add ekscloudwatch

What type of PR is this?
Enhancement
/kind feature

Any specific area of the project related to this PR?
/area falco-chart
What this PR does / why we need it:
Includes ekscloudwatch as a deployment.
Which issue(s) this PR fixes:
Approaches native functionality on eks.

[ ] Chart Version bumped
[X] Variables are documented in the README.md
[x] CHANGELOG.md updated

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

009e8bb add ekscloudwatch

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign nestorsalceda
You can assign the PR to them by writing /assign @nestorsalceda in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

falco/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @dza89! It looks like this is your first PR to falcosecurity/charts 🎉

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

34633e0 Update README.md

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

falco/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

34633e0 Update README.md
8c43a37 Update CHANGELOG.md

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dza89: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

34633e0 Update README.md
8c43a37 Update CHANGELOG.md

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@leogr
Thanks. Sorry fixed.
My input: ekscloudwatch is an extension of Falco, and cannot live on it's own, so should be it in the same helm chart.
I also don't understand why falco-exporter is in a different chart and not a side container within the falco helm chart for the same reason. Deploying it seperately introduces an extra (unneccesary) risk. (Volume mounting a hostfilepath)

Thank you, @dza89 !
There're several reasons why falco-exporter (and others, we will soon get falcosidekick here too) are distinct charts. IMHO, it's mainly a matter of maintainability and modularity. For example, the Falco chart is already too cumbersome to get the full official support (as per our convention) because of all embedded integrations that are hard to test and maintain. But, there're cons too. As always, it's a trade-off.
Moreover, the community could raise other concerns about this integration. AFAIK sysdiglabs/k8sauditlogforwarder is not maintained by the Falco project, does not seem to be documented, and I haven't found the source code of that image. Perhaps, do you know where I can see the sources?
That being said, I can understand your point, and I will not disagree if maintainers want to merge this.
I'm just trying to be a bit scrupulous before including a new thing in the chart :)

Ah ok, I thought sysdiglabs and falcosecurity were practically the same thing :)
Personally I don't mind a big helm chart (until it becomes prometheus-operator)
And you do need this to have falco fully functioning on EKS. So perhaps a cloudprovider piece which you refrain from testing. (?)
Source:
https://github.com/sysdiglabs/ekscloudwatch

/cc @nibalizer
/cc @kris-nova

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

eb523cb add grafana dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dza89: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Hey @dza89
I have seen your commit https://github.com/falcosecurity/charts/pull/63/commits/eb523cbb308d57838fa661180ca66b8fcd346431 that introduces the grafana dashboard for falco-exporter, anyway I believe this feature should be introduced in a different PR and not here (since it affects a different chart and is not directly related to ekscloudwatch).

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by:
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Positions of removed securities are always liquidated during rebalance even with active insights

Expected Behavior
In the PortfolioConstructionModel class, the CreateTargets method should only create a flatten target for securities that are removed from the universe when we want to liquidate removed securities, i.g., their insights expired.
Actual Behavior

If rebalance is required (for whatever reason), CreateTargets always creates a flatten target for securities that are removed from the universe (even if the insights are still active on those securities).
The issue is that inside the CreateTargets method, once IsRebalanceDue[source] returns true for whatever reason, rebalance will set in and these lines [source] will always be executed to liquidate removed securities, even if RebalanceOnSecurityChanges is False.
Potential Solution

My solution is to add RebalanceOnSecurityChanges as a condition to this line. Please refer to my fork here:
# if RebalanceOnSecurityChanges is False, we can continue rebalance and let the insight
# period on those removed securities to determine whether they should be liquidated or not
if (_removedSymbols != null && RebalanceOnSecurityChanges)
{
var universeDeselectionTargets = _removedSymbols.Select(symbol => new PortfolioTarget(symbol, 0));
targets.AddRange(universeDeselectionTargets);
_removedSymbols = null;
}

RebalanceOnSecurityChanges is True by default, so a position will be liquidated by default if the security is removed from the universe. With this solution, if RebalanceOnSecurityChanges is set to False, the rebalance process is no longer liquidating a position just because the security is removed from the universe (liquidation might still happen later during the rebalance process, if insight expires).
Reproducing the Problem

The following algorithm reproduces the issue:
class badSell(QCAlgorithm):

    def Initialize(self):
        self.SetStartDate(2021, 5, 20)
        self.SetEndDate(2021, 5, 22)
        self.SetCash(100000)
        self.Settings.RebalancePortfolioOnSecurityChanges = False

        self.AddUniverse(self.coarse)
        self.UniverseSettings.Resolution = Resolution.Daily

        self.SetAlpha(ConstantAlphaModel(InsightType.Price, InsightDirection.Up, timedelta(days=2))
        )

        self.SetPortfolioConstruction( EqualWeightingPortfolioConstructionModel(lambda time: None) )

        self.SetExecution(ImmediateExecutionModel() )

        tickers = ['SPY', 'AMZN']
        self.symbols = [Symbol.Create(ticker, SecurityType.Equity, Market.USA) for ticker in tickers]

        self.calls = 0

    def coarse(self, coarse):
        if self.calls == 0:
            self.calls += 1
            # return SPY
            return [self.symbols[0]]
        elif self.calls == 1:
            self.calls -= 1
            # return amazon and SPY is liquidated
            return [self.symbols[1]]

In the algorithm,

SPY and AMZN is taking turns to be included in the universe, so securities are being added and removed.
insight lasts for 2 days
RebalancePortfolioOnSecurityChanges is set to False and daily automatic rebalance is turned off by lambda time: None to make sure we are rebalancing only because there is a new insight on every other day and NOT because one of the securities is removed from the universe.
Nevertheless, the arrival of a new insight for AMZN triggers rebalance on the second day, so SPY was liquidated [source] even if its 2-day insight is still active.

System Information

Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

Moreover, the comment in this thread suggests that we need to do the following to make sure positions are not liquidates on removed securities:
self.Settings.RebalancePortfolioOnSecurityChanges = False
self.SetPortfolioConstruction( EqualWeightingPortfolioConstructionModel(lambda time: None) ) # not good

The fact that we need to turn off rebalance (second line) is not desirable because we may still want to rebalance daily to achieve an ideal portfolio weight.
With this issue fixed, only self.Settings.RebalancePortfolioOnSecurityChanges = False is needed and we can still rebalance our portfolio however we want.

Behavior adjusted by custom PCM, overriding the settings as you've shown.
Not sure its really a bug if its removed from the universe could argue it shouldn't be traded.


Loading editor: initial text is black on black

VSCode Version: 1.9 insiders
OS Version: macOS

Steps to Reproduce:

reload window with dark theme
pay attention to the editor text

=> it shows as black on dark background

@aeschli @bpasero The theme service needs to help me out here. I call themeService.getColorThemeDocument(). That one is null until the theme is fully loaded. Perhaps the theme service could know if a dark or white theme is being loaded very quickly and provide a corresponding "fake" theme document until the real theme document is loaded.

fyi @egamma This is the bug you mentioned.


No margin to the left of the right menu item

Provide the exact quote of the error or issue
No margin to the left of the right menu item.

Does the docs page already exist? Please link to it.
No response
Are you willing to participate in fixing this issue and create a pull request with the fix?
None

Related #2600


Microsoft.Extensions.Configuration (ver 3.1.18) updated to be compatable with new version of IConfiguration

Contact Details
<EMAIL_ADDRESS>Version
8.x
On which operating system(s) are you experiencing the issue?
Windows
Using which broker(s) did you encounter the issue?
RabbitMQ
What are the steps required to reproduce the issue?
1.Created a new project that used Microsoft.Extensions.Configuration namespace for IConfiguration  (package installed Microsoft.Extensions.Configuration.Binder ver 7.0.0)  (All projects in .Net 7)
2.Installed in an existing project that is using MassTransist ver 8.0.9
3.Received error that there was a conflict in versions of Microsoft.Extensions.Configuration.Abstractions - version <IP_ADDRESS> and <IP_ADDRESS> in added package.
4.Found it was conflicting with MassTransit.  I installed Microsoft.extensions.diagnostics.HealthChecks which resolved this issue and brought other packages forward to most recent versions.
...

What is the expected behavior?
Some underlying packages need to be update to be compatible with other packages.
What actually happened?
Packages a level 3.1.18 need to be updated
Related log output, including any exceptions
No response
Link to repository that demonstrates/reproduces the issue
No response

Hi Chis,
Installing MassTransit 8.0.9, it uses several packages that are older version.
@.***
I added a .dll to one of my projects that was using Microsoft.Extensons.Configurations ver 7.0.0.  I starting getting version incompatibility errors, as noted in my post.
It took me awhile to track down the problem.  So, I thought that MassTransist should be using latest versions.
Thanks,
Bruce
From: Chris Patterson @.>
Sent: Monday, December 12, 2022 11:34 AM
To: MassTransit/MassTransit @.>
Cc: Bruce Haskell @.>; Author @.>
Subject: Re: [MassTransit/MassTransit] Microsoft.Extensions.Configuration (ver 3.1.18) updated to be compatable with new version of IConfiguration (Issue #3937)
Okay, so why is this an issue with MassTransit?

Reply to this email directly, view it on GitHubhttps://protect-us.mimecast.com/s/7kGuCzpzqVHG11Ou4x6HH?domain=github.com, or unsubscribehttps://protect-us.mimecast.com/s/DoWTCADl8jfZQQGt8C5Q6?domain=github.com.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

I understand.  Maybe I had an edge case because I was adding via a .dll.  Unfortunately, it just took be a long time to ferret out the problem.
From: Chris Patterson @.>
Sent: Monday, December 12, 2022 12:35 PM
To: MassTransit/MassTransit @.>
Cc: Bruce Haskell @.>; Author @.>
Subject: Re: [MassTransit/MassTransit] Microsoft.Extensions.Configuration (ver 3.1.18) updated to be compatable with new version of IConfiguration (Issue #3937)
I get that, but MassTransit targets multiple frameworks so it isn't reasonable to target say v7.0 when netstandard2.0 is still supported.
—
Reply to this email directly, view it on GitHubhttps://protect-us.mimecast.com/s/sTFLCNkB7QUZWLAIm2iHH?domain=github.com, or unsubscribehttps://protect-us.mimecast.com/s/VrxBCOYDJVCN8YJiv4dbG?domain=github.com.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>


⚠ Bofrost.at has degraded performance

In 835d324, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1181 ms

Resolved: Bofrost.at performance has improved in 06ee54f after 34 minutes.


completed adding remark command

The adding remark comment is just for the tutorial, will close the PR since thats not a feature we want to implement for now. If in the future we decide it will be a good feature to have, can always PR again.


change origin

Similarly, I'm not sure if this is intended, but have you considered renaming the origin remote to be downstream rather than simply writing over it. That way if there are feature updates to the cloned site, you can merge them more easily. Just a thought.

https://github.com/18F/microsite-18f/pull/1#issuecomment-72473535
cc @vzvenyach

This is not quite right. What the script is doing is creating a remote named origin that points to the user's repo. origin is the correct name for a remote that you own and where you push your own changes.
To be able to pull in and merge feature updates from this 18F repo that the user cloned, what needs to be done is to create a new remote called upstream that points to https://github.com/18F/microsite-18f.

Then, if the user wants to get the latest updates from this repo, they can follow these steps:

Create a new branch called upstream-updates
git fetch upstream
git merge upstream/master
Merge any conflicts if necessary and make any other changes.
Stage the changes in git and commit them
Push the changes to origin and create a Pull Request: git push origin upstream-updates (or they can merge directly to their master branch if they don't need or have anyone to review their code).

Here are relevant GitHub Help articles:
https://help.github.com/articles/syncing-a-fork/
https://help.github.com/articles/configuring-a-remote-for-a-fork/
https://help.github.com/articles/pushing-to-a-remote/


Update code-of-conduct.html

Margin-ised

@simonmcmanus did bootstrap get removed?
please advise on this PR


any samples to enable private to true

In part of
custom:
  stage: ${opt:stage, self:provider.stage}
  func_prefix: ${self:service}-${self:custom.stage}
  private: false # Change to 'true' if you don't want to publish Dashboard

After enable private to true, could you please provide some samples on how to set the api keys:
   apiKeys:
     - some-api-key-name   # ???

What should I adjust when accessing the endpoint? How does the new curl url look like?

I can answer my own question:
https://serverless.com/framework/docs/providers/aws/events/apigateway/
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-apikey.html
curl  `-H "x-api-key: HmClkBybt69H1WsNXUta52sgdLfMy5jK5brwVxGu`   https://xxxxxxxxx.execute-api.ap-northeast-1.amazonaws.com/dev/sites


Updated Distribution Licence

Close, but look carefully. This pull request isn't based on current 5_x-prod. You have included two other unrelated commits.


Add option to disable bits

Allow disable of BITS.

Part of #179 so closing #179

Edit floppy\_packer_config.cmd:
:: Uncomment the following to disable BITS so scripts can fail instead of hanging when
:: BITS doesn't work right.
:: Default: (unset)
:: set DISABLE_BITS=1

I don't see any issues with this, it works for me, and I hate BITSADMIN anyways.
Thanks for your contribution!


Implement SetAdd hint

Fixes #246
Will move from draft to open PR once builtin's issue is fixed in a different PR.

Btw this has some conflicts


Drift detection

I think it would be good to have a discussion about how we want to handle drift detection. There are different kinds of drift (performance of a model, feature distribution...). Here is an academic survey. We should probably start to define what cases we want to handle, and then define an API. From what I have gleaned practitioners would first and foremost be interested by a simple way to monitor the performance of a model and receive alerts whenever the performance drops "significantly".
This is going to require a bit of research and foresight before actually implementing something concrete.

What's the status on this?

Well I know what to do, but we're actually looking at merging with another online machine learning library that already does this. Things should be moving in the upcoming summer.

Added this to the icebox.


Notification, Windows

Under the windows notification bring QT wallet on the top. As a result it is problematic to work with any other app except QT wallet.
@jbyrer , please check how nightly works now under the windows. I am going to keep notifications for release, but I am really not sure how that freak people out.  Please check the version and let me know what do you think. We can disable that for Windows.
Currently by default notifications are active.

Notifications are disable for Windows. See commit above.

It is released

It is released


a bit misleading ..

This strategy is working for Azure, I got that. But to diss gitflow - an arguably far more popular branching strategy - is unnecessary and misleading: (1) I don't think anyone ever advocated "testing in production" - see Vince Driessen's original article https://nvie.com/posts/a-successful-git-branching-model/ - and 'release' branches.  (2) Author states "our branching strategy looks like a typical trunk-based development model" - yes it does looks like TFVC legacy, taking little advantage of the scope of functionality of distributed vc. (3)  "After merge, we run additional acceptance tests that take more time to run." - and if tests fail at this point? What, now you have a broken master. There should not be any need for testing of changes being merged into master.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d1235ec4-e7e9-b0c2-8f1f-ee9682175a05
Version Independent ID: a473750a-fbb6-4eed-e0e6-34e8a5009507
Content: Release Flow - Azure DevOps
Content Source: https://mseng.visualstudio.com/DefaultCollection/TechnicalContent/_git/devops-learn-pr?path=%2fdocs%2fdevops-at-microsoft%2frelease-flow.md&version=GBlive&_a=contents
Product: devops
Technology: devops-learn
Git Login: samgu
Microsoft Alias: ethomson

My first thought was this sounds a lot like GitFlow, with the branches names changed (master instead of develop, and releases instead of master), and some pull request magic tacked on..
Btw Edward compared to GitHub Flow, not GitFlow. It certainly a bit misleading to compare to GitHub Flow, as what they're doing is much closer to GitFlow than GitHub Flow. It's like comparing apples to oranges, instead of one type of apple to another type of apple.
This sentence alone screams to me that the branches are not named very well: "we continue developing in our master branch". Developing in our master branch??? Surely developing in our development branch makes a lot more sense. The master branch is usually the latest compilable code, and what is usually gets deployed. GitFlow also has release branches (based off of master), as well as hotfix branches (also based off of master). Both of those branches are automatically then merged back into both master and develop during the "finish" operation of releases and hotfixes.

@papiermache

But to diss gitflow ... is unnecessary and misleading

The article does not mention GitFlow, but instead GitHub Flow, a simple feature branching pull request strategy. Also, lets not be so sensitive... suggesting another way to use git doesn't mean the author is dissing anything.
@papiermache

I don't think anyone ever advocated "testing in production"

That's actually exactly what GitHub flow, which the author was referencing, advocates:
https://guides.github.com/introduction/flow/
@yannduran

This sentence alone screams to me that the branches are not named very well. Developing in our master branch??? Surely developing in our develop branch makes a lot more sense.

Then rename master to develop and don't have a master. Release flow only has the 1 branch, so I don't really see the problem here other than arguing semantics. You could call it whatever you wanted.
@yannduran

The master branch ... is usually what gets deployed.

Sure, maybe in other branching strategies, but that is strictly not true for this strategy. master contains code for the next release, not what's in the current release. If you're looking for what gets deployed, look at the current release/ branch.


Add a note about disabled challenges in containerized env

Description

Hi! I spent a lot of time troubleshooting, before figuring out that the Docker image has a safety feature enabled by default that disables some vulnerability. Also, finding the documentation about this hasn't been easy so I think it is worth mentioning it in the README. 😊
Resolved or fixed issue: none
Affirmation

[x] My code follows the CONTRIBUTING.md guidelines

There a section on this in the documentation (https://pwning.owasp-juice.shop/part1/challenges.html#potentially-dangerous-challenges) but much more importantly, this is mentioned in the running application itself via the Danger Zone tag...

...and also when turning on the Show unavailable filter on the Score Board...

...so I do not agree that this needs to get even more focus by adding a statement in the README.


doesn't build on ghc 7.10.3

Building hermit-<IP_ADDRESS>...
Preprocessing library hermit-<IP_ADDRESS>...
[ 1 of 69] Compiling HERMIT.Syntax    ( src/HERMIT/Syntax.hs, dist/build/HERMIT/Syntax.o )
[ 2 of 69] Compiling HERMIT.Parser    ( dist/build/HERMIT/Parser.hs, dist/build/HERMIT/Parser.o )
[ 3 of 69] Compiling HERMIT.GHC.Typechecker ( src/HERMIT/GHC/Typechecker.hs, dist/build/HERMIT/GHC/Typechecker.o )

src/HERMIT/GHC/Typechecker.hs:151:34:
    Couldn't match expected type ‘RealSrcSpan’
                with actual type ‘SrcSpan’
    In the ‘tcl_loc’ field of a record
    In the expression:
      TcLclEnv
        {tcl_errs = errs_var,
         tcl_loc = mkGeneralSrcSpan (fsLit "Top level"), tcl_ctxt = [],
         tcl_rdr = emptyLocalRdrEnv, tcl_th_ctxt = topStage,
         tcl_th_bndrs = emptyNameEnv, tcl_arrow_ctxt = NoArrowCtxt,
         tcl_env = emptyNameEnv, tcl_bndrs = [], tcl_tidy = emptyTidyEnv,
         tcl_tyvars = tvs_var, tcl_lie = lie_var, tcl_tclvl = topTcLevel}
Updating documentation index

Thanks for noticing that, @cartazio. The Hackage version of hermit hasn't been updated since GHC 7.10.1, and GHC 7.10.2 made some pretty important changes involving TcLclEnv (to allow threading of CallStack information, IIRC).
@xich, do you think the current state of hermit is ready for another Hackage release? I'd do so myself, but I'm not in the maintainer group at the moment.

@RyanGlScott Yes, we should do a release (<IP_ADDRESS>) for 7.10.3.
There are still some outstanding issues to solve for GHC 8, so if you do a release (I added you to the maintainer group, but don't feel obligated), please constrain the version of the 'ghc' package to '== 7.10.3'. (7.10.1 and 7.10.2 were broken anyway.)
If you don't release it, I can probably find some time later tonight.
@cartazio Thanks for pointing it out!

sweet!
I've never used hermit, but since some of the changes in 7.10.3 were aimed at making sure fusion (and hermit) worked, I figured I should try it out!
(also figured i should learn this whole rewrite based vocab engineering thingy)

Uploaded hermit-1.0.1 to Hackage. Please reopen if there are any other installation issues.

seems to build! I still need to try things out and stuff, but it installed!


Terminal Port(s)

Not sure if this is an issue or not, maybe somebody could create a wiki to track all the ports of this amazing theme to different tools / platforms.
I created an (imperfect) Windows Terminal port of the theme.
https://github.com/ellman121/Ariake-Dark-Windows-Terminal-Theme
Enjoy!

Update: I also created a mac terminal version

Update: I also created a mac terminal version


UID 1000

I have read the other forums about this but i need exact instructions because i'm a noob. It works with LXDE, i want to fix it for desktop environment Xfce its always says
Mounting....
uid 1000 error
UnMounting....
Btw can someone tell me how to install the unity desktop to my pin drive please.

It works with LXDE

Does that mean you have a working chroot using the lxde desktop?

i want to fix it for desktop environment Xfce its always says...uid 1000 error...

It looks like the installation didn't finish. It'd probably be best to delete it and start over - or, add the xfce target to your chroot with lxde.

Btw can someone tell me how to install the unity desktop to my pin drive please.

Use crouton's '-p' option to specify where you want to install it, something like:
sudo sh ~/Downloads/crouton -r trusty -t xfce,extension,keyboard -p /path/to/pindrive/

No, i keep try to I re-install fxce but it always keeps saying Uid 1000.
I need to format the pin drive for it to install but idk how to.

It looks like the installation didn't finish. It'd probably be best to delete it and start over - or, add the xfce target to your chroot with lxde.

No, i keep try to I re-install fxce but it always keeps saying Uid 1000.

You might want to try the 'trusty' release instead of 'precise', use '-r trusty' when intalling.

I need to format the pin drive for it to install but idk how to.

Take a look at this thread for instructions, substituting sdb2 with your media device: https://github.com/dnschneid/crouton/issues/1515#issuecomment-83831807

Yes i keep on trying to re install it and delete it and i'm using
sudo ~/Downloads/crouton -t trusty -r xfce

I have tried other supported ones with xfce but it keeps getting an error saying
Uid 1000
when i try to mount it.

I'm just going to use LXDE and move it to my pin drive so i have extra space programs.
But i was wondering can i install windows 10 iso file to a pin drive and mount it and install windows 10 on
here. USB booting through the bios does not work because i"m using a Acer 11 BIII

Forget the windows 10 part its just stupid. But i wanna say thanks ill see if a can get the lxde to the Pin Drive.

Yes i keep on trying to re install it and delete it and i'm using
sudo ~/Downloads/crouton -t trusty -r xfce

If that's what you actually entered (I doubt it), it should give you an error right away.
The options are turned around, it should be: sudo sh ~/Downloads/crouton -r trusty -t xfce

I have tried other supported ones with xfce but it keeps getting an error saying
Uid 1000
when i try to mount it.

Then I would try lxde or another target besides xfce.

But i was wondering can i install windows 10 iso file to a pin drive and mount it and install windows 10 on here.

Nope.

My problem is solved i'm just going to install LXDE to a pin drive and just use it.

That sounds like a very good solution, I use a trusty/lxde-desktop about 90% of the time.


Support checking the bulk export job status

User story
As a user, I want to check the status of the bulk export job status.
The job status location will be in the form of [base]/_operations/export/{id}. To avoid being mixed up with the valid resources, we will use name _operations to distinguish the endpoint. The FHIR spec constrains the resource name to start with capitalized letter from A-Z so using a name that starts with underscore should be okay.
Acceptance criteria

Verify 404 Not Found is returned if the job does not exist.
Verify 202 Accepted is returned if the job exists and is pending or in-progress.
Verify 200 OK is returned if the job exists and is completed.
Verify 500 Internal Server Error is returned if the API cannot get the job from database.
Verify the response payload is in JSON format.
Verify transactionTime property is returned with the timestamp of when the job was queued.
Verify request property is returned with the URL used to queue the job.
Verify output property and error property are both empty arrays.

Moved tracking of user story level items to Azure DevOps.


feature request: min length, max length, and whitespace trimming

The .String() type is versatile, but often it is more permissive than we want. For example, some flags might have a maximum or minimum length. Minimum length is not naturally expressed with .Required() as that implies a minimum length of 1 and does not trim whitespace.
Suggestion: Add some modifiers to FlagClause such as:
a. MinLength to enforce a min length
b. MaxLength to enforce a max length
c. Trimmed to always whitespace-trim the flag before processing
Using custom flag.Value types doesn't appear to be an elegant solution to this problem because:

they are awkward to chain, leading to a proliferation of flag-specific flag.Value implementations
errors returned by .Set are not displayed by kingpin with the flag name prefixed, which makes implementation of useful error messages awkward. For example, a return fmt.Errorf("max length of %d exceeded", m.maxLength) from a flag.Value .Set() prints

progname: error: max length of 24 exceeded, try --help

It would be nice if this also contained the name of the flag that was being validated.
If I misunderstood how Kingpin is to be used, please send me in the right direction. I see v1.3.4 added "Add post-app and post-cmd validation hooks. This allows arbitrary validation to be added." but I couldn't find any examples or additional docs on this.
Thanks!

After additional investigation, it looks like .Action(), .PreAction(), and .Validate() methods are also inappropriate for applying custom validation to user-provided strings because the actual string value is awkward to extract from the data structures made available to those methods. The Validate API allows identifying a FlagClause by name, though the Action API requires searching over c.Elements manually. In both cases, retrieving the actual value is impossible because .value is not exported and there is no getter. Am I missing something?
Thanks!

Hi there. Yes, the actions and Validate methods were poorly thought out. Fixing that is the first item in the v3 wish list (#90).
I don't think adding functions for specific types of validation is the right approach though, but fixing the Validate functions is.
I've added a link to this issue for details.
Thanks for the report.

the actual string value is awkward to extract from the data structures made available to those methods. The Validate API allows identifying a FlagClause by name, though the Action API requires searching over c.Elements manually. In both cases, retrieving the actual value is impossible because .value is not exported and there is no getter.

I've had the same thoughts when trying to figure out how to use these, I'm glad it's not just me 😄  For instance, where does the error that my Action returns go/how is it handled, and how can I actually get at values with Validate? There were no unit tests or examples added for Validate to shed light.
I'll look forward to v3 for these 😄


Automatic persisted query hashes are not computed on the actual query being issued

Describe the bug
Query hash is being computed on a formatted version of the query, not the original query actually issued.
To Reproduce
Steps to reproduce the behavior:
# 1. issue query with correct sha hash:
curl -g 'http://localhost:5000/graphql/?query={__typename}&extensions={"persistedQuery":{"version":1,"sha256Hash":"ecf4edb46db40b5132295c0291d62fb65d6759a9eedfa4d5d612dd5ec54a6b38"}}'

# 2. re-issue query, note it's not cached:
curl -g 'http://localhost:5000/graphql/?extensions={"persistedQuery":{"version":1,"sha256Hash":"ecf4edb46db40b5132295c0291d62fb65d6759a9eedfa4d5d612dd5ec54a6b38"}}'

# 3. issue same query with normalized hash based on "{ __typename }"
curl -g 'http://localhost:5000/graphql/?query={__typename}&extensions={"persistedQuery":{"version":1,"sha256Hash":"7f56e67dd21ab3f30d1ff8b7bed08893f0a0db86449836189b361dd1e56ddb4b"}}'

# 4. query for persisted value, note it is cached
curl -g 'http://localhost:5000/graphql/?extensions={"persistedQuery":{"version":1,"sha256Hash":"7f56e67dd21ab3f30d1ff8b7bed08893f0a0db86449836189b361dd1e56ddb4b"}}'

Expected behavior
sha256Hash should be computed based on the actual query passed in, without any reformatting.
Desktop (please complete the following information):

OS: Windows 10
Version 11.0.9

Additional context
Unclear if it's related to #2759

I put it on the next release backlog. If it is a quick win we will fix it for 11.1 if not it will be in the first previews of version 12.

I can confirm this issue.

This one is fixed.


Empty files generated for RNA with bam2Mtx2

Hi,
I am running the pipeline with data downloaded from GEO. The former steps run well, and I got sorted, duplication removed bam files. However, when I run the last step, "reachtools bam2Mtx2 ${s}_sorted_rmdup.bam ${mm10_rna}", it runs without any error. However, the generated files are all empty.
Do you have any idea about what might lead to this problem?
The fa files was downloaded from https://hgdownload.soe.ucsc.edu/goldenPath/mm10/bigZips/mm10.fa.gz
gtf file was downloaded from https://hgdownload.soe.ucsc.edu/goldenPath/mm10/bigZips/genes/mm10.ensGene.gtf.gz
Then index was generated with code
STAR --runMode genomeGenerate
--runThreadN 40
--genomeDir ./mm10_STAR
--genomeFastaFiles mm10.fa
--sjdbGTFfile mm10.ensGene.gtf
--sjdbOverhang 75

Also, I wonder how can barcodes.tsv, genes.tsv, and matrix.mtx generated by DNA sequencing be converted to a format that can be used in snapATAC?

Hi @yoshihiko1218,
As mentioned in the readme file, variables in the scripts will need to be modified according to your environment. Could you check this shell script: have you changed all the variables as indicated in the file? Particularly, the "path-to-your-mm10-annotation-reference" to where you put your gene annotation reference file. The converted mm10 annotation file is available here.
Once finished, the output will be a standard Matrix Market format. For how to load the datasets in a standard Matrix Market format to other packages, please contact the package developers.


Added assets, animations for tours

Would it be cleaner to have different animation listeners rather than use the duration to distinguish between them?

I had considered that, but I'd end up having to make 4 listeners for the MapFragment, which would just be a lot of extra boilerplate code. The duration check was the best way I could find of identifying each animation without having to use a bunch of booleans or multiple listeners

Fair enough


Android - Bank - Inconsistency in showing "https" in company website section

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4426492
Issue reported by: Applause - Internal Team
Action Performed:

Launch app
Login with gmail
Tap on profile --- Workspaces --- Workspace
Tap bank ---Update to USD
Tap continue with plaid
Complete the chase Bank flow with plaid savings ending 1111
Enter all required information
In Business information page, in company website section, delete the text https://
Tap app back button
Tap next
Note https://
is not shown
Tap app back button
Tap next
On revisiting page, note https://
is shown

Expected Result:
After clearing https://,
tapping app back button and visiting the company website page for first time https://
must be shown.
Actual Result:
After clearing https://,
tapping app back button and visiting the company website page for first time https://
is not shown. Only on revisiting, the https://
is shown in company website page.
Workaround:
n/a
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/fe9b78c1-fbc9-436e-a549-e8d43b1a062f
View all open jobs on GitHub

@dylanexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

huh this feels like if you're choosing to delete the string, then when you come back having it still deleted sounds right, no? Confirming

asked internally


Prepare simple Kotlin Multiplatform app

To get started with app development on both platforms (iOS, Android) it makes sense to setup Kotlin Multiplatform in the project and build super simple application.
Link: https://kotlinlang.org/docs/multiplatform.html
The idea:

minimum working setup on both iOS, Android (simple app, single text field rendered)
setup includes simple test - to verify app starts fine

Done in: 1377c3c


Downloader.FileDownloaderType.PARALLEL doesn't support cloud locattion when using SAF

 private OkHttpDownloader getOkHttpDownloader() {
        return new OkHttpDownloader(okHttpClient, Downloader.FileDownloaderType.PARALLEL);
    }

 final FetchConfiguration fetchConfiguration = new FetchConfiguration.Builder(this)
                .enableLogging(BuildConfig.DEBUG)
                .setDownloadConcurrentLimit(3)
                .enableRetryOnNetworkGain(true)
                .enableAutoStart(false)
                .setAutoRetryMaxAttempts(10)
                .setProgressReportingInterval(1100)
                .setHttpDownloader(getOkHttpDownloader())
                .build();
        Fetch.Impl.setDefaultInstanceConfiguration(fetchConfiguration);

Fetch 3.1.1 AndroidX version.
When I try to download any file to cloud locations using SAF (Storage Access Framework) such as Google Drive, Box, etc, fetch returns UNKNOWN_IO_ERROR. But it works when using Downloader.FileDownloaderType.SEQUENTIAL.
I guess that it is the limitation of PARALLEL mode. But it would be great if the library does like below...
if (cloud_location)
   use_sequential_download_regardless_of_settings;
else
   use_default_fetch_config;

or can you give us the ability to change download type on the fly per download request?

@jpvs0101 What you can do is override the getRequestFileDownloaderType(request: ServerRequest, supportedFileDownloaderTypes: Set<Downloader.FileDownloaderType>): FileDownloaderType method on the Downloader and only return the FileDownloaderType.SEQUENTIAL type in the set. The download manager will use that information to download the request. In that method you can do checks on the url etc. Hope this helps.

Sorry, when I did several test with different versions of android, both emulator & real device, most of the time google drive not working! In Box, sometimes works, sometimes not works! No clear logs to trace the issue. You can always reproduce this issue! I can't get it what is going on...

I will have a chance to give this a try over the weekend.

@jpvs0101 I was able to pin point the error. java.io.FileNotFoundException: Unsupported mode: rw. Changed  context.contentResolver.openFileDescriptor(uri, "rw") to  context.contentResolver.openFileDescriptor(uri, "w") and it worked. The ContentProvider documentation does not have the updated modes. I was able to successfully use the Parallel downloader. Look out for the next release.

Awesome, you always rocks! Also please consider reducing permissions #284

@jpvs0101 had a look at issue #284 again. My position still stands. The library depends on the network state permissions defined to get network change notifications. It is actually the ConnectivityManager that require these permissions not the library.

@jpvs0101   new version of fetch is now available. See readme and changelog.

@jpvs0101 had a look at issue #284 again. My position still stands. The library depends on the network state permissions defined to get network change notifications. It is actually the ConnectivityManager that require these permissions not the library.

I understand that it was tightly coupled, but it would be great if we can use only android.permission.INTERNET & all other permissions are optional. So we can add permissions only if we use a particular feature.  You can even set internet permission as optional when we use only local files.
For example, in my case, i don't check whether the connectivity is on or off, or user using wifi or not. We just throw an error when no connectivity. Simple for users & developers. So other permissions are unnecessary. Users watch permissions very closely these days but most are don't know the difference between android.permission.INTERNET & android.permission.ACCESS_NETWORK_STATE. Some users thought that the app is spying on network state. Same for fetch notification broadcast receiver. I am not using it. But it has an entry in manifest.
I hope you aware of that Android Q removed storage permission. They are restricting permissions more & more. They already put restriction on wifi scanning. So may be they restrict access network/wifi state permission in future. It is better we can prepare now. Like i mention, logically this lib can work without a permission. You give us almost everything optional & extensible except these permissions. Hope it shows an overview of the situation. Thanks!

@jpvs0101 new version of fetch is now available. See readme and changelog.

Not working with Google Drive, but works with Box. I tried various platforms, sequential, parallel, preallocation. But none works with Google drive. It shows download complete, then upload complete, but the file in google drive shows 0 bytes. Logs are normal.

If it works with box and local storage the issue is then with gDrive. You may want to look at the documentation.

OK, it is weird, I close this issue for now, I will come back later!


consider to support -s and --relative-to as it does on linux

I'm looking for solution to provide realpath shim on macos to match the behavior as on linux.
I was going to make a cli package and did a name clash checking, then I saw your package :)

Done in https://github.com/sindresorhus/realpath/releases/tag/v3.0.0


Update github_actions_runner.md

Adding small details to help get through the runner setup more easily:

Additional instruction for runner app private key generation.

bors merge


Experimenting with conditional rendering

Description

Screenshots/GIFS

Reviewers

All React files should have the extension jsx to let developers immediately know that those are files containing JSX.  It also makes it easier for us to make more targeted webpack module tests.

@JacobPernell going to close this for now and we can reopen if we think it'll be worth merging.


Port Ranges

Now it is possible to use Ranges for ports as well.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@steinbrueckri Maybe we close this PR and open a new one to workaround the CLA sign issue.

Hi there! I'm trying to figure out if there's an objection to signing the CLA, or a technical issue in trying to do so. Please let me know if I can help. CC: @johnRiv

@kristakhare it's a technical issue. I would like to sign the CLA and get this PR merged, but i receive a request timeout if i click on "I Agree" at https://cla-assistant.io/Comcast/snowdrift?pullRequest=2.
I opened a issues on the cla-assistant repo in may without success 😢
https://github.com/cla-assistant/cla-assistant/issues/440

I see kunzese signed out CLA on 3/18/19... not sure why the tool isn't recognizing it for this PR, but we should be good to merge this

@JohnRiv if you can remove my old consent, i will be happy to sign it again.

The tool seems to be slow today & I'd rather get it in... @dmuth I'm OK with you just merging this if you're happy with the code. If you're unable to override CLA Assistant's block on this PR let me know and I'll merge it.

Sorry for the delay in getting on this, I've been thinking about how to go about building some testing so I can verify that the script continues to operate correctly.
I ended up writing https://github.com/Comcast/snowdrift/issues/3 to track development on building in some testing, with merging this PR as part of that Issue.
Do let me know if there are any questions, thanks!
-- Doug

Update: I've begun working on that branch.  My work can be followed in #3.
-- Doug

Hey @steinbrueckri, thanks for being so patient.  I just finished up my work in #3 and merged it to master.
  (Note: the test may fail on the first run due to the containers not having yet started yet, I have a note in TODO to address that.)
From here, I think may plan is to do the following:

Create another branch, and pull your changes in
Write tests for snowdrift based on your changes, and update test.sh accordingly.  (I will create additional Docker containers accordingly)

Once I've verified functionality, I'll merge to main and we should be good!
Let me know if you have any thoughts on that approach, otherwise I'll start on that this week.
Thanks,
-- Doug

Hi @dmuth,
thx for the update, that sounds like an plan. 👍🎉

Good news!  I'm pretty much done at this point with my testing-framework branch and have merged it into master.  When I work on Snowdrift next (this weekend/next week), I'll pull in your changes, write some tests for port ranges, and we'll be good to merge into master!
If you'd like to play around with the testing framework in the meantime, feel free to merge master into your branch.
-- Doug

Okay, this has been merged.  Thank you for your contributions, and sorry for the lengthy delay on my part.  I will add the updated script to https://github.com/Comcast/homebrew-opensource shortly.


Type annotation

Applied type annotations based on this issue https://github.com/larsvonschaff/Django-mockingbird/issues/3

Also maybe add mypy check to github ci. Also consider adding a linter, formatter etc to the pipeline.


possible race condition in strategy-driven scale_in resulting in killed tasks

Describe the bug
I haven't tried to recreate this, but I saw an error in CI that suggests this might happen sometimes: in CI a block was killed by scale_in when it was running a task.
The scale in strategy asks the interchange for a list of connected managers and idle times; it then makes a decision about which blocks to scale in based on those idle times, and individually calls hold_block on each one.
These hold block calls can take some time, as they involve an IPC to call hold_worker on each manager registered for each block.
During that time, other parts of htex may place a task onto one of the managers which is in the list to be scaled in; that task will then be killed after it has started execution when the containing block is killed.
To Reproduce
I haven't reproduced this - I think it's an extremely rare race condition that I've only seen once.
Expected behavior
strategy driven scale-in should not kill blocks which are executing tasks
Environment
CI for initial observation, around parsl master b26c04ffddd4c9b75fa1c08a7b8550185d888553

crossref the race condition in #2627

here's a related runinfo directory where I just saw something like this, in runinfo/022.
In this log, I think scale in is not being called, but tasks are ending up on a manager 362e761e0b8b which does not appear to belong to any of the 5 launched blocks (or at least has no log directory there), and which does not appear to belong to any earlier run either, and which dies from too many missing heartbeats 2 seconds after registering.
It has block id 0, along with another manager in the log which also has block id 0. This is suggestive that it's a manager coming from an earlier run that was not scaled in in time, and which connected to the wrong interchange.
runinfo-3.9.zip
In that case, this would be related to issue #2199 where a manager can connect to the wrong interchange.

I'm working on some worker draining code in PR #3063, and one approach to this issue might be to set workers to drain in one iteration, and then later only kill draining candidates which have full drained.


Convolution - Converting RGB Image from OpenCV Shape

I'm trying to shape my data correctly to pass to a convolution layer, but I keep getting the following error:

[14:50:27] src/operator/./convolution-inl.h:370: Check failed: ksize_y <= dshape[2] + 2 * param_.pad[0] && ksize_x <= dshape[3] + 2 * param_.pad[1] kernel size exceed input

The size of the training set is (7878, 256, 256, 3). The images have been loaded in via cv2 and had some operations prior to being added to the training set array.
The convolution layer is as follows:
conv1 = mx.symbol.Convolution(data=input_data, kernel=(11, 11), stride=(4, 4), num_filter=96)
Does the convolution layer have a different ordering of dimensions to the cv2 ordering?

I think the data shape should be (count, channel, height, width)

Thanks for the response. For reference, I used numpy's rollaxis as follows:
ex_img = numpy.rollaxis(ex_img, axis=2, start=0)
This managed to get the network training!

rollaxis is ok, but the more straight forward way is ex_img.transpose(2, 0, 1)


prefer_is_not - exclude method calls

Example: if not is_valid( ).

just method calls? I'd suggest it to exclude all short form IFs, supposed we move in this direction,
example
IF NOT lv_bool.

IF NOT lv_bool does not compile.

oh, okay 😄

try again, 2.48.4 published


Animation Tab Resizing Freezes Godot

Godot version
v4.0.beta12.official [3c9bf4bc2]
System information
Windows 10, Forward+, Intel Iris Xe Graphics
Issue description
When I resize the animation tab, there's a high chance of it freezing godot, for seemingly forever until i close godot. My project kept on freezing sometimes while resizing the animation tab. Beta 12 never crashed for me in any moment that wasn't me resizing the animation tab. It literally only happens when i'm resizing that tab, not always, but it feels like a 50/50 chance of freezing or not depending on how many seconds i'm taking to resize that tab.
Steps to reproduce
Use Forward+ and have a 3d model with animations, try to resize the animation tab for longer than 2 seconds. If it doesn't freeze godot the first time you resize that tab, try a few more times for longer than 2 seconds.
Minimal reproduction project
New folder.zip

Can't reproduce in beta 17.
Please attach a real MRP.

Can't reproduce in beta 17. Please attach a real MRP.

then that might means it was fixed in beta 17. Since i made this post using beta 12.
Also i ddin't include a real mvp because in the rules, it mentions that no need to include a mvp but i can't submit without including, which is why i did that.

You could've just written "N/A".
Like the text you highlighted said.
And while MRP can be sometimes irrelevant, not everyone has "a 3d model with animations" ready for testing (I don't).

then that might means it was fixed in beta 17.

Comment if it's otherwise.

You could've just written "N/A". Like the text you highlighted said. And while MRP can be sometimes irrelevant, not everyone has "a 3d model with animations" ready for testing (I don't).

then that might means it was fixed in beta 17.

Comment if it's otherwise.

Just tested, and i tried resizing the tab multiple times, it didn't crash, seems fixed. In beta 12 it was so frustrating lel

nevermind, it just crashed

it took longer than normal to crash though compared to beta 12, i had to resize it from it taking up most of the vertical screen, to it taking up little of the vertical screen constantly and eventually it froze godot, the same way that beta 12 did. Only difference is took more tries

oh also the animation wasn't playing when i was resizing it, just a small note

In beta 17, you have to resize it from very short to very big and vice versa, like 10 times before it freezes godot, in beta 12, it would freeze after maybe 2 tries

@Captainkittyca2 Please use the Edit button (located behind the … icon in the top-right corner of your comments) instead of multi-posting.

Why was this removed from 4.0 milestone? @KoBeWi

It was never in the milestone.
Seems like no one else was able to reproduce this issue so far.

How can you know whether or not it wasn't in a milestone after it as removed? i'm still getting used to github overall

Not sure if regular users can see the full history.

i can't see full history, no

only "modified"

But you can see it's the only milestone note here.

anyways, won't adding it to milestone make a developer actually test it out?
Because right now it's in the middle of nowehere

So as I said in my first comment, you need to attach a real MRP, i.e. any zip with a model with animations that can be used to test the issue. I just tested with a random AnimationPlayer and it works without any problems, so this can't be reliably reproduced.
And by "No one else was able to reproduce this issue so far." I meant any user. If the issue was common or critical or whatever, there would be some duplicates or comments or at least upvotes. There is no activity here, so it's clear no other user had this problem.

it's not as easy to reproduce in beta 17 and RCs as it is in beta 12
The reason why i wanted people to test in beta 12 first is to check if i'm only having this issue because of my PC version combined with version of godot 4 or if it's entirely because of godot 4
With beta 17 and onwards, it still occurs but it's much more uncommon. So it's hard for even you to come by it. Which is why if i can confirm that even you or others can get it in beta 12 after about 3 tries maybe, then that means you can probably even get it in beta 17 and onwards even if it's more uncommon in those.

As there aren't any other reports for this, and there isn't a reproduction project for us to test this against, I'm going to close this report. Please try 4.0 stable and if you experience an issue, open a new report with a proper reproduction project.
Also, please keep discussions about issues on topic, and edit your messages instead of multiposting. Both of these problems makes it very hard to contributors to help you and figure out what the actual information about the problem is.


YouTube video loading

Can this view automatically play YouTube videos by just providing the video url ?

No, but it is easy to implement in Android. Check this out:
https://github.com/youtube/yt-android-player


2.0.4版本报错

您好，更新到2.0.4后，进游戏右上角有红字。

Thanks for report. Please note that I don't speak Chinese so If you can please use English.

Should be fixed in v2.0.5

Sure. Thanks a lot.


GZDoom v4.12.2 with default Vulkan renderer for Legacy of Rust

Project Link
https://github.com/ZDoom/gzdoom/
Project License
GPL v3
Steam App Ids
https://steamdb.info/app/2280/
Additional Context
Latest release of GZDoom (v4.12.2) appears to run with Vulkan renderer as default that seems to be not affected by the following OpenGL issue. During the first 2 levels of Legacy of Rust, the game stayed between 240-260 mb ram usage, including level transitions.
https://gitlab.freedesktop.org/mesa/mesa/-/issues/9953
Latest release of GZDoom appears to rendering new Legacy of Rust enemies just fine. iwads and command;

doom2.wad (rerelease)
id1.wad
id1-res.wad
id1-weap.wad

gzdoom -iwad doom2.wad -file id1.wad id1-res.wad id1-weap.wad

This should be complete now, I've updated to gzdoom, forced vulkan. Let me know if you run into any issues.


Add python utility for lng format (HandyGames)

https://github.com/CakesTwix/pylng

Added!
Sorry for late reply.


Queries and MOTD Passthrough

Adds Queries
Removes MOTD from Passthrough
Adds online players to ping info for queries

Also removes version number from MOTD so it looks more like this

And Queries:

Manually pushed.


Let instant execution capture registered task outputs for stale outputs cleanup

This change lets instant execution capture registered task outputs for stale outputs cleanup, making task execution more reliable.
Capturing this forces the creation of registered clean tasks.

Thanks @wolfs!


[greatest] Update to 1.5.0

Describe the pull request

What does your PR fix?
Updates greatest to 1.5.0

Which triplets are supported/not supported? Have you updated the CI baseline?
As before, Yes

Does your PR follow the maintainer guide?

Yes

Update all the things :D


socket.io site is 502!

socket.io site is 502!

Same for me, thought I was all alone.

@danmw3  wating site admin ......

Sorry for the inconvenience.
It's back up now!


Security vulnerability in svg-baker-runtime dependency

Do you want to request a feature, report a bug or ask a question?
Question
Our vulnerability scanning has picked up a vulnerability in the merge-options package, which is a dependency of the svg-baker-runtime (CVE-2018-3752)
Is there a public GitHub repository where we can make PRs for this project? Or are there any plans to update this dependency?

I have the same question because the SVG sprite generated from this isn't a11y compliant and I'd like to make it pass accessibility with a PR.

This is also a dependency of svg-baker and posthtml-svg-mode packages

Fixed in<EMAIL_ADDRESS>please check


cordova plugin problem

Hello please i want to know which version of cordova cli you use to build tabris app because i have a problem with this cordova plugin(android snackbar)  and the guy who did this plugin says it needs cordova cli 6.3.0 for it to work

#1049

Thank you


rest: copy api folder in Dockerfile

Part of #126
Signed-off-by: Francesco Ilario<EMAIL_ADDRESS>

@sadlerap as those layer are in a temporary image just meant for building the binary I'd say it's good for now. I'd propose to merge this one and then have a separate PR in which we add the .dockerignore file. Would it be good?

@sadlerap as those layers are in a temporary image just meant for building the binary, I'd say it's good for now. I'd propose to merge this one and then have a separate PR in which we add the .dockerignore file. Would it be good?

Works for me, just something I noticed when reviewing this.


first run: autoclaim new_android reward and allow channel creation

Similar to the desktop/web version, we should consider doing this during the first run process. The email reward does not require rewards verification, but there are cases where it still may not be claimable (in that case, don't allow channel creation).

@akinwale this reward is now live: new_android - can be claimed without creating an email/account. Only for new users. Existing users that sign in, and haven't been reward verified(or are), can also claim it.

Also, keep in mind that some areas of the app check for a min balance of 0.1 LBC.
Should this also include channel creation on first run? Maybe nudge towards it?

Done. We don't nudge for channel creation but it's an easy process for users at points required: invites, publishing, and eventually comments.


Does this gem integrate with https://github.com/kendrikat/grape-swagger-ui ?

Better late than never:
It appears grape-swagger-ui is a different attempt at integrating grape and grape-swagger into a Rail project.  It also appears as though grape-swagger-ui hasn't been updated in a year and is currently only known to support Rails 3 based on it's README.
Nothing in grape-swagger-rails is written with the intent of being integrated with grape-swagger-ui to my knowledge.  If you had both gems active in a project, there may be unexpected collisions in logic.


The "properties" blade no longer exists (22/01/2020) on Subscription tab

The "properties" blade no longer exists (22/01/2020) on Subscription tab.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11cda2e8-81c4-ab6a-371e-73506948488f
Version Independent ID: f18c9bf9-a0e7-ea07-144b-c2c7cedc8b6b
Content: Classic subscription administrator roles, Azure RBAC roles, and Azure AD administrator roles
Content Source: articles/role-based-access-control/rbac-and-directory-admin-roles.md
Service: role-based-access-control
GitHub Login: @rolyon
Microsoft Alias: rolyon

I received this from Microsoft Support:

I am afraid to inform you that as per our Engineering team we have received response that by design that modern subscriptions don't have properties blade.

@truekonrads Thank you for posting your findings on this issue with the support engineering . We are now in the process of getting this document updated and I am working internally with the author. This should be updated in the next release cycle. I will update once the article is updated with content about modern subscriptions.
Thank you.

I can confirm that what was said here is NOT correct, as of February 7, 2023 the properties blade DOES exist; when it's missing the matter is related to orphaned subscription where the user does NOT have one of the key roles: service administrator or subscription administrator which are NOT assignable via AIM - they can only be transferred via the properties section with special click on top that says "change service admin" but of course it's the chicken and the egg - how can one initiate the transfer if one can not access the properties blade. Sadly support is completely oblivious to this and you end up in incoherent script hell - if anyone knows how to recover orphaned subscription at this stage - please share with us your solution. Thank you

I do not show properties for my pay as you go subscription.

Wondering if the Properties view for a Subscription requires elevated licensing like P1?  I do not have a P1 license.

@kimdav111 Good point; but NO it isn't the P1 - I have it and my properties had disappeared few months ago:


Docker: automatically build an image for inference

This is on top of #16.
Providing a docker image can save potential users the need to install dependencies to run the software.
The workflow provided in this PR automatically builds a docker image and can push it to a registry. On my fork, it gets pushed to ghcr.io/nrdg, but you'll have to change that to a registry on which you have push permissions.

I might accept this in the future, but for now I'm not too sure that I want a docker image for inference, mainly because I encourage people to use the FreeSurfer version for inference. But thanks anyway :)

Is there documentation somewhere about how to use this via Freesurfer? That
would be excellent!
On Thu, Nov 4, 2021 at 10:41 AM BBillot @.***> wrote:

I might accept this in the future, but for now I'm not too sure that I
want a docker image for inference, mainly because I encourage people to use
the FreeSurfer version for inference. But thanks anyway :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BBillot/SynthSeg/pull/17#issuecomment-961272605, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA46NUAK2HUILJW5FGBVZ3UKLAUBANCNFSM5G6RLQFA
.

Yes, I added the links in the readme few days ago :)


feat: add ability to add ConfigMap checksum as resource annotations

Note: draft change do not merge
One common practice that I have seen is adding the checksum of config map contents as annotations to workloads, so that when a config map is updated, the associated deployments can also get updated and bounced. This PR is an attempt to implement such functionality, though I am not sure about some aspects of this change and would appreciate some feedback.
Specific things that I'd like some feedback on:

Should we expose the checksum as a property on ConfigMap? For example cm.checksum. While the type of that property would need to be string, but in fact it needs to be Lazy that produces a string. I am not sure what the practice is for exposing a Lazy as a property on a construct.
Choosing to not expose the checksum outside the ConfigMap results in this awkward addChecksumTo() API. I'd appreciate any input on what would be a good API pattern for adding these checksum annotations.
I had to add a dependency on json-stable-stringify to make sure that hashes come out consistent. What are the opinions of this project on adding dependencies?

@wyvernzora

Should we expose the checksum as a property on ConfigMap?

No need. At least not right now.

Choosing to not expose the checksum outside the ConfigMap results in this awkward addChecksumTo()

Agree. But its ok.

I had to add a dependency on json-stable-stringify to make sure that hashes come out consistent. What are the opinions of this project on adding dependencies?

We try to avoid it, but also recognize sometimes it is needed. This seems like one of those times 👍

Please reconsider.


Add support for serializing to a BytesIO buffer

Hi GEOLib team,
As discussed in issue #69, i would like GEOLib to support BytesIO buffers for serialization. In this PR, I have modified the serialize functions on the models and serializers to both allow local file paths and BytesIO buffers.
These modifications are fully backwards compatible, so the old functionality is unchanged.
Let me know what you think?
closes #69

Will add some more tests later

@Mbweehuizen Looks good to me now, do you still want to add some more tests for the other models? If those are present I will merge it for you

@carloslubbers I will add some more tests for the other models. Incomming soon.

Tests added.

@carloslubbers I checking something, please hold merging for now.


Dockerize runner

Description
Allow the runner to be run within docker.
This works by considering a docker container as just being a host in its own right, by starting the container with a command such as  the following, we can provide all runtime dependencies needed by the runner (API key, access to dockerd, log writing).
docker run --rm -it --network system-tests_default -v "${PWD}"/.env:/app/.env -v /var/run/docker.sock:/var/run/docker.sock -v "${PWD}"/logs:/app/logs --name system-tests-runner system_tests/runner ./run.sh

Save for secrets, the image contains everything needed to be self-sufficient and is built thusly:
docker buildx build -f utils/build/docker/runner.Dockerfile -t system_tests/runner:latest .

If so desired (e.g quick development of tests), select folders can be overridden on a case by case basis just by adding the corresponding volumes:
docker run --rm -it -v "${PWD}"/tests:/app/tests -v "${PWD}"/parametric:/app/parametric -v "${PWD}"/utils:/app/utils

As of opening this PR, I did not update the tooling (build.sh + run.sh) to allow for these commands to be run.
Motivation
The runner now has the ability to run on the host, but this removed the option of running it within Docker, as all Docker supporting files regarding the runner have been removed and its container infrastructure revamped (the runner is now in charge of starting the containers, whereas previously it was handled outside of it by docker-compose).
While this host-running ability is useful for local development of system tests, having the ability to run the runner in Docker had multiple advantages:

easy cacheability of python dependences
easy reproducibility by pulling an image
running environment consistency
not having to install a specific python version

In addition, dd-trace-rb CI uses a docker-based build->run job order that minimizes build time and severely reduces its impact.
So with this PR we attempt to get the best of both worlds!
Additional notes

As of the opening of this PR, the runner is able to access the agent and weblog information:
================================================================================================================== test context ==================================================================================================================
Scenario: DEFAULT
Logs folder: ./logs
Library<EMAIL_ADDRESS>Agent: 7.43.1
libddwaf: <IP_ADDRESS>.0
Weblog variant: rack
Backend: datad0g.com
============================================================================================================== test session starts ===============================================================================================================
collected 348 items / 145 deselected / 203 selected
Executing weblog warmup...

Sadly it appears it fails to reach to the agent:
------------------------------------------------------------------------------------------------- generated xml file: /app/logs/reportJunit.xml --------------------------------------------------------------------------------------------------
======================================================================================================= 145 deselected in 64.06s (0:01:04) =======================================================================================================
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! _pytest.outcomes.Exit: http://localhost:8127/info never answered to healthcheck request !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Indeed, while it appears to be able to start the agent container, it fails to reach to it:
$ docker ps
CONTAINER ID   IMAGE                 COMMAND                 CREATED         STATUS                            PORTS                                          NAMES
b82c4b82f381   system_tests/agent    "/bin/entrypoint.sh"    7 seconds ago   Up 6 seconds (health: starting)   8125/udp, 8126/tcp, <IP_ADDRESS>:8127->8127/tcp   system-tests-agent
1adbad5ce645   system_tests/runner   "/bin/sh -c ./run.sh"   8 seconds ago   Up 7 seconds                                                                     xenodochial_lehmann

Since it manages to start the agent, I'm confident this can be made to work though. It might be failing because of the localhost things.

I now have this working locally with a few workarounds. Two main issues:

localhost (originating from port forward/expose) instead of container naming, similar case as for #1095
bind mounts giving an incorrect path when runner is containerized:

to logs folders for proxy and weblog
to source code in utils for proxy

Interestingly enough, when I attempted #1095 on my configuration (which has docker in an isolated VM) I assumed that the proxy code was running in the runner process, so there needed to be a docker->host communication to reach it... But it's in a container, so there's no need to know the host IP on the VM network. Therefore solving this one will make a VM-ized docker setup work as well.

I strongly recommend adding a CI using this setup

Agreed. I did not want to waste time doing it until I could validate that this is a workable path.

Since it manages to start the agent, I'm confident this can be made to work though. It might be failing because of the localhost things.

I slightly change the way healthcheck is done, rebasing your branch may solve that.

I slightly change the way healthcheck is done, rebasing your branch may solve that.

Ha, coincidentally I made significant improvements to that part, allowing more use cases to succeed. I'll see how to best resolve the conflicts.
May I ask why the use of curl now instead of python requests? (which I feel was better in some ways)

At this stage all test are passing, proceeding with git revert fbb03ac

In https://github.com/DataDog/system-tests/pull/1379/commits/bacec71449cd185c062efbd04b7942532fa147bf two cases seem to have been overlooked.

Inconsequential to this PR but I've seen this failure:
#9 6.908 Install args are --appsec-file /binaries/dd-appsec-php-amd64.tar.gz --tracer-version latest
#9 6.923 Searching for available php binaries, this operation might take a while.
#9 7.050 ERROR: Could not find latest release for dd-trace-php in GitHub API response.
#9 7.050 URL: https://api.github.com/repos/Datadog/dd-trace-php/releases/latest
#9 7.050 Full response follows:
#9 7.050 {"message":"API rate limit exceeded for <IP_ADDRESS>. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}
#9 7.050
#9 ERROR: executor failed running [/bin/sh -c /tmp/php/apache-mod/build.sh]: exit code: 1
------
 > [ 5/10] RUN /tmp/php/apache-mod/build.sh:
6.676 Setting up dumb-init (1.2.5) ...
6.679 Processing triggers for man-db (2.9.4-2) ...
0 48871    0     0  1767k      0 --:--:-- --:--:-- --:--:-- 1767k
6.908 Install args are --appsec-file /binaries/dd-appsec-php-amd64.tar.gz --tracer-version latest
6.923 Searching for available php binaries, this operation might take a while.
7.050 ERROR: Could not find latest release for dd-trace-php in GitHub API response.
7.050 URL: https://api.github.com/repos/Datadog/dd-trace-php/releases/latest
7.050 Full response follows:
7.050 {"message":"API rate limit exceeded for <IP_ADDRESS>. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}

Maybe worth it to have authentication towards GH API for these fetches?

All green again! Pushing one last change to reinstate the proxy code volume mount.

@cbeauchesne I've asked @GustavoCaso to do a local test run tomorrow to confirm it all works in another local environment than mine, and we should be good (unless you see anything else)

@GustavoCaso reported one issue with macOS's default bash:
$ /bin/bash --version
GNU bash, version 3.2.57(1)-release (arm64-apple-darwin22)
Copyright (C) 2007 Free Software Foundation, Inc.
$ /bin/bash run.sh
run.sh: line 271: libraries[@]: unbound variable

Which is a lie because it's bound and set, and I can't seem to reproduce it in a smaller setting:
#!/usr/bin/env bash

function main() {
    local scenarios=()
    local libraries=()

    IFS=',' read -r -a libraries <<< "${TEST_LIBRARY:-}"

    scenarios+=('foo')

    while [[ "$#" -gt 0 ]]; do
        libraries+=("$1")
        shift
    done

    for i in "${!scenarios[@]}"; do
      for library in "${libraries[@]}"; do
          echo "${library}"
      done
    done
}

main "$@"

gives:
~> env TEST_LIBRARY=foo,bar /bin/bash foo.sh abc def
foo
bar
abc
def
~> env TEST_LIBRARY=foo,bar /bin/bash foo.sh
foo
bar
~> /bin/bash foo.sh abc def
abc
def
~> env TEST_LIBRARY='' /bin/bash foo.sh abc def
abc
def
~> /bin/bash foo.sh
~>

Still, I'll find what bash 3's big idea is here and fix it.

Merged main in, resolved conflicts:

Folded https://github.com/DataDog/system-tests/commit/81ec2fc082004a6e1e6063dcbd9bc9db8b3eda1b in the yaml file
That one appears to be a hack, as <IP_ADDRESS> as a source has at best peculiar behaviour and at worst is not routable at all. Really the previous external healthckeck was better, as it tested external reachability from the runner, which is what we want to ensure.

That one appears to be a hack, as <IP_ADDRESS> as a source has at best peculiar behaviour and at worst is not routable at all. Really the previous external healthcheck was better, as it tested external reachability from the runner, which is what we want to ensure.

Acked, if runner is also going to be in docker (which didn't work for me in CIs), the current healthcheck makes more sense.

Rerunning CI to ensure it's still green after merging in main.
Looks like there are two consistent experimental failures from main.


对Mac系统不友好

Mac系统没法使用呀

mac自行编译 有log请贴log
获取Outlook for Androidhttps://aka.ms/AAb9ysg

From: 不知名的虫子 @.>
Sent: Sunday, October 23, 2022 12:09:15 AM
To: TurboHsu/Vocab-Master @.>
Cc: Subscribed @.***>
Subject: [TurboHsu/Vocab-Master] 对Mac系统不友好 (Issue #5)
Mac系统没法使用呀
―
Reply to this email directly, view it on GitHubhttps://github.com/TurboHsu/Vocab-Master/issues/5, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKHCNCVVPUJCCA2IUR52O3WEQGSXANCNFSM6AAAAAARL43VZM.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

如果有具体问题，请带上日志/截图重新开启此issue。

请看release


delete unused IOCTLs to save flash

This saves a little bit of flash (badly needed on px4fmu-v2). These are only the easy ones that can be deleted without much thought (no PX4 usage at all). The significant wins will require slightly more effort and restructuring.
There is an enormous amount of duplicated code across the drivers.

Jenkins test this please.


Missed Qounter doesn't count hitting with the wrong saber as a miss

Not sure if this was intentional behavior or not but if you hit a block with the wrong saber, it doesn't increase the counter

Although there is a toggle, I think a toggle to separate a wrong saber cut from a bad accuracy cut would be a nice addition. Closed the issue since it's not really an issue, simply an idea


IPTV Live Stream Only works on emulator

Bug

IPTV Live stream links only work on emulators and not actual phones. Tested on S8+ and s10+, works fine on both Genymotion and Android Virtual Device with multiple configs.
Regular iptv links like movies work as intended both on emulators and physical devices.
The only error I'm getting from the player is : {extra: -2147483648, what: 1}
Environment info

React native info output:
    OS: Windows 10
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 6.39 GB / 15.85 GB
  Binaries:
    Node: 10.14.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.16.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
  IDEs:
    Android Studio: Version  <IP_ADDRESS> AI-183.6<IP_ADDRESS>92245

Library version: ^5.0.0
Steps To Reproduce

react-native init project
yarn add react-native-video
add Video component and try a live stream iptv link

Describe what you expected to happen:

I expect it to work ...

Reproducible sample code
Use any code from readme or from examples dir

Can you show the code?
We have an IPTV project working (playing HLS)


Build System

Hi @dnobori,
I have been watching this project since it became Open Source.
The biggest issue I can see is the manual makefile setup that is included.
To add support to more and more platforms you may want to look at using something like cmake. You will be able to remove the visual studio solutions with this also and have it all managed from one script.
Will you be accepting PR's?
I may do one for this
Many Thanks,
Martell

I'd like to bump this issue. I'd also like to contribute in some way, but don't have access to a paid 2008 version of Visual Studio. I'm completely new to C coding, and didn't want to invest a whole lot of time learning it. Just wanted to help fix a sorting bug thats been bothering me a while. What would it take to be able to build/test without such a dependency?

https://www.visualstudio.com/products/visual-studio-community-vs
On Sun, Apr 24, 2016 at 4:49 PM, topherbuckley<EMAIL_ADDRESS>wrote:

I'd like to bump this issue. I'd also like to contribute in some way, but
don't have access to a paid 2008 version of Visual Studio. I'm completely
new to C coding, and didn't want to invest a whole lot of time learning it.
Just wanted to help fix a sorting bug thats been bothering me a while. What
would it take to be able to build/test without such a dependency?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/SoftEtherVPN/SoftEtherVPN/issues/65#issuecomment-214057302

@meganerd
My understanding was that only the 2008 SP1 would work. Have you successfully built using the 2015 package linked?
Regardless, I tried downloading the 2015 version from the link provided and only downloaded a 207 kb file which failed to open. I'll debug that on my own if you confirm you are able to build with the 2015 version.

hi @martell . This sound good, please implement that if you can.
There are some new board members here and we can actually accept PRs :) . So please do it.
Also @martell  and @topherbuckley . You do not really need Visual Studio to compile this project. I don't even have windows. I have linux and eclipse. Both are free and I use make and gcc to compile.
However there are many things that could be enhanced in the configure and the make file.
Do you have concrete ideas???

@moatazelmasry2 Sorry, but I haven't used this in quite some time and ended up going with a paid service for my VPN. The one concrete idea I HAD, (not sure if it is even still an issue), was the sorting of VPN servers. I remember I couldn't sort by ping or speed properly. I don't remember exactly, but there was something in the sorting that favored alphabetical name order over ping/speed or something like that. Sorry I can't be of more help, but hope that sparks at least one product improvement.

https://github.com/SoftEtherVPN/SoftEtherVPN/issues/65#issuecomment-346202196
I'd also like to know how exactly you build the windows installers or windows gui tools without using windows nor vs2008. If GCC/MINGW-w64 alone can deal with it, it would simplify the build process a lot (and helps to gain more contributors).
I have tried MSYS2 but it refuse to build. Only in a VM with the relic VS2008 SP1 installed can generate the installer.
If the build process is clear (and hopefully not requiring C#), than writing a cmake build script MIGHT be possible.

CMake is now used as build system on Linux (#518).
@MaverickTse I created a feature request for MinGW: #591


After return promise, the test still fail with Timeout error.

Do you want to request a feature or report a bug?
Bug 🐛
What is the current behavior?
const CancelToken = require('./CancelToken')
const Cancel = require('./Cancel')

test('CancelToken is work fine', done => {
  const source = CancelToken.source()

  expect(source).toEqual({
    token: expect.any(CancelToken),
    cancel: expect.any(Function)
  })

  source.cancel('foo')
  return source.token.promise
    .then(reason => {
      expect(reason).toBeInstanceOf(Cancel)
      expect(reason.message).toBe('foo')
      expect(reason.toString()).toBe('Cancel: foo')
      console.log('Complete')
      // done()
    })
    .catch(done.fail)
})

Although I returned the promise, still got the timeout error
Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL..
Here is the demo: https://repl.it/HZ4K/12
Only if call done() in then callback, the test will pass.
What is the expected behavior?
Test PASS
Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.
node v7.7.1
npm v4.1.2
jest v19.0.2

If you use done callback, calling it is mandatory (this is the part where Jasmine takes over). You should just do:
test('test name', () => {
  return source.token.promise
    .then(reason => {
      expect(reason).toBeInstanceOf(Cancel)
      expect(reason.message).toBe('foo')
      expect(reason.toString()).toBe('Cancel: foo')
      console.log('Complete')
    })
});

@thymikee
Oh...I found the problem.
When I use callback without without parameter, I usually use _ => 'foo'
Like this:
test('test name', _ => {
  return source.token.promise
    .then(reason => {
      expect(reason).toBeInstanceOf(Cancel)
      expect(reason.message).toBe('foo')
      expect(reason.toString()).toBe('Cancel: foo')
      console.log('Complete')
    })
})

So, Jasmine (maybe) will think that I use done callback?
Please checkout the demo: https://repl.it/HZ4K/14

Yes, first parameter of test callback is considered done, you can name it whatever you like, Jest doesn't check how it's called.

Got it. Thank you~


Replaced existing browser tests with new Protractor tests

Replaced existing browser tests with new Protractor tests
Additions

Adds initial config and tests for Protractor

Removals

Those busted browser tests

Changes

Adds protractor as a dev-dep (make sure you install through ./setup.sh)

Testing

fetch, install protractor and follow the instructions in the README

Review

@imuchnik
@contolini
@KimberlyMunoz
@anselmbradford
@sebworks
@dpford
@kurtw

Preview

Preview this PR without the whitespace changes
Notes

Initialized with simple contact-us and the-bureau tests to get started
Organized into suites to allow testing for one-off instances (typically browser size but could also be non-js tests)
Utilizes Page Objects for easily sharing pages among multiple tests
Not sure if removing the old tests will break Jenkins builds, need input from BEWDs
Once there's a few more tests and we're more sure of the organization we can add the basic instructions to the project readme and getting started guide.

I am just too excited for words.
:+1:  :heart: :heart_eyes:  :love_letter: :trophy: :100:

:+1:

Going through this right now.
Just be sure to add `npm install -g protractor" to either the setup instructions or setup.sh.

A couple comments above, but :+1:.

All good now.

Tiny comments. Nothing that cannot be addressed later, just for good discipline, hygiene and form, worth mentioning now.
Let  me know if it does not make sense to you.

GREAT JOB!!!!

Review done. Mostly trivial stuff as you see fit to fix. Doesn't necessarily have to happen here but the main root readme should reference the testing readme instructions. I think ideally we'd have something like TEST.md in our root where all the testing instructions are and we eliminate the readmes in the test subdirectories. I feel like readmes in subdirectories can be a little like wikis in that the info can be hard to find when browsing the project.

@anselmbradford and @imuchnik I made all the recommended changes aside from the readme, I think those can wait so we can move forward for now.

Minor readme update, otherwise looks :+1:


Warning error on all pages in v2.0.6

Since updated to the new version, all pages got a warning like this.
Warning: call_user_func_array() expects parameter 1 to be a valid callback, class 'Kirki_Customizer_Scripts_Loading' does not have a method 'customizer_scripts' in ......\wp-includes\plugin.php on line 525
Can you fix this soon, some of users enable WP_DEBUG mode, so the warning is shown on all their pages.
Thanks!

can confirm

2.0.7 released, this should be fixed now.


Add a CLI option "-E" running an external script to configure environment variables

This PR is on #779. I guess it (indirectly) solves #778...

@dmikurube
I'm wondering is it possible to set environment variables via Ruby?
export in shell worked, but ENV["HOGE"] and dotenv in ruby script doesn't export environment variables.
cat /tmp/.env.test
DOTENV=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

#!/bin/sh

export HOGE='**************** HOGEHOGE **********************'

ruby -e '
 require "dotenv"
 ENV["HOGE"] = "***************************** FUGAFUGA ***************";
 Dotenv.load "/tmp/.env.test"

 ENV.each{ |k,v| puts "RUBY -- #{k} = #{v}" }
'

embulk -E/tmp/test.sh run -I /tmp/embulk-input-hoge/lib  /tmp/test.yml

RUBY -- HOGE = ***************************** FUGAFUGA ***************
RUBY -- DOTENV = AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

2017-09-07 20:59:42.051 +0900: Embulk v0.8.31
2017-09-07 20:59:46.612 +0900 [INFO] (0001:transaction): Loaded plugin embulk/input/hoge from a load path
HOGE = **************** HOGEHOGE **********************
...
2017-09-07 20:59:46.661 +0900 [INFO] (0001:transaction): Using local thread executor with max_threads=8 / output tasks 4 = input tasks 1 * 4
2017-09-07 20:59:46.676 +0900 [INFO] (0001:transaction): {done:  0 / 1, running: 0}
example-value,1,0.1
example-value,2,0.2
2017-09-07 20:59:46.767 +0900 [INFO] (0001:transaction): {done:  1 / 1, running: 0}
2017-09-07 20:59:46.779 +0900 [INFO] (main): Committed.
2017-09-07 20:59:46.779 +0900 [INFO] (main): Next config diff: {"in":{},"out":{}}

test.yml
in:
  type: hoge
out:
  type: stdout

embulk-input-hoge
module Embulk
  module Input

    class Hoge < InputPlugin
      Plugin.register_input("hoge", self)

      def self.transaction(config, &control)
        # configuration code:
        task = {
#          "option1" => config.param("option1", :integer),                     # integer, required
#          "option2" => config.param("option2", :string, default: "myvalue"),  # string, optional
#          "option3" => config.param("option3", :string, default: nil),        # string, optional
        }

ENV.each{ |k,v| puts "#{k} = #{v}" }
        columns = [
          Column.new(0, "example", :string),
          Column.new(1, "column", :long),
          Column.new(2, "value", :double),
        ]

        resume(task, columns, 1, &control)
      end

      def self.resume(task, columns, count, &control)
        task_reports = yield(task, columns, count)

        next_config_diff = {}
        return next_config_diff
      end

      # TODO
      # def self.guess(config)
      #   sample_records = [
      #     {"example"=>"a", "column"=>1, "value"=>0.1},
      #     {"example"=>"a", "column"=>2, "value"=>0.2},
      #   ]
      #   columns = Guess::SchemaGuess.from_hash_records(sample_records)
      #   return {"columns" => columns}
      # end

      def init
        # initialization code:
        @option1 = task["option1"]
        @option2 = task["option2"]
        @option3 = task["option3"]
      end

      def run
        page_builder.add(["example-value", 1, 0.1])
        page_builder.add(["example-value", 2, 0.2])
        page_builder.finish

        task_report = {}
        return task_report
      end
    end

  end
end

@hiroyuki-sato As chatted directly, they're impossible due to "environment variable"'s nature.

Thanks! Merging, and releasing v0.8.32 soon...

Late to the party, but if we assume -E would be used for env variables, would it make more sense to do something like
env_file="${1#-E}"
echo "Running an external env: $env_file"
env $(cat $env_file | xargs)

with -E option.
This way one could keep Procfile/.dotenv format and no need for extra sh scripts?

@kakoni Thanks for your comments. It would be feasible (on Linux/Mac), but I think we won't adopt it from now since:

It won't work the same for Windows. It'd be more consistent to use "the more basic scripting language" on the OS.
We see some benefits on the idea, but not very big.
The -E option has already been merged and released.


Compatibility with Django CMS and djangocms-text-ckeditor

(also submitted as divio/djangocms-text-ckeditor#431)
django-admin-bootstrap generally works great with Django CMS, but we're running into an issue with a certain plugin. With django-admin-bootstrap installed, the djangocms-text-ckeditor app seems to fail to register itself.
When loading a change form while editing a CMS page, we get the following error:
NoReverseMatch at /admin/cms/page/edit-plugin/1/
Reverse for 'app_list' with arguments '()' and keyword arguments '{u'app_label': 'djangocms_text_ckeditor'}' not found. 1 pattern(s) tried: [u'admin/(?P<app_label>django_comments|auth|updates|filer|cms|tagging|zinnia|sites|djangocms_snippet)/$']
As you can see, djangocms-text-ckeditor isn't listed in the app_list, but I expect it to be. Is django-admin-bootstrap doing something that would interfre with the registration of another app in the admin?

The template tag render_menu_app_list use 'app_list'.
So it's probably messing up, only why I don't know.
Need to find a better way to render the lateral menu.

1eeade05f44b7d2bb59975103114c049406df0c4

This still appears to be a problem with:
Django==1.11.13
django-cms==3.6.0
djangocms-text-ckeditor==3.5.3
bootstrap-admin==0.4.2


installing dependencies  required for code if the code is running in …

…google colab
The site doesn't provide information on dependencies  required . so if you run the code in colab you will encounter error due to missing of  dependencies .The code i  added check if the code is running in colab env . if yes it will install all the needed dependencies . so user wont encounter an error . user can run smoothly

@googlebot I signed it!


Support for 'discard' transport.

Thanks for the best Postfix library.
Here's support for the 'discard' transport. We use it a lot in devel to prevent embarrassing email accidents.

Thanks for contributing!


Calendar’s weekdays are broken

This is a very urgent bug. The weekdays at the top of the calendar are incorrect, rendering the calendar a bit useless.

Notice the highlighted day in the photo. It says Friday March 6th. But today is Saturday March 6th. Calendars (at least in the US) typically start with a Sunday, so maybe that explains the problem.
Compare with the correct dates from iPhone Calendar:

I have users trying to select dates based on weekdays, and they're choosing the wrong one.
The problem happens on nearly every month. You can see it on the example app: https://www.reactnativepaperdates.com/
Compare it to a calendar and you'll see that the days are wrong.
@RichardLindhout please tell me if I can help solve this somehow. It's really important this gets fixed in order to keep using the library. Thank you!

Really strange looks like a difference in locale / timezone

Oke I think I fixed it. Let me release a new version

Let me know if this fixed your issue. I think it does since it works for me but it created the weekdays in dutch format and it could break on some devices I guess

Is the example app site updated too? I still have the issue there.

No, I'll update it

Updated version online, should show Example version: 0.3.2

I think that did it! Thanks :)


The only remaining issues have to do with the weights argument passed to setup and the dynamically defined PredictionRequest / PredictionResponse types:
$ python -m mypy python/cog
python/cog/predictor.py:95: error: Argument "weights" to "setup" of "BasePredictor" has incompatible type "Union[IOBase, pathlib.Path, None]"; expected "Union[File, cog.types.Path, None]"  [arg-type]
python/cog/server/http.py:141: error: Variable "PredictionRequest" is not valid as a type  [valid-type]
python/cog/server/http.py:141: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
python/cog/server/http.py:147: error: PredictionRequest? has no attribute "id"  [attr-defined]
python/cog/server/http.py:161: error: PredictionRequest? has no attribute "id"  [attr-defined]
python/cog/server/http.py:169: error: Variable "PredictionRequest" is not valid as a type  [valid-type]
python/cog/server/http.py:169: note: See https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
python/cog/server/http.py:178: error: PredictionRequest? has no attribute "input"  [attr-defined]
python/cog/server/http.py:179: error: PredictionRequest? has no attribute "input"  [attr-defined]

Punting on fixing the remaining mypy issues. Hoping that an alternate solution to https://github.com/replicate/cog/pull/1056 will help resolve this as well.