plugins/lsp: add omnisharp language server

Adds option to enable omnisharp, and options to configure it.

Haven't tried this pr myself yet. But I did manually once add OmniSharp to my config and If I remember OmniSharp is kinda broken for nvim-lsp (https://github.com/OmniSharp/omnisharp-roslyn/issues/2483)
If it's still true then I believe it's better to not merge this for now since it won't work anyways. We could potentially add csharp-ls instead. Though it's not packaged in nixpkgs

But I did manually once add OmniSharp to my config

When was this? And I'm assuming you installed omnisharp through nixpkgs?

When was this? And I'm assuming you installed omnisharp through nixpkgs?

Yeah I installed it through nixpkgs. You can check if produces some problem. I'll check it out tomorrow

I have my fork if you want to use it and try it out. I
'm probably fortunate enough to have a neovim config with an older version of omnisharp that doesn't have to deal with this.
That issue you linked goes back to December 2022, and i'm not really holding my breath for a fix. maybe i'll bring in that hacky workaround lol

I found some stuff that suggests that this won't be a problem for long.
There's this open PR to bring omnisharp back in line with the LSP spec: https://github.com/OmniSharp/omnisharp-roslyn/pull/2520
Then nvim-lspconfig itself seemed to add a workaround to fix this: https://github.com/neovim/nvim-lspconfig/pull/2692

If omnisharp is going to fix it then it's pretty nice. We can probably wait for them to merge the changes.
Also nvim-lspconfig's version is dependent on nixpkgs. If it's updated then we can simply update flake inputs.
Other than that I just tried out your fork and yes the problem is still there. I just created a new console project using dotnet new console and as soon as I opened the Program.cs file I got the errors

Just checked and lspconfig's fix was only merged in 2 days ago, and vimPlugins hasn't been updated since the end of May.
:pensive: I think I'll leave this PR open until nixpkgs gets updated. I'm tempted to add an input just for nvim-lspconfig to point towards the most recent version, but I doubt that would be accepted lol

Yes I am on the team of waiting for a fix if it is likely to come.

😔 I think I'll leave this PR open until nixpkgs gets updated. I'm tempted to add an input just for nvim-lspconfig to point towards the most recent version, but I doubt that would be accepted lol

Until then you can probably look into the changes I asked for! 😃

Yes I am on the team of waiting for a fix if it is likely to come.

The omnisharp team hasn't fixed that issue for months. Since nvim-lspconfig has added a workaround into the plugin themselves we can just merge this PR when nixpkgs update nvim-lspconfig instead of waiting for omnisharp team's fix.

Speaking of, lspconfig's fix is on the way.
Here's lspconfig currently: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/applications/editors/vim/plugins/generated.nix#L6866
https://github.com/NixOS/nixpkgs/pull/240130 has been merged and updates to a version of lspconfig that should include that fix. It's this line specifically
So, in a couple of days, this should be good to go. Let's leave this PR open until then just in case.

The OmniSharp fix was merged as well.

The OmniSharp fix was merged as well.

Great, I just updated the flake.lock for nixvim, so it should be in it.
Can you rebase from main and re-test please ?

Great, I just updated the flake.lock for nixvim, so it should be in it. Can you rebase from main and re-test please ?

The fix was just merged. nixpkgs will not have the fix until omnisharp creates a new release with the fix. (Correct me if I'm wrong)

The fix was just merged. nixpkgs will not have the fix until omnisharp creates a new release with the fix. (Correct me if I'm wrong)

I thought the "fix" was in nixpkgs, not in omnisharp itself. What is this PR about then ?

I thought the "fix" was in nixpkgs, not in omnisharp itself. What is this PR about then ?

Ok so......
OmniSharp has had that issue for months without a fix. @garaiza-93 said nvim-lspconfig added a workaround to the plugin itself instead of waiting for OmniSharp to fix it.
I believed it at that time and didn't check the nvim-lspconfig's PR myself. I just checked it out and... The changes it does doesn't fix the issue I was referring to. That PR is fixing some other things.
Other than that OmniSharp themselves have finally fixed the issue themselves a few hours ago. Though a release hasn't been created yet.
So basically we'll have to wait for OmniSharp to create a release and it getting into nixpkgs before merging
Link to convo about both PRs: https://github.com/pta2002/nixvim/pull/465#issuecomment-1616090847

Thanks @Tanish2002 for the clarification. I would advise to indeed wait for a release of omnisharp.

Alright, waiting for an updated release on omnisharp to reach nixpkgs.

I made a PR on nixpkgs to update omnisharp: https://github.com/NixOS/nixpkgs/pull/244119
PR status: https://nixpk.gs/pr-tracker.html?pr=244119

Hey @garaiza-93 could you please rebase your branch on main please ?
It seems that it is a bit messed up right now.


chore(release): 2.67.0

See CHANGELOG

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 7ff24b422f207ef8bc83f03007ea2793c09dad0b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Tier Rework

Making the interfaces themselves is the most tedious and generally resource-intensive part of the mod. It's a pretty intricate process. After all that, the tier selection is very underwhelming. It's a boring resource sink (8 of an item around the block to choose its tier? Come on). Anything under obsidian tier is going to feel like a waste of all the resources it took to make the interfaces. Anything above it is unreasonably expensive.
I feel like the entire tier system needs some kind of rework. Maybe tiered interface panels? I'd like to see discussion on it.

I agree and am open to suggestions.

To go along with power requirements, have different Tiers use a power multiplier for upgrades.  So you  could have the smaller CM cheap or free to use upgrades.
Just random thoughts

a specific machine to make CM
^ above is actually the inside of a Tiny CM
able to make a CM bigger after it's built/used

Perhaps requiring a source of power to maintain the inner dimension?

I would really discourage the need of power to maintain the inner dimension, it will just be an hassle.
Regarding the recipe for the compact machines, as for the actual state of the mod, I think is balanced and not at all a resource waster, 8 of an item it's so cheap. I would agree only for the maximum size which requires 8 nether stars, if all the tiers has some kind of "linear" progression the biggest compact machine is waaay too much expensive. Instead 8 blocks of diamonds imho suit better the case.
The nether star price to upgrade them and entangle them seems reasonable instead.
Honestly speaking for the great advantage you take from a compact machine, it's price in terms of recipe resources it's worth it.
I see this mod more like a middle to end game thing.

It would be nice to be able to upgrade the cm size, but i understand that it would mean a new area in the dimension. That means that if you have anything in the small CM and upgrade it you'll get a new room and lose all your stuff in the old room. unless you figure out a way to expand that same room and delete the walls and expand the room, but that seems quite hard to do from a programming point. I like the way it is now.

Currently working on a 1.10.2 version, the 1.7.10 version is not being maintained anymore, sorry.
Closing all issues not relevant for the new version.


Bubnoff units are completely off

Bubnoff units (speed) convert to about .1c, consistent across various units, when they should be something like a millimeter per year. It seems like this comes from app/src/main/java/yetzio/yetcalc/component/UnitConv.kt, where the formulas in MetreperSecToBubnoff and BubnoffToMetreperSec are swapped.

@Eiim Thanks for reporting that :). Yea it seems like the conversion was wrong for those two methods, now I wonder where I took those conversation rates from. I will probably release a new update within these days.
Sorry for any inconvenience.

Fixed as of #44


Implement ffi interface for GlobalMemoryStatusEx() (and others)

It turned out that Prometheus os collector does not use WMI (despite that the documentatoin states otherwise).

It uses the following API to retrieve the system infroamtion

GlobalMemoryStatusEx()
NetWkstaGetInfo()
HKLM\SYSTEM\CurrentControlSet\Control\Session Manager\Memory Management
HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion

See the following implementation for details

https://github.com/prometheus-community/windows_exporter/blob/master/collector/os.go#L160

We need to implement the same logic in Ruby to replicate the output.

NetWkstaGetInfo()
https://docs.microsoft.com/en-us/windows/win32/api/lmwksta/nf-lmwksta-netwkstagetinfo
GlobalMemmoryStatusEx()
https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-globalmemorystatusex

I was surprised to find that the os collector collects information about memory,
such as PhysicalMemoryFreeBytes, using 'GlobalMemoryStatusEx'.
https://github.com/prometheus-community/windows_exporter/blob/master/collector/os.go#L244-L248
The Memory collector, on the other hand, seems to be collecting information only from HKEY_PERFORMANCE_DATA.
I don't understand why the os collector has to collect such memory information using GlobalMemoryStatusEx.

My theory is that they initially used WMI::Win32_OperatingSystem (which contains
bits about memory status) to implement os collector.
And it turned out that the performance was not  so great, so they switched to GlobalMemroyStatusEx
while keeping the output data format.

I think I found a bug in FIddle. Posted a bug ticket to the upstream fiddle project: https://github.com/ruby/fiddle/issues/99

GlobalMemoryStatusEx()
NetWkstaGetInfo()
HKLM\SYSTEM\CurrentControlSet\Control\Session Manager\Memory Management
HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion

Done implementing them. Stil it DEFINITELY needs testing, though,

Let's mark this ticket done. I'll proceed to implement os collecctor #3


Incorrect URL, skrollr remove "0" in url

I have this HTML tag on the back-end,

Scroll Output is something like this.

you'll see the url is /wp-content/uploads/2015/02/fullwidth-box-tail.gif
but scroll change it to /wp-content/uploads/2015/2/fullwidth-box-tail.gif when implementing the background image style
Any help would be appreciated

https://github.com/Prinzhorn/skrollr/issues/668


Element option: Conditionally show element

The element should be conditionally shown. This happens via creating a conditional dependency for the current element on other available element.
To acheive this, the condition option must be added for current element with specific condition value (according to the conditional element selected).

Implemented


Metrics exposing

Hi there!
Is there any plans to expose metrics such as RPS, timings in some format?

hi. Sure, this would be nice and helpful and if you want to deal with this - all yours. Probably we should expose metrics in Prometheus-friendly way

I have created basic support for management API on a separate port exposing /prometheus with a few metrics.
Pls take a look. I'll appreciate recommendations/ideas/fixes, especially in this particular area, because this is my first attempt to integrate such metrics into an application.

ok, this is horrifying how much dependencies the standard prometheus go library brings :( I don't want it in our codebase. Will try some lightweight alternative. So far found this one https://github.com/VictoriaMetrics/metrics
If I can't find a working and lightweight alternative will probably drop this support.

I did it already a few days ago https://github.com/umputun/reproxy/blob/master/app/mgmt/server.go#L40


A question about spn

Dear @mileyan , when I used spn（sh make.sh）, there was an error(ImportError: torch.utils.ffi is deprecated. Please use cpp extensions instead) and I didn't know how to solve it.
My Computer Environment： python-3.5  CUDA-9.0.176   pytorch-0.4.
Looking forward to your reply！

Can you try CUDA-8.0? It might have some problems for CUDA-9.0 now. I will try to fix it. But CUDA-8.0 should be work.


New release?

It has been 5 months since last release and useful commands such as "boot add" are not in that release. Consider make a new release?

Done !


Feature Request: being able to sort spells in compendium by save or attack roll

When looking in the compendium it would be nice to be able to filter between attack roll or save.

Closing in favor of the consolidated issue #6588


Invisible button to extract ingredients

Hi everyone,
Regularly, the server seems overwhelmed by requests, where we can be stuck on this screen for seconds:

The main issue here is with the "Extract ingredients" hidden with an infinite Progress Bar.
I think it would be better to gray the button and add the Progress bar on top of it, to let the user understand what that progress bar is for.

@g123k Definitely something to do there.
The tricky part is that you upload the picture in background - potentially much later if you don't have connection at all.
An additional text "Waiting for the server to respond before you can extract the ingredients"?

Actually, there are 3 steps with this button:

When the screen is loading with the infinite progress bar (= my issue)
When the button is clickable to extract the ingredients
When the request is in progress

I think we should indeed add your proposal.
But another issue is when I press on extract ingredients, the button is still in the same state (pressable), whereas we should prevent clicks and show a Progress bar-like info

I couldn't agree more - https://github.com/openfoodfacts/smooth-app/blob/develop/packages/smooth_app/lib/pages/product/edit_ingredients_page.dart
    // TODO(monsieurtanuki): hide the "extract" button while extracting, or display a loading dialog on top

    // TODO(monsieurtanuki): add WillPopScope / MayExitPage system

                        // TODO(monsieurtanuki): what if slow upload? text instead?
                        const CircularProgressIndicator.adaptive(),

Implemented in #5384


Training SNR distribution

What injected event SNR distribution should we use during training? Something which mimics the test-time SNR distribution? Or something biased towards lower SNRs to improve our performance in that region, with the assumption that such a network will generalize better to higher SNRs?

@EthanMarx yes definitely


[New game]: Fidget Spinner

🎮 Game Request
Game logic and basic description
The logic of the game is that the turns will keep increasing as you press the space bar, and it will reduce its speed and stop at a point where you stop pressing the space bar
Point down the features
Game points
We use tkinter for this
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @nisargaa20 , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#3953

Hey @nisargaa20 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @nisargaa20 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹


n-dim state space

Current version support only 2-dim state space. It will be better if the software can deal with arbitrary dim state space. To this end, there will be two tasks required:
Task1) support n-dim space in OptimalControler.m.
Task2) develop a visualization tool which can handle n-dim state space. [if possible]
Task2 might be difficult as some nice idea is necessary to neatly visualize over 4dim spaces.

Hi，thanks for your code！
I want to modify it to an 11-dimensional state space, but there are errors in the number of dimensions. If I want to use the library to write, will I have to modify many parameters?
Thank you so much!

Hi @lucattycord thanks for feedback. I'm currently have trouble in mathworks license, and  cannot use MATLAB. I think there needs only slight modification to use in higher dimension case.
What exactly "there are errors in the number of dimensions." is? like, which part of code or someghing like that

I only modify  A, B, C, Q,  R, and W matrixes in example_tube MPC.m, and it mentioned me errors above.
The state is 111, and I choose the dim of W_vertex 112. But by calculating, in line 56 of DisturbanceLinearSystem.m, the dim of obj.Ak is 1111 while the dim of obj.W.A is 52 so that it occurs the error.

Could you provide the code (or A, B, C, Q, R values) to reproduce the bug?

addpath('../src/')
addpath('../src/utils/')
% fix random seed
rng(0);
k_e=10^(-5);
Jx=2562e-6;
Jy=2562e-6;
Jz=5124e-6;
m_uav=1.2954;
r=[0.1;0.1;0.01;3];
input=4;
output=4;
state=11;
T=0.1;%sample time
Np=20;%predictive horizon
Nc=8;%control horizon
%   xm(k+1)=A_m*xm(k)+B_m**u(k)
%A_m
A=eye(11,11);
A(1,4)=T;
A(2,5)=T;
A(3,6)=T;
A(4,9)=T/Jx;
A(5,10)=T/Jy;
A(6,11)=T/Jz;
A(7,8)=T+1;
A(9,9)=-10T+1;
A(10,10)=-10T+1;
A(11,11)=-10T+1;
%B_m
B=zeros(11,4);
B(8,1)=T/m_uav;
B(9,2)=10k_eT/Jx;
B(10,3)=10k_eT/Jy;
B(11,4)=10k_e*T/Jz;
%C_m
C=zeros(4,11);
C(1,1)=1;
C(2,2)=1;
C(3,3)=1;
C(4,7)=1;
% make your own discrete linear system with disturbance
Q = diag([1,1,1,1,1,1,1,1,1,1,1]);
R = diag([0.1,0.1,0.1,0.1]);
W_vertex = [0.15,-0.12; 0.1,-0.13;  0.11,-0.11; 0.12,-0.1; 0.14,-0.11; 0.13,-0.14; 0.08,-0.15; 0.09,-0.09; 0.05,0.08; 0.15,-0.1; 0.13,-0.2];
% construct a convex set of disturbance (2dim here)
W = Polyhedron(W_vertex);
% construct disturbance Linear system
disturbance_system = DisturbanceLinearSystem(A, B, Q, R, W);
% constraints on state Xc and input Uc
Xc_vertex = [2, -2; 2 2; -10 2; -10 -2];
Uc_vertex = [1; -1];
Xc = Polyhedron(Xc_vertex);
Uc = Polyhedron(Uc_vertex);
% create a tube_mpc simulater
% if N_horizon is too small, the path will never reach inside the robust MPI-set X_mpi_robust in time step N_horizon, then the problem becomes infeasible.
N_horizon = 10;
w_min = [0; -0.10];
w_max = [0; 0.10];
mpc = TubeModelPredictiveControl(disturbance_system, Xc, Uc, N_horizon);
% The robust MPC guidances the path inside the robust MPI-set so that the path will reach the robust MPI-set in N_horizon.
x = [-7; -2];
savedir_name = 'results';
mkdir(savedir_name);
for i = 1:15
disp(i)
u_next = mpc.solve(x);
x = disturbance_system.propagate(x, u_next); % additive disturbance is considered inside the method
mpc.show_prediction();
saveas(gcf, strcat(savedir_name, '/tmpc_seq', number2string(i), '.png')); % removing this line makes the code much faster
clf;
end

My main question lies in the dimension of W. If my status is 111 dimension, then due to the upper and lower limits, W is 112.

Hi,I have modified it to 6-dimensional, you can go to my homepage to see.


Subscribe twice

$billing->newSubscription('main', 'plan')->create('tok_visa', [
    		'email' => $customer->email,
		]);

It appears that if you call this twice, you can subscribe to the same plan twice.
On stripes platform, the customer is considered the same, but on laravel's database and on stripe, the subscription is registered twice.
Is this a bug?

Hey yes, it's perfectly possible to have two subscriptions to the same plan. You'll need to use the checks to see if you are already subscribed to a plan before trying the same thing again: https://laravel.com/docs/5.7/billing#checking-subscription-status

Hey all,
I have same problem and partially solved this with @driesvints suggestion.
Currently, if i subscribed to plan i can't subscribe to it again.
The problem is when i am not yet subscribed and call my API URL for subscription multiple times at same time it buys multiple subscriptions. The problem is that if statement return false for all requests because first request is not yet finished and user is not yet subscribed.
Is there any chance i can prevent user calling URL multiple times at same time? Or somehow wait for one request to finish and then execute second etc.


Extension not working at all

None of the snippets fire?

@anthonybrown Could you add some more details? I'm using it continuously day by day and it works for me.

@dsznajder I fixed the issue.

@anthonybrown What did you do to fix it? On my Windows machine, I am having the same issue (I'm on latest VS Code version). On my Mac everything works out of the box, so I'm confused as to why it doesn't work on Windows.


fix add ssh certificate with existing key

Currently you cannot add or update a certificate if the key has already been loaded because AddTPMKey will exit if the public key fingerprint matches an existing key. It ignores the certificate that was provided in the request.
Let's unconditionally replace the key so that the certificate attribute will be updated.
This enables using short lived ssh certificates which are common in enterprise environments. These certificates typically expire in a few hours.
One notable thing that will still not work is having multiple certificates per key. This can happen if there are multiple authorities in your organization or a authority rotation is in progress. These scenarios could be tolerated, but I think we should just do a simple fix for now.

Cool, thanks!


generate all atomic styles in dev mode?

it's nice to be able to author styles in dev tools but this doesn't work well if you are trying to apply a tokenami property that hasn't had its atomic CSS generated for you yet.
should tokenami generate all styles by default in dev mode and make the stylesheet a build asset that wouldn't be committed to your repository?

closing for now, will see if this is


Column Header Sizing

Autosized column headers become cut off when sorting or filtering icons are added. It would be nice if we had one of the options below:

A padding parameter to manually adjust for this
Ag-grid automatically pads for this (or a flag to enable it)
Automatic resize on header size change. I'll probably use the onFilterChanged and onSortChanged events to make this work in the meantime.

will be in next release.
added gridOption.autoSizePadding, to specify number of pixels to add to calculated width.

I think it would be better to just have a flag for whether filter and sort icon widths should be included. If I resize the column after the icons appear, the column width increases even more with the new option.


Pass gcloud objects for Logging Sink destination

gcloud-node has the ability to accept a Storage Bucket, Bigquery Dataset, and Pub/Sub Topic object as the Sink's destination. Should we do the same?

Link to the gcloud-node implementation.

I definitely think we should do this.

Here is some code I was playing with for testing this:
    it "creates a sink with a Bucket destination" do
      skip
      require "gcloud/storage"
      bucket = Gcloud.storage.create_bucket "#{prefix}-bucket"
      # TODO: Set permissions on the bucket…
      sink = logging.create_sink "#{prefix}-bucket",
                                 destination: bucket

      sink.destination.must_equal "storage.googleapis.com/#{bucket.name}"

      sink.delete
      bucket.delete
    end

    it "creates a sink with a Dataset destination" do
      skip
      require "gcloud/bigquery"
      dataset = Gcloud.bigquery.create_dataset "#{prefix}_dataset"
      sink = logging.create_sink "#{prefix}-dataset",
                                 destination: dataset

      sink.destination.must_equal "bigquery.googleapis.com/projects/#{dataset.project}/datasets/#{dataset.id}"

      sink.delete
      dataset.delete
    end

    it "creates a sink with a Topic destination" do
      skip
      require "gcloud/pubsub"
      topic = Gcloud.pubsub.create_topic "#{prefix}-topic"
      sink = logging.create_sink "#{prefix}-topic",
                                 destination: topic

      sink.destination.must_equal "pubsub.googleapis.com/#{topic.name}"

      sink.delete
      topic.delete
    end

Is this something we want to take action on?
/cc @dazuma @hxiong388

I think it's ok to leave it to user to build the full destination string, as it matches consistently with the cloud.google.com documentations.


bug: Problems linking to generated targets

I might be submitting this to a wrong project, but because I don't know any better place, and this is at least related to autorefs, I decided to submit it here. Feel free to close this if the place is wrong. If you know a better place, please let me know.

Let's first assume I have the following content:
# Welcome

## Just testing

When I have autorefs installed, I can very conveniently link to the Welcome section using this syntax:
This is a link to the [welcome][] section.

This is very similar, and equally convenient, than the syntax I'm used to with reStructuredText and Sphinx:
This is a link to the `welcome`_ section.

The problem is that I'd typically like to refer to sections so that the name starts with a capital letter as below, but in this case the auto-linking doesn't work:
This is a link to the [Welcome][] section.

There's also a problem with headings having spaces. For example, this doesn't work:
I'm [just testing][].

I know I can get both of the above to work by including the actual link target link as below:
This is a link to the [Welcome][welcome] section. I'm [just testing][just-testing].

The problem with adding those link targets is that it requires writing redundant content, makes document source less readable and is inconsistent. Inconsistency also means you can easily forget to add the target when in some cases it is not needed. Notice that with reStructuredText and Sphinx these work out-of-the-box:
This is a link to the `Welcome`_ section. I'm `just testing`_.

My first problem that [Welcome][] isn't handled case-insensitively feels like a bug to me, because according to the original Markdown spec, reference targets are case-insensitive. There is, for example, an example like this:
I get 10 times more traffic from [Google][] than from
[Yahoo][] or [MSN][].

  [google]: http://google.com/        "Google"
  [yahoo]:  http://search.yahoo.com/  "Yahoo Search"
  [msn]:    http://search.msn.com/    "MSN Search"

The odd thing is that the above example is handled fine by MkDocs. It's strange that [Google][] works when the references target is [google]:, but [Welcome][] doesn't work when the reference target ought to be something similar.
My second problem that [just testing][] is not linked to the generated just-testing target is something where my wish is against the Markdown spec. This example from the spec wouldn't work if spaces would be automatically replaces with hyphens:
Visit [Daring Fireball][] for more information.

[Daring Fireball]: http://daringfireball.net/

Although I'm fighting against the spec, I feel that this syntax would be really convenient. Is it something autorefs could support? If there are backwards compatibility concerns, it didn't need to be enabled by default, but having an option to enable this behavior would be awesome. If this is something autorefs cannot do or it doesn't belong to its scope, do you have ideas how I could enable the behavior otherwise? I'm willing to implement a plugin if needed and would also be ready to provide a PR to autorefs if this feature could be added to it.

Thank you for the bug report / feature request @pekkaklarck, I think it makes a lot of sense. We can definitely consider "slugifying" titles when no identifier is provided (and after having tried with the actual title as id, probably). At first glance, this shouldn't cause any issue if we do this by default, but I'll have a deeper look :slightly_smiling_face:

That would be awesome! And yes, should first check is is there a match with the original name/id before sluggifying.

Looking into this. When referencing API docs, it's important to retain case-sensitivity, since object names themselves are most likely case-sensitive (that's the case for Python for example). So how to distinguish when we would like to try and slugify (in case of title not matching as is), and when we wouldn't want that? I think there's a simple answer: if the title is wrapped in backticks, maintain case-sensitivity (and more generally, don't try to slugify the title at all).
All the following examples assume there's no direct match with the title unchanged:

[Welcome][] -> slugify
[just testing][] -> slugify
[`Constant`][] -> do not slugify
[Note about `Thing`][] -> slugify

Does autorefs know that link targets are available? If it does, then it could work like this:

Check is there an exact match. If there is, use it.
Go through all targets and compare the used text with them in normalized manner (e.g. lower case, all special characters removed, ...). If there's a single normalized match, use it. If there's none or multiple, emit a warning or error.

It knows. The issue with always falling back is that it's unwanted in some cases. Consider this:
class Bicycle:
    ...

bicycle = Bicycle()
"""This is my bicycle."""

def compare(b1: Bicycle, b2: Bicycle) -> bool:
    """Compare instances of [`Bicycle`][]."""
    ...

Now imagine that Bicycle is not included in the docs (because the dev adds each object manually and forgot about it, or because they auto-generate the docs and Bicycle doesn't have a docstring, which would exclude it). The Bicycle cross-ref in compare's docstring would therefore fail, and fallback to slugification, resulting in bicycle, but that's not the right object! Instead, we want to fail hard and emit a warning, without falling back.


'Current process' needs some clarification

[Threads have an owning process and then a process whose address space they are attached to, typically these are the same process, however a thread can be attached to an arbitrary process.  Some experimentation has shown that IoGetCurrentProcess() returns the EPROCESS that the current thread is attached to, not necessarily the threads owning process.  PsGetCurrentProcessId() however seems to return the owning process for the current thread even if the thread is attached to a different process at the time of the call.  As such EPROCES objects looked up using these two routines will not necessarily be the same EPROCESS objects.]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 28a0c76c-c19b-a36d-e6ef-b4e7f0a15d63
Version Independent ID: 66ce88d8-bd68-beb7-7b36-89cc30fced50
Content: IoGetCurrentProcess function (wdm.h) - Windows drivers
Content Source: wdk-ddi-src/content/wdm/nf-wdm-iogetcurrentprocess.md
Product: windows-hardware
Technology: wdk-api-reference
GitHub Login: @barrygolden
Microsoft Alias: bagold

@camptatopenmars, thanks for your feedback on this article.
You may have success posting a question about the current process return value from IoGetCurrentProcess in the following forums, where other driver developers and Microsoft engineers can be found.
Microsoft Q&A: Windows Hardware development
OSR Developer Community

I dont have a question.  Just pointing out the docs are missing a detail
that may be important to a dev.
On Mon, Jan 8, 2024, 10:08 AM Barry Golden @.***> wrote:

@camptatopenmars https://github.com/camptatopenmars, thanks for your
feedback on this article.
You may have success posting a question about the current process return
value from IoGetCurrentProcess in the following forums, where other driver
developers and Microsoft engineers can be found.
Microsoft Q&A: Windows Hardware development
https://docs.microsoft.com/answers/topics/windows-hardware.html
OSR Developer Community https://community.osr.com/
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/windows-driver-docs-ddi/issues/1496#issuecomment-1881585348,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOQKSMJUQB2GKZX6NWD5MFLYNQY3LAVCNFSM6AAAAAA7B4FM4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRGU4DKMZUHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Fix ResourceWarning due to unclosed file

Changelogs
closes #211

enumerate the changes of that PR.
This PR addresses a ResourceWarning that was being raised due to an unclosed file in datamol/mol.py. The warning was triggered by the following line of code:

SALT_SOLVENT_PATH = datamol.data.open_datamol_data_file("salts_solvents.smi").name

This line opens a file but does not close it, which is why the ResourceWarning was being raised. To resolve this issue, I've modified the line to use a with block, which ensures that the file is properly closed after its name is retrieved:
with datamol.data.open_datamol_data_file("salts_solvents.smi") as file_obj:
    SALT_SOLVENT_PATH = file_obj.name

This change should prevent the ResourceWarning from being raised in the future. I've tested the change locally and confirmed that it resolves the warning without causing any other issues.

Checklist:

[ ] Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
[ ] Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
[ ] Update the API documentation is a new function is added, or an existing one is deleted.
[ ] Write concise and explanatory changelogs below.
[ ] If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

Thank you for the catch! This is indeed a bug, but I don't think we should even open that file to get its path. Instead we should simply retrieve the path.
In datamol/data/__init__.py, can you add the below function and use it in mol.py with SALT_SOLVENT_PATH = datamol_data_file_path("salts_solvents.smi")?
@functools.lru_cache()
def datamol_data_file_path(filename: str, dm_module: str = "datamol.data"):
    if sys.version_info < (3, 9, 0):
        with importlib_resources.path("datamol.data", filename) as p:
            data_path = p
    else:
        data_path = importlib_resources.files(dm_module).joinpath(filename)

    return str(data_path)

Thanks for the suggestion @hadim, that's definitely a much better way of handling things. I'll push an update a little later today.

@hadim I just pushed a commit with the requested changes.

Thank you, @kkovary, for your contribution!

Thank you @hadim for the wonderful tools, hope to make more contributions in the future 😄


css map option

Hello. I would like to propose a micro fix which will allow to map css-like files with wildcards. That will allow to use css pre/post processing on backend side for css-like files while SystemJS and builder will not know about that. That could be a good temporary solution until new plugin-css with modules for less, scss, autoprefixer etc. will be implemented. Thank you.
PS: May be we could move all css related options into cssOptions config property.

Great work!!
This project was just updated yesterday with a release to make it possible to build CSS plugins on top of this as a base-level plugin.
I think it should be possible to use this approach to provide your remap functionality as a separate plugin?
I'd love to see some more experimentation of advanced CSS features that can then sit outside of the core CSS plugin in this way.
Perhaps you would consider making this its own project? It would be great to include in the plugin list as a more advanced CSS plugin approach.
Happy to discuss further... just let me know your thoughts.

Current plugin-css implementation don't have hook for locate.
Not sure how can this plugin be used as basis? extend from it? compose with it?

See systemjs/plugin-less as an example of how the plugin can be used as a
base. The extension can then add whatever hooks it likes.
On Fri, 29 Jul 2016 at 02:22, Artem Butusov<EMAIL_ADDRESS>wrote:

Current plugin-css implementation don't have hook for locate.
Not sure how can this plugin be used as basis? extend from it? compose
with it?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/systemjs/plugin-css/pull/95#issuecomment-236062915,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAkiyu_PLZ8SEK-tAtxb1UrQbY1XwyTbks5qaUexgaJpZM4JVvWN
.


Fix compatibility with Sanic 21.12.0+

The deprecation is now an error with current Sanic 21.12.0
Would you mind to include the fix?

Is there any timeline for merging this?

In __init__.py lines 134 and 144 app.memcollect_task should be changed to app.ctx.memcollect_task as these are still causing errors.

Are you still working on this? @jmarcet

@ghost I had forgotten completely about this PR. I've been using it all this time without that change 😅


the hyperparameter is not clear

。。。。i didnt find the location to adjust the dim of input or output

Hyperparameters are in bin/train_elmo.py


Psi

PR fulfills these requirements

[ ] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[ ] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[ ] Backend (Database)
[ ] Backend (API)
[ ] Frontend

Describe the reason for change
(link to issue, supportive screenshots etc.)
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[ ] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Hi @shreesha-j, just closing this PR as it looks like it was intended for your fork, rather than to be merged into our repository.

Hi @shreesha-j, just closing this PR as it looks like it was intended for your fork, rather than to be merged into our repository.

Ya sorry for it


Error running the tool

I got this crash with this example command:
cwltool scatter-test.cwl --cancerTypes ccrcc --mrna-algorithms xcell --prot-algorithms xcell --signatures ../signature_matrices/LM22.txt --tissueTypes all
Combining 2 files
Error in file(file, "rt") : cannot open the connection
Calls: main ... combinePatientCors -> do.call -> lapply -> FUN -> read.table -> file
In addition: Warning message:
In file(file, "rt") :
cannot open file 'correlation': No such file or directory
Execution halted
INFO [job get-patient-cors] Max memory used: 144MiB
ERROR [job get-patient-cors] Job error:
("Error collecting output for parameter 'table':\nfigures/plot-figs.cwl:36:9: Did not find output file with glob pattern: '['*.tsv']'", {})
WARNING [job get-patient-cors] completed permanentFail
ERROR [step get-patient-cors] Output is missing expected field file:///Users/pietro/Documents/GitHub/proteomicsTumorDeconv/perfEval/scatter-test.cwl#scatter-test/get-patient-cors/table
ERROR [step get-patient-cors] Output is missing expected field file:///Users/pietro/Documents/GitHub/proteomicsTumorDeconv/perfEval/scatter-test.cwl#scatter-test/get-patient-cors/fig
[step get-patient-cors] completed permanentFail

Pietro what branch are you on?

Ok. I've never tried running with only a single cancer type and algorithm. Can you run with the scatter test yaml file?

Actually I was able to run that command from the main branch. Do you receive any other errors?

I got this crash with this example command:
cwltool scatter-test.cwl --cancerTypes ccrcc --mrna-algorithms xcell --prot-algorithms xcell --signatures ../signature_matrices/LM22.txt --tissueTypes all
Combining 2 files
Error in file(file, "rt") : cannot open the connection
Calls: main ... combinePatientCors -> do.call -> lapply -> FUN -> read.table -> file
In addition: Warning message:
In file(file, "rt") :
cannot open file 'correlation': No such file or directory
Execution halted
INFO [job get-patient-cors] Max memory used: 144MiB
ERROR [job get-patient-cors] Job error:
("Error collecting output for parameter 'table':\nfigures/plot-figs.cwl:36:9: Did not find output file with glob pattern: '['*.tsv']'", {})
WARNING [job get-patient-cors] completed permanentFail
ERROR [step get-patient-cors] Output is missing expected field file:///Users/pietro/Documents/GitHub/proteomicsTumorDeconv/perfEval/scatter-test.cwl#scatter-test/get-patient-cors/table
ERROR [step get-patient-cors] Output is missing expected field file:///Users/pietro/Documents/GitHub/proteomicsTumorDeconv/perfEval/scatter-test.cwl#scatter-test/get-patient-cors/fig
[step get-patient-cors] completed permanentFail

Hi, Peitro, can you try to use the yaml file rather than using the command line? I suspect the problem is that some steps in scattering pipeline expect you provide many deconvoluted tables.

OK, now it works. I deleted the previous images with 'docker image prune -a'. Thanks @sgosline


Explosion logging

About the PR

Adds an admin log for each Actor entity that got damaged by an explosion, including how much damage it dealt.
Why / Balance

Admin QoL.
Technical details

This technically covers all explosions ever to exist. Testing has been done, but sometimes the log might look a little weird due to the cause being provided as an object (i.e. meteor).
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

n/a
Changelog

:cl:
ADMIN:

add: Explosions by grenades now cause a log trace per player entity that got damaged.

Upstream PR: https://github.com/space-wizards/space-station-14/pull/29762

Superceded by #2852 .


As a user, I want to see the treasury workflow throw democracy

We should show the referendum info in the timeline if it's for approving for rejecting treasury proposals.

[ ] Display referenda result to timeline, refer to SubSquare

Figma link
Preview

[ ] Add a icon which links to subsquare
[ ] Tag links to subsquare

Preview

[ ] Implement loading state
[ ] Implement error(unable to load the data) state

Figma link
Files
loading-animation icon.zip
Preview


Defer reaps not prompted due to failure

Rather than wait for the next read (which may never happen) to repair - try and defer, as the reaper will not process until the failure has cleared.

https://github.com/basho/riak_kv/issues/1869

https://github.com/nhs-riak/riak_kv/pull/2#issuecomment-1703760797


Updated openjdk_test file - use of ci.role.perf label in Jenkins

The change of adding ci.role.perf  needs to wait until both internal and external Jenkins have the machine labeled properly.
I think we should start with documenting the Perf machine requirements and ci.role.perf  machines at Adopt Jenkins. Ideally, we need at least one perf machine on each platform.

The change of adding ci.role.perf  needs to wait until both internal and external Jenkins have the machine labeled properly.
I think we should start with documenting the Perf machine requirements and ci.role.perf  machines at Adopt Jenkins. Ideally, we need at least one perf machine on each platform.

Hi @llxia looking at @sxa comment https://github.com/adoptium/aqa-tests/issues/2401#issuecomment-817853626.. is like he workes on it or something else

hi @norbline - based on my chat with @llxia and since we are trying not to break anyone who is currently using our scripts, the prudent thing to do as part of this PR is to create a method that checks if nodes of a particular label are online, something like:
def areNodesWithLabelOnline(labelToCheck) {
            String[] onlineNodes = nodesByLabel(labelToCheck)
            if (onlineNodes.size() < 1) {
                        return false
            }
            return true
}

before changing label, in your L159 check
if (params.BUILD_LIST.contains("perf") && areNodesWithLabelOnline(LABEL.minus("ci.role.test&&").concat("&&ci.role.perf")) {

and since we have a method, also replace L181-L182 with
areNodesWithLabelOnline(LABEL) {

Can you make these changes to this PR please?  then we can proceed to test and merge.  Thanks!

hi @norbline - based on my chat with @llxia and since we are trying not to break anyone who is currently using our scripts, the prudent thing to do as part of this PR is to create a method that checks if nodes of a particular label are online, something like:
def areNodesWithLabelOnline(labelToCheck) {
            String[] onlineNodes = nodesByLabel(labelToCheck)
            if (onlineNodes.size() < 1) {
                        return false
            }
            return true
}

before changing label, in your L159 check
if (params.BUILD_LIST.contains("perf") && areNodesWithLabelOnline(LABEL.minus("ci.role.test&&").concat("&&ci.role.perf")) {

and since we have a method, also replace L181-L182 with
areNodesWithLabelOnline(LABEL) {

Can you make these changes to this PR please? then we can proceed to test and merge. Thanks!

wow, thanks so much for the help @smlambert...

Note: I did not check yet if my code suggestions will work, so once you make the changes, you will need to run some Grinders on the changes @norbline :)

Note: I did not check yet if my code suggestions will work, so once you make the changes, you will need to run some Grinders on the changes @norbline :)
is this okay @smlambert ..failed on grinder https://ci.adoptopenjdk.net/job/Grinder/2778/
stage('Queue') {
def areNodesWithLabelOnline(labelToCheck) {
String[] onlineNodes = nodesByLabel(labelToCheck)
if (onlineNodes.size() < 1) {
return false
}
return true
} {
int ACTIVE_NODE_TIMEOUT = params.ACTIVE_NODE_TIMEOUT ? params.ACTIVE_NODE_TIMEOUT : 0
timeout(ACTIVE_NODE_TIMEOUT) {
// If there is available node before timeout
node(LABEL) {
echo "find the node with label as ${env.NODE_NAME}"
}
}
}

hi @norbline - I may have caused you to go in the wrong direction :)
The new method you added should not go where you have put it, but rather it can go near the end of the file just before the other method, checkErrors(errorList) is defined at Line303.
Also, the reformatting you have applied is not desirable, as it has gone and changed all of the " double quotes to ' single quotes, which is unneeded.  Perhaps you can undo your last commit and just adjust the indentation of the small section of code by hand (without invoking formatting in your IDE).
Message me if you want to connect and walk through the next code review over a video call where we share a screen.  :)


Improve typing of return type with or without withScore

Currently I have to cast the result of search to either a T[] or a { element: T; score: number; }[] depending on what I give for options.withScore.
In addition, there's the unexpected (to me) behavior that even with options as { withScore: true }, you can get a result of T[] if your searchText is falsey.
I propose two alternatives, one which simply improves types and one which would require a small behavior change but would improve types further:

(Non-breaking) Add overload types for the search function to narrow the return type in the withScore: false case:

@@ -61,6 +61,8 @@
     return round(1 - remainingTextAfterRemovingSearchWords.length / searchableDataStringWithoutNonWordCharacters.length, 4)
 }

+export function search<T>(elements: T[], searchableKeys: string[], searchText: string, options?: { withScore?: false }): T[]
+export function search<T>(elements: T[], searchableKeys: string[], searchText: string, options: { withScore: boolean }): (T | { element: T, score: number })[]
 export function search<T>(elements: T[], searchableKeys: string[], searchText: string, options: { withScore?: boolean } = {}) {
     if (!searchText) {
         return elements

(Breaking) Change the behavior of search when !searchText and withScore: true to still return the unfiltered list, but add the score anyways so the type is consistently dependent on options instead of searchText + options:

@@ -61,8 +61,14 @@
     return round(1 - remainingTextAfterRemovingSearchWords.length / searchableDataStringWithoutNonWordCharacters.length, 4)
 }

+export function search<T>(elements: T[], searchableKeys: string[], searchText: string, options: { withScore: true }): { element: T, score: number }[]
+export function search<T>(elements: T[], searchableKeys: string[], searchText: string, options?: { withScore?: false }): T[]
+export function search<T>(elements: T[], searchableKeys: string[], searchText: string, options: { withScore: boolean }): (T | { element: T, score: number })[]
 export function search<T>(elements: T[], searchableKeys: string[], searchText: string, options: { withScore?: boolean } = {}) {
     if (!searchText) {
+        if (options.withScore) {
+            return elements.map((x) => ({ element: x, score: 0 }))
+        }
         return elements
     }

Here is a workaround which accomplishes the same things without changing the library:
function typedSearch<T>(elements: T[], searchableKeys: string[], searchText: string, options: { withScore: true }): { element: T, score: number }[]
function typedSearch<T>(elements: T[], searchableKeys: string[], searchText: string, options?: { withScore?: false }): T[]
function typedSearch<T>(elements: T[], searchableKeys: string[], searchText: string, options: { withScore: boolean }): (T | { element: T, score: number })[]
function typedSearch<T>(elements: T[], searchableKeys: string[], searchText: string, options: { withScore?: boolean } = {}) {
    if (!searchText) {
        if (options.withScore) {
            return elements.map((x) => ({ element: x, score: 0 }))
        }
        return elements
    }
    return search(elements, searchableKeys, searchText, options);
}

// e.g.
type T = { a: string }
const stuff: T[] = [{ a: "1" }, { a: "2" }, { a: "3" }]
const a = typedSearch(stuff, ["a"], "2")        // T[]
const b = typedSearch(stuff, ["a"], "2", {})    // T[]
const c = typedSearch(stuff, ["a"], "2", { withScore: false })  // T[]
const d = typedSearch(stuff, ["a"], "2", { withScore: true })   // { element: T, score: number }[]
const e = typedSearch(stuff, ["a"], "2", { withScore: Math.random() < 0.5 })    // (T | { element: T; score: number; })[]

Thanks for flagging this typing improvement.
I think we could always return the score, but it could be undefined if you didn't pass the withScore option to keep the library fast if you don't care about the score.
This would provide a consistent result object.
That being said, it might introduce confusion to the end user if the score is always undefined.
I think it would be possible to have a conditional return type based on if the withScore attribute is true or false.
This might add type maintenance challenges though.
I'd love to get your take on this!

@MHebes I fixed the return type using conditional typing. This achieves the expected behaviour without the need for overloads, let me know what you think :)


How to get connect with DB in selenium MSTESTV2?

Description

As a part of my TCs, I want to get connect to DB and execute queries. Tried to find out references but didn't find much.
Is MSTESTV2 is supporting this? Is so, can someone please provide details to get connect DB while executing scripts in selenium?
For a defect specific to the MSTest V2 test framework, describe the issue you've observed.

@shirishnagarnz mstest v2 doesn't restrict you from connecting to a DB. you can connect to DB in the same way as you will do in a normal console app. The connection of DB code will vary from DB engine to engine. Search for samples on how to connect to DB via c# and you should find something

@shirishnagarnz as mentioned above, mstest v2 doesn't restrict you from doing that. Depending on the db you're planning to connect to it, you would have to use a specific library that help you doing that. There's a ton of example on the internet if you look for "how to connect to a sql database from c#".
Below is a short snippet that you could use right away to get connected to a SQL Server db:
var connectionString = "data source=YOUR_SQL_SERVER_NAME;initial catalog=YOUR_DB_NAME;persist security info=True;user id=USER_ID;password=PASS;MultipleActiveResultSets=True;";

using (SqlConnection con = new SqlConnection(this.ConnectionString))
{
   using (SqlCommand command = new SqlCommand(queryStatement, connection)
   {
        connection.Open();
        result = command.ExecuteReader();
        connection.Close();
   }
}

Of course, for the above code to work, you should have a SQL Server with a database on it. And the user/password part is optional, but you have to specify in the connectionString that you'd like to use
WindowsAuth.
Hope it helps getting this resolved!

@shirishnagarnz I am closing the issue. If you have any other queries do open another issue


Modified script for include all kserve poetry projects.

1. graph poetry project was not included in previous checks.
2. As poetry lock --check is deprecated, used `poetry check --lock`.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

/lgtm
/approve


[FEATURE]

Problem:
Objects having null properties are not allowed by Joi
Description:
Consider we make a request with an object
user = {
 name: 'john',
 age: null
}

This does not pass Joi check since age is null.
This becomes a problem with some Angular features like form.reset() which resets values to null.
because the code generates Joi.string().allow('')
i think it should include null like Joi.string().allow('').allow(null)
related code is at SwaggerUtils.ts:
      if (type === 'string' && !isRequired && !param.minLength) {
        validationText += `.allow('')`;
      }

closing as duplicate https://github.com/acrontum/generate-it/issues/58

I believe this may also require changes in the templates, but not 100%


Android: edge swipes conflict with gesture navigation

Hi. First of all, thank you for this amazing app. It's a blast to use on all kinds of screens.
I found some weird behavior on Android when gesture navigation is enabled with the app's default settings.
Swiping on the edge of the screen starts the built-in navigation, but when the system's back gesture kicks in, it gets canceled and the app falls into an inconsistent state.
The old page is still on top of the screen (albeit a bit translated to the side), but the address bar is showing the underlying page, and that page reacts to scroll and other events.
For example, here's a screenshot:

This was pretty confusing until I found in another issue that "Swiping from edge" can be disabled in the UI settings, a place I wouldn't have otherwise visited. Or that swiping in the middle of the screen can dismiss the stuck panel.

I believe that to avoid this, the app should either:

Disable the from edge gestures automatically if gesture navigation is enabled. In theory, it should be possible to detect this, starting with Android API level 30.
Handle the touch cancellation when the system gesture kicks in, and revert the halfway done navigation.
Start with edge gestures disabled on Android. That would align the app with Chrome's behavior: back gesture or back button to go back, depending on the system setting.

What do you think?

Thank you!
I don't know how popular gesture navigation is among all Android users either. But since it was introduced in Android 10, most phones out in the wild at least support it. Android 9 and below marketshare seems to be around 10-15% on various stats sites.


move docs python build and ignore

Is everything needed to build it in the appropriate npm script?

Coverage remained the same at 78.853% when pulling 35f2cab0cbab35e24ef6739d2beb2171825f5743 on mparke:move-python-build into 2cd079b7264b9bfd51b921bfda18b0f76b973a5b on linode:develop.

@eatonphil yes, It's part of https://github.com/linode/manager/blob/master/docs/prebuild.js which is run https://github.com/linode/manager/blob/master/docs/package.json#L7

Coverage increased (+0.03%) to 78.273% when pulling 27f08a2b6eb0b3f744869eaa9df2aa29e93b055b on mparke:move-python-build into 30f51749c589877f7eacd424ff7dccfca5d1aca7 on linode:develop.


Rivescript integration

this is a placeholder PR with an example rivescript integration.
The PR is a bit messy but I wanted to get something in time for the slackdevs meetup tonite, I'll cleanup with input from others too.
you probably don't want to merge this because of some mods to your error handling etc
https://github.com/howdyai/botkit/compare/master...dcsan:rivescript-integration?expand=1#diff-ffa8ec227ea6e9babdfc11d5a71ee29dL87
already updated. if anyone is interested better to clone from
https://github.com/dcsan/botkit

Please follow CONTRIBUTING.md for commit messages.

@dcsan Thanks for making this!

Please fix the conflicts and re-open the pull request.


fix: use attachTo in failing tests with jsdom v21.1

attachTo can be removed when https://github.com/jsdom/jsdom/issues/3502 is fixed
With jsdom v21.1, getComputedStyle is cached and not updated for elements not in the DOM
so some our tests fail (because the elements are checked a first time)
We'll probably see issues in Vue projects using VTU and jsdom as well, and we can point to this PR if that happens

@lmiller1990 We don't have to, I'm fine either way 😉
It's just that:

I was happy to have a workaround and to share it with you
I'm not even sure jsdom is going to fix it
I wanted to have something to point out if someone opens an issue (we had the same issues in our projects of course)
It unblocks Renovate

That's fair - happy to move forward with this.
Once we merge up all the deps PRs, we can do another release - good to have the latest code in the wild, even if it's just dev dependencies updates that don't make a difference - good to keep a fast release cadence.


Permit post-process merging in custommap schemas

To overcome the limitations in #350, I've been using these modifications locally.
I'm not sure which direction @msbarry would like to take with this functionality, but I'm sharing this PR in case its useful.

I'm not sure which direction @msbarry would like to take with this functionality, but I'm sharing this PR in case its useful.

In the future I want to make the post processing more flexible, so you can limit the fields features get grouped by, and tell planetiler how to combine the rest (for example bridges) and also make line merging more flexible so it can maintain direction (ie. for oneway roads).  Also, I want to move every fixed number to support being an expression so it can vary by zoom/feature attributes (see #298).  That being said, this is a good first step and we can add those later without breaking compatibility since they will just add extra keys, or allow changing a numeric value to a complex object or expression.

I just landed  #421 so you can set min_size: 0 on features now

Thanks for reviewing this @msbarry!
I have quite a lot of paid work to get through at the moment, but I hope to return to this and implement the points you raised.

Hey @zhibek just checking do you think you'd have a chance to add this to the json schema  and planetiler-custommap/README.md? Or do you want me to add those in? Would be great to get this merged!

Thanks for the nudge @msbarry. I'm aiming to implement the final points this weekend. But feel free to adjust if I miss anything.

OK @msbarry - I think that's everything. But feel free to modify if I missed something.


Please disable Ctrl + X

Please disable Ctrl + X

and Ctrl + Z

Hi! @HeiMaoJingZhangGiaoGe Thank you for your suggestion!
I’ll add the functionality to disable Ctrl + X and Ctrl + Z soon. Stay tuned for updates!


PostgreSQL migration updates

Fixes for #415

Codecov Report

Merging #417 (fc57366) into main (bdbc50a) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head fc57366 differs from pull request most recent head e42e3e1. Consider uploading reports for the commit e42e3e1 to get more accurate results

@@            Coverage Diff            @@
##              main      #417   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          277       277
  Lines        14845     14850    +5
=========================================
+ Hits         14845     14850    +5

Impacted Files
Coverage Δ

pkg/fftypes/jsonobject.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdbc50a...e42e3e1. Read the comment docs.


support submit query session transaction (WIP)

Implement Submit Session Query
Resolve ISSUE: https://github.com/dbpunk-labs/db3/issues/126

[x] Add QuerySessionPayload type to WriteRequest
[x] Support CheckTx and DeliverTx for QuerySession transactions in ABCI
[x] Apply apply_query_session: apply BillForQuery
[x] estimate_query_session_gas
[ ] Submit query session in db3 node
[ ] Add integration test and ut

Codecov Report

Merging #231 (579b7a9) into main (b935dd5) will decrease coverage by 0.22%.
The diff coverage is 43.11%.

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   53.12%   52.90%   -0.23%
==========================================
  Files          37       38       +1
  Lines        3070     3308     +238
==========================================
+ Hits         1631     1750     +119
- Misses       1439     1558     +119

Flag
Coverage Δ

rust
52.90% <43.11%> (-0.23%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/cmd/src/lib.rs
71.62% <ø> (ø)

src/error/src/lib.rs
50.00% <ø> (ø)

src/node/src/abci_impl.rs
0.75% <0.00%> (-0.33%)
:arrow_down:

src/node/src/auth_storage.rs
1.13% <0.00%> (-0.23%)
:arrow_down:

src/node/src/storage_node_impl.rs
0.80% <0.00%> (-0.01%)
:arrow_down:

src/proto/src/lib.rs
100.00% <ø> (ø)

src/sdk/src/store_sdk.rs
91.30% <ø> (ø)

src/session/src/lib.rs
100.00% <ø> (ø)

src/session/src/session_manager.rs
90.54% <ø> (ø)

src/session/src/query_session_verifier.rs
92.23% <92.23%> (ø)

... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Help Requested unknown parameter 'id' for row 0, column 0

Hi AltEditor,
Thank you for your awesome alternate :).
I facing a problem when i try to ADD and EDIT. I receive message like this
_

DataTables warning: table id=host - Requested unknown parameter 'id' for row 0, column 0. For more information about this error, please see http://datatables.net/tn/4

_
heres my script table : https://plnkr.co/edit/32WyF23xXWQ0gFFD?preview
thanks

Hello.
The problem is in the webservice answer.
AltEditor expects that the webservice returns the exact data inserted on database, and shows it in the Datatable. Your webservice
https://bundadaycare.com/itg/api/datahost.json
is returning something different (maybe the whole list?)
If you search in the closed issue, you will find that several people had a similar problem in the past.
You can also look at the "examples" section to see what kind of answer is expected.

Hello.
The problem is in the webservice answer.
AltEditor expects that the webservice returns the exact data inserted on database, and shows it in the Datatable. Your webservice
https://bundadaycare.com/itg/api/datahost.json
is returning something different (maybe the whole list?)
If you search in the closed issue, you will find that several people had a similar problem in the past.
You can also look at the "examples" section to see what kind of answer is expected.

Awesome !! after I test on rest API. it works properly.
but I facing another problem when I try to post or put multiple select. i get response 500.

and this one my controller

Thanks !

@inihaekal did you solve this?


URI's protocol is not removed in GCSFileSystem.get

I've been using GCSFileSystem.get with recursive=True, and ran into some unexpected (to me) behavior: the first few characters of the local file names were missing. It looks like this happens when a gs:// protocol is in the path.
After some digging, I realized that the recursive get is using GCSFileSystem.walk to get the paths to copy (which returns canonicalized paths from gcsfs.core.norm_path), but then it uses the length of original remote path (including the gs:// protocol) to piece together the output paths.
My question is: Is it required that there is no protocol in the path passed to get?
If not, I'm happy to open up a PR that simply uses norm_path in get. Wanted to make sure I'm not just using the library in an unexpected way first though.

Should be easy to correct inline https://github.com/dask/gcsfs/blob/master/gcsfs/core.py#L932 ? Of, you could simply rpath = norm_path(rpath) at the start of the function?
Would you be interested in submitting a PR with test?

That's exactly what I was thinking 👍
And yep, I can make a PR a bit later today


Support Ubuntu 22.04 for Swift 5.7

[ ] Add Docker image for Ubuntu 22.04 on swift-docker repo
[ ] Add Swift CI jobs to build nightly toolchains
[ ] Update the automation to include Ubuntu 22.04 toolchain
[ ] Update the website to include links to Ubuntu 22.04

Currently, the release/5.7 does not contain all of the Python 3 changes required to support Ubuntu 22.04.

Can't wait, we are moving our test servers to 22.04.

https://github.com/apple/swift-llbuild/pull/838

https://github.com/apple/swift-package-manager/pull/5743

https://github.com/apple/indexstore-db/pull/157

https://github.com/apple/sourcekit-lsp/pull/616

https://github.com/apple/swift-docc/pull/370

https://github.com/apple/swift-org-website/pull/126

Ubuntu 22.04 now available on swift.org for nightly snapshots.


merge setup repositories

Merge the raspbian-setup repository to the current one.
Use
cat /etc/issue
cat /etc/debian_version
hostnamectl
to differentiate between operating systems and versions.

No longer applicable.


Build fails on iOS on 7.3.1 (M1 Silicon)

I upgraded from 7.2.0 to 7.3.1, and it seems that the new Expo plugin is messing things up,
🐛 Bug Report
I upgraded from 7.0.1 to 7.3.1, and it seems that the new Expo plugin is messing things up.
Error
The following build commands failed:
PhaseScriptExecution [CP-User]\ Generate\ Specs /Users/user/Library/Developer/Xcode/DerivedData/electra-efhopmcbavxoswdwpxqrefpzlblb/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FBReactNativeSpec.build/Script-0C645E84D737C4B3EF4A9A92FB79B97C.sh (in target 'FBReactNativeSpec' from project 'Pods')
CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler (in target 'ExpoAdapterFBSDKNext' from project 'Pods')
CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler (in target 'ExpoAdapterFBSDKNext' from project 'Pods')
To Reproduce
Create a new reactive native app, use expo modules, add fbsdk, build
Expected Behavior
Build passes
Environment
System:
OS: macOS 12.1
CPU: (8) arm64 Apple M1
Memory: 100.47 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.14.0 - ~/.nvm/versions/node/v16.14.0/bin/node
Yarn: 1.22.17 - /opt/homebrew/bin/yarn
npm: 8.3.1 - ~/.nvm/versions/node/v16.14.0/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.2 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
Android SDK: Not Found
IDEs:
Android Studio: 2021.1 AI-211.7628.21.2111.8193401
Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
Languages:
Java: 11.0.12 - /opt/homebrew/opt/openjdk@11/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.67.2 => 0.67.2
react-native-macos: Not Found
npmGlobalPackages:

Create a new reactive native app, use expo modules, add fbsdk, build

Can you list out the exact commands you use to reproduce this, every command + argument? That would really help
@giautm  - possibly of interest - seems the expo plugin might break builds for expo users but I'm not sure what it could be until I get a full repro

The Expo adapter was written in Swift. So please make sure you have latest version of Swift SDK (5.4 is required version).
I dont have a Mac M1 for testing right, but looking for you repo to send to someone able to test.

I have an M1 I can do build testing on no problem, but I have literally zero expo experience, I will need the exact list of steps to reproduce

The following build commands failed:
PhaseScriptExecution [CP-User]\ Generate\ Specs /Users/user/Library/Developer/Xcode/DerivedData/electra-efhopmcbavxoswdwpxqrefpzlblb/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FBReactNativeSpec.build/Script-0C645E84D737C4B3EF4A9A92FB79B97C.sh (in target 'FBReactNativeSpec' from project 'Pods')
CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler (in target 'ExpoAdapterFBSDKNext' from project 'Pods')
CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler (in target 'ExpoAdapterFBSDKNext' from project 'Pods')

This error is not really helpful; So, can you share full build log? @yemd

I am also facing this error.

@AlexandreLage not a useful report, there is nothing actionable in this issue if you read the comments
https://stackoverflow.com/help/how-to-ask
https://stackoverflow.com/help/minimal-reproducible-example
https://medium.com/hackernoon/i-thought-i-understood-open-source-i-was-wrong-cf54999c097b
Until someone provides actual information this stays closed because there's nothing to do, sorry

Now, I also have an M1 chip for testing, if you facing the issue, please attach the build error log, then I will take a look. :D

I am facing same issue with 8.0.0, has anyone found any work around for the same?
I am having 0.68.1 RN version.

We can't find a work around because people keep submitting low quality issue details and comments.
Please please please imagine you are some random person on the internet, donating their time to help other random people on the internet for who knows what reason.
And someone comes to and says "I am facing the same (poorly specified, no reproduction) issue (except now on a different version)? Anyone have a solution?
Sure, we have lots of solutions. but we don't know what your problem is
Quality issue reports! Honest work to specify your problem. You do that, we help you
https://stackoverflow.com/help/how-to-ask
https://stackoverflow.com/help/minimal-reproducible-example
https://medium.com/hackernoon/i-thought-i-understood-open-source-i-was-wrong-cf54999c097b


Use super() instead of copying function contents

What does this PR do?
Uses super()._sanitize_parameters() instead of copying the function contents.

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Version 0.6.0 core functionality broken

Version 0.6.0 of this module doesn't seem to work. I have tried on FoundryVTT version 0.7.7, using the latest DnD5e and PF2 systems, with the "Hide Private GM Rolls" setting enabled, and in all cases, a chat card still appears for the players.
I have tested with no other modules installed, so I believe this must be broken.

Whoops! Did some refactoring last update and accidentally dropped the call to this method, fixed in 0.6.1 that should be live soon.


Bump to NDK LTS

Based on: https://developer.android.com/ndk/downloads
The old NDK cannot be found as well:
Warning: File /root/.android/repositories.cfg could not be loaded.ry...
Warning: Failed to find package ndk;20.1.5948944                                .
#10 18.92 [===                                    ] 10% Computing updates...
------
executor failed running [/bin/sh -c curl https://dl.google.com/android/repository/sdk-tools-linux-4333796.zip > /aosp/sdk-tools-linux.zip &&     unzip /aosp/sdk-tools-linux.zip -d /aosp/sdk &&     yes | /aosp/sdk/tools/bin/sdkmanager --licenses &&     /aosp/sdk/tools/bin/sdkmanager "platform-tools" "ndk;20.1.5948944" "platforms;android-32" "build-tools;30.0.0" &&     ln -s /aosp/sdk/ndk/20.1.5948944 /aosp/sdk/ndk-bundle &&     rm /aosp/sdk-tools-linux.zip]: exit code: 1

Seems to work now? Closing.


Refactor Code

We did a lot of refactoring already but we can still do more!

I think we've done enough for this version.


Increase ginkgo timeout for default serial shoot suite

How to categorize this PR?
/area testing
/kind regression
What this PR does / why we need it:
With the update to ginkgov2 (with  https://github.com/gardener/gardener/pull/5313)  the default for the timeout
is reduced to 1h and is applied to the whole test suite (see doc below).
On slower cloud providers we see test suite runs of over one hour
and consequently running into the suite timeout.
From Ginkgo docs https://onsi.github.io/ginkgo/MIGRATING_TO_V2#timeout-behavior:

Timeout Behavior
In Ginkgo V1.x, Ginkgo's timeout was managed by go test. This meant that timeouts exited the test suite abruptly with no opportunity for custom reporters or clean up code (e.g. AfterEach, AfterSuite) to run. This is fixed in V2. Ginkgo now manages its own timeout and when a timeout triggers the test winds down gracefully. In fact, a timeout is now functionally equivalent to a user-initiated interrupt.

In addition, in V1.x when running multiple test suites Ginkgo would give each suite the full timeout allotment (so ginkgo -r -timeout=1h would give each test suite one hour to complete). In V2 the timeout now applies to the entire test suite run so that ginkgo -r -timeout=1h is now guaranteed to exit after (about) one hour.

Finally, the default timeout has been reduced from 24h down to 1h. Users with long-running tests may need to adjust the timeout in their CI scripts.

Special notes for your reviewer:
I will take care of a cherry-pick to v1.40
cc @timebertt
Release note:

Increase the ginkgo timeout for default shoot serial test suite to prevent timeouts on tests

Thanks to @dguendisch for his comments. I added:

set activeDeadlineSeconds to 4200 = 70 min for testdefs where the ginkgo timeout is 1h (default) so that the logs can still be written before the concourse run is canceled
set the ginkgo timeout also to 2h for the shoot default suite (I also saw a timeout happening there)
set the ginkgo timeout to 2h for the  shoot default serial suite as that should be enough (runs are usually up to 1h20 minutes long) and adapt activeDeadlineSeconds accordingly to be slightly more that the ginkgo timeout

/retest


Add Troubleshooting content

When following the steps to add the Cloud Witness, i received an error regarding WinRM. I have seen in other forums people with this same issue. Is there a workaround or solution for this error?
Only happens in Win 2019. Win 2016 works fine.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4b112fd4-0bd2-ca4d-5d45-15396a00820a
Version Independent ID: 34bffa79-1d32-aeeb-1577-8cc94808544c
Content: Deploy a cloud witness for a Failover Cluster
Content Source: WindowsServerDocs/failover-clustering/deploy-cloud-witness.md
Product: windows-server
Technology: storage-failover-clustering
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close

#assign:IngridAtMicrosoft


whatsapp-for-linux blank screen when application starts

Describe the bug
When launching the application nothing is drawn on the screen, although resources are still downloaded
Output from terminal
~ took 2s ✦ ❯ nix-shell -p whatsapp-for-linux

~ via ❄  impure (shell) ✦ ❯ whatsapp-for-linux
<13>Dec 11 09:56:01 whatsapp-for-linux[84137]: SettingMap: Key file does not have group “Network”, returning default value.
<13>Dec 11 09:56:01 whatsapp-for-linux[84137]: Could not determine the accessibility bus address
<13>Dec 11 09:56:01 whatsapp-for-linux[84137]: SettingMap: Key file does not have key “close_to_tray” in group “General”, returning default value.
<13>Dec 11 09:56:01 whatsapp-for-linux[84137]: SettingMap: Key file does not have key “start_in_tray” in group “General”, returning default value.
<13>Dec 11 09:56:01 whatsapp-for-linux[84137]: SettingMap: Key file does not have key “header_bar” in group “General”, returning default value.
<13>Dec 11 09:56:01 whatsapp-for-linux[84137]: SettingMap: Key file does not have key “start_in_tray” in group “General”, returning default value.

Screenshots

Output from webconsole
[Warning] Another connection wants to delete database 'wawc'. Closing db now to resume the delete request. (vendor1~app.58a51d93a250f83ab555.js, line 7)
[Warning] AES-CBC and AES-CTR do not provide authentication by default, and implementing it manually can result in minor, but serious mistakes.  Please make sure it wasn't preloaded for nothing.

Notify maintainers
@wandersoncferreira
Metadata
~ ✦ ❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.80, NixOS, 22.11 (Raccoon), 22.11.466.596a8e828c5`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.11.0`
 - channels(root): `"nixos-22.11"`
 - channels(mathiassven): `"home-manager-22.11.tar.gz"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

I've the same issue on Ubuntu 23.10.

I had this problem on NixOS until I turned off hardware acceleration in Whatsapp-for-linux preferences (web tab) . At this point the window corrupted. I relaunched it and then it was usable.

Note: hardware acceleration can be disabled by editing ~/.config/whatsapp-for-linux/settings.conf:
[web]
hw-accel = 2

Alternatively, I found out that WEBKIT_DISABLE_DMABUF_RENDERER=1 helps in my case, but unlike OP I have "AcceleratedSurfaceDMABuf was unable to construct a complete framebuffer" errors in the console output, indicating it's webkit2gtk bug.


Possible RmqMessageProducer Dispose Problem

I've created a microservice setup that uses TopShelf to host a OWIN self host service which starts a WebApp... pretty standard setup.  This microservice accepts a command, handles it, packages it up into an event which gets published to a RabbitMQ exchange.
My command processor setup seems trivial:
        RmqMessageProducer gateway = new RmqMessageProducer(logger);

            var commandProcessorBuilder = CommandProcessorBuilder
                .With()
                .Handlers(new HandlerConfiguration(BuildSubscriberRegistry(),
                    new AutofacCommandHandlerFactory(c.Resolve<IComponentContext>())))
                //.NoPolicy()
                .Policies(BuildPolicyRegistry())
                .Logger(logger)
                //.NoTaskQueues()
                .TaskQueues(new MessagingConfiguration(couchbaseMessageStore,
                    gateway, BuildMessageMapperRegistry(c.Resolve<IComponentContext>())))
                .RequestContextFactory(new InMemoryRequestContextFactory());

When I start the service and immediately stop it everything shuts down fine.
If I start it and actually send in a command the command is handled properly but when I shut down the service the service stops but the window does not close.  Visual Studio indicates that there is still a process running.  My investigation seems to point to the RmqMessageProducer not getting cleaned up.  If I turn off the policies and the task queues (bypassing the queue code) the service will shut down correctly.  Something is keeping the process running despite the Stop method being called on my service.
Any suggestions of what I can look into?

@critchie I'm going to try replicate this today, hopefully something simple. The rabbitmq client has been a pain to deal with.

I'll be glad to try any ideas you decide to try.
-Craig

On Mar 2, 2015, at 5:29 AM, Toby Henderson<EMAIL_ADDRESS>wrote:
@critchie I'm going to try replicate this today, hopefully something simple. The rabbitmq client has been a pain to deal with.
—
Reply to this email directly or view it on GitHub.

How often do you release to NuGet?

@critchie First, all of our Appveyor builds become NuGet packages, so you can download them. Just pick a build you want to use https://ci.appveyor.com/project/IanCooper/paramore/history and then click on the artefacts tab
Once you have the NuGet package locally, you can use them directly (see http://stackoverflow.com/questions/10240029/how-to-install-a-nuget-package-nupkg-file-locally)
It may be the easiest solution if you need bug fixes ahead of a push to the NuGet servers.
We then push to the NuGet servers when we think we have some stored value to share that we think everyone should take. It's very unlikely to be more than once every two weeks, and more likely to be once every month or two

Perfect thanks.

On Mar 6, 2015, at 9:32 AM, Ian Cooper<EMAIL_ADDRESS>wrote:
@critchie First, all of our Appveyor builds become NuGet packages, so you can download them. Just pick a build you want to use https://ci.appveyor.com/project/IanCooper/paramore/history and then click on the artefacts tab
Once you have the NuGet package locally, you can use them directly (see http://stackoverflow.com/questions/10240029/how-to-install-a-nuget-package-nupkg-file-locally)
It may be the easiest solution if you need bug fixes ahead of a push to the NuGet servers.
We then push to the NuGet servers when we think we have some stored value to share that we think everyone should take. It's very unlikely to be more than once every two weeks, and more likely to be once every month or two
—
Reply to this email directly or view it on GitHub.


demo

greateful work，have you done or will to run completely the  demo inference？why the points num is 137,  debugger.add_coco_face_lm(bbox[12:149], img_id='landmark', text=ind)?

greateful work，have you done or will to run completely the demo inference？


Updating the store app

Resolved pagination issue on the shop page
Worked on the multiple image uplaod for perfumes
Done with all the request methods for perfumes and categories
Done with the reviews module and endpoints
Worked on the perfume recommendation to be displayed on the
perfume detail page

Looks good


Avoid null ref exception when package is not loaded

This mitigates the symptoms of issue #181
Maybe we need another fix to actually load the package even for non-Rust projects? I'm not sure if that's possible / desirable. But at least with this fix Rust files are editable from other kinds projects, syntax highlighting also works...

Also added a sanity check in FindInstallPath to ignore directories without rustc.exe. Some people just delete Rust folders from disk without properly uninstalling... We can't change people, but we can change the code :-)
This would cover issues #182 and #187.

Perfect


Adding an external Azure AD group to the api management does not work as described

"To add an external Azure AD group into APIM, you must first complete the previous section. Additionally, the application you registered must be granted access to the Microsoft Graph API with Directory.Read.All permission by following these steps."
Adding this permission from the Microsoft Graph API is not sufficient: when trying to load the list of groups, one gets an error message. What does work is adding the permission with the same name from the deprecated Azure Active Directory Graph tile, as described in the workaround to this issue: Azure Active Directory Graph: https://github.com/MicrosoftDocs/azure-docs/issues/56345 from June 2020. So:

The documentation is (still) incorrect/The documented solution (still) doesn't work.
The work around (still) involves a deprecated API.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 692852cd-11a6-1d6b-9540-caec9d0f14a4
Version Independent ID: 4c376561-6015-6dab-e23e-feffe74ccc8b
Content: Authorize developer accounts by using Azure Active Directory - Azure API Management
Content Source: articles/api-management/api-management-howto-aad.md
Service: api-management
GitHub Login: @miaojiang
Microsoft Alias: apimpm

Hello @mrickly,
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.
@miaojiang, could you please have a look at this issue. Thank you!

Thank you @ChaitanyaNaykodi-MSFT , @miaojiang : I see that the documentation has been fixed. However, it does not explain why I need to add permissions for the deprecated Azure Active Directory Graph API. Can you share some insights on the Microsoft roadmap regarding the Azure Active Directory Graph? Are there plans to make sure that the Azure Active Directory Graph API permissions are not needed anymore in some future release?

Hi @ChaitanyaNaykodi-MSFT - could you tag the issue of using a legacy/depreciated Azure AD Graph API as "product feedback", so that it gets assigned to the product team? Thank you!

Hello,
Running into the same issue.
Since the legacy AAD Graph is planned to be deprecated in June 2022, we are unable to add such permissions to the registered app.

Thanks!
AR

Any updates to this? June 2022 is coming really fast.

I believe this issue has been addressed in intervening updates to this article that clarify the required permissions in Graph API.
#please-close


Integration-test re governance & feegrant module

Summary
Verify in an integration test that the blob module's GasPerBlobByte param is indeed changeable via governance.
ref: https://github.com/celestiaorg/celestia-app/issues/1380
Problem Definition
It's unclear if custom module params need to pass around governance (and later authz) codecs to be able to function properly. See for example:

https://github.com/cosmos/cosmos-sdk/blob/340c01bf5a84118f29a8c7d10170abce58b7981c/x/staking/types/codec.go#L65-L66 (gov and authz codecs being passed around in the staking module)
https://github.com/osmosis-labs/osmosis/blob/9bc52d49bf9896850dd5d31d5af90cc22ea8b7ce/x/incentives/types/codec.go#L36-L39(for passing around the authz codec in osmosis' incentives module).

Proposal
write integration test
For Admin Use

[X] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Verify in an integration test that the blob module's GasPerBlobByte param

this is tested in a stateful way in #1772, where we update blob module params and check that those updates actually occurred after the proposal passes.

I think similarly, we should validate if the feegrant module works well with the blob module. I.e. can we give a fee-allowance for submitting PFBs?

in the past our txsim used feegrant with the blob module, but we could definitely re-add similar tests.


fix(prefetch): fail step when error happen

Task were failing silently causing harder to debug errors or misleding users that different step failed. Ensure that steps aren't failing silently and we don't run unnecessary steps after failure.

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

/retest

e2e Fails at this
container step-unregister-rhsm: \ncp: cannot stat '/shared/rhsm/consumer/*': No such file or directory\n\


Add background colors to images

This improves perceived performance on slow connections by displaying a background color while the image is loading.

Doesn't seem worth doing, looks worse than a plain colour.
How are the gradient specifications created? Would we have to generate a gradient specification from an image for each image added to a gallery? It doesn't seem automatic.
:-1:

@paramat The gradient specification has to be added manually (since we don't have a build pipeline set up), but the declaration can be generated using this tool. Either way, it's not like we add new images to the gallery every month :slightly_smiling_face:

I don't think this looks very nice. Perhaps a more subtle appearance, or a solid grey would be better

Solid grey is much better as it requires no manual matching to the current images. Also looks better than weird gradients.

I amended the pull request to only add background colors to images on the homepage.

Actually, I think a lighter grey would look better - #ccc for example

@rubenwardy I replaced the background color with #ccc.

Bump :slightly_smiling_face: Could this be merged, please? I replaced the gradients with a simple gray color which is easier to maintain if we update the screenshots.

Bump :slightly_smiling_face: Could this be merged, please? I replaced the gradients with a simple gray color which is easier to maintain if we update the screenshots.


bundle.js not created in development mode

My application starts with index.html served through express router
Next I need to enable react-router.My application entry point is client/index.js which looks like this:

/**
 * Client Entry Point;
 */

import 'babel-polyfill';  //certain functions like array.from , set, map can't be transpiled by babel so ue poyfill for that
import React from 'react';
import {  render } from 'react-dom';
import { Router, browserHistory } from 'react-router';
import  routes  from './routes';

render((
  <Router history={browserHistory} routes={routes}/>),
  document.getElementById('app')
);

console.log("In index js render ")

Above console statement is never consoled. It is set as entry point in webpack.dev.js . It should also output the bundled file app.js or bundle.js (whatever called in webpck config) but that never gets created. I believe I need to add that bundle file in index.html for react-routing to start thereafter?
I tried running npm run bs and the file server.bundle.js was created just fine in dist folder .Why is it not getting created in development mode?Also, why is react-router not working in this arrangement? Could I get some help on this please?
also, if I add a script tag in my index.html i.e
<script src="index.js>
It can't find it. No matter whatsoever js file I try to import here. It can't "see" it. resulting in an error: unexpected symbol <!DOCTYPE> from index.html. (!Doctype isn't the problem). It keeps giving the same error even when I take off Doctype and no matter which script file I try to import.

Probably a bit delayed to answer this one, but a lot of this will change as we implement React Router V4 and webpack 4...so keep following our updates.


nosetest verbose mode

Coverage remained the same at 85.519% when pulling 0e76310c6deecaca1ac7ea78537c7e0b49988fa1 on reset_password into 7fc8c70172a33ff4f8150c9d6142e85d9fd32e7e on master.


optimize the flow management panel

At present, the platform has 80 flow and needs to optimize the flow management panel
Problem:
1、Slow opening speed
2、There is no hierarchy in management
Hope for improvement:

Add close button to each tab
flow can be saved and opened through catalog
Reference example:

thanks!
regard.

The issue template you have deleted asks that feature suggestions are made on the forum. This issue list is for bugs and code issues. It is not where we maintain our backlog of features.

Just to add, the topic of managing flows has been discussed frequently on the forum. Please search to see what has been discussed and what is already in the plan to address it.


src/routes: Update pydantic dict() to model_dump()

.dict() method for converting a pydantic BaseModel to a dictionary is deprecated. This PR updates it to the new method, .model_dump()

LGTM! Rebase the branch to main to pass all checks.

alright, will do


[9.x] Map integer parameter to parameter name when resolving binding field

Fixes #42541
First of all, I'm really sorry about all the issues the initial PR has caused 😞
Summary
This PR reverts most of the changes of the original PR (#42425) while still fixing the bug described in the PR. The only method that was changed was the bindingFieldFor method of the Route class. All changes to ImplicitRouteBinding and RouteUri were reverted.
To fix the bug described in the original PR, we now resolve the parameter index to the parameter name by looking it up in the route's parameterNames array.
public function bindingFieldFor($parameter)
{
    if (is_int($parameter))  {
        $parameter = $this->parameterNames()[$parameter];
    }

    return $this->bindingFields[$parameter] ?? null;
}

This means that we no longer have to change the structure of the bindingFields array itself like in the original PR. The bug described in the related issue (#42541) was due to the fact that the ResourceRouteRegistrar also filled the route's binding fields with null values, just like my change in the original PR. The problem with that is that both of these implementations used null to signal the exact opposite of each other. My PR used null to mean "don't scope this parameter", whereas the ResourceRouteRegistrar used it to mean "scope this parameter but default to the model's route key name".
I left in all the additional tests I added since all the problems that got reported due to my original PR were not covered by any existing tests.

FYI I think this PR introduced a breaking change in a rather exotic edge case. I posted a bug report (https://github.com/laravel/framework/issues/42605), but I closed it myself when I realized that it only happens if you ask the route() helper to turn models into query params. Which is obviously a mistake, but up until v9.14 it produced valid URL's. Now it produces 500 errors.


Fixes #1763

Twitter login now works for majority of users
Removed Twitter service as once Twitter app registration is configured correctly you can retrieve the user email address directly from the claims returned by the Twitter middleware by setting the correct bool property in the options.
Any users who do not have a twitter email will currently not be able to log in (#1779 opened to address this)

@shahiddev I just pulled this local and ran it, and it works great. Thanks for digging into this problem and finding a viable solution.
cc @stevejgordon I'm going to approve the code review.


Declarative macro_rules! attribute macros

Many crates provide attribute macros. Today, this requires defining proc
macros, in a separate crate, typically with several additional dependencies
adding substantial compilation time, and typically guarded by a feature that
users need to remember to enable.
However, many common cases of attribute macros don't require any more power
than an ordinary macro_rules! macro. Supporting these common cases would
allow many crates to avoid defining proc macros, reduce dependencies and
compilation time, and provide these macros unconditionally without requiring a
the user to enable a feature.
I've reviewed several existing proc-macro-based attributes in the ecosystem,
and it appears that many would be able to use this feature to avoid needing
proc macros at all.
Rendered

Nominated as a follow-up to recent lang discussions about this.

how will this work in macro form? or is rust-lang/rust#39412 decl_macro still a thing
// ok
macro main {
    attr() ($func:item) => { make_async_main!($func) },
    attr(threads = $threads:literal) ($func:item) => { make_async_main!($func, $threads) },
}

// ?
macro stub attr() ($func:item) {
    make_stub_func!($func)
}

@kennytm

how will this work in macro form?

macro is unstable and incomplete; if someone is working on it they can determine that. Your syntax proposal seems like a fine existence proof that it's possible to provide syntax for this.

We had a @rust-lang/lang design meeting today on the set of macro RFCs. I've updated the RFC to incorporate all the feedback from that design meeting.
Per the feedback in that meeting, I'm starting an FCP to start letting people register consensus for this RFC.
@rfcbot merge