Add support for assert_true and assert_false to RSpec/Rails/MinitestAssertions

related to #1485
This PR add support for assert_true and assert_false to RSpec/Rails/MinitestAssertions.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Ah I missed some comments. Hmm. I think we should distinguish between Minitest and Test:: Unit.
I thought it best not to support assert_true and assert_false in this Cop. It would be better to discuss the extent of this support first. For example, it looks like it could be transferred to a Cop called RSpec/TestUnitAssertions.

fwiw I currently vote for "have a single cop" because these all seem to be using the same structure and as a downstream user my focus is on "use expect consistently" - that doesn't matter if the assertions come from Minitest, Test::Unit, or Rails.
Put another way: I don't think I've yet seen a technical reason for having different cops? i.e. the assertions so far have followed the same logic and structure regardless of where they're actually from.
If people want to rename it to something like RSpec/PreferExpectInsteadOfAssert, that'd be fine with me but I think having two cops based on "Minitest vs TestUnit" when they have the same behaviours is just adding more work for ourselves (and to take that a step further: should we have a third cop dedicated to Rails' extension assertions?)

@G-Rath Thank you for expressing your opinion.

Put another way: I don't think I've yet seen a technical reason for having different cops?

In many cases, I think there is no problem to combine them into one cop. However, as the devil's advocate, I would like to deepen this discussion.
For example, the following comments seem to be points where different actions are required. The compatibility of assert and refute is different between Minitest and Test:: Unit.

https://github.com/rubocop/rubocop-rspec/pull/1786#discussion_r1460740373

Also, the adapter to Minitest is defined in rspec-rails, which is appropriate for the RSpec/Rails department.
https://github.com/rspec/rspec-rails/blob/main/lib/rspec/rails/adapters.rb#L140
Note, however, that Unit:: Test exists in rspec-core.
https://github.com/rspec/rspec-core/blob/f8c8880dabd8f0544a6f91d8d4c857c1bd8df903/lib/rspec/core/test_unit_assertions_adapter.rb#L9
In other words, it seems odd to enable Cop for the RSpec/Rails department if you are using Unit:: Test-style assertions and not rspec-rails.

However, as the devil's advocate, I would like to deepen this discussion.

Yup fully in support of that, and in doing so sooner rather than later.

In other words, it seems odd to enable Cop for the RSpec/Rails department if you are using Unit:: Test-style assertions and not rspec-rails

Just want to check that I'm understanding what you mean correctly, which is effectively: it's weird for someone who's using just Unit::Test but not Rails, to enable a Rails cop.
If so then yes I agree with that - I'd wondered why this was considered a Rails cop though you've pointed out it's rspec-rails that has the Minitest adapter so I'm guessing that is (or was...) the why.

odd to enable Cop for the RSpec/Rails department if you are using Unit:: Test-style assertions and not rspec-rails.

Fair enough, but in the future when we extract rubocop-rspec_rails, we could also extract Rails-specific assertion detectors from this cop, and make the cop open for extension.
We’ll depend on rubocop-rspec from rubocop-rspec_rails, right?

Probably best to take this to the issue, but there's also Capybara assertions we could be translating, and I'd like to also include aggregate_assertions as it seems very solid and 1:1 with aggregate_failures

We’ll depend on rubocop-rspec from rubocop-rspec_rails, right?
Oh, I see. If we needs to extract to rubocop-rspec_rails, maybe we shouldn't add support for this to the RSpec/Rails department's Cop for now?

I update this PR.


when support mazda3 for 2014 ?

不支持，要自己加装硬件设备，还得在程序上再开发

I think he said
Does not support, you want to install their own hardware, have to develop the program

comma.ai doesn't have plans to support cars beyond Honda's, but if people show initiative doing the port, we can help support and upstream


[5.0.x] Updated asgiref dependency for 5.0 release series.

We forget to do this before releasing the 5.0.

@carltongibson Thanks :santa:


perf: avoid checking success tasks when save limit is disabled

We disabled save limit which generate a lot of wait time for each save ~20seconds

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 89.573%

Totals

Change from base Build<PHONE_NUMBER>1:
0.003%

Covered Lines:
3376

Relevant Lines:
3769

💛  - Coveralls


cmd/cue: regression in definition of unification of disjunction

What version of CUE are you using (cue version)?

$ cue version
cue version +304b02e linux/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?
exec cue def

-- cue.mod/module.cue --
module: "mod.com"
-- x.cue --
package x

#a: (#c | #d) & {
	name: string
}

#a1: #c & {
	name: string
}

#a2: #d & {
	name: string
}

#c: {
	name: string
	age:  int
}

#d: {
	name:    string
	address: string
}

What did you expect to see?
Success with the def of the current package printed.
What did you see instead?
Error:
#a: field `address` not allowed:
    ./x.cue:3:1
    ./x.cue:3:17
    ./x.cue:20:5

This appears to work with v0.2.2:
$ cue version
cue version 0.2.2 linux/amd64
$ cue def
package x

#a: (#c | #d) & {
        name: string
}
#c: {
        name: string
        age:  int
}
#d: {
        name:    string
        address: string
}
#a1: #c & {
        name: string
}
#a2: #d & {
        name: string
}

This issue has been migrated to https://github.com/cue-lang/cue/issues/471.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


@opentelemetry/instrumentation-aws-sdk does not instrument AWS SDK v3

What version of OpenTelemetry are you using?
See package.json below
What version of Node are you using?
18.x on AWS Lambda
What did you do?

Upgraded from AWS SDK v2 to AWS SDK v3.
What did you expect to see?
I expected to see spans containing DynamoDB specific attributes.
What did you see instead?
Just http details not, DynamoDB details.
Additional context
This is very plausibly something I'm doing wrong, or something unexpected happening in a build step somewhere, but I'm at a loss on how to debug it further. Every Lambda uses the following build config:
    Metadata:
      BuildMethod: 'esbuild'
      BuildProperties:
        EntryPoints:
          - './index'
        External:
          - '@aws-sdk/*'
          - '@opentelemetry/api'
          - '@opentelemetry/exporter-trace-otlp-proto'
          - '@opentelemetry/resources'
          - '@opentelemetry/sdk-trace-base'
          - '@opentelemetry/sdk-trace-node'
        Minify: false
        Sourcemap: true
        Target: 'es2020'

OpenTelemetry Setup Code
Even though the following code uses import/export, it's passed through the SAM CLI's ESBuild plugin and runs as CJS once deployed.
import {assert} from '@code-like-a-carpenter/assert';
import {env} from '@code-like-a-carpenter/env';
import {diag} from '@opentelemetry/api';
import {
  CompositePropagator,
  W3CTraceContextPropagator,
} from '@opentelemetry/core';
import {OTLPTraceExporter} from '@opentelemetry/exporter-trace-otlp-proto';
import {AWSXRayPropagator} from '@opentelemetry/propagator-aws-xray';
import {B3InjectEncoding, B3Propagator} from '@opentelemetry/propagator-b3';
import {Resource} from '@opentelemetry/resources';
import type {SDKRegistrationConfig} from '@opentelemetry/sdk-trace-base';
import {BatchSpanProcessor} from '@opentelemetry/sdk-trace-base';
import type {
  NodeTracerConfig,
  NodeTracerProvider,
} from '@opentelemetry/sdk-trace-node';
import {SemanticResourceAttributes} from '@opentelemetry/semantic-conventions';
import {
  SentryPropagator,
  SentrySpanProcessor,
} from '@sentry/opentelemetry-node';

import {initSentry} from './sentry';

initSentry();

// Copied from
// https://github.com/open-telemetry/opentelemetry-lambda/blob/0a83149fe2f23a7dab64df6108cfa35f18cc2ae5/nodejs/packages/layer/src/wrapper.ts#L42-L50
declare global {
  function configureSdkRegistration(
    defaultSdkRegistration: SDKRegistrationConfig
  ): SDKRegistrationConfig;

  function configureTracerProvider(tracerProvider: NodeTracerProvider): void;

  function configureTracer(defaultConfig: NodeTracerConfig): NodeTracerConfig;
}

// In another file, there's a wrapper around each lambda which uses the globally attached tracerProvider to flush before exit. It would be lovely if OTel could provide a native solution for this.
declare global {
  // var seems to be the only typescript keyword that works here.
  // eslint-disable-next-line no-var
  var tracerProvider: NodeTracerProvider;
}

global.configureSdkRegistration = (config: SDKRegistrationConfig) => {
  return {
    ...config,
    propagator: new CompositePropagator({
      propagators: [
        new AWSXRayPropagator(),
        new W3CTraceContextPropagator(),
        new B3Propagator(),
        new B3Propagator({injectEncoding: B3InjectEncoding.MULTI_HEADER}),
        new SentryPropagator(),
      ],
    }),
  };
};

// we need to override the service name to avoid creating a new set of Honeycomb
// datasets every time a build runs in CI.
const serviceName = process.env.AWS_LAMBDA_FUNCTION_NAME?.split('-')
  ?.slice(-2, -1)
  ?.join('');

diag.info('Telemetry: included');

// This produces the config passed to new NodeTracerProvider()
const originalConfigureTracer = global.configureTracer;
global.configureTracer = ({resource, ...config}) => {
  diag.info('Telemetry: generating tracer config');

  assert(serviceName, 'Service name is required');
  const r = new Resource({
    [SemanticResourceAttributes.DEPLOYMENT_ENVIRONMENT]:
      process.env.STAGE_NAME ?? 'development',
    [SemanticResourceAttributes.FAAS_INSTANCE]:
      process.env.AWS_LAMBDA_LOG_STREAM_NAME ?? '',
    [SemanticResourceAttributes.FAAS_MAX_MEMORY]:
      process.env.AWS_LAMBDA_FUNCTION_MEMORY_SIZE ?? '',
    [SemanticResourceAttributes.SERVICE_NAME]: serviceName,
    [SemanticResourceAttributes.SERVICE_VERSION]: env('SHA'),
    'git.commit.sha': env('SHA'),
    'git.repository_url': env('REPOSITORY_URL'),
  });
  resource = resource ? resource.merge(r) : r;

  return originalConfigureTracer({
    ...config,
    resource,
  });
};

const originalConfigureTracerProvider = global.configureTracerProvider;
global.configureTracerProvider = (tracerProvider) => {
  diag.info('Telemetry: configureTracerProvider');

  // need to set tracerProvider so that we can flush at the end of each
  // invocation.
  diag.info('Telemetry: assigning global.tracerProvider');
  global.tracerProvider = tracerProvider;
  diag.info('Telemetry: assigned global.tracerProvider');

  // but since configureTracerProvider is defined, we need to repeat the default
  // behavior.
  diag.info('Telemetry: adding BatchSpanProcessor');
  tracerProvider.addSpanProcessor(
    new BatchSpanProcessor(new OTLPTraceExporter())
  );
  diag.info('Telemetry: added BatchSpanProcessor');

  diag.info('Telemetry: adding SentrySpanProcessor');
  tracerProvider.addSpanProcessor(new SentrySpanProcessor());
  diag.info('Telemetry: adding SentrySpanProcessor');

  if (originalConfigureTracerProvider) {
    diag.info('Telemetry: Running original configureTracerProvider');
    originalConfigureTracerProvider(tracerProvider);
    diag.info('Telemetry: Ran original configureTracerProvider');
  }
};

Dependencies and Versions
{
  "name": "@check-run-reporter/telemetry",
  "main": "src/index.ts",
  "dependencies": {
    "@code-like-a-carpenter/assert": "^1.0.0",
    "@code-like-a-carpenter/env": "^1.0.1",
    "@code-like-a-carpenter/telemetry": "^1.0.1",
    "@ianwremmel/data": "^3.1.0",
    "@octokit/request-error": "^2.1.0",
    "@opentelemetry/api": "~1.3.0",
    "@opentelemetry/core": "^1.9.1",
    "@opentelemetry/exporter-trace-otlp-proto": "0.34.0",
    "@opentelemetry/propagator-aws-xray": "^1.2.0",
    "@opentelemetry/propagator-b3": "^1.9.1",
    "@opentelemetry/resources": "1.8.0",
    "@opentelemetry/sdk-trace-base": "1.8.0",
    "@opentelemetry/sdk-trace-node": "1.8.0",
    "@opentelemetry/semantic-conventions": "1.8.0",
    "@sentry/opentelemetry-node": "^7.38.0",
    "@sentry/serverless": "^7.38.0"
  }
}

@code-like-a-carpenter/telemetry pulls in "@opentelemetry/api": "1.4.0" but is otherwise just convenience functions and shouldn't have anything to do with instrumentation.
Using ADOT version: 'arn:aws:lambda:${AWS::Region}:901920570463:layer:aws-otel-nodejs-amd64-ver-1-8-0:1'
Relevant Log Output
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.194000 Registering OpenTelemetry
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.204000 @opentelemetry/api: Registered a global for diag v1.3.0.
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 AwsLambdaDetector found resource. Resource {
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 attributes: {
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'cloud.provider': 'aws',
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'cloud.platform': 'aws_lambda',
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'cloud.region': 'us-east-1',
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'faas.name': 'check-run-reporter-FnRemixed-77xsc4EV6YYH',
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'faas.version': '16'
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 }
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 }
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 EnvDetector found resource. Resource {
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 attributes: { 'service.name': 'check-run-reporter-FnRemixed-77xsc4EV6YYH' }
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 }
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 ProcessDetector found resource. Resource {
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 attributes: {
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'process.pid': 17,
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'process.executable.name': '/var/lang/bin/node',
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'process.command': '/var/runtime/index.mjs',
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'process.command_line': '/var/lang/bin/node /var/runtime/index.mjs',
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'process.runtime.version': '18.12.1',
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'process.runtime.name': 'nodejs',
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 'process.runtime.description': 'Node.js'
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 }
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.209000 }
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.213000 Telemetry: generating tracer config
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.215000 Exporter "otlp" requested through environment variable is unavailable.
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.215000 Telemetry: configureTracerProvider
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.215000 Telemetry: assigning global.tracerProvider
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.216000 Telemetry: assigned global.tracerProvider
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.216000 Telemetry: adding BatchSpanProcessor
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.217000 Telemetry: added BatchSpanProcessor
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.217000 Telemetry: adding SentrySpanProcessor
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.217000 Telemetry: adding SentrySpanProcessor
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.219000 @opentelemetry/api: Registered a global for trace v1.3.0.
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.219000 @opentelemetry/api: Registered a global for context v1.3.0.
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.219000 @opentelemetry/api: Registered a global for propagation v1.3.0.
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.446000 (node:17) NOTE: The AWS SDK for JavaScript (v2) will be put into maintenance mode in 2023.
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.446000 Please migrate your code to use AWS SDK for JavaScript (v3).
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.446000 For more information, check the migration guide at https://a.co/7PzMCcy
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.446000 at emitWarning (/var/node_modules/aws-sdk/lib/maintenance_mode_message.js:21:13)
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.446000 at Timeout._onTimeout (/var/node_modules/aws-sdk/lib/maintenance_mode_message.js:29:5)
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.446000 at listOnTimeout (node:internal/timers:564:17)
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.446000 at processTimers (node:internal/timers:507:7)
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.482000 Applying patch for net module
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.494000 2023-02-26T17:43:01.494Z	undefined	DEBUG	@opentelemetry/instrumentation-http Applying patch for<EMAIL_ADDRESS>2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.734000 2023-02-26T17:43:01.734Z	undefined	DEBUG	@opentelemetry/instrumentation-http Applying patch for<EMAIL_ADDRESS>2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:01.842000 2023-02-26T17:43:01.842Z	undefined	DEBUG	aws-sdk instrumentation: applying patch to aws-sdk v3 client send
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.114000 2023-02-26T17:43:02.114Z	undefined	WARN	Failed extracting version /var/task
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.115000 2023-02-26T17:43:02.114Z	undefined	DEBUG	Applying patch for lambda handler
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.115000 2023-02-26T17:43:02.115Z	undefined	DEBUG	patch handler function
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.125000 EXTENSION	Name: collector	State: Ready	Events: [INVOKE,SHUTDOWN]
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.127000 START RequestId: 1dc72f59-d1b7-4077-aa6f-f5173ff86d5f Version: 16
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.180000 2023-02-26T17:43:02.180Z	1dc72f59-d1b7-4077-aa6f-f5173ff86d5f	DEBUG	@opentelemetry/instrumentation-http https instrumentation outgoingRequest
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.181000 2023-02-26T17:43:02.181Z	1dc72f59-d1b7-4077-aa6f-f5173ff86d5f	DEBUG	@opentelemetry/instrumentation-http http.ClientRequest return request
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.184000 2023-02-26T17:43:02.184Z	1dc72f59-d1b7-4077-aa6f-f5173ff86d5f	DEBUG	@opentelemetry/instrumentation-http https instrumentation outgoingRequest
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.185000 2023-02-26T17:43:02.185Z	1dc72f59-d1b7-4077-aa6f-f5173ff86d5f	DEBUG	@opentelemetry/instrumentation-http http.ClientRequest return request
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.187000 2023-02-26T17:43:02.187Z	1dc72f59-d1b7-4077-aa6f-f5173ff86d5f	DEBUG	@opentelemetry/instrumentation-http https instrumentation outgoingRequest
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.187000 2023-02-26T17:43:02.187Z	1dc72f59-d1b7-4077-aa6f-f5173ff86d5f	DEBUG	@opentelemetry/instrumentation-http http.ClientRequest return request
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.189000 2023-02-26T17:43:02.189Z	1dc72f59-d1b7-4077-aa6f-f5173ff86d5f	DEBUG	@opentelemetry/instrumentation-http https instrumentation outgoingRequest
2023/02/26/[16]6f9b07ad21a04050a200688aa5fa70c0 2023-02-26T17:43:02.189000 2023-02-26T17:43:02.189Z	1dc72f59-d1b7-4077-aa6f-f5173ff86d5f	DEBUG	@opentelemetry/instrumentation-http http.ClientRequest return request

The warning about SDK v2 is caused by @sentry/serverless pulling it in whether it's in use or not. When I removed Sentry, that warning went away, but the AWS instrumentation didn't work any better.

I'm not sure what changed since this morning, but I now see properly instrumented DynamoDB spans but SQS spans still show up as plain HTTPS spans

@ianwremmel The instrumentation is implemented and tested to support v3 for all services including SQS.
Can you please try to remove other instrumentation libraries and see if it makes any difference? I suspect that the sentry packages might be colliding with otel.

Thanks for the update
Closing this issue since your setup is working now. Feel free to reopen if you have other issues in the future.


Exiting current pcall

Is it possible to exit a pcall from a C defined function. Eg, let's have the following Javascript:
function MyTest() {
      aJavascriptfFunction();

    cDefinedFunction();  // Inside this C defined function, I want to exit from MyTest if something goes wrong

      aNotherJavascriptfFunction(); // not want to execute this if the previous function has failed
}

On the C side, I called
int rc = duk_pcall(ctx, 0); // exit from that call if any sub functions has been problematic

Is there a duk_xxx function to do that? I tried several mechanisms including exceptions, without success.

You can throw an error (see duk_throw()) but that’s about it.  The C call is just an extension of the normal flow of JS execution, so you’re basically asking “how do I return from multiple levels of function calls at once?” which is non-trivial.

Yes, I wanted this behavior; I will ask it for Christmass.
Meanwhile, I managed to get what I wanted:

Without enable C++ exceptions, it generates a whole application crash that I am not able to catch.
return DUK_RET_ERROR; from my C Code, thank you wonderful documentation :)

In that way the pcall() returns without success, exactly what I want. I love Duktape.

“Returning from multiple functions at once” is pretty much what exceptions are for.  By returning DUK_RET_ERROR this is essentially shorthand for throwing an equivalent exception using duk_throw() or duk_error(), so I don’t understand why the latter didn’t work for you.

Indeed I now understand that it is the same, duk_throw() didn't work because I enabled DUK_USE_CPP_EXCEPTIONS.
Unfortunately I was excepted to have something like this in the user code:
try {
     pcal();
} catch( std::runtime_error &e) {
}

By reading the doc, it seems that the exception option is only to transform into JS an exception in a Duktape/C function, which is not exactly what I want.

When you enable DUK_USE_CPP_EXCEPTIONS it doesn't change the way errors are handled in the Duktape API: you still use duk_pcall() (and its variants) and check the error code. C++ exceptions are used strictly internally to perform the long control transfer (from the throw site to the catch site) in a way that unwinds the C stack that supports automatic destructors etc. That internal exception, duk_internal_exception is not normally visible or caught by application code, and for that reason it also doesn't inherit from any standard exception class (to discourage trying to catch it).

So as a concrete example, regardless of whether DUK_USE_CPP_EXCEPTIONS is enabled, one would:
if (duk_pcall(...) == DUK_EXEC_SUCCESS) {
    printf("success!\n);
} else {
    printf("failure: %s\n", duk_safe_to_string(ctx, -1));
}
duk_pop(ctx);

and in the throw site, one could e.g. use:
duk_type_error(ctx, "aiee");

The only concrete application-visible effect of DUK_USE_CPP_EXCEPTIONS is that when the C stack is unwound between the throw site and the catch site (duk_pcall), the stack unwinding is C++ aware and supports automatic destructors etc.

Ok that's clear, I had mis-understanding the documentation, but with this option turned on I always had exception raised and application crash (MinGW on Windows).

Hmm, so with DUK_USE_CPP_EXCEPTIONS a duk_pcall() + duk_error() leads to a crash in your setup? What kind of crash, is there any useful information about the cause?

@arabine Any updates?

No, I have to find time to give you a simple example of this use case, can you hold on this ticket a bit?

Sure, no hurry, I was just trying to clean up some unnecessarily hanging issues.

Good to hear that the cause was found :) Can you describe what fix you concretely applied; a gcc option?


Improvement: Pylance/Pyright VS Code extension and their relation

The VS Code Python extension is a dependency on the Pylance extension. The Pylance extension is used for Python language support. Pylance in turn is powered by Pyright.
The question then is:
If someone has the Python and Pylance extension, why (and what extra) features does the Pyright extension add? Since Pylance is already powered by Pyright.
This could be more clear in the README so users know why they should opt to also install the VS Code Pyright extension alongside the two others.

@erictraut @debonte  it does! But it would be very good if this was also added here:

https://marketplace.visualstudio.com/items?itemName=ms-pyright.pyright (This is what you get on search engines search for vs code pyright and also in VS Code extension panel when searching for pyright. Since this recommendation is not shown there, it is very easy for users to happen to install both.
The README.md at https://github.com/microsoft/pyright/tree/main/packages/vscode-pyright should preferably also add this (maybe the source of truth is the same for this and the above bullet point).

(This issue better belongs in https://github.com/microsoft/pyright/ so should probably be moved back)


Automatically changes the format 12h to 24h

Using:
<EMAIL_ADDRESS><EMAIL_ADDRESS>There seems to be a bug with AM. I select AM times, it converts to PM times. Ex. I select 2:15AM and click OK, the params returns the object like that:
Object {
"hours": 14,
"minutes": 15,
}

Will look into this and release a fix!

Looks like this works now for me with english locale and expo 46 on iOS. I think someone else fixed it because I did not do anything.
Please test with new release!

Will be released later this evening!


Invalid escape sequences in regular expressions

Something I noticed in some of my unit tests:
[...]\markdown\extensions\toc.py:28: DeprecationWarning: invalid escape sequence \w
  value = re.sub('[^\w\s-]', '', value.decode('ascii')).strip().lower()
[...]\markdown\extensions\toc.py:29: DeprecationWarning: invalid escape sequence \s
  return re.sub('[%s\s]+' % separator, separator, value)

There might be more occurrences of this problem than those I've found, but making the regular expressions on lines 28 and 29 into raw strings (i.e. '[^\w\s-]' into r'[^\w\s-]') silenced these warnings. I'm not sure whether this is the correct fix.
(Python 3.6.3)

Yes, these should all get fixed.  PY 3.6 is much more strict with its tokenizer (I ran into this on another project), and PY 3.7 will actually throw exceptions on these making it more critical to address.  The motivation behind this is they want to start discouraging people from using unsupported ASCII escapes in case they want to support other back references in replaces in the future, like \N etc., but those are long term goals.  This is specifically referring to Re, but Python in generally may also be more strict with normal strings in general.
Anyways, we should probably scan the code for all cases like this were regex strings were lazily using non-raw strings.

Yup, I agree as well. One thing we need to be aware of is that many regex are build up by concatenating multiple strings together. That's not a problem in itself, it just adds another level of complexity to the process. For example, what happens when you concatenate a raw string and a regular string? Does it matter if one or the other comes first (the way Python operators work it's a possibility depending on the implementation)? I expect all we really care about is that the final string (which gets passed to re) is raw, regardless of what the individual pieces started out as. However, it would probably be good form to have each piece start out raw.
Of course PRs are welcome.

Good news is that it doesn't really matter. Raw or not raw, it all concatenates the same. The r in front only matters at compile time, then it's just a string. I concatenate raw strings for regex all the time. By time the operator are working on the objects, they're just strings.

I will tentatively assign this task to me assuming someone doesn't get a pull together before I do.


Asynchronous calls to jobs

Added

Introduced asynchronous calls to jobs. This feature lets you avoid timeouts on very long requests
by switching to a two-step process: request a task and then check on the result.
See Asynchronous calls to jobs guide for more details.

Looks good to me. The only worry is using a global lock for the task store - this might become a problem at some point, but until we actually see it being a problem, I don't want to implement and test something more complicated for accessing the task store.

Yeah, it could become a problem when having a lot of concurrent requests. It is a "Readers–Writer lock", allowing multiple readers at no cost, but when someone writes to it, it can cause longer delays. Fortunately, writing (creating a new task) doesn't happen so often, so I think there's nothing to worry about right now.


Enable dev.external on plinux

related: runtimes/backlog/issues/1099 and https://github.com/ibmruntimes/ci-jenkins-pipelines/pull/175

@AdamBrousseau could you review? Thanks


Improve find functionalities

Fixes https://github.com/AY2122S2-CS2103T-W14-3/tp/issues/57, https://github.com/AY2122S2-CS2103T-W14-3/tp/issues/59, and https://github.com/AY2122S2-CS2103T-W14-3/tp/issues/84
Background
Changing Find Commands
Currently, the find command functionalities are very limited. In particular,

FindEventCommand can only find events based on their companyName
FindCompanyCommand can only find companies based on the companyName
FindPersonCommand can only find people based on the name

However, as Events, Persons, and Companies have a lot of attributes, it will be beneficial for users to be able to filter these events from the attributes. Therefore, this Pull Request serves as an improvement to the current Find Commands.
Refactoring predicates in seedu.address.model.entry
Currently, the predicates are scattered inside the entry directory. E.g. CompanyNameContainsKeywordsPredicate and NameContainsKeywordsPredicate. However, notice that these 2 classes seemed out of place as the other classes in the same directory hold entries and their attributes. Therefore, refactoring these predicates will help the organisation of the codebase.
Let's

Improve FindEventCommand to include searching by all Event's attribute
Improve FindCompanyCommand to include searching by name, companyName, and tags
Improve FindPersonCommmand to include searching by name and tags
Refactor predicates to their own directory
Create predicates for each Event's attributes for improve reusability

Codecov Report

Merging #86 (ca9801d) into master (0de0fba) will decrease coverage by 3.48%.
The diff coverage is 13.00%.

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     50.93%   47.45%   -3.49%
- Complexity      437      451      +14
============================================
  Files            97      104       +7
  Lines          2026     2221     +195
  Branches        257      318      +61
============================================
+ Hits           1032     1054      +22
- Misses          927     1089     +162
- Partials         67       78      +11

Impacted Files
Coverage Δ

...edu/address/logic/commands/FindCompanyCommand.java
0.00% <0.00%> (ø)

...seedu/address/logic/commands/FindEventCommand.java
0.00% <0.00%> (ø)

...du/address/logic/parser/AddEventCommandParser.java
0.00% <ø> (ø)

...a/seedu/address/logic/parser/ArgumentMultimap.java
85.71% <0.00%> (-14.29%)
:arrow_down:

...address/logic/parser/FindCompanyCommandParser.java
0.00% <0.00%> (ø)

...u/address/logic/parser/FindEventCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/entry/Date.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/entry/Event.java
0.00% <ø> (ø)

.../main/java/seedu/address/model/entry/Location.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/entry/Time.java
0.00% <0.00%> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de0fba...ca9801d. Read the comment docs.


clarify node names of ACL nodes

here should IMHO be no changes made without jira reference.

There are quite some commits without JIRA references in https://github.com/apache/jackrabbit-oak/commits/trunk/oak-doc.
Also there should be almost no obstacles to apply clarifications and fix typos, I would strongly propose to be less formal with those, as IMHO Jackrabbit has a problem with getting contributions at all, rather than getting low quality contributions.

hi @kwin  if it was just about fixing a typo, i might agree but it's not just that but changing phrasing that in the current context actually introduces a mistunderstanding because the start of the segment sounds as if that was true for all policies which is not correct.... and therefore i think asking for a dedicated ticket is not too much.


Can't catch invalid_grant error after refresh token revoke

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.14.1
Wrapper Library
Not Applicable
Wrapper Library Version
none
Description
We have an Azure AD B2C with custom policies configured.
By our security policy we are going to revoke all refresh tokens once user changed his password.
The expected behavior is like that;

Revoke all refresh tokens for a particular user
Access token is expired for that user
User initiates any request which under the hood is calling acquireTokenSilent
Token endpoint returns invalid_grant error
We catch that error and sign the user out immediately.

Even though Msal.js v2 receives this error under the hood, it doesn't allow developers to detect it and does a silent renew of the access/refresh token pair.
FYI: I've explored the source code a little bit and found that there's no way to abandon silent request execution in the iframe in case of invalid_grant error. Does it mean that the new feature/flag is required? What do you think?
Here is a reference to the code for your information:
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/0e8a18c059bbacbd7f68057d1e760d9e52bdfa02/lib/msal-browser/src/app/ClientApplication.ts#L325
Error Message
Only network error with invalid_grant token endpoint error, which is correct.
Msal Logs

MSAL Configuration
Any relevant B2C config from this repository can be used.

Relevant Code Snippets
Any B2C example from this repository can be used

Reproduction Steps

Sign in under any Azure AD B2C user.
Wait for access token expiration (I used minimal access token's expiration time = 5min).
In Azure Portal click 'Revoke sessions' button for the user.
In the web app put a breakpoint on catch clause of for PublicClientApplication.acquireTokenSilent
Initiate a request in the web application which will cause a new token acquisition.

Problems:

Error is not caught (execution flow won't stop on the breakpoint).
New refresh token/access token received successfully.

Expected Behavior

I wanna be able to catch the invalid_grant (revoked/expired refresh token) exception and sign the user out immediately.

Generally, we are going to revoke all refresh tokens once user's changed his password. That's a part of our security policy.
Identity Provider
Azure B2C Custom Policy
Browsers Affected (Select all that apply)
Chrome, Safari
Regression
No response
Source
External (Customer)

Hi @Codeluck,
The current behaviour is by design, at this moment the library does not support your scenario, we are however taking this suggestion under consideration for our next iterations.

Hello @samuelkubai and thank you for your feedback!
Could you add an additional configuration object like Configuration.throwOn with the signature like:
interface ThrowExceptionConfig {
      interactionRequired?: boolean;
      serverError?: boolean;
      invalidGrant?: boolean;
}

If the error for an appropriate flag is caught then just throw it without processing silent refresh token request in the iframe.
What do you think?
Btw, I've noticed at least one similar issue here closed because of inactivity. So this feature looks relevant.

I'm facing the same issue. In my case the function acquireTokenSilent returns undefined when the refresh token is expired.
Below follows the log (for readability and privacy purposes, I removed some parts of text).
Description

Log in through acquireTokenPopup
Let the refresh token expires (usually after 24 hours)
Call acquireTokenSilent, the promise is fulfilled but the authentication result is undefined

Expected behavior
The promise returned by acquireTokenSilent is rejected.
Actual behavior
It fulfills the promise returned by acquireTokenSilent with undefined.
The request logs instead shows the invalid_grant error with description AADSTS700084: The refresh token was issued to a single page app (SPA), and therefore has a fixed, limited lifetime of 1.00:00:00, which cannot be extended. It is now expired and a new sign in request must be sent by the SPA to the sign in page..
Logs
General
Request URL: https://login.microsoftonline.com/<TENANT-ID>/oauth2/v2.0/token
Request Method: POST
Status Code: 400 Bad Request
Remote Address: <REMOTE-ADDRESS>:443
Referrer Policy: strict-origin-when-cross-origin

Request Headers
Accept: */*
Accept-Encoding: gzip, deflate, br
Accept-Language: it-IT,it;q=0.9,en;q=0.8,de;q=0.7,la;q=0.6,fr;q=0.5,es;q=0.4
Connection: keep-alive
Content-Length: 1808
content-type: application/x-www-form-urlencoded;charset=utf-8
Host: login.microsoftonline.com
Origin: <ORIGIN>
Referer: <REFER>
sec-ch-ua: " Not;A Brand";v="99", "Google Chrome";v="97", "Chromium";v="97"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "macOS"
Sec-Fetch-Dest: empty
Sec-Fetch-Mode: cors
Sec-Fetch-Site: cross-site
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.99 Safari/537.36

Response Header
Access-Control-Allow-Methods: POST, OPTIONS
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: Content-Length,Content-Encoding
Cache-Control: no-store, no-cache
Content-Length: 740
Content-Type: application/json; charset=utf-8
Date: Mon, 07 Feb 2022 08:58:48 GMT
Expires: -1
nel: {"report_to":"network-errors","max_age":86400,"success_fraction":0.001,"failure_fraction":1.0}
P3P: CP="<CP>"
Pragma: no-cache
Referrer-Policy: strict-origin-when-cross-origin
report-to: {"group":"network-errors","max_age":86400,"endpoints":[{"url":"https://identity.nel.measure.office.net/api/report?catId=GW+estsfd+ams1"}]}
Set-Cookie: fpc=<FPC>; expires=Wed, 09-Mar-2022 08:58:48 GMT; path=/; secure; HttpOnly; SameSite=None
Set-Cookie: x-ms-gateway-slice=estsfd; path=/; secure; samesite=none; httponly
Set-Cookie: stsservicecookie=estsfd; path=/; secure; samesite=none; httponly
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Content-Type-Options: nosniff
x-ms-clitelem: <TELEM>,
x-ms-ests-server: 2.1.12381.24 - NEULR1 ProdSlices
x-ms-request-id: <REQ-ID>

Request Payload
client_id: <CLIENT-ID>
scope: <SCOPE>
grant_type: refresh_token
client_info: 1
x-client-SKU: msal.js.browser
x-client-VER: 2.21.0
x-client-OS:
x-client-CPU:
x-ms-lib-capability: retry-after, h429
x-client-current-telemetry: 5|61,0,,,|,
x-client-last-telemetry: <LAST-TELEMETRY>
client-request-id: <CLIENT-REQUEST-ID>
refresh_token: <REFRESH-TOKEN>
X-AnchorMailbox: <ANCHOR-MAILBOX>

Response
{
  correlation_id: <CORRELATION-ID>
  error: "invalid_grant"
  error_codes: [700084]
  error_description: "AADSTS700084: The refresh token was issued to a single page app (SPA), and therefore has a fixed, limited lifetime of 1.00:00:00, which cannot be extended. It is now expired and a new sign in request must be sent by the SPA to the sign in page. The token was issued on 2022-02-04T14:02:43.2682473Z.\r\nTrace ID: <TRACE-ID>\r\nCorrelation ID: <CORRELATION-ID>\r\nTimestamp: 2022-02-07 08:58:48Z"
  error_uri: "https://login.microsoftonline.com/error?code=700084"
  suberror: "bad_token"
  timestamp: "2022-02-07 08:58:48Z"
  trace_id: <TRACE-ID>
}

We are facing the same issue as well, I’m unable to catch the exception in acquireTokenSilent subscription block with instance of InteractionRequiredAuthError

I am facing the same issue, too. Still looking for solution.

any updates?

Apologies for the delay. @EmLauber can we track this internally?

We're also experiencing this issue, is there a workaround we could use until the solution is implemented?

We are facing the same issue as here, is there any updates?

Same error occurred in my app (and also a loop of redirects) due to 2 things:

Missing *ngIf="!isIframe" in the app.component.html's router-outlet. Make sure it is
<router-outlet *ngIf="!isIframe"></router-outlet>
Setting the active user (using this.msalService.instance.setActiveAccount(allAccounts[0]);) from the constructor of an Angular Service or the Bootstrap Component (AppComponent in most cases) without waiting for the auth flow to complete.

this.msalBroadcastService.inProgress$.pipe(filter((status: InteractionStatus) => status === InteractionStatus.None))
.subscribe(() => {
      this.setActiveUserIfNotSet();
    });

I'm facing the same issue. In my case the function acquireTokenSilent returns undefined when the refresh token is expired. Below follows the log (for readability and privacy purposes, I removed some parts of text).
Description

Log in through acquireTokenPopup
Let the refresh token expires (usually after 24 hours)
Call acquireTokenSilent, the promise is fulfilled but the authentication result is undefined

Expected behavior
The promise returned by acquireTokenSilent is rejected.
Actual behavior
It fulfills the promise returned by acquireTokenSilent with undefined.
The request logs instead shows the invalid_grant error with description AADSTS700084: The refresh token was issued to a single page app (SPA), and therefore has a fixed, limited lifetime of 1.00:00:00, which cannot be extended. It is now expired and a new sign in request must be sent by the SPA to the sign in page..
Logs
General
Request URL: https://login.microsoftonline.com/<TENANT-ID>/oauth2/v2.0/token
Request Method: POST
Status Code: 400 Bad Request
Remote Address: <REMOTE-ADDRESS>:443
Referrer Policy: strict-origin-when-cross-origin

Request Headers
Accept: */*
Accept-Encoding: gzip, deflate, br
Accept-Language: it-IT,it;q=0.9,en;q=0.8,de;q=0.7,la;q=0.6,fr;q=0.5,es;q=0.4
Connection: keep-alive
Content-Length: 1808
content-type: application/x-www-form-urlencoded;charset=utf-8
Host: login.microsoftonline.com
Origin: <ORIGIN>
Referer: <REFER>
sec-ch-ua: " Not;A Brand";v="99", "Google Chrome";v="97", "Chromium";v="97"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "macOS"
Sec-Fetch-Dest: empty
Sec-Fetch-Mode: cors
Sec-Fetch-Site: cross-site
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.99 Safari/537.36

Response Header
Access-Control-Allow-Methods: POST, OPTIONS
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: Content-Length,Content-Encoding
Cache-Control: no-store, no-cache
Content-Length: 740
Content-Type: application/json; charset=utf-8
Date: Mon, 07 Feb 2022 08:58:48 GMT
Expires: -1
nel: {"report_to":"network-errors","max_age":86400,"success_fraction":0.001,"failure_fraction":1.0}
P3P: CP="<CP>"
Pragma: no-cache
Referrer-Policy: strict-origin-when-cross-origin
report-to: {"group":"network-errors","max_age":86400,"endpoints":[{"url":"https://identity.nel.measure.office.net/api/report?catId=GW+estsfd+ams1"}]}
Set-Cookie: fpc=<FPC>; expires=Wed, 09-Mar-2022 08:58:48 GMT; path=/; secure; HttpOnly; SameSite=None
Set-Cookie: x-ms-gateway-slice=estsfd; path=/; secure; samesite=none; httponly
Set-Cookie: stsservicecookie=estsfd; path=/; secure; samesite=none; httponly
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Content-Type-Options: nosniff
x-ms-clitelem: <TELEM>,
x-ms-ests-server: 2.1.12381.24 - NEULR1 ProdSlices
x-ms-request-id: <REQ-ID>

Request Payload
client_id: <CLIENT-ID>
scope: <SCOPE>
grant_type: refresh_token
client_info: 1
x-client-SKU: msal.js.browser
x-client-VER: 2.21.0
x-client-OS:
x-client-CPU:
x-ms-lib-capability: retry-after, h429
x-client-current-telemetry: 5|61,0,,,|,
x-client-last-telemetry: <LAST-TELEMETRY>
client-request-id: <CLIENT-REQUEST-ID>
refresh_token: <REFRESH-TOKEN>
X-AnchorMailbox: <ANCHOR-MAILBOX>

Response
{
  correlation_id: <CORRELATION-ID>
  error: "invalid_grant"
  error_codes: [700084]
  error_description: "AADSTS700084: The refresh token was issued to a single page app (SPA), and therefore has a fixed, limited lifetime of 1.00:00:00, which cannot be extended. It is now expired and a new sign in request must be sent by the SPA to the sign in page. The token was issued on 2022-02-04T14:02:43.2682473Z.\r\nTrace ID: <TRACE-ID>\r\nCorrelation ID: <CORRELATION-ID>\r\nTimestamp: 2022-02-07 08:58:48Z"
  error_uri: "https://login.microsoftonline.com/error?code=700084"
  suberror: "bad_token"
  timestamp: "2022-02-07 08:58:48Z"
  trace_id: <TRACE-ID>
}

so what did you guys do to handle this scenario?
just force user goto login page if acquireTokenSilent result is undefined?

const res = await msalInstance
      .acquireTokenSilent({
        ...loginRequest,
        account,
      })
      .catch((error) => {
        console.log(error)
        if (error instanceof InteractionRequiredAuthError) {
          // fallback to interaction when silent call fails
          return msalInstance
            .acquireTokenPopup({ ...loginRequest })
            .catch(function (err) {
              /* eslint-disable no-console */
              console.log(err)
            })
        }
      })

can this InteractionRequiredAuthError handle the 700084 error right now?

The below code worked for to get the expiry token.
 this.msalBroadcastService.msalSubject$             .pipe(                 filter((msg: EventMessage) => msg.eventType === EventType.ACQUIRE_TOKEN_NETWORK_START                      || msg.eventType === EventType.ACQUIRE_TOKEN_FAILURE                     || msg.error?.message.indexOf('AADSTS700084') === 0),             )             .subscribe((result: EventMessage) => {                 console.log('Login failed, checking for refresh token.', result); }

 const res = await msalInstance
      .acquireTokenSilent({
        ...loginRequest,
        account,
      })
      .catch((error) => {
        /* eslint-disable no-console */
        console.log(error)
        if (error instanceof InteractionRequiredAuthError) {
          // fallback to interaction when silent call fails
          return msalInstance
            .acquireTokenPopup({ ...loginRequest })
            .catch(function (err) {
              /* eslint-disable no-console */
              console.log(err)
            })
        }
      })
    if (res === undefined) {
      msalInstance.logoutPopup({
        mainWindowRedirectUri: '/login',
      })
      throw new Error('acquireTokenSilent return undefined!')
    }

can this InteractionRequiredAuthError handle the 700084 error right now?
could I use res === undefined statement to check this scenario?

you can try this:
this.msalBroadcastService.msalSubject$ .pipe(
  filter((msg: EventMessage) => msg.eventType === EventType.ACQUIRE_TOKEN_FAILURE && msg.error?.message.indexOf('AADSTS700084') === 0), ) .subscribe((result: EventMessage) =>
{
  console.log('Login failed, checking for refresh token.', result);
});

I still have the same problem.
My current version of packages is:
"@azure/msal-browser": "^2.28.2",
"@azure/msal-common": "^13.3.0",
"@azure/msal-react": "^1.5.11",

This erorr is not throwed by InteractionRequiredAuthError, so thats why i cant handle it properly.
I try solution of @supriyabhattacherjee but it doesnt work as well.
Any ideas how to resolve this error or reproduce on develop enviroment?


how to run these tests

Can u pls add details to run these files? I am new to gatling. trying to run PublishExample.scala

gatling:testOnly *PublishExample. Read documentation please gatling sbt


footer redesign

Resolves: #8641

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e348b957e3aaf5e400befdc64a8fc44db8f5804d/
Edited pages:

index.md
v19.2/connect-to-the-database.md
v19.2/delete-data.md
v19.2/insert-data.md
v19.2/query-data.md
v19.2/run-multi-statement-transactions.md
v19.2/update-data.md
v20.1/connect-to-the-database.md
v20.1/delete-data.md
v20.1/index.md
v20.1/insert-data.md
v20.1/query-data.md
v20.1/run-multi-statement-transactions.md
v20.1/update-data.md
v20.2/connect-to-the-database.md
v20.2/delete-data.md
v20.2/index.md
v20.2/insert-data.md
v20.2/query-data.md
v20.2/run-multi-statement-transactions.md
v20.2/update-data.md

Looking good! Should I test the links aswell?
UI Feedback:

the footer should go all the way to the edge, right now there are gaps on both sides
titles should not be all caps
would like @jseldess and @lnhsingh to look at the links and assess whether everything that is on there makes sense

@luciaaaaaaa gaps will be removed by sidenav pr

I think the footer links should be the same as what's currently on the website but then that also needs to be updated to what Marketing recently requested

Yes, I agree with @lnhsingh. No reason to diverge on the footer.
@yingzhuchin, can you make that quick fix to the footer that @jess-edwards requested?

Yes, I agree with @lnhsingh. No reason to diverge on the footer.
@yingzhuchin, can you make that quick fix to the footer that @jess-edwards requested?

This is done.
@elkmaster, can you please pull commit 1740d890559767f8984e5ce69ad6622ed2182c7d into your PR here? Thank you!

Updated menu items to match 1740d89

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7fedb42aac2ad0082003433f3ad2babe7101b116/
Edited pages:

index.md
v1.0/create-table.md
v1.0/sql-grammar.md
v1.1/create-table.md
v1.1/sql-grammar.md
v19.1/configure-zone.md
v19.1/create-table.md
v19.1/joins.md
v19.1/show-zone-configurations.md
v19.1/sql-grammar.md
v19.1/table-expressions.md
v19.2/configure-zone.md
v19.2/connect-to-the-database.md
v19.2/create-table-as.md
v19.2/create-table.md
v19.2/delete-data.md
v19.2/insert-data.md
v19.2/joins.md
v19.2/partition-by.md
v19.2/query-data.md
v19.2/run-multi-statement-transactions.md
v19.2/selection-queries.md
v19.2/show-zone-configurations.md
v19.2/sql-grammar.md
v19.2/table-expressions.md
v19.2/update-data.md
v19.2/update.md
v2.0/create-table.md
v2.0/joins.md
v2.0/sql-grammar.md
v2.0/table-expressions.md
v2.1/configure-zone.md
v2.1/create-table.md
v2.1/joins.md
v2.1/show-zone-configurations.md
v2.1/sql-grammar.md
v2.1/table-expressions.md
v20.1/common-table-expressions.md
v20.1/configure-zone.md
v20.1/connect-to-the-database.md
v20.1/create-table-as.md
v20.1/create-table.md
v20.1/delete-data.md
v20.1/index.md
v20.1/insert-data.md
v20.1/joins.md
v20.1/partition-by.md
v20.1/query-data.md
v20.1/run-multi-statement-transactions.md
v20.1/selection-queries.md
v20.1/show-zone-configurations.md
v20.1/sql-grammar.md
v20.1/table-expressions.md
v20.1/update-data.md
v20.1/update.md
v20.2/common-table-expressions.md
v20.2/configure-zone.md
v20.2/connect-to-the-database.md
v20.2/create-table-as.md
v20.2/create-table.md
v20.2/delete-data.md
v20.2/index.md
v20.2/insert-data.md
v20.2/joins.md
v20.2/partition-by.md
v20.2/query-data.md
v20.2/run-multi-statement-transactions.md
v20.2/selection-queries.md
v20.2/show-zone-configurations.md
v20.2/sql-grammar.md
v20.2/table-expressions.md
v20.2/update-data.md
v20.2/update.md

Updated menu items to match 1740d89

Thanks, @elkmaster! I am seeing in Figma that the footer text should be underlined in blue when user hovers: https://www.figma.com/file/6XcxaUdad2RkjpEqnVHKAG/Education-docs-redesign?node-id=3020%3A4
Could you make that change?

@yingzhuchin, can't find hover state for that element in figma except:

But this is not intended to display hover state. This is internal figma app highlights of clickable elements.

But this is not intended to display hover state. This is internal figma app highlights of clickable elements.


GTN paper: almost ready! Need your review now :)

We are working for more than 2 years now on paper to present the GTN to instructors.
We think it is almost ready to be send. But we would like the feedback from the community first.
If you want to participate, please before the 10th of January:

open the document at: https://www.overleaf.com/5685435963xxydhyqdnwmj
read the paper
add your comments / suggestions in the document
add your name
reach us if you have any major concerns

Thank you!

@bebatut  What's the best way to proof/comment on the paper? Should I edit the source directly? (sorry, I've never used overleaf before).

@ic4f Yes you can edit the source directly. I see already (at least) a change you did. Thanks for that :)

Pinging everyone who is watching this :)


interactions module errors

This follows on a closed issue, as it could not be replicated at the time.  One factor that occurred to me later was that the MS staff could
have been using a cloud based repository versus my use of a local copy of CDM.
I'm am running against a local copy of CDM 1.6, with the updated maven pom.xml for the 1.6 version and receiving the following
error messages for all the classes in the module. I have not experienced this issue with any other modules I've processed with
the java client.
I did see that the first schema listed below is version 0.9.2, so possibly its code updates related to later versions.
Reading entity schema ActivityContactDispatched located at ActivityContactDispatched.cdm.json/ActivityContactDispatched
ERROR: entity does not provide any schemas ActivityContactDispatched
Reading entity schema ActivityContactProcessingFailed located at ActivityContactProcessingFailed.cdm.json/ActivityContactProcessingFailed
ERROR: entity does not provide any schemas ActivityContactProcessingFailed
Reading entity schema ContactCheckedIntoEvent located at ContactCheckedIntoEvent.cdm.json/ContactCheckedIntoEvent
ERROR: entity does not provide any schemas ContactCheckedIntoEvent
Reading entity schema ContactRegisteredToEvent located at ContactRegisteredToEvent.cdm.json/ContactRegisteredToEvent
Please re-review this issue to determine what could be throwing this error.
Thanks

hello @cashel1,
For the schema files, we recommend only using the ones starting at 1.0 since this was when we made all the code and schema generally available.
As for the error messages, can you please provide more details about how you're seeing them?

Hello Victor,
The activityContactDispatched.cdm.json file lists the following version info at the top of the file.  Reviewed several other files and they also show a document version < 1.0.
The "documentVersion": "0.9.2",
"jsonSchemaSemanticVersion": "1.0.0"
The error messages I noted are the only items displayed, and they occur for each schema file.  I have not stepped thru the java code, but I'm guessing the 'entity does not provide any schemas' is referencing the document schema being less than 1.0
Thanks

Hi @cashel1,
These files should have been updated here as they have been internally. We will work on fixing this. In the meantime, you can remove the "documentVersion" line from the file and change the "is.CDM.entityVersion" trait to be "1.0" as well to fix it for you locally.

The schemas have now been updated so I am closing this issue.


rollback torch.norm() in spectrogram()

rollback torch.norm() in spectrogram() to v0.4.0 because torch.norm() is very slow in CPU mode as mentioned in following issues:

https://github.com/pytorch/audio/issues/740
https://github.com/pytorch/audio/issues/455

Thanks for submitting this! It is indeed enough to address the original concern. However, as mentioned here, this affects any function invoking complex_norm (since the latter uses torch.norm). I would prefer fixing complex_norm here instead of spectrogram. Is there a reason why you modified spectrogram instead?

Thanks for submitting this! It is indeed enough to address the original concern. However, as mentioned here, this affects any function invoking complex_norm (since the latter uses torch.norm). I would prefer fixing complex_norm here instead of spectrogram. Is there a reason why you modified spectrogram instead?

That's a good point! The reason I changed the spectrogram() is that the difference between v0.4.0 and v0.5.0 is from that function:

But there's no change in complex_norm() between v0.4.0 and v0.5.0. So I changed spectrogram() since I don't know all history of torchaudio. If there's no problem, as you mentioned, fixing complex_norm() is the right solution 😄

Thanks for being careful :) In this case though, I do believe changing complex_norm is the better solution: not only will it fix your problem, but it should also make complex_norm faster :)

Thanks for being careful! In this case though, changing complex_norm is the better solution: not only will it fix your problem, but it will also make complex_norm faster :)

I updated the code as you mentioned  and found out that there's no problem in my training script. Thanks!


Let support by Internet Explorer 11

Internet Explorer 11 only have partial support of the "let" feature.
(function(){
	for (let i=0; i<5; ++i)
	{
		setTimeout(
			function()
			{
				console.log("delayed loop:", i);
			},
			100
		);
	}
})();

Expected output:
delayed loop: 0
delayed loop: 1
delayed loop: 2
delayed loop: 3
delayed loop: 4

Internet Explorer 11 output:
delayed loop: 5
delayed loop: 5
delayed loop: 5
delayed loop: 5
delayed loop: 5

And for people wondering how to solve that:
(function(){
	for (var j=0; j<5; ++j)
	{
		let i = j;
		setTimeout(
			function()
			{
				console.log("delayed loop:", i);
			},
			100
		);
	}
})();

Is this covered by note 5?
https://caniuse.com/let
https://github.com/Fyrd/caniuse/blob/db981f338e4e2e9acb102e10e4096fa1c284076d/features-json/let.json#L418


[Bug] Create new Organisation has a broken design

Steps to reproduce:

Navigate to home page
Click on the Create organisation
and observe the pop up

Observation:
The pop up for creation looks incomplete as the submit and cancel button needs more clarity

A duplicate issue


tools/magit: add magit-diff-refine-hunk to readme

Mention how to turn on granular diffs for all hunks, as requested in #4109.

Thanks


[#171896697] Ship CDN Broker with OriginKeepaliveTimeout fix

What
This commit ships a new boshrelease with an updated paas-cdn-broker. Hopefully it fixes a bug around updating CDN routes.
How to review
Before deploying this, create or find an existing CDN route instance. Make sure its Origin Read Timeout is set to 60 seconds (we didn't do that to existing dev CDN routes.) Try changing the headers and check you get this error:
$ cf update-service my-cdn-route -c '{"headers": ["Accept", "Authorization", "Host"]}'
Server error, status code: 502, error code: 10001, message: Service broker error: IllegalUpdate: OriginKeepaliveTimeout is required for updates.
	status code: 400, request id: 5a76887e-1e3d-4d8b-af86-9eece2291d06

Then deploy this change. See if the command above works. We don't have good testing around the CDN broker, so create a new CDN Route too just to be sure it's all working.
How to merge
Before merging, you need to review and merge the following PRs:

https://github.com/alphagov/paas-cdn-broker/pull/31
https://github.com/alphagov/paas-cdn-broker-boshrelease/pull/28

Once those are merged the cdn-broker-release/build-final-release job in our build Concourse will run. Copy the YAML output from that, update this PR's commit with it, and remove [WIP] from the commit name. Then you can merge this.
Who can review
Not @46bit.

Can confirm this affects an existing CDN route in Toby's env, even before the 60s read timeout.

I fixed this one error, only to see another error pop up behind it:
Server error, status code: 502, error code: 10001, message: Service broker error: InvalidArgument: The parameter Field level encryption id is required.
  status code: 400, request id: c02e2d10-9d18-4f33-bd65-e393000025dd

I've now found https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/distribution-overview-required-fields.html, which shows we will need to start supplying lots of fields when doing updates which we don't yet provide.

The issue this PR was addressing was fixed in another PR, and this one is now obsolete.


Add the place name somewhere on the screen

Sometimes I'm eager to know what the place of current video is and I feel it might be cool if we can have an option to show the place name somewhere on the screen.

This is available on latest beta, be aware that there are other changes though :
https://github.com/JohnCoates/Aerial/releases/tag/v1.4beta9


Instances for NonEmpty Array and NonEmpty List

There's a couple things in the commit that could probably use some improvement, but this should be a start.  Let me know if there's anything you want changed.

Hi @dgendill! Thanks for adding these useful instances. Tthey're a valuable addition to the library and I'd like to merge them in. I'm sorry it took so long to get back to you.
I think two steps need to be taken before merging:

We'll need to resolve the merge conflicts
I'd like to see a test case covering this instance. Test coverage isn't perfect so far, but from this point onward I'd like to make sure any new instances or revisions to existing ones are accompanied by a QuickCheck round-trip test. I see you added one with StrongCheck a while ago -- perhaps it could simply be recovered with QuickCheck?

I understand it's been a long time since this was opened and I'm sorry it wasn't addressed. That said, I'm here to stay on top of that sort of thing now, and I promise I'll respond within a day or two if you update this PR.
I'll wait for a week to give you a chance to check in, but after that I'll take those actions myself and merge this in. Please let me know if you have any objections to that or would like to jump on that yourself.

Hi, @thomashoneyman thanks for taking the time to look at this. I've resolved the conflicts and added a new test case for encode/decode of NonEmpty Array String and NonEmpty List String. It's been a while since I've done anything with QuickCheck and PureScript so let me know if I did anything wrong.

@dgendill I think this is very close to being good to go. I'd prefer just implementing the two instances concretely rather than have the helper toNonEmpty function, if that's OK, simply because that way we can more easily re-use the uncons functions for Array and List and we don't export a function that's not really relevant to the library other than its use as a helper for these instances.
If you're OK with that change, then I'm happy to merge!

Looks good to me! Thanks! I'll merge this in, but there are a couple of improvements in the pipeline so I'm not quite ready for a release.


Inconsistency of message_k and temp_message_k buffer size

Per discussion in #858 , the message_k reserves with large buffer where temp_message_k is medium, and this result in runtime error. Changing the temp_message_k to large will resolve this issue.
libspdm_append_managed_buffer 0x1e6 fail, rest 0x7a only
Reference:
https://github.com/DMTF/libspdm/blob/d9a07ede65a818236411abfe5d580e9e49024f4e/include/internal/libspdm_common_lib.h#L236-L242

Issue was fixed by https://github.com/DMTF/libspdm/pull/862


Upgrade bookshelf to 0.9.1

Changelog is here
There was a small breaking change from 0.7.9 -> 0.9.1, but according to the Changelog it wouldn't affect very many people. I'll leave it up to the maintainers here to decide whether this package should receive a major version bump.

Thanks for the contribution @chadxz! We're probably just going to make it a minor version since the behavior of this module doesn't change form upgrading.

Version 1.6.0 published!

thanks @robinjoseph08 !


Warn when project constraint is missing in Gopkg.toml

For every project in Gopkg.toml, there should be a constraint (branch, version or revision). A project without any constraint doesn't tell anything useful to dep.
For example, Gopkg.toml with a project:
[[constraint]]
  name = "github.com/x/y"

should result in warning during manifest validation and tell the user to add a branch/version/revision constraint.

mmmm, almost - a [[constraint]] is useful if either a version rule OR a source rule is present. but other than that, yeah, this would be good to add 😁

Hey @sdboyer @darkowlzz can I pick this one up?

@JackyChiu go for it! 👍

@sdboyer @darkowlzz The importers make entries like this when a constraint version/branch cannot be determined. Here's the original PR where that behavior was introduced https://github.com/golang/dep/pull/901. If we are going to start warning about config that dep itself is generating, then we'll need to change the importers to do something different.
I can't find the original issue/discussion on why we use gps.any for the constraint, instead of ommitting it, but I thought it had to do with confusion around getting an empty manifest (but populated lock) after importing.

@carolynvs a quick update. I had a discussion with Sam about this and we decided to omit those projects from manifest for which we don't have proper/useful constraints.

Thanks for the quick clarification! I've created https://github.com/golang/dep/issues/1373 to get the importers tweaked to match and flagged it with help wanted.


When switching over to MfD from another window, even if I...

Description:
When switching over to MfD from another window, even if I click in the Type a message... box, I have to click in it again to begin typing. I would expect to be able to begin typing as soon as I switch over, like Skype does.
Steps to reproduce:
With another window active, move the mouse over the MfD window and click within it, outside of the Type a message... box. The MfD window will become active, but you will not be able to begin typing until you click in the Type a message... box.
App version:
Version 2.0.1-beta
OS:
Windows 10 Home Edition
Works in WhatsApp Web:
Extra:
When using a dark theme, I'd like the bits of dark text (such as the information about the person you're messaging at the top of their message log) to change to white text, so they are easier to read.

Additional: Right-clicking in MfD causes a box to pop up saying "JavaScript error in the main process"


Fix badge with build and version statuses in README.md

Description
Fix badge with build and version statuses in README.md
Before:

After fixes:

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I wrote unit tests for my code (if tests is required for my changes)
[x] I have made changes in CHANGELOG.md file

@eldario
Can your merge this PR?
I didn't make any changes to file CHANGELOG.md because it's a purely dev-fix.


Add support mount multiple secrets

Hi..
When vault come into different path for applying some policy for different departement like database credentials, apps configuration and others, We need to merge into one environment configuration in kubernetes apps.
Rather than create more than one vault kind for each path, I think this can be done by mount multiple path of vault in one kind vault-crd then combine it into one secrets, then mount it into kubernetes apps environment for only single secrets

Hi @ardimaul,
please have a look at this: https://vault.koudingspawn.de/supported-secret-types/secret-type-properties
Does it support your requirements?

Hi @DaspawnW
Yes, it works like that, multiple mounting.. But it doesn't support return as string without specify the key like KV/KV2 mounting type.

Hi @DaspawnW
Yes, it works like that, multiple mounting.. But it doesn't support return as string without specify the key like KV/KV2 mounting type.

Maybe it will looks like this,
spec:
  type: "KEYVALUE"
  path:
    - "secret/one-secret"
    - "secret/two-secret"

If key exist in both secret, the last key in secret will apply to them

Hi @ardimaul,
I would really welcome a merge request for it :-)

Hi @matiri132,
I would recommend you create a new Secret Type:

https://github.com/DaspawnW/vault-crd/blob/master/src/main/java/de/koudingspawn/vault/vault/impl/KeyValueGenerator.java
https://github.com/DaspawnW/vault-crd/blob/master/src/main/java/de/koudingspawn/vault/kubernetes/scheduler/impl/KeyValueRefresh.java

The other option is you add an additional property next to the path property called paths (to prevent collision) https://github.com/DaspawnW/vault-crd/blob/master/crd.yml#L25 and update the corresponding VaultSpec in Java:
https://github.com/DaspawnW/vault-crd/blob/master/src/main/java/de/koudingspawn/vault/crd/VaultSpec.java#L10
Then you can "simply" change the KeyValueGenerator / KeyValueRefresh classes to take this up.

Hi @DaspawnW , i was working around the propossals that you give me to start the resolution of the issue but i'm blocked.
I'm trying to add a property called paths what works as Array in the crd.yaml, so the VaultSpec  receives this Array as "paths".
But then the KeyValueGenerator wants to return a single secret.
Here i'm blocked cause i can't reach where the KeyGenerator is used to create the Kubernetes secret from the VaultSecret.
If you can guide me in the code flow or give me some documentation of how works the whole program to figure out how continue with this.
I'll give to you this first changes in a new branch (but the code not compile yet).


chore(main): release 11.0.0

:robot: I have created a release beep boop
11.0.0 (2024-10-27)
⚠ BREAKING CHANGES

refactor v1 internal state and options logic (#780)
refactor v7 internal state and options logic, fixes #764 (#779)
Port to TypeScript, closes  #762 (#763)
update node support matrix (only support node 16-20) (#750)

Features

add support for MAX uuid (new in RFC9562) (#714) (0385cd3)
Port to TypeScript, closes  #762 (#763) (1e0f987)
support v6 uuids (#754) (c4ed13e)
update node support matrix (only support node 16-20) (#750) (883b163)
v8 support (#759) (35a5342)

Bug Fixes

missing v7 expectations in browser spec (#751) (f54a866)
refactor v1 internal state and options logic (#780) (031b3d3)
refactor v7 internal state and options logic, fixes #764 (#779) (9dbd1cd)
remove v4 options default assignment preventing native.randomUUID from being used (#786) (afe6232)
revert "perf: remove superfluous call to toLowerCase (#677)" (#738) (e267b90)
seq_hi shift for byte 6 (#775) (1d532ca)
tsconfig module type (#778) (7eff835)

Performance Improvements

remove superfluous call to toLowerCase (#677) (e53793f)

Miscellaneous Chores

release 11.0.0 (#805) (b003cde)

This PR was generated with Release Please. See documentation.

@ctavan: Finally pulling the trigger on enabing release-please here. 🎉
Merging this PR should publish<EMAIL_ADDRESS>to NPM, but this'll be the first actual test of that.
'Wish I could say this has gone smoothly, but there's been a couple hiccups:

RP initially marked this as version 10.0.0.  Why?  I don't know.  But  I fixed that by manually overriding the version with #805.  (Note: manual-override like that also provides a way of doing prerelease versions, if all else fails.)
The CHANGELOG updates here include some outdated commits from pre-v11.  Why?  Again, I don't know.  Maybe something to do with non-linear git commit history?  'Not at all sure that's the issue here, but I saw something similar with standard-version when doing the v11-prerelease, so I suspect it's more an issue with the git repo structure and not RP.

The upshot of this is that I'm hopefull these are one-off issues and that things will go more smoothly moving forward.
Regarding the actual release, it's worth noting that there's no actual changes to the built NPM release.  All the recent code churn has just been fixing up the dev and CI toolchains.
Anyhow... let me know if you have any concerns.

@ctavan Note: I've created a uuidbot account to use for automated task and updated the PAT used by the RP workflow to one generated from that account.  Moving forward, release PRs should show up as coming from uuidbot instead of me.
I'm sending sharing the account info with you via lastpass, so keep an eye out for that email.  Let me know if there's a better way of sharing.  (I use 1password as well, but lastpass is where I keep this sort of thing.)

One last note before merging:  PR is blocked because the commits need to be signed... but I don't see an obvious way of fixing that at the moment.  So yet another reason to allow admins to override and merge anyway.


Implementation of getModerator() for GuildVoiceEvents

Feature Request
The feature is related to some ideas I made for my Bot which couldn't be fullfilled by neither JDA nor my code (which was a miserable attempt to get the moderator and only worked 40% of the time).
Example Use-Case

Logging which moderator muted/deafened/disconnected a member to prevent the moderator of abusing his rights

Describe the solution you'd like
An event.getModerator(), which returns the moderator which caused the event for the following events:

GuildVoiceLeaveEvent
GuildVoiceMoveEvent
GuildVoiceGuildMuteEvent
GuildVoiceGuildDeafenEvent

(If the moderator wasn't the reason for some of these events, setting the value to null would be an option)
Describe alternatives you've considered
As an alternative of getting the moderator I considered using the AuditLog which worked more or less 40% of the time
Additions

The Getter doesn't need to be named "getModerator()", I am just very bad at naming stuff, that's why i picked the most obvious name i could think of

Discord does not provide such information is voice events, JDA tries to wrap the Discord API as close as it can, while not providing too high level functions, as you also said, using audit logs is rather unreliable, so there is no way JDA can do it better
Unless Discord recently made a change in the API to include this info, which I am not aware of, I don't see how this feature could get added


Unable to use FEZ.Hooks.dll in a mod

Presumably isolating FEZ.Hooks.dll into a separate file wasn't the greatest idea - the game is unable to load the library properly when any mod is requesting its usage.

The only way I've managed to make it work is by including the hooks library within the MonoModded executable. However, I didn't manage to ILRepack both Hooks library and HAT together properly.
For now, I've gone back to the old solution, which is including FEZ.Hooks.mm.dll and let MonoMod do its job. The patching process is significantly slower with this method, but I'm not seeing any better solution right now. I should probably revisit this in the future.


change title on README

Left reviews and line comments
Created a file and made a commit
Opened a pull request

Testing

Testing

Looks solid

Looks solid


RF: ZNC-26: Issue Template to highlight Discourse

Following conversations with Jono Bacon, it was highlighted that we should insist on redirecting people to the forum on the issue submission form. This pull request attempts to make a stronger statement than before on this matter.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

This is good to go.

PR has been updated. Reviewers, please be cautious.

Thanks @stefano, thought I fixed those... squashed both commits and rebased, ready to merge @rahulreddy

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.

PR has been updated. Reviewers, please be cautious.


feat: copy link to clipboard when adding to ipfs

With this PR, we get back the feature of copying a shareable link to the clipboard when adding files to our node via the IPFS icon that sits on the menubar on macOS or to the shortcut of the app on Windows.
In addition, I cleaned up the locale messages, removing some that are not used anymore and updating the ones we have for this notification in particular. I will create a separate PR organizing the translation file a bit more.
We now add all files at once and give only one notification. If the user drops multiple files, we create an object linking to all of them, which is used for the shareable link and when clicking on the notification.
Closes #1218.
License: MIT
Signed-off-by: Henrique Dias<EMAIL_ADDRESS>

Thanks for your review @autonome! 😃

it bundled up two distinct changes: adding multiple files, and the clipboard change.

We already added multiple files, but not inside this function. We'd just call the function multiple times and get the same number of notifications as files, which would be annoying.
But yeah, I agree it could be separated into two PRs.

Sometimes the code is just too tangled to do that easily and I don't know the Desktop code very well, so ignore me if that's the case here!

Definitely, IPFS Desktop's code is too... not complex... but "well together"? 😆 There are a couple of things I'd like to adjust actually, but that's another matter.


Depth to Image Generation

What does this PR do?
This PR enables Depth to Image generation for stabilityai/stable-diffusion-2-depth. Changes were made to the pipeline and DDIM scheduler.
Benchmarks
Benchmark was performed between A100 and Gaudi 2 with the following settings:

torch_dtype = torch.bfloat16
prompt = "two tigers"
n_prompt = "bad, deformed, ugly, bad anotomy"
Initial image: http://images.cocodataset.org/val2017/000000039769.jpg
Pipeline command: pipe(prompt=prompt, image=init_image, negative_prompt=n_prompt, num_inference_steps=50)
2 Warmup iterations followed by 10 iterations timed
Times reported in seconds

Results:

Batch size
A100
Gaudi2 /w PNDMScheduler
Gaudi2 /w DDIMScheduler

1
1.290
1.757
1.760

2
2.017
2.934
2.908

4
3.375
5.195
5.153

8
6.268
9.664
9.649

16
11.922
18.366
18.320

32
23.303
35.974
34.727

[!Note]
PNDMScheduler has a much higher latency than DDIMScheduler during warmup

Before submitting

[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Please sync your PR with main/upstream and fix any merge conflicts. Thank you.

@pi314ever I left a comment here because I don't get the right latency in test_depth2img_pipeline_latency_bf16.


Made TachyonFileSystem methods throw better exceptions

We were turning everything into an IOException, which can make it hard
for callers to determine what went wrong in an operation. So now the
TachyonFileSystem and related classes don't wrap exceptions in an
IOException.
There are a lot of miscellaneous refactors for deprecated code and tests
to get this to compile.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4865/Failed Tests: 4org.tachyonproject:tachyon-integration-tests: 4tachyon.client.TachyonFileSystemIntegrationTest.createFileWithFileAlreadyExistExceptionTesttachyon.client.TachyonFileSystemIntegrationTest.deleteFileTesttachyon.master.FileSystemMasterClientIntegrationTest.user_getClientBlockInfoReturnsOnErrortachyon.worker.block.meta.TieredStoreIntegrationTest.deleteWhileReadTest
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4869/Build result: FAILURE[...truncated 3214 lines...][JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/pom.xml to org.tachyonproject/tachyon-clients/0.8.0-SNAPSHOT/tachyon-clients-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/pom.xml to org.tachyonproject/tachyon-client-unshaded/0.8.0-SNAPSHOT/tachyon-client-unshaded-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/target/tachyon-client-unshaded-0.8.0-SNAPSHOT.jar to org.tachyonproject/tachyon-client-unshaded/0.8.0-SNAPSHOT/tachyon-client-unshaded-0.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/target/tachyon-client-unshaded-0.8.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-client-unshaded/0.8.0-SNAPSHOT/tachyon-client-unshaded-0.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/unshaded/target/tachyon-client-unshaded-0.8.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-client-unshaded/0.8.0-SNAPSHOT/tachyon-client-unshaded-0.8.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/servers/pom.xml to org.tachyonproject/tachyon-servers/0.8.0-SNAPSHOT/tachyon-servers-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/servers/target/tachyon-servers-0.8.0-SNAPSHOT.jar to org.tachyonproject/tachyon-servers/0.8.0-SNAPSHOT/tachyon-servers-0.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/servers/target/tachyon-servers-0.8.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-servers/0.8.0-SNAPSHOT/tachyon-servers-0.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/servers/target/tachyon-servers-0.8.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-servers/0.8.0-SNAPSHOT/tachyon-servers-0.8.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/pom.xml to org.tachyonproject/tachyon-underfs-hdfs/0.8.0-SNAPSHOT/tachyon-underfs-hdfs-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/target/tachyon-underfs-hdfs-0.8.0-SNAPSHOT.jar to org.tachyonproject/tachyon-underfs-hdfs/0.8.0-SNAPSHOT/tachyon-underfs-hdfs-0.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/target/tachyon-underfs-hdfs-0.8.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-underfs-hdfs/0.8.0-SNAPSHOT/tachyon-underfs-hdfs-0.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/hdfs/target/tachyon-underfs-hdfs-0.8.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-underfs-hdfs/0.8.0-SNAPSHOT/tachyon-underfs-hdfs-0.8.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/pom.xml to org.tachyonproject/tachyon-parent/0.8.0-SNAPSHOT/tachyon-parent-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/dependency-reduced-pom.xml to org.tachyonproject/tachyon-client/0.8.0-SNAPSHOT/tachyon-client-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/target/tachyon-client-0.8.0-SNAPSHOT.jar to org.tachyonproject/tachyon-client/0.8.0-SNAPSHOT/tachyon-client-0.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/target/tachyon-client-0.8.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-client/0.8.0-SNAPSHOT/tachyon-client-0.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/clients/client/target/tachyon-client-0.8.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-client/0.8.0-SNAPSHOT/tachyon-client-0.8.0-SNAPSHOT-javadoc.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/shell/pom.xml to org.tachyonproject/tachyon-shell/0.8.0-SNAPSHOT/tachyon-shell-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/pom.xml to org.tachyonproject/tachyon-underfs-glusterfs/0.8.0-SNAPSHOT/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/target/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT.jar to org.tachyonproject/tachyon-underfs-glusterfs/0.8.0-SNAPSHOT/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/target/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT-sources.jar to org.tachyonproject/tachyon-underfs-glusterfs/0.8.0-SNAPSHOT/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Tachyon-Pull-Request-Builder/underfs/glusterfs/target/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT-javadoc.jar to org.tachyonproject/tachyon-underfs-glusterfs/0.8.0-SNAPSHOT/tachyon-underfs-glusterfs-0.8.0-SNAPSHOT-javadoc.jarchannel stopped
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4922/
Test PASSed.

Thanks for the patch! I left some comments, and please also resolve the conflicts.

Resolved merge conflicts

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4937/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4938/
Test PASSed.

@manugoyal Looks good overall, could you check the formatting?

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4949/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/4951/
Test PASSed.

LGTM, Thanks for the improvement!

LGTM, there are still a few formatting issues that I will address them separately.


Add initial cellhash demux functions

This PR adds two functions to scpcaTools, plus some associated tests.
The first function, add_hashsample_table() adds sample ID information to cellhash data, adding it to the rowData for an alt experiment. The input is a table which has the barcode ids that were used for mapping and a sample id. In our use, this will generally be derived from the file scpca-multiplex-pools.tsv from scpca-admin, but it could be any file with the two required columns. What I have not done (I realize as I write this), is check that the input table has only one unique value for each barcode id. I will plan to add that check after filing this PR.
The second function, add_demux_hashedDrops() performs demultiplexing using DropletUtils::hashedDrops(), and adds the results to the colData table of the sce object. I preserved a number of what seemed like the more important values in those fields, but I am not sure whether/how useful all of that is. The values I used are the "best" call, which should always be filled in, whether the call is confident, and what the logFC to the next call is. I then create a hashedDrops_id field that is the best call when confident and NA when not. I did not preserve doublet call info, though I probably ought to do that.
One option I was considering is to put all of the results from the hashedDrops() output in the in the colData for the altExp, and then only copy over the final calls (hashedDrops_id) to the main colData table. I'm curious what reviewers might think of that idea.
Questions for reviewers:

Does this structure/approach make sense? I will be adding functions for alternative demux methods, so I want to use this PR to get the general approach decided.
Do the function/argument names make sense? I had a lot of arguments with myself about what to call things. Again, this will affect later PRs, so sorting it out now would be good!

Thanks for the review! I add optional trimming of the altExp data to only those barcodes that have sample_ids, and with that the option to rename the altExp rows to the sample_ids.
I also changed how we handle the hashedDrops results a bit: Now I just add all of them to the altExp colData, after adding a prefix to the column names to indicate their origin. I still keep the called confident ids in the main colData, and add the translation from Best, which is an integer, to hashedDrops_bestid which contains the sample_id. I didn't do a similar translation for Second, which I could... but it seems like if people want to go that deep they ought to be able to manage the translation.


query.filter_by returns list for primary_key

More of a suggestion than an issue.  If you use filter_by on the primary_key it returns a list even though there is only one object with a primary key.

This makes no sense. filter_by does not return a list or an object but just modifies the sql query.
If you just want one item you can use .first().
Even if this would be an issue, it would not be a flask-sqlalchemy issue since filter_by is part of sqlalchemy. (http://docs.sqlalchemy.org/en/rel_0_9/orm/query.html#sqlalchemy.orm.query.Query.filter_by)

To be honest I'm just starting out on all this so I hope you guys won't be too critical.  Thanks for the honest reply though.  I suppose somebody should close this issue

Sorry if I sounded rude .. it was not my intention ;9

Sorry if I sounded ignorant it was not my intention haha.  You're fine

Hey Patrick, thanks for your feedback, but this isn't really an issue with the library, as @bastianh mentioned.
Feel free to pop onto #pocoo on freenode if you have any questions!


Typo fix in docs/readme/howitworks.mdx

Typo fix in docs/readme/howitworks.mdx

Thanks @mbrydak !


Feature selinux

two additions to make zabbix + selinux working. you maybe also need:
Selboolean{
  persistent  => true,
  value       => 'on',
}
selboolean{'httpd_can_network_connect_db': }
selboolean { 'httpd_can_network_connect': }

but this is really apache specific and should be handled by the apache module or by a profile. This PR is related to https://github.com/dj-wasabi/puppet-zabbix/issues/190

Hi @bastelfreak
The CI build failed on this:
manifests/server.pp - WARNING: indentation of => is not properly aligned on line 512
manifests/server.pp - WARNING: indentation of => is not properly aligned on line 513
manifests/web.pp - ERROR: two-space soft tabs not used on line 412
manifests/web.pp - ERROR: two-space soft tabs not used on line 415
manifests/web.pp - WARNING: indentation of => is not properly aligned on line 413
manifests/web.pp - WARNING: indentation of => is not properly aligned on line 414

Can you check and fix this first? Then I'm able to merge this PR.
Thanks in advance.
Kind regards,
Werner

I fixed the issues in server.pp. I'm not sure what is wrong with the web.pp, the code is fine, there aren't any hard tabs, only soft tabs. Every reformat I do there leads to new suspicious issues in that file.

wuhu \o/
@dj-wasabi @ericsysmin could one of you take a look please?

Looks good to me. One thing before I merge, this only concerns the Server? Not the agent?

These settings are only needed on the machine that runs the zabbix-server or the webfrontend. The agent itself doesn't need a selinux boolean in the default configuration. I just tested that on my CentOS 7 stuff with Zabbix 2.4

Ok, thanks!! 👍


Script to update the timezone in specified AGiXT Docker Compose files to the current server timezone.

Explanation of the script:
Determine Current Timezone:
Use timedatectl to retrieve information about the current server timezone.
awk extracts the timezone information from the output.
Function to Replace Timezone:
Define a function replace_timezone that takes a file as an argument and uses sed to replace the timezone pattern in the file.
The pattern TZ=${TZ-[^}]*} matches strings like TZ=${TZ-America/New_York} or similar.
Array of Files:
Create an array compose_files containing the names of Docker Compose files to be updated.
Update Each File:
Iterate through the array of files and call the replace_timezone function for each file.
Display Success Message:
Print a message indicating that the timezone in the files has been successfully updated to the current server timezone.
This script ensures that the timezone pattern in the specified Docker Compose files is replaced with the current server timezone.

Description

Motivation and Context

How has this been tested?

Screenshots (if appropriate)
Types of changes

Changes visible to users:

[ ] Bug fix (prefix: fix - non-breaking change which fixes an issue)
[x] New feature (prefix: feat - non-breaking change which adds functionality)
[ ] Breaking change (prefix: feat!! or fix!! - fix or feature that would cause existing functionality to not work as expected)

Internal changes:

[ ] Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
[ ] Tests (prefix: test - additions and improvements to unit tests and the smoke tests)
[ ] Infrastructure (prefix: chore - examples include GitHub Actions, issue templates)

Checklist

[ ] My code follows the code style of this project and passes yarn run lint.
[ ] My change requires a change to the documentation.
[x] My change works!

Hello. You can alternatively use the TZ environment variable in the .env file.


Intermittent System.IO.IOException for Schema Registry

Description
We have a persistent problem with Schema Registry that we can't seem to make reliable 100% of the time.
This happens both with Schema Registry in Confluent Cloud and using the Schema Registry deployed through Confluent for Kubernetes.
This happens only very infrequently (possibly less than 1% of the time) so it's very hard to reproduce consistently but it cause our integration tests to fail nearly 100% of the time because of 1 test failing out of hundreds.
Randomly we will have a request to publish fail with the following stack trace and error:
System.Threading.Tasks.TaskCanceledException : The request was canceled due to the configured HttpClient.Timeout of 30 seconds elapsing.
---- System.TimeoutException : The operation was canceled.
-------- System.Threading.Tasks.TaskCanceledException : The operation was canceled.
------------ System.IO.IOException : Unable to read data from the transport connection: Operation canceled.
---------------- System.Net.Sockets.SocketException : Operation canceled
at System.Net.Http.HttpClient.HandleFailure(Exception e, Boolean telemetryStarted, HttpResponseMessage response, CancellationTokenSource cts, CancellationToken cancellationToken, CancellationTokenSource pendingRequestsCts)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at Confluent.SchemaRegistry.RestService.ExecuteOnOneInstanceAsync(Func`1 createRequest)
   at Confluent.SchemaRegistry.RestService.RequestAsync[T](String endPoint, HttpMethod method, Object[] jsonBody)
   at Confluent.SchemaRegistry.RestService.LookupSchemaAsync(String subject, Schema schema, Boolean ignoreDeletedSchemas, Boolean normalize)
   at Confluent.SchemaRegistry.Serdes.ProtobufSerializer`1.<>c__DisplayClass16_0.<<RegisterOrGetReferences>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at Confluent.SchemaRegistry.Serdes.ProtobufSerializer`1.RegisterOrGetReferences(FileDescriptor fd, SerializationContext context, Boolean autoRegisterSchema, Boolean skipKnownTypes)
   at Confluent.SchemaRegistry.Serdes.ProtobufSerializer`1.<>c__DisplayClass16_0.<<RegisterOrGetReferences>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at Confluent.SchemaRegistry.Serdes.ProtobufSerializer`1.RegisterOrGetReferences(FileDescriptor fd, SerializationContext context, Boolean autoRegisterSchema, Boolean skipKnownTypes)
   at Confluent.SchemaRegistry.Serdes.ProtobufSerializer`1.SerializeAsync(T value, SerializationContext context)

How to reproduce
Publish any message that needs to make a request to Schema Registry.  We have even attempted to setup our configuration so we duplicate the URLs provided to the schema registry config to allow a retry on failure, however this doesn't seem to helped.
I would love it if the Schema Registry Client had some kind of retry semantics built in so that it could handle intermittent network failures like this.
Checklist
Please provide the following information:

[ ] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[2.0.2] Confluent.Kafka nuget version.
[7.3.0] Apache Kafka version.
[ X] Client configuration.
[ ] Operating system.
[ X] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[ ] Critical issue.

Fixed by https://github.com/confluentinc/confluent-kafka-dotnet/pull/2353