0v7725 rgb565

other than changing app_main.c
#define CAMERA_PIXEL_FORMAT CAMERA_PF_GRAYSCALE
to
#define CAMERA_PIXEL_FORMAT CAMERA_PF_RGB565
what do I need to do to get rgb image in webserver?
and I get this error after changing that line
I (148) camera_demo: Detected OV7725 camera, using RGB565 bitmap format
E (238) camera: Failed to allocate frame buffer
E (238) camera_demo: Camera init failed with error 0x101

the same to you ,how do you solve it？

Hi, I'm also not an expert on ESP32 or CAM interfacing.
But it seems currently the library doesn't support RGB565 in OV7725.
To fix the issue you're having, all you need to do is enable the SPI ram in menu config.
After all this still I get three images overlay on each other, maybe because it still doesn't support RGB565.


How to work with typed blocks by design?

Hi, please explain how you design work with typed Block (e.g. Paragraph) after retrieve Page?
  NotionResponse resBlocks =
      await notion.blocks.list(block_id: 'YYYYYYYYY');
  Pagination paging = resBlocks.content;
  for (Block block in paging.blocks) {
    if (block.isParagraph) {
      //<-- HOW TO GET Paragraph Object ?
    }
  }
`

Right now only can be obtained from jsonContent attribute :(
NotionResponse resBlocks =
      await notion.blocks.list(block_id: 'YYYYYYYYY');
Pagination paging = resBlocks.content;
for (Block block in paging.blocks) {
  if (block.isParagraph) {
    print(block.jsonContent);
  }
}

I don't like a lot of things in this package, so I'm doing it again almost from scratch breaking my mind in the process. I will think about a way to solve this problem for this new version.
Thanks for letting me know and sorry for all my mess here hehe

Thanks, it's clear now.
Dude, the code is great, don't worry. It would be worse if it didn't exist at all.
Let's try to fix the current one and support those who already use it.
May the force be with you)


(docs) Accordion Example Code is wrong - accordionId on AccordionItem

components: Accordion
reactstrap version #9.0.1
import method es
react version #16.8.0
bootstrap version #5.1.3

What is happening?
The code in the documentation is misleading, it uses AccordionItem as AccordionBody and tries to set the accordionId on the AccordionItem which is not possible.
What should be happening?
Docs code should be correct + examples should work.
Steps to reproduce issue

Implement Accordion like described in documentation
Look into Browser Console
Try to click on Accordion Header → not working

Error message in console
Warning: React does not recognize the `accordionId` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `accordionid` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
in div (created by AccordionItem)
in AccordionItem (created by Example)
in div (created by AccordionItem)
in AccordionItem (created by Example)
in div (created by Accordion)
in Accordion (created by Example)
in div (created by Example)
in Example (created by App)
in div (created by Container)
in Container (created by App)
in App

Code
https://stackblitz.com/edit/reactstrap-svw21y?devtoolsheight=33&file=Example.js

Hi @Maybach91,
I think this issue can be closed.
The example on that Storybook page does appear to have an <AccordionBody> inside each <AccordionItem>:
https://github.com/reactstrap/reactstrap/blob/1179b87c1fdc3f2289796c1e0260a6ef109ba133/stories/examples/Accordion.js#L12-L40


Unable to install beta 0.95.0b1 on Tinkerboard

Description of problem:
Running Hassio on a Tinkerboard and receives this messages when trying to install the update.
Traceback (if applicable):
19-06-23 08:11:46 ERROR (SyncWorker_5) [hassio.docker.interface] Can't install homeassistant/tinker-homeassistant:0.95.0b1 -> 404 Client Error: Not Found ("manifest for homeassistant/tinker-homeassistant:0.95.0b1 not found").
19-06-23 08:11:46 WARNING (MainThread) [hassio.homeassistant] Update Home Assistant image fails

The error persists in 0.95.0b2 and 0.95.0b3


Photo gallery css on homepage needs attention

Seems like we're getting lots of different-sized images (portrait?) than originally designed for and it looks pretty wonky.
Just needs some CSS cleanup.  If someone wants to redesign the photos stuff, that would be great too.

@merlinorg would you say that #298 and what came before took care of this?

@obscurerichard that, I would.


removing unused modules / variables and circular references

the code "var Glob = require ('./ glob.js'). Glob" in sync.js is a circular reference
and others are not used

anybody can help here?
my changes do not impact to cause this error
travis build successfully, but appveyor failed with this error:
npm install
C:\Users\appveyor\AppData\Roaming\npm\node_modules\npm\bin\npm-cli.js:82
let notifier = require('update-notifier')({pkg})
^^^
SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
at exports.runInThisContext (vm.js:53:16)
at Module._compile (module.js:387:25)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Function.Module.runMain (module.js:447:10)
at startup (node.js:148:18)
at node.js:405:3

Let's merge?

@isaacs , @jimmywarting ,
merge, please! It resolves #365 ...

I can't

@isaacs , let's merge?

@isaacs , ping

@isaacs , why this couldn't be merged?

@isaacs , merge, please!

If it helps anyone else, I resolved this in my own project by updating to the latest @rollup/plugin-commonjs and adding this to my config file:
    commonjs({ dynamicRequireTargets: 'node_modules/glob/*.js' }),

@isaacs , please merge

A request for someone to fix and merge this as I actually get a runtime error in a setup with Rollup and Typescript which is caused by the circular dependency this resolves.

@isaacs , please.

No longer an issue in v9.


Bichromatic Pads

I have extended Bichromatic Pad wallpapers to include commodore 64 and sega dreamcast...where do I upload these to?

You can fork the repository and submit these contributions as a pull release.  It looks like they're supposed to go in /libretro/retroarch-assets/tree/master/wallpapers/bichromatic%20pads/1440x900.

Hi, this has been submitted for pull release but hasn't progressed. Is there anything else I need to do? Many thanks and merry christmas

Hi, #399 has had more images edited and uploaded to finally complete the dynamic background pack; please can this be committed.
Thank you all!


Fixed IA Correction Structure

Issue #: /bcgov/entity###
Description of changes:

Fix to the IA Correction filing structure and Interface

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Oops, good catch and fix.
I'm wondering why the package lock file changed?

Hmm, not sure. After my rebase i had to pull in the latest modules added in. The latest BCRS common component work. That updated the Package-lock i spose.


db option group - ability to pass delete timeout

Description
Deleting rds option group sometimes takes longer than 15 mins. and the TF plan fails.
module.db.db_option_group.aws_db_option_group.this: Still destroying... (ID: database-test-20190709084719698200000001, 14m20s elapsed)
module.db.db_option_group.aws_db_option_group.this: Still destroying... (ID: database-test-20190709084719698200000001, 14m30s elapsed)
module.db.db_option_group.aws_db_option_group.this: Still destroying... (ID: database-test-20190709084719698200000001, 14m40s elapsed)
module.db.db_option_group.aws_db_option_group.this: Still destroying... (ID: database-test-20190709084719698200000001, 14m50s elapsed)

Error: Error applying plan:

1 error occurred:

	* module.db.module.db_option_group.aws_db_option_group.this (destroy): 1 error occurred:
	* aws_db_option_group.this: Error Deleting DB Option Group: InvalidOptionGroupStateFault: The option group 'database-test-20190709084719698200000001' cannot be deleted because it is in use.
	status code: 400, request id: 60a2dd2e-55c8-45e4-8605-faf5a0742c24

It would be nice to have support for specifying longer delete timeout, e.g.
timeouts {
    delete = "35m"
  }

This has been just fixed. Please upgrade to v2.13.0 if you are using Terraform 0.12, and use v1.36.0 if you are still on Terraform 0.11.


pull request for e2e test at 02/06/2017 17:26:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Slight cleanup of bank names

Update lib/clearingNumbers.js to use current bank names for a few clearing numbers.
(Thanks for this project! 💯)

Awesome! Thanks a lot! 🙏


make track volume and track panning adjustable

enable users to adjust volumes and panning of single tracks

implemented in v2


Syntax error

Hello,
first of all, I am going back to programming after a while so forgive me if I am missing something obvious (and I probably am).
So I am trying to use this new lib instead of miio that I used before. I'd love to have functionality like being able to get tokens from cloud, etc., but when I am trying to use it I am getting an error.
const mihome = require('node-mihome'); mihome.miioProtocol.init();
`C:\Users\Michal\source\ihome\ihome_api\node_modules\node-mihome\lib\devices\imibar.cooker.mbihr3.js:26
static model = 'imibar.cooker.mbihr3';
^
SyntaxError: Unexpected token =
at new Script (vm.js:80:7)
at createScript (vm.js:274:10)
at Object.runInThisContext (vm.js:326:10)
at Module._compile (internal/modules/cjs/loader.js:664:28)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:712:10)
at Module.load (internal/modules/cjs/loader.js:600:32)
at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
at Function.Module._load (internal/modules/cjs/loader.js:531:3)
at Module.require (internal/modules/cjs/loader.js:637:17)
at require (internal/modules/cjs/helpers.js:22:18)`

What is Node.js version you use? You can check it e.g. via node --version terminal command.

Hey, old Node.js version was the reason, the problem occured on:
Debian -
npm -v 5.8.0  node -v v10.15.2
Windows -
npm -v 6.4.1  node -v v10.15.3
After upgrading to current LTS it is working fine now, big thanks!

That's what I suspected. Glad it was so easy :-)

I am glad too, I like this library more and more as I am using it :).


where i extends Controller, and rewrite __construct, get error

TypeError
Argument 3 passed to App\Core\MY_Controller::__construct() must be an instance of CodeIgniter\Log\Logger, none given, called in /Users/deliang/Work/work/CodeIgniter4/system/CodeIgniter.php on line 706

This is the wrong repo. You want https://github.com/bcit-ci/CodeIgniter4.
Or, this sounds more like a mistake on your part, and should perhaps be posted on the forum.
We use github issues to track bugs and approved work packages.


fix term_start with env on Windows

On Windows, term_start with env is not implemented.

Codecov Report

Merging #2264 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2264      +/-   ##
==========================================
- Coverage   74.46%   74.46%   -0.01%
==========================================
  Files          90       90
  Lines      132093   132093
  Branches    29003    30888    +1885
==========================================
- Hits        98365    98357       -8
- Misses      33703    33711       +8
  Partials       25       25

Impacted Files
Coverage Δ

src/terminal.c
65.47% <ø> (ø)
:arrow_up:

src/if_xcmdsrv.c
83.63% <0%> (-0.72%)
:arrow_down:

src/os_unix.c
53.41% <0%> (-0.19%)
:arrow_down:

src/gui_gtk_x11.c
47.6% <0%> (-0.15%)
:arrow_down:

src/undo.c
81.76% <0%> (-0.07%)
:arrow_down:

src/channel.c
82.48% <0%> (+0.04%)
:arrow_up:

src/window.c
81.42% <0%> (+0.06%)
:arrow_up:

src/gui_beval.c
44.78% <0%> (+0.3%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e51d9a...edbd1b9. Read the comment docs.


Release 3.0.0 requirement pydantic<2.0 breaks our project

Since release 3.0.0 there is the following dependency for safety:
pydantic>=1.10.12,<2.0
That makes it backward incompatible for our project, since we are currently using the latest release of pydantic -  2.6.1

Another problem with 3.1.0 release.
It depends on dparse>=0.6.4b0 but 0.6.4 was not released yet ... with beta released in Oct 2023 :(

Is there any reason why safety needs to be in the same venv as the rest of the project?
Installing in a separate venv will mean that it can have separate set of dependencies from the main project (but also that there is now an additional venv to manage).


[Question]: I have new question : whereis the system route ?

疑惑的地方
1、Whereis  the system route ,  they not in app/admin/route  or app/index/route ，where are they ?
2、the page refersh by cycle
期望的结果
just answer my question

3、 new question !   it quit process ... because too many open files

1 admin-syatem route is at [ https://github.com/deatil/lakego-admin/blob/main/pkg/lakego-app/doak-admin/admin/route/route.go#L12 ]
[app/admin/route] is admin for user

2 is not see page ？

2、 I think it‘s web timer
3、 I do't know how to fix it ...  they have user avatar

avatar need attachment table have data.
at antd dev time , it need time to load vue js. it is not load all js and show.

The second question  maybe  refersh  by this ?

The second question maybe refersh by this ?

no. it is other page. it is not core.

ok , thank you


Eliminate UTILS_UNUSED_PARAM(..) macro

Unlike C, C++ has the ability to omit parameter names in implemented
interfaces when the parameter is unused, aka "unnamed parameters"
This change does the following:

Mechanically replace UTILS_UNUSED_PARAM(x) with /* x */.
Removes all doxygen directives that reference unused_*.
Removes the m4 macro that looks for __attribute__((unused)).

Signed-off-by: Enji Cooper<EMAIL_ADDRESS>

@jmmv: this came about as a subthread of #197.

@jmmv: ready! It needs some more fix up in order to pass make apidocs, but I will resolve that as part of #197.

@jmmv: ping?

This was merged as part of #197, so I'm closing this PR.

Was it? The #197 diff doesn't mention UTILS_UNUSED_PARAM at all...

Was it? The #197 diff doesn't mention UTILS_UNUSED_PARAM at all...

It was based on that branch. Sorry about the confusion >_>..

I don't understand... even if that commit was on top of another unmerged branch, GitHub should have showed the diff against the master branch (and thus have showed the two changes). Also, looking at head, I still see the macro. So... this PR needs to be revived? Is that what you meant?

I don't understand... even if that commit was on top of another unmerged branch, GitHub should have showed the diff against the master branch (and thus have showed the two changes). Also, looking at head, I still see the macro. So... this PR needs to be revived? Is that what you meant?

Oh wait! I split them up! Shoot... yeah, I'll revive the branch in a sec.

Ugh. Need to use another name. GitHub isn't letting me reopen this because I prematurely deleted the branch :(.

Ok, opened a new PR: #201. I'm waiting for it to complete.


Enable CD for git-server

Description
https://github.com/jenkinsci/git-server-plugin/pull/87
Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@alecharp @fcojfernandez @batmat et al.


The module does not work on Microsoft Edge

Hello,
First of all: Great code and features. Congrats!
The issue: When Cookiefy is implemented in a website as described in the documentation it runs without problems on Chrome, Firefox and Opera, but does not work on Edge (Microsoft Edge 44.19041.423.0, Microsoft EdgeHTML 18.19041). No error is displayed. The cookie icon and the model do not appear.
Thank you in advance for your help.

Thank you for your issue.
I am constantly testing in Microsoft Edge. For me it is working normally like in all other browsers.
Make sure you have the latest update of Microsoft Edge. I have the version 88.0.705.56.

Thank you for your prompt reply, @Jersyfi.
You are right. It works perfectly with the newest version. Unfortunately, it seems that the other version I have used to test before was too old. Thanks again for the great scripts.


Fixing ignored overlapping specs for Time.t()

Summary of changes
Based on my tests, Dialyzer is ignoring all the duplicate specs that have the same arity in Timex.ex and therefore reporting errors every time I try to use the functions with %Time{} arguments.
Checklist

[x] New functions have typespecs, changed functions were updated
[x] Same for documentation, including moduledocs
[ ] Tests were added or updated to cover changes (I don't see a clear way to add dialyzer tests)
[x] Commits were squashed into a single coherent commit
[ ] Notes added to CHANGELOG file which describe changes at a high-level (Is this necessary for such a small commit?)

Looks good, thanks!


Fix ConditionalAssignment auto-correct

Handle inner conditional inside else.
An inner conditional such as
  if cond1
    a = 1
  else
    if cond2
      a = 2
    end
  end

was not correctly handled. It should not be treated as an elsif, because it is an else and there's special logic for else branches.

Thanks!


My account is not showing up

I should be listed in this page - https://commits.top/brazil.html
but I'm :(

#40

Reopening, Just checked and I'm listed in top 1000 most followed too
https://github.com/search?l=&p=78&q=sort%3Afollowers-desc+location%3ABrazil&ref=advsearch&type=Users&utf8=✓

There was a recent change to include only public contributions on the main page of each country. If you have mostly private contributions, you'll probabl find yourself on the subpage with private contributions included.


Refactor

Make num-bigint and bigdecimal optional with feature
Use num-traits for Num
Fix a bunch of clippy lints

I also rewrote a huge chunk of this library to be easier

@j5ik2o please review

Ok whatever


Note counter in QS tile is not consistent with actual count

The notification counter does not hold the count for how many notifications are actually present.
i.e. I created a notification, it still says 0. I created a second one, it says 1.  I removed all of the notifications, it still says 1.

Depending on your device, the system might update the quick settings tile less frequently. I personally didn't have this issue.


Laravel

Add in guides/DevOps

@the-ethan-hunt I would like to work on this one!

Complete your PR edit so that this can be assigned to you

Okay. Sure.

Assigned to @pbiswas101


[Event Request] Codeunit 8 - AccSchedManagement - OnDrillDownTotalingTypeElseCase

Hello,
We are extending "Totaling Type" (from Enum "Acc. Schedule Line Totaling Type") and we would like to use the DrillDown procedure from the codeunit 8 AccSchedManagement.
Would it be possible to refactor this procedure in order to manage AccScheduleLine."Totaling Type" with a case statement and add en event to allow an else case?
New Event
    [IntegrationEvent(false, false)]
    local procedure OnDrillDownTotalingTypeElseCase(TempColumnLayout: Record "Column Layout" temporary; var AccSchedLine: Record "Acc. Schedule Line")
    begin
    end;

Suggestion for DrillDown refactoring:
    procedure DrillDown(TempColumnLayout: Record "Column Layout" temporary; var AccScheduleLine: Record "Acc. Schedule Line"; PeriodLength: Option)
    var
        AccScheduleOverview: Page "Acc. Schedule Overview";
        ErrorType: Option "None","Division by Zero","Period Error",Both;
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeDrillDown(TempColumnLayout, AccScheduleLine, PeriodLength, IsHandled);
        if IsHandled then
            exit;

        with AccScheduleLine do begin
            if TempColumnLayout."Column Type" = TempColumnLayout."Column Type"::Formula then begin
                CalcFieldError(ErrorType, "Line No.", TempColumnLayout."Line No.");
                if ErrorType <> ErrorType::None then
                    Message(StrSubstNo(ColumnFormulaErrorMsg, TempColumnLayout.Formula, Format(ErrorType)))
                else
                    Message(ColumnFormulaMsg, TempColumnLayout.Formula);
                exit;
            end;

            if "Totaling Type" in ["Totaling Type"::Formula, "Totaling Type"::"Set Base For Percent"] then begin
                AccScheduleOverview.SetAccSchedName("Schedule Name");
                AccScheduleOverview.SetColumnDefinition(TempColumnLayout."Column Layout Name");
                AccScheduleOverview.SetTableView(AccScheduleLine);
                AccScheduleOverview.SetRecord(AccScheduleLine);
                AccScheduleOverview.SetViewOnlyMode(true);
                AccScheduleOverview.SetPeriodType(PeriodLength);
                AccScheduleOverview.Run();
                exit;
            end;

            OnBeforeDrillDownOnAccounts(AccScheduleLine, TempColumnLayout, PeriodLength, StartDate, EndDate);

            if Totaling = '' then
                exit;

            case "Totaling Type" of
                "Totaling Type"::"Posting Accounts",
                "Totaling Type"::"Total Accounts":
                    DrillDownOnGLAccount(TempColumnLayout, AccScheduleLine);
                "Totaling Type"::"Cash Flow Entry Accounts",
                "Totaling Type"::"Cash Flow Total Accounts":
                    DrillDownOnCFAccount(TempColumnLayout, AccScheduleLine);
                "Totaling Type"::"Account Category":
                    DrillDownOnGLAccCategory(TempColumnLayout, AccScheduleLine);
                else
                    OnDrillDownTotalingTypeElseCase(TempColumnLayout, AccScheduleLine);
            end;
        end;
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 51150.


Having issues understanding internals/templates

I am trying to understand where we use templates from internals folder and why. At first glance is it used for server rendering? Otherwise i'd expect templates to be located within app folder.

Nope, they're used for npm run clean!


openjdk: add openjdk15

Motivation for this change
To have the latest JDK version available.
Support for darwin (of for 32-bit systems) is not included in this PR, but it seems useful already.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Quick test:

AWT Hello World: OK
Swing Hello World: OK
JFX Hello World: OK
JFX MediaPlayer: Failed

Sample code: https://github.com/taku0/JavaSample/tree/4086d84efd8041d09f0075a9f7c6fe936553c130

MediaPlayer doesn't work even with openjdk11.

ping

MediaPlayer doesn't work even with openjdk11.

ok, so no regression there

ping

who are you pinging?
Rebased, ofborg seems happier now as well.
Note there has been some discussion around which Java versions to retire, see https://discourse.nixos.org/t/retirement-of-old-openjdk-releases/9929

I've looked this over somewhat, but haven't had time to try it locally.  Still trying to find that time.  :)
The only thing I noticed so far is: I don't think we ought to leave both jdk14 and jdk15 "exposed" in all-packages.nix -- jdk14 should be inlined as the bootstrap jdk for 15, nothing more.  This way we only have one non-LTS jdk for people to choose from.

This way we only have one non-LTS jdk for people to choose from.

If we need to build it to bootstrap openjdk15 anyway, what is the advantage of not exposing it in all-packages.nix?

I'm not sure we want to maintain the approach of building an ever-growing chain of bootstrap jdks.  It might make more sense to e.g. bootstrap with adoptopenjdk.
It's also the case that any explicit dependencies on jdk13 or jdk14 are just tech debt that's gonna come due in a pretty short timeframe (~6 mos, AIUI) -- when OpenJDK stops publishing updates to them, do we mark them insecure?  Or remove them from all-packages.nix and update explicit dependencies to jdk15 etc.?  We should try as hard as we can to avoid baking dependencies on short-lived projects into nixpkgs -- the goal of the new release cadence for OpenJDK, as I understand it, is to encourage quicker adoption of new releases by making them easier to digest, and I think a rolling-release package collection like nixpkgs is better off working with that cadence if at all possible.
Maybe I'm just being optimistic that serious breaking changes like JPMS will be few and far between ... :)

I'm not sure we want to maintain the approach of building an ever-growing chain of bootstrap jdks. It might make more sense to e.g. bootstrap with adoptopenjdk.

That is what we do, right? (except on i686 where adoptopenjdk is not available, according to the comment)

It's also the case that any explicit dependencies on jdk13 or jdk14 are just tech debt that's gonna come due in a pretty short timeframe (~6 mos, AIUI) -- when OpenJDK stops publishing updates to them, do we mark them insecure? Or remove them from all-packages.nix and update explicit dependencies to jdk15 etc.?

I would like to remove them - that was part of my motivation for #105924: if we can use that to easily fetch various JDK's for development purposes, dropping openjdk14 from the 'real' packages would not be a big deal anymore.

I'm not sure we want to maintain the approach of building an ever-growing chain of bootstrap jdks. It might make more sense to e.g. bootstrap with adoptopenjdk.

That is what we do, right? (except on i686 where adoptopenjdk is not available, according to the comment)

It's not what's done in this PR; it just does:
openjdk15-bootstrap = openjdk14;

I'm not sure we want to maintain the approach of building an ever-growing chain of bootstrap jdks. It might make more sense to e.g. bootstrap with adoptopenjdk.

That is what we do, right? (except on i686 where adoptopenjdk is not available, according to the comment)

It's not what's done in this PR; it just does:
openjdk15-bootstrap = openjdk14;

Ah, you're quite right, I was looking at the wrong one.
Anyway, I see adoptopenjdk 15 has made it into nixpkgs since, which is sufficient for my use case so I'll close this one.

I've resurrected this work in #107547.


Rule: default-over-else

Prefer default assignment over catch-all else. This rule was originally meant to endorse the new default function construct, but having tested it out thoroughly for this rule, I'm now more inclined to have it flagged. I find that counter-intuitive, and as such more likely to cause harm than good. Those who disagree may configure the prefer-default-functions option. Either way, default assignment over the equivalent else feels more idiomatic to me, so the rule feels relevant despite not doing what was originally intended.
Fixes #211

Thanks @charlieegan3! Yeah, I feel like the OPA docs should be amended to mention that, as using default functions without being aware seems like it could lead to some unintended things happening. I'll create an issue for that in the OPA backlog.


How to use this to create qt widget?

How to use this to create qt widget?

Hello. This is a dependency package, that only distributes the Qt binaries for Windows, Linux and OSX via NPM. Please see https://github.com/node-3d/3d-qml-raub and its examples for QML usage. (there is likely an issue with OSX distribution though)
If you are not interested in QML you may use this package as-is: it will install you a bunch of DLLs (SO, etc, depending on the platform). And there you have it, you may go on building an addon for Node.js which somehow uses those Qt binaries. This is exactly what is done here:

https://github.com/node-3d/deps-qmlui-raub - this one is built with Qt, resulting in a DLL of its own, and
https://github.com/node-3d/3d-qml-raub - this one uses the former wrapping it into a Node.js addon

@raub Thank you!


2D pure localization: no matched laser scan showing

Hi all!
I've been using Cartographer for 2D SLAM for several months. Recently I'm trying to implement 2D pure localization.
I've successfully run the demo of 2D pure localization but when I'm trying to run my own rosbag, there's two issues:
1. No matched laser scan shown in the rviz and there's warning (no errors) related to IMU:
(1) The warning is:

(2) The rviz interface:

2. Why the map generated is not aligned with the grid line (as shown in the previous rviz interface)? Is it also something related to my IMU ?
What I want is something like this example (same X/Y direction with the grid):

Here's what rosbag_validate give me:
(1) For the rosbag used to generate the map:

(2) For the rosbag used to run pure localization:

Here's what rosbag_info give me:
(1) For the rosbag used to generate the map:

(2) For the rosbag used to run pure localization:

Here's my configuration files:

offline_backpack_2d.launch
backpack_2d.urdf
backpack_2d_localization.lua
backpack_2d.lua
demo_backpack_2d_localization.launch

Do you have comment or advice for these two issues? I can upload my rosbag files if needed.
Thanks in advance!
@gaschler @MichaelGrupp @ojura @cschuet

Hi @Ricolus. Thanks for replying.
I removed the /tf topic from my rosbag (the rosbag used to generate the map / run pure localization / both of them). Then I got the totally misordered .pbstream like this:

Even the .pbstream is wrong so of course there's still no matched laser scan showing in the pure localization. And I still got repetitive warning saying that
[ WARN] [1544759056.892053210,<PHONE_NUMBER>.641183901]: W1214 11:44:16.000000 31588 ordered_multi_queue.cc:155] Queue waiting for data: (1, imu)
Any comment or advice?
Thanks!

No matched laser scan shown in the rviz and there's warning (no errors) related to IMU

"Queue waiting for data: (1, imu)" means that no IMU data was received yet. In your offline_backpack_2d.launch you have specifed a topic remapping for the IMU, but you don't have it in your demo_backpack_2d_localization.launch.

Why the map generated is not aligned with the grid line (as shown in the previous rviz interface)? Is it also something related to my IMU ? What I want is something like this example (same X/Y direction with the grid)

The grid in RViz is aligned with the TF frame that is configured as its "Reference Frame" in RViz (probably its the map frame). Apart from that, I don't quite understand what you expect. Do you want the walls of your map aligned with the grid? The map frame is not aligned with walls.

The map is aligned with the heading of the beginning of the first trajectory. This cannot be changed.
If you want to have a fixed frame aligned to the walls, I suggest you calibrate the rotation manually and publish a fixed transform (rotation) from e.g. “map_aligned” to Cartographer’s “map” frame, and use “map_aligned” as the fixed frame in rviz.

@MichaelGrupp
Thanks for your advice. It works now! I did forget to specify a imu topic remapping in demo_backpack_2d_localization.launch.
Actually I was planning to use the map built by Cartographer for laser scan pure localization in another algorithm called mrpt_localization. In that algorithm, the submitted map must have same X/Y direction with the grid. Since I successfully made Cartographer pure_localization work, this question no longer exists.
@ojura Thanks for your notes. Now I'm just using Cartographer pure_localization and no longer consider other algorithms so the fixed frame question doesn't exist anymore.


Add redhat support to docker hypervisor

Vendor provides universal base images with a permissive EULA.

Does UBI let me distribute my container images anywhere I want?
Yes. Building on UBI means Red Hat is never going to tell you where or how you can distribute your images. You can distribute your images wherever and however you like.

In the past we enabled acceptance testing a few times when the OSes were already in the metadata.json. That's a bit tricky because that can break CI pipelines because there are unexpected new jobs for some OSes. We've RedHat listed quite often. I would love to see this merged, but we need to more sure that it passes on our modules and that the registry can handle some concurrent pulls (quay.io seems to be rather flaky :( )

Will this impact existing pipelines until the puppet_metadata change is merged?

this will impact them as soon as we release beaker-hostgenerator and puppet_metadata as minor versions.

Looks like it fails because chrony/ntpdate isn't present in UBI. I knew it had a slightly filtered list and I guess this is one of them.
This means we need to update the packages to install.
Right now this is determined in a complex way:

host_packages(host) determines which packages to install: https://github.com/voxpupuli/beaker/blob/0b477ea3f84bfdd053bad614f7a874ffbd233cf1/lib/beaker/host_prebuilt_steps.rb#L106-L153
This is used in beaker-docker: https://github.com/voxpupuli/beaker-docker/blob/72dda38788e291394271bc186d7e20eb6ee1d241/lib/beaker/hypervisor/docker.rb#L498

I'm not sure what the best way to filter it out is without breaking non-Docker deployments. Perhaps reject some values in beaker-docker for RHEL?
Then we also find a way to exclude it from the testing matrix in https://github.com/voxpupuli/puppet-chrony. Perhaps some options to add in puppet_metadata?

Looks like it fails because chrony/ntpdate isn't present in UBI. I knew it had a slightly filtered list and I guess this is one of them.
This means we need to update the packages to install.
Right now this is determined in a complex way:
* `host_packages(host)` determines which packages to install: https://github.com/voxpupuli/beaker/blob/0b477ea3f84bfdd053bad614f7a874ffbd233cf1/lib/beaker/host_prebuilt_steps.rb#L106-L153

* This is used in beaker-docker: https://github.com/voxpupuli/beaker-docker/blob/72dda38788e291394271bc186d7e20eb6ee1d241/lib/beaker/hypervisor/docker.rb#L498

I'm testing locally with a modification to https://github.com/voxpupuli/beaker/blob/0b477ea3f84bfdd053bad614f7a874ffbd233cf1/lib/beaker/host_prebuilt_steps.rb#L110 which filters time related packages if the host timesync option is disabled (which is a default I think).

I'm not sure what the best way to filter it out is without breaking non-Docker deployments. Perhaps reject some values in beaker-docker for RHEL?
Then we also find a way to exclude it from the testing matrix in https://github.com/voxpupuli/puppet-chrony. Perhaps some options to add in puppet_metadata?

Yes, filtering will need to be added. I suggest it be left up to the specific modules workflow as I suspect it will be a moving target over time.

I would like to see all the packages in beaker-docker moved to beaker. They really aren't docker specific.

Agreed, it shouldn't be needed there as it's done in host_prebuilt_steps for all hypervisors.

I would like to see all the packages in beaker-docker moved to beaker. They really aren't docker specific.

As I described: we already have that since https://github.com/voxpupuli/beaker-docker/commit/e126b7005475bd4e4a8508be4a43a1e9287b2163.
IMHO there is a benefit to installing packaging during container building: they're cached so if you rerun tests you don't need to install them again. It would be even better if we publish the built containers for even faster CI.
Though you did trigger me to look at Beaker::HostPrebuiltSteps and in validate_host it ensures the host packages are present. So just changing the definition in beaker-docker is probably insufficient.
That makes me think: can we actually refactor it so it's only installed if you actually timesync and do that for every OS? I opened https://github.com/voxpupuli/beaker/pull/1853 as a start for that.


Update Autohotkey lexer

Add fold point and keyword class and extends.
Detail:

Fold point: Fold between { and }. Autohotkey use them to mark code block.
class related keywords: class and extends. OOP of Autohotkey.

Thanks! Committed as https://github.com/orbitalquark/scintillua/commit/683915b032f0917f0af201e020ef163fdafa090d


Update description of a, shift-a points keybinds to reflect toggle

References and relevant issues
When working on https://github.com/napari/napari/issues/6746 I didn't realize that a would deselect (checked the preferences/shortcuts)
Description
Clarifies the description of the keybinding, making it describe the behavior, which includes a toggle.

Yeah I like that too, not sure why I didn't go with that in the first place!
🙏


Labeler hasnt been triggered lastly

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
It seems that the labeler hasn't worked in the last 17 days. But there has been no changes (in the workflow file nor the action).
This was brough to me by @PProfizi in https://github.com/pyansys/pydpf-core/pull/359
I'm pinging @jorgepiloto for some feedback on this, because to me, everything looks fine.
Steps To Reproduce
NA
Which Operating System are you using?
Windows
Which Python version are you using?
3.7
Installed packages
N/A

Thanks for pinging me, @germa89. I will investigate this.

In the sphinx-theme the workflow works:
https://github.com/ansys/ansys-sphinx-theme/blob/main/.github/workflows/label.yml

Which by the way they have:
https://github.com/ansys/ansys-sphinx-theme/blob/53d74171f1220b6b9c479a3f8b103e04fa218589/.github/workflows/label.yml#L72
I believe it should use [] instead of {}.


Gethistory 2

based on #316

@edouardparis looks like you tried to restart CI, this doesn't work.

CI fails. Have you looked into why?...

Added the change as a new commit so you have a chance to review it.
ACK f491c76c9b022070992452b0449e0a6e9d8e73b8

ACK edf0590c26ebf2b8cc57fb60eb1840ba0f31f254

ACK edf0590c26ebf2b8cc57fb60eb1840ba0f31f254

ACK a64c4f3ba22cc8d94cfe2b6a1dc54f89d7cf78fa

ACK a64c4f3ba22cc8d94cfe2b6a1dc54f89d7cf78fa


Kudos. And a half-baked idea for an application.

Kudos on your work! I'll be watching to see where it goes.
The half-baked idea I'd like to work on sometime (when I get time):
Up till now, hypermedia APIs have not gotten as much as attention as they deserve, arguably because they are designed for a theoretical client that doesn't actually exist. What if this client did exist in the form of code completion and validation engines for multiple languages? By existing only as a helper for the developer, it might avoid the mess of CORBA and SOAP.
Hug could make this easy if it used the HTTP Link Header to return type information. For example, it could return the following for the /users API endpoint:
{
  "@context": "http://schema.org/",
  "@type": "Person",
  "@typedef": "http://www.janedoe.com/typedefs/person.d.ts"
}

With http://www.janedoe.com/typedefs/person.d.ts being something like this (using Typescript to describe JSON because JSON Schema is unwieldy):
interface Person
{
    name: string;
    jobTitle?: string;
    telephone?: string;
    url?: string;
}

And a sample response body for a GET request:
{
  "name": "Jane Doe",
  "jobTitle": "Professor",
  "telephone": "(425) 123-4567",
  "url": "http://www.janedoe.com"
}

Related:

Hydra: Hypermedia-Driven Web APIs
Code generation

HI @ariutta, I think this is an interesting idea and would be interested to see what would come by exploring it further. Potentially including it as a plug-in for hug?
Thanks!
~Timothy

Yes, a plug-in sounds like the right place for it. I'm a little tied up with other projects right now, so it'll be awhile before I can get to it :( But I'd love to find out whether something along these lines would get traction in the dev community.
Any opinions on the best format for the type data? JSON Schema might be easiest to apply for multiple languages, but it's really verbose. Typescript is nicer to work with, but it's geared toward JavaScript, and each language would need a parser for TypeScript type definitions. JavaDoc (JSDoc/PythonDoc/etc.) style documentation comments are another option, although they are intended more for their target languages than for JSON.

@ariutta I had a quite similar idea, see #34
It would be great if the user could set a flag in the config file like HYDRA = True beside an handler for the api doc: the library this way generate a basic ApiDocumentation file and could automatically add the LINK to the vocabulary in the Response Header with the proper rel.
I have never developed on third party library, but with the right hints I could implement the thing. I am Python developer and I have quite good knowledge about REST and HYDRA.
Let's talk about.
Cheers!

Hi @Mec-iS, you're right - we're thinking along the same lines. Versions of these ideas seem to be popping up all over.
As a matter of fact, check out what the FB GraphQL team just released: a GraphQL IDE explorer with "typeahead query completion, error highlighting, query results".
Netflix is using Falcor with JSON Graph for API typing.
BreezeJS works with OData to provide API typing, although the NuGet team actually moved from OData to JSON-LD.
GraphQL and Falcor are moving away from strict REST/Hypermedia patterns more than BreezeJS/OData, which makes them less useful for Linked Open Data. What about creating something that could work with BreezeJS, but instead of relying on OData, create a replacement based on JSON-LD and TypeScript (or possibly JSON Graph)? That would involve building on hug to create a server that could return JSON-LD with TypeScript interfaces as typedefs. Then for JavaScript purposes, the JSON-LD @context and TypeScript interfaces could be used to generate metadata, as described here: http://breeze.github.io/doc-js/metadata-by-hand-details.html
BTW, @timothycrosley, do you think this thread belongs here or in its own repo?

Hi @ariutta
I think h.u.g. (as any good server, or server-level layer) should be completely independent from which client is going to hit it (the same for the output format on the other direction). So making the library compliant to any W3C standard out there is a good start (like the to-be standards HYDRA, and the Triple Pattern Fragments).
I am taking a look to all the options you pointed out; but they all seem to be supported by different actors in the market, without a defined standard to base on. So, talking server-side, I would base the first improvement on HYDRA. After that, the next step could be to leverage the HYDRA feature in h.u.g. to make the server able to respond to as many clients libraries on the market as possible.
So, much simpler:

Let h.u.g. users to easily create and use the HYDRA vocabulary via the ApiDocumentation (simply letting the user decorating a view for this purpose)
See how REST/HYDRA coupling and the needs of the different clients evolve

Your point 2. could be nice, but i don't see any advantage to port h.u.g. to Falcor. I think h.u.g. has a good potential as it is (Falcon is a very good web-server): adding support to other W3C standards (maybe also to SPARQL endpoints for LD, using a good triple store) can be a great way to go.
See you on the gitter chat for futher exchanges of ideas.
Cheers!

Closing this issue, because this is probably more of a plugin, which would go in a separate repo.


Question.

Does i need use(include) angular-extender module in my app or just use this grunt-angular-extender task?

Just use the grunt task, it is meant to extend the modules at build time (not at runtime) so no need to reference it in your application. Hope this helps.

Yes. Thanks


[zh]Sync kubeadm-3

related issue:https://github.com/kubernetes/website/issues/33479
kubeadm-3
16	3	content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_version.md
20	7	content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_init_phase_upload-certs.md
26	13	content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_token_create.md
17	4	content/en/docs/reference/setup-tools/kubeadm/generated/kubeadm_token.md

/approve

/lgtm


[Many tests ports] Run format-manifest on test_ports

I run the command:
find scripts/test_ports/ -name "vcpkg.json"  -exec ./vcpkg format-manifest "{}" \;
you can take a look we chat here: #39285

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[x] The "supports" clause reflects platforms that may be fixed by this new version.
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

FTR I think there is a reason why these manifest are not formatted:
Order of elements is sensitive to the content of supports, dependencies and features.
It is easy to remove a no-longer-unsupported platform or to add a now-supported dependency or feature, and it is very easy to review such modifcations.
But it is very hard to review what is the intented change and what is a formatting artifact when reviewing changes in a single commit.
So I tend to continue to not run format-manifest on these ports for trivial changes.
(But I strongly expect vcpkg ci to report a fail loudly if a manifest has invalid syntax!)

But it is very hard to review what is the intented change and what is a formatting artifact when reviewing changes in a single commit.

We already review such a changes to regular ports.
Once it formated, the changes will be small.
Most of the difficulty review coming from cmake behavior, not json review.
After awhile tests don't to change.
As I say I also in favor in ci check,
But local check will be fast iteration for developers.
Also save CI precious time as we experience today.

I didn't not format the vcpkg-ci-openimageio because there was already PR open fixing the problem, and not wanted to create conflict.
So this PR #39285 is still valid.

Once it formated, the changes will be small.

No, for the reasons already given...

Most of the difficulty review coming from cmake behavior, not json review.

Many of the test ports don't have "cmake behavior". The effect is achieved via the manifest alone.

After awhile tests don't tend to change.

It can take a long while until a dependency or feature can be tested for android. Similar for C++20, C++23, or osx deployment targets.

To be clear, I don't object to this PR.
I just want to help understand why such formatting differences exist, and why it might be worthwile to accept them during normal test port updates.
(We don't have a problem with test port manifest formatting. We have a problem with CI not properly reporting malformed test port manifests.)

Thanks for the fix!


how to find out what player settings in the example?

Have you read the FAQ and checked for duplicate open issues?
yes
What version of Shaka Player are you using?
3.0.1 (2020-06-18)
Please ask your question
how to find out what player settings in the example?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;asset=https://livesim.dashif.org/livesim/utc_head/testpic_2s/Manifest.mpd;panel=ALL_CONTENT;build=uncompiled

Hi @EduardWorrk! Which setting do you mean? If you open the hamburger menu in the top left corner of the demo page and click on different sections, you can see most current player configurations - are those what you wanted?
Programmatically you can run player.getConfiguration() to see the config object
shakaDemoMain.player_.getConfiguration(); in the console of our demo page, if you want that specifically.
Does that help?


Nova package updates

Std:accounts package wasn't up to date and through some unnecessary errors. This was fixed in a new release.
Package update:
std:accounts-ui from 1.1.5 to 1.1.12,
collection2 from 2.8.0 to 2.9.1,
react-meteor-data from 0.2.6beta to 0.2.7,
check-npm-versions from 0.1.1 to 0.2.0

Thanks! Btw make sure you remove all console.log before you submit a PR :)

Will do.


#935 Using 'self' instead of FQCN on Models

Related issues: closes #935
If we use -W option it will write docs to the classes directly. At this time we need to replace the Fully Qualified Class Name with self.
If we don't use -W option, it means, we using helper file instead of writing Models itself. At this time we don't need to replace FQCN with self

At this time we need to replace the Fully Qualified Class Name with self.

…

At this time we don't need to replace FQCN with self

…
IMHO we should not do that. What was used to be a single clear code path not becomes entangles in behaviour, depending on whether it's written within the class or the external one.
The general code already has so many cases, I'm on 👎 changing this at the moment.

IMHO we should not do that. What was used to be a single clear code path not becomes entangles in behaviour, depending on whether it's written within the class or the external one.
The general code already has so many cases, I'm on 👎 changing this at the moment.

thanks for feedback. You are right on most points @mfn. I just wanted to share it with community :)

At this time we need to replace the Fully Qualified Class Name with self.

…

At this time we don't need to replace FQCN with self

…

I mean when using -W parameter we need to replace FQCN with self. And if we don't used -W parameter replacing is not necessarily 🤔 sorry for fast typo combined with bad english 😂

I mean when using -W parameter we need to replace FQCN with self. And if we don't used -W parameter replacing is not necessarily 🤔 sorry for fast typo combined with bad english 😂

It's fine, I understood it 👍 I just didn't agree with it 🤷♀

I don't think there is much of a benefit to this, other than conciseness! I also agree that reducing code complexity should probably be the priority here, therefore I am also 👎 If the codebase were a bit less spaghetti, this would probably be welcome 😅

@samirmh-dev is you use-case maybe solved with https://github.com/barryvdh/laravel-ide-helper/pull/954 which was merged recently?

@mfn hey 👋 yeah it looks like already done. We can close issue I created 👍

@barryvdh PR can be dropped :}


swapi.dev rate limited after one api call

I havent made any api calls to swapi.dev in at least a couple weeks and this morning I made one api call (https://swapi.dev/api/people/1) and got
HTTP 429 TOO MANY REQUESTS
Retry-After: 25924
Content-Type: application/json
Vary: Accept
Allow: GET, HEAD, OPTIONS

{
    "detail": "Request was throttled. Expected available in 25924 seconds."
}

I am getting a similar experience.  I haven't used the API in quite a while; and, this morning I am getting the same 429 error with {"detail":"Request was throttled. Expected available in 25463 seconds."}.

Same here

Fixed. Sorry for an inconvenience...


How to invoke another microservice application

i'm newbie in JHipster and i'm trying to figure this, when i create two microservice applications, e.g. micro1,micro2,  how to call each other between micro1 and micro2?
thrift ? grpc-java ? httpclient ? HttpURLConnection ? Sping RestTemplate?

like  MicroserviceSecurityConfiguration.java ? use the RestTemplate

@Inject
    @Qualifier("loadBalancedRestTemplate")
    private RestTemplate keyUriRestTemplate;

    private String getKeyFromAuthorizationServer() {
        // Load available UAA servers
        discoveryClient.getServices();
        HttpEntity<Void> request = new HttpEntity<Void>(new HttpHeaders());
        return (String) this.keyUriRestTemplate
            .exchange("http://uaa/oauth/token_key", HttpMethod.GET, request, Map.class).getBody()
            .get("value");

    }

Hi, this is not the place to post this. Post it in the generator's issue tracker, use the Gitter or post in StackOverflow. Thanks.

@MathieuAA is right
And there is already a big discussion about this and a lot of interesting links (blog, sample repo, tuto, etc.) here -> https://github.com/jhipster/generator-jhipster/issues/3649

Thanks Pascal :)

@pascalgrimaud @MathieuAA thanks,it's cool,jhipster/generator-jhipster#3649


compute a bit smarter the metadata when there are multiple definitions for a given metric

:+1: Thanks :)


Module Augmentation

This combines #1284 and #1288 with the latest additions to the signatures, and introduces "module augmentation" for use with Rx.
Thanks to @masaeedu for getting it going, this branch is just an extension of his work. :clap:
In addition I was able to clean up Rx.DOM.ts and Rx.KitchenSink.ts, so that they simply export Rx.ts, plus add the additional augmented items.
cc @kwonoj @blesh @staltz @luisgabriel

#1284 and #1288 can be closed on behalf of this? (actually, noticed one of them closed already)

@kwonoj Yeah, this PR amalgamates the changes in both of those, alongside some changes that were only mentioned in comments (cleanup of Kitchensink to re-export from Rx, for example). Correct me if I'm wrong here @david-driscoll.

Main question in here will be 'when' to check in this changes. I think it's ok to consider now since 1.8 is released, ng2 b7 is 1.8 friendly, so next release of RxJS will work with those mostly. cc @robwormald and @IgorMinar for visibility, to not proceed if that's incorrect expectation.
Also, maybe we need commit message for 'breaking changes'? (not sure, this is non-api changes but prerequisite dependency changes)

Amazing work guys! :clap: :clap:

Amazing work guys!

: Yes, I forgot to add this emoji... :clap: :+1:

Seems Rx.TestScheduler is not exported in kitchensink?

@kwonoj yeah... I was missing TimeInterval, TestScheduler and VirtualTimeScheduler from the original file.  Those have been added back in.

great stuff! :clap:
cc @IgorMinar

Very nice @david-driscoll!

@kwonoj, can I lean on you to verify this change?

@blesh Sure. I already reviewed most of changes and mostly fine, was waiting good to go sign from you (and from ng2 also) - I'll respin verification and ping once it's ready to check in.

will verify on our end tomorrow

@robwormald cool, I'll finish verification on my end before then, can be aligned.

Change looks good to me.
@blesh , one thing to be noted - as mentioned in here (https://github.com/ReactiveX/RxJS/pull/1388#discussion_r54024603) , now CoreOperators and KitchenSinkOperators interfaces are removed by this PR. I don't see strong usecases of those interface since most of behaviors are based on Observable<T> itself so think it's ok but letting you know since there may be some reason it should exist.

Remaining things

[ ] rebase : @david-driscoll
[ ] good to go sign from ng 2 for align release schedule : @robwormald

good to go sign from ng 2 for align release schedule

What's that?
Also: @kwonoj I've added a label for "needs rebase".

@blesh nothing special - basically this change will make minimum requirement of TypeScript to 1.8.2. Check once again Angular 2 also bumps up minimum requirement before check in to avoid breaking build for further releases. I believe this won't happen but just in case to ensure.

@kwonoj @robwormald rebased

Thanks, I'll check this in around later today.

Merged with a08fabf, thanks @david-driscoll ! :tada:


Roll Flutter Engine from 59d5444cf06c to e00b53901f24 (3 revisions)

https://github.com/flutter/engine/compare/59d5444cf06c...e00b53901f24
2023-06-07<EMAIL_ADDRESS>Roll Skia from 521b8c4bb011 to a01f49f539ab (4 revisions) (flutter/engine#42608)
2023-06-07<EMAIL_ADDRESS>Roll Skia from cef18d10b363 to 521b8c4bb011 (1 revision) (flutter/engine#42605)
2023-06-07<EMAIL_ADDRESS>Roll dart to 3.1.0-169.0.dev (flutter/engine#42602)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


feat: exposing nargo version via NodeInfo

Fixes #2332
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

[ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
[ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to relevant issues (if any exist).

cc'ing @dan-aztec since we were discussing this recently


KeyError: 'loss_cls'

After 300 Iter training, raise "KeyError: 'loss_cls'".
Below is my training information:
wandb: (1) Create a W&B account
wandb: (2) Use an existing W&B account
wandb: (3) Don't visualize my results
wandb: Enter your choice: wandb: WARNING Invalid choice
wandb: Enter your choice: wandb: WARNING Invalid choice
wandb: Enter your choice: 3
wandb: You chose 'Don't visualize my results'
CondaEnvException: Unable to determine environment
Please re-run this command with one of the following options:

Provide an environment name via --name or -n
Re-run this command inside an activated conda environment.

wandb: W&B syncing is set to offline in this directory.  Run wandb online or set WANDB_MODE=online to enable cloud syncing.
=====group sizes is [1755 7042]
=====len of indices is 14660 - offset: 0 - len self 14660
/opt/conda/lib/python3.7/site-packages/torch/nn/functional.py:718: UserWarning: Named tensors and all their associated APIs are an experimental feature and subject to change. Please do not use them for anything important until they are released as stable. (Triggered internally at  /pytorch/c10/core/TensorImpl.h:1156.)
return torch.max_pool2d(input, kernel_size, stride, padding, dilation, ceil_mode)
/home/swap/project/SoftTeacher/thirdparty/mmdetection/mmdet/core/anchor/anchor_generator.py:324: UserWarning: grid_anchors would be deprecated soon. Please use grid_priors
warnings.warn('grid_anchors would be deprecated soon. '
/home/swap/project/SoftTeacher/thirdparty/mmdetection/mmdet/core/anchor/anchor_generator.py:361: UserWarning: single_level_grid_anchors would be deprecated soon. Please use single_level_grid_priors
'single_level_grid_anchors would be deprecated soon. '
2021-09-13 07:35:50,265 - mmcv - INFO - Reducer buckets have been rebuilt in this iteration.
2021-09-13 07:36:05,024 - mmdet.ssod - INFO - Iter [50/14400]	lr: 9.890e-04, eta: 1:18:29, time: 0.328, data_time: 0.021, memory: 3390, ema_momentum: 0.9800, unsup_weight: 4, sup_loss_rpn_cls: 0.4607, sup_loss_rpn_bbox: 0.2644, sup_loss_cls: 1.8000, sup_acc: 74.8359, sup_loss_bbox: 0.3120, unsup_loss_rpn_cls: 1.2687, unsup_loss_rpn_bbox: 0.4132, unsup_loss_cls: 3.9225, unsup_acc: 78.9180, unsup_loss_bbox: 2.3666, loss: 10.8082
2021-09-13 07:36:20,035 - mmdet.ssod - INFO - Iter [100/14400]	lr: 1.988e-03, eta: 1:14:52, time: 0.300, data_time: 0.012, memory: 3390, ema_momentum: 0.9900, unsup_weight: 4, sup_loss_rpn_cls: 0.2892, sup_loss_rpn_bbox: 0.2540, sup_loss_cls: 0.4055, sup_acc: 92.8125, sup_loss_bbox: 0.2864, unsup_loss_rpn_cls: 0.1523, unsup_loss_rpn_bbox: 0.0000, unsup_loss_cls: 0.0626, unsup_acc: 99.9648, unsup_loss_bbox: 0.0114, loss: 1.4615
2021-09-13 07:36:35,185 - mmdet.ssod - INFO - Iter [150/14400]	lr: 2.987e-03, eta: 1:13:43, time: 0.303, data_time: 0.012, memory: 3390, ema_momentum: 0.9933, unsup_weight: 4, sup_loss_rpn_cls: 0.2405, sup_loss_rpn_bbox: 0.2624, sup_loss_cls: 0.3531, sup_acc: 92.7383, sup_loss_bbox: 0.2667, unsup_loss_rpn_cls: 0.1803, unsup_loss_rpn_bbox: 0.0000, unsup_loss_cls: 0.0657, unsup_acc: 100.0000, unsup_loss_bbox: 0.0000, loss: 1.3686
2021-09-13 07:36:51,586 - mmdet.ssod - INFO - Iter [200/14400]	lr: 3.986e-03, eta: 1:14:30, time: 0.328, data_time: 0.012, memory: 3390, ema_momentum: 0.9950, unsup_weight: 4, sup_loss_rpn_cls: 0.3032, sup_loss_rpn_bbox: 0.3015, sup_loss_cls: 0.4180, sup_acc: 92.7266, sup_loss_bbox: 0.2982, unsup_loss_rpn_cls: 0.1778, unsup_loss_rpn_bbox: 0.0000, unsup_loss_cls: 0.0629, unsup_acc: 100.0000, unsup_loss_bbox: 0.0000, loss: 1.5616
2021-09-13 07:37:07,086 - mmdet.ssod - INFO - Iter [250/14400]	lr: 4.985e-03, eta: 1:14:01, time: 0.310, data_time: 0.012, memory: 3390, ema_momentum: 0.9960, unsup_weight: 4, sup_loss_rpn_cls: 0.3210, sup_loss_rpn_bbox: 0.4059, sup_loss_cls: 0.4333, sup_acc: 92.9453, sup_loss_bbox: 0.3436, unsup_loss_rpn_cls: 0.1687, unsup_loss_rpn_bbox: 0.0000, unsup_loss_cls: 0.0740, unsup_acc: 100.0000, unsup_loss_bbox: 0.0000, loss: 1.7465
2021-09-13 07:37:22,497 - mmdet.ssod - INFO - Iter [300/14400]	lr: 5.984e-03, eta: 1:13:32, time: 0.308, data_time: 0.011, memory: 3390, ema_momentum: 0.9967, unsup_weight: 4, sup_loss_rpn_cls: 0.3386, sup_loss_rpn_bbox: 0.4950, sup_loss_cls: 0.3686, sup_acc: 93.9102, sup_loss_bbox: 0.2682, unsup_loss_rpn_cls: 0.1938, unsup_loss_rpn_bbox: 0.0000, unsup_loss_cls: 0.0760, unsup_acc: 100.0000, unsup_loss_bbox: 0.0000, loss: 1.7401
Traceback (most recent call last):
File "tools/train.py", line 198, in
main()
File "tools/train.py", line 193, in main
meta=meta,
File "/home/swap/project/SoftTeacher/ssod/apis/train.py", line 205, in train_detector
runner.run(data_loaders, cfg.workflow)
File "/opt/conda/lib/python3.7/site-packages/mmcv/runner/iter_based_runner.py", line 133, in run
iter_runner(iter_loaders[i], **kwargs)
File "/opt/conda/lib/python3.7/site-packages/mmcv/runner/iter_based_runner.py", line 60, in train
outputs = self.model.train_step(data_batch, self.optimizer, **kwargs)
File "/opt/conda/lib/python3.7/site-packages/mmcv/parallel/distributed.py", line 53, in train_step
output = self.module.train_step(*inputs[0], **kwargs[0])
File "/home/swap/project/SoftTeacher/thirdparty/mmdetection/mmdet/models/detectors/base.py", line 238, in train_step
losses = self(**data)
File "/opt/conda/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1051, in _call_impl
return forward_call(*input, **kwargs)
File "/opt/conda/lib/python3.7/site-packages/mmcv/runner/fp16_utils.py", line 128, in new_func
output = old_func(*new_args, **new_kwargs)
File "/home/swap/project/SoftTeacher/thirdparty/mmdetection/mmdet/models/detectors/base.py", line 172, in forward
return self.forward_train(img, img_metas, **kwargs)
File "/home/swap/project/SoftTeacher/ssod/models/soft_teacher.py", line 50, in forward_train
data_groups["unsup_teacher"], data_groups["unsup_student"]
File "/home/swap/project/SoftTeacher/ssod/models/soft_teacher.py", line 77, in foward_unsup_train
return self.compute_pseudo_label_loss(student_info, teacher_info)
File "/home/swap/project/SoftTeacher/ssod/models/soft_teacher.py", line 120, in compute_pseudo_label_loss
student_info=student_info,
File "/home/swap/project/SoftTeacher/ssod/models/soft_teacher.py", line 244, in unsup_rcnn_cls_loss
loss["loss_cls"] = loss["loss_cls"].sum() / max(bbox_targets[1].sum(), 1.0)
KeyError: 'loss_cls'

I think it is caused by multiple threads, I has tried change workers_per_gpu from 4 to 0, then there is no problem here!
but loss become nan

I think it is not related to multiple threads. What about the batch size? Did you use a batch size of 1?

I think it is not related to multiple threads. What about the batch size? Did you use a batch size of 1?

I think it is not related to multiple threads. What about the batch size? Did you use a batch size of 1?

I think it is not related to multiple threads. What about the batch size? Did you use a batch size of 1?

Thank you for your reply, samples_per_gpu is 2.
Below is my config:
base="base.py"
data = dict(
samples_per_gpu=2,
workers_per_gpu=4,
train=dict(
    sup=dict(

        ann_file="data/coco/annotations/instances_train2017.json",
        img_prefix="data/coco/train2017/",

    ),
    unsup=dict(

        ann_file="data/coco/annotations/instances_unlabeled2017.json",
        img_prefix="data/coco/unlabeled2017/",

    ),
),
sampler=dict(
    train=dict(
        sample_ratio=[1, 1],
    )
),

)
semi_wrapper = dict(
train_cfg=dict(
unsup_weight=2.0,
)
)
checkpoint_config = dict(by_epoch=False, interval=1000, max_keep_ckpts=20)
optimizer = dict(type='SGD', lr=0.01, momentum=0.9, weight_decay=0.0001)
optimizer_config = dict(grad_clip=dict(max_norm=35, norm_type=2))
lr_config = dict(step=[2400 * 4, 3200 * 4])
lr_config = dict(
policy='step',
warmup='linear',
warmup_iters=500,
warmup_ratio=0.001,
step=[1000, 3200 * 4])
runner = dict(delete=True, type="IterBasedRunner", max_iters=3600 * 4)

I see. I will have a try.

I see. How many GPUs do you use? I will have a try.

Only one GPU

OK. I will post the debug result here ASAP.

OK. I will post the debug result here ASAP.

Thanks

I can reproduce the NaN problem. And I think it is mainly related to the learning rate. In our code, the learning rate (optimizer=dicr(lr=[HERE}) indicates the total learning rate for a batch. So for a smaller batch, you should reduce the learning rate (maybe 1/32 of the original one in your case).

Thank you for your reply.
I will try a bigger batch size in server.
Can't you repeat "KeyError: 'loss_cls'"?  Maybe it's because I train on a custom dataset

Yes, I can't. I tried to change the workers_per_gpu but can only observe the nan error. Could you pull the latest code and run several iterations on coco dataset?

Yes, I can't. I tried to change the workers_per_gpu but can only observe the nan error. Could you pull the latest code and run several iterations on coco dataset?

I'll try it sometime. I need to download the Coco dataset first

Yes, I can't. I tried to change the workers_per_gpu but can only observe the nan error. Could you pull the latest code and run several iterations on coco dataset?

After I use bigger batch size on the server, the problem went away.

OK.

Yes, I can't. I tried to change the workers_per_gpu but can only observe the nan error. Could you pull the latest code and run several iterations on coco dataset?

After I use bigger batch size on the server, the problem went away.

Hi,I had the same problem, but couldn't solve it.


Workflow error in module when using a prefix and 'expand' in a rule input

Snakemake version
7.3.8
Describe the bug
I have an issue when using a workflow as module in another workflow with a prefix. Rules from the module that are using 'expand' as input generate a WorkflowError (see below). This does not occur when removing the prefix in the module definition.
Logs
WorkflowError in line 15 of /home/romain/work/test/wfA/Snakefile:
Flags in file patterns given to expand() are invalid. Flags (e.g. temp(), directory()) have to be applied outside of expand (e.g. 'temp(expand("plots/{sample}.pdf", sample=SAMPLES))').
  File "/home/romain/work/test/wfB/Snakefile", line 5, in <module>
  File "/home/romain/work/test/wfA/Snakefile", line 15, in <module>

Minimal example
Two simple workflows with the following structure:
.
├──  wfA
│   └── Snakefile
└── wfB
    ├── a.txt
    ├── b.txt
    └── Snakefile

wfa/Snakefile:

WILDCARDS = ['a', 'b']

rule copy_data:
    input:
        '{x}.txt'
    output:
        'results/data/{x}.txt'
    shell:
        'cp {input} {output}'

rule test:
    input:
        expand(rules.copy_data.output, x=WILDCARDS)
    output:
        'results/test_wfA.txt'
    shell:
        'cat {input} > {output}'

wfB/Snakefile:
module wfA:
    snakefile: '../wfA/Snakefile'
    prefix: 'results/wfA'

use rule * from wfA as wfA_*

rule test:
    input:
        rules.wfA_test.output
    output:
        'results/test_wfB.txt'
    shell:
        'cp {input} {output}'

Snakemake command ran from wfB:
snakemake -j1 -n results/test_wfB.txt
Additional context
The example above generates the logs I posted but it works when commenting the "prefix" line in "module wfA". I'm not sure if it's a bug or if I missed something in modules.

I am having the same issue on version v8.10.6, but when the input file is a temp (in your case, if copy_data.output  was temp(copy_data.output) ).
I think the issue might be around:
https://github.com/snakemake/snakemake/blob/293bc056b6c44f17340543b2678f8a59e808a5a6/snakemake/path_modifier.py#L55
If the path is changed (like when you add a prefix) then it adds a PATH_MODIFIER_FLAG flag to the file, and this might be causing the expand to fail:
https://github.com/snakemake/snakemake/blob/293bc056b6c44f17340543b2678f8a59e808a5a6/snakemake/io.py#L1250-L1255
Not sure how best to fix it, but maybe we need to change the expand code to ignore the PATH_MODIFIER_FLAG flag.


fix: icrease allowed running time of gCNV jobs

Coverage: 84.263%. Remained the same when pulling ed1ddcdc2ea6bdd2751abfe7b291e9a7c1141d43 on fix-bump-gcnv-running-time into 7ef41fad177c6312dc62cbf11e79df433b1a7053 on main.


New elixir computing a simplified colliding flow setup inspired from ...

…astrophysics. very tough on the high order method and thus a nice benchmark for the current and future shock capturing approaches

Thanks for the review, I included everything!


Lookbook FS listener can hang a non-server process

We recently had an issue where, after introducing Lookbook, several of our non-server scripts ( things in the manner of bin/run_some_database_tasks or bundle exec rake do_a_thing ) would fail to exit cleanly - instead they would just hang. Investigating this, we found that there was a single fs_event process ( from the listen gem ) that was only looking at view_component directories. After further investigation, it appeared that by setting config.lookbook.listen to false in our application config, the fs event watching process would not be started, and our processes would exit cleanly.
Reviewing the Ruby stack traces of the processes while they were hung, it seemed like the hang could occur due to an odd interaction of the debug Ruby gem and the listen gem.
Also, it seems like the very idea that file system watchers were initialized and running in a non-server process ( eg, a Rake task ), seems likely not intended. It is probably worthwhile to make it such that the filesystem watchers only initialize and run in cases where the application is running as a server and not as a script or Rake task.

Hey @netshade, many thanks for the detailed bug report and I'm sorry that this has had to take up your time!
You are right - those file system watchers should not run in non-server processes. I've just done a little testing and determining what is and isn't a server process is harder than I had assumed, but I think I have a fix that I'll push up shortly.
Out of interest, what version of Lookbook are you using? Are you using a v1.0 beta version?
Really appreciate your help with this and I'll let you know as soon as I have a release out with a fix.

Hey again @netshade.
I've just released v0.9.5 that I'm hoping fixes the issue for the most part. After much tearing hair out trying to figure out how to tell a server process from a non-server one I stumbled across a pretty neat way of doing it, but it's only supported in Rails >= <IP_ADDRESS>.
So for older versions of Rails it just checks for if it is running in a rake task (if so, it won't start listening), as this was really the only reliable check I could put together. I'll see if I can improve it in the future.
I'm going to port these changes over to the v1.0-beta branch later on and will get a new release of that out too when I can.
If you have a chance to test it and let me know if you are still experiencing any issues then that would be much appreciated :-)

I just tested it, and it works "sort of" for our case. Here's what's happening:

We initialize a server process with Lookbook enabled. This works, as the listener starts up as desired.
We run a rake task. This works, as Rails.application.server is nil, so then we hit your else case and it checks to see if we're in a rake task.
We run a script that does require "../config/environment" to load the Rails environment. This does not work and the filesystem listener starts up, due to the fact that: Rails.application.server is nil, so we fail the first part of the condition you added, which takes us to the else, which in turn will start the listeners because rake is not involved in the process.

I think what might be intended by your commit is something more along the lines of:
if Rails.version >= "<IP_ADDRESS>"
  if Rails.application.server
    Rails.application.server { init_listeners }
  end
else
  init_listeners unless File.basename($0) == "rake" || Rake.application.top_level_tasks.any?
end

because I assume that, if you are in any Rails beyond <IP_ADDRESS>, you don't care about the rake fallback, it is only whether or not server is present. ( Totally acknowledge that the explicit version check is not great, just the easiest way to communicate what's intended there. I guess you could also do if Rails.application.public_methods.include?(:server) or something like that too, tho I doubt anyone would say that's much "better" )

Ok that is very helpful, thank you. I'm really a frontend dev (as you can probably tell by the state of my Ruby code!) and so my go-to approach is usually to feature test rather than compare versions. But now looking at it again after reading your explanation I can see that attempting some sort of feature detection here is totally the wrong approach. Serves me right for rushing something out :-)
Appreciate you sharing your use case details - I certainly hadn't thought through the require scenario so that is very helpful.
I'm going to get a branch up with the changes you suggest and then if all is good I'll get out another release with the fix.
Are you current using the 0.9.x releases? Or the v1.0 beta ones?

@netshade I've just pushed up a (0.9.x) branch called  server-only-listeners that has (I hope!) the correct logic in it now.
With the version number test there was no need to additionally test for the presence of Rails.application.server - the block will only be run if it's in a server context anyway.
Whenever you have a chance if you could give it another test with this branch and let me know how you get on it would be much appreciated.
Obviously the fallback for older rails versions is still far from perfect but it's still better than the way it is currently.

We were using the 0.9.x release series - specifically 0.9.3. And I just tested on your server-only-listeners branch for us and that works great, thank you for the quick response and your maintainership on this. And yeah, I definitely agree with your take on the older Rails version issue - locally I had put a hack into place that essentially set a global variable in our config.ru such that I was guaranteed that it would be only set from within a server context, and then I set config.lookbook.listen to true or false based on the presence of that variable. If someone else runs into this on an older Rails version, they could likely take that approach as a way to handle it in their use case.
Thanks very much for your work and maintainership on this, you're awesome.

Ok that is great, thanks for testing it so quickly, I'll get a new release out now. And thank you for the kind words - totally made my day ☺
The config.ru variable hack sounds like a great workaround for people if they need it, nice one. I think I'll actually try to get that added to a 'troubleshooting' section in the docs as soon as I have a chance.
Very much appreciate your help and just let me know if there is ever anything else I can help with.


Feature: Regex support in --secret-type flag

New Feature Request:
We use x509 extensively in our production to monitor the certs. Recently during onboarding one of our internal customer, we realized that it is a hassle to keep adding the flag --secret-type for every custom key of the secret where the value is certificate we want to monitor.
It will be very helpful if we have regex support like below
--secret-type=Opaque:.*.crt --secret-type=Opaque:.*.pem
If x509 exporter has to scan all of the cluster secrets and if we have too many customizations in the secret keys it becomes unmanageable

https://github.com/enix/x509-certificate-exporter/pull/243


Change Float encoding

This PR introduce a new way of encoding Floats in mlir-tv.
Float is encoded as BitVector[3+VALUE_BITS].

The MSB represents the sign (0: positive, 1: negative)
The following two bits represent type of the value (00: Finite value, 01: Inf, 10: NaN)
VALUE_BITS is equal to FP_BITS before this PR.

Rebase please~


UnrealEngine4

I heard that unreal engine is not supported by github. I have tried to install it on ubuntu, but get error that, "repoository doesn't exists anymore!"
Now to, solve this follow these steps:

Join to the unreal engine community on gitbub. Now you might wonder where to join the unrealEngine community -- First of all make you epic games account and then when you have log into your account of epic games, Click on your ID and go to "My Profile". After this go to the "connections", (this is the main step) Here connect with your github account and wait for 2-3 hrs. After 2-3 hrs, go to the "https://github.com/EpicGames"
If you find any invitation of joining the UnrealEngine community at the top, then you will able to find the "UnrealEngine" repository and if not then wait for 1 day, after 1 day you will definitely find the invitation link


JWT verifier: do not return 404 error on not found identity

Hi there,
I think that the verifier should not return the error on 404 finding a missing identity. The use case:

get a valid token with a valid user
get a request for an endpoint with this token -> ok
delete the user
make a new request with the same token -> 404

I think that the verifier should return 401 with Unknown user.
It is a wrong though?
All the best!

If that is the desired behaviour for your application you can customize the JWT verifier.

Yes of course I customized the verifier. My thought was only on what was the best error message for the use case: maybe they are both correct.
Thank you for your awesome framework!


Fix method for finding a table's primary key

Previously this method did not work and was not tested.
This implementation is also simpler and takes advantage of the fact that a table can only ever have one primary key.
Planning on using this method to determine if all tables have a primary key of "id" in a follow up.
@Fryguy @matthewd please review.

I think I'd rather use https://github.com/rails/rails/blob/c7d3bd48dff0a509f5c21ec8864cb4f774d604e6/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb#L409, despite it being private, to answer the simpler question.
As for this method in its current use case... it really seems a fair stretch outside our purview to be needing to care about PK indexes, especially. As long as we're going to have it, specs do seem like a good idea. :smile:
I'm a bit torn on the simplified query vs having a direct copy of https://github.com/rails/rails/blob/c7d3bd48dff0a509f5c21ec8864cb4f774d604e6/activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb#L171 (except the indisprimary condition), which I assume is how the previous version started life.

Agreed, #primary_keys seems like a better way to go, also I don't think that particular method is private so it should work nicely.
For this PR, I'll set WIP and do some more looking into what exactly we are using this information for now that it isn't blocking my other work.
@miq-bot add_label wip

Just got to revisiting this. It seems like this is preventing pk indexes from showing up in the database inspection view (Configuration -> Database -> table). I'll post some screenshots to show the issue.

Before (primary keys missing):

After (with primary keys):

@miq-bot rm_label wip

Ah right, no bot today. Thanks @chessbyte

@Fryguy @gtanzillo I think this is (finally) ready to go.

👍 Looks good!


Access recaptcha through reverse proxy

Following discussion below, we have setup Apache reverse proxy for accessing Google recaptcha for serving China user access purpose:
https://github.com/google/recaptcha/issues/87
However we found that for all recaptcha traffic going through reverse proxy, it always require input recaptcha by selecting image even we have set the Security Preference to the lowest value. (with direct access recaptcha service, we just need to click the checkbox "I am not a robot"
It seems that all request going through reverse proxy are under high risk and require additional verification. Any one have idea to overcome this?
Thanks.

Reliability of results and user experience if you're going through a proxy is really out of scope for this repo. I've updated the code to allow for setting of an explicit URL and I'm happy to take PRs that add RequestMethods for better working within a proxy.


help text on search pages

Some users would likely benefit from having a short introduction text/tutorial to the search interface.
Especially given that it is such a central part of our site.
On the existing site we get feedback from users that reports errors, when in fact it is a misunderstanding.
The cost depends on the ambition. it could be as simple as a text. A video. To an interactive tour.

Add help text to basisOfRecord filter
from Jira and kbraak
The difference between observation, machine observation, and human observation isn't obvious.
It's sensible to expect human and machine observations to be returned in a filtered search by the generic 'observation' filter.
Users need help text / context help to search properly. They shouldn't have to deduce the meaning of these filters themselves.


Time is slower than date output

I use the libuv's time function. But as the program runs, the time is much slower than the date output. I have test the clock_gettime function, it's also slower.

It's completely unclear to me what you mean.  Can you post a test case and/or expected vs. actual output?

actual output:
date
Tue May 16 10:00:02 CST 2017
./myprogram
Tue May 16 10:00:03 CST 2017
Tue May 16 10:00:04 CST 2017
... a long time ...
Tue May 17 8:00:50 CST 2017
date
Tue May 17 9:00:50 CST 2017
expected output:
date
Tue May 16 10:00:02 CST 2017
./myprogram
Tue May 16 10:00:03 CST 2017
Tue May 16 10:00:04 CST 2017
... a long time ...
Tue May 17 9:00:50 CST 2017
date
Tue May 17 9:00:50 CST 2017

You probably have a bug in your timestamp-to-date conversion but that is not a libuv issue.

No follow-up, closing.


Rage of Mages 2 (Allods2)

Game works so far, but you can't click "Ok" in dialogs. (You have to press Esc as a workaround)
The game also has the problem that the scrolling speed in the game is too fast, which is a general problem of the game. What with "maxgameticks" can make more enjoyable, but also is not the solution, because it affects not only the speed of scrolling.

cnc-ddraw log
rom2_log.zip


Please add column "Can use with UDR?"

Could you please add column for UDR? (like "Can use with Azure Firewall?")
It seems that following Tags can't use with UDR now.

AzurePlatformDNS
AzurePlatformMDS
AzurePlatformLKM
Internet
VirtualNetwork
AzureLoadBalancer

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08217244-82bb-13b5-46f7-454801d8f865
Version Independent ID: 4a8b0a32-bf57-7544-c60d-6b7f250c4477
Content: Azure service tags overview
Content Source: articles/virtual-network/service-tags-overview.md
Service: virtual-network
GitHub Login: @allegradomel
Microsoft Alias: mbender

@ShuheiUda , thank you for your feedback. We have assigned this to the content owner/author for review.
@allegradomel , could you please review the suggestion and provide your inputs?

#reassign-reviewer: @mbender-ms

For service tags using NSGs, UDRs can be used as well.
Reviewing doc to clarify messaging and intent of UDR usage.
#Please-close


When BSSID changes but SSID stays the same, mondevtopromisc should switch to the new BSSID

Now when the PSP goes to sleep, or when someone starts rehosting it often requires a complete restart of the program.

Done in feature branch


Add Privacy Policy, FAQs and Contributor's guidelines.

Hello, I'm Harry. I engage in creating documents for open source projects. It's part of my contribution to helping open source projects. One of the documents I engage in creating is a privacy policy. The privacy policy will give details about user information collection, use and security. I really don't know if you externally collect user information, but, if you don't, it's good to let end users know via a privacy policy.
Contributor's guidelines is also an important document that will help prospective collaborators contribute easily to your project.
I'll love to hear your thoughts on this.

Hello, I am still a student at school and a start-up developer. The documentation for the privacy policy is not known, and the current focus is on fixing bugs and adding new features.
I would be very grateful to those who contributed, including the issue.

Oh okay. So I could go ahead and send PRs?

Oh okay. So I could go ahead and send PRs?

sure

Great! I'll send PRs for the privacy policy and contributor's guidelines very soon. For the FAQs, I can compile something before the end of today though. Thanks for letting me contribute.


git-lfs: 3.3.0 -> 3.4.0

Diff: https://github.com/git-lfs/git-lfs/compare/v3.3.0...v3.4.0
Changelog: https://github.com/git-lfs/git-lfs/raw/v3.4.0/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 245621 run on x86_64-linux 1

34 packages built:

bundix
cabal2nix
crate2nix
crystal2nix
dep2nix
git-lfs
github-backup
github-backup.dist
go2nix
go2nix.man
haskellPackages.cabal2nix-unstable
haskellPackages.nvfetcher
haskellPackages.nvfetcher.doc
haskellPackages.update-nix-fetchgit
haskellPackages.update-nix-fetchgit.doc
lua51Packages.luarocks-nix
luarocks-nix (luaPackages.luarocks-nix)
lua53Packages.luarocks-nix
lua54Packages.luarocks-nix
luajitPackages.luarocks-nix
nix-prefetch-git
nix-prefetch-scripts
nix-update
nix-update-source
nix-update-source.dist
nix-update.dist
npins
nvfetcher
prefetch-yarn-deps
sparkleshare
swiftpm2nix
update-nix-fetchgit
update-python-libraries
yarn2nix


[!] Error installing ZXingObjC with pod

Installing ZXingObjC (3.1.0)
[!] Error installing ZXingObjC
[!] /usr/bin/git clone https://github.com/TheLevelUp/ZXingObjC.git /var/folders/x2/270gwz7938g38n5x45c7rdjw0000gn/T/d20160831-69461-13vwg4c --template= --single-branch --depth 1 --branch 3.1.0
Cloning into '/var/folders/x2/270gwz7938g38n5x45c7rdjw0000gn/T/d20160831-69461-13vwg4c'...
error: RPC failed; curl 56 SSLRead() return error -9845
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed

Check, the problem was Github related. Should work for now.


asset not clickable

In the old version, when an asset was clicked it would open to that asset, now that's no longer the case

Following user requests, we updated the default click action. The balance click switches the asset displayed in the balance change history below.


Update /user/ view to accept an api token.

Coverage decreased (-0.6%) to 96.552% when pulling 80e20c02e32c1ae1cd9abea98d3cdc590d8d8868 on arlyon:add-token into a3057b7aa1963da834ffc33edaf188b0e0e4556d on Tivix:master.


Fibonacci Series Test In Go

Fixes #
Changes proposed in this PR:

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #36   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      2    +1
  Lines           2     14   +12
=====================================
+ Hits            2     14   +12

Impacted Files
Coverage Δ

01_fib/fibonacci.go
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8055b5...171ca52. Read the comment docs.

Please update PR description.

@juliaogris It looks like @paraganz merge to master is causing problems.
Updating a branch from master now brings in files with main and fib already defined. This either causes conflicts if the files have the same name, or compile errors if the files have different names.

Fill in the PR description template.

Click Update branch and locally git pull origin lab1 before adding new commits.
Please fix broken build.

Click Update branch and locally git pull origin lab1 before adding new commits.
Please edit your commits to follow recommendations

Capitalize the subject line
Use the imperative mood in the subject line
Fold fixup commits into previous ones with git rebase -i HASH

Hi,
There has been  no activity in the last 20 days so I will close this PR.
Feel free to open it again if you have something to add.
Thanks!
Julia


Sensitive information in repo

Git is tracking __init__.py, which contains password information for firebase.  This is a security concern.
Git should instead ignore this file, and there should be a __init__.py.sample file that defines what fields are needed.

Closed in pull request #5


Update src20.md

Add optional owner parameter to DEPLOY if issuing on someone else's behalf

perfect and simple :)  will need to add to mints as well.


Question: Is there an easy way to get ShownDates (plural) from the calendar

Requirement:
I'm binding events to data which is fetched from an api - so when month or week view is changed - or I change from week view to month view at runtime, I need to fetch new data based on the range of dates that are shown in the calendar.
so

is there a way to easily determine the date range currently shown on the calendar (or do I have to deduce this from CalendarLayout and ShownDate property?
is listening to the ShownDate property change the best way to detect that the calendar layout or left/right week/month view has changed?

I think perhaps you misunderstand slightly
for example - if I'm viewing the calendar in month view of april, then would be handy to access a property like VisibleStartDate and VisibleEndDate - which would be Apr 1 - Apr 30. ie what are all the dates my user is looking at - so I know I need to fetch data for that date range. This is something different to date selection.
So if there aren't properties like above to know this, I guess one can derive the visible dates from SelectedDate + CalendarLayout properties.
I guess ShownDate property change is also the best way to handle submitting a new query for the dates the user is seeing?
So if the  user does any user action that changes the visible dates (like via any of the commands above) - I need to submit a new query to fetch data for all the dates they can see.

Currently, there is no specific property for that hence if you can achieve results with ShownDate then use it. I will think about how to simplify this with next versions


Feature/hma 5091 android jetpack compose components summary row view

📝 Description
https://jira.tools.tax.service.gov.uk/browse/HMA-5091

[ ] Updated CHANGELOG
[ ] Updated README

📸 Screenshots

Thank you for submitting a pull request on this HMRC repository. A member of the HMRC team will review your changes and action accordingly.
HMRC reviewer: please reference this runbook for guidance on how to proceed.

Thank you for submitting a pull request on this HMRC repository. A member of the HMRC team will review your changes and action accordingly.
HMRC reviewer: please reference this runbook for guidance on how to proceed.


attribute error raised when training on KITTI dataset using MMDetection3D

Thanks for your error report and we appreciate it a lot.
Checklist

I have searched related issues but cannot get the expected help. Yes,I was able to trace the bug,and figure out the cause,and would like your opinion on how to resolve it on my end.

Describe the bug
A clear and concise description of what the bug is.
The following error was raised when working with MMDetection3D.However,since the trace pointed to a specific line in MMDetection.apis.,I thought of bringing it to your notice also.
While training SECOND/Point Pillar on KITTI3D when single_gpu_test.py is executed,an attribute error is raised.Inside the single_gpu_test.py there is a line
 PALETTE = dataset.PALETTE

which is raising the error.
I looked at MMDetection version 2.19 and the specific line which is causing the error is not mentioned .As such ,I would like some help in figuring out which version of MMDet,MMSeg and MMDetection3d should I install,so that the above issue doesn't happen.
I tried training HRNet using MMSeg on ADE and there was no issues,same for SOLO.In both scenarios I used the master branch.
Reproduction

What command or script did you run?

python tools/train.py /content/mmdetection3d/configs/second/hv_second_secfpn_6x8_80e_kitti-3d-3class.py

Did you make any modifications on the code or config? Did you understand what you have modified? No modifications were made in the code,I am just testing it to get an idea of how the training process looks like.Once that's done,then I will customize the configurations.
What dataset did you use? KITTI 3D

Environment
Using colab
Enviroment/system config
sys.platform: linux
Python: 3.7.12 (default, Jan 15 2022, 18:48:18) [GCC 7.5.0]
CUDA available: True
GPU 0: Tesla P100-PCIE-16GB
CUDA_HOME: /usr/local/cuda
NVCC: Build cuda_11.1.TC455_06.29190527_0
GCC: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
PyTorch: 1.10.0+cu111
PyTorch compiling details: PyTorch built with:
  - GCC 7.3
  - C++ Version: 201402
  - Intel(R) Math Kernel Library Version 2020.0.0 Product Build 20191122 for Intel(R) 64 architecture applications
  - Intel(R) MKL-DNN v2.2.3 (Git Hash 7336ca9f055cf1bfa13efb658fe15dc9b41f0740)
  - OpenMP 201511 (a.k.a. OpenMP 4.5)
  - LAPACK is enabled (usually provided by MKL)
  - NNPACK is enabled
  - CPU capability usage: AVX2
  - CUDA Runtime 11.1

  - CuDNN 8.0.5
  - Magma 2.5.2
  -

TorchVision: 0.11.1+cu111
OpenCV: 4.1.2
MMCV: 1.4.5
MMCV Compiler: GCC 7.3
MMCV CUDA Compiler: 11.1
MMDetection: 2.21.0
MMSegmentation: 0.21.1
MMDetection3D: 0.18.1+86cc487

Please run python mmdet3d/utils/collect_env.py to collect necessary environment infomation and paste it here.
You may add addition that may be helpful for locating the problem, such as

How you installed PyTorch [e.g., pip, conda, source] No I am using colab

Error traceback
If applicable, paste the error trackback here.
File "tools/train.py", line 235, in <module>
    main()
  File "tools/train.py", line 231, in main
    meta=meta)
  File "/content/mmdetection3d/mmdet3d/apis/train.py", line 35, in train_model
    meta=meta)
  File "/usr/local/lib/python3.7/dist-packages/mmdet/apis/train.py", line 208, in train_detector
    runner.run(data_loaders, cfg.workflow)
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/epoch_based_runner.py", line 127, in run
    epoch_runner(data_loaders[i], **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/epoch_based_runner.py", line 54, in train
    self.call_hook('after_train_epoch')
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/base_runner.py", line 309, in call_hook
    getattr(hook, fn_name)(self)
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/hooks/evaluation.py", line 267, in after_train_epoch
    self._do_evaluate(runner)
  File "/usr/local/lib/python3.7/dist-packages/mmdet/core/evaluation/eval_hooks.py", line 56, in _do_evaluate
    results = single_gpu_test(runner.model, self.dataloader, show=False)
  File "/usr/local/lib/python3.7/dist-packages/mmdet/apis/test.py", line 25, in single_gpu_test
    PALETTE = dataset.PALETTE
  File "/usr/local/lib/python3.7/dist-packages/torch/utils/data/dataset.py", line 83, in __getattr__
    raise AttributeError
AttributeError

**Bug fix**
If you have already identified the reason, you can provide the information here. If you are willing to create a PR to fix it, please also leave a comment here and that would be much appreciated!
I think that I am not installing the correct version of MMDetection,because the master branch includes a term called PALETTE with the dataset but the branch 2.19 doesn't include the pallete term.
The problem is that when I install MMDetection via pip,it seems that pip ends up installing the master branch which causes an error when I run the training script on KITTI 3D.

Related bug: https://github.com/open-mmlab/mmdetection/pull/7085
Issue in MMDetection3D: https://github.com/open-mmlab/mmdetection3d/issues/1259

Yes I was the one who raised,I was able to resolve it using a different version of MMdet 2.19

Please keep this issue open while the latest version has the bug.