mxnet-cu90mkl does not work on g2.8xlarge instance

Description
got core dump when import mxnet(mxnet-cu90mkl) in g2.8xlarge instance.
Environment info (Required)
----------Python Info----------
('Version      :', '2.7.15')
('Compiler     :', 'GCC 7.2.0')
('Build        :', ('default', 'May  1 2018 23:32:55'))
('Arch         :', ('64bit', ''))
------------Pip Info-----------
('Version      :', '10.0.1')
('Directory    :', '/home/ec2-user/anaconda3/envs/mxnet_p27/lib/python2.7/site-packages/pip')
----------MXNet Info-----------
Illegal instruction
Note:
Below hardware info are getting from mxnet1.3.0post0, as mxnet-cu90mkl will stop when testing MXNet.
----------System Info----------
('Platform     :', 'Linux-4.14.72-68.55.amzn1.x86_64-x86_64-with-glibc2.2.5')
('system       :', 'Linux')
('node         :', 'ip-172-31-23-121')
('release      :', '4.14.72-68.55.amzn1.x86_64')
('version      :', '#1 SMP Fri Sep 28 21:14:54 UTC 2018')
----------Hardware Info----------
('machine      :', 'x86_64')
('processor    :', 'x86_64')
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                32
On-line CPU(s) list:   0-31
Thread(s) per core:    2
Core(s) per socket:    8
Socket(s):             2
NUMA node(s):          2
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 45
Model name:            Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz
Stepping:              7
CPU MHz:               2599.851
BogoMIPS:              5270.04
Hypervisor vendor:     Xen
Virtualization type:   full
L1d cache:             32K
L1i cache:             32K
L2 cache:              256K
L3 cache:              20480K
NUMA node0 CPU(s):     0-15
NUMA node1 CPU(s):     16-31
Package used (Python/R/Scala/Julia):
Python
Error Message:
Illegal instruction
Minimum reproducible example
python
import mxnet
Steps to reproduce
(Paste the commands you ran that produced the error.)

What have you tried to solve it?
Install mxnet1.3.0post0 it works, but mxnet-cu90mkl does not work at all.

@mxnet-label-bot [Build, Installation, Breaking]

Did you compile MXNet from source? It looks like you're using a published version of MXNet that was compiled for a CPU (?) instruction set that's not supported by the CPU in a G2 instance (aka, the CPU is too old).
This should be resolved if you compile from source. Could you give that a shot please?

@mirocody Was this issue resolved for you ?

Can you post the stack trace?  Did it give an 'image not found' cuda error?

Agree with Marco, looks like the error is related to AVX vector instructions being used that aren't available on the E5-2670.

@mirocody bouncing again.
Suggest you check these steps:
(1) Try with non-mkl version.
(2) if it still fails, try building from source.

Thanks for the response. I will give a try to compile from source, but just want to make sure here: is there any plan to fix the pip package, so it can work on g2? We need to know this so we can discuss our plan for dlami.

Thanks for the response. I will give a try to compile from source, but just want to make sure here: is there any plan to fix the pip package, so it can work on g2? We need to know this so we can discuss our plan for dlami.

Thanks for the response. I will give a try to compile from source, but just want to make sure here: is there any plan to fix the pip package, so it can work on g2? We need to know this so we can discuss our plan for dlami.

Thanks @marcoabreu @KellenSunderland @lupesko for your suggestions.
Update:
After trying different versions of packages, got following observations:

both cu90-mkl and cu90 versions wok on E5-2650
Both cu90-mkl and cu90 versions failed on E5-2670

Currently we do not have plan to build from source for g2(which has both e5 2670 and 2650 cpu) specifically. We need find a way that make it work on e5-2670 too.

@mirocody This problem has been fixed in the latest release 1.3.1 (to be released)
You may verify using pip install mxnet-cu90mkl --pre

Verified, thanks. I close this issue.


Add support for writing host keys to guest attributes.

I don't think this is quite ready to merge yet. I would like to improve the unittests a bit.


DaVinci LGGO DCTL doesn't compile

Hey Thatcher,
The DaVinci LGGO DCTL doesn't have any effect when I drag the slider. It seems relates to the function sample_color, I remove this function and it compiles.
The error log (intercepted from davinci_resolve.log file) is attached. It's running on an Apple silicon Mac.

Hey thanks for reporting that bug, I've removed that function from that tool and it should work fine now. Thanks!


Because filtering is not strict input

Because filtering is not strict input:[xss](javascript:alert1;) Causes XSS vulnerabilities

aaaa

payload:javascript:alert(1);


Fearure for #2531 - for jindofsx runtime

Signed-off-by: niwang<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

fixes https://github.com/fluid-cloudnative/fluid/issues/2531
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

/test fluid-e2e

/test fluid-e2e

/lgtm
/approve


ERFNet_pretrained.tar issue

I tried to run the train_erfnet.sh in ERFNet-CULane-PyTorch. But the following error appeared:
=> loading checkpoint './pretrained/ERFNet_pretrained.tar'
#reused param: 302
=> loaded checkpoint 'False' (epoch 16)
Traceback (most recent call last):
File "train_erfnet.py", line 291, in
main()
File "train_erfnet.py", line 103, in main
validate(val_loader, model, criterion, 0, evaluator)
File "train_erfnet.py", line 194, in validate
for i, (input, target, target_exist) in enumerate(val_loader):
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 345, in next
data = self._next_data()
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 856, in _next_data
return self._process_data(data)
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 881, in _process_data
data.reraise()
File "/usr/local/lib/python3.6/dist-packages/torch/_utils.py", line 394, in reraise
raise self.exc_type(msg)
AttributeError: Caught AttributeError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/worker.py", line 178, in _worker_loop
data = fetcher.fetch(index)
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/content/gdrive/My Drive/lane_detection/SAD/sad/ERFNet-CULane-PyTorch/dataset/voc_aug.py", line 31, in getitem
image = cv2.imread(os.path.join(self.img_path, self.img_list[idx])).astype(np.float32)
AttributeError: 'NoneType' object has no attribute 'astype'
Any suggestions? Thank you.

After updating the list address in voc_aug.py, the error becomes:
=> loading checkpoint './pretrained/ERFNet_pretrained.tar'
#reused param: 302
=> loaded checkpoint 'False' (epoch 16)
Traceback (most recent call last):
File "train_erfnet.py", line 291, in
main()
File "train_erfnet.py", line 103, in main
validate(val_loader, model, criterion, 0, evaluator)
File "train_erfnet.py", line 194, in validate
for i, (input, target, target_exist) in enumerate(val_loader):
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 345, in next
data = self._next_data()
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 856, in _next_data
return self._process_data(data)
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 881, in _process_data
data.reraise()
File "/usr/local/lib/python3.6/dist-packages/torch/_utils.py", line 394, in reraise
raise self.exc_type(msg)
RuntimeError: Caught RuntimeError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/worker.py", line 178, in _worker_loop
data = fetcher.fetch(index)
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/fetch.py", line 47, in fetch
return self.collate_fn(data)
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/collate.py", line 79, in default_collate
return [default_collate(samples) for samples in transposed]
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/collate.py", line 79, in
return [default_collate(samples) for samples in transposed]
File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/collate.py", line 55, in default_collate
return torch.stack(batch, 0, out=out)
RuntimeError: invalid argument 0: Sizes of tensors must match except in dimension 0. Got 763 and 785 in dimension 3 at /pytorch/aten/src/TH/generic/THTensor.cpp:612


get tests working again mostly

This still isn't building correctly.  I copied over what we are doing in https://github.com/tinystacks/ops-core-widgets locally and the build output was correct but then many of the tests either failed or didn't run.

Reviewed, this looks good to go! Merging up, we'll go ahead and merge other PRs down into main once that's done


Adding new cuts for the imaging - Scatter test and angle / Expanding …

…imaging for the positronium imaging / Formatting and binning changes

Added angle criterion and scatter test as I use for the analysis of the data from the 3-layer prototype. Changed in stream2Gamma and stream3Gamma the methods for the calculations of the angles between the hits to the quicker and simpler version. I have added one new command, that can be used regarding setting the scatterTest cut-off.
Left creating histograms to the old version -> probably this part need to be updated in modular version
Formatting of the code is not as it is now in framework (clang), so I left it as it was, with some small changes to compress a little the code
Added the streaming for the positronium imaging as it can be in near future used for the modular detector -> userParams.json should be updated with the new commands used for the positronium imaging data selection

Question: Because there is stream3Gamma without any code for the position reconstruction for 3G, should I add the code that I used in my analysis? Or it is not necessary yet? I would need to optimize it and I do not know if someone would use it for the modular analysis.

@kdulski Thank you.  I guess it 3Gamma  is not needed now


license?

what license do you prefer?

see https://github.com/brewster/vcardigan/blob/master/vcardigan.gemspec ... s.license = 'MIT'


Improved tailscale healthcheck

Improvment To Tailscale Healthcheck
Summary
This change provides a more robust and accurate way to monitor the health of the tailscale service, improving the reliability and observability of the deployment.
This pull request updates the healthcheck configuration to use:
healthcheck:
  test: ["CMD", "wget", "--spider", "-q", "http://<IP_ADDRESS>:8080/healthz"]

instead of:
healthcheck:
  test: ["CMD", "tailscale", "status"]

Reasons for the Change

Checking 'tailscale status' only verifies that the Tailscale daemon is running, not that the service is functioning correctly or that the service is reachable or working as expected.

The new healthcheck ensures that the application or service behind Tailscale is reachable by probing a specific health endpoint (e.g., /healthz), providing a more meaningful validation of the system's operational state.

The new method makes use of the HTTP health endpoint that is explicitly designed to signal service health. This endpoint returns 200 OK if the node has at least one Tailnet IP address assigned, otherwise, it returns 503. This provides a direct indication of the node's connectivity to the Tailnet.

Hello, should you choose to accept this PR for the Pi-Hole service, I'd be happy to make subsequent updates to the other services in this repo too.

For reference: https://tailscale.com/kb/1282/docker#ts_healthcheck_addr_port / This functionality is available in Tailscale 1.78 and later.

Hello, Should you choose to accept this PR for the Pi-Hole service, I'd be happy to make subsequent updates to the other services in this repo too. Thanks, Adam

Thanks for the PR. Please check comments/suggestions and subsequent update the other services, thanks!

This is recently deprecated:
TS_HEALTHCHECK_ADDR_PORT
From v1.78, use instead: TS_ENABLE_HEALTH_CHECK
TS_LOCAL_ADDR_PORT
As the services in this repo are using the 'latest' tailscale image tag, it's best to make use the new method.
See here for reference:
https://tailscale.com/kb/1282/docker#ts_healthcheck_addr_port
Thanks

This is recently deprecated: TS_HEALTHCHECK_ADDR_PORT
From v1.78, use instead: TS_ENABLE_HEALTH_CHECK TS_LOCAL_ADDR_PORT
As the services in this repo are using the 'latest' tailscale image tag, it's best to make use the new method. (At the time of writing, 'latest' is v1.78.3).
See here for reference: https://tailscale.com/kb/1282/docker#ts_healthcheck_addr_port
Thanks

Looks good! If you could update the rest of the services, please 🚀

This is recently deprecated: TS_HEALTHCHECK_ADDR_PORT
From v1.78, use instead: TS_ENABLE_HEALTH_CHECK TS_LOCAL_ADDR_PORT
As the services in this repo are using the 'latest' tailscale image tag, it's best to make use the new method. (At the time of writing, 'latest' is v1.78.3).
See here for reference: https://tailscale.com/kb/1282/docker#ts_healthcheck_addr_port
Thanks

Looks good! If you could update the rest of the services, please 🚀

All done :)


remove junk highway=minor and highway=footpath

highway=minor and highway=footpath aren't valid data, and there are less than 100 of them world wide, says TagInfo. Let's remove them from all the places.

Connects to: https://github.com/mapzen/vector-datasource/pull/681


Gradle project sync failed when running the demo on Android Studio 3

I run the example on Android Studio 3.0, so it requires me to upgrade gradle version from 2.14.1 to 4.1.
After upgrading, the IDE show error: Gradle project sync failed
Error:Unable to load class 'org.gradle.api.internal.component.Usage'.
Possible causes for this unexpected error include:Gradle's dependency cache may be corrupt (this sometimes occurs after a network connection timeout.)
Re-download dependencies and sync project (requires network)The state of a Gradle build process (daemon) may be corrupt. Stopping all Gradle daemons may solve this problem.
Stop Gradle build processes (requires restart)Your project may be using a third-party plugin which is not compatible with the other plugins in the project or the version of Gradle requested by the project.In the case of corrupt Gradle processes, you can also try closing the IDE and then killing all Java processes.
How can i fix it?

This problem occurs because the gradle version 4.1 is not compatible with the plugin 'com.novoda:bintray-release:0.3.4',after i upgrade it to 0.5.0, it works.


Mironathome issue 2027 fix ( branch PG15 )

Fix issue #2027
get_graph_oid function declaration return type uint32 definition Oid
Make both return Oid

@MironAtHome Please see PR #2038


Fixes 2668: use newer yummy

Summary
to limit the size of an xml file we can process
Testing steps
Try to introspect a repo: https://raw.githubusercontent.com/lpardoRH/custom-repo/zip_bomb2/
You will likely run out of memory in ephemeral (maybe locally).  With this fix it will simply return zero packages (as its not really an xml file).   Right now this does not trigger an error which is a result of underlying libraries.  Since this edge case is an attempted attack and not a legitimate case, this is okay.  A partial (or corrupted) XML file would error as expected

https://issues.redhat.com/browse/HMS-2668

lgtm


BTree, kruskal for directed graphs

Codecov Report

Merging #35 into Development will increase coverage by 0.54%.
The diff coverage is 98.84%.

@@               Coverage Diff               @@
##           Development      #35      +/-   ##
===============================================
+ Coverage        97.44%   97.98%   +0.54%
===============================================
  Files               28       31       +3
  Lines             2074     2534     +460
===============================================
+ Hits              2021     2483     +462
+ Misses              53       51       -2

Impacted Files
Coverage Δ

Tests/TreeTests.swift
99.41% <100%> (+0.26%)
:arrow_up:

Sources/SinglyLinkedList.swift
100% <100%> (ø)
:arrow_up:

Sources/Graph_Algorithms.swift
93.96% <100%> (+0.81%)
:arrow_up:

Sources/DoublyLinkedList.swift
100% <100%> (ø)
:arrow_up:

Sources/Graph_Pathfinding.swift
100% <100%> (ø)

Sources/B-Tree.swift
97.45% <97.45%> (ø)

Sources/Graph_Traversal.swift
97.5% <97.5%> (ø)

Tests/GraphTests.swift
99.62% <99.08%> (-0.38%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358d994...eb23532. Read the comment docs.


Unable to compile modules after update

After updating build commands that previously worked are failing now.
python unet.py --hf-hub-or-path "runwayml/stable-diffusion-v1-5" --width 512 512 --height 512 512 --batch-size 2 2 --clip-chunks 1 --model-name "v1_unet_512_512_2_2_c1_test" --work-dir "/home/primary/Documents/code/ML/AIT/modules"

2023-09-09 14:08:36,292 INFO <aitemplate.compiler.compiler> compiled the final .so file elapsed time: 0:03:22.475189
[14:08:36] model_container.cu:69: Device Runtime Version: 11080; Driver Version: 12010
[14:08:36] model_container.cu:83: Hardware accelerator device properties:
  Device:
     ASCII string identifying device: NVIDIA GeForce RTX 4090
     Major compute capability: 8
     Minor compute capability: 9
     UUID: GPU-3caeb811-53d4-7669-01dc-ca502ea01048
     Unique identifier for a group of devices on the same multi-GPU board: 0
     PCI bus ID of the device: 12
     PCI device ID of the device: 0
     PCI domain ID of the device: 0
  Memory limits:
     Constant memory available on device in bytes: 65536
     Global memory available on device in bytes:<PHONE_NUMBER>6
     Size of L2 cache in bytes: 75497472
     Shared memory available per block in bytes: 49152
     Shared memory available per multiprocessor in bytes: 102400
[14:08:36] model_container.cu:87: Init AITemplate Runtime with 1 concurrency
Traceback (most recent call last):
  File "/home/primary/Documents/code/ML/AIT/AITemplate/unet.py", line 141, in <module>
    compile_diffusers()
  File "/home/primary/mambaforge/envs/AITemplate/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/primary/mambaforge/envs/AITemplate/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/home/primary/mambaforge/envs/AITemplate/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/primary/mambaforge/envs/AITemplate/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/primary/Documents/code/ML/AIT/AITemplate/unet.py", line 104, in compile_diffusers
    compile_unet(
  File "/home/primary/Documents/code/ML/AIT/AITemplate/ait/compile/unet.py", line 305, in compile_unet
    vram = round(total_usage / 1024 / 1024)
                 ~~~~~~~~~~~~^~~~~~
TypeError: unsupported operand type(s) for /: 'Model' and 'int'

The PR references https://github.com/hlky/AITemplate/releases/tag/0.3.33, but their account and repos seem to just be gone

I luckily found a cached copy of the repo locally, though this issue is still present as the code is not available online.


docs: update Hibernate sample to Hibernate 6.2

Updates the Hibernate sample to use the most recent Hibernate version. This is more relevant, as new users as more likely to use a recent version of Hibernate than an old 5.x version that is no longer supported.

The lower code coverage is a false positive. It is caused by the fact that I recently restricted the number of integration tests that are running for pull requests, in order to keep the test time for PRs within reasonable limits. All integration tests are still executed on nightly builds.


Missing File::Info data.

Crystal::System::FileInfo is missing public accessors.  I'd like to create a PR to expose some or all of the information below.
Most of the data is cross platform with some exceptions.  The list is not exhaustive.

Name
Platforms
Notes

atime
POSIX, Windows

ctime
POSIX, Windows

birth_time
Dragonfly, FreeBSD, Linux, MacOS, Windows

ino
POSIX, Windows*

dev
POSIX, ?
Is the volume serial number on Windows equivalent?

nlink
POSIX, Windows

blocks
POSIX
Not technically required in the spec but implemented almost universally.

blksize
POSIX
Not technically required in the spec but implemented almost universally.

flags
Linux, *BSD, MacOS, ?

Suggested names:

access_time or last_access_time.
creation_time or birth_time.
change_time or metadata_change_time.
link_count.
io_block_size.
flags is used by something else.  I don't know what to call it.

Currently I need ctime, birth_time, ino, dev, nlink, flags.  I assume others may want the full stat structure when more non web applications are written.

What are your use cases?

Detecting hard links needs[ino, dev, nlink] and birth_timeideally. ctimeas a fallback but I also needctime` when displaying file info..
Also getting or setting flags like APPEND.

We specifically didn't expose ino and dev because we have same_file? which compares ino and dev, but doesn't expose these platform-specific details.
Exposing the number of links would be fine.
Exposing more times is interesting: many filesystems don't support the birth time, and there's discrepancies between windows and linux on ctime and atime, iirc. Go supports only modification time for this same reason.

There is also st_size missing, to get the disk size.

A platform specific API should exist for this kind of non-portable, low-level operations, like Rust std::os::unix, and Go unix package.
It may be kind of already present with src/crystal/system/unix and src/crystal/system/win32, but this files aren't meant to be used as-is.

Stat flags are already exposed.

No they aren't.  Crystal split mode in to permissions and suid/sugid/sticky calling it flags.
I need what BSD systems refer to as flags or Linux as attributes (not to be confused with extended attributes).  On BSD it's part of the stat structure in st_flags.  On Linux it's available through one of the stat interfaces, but I don't remember how exactly.
https://en.wikipedia.org/wiki/Chattr

We specifically didn't expose ino and dev because we have same_file? which compares ino and dev, but doesn't expose these platform-specific details.

My laptop has 3 million files.  How do I find the hard links?  I can't keep 3 million files open.  Comparing every file against every file is unacceptably slow so that won't work either.  I also can't compare incrementally or between program runs by saving state.  So no this doesn't work for my use cases at all.  I've mentioned what I for porting one ruby program.
What is the solution?  Either I make my own shard which monkey patches or duplicates the stat structure already available in src/crystal/system/unix and src/crystal/system/win32 or crystal exposes thing like atime/ctime/birth_time which may vary in their use between platforms.
mtime can vary.  I've encountered NFS systems that return epoch mtime/ctime/atime for every file. Every reported time in the structure including mtime is not just platform specific but file system specific.  Especially so when using network file systems.
I can handle the differences and expect to.  On systems supporting birth time I use birth time (which includes Windows).  Otherwise fall back to POSIX ctime and nlinks.  Both solutions need dev and ino.
Additional use cases that I need dev and ino for:

Detecting when crossing a mount point and running user defined triggers.
Comparing [dev, ino] with [birth_time, ctime, nlink] and between program runs.

Additional use cases:

Getting and setting flags similar to chflags/chattr.

Most of the flags could be handled by an enum.  The ones I need are mostly portable like immutable and append.  Linux version flag is an outlier with additional data. I have no need for it.
So how do I make this work in crystal considering when everything except birth_time is available in ruby and working for ~12 years?

Note that Go has a non-portable direct access to the stat struct through FileInfo Sys().

Yeah, this is the solution I prefer too - just expose a stat struct with a info.platform_specific.foo.

No they aren't. Crystal split mode in to permissions and suid/sugid/sticky calling it flags.

My bad. Looks like this needs statx though. Just like birth_time. I don't think we should bind statx, or use statx by default on linux. A statx binding should be a shard, since the difference is only visible on the platfom-specific members.

My laptop has 3 million files. How do I find the hard links?

Thanks for the usecase! I agree, indexing hardlinks is impossible with same_file?. We should expose the platform-specific members.

Yeah, this is the solution I prefer too - just expose a stat struct with a info.platform_specific.foo.

So make info.stat public and document it's platform specific?  That would solve almost every use case.

What about File::Info#raw? It would return @stat on UNIX and @file_attributes on Windows.

I prefer platform_specific - but I'd rather ensure everyone agrees with this approach (:+1: / :-1: this comment) before bikeshedding on that.

No platform specific data, please. A Crystal program should compile and run exactly the same on all platforms. Or, said another way, the API should be exactly the same for all platforms. But it's fine if a method raises on one platform but works on another, given that it's documented to only work on certain platforms.

No platform specific data, please. A Crystal program should compile and run exactly the same on all platforms. Or, said another way, the API should be exactly the same for all platforms. But it's fine if a method raises on one platform but works on another, given that it's documented to only work on certain platforms.

Instead of handling it at compile time:
if stat.responds_to?(:birth_time)
  ...
else
  # ctime handler
end

I have to use exception handling at runtime:
begin
  stat.birth_time
rescue
  # ctime handler
end

@asterite How much overhead does that add when traversing file systems with > 10 million files?  100 million?  They won't use spinning rust so seek times are not as much of a concern.
But it's not one exception handler.  It's several.  One for flags, another for acl's, another for resource forks, another for extended attributes plus anything I missed.
I'd much rather use feature checks than exception handling.  To me the code is clearer.  I know it's a platform feature check and only runs on specific platforms. With the exception handler am I handling an os error or the platform unsupported?  It's even less clear when trying to understand someone else's code.  What did they intend?

How much overhead does that add when traversing file systems with > 10 million files? 100 million?

Exception handling doesn't add overhead unless an exception is raised (as far as I know).
Additionally, if a method doesn't raise (the compiler knows which methods raise), and methods you want to use in an OS and they are available won't raise, then the compiler will skip the entire exception handler (or LLVM will do this). So zero overhead, really.

I'd much rather use feature checks than exception handling.

The problem is that if someone forgets to check for a feature flag in a library, nobody can use that library in some OS, even if the library never calls that code (for example if they call it conditionally at runtime). This was discussed in the past.

I'd much rather use feature checks than exception handling.

The problem is that if someone forgets to check for a feature flag in a library, nobody can use that library in some OS, even if the library never calls that code (for example if they call it conditionally at runtime). This was discussed in the past.

@asterite If they forget a rescue nobody can use that library on the different OS.  How is that different?
If anything it's worse.  A clear compile time error is changed in to a maybe run time error.  Do the specs test that part of the code?  If not the program appears to compile and function correctly but raises unhandled exceptions when run in the real world.
In both compile time feature checking and exception:

They need additional code.
They need aditional testing.
The code is nearly identical.  if responds_to? vs rescue

The difference is when the error occurs.  Compile or runtime.  Compile time is more robust.

Additionally, if a method doesn't raise (the compiler knows which methods raise), and methods you want to use in an OS and they are available won't raise, then the compiler will skip the entire exception handler (or LLVM will do this). So zero overhead, really.

@asterite No OS has all the features I'm checking.  That means 2-3 exceptions on average, not zero overhead.

When the methods raise on specific platforms, you can use conditional macro branches:
{% if flag?(:win32) %}
  stat.birth_time
{% else %}
  stat.ctime
{% end %}

This ensures only the non-raising methods are invoked on a platform.
Some of these features however are not even platform-specific but depend on the file system. In that case, the API should provide nilable getters to avoid exception overhead.
if birth_time = stat.birth_time?
  birth_time
elsif ctime = stat.ctime?
  ctime
end

When the methods raise on specific platforms, you can use conditional macro branches:
{% if flag?(:win32) %}
  stat.birth_time
{% else %}
  stat.ctime
{% end %}

This ensures only the non-raising methods are invoked on a platform.

But that's a feature flag!
What's the point of raising an exception?  Without rescue's the code won't run on unsupported platforms.  Exactly the opposite of what @asterite claims the exceptions are for.
You also duplicated code.  Crystal already has to know which platforms are supported or not in order to raise.  Instead of if responds_to every developer needs to figure out which platforms are supported or not and use if flag :platform for  every feature tested.

It would be intersting to know how this is solved in Go, Java and other languages.

@asterite as said above, Go has a platform agnostic interface (FileInfo) with the portable info that works everywhere the same, but also exposes the raw, system specific, info (FileInfo Sys()).
This is IMO an acceptable solution. We have a platform agnostic API that works everywhere for 99% of use cases, but allow the 1% remaining use cases to be implemented.

Rather than do it the java/gofy way, I'd rather ask: "what would @asterite do?"  @asterite had this great idea to take ruby and add nil checking.  Maybe he had the answer.
So I crossed the vast ocean, climbed the highest mountian and slept with the ugliest of mountain goats (it was cold... and lonely).
He wasn't there.
So I used the internet to ask the great sage: "Is a method that may or may not be like a the nil problem you originally solved?  Could you treat it exactly like the compile time nil checking already used?"
stat.ino => Compile error "Not available on all platforms.  Check with .responds_to?"

if stat.respond_to?(:birth_time)
  stat.birth_time
else
  stat.ctime
end

Side note, if you use lambskin they think it's another goat.
And the great sage @asterite squeeked in a booming voice:

My child.
You have come far in your journey and learned much.
You have served our cause with the truest faith.
Therefore I name you blessed and beloved.
The nilable approach suggested by @straight-shoota seems to be a good option: you ask it, but you have to check whether it's really supported. But maybe it depends on the API.

That's not quite what I had i mind but I'll take it.
It'd be nice to have a clear split between platform if's and runtime nil checks.
# baz may return nil
if foo = bar.baz
  ...
end

# baz may not exist depend on platform an OS version.
if foo = bar(.)(.)baz
  ...
end

The operator above is only an example.  Feel free to change it.  I prefer to check if the bar has (.)(.)'s.

I'd like to propose a standard annotation or other method to indicate platform variant behavior.
Advantages:

Documentation can show platform specific behavior in a standardized format.
Shards and applications can use the same annotation.
Code coverage tools can show red flags when missing platform specific handlers.
Code coverage tools can have different coverage settings for platform specific behavior. 95% for normal.  100% for cross platform.
Code coverage tools can turn off extra platform coverage errors when working on the target platform to get the current platform to 100%.
Or maybe just split the coverage % between current and variant platforms.

This should work regardless of whether using nil, responds_to?, or other methods.

It looks like creation time is available on all supported platforms already?


same position for multiple message

When I click on success multiple time, it creates multiple messages and appends it on the bottom of last.
What I want is to replace the first message with the second message.
Can I do that?
Does it have any option for it?
It should replace the old message with the new message in the same position.
Because when I call an APIs if an error occurred it displays all error appended to each other which looks ugly.

@dolce

Hello guys, I need an answer.

Hello @nimatullah.
Do you want the Toast to be displayed only once?

It is only you to use the properties below, remembering what this has in the documentation.
iziToast.show({
    title: 'Hello!',
    id: 'toast',
    toastOnce: true
});

What I mean is that it should not append to the last one. It should replace it. Or perhaps a different approach to solving the problem, the same toast keep appearing and this is bad user experience. I am open to any suggestions.

In above attachment, when I click on save job, it saves the job, after clicking the save button multiple time, it appends it to the last message.

If you do not want it to be opened multiple times then at the moment I advise you to use the toastOnce property as I mentioned above.

If you don't want it to be opened multiple times then at the moment I advise you to use the toastOnce property as I mentioned above.

I've came across the same problem lately.
So i have a site which sends you multiple different notifications over a short period of time ex you klick a button and then you'll get 4 notifications (whenever they are send back by the server):
Startet process 1
Started process 2
Finished process 2
Finished process 1
Currently they are appended like @nimatullah shows in his image is there any way that the following toasts update/replace the existing one instead of appending them?

@dolce is there any way to do something like that?

How would you call this new option?
replaceToast: true
?

@cytec , @nimatullah
How would you call this new option?
toastOnce: false,
replaceToast: false,

or
displayMode: false // or 'once', 'replace'

can also be: 0(false), 1(once), 2(replace)

@dolce im fine with either way.
I guess the first option replaceToast would be a bit more compatible since if i get that correct option 2 would change the api for toastOnce as well?

@dolce wouldn't it be possible to combine those two options? so that both can be true?
not entirely sure if i recall that correctly but toastOnce was the option to wait till the last message was closed before showing the new one? if thats correct and replaceToast just replaces the already placed toast as noted above, setting both to true would be some sort of message queue?
If thats true i guess keeping 2 options would make sense, if not... personally i think both ways would fit and you should use the one you think fits best.

iziToast v1.3.1.zip
Could you test?
displayMode: false // 'once', 'replace'

displayMode: 0 // 1, 2

seems to work as it should 👍

v1.4.0 released.
https://www.npmjs.com/package/izitoast


Salsa IV and KEY

those two variables have some problem that they cannot be strings

Fixed by https://github.com/AChep/15puzzle/commit/e015e4e514187c2c2f64648c7c48d61e20f9480e


Some kind of showDelay option would be nice #59

#59

oh, I found that delay was misspelled

oh, I found that delay was misspelled

How does it work?

How does it work?

The design pattern "dependency inversion".When displaying, create a Promise with a delay, and resolve the Promise when it is closed, so that it can be reached. I ran the test and both the component and plugin passed

The design pattern "dependency inversion".When displaying, create a Promise with a delay, and resolve the Promise when it is closed, so that it can be reached. I ran the test and both the component and plugin passed

Too much hacky code, i will find another easy and readable solution


Python 3.5 not supported

HTMLParseError is deprecated from Python 3.3 onwards and removed in Python 3.5, as per the official documentation.

I just pushed a quick fix for that into a new branch py35_fix that should resolve the issue. I'll merge that into master and PyPi when I find time in the next few days.


Gray well organism needs option for 2 columns

Per team discussion during working session 12/11/15:
We want gray wells to be somewhat short so that they don't occupy a lot of height on the page. Allowing two columns within the well would support this design and content goal. We'll want to be able to choose this option within the CMS.
During the working session we discussed modifying the half width link blob so that just the text portion could be used, then two could be placed next to each other within the gray well organism to accommodate this functionality change. @jimmynotjim may be able to explain the proposed solution better.
Also tagging @tnferrell as an FYI since I can't find Laura S.'s handle.

Essentially. We'd split the half width link blob into a parent half width organism, and child link blob molecule. We could then use the half width organism elsewhere and for other molecules, like within the gray well.

Would the Half-Width organism be used in the 50-50-text-image organism?

I think it could.

This sounds good. We'll need a list of molecules to include as "children" of the half width organism.

Low priority as we no longer need this for V1 migration.

Closing, it'll be recreated if a request for this comes up again.


Save and Load Json from DB

I would like to know if we can have the json from this app save to a db and retrieve and load if the page reopened. using a variable in the url to tell what drawing in the db to use.

The app currently does not have any database associated with it, and is just a static site. A database would add some cost for hosting. There could also be concerns with managing the data once it is saved since there are no user accounts. I would have to do some research into if there is a reasonable way to do it.

Thanks Chris, I was just looking at using it on an internal office webpage but needed some way of saving the drawings for future editing, But that's ok I'm looking at other options.


A few users seem to be misconfigured?

Such as long_phan and possibly asa_cooper

To add the relevant details here. Long Phan wasn't showing up correctly under the sacctmgr associations I might've misconfigured him. I think his parent was root?
ASA cooper doesn't show up with PID search unlike other users. Check the GPU stats page while he's running something to see an example.

@steven-basart
Long Phan seems to be configured correctly. When running sudo sacctmgr show assoc, Long Phan appears under the cais account.
I've yet to see Asa Cooper run a job. I'm not sure whether he is still misconfigured.

Closing. Long isn't misconfigured and Asa was off boarded from the cluster.


add-news-entity

As we currently working on the entity for news, i renamed the pull request into add-news-entity in order to be more alligned with what we are working on


[youtube] ytdl doesn't find the higher resolution thumbnail

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.04.26
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

neon@neon-81de:~$ youtube-dl -v --list-thumbnail https://www.youtube.com/watch?v=5Od1VaDL090
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--list-thumbnail', 'https://www.youtube.com/watch?v=5Od1VaDL090']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8
[debug] youtube-dl version 2021.04.26
[debug] Python version 3.8.5 (CPython) - Linux-5.4.0-73-generic-x86_64-with-glibc2.29
[debug] exe versions: ffmpeg 4.2.4, ffprobe 4.2.4, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] 5Od1VaDL090: Downloading webpage
[info] Thumbnails for 5Od1VaDL090:
ID  width  height URL
0   168    94     https://i.ytimg.com/vi/5Od1VaDL090/hqdefault.jpg?sqp=-oaymwEbCKgBEF5IVfKriqkDDggBFQAAiEIYAXABwAEG&rs=AOn4CLBJ8ycGGlLb-0nTAlKNHmB3huZ_-w
1   196    110    https://i.ytimg.com/vi/5Od1VaDL090/hqdefault.jpg?sqp=-oaymwEbCMQBEG5IVfKriqkDDggBFQAAiEIYAXABwAEG&rs=AOn4CLB9MNRm2RlvsAXzYathcn3dPIjz8g
2   246    138    https://i.ytimg.com/vi/5Od1VaDL090/hqdefault.jpg?sqp=-oaymwEcCPYBEIoBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLDirr0181RtM6nBIGlQRMsf2sGzOA
3   336    188    https://i.ytimg.com/vi/5Od1VaDL090/hqdefault.jpg?sqp=-oaymwEcCNACELwBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLBwKvPHn9PwnohyHZcBBPvMUSBkbA

Description

This video has the thumbnail with a higher resolution (1280x720): https://img.youtube.com/vi/5Od1VaDL090/maxresdefault.jpg , but youtube-dl doesn't find its
I used this site https://alexbruni.ru/youtube2images/video.php?v=5Od1VaDL090

Maybe same as #19255


Add license info for python module 'requests'

Add or modify the license header for python module 'requests'

This is taken care by PR #192


Error creating IOS version to upload to Testflight.

Hi, I want to upload a flutter app to apple store but when I go to Xcode and I make: Product -> Archive
After some minutes of Xcode process I get this error:
Could not find an option named "track-widget-creation".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.
Failed to build /Users/{"myUser"}/IdeaProjects/{"myProjectName"}.
Command /bin/sh failed with exit code 255

Here is my flutter doctor -v:
[✓] Flutter (Channel dev, v0.11.3, on Mac OS X 10.14.1 18B75, locale en-AR)
    • Flutter version 0.11.3 at /Users/{"myUser"}/flutter
    • Framework revision 72bf075e8d (2 days ago), 2018-11-09 20:36:17 -0800
    • Engine revision 5646e86a6f
    • Dart version 2.1.0 (build 2.1.0-dev.9.3 9c07fb64c4)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/{"myUser"}/Library/Android/sdk
    • Android NDK at /Users/{"myUser"}/Library/Android/sdk/ndk-bundle
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.2

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 29.0.2
    • Dart plugin version 181.5616
    • Java version OpenJDK Runtime Environment (build
      1.8.0_152-release-1136-b06)

[✓] IntelliJ IDEA Community Edition (version 2018.2.5)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 30.0.2
    • Dart plugin version 182.5124

[✓] Connected device (1 available)
    • {"myUser"} Phone • af7486d829711c96bebd0ccdd8e2d281ebd4825b • ios • iOS 12.0

• No issues found!

Can someone help me?
Thanks!

cc @jacob314

@foosionsapps
In the meantime, you can try and go to Runner -> Build Settings (Tab), scroll down and set "TRACK_WIDGET_CREATION" = false under "User-Defined"
I'm currently trying that approach myself, as I ran into the same issue today.

flutter run --no-track-widget-creation

seems to work as well
https://github.com/flutter/flutter/issues/20260#issuecomment-439157377

I got this Could not find an option named "track-widget-creation" error too when executing
flutter build ios

Here is my flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v0.11.7-pre.47, on Mac OS X 10.14 18A391, locale en-ID)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.2)
[✓] VS Code (version 1.28.2)
[✓] Connected device (3 available)

• No issues found!

I got this Could not find an option named "track-widget-creation" error too when executing
flutter build ios

Here is my flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v0.11.7-pre.47, on Mac OS X 10.14 18A391, locale en-ID)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[✓] Android Studio (version 3.2)
[✓] VS Code (version 1.28.2)
[✓] Connected device (3 available)

• No issues found!

me too.

@foosionsapps
In the meantime (in XCode), you can try and go to Runner (Poject) -> Build Settings (Tab), scroll down and set "TRACK_WIDGET_CREATION" = false under "User-Defined"
I'm currently trying that approach myself, as I ran into the same issue today.

Not works.

Work around
code $FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh

  local track_widget_creation_flag=""
  if [[ -n "$TRACK_WIDGET_CREATION" ]]; then
    # Remove the flag
    # track_widget_creation_flag="--track-widget-creation"
    track_widget_creation_flag=""
  fi

flutter run --no-track-widget-creation

seems to work as well
#20260 (comment)

how to create archive build with it?

Work around
code $FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh

  local track_widget_creation_flag=""
  if [[ -n "$TRACK_WIDGET_CREATION" ]]; then
    # Remove the flag
    # track_widget_creation_flag="--track-widget-creation"
    track_widget_creation_flag=""
  fi

Permission denied

This is a weird one that I have been facing for the past few days since updating Flutter.
For me, the solution is to run "flutter build ios --release" in the project directory, which will fail often times with several pod errors, but I just ignore those and re-archive in Xcode and it works.
I do not know enough about iOS build tools to know why these things fail. Just that before the newest beta branch version "flutter build ios --release" worked, now it fails but doesn't mean anything serious, and despite the flutter documentation, I still have to run this command before archiving in Xcode or I get strange errors like this one.

This helped me a lot! I just got this strange error message out of no where. After releasing my app and updating it about 10 times this error now appears.... Thank you very much @calebisstupid

Would having Xcode 9.3 have any effect on this error. I've tried almost all the steps I could find, but the archive was only built once successfully. Following which, the window to analyze and publish never opened, so I did the process again and back to the start with the same error listed above.

Show stopper for me. I cannot archive iOS to upload to iTunes Connect. "TRACK_WIDGET_CREATION" = false under "User-Defined" does not work. This started when I switched to 1.0 stable. I am not trying to run it but archive it so "flutter run --no-track-widget-creation" doesn't help me.

Show stopper for me. I cannot archive iOS to upload to iTunes Connect. "TRACK_WIDGET_CREATION" = false under "User-Defined" does not work. This started when I switched to 1.0 stable. I am not trying to run it but archive it so "flutter run --no-track-widget-creation" doesn't help me.

wenerme has posted a workaround for it above in this thread to edit the backend.sh, follow the steps and it should work succesfully. Worked in my case.

flutter is in release 1.0 now. This issue should be fixed.

Related #24641

Probably relate with #25167 too.

Man this issue is such a nightmare.  If I edit my flutter build to fix it I start getting other issues after a while.  Every time I get it working in one project it breaks in another.  Sorry I know this isn't helpful, I'll try to post a better report later, just frustrated.

Just add TRACK_WIDGET_CREATION= to Release.xcconfig

i had the same problem and i fixed that, just removing the build folder from my project and try archive again

Work around
code $FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh

  local track_widget_creation_flag=""
  if [[ -n "$TRACK_WIDGET_CREATION" ]]; then
    # Remove the flag
    # track_widget_creation_flag="--track-widget-creation"
    track_widget_creation_flag=""
  fi

While doing this I lost all hot reload capabilities on iOS, so instead of removing completely the flag I tried to just use it on release mode
local track_widget_creation_flag=""
if [[ -n "$TRACK_WIDGET_CREATION" && "${build_mode}" == "debug" ]]; then
  track_widget_creation_flag="--track-widget-creation"
fi

It seems to work so far

@Klauzt https://github.com/flutter/flutter/issues/24239#issuecomment-440739466 should do as well

XCode > Runner Target > Build Settings > Scroll down to User-Defined and deleted all three entries for TRACK_WIDGET_CREATION. Solved it (for me).

@IAmKio Great!
It works for me too!

Well, I have encountered this issue and I didn't have to do anything either in sh scripts nor Xcode. The only thing I tried was:
From the flutter project root directory, executed the following:
flutter clean
flutter build ios
So in other words don't build your flutter project using Xcode directly because your project might need some commands to be executed(preprocessing) which flutter is doing for you and then it uses Xcode build.
After the build is done go to Xcode and try to Archive your project once again.
P.S: Flutter Version that I am running v1.4.8

XCode > Runner Target > Build Settings > Scroll down to User-Defined and deleted all three entries for TRACK_WIDGET_CREATION. Solved it (for me).
@IAmKio  Thank you, It works for me too!

iOS build Archiving but display white screen.
How to resolve this issue.

Please install version 1.0.0 (8) from TestFlight.
Best.
Original Message
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Date:Monday, Jul 8, 2019 14:35
Subject:Re: [flutter/flutter] Error creating IOS version to upload toTestflight. (#24239)
iOS build Archiving but display white screen.
How to resolve this issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@BRLOKESH   Archiving for Generic iOS Device.

iOS build Archiving but display white screen.
How to resolve this issue.

Any success about fixing the white screen?

No Success ..

@BRLOKESH  Try running 'flutter build ios --release' before Archiving with XCode.

Now Working **Thanks @mobilecheng  **
LOKESH:~ LOKESH$ touch ~/.bash_profile
LOKESH:~ LOKESH$ open -e ~/.bash_profile
LOKESH:~ LOKESH$ source $HOME/.bash_profile
LOKESH:~ LOKESH$ echo $PATH
/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/Server.app/Contents/ServerRoot/usr/bin:/Applications/Server.app/Contents/ServerRoot/usr/sbin:/Users/apple/Desktop/flutter V1.5.4/flutter/bin:/Users/apple/Desktop/flutter V1.5.4/bin
LOKESH:~ LOKESH$


feat(v2): add FB link to footer

Motivation
The main Docusaurus site as well as the template should demonstrate the basic functionality, so I consider it  rationale to add a recently added link field for the footer.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
See footer.

#1640 document usage of footer


Update show/hide guidance

Remove "/exclude" from Household goods question as guidance only shows what to include.
What is the context of this PR?
Remove "/exclude" from Household goods question as guidance only shows what to include.
How to review
Check show hide guidance now states "Show/Hide household goods items to include"

Closing this as it has been done in https://github.com/ONSdigital/eq-survey-runner/pull/1155


Added a scenario when OSv2 is re-enabled

Added the expected behavior of key/value pair when the OSv2 option is changed from "Disabled' to "Enabled".
Be note that I have confirmed with @Shashi Chinthakindi from the engineering team and advised that this is expected behavior and should be documented.
The testing case is as below.

Deploy the app to the CloudHub
Send a request GET request to the app to create a key/pair
Disable OSv2 option and app gets restarted
The OSv2 data is not visible from GUI.
Enabled the OSv2 option, the key/value pair stays

Hi @yunmei-zhang - can you look/commit my suggestions? @schinthakindims - can you approve this PR?


MaterialPropertyCoefficient refactor

Closed in favor of reviewing the full PR https://github.com/awslabs/palace/pull/166 in one go.


File format

Hi,
I am looking into using the OMF format for data exchange.  Is this format really in JSON utf-8?    I am currently using a compressed Uint16 in binary format and struggle to open large terrain models.  Has this format been stress tested and what are the limitations?
https://omf.readthedocs.io/en/stable/content/io.html

Following the binary is a UTF-8 encoded JSON dictionary containing all elements

Hey,
Note: I'm currently not involved in this project, but have been in the past so can answer this question,
Your quoted comment actually contains the important detail.

Following the binary is a UTF-8 encoded JSON dictionary containing all elements

In v1, the numeric arrays for the data (so vertex location and triangle indices for meshes) are stored as binary data with the JSON section containing meta data to interpret those arrays.
This has been revised for v2 which is under development at present, but it should still be stored relatively efficiently.
Still if you're looking at just storing large terrain models with a particular structure, there are likely other formats more optimised for your use.


When a Pearl Injector(and it's endergenic generator) is out side of a set of looped generators, it freezes the server

Versions:

minecraft-1.10.2
forge-1.10.2-<IP_ADDRESS>4
mcjtylib-1.1x-2.3.11
compatlayer-1.10-0.2.5
rftools-1.1x-5.90

How to reproduce:
Condition 1: A Pearl Injector is already placed.

place 4 generators and another generator out side of the loop with a Pearl Injector next to it.
link four generators to form a loop.
try to link the fifth generator(the one with injector) to other generator will cause the server to freeze.

Condition 2: Five generators are already linked.

place 4 generators and link them with the wrench.
place another generator and link it to one of the four generators.
try to place a Pearl Injector next to the generator will cause the server to freeze.

Note:

There is no crash report produced as the server just freeze, the server does not respond to commands and a server manager will have to terminate the server process.
This happens in a singleplayer world as well as a multiplayer world.

Will check it out

Fixed next release


chore: release main

:robot: I have created a release beep boop
renderer: 1.1.0
1.1.0 (2023-12-26)
Features

update package name (f0b7df9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/pavophilip/react-shader-fiber/releases/tag/renderer-v1.1.0 :sunflower:


feat(Calibration Tool) - add a calibration tool that can manually recalibrate an image and measurements on it

Context
Manual Calibration Tool implementation.
A DICOM image usually have calibration information (or pixel spacing information) that represents the mapping of real-world size and the pixels in the image. Sometimes this information is not available and even when it is available, we may want to manually re-calibrate the image.
Changes & Results
UX

Similar to the line(length) tool
but once the line is drawn, a popup shows up to collect input about the physical distance represented by the line.
Click OK, then the viewport and all the measurements will be updated

Notes

The re-calibration performed by this tool would be temporary and won't be persisted/uploaded back to the source image yet.

Testing
Checklist
PR

[x] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[x] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[x] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[x] OS: Windows 10
[x] Node version: 16.15.0
[x] Browser: Chrome 109.0.5414.121 (Official Build) (64-bit)

See my comment. I don't think you need to add it to measurement service since it is not getting displayed in the measurement panel, nore getting exported right?

What OHIF version does this PR support?

@sedghi I am sorry for the delay. Rebased, fixed (some code changes required after rebase), and tested.


Missing docstrings

It was noted that Node.config() is not included in API docs. This particular method does not have a docstring. Per interrogate, a third of fablib do not have docstrings:
$ interrogate -v fabrictestbed_extensions/fablib/
----------------------------------- Summary ------------------------------------
| Name                     |      Total |      Miss |      Cover |      Cover% |
|--------------------------|------------|-----------|------------|-------------|
| __init__.py              |          1 |         1 |          0 |          0% |
| component.py             |         40 |        12 |         28 |         70% |
| fablib.py                |        115 |        29 |         86 |         75% |
| facility_port.py         |         18 |        12 |          6 |         33% |
| interface.py             |         63 |        27 |         36 |         57% |
| network_service.py       |         67 |        31 |         36 |         54% |
| node.py                  |        124 |        40 |         84 |         68% |
| resources.py             |         43 |         8 |         35 |         81% |
| slice.py                 |         84 |        20 |         64 |         76% |
|--------------------------|------------|-----------|------------|-------------|
| TOTAL                    |        555 |       180 |        375 |       67.6% |
---------------- RESULT: FAILED (minimum: 80.0%, actual: 67.6%) ----------------

It could be that some of the undocumented methods that interrogate complains about really should be private methods, so we'll need a plan for marking them as such (with _ prefix maybe), but without breaking existing code.

#237 only adds some missing docstrings for methods in Node. Let's keep this open until we have better docstring coverage, or maybe create some child issues if necessary.


Not supported object types: SAP Gateway IWMO / IWOM / IWSG / IWSV

Hi,
I want to deserialize gateway services and need the following object types:
Object type ignored, not supported: IWMO
Object type ignored, not supported: IWOM
Object type ignored, not supported: IWSG
Object type ignored, not supported: IWSV
Thank you very much!

Did you try abapGit plugins?

we should just implement these in core

also see https://github.com/larshp/abapGit/issues/75

todo: update https://docs.abapgit.org/ref-supported.html when/in merge

Super thank you because gateway services and sapui5 is becoming more important.

@mnemotron can you help testing the pull request?

sure, I'll be glad to help

I'll test it on Monday. My SAP has no access to the internet I use the following link for an offline upgrade. https://github.com/larshp/abapGit/archive/gateway.zip

Hello, I tested it. There were no errors during serialization and deserialization. The objects are there. It looks good. I'll keep it under observation. If there's any complications, I'll get back to you.
Thank you very much for the quick implementation. Many greetings...

thanks, merging, closing issue, open new if errors are found


Block Time vs Created Time

Created time is when we find out about the transaction. Usually this is from when we read it from the mempool. However, with a full resync of chainquery this would be much sooner. In these cases the block explorer should show block time for both fields. If the gap is more than 1 hour a part make them both the blocktime value.

This may be confusing to users (just got me!), we should get it fixed up....

I don't think it makes sense to show Created Time, except if it's a mempool transaction.
Other explorers show a block time as Transaction time, and add a confirmation time :

So I would suggest removing Created Time and showing only Block Time, except for mempool transactions, and maybe add a confirmation time with less visibility.

I don't think it makes sense to show Created Time, except if it's a mempool transaction.
Other explorers show a block time as Transaction time, and add a confirmation time :

So I would suggest removing Created Time and showing only Block Time, except for mempool transactions, and maybe add a confirmation time with less visibility.


Authentication error

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.31.1
Regression From
No response
Architecture
x64
Storage Explorer Build Number
No response
Platform
Windows
OS Version
Windows 11 Pro 22621.2361
Bug Description
I have never been this error let me show in a picture

Steps to Reproduce

Launch MASE and eveytime the same

Actual Experience

Expected Experience
No response
Additional Context
No response
### Tasks

More information:

I have the default browser to MIcrosoft Windows Edge, but it not opened

Moved to 1.29.2 and works

So my conclusions in my cas is version 64 bit error, and when I return to 32bit works

Fixed, the problem was in my last Visual Studio 2022 professional update. Was not correct... seems, after uninstall and install again from scratch all works, so close the issue


adjust both sh scripts - derive project for organization and billing (no input required)

gcloud config set project lz-stg
export PROJ=$(gcloud config list --format 'value(core.project)')
export ORGANIZATION_ID=$(gcloud projects get-ancestors $PROJECT_ID --format='get(id)' | tail -1)
export BILLING_ID=$(gcloud alpha billing projects describe $PROJECT_ID '--format=value(billingAccountName)' | sed 's/.*\///')

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards
This issue may participate in the LZ refactor after rebase
Query on all issues related to the older V1 version via the tag
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/labels/2024-pre-tef-v4


Supported Ruby versions?

Which Ruby versions are officially supported by this gem? Going by the .travis.yml file, Ruby 2.4 support (testing) was "dropped"(?) in this commit https://github.com/fnando/browser/commit/c9a47545deb8c3ea4856ae74f8439e2cb35b4fe0. I was wondering, because the .gemspec file says >= 2.0 while the CHANGELOG.md says that version 2.4.0 of this gem removed Ruby 2.1 support, which was released in May 2017.

Officially, I support the latest two Ruby versions on all of my projects, unless specified otherwise on .travis.yml. I don't lock the version on the gemspec though; maybe it'll work, maybe it won't. The current restriction was back in the day when Ruby 1.9 had different feature set than 2.0 and can be removed.

Thank you for the quick response!


feature: Added Damage curves plot as new section

CanFlood
Changelog:

Getting curves filepath from control file
New method in dialog to plot using existing plot methods
Shifted legend underneath plot for better readability

Test coverage for this change:

[ ] I have added API unit tests
[ ] I have added appropriate UI unit tests
[X] I have not added tests

Additional Notes:

Thanks @BenMaxIBI, this looks great. We may need to add a 'purge curves' tool at some point (to the Build), but this can be done later. I made some tweaks to some of your variable and function names ( I use the 'run' prefix for something tied to a GUI button. I like to include some description of the object type in variable names where possible)


Relative effect path don't work with systemd

I have seen this issue long before. Now i investigated some more.
If systemd starts hyperiond, realtive effect path don't contains new created effects. Hyperion itself talks about success.
If i copy the systemd ExecStart command and let it run from commandline it works.
If i start hyperiond directly without /usr/bin symlink it works also.
User is always 'pi' on a raspbian jessie (also for systemd)
Wonder if someone could confirm this.

can you post your systemd service file?

this
WorkingDirectory=/path/to/hyperion
must be set, otherwise it can't be working

Ha! Added for later
https://github.com/hyperion-project/hyperion.ng/commit/81e06ef6a07f9fba2fe9ba81b56f123a796da953
Thank you!


[WIP] Added metric and alert for Uninstallation Stuck Due To PVC

Signed-off-by: bindrad<EMAIL_ADDRESS>

Modify template filename to lowercase
additionalPrometheusRule.go  ->additionalprometheusrule.go

deemed to be obsolete


Let's be strict when we install/upgrade Concrete

Newer versions of PHP are more strict about coding.
For example: in old PHP versions, accessing undefined array indexes raised notices (which is less "important" than warnings).
Since PHP 8.0 we have warnings, which are more "serious" messages.
And future PHP versions may be even more strict, for example refusing to run code that access undefined array indexes.
So, in order to be as future-proof as possible, we should fix any notice/warnings (see also #4723), and run our tests in an environment as strictly possible.
So, what about, for example, testing installation and upgrades with PHP 8.1?
In order to make the tests pass we already need some fixes (which I'll add here in a second time)

@mlocati you can also remove the continue-on-error: ${{ matrix.php-version == '8.1' }} lines in https://github.com/concrete5/concrete5/blob/develop/.github/workflows/phpunit.yml to make sure tests pass in 8.1

I also added https://github.com/concrete5/concrete5/pull/10446/commits/398b85728a20e2af12894c7209689ac68be35d1c
At the moment tests won't pass: we also need https://github.com/concrete5/dependency-patches/pull/8

I've pulled in that PR – can you add a commit to this in order to get the workflows to re-run?

Sure – I've published a new release for 1.7.1

The upgrade now works, but it seems there's something that breaks the website.
I'm going to check what's going wrong.

We still need another dependency patch...

I've done a new dependency-patches release.


Fix issues involving "indirect" random variables

This PR addresses issues with value variable tracking for random variables that aren't passed directly to joint_logprob.

From this I noticed this Aesara issue https://github.com/aesara-devs/aesara/issues/569.


"java.util.NoSuchElementException: No value present" when trying to pay someone from Server source (Minecraft 1.20.1 Fabric)

All I did is /economy pay 5 someone somecurrency Server
java.util.NoSuchElementException: No value present
    at java.base/java.util.Optional.get(Unknown Source)
    at net.impactdev.impactor.core.providers.ServiceProviderImplementation.provide(ServiceProviderImplementation.java:45)
    at net.impactdev.impactor.core.commands.economy.EconomyCommands.transfer(EconomyCommands.java:225)
    at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(Unknown Source)
    at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(Unknown Source)
    at cloud.commandframework.annotations.MethodCommandExecutionHandler.execute(MethodCommandExecutionHandler.java:79)
    at cloud.commandframework.execution.CommandExecutionHandler.executeFuture(CommandExecutionHandler.java:95)
    at cloud.commandframework.execution.AsynchronousCommandExecutionCoordinator.lambda$coordinateExecution$1(AsynchronousCommandExecutionCoordinator.java:101)
    at cloud.commandframework.execution.AsynchronousCommandExecutionCoordinator.lambda$coordinateExecution$3(AsynchronousCommandExecutionCoordinator.java:131)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.base/java.lang.Thread.run(Unknown Source)

It used to work on Impactor-Fabric-<IP_ADDRESS>.1-RC3.jar

Best to utilize eco deposit as your server paying source

Best to utilize "eco deposit" as your server paying source

Indeed that's certainly a better way, thanks!

Good note nonetheless, looks like a service component that wasn't registered. Will push a fix for this soon.


Suggestion - Add a "language" filter and/or show language in the title on the browse page.

I like to use the Browse page to discover new libraries and modules.
Something I miss is a quick way to know the main language of a project.
I see two ways to have this : either add a "filter by language" feature, or show the main language in the project list item.
Or both, obviously.
What do you think ?

Hi xurei, do you think we could roll this in with #3938?

Yes, that would fit in there :-)


Implementing container-interop interface

I'm using Auryn together with XStatic as a way to get something similar to Laravel Facades.
The problem is XStatic requires an instance of a Service Container that implements this Container Interface already being used by other Dependency Injector Containers.
It only requires implementing these two methods in the Provider (which you already has, but with other names).
public function get($id)
{
    return $this->make($id);
}

public function has($id)
{
    return $this->isDefined($id);
}

I'm currently extending Auryn\Provider so it is not much of a hassle, just wondering if it is wort the consideration.

Why on earth would you want to go near Laravel’s “Facades”?
Apart from that bombshell, you can use the adapter pattern to ‘forward’ calls from your required interface to auryn’s interface? That may help :-) Google ‘adapter pattern’ if you haven’t used it before. Also, Auryn is an Injector not a container.

On 27 Feb 2015, at 22:41, Raúl Ferràs<EMAIL_ADDRESS>wrote:
I'm using Auryn together with XStatic as a way to get something similar to Laravel Facades.
The problem is XStatic requires an instance of a Service Container that implements this Container Interface https://github.com/container-interop/container-interop already being used by other Dependency Injector Containers.
It only requires implementing these two methods in the Provider (which you already has, but with other names).
public function get($id)
{
return $this->make($id);
}
public function has($id)
{
return $this->isDefined($id);
}
I'm currently extending Auryn\Provider so it is not much of a hassle, just wondering if it is wort the consideration.
—
Reply to this email directly or view it on GitHub https://github.com/rdlowrey/Auryn/issues/77.

Well I'm just experimenting and wanted to replicate it.
The adapter pattern would suffice thanks.

Np. Just so you know, passing your container anywhere (apart from your bootstrap or a factory) is likely utilising it as a service locator - which is an anti-pattern. Is there another way you can use Auryn without turning it into one?

As I said I'm experimenting with this Dependency Injection thing.
The main issue I'm facing is how to handle the different dependencies controller's actions may need. Laravel uses Facades, but as you said this is just a form of Service Locator, so I'm struggling how I can avoid using Service Locators and/or defining a gigantic list of dependencies in the controller constructor.

Awesome, that's a great way forward. As soon as you have Auryn running make() on your controllers and running execute() on your controller method, you can typehint for what you want in any controller and it's 'plug and play' for all your libraries. Everything from there forward is then DI-based.
You might want to look at where your controllers are actually executed with Laravel and extend that class, make Laravel use your extended version, and do the above logic. This will involve prefixing any get parameters with : so that you can scalar typehints (as in Symfony slugs) and have those params passed in.
As for a gigantic list of dependencies, each controller method will have its own requirements right. So your execute() call takes care of that. I put common dependencies in a base class for my controller (like session, entity manager, logged in user etc), extend that, and have method-specific injection for each controller method.

On 28 Feb 2015, at 00:50, Raúl Ferràs<EMAIL_ADDRESS>wrote:
As I said I'm experimenting with this Dependency Injection thing.
The main issue I'm facing is how to handle the different dependencies controller's actions may need. Laravel uses Facades, but as you said this is just a form of Service Locator, so I'm struggling how I can avoid using Service Locators and/or defining a gigantic list of dependencies in the controller constructor.
—
Reply to this email directly or view it on GitHub.

You mean as in the "App-Bootstrapping" example in documentation right?
However, I worry about a scenary where a heavy dependency (in terms of time of instantation/memory footprint for example) that would be only used by a method would be instantiated every time the controller is created... but I guess I could create another controller with only that method to leverage other actions...

Usually it's best to use method-specific stuff when not every method will be using the object.
Auryn allows you to use factories for lazy instantiation, so you're creating a (not yet resolved) closure which does the lifting only when you try and use it. That may be beneficial in those heavy lifting cases where you still want constructor injection.

On 28 Feb 2015, at 09:02, Raúl Ferràs<EMAIL_ADDRESS>wrote:
You mean as in the "App-Bootstrapping" example in documentation right?
However, I worry about a scenary where a heavy dependency (in terms of time of instantation/memory footprint for example) that would be only used by a method would be instantiated every time the controller is created... but I guess I could create another controller with only that method to leverage other actions...
—
Reply to this email directly or view it on GitHub.

I don't quite understand how a factory method can help me in that scenario. Could you give me an example?
On the other hand, I've re-read the documentation and saw the execute method you were referring above, wouldn't that allow me to specify per method dependencies better?

Yep, make your controller then execute on the controller method. This may be useful, it's how I do it in Silex.
If there's something I need in a constructor but may only use it in one or two methods out of say 8, then I create a factory (not with Auryn, just an actual factory) and DI that instead. The factory's create method returns the newly created object but only when I call it. Factories are also useful for delaying the instantiation of an object so you can provide it runtime gathered data (ie data provided from a user's request).

On 28 Feb 2015, at 09:29, Raúl Ferràs<EMAIL_ADDRESS>wrote:
I don't quite understand how a factory method can help me in that scenario. Could you give me an example?
On the other hand, I've re-read the documentation and saw the execute method you were referring above, wouldn't that allow me to specify per method dependencies better?
—
Reply to this email directly or view it on GitHub.

I'd like to request that this issue be reopened, as container-interop is a beneficial to the ecosystem as a whole by allowing us to pick and choose components.

But Auryn isn't a container, it's an injector - I would argue a container is an anti-pattern - you're painstakingly storing everything in a magic box which you pull out when you like (i.e. service locator). Why would Auryn support such a massive waste of time and effort?

I don't personally have much interest in integrating interop capability into the library directly (as I philosophically disagree with its existence). But it should be fairly straightforward for someone to create a simple wrapper if they're so inclined.

@J7mbo because as the issue author said:

It only requires implementing these two methods in the Provider (which you already has, but with other names).

Your implementation of dependency injection doesn't have to change at all, it simply gives users more options to choose from. Similar to how we have psr-3 for standard logging, we can use container-interop as a universal interface for DI.

as I philosophically disagree with its existence

That's a fine opinion to have, but your willfully making it more difficult for your users to do what they want.

Not to mention that it's just another way to promote your opinion about how people should be doing DI. I fail to see any downsides.

Oh no, it's the PSR recruitment brigade! Quick, hide! ;D
It's not my implementation or opinion of Dependency Injection: Dependency Injection and Service Locator are patterns, one of them is an anti-pattern, and they usually oppose each other.
You can always write an adapter to deal with your required interface. For the record, I hugely disagree with "container-interop" - just because frameworks decide they're going to use it doesn't mean it's right - I'm not talking from a PHP only perspective here either.

Your attitude is very rude. Good luck with your project.

So is yours saying it's just me promoting my opinion... good luck to you too.

I'm not sure what is rude about suggesting that you provide more options for users, allowing your package to be used by a larger number of users. Chive on.

That's a little like saying it's a good thing that Laravel allows you to access everything statically.

It's absolutely not the same thing at all.

Would you like help writing an adapter? Perhaps we could work together on that and host it on github to make it work for others.. I don't mind... I just really don't agree that more options is always better.

Again, there's no reason for a separate adapter or a separate package. The entirety of what you would have to do is require container-interop/container-interop and implement the two interface methods as aliases to existing methods. I don't really have any interest in working with you on any project, given the attitude you've expressed.
Having more options isn't necessarily better, except when it makes your software better, which is clearly the case here.

But we've already established that it (1) puts forward poor practice (so, it doesn't make your software better, it merely makes it easier to write given your current architecture) and (2) the package owner doesn't want to do it. If they're not good enough reasons not to, I don't know what is.
If you think that that would make your software better, then I don't want to work with you either. Your suggestion would only make the library more complaint with a joke interface. That's all.

Usually you have interop interfaces for sharing injecting implementations somewhere with a common API… But the point of a Dependency injector is to inject dependencies and to be injected itself.
There's no real reason to inject this and so no reason to have it implementing a common interface. But feel free to create a tiny class WorseAuryn extends Auryn\Provider implements Interop\Container\Container-Interface { /* the two methods */ }.
Also I think reducing dependencies as far as possible is a good thing (not talking about duplicating code, but about not really necessary deps). There's no reason for Auryn\Provider to implement that interface. It doesn't add any value to it.

Not to resurrect a ghost, but I just wanted to mention that I now completely agree with @rdlowrey and @J7mbo on this subject... the container-interop is a huge mistake and totally unnecessary. We use Auryn with @sparkphp and love it!

Just out of interest @shadowhand, what changed your mind? Was there something in particular with the interface? I'm wondering if there's any knowledge you could share on that one :-)

@J7mbo Nothing specifically with the interface. What changed was the realization that Auryn could exist purely in the very outer layers of my application and be completely isolated from nearly everything. Nothing in the "business logic" of my application would need to know about it.
That said, I think there is potentially a tiny bit of convenience in having a common interface that allows people to replace the injector that is used by a framework, even though the framework does not need to depend on a specific injector, because pushing all injector configuration onto the user is not convenient for anyone.


Add integration tests for Docker External Volumes

There's no integration test for Docker External Volumes, making it very hard to be confident of code changes related to this functionality.

To be clear: there's a dc/os integration test that exercises the mesos containerizer (w/ docker vol isolator) and external volumes. What's missing is a dc/os integration test that leverages the docker containerizer + external vols.

xref https://github.com/dcos/dcos/pull/220/files#diff-e68bd6cbb63a4d94e426ca8692c4eae6R938

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1823. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-1823. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Lockdown Mode pallet.

This PR implements a lockdown mode pallet inspired in the Moonbeam maintenance pallet implementation.
Specs can be found here: https://github.com/paritytech/trappist/issues/144#issuecomment-1521927519
Closes #144

The PR is ready to be reviewed now. Still needs to be confirmed, but it seems the chess pallet is the responsable for the wasm exceed during execution.

@hbulgarini I think calling this pallet lockdown-mode would better represent the intent (I just found out that Apple has such a mode in iOS).

@stiiifff @kalaninja @valentinfernandez1 , i have addressed all the comments.

@kalaninja , i have to solve some conflicts on this branch because of the merge of the PR #165, could you please make sure that something was not incorrectly solved during the sync?  Then if everything looks fine, you can just approve and merge. @stiiifff already approved it but due to the re-sync the approval was missed.

@hbulgarini approved but I think it'd be nice to implement @kalaninja 's suggestion (see above).


Doesn't render stroke of rect, if fill opacity is 0

I realized, that this SVG lib doesn't render the border of rectangles, when the fill opacity is set to 0:
<rect id="SvgjsRect1008" width="313" height="448" stroke-opacity="1" stroke="#ff0d28" stroke-width="3" fill-opacity="1" fill="rgba(0, 0, 0, 0)" x="360" y="48" />

This example will render the stroke in the same opacity as the fill color. So it's not rendered at all in this example. This, as far as I know, doesn't correspond to the SVG standard.

This is actually a regression I introduced myself in this commit. Should work in 2.4.1...

As far as I can see, this will be fixed by #433.

@mrbean-bremen
Checked with the following SVG.
<?xml version="1.0" encoding="utf-8"?>
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0" y="0" width="700" height="200" xml:space="preserve">
<rect width="50" height="100" stroke-opacity="1" stroke="rgba(255, 0, 0, 0)" stroke-width="6" fill-opacity="1" fill="rgba(0, 0, 255, 0)" x="100" y="40" />
<rect width="50" height="100" stroke-opacity="1" stroke="rgba(255, 0, 0, 255)" stroke-width="6" fill-opacity="1" fill="rgba(0, 0, 255, 255)" x="100" y="40" />
<rect width="50" height="100" stroke-opacity="1" stroke="rgba(255, 0, 0, 127)" stroke-width="6" fill-opacity="1" fill="rgba(0, 0, 255, 127)" x="160" y="40" />
<rect width="50" height="100" stroke-opacity="1" stroke="rgba(255, 0, 0, 1)" stroke-width="6" fill-opacity="1" fill="rgba(0, 0, 255, 1)" x="220" y="40" />
<rect width="50" height="100" stroke-opacity="1" stroke="rgba(255, 0, 0, 1)" stroke-width="6" fill-opacity="1" fill="rgba(0, 0, 255, 1)" x="280" y="40" />
<rect width="50" height="100" stroke-opacity="0.5" stroke="rgba(255, 0, 0, 255)" stroke-width="6" fill-opacity="0.5" fill="rgba(0, 0, 255, 255)" x="340" y="40" />
</svg>

In Firefox and Chrome, It is hidden when alpha value is 0 and displayed when alpha value is 255.
But not transparent.

It's nice to hear, that a fix is already available. Will there be an official release soon?

I'm also seeing an issue with "fill-opacity", although I'm not sure if this is the problem as reported in this issue.
The svg markup is as follows:
<?xml version="1.0" encoding="UTF-8"?>
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" width="225" height="200">
  <g id="Layer 1">
    <path d="M150 0 L75 200 L225 200 z" fill-opacity="0" stroke="red" stroke-width="1" />
  </g>
</svg>

Expected rendering:

Result using 6ca410096bf231692600126a86f771dff21eb878 and using H1Gdev's 8fa0c66daad2a106565f819fe442c9c347b0e8c5:

Can you please provide a quick hotfix release with the lastest changes and bugfixes for this issue?

As per my comment in #439, the issue I reported above appears to be fixed as of H1Gdev's commit 7f392c318d8dc20caba5d16ee053994b3f997ffb (branch "opacity").
Thank you, @H1Gdev and @mrbean-bremen, for your assistance.

@H1Gdev - are you done fixing, or do you want to add more PRs?
@tebjan: provided @H1Gdev is done - he did a good job fixing these opacity issues, which partly have been regressions. Maybe it makes sense to make another minor release (as asked by @AnReZa)?

@mrbean-bremen
Yes.fix all my PRs.

@mrbean-bremen @tebjan Any chance to get a minor release for this fix? I would be really thankful! :)

yes, sounds good! will make a new release.

done, thanks for the fixes @H1Gdev and @mrbean-bremen!

takes usually 30 minutes to be listed on nuget org. https://www.nuget.org/packages/Svg/2.4.3

Thank you!

takes usually 30 minutes to be listed on nuget org. https://www.nuget.org/packages/Svg/2.4.3

There is no reference to #437 on the release notes for 2.4.3.
Thank you for making this happen.

Looks like the release notes on the nuget page belong to 2.4.2 - you can check the release notes in the Wiki.


Save multinucleate molecules

Instead of skipping such molecules, if a molecule has more than one metal atom, retrieve it. However, since these may need to be filtered out in downstream analysis, add a column to the output csv indicating the number of metal atoms

Resolved in ef145de2e00de47e841586ffd3b27ef7ba35c0e2


Doorlock clear credential command and get credential command  return failure when called after set credential command

Problem -when we try to send Clear Credential Command after setting credential we are seeing failure
sequence of  steps

clear credential =./chip-tool doorlock clear-credential  '{ "credentialType" : 1 , "credentialIndex" : 1 }'  1 1 --timedInteractionTimeoutMs 1000   (Response=success)
set credential =./chip-tool doorlock set-credential 0 '{ "credentialType" : 1 , "credentialIndex" : 1 }' 123456 null 0 0 1 1 --timedInteractionTimeoutMs 1000   (Response=success)
get credential = ./chip-tool doorlock get-credential-status '{ "credentialType" : 1 , "credentialIndex" : 1 }'  1 1 --timedInteractionTimeoutMs 1000   (Response=failure)
clear credential= ./chip-tool doorlock clear-credential  '{ "credentialType" : 1 , "credentialIndex" : 1 }'  1 1 --timedInteractionTimeoutMs 1000   (Response=failure)

feature map for PIN is  1
Expected Behavior - in step 3 and 4 status should be success 0x00 (Success)
App used - lock app
Platform - Chip-tool - RPI-4, 8GB RAM
DUT - RPI-4, 8GB RAM
Network - Ble-wifi
Commit - https://github.com/project-chip/connectedhomeip/commit/9493d7b48c410f058b85552e1668b33f858afcac
DOORLOCK logs.txt

From the server log:
[1655305543142] [3213:12083751] CHIP: [ZCL] [GetCredentialStatus] Database possibly corrupted - credential exists without user assigned [endpointId=1,credentialType=1,credentialIndex=1]

The issue is that this command:
/chip-tool doorlock set-credential 0 '{ "credentialType" : 1 , "credentialIndex" : 1 }' 123456 null 0 0 1 1 --timedInteractionTimeoutMs 1000

is passing in 0 for UserStatus and 0 for UserType, which correspond to "Available" (i.e. "does not exist") and "UnrestrictedUser".
It seems like that should perhaps error out at that point, instead of claiming success and creating a credential attached to a non-existent user?  @DanM-AssaAbloy @Morozov-5F @RyanLindemanCAE
But if it is ok to have a credential attached to a non-existent user, then I'd expect "Get Credential Status" to succeed for such a credential...

@bzbarsky-apple yeah, that was definitely overlooked in the implementation. Should be an easy fix.


Support PostgreSQL search_path in xorm rather then code of juicefs

reference #2663

It is a little difficult to implement search_path in xorm and requires a lot of API changes. So I think the current implementation in juicefs should be maintained.


EnumPath.stringValue in CaseBuilder: Error converting data type varchar to float on SQLServer

We have a CaseBuilder that works on an EnumPath and returning a default value in some cases. Something like
com.querydsl.core.types.dsl.StringExpression state = new CaseBuilder().when(jobExecution.status.eq(JobStatus.FAILED)).then("FAILED")
            .when(jobExecution.status.in(runningStatus)).then("RUNNING")
            .otherwise(jobExecution.status.stringValue());

(jobExecution is the EnumPath)
This creates an SQL like
select case when jpabatchjo0_.STATUS='FAILED' then 'FAILED'
    when jpabatchjo0_.STATUS in ('STARTING' , 'STARTED') then 'RUNNING'
    else str(jpabatchjo0_.STATUS)
end
...

This causes an error to be thrown [S0005][8114] Error converting data type varchar to float.
Consulting the SQLServer reference, we see that the STR function converts a numeric value to string, so the above is incorrect for this DBMS.
Please fix the casting or provide a workaround for SQLServer.

Seems you found the work around.


fix: update examples readme

The existing README was targeted for connect-sdk, updated it for wormhole-sdk-ts

Thanks!


Restore previously overwritten listeners

I added a story that showcases the bug which is now fixed. Listeners are properly re-bound when removing some.
Fix #16

[x] Tests for the changes have been added (for bug fixes / features)
[x] ~Docs have been added / updated (for bug fixes / features)~

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?
[ ] Yes
[x] No

Sigh - I had to revert this as it broke things in my app. I'll try to recreate the issue and see if I can post it here to see what your thoughts are.

Sigh - I had to revert this as it broke things in my app. I'll try to recreate the issue and see if I can post it here to see what your thoughts are.

Sorry about that! 😕 Let me know, I'd be happy to help.

I had this:
Mousetrap.trigger('SHIFT+?')

and it was bound like this:
{
      name: 'Help',
      keys: 'mod+shift+h',
      category: 'Navigation',
      callback: event => {
        event.preventDefault();
        show();
      }
    }

After upgrading it stopped working altogether. I'm thinking what happened is:
- Page Loaded
- The component binding this is at the top level
- Pages below this load later
- They bind their own hotkeys
- Parent hotkey gets discarded ( not sure here )

I have this in a menu item to open a dialog that shows all the hotkeys:
Mousetrap.trigger('SHIFT+?')

The .trigger method should be called from the instance that bound the events. Previously it was working because it was using Mousetrap.bind and not new Mousetrap().bind. An easy fix would be to get back to that, let me open a PR with a test.
Ideally reakeys should probably expose a way to trigger a shortcut on the global instance or an element's instance. But we can look into it later.

@zhouzi - +1 to adding the trigger - that could just be part of the hook return variables.
Also I was thinking about adding a hotkey to text utility method like:
export const isMac = navigator.platform.toUpperCase().indexOf('MAC') >= 0;
export const MODIFIER_KEY = isMac ? '⌘' : 'CTRL';

function getHotkeyText(hotkey) {
  return text
}


Qmalcolm  add event for debugging artifact writing

Resolves #10934
Problem
Solution
Checklist

[ ] I have read the contributing guide and understand what's expected of me.
[ ] I have run this code in development, and it appears to resolve the stated issue.
[ ] This PR includes tests, or tests are not required or relevant for this PR.
[ ] This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
[ ] This PR includes type annotations for new and modified functions.

@ChenyuLInx what if I actually split this into 3 PRs? It'll be easier to see what is happening and separates the work streams appropriately

Emitting events
Fixing safe_run_hooks
Refactor focused on simplification

Closing in favor of:

https://github.com/dbt-labs/dbt-core/pull/10941
https://github.com/dbt-labs/dbt-core/pull/10940


Added new texture button and new textures

We may have to be wary of uploading further assets to keep pull/clone time down. Or we might consider git lfs.


Add no_ssl_verify source option

This adds an optional source configuration to disable ssl verification.
This way ssl verification is not disabled anymore when an http_proxy is set.
This can also be a useful option for endusers when targeting github enterprise instances.

Thanks for the PR and updating the tests. :+1:


Fix Mixin box-shadow english file

Checklist:

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Closes #XXXXX

Is there an issue for this/these @ivanfranco502? Or any discussion anywhere on why it needs changing?

@moT01 there isn’t any issue, cause it’s a typo.
When we are specifying in the mixin box-shadow each css rule, we are using commas as a separator between parameters instead of just spaces.
If you need, I could create an issue but accordingly to the FCC Contribution Guide, if it’s a typo, we can create a PR directly.

No, I don't think we need an issue at this point. I misread the diff a little bit before and thought all the green was added.


feat(Mathlib/Topology/Bases): subbasis closed under intersection is a basis

We show that if a sub-basis is closed under finite intersections, then it is a basis for a topology.
As a corollary, if a sub-basis is closed under intersections, then inserting the universal set gives a basis for the topology.
An example application of this result is given in #12234

bors merge


GDB support broken in minimal docker container

Reported on Discord

Hi, I'm also having some trouble with the debugger. I am trying to get the debugger working in a clean Docker environment with only gdb installed.

FROM runtimeverificationinc/kframework-k:ubuntu-jammy-7.1.70

RUN apt-get update && \
    apt-get install -y gdb && \
    apt-get clean && \
    rm -rf /var/lib/apt/lists/*
RUN echo "set auto-load safe-path /" >> /root/.gdbinit

RUN mkdir -p /workspace
WORKDIR /workspace

I compile and run the program as follows:

$ kompile --backend llvm --enable-llvm-debug test.k
$ krun testfile --debugger

However, I couldn't start or step through the program in gdb:

(gdb) k start
Temporary breakpoint 1 at 0x7be20
Starting program: /workspace/test-kompiled/interpreter /tmp/.krun-2024-07-21-18-01-21-7HhvVMBifn/tmp.in.9ow8yaJKOg -1 /tmp/.krun-2024-07-21-18-01-21-7HhvVMBifn/result.kore
warning: Error disabling address space randomization: Operation not permitted
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Temporary breakpoint 1, 0x00005632fa85ae20 in main ()
Python Exception <class 'gdb.error'>: No source file named definition.kore.
Error occurred in Python: No source file named definition.kore.

Thanks for the additional info; we'll take a look at this for you!

This is an error related to the -g flag. We're not passing it appropriately to clang. I saw this same error here: https://github.com/runtimeverification/llvm-backend/issues/858
If you execute kompile --verbose ..., copy and paste the llvm-kompile command and append -g after the --, you'll be able to open the debugger as expected.

This is an error related to the -g flag. We're not passing it appropriately to clang. I saw this same error here: #858 If you execute kompile --verbose ..., copy and paste the llvm-kompile command and append -g after the --, you'll be able to open the debugger as expected.

It worked! Really appreciate the help!


Upgrade rpyc and pip-tools.

Motivation for changes:
Fix Python 3.7 breakage.
Make updating dependencies work.
Detailed changes:
Upgrade rpyc and pip-tools.

rpyc < 4.0 is broken with Python 3.7 because 'async' is now a keyword: https://github.com/tomerfiliba/rpyc/issues/253
pip-tools < 2.0.1 is incompatible with pip >= 10 so pip-compile fails: https://github.com/jazzband/pip-tools/issues/648

Addressed issues:

None.

Implemented feature requests:

None.

Config usage if relevant (new plugin or updated schema):
None.
Log and/or tests output (preferably both):
Cannot test properly until https://github.com/Flexget/Flexget/pull/2162 is merged because that's also a fix for Python 3.7.
To Do:
None.

I already got #2193 going, we should probably merge these two.

I already got #2193 going, we should probably merge these two.

I agree