[SPARK-43648][CONNECT][TESTS] Move interrupt all related test to a new test file to pass Maven test

What changes were proposed in this pull request?
SPARK-43331 added two new test cases in ClientE2ETestSuite:

interrupt all - background queries, foreground interrupt
interrupt all - foreground queries, background interrupt

The udf in these two new test cases does not only require spark-connect-client-jvm-tests.jar when deserializing on the server side due to ClientE2ETestSuite implicitly import some classes from spark-connect-client-jvm.jar, such as org.apache.spark.sql.connect.client.SparkResult, so when run the maven test as follows:
build/mvn clean install -DskipTests
build/mvn test -pl connector/connect/client/jvm -Dtest=none -DwildcardSuites=org.apache.spark.sql.ClientE2ETestSuite

There will be the test failed in server side as follows:
23/05/22 15:44:11 ERROR SparkConnectService: Error during: execute. UserId: . SessionId: 0f4013ca-3af9-443b-a0e5-e339a827e0cf.
java.lang.NoClassDefFoundError: org/apache/spark/sql/connect/client/SparkResult
	at java.lang.Class.getDeclaredMethods0(Native Method)
	at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)
	at java.lang.Class.getDeclaredMethod(Class.java:2128)
	at java.io.ObjectStreamClass.getPrivateMethod(ObjectStreamClass.java:1643)
	at java.io.ObjectStreamClass.access$1700(ObjectStreamClass.java:79)
	at java.io.ObjectStreamClass$3.run(ObjectStreamClass.java:520)
	at java.io.ObjectStreamClass$3.run(ObjectStreamClass.java:494)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.io.ObjectStreamClass.<init>(ObjectStreamClass.java:494)
	at java.io.ObjectStreamClass.lookup(ObjectStreamClass.java:391)
	at java.io.ObjectStreamClass.initNonProxy(ObjectStreamClass.java:681)
	at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:2005)
	at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1852)
	at java.io.ObjectInputStream.readClass(ObjectInputStream.java:1815)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1640)
	at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2431)
	at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2355)
	at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2213)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1669)
	at java.io.ObjectInputStream.readArray(ObjectInputStream.java:2119)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1657)
	at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2431)
	at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2355)
	at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2213)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1669)
	at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2431)
	at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2355)
	at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:2213)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1669)
	at java.io.ObjectInputStream.readObject(ObjectInputStream.java:503)
	at java.io.ObjectInputStream.readObject(ObjectInputStream.java:461)
	at org.apache.spark.util.Utils$.deserialize(Utils.scala:148)
	at org.apache.spark.sql.connect.planner.SparkConnectPlanner.org$apache$spark$sql$connect$planner$SparkConnectPlanner$$unpackUdf(SparkConnectPlanner.scala:1353)
	at org.apache.spark.sql.connect.planner.SparkConnectPlanner$TypedScalaUdf$.apply(SparkConnectPlanner.scala:761)
	at org.apache.spark.sql.connect.planner.SparkConnectPlanner.transformTypedMapPartitions(SparkConnectPlanner.scala:531)
	at org.apache.spark.sql.connect.planner.SparkConnectPlanner.transformMapPartitions(SparkConnectPlanner.scala:495)
	at org.apache.spark.sql.connect.planner.SparkConnectPlanner.transformRelation(SparkConnectPlanner.scala:143)
	at org.apache.spark.sql.connect.service.SparkConnectStreamHandler.handlePlan(SparkConnectStreamHandler.scala:100)
	at org.apache.spark.sql.connect.service.SparkConnectStreamHandler.$anonfun$handle$2(SparkConnectStreamHandler.scala:87)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at org.apache.spark.sql.SparkSession.withActive(SparkSession.scala:825)
	at org.apache.spark.sql.connect.service.SparkConnectStreamHandler.$anonfun$handle$1(SparkConnectStreamHandler.scala:53)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at org.apache.spark.util.Utils$.withContextClassLoader(Utils.scala:209)
	at org.apache.spark.sql.connect.artifact.SparkConnectArtifactManager$.withArtifactClassLoader(SparkConnectArtifactManager.scala:178)
	at org.apache.spark.sql.connect.service.SparkConnectStreamHandler.handle(SparkConnectStreamHandler.scala:48)
	at org.apache.spark.sql.connect.service.SparkConnectService.executePlan(SparkConnectService.scala:166)
	at org.apache.spark.connect.proto.SparkConnectServiceGrpc$MethodHandlers.invoke(SparkConnectServiceGrpc.java:611)
	at org.sparkproject.connect.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:182)
	at org.sparkproject.connect.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:352)
	at org.sparkproject.connect.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:866)
	at org.sparkproject.connect.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at org.sparkproject.connect.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:133)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)
Caused by: java.lang.ClassNotFoundException: org.apache.spark.sql.connect.client.SparkResult
	at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
	... 56 more

We can choose to add spark-connect-client-jvm.jar as Artifact to the server during testing, but this is relatively complex and spark-connect-client-jvm.jar does not always exist during Maven testing. So this PR chooses to move these two test cases to a separate file to pass Maven test.
sbt test is not failed by this because the classpath of sbt submitted SimpleSparkConnectService will include connect client module, this is different from Maven, so GitHub Actions can passed.
Why are the changes needed?
Make interrupt all - background queries, foreground interrupt and interrupt all - foreground queries, background interrupt can test pass using maven.
Does this PR introduce any user-facing change?
No, just for test
How was this patch tested?

Pass Github Actions
Manual check

build/mvn clean install -DskipTests
build/mvn test -pl connector/connect/client/jvm

The two test cases in the PR description can be tested successfully.

We can choose to add spark-connect-client-jvm.jar as Artifact to the server during testing, but this is relatively complex and spark-connect-client-jvm.jar does not always exist during Maven testing. So this PR chooses to move these two test cases to a separate file to pass Maven test.

https://github.com/apache/spark/pull/41483/files has implemented the fix way of using spark-connect-client-jvm.jar and spark-connect-client-jvm-tests.jar as Artifacts, but this seems more complex and I prefer to use current one

cc @dongjoon-hyun @HyukjinKwon @hvanhovell @vicennial @juliuszsompolski

@vicennial ca3e6b1 rename SparkSessionE2ESuite  to SparkSessionCleanRoomE2ESuite

@dongjoon-hyun @vicennial @juliuszsompolski Do you have any other suggestions for this pr? Can we merge this one first? This can make Maven test to pass first, and if there is a better solution, we can add followup

Thanks @HyukjinKwon  ~

Merged to master.

Thanks @HyukjinKwon @dongjoon-hyun @vicennial @juliuszsompolski

This is fine as a temporary workaround, but it is actually showing a problem that can heavily impact usability. We are apparently capturing classes that are unrelated to the code at hand.
@LuciferYang is anyone looking into why this is causing problems with Maven? I am not saying that you should, I just want to make sure we are not duplicating efforts.

@juliuszsompolski
I think what you said is reasonable, and I also hope there can be a way to remove unnecessary parts from the function, which would be very perfect.
in addition, or do you think we should also remove
https://github.com/apache/spark/blob/7107742a381cde2e6de9425e3e436282a8c0d27c/connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/util/RemoteSparkSession.scala#L130-L140
？This is added to avoid similar issues.


Rails 5.0.1 placeholders are not working

Role.first
Role Load (3130.9ms)  SELECT  roles.* FROM roles ORDER BY roles.id ASC LIMIT ?
ActiveRecord::StatementInvalid: Mysql2::Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?' at line 1: SELECT  roles.* FROM roles ORDER BY roles.id ASC LIMIT ?

I also get this for all or most queries. It prevents the Rails app from starting.

Try setting prepared_statements: false in database.yml

This's helpful and should put to readme file.


Format change in chat

I don't know why, but today the chat rolls and "broadcast" have changed their format. It looks like a little "broken/ugly". It shows all table borders. I have watched in Eirendor/D&D5th and The Sprawl. Is this an issue or a change?

Well. Since nobody has commented anything (not even on Twitter) I have been looking at the forums and it seems that these changes will force the creators of the sheets to update them. I hope that @timdenee  has time to fix it again The Sprawl, because it was perfect.

I fixed the roll template in #3896.

The fix is now live.

Thanks. It's perfect again.

@WallaceMcGregor it would be great if you could close this to shrink the list of issues.


Fix test command which was calling mutt instead of neomutt

brew test for the formula is failing because the wrong command is called. Even worse, if mutt is installed the test will deceptively pass.

Good idea, thanks! This line will also need changing (or removing, seeing as it’s redundant).

@alexpearce I'll change that too. I had one more change that required your attention: https://github.com/neomutt/homebrew-neomutt/blob/master/Formula/neomutt.rb#L29
brew list says that this formula does not install such a library (neomutt is installed as expected) and I think we can remove this conflict after renaming bin/smime_keys as that does conflict.
On top of that, if its agreeable to the neomutt maintainer, we can also add an option to force link neomutt to mutt even if mutt is installed. Other packages provide this functionality, for example vim.

I was fixing the build a couple of days ago, and made these changes myself, forgetting this 😰 I'm sorry about that.
So I'll the PR. Thank you very much for your contribution though, we appreciate it!


The application falls on huawei  p8 lite 2017

E/MediaRecorder: stop failed: -1007
mediaRecorder?.apply {                     stop()                     reset()                 }

This sample has been migrated to a new location where we can accept Pull Requests (check README for more information).
As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.
If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!


Offline documentations for Dash (Zeal)

I know that there is offline documentation available for Perl6 (via p6doc and the generated html's). However, some of the developers may want to use Zeal to browse the documentations for Perl 6. There is Perl 5 docset, but Perl 6 is still not yet available.
Resource for generating the docset - https://kapeli.com/docsets

@faraco Could you convert the html output of the current docs using this method: https://kapeli.com/docsets#dashDocset

@WildYorkies I think yes, but I'm not sure if I can finish it, because I'm not familiar with dash docset making. I will come back again, if there is good progress on making it.

Sounds like someone is volunteering to make Pod::To::Dash :)

After a while, I found some one already made it - https://github.com/davepagurek/Perl6-Dash-docset-generator
However, there is some error in the repository (maybe uncleaned development code). The dependencies is fine, although HTML::Entity cause an error because of there is more test plan than the actualy test. So it might be safe to just --force install it.
To include the docset to Zeal official download docsets, we might need to contact one of the Zeal developers, or we can host our own feed somewhere (private place, where users need to copy paste the link and download the already made docset).
Resource:
https://kapeli.com/docsets#dashdocsetfeed
https://kapeli.com/docsets#sharedocsetfeed

I updated the Dash docset for Perl 6. Please go here: Zeal User Contributions and search for Perl6. Please be aware that there are some minor issues with the docset mostly due to the fact that links in the Perl 6 documentation are case-sensitive but not in Dash. Dash has to work on system which don't care about case-sensivity. There is no work-around.

Thanks!
Can we close this issue then?

Please close it.

(Fair warning: I had never heard of Zeal until seeing this ticket, so I'm catching up here.)
Wait—before closing this issue, is the process for updating it on that feed automatically when this repo is updated already done? Perhaps it shouldn't be a process in this repo's CI, but your process needs to be repeatable and preferably automated, @schmidh, in the schmidh/Perl6-Dash-Docset-Generator repo.
The feed currently available at https://zealusercontributions.herokuapp.com/docsets/Perl6.xml is for bac7d410, which is two days old at this writing, so I assume this hasn't been done.
These docs are updated much more frequently than most languages', so at the very least there should be a lightweight process for kicking an update off, accessible by more than only you.
(Meanwhile, I have opened a cosmetic issue at schmidh/Perl6-Dash-Docset-Generator#1 assuming that that's to be the place for this?)

The process of generating the docset is automated. You can check for yourself by following the instructions in the README.
In order to update the docset for Dash one has to send a PR to Kapeli. Then a guy there will check it and if the CI went through without any problems apply it. Shortly afterwards it will be available to the Dash users. I don't think Kapeli wants to check a PR every time the Perl 6 documentation slightly changes.

In order to update the docset for Dash one has to send a PR to Kapeli. Then a guy there will check it and if the CI went through without any problems apply it. Shortly afterwards it will be available to the Dash users. I don't think Kapeli wants to check a PR every time the Perl 6 documentation slightly changes.

Since you have the familiarity with Kapeli and Dash, how often would you suggest is reasonable? The Perl 6 docs have never had a real concept of versioning or "major" vs. "minor" changes.

Perl 6 is moving slowly but steady as we all know. I thought about doing in update every half year or so. Probably once a year would be ok, too. What do you think?

El mar., 5 feb. 2019 a las 0:25, Hans-J. Schmid<EMAIL_ADDRESS>escribió:

You are right. There is a lot of activity on Perldoc. Didn't realize that.
Changed my mind. Updates should be done on a monthly basis. Will automate
it.

Thanks!

Mission accomplished. There is an update coming once a month from now on.  Maybe they are even happy about it. They should actually.
Search index is much bigger now. About 15000 entries instead of 1500. Browsing the Perl 6 help system offline with Dash or Zeal is awesome. My advice: if you have a Mac box purchase Dash. Makes you a hero from zero in no time. Otherwise there is still Zeal for Windows and Linux. Also very good. Did some Ansible work lately. I felt I did this for years. Thanks to the Ansible docset.
Problems with the Perl 6 docset should be directed at the Perl6 Dash Docset Generator from now on.

Thanks!
El vie., 8 feb. 2019 a las 13:53, Hans-J. Schmid<EMAIL_ADDRESS>escribió:

Mission accomplished. There is an update coming once a month from now on.
 Maybe they are even happy
about it. They should actually.
Search index is much bigger now. About 15000 entries instead of 1500.
Browsing the Perl 6 help system offline with Dash or Zeal is awesome. My
advice: if you have a Mac box purchase Dash. Makes you a hero from zero in
no time. Otherwise there is still Zeal for Windows and Linux. Also very
good. Did some Ansible work lately. I felt I did this for years. Thanks to
the Ansible docset.
Problems with the Perl 6 docset should be directed at the Perl6 Dash
Docset Generator https://github.com/schmidh/Perl6-Dash-Docset-Generator
from now on.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/perl6/doc/issues/1185#issuecomment-461793750, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAB9OuB0n2MHFYQcj_m64LxZ8WXGafhks5vLXNfgaJpZM4L5jha
.

--
JJ

Awesome!

I'm not going to say thanks again. But I will say, since this is done, can we close this issue?

We can close it. Thanks!


fix before onPageFinished activity onPause make the defParamValue empty

as the title desc

Thank you for fixing that! :+1:


Emmet breaks on Sublime Text 3 Build 3124

After installing the latest build of Sublime Text 3 (Build 3124), Emmet doesn't work anymore. This is the error message:
Traceback (most recent call last):
  File "/opt/sublime_text/sublime_plugin.py", line 109, in reload_plugin
    m = importlib.import_module(modulename)
  File "./python3.3/importlib/__init__.py", line 90, in import_module
  File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 584, in _check_name_wrapper
  File "<frozen importlib._bootstrap>", line 1022, in load_module
  File "<frozen importlib._bootstrap>", line 1003, in load_module
  File "<frozen importlib._bootstrap>", line 560, in module_for_loader_wrapper
  File "<frozen importlib._bootstrap>", line 868, in _load_module
  File "<frozen importlib._bootstrap>", line 313, in _call_with_frames_removed
  File "/home/sub0dh/.config/sublime-text-3/Packages/emmet-sublime/emmet-plugin.py", line 24, in <module>
    import emmet.pyv8loader as pyv8loader
  File "/home/sub0dh/.config/sublime-text-3/Packages/emmet-sublime/emmet/pyv8loader.py", line 20, in <module>
    import urllib.error as url_err
AttributeError: 'module' object has no attribute 'error'

I listed the methods available in the urllib module and it contains only the following methods ['__builtins__', '__cached__', '__doc__', '__file__', '__loader__', '__name__', '__package__', '__path__', 'request'].
Is this an issue with the new Sublime Text 3 build or something else?

I had same problem. The solution was at ST3 forum:
https://forum.sublimetext.com/t/solved-emmet-not-working-in-3124/23122/2

Hey guys, emmet is not working at all. I installed manually emmet and Pyv8 and nothing happened.
Please help!

Same issue here, solution in forum seems to work, but stops again after restarting sublime

For now I've implemented a hacky solution, which will work on the cases that there's no errors while downloading the pyv8 library. I cloned the repository and made changes in the emmet-sublime/emmet/pyv8loader.py file at line 20 and 21 to:
url_err = ''
url_parse = ''

It works at multiple restarts as well. But we'll have to find a better solution for this problem.

from SubodhDahal #638

I cannot reproduce this issue on my Ubuntu 16.04 x64 VM, as well as on OSX.
Solution provided by @SubodhDahal isn’t valid since it breaks further error reporting.
My guess it that there’s a plugin that contains (or overrides loader for) standard urllib package. If you still have this issue, please run the following in ST console:
import importlib; importlib.find_loader('urllib')

It should display path python3.3.zip bundled with ST. If it’s not, then some package overrides loader for this module

I'm still having this issue on Ubuntu 16.04 x64.
Yeah, the solution I posted is not a valid one. It was just meant to be a temporary workaround to get Emmet working until a real solution could be found.
I ran the code you posted in console and got the following output.
<zipimporter object "/opt/sublime_text/python3.3.zip">
Emmet was working until I upgraded to Build 3124. Immediately after upgrading, Emmet stopped working.

@SubodhDahal seems like a valid path. Can you unpack /opt/sublime_text/python3.3.zip and check if there’s urllib/error.py file?

There's a error.pyo file there. urllib directory contains the files error.pyo, __init__.pyo, parse.pyo, request.pyo, response.pyo, robotparser.pyo.

Everything seems fine...
From your initial message:

I listed the methods available in the urllib module and it contains only the following methods ['__builtins__', '__cached__', '__doc__', '__file__', '__loader__', '__name__', '__package__', '__path__', 'request'].

When topic error raise again, can you list urllib methods again? If there’s still no error property, can you output __file__ prop and tell me where it points to?

Every time I list the urllib methods, I get the only the methods that I posted before.
urllib.__file__ points to /opt/sublime_text/python3.3.zip/urllib/__init__.pyo

Can you post a full ST log right after editor is started?

Setting on request handler
CodeFormatter: Plugin Initialized
SublimeLinter: debug mode: off
HTTP Start
reloading settings Packages/User/PackageSync.sublime-settings
Package Control: Skipping automatic upgrade, last run at 2016-10-04 17:52:10, next run at 2016-10-04 18:52:10 or after

I'm seeing the same thing, running on Ubuntu 14.04 64bit box, but it seams to work fine on my Fedora 23 64bit machine. Something very strange going on

I still think there’s some package that affects this behaviour. I need some time to investigate it further

Attaching my startup console output to see if there is anything common. I don't see anything obvious between mine and @SubodhDahal log
DPI scale: 2
startup, version: 3126 linux x64 channel: stable
executable: /opt/sublime_text/sublime_text
working dir: /
packages path: /home/hardillb/.config/sublime-text-3/Packages
state path: /home/hardillb/.config/sublime-text-3/Local
zip path: /opt/sublime_text/Packages
zip path: /home/hardillb/.config/sublime-text-3/Installed Packages
ignored_packages: ["Vintage"]
pre session restore time: 0.156366
startup time: 0.236727
first paint time: 0.24323
first paint time: 0.255893
reloading plugin Default.auto_indent_tag
reloading plugin Default.block
reloading plugin Default.comment
reloading plugin Default.convert_syntax
reloading plugin Default.copy_path
reloading plugin Default.delete_word
reloading plugin Default.detect_indentation
reloading plugin Default.duplicate_line
reloading plugin Default.echo
reloading plugin Default.exec
reloading plugin Default.fold
reloading plugin Default.font
reloading plugin Default.goto_line
reloading plugin Default.history_list
reloading plugin Default.indentation
reloading plugin Default.install_package_control
reloading plugin Default.kill_ring
reloading plugin Default.mark
reloading plugin Default.new_templates
reloading plugin Default.open_context_url
reloading plugin Default.open_in_browser
reloading plugin Default.pane
reloading plugin Default.paragraph
reloading plugin Default.paste_from_history
reloading plugin Default.profile
reloading plugin Default.quick_panel
reloading plugin Default.run_syntax_tests
reloading plugin Default.save_on_focus_lost
reloading plugin Default.scroll
reloading plugin Default.set_unsaved_view_name
reloading plugin Default.settings
reloading plugin Default.show_scope_name
reloading plugin Default.side_bar
reloading plugin Default.sort
reloading plugin Default.swap_line
reloading plugin Default.switch_file
reloading plugin Default.symbol
reloading plugin Default.transform
reloading plugin Default.transpose
reloading plugin Default.trim_trailing_white_space
reloading plugin CSS.css_completions
reloading plugin Diff.diff
reloading plugin HTML.encode_html_entities
reloading plugin HTML.html_completions
reloading plugin 0_package_control_loader.00-package_control
reloading plugin 0_package_control_loader.01-ssl-linux
Package Control: Linux SSL: successfully loaded _ssl module for libssl.so.1.0.0
Package Control: Linux SSL: unloading http module so ssl will be available
Package Control: Linux SSL: unloading urllib module so ssl will be available
reloading plugin Emmet.emmet-plugin
Traceback (most recent call last):
File "/opt/sublime_text/sublime_plugin.py", line 109, in reload_plugin
m = importlib.import_module(modulename)
File "./python3.3/importlib/init.py", line 90, in import_module
File "", line 1584, in _gcd_import
File "", line 1565, in _find_and_load
File "", line 1532, in _find_and_load_unlocked
File "/opt/sublime_text/sublime_plugin.py", line 915, in load_module
exec(compile(source, source_path, 'exec'), mod.dict)
File "emmet-plugin in /home/hardillb/.config/sublime-text-3/Installed Packages/Emmet.sublime-package", line 24, in
File "", line 1565, in _find_and_load
File "", line 1532, in _find_and_load_unlocked
File "/home/hardillb/.config/sublime-text-3/Installed Packages/Emmet.sublime-package/emmet/pyv8loader.py", line 20, in
AttributeError: 'module' object has no attribute 'error'
reloading plugin JsFormat.js_formatter
reloading plugin Package Control.1_reloader
reloading plugin Package Control.2_bootstrap
reloading plugin Package Control.Package Control
reloading plugin HTML-CSS-JS Prettify.HTMLPrettify
reloading plugin OmniMarkupPreviewer.OmniMarkupPreviewer
reloading plugin Pretty JSON.PrettyJson
reloading plugin Pretty JSON.PrettyJsonListeners
reloading plugin emmet-sublime-master.emmet-plugin
Traceback (most recent call last):
File "/opt/sublime_text/sublime_plugin.py", line 109, in reload_plugin
m = importlib.import_module(modulename)
File "./python3.3/importlib/init.py", line 90, in import_module
File "", line 1584, in _gcd_import
File "", line 1565, in _find_and_load
File "", line 1532, in _find_and_load_unlocked
File "", line 584, in _check_name_wrapper
File "", line 1022, in load_module
File "", line 1003, in load_module
File "", line 560, in module_for_loader_wrapper
File "", line 868, in _load_module
File "", line 313, in _call_with_frames_removed
File "/home/hardillb/.config/sublime-text-3/Packages/emmet-sublime-master/emmet-plugin.py", line 24, in
import emmet.pyv8loader as pyv8loader
File "", line 1565, in _find_and_load
File "", line 1532, in _find_and_load_unlocked
File "/home/hardillb/.config/sublime-text-3/Installed Packages/Emmet.sublime-package/emmet/pyv8loader.py", line 20, in
import urllib.error as url_err
AttributeError: 'module' object has no attribute 'error'
reloading plugin sublime_diagram_plugin.diagram_plugin
plugins loaded
Viewer Setting: Preview
Loading processor class: <class 'sublime_diagram_plugin.diagram.plantuml.PlantUMLProcessor'>
Detected '/home/hardillb/.config/sublime-text-3/Packages/sublime_diagram_plugin/diagram/plantuml-8024.jar'
Version Detection:
b'PlantUML version 8024 (Sun May 03 16:05:11 BST 2015)\n(GPL source distribution)\nOpenJDK Runtime Environment\nOpenJDK 64-Bit Server VM\n1.7.0_111-b01\nLinux\n\nThe environment variable GRAPHVIZ_DOT has not been set\nDot executable is /usr/bin/dot\nDot version: dot - graphviz version 2.36.0 (20140111.2315)\nInstallation seems OK. File generation OK\n'
PlantUML Smoke Check:
b'The environment variable GRAPHVIZ_DOT has not been set\nDot executable is /usr/bin/dot\nDot version: dot - graphviz version 2.36.0 (20140111.2315)\nInstallation seems OK. File generation OK\n'
Loaded processor: <sublime_diagram_plugin.diagram.plantuml.PlantUMLProcessor object at 0x7f5188d93450>
Loading viewer class from configuration: <class 'sublime_diagram_plugin.diagram.preview.PreviewViewer'>
Unable to load configured viewer, falling back to autodetection...
Traceback (most recent call last):
File "/home/hardillb/.config/sublime-text-3/Packages/sublime_diagram_plugin/diagram/init.py", line 58, in setup
vwr.load()
File "/home/hardillb/.config/sublime-text-3/Packages/sublime_diagram_plugin/diagram/preview.py", line 9, in load
raise Exception("Currently only supported on MacOS")
Exception: Currently only supported on MacOS
Trying Viewer Sublime3Viewer
Loading viewer class: <class 'sublime_diagram_plugin.diagram.sublime3.Sublime3Viewer'>
Loaded viewer: <sublime_diagram_plugin.diagram.sublime3.Sublime3Viewer object at 0x7f5188d93350>
Processors: [<sublime_diagram_plugin.diagram.plantuml.PlantUMLProcessor object at 0x7f5188d93450>]
Viewer: <sublime_diagram_plugin.diagram.sublime3.Sublime3Viewer object at 0x7f5188d93350>
OmniMarkupPreviewer: [INFO] Bottle v0.11.6 server starting up...
OmniMarkupPreviewer: [INFO] Listening on http://<IP_ADDRESS>:51004/
OmniMarkupPreviewer: [INFO] Loaded renderer: TextileRenderer
OmniMarkupPreviewer: [INFO] Loaded renderer: AsciiDocRenderer
OmniMarkupPreviewer: [INFO] Loaded renderer: OrgRenderer
OmniMarkupPreviewer: [INFO] Loaded renderer: PodRenderer
OmniMarkupPreviewer: [INFO] Loaded renderer: RstRenderer
OmniMarkupPreviewer: [INFO] Loaded renderer: MediaWikiRenderer
OmniMarkupPreviewer: [INFO] Loaded renderer: CreoleRenderer
OmniMarkupPreviewer: [INFO] Loaded renderer: RDocRenderer
OmniMarkupPreviewer: [INFO] Loaded renderer: MarkdownRenderer
Package Control: No updated packages

Just as a crazy idea: try to remove Package Control completely from ST and restart editor.

OK, so I uninstalled Package Control and Emmet now works...
reisntalled Package Control and it fails again

Looks like the problem is in urllib modules bootstrapped by Package Control

Package Control for Linux was updated and should fix that issue, please check if it works for you

Looks like you might not need to upgrade.
Try removing ~/.config/sublime-text-3/Installed Packages/0_package_control_loader.sublime-package and restarting ST

After upgrading Package Control and deleting the 0_package_control_loader.sublime-package file, Emmet now works without any errors.

For me (on Linux) the fix was to remove a particular file and restart the application.
mv ~/.config/sublime-text-3/Installed Packages/0_package_control_loader.sublime-package ~/.config/sublime-text-3/Installed Packages/0_package_control_loader.sublime-package.bak

Many thanks to Ildar Khasanshin.

remove 0_package_control_loader.sublime-package file solved my problem.
Many thanks to @hardillb


arch: kernel: lib: toolchain: Standardize TLS keyword

Up until now, the __thread keyword has been used for declaring variables as Thread local storage. However, __thread is a GNU specific keyword which thus limits compatibility with other toolchains (for instance IAR).
This PR intoduces a new macro Z_THREAD_LOCAL which expands to the corresponding C11, C23 or C++11 standard keyword based on the standard that is specified during compilation, else it uses the old __thread keyword.
Signed-off-by: Daniel Flodin<EMAIL_ADDRESS>

Once the various warnings and compliance checks are corrected, I will be happy to give this a +1.

Should I address the clang-format warnings as well?

those are not mandatory for now, but would be nice.

Should I address the clang-format warnings as well?

those are not mandatory for now, but would be nice.

I fix them as well. It looks like you need to re-approve.


Testing gem C API

Is it possible to test the C API of the gem?
I have C API in my mruby-float4 gem:
https://github.com/dabroz/mruby-float4/blob/master/include/mruby/float4.h
and would like to have tests for it using standard gem testing infrastructure, like this (C pseudocode):
mrb_value value = test_execute(mrb, "Vec3.new(1, -2) * 2.5");
mrb_bool result = mrb_float4_vec(mrb, value, &data, &size);
test_assert_equal(result, TRUE);
test_assert_equal(size, 3);
...

But it seems that currently I can have pure Ruby tests in /test, tests for a generated binary in /bintest, but no mixed C & Ruby tests.

your mruby-inline-struct gem (already merged) will be a perfect example of C testing gem.
thank you!


: Allow dialog customization

Currently, <Prompt> only allows defining a dialog text. This allows to create dialogs like the following:
+------------------------------------+
| CONFIRM                            |
+------------------------------------+
| Are you sure you want to quit      |
| without saving your changes?       |
|                                    |
|                [ Cancel ]   [ OK ] |
+------------------------------------+

However, this is bad UI. The user must read the text very carefully to find out what will happen when they click each of the buttons.
The better UI would be something like the following, but this is not currently possible:
+------------------------------------+
| DISCARD CHANGES                    |
+------------------------------------+
| Are you sure you want to quit      |
| without saving your changes?       |
|                                    |
|     [ Keep Editing ]   [ Discard ] |
+------------------------------------+

I'd like to suggest adding more options to <Prompt> to allow customizing this, for example <Prompt title="Discard changes" message="Are you ..." yesmsg="Discard" nomsg="Keep Editing"> or something.
(I know that the default handler for the confirmation dialog is window.confirm, which doesn't support this kind of configuration. But it isn't even possible to pass these kinds of parameters to a custom confirm dialog handler.
Part of this issue is finding a solution for this: either change the default to use a custom confirm function, or ignore the additional parameters in that case – however, this may create the problem that the message can become hard to understand without the according button labels.)

This is a feature of the history library that we use under the hood, so you should ask for this over there.


Market cards for template formatting is currently off

For All sport templates that are using the Estimated scheduled start time, Formatting needs to be on 2 lines(even if the Font size needs to be shrunk on the 2nd line):
Needs to look like this:
yes/no
Will the NY Giants win vs. the New England Patriots by 3 or more points
Estimated schedule start time: Sept 19, 2019 1:00 pm EST
Categorical
Which NFL Team will win:  NY GIants vs New England Patriots
Estimated schedule start time: Sept 19, 2019 1:00 pm EST

don't have control over the formatting of the market title string. it's just a string.

NO...was just showing the templated market under each market type

did we get fixed?

this has been done, templates with estimated scheduled date time is formatted in 2 lines


Feature request: soft delete by default, and force option

For distructive operations such as removing or syncing (which can remove), it would be nice if, by default, deletes were not done if anything is using that label. The label not deleted should be reported back so the user can investigate. Possibly would want to add a "force" option to override this function.

Hi @Relequestual,
Thank you for taking the time to submit this feature request. I really appreciate the input and the value it adds to the project.
I can see the merit in this proposal and understand the importance of avoiding destructive operations when labels are still in use. When I initially built the project, my assumption was that it would only be a single user(me) and that it would only be used on new projects.
However, I am currently tied up with other commitments and will not be able to address this immediately. Rest assured that I'll revisit this feature request once things settle down.


Wrong miss block count if validator is jailed

If the validator is jailed, it should not be included in the miss block count.

fixed in https://github.com/forbole/big_dipper/commit/2a240589dfd8fee364fb15bab40921bbf01bbad2


CY-495: Add more context for tampered the process alert

Just ensure the related alerts on forensics page works without issue.


docs: fix misspellings

Add @mrmaster009 as a contributor
docs: fix misspellings

Add @mrmaster009 as a contributor

I don't see this anywhere. Do you want to add this?

It was a very old commit in another branch. That guy is in the contributors list now.


The Text component can not flat wrap.

Environment
[skip envinfo]
Description
I tried to show a URL by the Text component. But it wraps with huge blank on the right of the component. I have read all the doc but can not find any props to configure it.

Reproducible Demo
It does not need any reproducible demos.

Duplicate of #1438


Panic with vdso mapping

Regarding the panic, it occurs at if l.Location.Mapping.File == "[vdso]" { ... } https://github.com/parca-dev/parca-agent/blob/main/pkg/symbol/symbol.go#L82. The mapping is nil for some reason &{ID:24 Mapping:<nil> Address:85858880 Line:[] IsFolded:false mappingIDX:0}.
Originally posted by @marselester in https://github.com/parca-dev/parca/pull/2955#discussion_r1195316691

Should be fixed.


update async-http-client

Description
Update org.asynchttpclient:async-http-client from 2.5.3 to 3.0.1 to address CVE-2024-53990
Release note
Update org.asynchttpclient:async-http-client from 2.5.3 to 3.0.1 to address CVE-2024-53990
This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[x] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Thanks for the fix, @janjwerner-confluent !
The license checks are failing, you might need to update licenses.yaml file.

closing, missed #17578


PHP 7.1 Error

Hi,
I tried make a library for PHP 7.1 and got a error.
I tried this in two different Systems:

PHP 7.1.10-1+0~20170929170818.9+stretch~1.gbp501135 (cli) (built: Sep 29 2017 17:08:20)
OS:
Linux c026bfe236a2 4.4.0-87-generic #110-Ubuntu SMP Tue Jul 18 12:55:35 UTC 2017 x86_64 GNU/Linux

Distributor ID:	Debian
Description:	Debian GNU/Linux 9.1 (stretch)
Release:	9.1
Codename:	stretch
2)PHP 7.1.10-1+ubuntu16.04.1+deb.sury.org+1 (cli) (built: Sep 29 2017 17:04:25)
OS:
Linux ubuntu 4.4.0-62-generic #83-Ubuntu SMP Wed Jan 18 14:10:15 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.2 LTS
Release:	16.04
Codename:	xenial
Error:
/usr/sap/nwrfcsdk/php7-sapnwrfc/sapnwrfc.c: In function 'zim_Connection_getAttributes': /usr/sap/nwrfcsdk/php7-sapnwrfc/sapnwrfc.c:377:121: error: 'RFC_ATTRIBUTES {aka struct _RFC_ATTRIBUTES}' has no member named 'partnerBytesPerChar'      add_assoc_str(return_value, "partnerBytesPerChar", sapuc_to_zend_string(attributes.partnerBytesPerChar));                                                                                ^ /usr/sap/nwrfcsdk/php7-sapnwrfc/sapnwrfc.c:378:125: error: 'RFC_ATTRIBUTES {aka struct _RFC_ATTRIBUTES}' has no member named 'partnerSystemCodepage'; did you mean 'partnerCodepage'?      add_assoc_str(return_value, "partnerSystemCodepage", sapuc_to_zend_string(attributes.partnerSystemCodepage));                                                                                ^ /usr/sap/nwrfcsdk/php7-sapnwrfc/sapnwrfc.c: In function 'zim_Connection_setTraceDir': /usr/sap/nwrfcsdk/php7-sapnwrfc/sapnwrfc.c:548:10: warning: implicit declaration of function 'RfcSetTraceDir' [-Wimplicit-function-declaration]      rc = RfcSetTraceDir((path_u = zend_string_to_sapuc(path)), &error_info);           ^~~~~~~~~~~~~~ /usr/sap/nwrfcsdk/php7-sapnwrfc/sapnwrfc.c: In function 'zim_Connection_setTraceLevel': /usr/sap/nwrfcsdk/php7-sapnwrfc/sapnwrfc.c:578:10: warning: implicit declaration of function 'RfcSetTraceLevel' [-Wimplicit-function-declaration]      rc = RfcSetTraceLevel(NULL, NULL, level, &error_info);           ^~~~~~~~~~~~~~~~ In file included from /usr/sap/nwrfcsdk/include/sapnwrfc.h:9:0,                  from /usr/sap/nwrfcsdk/php7-sapnwrfc/exceptions.h:10,                  from /usr/sap/nwrfcsdk/php7-sapnwrfc/sapnwrfc.c:21: At top level: /usr/sap/nwrfcsdk/include/sapuc.h:840:24: warning: 'sccsidU16' defined but not used [-Wunused-variable]    static const SAP_UC* sccsidU16 = NULL;                         ^~~~~~~~~ Makefile:194: recipe for target 'sapnwrfc.lo' failed make: *** [sapnwrfc.lo] Error 1

Which version of the NetWeaver SDK do you use?

Version => 1.1.2
SAP NW RFC SDK => 7.11.0

I have never tried to build the extension with a RFC SDK version < 7.20.. I'll have a look when I find some free time. In the meantime you can try to comment out the offending lines, but YMMV.

I will try to make the inclusion of those members conditional on their existence.

You can try the latest version from master, it should build without error. Make sure to run make test after a successful build.

Thank you.
I had a Problem with sapnwrfc.c too. Functions partnerBytesPerChar & partnerSystemCodepage does not exist. (see my commit https://github.com/vlobovikov/php7-sapnwrfc/commit/d60902d8c598060dee86a959b66449d6cbda3de1 file sapnwrfc.c)

I tried with SDK version 7.11. partnerBytesPerChar exists for me. But we can easily add a check for it as well.

Perfect! Thank you very much.
It works now!


Extractor yaml files should have mount options

Especially when using larger machine learning models (i.e. from huggingface), mounting a drive to the local huggingface cache will be useful. An optional "mount" parameter in the model yaml file could be a good way to implement this

Instead (or in addition to) of an mount option, we could also accept another input file to accept an extension to a Dockerfile (which uses the FROM diptanu/indexify-base-extractor base image)


lrpmctl colors argument; dependencies refactoring

added support for color argument in lrpmctl
moved table formatting to TextTableFormatter, ANSI sequences to TerminalPalette

Ikarred der zee ze treffend SSA z de strydr

Apologies. My phone was in my pocket and apparently typed all that spontaneously. 🥶

No worries :smiley:


Default layout index new theme

Sumary
I noticed that the index pages that are in the new_theme branch are not following a pattern.
Here are my considerations:
Pictures

Broken alignment of the export and new buttons. And filter and clear filter below select.

2) Buttons new and export aligned with Filter.

3) filter and clear filter buttons aligned with select.
Which is the correct way?

Thanks for pointing this out! I think we those were submitted there were varying patterns for the filtering. Do you want to take this on or should I make a new issue for it?

@armahillo ☝

@rodrigovirgilio Either the second or third one would be fine. I like the third one, @mdworken likes the second one.
What're your thoughts?
The filter console should be attached to the collection, to communicate that relationship. The additional form controls could be nearby, like in the third example. I'm not completely sure which one would be best.
But definitely not the first one. :)

@armahillo I prefer the third image too.

@rodrigovirgilio Sounds good! We can always tweak / change later if we need to.
Thank you!


pnpm android errors out with package name

Summary:
pnpm android errors out.
Steps to reproduce:
do  pnpm android
Expected behavior:
Android should build and run on emulator
Additional notes:
Please read this comments from expo change
https://github.com/expo/expo-cli/commit/a1b565e081c6ec20ef00965a50463cc1ef89e15b
(base) ➜  project-test-rn git:(main) ✗ npx expo --version
0.17.8

(base) ➜  project-test-rn git:(main) ✗ pnpm android

><EMAIL_ADDRESS>android /Users/d/workspace/project-test-rn
> cross-env EXPO_NO_DOTENV=1 expo run:android

AssertionError [ERR_ASSERTION]: Invalid format of Android package name. Only alphanumeric characters, '.' and '_' are allowed, and each '.' must be followed by a letter. The Java keyword 'native' is not allowed.
 ELIFECYCLE  Command failed with exit code 1.

Tasks

Repo should initialize .env files with example pakcage name or in eas configs.     com.obytes.app

Please make sure to read the note related to android project naming https://starter.obytes.com/getting-started/create-new-app/
Apparently the app name is not valid as it contains -.


Is RetroNAS required or can I use TrueNAS or other NAS?

I've gone through the docs a few times and don't understand how it works. It says in the docs that it works with the MiSTer FPGA, but it doesn't say how:

Is RetroNAS doing something special? Can you list in the docs the protocol you need to use to be compatible with these systems such as the MiSTer FPGA with a link to their setup docs?
From what I'm seeing in videos, this is a NAS with lots of protocols, but I'm not sure how the MiSTer is supposed to access it. In every video on the MiSTer, everyone's using microSD cards, not SMB or NFS shares, so I'm not sure how this is supposed to work just from the docs and some RetroRGB videos I saw.

RetroNAS simplifies this installation for the users of RetroNAS, RetroNAS is not required for loading MiSTer data across a network.
MiSTer uses cifs (smb/samba), this is documented (at a minimum) in the playbook where it installs configuration and restarts the samba service pointing at our configured MiSTer directory.
if you want to setup a samba share on some other NAS product you can do so but refer to that products documentation.
Our documentation for MiSTer covers the MiSTer side of the configuration to connect to the samba share refer to https://github.com/danmons/retronas/wiki/MiSTer-FPGA#MiSTer-FPGA-configuration you can follow this and point it at your alt NAS product once your share is setup.
This repo and doco we have here is for the RetroNAS project, if you want to understand how to integrate MiSTer on a specific alt product please ask on their support channels.

everyone's using microSD cards, not SMB or NFS shares

https://www.retrorgb.com/introducing-retronas.html


Support datetime type

The types include time and date, but it doest not support datetime format
For example,  "Coupon expires at {expires, datetime}" are supposed to be "Coupon expires at 4/13/2017 22:33:50"

Any idea?

You can define a custom format using the options from Intl.DateTimeFormat

@longlho any example?


Reduce size of installed package

This is > 5 MB, primarily due to all of the test snapshots in inst/tinytest.
As per R CMD check:
❯ checking installed package size ... NOTE
    installed size is  7.5Mb
    sub-directories of 1Mb or more:
      doc        3.0Mb
      help       1.5Mb
      tinytest   2.9Mb

Can we retain the GitHub testing infrastructure but skip it on CRAN? This is something that I don't have experience with, but I imagine there's a simple workaround.

@vincentarelbundock writes (original comment)

To skip on CRAN, I set an environment variable on the GitHub workflow and on my computer. Then, at the top of the test script I check if the flag is set with Sys.getenv and call tinytest::exit_file() if not.

That's a cool idea. But we would still need to manually add inst/tinytest/_tinysnapshot to .Rbuildignore before submission, right?

Yep, or you could skip all the tests

I do a palettize of all image files after generation by the package, it's a bit crufty but it worked (using magick):
https://github.com/hypertidy/ceramic/blob/052b5f3e7608efa472d2ab0f84112f7ea4d5f625/README.Rmd#L230

I do a palettize of all image files after generation by the package, it's a bit crufty but it worked (using magick)

That's interesting, thanks @mdsumner. I'm not sure whether it will work with the tinysnapshot testing workflow but I'll investigate when I get back to this.

@vincentarelbundock Do you mind taking a crack at this if you already have some boilerplate ENV VAR logic lying around?
(I'm still not quit sure how skipping the tests will get us around the snapshots if they're already bundled in inst . Probably just missing something obvious.)

The process is kind of annoying, but this is what I do:

Add this to my local .zshrc or equivalent: export R_NOT_CRAN=true
Add a similar thing to Github workflow
In tests/tinytest.R, add some logic to skip tests based on the environment variable using Sys.getenv()
Before releasing to CRAN, add inst/tinytest/_tinysnapshot to .Rbuildignore

The last step is manual and should not be forgotten, which is not ideal.

If you're fine with this workflow, I'll prep a PR

An additional thing that might consider doing here is not building the vignette(s).

Honestly, I think I've come to the conclusion that package vignettes are not a good vehicle for tutorials when there are lots of visual elements and complex content. My simple packages have vignettes but those with more scope have a website.

You just add them to .Rbuildignore right? Do you have to make any adjustments to your altdoc CI workflow to get the website rendering to work properly?

Yes, right. No, altdoc does not consider .Rbuildignore so everything in vignettes/ gets built.

Great, let's do that then. I'll add this, then take a proper look at #128 too once I get time. (Slammed with work deadlines before I head out for an extended spring break...)

What @vincentarelbundock sketches above works, but there are other possible (related) ways.
We could for example tie it up from the other end and start with the dreaded 'manual' tweak to .Rbuildignore and have that driven by a script (calling an R helper function you could call from R too) which

temporarily adds the skip instruction to .Rbuildignore
builds the release tarball
removes the temporary instruction

If we take that as a given it becomes easier / cleaner to condition the tests. You can now check via dir.exists() if snapshot filess are present, and if not skip (even explicitly via tinytest::exit_file("message here") which I do a lot).
You could also hook the call to the temporary modification into cleanup.
There are other ways.  For example GitHub has a boatload of environment vars including the standard CI (as most/all CI systems have) but also GITHUB_ACTIONS so you could use that to (at GitHub only) not skip etc.
Anyway, feel free to ignore, just trying to help if I can to shepherd this to CRAN.   (Also: 5mb is AFAIK not a  hard constraint but I also haven't submitted a new 'yuge' package in a while...)


Doesn't work when strict mode (ng-strict-di) is enabled

I have angular's strict mode enabled for dependency injection (ng-strict-di), but I get an error controller is not using explicit annotation and cannot be invoked in strict mode. If I disable strict mode, it works just fine. Is it possible to make it work with strict mode enabled? Here is my code:
<!DOCTYPE html>

        ...

        <horizontal-timeline
                start-date="2016-08-27"
                end-date="2016-12-27"
                events="[{'date':'2016-10-20','content':'
lorem ipsum
'},{'date':'2016-11-03','content':'
lorem ipsum
'}]">
        </horizontal-timeline>

Thank you!

Great! Thank you, @eowo!


Test patch job

The Run Patch Job is failing. It succeeds on my local setup. Not sure why this could be happening.


Adds observability use case doc

Product Version(s):

Issue:

Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

Comments picked from #1449


Error Ban.Profile#getCreationDate()

Ban.Profile#getCreationDate() return the value of Ban.Profile#getExpirationDate().
There is an error in the UserListBansEntry :

Looks like a mistake in vanilla.
I quickly tested by getting the vanilla server to convert an old banned-players.txt file to the new format because it calls this constructor.
simon8162|2016-01-01 12:00:00 GMT|admin|2018-01-01 12:00:00 GMT|reason

[
  {
    "uuid": "48708698-b1b1-43f2-908d-5383bbaa27bb",
    "name": "simon8162",
    "created": "2018-01-01 12:00:00 +0000",
    "source": "admin",
    "expires": "2018-01-01 12:00:00 +0000",
    "reason": "reason"
  }
]

"created" should be 2016-01-01 12:00:00 +0000 but is instead 2018-01-01 12:00:00 +0000

I opened an issue on Mojang.
https://bugs.mojang.com/browse/MC-112684

This issue can now be resolved using Mixin 0.6.12 using the new ModifyArgs injector.


Twitch fails to download if stream requires subscription

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2022.02.04. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Italy
Description
The Twitch stream fails to download if it requires subscription.
The output says:

report this issue on  https://github.com/yt-dlp/yt-dlp , filling out the "Broken site" issue template

and doesn't allow me to insert login and password for the user who is subscribed to the channel.
Verbose log
$ yt-dlp -vU https://www.twitch.tv/videos/1305275390
[debug] Command-line config: ['-vU', 'https://www.twitch.tv/videos/1305275390']
[debug] Encodings: locale UTF-8, fs utf-8, out utf-8, err utf-8, pref UTF-8
[debug] yt-dlp version 2022.02.04 [c1653e9ef]
[debug] Python version 3.10.2 (CPython 64bit) - Linux-5.16.9-200.fc35.x86_64-x86_64-with-glibc2.34
[debug] exe versions: ffmpeg 4.4.1 (setts), ffprobe 4.4.1
[debug] Optional libraries: Cryptodome, secretstorage, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2022.02.04, Current version: 2022.02.04
yt-dlp is up to date (2022.02.04)
[debug] [twitch:vod] Extracting URL: https://www.twitch.tv/videos/1305275390
[twitch:vod]<PHONE_NUMBER>: Downloading stream metadata GraphQL
[twitch:vod]<PHONE_NUMBER>: Downloading video access token GraphQL
[twitch:vod]<PHONE_NUMBER>: Downloading m3u8 information
ERROR: [twitch:vod]<PHONE_NUMBER>: Failed to download m3u8 information: HTTP Error 403: Forbidden (caused by <HTTPError 403: 'Forbidden'>); please report this issue on  https://github.com/yt-dlp/yt-dlp , filling out the "Broken site" issue template properly. Confirm you are on the latest version using -U (caused by <HTTPError 403: 'Forbidden'>); please report this issue on  https://github.com/yt-dlp/yt-dlp , filling out the "Broken site" issue template properly. Confirm you are on the latest version using -U
  File "/home/raffaele/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 730, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/home/raffaele/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 3558, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib64/python3.10/urllib/request.py", line 525, in open
    response = meth(req, response)
  File "/usr/lib64/python3.10/urllib/request.py", line 634, in http_response
    response = self.parent.error(
  File "/usr/lib64/python3.10/urllib/request.py", line 563, in error
    return self._call_chain(*args)
  File "/usr/lib64/python3.10/urllib/request.py", line 496, in _call_chain
    result = func(*args)
  File "/usr/lib64/python3.10/urllib/request.py", line 643, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)

yt-dlp can't bypass paywalls. If you have access to the video, pass cookies (and show verbose log with it)

yt-dlp can't bypass paywalls. If you have access to the video, pass cookies (and show verbose log with it)

Fine, but then the error message should say to pass cookies to it, not to report it as a bug

then the error message should say to pass cookies to it, not to report it as a bug

It does not seem possible to differentiate (from the API) b/w actually being unable to extract formats and the video being private

It does not seem possible to differentiate (from the API) b/w actually being unable to extract formats and the video being private

I think the relevant information is contained in the value field of the access token:
https://github.com/yt-dlp/yt-dlp/blob/5424dbaf91728aaf77458e68d993ba6c34e8e222/yt_dlp/extractor/twitch.py#L518
{'value': '{"authorization":{"forbidden":false,"reason":""},"chansub":{"restricted_bitrates":["160p30","360p30","480p30","720p60","audio_only","chunked"]},"device_id":null,"expires":xxx,"https_required":true,"privileged":false,"user_id":null,"version":2,"vod_id":xxx}', 'signature': 'xxx'}

specifically this part
"chansub":{"restricted_bitrates":["160p30","360p30","480p30","720p60","audio_only","chunked"]}

I'm not sure if it's possible for only some bitrates to be restricted, so downloading the m3u8 still should be attempted in this case. But I think this information can be used to print a more helpful error message.


Create multiple clients for multiple endpoints

I developed an app that connects to multiple services. how do I set up the creation for numerous clients? I can't figure out how to split the configuration in various builds in the same project.

Hi @SergeBerwert !
According current implementation, you can do the next:
You can just create several clients with different parameters (baseUrl, interceptors etc.) and use multiple clients.
final client1 = MyService.create(....);
final client2 = MyService.create(....);
etc...
But better way to use just one client. You can set baseUrl as a --dart-define parameter and use different baseUrl for different builds with the fully same code base.
Please, reopen the issue if I did not answered fully to your question :) Will be happy to help!


Cannot download app to some devices

From the Android Market: This item is not compatible with your device.
Shown on at least two: Samsung Galaxy Mini and Samsung Galaxy Tab.

Deployed to market in version 1.2


Echo build warnings in summary

Resolves #9
However I was not able to reproduce the warnings referred to in the issue: https://github.com/TeachBooks/Macaulays_method/actions/runs/8800322111/job/24151269724#step:6:60
See build https://github.com/TeachBooks/Macaulays_method/actions/runs/8833021565/job/24251471364#step:6:73 from an adjacent branch (now deleted)

Seems to work nice, I tested it here: https://github.com/TeachBooks/Sandbox/actions/runs/8833302145


Add noop system chain code.

Add noop system chain code
Description
Noop system chain code simply stores invoke transactions without validation. This chaincode is useful for testing. The noop system chaincode is prepared to work with fabric-api
Motivation and Context
Preparation for performance tests.
How Has This Been Tested?
run unit tests
Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[ ] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Tamas Blummer<EMAIL_ADDRESS>

@tamasblummer Since this scc is for testing, I'd suggest putting the code in bddtests/chaincode/go or bddtests/syschaincode/go, not in the base code, and default build should not pick up this code.
We need to think about build options for various needs, so that one may build with certain scc's or configuration features.

@tamasblummer @binhn Any conclusion regarding Binh's comments above about the code location?

reverify jenkins

@ghaskins @binhn could not find suitable means of passing in test specific configuration to behave test. @gabre is working on an other pull request that makes easy to specify configuration for tests, so this chain code can be moved to bddtests and also tested.

@tamasblummer @ghaskins @binhn I have this "draft": https://github.com/gabre/fabric/commit/00b1a68a16a47a5d91e062324abf1c666b120224

The check fails because the CI server starts behave tests not from bddtests (as I have done on my machine) but from some other location so it is unable to find the alternative core.yaml which would deploy noop syscc. The questions is how we could work this around in an elegant way. E.g. we could use absolute path for the config location path but... my opinion is that this wouldn't be the best... Any suggestions?

Let's hold off merging this until @muralisrini provides a fix for #1741, which will change the genesis block spec in the yaml file, effecting this PR.  Thanks.

There is a failing test: peer_basic.feature:516 which is a known bug as far as I know: https://github.com/hyperledger/fabric/issues/1820

@tamasblummer would you mind rebasing to resolve merge conflicts? Apologies for the delay in getting this merged.

@christo4ferris I rebased it. But this introduces some problems which were already solved but now need some other solution. System chain codes need to be switchable/configurable but the current implementation uses chain codes wired into the source so it is determined at build time which ones will be deployed. This makes it very hard to have our noop chain code switched off by default and also test it using bdd tests (because a bdd test can't build its own fabric, it has to use a prebuilt one).

@binhn @muralisrini @tamasblummer @gabre please get together on this and develop an approach that allows syscc to be used in the manner that Tamas and team require. Maybe we need to have a third class e.g. inlinecc or something. Whatever. We need to work together on this. @mastersingh24

I see the following possibilities:

add a section to the configuration where system chain code can be enabled/disabled (as it was before)
enable noop syscc by default (this would be not so good as it is not needed by everyone)
It is nearly sure that the first option is the better. But why was the system chain code configuration removed (from core.yaml)? @binhn @muralisrini @christo4ferris

Sorry for joining the party late here.  Which of the several problems do we want to solve first?
I've probably missed variations of this pull request due to changes in both the PR as well as the fabric.
Here are my observations:

I am no expert on Behave, but as far as I can tell it seems that all Behave tests use the various compose files to start up one or more peers

All of those use the hyperledger/fabric-peer as their Docker image

hyperledger/fabric-peer appears to be built before ever running Behave tests so unless code / config is enabled / available by default in the src tree, I don't see within the current structure of tests you would ever be able to test optional system chaincode within Behave unless the code is compiled as part of building the hyperledger/fabric-peer image

I still need to understand more about the options for syscc configuration in the latest code...but one comment I have related to @mastersingh24's last post is that if the issue is purely one of available docker image, we could trivially add a new one to the roster that is configured however this test needs it.  I could work with @gabre @tamasblummer if that is deemed the right direction.

@gabre to first answer your question as to why sys chaincode was removed from the genesis block in the yaml, please see #1854.
Given that syscc have to be "baked into" the system, registering programmatically makes it hardest to change peers and prevent divergence. However it does cause problems for creating special peers (such as for testing).
I'd second @ghaskins suggestion to create a special image with noops baked into it. Is that an option ?
Would it further help if we move the following from importsyscc.go into its own file (say "systemchaincodes.go") ?
//see systemchaincode_test.go for an example using "sample_syscc"
var systemChaincodes = []*api.SystemChaincode{}

It would separate the defined sys cc's into its own file so you can simply replace systemchaincodes.go file before image generation without modifying importsyscc.go itself.
(As an aside, I miss "class loading"....)

@muralisrini I understand the motivation to get rid of the ctor from the yaml and to make things more flexible than requiring genesis inclusion...but I am wondering if, given golang's relative inflexibility in this regard, we would be best served to still retain a notion of something like a whitelist in the yaml.  Whereby syscc can be compiled in and registered, but it will only be loaded if the whitelist includes it.  That way, local admins can decide what they want to include and we can opt to disable certain testing-related things by default.  Thoughts?

@ghaskins @muralisrini "a whitelist in the yaml" From my point of view (without a total understanding of the details) this would be the same as it was before: importsyscc (syscc baked into the peer binary) + yaml together decide, which code will be deployed. This way, noop syscc could be included in importsyscc but it would not be included in that yaml/whitelist. This would make it a lot easier to test (This is very similar to the way it worked before @mastersingh24 - this is how I tested it) as I have already implemented some functionality to make the config yaml replacable if it is needed (I used an ENV for that as that was the easiest way to solve this problem).

OK - this is going in circles for no real reason.  Totally agree that we should figure out some better options for system chaincode inclusion and deployment moving forward, but given that we have to stop making tactical changes, is there any reason why we really have to have BDD tests for this at all?  If it passes the unit tests, what purpose do the BDD tests serve in this case?

agree with @mastersingh24 on principle, but the problem is that it will break all subsequent builds. Is there a specific behave test(s) we can disable to get this merged?

@mastersingh24 @christo4ferris We should not include this or any other system chain code without an explicit whitelisting in configuration. Whitelisting would also solve the problem of testing, provided configuration can be read from an argument instead the current rather complicated on-the-fly-edit process.

@tamasblummer   -  just to doublecheck - so you want to make sure that even if the system chaincode is compiled in the peer executable that it is not actually "registered" with the system unless explicitly in a whitelist?
That seems okay to me.  This should be outside the previous list which was used as part of the genesis  block (which is I think why it was removed)
@gabre  - is this something you can do?  sounds pretty straightforward and looks like you know how to do it

@mastersingh24 yes that is what I mean. User should not be exposed to a chaincode just because it is compliled in (that is a technical necessity) but only if it is explicitly whitelisted.
The config needs rework, such that it is easy to start a peer with different config (as argument) and not do some on-the-fly edit of a single config as is now. This however is stuff for yet another pull request. For now please fix however you feel fit temporarily, provided we get this merged.

Agree config and so forth can be separate PR; but we need to resolve the build issues... can we disable the behave tests that are failed by this so that post merge we don't have everyone with a failing build? Also, we need an issue to track so we can be sure to restore those skipped tests before we cut another release.

I'm good with whitelist too. For production envs it seemed registering via code provided strictest way to control changes but it does make it hard for dev/test. Also when we enable system chaincode for security (#1964) we could factor in the whitelist.
@cbf just took a quick look at the failures.... while agree we should disable the behave tests while working on whitelist, none of the failures above are related to that I think.
The travis seems to have stopped during build time at
g++ -DHAVE_CONFIG_H -I. -I..  -I./../gmock/gtest/include -I./../gmock/include  -pthread -DHAVE_PTHREAD=1  -Wall -Wwrite-strings -Woverloaded-virtual -Wno-sign-compare -g -DNDEBUG -MT google/protobuf/stubs/protobuf_test-stringpiece_unittest.o -MD -MP -MF google/protobuf/stubs/.deps/protobuf_test-stringpiece_unittest.Tpo -c -o google/protobuf/stubs/protobuf_test-stringpiece_unittest.o `test -f 'google/protobuf/stubs/stringpiece_unittest.cc' || echo './'`google/protobuf/stubs/stringpiece_unittest.cc
In file included from ./../gmock/gtest/include/gtest/gtest.h:1929:0,
                 from google/protobuf/stubs/stringpiece_unittest.cc:40:
google/protobuf/stubs/stringpiece_unittest.cc: In member function 'virtual void google::protobuf::{anonymous}::StringPiece_ComparisonOperators_Test::TestBody()':

The jenkins failures have the same signature we saw when running unit tests in parallel (which should have been fixed in PR #1930)

07:29:52 panic: Could not open openchain db error = [IO error: lock /var/hyperledger/test/tmpdb/db/LOCK: Resource temporarily unavailable] [recovered]
07:29:52 	panic: Could not open openchain db error = [IO error: lock /var/hyperledger/test/tmpdb/db/LOCK: Resource temporarily unavailable]
07:29:52

I have temporarily removed the test and added https://github.com/hyperledger/fabric/issues/1967

Are Jenkins check errors to be expected?

Yes, Jenkins is still a work in progress. It's best to rely on Travis results for now. I'm not sure why Travis is not showing up in this PR. @rameshthoomu do you have any ideas?

@srderson : I am working on this. Will let you know the reason.

Discussed PR this morning in the Fabric maintainers issue. Two issues

No documents
How is the system chaincode enabled/disabled? Is this part of the build process or is this a whitelist? @muralisrini and @ghaskins are investigating. Do we need a new issue opened?

@srderson @muralisrini @tamasblummer I have rebased the change and added a whitelist functionality. Please check the md file I added (and the directory structure). Any comments, suggestions are welcome.

Waiting for @muralisrini to review whitelist functionality.

reverify jenkins

@gabre LGTM with a proviso.
As mentioned in the inline comment, it might make sense to create a separate file for the whiltelist to be read in at startup as opposed to making it a part of core.yaml along with other properties. File content could be used in implementation of #1964.

Thanks @gabre and @muralisrini! LGTM


assertion pass when it should'nt

As you can see in the screenshot, the answer should pass when the result contains 72,
but gpt4 answers 73, which is not the expected value.
Maybe a mix between string and number but it's confusing.

damn yaml, I missed a tab and the assertion was seen as a variable...
sorry for the noise

yaml problems :(  it happens


fix: remove adsense.v1.4.json

It is recommended to use adsense v2

Wait until the release freeze ends on January 4, 2022.


Spanner client lib doesn't have read-only transaction via transaction manager

will also need to make a ticket for client lib team. this issue is a reminder for us to incorporate the fix if/when it happens.

https://github.com/GoogleCloudPlatform/google-cloud-java/issues/3666

closing due to https://github.com/spring-cloud/spring-cloud-gcp/issues/1026 . there is a readonly context but it comes from the databaseclient rather than the transaction manager.


[ButterflyAspect] Bugfixes

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

fixed incorrect calculation of negative modifiers
armor calculation corrected
typo with the attack macro
js optimized

Character Sheet Info Roll20 Internal Use only.


Math for the second circle graph?

On the Project screen for an Active Project (the one with the two circle graphs), what is the math being used for the second "Time Remaining" graph? The only thing I can think of is: (currentDate - startDate) / (endDate - startDate)

https://github.com/projectjellyfish/api/blob/fix-poltergeist-login-issue/app/assets/javascripts/projects/project_controller.js#L167 It's an estimate based on remaining budget and monthly expenditures.


Feature/text instructions

The 'MarkDownView ' dependency was added to handle the text instructions

Any updates on this?


Typo errors in Adding and configuring a service provider

Suggested Labels
Type/Docs
Priority/Normal
Affected/5.5.0-Alpha3
Description
There is a statement as "Under This topic contains the following sections" in [1]
There remove the bullet points which does not have a content included.
[1]. https://docs.wso2.com/display/IS550/Adding+and+Configuring+a+Service+Provider

removed the unnecessary bullet points.


Integrate virtualbmc in libvirt_manager

This patch allows to configure the virtualbmc service and inject all of
the created virtual machines in it.
Since we want to get only one instance of virtualbmc, even in a
multi-hypervisor layout, we have to be sure to properly target the one
hosting the OpenShift services, being OCP cluster or single CRC.
This patch also remove a duplicated call to the
libvirt_manager/clean_layout tasks from the devscripts role.
This patch also correct some indempotency issues in virtualbmc,
preventing a nice integration.
Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/1284
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running

recheck

recheck

/test all

recheck

/retest-required

This latest iteration also produces a nice file we'll then be able to push in the controller-0 (like we do for some others) listing the known VBMC nodes, the IP address, port and credentials:
[virtuser@builder2 ~]$ cat ci-framework-data/artifacts/virtualbmc-nodes.yml
cifmw_virtualbmc_known_hosts:
-   Address: <IP_ADDRESS>
    Domain name: cifmw-compute-0
    Port: 6240
    Status: running
    password: password
    username: admin
-   Address: <IP_ADDRESS>
    Domain name: cifmw-controller-0
    Port: 6241
    Status: running
    password: password
    username: admin
-   Address: <IP_ADDRESS>
    Domain name: cifmw-crc-0
    Port: 6242
    Status: running
    password: password
    username: admin

instackenv.json is dead, long live instackenv.json :rofl: !

recheck

/approve


Start: createServerFn cannot return raw response objects

Which project does this relate to?
Start
Describe the bug
Server functions should able to return Raw Response objects.
Your Example Website or App
https://github.com/nekochan0122/tanstack-start-return-response-object
Steps to Reproduce the Bug or Issue

Open the dev server
Click the "Trigger serverFn" button
See the console output and cookies

Expected behavior
const serverFn = createServerFn({ method: "POST" }).handler(async () => {
  return new Response(JSON.stringify({ hello: "world" }), {
    status: 200,
    headers: {
      "Content-Type": "application/json",
      "Set-Cookie": "test=test",
    },
  });
});

The console output is expected to contain { hello: "world" }
The cookie should be set to test=test

Screenshots or Videos
No response
Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

a temporary solution:
import { getEvent, setHeaders } from 'vinxi/http'

async function handleResponse<ResponseBody = unknown>(response: Response): Promise<ResponseBody> {
  const event = getEvent()

  setHeaders(event, Object.fromEntries(response.headers))

  switch (response.headers.get('Content-Type')) {
    case 'application/json':
      return await response.json() as ResponseBody

    default:
      return response.body as ResponseBody
  }
}

Tried https://discord.com/channels/719702312431386674/1310732156561260575/1310785299915346100
const exampleStreamingFn = createServerFn({ method: 'GET' }).handler(async () => {
  const encoder = new TextEncoder();

  // replace with ur actual stream
  const stream = new ReadableStream({
    async start(controller) {
      for (let i = 0; i < 10; i++) {
        const chunk = encoder.encode(`${i + 1}`);
        controller.enqueue(chunk);
        await new Promise((resolve) => setTimeout(resolve, 100));
      }
      controller.close();
    },
  });

  const res = new Response(stream, { status: 200 });

  return sendWebResponse(getEvent(), res);
});

and https://discord.com/channels/719702312431386674/1310732156561260575/1310785660948578355
const res = await fetch(exampleStreamingFn.url);

Which got streaming kindof working, but after stream is done im getting.
ServerFn Response: 200
 - Payload: {"result":{"$undefined":""},"context":{}}

node:_http_outgoing:699
    throw new ERR_HTTP_HEADERS_SENT('set');
          ^

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at ServerResponse.setHeader (node:_http_outgoing:699:11)

and then vinxi crashes and I need to restart the server


Keyboard Shortcut to open terminal

Description of the new feature/enhancement
"I would like to bring attention to a potential enhancement for the Windows Terminal app on Windows 11. Currently, Windows Terminal does not provide native support for creating keyboard shortcuts to open the terminal directly. While users can resort to alternative methods such as creating desktop shortcuts or using the Task Scheduler to achieve this, it would greatly improve user convenience and accessibility if the Windows Terminal application itself had a built-in feature to assign and manage custom keyboard shortcuts for launching the terminal. This enhancement would streamline the user experience, aligning with the user expectations and providing a more integrated and user-friendly approach to accessing the terminal on Windows 11. I believe this improvement would contribute to the overall usability of the Windows Terminal and enhance its functionality for users who prefer quick keyboard access to the terminal application."
Proposed technical implementation details

Shortcut Configuration UI:

Introduce a new section in the Windows Terminal settings dedicated to keyboard shortcuts.
Within this section, provide a user-friendly interface allowing users to configure and customize keyboard shortcuts for opening the terminal.

Configuration Storage:

Implement a mechanism to store and manage user-defined keyboard shortcuts within the Windows Terminal's configuration settings.
Consider using a JSON or similar configuration file to store the key bindings and associated actions.

Integration with Task Scheduler:

Enhance the Windows Terminal application to dynamically register itself with the Task Scheduler during installation.
When a user defines a custom keyboard shortcut within the Windows Terminal settings, the application should register a corresponding task with the Task Scheduler.

Task Execution:

Ensure that the registered Task Scheduler tasks trigger the Windows Terminal application with the appropriate command-line arguments to launch the terminal window.

Error Handling and Validation:

Implement robust error handling mechanisms to address scenarios such as conflicting shortcuts or invalid configurations.
Provide informative error messages and log entries to assist users in resolving any configuration issues.

User Feedback:

Integrate user feedback mechanisms to collect information on the usage and effectiveness of the new keyboard shortcut feature.
Consider providing a feedback channel within the Windows Terminal application for users to report issues or suggest improvements related to this feature.

Expected Benefits
The implementation of this feature would significantly enhance the usability of the Windows Terminal, providing users with a seamless and integrated method for configuring and utilizing custom keyboard shortcuts. This improvement aligns with user expectations for efficient and direct access to the terminal application on Windows 11.

This already exists for the Terminal. See the globalSummon action


Faster decoders lookup by setting typeId to every ASN.1 type

Codecov Report

Merging #30 into master will decrease coverage by 0.02%.
The diff coverage is 87.75%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage    82.9%   82.88%   -0.03%
==========================================
  Files          25       25
  Lines        3551     3587      +36
==========================================
+ Hits         2944     2973      +29
- Misses        607      614       +7

Impacted Files
Coverage Δ

pyasn1/type/tagmap.py
74% <0%> (ø)
:white_check_mark:

pyasn1/type/char.py
88.18% <100%> (+1%)
:white_check_mark:

pyasn1/codec/ber/decoder.py
82.55% <100%> (-0.73%)
:x:

pyasn1/type/univ.py
79.47% <100%> (+0.13%)
:white_check_mark:

pyasn1/type/base.py
77.73% <100%> (+0.51%)
:white_check_mark:

pyasn1/codec/cer/decoder.py
93.54% <80%> (-2.75%)
:x:

pyasn1/codec/der/decoder.py
94.44% <80%> (-5.56%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b7cfe...d4256a8. Read the comment docs.


Disk cache lookups inconsistent?

I'd like to use Siesta's persistent cache feature. I implemented a simple class conforming to the EntityCache protocol based on NSCoding that writes/read to disk just to get a sense of how the whole thing works. I manage to get most of it working, but I'm noticing a weird pattern when it comes to disk cache lookups and I'm trying to understand the reasoning behind it.
I've set the expirationTime on one of my resource (let's call it foo) to 5 seconds, and this is what I am observing:

When the app starts, it tries to load resource foo which is already in the cache, it results in a cache lookup, followed by a cache hit, as expected. It also results in a network request and a cache write with the fresh data once the request succeeds, again, as expected.
Wait for 5 second to pass, resource foo should be stale, but still on the disk cache. Next time the resource is loaded (with loadIfNeeded), a network request is initiated immediately and no cache lookup happens. Upon success, the expected cache write is happening.

I'm trying to figure out why this second request to my resource doesn't even trigger a disk cache lookup and immediately requests it from the network?
Ideally what I'd like to do is this: If the data is available in the disk cache, return it immediately so that I can update my UI asap, even on a slow network, while requesting fresh data from the server and updating the cache... It seems like this happens on app launch (or the first time a resource is requested), but not for subsequent requests, even if they are stale, which results in immediate network requests, and long loading time on a slow network... Reading Siesta's documentation, I was lead to believe that this was possible (this part especially from EntityCache's documentation: "The purpose of HTTP caching is to prevent network requests, but what we need is a way to show old data while issuing new requests. This is the real deal-killer.")
Am I misunderstanding something here or is it an issue with Siesta's disk cache lookup logic?

I'm trying to figure out why this second request to my resource doesn't even trigger a disk cache lookup and immediately requests it from the network?

I also use the persistent cache feature of Siesta, and from your description I would first recommend you look at the value of the ResourceEvent you are getting back in your observer.  I'm guessing that it is .requested.
The reason your persistent cache doesn't get hit is that Siesta has an in-memory cache which was initialized from the persistent cache, and then updated from the network request.  Your cache should only see new data to write to it until the resource in question is removed from the in-memory cache.

Oh, interesting! That would make sense. I can't test right now but I will as soon as I'm back home. I think I was actually only updating my UI on the .newData event, which might actually explain the slowness in updating the UI on a throttled connection that I was observing!?
Will confirm once I get back home and close this issue if that's the case! 👍


StaticSite: speed up CloudFront update/invalidation

Currently, on sst deploy it takes CloudFront several minutes to update the distribution and then invalidate the cache. Let's use this issue to gather some potential ways to speed it up.

Requested by brent on Slack

I personally liked this feature because I know once I get the build complete alert from CI that I know for sure it was all invalidated.  The python custom resource in static site explicitly waits for the invalidation to finish - maybe can make this an option to disable?

Yeah, I agree, I think we should always wait. 2 things are slow currently:

updating the distribution to point to the new S3 folder
invalidating cache

I'm not sure why 1. takes ~1min. If it's just CloudFormation being slow, we could move updating the distrubution's s3 Origin to the custom resource and update it via CloudFront API. Not a good practice, but if that cuts down 1 min per deployment and is safe, I'd go for it.

Would more flexibility for fileOptions include/exclude combinations help?  I've found myself effectively copying files multiple times just to get the cacheControl combinations I've wanted, whereas I could target groups of files more precisely if I could specify  exclude/include combinations of arbitrary length and order (as s3 cp allows)

Removed the use of S3 folder and added an option to not wait for invalidation.


[feat] ⚡ add IPFS proxy support

added utility functions:

uploadFileToIPFSProxy
uploadMultipleFilesToIPFSProxy
uploadMetadataToIPFSProxy

Hey xat, what is the status?
Is it ready to be hooked up to the minter?

yes, it should be ready to be connected. zir0h deployed a proxy instance for testing.


InMemory provider Thread Safety

While running some tests on the build server yesterday using xunit, we experienced behavior where the tests wouldn't complete.  Nothing was reported, xunit would discover the tests and queue them, they just never executed.  Net effect was that our builds were hanging.
After a bit of discovery, it appeared that the culprit was that our tests were running in a Parallel.ForEach and that, specifically, we had 2 test classes that were both attempting to access the same in-memory Table of data.
Are there currently any tests around the thread-safety of In-Memory DbSet access?   And, should it be thread-safe by design?

@dneimke can you share some code that reproduces the issue? InMemory should be thread-safe... we were wondering if this could be a result of using the same context instance on multiple threads (rather than separate context instances targeting the same InMemroy store).

Hi @rowanmiller, I'll try to produce a repro this morning and will post you a link when done.

I'm going to park this for now.  I couldn't repro in a canonical xunit test project using multiple test classes but I can repro it on our build server (AppVeyor) - so it's not an EF threading issue per se but something in the build process.

I'll close this for now, feel free to re-open if you identify something EF related.


Slowness in the Event Loop

Hi all,
I am running into a hard to debug issue. I am using better-sqlite3 to log some activity from a webapp into
a table with a handful of columns.
 CREATE TABLE IF NOT EXISTS sometable('key' varchar, 'value' varchar, 'createdAt' DATETIME NOT NULL, 'updatedAt' DATETIME NOT NULL, 'TTL' INTEGER);
The table is written to sporadically and not very intensively, so once a day there are 40-70 writes, the value varchar can be large 2-3mb, but is typically small (less than 100-200 characters). The better-sqlite store replaces an in memory cache, literally a js map. The application is a long running webapp in node.
After the joy of everything working faded, the app seemed sluggish. At first, I thought it was my imagination, so I added a little
bit of software to check when the event loop gets behind:
module.exports = function (fn, options) {
    const opts = options || {};
    let start = process.hrtime();
    const interval = opts.interval || 100;
    const threshold = opts.threshold || 10;

    return setInterval(function () {
        const delta = process.hrtime(start);
        const nanosec = delta[0] * 1e9 + delta[1];
        const ms = nanosec / 1e6;
        const n = ms - interval;

        if (n > threshold) {
            fn(Math.round(n));
        }
        start = process.hrtime();
    }, interval).unref();
};

When the application is mostly idle the callback fires every few seconds, even if the threshold is set to 250 millis. When there is load on the application it (delay) can spike by an order or two of magnitude. I do have WAL mode set.
Is there anything happening in the background that would cause this behavior? Going back to the map returns the app to its former
timings. For reference, all of the access to the underlying SQLITE db is via cached prepared statements. Here's a get statement:

 const getKeyIfExists = db.prepare(`SELECT key FROM sometable where key = ? LIMIT 1`);
 const test = getKeyIfExists .get(key);

Is there some clean up I need to do?
Thank you!
Node version 16.16.0

Please properly format your message, so that the code is readable https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax
Upgrade to the latest better-sqlite3 and to a supported Node.js version (end of life for 16 was five months ago)

@Prinzhorn The behavior is the same in v18. I have edited the code in the original report.

@Prinzhorn Thanks for the quick responses. I will try to hack something up.
In the meantime swapping out to Sqlite3 does not result in a similar issue (slowing the event loop). I understand this is apples to oranges, but that's why I asked about any background processing.

See https://nodejs.org/en/guides/simple-profiling for how to profile where the time is spent, I assume one of your queries is super slow.
You have key indexed, right?

In the meantime swapping out to Sqlite3 does not result in a similar issue (slowing the event loop). I understand this is apples to oranges, but that's why I asked about any background processing.

You're probably doing something very slow and sqlite3 is masking that by giving control back to the event loop.

Yeah, I agree that this is my doing. I will try the indexing to see if that cures it.

So adding the index has helped dramatically. Adding in the following pragmas also seems to help.
PRAGMA journal_mode = WAL; PRAGMA synchronous = normal; pragma temp_store = memory;
More testing to be done.

I am closing this issue. More and more, this looks like my misuse of the library. The application was creating a lot of queries for a field that was stored in one of the tables. Async code of the Sqlite3 was masking the scale of those requests. Fixing the app removed the problem with the stuck event queue. Thanks to the responder @Prinzhorn for the gentle nudge. Apologies for the dead end.


Pass datasource errors through to the page

Currently it's hard to get insight into errors happening in datasources as they get logged on the server and a generic 500 is sent to the client. This passes the error through to the client so a meaningful message can be shown

Splitted into https://github.com/mui/mui-toolpad/pull/946 and https://github.com/mui/mui-toolpad/pull/948


common: fix consensus warning

fix consensus warning
fixes #1271

@bingyanglin You have conflict because you are pushing 2 commits recently merged in your previous PR

@bingyanglin You have conflict because you are pushing 2 commits recently merged in your previous PR


1.3.0 dev

Added unit-test, build & coverage statuses to README

Changes Unknown when pulling 7ea0b00161e449eb2e67b47ce36c799b058cc20d on 1.3.0-dev into ** on master**.


[v2] how to use environment variables?

I am using IntelliJ iDEA 2019.1. I have a .graphqlconfig file as follows. I am trying to figure out how to get js-graphql-intellij-plugin to automatically get the value of YOUR_APP_TOKEN which I have in a .env file.
{
  "schemaPath": "./schema.graphql",
  "extensions": {
    "endpoints": {
      "dev": {
        "url": "http://your-app.com/graphql",
        "headers": {
          "Authorization": "Bearer ${env:YOUR_APP_TOKEN}"
        }
      }
    }
  }
}

When I run a graphql query using js-graphql-intellij-plugin plugin, I get a dialog box asking to

Enter Missing GraphQL "API_KEY" Environment Variable

(I have a .env file with this value in it which it would be great if there was a way the plugin could read from.)
If I paste the value into the dialog box, it does remember the value, even though the dialog box appears every time I make a new request.
The hint text in this dialog box says:

Hint Specify environment variables using -DvarName=varValue on the IDE command line.

But -DvarName=varValue is not a valid bash command.
Expected Behaviour
A way to either set the environment variable inside of IntelliJ so the dialog box doesn't always pop up when I run a graphql query, or for js-graphql-intellij-plugin to be able to env vars from a .env file.

Hi Sam.
Thanks for using the plugin.
The -D option would still show the dialog, and would only set the initial value.
I opted to show the dialog each time as the it would also be annoying to have to restart the IDE in case a new value needs to be entered. But I made sure to focus the dialog such that you can simply press enter to close it using the current value.
A lot of non-JS project don't use .env files, so I'm not sure that's worth the effort. I'm thinking that a check box to not show the dialog again until IDE restart could be the a pragmatic solution.
Best regards,
Jim.

HI Jim,
Thanks for the response. Finding v2 of the plugin really useful btw.
Could you please clarify how the -D option works? What do you mean by the
IDE command line in IntelliJ? Assuming it's not the terminal.
Kind regards,
Sam
On Fri, 3 May 2019 at 09:17, Jim Kynde Meyer<EMAIL_ADDRESS>wrote:

Hi Sam.
Thanks for using the plugin.
The -D option would still show the dialog, and would only set the initial
value.
I opted to show the dialog each time as the it would also be annoying to
have to restart the IDE in case a new value needs to be entered. But I made
sure to focus the dialog such that you can simply press enter to close it
using the current value.
A lot of non-JS project don't use .env files, so I'm not sure that's worth
the effort. I'm thinking that a check box to not show the dialog again
until IDE restart could be the a pragmatic solution.
Best regards,
Jim.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jimkyndemeyer/js-graphql-intellij-plugin/issues/249#issuecomment-489001722,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACZNDLWA4XK3HWFM6ARXG2LPTPYKVANCNFSM4HJ4ZLJA
.

Hi Sam.
I mean the command line that starts your IDE process. I'm actually not sure how to pass the arguments from a terminal as I've only tested this by running the IDE as debug from inside another IntelliJ instance:

You might have some luck by reviewing https://www.jetbrains.com/help/idea/tuning-the-ide.html
The plugin uses System.getProperty to look up the default values for the env vars given that IntelliJ itself is a Java process.

OK thanks. Will close issue.
I found the popup dialog a bit annoying when I first referenced an env var in my .graphqlconfig file, but I am used to it now.


Pass type converter to all ONNX operations

This PR finishes the type conversion related changes started in #1095. Specifically this pull request modifies all ONNX operators to pass a type converter to their base class.

Jenkins Linux amd64 Build #3381 [push] Pass a type converter to... started at 10:20

Jenkins Linux s390x Build #3373 [push] Pass a type converter to... started at 11:20

Jenkins Linux s390x Build #3373 [push] Pass a type converter to... passed after 48 min

Jenkins Linux ppc64le Build #2489 [push] Pass a type converter to... passed after 54 min

Jenkins Linux amd64 Build #3381 [push] Pass a type converter to... passed after 58 min


fix bug in zscal function

memset can not be used in zscal because of
the stride parameters.
Signed-off-by: Wu Zhigang<EMAIL_ADDRESS>

Oh, right. Thank you very much.


Which version to use?

Hey Graphite Team,
We're running 0.9.15 as our production graphite instance. I'm finding though that some features like (sortByTotal) are missing from the 0.9.x release even though these features were merged to master several years ago.
I found graphite-project/carbon#312 which discusses a similar issue where master and 0.9.x are diverged and there doesn't seem to be anything (at least that I've found) which indicates what a way forward is here.
So, my questions are, specifically with regards to graphite-web:

is 0.10.x stable enough to be running in production?
is it safe to run different versions of carbon and graphite-web?
are there any obvious things that are missing in 0.10.x from 0.9.x

Thanks!
-- Jonas

Hi @jbergler! Rest assured we will make sure there is a reasonable path forward for 0.9.x -> 1.0 users when 1.0 is considered ready for general consumption. That is to say, when it's fully documented and the warts are fully understood/acknowledged.
Good news, Graphite development has been picking up recently but it's about to get a full-on boost of my time. I'm starting employment at raintank next week. They're huge fans of Graphite and intend to continue investing in the Graphite ecosystem, in particular with my time working on the project.
P.S. Thank you for your PR bringing in sortByTotal to 0.9.x.


Add Quick / Nimble test dependencies

Use Carthage to add Quick and Nimble dependencies, only on the Test project.
The tests should continue to run normally

Issue fixed with PR #6