Cloudflared Tunnel with Empty Request to Traefik

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?
As the title implies, the request that Traefik seems to receive does not have any information, now I am lost and I do not know how to continue, other solutions I have found do not seem to work, for example setting the HTTP Host Header: https://imgur.com/a/BJXe55p
Unfortunately I cannot find any other solutions for this either, this is my current configuration:
Cloudflare:
Cloudflare tunnel with http://rps.website.com, with a http service to traefik.
With http settings containing the HTTP Host Header of rps.website.com.
Traefik:
  traefik:
    image: traefik
    hostname: traefik
    command:
      - "--api.insecure=true"
      - "--providers.docker=true"
      - "--entrypoints.web.address=:80"
      - "--entrypoints.websecure.address=:443"
      - "--accesslog=true"
    ports:
      - "80:80"
      - "443:443"
      - "8080:8080"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    networks:
      - exposed
      - private

What did you see instead?

Version:      3.1.4
Codename:     comte
Go version:   go1.23.1
Built:        2024-09-19T13:47:17Z
OS/Arch:      linux/amd64
What is your environment & configuration?
version: "3"

services:
  rockpaperscissors:
    image: ghcr.io/axodouble/rockpaperscissors:main
    labels:
      - "traefik.enable=true"
      - "traefik.http.routers.rockpaperscissors.rule=Host(`rps.website.com`)"
      - "traefik.http.services.rockpaperscissors.loadbalancer.server.port=80"
      - "traefik.http.routers.rockpaperscissors.entrypoints=web"
      - "traefik.http.routers.rockpaperscissors.tls=true"
    networks:
      - exposed

  tunnel:
    image: cloudflare/cloudflared
    restart: no
    command: tunnel run
    labels:
      - "traefik.enable=false"
    environment:
      - TUNNEL_TOKEN=${CLOUDFLARED_TOKEN}
    networks:
      - exposed

  traefik:
    image: traefik
    hostname: traefik
    command:
      - "--api.insecure=true"
      - "--providers.docker=true"
      - "--entrypoints.web.address=:80"
      - "--entrypoints.websecure.address=:443"
      - "--accesslog=true"
    ports:
      - "80:80"
      - "443:443"
      - "8080:8080"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    networks:
      - exposed
      - private

networks:
  exposed:
    driver: bridge
  private:
    driver: bridge

If applicable, please paste the log output in DEBUG level
No response

I was mistaken, this was a simple case of user error.


wrap all files read/writes in try/except not just "with"

but we need to decide what to do in that case beyond  sending a logger message to warn the researcher and write to the log file

Use warnings? Example:
https://github.com/AI-SDC/ACRO/blob/59684a0dc24b15e8774e3c59d41f1b9c243532f2/acro/acro.py#L128


Add patterns for fsdf/common and fsdf/network

Changing core: to common: wait a few moments

I've merged the equivalent patterns in for these repos, see https:linked.data.gov.au/def/fsdf/common. I did update the ontology HTML documentation first, using updated pyLODE which now respects cases in URL fragments.


Ignore stat errors on volume rm.

Underlying volume data may have been removed by some other tool.
Ignore and remove the reference in this case.
ping @vieux
This should fix the lstat errors you were seeing on docker volume rm

LGTM

LGTM

:+1: thanks @cpuguy83 works as expected


🔌 Plugin: CycloneDX SBOM

Suggesting a plugin to display a CycloneDX Software Bill of Materials (SBOM) Composition Report. CycloneDX is a commonly used standard across a number of tools that supports both JSON and XML schemas.
CycloneDX is the SBOM format created by the Open Web Application Security Project (OWASP) and was built with cybersecurity in mind. The largest benefit of CycloneDX is the ability to include vulnerability information in the SBOM or link to a separate Vulnerability Exploitability Exchange (VEX) which lets you indicate false positives alongside component vulnerability information. The schema also supports  a Package URL (PURL) which standardizes how software package metadata is represented so that packages can universally be located regardless of what vendor, project, or ecosystem the packages belongs to.

Thinking the plugin will work similar to the dependency-track plugin
metadata:   annotations:     backstage.io/sbom: enabled
A tab called SBOM to be shown at the component, system and even resource level with sub tabs with the SBOM provider name i.e Sonatype, syft or any tool that supports the Cyclone specification standard.

https://github.com/CycloneDX/cyclonedx-javascript-library/discussions/215
Unfortunately i don’t have time to contribute right now but wanted to throw the idea out there and get feedback from the community!

@BethGriggs you closed this by referring to it in a list, how does it address the issue? The close resolution is not clear, I'm new to the topic and was wondering if I can use Backstage to render my SBOMs

I am not sure I understand what would the objective of the plugin?
Would that be an annotation handler at Component level or System to review the dependencies?
Are you looking to create a CatalogProcessor ?
As part of the SCA concerns, I guess it make sense to have per component a SBOM but not sure of the exact way to create the most value out of the SBOM inside Backstage vs referring to a third party service like DependencyTracker, Aikido ....
Keen to chat about it


Guice-based Beadledom clients use the wrong time unit for timeouts

The BeadlecomClientBuilderProvider class configures the client timeouts using the provided configuration with the wrong time unit. The configuration contains values in milliseconds, but the provider is setting values as seconds. This means if the timeout is configured for 10000 milliseconds, the resulting timeout will be 10000 seconds instead of 10 seconds.
See: https://github.com/cerner/beadledom/blob/c40fba49a602b8e4639b7e334889ac5980cc5c75/client/beadledom-client-guice/src/main/java/com/cerner/beadledom/client/BeadledomClientBuilderProvider.java#L75-L77

Fixed by #147.


[SPARK-38160][SQL] Shuffle by rand could lead to incorrect answers when ShuffleFetchFailed happend

What changes were proposed in this pull request?
When we do shuffle on indeterminate expressions such as rand, and ShuffleFetchFailed happend, we may get incorrent result since it only retries failed map tasks.
To illustrate this, suppose we have a dataset with two columns (range(1, 5) as a, rand() as b), we shuffle by b using two map tasks and two reduce tasks.

When there is a fetch failed and we need to rerun map task 2,  the generated partitions maybe different compared with last attempt, and finally we get a duplicate record with a = 4

This is very similary to the bug in Repartition+Shuffle, which is fixed by https://github.com/apache/spark/pull/22112.
This PR try to fix this by reuse current machenism.
Why are the changes needed?
Fix data inconsistent issue.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT

@cloud-fan @maropu Can you please help review this?

Can one of the admins verify this patch?

also cc @srowen @viirya @yaooqinn I found there is a similar report before https://issues.apache.org/jira/browse/SPARK-24607

Isn't this why you shouldn't partition, shuffle, etc on some random value? use a hash?

Isn't this why you shouldn't partition, shuffle, etc on some random value? use a hash?

The data analyst may always have various needs such as distributed by rand() to redistribute data evenly
or select * from     (select concat(key1, rand()) as key1 from tbl1) a    join     (select key2 from tbl2) b   on a.key1 = b.key2 to work around skew data,  which is a valid SQL in Spark.
Both of these sqls will generate a HashPartitioning with non-deterministic expressions.
If we don't support shuffle by random value, we should disable this.

Right, shouldn't we reject it? distributing by "hash(ID)" or similar makes more sense, not least of which because it is reproducible and deterministic across runs and environments

Reject it maybe not a good idea.

Both Hive/Presto support patterns like distributed by rand or Join/GroupBy by rand. And seems Spark is intent to support groupby by rand, refer https://github.com/apache/spark/pull/16404.  And also some udfs or java_methods is marked as indeterminated, if we reject it, it means users cannot join/groupby a column generated by udf/java_methods.
The root cause of data inconsist when shuffle by rand expression is Spark only retry partially map tasks when shuffle fetch failed. If we retry the whole stage, there is no problem. We can utilize current logic in DAGScheduler to achieve this.

If there is a fetch failure and the parent stage is INDETERMINATE, both the parent and child stage are entirely recomputed .

If there is a fetch failure and the parent stage is INDETERMINATE, both the parent and child stage are recomputed. Custom RDD's can extend getOutputDeterministicLevel and return the right DeterministicLevel. See #22112 for more details

Thanks for your reference. That's what I do in this MR for SparkSQL.
When we shuffle by rand with sqls like distributed by rand, the RDD's DeterministicLevel generated by SparkSQL is INDETERMINATE after this MR

This is really a hard problem and rerunning the entire stage is more of a compromise. In a large enough cluster, we may always see task failures when running a stage, and rerunning the entire stage may never succeed. That's why in Spark SQL, we don't really rely on the DeterministicLevel framework, but by default we sort before repartition to fix the correctness issue.
I think we should either have reliable shuffle storage (AFAIK there are several third-party remote shuffle services) so that fetch failure never happens, or we reject such queries.


Ensure system gem updates in docker image

To avoid dependency issues when default gems are behind while running BKB.

Is this PR still active? If so I'm wondering if build stability might be a better reviewer than Prod Infra RR & A at this point? Just asking because this comes up in my daily ping of outstanding PRs, but I don't think I'm the right person to review.

Is this PR still active? If so I'm wondering if build stability might be a better reviewer than Prod Infra RR & A at this point? Just asking because this comes up in my daily ping of outstanding PRs, but I don't think I'm the right person to review.

Yes, I've changed the reviewer, thanks.


Student statistics: Improve chart appearance

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[ ] I chose a title conforming to the naming conventions for pull requests.

Client

[x] I followed the coding and design guidelines.
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

This PR improves the charts on students statistics tab in some details
Description

Chart coloring: The coloring of the bars is reworked. A bit darker colors are chosen since the current ones are quite loud. For this purpose, standardized colors used in different places are reused. Furthermore, the color of the average score line is changed from red to yellow. Since red is used to indicate missing scores in the bar charts, this leads to a confusing difference in color coding between the two chart types.
Performance in exercises positioning: The positioning of the chart is now changed so that it is centered on the page and consumes 90% of the page width.
Readability of legend entries: The default color of the legend entry test is changed to the Artemis dark color (which is more or less black) as well as its font weight is increased in order to make the legend more readable. If the user now hovers over a chart entry, it is colored in Artemis primary color instead of black as it was previously.
Horizontal bar chart height: We encountered some problems for the horizontal bar charts: As the height of the chart is currently hardcoded, the chart gets hardly readable if many exercises should be displayed. The height is now determined dynamically in order to ensure readability even if many exercises are displayed.

Steps for Testing

Prerequisites:

1 Student
1 Course with some contributions

Log in to Artemis
Navigate to the student statistics tab
Inspect the charts there. Feel free to share your opinion about the new colors. These are open for discussion.
Also check that the horizontal bar charts are sized conveniently and the dimensions are not reducing your usability.

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Mainly UI changes
Screenshots

An example how a chart with 50 exercises would look with the current implementation. Notice that even some exercise titles are omitted by the framework because there is not enough space:

How it looks with my changes:

The new colors:

So far everything looks quite good to me. However, could the red color be a bit lighter? I don't know if it's only me but the dark color is a bit overwhelming for my eyes, especially if everything is red.

This is the red we are currently using in other places, mainly for indicating missing parts (points, assessments, etc.). I would like to be consistent in the color domain across the system. However if this red is overwhelming, we might want to switch to a lighter one in general. I append the tint scheme of this color below. let me know which version would be more convenient for you. If no version really works for you, let me know and we try to find another color.

Colors look good but i have a question about thickness of the bars of each exercise. If we have just one exercise in a type, it's bar is very thin compared to the others. For example "Julis SCA progra.." here:
Could we have same height for all the bars?

Well, this definitely has to be changed, thanks for pointing it out. I will have a look into it.

So far everything looks quite good to me. However, could the red color be a bit lighter? I don't know if it's only me but the dark color is a bit overwhelming for my eyes, especially if everything is red.

This is the red we are currently using in other places, mainly for indicating missing parts (points, assessments, etc.). I would like to be consistent in the color domain across the system. However if this red is overwhelming, we might want to switch to a lighter one in general. I append the tint scheme of this color below. let me know which version would be more convenient for you. If no version really works for you, let me know and we try to find another color.

If no one got the same problem as me, then you can also just leave it as it is. I think color that is just a tad brighter would be fine (20%, 30%)

@MertAksehirlioglu I changed the chart size calculation a bit. It is now unified for all possible chart sizes (I think this is the easiest and most convenient solution instead of doing random case differentiation). The bar padding is now unified as well. I checked it locally, this should fix the appearance if only one bar is displayed. Feel free to take a look by yourself on a test server again!

So far everything looks quite good to me. However, could the red color be a bit lighter? I don't know if it's only me but the dark color is a bit overwhelming for my eyes, especially if everything is red.

This is the red we are currently using in other places, mainly for indicating missing parts (points, assessments, etc.). I would like to be consistent in the color domain across the system. However if this red is overwhelming, we might want to switch to a lighter one in general. I append the tint scheme of this color below. let me know which version would be more convenient for you. If no version really works for you, let me know and we try to find another color.

If no one got the same problem as me, then you can also just leave it as it is. I think a color that is just a tad brighter would be fine (20%, 30%)

I will keep your suggestion in mind. If similar feedback occurs from prod users, it would be an quick fix to change the color in a followup :)


Unify Uri vs. Link naming

Fixes #295 (replaces #303 PR)

Coverage increased (+0.04%) to 81.688% when pulling 533d8571d5539066259a024d86f67e81735f73ad on uri-vs-link into 1c8b21509e9b5a68a6c08988181bf82bc5294487 on 2.0.0-RC.

Coverage increased (+0.03%) to 81.731% when pulling 4678028b07b293874ef97bc9274195f99b9ec0ab on uri-vs-link into 6b055e0175c27ae7e03fc1e32c3885ffb7462bf5 on 2.0.0-RC.

Coverage increased (+0.04%) to 81.916% when pulling 04644dda6f4e9c333d30d64ccc661c2d680afb12 on uri-vs-link into 222f00acd5c5409bb25e25ac537ef918c77e32f1 on 2.0.0-RC.

Coverage decreased (-0.02%) to 81.855% when pulling 04644dda6f4e9c333d30d64ccc661c2d680afb12 on uri-vs-link into 222f00acd5c5409bb25e25ac537ef918c77e32f1 on 2.0.0-RC.


Figuring out how to send watch data to phone

Generally documenting all the findings and things done with getting sensor data from watch to the phone
The branch I'm working on is watch_datasharing

There already was an activity for sending the data, but no way to get to it, so i hooked up the UI the actually be able to get to the SendSurveyActivity and be able to send data to the phone, which works
the data goes to /storage/emulated/0/Download on the phone
the only data sent is the header comment
# log_watch_01011970_061538885.csv
#
# Header Description:
#
# Version: 1 Platform: 13 Manufacturer: unknown Model: sdk_gwear_x86_64
#

which corresponds to this part of the code in SendSurveyActivity:
fun writeLine(line: String) {
    outputStream.write("$line\n".toByteArray())
}

val dateTime: String = SimpleDateFormat("ddMMyyyy_hhmmssSSS").format(startTime)
writeLine("$COMMENT_START log_watch_$dateTime.csv")
writeLine(COMMENT_START)
writeLine("$COMMENT_START Header Description:")
writeLine(COMMENT_START)
writeLine("$COMMENT_START Version: ${BuildConfig.VERSION_CODE} Platform: ${Build.VERSION.RELEASE} Manufacturer: ${Build.MANUFACTURER} Model: ${Build.MODEL}")
writeLine(COMMENT_START)

figured out that no other data is sent because the file locations for WatchActivityHandler is empty, but don't know why it's empty, so currently figuring that out

Took me a while to figure out how the file saving is handled from the LoggingActivity on watchlogger

Essentially LoggingActivity has a LoggingService class, and LoggingService calls on SensorsHandler and SensorsHandler calls on FileHandler in order to save files

checked if the files would be sent if i manually add the file to WatchActivityHandler, and it seemed to work
var newPath = "/data/data/com.mobilewizards.logging_app/files/log_mimir_20241020115122.txt"
WatchActivityHandler.addFilePath(newPath);

So the file sending works if we get the file paths to the files, it's probably fine to move to making a prototype UI that lists the file names and then sends the individual files from there

Figured out a way fetch all the files list them as a list in the UI using a RecyclerView, there is probably a way to attach functionality to the listing.

Managed to figure out how to add functional items to the list instead of just placeholder text
Now it is a functional list of tems along with a button that can do anything with the file that is attached to the list item
Currently there is just a placeholder alert that says the item file name

Made a lot of improvements to the UI and made the item list thin enough to be seen on circular display watches
Added a confirmation screen for sending the file to the phone and for deleting the file off the watch
Added a way to delete files from inside of the watch
Demonstration about uploading files and deleting them off the watch

branch merged with pullreguest #9


Fix linking on BSD systems

After this change, x11-dl builds on FreeBSD.
Thanks to libloading's build.rs for info about other BSDs.

Thanks, that was quick :)


[mpg123] Update portfile.cmake to accomodate OpenSUSE 15.x /lib /lib64

[mpg123] Update portfile.cmake to accomodate OpenSUSE 15.x /lib versus /lib64 when port is built

Some builds on OpenSUSE 15.x put libraries in /lib64 instead of /lib

Fixes #10920

Changes made to portfile.cmake to check where the libraries exist (either in /buildtrees/mpg123/lib or /buildtrees/mpg123/lib64) before trying to install them into the /installed/x64-linux/lib directory

Reformatted where new lines where added for readability.

Incremented version in CONTROL file

This replaces Pull Request #12255

@LilyWangL - I think it is ready now.

Thanks for the fixes!


⚠ RPC server - xDai has degraded performance

In ad3af1a, RPC server - xDai ($XDAI_RPC_URL) experienced degraded performance:

HTTP code: 200
Response time: 411 ms

Resolved: RPC server - xDai performance has improved in 62d9c33 after 40 minutes.


Get mljsapi running on my laptop

It was running. Now I have to use Cloud9. I have a support case open.
TODO

[ ] Try the recommendation from the support engineer
[ ] See if adding a CodeUri line fixes it

Nope. We're running under turnkey now, and in turnkey there's no running on my laptopl.


🐞[bug]: Missing Navbar in Book now page

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Navbar is missing on the Book now page . There is no way back to the previous page or home page.
Expected behavior
There should be a navbar to access the other pages.
Add ScreenShots

What browsers are you seeing the problem on?
Chrome
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

Please assign me this issue

I want to tackle this issue, please assign this issue issue  me.


⚠ Samsung has degraded performance

In 0f48ade, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2288 ms

Resolved: Samsung performance has improved in 53914c7.


Question of RMSNorm's forward function

I noticed that RMSNorm's hidden_size does not been changed to the sliced dim. So In the forward of RMSNorm the input tensor's shape is [bs, seq_len, sliced_hidden_size], while the variance is caculated by variance = x.pow(2).sum(-1, keepdim=True) / self.mean_dim, where self.mean_dim is equal to hidden_size.
I think self.mean_dim should be equal to the sliced hidden_size. Please correct me if I misunderstand anything. Thx.
    replace_modules(
        model_adapter.model,
        model_adapter.original_layer_norm_type,
        lambda _: RMSN(model_adapter.hidden_size),
        replace_layers=False,
    )
    logging.info("Fusing layernorm modules done")

### Tasks

Very interesting question - I think it makes sense to keep as is, because by discarding eigenvalues from x's PCA we are effectively setting some x values to zero, which allows us to slice them off. So from this perspective, if we imagine keeping the zeros in x then we calculate the variance of x in RMSN by summing over non-zero and zero elements, then divide by the total (original) dim. Curious to know if @myshkov @jameshensman agree.

@nailimixaM Thanks for your explaination. You are right. And I verified that the ppl of the sliced model will drop if replacing self.mean_dim with the sliced hidden_size.


Show a stack of upcoming cards

Hi I wanted to request a feature :
Can we show the a stack of cards at the bottom, so that they are scrolled into view ?

You mean more than 1 card at bottom right?

Yeah exactly right, it shows there's more cards available.

I tried doing this before and it looks like that the currently it is not possible with PageView.
I would have to create a custom PageView type widget, but I am busy with some other work right now.
You can give it a try


machine registration connectivity rework - part II

This is the client-side equivalent of https://github.com/rancher/elemental-operator/pull/140.
Note that this needs first that https://github.com/rancher-sandbox/go-tpm/pull/5 got merged, then this branch will be updated with the new go-tpm version (for this reason got the blocked flag).
register: take control of the registration process
Till now, the attestation and communication with the elemental operator
were all demanded to the github.com/rancher-sandbox/go-tpm package.
Split TPM attestation from the communication with the elemental operator
demanding TPM authentication to the external library while taking full
control of the communication with the operator.
This doesn't introduce functional changes (so it will keep retrocompatibility
with the current elemental operator) and is a preparatory step to address
rancher/elemental-operator#5

Codecov Report

Merging #141 (858e46f) into main (f0bd8f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   33.77%   33.77%
=======================================
  Files           5        5
  Lines         379      379
=======================================
  Hits          128      128
  Misses        246      246
  Partials        5        5

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Random Chinese text wrong weight/traditional/simplified rendering on iPhone

It should be showed in normal font, but it is showed in bold font.

This should be showed in Simplified Chinese, but it is showed in traditional Chinese.
The two cases rarely happen. But it not nice when happen. I guess it is font rendering issue.
Did anyone encounter this situation?

Please add the output of flutter doctor -v.

Please add the output of flutter doctor -v.

➜  Work flutter doctor -v
[✓] Flutter (Channel unknown, v1.0.0, on Mac OS X 10.13.6 17G65, locale zh-Hans-CN)
• Flutter version 1.0.0 at /Users/xyz/Work/GitHub/awesome-flutter/flutter
• Framework revision 5391447fae (4 weeks ago), 2018-11-29 19:41:26 -0800
• Engine revision 7375a0f414
• Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)
It seems that it happened in before version too. Our users encounter it random in release mode.

@GaryQian I vaguely remembered that you looked into a similar issue before. Is this still relevant? If not, can we close it now?
Besides, I am not seeing a consistent repro here, if the information provided in the bug is not sufficient for investigation, please feel free to close it with a comment back to the customer.


realm logo: Fix realm logo unsupported file upload bug.

Unable to upload a realm logo once we encounter file input error bug
was fixed by clearing get_file_input() after file input error
with get_file_input().val('').

fixes #15198
Testing Plan:
Tested in browser
GIFs or Screenshots:

@timabbott ready for review

Merged as 44995e36df050daf5f16f5b62335c62aa7dcce9b, thanks @Jagansivam28!
(I added a bit more detail to the commit message)


Use a single call to dpinger for a coherent view of latency/stddev/loss.

Sorry, I had turned tabs completely off to make it easier for you and I to work on dpinger. Fixed now.


Update built-in-routing-conventions.md

Fix grammar.

Docs Build status updates of commit 4e1e089:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/webapi/built-in-routing-conventions.md
:warning:Warning
View
Details

Odata-docs/webapi/built-in-routing-conventions.md

Line 2, Column 1: [Warning-author-missing] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 3, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Routing Conventions' is duplicated in 'webapi/attribute-routing.md(3,14)', 'webapi/built-in-routing-conventions.md(3,14)', 'webapi/custom-routing-convention.md(3,14)', 'webapi/routing-abstract.md(3,14)'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


DtlsCompressed sequence_number size should be 48/8

To match DtlsPlaintext https://github.com/Rantanen/node-dtls/blob/master/packets/DtlsPlaintext.js#L23
DtlsCompressed sequence_number size should be 48/8 https://github.com/Rantanen/node-dtls/blob/master/packets/DtlsCompressed.js#L19

DtlsCompressed and DtlsCiphertext were never used. The byte structure of these packets is essentially the same as DtlsPlaintext.
Instead of using the DtlsCompressed and DtlsCiphertext packet formats, the DtlsRecordLayer reads the incoming packet as DtlsPlaintext and then based on the epoch and sequence numbers (which are in the same location for all the incoming packets) it'll figure out whether the packet requires decrypting/decrompression. Same happens for outgoing packets.
I'll close the issue by removing the obsolete packets from the code base.


byte vs base64 format

Data Types defines format: byte as base64-encoded characters.
Considerations for File Uploads and Special Considerations for multipart Content mention format: base64, which is not mentioned in Data Types. Is this a typo and meant to say format: byte? Or are base64 and byte different formats?

I've stumbled on the same issue and the spec is incoherent on this point.
I've found this remark  on the PR that introduces a "base64" that suggests that "byte" is the good format but there was no corrections.

@hkosova @axlbonnet
JSON Schema draft-07 (which would be relevant to OpenAPI 3.1 at the earliest, possibly 4.0, assuming OAI wants to adopt it at all) adds the contentMediaType and contentEncoding parameters for general support of encoding other forms of data in JSON strings.
These were formerly the type and binaryEncoding keywords within Hyper-Schema's media object, but we do not think JSON Schema users should have to adopt Hyper-Schema for this functionality (or readOnly or writeOnly, both of which are also now in the validation spec).

Where does this leave interpreting "format"? Based on my reading of 3.0.1, it would seem right now that "byte" and "base64" would be synonyms.

@pbryan in the long run, format should not be used for this.  OpenAPI worked around deficiencies in JSON Schema, but I'm hoping we can drop the workarounds and converge on the existing unambiguous solution.

Thanks @handrews.

Closing in favor of #1547.

Hi @hkosova,
we are using the 3.0.0 version currently.
So please can you help me with this query ==> comment


Id from from combobox items not returned from onSelectionChange

Provide a general summary of the issue here
According to the docs on https://react-spectrum.adobe.com/react-aria/ComboBox.html#dynamic-collections.
The id provided in the array of objects (items) passed to the ComboBox as defaultItems should be returned as the key from onSelectionChange. In the current implementation is returns an internal id instead of the id from the items.
Quote from https://react-spectrum.adobe.com/react-aria/ComboBox.html#dynamic-collections
"As seen below, an iterable list of options is passed to the ComboBox using the defaultItems prop. Each item accepts an id prop, which is passed to the onSelectionChange handler to identify the selected item. Alternatively, if the item objects contain an id property, as shown in the example below, then this is used automatically and an id prop is not required."
🤔 Expected Behavior?
The id provided in the array of objects (items) passed to the ComboBox as defaultItems should be returned as the key from onSelectionChange.
😯 Current Behavior
The key returned from  onSelectionChange is an internal id such as react-aria-2.
Only if you explicitly pass the id to <Item id={item.id}>{item.label}</Item> does it actually return the id.
💁 Possible Solution
No response
🔦 Context
No response
🖥 Steps to Reproduce
I've reproduced the error on Codesandbox: https://codesandbox.io/p/sandbox/tender-sun-mtrh8f
Version
"react-aria-components": "^1.0.0-alpha.6",
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
macOS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

This is because you are passing key={item.id} to your Item. If you omit that entirely or do id={item.id} (as you mentioned earlier), then you receive the proper value in your onSelectionChange. This is a change from our React Spectrum collection implementation noted in @devongovett's RFC as follows:
Our current implementation heavily uses the React key prop to identify items in collections. However, this will not work with the new implementation because key is not passed through from the <Item> element to the implementation of the Item component. Therefore, we will need to use a different prop name such as id that is passed through. This would be a breaking change to switch to by default, but for React Aria Components this is ok since it is a new library. We will need to think through how to release this in our existing React Aria hooks and React Spectrum components separately.

Closing and we can reopen if it's still a problem.


Add optional arg that provides fix for #11261 (Anthropic w/ BedrockChat)

Fixes #11261

Is this going to be reviewed? I'm having the same issue

🤷🏻♂

Apologies for the slow review! Pr has some merge conflicts, happy to re-review if you'd like to resolve


[GCI 2018] Not  .gitignore file

No proper gitignore file. It appears someone tried adding it but made it a folder somehow.

I've created a PR for this issue :)


SB-820  Resource leaks and initialization checks in tests

@carlspring, all tests are free from initialized flag and I received full project SUCCESS running mvn clean install  with tests. Some tests required better cleanup, sometimes there was a need to close some resources.
However, jenkins shows an error on:

Failed tests:   testMavenCentral(org.carlspring.strongbox.providers.repository.ProxyRepositoryProviderTest)

So the situation reversed now - on my end, under Windows, all tests have passed.
I'll schedule jenkins machine access with @steve-todorov and will take a look over ther there one day over the weekend.
Please review this PR as it's ready now (almost, according to jenkins :P).

I forgot about https://github.com/strongbox/strongbox/blob/master/strongbox-web-core/src/test/java/org/carlspring/strongbox/controllers/maven/MavenArtifactControllerTest.java#L675 PR is still in progress.

The pull looks good to me. Some minor code formatting issues raised.
Also, any excessive debugging logging that is no longer useful, could be dropped (if there is such).
Will merge, after @sbespalov has given it a go under Windows as well.

[INFO] Reactor Summary:
[INFO]
[INFO] Strongbox: Parent .................................. SUCCESS [  0.516 s]
[INFO] Strongbox: Resources [Common] ...................... SUCCESS [  1.531 s]
[INFO] Strongbox: Resources [Storage API] ................. SUCCESS [  0.422 s]
[INFO] Strongbox: Resources [Storage] ..................... SUCCESS [  0.016 s]
[INFO] Strongbox: Resources [Web] ......................... SUCCESS [  1.328 s]
[INFO] Strongbox: Resources ............................... SUCCESS [  0.015 s]
[INFO] Strongbox: Data Service ............................ SUCCESS [  5.657 s]
[INFO] Strongbox: Commons ................................. SUCCESS [ 12.130 s]
[INFO] Strongbox: Configuration ........................... SUCCESS [  1.406 s]
[INFO] Strongbox: Metadata [Maven API] .................... SUCCESS [  5.473 s]
[INFO] Strongbox: Event API ............................... SUCCESS [  0.875 s]
[INFO] Strongbox: Authentication API ...................... SUCCESS [  0.844 s]
[INFO] Strongbox: Client .................................. SUCCESS [ 14.462 s]
[INFO] Strongbox: Testing [Core] .......................... SUCCESS [  2.938 s]
[INFO] Strongbox: Security API ............................ SUCCESS [ 15.911 s]
[INFO] Strongbox: Storage [Core] .......................... SUCCESS [  6.640 s]
[INFO] Strongbox: Testing [Storage] ....................... SUCCESS [  1.625 s]
[INFO] Strongbox: Storage [API] ........................... SUCCESS [ 53.083 s]
[INFO] Strongbox: User Management ......................... SUCCESS [ 59.271 s]
[INFO] Strongbox: REST Client ............................. SUCCESS [  2.031 s]
[INFO] Strongbox: Storage [Maven Layout Provider] ......... SUCCESS [04:25 min]
[INFO] Strongbox: Testing [Web] ........................... SUCCESS [  3.099 s]
[INFO] Strongbox: Testing ................................. SUCCESS [  0.031 s]
[INFO] Strongbox: Storage [Nuget Layout Provider] ......... SUCCESS [  5.974 s]
[INFO] Strongbox: Storage [P2 Layout Provider] ............ SUCCESS [  6.145 s]
[INFO] Strongbox: Storage Layout Providers ................ SUCCESS [  0.016 s]
[INFO] Strongbox: Storage ................................. SUCCESS [  0.031 s]
[INFO] Strongbox: Web Core ................................ SUCCESS [06:05 min]
[INFO] Strongbox: Cron Tasks .............................. SUCCESS [ 57.146 s]
[INFO] Strongbox: Masterbuild ............................. SUCCESS [  0.016 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:50 min
[INFO] Finished at: 2017-06-15T13:10:34+03:00
[INFO] Final Memory: 62M/210M


Messages Collapse Down

Allows messages to collapse down when you have a short result set.

I'll merge this to include in testing.


Flickering Mihon Logo in About Page

Steps to reproduce
Open About screen, watch the logo displayed at the top. After a couple seconds, it starts to flicker. I've tested this on a Motorola Edge 2020 and Moto G Stylus 2023, happens on both devices.
Expected behavior
Logo should be displayed clearly without flicker.
Actual behavior
Flickering can be seen on the logo when viewing the about screen.
https://github.com/mihonapp/mihon/assets/61475057/80b2eebd-4139-4a68-8f2e-2b80b29eb24a
Crash logs
No response
Mihon version
0.16.1
Android version
Android 11, Android 13
Device
Motorola Edge 2020, Moto G Stylus 2023
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 0.16.1.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Can't reproduce on my phone or the android emulator

Can't reproduce on my phone or the android emulator

I think I figured out why. It doesn't happen on my Moto G Stylus, so I probably just remembered wrong.
It did happen on my Moto Edge (that's the phone in the video), and it seemed to be caused by the phone's edge cutting feature where it doesn't allow app content to be displayed on the waterfall sides of the display. This feature is specific to this exact Motorola phone, as I don't believe any other Moto phones are like this one.
Anyway, turning that off fixed the issue, so I'll close this. (and I used to have it off in Tachiyomi as well, as I preferred to have the entire screen be used to display manga.)


GitHub Actions

Fixes #53

Workflows are currently failing due to outage https://github.com/actions/runner/issues/1923

Planning to submit a separate PR for Ruby 3 support.

Done @dblock

Merged, thank you!


Adding automated release process

An automated release worklow. Basically adds an action that can be triggered whenever we want to do release.

Manually trigger action
Approve resulting PR with release notes
Github will automatically create the associated release

Todo:

Add npm auth token so we can do the actual publish.

@timostamm added secret references. Not much of a way to test this action except to actually run it.

Closing this as it has become a bit stale with a concurrent effort in connect-web. We are still tracking this internally in TCN-273.


wrong syntax highlight of perl code

See https://github.com/Perl/perl5/issues/20640

Syntax highlighting is managed by highlight.js. Not much I could do currently except update the packed asset and hope it gets fixed.

Updated to latest highlight.js in https://github.com/Grinnz/perldoc-browser/commit/0eb98503980eb37f6304b6797ca0ed6e0860b357 and it seems to have fixed the issue although it still isn't able to handle the C code embedded at the end but that's expected. May need to clear cache to retrieve the updated JS asset. Thanks for the report


please add active skills for pal

we need the function which can change the active skills of pal

Coming in update v0.5


[BUG] S3-SQS source pipelines can get stuck when SQS is reading from multiple buckets and one bucket has permissions issues

Describe the bug
S3-SQS source pipelines can get stuck when SQS is reading from multiple buckets and one bucket has permissions issues.
To Reproduce
Steps to reproduce the behavior:

Create an SQS queue
Create 2 S3 buckets and configure event notifications for the SQS queue in step 1
Create an IAM role with permissions needed to get objects from one of the S3 buckets (call it Bucket1)
Create an S3-SQS pipeline using the SQS queue and IAM role
Upload objects to Bucket1, the pipeline should process them correctly
Upload objects to Bucket 2, the pipeline will get 403 errors and retry
Upload objects to Bucket1, these will not be processed because the pipeline is still trying to process objects from Step 6

Expected behavior
If a pipeline hits access denied errors with one bucket it should still process objects from the other bucket

If Data Prepper fails to read the S3 object, it will keep the SQS message in the SQS queue. This is intentional. Users should configure an SQS redrive policy to an SQS DLQ. After, say 5, failed attempts SQS will automatically put this in an SQS DLQ.
I think we can do a few things to help with this:

When a failure like this occurs, change the visibility timeout to some reasonable value (say 5 minutes). This way, the message does not become available too soon.
Improve the documentation to direct users to use an SQS redrive policy and DLQ.

Another question: In this use-case, is it intentional that the user does not have access to  Bucket 2? If the user will never have access, we could add some additional configurations to ignore certain buckets and/or key prefixes.


MRG: Fix plot_compare_evokeds to support 'misc' channel type

Fixes #3963
to allow use 'misc' channels in plot_compare_evokeds. I replace _DATA_CH_TYPES_SPLIT (defined as ['mag', 'grad', 'eeg', 'seeg', 'ecog', 'hbo', 'hbr'] see here) with the same valid types defined in _plot_evoked.

Thanks for taking care of this ... Sorry, I'm sick and I have 100s of emails of backlog :(

no problem! I hope you feel better soon :-)

LGTM

@cmmoenne does this fix your plotting case?

@Eric89GXL  Yes, it solves my problem.
However, it is worth noting that there is a border case of use. When using picks's default value (list()), gfp is set to True and _pick_data_channels is used to determine data channels. As _pick_data_channels don't pick misc channels by default, plot_compare_evokeds will raise an exception when checking the number of channels to perform a GFP. Specifically, _pick_data_channels use a pick_types call with _PICK_TYPES_DATA_DICT as hardcoded parameter. Misc channels will never be able to be plotted, because _PICK_TYPES_DATA_DICT defines misc = False.
I don't know if GFP has some meaning when working with misc data, and I think that change _PICK_TYPES_DATA_DICT is too risky for such a small profit (or no profit at all). We have 2 possibilities if we want to be nice with the user:
a) raise an exception earlier: 'GFP not supported with ...'.
b) or, as the user can bypass the error by selecting channels with picks, call pick_types directly with a copy of _PICK_TYPES_DATA_DICT that sets misc to True (and other valid channels of _VALID_CHANNEL_TYPES that are also False in _PICK_TYPES_DATA_DICT). Alternatively, we can do something similar by changing the signature of _pick_data_channels with a default parameter pick_types=_PICK_TYPES_DATA_DICT, allowing change the picked types if required.
(finally, the out of the scope option)
c) As I use picks extensively in my 'misc' datasets, I suspect that a bunch of functions raise exceptions when using misc channels (don't remember which ones, but it happened to me). However, by using picks directly the errors don't raise. Perhaps what needs to be fixed lies beyond this PR.
...also, I move _VALID_CHANNEL_TYPES to io.pick in my last commit.

My vote would be to keep it simple and just do a) raise an error for now, saying to set gfp=False. We can always add the functionality in b) later if users feel like the GFP is useful/important for them in such cases.
You can add the error to this PR if you want

PR updated.
Now an error is thrown when picks is empty and no valid channels are found. Note that picking channels manually let the user plot the gfp of non-valid channels, such as misc, when gfp=True.

Codecov Report

Merging #3965 into master will decrease coverage by -0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #3965      +/-   ##
==========================================
- Coverage   86.02%   86.01%   -0.01%
==========================================
  Files         350      350
  Lines       63307    63309       +2
  Branches     9654     9655       +1
==========================================
- Hits        54459    54457       -2
- Misses       6163     6165       +2
- Partials     2685     2687       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c88601...2ad832d. Read the comment docs.

Is this good to go from your end? If so please prefix MRG to the title

LGTM

Thanks @cmmoenne


Why the log detminant of Reshape is 1?

Hi! Could you please look at the line indicated below? It is the log determinant of Reshape, which, as other reshaping methods, should be 0, but here it is 1. Correct me if I am wrong. Thanks!
https://github.com/VLL-HD/FrEIA/blob/b5d2a1ee363e8afd5c6b9435db5efa165e9ca9e4/FrEIA/modules/reshapes.py#L239

Yes, you are absolutely right. Thank you very much for pointing this out!
I have fixed it in dd51f4fa5897e017527c682a8c3508c29e507259


Update ecloud sdk

Update models
Add Active Directory Domain Operations support
Expose GPU Profile Operations on IUKFastECloudClient
Update UKFast.API.Client.Core package dependency to 1.0.4

LGTM


Update start-prerequisites.md

Changed you'll to you in last paragraph. Also Changed your to you in object oriented section.

Q
A

Is bugfix?
no

New feature?
no

Breaks BC?
no

Tests pass?
no

Fixed issues
comma-separated list of tickets # fixed by the PR, if any

Merged. Thank you!


Is not working as documented

We tried with sentiment as the output, but we are getting null.
If we used score instead of sentiment as the output, works as expected

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f32645a0-29f6-94d3-46d7-96f2c3264e60
Version Independent ID: b2b285f4-3e18-72d4-c6c3-303348c0b473
Content: Sentiment cognitive skill (V3) - Azure Cognitive Search
Content Source: articles/search/cognitive-search-skill-sentiment-v3.md
Service: cognitive-search
GitHub Login: @Careyjmac
Microsoft Alias: chalton

@cdanvergara Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @cdanvergara and @SnehaAgrawal-MSFT -- I can repro this on my search service as well.  If I use the older version of the skill, I get scores. If use the newer version (V3), I get nothing.  Can you file a support ticket against the product?  I don't think it's the docs that is broken.
I will close this issue now, since I don't think there is anything actionable for docs, but if you disagree please re-open it.  Thanks!

#please-close


RawKeyboard for iOS is unstable - inconsistent results: double and missing characters

When using RawKeyboard with QR-code scanner (HID bluetooth) connected to iOS device, it works perfectly and consistently in Swift in AppDelegate:
`    override var keyCommands: [UIKeyCommand]? {
        var commands:[UIKeyCommand] = []
        let numbers:[String] = ["0","1","2","3","4","5","6","7","8","9"]
        let letters:[String] = ["a","b","c","d","e","f","g","h","i","j","k","l","m","n","o","p","q","r","s","t","u","v","w","x","y","z"]
        for number in numbers {
            commands.append(UIKeyCommand(input: number, modifierFlags: [], action: #selector(keyPressed(_:))))
        }
        for letter in letters {
            commands.append(UIKeyCommand(input: letter, modifierFlags: [], action: #selector(keyPressed(_:))))
            commands.append(UIKeyCommand(input: letter, modifierFlags: [.shift], action: #selector(keyPressed(_:))))
        }
        commands.append(UIKeyCommand(input: "\r", modifierFlags: [], action: #selector(keyPressed(_:))))
        commands.append(UIKeyCommand(input: "_", modifierFlags: [], action: #selector(keyPressed(_:))))
        return commands
    }

    @objc private func keyPressed(_ sender: UIKeyCommand) {
        guard let key = sender.input else { return }
        if(key=="\r") {
            print("line [\(line)]")
            line = ""
        } else {
            line.append(contentsOf: key)
        }
    }
`

line [ink93002_1348042_can]
line [ink93002_1348042_can]
line [ink93002_1348042_can]
line [ink93002_1348042_can]
line [ink93002_1348042_can]
line [ink93002_1348042_can]
line [ink93002_1348042_can]
line [ink93002_1348042_can]
line [ink93002_1348042_can]

When I add the exact same code to AppDelegate in Flutter app, this becomes inconsistent:
line [ink93002_1348042_can]
line [9999993002_13480442_can]
line [in933000__1348042_can]
line [iiink93002_1348042_can]
line [ink93002_13480422caan]
line []
line [ink9302134404__an]
line [ink93002_1348042_can]

and app crashes:
Thread 1: EXC_BAD_ACCESS (code=2, address=0x16f9b3fa0)

Scanner used: Eyoyo MJ-R30
Setting scanner to slow upload did not have any effect other then slower simulated keystrokes

@jakusb
Can you provide flutter doctor -v, a minimal code sample that we can use along with detailed steps to replicate indicating what exactly are you trying to achieve / implement.
Thanks.

@jakusb
I updated a sample app with your code sample, but what's the UI look like to scan the QR code ?

@jakusb
I updated a sample app with your code sample, but what's the UI look like to scan the QR code ? ie, how do I scan the code from the app ?

For this sample app I do not use any interface to display the result.
I use this line to print to console:
            print("line [\(line)]")
So simply check the console log for the result of the scan

Can you check this issue and see if it sounds similar to your case ?

Can you check this issue and see if it sounds similar to your case ?

It is not the same issue. I do see console responses to HID input without any related textfield. Did you manage to replicate with my suggestions?
Problem is that triggered events are inconsistent double characters, missing characters, etc.
example output with same input every scan:
line [kk93002_1348800422_can]
line [k000__11348042_can]
line []
line [ik93002__1348042_can]
line [k000__1134480422_can]


chore(all): reduce cognitive complexity

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 6962fde011efa46509855beaaa6dea63ad02b703
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 2a1222f113839a663890d034768a2aa2b66b49d6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: githubautobuild-for-cdk-v2
Commit ID: 7f6f349a837efa3fdb030a821cc3e0a04040f66f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Baseline variable renames

This PR is stacked on https://github.com/obi1kenobi/cargo-semver-checks/pull/348.
In the next PR, the trait BaselineLoader and its structs will be also user for the current crate, the names won't be relevant anymore. This PR renames the trait and structs.

This is good, just resolve the merge conflict and add the manual Debug impl and it's good to go.

I'll fix the compile error.

Thanks! I wish GitHub ran rust-analyzer in WASM :)


ros2-master build failed on Galactic

Descrption
We just started examine the new galactic release. Build nav2 1.0.3 from src.
Issue
Failed to build teb ros2-master branch from src.
build seem to fail on optimal_planner.cpp.
snap shot of termnial output:

The same error shows up for foxy-devel. The g2o build seems to be fine with all the dependencies met. Yet there's conflicts when building teb_planner. I have suspicion this has something to do with C++ version used to build both.


'EntityFramework.Reflection.DynamicProxy' does not contain a definition for 'InternalQuery'

This exception occurs with the following example:
// ids is an array of integer Ids.
db.Table.Where(e => ids.Contains(e.Id)).Delete();

In my experience, that only happens when ids is empty.
As a workaround you could do:
if (ids.Any())
{
     db.Table.Where(e => ids.Contains(e.Id)).Delete();
}

I can confirm ids is not empty. Still no dice. Thought it might be an issue with ids.Contains()

yes, this  issue happens every time if you use MySQL


Mopping ECS (No BucketComponents allowed!)

About the PR

"There are times, when you find, lobsters in a bucket, can't climb out.
Why won't they climb away? Because other lobsters, pull them down."
-- Lobster Bucket, The Aquabats (1997)

This WIP PR aims to replace MopComponent and BucketComponent with a more ECS-friendly MoppingSystem and AbsorbentComponent. This is mostly a refactor with a few slight tweaks (such as being able to use a mop to drain or refill anything with drainable or refillable).
Will get #3926 to 3/4 tasks complete.
Screenshots

Changelog

:cl:

tweak: Mops can now be used to add or remove liquid from most containers. However, Nanotrasen continues to recommend the company-made "Big Yella" brand mop buckets for best results.

Hold up, I can do way better. Don't bother reviewing this yet.

(Still WIP - no review requested at this time. Light at the end of the tunnel though!)

NOW we're cooking! Some cleanup, commenting, whitespace, and bells & whistles still to add, but the main structure isn't dumbcode anymore!
I'll mark this as Ready once it's properly finished, likely in the next day or so. Comments/reviews are welcome in the meantime!

Should be good to go now! Resolved the merge conflicts on the Component files I deleted.

Coming back to this now after a break. Thanks for your review, @mirrorcult! If you'd like to weigh in on the options I commented around MoppingSystem line 291, it would further help me make this more robust 😄

Cleaned up all the little things, now only a few big things remain. I'm now seeking input from anyone (maintainers especially) on:

How can I improve the control flow in the HandleDoAfter() function? Should separate functions be made, e.g. HandlePuddle(), HandleRefillable(), HandleDrainable(), which HandleDoAfter() could then call?
Regardless of the point above, should I repeat some of the component checking logic in OnTransferComplete() as shown below, in order to postpone the heavy lifting until the doAfter succeeds?

Should be ready for review again! Thanks all 😄


Too many open files

Getting the following, goes away when I restart.
2016/02/11 21:32:46 http: Accept error: accept unix /run/docker/plugins/rexray-remote.sock: accept4: too many open files; retrying in 1s
2016/02/11 21:32:47 http: Accept error: accept unix /run/docker/plugins/rexray.sock: accept4: too many open files; retrying in 1s
Will ulimit help me fix this?

@byrnedo Can you discuss which storage driver is being used?
It would be great to get a count or see the list via lsof at some point before you get that error.
lsof -a -i
lsof -a -U
lsof

Sorry, it's ec2, I updated the title.
lsof -a -i : http://pastebin.com/5eVxnXq7
lsof -a -U : http://pastebin.com/42Xsn8Vs
lsof|wc -l : 20588

What version of docker and rexray?
On Thursday, February 11, 2016, Donal Byrne<EMAIL_ADDRESS>wrote:

Sorry, it's ec2, I updated the title.
lsof -a -i : http://pastebin.com/5eVxnXq7
lsof -a -U : http://pastebin.com/42Xsn8Vs
lsof|wc -l : 20588
—
Reply to this email directly or view it on GitHub
https://github.com/emccode/rexray/issues/291#issuecomment-183081646.

Docker 1.10
Rexray 0.3.1

Do you know how long it takes to run into this situation after the service is started?

I had been testing with about 2/3 volumes on 2 aws machines running docker swarm. After about 20 minutes I started getting that in my ssh terminal.
Initially I had gotten errors when the volumes had been created in a different availability zone.

Can you try increasing the open file limits and see if that addresses the
problem?  I do see that there is a decent amount of open files from docker
as well so it might just be a limit problem versus something that increases
over time.
Looking further into it here as well.
On Friday, February 12, 2016, Donal Byrne<EMAIL_ADDRESS>wrote:

I had been testing with about 2/3 volumes on 2 aws machines running docker
swarm. After about 20 minutes I started getting that in my ssh terminal.
Initially I had gotten errors when the volumes had been created in a
different availability zone.
—
Reply to this email directly or view it on GitHub
https://github.com/emccode/rexray/issues/291#issuecomment-183220038.

Going to wait until I see it again and will then increase the limit like you say.

Some details on this issue:
root@swarm-node-06a:~# docker version
Client:
 Version:      1.10.2
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   c3959b1
 Built:        Mon Feb 22 21:37:01 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.10.2
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   c3959b1
 Built:        Mon Feb 22 21:37:01 2016
 OS/Arch:      linux/amd64
root@swarm-node-06a:~#
root@swarm-node-06a:~# docker ps
CONTAINER ID        IMAGE                           COMMAND                  CREATED             STATUS              PORTS               NAMES
51a4bf51154c        swarm:latest                    "/swarm join --advert"   6 hours ago         Up About an hour    2375/tcp            swarm-node
089d7d521063        gliderlabs/registrator:latest   "/bin/registrator con"   6 hours ago         Up About an hour                        registrator
root@swarm-node-06a:~#

Swarm is version 1.1.2
root@swarm-node-06a:~# rexray version
Binary: /usr/bin/rexray
SemVer: 0.3.2-rc3+2+dirty
OsArch: Linux-x86_64
Branch: ec2tags
Commit: 28dfb1da585364e92d3d64dcf69f72f1795359a0
Formed: Wed, 24 Feb 2016 14:13:20 UTC
root@swarm-node-06a:~#

Here is lsof with no volume driver started:
root@swarm-node-06a:~# pgrep -afl rexray
root@swarm-node-06a:~#
root@swarm-node-06a:~# lsof | wc -l
2351
root@swarm-node-06a:~# lsof | grep rexray.sock| wc -l
0
root@swarm-node-06a:~#

Now start volume driver and check number of open sockets every 1 minute:
root@swarm-node-06a:~# rexray service start
Starting REX-Ray...SUCCESS!

  The REX-Ray daemon is now running at PID 28157. To
  shutdown the daemon execute the following command:

    sudo /usr/bin/rexray stop

root@swarm-node-06a:~# for i in $(seq 1 30) ; do lsof |grep rexray.sock|wc -l ; sleep 60 ; done
8
32
48
64
96
112
128
160
176
192
208
240
256
272
304
336
352
368
400
416
432
448
480
496
528
560
576
592
608
624
root@swarm-node-06a:~#

So 600+ leaked files in 30 minutes.
I’m not sure whom to blame here, but I suspect docker volume plugin system leaks connection to volume driver on each call.

if you watch the swarm agent logs at the same time you watching the .sock they correlate.
Notice the 1m0s
time="2016-02-24T16:52:56Z" level=info msg="Registering on the discovery service every 1m0s..." addr="<IP_ADDRESS>:12376" discovery="etcd://<IP_ADDRESS>:12379"

I suppose the call chain is swarm -> docker -> volume driver
And though its swarm who makes the call, leak itself happens in docker engine. I’ll try to look into DE code how it really works.

@echupriyanov @cpuguy83
I have been able to reproduce on my side here. It does look like Swarm is exacerbating a leak problem by issuing the List() requests.
You can see here that a docker volume ls does result in leaked files. Each call increments by 12 and this makes sense for 1.10 since 1 call is List() and the other 11 are Path()'s per volume.
[root@localhost vagrant]# docker volume ls;sudo lsof |grep rexray.sock|wc -l
DRIVER              VOLUME NAME
local               921i190k2910di290id190i2d1921i90d2
local               921i190k2910di290id190i2d1921i90d20192912i1290i12i9029021i
rexray              48ac602a85bac429400a2016d71d796
rexray<PHONE_NUMBER>123456789012345678901
rexray              6001118f6f4eb0216512a89ef244415
rexray              de4f74e72a4c0202e58b9a1cc1b59d0
rexray              8a66790a0f70706cfb0b4a0fe1dc4f0
rexray              734c30512c6af261ddd3ad5f808a454
rexray              29027582b27d8a5026ca556754891a3
rexray              testabc1
rexray              testabc
48
[root@localhost vagrant]# docker volume ls;sudo lsof |grep rexray.sock|wc -l
DRIVER              VOLUME NAME
local               921i190k2910di290id190i2d1921i90d2
local               921i190k2910di290id190i2d1921i90d20192912i1290i12i9029021i
rexray              48ac602a85bac429400a2016d71d796
rexray<PHONE_NUMBER>123456789012345678901
rexray              6001118f6f4eb0216512a89ef244415
rexray              de4f74e72a4c0202e58b9a1cc1b59d0
rexray              8a66790a0f70706cfb0b4a0fe1dc4f0
rexray              734c30512c6af261ddd3ad5f808a454
rexray              29027582b27d8a5026ca556754891a3
rexray              testabc1
rexray              testabc
60
[root@localhost vagrant]# docker volume ls;sudo lsof |grep rexray.sock|wc -l
DRIVER              VOLUME NAME
local               921i190k2910di290id190i2d1921i90d2
local               921i190k2910di290id190i2d1921i90d20192912i1290i12i9029021i
rexray              48ac602a85bac429400a2016d71d796
rexray<PHONE_NUMBER>123456789012345678901
rexray              6001118f6f4eb0216512a89ef244415
rexray              de4f74e72a4c0202e58b9a1cc1b59d0
rexray              8a66790a0f70706cfb0b4a0fe1dc4f0
rexray              734c30512c6af261ddd3ad5f808a454
rexray              29027582b27d8a5026ca556754891a3
rexray              testabc1
rexray              testabc
72

The following are manual List() POST operations that do not result in leaks as shown with the consistent 72 count.
[root@localhost vagrant]# echo -e "POST /VolumeDriver.List HTTP/1.1\r\nContent-Length: 132\r\n\r\n{}\r\n" | socat unix-connect:/run/docker/plugins/rexray.sock STDIO && sudo lsof |grep rexray.sock|wc -l
HTTP/1.1 200 OK
Content-Type: application/vnd.docker.plugins.v1.2+json
Date: Wed, 24 Feb 2016 23:56:15 GMT
Content-Length: 354
Connection: close

{"Volumes":[{"Name":"48ac602a85bac429400a2016d71d796"},{"Name":"1234567890123456789012345678901"},{"Name":"6001118f6f4eb0216512a89ef244415"},{"Name":"de4f74e72a4c0202e58b9a1cc1b59d0"},{"Name":"8a66790a0f70706cfb0b4a0fe1dc4f0"},{"Name":"734c30512c6af261ddd3ad5f808a454"},{"Name":"29027582b27d8a5026ca556754891a3"},{"Name":"testabc1"},{"Name":"testabc"}]}
72
[root@localhost vagrant]# echo -e "POST /VolumeDriver.List HTTP/1.1\r\nContent-Length: 132\r\n\r\n{}\r\n" | socat unix-connect:/run/docker/plugins/rexray.sock STDIO && sudo lsof |grep rexray.sock|wc -l
HTTP/1.1 200 OK
Content-Type: application/vnd.docker.plugins.v1.2+json
Date: Wed, 24 Feb 2016 23:56:16 GMT
Content-Length: 354
Connection: close

{"Volumes":[{"Name":"48ac602a85bac429400a2016d71d796"},{"Name":"1234567890123456789012345678901"},{"Name":"6001118f6f4eb0216512a89ef244415"},{"Name":"de4f74e72a4c0202e58b9a1cc1b59d0"},{"Name":"8a66790a0f70706cfb0b4a0fe1dc4f0"},{"Name":"734c30512c6af261ddd3ad5f808a454"},{"Name":"29027582b27d8a5026ca556754891a3"},{"Name":"testabc1"},{"Name":"testabc"}]}
72

Hmm, I could see a potential leak if there is an error, but not otherwise.

@cpuguy83 I believe I narrowed it down to the init process for the plugins. A docker volume ls looks to reinitialize all plugins from spec/socks.
[root@localhost vagrant]# cat /tmp/docker.log | grep rexray
8947  lstat("/run/docker/plugins/rexray.sock", {st_mode=S_IFSOCK|0755, st_size=0, ...}) = 0
8947  stat("/run/docker/plugins/rexray.sock", {st_mode=S_IFSOCK|0755, st_size=0, ...}) = 0
8947  connect(12, {sa_family=AF_LOCAL, sun_path="/run/docker/plugins/rexray.sock"}, 34) = 0
8947  getpeername(12, {sa_family=AF_LOCAL, sun_path="/run/docker/plugins/rexray.sock"}, [34]) = 0
[root@localhost vagrant]# docker volume ls ;sudo lsof |grep rexray.sock|wc -l
DRIVER              VOLUME NAME
rexray              testabc4
18
[root@localhost vagrant]# cat /tmp/docker.log | grep rexray
8947  lstat("/run/docker/plugins/rexray.sock", {st_mode=S_IFSOCK|0755, st_size=0, ...}) = 0
8947  stat("/run/docker/plugins/rexray.sock", {st_mode=S_IFSOCK|0755, st_size=0, ...}) = 0
8947  connect(12, {sa_family=AF_LOCAL, sun_path="/run/docker/plugins/rexray.sock"}, 34) = 0
8947  getpeername(12, {sa_family=AF_LOCAL, sun_path="/run/docker/plugins/rexray.sock"}, [34]) = 0
8947  lstat("/run/docker/plugins/rexray.sock", {st_mode=S_IFSOCK|0755, st_size=0, ...}) = 0
8947  stat("/run/docker/plugins/rexray.sock", {st_mode=S_IFSOCK|0755, st_size=0, ...}) = 0
8947  connect(13, {sa_family=AF_LOCAL, sun_path="/run/docker/plugins/rexray.sock"}, 34) = 0
8947  getpeername(13, {sa_family=AF_LOCAL, sun_path="/run/docker/plugins/rexray.sock"}, [34]) = 0

It looks like store.getVolume() and store.list() are calling volumedrivers.GetAllDrivers() causing the behavior.

@byrnedo @wallnerryan I believe I have a fix in place for this now as referenced in PR https://github.com/docker/docker/issues/20686.  Thank you for tracking.

Thanks @clintonskitson


Ramp rate sensitivity analysis - assess parameter values and order of aggregation

shell issue

@TrentonBush is this still relevant?

Maybe for Sloan work, but probably not. I'll reopen it if so.


Issue with k8s.io/docs/concepts/services-networking/network-policies/

This is a...

[ ] Feature Request
[ x] Bug Report

Problem:
The example on the 1.7 documentation does not work. I get:
error validating data: found invalid field ipBlock for v1.NetworkPolicyPeer;
Page to Update:
https://v1-7.docs.kubernetes.io/docs/concepts/services-networking/network-policies/

Doc team doesn't have a bandwidth or plan to actively maintain old docs.
/close


Color.lerp does not maintain equality

Use case
I'd like to make sure a widget only rebuilds when colorScheme.primary changes.

Test
import 'dart:ui';
import 'package:flutter_test/flutter_test.dart';

void main() {
  test('Color can lerp and maintain equality with itself', () {
    const color = Color(0xFF123456);

    expect(Color.lerp(color, color, 0.0), color);
    expect(Color.lerp(color, color, 0.1), color);
    expect(Color.lerp(color, color, 0.2), color);
    expect(Color.lerp(color, color, 0.3), color);
    expect(Color.lerp(color, color, 0.4), color);
    expect(Color.lerp(color, color, 0.5), color);
    expect(Color.lerp(color, color, 0.6), color);
    expect(Color.lerp(color, color, 0.7), color);
    expect(Color.lerp(color, color, 0.8), color);
    expect(Color.lerp(color, color, 0.9), color);
  });
}

The test fails due to tiny floating point rounding errors 😃 😃

We could make Color.lerp(a, a) always return a but I doubt that is what you are asking; the problem is that Color now stores the underlying data as floating point numbers (for wider color ranges), and of course floating point numbers cannot be perfectly maintained the way fixed point integers were.
A few ideas (not mutually exclusive):

Add a note on Color that explains how equality now works, and what to do.
Add a method, such as [Color.isCloseTo] directly on the class
Remove equality and hashCode entirely from the class, given it is unlikely to be stable in the same way it was before

Defer of course to @gaaclarke who has been leading the color improvement effort.

Hey @nate-thegrate, this is expected behavior and is addressed in the breaking change notice: https://docs.flutter.dev/release/breaking-changes/wide-gamut-framework#equality
The only guarantee we should make with respect to colors made with the 8 bit-per-pixel constructors is that unadulterated they will remain equal (Color(0xaabbccdd) == Color(0xaabbccdd)).  In practice, integer addition, subtraction and multiplication should be fine for small numbers.

A few ideas (not mutually exclusive):
Add a note on Color that explains how equality now works, and what to do.

I'm open to this.  It could mention isSameColorAs .

Add a method, such as [Color.isCloseTo] directly on the class

Given the times this has come up has been in tests I would rather just lean into isSameColorAs.

Remove equality and hashCode entirely from the class, given it is unlikely to be stable in the same way it was before

I think developers can manage.  What Nate didn't show was the error message you get when these equality tests fail.  I think the solution is pretty obvious when you see what prints out (something like expected Color(alpha: 1.000, red: 0.9999, green: 1.000, blue: 1.000), but got Color(alpha: 1.000, red: 1.000, green: 1.000, blue: 1.000)).

In Nate's case, it's in his actual code - he wants to use equality to avoid widget rebuilds.

Okay, in that case I think it's up to the user to define their own criteria for color closeness.  My preference is that we leave that out of dart:ui since there are a lot of different ways people could define closeness of colors, and it's usually a couple of lines.
Like should Color.from(alpha: 1, red:1, blue: 0, green: 0).isCloseTo(Color.from(alpha: 1, red: 0.9175, blue: 0.2004, green: 0.1385)) == true.  They are the same color, but in different color spaces.  Or how about using vector distance?  Or converting to a colorspace that better matches perception like XYZ to do comparison?  I think anything beyond literal bitwise equality should be left to users of Flutter.

Perhaps instead of something in dart:ui, this issue could be fixed with a change to the color scheme implementation:
class ColorScheme {
  final Color primary;
  final Color onPrimary;
  // ...

  @override
  bool operator==(Object other) {
    if (other is! ColorScheme || other.runtimeType != runtimeType) {
      return false;
    }
    if (identical(this, other)) {
      return true;
    }
    return other.primary.isCloseTo(primary)
        && other.onPrimary.isCloseTo(onPrimary)
        // etc.
  }

  @override
  int get hashCode => // ???
}

IMO the easiest change would be to add a guard statement to Color.lerp:
  static Color? lerp(Color? x, Color? y, double t) {
    assert(x?.colorSpace != ColorSpace.extendedSRGB);
    assert(y?.colorSpace != ColorSpace.extendedSRGB);
+   if (t == 0.0 || x == y) return x;
+   if (t == 1.0) return y;
    // ...
  }

Interested to hear thoughts!

I bet https://github.com/flutter/engine/pull/55496 would help several folks out, thanks!
If there's a reason we'd want to avoid guard statements in Color.lerp, it wouldn't be a huge deal, since it'd be easy to just add them to a private _lerpColor() function in color_scheme.dart.

Remove equality and hashCode entirely from the class, given it is unlikely to be stable in the same way it was before

I've put some thought into this idea—given Color's ubiquity, it'd be nice to reduce the amount of bloat in the class if possible—but there is an advantage to retaining the == / hashCode implementations:
final a = Colors.grey.withValues(alpha: 0.5);
final b = Colors.grey.withValues(alpha: 0.5);

a == b; // true

There are still spots where you have identical configuration on non-identical Color objects, so the equality implementation is nice for that.

It sounds like we've decided the docstring update is what we'll do at this time.


perf(logger): Remove unnecessary heap allocations

Use here, below, and in similar places, theformat_args!() macro instead, to omit redundant allocations produced by the format!() macro (as it returns a new String).
https://github.com/juspay/orca/blob/01cafe753bc4ea0cf33ec604dcbe0017abfebcad/crates/router_env/src/logger/formatter.rs#L207
https://github.com/juspay/orca/blob/01cafe753bc4ea0cf33ec604dcbe0017abfebcad/crates/router_env/src/logger/formatter.rs#L213
Redundant allocation on heap. This code produces the redundant String allocation as the result of format!() macro call. Omit it by writing into the formatter directly with write!() macro:
::core::write!(f, "{:?}", self)

https://github.com/juspay/orca/blob/01cafe753bc4ea0cf33ec604dcbe0017abfebcad/crates/router_derive/src/macros.rs#L23
This code contains redundant heap allocation .to_string() allocations, because we can write directly into the formatter:
write!(f, "{}", serde_json::json!({"error": &self.err }))

https://github.com/juspay/orca/blob/01cafe753bc4ea0cf33ec604dcbe0017abfebcad/crates/router/src/utils.rs#L37-L42
Checklist

[ ] #1293
[ ] #1294

@NishantJoshi00 I would like to look at this. Please can you assign this to me

Hey @jeevaprakashdr, that's for the interest. As you have already noticed, this issue contains 2 distinct perf improvements, that are in need of solutioning. I'll split this issue into 2 parts, and we can use this issue to track those sub-issues.
I'll gather some context, and create the sub-issues. Then we can, discuss on the solutions and I'll assign the sub-issues to you.

@NishantJoshi00  That would be great!  Keep me posted.


RN-145 Add support for sentry error tracking

Summary
This PR adds the ability to use Sentry to log application errors. To use follow the below steps:

Install sentry cli using brew install sentry-cli
Create a config.json file in the assets/override folder with the following:

{
    "EnableSentryLogging": true,
    "SentryAuthToken": <YourSentryAuthToken>,
    "SentryDSN": <YourSentryDSN>,
    "SentryOrg": <YourSentryOrgSlug>
    "SentryProject": <YourSentryProjectSlug>
}

Create a sentry.properties file in the android folder with the following:

defaults.org=<YourSentryOrgSlug>
defaults.project=<YourSentryProjectSlug>
auth.token=<YourSentryAuthToken>

Once complete run make run-ios or make run-android and the application will now report all errors and crashes to your Sentry portal.
Ticket Link
https://mattermost.atlassian.net/browse/RN-145
Device Information
This PR was tested on:
iPhone 6 iOS 10
iPhone 7 iOS 10
Galaxy s7 - Android 6.0 API 23

@enahum Added to NOTICES.TXT


TinDog- A dating site for dogs

Keeping tinder in mind, this is a webpage for finding a perfect match for your dog. It's a static website created using HTML, CSS, and Bootstrap.

I have heard about shaadi.com jeevansathis.com first time heard about dog dating

Well, everyone wants a good partner XD.
LOL
On Wed, 5 Oct 2022 at 19:29, projectsop @.***> wrote:

I have heard about shaadi.com jeevansathis.com first time heard about dog
dating
—
Reply to this email directly, view it on GitHub
https://github.com/codemistic/Web-Development/pull/157#issuecomment-1268476727,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUAV6CB6BOI2QLCIKPALU63WBWCVDANCNFSM6AAAAAAQ5GH4NI
.
You are receiving this because you authored the thread.Message ID:
@.***>

unable to merge rn
will fix it soon


Failed to run automated scorecard-action@main test-organization-ls/scorecard-action-private-repo-tests

https://github.com/test-organization-ls/scorecard-action-private-repo-tests/actions/runs/2217769550

https://github.com/ossf/scorecard-action/issues/189#issuecomment-1103181694
I think this is what's causing this, #200, and #199 to fail. I'm not sure which permission is missing though--but adding read-all fixes it. Is there a certain permission necessary for workflows to make API requests?

no permission means all permissions default to none. On a public repo it's not a problem because the repo is public. On a private repo you need to be able to read it so you must declare some read permissions.. not sure which ones exactly. read-all is fine

This is a great finding @rohankh532 @laurentsimon. We need to update our GitHub partnered workflow to include these changes before rolling out Golang:

top-level read-all permissions
id-token: write permission
GITHUB_TOKEN by default with a comment to use PAT if Branch-Protection is needed.

the starter workflow already has these, except for the GITHUB_TOKEN which will be done once everything else is wrapped up and reading for the release.

This is a great finding @rohankh532 @laurentsimon. We need to update our GitHub partnered workflow to include these changes before rolling out Golang:

top-level read-all permissions

already the case.

id-token: write permission

correct.

GITHUB_TOKEN by default with a comment to use PAT if Branch-Protection is needed.

this is in the TODO list once we've verified that everything else works. https://github.com/ossf/scorecard-action/pull/203 is waiting for approval to merge this change in our doc as a first start.

@laurentsimon isn't the repo this is being run on public? https://github.com/test-organization-ls/scorecard-action-private-repo-tests

Here's what's happening on the server end.

PR ossf/scorecard-webapp/#85 should fix this

nope, this is is private. Can you confirm that you cannot visit the repo?
The logs show "bad gateway", I thought. The bad gateway is likely to be because it's a private repo.
Ouch, another nil pointer: did we push the code change to k8 cluster (k8 apply -f)? The nil pointer seems like it's thee same error as last week before we made the change

got it, so have not merged it yet.


[C++] Sync server ignores thread creation error, leads to single-threaded behavior

What version of gRPC and what language are you using?
gRPC 1.20.1, C++, but the bug exists in master as well (by code inspection)
What operating system (Linux, Windows,...) and version?
Ubuntu Linux 18.04
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc 7.3
What did you do?
Opened many concurrent connections to sync gRPC server; thread creation failed, and the sync gRPC server does not recover from that (num_pollers_ and num_threads_ become incorrect) and ends up using one single thread to process all connections.
Detailed analysis below.
What did you expect to see?
Closing the connection with RESOURCE_EXHAUSTED if thread creation fails.
What did you see instead?
We had a load spike (due to what is likely a bug in our system, we ended up with 20k concurrent connections to this sync C++ server).  We were running with the default configuration, min_pollers_ = 1, max_pollers_ = 2.
The sync C++ server attempts to keep at least 1 poller thread around to handle new connections, so it spawns new threads whenever new connections arrive: https://github.com/grpc/grpc/blob/57bae312b97b2388b03fc55ebea466aeb66c8d6d/src/cpp/thread_manager/thread_manager.cc#L180
However, the WorkerThread constructor does not handle the case where the OS thread creation fails. grpc_core::Thread signals thread creation error in the success output parameter to the Thread constructor: https://github.com/grpc/grpc/blob/57bae312b97b2388b03fc55ebea466aeb66c8d6d/src/core/lib/gprpp/thd.h#L86
However the WorkerThread constructor doesn't pass a success argument: https://github.com/grpc/grpc/blob/57bae312b97b2388b03fc55ebea466aeb66c8d6d/src/cpp/thread_manager/thread_manager.cc#L34
Because thread creation failed, num_pollers_ is now erroneously always at least 1 (the new thread never gets a chance to decrement it, as it never started), and so the check in https://github.com/grpc/grpc/blob/57bae312b97b2388b03fc55ebea466aeb66c8d6d/src/cpp/thread_manager/thread_manager.cc#L170 never fires again.
This means that the sync server never creates more threads in response to requests any more, and so uses only one thread to process requests from that moment onwards.
The fix would be to handle thread creation failure gracefully.
cc: @igorcanadi @ari-e

Thanks for the detailed investigation. I'll take a look at this. Do you have a code segment to repro the failure by any chance?

No; this happened in production for us, and we haven't tried to reproduce in isolation. If it were me, I'd probably force thread creation failure (either probabilistically or with some global flag) while testing a fix for this bug.

Closing as duplicate of #20366


Fix error when removing temp_step_files directory

The script prints an error message when only one processing step is set in the config.
That is because no temp_step_files directory is created in that case and the rm command returns an error if the given file or directory does not exists.
These changes check if the directory exists before using rm

Looks good


Implement "URL" to open app with predefined values

Allow to click a vehicle in windshield and start tracking this specific vehicle using stasi.

I am slightly confused about this issue.
So when u click on a vehicle in windshield there should be the options to track this vehicle in stasi ? an then the app opens on mobile ?

Correct

This would be helpful if you can't see the run number on the vehicle and don't want to copy it from. Windshield, so you could just click in windshield.

maybe smart to add it to the sidebar in windshield but I dont know whats is needed for opening and app on mobile

Example in Kindergarten:
Select a vehicle and click "Track within Stasi", which would automatic opens the App and prefill the text fields with all values regarding the selected vehicle:


generate output relative to node_modules/@prisma/client

Problem
In our NX-based repository. We have several libraries that can contain their own schema.prisma.
The best place to then generate the prisma client is node_modules/@prisma/client/{module_name}. Because this is fully supported and does not cause the desired problems.
If the path is outside node_modules like
./src/generated
then in the case of multiple schemas it will break with a runtime error message
Error: Could not find mapping for model ...
But to achieve the generation to node_modules you need to specify the path relatively
for example
generator client {
    provider = "prisma-client-js"
    output = "../../../../node_modules/@prisma/client/moduleA"
    // import from '@prisma/client/moduleA'
}
// or moduleB
generator client {
    provider = "prisma-client-js"
    output = "../../node_modules/@prisma/client/moduleB"
    // import from '@prisma/client/moduleB'
}

which doesn't seem very practical to me.
Another problem with this approach is that in subsequent builds and deployments via docker. You need to re-generate @prisma/client. We have written a script that copies all schema.prisma from the libraries the application depends on to the dist folder. We then use the script to have all the @prisma/client re-generated.
find prisma -name '*.prisma' -exec npx prisma generate --schema={} \;

which works relatively well. But the problem arises in the path where the @prisma/client is generated. It's not to the node_modules of the application, but is created relative to the application. so it may create multiple node_modules in the parent folders.

Suggested solution
Because prisma if it doesn't have output set automatically generates to node_modules/@prisma/client. I think it would be practical to add an alternative option instead of output, for example clientName, which keeps the path to node_modules/@prisma/client but adds the clientName to path node_modules/@prisma/client/{clientName}
generator client {
    provider   = "prisma-client-js"
    // output  = "../../../node_modules@prisma/client/moduleA"
    clientName =  "moduleA"
    // import from '@prisma/client/moduleA'
}

Additional context
"prisma": "^4.8.0",
"@prisma/client": "^4.8.0",
"nx": "15.4.2",
"@nrwl/workspace": "15.4.2",
"@nx-tools/nx-prisma": "^4.0.2",

Yes, that would be useful :)

We have the same issue as well.
Related issues : #8326 #2443
This comment highlights an instance where a user encounters an error when trying to use a custom output:
https://github.com/prisma/prisma/issues/2443#issuecomment-1019611749
This comment highlights how you currently have to work around the above issues, which is what this issue is addressing:
https://github.com/prisma/prisma/issues/2443#issuecomment-1110434344

I think it would also be convenient to add a CLI flag for generate to override output path, so that you can customize it for nx monorepo/docker build workflow

For mono-repo
Have a package for your database e.g. "database-a" with the following:
package.json
{
  ...
  "type": "module",
  "dependencies": {
    "@prisma/client": "^4.11.0",
    "prisma": "^4.11.0"
  }
  ...
}

schema.prisma
...
generator client {
  ...
  output = "./client"
}
...

index.js
export * from "./client/index.js"

Note that the location of the client may be different depending if you put your schema.prisma file inside the root folder of the package or inside /prisma/
Now you can import your database client using the following
import { PrismaClient as PrismaClientA } from 'database-a'
const prismaA = new PrismaClient()

Today, I also stumbled upon this issue. We are using npm workspaces, and the entire repo has one node_modules in the project's root. So the 2nd prima module conflicted with the first one.
The only alternative (workaround) I found was to indeed use a variant of the solution above. I generate the client in the ./src directory, and git ignore that folder.
The solution from the OP would be way more convenient though.

Would love to bring back a discussion on this. We're big advocates for NX which uses a single node_modules folder.
We also commonly have to work with multiple different databases in the same project. It would be huge to be able to generate Prisma clients by a specific name as mentioned above.
Since the postinstall hook only accounts for schema.prisma placing it into node_modules requires some custom scripts to handle this which can be annoying.


[1.18.1] rocket disappear unable to leave earth

Minecraft Version
1.18.1
Forge Version
39.0.5
Space-BossTools or Beyond Earth Version
1-6.0b
Addon Mod Version (This Mod)
1.18.1-1.4
The details
in server
launch rocket
rocket despawns before reaching orbit player fell down every time.
works if i enable creative or in single player game but not on server

it looks parent mod's problem
what use you server program?

i use another quality modpack 3 on forge

can i get that modpack url?

https://www.curseforge.com/minecraft/modpacks/another-quality-modpack-3

thx, i will test
tt may take a little while!

not a problem i need a fix haha :D so take your time :)

what did you click on server? (yellow, green)
green : create space station, and teleport to orbit dimension
yellow : just go to orbit dimension, if you not create space station, fell down to earth
so other sentence, require green button first

i dont get that screen. rocket fly up to height limit then disapear and i am falling down

is BeyondEarth version 6.0b right?

yes that ius correct ok thanks anyway


Add autoscaler balancing ignore labels args

What this PR does / why we need it:
This ensures that cloud platform specific node labels are ignored by the cluster autoscaler
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #HOSTEDCP-711
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[x] This change includes unit tests.

Nice, thanks!
/approve
/lgtm

cc @elmiko you aware of any other label we should be adding here?

/unhold
/retest-required


algos in golang

rewritting of the algos in golang with visualization of the benchmarks

translation of the C code of all the algorithms in the GOlang.


Implicit C# expressions should launch completion on "."

Describe the bug:
A clear and concise description of what the bug is.
Version used:
e.g. VS2022 17.1 Preview 1
To reproduce:
Steps to reproduce the behavior:

Go to any .razor file
Type @DateTime. in any empty space
You would expected to see a completion but one is not available, and even explicitly invoking completion does not get one

Expected behavior:
Completion is offered after typing "."
Actual behavior:
No completion is available, even when explicitly invoked.
Additional context:
If I had to guess I'd say that this is (at least rooted in) a compiler issue. I'm betting that the . is read as an HTML literal instead of as incomplete C# and so the C# completion paths don't trigger because there's no C# mapping.

Should be fixed in latest


Unmable to make LED blink.

I have taken the code from https://rahul-thakoor.github.io/physical-computing-rust/step_6.html#flashing-an-led
And tried to use the version not with a build method. The LED turns on, and does not turn off.
I added printlines to view as shown here
extern crate rust_gpiozero;

use rust_gpiozero::*;
use std::{thread::sleep, time::Duration};

fn main() {
    let mut led = LED::new(17);

    loop {
        println!("Turning on");
        led.on();
        println!("Is on");
        sleep(Duration::from_secs(1));
        println!("Turning off");
        led.off();
        println!("is on");
    }
}

Still no effect.
Using a Raspberry Pi Zero W with GPIO pins added on found here.
Crate version is 0.2.1
Any further information please feel free to ask.
Thanks in advance for any assistance/investigation.

Hi @parkeradam - I've tested your code and found the issue: you need to add a sleep step after the LED is turned off. What is currently happening is that the loop ends with led.off(), then immediately restarts with led.on(), which results in the LED never turning off visually since this happens so quickly.

I'm closing this issue given it has been addressed with the above comment. Feel free to reopen if that is not the case.


Fix baselines after PR 58621

This PR was not up to date with main and had not been recently run.

Perhaps the merge queue feature could be used to avoid this problem?

Our tests take a while to run, so it probably will slow things down a bit while removing the ability to figure out which commit was the one that actually failed (instead of just the merge group), so I'm not sure if it's all good. But technically yes.


tpm2_evictcontrol doesn't handle passwords properly

Passing -P  to tpm2_evictcontrol exits immediately because of mishandling the return value of password_util_copy_password. The fix is one character, as below.
diff --git a/tools/tpm2_evictcontrol.c b/tools/tpm2_evictcontrol.c
index 565f8b7..8dc9d6a 100644
--- a/tools/tpm2_evictcontrol.c
+++ b/tools/tpm2_evictcontrol.c
@@ -155,7 +155,7 @@ static bool init(int argc, char *argv[], tpm_evictcontrol_ctx *ctx) {
         case 'P': {
             bool result = password_util_copy_password(optarg, "authenticating",
                     &ctx->session_data.hmac);
-            if (result) {
+            if (!result) {
                 return false;
             }
             flags.P = 1;

Thank you for the patch, I gave you credit as the author, if you have time please review the PR #257


Improve active link highlighting for edge cases

Found another interesting bug: active navbar link highlighting is broken in HEAD, basically browser always highlight the section before the one that is currently in view.
Can be reproduced on the demo site (just click on any navbar link): https://academic-demo.netlify.com/
I did not have a chance to dig too deep but from a cursory look it does seem to be caused by mismatching styles referencing different navbar heights (seems like navbar used to be 70px tall and is 50px tall now). The 20px in difference seem to be enough to trip the scrollspy logic.

The issue is more complex. There are two dynamic height components - Portfolio widget and navbar - which can cause issues in some edge cases.
I have a local fix for ScrollSpy which I'll push to master soon.

Ok great, thanks for looking into this!

Thanks, works much better.
Not sure if it's intended but this does not seem to highlight "Home" by default when first landing on the site, but perhaps that is intended?

That's unrelated - in the Demo, we link Home to the About widget (i.e. after the widgets which introduce Academic) in menus.toml. We could change the text to About instead, but at least with the current way it's slightly easier for users to create their site based on the Demo if they wish.

It could be unrelated, but if the intent is for Home to be highlighted if About were to be the first widget, I am not sure it is working as intended, at least based on this preview of my demo site: https://deploy-preview-3--abahgat.netlify.com/
Home is the first widget on my site, and previous versions of the theme did highlight it by default.

I see you weren't referring to the Demo. That issue should be fixed now too.

Thanks!

this issue still exists? Eg see the demo site: https://academic-demo.netlify.app/, click on publications and it takes you to publications but projects is highlighted in the navbar
i have the same issue on my hugo academic site: https://pmbrown.net/
any idea how i can fix it? cheers