Migrate from golang/mock to go.uber.org/mock

Google no longer maintains the golang/mock package. Maybe we can migrate from golang/mock to go.uber.org/mock.
https://github.com/golang/mock#gomock

Update, June 2023: This repo and tool are no longer maintained. Please see go.uber.org/mock for a maintained fork instead.

https://github.com/uber-go/mock#gomock

This project originates from Google's golang/mock repo. Unfortunately Google no longer maintains this project, and given the heavy usage of gomock project within Uber, we've decided to fork and maintain this going forward at Uber.

Hey @shi0rik0 can you tell me more about the issue? I want to contribute to this issue. I am new to open source can you explain what the issue is really asking for?

@KirtiKamal Welcome!
I think the issue is pretty straightforward: this repository makes extensive use of golang/mock in unit tests (for mocking), but that project is no longer maintained. The recommendation from Google is to migrate to the Uber fork which is actively maintained: github.com/uber-go/mock.
A good place to start is to search through references to golang/mock in this repository (using git grep "golang/mock") and update them to point to the new module. If there were no API changes in the Uber fork, you may not need to update any other code. All that's required is a little bit of hands-on experience with Golang; if there are questions about the build process in Antrea, we can answer them.
Refer to https://github.com/antrea-io/antrea/blob/main/CONTRIBUTING.md#building-and-testing-your-change for instructions on how to test your changes.
If you are interested in working on this and can do so in the near future, please let us know and I can assign the issue to you.

Hi @antoninbas, is this issue already assigned? I'm interested to take this up and complete in next couple of weeks.

@aniketraj1947 sorry for the delay, I was on vacation. AFAIK, no one has claimed the issue yet, so I will assign it to you. Please let us know if no longer intend to work on this, so that someone else can pick it up.

Hi @antoninbas, can you review this PR - https://github.com/antrea-io/antrea/pull/5518 or assign reviewers for the same? Thanks!


ListenerContainerWithDlqAndRetryCustomizer template points to localhost:9092

Hi,
I am using following dependencies
spring-cloud-stream: 3.21
spring-cloud-stream-binder-kafka: 3.21
spring-kafka: 2.8.2

To forward deserialization errors to DLQ, I added the following bean:
	@Bean
	ListenerContainerWithDlqAndRetryCustomizer cust(KafkaTemplate<?, ?> template) {
		return new ListenerContainerWithDlqAndRetryCustomizer() {
			@Override
			public void configure(AbstractMessageListenerContainer<?, ?> container, String destinationName,
					String group,
					BiFunction<ConsumerRecord<?, ?>, Exception, org.apache.kafka.common.TopicPartition> dlqDestinationResolver,
					BackOff backOff) {
				ConsumerRecordRecoverer dlpr = new DeadLetterPublishingRecoverer(template, dlqDestinationResolver);
				container.setCommonErrorHandler(new DefaultErrorHandler(dlpr, backOff==null? new FixedBackOff(0L, 1L):backOff));
			}
                        ......
		};
	}

I have the following configuration in application.yml
spring.cloud:
    schemaRegistryClient:
      endpoint: .....
    stream:
      default:
        consumer:
          maxAttempts: 1
      function:
        definition: myDataConsumer
      bindings:
        myDataConsumer-in-0:
          destination: input-topic
          ....
        myDataConsumer-output:
          destination: output-topic
          ...
      kafka:
        default:
          consumer:
            useNativeDecoding: true
            enableDlq: true
            dlqName: dlq-topic
        bindings:
          myDataConsumer-in-0:
            consumer:
                ...
        binder:
          brokers: "broker1Url,broker2Url"
          producer-properties:
               ...

When the application runs and if there are Deserialization errors, it tries to produce to non-existent  localhost:9092 instead of the brokers in the config.
What am I missing?
Thanks in advance

You are wiring in Boot's auto-configured KafkaTemplate. Boot knows nothing about binders or binder configuration; it uses the normal Boot spring.kafka.... properties when configuring that template.
https://docs.spring.io/spring-boot/docs/current/reference/html/application-properties.html#application-properties.integration.spring.kafka.bootstrap-servers

Thanks @garyrussell .
It worked on configuring the spring.kafka properties as you mentioned.
I assumed it would pick the server settings from the binder configuration based on
https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/blob/main/docs/src/main/asciidoc/overview.adoc#retry-and-dead-letter-processing

Reopening; we should improve that documentation.

Issue moved to spring-cloud/spring-cloud-stream #2313 via ZenHub

Little writeup to make it easy for others
https://medium.com/@sidsamanta/spring-cloud-stream-kafka-errors-to-dead-letter-queue-dlq-bb4078d9c6a0


Language selector applied to Flex

Language selector added to the original template has now been added to Flex template refactoring it.

thanks @jose-oc  and @xxxtonixxx  for your feedback


Ipad Bazqux feeds not updating

Hi, I’m using an iPad Pro and iOS NetNewsWire, using Bazqux for news feeds. I was able to add Bazqux and my feeds synched a few days ago but now it’s not synching. I can use Unread on my phone or Vienna on MacOS without issue. Thanks.

If you do a manual refresh, do you get an error?

No error message. The progress bar moves but no new updates.

Did this clear up for you @twilight-moon? I think we must have some incompatibility with BazQux that we should talk to their team about. It seems that every once in a while it temporarily stops syncing.

It hasn't cleared up yet. Thanks.

Try and input your Bazqux password again, in the settings. I've had macOS NNW loose mine on several occasions.

I'm getting the same issue, but on the iPhone. If I log out and back in using my credentials the issue will temporarily correct itself and feeds will be fetched. However, a few hours later the issue starts again with no feeds being synced.

We are looking into this problem. I'm having trouble recreating it, but haven't stopped working on it.

Any way we can help? I've seen it once on iPad OS, and about ten times on macOS. Strangely, when it happens for me, the iPad retains the password in the preferences dialog, while the macOS version doesn't. They both retain the username.

I was finally able to successfully recreate this. We had thought we were losing the API token, but that doesn't seem to be the case. It looks like BazQux expires it's API token every 14 days. We need to add code to automatically reauthorize if the API token is expired to fix this.

This has been fixed and will be in the next releases for both iOS and the Mac.


Tool tip over polygon layer on hover.

Hi, by any chance can we add a tooltip over any layer, specifically on polygon layer?

Hi @vsarthak21 , sorry for the late reply. This is in our roadmap this year. We have considered to support this feature in the future release soon. Will keep you posted. Thank you very much.


add git target branch option

We often have multiple Storybook branches being reviewed for a single developer at any given time. For this reason, it would be nice to support a target branch and serving via rawgit as well as gh-pages. I've tested in Patternfly and it works fine - please let me know if you'd like any modifications to this.
To keep this simple, I've built on top of @tsargent's remote option PR...

Thank you, guys!
@priley86 @orta @tsargent @ankurp @brycedorn are you interested in maintaining this repo?

@UsulPro I am interested in maintaining this repo.

@UsulPro sure - i'd be happy to help w/ reviews here. We will continue using Storybook for the foreseeable future on the Patternfly React team (Red Hat User Experience Design). Absolutely <3 this tool.
Thanks for the merge w/ this PR and let us know what we can do to help 🎉 🎈

@ankurp and @priley86 - I've invited you both to be collaborators on the project 👍
I'll also be keeping an eye on it, as we use it at Artsy 🍰

@UsulPro we actively use it here at FMG too! I'll be sure to check in from time to time & make future PRs if we ever run into issues 🙂


Branch update dg

Update the diagram to "editt" in DG
Update "updatet" to "editt" in UG

Codecov Report

Merging #144 (51b0b1b) into master (817e834) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #144   +/-   ##
=========================================
  Coverage     59.53%   59.53%
  Complexity      484      484
=========================================
  Files            99       99
  Lines          1920     1920
  Branches        209      209
=========================================
  Hits           1143     1143
  Misses          706      706
  Partials         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 817e834...51b0b1b. Read the comment docs.


0.30 sys backend audit with valgrind

Ran all the tests in the project in valgrind assuming that #447 is merged:
https://gist.github.com/i509VCB/81726a541c2fe96e1446ff7c2fbc77b3
There are three types of leaks I've found while analyzing the log:
Client

wl_proxy_marshal_array_constructor_versioned inside Handle::send_request.
wl_display_read_events inside Handle::try_read

Server

Handle<D>::create_global

globals are not destroyed at drop time.

wl_proxy_marshal_array_constructor_versioned and wl_display_read_events

Those ones is use leaking every wayland object that was not explicitly destroyed by protocol messages, because contrarily to its documentation, wl_display_disconnect does not "free all resources" associated with the connection. Not quite sure what to do about that, tracking all wayland objects to properly destroy them on drop would add significant overhead.

Handle<D>::create_global

Indeed, there are no "global destructrors" in libwayland, so we should probably track them to properly free them.

According to https://gitlab.freedesktop.org/wayland/wayland/-/issues/4
it looks like the client-side thing is expected behavior:

when a wl_display is destroyed, all objects, event queues etc. referencing it have already been destroyed


Can 'src' attribute be relative to gruntfile

Currently you have to look up the path for the source folder
src: 'path/to/source/folder',
It could be useful to accept paths relative to the Gruntfile. In my case, I am usually uploading the folder containing the gruntfile itself... or would possibly want to upload only a portion of that folder.

The paths are relative to the root of the project (which is the location that should contain the gruntfile) but I would advise against it because this would be also the most likely location of potential password files and even node_modules.


Set own default parameters for "Filter Variants" and "Filter SVs"

Is your feature request related to a problem? Please describe.
Our requirements for variant filter parameters differ from the shipped default parameters. Is there any way to set own default parameters via a config file?
Describe the solution you'd like
A config file that takes a default configuration for filtering parameters.
Describe alternatives you've considered
Adapt filters every time "Filter Variants" or "Filter SVs" is opened.
Additional context
none

Any comment on this? I see that CUBI instance has filters set per default which are not the shipped filters.

Which filters did you notice are different between LB and the CUBI instance?

Ok. Now I see it is restoring the lastly used query settings if "Filter Variants" is opened again.

When opening a previously untouched case it seems "default" preset is loaded which is fine. I don't know if it is really "default" because the preset name is not indicated. This explains why filters looked different. Sorry for my mistake.
Regarding the initial questiuon I would like to know how

the preset "default" can be configured
new presets can be added

Thanks in advance!

This is not possible from the UI in the current version. See #776 for an upcoming feature. We will not port this back to anthenea, though.
As a workaround for anthenea, you can create a copy of variants/query_presets.py, adjust it, and bind mount it into your Docker container.

Thanks @holtgrewe ! We will look into adapting variants/query_presets.py to our needs.
One more question:
When opening a previously untouched case it seems "default" preset is loaded which is fine (however it's not indicated). Is 'default' or 'any' loaded in that case?
Are presets saved when revisiting a case?


JavaScript noop href: Uncaught SyntaxError: Unexpected token )

Although quite trivial,  is invalid syntax. It can be fixed by adding a 0 parameter like so:
Anyway, nice library! :+1:

Oups! Merged your fix, thanks a lot!


Mismatched Variable Types in Data Structures

Describe the bug
While auditing cFE tlm packets for 64 bit alignment issues, I noticed that we have instances of mismatched variable types in data structures.  This results in data being truncated/corrupted.
Example:
In cfe_es.h::CFE_ES_AppInfo_t
There are multiple addresses (StartAddress, CodeAddress, etc) declared as uint32.  They should be declared as cpuaddr variables - similar to CFE_ES_AppStartParams_t:StartAddress and OS_module_address_t:code_address.
Another example is the priority, stackSize, and Exception Action variables.  See below for declaration trace:
CFE_ES_ParseFileEntry:
unsigned int Priority
unsigned int StackSize
unsigned int ExceptionAction
CFE_ES_AppCreate:
uint32  Priority
uint32  StackSize
uint32  ExceptionAction
CFE_ES_AppStartParams_t:
uint16  ExceptionAction
uint16  Priority
uint32  StackSize
CFE_ES_AppInfo_t:
uint16   Priority
uint16   ExceptionAction
uint32   StackSize
Reporter Info
Dan Knutsen
NASA/Goddard

Part of this was actually a design decision at the time 64 bit support was initially added.  There was a desire to not change the TLM/CMD formats at that time, so these fields remained fixed 32 bit in size and the AddressesAreValid should be set FALSE to basically just tell the ground system they are all wrong and not to pay attention to them.
That being said, there might have still been one place (in the mempool stuff?) where telemetry did change size.

The other aspect is that CFE doesn't ever actually use data structures that are bigger than 32-bit sizes so the size fields remaining as 32-bit was OK.  The emphasis was to build and run on the newer architectures, not necessarily to actually use or manipulate huge data structures with sizes > 4GB.

Thanks for the info/feedback!  I just double checked and identified the following tlm/cmd that contain 64 bit variables:
CFE_SB_HousekeepingTlm_Payload
CFE_ES_PoolStatsTlm_Payload
CFE_TBL_HouseKeepingTlm_Payload_t
CFE_TBL_TblRegPacket_Payload_t
CFE_ES_SendMemPoolStatsCmd_Payload_t
I think it might be possible that these were updated at some point following the original decision to not modify and CFE_ES_AppInfo_t was missed because it is contained in cfe_es.h - as opposed to cfe_es_msg.h.

Yeah, those are likely all pointers / memory addresses right?  That should be a separate design discussion / steering committee topic on the solution to these.  Firstly it should be clarified whether or not the addresses are even needed in the TLM stream in the first place (i.e. what does the ground system actually use that for).
Obviously, receiving a memory address in a CMD (as in CFE_ES_SendMemPoolStatsCmd) and proceeding to dereference it is very dangerous because CFE cannot validate the pointer value wasn't corrupted at some point.   I think there is a separate issue ticket about this?
For this we should consider using a more abstract "handle" instead, that the CFE can validate and get the real address of.  It can stay 32 bits which will be backward compatible with a 32-bit memory address.
Any other CMD/TLM interactions that deal with direct memory addresses should be relegated to an app (e.g. MM, which already does peeks and pokes) due to the inherent risk involved.

Add to list of issues that need design discussion.

Topics touched on - possibly mission define typedef for memory address sizes (could be 64 or 32...), discussed config vs just going to 64 bit everywhere...
GetMemPoolStats - this is an offender for taking memory addresses.

CCB 2020-0805 See comment above and minutes

Note CFE_TBL_TblRegPacket_Payload_t is unique in that it actually uses cpuaddr.  Not good.

In places where CFE is using these values to call OSAL (e.g. stack pointer and priority at least), OSAL should be identifying the right type to use.  Submitted nasa/osal#635 to add a typedef for those items.  Will then update CFE to use the typedef.

My other recommendation is to start migrating toward using cpusize (or perhaps size_t, because it is a standard C type) for internal sizes - as it will match the type resulting from use of e.g. sizeof() operator and thereby avoid any conversions.
Types in commands/telemetry will still need to be standardized by CFE to be fixed width - cannot use cpusize here.  But #964 already added a separate typedef for those.  So the remaining issue is primarily how it is stored internally and that we do many conversions across APIs.

After reviewing the code a bit more I'm leaning more toward using the standard size_t internally and using the CFE_ES_MemOffset_t for sizes cmd/tlm messages - perhaps renaming it to CFE_ES_MemOffset_Atom_t to clarify it is intended for this purpose.

Another potential compromise to move in that direction without jumping all-in would be to add another typedef in ES for this, i.e.
typedef size_t CFE_ES_Size_t;

Then update all CFE APIs to use this typedef for sizes.  Mem Pool code was already done this way in my previous commit, but this can be generalized to the rest of the API.
Upside: Gives users an easy escape if their apps don't compile nicely with 64-bit sizes - they can patch it back to uint32.
Downside: Yet another typedef.....

I vote against another typedef, I'd rather jump all-in.


[zh-cn]Modify Myapp Label

The file content/zh-cn/docs/tasks/network/validate-dual-stack.md have been syned by PR #35306, please rebase into main branch.

#35306

Run the following commands to rebase:
git checkout main
git pull -r
git checkout kinzhi171
git rebase main

Manually resolve the conflicts by the on-screen tips, where may give you one or more files. Then:
git add .
git rebase --continue
git push origin kinzhi171 -f

/lgtm
/approve


NullPointerException in 3.0.1

I've been trying to version 3.0.1 and I'm getting this error:
$ java -jar epubcheck-3.0.1.jar content/ -mode exp
Epubcheck Version 3.0.1
java.lang.NullPointerException
at com.adobe.epubcheck.util.Archive.createArchive(Archive.java:102)
at com.adobe.epubcheck.tool.Checker.run(Checker.java:207)
at com.adobe.epubcheck.tool.Checker.main(Checker.java:182)
The only match I've found online says this happens when trying to save the archive to an unwritable directory but I'm not attempting to save the archive and my CWD is writable in any case.

Try using the content/ die as the last argument, after the -mode exp

The order of the arguments doesn't appear to matter.
$ java -jar epubcheck-3.0.1.jar -mode exp content/
Epubcheck Version 3.0.1
java.lang.NullPointerException
at com.adobe.epubcheck.util.Archive.createArchive(Archive.java:102)
at com.adobe.epubcheck.tool.Checker.run(Checker.java:207)
at com.adobe.epubcheck.tool.Checker.main(Checker.java:182)

I am seeing the same problem with -mode exp. The directory is definitely writable:
Epubcheck Version 3.0.1
java.lang.NullPointerException
at com.adobe.epubcheck.util.Archive.createArchive(Archive.java:102)
at com.adobe.epubcheck.tool.Checker.run(Checker.java:207)
at com.adobe.epubcheck.tool.Checker.main(Checker.java:182)
The OS is Windows 7. The command is run from a bat file running as administrator. Java version "1.8.0_45" [Java(TM) SE Runtime Environment (build 1.8.0_45-b14), Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode)].

The command seems to run with the -mode exp -save switches without the null-pointer exception
when a target directory is explicitly supplied for the -save option and when all paths are fully qualified.  I couldn't paths relative to the current working directory (CWD) to work. I needed something like:
java -jar C:\opt\epubcheck-3.0.1\epubcheck-3.0.1.jar C:\temp\Q65321\epubpkg\ -mode exp -save C:\temp\Q65321\
This tool would be easier to use if it were better documented. Ideally, the tool would use CWD as the default for -save, much as ZIP utilities do when creating an archive of a subdirectory. But, in any case, the exception should be handled gracefully.

Thanks for pinpointing the issue, I'll look into it.

I couldn't repro with latest builds from the master (forthcoming 4.0 release). Removing the 4.0 label for now, please chime in if the issue persists after 4.0.

Closing this as outdated. Feel free to reopen the issue if necessary.


0.6.1 needs to be published to rubygems.org

Could you please publish the 0.6.1 tag to rubygems?
We can include it in our Gemfile using the git source, but that's not compatible with dependabot (as per https://github.com/dependabot/dependabot-core/issues/4002)

Yep! This would be a huge help. Currently Rubygems is only aware of 0.6.0 as the latest version.

@damir any chance this could be resolved?


[FS] Input consolidation when too many inputs at once.

https://stratisplatformuk.visualstudio.com/StratisBitcoinFullNode/_workitems/edit/3890
When we come up against a withdrawal transaction that would take >50 inputs to build, the nodes will stop building withdrawals until they all sign a consolidating transaction to reduce the number of inputs the wallet.
This needs to be able to track and report on multiple consolidating transactions.

@codingupastorm @zeptin Dont merge yet, I want to have a look at this stiil )

I think this PR should get more attention before it goes in.
After chatting with Jordan the consolidation processes is intended to be a deterministic coin selection to unify outputs which is good but I'd recommend putting some more eyes on this.

@codingupastorm could you please describe on a high level logic behind tx consolidation?
I mean when is it triggered, how multisig members come to a conclusion, is partial tx creation deterministic and so on.
I understand that this info can be acquired from the source code but it will be much easier for all the reviewers if this data was present in a plain text so we can first argue if the design is good and then check the design against the implementation.

so we can first argue if the design is good and then check the design against the implementation.

This discussion has been ongoing in slack for many weeks ???

This discussion has been ongoing in slack for many weeks ???

Yes. Just making sure I'm not missing something and everything is in 1 place
The design you've provided looks correct, thanks for writing it down.

I might e wrong but what if following happens:
All multisig nodes create partial consolidation tx. One node is malicious and it would take consolidation tx and spend all money on fees. Then it will broadcast partial txes to other nodes and following will happen:
tx goes to PartialTransactionsBehavior.OnMessageReceivedAsync then to HandleConsolidationTransactionRequest and then InputConsolidator.CombineSignatures
there we will try to get a tx that we think is the same: GetInMemoryConsolidationTransaction which only checks that our collection of consolidation txes has a tx with same first input/
Then we would coimbine the signatures and broadcast the tx.
So if I'm correct then it is possible to drain all sidechain funds in case consolidation is triggered and one fed member is malicious.
In that case additional validation steps for consolidation tx coming from a peer should be introduced.

@noescape00 the method CombineSignatures checks that the templates of the transactions match, aka that the outputs are as expected, so this is chill. Same as for the Withdrawal transactions.
Will fix the style now.

the method CombineSignatures checks that the templates of the transactions match, aka that the outputs are as expected, so this is chill
Ah, I see, it's in the  SigningUtils.TemplatesMatch- there are checks that inputs and outputs are as expected. Btw it's weird that it's checked in SigningUtils.CombineSignatures because it's not obvious that the method does the validation and not only combines the signatures. Please rename it and add comment.

Sure, I just copied the method over but I can rename it.

Good ideas @zeptin, just heard that testing is working well so I'm not going to make any changes to the code but I incorporated your changes as comments for the future!


WC2-53: list dynamic fields

Use entity type list field entries to populate columns and fields popup on beneficiaries list page only ONE entity type is selected
Self proof reading checklist

[x] Did I use eslint and black formatters
[x] Is my code clear enough and well documented
[x] Are my typescript files well typed
[ ] Did I add translations
[ ] My migrations file are included

Changes

adding type selector
remove unused fields
refactor use columns and popup component to use fields from new api
repair detail infos fields broken due to api change
allow api to receive multiple entity_type_ids
add org unit (Health Center) to the hardcoded values in the api

How to test
Go to entity types page and edit a type with entities.
Add or remove list field items.
Open beneficiaries list page.
Filter those on the types you just edited and check that the columns are correct.
Open map tab and click on a marker to open popup => check that same fields are present .
Print screen / video
https://user-images.githubusercontent.com/12494624/190381153-1a10bf1b-af1c-4f9a-b53c-4b36cd499534.mov
Notes
We have some issues with the api, ticket is here

CSV export is broken for now

Very neat. Nothing blocking, but a few suggestions and/or bugs that fall out of scope:

I think it would be nicer to have the dynamic fields shown before the static fields in the table, as they're more likely to have relevant info
I agree with @niconoe 's suggestion regarding "shared fields". If the search only returns 1 beneficiary or 1 beneficiary type, it would be nice to display the dynamic fields for its type. I think it's a nice to have that can be spun in another ticket if we decide to implement it
Another nice to have would be the possibility for the user to order the dynamic fields as they want (vs: auto sorted at the moment).
The map view gets hard to read when there are a lot (20+) beneficiaries for the same org unit. Not blocking for this PR, but worth considering

csv download is broken (out of scope):

xlsx download ignores search, ie: always download everything

like i said, the order and shared fields can come after indeed.


very minor grammar and syntax cleanup in comment to def run.

Summary
Grammar and syntax cleanup in comment to def run
Details and comments
Trivial but neat.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.391%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
54559

Relevant Lines:
64650

💛  - Coveralls


feature: make number of ripgrep threads configurable

fixes #206030.
Testing
For testing, I used the process explorer to see the ripgrep args being used, e.g. if the --threads argument is passed correctly to ripgrep.
With many threads
In settings.json, search.threads is commented out. By default, multiple threads are used. The ripgrep cli args don't include the --threads option:

With one thread
In settings.json, search.threads is set to 1. The ripgrep cli args include --threads 1:

Okay, I've been thinking through this change a bit this morning, and I was afraid that the threads was too ripgrep-specific for TextSearchOptions, which should be identical to https://github.com/microsoft/vscode/blob/64b74d9a64c54798b7fefa9070cbb8961917d0f9/src/vscode-dts/vscode.proposed.textSearchProvider.d.ts#L108-L142
Therefore, adding it to TextSearchOptions would make it part of the TextSearchProvider API. This leaves us the option to read the configuration from the extension host side instead of using QueryBuilder and TextSearchOptions to carry it from the main process. I believe that this should be possible by asking for the configurationService here:
https://github.com/microsoft/vscode/blob/bf8e6000e68ce1bec45ab43945b16a17766d5888/src/vs/workbench/api/node/extHostSearch.ts#L35-L38
Also, since this is ripgrep specific, maybe making the setting called something like search.ripgrep.numThreads would probably make it more specific to ripgrep.
Apologies for flip-flopping on this!

I made some changes, but unfortunately the code is now broken due to the configuration service missing in the extension host.

I believe that this should be possible by asking for the configurationService here

It seems currently the IConfigurationService is not available in the extensionHost services (extHost.common.services.ts extHost.node.services.ts). It seems it might be a bit much to add the configuration service and required dependency services userDataProfilesService, fileService, policyService, logService) to the extension host.
What do you think about reading the configuration in the queryBuilder  (similar to before). But adding the types not to the public TextSearchOptions interface but to another internal interface TextSearchOptionsExtended ? So that the public api remains unchanged:
// searchExtTypes.ts
export interface TextSearchOptions extends SearchOptions { /* ... */ } // no changes

// searchExtTypesExtended.ts
export interface TextSearchOptionsExtended extends TextSearchOptions {
	numThreads?: number;
}

// ripgrepTextSearchEngine
export function getRgArgs(query: TextSearchQuery, options: TextSearchOptionsExtended): string[] {
  // ...
}

Thanks. :)

Hmm. Since the extHost ripgrep text provider would still expect something of shape TextSearchOptions, I'm not too sure whether that would work (?).
https://github.com/microsoft/vscode/blob/2d6df400a7ee2c3bc458ff23b18b9df4d6500ad6/src/vs/workbench/services/search/common/textSearchManager.ts#L167
Does something like this to get a configurationService work? https://github.com/microsoft/vscode/blob/10bea6aa291aea6da506fc577f7c1ea2fb0ed930/src/vs/workbench/api/node/extHostDebugService.ts#L42

Thanks! It's working now with IExtHostConfiguration configurationService.

Okay, I'm testing it now- I realize that it says Num Threads here, which isn't the best

Could you change the outward-facing setting to maxThreads? Max Threads might look better.

Should https://github.com/microsoft/vscode/blob/cbffb5d134595d5a8c9edbca50d15f1587f67fc1/src/vs/workbench/services/search/node/rawSearchService.ts#L125 also pass through numThreads?

I noticed that the string of added args ends up being
 --threads '3'
Should the number end up being a string?

I noticed that the string of added args ends up being  --threads '3' Should the number end up being a string?

I see both work on rg, so nvm on that.


Changed testPlans to an overload

I'd personally prefer that this PR didn't go in, but I don't mind it.


Add parallel installation library

Description
Changes proposed in this pull request:

Add parallel installation library

Related issue(s)

See https://github.com/kyma-project/kyma/issues/9347

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 5 committers have signed the CLA.:x: Tomasz-Smelcerz-SAP:x: strekm:x: colunira:x: suleymanakbas91:x: kubadzYou have signed the CLA already but the status is still pending? Let us recheck it.


Testing this out; some example markdowns for reactome and maxquant

Recording this so I remember in our meeting:

I think one of the main issues with non-image-based analyses with this tool is that the input dataframes can vary widely based on the preceding tools, and the downstream analysis tools can expect very specific dataframe structures. This is a challenge for users, and it's also a challenge here. We should try to think about how the user could chat through that type of data manipulation.


Update web runner 1.1.8

Update web runner 1.1.8
Bump relate packages in package.json

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-207-954-merge-2023-08-15T09-48-41.ipa
Devices: IP 11
Validation passed.


Update "Filter" side menu

Turns 'article filter' into a slide-out window pane with a filter icon button to display options.


AdditionalProperties are missing and how to add enum properties?

I am trying to create json schema for an array of object. I need to include enum property which contains some enum values used for array creation. And need to add " 'additionalProperties':false " also in generated schema.

Gone through previous issues. This can be ignored.


Update azure-to-azure-autoupdate.md

A suggested rewording for easier understanding in the latter half of the !Note regarding changing the automation account.

@davenew : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@Sharmistha-Rai: I'm sorry - only the author of this article, @rajani-janaki-ram, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off


Add manifest for EduMIPS64 v1.2.10

Add a manifest for the new version of EduMIPS64, released today.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

Ah cool, nice to see it added by someone else! Closing the PR.


Versions not found for images on custom registry

We have some images in our project from a custom registry, which seem to work well with DockStation as long as we are logged into the registry already (docker login registry.example.com).
When accessing the settings for an image though, we get an error "Versions not found.", and the dropdown only contains the currently specified version.

Is it possible to allow selecting the version for images from a custom registry?

Hi @mikejpeters.
Yep, we don't provide custom registry and private images from docker hub.
Right now I can offer only 1 solution:
Download image manually and set the image name from "Local Images" tab.

I think we'll add that feature into a next release

No work on this yet?

Nope. We didn't add custom registry yet.


Update azure-batch-pool-resizing-failure.md

adding another scenario which is about Insufficient capacity for the requested VM size in the current region.
Pull request guidance
Thank you for submitting your contribution to our support content! Our team works closely with subject matter experts in CSS and PMs in the product group to review all content requests to ensure technical accuracy and the best customer experience. This process can sometimes take one or more days, so we greatly appreciate your patience.
We also need your help in order to process your request as soon as possible:

We won't act on your pull request (PR) until you type "#sign-off" in a new comment in your pull request (PR) to indicate that your changes are complete.

After you sign off in your PR, the article will be tech reviewed by the PM or SME if it has more than minor changes. Once the article is approved, it will undergo a final editing pass before being merged.

As discussed offline. All good for me.

@yashbhatia9800 I created the private PR https://github.com/MicrosoftDocs/SupportArticles-docs-pr/pull/5728 to publish the same changes in PR#1375. The private PR is merged, so I merged this public PR.


Set a CI

Since I do not trust your test, please do set a CI system for the project.

In minutes it will be done. I suppose you are using a MAC computer....ehehhehehe

You’re correct about my computer.
For what’s worth, last time you said “minutes” we waited for 7 months.

AppVeyor CI system has been added to the project. I hope you will enjoy it in the future. ;)


Add DynamoDB storage

Hi,
I needed storage for DynamoDB so I created one:)
https://github.com/uniplaces/osin-dynamodb
So far works for me, but let me know if you've noticed anything wrong with it.
I think I've reproduced most of the tests from osin, but you never know - maybe I've missed something.
CR welcome

:+1:


Makes the Nuke require Central Command or Nuclear Operative access to toggle Nuke Anchor

About the PR

Make the nuke require Central Command or Nuclear Operative to toggle anchor
Why / Balance

Having the crew hide the station nuke during nukies shifts is the worst thing and ultimately leads to the nukies just murderboning the entire crew in the search. This will prevent the crew from removing the nuke from the vault while still allowing the people who should be moving it (central command officials, death squad, and nukies) to be able to move it.
Technical details

Makes a check for the access level on the id, and adds that check to the anchoring code.
Media

https://github.com/space-wizards/space-station-14/assets/83733158/9711852b-a866-4949-9b26-cb940c12cf25

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: Now only IDs with Central Command or Nuclear Operative can toggle the anchor on the nuke.

If you dont want people hiding the station anchor then just make it unable to be unanchored. Hardcoding it to nukeops only is just nonsensical and heavy handed

If you dont want people hiding the station anchor then just make it unable to be unanchored. Hardcoding it to nukeops only is just nonsensical and heavy handed

some stations have a nuke too close to space by default which causes the nuke be unable to be triggered, and that'd be easily abusable
The most fair "don't let random crew members move this nuke around" option would be letting the nuke be unanchored only if the nuke disk is in it, and only giving the nuke disk back if the nuke is anchored. It lets the nukies track the nuke if the nuke is moving around

Make it unanchorable without disk or add a pinpointer, either is good.

Some stations have a nuke too close to space by default which causes the nuke to be unable to be triggered, and that'd be easily abusable. There's a dozen possibilities that would cause lockout that aren't really anyone's faults.

you could just disable the requirement for nukes locked in place. i dont think that's particularly hard to do.

This is in addition to letting nukies freely move the nuke around... because their own nuke needs to be unanchored and anchored as well

i mean the most reasonable thing (which some ss13 servers do) is just have 2 distinct nukes. One is the mobile one that can just be dragged around (the one the nukies spawn with) and the second is the fixed station nuke. They have different sprites IIRC. i think that would be the best of both worlds.

Make it unanchorable without disk or add a pinpointer, either is good.

Would every nukie have the pinpointer? Do you just want it to be one combined pinpointer that can swap between nuke disk and intended nuke or two different pinpointers?

hah, plutonium core merge conflict.
I think I like the unanchorable without nuke disk most. Having a stationary nuke sounds like fewer options for the nukies when on station.


Screengrab: can't get screenshots from device

New Regression Checklist

[X] Updated fastlane to the latest version
[X] I read the Contribution Guidelines
[X] I read docs.fastlane.tools
[X] I searched for existing GitHub issues

Regression Information

Breaking version: [e.g. 2.143.0]
Last working version: [e.g. 2.142.0]

Regression Description
I'm trying to automate my screenshot test. On the old version "2.142.0" there was an issue #16094 (which was troubling me, but not so bad). Then i tried newer "2.143.0" version. I can't get screenshots from device, it's been arguing for permissions.
I'm not sure, but something like #16090 is here, but maybe some other issue.
There're two sepparated ways to track it:

I don't have directory for my screenshots and html file (see "log_1");
I've got directory and html file (see "log_2).

Plus I can't get "--capture_output" in my command "fastlane screengrab" somehow, sorry. That's why I'm sending logs.
Complete output when running fastlane, including the stack trace and command used

Log_1

[17:41:06]: Pulling captured screenshots for locale en-US from the device
ls: /data/data/com.whisperarts.kids.breastfeeding/app_screengrab: Permission denied
[17:41:07]: Exit status: 1
ls: /data/data/com.whisperarts.kids.breastfeeding/screengrab: Permission denied
[17:41:07]: Exit status: 1
ls: /data/user/0/com.whisperarts.kids.breastfeeding/files/com.whisperarts.kids.breastfeeding/screengrab/en-US/images/screenshots: Permission denied
[17:41:07]: Exit status: 1
ls: /data/data/com.whisperarts.kids.breastfeeding/files/com.whisperarts.kids.breastfeeding/screengrab/en-US/images/screenshots: Permission denied
[17:41:07]: Exit status: 1
[17:41:07]: Generating HTML Report
[17:41:07]: Successfully created HTML file with an overview of all the screenshots: '/home/android/Desktop/androidProjects/breastfeeding-android/fastlane/screenshots/screenshots.html'
[17:41:07]: Captured 0 new screenshots! 📷✨

Log_2

[17:45:38]: Pulling captured screenshots for locale en-US from the device
ls: /data/data/com.whisperarts.kids.breastfeeding/app_screengrab: Permission denied
[17:45:38]: Exit status: 1
ls: /data/data/com.whisperarts.kids.breastfeeding/screengrab: Permission denied
[17:45:38]: Exit status: 1
ls: /data/user/0/com.whisperarts.kids.breastfeeding/files/com.whisperarts.kids.breastfeeding/screengrab/en-US/images/screenshots: Permission denied
[17:45:38]: Exit status: 1
ls: /data/data/com.whisperarts.kids.breastfeeding/files/com.whisperarts.kids.breastfeeding/screengrab/en-US/images/screenshots: Permission denied
[17:45:38]: Exit status: 1
[17:45:38]: Generating HTML Report
[17:45:38]: Error accessing file, this might be due to fastlane's directory handling
[17:45:38]: Check out https://docs.fastlane.tools/advanced/#directory-behavior for more details
Traceback (most recent call last):
14: from /usr/local/bin/fastlane:23:in <main>' 	13: from /usr/local/bin/fastlane:23:in load'
12: from /var/lib/gems/2.5.0/gems/fastlane-2.143.0/bin/fastlane:23:in <top (required)>' 	11: from /var/lib/gems/2.5.0/gems/fastlane-2.143.0/fastlane/lib/fastlane/cli_tools_distributor.rb:111:in take_off'
10: from /var/lib/gems/2.5.0/gems/fastlane-2.143.0/screengrab/lib/screengrab/commands_generator.rb:19:in start' 	 9: from /var/lib/gems/2.5.0/gems/fastlane-2.143.0/screengrab/lib/screengrab/commands_generator.rb:67:in run'
8: from /var/lib/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in run!' 	 7: from /var/lib/gems/2.5.0/gems/fastlane-2.143.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in run!'
6: from /var/lib/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in run_active_command' 	 5: from /var/lib/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in run'
4: from /var/lib/gems/2.5.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in call' 	 3: from /var/lib/gems/2.5.0/gems/fastlane-2.143.0/screengrab/lib/screengrab/commands_generator.rb:49:in block (2 levels) in run'
2: from /var/lib/gems/2.5.0/gems/fastlane-2.143.0/screengrab/lib/screengrab/runner.rb:78:in run' 	 1: from /var/lib/gems/2.5.0/gems/fastlane-2.143.0/screengrab/lib/screengrab/reports_generator.rb:29:in generate'
/var/lib/gems/2.5.0/gems/fastlane-2.143.0/screengrab/lib/screengrab/reports_generator.rb:29:in `write': No such file or directory @ rb_sysopen - fastlane/screenshots/screenshots.html (Errno::ENOENT)

Environment

[✔] 🚀
[17:46:15]: fastlane detected a Gemfile in the current directory
[17:46:15]: However, it seems like you didn't use `bundle exec`
[17:46:15]: To launch fastlane faster, please use
[17:46:15]:
[17:46:15]: $ bundle exec fastlane env
[17:46:15]:
[17:46:15]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[17:46:16]: Generating fastlane environment output, this might take a few seconds...
✅ fastlane environment ✅
Stack

Key
Value

OS
debian_based buster/sid

Ruby
2.5.5

Bundler?
false

Git
git version 2.20.1

Installation Source
/usr/local/bin/fastlane

Host
Ubuntu 19.10 debian_based buster/sid (5.3.0-40-generic)

Ruby Lib Dir
/usr/lib

OpenSSL Version
OpenSSL 1.1.1c  28 May 2019

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:android)

platform :android do
  desc "Runs all the tests"
  lane :test do
    gradle(task: "test")
  end
end

`./fastlane/Appfile`
json_key_file("") # Path to the json secret file - Follow https://docs.fastlane.tools/actions/supply/#setup to get one
package_name("") # e.g. com.krausefx.app

fastlane gems

Gem
Version
Update-Status

fastlane
2.143.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.2.1

slack-notifier
2.3.2

atomos
0.1.3

CFPropertyList
3.0.2

claide
1.0.3

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.15.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.6.1

terminal-table
1.8.0

plist
3.5.0

public_suffix
2.0.5

addressable
2.7.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.7.1

tty-cursor
0.7.1

tty-spinner
0.9.3

babosa
1.0.3

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

excon
0.72.0

faraday
0.17.3

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
0.13.1

fastimage
2.1.7

gh_inspector
1.1.3

json
2.1.0

mini_magick
4.10.1

multi_xml
0.6.0

rubyzip
1.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

dotenv
2.7.5

bundler
2.1.4

naturally
2.2.0

simctl
1.6.8

jwt
2.1.0

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

mini_mime
1.0.2

multi_json
1.14.1

signet
0.13.0

memoist
0.16.2

os
1.0.1

googleauth
0.11.0

httpclient
2.8.3

google-api-client
0.36.4

google-cloud-env
1.3.1

google-cloud-errors
1.0.0

google-cloud-core
1.5.0

digest-crc
0.5.1

google-cloud-storage
1.25.1

emoji_regex
1.0.1

jmespath
1.4.0

aws-eventstream
1.0.3

aws-sigv4
1.1.1

aws-sdk-core
2.11.460

aws-sdk-resources
2.11.460

aws-sdk
2.11.460

stringio
0.0.1

openssl
2.1.2

strscan
1.0.0

date
1.0.0

fileutils
1.0.2

etc
1.0.0

io-console
0.4.6

zlib
1.0.0

ipaddr
1.2.0

psych
3.0.2

generated on: 2020-03-05

[17:46:16]: Take notice that this output may contain sensitive information, or simply information that you don't want to make public.
[17:46:16]: Open https://github.com/fastlane/fastlane/issues/new to submit a new issue ✅

@ArtyomZuev Will look into and get back to you soon!

@ArtyomZuev have you enabled adb root flag? Permission denied hints for missing root. Check for more: https://github.com/fastlane/fastlane/pull/15635

Yeah yeah, this could be it ☝ Try setting use_adb_root: true. This does only work (I think) with AVDs that use system images that are Google APIs (and not Google Play)
This will work

This won't work

@joshdholtz, yeah, I tried this one, my device was created with "Google Play", not "API" one.
Tried to root a new emulator, it did a trick, by only with permissions. Not it's arguing for not detecting directories and files. Maybe it can't create screenshots at all.
###Log
[09:43:55]: Pulling captured screenshots for locale en-US from the device ls: /data/data/com.whisperarts.kids.breastfeeding/app_screengrab: No such file or directory
I checked my setup for fastlane and screengrab at my application and script. I didn't notice any setting that I write wrong, all by guide.

Running successfuly on previous version hints me that you don't use latest companion library. Just to confirm are you using tools.fastlane:screengrab:2.0.0? As it is the version introduced storing file at internal over external storage. Check FileWritingCallback change from https://github.com/fastlane/fastlane/commit/2f1815d0ed4c0c542f62ab721c52e639fdda696e#diff-543bbda0715a82d981c7df3152009b20 for more info.

I am having the same error. Latest working versions for me are:
fastlane: 2.141.0
screengrab: 1.2.0
emulator: sdk 28 with Play services (not store)

[14:29:56]: ▸ OK (10 tests)
[14:29:57]: Pulling captured screenshots from the device
[14:29:57]: $ //Users/henning.bunk/Library/Android/sdk/platform-tools/adb -s emulator-5554 pull /sdcard/de.wetteronline.wetterapppro/screengrab /var/folders/1z/r9tnh30d2295kv_vs7q1f47r0000gp/T/d20200306-65147-o1x82z
ls: /data/data/de.wetteronline.wetterapppro/app_screengrab: No such file or directory
[14:29:57]: Exit status: 1
ls: /data/user/0/de.wetteronline.wetterapppro/files/de.wetteronline.wetterapppro/screengrab/de_DE/images/screenshots: No such file or directory
[14:29:57]: Exit status: 1
[14:29:58]: Screenshots copied to fastlane/screenshots/de-DE/images/phoneScreenshots
[14:29:58]: Generating HTML Report
[14:29:58]: Successfully created HTML file with an overview of all the screenshots: '/Users/henning.bunk/repos/android/wetter-app/fastlane/screenshots/screenshots.html'
[14:29:58]: Captured 9 screenshots! 📷✨

Using fastlane 2.143.0 and screengrab 1.2.0 I get:

[13:46:41]: ▸ OK (10 tests)
[13:46:42]: Pulling captured screenshots for locale de_DE from the device
ls: /data/data/my.app/app_screengrab: No such file or directory
[13:46:42]: Exit status: 1
ls: /data/data/my.app/screengrab: No such file or directory
[13:46:42]: Exit status: 1
ls: /data/user/0/my.app/files/my.app/screengrab/de_DE/images/screenshots: No such file or directory
[13:46:42]: Exit status: 1
ls: /data/data/my.app/files/my.app/screengrab/de_DE/images/screenshots: No such file or directory
[13:46:42]: Exit status: 1
[13:46:42]: Generating HTML Report
[13:46:42]: Successfully created HTML file with an overview of all the screenshots: '/Users/me/repos/android/app/fastlane/screenshots/screenshots.html'
[13:46:42]: Captured 0 new screenshots! 📷✨

Using fastlane 2.141.0 and screengrab 2.0.0. I get:

[14:04:26]: ▸ OK (10 tests)
[14:04:27]: Pulling captured screenshots from the device
ls: /sdcard/de.wetteronline.wetterapppro/screengrab: No such file or directory
[14:04:27]: Exit status: 1
ls: /data/data/de.wetteronline.wetterapppro/app_screengrab: No such file or directory
[14:04:27]: Exit status: 1
ls: /data/user/0/de.wetteronline.wetterapppro/files/de.wetteronline.wetterapppro/screengrab/de_DE/images/screenshots: No such file or directory
[14:04:27]: Exit status: 1
[14:04:27]: Make sure you've used Screengrab.screenshot() in your tests and that your expected tests are being run.

Using fastlane 2.143.0 and screengrab 2.0.0. I get:

[14:10:29]: ▸ OK (10 tests)
[14:10:29]: Pulling captured screenshots for locale de_DE from the device
ls: /sdcard/my.app/screengrab: No such file or directory
[14:10:30]: Exit status: 1
ls: /data/data/my.app/app_screengrab: No such file or directory
[14:10:30]: Exit status: 1
ls: /data/data/my.app/screengrab: No such file or directory
[14:10:30]: Exit status: 1
ls: /data/user/0/my.app/files/my.app/screengrab/de_DE/images/screenshots: No such file or directory
[14:10:30]: Exit status: 1
ls: /data/data/my.app/files/my.app/screengrab/de_DE/images/screenshots: No such file or directory
[14:10:30]: Exit status: 1
[14:10:30]: Generating HTML Report
[14:10:30]: Successfully created HTML file with an overview of all the screenshots: '/Users/me/repos/android/app/fastlane/screenshots/screenshots.html'
[14:10:30]: Captured 0 new screenshots! 📷✨

Using an sdk 29 emulator (regardless the screengrab and fastlane version) I get:
java.lang.RuntimeException: Error while connecting UiAutomation
All tests were started with the adb root option.

@henningBunk can you check on device into which folder screenshots are actually written?
I have noticed in your output that fastlane tries to pull screenshots from /data/user/0/my.app/files/my.app/screengrab/de_DE/images/screenshots folder. Are you passing de_DE into fastlane screengrab --locales "de_DE"?
Both documentation https://docs.fastlane.tools/actions/screengrab/#parameters and screenshot writing code https://github.com/fastlane/fastlane/blob/master/screengrab/screengrab-lib/src/main/java/tools.fastlane.screengrab/FileWritingScreenshotCallback.java#L114 suggests to use different separator de-DE.

Hey @plastiv
thank you very much for your answer. Very good catch with a sharp eye! using de-DE as a parameter instead of de_DE helped me fix my problem. Hope that OP also gets help since I guess my problem wasnt related as I initialy thought.

Oh hmmm 🤔 So we could maybe improve this by checking to make sure its a valid language?

@plastiv, sorry for the late response. It was screengrab 1.2.0 at last. Now it's working perfect.
Still need root and proper emulator on a side, but actualy making screenshots and grabing them. :)


Google Chrome blocks the site

https://insomnia.rest/download/#mac

This should be fixed now. I was notified via Google Webmaster Tools of this last night. It's frustrating because they don't give you a reason but I suspected it was because that page triggered an automatic download to a 3rd-party site (GitHub.com). I have changed this behavior and they have lifted the ban.
Please let me know if you are still seeing this.

@gschier all good now 👍🏻Thanks!


No MonadError instance for Maybe or []

There is a MonadError instance defined for Either, but neither Maybe nor List ([]) even though the transformer versions of those types are defined.
As it stands, users who may wish to treat a failure as a Nothing or empty list must define Orphaned instances.

MonadError implies two things:
1.) The type of error is determined by the monad.
2.) You can catchError whatever it is that you throw with throwError.
Neither one of these properties holds for either Maybe or List.
You can't just make instance MonadError e Maybe because of the functional dependency.
They can't comply with the MonadError invariants unless the 'e' in MonadError is ().
I have no particular objection to adding this very restricted instance for each, but note as described above it can't be "whatever error type you want to throw", it can only be ().

On the other-other hand, these instances are inconsistent with the behavior of MaybeT and ListT.

Deciding not to proceed here because of the incompatibility with the existing MaybeT and ListT instances.

Sorry what's the incompatibility/inconsistency with MaybeT?

The instance for MaybeT lifts the MonadError instance for the underlying monad.
instance MonadError e m => MonadError e (MaybeT m)

Having Maybe and MaybeT Identity have different semantics would be very awkward.

Ah of course, thanks. Maybe it's just best to add a catchM to transformers then.


ignore me: hunting down the root case of a flakey test

Ignore this PR entirely.
Related to #1123

I cannot replicate the issue locally

I cannot even see that the assertion that's allegedly failing is even tested in the indicated location.

This PR is so that I can run and re-run CI in an attempt to nail down the issue.

Found it. The branch I was troubleshooting on was out of date and I hadn't realized.


Quality plugin crashes when quality isn't a valid quality string

Expected behaviour:
quality field should contain a Quality object when entry is used as input from entry_list.
Actual behaviour:
quality field is a string, which is sometimes literally "unknown". The task crashes if any quality comparisons are made with an invalid quality string.
Config:
Following config reproduces the issue
  test_quality:
    mock:
    - title: foo
      quality: unknown
    accept_all: yes
    quality: 720p
    disable: seen

Another config using entry_list (untested though)
  t_e:
    seen: local
    list_add:
      - entry_list: test
    mock:
      - {title: 'My Show S01E01'}
    series:
      - My Show
  t_q:
    entry_list: test
    accept_all: yes
    quality: 720p
    disable: seen

Log:
2017-11-29 20:34 CRITICAL task          task_name BUG: Unhandled error in plugin quality: `unknown` does not appear to be a valid quality string.
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/flexget/task.py", line 486, in __run_plugin
    return method(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/flexget/event.py", line 23, in __call__
    return self.func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/filter/quality.py", line 36, in on_task_filter
    if not any(req.allows(entry['quality']) for req in reqs):
  File "/usr/local/lib/python2.7/dist-packages/flexget/plugins/filter/quality.py", line 36, in <genexpr>
    if not any(req.allows(entry['quality']) for req in reqs):
  File "/usr/local/lib/python2.7/dist-packages/flexget/utils/qualities.py", line 475, in allows
    raise TypeError('`%s` does not appear to be a valid quality string.' % qual.text)
TypeError: `unknown` does not appear to be a valid quality string.

Additional information:

FlexGet version: 2.11.4
Python version: 2.7.12
Installation method: pip
Using daemon (yes/no): yes
OS and version: Ubuntu 16.04

I think these 2 lines can (should) be removed:
https://github.com/Flexget/Flexget/blob/c2cdc6b186a8474792454a0dbb2fee8d0200dd6d/flexget/utils/qualities.py#L474-L475


 Might also become important in the future for passing data.

#15


azdata notification shows on every start on dev builds

Azure Data Studio Version: main

Steps to Reproduce:

Open ADS on dev build

Expected: No notifications everytime
Actual: azdata keeps prompting for install.  There should be option "Don't show again" or some other way to disable.

BTW, why is azdata extension loading on startup?  Perhaps the activation event should be scoped to an action that requires azdata.

@kburtram Yeah - so the interesting thing here is that by itself the extension isn't really doing anything. It's basically just there for providing the API to other extensions to use. And currently there isn't an "only load when another extension that depends on this activates" event so we have to do this (from what I've seen at least).


Add filtering functions

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 0%.

@@         Coverage Diff          @@
##           master   #27   +/-   ##
====================================
  Coverage       0%    0%
====================================
  Files           4     4
  Lines         156   165    +9
====================================
- Misses        156   165    +9

Impacted Files
Coverage Δ

janitor/dataframe.py
0% <ø> (ø)
:arrow_up:

janitor/functions.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad4b09...0020bbf. Read the comment docs.


bug: Error occurred while updating device status by restapi

Description
Error occurred while updating device status by restapi
1.request the api "Update device status",  Return error message “400 bad request”
my url format: http://{serverAddress}/api/devices/{uid}/{status}    --The status value is  "accept" "reject" "pending"  or "unused"
2.request the api "Update device status to offline", Return error message "405 not allowed"
my url format: http://{serveraddress}/internal/devices/{uid}/offline
And I'm sure the api token was correct.
Steps to Reproduce
1.Install the agent and accept
2.request the restapi
Expected Behavior
i want the restapi works normally
Edition
Community
Version
v0.16.0
Related Logs
No response
Related Code
No response
Additional Information
No response

Hi, @bonnlee2024
Thank you for helping to improve ShellHub!
First, the internal paths are intended for use between the services only, so they aren't reachable outsize the container's network, what returns the error informed.
About the first request, that one to update the device status, would you mind providing additional information like the HTTP method used and the tool you are using to make the HTTP requests?

Hi, @bonnlee2024
Thank you for helping to improve ShellHub!
First, the internal paths are intended for use between the services only, so they aren't reachable outsize the container's network, what returns the error informed.
About the first request, that one to update the device status, would you mind providing additional information like the HTTP method used and the tool you are using to make the HTTP requests?

My testing tool is postman,  used HTTP request,    request method was Patch,   request url like this "http://<IP_ADDRESS>/api/devices/1234a453c8c6746bd0db7a733f8c68895936cf4078e8c4e5566b7062c98cb7c7/pending"
it dosen't work

@bonnlee2024, once your device is accepted, it may only be deleted. Only pending devices can have their status changed to rejected.


Uncaught TypeError Cannot read property '1' of undefined jssPreset

i got error when i used jssPreset().plugins but when i change to use default jss-preset-default it's work. how can i solve? thanks. i want to use preset of material-ui
Uncaught TypeError: Cannot read property '1' of undefined     at supportedKeyframes (css-vendor.esm.js:77)     at Array.onProcessRule (jss-plugin-vendor-prefixer.esm.js:17)     at PluginsRegistry.onProcessRule (PluginsRegistry.js:56)     at Array.forEach (<anonymous>)     at RuleList.process (RuleList.js:163)     at new StyleSheet (StyleSheet.js:55)     at Jss.createStyleSheet (Jss.js:123)     at attach (makeStyles.js:115)     at eval (makeStyles.js:254)     at useSynchronousEffect (makeStyles.js:206)

@javadzobeidi You have a JSS conflict between v9 and v10 running at the same time.

@oliviertassinari Your comment was spot on.
The issue is that while material-ui requires JSS v10, the current default JSS version on NPM is 9.8.7. So just npm install-ing both of them will cause this issue.
I'm guessing it's gonna happen to a lot of other folks, so just dropping in the simple fix:
npm install<EMAIL_ADDRESS>

We could think of adding a warning. I'm not sure how much people it impacts. Can the folks impacted by the problem 👍 to help us prioritize?

im impacted too...


Update openshift versions

Description
Existing docs seem to refer to outdated openshift versions

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Deploy preview for calico ready!
Built with commit aec3821ddb0b52cc2bac710d20e2265045af6fbd
https://deploy-preview-2332--calico.netlify.com

@kprabhak thanks!
Could you make the same changes in the v3.4 and master directories? Otherwise this will only apply to the v3.3 release.


Design System > Elements > Badge : Minor issues in Badge

Design System > Elements > Badge : Monor issues in Badge
Docs	1] Badges development different than design
Default	1] Different layouts are missing in development
2] colors are different than design
3] Stories are missing in development
https://www.figma.com/design/vziFLZAgMFi8wA5SlikLh5/Raaghu-Design-System?node-id=1095-14374&node-type=frame&t=84ekWaM7By5ywc4L-0

colors are different than design : This point is in pending.

Text Badge > controls > layout > Icon+ Text issue.
Badge With Icon And Text > Icon only &  Icon+text is not working.

Fixed on staging


Outdated JS guidelines in documentation

In the ReadTheDocs Code Contribution Guide, the JavaScript var section is outdated (following ES5 standard).
The guide states you should "declare JavaScript variables using var. JavaScript has function scope only, not block scope. " But with the advent of ES6, came let/const and with these, block scoping.
Maybe the documentation should be updated to include the fact that block scoping has been introduced to JS via the new variables of let and const?

We are not using ES6 in this codebase yet; there's an ongoing webpack migration required before we can do that.  So the documentation is correct :).


Image does not show when using encrypted graphs?

Seems it does not display images if graph is encrypted - is this correct? If so, anything you plan on fixing? The plug-in is great so really would like to see this work - thanks!

We expect to support this to be supported once we implement https://github.com/RoamJS/presentation/issues/6, closing as duplicate


DASH UHD HEVC playback failure on Amazon FireTV Stick UHD (AFTMM)

Version
Media3 1.1.1
More version details
No response
Devices that reproduce the issue
Amazon FireTV Stick UHD (AFTMM)
Fire OS <IP_ADDRESS> (NS6298/4758)
Devices that do not reproduce the issue
Amazon FireTV Stick UHD Max
Reproducible in the demo app?
Yes
Reproduction steps
Play DASH UHD HEVC stream with Widevine DRM.
Expected result
Stream can be played successfully.
Actual result
Playback crashes with the following error:
2023-09-14 08:13:10.172   245-276   BufferQueueProducer     pid-245                              E  [SurfaceView - androidx.media3.demo.main/androidx.media3.demo.main.PlayerActivity] dequeueBuffer: createGraphicBuffer failed
2023-09-14 08:13:10.172   748-1024  ACodec                  androidx.media3.demo.main            E  dequeueBuffer failed: Out of memory (12)
2023-09-14 08:13:10.172   748-1024  ACodec                  androidx.media3.demo.main            E  Failed to allocate output port buffers after port reconfiguration: (-12)
2023-09-14 08:13:10.172   748-1024  ACodec                  androidx.media3.demo.main            E  signalError(omxError 0x80001001, internalError -12)
2023-09-14 08:13:10.172   748-1022  MediaCodec              androidx.media3.demo.main            E  Codec reported err 0xfffffff4, actionCode 0, while in state 6
2023-09-14 08:13:10.173   748-1022  MediaCodecLogger        androidx.media3.demo.main            I  xxx.4K.secure.HW.video.hevc.DecoderErrorFatal = 1
2023-09-14 08:13:10.173   748-1022  MediaCodecLogger        androidx.media3.demo.main            I  xxx.4K.secure.HW.video.hevc.ASAP-P2Ms = 16
2023-09-14 08:13:10.173   748-1022  MediaCodecLogger        androidx.media3.demo.main            I  xxx.4K.secure.HW.video.hevc.ASAP-P3Ms = 29
2023-09-14 08:13:10.173   748-1022  MediaCodecLogger        androidx.media3.demo.main            I  xxx.4K.secure.HW.video.hevc.FirstFrameReadyMs = -234915546
2023-09-14 08:13:10.180   748-993   MediaCodecVideoRenderer androidx.media3.demo.main            E  Video codec error
                                                                                java.lang.IllegalStateException
                                                                                at android.media.MediaCodec.native_dequeueOutputBuffer(Native Method)
                                                                                at android.media.MediaCodec.dequeueOutputBuffer(MediaCodec.java:2584)
                                                                                at androidx.media3.exoplayer.mediacodec.SynchronousMediaCodecAdapter.dequeueOutputBufferIndex(SynchronousMediaCodecAdapter.java:108)
                                                                                at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.drainOutputBuffer(MediaCodecRenderer.java:1865)
                                                                                at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:816)
                                                                                at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.render(MediaCodecVideoRenderer.java:852)
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:1047)
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:522)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:98)
                                                                                at android.os.Looper.loop(Looper.java:154)
                                                                                at android.os.HandlerThread.run(HandlerThread.java:61)
2023-09-14 08:13:10.183   748-993   ExoPlayerImplInternal   androidx.media3.demo.main            E  Playback error
                                                                                androidx.media3.exoplayer.ExoPlaybackException: MediaCodecVideoRenderer error, index=0, format=Format(video_deu=2212041, null, null, video/hevc, hvc1.2.4.L93.90, 2212041, null, [1280, 720, 25.0, ColorInfo(BT709, Limited range, SDR SMPTE 170M, false)], [-1, -1]), format_supported=YES
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:601)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:98)
                                                                                at android.os.Looper.loop(Looper.java:154)
                                                                                at android.os.HandlerThread.run(HandlerThread.java:61)
                                                                                Caused by: androidx.media3.exoplayer.video.MediaCodecVideoDecoderException: Decoder failed: OMX.MTK.VIDEO.DECODER.HEVC.secure
                                                                                at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.createDecoderException(MediaCodecVideoRenderer.java:1862)
                                                                                at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:837)
                                                                                at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.render(MediaCodecVideoRenderer.java:852)
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:1047)
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:522)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:98)
                                                                                at android.os.Looper.loop(Looper.java:154)
                                                                                at android.os.HandlerThread.run(HandlerThread.java:61)
                                                                                Caused by: java.lang.IllegalStateException
                                                                                at android.media.MediaCodec.native_dequeueOutputBuffer(Native Method)
                                                                                at android.media.MediaCodec.dequeueOutputBuffer(MediaCodec.java:2584)
                                                                                at androidx.media3.exoplayer.mediacodec.SynchronousMediaCodecAdapter.dequeueOutputBufferIndex(SynchronousMediaCodecAdapter.java:108)
                                                                                at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.drainOutputBuffer(MediaCodecRenderer.java:1865)
                                                                                at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:816)
                                                                                at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.render(MediaCodecVideoRenderer.java:852)
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:1047)
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:522)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:98)
                                                                                at android.os.Looper.loop(Looper.java:154)
                                                                                at android.os.HandlerThread.run(HandlerThread.java:61)
2023-09-14 08:13:10.185   748-993   ExoPlayerImplInternal   androidx.media3.demo.main            E  Disable failed.
                                                                                java.lang.IllegalStateException
                                                                                at android.media.MediaCodec.native_flush(Native Method)
                                                                                at android.media.MediaCodec.flush(MediaCodec.java:2068)
                                                                                at androidx.media3.exoplayer.mediacodec.SynchronousMediaCodecAdapter.flush(SynchronousMediaCodecAdapter.java:168)
                                                                                at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.flushCodec(MediaCodecRenderer.java:901)
                                                                                at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.flushOrReleaseCodec(MediaCodecRenderer.java:894)
                                                                                at androidx.media3.exoplayer.mediacodec.MediaCodecRenderer.onDisabled(MediaCodecRenderer.java:733)
                                                                                at androidx.media3.exoplayer.video.MediaCodecVideoRenderer.onDisabled(MediaCodecVideoRenderer.java:634)
                                                                                at androidx.media3.exoplayer.BaseRenderer.disable(BaseRenderer.java:197)
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.disableRenderer(ExoPlayerImplInternal.java:1731)
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.resetInternal(ExoPlayerImplInternal.java:1453)
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.stopInternal(ExoPlayerImplInternal.java:1413)
                                                                                at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:634)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:98)
                                                                                at android.os.Looper.loop(Looper.java:154)
                                                                                at android.os.HandlerThread.run(HandlerThread.java:61)

Media
Will be emailed.
Bug Report

[X] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

last working ExoPlayer version is 2.18.1.
In 2.18.2 the calculation of codecMaxInputSize for HEVC has been changed, that leads to the playback crash on AFTMM: https://github.com/androidx/media/commit/d3d5ffce91452ebf1edf51a0c0c9d80ad29fe0b6

Thank you for the report. I'll take a look as soon as possible. I saw you've shared content with us (thanks again) but with a 24hr token. Can you make the token can last longer, say 1 week, or even better share a non-encrypted version of the content with us? If the issue is with the commit you spotted, then having access to the non-encrypted version of the content should be enough.

I tried the content on a device (not FireTV) with media3 1.1.0 and ExoPlayer 2.18.1. Btw, the content doesn't play (the DRM server returns 500 - the token expired?) but the player can parse the manifest and calculate the HEVC max input buffers.
On your log, the error is thrown when playing the 720p resolution for which

media3 1.1.1 calculates the max input size to around 2MB
ExoPlayer 2.18.1 calculates the max input size to around 350 KB

While I see the difference in the calculations between the library versions, the specific content can reach 4K resolution, in which the max input size calculated by ExoPlayer 2.18.1 is ~3MB.  What is the maximum resolution the FireTV can reach? If the codec max value is the problem, and if the 4K resolution is playable, then the FireTV would maybe throw on ExoPlayer 2.18.1 too?
I wonder if the problem comes from elsewhere. Unfortunately the bug report does not contain the logs from the demo app. Can you please reproduce again on the FireTV and then obtain a bug report immediately?
Also, as mentioned in the above comment, can you please share a content with a longer expiration token, or non encryption at all?

aside: @tonihei when MediaCodecVideoRenderer is calculating the codec max input size and the content is adaptive, shouldn't it be using a max input size based on the max possible resolution? While debugging, I noticed that the player sets the max input size based on the currently played resolution.

Please disregard my previous comment (I have now hidden it), I was debugging on a device with resolution up to 1080p and the player was excluding resolutions over 1080p, I need to debug on a 4K screen.

The max input size in ExoPlayer 2.18.1 is ~3MB and in media3 1.1.0 ~6MB, because minCompressionRatio changed from 4 to 2 for HEVC. It seems to be too much for FireTV AFTMM.
4K resolution is playable on FireTV AFTMM with ExoPlayer 2.18.1. However, the same stream fails on FireTV AFTMM with media3 1.1.0. I tried to change minCompressionRatio from 2 back to 4 in media 3 1.1.0, then the same stream can be played in 4K.
DRM 500 is indeed an expired token. Unfortunatelly, we don't have an unencrypted stream and can't change the token life time.  I can send you an updated license URL, if you tell me, when exactly you would like to run your tests. Btw, FireTV AFTMM runs into an exception, that I reported, before requesting a license. So you would see this exception, even if the token has expired.

The change in ExoPlayer was made after we found HEVC content with access units larger than the previous calculations. The current calculations in ExoPlayer assume a min compression of 2 in alignment with the the HEVC software decoder in the platform.
This seems to be a FireTV specific issue. However, I'm not aware of another report coming from FireTV users, so I'm hesitating to make a change in the code specifically for FireTV (at least not yet). Also, I wonder what would happen if you try to play HEVC content on the FireTV with access units are larger than the previously calculated max input size, which we know was too optimistic on the assumed min compression rate.
In the short term, you can customize the behavior on your app, the value is calculated at MediaCodecVideoRenderer.getCodecMaxValues() which is protected and you can override it. If you're not customizing the renderers at the moment, then the fastest path to customize MediaCodecVideoRenderer is to build a DefaulRenderersFactory and pass it to the player, here's an example
RenderersFactory renderersFactory = new DefaultRenderersFactory(context){
    @Override
    protected void buildVideoRenderers(Context context,
        @ExtensionRendererMode int extensionRendererMode, MediaCodecSelector mediaCodecSelector,
        boolean enableDecoderFallback, Handler eventHandler,
        VideoRendererEventListener eventListener, long allowedVideoJoiningTimeMs,
        ArrayList<Renderer> out) {
      out.add(new MediaCodecVideoRenderer(
          context,
          getCodecAdapterFactory(),
          mediaCodecSelector,
          allowedVideoJoiningTimeMs,
          enableDecoderFallback,
          eventHandler,
          eventListener,
          MAX_DROPPED_VIDEO_FRAME_COUNT_TO_NOTIFY){
        @Override
        protected CodecMaxValues getCodecMaxValues(MediaCodecInfo codecInfo, Format format,
            Format[] streamFormats) {
          CodecMaxValues codecMaxValues = super.getCodecMaxValues(codecInfo, format,
              streamFormats);
          if (codecMaxValues.inputSize > XXX) {
            codecMaxValues = new CodecMaxValues(codecMaxValues.height, codecMaxValues.width, YYY);
          }
          return codecMaxValues;
        }
      });
    }
  };
  ExoPlayer exoPlayer = new ExoPlayer.Builder(context, renderersFactory).build();
}

where XXX and YYY are the FireTV specific values for the max input size. Can you try this and let us know if that works on your app?

Customizing MediaCodecVideoRenderer helps. I did it for FireTV AFTMM and set maxInputSize to 3,110,400 (as it was calculated by ExoPlayer 2.18.1)
if ("Amazon".equals(Util.MANUFACTURER) && "AFTMM".equals(Util.MODEL) && codecMaxValues.inputSize > 3110400) {
   codecMaxValues = new CodecMaxValues(codecMaxValues.height, codecMaxValues.width, 3110400);
}

The limit for maxInputSize on AFTMM seems to be somewhere between 5,900,000 and 6,000,000, but 3,110,400 works for our content.
You mentioned, that you found HEVC content with access units larger than the previous calculations. I could try playing it on AFTMM, if you can give me the url.

Wouldn't you consider adding this exception to the getCodecMaxInputSize function? I see, that you did it in a similar way for H264:
case MimeTypes.VIDEO_H264:
        if ("BRAVIA 4K 2015".equals(Util.MODEL) // Sony Bravia 4K
            || ("Amazon".equals(Util.MANUFACTURER)
                && ("KFSOWI".equals(Util.MODEL) // Kindle Soho
                    || ("AFTS".equals(Util.MODEL) && codecInfo.secure)))) { // Fire TV Gen 2
          // Use the default value for cases where platform limitations may prevent buffers of the
          // calculated maximum input size from being allocated.
          return Format.NO_VALUE;
        }

I tried playing UHD content on a FireTV 4K TV stick (identified as AFTMM) and did not see the issue. I wonder if this error is specific to your app and/or content. I'm inclined not to change the library and add an exception for FireTV until we get more reports that this is happening on other FireTV devices (I have not seen such reports yet). Adding the exception you mention above  has some risk too. For example if we add the same logic as it is for H264, that method will not return a specific value letting MediaCodec decide on its own, and I'm not sure that this will not impact devices even more.


upgraded to xtensor 0.16.2

It seems that we need to inckude xtensor.hpp in xeval.hpp. In the mean we can probably do this here in the client code.

Ok, and probably xarray.hpp too.

Actually we cannot include xtensor.hpp or xarray.hpp in xeval.hpp because that leads to circular includes. So maybe we could do the opposite, so xt::eval is always available.

Let's not change anything in xtensor for now then. We will need to rethink completely the eval logic so I'd rather not make the current one more prevalent.

@SylvainCorlay despite the travis failure, this should work. I let you check on your side and merge it.

The linux build seems to be failing to link libraries that are part of ffmpeg.
Either the underlying travis ubuntu doesn't ship them anymore or the version number has changed.
In any case, we should install them with conda, and there is a recent conda package on conda-forge:  https://anaconda.org/conda-forge/ffmpeg

argh, newest conda release ships e.g. libavcodec.so.58, we try to link against libavcodec.so.57
so we need to rebuild the openimageio package?

indeed :(

argh, newest conda release ships e.g. libavcodec.so.58, we try to link against libavcodec.so.57
so we need to rebuild the openimageio package?

@JohanMabille @wolfv the binder seems to be failing because of the same issue.


upload image directly in editors image popup

it would be extremely helpful if one can upload a photo directly inside the editors image popup

as this is still a wanted feature, I will most likely not work on it because since Comfy 1.12.5 (https://github.com/comfy/comfortable-mexican-sofa/releases/tag/v1.12.5) it is possible to use the Redactor editor which comes with a build in file manager.
It would still be great, if someone takes the job to add this also to TinyMCE


IRIS SCRIPT is never executes

no code is loaded into the image
manually running iris.script works

which version of docker are you using ?
does it support this syntax :

Hi Robert,
Thank you for your time and expertise.
Which version of docker are you using ?
Does it support the following syntax  ?
RUN <<EOF iris start IRIS iris session IRIS < iris.script iris stop IRIS quietly EOF

oops, closed by error

Windows Docker Dessktop  4.34.2 (167172)
it doesn't accept your way
BUT
Dockerfile just for Online Demo
Explicit version for Quality check !!!
ARG IMAGE=intersystemsdc/iris-community
ARG VERSION=2024.1
ARG VERSION=latest
FROM $IMAGE:$VERSION
USER root
WORKDIR /home/irisowner/dev
RUN chown ${ISC_PACKAGE_MGRUSER}:${ISC_PACKAGE_IRISGROUP} /home/irisowner/dev
USER ${ISC_PACKAGE_MGRUSER}
COPY src src
COPY module.xml module.xml
COPY iris.script iris.script
RUN iris start IRIS && iris session IRIS < iris.script  && iris stop IRIS quietly

I'm using the same docker desktop version. But I think this may be due to container build being finicky about end-of-line characters.
In my git config, I have :
core.autocrlf=false
which basically tells git client to stop converting to/from Windows/Un*x eols ($0D vs $0D $0A)

I found the problem:

in Dockerfile I see WORKDIR /opt/irisbuild
-iris script gets executed BUT: in iris.script there is
zpm "load /irisrun/repo -v":1:1
changed it to
zpm "load /opt/irisbuild -v":1

now all modules are loaded and compiled

I changed the Dcockerfile to RUN <<EOF format and it worked.
It was just the wrong directory that prevented any traces. In combination with the :1:1  after load:
the second :1  kills the process immediately

Thank you Robert, it is  indeed building correctly now


Support rule customization via config file

Allow customization of rules via the .tailor.yml file. This includes porting over max and min length restrictions from the command-line.
Some suggested customizations include:

[ ] limiting naming checks to specific constructs

+1 generally for allowing custom rules

Updates on this?

Any updates on this?

No commits on this project for over 3 months , no response on this issue for almost a year. I think that answers it? :)

The current priority is to update the grammar to support the latest Swift release.  Once that is done we will do our best to address the enhancement requests.  In the meantime pull requests are welcome :)


How to disable comments?

If I don't use the switch, it doesn't do anything. If I put the switch, it enables them!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9cbd838-1888-5be7-348b-c8862d7caedb
Version Independent ID: 80961074-993c-c395-64d2-2b18bd048e31
Content: Set-PnPClientSidePage (sharepoint-pnp)
Content Source: sharepoint/sharepoint-ps/sharepoint-pnp/Set-PnPClientSidePage.md
GitHub Login: @techwriter40
Microsoft Alias: kirks

@XabiBeltza Thank you for this feedback
We want to make sure your PnP issue is handled appropriately.
We have a separate repo for the PnP PowerShell issues. We want your issue to get the proper attention it deserves.
Please open your issue in this repo: https://github.com/SharePoint/PnP-PowerShell
I am going to close this issue so that we can track to correct one in the PnP PowerShell repo.


[Enhancement] Multiple SlideMenu

Hello World,
It would be nice to get multiple side menus on one page.
Nice package

Current, there is no feature for this. But I think you can use binding IsVisible to show different view in a single slide menu.


Specify platforms for Swift unit tests

This is required since watchOS doesn't have XCTest available.
#no-changelog

Killed Travis build since all Core tests passed.


UserList: Translate section headers

(I just happened to notice this while doing some manual testing.)

Good catch, thanks! Also good to make that conversion from identifiers to names (like active as a property name -> "Active" in the UI) more explicit. Merging.


Can Delete

Where can I find that functionality for the @can ('delete', $category)?
Looks like all the auth users are able to delete all categories and I am trying to only allow auth users to delete there own threads

The readme covers this in basic terms: https://github.com/Riari/laravel-forum#policies-user-permissions
For more info, see http://teamteatime.net/docs/laravel-forum/3.x/policies.md


🛑 Internal Service Down

Pick a service label corresponding to the degraded service. When the service is restored simply close the issue.

https://github.com/bolyachevets/PHP-Plugin-WordPress-Custom-Form/issues/4


[Android] content:// to file://storage does not get resolve

Bug Report
Problem
When you take pdf anyother file from download you get URI with content://. So in order to resolve i use this package to get file URI path https://www.npmjs.com/package/cordova-plugin-filepath
What is expected to happen?
It should resolve and return file detail
What does actually happen?
It returns error code: 1 // not found
Information

chrome://inspect

Command or Code

const options: CameraOptions = {
          quality: 50,
          destinationType: this._camera.DestinationType.FILE_URI,
          mediaType: this._camera.MediaType.ALLMEDIA,
          sourceType: this._camera.PictureSourceType.SAVEDPHOTOALBUM,
          saveToPhotoAlbum: false,
        };

 if (file.indexOf("content://") > -1) {
          console.log("content //", file);
          window.FilePath.resolveNativePath(file, (success) => {
            console.log(success, "content");
            window.resolveLocalFileSystemURL(success, (fileEntry) => {
              console.log(fileEntry, "fileEntry");
              fileEntry.file((finalFile) => {
                console.log(finalFile, "resolve");
                resolve(finalFile);
              });
            });
          });
        }

Environment, Platform, Device

All Android version i think so btw currently i am testing on Android 10
Version information

Cordova CLI       : 10.0.0
Cordova Platforms : android 9.0.0
Checklist

[X] I searched for existing GitHub issues
[X] I updated all Cordova tooling to most recent version
[X] I included all the necessary information above

Can you try to parse out /storage/emulated/0/ so you're full url looks something like file:///Downloads/dummy.pdf.
See https://github.com/apache/cordova-plugin-file#upgrading-notes for the why.

Repo: https://github.com/indraraj26/cordova-camera-fast-click/tree/content-file-path
Branch: content-file-path
Android 7 vs Android 10

Repo to reproduce: https://github.com/indraraj26/cordova-camera-fast-click/tree/content-file-path
Branch: content-file-path
On Android 10 it returns code 1 error i.e file not found
Android 7 vs Android 10

Google don’t want people to convert content urls to file urls for privacy reasons, because content urls don’t belong to your app and they just make it harder on every release.
As workaround you can enable legacy storage, that will work for Android 10, but not for 11 and newer.
For enabling legacy storage add this to the application tag in the AndroidManifest.xml
android:requestLegacyExternalStorage="true"
or use the dev version of the plugin that enables the legacy storage for you
https://github.com/apache/cordova-plugin-file/pull/417

Hi @jcesarmobile,
Thank you for quick reply, If you check above repo you will see i am already using the android:requestLegacyExternalStorage="true"
Can you test my repo in your android 10
step to reproduce:

open google chrome and search for download dummy pdf and download that file.
then open this app and select that downloaded dummy pdf file


License

We've been using this library for some time under the previous MIT license.
I see that the code is now GPL licensed - can you confirm that if we continue using the previous version (tagged 2.1.0) that we are not bound by the GPL license? Since it is marked by the MIT license I would say not but just wanted to check.
Thanks!

Yes, you may continue to use Infinite Scroll v2 under the MIT license.

Perfect - thanks for the quick response!


[Bug]: error 10000 and error 10100

Version of the software
1.27
Operating system
Debian11
Browser / Native
FireFox
What happened?
Hello.
Find the broblem error 1000 and error 10100 pls help me

Relevant LoliCode if needed
No response

Please reupload the image, I cannot see anything

Same thing... can you upload it on imgur and link it?

https://imgur.com/a/TPd1r9C

Ho mandato tutto
Il gio 16 dic 2021, 20:53 openbullet @.***> ha scritto:

Same thing... can you upload it on imgur and link it?
—
Reply to this email directly, view it on GitHub
https://github.com/openbullet/OpenBullet2/issues/564#issuecomment-996147738,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUR6RM6PMSECZRY7N6EKBHDURI7TDANCNFSM5KA6MGAQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

There is already another issue open for this error, please watch that one until it's resolved https://github.com/openbullet/OpenBullet2/issues/483


Feature/tech 868

Ticket:
https://govstack-global.atlassian.net/browse/TECH-868
Description
This Pull Request addresses several test-related issues. Specifically, it corrects syntax errors, updates the handling of missing headers, and adds assertions for the 'Content-Type' header. Note that it does not add any new assertions for existing tests.
How Has This Been Tested?
Tests have been successfully executed locally and have also passed on CircleCI.

We can also change the Information Mediator Header to be fetched and checked


adds popup offset option

I added an extremely minimal offset option to fix the specific use case of elements up against the edge of the page. See #89 for an example use case.
You can see it in action at http://zevdg.com/driver.js/#single-element-with-popover-position.
This absolutely doesn't address several of the other positioning issues in #18, but I figured I'd share it anyway.

I was mostly scratching my own itch here so I don't really expect you to accept this PR.
That said, I did try to make it a sane incremental improvement that would play nicely with other positioning fixes that may be added later.

Thanks for the PR @zevdg. It has been added in 0.7.0 along with the other positioning options