Default address resolver impl may create non-routable PeerAddresses

Problem
In AddressResolve_DefaultImpl.cpp the code in Resolver::OnNodeIdResolved does:
         address.SetInterface(nodeData.mInterfaceId);

unconditionally.  But the interface id can be wrong for a non-link-local address: the interface the DNS-SD response comes in on may not match the interface that needs to be used to communicate with the relevant IP.  See comments in OperationalDeviceProxy::ToPeerAddress for example.
As a result, using the PeerAddress OnNodeIdResult creates can lead to inability to deliver messages to the resolved IP.
Proposed Solution
Either implement logic to only set the interface id if IsIPv6LinkLocal is true, or very clearly document the limitations of the PeerAddress that this API produces in the API documentation.
@andy31415

This is code that was added in https://github.com/project-chip/connectedhomeip/pull/15200

Why does the interface the mdns packet comes on not support the relevant IP?
this is easy enough to change, however I am very surprised by this. My understanding is that getting rid of the interface just makes it route in case it happens to be routable over other interfaces in case one goes down.

From the mdns spec s14:
   Except in the case of proxying and other similar specialized uses,
   addresses in IPv4 or IPv6 address records in Multicast DNS responses
   MUST be valid for use on the interface on which the response is being
   sent.

   Just as the same link-local IP address may validly be in use
   simultaneously on different links by different hosts, the same link-
   local host name may validly be in use simultaneously on different
   links, and this is not an error.  A multihomed host with connections
   to two different links may be able to communicate with two different
   hosts that are validly using the same name.  While this kind of name
   duplication should be rare, it means that a host that wants to fully
   support this case needs network programming APIs that allow
   applications to specify on what interface to perform a link-local
   Multicast DNS query, and to discover on what interface a Multicast
   DNS response was received.

If a device is receiving A/AAAA records on an interface, the addresses specified in those records should be routable on that interface. That interface may not be the PREFERRED route out, but it is routeable. If a network stack does not wish to make use of the interface indicator for non-link-local addresses and allow the network stack to determine the route, that seems like a reasonable optimization, but if you really cannot route an address on the interface on which the record was received, that is a different problem.

Why does the interface the mdns packet comes on not support the relevant IP?

I don't know offhand, but @sagar-apple was definitely seeing this with Thread networks.


KAFKA-13972; Ensure that replicas are stopped after cancelled reassignment

When a reassignment is cancelled, the controller must send StopReplica to all Adding replicas to ensure that the partition state is removed. Currently, this does not necessarily result in a bump to the leader epoch, which means that the StopReplica may be ignored by the Adding replica due to KIP-570. When this happens, the partition becomes stray and must be manually cleaned up.
We fix the problem here by ensuring that the leader epoch is bumped when a replica transitions to OfflineReplica even if the replica is not a leader or in the current ISR.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

There are some failures in ControllerIntegrationTest due to the additional epoch bump. The controlled shutdown logic is not doing quite what I expected, so I need to understand it a little better. It looks to me like we are sending LeaderAndIsr requests to the shutting down replicas and relying on the check here to keep the replica from restarting itself: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/ReplicaManager.scala#L1694. I had expected that we would send StopReplica instead.

@hachikuji : For controlled shutdown, if the shutting down broker is the leader, we send a leaderAndIsr to every replica. If the shutting down broker is a follower, we send leaderAndIsr to replicas that are not shutting down and send StopReplica to the shutting down broker.

Some updates here. In the latest patch, I have refactored the OnlinePartition state transition in PartitionStateMachine to allow for general LeaderAndIsr changes. This allows us to cancel or complete a reassignment in one single step. This saves the need to do additional leader epoch bumps in order to get unneeded replicas to accept the StopReplica request. Additionally, I found that the logic for cancellation was generally unsafe. It blindly assumed that unneeded replicas can be removed from the ISR even if that leaves no replicas from the original replica set. In the latest patch, I have added some validation to ensure that cancellation is safe. If it is not, we return INVALID_REPLICA_ASSIGNMENT.

I'm going to close this PR and submit a new one which is tailored a little more closely to the problem with cancellation. I think there's not much appetite at the moment for a big change affecting the old controller since it is on the way out.


Docs cherrypick to 2.5.1 branch

Overview
To keep our default docs pages up to date, this cherry-picks some recent doc improvements into the branch we publish our default docs from.

/azp run


RATIS-981: Step-down stale leader in case of split-brain

What changes were proposed in this pull request?
If a leader can not hear from majority (including itself)
during last election timeout, it should step down and
become a follower of next term.
What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/RATIS/issues/RATIS-981
How was this patch tested?
CI

The implementation is ready for review. Right now I am working on several unit test, hope I can fix them soon.


Dockstore CLI generates invalid JSON if Dockstore CLI wants you to update

Describe the bug
Due to the nature of this bug I can't be sure if it still exists in 1.10.0, but it does exist in 1.9.0 so it might be worth looking into. Basically, when using Dockstore's recommended method for generating a JSON for a WDL, the output WDL will include error output about Dockstore's version being out of date, resulting in an invalid JSON.
To Reproduce
Steps to reproduce the behavior:

Be using Dockstore 1.9.0
Run dockstore workflow convert entry2json --entry github.com/manning-lab/vcfToGds:master > Dockstore.json
End up with a Dockstore.json that looks like this

14:23:17.596 [main] ERROR io.dockstore.client.cli.ArgumentUtility - Current version : 1.9.0
14:23:17.599 [main] ERROR io.dockstore.client.cli.ArgumentUtility - Latest version : 1.10.0
14:23:17.599 [main] ERROR io.dockstore.client.cli.ArgumentUtility - You do not have the most recent stable release of Dockstore.
Please upgrade with the following command:
dockstore --upgrade
{
"vcfToGds_wf.vcf_files": "Array[File]",
"vcfToGds_wf.this_disk": "Int",
"vcfToGds_wf.this_memory": "Float"
}

Expected behavior
The error output should not be in the output file. The resulting JSON should be valid. While I get that we would want users to run the latest stable version of Dockstore, I don't think we should be breaking their pipelines to do so. If we want to keep the erroring when a different version is detected, one solution might be changing how we recommended users obtain output JSONs on Dockstore rather than changing the output itself.
Screenshots

Desktop (please complete the following information):

OS: Catalina
Version: Dockstore CLI 1.9.0 but may persist in 1.10.0

┆Issue is synchronized with this Jira Story
┆fixVersions: Open-ended research tasks
┆friendlyId: DOCK-1713
┆sprint: Backlog
┆taskType: Story

Looks like https://github.com/dockstore/dockstore/issues/3426#issuecomment-623713391

Seems to be a consequence of that, yep. I'm of two minds about the stderr/stdout debate; all I have is a nebulous feeling that the error about being outdated should be a warning instead, should be shorter (the first two lines could be combined into something like "You're using x.x.x, but the latest stable release is x.x.x"), and shouldn't break entry2json. In any case, if the error/warning could be suppressed for convert entry2json that'd sidestep that particular issue.

Related:
There was an issue in the past where an enduser was running an old version of the Dockstore CLI and did not want to upgrade. The stderr (it used to be stderr) said to upgrade the Dockstore CLI and this was causing issues for them in determining whether their dockstore launch command has passed or failed.

The behavior as described, "it was put into stdout because some users didn't want to upgrade and also didn't want to see it the stderr when they run their workflows," sounds like an anti-pattern. Any errors and warnings should go to stderr, and anything parseable should go to stdout. That way, when a user runs a command like the one in the comment just above that, it still produces valid JSON.
Warning messages should not break scripts, and this approach seems like it could unexpectedly break scripts that were producing valid JSON prior to a new release. If users don't want warning messages showing up in their stderr stream, we should not send warnings to stdout instead, we should provide some additional documentation/examples to users of how to use shell redirects to handle stdout/stderr.

Related to this issue, the ds-cli is generating invalid cwl files when trying to download from quay.io.
dockstore tool cwl --entry quay.io/collaboratory/dockstore-tool-bamstats:1.25-7
Current version : 1.12.0
You have the most recent stable release.
If you wish to upgrade to the latest unstable version, please use the following command:
   dockstore --upgrade-unstable
#!/usr/bin/env cwl-runner

class: CommandLineTool
id: "BAMStats"
label: "BAMStats tool"
cwlVersion: v1.0
doc: |
    ![build_status](https://quay.io/repository/collaboratory/dockstore-tool-bamstats/status)
    A Docker container for the BAMStats command. See the [BAMStats](http://bamstats.sourceforge.net/) website for more information.

dct:creator:
  "@id": "http://orcid.org/0000-0002-7681-6415"
  foaf:name: Brian O'Connor
  foaf:mbox<EMAIL_ADDRESS>
requirements:
  - class: DockerRequirement
    dockerPull: "quay.io/collaboratory/dockstore-tool-bamstats:1.25-6_1.0"

hints:
  - class: ResourceRequirement
    coresMin: 1
    ramMin: 4092  # "the process requires at least 4G of RAM"
    outdirMin: 512000

inputs:
  mem_gb:
    type: int
    default: 4
    doc: "The memory, in GB, for the reporting tool"
    inputBinding:
      position: 1

  bam_input:
    type: File
    doc: "The BAM file used as input, it must be sorted."
    format: "http://edamontology.org/format_2572"
    inputBinding:
      position: 2

outputs:
  bamstats_report:
    type: File
    format: "http://edamontology.org/format_3615"
    outputBinding:
      glob: bamstats_report.zip
    doc: "A zip file that contains the HTML report and various graphics."

baseCommand: ["bash", "/usr/local/bin/bamstats"]

$namespaces:
  dct: http://purl.org/dc/terms/
  foaf: http://xmlns.com/foaf/0.1/

In the tutorial the user is guided to create a file using the command
dockstore tool cwl --entry quay.io/collaboratory/dockstore-tool-bamstats:1.25-7 > Dockstore.cwl
dockstore tool convert cwl2json --cwl Dockstore.cwl > Dockstore.json
In both cases the files that are generated become malformed.

Any errors and warnings should go to stderr, and anything parseable should go to stdout.

👍🏽


UI/modeless dialog fix

Removed unneeded CSS class for modeless dialogs that was setting width & height to 0

Are you sure this is not breaking things? I guess if overlay is visible, it will cover whole viewer. That means, when you open dialog (which you can drag around) all other parts of the app (i.e. viewer) become not interactive.

Can confirm what @veekeys described if I remove core-dialog-hidden class in devtools. The overlay covers the entire background and prevents interactions.


JKBMS BLE - Not reporting the right values

Describe the bug
I have a Victron GX MP-II 48/5000/70 with two JKBMS'ses 304 Ah so around ~29 kWh.
The version of the Venus OS is 2.92 and I'm using the latest dev nighly build of the driver
One of my JKBMS'es reports false number/stats and settings.
the BMS shows the right values when connected to the phone app but the driver does not report the correct values.
The only thing that has changed but I do not think what can cause an issue is I installed 4 BLE transmitters and a ESPresence in the same shed where my batteries are.

How to reproduce
Steps to reproduce the behavior:
Rebooting the JKBMS by hand, removing the cables, disconnecting the battery, rebooting the MultiPlus by button or software or disconnecting the battery.
Expected behavior
Getting the correct values
Driver version
1.0.20230919dev
Venus OS device type
Venus_GX
Venus OS version
2.92
BMS type
JKBMS / Heltec BMS
Cell count
16
Connection type
Bluetooth
Config file
[DEFAULT]

; If you want to add custom values/settings, then check the values/settings you want to change in "config.default.ini"
; and insert them below to persist future driver updates.

; Example (remove the semicolon ";" to uncomment and activate the value/setting):
; Jkbms_Ble C8:47:8C:E5:01:1B
MAX_BATTERY_CHARGE_CURRENT = 100.0
MAX_BATTERY_DISCHARGE_CURRENT = 100.0

BLUETOOTH_BMS = Jkbms_Ble C8:47:8C:EC:C0:B5, Jkbms_Ble C8:47:8C:E5:01:1B
BLOCK_ON_DISCONNECT = False
TIME_TO_GO_ENABLE = True

BMS_TYPE = Jkbms

; CUSTOM_BATTERY_NAMES = C8:47:8C:E5:01:1B:Batterij Onder,C8:47:8C:EC:C0:B5:Batterij Boven

; Max voltage can seen as absorption voltage
MAX_CELL_VOLTAGE   = 3.555
FLOAT_CELL_VOLTAGE = 3.535

; Set steps to reduce battery current
; The current will be changed linear between those steps if LINEAR_LIMITATION_ENABLE is set to True
CELL_VOLTAGES_WHILE_CHARGING   = 3.56, 3.50, 3.45, 3.30
MAX_CHARGE_CURRENT_CV_FRACTION =    0, 0.05,  0.5,    1

CCCM_CV_ENABLE = False
DCCM_CV_ENABLE = False

CELL_VOLTAGES_WHILE_DISCHARGING   = 2.70, 2.80, 2.90, 3.10
MAX_DISCHARGE_CURRENT_CV_FRACTION =    0,  0.1,  0.5,    1

; Discharge current soc limits
DC_SOC_LIMIT1 = 5
DC_SOC_LIMIT2 = 20
DC_SOC_LIMIT3 = 30

; Discharge current limits
DC_CURRENT_LIMIT1_FRACTION = 0.1
DC_CURRENT_LIMIT2_FRACTION = 0.3
DC_CURRENT_LIMIT3_FRACTION = 0.5

; !!!!!Added after new version
AUTO_RESET_SOC = True
CCCM_SOC_ENABLE = False
DCCM_SOC_ENABLE = False
; Limitation on SOC when BMS is not working
LINEAR_LIMITATION_ENABLE = False
; !!!Temp restricting charge
CCCM_T_ENABLE = False
DCCM_T_ENABLE = False

Relevant log output
`root@nanopi:~# tail -F -n 50 /var/log/dbus-blebattery.*/current | tai64nlocal
==> /var/log/dbus-blebattery.0/current <==
2023-09-19 11:06:54.503437500
2023-09-19 11:06:56.236364500 INFO:SerialBattery:
2023-09-19 11:06:56.236919500 INFO:SerialBattery:Starting dbus-serialbattery
2023-09-19 11:06:56.238062500 INFO:SerialBattery:dbus-serialbattery v1.0.20230919dev
2023-09-19 11:06:56.642506500 INFO:SerialBattery:Init of Jkbms_Ble at C8:47:8C:EC:C0:B5
2023-09-19 11:06:56.643140500 INFO:SerialBattery:Test of Jkbms_Ble at C8:47:8C:EC:C0:B5
2023-09-19 11:07:01.157689500 INFO:SerialBattery:BAT: JKBMS 11.XW 16 cells (20230504)
2023-09-19 11:07:01.158826500 INFO:SerialBattery:Connection established to Jkbms_Ble
2023-09-19 11:07:01.159381500 INFO:SerialBattery:Battery Jkbms_Ble connected to dbus from c8478cecc0b5
2023-09-19 11:07:01.159815500 INFO:SerialBattery:========== Settings ==========
2023-09-19 11:07:01.160280500 INFO:SerialBattery:> Connection voltage: 0.0V | Current: 0.0A | SoC: 0%
2023-09-19 11:07:01.160661500 INFO:SerialBattery:> Cell count: 16 | Cells populated: 16
2023-09-19 11:07:01.161059500 INFO:SerialBattery:> LINEAR LIMITATION ENABLE: False
2023-09-19 11:07:01.161461500 INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 100.0A | MAX BATTERY DISCHARGE CURRENT: 100.0A
2023-09-19 11:07:01.161832500 INFO:SerialBattery:> CVCM:     True
2023-09-19 11:07:01.162343500 INFO:SerialBattery:> MIN CELL VOLTAGE: 2.9V | MAX CELL VOLTAGE: 3.555V
2023-09-19 11:07:01.162762500 INFO:SerialBattery:> CCCM CV:  False | DCCM CV:  False
2023-09-19 11:07:01.163143500 INFO:SerialBattery:> CCCM T:   False | DCCM T:   False
2023-09-19 11:07:01.163515500 INFO:SerialBattery:> CCCM SOC: False | DCCM SOC: False
2023-09-19 11:07:01.163895500 INFO:SerialBattery:Serial Number/Unique Identifier:<PHONE_NUMBER>
2023-09-19 11:07:01.238868500 INFO:SerialBattery:DeviceInstance = 4
2023-09-19 11:07:01.239429500 INFO:SerialBattery:com.victronenergy.battery.c8478cecc0b5
2023-09-19 11:07:01.240158500 INFO:SerialBattery:BAT: JKBMS 11.XW 16 cells (20230504)
2023-09-19 11:07:01.274547500 INFO:SerialBattery:publish config values = 1
2023-09-19 11:07:01.719312500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634
2023-09-19 11:08:01.537445500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634
2023-09-19 11:09:01.446071500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634
2023-09-19 11:10:01.343411500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634
2023-09-19 11:11:01.219060500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634
2023-09-19 11:12:01.137467500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634
2023-09-19 11:13:01.543668500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634
2023-09-19 11:14:01.416879500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634
2023-09-19 11:15:01.316038500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634
2023-09-19 11:16:01.208867500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634
2023-09-19 11:17:01.069069500 ERROR:SerialBattery:Exception occurred: ZeroDivisionError('float division by zero') of type <class 'ZeroDivisionError'> in /opt/victronenergy/dbus-serialbattery/dbushelper.py line #634

==> /var/log/dbus-blebattery.1/current <==
2023-09-19 11:02:05.601796500 INFO:SerialBattery:> CVCM:     True
2023-09-19 11:02:05.602238500 INFO:SerialBattery:> MIN CELL VOLTAGE: 2.9V | MAX CELL VOLTAGE: 3.555V
2023-09-19 11:02:05.602783500 INFO:SerialBattery:> CCCM CV:  False | DCCM CV:  False
2023-09-19 11:02:05.603570500 INFO:SerialBattery:> CCCM T:   False | DCCM T:   False
2023-09-19 11:02:05.605039500 INFO:SerialBattery:> CCCM SOC: True  | DCCM SOC: True
2023-09-19 11:02:05.605481500 INFO:SerialBattery:Serial Number/Unique Identifier:<PHONE_NUMBER>
2023-09-19 11:02:05.707573500 INFO:SerialBattery:DeviceInstance = 5
2023-09-19 11:02:05.708805500 INFO:SerialBattery:com.victronenergy.battery.c8478ce5011b
2023-09-19 11:02:05.710332500 INFO:SerialBattery:BAT: JKBMS 10.XW 16 cells (20221223)
2023-09-19 11:02:05.753851500 INFO:SerialBattery:publish config values = 1
2023-09-19 11:05:54.762186500 *** CCGX booted (0) ***
2023-09-19 11:06:49.168224500
2023-09-19 11:06:49.168230500 INFO:Bluetooth details
2023-09-19 11:06:49.311559500 Attempting to disconnect from C8:47:8C:E5:01:1B
2023-09-19 11:06:49.311570500 Successful disconnected
2023-09-19 11:06:54.380620500 Device C8:47:8C:E5:01:1B (public)
2023-09-19 11:06:54.380631500   Alias: Batterij onde
2023-09-19 11:06:54.380633500   Paired: no
2023-09-19 11:06:54.380635500   Trusted: yes
2023-09-19 11:06:54.380636500   Blocked: no
2023-09-19 11:06:54.380637500   Connected: no
2023-09-19 11:06:54.380639500   LegacyPairing: no
2023-09-19 11:06:54.380640500   UUID: Device Information        (0000180a-0000-1000-8000-00805f9b34fb)
2023-09-19 11:06:54.380643500   RSSI: -74
2023-09-19 11:06:54.381032500
2023-09-19 11:06:56.225900500 INFO:SerialBattery:
2023-09-19 11:06:56.226666500 INFO:SerialBattery:Starting dbus-serialbattery
2023-09-19 11:06:56.228123500 INFO:SerialBattery:dbus-serialbattery v1.0.20230919dev
2023-09-19 11:06:56.642561500 INFO:SerialBattery:Init of Jkbms_Ble at C8:47:8C:E5:01:1B
2023-09-19 11:06:56.643140500 INFO:SerialBattery:Test of Jkbms_Ble at C8:47:8C:E5:01:1B
2023-09-19 11:07:01.658784500 INFO:SerialBattery:BAT: JKBMS 10.XW 16 cells (20221223)
2023-09-19 11:07:01.660014500 INFO:SerialBattery:Connection established to Jkbms_Ble
2023-09-19 11:07:01.661479500 INFO:SerialBattery:Battery Jkbms_Ble connected to dbus from c8478ce5011b
2023-09-19 11:07:01.664933500 INFO:SerialBattery:========== Settings ==========
2023-09-19 11:07:01.666687500 INFO:SerialBattery:> Connection voltage: 53.19V | Current: 31.0A | SoC: 99%
2023-09-19 11:07:01.668166500 INFO:SerialBattery:> Cell count: 16 | Cells populated: 16
2023-09-19 11:07:01.669912500 INFO:SerialBattery:> LINEAR LIMITATION ENABLE: False
2023-09-19 11:07:01.673566500 INFO:SerialBattery:> MAX BATTERY CHARGE CURRENT: 100.0A | MAX BATTERY DISCHARGE CURRENT: 100.0A
2023-09-19 11:07:01.677865500 INFO:SerialBattery:> CVCM:     True
2023-09-19 11:07:01.689804500 INFO:SerialBattery:> MIN CELL VOLTAGE: 2.9V | MAX CELL VOLTAGE: 3.555V
2023-09-19 11:07:01.691208500 INFO:SerialBattery:> CCCM CV:  False | DCCM CV:  False
2023-09-19 11:07:01.693125500 INFO:SerialBattery:> CCCM T:   False | DCCM T:   False
2023-09-19 11:07:01.694772500 INFO:SerialBattery:> CCCM SOC: False | DCCM SOC: False
2023-09-19 11:07:01.696421500 INFO:SerialBattery:Serial Number/Unique Identifier:<PHONE_NUMBER>
2023-09-19 11:07:02.173584500 INFO:SerialBattery:DeviceInstance = 5
2023-09-19 11:07:02.174578500 INFO:SerialBattery:com.victronenergy.battery.c8478ce5011b
2023-09-19 11:07:02.175711500 INFO:SerialBattery:BAT: JKBMS 10.XW 16 cells (20221223)
2023-09-19 11:07:02.265307500 INFO:SerialBattery:publish config values = 1
2023-09-19 11:11:49.567075500 [CHG] Device C8:47:8C:E5:01:1B RSSI: -74
2023-09-19 11:11:49.567088500 [CHG] Device C8:47:8C:E5:01:1B RSSI: -68
`

Any other information that may be helpful
No response

Those are the values in the VRM/ Remote Console where the driver acts on. So when the values are 0 C or soc is 0 the battery is not drained or charged. In the log you can see the same values which are displayed in the log above.

Not quite sure if my BMS is corrupt but I checked my logs and it happend aroun 23:02:31 last night

When I set Grafana 1 second later this is the output:

The cycles are reporting the voltage in some what way. Everything else like amps, soc and temp go haywire.
I did not reboot or changed anything at this time since I was asleep. the victron was set on Grid 0 mode so just maintaining the basic house load.

The values in this Grafana / Influx DB are coming from the MQTT queries against the Victron. So the Victron is "feeding" the database. When I disconnect the Victron BLE towards my BMS which is at fault the app displays the correct information.
I already installed the new driver as mentioned above but this does not resolve the problem.

Can you try an older build? https://github.com/mr-manuel/venus-os_dbus-serialbattery/releases/

Please try the nightly of the dev branch from today. There are some fixes included for the correct JKBMS BLE recognition.

Confirmed that it working also! All the values are showing the right things!
Thanks for this fix!


Ability to export project's training profile to perform further analysis

Investigate what it would take to export project's training profile to csv or excel format for further analysis

PR: #2862

Feedback based on testing:

Improve export of the Expiration Column to:
Daily: every 90 days, Yearly: on September 16th and Monthly: on 1st
Remove group rows from the export and change the export button to Export All Skills
Add Up to N occurences information to the Time Window column

PR #2: #2871

:+1:


parser stops when it hits a do/end

do
	print("yay")
end

do
	print("oww")
end

If you parse this then the tree ends at "yay"

added a pull request with the fix
https://github.com/GavinHigham/lpil53/pull/7

Awesome, thanks! Please let me know if you're doing anything neat with the project 😊


Notes_about_contacting_author -> publication_contact_author_notes

The species descriptor had 4 fields for this:
Notes_about_contacting_author (previously contacted)
Contacted.again
ContentEmail
Reply
@DannyLBuss suggests creating a single string field that concatenates these for archival referencing and to avoid nasty migration work
no decisions has been made yet

I have concatenated all the notes from these columns into a single string column called publication_study_notes, this will be a new field. We don't need the other 4 fields above.
publication_study_notes - string field, needs adding to the publication model and can have a character limit of 2000 (authors responses etc. are inc. in this string

I will add this to db model and migration tonight if it isn't done by the end of the day

Does this make the AuthorContact table redundant?

@sargentfrancesca and I have discussed the above and decided to keep all the fields separate. This means in the current author_contact table, some new fields need to be added and some field names need changing.
Existing fields

id
publication_id
date_contacted (publication_date_author_contacted) - date
contacting_user_id
content_email_id (publication_correspondence_email_content) -> string not meta
author_reply (publication_correspondence_author_reply) - string

New fields

publication_date_contacted_again - date
publication_missing_data_id (FYI missing_data_metatable)
publication_corresponding_author - string
publication_corresponding_author_email - string

are publication_corresponding_author and publication_corresponding_author_email going to remain in the publication model as well? Or moved?

Moved to the AuthorContact model

Is there any benefit of having them in both (sorry database newbie here)?

@DannyLBuss no
ok cool @sargentfrancesca


implemented RxJava-based async interface to ServiceBus

RxJava async interface for ServiceBus

seems i made it to master branch, not to v0.9.1 tag as it was intended. not sure if it correct


feat: support solid-js hmr

Summary
feat: support solid-js hmr
Related Links

Checklist

[ ] I have added changeset via pnpm run change.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.

LGTM!


V2 Transaction Input Card

Summary of changes

Adding V2 Transaction Input Card
Fix the UI issue on the TextField component
Modify the placeholder for the TokenSelector

Proposed area of change
Put an x in the boxes that apply.

[ ] apps/bridge-dapp
[ ] apps/hubble-stats
[ ] apps/stats-dapp
[ ] apps/webbsite
[ ] apps/faucet
[ ] apps/tangle-website
[x] libs/webb-ui-components

Reference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g. Closes #233).

Closes https://github.com/webb-tools/webb-dapp/issues/1405

Screen Recording
If possible provide a screen recording of proposed change.
https://github.com/webb-tools/webb-dapp/assets/60747384/edf1b642-e163-4860-a392-7655b04ea8f7

Code Checklist
Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

The new component Storybook for UI review. cc @monaiuu.


Let the user perform runtime checks for CPU features

Even if the user wants to enable features at compile time or not, it's helpful as an extra sanity check to be able to check at program start that the features really are available and maybe print an error message or something if the actual CPU isn't ready to handle what you're doing.

first call __get_cpuid_max(0) and check ret.0 for the max leaf.
If a leaf has sub-leaves you need to know the max of, call __get_cpuid_max(leaf) and check ret.1 for that max.
once you know your limits, particular features can be checked for by getting the info for a leaf and checking the bits of a particular return register. Which bit you need to look for in what register in what leaf is mostly covered in the CPUID wikipedia article.

I think rust-cpuid crate can be used for this


Fix/468 HSE -> DOH in all copy

For https://github.com/project-vagabond/covid-green-app/issues/468
Since this slipped through I've replaced all mentions of HSE (including unused ones) to be sure.

@floridemai Checking each language:

[x] bn: NYS
[x] es: el Departamento de Salud del Estado de Nueva York
[x] ht: NYSDOH
[x] ko: 뉴욕주 보건부에 연락하여 == "Call the New York State Department of Health"
[x] ru: Департаментом здравоохранения штата Нью-Йорк
[x] zh: 纽约州卫生厅 == "New York State Department of Health"

@floridemai Checking each language:

[x]  bn: NYS
[x]  es: el Departamento de Salud del Estado de Nueva York
[x]  ht: NYSDOH
[x]  ko: 뉴욕주 보건부에 연락하여 == "Call the New York State Department of Health"
[x]  ru: Департаментом здравоохранения штата Нью-Йорк
[x]  zh: 纽约州卫生厅 == "New York State Department of Health"

"HSE" didn't appear in any non-English language file, and looking up and translating some of the other keys, they all contain some variant of NYS Department of Health - which makes sense since Kevin says he instructed the translators.

Couldn't ask for more. Thanks for checking it.


onDisconnect not defined

Just forgot to add:
void MQTTClient::onDisconnect(THandlerFunction fn) {     _disconnected_cb = fn; }
in file ESP8266MQTTClient.cpp

Unfortunately that's not enough. The _disconnected_cb is not called anywhere. #8 should fix that.


Remove dead links from kythe-storage.txt. [phab:D744]

Created by fromberger at 2016-02-25 21:03:52:
We no longer have several imlementations of this interface, so I removed that
line also.

shahms accepted this revision at 2016-02-25 21:10:20

fromberger closed via commit de004b92435da00d8820ce7727e783a95e399f24 at 2016-02-25 21:14:31


CheckedFromJsonException: toString() or consistent message field

The CheckedFromJsonException does not always have its message field populated, nor does it have a toString() that could provide  a helpful message in such cases.

Fixed in https://github.com/dart-lang/json_serializable/commit/64889f0e6bf4e2ee1782282d17fe84abde98996d


Two way Messaging

Could you add a way to show messages sent from slack to the server?

This is in the API, but it not implemented by the plugin.

Would you be willing to add it as a feature to the plugin?

If you haven't noticed, I haven't been working on the plugin for a long time, unfortunately. I've just been very busy lately, but I guess there is still interest in the plugin so I'll try to update it when I can.

Thank you.


Issue with Radio Button Animation

If you'll notice immediately after click, the circle doesn't fully form. Instead the bottom and right "sides" of the circle end up being straight edges; however, they do eventually flesh out to form a circle.
Using Firefox 46.0.1

@duskykmh we've checked and you're right, on Firefox the circles are not fully formed after you click. We will check and come with an update for this issue. Thank you!


Crash when launching native Android Vulkan app

I have an app that is running perfectly on Windows with no validation errors, but I've been having loads of problems getting it up and running on Android. After stumbling through a lot broken code that the worked fine on windows and crashes on android with no validation errors, I've finally managed to get it stable and running fine. My last issue is that no 3D objects are rendering (ImGui renders fine). I'm definitely doing a lot of things out of the ordinary:

Compiling with visual studio
Stuck on platform r16b (lack of visual studio support)
Compiling hlsl shaders at runtime through locally compiled shaderc (ImGui uses precompiled Spir-v)

Basically at this point I just need to debug what's going on in the frame but every time I launch with renderdoc is crashes on startup. I tried embedding the renderdoc layer into my apk and launching but it seemed to be crashing slightly differently. In both cases I'm really at a loss as to what to try next.
The callstack when I launch and debug through android studio:
art_sigsegv_fault 0x00000070b7ab4da8
art::FaultManager::HandleFault(int, siginfo*, void*) 0x00000070b7ab52b4
___lldb_unnamed_symbol20$$app_process64 0x0000005a4c806b5c
 0x000000713d9d5870
___lldb_unnamed_symbol290$$libvulkan.so 0x0000007139d13370
___lldb_unnamed_symbol294$$libvulkan.so 0x0000007139d136f4
___lldb_unnamed_symbol279$$libvulkan.so 0x0000007139d12fbc
___lldb_unnamed_symbol278$$libvulkan.so 0x0000007139d12ad8
___lldb_unnamed_symbol14$$libvulkan.so 0x0000007139d08ee0
std::__1::__call_once(unsigned long volatile&, void*, void ()(void)) 0x000000713cd62e1c
___lldb_unnamed_symbol5$$libvulkan.so 0x0000007139d07804
GR_VulkanRenderSystem::Initialize() GR_VulkanRenderSystem.cpp:447
It's crashing in vkCreateInstance, the entry above GR_VulkanRenderSystem::Initialize(). I've attached the relevant bits of the logcat for this run.
I've also attached the log file from renderdoc, that callstack seems to have crashed shortly after vkCreateInstance.
Repro steps
Launch native android app built with visual studio using platform r16b.
Environment

RenderDoc build: v1.4 built from 214d8522
Operating System: Windows 10, Android 9 (Pixel 1 and 3)
API: Vulkan

Debug - logcat.log
RenderDoc_2019.07.11_23.39.21.log

Can you provide your application for me to reproduce the problem? The repro steps of "launch any native android app" aren't very helpful because I can test with native apps here and it works fine, so there's something specific to what you're doing that's causing the problem.
I would definitely strongly recommend that you don't try to do any manual custom steps like embedding the layer in the apk. That is not how RenderDoc is supposed to work and given how terrible a platform Android is I would not be surprised if it crashed in unexpected ways.
One thing, the callstack in the RenderDoc log you attached suggests that the validation layers are active and in fact the crash is happening within the layers after a vkCreateDevice call. Can you test without the validation layers to see if that makes any difference? In the past the validation layers have had bugs/crashes when interacting with RenderDoc so it's good to simplify the repro case.

You nailed it. Not sure about other NDKs but r15c and r16b seem to have very broken validation layers. Disabling fixed most of the rendering issues and got renderdoc working again.
Thanks for the quick response and accurate feedback. I'm going to assume that since the validation layers are broken it's not working debugging the issue any further.
Thanks!

Going by the NDK archive r15c and r16b are from 2017 so I'm not surprised you had problems. When you use the layers I'd recommend using the latest available, either from the latest NDK or from building them yourself from source. But yes any debugging/investigation would need to happen on the validation layers repository, not here.


LITE-29353: Added ProductMessage compatability on product export, sync and clone cmds

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ESBAR093066LT seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


PR for #40 - Bug with UWP networking components

Change Title
Removed the UWP specific logic from the networking components that was causing an issue with constructing from a .NET Standard library within a UWP application.
Also updated the UWP only network request classes to be common across all platforms.
Associated Issues
#40 - [Bug] JSON network requests cannot be created in common layer running on UWP due to namespace difference

@tom-made apologies for the first part merge. I hadn't synced before branching.


Move scripts and logs from /opt

Since JMU Tux now lives in /usr/share/icons we can use that icon name and not have to keep it in /opt. The script also should live in /usr/share. And while we're moving stuff out, the Ansible log file can live in /var/log.
The scripts are also now templated by jinja2 to reduce the effort to change values of various paths later.

This is a lot at once, and I may just be browsing too fast, but can you take a look at the Eclipse and jGRASP tasks as well. I believe they both expect global_base_path to download and unpack.

Yeah it's a lot of reorganization. global_base_path still exists. It's now specified in common instead of user which probably makes a little more sense.

Cool. Fixed the robots stuff

Packer build fails with:
    virtualbox-iso: TASK [common : Install custom MintReport script] *******************************
    virtualbox-iso: fatal: [localhost]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: 'global_profile_path' is undefined"}

that's all I've got for now.

Alright just did a run with the latest update. Packer ran and then I did a run as a user with all roles selected and it worked for me. Let me know if that seems to not be the case.


Revert "Merge branch 'bug-fix-typo'"

This reverts commit 9e93d8768c18dfde57dc38ff896e5ac1a76c7fce, reversing changes made to 44c4384aed6cf3b732c68f89644536f1e839483b.

FInal


CloudWatch support

It would be great to add support for CloudWatch, specifically the ability to send events to CloudWatch.

I completely agree. At this time however I'm unfortunately not in a position to be taking feature requests for new services. The process for adding APIs these days is wildly streamlined from the past, so if you want to make a PR to that effect I am more than happy to review and merge it in.
In the meantime I'm trying to keep issues directed at things either with a relevant PR or that list bugs.

@benwilson512 @stocks29 I required CloudWatch too, but only the PutMetricData, so I made it on my fork... Its unpolished, but which APIs for CloudWatch would be needed?
Also, a bit new to elixir, I can submit a PR, but it might go under a lot of changes

I also only require PutMetricData. @benwilson512, is that enough to start CloudWatch integration for ExAWS? :)


Am i missing something? [Repository not updating]

Problem Description

I created a repository with a wrong .gitignore file, so at the start, it detected that I had 98% javascript, it was ok because all my node modules were in the repository, once I corrected the .gitignore file I deleted them from the repository, but it did not update. I made a copy of the repository to know if I was missing something but linguist worked perfectly in the new one. So I don't know if I am missing something or what, I tried vendoring code with the .gitattributes file, excluding all the .js files from the repository, and a lot of things I found in the solved issues but nothing worked 😞
URL of the affected repository: https://github.com/RaimundoDiaz/Atenas
Last modified on:

< 2020-12-13 >
Expected language:

I made a copy and created another repository and linguist worked perfectly:

https://github.com/RaimundoDiaz/test123/tree/master

Detected language:

Javascript 100% 😢

You'll need to push a change to one of the files that count towards the language stats in order to force a re-analysis as changing or removing the .gitattributes alone does not force a re-analysis.

You'll need to push a change to one of the files that count towards the language stats in order to force a re-analysis as changing or removing the .gitattributes alone does not force a re-analysis.

Thanks! I deleted everything and uploaded it again and it worked.


Authenticate via Visual Studio Code

Add a credential to authenticate with the identity signed in to Visual Studio Code's Azure extension. This credential should be internal because it may be exposed to users only as part of an aggregate credential. The Azure extension uses keytar to store a refresh token, so the credential will need to make native calls to get that token. I expect msal-extensions has an interface for some of these calls (e.g. for macOS Keychain). Sharing authentication with the Azure extension means redeeming the refresh token it stored; AadClient has code for that.
Azure/azure-sdk-for-net#10979 has a complete cross-platform implementation in C#.

See in #10840


Change how we model 535 fields in the Sierra transformer

See discussion in Slack for context: https://wellcome.slack.com/archives/C8X9YKM5X/p1613582869028700

[x] 535 _2 becomes a different type of note in the API, which I'll call "Location of duplicates", for consistency with "Location of originals"
[x] We pull through the "Copies" field in Calm as note "Location of duplicates". (It doesn't appear right now because we drop notes from Sierra when we merge Calm/Sierra works, but this sounds like it's one we should have.)
[ ] Make sure these new fields appear on works pages

Also https://wellcome.slack.com/archives/CBT40CMKQ/p1614098734110700

I still need to bump the internal model used by the catalogue, and possibly tweak the frontend.

All the catalogue changes are deployed, and I think the front end will pick this up automatically. It's not worth the time or money to do a reindex just for these changes, so I'm going to hold them until the next reindex.


[Bug] Out-of-date Social Lists

Social lists does not correctly update
i've tried logging in and out, and opening the friends list menu/fc menus but it just doesn't update properly, it doesn't remove players who aren't in thoes groups anymore (like if you change FCs or if you add/remove friends)

This is likely related to a similar issue reported that the local player isn't updating as expected. I've pushed an update and it's waiting on merge now.
Try updating and logging back in. If still no luck, delete your local player (in settings -> data -> characters) and log back in again to force the data to reload.


debug console is not working and stdout has wrong file descriptor

Environment data

VS Code version: 1.21.1
Extension version (available under the Extensions sidebar): 2018.3.1
OS and version: Windows Server R2
Python version (& distribution if applicable, e.g. Anaconda): Anaconda 2.7.14
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Relevant/affected Python packages and their versions: XXX

Actual behavior
I have experimented a deep learning code with two computers, and all codes worked well without any bugs.
After I restart vscode two days ago, I have some troubles about print on one computer.
When I started the code, vscode show the terminal with the commands.
(I remember that the vscode show the debug console first.)
and the running is immediately stopped.
The error occurred in print function.
the error message is
IOError: [Errno 9] Bad file descriptor
and the return of the sys.stdout.fileno() and sys.stderr.fileno() is -2.
and the change of strout to nullwriter makes the code run.
This problem occured my second computer either, after the restart of the vscode..
How can I solve this problem?
Expected  behavior
XXX
Steps to reproduce:

XXX

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
XXX

I got same error when i print something....
There is a workound method is set  "console":"none" in launch configurations

That error won't occurred
FYI

Please could you provide a sample to replicate this issue.

My sample is quite simple

Environment data
VS Code version: 1.21.1
Extension version (available under the Extensions sidebar): 2018.3.1
OS and version: Windows 10
Python version (& distribution if applicable, e.g. Anaconda): Anaconda 2.7.14
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Relevant/affected Python packages and their versions: XXX
I'm not sure what else information should i provide...

Please could you try debugging using the experimental debugger.
Please go into launch.json and change the type from python to pythonExperimental.
Do you have any of the following options selected:

[ ] All Exceptions
[ ] Uncaught Exceptions

Closing due to lack of response for more info. If the info is provided in the future we will be happy to re-open this.

I think the default strout is redirected to wrong file descriptor when console is terminal.
So the nullwriter for strout make the code run without any errors.
Now I run the program with the previous console option "none".
Since I am not familiar with vscode, I can not tell the exact cause, but in my case this happened after a recent update.

@gkyh0805 please see Don's request to try the experimental debugger.


monetdb: 11.39.13 -> 11.39.15

Some files in bin/ can't be successfully executed

perl scripts are missing the monetdb module DBD/monetdb.pm

> ./result/bin/sqlsample.pl

Start a simple Monet SQL interaction

install_driver(monetdb) failed: Can't locate DBD/monetdb.pm in @INC (you may need to install the DBD::monetdb module) (@INC contains: /nix/store/hcd1yj7dhcp8is9a5vxxplxjmqmm8j2y-perl-5.32.1-env/lib/perl5/site_perl/5.32.1/x86_64-linux-thread-multi /nix/store/hcd1yj7dhcp8is9a5vxxplxjmqmm8j2y-perl-5.32.1-env/lib/perl5/site_perl/5.32.1 /nix/store/hcd1yj7dhcp8is9a5vxxplxjmqmm8j2y-perl-5.32.1-env/lib/perl5/site_perl /nix/store/6mnbpv86l5ff2vf765hinq95k12dhj85-perl-5.32.1/lib/perl5/site_perl/5.32.1/x86_64-linux-thread-multi /nix/store/6mnbpv86l5ff2vf765hinq95k12dhj85-perl-5.32.1/lib/perl5/site_perl/5.32.1 /nix/store/6mnbpv86l5ff2vf765hinq95k12dhj85-perl-5.32.1/lib/perl5/5.32.1/x86_64-linux-thread-multi /nix/store/6mnbpv86l5ff2vf765hinq95k12dhj85-perl-5.32.1/lib/perl5/5.32.1) at (eval 6) line 3.
Perhaps the DBD::monetdb perl module hasn't been fully installed,
or perhaps the capitalisation of 'monetdb' isn't right.
Available drivers: DBM, ExampleP, File, Gofer, Mem, Proxy, Sponge.
 at ./result/bin/sqlsample.pl line 16.

Other scripts still have references to /build/

> ./result/bin/Mtest.py
Python available, but pymonetdb package not available
Perl available, but MonetDB driver or DBI module not available

Mtest.py:  ERROR:  Illegal TSTSRCBASE: directory '/build/MonetDB-11.39.15' does not exist!

Tests in MonetDB::CLI::MapiPP fail

building '/nix/store/318c3a3p8lkwvsk09v8k2x335ffscrls-perl5.32.1-Monetdb-MapiPP-0.03.drv'...
unpacking sources
unpacking source archive /nix/store/2rw4gqfl8vbx39pg9nyxnj0fz8h1qc15-MonetDB-CLI-MapiPP-0.03.tar.gz
source root is MonetDB-CLI-MapiPP-0.03
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file MonetDB-CLI-MapiPP-0.03/MapiPP.pm
patching sources
configuring
Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for MonetDB::CLI::MapiPP
Writing MYMETA.yml and MYMETA.json
no configure script, doing nothing
building
build flags: SHELL=/nix/store/jdi2v7ir1sr6vp7pc5x0nhb6lpcmg6xg-bash-4.4-p23/bin/bash
cp MapiPP.pm blib/lib/MonetDB/CLI/MapiPP.pm
Manifying 1 pod document
running tests
check flags: SHELL=/nix/store/jdi2v7ir1sr6vp7pc5x0nhb6lpcmg6xg-bash-4.4-p23/bin/bash VERBOSE=y test
PERL_DL_NONLAZY=1 "/nix/store/6mnbpv86l5ff2vf765hinq95k12dhj85-perl-5.32.1/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/00use.t .. ok
t/02cxn.t .. 1/18
#   Failed test 'connect'
#   at t/02cxn.t line 37.
Use of uninitialized value $cxn in concatenation (.) or string at t/02cxn.t line 38.

#   Failed test 'Connection object: '
#   at t/02cxn.t line 38.

#   Failed test 'query'
#   at t/02cxn.t line 41.
Use of uninitialized value $req in concatenation (.) or string at t/02cxn.t line 42.

#   Failed test 'Request object: '
#   at t/02cxn.t line 42.
Use of uninitialized value $cnt in concatenation (.) or string at t/02cxn.t line 45.

#   Failed test 'columncount: '
#   at t/02cxn.t line 45.
#          got: undef
#     expected: '2'
Use of uninitialized value $querytype in concatenation (.) or string at t/02cxn.t line 48.

#   Failed test 'querytype: '
#   at t/02cxn.t line 48.
#          got: undef
#     expected: '1'
Use of uninitialized value $v in concatenation (.) or string at t/02cxn.t line 52.

#   Failed test 'id: '
#   at t/02cxn.t line 52.
Use of uninitialized value $v in concatenation (.) or string at t/02cxn.t line 52.

#   Failed test 'rows_affected: '
#   at t/02cxn.t line 52.
Use of uninitialized value $v in concatenation (.) or string at t/02cxn.t line 57.

#   Failed test 'name( 0 ): '
#   at t/02cxn.t line 57.
Use of uninitialized value $v in concatenation (.) or string at t/02cxn.t line 57.

#   Failed test 'name( 1 ): '
#   at t/02cxn.t line 57.
Use of uninitialized value $v in concatenation (.) or string at t/02cxn.t line 57.

#   Failed test 'type( 0 ): '
#   at t/02cxn.t line 57.
Use of uninitialized value $v in concatenation (.) or string at t/02cxn.t line 57.

#   Failed test 'type( 1 ): '
#   at t/02cxn.t line 57.
Use of uninitialized value $v in concatenation (.) or string at t/02cxn.t line 57.

#   Failed test 'length( 0 ): '
#   at t/02cxn.t line 57.
Use of uninitialized value $v in concatenation (.) or string at t/02cxn.t line 57.

#   Failed test 'length( 1 ): '
#   at t/02cxn.t line 57.
Can't call method "rows_affected" on an undefined value at t/02cxn.t line 67.
# Looks like your test exited with 111 just after 15.
t/02cxn.t .. Dubious, test returned 111 (wstat 28416, 0x6f00)
Failed 17/18 subtests
t/75mil.t .. 1/18
#   Failed test 'connect'
#   at t/75mil.t line 37.
Use of uninitialized value $cxn in concatenation (.) or string at t/75mil.t line 38.

#   Failed test 'Connection object: '
#   at t/75mil.t line 38.

#   Failed test 'query'
#   at t/75mil.t line 41.
Use of uninitialized value $req in concatenation (.) or string at t/75mil.t line 42.

#   Failed test 'Request object: '
#   at t/75mil.t line 42.
Use of uninitialized value $cnt in concatenation (.) or string at t/75mil.t line 45.

#   Failed test 'columncount: '
#   at t/75mil.t line 45.
#          got: undef
#     expected: '2'
Use of uninitialized value $querytype in concatenation (.) or string at t/75mil.t line 48.

#   Failed test 'querytype: '
#   at t/75mil.t line 48.
#          got: undef
#     expected: '-1'
Use of uninitialized value $v in concatenation (.) or string at t/75mil.t line 52.

#   Failed test 'id: '
#   at t/75mil.t line 52.
Use of uninitialized value $v in concatenation (.) or string at t/75mil.t line 52.

#   Failed test 'rows_affected: '
#   at t/75mil.t line 52.
Use of uninitialized value $v in concatenation (.) or string at t/75mil.t line 57.

#   Failed test 'name( 0 ): '
#   at t/75mil.t line 57.
Use of uninitialized value $v in concatenation (.) or string at t/75mil.t line 57.

#   Failed test 'name( 1 ): '
#   at t/75mil.t line 57.
Use of uninitialized value $v in concatenation (.) or string at t/75mil.t line 57.

#   Failed test 'type( 0 ): '
#   at t/75mil.t line 57.
Use of uninitialized value $v in concatenation (.) or string at t/75mil.t line 57.

#   Failed test 'type( 1 ): '
#   at t/75mil.t line 57.
Use of uninitialized value $v in concatenation (.) or string at t/75mil.t line 57.

#   Failed test 'length( 0 ): '
#   at t/75mil.t line 57.
Use of uninitialized value $v in concatenation (.) or string at t/75mil.t line 57.

#   Failed test 'length( 1 ): '
#   at t/75mil.t line 57.
Can't call method "rows_affected" on an undefined value at t/75mil.t line 67.
# Looks like your test exited with 111 just after 15.
t/75mil.t .. Dubious, test returned 111 (wstat 28416, 0x6f00)
Failed 17/18 subtests

Test Summary Report
-------------------
t/02cxn.t (Wstat: 28416 Tests: 15 Failed: 14)
  Failed tests:  2-15
  Non-zero exit status: 111
  Parse errors: Bad plan.  You planned 18 tests but ran 15.
t/75mil.t (Wstat: 28416 Tests: 15 Failed: 14)
  Failed tests:  2-15
  Non-zero exit status: 111
  Parse errors: Bad plan.  You planned 18 tests but ran 15.
Files=3, Tests=32,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.18 cusr  0.03 csys =  0.24 CPU)
Result: FAIL
Failed 2/3 test programs. 28/32 subtests failed.
make: *** [Makefile:845: test_dynamic] Error 111
builder for '/nix/store/318c3a3p8lkwvsk09v8k2x335ffscrls-perl5.32.1-Monetdb-MapiPP-0.03.drv' failed with exit code 2

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Closed by #149823.


Bug 2145092: Display migrationPoliciesEmptyState image for slow network

📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2145092
Display the image fast when no any MigrationPolicies are defined and when there is a slow network connection.
🎥 Demo
Before:
The image is displayed a bit later, after MigrationPolicy deletion:

After:
The image is displayed fast, together with the appropriate text:

/lgtm


Multiple instances of same app on same server, using single mongodb container currently impossible

Currently a setup like this is impossible:
  "servers": [
    {
      "host": "hostname",
      "username": "uname",
      "password": "pwd",
      "env": {
        "PORT": 3000
      }
    },
    {
      "host": "hostname",
      "username": "uname",
      "password": "pwd",
      "env": {
        "PORT": 3001
      }
    }
]

It seems to collide when it sets up MongoDB saying the container is already in use.
Due to node.js single thread use, it's sometimes desirable to set up multiple instances for load balancing. An alternative is of course multiple servers, but sometimes it's just easier to have 1 to manage but with a couple of more CPUs. Also makes it more flexible if you get a single request requiring more RAM.
Is there a way to set up the same server twice for the same app, on a single MongoDB instance?

I have tried the same with an external mongodb, and It's not a mongodb thing, but the container name.
  "servers": [
    {
      "host": "foo.bar",
      "username": "baz",
      "pem": "~/.ssh/id_rsa",
      "env": {
        "PORT": 3001
      }
    },
    {
      "host": "foo.bar",
      "username": "baz",
      "pem": "~/.ssh/id_rsa",
      "env": {
        "PORT": 3002
      }
    }
  ],
  "setupMongo": false,
  "appName": "foobar",
  "app": "../foobar",
  "env": {
    "ROOT_URL": "https://foo.bar",
    "MONGO_URL": "mongodb://mongo1.foo.bar,mongo2.foo.bar,mongo3.foo.bar/foobar?replicaSet=foobar",
    "MONGO_OPLOG_URL": "mongodb://mongo1.foo.bar,mongo2.foo.bar,mongo3.foo.bar/local?replicaSet=foobar"
  },
  "deployCheckWaitTime": 60,
  "enableUploadProgressBar": true
}

Both containers are named the same, so the second one overwrites the first one.
Maybe they should be called appName.port
In my example:
foobar.3001 and foobar.3002

I'm thinking different setup files or different hostnames as a possible suggestion?

I think Diferent setup files will do it, thought it is not confortable.
`mupx deploy --settings=container1.json; mupx deploy --settings=container2.json
// container1.json
{...
"appName": "foobar1",
...}
// container2.json
{...
"appName": "foobar2",
...}
`
I think diferent hostnames won't work, because the container name is taken from appName.


Differences with earlier MS communications about object ranges

Cf. the blog by Kurt Juvyns here: https://community.dynamics.com/business/b/businesscentraldevitpro/archive/2018/10/17/which-object-ranges-can-we-use-with-microsoft-dynamics-365-business-central
The information on this page is not equivalent to the information in the blog. Which version is the truth?
I'm mainly interested in the 70M range.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 98387b95-ce70-594b-b0e1-36ef1b5a6fb6
Version Independent ID: 8a8d3822-49c4-1422-e046-0d7c9726c9b6
Content: Object Ranges - Business Central
Content Source: dev-itpro/developer/devenv-object-ranges.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Hello, thanks for your feedback. The help topic was outdated and will be fixed with the next refresh. Please use the referenced blog post as guidance. Thanks.


ENH: accept list for labels

Currently, we only accept individual labels, it would be convenient to accept a list (e.g. an affects-dev bugfix doesn't require a changelog entry but only if it is done and merged in the same release as its regression pre-cursor, so adding a no-changelog-needed label is not good in case it gets remilestoned/etc.)

(I promised to add this, thus assigning for an easier reminder, but anyone please feel free to open a PR if I haven
t done it yet)

Huh... I guess we do check for Affects-dev in the other one:
https://github.com/scientific-python/action-check-changelogfile/blob/ab37ab266b66e8a3e5a0d22c2cf80556716674da/check_changelog.py#L64
I guess I never bothered here because I thought Stuart was gonna fix the Giles bot for astropy all those years ago. 😬
Thanks for tackling this!

ahh, thus my surprise as I use Affects-dev all the time in pyvo land :)

(But I agree that hard-wiring labels is way too astropy specific, so it should all be doable with the config that the towncrier Action already supports)


Inputpicker issues on iPhone and iPad

Hello,
I have been using your jquery inputpicker, and it has really been easy to use. However, I am having some issues with script errors on iPhone and iPad displays. Is this something that you have encountered before? These are errors related to assigning values to readyonly properties.
Thanks.
Darrell Jones

Hi Darrell,
I tested it in Chrome on iPhone and it is working fine. Can you please give me more details which errors you encounter in your environment, so I could solve them for you.


Fix updateDetails reference to undefined variable

This has already been done on indev. Try to check there before making pull requests.


ERROR: Input file is missing on Ubuntu 20.04

Hi,
I developed a code snippet using sharp for adding a frame to a provided image. It works extremely well on my development machine (MacBook Air M1, 8gb Memory). But when run the same code on my development server (Azure VM, Ubuntu, 20.04). I get the error Input file is missing. Here is what I have tried so far,
I double checked the paths and even tried to provide absolute paths to files.
I read somewhere that this can happen if low on memory, So I upgraded my VM and gave it 4gb ram. Tried the code when approx 3.5gb was available. still same error.
One thing I noticed is that the error occurs when I call toBuffer or toFile on the last step of the complete chain.
I am creating SVGs to write text on the image. (Is that supported on displayless Ubuntu)?
Following is my code.
const sharp = require('sharp')
const { dirname } = require('path');
const appDir = dirname(require.main.filename);

let foodText = 'Awesome Double Patty Beef Burger';
let locationText = 'KFC, Bahria Town, Civic Center, Phase 4';
const foodIconPath = `${appDir}/icons/spoon-and-fork.png`;
const locationIconPath = `${appDir}/icons/location-red.png`;
const logoPath = `${appDir}/icons/group39.png`
const centerImagePath = `${appDir}/icons/Best-Burger-4.jpeg`

const outputFilename = 'newImage323.png'

const textMaxLength = 40

const swotifyImage = (centerImagePath, foodText, locationText, outputFilename, foodIconPath, locationIconPath, logoPath) => {
  if (locationText.length > textMaxLength) {
    locationText = locationText.substr(0, textMaxLength);
    locationText += '...';
  }

  if (foodText.length > textMaxLength) {
    foodText = foodText.substr(0, textMaxLength);
    foodText += '...';
  }

  const foodTextSVG = `
    <svg width="900" height="60">
    <text fill="#ef3b36" font-size="30" font-family="Tahoma"  x="0" y="50">${foodText}</text>
    </svg>
    `;

  const foodTextSVGBuffer = Buffer.from(foodTextSVG);

  const locationTextSVG = `
    <svg width="600" height="60">
    <text fill="#ef3b36" font-size="30" font-family="Tahoma"  x="0" y="50">${locationText}</text>
    </svg>
    `;

  const locationTextSVGBuffer = Buffer.from(locationTextSVG);

  sharp(centerImagePath)
  .resize({width: 1000})
  .extract({ left: 0, top: 200, width: 1000, height: 850 })
  .toBuffer()
  .then(centerImage => {
    sharp(foodIconPath)
    .resize({ width: 45 })
    .toBuffer()
    .then(foodIcon => {
      sharp(locationIconPath)
    .resize({ width: 45 })
    .toBuffer()
    .then(locationIcon => {
      sharp({
        create: {
          width: 1000,
          height: 1100,
          channels: 4,
          background: { r: 255, g: 255, b: 255 }
        }
      })
      .composite([
        {input: foodIcon, top: 30, left: 15},
        {input: foodTextSVGBuffer, top: 25, left: 80},
        {input: locationIcon, top: 1010, left: 15},
        {input: locationTextSVGBuffer, top: 1005, left: 80},
        {input: centerImage, gravity: 'center'},
        {input: logoPath, left: 750, top: 1000}
      ]).png().toFile(outputFilename)
      .then(data => {
        console.log('done!');
      }).catch(err => {
        throw err;
      });
    })
    .catch(err => {throw err});
    })
    .catch(err => { throw err });
  }).catch(err => {
    throw err;
  })

}

swotifyImage(centerImagePath, foodText, locationText, outputFilename, foodIconPath, locationIconPath, logoPath);

I have traced the issue down to the composite function. It seemed that I can call the toFile function just fine if its a simple resize but after I call composite. even with a simple 1 image over base, I am getting the error. and that too only on my Ubuntu VM.

Please ensure all of the input properties contain filenames that exist and have the relevant access permissions. As of the next release the error message will include the filename via https://github.com/lovell/sharp/issues/2360

Thank you for such quick response. We need more active contributors like you in the community. I figured out the issue. IT was indeed one of the files. Except it was not missing but the filename in code was all small letters where as the actual filename was camel case. The reason it worked on my machine was because Mac's file system is case insensitive where as it is case sensitive on ubuntu. (a very very noob mistake on my behalf).
Closing the issue.


Add button to copy Introspection Query to Data Provider

Introspection queries have been phased out in favor of DocumentNodes


fix: solid-js/dist/solid import fix.

Addressed Issue: https://github.com/maxnowack/signaldb/issues/788

See discussion in #788
I'm not sure why the CI is not running this PR, but I'm pretty sure that also the tests are not working with the changed import.

Closing this. See #788

I figured out how to solve this. I cherry-picked your commit into https://github.com/maxnowack/signaldb/commit/de18ea6177e029e37c8b4c9079617ec2fd44c8e2. The issue is resolved with<EMAIL_ADDRESS>🎉


[BUG] Preview Page does not render toggles

Describe the bug
Docs page does not render toggles.
To Reproduce

Visit https://palcarazm.github.io/bootstrap5-toggle/
Scroll down to examples

Screenshots

Desktop:

OS: Win
Browser: Chrome
Version: 120

Hi,
Thanks for reporting the issue. The demo page is rendered by loading async files for each section.
This is not a good practice, but is a simple solution for having a demo static page.
Sometimes the render effect is launch when some sections are still loading, causing this bug.


Update info on enabling Data Streamer

Updated info about using Data Streamer.
RE: https://github.com/Microsoft/pxt-microbit/issues/1998

You need to bump after merging.

Can't merge. Not a contributor on this repo.


[bug] Group has not been registered with django-reversion

This shows up in instances installed via ansible-openwisp2 but can be replicated in the dev env.
How to replicate:

add reversion to INSTALLED_APPS, install django-reversion if you don't have it installed in your virtualenv already, in openwisp-users is optional
go to groups, open a group, (eg: administrator), make some changes, save, repeat the process again
click on the "history" button in the upper right part of the page
different revisions will appear, click on any

Expected outcome:
Page with the revision appears.
Actual outcome:
<class 'django.contrib.auth.models.Group'> has not been registered with django-reversion

Fun fact, trying to register Group manually yields the opposite exception:
>>> from reversion import revisions
>>> revisions.register(Group)
Traceback (most recent call last):
  File "<input>", line 1, in <module>
    revisions.register(Group)
  File "/opt/openwisp2/env/lib/python3.8/site-packages/reversion/revisions.py", line 406, in register
    return register(model)
  File "/opt/openwisp2/env/lib/python3.8/site-packages/reversion/revisions.py", line 373, in register
    raise RegistrationError("{model} has already been registered with django-reversion".format(
reversion.errors.RegistrationError: <class 'openwisp_users.models.Group'> has already been registered with django-reversion

Oh I see now, Group is being interpreted in two different ways:

openwisp_users.models.Group: registered
django.contrib.auth.models.Group: not registered

This shows up in instances installed via ansible-openwisp2 but can be replicated in the dev env.
How to replicate:

add reversion to INSTALLED_APPS, install django-reversion if you don't have it installed in your virtualenv already, in openwisp-users is optional
go to groups, open a group, (eg: administrator), make some changes, save, repeat the process again
click on the "history" button in the upper right part of the page
different revisions will appear, click on any

Expected outcome:
Page with the revision appears.
Actual outcome:
<class 'django.contrib.auth.models.Group'> has not been registered with django-reversion

@nemesisdesign I was able to replicate this but when I run ./manage.py createinitialrevisions I got the expected outcome.

This shows up in instances installed via ansible-openwisp2 but can be replicated in the dev env.
How to replicate:

add reversion to INSTALLED_APPS, install django-reversion if you don't have it installed in your virtualenv already, in openwisp-users is optional
go to groups, open a group, (eg: administrator), make some changes, save, repeat the process again
click on the "history" button in the upper right part of the page
different revisions will appear, click on any

Expected outcome:
Page with the revision appears.
Actual outcome:
<class 'django.contrib.auth.models.Group'> has not been registered with django-reversion

@nemesisdesign I was able to replicate this but when I run ./manage.py createinitialrevisions I got the expected outcome.

I was able to replicate this but when I run ./manage.py createinitialrevisions I got the expected outcome.

Are you sure about this? This had no effect for me.

I was able to replicate this but when I run ./manage.py createinitialrevisions I got the expected outcome.

Are you sure about this? This had no effect for me.


✨ bookmarklet support for Gitlabs & Bitbucket repos (corrected)

The Problem/Issue/Bug:
DDEV-gitpod bookmarklet does not support non-github "git repositories"
How this PR Solves The Problem:
This PR uses a regex expression to check for the 3 main repos
Github - checks for "https://github.com"
Gitlab - checks for "https://gitlab.com"
Bitbucket - checks for "https://bitbucket."
This is an updated version of #3465 with improved Bitbucket resolution.

This PR improves on #3465 by correcting the bitbucket parsing.
The javascript code "translates" to
if(\/bitbucket\/.test(window.location.host) ) {
    paths=window.location.pathname.split("/")
    repo=[window.location.origin, paths[1], paths[2]].join("/")
}
if(/github.com|gitlab.com/.test(window.location.host)) {
    repo = window.location.href
}
if (repo) {
    window.location.href = "https://gitpod.io/#DDEV_REPO=" + encodeURIComponent(repo) + ",DDEV_ARTIFACTS=" + encodeURIComponent(repo) + "-artifacts/https://github.com/drud/ddev-gitpod-launcher/"
}

The following appear functionally equal.

git clone https://bitbucket.org/metadrop/drupal-8-search-api-solr-8/src/master/
git clone https://bitbucket.org/metadrop/drupal-8-search-api-solr-8

Informal polling suggests this is a "standard" format, atleast in-house. So the bitbucket part of the script grabs the first 2 items of the path, metadrop (username) & drupal-8-search-api-solr-8 (reponame) and uses this as the URL to send to ddev-gitpod. This also because the assumed artifact base (URL+'-artifacts').

This solution has the benefit of leaving the URL handling up to end-users. Unlike https://github.com/drud/ddev-gitpod-launcher/pull/17 which was hard-coded based on assumptions.
If a user has a different URL pattern, they are free to create their own bookmarklet using whatever logic they require.

The javascript was encoded using the following function:
function fixedEncodeURIComponent(str) {
  return encodeURIComponent(str).replace(/[!'()*]/g, function(c) {
    return ' %' + c.charCodeAt(0).toString(16) + ' ';
  });
}

I'm not sure if there is a better way to generate it.

I went ahead and rebased this, so make sure you do a git fetch and git reset --hard <remote>/tyler36/2020_01_17_fix_bitbucket_gitpod_bookmarklet or whatever.

I did a bit more search and "https://bitbucket.csiro.au/users/bat161/repos/pytorch_unet/browse" appear to be non-standard format. I don't think we will get this one working
A more common format is the following (which should work with this PR)

https://bitbucket.org/metadrop/drupal-8-search-api-solr-8/src/master/
https://bitbucket.org/websolutionshr/drupal-8-ws-starterkit/src/master/

Either way, this PR is better than the original since it adds Gitlab support (and potential bitbucket). If we get a lot of bitbucket issues / discord threads, we will have real-world URLs that will help tweak it.
Happy to see it merged.

On a road trip with my wife so will look at this more closely later, thanks so much!

https://bitbucket.org/metadrop/drupal-8-search-api-solr-8/src/master/ mostly worked for me. Out of date composer stuff, but that's not this bookmarklet's responsibility!
Thanks so much for the long, hard pull on this one. It's such a great contribution.


Fix nonce starting at 0

What ❔
This PR fixes some tests that expected the nonce on EVM to start at 1, while we start it at 0.
This PR depends on https://github.com/lambdaclass/era-contracts/pull/24

Why ❔

Checklist

[x] PR title corresponds to the body of PR.
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via cargo fmt and checked with cargo clippy.

Hm, this is weird. A lot of tests used to fail for me when I was doing this.

Hm, this is weird. A lot of tests used to fail for me when I was doing this.

With the new change I just pushed this are the differences on the tests results:
Test solidity/test/libsolidity/semanticTests/isoltestTesting/balance_other_contract.sol[#balance_check:3] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/isoltestTesting/balance_other_contract.sol[getAddress:2] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/builtinFunctions/keccak256_packed_complex_types.sol[f:1] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/functionCall/failed_create.sol[f:1] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/libraries/library_references_preserve.sol[#deployer:solidity/test/libsolidity/semanticTests/libraries/library_references_preserve.sol:L2] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/functionCall/failed_create.sol[stack:7] was failing and is now passing ✅
Test solidity/test/libsolidity/semanticTests/errors/errors_by_parameter_type.sol[e:5] was failing and is now passing ✅
Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:31] was passing and is now failing ❌
Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[removeLiquidity:41] was passing and is now failing ❌
Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:35] was passing and is now failing ❌
Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[swapExactTokensForTokens:36] was passing and is now failing ❌
Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[addLiquidity:30] was passing and is now failing ❌
Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:34] was passing and is now failing ❌
Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:39] was passing and is now failing ❌
Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:38] was passing and is now failing ❌
Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:37] was passing and is now failing ❌

Have in mind this PR depends on https://github.com/lambdaclass/era-contracts/pull/24, I forgot to mention it

Hm, this is weird. A lot of tests used to fail for me when I was doing this.

With the new change I just pushed this are the differences on the tests results:

Test solidity/test/libsolidity/semanticTests/isoltestTesting/balance_other_contract.sol[#balance_check:3] was failing and is now passing ✅

Test solidity/test/libsolidity/semanticTests/isoltestTesting/balance_other_contract.sol[getAddress:2] was failing and is now passing ✅

Test solidity/test/libsolidity/semanticTests/builtinFunctions/keccak256_packed_complex_types.sol[f:1] was failing and is now passing ✅

Test solidity/test/libsolidity/semanticTests/functionCall/failed_create.sol[f:1] was failing and is now passing ✅

Test solidity/test/libsolidity/semanticTests/libraries/library_references_preserve.sol[#deployer:solidity/test/libsolidity/semanticTests/libraries/library_references_preserve.sol:L2] was failing and is now passing ✅

Test solidity/test/libsolidity/semanticTests/functionCall/failed_create.sol[stack:7] was failing and is now passing ✅

Test solidity/test/libsolidity/semanticTests/errors/errors_by_parameter_type.sol[e:5] was failing and is now passing ✅

Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:31] was passing and is now failing ❌

Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[removeLiquidity:41] was passing and is now failing ❌

Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:35] was passing and is now failing ❌

Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[swapExactTokensForTokens:36] was passing and is now failing ❌

Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[addLiquidity:30] was passing and is now failing ❌

Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:34] was passing and is now failing ❌

Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:39] was passing and is now failing ❌

Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:38] was passing and is now failing ❌

Test tests/solidity/complex/defi/UniswapV2Router01/test.json::complex[balanceOf:37] was passing and is now failing ❌

Have in mind this PR depends on https://github.com/lambdaclass/era-contracts/pull/24, I forgot to mention it

Thank you sir 🫡
Will check out shortly.
Could you rebase this PR onto our branch with other updates? It already points to all necessary submodules.

@gianbelinche shall we merge this PR into https://github.com/matter-labs/era-compiler-tester/issues/60 ?

@gianbelinche shall we merge this PR into #60 ?

You are right, I created a PR on the lambdaclass fork, https://github.com/lambdaclass/era-compiler-tester/pull/1, we are not going to merge it yet, since it needs more reviews, have in mind this PR still depends on it https://github.com/lambdaclass/era-contracts/pull/24
I'll close this one


[QUESTION]how to using the placeholder to generation chart template

Can write a few more placeholder type of demo?THX

A demo of a chart placeholder is already available:
https://gitbrent.github.io/PptxGenJS/demo/browser/index.html#templates


Possible regression with Code Lens for running spec-style tests

There seems to have been some regression with the Code Lens for running spec-style tests. On Tapioca, Kaan says it was working previously, but now it is failing, e.g.
tapioca main % bundle exec ruby -Itest /Users/andyw8/src/github.com/Shopify/tapioca/spec/tapioca/cli/annotations_spec.rb --name "/^T
apioca::AnnotationsTest(#|::)/"
/opt/rubies/3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `require': cannot load such file -- spec_helper (LoadError)
        from /opt/rubies/3.3.4/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
        from /Users/andyw8/src/github.com/Shopify/tapioca/spec/tapioca/cli/annotations_spec.rb:4:in `<main>'

(this could relate to a change within Tapioca itself)

The problem is with the -Itest part. For that project, it should be -Ispec.

If that's the only problem, then this is a duplicate of #2308 and we can close this one.

I think https://github.com/Shopify/ruby-lsp/pull/2522 is partly the cause. If I try the ruby-lsp version prior to that (v0.17.17), and just change -Itest to -Ispec then it works, e.g.
bundle exec ruby -Ispec /Users/andyw8/src/github.com/Shopify/tapioca/spec/tapioca/cli/gem_spec.rb --name /must\ remove\ outdated\ RBIs/
Started with run options --name "/must remove outdated RBIs/" --seed 41260

This is likely related to the specs in Tapioca being within a class definition, which is a bit different from normal specs.

I'll closet his since it wasn't a regression, it had never worked previously. But it should all be working once https://github.com/Shopify/ruby-lsp/pull/2706 is released.


[MetricsAdvisor] Ignoring AAD tests

AAD tests started failing. Ignoring them until issue is fixed service-side. Tracked by https://github.com/Azure/azure-sdk-for-net/issues/23268.

/azp run net - metricsadvisor - tests


Modern Paper command doesn't support parsing asian languages or specific symbols (like '?')

I'm using the latest snapshot of cloud and cloud-minecraft.
When I try to add an argument to my command that may contain Chinese characters, the command doesn't work.

In SINGLE mode, StringParser seems to read all contents from the CommandInput. I suspect this issue is related to the platform's CommandManager.
public @NonNull ArgumentParseResult<String> parse(final @NonNull CommandContext<C> commandContext, final @NonNull CommandInput commandInput) {
    if (this.stringMode == StringParser.StringMode.SINGLE) {
        return ArgumentParseResult.success(commandInput.readString());
    } else {
        return this.stringMode == StringParser.StringMode.QUOTED ? this.parseQuoted(commandContext, commandInput) : this.parseGreedy(commandInput);
    }
}

When I switch to LegacyPaperCommandManager and register a legacy Paper brigadier, the command works correctly.
lateinit var commandManager: LegacyPaperCommandManager<CommandSender>
commandManager = LegacyPaperCommandManager.createNative(this, ExecutionCoordinator.asyncCoordinator())
commandManager.registerLegacyPaperBrigadier()

Here is how I create my command:
commandManager.commandBuilder("home")
    .required("name", StringParser.stringParser())
    .suspendingHandler {
        ...
    }

Legacy brig only appears to work as it does nothing (Paper never re-implemented the old API on 1.20.6+).
https://github.com/Mojang/brigadier/blob/master/src/main/java/com/mojang/brigadier/StringReader.java#L169-L175
Mojang is very restrictive on what is allowed in unquoted strings. You must map your argument to a Brigadier type that accepts Chinese characters, like greedy or quoted string.


2185 - re-added imputation lookups

Pre-review checklist
I have ensured that:

[ ] Code runs successfully in the development environment.
[ ] New code is tested to prove that it works. If not, justify reasoning.
[ ] New code is documented using type hinting and following the numpydoc docstring format.
[ ] New code follows the project naming standards.

Overview of changes

Post-review checklist
As I merge these changes, I have:

[ ] Updated the related Jira ticket, including approximate time spent (including review).
[ ] Moved the related Jira ticket to Done.

Please could you also turn archiving on for the imputed values table? This would be good to keep a backup of, in case we have to start the pipeline from scratch


xilem_web: Update dependencies, and support style for MathMlElements

As noted in https://github.com/linebender/xilem/pull/621#issuecomment-2405688142, https://github.com/rustwasm/wasm-bindgen/pull/4143 is now added in wasm_bindgen 0.2.96.
This PR updates all the dependencies of xilem_web and finally correctly supports style  for MathMlElement.

Thanks, in the meantime another (minor) update of wasm-bindgen happened, I've incorporated that, and made sure that all the examples use the same version as well.


hello world build fail on windows power shell

hello world build fail on windows power shell

Have installed cmake ninja and armgcc, still build fail, do not know how to do.

Hi the environment variable ZEPHYR_BASE is not set.
https://stackoverflow.com/questions/47081317/zephyr-cmake-error


Exporting Database error

On trying to update my DB after some changes I've been getting an error which I can't seem to fix. I've tried removing recently updated mods, from steam and nexus, without any success.
Sorry for the trouble, and thanks for your time
X4_ComplexCalculator_CrashReport.txt
.
I'm sure I just don't know how to read the crash report, if there was a way to easily identify the offending mod I could avoid bothering you with these. It appears that it has something to do with an XML entry regarding wares (energy cells) but I can't begin to imagine how many times that line might appear in the many many mods I have installed.

After some trial and error I found the offending mod.
It's the Terran Cruisers mod by SimonPlaysGames, and a simple typo in the wares.xml on line 100.
Once I removed the offending comma from the value field everything was fine.
I don't know if I should leave this open for anyone else who might have this issue until the mod is updated. If you'd like it closed, please do so, or tell me to if I must personally.
Thanks again for your time.


Fix 502 Bad Gateway in deno deployment.

error: Uncaught (in promise) Error: failed to lookup address information: Name or service not known


Migrate srml-assets, srml-aura, srml-balances and srml-consens to the 2018 edition

Part of the #1415 issue.

error: the lock file /builds/parity/substrate/Cargo.lock needs to be updated but --locked was passed to prevent this

Should I update the Cargo.lock file?

@DarkEld3r didn't you build substrate locally? That should update Cargo.lock.

@DarkEld3r yes these changes should be committed, so please update your pr a last time :) All Cargo.lock and wasm files that are part of the git repo, should be committed.

@bkchr Done.

Ready for review. :upside_down_face:


Fix checking for required timed invoke for commands.

We weren't checking it for commands implemented via CommandHandlerInterface.
Fixes https://github.com/project-chip/connectedhomeip/issues/12437
Problem
Not doing "is this ok to do untimed?" checks for commands that are not dispatched via codegen.
Change overview
Move the checks into CommandHandler.
Testing
Verified that existing tests for timed invoke pass.

/rebase


#902 Autoreloader make crashing

Short description of what this resolves:
Updated ws version which fixes usage more then one ws connection and livereload
Changes proposed in this pull request:

Update npm packge ws version to 1.1.4

Fixes: #902

This needs to be merged! Please can someone do this! It's not possible to refresh the page without this crash described in #902.


Lint tests

#1256 had a focused test that would have gotten merged into master if I didn't happen to spot it, which would have disabled all other tests in that file.
This PR adds linting rules for the tests. I based the rules around the jest/recommended configuration, but with a few changes to fit how we use tests. Mostly I didn't include a few rules that prevent conditional tests, which we use a fair bit to conditionally enable tests depending on Kafka versions or authentication methods.

My bad 🤦


Soft Keybind Conflict & Bed Exclusion

Makes the tab keybind not consume the tab click event so the multiplayer player list still functions without having to rebind it.
Also I removed beds from the block entity list

Thank you!
I was planning on making a tab provider for beds (so that a single tab would only show up when it is a valid time to sleep), but decided against it as InventoryTabs should only be for inventories. Completely forgot to exclude the entry haha


Support for custom path of the config file

It would be nice if this linter could  get path for the custom config file from command line argument.
For example:
htmlcs --config=/path/to/.htmlcsrc

P. S. Thank you for great tool!

Thanks for your suggestion, I'll take it into consideration in future development.
The CLI tool is far from good enough, as it's not the key part of htmlcs now (I'm working on some exciting features/rules). if the current CLI tool can not meet your need, I'll recommend to require htmlcs and call its methods in your own code, which is more flexible.
Also, your pr will be very welcomed!

Thank's for your reply!
I'm using this tool from python script. So direct calling of NodeJS code is not very cosily in this situation.

https://github.com/ecomfe/htmlcs/pull/47

@selevit https://github.com/ecomfe/htmlcs#usage


Tail end of server logs appearing above the rest of the logs

Logs: buildkite.log
At line 1974 in the log file you can see that I seem to be experiencing logs being cut off when I have quite a lot of them.
Interestingly it actually looks like a chunk of logs are being spurted out, before Complement actually prints them on line 2518.
And if you look at the end of the actual logs... that lines up with the beginning of the spurted out logs.
So somehow the tail end of the server logs are being printed out above the rest of them...
I initially wondered if this was a bug with piping the logs to less and viewing them there. But the same happens even without less involved.

Do you experience this when running complement locally?

Sorry, some useful information may be that this was buildkite running locally on my laptop.
But indeed, I do not seem to experience the issue when running the same commands (and without CI=true) on the same machine.

Closing this on the basis that no one else seems to have noticed this, and you don't experience this when running locally. This could have been a buildkite thing.


Error executing:  openaps report invoke raw-cgm/glucose-raw.json

pi@raspberrypi:~/ben $ openaps use pump model
"522"pi@raspberrypi:~/ben $ openaps device add cgm dexcom
added dexcom://cgm
pi@raspberrypi:~/ben $ openaps use cgm config --G5
{
"model": "G5"
}pi@raspberrypi:~/ben $ openaps use cgm oref0_glucose  --no-raw --hours 2.0
[]pi@raspberrypi:~/ben $ openaps report add raw-cgm/glucose-raw.json JSON cgm oref0_glucose  --no-raw-hours 2.0
added cgm://JSON/oref0_glucose/raw-cgm/glucose-raw.json
pi@raspberrypi:~/ben $ openaps report invoke raw-cgm/glucose-raw.json
cgm://JSON/oref0_glucose/raw-cgm/glucose-raw.json
raw-cgm/glucose-raw.json  raised  Python int too large to convert to C long
Traceback (most recent call last):
File "/usr/local/bin/openaps-report", line 4, in
import('pkg_resources').run_script('openaps==0.1.6.dev0', 'openaps-report')
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 719, in run_script
self.require(requires)[0].run_script(script_name, ns)
File "/usr/local/lib/python2.7/dist-packages/pkg_resources/init.py", line 1505, in run_script
exec(code, namespace, namespace)
File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.6.dev0-py2.7.egg/EGG-INFO/scripts/openaps-report", line 82, in
app( )
File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.6.dev0-py2.7.egg/openaps/cli/init.py", line 51, in call
self.run(self.args)
File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.6.dev0-py2.7.egg/EGG-INFO/scripts/openaps-report", line 75, in run
output = app(args, self)
File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.6.dev0-py2.7.egg/openaps/cli/subcommand.py", line 52, in call
return self.method.main(args, app)
File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.6.dev0-py2.7.egg/openaps/reports/invoke.py", line 40, in main
output = task.method(args, app)
File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.6.dev0-py2.7.egg/openaps/uses/use.py", line 45, in call
output = self.main(args, app)
File "/usr/local/lib/python2.7/dist-packages/openaps-0.1.6.dev0-py2.7.egg/openaps/vendors/dexcom.py", line 536, in main
for egv, raw in itertools.izip_longest(iter_glucose, iter_sensor):
File "/usr/local/lib/python2.7/dist-packages/dexcom_reader-0.1.10-py2.7.egg/dexcom_reader/readdata.py", line 300, in iter_records
for x in reversed(xrange(start, end)):
OverflowError: Python int too large to convert to C long

I think this belongs in https://github.com/openaps/openaps/issues rather than oref0.  This project is all JS; the openaps toolkit is Python.

Oh, you're trying to do raw with a G5.  You can't do that: the receiver doesn't have raw isig values.

Thanks,  I appreciate your help,
Wes
From: Scott Leibrand<EMAIL_ADDRESS>Sent: Sunday, August 14, 2016 10:19 PM
To: openaps/oref0
Cc: maciorowski; Author
Subject: Re: [openaps/oref0] Error executing: openaps report invoke raw-cgm/glucose-raw.json (#193)
Oh, you're trying to do raw with a G5. You can't do that: the receiver doesn't have raw isig values.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/openaps/oref0/issues/193#issuecomment-239721857 , or mute the thread https://github.com/notifications/unsubscribe-auth/ATqiR_NGL1BlJGFO2GgDtGBKZaLTKRCAks5qf9rAgaJpZM4JkFQw .  https://github.com/notifications/beacon/ATqiR0fQhegQAZpHAPCsMJ9O1aPB6KWpks5qf9rAgaJpZM4JkFQw.gif


Remove support for layer-in-class syntax

If we do not want to rely on a non-standard ECMAScript class system, we have to drop support for method names like LayerName$layeredMethodName becoming partial methods automatically. It would be possible to rectify classes/prototypes with these later, or we could write some kind of mixin which does that, but this can be done when the need for it arises in the first place.
The test cases relying on that syntax should be rewritten with the class-in-layer syntax (refineClass/refineObject) or removed if the same test case exists with class-in-layer syntax already.

Done 64e86e277


Add an option on the landing page to create dummy fact checks for quick exploration

For folks who want to quickly install and explore the tool, it might be beneficial to have an option on the landing page to install dummy data. Needless to say, clicking on the button should install the dummy data defined in the data files here

[ ] Add sample json files for dummy data
[ ] Option of adding dummy data should be only available when the instance doesn't have any fact-checks, ratings, claimants
[ ] Create an env param, INSTALL_DUMMY_DATA which automatically installs dummy data during the startup if there is no existing data for the entities: fact-checks, ratings, claimants

@shreeharsha-factly or @deshetti can one of you send me what all dummy data we want to store on install.


Twitter OAuth Failure Leads to Broken State

When attempting to connect my account to Twitter via the OAuth flow, the twitter endpoint failed with a 503.

Though it incorrectly shows me that my twitter account has been connected:

and in the "Editor" view it shows "not connected":

and a continuous loading indicator in the account info modal:

This is not applicable to the new version of the authentication flow. I will close it, thanks for highlighting it @weswalla


Da vatatron finally ready ish.

Description
Implements the Vat along with some test recipes
Todo

[ ] Custom processing widget, this is not made since the widgets are to be rewrited for 1.19.4 if I recall correctly.
[ ] Custom processing widget for the JEI integration.
[x] Fluid tank update needs to be merged before this.
[ ] This code must be rebased to accommodate for said update.

Checklist:

[x] My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you)
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

Hey; are you still keen to work on this PR with us? Thanks!

Hey; are you still keen to work on this PR with us? Thanks!

Yes. I'd very much like to continue working on it. Life has come in between I'm afraid and hope to come back to it before the end of the summer hopefully. I really like the modding community and what EnderIO is becoming, so defiantly still keen even though time is at a premium at the moment in my life

No worries, no pressure at all!

We're going to go ahead and close this. The vat might see some changes in direction and this PR is also really outdated at this point.
Thanks for your work on this though, feel free to come back to the Discord and chat with us if when you're free :)


User interaction while animating

While animating a UIView, user interaction is disabled. Could you please add an option to enable/disable user interaction while the animation is running (just like the UIViewAnimationOptions.allowUserInteraction option)?
The only way to get it done is to change TweenManager.swift line 90:
CATransaction.setDisableActions(false) // was true

I suggest adding the possiblity to change this without changing the pod itself.
Thank you

I'm currently wrapping up major refactoring for the 1.0 release and will look into making sure user interaction is working properly for that release soon.


Grub2 grub_user fix

The user generation script was incorrectly outputting additional
erronous information

Coverage remained the same at 95.402% when pulling 61fa7e83990f65bf0c7988aede7443cc0b3c6b43 on trevor-vaughan:grub2_user_fix into ce7389d77963a7afa9e86edc22c88e8ee96895c1 on hercules-team:master.

Also why include /boot/grub/grub.cfg since that is only grub not grub2?

Since that's what Ubuntu uses for Grub2 configuration.
This removal, which was not documented in the commit message, has broken at least Ubuntu (maybe also Debian).
Grub1 would use menu.lst which is completely unrelated to the files looked for here.
See #36 for my fixup PR.


Raku®

The Raku® Programming Language is used in the footer. As I understand, this should be a trademark, not a registered mark.

@codesections

it appears in multiple locations

No, ® is fine for Raku – we needed to use ™ before our trademark was registered, but it is now.  (The USPTO doesn't seem to believe in permalinks, but you can see the registration by using their search page and running a "structured search" for our registration number: 6456780).
We should still use ™ for any marks that aren't registered (e.g., Rakudo, Camelia).  See #192.