Add support for FP16 output for tl.dot

As discussed at #1080, this PR wants to add  support for FP16/BF16 output for tl.dot.

Nice! It's not trivial work; thanks for doing it.
Small suggestion: I think allow_f16_acc is not a very accurate name, since it is not something that we want to allow but something that we want to enforce. How about just:
tl.dot(a, b, out_dtype=tl.float16) ?

Nice! It's not trivial work; thanks for doing it.
Small suggestion: I think allow_f16_acc is not a very accurate name, since it is not something that we want to allow but something that we want to enforce. How about just: tl.dot(a, b, out_dtype=tl.float16) ?

Thanks @ptillet for the quick review! Sure, I will change the variable names as you suggested. The unit tests and benchmarking will be added as well.

@ptillet The variable name is changed and also update the unit tests for test_dot. Could you please take a look when you get a chance?

I'll take a look!

The cpp style issue is resolved.

hmm it doesn't quite seem resolved 🤔  Are you using clang format from pip install clang-format ? There can be discrepencies between versions

Only run test_dot, but forgot to run all the tests inside test_core.py... After the above fix, all the tests in test_core.py are passed locally on A100.

Merge the main branch again (git pull --rebase upstream main is used to merge the main branch, resulting in that the commit history did not show it. Maybe git pull is better?). And fix the accuracy check failure in test_matmul.py, which is caused by the default out_dtype in tl.dot is float16. Not quite sure why test_core.py failed as the tests passed locally.

Not sure what's going on, but it seems like test_core.py is segfaulting even on top of current main

Do you think here needs to be out_dtype: tl.constexpr instead of out_dtype: tl.dtype?

oh yes, it does need to be tl:constexpr

The test still fails. I can reproduce it locally now by adding `TRITON_USE_ASSERT_ENABLED_LLVM=TRUE' to the build command. Will take a closer look.

The failed unit test should be fixed by this commit (https://github.com/openai/triton/pull/1258/commits/115517bc9dd2913fc2c0bb699b0a21777251811b). @ptillet  Could you help trigger the CI test again?

Very close! I think it's ok to throw an error message on V100.

Thanks @ptillet ! Not quite sure which case caused the failure on V100 from the CI log here. I will find a V100 machine to reproduce it.

I don't think your PR handles V100 codegen. You can add it in another PR; I'm comfortable merging this one as long as we raise an exception on V100 for this mode.

The exception for V100 is added now.

There was a python style issue in the last commit. It is fixed now.

I think the perf regression test is grumpy. I'll force-merge this PR

Thanks @ptillet a lot for your help with this PR!

FYI after merging I noticed a big problem that made out_dtype=float16 by default, but it is fixed now.

Yes, after checking the CI log, I saw a failure of accuracy check in flash attention. Thanks @ptillet for the quick fix!

Hello, out of curiosity, this PR did not cover BF16?

@jon-chuang
I read below from your link.
// Floating point (.f16 multiplicands) wmma.mma
wmma.mma.sync.aligned.alayout.blayout.shape.dtype.ctype d, a, b, c;

// Integer (.u8/.s8 multiplicands) wmma.mma
wmma.mma.sync.aligned.alayout.blayout.shape.s32.atype.btype.s32{.satfinite} d, a, b, c;

.alayout = {.row, .col};
.blayout = {.row, .col};
.shape  =  {.m16n16k16, .m8n32k16, .m32n8k16};
.dtype   = {.f16, .f32};
.atype   = {.s8, .u8};
.btype   = {.s8, .u8};
.ctype   = {.f16, .f32};

Is the reason that mma does not support bfloat16 because there's no bfloat16 in dtype?

Anyone can enlighten me on deeper reasons why MMA doesn't support bfloat16 out? Thanks


[Feature Request]: Set persistence directory on boot

Describe the problem
When launching the docker instance the default directory for data output is ./chroma and it is relative to the repository itself. However, when deploying Chroma on ephemeral disk services like Render.com, we cannot have the storage be on the same ephemeral disk as the repo, since on restart the data will no longer persist.
Persistent disks on services like Render are allowed but are not relative to the repo and are absolute paths. Since we cannot set the persistent directory on the initial boot, it becomes tedious to ensure subsequent reboots and restarts all write to the persistent storage.
Describe the proposed solution
Like with IS_PERSISTENT=1 there could be a variable for PERSISTENT_STORAGE that if set, would be the absolute path to write to and if unset, would fallback to the default ./chroma directory.
fall back
Alternatives considered
No alternatives that would be within the scope of this repository.
Importance
would make my life easier
Additional Information
No response

POC: https://github.com/timothycarambat/chroma/commit/2e42e9fae7ce31bd40300a2210d8267ffce47a8d

facing this issue right, also on Render deployment. What is the work around temporarily until this is resolved?

@timothycarambat there is already an env var called PERSIST_DIRECTORY (lower case works too) through which you can control the dir where chroma would store persistent data. - https://github.com/chroma-core/chroma/blob/221bdfa91335bb096fbc632f098a858ff56ea866/chromadb/config.py#L83

facing this issue right, also on Render deployment. What is the work around temporarily until this is resolved?

My current "workaround" is just a branch on my fork that has it hardcoded to /storage and then on render I just set that as the root volume for the disk.
https://github.com/timothycarambat/chroma/commit/2e42e9fae7ce31bd40300a2210d8267ffce47a8d
Video: https://www.youtube.com/watch?v=ADv9pk3zOIM

@timothycarambat there is already an env var called PERSIST_DIRECTORY (lower case works too) through which you can control the dir where chroma would store persistent data. -
https://github.com/chroma-core/chroma/blob/221bdfa91335bb096fbc632f098a858ff56ea866/chromadb/config.py#L83

I was unsure how I could set this as an ENV variable and have that passthrough to the docker container so it would pick that up on boot. That was the crux of my issue and I simply think that comes down to just being better at docker configs.

@timothycarambat I too spent some time tinkering with Pydantic BaseSettings and Docker until I figured it out when creating the helm chart :), so just sharing my experience here ;)

@timothycarambat should be just setting it in environment: https://docs.pydantic.dev/latest/usage/pydantic_settings/#environment-variable-names

@ibash, yes you can use env to set the persistent directory. Here's an example how to run the server locally with your own persistent dir:
PERSIST_DIRECTORY=/path/to/your/persistend_dir IS_PERSISTENT=1 uvicorn chromadb.app:app --workers 1 --host <IP_ADDRESS> --port 8000  --proxy-headers --log-config log_config.yml --reload


Block explorer shows incorrect number of validating nodes

Description
Check homepage of explorer.vega.xyz, expect to see 13 validating nodes, it says 15.

Closed by #2671


Consolidate ttnn and tt_lib library

@TT-billteng @vtangTT @ttmchiou
This is something we've been tracking on infra side for a while.

what do we need to do our end?

I think we just need to make sure that we should help out with any build stuff, and ensure we're not creating any unnecessary binaries / things that we don't people to link to.

And ensure that we pass CI. There's gonna be a lot of places to replace tt_lib with ttnn.experimental

so we are phasing out the use of tt_lib all together?

I think that should be the ultimate goal. tt_lib -> ttnn.experimental, so the pybindings are hopefully in one place now


Sprite.fromImage is undefined

Expected Behavior
That Sprite.fromImage would exist
Current Behavior
Sprite exists and I have been using it successfully for some time. Sprite.fromImage is undefined.
Possible Solution
Steps to Reproduce
import { Sprite, Container } from "pixi.js";

console.log("Sprite", Sprite);
console.log("Sprite.fromImage", Sprite.fromImage);

With the result
Sprite ƒ e(e){var i=t.call(this)||this;return i._anchor=new Di(i._onAnchorUpdate,i,e?e.defaultAnchor.x:0,e?e.defaultAnchor.y:0),i._texture=null,i._width=0,i._height=0,i._tint=null,i._tintRGB=null,i.tint=16777…

Sprite.fromImage undefined

Environment

pixi.js version:  6.0.0
Browser & Version: Chrome 89
OS & Version: Mac OX 10.15.7

This was deprecated in v5 and removed in v6. Sprite.from does the same thing. Latest docs are here https://pixijs.download/v6.0.1/docs/index.html

Oh fantastic thanks!


Find default inputs and outputs of onnx model

With onnx model, user needs to enter the names of inputs and outputs of the model.
If we provide default inputs and outputs of onnx model, it would make usability better.
Things to do:

[ ] check why one-import-tflite does not need inputs and outputs list but one-import-onnx needs
[ ] design how to introduce this feature
[ ] implementation (TBD)

Why I think we need to do this task?
I checked one-import-onnx:
$ /usr/share/one/bin/one-import-onnx --help
usage: one-import-onnx [-h] [-v] [-V] [-C CONFIG] [-i INPUT_PATH] [-o OUTPUT_PATH] [-I INPUT_ARRAYS] [-O OUTPUT_ARRAYS] [--model_format MODEL_FORMAT]
                       [--converter_version CONVERTER_VERSION] [--unroll_rnn] [--unroll_lstm] [--save_intermediate]

command line tool to convert ONNX to circle

optional arguments:
  -h, --help            show this help message and exit
  -v, --version         show program's version number and exit
  -V, --verbose         output additional information to stdout or stderr
  -C CONFIG, --config CONFIG
                        run with configuation file
  --unroll_rnn          Unroll RNN operators
  --unroll_lstm         Unroll LSTM operators
  --save_intermediate   Save intermediate files to output folder

converter arguments:
  -i INPUT_PATH, --input_path INPUT_PATH
                        full filepath of the input file
  -o OUTPUT_PATH, --output_path OUTPUT_PATH
                        full filepath of the output file
  -I INPUT_ARRAYS, --input_arrays INPUT_ARRAYS
                        names of the input arrays, comma-separated
  -O OUTPUT_ARRAYS, --output_arrays OUTPUT_ARRAYS
                        names of the output arrays, comma-separated
  --model_format MODEL_FORMAT
  --converter_version CONVERTER_VERSION

Today people suggested me to check existing cfg files and I found that cfg does not have INPUT_ARRAYS.
I also ask @seanshpark and he mentioned that that option is not used any more. :-)

/cc @llFreetimell

I've heard that pb file also does not need input array when tf.__version__ > 2.
I wonder if we need to support tf version 1....

I wonder if we need to support tf version 1....

@lemmaa , any information on this?

tf 1.x still exists in our customer requirements. We will have to keep it going for the time being.

@seanshpark updated this issue with TF.
Please refer to https://github.com/Samsung/ONE-vscode/pull/740#discussion_r885229372
Let me close this issue.


Vapoursynth R58

Trying to install vs-dpir to latest portable Vapoursynth R58-RC1,
but I get:
I:\Hybrid\64bit\Vapoursynth>python -m pip install --upgrade vsdpir
Collecting vsdpir
  Downloading vsdpir-2.1.0-py3-none-any.whl (7.0 kB)
Collecting VapourSynth>=55
  Downloading VapourSynth-57.zip (567 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 567.1/567.1 KB 7.1 MB/s eta 0:00:00
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [15 lines of output]
      Traceback (most recent call last):
        File "C:\Users\Selur\AppData\Local\Temp\pip-install-8umebnq_\vapoursynth_2f81ae9c21b34d768097c5a208b5989a\setup.py", line 64, in <module>
          dll_path = query(winreg.HKEY_LOCAL_MACHINE, REGISTRY_PATH, REGISTRY_KEY)
        File "C:\Users\Selur\AppData\Local\Temp\pip-install-8umebnq_\vapoursynth_2f81ae9c21b34d768097c5a208b5989a\setup.py", line 38, in query
          reg_key = winreg.OpenKey(hkey, path, 0, winreg.KEY_READ)
      FileNotFoundError: [WinError 2] Das System kann die angegebene Datei nicht finden

      During handling of the above exception, another exception occurred:

      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "C:\Users\Selur\AppData\Local\Temp\pip-install-8umebnq_\vapoursynth_2f81ae9c21b34d768097c5a208b5989a\setup.py", line 67, in <module>
          raise OSError("Couldn't detect vapoursynth installation path")
      OSError: Couldn't detect vapoursynth installation path
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

any idea how to get vs-dpir setup with Vapoursynth R58?

Unfortunately ONNX Runtime doesn't support Python 3.10 yet. Wait for its new version or use vs-mlrt.


TimePicker minutes "snap back" for small changes in iOS

Environment

Tech
Version

@material-ui/pickers
^3.2.3

material-ui
^4.3.1

TypeScript
3.5.3

React
^16.9.0

Browser
Safari 13 (and 12)

Peer library
date-fns

Steps to reproduce

navigate to https://material-ui-pickers.dev/demo/datetime-picker in mobile Safari
select date and hour to get to minutes
3.make a small adjustment in time (typically 1 to 3 minutes) in either direction

Expected behavior
Picker displays selected time
Actual behavior
The selection immediately jumps back, either to the previously selected time or another nearby value.
Live example

Any progress or comments on this issue?
This is an issue we're experiencing as well.

I couldn't reproduce, does it happen on https://next.material-ui-pickers.dev/demo/datepicker too?

Just reproduced using an iPhone 11 on iOS 13.5.1 with the above link.
Especially noticable when you drag the selection around and release.

@NGuldager I couldn't reproduce, however, there is an event.preventDefault() issue. We shouldn't be able to scroll the container.

Ok, my bad, I could also reproduce, I'm opening a different issue for the above.


Dapr RabbitMQ binding failing

Expected Behavior
Invoke microservice using RabbitMQ binding without failure.
Actual Behavior
RabbitMQ Binding is failing when the system remains idle for several hours leading to RabbitMQ - Dapr connection getting closed.
RabbitMQ Log:
2022-01-06 10:48:55.460 [warning] <0.5618.44> closing AMQP connection <0.5618.44> (<IP_ADDRESS>:39128 -> <IP_ADDRESS>:5672, vhost: '/', user: 'dapr'):

client unexpectedly closed TCP connection
.
.
.
2022-01-06 10:48:55.461 [info] <0.17915.47> Closing all channels from connection '<IP_ADDRESS>:39130 -> <IP_ADDRESS>:5672' because it has been closed

2022-01-06 10:48:55.461 [info] <0.17917.47> Closing all channels from connection '<IP_ADDRESS>:32814 -> <IP_ADDRESS>:5672' because it has been closed

rabbitmq log.txt
Steps to Reproduce the Problem

Deploy dapr v1.4.3-1.5.0 on k8s cluster

helm repo add dapr https://dapr.github.io/helm-charts/
helm repo update
helm install dapr dapr/dapr \
--version=1.5 \
--namespace dapr-system \
--create-namespace \
--wait

Deploy RabbitMQ on k8s
Deploy RabbitMQ binding component on k8s cluster

apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
  name:test-api
spec:
  type: bindings.rabbitmq
  version: v1
  metadata:
    - name: queueName
      value: myqueue
    - name: host
      secretKeyRef:
        name: rabbitmq-secret
        key: HOST
    - name: durable
      value: true
    - name: deleteWhenUnused
      value: false
    - name: prefetchCount
      value: 0

Deploy daprized microservice created using Fast API framework on k8s
main.py

import os
import json
from typing import List, Optional
from fastapi import FastAPI, Request, Response
from pydantic import BaseModel

app = FastAPI()

class Topic(BaseModel):
    title: str
    author: str

@app.api_route("/test-api", methods=['OPTIONS'], status_code=200)
def test_api_binding():
    return {'success': True}

@app.post(path="/test-api", status_code=200)
def perform_task(topic: Topic):
    # Method to perform task for a topic
    # :return: json
    print(f"Request to perform task for topic {topic.title}", flush=True)
    return {'success': True}

Docker CMD: uvicorn main:app
4. Trigger the microservice using binding
from dapr.clients import DaprClient

with DaprClient() as d:
    resp = d.invoke_binding(name='test-api', operation='create', data='{"title":"Test","author":"Dev"}')

Let the system remain idle for over 24 hours
Try to trigger the microservice again using binding

Release Note

RELEASE NOTE: FIX RabbitMQ - Dapr Connection Bug.

/assign

@skmaingi, I was able to deploy the setup. Is there a way to decrease the duration of the test cycle?

@skmaingi, I could not to reproduce the issue after 24 hours.
My k8s cluster runs in AKS, and I'm using Bitnami's char to deploy RabbitMQ:
helm repo add azure-marketplace https://marketplace.azurecr.io/helm/v1/repo

helm install dapr-demo azure-marketplace/rabbitmq ...

The main difference is that I'm running the latest dapr code, and not v1.5.
The new dapr release v1.6 is expected in the upcoming weeks.
In the meantime, could you try my custom image docker.io/dmitsh/dapr:dev-linux-amd64 and see whether you could reproduce the issue in your environment?

@skmaingi, I was able to deploy the setup. Is there a way to decrease the duration of the test cycle?

Hi @dmitsh,. We have tasks that will run for over 24 hours i.e. perform_task(topic: Topic). When those tasks run, the system could remain idle for hours waiting for other requests to process

@skmaingi, I could not to reproduce the issue after 24 hours.
My k8s cluster runs in AKS, and I'm using Bitnami's char to deploy RabbitMQ:
helm repo add azure-marketplace https://marketplace.azurecr.io/helm/v1/repo

helm install dapr-demo azure-marketplace/rabbitmq ...

The main difference is that I'm running the latest dapr code, and not v1.5. The new dapr release v1.6 is expected in the upcoming weeks. In the meantime, could you try my custom image docker.io/dmitsh/dapr:dev-linux-amd64 and see whether you could reproduce the issue in your environment?

Thank you @dmitsh. I will test with your custom image

@dmitsh could this issue be related to this https://github.com/dapr/dapr/issues/2301
There is a timeout error we get for tasks that take several hours or days to complete.
2022-01-06 10:49:01.089 [info] <0.18126.47> connection <0.18126.47> (<IP_ADDRESS>:33468 -> <IP_ADDRESS>:5672): user 'dapr' authenticated and granted access to vhost '/'
2022-01-06 11:19:03.607 [warning] <0.18136.47> Consumer ctag-/daprd-3 on channel 1 has timed out waiting for delivery acknowledgement. Timeout used: 1800000 ms. This timeout value can be configured, see consumers doc guide to learn more
2022-01-06 11:19:03.608 [error] <0.18136.47> Channel error on connection <0.18126.47> (<IP_ADDRESS>:33468 -> <IP_ADDRESS>:5672, vhost: '/', user: 'dapr'), channel 1:
operation none caused a channel exception precondition_failed: delivery acknowledgement on channel 1 timed out. Timeout value used: 1800000 ms. This timeout value can be configured, see consumers doc guide to learn more

@skmaingi, I deployed Dapr v1.5.0 but still could not reproduce the error in my setup.
I suspect that closing the channel happens in rabbitmq container independently of Dapr.
How do you deploy rabbitmq service? What version?
Regarding dapr/dapr#2301 I'm not sure this is the case. IIUC, you are sending data to rabbitmq, which is output binding functionality.

@dmitsh
RabbitMQ deployment
helm repo add bitnami https://charts.bitnami.com/bitnami
helm repo update
helm install rabbitmq -f values.yaml bitnami/rabbitmq -n <namespace>

values.yaml
auth:
  username: <USERNAME>
  password: <PASSWORD>
  erlangCookie: <COOKIE>
persistence:
  enabled: false
replicaCount: 1
extraConfiguration: |-
  log.file.level = debug
  max_message_size = 512000000

@skmaingi, I checked the binding code and confirmed that dapr does not close any channels. So I'm pretty convinced the closure of the channel happens outside dapr.
Where do you run your k8s cluster, on site or in the cloud?
If you are using AKS, please try Bitnami's version of RabbitMQ for AKS:
helm repo add azure-marketplace https://marketplace.azurecr.io/helm/v1/repo
helm install dapr-demo azure-marketplace/rabbitmq ...

I also checked parameters of my rabbitmq deployment and found one difference, compared to yours:
persistence:
  enabled: true

Thank you @dmitsh
I noticed timeout exception in RabbitMQ logs after binding request.
2022-01-06 10:49:01.089 [info] <0.18126.47> connection <0.18126.47> (<IP_ADDRESS>:33468 -> <IP_ADDRESS>:5672): user 'dapr' authenticated and granted access to vhost '/'
2022-01-06 11:19:03.607 [warning] <0.18136.47> Consumer ctag-/daprd-3 on channel 1 has timed out waiting for delivery acknowledgement. Timeout used: 1800000 ms. This timeout value can be configured, see consumers doc guide to learn more
2022-01-06 11:19:03.608 [error] <0.18136.47> Channel error on connection <0.18126.47> (<IP_ADDRESS>:33468 -> <IP_ADDRESS>:5672, vhost: '/', user: 'dapr'), channel 1:
operation none caused a channel exception precondition_failed: delivery acknowledgement on channel 1 timed out. Timeout value used: 1800000 ms. This timeout value can be configured, see consumers doc guide to learn more

@dmitsh You are right "I suspect that closing the channel happens in rabbitmq container independently of Dapr."
I read this from RabbitMQ consumers link
"Delivery Acknowledgement Timeout
In modern RabbitMQ versions, a timeout is enforced on consumer delivery acknowledgement. This helps detect buggy (stuck) consumers that never acknowledge deliveries. Such consumers can affect node's on disk data compaction and potentially drive nodes out of disk space.
If a consumer does not ack its delivery for more than the timeout value (30 minutes by default), its channel will be closed with a PRECONDITION_FAILED channel exception. The error will be logged by the node that the consumer was connected to."

Thank you for confirming, @skmaingi . Do you require any further assistance?

@dmitsh currently no. I made some updates to test consumer timeout.
Thank you very much for your support and assistance in troubleshooting the issue.


⚠ AtmoVantage Homepage has degraded performance

In c4b27ff, AtmoVantage Homepage (https://atmovantage.com) experienced degraded performance:

HTTP code: 200
Response time: 6352 ms

Resolved: AtmoVantage Homepage performance has improved in 944b9f4.


Editable variables in Django stack frames

When on a breakpoint in a Django template, variables that are displayed in Locals can be edited, but committing the changes doesn't work - the variable just reverts to its original values.
Ideally, this should just work. Alternatively, if all these variables cannot be edited, then Locals shouldn't allow to edit them (i.e. set the read-only flag on IDebugProperty2).

should be retested, unsure if this is any better in ptvsd 4.x

@karthiknadig tested it, definitely not fixed


Cudajit: Reconsider if it is better to use uint or size_t rather than int where it's closer to C API

For things like sizes in bytes, grid_dim_x etc. Currently I'm suggesting int everywhere for convenience, except in kernel_param.Size_t.

IIRC int is better.


Cats is CartesianClosed (when all levels the same)

I tried to prove this, got a fair ways in, and got stuck.  I don't think it is fundamental, just that I'm missing something that will likely turn out to be simple.  Also, my definitions might be off a bit, which certainly wouldn't help matters.
I've pushed my attempts onto branch 'CatsCCC' (as I can't attach .agda files easily here). Holes 3 and 5 in particular.  I think the rest are ok, just tedious.

So I think I know what the source of difficulty is: the definition of 'exponential object' used assumes that some products (as necessary) exist; but we already know all products exist. The problem is that the definition doesn't use the product just given.  But of course the it is CCC is with respect to that one product.  [This definition is inherited from the original port].  I think that if the definition was adjusted so that the exponential object was coherent, by construction, with the given product, lots of things would be considerably simpler.  And it would match the definitions in the literature too.

actually the current behavior is correct.
consider a trivial example. usually we say a product of A and B is A × B. However, it doesn't have to be the canonical representation of the product. for example, B × A is also an legitimate representation. in fact, there isn't a preference between both; they are just equally good, and there are other equally good representations. the uniqueness part of products concludes all such best representations are isomorphic and that's good enough. that the exponential part does not make assumption of concrete representation of a product is consistent with this extensional view.

The current behaviour is definitely not wrong. I agree with your reasoning.
I wonder if anyone has ever proved it in full generality though?  I really have no idea of how to proceed in those 2 holes. I suspect that existing proofs are either just sketches or 'for convenience' pick one product, since they are all "the same" anyways.

I did it in https://github.com/agda/agda-categories/commit/1c7e2f44bb31e7f502b26d256e81cdc8f62ad5e3
it is not too difficult. the problem is that there are slow computation parts. the idea is to make use of the UMP of the products in the construction. assuming a canonical construction is morally correct, because if we only inspect objects and morphisms extensionally consistently, there shouldn't be a problem. this is seen in many other constructions where properties like associativity etc are ignored.

Thanks.  A couple of hours after I posted my comment, your remarks finally sunk in properly, and it finally occurred to me to use the UMP of products.  Still, there was quite a bit of work to do to make it all come together!  Very nice.

I developed @HuStmpHrrr's insight a bit further in #90.


Unable to Submit License

I am trying to submit the form on:
https://ego4ddataset.com/ego4d-license/
but I get an error that says 'Load Failed'.
There are a lot of people posting about the same issue here:
https://discuss.ego4d-data.org/latest

Can you try again, the license server was having some backend issues which we have resolved. Let me know if you still face this issue.

+1; Thanks both for the flag, the license server has now been fixed.
Once you submit the form, you should see a screen similar to this:

There are a couple of issues that affect the license server and we're setting up flows to make it more robust. The server has been functional during the times between forum comments, and once you get a license - you can use the visualizer in the access email to explore the dataset yourself!

Today I'm facing this error

This issue has returned.


Handle commas and full stops (,.)

I would consider also the AT sign (@). Today i faced an username like
<EMAIL_ADDRESS>;)

Maybe this Issue need to be closed !
Because @wvh-shanee already gave the solution.
I finde the use case with email address is also a bit wild , Because no matter what you can extract some meaningful strings from it.

I agree @Korak-997 !


fix: export default orchestrator bot component

Fixes https://github.com/microsoft/botbuilder-js/issues/3598

Pull Request Test Coverage Report for Build 771917813

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.3%) to 84.466%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build 771517078:
1.3%

Covered Lines:
18931

Relevant Lines:
21333

💛  - Coveralls


Do I need to use this library?

I'm already using MSAL.NET in a MAUI app and it seems to support token caching. Am I supposed to be using this library too? (Are tokens stored unencrypted by the built-in token caching and this library adds encrpytion?)

Sorry for the late reply. By default MSAL caches in-memory - when the PublicClientApp or ConfidentialClientApp instance is disposed of, so is the cache. This library is recommended for desktop apps like desktop MAUI. It does support encryption using OS-specific encryption methods. The default in-memory MSAL cache does not. More info in Token cache serialization in MSAL.NET
.


Reorganize split_into_key_value in Parser_utils

We still rely on some obscure scanf regexes to extract keys and values from the fields while parsing. Would be nice to implement the splitting more explicitly approach.
(Also not sure what to do if there are multiple = chars in the filed -- check the FIX specs.)

In my version I did I assumed the = was a special character in the FIX string and determined a valid segment - only happening once per segment. I think that's what the FIX specs say - I'll check, but I don't think you can use = elsewhere


[BEAM-3709] Portable combiner lifting support in py Dataflow Runner.

Modifies the way the CombineValues transform is communicated to
Dataflow for FnApi pipelines to enable support for combiner lifting.
Important: Don't merge this change in until #6128 is merged. Doing
so will cause pipelines containing combines with side inputs to fail.

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.


V9

As part of my mission to rewrite all my modules as TypeScript modules with hybrid exports, and update the entire world apparently, v9 is coming.
It's pretty much working, but the tests still need a lot of cleanup.
Summary of changes in the changelog.

100% test coverage all passing!
The only thing left to do is refactor some of the initial path management out of the walker class.  Right now, it's a bit too smart.  All of the "setStart()" and absolute/windows path detection belongs in Glob, not GlobWalker.

Mostly got performance up to where I want it with some aggressive caching of readdir calls and a few other minor fixes, but found an interesting pathological cases.  When a globstar is followed by multiple magic patterns, especially if those include another glob star, the performance falls off a cliff.
So, in a big directory tree, a pattern like **/*/*.txt takes about twice as long as it should, and a pattern like **/*/**/*.txt takes 3x as long as it should.
Need to rethink the approach for handling **, I think.

It is currently spending too much time in path resolution. I have an idea for a way around it, though it does involve writing Yet Another dir walker type thing, as none of the ones I found on npm give me quite what I want. But, I think that could be useful if I ever need to revisit modules like ignore-file that do directory traversals, so it would be worth being it's own thing.

Thanks for working on this, and for your recent work on rimraf and minimatch, too! These dependencies are in literally all of my projects, often multiple times. It's not at all a given that you'd spend your time on this, but you do, and it's improving the dev experience for many thousands of people. Thank you!

This exists now: http://npm.im/pointer-set
Now on to the thing that uses it.

Ok, so, TURNS OUT, using uint32 slab pointers in this way can be faster, but only in cases where gc is a major performance killer, ie where objects are being deleted quickly, like in a cache that's pushing out old items.  That's why it makes lru cache implementations so unreasonably fast.  But in a case where I'm walking a bunch of paths and keeping the information around for the duration of the walk, the work of allocating and accessing and dereferencing uint32 pointers into an expanding data store of that sort is actually much worse than just using consistently-shaped objects, since they're not going to be garbage collected until after the call is completed.
And in fact, if you re-use the data store (so a reference to it is maintained), then it's never garbage collected ever so the object-based data store (which, also, is like, way simpler and less awkward to work with) is significantly faster.
All this is to say, the exploration of pointer-set was fun to write and might be useful for some application someday, but it's not useful for this, which means it was... well, not pointless, but academic rather than practical.
On to the next approach, I guess, the (not pointer-based) path walker.  The fundamental algorithm is still worth pursuing, just don't need to be doing as much pointer arithmetic and bit-shifting, which frankly, is kind of a relief in a way.

Since I know some folks are watching this, maybe some of y'all could weigh in:

Dirent data: Would it be worthwhile to have a { withFileTypes: true } option, and get a Dirent-type thing returned instead of path strings?  I find a lot of applications where I'm globbing for paths, I immediately turn around and stat them to call isDirectory() or something on them, so it might be handy to have that already done, since the glob walk has to gather that info on its way anyhow.

Bash-style weird paths.  Let's say you have a folder structure like:
a
+-- b
|   +-- c
+-- x

If you do echo a/*/../b/c then shells will output a/b/../b/c a/x/../b/c, even though these two entries are actually the same thing.  Would it be more useful to just get a single a/b/c back?  That'd actually be much easier to do.
Same if you have dots or multiple slashes in the pattern.  So if you did a///.///*/c, that'll return a///./b/c.  Just returning the joined path would be less work, because it would mean that I can just walk up and down the tree that PathScurry creates, which cuts out the need to track the literal pattern that got resolved at each step.

Bonus, this is going to handle UNC paths and windows drives, and in windows mode, will return canonical windows-style paths, like c:\\x\\y\\z instead of c:/x/y/z. Tbh, as a long time unix user, the second looks way less weird to me, but I know feels off-putting to Windows users, and PathScurry makes that the default behavior.

{ withFileTypes: true } would be very useful! 👍
The second seems nicer and more useful in practice with your suggestion - how much to diverge from shell globbing and how that might surprise people I couldn't say (IIRC I've never used either syntax). Maybe a normalize (or something) option which defaults to true?

The second seems nicer and more useful in practice with your suggestion - how much to diverge from shell globbing and how that might surprise people I couldn't say (IIRC I've never used either syntax). Maybe a normalize (or something) option which defaults to true?

I could see it being a bit weird if you get absolute paths instead of relative paths.  For example, if you had a module that globs for files to include in a package.json or other project-specific config file, then I definitely don't want to end up hard-coding /Users/isaacs/projects/isaacs/blah/dist/foo.js somewhere, and having to do an extra step to relativize the paths is annoying.
Tracking the "pattern expanded" path is a bit odd, tbh, and results in getting duplicate entries, which isn't a huge deal in a shell context, but can be annoying in other places.  (Eg, getting both a/b/../b and a/x/../b, which resolve to the same path.) The previous implementation did it that way because it worked by appending each new piece of the pattern's expansion onto the prior string (which is afaik also more or less how bash works).  I suppose I could add it as an option, with the caveat that it means slightly reduced performance (because a duplicate Path object will have to be tracked multiple times).
One possible approach is add a Path.relative(from = cwd) method to the PathScurry path object, which would walk up from the two paths and find their nearest ancestor.  (And we could take some shortcuts there, like if it finds that its parent path's relative value is ../foo, and its name is bar, then you know it's ../foo/bar, so it could start out by stashing the relative paths to all the ancestors of the cwd, and the root as /.)
If I did that, then the default result would be that the a/*/../b pattern would resolve to a/b, without any additional work.  Then if you set {absolute:true} or {realpath:true} in the options, you'd get /full/path/to/a/b.

If I did that, then the default result would be that the a/*/../b pattern would resolve to a/b, without any additional work. Then if you set {absolute:true} or {realpath:true} in the options, you'd get /full/path/to/a/b.

That seems very reasonable to me

For the last pathological perf case, I think I can fix it with some clever preprocessing in minimatch, just need to prove that these equivalencies hold in all cases:

pre/**/../<more> is equivalent to pre/../**/<more>
pre/<not **>/../<more> is equivalent to pre/<more>

If that's the case, than I can eliminate .. from the pattern in all cases except for the first or final position, and never have a case where it causes repeated ** calls, because a pattern like */../**/*/../** will resolve down to just ./**

Ah, no, pre/**/.. isnt equivalent to pre/../**, because the first will only include the parent and all children of pre, but the second will also include the siblings of pre.

But, I think I can still improve it a different way, by only ever walking a given path with a given pattern set one time.
Currently, a pattern like x/**/../*.txt will search the x path for *.txt once for each child of x. (Same for their children, etc.) Should be able to short circuit that.

Alright! Passing with full coverage on linux and macos, passing with ~98% coverage on windows, because I'm still skipping all the symlink and realpath tests.
All that's left now is docs.


Refactor - Bump deps

Upgrade React Native from 0.71.1 to 0.71.12

Version test: https://file.cdmteck.com/s/DB9JLAnjJczopcC/download?path=%2F&files=SubWalletMobile-build-200-888-merge-2023-07-17T05-02-28.ipa
Devices test: IP 11
Validation passed.


Only provide scopes when set in options

Partially reverts #1030
This will still allow to set a scope on the access token as array and format it properly, but it will not add the default scopes by default.
Setting the scope in the access token request is optional according to https://www.rfc-editor.org/rfc/rfc6749#section-3.3
In practice it seems to limit the scopes that are set in the authorization flow to a subset of the original scopes. But this is depending on the implementation.
Hopefully fixes #1052, #1051, https://github.com/RiskioFr/oauth2-auth0/issues/28 https://github.com/Weble/ZohoClient/pull/34
cc @sandervanhooft @liayn
For libraries needing to add default scopes to the access request, I would suggest something like this in your own provider:
public function getAccessToken($grant, array $options = [])
{
    if (empty($options['scope'])) {
        $options['scope'] = $this->getDefaultScopes();
    }

    return parent::getAccessToken($grant, $options);
}

I've tried your branch and it works good with Auth0.

Anyways to prioritize this getting merged?

Not sure. I think only @ramsey can merge this. I'm not really sure about the impact but it seems the previous PR does break some cases.

It unfortunately breaks Google OAuth refresh tokens quite significantly. Any custom scope aside from the default provider ones that was originally requested on the initial token (which works) is lost on a refresh making the token essentially invalid for the API context it was originally requested for.
I can see this PR is kind of the happy medium between the original purpose of the original PR and keeping existing clients working. If it is not accepted, everyone who uses Google APIs through the oauth2-client provider would need to amend their provider class to handle the token side of things specifically. I'm not sure that's the best move.


fix: Fix list lowering bugs

Fixes some lowering bugs for list subscripts. Also adds more tests for list subscripting (mostly copied from test_array.py)

Codecov Report
Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.64%. Comparing base (6449184) to head (deb4300).

Files with missing lines
Patch %
Lines

guppylang/prelude/_internal/compiler/list.py
75.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   91.16%   91.64%   +0.48%
==========================================
  Files          59       59
  Lines        6257     6260       +3
==========================================
+ Hits         5704     5737      +33
+ Misses        553      523      -30

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Enhance filters tests

@nmirasch @bsremac please take a look.

@cristianonicolai Looks good Cristiano. Thank you.
I will be able to relax existing Selenium tests by removing a certain group of assertions.
Just one comment from my side.

@bsremac changes done.


Bug Reporter does not allowing undo

Type: Feature Request
If I am filing a bug report, I cannot undo anything.
VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:48:16.874Z)
OS version: Darwin arm64 23.2.0
Modes:

https://github.com/microsoft/vscode/assets/13932583/5e401beb-ec21-4398-bdca-d402882f1d52

/duplicate https://github.com/microsoft/vscode/issues/87904


Review develop branch, develop with style branches

Determine if we can merge or not.
@simongamester

We asked @simongamester .

Develop merge has been deleted and Develop with styles has been merged with Develop


Split into features

Fixes #10
Each individual feature seems to build, and by default the union also builds. Perhaps we should add CI for this.

@niondir Mind cutting a release with this?

Created a tag 0.1.0 does this help you?
Since I'm not using this code in any project at the moment I'm also open to offer you maintainer permissions.
Let me know if you plan to work more on this and if it makes sense.

@niondir I was more looking for a cargo publish with a bumped cargo.toml

I don't know how much I'd be using it, but happy to help a bit with maintainership


webui on a device on local network

How do I access webui on a different device connected to the same local network?

Please check this discussion : https://github.com/rupeshs/fastsdcpu/discussions/210


WIP: Redesign website

This PR replace the static pages into a full webpack based VueJS project, also uses github actions for CI, redesign the interface with Buefy/Bulma css framework.

I reorganised the project so we can use npm build system and CI to generate the site
Make the model cards more general such that we can also include datasets and applications, also notebooks can be added later
The search feature is much more improved, now we support also free text, there is also tag groups as suggested by Anna
Added badges, for example the CO2 footprint badge. Later, we can add also certificate for model reproducibility, tests passed etc.
Each model is now associated with an anonymous animal to make it more like a zoo ;)
Multiple cover images are shown as carousel
Use github style to show documentation
Improved dialog window that can be maximized and dragged

Fixes #6
Fixes #22
Fixes #23

The buttons on the other pages, about, contribute etc are not working on mobile, neither Firefox or Chrome.
Should those pages not show as subfolders in the url?

The buttons on the other pages, about, contribute etc are not working on mobile, neither Firefox or Chrome.
Should those pages not show as subfolders in the url?

It looks fine on iOS, how does it looks on android?

I mean the buttons on the actual about and contribute pages. Not the menu.

This is how the about page looks for me on android Firefox.

This is how the about page looks for me on android Firefox. The x and the two slice hamburger menu buttons don't do anything when pushed. And there's no dedicated subdirectory for the page in the url.

I see, thanks for the report, I will fix that, I saw the same on ios.

@MartinHjelmare Could you test on you mobile with the latest version (reload a few times to make sure)?

Now the x-button works. The maximize/minimize button is now active but doesn't make any change on my screen size. Maybe hide it on mobile screens?

Now the x-button works. The maximize/minimize button is now active but doesn't make any change on my screen size. Maybe hide it on mobile screens?

Good point, just changed, please try it in the next preview.


UX: Lack of info about filtering while browsing records/entities

Scenario:

apply filter in grid view;
enter view for any filtered record;

If filter reduces number of records you'll be able to view only filtered set of records (by pagination).
It works as expected but there is no info about:

applied filter;
filter details;
number of total records;
possibility to clear filter .. etc.

Shouldn't filter block (minimized?) be inserted "before content" if not empty?

@axelmm So you'd like to see the applied filter somewhere in the pagination control on the record view, am I getting you correctly?

This is about views being self descriptive.
In grid view we can see "ALL" "Contacts" followed by "Options" and conditionally "Edited" addition appearing when some filters or sorting are applied. We can directly see all filters, their conditions and from all these deduce that list is filtered. This isn't explicit shown, we can even see in pagination description "Total of {{ totalRecords }} records" whitch is ... missleading because it's not total but filtered/searched results, not all records but it's quite good, enought for grid view as all these connected informations describes this record set. (I have to remove "total" from translations.)
It would be ideal when grid paginator could be aware of filtering conditionally showing "Total of {{ totalFilteredRecords }} filtered records" "( {{ totalRecords }} )" and this last totalRecords being link (url) for "pure", non-filtered list (f.e. "/contacts/" for All Contacts).  but I'm aware this is not grid's [single bundle] responsibility ... injection from FilterBundle ... extension?
There is a lot lower number of descriptive informations in record view ... we can have 1 record filtered from 101 total and having no clue where are missing 100, how to "get back" to whole 101 records.
It's enought to have only label "Filtered results" info next to pagination control displayed only when filter is applied (and count filtered != total). Just more explicit info, like filtering/searching issues results with "Clear current search query, filters, and sorts" - additional info/action for being more readable than indirect looking for active filter condition,
Being more accurate there can be a conditional "filtering block" (next to pagination, before bookmark buttons) with more usable informations and actions like: button back-icon with hint "Back to filtered list", cross-icon with "Clear filtering, show all" ...number of totalNonFilteredRecords ... and so on ... extending it will be easier when will be sth to extend ;)

@axelmm Thanks for the detailed description, it's very clear now.
I definitely see value in this request but it's hard to provide any timeline for our own implementation. Therefore I will mark it as open for contribution for now and if our priorities change, will update the issue accordingly.
Thank you for helping us become better!


online transactions still not populating

When someone pays online and then renews or buys a badge the information about their online sale is not populating.  The same is happening for sales of steel and holster certs and the quiz results.  When I mentioned this before you said it was only when the email was not the same but this is still happening for all online sales regardless or the email used.

Should be good

Should be good


chore: import repository https://github.com/cns-ubiwhere/quickstart-node.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

@cns-ubiwhere: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
7ca1f5b4a24c67914d39eadb6ad69bbacaad5429
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Issue when connecting two models

I am working with a GAN-like model where I have a generator and a discriminator. Each of the models is a Model (using the new functional API). Both models work individually, but when I try to connect them, I get a MissingInputError telling me that an input to the graph is missing. That happens to be the input to the discriminator, which is the second model in the processing chain. I tried connecting the models both by using a Sequential object and by creating a new Model like this:
inputs = Input(shape=generator_input_shape)
generated = generator(input)
output = discriminator(generated)
discriminator_on_generator = Model(input=inputs, output=output)

Calling discriminator_on_generator.predict(batch) works properly, but discriminator_on_generator.train_on_batch(batch, targets) does not.
This was with the Theano backend (I cannot test the Tensorflow backend right now as I'm on a Windows machine).
Any ideas on what could be wrong?

I found some code that used to work on Keras 0.3.3 that is similar to what I'm doing and also does not work on Keras >= 1.0. This code uses Sequential to wrap and connect the different models.
@fchollet: is this expected? Am I missing something?

Not enough information here... what's your model and what's your error message?

generator is your usual stack of LSTMs (without any dropout between them). discriminator is a CNN with batchnorm and leaky ReLUs, like on DCGAN. The code I linked has exactly the same issue on Keras >= 1.0 (but they use CNNs for both the generator and discriminator). The error message for the linked code is the following:
theano.gof.fg.MissingInputError: ("An input of the graph, used to compute Abstra
ctConv2d{border_mode='half', subsample=(2, 2), filter_flip=True, imshp=(None, No
ne, None, None), kshp=(128, 3, 5, 5)}(convolution2d_input_1, HostFromGpu.0), was
 not provided and not given a value.Use the Theano flag exception_verbosity='hig
h',for more information on this error.", convolution2d_input_1)

This is the first convolution from the discriminator, which means that somehow the output of the generator is not interpreted as the input of the discriminator. I had the same error when I converted the model to the functional API (as described above).

I tried a few more things to see what could be going on and tested having different types of layers in the generator and discriminator. I narrowed the problem down to having a convolutional layer as the first layer of the discriminator, which is the second model in the processing chain. Adding a Reshape layer before it does not help and moves the error message to the Reshape node.

I have been working on this for long and wasn't able to find a solution yet. Any clues or directions on what I should investigate, @fchollet? I linked some code above, and the only change you have to make to get it to run (and crash) on Keras 1.0 is to line 23 of dcgan.py (remove dim= from the instantiation of the Reshape layer).
Here is the full traceback:
Traceback (most recent call last):
  File "dcgan.py", line 154, in <module>
    train(path = args.path, BATCH_SIZE = args.batch_size)
  File "dcgan.py", line 118, in train
    g_loss = discriminator_on_generator.train_on_batch(noise, [1] * BATCH_SIZE)
  File "c:\users\santosj\src\keras\keras\models.py", line 493, in train_on_batch
    class_weight=class_weight)
  File "c:\users\santosj\src\keras\keras\engine\training.py", line 1165, in train_on_batch
    self._make_train_function()
  File "c:\users\santosj\src\keras\keras\engine\training.py", line 670, in _make_train_function
    **self._function_kwargs)
  File "c:\users\santosj\src\keras\keras\backend\theano_backend.py", line 518, in function
    return Function(inputs, outputs, updates=updates, **kwargs)
  File "c:\users\santosj\src\keras\keras\backend\theano_backend.py", line 504, in __init__
    **kwargs)
  File "c:\users\santosj\src\theano\theano\compile\function.py", line 322, in function
    output_keys=output_keys)
  File "c:\users\santosj\src\theano\theano\compile\pfunc.py", line 480, in pfunc
    output_keys=output_keys)
  File "c:\users\santosj\src\theano\theano\compile\function_module.py", line 1823, in orig_function
    output_keys=output_keys).create(
  File "c:\users\santosj\src\theano\theano\compile\function_module.py", line 1475, in __init__
    accept_inplace)
  File "c:\users\santosj\src\theano\theano\compile\function_module.py", line 177, in std_fgraph
    update_mapping=update_mapping)
  File "c:\users\santosj\src\theano\theano\gof\fg.py", line 182, in __init__
    self.__import_r__(output, reason="init")
  File "c:\users\santosj\src\theano\theano\gof\fg.py", line 371, in __import_r__
    self.__import__(variable.owner, reason=reason)
  File "c:\users\santosj\src\theano\theano\gof\fg.py", line 413, in __import__
    variable=r)
theano.gof.fg.MissingInputError: An input of the graph, used to compute AbstractConv2d{border_mode='half', subsample=(2, 2), filter_flip=True, imshp=(None, None, None, None), kshp=(128, 3, 5, 5)}(convolution2d_input_1, HostFromGpu.0), was not provided and not given a value.Use the Theano flag exception_verbosity='high',for more information on this error.

Backtrace when the variable is created:
  File "dcgan.py", line 154, in <module>
    train(path = args.path, BATCH_SIZE = args.batch_size)
  File "dcgan.py", line 82, in train
    discriminator = discriminator_model()
  File "dcgan.py", line 43, in discriminator_model
    model.add(Convolution2D(128, 5, 5, subsample=(2, 2), input_shape=(3, 64, 64), border_mode = 'same'))
  File "c:\users\santosj\src\keras\keras\models.py", line 110, in add
    layer.create_input_layer(batch_input_shape, input_dtype)
  File "c:\users\santosj\src\keras\keras\engine\topology.py", line 337, in create_input_layer
    dtype=input_dtype, name=name)
  File "c:\users\santosj\src\keras\keras\engine\topology.py", line 1026, in Input
    name=name, input_dtype=dtype)
  File "c:\users\santosj\src\keras\keras\engine\topology.py", line 952, in __init__
    name=self.name)
  File "c:\users\santosj\src\keras\keras\backend\theano_backend.py", line 42, in placeholder
    x = T.TensorType(dtype, broadcast)(name)

I made a minimal reproducing example and the problem is actually with BatchNormalization. If you comment out line 30, taking the BatchNormalization layer out of model B, then it works properly.

I understand the bug, although I don't have an immediate fix.
In the call method of BatchNormalization, we are defining updates based on the input x. When you reconnect the model to a different input, the inner updates of the BN layer are still referring to the original input, which is no longer available during training.
Unclear how this could be fixed.

Actually I know how to fix it in your case. Just call layer.call(prev_layer.output) after reconnecting the models, where layer is the BN layer instance and prev_layer is the layer right before BN. This will overwrite the updates of the BN layer.

Thanks a lot for your suggestion! I will test this tomorrow.
Now I understand what is happening, but can't think on any fix that's not overly complicated (such as having a method to verify and "reconnect" missing inputs based on the current graph structure).

Apparently Reshape has a similar issue, but the proposed workaround does not work. In the minimal example, Reshape is the first layer of the second model, so I suppose it should be connected to the output of the previous model, but doing modelB.layers[0].call(modelA.layers[-1].output) did not work.

The proposed fix did not work. Funny thing is that when BatchNormalization is added, the error happens at the Reshape layer, not the BatchNormalization layer. I could not figure out why that is the case.

Any further progress on this issue?  I am running into the same problem.

Is there any progress on this?


Advance to "Add a test for sandbox disconnect" commit.

Coverage increased (+0.1%) to 85.783% when pulling dfc91a6fee3e37557be61d154bc9cd00ec81a02b on sandbox-disconnect into fa644ec85dc08b713f1fd047ece0ea24accfb0cb on master.


Simplifying tests and getting them working for us

Description
Hey @markgibbons - we are working on adding support for policyfiles and wanted to get the existing tests working first.  This is a in-progress PR but I wanted to get a discussion started about some potential simplifications we could make.
Most of the issues I had running the test came down to networking. I was able to fix this by setting the hostname on the instance earlier, which forces the name of the self-signed certificate. I also updated the tests to address the instance by the hostname rather than localhost.
The other big change I made was to use synced folders rather than fetching the source from github. This hits one of the TODO items I found to ensure the tests are using the local changes, but we may need to change this depending on the CI setup you would like to use.
TODO

The tests pass, but I don't see any of the go-chef dependencies being downloaded on the machine. They are not in /go so I'm not actually sure how these tests are passing...

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] All commits have been signed-off for the Developer Certificate of Origin.

I'm out of time for now but I will go through this PR tomorrow and point out my reasoning for the changes that @mudash and I made

Ran gofmt on the chefapi_test code, so this PR should be reviewed without whitespace differences

We need to consume the go.mod to get master working, so I am going to merge this PR


sites.Add NOT Working

Hi, I havee been using webmaster API service for adding, verifying and adding sitemap to a site to webmaster tools account in php. However over the past two weeks i have noticed that sites are not going through the webmaster account.
Upon debugging the code i got to know that sites have been properly verified and site map is added however the first step of adding a site to webmaster account i.e. sites.add is not working. Upon further investigation i got to know that the response code that i am receiving on sites.add is 204 which is valid.
Now i am in a dead lock situation.

Have you asked the webmaster api team? They may know of any changes. If not, best thing to do is test whether your query works as expected in the API explorer: https://developers.google.com/apis-explorer/#, and see if there is a difference in the call the client library generates, then we can look for any bugs in the library implementation.


Fix conversion failure function

This PR addresses issues discovered in the failed_fhir_conversion function and the ingestion pipeline orchestration for handling FHIR conversion failures.

Task linked: CU-2wgqgj0 Handle FHIR conversion failures


IGN Daily Fix downloads first playlist video, not the the main video

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2020.03.24
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

$ python3 -m youtube_dl -v http://www.ign.com/videos/2020/04/13/is-a-resident-evil-4-remake-on-the-way-ign-daily-fix
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://www.ign.com/videos/2020/04/13/is-a-resident-evil-4-remake-on-the-way-ign-daily-fix']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.03.24
[debug] Git HEAD: 00eb865b3
[debug] Python version 3.5.3 (CPython) - Linux-4.9.0-12-amd64-x86_64-with-debian-9.12
[debug] exe versions: ffmpeg 3.2.14-1, ffprobe 3.2.14-1
[debug] Proxy map: {}
[ign.com] is-a-resident-evil-4-remake-on-the-way-ign-daily-fix: Downloading webpage
[ign.com] b363015830804eb6b42df8e7a8251675: Downloading JSON metadata
[ign.com] b363015830804eb6b42df8e7a8251675: Downloading m3u8 information
[ign.com] b363015830804eb6b42df8e7a8251675: Downloading f4m manifest
[debug] Default format spec: bestvideo+bestaudio/best
[debug] Invoking downloader on 'https://assets7.ign.com/videos/zencoder/2019/02/25/1920/b363015830804eb6b42df8e7a8251675-3906000-1551138254.m3u8'
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 34
[download] Destination: Tons of Resident Evil Coming to Switch - IGN Daily Fix-b363015830804eb6b42df8e7a8251675.mp4
[download] 100% of 99.86MiB in 00:22
[debug] ffmpeg command line: ffprobe -show_streams 'file:Tons of Resident Evil Coming to Switch - IGN Daily Fix-b363015830804eb6b42df8e7a8251675.mp4'
[ffmpeg] Fixing malformed AAC bitstream in "Tons of Resident Evil Coming to Switch - IGN Daily Fix-b363015830804eb6b42df8e7a8251675.mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i 'file:Tons of Resident Evil Coming to Switch - IGN Daily Fix-b363015830804eb6b42df8e7a8251675.mp4' -c copy -f mp4 -bsf:a aac_adtstoasc 'file:Tons of Resident Evil Coming to Switch - IGN Daily Fix-b363015830804eb6b42df8e7a8251675.temp.mp4'

Description

For IGN Daily Fix videos, the first playlist video is downloaded, instead of the main video.
For example, for this URL: http://www.ign.com/videos/2020/04/13/is-a-resident-evil-4-remake-on-the-way-ign-daily-fix
It incorrectly downloads this playlist video: https://assets7.ign.com/videos/zencoder/2019/02/25/1920/b363015830804eb6b42df8e7a8251675-3906000-1551138254.m3u8
Instead of this main video: http://assets14.ign.com/videos/zencoder/2020/04/13/1920/aad8ad325d3608ff722291acddc7b230-3906000-1586818781.mp4

Yes, I got the same problem :(

This issue still exists. I don't know what Daily Fix is, but it also occurs with like any of their videos as far as I can tell.
https://www.ign.com/videos/2005/04/19/nintendogs-chihuahua-friends-ds-japanese-trailer


Module stops working after a while.

Hello.
I installed the module today and it’s pretty amazing.
Although I have an issue. The module starts and works perfectly, but after some time does not displaying photos at all.
Here is the error code I get when issuing the pm2 log mm command
0|mm       | [2020-04-28 16:57:37.882] [ERROR]  (node:7279) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. 0|mm       | [2020-04-28 16:59:05.210] [ERROR]  (node:7560) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. 0|mm       | [2020-04-28 18:18:27.667] [ERROR]  (node:9637) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. 0|mm       | [2020-04-28 18:19:02.709] [ERROR]  (node:9917) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. 0|mm       | [2020-04-28 19:02:23.091] [ERROR]  (node:11312) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. 0|mm       | [2020-04-28 19:02:44.920] [ERROR]  (node:11312) UnhandledPromiseRejectionWarning: Error: Request failed with status code 503 0|mm       |     at createError (/home/pi/MagicMirror/modules/MMM-GooglePhotos/node_modules/axios/lib/core/createError.js:16:15) 0|mm       |     at settle (/home/pi/MagicMirror/modules/MMM-GooglePhotos/node_modules/axios/lib/core/settle.js:17:12) 0|mm       |     at IncomingMessage.handleStreamEnd (/home/pi/MagicMirror/modules/MMM-GooglePhotos/node_modules/axios/lib/adapters/http.js:236:11) 0|mm       |     at IncomingMessage.emit (events.js:187:15) 0|mm       |     at endReadableNT (_stream_readable.js:1090:12) 0|mm       |     at process._tickCallback (internal/process/next_tick.js:63:19) 0|mm       | [2020-04-28 19:02:44.928] [ERROR]  (node:11312) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2) 0|mm       | [2020-04-28 19:02:44.929] [ERROR]  (node:11312) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Any suggestions?
Thanks

Already Created. Removed


Infer tensor shapes automatically from game's Observer.

I don't think this is an improvement - it makes KuhnPoker less comprehensible; this is an important entry point for new users and it should be as easy as possible to understand.
Another (fixable) issue is that it moves a class into the external API without adequate documentation.

Will it be OK if I revert Kuhn changes and add documentation?

Actually, I don't see why TrackingVectorAllocator has to move into the
public API at all.
On Wed, 16 Sep 2020 at 09:27, michalsustr<EMAIL_ADDRESS>wrote:

Will it be OK if I revert Kuhn changes and add documentation?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/deepmind/open_spiel/pull/346#issuecomment-693256479,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHAF7TEOMFRLCA5QJMXHS4TSGBZHDANCNFSM4RAKXHXQ
.

Not in here, true.

I will do it in a different PR: #358


mne.viz.plot_trans failed

Hi mne-python experts
I have an issue running:
plot_trans(epochs.info, trans=None, subject=freesurf_subject, dig=True,            meg_sensors=True, subjects_dir=subjects_dir, brain=True)
it gives me this error:
/Applications/anaconda/lib/python2.7/site-packages/mne-python/mne/viz/3d.pyc in fiducial_coords(points, coord_frame)
52     points = dict((p['ident'], p) for p in points if
53                    p['kind'] == FIFF.FIFFV_POINT_CARDINAL)
---> 54     return np.array([points[i]['r'] for i in FIDUCIAL_ORDER])
55
56
KeyError: 1
I am running on macOS X El capitan and with mne.0.15dev.
The error seems to be not present on mne.0.13stable.
Thank you
Romain

We should add a check for this.
But you have strange data -- you have digitization points but no fiducials?

I have 3 digitization points corresponding to the fiducials in surface_MRI coordinate system.

Ahh yes, this problem again :) Okay we can make plot_trans work in the short term and make it actually plot those properly in the long term.

Yes :)
Ok. Thank you!

Can you try #4069 to see if it fixes your problem?

It fixed it! Thank you!

Should be fixed in master now