Convert padding to lower case, so same and SAME are equivalent

Fixes #18535.
In Conv operations, we check for valid and same, but user can sometimes provide "SAME" or "VALID".  This works for some operations but not all.  So translate all usages of padding to lower case.  Added unit tests.

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (c8a5a89) 77.76% compared to head (525153a) 57.27%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18553       +/-   ##
===========================================
- Coverage   77.76%   57.27%   -20.50%
===========================================
  Files         334      334
  Lines       32372    32378        +6
  Branches     6313     6313
===========================================
- Hits        25175    18544     -6631
- Misses       5620    12414     +6794
+ Partials     1577     1420      -157

Flag
Coverage Δ

keras
57.27% <100.00%> (-20.40%)
:arrow_down:

keras-jax
?

keras-numpy
57.27% <100.00%> (+<0.01%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

keras/ops/nn.py
89.83% <100.00%> (+0.14%)
:arrow_up:

... and 181 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chat system messages for rentetion policy changes

posts a new Changerentention SYSTEM message to the conversation/channel/#general when a retention policy is changed. cli renders these messages, UI to follow
in action:
impconv:
$ kb chat retention-policy test13 --explode 1d
Found PRIVATE CHAT conversation: test1,test13
Set the conversation retention policy?
Hit Enter to confirm, or Ctrl-C to cancel.
Found PRIVATE CHAT conversation: test1,test13
Messages will explode after 1 day by default
$ kb chat read test13
Found PRIVATE CHAT conversation: test1,test13
[1]  [test1 6s]   [test1 changed the conversation retention policy. Messages will explode after 1 day by default]

$ kb chat retention-policy test13 --keep
Found PRIVATE CHAT conversation: test1,test13
Set the conversation retention policy?
Hit Enter to confirm, or Ctrl-C to cancel.
Found PRIVATE CHAT conversation: test1,test13
Messages will be retained indefinitely
$ kb chat read test13
Found PRIVATE CHAT conversation: test1,test13
[1]  [test1 38s]   [test1 changed the conversation retention policy. Messages will explode after 1 day by default]
[2]   [test1 6s]   [test1 changed the conversation retention policy. Messages will be retained indefinitely]

$ kb chat retention-policy test13 --expire 1w
Found PRIVATE CHAT conversation: test1,test13
Set the conversation retention policy?
Hit Enter to confirm, or Ctrl-C to cancel.
Found PRIVATE CHAT conversation: test1,test13
Messages will expire after 7 days
$ kb chat read test13
Found PRIVATE CHAT conversation: test1,test13
[1]  [test1 54s]   [test1 changed the conversation retention policy. Messages will explode after 1 day by default]
[2]  [test1 22s]   [test1 changed the conversation retention policy. Messages will be retained indefinitely]
[3]   [test1 7s]   [test1 changed the conversation retention policy. Messages will expire after 7 days]

team:
$ kb chat retention-policy new --explode 5m
Set the team-wide retention policy?
Hit Enter to confirm, or Ctrl-C to cancel.
Team policy: Messages will explode after 5 minutes by default
#general channel: Uses the team policy
$ kb chat read new
[1]  [test1 2m]   [test1 changed the team retention policy. Messages will explode after 5 minutes by default]

$ kb chat retention-policy new --channel new-chan --inherit
Set the channel retention policy?
Hit Enter to confirm, or Ctrl-C to cancel.
Team policy: Messages will explode after 5 minutes by default
#new-chan channel: Uses the team policy
$ kb chat read new --channel new-chan
[1]  [test1 11s]   [test1 changed the channel retention policy to inherit from the team policy. Messages will explode after 5 minutes by default]

$ kb chat retention-policy new --channel new-chan --expire 1m
Set the channel retention policy?
Hit Enter to confirm, or Ctrl-C to cancel.
Team policy: Messages will explode after 5 minutes by default
#new-chan channel: Messages will expire after 30 days
$ kb chat read new --channel new-chan
[1]  [test1 2m]   [test1 changed the channel retention policy to inherit from the team policy. Messages will explode after 5 minutes by default]
[2]  [test1 2m]   [test1 changed the channel retention policy. Messages will expire after 30 days]

kbfs server failed to build, merging


Optimized implementation using topological sort

The "old" implementation was not really optimized, leading to poor performance on "big" activity graphs (200+ nodes, 10.000+ edges). This implementation does a topological sort first, and then does linear iterations over the nodes.
With my local test use-case, runtimes dropped from roughly 15m to 0.1s.
Fixes #43

Looks good!
Would you agree that this also makes #11 somewhat redundant since performance is not an issue anymore?

Looks good!
@NiklasHansen would you agree that this also makes #11 somewhat redundant since performance is not an issue anymore?

For performance reasons, then yes, I would regard that issue as redundant. And we do not have any I/O or similar, that would benefit from async/await either.


KAFKA-14491: [21/N] Docs updates for versioned state stores

This PR adds docs for the versioned stores introduced in KIP-889. While adding a warning about not changing segment interval between application restarts, I also added the analogous warning to window stores as well.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

We should also add a note to the top level upgrade guide (ie, docs/upgrade.html`); KIP-889 is a major feature that should be mentioned.

Sorry for the delay in responding -- just updated the PR with your latest suggestion.


Don't clobber deserialized types

This is https://github.com/dotnet/razor-tooling/pull/6034 but without the more controversial bits.. this is just a good idea :)

This, but with the 🚫over it. (Use your imagination, I'm lazy)


Link in  Step 2: Configure two Scale-Out File Server Failover Clusters out of date.

[Enter feedback here]
In Step 2: Configure two Scale-Out File Server Failover Clusters , substep # 5, you say:  Create the clustered Scale-Out File Servers on both clusters using the instructions in Configure Scale-Out File Server, with the Configure Scale-Out File Server a link.  It links to this page: https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2012-R2-and-2012/hh831718(v=ws.11)?redirectedfrom=MSDN
This page is on Windows Server 2012.  Can you replace this link with a newer source for those attempting to follow this guide?
Thanks!
Dave Franklyn

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: be40bc07-3cb8-0326-d791-847d0bd08d1d
Version Independent ID: 87422f25-ac75-40c4-a09e-df6bfcff6ce1
Content: Cluster to cluster Storage Replication
Content Source: WindowsServerDocs/storage/storage-replica/cluster-to-cluster-storage-replication.md
Product: windows-server
Technology: storage-replica
GitHub Login: @nedpyle
Microsoft Alias: nedpyle

Just to verify that I am seeing the same as you; is this sub-step 6 under step 2, looking like this?

Add one disk in the Redmond site to the cluster CSV. To do so, right click a source disk in the Disks node of the Storage section, and then click Add to Cluster Shared Volumes.

Create the clustered Scale-Out File Servers on both clusters using the instructions in Configure Scale-Out File Server (https://technet.microsoft.com/library/hh831718.aspx)

By the way, I did try to find pages containing the phrase "Scale-Out File Server Failover Clusters", but the hits I got seem to be mostly referencing Windows Server 2012 R2 & 2012.
https://www.bing.com/search?q=Scale-Out+File+Server+Failover+Clusters+site%3Amicrosoft.com
I also found https://docs.microsoft.com/windows-server/failover-clustering/failover-clustering-overview , which applies to Windows Server 2019, Windows Server 2016, but it seems to lead to the same page as the one you referred above:

https://docs.microsoft.com/previous-versions/windows/it-pro/windows-server-2012-r2-and-2012/hh831718(v=ws.11)

On the other hand, maybe I lost track because I don't know this content well enough. Would you be able to suggest any existing page(s) which would be a reasonably useful replacement for that old page, maybe one of the links or TOC entries from this page?

https://docs.microsoft.com/windows-server/failover-clustering/create-failover-cluster

Disclaimer: I am not affiliated with Microsoft or the Microsoft Docs teams here on GitHub. The intention of this repository is to improve on the existing documentation by providing the users a way to report factual errors, improvement suggestions and request updates for new versions. The MS Docs team members might not have time to answer your question, both due to the small size of the team and the big workload.
If you are able to suggest one or more links worth using instead of the old page, that would be more practical than waiting for a reply from the MS Docs team members, because then we should be able to use the productive approach of creating a Pull Request to have this page updated as you requested. This procedure should take a lot less time than waiting for a follow-up from the MS Docs team.

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Update woodstox-core to 7.0.0

About this PR
📦 Updates com.fasterxml.woodstox:woodstox-core from 6.7.0 to 7.0.0 ⚠
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.fasterxml.woodstox", artifactId = "woodstox-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.fasterxml.woodstox", artifactId = "woodstox-core" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

+1
Diff with previous version: https://github.com/FasterXML/woodstox/compare/woodstox-core-6.7.0...woodstox-core-7.0.0
Release Notes: https://github.com/FasterXML/woodstox/blob/master/release-notes/VERSION

[X] Do all automated continuous integration checks pass?
Yes
[X] Is the update a patch, minor, or major update?
Major update, moves to Java 8 and updates WstxInputLocation's setLocation and WstxSAXParser error handling. Remove QNameCreator helper class.
[X] Is the license still compatible with ASF License Policy?
Yes, ALv2
[X] Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
Not applicable, we do not distribute
[X] Have any transitive dependencies been added or changed?
Not applicable, we do not distribute

Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
Not applicable, we do not distribute
Have any transitive dependencies been added or changed?
Not applicable, we do not distribute

Woodstox-core is distributed in the binary helper with the CLI, so this is applicable if there are any changes to the LICENSE/NOTICE or are transitive dependencies

Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
Not applicable, we do not distribute
Have any transitive dependencies been added or changed?
Not applicable, we do not distribute

Woodstox-core is distributed in the binary helper with the CLI, so this is applicable if there are any changes to the LICENSE/NOTICE or are transitive dependencies

Ah will update comment


Implement safe navigation/null-coalescing operator

Code like this:
my bossName;
if employee != None {
    if employee.boss != None {
        bossName = employee.boss.name;
    }
    else {
        bossName = None;
    }
}
else {
    bossName = None;
}

Could profitably be rewritten by using a ?. safe navigation operator:
my bossName = employee?.boss?.name;

I decided not to refer to this as "the Elvis operator", since Wikipedia seems to be of the opinion that that's the name of another operator, usually spelled ?: but with the same semantics as 007 (and Perl 6) infix:<//>.

The TC39 proposal makes a good point I hadn't considered: the operator is short-cricuiting such that any side effects happening on the rhs of a ?. with a none lhs won't run. We want to do it that way too, I'm sure.


fix error message for ocis accounts list if the runtime is not running

Is your feature request related to a problem? Please describe.
When you run ocis accounts list and the runtime has not been started, you get a wired error message which should be fixed. This is the current output:
ocis accounts list
could not list accounts {"id":"go.micro.client","code":500,"detail":"service com.owncloud.api.accounts: not found","status":"Internal Server Error"}

Describe the solution you'd like
We have already fixed error messages in other commands related to the runtime and the text could be reused, see: https://github.com/owncloud/ocis/pull/3481 (improve runtime connect error messages)
Fixing is an easy win.
Describe alternatives you've considered
No alternative to a well reading text...
@micbar @butonic @wkloucek
@EParzefall  fyi

accounts service will be deleted.


Exit status 126 error when running hook bash script

[ ] Make sure you've installed the latest version using instructions in the wiki

Output from azd version
Run azd version and copy and paste the output here:
azd version 0.7.0-beta.1 (commit 9ce71659f7688d0dc3dda8b84e5accedca58cf01)
Describe the bug
When I run a simple bash script in predeploy (or any other hook) I get exit status 126 error code.
To Reproduce
This is my azure.yaml file:
name: my-app
services:
  api:
    project: src/api
    dist: build
    language: csharp
    host: containerapp
    module: app/api
    docker:
      path: ./Dockerfile
      context: ../
    hooks:
      predeploy:
        run: ../../infra/scripts/my-script.sh
        continueOnError: false
        interactive: false

and this is the content of  [root]/infra/scripts/my-script.sh file:
#!/bin/sh
echo "Running Script..."

And when I run
azd deploy --service api --debug

I see the following error:
Executing predeploy hook => ../../infra/scripts/my-script.sh
2023/03/28 09:16:53 hooks_runner.go:145: Executing script '../../infra/scripts/my-script.sh'
2023/03/28 09:16:53 command_runner.go:88: Run exec: ' ../../infra/scripts/my-script.sh'
  (✓) Done: Deploying service api

ERROR: deploying service: failed invoking event handlers for 'predeploy', 'predeploy' hook failed with exit code: '126', Path: '../../infra/scripts/my-script.sh'. : exit status 126

Thank you so much, it worked.
name: my-app
services:
  api:
    project: src/api
    dist: build
    language: csharp
    host: containerapp
    module: app/api
    docker:
      path: ./Dockerfile
      context: ../
    hooks:
      predeploy:
        shell: sh
        run: chmod +x ../../infra/scripts/my-script.sh       <--------------
        continueOnError: false
        interactive: false

To change the permissions of all .sh files in a directory on macOS, you can use the chmod command in the terminal.
Open Terminal & navigate to the directory:
cd /path/to/your/directory
Change permissions: Use the following command to change the permissions of all .sh files in the directory:
chmod +x *.sh


Add code coverage reporting

Current coverage is 91.82% (diff: 100%)

No coverage report found for master at 191acbb.

Powered by Codecov. Last update 191acbb...4f4a184


[CU-8688g6zx3] Fixes image blur in model and bounty carousel

Task linked: CU-8688g6zx3 Bounties carousel breaks when images are blurred


Updating commands not running tasks

$signature variable from update commands not being correctly compared

Solved in this commit https://github.com/anibalealvarezs/projectbuilder-package/commit/acfd8d13729d87147211cb7b8f5236b97af19e5a


ili9486L SPI screen will not initialize

Hello,
I recently bought this screen from Aliexpress: https://www.aliexpress.com/item/3-5-inch-8P-SPI-TFT-LCD-Color-Screen-Module-ILI9486-Drive-IC-320-480-RGB/32828284227.html
I wired it up to my Pi Zero W as follows (Raspberry Pi Pins, not GPIO): GND >20 VCC>17 CLK>23 MOS>21 RES>22 DC>18 BLK>12 MIS>21
I cmake-ed fbcp-ili9341 with the following options: -DPI-ZERO=ON -DWAVESHARE35B_ILI9486=ON -DUSE_DMA_TRANSFERS=OFF -DSPI_BUS_CLOCK_DIVISOR=14 -DGPIO_TFT_RESET_PIN=25 -DGPIO_TFT_DATA_CONTROL=24
Using make-j after cmake-ing it with DILI9486=ON gave me a myriad of errors so I used the waveshare display flag instead.
When running sudo ./fbcp-ili9431, it seems to go through some initialization setup, and then stops giving further info, but the entire time the Pi has been plugged in, the screen has done nothing but shown a flat white display. It does not flicker when running ./fbcp-ili9431. I have made sure that the spi dtoverlay is commented out on my config.txt, and my core_freq is 400.

Using make-j after cmake-ing it with DILI9486=ON gave me a myriad of errors so I used the waveshare display flag instead.

Thanks for reporting. Fixed in above commit so that
cmake -DILI9486=ON -DUSE_DMA_TRANSFERS=OFF -DSPI_BUS_CLOCK_DIVISOR=14 -DGPIO_TFT_RESET_PIN=25 -DGPIO_TFT_DATA_CONTROL=24 ..

should now also build.

I wired it up to my Pi Zero W as follows (Raspberry Pi Pins, not GPIO): GND >20 VCC>17 CLK>23 MOS>21 RES>22 DC>18 BLK>12 MIS>21

Both MOS>21 and MIS>21? Probably a typo? MIS should be good to go to Pi pin 21, MOS should go to pin 19.

VCC>17

Double-checking: Pin 17 is a 3.3V pin. Do you know if the display operates on 3.3 volts power and not on 5 volts? (don't plug it in 5 volts to just to try, if it's 3.3V it can burn if connected wrongly to 5V) Many of my displays plug in to 5 volts for power, although those are Adafruit ones so they often go interchangeably with either of 3.3V or 5V.
ILI9486L and ILI9486 should to my understanding work interchangeably. Their controllers should be the same, except that ILI9486L strips out unneeded support for MIPI DSI that is not used with SPI. So the rest of your setup looks good.

Paired my WaveShare 3.5" (B) ILI9486 display to a Pi Zero W, a combination that I have not tried before; and found a race condition that caused the display to randomly fail to initialize when DMA was enabled. That is now fixed in above commit, try git pulling to latest for the fix. Not sure if that might help when DMA is disabled, fingers crossed.

Okay, I did it again, this time with pictures. Firstly here's the wiring:
https://puu.sh/ADWWv/021ce8c3cc.JPG
https://puu.sh/ADWX0/5b70f34f32.JPG
https://puu.sh/ADWXq/2ae22a19e6.JPG
After making it with cmake settings -DPI_ZERO=ON -DILI9486=ON, DSPI_BUS_CLOCK_DIVISOR=14 -DGPIO_TFT_DATA_CONTROL=24 -DGPIO_TFT_RESET_PIN=25 -DUSE_DMA_TRANSFERS_OFF .. I then ran it, and here is a picture (apologies, I didn't do this in SSH and don't have a capture card) of what it showed me. However, the screen stayed white the entire time.
https://puu.sh/ADWQz/fb34f4ff23.JPG
You were correct, I did make a typo in the initial post.

Not quite sure, everything looks good to me. Tested out on my WaveShare 3.5" (B) display and Pi Zero W, with
cmake -DPI_ZERO=ON -DILI9486=ON -DSPI_BUS_CLOCK_DIVISOR=14 -DGPIO_TFT_DATA_CONTROL=24 -DGPIO_TFT_RESET_PIN=25 -DUSE_DMA_TRANSFERS=OFF ..

the build does work out ok.
One thing that does come to mind is that ILI9486 is a peculiar display controller since its SPI communication bus word size is 16 bits wide instead of the usual 8 bits I see on every other controller. ILI9486 is also the only controller I have met that has MIPI DSI support.
Since ILI9486L removes the MIPI DSI support that ILI9486 has, then perhaps ILI9486L also reverts to a 8 bits word size instead of the 16 bits on ILI9486. That is a random guess though, I cannot find a mention in the ILI9486L vs ILI9486 spec sheets to say anything about this. In any case, you can try git pulling to latest to get the above commit, and then apply the following change locally to your checkout:
diff --git a/ili9486.h b/ili9486.h
index 2471e4c..8b77bd9 100644
--- a/ili9486.h
+++ b/ili9486.h
@@ -21,7 +21,7 @@
 #endif

 // On ILI9486 the display bus commands and data are 16 bits rather than the usual 8 bits that most other controllers have.
-#define DISPLAY_SPI_BUS_IS_16BITS_WIDE
+// #define DISPLAY_SPI_BUS_IS_16BITS_WIDE

 // ILI9486 does not behave well if one sends partial commands, but must finish each command or the command does not apply
 #define MUST_SEND_FULL_CURSOR_WINDOW

i.e. comment out #define DISPLAY_SPI_BUS_IS_16BITS_WIDE to make fbcp-ili9341 drive the display with 8 bits wide word size.
If that does not help, then I'm not sure, there must then be something fundamentally different with ILI9486L and ILI9486 assuming everything else checks out properly.

This has produced some sort of progress!
First here is the pictures (again, sorry) of the CMake and Make results
https://puu.sh/AE19Y/752a31d9ec.JPG
https://puu.sh/AE1bn/b650e48d81.JPG
When starting the ./fbcp-ili9341, the screen goes from flat white to what appears to be every other line being black. Here are two pictures of the full white, then the white/black stripes. Apologies for blurriness and screen door effect. My phone was really struggling to get this close up.
https://puu.sh/AE1f2/ab3c01befd.JPG
https://puu.sh/AE1fw/61776dc62f.JPG
This is identical to the behavior I was getting when attempting to use fbtft_device's custom ili9486 device profile.

That is indeed promising, and I think it confirms that the display is 8 bits in word size instead of 16 bits that ILI9486 is. So the differences are more than just stripped down MIPI DSI support.
My WaveShare 3.5" (B) display does the same - its "reset state" is the kind of alternating "every other scanline = white, every other scanline = black" striped pattern. That occurs after this line has finished: https://github.com/juj/fbcp-ili9341/blob/master/ili9486.cpp#L126
This suggests that the initialization commands do reach the display, but that ILI9486ClearScreen() function does not go correctly through at https://github.com/juj/fbcp-ili9341/blob/master/ili9486.cpp#L128. It might be that it is taking in commands, but is not accepting pixel data.
Had a read through the ILI9486 and ILI9486L spec sheets side by side, and added explicitly in the initialization different commands in the spec sheets that might have an effect. If the above changes do not help, then I am at a loss, and I think the only way might then be to reverse engineer a working driver if such exists, or try random changes to the initialization routines reading against the ILI9486L spec sheet to see if anything there can bring reaction to the display. Either way may be a bit of a challenge, sorry I am not able to be of better help here.

Sorry for lack of clarity on my part. You mention you "added explicitly in the initialization different commands in the spec sheets that might have an effect," does that mean you updated the Git and I should try a new pull and make, etc and see if it works for my display?

Yeah sorry, what I meant is that I pushed a new commit in https://github.com/juj/fbcp-ili9341/commit/ada111e3ed0e69144d483efcc5f1df091a6a7197 that you can git pull to try out, if that might make any difference.
If that does not help, then it is possible that the issue is in some other difference in required initialization, and you can try following the similar kind of approach in that commit to modify the initialization sequence, to try to see if you can make the display react to something. The spec sheet I was reading is this ILI9486L V0.06.pdf.

Something that is also worth occassionally trying out when doing multiple changes, is to physically power off the Pi and the display after a failed attempt. I do find that sometimes when I run a command sequence to a display that it does not understand, it gets out of sync or somehow else in an odd state, and I need to hard power it off to reset it.

After downloading the new commit, I ran the script and got some extremely strange behavior.
https://youtu.be/OKulcCcZt0g
The screen started white then slowly dimmed until it was a dark grey smear, with the bottommost (pin side) section being lighter, before it too fades leaving the bottommost two pixels in full brightness. The greyness seems to have vertical striations as well, though that could just be my screen protector. The process repeats if I run the script again.

Interestingly, if I power cycle the screen(by pulling ground) while the script is running, it stays as it was when last powered on. E.G. if I power cycle it midway through fading, it comes back in the same part of fading and continues to fade. If I stop the script, the screen maintains its state, unless I power cycle it, in which case it goes back to being fully white.

That is interesting. I believe what is happening here is that the display stopped refreshing its pixels across full height ,so they fade out slowly after time. (LCD pixels need constant refreshing)
This is definitely not the desired result, but it does confirm that the display did react to the commands that were specified to it. Most likely the command that caused the artifact on video is this line: https://github.com/juj/fbcp-ili9341/commit/ada111e3ed0e69144d483efcc5f1df091a6a7197#diff-497750249aed12e322610c93513785b6R126 which attempts to initialize the display to its normal height of 480 pixels. You can try commenting out that line (or any other line that was added) one by one (then remake and rerun) to find which caused this effect.
To try to find a suitable initialization sequence for the display, you could see if something in http://aitendo3.sakura.ne.jp/aitendo_data/product_img/lcd/tft2/Z350IT002/ILI9486AN_V0.6.pdf could be adaptable. In there, a sequence
LCD_ILI9486_CMD(0xC5);
LCD_ILI9486_INDEX(0x00);
LCD_ILI9486_INDEX(0x55);

translates to a sequence
SPI_TRANSFER(0xC5, 0x00, 0x55);

in fbcp-ili9341 initialization. That application notes pdf is not for ILI9486L but it is for ILI9486, although for some reason it lists multiple variants, and some of the commands are undocumented in the ILI9486 spec sheet pdf file above, so perhaps with some luck something there might give good results.
Although this can be quite a trial and error attempt, so patience and free time is good to prepare with if you want to go that route.

Also for reference, here are the contents of my full /boot/config.txt that I am running with on Pi Zero W + WaveShare 3.5" (B):
hdmi_group=2
hdmi_mode=87
hdmi_cvt=480 320 60 1 0 0 0
hdmi_force_hotplug=1

i.e. there are no other lines. I SSH in to the Pi via network to configure and build fbcp-ili9341. May be good to double check that your /boot/config.txt does not have any extra directives with dtoverlay= or dtparam= that might be leftovers.
(Although usually I do recall if I did have some bad /boot/config.txt options, I would still always be able to clear the screen to black before the conflicting dtparam/dtoverlay directives would have time to interfere with fbcp-ili9341, so not sure if /boot/config.txt directives can be at fault here)

I did get some information from the seller before I ordered the display, including what appears to be some initialization code. Can you tell me if this matches up to what you have for initialization on this display already?
`void Initial_ILI9486()
{
//************ Reset LCD Driver****************//
RES=1;
Delayms(20);
RES=0;
Delayms(60);
RES=1;
Delayms(120);
//************* Start Initial Sequence**********//
comm_out(0XF2);
data_out(0x18);
data_out(0xA3);
data_out(0x12);
data_out(0x02);
data_out(0XB2);
data_out(0x12);
data_out(0xFF);
data_out(0x10);
data_out(0x00);
comm_out(0XF8);
data_out(0x21);
data_out(0x04);
comm_out(0XF9);
data_out(0x00);
data_out(0x08);
comm_out(0x36);
data_out(0x08);
comm_out(0x3A);
data_out(0x05);
comm_out(0xB4);
data_out(0x01);//0x00
comm_out(0xB6);
data_out(0x02);
data_out(0x22);
comm_out(0xC1);
data_out(0x41);
comm_out(0xC5);
data_out(0x00);
data_out(0x07);//0X18
comm_out(0xE0);
data_out(0x0F);
data_out(0x1F);
data_out(0x1C);
data_out(0x0C);
data_out(0x0F);
data_out(0x08);
data_out(0x48);
data_out(0x98);
data_out(0x37);
data_out(0x0A);
data_out(0x13);
data_out(0x04);
data_out(0x11);
data_out(0x0D);
data_out(0x00);
comm_out(0xE1);
data_out(0x0F);
data_out(0x32);
data_out(0x2E);
data_out(0x0B);
data_out(0x0D);
data_out(0x05);
data_out(0x47);
data_out(0x75);
data_out(0x37);
data_out(0x06);
data_out(0x10);
data_out(0x03);
data_out(0x24);
data_out(0x20);
data_out(0x00);
comm_out(0x11);
Delayms(120);
comm_out(0x29);
}`

However it seems that all information the seller sent me is for the ili9486, not the ili9486L, so I'm unsure if it is helpful.

I just noticed a mistake on my part. When I made the file that I used for the video of the weird behavior, I neglected to comment out the bus width in ili9486.h locally again. When I do comment it out and make again, I return to the previous initialization mode of alternating black and white rows on the screen. When the script is ctrl+c'd, the screen returns to full white, and comes back to alternating lines when run again.
I apologize if I sent you down any rabbit holes.

That set of initialization strings would be encoded as
    SPI_TRANSFER(0XF2, 0x18, 0xA3, 0x12, 0x02, 0XB2, 0x12, 0xFF, 0x10, 0x00);
    SPI_TRANSFER(0XF8, 0x21, 0x04);
    SPI_TRANSFER(0XF9, 0x00, 0x08);
    SPI_TRANSFER(0x36, 0x08);
    SPI_TRANSFER(0x3A, 0x05);
    SPI_TRANSFER(0xB4, 0x01//0x00);
    SPI_TRANSFER(0xB6, 0x02, 0x22);
    SPI_TRANSFER(0xC1, 0x41);
    SPI_TRANSFER(0xC5, 0x00, 0x07//0X18);
    SPI_TRANSFER(0xE0, 0x0F, 0x1F, 0x1C, 0x0C, 0x0F, 0x08, 0x48, 0x98, 0x37, 0x0A, 0x13, 0x04, 0x11, 0x0D, 0x00);
    SPI_TRANSFER(0xE1, 0x0F, 0x32, 0x2E, 0x0B, 0x0D, 0x05, 0x47, 0x75, 0x37, 0x06, 0x10, 0x03, 0x24, 0x20, 0x00);
    SPI_TRANSFER(0x11);
    usleep(120*1000);
    SPI_TRANSFER(0x29);

in fbcp-ili9341.

Applying the above set of initialization would look something like https://gist.github.com/juj/a16603dc6cf6aacceac95de2b3f35a81 . You can try that file instead to see how it behaves.

Okay, to use that file do I need to do anything special, or just another regular pull request?

Copy paste the file (or just its contents) to replace the original ili9346.cpp in your working directory. I did not want to push that directly to the repository to not fill up the tree with temporary debugging attempts code.
If you are on a Pi Zero itself without a text editor, you can do
wget https://gist.githubusercontent.com/juj/a16603dc6cf6aacceac95de2b3f35a81/raw/19a7f25902e63fe77098449ffa89ec8265daf594/ili9486.cpp

directly on the Pi terminal to download the file to local disk.

Thank you for preparing the file for me. I dropped it in, re cmade and re make'd, and the behavior is still the white + black lines initialization behavior. I'm not sure where else to go at this point besides trying the trial+error method to reverse engineer it like you described.
Thank you for all the help you've given me. I will update this if and when I find something.

After having done some experimentation, I cannot seem to find any rhyme or reason to how the display behaves. If you like, I can mail you the display to have (I have no use for it if it doesn't work) and that way you can figure out how to get a 9486L working on your own time.

Sorry to hear. :/ Some searching on the web about the display about ILI98486L specifically does not find much, ended up with these:

KeDei 3.5 inch 480x320 TFT lcd from ali
ILI9486L 3.5" Display with fbtft
Great Cow BASIC documentation - GLCD Overview - ILI9486L Controllers
RedlandRedneck/pic32_ILI9486L/pic32_ILI9486/ILI9486L.c

Curiously the last link has a comment "HIMAX HX8347 LCD controllers driver", perhaps a leftover, or used interchangeably? Another page at https://www.raspberrypi.org/forums/viewtopic.php?t=57548#p440798 has a reference to batches of a display coming with "ILI9486L and HX8357", which might mean there's some level of compatibility.
You could try seeing what happens if the display is driven with fbcp-ili9341s HX8357D path, with
cmake -DHX8357D=ON -DUSE_DMA_TRANSFERS=OFF -DSPI_BUS_CLOCK_DIVISOR=14 -DGPIO_TFT_RESET_PIN=25 -DGPIO_TFT_DATA_CONTROL=24 ..

It is a very kind offer to send the display over to me, though it might not be worth the exercise if you are located outside Europe. I reside in Helsinki in Finland, and e.g. a Priority Mail International® Small Flat Rate Box via USPS seems to be $32.25 if you are located in the US. If the value of the display is around $20, it is just around the magic limit that Finnish customs may ask me to declare it upon receival for VAT and import taxes. If you are in Europe, then it will be simpler. You can reach me at
 if you'd like to coordinate further.

Hello! Just chiming in to say I've been having this same problem (although not on the RasPi but on an stm32f4, and on my own written library), and just managed to figure it out.
Basically the problem is the ILI9486L only supports 18bits/pixel or RGB666 (or RGB111, but importantly not RGB565 or RGB888) mode over 4 wire SPI, so for me, at initialization CMD:0x31 DAT:0x55 has to be changed to 0x66, and when sending the pixels you have to send 3 bytes with the R, G and B components in the 6 most significant bits of each byte (see: https://www.displayfuture.com/Display/datasheet/controller/ILI9486L.pdf pg48)
After that it should work, hope this helps you guys :)

Thanks @IndianBoy42 ! Pretty amazing timing, I just got an ILI9486L display in mail to play with myself. Confirmed that R5G6B5 mode is what caused the display not to react, and in R6G6B6 mode it works. You saved me a lot of time! Added support for ILI9486L now, enabled by passing -DILI9486L=ON in CMake, see details in https://github.com/juj/fbcp-ili9341/commit/378d111d00a5996f7039630f5c607d3cdada34e0.

Tested on my ili9486L display (same model as Juj’s) and it works a treat. Performance is marginally better than the Waveshare 35b. Running cmatrix in the terminal yields about 8-13fps with a frame rate target of 20 and single rectangular diff and 180 degree flip enabled. Cmatrix in a lxtermjnal window in i3 yields about 13-19fps, an excellent improvement.

The screen flip seems to yield a ~1-2% cpu increase but that’s within reason.
I have to say this little display is excellent. I don’t think it’s IPS, but the viewing angles are superb compared to my UCTRONICS 3.5” display.

Haha, cmatrix looks pretty cool, had not seen that project before :)
Running cmatrix from command line (not inside X windowing system) on a Pi 3B gives fbcp-ili9341 CPU usage that fluctuates between 15.3% and 27.9%, and frame rate of 24p-27p with no frames lost. cmatrix itself consumes about 4.6% of CPU. Pi Zero definitely has a harder time with this since it's limited to a single core approach,  but the numbers you posted don't look at all bad there either.

Indeed, I was impressed with the zero. I specifically chose cmatrix because I knew it would generate large single rectangles of movement. I didn't try it with full diffing.

IndianBoy42 you saved me, thank you. I don't even know if I have an L model controller or not but it is now working because of reading your comment better than I read the datasheet! Of interest is that b6h command should have three  parameters not two as in most init examples I see. If I use b6,08,82,27 I get a 2/3 partial screen which fades from dark to light. If I skip b6h it works great.

Hi,
I've got a 3.5" Waveshare Spotpear (A) V3
I've tried to enable it using
-DILI9486L=ON
but no success
my cmake is
cmake -DSPI_BUS_CLOCK_DIVISOR=12 -DILI9486L=ON -DARMV8A=ON -DGPIO_TFT_DATA_CONTROL=24 -DGPIO_TFT_RESET_PIN=25 -DSTATISTICS=0 -DDISPLAY_ROTATE_180_DEGREES=ON ..
Pi3A+
any tips on how I should proceed
Thank you
.

That set of initialization strings would be encoded as
    SPI_TRANSFER(0XF2, 0x18, 0xA3, 0x12, 0x02, 0XB2, 0x12, 0xFF, 0x10, 0x00);
    SPI_TRANSFER(0XF8, 0x21, 0x04);
    SPI_TRANSFER(0XF9, 0x00, 0x08);
    SPI_TRANSFER(0x36, 0x08);
    SPI_TRANSFER(0x3A, 0x05);
    SPI_TRANSFER(0xB4, 0x01//0x00);
    SPI_TRANSFER(0xB6, 0x02, 0x22);
    SPI_TRANSFER(0xC1, 0x41);
    SPI_TRANSFER(0xC5, 0x00, 0x07//0X18);
    SPI_TRANSFER(0xE0, 0x0F, 0x1F, 0x1C, 0x0C, 0x0F, 0x08, 0x48, 0x98, 0x37, 0x0A, 0x13, 0x04, 0x11, 0x0D, 0x00);
    SPI_TRANSFER(0xE1, 0x0F, 0x32, 0x2E, 0x0B, 0x0D, 0x05, 0x47, 0x75, 0x37, 0x06, 0x10, 0x03, 0x24, 0x20, 0x00);
    SPI_TRANSFER(0x11);
    usleep(120*1000);
    SPI_TRANSFER(0x29);

in fbcp-ili9341.

I try this Init Code, and found that it works OK.


Add new topic for authentication for app plugins

The existing authentication topic needs to be rewritten to apply only to data source plugins, and a new topic should be created specifically for app plugins.

Looking for subject matter expert to draft this topic.

Adding Esteban as co-owner. He writes: "I can help you with this. But the information for apps is basically the same as data sources"


Support for virtual file systems

Please select if your request is either something new or an enhancement

[ ] Enhancement of an existing Feature.
[x] Request of a new feature.

Please select the area your request applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)
Generally applies to the entire extension
Is your feature request related to a problem? Please describe
I'd like to be able to use github.dev or vscode.dev to open my repo and take notes. Right now this is not possible because dendron cannot work in a virtual file system.
Describe the solution you'd like
Support virtual file systems for better vscode web support.

Thanks @sbatten for the feature request.

Hey @sbatten , Dendron does have a web extension now!
It has very limited functionality currently, but we are planning to extend them as per the usage patterns
Read more here

hi @Harshita-mindfire I've been playing around with this in vscode.dev. I'm happy to see the extension loading and some commands showing up. It seems some really useful commands are still not there yet, like "Create Daily Journal", also a few other issues I see are:

Incomplete note lookup results
errors when opening notes with note lookup (see below)
opening a non-dendron workspace with remote repositories extension still errors on desktop when opening

I'm a bit hesitant to open a new issue here, since it seems similar but this is not working at all for me - let me know if a new issue is preferred.
When I load GitHub.dev with synced settings and Dendron enabled, code spaces tries to install the extension but then has a "problem with initialization".

I'm just starting to poke around codesoaces, so I'm not that familiar with the environment, but because of the init issue I don't have any Dendron commands so I can't attach a log using the built-on command, but if I can gather additional data let me know.
If I load my config in vscode.dev (or within the Blink Shell, FWIW) I don't get the error, but none of the Dendron commands are installed - the only Dendron-related command I see is Paste Image


!uqfinal should dynamically get semester code

To ensure it works without changing the magic number every sem, it should make a request to https://api.uqfinal.com/semesters and then use the current semester id

Does this consistently return the current semester as the last element, or will semesters sometimes pop in early?

it will consistently return only one of them with isCurrent == true


target detection scripts and move_base parameters

Update move_base parameters
Add new features: detecting targets and calculating their positions

Thanks for your contribution


wrap blockly in a TEA-style submodule

Still need to try to remove anything marlowe-specific from Halogen.Blockly but I think we can leave this for another PR

Pre-submit checklist:

Branch

[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Relevant tickets are mentioned in commit messages

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

If you updated any cabal files or added Haskell packages:

[ ] $(nix-build default.nix -A plutus.updateMaterialized) to update the materialized Nix files
[ ] Update hie-*.yaml files if needed

If you changed any Haskell files:

[ ] $(nix-shell shell.nix --run fix-stylish-haskell) to fix any formatting issues

If you changed any Purescript files:

[ ] $(nix-shell shell.nix --run fix-purty) to fix any formatting issues

Pre-merge checklist:

[ ] Someone approved it
[ ] Commits have useful messages
[ ] Review clarifications made it into the code
[ ] History is moderately tidy; or going to squash-merge

This change has also improved the halogen flow a little. We want to do the same for Actus eventually but first we need to remove some marlowe specific code: https://github.com/input-output-hk/plutus/blob/master/marlowe-playground-client/src/Halogen/Blockly.purs#L115

This change has also improved the halogen flow a little. We want to do the same for Actus eventually but first we need to remove some marlowe specific code: https://github.com/input-output-hk/plutus/blob/master/marlowe-playground-client/src/Halogen/Blockly.purs#L115


Remove assumption of `window' in MdPlatform

Makes it work when loaded in node
See https://github.com/angular/material2/issues/2171
https://github.com/angular/material2/issues/308#issuecomment-267124520
If you would rather see this rewritten with proper node detection instead of this workaround to make it load, that would be fine with me as well.

LGTM


Question: how to support i18n while writing extension for vscode?

Sorry for asking it here, because I cannot get answer from stackoverflow
I'm working on an extension authoring, a few menu items will be shown in explorer view, as below:

I am wondering if it is possible to give them localization such as all other built-in menus items?

@michelkaporin checked the module, i am not sure my understanding is correct.
For example, i have following command definition in the package.json:
"commands": [
      {
        "command": "favorites.addToFavorites",
        "title": "%command.favorites.addtofavorites%"
      },
      {
        "command": "favorites.deleteFavorite",
        "title": "%command.favorites.deletefavorite%"
      }
    ]

So i give a default value for it in package.nls.json as below:
{
	"command.favorites.addtofavorites": "Add to Favorites",
	"command.favorites.deletefavorite": "Delete favorite"
}

If i need a zh-CN translation, what should i do? Thanks very much

@leftstick As a next step you need to perform translations. We use Transifex platform for this as I have already mentioned above. How to onboard your extension to it (in terms of code) is described here:
https://github.com/Microsoft/vscode-nls-dev#onboarding-extension-to-transifex
If you want to manually translate your extension, you should reuse the same code as in the example there but without calling nls.pushXlfFiles and nls.pullXlfFiles. Instead you will pipe the result of prepareXlfFiles to your filesystem and work with XLF standard for translation. Once you have translated XLF files you pipe them to nls.prepareJsonFiles and then to ./i18n folder in the root of your extension.
Hope it makes sense.

@michelkaporin make sense. Thanks a lot.  Last question, i have i18n folder generated:

But when i start debugging my extension, the menu item still display in english, while the rest built-in menus have been changed correctly(I have chagned the locale.json to "locale":"zh-CN")

Check if package.i18n.json contains your translations. If yes, then I am not sure what's wrong. If not, then translations most likely were not correctly imported.

Hi @michelkaporin, thanks for your quick response.
Content in package.i18n.json is correctly generated:

It's indeed weird

Maybe you need to create vsix to see all localizations. @dbaeumer should know more.

@michelkaporin, thanks anyway. I am going to do more trials with my extension.

Translation bundling in a build time step in VS Code not a development time step. We do this to optimize translations in terms of size and key look up. So if you want to test the translation of an extension you need to built a vsix and install it locally. It is the same with VS Code. If run out of source you don't see any translated values even if you switch to another language.

@dbaeumer  thanks for your answer. I tried following:

generate .vsix with vsce package
use Install from VSIX...
reload vscode
change language to zh-CN
reload vscode
translation is not there, even the rest menus were changed

So i tried vsce ls to see if my i18n stuff packaged, and i got:
.esformatter
gulpfile.js
i18n/chs/package.i18n.json
images/favorites.png
images/preview.gif
LICENSE
out/src/enum/index.js
out/src/index.js
out/src/model/index.js
out/src/provider/FavoritesProvider.js
package-lock.json
package.json
package.nls.json
README.md

The third line tells that the i18n stuff were package correctly.
I tried to search it there is extension provided such experience(as example for me), but no luck. Thanks anyway

@dbaeumer let me know if there is something wrong on my side, then I will jump in. Leaving it to you for now.

I found even the built-in extension vscode-node-debug has this issue either. So i reported there Localization for menu items seem not working properly

@leftstick check if your nls import and configuration is done before you import any other code in your extension.

@michelkaporin  just tried by your advice, import nls and config it at the very beginning of the extension entry point. Rebuild it with vsce package, install this VSIX from local. But no luck, the menu item still displayed in English

@leftstick - From what you posted at https://github.com/Microsoft/vscode-extension-samples/issues/20#issuecomment-311006385 it doesn't seem like you have the right .json files in your out folder.
Documentation on this is quite sparse, but from inspecting what is in

/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/markdown
https://github.com/Microsoft/vscode-nls/blob/master/src/tests/localize.test.ts#L60
https://github.com/Microsoft/vscode/blob/master/build/gulpfile.extensions.js#L67
https://github.com/Microsoft/vscode-nls-dev/blob/master/src/tests/analyze.tests.ts#L11

you will have a better idea of what is the shape of the .json file that is needed. It's not sufficient to just have the i18n folder as you have.
I have a basic version (doesn't hook into the build pipeline) that will hopefully demystify some of the magic that vscode-nls and vscode-nls-dev is doing. Take a look at https://github.com/vazexqi/vscode-extension-samples/tree/master/i18n-sample (I might submit this as a PR if I hook into the whole nls-dev pipeline of gulp tasks)

Also, as @michelkaporin pointed out, you want to be very careful to ensure that nls.config is called during the activation of your extension before nls.loadMessageBundle (remember this could happen during import statements from modules you depend on). See https://github.com/vazexqi/vscode-extension-samples/blob/master/i18n-sample/src/extension.ts
IMO, the vscode-nls and vscode-nls-dev combination seems quite heavyweight for most use-cases. If you are sending stuff over to Transifex for translations, this overhead might be necessary.
You might be better off just rolling your own implementation of a simple key-value .json file. The trick to this is to just read process.env.VSCODE_NLS_CONFIG to see what locale VS Code is run with and then just load the right bundle.
On a separate note, @dbaeumer and @michelkaporin - why is the .json file that you expect for vscode-nls keyed by position rather than by message string? This seems very unintuitive and requires lots of transformation (including the complicated JS source manipulation at https://github.com/Microsoft/vscode-nls-dev/blob/master/src/lib.ts#L642). Why not just follow the format that you use for the top-level package.nls.json and have them be key-values pairs in the .json file?

@vazexqi , thanks man. I think the issue shall be closed since your example just awesome

@vazexqi late answer: performance and memory consumption. If you have thousands of messages (which we do in VS Code) then this starts to matter.


Updated to provide the meeting room details

Added a function to get the meeting room details corresponding to meeting id

Closing due to inactivity.


Slier plugin,  not having a slicer engine

Hello,  It installed perfectly via plugin manager.  NO slicer engine is in drop down.  How to install a slicer engine?

Never mind, figured it out.  User Problem.,   :-)


Possible to create a unviersal queue for alamofire requests?

Just wondered if it was possible to use this Queuer to push all alamofire requests into it with different priority scales? I think i read somewhere in an issue it wasn't possible with Alamofire or something along those lines but saw a new version was brought out.

Hi @liamcharmer! As I can see on Alamofire's documentation, you can set different queues only for rootQueue, requestQueue, and serializationQueue. But, all this properties must be an instance of DispatchQueue. More info here.
Queuer is a wrapper around OperationQueue, not on DispatchQueue. I'm planning to add more features to allow this kind of thing, but unfortunately, I have no ETA about it.


added mq_getattr for Linux (2nd try)

This is the 2nd attempt for mq_getattr which hopefully solves the broken stack problem.
Now again without Box and stack allocated.
I have added a c_long[4] array to the MqAttr as this is there on Linux systems. Without it the memory is corrupt and some unit tests result in an error with Signal 4 (which is very bad!).
See
/usr/include/linux/mqueue.h
Again, please carefully review this. mq_open is now also changed to take varargs (...) which is how it works in Linux.
(/usr/include/mqueue.h)
If this is ok, added the remaining mqueue functions should be a lot easier and I will be able to complete the mqueue support for nix-rust.

Looks good as far as I can tell. Thanks :+1:

Thanks for merging. Working in the missing functions.


[Auto] The wix GitHub organization is added

Automated changes by create-pull-request GitHub action

Figured try to add wix/greyhound as it came up here; but it's Bazel and GitHub struggles to apply my code suggestion.


fix: AU-820: Update ATV.

AU-820

GDPR calls to ATV were authenticated incorrectly with JWT token, when they need to be authenticated with Apikey.
What was done

ATV module was updated to 0.9.5 which uses apikey.

Other PRs

Link to other PR

Ei pysty ees testaamaan. Itse asiassa unohin mergee tän suoraan :)


Field description

Is your feature request related to a problem? Please describe.
I will use this libary to automatically create models. I want to write description (why a certain field is used for). The best way to do this is to write it in python comment.
Describe the solution you'd like
Add an option to write it in brackets when defining fields:

python manage.py dr_scaffold blog Post body:textfield(Content of the post) author:foreignkey:Author

Would generate:
class Post(models.Model):
    body= models.CharField(max_length=255) #Content of the post
    ...

It would also add this comment to the admin page (so that it is visible when adding new Post)
Describe alternatives you've considered
None
Additional context
N/A

not relevant, you can do this manually instead!

Why, isnt this code generator? I have a metadata libary that includes data types and descriptions, and I would like to use this code generator to add more information for each generated attribute.


Urdu (اردو) translation added

Urdu (اردو) translation added

@b0bdN could I have a quick 👀 on this, thanks


Consistent keyword ordering

Every time I run pegen on the same grammar, I (often) get a different order for KEYWORDS and SOFT_KEYWORDS.  This is annoying for version control, when parse.py is committed to a repo.
I imagine the cause is that the keywords are stored in a set which has nondeterministic order, and sorted will make this behavior deterministic.  Specifically, tuple(...) should be replaced with tuple(sorted(...)) in these lines:
https://github.com/we-like-parsers/pegen/blob/31f489a16ba961be2b7142789f54e4a02561acbc/src/pegen/python_generator.py#L240-L241
Is it appropriate to make PR here, or would it be better against cpython?

I believe such a PR would be welcome. This repo focuses on the pure python parser generation while the cpython repo focuses more on the generation of the C parser. So there is some non ideal duplication but for your case a PR against this repo is the most appropriate I would say.


SA1200 is firing for global usings

As mentioned in https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3243, SA1200 is firing for C# 10 global using statements.
cc @AraHaan @sharwell

Note that global using directives are only expected to appear in auto-generated files, since they are created by the SDK according to directives listed in the project file. When this pattern is followed, SA1200 will not be reported because SA1200 is not active in generated files.

Note that global using directives are only expected to appear in auto-generated files

Why would you expect that? It is totally valid to use them in normal code, to reduce the boilerplate across your code base.

Consistent declaration of global usings in the project file reduces the burden of keeping track of which directives are declared in which location(s) throughout the project. This best practice is already supported by SA1200.

Some people use older .NET SDKs but reference a version of the compiler that supports global usings via nuget packages just so they can use newer C# language versions I think with it (when they set their C# language versions to preview or latest) while targeting an older framework. With that aproach they can then use global usings or file scoped namespaces but since they are using an older .NET SDK (where the SDK does not auto generate them) they have to write the global usings themselves.
Now I know you are thinking: Why are they wanting to do that?
The answer is that sometimes their CI pipelines does not allow them to update the .NET SDK they want to use and so they get stuck with an older one installed with no way to install an newer one without admin/root access (some lock that down to avoid them from installing malicious programs in their CI). Sometimes however they have to reference the C# compiler package due to the one in their SDK bugging on their code and the referenced one fixes it due to it being newer. Both cases are valid reasons why the analyzer should acknowledge global usings and not expect them to only happen on autogenerated files mainly because it is not always possible. Likewise perhaps the user prefers to type the global usings themselves?

@AraHaan You can still add the following line to the top of a file manually if it's not possible to use the project system to generate the file:
// <auto-generated />

Actually it is the new language feature. We can see being used manually on the event of the launch of VS2012.

@AraHaan You can still add the following line to the top of a file manually if it's not possible to use the project system to generate the file:

This will disable more warnings though, and not just the one this bug causes

May I please ask that this be reconsidered.  Global using statements are intended to be used in normal source code to reduce boilerplate in cases where certain libraries are bound to be imported in all / most files.  It's cleare that Microsoft has been working hard to reduce boilerplate with file-scoped namespaces, implied Main method, record types and global namespaces.  This allows the language to be more succinct (sometimes to its detriment) but in many cases this is justified to reduce repeated code.
Would you at least consider an option to avoid firing SA1200 when global usings are used please?


Separate "PackageVersion" from "Marketing Version"

Description of the new feature / enhancement
Currently, there is the concept of two different versions

The Marketing Version
The DisplayVersion

Guidance has been to use PackageVersion as the marketing version and using the AppsAndFeaturesEntries to define the DisplayVersion when it differs from the marketing version.
I propose adding a new manifest field MarketingVersion - which would allow the version to be arbitrary and duplicative while still retaining a semantic version for PackageVersion
Proposed technical implementation details
No response

[Policy] Area-Manifest


CHAOS-121: Handle deleting chaos pods before they finish injecting

What does this PR do?

[ ] Adds new functionality
[x] Alters existing functionality
[x] Fixes a bug
[ ] Improves Documentation

A brief description of changes to implementation or controller behavior:

Make our injector's exitHandler signal channel buffered
Increase the TerminationGracePeriodSeconds of the chaos pod spec

Motivation for change:

signals needs to be a buffered channel, so that we can receive a signal anytime during the injection process as an unbuffered channel will ignore signals sent before it begins listening. We can keep the buffer size to 1 here as no matter how many SIGINT or SIGTERMs we receive, we want to carry out the same action: clean and die
The default TerminationGracePeriodSeconds is 30s. This can be too low for a chaos pod to finish cleaning. After TGPS passes, the signal sent to a pod becomes SIGKILL, which will interrupt any in-progress cleaning. Setting this to a generous 2 minutes in the pod spec itself, ensures that whether a chaos pod is deleted directly or by deleting a disruption, it will have time to finish cleaning up after itself.

Code Quality
Testing

[ ] I used existing unit tests
[x] I manually tested locally
[ ] I will manually test in a canary deployment

Please list your manual testing steps (sample yaml file, commands, important checks):
Proper testing would need a real cluster integration test. Locally, I have tested the following case before and after the patch, to ensure we are fixing the bug:

Add a time.Sleep(time.Minute) immediately before sig := <-signals in injector/main.go#injectAndWait to ensure that I could definitely issue a delete before a chaos pod begins listening for signals
Create a disruption
After the disruption has started and begun injecting, but before all chaos pods are ready and listening for signals, delete the disruption
Wait to see if the disruption is stuck on removal

Checklist

[x] The documentation is up to date
[x] My code is sufficiently commented
[x] I have tested to the best of my ability
[x] I have signed my commit (see Contributing Docs)

Other than needing feedback on our preferred "if cancelled; then return" syntax, and more manual testing, this is ready for review

Since implementing cancel, the original bug has re-appeared, i'm investigating


abstract tracker: In order to provide generic super class that defines a domain interface

The main purposes are:

specify interface
provide some behavioral helpers
method_missing issue
exception catching and passing

_setFields issue: https://github.com/roundscope/ember-insights/commit/b698e9afb8d0a2ed6efbd0ed08b1985de06518d8
if (settings.tracker._setFields) {
  settings.tracker._setFields();
}


[WFLY-10586] set capability reference for journal-datasource

set missing capability reference for journal-datasource that represents
the name of a data-source resource.

JIRA: https://issues.jboss.org/browse/WFLY-10586

thanks, I've amended the commit message with the correct JIRA number

test failures are not related to the PR


feat(build): add git version to binary and huge pages check

Some minor changes:

add check for huge pages or refuse to start
add git_version to binary
fix some clippies

bors try

bors r+

bors r+

bors merge

bors merge


merge from upstream

Plus:

small fix at SingleObjectArrayConverter
change to Auth Creds with one parameter only
updates to few Response classes

Coverage remained the same at 100.0% when pulling fe555f4fff461f271f9e0bdde267ee8e34b187ae on rodkings:master into e0402973efa49fcf87d77acb2c2fbcf09db969b8 on tparnell8:master.


RM: Fix deadloop in physical tpm case

For other cmd server thread, in physical tpm case, just skipped all cmd and give a successful response. this is not enough. Need to handle TPM_SESSION_END cmd to exit the thread, instead of continue to let the thread in a deadloop state.
Fix #221.

Will try to get a review done tonight.

Pushed but I didn't get a chance to test since I've been on the road. It's only a 2 line patch though and the bug is pretty serious so I'm pushing it a bit blind. Will test over the weekend just for good measure.


Sit-cfg override fixes:

MAJOR
-- Move log location sit-cfg override stanzas to just after listen-address (work-around for XML parsing issue seen in domain-in-image wl server log).
-- Add a 'TBD' note in the code for an outage in handling dynamic cluster SSL, NAP, and admin ports (discovered via code inspection).   We need to (A) have the introspector report these in its topology.yaml output, (B) check that the Operator can consume them from topology.yaml and set up services accordingly, and (C) add tests to cover this area.
MINOR
-- Call 'add' instead of 'replace' if overriding a missing Listen address (this is a best practice, 'replace' works but that's not documented as supported).
-- Do not 'replace' or 'add' an unset NAP ListenAddress (corrects mock/unit test issue seen in a particular T3Channel, no override is actually needed as the default NAP LA comes from server default LA).
-- Do not add SSL listen-address overide stanzas since there's no listen address field in an SSL stanza (this wasn't causing an issue, discovered during code inspection).
-- Update introspect mock/unit tests to cover even more use cases.

The change passes QUICKTEST, ad-hoc mock/unit introspector testing, and ad-hoc domain-in-image sample testing.

Even so, we probably should wait until after the holiday break to merge this into develop (and then eventually onto rc1), since the change likely won't get much testing until then...


gather some test utilities under xaynet_core::testutils

This makes some helpers for crafting messages re-usable from other
crates. xaynet_core::testutils requires the "testutils" feature.
This commit also moves the benchmarks to a separate crate.

@Robert-Steiner thanks for the review (and for spotting that the benchmarks were actually broken :confounded: ). I think I addressed all of your comments. Let's see if the CI is happy.

if I'm understanding the compromise here: although an update message helper feels like it ought to live with the update message module (say), the fact is it's used for tests in multiple places. so it's justifiable for such helpers to live in a shared crate (and necessary even, to be accessible from a different crate like benchmarks). And we put the helpers behind a feature flag because we consider them "internal".

Exactly


How to add scopes

So the api talks about using scopes to accomplish user specific commands or mod/owner commands, how does one use scopes with the mixer api?

Your question should be covered in the below documentation, but if not, let me know :)
https://dev.mixer.com/reference/oauth/shortcodeauth


Refine the spill threshold for aggregation/sort, refine the memory usage calculation for aggregation

What problem does this PR solve?
Issue Number: ref #6528
Problem Summary:
What is changed and how it works?

refine the spill threshold for aggregation/sort, now if aggregation/sort is executed parallelly, the threshold used in every sub agg/sort is recalculated by total threshold and the concurrency
refine the memory usage calculation for aggregation, don't rely on the task-level memory tracker to calculate the memory usage of aggregation.

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/hold

hold after code freeze

/unhold

/merge


Is React-SortableJS 6.1.4 compatible with React 18?

I have tried implementing this package (6.1.4) with React 18, and it looks like the state is not updated property after drop, if the approach is nested. Can someone please have a look on this?

Facing the same issue with package(6.1.4) with react 18, state not updating in case of nested structure

Facing the same issue..

Same.

I've found that this problem is due to automatic batching. You can work around it by wrapping the setList function in flushSync:
import { flushSync } from 'react-dom';

...then...
<ReactSortable setList={(items) => flushSync(() => onChange(items))} />

I've found that this problem is due to automatic batching. You can work around it by wrapping the setList function in flushSync:
import { flushSync } from 'react-dom';

...then...
<ReactSortable setList={(items) => flushSync(() => onChange(items))} />

Hi, this fix did not work for us (and we get warnings in the console for using flushSync inside a lifecycle method).
Seems like the component state is not updated.
Did someone find a workaround? Thanks!

Can try this to avoid the error about calling flushSync inside lifecycle (it's working for me):
      setList={(newItems) => {
        queueMicrotask(() => {
          // flushSync required for this to work in React 18
          flushSync(() => onChange(newItems));
        });
      }}

Same issue. Unusable on React 18 and flushSync do not solve anything for my project.
Any updates on React 18 compatibility?

Dropping this on top, in React 18 StrictMode the animations are really bugged for me during the development but work fine in the production build. I didn't not suspect this at first and spent quite some time trying to fix the animations only to turn off them in the end and accidentally find out that they work fine on the production build.

@etiennelacoursiere  I changed it to this later on, which I think fixes that problem:
      setList={(newSteps, sortable) => {
        if (sortable) {
          // flushSync required for this to work in React 18
          flushSync(() => onChange(newSteps));
        } else {
          // called from component constructor, where flushSync throws error
          onChange(newSteps);
        }
      }}

@etiennelacoursiere I changed it to this later on, which I think fixes that problem:
      setList={(newSteps, sortable) => {
        if (sortable) {
          // flushSync required for this to work in React 18
          flushSync(() => onChange(newSteps));
        } else {
          // called from component constructor, where flushSync throws error
          onChange(newSteps);
        }
      }}

hmm, yeah It got rid of the errors I had in the console, but can't say I understand why. Care to explain?

I got this working.... Adding className="flex flex-col w-full" to my ReactSortable fixed it for me.

I did get it to somewhat work - Adding the prop group="grouped" seemed to make things behave. Sometimes it feels like I have to drag upwards to get it to start working. But it made it somewhat usable...

I am also having issues. Does someone know of a different package with the same functionality?

Same issue. Passing 'dropBubble' to ReactSortable resolved it for me.


missing system variable like @activity

there are missing system variables from this, including the activity / dataset etc
would be good to have a more updated list of all system variables that can be used within ADF

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: befd9a68-45a2-9105-1b1b-16bf792a2d73
Version Independent ID: 2c2e1fa5-7824-5fe9-7382-bf5573a25be3
Content: System variables in Azure Data Factory
Content Source: articles/data-factory/control-flow-system-variables.md
Service: data-factory
GitHub Login: @sharonlo101
Microsoft Alias: shlo

@aaronhughesdelt Thanks for bringing this to our notice. I am assigning the issue to the content owner to review and update as appropriate.
@sharonlo101 Can you please take a look at this one and do the needful?

Agreeed - also would like to see how pipeline variables are called pipeline().variable.?

@djpmsft Can you please have a look at this ?

Hi there,
There are no missing dataset or activity System Variables from this list. Variables such as @activity('activityName').output are a different concept and should not be included in this doc.
Pipeline variables are user-created, not System variables, that can be accessed via @variables('variableName')
As there is no specific ask, I am closing this issue.
-Daniel

closed #29560

#please-close

@djpmsft is there documentation for the "other concept" variables such as @activity().output ?


Set the default DynamicFont size to 16

This makes it possible to view newly-created DynamicFonts once a font has been assigned to them, without having to change their size by hand after creating them.
Note: I don't know if that's the proper way to set the font size from the constructor, but it seems to work well without causing side-effects in existing projects.
Preview:

Hopefully it does not cause the font to be generated twice when loaded (once with size of 16 due to setting the default and a second time with whater size is actually set)

Cherry-picked for 3.0.7.


optimized code for LdapUserService.class

What's the purpose of this PR
avoid creating useless objects

Codecov Report

Merging #3127 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #3127      +/-   ##
============================================
- Coverage     51.24%   51.24%   -0.01%
+ Complexity     2236     2235       -1
============================================
  Files           432      432
  Lines         13427    13425       -2
  Branches       1381     1381
============================================
- Hits           6881     6879       -2
+ Misses         6069     6068       -1
- Partials        477      478       +1

Impacted Files
Coverage Δ
Complexity Δ

...mework/apollo/portal/spi/ldap/LdapUserService.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

.../apollo/internals/RemoteConfigLongPollService.java
77.10% <0.00%> (-1.21%)
28.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ade3b...f0b777e. Read the comment docs.


[Feature request] Dates comparing

It would be nice to have methods for comparing dates like before, equal and after

@justin-schroeder sorry for tagging, if there is more date-fns function that need to be migrated here I will move them ❤

@vanodevium We do have a sameDay function for simple equality, but help me understand before and after. Is this pure syntactic sugar? Since tempo’s primitive is native Date objects you can compare them directly:
const dateA = new Date()
const dateB = new Date('2012-11-10')

dateA > dateB // true

@justin-schroeder
yeap, these methods are simply sugar
main goal: I can compare not only Date instances, but strings
Something like
before(new Date(), '2024-02-23');
before(tempoInstance, '2024-02-23');
before(tempoInstance, '2024-02-23 00:01:02');
before(tempoInstance, new Date());
before(tempoInstance1, tempoInstance2);

All these variants works as expected -> true/false

friendly reminder: sameDay() isn't equal() because it skips time.

I think i can get onboard with the syntax sugar since it should all tree shake out nicely.


libm{libm|newlib}: fix broken sincos optimization for GCC

Summary

libm/libm: disable optimization for sincos

libm/newlib: disable optimization for sincos
Disable sincos optimization otherwise gcc would generate infinite calls.
Refer to gcc bug 46926: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=46926
-fno-builtin-sin or -fno-builtin-cos can disable sincos optimization,
but these two options do not work inside optimize pragma in-file.
Thus we just enforce -O0 when compiling this file.

Impact
fix broken sincos when high optimization enabled
Testing
x86 with -O3

I just realized there is a typo in optimization name, I think nooptimiziation_function should be renamed to nooptimization_function

@acassis you're right, there is a typo in this macro :)

@szafonimateusz-mi let's create a new patch to fix the typo.


⚠ Bofrost.be has degraded performance

In 24baab9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2842 ms

Resolved: Bofrost.be performance has improved in 9489e7b.


Verification failed in compiling tb using xlm

Observed Behavior

I run make TEST=riscv_machine_mode_rand_test ITERATIONS=1 SEED=1 COV=0 SIMULATOR=xlm in dv/uvm/core_ibex. The terminal outputs:
mkdir -p out/build make: *** [Makefile:331: out/build/tb/.compile.stamp] Error 1
I have attached the compile.log in dv/uvm/core_ibex.
Thanks for your help!
compile.log
Expected Behavior

Steps to reproduce the issue

My Environment

EDA tool and version:

XCELIUM21.03.007
Operating system:

Version of the Ibex source code:

Do you have access to Xcelium version '21.09.s006'? That is the version we use to run some internal regressions and it's possible the issues you're seeing here are some version specific bug.

Thank you, after using Xcelium 21.09, I can run the test, but when I set COV=1, errors occur in merge-cov.py
Here is the terminal output:
make TEST=riscv_arithmetic_basic_test SEED=1 ITERATIONS=1 COV=1 SIMULATOR=xlm
Repeating compiling TB because variable COV has changed value.
Running RTL simulation at out/run/riscv_arithmetic_basic_test.1/rtl.log
Comparing traces for riscv_arithmetic_basic_test.1
Collecting up results (report at out/run/regr.log)
100.00% PASS 1 PASSED, 0 FAILED
Thu, 09 Jun 2022 11:51:46 INFO     Creating output directory: out/run/fcov
Thu, 09 Jun 2022 11:51:46 INFO     Processing trace log under out/run
Thu, 09 Jun 2022 11:51:46 INFO     Process ibex log[1/2] : out/run/riscv_arithmetic_basic_test.1/spike_cosim.log.csv
Thu, 09 Jun 2022 11:51:46 INFO     Process ibex log[2/2] : out/run/riscv_arithmetic_basic_test.1/trace_core_00000000.log.csv
Thu, 09 Jun 2022 11:51:46 INFO     Building the coverage collection framework
Thu, 09 Jun 2022 11:51:56 INFO     Collecting functional coverage from 2 trace CSV
Thu, 09 Jun 2022 11:51:56 INFO     Processing batch 1/1
Thu, 09 Jun 2022 11:51:58 INFO     Collecting functional coverage from 2 trace CSV...done
Thu, 09 Jun 2022 11:51:58 INFO     Coverage results are saved to out/run/fcov
Traceback (most recent call last):
File "/home/oyykyook/ibex/dv/uvm/core_ibex/scripts/merge-cov.py", line 146, in
sys.exit(main())
File "/home/oyykyook/ibex/dv/uvm/core_ibex/scripts/merge-cov.py", line 141, in main
return merge_funs[args.simulator](output_dir, args.verbose, cov_dirs)
File "/home/oyykyook/ibex/dv/uvm/core_ibex/scripts/merge-cov.py", line 84, in merge_cov_xlm
merge_ret = run_one(verbose,
File "/home/oyykyook/ibex/dv/uvm/core_ibex/scripts/scripts_lib.py", line 78, in run_one
return subprocess.run(cmd,
File "/home/oyykyook/miniconda3/lib/python3.9/subprocess.py", line 505, in run
with Popen(*popenargs, **kwargs) as process:
File "/home/oyykyook/miniconda3/lib/python3.9/subprocess.py", line 951, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "/home/oyykyook/miniconda3/lib/python3.9/subprocess.py", line 1821, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'imc'
make: *** [Makefile:429: out/run/coverage/.merge.stamp] Error 1
I checked the merge_cov_xlm function in merge-cov.py and I found that "imc" belongs to a cmd, so I guess I did not set the environment variable for Xcelium properly.
Would you please show me how you set the environment variable for Xcelium?
Thanks!

Hi, I found that I did not install imc, after I installed imc I ran make TEST=riscv_arithmetic_basic_test ITERATIONS=1 SEED=1 COV=1 SIMULATOR=xlm VERBOSE=1.
The contents in fcov folder are:
asm_test  compile.history  compile.log  default  ibex_trace_log  seed.yaml  sim_riscv_instr_cov_test_0_0.log  xcelium.d
How can I get the coverage report with the scores in a .txt file?

Hi, I have installed the imc and I ran make TEST=riscv_arithmetic_basic_test ITERATIONS=1 SEED=1 COV=1 SIMULATOR=xlm VERBOSE=1
But the cov_report_cg.txt in the out/run/coverage/report folder only have 3 covergroups:
`name                                     CoverGroup Average   CoverGroup Covered
riscv_instr_pkg                          34.73%               29.90% (3388/11331)
core_ibex_fcov_if                        36.18%               7.80% (207/2653)
core_ibex_pmp_fcov_if.g_pmp_cgs_T        42.25%               20.91% (23/110)
core_ibex_pmp_fcov_if.g_pmp_cgs_T.g_pmp_region_fcov 34.44%               5.23% (16/306)`
How can I get a more detailed coverage report likewise the way I using vcs, in which I can see scores for each coverpoints.
Thank you!

Hi,
xlm will produce index.html under <your_core_ibex_dv_path>/out/run/coverage/report for a report about merged coverage from all tests. The reason behind having another folder named fcov there is for gathering the coverage data about the instructions that is auto-generated by riscv-dv (So you could think about fcov as just another run, like riscv_arithmetic_basic_test.1).
Sorry for the delayed response!
Canberk

I believe that this issue is now best resolved with an improvement / update to the documentation. Closing the issue but referenced in our documentation improvement exercise: [doc] Documentation Improvement - catch all for documentation issues


CMake Error at C:/Program Files/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message)

I am trying to use cmake to compile darknet for YOLO V3. But getting following error:
CMake Error at C:/Program Files/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message): Could NOT find PThreads_windows (missing: PThreads_windows_LIBRARY PThreads_windows_INCLUDE_DIR) Call Stack (most recent call first): C:/Program Files/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE) cmake/Modules/FindPThreads_windows.cmake:39 (find_package_handle_standard_args) C:/Users/MSI/vcpkg/scripts/buildsystems/vcpkg.cmake:288 (_find_package) CMakeLists.txt:93 (find_package)
How can I fix this?

How did you install darknet?
vcpkg install darknet:x64-windows?
What compiler did you use?

@Asif1405, could you provide us the environment and repro steps, also attach the failure logs?
I tried to build darknet:x64-windows with latest vcpkg and VS2017 15.9.19, it built successfully for me.
Starting package 3/3: darknet:x64-windows
Building package darknet[core]:x64-windows...
-- Downloading https://github.com/AlexeyAB/darknet/archive/81290b07376c5abb4988a492dda70913bb90133d.tar.gz...
-- Extracting source F:/VCPKG/src/downloads/AlexeyAB-darknet-81290b07376c5abb4988a492dda70913bb90133d.tar.gz
-- Using source at F:/VCPKG/src/buildtrees/darknet/src/13bb90133d-a4584e7461
-- Configuring x64-windows-dbg
-- Configuring x64-windows-rel
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: F:/VCPKG/src/packages/darknet_x64-windows/share/darknet/copyright
-- Performing post-build validation
-- Performing post-build validation done
Building package darknet[core]:x64-windows... done
Installing package darknet[core]:x64-windows...
Installing package darknet[core]:x64-windows... done
Elapsed time for package darknet:x64-windows: 52.26 s
Total elapsed time: 1.488 min
The package darknet:x64-windows provides CMake targets:
find_package(Darknet CONFIG REQUIRED)

@Asif1405, feel free to reopen this issue if it still a problem for you, please also provide us the repro steps at the same time.


Create UI and Navigation for Detailed Patient Information

Relevant Issue
[PAL-73] (https://pallinet.atlassian.net/browse/PAL-73?atlOrigin=eyJpIjoiMTA2MTYzOGQzNmNjNDA2NjlhYzMyNzlmYWIxYWJkMTAiLCJwIjoiaiJ9)
[PAL- 103] (https://pallinet.atlassian.net/browse/PAL-103?atlOrigin=eyJpIjoiYTU3ZmNhNDk0NmNjNDAxMmJmMzFjMzgzZDFmOGU3NDciLCJwIjoiaiJ9)
Description
I created the Navigation to the detailed Patient Information View.
I created the UI for the detailed Patient Information View.

Can see the patient detail list, summary list, and physician home page. Looks good to me!

New view looks good, can likely further refine the UI in future sprints

Great work. UI looks nice.


CMC-1647-1648: Claim issue hand off when any defendant(s) is unpresen…

…ted or unregistered
Before creating a pull request make sure that:

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CMC-1647
https://tools.hmcts.net/jira/browse/CMC-1648
Change description

Changed the stateflow to accommodate 1v2 cases for example: 1 def unregistered and 1 def unrepresented
Any case that has an unregistered or unrepresented defendant will go offline
This story does not include RPA changes

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Camunda diagram


Change cache hit ratio to reflect change since last snap

This fixes #272

@Krysztophe : can you try this ?

As said in private:
with a pgbench scale 1000 (about the size of the 12 Gb share buffers), after a server restart, I get immediately a hit ratio around 65%-90%, although only a very small part of the tables are in the SB (checked with pg_buffercache) ?!?

I tried with scale 300 (4GB) and the default shared buffers.
I got similar results.
But I also see the same with hit_ratio service of check_pgactivity.

I have regened the man file and squashed the commits.


Unnecessary log-cache config

log-cache instances are told where their peers are via the scheduler. They also require this information to be provided via env vars NODE_ADDRS and NODE_INDEX. Perhaps we make operators lives easier and not require this configuration.
cc/ @apoydence

I don't think this is the case any longer. Closing this out.


Hyphenation exceptions don't work with curly apostophes

The solution to #265 works for the documented test case but it only tests straight single quotes used as apostrophes. In those cases it works as expected, but in the case of Unicode typographic marks it does something quite unexpected:
\hyphenator:add-exceptions{
	rab’-bin
	rab'-bin
	rab’-bim
	rab'-bim
}

\script{SILE.typesetter:typeset(showHyphenationPoints("RAB’bin", "tr"))}

\script{SILE.typesetter:typeset(showHyphenationPoints("RAB'bin", "tr"))}

\script{SILE.typesetter:typeset(showHyphenationPoints("RAB’bim", "tr"))}

\script{SILE.typesetter:typeset(showHyphenationPoints("RAB'bim", "tr"))}

RAB’bi-n
RAB'-bin
RAB’bi-m
RAB'-bim

Note it did do something because this isn't the default for those words either, but it isn't hyphenating where expected. Likewise some words produce even more scrambled results:
\hyphenator:add-exceptions{
	tan-rı’-nın
	tan-rı'-nın
	tan-rı’-yla
	tan-rı'-yla
}

\script{SILE.typesetter:typeset(showHyphenationPoints("Tanrı’nın", "tr"))}

\script{SILE.typesetter:typeset(showHyphenationPoints("Tanrı'nın", "tr"))}

\script{SILE.typesetter:typeset(showHyphenationPoints("Tanrı’yla", "tr"))}

\script{SILE.typesetter:typeset(showHyphenationPoints("Tanrı'yla", "tr"))}

\script{SILE.typesetter:typeset(showHyphenationPoints("volksemosie", "af"))}

Tan-rı’nın-
Tan-rı'n-ın
Tan-rı’yla-
Tan-rı'y-la

This is a matter of Lua's string functions not being UTF-8 away. #exc is coming back two bytes longer than it should be and the character positions are off by 2 after each non-8bit character.


Implement trusted workspace settings

This PR includes changes implementing

Workspace trust editor to represent workspace settings requiring trust.

Settings editor to represent workspace settings requiring trust

Settings editor shows settings requiring workspace trust with a message and link to open the workspace trust editor. Note that user cannot modify the value.

Workspace trust editor changes LGTM!


Add the default user and password note.

What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @your-reviewer

Release note:

NONE

thanks, this is useful for new user. 👏


Fix incompatibility Elixir/Erlang OTP error in GitHub CI

This resolves the error below:
Error: Requested Elixir / Erlang/OTP version (1.10.4 / OTP-24.0.6) not
found in version list (did you check Compatibility between Elixir and
Erlang/OTP?)

The last supported Erlang OTP for Elixir 1.10.4 is OTP 23:
$ asdf list all elixir | grep 1.10.4
1.10.4
1.10.4-otp-21
1.10.4-otp-22
1.10.4-otp-23

We also refactor and simplify the GitHub Actions configuration.

@josevalim What is the minimum Elixir version we want to support here? The CI set to 1.10.4 while mix.exs set to 1.7?

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


[BUG] "Warning: some journal files were not opened due to insufficient permissions." and "cannot open debug.log for reading"

Describe the bug
Following the guide here at this point, I ran the command systemctl status bitcoind.service and saw the following results and warning:
admin@raspibolt3:~/.bitcoin $ systemctl status bitcoind.service
* bitcoind.service - Bitcoin daemon
     Loaded: loaded (/etc/systemd/system/bitcoind.service; enabled; vendor preset: enabled)
     Active: active (running) since Thu 2021-12-30 23:15:37 EST; 5min ago
    Process: 786 ExecStart=/usr/local/bin/bitcoind -daemon -pid=/run/bitcoind/bitcoind.pid -conf=/home/bitcoin/.bitcoin/bitcoin.conf -datadir=/home/bitcoin/.bitcoin -startupnotify=chmod g>
   Main PID: 787 (bitcoind)
      Tasks: 17 (limit: 4165)
        CPU: 6.324s
     CGroup: /system.slice/bitcoind.service
             `-787 /usr/local/bin/bitcoind -daemon -pid=/run/bitcoind/bitcoind.pid -conf=/home/bitcoin/.bitcoin/bitcoin.conf -datadir=/home/bitcoin/.bitcoin -startupnotify=chmod g+r /home>

Warning: some journal files were not opened due to insufficient permissions.

Additionally, I was unable to tail the log file:
admin@raspibolt3:~/.bitcoin $ tail -f /home/bitcoin/.bitcoin/debug.log
tail: cannot open '/home/bitcoin/.bitcoin/debug.log' for reading: Permission denied
tail: no files remaining

Location in guide
https://raspibolt.org/bitcoin-core.html#verification-of-bitcoind-operations
Expected behavior
I expect to not see the warning or the error when tailing debug.log
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

Hardware platform: Raspberry Pi 4
Operating system: Raspberry Pi OS 64bit
Version: Debian GNU/Linux 11 (bullseye)

Additional context
Add any other context about the problem here.

See here: https://github.com/raspibolt/raspibolt/issues/853
But I think the guide should either be updated to show the warning like mentioned in the thread linked above or the permissions updated so there are no warnings.
For the log you need to either use 'sudo' or change the permission of the log file. Should probably update the guide for this as well because it's leads to confusion.

See here: #853
But I think the guide should either be updated to show the warning like mentioned in the thread linked above or the permissions updated so there are no warnings.
For the log you need to either use 'sudo' or change the permission of the log file. Should probably update the guide for this as well because it's leads to confusion.

I agree about showing the warning (since I was confused) and I also agree about updating the guide to use sudo. I will close my PR #865 and make a new one. Thank you!


Conditional Lazy Listener?

Is there a way to make it so that the lazy function triggers conditionally based on the ack response?
For example, I want my ack to do parameter validation and potentially reject the request. Right now, my solution is to have the lazy function run the same parameter validation as the ack function, but it seems a bit wasteful. I'd much rather the lazy function not get triggered at all in the scenario where the ack function returns errors to the user.
Reproducible in:
The slack_bolt version
slack-bolt==1.9.1
Python runtime version
Python 3.8.12
OS info
ProductName:    macOS
ProductVersion: 11.5.2
BuildVersion:   20G95
Darwin Kernel Version 20.6.0: Wed Jun 23 00:26:31 PDT 2021; root:xnu-7195.141.2~5/RELEASE_X86_64

Steps to reproduce:
Run something like this:
def validate_the_stuff(ack, view):
    #errors = validate_inputs(view)
    errors = { "environment-select-block": "Nope" }
    if len(errors) > 0:
        ack(response_action="errors", errors=errors)
        return False
    else:
        ack(response_action="clear")

def do_the_thing(view):
    logging.error("You should not get this far")

app.view_submission('environment_select_submit')(
    ack=validate_the_stuff,
    lazy=[do_the_thing]
)

Expected result:
Don't do the thing if validation fails.
Actual result:
Does the thing even if validation fails.
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

Hi @SigniantJoe, thanks for writing in!
Unfortunately, there is no way to run lazy listeners based on the ack listener behavior. the current recommendation for your use case at this moment is to have the same validation in the beginning of the lazy listeners.
With that being said, we may consider adding a new configuration / mechanism to support this use case in a better way.

@seratch thank you for confirming the behaviour. I do think this would be a great enhancement, especially as sometimes we need to query external services or do relatively heavy validation


Add WarningAggregator, improve unused stream warning

The unused stream warning emitted when a tee'd branch of an internal stream is left unconsumed is spammy and not very helpful. This change improves things by ensuring that only one instance of the warning per IoContext is emitted, aggregating all of the information about branches that are not read. The warning message is further augmented to include the JavaScript stack trace locations where each of the unconsumed branches were created.

Nice one! LGTM


SWIFT_VERSION build setting not being applied

Attempting to develop a new swift-based plugin, so I've never had this working before and therefore don't know it's not something I've done wrong, but this is what happens when I try to build my plugin (starting fresh with a new iOS platform installation):
Andys-Mac-mini:testapp andy$ cordova platform remove ios
Removing platform ios from config.xml file...
Removing ios from cordova.platforms array in package.json
Andys-Mac-mini:testapp andy$ cordova platform add ios
Using cordova-fetch for<EMAIL_ADDRESS>Adding ios project...
Creating Cordova project for the iOS platform:
	Path: platforms/ios
	Package: net.meridiandigital.cordova.mediatest
	Name: Media Test
iOS project created with<EMAIL_ADDRESS>Installing "cordova-plugin-whitelist" for ios
--save flag or autosave detected
Saving<EMAIL_ADDRESS>into config.xml file ...
Andys-Mac-mini:testapp andy$ plugman install --platform ios --project "platforms/ios" --plugin "../mediacentre"
Installing "uk.org.dsf.cordova.media" for ios
Fetching plugin<EMAIL_ADDRESS>via npm
Installing "cordova-plugin-add-swift-support" for ios
Andys-Mac-mini:testapp andy$ cordova prepare ios
Andys-Mac-mini:testapp andy$ cordova build ios
Reading build config file:
Building project: /Users/andy/Desktop/cordova-plugin-mediacentre/testapp/platforms/ios/Media Test.xcworkspace
	Configuration: Debug
	Platform: device
User defaults from command line:
    IDEArchivePathOverride = /Users/andy/Desktop/cordova-plugin-mediacentre/testapp/platforms/ios/Media Test.xcarchive

Build settings from command line:
    CONFIGURATION_BUILD_DIR = /Users/andy/Desktop/cordova-plugin-mediacentre/testapp/platforms/ios/build/device
    SHARED_PRECOMPS_DIR = /Users/andy/Desktop/cordova-plugin-mediacentre/testapp/platforms/ios/build/sharedpch

Build settings from configuration file '/Users/andy/Desktop/cordova-plugin-mediacentre/testapp/platforms/ios/cordova/build-debug.xcconfig':
    CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES
    CODE_SIGN_ENTITLEMENTS = $(PROJECT_DIR)/$(PROJECT_NAME)/Entitlements-$(CONFIGURATION).plist
    CODE_SIGN_IDENTITY = iPhone Developer
    DEVELOPMENT_TEAM = 84P6SXL3HM
    ENABLE_BITCODE = NO
    GCC_PREPROCESSOR_DEFINITIONS = DEBUG=1
    HEADER_SEARCH_PATHS = "$(TARGET_BUILD_DIR)/usr/local/lib/include" "$(OBJROOT)/UninstalledProducts/include" "$(OBJROOT)/UninstalledProducts/$(PLATFORM_NAME)/include" "$(BUILT_PRODUCTS_DIR)"
    OTHER_LDFLAGS = -ObjC
    SWIFT_OBJC_BRIDGING_HEADER = $(PROJECT_DIR)/$(PROJECT_NAME)/Bridging-Header.h

=== BUILD TARGET CordovaLib OF PROJECT CordovaLib WITH CONFIGURATION Debug ===
[...]
=== BUILD TARGET Media Test OF PROJECT Media Test WITH CONFIGURATION Debug ===

Check dependencies
The “Swift Language Version” (SWIFT_VERSION) build setting must be set to a supported value for targets which use Swift. This setting can be set in the build settings editor.
The “Swift Language Version” (SWIFT_VERSION) build setting must be set to a supported value for targets which use Swift. This setting can be set in the build settings editor.

** ARCHIVE FAILED **

For future reference, the plugin & test application I'm developing, along with the scripts I'm using for building them, are available at this commit: https://github.com/jh3141/cordova-plugin-mediacentre/commit/c28ef4c65150e3c7bd38eb3a6e9f27c34465a311

Hmm.  Looking at this in more detail, it seems that while plugman install happily suggested it was installing the swift support plugin, it seems as though it seems as though it has failed to install the hooks: running cordova prepare ios --verbose includes the following:
No scripts found for hook "after_prepare".

I therefore suspect that this is user error.  Sorry about that. :)


I can't add repository / install app.

Pull down menus allowing to install apps are disabled with 'refreshing cache' message below. Uninstalls/reinstalls didn't help. SailfishOS 2.1.4

It turned out installation of 3rdparty apps was disabled in SailfishOS. So, closing the issue.