MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #4.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed

Fixes #4

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

ℹ No valid build backend found for Python recipe for package dvg-ringbuffer using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
ℹ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.

For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

ℹ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12448648587. Examine the logs at this URL for more detail.

@conda-forge-admin rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin relint


Support for v1.2 of Azure python sdk

This problem refers to #444
I am working with smart_open for Azure blob storage, but I'm working on a codebase that uses the older API interface by azure i.e. v2.1 which provides BlockBlobService. I see in the client this accepts BlobServiceClient. Could it be used with BlockBlobService?
Talking about this version here.
In the current code if I try to use v2.1 client like
from azure.storage.blob import BlockBlobService
from smart_open import open as sopen

client = BlockBlobService(account_name='account-name', account_key='secret-key')

sopen('azure://{0}/{1}'.format("container", "file"), 'wb', transport_params=dict(client=client))

I get an error:
AttributeError: 'BlockBlobService' object has no attribute 'get_container_client'

which hints over API differences in v2.1 and v12.0
Would we implement smart_open for azure v2.1 python-sdk too? If yes, would like to contribute.

Why would we want to support a much older version of the API? Is it somehow more popular or commonly used?
If possible, I would prefer to avoid it.

the 1.2 and 12.0 versions don't play well with each other at all.  I recently moved some of my other code to 12.0  I would suggest getting there as soon as possible.

Can we please change the title to "Support for v2.1 of Azure python sdk"?

I agree with the comments above. I do not think we should add backwards compatibility for a depreciated SDK. Seems like if @prakharcode needs this he should fork and build it himself.

Yes, I'm implementing a version for v2.1 myself, v2.1 SDK was implemented earlier in my project and according to Microsoft's package timeline v2.1 was deprecated in May 2020 only, hence there might be some project with v2.1 implementation.


Move generate_feature_maps_file() from CLEVR to GenerateFeatureMaps

In order to enable reproducible VIGIL experiments, and make CLEVR a lighter class:
Move most of the complexity of CLEVR.generate_feature_maps_file() to GenerateFeatureMaps\

that would be the first step towards VIGIL experiments on Miprometheus documentation

Formalize the hack about reusing CLEVR embeddings weights for CoGenT
grid configs for finetuning

grids configs for testing, mutex for accessing same image file at same time?

forget about EMA


add support for gdrive public file download

This PR adds support for downloading public files from google drive using only the shared url. It uses the gdown library to perform the download.
Usage
from meddlr.utils import env

path_mgr = env.get_path_manager()

# Fetch, cache, and return local path for public google drive file
# 1. Full url (recommended)
file_path = path_mgr.get_local_path("gdrive://https://drive.google.com/file/d/14VQf4esuZVy_Xf6IUciBas81j0JpaqCb/view?usp=sharing")

# 2. id only
file_path = path_mgr.get_local_path("gdrive://14VQf4esuZVy_Xf6IUciBas81j0JpaqCb")

# 3. With download directive (requires full URL)
file_path = path_mgr.get_local_path("download://https://drive.google.com/file/d/14VQf4esuZVy_Xf6IUciBas81j0JpaqCb/view?usp=sharing")

The main work is done by the GoogleDriveHandler
handler = GoogleDriveHandler()
handler.get_local_path("gdrive://https://drive.google.com/file/d/14VQf4esuZVy_Xf6IUciBas81j0JpaqCb/view?usp=sharing")
# OR
handler.get_local_path("gdrive://14VQf4esuZVy_Xf6IUciBas81j0JpaqCb")

Caveats

The file must be publicly viewable with a shared link
Dependency on gdown
Only tested with files, not folders

Todos

[x] Add PathHandler for Google Drive files
[x] Add PathHandler for generic downloading (currently only support GDrive download)
[x] Add gdown to optional download

Codecov Report

Merging #12 (36ab536) into main (ac8dbcd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   57.95%   57.95%
=======================================
  Files          76       76
  Lines        5589     5589
  Branches     1122     1188   +66
=======================================
  Hits         3239     3239
  Misses       2044     2044
  Partials      306      306

Flag
Coverage Δ

unittests
57.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8dbcd...36ab536. Read the comment docs.


Repackage okhttp

In my android project I already included okhttp as a native binding. This causes duplicate addition of okhttp classes during build:
/Library/Frameworks/Mono.framework/External/xbuild/Xamarin/Android/Xamarin.Android.Common.targets: Error: Tool exited with code: 1. Output:
UNEXPECTED TOP-LEVEL EXCEPTION:
java.lang.IllegalArgumentException: already added: Lcom/squareup/okhttp/Address;
	at com.android.dx.dex.file.ClassDefsSection.add(ClassDefsSection.java:122)
	at com.android.dx.dex.file.DexFile.add(DexFile.java:161)
	at com.android.dx.command.dexer.Main.processClass(Main.java:732)
	at com.android.dx.command.dexer.Main.processFileBytes(Main.java:673)
	at com.android.dx.command.dexer.Main.access$300(Main.java:82)
	at com.android.dx.command.dexer.Main$1.processFileBytes(Main.java:602)
	at com.android.dx.cf.direct.ClassPathOpener.processArchive(ClassPathOpener.java:284)
	at com.android.dx.cf.direct.ClassPathOpener.processOne(ClassPathOpener.java:166)
	at com.android.dx.cf.direct.ClassPathOpener.process(ClassPathOpener.java:144)
	at com.android.dx.command.dexer.Main.processOne(Main.java:632)
	at com.android.dx.command.dexer.Main.processAllFiles(Main.java:510)
	at com.android.dx.command.dexer.Main.runMonoDex(Main.java:279)
	at com.android.dx.command.dexer.Main.run(Main.java:245)
	at com.android.dx.command.dexer.Main.main(Main.java:214)
	at com.android.dx.command.Main.main(Main.java:106)
1 error; aborting

If you ship ModernHttpClient with an embedded version of okhttp you should probably repackage okhttp (e.g. using jarjar) so that it is possible to used it side-by-side with other dependencies. Another solution would be to extract okhttp into its own component.

Can't you just remove your copy of OkHttp?

Fixed? Maybe?

Ran into this. Have Project A referencing Project B and OkHttp. Project B is also referencing Project OkHttp. When I try to run Project A I get this error. The solution is to manually remove the OkHttp reference from the project.
If you are using nuget (In my case, Project B was nuget). You must add Project B and OkHttp to your project and then manually remove the reference from project A to 'trick' it into working.


Add ability to pass 'id' attribute for content

This adds compatibility with react-scroll. react-scroll needs to have an id for the container element (see example)

This feature was added in #160 instead.
Sorry no one acknowledged your PR. This project hasn't been maintained for sometime.


Document return codes in --help

I regularly use the robot and rebot scripts, notably in CI. When reading their --help, they give no clear indication of what their exit_code/return_status will be.
They both have a --nostatusrc :

Sets the return code to zero regardless are there failures. Error codes are returned normally.

It's not clear to me what it means that "Error codes are returned normally" when "Sets the return code to zero". I think I don't know the nuance between "error code" and "return code".
And if I am not setting this option, what should be the normal error codes ?
I have found 3.1.3 Test results / Return codes in the UserGuide, which states the expected results codes for robot :

0 = all pass
1-249 = corresponding number of failing tests
250 = more than 250 tests have failed
251 = help
252 = bad command
253 = ctrl+C
254 unused ?
255 = unexpected internal error

Could a summary of that be included in the Robot help message ? robot/run.py#L46
I can open a PR if you are interested.
Also, the same applies to rebot. There is note in 3.1.3 Test results / Return codes that indicates that it is the same for rebot, so could it be added to its help message too ? robot/rebot.py#L46

--no-status-rc makes robot to return 0 if execution can be done regardless are there failing tests or not. You'll get a non-zero return code if tests cannot be run at all due to, for example, invalid command line options or non-existing files.
If you have ideas how to make the documentation more clear, please submit a PR. I guess documenting the return codes also in --help would be a good idea.

Thank you very much !


Add ios pipeline

This PR

adds a pipeline to check the ios build
removes the iOS WaitUntil workaround, which doesn't seem to be necessary anymore after the winit update (and caused the build for iOS to fail again because of a missing self
~removes a iOS workaround for window size which doesn't seem necessary anymore~
Turns out it was still needed (but you need to actually restart the app for the issue to show up, so I didn't catch it first)
fixes some cargo check errors in run.rs

I've done all these changes in a single PR because otherwise the pipeline doesn't run but I can also split them in separate PRs if that makes it easier to review

@emilk finally got around to fixing the lint warnings, sorry it took so long


PermissionDenied when trying to get a user using Zitadel dotnet SDK

Hi, I'm using Zitadel dotnet SDK to get a user, I used the PersonalAccessToken method as shown in the example, I gave the service user IAM Owner permission in the instance as well as Organization Owner in ZITADEL org and generated a new PAT, however, I always get this error when calling the Method: GetUserByIDAsync in UserService Grpc.Core.RpcException: Status(StatusCode="PermissionDenied", Detail="Bad gRPC response. HTTP status code: 403")
I injected the clients this way:
services.AddScoped(sp =>
{
    return Clients.AuthService(new(auhthorityUrl, ITokenProvider.Static(personalAccessToken)));
});

I'm on version v2.64.1

I found the solution, It was cloudflare that was blocking the grpc connection, I had to enable it in Network > enable Grpc, in cloudflare dashboard


Making additional client certifications?

I was able to add a few client to Simian w/o issue.  Now I'm looking to do a bigger deployment, but how can I make more certificates w/o have to delete all the certs from the app engine, redoing all the private keys, and have to re-do the clients that are currently working.  I tried doing the export CA="my password" and then running the command to make the certs, but I got an error about not finding the key.  Any help would be greatly appreciated...Thanks again for all your work on Simian!!!!

TL;DR:  supporting multiple certificate authorities in Simian is not straightforward, and not documented, and can only be done if you have significant experience with Python and some App Engine development chops.
We have functionality to support multiple certificate authorities, and we've used it internally to migrate from one CA to another, but we've never tested it in our open source app, and thus never documented it.  It may or may not work.  Unfortunately we cannot support it at this time, as it would take a lot of effort to streamline for non-developers.  But I'll provide pointers in case you have the requisite experience to proceed.
GetCaId() loads CA_ID from the settings/config file, and defaults to None if that (undocumented) variable doesn't exist: https://github.com/google/simian/blob/master/src/simian/auth/util.py#L65
The client will use this value (if present) to instruct the server which CA it's using, which effects which private_key/public_cert pair is loaded from App Engine Datastore's "Settings" model.  You should be able to use Datastore Viewer to see the server_private_key_pem and other keys in that model today, as uploaded in the admin web UI.  You'd have to write some Python code to use the Datastore API to write additional entities to the settings table, similar to the existing ones but with a prefix matching CA_ID in the clients using the new CA: https://github.com/google/simian/blob/master/src/simian/auth/util.py#L124
If that all makes sense and you need a little more guidance, I'm happy to answer questions.  If it seems too difficult, it's because it is, and it would take many, many hours to make easier, unfortunately.  We can leave this issue open to use as a feature request for making this process easier.

Sorry, thats not what I was trying to ask. My fault.
I want to be able to make my own certificates in an on-demand manner.  I followed the wiki about openssl and I made certificates for all my test machines and everything worked.  Now I want to deploy to more clients, but I can't seem to get the process to run w/o starting over with the whole how-to.
That would require me to delete all my current clients and the keys from the data store and start re-adding the clients that are working.
This is the part I need to be able to do w/o remaking the CA identity, server identity, etc:
for serial in $(cat serials.txt) ; do
rm -f client.csr
openssl req -config openssl.cnf -sha1 -new -nodes
-out client.csr
-keyout private/${serial}.pem
-subj "/CN=${serial}"
openssl ca -config openssl.cnf -in client.csr
-md sha1 -days 3650 -notext
-cert newcerts/ca_public_cert.pem -keyfile private/ca.key
-out newcerts/${serial}.pem
-policy policy_anything
-passin env:CAPASS -batch
done
Does that make more sense?

Hi mjosh20
can you verify that all of the files like private/ca.key openssl.cnf etc still exist and that you are in the right portion of the directory tree? cd to the top of the path that contains all of those subdirectories like newcerts/ private/ etc and verify what you see in there. perhaps paste it here.
also prior to running the openssl commands, are you sure you entered:
export CAPASS="your passsword"
and not just
CAPASS="your password"
?
the first one (export...) is what you need.

....................++++++
writing new private key to 'private/00000000001.pem'
Using configuration from openssl.cnf
unable to load CA private key
59460:error:0906A065:PEM routines:PEM_do_header:bad decrypt:/SourceCache/OpenSSL098/OpenSSL098-52.8.1/src/crypto/pem/pem_lib.c:428:
Generating a 1024 bit RSA private key
..++++++
..........++++++
I think it has something to do w/ the fact that I don't remake the server identity in the process.  I go from the export CAPASS to running the script to make the client certs.
Thoughts?

you need to verify that newcerts/ca_public_cert.pem and private/ca.key still exist.
you should perform these new client cert generations from the top level directory in which those newcerts/ and private/ directories descend from.

They still exist in the correct folders.

I still get the error no matter what I try.

I deleted CA and all the certificates from the appengine and started fresh.  I made ~10 client certs w/o any issue.  I then try to make a few additional ones.  I run the export CAPASS='MY PASSWORD HERE', then I run the the script that generates the certs.  I no longer get the error I was getting but I get the following:
        X509v3 Basic Constraints:
            CA:FALSE
        Netscape Comment:
            OpenSSL Generated Certificate

The private key appears to have generated but the other one is blank.  I assume its due to the CA: False part in the output.  I'm positive its still in the CA/private.  Is there a way to make a 2nd round of keys w/o remaking the CA.key?

Hi mjosh20
there should be no problem running the client private key and create cert with client private key + signed w/ca private key commands in more than one iteration.
The paste you have supplied is fine, CA:FALSE, if it is from openssl x509 -in clientcert.pem -text . The client certs should not have CA:TRUE because they are not CA certs and should not be used for signing.
The CA cert will show CA:TRUE, example:
:/tmp/CA$ openssl x509 -in newcerts/ca_public_cert.pem  -text
...
            X509v3 Basic Constraints:
                CA:TRUE

After your initial pass of 10 client certs did you populate serials.txt with more serial numbers, assuming that you are using our wiki cli cut/paste directly?

Yes, I added more of them to the end of it.  Your assumption is correct.
Additional note: The one client cert is coming out completely blank.  And the other one is similar to the first run but not exactly the same.

Ok, so by your wording "I added more of them to the end of it" it sounds like you are probably instructing openssl to re-create private keys and signed certs for each client, including the ones you already generated this for. You don't want to do this.
Part of this confusion may be because we suggested that you could name the subject of your host after the Apple serial number of the hardware and refer to serials.txt etc. However each x509 cert also has a serial number field which is a x509 cert property and has no relation to the hardware.
So if you start with this list
serial1
serial2
serial3
And generate keys/certs, but then append
serial4
serial5
You will re-create serial1,2,3 again (or possibly it will produce errors) and also generate new serial4,5.
The way that shell loop is written is such that you really only want serials.txt to contain the new items to work on, not all the prior items too. We could make our shell snippet smarter about repeats, but then you're starting to get more complicated...
can you try just making serials.txt contain new items to create and see if it works?

I revised our wiki documentation to try to make it more clear that by throwing names into a text file and iterating over them with shell we are choosing commonName values for each certificate, and to remove any confusion that it's related to the x509 serial number.

That worked.  I noticed the changes when I copied them and it said the file didn't exist, then I got your message. :)
The new code will work just like before, except I need to change the name of my serials.txt correct?

Yes, all I did was go into the text and change serials.txt to cns.txt
anywhere I saw it, and also renamed the variable serial to cn. I also added
some extra wording to clarify that while we are suggesting that perhaps you
could name each certificate with the CN=machineserialnumber, this is only a
suggestion and is not related to the x509 certificate serial number, which
is maintained by openssl. You seed it at "1" with the "echo 000001 >
serial" line earlier in the instructions.
On Wed, Feb 11, 2015 at 1:59 PM, mjosh20<EMAIL_ADDRESS>wrote:

That worked. I noticed the changes when I copied them and it said the file
didn't exist, then I got your message. :)
The new code will work just like before, except I need to change the name
of my serials.txt correct?
—
Reply to this email directly or view it on GitHub
https://github.com/google/simian/issues/11#issuecomment-73941261.


some plugin have plugin formats that work only with certain architectures

'Note : MacOS Audio Unit supports Intel architecture only. Use the VST variants for ARM support.'
https://github.com/igorski/fogpad/releases/tag/1.0.3-3.7.10
yaml structure does not account for this possibility

It is common for plugin authors to provide separate zip files per architecture. Otherwise you are downloading plugins you can't run.
Open Audio Stack Registry assumes one architecture per file, and I think it's a good standard to enforce.
This ticket could be opened for the plugin author to separate out architectures into different release files.


Optimized tests

In the tests we are currently listing all Spaces on the Hub 3 times. This is not necessary and takes a huge amount of time (almost 1min only for that). This PR fixes this :)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Android builds are failing on servo-linux-cross3

We've tried re-highstating servo-linux-cross3; jury is still out on the last highstate, but previous attempts have not fixed the problem.
I'm not well versed with Android, but I have a new idea about what might be going wrong:

The relevant builds (e.g. http://build.servo.org/builders/android/builds/6778/steps/compile/logs/stdio) are currently failing in the /mach build --android --dev step
In buildbot_steps.yml, we only override the ANDROID_SDK variable for the ./mach package step, not the ./mach build step, so the current SDK symlink takes precedence
#644 has not yet been deployed to -cross1 and -cross2, only -cross3:

Both -cross1 and -cross2 still have the older r24.4.1 SDKs on disk, while all three have the new r25.2.3 SDK on disk.
-cross1 and -cross2 have the old SDK as current, while -cross3 has the new SDK as current.

Is it feasible that ./mach build --android --dev is failing due to getting the new r25.2.3 SDK on -cross3, while working OK with the r24.4.1 SDK on -cross1 and -cross2?
cc @larsbergstrom @MortimerGoro

OK, reproduced the failure on servo-linux-cross2 with the above test PR (see http://build.servo.org/builders/android/builds/6786), SDK 25.2.3 breaks ./mach build --android --dev.

This line in blurdroid dependency is the one causing the problem:
https://github.com/szeged/blurdroid/blob/master/build.rs#L64
The problem is that when SDK 25.2.3 is enabled, only android-25 platform is installed. When r24.4.1 is enabled only android-18 platform is installled. Blurdroid dependency has android-18 path hardcoded...
Possible solutions:

Add an array of platforms to saltfs instead of using a unique android-platform
Fix hardcoded path in blurdroid dependency

Making platforms into an array in saltfs is a fairly easy change. However, IMO it makes more sense to update blurdroid, then send a servo/servo PR with that change (and also fixing buildbot_steps.yml to pass the ANDROID_SDK var for ./mach build) for a few reasons:

Easier to test servo/servo changes since there's no need to revert as with saltfs changes
It doesn't seem like anyone else depends on blurdroid: https://crates.io/crates/blurdroid/reverse_dependencies
This avoid having multiple platforms, which seems like it could easily cause problems later

Also, I just noticed we should update the servobuild.example file as well at some point.

It might also make sense to use an environment variable for the platform version in blurdroid, and set that from buildbot_steps.yml / saltfs.

Yes, good reasons to update blurdroid.
I'll do the PR to blurdroid, it's a easy change too.

Thanks for the PRs @MortimerGoro! I just grepped servo/servo and I still see android-18 in a few places and saw it used in the build log for servo/servo#16812, so I think we need to update this in more places if you want to take a look. I'm going to run a force build on cross3 to check in the meantime.

@aneeshusa the android-18 in the log are related to Android NDK (C++) which is a different SDK (it has all the platforms included). I think that there aren't more dependencies in Servo that use Android SDK (java). So the cross3 build should work

I didn't know that about SDK vs. NDK, thanks for the explanation. Indeed, the force build succeeded: http://build.servo.org/builders/android/builds/6858
I'm going to roll out #644 to cross2 and cross1 now, since this appears to be working. Closing this issue.


Expose create and deploy API

For the Wizard project team so they can flow into a create and deploy scenario after creating an app.

Closing this due to the fact that we decided that the intern team wouldn't need a fully functional API


Update README and add license

Just some initial setup stuff.
cc @jamesls @mtdowling @rayluo @JordonPhillips

:shipit:  You'll also need a NOTICE file.

@jamesls I updated the license and added a notice. Let me know if that looks fine.

:shipit: Looks good.


Parsing quirks

\\. should be an alias of QzBSOL_., i.e. a module literal. Instead it's read as QzFULLxSTOP_. Not sure how that happened, but full stops are handled separately, and this seems wrong.
It is currently possible for a reader macro to start with : e.g. (defmacro :QzHASH_ (..., which doesn't seem like the ideal way to say it. This ends up adding a non-identifier string to the _macro_ namespace, which prevents attribute-access symbols like _macro_.:QzHASH_ from working. I'm not sure what \:\# should be.  Making it :QzHASH_ would work for the defmacro, but it doesn't make a lot of sense. Maybe the \: should suppress the control word interpretation, making it QzCOLON_QzHASH_? But then the reader macro usage would have to be spelled \:#foo, which isn't as nice. Should control words be disallowed as reader macro names? Should they always be treated like the first character is escaped? Maybe just colons? I will have to think about this some more.
Reader macros with extras could be more compact if symbols weren't allowed to contain !. Then you could say foo#!1!2!3 bar instead of foo# !1 !2 !3 bar or foo#!!! 1 2 3 bar. You could still escape them, like any other character. But there are conventions where mutating/dangerous functions end in a !, and now they'd have to end in a \!, which isn't as nice. Maybe there's some way to avoid that. Extra could maybe use some other character instead of !. Lisp's symbols can contain more characters than Python, but that also means you need spaces to separate things in situations Python wouldn't. I'm not really satisfied with the whole Extra system, but I don't have a better idea yet.

If we get rid of collection atoms, #130, that frees up the []{} characters for other things. We could write extras in square brackets, like foo#[1 2 3]bar, foo[1 2 3]#bar, or even foo[1 2 3]bar, in which case, non-extra macros might be written foo[]bar? I'm not sure how easy this is to parse yet, or how it would interact with tooling like Emacs or Parinfer.
A comment string now turns out like this:
(exec
  <<#[
  ;for i in 'abc':
  ;    for j in 'xyz':
  ;        print(i+j, end=" ")
  ;print('.')
  ;
  ]#"\n")

The single leading ; is bad though. Emacs would indent them to the margin. (Which would still work though.) You could avoid that with ;;. The macro could easily strip the first character of each line:
(exec
  <<#[
  ;;for i in 'abc':
  ;;    for j in 'xyz':
  ;;        print(i+j, end=" ")
  ;;print('.')
  ;;
  ]#"\n")

But now Parinfer wouldn't like the brackets here and would have to indent them at least this much:
(exec
  <<#[
      ;;for i in 'abc':
      ;;    for j in 'xyz':
      ;;        print(i+j, end=" ")
      ;;print('.')
      ;;
      #_/]#"\n")

It wouldn't care about the comments' indentation, but if we want them aligned with the other elements, that's where they go. Parinfer also wouldn't allow a closing bracket to start a line like this, so it needs the final discarded item. Square brackets are maybe nice for inline extras, but this seems worse if they span multiple lines.

# is now the macro for sets. But _macro_.# is still read as a reader macro. Probably reader macro names should not be allowed to end in a dot.

## should probably be a single-character reader macro. It's currently a symbol. \## works though.

. is a module handle. For the empty-named module. Which is weird. That would totally be a syntax error in a Python import statement. Empty is not a valid identifier, and can't be munged to one. This should probably just be a symbol: QzFULLxSTOP_.

.. is a SyntaxError. ... is Ellipsis. Four or more is likewise a syntax error. This is related to . being the empty-named module. Maybe these errors should be symbols too?

[# is now a macro for the subscript operation, particularly good for slices. So that's kind of claimed again.

The EDN Hissps have claimed . to represent :, since that's not allowed in EDN, and Hissp needs it.
The X# series is often combined with inject to turn a Python expression into a function, e.g. XY#.#"Y-X". It would be slightly nicer to do XY.# instead. This saves all of one character in Lissp, which is why I didn't bother, but in the EDN Hissps, where inject is currently has a longer spelling (#XY #hissp/."Y-X"), this is a much bigger win: #XY."Y-X".
The dot is the natural choice here (though not the only one), but it would have to munge for the attr in macro to be a valid identifier. It can currently be defined using X\.\#, but the tag still has to be spelled X\.#, negating the 1-character saving, and probably requiring the full spelling of the munged name in EDN Hissps. The munger needs to leave dots alone for attr access and module handles, so tags with a trailing (or leading?) dot would have to be special cased in the respective readers.

I'm noticing that the desired interpretation of XY.# as a XYQzFULLxSTOP_ tag and _macro_.# as a _macro_.QzHASH_ attr are incompatible. Of course, XY\.# and _macro_.\# would disambiguate, but one or the other shouldn't have to.
Tags have no particular need for a leading dot either, so .XY# should maybe be allowed (as a QzFULLxSTOP_XY tag), freeing up the trailing dot for the attr interpretation. Are dots even allowed in EDN tags though? If so, where? I was paying attention to those details when writing garden-of-edn, but I need to check that again.

Looks like EDN tags can't start with a dot (must be alphabetic after the #), but the part after the prefix/ (the name) could, as long as the next character is not a digit.

Found another one:
#> (.hex : self 42.0)
>>> self=(42.0).hex()

This happens to compile to a valid assignment, which is interesting. Only at the top level though. It's a little too situational to be very useful and it's nonsense when nested. Not worth keeping. But is it worth fixing? The fix would probably be to make it an error, but it's already that (except at the top level, where it's not, but not useful either).

Actually, it does work nested. Sometimes.
>>> print(
...   end=(42.0).hex())
0x1.5000000000000p+5#>

Still seems too situational to be useful. I still kind of think this should be an error, and seeing how it's not just a top-level problem makes me more inclined to fix it.


Deployment Errors

Hi Matt,
As mentioned before, we're trying your workshop again and we're facing a lot of deployment errors. All of them with the same message:
{
"status": "Failed",
"error": {
"code": "VMExtensionProvisioningError",
"message": "VM has reported a failure when processing extension 'ConfigureHybridHost'. Error message: "DSC Configuration 'HybridHost' completed with error(s). Following are the first few: WinRM cannot process the request. The following error with errorcode 0x80090350 occurred while using Negotiate authentication: An unknown security error occurred.  \r\n Possible causes are:\r\n  -The user name or password specified are invalid.\r\n  -Kerberos is used when no authentication method and no user name are specified.\r\n  -Kerberos accepts domain user names, but not local user names.\r\n  -The Service Principal Name (SPN) for the remote computer name and port does not exist.\r\n  -The client and remote computers are in different domains and there is no trust between the two domains.\r\n After checking for the above issues, try the following:\r\n  -Check the Event Viewer for events related to authentication.\r\n  -Change the authentication method; add the destination computer to the WinRM TrustedHosts configuration setting or use HTTPS transport.\r\n Note that computers in the TrustedHosts list might not be authenticated.\r\n   -For more information about WinRM configuration, run the following command: winrm help config."\r\n\r\nMore information on troubleshooting is available at https://aka.ms/VMExtensionDSCWindowsTroubleshoot "
}
}
Could you please help us understand why is the error occurring and what can we do to correct it? We're just using your ARM template deployment as is.
Thanks,
Francisco

Feel free to ping me and we can have a look together

It may be that DSC hits an error, Azure ARM marks things as "Failed" but the deployment happily continues inside the VM - I've seen this occasionally. Handling reboots is tricky from the ARM / DSC side.

I tried to follow that troubleshooting guide:

Tried to re-apply the DSC configuration, all went great and a reboot was done. After that:

Right - but if you run:
cd "C:\Packages\Plugins\Microsoft.Powershell.DSC*\DSCWork\hybridhost.0\HybridHost"
Start-DscConfiguration -Path . -Wait -Force -Verbose
Does it run through to a clean completion?

It may be there are a better set of "manual" DSC commands that will allow better visibility into currently running DSC configurations etc - I'm not an expert on those but will investigate.

I run that before the reboot. So a did a Get-DscConfigurationStatus, did a Start-DscConfiguration (it was rebooted), and a Get-DscConfigurationStatus. And the output was what I shared with you. If I run again the Start command, it runs and creates new recources, but some fail:

If I do another get, this is the outcome:

I can see stuff created (like WAC), but only with one host

So I don't think it did a clean installation

OK thanks - so Get-DSCConfigurationStatus will always fail with an error is there is a currently running DSC configuration. I'll need to update the docs there.
If deploying the Azure VM returns an error in the portal, i'll document some more accurate steps to check and then re-run the DSC correctly. It may be that the Volume creation has hit a locking issue and with no V:\ volume, subsequent steps can't be completed.
if the DSC has stopped for you, you could go ahead and delete/clean up the Storage Spaces, close all PS windows, and re-run and see if that fixes things.
Thanks,
Matt

Thanks Matt. If you can have a look that would be great. We really want to use your workshop for our program, and we want to make sure everything is working properly :) Let me know when you have an update

Will do - currently have a deployment running that's been going for ~40 mins, so i suspect it will succeed. Kept all the defaults or the VM, E16, EastUS etc.

Success:

Did you choose anything different from the template defaults?

Yes, I chose Premium Disks, E32s_v4 and UK South...
Already tried with the default options and it worked great!


398 remove unit conversions from tada harmonization template

Unit conversions can be customized in TADA_ConvertResultUnits.
The new function TADA_CreateUnitRef is used to create a reference df based on TADA priority characteristics (then WQX/USGS targets). This function is run within TADA_ConvertResultUnits if "tada" is selected as the ref. It can also be run by the user to create a draft unit ref that can be customized for use within TADA_ConvertResultUnits.
Temperature conversions now happen along with all other conversions.

I'm taking a look at the test failure issues.

Still have work to do regarding harmonization tests.

@cristinamullin - this is ready for your review

Codecov Report
Attention: Patch coverage is 76.69173% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 48.51%. Comparing base (47fd788) to head (b9d2649).
 Consider uploading reports for the commit d2cb12a to get more accurate results

Files
Patch %
Lines

R/UnitConversions.R
73.63%
58 Missing :warning:

R/Transformations.R
81.81%
2 Missing :warning:

R/Utilities.R
93.75%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #448      +/-   ##
===========================================
+ Coverage    46.21%   48.51%   +2.29%
===========================================
  Files           14       16       +2
  Lines         3410     3941     +531
===========================================
+ Hits          1576     1912     +336
- Misses        1834     2029     +195

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update active-directory-aadconnectsync-attributes-synchronized.md

Fixed the Exchange hybrid writeback attribute names to reflect the correct names in AD.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: adamfowlerit sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@adamfowlerit - Hi Adam, this contribution triggered the contributor license agreement (CLA) requirement; for us to move ahead, the CLA needs to be signed.

@adamfowlerit : Thanks for your contribution to the Azure documentation! The author, @billmath, has been notified to review your proposed change.

#do-not-fix
The attributes list is using the LDAP DisplayName value and not LDAP cn, because that is what the sync engine manager and sync rule editor is using. If making the proposed change, it wouldn't match what is visible in Connect itself. The document wasn't written to show the attribute names found in Active Directory Users and Computers but what you will find in the Connect UI.

That's fair, can we have references to both then? To lock down the security it needs to be done at the AD end and someone following this guide to do so may not be able to find it easily.

We could add a new column with how it looks like in AD as well. I don't have a problem with that.

@adamfowlerit can you update with the following:

Attribute Name (Connect UI)
Attribute Name (On-premises AD)
User
Contact
Group
Comment

msDS-ExternalDirectoryObjectID
ms-DS-External-Directory-Object-Id
X

Derived from cloudAnchor in Azure AD. This attribute is new in Exchange 2016 and Windows Server 2016 AD.

msExchArchiveStatus
ms-Exch-ArchiveStatus
X

Online Archive: Enables customers to archive mail.

msExchBlockedSendersHash
ms-Exch-BlockedSendersHash
X

Filtering: Writes back on-premises filtering and online safe and blocked sender data from clients.

msExchSafeRecipientsHash
ms-Exch-SafeRecipientsHash
X

Filtering: Writes back on-premises filtering and online safe and blocked sender data from clients.

msExchSafeSendersHash
ms-Exch-SafeSendersHash
X

Filtering: Writes back on-premises filtering and online safe and blocked sender data from clients.

msExchUCVoiceMailSettings
ms-Exch-UCVoiceMailSettings
X

Enable Unified Messaging (UM) - Online voice mail: Used by Microsoft Lync Server integration to indicate to Lync Server on-premises that the user has voice mail in online services.

msExchUserHoldPolicies
ms-Exc-hUserHoldPolicies
X

Litigation Hold: Enables cloud services to determine which users are under Litigation Hold.

proxyAddresses
proxyAddresses
X
X
X
Only the x500 address from Exchange Online is inserted.

publicDelegates
ms-Exch-Public-Delegates
X

Allows an Exchange Online mailbox to be granted SendOnBehalfTo rights to users with on-premises Exchange mailbox. Requires Azure AD Connect build 1.1.552.0 or after.

@AndKjell  let me know about the headers if the look okay.
Thanks!

Looks like it turned my markdown into the table.  Not sure if you can pull the table from the comment in raw markdown.  Let me know.  Otherwise I can create a private pr and pull this in and we can close this one.

Those column names works just fine for me.

hey @billmath - can you make the change yourself with the markdown file, otherwise I will have to hack it together from the formatted comment above.  I can close this request once you go ahead with the update.  Otherwise - can you send me the markdown file and I can incorporate it in this PR?

@adamfowlerit  I went ahead and added this and it has been merged.  It should be live tomorrow after 10:30 PST.  Thanks for the submission.  I am going to go ahead and close this one.  Thanks!
#please-close


Adding bower.json and uglified dist version

I ran into PDFKit earlier today and I want to use it as a dependency for a few things, and noticed it didn't have a bower.json. It's also hard to use with bower if the only non-browserified distributable version is built in a release. So I added uglify-js as a dev dependency and added a few lines to the Makefile that create a dist folder with a minified version in, then added a bower.json.
Wasn't sure what to use as the contact email, please let me know if I should amend!

I don't really want to maintain yet another version for another package manager. My suggestion is to just use npm and browserify.

Fair point. TBTH I've barely used Bower since I started using Webpack a few months ago, and given this package is much more likely to be used on something server-side, having Bower is a bit unnecessary. So, good decision. :+1:

@devongovett @aendrew Even with as popular as bower is these days? I'm going to use [this third-party mirror], but it'd be much nicer to have first-party support.

My understanding is that development on Bower has pretty much stopped. Read this: https://github.com/rackt/redux/issues/944#issuecomment-154858804.
I have no plans for Bower support, and if you are using Bower, I'd recommend moving to npm as soon as you can.

@mattblang Pretty much what @devongovett said. Bower isn't popular any more. Are you using Bower through a Gulp-based build system (I.e., via Yeoman)? Then there's absolutely no reason not to use something like Webpack or Browserify for your build process, and use npm for your dependency management. I've submitted a dozen or so PRs like this, and am now closing any that are open because Bower isn't really necessary any longer (It was brilliant two years ago, but in modern ES2015 module management land, it's way more effort than it's worth).
Obligatory link to That Cube Drone Comic.

@aendrew - a lot of people still use bower, myself included. why not make your library more convenient?

@booleanbetrayal Lots of reasons, not least because Bower development has slowed to a crawl and it adds additional maintenance burden on library maintainers (needing to keep dependencies in bower.json up-to-date, in addition to package.json).
It's totally fine if you want to continue using Bower and not improve your practices, but library maintainers shouldn't feel the need to exert any extra effort in order to help you do so.
My two cents, anyhow.

In the real world, it's not always possible to refactor every projects'
dependencies due to ideological shifts in the development community.
Nothing to do with best practices, desire, etc. Maybe something to consider.
On Nov 19, 2015 4:18 AM, "Ændrew Rininsland"<EMAIL_ADDRESS>wrote:

@booleanbetrayal https://github.com/booleanbetrayal Lots of reasons,
not least because Bower development has slowed to a crawl and it adds
additional maintenance burden on library maintainers (needing to keep
dependencies in bower.json up-to-date, in addition to package.json).
It's totally fine if you want to continue using Bower and not improve your
practices, but library maintainers shouldn't feel the need to exert any
extra effort in order to help you do so.
My two cents, anyhow.
—
Reply to this email directly or view it on GitHub
https://github.com/devongovett/pdfkit/pull/359#issuecomment-158026557.

Without spending too much more time on this — I'm really lost as to your point. Nobody's asking anybody to refactor anything.
All projects that use Bower will continue to work, and so long as Bower doesn't take down their centralised registry, it will be possible to grab the existing dependencies at the version that was referenced when the code was originally created. By this I mean I'll be able to clone one of my old frontend projects later on, do a bower install, and be on my way.
What's being considered is whether package maintainers should have to include and maintain another dependency graph in their projects, particularly when the package manager that uses it is decreasingly maintained.
goes back to working on not-real projects in the not-real world he supposedly works in...

Actually, you're talking about introducing an entirely new pipeline for client-side code if your existing pipeline is solely Bower dependent. It is extraneous for the end-user. Seeing as how the Bower is not dead, yet, nor has it officially been announced as such, and considering that most every client-side library out there instructs users to install with Bower, the rush to NPM-only dependency management seems premature and inconsiderate of end-users. There are a thousand different modules to bump versions, so I don't buy the argument of maintenance lift. That's all.

I'm going to close this discussion now. I'm not going to add official Bower support. However, if you would like to maintain a separate repo containing only the pre-built files for Bower, you can do that.


[Vagrant] make build fails with error "type reflect.StructField has no field or method IsExported"

Bug Description
[Vagrant] make build fails with error "type reflect.StructField has no field or method IsExported"
Version and Command Invocation
(The output of preflight --version)
Steps to Reproduce:
(How can we reproduce this?)

pull the latest changes
make build

Expected Result
make build should produce preflight binary
Actual Result
make build
go build -o preflight -ldflags "-X github.com/redhat-openshift-ecosystem/openshift-preflight/version.commit=dca05f9cd6cfe2cc2d3d13f684aa6323746bb9a4 -X github.com/redhat-openshift-ecosystem/openshift-preflight/version.version="0.0.0"" main.go
# sigs.k8s.io/json/internal/golang/encoding/json
../go/pkg/mod/sigs.k8s.io/json@v0.0.0-20211020170558-c049b76a60c6/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
../go/pkg/mod/sigs.k8s.io/json@v0.0.0-20211020170558-c049b76a60c6/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)

Additional Context
Updating go version to 1.17 fixes this issue

/assign


Create built-in ResourceSummarizer types for detecting common obfuscation patterns

Detection of common obfuscation patterns

Illegal Signatures: Classes, fields, and methods can be given bogus Signature attributes that break some decompilers (because they trust the content of the attribute to be well-formed).  We can:
-Detect these cases

List how many there are
List where they are (should be a separate screen, which is opened only upon request)
Allow automatically removing them with a single click

Bogus Annotations: Obfuscators can add bogus annotations that are very long to slow down decompilation, or abuse the name of the annotation to confuse the syntax of the decompiled code.

Long annotation names with no usage can be stripped.
Any class/member with more than one of the same annotation type can have duplicates of that annotation type removed, even if they are otherwise valid. Duplicate annotations are not allowed in source Java.

Self Inheritance: Attacking the class hierarchy resolution logic, obfuscators can make A extend B extends A or even A extends A. In these cases we can allow a single-click to delete all classes in those hierarchies since they are not referenceable at runtime and are useless junk.

Added in a297a8b0790fcf5b14484fa180a5b3e27a179d6f
https://github.com/Col-E/Recaf/assets/21371686/c68c66b0-7db7-4839-80e4-a88a06ba6721


[WIP] Update document manager

Depends on https://github.com/jupyter/jupyter-js-ui/pull/97

Thanks!


Set config and model paths dynamically from environment vars

Hello, I'm working on packaging this plugin as a snap for use on Ubuntu (and other Linux distros supporting snaps) and created the following patch to make the installation and runtime more flexible. This is particularly important for containerized packaging formats where hard-coded paths may point to immutable paths inside the container.
Some notes:

Without setting the environment variables the behavior will be unchanged as the variables will fall back to their current paths
I'm not wed to the names of the variables (GIMP_OPENVINO_CONFIG_PATH and GIMP_OPENVINO_MODELS_PATH) if there is some other standard naming that is preferred
I did not document this anywhere in case there are hesitations or concerns about officially supporting this feature, but I'm happy to add docs some place if there is interest

Hi @frenchwr,
First, thank you! Giving Linux users the ability to easily install these plugins is fantastic!
After quick review, these specific changes look fine to me -- I do want to do some Windows / Linux testing on my side with these changes, so give me a day or so to report back.
I do have a question outside of the scope of this PR, but still related to snap installation... Would it be possible for you to give a high level description of what the Snap installation will actually do? e.g. Will it invoke install.sh, or simply extract some bundled set of artifacts (like python virtual env.) from a previous installation? I think these details would help us to identify other possible 'gotchas' that our team can help address!
Best Regards!
Ryan

Hi @frenchwr  -  Thanks for the contribution! As I have been testing this, its uncovered a few other issues which we need to address to make this really work properly. @RyanMetcalfeInt8  has created a new snap branch and we'll target this PR to that branch and then I can add the rest of my changes on top to enable this functionality. Thanks!

Thanks @frenchwr ! I've created an issue that we can use to coordinate efforts: https://github.com/intel/openvino-ai-plugins-gimp/issues/152
Feel free to post any more details / updates there.


Substitution in a Dockerfile?

Hi!
I'm creating a multi project template for Visual Studio 2022. The base for my template is a ASP.NET Core Web App with Docker enabled and a couple of class libraries.
The Dockerfile that is generated from the ASP.NET Core Web App template looks like this:
FROM mcr.microsoft.com/dotnet/aspnet:6.0 AS base
WORKDIR /app
EXPOSE 80
EXPOSE 443

FROM mcr.microsoft.com/dotnet/sdk:6.0 AS build
WORKDIR /src
COPY ["WebApplication1/WebApplication1.csproj", "WebApplication3/"]
RUN dotnet restore "WebApplication1/WebApplication1.csproj"
COPY . .
WORKDIR "/src/WebApplication1"
RUN dotnet build "WebApplication1.csproj" -c Release -o /app/build

FROM build AS publish
RUN dotnet publish "WebApplication1.csproj" -c Release -o /app/publish /p:UseAppHost=false

FROM base AS final
WORKDIR /app
COPY --from=publish /app/publish .
ENTRYPOINT ["dotnet", "WebApplication1.dll"]

When I am creating my template I obviously want to substitute "WebApplication1" with the new project name. Using $ ext_safeprojectname$ does not work. How can I achieve substitution in the Dockerfile?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7ffd68f8-8ba6-f868-648c-2a2b6e8899b4
Version Independent ID: 52b9100f-d71c-7e9c-303f-76d1eafcfa20
Content: Add name parameters to project and item templates - Visual Studio (Windows)
Content Source: docs/ide/how-to-substitute-parameters-in-a-template.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

@lojoh -- Ludwig, thank you for your question and feedback.  Please see this link and let me know if it helps answer:

Environment replacement

Also, consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

cc @TerryGLee for awareness

@lojoh -- Ludwig, please see this as well:

Container Tools in Visual Studio

Hi!
Thank you for your reply. To further clarify what I am trying to achieve, a class in the project I am using to create the template looks like this:
using $ext_safeprojectname$.App.Controller;
using $ext_safeprojectname$.Domain.Interfaces;

namespace $ext_safeprojectname$
{
   //...
}

If I follow the guide to create a template and then use that template to create a new project the same class looks like this:
using Example.App.Controller;
using Example.Domain.Interfaces;

namespace Example
{
   //...
}

This is great and the same approach works for a lot of differrent filetypes such as nlog.config, appsettings.json etc. But it doesn't work in the Dockerfile. The new projects Dockerfile still looks like this:
FROM mcr.microsoft.com/dotnet/aspnet:6.0 AS base
WORKDIR /app
EXPOSE 80
EXPOSE 443

FROM mcr.microsoft.com/dotnet/sdk:6.0 AS build
WORKDIR /src
COPY [" $ext_safeprojectname$/ $ext_safeprojectname$.csproj", " $ext_safeprojectname$/"]
RUN dotnet restore " $ext_safeprojectname$/ $ext_safeprojectname$.csproj"
COPY . .
WORKDIR "/src/ $ext_safeprojectname$"
RUN dotnet build " $ext_safeprojectname$.csproj" -c Release -o /app/build

FROM build AS publish
RUN dotnet publish " $ext_safeprojectname$.csproj" -c Release -o /app/publish /p:UseAppHost=false

FROM base AS final
WORKDIR /app
COPY --from=publish /app/publish .
ENTRYPOINT ["dotnet", " $ext_safeprojectname$.dll"]

I tried environment replacement in the Dockerfile but it does not give me the results I want. Maybe I am doing something wrong or the variable substitution when creating a Visual Studio template does not work with Dockerfiles? I realize that this may not be an issue with the documentation and I will continue my search for the answer on the resources you suggested.

@lojoh -- Ludwig, thank you for your thorough followup and extensive research.  It seems this potential feature is not yet available.  Please add it as a suggestion here:

Use the new Suggest a feature for Visual Studio IDE menu item.
Suggest a feature, track product issues, and find answers in the Visual Studio Developer Community.

cc @TerryGLee for awareness
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


Magento2 acceptance test utils not available

Is there an existing issue for this?

[X] I have searched the existing issues

Run a Diagnostic and Paste Link Here
No response
Current Behavior
When running the magento acceptance tests, an error occurs because the DEV tools are not available.
The dev tools have to be available by request the current url:
https://[example].ddev.site/dev/tests/acceptance/utils/command.php
Currently I get the following error:
404 Not Found
nginx
Expected Behavior
The dev tools must be available to run.
Steps To Reproduce
Browse to: https://[example].ddev.site/dev/tests/acceptance/utils/command.php
Get error: Not found
Anything else?
The issue can be solved, by adding the following to the nginx config (pkg/ddevapp/webserver_config_assets/nginx-site-magento2.conf) after line 34.
Is there a variable for current working dir available?
location ~* ^/dev/tests/acceptance/utils($|/) {
root /var/www/html/src;  #Variable for working dir?
    # This endpoint runs `bin/magento` CLI, be aware that it needs more time to finish
    location ~ ^/dev/tests/acceptance/utils/command.php {
        fastcgi_pass unix:/run/php-fpm.sock;
        fastcgi_index  index.php;
        fastcgi_param  SCRIPT_FILENAME  /var/www/html/src$fastcgi_script_name;   #Variable for working dir?
        fastcgi_param  PATH_INFO        $fastcgi_path_info;
        fastcgi_read_timeout 600s;
        fastcgi_connect_timeout 600s;
        include        fastcgi_params;
    }
}

HI @rfay
thank you!
Yes! That's is what I meant. When running "ddev exec" that is my working_dir.
No, the location entry above doesn't work for this because the magento dev utils are not available in the document root.
For example:
Public magento files are located in the document root ($document_root) /var/www/html/pub
The magento dev utils are available in /var/www/html/dev
I'd like to create a pull request, but I need a variable for the working dir in the nginx config, not the document root.

@rfay That issues is not new for me, because @sebastian-ehrling and me already talked about a good way to integrate the Magento Acceptance Test Suite.
Let's see if we can get it to run.

I think the magento nginx config could have two stanzas in it with different roots...

Hi @cmuench
that would be great! I've created a ddev addon to add and run and selenium container to a ddev project.
ddev get sebastian-ehrling/ddev-selenium-standalone
What do you think is the best way to modify the nginx config?

I opened the first issue on your selenium add-on, great start!

https://github.com/sebastian-ehrling/ddev-selenium-standalone/issues/1

Hi @cmuench that would be great! I've created a ddev addon to add and run and selenium container to a ddev project. ddev get sebastian-ehrling/ddev-selenium-standalone
What do you think is the best way to modify the nginx config?

If you want then we can have a zoom call to discuss it. It depends :-)

I'll leave this in your hands. Let me know if I can help. Closing for now, happy to continue the conversation here or elsewhere.


Accept a sub-syntax so we can support scss, less, etc

Currently, we do not actually support sass/less properly since they too are implemented as custom postcss syntaxes.
Since you can only have one syntax, it means we're now overriding the inner syntax.
Ideally, we'd support something like this in postcss' config files:
{
  "syntax": "postcss-lit",
  "syntaxOptions": {
    "syntax": "postcss-less"
  }
}

though that would also mean we'd need stylelint to support the same, or just tell stylelint users they must have a postcss config file...
i think i'll need your help here @ai to figure this concept out.
ideally we want to avoid requiring consumers to programmatically call postcss just so they can specify the sub-syntax (e.g. LESS).
one thought was that we could read the postcss config file (if one exists) and look for a "syntaxOptions" like above. though syntaxes are synchronous and loading postcssrc is async... meaning we wouldn't really be able to do it.

once we get hold of the sub-syntax name, it should be super easy to pass it through when we call the parser under the hood.
we basically want to do the same logic as postcss-cli: load the config file, get hold of the imported syntax and call its parse function or fallback to postcss' own.
we should try come up with a standard way of achieving this so we don't end up with side effects/postcss api mutations like we've seen in the past.

i think i'll need your help here @ai to figure this concept out.

Honestly, I think the task is too complicated and not really popular.
CSS evolving very fast and preprocessors have no solid future.
Standard CSS in CSS-in-JS is our main future.

Adding syntax option will be hard (especially, because most tools has own PostCSS config loader).
I think the best API is to use separated files for imports "syntax": "postcss-lit/less". Anyway, we have a very small amount of these inner syntaxes.

Standard CSS in CSS-in-JS is our main future

as a huge proponent of web standards/APIs i strongly agree with that... though we still have quite a lot of people/projects around using sass/less it seems.

I think the best API is to use separated files for imports "syntax": "postcss-lit/less"

that is the easiest solution without having to change much i think.
it is a shame, though, as we would have to tie this generic package into understanding specific sub-syntaxes.
given that there's only two im aware of  still widely in use though (sass, less), maybe we will be fine.
postcss basically import(config.syntax) from what i understand. so i could just publish a less.js and a scss.js or some such thing in each css-in-js syntax.

it is a shame, though, as we would have to tie this generic package into understanding specific sub-syntaxes.

Agree. But it is not so big problem since we have only a small number of them: Sass, Less, SugarSS (maybe only Sass and Less).

Wonder if most subsyntax features will converge with vanilla CSS in the future, since vanilla CSS will support nesting (albeit with a different syntax).
Eg. if Emotion or Styled Components (or both) were to support this new nesting syntax instead of non-standards like Sass or Less (and Stylelint would also support this syntax), then maybe there could be less custom code in the customSyntax for this...

i think so yeah
LESS already seems to be valid (parseable) CSS. SCSS not so much, but isn't far off.
ideally people will move towards vanilla css anyway over time since the same features are becoming available natively 🙏
i'd highly recommend people try use postcss-styled-components without the sub-syntax first, and if it works fine on their project, leave it.


Wrong cassette using http.client and tunneled connection

Hello,
I am using the HTTPConnection.set_tunnel method from http.client to get the proxy right but when I want to record a request

the cassette file does not contain any of the request to the proxy (which are actually what I need to test)
the URL stored in the cassette is [proxy host]/path-to-resources and not [host I want to reach]/path-to-resources.

I can fairly understand that it can be seen as useless to record interaction with the proxy but in that case it would make more sense to not record the proxy host but the real host on which we want to perform the query.

A lot of changes have happened to VCRpy since this ticket was opened. As this ticket has become stale and we have a lot of old tickets that need to be groomed, I'm closing this for now to make it easier to see what is still relevant.
However if it is still needed, please feel free to re-open or create a new ticket.
Thanks! 🙏


ImportWarning: can't resolve package from spec or package

What is wrong?
When running trinity, there are several warnings like this:
ImportWarning: can't resolve package from __spec__ or __package__, falling back on __name__ and __path__

This is one of many different kinds of warnings mentioned in #1370
The goal is not simply to hide these warnings but to resolve them.
How can it be fixed
It will take some investigation. You should be able to see stack trace info for the warning by starting trinity with:
PYTHONWARNINGS=error::ImportWarning trinity

Then dig into each offending module to investigate.
This bug report has some ideas about resolving the warnings.

Should have been fixed with #1419


Added User Management Sample

Hello,
I have replicated the User Management sample from .Net to Nodel.js.
Please have a look at it and let me know about any improvements or suggestions.
Thank you

@hemantkathuria,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

Thanks Hemant!
Merging in (Hemant is a MSFT employee; CLA not required)


Repo needs usage documentation

This repo would benefit from more documentation.  I'm trying to adapt the collection for the community.okd / redhat.openshift collection but it's not immediately obvious what the different vars are used for (and some values are hard-coded in the janus.yml playbook.)  I'm getting unexpected results but I'm not sure if it's user error or not.
For example, how do upstream_name, upstream_namespace, and upstream_collection_name relate to each other?  I can make an educated guess about upstream_namespace because it has a hard-coded value but I'm uncertain about the other 2.
Right now my resulting collection still has the upstream collection name (community.okd) in plugin EXAMPLES blocks, redirects in meta/runtime.yml, and my CONTRIBUTING.md file (as well as a number of test directories, such as /molecule/, but I don't expect janus to support that today).  I'm probably overlooking something, but I don't have confidence I'm doing the right thing in general.
Ideally IMO, janus would be a role that users can use rather than calling a playbook from another playbook and over-riding the vars that are in janus.yml.  That role would have a set of documented variables, with sensible role defaults where they can be made generic (such as the environment variable lookups for things like PROJECT_UPSTREAM_NAME, but no default of upstream_namespace:  "middleware_automation").   That documentation should be adequate for a new user to configure a playbook for use with a new collection without having to dig into the underlying roles in middleware_automation/janus/roles/.
Reference config:
(venv) jill@lab:~/collections/ansible_collections/middleware_automation/janus$ git diff
diff --git a/playbooks/janus.yml b/playbooks/janus.yml
index a2912ae..c37f985 100644
--- a/playbooks/janus.yml
+++ b/playbooks/janus.yml
@@ -5,14 +5,14 @@
   collections:
     - middleware_automation.janus
   vars:
-    upstream_name: "{{ lookup('env', 'PROJECT_UPSTREAM_NAME') }}"
-    downstream_name: "{{ lookup('env', 'PROJECT_NAME') }}"
-    upstream_collection_name: "{{ lookup('env', 'UPSTREAM_COLLECTION_NAME') | default(omit) }}"
-    project_git_url: "{{ lookup('env', 'GIT_REPOSITORY_URL') }}"
-    project_git_version: "{{ lookup('env', 'GIT_REPOSITORY_BRANCH') }}"
-    upstream_namespace:  "middleware_automation"
-    downstream_namespace: "redhat"
-    workdir: "{{ lookup('env', 'PWD') }}"
+#    upstream_name: "{{ lookup('env', 'PROJECT_UPSTREAM_NAME') }}"
+#    downstream_name: "{{ lookup('env', 'PROJECT_NAME') }}"
+#    upstream_collection_name: "{{ lookup('env', 'UPSTREAM_COLLECTION_NAME') | default(omit) }}"
+#    project_git_url: "{{ lookup('env', 'GIT_REPOSITORY_URL') }}"
+#    project_git_version: "{{ lookup('env', 'GIT_REPOSITORY_BRANCH') }}"
+#    upstream_namespace:  "middleware_automation"
+#    downstream_namespace: "redhat"
+#    workdir: "{{ lookup('env', 'PWD') }}"
     upstream_projects_dir: "{{ workdir }}/upstream"
     downstream_projects_dir: "{{ workdir }}/downstream"
     downstream_repository_host_env_varname: 'INTERNAL_GIT_REPOSITORY_URL'

(venv) jill@lab:~/collections/ansible_collections/middleware_automation/janus$ cat playbooks/openshift.yml
---
- import_playbook: janus.yml
  vars:
    post_processors_replacements:
     - match: "community.okd"
       replace: "redhat.openshift"
     - match: "Ansible Galaxy"
       replace: "Automation Hub"
     - match: "Kubernetes"
       replace: "OpenShift"
     - match: " okd"
       replace: " openshift"
    upstream_name: "community.okd"
    downstream_name: "redhat.openshift"
    upstream_namespace: community
    downstream_namespace: redhat
    workdir: /var/tmp
    project_git_url: "git@github.com:openshift/community.okd"
    project_git_version: DNM_downstream_experiment
    downstream_repository_host_env_varname: localhost

Absolutely, I'll start by creating the argument specs for the janus role, and using our tooling to generate a README so we have at least the variables docs.

Should the changelog generation be useful, too?

If janus will use https://github.com/ansible-community/antsibull-changelog the docs can probably link to those docs, otherwise if there is a different changelog process then yes it would be helpful.

yes, we have GH pipelines that take care of all that automatically, I'll add those bits too
( https://github.com/ansible-middleware/collection-docs-action )

Infra for  ci, docs and changelog is merged, along with arg specs for the janus role; some more work is needed for proper default values, and "real" usage docs have to be written (#14 and #15); docs here:
http://ansiblemiddleware.com/janus/main/CHANGELOG.html and http://ansiblemiddleware.com/janus/main/roles/janus.html

@jillr I think we're good now :) but if you still have comments or feedback, please use the new repo!


Remove KWExistVerifier

This is the first step in a possible solution to #621.
Currently there's this very loose contract between subjects, verifiers and matchers. At the moment it's possible to pair any kind of subject with any kind of verifier. One problem with this is that a plain old subject can be added to an async verifier, even though it's not possible for the subject to be re-evaluated multiple times.
This is the first simplification of the set of types conforming to KWVerifying.

Also, because this is a breaking change, I've created a new 3.0-development branch, which this PR targets. It's going to be helpful to have a place that's safe to put these changes!

@sharplet it's worth a re-think about whether you want this in

I think this is only useful as part of a larger set of changes which I'm not really able to commit to. I don't think it's worth merging at this point.


[SECURITY] Access to other user's profile

What happened?
It turns out that if you're logged in as one user and happen to know the id another user, you can access that other user’s profile page. E.g. mysite.com/users/someotheruserid.
What should've happened instead?

Steps to reproduce
Login as user A. Change URL to mysite.com/users/userb.

So this is easily handled with more
{% if object == request.user %}
...
{% endif %}
statements. But I think the out of box user_detail.html should already have them in place.

I'm not sure it's a problem. Many websites have a public profile for their users. Aren't you able to access the profile page of any Facebook/Twitter/LinkedIn user if you know their username?
It's not like the default layout is exposing much sensitive info by default. If the app you build is NOT meant to have a public user profile page, then I guess one would audit their URLs beforehand.
If one is not happy with a public profile, it's pretty much one Mixin away. It's not a one-size-fits-all currently, but I'm not sure it's worth adding an option to the template either.

@browniebroke I think https://github.com/pydanny/cookiecutter-django/pull/2062 takes care of this.

Disregard my previous comment, I though the PR removed all the user's views.

Hmm, this still exists.  Here is my code using mixin
<<app_name>>/users/views.py
from django.contrib.auth.mixins import UserPassesTestMixin

class UserDetailView(UserPassesTestMixin, DetailView):

    # original code goes here ......

    def test_func(self):
        return self.request.user.get_username() == self.kwargs['username']

Yes, it still exists. As per my above comment, I don't consider it a security risk. Unless I misunderstood, lots of website do have a public profile (including the one we're using right now).


Add new genre

What's wrong with the existing documentation
Add new genre for drama , comedy, action, mystery and phycological
Add ScreenShots
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@anuragverma108 can you please reupdate the labels as it contains more than one new genre adding


[Security] Workflow pr.yml is using vulnerable action s4u/maven-settings-action

The workflow pr.yml is referencing action s4u/maven-settings-action using references v2.4.0. However this reference is missing the commit 5935b2506fdb5912d2dbbd167716193890e2fabd which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

Please look at the last PR build: https://github.com/s4u/slf4j-mock/runs/4558858552?check_suite_focus=true
and the setup task:
Download action repository<EMAIL_ADDRESS>(SHA:ec3a7ce113134d7a93b817d10a8272cb61118579)
Download action repository<EMAIL_ADDRESS>(SHA:5f00602cd1b2819185d88dc7a1b1985f598c6705)
Download action repository<EMAIL_ADDRESS>(SHA:937d24475381cd9c75ae6db12cb4e79714b926ed)
Download action repository<EMAIL_ADDRESS>(SHA:7060d72b50fbf2389a16d6f66a9c7d4d9ece5d36)
Download action repository<EMAIL_ADDRESS>(SHA:902651b0f8e6e470107a6eee701f30f4f0986fbe)

So we use v.4.1 of maven-settings-action
Please one again check all reported issue for our organization.

@igibek pleas close all duplicate issues


Deferrable mode for custom training job operators

The PR adds the deferrable mode feature for the following Vertex AI operators:

CreateCustomContainerTrainingJobOperator
CreateCustomPythonPackageTrainingJobOperator
CreateCustomTrainingJobOperator

Other changes include:

Fix for VertexAIModelLink. The old link url did not work anymore, I replaced it with a working one.
New unit tests
Update example dags

Note
The PR depends on another repo branch which is currently under review in the Airflow community:
https://github.com/apache/airflow/pull/37969

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Why did you not add a system test for CreateCustomTrainingJobOperator operartor?

Why did you not add a system test for CreateCustomTrainingJobOperator operartor?

The system test is there now, thanks for pointing it out.


Question regarding 2nd Moment Update

Hi Lucas,
First of all I would like to say thank you as the RAdam is really an amazing optimizer I have been using since last year.
Recently I am interested in the algorithm behind RAdam and I have a dumb question if you don't mind - the update of exponential moving 2nd moment formula in your paper is: vt ← 1/β2vt-1 + (1 - β2)gt2. I remembered in Adam optimizer, the update of is vt ← β2vt-1 + (1 - β2)gt2 without "1/". I also noticed that in your paper's version 1 the formula does not include "1/", so why is "1/" added?
I also checked the code, if I understand correctly, the following is updating the 2nd moment:
exp_avg_sq.mul_(beta2).addcmul_(1 - beta2, grad, grad)

Could kindly help me out when you have free time?
Many thanks,
Bowen

Thanks for reaching out! It is really an encouragement to hear you like our work!
As to the second momentum update, it is indeed a typo and should be β_2 instead of 1 / β_2. I will update the paper in the next version.
Best,
Liyuan


wleave: init at 0.3.0

https://github.com/AMNatty/wleave
Tested build and basic functionality
Closes #251058
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 251072 run on x86_64-linux 1

1 package built:

wleave

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2609

Result of nixpkgs-review pr 251072 run on x86_64-linux 1

1 package built:

wleave


Text Align Right

How can i align the text?
I want right align...

This isn't built into the library, but it appears possible.

I added the code in.  The one thing that might be confusing is the default alignment.
Example:
position: top left
default alignment: left
position: top right:
default alignment: right
Maybe there should be a default alignment for text?  If left was the default example, and you chose top right for position.  You would have to give it a right alignment otherwise it would create the text right off the image

I support a default option for alignment, which would depend on the position. If the user specifies alignment, it would obviously override it.
Only problem is this would be considered a breaking change, so I'd prefer to keep the default as-is and add it to the 3.0 roadmap :)

Scratch that. Totally possible since alignment is a new parameter and defaults to null. If you'd like to add this, let me know and I'll hold off on drafting the next release.

Added in #100. Please submit a new PR if you want to update the default alignment based on position.


mgmt, appservice, add TOMCAT_10_0_JAVA11, deprecate TOMCAT_10_0_JRE11

fix https://github.com/Azure/azure-sdk-for-java/issues/37769
Also removed TOMCAT_10_0_JRE11 from getAll.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-appservice


Revamp RequestContext.set{Request,Response}Timeout()

…ions.
Motivation:
The new timeout API was introduced in Armeria 0.98.0 and set*Timeout{Millis} has been deprecated. #2343
However, we got some internal inquiries about how to replace the setTimeout{Millis}.
It is hard to implement with the existing API.
On the other hand, some of the users are confused about the new timeout API.
See #2535 for the detail discussion.
I think we need to clean and revamp the timeout API before 1.0
Modifications:

Undeprecate set*Timeout{Millis}
Deprecate set*TimeoutAt{Millis} without a replacement
Deprecate set*TimeoutAfter{Millis} in favor of setTimeout{Millis}(TimeoutMode.FROM_NOW, ...)
Deprecate extend*Timeout{Millis} in favor of setTimeout{Millis}(TimeoutMode.EXTEND, ...)
Add TimeoutMode enum
Migrate deprecated API
Use default method to deduplicate code

Result:

set*Timeout{Millis} is revived.
You can now schedule a timeout with TimeoutMode.
Fixes #2535

/cc @KarboniteKream

Thanks, @ikhoon!


Path winding order on sketches are in the opposite sense after extrusion

The winding order is wrong to me. The code I wrote in https://github.com/KittyCAD/modeling-app/issues/766 makes a clockwise circuit for the inside face of the solid. After extrusion, the top face is oriented correctly but the bottom face remains the wrong way up. Reversing the order in the code corrects the bottom face orientation but this is not a solution.

For clarity, the point I'm trying to get across is the path is counter-clockwise when viewed from below as the picture above it doing, so I would expect the face to be visible on this side.
Is the winding order meant to have any significance on the solid in the modelling app? Whether it is or not, either the modelling app or the engine needs to ensure outward faces have counter clockwise loops for export to work properly.

I think the engine should own this but cc @jgomez720 @Irev-Dev for comment

Yeah seems like a engine should own thing to me too.

@alteous are you still seeing this? If so can you hit the transfer button and move to engine repo :)

I wasn't able to reproduce this anymore so consider it solved. :smile:


Package 'multibootusb'

Issue description
http://multibootusb.org/
https://github.com/mbusb/multibootusb

@matthewbauer Hi, did I do something wrong? Should I have requested this in a different way?

Weird, I thought I'd seen something to make me think this was resolved in a way other than just closing, but I can't find that linkage now.
Searching manually though, I do see a merged PR around the same time: https://github.com/NixOS/nixpkgs/pull/40184
Thanks; no action needed!

Yeah sorry! Meant link it.


extern: Fix fast_obj to trim trainling whitespace for names

Some .obj files have extra whitespace after usemtl and other statements; this may interfere with parsing, for example by adding a space to the material name which can result in inability to find it in .mtl file.
Fixes #590

Also submitted the same patch upstream https://github.com/thisistherk/fast_obj/pull/43


Pipenv local editable packages won't deploy

I'm using a pipfile with a section like this
[packages.common]
editable = true
path = "./../common"

Gives the error

STDERR: ERROR: Invalid requirement: './../common' (from line 1 of /var/task/requirements.txt)
Hint: It looks like a path. File './../common' does not exist.

#314 seems to be similar, the only difference is my package is a sibling folder

@thejuan thanks for the report! Would you mind providing the version of serverless, the plugins, pipenv, Python? Also, the generated requirements.txt file from pipenv lock -r

pipenv, version 11.9.0
python 3.7.5
serverless
Framework Core: 1.64.0
Plugin: 3.4.0
SDK: 2.3.0
Components Core: 1.1.2
Components CLI: 1.4.0
plugins
  - serverless-jetpack
  - serverless-scriptable-plugin
  - serverless-reqvalidator-plugin
  - serverless-aws-documentation
  - serverless-offline
  - serverless-domain-manager
  - serverless-plugin-bind-deployment-id
  - serverless-plugin-warmup
  - serverless-content-encoding
  - serverless-plugin-scripts
  - serverless-plugin-split-stacks
  - serverless-dependson-plugin
  - api-gateway-stage-tag-plugin
  - serverless-plugin-package-json
  - serverless-openapi-documentation
  - serverless-plugin-additional-stacks
  - serverless-python-requirements

requirements
 -e ./../common
 boto3==1.12.6
 botocore==1.15.6

Workaround for now is to use nodeploy and then include the other package into the serverless package via include


Custom join on conditions

PR Info

Closes https://github.com/SeaQL/sea-orm/issues/160

Adds

[ ] RelationDef and RelationBuilder with on_condition field

thank you for inviting me , this implement is great. I have one more question about how it handle multiple join conditions? Can you  gave me more examples?

thank you for inviting me , this implement is great. I have one more question about how it handle multiple join conditions? Can you gave me more examples?

Hey @liberwang1013, for example, https://github.com/SeaQL/sea-orm/pull/793/commits/3efe1611a2bb0b658aab78ffc9e22005760cbd96?

Docs added

Great work!


Forecast showing same temperature for min and max

The forecast complication has been showing the same minimum and max temperature for quite a while now.  For clarification, its not that the forecast temperatures doesnt update, but that everytime it updates the same two numbers are shown from the minimum and maximum.

Yeah, this is a definite issue. The problem is, OpenWeatherMap doesn't actually offer daily forecasts for free, so I'm actually just pulling the next 24 hours of hourly forecasts and using the min/max temps. It's possible that if I use the next 48 hours this issue will happen less.

The two numbers have been showing the same temperature for at least the past month or more.  I have never seen it show different numbers in the min and max during this time.  If it was correctly pulling hourly temps for the next 24 hours, I would expect the two numbers to be different at least some of the time, but its never different.

Fixed in version 6.0


Doc: clarify that :fork inherits settings from main repo

I was attempting to switch a fork of a Github package to use SSH instead of HTTPS and wrote the following:
(use-package org-gcal
  :straight (:host github :repo "kidd/org-gcal.el"
             :fork (:repo "git@github.com:telotortium/org-gcal.el")))

To my surprise, straight constructed the URL "https://github.com/git@github.com:telotortium/org-gcal.el" for the fork. It turns out that, even though :host is nil by default in a top-level straight recipe, the :fork clause inherits the keys from the top-level recipe, so there was an implicit :host github in the :fork recipe. The configuration
(use-package org-gcal
  :straight (:host github :repo "kidd/org-gcal.el"
             :fork (:host nil :repo "git@github.com:telotortium/org-gcal.el")))

gives me the expected repo URL "git@github.com:telotortium/org-gcal.el". It would be worth documenting this behavior of the :fork keyword explicitly, and also giving an example like this.

Yes, that sounds reasonable. It is intended behavior but it doesn't look particularly pretty from this angle. In fact, it would probably make sense to add a special case whereby if you provide a full URL when :host is non-nil, then it's taken as given rather than processed further.


add simple explanation about test cases

add simple explanation about test cases, very useful for golang fresher

Coverage remained the same at 95.76% when pulling 23024271cd30edc06510f35e1dd0da4bf4c1212a on sssvip:master into 651680c71b22b1164ee36398b009b2da5839e694 on cweill:master.

I agree that it would be a better UX to add some examples of how this works. I'll need to think about this a bit. We need to at least clean up the examples a bit.


Make https://github.com/Gamebuino/gamebuino-samd-peripherals.git public

Hej, Aurélien,
I try to build the CircuitPython port of the gamebuino by myself. Unfortunately I already failed at the first step cloning the repo and the submodules, because it seems gamebuino-samd-peripherals is not a public repo. Could you please make the gamebuino-samd-peripherals open?
Thanks.
björn

@Rodot that is https://github.com/Rodot/gamebuino-samd-peripherals

Done !


Purchaseable shuttles should be sorted into categories like cargo.

Description

E.g. civilian group, expedition group, ... showing in the shipyard UI

right now thats what the small/med/large is doing but that can easily be replaced with type categories instead.  the other tag is built in to allow console specific sorting and you could have that as well, if you wanted to give nukies their own console with it.  If that's ever requested let me know and I can add that here from my fork.


Add implementations section on the README

Adds bitcoin-s implementation to DLC spec README for new users to find working code. CG/others feel free to submit implementations after this gets merged

Looks like you duplicated the readme

Looks like you duplicated the readme

Should be fixed, I don't have the ability to merge though


How to get the rest Surrey Face Model

I followed README instructions, visited website http://www.cvssp.org/faceweb/3dmm/facemodel/, and registered, but it has been a week after registered. I have no received any reply.
and I send a email to<EMAIL_ADDRESS>....without reply...
So, the only way I can consider is post a issue here...
looking for a reply，
and Thank you for your work again!

Hi,
Thank you very much!
Unfortunately there is nothing really that I can do to help you regarding obtaining the full Surrey Face Model - as you already know<EMAIL_ADDRESS>is the contact address and you would have to wait until you receive a reply, or email them again.
I wish you good luck, and hope you hear from them soon! :-) Maybe let us know here once you do.