Refactor Managed Elasticsearch implementation

Our integration tests are self managing, acquiring and installing elasticsearch and its plugins and making sure that the clusters we start are in the state we need them to be.
The code to get them in to that state was scattered around different classes with different responsibilities,
The code that actually started and waited for the node to be really started (e.g elasticsearch printing started) grew too much in complexity,

Simplified startup code, we had too many waithandles and callbacks.

Refactored tasks out of ElasticsearchNode and FileSystem to dedicated
classes

Introduced a dedicated task runner that breaks up the following stage
s in multiple tasks:

Installation of elasticsearch (previously in ElasticsearchNode)
PreStart tasks (previously in NodeFileSystem)
Post start validation (previously in ElasticsearchNode)

Tasks runner now also keeps track of tasks it ran in
%APPDATA%/NEST/{version}, so that we can introduce more tasks without
deleting this folder. Tasks now also not necessarily in charge of
idempotency. Allthough writing idempotent tasks should still be the
goal

ported to master


Sending a notification with the same id does not replace the old one when I switch between foreground and background on Android

 "react-native": "0.71.7",
 "@notifee/react-native": "^7.6.1",
 "@react-native-firebase/app": "^18.0.0",
 "@react-native-firebase/messaging": "^18.0.0",

I send a notification (notification + data) when the app is on background

Notification is displayed (created by the OS)

I move the app to foreground

Re-send exact same notification (same id, same title, body, data, etc) -> I create a notification to display at onMessageReceived  like this:
await notifee.displayNotification({
     id: remoteMessage.data?.notificationId,
     title: remoteMessage.notification?.title,
     body: remoteMessage.notification?.body,
     data: remoteMessage.data,
     ios: {
       foregroundPresentationOptions: {
         alert: true,
         badge: true,
         sound: true,
       },
       critical: true,
     },
     android: {
       channelId,
       importance: AndroidImportance.HIGH,
       smallIcon: "ic_small_icon",
       color: "#EFC40F",
       pressAction: {
         id: "default",
       },
       sound: "default",
       style: {
         type: AndroidStyle.BIGTEXT,
         title: remoteMessage.notification?.title,
         text: remoteMessage.notification?.body ?? "",
       },
     },
   })

Expected: new notification must replace the old notification displayed (because I'm using the same id)
Actual:  A new notification is displayed (now I have two notifications)
this is the JSON format of the notification I receive on the phone:
{
    "collapseKey": "com.mypackage.here",
    "data": {
        "notificationId": "11557ce2f-e928-4d93-9721-111111",
        "myData": "here",
    },
    "from": "112312312312123",
    "messageId": "0:1231231231231231231231231312c8",
    "notification": {
        "android": {
            "smallIcon": "ic_small_icon"
        },
        "body": "Body example",
        "title": "My title"
    },
    "sentTime":<PHONE_NUMBER>122,
    "ttl": 104800
}

✅ If I have my app in the background the whole time, and I send exact same notification several times, the new notification replaces the old one
✅  If I have my app in the foreground the whole time, and I send exact same notification several times, the new notification replaces the old one
❌ So the issue comes to play when I start switching between foreground and background ONLY ON ANDROID (iOS works fine)
Anyone can help me with this issue?

@fgagneten (how) did you solve this?


CMake and/or vanilla make ?

@all Is there an agreement that CMake should be mandatory for the exercices ? If so, the old files Makefile should be removed from git.

Ouch... Attila has worked hard, perhaps making this issue obsolete...

Both are fine for me. But we should explain the advantages/disadvantages.

I created a ticket for CMake now since I also think we should talk briefly on CMake: #123


feat: setup moduletemplate cache

Cache Key is generated from Controller-Name (e.g. manifest) + Channel (stable), as there can be at most one template for this combination. If a module change is detected, the template is purged from the cache and will be dynamically recalculated the next time a kyma is reconciled for this channel. This will happen right after the invalidation since all Kymas connected to the channel with the module will be requeued.

We use the internal system cache lookup for kubebuilder


Support compiling the SDK with Kotlin 2 (#1721)

Just cherry-picking from main so will merge without review.


add systemview trace tool code

add systemview trace tool code

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.liangzeng.glz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Running from a flash?

I'm relatively green with programming, but if I downloaded a bunch of speech docs to a flash, as well as all of the programs you have listed as required onto a flash/the computer I'd be using this on, would I be able to have it parse cards and search them from those docs?

You'd need to install all the dependencies on the host machine and run it from there. You should still be able to load in files from the flash drive, but this is a fairly slow process.


Issue with string keys in Mail delivery_options

I'm not sure if this is an issue in Mail or not, but I'm using Mail version 2.2.15. Broadcast is giving Mail a Hashie::Mash for delivery_options which seems to serialize to a hash with string keys. Mail appears to be expecting symbol keys. The result is that for example SMTP delivery options are not used by Mail when configured through Broadcast.
I fixed this for myself with a monkeypatch to Hashie::Mash, but as I doubt this is a proper solution, I have not issued a pull request:
lyleunderwood/broadcast@afdd780

Hi
This commit addresses this issue:
https://github.com/futuresimple/broadcast/commit/0d621714821f8c58ecc68ec0bc4ae753411d114d
It is in broadcast >= 0.2.3
Thanks for reporting the issue, and sorry it took me so long to implement :)


Getting Registry key exception on EnumEnterpriseCAs when using library version <IP_ADDRESS> in my C# project

Issue:Getting Registry key exception when using library version <IP_ADDRESS> in C# project

CertificateAuthority[] certificateAuthority = CertificateAuthority.EnumEnterpriseCAs("Name","*");

Please note same thing happens on EnumEnterpriseCAs("Server","*");
Appears to be similar to the issue PSPKI issue 73.
Exception details:

{"Requested registry access is not allowed."}
{System.Collections.ListDictionaryInternal}
null
null
null
null
-2146233078
null
null
"Requested registry access is not allowed."
null
null
null
null
null
"Microsoft.Win32.Registry"
"   at Microsoft.Win32.RegistryKey.InternalOpenSubKeyCore(String name, Boolean writable)\r\n   at PKI.Utils.CryptoRegistry.GetRReg(String entry, String caName, String computerName, String node)\r\n   at PKI.CertificateServices.CertificateAuthority.pingRegistry(String computerName)\r\n   at PKI.CertificateServices.CertificateAuthority..ctor(String computerName, String name)\r\n   at PKI.CertificateServices.CertificateAuthority.EnumEnterpriseCAs(String findType, String findValue)\r\n   at CertExporter.Startup.StartAsync(CancellationToken cancellationToken) in D:\Alexey\p\CertExporter\Startup.cs:line 40\r\n   at Microsoft.Extensions.Hosting.Internal.Host.d__9.MoveNext()\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.d__4.MoveNext()\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.d__4.MoveNext()\r\n   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.Run(IHost host)\r\n   at CertExporter.Program.Main(String[] args) in D:\Alexey\p\CertExporter\Program.cs:line 104"
{Microsoft.Win32.RegistryKey InternalOpenSubKeyCore(System.String, Boolean)}
null
{string[0]}
{Microsoft.Extensions.Hosting.Internal.Host}

No, this exception is not same or similar. This error says that you can access to remote registry, but do not have sufficient permissions to access CA configuration key. This is mostly, a permission issue. Leave this item open. I will add extra check if you can open CA configuration key on remote machine before setting RegistryOnline = true. Currently, I check only if you ever can open remote registry, not particular key.

Thank you for your prompt reply! Спасибо!


Switch minimum TFM to net10.0

We will skip net9.0 since we are tracking LTS releases.

https://learn.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-13#params-collections


3.1.3 missing dist directory when installed via bower

Regression defect,

dist directory is in version 3.0.7

Note that the dist directory is available when: npm install flatpickr

Reproduction Link
Reproduction steps on command line:
mkdir test
cd test
bower cache clean flatpickr flatpickr-calendar
bower install flatpickr-calendar
ls -l bower_components/flatpickr/  | grep dist

nothing to output > there is no dist

Your Environment

flatpickr version used: ^3.0.7
Browser name and version: does not matter at all
OS and version: Ubuntu 16.04

Hello,
I've released v3.1.5 which contains the dist folder to prevent breakage.
v4 and onwards, however, I see less purpose in containing and versioning it in the repository.

thank you

Hello, can you explain why you see less purpose in containing it?
Thank you for your work.


BMA mode

is it ok to use sorted (sorted by samtools) bam files in the bam mode (Quantify IR) I'm not sure but I remember is earlier stages you mentioned not to do it

Hello,
yes, in the new version, the sorted bam files are supported.
Cheers,
Claudio


Integration color counts

add severity counts to indicator result nodes
hover tooltip displays clickable Integrations Buttons per category (green counts, grey counts, red counts)
counts of zero are not shown, so if all are zero, nothing will appear
IntegrationBtns minor refactors + severity filter added (for use in color-counter tooltip)

Let's merge in the UI reshuffle branch to dev5. This diff is ugly since it has those changes too.

Let's merge in the UI reshuffle branch to dev5. This diff is ugly since it has those changes too.

agreed 👍

closing PR due to git sadness.
see https://github.com/arkime/arkime/pull/2358

so so sad


feat(request): add argument to filter by "missing" status in arrs

Hello,
I am interested in using retraktarr to synchronize my Radarr and Sonarr lists with Trakt. I would like to request a feature that allows syncing only the items marked as "missing" in Radarr and Sonarr to the Trakt list. This feature would be invaluable for users like me who manage files on a seedbox and delete them post-transfer, ensuring that only the necessary "missing" movies and series are tracked and added to Trakt.
Thank you for considering this feature request!

Good addition, will look into getting this implemented - hopefully this weekend, time permitting. Thanks.

I still tried using custom tags for Radarr as you advised, and it seems to work (for my use at least). I added a "imported" tag with the conditions: "not monitored" and "present in root path" (if it's in the root path, it means it was imported from the download client, so it's considered imported.
I sync the list with Trakt using the -p parameter and boom, it works.
For Sonarr, it's a different story, what a headache... The same custom tags don't work because a series is always "monitored" as long as it's not "ended", which means as long as it continues to be aired, it retains its "monitored" status. And for the mandatory presence in the root path, if I do that, it syncs 100% of the series. Oh, but wait... It's hitting me as I write... If I set the condition that the series must not be in the root path and I check the "delete empty folders after file deletions" parameter, it might just work, I'm going to try :D

For Radarr, typically using Size on Disk for missing is what I've seen recommended. Sonarr, I just don't know.
As we discussed on Discord, I'm not entirely sure what should or should not constitute a "missing" qualification for Sonarr, the main issue being that every week for a short time there will be missing episodes. Percentage of Episodes is a possibility, but once again this is a potentially fluid metric to base this off. I'm going to look into Radarr's implementation now, and think more about Sonarr.
Thoughts are welcome on potential Sonarr integrations for missing.

Pending Sonarr (if possible) implementation. Radarr is done, about to push 1.0.7 for this.
Feel free to test, or update using pip once 1.0.7 is on pypi

No viable use with sonarr in use-cases has been found, closing this. Any future issues for this flag in sonarr will need to provide some way for it to be done that makes sense.


[BUG] Upper method applied to each queried symbol...

I check the code and see that it uses upper() method after a string symbol, if we query some ticker like AAMpA, where there is a letter 'p' which is not in upper case, the result will be FALSE.

Just managed to hit this with ABRpD..

I remember this being reported once before and I think it should be possible to query a symbol without the lib changing it.
Lemme know if this is still an issue and I'll take a look


[Docs] Added: information regarding enabling internationalization support in VSF(#486)

Related Issues
#486
closes #486
Short Description of the PR

Added the information regarding internationalization support in Vue Storefront
Added a note

Screenshots of Visual Changes before/after (if There Are Any)

Pull Request Checklist

[x] I have updated the Changelog (V1) and mentioned all breaking changes in the public API.
[ ] I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.
[x] I have tested my Pull Request on production build and (to my knowledge) it works without any issues

[ ] I have followed naming conventions

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[x] I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

Contribution and Currently Important Rules Acceptance

[x] I read and followed contribution rules

@Fifciu Please review


use command builtin for grepping

Looks good.
What do you think about also doing this for sort.
What are your thoughts on also making those commands local * variables?

Sure thing- let me update it when i get home.
On Fri, Aug 5, 2016 at 1:10 PM Wil Moore III<EMAIL_ADDRESS>wrote:

Looks good.
What do you think about also doing this for sort.
What are your thoughts on also making those commands local * variables?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/wilmoore/php-version/pull/53#issuecomment-237907093,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIqu0GA-1a0-WiI50moN0NFgm6mWk6ZHks5qc25wgaJpZM4Jd3kv
.

My first time doing locals in bash like this- i'm not sure it's the best approach.

Looks great @erikdstock - I just had one comment. If you could address that, I'd be happy to merge.

Done- thanks!

LGTM 👍


May I ask how to put the latest comments first?

May I ask how to put the latest comments first?It seems that they are all sorted from the earliest?I can't change it, I need your help! Thanks!

Click the toggle

Or add a giscus.json to your repository to configure the default
https://github.com/giscus/giscus/blob/main/ADVANCED-USAGE.md#defaultcommentorder

I have solved it, thank you for your help!

can i set anything to change the default sort way as latest


refact(packages) execute script from node_modules/.bin/ directly

When executing a script using npm run foo, npm adds ./node_modules/.bin to the PATH. This means that it is unnecessary to mention node_modules/.bin/ again when executing the scripts.
Documentation: https://docs.npmjs.com/cli/run-script

@mgeisler cool. I didn't know this. useful stuff.


No closing transition for modal when clicked button is btn btn-primary

Operating system: Linux
Browser: Chromium Version 89
There is no closing transition for a modal when, after being allowed to finish its opening transition, a button with the data-bs-dismiss="modal" attribute and the btn btn-primary classes is clicked in the modal, as opposed to a similar button with just one class (just btn, or a btn-close button).
https://jsfiddle.net/bdy73erw/

Pretty much same the problem as with #33682 😔


[Tests] Fix vscode version to avoid error

The latest vscode v1.66 has caused errors so it needs to be fixed to
v1.64 until the problem would be resolved.
ONE-vscode-DCO-1.0-Signed-off-by: Yongseop Kim<EMAIL_ADDRESS>

Maybe in next PR, it would be great if we have some comment or TODO about this version limitation. 😸

@hyunsik-yoon I update with some comments.


[PDI-17585] Variable Replacement Is Not Working in Connection Pool Co…

…nfiguration
@pentaho/tatooine
@pentaho-lmartins @mbatchelor
Following @pentaho-lmartins suggestion, now the initialPoolSize and maximumPoolSize variable names are stored and evaluated at runtime.

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/database/BaseDatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/ConnectionPoolUtil.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseInterface.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseMeta.java
  core/src/test/java/org/pentaho/di/core/database/BaseDatabaseMetaTest.java
  core/src/test/java/org/pentaho/di/core/database/DatabaseTest.java
  dbdialog/src/main/java/org/pentaho/ui/database/event/DataHandler.java

Newly Broken Tests:
org.pentaho.di.core.database.BaseDatabaseMetaTest.testGettersSetters:
:red_circle: java.lang.AssertionError
java.lang.AssertionError: expected: java.lang.Integer<15> but was: java.lang.String<15>
	at org.pentaho.di.core.database.BaseDatabaseMetaTest.testGettersSetters(BaseDatabaseMetaTest.java:291)

org.pentaho.di.core.database.DatabaseTest.testNormalConnect_WhenTheProviderDoesNotReturnDataSourceWithPool:
:red_circle: org.pentaho.di.core.exception.KettleDatabaseException
org.pentaho.di.core.exception.KettleDatabaseException:

Error occurred while trying to connect to the database
null

	at org.pentaho.di.core.database.DatabaseTest.testNormalConnect_WhenTheProviderDoesNotReturnDataSourceWithPool(DatabaseTest.java:676)
Caused by: java.lang.NumberFormatException: null
	at org.pentaho.di.core.database.DatabaseTest.testNormalConnect_WhenTheProviderDoesNotReturnDataSourceWithPool(DatabaseTest.java:676)

Still Broken Tests:
org.pentaho.di.trans.steps.jsoninput.analyzer.JsonInputAnalyzerTest.testJsonInputExternalResourceConsumer:
:red_circle: java.lang.AssertionError
java.lang.AssertionError
	at org.pentaho.di.trans.steps.jsoninput.analyzer.JsonInputAnalyzerTest.testJsonInputExternalResourceConsumer(JsonInputAnalyzerTest.java:195)

org.pentaho.di.trans.steps.jsonoutput.analyzer.JsonOutputAnalyzerTest.testJsonOutputExternalResourceConsumer:
:red_circle: java.lang.AssertionError
java.lang.AssertionError: expected:<2> but was:<3>
	at org.pentaho.di.trans.steps.jsonoutput.analyzer.JsonOutputAnalyzerTest.testJsonOutputExternalResourceConsumer(JsonOutputAnalyzerTest.java:148)

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: -0.1% (click to expand)
org.pentaho.di.core.database.BaseDatabaseMeta

Branch Change: -8.1% :small_red_triangle_down:
Complexity Change: -5.2% :small_red_triangle_down:
Instruction Change: -14.4% :small_red_triangle_down:
Line Change: -10.1% :small_red_triangle_down:
Method Change: -3.9% :small_red_triangle_down:

org.pentaho.di.core.database.ConnectionPoolUtil

Complexity Change: -2.6% :small_red_triangle_down:
Instruction Change: -2.9% :small_red_triangle_down:
Line Change: -2% :small_red_triangle_down:
Method Change: -7.7% :small_red_triangle_down:

org.pentaho.di.core.database.PartitionDatabaseMeta

Complexity Change: -64.3% :small_red_triangle_down:
Instruction Change: -68.3% :small_red_triangle_down:
Line Change: -61.5% :small_red_triangle_down:
Method Change: -64.3% :small_red_triangle_down:

org.pentaho.di.core.encryption.KettleTwoWayPasswordEncoder

Branch Change: -3.9% :small_red_triangle_down:
Complexity Change: -3.2% :small_red_triangle_down:
Instruction Change: -1% :small_red_triangle_down:
Line Change: -1.7% :small_red_triangle_down:

org.pentaho.di.core.logging.LogChannel

Complexity Change: -1.6% :small_red_triangle_down:
Instruction Change: -0.6% :small_red_triangle_down:
Line Change: -0.7% :small_red_triangle_down:
Method Change: -2.6% :small_red_triangle_down:

org.pentaho.di.core.logging.LogLevel

Branch Change: -4.6% :small_red_triangle_down:
Complexity Change: -3.7% :small_red_triangle_down:
Instruction Change: -2.4% :small_red_triangle_down:
Line Change: -2.8% :small_red_triangle_down:
Method Change: -6.3% :small_red_triangle_down:

org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/database/BaseDatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/ConnectionPoolUtil.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseInterface.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseMeta.java
  core/src/test/java/org/pentaho/di/core/database/BaseDatabaseMetaTest.java
  core/src/test/java/org/pentaho/di/core/database/DatabaseTest.java
  dbdialog/src/main/java/org/pentaho/ui/database/event/DataHandler.java

Newly Broken Tests:
org.pentaho.di.core.database.DatabaseTest.testNormalConnect_WhenTheProviderDoesNotReturnDataSourceWithPool:
:red_circle: org.pentaho.di.core.exception.KettleDatabaseException
org.pentaho.di.core.exception.KettleDatabaseException:

Error occurred while trying to connect to the database
null

	at org.pentaho.di.core.database.DatabaseTest.testNormalConnect_WhenTheProviderDoesNotReturnDataSourceWithPool(DatabaseTest.java:676)
Caused by: java.lang.NumberFormatException: null
	at org.pentaho.di.core.database.DatabaseTest.testNormalConnect_WhenTheProviderDoesNotReturnDataSourceWithPool(DatabaseTest.java:676)

Still Broken Tests:
org.pentaho.di.trans.steps.jsoninput.analyzer.JsonInputAnalyzerTest.testJsonInputExternalResourceConsumer:
:red_circle: java.lang.AssertionError
java.lang.AssertionError
	at org.pentaho.di.trans.steps.jsoninput.analyzer.JsonInputAnalyzerTest.testJsonInputExternalResourceConsumer(JsonInputAnalyzerTest.java:195)

org.pentaho.di.trans.steps.jsonoutput.analyzer.JsonOutputAnalyzerTest.testJsonOutputExternalResourceConsumer:
:red_circle: java.lang.AssertionError
java.lang.AssertionError: expected:<2> but was:<3>
	at org.pentaho.di.trans.steps.jsonoutput.analyzer.JsonOutputAnalyzerTest.testJsonOutputExternalResourceConsumer(JsonOutputAnalyzerTest.java:148)

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.core.database.ConnectionPoolUtil

Complexity Change: -2.6% :small_red_triangle_down:
Instruction Change: -2.9% :small_red_triangle_down:
Line Change: -2% :small_red_triangle_down:
Method Change: -7.7% :small_red_triangle_down:

org.pentaho.di.core.encryption.KettleTwoWayPasswordEncoder

Branch Change: -3.9% :small_red_triangle_down:
Complexity Change: -3.2% :small_red_triangle_down:
Instruction Change: -1% :small_red_triangle_down:
Line Change: -1.7% :small_red_triangle_down:

org.pentaho.di.core.logging.LogChannel

Complexity Change: -1.6% :small_red_triangle_down:
Instruction Change: -0.6% :small_red_triangle_down:
Line Change: -0.7% :small_red_triangle_down:
Method Change: -2.6% :small_red_triangle_down:

org.pentaho.di.core.logging.LogLevel

Branch Change: -4.6% :small_red_triangle_down:
Complexity Change: -3.7% :small_red_triangle_down:
Instruction Change: -2.4% :small_red_triangle_down:
Line Change: -2.8% :small_red_triangle_down:
Method Change: -6.3% :small_red_triangle_down:

org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/database/BaseDatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/ConnectionPoolUtil.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseInterface.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseMeta.java
  core/src/test/java/org/pentaho/di/core/database/BaseDatabaseMetaTest.java
  core/src/test/java/org/pentaho/di/core/database/DatabaseTest.java
  dbdialog/src/main/java/org/pentaho/ui/database/event/DataHandler.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.4% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.job.entries.waitforsql.JobEntryWaitForSQL

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:
Line Change: -0.4% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/database/BaseDatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/ConnectionPoolUtil.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseInterface.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseMeta.java
  core/src/test/java/org/pentaho/di/core/database/BaseDatabaseMetaTest.java
  core/src/test/java/org/pentaho/di/core/database/ConnectionPoolUtilTest.java
  core/src/test/java/org/pentaho/di/core/database/DatabaseTest.java
  dbdialog/src/main/java/org/pentaho/ui/database/event/DataHandler.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.core.database.BaseDatabaseMeta

Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.9% :small_red_triangle_down:
Line Change: -1% :small_red_triangle_down:
Method Change: -2.1% :small_red_triangle_down:

org.pentaho.di.core.database.DatabaseMeta

Complexity Change: -0.3% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.4% :small_red_triangle_down:
Method Change: -0.6% :small_red_triangle_down:

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/database/BaseDatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseInterface.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseMeta.java
  core/src/test/java/org/pentaho/di/core/database/BaseDatabaseMetaTest.java
  core/src/test/java/org/pentaho/di/core/database/ConnectionPoolUtilTest.java
  core/src/test/java/org/pentaho/di/core/database/DatabaseTest.java
  dbdialog/src/main/java/org/pentaho/ui/database/event/DataHandler.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.core.database.BaseDatabaseMeta

Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.9% :small_red_triangle_down:
Line Change: -1% :small_red_triangle_down:
Method Change: -2.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction

Branch Change: -8.7% :small_red_triangle_down:
Complexity Change: -3% :small_red_triangle_down:
Instruction Change: -0.7% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.dbproc.DBProcMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -1.1% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Branch Change: -2.6% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

Hi @mbatchelor! After talking with you, I made some changes to this PR.
Could you please review this?

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/database/BaseDatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseInterface.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseMeta.java
  core/src/test/java/org/pentaho/di/core/database/ConnectionPoolUtilTest.java
  core/src/test/java/org/pentaho/di/core/database/DatabaseTest.java
  dbdialog/src/main/java/org/pentaho/ui/database/event/DataHandler.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.core.database.BaseDatabaseMeta

Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.9% :small_red_triangle_down:
Line Change: -1% :small_red_triangle_down:
Method Change: -2.1% :small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2.1% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.processfiles.ProcessFilesMeta

Branch Change: -3.5% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'dbdialog,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/database/BaseDatabaseMeta.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseInterface.java
  core/src/main/java/org/pentaho/di/core/database/DatabaseMeta.java
  core/src/test/java/org/pentaho/di/core/database/ConnectionPoolUtilTest.java
  dbdialog/src/main/java/org/pentaho/ui/database/event/DataHandler.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.core.database.BaseDatabaseMeta

Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.9% :small_red_triangle_down:
Line Change: -1% :small_red_triangle_down:
Method Change: -2.1% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.4% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:
Instruction Change: -0.4% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -3.8% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.pgbulkloader.PGBulkLoaderMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Branch Change: -2.6% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.symmetriccrypto.symmetriccryptotrans.SymmetricCryptoTransMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -1.8% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileinput.TextFileInputMeta

Branch Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

Looks good now. No breaking changes to the API and variables will be evaluated at runtime.

@pentaho-lmartins @LeonardoCoelho71950 @mbatchelor @pamval this PR changes DatabaseInterface, which is an existing public-facing interface.
Are we OK in doing so, especially as we steer towards a minor release?
Did a quick search through our pentaho codestack for implements DatabaseInterface, and got 51 hits throughout pentaho-kettle , pentaho-metadata, pdi-ee-plugin, pdi-sdk-plugins , ...
Given the above: have we considered less intrusive changes? If we feel we need to change that public-facing interface, have we looked into Java 8's default method interfaces ?


Command arguments system

A system that allows settings to be specified as arguments, using argparse (standard library)
This will improve usability, as you can see the list of arguments when you add --help at runtime, and there is no need to change variables in the file.
Also, since we are using the standard library, there is no need for users to add libraries, and the additional code used in this system is short, so developers can be flexible as they move forward.

i think this is a good idea, but I'm a bit hesitant to add it for now due to how much I expect the input format to change as I add more stuff.

We've applied this update to support new options, including flipuv.

is it possible to somehow keep the current list of options in the script, but allow args to overwrite them?

ah maybe like this?
if this works i think i like it more
duration = 20

parser.add_argument('--duration', type=int, help="Spectify a duration", default=duration)
duration = args.duration

nice it did work, iv put it into latest update along with fixes for new fog as well as a more flexible colorbehavior


Edit guide and add snippet

Add double backslash in guide windows write of "path_to_python", like guide of "robot_framework_workspace".

Add snippets [Template] that use case specifies the template keyword to use. The test itself will contain only data to use as arguments to that keyword. (reference UserGuide-Template)

Thank you from the contribution.
Looks good, from review point of view. Templates are not automatically tested, so I need to try it out, before I merge PR to master.

thank you.


⚠ Secret Website 3 has degraded performance

In bdbdb0b, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2120 ms

Resolved: Secret Website 3 performance has improved in da81326.


linux32, darwin64 compile error

error: failed to run custom build command for `ring v0.16.20`

Caused by:
  process didn't exit successfully: `/root/src/target/release/build/ring-9ce820ff71342b4d/build-script-build` (exit status: 101)
  --- stdout
  OPT_LEVEL = Some(3)
  TARGET = Some(x86_64-apple-darwin)
  OUT_DIR = Some(/root/src/target/x86_64-apple-darwin/release/build/ring-3ff2fa40296a8238/out)
  HOST = Some(x86_64-unknown-linux-gnu)
  cargo:rerun-if-env-changed=CC_x86_64-apple-darwin
  CC_x86_64-apple-darwin = None
  cargo:rerun-if-env-changed=CC_x86_64_apple_darwin
  CC_x86_64_apple_darwin = None
  cargo:rerun-if-env-changed=TARGET_CC
  TARGET_CC = None
  cargo:rerun-if-env-changed=CC
  CC = None
  cargo:rerun-if-env-changed=CROSS_COMPILE
  CROSS_COMPILE = None
  RUSTC_LINKER = None
  cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
  RUSTC_WRAPPER = None
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some(false)
  CARGO_CFG_TARGET_FEATURE = Some(cmpxchg16b,fxsr,lahfsahf,sse,sse2,sse3,sse4.1,ssse3)
  cargo:rerun-if-env-changed=MACOSX_DEPLOYMENT_TARGET
  MACOSX_DEPLOYMENT_TARGET = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64-apple-darwin
  CFLAGS_x86_64-apple-darwin = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64_apple_darwin
  CFLAGS_x86_64_apple_darwin = None
  cargo:rerun-if-env-changed=TARGET_CFLAGS
  TARGET_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None

  --- stderr
  running "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-arch" "x86_64" "-mmacosx-version-min=10.7" "-I" "include" "-Wall" "-Wextra" "-pedantic" "-pedantic-errors" "-Wall" "-Wextra" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wenum-compare" "-Wfloat-equal" "-Wformat=2" "-Winline" "-Winvalid-pch" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wundef" "-Wuninitialized" "-Wwrite-strings" "-fno-strict-aliasing" "-fvisibility=hidden" "-fstack-protector" "-gfull" "-DNDEBUG" "-c" "-o/root/src/target/x86_64-apple-darwin/release/build/ring-3ff2fa40296a8238/out/aesni-x86_64-macosx.o" "/root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.16.20/pregenerated/aesni-x86_64-macosx.S"
  cc: error: x86_64: No such file or directory
  cc: error: unrecognized debug output level 'full'
  cc: error: unrecognized command line option '-arch'
  cc: error: unrecognized command line option '-mmacosx-version-min=10.7'
  thread 'main' panicked at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ring-0.16.20/build.rs:656:9:
  execution failed
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
make: *** [Makefile:31: community_darwin64] Error 101

Fix by commit ab6d851


ARROW-11297: [C++][Python] Add ORC writer options

9702

 Quality gate: Failed
37 Issues

 1 Vulnerabilities
 34 Code issues
 2 Anti-patterns

Details


Properties panel handle does not get detached

Steps to reproduce:

edit a label of a task using the XML tab

Problem:

duplicate handles are created

moved to https://github.com/bpmn-io/bpmn-js-properties-panel/issues/71


Finalize support of Brave

Support for Brave was not fully implemented (not part of the supported reminder applications)

Strange it works on my side.


Nadro/adhoc/center rectangle

closes https://github.com/KittyCAD/modeling-app/issues/4402
Implements

Used the placeholder we have for Center Rectangle in the toolbar and updated it with the new state
Implemented a workflow similar to Rectangle but for Center Rectangle
Center Rectangle is enabled in the rectangle dropdown menu
Several type narrowing functions for different expressions
Fixed createLiteral definition since it didn't actually use the type LiteralValue

Gotchas

Toolbar UX issue are apparent in this ticket but the work will be done in https://github.com/KittyCAD/modeling-app/issues/4469
We are using the same modtifyAST for rectangle for center rectangle
Once the center rectangle is created, it edits as if it is a rectangle not a center rectangle due to the handler
The initial point the user clicks is "wrong" in the KCL code within the startProfileAt but once they click into the second state for dragging the width and height it will be corrected since there is dimension to the box. It effectively says the startProfile at is the center with width/height of 0.

Future improvements

Do we need a kcl standard library call for center rectangle?
Do we need a new handler for center rectangle so it only allows center point moving and matched dimensions dragging for height and width?


Use Redis 6.2.6 in omnibus-overrides

Previously upgrading to Redis 6.x broke builds. We need to resolve these issues and bump the omnibus-overrides pin to 6.2.6
Acceptance Criteria

Pin is bumped to 6.2.6
Adhoc builds are successful at 6.2.6

This is in JIRA now


[Feature] Multi-Node Copy and Paste Functionality

Hi,
First of all, I would like to express my gratitude for creating such a wonderful open-source project like Nodify. It has been incredibly helpful in my work and I truly appreciate the effort and dedication put into it.
I was wondering if it would be possible to implement a feature that allows for the copy and paste of multiple nodes. This functionality would greatly enhance the usability and efficiency of the tool, especially for complex projects involving numerous nodes.
Thank you for considering this request. I look forward to your feedback.
Best regards,

There is a seperate branch in the PRs where such function exists, in the main one its not useful as copy&paste depend on a data model being present. The library being view model only, thus doesnt have much sense to have such function. From experience i can say its doable pretty easy once datamodel and serialization is in place (just serialize Selected nodes, and deserialize them while offseting and switching selection).

Thank you for your response. I appreciate the clarification regarding the separate branch and the rationale behind not including the copy & paste functionality in the main branch. It makes sense given the view model-only nature of the library.
I am currently working on implementing this feature as well. Serializing the selected nodes has been straightforward, but I am encountering an issue with restoring the connections when pasting. I am seeking advice on how to effectively manage the connections during the deserialization process. Any insights or suggestions would be greatly appreciated.

e.g. each node and also each connection should have an uuid Serialize list of nodes and connections indepently. connection is start uid + connector index + enduid + connector index.
On deserialize keep track of the node uids, generate new ones for all nodes/connections, replace them in the connections to be recreated. Create then all nodes with some offset on the graph. Then recreate the connections with the exchanged uids.

Thank you for sharing your approach. I was also looking into the node serialization method on the feature/new-blueprint branch, and your explanation has provided me with a clearer understanding. My previous method of serializing and restoring all connections and nodes was indeed inefficient. Your insights have been very helpful.


Initial support for aggregation pipelines

Description
Closes #1410.
Readiness checklist

[ ] I added/updated unit tests.
[ ] I added/updated integration/compatibility tests.
[x] I added/updated comments and checked rendering.
[x] I made spot refactorings.
[x] I updated user documentation.
[x] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

Tigris and tests will be done in #1891


Feat/160 explorer theme switcher

Closes #160

For AlphaLyrae font files we should have separate lib that will produce fonts.css with
@font-face { font-family: "AlphaLyrae-Medium"; src: url("./AlphaLyrae.woof") }
Where font files are imported from package sourced from https://github.com/vegaprotocol/alpha-lyrae
Then deployment pipeline to static.vega.xyz/fonts.css and
<link rel="stylesheet" href="//static.vega.xyz/fonts.css"> in app index template


Migrate Mini connect playground to v5 in connect landing page

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR updates wallet functionality in the dashboard:
Detailed summary

Updated wallet options and social login methods
Improved theme selection and modal size handling
Removed unused components and assets

The following files were skipped due to too many changes: apps/dashboard/src/components/wallets/ConnectWalletMiniPlayground/MiniPlayground.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#4249  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on  Graphite


fix(cloud): mideaair request fails on http exception

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 6.43%. Comparing base (27be5bc) to head (3758fa8).

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #44      +/-   ##
========================================
+ Coverage   6.40%   6.43%   +0.03%
========================================
  Files         77      77
  Lines       6585    6585
========================================
+ Hits         422     424       +2
+ Misses      6163    6161       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Sample] Generate event

Problem Statement
Generate a custom Event when a user exec's into a Pod.
Solution Description
apiVersion: kyverno.io/v2beta1
kind: ClusterPolicy
metadata:
  name: audit-pods
spec:
  background: false
  rules:
  - name: generate-event-on-exec
    match:
      any:
      - resources:
          kinds:
          - Pod/exec
    context:
    - name: parentPodUID
      apiCall:
        urlPath: "/api/v1/namespaces/{{request.namespace}}/pods/{{request.name}}"
        jmesPath: "metadata.uid"
    generate:
      apiVersion: v1
      kind: Event
      name: "exec.{{ random('[a-z0-9]{6}') }}"
      namespace: "{{request.namespace}}"
      synchronize: false
      data:
        firstTimestamp: "{{ time_now_utc() }}"
        involvedObject:
          apiVersion: v1
          kind: Pod
          name: "{{ request.name }}"
          namespace: "{{ request.namespace }}"
          uid: "{{ parentPodUID }}"
        lastTimestamp: "{{ time_now_utc() }}"
        message: An exec was performed by {{ request.userInfo | to_string(@) }} running commands {{ request.object.command }}
        reason: Exec
        source:
          component: kyverno
        type: Warning

Example "Good" Resource
No response
Example "Bad" Resource
No response
Other Comments
No response
Slack discussion
No response
Troubleshooting

[X] I have read and followed the documentation AND the troubleshooting guide.
[X] I have verified the policy does not exist in the samples library.

Generate an Event upon editing of a ConfigMap named foocm:
apiVersion: kyverno.io/v2beta1
kind: ClusterPolicy
metadata:
  name: audit-cm
spec:
  background: false
  rules:
  - name: generate-event-on-edit
    match:
      any:
      - resources:
          kinds:
          - ConfigMap
          names:
          - foocm
    preconditions:
      any:
      - key: "{{ request.operation }}"
        operator: Equals
        value: UPDATE
    generate:
      apiVersion: v1
      kind: Event
      name: "edit.{{ random('[a-z0-9]{12}') }}"
      namespace: "{{request.object.metadata.namespace}}"
      synchronize: false
      data:
        firstTimestamp: "{{ time_now_utc() }}"
        involvedObject:
          apiVersion: v1
          kind: ConfigMap
          name: "{{ request.name }}"
          namespace: "{{ request.namespace }}"
          uid: "{{request.object.metadata.uid}}"
        lastTimestamp: "{{ time_now_utc() }}"
        message: This resource was updated by {{ request.userInfo | to_string(@) }}. The previous contents were {{request.oldObject.data}}.
        reason: Edit
        source:
          component: kyverno
        type: Warning


FirstActivity name in center.

@opticod
Solved #298
please check.

Closing as already discussed in https://github.com/BuildmLearn/BuildmLearn-Toolkit-Android/pull/242


Estimate task "MM snap for all gas tokens"

See estimation in this ticket: https://github.com/celo-org/celo-monorepo/issues/10253


Fix/modal spacing

💬 Description
I noticed our InputConfirmationModal looks a bit off in the app. I think the cross hair close button needed moving to the top right. I also spotted that the .modal--cleared is centring the buttons/content in the footer - I think this is supposed to be the responsibility of .modal--centred, looks like a copy paste error to me - this is now fixed.
📹 GIF (optional)
Before:

After:

This modal can now use the .modal--cleared class, instead of setting classNames directly, which is causing all the padding to disappear in the app.

🚪 Start Points
Commit by commit
✅ Checklist

[ ] Tests written
[x] Browser tested
[ ] Added to documentation
[x] Added to storybook

 Modal fixes

@p34ks and I made a couple more changes to the button in Figma and in Gather-ui - namely adding a small margin around the top-right corner.


Tables not rendered with nice style

It would be great to render tables with the same style!

Thanks for the issue!
This one will be a little hard to solve - a good chunk of notebook styling on observablehq.com is copyrighted to Observable Inc. and is only available if you copy/paste directly from their compiled HTML <style> tags. The Inspector CSS is open sourced (for things like inspector arrays, object, etc.) and is already used in this Atom package, but it doesn't provide styling for markdown elements (table styles, code blocks, etc).
For a quick fix, I've made v0.4.1 that defaults to github markdown styling. Ideally, I think we should have our own custom styling that more closely resembles observablehq styling and that can be used in other Observable extensions (VS Code, standalone apps, etc.), but I think Github Markdown styling is "good enough" for now.
Let me know if you like the new styling! If there's more desire from others for more observablehq-like styled components, then I'll make a new issue to track that.

awesome! I consider this resolved


When will the training code be available?

Hi,  Mr Deng,  do you plan to release the complete training code in the future ? A implementation in tensorflow is popular for novice like me。

Hi. Mr Deng, I have try to reproduce the work in human pose estimation, but I get some problem about the loss function for embedding map. The value of the generated embedding map is so small and there is almost no absolute value distance between the reference embedding of different person. I have try a lot to deal with this problem, but it does not work.
So, do you plan to release more detail about the loss function？I will be very grateful about that.

Hi. Mr Deng, I have try to reproduce the work in human pose estimation, but I get some problem about the loss function for embedding map. The value of the generated embedding map is so small and there is almost no absolute value distance between the reference embedding of different person. I have try a lot to deal with this problem, but it does not work.
So, do you plan to release more detail about the loss function？I will be very grateful about that.

@jin-miao-cai Hi, i met the same issue before. I changed the penalty for group loss where the first penalty should be normalized by a smaller weight(i.e., 1/(N*K) instead of 1/N). It seems work, but it will hurt the precision on heatmap regression.

The training code is now up: https://github.com/umich-vl/pose-ae-train

@anewell Great!  Thanks so much~


Tool to restore window positions when switching monitors

Summary of the new feature/enhancement
Nowadays mobile computers are very common as the primary work device, multiple monitor setups are also becoming more and more popular.
Unfortunately the switching from the one laptop screen to the 2 or 3 screans at work and than later to the other monitors at home is not a good user experience as one than every time has to re arrange all the windows in the proper order.
A tool that for every monitor configuration remembers where each window goes and upon switching screens moves and resizes the windows accordingly would be extremely useful.
Please add ;)

Hi @DavidXanatos
thank you for the suggestion.
There might be another one similar to this already, so in case we will close this one and link it to the other
Thank you.

Seems a duplicate of this earlier ticket https://github.com/microsoft/PowerToys/issues/261

tracking in #261


go.mod should be tidy up by go mod tidy?

I found ctop is written by golang.
That means I can install it by go install if I had install golang?
I try like:
✗ go install github.com/bcicen/ctop@latest

But I got this:
go: github.com/bcicen/ctop@latest (in github.com/bcicen/ctop@v0.7.7):
        The go.mod file for the module providing named packages contains one or
        more replace directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.

Then I found go.mod in project:
module github.com/bcicen/ctop

require (
	github.com/BurntSushi/toml v0.3.1
	github.com/c9s/goprocinfo v0.0.0-20170609001544-b34328d6e0cd
	github.com/fsouza/go-dockerclient v1.7.0
	github.com/gizak/termui v2.3.1-0.20180817033724-8d4faad06196+incompatible
	github.com/hako/durafmt v0.0.0-20210608085754-5c1018a4e16b // indirect  --------------- this line
	github.com/jgautheron/codename-generator v0.0.0-20150829203204-16d037c7cc3c
	github.com/mattn/go-runewidth v0.0.2
	github.com/nsf/termbox-go v0.0.0-20190121233118-02980233997d
	github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
	github.com/op/go-logging v0.0.0-20160211212156-b2cb9fa56473
	github.com/opencontainers/runc v1.1.0
	github.com/pkg/browser v0.0.0-20201207095918-0426ae3fba23
	github.com/pkg/errors v0.9.1
	github.com/stretchr/testify v1.4.0
)

I clone the project, and run go mod tidy,
I got go.mod like:
module github.com/bcicen/ctop

require (
	github.com/BurntSushi/toml v0.3.1
	github.com/c9s/goprocinfo v0.0.0-20170609001544-b34328d6e0cd
	github.com/fsouza/go-dockerclient v1.7.0
	github.com/gizak/termui v2.3.1-0.20180817033724-8d4faad06196+incompatible
	github.com/hako/durafmt v0.0.0-20210608085754-5c1018a4e16b   // ---------- this line changed without indirect
	github.com/jgautheron/codename-generator v0.0.0-20150829203204-16d037c7cc3c
	github.com/mattn/go-runewidth v0.0.2
	github.com/nsf/termbox-go v0.0.0-20190121233118-02980233997d
	github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
	github.com/op/go-logging v0.0.0-20160211212156-b2cb9fa56473
	github.com/opencontainers/runc v1.1.0
	github.com/pkg/browser v0.0.0-20201207095918-0426ae3fba23
	github.com/pkg/errors v0.9.1
)

Is this bug? Should I PR to fix it?
Or ctop just make it like that to let user DO NOT install ctop by go install?

It's not bug. In my opinion It would be a good practice execute go mod tidy, go vet ./... before commit


Ignore just born mobs from count

Would be really nice to ignore just born mobs from the chunk_max counter as if I set chunk_max to 2 animals can't breed.

This functionality is by design. chunk_max is meant to be the highest amount ever possible to be in a chunk. It's a hard cap that prevents things like runaway spawners...or players intentionally breeding way too many mobs.
If you use the cull setting instead, MobLimiter will sweep over mobs and prune them down to the desired amount (e.g. 2) when the chunk unload. The chunk_max should definitely be higher than two.


chore(): update deps

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build (npm run build) was run locally and any changes were pushed
[ ] Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

I checked screenshot before I updated this to fix merge conflicts. Looks good to me. 👍


Look into why MAD competition tests take so long

I think because I test so many variants, but double-check and see if they can be simplified in any way.

reduce max_iter
consider running once and then testing all possible after the fact methods
reduce number of arguments? related to #75

test_display also takes a long time, due mainly to TestMADDisplay I think, same basic issues as in test_mad.py

test_display::TestMADDisplay::test_all_plot_animate does seem to take a fair amount of time in each call

Figured out a way to rearrange test_display.py to take less time (in #93): moved out the Metamer / MADCompetition objects to a fixture that was shared across class. Something like this will work with test_mad.py, I think.

Also, reduce the number of times that images are loaded, models are instantiated, and synthesis is called.

closed by #115


Filtering Top N values

Currently i am using the superset version 0.18.5 . My source Database is Mysql , one of my requirement is to display the top '5' departments by revenue across years , months and quarter . Is there any way to do this in superset . Also I would like to know whether we can use the custom queries as input to the visualization .

It's unclear to me what you mean by "display the top '5' departments by revenue across years , months and quarter". What type of visualization? time series? a table?
And yes you can use custom queries as input. The easiest way is to click [Visualize] from a SQL Lab result set.

Notice: this issue has been closed because it has been inactive for 258 days. Feel free to comment and request for this issue to be reopened.

Hi ,
i am having same concern for filtering the top 5 values based on metrics

Hi ,
i am having same concern for filtering the top 5 values based on metrics


Premium Wood

Adds Premium Wood models/recipes, closes #276
Adjust for Quark changes to blossom trees, closes #275

Thanks!


pkg/pod: simplify orderContainers returns

Changes
Small refactoring on pkg/pod, simplifying orderSteps function (less arguments to pass, less return vaule).
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
NONE

The commit message is quite bare-bones at the moment. Any other info you can include there explaining the motivation for moving the code around?

Yeah, I need to migrate the tests.. for some reason.. I thought I did when submitting the PR 😅
/hold

Updated the commit message a bit.

thanks @vdemeester
/lgtm


Allow for large (>2GB) files on Linux

The PHP functions filemtime() and filesize() fail on Linux if the file is
larger than 2GB - the max 32 bit integer. This fix detects the failure and
uses the Linux 'stat' command to retrieve the information.

Thanks for this, however I have reservations on using the escapeshellarg() function from a security standpoint.  In my opinion (and those of many security professionals) calling shell commands from PHP is a big no-no.   I'll have to evaluate the potential security risks and decide if this (or another approach) are reasonably secure.  In the mean time, the REAL solution  to this issue is to make sure you're running Directory Lister on a 64-bit OS if you require accurate modified times and file sizes.
That being said, I do feel that this issue could use some improvement.  Perhaps implementing some "graceful degradation" in the event users are stuck on 32-bit OSes and want to use Directory Lister.

Feel free to not use it. I deployed it to a hosting service, so I have no control over the OS.


Updating my LinkFree page

Added some new links to my LinkFree page.

just remove the , from line 43

just remove the , from line number 43

Did that just now, thanks for correcting.

just remove the , from line number 43

Did that just now, thanks for correcting.

cool


add React Summit remote 2021

Adding newly announced React Summit Remote edition in April 2021.

@operatino thanks!