Optimize alloc

Looks good overall but there are some borrow-checking issues and ChunkList::len seems to be unused.
A couple notes, though, unless you need to support stable Rust you may want to use arena::TypedArena distributed with rustc instead. Also, I made this crate to support some experiments, but I’m not really using it now. (I went with reference-counted nodes for Kuchiki.) So if you want to maintain it I’m happy to give repository and crates.io access.

Oh, I forgot to test before pushing.
Cool experiments. Why did you choose Rc? I'm using arenas for parse forests. Also, I'd be happy to maintain this repository.

I'm in the middle of optimizing rustc's TypedArena as well.

Roughly, my conclusion is that it’s a trade off: was Rc for a convenient API, a typed arena for the last bit of runtime performance, and vectors + IDs for multithreading (having &mut Graph for the entire thing means you don’t need cells, and no other thread can make the graph inconsistent from under you). I chose to favor convenience in Kuchiki.

Looks good, thanks!


python39Packages.pyeclib: 1.6.0 -> unstable-2022-03-11, python39Packages.python-novaclient: 17.6.0 -> 17.7.0

this fixes python 3.9 and 3.10 support
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
Result of nixpkgs-review pr 165996 run on x86_64-linux 1

1 package failed to build and already failed to build on hydra master:

python310Packages.python-openstackclient: log was empty

7 packages built:

openstackclient (python39Packages.python-openstackclient)
python310Packages.pyeclib
python310Packages.python-novaclient
python310Packages.swift
python39Packages.pyeclib
python39Packages.python-novaclient
python39Packages.swift


Surveyor seal image preview doesn't change

upload and save surveyor seal image
exit profile, then go back into profile
click Remove
click Choose File, and upload new image
the originally-uploaded image appears in the preview (I haven't tested yet whether the proper image appears on a "new" tiesheet)

no actual images are used in the tiesheets yet

this is a bit of a head scratcher. I'm going to side line it a bit to make some progress on some other items. Hopefully it's a not so common use case that won't give too many people an issue.

this looks like a duplicate of #151 also

added this info to #151 and closing


Use github permalink instead

Currently a link referencing the current branch is opened, which will break if/when that branch is deleted, so use the Github permalink form, containing the commit hash, instead.

Hi, thanks for the PR 👍


[Feature request] Add * support for sidebar

Clear and concise description of the problem
Now the sidebar added page can only be identified by filling in the relative complete path, but in most cases a sidebar file will be placed in a directory. If wildcard paths are supported, a lot of code will be reduced.
现在sidebar添加页面只能通过填写相对的完整路径才能识别，但是绝大多数情况下一个sidebar的文件会放在一个目录下，如果支持通配符路径将会减少很多代码量
Suggested solution
I thought of two solutions
1.Add * to support automatic matching path
2. Allow users to add folders
我想到了两个解决方法
1.添加*的支持自动匹配路径
2.允许用户添加文件夹
Alternative
No response
Additional context
No response

It seems that you may want: https://theme-hope.vuejs.press/guide/layout/sidebar.html#generate-from-file-structure

Yes, but for people like me who only wrote the beginning, it's okay, but for people who have written a lot, the workload of porting from the default theme to a third-party theme is still very large. If it can be merged into the official theme, it will be more  good
是的，但是对于像我这种只写了开头的人还好，但是对于已经写了很多的人来说，从默认主题移植到第三方主题工作量还是很大，如果能合并到官方主题更好

The default theme is designed to be slim and out of box, features are almost solid.
theme-hope should work out of box with default theme except <CodeGroup> are replaced by codeTabs


feat(support-universal-runtime): adopt all changes needed for create-helix-service to create universal runtime functions by default

BREAKING CHANGE: switch from openwhisk-action-builder (targeting Adobe I/O Runtime) to helix-deploy (targeting Universal Runtime)

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


willgit: fixed url

the url was wrong and could not be cloned,
I also added a short description and updated the link, to the real homepage

Merged in https://github.com/Homebrew/homebrew-head-only/commit/bc6757fc39ae2d2e853614198591ec5e7da2f3d8. Thanks for your contribution to Homebrew/head-only, We appreciate it! :smiley_cat:


Getting Error after upgrading to new version

Im getting this error message when im start my project after upgrading  to new version
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:21:45 Unresolved reference: YuvToRgbConverter
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:34:40 Unresolved reference: MobileScannerCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:35:45 Unresolved reference: MobileScannerErrorCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:88:52 Unresolved reference: data
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:91:48 Unresolved reference: data
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:101:43 Unresolved reference: YuvToRgbConverter
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:214:29 Unresolved reference: TorchStateCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:215:33 Unresolved reference: ZoomScaleStateCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:216:39 Unresolved reference: MobileScannerStartedCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:393:52 Unresolved reference: AnalyzerCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScanner.kt:398:68 Unresolved reference: data
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:23:33 Unresolved reference: BarcodeHandler
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:25:30 Unresolved reference: MobileScannerPermissions
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:29:35 Unresolved reference: AnalyzerCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:45:27 Unresolved reference: MobileScannerCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:62:32 Unresolved reference: MobileScannerErrorCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:73:37 Unresolved reference: TorchStateCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:77:41 Unresolved reference: ZoomScaleStateCallback
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:111:25 Unresolved reference: MobileScannerPermissions
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:112:21 'onResult' overrides nothing
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:115:29 Unresolved reference: MobileScannerPermissions
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:178:36 Not enough information to infer type variable V
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:179:40 Unresolved reference: it
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:180:32 Not enough information to infer type variable B
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:180:35 Not enough information to infer type variable V
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:180:52 Unresolved reference: it
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:180:74 Unresolved reference: it
e: file:///C:/Users/meiser/AppData/Local/Pub/Cache/hosted/pub.dev/mobile_scanner-3.5.3/android/src/main/kotlin/dev/steenbakker/mobile_scanner/MobileScannerHandler.kt:181:40 Unresolved reference: it

Can you try

flutter clean
flutter pub cache repair
flutter pub get

Version 3.5.3 has been retracted due to a critical issue on iOS. Could you retry with version 3.5.4?

Still happens on 3.5.4, seems to be a problem that happens only in Windows, on MacOS with the same project works fine for me

Failed to build iOS app
Semantic Issue (Xcode): Duplicate interface definition for class 'MobileScannerPlugin'
/Users/dev/rtkit/remote/build/ios/Debug-iphonesimulator/mobile_scanner/mobile_scanner.framework
/Headers/MobileScannerPlugin.h:2:0

Modules Issue (Xcode): Definition of 'MobileScannerPlugin' must be imported from module
'mobile_scanner.Swift' before it is required
/Users/dev/rtkit/remote/ios/Runner/GeneratedPluginRegistrant.m:62:3

Could not build the application for the simulator.
Error launching application on iPhone 14.

I got these errors which went away eventually on macos, still persist in windows though

@SputNikPlop building for iOS is only supported when the host is a MacOS device.
The duplicate interface issue should have been fixed a while back anyway.
Make sure you are on the latest version of the plugin.

Collaborator

I am on mobile_scanner: 3.5.5 and see the exact same issue:
Running Xcode build...
Xcode build done.                                           316,6s
Failed to build iOS app
Semantic Issue (Xcode): Duplicate interface definition for class 'MobileScannerPlugin'
/Users/patrick/development/flutter-projects/mobileraker/build/ios/Debug-iphonesimulator/mobile_scanner/mobile_scanner.framework/Headers/MobileScannerPlugin.h:2:0

Modules Issue (Xcode): Definition of 'MobileScannerPlugin' must be imported from module 'mobile_scanner.Swift' before it is required
/Users/patrick/development/flutter-projects/mobileraker/ios/Runner/GeneratedPluginRegistrant.m:208:3

Could not build the application for the simulator.
Error launching application on iPhone 15 Pro.

@Clon1998 In this order try
flutter clean
flutter pub cache repair
flutter pub get

Please check the steps above and then give us your flutter doctor output.

flutter pub get

That worked, thanks!

@LauMeiso are you still getting this issue after doing a repair of your pub cache, as noted in https://github.com/juliansteenbakker/mobile_scanner/issues/876#issuecomment-1822721253 ?

As this issue seems to be resolved after doing a flutter clean && flutter pub get I'm going to close this issue.


Scale down TensorBoard UI within iframe

Today the TensorBoard UI looks somewhat misplaced within VSCode because it appears more zoomed in than the rest of the VSCode UI and doesn't pick up VSCode's font sizes. To address this, this PR does the following:

Scales the contents of the iframe that the TensorBoard UI is hosted in down; since we don't own the TensorBoard UI we can't directly style it. However, this shrinks the entire iframe and not just its contents, so this PR also
Sets the iframe width and height attributes whenever the window is resized and hides scrollbars from overflow so that the TensorBoard UI fills all available space in the window.

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[x] Title summarizes what is changing.
[ ] ~Has a news entry file (remember to thank yourself!).~
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).
[ ] The wiki is updated with any design decisions/details.

@joyceerhl The code changes seem solid for now, but it's just at a fixed scaling level currently, right?
Wonder if the next step here would be reflecting the vscode window.zoomLevel setting. That's the setting that controls overall vscode UI zoom level (not just editor font size) and is a pretty important accessibility feature. But I don't think that it's required to honor that right now. Maybe file a bug on that? What do you think?

@IanMatthewHuff When running the View: Zoom In/Out commands, the iframe and its contents do also adjust because we're using window.innerHeight and window.innerWidth to redraw the iframe on every resize. Is this what you're asking about?

Codecov Report

Merging #14992 (1303af6) into main (cbfa382) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #14992   +/-   ##
======================================
  Coverage     65%      65%
======================================
  Files        557      557
  Lines      26210    26210
  Branches    3716     3716
======================================
  Hits       17056    17056
  Misses      8459     8459
  Partials     695      695

@joyceerhl Nice! Didn't realize that the inner height / width values would reflect the zoom change. Looks good.


revertedWith failing when using local Hardhat node

Describe the bug
When unit testing in a local hardhat node accessible through localhost endpoint with ethereum-waffle 4.0.7, the to.be.revertedWith matcher fails with the following reason:
TypeError: errorString.startsWith is not a function
      at decodeRevertString (./node_modules/@ethereum-waffle/provider/dist/cjs/revertString.js:41:21)
      at onError (./node_modules/@ethereum-waffle/chai/dist/cjs/matchers/revertedWith.js:12:367)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

Following the code to revertString.js it seems that getHardhatErrorString is not able to parse the revert message. Instead the getGanacheErrorString is used and an object is returned:
{
  message: "Error: VM Exception while processing transaction: reverted with reason string 'AccessControl: account 0x70997970c51812dc3a010c7d01b50e0d17dc79c8 is missing role 0x0000000000000000000000000000000000000000000000000000000000000000'",
  data: '0x08c379a000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000094416363657373436f6e74726f6c3a206163636f756e7420307837303939373937306335313831326463336130313063376430316235306530643137646337396338206973206d697373696e6720726f6c6520307830303030303030303030303030303030303030303030303030303030303030303030303030303030303030303030303030303030303030303030303030303030000000000000000000000000'
}

Changing the following line in revertString.js:
return (_a = callRevertError === null || callRevertError === void 0 ? void 0 : callRevertError.error) === null || _a === void 0 ? void 0 : _a.data;

to
return (_a = callRevertError === null || callRevertError === void 0 ? void 0 : callRevertError.error) === null || _a === void 0 ? void 0 : _a.data.data;

(notice the double .data.data at the end) seems to do the trick.
My guess is that Hardhat has updated the way they emit the revert message in localhost and ethereum-waffle is not able to parse it anymore. When unit testing using internal Hardhat, the unit tests work correctly, which tells me it is only a problem when running the local instance of Hardhat.
To Reproduce

Run a local instance of Hardhat 2.12.2
Use ethereum-waffle 4.0.7
Use the revertedWith matcher to catch a revert

Software versions

ethereum-waffle 4.0.7
@nomiclabs/hardhat-waffle 2.0.3
@nomiclabs/hardhat-ethers 2.1.1
hardhat 2.12.2
Package manager: yarn
Node version: 16.14.0
Solidity version: 0.8.14

Thanks, we will double down on this.

My guess is that Hardhat has updated the way they emit the revert message in localhost and ethereum-waffle is not able to parse it anymore. When unit testing using internal Hardhat, the unit tests work correctly, which tells me it is only a problem when running the local instance of Hardhat.

That sounds like it. We do unit tests against different versions of in-memory Hardhat, but looks like we're gonna have to expand those tests with localhost Hardhat.
@robercano Could you share your exact process of starting the localhost instance of Hardhat? Might come in handy for debugging. (like through npx, or differently?)

Great! Thanks for the prompt reply.
We are currently using nx so the actual command line is:
yarn nx run contracts:hardhat-localnode
which in turn executes:
hardhat node --hostname <IP_ADDRESS>
Let me know if you need more context.

Hi @robercano, can you please send some example test where the problem occurs? Because I've reproduced all your steps and I cannot reproduce the error.

I've tried all morning to prepare a repo but I cannot make it fail. I've used the same package.json and yarn.lock as in the original repo, but it works properly in the reproduction repo, so I'm not sure what to say. I guess it works and we just have a bad package. I've noticed that the ethers package package.json is different in the 2 repos for the same exact version of ethers, so maybe we cached something wrong. I've tried to remove the cache, update the packages and allow to update the checksums, and more things, but cannot reproduce it in a new repo. In our repo it still fails. I guess you can ignore this until we figure out what's going on! Thanks a lot a sorry for the noise.

Please let me know how things are going and if there is indeed something wrong we will reopen the issue.


Package hls_utils

Also, take the opportunity to refactor https://github.com/orcasound/aifororcas-livesystem/tree/main/InferenceSystem/src/hls_utils

Test repo: https://github.com/Molkree/orcasound-hls-utils
Package on Test PyPI: https://test.pypi.org/project/orcasound-hls-utils/
Some questions:

License: I've put MIT and I guess it's alright to keep it.
Build system: for now I've just copied stuff from Packaging tutorial, so it's setuptools>=42 and wheel.
Readme: just put in two sentences, probably need to add more!
Metadata (in setup.cfg):

What should be the package name? For now I've made it orcasound-hls-utils (this is what shows up on PyPI). Related to it is the package name (the one you use when importing in the code, orcasound_hls_utils now) and repository name (orcasound-hls-utils now).
How will the versioning work? Right now the version is specified in the setup.cfg
Who is the author? (left author/email with placeholders)
Short description: "Collection of utilities for getting Orcasound HLS data" now.

I will transfer the repository under Orcasound organization when it's ready.
P.S. Oh, and I forgot to add requirements.txt, will do now 😅
@prakruti, am I moving in the right direction?

Sounds great @Molkree! I was earlier wondering if it would be possible to publish from the livesystem repo itself but I guess this is the right thing to do is to create a separate repo for it. Thanks!

So one of the next steps should be removing the code from this repo and instead using the package. I guess for that I'll need to run  InferenceSystem locally to test that everything works. Correct, @prakruti?

I guess for that I'll need to run InferenceSystem locally to test that everything works.

Had to fight with my installed Python versions a bit, I know it was only tested on 3.7 but couldn't stop trying newer:

I had little hope that Python 3.10 on Win would work and it didn't because numpy can't be built, I have abandoned it.
Python 3.9.5 in Ubuntu didn't work because pip can't find torchaudio==0.6.0 (maybe we should update it in the future)
Python 3.8.10 worked after installing gcc and python3-dev (sudo apt install gcc python3-dev, note that my Ubuntu has 3.8 as default but you might need to specify python3.8-dev) and wheel (python -m pip install wheel)

Local inference worked fine after that.
Now to testing, I have just replaced hls_utils.* imports with orca_hls_utils.* imports and installed the package. After trying to run inference again I have discovered that I made a mistake in orca-hls-utils dependencies and added python-ffmpeg instead of ffmpeg-python. Both packages exist and they are incompatible! Funny thing is that I made the same mistake when I worked with ffmpeg from Python over this summer. So I have fixed this dependency in the package and released a new version 0.0.2. Everything seems to work correctly now.
I'll be sending PR removing the code from this repo and adding a new dependency tomorrow.


Document self-hosting recommendations

It might be useful to collect best practices and general recommendations for users that want to self-host ZITADEL. Based on current conversations, it might make sense to provide some information around the following topics. We could put it under Installation
System requirements:

Compute
Database
Storage

Operational

Load balancing
Redundancy
Backups

Operational security

DoS Protection
Rate limiting
TLS

Relates to https://github.com/zitadel/zitadel/discussions/2079

Asked again here: https://discord.com/channels/927474939156643850/927474939156643853/1017360779747536947

@eliobischof @fforootd are these points currently answered in the docs in your view? What's missing from that list?
I think we did a good improvement with https://docs.zitadel.com/docs/guides/manage/self-hosted/production

I think that's fine for the moment.
Lets see first what else people want to see.


Animation fix baby steps

Add a scroll speed configuration option.  Also, set show_full_animation = True so people can get the full quotes. They may be a little long, but not so long that folks who installed this app will be annoyed. They can speed the scrolling up if they really want to speed through this app.

Sorry about the icons! It was moved to pixlet: https://github.com/tidbyt/pixlet/blob/main/icons/icons.go

No worries, thanks for the updated link. Some other folks were asking on discord, I’ll post a follow up with this! On Feb 8, 2023, at 2:14 PM, Mark Spicer @.***> wrote:
Sorry about the icons! It was moved to pixlet: https://github.com/tidbyt/pixlet/blob/main/icons/icons.go
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Edit your attendace

Add the capability of editing the attendance of a particular subject i.e. the number of missed and the number of attended classes for that particular subject. After that the overall attendance should be calculated again automatically and update the attendance at the home page.

Also add an option to undo the last entry in popup menu under delete option

If this item is unresolved, I'd like to make an attempt at this.

If this item is unresolved, I'd like to make an attempt at this.

@arcanearronax  Sure, Go ahead. I'll assign it to you. If you have worked with room and live data I would recommend you to attempt this in MVVM branch

@arcanearronax Any update on this feature?

@sjain30 sorry for the delay, I should be done with it hopefully in the next week. Home and work life have been a bit more demanding than I expected.

@arcanearronax, unfortunately, I have to unassign you from this issue since we needed this issue solved immediately I did it myself.


Added required listener to removeEventListener()

What kind of change does this PR introduce? (check one with "x")

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
See issue #237. Application throws error when removeEventListener('scroll') is being called without supplying the listener being added before .
What is the new behavior?
No more error thrown.
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
See documentation: EventTarget.removeEventListener()

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Thanks for the contribution, I actually changed this yesterday morning to use angular's event listening approach. See: https://github.com/swimlane/angular2-data-table/commit/b5067cd134b55f609438e203529c80375c63bfeb

Oh well... cloned your repo just a few hours too early... :-)
It works fine though.


Help with gRPC HTTP / 1.1 reverse bridge: grpc-message mapping.

Help with gRPC HTTP / 1.1 reverse bridge.
Title: Help with gRPC HTTP / 1.1 reverse bridge: grpc-message mapping.
Description:
I'm using the gRPC HTTP / 1.1 reverse bridge and I have the next doubt:
In case of error, (besides the grpc-status "auto" map) is there any way to map an error message to the trailer grpc-message when my upstream does not understand any gRPC semantics?
I would like to avoid passing errors in the body and use the standard way.
Many thanks in advance and excuse my ignorance.
Config:
This is the config I'm using it and working correctly:
admin:
  access_log_path: /tmp/admin_access.log
  address:
    socket_address:
      protocol: TCP
      address: <IP_ADDRESS>
      port_value: 9901
static_resources:
  listeners:
    - name: listener_0
      address:
        socket_address:
          protocol: TCP
          address: <IP_ADDRESS>
          port_value: 10000
      filter_chains:
        - filters:
            - name: envoy.http_connection_manager
              typed_config:
                "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
                stat_prefix: ingress_http
                codec_type: AUTO
                route_config:
                  name: backend
                  virtual_hosts:
                    - name: backend
                      domains: ["*"]
                      routes:
                        - match: { prefix: "/" }
                          route: { host_rewrite: nginx, cluster: backend, timeout: 59.99s }
                http_filters:
                  - name: envoy.filters.http.grpc_http1_reverse_bridge
                    config:
                      content_type: application/grpc+proto
                      withhold_grpc_frames: true
                  - name: envoy.router
                    typed_config: {}
  clusters:
  - name: backend
    connect_timeout: 59.99s
    type: logical_dns
    dns_lookup_family: v4_only
    lb_policy: round_robin
    load_assignment:
      cluster_name: backend
      endpoints:
        - lb_endpoints:
            - endpoint:
                address:
                  socket_address:
                    address: nginx
                    port_value: 80

The filter already injects error messages into grpc-message when it receives an unsupported response. Are you talking about being able to respond with a custom message?

@snowp yes, I was referring to custom message error (even the possibility to customize grpc-status too).

To send a custom message you can just send a header only response (no body) with a header named grpc-message with your message. As log as the content-type matches what the filter expects it should just pass through the grpc-message.
For grpc-status we'd have to make some code changes. Making the filter just pass through the status if the upstream provided one sounds reasonable, would that work for you?

Hi @snowp
I've checked grpc-message pass through using your directions and works as expected.
For example:
HTTP/1.1 request/response (within content-type, content-length: 0, grpc-message headers set)
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 10000 (#0)
> POST /TestAPI/TestMethod HTTP/1.1
> Host: localhost:10000
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 400 Bad Request
< server: envoy
< content-type: application/grpc+proto
< content-length: 0
< x-powered-by: PHP/7.2.15
< grpc-message: custom message for 400 http status code
< cache-control: no-cache, private
< date: Thu, 04 Apr 2019 10:19:12 GMT
< access-control-allow-origin:
< x-envoy-upstream-service-time: 966
<
* Connection #0 to host localhost left intact

gRPC response status (as PHP array, sorry for that. I'm testing with PHP client too)
(
    [metadata] => Array
        (
            [:status] => Array
                (
                    [0] => 400
                )

            [server] => Array
                (
                    [0] => envoy
                )

            [content-type] => Array
                (
                    [0] => application/grpc
                )

            [content-length] => Array
                (
                    [0] => 5
                )

            [x-powered-by] => Array
                (
                    [0] => PHP/7.2.15
                )

            [grpc-message] => Array
                (
                    [0] => custom message for 400 http status code
                )

            [cache-control] => Array
                (
                    [0] => no-cache, private
                )

            [date] => Array
                (
                    [0] => Thu, 04 Apr 2019 10:22:16 GMT
                )

            [access-control-allow-origin] => Array
                (
                    [0] =>
                )

            [x-envoy-upstream-service-time] => Array
                (
                    [0] => 1255
                )

        )

    [code] => 1
    [details] => Received http2 header with status: 400
)

I can see:

http2 status (:status) set to 400
grpc custom message (grpc-message) set to "custom message for 400 http status code"
This is ok and very useful for me.

But I miss the grpc-status in metadata. Related to this: ¿Is it the standard behaviour of the filter (and only sets the grpc-status trailer when response content is not empty)? Or I'm doing or understanding something wrong.
Related to:
snowp: "For grpc-status we'd have to make some code changes. Making the filter just pass through the status if the upstream provided one sounds reasonable, would that work for you?"
I guess this is related to what I said above. The standard mapping would work for me (in that case 11 (400 Bad Request)). If I would want a custom error I could add it into grpc-message using a protocolbuffer serialized as string or checking http2 generic ":status".
Many thanks in advance and apologize for the inconveniences.

Also, I've checked to add grpc-status as response header to do mapping manually and I get the next grpc status:
(
    [metadata] => Array
        (
            [server] => Array
                (
                    [0] => envoy
                )

            [content-length] => Array
                (
                    [0] => 5
                )

            [x-powered-by] => Array
                (
                    [0] => PHP/7.2.15
                )

            [cache-control] => Array
                (
                    [0] => no-cache, private
                )

            [date] => Array
                (
                    [0] => Thu, 04 Apr 2019 10:46:08 GMT
                )

            [access-control-allow-origin] => Array
                (
                    [0] =>
                )

            [x-envoy-upstream-service-time] => Array
                (
                    [0] => 1293
                )

        )

    [code] => 11
    [details] => custom message for 400 http status code
)

Now is not added in metadata but is added in code and details.
Is this behaviour correct?
Or I'm doing or understanding something wrong.
I attach the headers example too (HTTP/1.1 request/response):
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 10000 (#0)
> POST /TestAPI/TestMethod HTTP/1.1
> Host: localhost:10000
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 400 Bad Request
< server: envoy
< content-type: application/grpc+proto
< content-length: 0
< x-powered-by: PHP/7.2.15
< grpc-message: custom message for 400 http status code
< grpc-status: 11
< cache-control: no-cache, private
< date: Thu, 04 Apr 2019 10:52:22 GMT
< access-control-allow-origin:
< x-envoy-upstream-service-time: 1411
<
* Connection #0 to host localhost left intact

Ah yeah, looking over the code again we don't do anything fancy if it's a header only response, so it makes sense that grpc-status is propagated in that case.
I would expect them to not show up in metadata since they are headers with special meaning in gRPC.


Product screen does not have a mobile responsive view

@jaepass Is this supposed to be on the dashboard? Just a heads up, I have an ongoing HD project to make the entire dashboard responsive. The product screen is mostly complete on that branch already so may not be worth tackling this since I plan to PR it next HD.

Ah shucks wrong repo. Ok sounds good, won't tackle this but will just fix all other views with actions card mobile layout.


Your Podfile requires that the plugin cocoapods-binary be installed

If I run it by the book on my macbook pro, with Ruby 2.3.0 installed, I get[!] Your Podfile requires that the plugin `cocoapods-binary` be installed. Please install it and try installation again.
Is there something undocumented that the average user should be privy to, in order to get this going?

gem install cocoapods-binary ?

Hi @mrdavenz , is your project gems managed by Gemfile? If it's so, you should add gem 'cocoapods-binary' to your project's Gemfile.

i have installed succeed. when "pod install",  I get[!] Your Podfile requires that the plugin cocoapods-binary be installed. Please install it and try installation again.

@liuxingIphone did you find a solution for this?

sudo gem install cocoapods cocoapods-binary
sudo gem install -n /usr/local/bin  cocoapods cocoapods-binary

i have installed succeed. when "pod install", I get[!] Your Podfile requires that the plugin cocoapods-binary be installed. Please install it and try installation again.

I run source ~/.zshrc after the installation and then it worked

Thanks @cristipaval, worked for me 😄


javascript highlighting: destructuring over multiple lines breaks highlighting

From @AdamWillden on June 15, 2016 7:5

VSCode Version: 1.3.0 insider
OS Version: Windows 10 x64

Pictures explain this best:

This is okay - destructuring on one line:

This is broken - destructuring over multiple lines:

Copied from original issue: Microsoft/vscode#7696

From @sandy081 on June 15, 2016 8:30
I think this is typescript code.
@dbaeumer Not sure if this has to go to Typescript guys or we own the decorations. So assigning to you.
Thanks

Thanks

Fixed by #257


Chatterino has a memory usage problem

Describe your issue
Chatterino either leaks or retains too much memory for something. Memory usage seems to increase over time, but not linearly - for example my current chatterino instance uses 1.67GB private bytes for 3d3h runtime.
Applications like MTuner might help to find the cause.
Screenshots

OS and Chatterino Version
Win10 20H2 19042.1052
Chatterino Nightly 2.3.2 (commit f9ddd5303, )

Maybe the debug popup (F10) can help.
cf. my one, after a day or so of running

lots of message layout elements

I'm sure messages are leaked somewhere (I had no channels but there were messages) but I can't replicate it consistently.

Yeah, seems like it. I deleted and recreated a couple of splits and managed to get it down to 700k, but I see the number going down sometimes, so there are situations where layout elements are deleted

Is it maybe related to the amount of loaded animated emotes?
In your screenshot you have 1800 animated emotes, and my own count of 837 animated emotes puts my mem usage at 900 MB.

I test this by going into channels with a lot of animated BTTV emotes and opening up the emote window and my memory usage consistently goes up and stays that high until I close the tab: https://streamable.com/eqxqcn

Yes I'm also experiencing this high ram usage. As noticed today, my ram usage was up to 1.6gb. After restarting, it dropped down to 600mb.
When I started testing it, I was on 400mb after a fresh restart with emote hover and link previews turned off. @KararTY suggested I open emote windows in all splits to load the animated emotes. I'm now at 944mb (this didn't change from me going afk):

I went through all my splits today running the !bttvemotes command. I've been at home all day and had chatterino running. 390mb of ram being used.
After running said commands, I'm now up to 1gb being used.

I reached 1.5G of memory today

1.83GB with lower statistics except drawing buffers

4.3GB, seen it sit around 5GB later on in the day.

Isn't most of the memory usage because of animated emotes loaded into ram?
BTTV has a size limit of 1mb (I think) on gifs which would mean having, let's say 1471 animated images, is ~1.44GB of memory if every animted has max size limit.

A little bit of a useless bump.
IMO Chatterino should free unused images from memory but keep the cache and just reload from it. This could save us like half the usage of a high-uptime instance by my guesstimating.

or memory map the files?

It might be worth doing something like unloading all emotes in a chat if you haven't looked at a split of that chat in the past 5 min or something similar. This approach might cause too much disk read though. Also might be very hard to implement, unsure.
Memory mapping might also be a good approach, but only really works if emotes have a lot of overlap between channels. I suspect the biggest issue are the animated emotes and do most channels have similar ones?

Memory mapping might also be a good approach, but only really works if emotes have a lot of overlap between channels. I suspect the biggest issue are the animated emotes and do most channels have similar ones?

While there are a lot of channel-unique animated emotes, a lot of the common ones are still shared across hundreds or thousands of chats. I suspect that this would make a pretty noticeable difference.

Another possible optimization: instead of always pulling default for twitch emotes, could just cache static if the animateEmotes setting is disabled (tho extra logic is needed if the option is toggled)

with PR #3915 I still have an instance with 1.78GB usage, process started 3 days and 9 hours ago

with PR #3915 I still have an instance with 1.78GB usage, process started 3 days and 9 hours ago

keep it running and see how it increases :smiling_imp:

I have reached 2.78GB with 11 days uptime before I wanted to play BeamNG.Drive so I had to restart chatterino

We're more aggressive about releasing emotes now, closing this but feel free to re-open it if you feel like the latest nightly is still eating your memory like crazy.


license text discrepancy

There is a difference in https://www.openssl.org/source/license-openssl-ssleay.txt (linked from https://www.openssl.org/source/license.html) and the LICENSE file in the tar ball distribution:
$ diff --ignore-all-space -u license-openssl-ssleay.txt openssl-1.0.2t/LICENSE
--- license-openssl-ssleay.txt	2019-10-21 16:33:52.346205363 +0200
+++ openssl-1.0.2t/LICENSE	2019-09-10 15:24:10.000000000 +0200
@@ -4,13 +4,15 @@

   The OpenSSL toolkit stays under a double license, i.e. both the conditions of
   the OpenSSL License and the original SSLeay license apply to the toolkit.
-  See below for the actual license texts.
+  See below for the actual license texts. Actually both licenses are BSD-style
+  Open Source licenses. In case of any license issues related to OpenSSL
+  please contact<EMAIL_ADDRESS>
   OpenSSL License
   ---------------

 /* ====================================================================
- * Copyright (c) 1998-2019 The OpenSSL Project.  All rights reserved.
+ * Copyright (c) 1998-2018 The OpenSSL Project.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions

Now, I am not a lawyer so I don't know how big problem this is but certainly this is causing me some grief when dealing with upgrade to the last version internally (meaning inside Oracle).

This is not a change to the actual licence text itself, but to the non-normative preamble. The reference in 1.0.2 to<EMAIL_ADDRESS>is certainly out of date. But since 1.0.2 is in security fix only mode I don't think a fix is necessary here.

Mea culpa.

Given that the text isn't going to be changed, there doesn't seem any reason to keep this open.


feat(logger): add a simple logging module

This PR adds a simple logging module. It uses Winston to do the heavy-lifitng but the API is agnostic to Winston. This is done so that Winston could be replaced by another logging module in the future if desired. The clients of the library will continue to function without any changes. The README document has more information about the module.

Test coverage:

@zdravko-georgiev can you check if this works with logging in ui5 middlewares and tasks?

@zdravko-georgiev can you check if this works with logging in ui5 middlewares and tasks?

@tobiasqueck Checking

Is this how the info supposed to look like in the console?

Is this how the info supposed to look like in the console?

Yes. I can't fault you for not getting all way the way through the README :P

@IainSAP, @zdravko-georgiev, @tobiasqueck: I changed the default format for console to be plain text instead of JSON (it is colored and timestamped though. Piping the output will not use the color encoding - this is to facilitate both manual inspection and text manipulation (color encoding can be distracting and painful to work with)). FileTransport still uses JSON.
@IainSAP, I am slightly deviating from the format used in Fiori tools (levels are not uppercased and the log entry is not enclosed by []). Let me know if you have any concerns with these. (Not using uppercase as I use format.colorize() and it expects lowercased levels. The effort to keep both didn't seem worth it at this point).
An example logger that logs to console and two files simultaneously (the transports are added at different points in time and don't contain identical logs/levels):

Piping the output to a file (sample.log does not have any ANSI escape codes):

@zdravko-georgiev, looks like the ui5-logger uses npmlog for logging. I'm still checking to see if the output can be made compatible.

There is one empty file packages/logger/foo. Can we remove it?

Hi Ullas,
How will this interact with the existing SAP vscode logging we use in App Gen. Currently we already have rolling file and channel logging provided by the SAP VSCode logger. We do not want multiple log files being created when generating apps for example, or have multiple output channels for different parts of generation. This would complicate the logging. Does the open source logging proposal support integration with the existing SAP VSCode logging being used?
-Iain
From: Ullas Holla @.>
Reply to: SAP/open-ux-tools @.>
Date: Tuesday 11 January 2022 at 20:17
To: SAP/open-ux-tools @.>
Cc: Iain O'Farrell @.>, Mention @.***>
Subject: Re: [SAP/open-ux-tools] feat(logger): add a simple logging module (PR #257)
@IainSAPhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIainSAP&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=PbRMLerJlgLRVaoE4P6%2FUG4CeewdHsnU49YolkiAvBg%3D&reserved=0, @zdravko-georgievhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzdravko-georgiev&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=za%2Fiy4sjFZPlTf9zSUZZBUW1TTF2MhnmZYF9w4XTvIU%3D&reserved=0, @tobiasqueckhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftobiasqueck&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=4DWkQFLHsWxH76ztgZu2uA5L11Ii1OBF4ycLKphCLMY%3D&reserved=0: I changed the default format for console to be plain text instead of JSON (it is colored and timestamped though. Piping the output will not use the color encodinghttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fen.wikipedia.org%2Fwiki%2FANSI_escape_code&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Hc1%2FOSOgkCzs42b0qr1BomXz2YHxcpsndvU%2BbJX3e5c%3D&reserved=0 - this is to facilitate both manual inspection and text manipulation (color encoding can be distracting and painful to work with)). FileTransport still uses JSON.
@IainSAPhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FIainSAP&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=PbRMLerJlgLRVaoE4P6%2FUG4CeewdHsnU49YolkiAvBg%3D&reserved=0, I am slightly deviating from the format used in Fiori tools (levels are not uppercased and the log entry is not enclosed by []). Let me know if you have any concerns with these. (Not using uppercase as I use format.colorize() and it expects lowercased levels. The effort to keep both didn't seem worth it at this point).
An example logger that logs to console and two files simultaneously (the transports are added at different points in time and don't contain identical logs/levels):
[image]https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F212316%2F149013659-06005d72-cc29-455b-b7ca-071d5a1aa1d4.png&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=XqjbNlNGGzNNA2UW%2BbokgXw7P%2B33UQl9Q3OjBqCIxt0%3D&reserved=0
Piping the output to a file (sample.log does not have any ANSI escape codes):
[image]https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F212316%2F149013774-959479b4-164d-45bb-ab89-bb02d55367d7.png&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=M99YaXmwUv1bi4z2GhD7lpaLhZOc%2FerCNv0UXVpTE0Q%3D&reserved=0
@zdravko-georgievhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fzdravko-georgiev&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=za%2Fiy4sjFZPlTf9zSUZZBUW1TTF2MhnmZYF9w4XTvIU%3D&reserved=0, looks like the ui5-logger uses npmloghttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnpm%2Fnpmlog&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=fTXUmm02bz56fHh%2FJXAtxEu%2FTLwORxRPA6NKOcyVhEw%3D&reserved=0 for logging. I'm still checking to see if the output can be made compatible.
—
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSAP%2Fopen-ux-tools%2Fpull%2F257%23issuecomment-1010326678&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=cSDpbMtkvP0H7fUP1jvlxuv92sHRiRLARvfwHUAStSA%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALDBLRWJAVGNG4GW5HOECKDUVSF53ANCNFSM5LVQM5WQ&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=hEuiSFlQ7FtBUWvLuMmj2F2zqHm6frjgvyi0mM2zMnI%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Z9194aBDBMEVyghyWupY0svEK51MnaCnr76v3dFzaX4%3D&reserved=0 or Androidhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|iain.o-farrell%40sap.com|0e8c2e0e431b40b7d56208d9d53f67cd|42f7676cf455423c82f6dc2d99791af7|0|0|637775290566087863|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Q3p6THjJKamHwFeDEGxRvxgyJd%2F1YAOqG36h%2Fdl7JCo%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

There is one empty file packages/logger/foo. Can we remove it?

That's there for good luck 😬

Child loggers are now supported. They add an prefix to the log to make it clear which component is doing the logging. The FileTransport will have the property label to filter the logs on, if required.
On the console, using child loggers looks like this:

Code looks good, 2 Unit test are failing

@zdravko-georgiev: not for me, which ones cause problems for you?

Details

@tobiasqueck The PR build is failing https://github.com/SAP/open-ux-tools/runs/4813000583?check_suite_focus=true

@tobiasqueck The PR build is failing https://github.com/SAP/open-ux-tools/runs/4813000583?check_suite_focus=true

@zdravko-georgiev & @tobiasqueck, this is to do with Node 12 vs Node 14. Like @devinea pointed out, it's to do with WeakRef not being supported yet on Node 12 yet.
WeakRefs are used to keep to make sure the cache of child loggers does not prevent the garbage collection of the loggers. If we don't use weak references, there's a small chance of memory leak (we can remove support for weak refs now and add it back when we support only Node 14+). Another option is not to cache them in the first place.
Thoughts?

Reviewed:
* [x]  understandability of the code - nice, clean structure, however a little more complex than I expected

Thanks @tobiasqueck. Some of the complexity was due to caching. I've removed it. The caching covered a niche usecase and I think the tradeoff of having to worry about memory leaks (and having to use weak references is not worth it). Let me know if there are other areas where the code seems more complicated than necessary. We can think of refactoring those areas.
The PR tests now pass (they failed because they run on Node 12 but I developed locally using Node 14. I've removed code that doesn't work with Node 12 and have switched to using Node 12 locally as well).
I have addressed @devinea's comments (I have not marked all the conversations as resolved. I started doing that and then realized that it may be easier for to track the changes if I added a comment but left them as-is. Let me know what works better and I'll keep that in mind for the future).


Pure variants improvements

@MoritzWeber0 Don't you want to merge https://github.com/DSD-DBS/capella-collab-manager/pull/412 first?

@MoritzWeber0 Don't you want to merge #412 first?

This PR has #412 as base. Mounting of license keys is quite important for #412 (otherwise users can not use the pure::variants sessions as there is no license).


Enable Java 17 as the Default LTS

Description
This PR enables Java 17 as the default LTS version for running CI pipelines. Additionally, it removes the old codesnippet tooling which was no longer compatible with Java 17.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

/azp run java - core - tests


add new extension in brazilian portuguese

Source name
InfinyxScan
Source link
https://infinyxscan.cloud/
Source language
Português Brasil- PT-BR
Other details

Acknowledgements

[X] I have checked that the extension does not already exist by searching the extension listing and verified it does not appear there.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[X] I will fill out all of the requested information in this form.

Add a :+1: reaction to issues you find important.

Good!

Very good!


wandb token exposed to wandb users

hello, there exists a parameter to pass a wandb token into the training utility. unfortunately, this shows on the "Overview" tab of the training session, as a part of the complete commandline that is used to execute the trainer.
This exposes users to potentially nefarious activity, or at the very least, a sense of unease and the possibility of snooping/leaking internal data.

@bmaltais and @kohya-ss should probably do something about this :D does this project not care about security?

This is not good. I guess the Wanda token need to be exempted from making it in the metadata. This is something @kohya-ss need to filter in the training scripts. There is not much I can do about the metadata…

need to recommend users to go with wandb login command instead of a cmdline argument. just --report_to=wandb,tensorboard would work.

fwiw in Diffusers, there is simply a check whether wandb is enabled and the commandline args contain the Huggingface Hub token, because any secrets on cmdline will be exposed via wandb.
but in this case, its the wandb token itself on the cmdline. i am not sure that a documentation hint is enough to stop a user from doing this. the fact that it's on the cmdline at all means it will be exposed 100% of the time this is used.

none that i have found. i resorted in simpletuner to using json config files to hide cmdline args

Would be great bowever to send parameters to Wanda. At the moment in kohya_ss, we don't see  any training parameters in Wandb, only the project name (tracker name), and the run name set from kohya gui. Is it a problem to send all parameters through config?


Connect to websocket on real server, domain or ip server?

Hey, i have this problem. I have website on real server, i have domain and ip adress.
i have this code on server side and when i start it, the server write start success
php server.php start
Workerman[server.php] start in DEBUG mode
-------------------------------------------- WORKERMAN --------------------------------------------
Workerman version:4.1.11          PHP version:7.2.24           Event-Loop:\Workerman\Events\Select
--------------------------------------------- WORKERS ---------------------------------------------
proto   user            worker          listen                      processes    status
ssl      user            none     websocket://<IP_ADDRESS>:2346             1        [OK]
---------------------------------------------------------------------------------------------------
Press Ctrl+C to stop. Start success.

this is code from server.php
<?php

use Workerman\Worker;

require_once __DIR__ . '/vendor/autoload.php';

// SSL context.
$context = [
    'ssl' => [
        'local_cert'  => 'config/keys/cert.pem',
        'local_pk'    => 'config/keys/key.pem',
        'verify_peer' => false,
    ]
];

// Create a Websocket server with ssl context.
$ws_worker = new Worker('websocket://<IP_ADDRESS>:2346', $context);

// Enable SSL. WebSocket+SSL means that Secure WebSocket (wss://).
// The similar approaches for Https etc.
$ws_worker->transport = 'ssl';

$ws_worker->onMessage = function ($connection, $data) {
    // Send hello $data
    $connection->send('Hello ' . $data);
};

Worker::runAll();
?>

i should use wss because site has https protocol.
and when i write scripts in html i used
let ws = new WebSocket("wss://ip_real_server:2346");
and become this error
Event {isTrusted: true, type: 'error', target: WebSocket, currentTarget: WebSocket, eventPhase: 2, …}
isTrusted
:
true
bubbles
:
false
cancelBubble
:
false
cancelable
:
false
composed
:
false
currentTarget
:
WebSocket {url: 'wss://ip_real_server:2346/', readyState: 3, bufferedAmount: 0, onopen: ƒ, onerror: ƒ, …}
defaultPrevented
:
false
eventPhase
:
0
returnValue
:
true
srcElement
:
WebSocket {url: 'wss://ip_real_server:2346/', readyState: 3, bufferedAmount: 0, onopen: ƒ, onerror: ƒ, …}
target
:
WebSocket {url: 'wss://ip_real_server:2346/', readyState: 3, bufferedAmount: 0, onopen: ƒ, onerror: ƒ, …}
timeStamp
:
21290.5
type
:
"error"
[[Prototype]]
:
Event

everywhere when wrote ip_real_server its ip my real server.
so, and question, what i need to use instead of    let ws = new WebSocket("wss://ip_real_server:2346");
should i use website's domain? or something else?

Please try let ws = new WebSocket("wss://yourdomain:2346");

Please type https://yourdomain:port directly into your browser's address bar.
If your service is running correctly, then information about the WebSocket and Workerman versions will be displayed.

Also, if you plan to create HTTPS or WSS services, it is recommended to use nginx/apache to proxy SSL.

ws.php:
<?php
use Workerman\Worker;
use Workerman\Connection\TcpConnection;
require_once __DIR__ . '/vendor/autoload.php';

$context = [
    'ssl' => [
        'local_cert'        => __DIR__ .'/ssl/server.pem',
        'local_pk'          => __DIR__ .'/ssl/server.key',
        'verify_peer'       => false,
    ]
];
$worker = new Worker('websocket://<IP_ADDRESS>:8282', $context);
$worker->transport = 'ssl';
$worker->onMessage = function(TcpConnection $con, $msg) {
    $con->send('ok');
};

Worker::runAll();

js code:
ws = new WebSocket("wss://mydomain.com:8282");
ws.onopen = function() {
    alert("连接成功");
    ws.send('tom');
    alert("给服务端发送一个字符串：tom");
};
ws.onmessage = function(e) {
    alert("收到服务端的消息：" + e.data);
};

Thanks all works


Create Edu create-react-app template

[sc-226631]
Create a create-react-app template with Edu's recommended tech.
Generate an app with npx create-react-app <my-app-name> --template @chanzuckerberg/edu.
Right now it'll have

Tailwind
TypeScript
Jest + tests
Storybook
Accessibility testing
Linting/prettier
PR template
CI via Github actions
react-router
react-query

Does not currently have

Feature/E2E testing

Here's what the generated app looks like:

One question re: npm vs yarn. I think we use both across repo.s? I may have missed which one we want to recommend using in the resulting apps.

Good question @booc0mtaco. I'd prefer to use Yarn, but had trouble getting the template to work right with it.
Will look into it some more.


Downgrade CCS

The used CCS is a bit older already, lets update it.
While here, lets do some small fixes QoL improvements.

patches: Update Code Compose Studio to <IP_ADDRESS>12
Split maclib binary patch
Ensure line-endings stay as intended in patch files

I think we should keep the CSS version as close a possible to the recommended one for this SDK. E.g. for this one it's CCS-12.5.0

So I've downgraded CSS as per desire to match the SDK, which I kind of agree with.

The firmware.patch file included with 20240710 release requires, that manipulation with projects (at least znp_CC1352P_2_LAUNCHXL_tirtos7_ticlang/znp.syscfg), are made with SysConfig 1.19.0 (look at line 187747 of firmware.patch: @versions {"tool":"1.19.0+3426"}). The required SysConfig version is not a standard part of CCS 12.6, neither 12.8.
So, I had to take additional steps to apply the patch:

Download and install SysConfig 1.19.0.
Attach new SysConfig to CCS.
Replace SysConfig for all projects.
Then do all other steps from COMPILE.md

Otherwise, the patch didn't apply.
The splitted version from this PR has the same requirement (line 1756).
@Koenkk If the version of SysConfig 1.19.0 is not necessary for firmware build, maybe it's better to make a new version of firmware.patch without this requirement?
BTW CCS 12.8 and 12.6 produces the same result, firmware hex files are byte-to-byte equal.
The only annoying thing is that firmware hex files build by me (CCS 12.6 on old x64 PC with Windows 11) is smaller, than built by @Koenkk.  But it works for 3+ days as for now.

I was using latest-everything and it seemed fine, but Lets go with 12.6 as koenkk suggested for this release. The next TI dump will probably go to a newer version anyway :) and after my patches, this won't be an issue at all (from a patching point of view).

Done; it's now staying with12.6

COMPILE.md has to updated to accommodate for the maclib_binary.patch

I think this is still missing?

Ah, I thought @Koenkk had to update something there. Not sure what I would need to do with regards to the maclib patches then?

I think it should be added to step 7 of https://github.com/oliv3r/Z-Stack-firmware/blob/update_ccs/coordinator/Z-Stack_3.x.0/COMPILE.md#compiling

And now I understand what you mean; you are absolutely correct. This was lost during rebasing at some point surely. I'll fix the instruction for this commit!

Thanks!

Thanks for the merge, i'll rebase the other mr's and we can focus on those next. Also I bought a second sonoff stick ;)


Use output.logVerbose where appropriate

To give a little context: The changes here will be needed in the long run to support different reporters with different log levels. A use case for that is CI runs where the cli output should be verbose, but not too noisy. But we still want to log every single message to disk regardless.


Ping fails

Ping fails if resolveSrv result is an empty array, i found that rejecting the promise if its empty resolved the issue.
The IP i tried to ping was server.mcs.gg

typo and logic was broken when DNS SRV response was ok but not return anything, this should be now fixed on 0.0.3 version.

typo and logic was broken when DNS SRV response was ok but not return anything, this should be now fixed on 0.0.3 version.


training not converge on Amazon Beauty dataset according to the paper's hyperparameter setting

@lipingcoding thx for reporting the issue, I also observed some problems and still wondering what's wrong with pytorch version compared with tf implementation. Sorry to say but I still haven't figured it out yet. The only thing I can be sure currently is that original paper's hyperparameter setting could be be directly used for this codebase, as I fixed some leaky attention issue by using PyTorch's MHA, the parameter initialization issue still need to be elaborated but I haven't done it yet.

btw @lipingcoding  could u pls provide bit more information like log etc. to describe the observation that the model do not converge? Like uncomment https://github.com/pmixer/SASRec.pytorch/blob/30c43cf090d429480339ab18d43354b3e399bc29/main.py#L93 would print loss for iteration which should be informative.

@lipingcoding  try the newly updated code?


fix: set to latest if git tag is empty

Signed-off-by: Zhizhen He<EMAIL_ADDRESS>

unifying the duplicated codes in one place is a good idea, but I have a concern about the function GetGitTagFromVersion(), it's about gitTag maybe it should not return the docker image domain latest?

Thanks for your contribution! :tada: :+1:


Tencent Cloud features support

[ ]  external-dns: https://cloud.tencent.com/document/product/302

[ ]  external-lb: https://cloud.tencent.com/document/product/214/888

[ ]  rancher-storage:
https://cloud.tencent.com/document/product/362/2345
https://cloud.tencent.com/product/cfs

[ ]  routes updater for Tencent Cloud VPC in per-host-subnet

external-lb +1
cfs +1

It turns out Tencent Cloud doesn't have Go SDK available for us to develop the related functions for Rancher, so we have to put a hold on this one for now until Tencent produce the SDK for Go.

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


fix: test pr comment

What:

Additional issues:

:tada: This PR is included in version 10.0.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 10.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 10.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Console history updates and tests.

Question:
What is the difference between an ObservableList and a Vector and when should we use one versus the other?

A Vector is generally used internally as "the interface we wish a native Array had".  It is typically exposed as an ISequence for public consumption, which is the "interface we wish a read-only native Array had".  An ObservableList is explicitly for an exposed attribute container that others should be notified when its elements change.

👍


Nacos-0 fail to initialize,

Summary
Tried to deploy train-ticket with command:
make deploy
Pod nacos-0 failed to initialize (with log "Error from server (BadRequest): container "k8snacos" in pod "nacos-0" is waiting to start: PodInitializin)", see picture below:

Have checked solutions reported by issue #233, and set "role=leader" and mysql "read-only=0", but nacos-0 still faill to initialize with same logs in the above picture

Expected behaviour
pod nacos-0 should be in "running" status.
Your environment
OS: Ubuntu 20.04.5
Kubernetes version(use kubectl version): v1.25.4+k3s1

Same problem!

Hi, recommend using this command: kubectl describe pod nacos-0 to see the details

Run the command "kubectl describe pod nacos-0", and then get details as shown in below pictures:

same probelm.

how did you set mysql "read-only=0", can anyone help me on this?


NIFI-3280 PostHTTP Option to write response to attribute or flowfile content

property to store response body in attribute or replace flowfile content
property to set which attribute to store response body in
property to store response code in attribute
property to set which attribute to store response code in

For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] ~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?~
[ ] ~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~
[ ] ~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~
[x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] ~Have you ensured that format looks appropriate for the output in which it is rendered?~

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@nickcarenza thank you for the contribution. May I ask you to squash the commit as requested by the PR template?
 Is your initial contribution a single, squashed commit?
At least you have been honest and left it blank. :-)

@nickcarenza - welcome. We all have been in that very same boat once. :smiley:

Some of us more than once.

@nickcarenza will try review sometime between today and the weekend.

thanks @trixpan. i dont remember this failing builds. i will try to look at cleaning that up but i don't know that ill get to it this week.

@nickcarenza thanks for the PR, much appreciated.
I was going through it and got myself wondering:
Is there any reason why we are doing this when InvokeHTTP processor cater for the very same need (i.e. POST followed by content to attributes)
From its documentation:

Put Response Body In Attribute
If set, the response body received back will be put into an attribute of the original FlowFile instead of a separate FlowFile. The attribute key to put to is determined by evaluating value of this property.
Supports Expression Language: true

Keen to understand the reason as I suspect I am missing something

Closing due to inactivity.


Fix: /api/v1/extensions/progression/initOrGetGroups

This needs to be fixed ASAP. If this is broken you CAN NOT join Arena!

Client sends: {"data":{"skipProgressionGroups":false,"skipMetadataGroups":false,"playerName":"Steam-Name-Here"}}
Struct to Return  (Struct Name "MirrorsExtModelInitOrGetGroupsResponse"):
{"ProgressionGroups": [ ], "MetadataGroups": [ ]}
KNOWN STRUCTS:
MirrorsExtModelProgressionUpdateMetadataGroupsResponse

MirrorsModelUpdateExperienceProgressionGroupsResponse:
{"List": [ TArray]}
MirrorsModelUpdateExperienceProgressionGroupResponse:

MirrorsModelUpdateExperienceProgressionGroupBody (This could be DATA):


introduce zoom property to CameraView to allow to zoom on Android

This PR implements the zoom on android

Cool! When would this zoom feature also be available on NuGet? Thanks so much :)


Windows binaries?

Hi, any chance for a Windows release?
Thanks

@gd4c Included windows! It should work, but I not tested, I have no windows. Let me know if there's an issue.

@gd4c Included windows! It should work, but I not tested, I have no windows. Let me know if there's an issue.


Wrong exception when calling ResultSet.getTimestamp on TIME value

java.lang.IllegalArgumentException: Expected column to be a timestamp type but is time(3)
	at io.prestosql.jdbc.AbstractPrestoResultSet.getTimestamp(AbstractPrestoResultSet.java:362)
	at io.prestosql.jdbc.AbstractPrestoResultSet.getTimestamp(AbstractPrestoResultSet.java:327)
	at io.prestosql.jdbc.PrestoResultSet.getTimestamp(PrestoResultSet.java:44)

should be SQLException

I would like to work on this. You just need the type of exception changed right?

Hm... looking at the javadoc for java.sql.ResultSet#getTimestamp(int) again.
The javadoc does not mandate use of SQLException in this case.
@rafatmunshi would you be able to check what's eg PostgreSQL's and Oracle's JDBC behavior here?

Hi, checked Oracle and Postgres JDBC docs. Both mention throws SQLException. Logically also I believe it should throw SQLException only as you suggested @findepi .  So I think we just need to change the Exception type in the file and do the relevant change in the tests. Hope I am not missing something?

@jetsasank recently did similar improvement for getDate, @rafatmunshi please check this out: https://github.com/prestosql/presto/pull/5510

Checked it. Clarifies my earlier query. Will send a PR soon. Thanks!

hi, is this available for a commit?

Hi @somayaj , I am working on a PR linked to this now. Thanks


Helped mvn test find test cases

public access specifier is necessary for the classes and the methods

Ah, my oversight. Thanks for the fix.


Cow: Watch techanicinfotech.com

Cow requests the watch of the watch_keyword techanicinfotech\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

techanicinfotech\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Dragonrage in Charcoal HQ


Cannot read property 'split' of undefined

Can't use at all as it says:
Cannot read property 'split' of undefined
and does not give any output.

Hi, so I think this might be an error on Yahoo's side. I added a catch after my function call to getHistoricalPrices so that it would recursively call itself if the the error you are mentioning occurred. I made sure to print out 2 blank lines if the function called itself and then ran it 1000 times. No errors occurred this time but there were gaps of 2 blank lines throughout the output, and it seemed that it was affecting all the quotes. So I think when the request is made to yahoo the body it returns isn't always as planned which is why the type error is thrown

So is there any way to fix this issue, or is it just unfixable due to an issue on yahoo's side?
Thanks

Right now I think it is unfixable and is a yahoo error, but maybe darthbatman can comment on this

Make sure you use your code inside a trycatch block and also make sure the ticker symbol is all uppercase

What I ended up doing was wrap the code in a function with a counter, and when the exception occurs, it retries the same with an incremented counter.
Perhaps an optional param can be added to the function that accepts num of retries?

This error looks to be caused by the CORS:

Access to fetch at 'https://finance.yahoo.com/quote/...' from origin 'http://localhost:3000' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' ...

I fixed the issue by modifying price in yahoo-stock-prices.js
  let price = body.split(`"${ticker}":{"sourceInterval"`)[0]
  .split('class="Cl(b)"')[1]
  .split('active="">')[1]
  .split('</fin-streamer>')[0]

I can pull request if people are still using this


node symbol overlap on Windows with hyper

Current behavior
Registering double symbols I do not know why it is doing this. I uninstalled everything nothing fixes it.
Expected behavior
Display information normally.
Relevant Zsh configuration (.zshrc)
# # If you come from bash you might have to change your $PATH.
# export PATH=$HOME/bin:/usr/local/bin:$PATH

# Path to your oh-my-zsh installation.
export ZSH="/home/darkristy/.oh-my-zsh"
eval $(/home/linuxbrew/.linuxbrew/bin/brew shellenv)

# Set name of the theme to load --- if set to "random", it will
# load a random theme each time oh-my-zsh is loaded, in which case,
# to know which specific one was loaded, run: echo $RANDOM_THEME
# See https://github.com/robbyrussell/oh-my-zsh/wiki/Themes
ZSH_THEME="robbyrussell"

# Set list of themes to pick from when loading at random
# Setting this variable when ZSH_THEME=random will cause zsh to load
# a theme from this variable instead of looking in ~/.oh-my-zsh/themes/
# If set to an empty array, this variable will have no effect.
# ZSH_THEME_RANDOM_CANDIDATES=( "robbyrussell" "agnoster" )

# Uncomment the following line to use case-sensitive completion.
# CASE_SENSITIVE="true"

# Uncomment the following line to use hyphen-insensitive completion.
# Case-sensitive completion must be off. _ and - will be interchangeable.
# HYPHEN_INSENSITIVE="true"

# Uncomment the following line to disable bi-weekly auto-update checks.
# DISABLE_AUTO_UPDATE="true"

# Uncomment the following line to automatically update without prompting.
# DISABLE_UPDATE_PROMPT="true"

# Uncomment the following line to change how often to auto-update (in days).
# export UPDATE_ZSH_DAYS=13

# Uncomment the following line if pasting URLs and other text is messed up.
# DISABLE_MAGIC_FUNCTIONS=true

# Uncomment the following line to disable colors in ls.
# DISABLE_LS_COLORS="true"

# Uncomment the following line to disable auto-setting terminal title.
# DISABLE_AUTO_TITLE="true"

# Uncomment the following line to enable command auto-correction.
# ENABLE_CORRECTION="true"

# Uncomment the following line to display red dots whilst waiting for completion.
# COMPLETION_WAITING_DOTS="true"

# Uncomment the following line if you want to disable marking untracked files
# under VCS as dirty. This makes repository status check for large repositories
# much, much faster.
# DISABLE_UNTRACKED_FILES_DIRTY="true"

# Uncomment the following line if you want to change the command execution time
# stamp shown in the history command output.
# You can set one of the optional three formats:
# "mm/dd/yyyy"|"dd.mm.yyyy"|"yyyy-mm-dd"
# or set a custom format using the strftime function format specifications,
# see 'man strftime' for details.
# HIST_STAMPS="mm/dd/yyyy"

# Would you like to use another custom folder than $ZSH/custom?
# ZSH_CUSTOM=/path/to/new-custom-folder

# Which plugins would you like to load?
# Standard plugins can be found in ~/.oh-my-zsh/plugins/*
# Custom plugins may be added to ~/.oh-my-zsh/custom/plugins/
# Example format: plugins=(rails git textmate ruby lighthouse)
# Add wisely, as too many plugins slow down shell startup.
plugins=(git)

source $ZSH/oh-my-zsh.sh

# User configuration

# export MANPATH="/usr/local/man:$MANPATH"

# You may need to manually set your language environment
# export LANG=en_US.UTF-8

# Preferred editor for local and remote sessions
# if [[ -n $SSH_CONNECTION ]]; then
#   export EDITOR='vim'
# else
#   export EDITOR='mvim'
# fi

# Compilation flags
# export ARCHFLAGS="-arch x86_64"

# Set personal aliases, overriding those provided by oh-my-zsh libs,
# plugins, and themes. Aliases can be placed here, though oh-my-zsh
# users are encouraged to define aliases within the ZSH_CUSTOM folder.
# For a full list of active aliases, run `alias`.
#
# Example aliases
# alias ohmyzsh="mate ~/.oh-my-zsh"
### Alias
alias update="source ~/.zshrc"
alias zshconfig="code ~/.zshrc"
### Dir Alias
alias intern="/mnt/f/InternWork"
### Base Alias
alias pip="pip3"
alias open="code ."
### Git Alias
alias gb="git branch"
alias gs="git status"
alias ga="git add ."
alias gba="git branch $1"
alias gbd="git branch -D $1"
alias gcm="git checkout master"
alias gcr="git checkout release"
alias gcb="git checkout $1"
alias gma="git merge abort"
alias gmm="git merge master"
alias gpo="git push origin $1"
alias gpom="git push origin master"
alias gpro="git pull --rebase origin master"
alias gpru="git pull --rebase upstream master"
alias gra="git rebase --abort"
alias grc="git rebase --continue"
alias gpull="git pull"

#Configuration

  # Set Spaceship ZSH as a prompt
  autoload -U promptinit; promptinit
  prompt spaceship

Environment
Spaceship version:  (3.11.1)
Zsh version:
Zsh framework: (oh-my-zsh)
Zsh plugin manager: (NPM)
Terminal emulator: (Hyper)
Operating system: (Windows)
Screenshot
Provide a screenshot that shows your issue.

Spaceship-prompt is not tested for Windows and we can't guarantee everything works perfectly, primarily because we don't use Windows. It would be awesome if someone is willing to contribute to Windows support.
In this issue, There seems some color overlaps between sections, apart from symbol rendering. Older version of Zsh tends to cause such issue, What is your Zsh version ?

zsh 5.4.2

Having the same issue on a normal Ubuntu 18.04 install using WSL. My zsh version is also at 5.4.2.

This setup has worked beautifully in the past and didn't exhibit any issues whatsoever, but just now recently broke.

Common denominator on both cases is the operating system, Windows. We need someone with similar setup to help you, Sorry for that.

This setup has worked beautifully in the past and didn't exhibit any issues whatsoever, but just now recently broke.

What has changed since then to cause this ?

What has changed since then to cause this ?

In my case, zsh pushed an update, which broke it for me. Prior to the 5.4.2 update I've used spaceship w/ WSL for a good year and haven't had any issues whatsoever.
Might be a bug with zsh and WSL.

Another when I load up the terminal in vscode it doesnt do that.

After some digging and debugging myself I found the issue:
It seems to be a problem with applications using xterm.js as their terminal. Xterm seems to fail at rendering double-width unicode emojis (e.g. the package icon). Visual Studio Code and Hyper for instance both using xterm.js exhibit this issue.
Other terminals like Windows Terminal do not have this problem.

My solution was to just disable the package icon for now (the Node.js icon works fine, since it's only a single-width emoji), which solved my problem completely.

I think it might be worth opening an issue on xterm.js' GitHub, addressing this problem.

Excellent @riyacchi :clap: xterm.js has a related issue at https://github.com/xtermjs/xterm.js/issues/1059.
Closing this now since this is not directly related to prompt theme amd we can't do much about this.


Camel 10418, Deploy route with an error

https://issues.apache.org/jira/browse/CAMEL-10418

I don't think this is the right point to place this check. You're re-throwing the exception without really manage it. Not sure anyway. Lets wait for @davsclaus

@oscerd it is the same code.... Today there is an implicit throw exception!!!!!

I need to investigate a bit if it can be placed in deeper methods of the class.

No problem, take your time!!!! ;-)

@oscerd do you have any news?

you're a bit eager. I'll merge it today.

@oscerd, my company will pay me in relation to PR you will do! ;-) (I'm kidding)

Hi please, check a different approach here: https://github.com/apache/camel/pull/1234

Thanks to both @Fabryprog for spotting the problem and @paoloantinori for fixing it.
@Fabryprog can you close this PR? Maybe you can add some tests around this special cases.


Can't install

Description
Can't install through the Microsoft Store - that broke a long time ago.  Tried the installer and it reports "Package failed updates, dependency or conflict validation."
Steps To Reproduce

Run installer.

Requirements

e.g. Fix crash that occurs when...

Files Version
Cant install.
Windows Version
19044.2486
Log File
No log.

Thank you for your feedback, please refer to here for troubleshooting steps and alternative installation methods. https://files.community/docs/install
Let us know if you're still having trouble after following those steps and we'll try to assist.

Tried the powershell (as admin) method:
Add-AppxPackage : Deployment failed with HRESULT: 0x80070005, Access is
denied.
AppX Deployment operation failed with error 0x0 from API Logging data
because access was denied for file:
\?\C:\Program
Files\WindowsApps\Microsoft.WindowsAppRuntime.1.5_5001.70.1338.0_x64__8wekyb3d8bbwe\AppxManifest.xml,
user SID: S-1-5-18
NOTE: For additional information, look for [ActivityId]
6008f623-798d-0001-c504-09608d79da01 in the Event Log or use
the command line Get-AppPackageLog -ActivityID
6008f623-798d-0001-c504-09608d79da01
At line:1 char:1

Add-AppxPackage -AppInstallerFile https://cdn.files.community/files/s ...

  + CategoryInfo          : SecurityError:

(https://cdn.fil...ge.appinstaller:String)
[Add-AppxPackage], PSSecurityE
xception
+ FullyQualifiedErrorId :
DeploymentError,Microsoft.Windows.Appx.PackageManager.Commands.AddAppxPackageCommand
On Mon, Mar 18, 2024 at 7:17 PM Yair @.***> wrote:

Thank you for your feedback, please refer to here for troubleshooting
steps and alternative installation methods.
https://files.community/docs/install
Let us know if you're still having trouble after following those steps and
we'll try to assist.
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/14988#issuecomment-2005277022,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFGWFSBELXNDQJIUDJGB2LYY5YXVAVCNFSM6AAAAABE4P2TQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGI3TOMBSGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
I am not a robot.

Do you have Files already installed?
Are you using an unofficial (like Atlas OS or ReviOS etc.) or a modified (like disabled Windows update system, removed the Microsoft store, used a debloat program/script etc.) version of Windows?

Nope. But I'm now performing a Windows update, we'll see if that helps.
On Mon, Mar 18, 2024 at 8:00 PM Josh65-2201 @.***>
wrote:

Do you have Files already installed?
Are you using an unofficial (like Atlas OS or ReviOS etc.) or a
modified (like disabled Windows update system, removed the Microsoft store,
used a debloat program/script etc.) version of Windows?

—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/14988#issuecomment-2005365416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFGWFU57AWX4NRKM66JUOTYY552BAVCNFSM6AAAAABE4P2TQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGM3DKNBRGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
I am not a robot.

The Windows update didn't accomplish anything.
Output from powershell:
Add-AppxPackage : Deployment failed with HRESULT: 0x80073CF3, Package
failed updates, dependency or conflict
validation.
Windows cannot install package Files_<IP_ADDRESS>_x64__1y0xx7n9077q4 because
this package depends on a framework that could
not be found. Provide the framework "Microsoft.WindowsAppRuntime.1.5"
published by "CN=Microsoft Corporation,
O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or
x64 processor architecture and minimum
version 5001.70.1338.0, along with this package to install. The frameworks
with name "Microsoft.WindowsAppRuntime.1.5"
currently installed are: {Microsoft.WindowsAppRuntim
Windows cannot install package Files_<IP_ADDRESS>_x64__1y0xx7n9077q4 because
this package depends on a framework that could
not be found. Provide the framework "Microsoft.WindowsAppRuntime.1.5"
published by "CN=Microsoft Corporation,
O=Microsoft Corporation, L=Redmond, S=Washington, C=US", with neutral or
x64 processor architecture and minimum
version 5001.70.1338.0, along with this package to install. The frameworks
with name "Microsoft.WindowsAppRuntime.1.5"
currently installed are:
{Microsoft.WindowsAppRuntime.1.5_5001.70.1338.0_x64__8wekyb3d8bbwe
Microsoft.WindowsAppRuntime.1.5_5001.70.1338.0_x86__8wekyb3d8bbwe}
NOTE: For additional information, look for [ActivityId]
8336a68c-7993-000c-5ce0-36839379da01 in the Event Log or use
the command line Get-AppPackageLog -ActivityID
8336a68c-7993-000c-5ce0-36839379da01
At line:1 char:1

Add-AppxPackage -AppInstallerFile https://cdn.files.community/files/s ...

  + CategoryInfo          : WriteError:

(https://cdn.fil...ge.appinstaller:String)
[Add-AppxPackage], IOException
+ FullyQualifiedErrorId :
DeploymentError,Microsoft.Windows.Appx.PackageManager.Commands.AddAppxPackageCommand
On Mon, Mar 18, 2024 at 8:00 PM Josh65-2201 @.***>
wrote:

Do you have Files already installed?
Are you using an unofficial (like Atlas OS or ReviOS etc.) or a
modified (like disabled Windows update system, removed the Microsoft store,
used a debloat program/script etc.) version of Windows?

—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/14988#issuecomment-2005365416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFGWFU57AWX4NRKM66JUOTYY552BAVCNFSM6AAAAABE4P2TQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGM3DKNBRGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
I am not a robot.

Try installing this, then use the power shell command or installer again https://cdn.files.community/files/stable/Files.Package_<IP_ADDRESS>_Stable_Test/Dependencies/x64/Microsoft.WindowsAppRuntime.1.5.msix

That was it!  Thanks!
On Mon, Mar 18, 2024 at 8:40 PM Josh65-2201 @.***>
wrote:

Try installing this, then use the power shell command or installer again
https://cdn.files.community/files/stable/Files.Package_<IP_ADDRESS>_Stable_Test/Dependencies/x64/Microsoft.WindowsAppRuntime.1.5.msix
—
Reply to this email directly, view it on GitHub
https://github.com/files-community/Files/issues/14988#issuecomment-2005491234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFGWFXZR4A2QA7PED4VRTTYY6CQTAVCNFSM6AAAAABE4P2TQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGQ4TCMRTGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
I am not a robot.


An attempt to add cancellation token to async methods (#41)

This is an attempt to add cancellation capability to async methods by adding the CancellationToken optional argument as follows:

Changed csharp.py code generator to add the CancellationToken to Async methods.
Changed DropboxRequestHandler to support cancellation while calling HttpClient methods and while performing the retry.
Changed DropboxClient to support cancellation for RefreshAccessToken.
Adding cancellation support to JsonWriter by using the async overloads of Newtonsoft.
I didn't implement the cancellation for JsonReader since it's called after the request is completed.

Checklist

General Contributing

[x] Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

[ ] Non-code related change (markdown/git settings etc)
[x] SDK Code Change
[ ] Example/Test Code Change

Validation

[x] Does this code build successfully?
[ ] Do all tests pass?
[x] Does Stylecop pass?

Hi @greg-db
Would you please review this PR? I tried to be comprehensive in terms of explaining the details. Please do let me know if anything is unclear.
Thanks!

Hi @greg-db
Would you please review this PR? I tried to be comprehensive in terms of explaining the details. Please do let me know if anything is unclear.
Thanks!

Thanks for putting this together! I'm not the right person to do the actual review, but I'll ask the team to review this when they can.

Thanks for putting this together! I'm not the right person to do the actual review, but I'll ask the team to review this when they can.

Thanks, @greg-db!
I'm not yet familiar with all Dropboxers! :) I think @connorworley or @rogebrd could help review this.

Thanks, @greg-db!
I'm not yet familiar with all Dropboxers! :) I think @connorworley or @rogebrd could help review this.

Hi @greg-db @connorworley
Is there any update on this PR?

@AlirezaMaddah This is still open with the team, but I don't have an update on this right now.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Alireza Maddah:x: AlirezaMaddahAlireza Maddah seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Change mapping for FULLTEXT indices

Relates to https://github.com/crate/crate/issues/4457
TODO:

[ ] Update FieldMappers to recognise new field "source"
[ ] Update MetadataUpgrader
[ ] Fix tests

Hi @mfussenegger, could you please have an early look?
As discussed, updating mapping for handling FULLTEXT indices, there are some more steps (MD upgrade, FieldMappers) to do but before I proceed wanted to get a feedback on the new structure itself.

./gradlew :server:test --tests "io.crate.integrationtests.FulltextIntegrationTest.testCopyValuesFromStringArrayToIndex" -Dtests.seed=A913780F7D07EFCE -Dtests.locale=kam-Latn-KE -Dtests.timezone=Asia/Thimphu
is reproducible

./gradlew :server:test --tests "io.crate.integrationtests.FulltextIntegrationTest.testCopyValuesFromStringArrayToIndex" -Dtests.seed=A913780F7D07EFCE -Dtests.locale=kam-Latn-KE -Dtests.timezone=Asia/Thimphu
is reproducible

retest this please
to get another seed if it's failing again to see what's changes between runs.

./gradlew :server:test --tests "io.crate.integrationtests.FulltextIntegrationTest.testCopyValuesFromStringArrayToIndex" -Dtests.seed=A913780F7D07EFCE -Dtests.locale=kam-Latn-KE -Dtests.timezone=Asia/Thimphu
is reproducible

Fixed in https://github.com/crate/crate/pull/14026/commits/a1710cbc62bb4351e5c50e0b46d0bb90e50f02cf
Flakiness was caused by translog handling.  (IndexShard.applyTranslogOperation -> applyIndexOperation which does source parsing and tries to call outdated copyTo parsing. Removed copyTo parsing and using sources instead now.

retest this please

Hi @seut, could you please take a look?
Regarding https://github.com/crate/crate/pull/14026#discussion_r1183344354, we discussed internally that it should be fine, but I will add a test case "add FT to the table" -> select before and after upgrade" to the crate-qa and also validate upgrade path 5.3-> build from this PR

retest this please (unrelated failure Removed server *** from active pool)


Pact js v3

Updating to use latest version of pact-js v<IP_ADDRESS>-beta and 10.0.0+
fixes #212

superceded by #214


FlywayException: No database found to handle jdbc:postgresql://...

Which version and edition of Flyway are you using?
8.5.9
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
N/A
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
java api
Which database are you using? (Type & version)
postgres 12.9 on aws
Which operating system are you using?
ubuntu
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
Updated from 6.4.2 to 8.5.9 and now am getting the error FlywayException: No database found to handle jdbc:postgresql://....
The stack trace points to this line being the culprit https://github.com/flyway/flyway/blob/master/flyway-core/src/main/java/org/flywaydb/core/internal/database/DatabaseTypeRegister.java#L55
I have the postgres depedency and driver already. Even weirder, it works on my personal machine and on github CI, but will get this error on AWS.

Was fixed by making sure META-INF/services/org.flywaydb.core.extensibility.Plugin was preserved when calling sbt assembly


Add quirk for Eurotronic Spirit Zigbee

This quirk adds support for the thermostat "Eurotronic Spirit Zigbee".
Manual: https://eurotronic.org/wp-content/uploads/2019/11/Spirit_ZigBee_BAL_web_DE_Okt.-2019.pdf (German, but the last pages containing the Zigbee information are in English)
Related issue: #356
The thermostat works without the quirk, but not well. This quirk adds support for:

OFF: Ability to turn off the thermostat using system mode
Bidirectional temperature: Temperature set on the thermostat will be reported back into HA

After joining, HA needs to be restarted for the thermostat to be working properly. It seems that some attributes are not read on first join (including system_mode). Other than that, the quirk should work well.

Wow. Thanks. I wouldn't be able to do it without access to the device.