🐛 [Firebase_Auth] Auth Blocking iOS firebase_messaging dev callbacks

Bug report
Describe the bug
didReceiveRemoteNotification is used in both firebase_auth, to handle incoming auth messages and firebase_messaging, to handle the rest of firebase messages. Firebase_messaging plays nice as it checks if the notification is for auth purposes and forwards it to it. But Auth is not doing the same, and all the messages are received by firebase_auth and its not forwarding the rest of the messages to firebase_messaging.
Steps to reproduce
Steps to reproduce the behavior:

iOS only
Install latest firebase_auth and latest firebase_messaging.dev
Add breakpoint at didReceiveRemoteNotification in both auth and messaging implementation
Send notification with contentAvailable (or any notification considered remote notification)
See how didReceiveRemoteNotification is called in auth but not in messaging

Expected behavior
Both functions should be called, or play nice one with the other.

Additional comments
This is related to #4097 and #4388

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.22.4, on macOS 11.1 20C69 darwin-x64, locale en-MX)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
[✓] Android Studio (version 4.1)
[✓] VS Code (version 1.52.0)
[!] Connected device

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.10.4
Flutter SDK 1.22.4
hometask_user 1.1.6+18

dependencies:
- add_2_calendar 1.4.0 [flutter]
- app_review 2.0.1 [http intl package_info url_launcher flutter]
- autocomplete_textfield 1.7.3 [flutter]
- cached_network_image 2.4.1 [flutter flutter_cache_manager octo_image]
- cloud_firestore 0.14.4 [flutter meta quiver firebase_core firebase_core_platform_interface cloud_firestore_platform_interface cloud_firestore_web]
- cloud_functions 0.7.2 [meta flutter firebase_core firebase_core_platform_interface cloud_functions_platform_interface cloud_functions_web]
- cupertino_icons 0.1.3
- dash_chat 1.1.15 [flutter flutter_parsed_text uuid intl transparent_image]
- facebook_app_events 0.8.1 [flutter]
- firebase_analytics 6.3.0 [meta flutter firebase_core firebase_analytics_web firebase_analytics_platform_interface]
- firebase_auth 0.18.4+1 [meta firebase_core firebase_core_platform_interface firebase_auth_platform_interface firebase_auth_web flutter]
- firebase_core 0.5.3 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- firebase_crashlytics 0.2.4 [flutter stack_trace firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface]
- firebase_database 4.4.0 [flutter firebase_core]
- firebase_dynamic_links 0.6.3 [flutter firebase_core]
- firebase_messaging 8.0.0-dev.11 [meta flutter firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web]
- firebase_performance 0.4.3 [flutter firebase_core]
- firebase_storage 5.2.0 [flutter firebase_core firebase_core_platform_interface firebase_storage_web firebase_storage_platform_interface quiver]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_app_badger 1.1.2 [flutter]
- flutter_credit_card 0.1.3 [flutter]
- flutter_device_type 0.3.2 [flutter]
- flutter_local_notifications 3.0.2 [flutter platform flutter_local_notifications_platform_interface timezone]
- flutter_twilio_voice 0.0.5+7 [flutter]
- get_it 5.0.1 [async meta]
- google_maps_flutter 1.0.6 [flutter flutter_plugin_android_lifecycle google_maps_flutter_platform_interface]
- image_cropper 1.3.1 [flutter]
- image_picker 0.6.7+14 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- intl 0.16.1 [path]
- location 3.1.0 [flutter meta location_platform_interface location_web]
- location_permissions 3.0.0+1 [flutter meta]
- phone_number 0.8.1 [meta flutter]
- photo_view 0.10.3 [flutter]
- provider 4.3.2+3 [collection flutter nested]
- share 0.6.5+4 [meta mime flutter]
- shared_preferences 0.5.12+4 [meta flutter shared_preferences_platform_interface shared_preferences_linux shared_preferences_macos shared_preferences_web shared_preferences_windows]
- smooth_star_rating 1.1.1 [flutter]
- sounds 0.9.3 [device_info flutter_spinkit meta path path_provider provider sounds_common uuid flutter]
- stripe_sdk 3.0.1+1 [flutter http url_launcher uni_links mask_text_input_formatter awesome_card flutter_slidable simple_animations supercharged]
- uni_links 0.4.0 [flutter]
- uuid 2.2.2 [crypto convert]

dev dependencies:
- dapackages 1.4.0 [yaml http]
- flutter_launcher_icons 0.8.1 [image args yaml path]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- archive 2.0.13 [crypto args path]
- args 1.6.0
- async 2.5.0-nullsafety.1 [collection]
- awesome_card 1.1.0 [flutter]
- boolean_selector 2.1.0-nullsafety.1 [source_span string_scanner]
- characters 1.1.0-nullsafety.3
- charcode 1.2.0-nullsafety.1
- clock 1.1.0-nullsafety.1
- cloud_firestore_platform_interface 2.2.1 [flutter meta collection firebase_core plugin_platform_interface]
- cloud_firestore_web 0.2.1+2 [flutter flutter_web_plugins http_parser meta firebase_core firebase_core_web cloud_firestore_platform_interface js]
- cloud_functions_platform_interface 3.0.3 [flutter meta firebase_core plugin_platform_interface]
- cloud_functions_web 3.1.1 [firebase_core firebase_core_web cloud_functions_platform_interface flutter flutter_web_plugins http_parser meta js]
- collection 1.15.0-nullsafety.3
- convert 2.1.1 [charcode typed_data]
- crypto 2.1.5 [collection convert typed_data]
- device_info 1.0.0 [flutter device_info_platform_interface]
- device_info_platform_interface 1.0.1 [flutter meta plugin_platform_interface]
- fake_async 1.2.0-nullsafety.1 [clock collection]
- ffi 0.1.3
- file 5.2.1 [intl meta path]
- firebase 7.3.3 [http http_parser js]
- firebase_analytics_platform_interface 1.0.3 [flutter meta]
- firebase_analytics_web 0.1.1 [flutter flutter_web_plugins firebase firebase_analytics_platform_interface meta]
- firebase_auth_platform_interface 2.1.4 [flutter meta firebase_core plugin_platform_interface]
- firebase_auth_web 0.3.2+3 [flutter flutter_web_plugins meta http_parser intl firebase_core firebase_core_web firebase_auth_platform_interface js]
- firebase_core_platform_interface 2.1.0 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.1+1 [firebase_core_platform_interface flutter flutter_web_plugins meta js]
- firebase_crashlytics_platform_interface 1.1.4 [flutter meta collection firebase_core plugin_platform_interface]
- firebase_messaging_platform_interface 1.0.0-dev.7 [flutter meta firebase_core plugin_platform_interface]
- firebase_messaging_web 0.1.0-dev.2 [flutter flutter_web_plugins meta firebase_core firebase_core_web firebase_messaging_platform_interface js service_worker]
- firebase_storage_platform_interface 1.0.2 [flutter meta collection firebase_core plugin_platform_interface]
- firebase_storage_web 0.1.1+1 [async crypto firebase_core firebase_core_web firebase_storage_platform_interface flutter flutter_web_plugins http js meta]
- flutter_blurhash 0.5.0 [flutter meta]
- flutter_cache_manager 2.0.0 [flutter path_provider uuid http path sqflite pedantic clock file rxdart]
- flutter_local_notifications_platform_interface 2.0.0+1 [flutter plugin_platform_interface]
- flutter_parsed_text 1.2.5 [flutter]
- flutter_plugin_android_lifecycle 1.0.11 [flutter]
- flutter_slidable 0.5.7 [flutter]
- flutter_spinkit 4.1.2+1 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection meta typed_data vector_math]
- google_maps_flutter_platform_interface 1.0.5 [flutter meta plugin_platform_interface stream_transform]
- http 0.12.2 [http_parser path pedantic]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- image 2.1.19 [archive xml meta]
- image_picker_platform_interface 1.1.1 [flutter meta http plugin_platform_interface]
- js 0.6.2
- location_platform_interface 1.0.1 [flutter meta plugin_platform_interface]
- location_web 1.0.0 [flutter flutter_web_plugins location_platform_interface http_parser meta js]
- logger 0.9.4
- mask_text_input_formatter 1.1.0 [flutter]
- matcher 0.12.10-nullsafety.1 [stack_trace]
- meta 1.3.0-nullsafety.3
- mime 0.9.7
- nested 0.0.4 [flutter]
- octo_image 0.3.0 [flutter flutter_blurhash]
- package_info 0.4.3+2 [flutter]
- path 1.8.0-nullsafety.1
- path_provider 1.6.24 [flutter path_provider_platform_interface path_provider_macos path_provider_linux path_provider_windows]
- path_provider_linux 0.0.1+2 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_macos 0.0.4+6 [flutter]
- path_provider_platform_interface 1.0.4 [flutter meta platform plugin_platform_interface]
- path_provider_windows 0.0.4+3 [path_provider_platform_interface meta path flutter ffi win32]
- pedantic 1.9.2 [meta]
- petitparser 3.1.0 [meta]
- platform 2.2.1
- plugin_platform_interface 1.0.3 [meta]
- process 3.0.13 [file intl meta path platform]
- quiver 2.1.5 [matcher meta]
- rxdart 0.24.1
- sa_v1_migration 1.1.2 [flutter]
- service_worker 0.2.4 [js]
- shared_preferences_linux 0.0.2+4 [file flutter meta path path_provider_linux shared_preferences_platform_interface]
- shared_preferences_macos 0.0.1+11 [shared_preferences_platform_interface flutter]
- shared_preferences_platform_interface 1.0.4 [meta flutter]
- shared_preferences_web 0.1.2+7 [shared_preferences_platform_interface flutter flutter_web_plugins meta]
- shared_preferences_windows 0.0.1+3 [shared_preferences_platform_interface flutter ffi file meta path path_provider_platform_interface path_provider_windows]
- simple_animations 2.4.2 [flutter supercharged sa_v1_migration pedantic]
- sky_engine 0.0.99
- sounds_common 1.0.8 [intl logger meta path pedantic uuid flutter]
- source_span 1.8.0-nullsafety.2 [charcode collection path term_glyph]
- sqflite 1.3.2+1 [flutter sqflite_common path]
- sqflite_common 1.0.2+1 [synchronized path meta]
- stack_trace 1.10.0-nullsafety.1 [path]
- stream_channel 2.1.0-nullsafety.1 [async]
- stream_transform 1.2.0
- string_scanner 1.1.0-nullsafety.1 [charcode source_span]
- supercharged 1.12.0 [supercharged_dart flutter]
- supercharged_dart 1.4.0
- synchronized 2.2.0+2
- term_glyph 1.2.0-nullsafety.1
- test_api 0.2.19-nullsafety.2 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- timezone 0.5.9 [path]
- transparent_image 1.0.0
- typed_data 1.3.0-nullsafety.3 [collection]
- url_launcher 5.7.10 [flutter url_launcher_platform_interface url_launcher_web url_launcher_linux url_launcher_macos url_launcher_windows]
- url_launcher_linux 0.0.1+4 [flutter]
- url_launcher_macos 0.0.1+9 [flutter]
- url_launcher_platform_interface 1.0.9 [flutter meta plugin_platform_interface]
- url_launcher_web 0.1.5+1 [url_launcher_platform_interface flutter flutter_web_plugins meta]
- url_launcher_windows 0.0.1+3 [flutter]
- vector_math 2.1.0-nullsafety.3
- win32 1.7.4 [ffi]
- xdg_directories 0.1.2 [meta path process]
- xml 4.5.1 [collection convert meta petitparser]
- yaml 2.2.1 [charcode collection string_scanner source_span]

Reproducible on the latest master 1.26.0-2.0.pre.64 with firebase_messaging: ^8.0.0-dev.11.

flutter doctor -v
[✓] Flutter (Channel master, 1.26.0-2.0.pre.64, on macOS 11.0.1 20B29 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-2.0.pre.64 at /Users/markus/development/flutter_master
    • Framework revision 9ff4326e1f (2 hours ago), 2020-12-17 06:19:05 +0000
    • Engine revision 6edb402ee4
    • Dart version 2.12.0 (build 2.12.0-157.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/markus/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Users/markus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.6953283/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.2, Build version 12B45b
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Users/markus/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/201.6953283/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      � https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      � https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] Connected device (3 available)
    • Nevercode’s iPhone (mobile) • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 14.2
    • macOS (desktop)             • macos                                    • darwin-x64     • macOS 11.0.1 20B29 darwin-x64
    • Chrome (web)                • chrome                                   • web-javascript • Google Chrome 87.0.4280.67

• No issues found!

Have the same problem on iOS 😕

I temporally solve this issue by changing these lines of code in the Auth Firebase package
https://github.com/FirebaseExtended/flutterfire/blob/473b878831f828cad158695c368e86545aae4d8a/packages/firebase_auth/firebase_auth/ios/Classes/FLTFirebaseAuthPlugin.m#L252-L260
#if !__has_include(<FirebaseMessaging/FirebaseMessaging.h>)
- (BOOL)application:(UIApplication *)application
    didReceiveRemoteNotification:(NSDictionary *)notification
          fetchCompletionHandler:(void (^)(UIBackgroundFetchResult result))completionHandler {
  if ([[FIRAuth auth] canHandleNotification:notification]) {
    completionHandler(UIBackgroundFetchResultNoData);
    return YES;
  }
  return NO;
}
#endif

I only needed to add a condition for not adding that code when the FirebaseMessaging plugin is used, as FirebaseMessaging already handles that for auth here:
https://github.com/FirebaseExtended/flutterfire/blob/473b878831f828cad158695c368e86545aae4d8a/packages/firebase_messaging/firebase_messaging/ios/Classes/FLTFirebaseMessagingPlugin.m#L418-L421
With this now "content_available": true and on background messages should work

I temporally solve this issue by changing these lines of code in the Auth Firebase package
https://github.com/FirebaseExtended/flutterfire/blob/473b878831f828cad158695c368e86545aae4d8a/packages/firebase_auth/firebase_auth/ios/Classes/FLTFirebaseAuthPlugin.m#L252-L260
#if !__has_include(<FirebaseMessaging/FirebaseMessaging.h>)
- (BOOL)application:(UIApplication *)application
    didReceiveRemoteNotification:(NSDictionary *)notification
          fetchCompletionHandler:(void (^)(UIBackgroundFetchResult result))completionHandler {
  if ([[FIRAuth auth] canHandleNotification:notification]) {
    completionHandler(UIBackgroundFetchResultNoData);
    return YES;
  }
  return NO;
}
#endif

I only needed to add a condition for not adding that code when the FirebaseMessaging plugin is used, as FirebaseMessaging already handles that for auth here:
https://github.com/FirebaseExtended/flutterfire/blob/473b878831f828cad158695c368e86545aae4d8a/packages/firebase_messaging/firebase_messaging/ios/Classes/FLTFirebaseMessagingPlugin.m#L418-L421
With this now "content_available": true and on background messages should work

Thanks @jamesblasco, it works! I tested it and I'm now receiving notifications with or without content-available.
Side issue...
didReceiveRemoteNotification is being called but not in background, I have both background capabilities checked but nothing, I then went to test on an iOS native app and is still not called. So I guess it's not related to flutter,  is is working for you? and if it is, could you share an example message sent from server?

Thanks @jamesblasco, it works! I tested it and I'm now receiving notifications with or without content-available.
Side issue...
didReceiveRemoteNotification is being called but not in background, I have both background capabilities checked but nothing, I then went to test on an iOS native app and is still not called. So I guess it's not related to flutter,  is is working for you? and if it is, could you share an example message sent from server?

@Salakar I think @jamesblasco's approach is the way to go.

@Salakar I think @jamesblasco's approach is the way to go.

@Salakar I think @jamesblasco's approach is the way to go.

Agreed, it's a good find. If someone can get a PR to that effect then I can get it released tonight

@Salakar I think @jamesblasco's approach is the way to go.

Agreed, it's a good find. If someone can get a PR to that effect then I can get it released tonight

@Salakar  #4657

@Salakar  #4657

Published. Thanks :)

Published. Thanks :)

Just want to drop in and say thank you very much for fixing and publishing this quickly! Background messages were our last option for a fix we had to ship ASAP and we found out last minute about this bug.

Just want to drop in and say thank you very much for fixing and publishing this quickly! Background messages were our last option for a fix we had to ship ASAP and we found out last minute about this bug.

Thanks @jamesblasco, it works! I tested it and I'm now receiving notifications with or without content-available.
Side issue...
didReceiveRemoteNotification is being called but not in background, I have both background capabilities checked but nothing, I then went to test on an iOS native app and is still not called. So I guess it's not related to flutter, is is working for you? and if it is, could you share an example message sent from server?
Edit: never mind... good old restarting phone did the trick

I'm with a similar problem but I only have AppDelegate.swift. Could you share your code ? This is my problem https://github.com/FirebaseExtended/flutterfire/issues/4687

Thanks @jamesblasco, it works! I tested it and I'm now receiving notifications with or without content-available.
Side issue...
didReceiveRemoteNotification is being called but not in background, I have both background capabilities checked but nothing, I then went to test on an iOS native app and is still not called. So I guess it's not related to flutter, is is working for you? and if it is, could you share an example message sent from server?
Edit: never mind... good old restarting phone did the trick

I'm with a similar problem but I only have AppDelegate.swift. Could you share your code ? This is my problem https://github.com/FirebaseExtended/flutterfire/issues/4687

Double check that you have set both capabilities as the documentation states, I don't have any special code, I just rebooted my phone and the notifications started working again.

Double check that you have set both capabilities as the documentation states, I don't have any special code, I just rebooted my phone and the notifications started working again.


chore: add linter ignore rule and dictionary entries

Description of changes

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #10022 (3ebfaf0) into master (adecb03) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10022   +/-   ##
=======================================
  Coverage   54.09%   54.09%
=======================================
  Files         837      837
  Lines       46374    46374
  Branches     9890     9890
=======================================
  Hits        25084    25084
  Misses      19295    19295
  Partials     1995     1995

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Fearture1

first pull request

Okay thank you I will try to fix all the errors I have, I hope you can have
some time to answer me if I have any other questions.
On Tue, Mar 21, 2023, 11:53 AM Francis Wayungi @.***>
wrote:

@.**** requested changes on this pull request.
Hi @OTMANE-ECHCHAFYKY https://github.com/OTMANE-ECHCHAFYKY ,
[image: image]
https://user-images.githubusercontent.com/99656687/224543672-ce29b4b2-d478-447f-ae6f-eb3df4f35902.png
Congratulations on the good job done so far! 🤝
There are some issues that you still need to work on to go to the next
project but you are almost there! 😄
Highlights ⚡ ⚡

Good commit messages ✔
Correct GitHub flow ✔

Required Changes ♻
Check the comments under the review.

Please fix the 2 failing linter tests below.
[image: linter]
https://user-images.githubusercontent.com/99656687/226589095-432c1813-f667-4c63-a694-e719b04dc1a8.png
You have not added the .hintrc & stylistrc files in your project.
Please read this resource a linter for HTML and CSS
https://github.com/microverseinc/linters-config and apply the steps
to your project carefully.
Your Branch name is not descriptive. A descriptive branch name should
indicate what is happing in the branch. eg
setup-hello-microverse-project. Kindly checkout to new branch and
use a descriptive name and mention the old PR in the new PR.
Please add a descriptive title telling you what changes are inside
this Pull request & a summary describing introduced changes in more detail.
[image: pr]
https://user-images.githubusercontent.com/99656687/226596270-584b5206-8af8-42cf-9b59-1d37d9bcca39.png
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop
the approval of this PR. However, I strongly recommend you to take them
into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
Please, remember to tag me in your question so I can receive the
notification.
Please, do not open a new Pull Request for re-reviews. You should use the
same Pull Request submitted for the first review, either valid or invalid
unless it is requested otherwise.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In style.css
https://github.com/OTMANE-ECHCHAFYKY/hello-microverse/pull/1#discussion_r1143211310
:

@@ -0,0 +1,3 @@
+h1 {

color: green;

You have a linter error. line 2 should only be indented by spaces.
kindly fix this.
[image: stylint]
https://user-images.githubusercontent.com/99656687/226588008-7eae520f-77d3-476a-b2f9-9069ca5dc25a.png

In .gitignore
https://github.com/OTMANE-ECHCHAFYKY/hello-microverse/pull/1#discussion_r1143223988
:

@@ -0,0 +1 @@
+node_modules

Please add the test.md file to your .gitignore so that the file is
not pushed to GitHub.
add this line to your .gitignore test.md
[image: copy]
https://user-images.githubusercontent.com/99656687/226590568-40917a0b-facb-4958-a8f1-27501c67d6f8.png

In README.md
https://github.com/OTMANE-ECHCHAFYKY/hello-microverse/pull/1#discussion_r1143229705
:

+<!--
+HOW TO USE:
+This is an example of how you may give instructions on setting up your project locally.

+Modify this file to match your project and remove sections that don't apply.
+
+REQUIRED SECTIONS:
+- Table of Contents
+- About the Project

Built With

Live Demo
+- Getting Started
+- Authors
+- Future Features
+- Contributing
+- Show your support
+- Acknowledgements
+- License

+OPTIONAL SECTIONS:
+- FAQ
+
+After you're finished please remove all the comments and instructions!

Comments should always be deleted from your code base.

All lines beginning with > only serve to guide you on how you should
fill in this document. kindly delete them once you have filled in all
sections fo the readme

In README.md
https://github.com/OTMANE-ECHCHAFYKY/hello-microverse/pull/1#discussion_r1143233296
:

Deployment
+- 👥 Authors
+- 🔭 Future Features
+- 🤝 Contributing
+- ⭐ Show your support
+- 🙏 Acknowledgements
+- ❓ FAQ (OPTIONAL)
+- 📝 License

+
+
+# 📖 [your_project_name]
+
+> Describe your project in 1 or 2 sentences.
+
+[your_project__name] is a...

Please replace this with your project name. It is mandatory to fill
in all sections of the README with the right information. All you need to
do is edit all sections.

In README.md
https://github.com/OTMANE-ECHCHAFYKY/hello-microverse/pull/1#discussion_r1143233987
:

+- [key_feature_1]
+- [key_feature_2]
+- [key_feature_3]

Please add 1-3 features you intend to add to this project in the
future

In README.md
https://github.com/OTMANE-ECHCHAFYKY/hello-microverse/pull/1#discussion_r1143235539
:

[Answer_1]

+- [Question_2]
+

[Answer_2]

+(back to top)
+
+
+
+## 📝 License
+
+This project is MIT licensed.
+
+NOTE: we recommend using the MIT license - you can set it up quickly by using templates available on GitHub. You can also use any other license if you wish.

This section serves to guide you on how you should add a License to
your project. Kindly delete it once the Licence is added.

In README.md
https://github.com/OTMANE-ECHCHAFYKY/hello-microverse/pull/1#discussion_r1143237958
:

+- [Question_1]
+

[Answer_1]

+- [Question_2]
+

[Answer_2]

+(back to top)
+
+
+
+## 📝 License
+
+This project is MIT licensed.

Your project does not have a license. All projects should have a
license as this lets other users know how to use your project and what
legal constraints are attached. Use this
https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository
to add a licence

In README.md
https://github.com/OTMANE-ECHCHAFYKY/hello-microverse/pull/1#discussion_r1143239324
:

+> Add at least 2 questions new developers would ask when they decide to use your project.

+- [Question_1]
+

[Answer_1]

+- [Question_2]
+

[Answer_2]

This section is optional and should be deleted in case you will not
add questions.

In README.md
https://github.com/OTMANE-ECHCHAFYKY/hello-microverse/pull/1#discussion_r1143242195
:

+- [ ] [new_feature_1]
+- [ ] [new_feature_2]
+- [ ] [new_feature_3]

All sections of the README are compulsory except the FAQs . You
should therefore always fill them in appropriately 🤝

—
Reply to this email directly, view it on GitHub
https://github.com/OTMANE-ECHCHAFYKY/hello-microverse/pull/1#pullrequestreview-1350183191,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQZNAOB3U4OPWTQH7OESKL3W5GJC3ANCNFSM6AAAAAAWCIGZSM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Okay thank you I will try to fix all the errors I have, I hope you can have some time to answer me if I have any other questions.
…
On Tue, Mar 21, 2023, 11:53 AM Francis Wayungi @.> wrote: @.* requested changes on this pull request. Hi @OTMANE-ECHCHAFYKY https://github.com/OTMANE-ECHCHAFYKY , [image: image] https://user-images.githubusercontent.com/99656687/224543672-ce29b4b2-d478-447f-ae6f-eb3df4f35902.png Congratulations on the good job done so far! handshake There are some issues that you still need to work on to go to the next project but you are almost there! smile Highlights zap zap - Good commit messages heavy_check_mark - Correct GitHub flow heavy_check_mark Required Changes recycle Check the comments under the review. - Please fix the 2 failing linter tests below. [image: linter] https://user-images.githubusercontent.com/99656687/226589095-432c1813-f667-4c63-a694-e719b04dc1a8.png - You have not added the .hintrc & stylistrc files in your project. Please read this resource a linter for HTML and CSS https://github.com/microverseinc/linters-config and apply the steps to your project carefully. - Your Branch name is not descriptive. A descriptive branch name should indicate what is happing in the branch. eg setup-hello-microverse-project. Kindly checkout to new branch and use a descriptive name and mention the old PR in the new PR. - Please add a descriptive title telling you what changes are inside this Pull request & a summary describing introduced changes in more detail. [image: pr] https://user-images.githubusercontent.com/99656687/226596270-584b5206-8af8-42cf-9b59-1d37d9bcca39.png Optional suggestions Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Cheers and Happy coding!clapclapclap Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. ------------------------------ As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s. ------------------------------ In style.css <#1 (comment)> : > @@ -0,0 +1,3 @@ +h1 { + color: green; - You have a linter error. line 2 should only be indented by spaces. kindly fix this. [image: stylint] https://user-images.githubusercontent.com/99656687/226588008-7eae520f-77d3-476a-b2f9-9069ca5dc25a.png ------------------------------ In .gitignore <#1 (comment)> : > @@ -0,0 +1 @@ +node_modules - Please add the test.md file to your .gitignore so that the file is not pushed to GitHub. add this line to your .gitignore test.md [image: copy] https://user-images.githubusercontent.com/99656687/226590568-40917a0b-facb-4958-a8f1-27501c67d6f8.png ------------------------------ In README.md <#1 (comment)> : > +<!-- +HOW TO USE: +This is an example of how you may give instructions on setting up your project locally. + +Modify this file to match your project and remove sections that don't apply. + +REQUIRED SECTIONS: +- Table of Contents +- About the Project + - Built With + - Live Demo +- Getting Started +- Authors +- Future Features +- Contributing +- Show your support +- Acknowledgements +- License + +OPTIONAL SECTIONS: +- FAQ + +After you're finished please remove all the comments and instructions! - Comments should always be deleted from your code base. Kindly delete this and all other comments. line 25 gives you a clue on what you should do smile ------------------------------ In README.md <#1 (comment)> : > + - Usage + - Run tests + - Deployment +- busts_in_silhouette Authors +- telescope Future Features +- handshake Contributing +- star Show your support +- pray Acknowledgements +- question FAQ (OPTIONAL) +- memo License + + + +# book [your_project_name]  + +> Describe your project in 1 or 2 sentences. - All lines beginning with > only serve to guide you on how you should fill in this document. kindly delete them once you have filled in all sections fo the readme ------------------------------ In README.md <#1 (comment)> : > + - Deployment +- busts_in_silhouette Authors +- telescope Future Features +- handshake Contributing +- star Show your support +- pray Acknowledgements +- question FAQ (OPTIONAL) +- memo License + + + +# book [your_project_name]  + +> Describe your project in 1 or 2 sentences. + +[your_project__name] is a... - Please replace this with your project name. It is mandatory to fill in all sections of the README with the right information. All you need to do is edit all sections. ------------------------------ In README.md <#1 (comment)> : > +- [key_feature_1] +- [key_feature_2] +- [key_feature_3] - Please add 1-3 features you intend to add to this project in the future ------------------------------ In README.md <#1 (comment)> : > + + - [Answer_1] + +- [Question_2] + + - [Answer_2] + +(back to top) + + + +## memo License  + +This project is MIT licensed. + +NOTE: we recommend using the MIT license - you can set it up quickly by using templates available on GitHub. You can also use any other license if you wish. - This section serves to guide you on how you should add a License to your project. Kindly delete it once the Licence is added. ------------------------------ In README.md <#1 (comment)> : > + +- [Question_1] + + - [Answer_1] + +- [Question_2] + + - [Answer_2] + +(back to top) + + + +## memo License  + +This project is MIT licensed. - Your project does not have a license. All projects should have a license as this lets other users know how to use your project and what legal constraints are attached. Use this https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository to add a licence ------------------------------ In README.md <#1 (comment)> : > +> Add at least 2 questions new developers would ask when they decide to use your project. + +- [Question_1] + + - [Answer_1] + +- [Question_2] + + - [Answer_2] + - This section is optional and should be deleted in case you will not add questions. ------------------------------ In README.md <#1 (comment)> : > +- [ ] [new_feature_1] +- [ ] [new_feature_2] +- [ ] [new_feature_3] + - All sections of the README are compulsory except the FAQs . You should therefore always fill them in appropriately handshake — Reply to this email directly, view it on GitHub <#1 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQZNAOB3U4OPWTQH7OESKL3W5GJC3ANCNFSM6AAAAAAWCIGZSM . You are receiving this because you were mentioned.Message ID: @.***>

You can reach me on slack or zoom directly for a quick response.

Yes, you can reach me on slack or zoom for a quick response


Support For Cassandra Internal Authentication In Client

This request is specifically aimed at providing support for connecting to Cassandra clusters configured to use 'org.apache.cassandra.auth.PasswordAuthenticator'.

I believe this overlaps with some work that @jamescway did, which is getting superseded by @michaelsembwever's Datastax work

Now that the big switch to use datastax is is committed, we can revisit this issue... :grin:

work is started in https://github.com/openzipkin/zipkin/commit/cb9f063f5e9b
it's implemented i believe but just needs a unit test for it.

I realize that I didn't call it out in the original Jira, so maybe it should be addressed in a follow-on, but I believe the support for providing credentials should support the possibility of securely providing the credentials.
Different organizations will certainly have different mechanisms for providing these credentials, so perhaps the implementation should provide an interface for providing credentials. The default implementation may be as simple as the command line option approach used here (and/or securely prompting for credentials).

Yeah, i just wanted to throw a simple implementation out there to begin with.
You also have the AuthProvider class in the datastax cql driver, along with the PlainTextAuthProvider implementation of it.

@michaelsembwever was this fixed?

Cassandra storage configuration has this option now:
* `CASSANDRA_USERNAME` and `CASSANDRA_PASSWORD`: Cassandra authentication. Will throw an exception on startup if authentication fails. No default


Errors or timeouts when running studio with --turbo flag

Describe the bug
Sanity studio no longer working in development, when running in turbo dev mode. Running a studio, according to the guide within this repository is broken with the following error:
Error: Module [project]/node_modules/sanity/lib/_chunks-es/pane.mjs [app-client] (ecmascript, async loader) was instantiated because it was required from module [project]/node_modules/sanity/lib/_chunks-es/index3.mjs [app-client] (ecmascript), but the module factory is not available. It might have been deleted in an HMR update.
Error: Module [project]/node_modules/sanity/lib/_chunks-es/pane.mjs [app-client] (ecmascript, async loader) was instantiated because it was required from module [project]/node_modules/sanity/lib/_chunks-es/index3.mjs [app-client] (ecmascript), but the module factory is not available. It might have been deleted in an HMR update.
    at instantiateModule (http://localhost:3000/_next/static/chunks/node_modules_next_dist_esm_build_templates_app-page_acc3d3.js:494:15)
    at getOrInstantiateModuleFromParent (http://localhost:3000/_next/static/chunks/node_modules_next_dist_esm_build_templates_app-page_acc3d3.js:609:12)
    at commonJsRequire (http://localhost:3000/_next/static/chunks/node_modules_next_dist_esm_build_templates_app-page_acc3d3.js:146:20)
    at http://localhost:3000/_next/static/chunks/node_modules_091980._.js:896:194
    at lazyInitializer (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react_a1d82d._.js:1767:32)
    at mountLazyComponent (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:14571:29)
    at beginWork$1 (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:15959:32)
    at beginWork (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:22853:28)
    at performUnitOfWork (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:21895:24)
    at workLoopSync (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:21660:17)
    at renderRootSync (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:21627:21)
    at recoverFromConcurrentError (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:20929:30)
    at performSyncWorkOnRoot (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:21176:34)
    at flushSyncWorkAcrossRoots_impl (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:7079:33)
    at flushSyncWorkOnAllRoots (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:7045:13)
    at processRootScheduleInMicrotask (http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:7167:13)
    at http://localhost:3000/_next/static/chunks/node_modules_next_dist_compiled_react-dom_cjs_react-dom_development_c9a189.js:7313:21

To reproduce, I have used the latest official nextjs bug reproduction project. And only added studio to it, according to the appdir readme of this repository.
To Reproduce
Steps to reproduce the behavior:

Clone my reproduction repository you will find it has 2 commits.
Install dependencies npm i
Specify any project in the env file cp .env.dist .env.local
You have 2 scripts available npm run dev and npm run dev:turbo.
Visit http://localhost:3000/studio the first page may work, but any further clicks will crash the tool entirely. For example click on the Pages item, or try to add a new Page.

In other reproductions, for example when using on real projects with plugins and similar, the symptoms vary from not being able to load studio at all, due to 100% timeout rate - to working fine but turning the CPU into a toaster oven.
Expected behavior
The studio should work as it normally does, and as it does without the turbo flag.
I've tried various next-sanity and next versions, down to 14.0.0 and 7.0.0, and this never seems to work correctly.
If using turbo is not yet possible (I'm aware turbo is beta and not all test are passing) perhaps we should write something about this in the readme for this repo, and for the sanity repo, for the time being. It's fairly straightforward when faced with an error like this, but It's been a lot of trouble figuring this out, in cases where it was just consuming our whole CPUs, as we had no idea that studio was the one that was jacking up the next process.
Screenshots

Which versions of Sanity are you using?
@sanity/cli (global)  3.37.2 (up to date)
// Only Sanity dependency in the package.json.
"next-sanity": "9.0.2",
What operating system are you using?
macOS Sonoma 14.4.1 (23E224)
Which versions of Node.js / npm are you running?
10.2.4
v20.11.1

Hi @markomitranic, we're investigating this issue with our friends at Vercel 🙌 Will keep you posted

@stipsan I had the same issue and following your instructions resolved it.

There's more information in the related fix in turbo here: https://github.com/vercel/turbo/pull/7959
It's probably related to us shipping Node ESM native support in v3.37.0: https://github.com/sanity-io/sanity/releases/tag/v3.37.0
Before that node in ESM mode would be redirected back to CJS mode by using the CJS ESM re-export pattern, as we had node.import export conditions for it. In other words in a lot of frameworks, Next.js included, whenever you imported sanity you always got the CJS code. I'm not sure if that's related but that's the only change we made that could've caused a change to bundler behavior recently 🤷

@stipsan FYI, I bumped to Sanity 3.39.0 and Next 14.2.2 this morning and the issue is no longer present.


Update table comparison

Reading the comparison table confused me because I was already using a number of the features with 'X's by them with the upstream nginx controller.
I took a shot at updating it based on my understanding of what the nginx ingress controller can do. It's possible I'm wrong about what some part of the table meant or about some detail of it though.

May be this can be a 3 column comparison instead of two tables.

Closing for inactivity.


Improve error messages when missing required initializer

Addresses #53

I paired with @tareksabry1337 offline to improve the messages here this morning. Going to merge without review since we paired on this (and this is SO MUCH BETTER than what we had before), but as always: happy to address feedback post-merge.


OoT Setting: Accessing Zora Fountain Behavior

Basically a set of options as a drop-down for how accessing Zora's Fountain works.
-Closed (current behavior)
-Open (King Zora is already moved for both ages)
-Open as Adult Only (like it says, King Zora is moved only for Adult Link)

Done


Programmatic file upload with Blob - how to set the Filename

Hi, I am using the programatic file upload: $('#fileupload').fileupload('send', {files: filesList}); with Blob's and need to be able to set the filename that is used on the server. At present I get names like: Blob0d3ee2048dc146f794f7f6e07fb11ef3
I am only ever sending one file at a time, if that makes any difference.
I need to do this in the JS code in the client, not on the server. Any help much appreciated.
-Neville

Setting the filename property is only possible if you build the multipart message data yourself, instead of using the FormData interface, which the plugin makes use of.
This involves loading the files (or blobs) contents via FileReader interface, which requires loading the complete files into memory and naturally doesn't perform well.
The old v4 branch had such an implementation if you are interested:
https://github.com/blueimp/jQuery-File-Upload/blob/v4/jquery.fileupload.js#L435
With the current version of the plugin, I would recommend you to send the filenames as formData, similar to the titles in this howto:
https://github.com/blueimp/jQuery-File-Upload/wiki/How-to-submit-additional-Form-Data

Hi Sebastian, Thanks for the prompt and helpful reply. I thought that sending the filename as formData might be the way forward. Can you give me some idea on what I need to do in index.php to get this to work at the server end?
-Neville

In the foreach loop of the post method, replace
isset($_SERVER['HTTP_X_FILE_NAME']) ?
                    $_SERVER['HTTP_X_FILE_NAME']

with
isset($_POST['filename']) ?
                    $_POST['filename'][$index]

with "filename[]" (note the brackets) being the name attribute of your filename inputs.

Fantastic, I'll give this a try. Thanks so much for your help.

I've changed public function post()  as follows:
        foreach ($upload['tmp_name'] as $index => $value) {
            $info[] = $this->handle_file_upload(
                $upload['tmp_name'][$index],
                // isset($_SERVER['HTTP_X_FILE_NAME']) ?
                //    $_SERVER['HTTP_X_FILE_NAME'] : $upload['name'][$index],
                isset($_POST['filename']) && is_array($_POST['filename']) ?
                      $_POST['filename'][$index]
                ....

And in my JS code I have:
$('#fileupload').fileupload( 'send', { 'files': filesList, 'formData': { 'filename': 'test' } } ).
xxxxx
and get:
XMLHttpRequest cannot load http:/xyz/backups/php/index.php. Origin file:// is not allowed by Access-Control-Allow-Origin.
-Neville

I've fixed the 'Access-Control-Allow-Origin.' error which was my mistake as my change hadn't included:  : $upload['name'][$index]. However I'm still getting filenames 'Blobnnnn'.
I am not clear on your comment: "with "filename[]" (note the brackets)". I can't see any use of filename[] in your code.
-Neville

Got it working. JS code had to be $('#fileupload').fileupload( 'send', { 'files': filesList, 'formData': { 'filename[]': 'test' } } ).
to match <input name='filename[]' ..> which is what you meant by filename[].
Thanks again.

Thanks for posting your solution for others to find. :)


initial HTML and some temp routes files

Added basic HTML skeleton in public folder. Also added api folder in controller folder with two files to set up nodemailer routes, but these can be altered later as necessary.

Looks good


Adding different patterns in multi-series

Hi!
I am trying to customize the bar chart code to add patterns to each category in a dataset. For the sake of simplicity, I'll use the example on the Deneb page "Pattern Fills" https://deneb-viz.github.io/pattern-fills#default-patterns.
Could you please help me with the syntax to code a different stripe type for each of the countries in the image below instead of having the diagonal for all countries?

In addition, what if we had the countries as a legend and years in the y-axis? Is there a way we could define different patterns for each country? (please see image below):

Below is the part of the code I'm trying to modify to include the patterns in case 2 (I have years on the x-axis and countries in the legend):
"mark": {
"type": "bar",
"fill": {
"expr":  " datum['countries']='Canada'? 'url(#diagonal-stripe-1-50)' && datum['countries']='France'? 'url(#vertical-stripe-1-50)' "
},
"stroke": "black"
},
I appreciate any guidance you could give me.
Thank you!!
Kind regards,
Lucianna

Due to how patterns have to be generated in SVG, we don't have all colours stored, just the standard ones documented on the documentation page if you want to use thr url() syntax. For colour assignment, you'll need to use the pbiPatternSvg function (also documented on that page). This will generate and reserve SVG patterns in the visual as specified.
For your stacked bar chart scenario, using the color encoding channel will automatically create a stacked bar chart, so we can leverage this for your needs. What you will need to do is create a custom range in the color scale with the desired patterns. Because ranges support ExprRefs, we can do this with a similar pattern, so your example might look like this:

{
  "data": {"name": "dataset"},
  "mark": {"type": "bar", "stroke": "black"},
  "encoding": {
    "y": {"field": "Year"},
    "x": {
      "field": "$ Sales",
      "type": "quantitative"
    },
    "color": {
      "field": "Country",
      "scale": {
        "range": [
          {
            "expr": "pbiPatternSVG('vertical-stripe-1', 'red')"
          },
          {
            "expr": "pbiPatternSVG('dots-3', 'blue')"
          },
          {
            "expr": "pbiPatternSVG('diagonal-stripe-1', 'green')"
          }
        ]
      },
      "legend": {
        "symbolSize": 200,
        "symbolType": "square",
        "symbolStrokeWidth": 0.5
      }
    }
  }
}

I've also made some changes to the legend config to make the patterns a bit easier to see, due to how some of them repeat.
For your initial scenario, I would also use a similar method to reduce the amount of expression logic you'll need to manage, but disable the legend, e.g.:

{
  "data": {"name": "dataset"},
  "mark": {"type": "bar"},
  "encoding": {
    "y": {"field": "Country"},
    "x": {
      "field": "$ Sales",
      "type": "quantitative"
    },
    "color": {
      "field": "Country",
      "scale": {
        "range": [
          {
            "expr": "pbiPatternSVG('diagonal-stripe-1', 'blue')"
          },
          {
            "expr": "pbiPatternSVG('diagonal-stripe-1', 'orange')"
          },
          {
            "expr": "pbiPatternSVG('diagonal-stripe-1', 'green')"
          },
          {
            "expr": "pbiPatternSVG('diagonal-stripe-1', 'red')"
          },
          {
            "expr": "pbiPatternSVG('diagonal-stripe-1', 'pink')"
          }
        ]
      },
      "legend": null
    }
  }
}

Note that your scale ranges will need to include suitable assignments for as many categories as you expect, or they will wrap around to the beginning.

That's great and very useful!! Appreciate your help!
Thanks!
Kind regards


update: typeDefs.js file cacheControl

Hey my friend. you don't need to create a pull request for that. Keep pushing your changes in a specific feature branch, then when you are done with a specific feature (for example if you are planning to divide dashboard to three features or whatever you like) create a pull request  to merge it to the dev branch. so I'm closing this pull request


amalgamation/../dmlc-core/src/io/local_filesys.cc:61: LocalFileSystem.GetPathInfo Error:No such file or directory

dfull <- xgb.DMatrix(as.matrix(xg.M), label=xg.Y, missing=NaN)
Error in xgb.DMatrix(as.matrix(xg.M), label = xg.Y, missing = NaN) :
[21:47:15] amalgamation/../dmlc-core/src/io/local_filesys.cc:61: LocalFileSystem.GetPathInfo 0.16388082504 Error:No such file or directory
Im getting interesting error. Tried with same dataset on different machines with same xgboost version. This is the first time it happened to me.
Any clues what it could be?
xgboost installed from source
install hash: c529cac6ff5e5d9a3affb3d14af66d46537c5fd6
using R on win10
Edit:
found out the culprit - there was character column in dataset (int64 converted to character);
Interesting error nonetheless

Agree. More explicit error would be helpful. Thanks, raddar!

Is it resolved? I am getting the same error as following
"amalgamation/../dmlc-core/src/io/local_filesys.cc:86: LocalFileSystem.ListDirectory 3/10 error: No such file or directory"

double check if you have provided all numeric type features to xgb.DMatrix function. Hope it helps

@fakyras suggestion corrected the problem for me... user error (doh) :)  Agree with @dmi3kno that a more explicit error would be helpful.

Seems was due to the fact that xgboost recognize some of it as string and think it is a path. @khotilov  @hetong007 maybe a better input type recognition code?

I've added a simple check in #2045 to print out, hopefully, a more clear error message.

Can you please explain how to "double check if you have provided all numeric type features to xgb.DMatrix function"

@theastyanax You should call str(dataframe) and check each variables type is of numeric (eg: not factor). XGBoost won't work with categorical (factor) variables.

Running xgboost on https://www.kaggle.com/dalpozz/creditcardfraud also returns this error. I have made sure that all the variable types are numeric.

Try data.matrix(yourdata) inside DMatrix() instead of as.matrix(yourdata), it works on me.

it seems the document needs to be improved, xgboost should throw the correct error for human in detail instead of the C++/C level error.

@harryprince Can you make a more concrete proposal for generating better error message? Let's open a new issue so that we can keep track of it.


ComputeOnDevice

I saw that you are using the Canny edge detector, is there a possibility to use another detector?
Thanks in advance

Yes. The purpose of the sample is to show how to use OpenCV with the image streams. It should be possible to use any other OpenCV functionality, or follow the OpenCV integration to make some other CV libraries work.

Thank you


[Test][data-tables] move to federated auth

API change check
API changes are not detected in this pull request.

CI failures are existing and known, due to new test-proxy sanitizer changes.

/azp run js - data-tables - tests

/check-enforcer override


Fix formating bug for seed nginx-ingress controller deployment

/area control-plane
/kind bug
What this PR does / why we need it:
Without this fix the deployment of the nginx ingress controller for Seeds with K8s version >= 1.22 has a formatting bug which prevents it from picking up the the right ingress-class.
Deployment yaml with Seed K8s version 1.22.3 before this fix:
  containers:
  - args:
    - /nginx-ingress-controller
    - --default-backend-service=garden/nginx-ingress-k8s-backend
    - --enable-ssl-passthrough=true
    - --publish-service=garden/nginx-ingress-controller
    - --election-id=ingress-controller-seed-leader
    - --ingress-class=nginx-ingress-gardener- --controller-class=k8s.io/nginx-ingress-gardener
(...)

Introduced with: https://github.com/gardener/gardener/pull/4614
Release note:

Fixes a bug in the seed-nginx-ingress-controller for Seeds with K8s version >=1.22.0

/assign

@BeckerMax can you backport to release-v1.36, release-v1.37 and release-v1.38?


A warning regarding await keyword

I see the following warning during make:
test/test_delivery_herald.py:51
  /w/hare/hax/test/test_delivery_herald.py:51: DeprecationWarning: 'async' and 'await' will become reserved keywords in Python 3.7
    def await(self):

Justin Woo commented in Jira Server:

[~534380] is this going to be scheduled in an upcoming sprint?
Is it going to be fixed or scheduled on the backlog?
We are updating issues in Github and want it to reflect the current status.

Shreya Karmakar commented in Jira Server:

{code:java}
DeprecationWarning: 'async' and 'await' will become reserved keywords in Python 3.7 {code}
This warning tells us that in updated versions of python, await and async will be treated as keywords. And hence we get this warning while reusing in the user-defined functions and variables.
Solution:
Rename the function names from await to anything relevant.

Pavan Krishna Thunuguntla commented in Jira Server:

Created PR

@max-seagate, This warning got resolved in this PR: https://github.com/Seagate/cortx-hare/pull/1948, please check.
Since the issue is resolved, Is it okay to close the issue?

Supriya Chavan commented in Jira Server:

Merged to main.

Supriya Chavan commented in Jira Server:

Verified


EIB CLI to replace podman run

Rather than using podman run to execute EIB, we should create a small CLI tool that wraps this and checks system compatibility. For example:
$ image-builder --config-directory /path/to/config-directory
[INFO] Checking system compatibility...
[INFO] Creating temporary directories...
[INFO] Validating configuration file...
[INFO] Validating provided image...
[INFO] Validating networking configuration...
[INFO] Executing Podman build...

(tail logs)

Would a shell script suffice?

@jdob it could... we just need to make it less error prone when running EIB via podman run

What about an alias in the meantime?
$ alias eib='podman run --rm -it -v $IMAGE_DIR:/eib eib:dev /bin/eib build'
$ eib --config-file $CONFIG_FILE.yaml --config-dir /eib --build-dir /eib/_build

@e-minguez I think we need something that wraps the command and simplifies execution. We should also consider checking for pre-requisites like podman, the btrfs packages, and perhaps check cgroup version to run privileged automatically.

@e-minguez I think we need something that wraps the command and simplifies execution. We should also consider checking for pre-requisites like podman, the btrfs packages, and perhaps check cgroup version to run privileged automatically.

I agree. My proposal was just a cheat in the meantime 😃


feat: Implement W3C verification (FE)

Implement W3C verification with connections.

[x] Refactor existing flow of verification with connections.
[x] Add payload structure which will be work for both INDY and W3C schemaTypes.

As tested, The changes are as expected, Thus Changing the status to "Done".


Updates versions for cyon.ch and adds phpinfo URLs

We do provide a phpinfo URL for the standard version, if that's something you're planning to automate :) https://phpversions.cyon.info/

Lovely! I have a local script that runs, so its semi-automated. I'll get that script running daily somewhere when I have enough time to think. :)
Thank you!


Golang receiver methods analysis

Describe the bug
While attempting to analyze Ghidra analysis for Golang binaries, a discrepancy was encountered regarding the getDef() function for receiver methods. The following code snippet was analyzed:
func RunCommandHandler(w http.ResponseWriter, r *http.Request) {
    cmd := r.URL.Query().Get("cmd")
    timeout := r.URL.Query().Get("timeout")

    bashRunner := &BashRunner{
        Cmd:     cmd,
        Timeout: 10, // Default timeout of 10 seconds if not provided
    }

    if timeout != "" {
        bashRunner.Timeout = convertToInt(timeout)
    }

    output, err := bashRunner.Run()
    if err != nil {
        http.Error(w, fmt.Sprintf("Failed to execute command: %s\nError: %s\n", cmd, err), http.StatusInternalServerError)
        return
    }

    fmt.Fprintf(w, "Command output:\n%s", string(output))
}

After analysis, the decompiled output of Ghidra was examined up to the bashRunner.Run() call:
void main::main.RunCommandHandler(net/http.ResponseWriter w,net/http.Request *r)
{
    []interface_{} a;
    net/url.Values phVar1;
    int iVar2;
    void *pvVar3;
    runtime.itab *prVar4;
    undefined auVar5 [16];
    string sVar6;
    string format;
    io.Writer w_00;
    main.(*BashRunner).Run_multivalue_return_type mVar7;
    string sVar8;
    string format_00;
    []interface_{} a_00;
    net/http.ResponseWriter w-spill;
    net/http.Request *r-spill;
    main.BashRunner *bashRunner;
    runtime._type *local_198;
    net/url.URL *local_178;
    net/url.URL *local_170;
    string timeout;
    error err;
    string cmd;
    interface_{} local_e8;
    string local_d8;
    error local_c8;
    []uint8 output;
    undefined local_58 [16];
    int iStack_48;
    uint8 *local_40;
    undefined local_38 [16];
    interface_{} local_28;
    undefined local_18 [16];

    w_00.data = w.data;
    auVar5 = (undefined  [16])0x0;
    while (&local_178 <= CURRENT_G.stackguard0) {
      runtime::runtime.morestack_noctxt();
    }
    local_170 = r->URL;
    phVar1 = net/url::net/url.(*URL).Query(local_170);
    sVar6.len = 3;
    sVar6.str = (uint8 *)"cmd";
    sVar6 = net/url::net/url.Values.Get((net/url.Values)phVar1,sVar6);
    local_178 = r->URL;
    phVar1 = net/url::net/url.(*URL).Query(local_178);
    sVar8.len = 7;
    sVar8.str = (uint8 *)"timeout";
    timeout = net/url::net/url.Values.Get((net/url.Values)phVar1,sVar8);
    cmd.str = sVar6.str;
    cmd.len = sVar6.len;
    local_58._0_8_ = cmd.str;
    iStack_48 = 10;
    local_58._8_8_ = cmd.len;
    if (timeout.len != 0) {
      iVar2 = main.convertToInt(timeout);
                      /* WARNING: Ignoring partial resolution of indirect */
      iStack_48 = iVar2;
    }
    local_40 = (uint8 *)0x0;
    local_c8 = (error)auVar5;
    local_38 = auVar5;
    mVar7 = main.(*BashRunner).Run((main.BashRunner *)local_58);
}

Issue with Analysis:
Upon using the API call to trace the function call, the obtained Pcode was:
(VARIABLE, 0x40, 40) CALL (ram, 0x62c7c0, 8) , (unique, 0x3c80, 8)

Subsequently, performing getDef() on the unique identifier led to:
(unique, 0x3c80, 8) CAST (unique, 0x100003a0, 8)

Continuing to trace the definition, the next Pcode encountered was:
(unique, 0x100003a0, 8) PTRSUB (register, 0x20, 8) , (const, 0xffffffffffffffa8, 8)

This up tracing sequence led to a dead end due to the need for a definition for the register 0x20. Furthermore, its descendants did not lead to the desired variable local_58, hindering the analysis process. Consequently, understanding the program flow and security risks related to using local_58 within the function call context became challenging.
Expected behavior
When tracing up the definition of the receiver method, the expectation is to arrive at the point of local_58 creation. By examining its descendants, the aim is to reach the line where local_58.0_8 = cmd.str; is defined.
Environment (please complete the following information):

OS: macOS 13.0
Java Version: <IP_ADDRESS>
Ghidra Version: 11.0.1
Ghidra Origin: Locally built

What arch is the go binary compiled for?  Could you show the storage that was assigned to the return value of the main.(*BashRunner).Run() function?


Feature Request: rename AuthorizeStep to AuthenticateStep

The AuthorizeStep class does check for authentication status and has nothing to do with authorization. Thus the name AuthenticateStep is more aligned with its scope.
But the main reason for renaming is to let a future authorisation plugin use the AuthorizeStep name for its pipeline step class.

i agree. we can keep a (deprecated) AuthorizeStep without conflict (mostly).
on a general note: we wanna stay like 100% BC to vanBlandels for the time being for ease of switching over

Ok for BC.. But then I should call my step RealAuthorizeStep?? 😲

unless one/you imports {AuthorizeStep}  from 'authelia-authentication'... there's no conflict and in that case one could use import {AuthorizeStep as OldAuthorizeStep] from 'authelia-authentication'

Well that will be common case, unfortunately, cause one will add first
an authentication step and then an authorization one..
So we will end up with aliasing by default, something like
import {AuthorizeStep as AuthenticateStep] from 'authelia-authentication';
import {AuthorizeStep] from 'authelia-whateverwenamedit';
but we deal with compromises every day, so that's fine if properly
documented
doktordirk wrote:

unless one/you imports {AuthorizeStep} from
'authelia-authentication'... there's no conflict and in that case one
could use import {AuthorizeStep as OldAuthorizeStep] from
'authelia-authentication'
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SpoonX/aurelia-authentication/issues/156#issuecomment-222631980,
or mute the thread
https://github.com/notifications/unsubscribe/AEs9633ED23FzW1LeweynRNrmQmTPqDXks5qG_lfgaJpZM4IqRfT.

Discard my last comment.. we said you'll add a new AuthenticationStep class anyway, so what I said is garbage 😖

hehe, i started to get lost. perfect then


Change font size

Make it possible to change the font size.

Related: #8

This one could be tricky to do without running the risk of making the UI unusable.  But, maybe just supporting supporting scaling via a small set of pre-determined sizes would be feasible.


Duplicate users returned in macOS

This bug is originally reported in https://github.com/nushell/nushell/issues/1204
Seems that current implementation for macOS returns duplicates and it is a bug!

Thanks for looking into this, since I opened the original issue, let me know if you need any more details.

I'm not sure how that slipped my mind initially, but heim::host::users() returns user sessions.
For example, with me as a logged in macOS user with 3 Terminal tabs opened it will return 4 user entries, and it is an expected behavior.
As for this issue, it should be considered not a bug and if nushell wants to, they can remove duplicates by matching on User::username


fix input margin-bottom value

Hey John - great work on the theme!
I assume this is a typo / oversight. Let me know. Thanks.

Thank you!


Create a Plugin Which Supports DeepFloyd IF

Hello @cruhl,
I am interested in working on a plugin that supports DeepFloyd. Can we discuss this further?


FireFly Sandbox

We should have an option to deploy the FireFly Sandbox application as part of the main firefly chart for dev / POC deployments of FireFly.

Closed by #53


NC | NSFS | CLI Basic Support of IAM Accounts Configs - Delete Account

Explain the changes

Handle the case where an account has more than 1 access key object.
Add override with a Sensitive string of access key object in a loop (instead of only the first element).

Issues: Fixed

In PR #8195 we didn't add this handling.

Testing Instructions:
Unit Tests:
Please run: sudo npx jest test_nc_nsfs_account_cli.test.js
Manual Tests:

Create the root user account with the CLI: sudo node src/cmd/manage_nsfs account add --name shira-1001 --new_buckets_path /tmp/nsfs_root1 --access_key <access-key> --secret_key <secret-key> --uid <uid> --gid <gid>
Note: before creating the account need to give permission to the new_buckets_path: chmod 777 /tmp/nsfs_root1.
Start the NSFS server with: sudo node src/cmd/nsfs --debug 5 --https_port_iam 7005
Notes:

Before starting the server please add this line: process.env.NOOBAA_LOG_LEVEL = 'nsfs'; in the endpoint.js (before the condition if (process.env.NOOBAA_LOG_LEVEL) {)
I Change the config.NSFS_CHECK_BUCKET_BOUNDARIES = false; //SDSD because I'm using the /tmp/ and not /private/tmp/.

Create the alias for IAM service: alias nc-user-1-iam='AWS_ACCESS_KEY_ID=<access-key> AWS_SECRET_ACCESS_KEY=<secret-key> aws --no-verify-ssl --endpoint-url https://localhost:7005'.
Use AWS CLI to create an IAM account with 2 access keys:

nc-user-1-iam iam create-user --user-name Benny
nc-user-1-iam iam create-access-key --user-name Benny
nc-user-1-iam iam create-access-key --user-name Benny

Test noobaa-cli account delete: sudo node src/cmd/manage_nsfs account delete --name Benny
Make sure that there are no symlinks left that point to Benny by sudo tree /etc/noobaa.conf.d/.

[ ] Doc added/updated
[X] Tests added

@alphaprinz I added a commit, hence asking for re-reviewing it.


Attempting to play a specially encapsulated TS format video in ExoPlayer results in a pointer out-of-bounds exception.

Problem Description
I've integrated ExoPlayer into my application to play TS format videos from a server URL. However, I encountered an exception that prevents the video from playing correctly. The exception is an ArrayIndexOutOfBoundsException thrown while trying to retrieve the buffered position.
##Version
Media3 1.3.0
Error Log
Here is the complete stack trace of the error:
Playback error
androidx.media3.exoplayer.ExoPlaybackException: Unexpected runtime error
at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:636)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:223)
at android.os.HandlerThread.run(HandlerThread.java:67)
Caused by: java.lang.ArrayIndexOutOfBoundsException: length=2; index=2
at androidx.media3.exoplayer.source.ProgressiveMediaPeriod.getBufferedPositionUs(ProgressiveMediaPeriod.java:395)
at androidx.media3.exoplayer.source.MaskingMediaPeriod.getBufferedPositionUs(MaskingMediaPeriod.java:203)
at androidx.media3.exoplayer.MediaPeriodHolder.isFullyBuffered(MediaPeriodHolder.java:153)
at androidx.media3.exoplayer.ExoPlayerImplInternal.shouldTransitionToReadyState(ExoPlayerImplInternal.java:1806)
at androidx.media3.exoplayer.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:1053)
at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:510)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:223)
at android.os.HandlerThread.run(HandlerThread.java:67)

My code looks like this
player=new ExoPlayer.Builder(context).setLooper(mHandlerThread.getLooper()).setLoadControl(loadControl).build();
DataSource.Factory dataSourceFactory = new DefaultDataSource.Factory(context);
MediaItem mediaItem = MediaItem.fromUri(mVideoUri);
mediaSource = new ProgressiveMediaSource.Factory(dataSourceFactory).createMediaSource(mediaItem);
player.setMediaSource(mediaSource );
player.prepare();

The video file cannot be uploaded due to copyright reasons.
How do I fix it ? Thank you for your assistance.

Thanks for reporting the error. Could you share the media file that reproduces the issue? It looks not quite clear how this problem can happen, so I think we can only debug this further if we can reproduce it ourselves. You can send a link to<EMAIL_ADDRESS>with "Issue #1476" in the subject if you don't want to share it here.

I have already sent the problematic media file. Hope it is helpful for solving the issue. Thank you.

Thanks for sharing the file. It seems this is caused by adding tracks in the TS file that are only advertised later in the file after ExoPlayer already finished its initial preparation step. I'll add a fix to the class that currently breaks to ignore such tracks as they are unsupported.


Flutter Gallery 0.4.2 fails to load icons.

Flutter Gallery 0.4.2 April 2018 version running on Android 7.0 Moto G4 Plus fails to load the icons as shown in below screenshots.

Dup of #17485 ?

Closing this as dup of #17485


[Suggestion] translate

A translator that works in chat. It will auto translate messages in chat not in your language to your language. You can also type a command like @fr... Which will translate your message into the language eg French. This is a good feature given a large player base of the game do not speak English. There is some code that was implemented at Pastebin  usage of this feature can be seen in this Video
I tried to implement this myself but had problems with the protobuff api as I don't know cpp to well and couldn't fix the problems

Could be a nice feature

You should know that automatic translation does not convey the true meaning. Many languages have native characteristics.

Of course, however regardless of actual linguistics, it can translate with some decent accuracy languages and the general meaning can usually be understood which is my reasoning behind using that phrase. It is the closest to universal chat where everyone understand each other. 朋友
-------- Original Message --------
On 13 Aug 2019, 13:01, 辣条哥哥 wrote:

You should know that automatic translation does not convey the true meaning. Many languages have native characteristics.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Oh yeah I have this in a different cheat I use. It is helpful indeed to understand those polish people but I don't think it's useful in osiris yet if I am going to be honest. There are many features I would like to see be added before this. I don't think a translator should be high priority.

Translator shouldn't be a priority. I don't think it's going to be accurate enough to translate thousands of Russian lines every day.

If you use an api then some other website does the translating probably using ai which the user doesn't care about, the translator just queries the api
-------- Original Message --------
On 15 Aug 2019, 10:10, LRW1 wrote:

Translator shouldn't be a priority. I don't think it's going to be accurate enough to translate thousands of Russian lines every day.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Unlock Counter Operative mode for Solo and Netplay

It frustrates me that Counter Operative mode is blocked in single-player. I was wondering if you could unlock it. I know it's pointless, but I hate seeing modes blocked, and the game isn't really 100% finishable without it. I'm also wondering if you're going to include the Counter Operative mode for Netplay?

You can just set FakeGamepads to 2 in pd.ini to unlock it. That will still spawn a player 2 that doesn't do anything though, because it isn't really an option to have it with one player.
It is not available in netplay, but may be implemented in the future.

In fact, it's useless solo. There are no stars in Counter Operative mode on N64. I confused it with the XBLA version where they were available.

I guess I'll consider this solved for now, other than the netplay part.


Fix triplet to csr conversion for input ending with empty lines

The previous fix was not working for matrice ending with empty lines/columns.
This commit fixes this issue and adds a related test.

Thanks a lot for finding this other edge case and fixing it. This seems much more robust now.


feat: aave integration

Looking good! Before a more in-depth code review I'd like to point a few UX improvements that can be made:

Handle unsupported chains. In the image below I've connected to Celo, which is unsupported by Aave, but the page still shows the dashboard with assets. I'd recommed to check if the chain is supported and if not just show a message saying that it's an unsupported chain rather than rendering the dashboard.

The supply/borrow select is not needed unless you're in a small screen, so you can conditionally hide it with tailwind

(Optional) On the supply table you could hide assets with 0 balance as default and add a checkbox to toggle it (like in Aave's UI)

@0xChin moving the PR to https://github.com/turbo-eth/template-web3-app/pull/133


Add a license

Hi there. I would like to run your code, but without a valid software license, I have no legal permission to do so. Please apply a license to your project.
A few licenses that I would recommend, depending on how you want people to use your code, are:

Apache 2.0
MPL 2.0
GNU AGPLv3

@iomintz
Added MIT license, please feel free to make any changes and also you are welcome to make contributions to this repository.
See #2


missing support for security type OpenID Connect Discovery (openIdConnect)

npm test test/openapi-syntax.test.js

><EMAIL_ADDRESS>test /home/joenio/src/lisis/risis-rcf-risor
> jest "test/openapi-syntax.test.js"

 FAIL  test/openapi-syntax.test.js
  OpenAPI document
    ✕ openapi.yaml file is valid (129 ms)

  ● OpenAPI document › openapi.yaml file is valid

    One or more errors exist in the OpenApi definition
      at: security > 0 > OpenID > OpenID
        Security requirement for openIdConnect value must be an empty array

But OpenAPI specs says that OpenID must not be empty array, it must be filled by the scopes in a array format.

https://swagger.io/docs/specification/authentication/openid-connect-discovery/

Thanks for sharing this issue. I'll look into it and hopefully have a fix tomorrow.

Thank you very much @Gi60s

The fix has been published in version 1.14.1. Thanks again for the issue.


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 2.5.16 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Adapter Executor Thread in STA by default

Hi @saikrishnav, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Sai Krishna Vajjala). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Looks good. Please consider not creating a new thread for netcore scenarios.


Net::WriteTimeout with #<TCPSocket:(closed)> (Faraday::TimeoutError) error when trying to upload an APK

Issue Description
When trying to upload an APK to App Distribution, the upload starts correctly, but always fails before completion with the following error:

Configuration
# Upload to Firebase
      firebase_app_distribution(
        android_artifact_type: 'APK',
        android_artifact_path: apk_path,
        app: app.firebase_android_app_id,
        firebase_cli_token: @env_manager.firebase_token,
        groups: 'everyone',
        release_notes: changelog
      )

Complete verbose output
Displayed in the "Issue Description" screenshot
Environment
Output of bundle exec fastlane env:
✅ fastlane environment ✅
Stack

Key
Value

OS
12.5

Ruby
2.6.10

Bundler?
true

Git
git version 2.35.1

Installation Source
~/.gem/ruby/2.6.10/bin/fastlane

Host
macOS 12.5 (21G72)

Ruby Lib Dir
~/.rubies/ruby-2.6.10/lib

OpenSSL Version
OpenSSL 1.1.1q  5 Jul 2022

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
13.1

Swift Version
5.5.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
[...]
      # Upload to Firebase
      firebase_app_distribution(
        android_artifact_type: 'APK',
        android_artifact_path: apk_path,
        app: app.firebase_android_app_id,
        firebase_cli_token: @env_manager.firebase_token,
        groups: 'everyone',
        release_notes: changelog
      )
[...]

fastlane gems

Gem
Version
Update-Status

fastlane
2.209.0
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-firebase_app_distribution
0.3.5
✅ Up-To-Date

Loaded gems

Gem
Version

did_you_mean
1.3.0

bundler
2.2.32

rake
13.0.6

rexml
3.2.5

CFPropertyList
3.0.5

concurrent-ruby
1.1.10

i18n
1.12.0

minitest
5.16.3

tzinfo
2.0.5

zeitwerk
2.6.0

activesupport
<IP_ADDRESS>

public_suffix
4.0.7

addressable
2.8.0

artifactory
3.0.15

atomos
0.1.3

aws-eventstream
1.2.0

aws-partitions
1.619.0

aws-sigv4
1.5.1

jmespath
1.6.1

aws-sdk-core
3.132.0

aws-sdk-kms
1.58.0

aws-sdk-s3
1.114.0

babosa
1.0.4

circleci
2.1.0

claide
1.1.0

colored
1.2

colored2
3.1.2

highline
2.0.3

commander
4.6.0

date
3.2.2

declarative
0.0.20

digest-crc
0.6.4

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

dotenv
2.8.1

emoji_regex
3.2.3

excon
0.92.4

faraday-em_http
1.0.0

faraday-em_synchrony
1.0.0

faraday-excon
1.1.0

faraday-httpclient
1.0.1

multipart-post
2.0.0

faraday-multipart
1.0.4

faraday-net_http
1.0.1

faraday-net_http_persistent
1.2.0

faraday-patron
1.0.0

faraday-rack
1.0.0

faraday-retry
1.0.3

ruby2_keywords
0.0.5

faraday
1.10.1

http-cookie
1.0.5

faraday-cookie_jar
0.0.7

faraday_middleware
1.2.0

fastimage
2.2.6

gh_inspector
1.1.3

jwt
2.4.1

memoist
0.16.2

multi_json
1.15.0

os
1.1.4

signet
0.17.0

googleauth
1.2.0

httpclient
2.8.3

mini_mime
1.1.2

trailblazer-option
0.1.2

uber
0.1.0

representable
3.2.0

retriable
3.1.2

webrick
1.7.0

google-apis-core
0.7.0

google-apis-androidpublisher_v3
0.25.0

google-apis-playcustomapp_v1
0.10.0

google-apis-iamcredentials_v1
0.13.0

google-apis-storage_v1
0.17.0

google-cloud-env
1.6.0

google-cloud-errors
1.2.0

google-cloud-core
1.6.0

google-cloud-storage
1.38.0

json
2.6.2

mini_magick
4.11.0

naturally
2.2.1

optparse
0.1.1

plist
3.6.0

rubyzip
2.3.2

security
0.1.3

simctl
1.6.8

terminal-notifier
2.0.0

unicode-display_width
1.8.0

terminal-table
1.8.0

tty-screen
0.8.1

tty-cursor
0.7.1

tty-spinner
0.9.3

word_wrap
1.0.0

nanaimo
0.3.0

xcodeproj
1.22.0

rouge
2.0.7

xcpretty
0.3.0

xcpretty-travis-formatter
1.0.1

fastlane-plugin-firebase_app_distribution
0.3.5

mime-types-data
3.2022.0105

mime-types
3.4.1

multi_xml
0.6.0

httparty
0.20.0

mini_portile2
2.8.0

racc
1.6.0

nokogiri
1.13.8

stringio
3.0.2

time
0.2.0

uri
0.11.0

open-uri
0.2.0

open3
0.1.1

ruby-progressbar
1.11.0

generated on: 2022-08-17

Hi @spatenotte thanks for reaching out.  I'm an engineer on the team that supports Firebase App Distribution and I'd be happy to help you out with this.
Is this issue still happening persistently for you?
Would you be willing to come join us on the Firebase Community Slack and DM me or post to our channel #app-distribution to exchange more detailed information?  Specifically I'm thinking I could take a look at your APK to see if there are any particular qualities that might cause this unexpected timeout.

+1

@emthomas If this is happening to you too, I'd similarly invite you to our Firebase Community Slack and the #app-distribution channel where I or one of our team members can connect directly to try some troubleshooting steps.

Thanks @jladieu, adding the link to my Slack message here for visibility: https://firebase-community.slack.com/archives/CJU4CK4NT/p1661791958830069

This should be fixed with #281

Thank you team, I've verified that v0.3.6 fixes my issue! 🙌


Test classes should have test methods

Summary
Enabled by default: true
Default severity: Info
Title: Test classes should have test methods
When a non-abstract or static type is marked with [TestClass] (or any descendant), it should contain at least one test method.

The analyzer should consider Assembly Initializers:
[TestClass]
class GlobalState {
  [AssemblyInitializer]
  static void Init(TestContext context) { … }
  [AssemblyCleanup]
  static void Cleanup() { … }
}

Ah, so
[TestClass]
static class GlobalState {
 [AssemblyInitializer] …

would work?
If this is the case, the wording "non-abstract or static type […] should contain at least one test method" should not include "static" (or rephrase that it applies to non-abstract and non-static / non (abstract or static)), then the analyzer can be stricter for these types.

Just realizing that I already created a ticket for this one here #2236. Will close this one as duplicate and copy your comments.


Any plan to support Styled Jsx syntax highlighting?

https://github.com/zeit/styled-jsx

Not directly, but you can add the string below to one of my package settings (Please update to v2.54.0 first). Having added it. wait 10 seconds and you should see a new extension grammar being created that will do what you want. For more info see the readme
"(?<=<style jsx>{)|(?<=<style jsx global>{)":source.css

should give you something like

If you also need to embed interpolations like ${something => something} then you may want to use my css grammar instead. This is used by styled-components.
e.g.
"(?<=<style jsx>{)|(?<=<style jsx global>{)":source.css.styled

Thanks that works perfectly

@gandm Noob here. Can't seem to find the 'settings' tab. Closest i got it this:

@oleole90 Atom settings for the editor itself as well as all package options are available via the settings menu option or via the shortcut ctrl+, From there goto to the packages and select language-babel.

@gandm There is just a Readme file there.

No editable input field found like yours

Another thing is confusing me is that:
inside:
packages/language-babel/grammars/Babel Language.json there is a valid json there but "(?<=<style jsx>{)|(?<=<style jsx global>{)":source.css looks like a reverse json to me! How can I even put something like this inside a json (as mentioned here) about scopeName?

@oleole90  If you don't see any settings it looks like the package isn't installed correctly. Uninstall it and re-install & restart Atom and try again. Please do not attempt to change any of the language-babel JSON files directly.
You should see:-

The setting you mention actually creates a new grammar file.  language-babel changes the setting provided to a valid JSON grammar file. Also, use "(?<=<style jsx>{)|(?<=<style jsx global>{)":source.css.styled as this allow for syntax, interpolation and auto-completion of styled CSS.
The grammar file created byt the above would look something like.

Yayyy! It's working after uninstall>Restart>Install!
Thank you so much dude! You're awesome!

If i need to let him support
export default `div {display: inline-block}`

How do i do it

@kudorori The tagged template literal could contain any type of data. In your case it is CSS but it could easily be SQL, GraphQL,.... and I have no way of knowing. You could do:-
export default /*css*/`div {display: inline-block}`

and then in my tagged template grammar configuration option add the following
/*sc*/:source.css.styled

If you are using Zeit's styled JSX then the string in this config will look like
"(?<=<style jsx>{)|(?<=<style jsx global>{)":source.css.styled,/*sc*/:source.css.styled

@gandm It works for me, great!

Can't make it work with nuclide atom IDE, before nuclide it works great


fix(Editor) Use rounding and support Maps to improve ref equality

Problem:
DOM element measurements weren't rounding, so ref equality was often lost in the metadata due to floating point precision. Also, Maps were completely truncated when run through keepDeepReferenceEqualityIfPossible
Fix:
Round all DOM element measurements to the nearest 0.5, and extend keepDeepReferenceEqualityIfPossible to support Maps.
The rounding here has reduced the time to render each frame when scrolling in the Majestic Broker project by roughly 5-8ms!

@Rheeseyb amazing find. I forgot what's the latest here in terms of browser support, but: do we need rounding to 0.5, or should we round to 1 here?

@Rheeseyb amazing find. I forgot what's the latest here in terms of browser support, but: do we need rounding to 0.5, or should we round to 1 here?

I think keeping it at 0.5 is fine tbh, because this should have little affect elsewhere. It's purely to prevent the floating point imprecision.


sqlsrv connection issues via browser - error: "There is some problem in connection: SQLSTATE[IMSSP]: This extension requires the Microsoft ODBC Driver for SQL Server"

Hello, i need help on identifying what i am missing on this setup.
I need to connect MSSQL server via php/apache/linux setup.
Connections works fine CLI (php mytest_connect_script.php) , however not from browser.
-----details----
+## PHP Driver version or file name
Array
(
[0] => odbc
[1] => sqlite
[2] => mysql
[3] => sqlsrv
)
+## SQL Server version
Microsoft SQL Server 2008 R2 (SP2) - 10.50.4000.0 (X64)
+## Client operating system
Red Hat Enterprise Linux Server release 7.3 (Maipo)
+## PHP version
7.2
+## Microsoft ODBC Driver version
unixODBC-2.3.1-11  and have /etc/odbcinst.ini with freeTDS as well.
+## Table schema
+
+## Problem description
testing connection:
mytest_connect_script.php - works fine from command line  (CLI) but it does not on browser (apache)
+## Expected behavior and actual behavior
connected via web browser
+## Repro code or steps to reproduce
//-----------------------
// PDO connection
//-----------------------
class pdo_connection {
protected $con;
public function openConnection(){
try {
$this->con = new PDO("sqlsrv:Server=".DB_HOST.";Database=".DB_NAME, DB_USER, DB_PASS);
return $this->con;
}
catch (PDOException $e) {
echo "There is some problem in connection: " . $e->getMessage();
}
} //end of func
public function closeConnection() {
$this->con = null;
}//end func
} //end of clas
comments:
Any hints on this specific issue will be appriciated.
I have bieng gloogling nothing lead me to good solution.

using this : Driver=ODBC Driver 13 for SQL Server

hi @leepolanco
Did you follow every step in our instruction documentation
What's the output when you ran odbcinst -q -d -n 'ODBC Driver 13 for SQL Server'
FYI, this is the FAQ which might help.

Thank you Yitam for getting back to me.
Somewhat i did follow steps, php/apache were compiled locally due to network restriction on our site.
sqlsrv items, the setup was followed as described (phpsize, etc.. as described)
but still looking for hints.
what's funny.. testscript.php (which connect SQL DB)  works fine from command line.
just not working on browser.
Output of:  odbcinst -q -d -n 'ODBC Driver 13 for SQL Server'
[ODBC Driver 13 for SQL Server]
Description=Microsoft ODBC Driver 13 for SQL Server
Driver=/opt/microsoft/msodbcsql/lib64/libmsodbcsql-13.1.so.9.2
UsageCount=1
Server=##.##.##.##   {this is target DB ip address}
Port=1433
charset=UTF-8

Hi @leepolanco, something is wrong, but please try the followings:
(1) cat /etc/odbcinst.ini
(2) ls -l opt/microsoft/msodbcsql/lib64/ (you should see libmsodbcsql-13.1.so.9.2)
(3) dltest /opt/microsoft/msodbcsql/lib64/libmsodbcsql-13.1.so.9.2 SQLGetInstalledDrivers

Hi @leepolanco, depending on some environment variables, where unixODBC finds odbcinst.ini can be different.
Please try doing an strace like this
strace [apache process] | grep odbcinst.ini
FYI about strace
strace: must have PROG [ARGS] or -p PID
Try 'strace -h' for more information.

thank you again.
but still searching.
keep you posted if anything

@leepolanco just thought it's worth trying to run phpinfo() in your browser.
Do you have more than one php version installed? Is there more than one php.ini in your env, for example? This link might be useful.

thank you!
fyi:
Only one php.ini and phpinfo() runs fine on browser..
This is test SQLconnection code runs well command line but on not browser!
test code:

command line:
$date; php  mytest2.php ;date
Tue Jun 26 23:08:31 EDT 2018
Connection established.
Tue Jun 26 23:08:31 EDT 2018

"<?php
require_once("../../libs/php/common/sqlsrv_properties.php");
$conn = new PDO("sqlsrv:Server=".DB_HOST.",".DB_PORT.";Database=".DB_NAME, DB_USER, DB_PASS);
if( $conn )
{
echo "Connection established.\n";
}
else
{
echo "Connection could not be established.\n";
}
?>
"

strace -p 29753  | grep odbcinst.ini
Process 29753 attached
select(0, NULL, NULL, NULL, {0, 18617}) = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0}^CProcess 29753 detached
<detached ...>

" strace -p 29753  | grep odbcinst.ini
Process 29753 attached
select(0, NULL, NULL, NULL, {0, 18617}) = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0})     = 0 (Timeout)
wait4(-1, 0x7ffd7a3ea764, WNOHANG|WSTOPPED, NULL) = 0
select(0, NULL, NULL, NULL, {1, 0}^CProcess 29753 detached
<detached ...>
"

Hi @leepolanco, I have not been able to reproduce this. I don't have freeTDS in my env however. Can you try this in another setting without freeTDS? Meanwhile I will do some investigation.

Hi @leepolanco,  even with freeTDS installed I have no problem connecting using browser (Apache). Yet, I didn't really configure freeTDS or specify any DSN.
That being said, you don't need freeTDS to connect to MS SQL Server. The MS ODBC driver is what the php drivers need to connect to SQL Server.
This is another useful reference you might find useful.

hi @leepolanco , any update? Another user (see issue #805) has experienced a similar issue and managed to find a solution. Please take a look and see if it helps.

Thank you for following up.
fyi -  we are trying to upgrade from RHEL 7.3 to 7.4.
i think, this might be related to openssl (1.0.1) version we have installed on RHEL 7.3.
on RHEL 7.4, we will have openssl 1.0.2
keep you posted.

Updates:

After upgrade to RHEL7.4 and openssl1.0.2 libs installed

the msodbcsql17-<IP_ADDRESS>-1.x86_64.rpm, mssql-tools-<IP_ADDRESS>-1.x86_64.rpm drivers installed.

compiled pdo_sqlsvr.so , sqlsvr.so load.

works fine
thank you!!!


Grep auto complete

I added additional auto-complete options to the grep auto-completion provider. Three types of options were added:

Standard options with free-text values e.g. --version, --regexp.
Options with a fixed set of values/ enumerated types e.g. --binary-files, --devices.
Options who's values are file or directory paths e.g. --file, --exclude-dir.

Am keen to hear your thoughts on whether some of the auto-complete functions can be made more generic and added to the "autocompletion_providers/Common.ts" file.
The long flag options with file or directory path values seem likely candidates i.e. --file, --exclude-dir.

Could you rebase the branch, please?

I tried making the changes requested. Please let me know if any further changes are needed.

It looks good.


Histograms (or barcharts then) (time and number) should allow to aggregate by operation and not only by count

Context
Sometimes you want to show histograms/barcharts that shows data aggregated by something that is not COUNT. Well those are barcharts.
Steps to Reproduce
Please break down here below all the needed steps to reproduce the issue

Imagine you have data with timestamps and commuters on transportation
You want to see commuters per day and create a timeseries widget or a histogram.
When adding a widget, you can only see count of features which doesn't tell the same story.

Expected result
By adding the aggregation operation input we can add this capacity.
This would mean we cannot call the widget histogram anymore :_(
cc/ @javisantana @rochoa @Jorgedelara

Is that example a count aggregation? What changes is the aggregation range, isn't it?

@jsanz could you help @rochoa explaining this issue? It is the EMT problem representing commuters count in the timeseries

After talking with @saleiva, we have agreed that the Time Series widget should allow aggregations, but that doesn't mean we need the histograms to implement that feature, because what we need is a category widget to do the aggregation.
This would work with date[time] columns, but also with any other aggregated category. As an example, consider sum of clients by customer value, in that case, the frontend will display a bar chart instead of a histogram.
cc @xavijam

BTW, this use case is already supported by torque.

I do  not agree with not supporting aggregations in histograms :disappointed:
Real life case: You have an arbitrary number monitoring stations gathering pollution values hourly. You sure want a 24 bins' histogram with the hourly average pollution value of all your stations. Category widget here makes no sense.

Then that would be a barchart. We are not saying not to aggregations
anyway, but we should separate both issues.
On Fri, Jan 13, 2017, 11:25 AM Abel Vázquez Montoro <
<EMAIL_ADDRESS>wrote:

I do not agree with not supporting aggregations in histograms 😞
Real life case: You have an arbitrary number monitoring stations
gathering pollution values hourly. You sure want a 24 bins' histogram with
the hourly average pollution value of all your stations. Category widget
here makes no sense.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/10809#issuecomment-272410425,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIENWuZCaF6y3lbweOjmO57_VBWIDfdks5rR1EcgaJpZM4K675w
.

Stale issue. Closing 👋


Trivial: the systemd example misuses RUST_LOG_STYLE

I might be wrong, but the systemd example (added in #157) overloads RUST_LOG_STYLE. Since that is parsed internally by env_logger, I think the example is suboptimal; it would be better to control the systemd-vs-non-systemd and style separately, as long as systemd is not directly supported (which would be best, actually, as a new WriteStyle).
I might misunderstand the way the WriteStyle is supposed to work though, not sure.

Also, the example given has this error in it
error[E0599]: cannot write into `&mut env_logger::fmt::Formatter`
  --> src/main.rs:26:5
   |
25 | /             writeln!(
26 | |                 buf,
   | |                 ^^^
27 | |                 "<{}>{}: {}",
28 | |                 match record.level() {
...  |
36 | |                 record.args()
37 | |             )
   | |_____________- method not found in `&mut Formatter`
   |
note: must implement `io::Write`, `fmt::Write`, or have a `write_fmt` method
  --> src/main.rs:26:5
   |
26 |                 buf,
   |                 ^^^
   = help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
   |
1  + use std::io::Write;
   |


[build] Update to latest revisions of upstream layers and webOS OSE v2.12.0 build #366

Merged to other branches as well:
44ac9c26e..98f2dc19e  build -> build-next


attention interface.

Signed-off-by: ChengZi<EMAIL_ADDRESS>

Codecov Report

Merging #1091 (6e163a8) into main (f192cab) will increase coverage by 0.11%.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
+ Coverage   69.86%   69.98%   +0.11%
==========================================
  Files         213      213
  Lines        9496     9537      +41
  Branches     1573     1575       +2
==========================================
+ Hits         6634     6674      +40
+ Misses       2401     2400       -1
- Partials      461      463       +2

Impacted Files
Coverage Δ

towhee/trainer/utils/visualization.py
66.21% <95.12%> (+6.54%)
:arrow_up:

towhee/hub/repo_manager.py
79.48% <0.00%> (+0.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f192cab...6e163a8. Read the comment docs.

/lgtm
/approve

/lgtm
/approved

/lgtm