Add ControlZ support to Citadel.

Add ControlZ functionality to Citadel, to be on par with Mixer, Pilot & Galley. See https://istio.io/help/ops/controlz/ for details.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-dashboard

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
d79859353923b8ce23fb33806b6da2bf6eff7abb
link
/test istio-pilot-multicluster-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-mixer-no_auth

prow/e2e-dashboard.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
0f17bc1b56fda3184d236e366049226a5210dfa1
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-mixer-no_auth

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test e2e-simple

prow/istio-pilot-multicluster-e2e.sh
4c0ab486e59de2d1ce3bbaa2bf4ee9f37795ee84
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ping.

Sorry for the delay.
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: myidpt
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [myidpt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4e38dab3a714bcd2e6bcd764384bc1388134d3e0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
4e38dab3a714bcd2e6bcd764384bc1388134d3e0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
4e38dab3a714bcd2e6bcd764384bc1388134d3e0
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

/test e2e-bookInfo-envoyv2-v1alpha3

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: myidpt
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

security/OWNERS [myidpt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
32cdb52d1eb30c7f497b51150159570f5dfb8af5
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-pilot-multicluster-e2e


Compilation error

This is on main right now, I cannot compile the library

Please update the SwiftUI views in your app to the latest template views. They were updated in #1260

Closing as this was due to not using the correct version of the lib to generate the new views


add message param for ping

Pull Request check-list

[ ] Do tests and lints pass with this change?
[ ] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
[ ] Is the new or changed code fully tested?
[ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
[ ] Is there an example added to the examples folder (if applicable)?

Description of change
add message param for ping(), so it can be used like real ping command
fix: #146

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.93%. Comparing base (1f6b63c) to head (4f02122).

:exclamation:  There is a different number of reports uploaded between BASE (1f6b63c) and HEAD (4f02122). Click for more details.
HEAD has 210 uploads less than BASE

Flag
BASE (1f6b63c)
HEAD (4f02122)

211
1

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #149       +/-   ##
===========================================
- Coverage   76.21%   61.93%   -14.28%
===========================================
  Files         130      130
  Lines       33911    33887       -24
===========================================
- Hits        25844    20989     -4855
- Misses       8067    12898     +4831

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore(main): release 0.18.1

:robot: I have created a release beep boop
0.18.1 (2024-09-22)
Bug Fixes

remove print statement from lru_cache_ext function (f919605)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.18.1
:sunflower:


gulp compiles only the first time

Hi, I'm new to mjml and I'm trying to setup gulp. I've installed the plugin and added code in my gulpfile so that gulp watches for any changes to .mjml files
  return src(source, { base: "./" })
    .pipe(mjml())
    .on("error", reportError)
    .pipe(gulp.dest("."));

When I update a .mjml file, gulp does detect the changes and compiles the template but only once. When I make another change and hit save, nothing happens.
Any ideas what could be going on?

You need to use a plugin like gulp watch to have this behavior.

On 7 Jan 2020, at 02:23, Panos Spiliotis<EMAIL_ADDRESS>wrote:

Hi, I'm new to mjml and I'm trying to setup gulp. I've installed the plugin and added code in my gulpfile so that gulp watches for any changes to .mjml files
return src(source, { base: "./" })
.pipe(mjml())
.on("error", reportError)
.pipe(gulp.dest("."));
When I update a .mjml file, gulp does detect the changes and compiles the template but only once. When I make another change and hit save, nothing happens.
Any ideas what could be going on?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thank you for the quick reply! I do use watch and it gets intialized properly in the default task because. The problem is that any changes are detected only once for mjml whereas for other tasks (sass, js etc.) it works just fine after saving any change.
watch("templates/**/*.mjml", function() {
    mjml();
  });

Just share your entire gulp file here we can’t really help you.

On 7 Jan 2020, at 04:45, Panos Spiliotis<EMAIL_ADDRESS>wrote:

Thank you for the quick reply! I do use watch and it gets intialized properly in the default task because. The problem is that any changes are detected only once for mjml whereas for other tasks (sass, js etc.) it works just fine after saving any change.
watch("templates/**/*.mjml", function() {
mjml();
});
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

This is not how watch works : https://www.npmjs.com/package/gulp-watch#usage


Merge from base repo

@jdordoigne I think this is a mistake no ? Am I missing something ?

Yes sorry, bad action

Yes sorry, mistake from my side.


replace desktop installer with version-management installer

Currently we are maintaining both a .pkg and a .msi installer for OSX and Windows. Not only are these baroque, but they are error prone.
I'd like to suggest that we replace both of these with the electron based installer and include version management as a feature in the installer.
It is possible to do over the wire autoupdate on electron apps, this would likely solve quite a number of our problems.

I agree it would be nice to replace all installers with a version manager installer. I have hesitations about Electron/NWJS though. For one, it seems like a "recreate the wheel" situation. FWIW, BitRock offers open source projects a free enterprise license for creating cross-platform installers. Personally, I've found it to be pretty straightforward.
Electron ships a whopping 45MB footprint. This would be the biggest version manager of any language. It also adds a new component to the overall management... someone's gotta maintain the UI.
Electron isn't the only evergreen player. Go also has evergreen capabilities, thanks to go-update. It can do binary diff updates. This is how ngrok works (same author). I know, I know... not JS. It's really not that hard.

It's not about being "hard", it's that things should be accessible to node dot js users, who use JS. Using Go will drastically limit the number of possible contributors, and I don't think any language or filesize benefits are worth that.

so something that I am hinting at here and in #3
If we standardize the folder layout and the way in which the path is shimmed for different environments then people can use whatever run time they want. We can have an official installer built in electron, you could make a tool bar item that can switch versions, you could then use nvm to switch if you prefer.
One other thing to consider with file size... if we can do OTA updates then file size is a bit of a null point

@TheAlphaNerd we already have a first implementation of the electron based installer :)
Every suggestion is welcome!
https://github.com/nodejs/installer

@jlharb - We also don't need thousands of contributors.  Don't get me wrong... I would prefer a JS based solution, I just don't think Go is a bad alternative and it has a number of advantages in dealing with cross-platform system issues.
@TheAlphaNerd - Remember that Squirrel, which is responsible for Electron OTA, expects a complete app, not a diff. Every update will ship the full app, so file size is still going to be comparatively large.
I agree 100% on standardizing a folder layout and shimming.
For shimming, my vote is for symlinks.
On windows, making changes to the PATH require elevated admin privileges (not good enough to just be an admin). The same is true for making any change to C:\Program Files or any subdirectory within. I tried to avoid that by only touching the PATH during the installation process (i.e. set it and forget it). By specifying a path to a known symlink residing in a location that doesn't require elevated admin privileges, changing it is trivial. One of the mistakes I made was giving users a choice of where they wanted to put the symlink. Most users picked C:\Program Files\nodejs anyway, out of habit, despite warnings. This causes 2 UAC prompts whenever the symlink changes... one to remove the old symlink and one to create the new one. Avoiding C:\Program Files would avoid these prompts.
This approach automatically updates all versions, including open terminals. It truly treats the environment as though the version manager weren't there at all, just as if you were to install a new version node, that would be the active version.
As for folder structure, I used a one-folder-per-install approach. I did not split it up by architecture (32 vs 64-bit). In retrospect, that was probably a mistake. It probably should be split by arch as well. The argument several users made was some native modules built using 64-bit architecture failed to work in a 32-bit environment. The downside is this can leave a pretty large overall footprint.

On windows, making changes to the PATH require elevated admin privileges

Not true. It's possible to update PATH for both the current shell and the current user profile without requiring admin privileges. Only system PATH changes require elevation.
A symlink is nice for some scenarios, but limiting for others, such as when you want to select a node version that is per-shell or per-directory. That's why NVS makes complementary use of both PATH changes and symlinks.

@jasongin - you're correct, I should have been more specific about the system PATH.  I've found most users are setting this up system-wide... but that's just my experience (I'm not saying it's right, but it's what people have been doing).
I opted for globally changing the version of node instead of per-terminal because that was the closest representation of what a user would have to do with no version manager installed. From my perspective, per-shell versions are a function of workflow/opinion... not of simply switching what's installed. Per-version versus global use has produced some heated discussions. Sentiment seems to be split 50/50.
This is why I suggested defining what we mean by version management. If we're just proposing version switching, it should operate the same way it would if the user had to do this by hand (i.e. global). If we're proposing a workflow, then we should propose a standard for per-shell use.

Per-[shell] versus global use has produced some heated discussions. Sentiment seems to be split 50/50.

Yes! And actually it's split in more than 2 ways. As @marcelklehr  mentioned in the other issue, there are really four scopes for version management:

system-wide
per-user
per-terminal
per-directory

Managing versions at different scopes is appropriate for different scenarios. That's part of why there are so many different version-management tools available today. I think any converged solution that aims to meet everyone's needs must support at least the first three scopes, and ideally all four.

In order for this project to be an overall success, the above "scopes" as pointed out by @jasongin must be addressed and treated with equal importance.

This doesn't seem to be going anywhere. Please feel free to open a new issue if anyone wants to explore this again.


Add Docker Support [Enhancement]

Description
Added Docker support to make ExposureStats easier to deploy and run in a containerized environment.
Added Files

docker/dockerfile - Base image using Python 3.12-slim with all required dependencies
docker/compose.yaml - Docker Compose configuration for easy deployment
docker/.dockerignore - Optimizes builds by excluding unnecessary files
docker/README.md - Documentation for Docker setup and usage

Features

Uses Python 3.12-slim as base image
Installs all dependencies using uv package manager
Exposes port 8080 for the Streamlit interface
Mounts the application directory as a volume for development
Configurable through environment variables

Testing

[x] Tested local build and run
[x] Verified environment variable configuration
[x] Confirmed Streamlit interface accessibility at http://localhost:8080

Documentation
Added comprehensive Docker documentation in README.md covering:

Quick start guide
Environment variable configuration
Application access instructions

Thanks @Itz-Agasta !


docs(react-scripts): update proxy usage wording

Update the proxy wording and usage instructions
Fixes #5300

@gaearon

It wouldn't be stale if it was merged in ...

Thanks for the PR but this doesn't really seem like an improvement to me. It basically just says the same thing as before but with more words.

@ianmcnally That was the point. The docs, as is, are not clear. This expands and to me, makes it more clear. Did you read the accompanying issue?

I added comments clarifying why the changes were made. Please reconsider this as it could hopefully save some other devs time in figuring out how to use this


feat: data hook

Initial implementation. Should be working but I haven't actually tested it, so opening as a draft for now until I at least push a working example. Feedback already welcome :pray:

💯 I will have a look at it after we merge the V1 docs.

Just had a quick high-level look at it: looks good so far 👍. I will have a closer look after the V1 docs merge and/or after you feel this PR is ready.

I'm happy with this PR now. It is covered with E2E tests and I'm confident it works as intended.
I want to wait for #1206 to land before I write the docs and an example, and I'm fine doing that in a follow-up PR. So as far as I'm concerned this can be merged

FYI I started reviewing this.
One issue Vike's repo has is that is has 78 monorepo packages, which massively slows down E2E tests and pnpm. So I'm trying to reduce the number of packages we create. For example I started merging bunch of tests into /test/misc/.
I wonder: could we maybe merge the unit tests (which is really neat) of /test/data-hook/ and /test/hook-override/ into a single test setup?

// NOTE(aurelien) `data` may not exist at all if the user doesn't use `data` hooks, thus the `?`.
data?: Data

I thought for a moment whether Vike should always set data to an object, but I actually like that data is undefined if there is, well, no data. So I'm thinking it's good like like that 👌.

Your last commit looks good, thanks!
Yes I'll merge /test/data-hook/ and /test/hook-override/, good idea

I wonder about the execution order. I struggle to find a sensible order. I'm actually thinking maybe we shouldn't execute the onBeforeRender hook if there is a data hook: that way we can postpone that ordering decision, and take the decision later when use cases that need both hooks pop up. But I'll mull over it a bit more and maybe a sensible order will occur to me.

I think it's a net win for the user if Vike executes both. I thought about superseeding only because it would allow us to postpone the ordering decision.

2. (New hook onStartup() #962, Global /renderer/+onBeforeRender and Local /page/+onBeforeRender behavior Vike V1 Client Routing #1226,

Neat, thanks for that list of use cases, that's very convenient.
The first use case needs onBeforeRender() to be called before data(), whereas the second use case needs the order to be the other way around.
I'm thinking, a simple solution would be to add one more hook onBeforeData with following order:

onBeforeData
data
onBeforeRender
onRender{Html,Client}

So my proposal would be this: we change this PR to always execute data before onBeforeRender. Then later, in another PR, we implement onStartup(). After that and if the need eventually arises, we implement onBeforeData.
Thoughts? Do you foresee an issue with executing data before onBeforeRender?

Thanks, this sounds good and makes sense. I'll swap the order

I'm happy with this PR :)

👌 I'll have a second look at it. (It didn't review everything last time so new questions may pop up.)

I'm thinking a hook useData() that is just an alias for usePageContext().data could be neat.// The Data generic is required, see example below.
const data = useData<Data>()
/* Equivalent to:
const { data } = usePageContext() as { data: Data }
*/

One neat thing about the data hook is that the user doesn't have to think in terms of pageContext and, instead, directly thinks in terms of data; that's why I'm thinking an alias getData() could be neat for that reason as well: we abstract away pageContext.
Since each page has its own Data structure, I wonder how much sense Vike.Data makes. Maybe it would make more sense to make pageContext.data globally undefined | Record<string, unknown> while forcing the user to always specify Data at the relevant places (at useData() and +data.js).
I guess TypeScript doesn't have the notion of filesystem precedence 🤔 so I'm inclined to think that the user does always need to specify Data at the relevant places.
I thought about renaming +data.js to +load.js but I'm hesitating — I guess +data.js is just fine.

Example:
// /pages/star-wars/types.ts

export type { Data, Movie }

type Data = {
  movies: Movie[]
}
type Movie = {
  id: string
  title: string
  release_date: string
}

// /pages/star-wars/+Page.ts

export { Page }

import React from 'react'
import type { Data } from './types'

// Note how we don't need the whole pageContext.pageProps thing
function Page() {
  return (
    <>

Star Wars Movies

      <MovieList />
    </>
  )
}

function MovieList() {
  // The Data generic is required
  const data = useData<Data>()
  const { movies } = data
  return (

{
      movies.map(({ id, title, release_date }) => (

          <a href={`/star-wars/${id}`}>{title} ({release_date})

      ))
    }

  )
}

// /pages/star-wars/+data.ts

export { data }

import type { Data, Movie } from './types'
import type { DataAsync } from 'vike/types'

// Make the Data generic required here as well? It's useless but it educates the user 🤔
const data: DataAsync<Data> = async (
// While this data hook doesn't need routeParams, it's a frequent use case.
{ routeParams }
): Data  => {
  const response = await fetch('https://star-wars.brillout.com/api/films.json')
  const movies: Movie[] = ((await response.json()) as any).results
  return movies
}

I'm thinking a hook useData() [...]

Super good ideas, thanks a lot. I'll do that. I'll see if I can modify an existing example to make use of useData() (an example that isn't already pointed at by the documentation in order to illustrate pageContext). If you have one in mind, let me know. If I can't find any, I'll write a new example.

👍 Let's see how/if we can remove/merge examples/tests later.

Done :)

Neat :)
I'm hesitating a bit whether my idea was good.
WDYT? Which do you prefer?
const data: DataAsync = async (pageContext): Promise<Data> => {
  // ...
}

const data: DataAsync<Data> = async (pageContext): Promise<Data> => {
  // ...
}

const data: DataAsync<Data> = async (pageContext): ReturnType<DataAsync<Data>> => {
  // ...
}

Can't wait to merge :)

I prefered const data: DataAsync = async (pageContext): Promise<Data> => {
But const data: DataAsync<Data> = async (pageContext): ReturnType<DataAsync<Data>> => { has the advantage, as you said offline, to keep the usual hint about return type that we have on other hooks.
So either of these two choices are fine by me.

Makes sense. There is also the third option of making the generic unknown by default. Consequently, the user can choose which one of two variants he wants to use. I think I like this most, but I'll mull a bit over it 💭

How about this: https://github.com/vikejs/vike/pull/1267/commits/d47fa19f01ffe1423eef91b64d7a729a3e7b34d6?

Nice move, I'd do https://github.com/vikejs/vike/pull/1267/commits/553b070ed4 on top of that. WDYT?

It keeps the important part IMHO of your change, being: +Page imports the Data type from ./+data

I'm thinking inferring can be quite important. Let me elaborate.
In our examples declaring instead of inferring type Data inside +data.ts is easy, but, if the user uses a tool such as Prisma with database query results that are automatically typed, then it can be cumbersome to declare instead of inferring type Data. Even very cumbersome for ORM queries that use .select().
Also the neat thing about inferring is that you can factor/move data fetching logic out of +data.ts without breaking type Data. Otherwise you'd need some brain power to preserve the declared type Data when refactoring.

Makes sense. So if we're going to infer Data from the return type, that means any return type is correct. There is no need to do type checking on the return type, thus there is no need for the generic. Let me push a commit according to that

No I understand now. I couldn't come up with anything better than what you did before. Just reverted my last commit.

I suggest we:

Always showcase the inferring way in the docs and examples.
We keep the DataAsync<Data> type for folks who want 1. the Data type to be defined next to and by the UI component and 2. want to re-use the usual recommendation.

This PR now LGTM. As always, feel free to disagree & nitpick.

Merged 🎉
Big 🙏 for the quite complex PR. I'm thrilled: it's the first PR implementing a major feature 💯
I can't wait for us to release these new lovely data() hooks 👀 It's quite a big DX improvement.

@brillout can we release this as v0.4.151? I'm implementing useData() in vike-react and need this. Thanks :pray:

I ain't sure, but I think it's actually already released in 0.4.150. (IIRC we didn't add a feat:  commit so it's missing in the changlog.)
Anyways, I just pre-released main as<EMAIL_ADDRESS>Let me know if that isn't enough.

@brillout no it's not in 0.4.150 if you look at the git history. It got merged later. And the first commit says feat: data hook
I don't want to write ^0.4.150-commit-e6c3150 in vike-react, so eventually I'd need it to be released. No rush though, but just curious: is there any specific reasons why you're not comfortable releasing 0.4.151?

This release isn't as trivial as usual because Telefunc needs to be co-released (the shared dependency https://github.com/brillout/vite-plugin-import-build has a breaking change).
But let me see if I can release now.

0.4.151 released. (FYI I had to manual fix the changelog; we added some fix:  and feat:  prefix where we shouldn't. Although sometimes it isn't always easy to know when to set them, e.g. I couldn't know whether I would update vite-plugin-import-build again in the future.)

Thanks :) Yes I'll be more careful too with my commit messages with regards to the changelog


Have pypi show the link to github

rendering of the rst file is way too strict to fuzz about with.

Current coverage is 0.00%

Merging #274 into paramz will not affect coverage as of 971820e

No diff could be generated. No reports for #274 found.
Review entire Coverage Diff as of 971820e

Powered by Codecov. Updated on successful CI builds.


Add event_stream_options to expose OPTIONS to the API

For issue: https://github.com/ManageIQ/manageiq-api/issues/1090
Note, currently there are several methods in EventStream whose implementation is
for EmsEvent and should move there.  We'll look at that when we need to
expose/test filtering on MiqEvent levels (success/failure) for the API.

@jrafanie I'm wondering if we should nest these options one more level under data.  That is, if we need to add something else to OPTIONS in the future, the root of the data payload is taken.  Maybe:
      "data": {
-         "EmsEvent": {
+         "event_groups": {
+             "EmsEvent": {

(not sure on the name event_groups...we can debate that)

Ok, applied the suggested changes, other than making timeline_classes private.


Accidental scroll while CLI prompt runs prints unwanted characters

Bug reports
Open any go-prompt enabled CLI app, such as cloudmonkey (https://github.com/apache/cloudstack-cloudmonkey) or kube-prompt. Sometimes in the CLI, while typing accidentally touch or scroll up and down. I'm able to consistently reproduce this issue while using the CLI tools in prompt mode inside tmux.
Screenshot:

Expected Behavior
Such events should be ignored and not cause any kind of unwanted character outputs
Current Behavior and Steps to Reproduce
Steps to reproduce:

Open tmux or any terminal multiplexer
cd and run the cli binary
use mouse to scroll up/down while in tmux, you'll see these characters

See screenshot above.
I tried to add keybindings for mouse events and page up/down, but still saw those errors.
Context

Operating System: Ubuntu Linux 18.10 and 18.04
Terminal Emulator: Guake, gnome terminal, tmux
tag of go-prompt or commit revision: v0.2.3 (also tried latest master, still same issue)

Hmm... Just to be sure, could you tell me the version of tmux? I'll try to reproduce this.

@c-bata tmux version 2.6 and 2.7.

I've found the problem. But it requires many changes to fix this issue. Please give me a few days.

Thanks @c-bata


Update onchain README with current information

The setup guide in the README of the onchain directory is currently outdated.
Update the guide with the latest information

I am Super Franky, a software developer with 3+ years of experience, and I have worked with frontend technologies like React, NextJS, JavaScript/TypeScript. I am also proficient in Cairo and Solidity for smart contract development. I'm a recent graduate of Web3bridge Africa, the foremost and premier blockchain developer community. I have made contributions to many open-source projects, and I look forward to contributing to this one. My approach to this will be to:
Review the documentation in the file to identify outdated or incorrect information.
Update the file with the current information about the game, ensuring all details are accurate and up-to-date.
Cross-check the updated details with the latest features or functionality in the game, and if necessary, reach out to the StarkLudo Contributors Telegram for clarification on any information.
ET: 1 day

I'd love to give this a go.

Can I tackle this one?

May I try my hand at this?

I’d like to resolve this.

I'd love to contribute to this. I'll update the README in the onchain directory to include the latest setup instructions, ensuring it's clear and accurate for developers. The guide will reflect the current state of the project and tools. My ETA is 8 to 24 hours.

May I try my hand at this?
hi
I am a front-end developer specializing in responsive web design.
device-compatible email templates, 3D web integration,
and technical writing on programming topics. I also contribute.
to open-source documentation and help build documentation sites.
I got my first GitHub. badge by contributing to documentation sites and readme.

I'd be happy to help with this. I'll update the README in the onchain directory with the latest setup instructions to make sure it's clear and up to date for developers.

Hi, I am proficient Blockchain developer  expert in Cairo , Rust and Solidity  and also in web development.
I have already  make readme.md  for many projects
please /assign  this issue .
Thank You

May I handle this issue?
If it's still available,  eta 12hrs

@princeibs I will be glad to work on this issue
I am a web3 developer/ Technical writer
I have experience in a lot of open source contributions especially in making Documentation
Here are some of the merged docs I’ve written
https://github.com/Flex-NFT-Marketplace/Flex-Marketplace-Contract/commit/fc28412
https://hackmd.io/@xZ4BOZ5TTTy1I0ZQHXFOkg/rkFBcGgAC

I’d like to help with this.

Can I start working on this? It will be nice to jump on this issue

May I try my hand at this?

Can I tackle this one?

Hello @princeibs,
I’d be happy to work on this issue! I will update the README in the onchain directory with the latest and accurate setup guide, ensuring it reflects the current state of the project.
If approved, I’ll deliver a clear, updated, and high-quality PR within the next 12-24 hours. Let me know if I can proceed!
Looking forward to contributing.

Can I handler this?

Hello @princeibs,
I’d be happy to work on this issue! I will update the README in the onchain directory with the latest and accurate setup guide, ensuring it reflects the current state of the project.
If approved, I’ll deliver a clear, updated, and high-quality PR within the next 12-24 hours. Let me know if I can proceed!
Looking forward to contributing.

Yo, I'm Isaac, a frontend dev.
I'd appreciate it if i can take on this issue.
ETA: 1day

Hello @princeibs,
I’d be happy to work on this issue! I will update the README in the onchain directory with the latest and accurate setup guide, ensuring it reflects the current state of the project.
If approved, I’ll deliver a clear, updated, and high-quality PR within the next 12-24 hours. Let me know if I can proceed!
Looking forward to contributing.

I’d like to work on this issue as I have experience with Cairo and building on StarkNet, including writing and optimizing smart contracts.
ETA:
I estimate completing this task in about less than 1 day. Let me know if I can get started!


add tests for edge cases

Current dependencies on/for this PR:

main

PR #5

PR #6   👈

This comment was auto-generated by Graphite.


Search route fixes #260 add route to get reminder by query

I mistakenly merged the unfinished sockets with this issue


Fix applications fetching at the Application List page

What this PR does / why we need it:
Fix a bug that filter options were not applied when fetching applications after the application action. (EDIT, DELETE, DISABLE, etc.)
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/lgtm

Thank you 🚀
/approve


✨ Add custom fetch for inference

Part of #155

Hey @coyotte508 is this issue fixed?

This PR fixes the issue for the @huggingface/inference module, not the @huggingface/hub one.
Do you need this for your project?

This PR fixes the issue for the @huggingface/inference module, not the @huggingface/hub one.
Do you need this for your project?

No actually I was working on it 😅 no worries if you're on it.

Well I'm only doing it for the @huggingface/inference for now, and the PR is ready. Feel free to work on the PR for @huggingface/hub :)

Alright I am on it then  👍   Thanks 🙂


Ability to add an image to events

We would like to be able to display an image (user's avatar) alongside a string event.title. Perhaps it could be event.image?

Or event.title would be able to have the type string or JSX to allow multiple use cases?

you can use titleAccessor to return more than a string i believe. the calendar should render whatever you return

you can use titleAccessor to return more than a string i believe. the calendar should render whatever you return

@jquense        {
                titleAccessor: <Image
                    source={require('../../assets/images/png/dashBoard.png')}
                    style={[styles.image,  ]}
                    resizeMode='contain'
                />,
                start: new Date(),
                end: new Date(),
            },is this a right way to implement image??


need help: how to disable window menu/titlebar icon ?

as per #438 , can you guys give me guide how to achieve this in newer jwm ? just in window though, not the tray/tasklist
possible reasoning are integration for some flat themes, because 3d legacy icons tends to be not matching well.
here an example, i want top bar on the file manager manager to be clean as possible. either by removing or set a static menu icon.

many thanks in advance.

You can use <TitleButtonOrder> to customize window button see here.


Error on bulk-adding genes to a group

http://www.chibi.ubc.ca/Gemma/geneGroupManager.html
In the gene pane, adding single genes via the search works; but adding in bulk by using the pop-up window fails with a javascript NPE ("cannot read property..."); console is not giving clues.
Also GET http://www.chibi.ubc.ca/Gemma/images/logo/gemOnlyTiny.ico 404 (Not Found)
This page also yields server-side warnings - missing js bundle.

I added an extra null check, but it seems that this can only happen when trying to import a list of genes that all have a taxon different form the taxon of the group. Is it possible that that might have been the case with your data?

They were gene symbols and as you know they are ambiguous about species, so I relied on the system to match them to the species chosen. Desired behaviour: If they don't match, they should just be left out. Ideally the user would be notified i.e. "99/100 genes were recognized".
Even if I had pasted in NCBI gene IDs, same thing should happen.

So the http://www.chibi.ubc.ca/Gemma/images/logo/gemOnlyTiny.ico 404 (Not Found) is fixed - I redirected it to the existing favicon file, but now for some reason the displayed favicon has a white background.
The favicon was displayed properly before, and the line causing the 404 was meta.jsp:29
<link rel="icon" href="<c:url value="/images/favicon.ico"/>"/>
I'd suggest to remove this line alltogether, since modern browsers detect favicons automatically anyway.


Tooltip for Cities on Browse Bills Page

On Browse Bills page, to the left of the "City" search box, insert a tooltip icon:
"this filter only captures bills submitted via "home rule" petition; not every bill that concerns a city"

Hi @jamesvas5307 - is the tooltip icon in the figma? Please link if so.
For now, here are the icons

@akh4rf is this still something you want to tackle? @timblais might want to work on it

Closing as this work is now captured via #1499


Open ttyUSB device in Ubuntu (list pos empty)

Inside device selection there is an EMPTY position which represent the connected device.
dmesg: usb 2-1.2: cp210x converter now attached to ttyUSB0
If selected the device will connected and is usable.
Ubuntu 22.04
Jama just downloaded

Hi @ghvau, do you have download from binaries or from repository sources?
I'll check that.

Ok that's works thanks

Problem was size or character inside port description.
See private mail
On 31.03.23 10:28, Jean-Christophe Bos wrote:

Ok that's works thanks
—
Reply to this email directly, view it on GitHub
https://github.com/jczic/ESP32-MPY-Jama/issues/33#issuecomment-1491522958,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A56V3ZQRF7QR56D733ACGUDW62IS7ANCNFSM6AAAAAAWOHFRRQ.
You are receiving this because you were mentioned.Message ID:
@.***>

Well @ghvau, it's fixed on commit : https://github.com/jczic/ESP32-MPY-Jama/commit/9603f12a1870eee4a723d3d990ca495f267d57e4
:)

Thanks, solved !
On 31.03.23 23:21, Jean-Christophe Bos wrote:

Well @ghvau https://github.com/ghvau, it's fixed on commit : 9603f12
https://github.com/jczic/ESP32-MPY-Jama/commit/9603f12a1870eee4a723d3d990ca495f267d57e4
:)
—
Reply to this email directly, view it on GitHub
https://github.com/jczic/ESP32-MPY-Jama/issues/33#issuecomment-1492622601,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A56V3ZVBJAUA63CQKURYY53W65DD3ANCNFSM6AAAAAAWOHFRRQ.
You are receiving this because you were mentioned.Message ID:
@.***>


Diff fails with NoMethodError: undefined method '[]' for nil:NilClass when line ending warnings are emitted

Repro case:

Download a repository which contains a file with CRLF endings on an operating system that uses LF endings
Extracting the diff will throw a NoMethodError: undefined method '[]' for nil:NilClass error in method process_full_diff

Example output;
Overriding any local changes to repositories in modules
Not managing Rakefile in puppetlabs-chocolatey
Not managing spec/spec_helper.rb in puppetlabs-chocolatey
Using no-op. Files in puppetlabs-chocolatey may be changed but will not be committed.
Files changed:
Error while updating puppetlabs-chocolatey
bundler: failed to load command: msync (/mnt/c/Source/modulesync_configs/.bundle/bash/ruby/2.3.0/bin/msync)
NoMethodError: undefined method `[]' for nil:NilClass
  /mnt/c/Source/modulesync_configs/.bundle/bash/ruby/2.3.0/gems/git-1.3.0/lib/git/diff.rb:151:in `block in process_full_diff'
  /mnt/c/Source/modulesync_configs/.bundle/bash/ruby/2.3.0/gems/git-1.3.0/lib/git/diff.rb:134:in `each'
  /mnt/c/Source/modulesync_configs/.bundle/bash/ruby/2.3.0/gems/git-1.3.0/lib/git/diff.rb:134:in `process_full_diff'
  /mnt/c/Source/modulesync_configs/.bundle/bash/ruby/2.3.0/gems/git-1.3.0/lib/git/diff.rb:109:in `process_full'
  /mnt/c/Source/modulesync_configs/.bundle/bash/ruby/2.3.0/gems/git-1.3.0/lib/git/diff.rb:68:in `each'
  /mnt/c/Source/modulesync_configs/.bundle/bash/ruby/2.3.0/bundler/gems/modulesync-899483f48304/lib/modulesync/git.rb:162:in `update_noop'
  /mnt/c/Source/modulesync_configs/.bundle/bash/ruby/2.3.0/bundler/gems/modulesync-899483f48304/lib/modulesync.rb:114:in `manage_module'
  /mnt/c/Source/modulesync_configs/.bundle/bash/ruby/2.3.0/bundler/gems/modulesync-899483f48304/lib/modulesync.rb:133:in `block in update'

The reason it fails because the code at; https://github.com/schacon/ruby-git/blob/master/lib/git/diff.rb#L139-L151 expects the first line to contain the filename whereas raw diff comes back as;
warning: CRLF will be replaced by LF in examples/init.pp.
The file will have its original line endings in your working directory.
diff --git a/.gitattributes b/.gitattributes
index 900ea0c..02d4646 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -1,5 +1,5 @@
 #This file is generated by ModuleSync, do not edit.

Suggested fix:
I suggest the line at https://github.com/schacon/ruby-git/blob/master/lib/git/diff.rb#L138 be changed from else to elsif !current_file.nil? so that it won't process diff text until a valid filename is detected

May be related to https://github.com/schacon/ruby-git/issues/326

Given we still have a monkey patch in voxpupuli's modulesync I think this isn't resolved and should be reopened.

Seems to be fixed with PR #405.


Access to the score of the chain?

Hi,
I've seen some cases in which the correference resolution fails, adding a wrong correference and missing the good one. So I wonder if there is any way to access to the score of the coreference resolution and if there are other options for the resolution that maybe are not being chosen as the correct ones by the network but they could be selected with rules.
Thanks.
PD: This is the case in which is failing:
... This seems to be the case for climate change. All of the available evidence shows that it is real, and it has consequences. ...
In this case, it relates the bold it(s) with All and not with climate change.
Best regards

Coreferee is designed as an end-to-end solution that generates internally consistent chains, i.e. a chain may not end up containing two pronouns that cannot possibly agree with each other. It does not attempt to do this for alternative interpretations as this would quickly get unmanageably complicated.
Having said that, you can access alternative interpretations as long as you are happy to process pairs of words rather than chains. Check out the source code, then comment out the code block starting with if not used_in_training in annotation.py. You will find the token._.coref_chains objects now retain a lot of extra information including the scores for alternative interpretations.


Newbie issue -- no map showing..white screen

I am sure this is a general totally newbie question -- but I am using the Example app as a basis for very simple app that shows the current location w/ accuracy (using flutter_location) .. the page is showing with a nice little accuracy indicator .. but.. there is actually no map showing .. that part is empty..
Now to be honest -- I am not sure where even the map data is supposed to be from .. but there are no errors anywhere I can see.. this is on iOS emulator if that makes a difference.. I am getting a valid lat/long and accuracy so that's ok ..
here is (maybe) the relevant code...
Widget _showMap(LocationData location) {
    Widget body;

    body = FlutterMap(
      options: MapOptions(
          center: LatLng(location.latitude, location.longitude), zoom: 16.0),
      layers: [
        TileLayerOptions(
            urlTemplate: 'https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png',
            subdomains: ['a', 'b', 'c']),
        MarkerLayerOptions(
          markers: [
            Marker(
                //marker
                width: 25.0,
                height: 25.0,
                point: LatLng(location.latitude, location.longitude),
                builder: (context) {
                  return Container(
                    child: IconButton(
                      icon: Icon(Icons.my_location),
                      iconSize: 25.0,
                      color: Color(0xff9045f7),
                      onPressed: () {
                        logger.fine('marker tapped');
                      },
                    ),
                  );
                }),
          ],
        ),
        CircleLayerOptions(
          circles: [
            CircleMarker(
              //radius marker
              point: LatLng(location.latitude, location.longitude),
              color: Colors.blue.withOpacity(0.3),
              borderStrokeWidth: 3.0,
              borderColor: Colors.blue,
              useRadiusInMeter: true,
              radius: location.accuracy, //radius
            ),
          ],
        ),
      ],
    );

    return body;
  }

I can also show an image if that is helpful but basically it's a white page with a nice little dot and bullseye thing on the page ..
Any help appreciated ...

Well maybe I just needed more coffee and food because now -- after running the example program and adding just some debug -- the map is showing very nicely .. go figure!  LOL :)


Add log rotation for internal services to prevent out of disk issues

The NSQ Daemon logs very aggressively which can consume many gigabytes of storage and prevent heavy use of a Snowplow Mini server.
These logs should be truncated or rotated regularly to prevent these issues.
After just 2 weeks of running a server 5.5G of logs were present in just the following file:

/var/log/nsqd.err

cc/ @alexanderdean

Ouch! Thanks @jbeemster, scheduling into next milestone.

This can be achieved with logrotate - the following script would set this up for all of the Snowplow apps to keep only 3 hours worth of logs:
# Insert logrotate configuration for Snowplow Services
sudo cat << EOF > /etc/logrotate.d/snowplow-apps
/var/log/snowplow_stream_collector.* /var/log/snowplow_stream_enrich.* /var/log/snowplow_elasticsearch_loader_* /var/log/nsqlookupd.* /var/log/nsqd.* iglu_server_0.2.0.* {
        hourly
        rotate 3
        missingok
        notifempty
        create 644 root root
}
EOF
sudo chmod 644 /etc/logrotate.d/snowplow-apps

# Change logrotate cron to hourly
sudo mv /etc/cron.daily/logrotate /etc/cron.hourly
sudo service cron restart

@oguzhanunlu the above is not tested fully so please do make sure it functions as expected before locking it in.  When I tried to make it work it had some weird side affects like the logs not working properly after rotation so would be good to test it thoroughly!

Sure @jbeemster , thanks for the warning!

As an update to this the approach I took to fix this was much less elegant - it essentially involves tailing the log file to a temporary log file with a certain number of lines and then doing an in-place overwrite.
Neither of these will be necessary as soon as everything is Dockerised though!

I'll start 0.6.0 right after 0.5.0 release and sp mini 0.6.0 includes dockerizing sp mini. I think we should drop this ticket into 0.6.0 to be cancelled after handling docker issue. Working on something that'll be deleted soon sounds inefficient. What do you think @jbeemster ?


WW getLatLonFromXY process one XY

WW function getLatLonFromXY only process one set of coordinate in item[0]. Leaflet and Cesium process all in a loop.

Implemented in branch #306. A test passing in issue 307 also means this issue passes too.

Reintegrate

Merged into the dev branch. closing this issue.


Add Mercury Cryostat PVs (Non-PLC)

Added Mercury Cryostat PVs from various instruments to the PV Import.
These PVs are external (non helium recovery PLC) and are currently configured directly in HLM_PV_Import/external_pvs.py.

Code looks good, what should the acceptance criteria be for testing?


possible to add bars at the end of each error bar?

Thanks for this nice function. It is really practical but i was wondering if it is possible to add the bars at the extreme of the error bars as many other functions and the basic matlab errorbar function do (like http://www.mathworks.com/matlabcentral/mlc-downloads/downloads/submissions/40221/versions/11/screenshot.jpg)

Hi NicolasClairis,
I didn't include the crossing error bars because they are difficult to scale automatically, and I find that in most cases they make my figures look cluttered. Especially when there are lots of points clustered closely together. I suppose we could set them to some multiple size. Do you have a specific application in mind?
Chris


compile failed in ubuntu-18.04

I am trying to use Reflect.h in R (https://github.com/kongdd/hello.R/blob/master/src/test-reflect.cpp). However, failed in ubuntu-18.04.
Any idea how to solve this issue?
https://github.com/kongdd/hello.R/runs/5064647738?check_suite_focus=true
g++ -std=gnu++17 -I"/opt/R/4.1.2/lib/R/include" -DNDEBUG  -I'/home/runner/work/_temp/Library/Rcpp/include' -I'/home/runner/work/_temp/Library/RcppArmadillo/include' -I/usr/local/include  -fopenmp -fpic  -g -O2  -c RcppExports.cpp -o RcppExports.o
g++ -std=gnu++17 -I"/opt/R/4.1.2/lib/R/include" -DNDEBUG  -I'/home/runner/work/_temp/Library/Rcpp/include' -I'/home/runner/work/_temp/Library/RcppArmadillo/include' -I/usr/local/include  -fopenmp -fpic  -g -O2  -c arr3d.cpp -o arr3d.o
g++ -std=gnu++17 -I"/opt/R/4.1.2/lib/R/include" -DNDEBUG  -I'/home/runner/work/_temp/Library/Rcpp/include' -I'/home/runner/work/_temp/Library/RcppArmadillo/include' -I/usr/local/include  -fopenmp -fpic  -g -O2  -c test-reflect.cpp -o test-reflect.o
In file included from test-reflect.cpp:2:0:
test-reflect.cpp:36:5:   in constexpr expansion of ‘ExtendedTypeSupport::TypeName<float>()’
Reflect.h:[92](https://github.com/kongdd/hello.R/runs/5064647738?check_suite_focus=true#step:10:92)5:73: error: the value of ‘__PRETTY_FUNCTION__’ is not usable in a constant expression
     static constexpr auto typeStr = ExtendedTypeSupport::TypeName<Type>(); \
                                                                         ^
Reflect.h:43:17: note: in definition of macro ‘ML_E’
 #define ML_E(x) x
                 ^
Reflect.h:51:23: note: in expansion of macro ‘DESCRIBE_FIELD’
 #define ML_3(f,a,...) f(a) ML_E(ML_2(f,__VA_ARGS__))
                       ^
Reflect.h:46:19: note: in expansion of macro ‘ML_3’
 #define ML_C(x,y) x##y
                   ^
Reflect.h:1[95](https://github.com/kongdd/hello.R/runs/5064647738?check_suite_focus=true#step:10:95):25: note: in expansion of macro ‘ML_N’
 #define FOR_EACH(f,...) ML_N(COUNT_ARGUMENTS(__VA_ARGS__),f,__VA_ARGS__)
                         ^~~~
Reflect.h:957:5: note: in expansion of macro ‘FOR_EACH’
     FOR_EACH(DESCRIBE_FIELD, __VA_ARGS__) \
     ^~~~~~~~
test-reflect.cpp:36:5: note: in expansion of macro ‘REFLECT’
     REFLECT(FuelTank, capacity, currentLevel, tickMarks)
     ^
Reflect.h:592:16: note: ‘__PRETTY_FUNCTION__’ was not declared ‘constexpr’
         view = __PRETTY_FUNCTION__;

PRETTY_FUNCTION not being usable in constexpr is a problem in GCC before version 8.1 or so; if possible, update to a later version of GCC (e.g. I have success on GCC 10.2 https://godbolt.org/z/hK184h but fails with your same error if I select GCC 7.5).
If not possible then note that getTypeView is how RareCpp gets types as strings - you may or may not be able to find an alternative method for getting the type strings in earlier versions of GCC; if you can live without constexpr type names you can replace the #if #else's there with just view = "unknown"; and maybe put some similar non-constexpr logic using PRETTY_FUNCTION in TypeToStr for wherever you need to use it.

Thanks for your quick response. I will have a try.

Thank you. Indeed, Reflect.h works well for GCC higher than version 8.1.
When changed ubuntu v18.04 into v20.04, the error disappears.
https://github.com/kongdd/hello.R/actions/runs/1795099938


it's difficult to select different nodes in the scatter plot when there are too many data points

People tend to select simple numbers such as 1000, 750 or 600 instead of a more specific version like 1131, 753 or 612. Because of this most nodes are clustered together and right now visualized on top of each other and users can only select the foremost node.
One way to fix this issue is to cluster nodes that are close to each other using d3.forceSimulation.

this is resolved by introducing d3 forceSimulation in #14


Meta changes to recent deps/rems articles.

Not merging today, because I'm guessing Pete will have something to say about the placement and appearance of the blurb.
What's changed, or what was fixed?

Added a new blurb to deps/rems that links to a tag page.
Add the blurb to recent relevant articles.
Misc other changes to correct errors I stumbled on and create consistency.

Target Live Date: 2017-12-14

[ ] This has been reviewed and approved by @petele
[x] I have run gulp test locally and all tests pass.
[x] I've staged the site and manually verified that my content displays correctly.

R: @petele

:+1:

@jpmedley ok you ok to fix the issue so we can merge?


OpenMP linkage was broken again

Fixes the link to OpenMP that was broken again by https://github.com/openmopac/mopac/commit/cc58cbf18086233b535a5083687c2e7c1a312c1b.
Closes #76  and #82
Status

[x] Ready for merge

Codecov Report

Merging #85 (3e7917d) into main (992869b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #85   +/-   ##
=======================================
  Coverage   68.26%   68.26%
=======================================
  Files         330      330
  Lines       71696    71696
=======================================
  Hits        48946    48946
  Misses      22750    22750

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992869b...3e7917d. Read the comment docs.

I've reproduced the problem on a Linux system, and I've tweaked your fix to use the OpenMP compiler flag rather than direct calls to libraries. Direct linking of OpenMP can (and has) caused linking of multiple, disjoint OpenMP libraries because the OpenMP detection in find_package(BLAS) is not synchronized with find_package(OpenMP). I think that the compiler flag is more intelligent in avoiding this issue. My previous tweak broke your original flag-based fix because I failed to add the flag at link time (your global change to compiler flags applied both to all targets and at both compile and link times).