Need a plan for reporting Dart crashes

Presumably we could integrate with existing Android Crash reporting:
https://developers.google.com/analytics/devguides/collection/android/v4/exceptions
Unclear what a solution is on iOS?
@johnmccutchan @Hixie

We also need engine crash reporting.

Firebase now has crash reporting: https://firebase.google.com/docs/crash/

Now that we use AOT dart in release mode, this plan is likely the same as #4070, but we will also need to be sure we can explain to devs how to symbolicate AOT dart stack traces?  FYI @zanderso

See also this related Gallery link: https://github.com/flutter/flutter/issues/4070

@eseidelGoogle, FYI I am going to untag this plugin as I don't think this is related to our plugin work.

Support symbols in AOT code: https://github.com/flutter/flutter/issues/7918

Do you mean "reporting a crash from Dart code running in a Flutter app on a device"?
I know @yjbanov is working on crash reporting for the flutter_tool, which I think is separate from this, but just clarifying.

A complete solution for Flutter applications would be something along these lines:

Can report unhandled Dart exceptions and native crashes
Supports iOS and Android
Integrates with a publicly available crash reporting backend (Firebase, Crashlytics, etc)

What I worked on supports unhandled Dart exceptions only and the backend is private. So there's still quite a bit of work to do. I think this issue only calls for writing up a plan. Developing an actual solution would be a bigger project that should probably be broken down into multiple smaller issues.

Assuming the existence of a class with Sender.sendReport method, here is some example code about how to catch Dart exceptions and report them:
void main() {
  FlutterError.onError = (FlutterErrorDetails details) {
    sender.sendReport(
      error: details.exception,
      stackTrace: details.stack,
    );
  };

  runZoned<Null>(() {
    // Errors from this call won't be caught by Flutter
    await server.getData();
    // Errors from MyApp constructor won't be caught by Flutter
    runApp(new MyApp());
  }, onError: (error, stackTrace) {
    sender.sendReport(
      error: error,
      stackTrace: stackTrace,
    );
  });
}

Might be worth noting in a comment above FlutterError.onError that these will be caught by Flutter:
// The following handler will receive errors caught by Flutter
FlutterError.onError = (FlutterErrorDetails details) {
 ...
}

@a-siva believes we have most (if not all) of the needed pieces from the runtime & compiler teams.  My understanding is @yjbanov is working on wiring up crash reporting for crashlytics as we speak, and likely will resolve this through that?

We found our contacts in Crashlytics and we have a meeting scheduled for Wednesday. Hope to kick if off real soon!

Should we de-dupe with https://github.com/flutter/flutter/issues/9592 ?

It's probably going to be hard to cover a complete crash reporting solution with one issue. That said, breaking down the tasks into issues requires some system, so I'm OK with deduping, and if we care to capture sufficient aspects of crash reporting, we could start a GitHub project and log multiple issues there.

@yjbanov What more needs to happen for you to consider this bug closed?

I think we have an 80% solution, so I'm OK with closing and switching to an incremental enhancements mode.
For users who would like to start collecting crash reports from their app now, check out package:sentry.

I think we have an 80% solution, so I'm OK with closing and switching to an incremental enhancements mode.

Where do I find information about the Crashlytics Flutter solution?

@magick93 this issue is about ability to report crashes in general. The Crashlytics issue is tracked here: https://github.com/flutter/flutter/issues/14765.


npm test broken

It seems that having moved the test files into the test directory broke the npm test command.
Moving them back to the root works as a workaround, even though it might be better to make changes to the npm test command and/or to the corresponding files.

Thanks, a PR is welcome here.


operator jaeger (1.46.0)

Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

@mporrato thanks for the heads up!

/merge possible

/merge possible

@iblancasa just waiting for approval from (at least one of) the owners listed in ci.yaml

/merge possible

/merge possible

/merge possible


Dp/allow workflows to specify a single spec path

Happy to merge this in if you wanted?

I intended to merge this into our fork, but that would be great!


Skydns gets kubelet-wrapper's container resolv.conf, not host's

In Kubernetes 1.2, pods only have a single nameserver in /etc/resolv.conf, which points to the kube-dns addon. https://github.com/kubernetes/kubernetes/issues/15592
This is fine, however kube-dns is expected to forward DNS queries for domains it's not authoritative over. This doesn't work perfectly today because the kube-dns pod inherits it's /etc/resolv.conf from the host, which in this case is the kubelet-wrapper container's resolv.conf, so it's getting <IP_ADDRESS> and <IP_ADDRESS> rather than the host's resolv.conf.
This means clusters which have an internal DNS server in their network are unable to resolve internal dns names, as that nameserver is not in skydns' resolv.conf. This is the case for AWS, for example, as every EC2 instance gets it's own hostname, which Amazon resolve for us normally.
The work around is to mount in /etc/resolv.conf into kubelet-wrapper as documented here: https://github.com/coreos/coreos-kubernetes/blob/master/Documentation/kubelet-wrapper.md#use-the-hosts-dns-configuration
I couldn't find any open issues for this specific problem yet, so I'm putting this here for others who run into the issue, and to track the status of this particular behavior.

ref: https://github.com/coreos/bugs/issues/1228

Closed via https://github.com/coreos/coreos-kubernetes/pull/681


How to connect multiple devices and containerization

Hello,
I have two questions:
Firstly;
Can you tell me how can I connect two or more plcs with your software, please?
Let's say I have two devices:
opc.tcp://bla.bla.bla.1
opc.tcp://bla.bla.bla.2
How a config file and measurements look like for this setup?
Secondly,
How can I run your software in Docker?
Thank you,

-> For two devices, simply run the application 2 times with a different config file.
-> For docker, there are multiple ways, but I'd suggest a basic linux imagein which you curl the pre-built binary (release tab) and run it

Would you mind explaining what is curling in the pre-built binary in basic linux image a bit more, please? How I will do it?

I could manage to run this logger in a container. As I still don't know how to run more than one instance in a container with different config.toml files, I cloned my conrainer and run other config.toml through it.
It works like a charm!
I want to ask if and how can I connect OPC-DA clients to this logger.

If you want to connect to an OPC-DA server, you'll need software for the DA to UA translation. You can use for examples Kepware KepserverEX or TaniOPC.

Thank you for your help.


Error Apply-PnPProvisioningTemplate : The specified user c:0-.f|rolemanager|spo-grid-all-users/ could not be found

Install Script not working in our Tenant:
Error Apply-PnPProvisioningTemplate : The specified user c:0-.f|rolemanager|spo-grid-all-users/ could not be found

Hello,
Good catch ! I will have a look ASAP.
Is it so that external sharing is disabled globally on your tenant ?
Regards,
Yannick

Yes, its off by default. Test it to enable on the site. but didnt solve the issue .
Mit freundlichen Grüßen,
Patrick Eisel

From: Yannick Plenevaux<EMAIL_ADDRESS>Sent: Monday, July 6, 2020 9:54:19 PM
To: pnp/sp-site-designs-studio<EMAIL_ADDRESS>Cc: SnappyFPV<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [pnp/sp-site-designs-studio] Error Apply-PnPProvisioningTemplate : The specified user c:0-.f|rolemanager|spo-grid-all-users/ could not be found (#6)
Hello,
Good catch ! I will have a look ASAP.
Is it so that external sharing is disabled globally on your tenant ?
Regards,
Yannick
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pnp/sp-site-designs-studio/issues/6#issuecomment-654434288, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABRS3RKVIANCBYI6OJFGFQLR2ITWXANCNFSM4OR2BAVA.

Hello Patrick,
According to the error message you mention, it looks like your tenant Id is not appended to it.
Could you please try the command "Get-PnPTenantId" and see if it returns something?
I don't see why that wouldn't work, but it's the only reason I can see now why it wouldn't be appended in the provisioning template.
To unblock you, you may probably try replace the $tenantId variable by your actual tenant Id in the following line of the setup.ps1 file
https://github.com/pnp/sp-site-designs-studio/blob/237d28792ff009e48b57794e9bec8a544406de31/setup/PnPPowershell/setup.ps1#L24
You can get to know your tenant Id following that doc
Let me know if that helps ?
BTW, do you use the -useMFA argument of the setup script ?
Regards,
Yannick

Hello Patrick,
According to the error message you mention, it looks like your tenant Id is not appended to it.
Could you please try the command "Get-PnPTenantId" and see if it returns something?

Problem was the MFA ... used a generated APP Password for the Admin Account to connect-pnponline - it works without any issues.

Awesome I will make sure to make it works. At worst suggesting a workaround :)

Closing this one since MFA is no longer supported in setup script.


test: start mailhog before running playwright

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

It's easy to forget that mailhog has to be running for some of the playwright tests to work. With these changes, you don't have to remember.
It doesn't require docker to be installed, but it does mean that either you have docker installed OR you have to start mailhog before running playwright.

--network host wasn't working on Huyen's Mac. The container would start, but the ports were not reachable. However, explicitly opening the ports did the trick.


JSON serialization defaults modify property names

When serializing Payload objects, the default JSON behaviour is to convert from camel case to snake case: https://github.com/dsrees/JavaPhoenixClient/blob/master/src/main/kotlin/org/phoenixframework/Defaults.kt#L52
I presume it was done deliberately for internal reasons, but it is a bit of a surprise.
I don't think this is what the equivalent Javascript library does: https://github.com/phoenixframework/phoenix/blob/master/assets/js/phoenix.js#L648

Ideally I would like to make the parser customizable to the User so you can use any serializer/deserializer you would like and configured in any way

@rawnsley Looking over this again, and you can pass your own Gson instance to your Socket
val myGson = GsonBuilder()
        .setLenient()
        .setFieldNamingPolicy(FieldNamingPolicy.UPPER_CAMEL_CASE)
        .create()

socket = Socket(
        url = "wss://localhost:4000/socket",
        gson = myGson
    )


Hetzner pre-release testing

What this PR does / why we need it:
Hetzner pre-release testing
Does this PR introduce a user-facing change? Then add your Release Note here:

Documentation:

/test pull-kubeone-e2e-hetzner-default-stable-upgrade-containerd-external-from-v1.27.11-to-v1.28.7
/test pull-kubeone-e2e-hetzner-rockylinux-stable-upgrade-containerd-external-from-v1.27.11-to-v1.28.7


merge from konsum-frontend-svelte,template-css,template-svelte-app

package.json

chore(deps): add ^2.9.14 remove ^2.9.13 (devDependencies.vite)

:tada: This PR is included in version 1.32.0 :tada:
The release is available on:

npm package (@latest dist-tag)
v1.32.0
GitHub release

Your semantic-release bot :package::rocket:


Is parameter samples ignored?

It looks like -samples 1000000 or, eg. -samples 100 makes no difference. Shouldn't 1000000 samples take longer than 100?

Ok got it. Looks like you overwrite the value by
samples := getTargetSampleCount(threadCount, samples)

not sure if that makes sense...
Maybe you should allow users to enable and disable this overwrite?
Any I guess samples should be raltive to the object size? It would take quite long to get 100000 32MB objects?
So maybe instead of overwriting it you allow a time based benchmark? so each sample size is running for the same amount of time?


Merge group UI should close after merge

If the group you selected gets merged INTO another group, the window should close, otherwise you get trapped in the admin GUI panel while NPEs spawn on the server.

Included in https://github.com/Civcraft/NameLayer/pull/225


Merge master-2.x commits 2023/06/01~2023/06/30 into main

What changes are proposed in this pull request?
Merge missing commits from master-2.x to main. The commits in 2023/05/01~2023/05/31 from https://github.com/Alluxio/alluxio/compare/main...master-2.x will be included by this PR.
Some commits are skipped because they have been manually ported to main
https://github.com/Alluxio/alluxio/commit/4a57bab5a96ff34f7eaa5eca196157e49d905665
https://github.com/Alluxio/alluxio/commit/a84b6e611b118ef4fb8cd4da00cddf4c995f0def
https://github.com/Alluxio/alluxio/commit/ec066dccaabf44a95c2fffb72cc9c4eadf274bab
This commit https://github.com/Alluxio/alluxio/pull/17717/commits/11af4ee3dc8e0d2cff944254105391321c9d327a is not a cherry-pick but a missed out clean up work for https://github.com/Alluxio/alluxio/pull/17638, where a test should be removed together with the Block API.

alluxio-bot, sync-merge this please


Feature/comments

Description
Comments end point - full CRUD
Type of change
Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)

Change Status

[ ] Complete, tested, ready to review and merge

How Has This Been Tested?

[ ] Test A

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

Looks good. What do you think about adding some validations later


Added the onBlur function.

Triggered by element's onblur event.

Will be covered in v2 work: https://github.com/jaredreich/pell/projects/1#card-8535962


Bug on real time location

If you use actual location (mi ubicación actual in Spanish) all goes OK....BUT if you use "on real time" (en tiempo real) you get this..
year 49122572 is out of range
Traceback (most recent call last):
File "/home/ubuntu/.local/lib/python3.6/site-packages/whalesong/managers/message.py", line 101, in call
return cls.message_classes[t](data=data, *args, **kwargs)
KeyError: 'location'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/ubuntu/.local/lib/python3.6/site-packages/whalesong/driver_firefox.py", line 149, in poll
await self.result_manager.set_partial_result(result['exId'], result['params'])
File "/home/ubuntu/.local/lib/python3.6/site-packages/whalesong/results.py", line 280, in set_partial_result
await cast(BasePartialResult, self._pendant[result_id]).set_partial_result(data)
File "/home/ubuntu/.local/lib/python3.6/site-packages/whalesong/results.py", line 115, in set_partial_result
await self._set_result(self.map(data))
File "/home/ubuntu/.local/lib/python3.6/site-packages/whalesong/results.py", line 47, in map
return self.fn_map(data)
File "/home/ubuntu/.local/lib/python3.6/site-packages/whalesong/managers/init.py", line 161, in
fn_map=lambda evt: cls.MODEL_MANAGER_CLASS.map_model(evt['item'])))
File "/home/ubuntu/.local/lib/python3.6/site-packages/whalesong/managers/init.py", line 93, in map_model
return cls.MODEL_CLASS(data)
File "/home/ubuntu/.local/lib/python3.6/site-packages/whalesong/managers/message.py", line 104, in call
return cls.message_classes[MessageTypes(t)](data=data, *args, **kwargs)
File "/home/ubuntu/.local/lib/python3.6/site-packages/whalesong/managers/message.py", line 90, in call
return super(MessageMetaclass, cls).call(data=data, *args, **kwargs)
File "/home/ubuntu/.local/lib/python3.6/site-packages/dirty_models/models.py", line 182, in init
self.import_data(data)
File "/home/ubuntu/.local/lib/python3.6/site-packages/dirty_models/models.py", line 301, in import_data
self._import_data(data)
File "/home/ubuntu/.local/lib/python3.6/site-packages/dirty_models/models.py", line 308, in _import_data
setattr(self, key, value)
File "/home/ubuntu/.local/lib/python3.6/site-packages/dirty_models/fields.py", line 116, in set
set_value(value)
File "/home/ubuntu/.local/lib/python3.6/site-packages/dirty_models/fields.py", line 112, in set_value
self.set_value(obj, self.use_value(v))
File "/home/ubuntu/.local/lib/python3.6/site-packages/dirty_models/fields.py", line 58, in use_value
return self.convert_value(value)
File "/home/ubuntu/.local/lib/python3.6/site-packages/dirty_models/fields.py", line 152, in inner
return func(self, value)
File "/home/ubuntu/.local/lib/python3.6/site-packages/dirty_models/fields.py", line 567, in convert_value
return datetime.fromtimestamp(value, tz=self.default_timezone)
ValueError: year 49122572 is out of range
Found the error is over   ""sequence = DateTimeField()"" on the 505 lines message.py file, buy as long I dont know what else afect this line I wont make upload the file.

Could you test it?

Working Fine !!!


Research & track reasons for customers not converting

In order to obtain actionable data for improving our documentation, process, and product roadmap we need to determine why customers are failing to convert.
We will obtain this information through #131 and possibly our website analytics. We will device a mechanism for tracking this data over time.

PI8 75% assessment:
WON'T: we do not have enough cases of potential customers entering the pipeline but not converting to prioritize this research during PI8. I think this would make more sense to take on when we have more business.


Fix: The outputs name with symbol - cause render error

Description of your changes

Fixes #2544
I have:

[x] Read and followed KubeVela's contribution process.
[x] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[x] Run make reviewable to ensure this PR is ready for review.
[x] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

/backport 1.1


instagram-scraper 1.5.34 didn't fix a thing!

I just downloaded the new version in hopes it will fix the problems but to my surprise it just did NOTHING! The login is still broken and when I applied @dmoreno1994 login fix it still didn't download pictures and videos from a users page. @rarcega Was that intended? I can't think of any reason why you would choose to commit a 20 day old pull request with meaningless changes and not fix the whole thing?!? You can't even appreciate the changes ...

2018-05-24 13:42:43,337 - instagram_scraper.app - WARNING - Retry after exception HTTPError(u'429 Client Error: - for url: https://www.instagram.com/hm/',) on https://www.instagram.com/hm
2018-05-24 13:42:48,545 - instagram_scraper.app - WARNING - Retry after exception HTTPError(u'429 Client Error: - for url: https://www.instagram.com/hm/',) on https://www.instagram.com/hm
2018-05-24 13:42:58,750 - instagram_scraper.app - WARNING - Retry after exception HTTPError(u'429 Client Error: - for url: https://www.instagram.com/hm/',) on https://www.instagram.com/hm
2018-05-24 13:43:18,921 - instagram_scraper.app - WARNING - Retry after exception HTTPError(u'429 Client Error: - for url: https://www.instagram.com/hm/',) on https://www.instagram.com/hm
2018-05-24 13:43:59,105 - instagram_scraper.app - WARNING - Retry after exception HTTPError(u'429 Client Error: - for url: https://www.instagram.com/hm/',) on https://www.instagram.com/hm

I think the 429 issue is still there, above is from my instagram-scraper.log

I think 429 is just a rate limitation on instagram side because if you wait 15 minutes and retry it works

I don't think OP means the 429 errors. He/she has probably the same issues as I have: With 1.5.34 you can't do a thing because of the cookie error and with the fixes from @dmoreno1994 you at least can login and get the story's of the user but it does not download any pictures!

you need to add the CSRF patch for the login to work because it wasn't merged yet.

No, no, no!!!! You mean this patch here. The other just gives an error! But as I wrote, I already applied the fix so I can login. BUUUUUUUT I can't download the media files! Can you download media files from a user? I really doubt it.  It can't be that @clublek @MintUser34827738947 and me are the only ones ...

I can confirm that the latest version does not solve anything :(

Try the latest build, this was fixed.


python3Packages.astropy: fix build

Motivation for this change
noticed it was failing reviewing another PR
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

https://github.com/NixOS/nixpkgs/pull/104418
6 packages failed to build:
python37Packages.aplpy python37Packages.reproject python37Packages.spectral-cube python38Packages.aplpy python38Packages.reproject python38Packages.spectral-cube

20 packages built:
python37Packages.asdf python37Packages.astropy python37Packages.astropy-healpix python37Packages.astroquery python37Packages.pyavm python37Packages.pyregion python37Packages.pytest-astropy python37Packages.pytest-astropy-header python37Packages.radio_beam python37Packages.sunpy python38Packages.asdf python38Packages.astropy python38Packages.astropy-healpix python38Packages.astroquery python38Packages.pyavm python38Packages.pyregion python38Packages.pytest-astropy python38Packages.pytest-astropy-header python38Packages.radio_beam python38Packages.sunpy

all of the reverse dependencies were previously failing.


Document the default null ordering for ORDER BY

Add documentation for #3218 that the default null ordering for ORDER BY
is NULLS LAST.

Merged, thanks!


fix utility props value type about override the Theme interface

Summary

this PR is fix below issue by add string | number | false into ThemeNamespaceValue (https://github.com/gregberge/xstyled/pull/345/commits/7a430a9fc9b6218cab77cbb8acf437951092ab9a).
Fixes #344
and fix type-errors about theme value types in tests files.
Test plan

npm install in project root
type checking

[x] no errors to run npx tsc --noEmit -p ./packages/system
[x] no errors to run npx tsc --noEmit -p ./packages/styled-components
[x] no errors to run npx tsc --noEmit -p ./packages/emotion

pass the tests (run npm test in project root)

@gregberge
thanks for your review.

Each prop has its own typing, maybe some are missing, but globally it is good.

Indeed, I think it should be safe for Typing to be more accurate and limited. This PR will be closed and I'll reconsider if we can contribute in another way.


Undefined variable: path

When I delete a recording that has several pictures, I have the following message :
Undefined variable: path [ROOT/vendor/davidyell/proffer/src/Model/Behavior/ProfferBehavior.php, line 113]

I have read the code and I saw that at the end of the loop, the variable $path is destroyed
public function afterDelete(Event $event, Entity $entity, ArrayObject $options, ProfferPathInterface $path = null)
    {
        foreach ($this->config() as $field => $settings) {
            $dir = $entity->get($settings['dir']);

            if (!empty($entity) && !empty($dir)) {
                if (!$path) {
                    $path = new ProfferPath($this->_table, $entity, $field, $settings);
                }

                $path->deleteFiles($path->getFolder(), true);
            }

            unset($path);
        }

        return true;
    }

The problem was solved by giving null inftead to unset the variable
$path = null;

Thanks for the bug report and fix.


Support for storing point in geo point field

PR to fix issue referenced: https://github.com/GeneaLabs/nova-map-marker-field/issues/51
Allows the user to select field type (currently only implements 'point')
uses ST_POINTFROMTEXT which should work with MySQL, PostGIS, and other geospatial database engines
Allows the user to set a custom SRID or use a sensible default (4326)

Implemented custom Nova Action Resource Class to manage non-UTF shape data in action_event logging.

@mikebronner Are there any changes you'd like me to make on this PR?

@nshontz Was just waiting for the go-ahead that you were finished. Will review over the weekend. :) Thanks!

@nshontz I'm working through the code changes in your PR. Could you explain why the ActionResource class is necessary?

Laravel Nova logs all of the events in action event, there is an issue when your model contains non-utf8 values, in this case the spatial column.
The ActionResource let's you implement your own ActionEvent which handles the encoding of the model.

@nshontz Thanks for all your work on this PR. Unfortunately it appears to currently only support MySQL. In order to be considered, it will need to support Postgres and SQLite without breaking. (Meaning for SQLite it would need to default to something that won't break, even if it isn't a geospatial field.

Laravel Nova logs all of the events in action event, there is an issue when your model contains non-utf8 values, in this case the spatial column.
The ActionResource let's you implement your own ActionEvent which handles the encoding of the model.

Thanks for the clarification. I didn't realize that the spatial data was not stored in UTF-8 format.

Unfortunately it appears to currently only support MySQL. In order to be considered, it will need to support Postgres and SQLite without breaking.

It should support Postgres (with the PostGIS extension) if you're seeing an error, I can give it a look but the ST_POINTFROMTEXT function is available in PostGIS.
I've not worked with SQLite spatial columns but I will spin something up and get it working.

@nshontz SQLite doesn't support spatial columns that I know of. I think the workaround there would be to store both coordinates separated by a comma in a single field, then parse them out when reading them? What do you think?
Regarding spatial handling in Postgres, I see what you are saying now. I was trying to read up on it, and saw usage of the point() method, without the use of ST_POINTFROMTEXT.

Laravel Nova logs all of the events in action event, there is an issue when your model contains non-utf8 values, in this case the spatial column.
The ActionResource let's you implement your own ActionEvent which handles the encoding of the model.

Is this documented anywhere? I would love to read up on this limitation in Nova. Thanks! :)

SQLite doesn't support spatial columns that I know of. I think the workaround there would be to store both coordinates separated by a comma in a single field, then parse them out when reading them?

I'm hesitant to blend or muddy support between supporting a true geospatial column type for any DB engine that implements the OpenGIS® spec (which this PR aims to do) and simply supporting the ability to support a single column with comma-separated-values, which might be useful but seems separate from this implementation.
So, if SQLite doesn't implement this geospatial standard, I would be hesitant to try and shoehorn faux support for a single column vs separate columns for lat/long.
I will look for some examples/documentation of Nova and UTF8 issues.


Update script.js with better error handling

Description
This update focuses on adding error handling throughout the todo list application to enhance its robustness and user experience. Critical operations such as adding, editing, deleting tasks, local storage interactions, and updating the displayed todo list are now enclosed in try...catch blocks. This ensures the application gracefully handles errors and provides clear feedback to the user.
Additionally, validation checks are included to prevent the creation of tasks without all required fields. The goal is to improve reliability and prevent potential crashes during user interactions.
Type of change
Please delete options that are not relevant.

[ X] Bug fix (non-breaking change)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so that they can be reproduced.
Tests were conducted to verify the functionality of the todo list with the added error handling. The following tests were performed:

[ X] Test A: Add a new task with valid inputs to confirm correct creation and storage.
[ X] Test B: Attempt to add a task with incomplete inputs to ensure validation messages are displayed.
[ X]  Test C: Edit a task and verify that the updates are reflected correctly in the UI and local storage.
[ X]  Test D: Delete a task and check that it is removed from both the UI and local storage.
[ X]  Test E: Simulate a localStorage failure to ensure graceful handling of errors.

Checklist:

[ X] My code follows the style guidelines of this project
[ X] I have performed a self-review of my code
[ X] I have commented my code, particularly in hard-to-understand areas
[ X] I have made corresponding changes to the documentation
[ X] My changes generate no new warnings
[ X] Any dependent changes have been merged and published in downstream modules

Hello, I have raised a new pr with the formatting changes, please look into it and let me know if there's anything else i need to chagne!


[Tests] 100% Tailwindcss coverage

The initial version of this library simply turned off core tailwindcss plugins only enabled ones could compile "as-is" to React Native. This approach was a bit naive and we should be able to more core plugins through a combination of (in order of preference)

Better base theme
Post processing styles
Custom plugins.

This is a little bit of tedious task, but we should be able to write a until test for each Tailwind style to ensure maximum compatibility.
This is a todo list that each section of the tailwind website has both a unit test and an entry in the compatibility document.
This is not a list of what works, rather what has been unit tested and documented
Layout

[x] Aspect Ratio
[x] Container
[x] Columns
[x] Break After
[x] Break Before
[x] Break Inside
[x] Box Decoration Break
[x] Box Sizing
[x] Display
[x] Floats
[x] Clear
[x] Isolation
[x] Object Fit
[x] Object Position
[x] Overflow
[x] Overscroll Behavior
[x] Position
[x] Top / Right / Bottom / Left
[x] Visibility
[x] Z-Index

Flexbox & Grid

[x] Flex Basis
[x] Flex Direction
[x] Flex Wrap
[ ] Flex
[x] Flex Grow
[x] Flex Shrink
[x] Order
[x] Grid Template Columns
[x] Grid Column Start / End
[x] Grid Template Rows
[x] Grid Row Start / End
[x] Grid Auto Flow
[x] Grid Auto Columns
[x] Grid Auto Rows
[x] Gap
[x] Justify Content
[x] Justify Items
[x] Justify Self
[ ] Align Content
[ ] Align Items
[ ] Align Self
[ ] Place Content
[ ] Place Items
[ ] Place Self

Spacing

[ ] Padding
[ ] Margin
[ ] Space Between

Sizing

[ ] Width
[ ] Min-Width
[ ] Max-Width
[ ] Height
[ ] Min-Height
[ ] Max-Height

Typography

[ ] Font Family
[ ] Font Size
[ ] Font Smoothing
[ ] Font Style
[ ] Font Weight
[ ] Font Variant Numeric
[ ] Letter Spacing
[ ] Line Height
[ ] List Style Type
[ ] List Style Position
[ ] Text Align
[ ] Text Color
[ ] Text Decoration
[ ] Text Decoration Color
[ ] Text Decoration Style
[ ] Text Decoration Thickness
[ ] Text Underline Offset
[ ] Text Transform
[ ] Text Overflow
[ ] Text Indent
[ ] Vertical Align
[ ] Whitespace
[ ] Word Break
[ ] Content

Backgrounds

[ ] Background Attachment
[ ] Background Clip
[ ] Background Color
[ ] Background Origin
[ ] Background Position
[ ] Background Repeat
[ ] Background Size
[ ] Background Image
[ ] Gradient Color Stops

Borders

[ ] Border Radius
[ ] Border Width
[ ] Border Color
[ ] Border Style
[ ] Divide Width
[ ] Divide Color
[ ] Divide Style
[ ] Outline Width
[ ] Outline Color
[ ] Outline Style
[ ] Outline Offset
[ ] Ring Width
[ ] Ring Color
[ ] Ring Offset Width
[ ] Ring Offset Color

Effects

[ ] Box Shadow
[ ] Box Shadow Color
[ ] Opacity
[ ] Mix Blend Mode
[ ] Background Blend Mode

Filters

[ ] Blur
[ ] Brightness
[ ] Contrast
[ ] Drop Shadow
[ ] Grayscale
[ ] Hue Rotate
[ ] Invert
[ ] Saturate
[ ] Sepia
[ ] Backdrop Blur
[ ] Backdrop Brightness
[ ] Backdrop Contrast
[ ] Backdrop Grayscale
[ ] Backdrop Hue Rotate
[ ] Backdrop Invert
[ ] Backdrop Opacity
[ ] Backdrop Saturate
[ ] Backdrop Sepia

Tables

[ ] Border Collapse
[ ] Table Layout

Transitions & Animation

[ ] Transition Property
[ ] Transition Duration
[ ] Transition Timing Function
[ ] Transition Delay
[ ] Animation

Transforms

[ ] Scale
[ ] Rotate
[ ] Translate
[ ] Skew
[ ] Transform Origin

Interactivity

[ ] Accent Color
[ ] Appearance
[ ] Cursor
[ ] Caret Color
[ ] Pointer Events
[ ] Resize
[ ] Scroll Behavior
[ ] Scroll Margin
[ ] Scroll Padding
[ ] Scroll Snap Align
[ ] Scroll Snap Stop
[ ] Scroll Snap Type
[ ] Touch Action
[ ] User Select
[ ] Will Change

SVG

[ ] Fill
[ ] Stroke
[ ] Stroke Width

Accessibility

[ ] Screen Readers

how would gap work since RN doesn't have it?

@nandorojo Correct. While RN doesn't support it, RNW does via the new className styling. The plan is to warn the user when they are using a class name not supported by the current platform.
As I'm working through this list I'm also "fixing" styles that can be supported via polyfills or fallbacks. Eg aspectRatio is supported by RN, but other libraries disable it because it's not 100% compatible, but I support it via a small polyfill.
I'm only doing basic polyfills for now, but I've got some more advanced ones planned in the future.

While I don't yet have 100% coverage, its high enough to give me confidence that the things are working as they should. There's still room for a lot of features but they can come with time.


Remove references to create-react-native-app cli

swap refs to crna cli for expo cli
update broken link to crna user guide, point to crna readme
fixes
https://github.com/react-community/create-react-native-app/issues/770

closing if favor of https://github.com/facebook/react-native-website/pull/582


Clean up MapboxToken subscriptions when DistanceRequest unmounts

Problem
As described here, we aren't cleaning up our Onxy.connect subscriptions, App state listener, and timeout from the MapboxToken library when the DistanceRequest component un-mounts. That's a bit of a waste.
Solution
Clean up when the DistanceRequest component un-mounts.

PR is up for this: https://github.com/Expensify/App/pull/25408

Depending on the order of how things get merged...
If https://github.com/Expensify/App/pull/24306 is merged first, then the PR here will need to be updated to tie into the unmount of the DistanceRequest component.
If https://github.com/Expensify/App/pull/25408 is merged first, then https://github.com/Expensify/App/pull/24306 will need to be updated to use Mapbox.stop()

If https://github.com/Expensify/App/pull/25408 is merged first, then https://github.com/Expensify/App/pull/24306 will need to be updated to use Mapbox.stop()

https://github.com/Expensify/App/pull/25408 has been merged first. Updating my PR to use the stop method to cleanup listeners

This is done and all deployed.


FlowRouter.setQueryParams() always causes full route re-render

I'm having an issue:

Give an expressive description of what is went wrong
FlowRouter.setQueryParams() always causes full route re-render
Version of flow-router-extra you're experiencing this issue
3.7.5
Version of Meteor you're experiencing this issue
2.5.5
Browser name and its version (Chrome, Firefox, Safari, etc.)?
Chrome Version 97.0.4692.99 (Official Build) (64-bit)
Platform name and its version (Win, Mac, Linux)?
Windows 10, WSL1

I'm trying to use FlowRouter.setQueryParams() without causing a re-render. I'd simply like my Tracker, which watches the query string via FlowRouter.getQueryParams(), to catch query string updates. Is there a particular pattern or other recommendation for doing this?
I tried throwing my call to FlowRouter.setQueryParams() into a FlowRouter.withReplaceState() callback just for the hell of it but no luck.
Thanks!

Hello @drone1 ,

I'm trying to use FlowRouter.setQueryParams() without causing a re-render

It depends from how you render, can you post your code here?

It will take me some time to get a simple code example to show. For now, if
it's easy can you simply tell me what I would need to do not to re-render
when using FlowRouter.setQueryParams(), if possible? Would appreciate it.
Thanks.
On Tue, Jun 7, 2022 at 2:52 PM dr.dimitru @.***> wrote:

Hello @drone1 https://github.com/drone1 ,
I'm trying to use FlowRouter.setQueryParams() without causing a re-render
It depends from how you render, can you post your code here?
—
Reply to this email directly, view it on GitHub
https://github.com/veliovgroup/flow-router/issues/94#issuecomment-1148626295,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQIEPDPDOW2TLNB4FW2FRLVN5AX3ANCNFSM5NURLVLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Ah OK. I use this.render()!
On Tue, Jun 14, 2022 at 4:46 PM dr.dimitru @.***> wrote:

@drone1 https://github.com/drone1 really would need to know how do you
render it. Do you use this.render() or blaze-renderer package?
—
Reply to this email directly, view it on GitHub
https://github.com/veliovgroup/flow-router/issues/94#issuecomment-1155294440,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQIEPAKKUU2CZ2TKO3WLGDVPCLLDANCNFSM5NURLVLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Just updated and tested. Still re-renders the page. forceReRender is not
set to true, and I believe it defaults to false, so i'm not sure what else
to try. Thanks.
On Tue, Jun 14, 2022 at 4:51 PM dr.dimitru @.***> wrote:

@drone1 https://github.com/drone1 have you updated to the lates
release? Perhaps it was fixed
—
Reply to this email directly, view it on GitHub
https://github.com/veliovgroup/flow-router/issues/94#issuecomment-1155301463,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQIEPFFSWTHSQ6QY7Z5H4LVPCMAJANCNFSM5NURLVLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

We would need a reproduction repo for this one, or at least post router definition

If someone could point me to the documentation for "yield" it would be
greatly appreciated. I can find it explained in the FlowRouter docs,
BlazeJS docs or anywhere else. I also see examples of it used with
Iron:Router which is confusing. Anyone? What exactly implements "yield"?
And what does it do? A link would be grealty appreciated. Thank you!
On Tue, Jun 14, 2022 at 10:01 PM Jon Lippincott @.***>
wrote:

Can you be more specific please? Thank you.
On Tue 14. Jun 2022 at 20:11, dr.dimitru @.***> wrote:

This isn't 100%. You might be able to solve it by using layout template
with {{>yield}}
—
Reply to this email directly, view it on GitHub
https://github.com/veliovgroup/flow-router/issues/94#issuecomment-1155530516,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQIEPHN4SXGMW36MVKGORLVPDDMFANCNFSM5NURLVLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@drone1 flow-router/templating

Thanks, but where is the explanation for exactly what yield does? I can
infer roughly but there is no crisp definition that I can see. Thanks.
On Sat 18. Jun 2022 at 07:15, dr.dimitru @.***> wrote:

@drone1 https://github.com/drone1 flow-router/templating
https://github.com/veliovgroup/flow-router/blob/master/docs/templating.md
—
Reply to this email directly, view it on GitHub
https://github.com/veliovgroup/flow-router/issues/94#issuecomment-1159364839,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQIEPA7IAEHG2FENYKAHJLVPVLQVANCNFSM5NURLVLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

is the explanation for exactly what yield does?

Thank you so much for explaining. Okay, I have clearly been missing out on something critical here. Maybe I missed something but I feel like this could be made much more clear in the documentation? This all seems extremely useful!
I'll be sure to test and let you know how it goes.
By the way, isn't this unreachable code? https://github.com/veliovgroup/flow-router/blob/e2cbb67bf422cde79aade9ebeccbdf768f05fc90/client/renderer.js#L348
And this? https://github.com/veliovgroup/flow-router/blob/e2cbb67bf422cde79aade9ebeccbdf768f05fc90/client/renderer.js#L358
(LMK if you want me to open a separate issue)

Quick question: I'm trying to assess the amount of work this would be to refactor my application to use yield.
Is it possible to yield a child of the layout? Or does it have to be in layout (and not a child of layout)?
I've_ got a main application layout which calls Template.dynamic with another layout. And then the given page is rendered within that.
Can I use yield with this structure, or would I need to refactor? Thank you.

@drone1

this could be made much more clear in the documentation

Sure, feel free to send a PR

By the way, isn't this unreachable code?

Why? Changing object property to read it on the next/other cycle

Is it possible to yield a child of the layout?

you can create empty template, with just {{> yield}}

Or does it have to be in layout (and not a child of layout)?

Since "layout" is template, and "templates" are following HTML tree structure — everything is a "child" of layout

I've_ got a main application layout which calls Template.dynamic with another layout. And then the given page is rendered within that.

Replace Template.dynamic with {{>yield}}
Use .render() passing layout and template names, instead of changing/assigning variable passed to Template.dynamic

Hope that helps

yield helps to render as passthrough data to your template, there are some improvements into rendering process in order to optimize it and avoid re-rendering of entire page the it isn't necessary. Also it cache and reuse previously loaded templates and layouts

What did you mean by avoid re-rendering of the entire page the it isn't necessary? That's what I mean by full re-rendering. :)

I was able to optimize my application by caching results of waitOn(). I will start a new issue if I find something odd, but this made a huge difference. So I'm good for now.
So, back to the topic of this issue. :)
Reproduction code for this issue is in my comment above.
The routing still increases the 'count' every 2 seconds (see setInterval), because calling FlowRouter.setQueryParam() causes the page to re-render.
Would you not expect this? There is nothing reactively getting the query parameter.

Reproduction code for this issue is in my https://github.com/veliovgroup/flow-router/issues/94#issuecomment-1161854792.
The routing still increases the 'count' every 2 seconds (see setInterval), because calling FlowRouter.setQueryParam() causes the page to re-render.

action() hook is expected to run on every URL change

Would you not expect this? There is nothing reactively getting the query parameter.

Black box, there are no details about your template an its structure

was able to optimize my application by caching results of waitOn(). I will start a new issue if I find something odd, but this made a huge difference. So I'm good for now.

You had waitOn and never mentioned it...

action() hook is expected to run on every URL change

So now you literally just answered the initial question: If this.render() is called within action(), FlowRouter.setQueryParams() will cause a page to re-render. Is that correct?

Black box, there are no details about your template an its structure

I don't think we are talking about the same thing here. It's not a black box -- I have included full reproduction source code for you in this thread twice.
waitOn I have in my application, not in the  reproduction code I have included twice pertaining to the specific topic this issue was created for, which is FlowRouter.setQueryParams() causing pages to re-render. Perhaps you can try running the reproduction code and seeing if it's behaving as you might expect. Thanks!

So now you literally just answered the initial question: If this.render() is called within action(), FlowRouter.setQueryParams() will cause a page to re-render. Is that correct?

No, action() hook is always called on URL change

I have included twice pertaining to the specific topic this issue was created for, which is FlowRouter.setQueryParams() causing pages to re-render

Does it mean that if you call .go() method or click a link — there are no re-rendering, is that what you mean?

@drone1
Feel free to close it in case if the issue is solved on your end.

Hello @drone1, have you found a way to solve this on your end?

Closed due to silence at issue owner end.
Feel free to reopen it in case if the issue still persists on your end.

Can you be more specific please? Thank you.
On Tue 14. Jun 2022 at 20:11, dr.dimitru @.***> wrote:

This isn't 100%. You might be able to solve it by using layout template
with {{>yield}}
—
Reply to this email directly, view it on GitHub
https://github.com/veliovgroup/flow-router/issues/94#issuecomment-1155530516,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQIEPHN4SXGMW36MVKGORLVPDDMFANCNFSM5NURLVLQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@drone1 templating docs are self-explanatory

@drone1 I've faced similar issue recently and realized that this statement is only true when data passed to the template not changed:

// without this option template won't be re-rendered
// upon navigation between different "item" routes
// e.g. when navigating from /item/1 to /item/2


Something, probably the latest release, has broken all WEBTOON downloading.

Traceback (most recent call last):   File "webtoon_downloader.py", line 169, in <module>     def get_chapters_details(session: requests.session, viewer_url: str, start_chapter: int = 1, end_chapter: int = None) -> list[ChapterInfo]: TypeError: 'type' object is not subscriptable Traceback (most recent call last):   File "webtoon_downloader.py", line 169, in <module>     def get_chapters_details(session: requests.session, viewer_url: str, start_chapter: int = 1, end_chapter: int = None) -> list[ChapterInfo]: TypeError: 'type' object is not subscriptable
I've made sure the requirements are properly satisfied.

Are you using an older version of Python (i.e Python ≤ 3.6.x)  ?
The project was never meant to support Python 3.6.x though yes the issue can be fixed by removing type hinting of the return function. Not all other functionalities are being tested on this specific version.

It worked fine before the latest release. I'm thinking one of the commits after you fixed the challenge downloading messed it up.

@Corrupt-Specturion Thank you, I've manager to fix it in 6c9d95933642672d3f3845d06bcfdb4a3b553933.
It Should not break now, let me know if all your cases work as intended know using the latest release.

It works fine now, thanks.


[SPARK-45626][SQL] Convert _LEGACY_ERROR_TEMP_1055 to REQUIRES_SINGLE_PART_NAMESPACE

What changes were proposed in this pull request?
The pr aims to convert _LEGACY_ERROR_TEMP_1055 to REQUIRES_SINGLE_PART_NAMESPACE
PS: In addition, the variable name (quoted -> database) was incorrect in the original error class message template, and this issue was resolved in the above convert.
Why are the changes needed?
Fix bug.

Before:

After:

Does this PR introduce any user-facing change?
No.
How was this patch tested?

Pass GA.
Manually test:

./build/sbt "hive/testOnly org.apache.spark.sql.hive.execution.command.CreateNamespaceSuite -- -z \"REQUIRES_SINGLE_PART_NAMESPACE\""

[info] CreateNamespaceSuite:
[info] - CREATE NAMESPACE using Hive V1 catalog V1 command: REQUIRES_SINGLE_PART_NAMESPACE (392 milliseconds)
[info] - CREATE NAMESPACE using Hive V1 catalog V2 command: REQUIRES_SINGLE_PART_NAMESPACE (3 milliseconds)
15:24:14.648 WARN org.apache.hadoop.hive.metastore.ObjectStore: Version information not found in metastore. hive.metastore.schema.verification is not enabled so recording the schema version 2.3.0
15:24:14.648 WARN org.apache.hadoop.hive.metastore.ObjectStore: setMetaStoreSchemaVersion called but recording version is disabled: version = 2.3.0, comment = Set by MetaStore<EMAIL_ADDRESS>15:24:14.654 WARN org.apache.hadoop.hive.metastore.ObjectStore: Failed to get database default, returning NoSuchObjectException
15:24:14.795 WARN org.apache.hadoop.hive.metastore.ObjectStore: Failed to get database global_temp, returning NoSuchObjectException
15:24:15.007 WARN org.apache.hadoop.hive.ql.session.SessionState: METASTORE_FILTER_HOOK will be ignored, since hive.security.authorization.manager is set to instance of HiveAuthorizerFactory.
[info] Run completed in 4 seconds, 819 milliseconds.
[info] Total number of tests run: 2
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 2, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 186 s (03:06), completed Oct 24, 2023, 3:24:15 PM

Was this patch authored or co-authored using generative AI tooling?
No.

Before:

After:

cc @MaxGekk

@panbingkun Could you update PR's description according to the recent changes (screenshot, test example, and so on).

@panbingkun Could you update PR's description according to the recent changes (screenshot, test example, and so on).

@MaxGekk Done.

+1, LGTM. Merging to master.
Thank you, @panbingkun.


Update vendor of buildah and containers/images

Mainly add support for podman build using --overlay mounts.
Updates containers/image also adds better support for new registries.conf
file.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

@mheon @baude @vrothberg @giuseppe @TomSweeneyRedHat PTAL

LGTM, but I don't know enough about the login code to say what's changed - would like someone else to look that over

@mheon This is the same change we made to buildah login.  The interface disappeared since GetAuthentiation returns the same data.

@rh-atomic-bot r=TomSweeneyRedHat

Oh dear - does Homu even work on this repo anymore?
/lgtm

/lgtm

@rhatdan not sure what to do here but maybe repush?

Green button pushed


Enable Deployment of CVM

security_type can be TrustedLaunch or ConfidentialVm.
secure_boot_enabled and v_tpm_enabled can both be True or False.
These values can all be set through the runbook.

Hello @squirrelsc, I have gotten CVM deployment to work. I wanted to sync with you again about design choices.
This enables all three CVM related settings to be set through the runbook. I tried to leave the functionality of the existing security_profile feature intact. I was not sure how to best handle when runbook settings and testcase settings conflict. As written, the runbook settings will overwrite any testcase settings for security_profile.

Hello @squirrelsc, I have gotten CVM deployment to work. I wanted to sync with you again about design choices. This enables all three CVM related settings to be set through the runbook. I tried to leave the functionality of the existing security_profile feature intact. I was not sure how to best handle when runbook settings and testcase settings conflict. As written, the runbook settings will overwrite any testcase settings for security_profile.

Overall, it's ok to me, except use less parameters. I think there is no test case conflict, because the secure_boot should be included in CVM. The parameter can be a NodeSpace, so the test case level can set it to secure boot or CVM. So the test case can be run on both settings.

@squirrelsc I don't think this is quite right yet. I'd like your input on what I have so far. Thank you :)


Provide a way to customize markup text

We need a way to build our own markup text because we'll need to recognize those markups in the flutter_parsed_text widget.

I could think of two ways to this the first way is to provide a function something like this:
markupBuilder({String trigger, String mention, String: value}) String;

or maybe a simple string that needs to have some keywords which I can then replace with their respective values in FlutterMentions
Something like this for this, where [trigger] will get replaced by the current mention trigger & so on:
makup: '[trigger][mention][value]'

Personally, I prefer the first one, too.
But I think if you can achieve both ways, you could set a priority orders for these.


Adding Decent-Partners

Description

It is a duplicate of that PR:
https://github.com/nova-wallet/opengov-delegate-registry/pull/24
Checklist

[x] Image was added in opengov-delegate-registry/images/{meaningful_name}.png
[x] Submit an on-chain transaction using the system.remark extrinsic type, and attach a link to it in your PR

https://kusama.subscan.io/extrinsic/17055140-2

@monsieurbulb
is everything correct?


Better delegation reporiting - impl

…ns discovered
Issue Number

#1312
Overview

[x] I have extended DB layer to obtain the latest two delegation discovered (slot id and potential pool id)
[x] I have added wallet function that retrieves last 2 delegations discovered
[x] I have added Api.Server logic function that basing on current epoch and last two delegation certificates determine what to report in delegation value of ApiWallet
[x] I have adjusted all integration tests affected
[x] I have added integration tests showing the cases to be covered in task description
[x] I have updated all things that needs to be fixed for this change : use of new ApiWalletDelegation as delegation type

Comments

bors try

bors try

bors try

bors try

@Anviking according to ADP-111 specification we have :
The wallet engine must only report a wallet as being delegated when it actively IS (i.e. after the 2 epochs grace period upon discovering a delegation certificate).

I included this requirement in #1312 description of the expectations what happens when we discover delegation certificate throughout the time (counting epochs)

bors try

bors r+


Fixed #10 "Error with Symfony 2.6"

Hi,
This is my proposed patch for #10
I loosen the validation rules to all allowed types, not only array, so no BC-break while it works with 2.6+

:beers: !

Thanks :)
Could you please consider tagging 0.1.2?

Done : )

Perfect :beers:


Edit Playlists

As a user, I want to create, edit, and delete playlists (looping sequences of signs).
A playlists consist of:

Plaintext title
0 to n signs in a specific order

Close as done.


Adding a "Native" option to newline_style.

By using it one will get \r\n line endings on Windows, and \n line endings on other platforms. This is the ideal case when using git's autocrlf option.

Somewhat related to #42.

This looks good, thanks!


Add a procedure for performing validation check on LEGO models

For background see: https://docs.google.com/document/d/1y-6to0vwEJHc3i3wdPnJoCAq910auPQp5jBvafpJvL0/edit#heading=h.tfapoit3wtla
A procedure will run on each model in the repo. The general query will be
?x Type <MechCls> & NOT (?x Type <Foo>)

(note the NOT is interpreted using the CWA)
The GO IDs for these will be provided by @dosumis and @cmungall - the intent is to find individuals that have a mechanism type but not a 'true function' type.
The procedure could be part of a fairly generic mechanism parameterized by queries.
cc @PaulDThomas (I think I have his GH name correct...)

Long-medium term plan: load all models into SciGraph, implement checks as cypher queries, or gremlin scripts

Replaced by #40


Issue 47750: LKSM auto-link to study ignores aliquots

Rationale

Related Pull Requests

Changes

include aliquot parent check for derivatives

targeting 23.3 https://github.com/LabKey/platform/pull/4332


Change environment variable names for consistency

To keep GenevaERS variable names from collisions with other user variable names, please change the following:
OLD NEW
SPECFILELIST  GERS_TEST_SPEC_FILE_LIST
TEST_HLQ       GERS_TEST_HLQ
PMHLQ           GERS_ENV_HLQ
DBSDSNL        GERS_DB2_LOAD_LIB
DBSDSNE        GERS_DB2_EXIT_LIB
DBRUNLD       GERS_DB2_RUN_LIB
DBSUB            GERS_DB2_SUBSYSTEM
DBTIADP         GERS_DB2_UTILITY

This has been done and committed to the int branch.

Please replace GERS_JARS with these more specific variables:
- GERS_DB2_JAR_DIR
- GERS_SDSF_JAR_DIR
- GERS_JZOS_JAR_DIR

Randall do we still need this?


Merge revision into develop

Conflicts fixed in:

docs/reference/menu.md
docs/reference/change-log.md
docs/reference/change-log-r2020.md renamed to changelog-r2020.md

AssertionError: False is not true : Wrong header in file: "/home/travis/build/omichel/webots/projects/robots/dji/mavic/protos/Mavic2Pro.proto"

This failure should already have been raised in the previous merge #715

👍


Add tests about user preferences

This issue to write tests of the code changes made in #1024. I'll write some example tests first, after which @brontolosone can add more tests.

@lognaturel suggested that it's probably most efficient for me to go ahead and write these tests, which I'm happy to do. I'll go ahead and unassign @brontolosone. I've also bumped this issue to the next release cycle.


Transform text to Markdown links by pasting

I did a brief searching and didn't find this request, so here I am.
Many text editors supports transforming text to Markdown links by pasting, for example, if I select GitHub and paste https://github.com, it becomes [GitHub](https://github.com).
This can already achieved by pressing ctrl/cmd + k then pasting, but it can be a nice addition to one-key-formatting (or its own feature).

Not a bad idea, GitHub already seems to do it in a few cases, for example when you copy an image from internet and paste it, it will automatically generate the right markdown code.
The problem for us is that to do this we need access to the clipboard, which means adding an extra "This extension will be able to read your clipboard" permission, which is pretty scary.

The problem for us is that to do this we need access to the clipboard, which means adding an extra "This extension will be able to read your clipboard" permission, which is pretty scary.

I see some applications (for example Notion) achieves this without asking clipboard permission. Is this because they have control of the text field or some magic? Are browser extensions limited to use those methods?

Are browser extensions limited to use those methods?

We had some limitations that required us to use clipboardWrite at some point but they were lifted because we no longer have that permission. It might be worth a try, but then we still have another problem: GitHub already handles some pastes, so we need to make sure we don't override them. For example:

Right-click on this image
Click "Copy image"
Paste into a field, you will already get markdown

I’m a bit conflicted on this one. It seems to make sense and not require a markdown parser to get this right, but also the same is achievable with a single additional key press:
+ ctrl k
  ctrl v

I guess that if using paste event, it does not need edit programtically

Rereading this thread, I think it’s not worth the many “just one problem”

@KSH-code

To override the default behavior (for example to insert some different data or a transformation of the clipboard contents) an event handler must cancel the default action using event.preventDefault(), and then insert its desired data manually.

Thanks for my misunderstanding to be corrected.

Done: https://github.blog/changelog/2021-11-10-linkify-selected-text-on-url-paste/

THAT'S ILLEGAL

As I has previously suggested, this is possibly the most annoying "feature" GitHub implemented EVER and I honestly want to break it. Absolutely awful. I can't paste anything normally in the text box anymore.


Save less

this finishes the work started here https://github.com/zingolabs/zingolib/pull/655

fixes https://github.com/zingolabs/zingolib/issues/572


[Feature] Enchantment-Descriptions support for enchantments added by this mod.

This would make for a nice QoL addition.
Enchantment-Descriptions
It looks for these localization keys:
enchantment.travel_anchors.teleportation.desc
enchantment.travel_anchors.range.desc

added


redocly: 1.14.0 -> 1.15.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/redocly/versions.
meta.description for redocly is: Makes OpenAPI easy. Lint/validate to any standard, generate beautiful docs, and more
meta.homepage for redocly is: https://github.com/Redocly/redocly-cli
Updates performed

NPM version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.15.0 with grep in /nix/store/gkcfa9v9n41f7yap7nl5yavbr8f5pjc1-redocly-1.15.0
found 1.15.0 in filename of file in /nix/store/gkcfa9v9n41f7yap7nl5yavbr8f5pjc1-redocly-1.15.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

redocly

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gkcfa9v9n41f7yap7nl5yavbr8f5pjc1-redocly-1.15.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A redocly https://github.com/r-ryantm/nixpkgs/archive/9a9b952d3d5f027bed8070b18a424ccfe2e9781f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/9a9b952d3d5f027bed8070b18a424ccfe2e9781f#redocly

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gkcfa9v9n41f7yap7nl5yavbr8f5pjc1-redocly-1.15.0
ls -la /nix/store/gkcfa9v9n41f7yap7nl5yavbr8f5pjc1-redocly-1.15.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

redocly

Maintainer pings
cc @szlend for testing.

@NixOS/nixpkgs-merge-bot merge


No namespace for JwtSecurity

I just downloaded the project and tried to simply build the project and I am getting missing references for
JwtSecurityToken
JwtSecurityTokenHandler
Let me know how to fix this.

There was a missing Nuget package reference.  Thanks for pointing this out.  Let us know if you run into any future issues.

Yep I just figured it out myself.  Thanks


"unlocked_by" must not be null for non-core exercises

@exercism/ecmascripts correct me if I'm wrong here, but my understanding of the new setup is that exercises should either be core: true or have a non-null unlocked_by value.
If I am right, then we have 6 exercises currently that are core: false and unlocked_by: null that we need to assign unlocked_by parents to.
?
I am going to enter the same issue for JavaScript.

@rchavarria thanks for your feedback on this.  I'm going to close it for now.


Set Password is visible in cookies and is in plaintext

Environment
Docker
Version
v0.10.5
Describe the problem
Step to repro:

Install Homarr with password.
Open webapp page and inspect element.
Go to storage -> cookes
Cookie name "password" have set password in plaintext.

Why we should not store plaintext password in cookies -  https://stackoverflow.com/questions/2100356/is-it-secure-to-store-passwords-in-cookies
Additional info
No response
Please tick the boxes

[X] You've read the docs
[X] You've checked for duplicate issues
[X] You've tried to debug yourself

Hello @pratimes ,
thank you for your request.
Storing any secret in cookies is indeed bad practice.
The reason why Homarr is doing this is technical debt.
@ajnart I think we should give this quite high priority.
What do you think?

I noticed this too, which is a very bad practice. I've switched to basic auth on my proxy for tad enhanced security.

Maybe using bcrypt will be easy to implement, storing a hashed password to cookies instead of plain text and check for match on login.
cryptr is also easy to use and lightweight but require a secret key to encrypt / decrypt

I would like to provide an update here.
We will use bcrypt, as it currently considered as a safe algorithm and can easily be implemented.
However, we will not modify the current cookie logic, as we're currently completely overhauling the authentication system.
In the future, JWTs with expiration and renewal will be used.
This is most considered to be state of the art.
On the beta branches, you can already see a few of those changes.
However, this is not even close to functional yet (authentication works but the logic behind dashboards is heavily being modified).
We are aware, that Homarr's biggest weakness may be it's security.
The next big release, that will contain most changes from beta, will change that.
Does this clear up the situation a bit?

I'd like to add my 2cents here. I've been working on some authentication solutions and JWTs aren't that safe as they might seem.
If the plan is to write a lot of custom code to manage all the issues that come with JWTs (like token invalidation in case of stolen credentials or tokens), then you should go for it; otherwise the current state of the art still remains cookies with server-side data storage.

We use server side sessions. The next release will contain that.


Expose block keys to block renderers

This pull request exposes the block key to the block renderer function. The use case is rendering a changing draft-js ContentState to React elements with consistent keys throughout re-renders.

I'm mindful of the API for blockRendererFn growing from (children, depth) to (children, depth, key). I'm not sure how to work around this other than pass a object through to allow for future expansion (children, depth, { key }) to possibly allow for block metadata or other things in future. Then again, adding block metadata to the draft-js API might come in a new major version.

Also, a bonus typo fix.

Thanks for another PR 👍 This look's nice and passing the key's is good idea. But in this case for blocks of same type if they are grouped you only get access to the last key.
Maybe we could pass an array of keys matching the blocks by their index? You could then access them individually when mapping children to something like a list item component, or just join them to get a single key that's unique to all the child blocks.
As for the API I'm not 100% sure. Technically both draf-js and redraft are not stable so api changes should't be that much of an issue, but maybe using something that's a bit more flexible would be a better idea.
Love those typo fixes. 😄

Good point — in terms of re-using the block group's element:

using the last block's key: the group element is re-used for edits until you add a block to the end of the group
using the first block's key: the group element is re-used for edits until the first block changes (more re-use in our use case)
as an array: using key={ keys.join(',') } would re-create the element group on every block addition or removal which I think is undesirable — but it does allow us to specify keys[0] for our use case and the flexibility for others to choose the one which supports their use case.

I think being opinionated would be better (I don't think a redraft renderer should concern themselves with what the underlying block key is) but thinking it through, it should be the first block's key. Regardless, I'm happy to change it to an array — let me know and I'll fix up the PR tomorrow.

I'd go with arrays as there are some use cases i could think of for using all the keys, like lists.

Right, absolutely. I'll put it together now :)

Also it's worth noting, if you insert a block (press enter) at the start of the editor, it'll re-use the first block's key and generate a new key for the original block which is now in the second position

Thanks again for this, i think it's a really nice feature.


Added Titaniam partner assets

Description
Add Titaniam logo and website link to opensearch partners page
Issues Resolved
None
By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

This looks great, thanks @makarthikeyan1!


Adding a license

The repo needs consent from all contributors to change the license. The proposal is for licensing the website under the MIT license.

[x] @egladman
[x] @oslerw
[x] @benlk
[x] @bsilvereagle
[x] @Nefari0uss
[x] @afuhrtrumpet
[x] @paradigm
[x] @J3RN
[x] @moore3071
[ ] @deadant2
[ ] @jib5920
[ ] @ryanconnorh0

I'm in favor. MIT is my go-to.

I'm on board, but we may already implicitly have everyone's consent since bower.json says this project is MIT? In any case, we need an explicit LICENSE file.

Technically, the MIT license says:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

So uh... You may have been in violation of your own license the whole time?

hm, @oslerw, so should we wait for full consent from participants due to that technicality?

@J3RN brings up a really good point. We should make sure we have everyones explicit permission, THEN add a LICENSE file.

MIT works with me, but I think I'm late to the party.

Consent is still appreciated as far as legality goes.

Bueracracy exists for a reason. The license just added to this repo is invalid. Get permission or remove unapproved content. We're the OPEN SOURCE club, there is no excuse for us to get licensing wrong, this is a very well defined situation legally with plenty of precedent that says we need approval from contributors. Please do not close this issue until that happens or offending commits are removed.

I'm voting for the MIT license.

It was a hindsight on my part for not including the license during the projects initial creation. It was always my intention to license the project under the MIT License. I just forgot. We should notmake a big deal of this. If I remembered to license this back in September we wouldn't be having this conversation right now.
Three of those 'contributors' are inactive accounts, that are only listed as contributors because they happened to be members of the initial CWDG team. Even if we were to get in touch with them, they shouldn't have a say in the matter.

Feel free to remove accounts that did not contribute any code or content to the repository. But if there is even a single byte of contribution from someone, we need their permission. Even if it was intended to be MIT in the first place, the lack of LICENSE file or headers means that it never actually was, so this is essentially a license change. I'm not trying to make this needlessly dramatic, but license changes are something you have to make sure you get right because getting this wrong can get our repo taken down. We only need 3 more people to consent by the looks of it, so its not like there's a lot left for us to do besides get in contact and wait.

I vote for MIT license. Yay.

I'm in favor.

It looks to me like the three people that were crossed out do indeed have bytes in the code.

@bsilvereagle Thanks, checklist updated to restore them. That puts us 4 people away.

No objection here, licensing to MIT is fine with me.

Since Eli did essentially a reboot in ad4da552372279b2fc86c0f9405e9988c0d3f0bd we can rebase and remove the code from two of those people. I'd have to first figure out how to do that, and then it looks like one of the files is still tied to a commit by Ryan.

@oslerw update?

Any updates?

It's almost been two weeks since I last inquired. What's the hold up?

In order to get around the contributions made by the members we can't contact, we are going to most likely need to edit history (scary times) to get rid of their contributions so we can license the site. This might not happen until the summer when everyone has more time.

@moore3071 and I came up with a potential resolution. Instead of licensing the entire repo we put a clause in the license saying the license begins at ea798362fa80ea5597a72e1e3b232c4c4ce1d50a. This is easier than rebasing commits.

Code newer than ea79836 is now licensed under the MIT license. If @deadant2, @jib5920, @ryanconnorh0 do end up seeing this, please comment and let us know if we can go ahead and get this whole repo licensed. For now though, I'll close this issue.


No source in getSleepSamples result objects

Solution to follow

@dmatora Have you found a resolution for this? I'm seeing the same issue.

@dmatora Have you found a resolution for this? I'm seeing the same issue.
Yes and I've posted it right before your question


Java methods that were supposed to stay the same are removed after Generated output

The class methods are removed. thereby removing the business logic of the class. I can see that the comment states // ... (rest of the class remains the same) however the patch removes the methods.
[models]
provider = "ChatBedrock"
[models.args]
model_id = "meta.llama3-70b-instruct-v1:0"
Generating the fix:
Appname Name: cargotracker.
Incidents: [
  {
    "ruleset_name": "quarkus/springboot",
    "ruleset_description": "This ruleset gives hints to migrate from SpringBoot devtools to Quarkus",
    "violation_name": "ee-to-quarkus-00000",
    "violation_description": "@Stateless annotation must be replaced",
    "uri": "/Users/sshaaf/git/kai-tests/cargotracker/src/main/java/org/eclipse/cargotracker/application/internal/DefaultBookingService.java",
    "message": "Stateless EJBs can be converted to a CDI bean by replacing the `@Stateless` annotation with a scope eg `@ApplicationScoped`"
  },
  {
    "ruleset_name": "quarkus/springboot",
    "ruleset_description": "This ruleset gives hints to migrate from SpringBoot devtools to Quarkus",
    "violation_name": "jakarta-cdi-to-quarkus-00050",
    "violation_description": "Stateless annotation can be replaced with scope",
    "uri": "/Users/sshaaf/git/kai-tests/cargotracker/src/main/java/org/eclipse/cargotracker/application/internal/DefaultBookingService.java",
    "message": "The Stateless EJBs can be converted to a cdi bean by replacing the `@Stateless` annotation with a scope eg `@ApplicationScoped`"
  }
]
---- Total Reasoning: ----
 To migrate the `DefaultBookingService` class to Quarkus, we need to address the issues related to the `@Stateless` annotation. Since Quarkus uses CDI (Contexts and Dependency Injection) instead of EJBs, we need to replace the `@Stateless` annotation with a CDI scope annotation.

In this case, we can replace `@Stateless` with `@ApplicationScoped`, which is a CDI scope that allows the bean to be instantiated once and shared across the application.

We don't need to make any changes to the imports, as the `jakarta.inject.Inject` annotation is already used, which is compatible with CDI.

---- Used Prompts: ----
I will give you a JavaEE file for which I want to take one step towards migrating to Quarkus.

I will provide you with static source code analysis information highlighting an issue which needs to be addressed.

I will also provide you with an example of how a similar issue was solved in the past via a solved example.

You can refer to the solved example for a pattern of how to update the input Java EE file to Quarkus.

Fix only the problem described. Other problems will be solved in subsequent steps so it is unnecessary to handle them now.

Before attempting to migrate the code to Quarkus reason through what changes are required and why.

Pay attention to changes you make and impacts to external dependencies in the pom.xml as well as changes to imports we need to consider.

Remember when updating or adding annotations that the class must be imported.

As you make changes that impact the pom.xml or imports, be sure you explain what needs to be updated.

After you have shared your step by step thinking, provide a full output of the updated file.

# Input information

## Input File

File name: "src/main/java/org/eclipse/cargotracker/application/internal/DefaultBookingService.java"
Source file contents:
```java
package org.eclipse.cargotracker.application.internal;

import java.time.LocalDate;
import java.util.Collections;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;
import jakarta.ejb.Stateless;
import jakarta.inject.Inject;
import org.eclipse.cargotracker.application.BookingService;
import org.eclipse.cargotracker.domain.model.cargo.Cargo;
import org.eclipse.cargotracker.domain.model.cargo.CargoRepository;
import org.eclipse.cargotracker.domain.model.cargo.Itinerary;
import org.eclipse.cargotracker.domain.model.cargo.RouteSpecification;
import org.eclipse.cargotracker.domain.model.cargo.TrackingId;
import org.eclipse.cargotracker.domain.model.location.Location;
import org.eclipse.cargotracker.domain.model.location.LocationRepository;
import org.eclipse.cargotracker.domain.model.location.UnLocode;
import org.eclipse.cargotracker.domain.service.RoutingService;

@Stateless
public class DefaultBookingService implements BookingService {

  @Inject private CargoRepository cargoRepository;
  @Inject private LocationRepository locationRepository;
  @Inject private RoutingService routingService;
  @Inject private Logger logger;

  @Override
  public TrackingId bookNewCargo(
      UnLocode originUnLocode, UnLocode destinationUnLocode, LocalDate arrivalDeadline) {
    TrackingId trackingId = cargoRepository.nextTrackingId();
    Location origin = locationRepository.find(originUnLocode);
    Location destination = locationRepository.find(destinationUnLocode);
    RouteSpecification routeSpecification =
        new RouteSpecification(origin, destination, arrivalDeadline);

    Cargo cargo = new Cargo(trackingId, routeSpecification);

    cargoRepository.store(cargo);
    logger.log(
        Level.INFO, "Booked new cargo with tracking ID {0}", cargo.getTrackingId().getIdString());

    return cargo.getTrackingId();
  }

  @Override
  public List<Itinerary> requestPossibleRoutesForCargo(TrackingId trackingId) {
    Cargo cargo = cargoRepository.find(trackingId);

    if (cargo == null) {
      return Collections.emptyList();
    }

    return routingService.fetchRoutesForSpecification(cargo.getRouteSpecification());
  }

  @Override
  public void assignCargoToRoute(Itinerary itinerary, TrackingId trackingId) {
    Cargo cargo = cargoRepository.find(trackingId);

    cargo.assignToRoute(itinerary);
    cargoRepository.store(cargo);

    logger.log(Level.INFO, "Assigned cargo {0} to new route", trackingId);
  }

  @Override
  public void changeDestination(TrackingId trackingId, UnLocode unLocode) {
    Cargo cargo = cargoRepository.find(trackingId);
    Location newDestination = locationRepository.find(unLocode);

    RouteSpecification routeSpecification =
        new RouteSpecification(
            cargo.getOrigin(), newDestination, cargo.getRouteSpecification().getArrivalDeadline());
    cargo.specifyNewRoute(routeSpecification);

    cargoRepository.store(cargo);

    logger.log(
        Level.INFO,
        "Changed destination for cargo {0} to {1}",
        new Object[] {trackingId, routeSpecification.getDestination()});
  }

  @Override
  public void changeDeadline(TrackingId trackingId, LocalDate newDeadline) {
    Cargo cargo = cargoRepository.find(trackingId);

    RouteSpecification routeSpecification =
        new RouteSpecification(
            cargo.getOrigin(), cargo.getRouteSpecification().getDestination(), newDeadline);
    cargo.specifyNewRoute(routeSpecification);

    cargoRepository.store(cargo);

    logger.log(
        Level.INFO,
        "Changed deadline for cargo {0} to {1}",
        new Object[] {trackingId, newDeadline});
  }
}

Issues
incident 0
incident to fix: "Stateless EJBs can be converted to a CDI bean by replacing the @Stateless annotation with a scope eg @ApplicationScoped"
Line number: -1
incident 1
incident to fix: "The Stateless EJBs can be converted to a cdi bean by replacing the @Stateless annotation with a scope eg @ApplicationScoped"
Line number: -1
Output Instructions
Structure your output in Markdown format such as:
Reasoning
Write the step by step reasoning in this markdown section. If you are unsure of a step or reasoning, clearly state you are unsure and why.
Updated File
// Write the updated file for Quarkus in this section. If the file should be removed, make the content of the updated file a comment explaining it should be removed.

Additional Information (optional)
If you have any additional details or steps that need to be performed, put it here.
---- Model Id: ----
meta.llama3-70b-instruct-v1:0
---- Additional Infomation: ----
(optional)
Note that we need to add the javax.enterprise.context.ApplicationScoped import to use the @ApplicationScoped annotation.
---- LLM Result: ----
Reasoning
To migrate the DefaultBookingService class to Quarkus, we need to address the issues related to the @Stateless annotation. Since Quarkus uses CDI (Contexts and Dependency Injection) instead of EJBs, we need to replace the @Stateless annotation with a CDI scope annotation.
In this case, we can replace @Stateless with @ApplicationScoped, which is a CDI scope that allows the bean to be instantiated once and shared across the application.
We don't need to make any changes to the imports, as the jakarta.inject.Inject annotation is already used, which is compatible with CDI.
Updated File
package org.eclipse.cargotracker.application.internal;

import java.time.LocalDate;
import java.util.Collections;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;
import jakarta.inject.Inject;
import javax.enterprise.context.ApplicationScoped;
import org.eclipse.cargotracker.application.BookingService;
import org.eclipse.cargotracker.domain.model.cargo.Cargo;
import org.eclipse.cargotracker.domain.model.cargo.CargoRepository;
import org.eclipse.cargotracker.domain.model.cargo.Itinerary;
import org.eclipse.cargotracker.domain.model.cargo.RouteSpecification;
import org.eclipse.cargotracker.domain.model.cargo.TrackingId;
import org.eclipse.cargotracker.domain.model.location.Location;
import org.eclipse.cargotracker.domain.model.location.LocationRepository;
import org.eclipse.cargotracker.domain.model.location.UnLocode;
import org.eclipse.cargotracker.domain.service.RoutingService;

@ApplicationScoped
public class DefaultBookingService implements BookingService {

  @Inject private CargoRepository cargoRepository;
  @Inject private LocationRepository locationRepository;
  @Inject private RoutingService routingService;
  @Inject private Logger logger;

  // ... (rest of the class remains the same)
}

Additional Information (optional)
Note that we need to add the javax.enterprise.context.ApplicationScoped import to use the @ApplicationScoped annotation.
---- Updated File: ----
package org.eclipse.cargotracker.application.internal;
import java.time.LocalDate;
import java.util.Collections;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;
import jakarta.inject.Inject;
import javax.enterprise.context.ApplicationScoped;
import org.eclipse.cargotracker.application.BookingService;
import org.eclipse.cargotracker.domain.model.cargo.Cargo;
import org.eclipse.cargotracker.domain.model.cargo.CargoRepository;
import org.eclipse.cargotracker.domain.model.cargo.Itinerary;
import org.eclipse.cargotracker.domain.model.cargo.RouteSpecification;
import org.eclipse.cargotracker.domain.model.cargo.TrackingId;
import org.eclipse.cargotracker.domain.model.location.Location;
import org.eclipse.cargotracker.domain.model.location.LocationRepository;
import org.eclipse.cargotracker.domain.model.location.UnLocode;
import org.eclipse.cargotracker.domain.service.RoutingService;
@ApplicationScoped
public class DefaultBookingService implements BookingService {
@Inject private CargoRepository cargoRepository;
@Inject private LocationRepository locationRepository;
@Inject private RoutingService routingService;
@Inject private Logger logger;
// ... (rest of the class remains the same)
}
Temp Filename: Kai-fix-All-DefaultBookingService.java.

Here is another example,
As you can see it takes away all the methods but the class is still valid as it adds the closing brace in the end.
I also see this in the server debug log
DEBUG - 2024-09-26 19:44:33,112 - kai.models.file_solution - [    file_solution.py:92   - parse_file_solution_content()] - Found single codeblock
package org.eclipse.cargotracker.domain.model.cargo;

import java.io.Serializable;
import jakarta.persistence.Embedded;
import jakarta.persistence.Entity;
import jakarta.persistence.GeneratedValue;
import jakarta.persistence.GenerationType;
import jakarta.persistence.Id;
import jakarta.persistence.JoinColumn;
import jakarta.persistence.ManyToOne;
import jakarta.persistence.NamedQuery;
import jakarta.persistence.SequenceGenerator;
import jakarta.validation.constraints.NotNull;
import org.apache.commons.lang3.Validate;
import org.eclipse.cargotracker.domain.model.handling.HandlingEvent;
import org.eclipse.cargotracker.domain.model.handling.HandlingHistory;
import org.eclipse.cargotracker.domain.model.location.Location;
import org.eclipse.cargotracker.domain.model.shared.DomainObjectUtils;

@Entity
@NamedQuery(name = "Cargo.findAll", query = "Select c from Cargo c")
@NamedQuery(
    name = "Cargo.findByTrackingId",
    query = "Select c from Cargo c where c.trackingId = :trackingId")
public class Cargo implements Serializable {

  private static final long serialVersionUID = 1L;

  @Id
  @SequenceGenerator(name = "cargo_id_seq", sequenceName = "cargo_id_seq")
  @GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "cargo_id_seq")
  private Long id;

  // ... rest of the code remains the same ...
}


v0.14.6 and collections

Do you still answer questions about v0.14.6?  We're stuck on it for a while due to some legacy code.
If so, I've set up my reducers like so:
const modelReducer = modeled(reducer, 'parent.child');
const formReducer = formReducer('parent.child');

Add added them to the main reducer so they appear in the state tree as parent.child and parent.childForm respectively.
I've been adding collection items to the model with something like
actions.push('parent.child.collection', { first:'tim', last:'peters'});
This correctly adds items to the model's state tree:
parent: {
  child: {
    collection: [
      0: {
        first: 'tim',
        last: 'peters'
      }
    ]
  }
}

But it doesn't make the correct entries in the form's state tree.  The new item is added as a value to the collection:
parent: {
  childForm: {
    fields: {
      collection: {
       ... field data (blur, dirty, focus, etc),
        value: [
          0: {
            first: 'tim',
            last: 'peters'
          }
       ]
    }
  }
}

However, using actions.change() to add each of those individually does work:
actions.push('parent.child.collection[0].first', 'tim);
actions.push('parent.child.collection[0].last', 'peters');

Results in the same model state tree entries, and the correct form state tree entries:
parent: {
  childForm: {
    fields: {
      collection.0.first:
        ...all field data,
        value: 'tim'
      collection.0.last: 'peters':
        ...all field data,
        value: 'peters'
    }
  }
}

Am I misunderstanding how to add a collection item to the model and have it automatically appear in the form's fields?  Or is this a bug in how the collection's items translate into field names?

It might be a bug that has long been fixed in the latest version of React Redux Form.
Is there anything I can help answer in terms of upgrading? v0.x to v1.x is not a huge migration, and there would be relatively few things you'd need to change to get it working.

Just FYI, actions.push() is not in the table of contents in the documentation for those that have trouble finding it.

Our teams share a common input component library, and we built a special layer that helps those input components work with v0.x.  So it's a matter of getting our custom components to work with the new version, then changing how we reference the newer state tree, and our custom validation layer would change too...  It's a bit more than we can do at the moment.
But I'd like to share things I've had troubles with that were very difficult to understand in v0.x.  It might be useful for you to know some pain points in case they exist in v1.x (and maybe could use some extra documentation).  Please don't take it as criticism, I really like this library :)

There is a tight relation between the model and form.  But it's not necessary for their initial state to match.  Adding things to the model via RRF's actions automatically adds things to the form's fields in the state tree.
Use modeled() to add RRF functionality to an existing reducer.  It was right there in the docs but we somehow missed this for months...
The naming of collection items in the model is different than in the form.  It's tricky understanding when to use which.  I believe x1.x has solved this.
A  can be added to your JSX without being defined in the model or form.  But it won't appear in the state tree until it's touched by the user.  Unless you give it a defaultValue, then it appears in the state tree immediately.

The naming of collection items in the model is different than in the form. It's tricky understanding when to use which. I believe x1.x has solved this.

Yes, this has been solved.

can be added to your JSX without being defined in the model or form. But it won't appear in the state tree until it's touched by the user. Unless you give it a defaultValue, then it appears in the state tree immediately.

Yep, this is what setting the initialState is beneficial for. In V1.0 it's even simpler:
const store = createStore(combineForms({
  foo: initialFoo, // not a reducer
  bar: initialBar, // not a reducer
});

Thanks for the quick responses.  Hopefully we'll get to migrate to v1.x soon...


Recover existing wallet:Textual change.

2.0 to be removed.

U and K should be capital

Remove this line

Verified this issue on dev app v2.0.75(469)


Update types

This code throws a error:

Property 'locales' does not exist on type 'VueI18n & IVueI18n'. Did you mean 'locale'?

get availableLocales () {
  return this.$i18n.locales.filter(i => i.code !== this.$i18n.locale)
}

It helps me.
Maybe this is not the best solution, but it should fix the error.
I think it's worth adding this for the rest of the variables:
https://github.com/nuxt-community/nuxt-i18n/blob/90bcd80e7f0cbf4f00d15353c4eadea31f6ff892/src/plugins/main.js#L53-L59

@iliyaZelenko $i18n is directly related to vue-i18n and there is no locales object.
Assuming nuxt-i18n code seems to set app.i18n = new VueI18n(...) and then set things on app.i18n that is not defined in VueI18n itself, we might need to extend VueI18n interfaces to achieve what you're trying to do.

@iliyaZelenko do you see what's missing according to kevin's comment? Do you think you'd be able to complete the definitions before we merge?

@paulgv well, today I will make types for the remaining properties.

@iliyaZelenko Cool, for the locales property, I think it can be better than any type, would need to check source code to know what's the correct type (It's probably an array of object having code and other properties defined in documentation)

@kevinmarrec It looks like I made types for all options, but there wasn’t much point, as these types will not be used in the code of this package and it is unlikely that someone will use them in their project.
The main thing is that I have extended the IVueI18n interface so that the $i18n object has additional properties, I have separated options that fall into $i18n in a separate interface NuxtVueI18n.Options.VueI18nInterface.
I tested these types on my small project, there were no errors.

@iliyaZelenko Alright, great job !
I can't really take the time to check if types are all good, but it seems good and anyway it's not something that can break the project, it's "just" types.
So if it turns out that a type is not properly defined, we'll change it.
I trust you about having tested these types so let's stick with that !

Many thanks to both of you!
We now have some errors in the tests: https://circleci.com/gh/nuxt-community/nuxt-i18n/355
I'm not sure what's missing, can you have a look @iliyaZelenko ?
I'll publish these changes as soon as the tests are fixed!

@paulgv this should fix the error: https://github.com/nuxt-community/nuxt-i18n/pull/216


Can any user be added to a project?

If a student does not have a skill required for a project, can this student be added to that project.

Yes, students don't always need to be a perfect match. Not being able to add a student missing a specific skill seems like an unnecessary roadblock.

I also think that should be possible. They want to be able to draft any student to any project, so I think this should be possible too.


Remove all raw type compiler warnings

Remove all raw type compiler warnings

Since SuppressWarnings hides compiler warnings, I linked another issue.


Slack integration

This is a first 'phase' towards adding 'integrations' to Textile Photos. Here, I've added some optional cli arguments to shell and daemon modes that allows a Cafe to automatically post any photos added to any Thread the Cafe has joined to a specified webhook. Currently, we only support Slack incoming webhooks, but I could see us adding more generic support later. There is a longer roadmap for this which we will outline elsewhere.
Currently, there are some hardcoded parameters and urls that should eventually become configurable. But this should be more than sufficient for testing and initial trials.

Closing as we'll keep this in a separate branch for now. Refer to this PR for comments etc.


Navigation can become broken

Description
I pulled master with commit d9e72f3083c08375794afa216fb2f89c0114f303 and played with project example
Please check video:
https://github.com/pointfreeco/swiftui-navigation/assets/78256107/d4d6ff60-b04f-4bda-9208-81209da2d41d
Checklist

[X] I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
[X] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior
I can back to previous screen
Actual behavior
I can not back to previous screen
Steps to reproduce
Please check attached video
SwiftUI Navigation version information
d9e72f3083c08375794afa216fb2f89c0114f303
Destination operating system
iOs 17.2
Xcode version information
15.2
Swift Compiler version information
swift-driver version: 1.87.3 Apple Swift version 5.9.2 (swiftlang-<IP_ADDRESS>.56 clang-15<IP_ADDRESS>.5)
Target: arm64-apple-macosx14.0

Hi @shalom-aviv, unfortunately this is just yet another bug in SwiftUI navigation and there's nothing we can really do about it. We tried working around some SwiftUI bugs, but honestly it's become a big pain to do so, and we probably should have never even attempted it.
In the case study you are seeing in particular, we had a workaround for bugs in navigationDestination that worked for iOS <16.4 and iOS 17+. It now seems this workaround is no longer correct for 17.2+ and so we technically should add another condition to that code.
Honestly this is all just getting untenable. I recommend using navigationDestination(isPresented:) directly in your code, and mimicking what our navigationDestination(unwrapped:) does directly in your code:
https://github.com/pointfreeco/swiftui-navigation/blob/d9e72f3083c08375794afa216fb2f89c0114f303/Sources/SwiftUINavigation/NavigationDestination.swift#L54-L56
Since this isn't an issue with this library I am going to convert it to a discussion.