inference speed

When I test, the inference speed isn't as fast as the paper says. It can only achieve 50fps with 1HG stack.

@dingweichao123 Test time speed heavily depends on your hardware configuration and your cuda/gpu driver version.
Since I did not release the evaluation script for 1 HG model, may I ask how did you get your runtime speed?

@dingweichao123 Test time speed heavily depends on your hardware configuration and your cuda/gpu driver version.
Since I did not release the evaluation script for 1 HG model, may I ask how did you get your runtime speed?

The runtime is evaluated on GTX 2080ti and cuda 10. I wrote a test code just for deployment according to the script you release . I set the num_modules as  1 and num_landmarks as 98.

@dingweichao123 Test time speed heavily depends on your hardware configuration and your cuda/gpu driver version.
Since I did not release the evaluation script for 1 HG model, may I ask how did you get your runtime speed?

The runtime is evaluated on GTX 2080ti and cuda 10. I wrote a test code just for deployment according to the script you release . I set the num_modules as 1 and num_landmarks as 98.

There are probably some issues with your script. If you change the number of HGs to 1, and batch_size to 1 in my sample script and run it, at the end of the evaluation you will get something like this:
Everage runtime for a single batch: 0.009969

This is tested on a GTX 1080ti GPU with CUDA 10 and PyTorch 1.3.0.
My original code was tested on PyTorch 0.4.1, and on another 1080ti machine which I do not have access right now. So there might be some variations on the performance side. But 2080ti should be faster than 1080ti, 50 FPS on 2080ti does not make sense to me at all.

@dingweichao123 Test time speed heavily depends on your hardware configuration and your cuda/gpu driver version.
Since I did not release the evaluation script for 1 HG model, may I ask how did you get your runtime speed?

The runtime is evaluated on GTX 2080ti and cuda 10. I wrote a test code just for deployment according to the script you release . I set the num_modules as 1 and num_landmarks as 98.

There are probably some issues with your script. If you change the number of HGs to 1, and batch_size to 1 in my sample script and run it, at the end of the evaluation you will get something like this:
Everage runtime for a single batch: 0.009969

I tested this just now on a GTX 1080ti GPU with CUDA 10 and PyTorch 1.3.0.
My original code was tested on PyTorch 0.4.1, and on another 1080ti machine which I do not have access right anymore. There might be some variations on the performance side, but 2080ti should be faster than 1080ti. 50 FPS on 2080ti does not make sense to me at all.

Thx for reply, the test speed I mentioned includes pre-processing time and post-processing time, the inference speed can achieve 83fps.   I'll check my script.

@dingweichao123 Test time speed heavily depends on your hardware configuration and your cuda/gpu driver version.
Since I did not release the evaluation script for 1 HG model, may I ask how did you get your runtime speed?

The runtime is evaluated on GTX 2080ti and cuda 10. I wrote a test code just for deployment according to the script you release . I set the num_modules as 1 and num_landmarks as 98.

There are probably some issues with your script. If you change the number of HGs to 1, and batch_size to 1 in my sample script and run it, at the end of the evaluation you will get something like this:
Everage runtime for a single batch: 0.009969

I tested this just now on a GTX 1080ti GPU with CUDA 10 and PyTorch 1.3.0.
My original code was tested on PyTorch 0.4.1, and on another 1080ti machine which I do not have access right anymore. There might be some variations on the performance side, but 2080ti should be faster than 1080ti. 50 FPS on 2080ti does not make sense to me at all.

Thx for reply, the test speed I mentioned includes pre-processing time and post-processing time, the inference speed can achieve 83fps. I'll check my script.

Runtime should be evaluated based on model forward only for comparison. In my opinion, data preprocessing and postprocessing may vary, and should be handled in parallel with the model inference.

@dingweichao123 Test time speed heavily depends on your hardware configuration and your cuda/gpu driver version.
Since I did not release the evaluation script for 1 HG model, may I ask how did you get your runtime speed?

The runtime is evaluated on GTX 2080ti and cuda 10. I wrote a test code just for deployment according to the script you release . I set the num_modules as 1 and num_landmarks as 98.

There are probably some issues with your script. If you change the number of HGs to 1, and batch_size to 1 in my sample script and run it, at the end of the evaluation you will get something like this:
Everage runtime for a single batch: 0.009969

I tested this just now on a GTX 1080ti GPU with CUDA 10 and PyTorch 1.3.0.
My original code was tested on PyTorch 0.4.1, and on another 1080ti machine which I do not have access right anymore. There might be some variations on the performance side, but 2080ti should be faster than 1080ti. 50 FPS on 2080ti does not make sense to me at all.

Thx for reply, the test speed I mentioned includes pre-processing time and post-processing time, the inference speed can achieve 83fps. I'll check my script.

Runtime should be evaluated based on model forward only for comparison. In my opinion, data preprocessing and postprocessing may vary, and should be handled in parallel with the model inference.

I think there are some variations on the performance side between different version of Pytorch. I got the runtime 11.5ms/pic on Pytorch 1.1 and 10.2ms/pic on Pytorch 1.2 , very close to yours.

@protossw512  will you release 1HG model?


Implement ICustomTypeDescriptor  for Microsoft.Azure.Documents.QueryResult

The class Microsoft.Azure.Documents.QueryResult can't be investigated and transformed using the TypeDescriptor.GetProperties.
I'm working everything using dynamic and I need to transform, on the fly, the result of a request.
To do it I'm using the TypeDescriptor.GetProperties.
My transformer works perfectly with a lot of objects especially deserialized with JSON.NET.
Would be very useful, at least to me, an implementation of ICustomTypeDescriptor (supported even in netstandard2.0).
Thanks.

Syncing offline with @fabiomaulo

For now the workaround is to leverage GetDynamicMemberNames() API.
Adding this as backlog to consider this as first class support in future releases.


Add --ignore-inode option to backup cmd

What is the purpose of this change? What does it change?
revised version of https://github.com/restic/restic/pull/2047
This PR adds --ignore-inode option to backup command, in order to support those filesystems that don't support fixed inodes, typically Fuse, pCloud, etc.
Was the change discussed in an issue or in the forum before?
https://github.com/restic/restic/issues/1631
https://github.com/restic/restic/pull/2047
Checklist

[x] I have read the Contribution Guidelines
[x] I have added tests for all changes in this PR
[x] I have added documentation for the changes (in the manual)
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

@fd0 when will this PR make it into an official release?

When the next version of restic is released. As this is an open source project we don't have a timeline :)

When the next version of restic is released. As this is an open source project we don't have a timeline :)
If you want to use it right now, either compile restic yourself from the master branch (which should be pretty stable) or use one of the beta binaries here: https://beta.restic.net/?sort=time&order=asc

C:\Temp\restic>go run -v -mod=vendor build.go
errors
errors
compile: version "go1.12.2" does not match go tool version "go1.11"
math/bits
internal/cpu
math/bits
compile: version "go1.12.2" does not match go tool version "go1.11"
internal/cpu
compile: version "go1.12.2" does not match go tool version "go1.11"
runtime/internal/atomic
runtime/internal/sys
runtime/internal/atomic
compile: version "go1.12.2" does not match go tool version "go1.11"
runtime/internal/sys
compile: version "go1.12.2" does not match go tool version "go1.11"
unicode/utf8
internal/race
unicode/utf8
compile: version "go1.12.2" does not match go tool version "go1.11"
internal/race
compile: version "go1.12.2" does not match go tool version "go1.11"
sync/atomic
unicode
sync/atomic
compile: version "go1.12.2" does not match go tool version "go1.11"
internal/syscall/windows/sysdll
unicode
compile: version "go1.12.2" does not match go tool version "go1.11"
unicode/utf16
internal/syscall/windows/sysdll
compile: version "go1.12.2" does not match go tool version "go1.11"
unicode/utf16
compile: version "go1.12.2" does not match go tool version "go1.11"

When the next version of restic is released. As this is an open source project we don't have a timeline :)
If you want to use it right now, either compile restic yourself from the master branch (which should be pretty stable) or use one of the beta binaries here: https://beta.restic.net/?sort=time&order=asc

C:\Temp\restic>go run -v -mod=vendor build.go
errors
# errors
compile: version "go1.12.2" does not match go tool version "go1.11"
math/bits
internal/cpu
# math/bits
compile: version "go1.12.2" does not match go tool version "go1.11"
# internal/cpu
compile: version "go1.12.2" does not match go tool version "go1.11"
runtime/internal/atomic
runtime/internal/sys
# runtime/internal/atomic
compile: version "go1.12.2" does not match go tool version "go1.11"
# runtime/internal/sys
compile: version "go1.12.2" does not match go tool version "go1.11"
unicode/utf8
internal/race
# unicode/utf8
compile: version "go1.12.2" does not match go tool version "go1.11"
# internal/race
compile: version "go1.12.2" does not match go tool version "go1.11"
sync/atomic
unicode
# sync/atomic
compile: version "go1.12.2" does not match go tool version "go1.11"
internal/syscall/windows/sysdll
# unicode
compile: version "go1.12.2" does not match go tool version "go1.11"
unicode/utf16
# internal/syscall/windows/sysdll
compile: version "go1.12.2" does not match go tool version "go1.11"
# unicode/utf16
compile: version "go1.12.2" does not match go tool version "go1.11"

@nixzahlen your comment is unproductive and comes across as passive-aggressive. Don't do that, here or anywhere, but especially not here. It wears me and other contributors down and reduces my motivation a lot. In fact, now I'm thinking about what I should write here instead of working on the code.
I assume you are complaining that my statement ("compiled the code yourself") does not work for you.  It has nothing to do with restic, as you can easily find out yourself by searching for the error message. Run set GOROOT= (avoid trailing spaces here) before running go. Or use a pre-compiled binary.
So, next time, please spend five to ten minutes looking for the error message yourself, then create a  new issue here. Don't comment on old, closed issues or PRs if you can avoid it.


[plugin-jenkins] Add tooltip to Jenkins build rerun

Hey, I just made a Pull Request!

Adds a tool tip when highlighting over the Jenkins rerun button on the CI/CD page.

Marked as minor, under the guise that pure semver would suggest patches should only be for bugfixes?  But happy to change back to a patch as this is really small.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)

Sweating the details 😍


atomic xtensa  build fail

Describe the bug
Not all xtensa architectures support the s32c1i and SCOMPARE1 registers
code:
#if defined(CONFIG_ATOMIC_OPERATIONS_BUILTIN)
/* Default.  See this file for the Doxygen reference: */
#include <sys/atomic_builtin.h>
#elif defined(CONFIG_ATOMIC_OPERATIONS_ARCH)-----------------------------------------------------------here
/* Some architectures need their own implementation */
# ifdef CONFIG_XTENSA
/* Not all Xtensa toolchains support GCC-style atomic intrinsics */
# include <arch/xtensa/atomic_xtensa.h>
# endif
#else
/* Generic-but-slow implementation based on kernel locking and syscalls */
#include <sys/atomic_c.h>
#endif

static ALWAYS_INLINE
atomic_val_t xtensa_cas(atomic_t *addr, atomic_val_t oldval,
			atomic_val_t newval)
{
	__asm__ volatile("wsr %1, SCOMPARE1; s32c1i %0, %2, 0" ---------------------------------------------here
			 : "+r"(newval), "+r"(oldval) : "r"(addr) : "memory");

	return newval; /* got swapped with the old memory by s32c1i */
}

log：
atomic_xtensa.h:35: Error: unknown opcode or format name 's32c1i'
atomic_xtensa.h:35: Error: invalid register 'SCOMPARE1' for 'wsr' instruction
atomic_xtensa.h:35: Error: unknown opcode or format name 's32c1i'
xt-xcc.exe ERROR:  C:/usr/xtensa/XtDevTools/install/tools/RI-2020.5-win32/XtensaTools/bin/xt-as.exe returned non-zero status 1

At least the code needs to be judged as follows,or distinguish the architecture used
if (XCHAL_HAVE_S32C1)
..............

The kconfig I saw opens the ATOMIC_OPERATIONS_ARCH configuration by default.
zephyr\arch\Kconfig：
config XTENSA
	bool
	select ARCH_IS_SET
	select HAS_DTS
	select USE_SWITCH
	select USE_SWITCH_SUPPORTED
	select ATOMIC_OPERATIONS_ARCH          -----------------------------------------------------------here
	help
	  Xtensa architecture

SECOND:
I found another problem when I enabled ATOMIC_OPERATIONS_BUILTIN
config SOC_SERIES_MYSOC
	bool "Xtensa hifi4 core"
	select XTENSA
	select XTENSA_HAL
	select ATOMIC_OPERATIONS_BUILTIN

log:
In file included from E:/work/zephyr/include/sys/atomic.h:29,
                 from E:/work/zephyr/include/kernel_includes.h:21,
                 from E:/work/zephyr/include/kernel.h:17,
                 from E:/work/zephyr/include/init.h:11,
                 from E:/work/zephyr/include/device.h:29,
                 from E:/work/zephyr/kernel/include/kernel_offsets.h:6,
                 from E:/work/zephyr/arch/xtensa/core/offsets/offsets.c:7:
E:/work/zephyr/include/sys/atomic_builtin.h:304:29: error: syscalls/atomic.h: No such file or directory

Under the build directory I only found "ZCAN-sdk\build\zephyr\include\generated\syscalls\atomic_c.h" but no "atomic.h"
CONFIG_ATOMIC_OPERATIONS_C and CONFIG_ATOMIC_OPERATIONS_BUILTIN and CONFIG_ATOMIC_OPERATIONS_ARCH are enabled by me at the same time. but there is no warning that they cannot be enabled at the same time
code:
#ifdef CONFIG_ATOMIC_OPERATIONS_C
#include <syscalls/atomic.h>
#endif

My current change plan can build the code:	del "select ATOMIC_OPERATIONS_ARCH"  & CONFIG_XTENSA_NO_IPC=y & CONFIG_ATOMIC_OPERATIONS_C=y
zephyr\arch\Kconfig：
config XTENSA
	bool
	select ARCH_IS_SET
	select HAS_DTS
	select USE_SWITCH
	select USE_SWITCH_SUPPORTED
	help
	  Xtensa architecture

Does your platform really not have S32C1?  That is the Xtensa atomic operations primitive, without it you have no hardware support and need to fall back to a much slower irq_lock() implementation in ATOMIC_OPERATIONS_C.  ATOMIC_OPERATIONS_BUILTIN just falls back to the gcc implementations, which are essentially identical to our own and also based on S32C1I -- they won't work for you (the only reason we have our own is that older xcc toolchains don't have the gcc builtins).
As far as selecting this automatically based on core-isa.h constants, that would be nice but difficult, as kconfig sits upstream of the C compiler.  You need the kconfig output header defined before you can build a C file against core-isa.h.  The Zephyr model is that the platform layer decides on software configuration.

@andyross
The biggest problem I encounter at the moment is that I have to change the code of Zephyr in order to compile and pass.
If I change this, it will affect other platforms.
zephyr\arch\Kconfig：
config XTENSA
	bool
	select ARCH_IS_SET
	select HAS_DTS
	select USE_SWITCH
	select USE_SWITCH_SUPPORTED
        select ATOMIC_OPERATIONS_ARCH          -----------------------------------------------------------del here
	help
	  Xtensa architecture

as long as CONFIG_XTENSA is configured, select ATOMIC_OPERATIONS_ARCH will be selected. So my suggestion is not to choose here, but to give others the right to choose.
Otherwise, the unsupported S32C1 platform cannot be built through

Does your platform really not have S32C1? That is the Xtensa atomic operations primitive

To be more precise that is one of the possible xtensa atomic operations primitive. There's also exclusive access option with l32ex/s32ex/getex/clrex opcodes and XCHAL_HAVE_EXCLUSIVE core-isa.h macro.


Spike every 5 or 10 MHz depending on sample rate

Not sure if my Limesdrmini has gone broken or the latest update from here but i can no longer measure antennas as every 5 or 10Mhz there is a spike depending on which samplerate i use
here's a screen shot spikes at 410 420 430 etc https://puu.sh/Ds8p6/ee52c6dda1.png done with a 50 Ohm calibration SMA plug

The "spikes" caused by the bandwidth of the receiver, its normal. Use relative mode if you want to cancel it out. Its is possible to cancel it out by overlapping measurements(use only 60-70% of the available bandwidth) but its not implemented yet. You can reduce the bandwidth by editing the SingleToneSweeper.py at line 42:
self.bandWidth = round(sampleRate*0.7)

Odd did not have them before and measurements were correct now nothing matches.
How i tried today do sweeps with a short  press relative then do antenna still spikes every 5Mhz
then i did it with  the 50 ohm calibration sma still spikes every 5Mhz.
before i just ran sweep directly and antennas got measured pretty well

Take a look at the Y axes labels on your previous screenshot there is a max of 0.004(VSWR) error at the spikes, seems negligible.
To confirm any problem please take screenshots from the antenna measurements with/without calibration in dB and VSWR mode and also the 50ohm sma calibration resistor in absolute mode(dB).


Usb server branch

The USB Server forwards rover messages to connected usb devices. Comminication is done using the packet structure from the vedder vesc bldc motor controllers. Requires modified firmware to use the vesc controllers.
List of changes:

Added the rover process USBServer
Communication with vedder vesc motor controllers

All credit for implementing the python/cython side of vesc communicaiton goes to @irene000.

Everything seems to work from a laptop, and after much coaxing, the raspberry pi as well. USB traffic on the raspberry pi can be limited by the fact that ethernet is handled by the same LAN9514 chip, so internet connections can be starved if too many motor controllers are connected. I will post the work around somewhere in the wiki.


Added page for creating flashcards

Description

Added page for creating flashcards.
Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

saveDeck method in GDriveRepo does not work


(Fix) Duplicated Owner Addresses on Safe Creation

This PR closes #1661, by:

adding a form-level validation function to properly check for duplicates

Also fixes #1183, by:

fixing row deletion function

Travis automatic deployment:
https://pr1666--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1666--safereact.review.gnosisdev.com/volta/app

This one looks good
A new ticket was created for the same issue in Address book and Settings (Adding/replacing owners)

@Agupane, @nicosampler I just added a couple of tests for the 'remove-owner' related function.
I was thinking about splitting this into two separate PRs and add tests for the refactored function. But given it's already checked/tested, I did it here :grimacing:

@Agupane, @nicosampler I just added a couple of tests for the 'remove-owner' related function.
LGTM

I've never acknowledged that this ticket also fixes 1183.

Travis automatic deployment:
https://pr1666--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1666--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1666--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1666--safereact.review.gnosisdev.com/volta/app


Labels not drawn for manually typed input coordinates in ArcMap

Drawing Lines by typing coordinates in for Starting Point and Ending Point produces a line without labels, whereas using the Map Point tool's line produces labels.
Steps:

Select Lines tab

Type '0.0 .0.0' for the Starting Point (without the single quotes)

Type '5.0 5.0' for the Ending Point (without the single quotes)

Select "Enter"
A line is drawn in Gulf of Guinea pointing to the northwest, which is correct, but there is no labels

Select Map Point tool and draw a line roughly parallel.
A second line is drawn WITH LABELS.

@mfunk fixed pull request https://github.com/Esri/distance-direction-addin-dotnet/pull/252

Looks good!


Added zoom in and zoom out functionality to performance viewer 🔍

This pullrequest implements the "Allow zooming into the graph" feature of milestone 3 in #10566. It does this by adding the following:

Attaches an event listener on construction of the service,
Event listener triggers whenever we use the mouse wheel to zoom in or out (Forward = in, Backwards = out).
When triggered we will get how much to zoom based on the mouseDelta before we triggered the event and bind the zoom level to be between 60 datapoints (at minimum) and the length of the largest dataset (at maximum).
We remove event listeners on unmount.

We also draw a playhead at the end of the data.  To help the user know where the future data is, and to move the changing bit to the center. This gives the eye something to lock onto and reduces the anxiety of the user when zooming into the graph fully. Without this the graph would look very chaotic.
To draw the playhead we do the following:

Adjust the maximum datapoint in the x axis based on the scale factor (this will scale all of our data to scaleFactor% of the canvas). Note: The scale factor is a number between 0.0 and 1.0 representing the percentage of the canvas. Currently the scaleFactor is a constant, but if we make this dynamic we should look at if there are any occurrences of division by zero, although I don't see a point where scaleFactor will ever be 0 (as that means that the data is fully hidden and we only see the playhead ).

We then paint the future box and a divider to 1-scaleFactor of the screen, and then paint the playhead about 8 pixels before the divider. This is done to give the user the ability to see the delta better.

Anyways here is  a video quickly showing off what is included in this PR:
https://user-images.githubusercontent.com/32103099/124183320-0b994900-da86-11eb-8708-499dcc67be17.mp4

Looks all good to me :-) @RaananW can I merge it ?


Animation on Toasts

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Can we have animations on toast as in pine ui?
Motivation and context
I have seen a cool toast animation on pine ui.

I suppose this is https://devdojo.com/pines/docs/toast


time.h: time() and ctime()

This change is

Reviewed 4 of 4 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

tests/time.c, line 18 at r2 (raw file):

    now = time(&tloc);
    is_true(now == tloc);

Please use is_eq(now, tloc) instead. This will show the value of both if it fails.

tests/time.c, line 20 at r2 (raw file):

    is_true(now == tloc);

    pass("%s", "time");

This is unesseary because there is an assertions above. However, it would be a good idea to also check: is_not_eq(now, 0)

tests/time.c, line 30 at r2 (raw file):

    time_t now = 946684798;
    s = ctime(&now);
    printf("%s", s);

Avoid printf as it will break the TAP output. You can use is_streq: https://github.com/elliotchance/c2go/blob/master/tests/tests.h#L198

tests/time.c, line 32 at r2 (raw file):

    printf("%s", s);

    pass("%s", "ctime");

Like the previous pass this doesn't actually check anything and can be removed.

Comments from Reviewable

Thanks for putting in the PR. I started to review it as you were still making changes :)

Review status: 2 of 4 files reviewed at latest revision, 4 unresolved discussions.

tests/time.c, line 18 at r2 (raw file):
Previously, elliotchance (Elliot Chance) wrote…
Please use is_eq(now, tloc) instead. This will show the value of both if it fails.

Done.

tests/time.c, line 20 at r2 (raw file):
Previously, elliotchance (Elliot Chance) wrote…
This is unesseary because there is an assertions above. However, it would be a good idea to also check: is_not_eq(now, 0)

Done.

tests/time.c, line 30 at r2 (raw file):
Previously, elliotchance (Elliot Chance) wrote…
Avoid printf as it will break the TAP output. You can use is_streq: https://github.com/elliotchance/c2go/blob/master/tests/tests.h#L198

Done.

tests/time.c, line 32 at r2 (raw file):
Previously, elliotchance (Elliot Chance) wrote…
Like the previous pass this doesn't actually check anything and can be removed.

Done.

Comments from Reviewable

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

@elliotchance Thank you for reviewing. I am having a hard time troubleshooting the OS X error; I do not have a machine at hand.
I tried to compile similar code in Travis. The build succeeded.

https://github.com/yulvil/clang/
https://travis-ci.org/yulvil/clang/builds/290531110

Is it possible to add debug for the Travis/OS X build? Any help appreciated.

When I run it on my Mac:
Elliots-MacBook-Pro-3:c2go elliot$ clang tests/time.c
Elliots-MacBook-Pro-3:c2go elliot$ ./a.out
1..6
# time
1 ok - now != 0
2 ok - now != 0
3 ok - now == tloc
# ctime
Segmentation fault: 11

It looks like ctime expects that the parameter not be NULL.
When I removed https://github.com/elliotchance/c2go/pull/253/files#diff-c3bb064a4d264cc6f2d46ab300725b61R25 I did not get the segfault.
Even the same compiler on different operating systems can give different results. You can remove line 25 and 26 and your build should pass.

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Awesome - thanks for the PR! 👍

@elliotchance Thank you for merging!


Docs: Add difference between the Bandada and Semaphore Groups in the FAQs

Bandada website: https://bandada.pse.dev/
Semaphore website: https://semaphore.pse.dev/

Some notes:
Regarding off-chain groups Semaphore has libraries to make it easier to have an infrastructure to manage groups. Semaphore does not have an infrastructure to manage off-chain groups. Bandada has that and also with other features such as: invite code (or link) to join a group and antisybil mechanisms to join a group.
Regarding on-chain groups, Semaphore has a set of on-chain contracts to manage groups so I would say that it can manage on-chain groups well.
In general:

Semaphore is a protocol for anonymous interactions. It should be simple.
Bandada is an infrastructure to manage privacy-preserving groups.
Bandada and Semaphore are compatible, the groups are different but can be transferred from one project to the other and used together.
Bandada makes it easier to work with off-chain Semaphore groups since Semaphore does not have an infrastructure for that.
To join a Semaphore group sometimes you need an antisybil mechanism, Bandada has this functionality integrated.
Bandada will help to manage really large groups because when a group has too many members it's necessary to create the merkle proof in a server instead of in the client side (browser).
Bandada implements easily the gating mechanisms to join groups.
Bandada makes these gating mechanisms composable (using logical operators) expanding the expressivity to join the group

Hey @od-hunter! Yes, it's still open. I just assigned you the issue. Feel free to ask any questions you may have.

Thank you @vplasencia

@vplasencia,
Is it the faq.md am expected to add the update for the differences?

Hello @vplasencia please review my pr

Hey @od-hunter! This is a high priority task now, so I will work on it to finish it asap.
Then I will need to close your PR, sorry for it, but feel free to ask for any other good first issue here: https://github.com/bandada-infra/bandada/issues?q=is%3Aopen+is%3Aissue+label%3A"good+first+issue"
Thank you! 🙏


How to get this info?

"network": "livefyre.com",
"siteId": "313878",
"articleId": "1",
"environment": "livefyre.com"
What are those siteID? articleId? network?
If i am going to pull social media stream from a certain celebrity social media acccount, what should i fill for those field above?

Social Media aggregation into Livefyre Collections requires purchasing a Livefyre Subscription. Do you or your employer have one? http://web.livefyre.com/engagement-cloud/

How to subscribe?

Fill out the form on http://livefyre.com/learnmore


Support Certificates With Password

Any chance you can add support for certs with passwords?

Sorry about this, just saw this issue.
Unfortunately, I have no time for this at this very moment. Do you still have a use for it? Would you be willing to create a PR for it?

@zeus82 do you still need this?

it will be nice to have that

it will be nice to have that

Are you interested in making a PR for this? I don't have much where to test.


Crash/Bug on trying to ... Black Screen in game

General Info
Terasology Launcher Version:
Terasology Version:
Operating System:
Onboard / Dedicated Graphics:
Java Version:
What you were trying to do
A clear and concise description of what you expected to happen.
What actually happened
A clear and concise description of what didn't match your expectations, a.k.a. the crash or malfunction you faced.
How to reproduce

Select Terasology version '...'
Start Terasology
Select gameplay '...'
Add modules '...'
Start game
Do '...'
See error

Log details
Note, that the crash reporter often provides multiple tabs with different logs.
Please attach (a link to) all of them.
Screenshots
If applicable, add screenshots to help explain your problem.
Workaround
If applicable, describe any workaround you found to avoid the issue
Additional Infos / Context
Feel free to add any other context about the problem here.
Hi There is the problem The Game Give Me black Screen When enter world i Has All the Requirements to lunch game

Hi @MoamenA
Please fill in the template including general info, reproduction steps and log details, otherwise we cannot help you with this.


Get possible values based on regex input

What's the Problem?
I need to get values matching a regex. They can be very complicated, and I would like to get some test values to run against a regex.
Solution/Idea
If I have a regex like this ^[a-zA-Z0-9]+(-*[a-zA-Z0-9])*$ I would like to get a list of values that match this (or just one value matching it)
Alternatives
I tried various tools like https://onlinestringtools.com/generate-string-from-regex and for at least the regex above they give me some gibberish...
Priorities

Capability
Priority

Generate test data from a given regex
Must

DevToys Version
Version <IP_ADDRESS> | X64 | RELEASE | b949a18 | b949a18
Comments
Nothing I can think of...

I wonder if Bing Chat or Chat GPT can help with that nowadays.


Implement pagination on existing APIs with potentially large result sets

All new APIs should have pagination included in any call that might return more then 100 results as data grows. So for example all getAll... calls should certainly have it and getXById can do without it as it will only return 1 item.
Go though all existing services finding the calls that should have it and update the service, controller and route to support pagination as done in the tags API and also in the resources API.

Completed as example in Goals


JIT trace does not work correctly with pyro.plate

I am not sure if this is a bug or I am using "pyro.plate" in a wrong way.
The following code shows the issue. I got this issue while trying to train a HMM model. Things work well for non-jit version. If we call torch.autograd.grad(loss_jit(x), (x,)) two times, it will throw RuntimeError: "Can not go backward 2 times for the graph".
import pyro
import pyro.distributions as dist
import pyro.poutine as poutine
import torch

def model():
    with pyro.plate("plate", 2):
        pyro.sample("x", dist.Normal(0, 1))
    #pyro.sample("x", dist.Normal(0, 1).expand((2,)).to_event())  # this works!

trace = poutine.trace(model).get_trace()

def loss(x):
    trace.nodes["x"]["value"] = x
    return poutine.trace(poutine.replay(model, trace=trace)).get_trace().log_prob_sum()

x = torch.tensor([0., 1.], requires_grad=True)
loss_jit = torch.jit.trace(loss, x, check_trace=False)
print(loss_jit(x))  # -2.3379
print(loss_jit(x))  # -4.6758

Excellent! Thanks a lot @eb8680 for a clear explanation! Things work smoothly now. :)

Nice sleuthing, @eb8680! We should fix that line in Trace.log_prob_sum() to use result = result + _ rather than +=.

Closed via #1687.


An option to disable the animation resampling

When using hand crafted animations, resampling my produce unintended results (one example are animations baked into a stepped curve for clean loops).
An option to completely skip resampling would be extremely useful, either as "-af 0" or "-noa".

Thanks for the request. It makes sense but I'm interested in a few details because they would determine the implementation complexity for this feature.

Would it be acceptable if this option didn't support animations that use cubic splines
Would it be acceptable if this option assumed that different tracks in the same animation have a matching timeline (which is what would happen after baking), and either failed or resampled using one of the tracks, with possibly non-uniform time keys, otherwise.

Also, would it help at all if during resampling, the time key of the last frame was preserved exactly, so that e.g. resampling a 1.23 second long animation at 10 Hz would still produce frames every 100ms but the last two frames had timestamps of 1.2 and 1.23 seconds respectively (right now it would produce 1.2 and 1.3 or 1.2 alone I believe).

To be fair, I downloaded the source code and had a look at it - in my case the issue I had was solved by setting the interpolation of the exported animation curves to STEP.
I'll clean up my changes and submit a pull request.
Basically the reason for this are loops where an item moves from A to B and then needs to jump back to A at the start of a loop again. That jump is visible if the interpolation is anything but STEP.
On a side node, massive kudos for the project - I've seen a 100% performance increase with the assets I've created after running then through gltfpack.


Jenkins should deploy latest distributions for each platform

Right now, Jenkins deploys only the image for the latest successful build here:
https://dl.feenk.com/gt/GToolkit-latest-build
However, we would also need the concrete packaging together with the VM for each platform.

This works now:
https://dl.feenk.com/gt/GToolkitLinux64-release.zip
https://dl.feenk.com/gt/GToolkitOSX64-release.zip
https://dl.feenk.com/gt/GToolkitWin64-release.zip


Enhance the UI of the footer section

Is your feature request related to a problem? Please describe.
Yes, Currently the alignment of the sections in the footer are not properly alignment which impacts the overall user experience and visual appeal.
Describe the solution you'd like.
I would to work on it by fixing these issues of the footer and make it more interactive.
Describe alternatives you've considered.
No response
Additional context.
I would like to work on it.
Please assign it to me under gssoc-ext and hacktoberfest.
Show us the magic with screenshots

Checklist

[X] I have checked the Existing Issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

thank you for raising this issue.
but for now we are not looking for any further updates on footer, as there were many changes happened before.
so i am closing this issue.
please understand.


Please update the tahoma component to the latest api

Tahoma is currently using the 0.0.13 version of the api. 0.0.14 is available for some time now.
tahoma-api==0.0.14

You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum. Thanks!


JUnit task vs. Exec task

Hi @rjust,
Here my first iteration to address issue #42. Known limitations:

currently, only the -t option of $D4J_HOME/framework/bin/defects4j test works, as I've no clue how to get the test class if not specified by -Dtest.entry.class.
whether there are 0 or 1000 failing test cases the outcome of the exec task is not integrated with D4J. (currently, the only way to know if a the test case failed is by looking at the 'failing_tests' file).

--
Cheers,
Jose

I am closing this for now; we will reopen the PR once the prototype is ready for replacing the entire test-execution set up in D4J, which is a major change.


Replace drop-shadow with box-shadow in <CodeSnippet>

What kind of changes does this PR include?

Changes to the docs site code

Description

Closes #1790 (and maybe #2726?)

Changes how the glow around our code samples is rendered. Previously this used the drop-shadow CSS filter which has poor performance in some browsers. I’ve replaced this with several box-shadows tweaked to try and replicate roughly the same effect. This isn’t quite possible but hopefully folks agree the difference is small enough to be OK for the performance gain.

Before
After

Will let Yan weigh in on the code, but the effect looks fine on Sarah's Evil Devices!


Implement restartTechnologyRequestIOS

In some cases we might get disconnected from the NFC tag. When that happens, we are not able to communicate with the NFC tag anymore, so on iOS the only valid further step is to invalidate NFC session with an error, and ask the user to try again. It also seems to be impossible to process multiple NFC tags within a single CoreNFC tag reading session (unless I'm mistaken).
This PR implements additional method called restartTechnologyRequestIOS which essentialy wires the NFCTagReaderSession.restartPolling() into the react-native-nfc-manager. This API makes it possible to process multiple tags or to retry an NFC operation against the same tag in case of any failure, without actually restarting the NFC scanning prompt.

@icedevml it's awesome, thanks for the contribution!

Could you please give an example of how to use restartTechnologyRequestIOS?

Whenever you have the transceive failure, you can call something like await NfcManager.setAlertMessageIOS("Failed to read the tag, please tap it again...") in order to tell the user what is going on, then you can immediately call await NfcManager.restartTechnologyRequestIOS(). The latter call will block until a new tag is detected, at which point you can use it normally with NfcManager.transceive(...).


compose: Fix flashing effect on trying to send message that's too long.

Due to a wrong CSS selector, the expected red outline flashing effect was not being applied to the compose box when the user tried to send a message that was longer than the maximum allowed length, which is fixed by this commit.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@timabbott Let me know if I should test.

@kuv2707 could you do a quick round of manual testing here, and mark for integration review if everything looks good?

The flashing works as intended, but doesn't end uniformly - sometimes it flashes three times as expected,
and sometimes extends to fourth for a split-second.
This is because setTimeout (used for removing the animation) isn't always punctual and sometimes fires a few milliseconds after the expected time.
Replication: I triggered the animation thrice, notice the second time

We can fix it by changing the animation iteration count from infinite to 3 in compose.css:298
If this is not a concern, the changes look good.

@kuv2707 Thanks for that excellent catch! Have changed the iteration count to 3 so there's no glitchy partial 4th flash now.

@zulipbot add "integration review"

Merged, thanks @N-Shar-ma and @kuv2707!


Didnt work properly under local windows environments

The problem is the missin SSl certificate.
Give us more control over the Guzzle instance to deactivate the SSL verification
cURL error 60: SSL certificate problem: unable to get local issuer certificate

Hi @benjaminfunk ,
Sorry for late reply.
You have full control over Guzzle Instance. You can also use an existing guzzle instance:

// create a guzzle client
$guzzle = new GuzzleHttp\Client(
    [
        'timeout'         => 0,
        'allow_redirects' => false,
        'proxy'           => '<IP_ADDRESS>:10',
        'verify'           => false /** DANGER: NEVER USE IN PRODUCTION */
    ]
);
// create the internal httpClient
$httpClient = new \Affilinet\ProductData\HttpClient\GuzzleClient($guzzle);

// the final config
$config = [
    'publisher_id' => '123456789',
    'product_webservice_password' => '123456789',
    'http_client' => $httpClient,
];
// and here it is
$affilinet = new \Affilinet\ProductData\AffilinetClient($config);
`

Updated documentation http://affilinet.github.io/productdata-php-sdk/documentation/#examples


Add functions fill_missing_key_combinations and missing_struct_expr

fill_missing_key_combinations: Fill missing key combinations with requested fill values.
missing_struct_expr: Create a struct of missing values for each field and type in the input struct.
Also added test code for both

I am having trouble getting the tests to run with my IDE but I think this is a me problem


GIT Source Control: Undo commit keeps the last commit message for any new commit

Does this issue occur when all extensions are disabled?: Yes/No
Yes

Version: 1.86.2
Commit: 903b1e9d8990623e3d7da1df3d33db3e42d80eda
Date: 2024-02-13T19:41:37.860Z
Electron: 27.2.3
ElectronBuildId: 26908389
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 6.1.0-18-amd64 snap

Steps to Reproduce:

Open Source Control to see all new changes/files
Stage new changes
Create a new commit for these changes
In the same window (Source Control) on Commits tab below, identify the last commit created and undo such commit
Here you can choose unstaging the changes to add another ones or stage and commit from the terminal using git commands
If you stage new changes then you press Commit it applies the earlier commit message for these new changes, thus producing inconsistency among commits

In the image, I made a mistake in the commit message yesterday then I created the commit manually from terminal and today using source control, when I tried to commit other non-related changes it automatically applied that message to my new commit.

It's been a while since this .. and yes, regarded to my git lens extension.
Thanks for response


Fix README example to use imported action constant

@shortjared hi! there is import { ADD_TODO } from 'constants', so this is variable, not string :)


Implementation of Oauth of Github and Google

fixes #4160
The right way it should look after logging in

new added button to log in with github

Changes:

added new buttons on login page for GitHub,Google Oauth authorization
added functions createLink and getOAuthToken  into authentication.thrift
changed the current version of thrift API from 6.58.0 to 6.59.0
imported OAuth2Session in client.py
added a case for Oauth authorization in login_user function
added definition for thrift
imported OAuth2Session in authentication.py
added code to load the authentication configuration from
added oauth method for authentication in performLogin function
added oauth case in session manager
added fields for server_config file in the server_config.json
added oauth cases in auth.js
added reusable providers dict to server config to allow easier adding of new oauth providers
create a new function get_oauth_config for getting different providers configs in session manager
added documentation for configuration

This looks like a real nice feature! Any update?


PDF Download issue

Description
the PDF couldn't download, seems like a speed problem. i can download pdf form other websites
(Optional:) Please add any files, screenshots, or other information here.
No response
(Required) What is this issue most closely related to? Select one.
Choose One
Internal issue ID
06328902-5f27-49c6-a16c-c1d55856db4e
Paper URL
https://arxiv.org/html/2402.10275v2
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop

This was likely due to server load, should be better now.


Toggle setting for suggested macro

Hello!
To preface, my PC struggles to run FFXIV already. However, it gets much much worse every time I open the crafting menu because every single time I click on any item, it auto-opens the side bar and starts running a search for a suggested macro. I am not going to craft every item I click as sometimes I am just comparing recipies, or I already have a macro for the recipie.
Basically, I would apprciate the option to not run a show the suggested macro tab, and only show the "view saved macros/open in simulator" buttons.
My standard workflow is identify an item to craft, then open in simulator to run the search w/ increased control on what foods or HQ items I am going to use. Having the Suggested Macro run every time I open it is annoying, esspecially since there is no progress bar, so I end up just having to close the crafting log to get my game playable again. For refrence, FFXIV drops to ~7 FPS for around 30 seconds (with the easier crafts) when the suggested macro calculation is running.
If it is not possible to create a toggle for removing it, a toggle for adding a button to start it from that page would work as well. Just some way for it to not start automatically for every craft item.
Thanks!

Thanks for the quick response!
Great to know that its (hopefully) in the next release!
Yeah, I've seen the core setting, however its not that helpful since I will just have to toggle it back to full when I do want to run the solver, so it becomes a game of low->high->low->high and so forth. I figured I would leave a suggestion just in case!

Also while I have you here?
Another suggestion would be to add the "Tier" of the collectable if thats possible. It's easy enough to just always go to highest number, but it would be a welcome suggestion to have 3 lines on the probability plot indicating where the collectablity milestones are.


[macOS] Enabling "Reduce transparency" makes buttons unclickable

Steps to Reproduce
See internal bug: b/246982950

Download repro app (see internal bug above)
Launch repro app
Enable Reduce transparency (System Preferences > Accessibility > Display > check Reduce transparency)
Try to click on buttons. Nothing happens
Disable Reduce transparency
Try to click on buttons again. They now work as expected.

/cc @cbracken @a-wallen

It seems this issue happens if the button is in an NSPopover. See b/246982950 for more details.

Here's a minimal repro https://github.com/a-wallen/flutter-popover

Looks like the responder chains are different when "Reduce Transparency" is enabled/disabled.
Reduce Transparency Disabled
<FlutterView: 0x7ff72c0049e0>
<FlutterViewWrapper: 0x7ff72c004c30>
<FlutterViewController: 0x7ff74bf2eef0>
<NSPopover: 0x600003e94b00, animates=1, behavior=0>
<_NSPopoverWindow: 0x7ff72c0051c0>
<NSStatusBarWindow: 0x7ff74d06c1c0>

Reduce Transparency Enabled
<FlutterViewWrapper: 0x7fe84b205160>
<FlutterViewController: 0x7fe85a91b4f0>
<NSPopover: 0x60000152c8f0, animates=1, behavior=0>
<_NSPopoverWindow: 0x7fe84b205590>
<NSStatusBarWindow: 0x7fe85a86d4e0>

Just adding a quick note. It appears what matters is whether reduce transparency is enabled when the popover opens. If we remove the close handler so the popover remains open when it loses focus, pointer event handling continues to behave as it did when the popover was first opened.

Alright I've now got a minimal non-Flutter_ repro for this that suggests this is an AppKit bug rather than a Flutter bug.
I've filed a Radar with Apple and duplicated the contents on OpenRadar: FB12050037.
https://github.com/flutter/engine/pull/40241 adds a workaround that fixes the behaviour in Flutter apps.


Feature Request: Context Menu for Selection

Now that we have onNodeContextMenu(event: MouseEvent, node: Node), it would be cool to have the same also for Multiselections, so something like onSelectionContextMenu(event: MouseEvent, node: Nodes[])
Would be useful e.g. when you want to do actions like deleting or copying Nodes via Contextmenu.

Yep! Good idea :) we will add this feature soon.

added in v5.9.0


onActivityResult and reinitialize mViews state

I have little bug with reinitialize mViews in MvpPresenter.
I need to animate ImageView when start new activity, and animate it again onActivityResult.
But my code works only with delay.
Activity code
public class SplashActivity extends BaseActivity implements SplashView {

    @InjectPresenter
    SplashPresenter mSplashPresenter;
.....
@Override
    public void showLogoAnimation(float rotateFromDegrees, float rotateToDegrees, float pivotXYValue, float fromAlpha, float toAlpha, long duration) {
        RotateAnimation rotateAnimation = new RotateAnimation(rotateFromDegrees, rotateToDegrees, Animation.RELATIVE_TO_SELF,
                pivotXYValue,  Animation.RELATIVE_TO_SELF, pivotXYValue);
        AlphaAnimation alphaAnimation = new AlphaAnimation(fromAlpha, toAlpha);
        AnimationSet animationSet = new AnimationSet(true);
        animationSet.addAnimation(rotateAnimation);
        animationSet.addAnimation(alphaAnimation);
        animationSet.setDuration(duration);
        mLogoImageView.startAnimation(animationSet);
    }

@Override
    protected void onActivityResult(int requestCode, int resultCode, Intent data) {
        switch (requestCode) {
            case REQUEST_LEAD_CODE:
                mSplashPresenter.onLeadActivityResult();
                break;
        }
    }
....
}

InterfaceCode
@StateStrategyType(SkipStrategy.class)
public interface SplashView extends BaseView {
......
void showLogoAnimation(float rotateFromDegrees, float rotateToDegrees, float pivotXYValue, float fromAlpha, float toAlpha, long duration);
}

Presenter code
@InjectViewState
public class SplashPresenter extends BasePresenter<SplashView> {
........
protected void onLeadActivityResult() {
        getViewState().showLogoAnimation(LOGO_END_ROTATE, LOGO_START_ROTATE, LOGO_PIVOT_XY_ROTATE_VALUE, LOGO_END_ALPHA, LOGO_START_ALPHA, LOGO_ANIM_DURATION);
}
....
}

It's auto generated code.
@Override
	public  void showLogoAnimation( float rotateFromDegrees,  float rotateToDegrees,  float pivotXYValue,  float fromAlpha,  float toAlpha,  long duration) {
		ShowLogoAnimationCommand showLogoAnimationCommand = new ShowLogoAnimationCommand(rotateFromDegrees, rotateToDegrees, pivotXYValue, fromAlpha, toAlpha, duration);
		mViewCommands.beforeApply(showLogoAnimationCommand);

		if (mViews == null || mViews.isEmpty()) {
			return;
		}

		for(com.omegar.scoreinpocket.ui_mvp.activity.splash.SplashView view : mViews) {
			view.showLogoAnimation(rotateFromDegrees, rotateToDegrees, pivotXYValue, fromAlpha, toAlpha, duration);
		}

		mViewCommands.afterApply(showLogoAnimationCommand);
	}

In my case mViews.isEmpty true and my code doesn't work.  Function "showLogoAnimation" in activity doesn't call.
mViewCommands
mState =  size = 0
mStrategies =  size = 0
mViews =  size = 0
But if i do it with delay, it's works.  mViews =  size = 1
protected void onLeadActivityResult() {
        new Handler().postDelayed(() -> getViewState().showLogoAnimation(LOGO_END_ROTATE, LOGO_START_ROTATE, LOGO_PIVOT_XY_ROTATE_VALUE, LOGO_END_ALPHA, LOGO_START_ALPHA, LOGO_ANIM_DURATION), 500);
    }

I think mViews initialize not so fast. Has anybody with ideas how to fix it ?

I change StateStrategyType to SingleStateStrategy.class and it's work. Sorry.


Dedicated section for project's system requirements.

Hi there Github team. Would it be possible to add a "resource/system/hardware requirements" section in the menu on the right along with About, Topics, Resources, etc? right under Languages where you could see the cpu, ram , storage, network recommendations from the official project page? It's not always easy to find those informations while they are often very critical. Instead of relying on the projects' official website (if they happen to have one and if they happen to have taken the time to create a web page or section on their website for that), maybe proposing the developers to mark it down on their project's page would be an easy go-to resource and would promote a good culture for the sake of documentation. It would also be really easy for the project's teams to get this important step done without having to plan for an integration on their site. At the same time, if they do not have this information, it could promote the importance of benchmarking of software solutions. Would be even better if this information could be gathered from the API. I think this simple add-on would bring a lot value to Github.
Thanks in advance for your time.

Hi, I believe this is a question about GitHub.com, the website. This issue tracker is for a command-line utility called hub, not the website itself. For reporting bugs and requesting features for GitHub the website, please go to https://github.com/contact or visit https://github.community. Thank you!


about  “data_dict['roi_rgb']”

hello,I would like to use genpose++ in my own projects. I have encountered some problems in use, which may be that I did not understand correctly.
My project is ROS-based, rgb images and depth images come in through topics. However, the original code needs to extract a specific region, which is mentioned in the paper as "employs segmented point clouds and cropped RGB images as inputs". But what I need is to detect an image, so how should I do it? Do I need to segment rgb images and depth images and pass them to genpose++ for detection?

GenPose++ requires the results after instance segmentation as input. You should start by using models like SAM for instance segmentation to generate these masks. Based on these masks, you can then determine the ROIs and use both the masks and the cropped ROIs as inputs for GenPose++ to perform pose estimation.


Doc updates and fixes

+1
FYI : Fixed docs build.

Closing since it looks like #1613 supersedes this PR.
My comments are still relevant though :)

@kami This PR is for master and 1613 is for 0.11.2 - we need both. Reopening.

Ah, sorry, I missed that.
Usually it's easier if we just create one PR against version branch and then merge version branch into master.

Usually it's easier if we just create one PR against version branch and then merge version branch into master.
Ok, will try next time.

@Kami did the fixes on both branches, except one in on_complete.rst as I just want user to quickly test that stuff works there, educate later.


Basic authentication

Is basic authentication supported by zeebe command and worker?

https://docs.camunda.io/docs/self-managed/zeebe-deployment/security/secure-cluster-communication/


[@labs/react] introduce a params object

This PR introduces a params object for the @labs/react package.
Why
API functions that rely on 3+ arguments are typically more difficult to extend as a library matures.
Mainly, param objects eliminate ordering as a concern. Devs can add properties to a params object without ordering creating an arbitrarily awkward experience, they can describe properties in any order.
Since createComponent is called once per component in an application, creating an params object once per component is not very expensive.
How
The params object looks like this:
interface CreateComponentParams<I extends HTMLElement, E extends Events> {
  React: typeof ReactModule;
  tagName: string;
  elementClass: Constructor<I>;
  events?: E;
  displayName?: string;
}

But it could use some review, probably better names.
As in the property name React could be more generic. A dev could use Preact or any compatible JSX pragma. So JSXEngine or similar might be more appropriate.

Isn't the return type just Component<ComponentProps>? (ie, ForwardRef shouldn't change the external type). Can we just extract this into a helper type?:
  // Props the user is allowed to use, includes standard attributes, children,
  // ref, as well as special event and element properties.
  type ReactProps = Omit<React.HTMLAttributes<I>, keyof E>;
  type ElementWithoutPropsOrEvents = Omit<I, keyof E | keyof ReactProps>;
  type UserProps = Partial<
    ReactProps & ElementWithoutPropsOrEvents & EventProps<E>
  >;

  // Props used by this component wrapper. This is the UserProps and the
  // special `__forwardedRef` property. Note, this ref is special because
  // it's both needed in this component to get access to the rendered element
  // and must fulfill any ref passed by the user.
  type ComponentProps = UserProps & {
    __forwardedRef?: React.Ref<unknown>;
  };

@justinfagnani will def try! Dunno why I got stuck on a 1:1 typing. You're correct that should work!


Jenkins Access: sign-builds and installer jobs

ping @karianna
@austin0 and I are unable to see the sign build logs, i.e.  https://ci.adoptopenjdk.net/job/build-scripts/job/release/job/sign_build/10397/ and the installer jobs, i.e. https://ci.adoptopenjdk.net/job/build-scripts/job/release/job/create_installer_windows/6531/
Unfortunately we still aren't able to see sign_builds despite #1492 , not sure if you can see them @adamfarley  ?

@Willsparker - I can.
You need to log in on another ci page first, as it doesn't know who you are until you do so.

If that doesn't work, try leaving all tabs on those pages, clearing browser history, logging in on a general-access ci page, and then going to the sign job.

Just tried it, unfortunately still getting Error 404 with URI: /job/build-scripts/job/release/job/sign_build/

Also unable to access, @adamfarley can you see anything useful in this run from today?

No, because that job ran on Friday (or earlier) and was purged.
The latest run we still have is #10355, which ran on Friday.

You had been granted access to the jobs but not the containing folder (FYI @karianna for next time!)
I have granted @austin0 and @Willsparker access to the folder now.

Excellent, thanks @sxa

Added.


Avoid sending finality notifications unconditionally

During synchronization we might finalize a large number of blocks and we want to avoid spamming listeners with finality notifications.
https://github.com/paritytech/substrate/blob/b57c458587e5e41b785b0197daa00723cccca488/core/finality-grandpa/src/lib.rs#L891-L893

Is this still relevant @andresilva ? I'm assuming not, but if so please reopen.


Extend polling timeout

PR #342 had an unexpected side effect where IDLE_TIMELAPSE started being heeded correctly. So all event polling ran for at most 60s. This is way too little for the offchain worker (that needs to wait possibly for days between jobs), and even for the offchain compute client (that needs to wait for the job to complete).
This PR extends the timeout to the point where it is practically disabled, but given that that is how we operated this whole time, the change should be non-controversial.
Should we do the same in Go?
More context: https://github.com/oasislabs/private-parcel/issues/842

I'll change it to 0 (and implement it being a special value). We can add parametrization later, when/if needed.

Yep, we should port this to go too.
No timeout? I think polling forever if there's a bug is a bad idea

No timeout? I think polling forever if there's a bug is a bad idea

It's not great, agreed. But it's what we've been doing all along.
I'd say the right solution to "what if we poll too much due to a bug" is:

server-side (rate limiting)
something to do in a followup PR.

I'm just restoring pre-#342 behavior to un-break offchain compute.

Opened an issue for go client as well.


Updated link to Event Webhook getting started pg

Previously pointing to just {root_url}
Description of the change:
Reason for the change:
Link to original source:

Closes #

Hello @bhammerquist,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


Update Moldova holidays, localization

Proposed change

Update Moldova holidays, localization (en_US, ro, uk).
Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good (make pre-commit)
[x] I've added tests to verify that the new code works and all tests pass locally (make test, make tox)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

Coverage: 99.884% (+0.0002%) from 99.884% when pulling a35654183c2f7e669ed255b50606b5773f5b1ad3 on KJhellico:upd-moldova into 3cfcbd44715f903b71745aee7aed4565c19ebf0b on dr-prodigy:beta.


Transition: hiding automatically when setState of parent called on mount

Bug Report
Steps

When the child of Transition is a stateful component and is not enclosed by any div in the parent component, hide of transition is not hiding the child but the visible prop is actually false at the moment.
When the child of Transition is a stateful component and enclosed by div in parent component, if any function gets triggered from child's componentDidMount which do a setState in parent, transition is hiding the child but the visible prop is still true.
If unmountOnHide is set true, this auto hide happens after every visible trigger.

Expected Result

Shall hide the child component.
Shall not auto hide on open.

Actual Result

Hide not happening.
Auto closing after making it visible.

Version
0.87.1
Testcase
[Fork, update, and replace this pen to show the bug]:

https://codesandbox.io/s/transitionhideissue-upze1
https://codesandbox.io/s/transitionautocloseissue-lj3km

It's expected, your component should spread props, at least className and style props:
-

+

+ // or

  <Image
    size="small"
    src="https://react.semantic-ui.com/images/leaves/1.png"
   />

This change fixes both examples.

It's expected, your component should spread props, at least className and style props:
-

+

+ // or

  <Image
    size="small"
    src="https://react.semantic-ui.com/images/leaves/1.png"
   />

This change fixes both examples.

Hi, Thanks for helping.
This change didn't fix the 2nd example. Please check
https://codesandbox.io/s/transitionautocloseissue-lj3km

The work around fix I got for this is to call setState after the running execution by putting inside setTimeout with zero delay.
 setTimeout(() => {       this.setState({ name: data.value });     }, 0);

@krajasekhar thanks for the clarification, definitely looks like a bug 🐛

Another workaround that fixes this for me is to use React.memo() HOC in order to prevent unnecessary re-render of the child component, and trigger the unwanted hide

This issue was fixed in<EMAIL_ADDRESS>(#3982) and I can't repro it anymore in linked CodeSandboxes. Please let us know if something still fails.


Experimental Reload browser on server restart

BrowserSync will reload when the server restarts allowing files such as the config.json to be updated and the page to reflect the change without manually refreshing the browser.

Not required


Make phpunit.xml location configureable

Hi,
it would help me a lot if the location of the phpunit.xml file would be configureable. In many of my projects it is located in $basedir/app.

Somewhat related - it is common for projects to also have a default phpunit.xml.dist. This file should be used when a phpunit.xml (usually ignored in VCS) is not found.
This approach that might avoid the need for path configuration (from stuartherbert/sublime-phpunit):

The Sublime-PHP plugin searches the folders upwards from whatever you are trying to test, using the first phpunit.xml or phpunit.xml.dist that it finds. Make sure that your phpunit.xml file is either at the top of your tests folder (or even further up), and this plugin will work for you.

I'll add both options into next version.
The Sublime-PHPUnit option is very interesting, and might be the default behavior in next release.

:+1: For both the .dist and the configurable option.
Auto discovery (like sublime's) would be nice but not a deal breaker :grin:

:+1: should be allow using "-c" PHPUnit  Command Line Option ;)


get_athlete fails with 'The /athletes/{id} endpoint was removed by Strava.

In [17]: a = client.get_athlete(<num>)
---------------------------------------------------------------------------
NotImplementedError                       Traceback (most recent call last)
<ipython-input-17-968412ea03f1> in <module>()
----> 1 steve = client.get_athlete(<num>)

/home/joel/dev/strava/.venv/lib/python3.6/site-packages/stravalib/client.py in get_athlete(self, athlete_id)
    235             raw = self.protocol.get('/athlete')
    236         else:
--> 237             raise NotImplementedError("The /athletes/{id} endpoint was removed by Strava.  "
    238                                       "See https://developers.strava.com/docs/january-2018-update/")

Apologies. Github misbehaved and I ended up with two issues opened. See #172


[GHSA-v3hp-mcj5-pg39] HashiCorp Vault and Vault Enterprise versions 0.8.0...

Updates

Affected products
CVSS
CWEs
Severity
Summary

Comments
The CVSS score was incorrect

Hi @oxeye-daniel, thank you for the information about GHSA-v3hp-mcj5-pg39/CVE-2023-0620. The National Vulnerability Database hasn't published its assessment of severity yet, which we like to check before putting a CVSS onto an advisory, but you'll still get credit for contributing a title, a CWE, and a patched version.

Thanks for the contribution @oxeye-daniel -- I'm currently troubleshooting the Processing advisory improvement check and closed and reopened the PR to make sure it was processed

For this contribution, Shelby published this out manually and I've manually added the advisory credit for your user on https://github.com/advisories/GHSA-v3hp-mcj5-pg39 . I'm re-closing the PR now, thanks again!

Thanks! Could you please also credit Gal Goldshtein (gal@oxeye.io)?


Convert to Sol modal presents terrifying number.

Describe the bug
Modal to convert HNT to SOL seems to be missing a decimal

To Reproduce
Steps to reproduce the behavior:

have not enough sol
claim rewards

Device: [e.g. iPhone14]
App Version v2.2.0

This will be fixed when the Jupiter swap goes live, it's in that PR.


Anvil file support (blocks and biomes)

This is a starting point for the valence_anvil crate.
It currently supports loading blocks and biomes.
Note on negative Y values:
Since UnloadedChunk does not support negative Y values, all parsed Y values are raised to Y=0.
Before merging, make sure the changes from https://github.com/valence-rs/valence/commit/03e89adeb8fc286ef24b1e21f5c78908276fef18 are uploaded to crates.io and the version number is set in Cargo.toml

Something worth mentioning: When loading chunks, especially with larger view distances, I notice (significant) stuttering while flying around in the java_region.rs example.
This is room for improvement and should be looked into. This PR is a start, but at least we have more functionality than yesterday.

When loading chunks, especially with larger view distances, I notice (significant) stuttering while flying around in the java_region.rs example.

Is the stuttering client side? I recall someone discovering their game was lagging because valence is not sending any light data. If the light data is filled with zeroes instead, the lag was eliminated.

Game crashed while flying around with this.
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: NbtFormatError(MissingKey("Status"))', valence_anvil/examples/java_region.rs:152:69
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Flying out of bounds, I found this. All the lava blocks are in the corner of the chunk, at index 0 of some array I assume.

And there was also this. That row of stone blocks is not supposed to be there.

Rather than just speculating about performance as I've done, I think it would be a good idea to set up a benchmark in performance_tests/. The benchmark could involve loading a large anvil world in one go and measuring how long it takes.

Quite possible that this is entirely my fault.

It was not! Fixed in https://github.com/valence-rs/valence/pull/145/commits/8db39c72235f7bbd59134c9b022c829921745c23 :)

When loading chunks, especially with larger view distances, I notice (significant) stuttering while flying around in the java_region.rs example.

Is the stuttering client side? I recall someone discovering their game was lagging because valence is not sending any light data. If the light data is filled with zeroes instead, the lag was eliminated.

That explains it! I installed a client-side mod to optimize lighting calculations and the stuttering is gone completely. There is currently not a way for me to add lighting data to UnloadedChunk, right? :thinking:

There is currently not a way for me to add lighting data to UnloadedChunk, right?
Yeah it needs to be done in valence.

Benchmark result from my machine for future reference:
Load square 10x10       time:   [140.07 ms 140.62 ms 141.16 ms]

Here are some things I would like to see before we merge:

The structure of biome.json should match the items in the biome registry. https://github.com/valence-rs/valence/blob/main/src/biome.rs#L59-L123
tokio does not need to be used and can be removed.

There are some API things we should figure out and some issues related to loading partially generated chunks, but let's not worry about that until after we merge.

Thanks for the feedback! I see you made a lot of changes and it does look a lot better now.


Make integration tests work with Phase 2 changes

At least common should work.

Fixed by Luca and me. :+1:


Feature/iiwa 41

Changes to the style of the NavBar

I pulled this branch down to take a look locally and it appears that you may have installed some packages (like react-router-dom) but you did not commit your changes to package.json or package-lock.json. Definitely commit those changes any time you add a new package - that way if other devs pull your branch down they can install all of the newly added packages with a simple npm i.

Couple style suggestions - you should add a cursor: pointer property to your labels so that the mouse appearance is consistent no matter where in in a navtab the mouse moves. You also might consider making the "back side" of the little foldy part (the ellipse) a slightly lighter or darker shade of gray than the inactive tabs so the design is a bit more clear when Dashboard is not the active tab.


unknown support for 'array-type'

Bug Report

TSLint version: 5.11.0
TypeScript version: 3.0.1
Running TSLint via: CLI

TypeScript code being linted
const a: unknown[] = [];

with tslint.json configuration:
{
  "rules": {
    "array-type": [true, "array-simple"],
  }
}

Actual behavior
TSLint recommends Array<unknown> instead of unknown[].
Expected behavior
unknown[] is considered a simple type and thus be preferred over Array<unknown>.

We should definitely accept the unknown type as a simple type. Happy to review a PR for this.

Since unknown was added in Typescript 3.0.0, how to add this rule with backwards compatibility?


Fix xiaomi gateway disappearing and builtin light/sensor updates

Description:
Related issue (if applicable): fixes #20329 #20383
This fix addresses next issues:

Gateway disappearing after 2.5 hours of HA uptime
Built-in illumination sensor updates only once (at restart of HA)
Built-in light switch works incorrectly

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @stsergo,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Can confirm code working with setup of 3 gateways.

Sorry for the noob question, I'd like to test it but how can I apply this fix in hassio? SSH or simply activating the beta repository?
Thank you

At the moment the component parses a multicast messages (gw ip -> <IP_ADDRESS>:9898). We could call it "local push". This code change implements polling. It requests the current state of a sensor periodically (via udp). The gateway responds with a unicast message (gw ip -> home assistant ip). For bad networks with broken multicast support this will help somehow. I'm unsure if it's a good change or not. ;-)

At the moment the component parses a multicast message (gw ip -> <IP_ADDRESS>:9898). We could call it "local push". This code change implements polling. It requests the current state of a sensor periodically (via udp). The gateway responds with a unicast message (gw ip -> home assistant ip). For bad networks with broken multicast support this will help somehow. I'm unsure if it's a good change or not. ;-)

My gateway sends only ip in heartbeat messages.
So there is no way to get sensors state without request it.
Example:
U <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898 #12
  {"cmd":"heartbeat","model":"gateway","sid":"04cf8c91566f","short_id":"0","token":"KknlKETfDUbAQEUa","data":"{\"ip\":\"<IP_ADDRESS>\"}"}
#
U <IP_ADDRESS>:48879 -> <IP_ADDRESS>:9898 #13
  { "cmd":"read","sid":"4cf8c91566f"}
#
U <IP_ADDRESS>:9898 -> <IP_ADDRESS>:48879 #14
  {"cmd":"read_ack","model":"gateway","sid":"4cf8c91566f","short_id":0,"data":"{\"rgb\":0,\"illumination\":708,\"proto_version\":\"1.1.2\"}"}```

I am not sure if this is a good idea.
It should at least be configurable, and not the default behavior.

My gateway sends only ip in heartbeat messages.
So there is no way to get sensors state without request it.

Which hardware version of the gateway do you own? It looks like a lumi.v3 with LAN protocol version 1.1.2. I assume there is something wrong with your network.
So there is no way to get sensors state without request it.

Which hardware version of the gateway do you own? It looks like a lumi.v3 with LAN protocol version 1.1.2. I assume there is something wrong with your network. Your log should look like this (without any requests):
2019-01-05 21:32:44 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'model': 'motion', 'sid': '158d0001aea71a', 'cmd': 'report', 'data': '{"no_motion":"180"}', 'short_id': 9483}

You are right -  lumi.v3 with LAN protocol version 1.1.2
For now my setup is only gateway without any sensors connected to it.
Network setup simple as possible: Apple time capsule as wifi and router. HA at lan, gateway on wifi. No VLANS, no segments.
Due to apple bonjour works as expected I consider that there is no issues with multicast. I also check connectivity by omping tool from my linux laptop and there is no issues also.
My gateway send nothing about built-in sensors until we ask :(
Connected sensors work OK, as I can see from community discussions.

@stsergo This is the multicast message of the gateway. It publishs the state of the light and illumination sensor every 60 seconds:
2019-01-05 18:38:03 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'model': 'gateway', 'sid': '34ce0088db0b', 'cmd': 'report', 'data': '{"rgb":0,"illumination":371}', 'short_id': 0}
2019-01-05 18:38:03 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Illumination_34ce0088db0b: 273.0>: {'illumination': 371, 'rgb': 0}
2019-01-05 18:38:03 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Gateway Light_34ce0088db0b: off>: {'illumination': 371, 'rgb': 0}
2019-01-05 19:37:55 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'model': 'gateway', 'sid': '34ce0088db0b', 'cmd': 'report', 'data': '{"rgb":0,"illumination":371}', 'short_id': 0}
2019-01-05 19:37:55 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Illumination_34ce0088db0b: 71.0>: {'illumination': 371, 'rgb': 0}
2019-01-05 19:37:55 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Gateway Light_34ce0088db0b: off>: {'illumination': 371, 'rgb': 0}
2019-01-05 20:37:48 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'model': 'gateway', 'sid': '34ce0088db0b', 'cmd': 'report', 'data': '{"rgb":0,"illumination":372}', 'short_id': 0}
2019-01-05 20:37:48 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Illumination_34ce0088db0b: 71.0>: {'illumination': 372, 'rgb': 0}
2019-01-05 20:37:48 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Gateway Light_34ce0088db0b: off>: {'illumination': 372, 'rgb': 0

@stsergo This is the multicast message of the gateway. It publishs the state of the light and illumination sensor every 60 seconds:
2019-01-05 18:38:03 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'model': 'gateway', 'sid': '34ce0088db0b', 'cmd': 'report', 'data': '{"rgb":0,"illumination":371}', 'short_id': 0}
2019-01-05 18:38:03 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Illumination_34ce0088db0b: 273.0>: {'illumination': 371, 'rgb': 0}
2019-01-05 18:38:03 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Gateway Light_34ce0088db0b: off>: {'illumination': 371, 'rgb': 0}
2019-01-05 19:37:55 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'model': 'gateway', 'sid': '34ce0088db0b', 'cmd': 'report', 'data': '{"rgb":0,"illumination":371}', 'short_id': 0}
2019-01-05 19:37:55 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Illumination_34ce0088db0b: 71.0>: {'illumination': 371, 'rgb': 0}
2019-01-05 19:37:55 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Gateway Light_34ce0088db0b: off>: {'illumination': 371, 'rgb': 0}
2019-01-05 20:37:48 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'model': 'gateway', 'sid': '34ce0088db0b', 'cmd': 'report', 'data': '{"rgb":0,"illumination":372}', 'short_id': 0}
2019-01-05 20:37:48 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Illumination_34ce0088db0b: 71.0>: {'illumination': 372, 'rgb': 0}
2019-01-05 20:37:48 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Gateway Light_34ce0088db0b: off>: {'illumination': 372, 'rgb': 0

Mine sent only ip :(
What version of firmware do you have? I have 1.4.1_164.0158 out of box.
And how this traffic looks in ngrep?

@stsergo This is the multicast message of the gateway. It publishs the state of the light and illumination sensor every 60 seconds:
2019-01-05 20:37:48 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'model': 'gateway', 'sid': '34ce0088db0b', 'cmd': 'report', 'data': '{"rgb":0,"illumination":372}', 'short_id': 0}

I mixed things up: The message is called report.

Is it possible that some firmwares don't send that message and still it's working in HA? I don't see that in log, maybe I don't have enough debugging turned on? Should I see it in meanwhile of normal traffic?

Got it! It's a firmware issue. Firmware version 1.4.1_164.0158 doesn't publish the report message of the gateway anymore. There are some report message but the one of the gateway is missing:
#
U <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898
  {"cmd":"report","model":"motion","sid":"158d000119fd8c","short_id":56278,"data":"{\"no_motion\":\"300\"}"}
#
U <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898
  {"cmd":"report","model":"sensor_motion.aq2","sid":"158d00016dc0d8","short_id":14573,"data":"{\"lux\":\"122\"}"}
#
U <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898
  {"cmd":"report","model":"sensor_motion.aq2","sid":"158d00016dc0d8","short_id":14573,"data":"{\"status\":\"motion\"}"}
#

In this case polling is a workaround.

I'm running latest (at least as of yesterday):
#
U 192.168.x.x2:4321 -> <IP_ADDRESS>:9898
  {"cmd":"heartbeat","model":"gateway","sid":"7811dcdad7a3","short_id":"0","token":"hoFklTtWx9Pxxx","data":"{\"ip\":\"192.168.x.x2\"}"}
#
U 192.168.x.x0:4321 -> <IP_ADDRESS>:9898
  {"cmd":"heartbeat","model":"gateway","sid":"34ce008c0674","short_id":"0","token":"7ABTqZJM6tsxxx","data":"{\"ip\":\"192.168.x.x0\"}"}
#
U 192.168.x.x1:4321 -> <IP_ADDRESS>:9898
  {"cmd":"heartbeat","model":"gateway","sid":"34ce008c136a","short_id":"0","token":"VikVbxsquqf2xxx","data":"{\"ip\":\"192.168.x.x1\"}"}
#

Those are the heartbeats, right?
GW itself identifies as lumi.v3 but some time ago it was lumi v2 (?) and protocol in APP changed from LAN to WiFi (mihome).

@andriej This is the message we are looking for:
# 'cmd': 'report'
{'model': 'gateway', 'sid': '34ce0088db0b', 'cmd': 'report', 'data': '{"rgb":0,"illumination":573}', 'short_id': 0}

You've posted the heartbeat used for key rotation. I've mixed this two messages types up in the past.

Then I can see those in ngrep:
U <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898
  {"cmd":"report","model":"gateway","sid":"7811dcdad7a3","short_id":0,"data":"{\"rgb\":0,\"illumination\":681}"}
#

Edit2:
Can confirm, they are not reporting that very often. Should be option to poll (gateways).

I moved my gateway away from dark room. Reports have really random gaps between.
U 2019/02/19 15:11:32.990091 <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898 {"cmd":"report","model":"gateway","sid":"04cf8c91566f","short_id":0,"data":"{\"rgb\":0,\"illumination\":558}"}
U 2019/02/19 15:24:35.336748 <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898 {"cmd":"report","model":"gateway","sid":"04cf8c91566f","short_id":0,"data":"{\"rgb\":0,\"illumination\":495}"}
U 2019/02/19 15:49:42.186527 <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898 {"cmd":"report","model":"gateway","sid":"04cf8c91566f","short_id":0,"data":"{\"rgb\":0,\"illumination\":433}"}
U 2019/02/19 15:55:21.450549 <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898 {"cmd":"report","model":"gateway","sid":"04cf8c91566f","short_id":0,"data":"{\"rgb\":0,\"illumination\":402}"}
U 2019/02/19 16:55:13.832239 <IP_ADDRESS>:4321 -> <IP_ADDRESS>:9898 {"cmd":"report","model":"gateway","sid":"04cf8c91566f","short_id":0,"data":"{\"rgb\":0,\"illumination\":323}"}

@Danielhiversen

I am not sure if this is a good idea.
It should at least be configurable, and not the default behavior.

Why?

Do you own the 'new' hardware gateways with new firmware and have another working solution?
Does it break existing setups with this new default behavior?
Do you have any information present that the 'broken' firmware will be fixed soon by Xiaomi? Do they have any reason to 'fix' the current behavior? There seems none; everything works fine in their app..
Is there an EASY way for (new) users (using hassio) to change this behavior*?

If all are answered with: 'no' then I urge you to reconsider...

i have been searching on how to change this behavior and found no clue on how to do this in hassio except for
(1) adding a 'custom_components' folder to config. But this is no custom component, it is part of the system!
(2) do a complete classic (re)install
So how.....?

Quickie; Firmware 1.4.1_167 came out. Updated one of my gateways to test if this fixed current issue. Not so; behavior remains the same. We need this fix...

This would supposedly fix this https://github.com/home-assistant/home-assistant/issues/21250 right? I'm currently running Hassio on VM and doesn't work correctly the sensors (sometimes it does sometimes it doesn't). However running Hassio on my pi3 works perfect.
Is there a way I can apply this to Hassio to test it out?

Hope for the fix in hassio

I have a theory...One thing I have noticed, and including myself, is that the people who appear to have most problems all have MAC address of the gateway starting 04:XX:XX:XX:XX:XX.
When I get updates from a sensor, I can see in the debug these appearing as a PUSH and the sensor gets updated.
2019-02-24 20:24:33 DEBUG (Thread-23) [xiaomi_gateway] MCAST (heartbeat) << {'model': 'sensor_ht', 'sid': '158dXXXXXXXXXX', 'cmd': 'heartbeat', 'short_id': 63981, 'data': '{"voltage":2985,"
temperature":"1845","humidity":"5269"}'}
2019-02-24 20:24:33 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Humidity_158dXXXXXXXXXX: 52.7>: {'voltage': 2985, 'temperature': '1845', 'humidity': '5269'}
2019-02-24 20:24:33 DEBUG (MainThread) [homeassistant.components.xiaomi_aqara] PUSH >> <Entity Temperature_158dXXXXXXXXXX: 18.4>: {'voltage': 2985, 'temperature': '1845', 'humidity': '5269'
}
However when I get an illumination update from the gateway I don't get the corresponding PUSH debug message.
2019-02-24 20:20:27 DEBUG (Thread-23) [xiaomi_gateway] MCAST (report) << {'model': 'gateway', 'sid': '04XXXXXXXXXX', 'cmd': 'report', 'short_id': 0, 'data': '{"rgb":1694434079,"illumination
":336}'}
One thing I notice that the entity_id that home assistant set up, is
sensor.illumination_4XXXXXXXXXX
and
light.gateway_light_4XXXXXXXXXX
thus missing the leading zero.
Could this be causing a mismatch between the SID being broadcast and the HA entitiy?

Superseded by #21453.


Make SQL strings generated from Exprs even "prettier"

Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/9494
In https://github.com/apache/datafusion/pull/10573 @goldmedal  made  expressions from the DataFusion SQL unparser (aka expr --> String) nicer. However there are still certain cases where the rendering will err on the side of explicitness rather than (human readability()
For examoke, it puts in quotes to make the order of operations explicit -- so instead of a < 5 AND b < 10 it would render ("a" < 5) AND ("b" < 10)
The current unparser is conservative and likely works well for when generating SQL for consumptions by other database systems. It could be nicer for generating SQL to read by humans
Describe the solution you'd like
If we want to make the generated SQL easier to read by humans / more succinct, these steps will have to be made "smarter".
Describe alternatives you've considered

We'll have to add in the math rules (precidence) to avoid unneeded parentheses. These rules typically vary subtly between dialects.

We could simply not do this item as well as it is likely hard to get right and maybe extra parens aren't all that bad 🤔

Additional context
No response

I think this can be closed now @alamb

Good call -- thanks @MohamedAbdeen21


Suggestion: Push HTTP2 Preload/Preconnect headers

It would be awesome pagespeed working HTTP/2 hints.
JS/CSS merges could be pushed by preload header increasing page performance.
If you want to push static files today you must to disable merges and all rename options.
After you need to manually load the output content in order to push links and scripts.
And that would be an easy job for pagespeed.
Well thats my suggestion.
Thanks and have a nice week.

Sorry! Duplicated #1158


EnvoyFilterUsesReplaceOperation new flaky test

Root cause https://github.com/istio/istio/pull/38389
Examples https://prow.istio.io/view/gs/istio-prow/logs/unit-tests_istio_postsubmit/1523665851696287744
See https://github.com/istio/istio/wiki/Test-Flakes#reproducing-test-flakes

Ah, you beat me to it. Can we roll back for now?

Still broken with https://github.com/istio/istio/pull/38862


Add points layer in GUI

Description:
Add a button to add a points layer (scatter plot) in the GUI:

[x] Add as many as the user wants
[x] Centroids
[x] Weighted centroids
[x] Custom x, y, (z) from table
[x] Choose colour
[x] Allow hide/delete

[ ] Allow manual entry additional option


Updated mainapp.config for 200qx and 210qc airframes (based off the g…

…eneric flight version)

Continued and rebased here: https://github.com/PX4/Firmware/pull/5582


Add translations

This is needed for my follow-up PR to https://github.com/typst/typst/pull/3094.
Is the file extension the correct one, or would you prefer a different one? The files are also valid Fluent (.ftl) files, but I think it might be confusing to use the ftl extension if we aren't using Fluent for now.

Sidenote, if not intentional: CI isn't set up yet in this repository.

As mentioned in https://github.com/typst/typst/pull/3728, the strings should live in typst/typst, so I'll close this.


Fix issue #359

Fixes issue #359 by removing an unnecessary border in a nested table.

Fixed in dev branch.


Minor changes from Issue 243 (adding integer types) that didn't make it into PR 244

This PR contains some rewording agreed towards the end of issue #243 discussion that I evidently never pushed to PR #244 .
@erget - You were the moderator on #243. Sorry for the confusion. I will reopen #243 and link to this PR. Maybe we restart the 3-week count down?
Release checklist

[x] Authors updated in cf-conventions.adoc?
[x] Next version in cf-conventions.adoc up to date? Versioning inspired by SemVer.
[x] history.adoc up to date?
[ ] Conformance document up-to-date?

For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then master always is a draft for the next version.

@ethanrd yes I'm happy to jump in (I've been quiet but this is only because most of my CF efforts have been focused on advancing https://github.com/cf-convention/discuss/issues/37 - I'm still around ;) )
These are straightforward changes that I believe we can class as a defect. Barring objections, I will merge this on 2020-09-22.

Thanks @erget


MSID: 89644 Version: 2 DOI: 10.1101/2<IP_ADDRESS>9898

MSID: 89644
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>9898
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=89644
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>9898

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/89644v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>9898
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/89644/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Caroline Habold missing correspondence email
too many references with duplicate content or incorrect formatting, screenshots in zip file
Archive.zip

@rkcook312, this one is a mess! Thanks for your help in identifying all those issues. I've attempted to catch them all. There'll still be some issues in the refs which are the result of platform issues. These mostly affect theses, e.g.:

and books, e.g. (missing publisher name):

These are issues that stem from Encoda and/or EPP, with poor support for any references that aren't journal ones.
Note that I also removed the nonsensical labels that the authors added (there were two sections with the label 4, and they went in the order 1, 2, 4, 3, 4).
Anyway - let me know if spot any further issues!

Thanks @fred-atherden for fixing these, all good to publish.


KAFKA-7549: Old ProduceRequest with zstd compression does not return error to client

As of current version (2.1.0), zstd-related validations are located in following spots:

ProduceRequest

MemoryRecordsBuilder: can't create MemoryRecords with magic < 2 (IllegalArgumentException)
ProduceRequest.Builder: can't create ProduceRequest with api version below 7 (InvalidRecordException)

FetchRequest

KafkaApis#handleFetchRequest: Returns FetchResponse w/ Errors#UNSUPPORTED_COMPRESSION_TYPE if ...

FetchRequest w/ API version < 10 is delivered to a zstd-compressed topic.
Down-conversion failure: LazyDownConversionRecords#makeNext → RecordsUtil#downConvert throws UnsupportedCompressionTypeException.

Etc

AbstractLegacyRecordBatch.DeepRecordsIterator: A boilerplate validation for legacy record batches.

In short, there is no broker-side validation for ProduceRequest w/ zstd compressed records. This PR compensates this hole.
There is a reason why this validation can't be located in other class, e.g., LogValidator: it can't see the API version of ProduceRequest. The only method that can check both of CompressionType and API version is KafkaApis#handleProduceRequest; it's why.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Then, is this alright?

Here is the update. Since ProducerRequest#validateRecords modifies the internal state of ProducerRequest (i.e., idempotent and transactional), I first separated that logic into ProducerRequest#setFlags and then turned ProducerRequest#validateRecords into static method. KafkaApis#handleProduceRequest now validates ProducerRequest with ProducerRequest#validateRecords.
+1. Now ProducerRequest#validateRecords throws UnsupportedCompressionTypeException when it violates zstd condition.
+2. This update also includes rebasing upon the latest trunk.

@dongjinleekr Thanks, I think the fix looks good. I am wondering if it is possible to create a test case in kafka.server.ProduceRequestTest to verify that we receive the expected error code when zstd is used in older versions?

@hachikuji No problem. I will complete it by this weekend.

Here is the update with rebasing upon the latest trunk. In this update, I added a method to go around the validation logic for unit testing(commit #
c23db83). I know this approach is a little bit dangerous but could not find any other good alternative.

Here is the update with rebasing upon the latest trunk. In this update, I added a method to go around the validation logic for unit testing(commit c23db83). I know this approach is a little bit dangerous but could not find any other good alternative.

@hachikuji I greatly appreciate your help. :+1:


revert(current): revert current() handling

Revert for fixing current() API. #51

hi @francescotescari, please confirm this PR. Thanks.


gift

So here the user has entered otp to accept the gift but the CTA is not active.
again he has to remove kepad and accept gift

it can be improved as per usability


[Feature]  Reduce EC2 number

Summary - What problem does this feature solve?
Deploy mock server on E2E EC2, can reduce this issue
Expectations
Deploy mock server on e2e ec2

close with action: #2059


fix wrong word eclipse to elapsed

What is the purpose of the change
fix wrong word
Brief changelog
fix wrong word eclipse to elapsed
the word is at org.apache.rocketmq.common.ServiceThread.java
Verifying this change
use elapsed instead

@hzdavid thanks for your pr, Could you rebase your commits, I have seen so many other branch merged info. It would be helpful if you redo the pr.