ext: hal: nordic: Update nrfx to version 1.1.0

Updates nrfx to the recently released version.
This version introduces a new HAL for the RADIO peripheral (contained
in the "nrf_radio.h" file) and this HAL replaces the one temporarily
copied to the "nrfx/hal" folder in the Zephyr source tree (see commit
619790a9bcb3a6fea7a91af24007eba6404c1a2b). The nRF 802.15.4 radio
driver ("nrf_drv_radio802154.c") is updated accordingly to reflect
the changes between these two RADIO HAL implementations.
Origin: nrfx
License: BSD 3-Clause
URL: https://github.com/NordicSemiconductor/nrfx/tree/v1.1.0
commit: 293f553ed9551c1fdfd05eac48e75bbdeb4e7290
Purpose: Provide peripheral drivers for Nordic SoCs
Maintained-by: External
Signed-off-by: Andrzej Głąbek<EMAIL_ADDRESS>

@aescolar

Codecov Report

Merging #8406 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8406   +/-   ##
=======================================
  Coverage   64.61%   64.61%
=======================================
  Files         421      421
  Lines       40296    40296
  Branches     6803     6803
=======================================
  Hits        26037    26037
  Misses      11126    11126
  Partials     3133     3133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391cf42...7062b21. Read the comment docs.

@kl-cruz is this OK with you?

Checking...


Add point cloud client.

This PR adds a point cloud client capable of dealing with multiple octrees in the same coordinate frame. In addition, a factory is passed which can be extended to handle octrees coming from other sources than local or grpc.

@wally-the-cartographer merge

@cschuet Can you please reactivate wally and/or merge? Thanks a lot!


[Bug] Fixed CameraView Shutter not responding

Description of Change

Bugs Fixed

Fixes #1442

API Changes

Behavioral Changes

Use the same photoCaptureDelegate when taking multiple photos.
PR Checklist

[ ] Has a linked Issue, and the Issue has been approved
[ ] Has tests (if omitted, state reason in description)
[ ] Has samples (if omitted, state reason in description)
[ ] Rebased on top of main at time of PR
[ ] Changes adhere to coding standard

[ ] Updated documentation

@jfversluis @pictos I have pushed a fix for the CameraView shutter not responding issue, could you please have a look when you have a chance?

I don't have iOS device... @AndreiMisiukevich can you also take a look at this one, if it's possible.

@jfversluis @AndreiMisiukevich @pictos is there someone else that we can add as a reviewer of this fix? Also, please let me know if the description or even the fix itself is missing something. Happy to fix or add any extra necessary info. Thanks in advance 👍

In the issue there is talked about that this also happens on Android, but this fixes iOS, is that correct?

@jfversluis hey mate, thanks for checking this PR. About the issue on Android, yes, it happens on Android as well, but it's harder to reproduce. I couldn't find the issue yet, but now I can focus on Android and try to fix it.


SEAL not compiling with nvcc

Hey everyone,
I am trying to add just the basic seal header file to a .cu file to compile in nvcc. I want to use SEAL in my CUDA code. For now, the cuda code is just a basic sample code and I am just adding the "seal/seal.h" header.
I am using Ubuntu 16.04, gcc-9, nvcc v11.3.58 and the newest SEAL 3.6.4. The following is my cmakelists file:
`# Cmake config for CUDA+SEAL test
Cmake version
cmake_minimum_required(VERSION 3.9 FATAL_ERROR)
Define project
project(test_cmake LANGUAGES CXX CUDA)
add_library(test_cmake STATIC
seal_helper.h
main.cu
)
C++ standard
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED True)
Cuda standard
set(CMAKE_CUDA_STANDARD 17)
set(CMAKE_CUDA_STANDARD_REQUIRED True)
set(CMAKE_CUDA_FLAGS "${CUDA_NVCC_FLAGS} -rdc=true -lcudadevrt -v")
find_package(SEAL 3.6 REQUIRED)
target_link_libraries(test_cmake SEAL::seal)
target_compile_features(test_cmake PUBLIC cxx_std_17)
set_target_properties( test_cmake
PROPERTIES CUDA_SEPARABLE_COMPILATION ON)
set_target_properties( test_cmake
PROPERTIES POSITION_INDEPENDENT_CODE ON)
set_target_properties( test_cmake
PROPERTIES CUDA_ARCHITECTURES "52;"
)
#add_executable(test_cmake_exec main.cu)`
The error I am getting is as follows:
test-cmake/lib/SEAL-3.6.4/include/SEAL-3.6/seal/dynarray.h: In instantiation of ‘void seal::DynArray::reserve(std::size_t) [with T = long unsigned int; std::size_t = long unsigned int]’:
test-cmake/lib/SEAL-3.6.4/include/SEAL-3.6/seal/plaintext.h:206:25:   required from here
test-cmake/lib/SEAL-3.6.4/include/SEAL-3.6/seal/dynarray.h:430:19: error: ‘__T0’ was not declared in this scope; did you mean ‘_y0’?
430 |             auto new_data(util::allocate(capacity, pool));
I have been stuck on this for a while now. I have disabled all optional dependencies for SEAL and built it using -std=c++17 in Release mode.
Any help would really be appreciated!!
Thanks!

I have not tried to include seal.h in a CUDA project since version 3.2. From the error message it seems to be caused by gcc or standard library. There could be many possible reasons. I'm just listing some ideas.

Build SEAL and your project with c++14 and see if it works fine. I'm not up-to-date with c++17 support in CUDA, but believe that it is not 100%.
gcc-9 is too new for Ubuntu 16.04. CUDA and NVIDIA driver might only work with certain versions of gcc on Ubuntu 16.04. Does other CUDA projects build fine, e.g. CUDA examples?
Also if you CUDA was built with gcc-7 and then you use gcc-9 to build CUDA projects, similar error can occur, due to a mismatch of gcc versions. So check whether the version of gcc used to build this project is the same version use to build CUDA and SEAL.


Adding notebook example exploring NSynth

Includes a readme and a notebook file inside demos/nsynth.

Few more quick nits:

You can change the link to the blog post to magenta.tensorflow.org/nsynth-fastgen
Maybe add a link to download the wavenet checkpoint http://download.magenta.tensorflow.org/models/nsynth/wavenet-ckpt.tar

Besides that, LGTM


input type date validation

Hi ,
I tried to used an input  with type date in templateOptions and a max today date . I found validation not working correctly when insert
data without chosed from picker

validation in picker working correctly

Hi,
could you please provide a reproduction, here is our stackblitz starter example:
https://stackblitz.com/edit/ngx-formly-ui-bootstrap
Thanks!


typo: windwos

done

Pls sign the CLA in order for the PR to be reviewed.
more info
https://github.com/kubernetes/community/blob/master/CLA.md

any possible to use the Github privacy email? or it be sure the real email for commits

Hey there! @MittWillson, looks like you haven't signed the CLA yet. Could I please have you do that? https://github.com/kubernetes/community/blob/master/CLA.md

Hey there! @MittWillson, looks like you haven't signed the CLA yet. Could I please have you do that? https://github.com/kubernetes/community/blob/master/CLA.md

Hi, So sorry reply you so late, this commit pushed with github private email, maybe that's way can't verify CLA, is there a way to bind private email to CLA?

@MittWillson I'm closing this one. Please try submit the PR using the email you used for CLA and see if things will work.

/close


updated to include listing tables & columns

Describe your changes
Added a "Listing Tables" and "Listing Columns" section at the bottom of the file. These sections demonstrate the steps needed to listing tables or columns from .csv and .parquet files.
I wasn't sure if this addition should have been included in the change log or not. Please let me know what you think and I'd be happy to make any necessary changes.
Issue ticket number and link
Closes #221
Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have added thorough tests (when necessary).
[ ] I have added the right documentation in the docstring and changelog (when needed)

:books: Documentation preview :books:: https://jupysql--227.org.readthedocs.build/en/227/

Got it! Thanks for the input.


[3.0-Alpha] Normalmap Importing (s3tc.stex) not working on certain Normal Map Textures in 3D graphics.

Operating system or device - Godot version:
3.0 Alpha Source Code Build, Windows 10 Pro, Wacom Cintiq Companion 2
Issue description:
I was trying to import a normalmap onto an object to test the PBR shading, but unfortunately, somewhere during the import process, the s3tc.stex didn't import the texture the right way...
This link shows a screenshot with cut pieces attached of what I am talking about

The engine somehow hasn't read or imported the normalmap correctly and now the object is completely glitched. In the resource tab the imported normalmap looks glitched in the preview, and the inspector editor isn't loading the normalmap texture.
Steps to reproduce:
I've included the albedo, roughness, rim, and normalmap textures so then you can see if you're seeing the same problem.

In an empty scene, create a WorldEnvironment Node and add a panorama .exr or .hdr texture.
Add a Mesh Instance Node and create either a cube, cylinder, or etc in the "Mesh" option.
Create a SpatialMaterial in the Materials slot, and start adding the attached textures to the object.

Let me know if you're having the same problem, because I think either I did something wrong with the normalmapping or that the import process needs a tweak for normalmapping.

Isn't this a dupe of #9267?

Maybe, but this is a different outcome for me. Nonetheless I just wanted to point out what I encountered just so then I hopefully wasn't the only one witnessing this bug.

I didn't know there's an alpha build yet 🤔

It was a source code compilation using scons. Sorry. I should have elaborated on that.

UPDATE, I realized that one of the older 3.0 builds actually managed to load Normals appropriately:
https://github.com/godotengine/godot/tree/47b34bf79be1ba2fe4a99c8931732efac68a0b87
The link to the Tree build where Reduzio released a patch for Intel based computers: "Remove error spam on Intel, closes #8665" Allows the engine to read, load, and convert the Normals correctly into the s3tc.stex and other stex files.
With that in mind, was there any difference between this build and the most recent patch update that caused the Normalmaps to be glitched out in s3tc.stex files?

git bisect, anyone? 😃

QUICK UPDATE: I have successfully narrowed down where the glitch was occurring using the git bisect that @bojidar-bg suggested. According to the narrowed down results, the glitch occurred in this commit:

[b19225bfce3dab39f8ce6b1ecf610ea0ba650f99] -Fix freezes caused by etccomp2, closes #9183 -Normalmaps are now detected and imported as RGTC, both in S3TC and ETC2, this improves their quality.

Somehow this patch caused the normalmap glitch to occur, can somebody confirm this and that which files are affected?

Ping @reduz, @tagcup. I assume this is caused by the "Detect normalmaps" part 😄

Oh, I actually had nothing to do with the normal map detection part so best ping @reduz I'll try to take a look too

this is fixed now, closing


fix: Correctly parse all dict-likes in executors

ResourceScopes, a subclass of UserDict (not dict), was getting parsed as a regular iterator, not a dict, so only the keys were being passed on.
Resolves #1968
Description

QC

[x] The PR contains a test case for the changes or the changes are already covered by an existing test case.
[x] The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

Something went wrong in the tests... I'll figure that out and merge


add templated fields

Signed-off-by: Issif<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:
This PR introduces new fields that can be added to events, they use go template and output_fields values. See #329 for more details.
Which issue(s) this PR fixes:
#329

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 860b25a68fd51d8c55e084f02d86564a64bb6734

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fjogeleit, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif,fjogeleit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


feat(webauthn): allow userName in register handler options

Allow passing userName directly to defineWebAuthnRegisterEventHandler to support linking credentials to existing users without requiring userName in request body.
No breaking change as it maintains backward compatibility while adding new functionality.
How it works?
export default defineWebAuthnRegisterEventHandler({
  userName<EMAIL_ADDRESS>  async onSuccess(event, { credential }) {
    // your db actions or whatever you'd like to do with the credential
    return credential
  },
})

@atinux @Gerbuuun I have made a small enhancement to the register event handler, please take a look
Issue ref: https://github.com/atinux/nuxt-auth-utils/issues/272

I think it is better to just do the check inside the handler already? That way the dev doesn't need to implement it themselves
let user: T;
try {
  // If user is logged in, use the current user's username
  const { user } = await requireUserSession(event);
  user = { userName: user.email };
}
catch {
  // Else do the currently implemented checks
  if (!body.user?.userName)
    throw createError({
      message: 'Invalid request, missing userName or verify property',
      statusCode: 400,
    })

  user = body.user
  if (validateUser) {
    user = await validateUserData(body.user, validateUser)
  }
}

// rest of registration event handler..

Other idea: Make
if (body.verify === undefined || !body.user?.userName)
  throw createError({
    message: 'Invalid request, missing userName or verify property',
    statusCode: 400,
  })

the default validateUser function and don't force any shape to the request body?

Didn't quite get this, How would a said api method look like?
export default defineWebAuthnRegisterEventHandler({
  async onSuccess(event, { credential }) {
    const { user } = await requireUserSession(event);
    // we have the users email here
    return user;
  },
});

Another ideas was to have a separate method for this called defineWebAuthnConnectEventHandler - but feels unnecessary

@Gerbuuun Updated this to check if the user is already logged in, this way is a user is already logged in, then we pick the userName from the session


OSX podspec

Hi..
I guess your class works well for OSX too, so you just should add that in the podspec file.
Please, could you do that ? :)
Thanks!

Can you test it first? I can see that it compiles but I don't have a Mac dev account so I can't test anything with iCloud.

Release 1.0.2 has OS X support enabled in the podspec. I wasn't able to test it. Please raise new issues (and pull requests!) if you find any problems.


schismtracker: 20210525 -> 20211116

Motivation for this change
https://github.com/schismtracker/schismtracker/releases/tag/20211115
https://github.com/schismtracker/schismtracker/releases/tag/20211116
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/647


Inline snapshots fail with most-recent babel, jest, and babel-plugin-source-map-support

🐛 Bug Report
Inline snapshots don't work with this combo of packages. This may be related to #6744, but it happens even without matching the criteria in that ticket.
 Jest: Couldn't locate all inline snapshots.

      at Object.parse (node_modules/jest-snapshot/build/InlineSnapshots.js:267:11)
      at Object.parse (node_modules/prettier/index.js:13625:19)
      at coreFormat (node_modules/prettier/index.js:14899:14)
      at format (node_modules/prettier/index.js:15131:14)
      at node_modules/prettier/index.js:57542:12
      at Object.format (node_modules/prettier/index.js:57562:12)

To Reproduce
Steps to reproduce the behavior:

Install most-recent babel, jest, and babel-plugin-source-map-support
Try running this test:

test('simply fails', async () => {
  expect({key: [1, '2', null]}).toMatchInlineSnapshot();
});

Link to repl or repo (highly encouraged)
https://repl.it/@stopcontinues/inline-snapshots-busted
envinfo
  System:
    OS: macOS 11.2.2
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
  Binaries:
    Node: 15.5.1 - ~/.nvm/versions/node/v15.5.1/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 7.5.2 - ~/.nvm/versions/node/v15.5.1/bin/npm

I'm experiencing this as well, I've verified that babel-jest is producing valid source maps (validating with http://sokra.github.io/source-map-visualization/) but when I trace things in the inspector it seems that source-map-support isn't able to find those source maps when toMatchInlineSnapshot() is called so the new Error().stack isn't correct and the correct call can't be found.

Wow, yeah, one of the files imported by my tests had source-map-support/register in it which seems to have broken it, but removing that import fixed it!

Jest handles installation of sourcemaps itself, so you should remove any source-map-support usage in your own code when running tests.
(if you need it for your app, you should set it up in the entrypoint of it, not every single source file, but that's really something to discuss here 🙂)


Move “check for update” into the settings

This doesn’t belong on the profile page.I hope this issue and all my other issues I submitted just now weren’t already created (sorry to waste your time if they were).

Fixed in master


Add DeduplicationByUniqueId transform

R: @lukecwik @robertwb

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Discussed offline. We decided to purchase timer/state approach. Close this PR for now.


Release v0.9.0

Release v0.9.0

SparkCompare is now using null safe logic. The behaviour here will be different from previous version. (#200)
Minimum Python version is now 3.8

house keeping and dependency updates

#184
#185
#186
#187
#191

ping @ak-gupta


Small fixes to the release guide

I've been running through the release guide, and fixed a few minor
issues.

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[ ] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task and TaskRun to build and release this image

Reviewer Notes
If API changes
are included, additive changes
must be approved by at least two OWNERS
and backwards incompatible changes
must be approved by more than 50% of the OWNERS,
and they must first be added
in a backwards compatible way.

/test pull-tekton-pipeline-integration-tests


strip deprectated lifecycle hooks

Motivation
Which issue does this fix? Fixes #117
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist

[x] Code follows coding conventions held in this repo
[x] Automated tests have been added
[x] Tests are passing
[x] Docu has been updated (if applicable)
[x] Temporary settings (e.g. project ID used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?
Stripped out deprecated lifecycle methods and replaced with componentDidUpdate. All functionality should be the same as it was.

Great job @andrew-anguiano, thanks for contribution!

Hey @andrew-anguiano,
we would like to thank you for contributing to Kentico's open-source project. As a sign of our appreciation, we would like to send you some Kentico Developer Community SWAG!
Please fill out your postal address if you are interested.
This comment was automatically generated. If you've submitted more than one pull request, it's OK to fill out the form just once.
Kentico Developer Community
If there’s anything we can do to help, please don’t hesitate to reach out to us at<EMAIL_ADDRESS>


fix issues in configure_module_default_qconfigs

this PR fixes a logic error (reference to wrong module) and infinite looping edge case in configure_module_default_qconfigs

@bfineran is there anything we can add as a test case with this diff?

@markurtz yup, just added an extra layer to the test module which triggers the bugs that this fix addresses


Feature that sorts between events/tasks scheudled for today and upcoming events/taks in the next 7 days

This is a duplicate of Issue #6


Correct PR link for GEP-995 implementation

While reading https://gateway-api.sigs.k8s.io/geps/gep-2648/#migration-from-single-to-multiple-targets I saw this text:

HTTPRoute.Rules.Name (once they are added in GEP-995, PR at https://github.com/kubernetes-sigs/gateway-api/pull/2593)

Following through I see that 2593 is merged but needs a second PR to actually implement it.  I've updated the text to say

HTTPRoute.Rules.Name (once they are added in GEP-995, implementation tracked by #2985)

so people don't have to walk the same path I did.

/release-notes-none
(wonder if that works here)

/release-note-none

/test pull-gateway-api-verify
I'mma call this a flake but leave it to you all to figure out.

Thanks @craigbox!
/lgtm
/approve
/unhold


fix: camel case generated lint rule names

This pull request updates the generation script for adding new lint rules by camel casing generated filenames in the same way that internal linting does.
Resolves #456

Looks good to me. I agree the duplication isn't ideal. Thank you!


Build and deploy Docker containers as part of CI/CD

We should build and deploy a Docker container to a registry as a part of CI/CD.
Optionally, consider testing with the built container image.

This issue is blocked by https://github.com/ClimateImpactLab/compute-impactlab-infra/issues/3. We need a container registry on Azure to deploy to first.
With Dockerhub's recent policy changes we'll need to create our own registry. Such is life.

This issue is blocked by https://github.com/ClimateImpactLab/compute-impactlab-infra/issues/3. We need a container registry on Azure to deploy to first.
With Dockerhub's recent policy changes we'll need to create our own registry. Such is life.


tests: stabilize test_nonblocking_batch

Signed-off-by: qupeng<EMAIL_ADDRESS>What is changed and how it works?
Stabilize the unstable case test_nonblocking_batch.
Related changes
Check List
Tests

No code

Release note
None

/merge


Please provide google colab for hallo

Hallo runs fine in Google Colab as-is – using around 15 GB RAM / 10 GB VRAM, and taking around one hour for 10 seconds of video.

Closing this issue. If any further questions, please reopen it.


Additional Sensors in SpaceAPI component

Home Assistant release with the issue: 0.88
Last working Home Assistant release (if known): None
Operating environment (Hass.io/Docker/Windows/etc.): Any
Component/platform: SpaceAPI
Description of problem:
The SpaceAPI docs declare a list of defined sensors the API can provide as well as the note "... additional sensor types may be defined by you."
The SpaceAPI component as it is at the moment does not allow other sensors than temperature and humidity.

https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/spaceapi/__init__.py#L53
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/spaceapi/__init__.py#L76-L78

The problem could be easily solved by declaring ALLOW_EXTRA like this:
SENSOR_SCHEMA = vol.Schema(
    {vol.In(SENSOR_TYPES): [cv.entity_id]},
    extra=vol.ALLOW_EXTRA
)

I would like to submit a pull request but beforhand want to know what way is preferd by HA:

Extend the SENSOR_SCHEMA in order to validate all sensor types declared by the SpaceAPI docs
Just add ALLOW_EXTRA and let the user add whatever sensors he wants

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
sensors:
  temperature:
    - sensor.sofa_temperature
    - sensor.zuluft_temperature
  people_now_present:
    - sensor.member_count

The temperature sensors in the above exampel work just fine, the people_now_present does not because the validation fails.

Option 1 is preferred.


Update baseline setting to handle shiny default

see https://github.com/SafetyGraphics/safetyGraphics/issues/238 for details

Poked around a bit and pretty sure no changes are needed on the js side. Will make the needed tweak in R.


Clarify Azure API Version Requirement in Settings

The current setting labeled "Api Version" is unclear and may lead to confusion. This setting is specifically required for Azure's API and should be renamed to "Azure API Version" to reflect its purpose. This change will help avoid misunderstandings for users who might assume it's relevant for other AI/LLM models.

Fair enough :+1:


fix: Drop karma as a peerDependency.

We have decided to drop karma as a peer dependency, as there a lot of issues when trying to use release candidate versions. I'm now in the middle of making the needed PRs to do this, would be great to see this merged, as that means people can actually use versions like the current canary 0.13.0-rc.4 with the plugin.
For more discussion and reasoning see karma-runner/integration-tests#5.

@sokra ping

Thanks


Write tests where up migration fails

https://github.com/zaynetro/roller/commit/680fa24b1b3aab70201624d307495dd722234d94 closed this


Allow Test-ModuleManifest to work when filename is not specified #8388

PR Summary

Fixing 'Test-Module requires rootmodule entry to be specified with filename extension'
fixes #8388
PR Context

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] to your commit messages if the change is significant or affects feature tests

@pougetat I apologize for us being neglecting this PR. I will quickly go through the changes and merge it if things look good.

@daxian-dbw No worries. Thanks for merging. :)

@pougetat Thank you for the contribution!


feat(ListTableBody): make row key accessible to the row itself

Imagine you're displaying the contents of a dictionary in a table. The table expects its data to be described as an array. This makes sense, but it's a bit inconvenient. For example, let's say you want the items in the dictionary to be displayed sorted by key. You would do something like this:
const sortedKeys = data.keys().sort();
const sortedObjects = sortedKeys.map((key) => data[key]);
return <ListTableBody collection={sortedObjects} keyGenerator={(instance, index) => sortedKeys[index])} />

And you have the data, piece of cake. But there's a problem: that resulting array doesn't have the key anymore!
No problem, you can put it back in:
const sortedKeys = data.keys().sort();
const sortedObjects = sortedKeys.map((key) => ({ dataId: key, data: data[key] }));
return <ListTableBody collection={sortedObjects} keyGenerator={(instance, index) => sortedKeys[index])} />

This is all well and good until you actually need to retrieve data within the component:
const componentValue = this.props.instance.data.someKey...

Kind of clumsy. The worst thing about it is, the row is already receiving that key as a prop! But child components don't have access to their own key prop, so it can't get it.
My proposal is to add a rowKey property to the rendered row, so that the row can tell what its key is. That should make it much easier to use tables for dictionaries.

Looks good 👍  :shipit: 💵

This is a reasonable solution to a yucky problem. LGTM.


feat(mission_planner): check goal footprint

Signed-off-by: ismet atabay<EMAIL_ADDRESS>Description
I added checking function for if the goal's footprint is within the lane boundaries. Thus, if the footprint of the given goal extends beyond the lane boundaries, the goal will be rejected. Moreover, while the goal is published, the parameter is added for the maximum angle that the goal makes with the lane to be accepted.
Related links
closes #1761
Tests performed
Many goals were published on Rviz, it was seen that the goal was rejected when the goal's footprint was outside the lane boundaries. Goal footprint marker publisher is added for debugging purposes. In addition When the goal was given, it was tried with 20, 30, 45 degrees to see whether the goal would reject or not. Since the value is 45 when no parameter is added, 45 was entered as the default value. (I think 20°  better than 45°)
https://user-images.githubusercontent.com/56237550/199095840-25d74459-d671-42e2-9352-a25e42dd0a78.mp4
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

I'm busy for the next 2 days, I will take care of it after thursday.

I think this PR is ready for review, thank you in advance. @takayuki5168 @isamu-takagi

When we think of edge scenarios, the footprint of the goal can be found on many lanelet. Also goal pose can be found in one lanelet, while the back or front of the vehicle boundaries can be found in another lanelet. To solve this case and another edge cases, I did it like this:

After the goal was published, I combined the created route lanelets (between goal pose and vehcile pose lanelets)
Then, I combine them with goal' next lanelets (There are 3 different next lanes from the case 1 in the picture below, combining them separately)
I check that the goal footprint in all combined lanelets.
As a result, we accept the goal if the goal footprint is within the logical lane boundaries, otherwise we reject it.
I updated the description video for final results.

The footprint of the vehicle can be found in the next lanelets of the published goal lanelet. If these next lanelets are too short for the vehicle's length, the vehicle's footprint will be found in many lanelets (previous and next lanelets of goal lanelet).
It's uncomplicated to find previous lanelets where the vehicle's footprint is located, because the planned route includes these lanelets. I used a recursive search method to find the next lanelets. In this method, there is a search between the next lanes of the lane where the goal lane is located. The condition for stopping this search is that the length of the lanelets traveled exceeds the max_longitudinal_offset_m (wheel_base + front_overhang) of the vehicle. If the goal lanelet has more than one next lane, the search is repeated like this way.
To test the implementation, I divided the lanelet into small lanelets as described in the image below. I did not encounter any problems with the the algorithm.

@isamu-takagi Could you review the architecture of mission_planner's implementation? I'll review if the check function works well .

@takayuki5168 Were you able to check the function?

Sorry to be late. I'll review this weekend.

@takayuki5168 hi, The lanelet map that I made my own tests is as follows. There are quite a few little lanelets paired with linestring points on map.
test_map.txt

@takayuki5168 friendly ping :-)

I will check if this PR works well tomorrow, and approve it.

@takayuki5168 Did you have chance to test the PR?

@ismetatabay @mitsudome-r Sorry to be late. I confirmed that the PR works well.

@ismetatabay I'm fine :)

we need to consider shoulder lane

@kosuke55 Hi, I created PR: #2546

@ismetatabay
thanks very much, I commented on your PR and I also send another PR https://github.com/autowarefoundation/autoware.universe/pull/2548


Telemetry preference issues

Describe the bug
Scenario: 1) Telemetry preference is saved locally but its not restored in Checkbox when user login again.
Scenario: 2) User should not wait for About popup to start the telemetry service. Expectation is that telemetry service should run when user login and if telemetry preference is enabled.
Scenario: 3)  If user has unchecked the preference then telemetry service should stop tracking user details but currently it is running to track the details.
To Reproduce
Steps to reproduce the behavior:

in list form if possible

Expected behavior
A description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions (please complete the following information):

OS: [e.g. rhel6]
Browser [e.g. chrome, safari]
Automate Build Number [e.g.<PHONE_NUMBER>2009]

Additional context
Add any other context about the problem here.

@kalroy
Scenario 1 & 2 are fixed and PR yet to raise for review.
Fix details:-
Telemetry preference is not restored properly from localstorage. So it cause two issues ( Scenario 1 & 2 ). The fix is restored the preference from localstorage and updated in its binded property.
Code changes needed in "chef-session.service.ts" file.

@Venkatesh-rengasamy Create a draft PR from the branch instead of keeping the changes in local.

@kalroy
Created a draft PR --> https://github.com/chef/automate/pull/5284

@kalroy
The following scenarios are tested manually and working as expected in local env.

Enable or disable the preference -> close the About popup -> Again open the About popup to see the preference is restored.

Enable or disable the preference -> logout the app -> login again -> open the About popup to see the preference is restored.

Enable the preference -> logout the app -> login again -> telemetry service should track the details and send it to server.

disable the preference -> logout the app -> login again -> telemetry service should not run and its related tracking api should not trigger.

Open the About popup -> see the warning message concate with second checkbox text.


Windows Installer based on InnoSetup

Hello,
I have made a Chromium Windows Installer. (setup.exe)
setup_src.zip
Just rename "chrome.exe" into "chromium.exe" -- I recommend this to avoid confusion in Windows Task Manager. and put my code into .\Chromium\ Folder, then run Inno setup script compiler on my code.
Binary here - my Windows Installer:
https://www.dropbox.com/s/ski5sm2b6yxi8ud/Chromium_v53_Setup.exe?dl=0
-Alexey.E. "Technologov". 08.11.2016.

Thanks for submitting this, but what are the benefits over the Windows installer system that Google provides?

Today Chromium lacks Windows installer completely.
Only Google Chrome has it. So basically I decided to fill the void by creating my own installer from scratch.
I don't mind if you use someone else's installer, but we need one.

Okay. I have created #115 to address the general issue here.


Electron Dev Tools: Context Menus Are Behind The Window

On windows, context menu in the code oss dev tools are basically unusable:

I think it has been like this for some weeks. This is a real productivity blocker, especially since the VS Code debugger is also quite broken when debugging code oss.

The feature that broke this behavior in the runtime is not trivial, I will take a look this week. You can start the application with --disable-features="WidgetLayering" as a workaround.
I will merge this to https://github.com/microsoft/vscode/issues/193206


Tune memory settings for Hadoop components(based on VM memory size)

Our current implementation uses default memory allocation of 1024MB for various hadoop components. Since we currently build VM cluster with either 2048MB or 4096MB of memory, using default values for hadoop componentes leaves almost no memory Yarn containers to launch and run a job. This PR uses dynamic memory calculations based on total memory available on the node for daemons mentioned below.

HBase Regionserver
HBase Master
Yarn NodeManager
Yarn ResourceManager
After tuning these components one should be able to successfully run jobs on the cluster.

The good news is that this did not break my build.  I was able to build a cluster successfully.
The bad news is that these changes did not allow containers to run in the default configuration.  Jobs enter "SCHEDULED" state, but they never run.

I am still testing this. This needs more changes.

You need to make adjustments in mapred-site based on minimum allocation as well

@amithkanand , Looks like we may already have these changes in the code. Do we still need this PR?

Not needed anymore.


Update dApp detail view

Description
Tickets
https://radixdlt.atlassian.net/browse/ABW-3548
https://radixdlt.atlassian.net/browse/ABW-3551
https://radixdlt.atlassian.net/browse/ABW-3609

updated UI of dApp detail screen based on zeplin designs. Added bunch of previews to account for situation when some data is missing
minor UI changes to approved dapps screen
added default card composable trying to get as close to zeplin design as I could with shadow color
fixed navigation issue when forgetting the Dapp, also Android copy on the confirmation dialog was wrong - updated as well
we use dimensions as multiplies of 4.dp, some Zeplin screens had inonsistent paddings, like for example 18 (made it 16.dp), 21 (made it 24.dp) and so on.

How to test

Go through dApp details screen/approved dApps
Test ABW-3609 according to steps provided there

@jakub-rdx Please ping me when this PR is ready to be tested. I see some errors in CI.

@sergiupuhalschi-rdx updated according to your comments


🐛  Increase timeout wainting for nginx Ingress controller

Summary
This PR increases the timeout that scripts/create-kind-cluster-with-SSL-passthrough.sh uses when waiting for the nginx Ingress controller to become ready. This is good because I observed the pull to take about 140 seconds, which is longer than the current timeout of 90 seconds.
Related issue(s)
Fixes #2573

/approve


Purv dev

Separated incomplete and completed tasks. Also fixed analytics None type error.

Yes, thank you so much! I was struggling hard to fix it! Really appreciate it!


Generalize compiling libtensorflow-lite.a for arm32

System information

TensorFlow version (you are using):N/A
Are you willing to contribute it (Yes/No): Yes (maybe if I can figure it out haha)

Describe the feature and the current behavior/state.
Right now cross compiling libtensorflow-lite.a will be either for arm64 (which works great, thanks) and rpi. I understand the build for rpi will mostly be for arm32 bits, why not make that more generalized for any arm32 system?
Also, with rpi4 in the market, we are running into issues where processor can support armv8 (64 bits) but the official OS is yet to support 64 bits. What happens when users start installing 64bits OS and realized that their rpi build isn't working?
Will this change the current api? How?
No changes to the api at all as far as I'm concern, the tutorial may just be more generalized as a user.
Who will benefit with this feature?
Anybody with a 32bits arm machine :)
Please correct me if I understand this incorrectly or if this issue has been raised before!
Thanks

I've just checked in ARM crossbuild toolchains (https://github.com/tensorflow/tensorflow/commit/4961f18733ca3967198393abf419e14476b4a85c)  for Bazel build.
You can build armhf, aarch64 targets with the following commands.
$ bazel build --config=elinux_armhf  //tensorflow/lite/tools/benchmark:benchmark_model
$ bazel build --config=elinux_aarch64  //tensorflow/lite/tools/benchmark:benchmark_model

@terryheo sorry, I didn't stated my full intention. The problem is that I'm trying to build tflite natively on different platform, without needing to first cross compile the lib-tensorflowlite.a first. The problem with this approach is that bazel doesn't support arm platform. So I'm working with cmake instead and I'm using your makefile which leads to this rpi_makefile.inc from this line.
I see that the included makefile above has 'armv7l' and a TARGET_ARCH, so I guess my concerns is that why not make this a arm32_makefile instead of rpi_makefile?
Here is my specific use case:
Let say I wanted to add tflite as an ExternalProject in cmake:
ExternalProject_Add(tflite
    GIT_REPOSITORY https://github.com/tensorflow/tensorflow
    PREFIX "tensorflow"
    CONFIGURE_COMMAND ./tensorflow/lite/tools/make/download_dependencies.sh
    BUILD_IN_SOURCE 1
    BUILD_COMMAND ${TFLITE_BUILD_COMMAND}
${CMAKE_BINARY_DIR}/tensorflow/src/tf/tensorflow/lite/tools/make/gen/${TF_INSTALL_PREFIX}/lib/libtensorflow-lite.a ${CMAKE_BINARY_DIR}/
)

Then I need to set the ${TFLITE_BUILD_COMMAND} variable, that's the variable that I'm talking about and here is how I'm setting it:
# GET CPU Architechture
if(${CMAKE_SYSTEM_PROCESSOR} STREQUAL "x86_64")
    set(EDGE_ARCH "k8")
    set(TFLITE_BUILD_COMMAND make -j8 BUILD_WITH_NNAPI=false -C ${CMAKE_BINARY_DIR}/tensorflow/src/tf -f tensorflow/lite/tools/make/Makefile lib)
    set(TF_INSTALL_PREFIX "linux_x86_64")
elseif(${CMAKE_SYSTEM_PROCESSOR} STREQUAL "aarch64")
    set(EDGE_ARCH "${CMAKE_SYSTEM_PROCESSOR}")
    set(TF_INSTALL_PREFIX "generic-aarch64_armv8-a")
    set(CROSS_PREFIX "aarch64-linux-gnu-")
    set(TFLITE_BUILD_COMMAND make -j4 TARGET=generic-aarch64 TARGET_ARCH=armv8-a -C ${CMAKE_BINARY_DIR}/tensorflow/src/tf -f tensorflow/lite/tools/make/Makefile CC=${CROSS_PREFIX}g++ CXX=${CROSS_PREFIX}g++ AR=${CROSS_PREFIX}ar CFLAGS=-fpermissive lib)
elseif(${CMAKE_SYSTEM_PROCESSOR} STREQUAL "armv7l")
    message("We are going to assume that this build is for the rpi")
    set(EDGE_ARCH "${CMAKE_SYSTEM_PROCESSOR}")
    set(TF_INSTALL_PREFIX "rpi_armv7l")
    set(CROSS_PREFIX "arm-linux-gnueabihf-")
    set(TFLITE_BUILD_COMMAND make -j4 TARGET=rpi TARGET_ARCH=armv7l -C ${CMAKE_BINARY_DIR}/tensorflow/src/tf -f tensorflow/lite/tools/make/Makefile CC=${CROSS_PREFIX}g++ CXX=${CROSS_PREFIX}g++ AR=${CROSS_PREFIX}ar CFLAGS=-fpermissive lib)
else()
	message(FATAL_ERROR "Not implemented to build for: ${CMAKE_SYSTEM_PROCESSOR}")
endif()

The only problem is that in the case of "armv7l" arch, there is no way to just specify TARGET=arm32 because we don't have an arm32_makefile.inc file.
This is not a huge issue, and I image the rpi makefile should just works but why not generalizing it?

@Namburger  do you have any solution for this problem?


Remove beta label

pivotal https://www.pivotaltracker.com/story/show/91096874

https://github.com/ministryofjustice/atet/commit/9684c5cda128b1ab0270753c0530c4a90bd7ef17

@demwunz do you want to create a PR for this and get it reviewed. Im looking to potentially release it tomorrow.


Promenade teleport Crash

Game crashing when i teleporting to Promenade.
crash-2024-05-06_21.03.45-server.txt

Update the Noisium mod to the latest version, this crash has already been fixed on their side


fix unknown flag on old release version

Signed-off-by: mahjonp<EMAIL_ADDRESS>What problem does this PR solve?
PR https://github.com/pingcap/tipocket/pull/265 causes unknown flag errors on the old release version.
And https://github.com/tikv/tikv/pull/8016 make tikv-server won't panic when advertise-status-addr isn't specified, so we can remove this flag on tikv_start_script_template.
What is changed and how does it work?
Check List
Tests

Unit test
E2E test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has Go code change
Has CI related scripts change
Has Terraform scripts change

Side effects

Breaking backward compatibility

Related changes

Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

/merge


npm install doesn't work on my docker instance

I am having issue with following commands.
docker-compose run --rm npm install
docker-compose run --rm npm run dev
For some reason it never finish installation. I tried to change npm to latest & 14.0 both failed
I am running docker on windows. Everything else works fine. Can someone help me with this so I can compile my assets in laravel application.
PS: posting issue after hours of trial & errors, removing folder etc etc.

Can you please post the console output when you run the command above? Either copy and paste, or share a screenshot. It'll help me figure out what's going on!

When I boot up instances they work fine ..

Half way installation they get stuck somewhere...

It has been different places all the time not fix error...
I even tried command
docker-compose run  --rm npm install --save --no-bin-link

Instance stats:

I have to stop windowds docker server  & restart to get rid of this instance which is stuck at some point.

Gave it another try ... I ran command from npm bin bash

I am trying to build development environment and installing & running node is essential, please help.

I did log into bash and ran npm comman from inside several times after few errors it installed.  Wired was I din;t do anything than firing command again few time... :)
but it worked finally..


Generator example not doing anything and corrupted

https://github.com/Probe-Particle/ppafm/tree/main/examples/Generator
run.sh error:
/usr/bin/python3: No module named ppafm.GeneratorOCL_Simple

run_afmulator.sh doing nothing ...

Both the generator and the AFMulator examples were outdated, so I deleted them while moving around and cleaning the code recently. The run.sh and run_afmulator.sh are remnants of that, and I would just delete them. The test_trainer.py script should still be working, but it would probably need more comments to serve as a good example.


i18n(ja): Update pages.mdx

Description

Update pages.mdx.

diff

https://github.com/withastro/starlight/pull/1613
https://github.com/withastro/starlight/pull/2168
https://github.com/withastro/starlight/pull/2249

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ja
guides/pages.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Set env to non-interactive

This should speed up installation

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Karl-Ludwig Reinhard seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Improvements to auto-blacklist PRs

I'd like to see if I can make the following improvements to the PRs created by non-code-privileged users when they use the !!/blacklist command:

[x] Link to a MS search for the URL
[ ] Link the username to their chat profile
[ ] (if possible) automatically search MS and show the number of tps and fps for the site.

The first two are easy enough; the third is just about possible currently but would require a lot of code Smokey-side that doesn't have much relevance to spam-detection...

but would require a lot of code Smokey-side that doesn't have much relevance to spam-detection

I've thought about doing this from the metasmoke side. We could have a webhook from GitHub fired on pull request creation, then embed a comment or something in Smokey PRs that we could pick up on.

Second one (linking user chat profile) is done, see #311 as an example.

No. 3 is now done. Suggestions for more information to cram in there are definitely helpful!


Add HTTPOnly and SameSite attribute to Cookie

The Cookie struct does not accommodate HTTPOnly and SameSite fields, described in the spec.
This makes it impossible to specify the HTTPOnly and SameSite field of a cookie. This field can be specified in the Set-Cookie HTTP header, so the Cookie struct should also support it.

A similar issue filed for Selenium WebDriver https://github.com/SeleniumHQ/selenium/issues/7798

What all needs to be done here?
Can we just update the Cookie struct to contain an extra field with the correct JSON field name?


Move this to a converter.

Resource: api/api-agi/src/main/java/org/astivetoolkit/agi/CommandProcessor.java
Location: line 146

This does not add any real value to the project, therefore I'm closing this issue.


Create Filters component

Release Type: non-breaking feature
Fixes https://x-team-internal.atlassian.net/browse/XP-2792
Description
Create new component Filters
Checklist

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective JIRA issue to the IN REVIEW column
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] Snapshots tests passed (npm run jest)
[x] component's documentation (.stories.js file) is changed or added accordingly to reflect any new or updated use cases or variants usage
[x] if any snapshots have been changed, verify that component still works and looks as expected and update the changed snapshot
[x] manually tested the component by running it in the browser and checked nothing is broken and operates as expected!

Steps to Test or Reproduce

Run npm start
Go to http://localhost:9001/?selectedKind=UI Components%2FFilters

Screenshots

@nicksp - Good catch, thank you.
comment addressed in this commit: 0bdf4c2df4a7f5c6083236d3bc10282a183e38ef

Thanks for review guys @KamWis @migueliriano Great help with progressing further! Let's get it merged and tested in a feature branch 🎉


insta: 1.33.0 -> 1.39-unstable-2024-08-04

Updates insta to latest unstable release.
Insta vendored their lockfiles again, fixing: #317404.
Because it is not released yet, I have pulled from the unstable main for now.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Let's wait a little since 1.40 is being prepped for release.

@donovanglover
How long does the prep take?

Thanks for the ping. I'll go ahead and merge this and insta can be updated again when the new release comes out.

Commit message should be cargo-insta so ofborg builds it. Could also use the latest commit if wanted.


included urgantshow.ru and kino-live.org resources to be able to send ...

Included urgantshow.ru and kino-live.org resources to be able to send their videos to xbmc

Sorry for the late response, I was away on holidays for a month, will process this soon.

Merged


Is it possible to edit firebase_chat_core.dart?

Is it possible to edit the firebase_chat_core.dart-file? I specifically need to add an extra where-clause to this stream
Stream<List<types.Room>> rooms({bool orderByUpdatedAt = false}) {
    final fu = firebaseUser;

    if (fu == null) return const Stream.empty();

    final collection = orderByUpdatedAt
        ? getFirebaseFirestore()
            .collection(config.roomsCollectionName)
            .where('userIds', arrayContains: fu.uid)
            .orderBy('updatedAt', descending: true)
        : getFirebaseFirestore()
            .collection(config.roomsCollectionName)
            .where('userIds', arrayContains: fu.uid);

    return collection.snapshots().asyncMap(
          (query) => processRoomsQuery(
            fu,
            getFirebaseFirestore(),
            query,
            config.usersCollectionName,
          ),
        );

There are a few ways that you can make this change.
The best way to do it depends on what you want to do.

Edit the file directly.
Override the FirebaseChatCore class.
Make a PR into this repo with the fix.
Fork this repo, make the change on your fork, and install from your fork.

.../flutter/.pub-cache/hosted/pub.dartlang.org/flutter_firebase_chat_core-1.6.3/lib/src/firebase_chat_core.dart
The file is here for me

Hi thanks. I did the 2. suggestion and moved the file into my own code. Works fine with this file, however, tried the same for the User-model, it have some generated code user.g.dart, and won't work just copying it in. Do you know how to do this file? Would like to add some fields to this model

I don't see this file.  Do you mean users.dart in the example folder?

You have to move the user.g.dart file into your project also.

Yeah, I can see why it would be a mess. Well, last solution for adding fields to the user is just to add them as a map to the metadata-field. Thanks a lot for your answers:)

Types come from a separate lib https://github.com/flyerhq/flutter_chat_types because I needed this for UI as well. I tried to add metadata everywhere so arbitrary fields can be added as needed. Regarding original question - this lib is quite small and straightforward, if some clauses are missing in some functions inside the lib itself, fetch code can be written from scratch, using same database name with all needed filters I guess.


Bug: derive_param_tte() fails if dataset and by_vars is specified

What happened?
derive_param_tte() fails if dataset and by_vars is specified because the check on duplicate parameter codes fails.
Session Information
No response
Reproducible Example
library(dplyr)
library(lubridate)
library(admiral)
adsl <- tibble::tribble(
  ~USUBJID, ~TRTSDT,           ~TRTEDT,           ~EOSDT,
  "01",     ymd("2020-12-06"), ymd("2021-03-02"), ymd("2021-03-06"),
  "02",     ymd("2021-01-16"), ymd("2021-01-20"), ymd("2021-02-03")
) %>%
  mutate(STUDYID = "AB42")

ae <- tibble::tribble(
  ~USUBJID, ~AESTDTC,     ~AESEQ, ~AEDECOD,
  "01",     "2021-01-03",      1, "Flu",
  "01",     "2021-03-04",      2, "Cough",
  "01",     "2021-01-01",      3, "Flu"
) %>%
  mutate(
    STUDYID = "AB42",
    AESTDT = ymd(AESTDTC)
  )

ttae <- event_source(
  dataset_name = "ae",
  date = AESTDT,
  set_values_to = exprs(
    EVENTDESC = "AE",
    SRCDOM = "AE",
    SRCVAR = "AESTDTC",
    SRCSEQ = AESEQ
  )
)

eot <- censor_source(
  dataset_name = "adsl",
  date = pmin(TRTEDT + days(10), EOSDT),
  censor = 1,
  set_values_to = exprs(
    EVENTDESC = "END OF TRT",
    SRCDOM = "ADSL",
    SRCVAR = "TRTEDT"
  )
)

  derive_param_tte(
    dataset = adsl %>% select(STUDYID, USUBJID) %>% mutate(PARAMCD = "XYZ"),
    dataset_adsl = adsl,
    by_vars = exprs(AEDECOD),
    start_date = TRTSDT,
    event_conditions = list(ttae),
    censor_conditions = list(eot),
    source_datasets = list(adsl = adsl, ae = ae),
    set_values_to = exprs(
      PARAMCD = paste0("TTAE", as.numeric(as.factor(AEDECOD))),
      PARAM = paste("Time to First", AEDECOD, "Adverse Event"),
      PARCAT1 = "TTAE",
      PARCAT2 = AEDECOD
    )
  )

results in
Error in match(x, table, nomatch = 0L) :
  'match' requires vector arguments

Is this a critical bug or one that we can wait on for a while?

As a work-around you could not specify the dataset argument, create separate datasets for each derive_param_tte() call, and bind them all together using bind_rows().
So it is not super-critical. However, I am not sure if we should wait until June.

I will add to agenda for next week's meeting.

@bms63 I looked at the Hotfix release page, do you create the patch branch that I should take feature branch from to fix this?

I think we should create a patch branch off the latest release tag and then branch off the patch to make the fix.  whew!!  @zdz2101

OK thanks, I have created a branch called patch from tag 1.0.1 on GItHub

Our documentation is inconsistent. On the one hand it requires that the patch branch is protected and updated after each release. On the other hand it suggests to create the patch branch from a release tag.
And the formatting of the "Hot Fix Release" section got mixed up:

Our documentation is inconsistent. On the one hand it requires that the patch branch is protected and updated after each release. On the other hand it suggests to create the patch branch from a release tag.
And the formatting of the "Hot Fix Release" section got mixed up:

Thanks Stefan I created a new issue https://github.com/pharmaverse/admiraldev/issues/365


unwanted xpos offset when drawing text

For some strings the xpos is not equivalent to the expected one when bounds are calculated / text is drawn. For example I'd like to align the text left and draw at position 0,0. So I expect the pos to be 0,0.
float bounds[4];
nvgTextAlign(vg, NVG_ALIGN_LEFT | NVG_ALIGN_TOP);
nvgTextBounds(vg, 0, 0, "this is a test", NULL, bounds);
printf("%f", bounds[0]);

If for example the string "this is a test" is used the xPosition is not 0 but -0.5. Although for most strings the xPosition is 0.

nvgTextBounds() returns the bounds of the glyphs used to render the text. Some glyphs just are "outside" the logical bounds. For example big O often starts a little bit left so that it optically aligns with the rest of the row.

Ah ok, so it's not a bug but a feature. Thanks for the info!


What is the difference with pysocks?

Would it be useful to list the differences between this library and pysocks? Also, could this be a drop-in replacement.

python-socks supports async API, pysocks does not.

Aha! and is this a drop in? would a pysocks project just transparently be able to use it? I see that other than the module name differences (socks vs python_socks) the interface looks quite similar...

In general no, they have a different interface

ACK, I just wanted to make sure in order to keep things tidy for the archlinux repository. Thanks!


search: Vertically center search pills in search bar.

before:

after:

@timabbott  a quick followup tweak that I forgot I had locally when you merged

Ran prettier to fix CI and merged, thanks @evykassirer!


Uncaught Error: Could not find module

Uncaught Error: Could not find module `ember-scroll-operator/mixins/reset-scroll`
imported from `website/open-source/route`

Any ideas why it can't be imported?

My bad, disregard this 😛


How to get svc_VoiceData events?

Currently not possible. In the meantime you can check out: https://github.com/DandrewsDev/CS2VoiceData

voice data can now be parsed with parse_voice


allowed extensions doesn't work

I have:
eel.init(directory, allowed_extensions=['.js', '.html', '.vue'])
And receive after script start:
TypeError: init() got an unexpected keyword argument 'allowed_extensions'
Where is a problem?

Are you on the latest version (the version from Github)?


⚠ ClamAV has degraded performance

In e972484, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 76 ms

Resolved: ClamAV performance has improved in 8ae2830 after 543 days, 2 hours, 25 minutes.


SPDIF/TOSLINK Adapters

Not actually an "Issue", but connecting a cheap SPDIF/TOSLINK adapter intended for motherboard breakout on a PC works nicely to provide output connectors. I'm using one like this: https://www.aliexpress.com/item/1005003014609633.html
I haven't tested the SPDIF because I don't have a coax cable but the TOSLINK works just fine.

Nice find. Good to know!
Maybe I should create a wiki page for tricks and finds like this.


[SPARK-20392][SQL] Set barrier to prevent re-entering a tree

What changes were proposed in this pull request?
It is reported that there is performance downgrade when applying ML pipeline for dataset with many columns but few rows.
A big part of the performance downgrade comes from some operations (e.g., select) on DataFrame/Dataset which re-create new DataFrame/Dataset with a new LogicalPlan. The cost can be ignored in the usage of SQL, normally.
However, it's not rare to chain dozens of pipeline stages in ML. When the query plan grows incrementally during running those stages, the total cost spent on re-creation of DataFrame grows too. In particular, the Analyzer will go through the big query plan even most part of it is analyzed.
By eliminating part of the cost, the time to run the example code locally is reduced from about 1min to about 30 secs.
In particular, the time applying the pipeline locally is mostly spent on calling transform of the 137 Bucketizers. Before the change, each call of Bucketizer's transform can cost about 0.4 sec. So the total time spent on all Bucketizers' transform is about 50 secs. After the change, each call only costs about 0.1 sec.
We also make boundEnc as lazy variable to reduce unnecessary running time.
Performance improvement
The codes and datasets provided by Barry Becker to re-produce this issue and benchmark can be found on the JIRA.
Before this patch: about 1 min
After this patch: about 20 secs
How was this patch tested?
Existing tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.

Test build #76174 has started for PR 17770 at commit fe44832.

Test build #76174 has finished for PR 17770 at commit fe44832.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Barrier(node: Option[TreeNode[_]] = None)

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76174/
Test FAILed.

Merged build finished. Test FAILed.

Test build #76182 has started for PR 17770 at commit 82978d7.

Test build #76182 has finished for PR 17770 at commit 82978d7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class Barrier(node: Option[TreeNode[_]] = None)

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76182/
Test FAILed.

Merged build finished. Test FAILed.

Can we fix the description? It is really confusing since it uses the word exchange. Also can we just skip a plan if it is resolved in transform?

@hvanhovell @rxin Thanks for comment.
Ok. Based on your suggestion, looks like we have two options:

Create a logical plan node and override the transformUp/transformDown
Override the transformUp/transformDown inLogicalPlan and skip resolved plan

May I ask which one is preferred?

Option 2 may not work because transformUp/transformDown is still used in Optimizer.

Test build #76219 has started for PR 17770 at commit 81db205.

Test build #76222 has started for PR 17770 at commit 24905e3.

Test build #76219 has finished for PR 17770 at commit 81db205.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AnalysisBarrier(child: LogicalPlan) extends UnaryNode

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76219/
Test PASSed.

Merged build finished. Test PASSed.

Test build #76222 has finished for PR 17770 at commit 24905e3.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AnalysisBarrier(child: LogicalPlan) extends UnaryNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76222/
Test PASSed.

@hvanhovell @rxin I've updated this accordingly. Do you have more comments on this? Thanks.

Test build #76324 has started for PR 17770 at commit a76f225.

Test build #76326 has started for PR 17770 at commit e15b001.

Test build #76324 has finished for PR 17770 at commit a76f225.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76324/
Test PASSed.

Test build #76326 has finished for PR 17770 at commit e15b001.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76326/
Test PASSed.

cc @cloud-fan

we can use resolveOperators to avoid transforming already resolved plans, but I think we still need to traverse the plan tree for optimizer.

There are many transform/Up/Down usages across Analyzer which still traverse resolved plans. We put this analysis barrier when we make sure the the wrapped plan is resolved and shouldn't be traversed again.

after we have this, can we remove the resolveOperators?

It is possible as I think resolveOperators works as the same as this analysis barrier + transformUp. However, resolveOperators is widely used now so we may not have urgent need to remove it.

I think we should have a single way to stop analyzing already analyzed plans. We should either apply resolveOperators more widely, or switch to use this analysis barrier.

Using resolveOperators looks cleaner to me.

resolveOperators can't cover all usage of this analysis barrier. There are also rules in analyzer that can't be replaced with resolveOperators.

is the analysis barrier applicable for all the cases?

Currently I think it can cover all cases of resolveOperators. It is more flexible for example we can choose only wrap specific sub-plan in barrier.

Test build #76407 has started for PR 17770 at commit a076d83.

Test build #76407 has finished for PR 17770 at commit a076d83.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AnalysisBarrier(child: LogicalPlan) extends LeafNode

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76407/
Test PASSed.

Merged build finished. Test PASSed.

this approach LGTM, my main concern is, shall we remove resolveOperators? If there are too much work, we can do it in a follow-up.

why don't we always add this to the dataset's logicalPlan? we can change that in one place.

Hmm, the possible issue I can think of that is self-join case. We just add the barrier to one side of it. If we always add this to dataset's logicalPlan, we may need to strip it when in join.

I'm actually wondering if we should just introduce a variant of transform that takes a stop condition, e.g.
def transform(stopCondition: BaseType => Boolean)(rule: PartialFunction[BaseType, BaseType])

and then in analyzer we can use
def transform(_.resolved) {
  case ...
}

I worry adding this random node everywhere will make the plan look ugly and break certain assumptions we have somewhere.

It only shows in parsed logical plan and disappears after analysis. I am not sure if we have some assumptions for logical plan before analysis.

A variant of transform with a stop condition might be tricky to apply on the self-join case. We have to manually reset the resolved status of right side of join.
Besides that, I think it should work if there is no other issue I didn't consider for now.

What self join case are you talking about? The one that we manually rewrite half of the plan? That one would be a special case anyway, wouldn't it?

Seems worth trying this direction. Of course it involves much more changes to analyzer. Is it ok for you @rxin? If so, I will update this to that direction.

Let's see what other people say before going too far...
cc @cloud-fan / @hvanhovell / @marmbrus / @gatorsmile see my proposal: https://github.com/apache/spark/pull/17770#issuecomment-298833348

Yap, thanks.

Some thoughts:

We shouldn't have multiple optimizations for avoiding repeated analysis.  So if we decide to go this way then we should get rid of resolveOperators.
I agree with Reynold, that the dummy operator could have confusing side-effects down the road.
The proposed generalization of resolveOperators to take a generic stopping condition is reasonable, but I would only do it if we have more than one use case.

Have we tried just using resolveOperators in more places?  Does that fix the performance issue?

I am not a giant fan of the resolveOperators* approach, is is yet another code path that does something similar to the transfrom* code path, it introduces some mutable state, and I have been bitten by it before. I personally think that a barrier node (that is be a no-op for any rule) is a far more elegant solution.

I also prefer the barrier approach, it will be removed at the end of analysis phase so we should be OK. But agree with @marmbrus , if we go with this approach, we should remove resolveOperators

Okay, I can be convinced.  Lets do eliminate the other path then though and make sure there are no performance regressions.

Thanks @rxin @marmbrus @hvanhovell @cloud-fan It is reasonable to me. I'll do eliminate the path of resolveOperators.

Test build #76470 has started for PR 17770 at commit b29ded3.

@srinathshankar also thinks it's weird to add a barrier node. I suggest @hvanhovell and @srinathshankar duke it out.

Test build #76472 has started for PR 17770 at commit 8c8fe1e.

Test build #76472 has finished for PR 17770 at commit 8c8fe1e.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76472/
Test FAILed.

Merged build finished. Test FAILed.

Test build #76474 has started for PR 17770 at commit a855182.

Test build #76474 has finished for PR 17770 at commit a855182.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76474/
Test FAILed.

Test build #76476 has started for PR 17770 at commit 2af9e2b.

Test build #76478 has started for PR 17770 at commit 4ff9610.

Test build #76476 has finished for PR 17770 at commit 2af9e2b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76476/
Test FAILed.

Test build #76478 has finished for PR 17770 at commit 4ff9610.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76478/
Test FAILed.

Test build #76470 has finished for PR 17770 at commit b29ded3.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76470/
Test FAILed.

Test build #76520 has started for PR 17770 at commit bbe4aa0.

Test build #76520 has finished for PR 17770 at commit bbe4aa0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76520/
Test FAILed.

Test build #76522 has started for PR 17770 at commit c316e68.

Test build #76522 has finished for PR 17770 at commit c316e68.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76522/
Test FAILed.

Test build #76524 has started for PR 17770 at commit 119e857.

Test build #76524 has finished for PR 17770 at commit 119e857.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76524/
Test PASSed.

Test build #76536 has started for PR 17770 at commit 7debd76.

Test build #76536 has finished for PR 17770 at commit 7debd76.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76536/
Test FAILed.

Test build #76541 has started for PR 17770 at commit d0a94f4.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76541/
Test FAILed.

retest this please.

Test build #76543 has started for PR 17770 at commit d0a94f4.

Test build #76543 has finished for PR 17770 at commit d0a94f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76543/
Test PASSed.

I've removed the path of resolveOperators. After ran the same benchmark, I didn't find obvious performance regression. @hvanhovell @marmbrus @cloud-fan @rxin @srinathshankar

It might be a good idea to look at the time spent before and after this change for all the unit tests in core / hive.

The total time spent on all tests in SQLQueryTestSuite. I sum up the numbers reported by dumpTimeSpent.
before:<PHONE_NUMBER>
after:<PHONE_NUMBER>

The total time spent on all tests in HiveCompatibilitySuite.
before:<PHONE_NUMBER>1
after:<PHONE_NUMBER>7

Test build #76670 has started for PR 17770 at commit 02e11f9.

Test build #76670 has finished for PR 17770 at commit 02e11f9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76670/
Test PASSed.

Test build #76684 has started for PR 17770 at commit 17f1a02.

Test build #76684 has finished for PR 17770 at commit 17f1a02.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedTableValuedFunction(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76684/
Test PASSed.

Test build #76719 has started for PR 17770 at commit 4629959.

Test build #76719 has finished for PR 17770 at commit 4629959.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76719/
Test FAILed.

Test build #76728 has started for PR 17770 at commit c313e35.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76728/
Test FAILed.

retest this please.

Test build #76734 has started for PR 17770 at commit c313e35.

Test build #76734 has finished for PR 17770 at commit c313e35.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76734/
Test PASSed.

LGTM except some minor comments, cc @gatorsmile

Test build #76788 has started for PR 17770 at commit 7e9dfac.

Test build #76788 has finished for PR 17770 at commit 7e9dfac.

This patch fails from timeout after a configured wait of `250m`.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76788/
Test FAILed.

Merged build finished. Test FAILed.

ping @gatorsmile Can you help review this? Thanks.

Test build #77003 has started for PR 17770 at commit fba3690.

Test build #77010 has started for PR 17770 at commit f63ea0b.

Test build #77003 has finished for PR 17770 at commit fba3690.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  case class RegisteredWorker(
class Imputer @Since(\"2.2.0\") (@Since(\"2.2.0\") override val uid: String)
case class UnresolvedTableValuedFunction(
case class ParseToTimestamp(left: Expression, format: Option[Expression], child: Expression)
case class InterpretedPredicate(expression: Expression) extends BasePredicate
class AstBuilder(conf: SQLConf) extends SqlBaseBaseVisitor[AnyRef] with Logging
class CatalystSqlParser(conf: SQLConf) extends AbstractSqlParser
case class ColumnStatsMap(originalMap: AttributeMap[ColumnStat])
class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder(conf)
              s\"($

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77003/
Test FAILed.

Merged build finished. Test FAILed.

Test build #77010 has finished for PR 17770 at commit f63ea0b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77010/
Test FAILed.

Test build #77020 has started for PR 17770 at commit b9d03cd.

Test build #77020 has finished for PR 17770 at commit b9d03cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77020/
Test PASSed.

Merged build finished. Test PASSed.

If we decide to introduce AnalysisBarrier, I think we can follow what we did for SubqueryAlias.

Test build #77082 has started for PR 17770 at commit 6a7204c.

It seems to me that we won't want to show AnalysisBarrier in analyzed plan, unlike SubqueryAlias.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77082/
Test FAILed.

retest this please.

Test build #77088 has started for PR 17770 at commit 6a7204c.

Test build #77088 has finished for PR 17770 at commit 6a7204c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77088/
Test PASSed.

ping @cloud-fan @gatorsmile Do you have more comments for this change? Thanks.

more thoughts about https://github.com/apache/spark/pull/17770#discussion_r117349872
If we add the AnalysisBarrier in Dataset.logicalPlan, and implement AnalysisBarrier.canonicalized like SubqueryAlias, will it be simpler?

@cloud-fan Sounds good. I'll update this.

Test build #77174 has started for PR 17770 at commit 7ba419f.

Test build #77175 has started for PR 17770 at commit 1701d98.

Test build #77175 has finished for PR 17770 at commit 1701d98.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77175/
Test FAILed.

Test build #77177 has started for PR 17770 at commit 3437ae0.

Test build #77177 has finished for PR 17770 at commit 3437ae0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77177/
Test FAILed.

Test build #77248 has started for PR 17770 at commit 8166cb3.

Test build #77249 has started for PR 17770 at commit 505aba6.

Test build #77249 has finished for PR 17770 at commit 505aba6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class JavaChiSquareTestExample
public class JavaCorrelationExample
  class DecisionTreeClassifierWrapperWriter(instance: DecisionTreeClassifierWrapper)
 class DecisionTreeClassifierWrapperReader extends MLReader[DecisionTreeClassifierWrapper]
  class DecisionTreeRegressorWrapperWriter(instance: DecisionTreeRegressorWrapper)
 class DecisionTreeRegressorWrapperReader extends MLReader[DecisionTreeRegressorWrapper]
case class Cot(child: Expression)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77249/
Test FAILed.

Test build #77248 has finished for PR 17770 at commit 8166cb3.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77248/
Test FAILed.

Test build #77281 has started for PR 17770 at commit f5f0524.

Test build #77283 has started for PR 17770 at commit 5c53f0f.

Test build #77284 has started for PR 17770 at commit f3e4208.

Test build #77286 has started for PR 17770 at commit c0bee01.

Test build #77281 has finished for PR 17770 at commit f5f0524.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77281/
Test FAILed.

Test build #77283 has finished for PR 17770 at commit 5c53f0f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77283/
Test FAILed.

Test build #77284 has finished for PR 17770 at commit f3e4208.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77284/
Test FAILed.

Test build #77286 has finished for PR 17770 at commit c0bee01.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77286/
Test FAILed.

Merged build finished. Test FAILed.

Test build #77290 has started for PR 17770 at commit 2bf0590.

Test build #77291 has started for PR 17770 at commit 1c1cc9d.

Test build #77290 has finished for PR 17770 at commit 2bf0590.

This patch fails to build.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77290/
Test FAILed.

Test build #77292 has started for PR 17770 at commit eb0598e.

Test build #77291 has finished for PR 17770 at commit 1c1cc9d.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77291/
Test FAILed.

Test build #77292 has finished for PR 17770 at commit eb0598e.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class UnresolvedHint(name: String, parameters: Seq[String], child: LogicalPlan)
case class ResolvedHint(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77292/
Test FAILed.

Test build #77294 has started for PR 17770 at commit cba784b.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77294/
Test FAILed.

retest this please.

Test build #77295 has started for PR 17770 at commit cba784b.

Test build #77295 has finished for PR 17770 at commit cba784b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77295/
Test FAILed.

Test build #77331 has started for PR 17770 at commit b82b018.

Test build #77332 has started for PR 17770 at commit 8314cc3.

Test build #77331 has finished for PR 17770 at commit b82b018.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77331/
Test PASSed.

Test build #77332 has finished for PR 17770 at commit 8314cc3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77332/
Test PASSed.

Merged build finished. Test PASSed.

@cloud-fan @gatorsmile Please let me know if you have more comments on this change. Thanks.

LGTM except some minor comments

Test build #77400 has started for PR 17770 at commit 6add9ec.

Test build #77400 has finished for PR 17770 at commit 6add9ec.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/77400/
Test PASSed.

Merged build finished. Test PASSed.

thanks, merging to master!

I think this will bring conflicts if we backport new PRs to branch 2.2, @viirya can you send a new PR to backport it to branch 2.2? thanks!

Whoa, I do not think we should back porting a large change to the inner workings of the analyzer.

Ok, I won't backport this until we reach a consensus.

Hi @viirya , as this PR already missed the Spark 2.2 release, I'd like to revert it and re-merge it at the end of Spark 2.3, so that future analyzer related PRs won't get conflicted when backporting to 2.2. I'm pretty sorry about this, I'll mark it as a blocker for spark 2.3 so that we don't forget.
What do you think?

@cloud-fan Ok. No problem for me. Thanks.

reverted, thanks for your understanding!

Hi @viirya , since it's close to Spark 2.3, would you like to reopen this PR? Thanks!

@cloud-fan Sure. Seems there is no option to reopen it as it was merged before. Should I create another PR for it?

yea, a new PR sounds good, thanks!


refactor(metrics): refine relabelled metrics interfaces

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

#18318
#18331  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BugenZhao and the rest of your teammates on  Graphite


Optimizing objectives with NaN or Inf outputs

Hi,
Thanks for this amazing library. I am using this to optimize a simulation results. In short the objective is a wrapped up version of simulation and so, it can return NaN or Inf for some inputs. I get the following error, ValueError: Input contains NaN, infinity or a value too large for dtype('float64')
I have been trying to handle this gracefully, for example, instead of NaN or Inf, I return a very high number or zero. I know this is not the best way to handle it and it is somehow closer to handling missing data or constrained optimization.  I am raising this issue to know if there is anything I could use within the skopt API or any other suggestions are also welcome.
Thanks,

AFAIK this is due to the sklearn models we use internally. Most (all?) sklearn regressors do not support NaN or Inf.
Off the top of my head using a special (large or small) value is the best hack we have right now.

Thanks for reassuring :+1:


Add document this code action to annotation declarations

Purpose

$Title

Fixes #34423
Approach

Adds Document this and Doccument all code actions for annotation declarations.

Samples
https://user-images.githubusercontent.com/46120162/166621556-c978cf7c-7f62-4fa0-9c0b-c597ce320d08.mp4
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Shall we improve the diff coverage?

Done


test(e2e): do not fail build on XRay failure

Send slack message and allow build to pass
on XRay report failure.

bors try

bors merge


Fixed the dark mode when using chrome

Implemnented pdf.js in my application, but when trying to open the application on chrome if my browser is in Dark mode the pdf viewer is in light mode and the orther way around. This is fixed getting rid of "prefers-color-scheme: dark".

This is unfortunately not something we can accept since this is the primary mechanism to switch between light and dark theme, and this has been confirmed to work correctly. Moreover, removing this would cause the dark theme to always be used. If Chrome or your application is doing something different, that's either a browser bug or an application bug.


Add support for SAML login with fleetctl

fleetctl currently supports login via username/password. We need to find a way to support SAML login as well.

Ping @cwhits


Add limited iOS support

@makeroo has added support for getConnectedSSID on iOS. It would be useful to have this in the 'official' plugin. :)

Nice! Thanks for the PR :smile: I'll try to get this included this weekend


AttributeError: 'NoneType' object has no attribute 'get'

Hi,
I tried this tool to migrate services from AWS ECS cluster to AWS EKS Cluster. But I am struck with the below error:
File "/specctl/.venv/lib/python3.11/site-packages/specctl/ecs2k8s/ecs_parser.py", line 92, in ingress_parser
tg_name = tg_details.get("TargetGroupName")
^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'get'
Please kindly help me in resolving this error.
Thanks,
Hariharan.

Let me look into it

Does the ECS service you are trying to convert use load balancer? And is that target group associated to some alb or not? Could you provide any other info to reproduce?

Hi,
We have few services in ECS which are not associated with any loadbalancers.  is there anyway to skip those services?
Thanks,
Hariharan.

Do those services have target groups in the service definition?

The above error seems to be due to services having target groups but no associated load balancer. If you confirm that is the case I can do the code change to fix the issue

Hi,
We have few services in ECS which are not associated with any loadbalancers. Pl kindly fix the code & let us know.
Thanks,
Hariharan.