error i think might be originating from this mod

evening. i think i have an issue coming from this mod, i've been unable to find any info regarding my errors specifically though. i can reliably produce the error if i install the mod, and remove any errors if i remove the mod. below are several log files.

redscript log
2022-12-29T19:37:19.7491808-07:00 [INFO] Script manifest not loaded, using defaults (manifest not available)
2022-12-29T19:37:19.7591814-07:00 [INFO] Custom cache directory provided: E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\cache\modded
2022-12-29T19:37:20.1312026-07:00 [INFO] Redscript cache file is not ours, copying it to E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\cache\modded\final.redscripts.bk
2022-12-29T19:37:20.3382145-07:00 [INFO] Compiling files: E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\ArchiveXL\ArchiveXL.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\ModSettings.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\ModSettingsMainGameController.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\ModSettingsModule.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\ModSettingsNotificationListener.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\_deathMenu.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\_pauseMenu.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\_pauseScenario.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\_preGameScenarios.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\_SettingsCategoryController.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\_SettingsSelectorControllers.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\mod_settings\_singleplayerMenu.reds, E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\scripts\TweakXL\TweakXL.reds
2022-12-29T19:37:20.3672161-07:00 [INFO] Compilation complete
2022-12-29T19:37:20.9322485-07:00 [INFO] Output successfully saved in E:\games\GOG Galaxy\Games\Cyberpunk 2077\r6\cache\modded

as near as i can determine from redscript, this log means it's working as it should

red4ext log
[2022-12-29 19:37:21.276] [RED4ext] [info] RED4ext (v1.9.0) is initializing...
[2022-12-29 19:37:21.277] [RED4ext] [info] Game version is 1.61
[2022-12-29 19:37:21.277] [RED4ext] [info] File version is <IP_ADDRESS>510
[2022-12-29 19:37:21.296] [RED4ext] [info] RED4ext has been successfully initialized
[2022-12-29 19:37:21.366] [RED4ext] [info] RED4ext is starting up...
[2022-12-29 19:37:21.578] [RED4ext] [info] ArchiveXL (version: 1.3.4, author(s): psiberx) has been loaded
[2022-12-29 19:37:21.711] [RED4ext] [info] CTD Helper (version: 0.0.4, author(s): Jack Humbert) has been loaded
[2022-12-29 19:37:21.767] [RED4ext] [info] Input Loader (version: 0.0.7, author(s): Jack Humbert) has been loaded
[2022-12-29 19:37:21.811] [RED4ext] [info] Mod Settings (version: 0.0.9, author(s): Jack Humbert) has been loaded
[2022-12-29 19:37:21.856] [RED4ext] [warning] Could not load plugin 'TweakXL'. Error code: 127, msg: 'The specified procedure could not be found.', path: 'E:\games\GOG Galaxy\Games\Cyberpunk 2077\red4ext\plugins\TweakXL\TweakXL.dll'
[2022-12-29 19:37:21.856] [RED4ext] [info] 4 plugin(s) loaded
[2022-12-29 19:37:21.856] [RED4ext] [info] RED4ext has been started

i was unable to find details about this error, it seems to suggest that tweakxl.dll is not located in that directory, but i've confirmed that it does in fact exist there.

ctd helper log
[2022-12-29 19:37:21.604] [info] Starting up CTD Helper v0.0.4
[2022-12-29 19:37:21.604] [info] Base address: 0x13f480000
[2022-12-29 19:37:24.739] [error] Missing native function 'GetFlat' in native class 'TweakDBInterface'
[2022-12-29 19:37:24.739] [error] Missing native function 'GetRecord' in native class 'TweakDBInterface'
[2022-12-29 19:37:24.739] [error] Missing native function 'GetRecords' in native class 'TweakDBInterface'
[2022-12-29 19:37:24.739] [error] Missing native function 'GetRecordCount' in native class 'TweakDBInterface'
[2022-12-29 19:37:24.739] [error] Missing native function 'GetRecordByIndex' in native class 'TweakDBInterface'
[2022-12-29 19:37:24.741] [error] Missing native class 'ScriptableTweak'
[2022-12-29 19:37:24.741] [error] Missing native class 'TweakDBManager'
[2022-12-29 19:37:24.741] [error] Missing native class 'TweakXL'
[2022-12-29 19:37:24.742] [error] Validation failed for 4 types
[2022-12-29 19:37:24.748] [error] File: E:\R6.Release\dev\src\common\engine\src\baseEngineInit.cpp @ Line 1019
[2022-12-29 19:37:24.748] [error]   result
[2022-12-29 19:37:24.748] [error]   Failed to initialize scripts data!
[2022-12-29 19:37:27.658] [error] Crash! Last called functions in each thread:

i'm not sure what to make of this log. but that is the error window that pops up when i run cp2077
some details:
CP2077 version 1.61, gog version.
all mods are the latest version posted to nexus mods. listed below
archivexl
ctd helper
cybercmd
cet
input loader
mod settings
red4ext
redscript
tweakxl
i've tried reinstalling cp2077 with just the mods cet, red4ext, redscript, cybercmd, and tweakxl to similar results. i've also followed the recommendations on redscripts page about clearing the cache. deleting everything in r6/cache and then verifying game files. also to no change. if there's anything you can shed light on here it would be appreciated.

You didn't describe any errors.

the game wont load, just opens a report with the info from ctd helper.

What's the exact error message?

[2022-12-29 19:37:21.604] [info] Starting up CTD Helper v0.0.4
[2022-12-29 19:37:21.604] [info] Base address: 0x13f480000
[2022-12-29 19:37:24.739] [error] Missing native function 'GetFlat' in native class 'TweakDBInterface'
[2022-12-29 19:37:24.739] [error] Missing native function 'GetRecord' in native class 'TweakDBInterface'
[2022-12-29 19:37:24.739] [error] Missing native function 'GetRecords' in native class 'TweakDBInterface'
[2022-12-29 19:37:24.739] [error] Missing native function 'GetRecordCount' in native class 'TweakDBInterface'
[2022-12-29 19:37:24.739] [error] Missing native function 'GetRecordByIndex' in native class 'TweakDBInterface'
[2022-12-29 19:37:24.741] [error] Missing native class 'ScriptableTweak'
[2022-12-29 19:37:24.741] [error] Missing native class 'TweakDBManager'
[2022-12-29 19:37:24.741] [error] Missing native class 'TweakXL'
[2022-12-29 19:37:24.742] [error] Validation failed for 4 types
[2022-12-29 19:37:24.748] [error] File: E:\R6.Release\dev\src\common\engine\src\baseEngineInit.cpp @ Line 1019
[2022-12-29 19:37:24.748] [error]   result
[2022-12-29 19:37:24.748] [error]   Failed to initialize scripts data!
[2022-12-29 19:37:27.658] [error] Crash! Last called functions in each thread:

This means you have problems with RED4ext.
Update everything to the latest versions.
Follow RED4ext troubleshooting instructions.

thanks, i'll follow up with them.


Fragments On Composite Types

http://facebook.github.io/graphql/June2018/#sec-Fragments-On-Composite-Types

Implemented with #221

Tests are still missing...


NanoService Reload

Not all NanoServices can be recreated on nSpec changes.  For those that cannot, 'reload' has been added to the NanoService interface.  Called from Boot and NSpecFactory to instruct the service that its nSpec was modified and to take appropriate action.

I would like to discuss.


Hello！ Question about the language.

I read this code briefly this morning and I am really curious about this.
Seems that this is based on opencv.
So if I want to use this, the Hearthstones' language option should be Ruassian?
Or I should change pictures into my own language?

Great, I'll add support on the screens FullHD in about 2 hours and if it doesn't help, I think I'll need your help in adding Chinese.

Hi, there/Привет.
Registered on github just to get notifications on your project progress. Could help with testing (rus/eng only).
Sent you request in discord if you don't mind.

Да, конечно, буду рад любой помощи, добавил в друзья. Вечером созвонимся.


Iterable type hint makes it easy to pass in wrong type of key argument

First of all, thank you so much for stewarding this library! The latest versions look great.
One notable difference in moving from aioredis is the behavior of functions that can either take one or many keys, for example exists. I think the approach coredis takes is reasonable -- which is to require that a list be passed in, even if it's a single-element list. However, the current type hinting makes it possible to accidentally pass in a single key instead, like:
await redis.exists("mykey")

Which will destructure into testing for each character in "mykey".
Would you be open to tightening the Iterable typehint on those commands? I'm happy to put up a PR if so. I was thinking something like Union[List, Tuple, Set, ValuesView, ItemsView] which should cover the majority of use cases for passing in iterables-but-not-strings into those functions.

First of all, thank you so much for stewarding this library! The latest versions look great.

Thank you for giving it a chance and the feedback 🙇
The issue with switching out variadic arguments when they are not optional is I think the most "annoying" decision I've made when adopting / migrating aredis to coredis. To be honest it was done purely out of laziness because I wanted to be able to rely on the redis command spec for optionality and be able to generate a reasonably consistent set of signature mappings for each redis command (i.e. let a script generate the methods for me). At the time I completely forgot about how strings and bytes are tacked onto Iterable and basically mess everything up both for runtime and static checking.
I'd considered two options:

Describe a Protocol that allows everything but strings and bytes
throw in the towel and add an override for common methods which face this issue (delete & exists  are probably the most obvious ones)

Now that I think about it pinning it to Union[List, Tuple, Set, ValuesView, ItemsView] really does look perfectly reasonable. The only (aesthetic) issue I have with that is how verbose the api docs become with sphinx, but I'm sure there's something that can be figured out with a TypeAlias.
TL;DR yes I think we should go ahead with your proposal. I'm getting close to completing a rather large refactor of the guts to make the type safety a bit more serious than just on the surface of the API, but if you have the bandwidth to put up a PR I'd be happy to push out a dot release. I think adding a new type alias in typing.py and replacing keys: Iterable[KeyT] with keys: Keys (and maybe a Values) (I suck at naming) would work?

Just a heads up, I managed to get something working on master (unreleased). This will probably be going out in 3.5. I'll leave this open until I do cut a release and in case you have some feedback.
The TL;DR is that I did end up going with a union along the lines of what you had suggested - details here.
On a side note, thank you for bringing this up and the suggestion. Turns out a handful of tests were infact calling delete("fubar") instead of delete(["fubar"]) etc and had been accidentally passing. Since the CI runs with runtime checking they started failing once I switched Iterable with Parameters. Here's an example run if you're interested.

This is now addressed in 3.5.0


Updated samples to use getThumbnailImage after serverRelativeURL stop…

Q
A

Bug fix?
yes

What's in this Pull Request?
The image column no longer returns the serverRelativeURL for new images added to the list. While this works fine for images uploaded before this change it no longer works for new ones. This PR replaces the URLs used to make the image preview by the getThumbnailImage function. This change make the sample work for both new and old images

@joaoferreira
Top! 🏆

Thank you so much @joaoferreira 🙏✨

Close #713

Fiexed #713


Fix graphql ahr; voter and preventable aren't propagating?

Voter participation data is available only for election years (2008, 2012, 2016, and 2020). The data is missing for non-election years, which results in null values. Let's use the voter participation rate from the most recent election year for the years between elections.

Use 2008 data for 2008-2011.
Use 2012 data for 2012-2015.
Use 2016 data for 2016-2019.
Use 2020 data for 2020-2023

So I double-checked AHR's database, and the data provides only one age breakdown category, Ages 65-74. Because of that, all other age categories will be null in the age_national and age_state tables. I think we should decide whether the age breakdown for Preventable Hospitalizations should be shown at all. Maybe we could do a "Senior Report" focusing on the 'Ages 65-74' category?

So I double-checked AHR's database, and the data provides only one age breakdown category, Ages 65-74. Because of that, all other age categories will be null in the age_national and age_state tables. I think we should decide whether the age breakdown for Preventable Hospitalizations should be shown at all. Maybe we could do a "Senior Report" focusing on the 'Ages 65-74' category?

@eriwarr I believe Preventable Hospitalizations is only measuring medicare beneficiaries, so that's probably why they don't show other age groups as the data would be much more sparse. I think we can probably hide the age breakdown for now, and then yes I think we should explore doing focused reports for seniors / kids / Black / Women etc


Transpile code by modifying AST to support robust import and TLA

This commit switches to Babel to transpile input code to AST, and perform modification on the AST.
In this way, import and top-level await handling are more correct and robust.

Sample input:
import { transformAsync } from "@babel/core"
await transformAsync("import { transformAsync } from '@babel/core'")

Before this PR, the code is transpiled to
const _core3340f9ae41b54938bbef2a7e8195ab7f = require("@babel/core");const{transformAsync}=_core3340f9ae41b54938bbef2a7e8195ab7f;true.valueOf["@@replTemp"]={};if(!((true.valueOf['@@replTemp'].$v="transformAsync") in _core3340f9ae41b54938bbef2a7e8195ab7f)){delete true.valueOf['@@replTemp']["transformAsync"];{const $err=new SyntaxError(`Import named '${true.valueOf["@@replTemp"].$v}' not found in module '@babel/core'.`);$err.stack='';throw $err;}}; void _core3340f9ae41b54938bbef2a7e8195ab7f.transformAsync;
transformAsync('import { transformAsync } from "@babel/core";/*$replTranspiledImport:{"moduleIdentifier":"@babel/core","destructuredVars":["transformAsync"],"wildcard":false}*/void transformAsync;');

The original implementation mistakenly process the import in string literal, make the transpiled code not runnable.
In this PR, the code is transpiled to
// code
(async function () {
  "use strict";
  const {
    transformAsync: transformAsync
  } = await import("@babel/core");
  globalThis._repl_result = {
    vars: {},
    lets: {},
    consts: {
      transformAsync
    }
  };
  return globalThis._repl_result.vars._repl_value;
})();
// postCode
var {} = _repl_result.vars;
let {} = _repl_result.lets;
const {
  transformAsync
} = _repl_result.consts;

// code
(async function () {
  "use strict";
  var _repl_value = await transformAsync("import { transformAsync } from '@babel/core'");
  globalThis._repl_result = {
    vars: {
      _repl_value
    },
    lets: {},
    consts: {}
  };
  return globalThis._repl_result.vars._repl_value;
})();
// postCode
var {
  _repl_value
} = _repl_result.vars;
let {} = _repl_result.lets;
const {} = _repl_result.consts;

This PR handles import and TLA more properly.
Also, it uses "postCode" to extract variables defined inside wrapper function.
Besides, the original implementation uses string match to detect TLA.
If we await inside a function, the code will be mistakenly regarded as TLA code.
This PR handle this more robustly, by always using async wrapper function.

Thanks for the PR! I really appreciate the effort and attention to detail here, and this would have been great if the plan was to stay as a separate package, but sadly for the case of this PR, the plan is actually to embed the project directly into Bun itself in the near future, with native integrations et. al., so embedding the whole of Babel inside of Bun is kind of a no-go.
The same is true for SWC, but as it currently stands the current uses of SWC in the code are easily replaceable with Bun's Transpiler once it becomes usable for the REPL (needs DCE toggle), infact SWC also has an AST API and could also have done the job in this PR (but its poorly documented so I understand why you didn't use it), although it's intentionally avoided using fancy SWC things like that as those won't be as simple to port to Bun's Transpiler later in the embedded version, which will most likely have its own distinct AST API to use for this, which won't match either Babel or SWC's APIs beyond the simple transform() call. (Additionally in the case of TLA it will hopefully be made so it requires no transpilation to work)
I'm well aware the current code for those features is a beyond awful nightmare fuel and doesn't work on everything (/most) scenarios, and believe me I am also very eager be gone with that monstrous code too, but, it is only intended as temporary hackarounds in order to at least have something there for basic usage until we can get proper support from Bun Transpiler.
Given all of the above, I sadly can't take in this PR, sorry.


Add Mozilla CA cert store in the docker image and enable building from macos

Hi.
The initial reason of this PR has to do with us using a valid *.random.com certificate for our ssl enabled prometheus server, inside AWS EKS. And getting this error x509: failed to load system roots and no roots provided.
While looking at the source code i found the undocumented (and not available in the official stable chart) option --prometheus-ca-file that we could have used to mitigate this, but i decided to open this PR anyway, maybe somebody else could use the features that it introduces.
Related issue: #119
Introduces changes:

Enable building from macos LOCAL_OS=macos make docker-build by using gsed (brew install gnu-sed)
Fix a docker-for-mac issue with shared directories (docker container mounts failed) not being canonicalize (because ls -l /tmp -> private/tmp in macos) by using readlink and greadlink (brew install coreutils)
Download and verify Mozilla CA cert store in PEM format provided by curl here
Add the cert store to the docker image in an arbitrary chosen path from this list

@DirectXMan12 any chance @nicolaevladescu can get a review on this? This is a blocker for us.

@Vlaaaaaaad @nicolaevladescu I am a bit worried about adding official certificates to the image. These needs long-term maintenance and is usually not idiomatic in other kubernetes components.
As you recognized, there was --prometheus-ca-file added, but you can also use --prometheus-auth-config which lets you specify a kubernetes-style kubeconfig which can also include the whole  *.remote.com certificate chain.
So, I would rather recommend you to either a) synthesize a kubeconfig-style including the cert-chain, mount that into the container and specify --prometheus-auth-config or b) synthesize a PEM certificate chain, mount that into the container and specify --prometheus-ca-file.
As for the fixes to make this buildable from macos, do you mind to create a separate PR for this?

@DirectXMan12: hm... would modifying the helm chart at stable/prometheus-adapter to mount the host's /etc/ssl/certs/( or a customizable path since this differs a bit) be a better idea? Looking into it that's what some charts seem to do.

@Vlaaaaaaad The host's /etc/ssl/certs/ has the same Mozilla CA store but yes, i would simplify the long-term maintenance by doing it on the host side. Aside from that, maybe we can cherry pick just the Makefile macos improvements if you guys see any value in those for local development.

My suggestion is in line with @s-urbaniak -- I'd recommend mounting in your cert bundle somehow.  Either with a Secret or ConfigMap is best -- you don't always know that you can or want to mount in the host's certs (different OS paths, different permissions, etc).
I'll like @brancz and @s-urbaniak make the final decision though, since they're the primary maintainers of this repo at this point.

Thanks guys, i think we can manage without the CA part, i'll open another PR with the Makefile improvements only.


Aws::DynamoDB::PutItem() calls take around 30ms

Confirm by changing [ ] to [x] below to ensure that it's a bug:

[x] I've gone though Developer Guide and API reference
[x] I've searched for previous similar issues and didn't find any solution

Describe the bug
Aws::DynamoDB::PutItem() calls take around 30ms
SDK version number
1.9
Platform/OS/Hardware/Device
Ubuntu:18.04 on Docker
To Reproduce (observed behavior)
Aws::Client::ClientConfiguration client_conf;
client_conf.region = Aws::Environment::GetEnv("AWS_REGION");
client_conf.caFile = "/etc/pki/tls/certs/ca-bundle.crt";
Aws::DynamoDB::DynamoDBClient dynamo_client(client_conf);
Aws::DynamoDB::Model::PutItemRequest request;
request.SetTableName(...);
request.SetItem(...);
auto db_outcome =  dynamo_client.PutItem(request); // This line takes around 30ms with small items

Expected behavior
PutItem is supposed to take <10ms
I create a new client with each PutItem call. Is this the reason of the latency?

Hi @NatxoM ,
So first to answer, your question I create a new client with each PutItem call. Is this the reason of the latency? maybe? It depends on how you are taking the times, as in do you include the whole process in the 30ms or is it just the putItem call?
The sample isn't very clear on this so let me ask a few questions.

How are you measuring this times? Can you show me the full sample with these lines?
Why 10 ms? Not saying you are wrong but I can't find documentation that specifies a time range, can you point me to some or was this an estimate on how long the operation takes on CLI or the web client?
Are you sure this isn't related to you network connection?
Is the 30ms constant? or does it vary if you run the command say 10 times?

Yes, the problem was that I was creating a new client with each PutItem call. With a static client, the latency is single-digit millisecond, as Amazon promises.


[decision needed] Drop green highlighting

Not necessarily intended for merge.
In case we do want to drop the green.  Would be good to have opinion from @oheim

3b399129b3ecf8fb1891de98a77aca5a818df6d4 throws a lot of warnings
warning: terminal_escapes: some elements in list of return values are undefined
4673bb4e4262344bdcfe9e26600fed1215877052 produces an error: hiliteoff vs. hilite_off
I am using gnome-terminal with the solarized light color theme, which probably overrides the intended colors with something else.
If it was my decision, I would copy the behaviour of run_test_suite in as many details as possible. That is, (1) no colors, (2) write failed doctests into doctest.log and not on console, (3) print the number of PASS/TOTAL for each file on stdout, (4) print the total number of PASS and FAIL on stdout, (5) do not mention files without example blocks on console, but add them in doctest.log.
Integrated examples in documentation:

  …
  @infsupdec/vertcat .................... PASS    1/1
  …
  doc/chapter/advanced-topics.texinfo ... PASS   19/19

Summary:

  PASS   326
  FAIL     0

See the file doctest.log for additional details.

65 (of 278) targets have no example blocks.

For details on the formatting please see run_test_suite.

Regarding (1), I would prefer colors by default but might be convinced otherwise if there is no way to detect when stdout is not a tty (cf. #33).
I am quite strongly against (2) as default options, as I am using doctest for interactive development and it is quite useful to see the error messages on the terminal right away (likewise for (5), but there the case is not quite as strong).
I would be very glad to adopt (3). Why do you propose a different format in (4) than in (3)?
On a higher level, would it be useful to make doctest a bit more modular so that run_test_suite (which I presume is Octave's internal test suite?!) could be a small wrapper around it that does all the reporting in the "non-interactive" fashion that you prefer?

The different format in (3) vs (4) is the current behaviour of __run_test_suite__. On the individual file level you can see the fraction of good tests for that file. The overall sum at the end divides that into PASSes and FAILs.
On the strategic level it would probably solve all other points easily if doctest would write failures to stdout (and possibly halt at the first error), whereas __run_doctest_suite__ would write a log file and only give a summary. In Octave core the test function has a 'quiet' and a 'normal' switch for these different modes of operation.

@oheim @cbm755 Should __run_doctest_suite__ be part of Octave and use some API provided by doctest, or do you think it should be a tool shipped in the doctest package?

If it is solely used to call doctest, put it in the package.

If it is solely used to call doctest, put it in the package.

I agree.
FWIW, I don't like the underscores at the beginning/end which imply internal private use (to me).  I assume this is for historical reasons in Octave (not sure of that).  But seems to me run_doctest_suite would be preferable.

Some of what @oheim suggests might be more do-able after #6.  For example: I deliberately output the per-file summary after all processing all tests, so that the spammy output is self-contained and not interleaved with the summary of each file.

Yes, run_doctest_suite should be okay. Or you consider calling it rundoctests after the Octave function runtests. AFAIK, the only difference between __run_test_suite__ and runtests is that the latter does not search test targets recursively and does not write a log file and summay at the end.

Let's continue the conversion in #37.


UTF-8 support is broken

When I run
watson edit

and change the project to something with umlauts I get following result:

Mh, if I edit it with vim it works, but not with sublime-wait. tasklite.org also has support for editing tasks and there umlauts also work with Sublime. So it's possible and it should be a bug of Watson and not Sublime.

Hi @ad-si! Can you provide at least the following information on your system:

OS
Watson's release
python version that runs Watson

Thx!

$ watson --version
Watson, version 1.8.0

$ neofetch --stdout
<EMAIL_ADDRESS>-----------------------------
OS: macOS Catalina 10.15.3 19D76 x86_64
Host: Macmini8,1
Kernel: 19.3.0
Uptime: 4 days, 18 hours, 2 mins
Packages: 264 (brew)
Shell: fish 3.1.0
Resolution: 2560x1440@2x, 1920x1080@2x
DE: Aqua
WM: Quartz Compositor
WM Theme: Blue (Light)
Terminal: iTerm2
CPU: Intel i7-8700B (12) @ 3.20GHz
GPU: Intel UHD Graphics 630
Memory: 20920MiB / 32768MiB

$ brew info watson
watson: stable 1.8.0 (bottled), HEAD
Command-line tool to track (your) time
https://tailordev.github.io/Watson/
/usr/local/Cellar/watson/1.8.0_2 (983 files, 10.8MB) *
  Poured from bottle on 2020-04-01 at 09:38:52
From: https://github.com/Homebrew/homebrew-core/blob/master/Formula/watson.rb
==> Dependencies
Required<EMAIL_ADDRESS>✔
==> Options
--HEAD
	Install HEAD version
==> Caveats
Bash completion has been installed to:
  /usr/local/etc/bash_completion.d

zsh completions have been installed to:
  /usr/local/share/zsh/site-functions
==> Analytics
install: 271 (30 days), 593 (90 days), 1,950 (365 days)
install-on-request: 255 (30 days), 568 (90 days), 1,879 (365 days)
build-error: 0 (30 days)


[BUG] Error: Error: 400 Bad Request: Payload error: JSON payload (37327342 bytes) is larger than allowed (limit: 33554432 bytes).

Im trying to embed a vector db (quadrant) with langchain docs with sitemap.xml link extraction.
everything works fine and the embedding starts, but after a while I get this error:
Error: Error: 400 Bad Request: Payload error: JSON payload (37327342 bytes) is larger than allowed (limit: 33554432 bytes).
is it possible to increase the JSON payload so it can manage all links?

Is the error coming from Qdrant not able to handle too large of a payload? Or its from Flowise side that is not able to pass the payload over to Qdrant?

I got the same error, I think the qdrant client must send the data in batch mode, and I think we must be able to customize the batch_size in the qdrant node

Increase QDrant limit size is not a solution. I am trying to upload 211kb csv file and I am getting the same error.
Very strange behaviour.

@xmaiconx: increase the max file upload size for Qdrant in the custom config.yaml for Qdrant as per ur use case...this is not a limitation from flowise but Qdrant...i faced problem with a txt file of less than 1 mb. use the config.yaml for configuring Qdrant to accept big files. size of the source file is not the issue but the no of vectors that are being generated from the content of the file that is being pushed in Qdrant in a single go is the bottleneck...Qdrant by default accepts max 32 MB (33554432 bytes) in a single go...increase that size as per ur requirement and the problem goes away.

should be fixed via PR, closing for now


Android error with com master branch (iOS9 fix)

Anyone getting this error when using the latest master branch?
Could not find com.android.support:support-v4:21.0.0
Required by:
:android:unspecified > com.google.android.gms:play-services-maps:6.5.87 > com.google.android.gms:play-services-base:6.5.87

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27011837-android-error-with-com-master-branch-ios9-fix?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F637500&utm_medium=issues&utm_source=github).

Use search, read wiki. Install android and Google repository in Android SDK Manager. Getting tired of lazy people


GZDoom is incompatible with new ID24 content of Doom + Doom II

Game
Doom + Doom II
Engine
GZDoom
Linux Distribution
Ubuntu Mate 22.04.5 LTS
Luxtorpeda Version
71.0.0
Bug description
ID24 is new specification and standard for Doom mapping. It was first used there for the Legacy of Rust expansion.
https://doomwiki.org/wiki/ID24
Currently, GZDoom doesn't support ID24, thus ID24 content such as Ghoul enemy doesn't appear in the game.
It's safe to remove GZDoom package for Legacy of Rust expansion as there is currently no source port supporting it.
Steps To Reproduce

Expected Behavior

Additional Context

Relevant log output
-

Never mind, just found a port replacing ID24 content.
https://www.doomworld.com/forum/topic/147764-actors-id24-to-gzdoom-port/

Interesting does that look like you can copy that file in the right spot and itll work? Are you able to replicate that?

id24res.wad needs to be put GZDoom config folder. Then putting -file id24res.wad should run it. However it gives an error indicates that it requires GZDoom 4.11 or newer.

Sounds like for now, I can remove it from use.
If/when gzdoom and/or mesa gets fixed, I can update to newer versions of gzdoom.

I've removed it for now, since it's not working. Thanks for letting me know


uuid() support

This adds uuid() support (and fix my issue #29). Requires uuid module (optional using a dynamic import)

Hey @Toilal, thanks for your merge request. I prefer a more predictable result without the need for a dependancy. Also I like it to be able to run in browser environment (rather than node only).

I have implemented uuid in version 0.6.0


Hindi Language Support

Is your feature request related to a problem? Please describe.
I would like to propose the addition of Hindi language support to FreeCodeCamp.
Describe the solution you'd like
With a large population of Hindi speakers worldwide, including India, Nepal, and other regions, providing content in Hindi would greatly enhance accessibility and inclusivity for learners who prefer or are more comfortable with the Hindi language.
Describe alternatives you've considered
Impact:
Reach a wider audience.
Empower Hindi-speaking learners.
Additional context

You are welcome to joining the translation efforts, article: https://www.freecodecamp.org/news/help-translate-freecodecamp-language/


Cosmos Encryption public build prerequisites

[ ] https://github.com/Azure/azure-sdk-for-java/issues/20374
[ ] https://github.com/Azure/azure-sdk-for-java/issues/20375
[ ] https://github.com/Azure/azure-sdk-for-java/issues/20376
[ ] https://github.com/Azure/azure-sdk-for-java/issues/20377
[ ] https://github.com/Azure/azure-sdk-for-java/issues/20378

It is covered in separate issues


Inconsistent type handling between backends

The following code works correctly with the jax backend:
import os

os.environ['KERAS_BACKEND'] = 'jax'
from keras_core import ops

r1 = ops.numpy.arange(10, dtype='float32')

c1 = r1 + 1j * r1

print(c1)

Switching to tensorflow backend:
import os

os.environ['KERAS_BACKEND'] = 'tensorflow'
from keras_core import ops

r1 = ops.numpy.arange(10, dtype='float32')

c1 = r1 + 1j * r1

print(c1)

Throws: TypeError: Cannot convert 1j to EagerTensor of dtype float
Potentially related, the following runs OK with the jax backend:
import os

os.environ['KERAS_BACKEND'] = 'jax'
from keras_core import ops

r1 = ops.numpy.arange(10).astype('float32')

While the tensorflow backend:
import os

os.environ['KERAS_BACKEND'] = 'tensorflow'
from keras_core import ops

r1 = ops.numpy.arange(10).astype('float32')

Throws:
AttributeError: EagerTensor object has no attribute 'astype'.
        If you are looking for numpy-related methods, please run the following:
        from tensorflow.python.ops.numpy_ops import np_config
        np_config.enable_numpy_behavior()
      . Did you mean: 'dtype'?

Running enable_numpy_behavior() does resolve the issue, but I don't like the idea of having to modify the default TF behaviour to make it work.  I assume that, if the developer goes via the keras_core.ops API, the same code should work with both backends as-is?
Package versions:
jax==0.4.14
jaxlib==0.4.14
keras-core==0.1.5
numpy==1.24.3
tensorflow==2.13.0

Thanks,
Luca

Like in the other issue linked, this is caused by the use of tensor methods: which methods are available and what they do depends on the backend framework because your tensors are backend-native tensors.
In order to get a fully standardized API surface, don't use tensor methods and instead us keras.ops, e.g. ops.add or ops.cast.
Do note that using Python operators such as + or @ will call into the object's methods. It will not call into keras.ops.


[AutoDiff] Show unmet @differentiable attribute requirements.

Show unmet @differentiable attribute requirements in diagnostic for
easier debugging.

Contrived example:
@differentiable(where T == T.TangentVector)
func foo<T: Differentiable>(_ x: T) -> T {
  x
}

func bar<T: Differentiable>(_ x: T) -> T {
  foo(x)
}

struct Foo : Differentiable {}
_ = pullback(at: Foo(), in: { x in bar(x) })

# Before:
test.swift:9:3: error: expression is not differentiable
  foo(x)
  ^
test.swift:9:3: note: function call is not differentiable because generic requirements are not met
  foo(x)
  ^

# After:
test.swift:9:3: error: expression is not differentiable
  foo(x)
  ^
test.swift:9:3: note: function call is not differentiable because generic requirements are not met: 'T == T.TangentVector'
  foo(x)
  ^

@swift-ci Please test tensorflow


feat: export parseRetryAfterHeader utility

Description
Export the new utility parseRetryAfterHeader so that it can be reused also in aio-lib-events library.
Related Issue

Motivation and Context
Reduce code duplication in aio-lib-events. Allow users of this library to reuse the parseRetryAfterHeader function.
How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@shazron could you have a look?

4.1.0 published


Improve warnings display

ayu:

dark:

Does this affect the "not latest version" warning too? Can we get screenshots of that?

Good point, checking!

Default color:

Color with hover:

We might want to make the color without hover a yellow?

For me it's yellow/orange by default?

 Since we changed the color in the display, it's the same in the topbar haha. So this'll be the same problem for ayu. Need to think about that...

Updated!

The warnings look a lot better :)


Re-enable IE 11 support

webpack's default behavior changed with the version 5, it needs extra target info and babel .mjs file transpilation (html-react-parser has a index.mjs file, which forces esm module syntax, which needs to be transpiled by babel)
Closes #3416
User changes

IE 11 users will be able to use ANET

Super User changes

Admin changes

System admin changes

[ ] anet.yml or anet-dictionary.yml needs change
[ ] db needs migration
[ ] documentation has changed
[ ] graphql schema has changed

Checklist

[X] Described the user behavior in PR body
[X] Referenced/updated all related issues
[X] commits follow a repo#issue: Title title format and these 7 rules
[X] commits have a clean history, otherwise PR may be squash-merged
[ ] Added and/or updated unit tests
[ ] Added and/or updated e2e tests
[ ] Added and/or updated data migrations
[ ] Updated documentation
[X] Resolved all build errors and warnings
[ ] Opened debt issues for anything not resolved here

Against :8080 it now works again with IE11, but against :3000 I get:

Against :8080 it now works again with IE11, but against :3000 I get:

will look into that


Self-document the prediction API endpoint

Overview
A useful API will tell you how to use it. Update the API endpoints to be more helpful!
Expected Behavior
Currently, there is just a placeholder if you GET our prediction API endpoints. We expect this call to tell us what the endpoint does, what the required parameters are, and what it returns.
To do this, we'll need to update our response payload to have that information.
Technical details

This feature should be implemented in the prediction/src/views.py
For each algorithm, we should add the right: description, expected_parameters, return_values
This feature should have tests for each algorithm in prediction/src/tests/test_endpoints.py

Acceptance criteria

[ ] accurately documents all three prediction endpoints
[ ] has passing tests

NOTE: All PRs must follow the standard PR checklist.

Closed in https://github.com/concept-to-clinic/concept-to-clinic/pull/66. Thanks !


chore(*): suspensive with toss

Overview

PR Checklist

[x] I did below actions if need

I read the Contributing Guide
I added documents and tests.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@d6f0f4e). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage        ?   83.44%
=======================================
  Files           ?       33
  Lines           ?      435
  Branches        ?       99
=======================================
  Hits            ?      363
  Misses          ?       62
  Partials        ?       10

Components
Coverage Δ

@suspensive/react
96.98% <0.00%> (?)

@suspensive/react-query
13.79% <0.00%> (?)

@suspensive/react-await
100.00% <0.00%> (?)

@suspensive/react-image
23.52% <0.00%> (?)


CronTab configuration

Fix #69 69

push -f didn't create a new PR for me, can I get a hint?

push -f didn't create a new PR for me, can I get a hint?


add description to security scheme per spec

Adding a description field to SecurityScheme enum. Not sure if it's preferred to repeat the field across all variants, but anything else might be messy.
Spec:
https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.0.md#securitySchemeObject

Thanks for this. I think the approach you took is the right one.


Add support matrix

Is your feature request related to a problem? Please describe.
Users don't have a place to find what's supported with what. For example, a user asks what the minimum JVM runtime environment is.
Describe the solution you'd like
Publish a set of support matrices in the product documentation, showing OS, JVM, browser configurations we've tested with, and inter-compatibilities between product versions.
via @julesg, Probably should cover "validated" or "tested" configurations rather than "supported" ones... since the project itself doesn't offer 'support' in the same way a commercial service might.

https://github.com/opensearch-project/documentation-website/pull/62


Fix automated determination when GCP is cloud provider

Also update README to describe CLOUD_PROVIDER env var, which is useful for custom provisioning scenarios.

@balena-ci I self-certify!


Switching from elasticsearch-elasticsearch to elastic-elasticsearch

I want to switch from the old
https://forge.puppet.com/elasticsearch/elasticsearch/changelog#0110--may-23-2016-
to
https://forge.puppet.com/elastic/elasticsearch/changelog#0110--may-23-2016-
and then study how to upgrade the whole thing.
But changing the Puppet Forge repo in the Puppetfile throws this error:

The module release elastic-elasticsearch-0.11.0 does not exist on https://forgeapi.puppetlabs.com/.

What to get from this? The changelog is there but the files are on the old repo?

The new namespace in the forge only holds versions 5.x onward, the other versions in the changelog under the elastic/elasticsearch namespace are artifacts from the module's history. The old namespace should have every version pre-5.x.


mp-build Advanced setting requirement

Describe the bug
When using the SDK tools, if the user's Docker docker socket is not enabled by default, the tools assume Docker is not running.
Reproduction steps
Disable default Docker socket in advance settings:

Expected behavior
If Docker is running but can't detect the socket, the tools should be more explicit about the cause of the error (Unable to connect to the Docker daemon socket). This should also be mentioned in the requirements section.
Additional context
No response

We need to do 2 things:

Document this requirement
Update code to prompt user to check this setting on error


Add fmt and zstd dependencies using FetchContent_Declare

Linked Case: SKETCH-2033
Primary Reviewer: @ricrogz

Description
Branch with an example of using FetchContent_Declare to pull down fmt and zstd. Ricardo originally set this up in a branch by creating a series of bash scripts that build each dependency -- that works, but I recently found FetchContent and wanted to give it a try. The advantage I see is that we'd only have to build the components of each dependency that rdkit_extensions/sketcher actually need. Note the FIND_PACKAGE_ARGS argument, which allows the cmake script to pybass pulling down source if the package is already found.
The posted changes include:

a simple header/library source/executable to demonstrate the dependencies work
a simple github action that will cache built dependencies if the workflow succeeds
a Schrodinger-env specific helper script for us to be able to compile locally with software/lib/

I left a couple of TODOs throughout, but the main issue I'm having is that the Windows CI fails with LNK2019: unresolved external symbol though as far as I can tell, Im using the dllimport/dllexport correctly. Still working on that.
Also, zstd as part of the cmake project has two annoying quirks that aren't present when using targets from an installed zstd:

it neither uses the zstd:: namespace for targets that are otherwise installed/exported. I manually alias it in that case, but don't need to do this if I run locally with software/lib/.
the libzstd_static target doesn't automatically set includes; see https://github.com/facebook/zstd/issues/3758
Not sure what the best way to deal with these, or if this is a sign that I shouldn't be using FetchContent.

Next review: add in boost and boost's unit_test_framework.
Testing Done

CI on all 3 platforms
Ran >$SCHRODINGER/run schrodinger_build.py && ./build/sketcher_app locally

which allows the cmake script to pybass pulling down source

Too much python.

which allows the cmake script to pybass pulling down source

Too much python.

Spoonerism!


MDSClient: Using new distance functions?

The DistanceFuncs header now includes cosine and JS distances, but the enum in MDS doesn't yet account for these. Question for @g-roma : should it?

I have fuzzy memories, but these were added for the external looping / graulation ugens. I guess they could be added to MDS.


update(UserData): Watch user data - 140

Description
Important information

Other parts of the app, that appear an user, like contacts list, blocked page, they are not with watch user stream yet, will be changed later with other PRs

0. User data being updated on Add Friend Page, Chat Room Page and Qr Code Scanner Dialogs
https://user-images.githubusercontent.com/63157656/198132428-f414118a-470e-4dcc-854e-4d61f9db10d7.mov
https://user-images.githubusercontent.com/63157656/198132761-a472df07-9e1f-4c98-9cc7-405ffdc7fd29.mov
1. Watch User Event
a. This event is looking for user data on each 1 second, and observing if there is an update

b. The data comes as Map<String, dynamic>? and it will be transformed on FriendBloc

c. It can be updated with all user info, username, message status, profile picture, banner picture, status and relationship
2. Stream Watch User, this stream has some particularities
a. It is not working compare two maps, when we have relationship map inside of them as well, so the first comparison to verify if there is an update, is to compare oldUserMap with newUserMap without relationship, after comparison, the data from newUserMap is passed to oldUserMap

b. The next step on this stream is to compare two maps about users relationship, after the comparison, the new data is passed to oldRelationshipMap

c. If there is new information on user parameters or relationship parameters, a new data will be yielded

d. If there is an error saying that identity was not found, it will not stop the stream, but will yield null data

3. Other code details
a. Fixed UStatusText, the status indicator was off center relative to the status text

Type of Change

[x] 🛠 Bug fix (non-breaking change which fixes an issue)
[x] 🧹 Code refactor

Awesome PR 🔥


Fix wrong role create db#285

resolves #285
Description
The CreateDabase operation is performed with the caller role. We want it to be performed by the glue session role_arn provided in profiles.yml.
Checklist

[X] I have signed the CLA
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nicor88


Can't click on 3d sprites using Camera3DPlugin

I am trying to click on a Sprite3D with no luck.  I'm using the camera like this:
camera = this.cameras3d.add(85).setZ(350).setPixelScale(16);
When I register the click handler nothing happens
      sprite.on('pointerup', function() {
         // do something to the cookie
         // this.doSomething();
         console.log("got click");

      }, sprite);

I also looked into camrea.unproject and camera.getPickRay  Both of which give me results in a coord system I don't understand.  If camera.getPickRay (undocumented) is supposed to return a ray into the scene, I should be able to "Advance" the ray and hit an object.  This also gives me wrong results.  Thanks.

Sorry, but Camera3D was removed from Phaser in 3.12 and remains an unsupported 3rd party plugin. I'm afraid no time will be spent trying to make it work with the main API beyond what it already does. The 3rd party lib it comes from was fully undocumented as well, which doesn't help matters.

who was the last maintainer. and would you guys accept pull requests if they were mutually deemed as helpful or increased documentation?

Here after having the same problem, but later for simple shapes, got a temporary workaround:
The camera does provide a ray when giving (x,y) on window.
The example I used to test is : http://labs.phaser.io/edit.html?src=src\camera\3D%20camera\floor.js
at line 33 add a variable to remember objects:
var balls = camera.createRect({ x: 8, y: 1, z: 8 }, 32, 'ball');

Inside create():
    balls.forEach( function(ball){
        ball.setData('tag', 'ball'+ball.x+':'+ball.y+':'+ball.z);
    } )

    this.input.on('pointerdown', function (pointer) {

        ray = camera.getPickRay(pointer.x, pointer.y);
        balls.forEach( function(ball){
            // r is hardcoded here
            let r = 4;
            // calculate x y @ z of the object
            let tx, ty;
            let tz = ball.z;
            tx = ray.origin.x + ray.direction.x * (tz - ray.origin.z ) / ray.direction.z;
            ty = ray.origin.y + ray.direction.y * (ray.origin.z - tz) / ray.direction.z;
            let tl = Math.sqrt( Math.pow(tx - ball.x, 2) + Math.pow(ty - ball.y, 2) );
            if( tl < r ){
                console.log(ball.getData('tag')+' isHit');
                ball.gameObject.alpha = 0;
            }
        } );

    }, this);

Also relates to #5105 , so I could only use .gameObject.alpha = 0 here.
Does not work on complex shapes ( for obvious reasons )
Did not sort z level, so object on the same ray will all be triggered


Flaky test fix: testHandleNotificationWithWithExpiredAuthenticationToken

In the test case testHandleNotificationWithWithExpiredAuthenticationToken, an expired token is initialised using the constructor of AuthenticationToken.java. This method uses a function called toMap() which makes use of a HashMap to form the signature signatureBytes. This signature is verified using a verify function.
Since HashMap does not guarantee the order of the items in the map, the signature may suffer from non-determinism, causing the verify function to fail, making the test flaky.
I found and confirmed the flaky behavior using an open-source research tool NonDex, which shuffles implementations of nondeterminism operations.
This PR fixes the test by replacing HashMap with LinkedHashMap. Since LinkedHashMap retains the order of insertion, this fixed the flakiness of the test.
The following command can be used to reproduce assertion failures and verify the fix:
mvn edu.illinois:nondex-maven-plugin:2.1.1:nondex -pl broker -Dtest=com.eatthepath.pushy.apns.server.TokenAuthenticationValidatingPushNotificationHandlerTest#testHandleNotificationWithWithExpiredAuthenticationToken

This line invokes the toMap() function:
https://github.com/KiruthikaJanakiraman/pushy/blob/da5f8b97106cd41278b421ec63e4e76a7313bed9/pushy/src/main/java/com/eatthepath/pushy/apns/auth/AuthenticationToken.java#L158
The toMap() function creates a HashMap here:
https://github.com/KiruthikaJanakiraman/pushy/blob/da5f8b97106cd41278b421ec63e4e76a7313bed9/pushy/src/main/java/com/eatthepath/pushy/apns/auth/AuthenticationToken.java#L132
The assertion happens here:
https://github.com/KiruthikaJanakiraman/pushy/blob/da5f8b97106cd41278b421ec63e4e76a7313bed9/pushy/src/test/java/com/eatthepath/pushy/apns/server/ValidatingPushNotificationHandlerTest.java#L273
Test Environment:
openjdk version "<IP_ADDRESS>"
Apache Maven 3.6.3
Ubuntu 20.04.6 LTS
Linux version 5.4.0-156-generic

Please let me know if you have any concerns or questions.

Reviewed the PR and the fix looks good.

Reviewed and looks good!


RTD: Fix alert blockquotes

Description
Alert blockquotes are not rendered by read the docs. We should fix them somehow so the docs won't look like this:

@levaitamas i think you mentioned this issue somewhere, but could not find it. Do you have any idea how we could/should fix this?

I recommend we remove the special blockquote syntax. It's not portable and even GitHub routinely breaks rendering. Just use running text line "Note that..." etc.

Should be fixed in latest. @davidkornel, can you please double check here: https://docs.l7mp.io/en/latest/?

Fixing the current stable seemed too much hustle. In case the latest looks good, the next stable (i.e., v1.0.0) will be rendered correctly too.

Just for the record, this was the fix: https://github.com/l7mp/stunner/commit/5596d84d81d286ab9e36b2f341525df25234a43d

Missed it, thanks. Closing this.


Migrate Schwarz icon consumers to new icon library

Depends on

#1802

Why?
We want to have one unified icon library at Schwarz IT which is used by all UX designers (Figma) and developers.
Technically we already synched @sit-onyx/icons with the Single-Source-of-Truth Figma file linked below (see #939).
We now want to onboard/migrate all consumers of the current SIT icon library to use the new unified library, this includes:

STACKIT
ODJ
Twogo
CoreUI

For responsible contacts for the consumers above, you can refer to @larsrickert
So eventually, all designers will consume the Icon Library - UX Schwarz IT Figma library and all developers will consume the @sit-onyx/icons npm package.
Design
Icon Library - UX Schwarz IT
Acceptance criteria

onyx is migrated to use the new icon library

[ ] UX
[x] DEV

STACKIT is migrated to use the new icon library

[ ] UX
[ ] DEV

ODJ is migrated to use the new icon library

[ ] UX
[ ] DEV

Twogo is migrated to use the new icon library

[ ] UX
[ ] DEV

CoreUI is migrated to use the new icon library

[ ] UX
[ ] DEV
[ ] Icon repository is locked or deleted
[ ] npm package @scu/icons package is either deprecated or updated to use the latest @sit-onyx/icons
CoreUI's icon showcase is deleted and linked to the onyx icon docs instead

[ ] @schwarz-ux/icons repo is locked/deleted and npm package is either deprecated or updated to use the latest @sit-onyx/icons
[ ] all consumers are informed about the changes (e.g. via Teams)

Definition of Done

[ ] follow-up tickets were created if necessary
[ ] updated version + documentation is deployed
[ ] Namings are aligned with Figma

Approval

Deployed Docs
[ ] approved by onyx designer @jannick-ux
[ ] approved by onyx dev
[ ] approved by STACKIT
[ ] approved by ODJ
[ ] approved by Twogo
[ ] approved by CoreUI

Maybe a new or another nom package with a generic naming? @schwarzit/icons?

Check if we can display or link to an own url something like icons.schwarz?

Maybe a new or another nom package with a generic naming? @schwarzit/icons?

The scope @schwarzit/* in npm was created by a former colleague at SIT, I am already in contact with @patrick246 to get access to it :) Imo @schwarzit/icons would be very nice!

Check if we can display or link to an own url something like icons.schwarz (public) - is also a internal domain possible?

@mj-hof I guess icons.schwarz should not be a problem, should I order it? Since its a public domain it may take some time before its ready for us. I would not make it internal since we also need it for onyx which is Open Source. Also internal domains are no longer allowed to use *.schwarz


chore(Logic/ExistsUnique): amend usages of existsUnique to follow naming convention

As a definition ExistsUnique, the spelling of usages should be existsUnique rather than exists_unique. The majority of applications already conform to this (96), but there are some (30) exceptions. This PR fixes those.
The large import is the import of Tactic.Alias to Logic.ExistsUnique, and is necessary if deprecations are to be performed here.

bors merge


Fix for reselecting a TileMap node without first de-selecting it #44824

Fixes #44824

Thanks!

Thanks!


Add release note about CUDA 10.1 and cuDNN 7.6

Good note. Two comments:

CUDA 10.2 isn't integrated right? Do you know if there's an issue where CUDA 10.2 integration is tracked?
Which exact cuDNN version? 7.6.5?

We build and test against cuDNN v<IP_ADDRESS>. But you should be able to install any 7.6 version and run the TF pip package with it.
CUDA 10.2 is not yet supported, and I'm now aware of any tracking issue. We might actually want to wait for CUDA 11, which shouldn't be too far out.


Add a property group for compressing RPC requests/responses with a threshold

Declined because the only large request is SendNotificationRequest that consists of the heavy text sent by a user.
Considering the CPU usage, Compression Ratio/Speed, and memory usage, it's not worthy to compress/decompress.


Remove OpenSSL and SQLite3 from FreeBSD images.

Still a draft: I need to add a CHANGELOG entry to this, but the rationale is as follows: FreeBSD's packagelist doesn't provide downloads for the correct versions of OpenSSL and SQLite3. For example, using the following settings:
$ pkg_source="https://pkg.freebsd.org/FreeBSD:12:amd64/quarterly"
$ curl --retry 3 -sSfL "$pkg_source/packagesite.txz" -O
$ tar xvf packagesite.txz
$ openssl_ver=$(jq -c '. | select ( .name == "openssl" ) | .version' "packagesite.yaml")
$ openssl_ver=${openssl_ver//'"'/}
$ echo "${openssl_ver}"
1.1.1q,1
$ wget "${pkg_source}/All/openssl-${openssl_ver}.txz"
Will not apply HSTS. The HSTS database must be a regular and non-world-writable file.
ERROR: could not open HSTS store at '/home/ahuszagh/.wget-hsts'. HSTS will be disabled.
--2022-07-15 00:59:00--  https://pkg.freebsd.org/FreeBSD:12:i386/quarterly/All/openssl-1.1.1q,1.txz
Resolving pkg.freebsd.org (pkg.freebsd.org)... 2610:1c1:1:606c::50:1, <IP_ADDRESS>
Connecting to pkg.freebsd.org (pkg.freebsd.org)|2610:1c1:1:606c::50:1|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2022-07-15 00:59:01 ERROR 404: Not Found.

Note that this doesn't reproduce with other packages, such as zstd. In short, FreeBSD builds are fragile, especially with their packages, and we can't trust the package lists to actually contain the package versions they describe. We've removed openssl for every other image: it's natural to remove it here as well.


Create Eventsub-specific CustomReward model

Pull request summary
Creates an Eventsub-specific model for Custom Channel Point rewards.
Fixes #254
Checklist

[x] If code changes were made then they have been tested.

[x] I have updated the documentation to reflect the changes.
[ ] I have updated the changelog with a quick recap of my changes.

[x] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Will test soon and update docs appropriately.

As it turns out I will be unable to test the Channel Point Reward Add/Update/Remove endpoints so any assistance with that will be appreciated.

This appears to be missing typings

Confirming that this pull request works great for me, fixing #254 and enabling CustomReward handing in my bot.  Thanks VERY much!

Thanks for the pr!


PARQUET-1167: [C++] FieldToNode function should return a status when throwing an exception

@wesm @xhochy Can one of you review when you get a chance? Thanks!


Poor formatted of expressions with dots / extra spaces

Hi,
After upgrading rustfmt stable (using rustup), rusftmt add unexpected spaces in expressions containing many dots.
This is a problem in der-parser and oid-registry, since the notation of a OID is a path with digits and dots.
These spaces seem to be added always after the third group (see examples).
Input
let oid = oid!(1.2.840.1135<IP_ADDRESS>);
let oid2 = oid!(<IP_ADDRESS>);

Output
let oid = oid!(1.2.840 .113549 .1 .1 .5);
let oid2 = oid!(2.5.4 .3);

Expected output
let oid = oid!(1.2.840.1135<IP_ADDRESS>);
let oid2 = oid!(<IP_ADDRESS>);

Meta

rustfmt version: rustfmt 1.4.24-stable (eb894d5 2020-11-05)
From where did you install rustfmt?: rustup

Thanks for reaching out @chifflier, what version of rustc were you using before your update, and what version have you updated to? Guessing 1.46.0 (or earlier) and 1.48.0 respectively
What I think you'll find is that prior to your update, rustfmt was actually failing to format those macro calls entirely and simply leaving your original code in place. Due to the incorporation of some upstream rustc changes, rustfmt is now able to work with and format this, and the formatting you are seeing is the result of some legacy formatting styles for nested tuple access.
I've included some additional context/background for you below, followed by some available options you can take
Background
To demonstrate what has actually been happening with the code you provided, try running rustfmt from stable 1.46.0 using this intentionally misformatted version of your code:
fn foo() {
    let oid = oid!(
                1.2.840.1135<IP_ADDRESS>       );
let oid2 = oid!(2.      5                      .4                 .     3         );
}

$ rustc -V
rustc 1.46.0 (04488afe3 2020-08-24)

$ cat foo.rs
fn foo() {
    let oid = oid!(
                1.2.840.1135<IP_ADDRESS>       );
let oid2 = oid!(2.      5                      .4                 .     3         );
}

$ rustfmt foo.rs --emit stdout
/........./foo.rs:

fn foo() {
    let oid = oid!(
                1.2.840.1135<IP_ADDRESS>       );
    let oid2 = oid!(2.      5                      .4                 .     3         );
}

From 1.46.0 to 1.47.0 there were some notable upstream changes in rustc to support nested tuple access which actually caused issues for us in rustfmt due to a rustc parser bug in the associated spans
$ rustc -V
rustc 1.47.0 (18bf6b4f0 2020-10-07)

$ cat foo.rs
fn foo() {
    let oid = oid!(
                1.2.840.1135<IP_ADDRESS>       );
let oid2 = oid!(2.      5                      .4                 .     3         );
}

$ rustfmt foo.rs --emit stdout
thread 'main' panicked at 'bad span: `.`: ``', src/tools/rustfmt/src/source_map.rs:52:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'bad span: `.`: ``', src/tools/rustfmt/src/source_map.rs:52:13
/........./foo.rs:

fn foo() {
    let oid = oid!(
                1.2.840.1135<IP_ADDRESS>       );
    let oid2 = oid!(2.      5                      .4                 .     3         );
}

What you're now seeing in the version of rustfmt that ships with 1.48.0 is that the rustc parser bug has been fixed, and rustfmt is now, finally able to apply formatting rules. For legacy/historical reasons (which I described in more detail in https://github.com/rust-lang/rustfmt/issues/4355#issuecomment-723764276), rustfmt has inserted the extra space because until the recent upstream changes because not doing so would've resulted in the formatted code causing compilation issues in many cases.
Due to rustfmt's stability guarantee, we cannot change that default behavior as it would cause issues for folks that formatted their code (successfully) with the older versions of rustfmt
$ rustc -V
rustc 1.46.0 (04488afe3 2020-08-24)
$ echo "fn foo() { oid!(  2  .5  .4); }" | rustfmt
fn foo() {
    oid!(2.5 .4);
}

Options
If the default behavior of those extra spaces is problematic for you then you can either:

add version="Two" to your rustfmt config file (or use the cli override --config version=Two)
leverage the skip attributes to have rustfmt leave them alone, either holistically via #[rustfmt::skip::macros(oid)]  or individually via #[rustfmt::skip]

$ rustc -V
rustc 1.48.0 (7eac88abb 2020-11-16)
$ cat bar.rs
fn bar() {
let oid = oid!( 1 . 2   .840 .113549 .1 .1 .5);
let oid2 = oid!(  2.5.4 .3);
}
$ rustfmt bar.rs --emit stdout --config version=Two
/........./bar.rs:

fn bar() {
    let oid = oid!(1.2.840.1135<IP_ADDRESS>);
    let oid2 = oid!(<IP_ADDRESS>);
}

Hi @calebcartwright ,
Thanks for the reply and the explanations!
I confirm your thoughts on rustc versions: it "worked" (left unchanged content) using 1.46, raised errors using 1.47, and current version (from my issue) is 1.48.
I am testing the solutions you proposed

I tested the skip attribute to the entire crate. Unfortunately, the skip macro cannot be applied as an inner attribute (error[E0658]: non-builtin inner attributes are unstable)
The version="Two" config value seems to work, with very little side effects (other lines changed). I'm curious why this affects the formatting?

Additional question: is version=Two considered stable, and usable in CI? The option is accepted when added to the command line of cargo fmt, but not if I add it to .rustfmt.yml:
Warning: can't set `version = Two`, unstable features are only available in nightly channel.`

Both are using the same version:
cargo fmt -- --version
rustfmt 1.4.24-stable (eb894d5 2020-11-05)
rustfmt --version
rustfmt 1.4.24-stable (eb894d5 2020-11-05)

Unfortunately, the skip macro cannot be applied as an inner attribute (error[E0658]: non-builtin inner attributes are unstable)

Hmm, I thought tool attributes were fine as inner attributes. Are you sure you're using 1.48.0? https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=823b9832c37480c3edce895afd2b900a

I'm curious why this affects the formatting?

Docs on the config option can be found here (including the in-source link since the anchor for version seems to be broken on the site)
https://github.com/rust-lang/rustfmt/blob/rustfmt-1.4.28/Configurations.md#version
https://rust-lang.github.io/rustfmt/?version=v1.4.27&search=#version
The stability guarantee that was put in place as part of the initial launch of rustfmt places some pretty stringent constraints that make it tricky to change anything about the formatted code rustfmt emits. There's a constraint that, except in cases of genuine bug fixes within rustfmt (like this one), new syntax, etc., that newer versions of rustfmt can't change the formatting of code formatted with previous versions of rustfmt (i.e. a rustup update ... && cargo fmt -- --check can never fail).
So even in cases like nested tuples where syntax/parser changes enable us to provide objectively better formatting, we can't make that new/better formatting the default due to that constraint, and have to gate the default formatting changes behind a feature-flag of sorts, which is the version config option.
Folks that opt in to this version = "Two" are agreeing to get the newer/improved formatting but also accepting that when they update to a newer version of rustfmt there is a chance it could make some (typically minor) formatting changes.

Additional question: is version=Two considered stable, and usable in CI?

No that option is still unstable. I should've remembered that given you shared you're working stable, sorry about that.

Unfortunately, the skip macro cannot be applied as an inner attribute (error[E0658]: non-builtin inner attributes are unstable)

Hmm, I thought tool attributes were fine as inner attributes. Are you sure you're using 1.48.0? https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=823b9832c37480c3edce895afd2b900a

I was trying to apply the attribute to the entire crate using an inner attribute (#![rustfmt::skip::macros(oid)], note the !) to src/lib.rs, which gave the error message.
After more tests, I think the stable solution is to add the skip attribute to every file containing calls to oid. This solution is fine, I'll use that until version 2 becomes stable.
Additionally, I just found that the skip statement must appear after the use der_parser::oid import to work - which seems logic - I just hit that because I tend to regroup attributes at the top of the file.

[...]

Additional question: is version=Two considered stable, and usable in CI?

No that option is still unstable. I should've remembered that given you shared you're working stable, sorry about that.

Thanks for all the details and explanations!

I was trying to apply the attribute to the entire crate using an inner attribute (#![rustfmt::skip::macros(oid)], note the !) to src/lib.rs, which gave the error message.

Nuts, sorry about that, typo :smile:

After more tests, I think the stable solution is to add the skip attribute to every function calls to oid. This solution is fine, I'll use that until version 2 becomes stable.

Going to go ahead and close this one as there's no real action for us to take, but thanks again for reaching out!


Training routine

Hey,
I am trying transfer learning on my data with given weights. Do you have updated training routing script for this?Do you now if it possible to translate Theano weight to Pytorch?
Thanks, VY

Hey @relyativist,
Thanks for your interest in our work!
I've added a relatively complete end-to-end demo of transfer learning at app/examples/transfer.ipynb. Try to train and fine-tune with your own data, and see if you can get to perform reasonably well. I've added annotations, wherever necessary, to get you up and running.
I've illustrated a single instance of the layer freezing (or unfreezing) and model (since there's a CNN-1 and a CNN-2) combination, so you can experiment with different combinations and see what works best for you.
If there are any questions or issues getting the notebook to run, please post here.
Best,
Ravnoor

From my brief research, it looks like it isn't possible to convert theano weights to pytorch directly or indirectly via keras2onnx.
I might port the code over to pytorch eventually, but that's probably more than six months away. I'll open an issue to serve as a reminder.

@ravnoor Thanks for complete response and support. In your example inference.py in tree directory markdown you mentioned about stereochastic native MRIs, but I didn't find whether labels should also be in t1 native or MNI? I didn't find corresponding transformation in NoelImageProcessing regarding labels. Thanks VY

Yes, the labels are expected to be in the same stereotaxic space as the T1- and T2-weighted images, in this case, MNI152.
You're right, the labels aren't transformed to the template space yet. Thanks for pointing that out! I'll fix that next week.

Hi,
I successfully tuned mode with fixed layers on model[1], and saved learnt model with frozen layers in model[0], thanks for guide. However, I have an issue with model inference on new model in example notebook on last cell inference, because it ran too long, what actually progress of predict_stochastic means as it ran too long for one subject, thank you.

predict_stochastic is a helper function that loops over mini batches of data during DropoutMC inference to make it less GPU memory intensive.
It shouldn't take too long. How much RAM are you currently working with? Are you using a GPU for compute?

@ravnoor Yes, I am using GPU with 12 gb of ram, and it utilise about 9 gb with batch_size=4096. Actually, It didn't finish after 12 hours for 1 subject

How about the system RAM?

How about the system RAM?
Does the inference exit with or without an error?
Also, make sure your inputs (T1 and T2 images) are correctly co-registered and skull-stripped (gh-6). If they are not, the number of input patches to the network will be overwhelmingly large. This might partially explain why the network takes so long.

@ravnoor Thank you for tip with memory alloc. Resolved the issue tuning batch size, so the inference finished successfully. I have additional questions regarding results. I experimented with performance set to true  during test model, I have additional output with files noel_deepFCD_dropoutMC_FCD_42_1_out_morph_labels.nii.gz and noel_deepFCD_dropoutMC_out_CNN.nii.gz, what this files mean?
Additional question regarding file FCD_42_1_noel_deepFCD_dropoutMC_prob_var_1.nii.gz,  from reference this is probability map of fcd roi lesion, however maximum value of this map is 0.24, what actually this value means?
Sorry, it this answers on this are posted early somewhere.

I'm glad it worked out for you!
The *out_morph_labels.nii.gz file is the product of a series of morphological operations following thresholding (probability- and size-based) described here. The purpose is to generate a binary output and compare with the the ground truth (if available), and quantify the number of false positives.
Looks like *out_CNN.nii.gz no longer exists in the most recent commit. If you let me know the version commit (SHA) you're using, I can look into it.
*prob_var_{0,1}.nii.gz is the uncertainty (or variance) image resulting from 20 or 50 forward passes through the network. Thus, the range (0,0.3) is reasonable. *prob_mean_{0,1}.nii.gz is the probability image with the range (0,1).


WIP Fix: init=False in dataclass fields ignored

Change Summary

Added init attribute to FieldInfo and Field
Added check for init in make_pydantic_fields_compatible
Added test to confirm init=False fields don't show up in the signature
Corrected docstring for init_var

Related issue number
WIP Partial fix for https://github.com/pydantic/pydantic/issues/8454

Previously, setting init=False in std field and pydantic's Field had no effect, the field still appears as a parameter in the generated __init__

Checklist

[ ] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Notes

Haven't updated docs for the new init parameters yet.
Unfortunately, can still use the init=False fields as parameters in the dataclass constructor... I think this is because of pydantic allowing the "extra" params that aren't explicitly defined
Even setting ConfigDict(extra='forbid') doesn't lead to throwing a ValidationError. From some debugging, it doesn't look like the model schema understands the init=False. So more work needed to actually throw an error.

For example:
@pytest.mark.parametrize(
    'init_false_field', [dataclasses.field(init=False, default=-1), pydantic.dataclasses.Field(init=False, default=-1)]
)
def test_init_false(init_false_field):
    @pydantic.dataclasses.dataclass(config=ConfigDict(extra='forbid'))
    class MyDataclass:
        a: int = init_false_field
        b: int = pydantic.dataclasses.Field(default=2)

    signature = inspect.signature(MyDataclass)
    # `a` should not be in the __init__
    assert 'a' not in signature.parameters.keys()
    assert 'b' in signature.parameters.keys()

    assert isinstance(MyDataclass(b=2), MyDataclass)
    # test passes up until here

    # however, this does not throw an error
    _ = MyDataclass(a=1, b=2)

    # this DOES throw a validation error, when that `extra='forbid'` is used
    _ = MyDataclass(a=1, b=2, c=3)

@sydney-runkle I tried adding init to Field & FieldInfo, then adding handling of it to the changes from https://github.com/pydantic/pydantic/pull/8511. Unfortunately, this only seems to be a partial fix? Wanted to get some feedback before I try to make some more involved changes
Details
The signature for __init__ is fixed but we are still able to initialize using that parameter.
Example:
def test_example():
    @dataclasses.dataclass
    class D1:
        a: int = dataclasses.field(init=False, default=-1)

    @pydantic.dataclasses.dataclass
    class D2:
        a: int = pydantic.dataclasses.Field(init=False, default=-1)

    @pydantic.dataclasses.dataclass
    class D3:
        a: int = dataclasses.field(init=False, default=-1)

    def demo(cls):
        try:
            sig = (inspect.signature(cls))
            res = cls(a=1)
        except Exception as exc:
            print(f"res: {exc}")
        else:
            print(f"res: {res}")
        print(f"sig: {sig}")

    demo(D1)
    demo(D2)
    demo(D3)

Output:
res: test_example.<locals>.D1.__init__() got an unexpected keyword argument 'a'
sig: () -> None
res: test_example.<locals>.D2(a=1)
sig: () -> None
res: test_example.<locals>.D3(a=1)
sig: () -> None

With ConfigDict(extra='forbid')
I think the first example might be expected by default since it supports "extra" fields passed to the initializer, so I also tried it with extra='forbid'. This doesn't seem to help:
@pytest.mark.parametrize(
    'init_false_field', [dataclasses.field(init=False, default=-1), pydantic.dataclasses.Field(init=False, default=-1)]
)
def test_init_false(init_false_field):
    @pydantic.dataclasses.dataclass(config=ConfigDict(extra='forbid'))
    class MyDataclass:
        a: int = init_false_field
        b: int = pydantic.dataclasses.Field(default=2)

    signature = inspect.signature(MyDataclass)
    # `a` should not be in the __init__
    assert 'a' not in signature.parameters.keys()
    assert 'b' in signature.parameters.keys()

    assert isinstance(MyDataclass(b=2), MyDataclass)
    # test passes up until here

    # however, this does not throw an error
    _ = MyDataclass(a=1, b=2)

    # this DOES throw a validation error, when that `extra='forbid'` is used
    _ = MyDataclass(a=1, b=2, c=3)

Some debugging
I took a look at the schema and DataclassValidator that is generated. My guess is, since there's not support for init=False here yet, the validator doesn't know that a shouldn't be allowed?
The definitions from collect_definitions in (_generate_schema.py):
{'tests.test_dataclasses.test_init_false.<locals>.MyDataclass:4483203024': {'type': 'dataclass', 'cls': <class 'tests.test_dataclasses.test_init_false.<locals>.MyDataclass'>, 'fields': ['a', 'b'], 'schema': {'type': 'dataclass-args', 'dataclass_name': 'MyDataclass', 'fields': [{'type': 'dataclass-field', 'name': 'a', 'schema': {'type': 'default', 'schema': {'type': 'int', 'metadata': {'pydantic.internal.needs_apply_discriminated_union': False}}, 'default': -1}, 'kw_only': False, 'metadata': {'pydantic_js_functions': [], 'pydantic_js_annotation_functions': [<function get_json_schema_update_func.<locals>.json_schema_update_func at 0x106d5c220>]}}, {'type': 'dataclass-field', 'name': 'b', 'schema': {'type': 'default', 'schema': {'type': 'int', 'metadata': {'pydantic.internal.needs_apply_discriminated_union': False}}, 'default': 2}, 'kw_only': False, 'metadata': {'pydantic_js_functions': [], 'pydantic_js_annotation_functions': [<function get_json_schema_update_func.<locals>.json_schema_update_func at 0x106d5c4a0>]}}], 'computed_fields': [], 'collect_init_only': False}, 'post_init': False, 'slots': False, 'config': {'title': 'MyDataclass', 'extra_fields_behavior': 'forbid'}, 'ref': 'tests.test_dataclasses.test_init_false.<locals>.MyDataclass:4483203024', 'metadata': {'pydantic.internal.needs_apply_discriminated_union': False}}}

@tigeryy2,
Thanks for your initial work on this, and your detailed report / questions.
@dmontagu has been kind enough to look into this a bit and has opened these two PRS:

https://github.com/pydantic/pydantic-core/pull/1163
https://github.com/pydantic/pydantic/pull/8552

Adding support for init does require changes to pydantic-core, as seen in the first PR.
The second PR still needs some tests and some additions to documentation. You've done some great work with adding tests already, as well as adding some much needed docs changes. I'll port the changes you've added over to the second PR.
I'm going to close this in favor of #8552.
Let me know if you have any questions - we appreciate your contributions and hope that you'll continue to help us out with your awesome work 🚀.

Thanks @sydney-runkle ! Definitely planning on continuing to contribute


Fix typo

Coverage remained the same at 99.216% when pulling 750ca931f7c4d9fac4972e629de69a60c03f0998 on typo into 18eb516c9c83648271706a8fd747a0f8876910e6 on v3.0.0.

Good catch, thanks!


Make eventemitter3 compatible with TypeScript 1.6 (still works with 1.5.3 as well)

I don't think the current eventemitter3.d.ts will be compatible with TypeScript 1.6. The following commands demonstrates the problem (output prepended with # to make it easier to cut and paste):
mkdir /tmp/eventemitter_test && cd /tmp/eventemitter_test
npm install typescript@next
#<EMAIL_ADDRESS>node_modules/typescript
wget --quiet "https://raw.githubusercontent.com/borisyankov/DefinitelyTyped/master/eventemitter3/eventemitter3-test.ts"
wget --quiet "https://raw.githubusercontent.com/borisyankov/DefinitelyTyped/master/eventemitter3/eventemitter3.d.ts"
./node_modules/.bin/tsc --module commonjs eventemitter3-test.ts

Giving the errors
eventemitter3-test.ts(11,9): error TS2322: Type 'EventEmitter3.EventEmitter.EventEmitter' is not assignable to type 'EventEmitter'.
  Property 'listeners' is missing in type 'EventEmitter'.
eventemitter3-test.ts(12,9): error TS2322: Type 'EventEmitter2' is not assignable to type 'EventEmitter'.
  Property 'listeners' is missing in type 'EventEmitter2'.
eventemitter3-test.ts(13,9): error TS2322: Type 'EventEmitter3' is not assignable to type 'EventEmitter'.
  Property 'listeners' is missing in type 'EventEmitter3'.
eventemitter3.d.ts(88,57): error TS2339: Property 'EventEmitter' does not exist on type 'typeof EventEmitter3'.
eventemitter3.d.ts(89,58): error TS2339: Property 'EventEmitter' does not exist on type 'typeof EventEmitter3'.
eventemitter3.d.ts(90,22): error TS2506: 'EventEmitter3' is referenced directly or indirectly in its own base expression.
eventemitter3.d.ts(90,58): error TS2339: Property 'EventEmitter' does not exist on type 'typeof EventEmitter3'.

If you change "npm install typescript@next" to "npm install typescript" (and thus get version 1.5.3 if you do it right now) in the above commands it will work.
I think the problem is described in https://github.com/Microsoft/TypeScript/issues/3602 . Some kind of name conflict that worked before but is no longer allowed in TypeScript 1.6.
This pull request fixes so the eventemitter3.d.ts works with both TypeScript 1.5.3 and the  current 1.6 nightly version, but I'm very uncertain if it is fixed in the right way. I don't understand much of the .d.ts files despite many hours of trying to make sense of them.

I can confirm maglar0's PR fixes the same issue I'm encountering.

eventemitter3/eventemitter3.d.ts
to author(@mrk21). could you review this PR?
:+1: or :-1:?
check list

[ ] pass the Travic-CI test?

@maglar0 thanks mate!


Wallet Management support in CLI

Closes #15

[ ] Implement init wallet
[ ] Implement view wallets
[ ] Implement funding
[ ] Implement encryption

[ ] Export command to output wallet mnemonic and passphrase to a file
[ ] Wallet aliases?

https://github.com/key-connect/services/issues/35 to support exporting mnemonic
https://github.com/key-connect/services/issues/36 to support wallet aliases


fix(dev_dependencies): remove types-click from pre-comits

Remove types-click from pre-commit.
I suspect the package is no longer necessary (and cause bugs):
There is no click folder in https://github.com/python/typeshed/tree/master/stubs  (so the link in https://pypi.org/project/types-click/#history is dead).
I have tried adding types-click as a dev-dependency, but it somehow requires ipython ??? (see https://github.com/GitGuardian/ggshield/runs/6452203176?check_suite_focus=true)

Codecov Report

Merging #236 (9a4e68e) into main (18a72e5) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   93.36%   93.35%   -0.02%
==========================================
  Files          57       62       +5
  Lines        2472     2498      +26
==========================================
+ Hits         2308     2332      +24
- Misses        164      166       +2

Flag
Coverage Δ

unittests
93.35% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ggshield/cmd/auth/utils.py
86.95% <0.00%> (-7.79%)
:arrow_down:

ggshield/core/client.py
100.00% <0.00%> (ø)

ggshield/cmd/config/config_list.py
100.00% <0.00%> (ø)

ggshield/core/config.py

ggshield/core/config/config.py
95.58% <0.00%> (ø)

ggshield/core/config/user_config.py
90.76% <0.00%> (ø)

ggshield/core/config/errors.py
85.71% <0.00%> (ø)

ggshield/core/config/__init__.py
100.00% <0.00%> (ø)

ggshield/core/config/utils.py
96.66% <0.00%> (ø)

ggshield/core/config/auth_config.py
96.34% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a72e5...9a4e68e. Read the comment docs.

An explicit message was hiding in plain sight: from https://pypi.org/project/types-click/#description

Note: The click package includes type annotations or type stubs since version 8.0. Please uninstall the types-click package if you use this or a newer version.

The message you found is quite unambiguous, but I get some breakage with pre-commit on my machine if I remove this package.
This is on the main branch:
$ mypy ggshield tests setup.py
Success: no issues found in 112 source files

$ pre-commit run --hook-stage commit -a mypy -v
mypy.....................................................................Passed
- hook id: mypy
- duration: 1.58s

Success: no issues found in 112 source files

This is on your branch:
$ mypy ggshield tests setup.py
Success: no issues found in 107 source files

$ pre-commit run --hook-stage commit -a mypy -v
mypy.....................................................................Failed
- hook id: mypy
- duration: 1.4s
- exit code: 1

ggshield/core/text_utils.py:85: error: Returning Any from function declared to return "str"
ggshield/cmd/install.py:67: error: Returning Any from function declared to return "Optional[str]"
Found 2 errors in 2 files (checked 107 source files)

What's even stranger is I don't have types-click installed in my virtual environment, and the mypy version matches the pre-commit one:
$ pip list | grep ^types-
WARNING: No metadata found in /home/agateau/.local/share/virtualenvs/ggshield-c3rFhSjf/lib/python3.8/site-packages
WARNING: No metadata found in /home/agateau/.local/share/virtualenvs/ggshield-c3rFhSjf/lib/python3.8/site-packages
types-appdirs             1.4.2
types-oauthlib            3.1.6
types-PyYAML              6.0.5
types-requests            2.27.13
types-urllib3             1.26.11

$ mypy --version
mypy 0.942

Do you have any idea what could be going wrong here?

Fixed by adding click to mypy's additional dependencies :tada:

Fixed by adding click to mypy's additional dependencies tada


Missing setlocale from release 2.4.5

The function "setLocale" for setting language is missing.

:+1:

+1


Getting error: neo is not a function

I followed the instructions:
var neo = require('neo-js-blockchain'); var neoBlockchain = neo('full', 'mainnet');
I'm getting error:
TypeError: neo is not a function     at Object.<anonymous> (/home/NEO/index.js:2:21)     at Module._compile (module.js:635:30)     at Object.Module._extensions..js (module.js:646:10)     at Module.load (module.js:554:32)     at tryModuleLoad (module.js:497:12)     at Function.Module._load (module.js:489:3)     at Function.Module.runMain (module.js:676:10)     at startup (bootstrap_node.js:187:16)     at bootstrap_node.js:608:3
Please help.
Thank you.

Seems like the README is wrong as the module exports { neo: Object } and not itself...
So, the following would work -
const Neo = require('neo-js-blockchain').neo;
let neoBlockchain = new Neo('full', 'mainnet');

Also, after doing that you may run into an additional issue I had. When installing via npm, dist/neo.blockchain.node.js had a couple of missing colons after "params" that prevented the module for working. (This was a couple of days ago, maybe it's been fixed.)

@tsirolnik That worked! thanks.
@professorhantzen Yes. Its not yet fixed.

@professorhantzen I have the same issue
``
neo-js-blockchain/dist/neo.blockchain.node.js:366
params[scriptHash, params],
^
Syntax Error: Unexpected token [
``
@hahahatrick You're welcome

Seems like the npm package is outdated and full of bugs for some reason...
Clone the repo and use it instead

@lllwvlvwlll Could you re-upload the npm package?

We are going to expedite release of 0.5 to fix these issues.  We will try to get it out tonight.  Please keep in mind that some of the syntax will be changing.

Please reference the latest version and documentation (0.5.0)


EKF: Enable nav validity timeout to be adjusted

Fixes an issue with excessively  short time from loss of GPS to reported loss of nav validity encountered during testing of https://github.com/PX4/Firmware/pull/8771#issuecomment-374826607

Removes duplicate checking for dead reckoning and consolidate into a single function.
Use separate timers to check for start of dead reckoning and check when dead reckoning has been performed for too long for the nav solution to be valid.
Allows the timeout for validity reporting to be adjusted externally.
Separates external reporting of dead reckoning from internal checks.

Recommend testing in combination with https://github.com/PX4/Firmware/pull/8771

Looks good. The other thing we should check is the vehicle_global_position deadreckoning flag. In https://github.com/PX4/Firmware/pull/8771#issuecomment-373228891 it wasn't updating. I'm also wondering if we should move that flag from global to local.

The only difference between what is returned by the global_position_is_valid() and local_position_is_valid() accessor functions is that global position requires an origin.

Rebased on master.

@dagar If you can update your review, then we can get this merged.

The last patch fixes the issue that was causing global position eph to go to zero before global position stopped publishing

Here is the log: https://logs.px4.io/plot_app?log=abbb7ebf-259d-432a-bf08-b137ce88df90
Reported global position error no longer falls before global position topic stops publishing.

@priseborough given we need a similar change for the sync between local position eph/epv and local_position_is_valid() could we avoid it entirely? Why not just skip zeroing the reported errors?
Any consumer can independently check the validity flags, or in the case of global position won't even have a publication.


path problems (?) in preprocess_pdb.sh - without ligand

Hi,
When trying to preprocess an entry without a ligand, it crashes on masif site step, failing to find nn_models.all_feat_31:
./preprocess_pdb.sh example/1a7x.pdb 1A7X_A -o example/output/

...
Running masif site on /home/masif-neosurf/example/1a7x.pdb
nn_models.all_feat_3l.custom_params
Traceback (most recent call last):
File "/home/masif-neosurf/masif/source//masif_site/masif_site_predict.py", line 27, in
custom_params = importlib.import_module(custom_params_file, package=None)
File "/usr/local/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 941, in _find_and_load_unlocked
File "", line 219, in _call_with_frames_removed
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 941, in _find_and_load_unlocked
File "", line 219, in _call_with_frames_removed
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 953, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'nn_models'

Adding catalogue with the said model to $PYTHONPATH helps with the issue, but it gets stuck on a similiar problem in next step.
Thanks for all the support and help
Michal

Hi, thanks for raising this issue. I'm closing this as @knawel's fix (16c1cf8c68b33c94a9a38988bdf281088db6b633) should solve it. Feel free to re-open if you still run into problems.


Upload wheel

close #770

Could you confirm that the contents of the wheel matches with the sdist?

The following command was used to compare the generated package files, and nothing was output, confirming that there is no difference in content.
mkdir tar_package
tar -xzf pytorch-pfn-extras-0.7.3.tar.gz -C ./tar_package
unzip -q pytorch_pfn_extras-0.7.3-py3-none-any.whl -d ./whl_package
diff -r ./whl_package/pytorch_pfn_extras ./tar_package/pytorch-pfn-extras-0.7.3/pytorch_pfn_extras


[WIP] Redesign icon for "IF" in the same style as "Switch" and "While" [AUTOZIP]

Fix #991

Download:
Environment: QT=5.12, ARCH=32, CONFIGURATION=release, QTIFW=C:\Qt\Tools\QtInstallerFramework\3.1
trik-studio-master-i686-auto.zip


Some template string conversions aren't safe

Consider this code:
        var a = {
          toString: function() { return "foo"; },
          valueOf: function() { return "bar"; },
        };
        console.log(a+'')

This outputs "bar". But Lebab will convert it to this code:
        const a = {
          toString() { return "foo"; },
          valueOf() { return "bar"; },
        };
        console.log(`${a}`)

This outputs "foo" in conforming ES6 engines.
Of course, it isn't possible to statically confirm whether a given value has a valueOf that meaningfully differs from toString. At the least, consider including a warning about this.

That's indeed a tricky case. Pretty much impossible to ensure that it doesn't happen.

I think the best we can do about this is to document this shortcoming of the template transform. Not even feasible to display a warning, as that would mean printing a warning for pretty much every template string conversion.

I've linked this issue from the main page, but I don't think there's anything we can really do about that.
If somebody actually encounters this bug with real-world code, feel free to comment.
Closing this for now as won't fix.


Kahan summation in mean computation

Current master states:
-- | /O(n)/ Arithmetic mean.  This uses Kahan-Babuška-Neumaier
-- summation, so is more accurate than 'welfordMean' unless the input
-- values are very large.

However, the implementation of mean is:
mean xs = sum xs / fromIntegral (G.length xs)
I'm not familiar with Neumaier's variant (I assume this refers to the method in Rundungsfehleranalyse einiger Verfahren zur Summation endlicher Summen?), but that implementation doesn't look anything like a Kahan method to me.
Am I missing something, or is this an incorrect comment or implementation?

Oops, just realised I was misreading, sum is implemented internally.


How Can i enabled and disabled a multiselect way JS/jQuery

I have a multiselect disabled  <select multiple disabled>

i want to enable the select element (when the checkbox is checked) i try:
$("select").prop('disabled', false) but doesnt work.
thanks for your help.

I suppose that after .prop('disabled', false) you need to run $('select').material_select();
Generally, after any operation on materializedselect tag you need to call  $('select').material_select(); to sync dropdown with underline hidden select.

@kmmbvnr Thanks You, its works, re-run  $('select').material_select();

Hello,
I'm having the same issue. It's not working anymore, nor with .material_select(); or .formSelect();


Initial wallet restore balance: NaN

The first time a wallet is restored the accounts will say "NaN" (Not a number) on the dashboard. Hide when there is no balance to display.

This is likely no longer an issue.


Consider null sentiment

Currently, in SentimentClass, Neutral is the same as Unspecified.  However a neutral sentiment in a sentence is different from no sentiment being able to be identified.  Consider how to design this.

Question added to #9722

However a neutral sentiment in a sentence is different from no sentiment being able to be identified.

A sentence will always return a sentiment as the service returns the arg-max across the label scores., so no need to have "null sentiment"