Support bluetooth volume

@Zlass Can you please review and release a version?

@Zlass It should not matter, since if we are using a bluetooth device such as phone clip or an accessory, it does not matter whether we are in a call or listening to music. We just need to change to bluetooth volume bar...
Does it make sense?

@Zlass Currently it was tested in some scenarios with 2 Samsung devices. I'll let Chris do more tests with more devices and modes (music / video call / phone call etc.) and see if it is still working.
We may need to add more switch cases to the case where we need to find the right mode type...
WDYT?


Ctrl + Space auto completion key binding alternative?

Ctrl + Space is my default language input key binding.
When I try Ctrl + Space for Marp auto completion in VScode, it does not do the job but switch my input language from Chinese to English. Could we customise the key binding for the auto completion? Thanks.

Refer to https://code.visualstudio.com/docs/getstarted/keybindings. Change key binding for editor.action.triggerSuggest to prevent confliction with IME.


Day view

added day view to see the events of the day

added an on day creation button to create new events on the day the user is viewing

home URL improvement

main view function for the home page upgraded to a template class view

fix: #86

@MortarDefender In addition to the comments I left, I think that it is necessary to add another button in the day-view to create a meeting from it. Also, I think we should add a tooltip for each button, so it would be more clear to the user what is the purpose of each button.

Done. 😃

@MortarDefender In addition to the comments I left, I think that it is necessary to add another button in the day-view to create a meeting from it. Also, I think we should add a tooltip for each button, so it would be more clear to the user what is the purpose of each button.

Done. 😃

Great!! 😄

@MortarDefender please fix the files conflicts


Unexpected token 'o', "[object Rea"... is not valid JSON

Log
GitHub Copilot Chat

Extension Version: 0.20.3 (prod)
VS Code: vscode/1.93.1
OS: Windows

Network
User Settings:
  "github.copilot.advanced": {
    "debug.useElectronFetcher": true,
    "debug.useNodeFetcher": false
  }

Connecting to https://api.github.com:

DNS Lookup: <IP_ADDRESS>
Electron Fetcher (configured): HTTP 200
Node Fetcher: HTTP 200
Helix Fetcher: HTTP 200

Connecting to https://api.githubcopilot.com/_ping:

DNS Lookup: <IP_ADDRESS>
Electron Fetcher (configured): HTTP 200
Node Fetcher: HTTP 200
Helix Fetcher: HTTP 200

Documentation:
In corporate networks: Troubleshooting firewall settings for GitHub Copilot.
Error message
Unexpected token 'o', "[object Rea"... is not valid JSON

I've tried sign out and sign back in; remove and re-install extensions; switch copilot to previous versions; switch copilot to pre-released versitions.

Could be https://github.com/cnblogs/vscode-cnb/issues/303.

Could be cnblogs/vscode-cnb#303.

I don't have the cnblogs extension

Hi can you include your copilot chat output logs. It's CMD / CTRL + SHIFT + U -> GitHub Copilot Chat

2024-10-05 22:52:09.062 [info] Using the Electron fetcher.
2024-10-05 22:52:09.062 [info] Initializing Git extension service.
2024-10-05 22:52:09.062 [info] Successfully activated the vscode.git extension.
2024-10-05 22:52:09.062 [info] Enablement state of the vscode.git extension: true.
2024-10-05 22:52:09.063 [info] Successfully registered Git commit message provider.
2024-10-05 22:52:09.072 [info] Logged in as liliyigz
2024-10-05 22:52:09.728 [error] SyntaxError: Unexpected token 'o', "[object Rea"... is not valid JSON
at JSON.parse ()
at t.json (c:\Users\DELL.vscode\extensions\nicepkg.aide-pro-1.19.0\node_modules@langchain\core\dist\output_parsers\structured.js:51:16)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at AC.authFromGitHubToken (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:299:7809)
at AC._auth (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:627:2720): Failed to get copilot token
2024-10-05 22:52:09.732 [error] GitHub Copilot could not connect to server. Extension activation failed: "Unexpected token 'o', "[object Rea"... is not valid JSON"
2024-10-05 22:52:09.732 [warning] [LanguageModelAccess] LanguageModel/Embeddings are not available without auth token
2024-10-05 22:52:09.732 [error] SyntaxError: Unexpected token 'o', "[object Rea"... is not valid JSON
at JSON.parse ()
at t.json (c:\Users\DELL.vscode\extensions\nicepkg.aide-pro-1.19.0\node_modules@langchain\core\dist\output_parsers\structured.js:51:16)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at AC.authFromGitHubToken (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:299:7809)
at AC._auth (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:627:2720)
2024-10-05 22:52:09.733 [warning] [LanguageModelAccess] LanguageModel/Embeddings are not available without auth token
2024-10-05 22:52:09.733 [error] SyntaxError: Unexpected token 'o', "[object Rea"... is not valid JSON
at JSON.parse ()
at t.json (c:\Users\DELL.vscode\extensions\nicepkg.aide-pro-1.19.0\node_modules@langchain\core\dist\output_parsers\structured.js:51:16)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at AC.authFromGitHubToken (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:299:7809)
at AC._auth (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:627:2720)
2024-10-05 22:52:09.747 [info] Logged in as liliyigz
2024-10-05 22:52:10.067 [info] activationBlocker from 'languageModelAccess' took for 980ms
2024-10-05 22:52:31.334 [info] Using the Electron fetcher.
2024-10-05 22:52:31.334 [info] Initializing Git extension service.
2024-10-05 22:52:31.334 [info] Successfully activated the vscode.git extension.
2024-10-05 22:52:31.334 [info] Enablement state of the vscode.git extension: true.
2024-10-05 22:52:31.334 [info] Successfully registered Git commit message provider.
2024-10-05 22:52:31.380 [info] Logged in as liliyigz
2024-10-05 22:52:31.964 [error] SyntaxError: Unexpected token 'o', "[object Rea"... is not valid JSON
at JSON.parse ()
at t.json (c:\Users\DELL.vscode\extensions\nicepkg.aide-pro-1.19.0\node_modules@langchain\core\dist\output_parsers\structured.js:51:16)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at AC.authFromGitHubToken (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:299:7809)
at AC._auth (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:627:2720): Failed to get copilot token
2024-10-05 22:52:31.964 [error] GitHub Copilot could not connect to server. Extension activation failed: "Unexpected token 'o', "[object Rea"... is not valid JSON"
2024-10-05 22:52:31.964 [warning] [LanguageModelAccess] LanguageModel/Embeddings are not available without auth token
2024-10-05 22:52:31.965 [error] SyntaxError: Unexpected token 'o', "[object Rea"... is not valid JSON
at JSON.parse ()
at t.json (c:\Users\DELL.vscode\extensions\nicepkg.aide-pro-1.19.0\node_modules@langchain\core\dist\output_parsers\structured.js:51:16)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at AC.authFromGitHubToken (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:299:7809)
at AC._auth (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:627:2720)
2024-10-05 22:52:31.965 [warning] [LanguageModelAccess] LanguageModel/Embeddings are not available without auth token
2024-10-05 22:52:31.965 [error] SyntaxError: Unexpected token 'o', "[object Rea"... is not valid JSON
at JSON.parse ()
at t.json (c:\Users\DELL.vscode\extensions\nicepkg.aide-pro-1.19.0\node_modules@langchain\core\dist\output_parsers\structured.js:51:16)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at AC.authFromGitHubToken (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:299:7809)
at AC._auth (c:\Users\DELL.vscode\extensions\github.copilot-chat-0.22.2024100401\dist\extension.js:627:2720)
2024-10-05 22:52:32.021 [info] Logged in as liliyigz
2024-10-05 22:52:32.352 [info] activationBlocker from 'languageModelAccess' took for 1123ms

Please try uninstalling this extension
nicepkg.aide-pro-1.19.0

Please try uninstalling this extension
nicepkg.aide-pro-1.19.0

It worked!!!!
Thank you all for helping!


Feature API?

Hi!
Any chance to get API support? So I can add ghstats to Homepage.
Thanks!

Hi, @sahara101.
What kind of data you want to get thought this API?

Hi! Total number of repos, clones, issues, stars and views. All time if possible.
Thanks!

Hi, @sahara101. I've been busy past weeks.
Feature was added to main few weeks ago and released in v0.4.0. Check docs here: https://github.com/vladkens/ghstats?tab=readme-ov-file#api-endpoint

Thanks!


HBASE-27931 Update hadoop.version from 3.3.5 to 3.3.6

targeting branch-2 and branch-2.6

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  5s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ branch-2 Compile Tests _

-1 :x:
mvninstall
4m 56s
/branch-mvninstall-root.txt
root in branch-2 failed.

+1 :green_heart:
compile
7m 57s

branch-2 passed

+1 :green_heart:
spotless
1m  2s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 11s

the patch passed

+1 :green_heart:
compile
9m  5s

the patch passed

+1 :green_heart:
javac
9m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
hadoopcheck
19m 34s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 45s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s

The patch does not generate ASF License warnings.

50m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6233

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux 59183afd16b4 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 76699ef938ec8cec3dcbefa34010a154f52f624d

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/console

versions
git=2.34.1 maven=3.9.8 xmllint=20913

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 24s

branch-2 passed

+1 :green_heart:
compile
2m 13s

branch-2 passed

+1 :green_heart:
javadoc
2m  0s

branch-2 passed

+1 :green_heart:
shadedjars
6m 13s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  8s

the patch passed

+1 :green_heart:
compile
2m 14s

the patch passed

+1 :green_heart:
javac
2m 14s

the patch passed

+1 :green_heart:
javadoc
1m 55s

the patch passed

+1 :green_heart:
shadedjars
6m 11s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
248m  7s
/patch-unit-root.txt
root in the patch failed.

281m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6233

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 2a1b913c360e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 76699ef938ec8cec3dcbefa34010a154f52f624d

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/testReport/

Max. process+thread count
5038 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m  7s

branch-2 passed

+1 :green_heart:
compile
2m 11s

branch-2 passed

+1 :green_heart:
javadoc
2m 13s

branch-2 passed

+1 :green_heart:
shadedjars
5m 29s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 56s

the patch passed

+1 :green_heart:
compile
2m 12s

the patch passed

+1 :green_heart:
javac
2m 12s

the patch passed

+1 :green_heart:
javadoc
2m  8s

the patch passed

+1 :green_heart:
shadedjars
5m 26s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
319m 38s
/patch-unit-root.txt
root in the patch failed.

353m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6233

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6002cade935a 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 76699ef938ec8cec3dcbefa34010a154f52f624d

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/testReport/

Max. process+thread count
8218 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 31s

branch-2 passed

+1 :green_heart:
compile
1m 42s

branch-2 passed

+1 :green_heart:
javadoc
1m 32s

branch-2 passed

+1 :green_heart:
shadedjars
5m 15s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 26s

the patch passed

+1 :green_heart:
compile
1m 44s

the patch passed

+1 :green_heart:
javac
1m 44s

the patch passed

+1 :green_heart:
javadoc
1m 32s

the patch passed

+1 :green_heart:
shadedjars
5m 10s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
329m 25s
/patch-unit-root.txt
root in the patch failed.

357m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6233

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 13191a507d38 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 76699ef938ec8cec3dcbefa34010a154f52f624d

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/testReport/

Max. process+thread count
4898 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6233/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

This has been superceded by the Hadoop 3.4.1 change.


Eliminate unnecessary semicolons in macros.

With this patch, -Wpedantic no longer produces warnings.

Thanks for this work!


Add pure SSH LFS support

Fixes #17554
/claim #17554
To test, run pushes like: GIT_TRACE=1 git push. The trace output should mention "pure SSH connection".

@lunny added copyright headers.

Improved error handling.

Accidentally resolved the conversation about DB connections above, but reiterating:
Pushes and clones work... but there's sometimes (by which I mean decently reproducible) bug where after transferring and verification and everything... the connection just hangs for almost exactly 120 seconds. After which it just ends gracefully and git proceeds with its push.
It's particularly nasty, I have no leads on it yet. The best I can figure out is that it looks like the git-lfs client seems to not send the quit command that it should at the end of the protocol, or that it isn't coming through.

Added locking API support.
Well at least I figured out what's causing the hang. Setting lfs.ssh.automultiplex to false on the client side:
https://github.com/git-lfs/git-lfs/blob/8e36a03d85bf05bbca004dd7e8b55b147809b3e0/docs/man/git-lfs-config.adoc?plain=1#L90
gets rid of the hang. The bad news is that it's true by default.
I think this is feature interacting badly with the SSH server?
I traced the traffic, and indeed, something weird is happening on the client side. Git LFS spawns several workers each making its own connection. In a multiplexed connection, only the "first" spawn of the our commands gets a quit message. The rest of them have to wait 120 seconds for an EOF. I'm almost tempted to believe this is a bug on the git-lfs client side.
Can you check and see if this is reproducible in your environments?

Yeah, I'm not going crazy. This commit:
https://github.com/git-lfs/git-lfs/commit/44b8801cbb57891b4c66fc3c43551802e5532bd1
breaks pure SSH LFS sessions.
And this has history, it isn't even the first time lol:
https://github.com/git-lfs/git-lfs/pull/5537

just made: https://github.com/git-lfs/git-lfs/pull/5816

@lafriks adressed the url joins.

Also, there's no way to selectively identify older git-lfs clients and just disable the SSH protocol for them, as the protocol doesn't have a user-agent identifier (it's been discussed several times as a deficiency in the protocol, but no improvements have been implemented).

Alternatively, I suppose, we can add a default-false config option to let users decide when it would be appropriate for their needs? It can be turned default-true once the "updated LFS client" utopia has been achieved.

Hey all,
Just wanted to do a quick ping to ask if you've had the chance to look at this yet.

@techknowlogick added a new commit adding a LFS_ALLOW_PURE_SSH option to the server section. It's default-false due to the zero value. It can be later set to default-true. But like I said above, it needs to be after a point in time where most people have shifted to the fixed LFS build (it'll probably be a while considering almost-LTS environments like ubuntu).
Also rebased on main.

The documentation blurb could be something like:

LFS Pure SSH Protocol Support
The LFS protocol supports connecting purely over SSH (without exposing an HTTP endpoint).
Support for it can be enabled with the config option server.LFS_ALLOW_PURE_SSH.
NOTE: The option is currently set to default false due to an open bug in the git-lfs client
that causes transfers to hang: https://github.com/git-lfs/git-lfs/pull/5816
This can be worked around on the client machines by setting the git config:
git config --global lfs.ssh.automultiplex true

The documentation blurb could be something like:

LFS Pure SSH Protocol Support
The LFS protocol supports connecting purely over SSH (without exposing an HTTP endpoint).
Support for it can be enabled with the config option server.LFS_ALLOW_PURE_SSH.
NOTE: The option is currently set to default false due to an open bug in the git-lfs client
that causes transfers to hang: git-lfs/git-lfs#5816
This can be worked around on the client machines by setting the git config:
git config --global lfs.ssh.automultiplex true

Please send a doc pull request to https://gitea.com/gitea/docs which should be merged after this one done.

The documentation blurb could be something like:

LFS Pure SSH Protocol Support
The LFS protocol supports connecting purely over SSH (without exposing an HTTP endpoint).
Support for it can be enabled with the config option server.LFS_ALLOW_PURE_SSH.
NOTE: The option is currently set to default false due to an open bug in the git-lfs client
that causes transfers to hang: git-lfs/git-lfs#5816
This can be worked around on the client machines by setting the git config:
git config --global lfs.ssh.automultiplex true

Please send a doc pull request to https://gitea.com/gitea/docs which should be merged after this one done.

@lunny where should this be in the docs?

The documentation blurb could be something like:

LFS Pure SSH Protocol Support
The LFS protocol supports connecting purely over SSH (without exposing an HTTP endpoint).
Support for it can be enabled with the config option server.LFS_ALLOW_PURE_SSH.
NOTE: The option is currently set to default false due to an open bug in the git-lfs client
that causes transfers to hang: git-lfs/git-lfs#5816
This can be worked around on the client machines by setting the git config:
git config --global lfs.ssh.automultiplex true

Please send a doc pull request to https://gitea.com/gitea/docs which should be merged after this one done.

@lunny where should this be in the docs?

I think at least https://gitea.com/gitea/docs/src/branch/main/docs/administration/config-cheat-sheet.md should be updated and also https://gitea.com/gitea/docs/src/branch/main/docs/administration/git-lfs-support.md

@lunny made https://gitea.com/gitea/docs/pulls/49

Linter and check failure should be fixed.

@delvh changed to use container.Set.

buildin ssh server + sha256 repo does not work ...

sha1 also does not work:
GIT_TRACE=1 git push --verbose                                                                                on  main [⇡]
21:56:42.989596 git.c:463               trace: built-in: git push --verbose
Pushing to ssh://<IP_ADDRESS>:20435/test/frwwa.git
21:56:42.989925 run-command.c:657       trace: run_command: unset GIT_PREFIX; ssh -p 20435<EMAIL_ADDRESS>'git-receive-pack '\''/test/frwwa.git'\'''
21:56:43.160171 run-command.c:657       trace: run_command: .git/hooks/pre-push origin ssh://git@<IP_ADDRESS>:20435/test/frwwa.git
21:56:43.165891 git.c:750               trace: exec: git-lfs pre-push origin ssh://git@<IP_ADDRESS>:20435/test/frwwa.git
21:56:43.165941 run-command.c:657       trace: run_command: git-lfs pre-push origin ssh://git@<IP_ADDRESS>:20435/test/frwwa.git
21:56:43.174518 trace git-lfs: exec: git '-c' 'filter.lfs.smudge=' '-c' 'filter.lfs.clean=' '-c' 'filter.lfs.process=' '-c' 'filter.lfs.required=false' 'remote' '-v'
21:56:43.175729 trace git-lfs: exec: git '-c' 'filter.lfs.smudge=' '-c' 'filter.lfs.clean=' '-c' 'filter.lfs.process=' '-c' 'filter.lfs.required=false' 'remote'
21:56:43.176843 trace git-lfs: exec: git '-c' 'filter.lfs.smudge=' '-c' 'filter.lfs.clean=' '-c' 'filter.lfs.process=' '-c' 'filter.lfs.required=false' 'rev-parse' 'HEAD' '--symbolic-full-name' 'HEAD'
21:56:43.177865 trace git-lfs: exec: git '-c' 'filter.lfs.smudge=' '-c' 'filter.lfs.clean=' '-c' 'filter.lfs.process=' '-c' 'filter.lfs.required=false' 'rev-parse' '--git-dir' '--show-toplevel'
21:56:43.179094 trace git-lfs: exec: git 'config' '--includes' '-l'
21:56:43.179921 trace git-lfs: exec: git 'rev-parse' '--is-bare-repository'
21:56:43.180770 trace git-lfs: exec: git 'config' '--includes' '-l' '--blob' ':.lfsconfig'
21:56:43.181805 trace git-lfs: exec: git 'config' '--includes' '-l' '--blob' 'HEAD:.lfsconfig'
21:56:43.183147 trace git-lfs: exec: git '-c' 'filter.lfs.smudge=' '-c' 'filter.lfs.clean=' '-c' 'filter.lfs.process=' '-c' 'filter.lfs.required=false' 'rev-parse' '--git-dir'
21:56:43.184646 trace git-lfs: exec: git '-c' 'filter.lfs.smudge=' '-c' 'filter.lfs.clean=' '-c' 'filter.lfs.process=' '-c' 'filter.lfs.required=false' 'remote'
21:56:43.186191 trace git-lfs: attempting pure SSH protocol connection
21:56:43.186199 trace git-lfs: spawning pure SSH connection
21:56:43.186244 trace git-lfs: run_command: ssh -oControlMaster=yes -oControlPath=/run/user/1000/sock-73099538/lfs.sock -p 20435<EMAIL_ADDRESS>git-lfs-transfer /test/frwwa.git upload
21:56:43.186426 trace git-lfs: exec: ssh '-oControlMaster=yes' '-oControlPath=/run/user/1000/sock-73099538/lfs.sock' '-p' '20435'<EMAIL_ADDRESS>'git-lfs-transfer /test/frwwa.git upload'
21:56:43.349324 trace git-lfs: pure SSH connection successful
21:56:43.349337 trace git-lfs: pure SSH protocol connection failed: Unable to negotiate version with remote side (unable to read capabilities): unexpected EOF
21:56:43.349537 trace git-lfs: pre-push: refs/heads/main 954452e504825b1302f181bb9930fcc06e3632be refs/heads/main e093361042867374edf0f1112e14a5bdc395d31c
21:56:43.349639 trace git-lfs: exec: git '-c' 'filter.lfs.smudge=' '-c' 'filter.lfs.clean=' '-c' 'filter.lfs.process=' '-c' 'filter.lfs.required=false' 'show-ref'
21:56:43.352266 trace git-lfs: exec: git '-c' 'filter.lfs.smudge=' '-c' 'filter.lfs.clean=' '-c' 'filter.lfs.process=' '-c' 'filter.lfs.required=false' 'ls-remote' '--heads' '--tags' '-q' 'origin'
21:56:43.542290 trace git-lfs: attempting pure SSH protocol connection
21:56:43.542302 trace git-lfs: spawning pure SSH connection
21:56:43.542331 trace git-lfs: run_command: ssh -oControlMaster=yes -oControlPath=/run/user/1000/sock-290582623/lfs.sock -p 20435<EMAIL_ADDRESS>git-lfs-transfer /test/frwwa.git upload
21:56:43.542506 trace git-lfs: exec: ssh '-oControlMaster=yes' '-oControlPath=/run/user/1000/sock-290582623/lfs.sock' '-p' '20435'<EMAIL_ADDRESS>'git-lfs-transfer /test/frwwa.git upload'
21:56:43.711956 trace git-lfs: pure SSH connection successful
21:56:43.711968 trace git-lfs: pure SSH protocol connection failed: Unable to negotiate version with remote side (unable to read capabilities): unexpected EOF
21:56:43.712109 trace git-lfs: run_command: ssh -p 20435<EMAIL_ADDRESS>git-lfs-authenticate /test/frwwa.git upload
21:56:43.712273 trace git-lfs: exec: ssh '-p' '20435'<EMAIL_ADDRESS>'git-lfs-authenticate /test/frwwa.git upload'
21:56:43.881384 trace git-lfs: HTTP: POST http://<IP_ADDRESS>:3000/test/frwwa.git/info/lfs/locks/verify
21:56:43.882774 trace git-lfs: HTTP: 200
21:56:43.882936 trace git-lfs: HTTP: {"ours":[],"theirs":[]}

Locking support detected on remote "origin".
Counting objects: 100% (7/7), done.
Delta compression using up to 16 threads
Compressing objects: 100% (4/4), done.
Writing objects: 100% (5/5), 65.45 MiB | 48.88 MiB/s, done.
Total 5 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
remote: . Processing 1 references
remote: Processed 1 references in total
To ssh://<IP_ADDRESS>:20435/test/frwwa.git
   e093361..954452e  main -> main
updating local tracking ref 'refs/remotes/origin/main'

@6543 what OS, and version of git are you using?

buildin ssh server + sha256 repo does not work
sha1 also does not work:
21:56:43.711956 trace git-lfs: pure SSH connection successful
21:56:43.711968 trace git-lfs: pure SSH protocol connection failed: Unable to negotiate version with remote side (unable to read capabilities): unexpected EOF

@6543 did you enable the config flag? That error message is what it says when SSH LFS is disabled.

@6543 what OS, and version of git are you using?

NixOS | Linux 6.10.1-zen1 x86_64
git version 2.44.1
do i have to enable it explizite via some config? as i understand it should transparently work

@6543 what OS, and version of git are you using?

NixOS | Linux 6.10.1-zen1 x86_64
git version 2.44.1 git-lfs/3.5.1 (3.5.1; linux amd64; go 1.22.5)
do i have to enable it explizite via some config? as i understand it should transparently work

@6543 That would indeed have been ideal, but see: https://github.com/git-lfs/git-lfs/pull/5816 (also https://gitea.com/gitea/docs/pulls/49)

May I know when we could get this PR merged?

The LFS requests MUST be from an internal API but not an external API, otherwise, it's the same as HTTP based LFS support or worse because there is a SSH proxy.

...
12:36:53.980011 trace git-lfs: attempting pure SSH protocol connection
12:36:53.980018 trace git-lfs: spawning pure SSH connection
12:36:53.980082 trace git-lfs: run_command: ssh -oControlMaster=yes -oControlPath=/run/user/1000/sock-337264434/lfs.sock -p 20435<EMAIL_ADDRESS>git-lfs-transfer /test/lfs-test.git upload
12:36:53.980265 trace git-lfs: exec: ssh '-oControlMaster=yes' '-oControlPath=/run/user/1000/sock-337264434/lfs.sock' '-p' '20435'<EMAIL_ADDRESS>'git-lfs-transfer /test/lfs-test.git upload'
12:36:54.194005 trace git-lfs: pure SSH connection successful
12:36:54.194019 trace git-lfs: pure SSH protocol connection failed: Unable to negotiate version with remote side (unable to read capabilities): unexpected EOF
12:36:54.194201 trace git-lfs: pre-push: refs/heads/main 9d274f23c82dd6638dd7b4d109127ad136e620ba refs/heads/main<PHONE_NUMBER>000000000000000000000000000000
12:36:54.194290 trace git-lfs: exec: git '-c' 'filter.lfs.smudge=' '-c' 'filter.lfs.clean=' '-c' 'filter.lfs.process=' '-c' 'filter.lfs.required=false' 'show-ref'
12:36:54.196099 trace git-lfs: exec: git '-c' 'filter.lfs.smudge=' '-c' 'filter.lfs.clean=' '-c' 'filter.lfs.process=' '-c' 'filter.lfs.required=false' 'ls-remote' '--heads' '--tags' '-q' 'origin'
12:36:54.386431 trace git-lfs: attempting pure SSH protocol connection
12:36:54.386442 trace git-lfs: spawning pure SSH connection
12:36:54.386479 trace git-lfs: run_command: ssh -oControlMaster=yes -oControlPath=/run/user/1000/sock-1703762547/lfs.sock -p 20435<EMAIL_ADDRESS>git-lfs-transfer /test/lfs-test.git upload
12:36:54.386682 trace git-lfs: exec: ssh '-oControlMaster=yes' '-oControlPath=/run/user/1000/sock-1703762547/lfs.sock' '-p' '20435'<EMAIL_ADDRESS>'git-lfs-transfer /test/lfs-test.git upload'
12:36:54.596317 trace git-lfs: pure SSH connection successful
12:36:54.596332 trace git-lfs: pure SSH protocol connection failed: Unable to negotiate version with remote side (unable to read capabilities): unexpected EOF
...

git version 2.45.2
git-lfs/3.5.1 (3.5.1; linux amd64; go 1.22.5)

The LFS requests MUST be from an internal API but not an external API, otherwise, it's the same as HTTP based LFS support or worse because there is a SSH proxy.

I'm glad to help you make the changes.

@lunny I don't think I need implementation help, but I do think I need clarification of the change you are requesting, as I elaborated on in the last comment I made: https://github.com/go-gitea/gitea/pull/31516#discussion_r1728205002
Unless I seem to be misunderstanding, you are asking for a new private router for these paths. The new router would just conflict with the public router, competing for answering to the same requests.

@lunny I don't think I need implementation help. I do think I need clarification of the change you are requesting, as I elaborated on in the last comment I made: #31516 (comment)
Unless I seem to be misunderstanding, you are asking for a new private router for these paths. The new router would just conflict with the public router, competing for answering to the same requests.

Yes, it looks like the new private routers are duplicated with the public routers. But if you look at #17554, he wants to disable public HTTP requests, that's why we need pure SSH LFS support. Commonly, the private routers will only be invoked from the internal Gitea sub-command, the traffic will never be requested to a public network but the loopback network. I think we can reuse some service layer functions between these two routes.
Let's compare the current implementations and the HTTP based LFS.
HTTP based LFS: git-lfs plugin -> Gitea Public LFS routers
Current implementation: git-lfs plugin -> Gitea SSH service -> Gitea subcommand -> Gitea Public LFS routers
My request changes: git-lfs plugin -> Gitea SSH service -> Gitea subcommand -> Gitea Private LFS routers

But if you look at #17554, he wants to disable public HTTP requests, that's why we need pure SSH LFS support. Commonly, the private routers will only be invoked from the internal Gitea sub-command, the traffic will never be requested to a public network but the loopback network.

The traffic in the current implementation never touches an external network precisely because we send requests to LocalURL and not AppURL. The routers don't have anything to do with it, they're just the receiving end.

But there is no info/lfs route at private routers, I don't know how the request succeeds. Private routers required an internal token check, I couldn't find how your code works for that.

@lunny that is because there is no such thing as "public" or "private" routers, except for the file they are defined in. They listen and respond on the same network socket, no matter whether the request came from localhost or the external network interface. The only thing your so-called "private" routers do differently is have middleware for checking if the token header exists, and responding with a fake "not found" if it doesn't. That is exactly why having the same path registered twice would be terrible.
I have been trying to explain precisely this for a while now. I don't know how else I can demonstrate reality. 3 of your colleagues have tested this and found it working, and you can do that as well.

But there is no info/lfs route at private routers, I don't know how the request succeeds. Private routers required an internal token check, I couldn't find how your code works for that.

@lunny that is because there is no such thing as "public" or "private" routers, except for the file they are defined in. They listen and respond on the same network socket, no matter whether the request came from localhost or the external network interface. The only thing your so-called "private" routers do differently is have a middleware for checking if the token header exists, and responding with a fake "not found" if it doesn't. That is exactly why having the same path registered twice would be terrible.
I have been trying to explain precisely this for a while now. I don't know how else I can demonstrate reality. 3 of your colleagues have tested this and found it working, and you can do that as well.

That's because commonly, the web will listen <IP_ADDRESS> and LOCAL_URL is http://<IP_ADDRESS>:3000. So when you request <IP_ADDRESS>, it actually requests the public routers. The internal APIs have a /api/internal prefixes rather than other routers.

That's because commonly, the web will listen <IP_ADDRESS> and LOCAL_URL is http://<IP_ADDRESS>:3000. So when you request <IP_ADDRESS>, it actually requests the public routers. The internal APIs have a /api/internal prefixes rather than other routers.

So... you want the API paths here to have a /api/internal prefix? Is that what this sums up to?

Yes

Okay, I see, that was the part I was missing. This conversation would've been a lot shorter otherwise. This way it's not an obvious bug because the paths don't conflict with the existing public paths (though I still don't quite grasp to what ends).

@lunny added private API. Used a /repo prefix so the path parameters don't accidentally match other internal APIs.

@lunny added private API. Used a /repo prefix so the path parameters don't accidentally match other internal APIs.

Thank you for the change and I think you also need to change the client code.

Ah right, my bad.

Just a sec, missed adding the internal token header there...

So this is getting ugly pretty quick. The LFS handler APIs are hardcoded to require a JWT token (and this is necessary to check user permissions on the repo) as the Authorisation header. But the internal APIs need the header for their own token.

I would be fine with the current state, just mention the lfs pull on the docu and the example ini next to tje enable option

It looks like LFS_ALLOW_PURE_SSH hasn't been read from [lfs] but [server]. And you need to add an example in app.example.ini file.

It looks like LFS_ALLOW_PURE_SSH hasn't been read from [lfs] but [server]. Otherwise I can test it successfully. And you need to add an example in app.example.ini file.

I added it under server because LFS_START_SERVER was there already.

It looks like LFS_ALLOW_PURE_SSH hasn't been read from [lfs] but [server]. Otherwise I can test it successfully. And you need to add an example in app.example.ini file.

I added it under server because LFS_START_SERVER was there already.

OK. It's a legacy problem. So could you add example in app.example.ini?

@lunny added it to the example config.

Thanks so much @ConcurrentCrab!!! <3

I'll sort out Algora stuff right now. Related, if you have other issues you'd like to suggest for bounties, please get in touch with me, as I'm working on a list right now.

Thanks! and I appreciate the tip.

Related, if you have other issues you'd like to suggest for bounties, please get in touch with me, as I'm working on a list right now.

Was this directed at me? If so, I'd be happy to take a shot at more bounties. I quite enjoyed the work part of this.
My only sore point here was the turnaround time on this one. I get that y'all have a business to run. One feature PR isn't exactly at the top of the priority list, I wasn't expecting instant replies. But to me it felt like this was basically ignored for quite a while, and as a result took far longer than it should have.

-> mind the documentation ...

But to me it felt like this was basically completely ignored for quite a while, and as a result took far longer than it should have.

Sorry for that i personnally was just waiting for some references in the docs and you would also have got my lgtm

-> mind the documentation ... ... i'm fine with the pull itselve but next to the config flag we should link to the upstream issue

@6543 does this cover what you mean: https://gitea.com/gitea/docs/pulls/49/files
I thought this was linked in reply to you above somewhere, but the discussion might've been collapsed before you saw it.

Could you take a look at " Refactor LFS SSH and internal routers #32473 " ?
If I understand correctly, when using LFS SSH transfer, there should be some "PUT" requests, but I can't see them in the test.
Could you help to improve the test? Otherwise the feature would be broken some time later when code changes. Thank you.


Fix_SIRT

[x] Fix inf values in precond matrices
[x] Improve unittests
[x] Improve docs

Close #1162

@jakobsj , I fixed all your comments. If you are happy please accept and merge.

The numpy.nan_to_num works for numpy 1.17. Could we drop numpy 1.15?

@epapoutsellis @jakobsj
I was thinking about this fix and I'm not sure about the way we're dealing with it.
So the issue states that you end up with inf when forward/back projecting 1s. If that's the case then it seems that the geometry is probably not set up right (or we have issues with the projectors) and you have some parts of the volume that you never have data for.
If it is expected then surely those values in the range/domain are never actually updated so I'm not sure whether inf values even would affect things.

I don't think we should just replace inf values unless we have a very good reason to do so.  It seems the problem is elsewhere.
I'm not sure why we are replacing nan at all here, again nans imply a problem with the projection operator that needs fixing
If we do replace them why are we choosing 1 as a value it seems arbitrary.

As a last point I didn't think the weight matrices M and D really worked for unmatched projectors as the forward and back end up discretised in different ways. I think you can rescale by number of voxels instead of these and still get it to converge, but maybe that only works with full angular coverage.

I agree in principle the functionality by lower and upper can be
achieved through constraint, however we intentionally kept lower and
upper to simplify the interface for these common constraints without
asking the user to understand indicator functions. We also have lower and
upper in the SIRT code snippet of the CIL1 paper so we really should keep
them.
On Tue, 19 Apr 2022 at 11:20, Vaggelis Papoutsellis <
@.***> wrote:

@.**** commented on this pull request.
In Wrappers/Python/cil/optimisation/algorithms/SIRT.py
https://github.com/TomographicImaging/CIL/pull/1163#discussion_r852804706
:

   r""" In case of division error when the preconditioning arrays :code:`M` and :code:`D`

   are defined, the :code:`np.nan`, :code:`+np.inf` and :code:`-np.inf` values are replaced with one.

   """

   # fix for possible inf values (code from numpy.nan_to_nam)

   np_version = numpy.__version__.split('.')

   if np_version[0]=='1' and np_version[1]<='17':

       for arr in [self.M, self.D]:

           tmp = arr.as_array()

           idx_nan = numpy.isnan(tmp)

           idx_pinf = numpy.isposinf(tmp)

           idx_ninf = numpy.isneginf(tmp)

           arr[idx_nan] = 1.

fixed
—
Reply to this email directly, view it on GitHub
https://github.com/TomographicImaging/CIL/pull/1163#discussion_r852804706,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMDSCBLAXREFFX6H22W5TTVFZ3G7ANCNFSM5O4T6WAQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Jenkins failed job 2957 for converting back to WIP.
It's also worth checking why jenkins failed but GHA passed.

Why did you revert the code? This opens up my previous comments again which you'd since fixed.
This is the error for numpy 1.15 python 3.6. To answer my previous question GHA passed because it was on a later numpy version. I think you have to check your parsing of the version number. Maybe using packaging would be a better idea here.
======================================================================
ERROR: test_SIRT_nan_inf_values (test_algorithms.TestSIRT)
Traceback (most recent call last):
File "/home/jenkins/conda-bld/cil_1650479727895/test_tmp/Wrappers/Python/test/test_algorithms.py", line 762, in test_SIRT_nan_inf_values
sirt.fix_weights()
File "/home/jenkins/conda-bld/cil_1650479727895/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_p/lib/python3.6/site-packages/cil/optimisation/algorithms/SIRT.py", line 151, in fix_weights
numpy.nan_to_num(self.M.as_array(), copy = False, nan = 1, neginf=1, posinf=1)
TypeError: nan_to_num() got an unexpected keyword argument 'nan'

Just looking at the numpy documentation I spotted 'np.isfinite' which has the combined logic of nans and infs (when inverted) so this fix seems like it should be 2 lines of code per matrix, and probably works across all numpy versions.
>>> arr = np.array([np.nan, 5.6, np.nan, np.inf, -np.inf, 2.1]).reshape(3,2,1)
>>> arr
array([[[ nan],
        [ 5.6]],

       [[ nan],
        [ inf]],

       [[-inf],
        [ 2.1]]])
>>> arr_replace = np.isfinite(arr)
>>> arr[~arr_replace] =1
>>> arr
array([[[1. ],
        [5.6]],

       [[1. ],
        [1. ]],

       [[1. ],
        [2.1]]])

Citation of SIRT is in wrong place, add it at the end of optimisation.rst


deliberately drop a path or multiple paths

Changes

:gift: Add new feature

/kind enhancement

Fixes #897

Release Note

deliberately drop a/multiple path(s)
action required: user will need to add a new annotation to his KSVC to include the path(s) that need to be dropped

Docs

Documentation on how configure this is included in PR

Let's continue to discuss this in https://github.com/knative/serving/issues/13228


Re-check/do external load-path and analytical gradient functions

Removed, they are inferior (much slower) to internal loadpath optimisation. See compas_loadpath repo.


Doc Needs for Hackathon

cc @jeffposnick @addyosmani @jpmedley

[ ] Recipe for SW-CLI + NPM Publish Scripts
[ ] Recipe for SW-Build + IIFE -> Gulp & Inlining
[ ] Recipe for SW-Build + ES2015 Module -> Gulp & Rollup
[ ] Guide to using sw-lib for runtime
[ ] Document on the structure of sw-helpers.

Is there anything else we should be adding?
Do we want to bother changing to workbox and wb-* modules? This could help remove confusion with other sw-* libraries.

Is this the priority? I'm working on CLI+NPM unless I hear otherwise.

Hey @jpmedley—As discussed at today's sync-up, I think the biggest gap that you could fill is on the narrative side of things, rather than producing specific recipes. On the recipe front, @gauntface, @prateekbh, and I all have snippets we could share based on our existing experiments.
The items on that list that scream "Joe!" to me would be "Document on the structure of sw-helpers." and "Guide to using sw-lib for runtime".
I think the workbox renaming has to happen sometime, but maybe after the hackathon.

Guide to sw-lib is in this: https://docs.google.com/document/d/1MC6pO3rF8g9op22YRD9thG2k-YWhOT1EUm5PkYXOhN0/edit#heading=h.z3mekvoay8yw

The phrase 'structure of sw-helpers' could mean several things. Can one of you please clarify this?
@jeffposnick @gauntface

It's referring to the structure of this repo. I.e. if someone were to look at this Github Repo - they'll probably be lost as to what everything is for and how it fits together.


Same substructures may have different Morgan fingerprint bits

Configuration:

RDKit Version: 2019.09.1
Operating system: Ubuntu 18.04
Python version (if relevant): 3.7.4
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? rdkit
If you are not using conda: how did you install the RDKit?

Description:

from rdkit import Chem
from rdkit.Chem import AllChem
bitinfo = {}
AllChem.GetMorganFingerprintAsBitVect(Chem.MolFromSmiles(Chem.CanonSmiles('C1C2CCC3(CCO3)C12')), 2, bitInfo=bitinfo)
print(bitinfo[926])
print(80 in bitinfo)

bitinfo = {}
AllChem.GetMorganFingerprintAsBitVect(Chem.MolFromSmiles(Chem.CanonSmiles('OCCC1NC12COC2')),2, bitInfo=bitinfo)
print(bitinfo[926])
print(bitinfo[80])

Above code will output:
((0, 0), (1, 0), (3, 0), (4, 0), (6, 0))
False
((6, 0), (8, 0))
((1, 0), (2, 0))

However, seems bits 926 and 80 all correspond to -CH2- substructure. I know Morgan fingerprint has a possibility of hash collision, but shouldn't it be different structure but same bits? However, I got same structures but different bits here.
To validate this, I also plot the substructures.
Draw.DrawMorganBit(Chem.MolFromSmiles(Chem.CanonSmiles('C1C2CCC3(CCO3)C12')), 926, bitinfo)

Draw.DrawMorganBit(Chem.MolFromSmiles(Chem.CanonSmiles('OCCC1NC12COC2')), 926, bitinfo)

Draw.DrawMorganBit(Chem.MolFromSmiles(Chem.CanonSmiles('OCCC1NC12COC2')), 80, bitinfo)

They are just same structures! In the first molecule, only 926 exists, but in the second molecule, 80 also exists for the same substructure. I wonder if Morgan fingerprint is designed for this or there is a bug.
Thank you so much!

Hi @Minys233
By default the morgan fingerprint includes information about whether or not an atom is in a ring in the information about the bits. In your case bit 926 is the CH2 in a ring, while bit 80 is the CH2 in a chain.

Thanks so much for pointing out the direction for me. For others who have the same question, I did some source code reading, the default atom invariants are defined at MorganFingerprints.h, which includeRingMembership has a default value of true. Check corresponding cpp file for implementation details.
If you do not want to this information included in the morgan fingerprint, just pass your own invariant parameter to AllChem.GetMorganFingerprint function.

I'll also point out that the atom invariants used are the ones described in the original paper, which is referenced in the RDKit documentation: https://doi.org/10.1021/ci100050t

I'm closing this because it looks like the question is answered. Please reopen if necessary.


set secure flag for cookie

Coverage remained the same at 50.761% when pulling b92b1036bf08981e89b314cb27ff770f0fd8a54e on reasonerjt:dev into bd2517f0023d72173e1d7ee51febc9cbd2f55817 on vmware:dev.


Add Missing Parameters to Resources #159 MSFT_xExchClientAccessServer

The parameter IsOutOfService was not added due to the fact that it's deprecated.

This change is

Hi @IngoGege  , I could be missing something, but how are you intending the CleanUpInvalidAlternateServiceAccountCredentials and RemoveAlternateServiceAccountCredentials parameters to be used in the context of DSC? I don't see any tests in Test-TargetResource for these parameters. Also, what happens if someone specifies both an AlternateServiceAccountCredential, and RemoveAlternateServiceAccountCredentials? Would that result in a Set/Test loop?

Hi @mhendric,
that's a good question. Actually you cannot combine CleanUpInvalidAlternateServiceAccountCredentials, RemoveAlternateServiceAccountCredentials  and AlternateServiceAccountCredential together. Only AlternateServiceAccountCredential and CleanUpInvalidAlternateServiceAccountCredentials. If you use them the CmdLet will throw an error. Is there are way to define this in the schema MOF? Or am I allowed to use ParameterSets? If not I can add this as an additional check in Set/Test-TargetResource and just break with a warning.
Ciao,
Ingo

I'm not personally aware of any way to specify in the MOF that certain parameters cannot be used together. I like the idea of throwing an error (vs. a warning) and then exiting the script. I think maybe this should only be done in Set-TargetResource, instead of doing it in both Set and Test. The Test is just checking conditions based on parameters, so I think even a bad combination of parameters should just result in a False. That in turn would trigger the Set, which would throw an error that the admin would have to then correct.
Regarding Parameter Sets, I can't find anything officially from MSFT that talks about DSC and Parameter Sets together. I did find this discussion on the matter though, which says it can't be done(https://powershell.org/forums/topic/custom-dsc-resources-and-parameter-sets/).

Sounds good! Will do it tomorrow and send a new PR.


why conversion  sys.modules to list??

why conversion  sys.modules to list??
https://github.com/requests/requests/blob/master/requests/packages.py#L10

Hey @wsqy, thanks for the question. I don't know if there is a specific reason sys.modules was cast as a list other than to ensure it's iterable. It's likely something that slipped through during code review.

If we didn't, we'd end up modifying the object we're iterating and Python 3 would blow up. That's not idea. We also likely don't want to touch the items we are inserting into sys.modules.
This is not the place for questions of this type.


Up NodeBB compatibility, fixed translator module, changed post selector.

I tested on 0.8 and 0.9 persona and lavender. Works. Should work on 0.7 too.

Works good enough for an npm publish? I can't really test it atm, no dev env.

It appears so, I just did another fresh install in 0.8 and 0.9 and everything appears to be working.


v1.2 release

This should be the target branch for v1.2 PRs
Remaining:

[X] #203 Entity Properties
[x] Entity Property documentation  (documentation here)
[x] #212 SHACL-AF shapes for tags
[x] #216 VBIS fixes
[x] Timeseries blank node model (#221)
[X] Timeseries model documentation (here)
[x] #215 Cooling Towers and Condenser Plants
[x] remove PROP namespace and replace with Brick
[x] remove RDFS.domain of Brick.hasUnit
[ ] Location model

Hi Gabe - I will look to add those new concepts and make a PR into here either today or tomorrow.

Hi Gabe - I will look to add those new concepts and make a PR into here either today or tomorrow.

Hey Gabe - can you describe how, with the new IRI formation, one is supposed to convey the version of Brick used in constructing a model?

As long as the major version number of Brick remains 1, which it will for some time, then Brick versions will be backwards compatible and you should use the latest version available. One can query the version number of the Brick graph loaded in through the dcterms:version property. One will also be able to load in a specific version of Brick using a versioned-URI (e.g. https://brickschema.org/schema/1.2/Brick), but the downloaded version of the ontology will have a versionless namespace. The hope is that this will facilitate the adoption of future Brick versions, and largely remove the need to worry about which specific version of Brick was used to define a model

@epaulson @jbkoh @shreyasnagare can you give this a look over in the next few days so that I can merge soon? Thanks!

Hi @jbulow! That file was supplied by external collaborators, so it is just an accident that it has CRLF. Thanks for the pointer for .gitattributes

Looks good to me

@shreyasnagare Docker shouldn't be necessary (even though it is listed in the requirements: https://github.com/BrickSchema/Brick/blob/master/requirements.txt#L10) --- it just enables the use of Allegrograph which is faster than the default reasoner. Can you try uninstalling the Python docker package to see if Brick.ttl generation is possible without it?
Thanks for going through the PR by the way!

@jbkoh can you approve the PR if there are no other changes you would like to be made?

@shreyasnagare Docker shouldn't be necessary (even though it is listed in the requirements: https://github.com/BrickSchema/Brick/blob/master/requirements.txt#L10) --- it just enables the use of Allegrograph which is faster than the default reasoner. Can you try uninstalling the Python docker package to see if Brick.ttl generation is possible without it?
Thanks for going through the PR by the way!

Yes, it seems to work after I uninstalled the docker python package.

Good to know! I put a note in the CONTRIBUTING.md document that docker is optional, but I kept it in there as a default install because it should work on most systems. If this ends up not being the case, we can revisit in the future

Good to know! I put a note in the CONTRIBUTING.md document that docker is optional, but I kept it in there as a default install because it should work on most systems. If this ends up not being the case, we can revisit in the future

I tried this on Windows and Ubuntu as well and ran into the same issue. Everything works fine when I have docker installed. I think this is something we can fix on the py-brickschema side of things: doing everything without docker if docker.from_env(version="auto") throws an error.

@shreyasnagare can you try installing brickschema==0.3.0a9 to see if it gracefully degrades without being able to connect to the docker client?

brickschema==0.3.0a9

2021-02-19:22:08:23,290 ERROR   [inference.py:94] Could not connect to docker (Error while fetching server API version: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))); defaulting to naive evaluation
Traceback (most recent call last):
  File "generate_brick.py", line 41, in <module>
    from bricksrc.quantities import quantity_definitions, get_units
  File "/root/Brick/bricksrc/quantities.py", line 11, in <module>
    g.expand(profile="brick")
  File "/usr/local/lib/python3.6/dist-packages/brickschema/graph.py", line 198, in expand
    return self.expand("owlrl+shacl+owlrl", backend=backend)
  File "/usr/local/lib/python3.6/dist-packages/brickschema/graph.py", line 194, in expand
    self.expand(prf, backend=backend)
  File "/usr/local/lib/python3.6/dist-packages/brickschema/graph.py", line 216, in expand
    self._inferbackend = OWLRLAllegroInferenceSession()
TypeError: __init__() should return None, not 'OWLRLNaiveInferenceSession'


Book rooms for early 2020

Time to start the New Year with some calendar invites! I have a couple of diary clashes for Mondays in January/February already, so I'll book rooms to avoid those when possible.

Done; we're going to start a bit later to avoid some busy weeks but we'll run fortnightly for most of the next few months (apart from moving some later sessions to avoid bank holidays).
 All bookings start at 12pm, but we won't start the talk until about 12:15pm to give people time to get their lunch and arrive.

Date
Room
Notes

Monday 17th Feb
Jack Good
Until 1pm

Monday 2nd March
Lovelace
No @LouiseABowler

Monday 16th March
David Blackwell

Monday 30th March
David Blackwell

Monday 27th April
Lovelace

Monday 18th May
David Blackwell


STG: Stage 1 issue

Hello, I'm having an issue with the recipe in egs/l2-arctic/stg.
Here's the log from data/bdl2TXHC_ppg_sxliu_dev/decode.log.
# s3prl-vc-decode --scp data/bdl_dev/wav.scp --checkpoint downloads/s3prl-vc-ppg_sxliu/checkpoint-50000steps.pkl --trg-stats downloads/s3prl-vc-ppg_sxliu/stats.h5 --outdir data/bdl2TXHC_ppg_sxliu_dev --verbose 1
# Started at Mon Feb 26 16:31:07 UTC 2024
#
/home/smejjoute/work/seq2seq-vc/.venv/lib/python3.10/site-packages/s3prl/upstream/byol_s/byol_a/common.py:20: UserWarning: torchaudio._backend.set_audio_backend has been deprecated. With dispatcher enabled, this function is no-op. You can remove the function call.
  torchaudio.set_audio_backend("sox_io")
['/home/smejjoute/work/seq2seq-vc/egs/arctic/vc1/downloads/cmu_us_bdl_arctic/wav/arctic_b0440.wav']
Traceback (most recent call last):
  File "/home/smejjoute/work/seq2seq-vc/.venv/bin/s3prl-vc-decode", line 8, in <module>
    sys.exit(main())
  File "/home/smejjoute/work/seq2seq-vc/.venv/lib/python3.10/site-packages/s3prl_vc/bin/decode.py", line 157, in main
    dataset = AudioSCPMelDataset(
  File "/home/smejjoute/work/seq2seq-vc/.venv/lib/python3.10/site-packages/s3prl_vc/datasets/datasets.py", line 259, in __init__
    len(contents[1:]) > 0
AssertionError: during inference, please append speaker embedding source files at the end of each line.
# Accounting: time=4 threads=1
# Ended (code 1) at Mon Feb 26 16:31:11 UTC 2024, elapsed time 4 seconds

I am running all of the stages (I just ran ./run.sh with the variables changed to the correct paths).

@Ryu1845 I apologize for the bug. The error was due to some bug in the s3prl-vc package. I need some time to fix it and test it. Please wait patiently. Thanks!

Thank you for your response!

@Ryu1845 I apologize for replying so late. Can you try updating the s3prl-vc package by executing the following?
cd tools
make s3prl_vc

And then see if you get the same error. If not, please paste the error log again.

Hi, this seems to have fixed the stage 1 issue, but now I'm having an issue in stage 4 ModuleNotFoundError: No module named 'seq2seq_vc.losses.diffsinger_l2_loss'


Remove unused function prototypes

args_verify() and opt_reset() are declared in apps/apps.h, but they are
not referenced anywhere. So can we remove them from apps.h?

I was bored, I did it :)  Thanks for the fixes!


skiprows in read_fwf: Link to Issue #2065

Four years ago in issue #2065 an issue with skiprows was raised. At that time dask.dataframe.read_csv would skip the number of rows specified in skiprows from every partition, not just the first partition. This was acknowledged as a bug and fixed in pull request #2165.
https://github.com/dask/dask/pull/2165
There have been significant changes in that part of the code base and it appears that this bug has reverted.
import dask.dataframe as dd
import pandas as pd
import dask

print(dask.__version__)
#  '2021.04.1'
df = pd.read_fwf('data.txt', colspecs=<colspecs>, skiprows=1)
ddf = dd.read_fwf('data.txt', colspecs=<colspecs>, skiprows=1).compute()
print(len(df))
# 1000000
print(len(ddf))
# 9999974
print(ddf.npartitions)
# 27

Thanks for reporting @rhjmoore. I could be missing something, but I'm not able to reproduce with the latest dask=2021.5.0 release with the snippet below:
import pandas as pd
import dask.dataframe as dd

df = pd.DataFrame({"a": range(10_000)})
df.to_csv("foo.csv", index=False)

ddf = dd.read_fwf("foo.csv", colspecs="infer", blocksize=600, sample=600, skiprows=1)
print(f"{ddf.npartitions = }")   # Should have more than 1 partition
print(f"{len(df) = }")
print(f"{len(ddf) = }")

outputs
ddf.npartitions = 82
len(df) = 10000
len(ddf) = 9999

Note that there are multiple partitions for ddf and the number of rows is one less than the corresponding pandas DataFrame (which is consistent with skiprows=1).

Apologies, you are right. The bug this time is in skip_footer. I simplified my code too much and did not notice the other possibility.
There is a bug, but the bug is in skipfooter not in skiprows. Try this:
df = pd.DataFrame({"a": range(10_000)})
df.to_csv("foo.csv", index=False)

ddf = dd.read_fwf("foo.csv", colspecs="infer", blocksize=600, sample=600, skiprows=1, skipfooter=1)
print(f"{ddf.npartitions = }")   # Should have more than 1 partition
print(f"{len(df) = }")
print(f"{len(ddf) = }")

@rhjmoore Thank you for the example, I was able to reproduce the bug. It seems we will need to do a fix similar to the one in the PR #2165 . Would you like to take shot at it?

@rhjmoore Thank you for the example, I was able to reproduce the bug. It seems we will need to do a fix similar to the one in the PR #2165 . Would you like to take shot at it?

@ncclementi I could, yes, but have never contributed to such a project before. I'd just git clone, make a new branch from master, make the changes, then pull request (anyone in particular I should address it to?)?

Yeah, those are most of the main steps. Our complete contributing guide is available at https://docs.dask.org/en/latest/develop.html. Feel free to ping me and @ncclementi on the issue. Thanks!

@jrbourbeau It looks like I'll have to change the structure of "parts" in dask.dataframe.io.csv line 372 to include a 4th entry named "is_last" and a new block_mask function to do the opposite of the existing one used for "is_first". Do you see a smarter way of knowing which block is the last one?

@ncclementi @jrbourbeau Pinging you both for the PR as suggested.


SAA-1324 firstName and lastName without space

PR closed, as its not required and fixed with another PR.


Merging in Cisco:Develop

Codecov Report

Merging #43 into puppet6 will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           puppet6     #43      +/-   ##
==========================================
- Coverage     4.24%   4.24%   -0.01%
==========================================
  Files          171     171
  Lines        20897   20905       +8
==========================================
  Hits           887     887
- Misses       20010   20018       +8

Impacted Files
Coverage Δ

lib/puppet_x/cisco/cmnutils.rb
0% <0%> (ø)
:arrow_up:

lib/puppet/parser/functions/platform_fretta.rb
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e980398...3db30b4. Read the comment docs.


[2308] Tidy up error handling

Context
The error handling was a little inconsistent.
Make sure #693 and #694 are merged first.
Changes proposed in this pull request
Grab bag of improvments to code and user experience for failure cases
Guidance to review
Read the commits individually

 Users accessing a provider url without access are seeing wrong message

rebased


Beginning the work to improve SDS setup

I'm breaking this into multiple PRs, for easier review.
This is renaming the deployment/etc - nodeagent is super confusing, and adds proper defaults
and kustomize options so it can be installed a-la-carte as an optional standalone component.
Tested a-la-carte manually using:
``bash
kubectl apply -k crds
kubectl apply -k kustomize/citadel
kubectl apply -k kustomize/sds-agent

The automated test depends on several other components - will be run after all pieces are in ( some are in progress in istio/istio )

This PR also fixes some breakages on 'local' mode.

PTAL

@costinm: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

build_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test build_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

build_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test build_installer

lintmodern_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lintmodern_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

build_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test build_installer

lintmodern_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lintmodern_installer

lint_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lint_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Costin, do you have time to work on this? If not, we will take it over.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

build_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test build_installer

lintmodern_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lintmodern_installer

lint_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lint_installer

gencheck_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test gencheck_installer

base_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test base_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

build_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test build_installer

lintmodern_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lintmodern_installer

gencheck_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test gencheck_installer

base_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test base_installer

lint_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lint_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

build_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test build_installer

lintmodern_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lintmodern_installer

base_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test base_installer

lint_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lint_installer

gencheck_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test gencheck_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

build_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test build_installer

lintmodern_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lintmodern_installer

base_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test base_installer

lint_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lint_installer

gencheck_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test gencheck_installer

noauth_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test noauth_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lintmodern_installer

base_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test base_installer

lint_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lint_installer

gencheck_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test gencheck_installer

noauth_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test noauth_installer

build_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test build_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lintmodern_installer

base_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test base_installer

lint_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test lint_installer

gencheck_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test gencheck_installer

noauth_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test noauth_installer

build_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test build_installer

demo_installer
3445c2cd76c795b1f99961ba189a2ea62059d277
link
/test demo_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Obsolete, istiod replaces it.


Make negative numbers work as input

make it so the parser can handle negative number expressions such as "20+-2" and that it interprets the string as ["20", "+", "-2"]. so that the -2 is one token.

Fixed with commit 00344eacf90e8b0d80b23a9609902c9557bf55cd


Implement GitHub Discussions support with/instead of GitHub Issues support

Recently GitHub has introduced a new feature which is GitHub Discussions and it appears to me that it is a viable alternative for current plugin algorithm, which works via GitHub Issues. I suggest to provide support for it because it might prevent Issues section cluttering.

Duplicate of https://github.com/utterance/utterances/issues/324


Adding minimum_input_lenght option

Hello,
Thank you for your work, you saved me a lot of time and effort. It seemed to me that this option was missing (unless it could be configured differently and I did not see it).

Hello! Thanks for the contribution!
You could use opts_for_select2 directly, but is ok if you take the work to add that option as a ruby wrapper. Merged!


InternVL2 customized fine-tuning for video-to-text

Hi! Great works! I'm wondering if swift can support fine-tuning for InternVL2 on customized video-to-text dataset soon? Thanks!

you can specify the abs video path by key videos as follows
{"query": "Describe this video in detail. Don't repeat", "response": "xxxxxxxxx", "history": [], "videos": ["video_path"]}

Hi Thanks for the reply! It works! However I'm wondering how to set the number of frames sampled for each video when ft internvlw?

modify  num_segments in https://github.com/modelscope/swift/blob/main/swift/llm/utils/vision_utils.py#L116


remove mmg validator/sql/based from cicd

@mscaldas2012  - adding as reviewer for visibility

making another PR with more changes


Add golang book (Dasar Pemrograman Golang)

Please see CONTRIBUTING.md.

At the end of the description, Dasar is it supposed to be lowercase? We want to build good and interesting descriptions :)

Okay sorry for that. Is there anything that I need to change besides that?

Cool, this should be good now. Thank you!


Add "Breakpoint"

Please add breakpoint (at-import/breakpoint). It's another Sass media query mixin.

Thank you @vwochnik for this! Added to this list 🎉


Adding tab navigation to language select hint

Hello,
Description
When a new file is create a hint asks the user to specify the desired
programming language. This commit introduces a tab navigation for
this hint. Thus there is more accessibility.
This is my first PR and it fixes #132085. I didn't ask for permission to work on this, because I wasn't aware of how far I will get. But here is my code suggestion to this topic. If tests are needed, can you give me a hint where to place those? Also check the import order, maybe I have to alter something.
Covered use cases
Focus outline style for anchors matches other anchors

Tab navigation forth, back and selecting using enter
https://user-images.githubusercontent.com/9914064/146949453-b8e9c8a2-d109-460b-85b4-b2fa415e517d.mov
Interrupting tab navigation by character input or click
https://user-images.githubusercontent.com/9914064/146950670-aadc13c0-ff63-4b19-a4ca-0f2c33beb14b.mov
These buttons will not interrupt tab navigation: KeyCode.Tab, KeyCode.Enter, KeyCode.Shift, KeyCode.Ctrl,KeyCode.Alt and KeyCode.Meta.
Interrupting tab navigation by opening command palette
Shortcuts can be called while in tab navigation.
https://user-images.githubusercontent.com/9914064/146953168-74fe7266-0578-4685-815f-d705d97c11d9.mov
Hopefully I didn't miss something and if you need more details feel free to ask. Thank you guys. 😁

Sorry for the delay here. It looks like there are some merge conflicts. If you'd still like to contribute, can you deal with those merge conflicts and we'll take a look?


#34887 [TRINO] Enable SQL based row limits for trino

When trino is configured with fault tolerant execution, queries are run to completion before results are returned. This means previewing a table in dbeaver ends up scanning the whole table and taking a lot of time, and potentially a huge amount of resources if its a very large table. Trino supports SQL limit statement, so enable SQL based row limiting in the plugin and make it the default for connections.
Fixes #34887

Thank you for contribution

We passed your PR to our QA team for testing

@E1izabeth Any update on this PR?

This PR is awaiting in a queue for testing.

verified


Dont build in profile mode

I tried to build example from this repository in profile mode, but got error.
And in my app after adding this package i got this error.
Build output
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':jitsi_meet_flutter_sdk:generateProfileRFile'.
> Could not resolve all files for configuration ':jitsi_meet_flutter_sdk:profileCompileClasspath'.
   > Could not resolve com.facebook.react:react-android:0.72.9.
     Required by:
         project :jitsi_meet_flutter_sdk > org.jitsi.react:jitsi-meet-sdk:9.2.2
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-amplitude:2.7.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-giphy:2.3.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-google-signin:10.1.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-async-storage:1.19.4-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-background-timer:2.4.1-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-calendar-events:2.2.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-community_clipboard:1.5.1-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-community_netinfo:11.1.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-default-preference:1.4.4-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-device-info:10.9.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-gesture-handler:2.9.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-get-random-values:1.9.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-immersive-mode:2.0.1-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-keep-awake:4.0.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-orientation-locker:1.6.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-pager-view:6.2.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-performance:5.0.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-safe-area-context:4.7.1-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-screens:3.24.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-slider:4.4.3-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-sound:0.11.2-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-splash-screen:3.3.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-svg:13.13.0-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-video:6.0.0-alpha.11-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-webrtc:118.0.7-jitsi-16757212
         project :jitsi_meet_flutter_sdk > com.facebook.react:react-native-webview:13.5.1-jitsi-16757212
      > No matching variant of com.facebook.react:react-android:0.72.9 was found. The consumer was configured to find an API of a component, preferably optimized for Android, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'profile', attribute 'com.android.build.api.attributes.AgpVersionAttr' with value '7.3.1', attribute 'org.jetbrains.kotlin.platform.type' with value 'androidJvm' but:
          - Variant 'debugVariantDefaultApiPublication' capability com.facebook.react:react-android:0.72.9 declares an API of a component:
              - Incompatible because this component declares a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug' and the consumer needed a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'profile'
              - Other compatible attributes:
                  - Doesn't say anything about com.android.build.api.attributes.AgpVersionAttr (required '7.3.1')
                  - Doesn't say anything about its target Java environment (preferred optimized for Android)
                  - Doesn't say anything about org.jetbrains.kotlin.platform.type (required 'androidJvm')
          - Variant 'debugVariantDefaultRuntimePublication' capability com.facebook.react:react-android:0.72.9 declares a runtime of a component:
              - Incompatible because this component declares a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug' and the consumer needed a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'profile'
              - Other compatible attributes:
                  - Doesn't say anything about com.android.build.api.attributes.AgpVersionAttr (required '7.3.1')
                  - Doesn't say anything about its target Java environment (preferred optimized for Android)
                  - Doesn't say anything about org.jetbrains.kotlin.platform.type (required 'androidJvm')
          - Variant 'debugVariantDefaultSourcePublication' capability com.facebook.react:react-android:0.72.9 declares a runtime of a component:
              - Incompatible because this component declares a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'debug' and the consumer needed a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'profile'
              - Other compatible attributes:
                  - Doesn't say anything about com.android.build.api.attributes.AgpVersionAttr (required '7.3.1')
                  - Doesn't say anything about its target Java environment (preferred optimized for Android)
                  - Doesn't say anything about org.jetbrains.kotlin.platform.type (required 'androidJvm')
          - Variant 'releaseVariantDefaultApiPublication' capability com.facebook.react:react-android:0.72.9 declares an API of a component:
              - Incompatible because this component declares a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'release' and the consumer needed a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'profile'
              - Other compatible attributes:
                  - Doesn't say anything about com.android.build.api.attributes.AgpVersionAttr (required '7.3.1')
                  - Doesn't say anything about its target Java environment (preferred optimized for Android)
                  - Doesn't say anything about org.jetbrains.kotlin.platform.type (required 'androidJvm')
          - Variant 'releaseVariantDefaultRuntimePublication' capability com.facebook.react:react-android:0.72.9 declares a runtime of a component:
              - Incompatible because this component declares a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'release' and the consumer needed a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'profile'
              - Other compatible attributes:
                  - Doesn't say anything about com.android.build.api.attributes.AgpVersionAttr (required '7.3.1')
                  - Doesn't say anything about its target Java environment (preferred optimized for Android)
                  - Doesn't say anything about org.jetbrains.kotlin.platform.type (required 'androidJvm')
          - Variant 'releaseVariantDefaultSourcePublication' capability com.facebook.react:react-android:0.72.9 declares a runtime of a component:
              - Incompatible because this component declares a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'release' and the consumer needed a component, as well as attribute 'com.android.build.api.attributes.BuildTypeAttr' with value 'profile'
              - Other compatible attributes:
                  - Doesn't say anything about com.android.build.api.attributes.AgpVersionAttr (required '7.3.1')
                  - Doesn't say anything about its target Java environment (preferred optimized for Android)
                  - Doesn't say anything about org.jetbrains.kotlin.platform.type (required 'androidJvm')

flutter doctor -v output:
[✓] Flutter (Channel stable, 3.19.6, on Ubuntu 22.04.4 LTS 5.15.0-105-generic, locale ru_RU.UTF-8)
    • Flutter version 3.19.6 on channel stable at /home/user/snap/flutter/common/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 54e66469a9 (2 недели назад), 2024-04-17 13:08:03 -0700
    • Engine revision c4cd48e186
    • Dart version 3.3.4
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /home/user/Android/Sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /home/user/.local/share/JetBrains/Toolbox/apps/android-studio/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2023.3)
    • Android Studio at /home/user/.local/share/JetBrains/Toolbox/apps/android-studio
    • Flutter plugin version 79.0.2
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)

[✓] VS Code (version 1.88.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.80.0

[✓] Connected device (3 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 14 (API 34) (emulator)
    • Linux (desktop)              • linux         • linux-x64      • Ubuntu 22.04.4 LTS 5.15.0-105-generic
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 124.0.6367.91

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Do you have the jitpack maven repo?

any updates?

Not from my side, since que question I asked wasn't answered 😅

Do you have the jitpack maven repo?

@saghul hi, sorry for waiting, i used example from this repository

Then I have no idea. It could be the react-native library does not provide something that's needed for that type of build.

@shabanov-krl were you able to solve the issue of your app crashing when you try to launch jitsi

See here for how to build in profile mode: https://github.com/jitsi/jitsi-meet-flutter-sdk/issues/91#issuecomment-2402804171


hi, I have some questions about TED

Hi,@hailanyi
Thanks for your contribution and the great work, I have two questions.

It's really hard to download huge data from Google drive in China. Do you have a plan to upload the preprocessed data in other netdisk like Baidu netdist or Ali netdisk?

I only have a 2080ti gpu with 10GB usable, I don know whether I can train it.  Is the GPU memory showed in Model Zoo a 1 batch?

Happy new year and looking forward to your reply. :)

I will also upload the data on Baidu disk in future. Currently, you can generate the data by yourself using the provided codes  and PENet model.

cd tools/PENet
python3 main.py --detpath [your path like: ../../data/kitti/training]

The TED-S can be trained on GPU with 10GB memory (2 batch), but you need modify the proposal number in config from 160 to 120 like:

225        TARGET_CONFIG:
226           BOX_CODER: ResidualCoder
227           ROI_PER_IMAGE: 120  # 160-> 120

The provided models in Model Zoo are trained with 2 batch. Using 1 batch may result in reduced 3D AP.

Got it.
Thank you very much @hailanyi


Problems with MathJax in Markdown

Describe the bug
This tool ignores MathJax code. If you use reserved Markdown characters, like _, it'll be converted to an  Element. Therefore, it is not possible to use atom-elearnjs to create reports with formulas.
To Reproduce
Steps to reproduce the behavior:

Write $x_{i}$ bla bla $x_{i}$
See error in HTML: $xi$ bla bla $xi$

Expected behavior
Do not touch MathJax!

I cannot test this atm. But does
$x\_{i}$ bla bla $x\_{i}$ work, maybe?
Otherwise i might have to check other possibilities.
You might need to surround the area with html:

$x_{i}$ bla bla $x_{i}$

Or

$x_{i}$ bla bla $x_{i}$

This way showdown.js should be forced to not convert the block in any way.

Regarding this problem a new syntax is introduced in the next version (1.7.2). (Updates for vsc-elearnjs and atom-elearnjs will follow)
You will then be able to deactivate the markdown conversion in a block. This might not be that useful for really short blocks, but for longer block formulas or texts containing no actual markdown.
Normal Conversion
This is a block in which no markdown should be processed.
It can contain $formulas__with$ anything $markdown *would__convert*$.

Converts to:

This is a block in which no markdown should be processed.
It can contain $formulaswith$ anything $markdown wouldconvert$.

Markdown Disabled Block

This is a block in which no markdown should be processed.
It can contain $formulas__with$ anything $markdown *would__convert*$.

Converts to:
This is a block in which no markdown should be processed.
It can contain $formulas__with$ anything $markdown *would__convert*$.

Please note the missing
. This might lead to unexpected results. If you want the additional
 you can simply use the usual Showdown behavior, not converting Markdown inside of Html:

This is a block in which no markdown should be processed.
It can contain $formulas__with$ anything $markdown *would__convert*$.


Syntax highlighting for match and case

It would be nice if syntax highlighting for match and case could be added.

def http_error(status: int):
    match status:
        case 400:
            return "Bad request"
        case 404:
            return "Not found"
        case 418:
            return "I'm a teapot"

After searching a bit more, I found these two existing issues:
https://github.com/microsoft/vscode/issues/120734
https://github.com/MagicStack/MagicPython/issues/235
I've also opened a PR https://github.com/MagicStack/MagicPython/pull/237 to recognize match and case as keywords, at least in a match statement.

In the meantime while we wait for VS Code and such to pull in those changes, I've modified our semantic tokenizer to output match and case as keyword tokens:

@jakebailey That's great! Thanks 🚀

This issue has been fixed in version 2021.5.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202150-5-may-2021

For people using pyright extension for development of it I think there's no other workaround than using a MagicPython extension built from the PR branch (rebased or not).

default themes and github themes support match case syntax, however majority of other themes does not support them out of the box.
running Inspect editor tokens and scopes shows result like this:

could there be any way to overwrite custom themes to support match case?

@scarf005, this issue has been closed for a long time. Please open a new issue for your suggestion.

@scarf005, this issue has been closed for a long time. Please open a new issue for your suggestion.

alright, referenced in new issue.


Clone repo vs using octokit

Octokit has endpoints to get repo tree, as well as to get contents of a file at a given path which meets the needs of checking if the repo meets specific criteria.  Unfortunately it looks like using the rest API for this rapidly exceeds the 5000 request limit.  Will need to try with the graphql API for this (plans to use graphql in the end anyway).  However, it may be more efficient to just clone the repo and find files directly - are there rate limits on this too?

Going with octokit for items it's created for, and cloning for file and directory searches as to not max out the quota. - may revisit this in the future when more flushed out.


Front camera and back camera cannot work together

Front camera and back  camera cannot work together
Like bereal

Steps to Reproduce
Describe how to reproduce the error
Expected results
What it should be
Actual results
only front or only back. its not working together
About your device

Brand
Model
OS

Apple
iPhone X
13.6.1

Thank you reporting this.
I'm not sure anymore but there was a technical reason when we did this.
(ps: I renamed your issue title as you've put the url of this page)

@g-apparence In this thread you can find the native APIs which will allow this functionality.
I beleive that this feature would be an awesome addition to this awesome plugin 🗡:D
https://github.com/flutter/flutter/issues/51928#issuecomment-1120289524

Closed because duplicate of #131


Fix PETSc 3.18.0 deprecation warning about MATTRANSPOSEMAT

Resolves #3260.

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Merged in next for testing...


Minor HTML issue

https://github.com/voodooattack/when-ts/blob/555f5665650d1f8f0dca9498439fd3a5f73226f5/src/stateMachine.ts#L74
The < S > at the end of the line gets interpreted as a strikethrough tag, leading to the documentation being crossed out from here on out:
https://voodooattack.github.io/when-ts/classes/statemachine.html

Closing this now since the root issue is an external tool.


Fixing the inheritance logic

A swagger file can have 'Resource'/'SubResource' models defined in them.
In the current design, these two models have defined structure in ms_rest_azure. When the provided structure matches with the one defined then the defined ones are used. Else, a new class is defined per gem and this new class derives from the standard ones in MsRestAzure.
But, the above approach does have a problem. When the 'Resource' in swagger has properties such as 'name', 'p1', 'p2', 'p3', the above approach fails.
In order to handle this condition, a new design is provided - 'Generate Resource/SubResource per gem'.
What are the changes included in this PR?

Any new code that was added originally to fix the inheritance logic has been removed.
There is no more logic around x-ms-azure-resource & x-ms-azure-external extensions. I have discussed with Amar too and confirmed that this does not have any impact.
AzureModelTemplate.cshtml was introduced originally to handle this issue. Since the logic has been changed, there is no reason to keep it. So, I removed.

How did I test?

I opened all the models in all the services and checked manually.
I have written a script to load all the models in all the services and confirmed there are no issues

@vishrutshah @veronicagg @salameer Please review and approve,

and thanks for the extensive testing on this!

@vishrutshah @veronicagg I have added the testcases around the inheritance logic.

@veronicagg Just to be on the safe side, I have created issue https://github.com/Azure/azure-sdk-for-ruby/issues/1010 and assigned it to next-arm and myself. I will just wait for one more release before taking that step :-)

Just adding Issue link here..
Fixing https://github.com/Azure/azure-sdk-for-ruby/issues/957

publish job


Tooltip right position works not correctly

https://s29.postimg.org/4042dn0iv/image.png
I thought that it is problem for me only, but I see that bug on your web-site

Yeah, thanks.
it's already fixed, but not published yet on demo.

Thanks. When it will be published in library?


portal(dm): delete protal code

What problem does this PR solve?

Issue Number: ref #3583
What is changed and how it works?
only DM v1.0 support dm-portal, so we can delete those dead code now
Check List
Tests

No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Breaking backward compatibility

Related changes
Release note
`None`.

/run-dm-integration-tests

/run-dm-integration-tests

/run-dm-integration-tests

/run-all-tests

need rebase @Ehco1996

need rebase @Ehco1996

done ~~

/merge

/hold
should fix wrong merge master

/merge

/unhold

/run-dm-integration-test
/run-verify

/run-verify

/run-all-tests

/merge

/run-kafka-integration-test

/run-kafka-integration-test


Fix current_user patch in test_asset_meta_and_delete

Instead of
with mock.patch(
    'app.modules.asset_groups.metadata.current_user', return_value=admin_user
):

which only returns admin_user when current_user is called, e.g.
current_user().  What we need is the current_user itself to be
admin_user:
with mock.patch('app.modules.asset_groups.metadata.current_user', new=admin_user):

The metadata.owner was "Public User".

/rebase


Update mockito-core to 3.5.6

Updates org.mockito:mockito-core from 3.5.5 to 3.5.6.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.mockito", artifactId = "mockito-core" } ]

labels: test-library-update, semver-patch

superseeded by #3661


Does shaka player support 8K on webOS TV 6.0?

Does shaka player support 8K on webOS TV 6.0?
I currently have the 75QNED95 (8K) model TV.
media content is applied drm(playready).
I have had success with 4K DRM by shaka player.

If the stream supports it and the TV has decoders to support 8K, it should work without a problem.


Move depends_on out of global namespace

Currently, this is in the global namespace, both in terms of file and where the method is defined. In general, it's better to namespace whenever possible.
In the case of a method, we can put it into a module, and then extend it wherever it's needed. That ends up being all the base classes, which makes sense.

@technicalpickles Lmk if you'd like me to merge?

@andreibondarev :shipit: