Import/export of snapshots

Output of restic version
restic 0.9.1 compiled with go1.10.2 on linux/amd64
What should restic do differently? Which functionality do you think we should add?
I'm using different storages for backups: an internal repository for daily snapshots and an external disk for not so often snapshots. It would be helpful to transfer a snapshot from the internal repo to the external. So I could run restic -r /mnt/backup export |restic -r /mnt/archive import from time to time and save snapshots on different storages. I think it would be useful to allow options to filter the snapshot, i.e. --exclude …
I'm not sure if both commands should be combined like restic transfer /mnt/backup /mnt/archive, but split command would allow a transfer with ssh and maybe you could add a format option to select the tar format. This would ease the first import of backups from foreign software like restic import --fmt tar /mnt/old/backup.tar. The same for an export as tar.

This could also help with migrations to newer versions of the repo format.

Very similar to #323 -- I believe the tricky part is to recompute the packs and rewrite the index. Probably doable, but a slight bit expensive (like prune).
(Maybe this issue should be combined with that one.)

Thanks for your suggestion!
It feels to me this this could be achieved with a copy command proposed in #323, although without modifying the snapshots. I'd like to avoid defining (and having to maintain) an export/import format, at least for now. restic's repo format is already rather complex, and maintaining one format is time consuming enough ;)
#323 is blocked at the moment by a config file, apart from the local and sftp backend types it's not possible to define more than one backend e.g. for b2 or s3, so we need to solve that first. Afterwards it's just a matter of traversing the trees in the snapshots and building a list of blobs to copy, then copy the blobs.
So, I'd like to close this issue for now, please subscribe over at #323 to get notified of any (eventual) progress in this area. Please feel free to add further comments, thanks!

How do you think about a tar import? I had to untar all my old backup and than run restic for them. Wouldn't it be possibly to import a tar archive on the fly?

@jo-so Interesting idea. But how often do you need to untar old backups to import them into restic? :)

@fd0: What happened to the this idea? Is there any way to copy a snapshot from one archive to another and filter it with commands like bsdtar?

@jo-so nobody implemented this so far. There's PR #2124 which adds exporting snapshots (or parts of snapshots) as a tar.

Also I did propose #2226, which would implement a tar import of sorts. But didn't get much feedback for that unfortunately.


Google phishing detection

Hi @kgretzky
Great project!
Quick question: Won't this trigger Google chromes phishing detection if opened with Chrome (with usage statistics, etc, enabled)?

Hi Tim.
Thanks! In my testing, it triggered SafeBrowsing protection once, but all I
had to do was modify the URL slightly and alert was gone.
I've released it to the public for others to check Evilginx detectability
as well.
On 27 Apr 2017 06:01, "Tim"<EMAIL_ADDRESS>wrote:

Hi @kgretzky https://github.com/kgretzky
Great project!
Quick question: Won't this trigger Google chromes phishing detection if
opened with Chrome (with usage statistics, etc, enabled)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kgretzky/evilginx/issues/9, or mute the thread
https://github.com/notifications/unsubscribe-auth/ASXmJyP8KLHBjLeP6iOfKLO3fyTvBhWTks5r0BMPgaJpZM4NJsnL
.


[api-minor] Allow specifying custom match logic in PDFFindController

Allow specifying custom match logic in PDFFindController
This patch allows embedders of PDF.js to provide custom match logic for seaching in PDFs. This is done by subclassing the PDFFindController class and overriding the match method.
match is called once per PDF page, receives as parameters the search query, the page contents, and the page index, and returns an array of { index, length } objects representing the search results.

This is my proposed API for https://github.com/mozilla/pdf.js/issues/18482. It is mostly moving code around, to carve out a (public) method with the minimum possible API that non-Firefox embedders can use to provide their own custom search. More specifically:

the logic in #calculateMatch that builds the RegExp has been moved to #calculateRegExpMatch, so that #calculateMatch is agnostic to the matching logic and only takes care of running the matcher and updating the state based on the match result
#calculateRegExpMatch has been renamed to match(...), that subclasses can override
~#calculateMatch supports calling match even when it's an async function. This does not affect PDF.js itself (since #calculateMatch() is already called in a non-awaited .then(() => ...)), but makes it possible for consumers to have async match logic.~

I believe that this API is minimal enough that it won't cause problems if in the future PDFFindController needs to be refactored, as @calixteman mentioned in https://github.com/mozilla/pdf.js/issues/18482#issuecomment-2248020959.
Some examples of how it can be used:

External search provider
import fuzzySearch from "some-fuzzy-search-library";

class FuzzyFindController extends PDFFindController {
  // "query" is a string
  match(query, text) {
    const results = fuzzySearch(query, text);
    return results.map(({ index, value }) => ({ index, length: value.length }));
  }
}

Multi-word search
This is already supported by PDF.js, but as far as I can tell it cannot be used through the Firefox UI. This example is how it would be implemented in an alternative timeline where this PR would have happened before adding support for multi-word search.
This example assumes that in that alternative universe convertToRegExpString is not private, and it accepts pageIndex instead of this._hasDiacritics[pageIndex].
class MultiWordFindController extends PDFFindController {
  // "query" is an array of strings
  match(query, text, pageIndex) {
    let isUnicode = false;
    // Words are sorted in reverse order to be sure that "foobar" is matched
    // before "foo" in case the query is "foobar foo".
    const queryStr = query
      .sort()
      .reverse()
      .map(q => {
        const [isUnicodePart, queryPart] = this.convertToRegExpString(
          q,
          pageIndex
        );
        isUnicode ||= isUnicodePart;
        return `(${queryPart})`;
      })
      .join("|");

    const flags = `g${isUnicode ? "u" : ""}${this.state.caseSensitive ? "" : "i"}`;
    query = new RegExp(queryStr, flags);

    const matches = [];
    for (const { index, 0: match } of pageContent.matchAll(query)) {
      matches.push({ index, length: match.length });
    }
    return matches;
  }
}

Simple multi-page search
EDIT: This example does not apply anymore now that we only support sync .match. See https://github.com/mozilla/pdf.js/pull/18549#issuecomment-2268954354 for an async matcher example.
This implementation uses some _-prefixed properties of PDFFindController. Assuming that they are meant to be private (I can open a PR to replace _ with # if needed, after that this PR lands), there is also a second implementation that only uses the real public API.
class MultiPageFindController extends PDFFindController {
  // "query" is a string
  async match(query, text, pageIndex) {
    let prefix = "", suffix = "";
    if (pageIndex > 0) {
      await this._extractTextPromises[pageIndex - 1];
      prefix = this._pageContents[pageIndex - 1].slice(1 - query.length) + " ";
    }
    if (pageIndex + 1 < this._linkService.pagesCount) {
      await this._extractTextPromises[pageIndex + 1];
      suffix = " " + this._pageContents[pageIndex + 1].slice(0, query.length - 1);
    }
    text = prefix + text + suffix;

    const matches = [];
    let index = -1;
    while ((index = text.indexOf(query, index + 1)) !== -1) {
      let start = Math.max(prefix.length, index);
      let end = Math.min(index + query.length, prefix.length + text.length);
      matches.push({ index: start - prefix.length, length: end - start });
    }
    return matches;
  }
}

class MultiPageFindController extends PDFFindController {
  #linkService;
  #pageContents;
  #pageContentsPromises = [];

  constructor(opts) {
    super(opts);
    this.#linkService = opts.linkService;
  }

  async #getPageContent(index) {
    if (this.#pageContents[index] == null) {
      this.#pageContentsPromises[pageIndex - 1] ??= Promise.withResolvers();
      await this.#pageContentsPromises[pageIndex - 1].promise;
    }
    return this.#pageContents[index];
  }

  // "query" is a string
  async match(query, text, pageIndex) {
    if (this.#pageContents[pageIndex] == null) {
    	this.#pageContents[pageIndex] = text;
    	this.#pageContentsPromises[pageIndex]?.resolve();
    }

    const [prevPage, nextPage] = await Promise.all([
      pageIndex > 0 ? this.#getPageContent(pageIndex - 1) : "",
      pageIndex + 1 < this.#linkService.pagesCount ? this.#getPageContent(pageIndex + 1) : "",
    ]);
    const prefix = prevPage.slice(1 - query.length) + " ";
    const suffix = " " + nextPage.slice(0, query.length - 1);
    text = prefix + text + suffix;

    const matches = [];
    let index = -1;
    while ((index = text.indexOf(query, index + 1)) !== -1) {
      let start = Math.max(prefix.length, index);
      let end = Math.min(index + query.length, prefix.length + text.length);
      matches.push({ index: start - prefix.length, length: end - start });
    }
    return matches;
  }
}

There are two questions that for which I keep swinging back and forth:

Should the API be subclass-based, or parameter-based?class CustomFindController extends PDFFindController {
  match(...) {}
}

vsnew PDFFindController({
  /* ... various other options... ,*/
  matcher(...) {}
}

PDFFindController already accepts multiple parameters to control its behavior, but having it as a subclass extension point leads to a cleaner implementation.
Should the isEntireWord word check apply after running the matcher, or as part of the default matcher? Running after means that it would easily be available to custom matching logic (simply by setting eintireWord: true on the dispatched "find" event), but on the other hand it feels like its part of the match logic itself.

Please let me know what you think about this :)
PS. If this feature gets accepted and it will need any maintenance in the future feel free to ping me, similarly to how I have been keeping an eye on the various bugs related to text selection.

Thanks for the first review! I addressed all the comments except for those regarding the changes related to the new await.
The reason I added await in front of the this.match call (and thus, for making #calculateMatch async) is so that subclasses can easily use async search logic (mostly, for calling to external services) without being limited by the sync-ness of the API. This causes minimal changes to PDFFindController, since #calculateMatch was already called in a .then callback. I tried to document the need for await in the JSDoc comment of match, which lists Promise<SingleFindMatch[]> | SingleFindMatch[] as the return value.
While this await is a very-nice-to-have, it's not strictly necessary for consumers that need async search logic. Even if PDFFindController only supported sync searches, they would still be able to use async logic by triggering two separate find events with the same query (one that spawns all the search jobs and returns no matches, and then once they are done one to collect all the results) — is that await is a blocking concern for this PR and my explanation isn't convincing, I can remove it.

I tried to document the need for await in the JSDoc comment of match, which lists Promise<SingleFindMatch[]> | SingleFindMatch[] as the return value.

Sure, but my issue is that it's completely impossible to understand that from looking only at the code itself. Hence why it feels like increasing the maintenance burden, since you need to either remember or (somehow) figure out why the code has unneeded asynchronicity. (Unless I'm missing things, the async-support also doesn't appear to be tested...)

While this await is a very-nice-to-have, it's not strictly necessary for consumers that need async search logic.

If, and that's a very big if in my opinion, we should even consider that there needs to be actual users wanting this; not just that it'd be theoretically nice to have.
So, can we please skip the extra asynchronicity for now, and wait until an actual real-world use-cases (that cannot be solved otherwise) emerges first?

Well the reason I added it is that the application I'm working on would use it, it's not a theoretical use case. :stuck_out_tongue:  More specifically, we rely on an external search provider that supports searching semantically based on "similar meaning". This provider is however running asynchronously, and there is no way for me to call it synchronously.
However, as I mentioned above, I believe I can workaround a sync-only API as follows:
class AsyncPDFFindController extends PDFFindController {
  #eventBus;

  #currentQuery = null;
  #pendingMatches = new Map();
  #matchResults = new Map();

  constructor(opts) {
    super(opts);
    this.#eventBus = opts.eventBus;
  }

  match(query, text, pageIndex) {
    if (this.#currentQuery !== query) {
      this.#matchResults.clear();
      this.#pendingMatches.clear();
      this.#currentQuery = query;
    }

    if (this.#matchResults.has(pageIndex)) {
      return this.#matchResults.get(pageIndex);
    }

    if (!this.#pendingMatches.has(pageIndex)) {
      this.#pendingMatches.set(
        pageIndex,
        this.matchAsync(query, text, pageIndex).then(matches => {
          this.#matchResults.set(pageIndex, matches);
          this.#pendingMatches.delete(pageIndex);
        })
      );
    }

    const { state } = this;
    if (state.type !== "custom-reloadmatches") {
      this.#pendingMatches.get(pageIndex).then(() => {
        this.#eventBus.dispatch("find", {
          ...state,
          type: "custom-reloadmatches",
        });
      });
    }

    return undefined;
  }

  async matchAsync() {
    throw new Error("Must be implemented by a sub-class");
  }
}

And then I can have my own async search provider by extending this AsyncPDFFindController class and defining a matchAsync method. It's not as nice as PDFFindController directly supporting an async match, but it should work too. For now I will remove it from this PR, and I will come back in the future if my approach ends up not working.
I agree that if we end up having async support I need to add a test for it.

/botio-linux preview

/botio unittest

/botio integrationtest

Now that the asynchronous bits are removed and it's mainly moving existing code around I think that this refactoring is small and self-contained enough to be accepted.

Agreed; since thinking more about the suggested async behaviour of the match-method, I'm less convinced that it'd have been generally safe and correct unfortunately. With that being async it'd have been possible for e.g. the active search-term to change while a previously pending (and slow) match-call resolves, in which case we'd then update various state with "old" data.

Updated — thanks for the reviews!

/botio unittest

/botio integrationtest

Regarding the timeout on Windows for "must check the new alt text flow" and "New alt-text flow", this branch does not include those tests because I have not rebased it. Should I rebase? Or is it a flaky test?

Regarding the timeout on Windows for "must check the new alt text flow" and "New alt-text flow", this branch does not include those tests because I have not rebased it. Should I rebase? Or is it a flaky test?

I ignored that failing test here, since I don't understand how this PR could affect that one.
Given that it's a new test I'm guessing that it's got some intermittent problems.

Yikes; thanks for noticing this. I have included this new one in the list of intermittents at #18396 for our overview.


[WIP] A parser for the titanic

This one has several open problems at the moment, but I wanted to get it out to enable cooperation and comments.
Any of these issues is up for grab, just overwrite the code and mark it as solved.

[ ] There is an issue with XPath, specifically with the summary. I have trouble extracting it. There is a comment in the code about it.
[ ] Should we include this parser at all? Since it is all about satire, it might mess with the intention to download news.
[ ] There are few articles, maybe #184 should be used on this one.

This PR is really low priority and may be redone once other more important tasks have been completed.


Trim trailing spaces at templates

Generated files have trailing spaces that some linters like rubocop complain about.

Thanks for the PR!


Small spelling mistake - mangnitude

As I note, small typo:
https://github.com/asjadnaqvi/DiD/blob/ad00723c02fe6f894a28f84e7dd6b2f28f1ece83/docs/code/06_bacon.md?plain=1#L518
(if helpful to note typos etc. I'm happy to fork repo and do larger read-through at some point - a very helpful guide!)

Thanks for finding this! I have fixed it. A read through will be great but the pages are currently being reorganized for the next updates


AMQP-643: Java 8 and Lambdas

Mark functional interfaces as such.
Convert many anonymous classes (mainly in tests) to lambdas.

Merged as https://github.com/spring-projects/spring-amqp/commit/8cc1caf1128fa0d828457ed140ad693ec3ab65a7


Write tests for wrapper

Previously https://github.com/alphagov/accessible-typeahead/pull/50.

@nickcolley I decided to leave the setTimeout hack in because in the future I'd like to write our tests with Jest so we can use timer mocks.

Are you sure we want these tests if we have your new e2e tests?

@nickcolley Yes, they are faster. The end to end tests are mainly responsible for keeping a finger on multi-browser support.

Thanks again for your contribution @nickcolley. 👍


Add ArrowHelper to @threlte/extras

https://threejs.org/docs/#api/en/helpers/ArrowHelper
Potentially supporting negative lengths?

You can use the ArrowHelper with the T component. Or do you mean something more custom?
https://stackblitz.com/edit/jqya9c?file=src%2Fexample%2FScene.svelte

(gosh, I really should have added more context to this issue!)
yep! just some custom wrapper around ArrowHelper that keeps it reactive and adds support for negative magnitudes - perhaps it can either be {from, to} or {origin, vector} as well?


Multiple issues

"Camera screen cannot be taken" and it doesnt generate the "Trap Stealer Zips" or the cookies or the passwords. the only proper thing it generates is "email" and "phone" and "discord token". also the "billing" doesnt generate. please fix ty <3

Camera screen cannot be taken : Have you a camera?
And can you send a screen on how it look like ?

Is there any error?

Hi dear i found the problem, it was about thread because it didnt check if everything was good or not

A fixed version have been uploaded tell me if you got another problem ^^

A fixed version have been uploaded tell me if you got another problem ^^

i will tell u soon but can u make it FUD exe?

A fixed version have been uploaded tell me if you got another problem ^^

Exception in thread Thread-3 (upload_files_to_discord):
Traceback (most recent call last):
File "C:\Users\zadge\AppData\Local\Programs\Python\Python311\Lib\threading.py", line 1038, in _bootstrap_inner
self.run()
File "C:\Users\zadge\AppData\Local\Programs\Python\Python311\Lib\threading.py", line 975, in run
self._target(*self._args, **self._kwargs)
File "Modi-Fuscate", line 803, in upload_files_to_discord
FileNotFoundError: [WinError 3] The system cannot find the path specified: 'C:\Users\zadge/Pictures'

I tried in a VM (with no Anti-VM) and it did nothing.

Yes sorry for the antivm it dont work but it's useless xD (i will fix it later)
and new update

ok

File "C:\Users\zadge\OneDrive\Pictures\Trap-Stealer-main\main.py", line 843
def ZipTelegram(path, arg, procc):
SyntaxError: expected 'except' or 'finally' block

Sorry i forgot an except ahah, fixed

ok thanks

when i open main.py it does nothing

Maybe add a webhook

and dont touch main, and use the builder

ok

Trap-Stl-Builted-Obf.py does nothing

have you put the webhook with the builder (an working one) or try the non obfuscated one

i put the webhook

no obfuscated works

it work well?

How strong have you obfuscated it?

wait

no

camera doesnt get grabbed

zips doesnt generate

Do you have a camera xD

everything doesnt work

game zip too? every zip?

can you tell me what you get on the non obfuscated one?

obfuscated doesnt work

100

email and phone and token

hmm what windows are you using?

only that

i run the program in windows 11

i get information in VM windows 10

try to launch it on windows 10

i did

Wait

unobfuscated VMWare windows 10 builder.py right?

ye

are you using a vm win10? or 11?

VM win10

real win11

So you run the program on the vm win10 or real 11?

vm win10

could you try real 11?

why completed?

what?

@ZadgeIsCool ZadgeIsCool closed this as completed now

and can you try launching it on your real computer without vm

No

maybe it would work

I tried this on Real win11

doesnt work

humm strange

it works but

no camera no zip

only email and phone and discord token

hmm strange

when i try to run in vm win10 i have discord but it doesnt take my email or phone or token

can you show me the config ? at the top

builder py?

Nono at the top of the non obfuscated built

ok

show me

everything seem right...
Can you try to put multiple print near line 1210 just to check if it still right or if it stop at some point

1 min

sorry

what do i do?

put some print at the line 1210, to check if something happen or not and then launch it and tell me if it is print

so i put "print" at line 1210?

Do thiung like that

maybe i know the problem , but just wanna check

why print doesnt work ahah

have you install python on vs code?

just save even if there is error and just launch it

ok

Oh you put in in the wrong thing put it near line 1210

you put it under line 1100

bru

you put it here

put it here

it says 1210

wait wut

download the latest main.py because there is a problem '-'

How did you get +100 line '-'

I have latest main.py

show the last line of the file?

GatherAll()

1357

HOW wait

https://pastebin.com/Ppxs3ucY

take this fixed version

BRO

what?

when i paste it in pycharm it shows 1357 last line

how

BRUH
xD

vs code works good

try to make a txt file, put the code in it, and saved it at main.py

try to launch it with it

ok done

it work ?

IT DOES NOTHING SBUGHGSIBUGHIS

zsehifghuoe

have you used the builder?

wait no

YES

BUT STILL

CAMERA BROKEN

AND ZIPS

only generates discord token and email and phone

do you have discord?

can you show me what it send to discord? with a screen (censored stuff)

can you friend me in discord? zadge2

@felix.argyle.

@TheCuteOwl


change botocore version to 1.12.201

without botocore change to 1.12.201, build container cell threw error "Credential named assume-role-with-web-identity not found"
The solution borrowed with pride from https://stackoverflow.com/questions/61753451/credential-named-assume-role-with-web-identity-not-found
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

merged the request.


⚠ Bofrost.nl has degraded performance

In 336303f, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1579 ms

Resolved: Bofrost.nl performance has improved in d2169e1.


Add new prefer-ideal-image eslint rule

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[x] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[x] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Described in #6472. Basically, this plugin enforces the use of @theme/IdealImage component instead of  tags.
Test Plan

Added tests using eslint's RuleTester utility.
Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

#6472

@slorber I still need to fix linting errors and add documentation for this eslint rule, but just wanted to ask, do you think it would be useful to implement auto-fixing capability for this rule?

@slorber I still need to fix linting errors and add documentation for this eslint rule, but just wanted to ask, do you think it would be useful to implement auto-fixing capability for this rule?

I don't think we need auto-fix, no. It sounds very non-trivial and has a high risk of breaking otherwise valid code. Auto-fixing should never change code behavior.

@Josh-Cena Seems like some of the checks are failing for this PR because of the following error:
12:50:33 PM: [INFO] [en] Creating an optimized production build...
12:50:50 PM: [info] [webpackbar] Compiling Client
12:50:50 PM: [info] [webpackbar] Compiling Server
12:51:02 PM: [success] [webpackbar] Client: Compiled successfully in 11.76s
12:51:20 PM: [success] [webpackbar] Server: Compiled with some errors in 30.14s
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: TypeError: _chalk.default.bold is not a function
12:51:20 PM: [ERROR] Unable to build website for locale en.
12:51:20 PM: [ERROR] Error: Failed to compile with errors.
12:51:20 PM:     at /opt/build/repo/packages/docusaurus/lib/webpack/utils.js:180:24
12:51:20 PM:     at /opt/build/repo/node_modules/webpack/lib/MultiCompiler.js:554:14
12:51:20 PM:     at processQueueWorker (/opt/build/repo/node_modules/webpack/lib/MultiCompiler.js:491:6)
12:51:20 PM:     at processTicksAndRejections (node:internal/process/task_queues:78:11)

Anything that needs to be done from my side to fix this?

Thanks but unfortunately that's not so simple. It is preferable that you open an RFC of the behavior you plan to implement before starting the work because the description of the original issue is not really complete and does not mention any design or edge cases to consider.

@slorber Apologies for underestimating the complexity of the implementation of this eslint rule. I should have discussed the schema and the desired behavior first before implementing this rule 😅
I agree the original issue does lack more details regarding the design and edge cases. Actually, I saw one of the comments on the original issue that mentioned that we could directly link a PR back to this issue; hence I went ahead with implementing this PR.

We should allow any string link coming from props, dynamic or hardcoded values:

Sure, it makes sense, as I noticed that the internal implementation of IdealImage in Docusaurus just returns an  tag whenever we pass string links.

Eventually, add an option to reject relative local links?

Any particular reason why we would want to reject relative local links?

The only patterns that IMHO we can safely reject are the usage of images that are required/imported locally:

Got it 👍. So, do we want to encourage users to use the <IdealImage /> whenever images are required/imported locally? Also, if we encourage this behavior, do we also want to check whether the imported/required image is of a supported format or not and throw a violation through this rule?

You can get the real errors by turning disableInDev: false, in the plugin options
https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-ideal-image#disableInDev
err TypeError: Cannot read properties of undefined (reading 'src')
    at fallbackParams (main:8332:43)
    at IdealImage.render (main:7750:106)
    at d (main:67040:231)
    at bb (main:67041:16)
    at a.b.render (main:67047:43)
    at a.b.read (main:67046:83)
    at Object.exports.renderToString (main:67057:138)
    at doRender (main:219469:37)
    at async render (main:219387:16)
    at async /Users/sebastienlorber/Desktop/projects/docusaurus/node_modules/p-map/index.js:57:22

Got it 👍

This PR is not ready to merge, not because of the CI failures, but because the behavior implemented is not what we need.

I'll make the appropriate changes in this PR to fulfill the desired behavior of this eslint rule.

@slorber Apologies for underestimating the complexity of the implementation and misunderstanding the behavior of this eslint rule. I should have discussed the schema and the desired behavior first before implementing this rule 😅
I agree the original issue does lack more details regarding the design and edge cases. Actually, I saw one of the comments on the original issue that mentioned that we could directly link a PR back to this issue; hence I went ahead with implementing this PR.

Not a big deal, some eslint rules are simples while others are much more complex. We can continue the design of the feature in this PR.

We should allow any string link coming from props, dynamic or hardcoded values:

Sure, it makes sense, as I noticed that the internal implementation of IdealImage in Docusaurus just returns an  tag whenever we pass string links.

That's not what I wanted to say. What I mean is that this should be valid because the user could use this component using absolute URLs like a github avatar link.
function Avatar({src}) {
  return
}

We can't know if the component is meant to be used with local images (that can be required) so it shouldn't error by default. At most it should be a warning IMHO, but probably default to no error/warning.

Eventually, add an option to reject relative local links?

Any particular reason why we would want to reject relative local links?

If an image is in the repo, it's probably more optimized to require it instead of using a string path.
I think it's good if we emit a warning by default (with option to disable) for these cases:

const imgSrc = "./xyz.png"

const imgSrc = "/xyz.png"

The only patterns that IMHO we can safely reject are the usage of images that are required/imported locally:

Got it 👍. So, do we want to encourage users to use the <IdealImage /> whenever images are required/imported locally?

Yes, by default we should error for these patterns and encourage usage of the <IdealImage/> component:
import imgSrc from './path/to/img.png';

Also, if we encourage this behavior, do we also want to check whether the imported/required image is of a supported format or not and throw a violation through this rule?

You mean requiring avif, webp and other similar extensions?
I guess it's not really necessary, the Webpack loader will likely already throw an error and we'll likely want to support those extensions in the future.

I'll make the appropriate changes in this PR to fulfill the desired behavior of this eslint rule.

Thanks
I'm not very skilled in writing ESLint plugins, so can't really help to figure out how to check if image was locally required/imported. Maybe @Josh-Cena can guide you?


activation: nil nipst is expected behavior

Motivation
closes: https://github.com/spacemeshos/go-spacemesh/issues/1925
Instead of panic'ing we will log an error that atx with nil nipst is received. It will prevent an adversary from crashing a network just by creating invalid atx.
Changes
Error instead of panic if atx with nil nipst is received.
Test Plan
Uni tests
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[ ] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors merge


Allow online backup of channel db and wallet db

A request has come in to allow online backup of the databases used by lnd so that the process doesn't have to be stopped for backup.
The channel DB can be backed up using https://godoc.org/github.com/boltdb/bolt#Tx.WriteTo
The wallet DB can be backed up using https://github.com/btcsuite/btcwallet/blob/master/walletdb/interface.go#L203 (DB.Copy()).

Hello. Can I work on this issue?

Sure. This should be an easy one, since we're no longer planning on integrating a LevelDB back-end at this time.

In that case I will try to do that.
I want to make sure I understand the problem.
So I have to add an RPC to make a backup, and add the corresponding command in the cli?

Note that this has evolved to the full static back up scheme. The goal here is to ensure there're no foot guns in the regular back up process for users.

Is this being worked on? If yes, is there another tracking issue or pull request or even a branch name where the development takes place?


Number Field dialog pops for Position/Coordinates

Not sure if this is by design or not...
Clicking on the number field in a Set Position block will pop up a number input dialog box.
This is not a great experience as we already have our coordinate field picker which gets shunted into the background.

Dupe of https://github.com/microsoft/pxt-arcade/issues/2793

Dupe of https://github.com/microsoft/pxt-arcade/issues/2793


Ensure runEnv is always a dictionary

Replace use of undefined with an empty dictionary as this will
ease implementing changes from #173 and make the code more robust.

There is bit of chicken and the egg issue here as adding tests underlined that i had to change that but now I think that I will do another change that adds tests for how runEnv works, so we can detect if proposed changes are breaking behavior w/ or w/o ee.

I added the blocked label few days ago to mark that this is not ok to merge as is. Since then I worked towards enable testing first and since yesterday we have some testing on runCommand. Now I will be able to investigate the behavior and also to ensure that when we modify it we don't break it.
To summarize the desired behaviors:

on ee we want to be able to add extra vars (never to reset what container already has). Kinda similar with setenv in tox.
outside ee (local machine) we want to be able to add extra vars and likewise ee, to still keep the process.env as.

An example should explain it better. You likely never want to touch PATH variable, but you may want to add or override some vars specific to our executed commands, like ANSIBLE_FORCE_COLOR=0 or similar.
I am not aware of any use case where we want to run a command with an empty environment or by passing it a full environment, so the default one would not be used. Also I am not aware of any case were we may want to unset some variables that may or may not be present on the ee or non-ee. Is not that we cannot implement these but I would avoid doing it until we have a clear use-case, avoiding over-engineering.
Does anyone think that there is a flaw the logic I described above?
I am inclined to update the way runEnv is used to match this behavior, with tests. If you do find this confusing we could rename it to injectEnv or extraEnv to be closer to how it would work.

You likely never want to touch PATH variable, but you may want to add or override some vars specific to our executed commands, like ANSIBLE_FORCE_COLOR=0 or similar.

We kind of already do: https://github.com/ansible/ansible-language-server/blob/281a660f44fd6d66851f42c6f394190c6554a951/src/utils/misc.ts#L74

I am not aware of any use case where we want to run a command with an empty environment or by passing it a full environment, so the default one would not be used.

Agree with the first part. As for the second case, the default is process.env so it is the full environment. If we send anything less, we're effectively removing environment variables from the child process's scope and that may be a huge and unwelcome surprise to the end-user, uncovered through hours of debugging.

Also I am not aware of any case were we may want to unset some variables that may or may not be present on the ee or non-ee.

One such case is right in the code: https://github.com/ansible/ansible-language-server/blob/281a660f44fd6d66851f42c6f394190c6554a951/src/utils/misc.ts#L77


Fix publisher build .then() example

I chose to bind to publisher because most other examples throughout the wiki utilize the variable name publisher to refer to the resolved PublisherInterface promise

Waiting for PR #38 to be merged


Kerberos Support

Do you guys support Kerberos? I can't seem to find any documentation on using something like a keytab to allow the HDFS crawler the ability to maybe run as a super user that can look into any file or something of that nature.

We use private key to login into remote machine, then run the job as that remote user.
The HDFS dataset configuration is here : https://github.com/linkedin/WhereHows/wiki/Hdfs-Dataset#configuration
Set the hdfs.remote.user and hdfs.private_key_location then it should be good.
We are working on a way to dynamically proxy to the folder owner (this user need to have permission to proxy to any user). Will create the pull request soon.

Just would like to know more around the thought process of, if we were to use this Tool, we would want to capture everything in the cluster as a holistic meta data catalog. In order to do that we would need to run as a super user or a user in HDFS's supergroup correct? Because we can't use Kerberos to essentially impersonate HDFS user when we run jobs.
Your proposed solution seems like you have every user or system ID logging in an keeping track of their own things rather a mandatory user doing all the work? Is that correct in my thinking?

Right now the code in HDFS metadata ETL does not have Kerberos login part, as in VM there is no security restriction. But inside Linkedin we did use Kerberos to manage the security issue, I'll push this part as an optional way later.

Right now it can only read the files that is 'readable to all'. What we plan to do is login as a 'super user' and use this 'super user' to proxy to each folder's owner to fetch the metadata.  The 'super user' I refer to here is a proxy user : https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Superusers.html . All schedulers such as Azkaban, Oozie have this kind of proxy user so they can execute jobs as others. It need extra configuration on hdfs site xml, but not too complex, I'll update the docs after this is done.

For your question about  why would I want a user to proxy into a bunch of other users vs just one user to do everything for me. . I guess the 'super user' your refer to is admin users such as 'hdfs' . It's too risky to use that account in an application, and grid ops guys won't let this happened :( .

Solved in #88


java.lang.IllegalStateException: KoinApplication has not been started

kalasim 0.6.6
fun main() {
    val devices = Resource(name = "devices", capacity = 1)
}

Exception in thread "main" java.lang.IllegalStateException: KoinApplication has not been started
	at org.koin.core.context.GlobalContext.get(GlobalContext.kt:35)
	at org.kalasim.Resource.<init>(Resource.kt:42)
	at MainKt.main(Main.kt:7)
	at MainKt.main(Main.kt)

How could I start KoinApplication?

You would need to create a simulation context before instantiating the resource. E.g. with
Environment().apply{
  val devices = Resource(name = "devices", capacity = 1)
}

For more details regarding koin and dependency injection see https://www.kalasim.org/basics/#dependency-injection
Feel welcome if you have further issues.

I've adjusted the docs accordingly

fun ComponentActivity.contextAwareActivityScope() = runCatching {     LifecycleScopeDelegate<Activity>(         lifecycleOwner = this,         koin = getKoin(this)     ) }.getOrElse { activityScope() }
private fun getKoin(activity: ComponentActivity): Koin {     return if (activity is KoinComponent) {         activity.getKoin()     } else {         GlobalContext.getOrNull() ?: startKoin {             androidContext(activity.applicationContext)             modules(listModule)         }.koin     } }
Here's my fix, give it a try!


in last week or so elfeed-search-browse-url  started to open in foreground?

Hi
after a few good months a recent update i guess started opening tabs in the foreground on chrome and auto shifts to chrome from emacs each launch of elfeed-search-browse-url .
I have changed nothing in my conf. any clue what is going on?
im on latest Arch linux and up to date emacs and elfeed
best
Z

That's very likely a change in Chrome than any change in Emacs or your
configuration. Elfeed uses Emacs' built-in browse-url function to open
URLs, so you should look into how that's configured. Usually it's
literally just running the browser with the URL as the argument, and
it's up to the browser to connect to an existing instance and open up a
tab.


How to make the btshell app support smp?

Hello, I have noticed that the comment in syscfg of btshell shows such a sentence

SMP is not supported in this app, so disable smp-over-shell.

I want to know how to adjust btshell to support SMP?
Or just talk about my original needs:
My current requirement is to build a bonded and link-layer encrypted uart application. I made a simple modification to your bleuart app and make it supports this. But now I can only use the app on my mobile phone to connect to it. I originally wanted to use the api provided by btshell but found that it does not support SMP. Do you have any suggestions?

There is an unfortunate acronym collision in mynewt....  This comment is for SHELL_MGMT which is for mcumgr SMP (Simple Management Protocol) and not for BLE Security Manager.
BLE bonding is supported in btshell sample :-)

Get it. Thanks for the clarification.


docs:Use v-bind for router-link on the API.

Thank you, I don't think this is necessary given how early we introduce shorthands in Vue docs: https://v3.vuejs.org/guide/template-syntax.html#v-bind-shorthand and that we recommend them everywhere


Update aws-java-sdk-core to 1.12.697

About this PR
📦 Updates com.amazonaws:aws-java-sdk-core from 1.12.459 to 1.12.697
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.amazonaws", artifactId = "aws-java-sdk-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #739.


External cpi log streaming

What is this change about?
Currently, the external cpi code uses IO.capture3 for invoking cpi commands. This works pretty well, however, we have experienced cases where the cpi calls would hang for a few days, and since the logs are only written when the process exits there is no way to debug these cases.
This PR changes cpi invocation to use IO.popen3 which allows us to stream cpi error logs while the command is still running. This should help to make debugging infinite cpi loop issues easier.
Please provide contextual information.
One public instance: https://github.com/cloudfoundry/bosh-vsphere-cpi-release/issues/276
But also internal issues once a month.
What tests have you run against this PR?

src/bosh-director/spec/unit/cloud/external_cpi_*
src/spec/integration/cpi_spec.rb

How should this change be described in bosh release notes?
_Something brief that conveys the change and is written with the Operator audience in mind.
Added support for streaming cpi logs, to help debug hanging cpi issues.
Does this PR introduce a breaking change?
The order in which err log and stderr end up in the logs has changed.

@rkoster this is a really useful feature! In https://github.com/cloudfoundry/bosh/issues/2276 we were discussing different options for the hanging issue. A timeout could be helpful here also but it's challenging to find the right value for it.

We've done manual acceptance test and confirmed logs are being streamed. It didn't work on warden because it pipes all messages to stderr found here, after commenting out, the logs are able to stream to test the changes.


Polymorphism support breaks when using dynamic assemblies (OData)

Hello,
I am trying to use Swashbuckle with OData and polymorphism. Things work great until I switch to dynamic assemblies.
I have attached some code sample to repro.
Swagger.zip
Without dynamic assembly it works fine. I get what I expect:

However I lose polymorphism when I start using dynamic assembly which happens when using the Ignore() method (check ModelConfiguration.cs)
// TODO: uncomment to see problems
// animal.Ignore(x => x.NotImportant);

I'm not overly familiar with dynamic assemblies but would point you to the following section in the docs as I think it may be relevent here:
https://github.com/domaindrivendev/Swashbuckle.AspNetCore#detecting-subtypes
By default, Swashbuckle it will only pick up subtypes for polymorphism that are defined in the same assembly as the base type. So, perhaps you could customize the selection strategy (i.e. SelectSubTypesUsing(...)) to account for your "dynamically" generated subtypes.

I'm not overly familiar with dynamic assemblies but would point you to the following section in the docs as I think it may be relevent here:
https://github.com/domaindrivendev/Swashbuckle.AspNetCore#detecting-subtypes
By default, Swashbuckle it will only pick up subtypes for polymorphism that are defined in the same assembly as the base type. So, perhaps you could customize the selection strategy (i.e. SelectSubTypesUsing(...)) to account for your "dynamically" generated subtypes.


[Fonts] Icon request: arrow_circle_right

@AhmedMOLotfy
The said icon seems to be available on latest master. See below:
body: Center(
        child: Icon(
          Icons.arrow_circle_right
        ),
      ),

Is there anything different from what are you looking for ?
Channel master, 2.13.0-0.0.pre.141


#3 get all accounts // moneydance implementation

closes #3
What's in?

Creation of the Moneydance plugin (so lots of technical stuff just to make it work)
Implementation the AccountService interface specific to Moneydance (AccountServiceMD)
Gradle build file for building and signing the Moneydance plugin
logback configuration

We can observe that the threading model performs as expected from the logs.
 2017-10-18 21:59:37,087 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | listAccounts
 2017-10-18 21:59:37,087 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.s.service.AccountsServiceMD    | getAllAccounts
 2017-10-18 21:59:37,093 | INFO  | AWT-EventQueue-0                     | c.g.a.f.b.s.service.AccountsServiceMD    | getAllAccounts with context
 2017-10-18 21:59:37,096 | INFO  | ForkJoinPool.commonPool-worker-1     | c.g.a.f.b.controller.AccountsController  | Obtained accounts:

The important bit is that the use of the Moneydance context happens on the GUI thread (AWT/Swing), named here AWT-EventQueue-0.
In that log, we see that:

the controller is called on a thread in the http-nio-8080-exec pool
the AccountServiceMD logs first on the same thread, before dispatching a task to the withContext of the MoneydanceService
withContext executes its body on the GUI thread AWT-EventQueue-0
the controller thens maps the result of the Future using thenApplyAsync, which forces the body of the mapping to be executed on the default ForkJoinPool.commonPool-worker pool.

@mkulak : After our discussion tonight, I did some threading test. I limited the Spring Boot thread pool to 2 threads and inserted a 10 seconds sleep in the /accounts endpoint. I added a temporary /accounts/foo endpoint that just replies foo without sleeping. Then, I am doing 3 calls to the one that blocks 10 seconds and multiple calls to the foo one to see if it still answers.
Good news is: Spring Boot does NOT wait for those futures to be completed, blocking one of its receiving thread, as you can (maybe) see from this log:
 2017-10-19 22:08:42,186 | INFO  | http-nio-8080-exec-1                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:43,252 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:44,466 | INFO  | http-nio-8080-exec-1                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:45,240 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:46,990 | INFO  | http-nio-8080-exec-1                 | c.g.a.f.b.controller.AccountsController  | listAccounts
 2017-10-19 22:08:46,990 | INFO  | http-nio-8080-exec-1                 | c.g.a.f.b.s.s.AccountsServiceStandalone  | getAllAccounts
 2017-10-19 22:08:47,013 | INFO  | ForkJoinPool.commonPool-worker-1     | c.g.a.f.b.s.s.AccountsServiceStandalone  | Sleeping 10 seconds...
 2017-10-19 22:08:48,825 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | listAccounts
 2017-10-19 22:08:48,825 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.s.s.AccountsServiceStandalone  | getAllAccounts
 2017-10-19 22:08:48,828 | INFO  | ForkJoinPool.commonPool-worker-2     | c.g.a.f.b.s.s.AccountsServiceStandalone  | Sleeping 10 seconds...
 2017-10-19 22:08:50,660 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | listAccounts
 2017-10-19 22:08:50,660 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.s.s.AccountsServiceStandalone  | getAllAccounts
 2017-10-19 22:08:50,664 | INFO  | ForkJoinPool.commonPool-worker-3     | c.g.a.f.b.s.s.AccountsServiceStandalone  | Sleeping 10 seconds...
 2017-10-19 22:08:51,590 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:52,218 | INFO  | http-nio-8080-exec-1                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:52,908 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:53,498 | INFO  | http-nio-8080-exec-1                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:54,069 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:54,656 | INFO  | http-nio-8080-exec-1                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:55,296 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:55,893 | INFO  | http-nio-8080-exec-1                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:56,487 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:57,018 | INFO  | ForkJoinPool.commonPool-worker-1     | c.g.a.f.b.s.s.AccountsServiceStandalone  | ... done sleeping.
 2017-10-19 22:08:57,019 | INFO  | ForkJoinPool.commonPool-worker-1     | c.g.a.f.b.controller.AccountsController  | Obtained accounts:
 2017-10-19 22:08:57,021 | INFO  | ForkJoinPool.commonPool-worker-1     | c.g.a.f.b.controller.AccountsController  | Account(name=foo, subAccounts=[Account(name=subFoo1, subAccounts=[]), Account(name=subFoo2, subAccounts=[])])
 2017-10-19 22:08:57,022 | INFO  | ForkJoinPool.commonPool-worker-1     | c.g.a.f.b.controller.AccountsController  | Account(name=bar, subAccounts=[Account(name=subFoo1, subAccounts=[]), Account(name=subFoo2, subAccounts=[]), Account(name=subFoo3, subAccounts=[]), Account(name=subFoo4, subAccounts=[]), Account(name=subFoo5, subAccounts=[]), Account(name=subFoo6, subAccounts=[]), Account(name=subFoo7, subAccounts=[]), Account(name=subFoo8, subAccounts=[]), Account(name=subFoo9, subAccounts=[])])
 2017-10-19 22:08:57,092 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:57,661 | INFO  | http-nio-8080-exec-2                 | c.g.a.f.b.controller.AccountsController  | foo
 2017-10-19 22:08:58,833 | INFO  | ForkJoinPool.commonPool-worker-2     | c.g.a.f.b.s.s.AccountsServiceStandalone  | ... done sleeping.
 2017-10-19 22:08:58,833 | INFO  | ForkJoinPool.commonPool-worker-2     | c.g.a.f.b.controller.AccountsController  | Obtained accounts:
 2017-10-19 22:08:58,833 | INFO  | ForkJoinPool.commonPool-worker-2     | c.g.a.f.b.controller.AccountsController  | Account(name=foo, subAccounts=[Account(name=subFoo1, subAccounts=[]), Account(name=subFoo2, subAccounts=[])])
 2017-10-19 22:08:58,833 | INFO  | ForkJoinPool.commonPool-worker-2     | c.g.a.f.b.controller.AccountsController  | Account(name=bar, subAccounts=[Account(name=subFoo1, subAccounts=[]), Account(name=subFoo2, subAccounts=[]), Account(name=subFoo3, subAccounts=[]), Account(name=subFoo4, subAccounts=[]), Account(name=subFoo5, subAccounts=[]), Account(name=subFoo6, subAccounts=[]), Account(name=subFoo7, subAccounts=[]), Account(name=subFoo8, subAccounts=[]), Account(name=subFoo9, subAccounts=[])])
 2017-10-19 22:09:00,670 | INFO  | ForkJoinPool.commonPool-worker-3     | c.g.a.f.b.s.s.AccountsServiceStandalone  | ... done sleeping.
 2017-10-19 22:09:00,670 | INFO  | ForkJoinPool.commonPool-worker-3     | c.g.a.f.b.controller.AccountsController  | Obtained accounts:
 2017-10-19 22:09:00,671 | INFO  | ForkJoinPool.commonPool-worker-3     | c.g.a.f.b.controller.AccountsController  | Account(name=foo, subAccounts=[Account(name=subFoo1, subAccounts=[]), Account(name=subFoo2, subAccounts=[])])
 2017-10-19 22:09:00,671 | INFO  | ForkJoinPool.commonPool-worker-3     | c.g.a.f.b.controller.AccountsController  | Account(name=bar, subAccounts=[Account(name=subFoo1, subAccounts=[]), Account(name=subFoo2, subAccounts=[]), Account(name=subFoo3, subAccounts=[]), Account(name=subFoo4, subAccounts=[]), Account(name=subFoo5, subAccounts=[]), Account(name=subFoo6, subAccounts=[]), Account(name=subFoo7, subAccounts=[]), Account(name=subFoo8, subAccounts=[]), Account(name=subFoo9, subAccounts=[])])

Closing this PR. After further experimentation, I came to the conclusion that for this kind of project, Spring Boot is not the right approach. It is way too heavy (the fat-JAR of the extension, with all the Spring dependencies, weight more than the app I am expanding itself).
Also, the main blocker is that version conflict I have with Jackson between the version the latest Spring Boot needs and the version that is already in the classpath at execution. I made it work for a little while (version in this PR), but going further, it does not work very long.
I will be re-writing this with something more light-weight like Vert.x or Javalin.


Website is broken on Firefox

Hi there! For the past week or so, the Umami website has been broken on Firefox, both on mobile and desktop.

The site looks fine on Vivaldi:

It looks like you have an ad blocker or something blocking the CSS file.

You're right, AdGuard is blocking umami's CSS. Weird, because this is the first website this has happened with...


QoL change to line 50

Changes / Comments
Line 50 had a typo
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Does this also need to be added to each .json translation file?

No, it should appear there automatically when Roll20 runs their update things for the translation files.

By mistake I opened a second pull request with the .json change, so this thread can be deleted

Think only you can close it yourself. There should be a "close Pull Request button" at the bottom of this page.


List as parameter is invalid in swagger.json

This issue is similiar to issue #105 except that List is a parameter instead of the return value.
I added the following to the IStore.cs file
       [WebInvoke()]         [OperationContract]         void CreateBookTest(List<string> bookIds);
The swagger.json file produced by swaggerwcf has an error. The editor.swagger.io reports "Could not resolve reference: #/definitions/System.String" and there are several other errors also.
{"operationId":"SwaggerWcf.Test.Service.BookStore.CreateBookTest", "consumes":["application/json"], "produces":["application/json"], "parameters":[ {"name":"bookId","in":"body","required":true, "schema":{ "type":"array"}, "items":{"schema":{"$ref":"#/definitions/System.String"}}, "collectionFormat":0}],
Expected:
{"operationId":"SwaggerWcf.Test.Service.BookStore.CreateBookTest", "consumes":["application/json"], "produces":["application/json"], "parameters":[ {"name":"bookIds","in":"body","required":true, "schema": {"type":"array"}, "items":{ "type":"string" }],
Note: I removed the collectionFormat and changed the the schema

can you try latest version?

I tried with version 0.2.1

0.2.2 is latest version

This is now fixed in version 0.2.2


[BUG]

error: failed to write /tmp/cargo-installnDcVEP/release/.fingerprint/unicode-ident-c79182aedd87c135/invoked.timestamp
Caused by:
No space left on device (os error 28)
warning: build failed, waiting for other jobs to finish...
error: failed to write /tmp/cargo-installnDcVEP/release/.fingerprint/proc-macro2-29e77dd05d5ad761/invoked.timestamp
Caused by:
No space left on device (os error 28)
error: failed to compile feroxbuster v2.11.0, intermediate artifacts can be found at /tmp/cargo-installnDcVEP.
To reuse those artifacts with a future compilation, set the environment variable CARGO_TARGET_DIR to that path.

howdy!
This is a problem with your local environment not having sufficient disk resources (i.e. the hard drive in use is full). With the error provided, I can't give any more insight than that. Additionally, this isn't a problem that I can solve, other than through advice, so closing this one. Please feel free to ask other questions in this thread though.


Allow link for Zenodo credentials for DOI creation in web service

Enable the user to link his Zendo credentials. This could happen when the user clicks on the Create DOI button and their credentials are not set up. It should also be done on the Account page.
┆Issue is synchronized with this Jira Story
┆Issue Type: Story
┆Sprint: Seabright Sprint 11 Kayak
┆Issue Number: DOCK-764
┆Epic: Create DOIs

➤ Walt Shands commented:
PR is still in review but passing tests: https://github.com/dockstore/dockstore/pull/2534 ( https://github.com/dockstore/dockstore/pull/2534|smart-link )

➤ Denis Yuen commented:
Seems to work to create DOIs in staging.
Allowing future tickets to delve into this feature more deeply
https://sandbox.zenodo.org/record/355452 ( https://sandbox.zenodo.org/record/355452 )


Using PHP library to crop the image

Hello, I am using this library http://image.intervention.io/api/crop to crop the image, it take x and y, I tried to use the offsets but they are wrong, can anyone help me ?
Thanks

You can use api onOffsetChange. To find the width and height of the image try this
var elem = $imageCropper.find('.cropit-preview');
var width = elem.width()
var heigh = elem.height()


Set ssh config to use a username for a remote host

Is there a role that we can add that allows for setting up ssh config rules for remote hosts?
I was thinking something like:
ssh_config:
 "github.com"
    - "USER git"
  "*.dev.remote.com"
    - "USER localusername"

Of corse, some of this could be done by changing the vagrant username to something else, but that wouldn't be as flexible.

I wouldn't want to add things inside the VM for this, but if you have the default Vagrantfile, you'll have SSH agent forwarding enabled by default: https://github.com/geerlingguy/drupal-vm/blob/2b94f2858ccf57a2f1fae6cb017fde3ec823dabe/Vagrantfile#L43
Therefore if you vagrant ssh in, the same host config should be available for you while logged in...

The issue is that I have a different usename on the remote dev than on the vagrant box.

In that case you can just prefix things with the username, right? e.g. myname@server instead of just server? Or does the key only apply without a named access?

Could always add a post provisioning script that copies over your .ssh/config to the vm.

@geerlingguy the issue is more of this would be shared in the repo and I am not the only developer. We all have unique usernames on the server.
@oxyc I think that is the best suggestion. We already have the bit about host forwarding, this might work just as well. Are there permission issues when dealing with sharing a ssh config like there is with sharing ssh keys?

Yeah, I'd go with @oxyc's recommendation; in your shell script, you could have it copy the ssh config from the ~/.ssh/config which would work on anyone's host (as long as they're on Mac/Linux), and if you need to set a specific username anywhere, just put in $USER.


[Feature] An option to drop the quoted message from Telegram replies.

Telegram has a reply function that quotes the entire message the user is responding to. This winds up being very spammy on IRC side, especially when the quoted message is full of line breaks.
Also, not passing the blank lines all together would be nice.

Hi, this is fixed in master, you can now set a QuoteDisable=true option under your telegram settings to disable quotes (line breaks have been fixed also).
Please rebuild yourself or a dev binary from https://bintray.com/42wim/nightly/Matterbridge/_latestVersion and let me know if it works like expected.

Thanks!
Quotes are being ignored, but the bridge does still send the blank lines in a multi-line post.

Could you run with -debug and do a message with blank lines in multi and look for
telegram <= Sending message from
telegram <= Message is
irc => Receiving

And paste those here ?
Thanks!

[0051] DEBUG telegram:     <= Sending message from af on telegram.mytelegram to gateway
[0051] DEBUG telegram:     <= Message is config.Message{Text:"one\n\nmore\n\ntime!", Channel:"-1001300521176", Username:"af", UserID:"555757310", Avatar:"", Account:"telegram.mytelegram", Event:"", Protocol:"", Gateway:"", Timestamp:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}, ID:"193919", Extra:map[string][]interface {}{}}
[0051] DEBUG gateway:      => Sending config.Message{Text:"one\n\nmore\n\ntime!", Channel:"-1001300521176", Username:"af", UserID:"555757310", Avatar:"", Account:"telegram.mytelegram", Event:"", Protocol:"", Gateway:"gateway1", Timestamp:time.Time{wall:0xbeae0ab6e33a23fe, ext:51743721661, loc:(*time.Location)(0x15aec80)}, ID:"193919", Extra:map[string][]interface {}{}} from telegram.mytelegram (-1001300521176) to irc.altfurry (#altfurry)
[0051] DEBUG irc:          => Receiving config.Message{Text:"one\n\nmore\n\ntime!", Channel:"#altfurry", Username:"[t]  ", UserID:"555757310", Avatar:"", Account:"telegram.mytelegram", Event:"", Protocol:"", Gateway:"gateway1", Timestamp:time.Time{wall:0xbeae0ab6e33a23fe, ext:51743721661, loc:(*time.Location)(0x15aec80)}, ID:"", Extra:map[string][]interface {}{}}

Ok, but this is a normal message, not a quoted message :)
So the issue with line break is also in the normal messages.

ok, could you try master again? the newlines should be fixed for all messages now

Yep, It's stripping the blank lines now. Thanks again!
Unfortunately it's added a new bug where all telegram messages have an extra blank line sent.

Oops, fixed now :-)

Sweet, working perfectly now, thanks again!
Now I can add my next feature request :3

please open a new issue/feature request for this


Training scripts for LLaMA

I appreciate you releasing the code. Where are the training scripts for the LLaMA model?

This was solved in a direct conversation. For anyone interested in the LLaMA training code, please contact the authors directly (jonathan.thomm@gmail.com).


🐛 Nil pointer on DBContainsPlaylists if DB not loaded

The app would crash after a failed import and a check if the DB contained playlists. This is fixed now.

coverage: 89.239% (-0.1%) from 89.384% when pulling 53432b3e88ab9f23763e444d5f6a8553c83b4a13 on fix_nil into d2a2915acd44c9a266fe15d0b57f0fcd2f3e9725 on master.


Java message that Jython is missing when visual automation is ran

pre-emptive issue

TagUI v5 packaged installation comes with dependencies packaged in. The first time visual automation is run, SikuliX may have to set up Jython appropriately. Try running TagUI again and it should work.
https://github.com/kelaberetiv/TagUI#packaged-installation


[rdbms-connect] Updated version for commands GA

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

rdbms-connect

@calvinhzy Hello can we merge this and release a new version? (so that cloud shell can include this GA as soon as possible)

@evelyn-ys would you merge this? Looks calvinhzy is OOF now..


Initial suggestions for plugin release

The basic structure looks good so far. While using the plugin, we did come up with a few suggestions based on our best practices:

ip2locationio.spc

Could you please update the ip2locationio.spc file to follow the format of the [namecheap plugin](https://github.com/turbot/steampipe-plugin-namecheap/blob/main/config/namecheap.spc
For instance:

 connection "ip2locationio" {
   plugin = "ip2location/ip2locationio"
   # API key for requests. Required.
   # Sign up for a free key at https://www.ip2location.io/pricing
   # api_key = "Q5Z8QS544RKC2VK4P3ZH7YW3C16MDCBW"
 }

docs/tables/*

The example queries in the doc look a bit light. Could you please add 2-3 more example queries wherever possible?

docs/index.md

One example query is sufficient for index.md however we can go forward and add as many example queries as we want in the table docs
We have to keep a section credentials before the configuration section, we can take reference from the namecheap plugin
Also please make sure that the Configuration section is in sync with the changes suggested for the config/ip2locationio.spc file.

README

One example query is sufficient for README.md however we can go forward and add as many example queries as we want in the table docs
The overall format looks good, a small suggestion would be to use sh instead of shell while putting down the CLI commands for instance

steampipe plugin install ip2location/ip2locationio

go.mod

We should recompile the plugin with steampipe-plugin-sdk v5.5.0

ip2locationio/*

The connection_config.go, plugin.go and utils.go seem to be quite well structured however why do we not use the environment variables for setting the api_key? Is there a way to authenticate with environment variables?

CHANGELOG.md

Looks correct we can however keep the release date as TBD

A couple of follow-up questions:

Is there a way to authenticate the api_key using environment variable? If yes, we need to mention explicitly in the ip2locationio.spc, index.md and README.md files
How are we handling the resource not found errors?
Do the APIs support pagination? I did not find any reference to it, but I want to make sure that we have checked that box before releasing it.
While working with the APIs did you encounter rate limit errors?
Please refer to https://steampipe.io/docs/develop/plugin-release-checklist#data-ingestion for more information
Please let us know if you have questions, happy to help :+1:

@madhushreeray30 Thanks for your suggestions.

Have added the environment variable
We are returning the error as Error: Response
The API does not support pagination
There is no rate limit

@ip2location Thanks for the quick updates and fixes!
Just a bit confused about the steampipe plugin install command you have used which is differently stated in the index.md and README.md files could you please look into this and get it updated?
Ideally, I think it should be steampipe plugin install ip2location/ip2locationio.

@madhushreeray30 Sorry, have updated the command.

Thanks @ip2location for this amazing plugin 👍. I was taking a final look at the plugin and had a few questions:

Should the plugin be named ip2location instead of ip2locationio? We have similar plugin references like https://github.com/tomba-io/steampipe-plugin-tomba, https://github.com/turbot/steampipe-plugin-ipinfo etc. Please let us know what your thoughts are on this nomenclature.
The formatting of the example queries should be updated using https://www.freeformatter.com/sql-formatter.html#before-output (2 spaces per indent level) to maintain consistency across all the plugins 👍. BTW the example queries look great!
Could you please point me to the source of the environment variable? I tried searching for it in https://github.com/ip2location/ip2location-io-go but could not find any references to it.

@misraved

We used ip2locationio because the API is from ip2location.io and not using the API from ip2location.com.
Have reformatted the SQL using 2 spaces.
The environment variable was introduced into the steampipe plugin as requested/suggested above. It does not exists in https://github.com/ip2location/ip2location-io-go.

Thanks @ip2location for this amazing new plugin 👍.
Please feel free to push a release tag (v0.0.1) and update the CHANGELOG file for the initial release 🎉 !!

@misraved There appears to be an error in publishing.

@misraved Have deleted the Build and Deploy OCI Image workflow. Do I need to delete the tag and add it again?

No, you do not need to add a new tag 👍.
I have triggered the build process for this new plugin, it should be available on the hub in a while 👍.

Just noticed that the icon and social graphic haven't been created.

Sorry for the delayed response @ip2location, I have fixed the issue of missing social graphics 👍.
The plugin is now available https://hub.steampipe.io/plugins/ip2location/ip2locationio.
Great work 🎉 !!

@misraved Thanks for fixing the graphics!!

@ip2location thanks once again for creating the new plugin and for quickly addressing all the review comments. I believe this issue can now be closed 👍.

@misraved Just saw this error. Is there anything that I need to do?

@ip2location you can remove the workflow from the .github folder since it relies on the workflows that point to a private repository 👍.


Verify post-pnr simulation for PP3

Once PP3 support is merged to master verify that post-pnr simulation using Verilog netlist and SDF timing annotation generated by VPR can be used to simulate a design.

A PR is open (https://github.com/QuickLogic-Corp/symbiflow-arch-defs/pull/504) with all the necessary fixes required for running post-pnr simulations for PP3


exposed add_offset control in concatenate_epochs

Fixes #5282
A small change to allow control of add_offset from the concatenate_epochs function. Before was available only in the _concatenate_epochs function. I also added the documentation for the change to the concatenate_epochs docstring.
P.S. I have recreated the PR in order to fix the commit message

please add a tiny test.

thx @antopolskiy


Remove driver config and adjust documentation

There is no need for the driver auto-config in SpringAI, it's already taken care of in Spring Boot.

This was quick! Thanks @meistermeier
I wonder should we add the spring-boot-starter-data-neo4j dependency to the https://github.com/spring-projects/spring-ai/blob/main/spring-ai-spring-boot-starters/spring-ai-starter-neo4j-store/pom.xml ?

This won't make any sense. This is for Spring Data Neo4j and the module for the Neo4jVectorStore does not require the object mapping. Our intention here was to keep it as simple as possible and only depend on the Neo4j Java driver for the communication.
The auto-config of the Neo4j driver is done already in Spring Boot (auto-configure https://github.com/spring-projects/spring-boot/blob/2abc25d51cbb672ef25bdb8141bb5fef25088404/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/neo4j/Neo4jAutoConfiguration.java#L63) and does not require any additional dependency.

perfect!

Thanks @meistermeier !
Rebased, squashed and merged at 10438c55a3da744a2d59d57d6c7c0f4e79749357


params: Include path parameter

Codecov Report

Merging #5 (e0f0bb2) into main (2cd4a48) will decrease coverage by 0.74%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   24.06%   23.31%   -0.75%
==========================================
  Files           1        1
  Lines         187      193       +6
==========================================
  Hits           45       45
- Misses        142      148       +6

Impacted Files
Coverage Δ

src/specified_handler.erl
23.31% <0.00%> (-0.75%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Feature Request] How to upload media file mp4 or .wmv with el-upload

Existing Component
Yes
Component Name
el-upload
Description
I did not find a tutorial about uploading video files

Upload doesn't care what file type you're uploading. You can upload whatever file you want.

Your help ! Configure how to only be allowed to upload a file. I want to prevent second file upload or have errors occured.

A silly question but i am new ! Thanks your


Only check for update in non-production

Should fix #351

Thank you! 😊 Released with the latest update.


support for class-balancing for download-vott-json flow

Hey Olga! Hope you're doing well!!
I'm sure everything works but there were a few small things I noticed:

The comments on config.ini after line 9 were a little confusing. I didn't get how the "10% not detected" part works. Maybe add more on that to the config_description.md file instead of as a comment?

In line 155 of download_vott_json you used isclose(s, 1, abs_tol=0.01) which makes sense but I think a more readable option would be abs(s-1)<0.01 since (hopefully) there won't be NaN/Inf values.

In prepare_per_class_dict (around line 132) for download_vott_json you could probably use a defaultdict(list) for cleaner code (you could say result=defaultdict(list) and then delete line 133 and 134). Also you should probably make classes a set instead of an np array to save time on line 132.

In line 177 onwards for get_top_rows you could move the for loop in line 181 inside the if statement in line 177 to make it easier to understand. Something like:

if ideal_class_balance is not None:
    class_balances_cnt = len(ideal_class_balance)
    for folder_name in all_files:
        all_files_per_class = prepare_per_class_dict(all_files[folder_name], class_balances_cnt, tag_names)
        # Rest of line 184 onwards

Feel free to ignore everything I said - that's why I put it in a comment here and not on the actual code 😄

@yashpande , thanks a lot for looking into PR, great comments, I will address them! :)

@olgaliak I am not sure this is a result from this PR but I pulled the latest and I am working on master.  I updated my config and I am trying to download images for tagging and asked for 5 images and it started downloading 1000s!  here is a screenshot of output.

and the config is attached.
config_bbalous.zip
Let me know if I am misspecifying something or if you need more info to look into this


".pkl"files

hello, dear author. Where can I get  train_all.pkl, dev_all.pkl and test_all.pkl files?

Hi, did you follow our commands in README to run generate_data_degree_eae.py/generate_data_degree_e2e.py/generate_data_degree_ed.py/ to generate the .pkl files first?

Thanks!!! It's my carelessness.
but when I train degree(end2end), an error occured:
[2023-03-10 12:44:46] - data - Loaded 292257 instances from ./data/degree_e2e_ace05ep/train_all.pkl
[2023-03-10 12:44:47] - data - Loaded 13929 instances from ./data/degree_e2e_ace05ep/dev_all.pkl
[2023-03-10 12:44:47] - data - Loaded 10535 instances from ./data/degree_e2e_ace05ep/test_all.pkl
[2023-03-10 12:44:47] - model - Loading pre-trained model ./bart-large
[2023-03-10 12:45:40] - main - Start training ...
[2023-03-10 12:45:40] - main - ./output/degree_e2e_ace05ep/20230310_124441/train.log
[2023-03-10 12:45:40] - main - Epoch 1
Train 1:   0%|                                    | 0/9134 [00:00<?, ?it/s]Traceback (most recent call last):
  File "degree/train_degree_e2e.py", line 106, in <module>
    loss = model(batch)
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/net/pjr/DEGREE-master/DEGREE-master/degree/model.py", line 20, in forward
    outputs = self.model(input_ids=batch.enc_idxs,
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/transformers/modeling_bart.py", line 1066, in forward
    outputs = self.model(
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/transformers/modeling_bart.py", line 914, in forward
    encoder_outputs = self.encoder(
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/transformers/modeling_bart.py", line 352, in forward
    x, attn = encoder_layer(x, attention_mask, output_attentions=output_attentions)
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/transformers/modeling_bart.py", line 253, in forward
    x, attn_weights = self.self_attn(
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/transformers/modeling_bart.py", line 672, in forward
    q = self.q_proj(query) * self.scaling
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/torch/nn/modules/linear.py", line 94, in forward
    return F.linear(input, self.weight, self.bias)
  File "/home/net/anaconda3/envs/pjrDEGREE/lib/python3.8/site-packages/torch/nn/functional.py", line 1753, in linear
    return torch._C._nn.linear(input, weight, bias)
RuntimeError: CUDA error: CUBLAS_STATUS_INTERNAL_ERROR when calling cublasCreate(handle)
Train 1:   0%|                                    | 0/9134 [00:01<?, ?it/s]
Did you have the error when you run the code? My virtual environment is exactly the same as Readme.
Thanks for your reply!!!!
I fix it, by install torch==1.7.1.
Thanks for your patient so much, I will close the issue.
Thanks again
------------------ 原始邮件 ------------------
发件人:                                                                                "PlusLabNLP/DEGREE"                                                                                @.>;
发送时间: 2023年3月10日(星期五) 中午12:31
@.>;
<EMAIL_ADDRESS>主题: Re: [PlusLabNLP/DEGREE] ".pkl"files (Issue #7)
Hi, did you follow our commands in README to run generate_data_degree_eae.py/generate_data_degree_e2e.py/generate_data_degree_ed.py/ to generate the .pkl files first?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Revise FitText to limit bounds in insights box, and update story

Follow on to https://github.com/studentinsights/studentinsights/pull/2050
Who is this PR for?
HS students, educators
What problem does this PR fix?
Some students have quite long and quite short responses, and the bounds cap didn't work before.
What does this PR do?
This fixes the bounds checking on <FitText /> and updates the bounds for the insights box use.
Screenshot (if adding a client-side feature)

selfie


Add Journal abbreviations from Web of Science

From E-Mail Content (user melp which I can't link here)
https://figshare.com/articles/Journal_abbreviations_from_Web_of_Science/3207787
Refs https://github.com/JabRef/www.jabref.org/issues/34

Fixed in #11


Implement iter::Sum and iter::Product for Saturating

Now this will work:
let sum = (0_u16..=100).map(Saturating).sum::<Saturating<u16>>();
let prod = (1_u16..=100).map(Saturating).product::<Saturating<u16>>();
assert_eq!(sum.0, 5050);
assert_eq!(prod.0, 65535);

Sum and Product are both implemented for Wrapping.

Thanks!


Fix bug in smpt notifier

closes #747

Coverage remained the same at 27.604% when pulling 7b8da29a983eecf24f15c0da39e290b92dfa7d9b on smtp into 46a4af22c8c8afca9e5d04766f77d3833921290a on master.


Add Expo Example

A simple expo example that contains the implementation of the client and the signaling server

Thanks for the contribution.
Can't say i'm too keen on the way you're doing things with hooks but if it works, that is what counts.
Will merge soon.
Can you also provide screenshots?

No problem
I used the hook to separate WebRTC logic from the rest of the UI and navigation logic. Just to make it easy to read and reuse.
I'll add some screenshots and put them on the readme.

Thanks for the update.
Will review soon 👍🏻


Move static legend to cloud-only

@noramullen1 @kelseiv
Slight change in static legend.

Static legend and Hover legend will no longer share the same attributes. They will have separate controls for opacity, orientation, .. etc

And this feature is live now so we are good to add this in once the edit has been made :)


[feat] Support Home Assistant Energy

Is your feature request related to a problem? Please describe.
No, not really an issue.
Home Assistant Energy has been introduced in one of the latest HASS releases. It allows for tracking your energy generation and consumption without the need to create elaborate sensors, and whatnot.
Describe the solution you'd like
Apparently only devices that follow this guide, are supported to be added:
https://www.home-assistant.io/more-info/statistics/
https://developers.home-assistant.io/docs/core/entity/sensor/#long-term-statistics
TL;DR: devices that produce state information using the kWh unit can be tracked, if they have a proper state_class and device_class assigned.
Describe alternatives you've considered
custom automations, sensors, etc...
Additional context
Not much to add here

@bushvin You want to introduce this on mqtt discovery?

I have no idea if it has already been implemented through the js websocket. But yes, it would be nice to have on the MQTT discovery.
Unless there's another way this can be achieved? I wouldn't mind setting this manually.

@bushvin As I explained in docs I have no plan right now to keep mqtt discovery supported in future due to the lack of features it has and that zwavejs integration already covers that needs (and it's integrated on z2m with the zwavejs server). I would ask that question on zwavejs server or hass core repository

ah, my apologies, I somehow missed that. Never mind me then.


[Resource Explorer] Ability to discard entire collection without having to go into it

Currently, the way we delete a collection or some of its items is by going into the collection, select the items to remove then clicking on the remove button.
Another useful scenario for users is to discard of the entire collection with one simple click.
As a user, I want to see a delete collection button
So I can easily discard of my collection.
The design would be something like this:

@thewahome We need some more work around this. We need to consider expanding/reducing the left pane.


[$250] Web - IOU - Unable to delete replaced receipt on manual request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Go to any chat> Create manual request
Go to detail IOU page> Add receipt
Go to 3-dots menu and replace the receipt
Go to 3-dots menu and select Delete

Expected Result:
Receipt should be deleted
Actual Result:
Unable to delete replaced receipt on manual request when there is one request
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/43996225/94973ab8-d886-43cf-8701-d8246593a9e6

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bd5a6adff9415feb
Upwork Job ID:<PHONE_NUMBER>350098944
Last Price Increase: 2024-04-23
Automatic offers:

nkdengineer | Contributor | 0

This bug might be related to #wave-collect - Release 1

Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to delete replaced receipt on manual request when there is one request
What is the root cause of that problem?
The back-end is returning 405 Cannot detach receipt from unowned transaction, and we're simply restoring the transaction here without showing any error message to the user.
So from the user POV, the receipt just restores itself and the feature looks like it doesn't work.
What changes do you think we should make in order to solve the problem?

In here https://github.com/Expensify/App/blob/f28d401b33649e25512cdc88efd4d7d0d944ab5f/src/libs/actions/IOU.ts#L5757, we should set errors on the transaction if the receipt deletion fails.
Fix the back-end not to error in this case, because it's a valid case

What alternative solutions did you explore? (Optional)
NA

Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to delete replaced receipt on manual request when there is one request
What is the root cause of that problem?
The back-end is returning 405 Cannot detach receipt from unowned transaction, and we're simply restoring the transaction here without showing any error message to the user.
So from the user POV, the receipt just restores itself and the feature looks like it doesn't work.
What changes do you think we should make in order to solve the problem?

In here https://github.com/Expensify/App/blob/f28d401b33649e25512cdc88efd4d7d0d944ab5f/src/libs/actions/IOU.ts#L5757, we should set errors on the transaction if the receipt deletion fails. We can add a new error message key like Unexpected error deleting this receipt. Please try again later.

value: {
    ...transaction,
    errors: ErrorUtils.getMicroSecondOnyxError('iou.error.receiptDeleteFailureError')
},

We already have it for the replaceReceipt case, and when requesting money, just missing it for the delete receipt case.
We can also remove the error in optimistic/success data.

Fix the back-end not to error in this case, because it's a valid case.

What alternative solutions did you explore? (Optional)
NA

@nkdengineer's proposal looks good to me. In this case, we'd need someone on the backend to fix the error. Regardless of that, as mentioned in the proposal, we should show the error and that would require a fix from the frontend.
🎀 👀 🎀 C+ reviewed

I agree that we need to show an error message if deleting a receipt on a request does not succeed 👍🏼

Looking into the backend error and leaving some notes for myself.
We're throwing the error here

 Logs from testing locally
2024-04-29T07:44:01.472184+00:00 expensidev2004 bedrock: USMjjb<EMAIL_ADDRESS>(Transaction.cpp:46) verifyWrite [sync] [info] Transaction::verifyWrite accountID=9684 transactionIDList=9166041848027912271 maxReportState=0 isValidOwner=1 areOnValidReports=0

2024-04-29T07:44:01.472366+00:00 expensidev2004 bedrock: USMjjb<EMAIL_ADDRESS>(Receipt.cpp:65) attach [sync] [info] [ReceiptAttach] write/own accountID=9684 receiptID=0 transactionID=9166041848027912271 verifyWrite=0 managerOrAdminAttach=1 scraperMergeAttach=0 isAttachedToPartialTransaction=0

I believe it's because of this condition. Spinning up a PR.

Still working on the backend PR -  https://github.com/Expensify/Auth/pull/10712

@nkdengineer I believe you can proceed with the frontend PR while the backend piece is being worked on.

@allroundexperts The PR is here.

The backend PR has been merged and will be deployed later today: https://github.com/Expensify/Auth/pull/10712

@nkdengineer is paid. @allroundexperts can you pls complete the C+ checklist?

Checklist

This was something that was never implemented. As such, there isn't any PR to pinpoint to.
N/A
N/A
A regression test would be helpful.

Regression test
Pre-Req: Make sure that Simulate failing network requests option is turned on in the Troubleshooting section.

Go to any chat -> Create manual request
Go to detail IOU page -> Add receipt
Go to 3-dots menu and replace the receipt
Go to 3-dots menu and select Delete
Wait for the request to fail

Verify that an error shows up under the receipt image.
Do we 👍 or 👎 ?

$250 approved for @allroundexperts


Fly3D

Adds flying support to a CharacterBody3D

[ ] input actions
[ ] signals
[ ] new movement speed
[ ] options for faster movement with shift

closed by #110


Revert "Revert "[NSError] Use Error for user info providers to match the Darwin version""

Reverts apple/swift-corelibs-foundation#838
https://github.com/apple/swift-corelibs-foundation/pull/833#issuecomment-277047371

@swift-ci please test and merge


ADD HOSTS in docker deployment

This will prevent users from being confused.

[ ] lift to english docs


Previous character builds are rendered when switching characters

Generate 10 builds on a character
Switch to teammate with 0 builds
Previous builds are rendered in profiler

Can't repro


feat: add coreApp property

Adds a property for identifying a core app.
The core_app-field is read from the manifest and set if it is true. In that sense this is the first information we are automatically getting from the manifest/d2.config. Note that the uploader must be a manager to be able to set this.
I've also implemented a simple override for this when editing an application. And you have to be a manager for this property-change to have an effect.
I'm a bit unsure about how we should show this to users, currently I have a simple tag for this:

Could potentially have the DHIS2 logo instead? Feedback welcome.

I've also added a way to sort by 'Core apps' only, but I'm not sure if that is something we want to include.


File Explorer does not show the coverage bar

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.86.0-insider
Commit: 46a233646602c378c2168fa2a104dff8e8551558
Date: 2023-12-11T05:36:45.890Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.86.0-insider Chrome/118.0.5993.159 Electron/27.1.3 Safari/537.36
Hi @connor4312
Sorry I cannot reproduce this issue via the extension sample.
Basically, I feed the test coverage provider with the file coverages. And the test coverage view shows them. And I'm sure that testing.showCoverageInExplorer is enabled.
What could be the reason causing that?

I'm guessing this is because the URIs on files in your coverage don't match precisely with the URIs of files in the workspace. Can you verify whether this is the case?

I think the uri should be correct because when I click the file in coverage view, the editor will open the correct file.

I think I found the cause.
Previously, the uri string is returned from Language Server, I parse the Uri instance by using
Uri.parse(uriString)

After that, the property path of the uri is /C:/Users/sheche/Documents/work/...
Then I changed the code to
Uri.file(Uri.parse(uriString).fsPath);

After that, I found the property path become: /c:/Users/sheche/Documents/work/.... Note that the device name become lower case (I'm on a windows machine)

I feel that this requirement is too implicit. can we handle it at VS Code side? Since both C and c are all valid uri.

Ah, yes, that's my bug. Thanks for the investigation.

Hi @connor4312,
My teammate tried the coverage feature today and found some really strange behavior, and it looks like related with the uri treatment.
We debugged the code and can ensure that all the uri returned to VS Code are using lower case c as the device name.
The version info listed below:
Version: 1.86.0-insider (user setup)
Commit: 789c802e75813bfb38ff2e13e4b322bd7e90124b
Date: 2023-12-14T05:36:50.991Z
Electron: 27.1.3
ElectronBuildId: 25612240
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621

The first video shows that only one file's uri keeps lower case c as the device name. Other files' uri become to upper case C:

https://github.com/microsoft/vscode/assets/6193897/279d1dad-8caf-4b32-a6fb-7f0d35441517

This video shows that for the second run, the coverage explorer kind of empty that nothing displays after expanding

https://github.com/microsoft/vscode/assets/6193897/28408fa0-7b48-4b52-964e-719b0a94685e

The third video shows when clicking on first node, the second node gets expanded.

https://github.com/microsoft/vscode/assets/6193897/620498cc-8524-4552-a18f-1898dc230b13
Looks like the status of the explorer goes into a strange status.

Thanks for the followup, this should be fixed in the next Insiders. I think we have one more of those before pausing builds for the holidays...

Thank you @connor4312 for the quick response 👍

This bug has been fixed in the latest release of VS Code Insiders!
@jdneo, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 1091f68d834974d78cd4f9769034b4ae4581ff2a of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

@connor4312 can we get some steps to verify?

Be on a case-insensitive system
Take the test profile sample https://github.com/microsoft/vscode-extension-samples/tree/main/test-provider-sample
Call .toLowerCase() on the URI before parsing it here https://github.com/microsoft/vscode-extension-samples/blob/5d892ccedd9f162094bd7f519fda1fd07e28f2bb/test-provider-sample/src/extension.ts#L111
Run the extension and run tests with coverage. Verify you see bars in the Explorer view.


Add a possibility of setting up added dynamic route middleware so that it would be executed before any global middleware from /middleware dir

Describe the feature
Hi everyone!
I have found out that:

addRouteMiddleware function adds the specified mw to nuxtApp._middleware.global list
The strict order in which mws are being executed on each route is [...globalMiddleware, ...nuxtApp._middleware.global], where globalMiddleware is a list of scanned mw files from /middleware dir.

That is, mw added by addRouteMiddleware will always be executed after mws from /middleware dir.
I am authoring a module that adds an mw to all projects that use it, and I would like my mw to be always running before any other. It would be great to achieve that in some easy way, e. g. by providing some new argument to addRouteMiddleware. (in this particular case new calls of addRouteMiddleware should not change the fact that a firstly added mw will always be executed first)

Is it possible to add to nuxt any functionality that would allow achieving my goal, i. e. to easily programmatically add some new mw that will be always executed before any other?
Or is there any existing way to easily achieve what I am trying to do?
Is addRouteMiddleware ever the best option to use for my purposes? Another option seems to be adding my mw to middleware array inside app:resolve hook, but working with it is not trivial (there I should specify mw as a path to a file with it, but I need to use compile-time options while creating mw, so I need to generate a proper mw file at first) and I am not sure if this was ever meant to be used by developers.

Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

We think it would be a good idea to allow passing an option to addRouteMiddleware (as with addPlugin) to allow adding middleware to the beginning of the middleware array rather than the end.
In general I'd advise against strict middleware ordering dependencies.

@nicky1038 Here it is https://github.com/nuxt/nuxt/pull/28496