Crash on resume if device is unplugged (or not responding)

Affects version 1.0.2
Application: PowerMateVolume.exe
CoreCLR Version: 7.0.1023.36312
.NET Version: 7.0.10
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.IOException: GetFeature failed.
 ---> System.ComponentModel.Win32Exception (0x80004005): The operation completed successfully.
   --- End of inner exception stack trace ---
   at HidSharp.Platform.Windows.WinHidStream.GetFeature(Byte[] buffer, Int32 offset, Int32 count)
   at HidSharp.HidStream.GetFeature(Byte[] buffer)
   at PowerMate.PowerMateClient.SetAllFeaturesIfStale()
   at Program.<>c__DisplayClass0_0.<<Main>$>b__3(Object _, EventArgs _)
   at PowerMateVolume.EventLogStandbyListener.onEventRecord(Object sender, EventRecordWrittenEventArgs e)
   at System.Diagnostics.Eventing.Reader.EventLogWatcher.HandleEventsRequestCompletion()
   at System.Diagnostics.Eventing.Reader.EventLogWatcher.RequestEvents()
   at System.Diagnostics.Eventing.Reader.EventLogWatcher.SubscribedEventsAvailableCallback(Object state, Boolean timedOut)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.PortableThreadPool.CompleteWait(RegisteredWaitHandle handle, Boolean timedOut)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

When the device is not recognized after resuming, you can check if Windows detected it in Device Manager. It's attached to a PCI-to-PCI Bridge > AMD USB 3.10 eXtensible Host Controller - 1.10 (Microsoft) > USB Root Hub (3.0).
It's not the same PCI-to-PCI Bridge as most of the other USB devices on the system like the mouse and keyboard, which share a bridge with the Radeon GPU and Realtek audio.
The PowerMate is highlighted in the device tree below.

GitHub Actions workflows are currently fucked, but this is a build for cf6c75a:
PowerMateVolume.zip

Device was unusable after resume.
PowerMateVolume had not crashed
Device still appeared in Device Manager with working properly state, no events or error messages.
Restarting PowerMateVolume caused it to crash after a delay because SetFeature failed.
Disabling and enabling the device in Device Manager does not stop PowerMateVolume from crashing in subsequent launches.

Application: PowerMateVolume.exe
CoreCLR Version: 7.0.1223.47720
.NET Version: 7.0.12
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.IOException: SetFeature failed.
 ---> System.ComponentModel.Win32Exception (0x80004005): The operation completed successfully.
   --- End of inner exception stack trace ---
   at HidSharp.Platform.Windows.WinHidStream.SetFeature(Byte[] buffer, Int32 offset, Int32 count)
   at HidSharp.HidStream.SetFeature(Byte[] buffer)
   at PowerMate.PowerMateClient.<SetFeature>g__SetFeatureAndTime|28_0(<>c__DisplayClass28_0&)
   at PowerMate.PowerMateClient.SetFeature(PowerMateFeature feature, Byte[] payload)
   at PowerMate.PowerMateClient.set_LightAnimation(LightAnimation value)
   at PowerMate.PowerMateClient.SetAllFeatures()
   at PowerMate.PowerMateClient.OnConnect()
   at HidClient.AbstractHidClient.AttachToDevice()
   at HidClient.AbstractHidClient..ctor(DeviceList deviceList)
   at HidClient.AbstractHidClient..ctor()
   at PowerMate.PowerMateClient..ctor()
   at Program.<Main>$(String[] args)

I don't think we can fix this with software.

Crashed again with the cf6c75a build while disabling and reenabling the device in Device Manager.
Application: PowerMateVolume.exe
CoreCLR Version: 7.0.1323.51816
.NET Version: 7.0.13
Description: The process was terminated due to an unhandled exception.
Exception Info: System.IO.IOException: SetFeature failed.
 ---> System.ComponentModel.Win32Exception (0x80004005): The operation completed successfully.
   --- End of inner exception stack trace ---
   at HidSharp.Platform.Windows.WinHidStream.SetFeature(Byte[] buffer, Int32 offset, Int32 count)
   at HidSharp.HidStream.SetFeature(Byte[] buffer)
   at PowerMate.PowerMateClient.<SetFeature>g__SetFeatureAndTime|28_0(<>c__DisplayClass28_0&)
   at PowerMate.PowerMateClient.SetFeature(PowerMateFeature feature, Byte[] payload)
   at PowerMate.PowerMateClient.set_LightAnimation(LightAnimation value)
   at PowerMate.PowerMateClient.SetAllFeatures()
   at PowerMate.PowerMateClient.OnConnect()
   at HidClient.AbstractHidClient.AttachToDevice()
   at HidClient.AbstractHidClient.OnDeviceListChanged(Object sender, DeviceListChangedEventArgs e)
   at HidSharp.DeviceList.RaiseChanged()
   at HidSharp.Platform.Windows.WinHidManager.DeviceMonitorEventThread()

Disabling and reenabling the child device (HID-compliant consumer control device) does nothing. Reenabling the parent device (USB input device) makes it appear in Device Manager as "Unknown USB Device (Device Descriptor Request Failed)" with the status

Windows has stopped this device because it has reported problems. (Code 43)
A request for the USB device descriptor failed.

Explorer also shows the toast

⚠ USB device not recognized
The last USB device you connected to this computer malfunctioned, and Windows does not recognize it.

If you click the toast, it shows this dialog box.


Choppy scrolling on youtube pages

Firefox seems to be choppy overall, started when i updated to the newest ytc dev build

Yes, actually, the whole firefox becomes VERY slow after latest update - as soon as you open a video.

Same thing happening over here. Firefox 42.

The newly added code messed it up, here's a build with that removed
YouTubeCenter.zip

Exactly same thing is happening on Chrome 47.

Or just do it yourself:

Open YouTubeCenter.xpi in 7zip or something
2: Open YouTubeCenter.js
Delete lines 1621-1637
Delete line 23230
Save and install

Everything bad on Maxthon 4, video stops every second and browser seems very slow.

Confirmed! thanks @YePpHa ! :D


Support globstar and extglob

Similar with GNU Make, I noticed that knit.glob() also doesn't support globstar and extglob too (e.g path/**/mangle-*.jsonc?). Is it intentional by design?

I'm not opposed to including support for this, I think the glob library I'm using just doesn't support it fully. Maybe this library would support the types of patterns you want? https://github.com/bmatcuk/doublestar. I can look into replacing the current glob usage to use that library instead.

Looks good to me as long as knit script enforce UNIX style path. Path separator must always be '/' instead of '' since that library will disable escaping if it's on Windows.


python: Take control of setuptools and pip version

setuptools 21.0.0
pip 0.8.2

I'm still not a fan of this, we're making our python be yet another special snowflake with it, for the benefit of one single line of code in one package which breaks with the builtin pip...
That said, we've had the argument before, so a begrudging 🚢


Vet Clinic Database #3: Query multiple tables

[x] Use primary key & foreign key mechanism for joining tables.

[x] Query multiple tables.

[x] Prepare complex queries that answer analytical questions.

[x] Screenshots of query results

Query 1
Query 2
Query 3
Query 4
Query 5
Query 6

Thanks very much @miltonHenschel for the review. 😁


False positive detecting unused method argument

Rubucop is incorrectly identifying a method argument as unused.
W: Unused method argument - n. If it's necessary, use _ or _n as an argument name to indicate that it won't be used. You can also write as portfolio_item_n(*) if you want the method to accept any arguments but don't care about them.
Code:
     def portfolio_item_n(n)         selector = '//android.support.v7.widget.RecyclerView[1]/android.widget.FrameLayout[#{n}]/android.widget.ImageView[1]'         wait { find_element(xpath: selector) }       end
As you can see, the argument n is used in FrameLayout[#{n}]
Expected behavior
Rubocop should not report this problem
Steps to reproduce the problem

Paste the above sample into file.rb
% rubocop file.rb

RuboCop version
| => rubocop -V 0.42.0 (using Parser <IP_ADDRESS>, running on ruby 2.0.0 universal.x86_64-darwin15)

One quirk of ruby is that the string interpolation syntax works in double-quoted strings, but not in single-quoted strings. The string in your method is single-quoted, which means that you're not really using the method argument, because the interpolation isn't occurring as you expect:
>> '#{foo}'
=> "\#{foo}"

I've wondered if maybe rubocop should have a cop which lets you know when you attempt to use interpolation in single quoted strings... I even implemented it... but it turns out that there are many such strings in the rubocop codebase, most of which are valid code samples... so I wasn't sure if it made sense... (cc @bbatsov)

Ah ha! I should be using a double-quoted string there. After changing to that, Rubocop no longer finds any offenses, so I'm going to close this. Thanks a lot @maxjacobson.


Binarization with DoReFa-Net

This issue is about DorefaParamsBinarizationSTE.
torch.sign() returns one of three possible values: {-1, 0, 1} .   I think this isn't binarization.
https://github.com/NervanaSystems/distiller/blob/b8fc508528bd3f3d73da7bd62bafa4a5afc9001a/distiller/quantization/clipped_linear.py#L145

You're correct, this is a bug indeed. When the input is 0 the output should be 1.
So, could be something like:
output = torch.where(input == 0, torch.ones_like(input), torch.sign(input)) * E

If you'd like to try and test this and submit a quick PR that'll be great. Otherwise I'll try to get to it soon.

Another option would be:
output = input.sign() * E
output[output == 0] = 1

Not sure if there would be a performance difference between the two.

Thank you for your quick response.
Could you wait for a couple of days ?


[Zeromorph] Avoid decompressing G2 points

Zeromorph verification executes pairing check with the input composed in the following way:
let pi = proof.pi;
let pairing_inputs = [
   (&c, &(-vk.s_offset_h).into()),
   (
     &pi,
     &(E::G2::from(vk.vp.beta_h) - (vk.vp.h * x))
       .to_affine()
       .into(),
   )
];

where vk.s_offset_h, vk.vp.beta_h and vk.vp.h are G2 points. In serialised form, compressed G2 points are represented as 64 bytes:
. . .
"vk_ee":{
   "vp":{
   "g":"2c6a92f8691642e6f4830e904e7c33b3b08e943e732154eca7897cd354a9bd59",
   "h":"40fe7193ec3e7adb474a338a8b55aefd065fd1d038cb80934ea313ec1c66762f9d6606bfcfb440ce81e306136d092e3e5302b422925129d2b71e80fe39bde614",
   "beta_h":"5fb81e39772b0e58a3c2620c694a22c50a7802245255b751f6896a174ba6852e851461a2fb9e5894d095827dd6b0e424d4622c5a8d2ee3a07c84bbb1e130a665"
   },
   "s_offset_h":"5fb81e39772b0e58a3c2620c694a22c50a7802245255b751f6896a174ba6852e851461a2fb9e5894d095827dd6b0e424d4622c5a8d2ee3a07c84bbb1e130a665"
}
. . .

Pairing check on Solidity side (Ethereum's precompile) requires input in specific form, where G2 points are decompressed. Decompressing points on Solidity side is just wasting gas, since it is not actually a useful computation required to be performed on-chain.
Can we update the CompressedSNARK and VerifierKey structures serialisation - to store G2 points in uncompressed form (and exclude implicit decompression from implementation of the reference verifier)?
Probably related to https://github.com/lurk-lab/solidity-verifier/issues/40

while I'm pretty sure we won't make our proof use compressed points, this note on deserialization matters:
https://github.com/privacy-scaling-explorations/halo2curves/issues/109#issuecomment-1849702276


Documented serialization of value tuple types

Documented serialization of value tuple types
Fixes #3019
Suggested Reviewers
@ViktorHofer, @mairaw

@rpetrusha aren't includes supported?

@mairaw, I completely forgot about includes! But the text for each is slightly different -- each refers to the type being documented. That can't be included in an includes, can it?

Thanks for creating the issue, @BillWagner; I've assigned it to myself and scheduled it for next month.

If they're slightly different, then you can forget about my suggestion. 😄

Closing and reopening to begin new build.

Build failed. Closing and reopening to begin new build.

Build failed on the portal. Starting again.

One question somewhat related to this PR @ViktorHofer:
https://docs.microsoft.com/en-us/dotnet/standard/serialization/binary-serialization only lists the ValueTuple type but not its generic versions. Should we include those in the list there?
@rpetrusha this is good to merge now.

I removed the generic versions of ValueTuple and Tuple from the list intentionally as I wanted to shorten the list. If you think this might be misleading, feel free to add them back.


Researcher report bug fixes

Minor bug fix for reportables with nil values
Spec test for details report
Moves lib/reports to app/services/reports
@scytacki   when you get a chance.
( Still working on the excel error  – https://www.pivotaltracker.com/story/show/145550201  )
[#145550201] [#145477945] [#145551627]

👍


Change content for Internet Access page on 5pm 30 Nov 21

Context
https://trello.com/c/OefcvcXW
Changes proposed in this pull request
Guidance to review

 Changes to the 'Internet access' guidance page.


Error related to backup & restore all the data using  "--volumes-from"?

sudo docker run  --rm --volumes-from huginn -v $(pwd):/backup  busybox   tar cvf /backup/backup.tar      /var/lib/mysql
sudo docker run  -d -it --restart=always  -p 3000:3000 -v   /var/lib/mysql --name huginn000  huginn/huginn
docker run -d -it --rm  --volumes-from huginn000   -v $(pwd):/var/lib/mysql    busybox   tar xvf /backup/backup.tar

Can you add a bit more context, what is the error you are getting, does the backup work, when does it fail?

It's been a few years and original issue submitter never followed up. Can we get this closed?


Update README.md for issue #94

Fixes Issue #94
Changes

add hyperlink for preview Template Studio V2 on Netlify

Thanks for the PR! You'll want to add a DCO (Developers Certificate of Originality) per the instructions:

Ensure you provide a DCO sign-off for your commits using the -s option of git commit. For more information see how this works.

Thanks for the PR! You'll want to add a DCO (Developers Certificate of Originality) per the instructions:

Ensure you provide a DCO sign-off for your commits using the -s option of git commit. For more information see how this works.

I have provided the sign-off

Thanks @Niladri24dutta! If you feel like it, you can open another PR to make this link into it's own badge to be next to the netlify - success badge that already exists.

Thanks @Niladri24dutta! If you feel like it, you can open another PR to make this link into it's own badge to be next to the netlify - success badge that already exists.

Is there any existing markdown for the badge similar like for Netlify-success ?

@irmerk also as this PR is merged can this issue #94 be closed?

Thanks @Niladri24dutta! If you feel like it, you can open another PR to make this link into it's own badge to be next to the netlify - success badge that already exists.

Is there any existing markdown for the badge similar like for Netlify-success ?

Honestly, not sure on this one.

How about this one from below ?

How about this one from below ? @irmerk . Please let me know if it's fine I will create another PR and add it .

Yeah this looks great, open a PR and reference the same issue #94


Single operations pt. 1

Added estimation for operations: elementw. mult, elementw. plus, cbind & rbind.
You can now call the estimator with an input string to determine the operation.

LGTM - thanks @johannaSommer. During the merge I only some minor cleanups and extensions.


Updating does not work

The existing instructions on updating vimrc does not work:
✔  ~
17:20 $ cd ~/.vim_runtime
✔  ~/.vim_runtime [master {origin/master}|✔ ]
17:20 $ git pull --rebase
Already up to date.
✔  ~/.vim_runtime [master {origin/master}|✔ ]
17:21 $ python update_plugins.py
Updated bufexplorer
Updated open_file_under_cursor.vim
Updated ctrlp.vim
Updated mayansmoke
Updated vim-indent-object
Updated vim-bundle-mako
Updated auto-pairs
Updated vim-colors-solarized
Updated ack.vim
Updated vim-yankstack
Updated nginx.vim
Updated tlib
Updated vim-addon-mw-utils
Updated nerdtree
Updated ale
Updated vim-less
Updated vim-pyte
Updated vim-snipmate
Updated vim-coffee-script
Updated vim-multiple-cursors
Updated gruvbox
Updated vim-flake8
Updated vim-pug
Updated lightline-ale
Updated vim-commentary
Updated vim-surround
Updated vim-expand-region
Updated vim-gist
Updated typescript-vim
Updated vim-python-pep8-indent
Updated lightline.vim
Updated rust.vim
Updated vim-abolish
Updated vim-markdown
Updated vim-javascript
Updated vim-ruby
Updated goyo.vim
Updated vim-repeat
Updated vim-zenroom2
Updated vim-fugitive
Updated vim-snippets
Updated vim-gitgutter
✔  ~/.vim_runtime [master {origin/master}|✚ 12…5]
17:21 $

Now, trying to update at a later time
✔  ~
17:23 $ cd ~/.vim_runtime
✔  ~/.vim_runtime [master {origin/master}|✚ 12…5]
17:23 $ git pull --rebase
error: cannot pull with rebase: You have unstaged changes.
error: please commit or stash them.
✘-128 ~/.vim_runtime [master {origin/master}|✚ 12…5]
17:23 $ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   sources_non_forked/ale/ale_linters/ruby/sorbet.vim
        modified:   sources_non_forked/ale/doc/ale-ruby.txt
        modified:   sources_non_forked/nerdtree/CHANGELOG.md
        modified:   sources_non_forked/nerdtree/README.markdown
        modified:   sources_non_forked/typescript-vim/README.md
        modified:   sources_non_forked/vim-coffee-script/ftdetect/coffee.vim
        modified:   sources_non_forked/vim-fugitive/autoload/fugitive.vim
        modified:   sources_non_forked/vim-fugitive/doc/fugitive.txt
        modified:   sources_non_forked/vim-gitgutter/autoload/gitgutter/utility.vim
        modified:   sources_non_forked/vim-multiple-cursors/Gemfile.lock
        deleted:    sources_non_forked/vim-snipmate/doc/snipMate.txt
        modified:   sources_non_forked/vim-snippets/snippets/c.snippets

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        sources_non_forked/typescript-vim/compiler/typescriptreact.vim
        sources_non_forked/typescript-vim/ftplugin/typescriptreact.vim
        sources_non_forked/typescript-vim/indent/typescriptreact.vim
        sources_non_forked/typescript-vim/syntax/typescriptreact.vim
        sources_non_forked/vim-snipmate/doc/SnipMate.txt

no changes added to commit (use "git add" and/or "git commit -a")
✔  ~/.vim_runtime [master {origin/master}|✚ 12…5]
17:23 $

I have raised a PR to fix this.

same for me, I don't know why that bunch of files has been modified

same for me, I don't know why that bunch of files has been modified

This command python update_plugins.py modifies the files.

yeah, but why? I've perform such test as remove vim_runtime completely, then checkout new instance, then on NEW instance just do git pull, so no new commits obviously, and then python update plugins and got those updated files.
I'm finding that behavior odd

This repo comes with its own set of files in the sources_non_forked directory. The update_plugins.py updates these files independently and hence we see these newer/changed files in the .vim_runtime directory.
This is a flaw in the design of this git repo. The sources_non_forked dir should be added to the .gitignore` file and the plugins should should not be maintained in this git repo, but downloaded separately during the installation process.

I have another issue while updating. When calling the update_plugins.py script, it always fails with:
Traceback (most recent call last):
  File "/Users/basti/.vim_runtime/update_plugins.py", line 12, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

I tried this with Python 2.7.17 and Python 3.9.1.

I have another issue while updating. When calling the update_plugins.py script, it always fails with:
Traceback (most recent call last):
  File "/Users/basti/.vim_runtime/update_plugins.py", line 12, in <module>
    import requests
ModuleNotFoundError: No module named 'requests'

I tried this with Python 2.7.17 and Python 3.9.1.

@sebelsc I have an open PR that should address this: #595. If that works for you, it would be nice to have more comments and 👍  on that PR so the maintainers can merge it.

Should be fixed. Thanks folks 🙏


turn_angle function not stopping

sorry to spam you with issues :)
I thought I'd let you know that the turn_angle() function sets the robot rotating. But it never stops. I think you forgot to set the robot speed to zero at the end?
Should the last line of this function read
 self.robot.drive_direct(0, 0)

thanks :)
I think I will remove the extra commands and let the user determine how they will figure turns out. Floor texture had large impacts on these commands and I used it as a learning point. I calibrated it on the classrooms which had carpets, but when we took them out into the hall to get some extra room, the those commands totally broke. It would turn way too much.

done in the git repo

I simplified the interface to just the direct drive. Really, you can do everything from just that function, plus you get to control sensor/motor interaction better.

closing due to lack of activity


Garage door with sensor ID spinning for about 20 minutes

What issue do you have? Please be as thorough and explicit as possible.
I successfully installed a Sonoff Basic with the DW2 sensor. While the sensor works fine and return accurate information, in the iOs Home app the spinner indicating that the task of opening/closing the door is in progress spins around for at least 20 minutes. The config json below was modified to try:

Minimize sensorTimeDifference to 10 seconds
Define operationTime to 0.1 second

Even in that case, it spins for minutes/hours...
Details of your setup.

Do you use Homebridge (with config-ui?) or HOOBS?
Yes, with config-ui on a raspberry zero W

Which version of Homebridge/HOOBS do you have?
v.1.16

Which version of this plugin (homebridge-ewelink) do you have? Has the issue started since upgrading from a previous version?
Latest version

Which eWeLink devices do you have that are causing issues? Please include product models if applicable.
Sonoff Basic RF2
Sonoff DW2 Sensor

Do you use your main eWeLink credentials or do you use a secondary eWeLink account for Homebridge?
Main credentials

Please paste any relevant logs below.
{
            "name": "eWeLink",
            "countryCode": "33",
            "username": "****",
            "password": "****",
            "debug": false,
            "debugReqRes": false,
            "disableHTTPRefresh": false,
            "disablePlugin": false,
            "inUsePowerThreshold": 0,
            "lowBattThreshold": 25,
            "sensorTimeDifference": 10,
            "hideZBLDPress": false,
            "groups": [
                {
                    "deviceId": "1000b80f2a",
                    "type": "garage",
                    "setup": "oneSwitch",
                    "operationTime": 1,
                    "sensorId": "1000f15bdd"
                }
            ],
            "bridgeSensors": [
                {
                    "sensorTimeLength": 1
                }
            ],
            "platform": "eWeLink"
        }

Hi @yghelmut
The logs could be a good indication of what is going on/wrong.
Please turn on "Debug Logging" and "Request & Response" logging from the plugin settings.
It would be useful to see the logs from when you open/close the garage onwards.
Also, I would recommend setting the operationTime to something more realistic for a garage, eg 100 (for 10 seconds).
Without the logs, it's almost impossible for me to figure out what's going on.
Thanks

Hi, thanks for your quick reply. Just realized that the DW2 sensors where offline (without telling anyone they went offline) since they don't support anything else than a Wifi B signal...
Problem solved, and the issue is not due to any plugin bug.
Thanks for what you created (and maintain) !!!

Fab. Glad it's sorted!


When sending a struct as a method argument, is it by copy or reference?

Hi. Silly question I couldn't get answered reading the wiki:
When sending a struct as a method argument, is it by copy or reference?
Thanks in advance.

It is not copied. It passes the pointer address, so it behaves as if it were passed by reference.
Technically it's passing a pointer, but for all intents and purposes, they'll behave more or less similar enough to not care about this subtle difference.

Thanks for the reply.
By the way, there is also info in this post: https://hub.jmonkeyengine.org/t/project-junion-struct-types-for-java/40369/8

Yes, just as Frontear said, structs are passed by reference/pointer/long and not copied.


Add -webkit- where its needed

I was experiencing problems with Safari (8.0.3) when it was not doing anything at all or few other glitches, I found out that -webkit- is only added automatically to 'transition' and no other properties, so I added manually and now works like a charm :)

Could you verify with the demo link (http://nnattawat.github.io/flip/) with Safari (8.0.3)? My understanding is that .css() automatically adds those prefix (-webkit-, -o-, -moz-).

Shoot exactly, it does on the example page, with simple html rotating, for some reason in our app it did nothing.... I will get back to you with specifics, I saw some autoprefixer gem and similar stuff in gemfile, hopefully I would be able to track what disabled that :( thx mate :)


Masonry layout break if you use infinite-scroll and ng-filter with ordering

Hi Guys,
Not sure if you have faced this issue or not, when you use angular infinite-scroll and your ng-repeat contains ordering, the Masonry layout breaks
The angular script
studentApp.controller('studentCtrl', function($scope) {

    $scope.students = [
        {studentId: 1, username: "user1",
			dob: "10/01/1970",
            address: { suburb: "Melbourne", state: "vic", postcode: "3000"}},
        {studentId: 2, username: "user2",
			dob: "10/01/1980",
            address: { suburb: "Melbourne", state: "vic", postcode: "3000"}},
        {studentId: 3, username: "user3",
			dob: "11/01/1980",
            address: { suburb: "Melbourne", state: "vic", postcode: "3000"}},
        {studentId: 4, username: "user4",
			dob: "12/02/1980",
            address: { suburb: "Melbourne", state: "vic", postcode: "3000"}}];

    $scope.loadMore = function() {
        var last = $scope.students[$scope.students.length - 1].studentId;

        for(var i = 1; i < 2; i++) {
            $scope.students.push({
                studentId: last + i, username: "user5",
				dob: "12/02/1980",
                address: { suburb: "Melbourne", state: "vic", postcode: "3000"}});
        }
    };
});

css
.masonry-brick {
    margin: 5px;
    float:left;
    padding:10px;
}

.masonry-brick.loaded {
    display: block;
    border:1px solid;
    border-radius:5px;
    white-space: nowrap;
}

This is my sample html

Order By:
        DOB

                    studentId {{student.studentId}} - {{student.username}}

DOB: {{student.dob}}

Location: {{student.location.suburb}}, {{student.location.state}}

If you change the ng-repeat without the ordering like this then it'll work

        studentId {{student.studentId}} - {{student.username}}

DOB: {{student.dob}}

Location: {{student.location.suburb}}, {{student.location.state}}

I have tried to isolate the issue but it seems the reload fails after the infinite scroll is activated? Has anyone experienced this issue?

@sipanda84 could you fix this problem? I did not start using this plugin but I like to switch to masonry from angular-deckgrid - but I will also use infinite-scroll and orderBy. When you have a small update on this, I really appreciate!

Now I'm here where you are. I have exact same issue. Seems like it breaks also track by obj.id and it has some "gaps" between when new elements are put inside

I have an array of 1000 objects. I use limitTo to display the first 30 items and then on scroll I would like to display the next 30 and so on. How would I approach that.

								{{path.name}}

							Assembled by

							{{path.author}}

							in {{path.city + ', ' + path.country}}

```

+1.
I fixed (only a workaround) this problem on my project by increasing the timeout on this.scheduleMasonry from 30ms to 100ms.
Line 44.
Change this:
this.scheduleMasonry = function scheduleMasonry() {
  if (timeout) {
    $timeout.cancel(timeout);
  }
  schedule.push([].slice.call(arguments));
  timeout = $timeout(function runMasonry() {
    if (destroyed) {
      return;
    }
    schedule.forEach(function scheduleForEach(args) {
      $element.masonry.apply($element, args);
    });
    schedule = [];
  }, 30);
};

to this:
this.scheduleMasonry = function scheduleMasonry() {
  if (timeout) {
    $timeout.cancel(timeout);
  }
  schedule.push([].slice.call(arguments));
  timeout = $timeout(function runMasonry() {
    if (destroyed) {
      return;
    }
    schedule.forEach(function scheduleForEach(args) {
      $element.masonry.apply($element, args);
    });
    schedule = [];
  }, 100);
};

The first thing I did to solve this was that I removed my angular-filter, and instead implemented the filter-function back-end. Secondly, I noticed that the loaded masonry-bricks had the class .loaded. I therefore set a simple css rule to hide the .masonry-brick by default, and then when the class .loaded was applied I put display:block;.

I know this is an old issue but I just ran into this using a filter.  You can get around it by broadcasting a masonry.reload event:
$scope.$broadcast('masonry.reload');
This event refreshes the layout and puts everything back into the correct position.  I'm not using infinite scroll but I'm sure you can fire the event within your loadmore() function to refresh the layout when the items have loaded.
For my filter I added a filterChange function which included the event broadcast and triggered it using ng-change, I also had to wrap the broadcast in a timeout to make sure the animations had ended before the reload event was fired.
I hope this helps anyone else that stumbles across this issue.

I had some static elements with the image,so bricks were overlapping at the initialization. So I added a min height to the brick,so bricks will init with min-height and then reload after image is loaded.


Returning invalid with 4xx status code from an action results in 200 HTTP status

Describe the bug
export const actions = {
	default: async ({ request }) => {
			return invalid(400, {foo: true})
         }
}

returns a HTTP 200 status response to the browser while I would expect a 400 HTTP status (from what I understand in the doc).
Should I throw invalid instead?
Reproduction
Have a +page.server.js with above code or check:
https://github.com/SylvainGarrigues/sveltekit-action-codes
Logs
No response
System Info
any

Severity
annoyance
Additional Information
No response

return invalid is correct. This is working fine in my own app. Please provide a complete reproduction.

+page.svelte
<script>
	import { enhance } from '$app/forms'
</script>

<form method="POST" use:enhance>
	<input name="email" type="email" />
	<input name="password" type="password" />
	<button>Log in</button>
</form>

+page.server.js
import { invalid } from "@sveltejs/kit";

/** @type {import('./$types').Actions} */
export const actions = {
  default: async () => {
    return invalid(400, { error: "something is wrong" });
  },
};

With use:enhance, server replies with 200 HTTP status code (not talking about the status field of the JSON payload), while it replies with 400 without it. Is that intended?

@SylvainGarrigues
This is the description directly below the required field "Reproduction" in our issue form. Please reread and provide the information we asked for.

A link to a repository, or a fork of https://node.new/sveltekit, that reproduces the issue. Reproductions must be short, self-contained and correct and must not contain files or code that aren't relevant to the issue — please do NOT just paste a link to your project. Explaining how to reproduce is generally not enough. It pushes the burden of creating a reproduction project onto a small set of volunteer maintainers and isn't scalable. If no reproduction is provided, the issue will be closed.

Please check https://github.com/SylvainGarrigues/sveltekit-action-codes.
It's merely the skeleton app created by create-svelte, with action code from SvelteKit doc.
2 pages there, one with use:enhance, one without. POST response is 400 in one case, 200 in the other.

This is by design. To be able to render validation errors on the same page in case of 400, or an error page in case of other errors, the response code is 200, but if you check the response body* you'll see the 400 code contained in there and the enhanced form should act accordingly.

{"type":"invalid","status":400,"data":{"error":"something is wrong"}}

To add on to that, when using a JS-enhanced form, $page.status will be updated with the 400 status code, if you have anything that's looking at that.

@dominikg  @Conduitry I know the status field of the JSON payload in the response body matches the provided status in the call to invalid`, but I just find it strange that (by design) the same SvelteKit endpoint code produces inconsistent HTTP status code response whether called from JS or from other mean.
Couldn't the server reply with the same consistent HTTP (not in the body) status code from ìnvalid (), and the JS code of enhance still be able to populate $page.form or $page.status on the same page?

I'm questioning the design of HTTP response statuses, that's all - not the content of the JSON payload which is in turn correct.

It's like this to distinguish return invalid from throw error or other unexpected errors. throw error could have any status code, so you could distinguish it on the client only by carefully inspecting the payload, which would be bad.

I think it would be correct, by web standards, for fail(400, {...}) to return an HTTP status of 400 with use:enhance on the form.


stdlib: Add security.h to the WinSDK module

This is required for getting access to the System Services extensions. The change was motivated by the work to support swift-foundation on Windows.

@swift-ci please smoke test

Going to close this for now as I'm not actively working on getting this merged after grading found a workaround. This would still be nice to have.


change for using correct get method depending on param type

fixes #576 #672

Coverage decreased (-0.05%) to 64.361% when pulling 7e2864de290b6ac6d421e937f49029703cfac63f on jainnikhil30:master into 62720c73a10a04081cf23afa867e69bb706b1fbc on ansible:master.

Coverage decreased (-0.05%) to 64.361% when pulling 7e2864de290b6ac6d421e937f49029703cfac63f on jainnikhil30:master into 62720c73a10a04081cf23afa867e69bb706b1fbc on ansible:master.

Coverage decreased (-0.05%) to 64.361% when pulling 7e2864de290b6ac6d421e937f49029703cfac63f on jainnikhil30:master into 62720c73a10a04081cf23afa867e69bb706b1fbc on ansible:master.


Move eth node

Move eth node to old-gravity-api

ETH-node moved, orchestrator, API-endpoint and monitoring are pointed to new node.


create_data.py    nuscenes

When I used the nuscene dataset, this error occurred, so I didn't generate gt_database and kitti_dbinfos_train.pkl. What should I do?

Thank you！

That's just a warning message written my me. point cloud of nuscenes may have problem when use database because the bounding box of key frame may not able to contain all points of sweeps.

I didn't generate gt_database and kitti_dbinfos_train.pkl. how should I solve it?

@traveller59
I hope you can help solve the problem of how to use the nuscenes data set.
thank you very much

please check newest code. the model with database sample is still under tuning, try model without sample first.


Payment Intents and Methods APIs (SCA)

Is anyone working on the new SCA ready APIs?
Edit: Looks like it's getting worked on by contributors here: https://github.com/FarmDrop/stripe-ruby-mock/commits/payment_method
It would be great to have these added to stripe-ruby-mock before the Strong Customer Authentication regulation comes into effect on September 14, 2019.
The APIs include:
Stripe Payment Intents API
Stripe Payment Methods API

Opened a PR to add support for it 🤞

this adds support for more SCA use cases https://github.com/rebelidealist/stripe-ruby-mock/pull/622


When dropping/importing a GeoJSON file we should zoom to the given bbox if defined

fix with https://github.com/kalisio/kdk/issues/483


Fix minor comment typo.

Signed-off-by: John Howard<EMAIL_ADDRESS>The title says it all :smile:

LGTM


The fibo seq has 0, 1, 1, 2, 3, 5, 8, ...

The fibonacci numbers goes as follows: https://en.wikipedia.org/wiki/Fibonacci_number

Indeed, and this plugin use these numbers.


Fix proxy environment variable names

According to the vagrant-proxyconf plugin the environment variables should be named VAGRANT_.
I tested using the KUBERNETES_ names but the master timed out during
==> master: Prepare package manager
with a timeout error.
Using VAGRANT_ works, adding the proxy settings to /etc/environment in the vagrant machine.

I signed it!

@gangefors can you fix the merge conflict so this PR can be salvaged?

I'll fix it when I'm back from vacation. So some time after July the 4th.
On Jun 24, 2016 10:02 AM, "johndmulhausen"<EMAIL_ADDRESS>wrote:

@gangefors https://github.com/gangefors can you fix the merge conflict
so this PR can be salvaged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/kubernetes.github.io/pull/164#issuecomment-228282223,
or mute the thread
https://github.com/notifications/unsubscribe/AARrrKrUp8CkB08qBMLVI6aI_LB7KgIlks5qO48KgaJpZM4Hy8CU
.

I've never rebased a pull request before, did the best I could. I hope the merge commits that github software on OSX added doesn't interfere with merging this PR.

Also seems that the section I modified was removed when readding it in a previous commit. So the commit message is not correct. I'll try to fix it tomorrow.

I think I've updated this correctly. You should be able to merge this now. Sorry for the delay.


Copy images

Use plain old div to support copying rich text/images. This request does not cause iOS devices to open the keyboard.

Hey @joshua-gould, clipboard.js is not intended for image copying. But thanks a lot for your pull request!


biome is being used instead of rome

While navigating the repository to implement https://github.com/cachix/git-hooks.nix/issues/425, I noticed that the rome hook is already configured to use biome instead of the actual rome tool.
This changed was performed in https://github.com/cachix/git-hooks.nix/pull/391 (with no indications or comments whatsoever about this change), and it is still referenced and used as rome throughout the documentation and code.
I propose to rename the rome hook to biome and maintain an alias from the latter to the former for backwards compatibility.

I'll work on this and send a PR soon :slightly_smiling_face:


Query: Rename Lateral joins to Cross/Outer Apply

Since they don't represent lateral join truly

Build is broken in #17357 which caused failures above. @AndriySvyryd is working it already.


Enquires for can this works for IOS?

Hi can I just clarify if this works for IOS too? and I am using E7 :)
Otherwise kindly advise me with alternatives.
Thanks in advance! :)

Yes, it should work on both Android and IOS.

@wkh237  hi! I just tried to understand your codes and found out that you have written for ios. i am going to try it now ! thanks for being RN firebase's saviour! :)

You're welcome.


add test on errorHandling

@cbialobos  I will review this more thoroughly later. For now it seems to cover all the basic, so you won some unlock codes!:)
Observability/error island - test-unhandled-xxx-3551
Integration island - test-the-contract-xxx-874432
Response island - big-unit-test-xxx-87004
db - isolate-test-records-xxx-87644
message queue - sometimes-fake-is-better-xxx-0202


chore: rename ironside-strap to ironside-mac

hopefully force canister to index new url

I'll complete the rename, but Canister stores the cache for repositories as a file-hash. If your repository has a new package then it forces Canister to re-index.


Cannot access a disposed object, Object name: 'ApplicationInsightsSink'

Hi,
I am struggling with writing logs to App Insights from ASP.NET MVC application.
I get the following exception:
Caught exception while emitting to sink Serilog.Sinks.ApplicationInsights.ApplicationInsightsSink: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'ApplicationInsightsSink'.
   at Serilog.Sinks.ApplicationInsights.ApplicationInsightsSink.CheckForAndThrowIfDisposed()
   at Serilog.Sinks.ApplicationInsights.ApplicationInsightsSink.Emit(LogEvent logEvent)
   at Serilog.Core.Sinks.SafeAggregateSink.Emit(LogEvent logEvent)

This is my logger configuration where I write LogEvent to Traces in Application Insights.
   Log.Logger = new LoggerConfiguration()
                .MinimumLevel.Is(minimumLevel)
                .Enrich.FromLogContext()
                .Enrich.WithMachineName()
                .Enrich.WithProcessId()
                .Enrich.WithProcessName()
                .Enrich.WithProperty(LoggerFields.ApplicationName, appName)
                .WriteTo.ApplicationInsights(TelemetryConfiguration.Active, TelemetryConverter.Traces)
                .CreateLogger();

Because of the mentioned error, there are no any logs with Trace type in my Application Insights. Do you have any suggestions?
The following lib's version is used:

Serilog.Sinks.ApplicationInsights 3.1.0
Serilog 2.9.0

I'm seeing the same with the same versions of nugets, on both netcoreapp2.2 and netcoreapp3.1.

Hi! 👋 Thanks for getting in touch, and sorry we were unable to respond to your request. We're in the process of bringing new maintainers onto this project, and need to close stale tickets so that we can identify which items are still important to users of the sink.
If this issue still affects you:

Please consider whether it's a question that can be asked on Stack Overflow; if so, the serilog tag will get your question in front of many more people who can help you
Please consider whether you can research or investigate the issue and propose a solution for other users to benefit from
Feel free to comment here, letting us know it's still a problem

Thanks again!

I am getting this error trying to log to app insights using version 4.0.0. Was there ever a resolution to this?


TensorFlow 1.13.1 -> 1.14.0

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

FWIW, see this TF issue

I think it's best to go from 1.13.1 to 1.15.0 since they have fix the issue in 1.14.0 in terms of not finding required .so files.


Exclude single-argument generics arrow functions from "typeParameters.trailingCommas" option

Starting with TypeScript 4.5, the following code now throws an error.
export const x = <T>(value: T): T => value;

error TS7060: This syntax is reserved in files with the .mts or .cts extension. Add a trailing comma or explicit constraint.

To fix this code, it should be rewritten as follows either:
export const x = <T extends unknown>(value: T): T => value;

export const x = <T,>(value: T): T => value;

dprint formats the second example code to the original unfixed code.
Reference:

https://github.com/microsoft/TypeScript/issues/15713
https://github.com/prettier/prettier/issues/6114
https://github.com/prettier/prettier/issues/6302
https://github.com/prettier/prettier-vscode/issues/955

There are a few instances where this occurs that dprint-plugin-typescript already handles. In this case, here is the relevant code in TypeScript and it's specific to mts and cts files:
        function checkGrammarArrowFunction(node: Node, file: SourceFile): boolean {
            if (!isArrowFunction(node)) {
                return false;
            }

            if (node.typeParameters && !(length(node.typeParameters) > 1 || node.typeParameters.hasTrailingComma || node.typeParameters[0].constraint)) {
                if (file && fileExtensionIsOneOf(file.fileName, [Extension.Mts, Extension.Cts])) {
                    grammarErrorOnNode(node.typeParameters[0], Diagnostics.This_syntax_is_reserved_in_files_with_the_mts_or_cts_extension_Add_a_trailing_comma_or_explicit_constraint);
                }
            }
        }

Will open a fix soon.


Add hyper-highlight-active-pane plugin to plugins.json

You could try using getkap.co to capture it and then double the size in export (unless it automatically doubles it, if set)

Done, didn't realize I was using my external monitor, which is not retina, to record. :)


Clean up the lint issues for source files

Does what it says, removes a whole bunch of warnings and one error.
Changes

Fixed up the source files to satisfy the linter.

Testing

run gulp lint:scripts
run gulp test

Checklist

[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the front end playbook
[x] Passes all existing automated tests
[x] New functions include new tests
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged
[x] Visually tested in supported browsers and devices
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

Testing checklist
Browsers

[ ] Chrome
[ ] Safari
[ ] FF
[ ] IE10
[ ] IE9
[ ] IE8
[ ] Opera
[ ] iOS
[ ] Android
[ ] Blackberry Bold

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

Yep, same as the other one, didn't want to get into refactoring here.


The NPM package just doesn't have anything

Thank you for your report I am taking a look

I am not able to reproduce this error.

@ProbablePrime I'm running npm 6.2.0 on macOS HS 10.13.6

Yea, the npm bundle definitely has stuff in there. Probably some local issue or a partial installation.


Issue with tsconfig.json settings

From @tjvantoll on April 12, 2016 20:34
Hey all,
@burkeholland discovered an interesting issue today. This template does not include a tsconfig.json file, and because of that, a couple of important flags—most notably "emitDecoratorMetadata"—are not set, which causes some issues when you go to actually run an ng2 app.
Is there anyway we allow users to start ng2 apps with the appropriate flags set as expected?
Copied from original issue: NativeScript/template-hello-world-ng#12

Fixed in<EMAIL_ADDRESS>


[jira] Add Jira Plugin

[ ] I added a CHANGELOG entry for this change.
[ ] I adjusted the corresponding documentation for this change.
[ ] I adjusted the values.yaml file and the documentation for all values.

Codecov Report

Merging #414 (e2bdcb2) into main (819f428) will decrease coverage by 0.83%.
The diff coverage is 7.34%.

:exclamation: Current head e2bdcb2 differs from pull request most recent head 3aeee0b. Consider uploading reports for the commit 3aeee0b to get more accurate results

@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
- Coverage   47.19%   46.35%   -0.84%
==========================================
  Files         136      139       +3
  Lines       11534    11776     +242
==========================================
+ Hits         5443     5459      +16
- Misses       5951     6176     +225
- Partials      140      141       +1

Impacted Files
Coverage Δ

cmd/kobs/main.go
0.00% <0.00%> (ø)

pkg/hub/api/applications/topology.go
0.00% <0.00%> (ø)

plugins/plugin-jira/cmd/jira.go
0.00% <0.00%> (ø)

plugins/plugin-jira/pkg/instance/instance.go
0.00% <0.00%> (ø)

plugins/plugin-jira/pkg/instance/helpers.go
81.25% <81.25%> (ø)

pkg/hub/api/applications/applications.go
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Port functionality of GenWeightTablesProducer to LHEWeightTablesProducer

Some info, such as the weight sums, of the current NanoAOD GenWeightTablesProducer are not yet in the new producer.

In progress by @sroychow


Possible Bug in Context Likelihood

When calculating the log likelihood of token at position i,  we should consider the logits at step i-1 and also log likelihood of starting token is undefined (can be set to zero).
https://github.com/NVIDIA/FasterTransformer/blob/main/src/fastertransformer/kernels/logprob_kernels.cu#L71
The way we fixed it.

Shift the position of logits by subtracted by vocab_size_padded (verified for batch_first case)
logits += step_offset + batch_offset - vocab_size_padded;
add step>0 in the loop (to avoid computing log probs for 0th token)

Hi bharatv007
I guess you're thinking the first token (at step 0th) should be ignored in the computation of the log probability of contexts and the token ids should be shifted by 1 according to the descprtion 1 (Shift the ...).
However, FT doesn't have any assumption of input tokens and that's why FT hasn't skipped the first token in computation.
Please correct me if I misunderstood the question and can you explain some details?

If the input is N tokens, the log likelihood will be a N-1 tokens, explained below.
log likelihood is defined as the log of probability of prediciting that token given all the previous tokens. So for first or 0th token, it is undefined as there are no previous tokens. Since we are getting the probability of predicting a token at time t, we need to get the logits upto t-1 (the current kernel is computing the probabilities on the incorrect logits step). Let me know if this is clear enough.

If i understand correctly, the kernel should work if the provided ids are output tokens instead of input tokens at step t. However I see it's called with input tokens here, I think we could either change the log_probs_kernel as bharatv007 suggested, or shift the input_ids by one element (because input of step t+1 is the same as output of step t here).

Thank you for the comment and discussion. As you say, this is a bug, and we have fixed it in latest release.

Close this bug because it is inactivated. Feel free to re-open this issue if you still have any problem.


Update GVM to use InventoryV4

This is a breaking change, but the fix is pretty simple: properties
was renamed to config, while properties now exist for a different
purpose.

This depends on ManageIQ/manageiq-providers-hawkular#74 to be merged, so it was created on a different branch to make sure that the code currently on the branch is working.


tf: show prometheus diff on failure instead of dump

Example output:
   stats.go:130: query "istio_requests_total" returned 2 series, but none matched our query exactly.
    stats.go:130: Series 0
    stats.go:130:   for label "reporter", wanted "destination" but got "source"
    stats.go:130: Series 1
    stats.go:130:   for label "reporter", wanted "destination" but got "source"
    stats.go:130:   for label "destination_app", wanted "server" but got "unknown"
    stats.go:130:   for label "destination_service", wanted "server.echo.svc.cluster.local" but got "server-no-sidecar.echo.svc.cluster.local"
    stats.go:130:   for label "destination_version", wanted "v1" but got "unknown"
    stats.go:130:   for label "destination_service_name", wanted "server" but got "server-no-sidecar"

As part of this, refactored how we pass around Queries to make things more useable in this manner

/test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test lint_istio

analyze-tests_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test lint_istio

analyze-tests_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test analyze-tests_istio

integ-telemetry_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test lint_istio

analyze-tests_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test analyze-tests_istio

integ-telemetry_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry_istio

integ-security_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test lint_istio

analyze-tests_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test analyze-tests_istio

integ-telemetry_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry_istio

integ-security_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security_istio

integ-security-istiodremote_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test lint_istio

analyze-tests_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test analyze-tests_istio

integ-telemetry_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry_istio

integ-security_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security_istio

integ-security-istiodremote_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security-istiodremote_istio

integ-telemetry-istiodremote_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test lint_istio

analyze-tests_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test analyze-tests_istio

integ-telemetry_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry_istio

integ-security_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security_istio

integ-security-istiodremote_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security-istiodremote_istio

integ-telemetry-istiodremote_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry-istiodremote_istio

integ-security-multicluster_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test lint_istio

analyze-tests_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test analyze-tests_istio

integ-telemetry_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry_istio

integ-security_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security_istio

integ-security-istiodremote_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security-istiodremote_istio

integ-telemetry-istiodremote_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry-istiodremote_istio

integ-security-multicluster_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security-multicluster_istio

integ-telemetry-mc_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry_istio

integ-telemetry-istiodremote_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry-istiodremote_istio

integ-security-multicluster_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security-multicluster_istio

integ-pilot-istiodremote-mc_istio
0123b7248a2f1bbc5539a45b3496e4dfbf9abadd
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-telemetry-istiodremote_istio

integ-security-multicluster_istio
124e838df6ab6b6dc5fb5ded2a01f07dd230ae90
link
true
/test integ-security-multicluster_istio

integ-pilot-istiodremote-mc_istio
0123b7248a2f1bbc5539a45b3496e4dfbf9abadd
link
true
/test integ-pilot-istiodremote-mc_istio

integ-telemetry_istio
0123b7248a2f1bbc5539a45b3496e4dfbf9abadd
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
0123b7248a2f1bbc5539a45b3496e4dfbf9abadd
link
true
/test integ-pilot-istiodremote-mc_istio

integ-telemetry_istio
0123b7248a2f1bbc5539a45b3496e4dfbf9abadd
link
true
/test integ-telemetry_istio

integ-telemetry-istiodremote_istio
0123b7248a2f1bbc5539a45b3496e4dfbf9abadd
link
true
/test integ-telemetry-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
0123b7248a2f1bbc5539a45b3496e4dfbf9abadd
link
true
/test integ-pilot-istiodremote-mc_istio

integ-telemetry-istiodremote_istio
0123b7248a2f1bbc5539a45b3496e4dfbf9abadd
link
true
/test integ-telemetry-istiodremote_istio

integ-telemetry_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry_istio

integ-telemetry-istiodremote_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry_istio

integ-telemetry-istiodremote_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry-istiodremote_istio

integ-telemetry-mc_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry_istio

integ-telemetry-istiodremote_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry-istiodremote_istio

integ-telemetry-mc_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry-mc_istio

lint_istio
67f7d05f68b9c21c63effa61323028e9afbefcfb
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry_istio

integ-telemetry-mc_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry-mc_istio

lint_istio
d070ed2e91d9db8f8fced6a77de864c9f7247461
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
fdeb74e16fcb7d0f8990f8df98962092d327e2e0
link
true
/test integ-telemetry-mc_istio

integ-telemetry_istio
68622bbfb945147eda18b76bda9a96b92d756a8e
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
68622bbfb945147eda18b76bda9a96b92d756a8e
link
true
/test integ-telemetry_istio

lint_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
68622bbfb945147eda18b76bda9a96b92d756a8e
link
true
/test integ-telemetry_istio

lint_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test lint_istio

analyze-tests_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test lint_istio

analyze-tests_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test analyze-tests_istio

integ-telemetry_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test lint_istio

analyze-tests_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test analyze-tests_istio

integ-telemetry_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test integ-telemetry_istio

integ-telemetry-istiodremote_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test integ-telemetry-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test lint_istio

analyze-tests_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test analyze-tests_istio

integ-telemetry_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test integ-telemetry_istio

integ-telemetry-istiodremote_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test integ-telemetry-istiodremote_istio

integ-telemetry-mc_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test integ-telemetry_istio

integ-telemetry-istiodremote_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test integ-telemetry-istiodremote_istio

integ-telemetry-mc_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test integ-telemetry-mc_istio

integ-pilot-istiodremote-mc_istio
528019be15bc49f5849faff19e65f4868c37bde0
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
24c9503525b80540478358a20bd04d3b8bded4c9
link
true
/test integ-telemetry-istiodremote_istio

integ-pilot-istiodremote-mc_istio
528019be15bc49f5849faff19e65f4868c37bde0
link
true
/test integ-pilot-istiodremote-mc_istio

integ-telemetry_istio
528019be15bc49f5849faff19e65f4868c37bde0
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-mc_istio
528019be15bc49f5849faff19e65f4868c37bde0
link
true
/test integ-pilot-istiodremote-mc_istio

integ-telemetry_istio
528019be15bc49f5849faff19e65f4868c37bde0
link
true
/test integ-telemetry_istio

integ-security-istiodremote_istio
528019be15bc49f5849faff19e65f4868c37bde0
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
59d9fd0c9c13f0af867059b8c3dc7fddc3aa8727
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
59d9fd0c9c13f0af867059b8c3dc7fddc3aa8727
link
true
/test integ-telemetry_istio

lint_istio
7cd0f600eb9dfbc306193b9393b7eeaf758cac1d
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
59d9fd0c9c13f0af867059b8c3dc7fddc3aa8727
link
true
/test integ-telemetry_istio

lint_istio
7cd0f600eb9dfbc306193b9393b7eeaf758cac1d
link
true
/test lint_istio

gencheck_istio
7cd0f600eb9dfbc306193b9393b7eeaf758cac1d
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Add cupy to Windows CI

Multithreaded in-place prediction with cupy does not work on Windows (#5793). I am unable to find a workaround so have just disabled one test.

Codecov Report

Merging #5797 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5797   +/-   ##
=======================================
  Coverage   82.61%   82.61%
=======================================
  Files          12       12
  Lines        2727     2727
=======================================
  Hits         2253     2253
  Misses        474      474

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b47b5ac...c2c64aa. Read the comment docs.


Why don't any of the examples use applyForce / applyImpulse?

I'm trying to debug my jumping code (as mentioned on Twitter) and when looking at the FPS example code, http://schteppe.github.io/cannon.js/examples/js/PointerLockControls.js, to make the player jump, the velocity property of the body is mutated directly:
var velocity = cannonBody.velocity;

...

        case 32: // space
            if ( canJump === true ){
                velocity.y = jumpVelocity;

Why do you do this instead of using applyForce or applyImpulse? Are those innappropriate to use for applying movement forces to a player?

If you run applyForce or applyImpulse, it will add to body.force or body.velocity. That makes the jump height unpredictable, which isn't acceptable when making a game. Instead, if you set the absolute value of the velocity, you always know what height you get.

ah ok, thanks!

On these lines of the FPS demo, PointerLockControls.js
    // Add to the object
    velocity.x += inputVelocity.x;
    velocity.z += inputVelocity.z;

Isn't that the same as applyImpulse?

Yeah, it is! But applyImpulse can add angular velocity too, depending on where you apply the impulse.


ClosureBackedMethodInvocationDispatch doesn't set the Closure delegation property

Expected Behavior
According to the documentation for TaskExecutionGraph, we can expect the delegate object for the Closure of whenReady(Closure) be TaskExecutionGraph as whenReady(Action<TaskExecutionGraph>) shows. The following code should pass:
gradle.taskGraph.whenReady {
    println hasTask("foo")
}

Current Behavior
The code actually fails with:
* What went wrong:
Could not find method hasTask() for arguments [foo] on root project 'foo-project' of type org.gradle.api.Project.

Context
It seems the closure invocation is handled by ClosureBackedMethodInvocationDispatch and the dispatching doesn't set the delegate properly.
Steps to Reproduce (for bugs)
Use the code above and invoke gradle on any task.

There are three ways this could get fixed:

Replace all usage of ClosureBackedMethodInvocationDispatch that will clearly be called with only a single parameter with ConfigureUtil.configureUsing(closure) passing the result to the overloaded method taking an Action
Modify ClosureBackedMethodInvocationDispatch.dispatch to always use the first arguments, if any, as the delegate
Modify ClosureBackedMethodInvocationDispatch.dispatch to use the first arguments, if only one argument is available, as the delegate

Option 1 was implemented here https://github.com/gradle/gradle/commit/ba0cbf33a217c701de24d0fd2450a0159a283b46. I see it as the best option but requires a wider change list. Option 3 could be a good one. I think option 2 would result in unexpected behavior for the couple usage that passes more than 2 parameters to the closure.

I don't think we can consider this actionable without a use case. Could you please provide one @lacasseio or close this?


try using the goreleaser docker image

Updates circleci configuration for release workflow as follows:

uses goreleaser docker image
updates the command run for release to just goreleaser instead of script

it does the thing:
https://github.com/trussworks/setup-new-aws-user/releases/tag/v0.1.11 was released on here


[BUG] Sometimes alerts are not triggered even though anomalies exist in sub-dimensions

Describe the bug
For particular KPIs, alerts are not sent or triggered even though anomalies exist in some sub-dimensions (and not overall) for the latest date.
Overall graph:

Subdims graph (anomalies are present for latest dates)

Logs showing "No anomalies exist"

Explain the environment

Chaos Genius version:  0.4.0
OS Version / Instance: Ubuntu 20.04 on EC2
Deployment type: Docker

Fixed by #780 and #680


Loss of detail in gRPC error mapping in client

Trying to run a container via ctr (or using the client library, now that both are using the same code) on an image that has not been pulled results in the simple output of:
# ctr run --rm --tty docker.io/library/alpine:latest alpine sh
metadata: not found

Given that error could relate to namespace or other metadata controlled objects, it would be good for the user to understand that this means that docker.io/library/alpine:latest isn't in the content store. And actually this level of detail is returned from the gRPC image service Get API here, but using the client of the same service throws that information away in the corresponding rewriteGRPCError here
One option is to preserve that information in the error by using grpc.ErrorDesc() in the rewrite error function, or wrapping it, but I'm not sure what kind of contract we are trying to hold there for error returns, hence my issue instead of a PR.
// cc: @stevvooe

@estesp We can wrap the rewrite in the original error string, such that the cause evaluates to metadata.ErrNotFound, but we get context on the error:
return errors.Wrap(ErrNotFound, err.String())

It looks wrong, but it might work.
The other, better option might be to define error interfaces, similar to Cause and Temporary to mark errors as NotFound() with an appropriate method. This will avoid some of the structural errors.


vscode debugger time out on win10

Environment data

VS Code version: XXX
Extension version (available under the Extensions sidebar): XXX
OS and version: XXX
Python version (& distribution if applicable, e.g. Anaconda): XXX
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Relevant/affected Python packages and their versions: XXX

Expected behaviour
XXX
Actual behaviour
XXX
Steps to reproduce:

XXX

Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
XXX

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)
XXX

Hello, this is a problem, the debugger does not debug what the file writes

Please fill the comment template we have to the best of your knowledge. Also, i don't see a problem with the image, please describe the problem more clearly.

sorry, I will fill the template.
thanks for responding


Json encode float issue

Summary of problem or feature request

json encode float issue on php 7.1
I tried to set
serialize_precision = -1
but the data from database is not correct
Code snippet of problem
$data = $this->model->join('parts as p', 'p.id', '=', 'production_plans.part_id')
            ->join('countries as c', 'c.id', '=', 'p.country_id')
            ->join('classification_materials as cm', 'cm.id', '=', 'p.classification_material_id')
            ->select(
                'production_plans.part_id',
                **DB::raw('SUM(production_plans.weight) as weight_plans')**,
                DB::raw('GROUP_CONCAT(production_plans.order_id) as orderIds'),
                'p.code as material_classification_code',
                'p.name as material_part_name',
                'cm.name as material_original_name',
                'c.name as material_country_name',
                'production_plans.type',
                'production_plans.production_date'
            )->where('production_plans.type', 0)//
            ->where('production_plans.part_id', 7)
            ->where('production_plans.production_date', '<=', $tomorrow)
            ->groupBy('production_plans.part_id');

        return $data;

The weight_plans was caculated from mysql
Excerpt from multidimensional array (before):
array:9 [
    "part_id" => 7
    "weight_plans" => 2.9
    "orderIds" => "1698,1731,1733,1732,1734,1739"
    "material_classification_code" => "00301"
    "material_part_name" => "肩ﾛｰｽ"
    "material_original_name" => "牛"
    "material_country_name" => "輸入"
    "type" => 0
    "production_date" => "2018-01-31"
  ]

after json encode
{"part_id":7,"weight_plans":2.9000000000000004,"orderIds":"1698,1731,1733,1732,1734,1739","material_classification_code":"00301","material_part_name":"\u80a9\uff9b\uff70\uff7d","material_original_name":"\u725b","material_country_name":"\u8f38\u5165","type":0,"production_date":"2018-01-31"}
System details

Operating System Ubuntu Server 16.04
PHP Version 7.1.2
Laravel Version 5.4
Laravel-Datatables Version 7.0

Does anybody have any idea ?

I think you just need to set some json parameter via config appropriately to your needs. This how the response being built:
        return new JsonResponse(
            $output,
            200,
            config('datatables.json.header', []),
            config('datatables.json.options', 0)
        );

Based on this, you can override the json header and options as needed.