Feature/swagger script

Removes all the authorization header injection via script since it's not longer necessary due to new swagger security definition and swagger authorization endpoints

Codecov Report

Merging #97 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop      #97      +/-   ##
===========================================
- Coverage     65.3%   65.28%   -0.02%
===========================================
  Files           90       90
  Lines         2421     2420       -1
  Branches       307      307
===========================================
- Hits          1581     1580       -1
  Misses         675      675
  Partials       165      165

Impacted Files
Coverage Δ

src/app/loginComponents/user.service.ts
92.85% <100%> (ø)
:arrow_up:

src/app/myworkflows/myworkflows.component.ts
77.41% <100%> (ø)
:arrow_up:

src/app/loginComponents/token.service.ts
92% <100%> (-0.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e5901...ddcf9ab. Read the comment docs.


More construction recipes

Description
To align ourselves with the roadmap we need the following construction recipies / graphs:
Things marked with an * are not / likely aren't in the game yet

[ ] Fake Walls
[x] Air Alarm & Fire Alarm
[ ] Security Camera*
[x] Light Fixture
[x] Windoor
[ ] Button
[ ] Reflectors #5635 *
[x] Airlock
[ ] Turret*
[ ] AI Core*
[x] Solar Panels
[x] Solar Tracker
[x] Disposals Chute
[ ] Disposals "exit"
[ ] Modular consoles*
[x] Railings
[ ] Sink - Peptide
[ ] Shower - Peptide

Furniture

[x] Chairs
[ ] Closet
[ ] Rack
[ ] Beds
[ ] Bookcase
[ ] Drying rack
[ ] Display
[x] Crates

Completed
Barricade

A few of these can't be implemented as construction recipes/graphs yet because they haven't been coded yet

im working on some of the furniture ones, i want to make a better wallmount system in the future as well

A few of these can't be implemented as construction recipes/graphs yet because they haven't been coded yet

Yeah I started putting a * beside ones that weren't in but I was super tired so left formatting for today.

im working on some of the furniture ones, i want to make a better wallmount system in the future as well

I'll avoid furniture for now and stick my name beside some above.

[#5018] contributes to this. Only just realised this old issue was still open. I'll continue work on it gradually as I know others have been too.

Closing as we have most of these now that matter and any new PRs for entities will include the graphs.


Revert reqwest, futures, tokio upgrade (revision 5502176e6)

Codecov Report

Merging #403 (43dc51f) into main (17b4f3e) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 43dc51f differs from pull request most recent head 15bc398. Consider uploading reports for the commit 15bc398 to get more accurate results

@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   66.34%   66.34%
=======================================
  Files         153      153
  Lines       14454    14454
  Branches     2863     2863
=======================================
  Hits         9590     9590
  Misses       2535     2535
  Partials     2329     2329

Flag
Coverage Δ

integration-aries-vcx
53.30% <ø> (ø)

unittests-agency-client
22.51% <ø> (ø)

unittests-aries-vcx
48.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b4f3e...15bc398. Read the comment docs.


Change the generation of 3D meshes to make it easier to visualize

connected to dalg24/cap-data#6

connected to dalg24/cap-data#6

[Current coverage][cc-pull] is 90.73%

Merging [#183][cc-pull] into [master][cc-base-branch] will decrease coverage by 2.20%

@@             master       #183   diff @@
==========================================
  Files            70         64     -6
  Lines          4219       3778   -441
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           3921       3428   -493
- Misses          298        350    +52
  Partials          0          0

6 files (not in diff) in python/test were deleted. more
3 files (not in diff) in python/source were modified. more

Misses +57
Hits -57

[][cc-pull]

Powered by Codecov. Last updated by [bb143eb...3f8493c][cc-compare]
[cc-base-branch]: https://codecov.io/gh/ORNL-CEES/Cap/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/ORNL-CEES/Cap/compare/bb143eb59d1a449ace967ddc705fd29e76244f24...3f8493c4be34c9c7521303494064a94b9d1804a1
[cc-pull]: https://codecov.io/gh/ORNL-CEES/Cap/pull/183?src=pr


Remove npm from dependencies

Having npm as dependency brings all alot of packages which has many vulnerabilities.
But vue-stepper package as itself doesn't have this vulnerabilities. I seeing in the code npm package didn't have that much of a use.

@Edujugon can we merge it? npm audit is very sad about this dependency.

bump


Publish as steam mod

please

Already is =p
https://steamcommunity.com/sharedfiles/filedetails/?id=1314910827
https://forums.bohemia.net/forums/topic/215148-breaching-charge/
How did you find this on GitHub if not through one of those places?

Through https://www.google.com/search?client=firefox-b-d&q="getdoor"+ace+arma apparently ^^


Attachment: Editing lecture-attachments is not possible in Safari due to an overlay

Describe the bug
When trying to edit an attachment for a lecture (not the lecture units but the lecture attachment), the entire screen is filled with the "is currently being edited..." overlay.
To Reproduce
Prerequisites:
1 Instructor
1 Student

Create a lecture in a course
Navigate to the "Attachments" of this lecture (not the attachment units!)
Create an attachment with a new file
Edit the attachment
Notice how the form fields are blocked by the overlay.

Expected behavior
The overlay should only be above the table, not the entire screen.
Screenshots
Chrome:

Safari:

Which version of Artemis are you seeing the problem on?
6.1.8
What browsers are you seeing the problem on?
Safari
Additional context
No response
Relevant log output
No response

Duplicate of #6195


[Feature Request] Default path for new console

It would be nice to have to have some kind of default path (folder) which will open if you open a new console (overrite the default console behavior).

Done.

I have alpha 35 (latest version right now). Is this included in that version?

No, it's coming in the Alpha 36.

I see it now - what should I set the value so that it would be my home folder (/home/tri) instead of /mnt/c/Users/tri? Setting it to either ~ or /home/tri causes the new tab to be hung.

This is set from the windows side when launching the shell - try setting it to the windows-mapped path of your home dir

E.g. C:\Users\Mark\AppData\Local\lxss\home\mark

First of all - Thanks a lot for this feature!
Currently there is a bug where the path is not taken into account when a new shell is opened via the shell-selector plugin. But I am not shure to whom the bug belongs (plugin dev or main application).

@Eugeny thanks that makes sense.
I tried the path you suggested, and it took me to a home folder of an Ubuntu I had installed before (but then subsequently uninstalled). I have since then installed the Ubuntu version on the Windows Store.
Do you know where the new home directory might be?

According to this post https://askubuntu.com/questions/759880/where-is-the-ubuntu-file-system-root-directory-in-windows-nt-subsystem-and-vice, it would be in something like
C:\Users\<username>\AppData\Local\Packages\CanonicalGroupLimited.UbuntuonWindows_79rhkp1fndgsc\LocalState\rootfs
However, the permission on that for me show 000 and owned by root.

Interestingly, if I set that path as above, a new tab will take me to the root directory (.i.e /). However, appending \home or \home\<username> does not actually take me to the home directory.


Error when running a local php container after the first time

When using a php container locally, there is an error thrown by entrypoint
mv: cannot stat '/usr/local/etc/php/conf.d/00-lagoon-php.ini.tpl': No such file or directory

I believe this is caused by a line in https://github.com/uselagoon/lagoon-images/blob/b49a5b6ce1b5347cefb9f63fa5eda453746cc193/images/php-fpm/entrypoints/70-php-config.sh#L22
mv "$PHP_INI_DIR/conf.d/00-lagoon-php.ini.tpl" "$PHP_INI_DIR/conf.d/00-lagoon-php.ini"

Because the file is moved, if the container is run a second time the file is not there to be moved by the entrypoint again.
Should this not be cp rather than mv?
./cc @seanhamlin - I believe you were working on the new php templating

@guptahemant and I are looking into the same problem as Hemant got this problem after latest build:
mv: cannot stat '/usr/local/etc/php/conf.d/00-lagoon-php.ini.tpl': No such file or directory
It seems that the commit https://github.com/uselagoon/lagoon-images/commit/6b3a30bd52aef7b32cb51998d17438ecd5d5e0f4 with Sean's change might be the cause of the problem.

Confirming that the issue affects both 23.5.0 and latest (23.6.0). The older version 23.4.0 is not affected.

good to know its not just my hackaday setup :D
I'm 90% sure changing the mv to cp would fix it - but I'd propose we wait for @seanhamlin to weigh in as he'll know the context of why it's done that way.
In the meantime @sonnykt  and @dalibor-matura - rebuilding the container works for my case as a work-around

oof, nice spot. I did not consider the event in which the entry points would need to be run multiple times. Sounds like a cp might be in order, and a comment to hopefully not trip the next soul up.

@tobybellwood
Do we know why CI did not pick this up? Can we add should restart step in one of the Leia tests?

yeah - we certainly can do - it just never crossed our minds that the entrypoint would re-run on an existing image - in Lagoon/Kubernetes it will only ever run on a fresh pull.

@tobybellwood
sorry for commenting on the closed issue. Should we expect a patched image to be released or wait for 23.7.0? thanks

Just published 23.7.0 🎉


chore: clean unused commands and packages in package.json

This pull request cleans up scripts and dependencies :

prepack command is the same as build
standard package are not in dependencies and then config and command related to it are not useful anymore
formdata-node is not used in the codebase

If I remember correctly prepack is used when the package is installed as a dependency to compile the TS to JS

Actually, the prepack command is implicitly used by npm publish.
I thought that in the workflow publishing the package, the yarn build command was run before yarn publish, in this case yarn prepack would have been useless.
Do you prefer to modify the workflow publishing the package to add the yarn build command before or keep the yarn prepare command ?

I would prefer keeping the alias, as it's very easy to forget to build when doing a manual publish (not that they should be done but nevertheless!)

@VaiTon done!


What tool?

What tool do you use instead of this?

My workflow has changed quite a lot but if it's a simple site then I use a either a Node stack with ExpressJS and Handlebars templates or a static site using Jekyll.


[BUG] UnobservedComponents throws error during predict() call, when wrapped under TransformedTargetForecaster and ForecastingPipeline

Describe the bug

Initially identified issue:

New version of sktime throws error for UnobservedComponents when wrapped under ForecastingGridSearchCV with TransformedTargetForecaster pipe.

Updated description:

From sktime v.0.11.1 onwards untill the current version of main, UnobservedComponents throws error during Predict method call when it is piped under TransformedTargetForecaster().
The same construct works with all the other models which I could test for example ARIMA, AutoETS etc. So the issue is how TransformedTargetForecaster calls predict and the cascading of the same method to UnobservedComponents class.
To Reproduce
The code example was taken from documentation of ForecastingGridSearchCV for advanced example. The only thing changed was calling UnobservedComponents instead of ExponentialSmoothing at the end of param_grid argument in gscv.

from sktime.datasets import load_shampoo_sales
from sktime.forecasting.exp_smoothing import ExponentialSmoothing
from sktime.forecasting.naive import NaiveForecaster
from sktime.forecasting.model_selection import ExpandingWindowSplitter
from sktime.forecasting.model_selection import ForecastingGridSearchCV
from sktime.forecasting.compose import TransformedTargetForecaster
from sktime.forecasting.theta import ThetaForecaster
from sktime.transformations.series.impute import Imputer
from sktime.forecasting.structural import UnobservedComponents

y = load_shampoo_sales()
fh = [1,2,3]
pipe = TransformedTargetForecaster(steps=[
    ("imputer", Imputer()),
    ("forecaster", UnobservedComponents())])
cv = ExpandingWindowSplitter(
    initial_window=24,
    step_length=12,
    start_with_window=True,
    fh=[1,2,3])
gscv = ForecastingGridSearchCV(
    forecaster=pipe,
    param_grid=[{
        "forecaster": [NaiveForecaster(sp=12)],
        "forecaster__strategy": ["drift", "last", "mean"],
    },
    {
        "imputer__method": ["mean", "drift"],
        "forecaster": [ThetaForecaster(sp=12)],
    },
    {
        "imputer__method": ["mean", "last"],
        "forecaster": [UnobservedComponents()],
        "forecaster__seasonal": [12],
    },
    ],
    cv=cv,
    n_jobs=-1)
gscv.fit(y)

y_pred = gscv.predict(fh)

Expected behavior

Additional context
Error report:
TypeError                                 Traceback (most recent call last)
~/work/chronos/chronos/pipeline/tests/test_pipeline.py in <module>
     37     cv=cv,
     38     n_jobs=-1)
---> 39 gscv.fit(y)
     40
     41 y_pred = gscv.predict(fh)

~/work/sktime/sktime/forecasting/base/_base.py in fit(self, y, X, fh)
    262         # we call the ordinary _fit if no looping/vectorization needed
    263         if not vectorization_needed:
--> 264             self._fit(y=y_inner, X=X_inner, fh=fh)
    265         else:
    266             # otherwise we call the vectorized version of fit

~/work/sktime/sktime/forecasting/model_selection/_tune.py in _fit(self, y, X, fh)
    279
    280         # Run grid-search cross-validation.
--> 281         results = self._run_search(evaluate_candidates)
    282
    283         results = pd.DataFrame(results)

~/work/sktime/sktime/forecasting/model_selection/_tune.py in _run_search(self, evaluate_candidates)
    487         """Search all candidates in param_grid."""
    488         _check_param_grid(self.param_grid)
--> 489         return evaluate_candidates(ParameterGrid(self.param_grid))
    490
    491     @classmethod

~/work/sktime/sktime/forecasting/model_selection/_tune.py in evaluate_candidates(candidate_params)
    266
    267             out = parallel(
--> 268                 delayed(_fit_and_score)(params) for params in candidate_params
    269             )
    270

~/opt/miniconda3/envs/chronos_dev2/lib/python3.7/site-packages/joblib/parallel.py in __call__(self, iterable)
   1054
   1055             with self._backend.retrieval_context():
-> 1056                 self.retrieve()
   1057             # Make sure that we get a last message telling us we are done
   1058             elapsed_time = time.time() - self._start_time

~/opt/miniconda3/envs/chronos_dev2/lib/python3.7/site-packages/joblib/parallel.py in retrieve(self)
    933             try:
    934                 if getattr(self._backend, 'supports_timeout', False):
--> 935                     self._output.extend(job.get(timeout=self.timeout))
    936                 else:
    937                     self._output.extend(job.get())

~/opt/miniconda3/envs/chronos_dev2/lib/python3.7/site-packages/joblib/_parallel_backends.py in wrap_future_result(future, timeout)
    540         AsyncResults.get from multiprocessing."""
    541         try:
--> 542             return future.result(timeout=timeout)
    543         except CfTimeoutError as e:
    544             raise TimeoutError from e

~/opt/miniconda3/envs/chronos_dev2/lib/python3.7/concurrent/futures/_base.py in result(self, timeout)
    433                 raise CancelledError()
    434             elif self._state == FINISHED:
--> 435                 return self.__get_result()
    436             else:
    437                 raise TimeoutError()

~/opt/miniconda3/envs/chronos_dev2/lib/python3.7/concurrent/futures/_base.py in __get_result(self)
    382     def __get_result(self):
    383         if self._exception:
--> 384             raise self._exception
    385         else:
    386             return self._result

TypeError: No valid mtype could be identified

Versions
System:
python: 3.7.13 (default, Mar 28 2022, 07:24:34)  [Clang 12.0.0 ]
executable: .../miniconda3/envs/chronos_dev2/bin/python
machine: Darwin-21.4.0-x86_64-i386-64bit
Python dependencies:
pip: 21.2.2
setuptools: 58.0.4
sklearn: 1.0.2
sktime: 0.11.3
statsmodels: 0.12.1
numpy: 1.21.5
scipy: 1.7.3
pandas: 1.3.5
matplotlib: 3.5.1
joblib: 1.1.0
numba: 0.55.1
pmdarima: 1.8.5
tsfresh: None

following minimal solution works on main WITHOUT TransformedTargetForecaster:
from sktime.datasets import load_shampoo_sales
from sktime.forecasting.exp_smoothing import ExponentialSmoothing
from sktime.forecasting.naive import NaiveForecaster
from sktime.forecasting.model_selection import ExpandingWindowSplitter, SlidingWindowSplitter
from sktime.forecasting.model_selection import ForecastingGridSearchCV
from sktime.forecasting.compose import TransformedTargetForecaster
from sktime.forecasting.theta import ThetaForecaster
from sktime.transformations.series.impute import Imputer
from sktime.forecasting.structural import UnobservedComponents

y = load_shampoo_sales()
fh = [1,2,3]
forecaster = UnobservedComponents()
cv = ExpandingWindowSplitter(
    initial_window=24,
    step_length=12,
    start_with_window=True,
    fh=[1,2,3])
gscv = ForecastingGridSearchCV(
    forecaster=forecaster,
    param_grid=
    {
        "transformed": [True, False],
    },
    cv=cv,
    n_jobs=-1)
gscv.fit(y)

y_pred = gscv.predict(fh)

Following minimal solution works not on main WITH TransformedTargetForecaster:

from sktime.datasets import load_shampoo_sales
from sktime.forecasting.exp_smoothing import ExponentialSmoothing
from sktime.forecasting.naive import NaiveForecaster
from sktime.forecasting.model_selection import ExpandingWindowSplitter, SlidingWindowSplitter
from sktime.forecasting.model_selection import ForecastingGridSearchCV
from sktime.forecasting.compose import TransformedTargetForecaster
from sktime.forecasting.theta import ThetaForecaster
from sktime.transformations.series.impute import Imputer
from sktime.forecasting.structural import UnobservedComponents

y = load_shampoo_sales()
fh = [1,2,3]
pipe = TransformedTargetForecaster(steps=[
    ("imputer", Imputer()),
    ("forecaster", UnobservedComponents())])
cv = ExpandingWindowSplitter(
    initial_window=24,
    step_length=12,
    start_with_window=True,
    fh=[1,2,3])
gscv = ForecastingGridSearchCV(
    forecaster=pipe,
    param_grid=
    {
        "forecaster__transformed": [True, False],
    },
    cv=cv,
    n_jobs=-1)
gscv.fit(y)

y_pred = gscv.predict(fh)

thanks @aiwalter for enhancement of bug description

@aiwalter
This works completely
y = load_shampoo_sales()
fh = [1,2,3]
pipe = TransformedTargetForecaster(steps=[
    ("imputer", Imputer()),
    ("forecaster", ThetaForecaster())])

pipe.fit(y)
pipe.predict(fh=fh)

Whereas this one only works until fit. So predict method is throwing error (which is pasted just below the code example)
y = load_shampoo_sales()
fh = [1,2,3]
pipe = TransformedTargetForecaster(steps=[
    ("imputer", Imputer()),
    ("forecaster", UnobservedComponents())])

pipe.fit(y)
# predict throws error as pasted below
pipe.predict(fh=fh)

error report:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
      6
      7 pipe.fit(y)
----> 8 pipe.predict(fh=fh)

~/work/sktime/sktime/forecasting/base/_base.py in predict(self, fh, X)
    327             self._y_mtype_last_seen,
    328             store=self._converter_store_y,
--> 329             store_behaviour="freeze",
    330         )
    331

~/work/sktime/sktime/datatypes/_convert.py in convert_to(obj, to_type, as_scitype, store, store_behaviour)
    239
    240     # now further narrow down as_scitype by inference from the obj
--> 241     from_type = infer_mtype(obj=obj, as_scitype=as_scitype)
    242     as_scitype = mtype_to_scitype(from_type)
    243

~/work/sktime/sktime/datatypes/_check.py in mtype(obj, as_scitype, exclude_mtypes)
    311
    312     if len(res) < 1:
--> 313         raise TypeError("No valid mtype could be identified")
    314
    315     return res[0]

TypeError: No valid mtype could be identified

same error with ForecastingPipeline

I improved the error message on mtype in this PR (would appreciate a review and potential approval) https://github.com/alan-turing-institute/sktime/pull/2606
with the purpose to understand why the check is failing, inside the pipeline.

so, two questions:

where is the pd.Index created?
why do the tests not catch this, they should catch output of non-conformant data types?

it's an empty pd.DataFrame when it reaches the convert_to the second time

Could it be that the UnobservedComponents predict output creates this index type when it returns the output?? Meaning modifying the _predict method of UnobservedComponents may be required additionally in Sktime side instead of simply calling it from statsmodel adaptors? I also noticed that UC also renames the predict output unlike other forecasters. It renames the output to "preds".

Actually the renaming of pred output by this UC models makes it also incompatible with ColumnwiseTransformer (CwT), which applies transformations and their inverse_transformations by the names of columns of in Y dataframe. So Y_train with name "Number of Air Passengers" is passed after predict as pd.Series(name="mean_preds") to inverse_transform method of CwT, which then throws error as "mean_preds" does not exist in columns.
@aiwalter FYI - a new bug but I will create a detailed issue later for that, unless it is clear to you from above example already.

Could it be that the UnobservedComponents predict output creates this index type when it returns the output?

The problem is an empty dataframe, not a wrong index type. Empty dataframes have the pd.Index type, apparently, which is why the check says that.
Suspicion: the problem is probably caused by the name that UnobservedComponents gives the series before it returns it.
This makes it break with a pd.DataFrame input:
y = pd.DataFrame(load_shampoo_sales())
fh = [1,2,3]

f = UnobservedComponents()

f.fit(y)
f.predict(fh=fh)

found the problem!
Combination of two issues:

unintuitive behaviour of pd.DataFrame constructor. When called as pd.DataFrame(my_series, columns=["col_name"]), this will produce an empty data frame if my_series has a name, otherwise a pd.DataFrame with column name "col_name"
UnobserveComponents._predict produces a non-conformant pd.Series as a return, in that it has a name (predicted_mean), as opposed to not having a name

I think we need to do two things:

immediate bugfix: fix the converter so it can deal with pd.Series to pd.DataFrame even when the series has a name
set up tests for the inner methods, whether they produce non-conformant returns. Currently, this is only tested for the outer predict, and only for certain scenarios.

PS @indinewton, did you know that instead of
pipe = TransformedTargetForecaster(
    steps=[
        ("imputer", Imputer()),
        ("forecaster", UnobservedComponents())
    ]
)

you can also write
pipe = Imputer() * UnobservedComponents()

since 0.11.3?
We should probably update the forecasting tutorial about this...

Yeah I noticed the new mul Dunder. Although I still have to explore it more. I also noticed that many base protocols like or have been also overwritten for some BaseForecasters.. but I will soon check in next days.

say, @indinewton, now that the conversion issue is fixed in #2607, it seems the UnobservedComponents forecaster always produces 0.0 for forecasts on the above test cases. Is that expected? Seems pretty odd.

it seems to produce zero in all cases where it previously broke.
But, the problem is not with the conversion, I tested that.
I would hence assume somewhere within UnobservedComponents there is a potential issue of similar kind, but it's a different bug.
@juanitorduz, can you help, perhaps?

@fkiraly yeah, in example above it should produce 0 as forecasts, because no parameters were given to initiate UC. And I just run the same using 0.11.0 version of sktime and it generated this
1994-01    0.0
1994-02    0.0
1994-03    0.0
Freq: M, Name: predicted_mean, dtype: float64

Note how the Name of column has been changed to "predicted_mean".

well, all good then if this is what it's supposed to do.
We are actually testing for consistency in test_structural, which I missed (kudos, @juanitorduz!), so I think we can close if/once the fix gets merged.

This "issue" (un-expected behaviour) of the pd.DataFrame constructor was a surprise for me as well 🙈 !

It seems so very unexpected.
Would it be worth raising an issue on pandas if that issue does not already exist?
It is the third time in my recollection, at least, that something broke due to that.
Because basically, it means you shouldn't be using the columns arg at all, if you might be potentially expecting to get a named argument.


Function UpdateTask is taking longer time (100ms or more) for POST TASK API

We have observed that the function updateTask is taking more time around 100ms and even more sometimes with the latest Netflix master code.
https://github.com/Netflix/conductor/blob/master/core/src/main/java/com/netflix/conductor/service/TaskServiceImpl.java#L135
Last code we had of Netflix/conductor was of Oct 2017.
Lately (Sep 2020), we have merged the latest master Of Netflix/conductor in our local master repository.
There is no change in setup or environment but the latest conductor code merged from Netflix master in our forked repo (https://github.com/CiscoM31/conductor/tree/master)
With New Code

Task Started @2021-01-08 13:41:43.406 and finshed @2021-01-08 13:41:43.716. Around 300ms

2021-01-08 13:41:43.406 DEBUG TaskServiceImpl:136 - Update Task: TaskResult{workflowInstanceId='6101a6fd-be51-42f1-a277-84bb029814de', taskId='3e6f31e0-8278-476c-87e6-130e00121703', reasonForIncompletion='null', callbackAfterSeconds=0, workerId='null', status=COMPLETED, outputData={}, outputMessage=null, logs=[], externalOutputPayloadStoragePath='null', subWorkflowId='null'} with callback time: 0
:
:
2021-01-08 13:41:43.716 DEBUG TaskServiceImpl:138 - Task: TaskResult{workflowInstanceId='6101a6fd-be51-42f1-a277-84bb029814de', taskId='3e6f31e0-8278-476c-87e6-130e00121703', reasonForIncompletion='null', callbackAfterSeconds=0, workerId='null', status=COMPLETED, outputData={}, outputMessage=null, logs=[], externalOutputPayloadStoragePath='null', subWorkflowId='null'} updated successfully with callback time: 0

With Old Code

Task Started @2021-01-08 13:41:43.406 and finshed @2021-01-08 13:41:43.716. Around 230ms

2021-01-08 14:38:55.018 DEBUG TaskServiceImpl:133 - Update Task: TaskResult{workflowInstanceId='5ff762b9-873c-4f41-80cb-cd6a8c7ea04c', taskId='9b825b5f-1f4f-459f-bb0e-fed8df71da59', reasonForIncompletion='null', callbackAfterSeconds=0, workerId='null', status=COMPLETED, outputData={}, outputMessage=null, logs=[], externalOutputPayloadStoragePath='null'} with callback time: 0
:
:
2021-01-08 14:38:55.246 DEBUG TaskServiceImpl:135 - Task: TaskResult{workflowInstanceId='5ff762b9-873c-4f41-80cb-cd6a8c7ea04c', taskId='9b825b5f-1f4f-459f-bb0e-fed8df71da59', reasonForIncompletion='null', callbackAfterSeconds=0, workerId='null', status=COMPLETED, outputData={}, outputMessage=null, logs=[], externalOutputPayloadStoragePath='null'} updated successfully with callback time: 0

Attaching the log excerpt from new and old code, if it helps. It is not the entire log but the excerpt of the log specifying the respective task.
newlog.txt
oldlog.txt

Attaching the log excerpt from new and old code, if it helps. It is not the entire log but the excerpt of the log specifying the respective task.
newlog.txt
oldlog.txt

fyi @manjurad

fyi @manjurad

Hey @techyragu, updateTask does a lot of things along with updating the task, such as cleaning up task queues and few other places that might store relevant task information, and calling decide on workflow which further evaluates and progresses the workflow etc. The structure and order of these might've also changed since Conductor 1.x in 2017.
We're curious to understand the impact of this increase in latency of updateTask endpoint. Also, how often have you seen this latency increase? do you have more metrics, such as averages and percentiles of this latency increase comparison?

Hey @techyragu, updateTask does a lot of things along with updating the task, such as cleaning up task queues and few other places that might store relevant task information, and calling decide on workflow which further evaluates and progresses the workflow etc. The structure and order of these might've also changed since Conductor 1.x in 2017.
We're curious to understand the impact of this increase in latency of updateTask endpoint. Also, how often have you seen this latency increase? do you have more metrics, such as averages and percentiles of this latency increase comparison?


fixed incidence values for many districts are faulty for 2022-01-16 and 2022-01-17

many values for 2022-01-16 and 2022-01-17 are faulty. The RKI shufted since Berlin-Mahrzahn-Hellersdorf the rows by 1. Berlin Mahrzahn-Hellersdorf has reported 0 new cases  for a few days so the incidence valu went to 0 for 16. and 17. maybe thats the reason!
I wrote a e-mail to the RKI and gave them a hint , dont know if they are reacting..........
Thats a data source error and only a hint here!

The RKI responded to my email and corrected the file!


jmxtrans log expiry configuration

Hi,
I tried posting on the Google group but there's been no activity in months so I'm hoping someone here can point me in the right direction. I'm trying and failing to get jmxtrans to expire old log files.
Version: jmxtrans-260-1.noarch (on CentOS7)
The logfile section of the config looks like this:
/etc/jmxtrans/wrapper.conf
wrapper.logfile.format=LPTM
wrapper.logfile.loglevel=INFO
wrapper.logfile.maxfiles=30
wrapper.logfile.maxsize=0
wrapper.logfile=/var/log/jmxtrans/jmxtrans.log
This creates a "jmxtrans.log" file and then rotates and compresses by date to produce archives with format "jmxtrans-20200909.log.gz". But those compressed logs never expire.
I've been looking here (https://wrapper.tanukisoftware.com/doc/english/properties.html) and trying various config combinations without success. Am I looking in the right place? And if I am, how do I find out which wrapper version I've got with my jmxtrans? Some of the config options in those docs were introduced in newer versions so I don't know which would apply to my install.
Thanks
Guy

260 is a really old release can you update.
Newer versions use Logback library to handle logs https://github.com/jmxtrans/jmxtrans/blob/master/jmxtrans/src/main/resources/logback.xml
You can override default logback configuration using -Dlogback.configurationFile=/path/to/logback.xml JVM property.
http://logback.qos.ch/documentation.html
https://gquintana.github.io/2019/05/17/Logging-configuration.html

260 is a really old release can you update.
Newer versions use Logback library to handle logs https://github.com/jmxtrans/jmxtrans/blob/master/jmxtrans/src/main/resources/logback.xml
You can override default logback configuration using -Dlogback.configurationFile=/path/to/logback.xml JVM property.
http://logback.qos.ch/documentation.html
https://gquintana.github.io/2019/05/17/Logging-configuration.html


Not able to remove views

I ve spent hours to remove items from parent as well as child list but somehow i m now able to do it. I m new to android programming so could you plz help me out with that. I didnt know where to contact you so i made an issue here.

@karanjatav You'll want to remove the objects from your list, and then call notifyChildRemoved or notifyParentRemoved. Please look at the sample application for an example of this in action (the horizontal sample has all the removes working).


using BasisMatrices in QuantEcon

I was trying to include some code that is using BasisMatrices to here, but it fails. The situation is the same as that described in "Circular modules and precompilation errors".
The code is to solve dynamic programs with continuous states by the collocation method using BasisMatrices: Preliminary notebook.
Is there any way to resolve this?

Very cool notebook! If/when we want to bring something like this into QuantEcon I'll have some tips to offer for how to make even better use of BasisMatrices potential performance.
If we do decide that we want to have BasisMatrices be a dependency of QuantEcon, then we will need to move the functions BasisMatrices currently imports from QuantEcon into BasisMatrices itself. We can then import these routines into QuantEcon so anyone who has been using them from the QuantEcon namespace can still do so.

@sglyon Thanks. Tips from the author of the library will be much appreciated.
According to this line, BasisMatrices imports gridmake, gridmake!, ckron, fix, fix! from QuantEcon, which are mostly used in quad.jl. As an alternative to moving these to BasisMatrices, would it make sense to setup a new package, like GridTools.jl?

I think that the "most Julian" thing to do would be to split them into a third package. But... that being said I still wonder if it would be worth the cost of maintaining another package. I wonder if there are any users of those routines outside QuantEcon and BasisMatrices. Any ideas or thoughts on that?

Alternatively, we could

create a package ContinuousDP.jl (or ContinuousDPs.jl?) which will be using BasisMatrices and QuantEcon.

Or

define a general ContinuousDP type in QuantEcon and create a package like DPCollocationSolve.jl (the collocation method is not the only way to solve a continuous state DP).

The short run solution should be 1, where we don't make any change to BasisMatrices and QuantEcon. What would be the medium run or long run solution?

That's totally true and is definitely in line with how much of the Julia package ecosystem works. I think it is a good short run solution.
WARNING: what follows is my very biased opinion, so discount appropriately.
If we make the argument to have continuous state dynamic programming in a separate package, then we could say something similar for DiscreteDP,  LQ/RBLQ, quad, MarkovChains, etc. My question is where to draw the line? Do we really want to have our packages become so modular?
One argument in favor of doing this is that each package can have the minimal set of dependencies needed to support that feature. This could be nice for people who only use the current QuantEcon for small pieces. We could definitely make QuantEcon the "umbrella" package that simply imports and re-exports all the functionality from the more modular sub packages.
On the other hand, to me this seems like an extra burden to be placed on the QuantEcon team. I have a hard enough time managing the dozen or so Julia packages I currently maintain, if we were to break quantecon into 6+ package that tension would increase.
I'm totally open to hearing from the rest of the team. Does anyone else have suggestions/ideas for how the future of QuantEcon.jl should be shaped?

@sglyon I share your concern. And my preference is to put as many routines into QuantEcon as possible; it will be best if I can get everything by one line using QuantEcon.
My point was:

We don't know yet if my code is worth adding into QuantEcon.
We cannot evaluate it unless we have working code.
The usual process is to put the code into QuantEcon and open a PR, but it doesn't work in this case because of the dependencies issue.
An option that doesn't bother anybody to resolve this issue is to create a (probably temporary) separate working package and discuss whether we want to include it to QuantEcon.

If more functions that use BasisMatrices are expected to come to QuantEcon in near future, then we might discuss resolving the issue (i.e., moving the relevant routines out of QuantEcon) right now.

Great, I'm glad you are on board.
As I mentioned above, I totally agree with your suggestion that the best plan in the short run for this material is to use a third package that depends on both QuantEcon and BasisMatrices. If/when we decide that QuantEcon is the right home for this code, we will definitely have to resolve the issue of circular dependencies.

+1 for a unified package, as QuantEcon.jl now stands.
@oyamad That's a great notebook!  Will you publish it somewhere?

There is working code now in https://github.com/QuantEcon/ContinuousDPs.jl.
Comments/suggestions are welcome.

It is now possible to register multiple package in (multiple subdirectories of) one repository. (One widely used package that makes use of this is https://github.com/JuliaPlots/Makie.jl.) I managed to split out some sub-packages of QuantEcon in my fork  https://github.com/greimel/QuantEconX.jl (I even registered smaller packages in a private package registry for some private project.)
I think it would be more "Julian" to have isolated functionality in individual packages. Maintainers of Julia packages tend to be very hesitant to take additional dependencies, so they are unlikely to use MarkovChains or DDPs from this package when this requires them to depend on all of QuantEcon's dependencies like NLOpt and Optim.
Having all the sub-packages in one repo would probably not really increase the cost of maintenance that @sglyon feared above.

@greimel this is a neat idea! Thanks for sharing. @oyamad (and others) do you feel like BasisMatrices belongs here?


Unresolved import nanoid::nanoid?

Hi, rust newbie here. I just created a new project to try out nanoid, but it says error[E0432]: unresolved import 'nanoid::nanoid'.
Cargo.toml:
[package]
name = "nanoid_test"
version = "0.1.0"
authors = ["Exr0n<EMAIL_ADDRESS>edition = "2018"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
nanoid = "0.1.3"

src/main.rs:
extern crate nanoid;
use nanoid::nanoid;

fn main() {
    println!("Hello, world!");
}

$ cargo run --verbose:
       Fresh libc v0.2.69
       Fresh rand v0.4.6
       Fresh nanoid v0.1.3
   Compiling nanoid_test v0.1.0 (/Users/exr0n/Desktop/snap/nanoid_test)
     Running `rustc --crate-name nanoid_test --edition=2018 src/main.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type bin --emit=dep-info,link -C debuginfo=2 -C metadata=e6ce498e3c0aac20 -C extra-filename=-e6ce498e3c0aac20 --out-dir /Users/exr0n/Desktop/snap/nanoid_test/target/debug/deps -C incremental=/Users/exr0n/Desktop/snap/nanoid_test/target/debug/incremental -L dependency=/Users/exr0n/Desktop/snap/nanoid_test/target/debug/deps --extern nanoid=/Users/exr0n/Desktop/snap/nanoid_test/target/debug/deps/libnanoid-8c29b7d0393c4491.rlib`
error[E0432]: unresolved import `nanoid::nanoid`
 --> src/main.rs:2:5
  |
2 | use nanoid::nanoid;
  |     ^^^^^^^^^^^^^^ no `nanoid` in the root

error: aborting due to previous error

For more information about this error, try `rustc --explain E0432`.
error: could not compile `nanoid_test`.

Caused by:
  process didn't exit successfully: `rustc --crate-name nanoid_test --edition=2018 src/main.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type bin --emit=dep-info,link -C debuginfo=2 -C metadata=e6ce498e3c0aac20 -C extra-filename=-e6ce498e3c0aac20 --out-dir /Users/exr0n/Desktop/snap/nanoid_test/target/debug/deps -C incremental=/Users/exr0n/Desktop/snap/nanoid_test/target/debug/incremental -L dependency=/Users/exr0n/Desktop/snap/nanoid_test/target/debug/deps --extern nanoid=/Users/exr0n/Desktop/snap/nanoid_test/target/debug/deps/libnanoid-8c29b7d0393c4491.rlib` (exit code: 1)

It seems like rustc knows where to find the nanoid crate, but for some reason can't use it while compiling? I can use other crates like chrono fine, so I have no clue what's going on.

Hi. Thank you for using my package, it's a pleasure.
You're using an old version of the project. To make it work, replace nanoid = "0.3.0" in Cargo.toml with nanoid = "0.3.0"

Sorry, I don't understand what the difference between nanoid = "0.3.0" and nanoid = "0.3.0" are?

Oh, I'm sorry. Meaning 'nanoid = "0.1.3" ' by 'nanoid = "0.3.0"`

Yup, I just caught that as well. It seems to work now.
I got confused because it says to use "0.1.3" on docs.rs. Thanks for clearing it up!

Yes, you are right.
Need to update here:
https://github.com/nikolay-govorov/nanoid/blob/30ff68b1307129b2e3e1e98ef9b8146c544d5d91/src/lib.rs#L11


DenseNet , ResNet , WRN models

Hi,
Thank you so much for giving us new data augmentation technique. I am bit confused, when I explore your models folder.
My main question is, are you training your ImageNet models with Pre-trained weights? It seems, you don't use pre-trained but you are building your own models and training without using "imagenet" weights.. Please, correct me If I am wrong here..
Secondly, the context of the first question is in the second question about baseline accuracies. Are you getting the baseline accuracies without "Imagenet" weights?
Any guideline to use FMix in keras?
Thank you!

Hi,
Thanks for the issue :)

You are correct that we don't use ImageNet weights, all of the models we used were trained from scratch (random initialisation)
The baseline results were also trained from scratch, but used standard augmentations found in datasets/datasets.py
We don't currently have a guide for FMix on keras but will take a look at adding one

Hope that helps!

Hi,
Thanks for the issue :)

You are correct that we don't use ImageNet weights, all of the models we used were trained from scratch (random initialisation)
The baseline results were also trained from scratch, but used standard augmentations found in datasets/datasets.py
We don't currently have a guide for FMix on keras but will take a look at adding one

Hope that helps!

Thank you man, it helped a lot. I was in depression while figuring out my questions!!!
Thank you again🙂

Thank you man, it helped a lot. I was in depression while figuring out my questions!!!
Thank you again🙂

Hi @ethanwharris ,
Could you please tell me what input image sizes you for fashion-mnist you used in your experiments?  I can't find in your paper. Default is 28 by 28 as you know but what size you kept in your experiments?  It would be a great help.. thank you!
Regards,
Aslam

Hi @ethanwharris ,
If I am not wrong, you are using 28 fashion-mnist images size in your experiments.

Hi @shuaibaslam2019, sorry for the delayed reply. Yes, we use 28 x 28 for Fashion-MNIST. It's worth mentioning that I think the Fashion-MNIST version we used is older than what you get with torchvision. You can find a Dataset that will load the older version here: https://github.com/ecs-vlc/FMix/blob/master/datasets/fashion.py

@shuaibaslam2019 I've played with fmix, cutmix, mixup with keras sequence generator, notebook here, you may find it as a guide starter in keras.


Fixes to git commands hardening.

I tested the current release, and it breaks at update time and for changelog generation.
The issue is that you need to be in the git_dir for git to work correctly for submodules, but that you cannot move to the worktree when cloning (because it does not exist yet).
The changelog was broken because make_git_command was not available in that script.
I moved one function around and exported it.
I have now tested my changes within and outside vcsh (GIT_DIR set) for the following operations:

[X] init (clone)
[X] update
[ ] plugin removal
[X] changelog
[X] log (error reporting)

My apologizes for not having properly tested my previous patches.

Thanks, I just haven't gotten around to it yet. Apologies.

No problem :-)


VM creation failed

What happened:
Unable to create VMI
What you expected to happen:
VM creation should happen normally
How to reproduce it (as minimally and precisely as possible):
kubectl apply -f vm1.yaml
Errort:
Error from server (InternalError): error when creating "vm1.yaml": Internal error occurred: failed calling webhook "virtualmachineinstances-mutator.kubevirt.io": failed to call webhook: Post "https://virt-api.kubevirt.svc:443/virtualmachineinstances-mutate?timeout=10s": x509: certificate signed by unknown authority
Environment:

KubeVirt version (use virtctl version): v0.59.0
Kubernetes version (use kubectl version): v1.23.16
VM or VMI specifications:
============================================================
metadata:
name: vm1
apiVersion: kubevirt.io/v1alpha3
kind: VirtualMachineInstance
spec:
domain:
resources:
requests:
memory: 30Gi
cpu: 20
devices:
disks:
- name: containerdisk
disk: {}
- name: cloudinitdisk
disk:
bus: virtio
- name: rootdisk
disk:
bus: virtio
interfaces:
- name: default
masquerade: {}
networks:

name: default
pod: {}
volumes:
name: containerdisk
containerDisk:
image: vmidisks/opensuse15:latest
imagePullPolicy: IfNotPresent
cloudInitNoCloud:
userData: |-
#cloud-config
chpasswd:
expire: false
password: password
user: test
name: cloudinitdisk
name: rootdisk
hostDisk:
capacity: 40Gi
path: /tmp/data/disk.img
type: DiskOrCreate
================================================================

Cloud provider or hardware configuration: N/A
OS (e.g. from /etc/os-release):  Ubuntu 22.04 LTS
Kernel (e.g. uname -a): 5.15.0-60-generic
Install tools: N/A
Others: N/A

These kinds of issues usually are transient. This might become an issue if the problem persists.


Tests: Mark skipped tests as pending (with reason)

Skip examples that don't work on non-macOS platforms instead of filtering them (which marks and reports them as pending). also offer reasons for skipping.
(Implementation details via discussion at http://groups.google.com/forum/#!topic/rspec/5qeKQr_7G7k)
Gives output for Ubuntu:

[17:45:21]: ▸ 4704 examples, 0 failures, 175 pending

No change in test output on macOS of course, so a bit hard to review. Please just note that it doesn't break macOS and everything is fine ;)

Technically this would be possible with e.g. rubocop or any other process that scans all the files I think.
But in my opinion this currently is not a thing we have to care too much about as a) this PR itself introduces the concept of skipping via example/group metadata into the project, and b) the override is limited to non-macOS platforms.
If one would add a test into a rspec file that is affected by this override, and define it as skip:false, they would hopefully notice that the test is not executed but continues to be listed as "pending" (which indicates that it is still skipped). A solution then would be to extract that one test e.g. into a group that has is not skipped and has the same before(:all).
If we really feel this "magic" solution is to intransparent, I had a solution that explicitly added a "skip" to the  before(:all) of that one test (only for non-macOS). I replaced with this fancy version as this is more general. (Again, not really relevant as this concerns just one test file at the moment, but I felt it was better not to have the explicit "skip" in the before(:all) as this could be forgotten when removing the tags from the examples/group and then could cause unexpected results as the skipping of the before(:all) is not reported as the skipping of the test example (as pending test)).
before(:all) really are a strange thing in RSpec, as Myron said in the mailing list thread.

Hmm, interesting. Well it is documented, so it should probably be ok.
My concern wasn't with how this is used right now, but now that it has been introduced we have to expect people to possibly use this technique, and then it's easy to forget during review and we'll have strange errors or flaky tests later on. But I think you're right, it's probably fine as is.
I like the solution overall (that we have separate groups that are disabled because of dependencies on certain tools), but before(:all) really seems like it should be avoided completely in the future. I suspect most specs would probably continue working if we replaced before(:all) with a before(:each) since they mostly just set up expects or the variables anyway

Yes, I though about that as well. But running the same setup code e.g. >20 times (multiplied by the many hundred test files we have) instead of just once probably could have a pretty hefty performance impact, so again I chose to keep it the way it is until we notice any real benefit.
(I am not sure we will keep this "skipping" mechanism for the long term anyway, as #windows will work towards fixing this stuff in the actual code being run somehow. If we are really successful, we can just rip it out again.)
(Also: Each newly added test that uses one of these tags to skip tests will have to be looked at at least twice as this really shouldn't be the normal case.)


Apply Filter Feature to the front-end

How to demo

The user can apply multiple conditions filter into the recipe.

Note

Use the filter_recipe method in the GetDataProxy class to perform filtering.
Use the FilterParam class to contain the parameters used in the filter_recipe method.

Done


CM-35959 - Make CWE and CVE clickable on violation cards

also fixed state resetting
DEMO:

i had a plan to update this branch after merging the prev PR :)


Daily stand-up meeting.

Here will be the updates and notes of our stand-up meetings.

We should start sprint planning as a team, what we expect in the last of the day:

complete user stories issues
write technical issues
DB schema
create file structure to keep work tomorrow

I wrote Readme file and created tables in sql file
i will start with landing page

today I will be finishing the configuration for eslint and travis and building heroku databse . If I finish these I will start working on the pledge component in home page.

I will complete the insert data to the database.
I will start with the category component in the dashboard page.

Yesterday i started work with landing page, I didn't finish it so i will continue today.
and i should start with Action-category component

Yesterday I discuss with my team the database structure schema and we decide to add new three more tables, then I moved to decide the time estimate and the priority for the whole project after that I started working on footer nav component

Today I worked on category component on the dashboard page, get data from the database using the query, push data to another page and make some style to this component.
I will work to show the number of completed pledges.

Today we discussed that the style must be responsive so im refactoring it to be responsive. after I finish I will move to work on context API to get the shared data between user pledges a
page and the pledge page with Yaqoot.

Yesterday I complete Category component with all its queries.

Today I work on the category component to fix bugs, and I start with style.

15/10/2019
i still working in Pledge page to receive multiple queries

14-16/10/2019

done with the home page styling
refactor travis configurations and fix it
working with @yaqootturman on the context api we studied and understand it then applied it to the code but still not done with it yet

14-16/10/2019

done BackButton shared component design and functionality.
confirmation page almost has done(responsive,front-end, back-end) still need pledge page props
for pledge related title.
congratulations page almost has done (front-end,back-end) still need pledge page props and some issue in the responsive style.

I start with style and try to make it responsive as I can.
Make some changes in the structure of Html tags to make it suitable.

17-20 /10/2019

Done the confirmation page
Done the  congratulations page
start working on the information page to be done

20-21/10/2019

designed the home page when there is no user pledges already
deleted the context api and used the axios in the needed components instead
I will pair with @DuaaH to work on the category pledges page  to get the data from the category page

I complete the dashboard page.

I added two categories to this page

Today I want to complete category pledge page with @RandInaim

Yesterday i worked some Pledge Page functionality to make or cancel the pledge
today i will work style of same page

yesterday I have done the information page in responsive design then I discuss with my team the confirmation page and we figured that if the user backward from the congratulation page he could add the same pledge again so I add a new query to check if the user confirms this pledge or not.

22/10/2019

working on the delete pledge confirmation page
then I will pair with @yaqootturman to merge it with the pledge page

22/10/2019

I complete the category pledges page and style it responsive.

I want to fill data on the database.

I will work with @Muniralsharif  on suggestions Pledges.

still working in Pledge page in 4 issues:

send data to confirm page
styling
delete context API
display text from the database as a split paragraph


[Request for Comments] How should the MRTK v3 preview be released?

Mechanically, it has been determined that MRTK v3 will be released via the Mixed Reality Feature Tool and the source code will be available on this repository.
We've been discussing internally whether it's better to

Release the core of MRTK v3 sooner so people can start using it and giving us feedback
Wait until we're ready to release all of our packages at once.

Which do you prefer and why?

Option 1. The earlier the better.

Also voting option 1.

Option 1

Option 2 unless the "sooner" means months. Reasons:

more areas targeted by feedback
Less effort for separating what goes into the initial release
More contributions

Option 2 for me because I'd rather use something stable

Definitely Option 1.   But also offering "previews" that people can opt in to for additional packages.

Option 1 -- whatever option gets us the "half-baked" code sooner, so we can be helpful as a community to make an even better MRTK together :)

Option 1

Option 1 - It lets us get more stable baseline (because some core packages will be complete) and build on top of that stable core with partially complete extras

Option 1 since otherwise you will never complete and you will likely have breaking changes in terms of feature parity anyways.

Option 1.
We will be able to provide a lot of feedback early, so wouldn't that make it possible to offer a STABLE Core Package?

+1 for option 1.

 This is why I'm not using the latest version of Unity. I can wait a few months or even a year if needed.


[KYUUBI #5308] Ensure release using Java 8

Why are the changes needed?

Avoid releasing new version with incorrect java version.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Was this patch authored or co-authored using generative AI tooling?

Also cc @cfmcgrady @cxzl25

Codecov Report

Merging #5308 (8bf3c13) into master (6061a05) will not change coverage.
Report is 41 commits behind head on master.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #5308   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         590     590
  Lines       33344   33372   +28
  Branches     4403    4415   +12
======================================
- Misses      33344   33372   +28

see 15 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merged to master/1.8/1.7


Feature new api

I added support for the new api. Tested it with a test script I developed to retrieve data and operate the switches.

Your right, it was just for PEP8.  I cleaned that up and other issues that the PEP8 linter raised.


Italian Partner Site in footer results in error

Short Description of Bug
HTTPS links via the language menu at the bottom of the screen are bringing up net cert errors.
Steps I should follow to reproduce
go to https://www.lonelyplanet.com/ scroll to the language options at the bottom, choose Italiano
What are the results you expect?
NET::ERR_CERT_AUTHORITY_INVALID error
Additional Info
I spoke to Mike K about this, wondering if it had to do with the recent https transition. Apparently, this this link is not specifying https.

He suggested a front end see if there is a script redireting to https://{selected_value}
Link to original Bug Report.

 HTTPS links via the language menu at the bottom of the screen are bringing up net cert errors.

re "see if there is a script redireting to https://{selected_value}": yes, I can confirm this:  https://github.com/lonelyplanet/rizzo-next/blob/c554c38985de44b9afb828dd624dc7dcc58d1e83/src/components/footer/footer_component.js#L14

re "wondering if it had to do with the recent https transition": yes, it's related (https://github.com/lonelyplanet/rizzo-next/commit/044e9464aa7bbd4c509e99ad7cfe31cb313db252)

I can just change that redirect back to http and test - it should work I believe.

hey @laserchicken more info just came in on this one (I'll adjust the original issue above). Looks like more than Italian site is affected, and I didn't catch it..that's my mistake.
The Germans and French site have an https version that's working just fine, but these are also throwing errors:
-India - Seb to reach out to Indian
-Italy - International Licensing Team to manage
-Russia - International Licensing Team to manage
-Brazil (Portuguese) - International Licensing Team to manage
-Czech - International Licensing Team to manage
If you change the redirect back to http, would there be any negative consequences if and when these sites transition over to https?
Secondly, @mkunkel, Seb said that in this context and timeframe SEO hit would be minimal. So no worries there. And we will work to get the others up to https (as much as we can).

I don't think there will be any negative consequence - if they transition they should just force https by redirecting http->https. @chrissysievers

Do you want me to update it @chrissysievers?

Yes, please.


GitHub Action Cache

Configure appropriate GitHub actions to use a cache.

I would like to do this one


Missing news article bug

Issue description:
Any news article that does not exist, would show a page like this:

It would be nice if it can redirect to 404 page, if data does not exist. Or just say that content does not exist.
URL to the web page:
https://dev.redotengine.org/news/sasppds

#175 fixed with 404page. As it is catching an error.

Found this is not fixed in dev site. I am going to fix this.

#177


Replace option does not work

E.g replacing a file from the config archive doesn't work. You have to remove the file first then add it.

Fixed in commit 0105448e1fb4e37c86d7b65a3e670fe512519fb0


Upload iOS simulator builds to Distribute

My project should support all available screen resolutions for iOS. And quality engineer should test that. So idea is to use simulator for UI testing to have appropriate test coverage.
So I need to create simulator builds with AppCenter to omit manual builds and proceed with CI builds workflows and pipelines.

Hi @anton-kolesnyk, we have the option to do that with real devices in App Center Test. But if you want to do it with simulators, I think your best option is to run a post-build script that starts simulators. Maybe Nilofer can help?

Hi @Oddj0b, actually post build script I think will be too late because simulator requires to build whole project for simulator and binary application file will be quite different in comparison with ipa-files that prepared for real device. And unfortunately I do not see such option to build for simulator in AppCenter at all.

@anton-kolesnyk what UI testing framework are you using?

@King-of-Spades, I don't use any right now.

@anton-kolesnyk if you don't sign your build it will work for simulators.

@anton-kolesnyk Did you manage to find a solution or should we have a call?

@Oddj0b yes I've utilized Asure DevOps. It takes more time for configuration but I can build whatever I want there :)
It would be great to have .app packeges distribution on AppCenter, to have iPhone and Simulator builds in one place. but that is not stopper for me right now.

The addition of iOS simulator as a package distribution option in AppCenter is important to my team. We use AppCenter primarily for the distribution functionality and have .app packages for iOS we need to upload.

@anton-kolesnyk @marikavertzonis It seems more of a question for my colleague @botatoes at our Distribute service than for me in Test. Correct me if I'm wrong.

Sure. The title of this issue doesn't discriminate. For me, I'd want to be able to upload iOS simulator build for distribution.

Reading though this again I wonder if it might have been misclassified as relating to Test from the beginning.

I have the same issue
When do upload my .ipa file to run in simulators
Example: DTPlatformName: iphonesimulator and DTSDKName: iphonesimulator13.4
Return error: Release:
A problem occured while extracting your app (Correlation ID: xxx)
If try publish to pipeline AppCenterDistribute
Return: ##[error]"{"error":"Error: Missing required params from body: version, build_version, unique_identifier, minimum_os_version, Service id: xxx"}"

@hewerthon Normally, an .IPA file would not be compatible with iOS simulators, because it is generated to run on iOS devices.
iOS simulator builds are NOT cross-compatible with iOS device builds; as far as I know there is no trivial way to convert one to the other. I have seen a few cases before where users have attempted to package simulator or device builds like their counterpart by renaming & rearranging the files...this doesn't bypass the limitation but can trigger very odd behaviors & symptoms.
At it's core, the processor architectures of an iOS simulator build and an iOS device build aren't the same; so as far as I know the only way to "change" between them would be to just compile a new build for the different target.
The limitation is pretty specific to iOS. Android by contrast typically allows you to run the exact same APK on it's emulators as you can run on real devices; assuming there aren't any other compatibility differences introduced between them.

Hello @King-of-Spades
Yes, for do build to the simulator, I use this script as an example
1- Export build to .xcarchive
2- Create folder Payload and move .app file to into
3- Compress this folder and rename to .ipa file
4- Do upload to App Center
Example script:
/Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -sdk iphonesimulator archive ARCHS=x86_64 VALID_ARCHS=x86_64 -workspace i9.xcworkspace -scheme "QA" -configuration "Release (QA)" -archivePath ~/IOSBuild/App.xcarchive || die "build failed"

cd ~/IOSBuild/App.xcarchive/Products/Applications

mkdir Payload

mv "QA.app" ~/IOSBuild/App.xcarchive/Products/Applications/Payload/

zip -r "QA.ipa" Payload

OBS: .app and .ipa file run in all simulators.
But any try do upload to App Center return error
I try create Apps projects custom for iOS, for MacOS but App Center does not accept my .app ou .ipa file to the simulator.

@hewerthon custom build logic can be applied via build scripts; but such customizations are not supported by App Center Build: https://docs.microsoft.com/en-us/appcenter/build/custom/scripts/.
This means that custom build script logic isn't QA'd or normally eligible for bugfixes by our team. The only exception would be if something with handling the script itself was fundamentally broken...say a bug was introduced that caused standard echo or eval commands to be ignored.

I tried to create a new app center app, for Custom OS, as it lets me upload a zip of my .app, but it gives me an error when I tried to upload A problem occured while extracting your app. (Correlation ID: 92fd5d16-cd99-49ac-a65e-833e0ce9f428).
Has anyone find a way to upload .app builds to appcenter?

Sure. The title of this issue doesn't discriminate. For me, I'd want to be able to upload iOS simulator build for distribution.

We also need that feature


bad ttl files generated

xmltoldmigration has output the following artifacts
./works/b7/ID.ttl
works_b7_ID.ttl.zip
./works/b8/id.ttl
works_b8_id.ttl.zip

it doesn't seem to do that anymore


Milestone 4a - Controllers specs

add tests to controllers

@julie-ify  Thank you for the review. I made the required changes but why do you suggest not writing tests for controllers?

@julie-ify Thank you for the review. I made the required changes but why do you suggest not writing tests for controllers?

Hi @t-bello7 consider that from Rails 5 upwards controller specs are no longer recommended, per the official release doc for Rspec. Rather the team recommends request specs instead.
If you take a look at the document above you would see that:

For new Rails apps: we don't recommend adding the rails-controller-testing gem to your application. The official recommendation of the Rails team and the RSpec core team is to write request specs instead. Request specs allow you to focus on a single controller action, but unlike controller tests involve the router, the middleware stack, and both rack requests and responses. This adds realism to the test that you are writing and helps avoid many of the issues that are common in controller specs.

type: :controller seems to be more of a Rails 3 and 4 convention but from Rails 5 type: :request tests have been greatly improved and so recommended. Basically, controller specs are somewhat "obsolete" (for lack of a better word)


Face Verification and Face Identification:

Is your feature request related to a problem? Please describe.
ace verification aims to verify whether a face matches a particular identity, while face identification involves identifying an unknown face by comparing it against a set of known identities. Advanced systems may employ both methods for different scenarios and requirements.
Assign this issue to mew under GSSOC'23

Hello! can you assign this issue to me . i would like add the code of face recognition based on certain emotion .

hello, please assign this issue to me under gssoc'24,I am interested to work on this

Hello mam, please assign this issue to me under GSSOC'24, I can do it.

Allow me to work on this issue for GSSOC 2024. I have worked on similar project before and can do this . Thank You


My starting map not there

Have downloaded image. Am working on a trace.

WIP

Believe that some terraforming has been done on the island in the image provided, but am tracing faithfully to the image, due to unfamiliarity with the default status.


Fields fix

When using fields with Elasticsearch fields come back as lists. However
Spark unpacks the list when fields along with elasticsearch-hadoop. This
modifes DummyRDD to match that behavior

I already fixed this apparently


Create concise requirement and env files

This issue is for creating concise versions of requirements.txt and environment.yml for wikirepo. It would be great if these files were created by hand with specific version numbers or generated in a way so that sub-dependencies don't always need to be updated.
As of now both files are being created with the following commands in the package's conda virtual environment:
pip list --format=freeze > requirements.txt
conda env export --no-builds | grep -v "^prefix: " > environment.yml

wikirepo and other obviously unneeded packages are then removed from these files before being uploaded.
Any insights or help would be much appreciated!

Hi @djKooks, posting this in the issue rather than the PR :) Thanks for your help with this!
For setup.py, would your basic suggestion on this be to pick the package that has the most requirements (pandas in this case that covers scipy, numpy, etc), and then build around it with what it doesn't include?
Also, could you give a quick explanation of why things like pylint, pyOpenSSL, packaging, and certifi are needed in the requirements files? Do you just know to leave these in, or was it a bit of trial and error to see what'd work? Testing packages make sense, but the others I'm not sure on. And why is numpy still in the requirements (as it's covered by pandas in setup.py)?

@andrewtavis hello~sorry for late reply...

For setup.py, would your basic suggestion on this be to pick the package that has the most requirements (pandas in this case that covers scipy, numpy, etc), and then build around it with what it doesn't include?

Yes. Also I've change setup.py to get requirements from requirements.txt.

pylint, pyOpenSSL, packaging, and certifi are needed in the requirements files?

In my opinion pylint and packaging can be used for the project(for linting, packaging in the future). If you think this is useless(or willing to use other module such as black or yapf for linting...) you could remove it in the future.

And why is numpy still in the requirements

Seems you're correct, but because there are parts using 'numpy' in your code, will be better to check if it works well without this...(didn't tried yet)

Also, I think maybe we could just remove 'environment.yml', cause AFAIK conda can be used with requirements.txt.

@djKooks, no worries at all for a late reply :)
I accepted the most recent changes to setup.py. Very much appreciate them!
Let's leave pylint and packaging in then, but the codestyle we're using is black, so should that be added? I'm fine with leaving numpy in there as well, as maybe there could be an issue with the documentation if it's not explicitly in there. Things to worry about later :)
I guess let's also just leave environment.yml for folks, as one benefit is that that will give people an environment that has conda packages installed in that manner and the rest with pip - for if a future contributor wants to use conda to manage their version of it.
Thanks again, and by all means let me know if you have further suggestions!

Let me know on if black should be added, and then I'lll give it a close based on that :)

@andrewtavis because linting tools(black, pylint, yapf) are doing similar things, so you could just decide which one to use.

Ok, great. I'll swap in black and close this then :)
My best for now!


A.06.IR86.layer.abstract

This issue has been extracted from the issue list on:https://ies-svn.jrc.ec.europa.eu/issues/2685
Comment
Test method only verifies whether abstract is a non-empty character string. There is no check to validate that the language presented is the correct one.
Proposed Change
Evaluate and update test method

Merge ATS for WMS and WMTS subelements that have identical requirements into single ATS, indicating to implementors that they can reuse ATS and ETS.
Valid for:

Layer. style
Layer legend
Layer BBOX
Layer abstract
Layer title
Layer name id
Layer metadata ref
Layer image format
Layer language param


Update alarm.dart

Fix Exception 'Alarm id cannot be set smaller than Int min value (-2147483648). Provided: ${alarmSettings.id}'

This should resolve the following issue https://github.com/gdelataillade/alarm/issues/146


Removed newline from end if bare report and no vulnerabilities

Pull request resolving this issue.
Issue 158: safety check --bare` should not produce output when no vulnerabilities are found
Please share what else need to be done for this to be accepted.
Found no contribution guide.

Thanks for the fix @chowmean.  I didn't know about the nl option to secho so that made it very easy.
I'm the bug reporter but not a participant in the project, so my review is informative only.
I did verify your patch works as shown here:
(venv) [bac@loiza safety]$ safety check --bare
(venv) [bac@loiza safety]$ pip install insecure-package
Collecting insecure-package
  Downloading https://files.pythonhosted.org/packages/54/05/62fbec685155cebbefe78fe2cdc87107b06d98260d7e491a9fc89105694d/insecure_package-0.1.0-py2.py3-none-any.whl
Installing collected packages: insecure-package
Successfully installed insecure-package-0.1.0
(venv) [bac@loiza safety]$ safety check --bare
insecure-package
(venv) [bac@loiza safety]$ python --version
Python 2.7.10

👍

@Jwomers please review it and tell me what else need to be done to get it merged.

Hi @chowmean @bac thank you for your patience! I will me merging later today :)


Removing and readding a 3D image layer is broken

🐛 Bug
Re-adding a previously removed 3D image layer results in the following error and a failure to add the layer:
ValueError: interpolation must be one of bessel, bicubic, bilinear, blackman, catrom, gaussian, hamming, hanning, hermite, kaiser, lanczos, mitchell, nearest, quadric, sinc, spline16, spline36

This only happens with 3D images. 2D images are fine.
As appropriate, git bisect tells me that it was a regression introduced by me, over at #3333 :P
To Reproduce
import napari
import numpy as np

v = napari.Viewer(ndisplay=3)
img = np.random.rand(100, 100, 100)
il = napari.layers.Image(img)
v.add_layer(il)
# everything is fine so far

v.layers.remove(il)
v.add_layer(il)
# error!

As appropriate, git bisect tells me that it was a regression introduced by me, over at #3333 :P

Haha, git bisect can be so cruel 😛

Is this related? https://github.com/napari/napari/issues/3551

just checked and #3551 is still present with the proposed fix at #3670

#3551 is not related. I explained why there!


Limit the number of parallel processes

Right now new processese are started in parallel without a limit. This can easily lead to OOM on the Github runners, we should be able to add a limiter on the number of processes running at the same time.
@devmotion I think you originally wrote this script, would you have a suggestion?

I was thinking of something like:
    return asyncmap(examples; ntasks=min(length(examples), max_procs)) do example
        return run(
            pipeline(
                `$(cmd) --startup-file="no" --project=$(example) $(LITERATE) $(basename(example)) $(examples_basedir) $(PKG_DIR) $(EXAMPLES_OUT) $(WEBSITE)`;
                stdin=devnull,
                stdout=devnull,
                stderr=stderr,
            );
            wait=true,
        )::Base.Process
    end


rs2_context error in rs_context.hpp while loading Unreal Engine 5.1

Required Info

Camera Model
D455

Firmware Version
<IP_ADDRESS>

Operating System & Version
Windows 11 Enterprise 22H2

Platform
PC

SDK Version
v2.53.1

Language
C++ and Unreal Engine 5.1.1 (I am not using Unreal Engine wrapper)

Segment
VR (Oculus Quest Pro)

Visual Studio Version
Visual Studio 2022 Enterprise 17.5.1

Issue Description
I am working on Unreal Engine 5 RealSense Android plugin for attaching my D455 to Quest Pro and getting RGB texture from it. My Windows SDK is v2.53.1 from release section.
My build.cs file is like this.
        if (UnrealTargetPlatform.Win64 == Target.Platform)
        {
            string Location_Realsense = "../Source/FF_RealSense/ThirdParty/Windows/include";
            PrivateIncludePaths.Add(Location_Realsense);

            PublicAdditionalLibraries.Add(Path.Combine(ModuleDirectory, "ThirdParty", "Windows", "libs", "realsense2.lib"));
            RuntimeDependencies.Add(Path.Combine(ModuleDirectory, "ThirdParty", "Windows", "libs", "realsense2.dll"));
            PublicDelayLoadDLLs.Add("realsense2.dll");
        }

        if (UnrealTargetPlatform.Android == Target.Platform)
        {
            PrivateDependencyModuleNames.Add("Launch");

            string Location_Realsense = "../Source/FF_RealSense/ThirdParty/Android/include";
            PrivateIncludePaths.Add(Location_Realsense);

            PublicAdditionalLibraries.Add(Path.Combine(ModuleDirectory, "ThirdParty", "Android", "libs", "libnative-lib.so"));
            PublicAdditionalLibraries.Add(Path.Combine(ModuleDirectory, "ThirdParty", "Android", "libs", "librealsense2.so"));

            AdditionalPropertiesForReceipt.Add("AndroidPlugin", Path.Combine(ModuleDirectory, "FF_RealSense_UPL_Android.xml"));
        }

My DLL delayed load module is like this
void FFF_RealSenseModule::StartupModule()
{
#ifdef _WIN64
	const FString BasePluginDir = IPluginManager::Get().FindPlugin("FF_REALSENSE")->GetBaseDir();
	const FString DLL_Path = FPaths::Combine(*BasePluginDir, TEXT("Source/FF_RealSense/ThirdParty/Windows/libs/realsense2.dll"));
	RealSenseHandle = FPlatformProcess::GetDllHandle(*DLL_Path);

	if (RealSenseHandle != nullptr)
	{
		UE_LOG(LogTemp, Log, TEXT("realsense2.dll loaded successfully!"));
	}

	else
	{
		UE_LOG(LogTemp, Fatal, TEXT("realsense2.dll failed to load!"));
	}
#endif
}

void FFF_RealSenseModule::ShutdownModule()
{
#ifdef _WIN64
	FPlatformProcess::FreeDllHandle(RealSenseHandle);
	RealSenseHandle = nullptr;
#endif
}

I am using #include "librealsense2/rs.hpp" and it pass Visual Studio compile but when Unreal Engine loading hits %45 (delayed load section) it gives crash like below.
Problem is not about packaging for Android. It is about Windows and I can't even start editor's itself.
Visual Studio Output
Exception thrown at 0x00007FFA06A9FE7C (KernelBase.dll) in UnrealEditor.exe: 0xC06D007E: Module not found (parameters: 0x0000003E84979550).
Unhandled exception at 0x00007FFA06A9FE7C (KernelBase.dll) in UnrealEditor.exe: 0xC06D007E: Module not found (parameters: 0x0000003E84979550).

Is there any suggestion for that ?
Currently Oculus Quest devices don't allow raw data camera access and I find libuvc really hard for what we will get.
So, I tought using Realsense would be easier and better approach. For example we can calculate distance, get point cloud at runtime and etc.
Plugin's repo.
https://github.com/FF-Projects-UE/FF_RealSense

Hi @ffreality  A project at the link below for connecting a RealSense D435i camera to the original Oculus Quest headset may be a helpful reference.  The RealSense Android wrapper's AAR should enable the camera to connect to an Android device if included in a project as the AAR provides device access permissions.
https://github.com/GeorgeAdamon/quest-realsense

Hi @ffreality A project at the link below for connecting a RealSense D435i camera to the original Oculus Quest headset may be a helpful reference. The RealSense Android wrapper's AAR should enable the camera to connect to an Android device (including the Android-based Quest headsets) if included in a project as the AAR provides device access permissions.
https://github.com/GeorgeAdamon/quest-realsense

But my problem is not about Android or Android package. First, I need to integrate Windows libraries to open Unreal Engine. This also allows me to test my functions. Problem is about Windows side because I can't even start editor on Windows.
If problem was about my Android integration, It would crash at Android package or on Quest's runtime.
So, that repo can't solve my problem.

Looking at your GitHub repository for your project, I did not see the RealSense x64 DLL files Intel.RealSense.dll and realsense2.dll included.  Usually when creating your own wrapper, these two dll files need to be included in the project in order for librealsense functions to be used.
On Windows, pre-made versions of these DLL files can be found by installing the full RealSense SDK on your Windows computer with the installer program Intel.RealSense.SDK-WIN10 and then going to the following folder location:
C: > Program Files (x86) > Intel RealSense SDK 2.0 > bin > x64
You can then copy the two DLL files from this folder and paste them into your project folder.
If you have not installed the full RealSense SDK on your computer, you can do so by visiting the link below and downloading and running Intel.RealSense.SDK-WIN10, which is in the 'Assets' file list at the bottom of the page.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.53.1

I saw Intel.RealSense.dll on Unity repo but latest Windows releases don't have that. There is only realsense2.dll in bin folder and realsense2.lib in lib folder.
I included both of them. You can find these in here.
https://github.com/FF-Projects-UE/FF_RealSense/tree/main/Source/FF_RealSense/ThirdParty/Windows
and there integrations are in build.cs.
These are screenshot of my SDK folder.

Also I rewrote my functions with
#include <librealsense2/rs.h>
#include <librealsense2/h/rs_pipeline.h>
#include <librealsense2/h/rs_frame.h>

and Unreal opened without problem.
If released sdk.exe should contain Intel.RealSense.dll, it is broken.

Looking at your GitHub repository for your project, I did not see the RealSense x64 DLL files Intel.RealSense.dll and realsense2.dll included. Usually when creating your own wrapper, these two dll files need to be included in the project in order for librealsense functions to be used.
On Windows, pre-made versions of these DLL files can be found by installing the full RealSense SDK on your Windows computer with the installer program Intel.RealSense.SDK-WIN10 and then going to the following folder location:
C: > Program Files (x86) > Intel RealSense SDK 2.0 > bin > x64
You can then copy the two DLL files from this folder and paste them into your project folder.
If you have not installed the full RealSense SDK on your computer, you can do so by visiting the link below and downloading and running Intel.RealSense.SDK-WIN10, which is in the 'Assets' file list at the bottom of the page.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.53.1

I saw Intel.RealSense.dll on Unity repo but latest Windows releases don't have that. There is only realsense2.dll in bin folder and realsense2.lib in lib folder.
I included both of them. You can find these in here.
https://github.com/FF-Projects-UE/FF_RealSense/tree/main/Source/FF_RealSense/ThirdParty/Windows
and there integrations are in build.cs.
These are screenshot of my SDK folder.

Also I rewrote my functions with
#include <librealsense2/rs.h>
#include <librealsense2/h/rs_pipeline.h>
#include <librealsense2/h/rs_frame.h>

and Unreal opened without problem.
If released sdk.exe should contain Intel.RealSense.dll, it is broken.

Looking at your GitHub repository for your project, I did not see the RealSense x64 DLL files Intel.RealSense.dll and realsense2.dll included. Usually when creating your own wrapper, these two dll files need to be included in the project in order for librealsense functions to be used.
On Windows, pre-made versions of these DLL files can be found by installing the full RealSense SDK on your Windows computer with the installer program Intel.RealSense.SDK-WIN10 and then going to the following folder location:
C: > Program Files (x86) > Intel RealSense SDK 2.0 > bin > x64
You can then copy the two DLL files from this folder and paste them into your project folder.
If you have not installed the full RealSense SDK on your computer, you can do so by visiting the link below and downloading and running Intel.RealSense.SDK-WIN10, which is in the 'Assets' file list at the bottom of the page.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.53.1

I saw Intel.RealSense.dll on Unity repo but latest Windows releases don't have that. There is only realsense2.dll in bin folder and realsense2.lib in lib folder.
I included both of them. You can find these in here.
https://github.com/FF-Projects-UE/FF_RealSense/tree/main/Source/FF_RealSense/ThirdParty/Windows
and there integrations are in build.cs.
These are screenshot of my SDK folder.

Also I rewrote my functions with
#include <librealsense2/rs.h>
#include <librealsense2/h/rs_pipeline.h>
#include <librealsense2/h/rs_frame.h>

and Unreal opened without problem.
If released sdk.exe should contain Intel.RealSense.dll, it is broken.

On the other hand android wrappers give this error when I try to use gradlew.
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
Caused by: java.lang.ClassNotFoundException: org.gradle.wrapper.GradleWrapperMain

but I can build this repo with gradle without problem and using it as android library.
https://github.com/mihir-chauhan/IntelRealsenseNative

It is unusual that both of the DLL files are not appearing in your SDK folder as I did a test install on Windows (though Windows 10 Home rather than Windows 11 Enterprise) for SDKs 2.53.1 and 2.51.1 and the files are there on my computer.

Usually I recommend not changing the default component installation settings on the installer program and just clicking 'Next' a few times until SDK installation is complete.  I also tried your method of installing just the C / C++ SDK, debug tools and Viewer and the DLL files were still present in the SDK bin folder.
It's great to hear that you made very significant progress!
There was a past case involving this Could not find or load main class org.gradle.wrapper.GradleWrapperMain error and a RealSense user posted their solution at https://github.com/IntelRealSense/librealsense/issues/6748#issuecomment-747250814 which was to change gradle version in Android Studio.  I do not know if you are using Android Studio yourself though.

using rs.h instead of rs.hpp solved my problem.
Also I built android wrapper from Android studio as you mentioned.
So, only problem is initating realsense for android.

It's great news that you achieved a solution.  Thanks very much for the update!


Build compatibility fix release 0.13.0 and assuring 'orelse' keeps its mandatory whitespace

Good minifier, I use it all the time. Thanks. In return, I can send you a PR to have your repo updated instantly. The massive formatting was handled automatically by ZLS.

Thanks!


Error when runing function test_IKE_Blip2OPT_VQA() in multimodal_edit.py

I'm trying to reproduce the result of method IKE on VQA dataset. But it appears the error:
Editing dataset:  75%|███████▌  | 1574/2093 [1:06:03<21:46,  2.52s/it]
Traceback (most recent call last):
  File "/mnt/Data/EasyEdit-main/multimodal_edit.py", line 737, in <module>
    test_IKE_Blip2OPT_VQA()
  File "/mnt/Data/EasyEdit-main/multimodal_edit.py", line 506, in test_IKE_Blip2OPT_VQA
    metrics, edited_model, _ = editor.edit_dataset(
  File "/mnt/Data/EasyEdit-main/easyeditor/editors/multimodal_editor.py", line 463, in edit_dataset
    "post": compute_icl_multimodal_edit_quality(self.model, self.model_name, self.hparams, self.tok, icl_examples,
  File "/mnt/Data/EasyEdit-main/easyeditor/evaluate/evaluate.py", line 329, in compute_icl_multimodal_edit_quality
    locality_image_acc, _ = icl_multimodal_lm_eval(model, model_name, hparams, tok, icl_examples,
  File "/mnt/Data/EasyEdit-main/easyeditor/evaluate/evaluate.py", line 348, in icl_multimodal_lm_eval
    samples = prepare_multimodal_edit(hparams, tokenizer, target, [''.join(icl_examples) + f'{x}'], image)
  File "/mnt/Data/EasyEdit-main/easyeditor/evaluate/evaluate.py", line 370, in prepare_multimodal_edit
    target = tok([' ' + target_ if target_[0] != ' ' else target_ for target_ in target], add_special_tokens=False, return_tensors="pt",)["input_ids"]
  File "/mnt/Data/EasyEdit-main/easyeditor/evaluate/evaluate.py", line 370, in <listcomp>
    target = tok([' ' + target_ if target_[0] != ' ' else target_ for target_ in target], add_special_tokens=False, return_tensors="pt",)["input_ids"]
IndexError: string index out of range

Hi, we will check the code and response to you asap.

Thank you for your interest in our work.
Due to the presence of null values in the dataset, which was formatted for EasyEdit, your code may have encountered errors. We have now updated the dataset on Google Drive to address this issue.
Please download the latest dataset and code to reproduce the results.

Well, I will try to run it on the latest dataset. Thanks!


Update Japanese strings, and fix a small i18n bug

This updates our Japanese translations, the better to serve as a basis for a push to translate the remaining ones.
Also fix a bug that prevents a few translations from working, which happen to be among the translations added in the couple of months since these were last pulled into the repo for 1.6.

Automated message from Dropbox CLA bot
@gnprice, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, after fixing the linter error (an extra semicolon).  Thanks @gnprice!


OKEx - Filled order getting logged twice on client

Describe the bug
Similar to issue #3317, while doing some tests with OKEx, the filled trade got logged twice after restarting the strategy. However, if you check the trade history from the exchange, only one filled record is available. This also provides wrong info for the aggregated data in datadog since the information send is duplicated.
Steps To Reproduce
Here are the steps to reproduce the issue (see attachments in the section below):

Run a pure market-making strategy and wait for an order to get filled.
Once a fill happens, immediately stop the strategy. In my case, I stopped the bot when I got the last confirmation message okex_exchange - The SELL OrderType.LIMIT_MAKER order ID has completed according to order delta websocket API.
Configure your market to another strategy or start the strategy a few seconds from stopping.
Check the log pane and it will return the previous filled message.
Run history --verbose to check if the same trade has been re-logged.

...
Screenshots

Release version
0.41.0
Attachments
logs_conf_pure_mm_3.log
sqlite and csv.zip
WARNING: Do NOT publish any exchange API keys or your wallet's private key. Whoever has access to them may steal your assets!
Optional: your discord username:
┆Issue is synchronized with this Clickup task by Unito

Tested but unable to replicate. The ticket closed for now and will reopen if happens again


Cython refactor of Python C wrapping layer

Supercedes #2134.
Begins Cython refactoring, adds Python3 testing to the harness, and provides the fuzzy pink floating platforms upon which robotic unicorns attack.

I've kicked the failing Python build a few times but the error smells legit. What do you make of
tools/run_tests/run_python.sh: line 39: python3.4_virtual_environment/bin/activate: No such file or directory FAILED: grpc._cython.cygrpc_test [ret=1, pid=9638]
in the output?

I forgot to install Python 3.4 and its virtualenv in the Travis yaml file.

Given the Python3.4 related changes, cc #282.

I've given up specifically using Python 3.4 (as opposed to Python 3.x) due to an incredible amount of trouble with getting Travis to provide the proper header files for building the extension without setting the entire project's language to Python. Instead this just tests against whatever version of Python 3 is available by default from python3-dev.

Aaannd OAuth2Client requires Python >= 3.3. What do I do with you, Travis...?

Changed to conditionally run Python x.y tests depending on the availability of interpreter x.y. Spits out a warning if a test is skipped.

(n.b. test failures are in other languages)

Only some nits. LGTM.
Note to self: adding comments on a specific commit leads to horrible UI.

Also, to be clear, commit 743c10ccd5b404edc695f2db6c8693a94b85d8c1 was already reviewed by Nathaniel?

The Travis Ruby failure is #2311. Please add issues for the other 3 failures (and note in them that Travis and Jenkins produced different results).

To the best of my knowledge Nathaniel covered 743c10ccd5b404edc695f2db6c8693a94b85d8c1 (and part of the now mutilated Py3-testing-support commit - wow GitHub's UI gets confusing with things like this) and I addressed his concerns. I'll add issues for these three guys soon™.

That's one reason why you shouldn't rebase history that's already published :) I guess if you recover the old commit number (reflog), add your changes as a new commit, and push again, the comments will reappear.

In any case, I re-reviewed the ammended commit and it LGTM.

Jenkins failure appears to be a separate issue (#2359).


Remove all token children that allowed arbitrary keywords

Allowing arbitrary keywords for a token was a bit of an anti-pattern. We should always explicitly specify which keywords we support. With token kind validation, this has pointed us to parser bugs before.
rdar://107156958

@swift-ci Please test

@swift-ci Please test


Give page paraeter to /users. It's required for history back.

Move to /users
Move to next page of /users
Show user detail
History back

Now, it's always back to first page. But it's expected to be back to page 2.

How to fix that bug ? :)

@Kravs
Here is an implementation. Take a look.
https://github.com/springboot-angular2-tutorial/angular2-app/commit/86bd413a1e0e1d64dd5490ecc2a3982c10b9ae80#diff-fe9330d62aad143933fa53e34da3cd04


Sanitize Terminology

Attribute -> AttributePath
AttributeSetOf -> AttrsOf
option -> option_path
(todo: more)

option_value could be definition IMO.
If we're changing Attribute to AttributePath I think OptionPath also works, I'm not so sure how well this works with NixOS terminology in general, but the way we're using AttributePath seems aligned with nixos-option.


Allow print_goals in sync example to alternate more frequently as sug…

The original example doesn't alternate frequently as suggested by the demo in SCRIPT.txt when running slow_print::start. Adding a short sleep before failing allows the threaded goals to alternate more frequently as initially suggested.

The original example doesn't alternate frequently as suggested by the demo in SCRIPT.txt when running slow_print::start. Adding a short sleep before failing allows the threaded goals to alternate more frequently as initially suggested.

Note my acknowledgment that the original code was demonstrating correct behavior. The improvements here only serve to make synchronization demo more illustrative to users.

Damn computers always getting faster :-) Please (1) undo the whitespace changes to the header, (2) update data to current date and version to 1.1, and (3) fix the failure-driven loops as indicated in the code comments.

No problem. I'll make the above changes when i return home.

Thanks!

A pleasure :grinning:


componentWillReceiveProps warning

A warning comes up to replace componentWillReceiveProps() to componentDidUpdate()
Thank you for your work.

the error from this library itself should be gone in the latest update.
The same lifecycle method deprecation warning also appears in my case from react-native's own components like TouchableOpacity etc.
Those will only be gone once react-native updates them.


Instructions for Vue devtools in chrome debugger

This was something I've been struggling with.  I could install devtools in my debugging session, but then I would have to reinstall it and reconfigure my settings every time I rebooted my computer.  This response has helped me

How is this?

@NataliaTepluhina thanks for looking over my PR.  How is this?


Out of Memory when training an large custom YOLOV3 dataset

While training in a custom large dataset using YOLOV3 i realised that when finishing epoch 1, no memory was released.
Due to the dataset size, it had used more than 50GB of the 64GB memory on the machine on the first epoch and it kept growing while working on Epoch 2.
Seems there is a memory leak or some structure keeps increasing even when epochs change.
This is not an issue with the GPU memory (batch size was 8) as the first epoch trained fine and generated a usable model
Machine has 64GB of memory plus 8GB of swap and a GTX 1070 with 8GB of memory. All memory and swap were exhausted while no other process was running on the machine (except linux and system processes)
Epoch 1/100
51576/51576 [==============================] - 42746s 829ms/step - loss: 7.3072 - yolo_layer_1_loss: 0.5451 - yolo_layer_2_loss: 2.1719 - yolo_layer_3_loss: 4.5901 - val_loss: 5.1430 - val_yolo_layer_1_loss: 0.4046 - val_yolo_layer_2_loss: 1.7030 - val_yolo_layer_3_loss: 3.9388
Epoch 2/100
13117/51576 [======>.......................] - ETA: 10:02:38 - loss: 5.7555 - yolo_layer_1_loss: 0.3795 - yolo_layer_2_loss: 1.6745 - yolo_layer_3_loss: 3.7015Killed

I will advice that you keep the batch size at about 4 to address this.

I will advice that you keep the batch size at about 4 to address this.


Automatically change from "Run" to "Build" when fn main is removed.

Often I just want to build code, not run it. Sometimes having the main function there is a little annoying. I know I can add #![crate_type="lib"], but try typing that fast (on a German keyboard, for extra challenge)... it's quite a mouthful.
Do you think it would make sense to switch to lib mode when I just remove the main function? The check could be something simple, like testing for the regex fn +main.

Duplicate of #169 or #201

My current gut feeling is to just add a "build" option in the dropdown, coupled with #368


[Feature] Ensure dropdowns render within viewport (if possible).

See the following GIF where I right click to bring up a context menu, and the context menu goes off screen.

Fix idea

When rendering a dropdown, pre-measure the width needed, then if rendering the dropdown would make it go offscreen, offset the position of the dropdown so that it stays on screen.
In a case where it is impossible fit a dropdown onscreen, show as much as one can, then allow for scrolling.

Stale issue. The IDE needs a release version and the issues are cluttered. I want to focus on getting high priority items listed and low priority items listed.
This would aid in anyone who has interest in the Luthetus.Ide project, what the triage is looking like for v1


Serialize and deserialize structs as sequences.

Fixes #1.

Codecov Report

Merging #2 (21f675a) into master (43e9aea) will decrease coverage by 0.02%.
The diff coverage is 96.87%.

:exclamation: Current head 21f675a differs from pull request most recent head 2ebd44f. Consider uploading reports for the commit 2ebd44f to get more accurate results

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   98.32%   98.30%   -0.03%
==========================================
  Files           4        4
  Lines        6339     6416      +77
==========================================
+ Hits         6233     6307      +74
- Misses        106      109       +3

Impacted Files
Coverage Δ

src/ser.rs
97.46% <96.29%> (-0.12%)
:arrow_down:

src/de.rs
97.95% <97.61%> (-0.01%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.