"Maximum call stack size exceeded" error on build a lot images

Describe the bug
To build a lot images will got "Maximum call stack size exceeded".
Reproduction
https://stackblitz.com/edit/vitejs-vite-3y1vrp?file=App.vue
Steps to reproduce

Toggle the last comment of the code
Run vite build
Build fail and get Maximum call stack size exceeded

System Info
System:
    OS: Linux 5.0
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    @vitejs/plugin-vue: ^4.0.0 => 4.1.0
    vite: ^4.3.0-beta.2 => 4.3.0-beta.8
* This info from stackblitz *

Used Package Manager
pnpm
Logs
❯ vite build
vite v4.3.0-beta.8 building for production...
✓ 5 modules transformed.
✓ built in 263ms
Maximum call stack size exceeded
error during build:
RangeError: Maximum call stack size exceeded
    at _0x43f618.entries (<anonymous>)
    at Literal.parseNode (file://file:///home/projects/vitejs-vite-3y1vrp/node_modules/rollup/dist/es/shared/node-entry.js:5837:43)
    at Literal.parseNode (file://file:///home/projects/vitejs-vite-3y1vrp/node_modules/rollup/dist/es/shared/node-entry.js:9269:15)
    at new NodeBase (file://file:///home/projects/vitejs-vite-3y1vrp/node_modules/rollup/dist/es/shared/node-entry.js:5753:14)
    at new Literal (file://file:///home/projects/vitejs-vite-3y1vrp/node_modules/rollup/dist/es/shared/node-entry.js:9226:1)
    at BinaryExpression.parseNode (file://file:///home/projects/vitejs-vite-3y1vrp/node_modules/rollup/dist/es/shared/node-entry.js:5862:29)
    at new NodeBase (file://file:///home/projects/vitejs-vite-3y1vrp/node_modules/rollup/dist/es/shared/node-entry.js:5753:14)
    at new BinaryExpression (file://file:///home/projects/vitejs-vite-3y1vrp/node_modules/rollup/dist/es/shared/node-entry.js:9139:1)
    at BinaryExpression.parseNode (file://file:///home/projects/vitejs-vite-3y1vrp/node_modules/rollup/dist/es/shared/node-entry.js:5862:29)
    at new NodeBase (file://file:///home/projects/vitejs-vite-3y1vrp/node_modules/rollup/dist/es/shared/node-entry.js:5753:14)

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

@sodatea should we move this one to the vite-plugin-vue repo? It looks like a Vue-only issue.

I have a website built by Nuxt, which is wiki-based , uses HTML to render pages, and some pages use a lot of images. There was no problem when compiling with nuxt2, until it was upgraded to nuxt3, because one of the page reused some pictures and the compilation failed. After checking to find that it was because of too many pictures.

I think this could be moved to a report in the rollup repo if there is interest. Having that many images is an edge case though, so maybe it isn't that urgent. Closing it here as there isn't much we can do in Vite core.


Test for issue 633 (warning on Ant)

This pull request adds a test for #633.
31a4f2029ce7358064d693f89f64ad7422e1e09b is the test.
cde7e67eec92d49099c768af0d47c16b7aecfd17 is a temporary commit for demonstrating test failures by not skipping the tests on Saxon 9.7: Azure, Travis
2c0fb3b387c544e6bf55471ce37e8faca151861a is for readability. 09227ea6f2a04d416d5bb888fa9e271bb2857fa2 just improves precision of a test. They aren't related directly to #633 but they are so trivial that I included them here.

ab5a79cd7b4d95d409cdbc656a2fe039b7ab0e15 demonstrates #633: Azure, Travis
318ab545eb55f23cfeca34a90fa0114ee365d4e0 skips the test until #633 gets fixed

As the test failures are demonstrated, I'm merging this.


[v3] CSS minification error on framework7.css 3.1.0 with vue-cli 3

Framework7 version: [e.g. 3.1.0]
Platform and Target: [Web]
Reproduction: See this repo. yarn run build

Describe the bug
Production build fails.
To Reproduce
Steps to reproduce the behavior:
framework7-template-split-vue-webpack git:(master) ✗ yarn build
yarn run v1.7.0
$ vue-cli-service build

 ERROR  Error: CSS minification error: Parse error on line 1:
8px + constant(safe-area-i
        ------^
Expecting 'SUB', 'LPAREN', 'NESTED_CALC', 'NUMBER', 'CSS_VAR', 'LENGTH', 'ANGLE', 'TIME', 'FREQ', 'RES', 'EMS', 'EXS', 'CHS', 'REMS', 'VHS', 'VWS', 'VMINS', 'VMAXS', 'PERCENTAGE', got 'PREFIX'. File: css/chunk-vendors.cd97c7e3.css
Error: CSS minification error: Parse error on line 1:
8px + constant(safe-area-i
------^
Expecting 'SUB', 'LPAREN', 'NESTED_CALC', 'NUMBER', 'CSS_VAR', 'LENGTH', 'ANGLE', 'TIME', 'FREQ', 'RES', 'EMS', 'EXS', 'CHS', 'REMS', 'VHS', 'VWS', 'VMINS', 'VMAXS', 'PERCENTAGE', got 'PREFIX'. File: css/chunk-vendors.cd97c7e3.css
    at /Users/andreas/dev/examples/framework7/framework7-template-split-vue-webpack/node_modules/@intervolga/optimize-cssnano-plugin/index.js:106:21
error Command failed with exit code 1.

Expected behavior
Build should succeed.
If you remove framework7.cc in main.js, the build will be successful:
Uncomment framework7.css:
// Import F7 Styles
// eslint-disable-next-line
// import Framework7Styles from "framework7/css/framework7.css";

Issue here is not in Framework7, but in the optimize-css-nano plugin which doesn’t understand such CSS rules

@nolimits4web As I understand it these are non standardized css rules. My project uses the Vue cli 3 toolchain.
Closing this issue ist not helpful, cause it cuts off Vue.

This css rules are used in iOS and must be used there, issue is closed because it is not related to Framework7
https://medium.com/@draganeror/iphone-x-layout-features-with-css-environment-variables-d57423433dec

More relevant and profitable will be opening issue on vue compiler or that css processor

Thanks for explaining.

Causing issue is here https://github.com/postcss/postcss-calc/issues/48

@zoosky can you tell me how you fixed it? Facing the same problem. Thanks!


Update to latest ethers & revm

Also dropping risc0-build from all guest crates. This should resolve most of the dependabot alerts.

Thank you for the build-dependencies cleanup


kie-server-tests: improve Case dynamic task coverage

Rest tests are failing:

testAddDynamicWorkItemTaskNoTaskSpec fails because CaseManagementServiceBase suppose that unmarshalled taskSpecificationMap is not null. May be good to return Response.Status.BAD_REQUEST in that case with description what is missing there.
testAddDynamicWorkItemTaskNotExistingContainer fails because Kie server service returns IllegalArgumentException for missing container which isn't handled in case resource.

@mswiderski What do you think about it?

testAddDynamicWorkItemTaskNoTaskSpec fails because CaseManagementServiceBase suppose that unmarshalled taskSpecificationMap is not null. May be good to return Response.Status.BAD_REQUEST in that case with description what is missing there.

+1, we should respond with bad request in that situation

testAddDynamicWorkItemTaskNotExistingContainer fails because Kie server service returns IllegalArgumentException for missing container which isn't handled in case resource.

is this only to handle the exception?

Was thinking about exception handling in Kie server a little bit.....
How we should distinguish between different failures in Kie server?
For example for case represented by testAddDynamicWorkItemTaskNoTaskSpec we can check unmarshalled taskSpecificationMap and if we find that there is missing parameter we can throw IllegalArgumentException which will be converted to HTTP response code 400 in REST endpoint.
Then there is for example testAddDynamicWorkItemTaskNotExistingContainer, where we throw same IllegalArgumentException when we try to locate proper container [1]. In this case it will be more appropriate to return HTTP response code 404 as case id (which wasn't found) is part of request URL.
I think that Kie server could use some specific exceptions to detect fail states in own code like missing container or case.
What do you think about it?
[1] https://github.com/droolsjbpm/droolsjbpm-integration/blob/master/kie-server-parent/kie-server-services/kie-server-services-case-mgmt/src/main/java/org/kie/server/services/casemgmt/locator/ByCaseIdContainerLocator.java#L67

incorporated in https://github.com/droolsjbpm/droolsjbpm-integration/pull/753


phpunit does not run by README

Hi. I've tried running tests by README but it gives an error about missing api key. I guess it should work out of the box for tests run? 🤔
terminal: php71 vendor/bin/phpunit --verbose
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

Runtime:	PHP 7.1.31 with Xdebug 2.7.2
Configuration:	~/pipedrive/pipedrive/phpunit.xml

EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE

Time: 354 ms, Memory: 8.00MB

There were 42 errors:

1) Pipedrive\Tests\ActivitiesControllerTest::testTestGetAllActivitiesAssignedToAParticularUser
Exception: Client is not authorized. An OAuth token or an API token is needed to make API calls.

~/pipedrive/pipedrive/src/OAuthManager.php:150
~/pipedrive/pipedrive/src/Controllers/ActivitiesController.php:128
~/pipedrive/pipedrive/tests/Controllers/ActivitiesControllerTest.php:64

2) Pipedrive\Tests\ActivityFieldsControllerTest::testTestGetAllFieldsForAnActivity
Exception: Client is not authorized. An OAuth token or an API token is needed to make API calls.

~/pipedrive/pipedrive/src/OAuthManager.php:150
~/pipedrive/pipedrive/src/Controllers/ActivityFieldsController.php:56
~/pipedrive/pipedrive/tests/Controllers/ActivityFieldsControllerTest.php:53

...

Hello @aistis- . Please ignore those tests for now. They are more for internal use. We will work on this in future versions on library to give possibility to open source community to check and write tests as well.
Thanks for your feedback.


Use get_state for unstucking.

Add code to push the received text data upstream.

Stable but drops text.


Remove unnecessary code

Was code review comment from #902
NONE

/lgtm

the error is in the next script, now I can repro it


Hello Rails Backend

Work Done
Backend

Created a new Rails API app called hello-rails-back-end.
Postgres database set up.
Created a table for storing messages and created 5 different greetings.
Created an API endpoint that selects a random greeting from the table (controller with an action and rails route).

Frontend
Link to React Frontend Repo: Frontend
Link to React Frontend PR: PR

Work Done
Hi @Reem-lab, thank you very much for your feedback, I realized an error in my configs and I have fixed it. The app now successfully fetches greetings from the backend.


Update platform field so that it can accept many more (any string) value

Currently I believe that the platform field is an enum that can only be one of the following values:

Platform
p value

Web (including Mobile Web)
web

Mobile/Tablet
mob

Desktop/Laptop/Netbook
pc

Server-Side App
srv

General App
app

Connected TV
tv

Games Console
cnsl

Internet of Things
iot

This is too limited now Snowplow is a general event data platform e.g. for tracking emails none of the above platforms fit the bill...
Can we update the validation so that any string value is accepted, giving users much more flexibility to set this field appropriately?

👍

Let's move over to Enrich.


fmt(*): fix comment format for go1.19

Signed-off-by: lance6716<EMAIL_ADDRESS>
What problem does this PR solve?

Issue Number: ref #6909
What is changed and how it works?
Check List
Tests

No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`.

/run-leak-test

/check-issue-triage-complete

/merge

Codecov Report

Merging #6943 (f914252) into master (7c5032c) will increase coverage by 0.0528%.
The diff coverage is 49.1793%.

Additional details and impacted files

Flag
Coverage Δ

cdc
67.3364% <73.7864%> (-0.0405%)
:arrow_down:

dm
52.0921% <36.0184%> (+0.0935%)
:arrow_up:

engine
62.7692% <56.4393%> (+0.1338%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #6943        +/-   ##
================================================
+ Coverage   59.9224%   59.9752%   +0.0528%
================================================
  Files           783        787         +4
  Lines         89519      89817       +298
================================================
+ Hits          53642      53868       +226
- Misses        31168      31237        +69
- Partials       4709       4712         +3


Photos not associated with the correct position

Here's an example. This is the intersection of US-41 and M94. I actually crossed this intersection. But your map has it associated with a wildly incorrect position. And similar errors have occurred for the last 10 traces I've uploaded.
At this point, I'm near giving up on your service. I've had errors with almost everything I've uploaded, and this whole experience is just incredibly frustrating.

quote! My smartphone GPS antenna is terrible, there shoud be a way to manually correct the photo position/orientation on the OpenStreetCam website...

This isn't a GPS problem though. This looks more like they're reading the wrong line it their trace. Otherwise you wouldn't expect the path to line up with the road as consistently as it does.

I think they choose the road based on the GPS position. if you have a low quality gps position and the photos are positioned with offset you risk that those photo are associated with the wrong road because that road is the nearest to the wrong positions. but i don't know how it work so this is only a my reasoning

It is the correct road, and every position it lists is a position I was actually at along that road. It just has the wrong photo associated with a given position, and that drift appears to get worse over time.


drivers: entropy: nrf5: Fix ENTROPY_BUSYWAIT from hanging

Missing clear pending RNG_IRQn when generating multiple
random numbers caused CPU to hang at __WFE call in the
loop waiting for new value.
This fixes commit ddb7f88f9ed5 ("drivers: entropy: nrf5: Fix
ENTROPY_BUSYWAIT implementation")
Fixes #9523.
Signed-off-by: Vinayak Kariappa Chettimada<EMAIL_ADDRESS>

Codecov Report

Merging #9770 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9770   +/-   ##
=======================================
  Coverage   52.24%   52.24%
=======================================
  Files         212      212
  Lines       25950    25950
  Branches     5593     5593
=======================================
  Hits        13557    13557
  Misses      10159    10159
  Partials     2234     2234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697919c...50efe20. Read the comment docs.


Support Zephyr

Hi,
Zephyr is very interested, have any plan to porting Zephyr to ESP32?

Comment: You might find that posting this as a question on the ESP32.com community forum might be a better mechanism.  The ESP-IDF issues tracking in Github is (I believe) primarily for defect tracking.
http://esp32.com/

@nkolban You are right. I'm sorry about this. I will close the issue & create a thread in the ESP32's forum.


[msid][gtd] react tutorial: DOCS-CODE-023

Purpose
Creating new React tutorial scenario: DOCS-CODE-023
Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

Hello @mmacy, Please review the Readme.


Lower SDK version to 10?

I am using LiveSDK for Android at the moment and I'd like to move on to OneDrive SDK but it has minimum SDK 15, all my apps are minimum SDK 10. Are there any plans to lower the SDK version? At least to 10?

The core SDK does not have any requirements that prevent it from functioning on SDK 10, however the default authentication provides that this library depends on have min versions set at 14.

I've already opened a pull request on the MSA Library https://github.com/MSOpenTech/msa-auth-for-android/pull/23 to lower the version number.

It doesn't appear that the ADAL library I use had a hard requirement on SDK 14, I've opened https://github.com/AzureAD/azure-activedirectory-library-for-android/issues/454 to follow that issue.

Abandoning this pull request for the time being, if there is renewed interest we can investigate this issue further.


added channels to connector

#925

Pull Request Test Coverage Report for Build 40788

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.744%

Totals

Change from base Build 40564:
0.0%

Covered Lines:
4365

Relevant Lines:
8602

💛  - Coveralls

working on js/ts next


GitHub Self hosted runner uses go cache

Current Behaviour
We are not running vagrant tests because it gets cached from go cache
Possible Solution
Set GOFLAGS="-count=1" in the .env action-runner file
Environment
GitHub Action self hosted runner
/cc. @rawkode

It doesn't look like we have self hosted runners any longer. If we encounter one and this is an issue we can reopen.


Using Expired Status and Throws Error

Expected Behavior
Pull current status of the different Roomba characteristics
Current Behavior
Get error:
[25/03/2021, 08:32:20] [Roomba i3+] Using expired status
[25/03/2021, 08:32:20] [Roomba i3+] Bin status requested
[25/03/2021, 08:32:20] [homebridge-roomba2] This plugin threw an error from the characteristic 'Contact Sensor State': Unhandled error thrown inside read handler for characteristic: This callback function has already been called by someone else; it can only be called one time.. See https://git.io/JtMGR for more info.
Steps to Reproduce (for bugs)
Normal operation; can't determine specific instance when the error occurs
The example above is one characteristic, but the same error happens for all of them
Versions

Homebridge: 1.3.4
Node: 14.15.1
Plugin: 1.2.0

Configuration

Homebridge Log / Command Output

[25/03/2021, 08:32:20] [Roomba i3+] Using expired status
[25/03/2021, 08:32:20] [Roomba i3+] Bin status requested
[25/03/2021, 08:32:20] [homebridge-roomba2] This plugin threw an error from the characteristic 'Contact Sensor State': Unhandled error thrown inside read handler for characteristic: This callback function has already been called by someone else; it can only be called one time.. See https://git.io/JtMGR for more info.

same problem here
using Roomba 900 series, Roomba 976


Watch history not working.

Hello, I am just put install forever and apply a command.
sudo forever -w app.js
then It should watch of running every hit of URL. but there is nothing happen in putty.
please alert me what I am doing wrong.. ASAP

Same for me, since the NodeJS version 6.0 update.


Remove unsafeHumanReadablePartFromText from bech32 library.

Context
We'd like to switch to using the Hackage version of the bech32 library instead of our own copy (in cardano-wallet/lib/bech32). In order to do so, we must bring our local copy and the Hackage version into parity with one another.
Our local copy of the library has one extra function not present in the Hackage version: unsafeHumanReadablePartFromText
Analysis
The unsafeHumanReadablePartFromText function throws an exception at run time if the specified input cannot be parsed. It's the only function that explicitly throws a run-time exception in a library of otherwise pure functions.
We currently only use this function to parse hard-coded string literals. Therefore, there is no need to defer the verification to run time. We can remove the function entirely and perform the parsing/checking at compile time instead.
Decision

[x] Remove the unsafeHumanReadablePartFromText function from our local copy of the bech32 library.
[x] Create a module in cardano-wallet-core:lib that defines and exports a Bech32 human-readable part (HRP) quasiquoter.
[x] Use this quasiquoter to replace existing calls to unsafeHumanReadablePartFromText.

Example:
hrp = [Bech32.humanReadablePart|addr|]

Acceptance Criteria

[x] Our local copy of the bech32 library must not export the unsafeHumanReadablePartFromText function.
[x] We must have a quasiquoter capable of parsing human-readable prefix literals at compile time, so that attempting to use an invalid literal will result in a compile time error.
[x] All existing human-readable prefix literals must use the quasiquoter.

Development
As above.
QA

[x] Migrate any coverage of the unsafeHumanReadablePartFromText function to the official version of the bech32 library. (See https://github.com/input-output-hk/bech32/pull/7)

Hi @piotr-iohk
Are you happy with me closing this issue? I believe that all the items are complete.


[stable/nginx-ingress] Extend defaultBackend probes

Signed-off-by: Kevin Scholz<EMAIL_ADDRESS>What this PR does / why we need it:
Currently there is no readinessProbe for the default backend deployment. This leads to a successful deployment, even if the default backend does not start properly .
Special notes for your reviewer:
I added some possibilities for configuration, similar to the probes in the NGINX deployment. I hope this makes it more consistent. The previous values and the defaults were preserved.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

Hi @taharah, could you have a look?
/assign @taharah

Both points make sense to me, so going to go ahead and approve as is.

/ok-to-test
/lgtm


issues api allow pulls and fix #4832 (#4852)

backport from #4852 and close #4832

make LG-TM work


boot_finished.save file is empty

Hi Andrea,
first of all thanks for the Photo Frame. Thanks to your guide i could install it. I just have one small problem. When I want to enable the autostart i get stuck on the step with modifying the boot_finished.save file.
My file is empty.
Do you know what I can do in this case? What should paste into it?
I tried it on an Kindle Touch 4 (Model Nr. D01200)

Hi, I'm happy you like it.
It is not clear to me why you use the '.save' extension. The file on my device is 'boot_finished' with no extension. Maybe on your device the names are different?
I do not have the device you have, so I cannot give you a safe advice on this (safe as avoiding to tell you "try this" and then your device is bricked).
Maybe you may look for help on the mobileread forum, which is a incredible resource of knowledge and talented people.
I've found most of the information I needed to build photoframe on mobileread.

Hi, thanks for the reply. Thanks for the suggestion, i will have a look at the mobileread forum

I'm closing the issue as "not planned". Whenever you'll find a solution you are very welcome to reopen it and add your information.


Add SECURE_SSL_PORT option for SSL redirects

The SECURE_SSL_REDIRECT option will redirect plain http:// requests to https:// URL but does not change the rest of the URL. This is fine if http is being served on default port 80, but in case of non-default port such as 8080 the redirect becomes http://hostname:8080/path -> https://hostname:8080/path which obviously fails.
The SECURE_SSL_PORT option added by this PR allows configuring what the destination port should be for SSL redirects.

I would expect that local 443 -> 8080 redirection is handled by HTTP server or a proxy, not an app itself 🤔

That argument would make more sense if SECURE_SSL_REDIRECT, SECURE_SSL_HOST and SECURE_REDIRECT_EXEMPT didn't exist, however it's clear there's likely to be resistance to this and it's going to be more effort to  justify than to do just that and implement in HTTP server.


Initialize v1 and v2 storage only when it is used

This costs a little bit, but it makes it possible to use this package for v3 and v4 without any available entropy. Network interfaces are only scanned when using v1 or v2. I don't know if these are interesting use cases, but here's the code!
Before:
BenchmarkNewV1   5000000               268 ns/op               0 B/op          0 allocs/op
BenchmarkNewV2   5000000               272 ns/op               0 B/op          0 allocs/op
BenchmarkNewV3   2000000               861 ns/op             144 B/op          4 allocs/op
BenchmarkNewV4   1000000              1841 ns/op              16 B/op          1 allocs/op
BenchmarkNewV5   2000000               916 ns/op             176 B/op          4 allocs/op

After:
BenchmarkNewV1   5000000               288 ns/op               0 B/op          0 allocs/op
BenchmarkNewV2   5000000               286 ns/op               0 B/op          0 allocs/op
BenchmarkNewV3   2000000               866 ns/op             144 B/op          4 allocs/op
BenchmarkNewV4   1000000              1853 ns/op              16 B/op          1 allocs/op
BenchmarkNewV5   2000000               916 ns/op             176 B/op          4 allocs/op

Great! Thanks again.


Added Bitwise Tuples

Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Fixes #1122
Replace issue_no with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

@ravikr126 please review this pr.


Why in version 223 - CC API VERSION 2.42.0, the method changed the Response (http code & body result)?

Good morning,
I would like to know why this method changed the REST output contract in relation to previous version.
http://apidocs.cloudfoundry.org/223/apps/remove_service_binding_from_the_app.html
From 2.44 to last version, this method returns a HTTP CODE 204 without BODY content but in previous versions, the method returned a 201 and a JSON.
What is the reason to change the contract?
Is it a bug?
I have tested this fact in 3 environments:
Environment: BLUEMIX 2.40.0 <- 204 NO BODY
Environment: PIVOTAL 2.44.0 <- 201 JSON
Environment: LOCAL_INSTANCE_1 2.25.0 <- 201 JSON

Many thanks in advance.
Juan Antonio

@jabrena This was posted to cf-dev [1] a while back asking if anyone had any issues with CC changing the response code from 201 Created is incorrect for DELETE end points.
Is this causing an issue for you?
[1]<EMAIL_ADDRESS>

Good morning @dieucao,
yes, I was checking the whole project and I noticed that every method which it removes an objects returns 204 so it is a good change.
If I detect some similar doubts, I will notify.
At the moment, I have registered 3 http codes:
https://github.com/prosociallearnEU/cf-nodejs-client/blob/master/lib/utils/HttpCodes.js
The alternative for this method:
http://apidocs.cloudfoundry.org/226/service_bindings/delete_a_particular_service_binding.html
has the right http code.
Cheers


PHP Parse error

Does outscraper-php version 1.6 really support PHP 7.4?
I'm following the examples and can't get past an error.
PHP Parse error:  syntax error, unexpected ':', expecting ')' in index.php on line 17.
Line 17 is "reviews_limit: 500".
$results = $client->google_maps_reviews_v3(         ["my place id...", "...", "...", "..."],         reviews_limit: 500,         limit: 1,         sort: 'newest',     );

The current release (1.6) will not work with PHP 7.4. I also tried versions 1.1.0 - 1.6 with PHP 7.4 and none of them worked for me. I ended up modifying my local source of the v1.6 outscraper.php file so that it does.


Component not found

With hardhat tasks present errors with components not found in artifacts paths. (Exchange, Liquidity)
Ex: import factoryContract from "../../build/artifacts/contracts/uniswapv2/UniswapV2Factory.sol/UniswapV2Factory.json";
import routerContract from "../../build/artifacts/contracts/uniswapv2/UniswapV2Router02.sol/UniswapV2Router02.json";
import { IERC20Uniswap__factory } from "../../build/types/factories/IERC20Uniswap__factory";
Thanks for review the issue.

Same Issue here!

Same problem here, did anyone have a solution?


Canvas render

Codecov Report

Merging #16 (5cec40a) into 0.0.5 (1886913) will increase coverage by 12.38%.
The diff coverage is 48.14%.

@@             Coverage Diff             @@
##            0.0.5      #16       +/-   ##
===========================================
+ Coverage   74.03%   86.42%   +12.38%
===========================================
  Files           2       23       +21
  Lines         104      788      +684
  Branches       21      124      +103
===========================================
+ Hits           77      681      +604
- Misses         27      107       +80

Impacted Files
Coverage Δ

src/RL/Algos/dqn/index.ts
93.85% <ø> (ø)

src/index.ts
100.00% <ø> (ø)

src/RL/utils/sleep.ts
25.00% <25.00%> (ø)

src/RL/Environments/viewer/index.ts
38.46% <38.46%> (ø)

src/RL/Environments/examples/simpleGridWorld.ts
88.63% <50.00%> (ø)

src/RL/Environments/examples/cartpole/index.ts
83.95% <56.25%> (ø)

src/RL/Environments/index.ts
68.42% <80.00%> (ø)

src/RL/Environments/examples/index.ts
100.00% <100.00%> (ø)

src/RL/DP/index.ts
100.00% <0.00%> (ø)

src/RL/Agent/index.ts
75.00% <0.00%> (ø)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1886913...5cec40a. Read the comment docs.


documentintelligence, update tsp-location commit ID to that from main branch

client name in current commit ID is wrong
https://github.com/Azure/azure-rest-api-specs/blob/a4879111ce38cd0350ced6278936ba36580218f9/specification/ai/DocumentIntelligence/client.tsp
DocumentAnalysisClient / DocumentModelAdministrationClient
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Update logging to include lockToken wherever available

It should be possible to trace a received message through the various touchpoints in the SDK. The best way to do this would be the lockToken as it will be specific to a particular instance of receiving the message (whereas SequenceNumber will always be the same for a given message each time it is received). Many events already include the lockToken, but we should log it whenever available.

This is still missing from lock renewal events.


Apply fingerprint backpack-react-scripts to project

Nudge generated by Atomist

Pull request auto merged by Atomist.

No reviews
1 successful check

[atomist:generated] [auto-merge:on-check-success]


Upgrading aws-sdk version from v1 to v2

Description and Impact
No change for production, just updating internal aws-sdk version.
Deploy Plan

Does Platform Operations need to know anything special about this deploy? Are migrations present?

Rollback Plan

To roll back this change, revert the merge with: git revert -m 1 MERGE_SHA and perform another deploy.

URLs
http://docs.aws.amazon.com/sdkforruby/api/Aws/EC2/Client.html
http://docs.aws.amazon.com/sdkforruby/api/Aws/ElastiCache/Client.html
http://docs.aws.amazon.com/sdkforruby/api/Aws/RDS/Client.html
http://docs.aws.amazon.com/sdkforruby/api/
QA Plan

[ ] Run bin/aws-auditor audit [profile] in both master and this branch to verify the outcomes are the same (may need to rebundle)
[ ] Run bin/aws-auditor inspect [profile] in both master and this branch to verify the outcomes are the same (may need to rebundle)
[ ] Run bin/aws-auditor audit [profile when MFA is enabled to see if it prompts for an MFA token

CRQA 👍


[Storage] Blob Clean-up

As title states 😄 all docstring changes so nothing should break!

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-storage-blob

/azp run python - storage - ci


Minor changes in import statement

Change from handyview.widgets import show_msg to from widgets import show_msg

@rushirajsherlocked
Thanks for your work:-)
But there must something wrong.
Some files have been already in the repo, but this PR again add them. You may check what happens.
For example, the db.py

Change from handyview.widgets import show_msg to from widgets import show_msg

It seems that this change is not necessary. So I close this PR.


fill in Learn more links on Landing page

There are 6 Learn more ... links on the Landing page. These need to point off to the right place in the clearlydefined/docs
Note that this has to wait until the docs are moved from the wiki but that should be any minute now

done


Temporarily removed moods link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://guh.guru:8080/job/guh-webinterface-pull-request/38/
Test PASSed.


Relative links in automatically generated workflow descriptions are broken.

Describe the bug
The description that is automatically generated from README.md on github will not handle the relative links correctly.
To Reproduce
Steps to reproduce the behavior:
After publishing the workflow to dockstore:
For example link to https://github.com/ENCODE-DCC/mirna-seq-pipeline/blob/PIP-1610-add-workflow-opts-for-dockstore/docs/installation.md from the main README.md will point to a non-existent page on docstore.org instead of the installation.md on github.
Expected behavior
The correct markdown document to be linked
┆Issue is synchronized with this Jira Story
┆fixVersions: Dockstore 1.12
┆friendlyId: DOCK-1908
┆sprint: SEAB 79- Gary (the snail)
┆taskType: Story

Million thanks for fixing this!


Crash when replying after commencing reading body but not completing

Leaving a "reply" after an unfinished (i.e. stop reading after badlength or more) call to body/2 or body_qs/1 results in a crash:
Req3 = cowboy_req:reply(400, Req2),
{ok, Req3, State}

Results in:
16:55:13.134 [error] Error in process <0.356.0> with exit value:
{{badmatch,{error,closed}},[{cowboy_req,body_recv,3,[{file,"src/cowboy_req.erl"},{line,464}]},{cowboy_req,body_loop,5,[{file,"src/cowboy_req.erl"},{line,447}]},{cowboy_protocol,next_request,3,[{file,"src/cowboy_protocol.erl"},{line,504}]}]}
16:55:13.134 [error] Ranch listener http terminated with reason: no match of right hand value {error,closed} in cowboy_req:body_recv/3 line 464

N.B. That the crash happens after the reply has been successfully received by the client (i.e. this problem is not affecting the client to my knowledge).
Removing the call to reply/2 results in an empty response and no crash.

Closing this because this all has changed in 2.0 and shouldn't be an issue anymore. Thanks!


No Background image after latest update

Bug Description
After updating to the latest version of the theme, prompted on the notification inside playnite, my background images are not showing up even if i have them downloaded.
To Reproduce
No response
Extensions log
No response
Screenshots

The background image has never been displayed in that panel. If you were seeing it before, that means you previously used the Details to Grid View Converter and either disabled or uninstalled the extension. Enable/install again and verify that the theme is enabled in the extension settings.

thanks!


Recently released version depends on python-is-python2, wrecks ability to use colcon

It seems that the latest version of python-vcstools and python-wstool installs python-is-python2 on 20.04.  This wrecks havoc on trying to use colcon as there are several steps that run python and expect to get a python3 interpreter.  Is there any reason a python2 version of this package was released into 20.04?  Secondly, is there any reason this had to depend on python-is-python2 in that version and not just use python2 or python2.7 or whatever version of python2 this depends on?

We are having the same issue company-wide. Friendly ping to @dirk-thomas if we are missing something or is there any other workaround other than what Tyler suggested here: https://discourse.ros.org/t/python-is-python2-is-not-nice/23021

When I search my apt history.log file for python-is-python2 this is what I can find:
Commandline: apt purge python-is-python2
Requested-By: tyler (1000)
Purge: python-is-python2:amd64 (2.7.17-4), python-vcstools:amd64 (0.1.42-1), python-dev-is-python2:amd64 (2.7.17-4), python-wstool:amd64 (0.1.17-1)
End-Date: 2021-11-06  18:44:43

The primary reason I posted to discourse is that it seems to have affected everyone here at PickNik over the weekend and wanted to post the answer many people were probably looking for in a really public place.

As I wrote on your Discourse post: the log lines which caused python-is-python2 to be installed (you mentioned an "apt upgrade") would be more interesting.
This just shows you purged the package.

Well, this is awkward.  I can't find that in the logs.  I assumed that was to blame but maybe it was something else that changed that brought this to light (and those packages have been on my system for a long time without creating issues).
It seems Jocken (can't figure out your github account to tag you) found that this issue is fixed here: https://github.com/ros2/rosidl/pull/612  and that the way to get the fix locally is to hack around it not being published yet with:
sed -i 's/PythonInterp/& 3/' /opt/ros/rolling/share/rosidl_adapter/cmake/rosidl_adapt_interfaces.cmake

I'm not sure what changed this last weekend (something in a rolling sync maybe) that resulted in everyone here experiencing this.

As @nuclearsandwich also wrote on Discourse, perhaps a ROS Answers question would be a better place for this.
In any case, it seems attributing this to vcstool, vcstools or wstool seems premature at this point.


[FEATURE] Better menu bar with icons

Detailed description
The Menubar looks too simple, I can make it more interactive by adding icons and other hover effects. Also, for the mobile and tablet view, placing the Get Started button and GitHub icon/social handles of Vibey in the Menubar would make the navbar clean and elegant.
Context
Icons grab users' attention faster than simple text. Adding icons for each menu item in the Menubar would instantly give an idea to users about menu items. Also transferring the Get Started button to the Menubar would give liberty to users to view it or not and also it looks clean and elegant.
Possible implementation
No response
Additional information
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Varghab you can work on this issue.

@Deepu178 I have created the PR, please check.


1695 add empty state component

Closes #1695
Summary

Adds EmptyState component according to the carbon / AI-PAL guidelines

Change List (commits, features, bugs, etc)

Add EmpyState component
Add EmptyState icons for the different types of empty states
Add story for component
Add tests for component

Acceptance Test (how to verify the PR)

View the stories, they should match the design site guidance
checks should pass

In addition, based on guidance from @dianatran18, the actions shouldn't be fully customizable. We should only allow the buttons, not an open ended node/element.

:tada: This PR is included in version 2.141.0-next.46 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.141.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Would you consider a big patch file / pull request?

During my work with jsGrid (currently based off of 1.3), I have modified it to support the following features (order by position in code :p ):

clik on row (anywhere) immediately triggers editing
grid "deleting" propery (same as inserting / updating)
some jqueryUI theming compatibility (header row, icons are jqueryUI "rendered")
inserting & editing reacts to ENTER (commit) and ESC (discard)
custom failCallback for _controllerCall (internal): allows for some special processing when needed
marking errors in the fields when AJAX returns error state (json must contain {field_name: [list of error strings], field_name: ... })
fix for item parameter in .editItem() event handler
added rowById function (though I need to fix this sometime for jsGrid to actually KNOW IDs)
updateItem can take addtitional parameter preventing call of the controller (the controller was called elsewhere)
added "prefix" parameter for fields - allows to prefix field value with a constant (good for fields that are e.g. numeric, but they need a description)
fix for field values: when null or undefined, an empty string is printed, not "null" or "undefined"
NumberField takes additional "min" and "max" parameters which are then passed to the input control
TextAreaField by default creates a textarea with max-height and overflow (they were getting really big when stuffed with 100K of text :)
ControlField modifications: editButton, deleteButton toggles, jqueryUI icons, insert button calls onInsert handler
onInsert, onDelete, onEdit handlers which are triggered before grid goes into the appropriate mode (allows for custom operations, such as dialogs, etc.)
custom fields: Select2Field, SelectmenuField, DateField (also introduces a nice Date.format function), CustomField (calls handlers for each value so each row can have a differend control)

I'm sure I forgot something, but let's say this is the gist of it. Most of the changes are not invasive to your existing code, except the jqueryUI functionality - I wasn't thorough with it so I had to leave your CSS in function which required me to remove your classes. If theming rework were complete, it would mostly be a matter of plugging-in different element classes.
My immeditate plan is to make the grid WAY more powerful with AJAX:

tackle the insane performance issues when 1000s of rows are in the grid (refresh is called way too often)
deferred record loading in seamless mode (only load the record when it comes into view)
other fixes & modifications to make this the grid my customer demand :D

Ok, so why this post:
I would like to contribute back, but until now I was a bit lax in doing that, so I have this huge changeset which is definitely awkward for a pull request, especially since I have seen you released 1.4 in the mean time and I think it also supports onInsert, onDelete, onEdit events (which would definitely conflick with my implementation)
This is the last opportunity for me to try merge my code with yours before I just fork away forever because the changeset would become too big & difficult to merge with trunk every time.
So, if you're interesed in my modifications or plans, how can we make this work together?

First of all thank you for your efforts and sharing all these modifications. Doing a single PR with multiple changes is not the right way. Each change should be done in a separate PR.
Regarding changes themselves it's hard to say, because it's not always clear what stands behind it:

clik on row (anywhere) immediately triggers editing
Not clear what it means. The default behavior is to start editing row on click, and it can be customized with rowClick handler.

grid "deleting" propery (same as inserting / updating)
What does it mean? How can a field can be deleted and the rest part of the row will stay untouched?

some jqueryUI theming compatibility (header row, icons are jqueryUI "rendered")
Not sure about necessity of compatibility with jQueryUI. The component is not a jQueryUI widget, it's just based on jQuery. Thus in the roadmap there is a bootstrap theme and currently I'm working on integration with Angular. So grid should not be that jQueryUI compatible in sense of theming.

inserting & editing reacts to ENTER (commit) and ESC (discard)
Keyboard support is a very good feature. It will go right after Angular integration.
But of course it's share your progress on that

custom failCallback for _controllerCall (internal): allows for some special processing when needed
What is meant by "special processing needs"? Do you have cases that cannot be handled by existing callbacks and controller methods?

marking errors in the fields when AJAX returns error state (json must contain {field_name: [list of error strings], field_name: ... })
Sounds as a little bit adhoc scenario. jsgrid currently supports validation, can it be used in this case?

fix for item parameter in .editItem() event handler
What issue is meant here?

added rowById function (though I need to fix this sometime for jsGrid to actually KNOW IDs)
Id here stands for what? Is it DOM element id? Or data item id?
Not sure about the use case of the method.

updateItem can take addtitional parameter preventing call of the controller (the controller was called elsewhere)
Why onItemEditing and onItemUpdating argument e.cancel cannot do the job?

added "prefix" parameter for fields - allows to prefix field value with a constant (good for fields that are e.g. numeric, but they need a description)
Why not just redefine itemTemplate? It should be fairly easy, like: itemTemplate: function(value) { return "prefix " + value; }. Do you think it makes sense to introduce yet another property for this?

fix for field values: when null or undefined, an empty string is printed, not "null" or "undefined"
Tried quickly with the latest sources and cannot reproduce the bug.
It would be good to know the details, and of course share the fix.

NumberField takes additional "min" and "max" parameters which are then passed to the input control
I believe now we can use validation for this.

TextAreaField by default creates a textarea with max-height and overflow (they were getting really big when stuffed with 100K of text :)
Have you put it in css? Currently there is a minimum styling for content to avoid styles clashing. You never know what will be put inside the cell, so content styling is usually up to developer. But if this is a bug, them it worth the PR.

ControlField modifications: editButton, deleteButton toggles, jqueryUI icons, insert button calls onInsert handler
What does editButton and deleteButton toggles stand for?

onInsert, onDelete, onEdit handlers which are triggered before grid goes into the appropriate mode (allows for custom operations, such as dialogs, etc.)
Why we cannot use onItemInserting, onItemDeleting, and onItemEditing for this?

custom fields: Select2Field, SelectmenuField, DateField (also introduces a nice Date.format function), CustomField (calls handlers for each value so each row can have a differend control)
Additional fields depending on other components cannot be ship with the grid due to new dependencies. But it would be good to share their code and put somewhere in the docs. It's also in the roadmap to create a page with additional fields for different cases on http://js-grid.com.

Regarding performance issue, maybe you could open an issue with an example (in fiddle or anyhow).
Virtual scrolling is also an accepted enhancement, but not for the nearest future.

I believe it's always better to go with the latest version of component to be able to use the latest features and improve the widget itself. We can merge things that make sense and add a value to the component.

"Each change should be its own PR": I know, that's why I asked.

The default behaviour did not work for me, so I had to resolve the row item before actually calling editItem()
grid "deleting", not field "deleting". Setting this option to false disables the deleting button from control field and prevends deleting in deleteItem()
"Not sure about necessity of compatibility with jQueryUI": Well, it seems at least I found it necessary. I'm not saying it should only support jqueryUI theming, only that it should eventually support a plugin that would enable that. I'm not all that profficient with JavaScript, so I don't know how to implement that. However, if you force Bootstrap on me, I will be unable to use that version. Theming should be a plugin, no matter which framework. I just hoped for something I seem to cannot get when I mentioned this.
I don't know what you mean by your answer here. Would a PR be welcome or not?
change no. 6 is the "special processing" meant here
Processing results returned from server doesn't seem an "ad hoc" scenario to me. Client-side validation is fine, but it's the server that always has the final say.
Well, the item parameter to handler was the row, not the data item. The fix fixes this.
In this case it's data item id. This however IS an ad-hoc solution (presumes there's an "id" member in item)
The event handlers are not the way to go in this case because I want to set a row item from elsewhere. The handlers are called as a result and don't know the cause of being called. Like I said: this parameter handles a scenario when the item data was obtained via a different AJAX call (page section with the entire item fieldset where grid only shows a small subset).
Your suggestion for this one is much better. One learns something each day :)
Don't know how you can't reproduce, Currently field itemTemplate returns value as it is. If it is null or undefined, that will be printed as text verbatim.
Maybe so, I have not yet seen validation as my current base is 1.3
No, this was not a bug. I't a matter of preference. I just didn't like rows being that high
editButton, deleteButton booleans when set to false prevent their respective buttons from being created (because their respective actions are being triggered elsewhere).
The handlers you mention are called much later in the process - when the entry is actually completed and the user wants to store the data. These handlers are called before the insertRow / editRow are even constructed and before the delete question is asked.
Agreed, they might be part of optional plugins or something. I do believe though that it would be nice if they were provided somehow to prevent users from reinventing the wheel every time.

about the performance issue: add 100000 rows and call render. I have a<EMAIL_ADDRESS>GHz and it takes a noticeable time. Multiply this by 10 grids I have on the page and you get an unresponsive page. Literally!
Sorry to hear you feel virtual scrolling such an unworthy feature.

I agree that latest code should always be used. However I don't have time to constantly check for new versions of every library. I sync every now and then. This entire question is based on the fact that I just checked and noticed that we both do a lot of development on the grid - each for his own reasons. Those reasons sometimes overlap, mostly they don't. Additionally, regarding some features I definitely need your help with as my expertise is too lacking (jqueryUI theming, change no. 10, for example).
OTOH I need to have some way of maintaining changes which you won't accept as pull requests. The end result should always be an accepted pul request or a possibility to achieve the same thing via a plugin, hopefully not by adding one line to a copied 30-line function. If we reach an agreement here it will mean a more work for me to split all this into 16 pull requests. I'm willing to do it if you're willing to spend some time dealing with my pull requests.

Ok, then we need to see what is worth a PR and what can be done just with the current implementation.
Here is some conclusions, feel free to correct me if disagree:

if default didn't work for, it can be easily redefined - no PR
deletion can be turned off in control field it self (deleteButton: false) - no PR
"Theming should be a plugin, no matter which framework." - completely agree, that's why don't see the point to go for jQueryUI, but maybe I just should see that changes you are talking about - need more details
Basic keyboard support - PR
no PR
There is a plan in the nearest future to support deferred (async) validation, so it won't be client-side only. For the server one, I don't want to put strick format rules here, any implementation and format can be done and handled on the done of controller method calls and handled accordingly. Or you see any limitations? - need more details
Not sure that I understand: editItem accepts both an item or a row - need more details
no PR
parameters can be passed in many ways: in the data item, put in the grid instance, read from outside object, but if you can do a PR we could see what it mean exactly - PR
cannot reproduce with the latest sources, so for now - no PR (unless you can reproduce)
can be easily done with outer css - no PR
editButton and deleteButton are options in control field - no PR
onItemEditing is fired before edit row is created, so issue is solved. For the showing inserting row onOptionChanging callback can be handled for the option inserting - no PR
Yes, so please, share the code of these fields - no PR
Performance issue - not sure that any changes can make the work with 100 000 grid fast (I'm not talking about virtual scrolling here). It's just browsers limitations, that's why we need tricks like partial items rendering and so on. Or you think it's a particular bottleneck in the jsGrid implementation? For me it's an antipattern to put so many data to client, and pageLoading: true for the rescue.
No, I don't say that it's not important, but there are just some stuff that have higher priority (angular integration, keyboard support in particular).

Thank you again for your efforts in making js-grid better.

I estimate that we have some major conceptual differences which will mean a bunch of my PRs getting rejected. That is especially because I know some of my solutions have been only to solve the immediate problem, not present a general solution that would work for every corner case. I can't decide nor guess which ones are worth spending time on and which are not and that makes it very likely that I will be spending hours on a PR, trying to improve the solution, which you will then simply reject.
I have concluded that it is much less work and the same amount of control if I just attach my current version here and you can use a diff tool to merge what is interesting to you. That is what I do when I want to merge with YOUR latest release and it takes ~15 minutes. That vs estimated > 6 hours needed to prepare all the PRs makes a clear winner in my eyes. You decide for yourself.
The ZIP with combined jsgrid & custom fields.

Thanks for sharing you sources. I'll take a look at diff.


Sort Plugins by name

Use case
While developing an add-to-app flutter project, we noticed that the FlutterPluginRegistrant.podspec that's generated locally has a different order of dependencies than the one being generated in CI.  This is causing a diff in the application's Podfile.lock.    I've reproduced the issue using Flutter's example repo here.  This pr also contains a description of which dependencies are arranged differently.
Proposal
Flutter should sort the plugins in the refreshPluginsList before generating the file, similar to how they are sorted in injectPlugins function.

Thanks for reviewing! Closing since the pr was merged 😄

Thanks for reviewing! Closing since the pr was merged 😄


Upgrade to Ember CLI 2.16.1

This project uses semver, please check the scope of this pr:

[ ] #none# - documentation fixes and/or test additions
[X] #patch# - backwards-compatible bug fix
[ ] #minor# - adding functionality in a backwards-compatible manner
[ ] #major# - incompatible API change

CHANGELOG

Updated to Ember CLI 2.16.1

Changes Unknown when pulling c8fda2027ad222b5f2bd87ec9e8515b8ab85d7e8 on juwara0:upgradeEmberCli_2-16-1 into ** on ciena-blueplanet:master**.

👍


subtitle in django should not be unique

django build models have subtitles listed as unique.

fixed in #105


SystemInformer (3.0.6328 8903fe9) crashes and exits, generating dump file

Brief description of your issue
It crashes when switching to the Disk panel.
This doesn't happen every time.
SystemInformer_RFOULTGSXGWMPXV_DumpFile.zip
Steps to reproduce (optional)
No response
Expected behavior (optional)
No response
Actual behavior (optional)
No response
Environment (optional)
Windows 22H2 22621.1413

Fixed in latest nightly 👍


V10 typings: update CardConfig

resolves: #1863
This changeset introduces the following major changes:

Remove CardConfig._getSubmitData as it is no longer present in CardConfig in V10 (as in it is no longer overridden by the implementation, it is of course still part of the base FormApplication).
Retype CardConfig._onFaceControl to return Promise<unknown> instead of Promise<void>. The actual implementation returns either the result of updating the Card objects (which would yield Promise<Card> or more precisely Promise<InstanceType<ConfiguredDocumentClassForName<"Card">>) or the result of Dialog.confirm. The API documentation describes it as returning Promise<any>, which seems unnecessarily open. I am a bit conflicted on whether or not we should return the actual precise types. I feel that it would expose to much of the implementation details. Nonetheless, I do feel that returning Promise<void> is too restrictive.

Thanks for the contribution and sorry it took so long to get around reviewing it.


guide-key breaks query-replace, making replace-string fail with args-out-of-bounds error

On Emacs 26.2 guide-key breaks replace-string as vanilla and anzu commands. Disabling guide-key-mode helps. Guide-key package was abandoned, but I have created issue explaining what is wrong with it anyway: https://github.com/kai2nenobu/guide-key/issues/49
Not sure if you experience this kind of problem. I wanted to chime in to save others from the pain I had to go through: identifying the bad package was not trivial.
If you can reproduce this with replace-string, and disabling it resolves the problem for you too, then I would advise to remove this from the config files as it is being used by, I suppose, many others.
According to the https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31586, it can affect users with Emacs > 24.5.

Closing because no longer using guide-key. :-)
Sorry for not responding earlier. I never saw this error myself.


enhancement: communication related changes required

[ ] all the communication functionality should work based on config file's communication related enabled flag

closing as done


Added the Missing Links

Fixes #1468
Changes:
Converted plain text to hyperlinks in https://p5js.org/examples/interaction-arduino-sensor-data-via-webjack.html . I found a similar issue in https://p5js.org/examples/simulate-penrose-tiles.html and fixed that too.
Screenshots of the change:

@limzykenneth Thanks for reviewing it. I have made the required changes.

Looks good. Thanks!


Auto-deployment bug

I got this message when adding a server when there were no allocations added on the node:
An unhandled exception occured while attemping to add this server. Please try again.
Stack trace:
https://pastebin.com/raw/GEeABTUt

Your stack trace has disappeared, can you please provide a new one otherwise I will have to close this bug report.

Please use https://hastebin.com so it doesn't disappear.

Sorry, I don't have it anymore.
I'm sure it could be reproduced though.
Regards.
---- On Sun, 18 Jun 2017 10:48:59 +0200<EMAIL_ADDRESS>wrote ----
Please use https://hastebin.com so it doesn't disappear.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


[feat]: conditional formatters

I'd like to run prettier if and only if the current project has a prettier config (.prettierrc or prettier in package.json)
prettier.nvim has an option for this https://github.com/MunifTanjim/prettier.nvim#setting-up-prettiernvim
prettier.setup({
  ["null-ls"] = {
    condition = function()
      return prettier.config_exists({
        -- if `false`, skips checking `package.json` for `"prettier"` key
        check_package_json = true,
      })
    end,
    runtime_condition = function(params)
      -- return false to skip running prettier
      return true
    end,
    timeout = 5000,
  }
})

I adapted MT's code in my dotfiles

Here is an example of how you can do it.


add a publish workflow

add a publish github action.

give github action the read and write permission in repo settings
run workflow manually, input version here

a release draft with .ccx and .zip will appeared here. Edit it and finish publish

Thank you, I've merged it in ad4fcfa7dff7af04e5d77cfec1d3af382dedcb08


MultiZarrToZarr speed improvements

Opening an issue so we can discuss processing time for MultiZarrToZarr. I'm running with the following code:
mzz = MultiZarrToZarr(
    json_list,
    remote_protocol='az',
    remote_options={
       'account_name' : 'goeseuwest'
    },
    xarray_open_kwargs={
        'decode_cf' : False,
        'mask_and_scale' : False,
        'decode_times' : False,
        'use_cftime' : False,
        'decode_coords' : False,
    },
    xarray_concat_args={
        "data_vars": "minimal",
        "coords": "minimal",
        "compat": "override",
        "join": "override",
        "combine_attrs": "override",
        "dim": "t"

    }
)

mzz.translate('combined.json')

Running mzz.translate() takes upwards of 40 minutes on a list of 144 reference jsons, which were generated with inline_threshold=300. It looks like a good chunk of the time is divided between to_zarr() and split().

I've attached the profile file here as well, which can be visualzed with snakeviz ./multizarr_profile.
multizarr_profile.zip

posixpath.split is being called 391721185 times! How many chunks are there here? Event dask.optimize takes a decent while. Sure we could stick an lru-cache around split, but something else is going on here.

I think it's just 1 chunk per file? At least that seems to be what xarray is treating it as. But one of the jsons lists a variable as having chunks : [226, 226]. I'll attach a zip of all the jsons I'm trying to combine.
combined.zip

Each JSON has 17,217 references.
An example data variable, and there are many of these:
In [20]: ds.CMI_C02.data
Out[20]: dask.array<xarray-CMI_C02, shape=(5424, 5424), dtype=float32, chunksize=(226, 226), chunktype=numpy.ndarray>

has 576 chunks, 200kB each. This is tiny! If you were to actually do any analysis on this data, you would have to specify a much larger chunksize to dask in order not to completely swamp the scheduler.

That would explain why I was having problems actually doing analysis on it 😆
Can we specify a chunk size with xarray during initial individual json creation? I'm guessing this would also speed up the MultiZarr creation

Can we specify a chunk size with xarray during initial individual json creation

No, xarray is not actually reading the data at this point (except some specific coordinate arrays), it's reading the metadata pieces that take so long. We could probably do something smart about the caching of bytes blocks, but the access pattern of scanning through the file seems to be unique to each HDF data provider.
The end goal is to have the scanning done in the cloud, close to the data - that's what pangeo-forge is all about. Maybe the problem will go away.

Gotcha, so my understanding is that as things stand right now there's no easy solution to making this process faster at the moment. That's fine with me, what I'm looking to show off is the speed of opening a dataset for analysis with existing references already created. I should be able to specify a larger chunk size in xarray when I do an xr.open_dataset on a fsspec mapper, correct?

Exactly right - there is little getting around the upfront cost of creating the references, but analysis will be faster as a result for downstream users.

.. running with the following code:
mzz = MultiZarrToZarr(
    json_list,
    remote_protocol='az',
    remote_options={
       'account_name' : 'goeseuwest'
    },
    xarray_open_kwargs={
        'decode_cf' : False,
        'mask_and_scale' : False,
        'decode_times' : False,
        'use_cftime' : False,
        'decode_coords' : False,
    },
    xarray_concat_args={
        "data_vars": "minimal",
        "coords": "minimal",
        "compat": "override",
        "join": "override",
        "combine_attrs": "override",
        "dim": "t"

    }
)

mzz.translate('combined.json')

This syntax is still all valid, right ? Asking because, and despite reading the docstrings, there is no full example (if I am not wrong) on how to use the kwargs for xarray. Would here, for example, using use_cftime suffice or is still then the following needed ?
        multi_zarr = MultiZarrToZarr(
            input_references,
            remote_protocol="file",
            concat_dims=["time"],
            identical_dims= ["lat", "lon"],
            coo_map={"time": "cf:time"},
            out=output,
        )

No, we don't use any direct xarray kwargs - MultiZarrToZarr doesn't use xarray to infer anything


feat(Compiler): Add file removal tracking in watch-run

What kind of change does this PR introduce?

[x] Feature

Did you add tests for your changes?

[x] Yes

Does this PR introduce a breaking change?

[x] No

What needs to be documented once your changes are merged?

Fixes #5072

That watchRun now exposes removed files.

Thanks


In the docker compose setup tutorial, reverse_hash doesn't exist anymore

From @bienehito

The task-standard/examples/reverse_hash task family is no longer in the vivaria repo

count_odds is the only example available (but the default modular-public gpt-4o agent isn't runnable on it except in interactive mode because it allows full internet).
We should change the docs to use count_odds, and we should use a different task so the modular-public agent is by default runnable on count_odds.

#638


Suggestion: Generate for all characters at once

When you get a new or upgraded artifact often times it can be an upgrade for multiple characters
Currently the process is;
You select your highest priority (favorite character) first and re-run the optimization target to see if they want that artifact
Then you go down your list of importance until you find a character that wants it
I propose a "Generate All" option that is based on your build settings across all characters (or an op-in selection of characters)
It would then provide a list of all characters that can benefit from the new artifact(s) and show a comparison of the damage increase on each optimization target - something like this:

You would then select which character you feel benefits the most from the new artifact and re-run the "Generate All" to see if the newly freed up artifact(s) will now be the best option for others
This would then slowly shuffle/filter the artifacts down until everyone has their "new best" option and the list is empty
I understand that "Generate All" could be a taxing process. But a correctly filtered build setting page (main stats, priority list etc) usually only takes half a second to 2 seconds to complete - so even if you opted 20 characters into this list one optimization run would only take 30 seconds to minute

Implementation wise:

Hard to strip out the build from the build tab,
very hard to make a new UI that does this, and display coherent information
Characters are not designed to be able to be optimized in serial, but in isolation.(conditionals locked to context, characters are not detached from the team, assumptions for one build dont necessarily carry over to all future builds)

UX:

Saves a few clicks, but actually increases overall workflow, while obscuring what its actually doing, and the end-user has less control over the results.
Interdependencies between characters will make this really difficult to be a predictable feature.


Recipe Compile Error in /var/chef/cache/cookbooks/compat_resource/libraries/autoload.rb

We are running on Chef 11.8.2 and getting below error. We can't upgrade chef version due to some internal reasons. Can you please suggest me compatible version which can work with Chef 11.8.2 ?
Recipe Compile Error in /var/chef/cache/cookbooks/compat_resource/libraries/autoload.rb
This resource is written with Chef 12.5 custom resources, and requires at least Chef 12.0 used with the compat_resource cookbook, it will not work with Chef 11.x clients, and those users must pin their cookbooks to older versions or upgrade.

@sarikav1986 I ran into a similar issue. The main culprits for me were apt and build-essential.
Make sure they're at versions prior to the compat_resource inclusion, so in my case, 'apt', '~> 3.0.0' and 'build-essential', '~> 3.2.0'. ohai may also be causing a problem so check on that too.
If those aren't you're specific problem cookbooks, just compare your run list against the list of cookbooks that have it as a dependency. It might take a while, but it's the only sure fire way I know.
As an aside, make sure you change the version on your envrionment for the relevant cookbooks if you have them locked down. I forgot about this, and had to scratch my head for a while trying to figure out what the issue was!

@gbish Thanks a lot for help, Yes I figured that out latter and was able to fix by fixing versions of 'apt' and 'build-essential'.

Even facing same problem, Is something wrong
cookbook 'jenkins', '= 2.4.0'
cookbook 'iptables', '= 1.1.0'
cookbook 'apt', '~> 3.0.0'
cookbook 'build-essential', '~> 3.2.0'


Bug: table can't be copied when only table is present

Lexical version: 0.16.1
A table doesn't get copied to the clipboard when there is only one table as content.
Steps To Reproduce

Visit https://playground.lexical.dev/
Insert a table using the Insert dropdown.
Delete the paragraph nodes, above and below the table.
Press Cmd+A to select the table.
Press Cmd+C to copy the table.
Press Backspace to delete the table.
Press Cmd+V to trigger the paste action.

Expected: I should see a table on the editor.
Actual: I see random text pasted from the clipboard that I had copied before.
https://github.com/user-attachments/assets/9c0e1447-2fb2-428a-a478-6b08927e0fbd

I can't reproduce this, probably fixed by one of the recent table refactors such as #6889


patient/obs widgets don't interact well with the rest of slicer

Currently (and this is referring to display-patient-and-observation branch) if we switch to the FHIRReader module then the current layout is replaced by the layout that shows the patient/obs widgets. If I then want to use the slice views then I can do that by changing the layout, e.g. View -> Layout -> Four-Up. Once I do that there seems to be no way to get the patient/obs widgets back, not even by switching out of and back into the FHIRReader module. There are really two issues here:

(Broken behavior) If we switch into FHIRReader module then change the layout manually, then there's seems to be no way to recover the FHIRReader module's initial layout.
(Inconvenient behavior) If we switch into FHIRReader module then our layout is replaced, but switching out of FHIRReader module doesn't revert the layout to what we had before. That's a bit annoying. Not sure how to deal with it.
a. I wonder if we can switch to something more like how the DICOM browser works, where it just lets you toggle between viewing a dicom data display widget versus the usual underlying layout on the right side.
b. Probably this is not the first time someone deals with this so it's worth looking into other solutions before complicating things too much.

Layout documentation might help somewhere: https://slicer.readthedocs.io/en/latest/developer_guide/mrml_overview.html#layout

Got some advice that can help us here (thank you @sjh26 and @jcfr):
The ScriptedLoadableModuleWidget has a setup function where we are currently setting up the widgets, and this causes problem (1) above because setup is just called once when you enter the module for the first time.
There are also enter and exit functions which are called when you switch into and out of the module respectively.
If we move our layout initialization into the enter function then this should solve problem (1).
If we also record the current layout ID in enter then we should be able to revert to the previous layout in exit. This would solve (2).

If we did want to do something more like what's in the dicom browser...
https://github.com/Slicer/Slicer/blob/9fae00686d071642a74b57a2e9cd2280aeccc177/Modules/Scripted/DICOM/DICOM.py#L787
That's the function that gets called when you toggle this "show dicom database" button:

I'm not fully understanding how this works but it's a place to start looking

If we are able to save the FHIRReader layout (based off 3rd comment it should be possible), what do we gain by going the DICOM browser route? The main advantage I can see is when the reader starts interacting with DICOM images (in this case, we have table view and then normal slicer view for images).

The DICOM browser, I think, seems to not do the hacky thing we are doing in which we grab a vtkMRMLPlotViewNode and inject our own stuff into it. But IDK if this matters. Feel free to ignore the dicom browser approach for now, I just wanted to include a note on it in case we later decide that we need that approach.


Getting "lint-staged requires at least version 6 of Node, please upgrade" with Node 10

I'm trying to commit some changes for a (possible) PR, but I can't commit due to the pre-commit script running lint-staged which gives me this error:
husky > npm run -s precommit (node v10.1.0)

lint-staged requires at least version 6 of Node, please upgrade

husky > pre-commit hook failed (add --no-verify to bypass)

I didn't want to do a --no-verify in case I'm missing something.
Is there something I should be doing after forking the project?

Thanks, related to okonet/lint-staged#432, PR is comming.

Please grab the latest changes from master, should work fine now.


The binding properties defined for springCloudBusOutput binding take no effect

Describe the bug
I am using the spring-cloud-bus version 3.0.0-RC1.
When a message is sent through the bus, the binding properties defined with the namespace 'spring.cloud.stream.bindings.springCloudBusOutput' take no effect.
It is due to the implementation of StreamBusBridge, as it is sending the message directly to the bus destination
this.streamBridge.send(properties.getDestination(), MessageBuilder.withPayload(event).build());

instead to the bindingName, as is stated in the spring-cloud-stream StreamBridge documentation.

Do you have the same issue in 3.0.0?
/Cc @olegz

Yes, in 3.0.0 is the same.
Just for clarify. The following link to the spring-cloud-stream documentation Using StreamBridge specifies that the first argument for the StreamBridge should be the binding name, instead of the destination. In this manner, it knows how to link the binding properties to this output.
Apart from that, I think that is also necessary to link the binding with the bus destination setting the next property:
spring.cloud.stream.bindings.springCloudBusOutput.destination=${spring.cloud.bus.destination}
The same that spring-cloud-bus does for the input in the BusEnvironmentPostProcessor.

I'm fairly positive I did this with @olegz's blessing. I'll wait for him to chime in.

I'm fairly positive I did this with @olegz's blessing. I'll wait for him to chime in.

Transferring it to s-c-stream as it is clearly unrelated to s-c-bus

Transferring it to s-c-stream as it is clearly unrelated to s-c-bus


UFS-WM regression test failures: spack stack PR #1707

Describe the bug
Reproducibility problem was found during the regression test with https://github.com/ufs-community/ufs-weather-model/pull/1707

Experiment results are not reproducible in the regression test runs to check B4B comparison after creating baselines for cpld_2threads_p8_intel, cpld_mpi_p8_intel, cpld_bmark_p8_intel, hafs_regional_docn_oisst_intel
Experiments run ok but results are not identical in the second run of the experiment

To Reproduce
Steps to reproduce the behavior: create baseline for those cases and run the regression test on Gaea: e.g. ./rt.sh -c -e -a [account name] and ./rt.sh -m -e -a [account name]
Expected behavior
A clear and concise description of what you expected to happen. nccmp result shows difference in fields
Jong.Kim@gaea10:/lustre/f2/pdata/ncep/Jong.Kim/rt-1707/tests/logs$ nccmp -d -S -q -f -g -B --Attribute=checksum --warn=format  /lustre/f2/pdata/ncep_shared/emc.nemspara/RT/NEMSfv3gfs/develop-20230807/hafs_regional_docn_oisst_intel/sfcf006.nc /lustre/f2/scratch/Jong.Kim/FV3_RT/rt_39997/hafs_regional_docn_oisst_intel/sfcf006.nc
Variable      Group   Count          Sum      AbsSum          Min         Max       Range         Mean      StdDev
acond         /      624432    -0.813792     77.8705    -0.033305   0.0246161   0.0579211 -1.30325e-06 0.000420176
albdo_ave     /         144    0.0202661    0.306048   -0.0882874    0.120814    0.209102  0.000140737   0.0128115
cduvb_ave     /         195  6.97528e-08 4.56946e-07 -2.71248e-08 4.27826e-08 6.99074e-08  3.57707e-10 5.75421e-09
cnwat         /       83295     -18.2661     340.479         -0.5    0.499961    0.999961 -0.000219294   0.0264393
cpofp         /         128     -3.78541      14.625     -0.86563    0.740301     1.60593   -0.0295735    0.225738

System:
What system(s) are you running the code on? Gaea and we suspect similar behavior happening on Acorn as well
Additional context
Add any other context about the problem here. We didn't see any problem when we merge in the latest library update PR https://github.com/ufs-community/ufs-weather-model/pull/1745. A suggestion is to revert the jasper and zlib updates and set exactly same library option as current UFS-WM develop and start debugging from there.

I'm currently exploring this on Gaea using the cpld_2threads_p8 case. I tried reverting a number of libraries, including jasper+zlib, to no avail. Interestingly, when I swap out a number of libraries for hpc-stack ones, I can get my cpld_2threads_p8 results to match cpld_control_p8 baseline results based hpc-stack (20230804). I'll keep updating here as I find out more.

As a general observation, the main differences between spack-stack and hpc-stack are:

jasper and zlib versions (I don't think this is it but @ulmononian is going to look deeper at this)
in spack-stack on Gaea, everything is built with cray wrappers, whereas with hpc-stack, only the MPI-based libraries are; all the non-MPI libraries are built with icc/ifort
spack sets different defaults for some (relatively) obscure cmake options. In the past this has impacted one or two libraries that behaved differently between CMAKE_BUILD_TYPE=Release and CMAKE_BUILD_TYPE=RelWithDebInfo (where the latter is the spack default, though it can be changed)

I have not been able to find any difference in terms of which packages are built with OpenMP support, which seemed like a logical thing to check based on the inconsistency between the cpld_control_p8 and cpld_2threads_p8 cases.

I can get the cpld_2threads_p8 test on Gaea to successfully match against the hpc-stack (20230804) baseline results if I swap the hpc-stack esmf library into my spack-stack installation but leave everything else exactly the same. For what it's worth, the references in libesmf.a to other libraries (NetCDF, PIO) are identical between the spack-stack (failing) and hpc-stack (succeeding) version of the library, and in my test that passes, I'm linking entirely against the spack-stack versions of NetCDF and PIO, so long story short, I'm pretty confident the problem is with the build of the ESMF library itself and not its dependencies. Looking at the libesmf.a symbols (nm output), I can see some differences in debug info, and Spack inserts a lot of its own build options like CPU arch targets and such, so I suspect the issue at least for cpld_2threads_p8 lies in some subtle but critical difference in the build settings (not all of which are necessarily visible in the build logs on account of cray and spack wrappers and their use of environment variables, so, yeah that'll be fun).

I've got cpld_2threads_p8 running successfully on Gaea with a pure spack-stack installation by making just a couple of build setting changes to ESMF. The most critical ones appear to be adding "-fp-model strict" to the F90 and CXX flags; I also fiddled with a few other settings so I'll keep testing to make sure that the "-fp-model strict" change is the only tweak needed. If that does it, then we should either update our spack-stack configuration (use fflags="-fp-model strict" cxxflags="-fp-model strict for intel version of ESMF), or add a variant (variant("fpstrict", default=False, when="%intel").

I've got cpld_2threads_p8 running successfully on Gaea with a pure spack-stack installation by making just a couple of build setting changes to ESMF. The most critical ones appear to be adding "-fp-model strict" to the F90 and CXX flags; I also fiddled with a few other settings so I'll keep testing to make sure that the "-fp-model strict" change is the only tweak needed. If that does it, then we should either update our spack-stack configuration (use fflags="-fp-model strict" cxxflags="-fp-model strict for intel version of ESMF), or add a variant (variant("fpstrict", default=False, when="%intel").

Sounds like progress!

Solved. I can get these RTs to match the hpc-stack-based baseline data by adding -fp-model precise to ESMF's F90 and CXX flags, as well as setting MAPL's CMAKE_BUILD_TYPE to Release (rather than Spack's default RelWithDebInfo). I'll create separate issues for the longterm fixes, so let's wait to close this issue until we have the ufs-pi-2.5.10 environments updated.

Awesome!

The ufs-pio-2.5.10 environment is now also available on S4 with the modifications from Alex described above. I don't know if the ufs-pio-2.5.10 environments were rebuilt according to those instructions on the other platforms, since I was out on vacation.

the tests reported here by @jkbk2004 now pass (each test was compared against a baseline created with spack-stack PR 1707 w/ alex's test stack with the esmf/mapl fixes). @climbfuji i think we can go ahead and perform alex's modifications as described in his email for all machines w/ the ufs-pio env.
RegressionTests_gaea.log

@climbfuji https://github.com/JCSDA/spack-stack/issues/712

@jkbk2004 @climbfuji  since these tests now pass on gaea c4 in a spack-stack - spack-stack comparison, can we close this issue?

The UFS transitioned to spack-stack two weeks ago after @AlexanderRichert-NOAA and @ulmononian figured out the b4b reproducibility issues. We can close this issue as completed.


💅 FileReaderSync Variable is undeclared

Environment information
CLI:
  Version:                      1.6.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.11.1"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "bun/1.0.30"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Linter:
  Recommended:                  true
  All:                          false
  Rules:                        a11y/recommended = true
                                complexity/recommended = true
                                complexity/noStaticOnlyClass = "off"
                                complexity/useSimplifiedLogicExpression = "warn"
                                correctness/recommended = true
                                correctness/noUndeclaredVariables = "error"
                                performance/recommended = true
                                style/recommended = true
                                style/useBlockStatements = "error"
                                style/useCollapsedElseIf = "warn"
                                style/useNamingConvention = {"level":"error","options":{"strictCase":false,"enumMemberCase":"CONSTANT_CASE"}}
                                style/useShorthandArrayType = "error"
                                style/useShorthandAssign = "error"
                                style/useSingleCaseStatement = "error"
                                suspicious/recommended = true
                                suspicious/noApproximativeNumericConstant = "error"
                                suspicious/noMisrefactoredShorthandAssign = "warn"

Workspace:
  Open Documents:               0

Rule name
lint/correctness/noUndeclaredVariables
Playground link
https://biomejs.dev/playground/?lintRules=all&code=YwBvAG4AcwB0ACAAbgBvAHIAbQBhAGwAUgBlAGEAZABlAHIAIAA9ACAAbgBlAHcAIABGAGkAbABlAFIAZQBhAGQAZQByACgAKQA7ACAALwAvACAAVwBvAHIAawBzAAoAYwBvAG4AcwB0ACAAcwB5AG4AYwBSAGUAYQBkAGUAcgAgAD0AIABuAGUAdwAgAEYAaQBsAGUAUgBlAGEAZABlAHIAUwB5AG4AYwAoACkAOwAgAC8ALwAgAEYAbABhAGcAcwAgAGEAbgAgAGUAcgByAG8AcgAKAAoA
Expected result
It should not flag an error, the FileReaderSync API is only available on Web Workers but it still exists after all.
Code of Conduct

[X] I agree to follow Biome's Code of Conduct

@Conaclos I'm not sure this should be a bug. The API is not always available unless the JS file js executed in a worker context. How can Biome help here, considering the current infrastructure?
I think it makes more sense to use overrides, and declare a global for that single file

@ematipico If it doesn't make sense then I will do what you say, just to extend a bit the issue, the function importScripts doesn't get recognized either. Just for you to know, in case you decide it to fix it.

@Conaclos I'm not sure this should be a bug. The API is not always available unless the JS file js executed in a worker context. How can Biome help here, considering the current infrastructure?
I think it makes more sense to use overrides, and declare a global for that single file

Yes. However, we could also claim that browser globals are not always available (for example in the backend) and Node globals are not always available (for example in a browser or in Deno).
We should certainly look for a way of declaring/detecting environments.

[!IMPORTANT]
In both cases it stops being flagged as an issue if you prepend self to the importScripts, like self.importScripts and  new self.FileReaderSync()

@ematipico If it doesn't make sense then I will do what you say, just to extend a bit the issue, the function importScripts doesn't get recognized either. Just for you to know, in case you decide it to fix it.

Thank you for your answer. My comment was a way to start a conversation and understand what's the best way to fix it. Probably it came off wrong. Sorry about that.
My suggestion is a workaround, so you don't need to wait for a fix for that.
@Conaclos you made a good point. It's possible that our globals are outdated

@ematipico Oh I didn't mean anything with what I said! I actually meant that if you said that it didn't make any sense then I would do what you said, and I already did! I apologize if it came off wrong too, I am not a native English speaker so it was probably not formulated very well.
What I meant with "in case you decide to fix it" it's because from your initial comment I understood that the issue could have been expected behaviour, and I wasn't sure if you were going to fix it or not.

For anyone that wants to fix the issue, we should port this:
https://github.com/sindresorhus/globals/blob/9e2e2598dabdb845ff76c0c3acf5c52c812a64de/globals.json#L1443-L1726
In here:
https://github.com/biomejs/biome/blob/main/crates/biome_js_analyze/src/globals/mod.rs
Just create a new worker.rs file and follow the same pattern of the other files in that folder.
Then add a new check in here:
https://github.com/biomejs/biome/blob/7a4f9e27b5b64dc9c976d6b446c23019e521f279/crates/biome_js_analyze/src/semantic_analyzers/correctness/no_undeclared_variables.rs#L94

I think we already have worker globals defined in browser.rs
https://github.com/biomejs/biome/blob/7a4f9e27b5b64dc9c976d6b446c23019e521f279/crates/biome_js_analyze/src/globals/browser.rs#L926

Look at that :D it seems we aren't using it, that will be even more simple!

I'd like to work on this. I plan to update the globals and also fix the rule.


Report Python errors in a log panel

We should show a logs panel somewhere in the GUI, showing all Python errors that could occur.

It's possible that the log panel that shows up when there is an error in the Notebook widget kernel already works for glue-lab:

In that case we can probably close this issue.

Indeed this log window works with the kernel of a glue session too.


add global @testset

Could we add global @testset wrapping all @testset so that if some tests don't pass one gets to see how the others went anyway?
I ask because for example I work woth WSL and the liveview test can't work here so I have to add the global @testset locally

Will we still get detailed information about which tests didn't pass then? Sounds like you double checked that this solution works for you, right?

Yes, it throws error even if just one fails and you still get the stack trace for each. The only difference is that it throws the error at the end and you get a report even for those tests that are after a failing one

Sounds reasonable to me thanks for clarification

Ok nice, I will make a PR soon!


support for federated login

adding support to use cognito's federated login would be amazing.

Let me clarify we have Cognito working with federation and federation is creating users in the Cognito User Pool correctly but login is not working.
I have also altered the Authenticator function passing it the Social login providers, but login does not render it.

You will need to update/import the Amplify auth component to use federated login, as described here: https://docs.amplify.aws/lib/auth/social/q/platform/js/

update is simple and builds fine, and Test Your Hosted UI Endpoint link works as expected. The issue is "login to existing account" does not bring up the federated login option to click through.

Got it. I have added your request to the "features to be considered" list, thx for the input.

Will not implement, this would extend the current scope of the project too far


Make cargo-miri not link against librustc (through libmiri)

Why is cargo-miri so big? 4.4 MiB for what should be a tiny wrapper seems excessive. miri itself is just 2.2 MiB!

Below are some sizes after compiling cargo-miri with lto, opt-level s, and using strip for debug symbols. All built with --release.
    4.3 MiB [##########]  cargo-miri-opt-level-s
    4.3 MiB [######### ]  cargo-miri
    2.7 MiB [######    ]  cargo-miri-lto
    2.7 MiB [######    ]  cargo-miri-lto-opt-level-s
  776.0 KiB [#         ]  cargo-miri-strip
  744.0 KiB [#         ]  cargo-miri-opt-level-s-strip
  692.0 KiB [#         ]  cargo-miri-lto-strip
  640.0 KiB [#         ]  cargo-miri-lto-opt-level-s-strip

Thanks for the analysis!
I think what is happening is that libmiri gets linked into cargo-miri. Not sure if that can be avoided easily, probably we'd need to use a workspace and make it a separate crate that doesn't depend on all the miri stuff.

Turns out that even breaking this dependency doesn't actually make the binary any smaller. Looks like the linker does indeed remove almost all of the cruft...
https://github.com/rust-lang/miri/pull/1422 does the workspace porting anyway, but I'll close this size issue as there does not seem to be much we can do.


Add service monitor API version override

This feature enables users to override the Service Monitor API version if they are using Azure managed prometheus which uses azmonitoring.coreos.com/v1 instead of the default monitoring.coreos.com/v1.

@cla-bot check

Thanks @nineinchnick for your review! Commits sqaush and prefix removed.


Use the GitHub user / organization name in ClearlyDefined source locations

Please have a look at the individual commit messages for the details.

For an example of a ClearlyDefined data PR created with these changes see https://github.com/clearlydefined/curated-data/pull/4134.


Need Only country and state in country.json

Is your feature request related to a problem? Please describe.
the huge size of the file and huge build for application
Describe the solution you'd like
remove the city from the country.json

Agreed that removing the cities would be really helpful. It's a really large file.
Especially because keeping the list of cities up to date seems insanely difficult. I searched for some cities in my geographic area and they weren't on the list, which made me immediately hide the cities dropdown and put in a separate city form field where the user can type in their city directly.
If the cities portion was a separate package that had a dependency on the country/state dropdown then developers would have the option of either!


KeyPass does not securely handle credential storage

Describe the bug
Hi there, always great to see more Apps making use of F-Droid! I thought I'd take a quick look due to the popularity.
I believe KeyPass in it's current status does not meet the security standards of other password managers or the recommendations by organisations such as OWASP and MITRE. This project should probably contain a warning on usage and details on encryption mechanisms so users can make an informed choice on on how their sensitive data is protected.
Issues

The current database (storing passwords) and shared preferences (storing the login password) are are not encrypted and thus accessible in plaintext to potential attackers without logging in.
Database backups use a static IV of: private val iV = byteArrayOf(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0) and when encrypted this results in a more predictable and potentially vulnerable exported backup.

To Reproduce
Steps to reproduce the behavior:

Download source code.
Build and then run on an emulator or real device with debugging enabled.
Open KeyPass then create a password to access.
Create a few example accounts.
Run adb shell "run-as com.yogeshpaliyal.keypass cat /data/data/com.yogeshpaliyal.keypass/databases/KeyPass-wal" > data.db to save the Write Ahead Log file containing the most recent changes to the DB.
cat data.db

Leak of login password

Leak of accounts

Recommendations

Enhance and fix the current storage mechanisms referring to the Android MASTG recommendations: https://github.com/OWASP/owasp-mastg/blob/master/Document/0x05d-Testing-Data-Storage.md

Thanks @BenEdridge for raising this, will address these ASAP

@BenEdridge Security has been improved in the latest version, can you verify once, thanks once again for raising this. ❤

Hi @yogeshpaliyal I've taken a quick look. Much better than before but one issue I raised still remains.
Static IV use (This should be generated with secure random number generator) and stored alongside encrypted data. Then upon upon decryption and utilised during decryption functionality.
common/src/main/java/com/yogeshpaliyal/common/dbhelper/EncryptionHelper.kt
32:    private val iV = byteArrayOf(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)

Additionally, user chosen passwords should be used to derive a secure encryption key using PBKDF2 or Argon2 (Similar to what 1Password and Bitwarden does).
User password -> PBKDF2/Argon2 -> Database Encryption/Database Backup Encryption

Sure will look into this, thanks


refactor: add support for scripts.yaml as a source for scripts

https://github.com/gonuit/rps/issues/23

@gonuit can you please publish a new version to pub.dev then

I will try to do it Today or Tomorrow


Feature request: Notifications on recieving.

Is your feature request related to a problem? Please describe.
I find it tedious that when I send something from my computer, to my iPhone, it doesn't show a notification. When someone else sends me an image, they have to manually tell me, or text me that they sent me something, instead of the app displaying an easy to program in notification.
Describe the solution you'd like
A notification from the app Displaying the type of content (ex. file, photo, text) and the device its recieving from (ex. "HP Computer").
Describe alternatives you've considered
No response
Additional context
It would look something like this

I believe this is not possible right now because LocalSend is not working (properly) in the background

What is the problem and how it could be overcome?

On iOS, you can't have something running 24/7 in the background. iOS is very strict regarding battery usage.
Other apps circumvent this limitation using push notifications triggered from their servers. LocalSend does not have any servers.

This is necessary on all platforms, I am not seeing notifications on desktop either.
LocalSend also doesnt seem to be working in the background on Android, at least for me.


Is Jocko dead now?

Just wondering if this project is dead now since Travis scored a job at Confluent in March? 😛
Lots of commits every day in January, February, and then silence (almost) 😔

Just haven't had a lot of free time. Was away on vacation for a while too. I'd love to get some help with PRs.