[BUG] Volumes showing as detaching even though all workload pods are scaled down

Describe the bug
During our scalability test we found an issue with the longhorn volumes getting stuck in the detaching state.
Even though the workload pods had been scaled down to 0 correctly.
To Reproduce
Not sure below is what I did:
3 control nodes - 100 worker nodes - 100 statefulsets - 1400 volumes total

scale up 0-1400 with steps at 0,1,100,1000,1400
scale down 1400-0 with steps at 1400,1000,100,0

Expected behavior
all longhorn volumes should become detached
Log
suppport bundle + kubernetes logs
Environment:

Longhorn version: 1.0.1
Kubernetes version: 1.18.6
Node OS type and version: Ubuntu 18.04 (ami-0a63f96e85105c6d3)

Additional context
node specs: 8 cpu 32 Gb ram (m5.2xlarge)
3 control nodes - 100 worker nodes - 100 statefulsets - 1400 volumes total

below is a trace for a single volume, Identified one opportunity of improvement already.
Trace for pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685
CreateVolume
2020-07-30T01:45:36.714888324Z time="2020-07-30T01:45:36Z" level=info msg="GRPC request: {"capacity_range":{"required_bytes":1073741824},"name":"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685","parameters":{"baseImage":"","fromBackup":"","numberOfReplicas":"3","staleReplicaTimeout":"30"},"volume_capabilities":[{"AccessType":{"Mount":{"fs_type":"ext4"}},"access_mode":{"mode":1}}]}"
2020-07-30T01:45:36.714902294Z time="2020-07-30T01:45:36Z" level=info msg="ControllerServer create volume req: name:"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685" capacity_range:<required_bytes:1073741824 > volume_capabilities:<mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER > > parameters:<key:"baseImage" value:"" > parameters:<key:"fromBackup" value:"" > parameters:<key:"numberOfReplicas" value:"3" > parameters:<key:"staleReplicaTimeout" value:"30" > "
2020-07-30T01:45:36.715339767Z time="2020-07-30T01:45:36Z" level=info msg="CreateVolume: creating a volume by API client, name: pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685, size: 1Gi"
2020-07-30T01:45:49.020482752Z time="2020-07-30T01:45:49Z" level=debug msg="Polling pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 state for detached at 2020-07-30 01:45:49.02040909 +0000 UTC m=+31917.618015726"
2020-07-30T01:45:49.312074503Z time="2020-07-30T01:45:49Z" level=info msg="GRPC request: {"capacity_range":{"required_bytes":1073741824},"name":"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685","parameters":{"baseImage":"","fromBackup":"","numberOfReplicas":"3","staleReplicaTimeout":"30"},"volume_capabilities":[{"AccessType":{"Mount":{"fs_type":"ext4"}},"access_mode":{"mode":1}}]}"
2020-07-30T01:45:49.312114996Z time="2020-07-30T01:45:49Z" level=info msg="ControllerServer create volume req: name:"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685" capacity_range:<required_bytes:1073741824 > volume_capabilities:<mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER > > parameters:<key:"baseImage" value:"" > parameters:<key:"fromBackup" value:"" > parameters:<key:"numberOfReplicas" value:"3" > parameters:<key:"staleReplicaTimeout" value:"30" > "
2020-07-30T01:45:49.315138723Z time="2020-07-30T01:45:49Z" level=debug msg="CreateVolume: got an exist volume: pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685"
2020-07-30T01:45:49.316217902Z time="2020-07-30T01:45:49Z" level=info msg="GRPC response: {"volume":{"capacity_bytes":1073741824,"volume_context":{"baseImage":"","fromBackup":"","numberOfReplicas":"3","staleReplicaTimeout":"30"},"volume_id":"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685"}}"
// looks like this is the answer to the initial volume creation request --
// that means it took till 01:46:09 for the volume to be created and in the detach state --
// that's also the reason why the first attach fails with attach not being an available action --
// TODO: check Create Volume code to make sure that the volume is detached / ready before returning that the volume already exists
2020-07-30T01:46:09.020561784Z time="2020-07-30T01:46:09Z" level=debug msg="Polling pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 state for detached at 2020-07-30 01:46:09.020449399 +0000 UTC m=+31937.618055986"
2020-07-30T01:46:09.024832714Z time="2020-07-30T01:46:09Z" level=info msg="GRPC response: {"volume":{"capacity_bytes":1073741824,"volume_context":{"baseImage":"","fromBackup":"","numberOfReplicas":"3","staleReplicaTimeout":"30"},"volume_id":"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685"}}"
ControllerPublish
2020-07-30T01:45:57.788180725Z time="2020-07-30T01:45:57Z" level=info msg="ControllerServer ControllerPublishVolume req: volume_id:"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685" node_id:"jmoody-work32" volume_capability:<mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER > > volume_context:<key:"baseImage" value:"" > volume_context:<key:"fromBackup" value:"" > volume_context:<key:"numberOfReplicas" value:"3" > volume_context:<key:"staleReplicaTimeout" value:"30" > volume_context:<key:"storage.kubernetes.io/csiProvisionerIdentity" value:"1596041631859-8081-driver.longhorn.io" > "
2020-07-30T01:45:57.792224755Z time="2020-07-30T01:45:57Z" level=error msg="GRPC error: rpc error: code = Internal desc = Action [attach] not available on [&{pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 volume map[self:http://longhorn-backend:9500/v1/volumes/pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685] map[]}]"
-- kube-controller {"log":"E0730 01:45:57.985920       1 csi_attacher.go:647] kubernetes.io/csi: attachment for pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 failed: rpc error: code = Internal desc = Action [attach] not available on [\u0026{pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 volume map[self:http://longhorn-backend:9500/v1/volumes/pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685] map[]}]\n","stream":"stderr","time":"2020-07-30T01:45:57.985994846Z"}
2020-07-30T01:46:14.585441571Z time="2020-07-30T01:46:14Z" level=info msg="ControllerServer ControllerPublishVolume req: volume_id:"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685" node_id:"jmoody-work32" volume_capability:<mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER > > volume_context:<key:"baseImage" value:"" > volume_context:<key:"fromBackup" value:"" > volume_context:<key:"numberOfReplicas" value:"3" > volume_context:<key:"staleReplicaTimeout" value:"30" > volume_context:<key:"storage.kubernetes.io/csiProvisionerIdentity" value:"1596041631859-8081-driver.longhorn.io" > "
2020-07-30T01:47:07.834744461Z time="2020-07-30T01:47:07Z" level=debug msg="Polling pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 state for attached at 2020-07-30 01:47:07.83460344 +0000 UTC m=+31996.138068496"
2020-07-30T01:47:07.836444744Z time="2020-07-30T01:47:07Z" level=debug msg="Volume pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 attached on jmoody-work32"
--
2020-07-30T01:47:02.450510393Z [pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685-e-2c801bdc] time="2020-07-30T01:47:02Z" level=info msg="Creating device /dev/longhorn/pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 8:64"
2020-07-30T01:47:02.452796921Z [pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685-e-2c801bdc] time="2020-07-30T01:47:02Z" level=info msg="device pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685: SCSI device sde created"
NodeUnpublish
2020-07-30T04:42:48.475669284Z time="2020-07-30T04:42:48Z" level=info msg="NodeServer NodeUnpublishVolume req: volume_id:"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685" target_path:"/var/lib/kubelet/pods/f1ab5467-03bc-4502-9865-15a0b50ce4c4/volumes/kubernetes.io~csi/pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685/mount" "
2020-07-30T04:42:48.484816567Z time="2020-07-30T04:42:48Z" level=debug msg="NodeUnpublishVolume: done pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685"
ControllerUnpublish
2020-07-30T05:06:07.603887212Z time="2020-07-30T05:06:07Z" level=info msg="ControllerServer ControllerUnpublishVolume req: volume_id:"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685" node_id:"jmoody-work32" "
2020-07-30T05:08:05.715092459Z time="2020-07-30T05:08:05Z" level=debug msg="Polling pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 state for detached at 2020-07-30 05:08:05.714601817 +0000 UTC m=+44054.018066887"
2020-07-30T05:08:07.714753581Z time="2020-07-30T05:08:07Z" level=warning msg="waitForVolumeState: timeout to wait for volume pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 become detached"
2020-07-30T05:08:07.714771000Z time="2020-07-30T05:08:07Z" level=error msg="GRPC error: rpc error: code = Aborted desc = Detaching volume pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 failed"
// multiple calls like this only last one shown
2020-07-30T06:04:08.722629306Z time="2020-07-30T06:04:08Z" level=info msg="ControllerServer ControllerUnpublishVolume req: volume_id:"pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685" node_id:"jmoody-work32" "
2020-07-30T06:04:08.728910794Z time="2020-07-30T06:04:08Z" level=error msg="GRPC error: rpc error: code = Aborted desc = The volume pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685 is detaching"
-- kube-controller
{"log":"W0730 05:11:15.382965       1 reconciler.go:206] attacherDetacher.DetachVolume started for volume "pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685" (UniqueName: "kubernetes.io/csi/driver.longhorn.io^pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685") on node "jmoody-work32" This volume is not safe to detach, but maxWaitForUnmountDuration 6m0s expired, force detaching\n","stream":"stderr","time":"2020-07-30T05:11:15.383063464Z"}
{"log":"E0730 05:11:15.579313       1 csi_attacher.go:662] kubernetes.io/csi: detachment for VolumeAttachment for volume [pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685] failed: rpc error: code = DeadlineExceeded desc = context deadline exceeded\n","stream":"stderr","time":"2020-07-30T05:11:15.579406524Z"}
{"log":"W0730 05:15:39.082852       1 reconciler.go:206] attacherDetacher.DetachVolume started for volume "pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685" (UniqueName: "kubernetes.io/csi/driver.longhorn.io^pvc-351fecb9-e9be-4b70-b9dd-2177fce7e685") on node "jmoody-work32" This volume is not safe to detach, but maxWaitForUnmountDuration 6m0s expired, force detaching\n","stream":"stderr","time":"2020-07-30T05:15:39.082961535Z"}

Need to be considered in https://github.com/longhorn/longhorn/issues/2598

Consider this issue as a part of https://github.com/longhorn/longhorn/issues/3083.

https://github.com/longhorn/longhorn/issues/3083 might have already resolved this issue. QA can test this one together with https://github.com/longhorn/longhorn/issues/3083

With 20 nodes and 50 statefulset, I didn't observe the issue. Trying with a bigger cluster.


Add concurrency option for benchmark

Motivation
There could be a load balancer above the server to control the request traffic since the server can't reject requests. This pr can simulate this situation. Code borrowed from https://github.com/vllm-project/vllm/pull/9390

Modifications

add an option --max-concurrency to bench_serving.py
make sure there will not exceed max-concurrency requests coming to the server concurrently

Checklist

[ ] Format your code according to the Contributor Guide.
[ ] Add unit tests as outlined in the Contributor Guide.
[ ] Update documentation as needed, including docstrings or example tutorials.

I'll fix the SimpleNamespace issue cc @merrymercy @cermeng


Maximum time duration for "Offline Mode" (AllowKeyMaterialCaching:$true)

What is the maximum duration of time for "Offline Mode" if Set-HgsKeyProtectionConfiguration -AllowKeyMaterialCaching:$true is configured?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ebf450ef-374e-598a-082b-ab4aa9aa1245
Version Independent ID: 835778b3-c196-66fc-dff9-e3a7d3d51a96
Content: Branch Office Considerations
Content Source: WindowsServerDocs/security/guarded-fabric-shielded-vm/guarded-fabric-manage-branch-office.md
Product: windows-server-threshold
Technology: security-guarded-fabric
GitHub Login: @rpsqrd

Hi @milesgratz,
The lifetime of cached keys is determined by the health state of the host, not real time. You can re-use the cached key indefinitely until the security state of the host changes (under the hood, when the security measurements change, the key encrypting the cached keys is rolled, preventing the keys from being unsealed). The only other event that will invalidate a key is a successful online attestation attempt to an HGS node that is configured to disallow key caching.

Thanks for your dedication to our documentation. If we have been unable to review your issue in a timely manner, we sincerely apologize for the delayed response. We have captured the informtion you have provided for review. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


Add id3.nvim and plantuml.nvim

It looks like there's a conflict, could you please fix and submit again? Thanks!

Done.


[Feature Request] Add ToDo List functionality

I really like this app and I think it would be cool if you could also add to do list type things to it, so e.g. add a one-time task with name, description, deadline and having it also displayed in the app,

Thank your for your suggestion first! However, the purpose of this app's design doesn't align with incorporating a todo tracker-like function. Therefore, there are no plans to add such a feature.
In this case, perhaps a to-do list app would be the most suitable option for you, such as OpenTask, Task.org or simply 'Reminder' on iOS.  😉


Release 0.4.1

By the way, where is the conda feedstock repo for ravenpy?  Just want to put a watch dessus.

@tlvu https://github.com/CSHS-CWRA/raven-feedstock


Transition animation bug

I ran into an issue where the views get drawn incorrectly during transitions.
While swiping:

After swipe is complete:

It can be replicated by changing the ColoredView drawRect: method to:
    override func draw(_ dirtyRect: NSRect) {
        self.backgroundColor.setFill()
        self.bounds.fill()
        let square = dirtyRect.insetBy(dx: 70, dy: 70)
        NSColor.orange.set()
        square.fill()
    }

I've been trying in vain for a while to solve this. Perhaps a bug in the underlying NSPageController?
Any help would be greatly appreciated.

I was able to fix this by using the view bounds instead of the dirtyRect.


Should there be a start:dev script?

After running npx create-remix@latest --template https://github.com/mcansh/remix-fastify/tree/main/example --no-install, per the README we should run npm run dev and npm run start:dev. Should there be a start:dev script? What am I missing here?

sorry about the confusion, the example README is from the express template before i made any modifications, npm run dev is enough, i’ll update the example README in a bit :)

ok great thanks for the clarification


A completely useless documentation

I was searching for how to enable localization in ASP.NET Core Blazor web assembly and came across this official documentation. But after reading this documentation I have found this completely useless. No single instruction of how to enable localization in ASP.NET Core Blazor web assembly. We don't expect such low-quality documentation from Microsoft ASP.NET Core Team.
Look at the following third-party documentation that clearly instructs of how to enable localization in Blazor Web Assembly.
https://code-maze.com/localization-in-blazor-webassembly-applications/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 15e7c51d-1839-1849-813a-23c4d21c64ae
Version Independent ID: d6f07538-228e-9f96-680f-6c324caf11d6
Content: ASP.NET Core Blazor globalization and localization
Content Source: aspnetcore/blazor/globalization-localization.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Thanks for the feedback, @TanvirArjel. I can't speak to this subject to any great degree, as I didn't write this topic and my globalization/localization experience as a dev is limited to a few Xamarin apps that I built something like five years ago (at least). The topic is currently due for a total overhaul on the UE ("user experience") issue. After we discuss it further here, we might close this in favor of tracking the work via that issue. I'll ping for help 🚓🚒🚑 ...............
@mkArtakMSFT @danroth27 How do you want to triage this? I have it on the UE passes issue, but do you want me to overhaul it? It would be time consuming, but I certainly can brush-up on the subject and then tackle it. However, I guesstimate that I wouldn't reach this until post-6.0 GA unless you table other work that I am making great progress with at this time.
cc: @pranavkm

@TanvirArjel ... We just discussed this offline, and the PU ("product unit") agrees that this very bare-bones coverage isn't good enough. We'll overhaul the topic as part of the UE ("user experience") passes that I'm conducting on https://github.com/dotnet/AspNetCore.Docs/issues/19286, and this topic has been placed NEXT 🏃 on the list for an overhaul. I'll get started on it tomorrow (Friday). I'm not really a loc expert, but I'll work out what I can and then Pranav will follow-up on the PR with suggestions for updates. I'll ping u on the PR when it goes up within a week or so depending on the workload. I'm going to close this issue because the work is tracked by #19286.

@TanvirArjel ... I've dug into the UE pass on the topic. Indeed, I see that you mean 👀🙈. This topic only covers how to set the app's culture, not how to localize it, and it's incomplete even at that. If the title were How to set a Blazor app's culture, it might have been fine to add a few additional remarks+examples, but I agree with you that that's not the right way to go here. I'm performing a major overhaul to include ...

Reorganization of the topic: Sections for globalization, setting the culture (both statically at app start and dynamically via a user's selection), and localizing the app with pivots for WASM and Server scenarios.
Fully-working examples for WASM and Server will be provided.
I'm adding helpful cross-links to API resources.

I'm probably not quite half-way through the work. I'll ping u on the PR when it's ready for review, and we can discuss it further with the the PU from there. I'll also ping Hisham Ben Ateya for his input. Hisham is a loc expert and helps us quite a lot with loc docs on the repo.
cc: @marin-bratanov ... Your remarks, Marin, are being addressed by the updates. I'll ping u, too, when the PR is ready for review. Cross-ref: https://github.com/dotnet/AspNetCore.Docs/issues/21619


[Key Vault] Readme improvements

Follow the structure .Net has in the Key Vault READMEs.
Some notes:

Use the same format even for Key Concepts.
Reduce samples, based on the samples of .Net.
Add the serviceVersion section as a sample.

Moved to the October release.

We can safely push this to March.

We can safely push this to March.


Maintainer Selection

Hi guys, if there is no problem, can I be the maintainer for this group? @Pranjal-Srivastava-2023 @JustinJaniszewski

Hi, @poojashresthacode since you were the maintainer for HW5 I think I would like to be the maintainer this time.

It's okay if you want. No worries.


refactor(dataplanes): moves dataplane viz to pick inbounds based on listeners

This PR changes the way we 'find' inbounds to use IP addresses and then the fallout from that change (which means everything is far simpler)
Finding inbounds by listeners/IP
Envoy stats is dot delimited line format but, in our case at least, it can unfortunately also include IPv4 addresses which are also dot delimited, furthermore we can't guarantee we are using IPv4 or even that the 'address thing' we are parsing isn't something like localhost.
We can mostly avoid dealing with any of this by using the cluster name and look in http./tcp. to figure inbounds out (the cluster name for the inbound is always localhost). But in the end doing that has meant adding significant workarounds and even then we found cases where we absolutely had to look in listener. (but we were able to continue to use the cluster name to pick the correct line.
Overall I figured dealing with the IP address thing and just looking in listener. would mean we could remove a lot of the workarounds, plus it it makes much more sense. "Look in listener. for the things that are listening, aka the inbounds"
This new approach does a switcharoo of IP address dot delimiters for ~ in our initial "line to JSON" pass. This lets us reliably use dot delimiters to parse the lines to JSON. We then switcharoo the ~s back to . before we finally return the JSON. Really straightforwards, and I kinda wish I'd just done that originally :shrug:
Other
Following on from the above:

We now pick out inbound lines based on IP address rather than cluster name.
I simplified everything and removed the majority of the additional types I'd added that felt like a hinderance rather than a help.
Removed all the forking based on gateway/data that we had in the nested routes. Both gateways and sidecars have fully fledged 'inbounds' whether those are gathered from the dataplane overview API or from us constructing those from the envoy stats, they are both 'inbounds' and we should try treat them exactly the same (this should help with the work ongoing in https://github.com/kumahq/kuma-gui/pull/2277).

Possibly more desc or inlines to come...

@kleinfreund I add 3 more tiny commits on the end here, I'll merge shortly if I hear nothing back on those.
Worth looking at as I'm using the "tagged anchor" thing here, plus an annoying re-addition of inline-block on some icons, which I would like to avoid having to deal with.


add sharepoint library restore

Description
adds restore boilerplate for sharepoint libraries.
Type of change

[x] :sunflower: Feature

Issue(s)

#1615

Test Plan

[x] :muscle: Manual
[x] :green_heart: E2E

@dadams39 This is ready for a final review.


The OpenBSD displays ? when using vtop.

Hi vtop owner,
Greeting from me!
My OS is OpenBSD, and SSH client is Cygwin. The vtop displays ?:

Is it normal? Or there are issues with vtop/nodejs/Cygwin/OpenBSD?
Thanks in advance!
Best Regards
Nan Xiao

You may want to check your character set/font.

@Eeems
Thanks for your reply! Changing LC_CTYPE to en_US.UTF-8 (Add "export LC_CTYPE=en_US.UTF-8" in  ~/.profile) fix this issue.
Best Regards
Nan Xiao


Add support for CORS headers

Please provide dev environment versions of your system
node -v: v9.2.0
( xmysql requires node >= 7.6.0 )
npm -v: 5.5.1
mysql --version: 5.7
xmysql --version: 0.4.0 (bug is also confirmed with version 0.0.2, the version I initially discovered this in)

Provide steps to reproduce this issue
0. Start xmysql on any database

Open your browser console
Request a page from xmysql (example: await fetch('http://localhost:3000/'))
Observe the request failing because of missing cors headers

Mark issue with suitable label if it is clear what this issue is.
Can't do this as only project members and higher have access to this feature, but I would mark this as "feature", "blocker"

Sorry could not get back any earlier because of a terrible flu - this is a must feature as you have mentioned.

It's just
npm install cors
And
diff --git a/index.js b/index.js
index 0b27c86..217fa69 100644
--- a/index.js
+++ b/index.js
@@ -1,5 +1,6 @@
 #! /usr/bin/env node

+const cors = require('cors')
 const morgan = require('morgan');
 const bodyParser = require('body-parser');
 const express = require('express');
@@ -16,6 +17,7 @@ cmdargs.handle(sqlConfig)

 /**************** START : setup express ****************/
 let app = express();
+app.use(cors())
 app.use(morgan('tiny'))
 app.use(bodyParser.json())
 app.use(bodyParser.urlencoded({

Another option is to handle cors headers by your reverse proxy, because I guess you won't run xmysql later on port 9000. But yeah, for developing, it's much easier when cors is included.

@ferrybig : apologies. This was an easy fix which I couldn't get it in. Thank you for pointing it out.
ps:
xmysql is undergoing interesting changes - very early days yet. Hope something good comes out.

xmysql version 0.4.1 has the fix


UDP packets outgoing from AP

I have a tello quadcopter connected as AP whith IP <IP_ADDRESS> which act as DHCP and set first client to <IP_ADDRESS>.
Tello :

receive command UDP pachets on port 8889 IP <IP_ADDRESS> and reply OK or error;
send telemetry UDP packets on port 8890 IP <IP_ADDRESS> to connected client <IP_ADDRESS> (instructions says to create a UDP server on client listening <IP_ADDRESS>:8890);
sends video stream UDP packets to on port 11111 to connected client <IP_ADDRESS>  (instructions says to create a UDP server on client listening <IP_ADDRESS>:11111);

I am triing to set an ESP8266 between the drone and the phone acting as wifirepeater
With the standard configuration my client has IP <IP_ADDRESS> (esp station has <IP_ADDRESS>).
<IP_ADDRESS><---->ESP STA <IP_ADDRESS> <---> ESP AP CLI <IP_ADDRESS> <---> TELLO DRONE <IP_ADDRESS>
I am able to send commands from client <IP_ADDRESS> to the drone <IP_ADDRESS> at port 8889 but telemetry and streaming packets sent from drone to the client (8890 and 11111) seems don't reach the client. Is there any configuration to trasparently forward packets sent from drone to phone at ports 8890 and 11111?
This is packet capture .pcap (wireshark) when phone is direcly connected to tello
https://drive.google.com/file/d/1xmGxSNjP1M5lHcuhfpnldQ16ZL2WHG8A/view?usp=sharing

same here, i want to extend my wifi with tello drone, i can control the drone but video is not working

same here any solution would be much appreciated


Update docs for Button to not consider count as required

When visiting the documentation for Button, the count prop is marked as required. This is not the case for the component and the docs for Button should be updated to reflect that.

That's odd! It's not required in the types.
Tracing back, looks like it was accidentally marked as required right around v36 (https://github.com/primer/react/pull/2893)


EmptyList: Chibi signals an error

$ chibi-scheme
> ()
ERROR: empty application in source: ()

However, that is not a syntax error -- it's an evaluation error.

Thanks!

However, that is not a syntax error -- it's an evaluation error.

It may be a syntax error in the sense that it isn't part of the grammar of things can be said in the language. However, I agree that it's not a lexical syntax aka read syntax error. Evaluation error may be a less ambiguous term; if you want to change it, go ahead.

It's "an error" :)

Perfect :D


Add jest test for data-size (NEWRELIC-7841)

Overview
Adds jest tests for the dataSize function. Also adds some comments.
Note, there are no existing "browser" tests to replace.
Related Issue(s)
NEWRELIC-7841
Testing
npm test src/common/util/data-size.test.js

Codecov Report

Merging #487 (1124f71) into main (4f562a7) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
+ Coverage   12.49%   12.77%   +0.27%
==========================================
  Files         121      121
  Lines        3969     3969
  Branches      989      989
==========================================
+ Hits          496      507      +11
+ Misses       2729     2723       -6
+ Partials      744      739       -5

Impacted Files
Coverage Δ

src/common/util/data-size.js
100.00% <ø> (+100.00%)
:arrow_up:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Verifier Results with empty notices

When implementing the compatibility suite, I came across the following scenario (ref)
  Scenario: Verifying an interaction where a provider state callback is not configured
    Given a provider is started that returns the response from interaction 1
    And a Pact file for interaction 1 is to be verified with a provider state "state one" defined
    When the verification is run
    Then the verification will be successful
    And a warning will be displayed that there was no provider state callback configured for provider state "state one"

It requires checking that a warning is displayed, which to my knowledge, is difficult to do through the FFI. When logging is enabled, the FFI does emit the correct warning:
WARN ThreadId(01) verify_interaction{interaction="interaction 1"}: pact_verifier::callback_executors: State Change ignored as there is no state change URL provided for interaction

However inspecting the logs requires logging to a buffer, and would fail if logging to stderr is configured for example.
Inspecting the verifier results, there is a notices key, though it appears to be empty:
{
  "errors": [],
  "notices": [],
  "output": [
    "\nVerifying a pact between \u001b[1mconsumer\u001b[0m and \u001b[1mprovider\u001b[0m",
    "",
    "  interaction 1 (0s loading, 159ms verification)",
    "     Given state one",
    "    returns a response which",
    "      has status code \u001b[1m200\u001b[0m (\u001b[32mOK\u001b[0m)",
    "      includes headers",
    "        \"\u001b[1mContent-Type\u001b[0m\" with value \"\u001b[1mapplication/json\u001b[0m\" (\u001b[32mOK\u001b[0m)",
    "      has a matching body (\u001b[32mOK\u001b[0m)",
    "",
    ""
  ],
  "pendingErrors": [],
  "result": true
}

and I am left wondering whether this is an error with the FFI or not.

notices contains any notices returned from the Pact Broker.
Just make the step a no-op as the underlying Rust code will emit the warning.

Cool, I'll make this a no-op.


[BUG] TimeoutError: Timed out after waiting 30000ms

Environment

chromium Version: 126.0.0
puppeteer-core Version: 22.12.1
Node.js Version: 18.x | 20.x
Lambda: nodejs18.x | nodejs20.x

Expected Behavior
Generate the pdf and upload to an s3 bucket
Current Behavior
The same code base was working before in nodejs 14.x lambda runtime having chrome-aws-lambda 6.0.0 puppeteer/puppeteer-core 6.0.0.
In Node18.x/20.x lambda runtimegetting a TimeoutError during pdf generation.
Failed to print PDF on time.

TimeoutError: Timed out after waiting 30000ms
    at /var/task/node_modules/puppeteer-core/lib/cjs/puppeteer/common/util.js:289:19
    at /var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:3986:35
    at OperatorSubscriber2._this._next (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:1055:13)
    at Subscriber2.next (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:678:16)
    at AsyncAction2.<anonymous> (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:4863:24)
    at AsyncAction2._execute (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:1974:16)
    at AsyncAction2.execute (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:1963:26)
    at AsyncScheduler2.flush (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:2235:30)
    at listOnTimeout (node:internal/timers:569:17)
    at process.processTimers (node:internal/timers:512:7) {
  [cause]: undefined
}

Steps to Reproduce
const url = require('url');

const { S3Client, PutObjectCommand } = require('@aws-sdk/client-s3');

const puppeteer = require('puppeteer-core');

const chromium = require('@sparticuz/chromium');

const timeoutPromise = async function(promise, ms = 60000) {
    let id;

    // Create a promise that rejects in <ms> milliseconds
    let timeout = new Promise((resolve, reject) => {
        id = setTimeout(() => {
            reject('Timed out in ' + ms + 'ms.')
        }, ms)
    });

    return Promise.race([promise, timeout]).then((result) => {
        clearTimeout(id);

        return result;
    });
};

exports.generatePdfHandler = async function(event, context) {
    /*
    This is the entry point for the Lambda function.

    */
    const s3Client = new S3Client();

    const browser = await puppeteer.launch({
        executablePath: await chromium.executablePath(),
        headless: chromium.headless,
        args: [
            '--no-sandbox',
            '--single-process',
            '--homedir=/tmp',
            '--data-path=/tmp/data-path',
            '--disk-cache-dir=/tmp/cache-dir'
        ]
    });
    const page = await browser.newPage();
    // Set viewport size so that CSS won't break in print mode. This was tested
    // to be working, anything below or above this standard resolution did not
    // work.
    await page.setViewport({width: 1024, height: 768});
    // Disable navigation timeout so that we allow more than 30 seconds to load
    // a report.
    await page.setDefaultNavigationTimeout(0);

    console.log(`Fetching report from ${event.reportUrl}`);
    try {
        await page.goto(event.reportUrl, {waitUntil: 'networkidle0'});
    } catch (err) {
        console.log('Failed to load report.');
        console.log(err);
        await browser.close();
        return;
    }
    console.log('Report page fully loaded.');

    // Verify that an actual report was rendered, making sure we have charts
    // in the DOM.
    let hasReports = false;
    try {
        hasReports = (await page.$eval('ca-reports', el => el.childElementCount)) > 0;
    } catch (err) {
        console.log('Could not find parent ca-reports element');
    }
    if (!hasReports) {
        console.log('Could not find any charts in the rendered report.');
        let screenshot = await page.screenshot({fullPage: true});
        let screenshotKeyName = event.pdfKeyName.replace('.pdf', '-error.png');
        const params = {
            Bucket: event.bucketName,
            ACL: 'private',
            Key: screenshotKeyName,
            Body: screenshot,
            ContentType: 'image/png',
            ServerSideEncryption: 'aws:kms',
            SSEKMSKeyId: process.env.PDF_KMS_KEY_ID
        };
        const command = new PutObjectCommand(params);
        await s3Client.send(command);
        console.log(`Saving Error screenshot to s3://${event.bucketName}/${screenshotKeyName}`);
        await browser.close();
        return;
    }

    const printToPdf = async function () {
        return page.pdf({printBackground: true, landscape: false});
    };

    await timeoutPromise(printToPdf(), (context.getRemainingTimeInMillis() || 2000) - 2000).then(async (pdf) => {
        try {
            const params = {
                Bucket: event.bucketName,
                ACL: 'private',
                Key: event.pdfKeyName,
                Body: pdf,
                ContentType: 'application/pdf',
                ContentDisposition: 'attachment',
                ServerSideEncryption: 'aws:kms',
                SSEKMSKeyId: process.env.PDF_KMS_KEY_ID
            };
            const command = new PutObjectCommand(params);
            await s3Client.send(command);
            console.log(`PDF successfully saved as s3://${event.bucketName}/${event.pdfKeyName}`);

            await browser.close();
            return;
        } catch (err) {
            console.log('Failed to upload PDF.');
            console.log(err);
            await browser.close();
            return;
        }
        await browser.close();
        return;
    }).catch(async (err) => {
        console.log('Failed to print PDF on time.');
        console.log(err);
        await browser.close();
        return;
    });
};

Lambda Memory - 4096 MB, Ephemeral storage - 512 MB, Timeout - 6 MIN
Can some one help me to figure out what is wrong here?

I have mostly seen this behaviour on pdf's with large file sizes around 50 MB, page count approx 750

oh, it's kinda heavy, I've asked, I'm getting same error, but in my case it's pretrty simple page.
Page has style tag with CSS inside, weird part is - when I use
 @media print {
        .non-pdf-link {
          display: none !important;
        }
        .pdf-link {
          display: flex !important;
        }
        .main-content {
          zoom: 145%;
        }
      }

page.pdf(...options) thorw Error waiting timeout, even if I increase it still occurs.
and in case I've removed media print styles, it works)

I've updated a lib and issue has gone =)

Could you tell me what was updated here for the issue to be gone?

Hi, I have just upgraded the library to the latest version, following the guidelines outlined in the documentation.

I tried with the latest library puppeteer-core == 23.6.1 and chromium Version: 130.0.0, but still receiving the same timeout error
TimeoutError: Timed out after waiting 30000ms     at /var/task/node_modules/puppeteer-core/lib/cjs/puppeteer/common/util.js:258:19     at /var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:3986:35     at OperatorSubscriber2._this._next (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:1055:13)     at Subscriber2.next (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:678:16)     at AsyncAction2.<anonymous> (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:4863:24)     at AsyncAction2._execute (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:1974:16)     at AsyncAction2.execute (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:1963:26)     at AsyncScheduler2.flush (/var/task/node_modules/puppeteer-core/lib/cjs/third_party/rxjs/rxjs.js:2235:30)     at listOnTimeout (node:internal/timers:581:17)     at process.processTimers (node:internal/timers:519:7) {   [cause]: undefined }

I've faced this issue and got this working with the following versions
"@sparticuz/chromium": "^130.0.0",
"puppeteer-chromium-resolver": "^23.0.0",
"puppeteer-core": "^23.7.1"

Here is my code

"use strict";
const puppeteer = require("puppeteer-core");
const PCR = require("puppeteer-chromium-resolver");

exports.generatePdfFromUrl = async (urlToPrint) => {
    try {
        const stats = await PCR();
        const browser = await puppeteer.launch({
            headless: true,
            args: ['--no-sandbox'],
            executablePath: stats.executablePath,
            defaultViewport: { width: 1920, height: 945, deviceScaleFactor: 4 },
        });

        const options = {
            format: 'A4',
            headerTemplate: '',
            footerTemplate: '',
            displayHeaderFooter: false,
            margin: {
                top: '0px',
                bottom: '0px',
            },
            printBackground: true,
        };

        const page = await browser.newPage();
        await page.setDefaultNavigationTimeout(60000); // Set timeout to 60 seconds

        await page.goto(urlToPrint, {
            waitUntil: 'networkidle0',
        });

        // Wait for 5 seconds to ensure all content is loaded
        await new Promise(resolve => setTimeout(resolve, 5000));
        const buffer = await page.pdf(options);

        await page.close();
        await browser.close();

        return buffer;
    } catch (error) {
        console.error(error);
        throw error;
    }
};


Fix button state on empty jobs page

Correcting button state
Before:

After:

Reviewer: @jfurrow

Nice!

⛵


[WIP] feat(RTL): Enable RTL for keyboard handlers

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS

For me it feels more confusing, I would say start & end is more about a position, not direction. For this would better make sense to have next and previous. But I don't see a reason to change it now, as it is more an internal logic which is not shown to the clients, all they do is just binding a key to action.

Yes, we considered this. I agree with @sophieH29. Changing the name for ArrowLeft to ArrowPrev is technically more correct, but very unintuitive especially for consumers that are not aware of RTL. In the case of direction in the components, where you control the interface, I agree that we should have start/end/next/prev. On the other hand, people expect to be able to set keyboard handlers for ArrowLeft or ArrowRight.


ARC-616: Extend app descriptor to include remotelinks

Was there anything else I was meant to do?

You'll also need to add a reference to remote links on the Jira client, so we can do something like remoteLinks.update here.


Ensure the GSC reference is used for decompression in bam2fastq module

Some of the bam files are being crammed, and it was found that some of the compressed files rely on the specific reference that was used in file compression. Those samples were exiting with error in bam2fastq module. To prevent this, we need  to modify the bam2fastq module to use GSC reference for decompression.

Is this done (via the PR I just approved)? If so, please close

No, it was not done in that PR. It is still work in progress.

Closing. This actually won't be necessary because the GSC is reheadering all the RNA-seq bam files to use the proper reference. If that process doesnt fix our issue we can re-open.


Delete confirmation dialog

Adds confirmation dialog for deprovision and apprepolist
Add apprepolistitem component
Anchor husky at 0.14.3

btw I created https://github.com/kubeapps/dashboard/issues/64 to track the issue of upgrading husky


Support TSQL ownership chaining in procedure

This commit supports forming ownership chain while executing the procedure such that when referenced object(in any particular statement) and procedure has same owner then invoker will be able to execute that statement even if it doesn't have explicit permissions on referenced object.
To implement above functionality we've implemented hook which

check whether current statement execution is inside procedure or not by looking at the PLtsql_exec_state stack.
If it is inside procedure then it compares the referenced object and procedure's owner.
If both are same then this hook bypasses the permission check and allows execution of that statement.

Task: BABEL-3014
Signed-off-by: Harsh Lunagariya<EMAIL_ADDRESS>Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

As I mentioned offline, please test nested ownership chain case like
proc -> view -> view -> table


Embedded SVG in exports fail with a SAX exception

Excluding fop under batik-transcoder fixes that, but then screws up some labels.

Should be fixed with new batik.

Should be fixed with new batik.


Reduce the environmental-dependence of Add-PrigAssembly

Currently, Add-PrigAssembly make the absolute path of the replacement target assembly. However, this behavior will break the build if the committed *.csproj is carried another environment.
It should reduce such environmental-dependence by using a reference path for example.

This issue has been fixed in the following commit:
ed1152ae5009ccf27182205366f1e4a32d0bc965


scroll causes scroll bar whether or not it's necessary

I noticed that there is a scrollbar on all of the output cells which makes things a little cluttered.

I think a good solution would be to just replace 'scroll' with 'auto'
https://github.com/fastai/fastpages/blob/c9061199a66cf2bf368918920cfae483b8b20831/_sass/minima/fastpages-styles.scss#L243
(https://www.w3schools.com/css/css_overflow.asp) and (https://stackoverflow.com/questions/35484742/hide-useless-scrollbars-that-show-up-on-windows-only) are the two links I used.

Just need to replace:
overflow: scroll;

with
overflow: auto;

https://github.com/fastai/fastpages/blob/c9061199a66cf2bf368918920cfae483b8b20831/_sass/minima/fastpages-styles.scss#L243

I'm on Firefox if that is important for this type of issue


Graphite 0.9.13

I am new to Graphite and Github, please help me if this question is not relevant for this forum.
Currently I am running Graphite 0.9.12 but having time gap issue while rendering graph using API.
But I have not seen this issue in 0.9.13. But i am not finding 0.9.13 code on github while it was available earlier.
It is a stable version and can i use it in production.
Thanks
Ravi

Graphite 0.9.13 is bata but it is the version you get if you do a pip install. I hit issues when I was using it. I have since reverted to 0.9.12 in production but this brings other issues.

See also #677.

The "0.9.13" from pip is a release candidate, not the final version. You didn't specify what sort of "time gap issues" you're having, but there were two recent PRs merged that address time issues. See https://github.com/graphite-project/graphite-web/pull/1157 and https://github.com/graphite-project/graphite-web/pull/1034 for details.

Thanks for all reply and sorry for very late in reply.
I am having issue in rendered graph. When I render a graphite graph in our application for last 20 minutes, it doesn't show any data but when we change the time in rendered link 1hour behind it starts showing correct data.
For example - If my rendered link is showing start time - 10:15 end time 10:35. Graph will not show any data (assuming i am running it at 10:35) but when I will change start time to and end time to 9:15 and 9:35 respectively it will start showing data from 10:15 to 10:35.
I have not noticed this i n 0.9.13.

@ravibhooshan As mentioned in my previous comment, there were some fixes that went into the 0.9.x branch to address time issues. If you're able, please try the 0.9.x branch. If not, it should be fixed in the next stable release.


Update input type for parse

midi-file-parser expects a string as input, not an ArrayBuffer. This also matches with how the tests do readFileSync with a "binary" encoding specified, which will result in string output.

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   82.42%   82.42%
=======================================
  Files          10       10
  Lines         347      347
  Branches       62       62
=======================================
  Hits          286      286
  Misses         61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b07ca...79ffbf9. Read the comment docs.

Looks like it should support both: https://github.com/Tonejs/MidiConvert/blob/master/src/Midi.js#L70
Please update your PR to include both (ArrayBuffer|string).

Thanks, done.

Could you please publish a new version to npm with the changes so I can depend on them in my package? Thanks!

You'd need @tambien for that.


Issue Template Forms

There will likely be a lot of similar issues submitted to this repo, which is why I think it's important to organize them.
For the issue forms to work, the following labels need to exist:

[x] enhancement
[ ] bindings
[ ] output-formats

Is there a plan for proposals of changes to the syntax or should I also just make a template for that?

I just saw that I didn't adhere to the commit message guidelines.

I was gonna do bug report and feature request forms but then I thought, it should probably be separated between cli, standard library, etc.? Can someone give me a list of templates that I should make?
Currently there's:

Language Bindings Request - Request for Pkl bindings for a programming language
Output Format Request - Request for a output format to be added to Pkl

Is there a plan for proposals of changes to the syntax or should I also just make a template for that?

@holzensp

@holzensp
https://github.com/apple/pkl/pull/140#issuecomment-1945795260


Game Crashes after installing pack that needs to be converted

Crashlog
Using latest FSB and MCPPPP

@RaptaG I think you should convert the pack with the standalone converter (instead of the mod) and then check if the converted pack works with this mod.

@RaptaG I think you should convert the pack with the standalone converter (instead of the mod) and then check if the converted pack works with this mod.

Yep, that was it -_-


Fix database migration file of kyc_verified field

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Fix database migration file of kyc_verified field
Why
Bug fix
Known limitations
N/A

Reference Server Preview is available here:https://anchor-ref-pr771.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr771.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr771.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr771.previews.kube001.services.stellar-ops.com/


Q4S2 P1 Development Bugs

Fix P1 development bugs in Sprint 2 Q4 2018.

Closing, failed to convert to epic, probably due to GitHub trouble on Monday. Trying again.


Admin dashboard right sidebar

Follow Figma designs
Update the map to reflect approved boxes in backend
Implement the right sidebar of the admin dashboard

/cib right sidebar

Branch 62-right-sidebar created!


FancyZones features from Mosaico

Have you taken a look at how zones are treated in Mosaico? That's what I use now and it works wonderfully. Here are some things you can learn and implement from that

Editor - let zones snap to a user-selectable grid. For example, a 4 column and 2 row grid.
Editor - let users select from a pre-populated list of zones (like 1/3, 1/4, 2/3 either left, middle or right justified)
When moving a window with a mouse, mark zone locations by smaller 'drop zones' - so that you can move a window into a zone which is totally hidden behind other zones.
define which zones can be cycled through using win+ arrow keys - so win+left array will only cycle through left-justified zones and win+ right array for right justified zones and win + up for middle zones - user can define which set of zones each win+arrow key will address.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

👍

👍
In particular, snapping zones to a user-selectable grid (user-definable number of rows, columns, and space between grid cells) would be excellent. I have a hard time aligning the borders of my zones with the current system.

Tracked in https://github.com/microsoft/PowerToys/issues/6611

Most of these features are tracked in other issues, can you remove the duplicates or close this issues if they are all tracked in other issues? /needinfo


Experimental Boundary: Adding code to render floor and check if object is within established boundary

Removed old stage code
Started using the buggy boudnary APIs in Unity b8
Added code to allow users to check if a game object is within the setup boundary.

This code class will change as we understand the API more and when it works.

There still looks to be a test scene and a readme in the Stage folder. This PR should probably remove/relocate all that as well, right?

Started using the buggy boudnary APIs in Unity b8
😆


Add WYSIWYG

https://github.com/JefMari/awesome-wysiwyg
A curated list of awesome WYSIWYG editors
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

You have to review at least 2 other open pull requests. Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration.
I have read and understood the instructions for creating a list.
This pull request has a descriptive title in the format Add Name of List (Example: Add Swift), not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the project/theme of the list. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
Be added at the bottom of the appropriate category.

The list I'm submitting complies with the below requirements.

Requirements for your Awesome list

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
Includes a succinct description of the project/theme at the top of the readme. (Example)
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of nested lists, preferably none.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
WTFPL and Unlicense are not acceptable licenses.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

Changes requested done

Looks awesome!

Please add add a . after the description of your list.

This is not done.

JQuery => jQuery
JQuery Based => jQuery-Based

Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

For example, you have Angular written in 3 different ways. Same with Vue.
Please go through all the descriptions and ensure their quality and consistency.

Includes a succinct description of the project/theme at the top of the readme. (Example)

I think the list should be named WYSIWYG Editors. Just WYSIWYG is too generic and doesn't capture the exact purpose of the list.


router base cripples the anchors

When
  router: {
    base: '/docs'
  },

is in nuxt.config.js, the anchors are not prefixed by the actual markdown site, e.g.
http://localhost:3000/docs/#where-can-i-use-mergin should be localhost:3000/docs/faq#where-can-i-use-mergin
when router is not set, it works correctly
reproduce:

go to FAQ page
click on any heading link  (#) in the right menu or in the text (e.g. #Where can I use Mergin?)

upstream issue https://github.com/nuxt/content/issues/938


Update response example for x-info (extended in Jaguar release).

Response now includes JSON sent to ES and version in parentheses after index name.

Naomi let's truncate the data that we supply, some of the fields might be considered private, so for company we can use company name address but not more than that.
Can you please update the example again?


init chains-db

📝 Changed routes:

/chain/[chainSlug]
/chainlist

(view full size)
(view full size)

Commit 7123e50102448ecf994f9424ee09aba29a46e947 (https://thirdweb-8am90b0zj.thirdweb-preview.com).


Implement more sophisticated filtering functionality for items in main list

It would be useful to be able to filter by title and tag at this stage. Filtering by tag is already implemented, but the interface is a little cumbersome to use.

https://github.com/Alc2110/MyLibrary/commit/e4aa3270b9fae99b01d866d0c746ac071fb726aa


Use tektoncd/results repo for git-init symbolic ref tests

Changes
Fixes https://github.com/tektoncd/pipeline/issues/2854
Prior to this commit we were pointing one of our integration tests
at a Spring project repo. We did this to test our git-init code
with a repo that uses "main" as its main branch instead of "master".
Now that we have switched many/all of our repos over to "main"
instead of "master" we can use them for testing instead. This means
we haven't tied our tests to an external third party repo that might
change / be removed without our realizing it.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
NONE

sounds good, thanks @sbwsg
/lgtm


Added language_code field in User structure

Works fine;

Hey @tucnak why don't you approve a couple of simple PRs?


Document.FromJson doesn't support unsigned longs

Primitives and DynamoDB easily support large numbers, however the third party json reader doesn't support unsigned numbers.
aws-sdk-net/docgenerator/SDKDocGeneratorLib/ThirdParty/Json/JsonReader.cs,
.NET will throw an overflow exception when trying to do Int64.parse on this example ulong:
16849433912163548285
As a result, the above number won't be included properly in a document retrieved by Document.FromJson

In the below code, the value is parsed incorrectly as 0, though I am not encountering an overflow exception.
ulong original =<PHONE_NUMBER>2163548285;
var doc = Document.FromJson(@"{""ULong"": " + original  + " }");
var parsed = doc["ULong"].AsULong();
Assert.AreEqual(original, parsed);

It appears that the JSON reader we are using doesn't support ulong at all.

That's correct. The library doesn't use Int64.Parse.
Also, the updated library has support for uint64, so would it be possible to simply update the library to the latest version?
I think it's called litjson, and is found here:
https://github.com/lbv/litjson/

That's correct. The library doesn't use Int64.Parse.
Also, the updated library has support for uint64, so would it be possible to simply update the library to the latest version?
I think it's called litjson, and is found here:
https://github.com/lbv/litjson/

This has been fixed in commit aef2e1705.


[BUG] : Make the Admin page responsive

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Currently the ui for this page breaks for mobile devices
Expected Behavior
Fix the ui so that it works appropriately for all devices
Steps To Reproduce
No response
Version
1.0.3 (Edge)
What browsers are you seeing the problem on?
No response
Environment
- OS:
- Node:
- npm:

Anything else?
No response

hey ,can you please assign this task to me

hey ,can you please assign this task to me

Assigned 👍,  try to complete it within two days time span

Assign me

@Ir786921 what's your update? Are you working on this or shall i reassign this to @Dhruv127

ok , Assign him

@Dhruv127 try to complete this by Friday eod

I want to work on this task. Please assign it to me sir @Tushar98644

I would like to work in this if not completed

PR #322 .

do check now PR #322

I would like to work, if it is not completed


Error message: "Fatal error: Couldn't find end of Start Tag tag at :1."

Update
I found the cause of the error described below: I copied and pasted the Wikipedia link to a sub-heading, which had a dot inside: _**https://de.wikipedia.org/wiki/Geschichtspfad_Friedrichshafen#Ehemaliges_Ledigenheim_-_Tafel_4.10**_
After pasting it to iD the link turned into Geschichtspfad Friedrichshafen#Ehemaliges Ledigenheim - Tafel 4. This malformed URL lead to the upload error. After changing the URL manually no more problems.
Original post
While trying to update node<PHONE_NUMBER> I am getting the following error message:

After clicking on Okay and trying to save again, the login page is displayed:

After a click on "Allow access" the app is greyed out and nothing can be clicked anymore.
Those are the tags that I added to the node (in case this matters in any way):

I can reproduce the error on http://preview.ideditor.com/master and dev instance: after pasting the string
https://de.wikipedia.org/wiki/Geschichtspfad_Friedrichshafen#Ehemaliges_Ledigenheim_-_Tafel_4.10 into the wikipedia field, an u0010 character is automatically appended at the end. This character also appears in the osc file. As it is invalid XML the API refuses the osmChange message.
<osmChange version="0.6" generator="iD"><create><node id="-1" lon="7.182067064782307" lat="50.100773134692865" version="0"><tag k="shop" v="supermarket"/><tag k="wikipedia" v="de:Geschichtspfad Friedrichshafen#Ehemaliges Ledigenheim - Tafel 4"/></node></create><modify/><delete if-unused="true"/></osmChange>

Thanks for reporting..  It's a bug in this code:
https://github.com/openstreetmap/iD/blob/a72865e4d85462cf8c071ce31e30b1191de249ba/modules/ui/fields/wikipedia.js#L172-L173
Which is intended to transform "anchorencoded" links but not really working.  This is apparently a thing MediaWiki does (see link).
I'm going to just comment out that code because, as far as I can tell, it shouldn't matter on the OpenStreetMap side whether we store the nice links or the ugly ones - both of them will take users to the right wiki page.  cc @1ec5 who probably knows more about this.  We can put it back later if it really is important.


Create 2022-06-01-annual-report-2021.md

blog post for annual report summary; publish as soon as we have the correct approvals from sig-docs and at least 1 other member of the steering committee
/hold

Preview of blog:
https://deploy-preview-34103--kubernetes-io-main-staging.netlify.app/blog/2022/06/01/annual-report-summary-2021/
This PR has an approval from a steering committee member, @dims
/lgtm
/approve
/unhold


Remove test_if_bot_is_unbchatbot test

PR Description
Fix issue #42 .
New Feature Submissions
To run tests locally, use make if you're on Mac or Linux.

[ ] Does your submission pass all the tests?
[ ] Have you lint your code locally prior to submission?
[ ] Have you written proper tests to your added code?

New Dialog Submissions
User messages have - -, bot messages have   -

[ ] Does all your user messages have lower letters?
[ ] Have you lint your dialogs locally prior to submission?
[ ] Have you written proper tests to your added dialogs on test_dialogs?
[ ] Does your dialog have an existing category? If not, did you create it?

Changes to Core Features

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests or modified old ones for your core changes, as applicable?
[ ] Have you successfully run tests with your changes locally?

Remove também a função que estava sendo testada. É para a cobertura de testes manter a mesma, tendo em vista que vc só está removendo funcionalidade

@alexandrebarbaruiva Removi a função verify_bot, mas o code coverage continua reclamando. Alguma ideia?

tá certinho agora, essa diminuição é só pq cada linha de código agora tem uma porcentagem maior

só melhora a descrição na próxima e marca as questões do template da PR


POW Elite (POWR320D) data scaled by 10 / 100 factor

Just installed 6 POWR320D. All show same issue:
Current (A) scaled up by 100
Power (W) scaled up by 100
Voltage (V) scaled up by 100

Image show current reading, obviously right data should be 9.4 A, 1964 W, 211.3 V
Thanks for any advice on that

Same behavior for the POWR316D

How to install it? I have only one working switch from POWR320D, and no sensors:

How to install it? I have only one working switch from POWR320D, and no sensors:

The same here link , so I'm also interested in the solurion.

Did you set up sensors in configuration.yaml?
for example:

If you didn't, write in the power, current, voltage.

Did you set up sensors in configuration.yaml? for example:  If you didn't, write in the power, current, voltage.

I only used the config flow, not the YAML. It is a bit weird it has to be set up manually in case of an energy monitoring device, but I will give it a go once I arrived home, thank you.


Bulk query adaptors?

Can you all discuss what sort of components would be needed for third party systems like Galaxy, Intermine, etc. to be able to pull data from SciGraph?
Maybe nothing special is needed other than some documentation, but just want to put these particular use cases on your radar.

Is this related to #5. Would the data in question be the entire graph or just a subset of it?

Hi Chris,
Yes the types of queries are same as #5, but with the exception that someone would query SciGraph via a third party system for some subset of the graph.
For example, a Galaxy user might want to import all phenotypes on a given chromosome into their Galaxy project.  I'm just wondering if there is anything we might want to do to make it easy to embed a SciGraph query tool in other sites to pull data - so not end users but other platform users.

The currently supported formats are documented here:
https://github.com/SciGraph/SciGraph/wiki/REST-Graph-Formats
It would be easy to add other formats as clients require them. Let's take those as new tickets.


Docs broken for Interlock - no new config section provided

File: ee/ucp/interlock/deploy/configure.md
Step 3 says:

Create a new Docker configuration object from the file you've edited:
docker config create $NEW_CONFIG_NAME config.toml

But it is missing where NEW_CONFIG_NAME get defined.

https://github.com/docker/docker.github.io/commit/3b83a63da2e745647c93e923dd42e4746740c6fb#diff-10687b3e4d881512964987a9c9a9ccc2L30 is where it looks like it was broken


[Bug] "Base Drama Spawn Chance" doesn't seem to work

set the slider to various values between 0 and 1000, but never saw a Drama mask for over an hour.  Immediately forced Drama masks to spawn with the other option by specifying moons.

Yeah, I was on planets with no base mask drop rate -- because it was never mentioned that it modified the base drop rate of other masks.  It's explicitly called the Drama mask drop rate and none of this is mentioned in your documentation.
If it clearly isn't intended to function as a base spawn rate variable, it really needs to be renamed and given an appropriate description.    Yikes.

I'm sorry to hear this was a nuisance, I'm going to add a fuller description of the default spawn rates of Drama mask in the ReadMe as part of the FAQ I'd planned earlier, and add it in the description of the config for the next patch alongside a planned bug fix
To clarify, this config name should have been called a Base Drama Mask Spawn "Multiplier" to align with its effects, and it only uses other mask spawn rates as a reference; it does not modify those.
I'll close after the next patch resolves this.


template issue with latest upgrade

Bug, feature request, or proposal:
Hi,
I have upgraded to latest version 2.0.0-beta.2.
Getting below issues while loading the page
The
The
The
The
What is the expected behavior?
What is the current behavior?
What are the steps to reproduce?
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, browsers are affected?
Is there anything else we should know?

https://github.com/angular/material2/issues?utf8=✓&q=The element is deprecated

Will be fixed by https://github.com/angular/material2/pull/3608.


stamps from a dictionary as option in struct (perhaps)

stamp: 'a' // something like this (if its not an array)

need to pass extra argument to evertything


[Bug] iOS Build failure: Umbrella header 'FirebaseCoreInternal-umbrella.h' not found

[REQUIRED] Please fill in the following fields:

Unity editor version: 2021.3.25f
Firebase Unity SDK version: 11.7
Source you installed the SDK: unitypackage (.unitypackage or Unity Package Manager)
Problematic Firebase Component: FirebaseCoreInternal(Auth, Database, etc.)
Other Firebase Components in use: Analytics (Auth, Database, etc.)
Additional SDKs you are using: AppsFlyer,Braze (Facebook, AdMob, etc.)
Platform you are using the Unity editor on: Win/Mac(Mac, Windows, or Linux)
Platform you are targeting: Mobile(iOS, Android, and/or desktop)
Scripting Runtime: IL2CPP(Mono, and/or IL2CPP)
Pre-built SDK from the website or open-source from this repo: Website

[REQUIRED] Please describe the issue here:
Firebase adds couple of pods to podfile. Here is our podfile:
use_frameworks! :linkage => :static

target 'Unity-iPhone' do
platform :ios, '12.0'
  pod 'InternalLibUnity', '0.0.1'
  pod 'InternalLibObjC', '0.0.1'
  pod 'InternalLibObjC2', '0.0.1'
  pod 'AppsFlyerFramework', '6.12.2'
end

target 'UnityFramework' do
platform :ios, '12.0'
	pod 'Firebase/Analytics', '10.20.0'
	pod 'Firebase/Core', '10.20.0'
end

target 'NotificationService' do
platform :ios, '12.0'
  pod 'BrazeNotificationService', '~> 6.0.0'
end

post_install do |lib|
	lib.pods_project.targets.each do |target|
		if target.name.include? "UnityFramework"
			next
		end
		target.build_configurations.each do |config|
			config.build_settings['ARCHS'] = '$(ARCHS_STANDARD_64_BIT)'
			config.build_settings['BUILD_DIR'] = '../build/$(CONFIGURATION)'
			config.build_settings['PROJECT_TEMP_DIR'] = '$(BUILD_DIR)'
			config.build_settings['PODS_CONFIGURATION_BUILD_DIR'] = '$(BUILD_DIR)'
			config.build_settings['CONFIGURATION_BUILD_DIR'] = '$(BUILD_DIR)'
			config.build_settings['CONFIGURATION_TEMP_DIR'] = '$(BUILD_DIR)'
			config.build_settings['ONLY_ACTIVE_ARCH'] = 'NO'
			config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '12.0'
			config.build_settings['ENABLE_BITCODE'] = 'NO'
		end
	end
end

Firebase recommends using static linking for pods by adding use_frameworks! :linkage => :static. When we do so, we get the following build (xcode) errors:
Umbrella header 'FirebaseCoreInternal-umbrella.h' not found
and
'google/protobuf/Any.pbobjc.h' file not found
Removing use_frameworks! :linkage => :static  results in an error in pod install:
[!] The following Swift pods cannot yet be integrated as static libraries:

The Swift pod `FirebaseCoreInternal` depends upon `GoogleUtilities`, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.

a workaround would be to add pod 'GoogleUtilities', :modular_headers => true. However, this results in the following build error:
'FirebaseCoreInternal.modulemap' not found
I did a comparison between our xcode project with and without Firebase integration and nothing jumped out as different. I also did that with a fresh Unity project + Fire SDK.. same result.
Firebase SDK for Unity has an iOSResolver component that does some operations on Unity post build. I replicated that for our build system.  One thing that I don't know the purpose of is that Firebase adds a dummy swift file to UnityFramework target. I just replicated it.
Steps to reproduce:
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)? Yes
What's the issue repro rate? (eg 100%, 1/5 etc) 100%
What happened? How can we make the problem occur? It's hard to reproduce. It's related to Firebase requirements and our project configuration. I can't give build logs at this point. I'll try to, if needed.
Relevant Code:

Hi @NawarRajab,
It would be helpful if you provide any additional information related to your issue such as build logs, a minimal, reproducible example of your implementation, as well as the steps you've taken to reproduce the issue. This way, we can identify what's causing this to happen.
Could you also elaborate the part where you mentioned the comparison between your Xcode project with and without Firebase? Are you facing a similar issue without any additional SDKs in your Unity project?

Hi,
(obfuscated)Build Unity-iPhone_2024-02-22T11-16-11.txt
I've attached the build log. What I meant by the comparison is that I compared xcode project settings of:

Our xcode project without FB (Builds successfully)
Our xcode project with FB (Build fails)
xcode project of a fresh Unity project + FB integration (Builds successfully)
and I could not find noticeable differences in settings.

I can't produce a sample project as the issue is specifically with how our project is configured and it's conflict with Firebase requirements. We have a bunch of ObjC libraries and they don't work well with the way Firebase configures its dependencies.
For example, we tried to build our project without Firebase integration but with  use_frameworks! :linkage => :static and it still produced build errors related to missing header files.

If there a way to integrate Firebase analytics without using use_frameworks!?
What is the purpose of the dummy swift script IOSResolver adds to the project?

For anyone facing the same issue, the solution is to bypass Firebase Unity SDK all together and use Firebase SwiftPM package. It's very simple process and is much cleaner solution:

Use Unity's PBXProject.AddRemotePackageReferenceAtVersionUpToNextMajor();
Add GoogleService-Info.plist to PBXProject.
Done!


SLL option

How do we select the SLL option whilst connecting to clickhouse using this driver in VSCode?

Hi @DombayciBayer, if you mean SSL, see #405.


Without openSUSE-release, /etc/os-release is not available, which makes distribution detection quite hard for the official openSUSE images. So far all the distributions I checked (CentOS, Fedora, Debian, Ubuntu, Oracle Linux, Alpine) had /etc/os-release in their official Docker images, so it would be great if openSUSE could include os-release too.

LGTM, thanks for the contribution. I'll merge the request when I'm back to a place with better internet connection (I'm travelling right now). I'll take care of pushing the new images to Docker Hub

Great to hear that, thanks!

I'm tired of taking care of these image rebuilds manually. I ported your changes on OBS where we are going to automatically build these images.
See https://build.opensuse.org/project/show/Virtualization:containers:images and its subproject.
I'll take care of pushing the build results of OBS to the Docker Hub. I'll also update this repo to drop all these sources, from now on we will do everything on OBS.

Wouldn't it be possible to trigger the OBS builds via a GitHub webhook or service hook?
While I can imagine that OBS makes your life as a maintainer a lot easier with regards to image updates, simply being able to contribute via GitHub is hard to beat in terms of simplicity.

Yes it is possible: http://openbuildservice.org/2013/11/22/Source-Update-Via_Token/

OK, let me rephrase then: I think it would be great for users to be able to keep using GitHub when submitting contributions.
I am sure OBS is a great tool, but only a small number of potential contributors is going to be as familiar with it as they are with GitHub.

May be we can keep the files here and use a git service in OBS to pull them?

Good idea, I'll take care of that.

Very glad to hear that, thanks! :+1:

Fixed. Unfortunately it is not possible to have the git hook because this repository defines two different OBS projects. I already talked with @adrianschroeter about that :(

That would be for a automatic hook, but we can always do osc service disabledrun or? It was not automatic until now either.

We just have to trigger a rebuild of the project, that will automatically fetch latest version of the code from this repository. So yes, the situation definitely improved.

@flavio Could you also push the updated images to docker-library/official-images? Thanks!

@sometimesfood yes, yesterday I didn't have time to do that. I'll take care of that today

@sometimesfood tracked here https://github.com/docker-library/official-images/pull/853

Great, thanks!


arrow function in string template to work in old browser (android 6.0)

Version
2.6.10
Reproduction link
[https://jsfiddle.net/omkardusane/m36tvz8w/24/ 1](https://jsfiddle.net/omkardusane/m36tvz8w/24/ 1)
Steps to reproduce
https://jsfiddle.net/omkardusane/m36tvz8w/24/ 1
What is expected?
This should work in android's 6.0
What is actually happening?
Doesnt work due to arrow function doesn't get compiled in backward compatible if it is in stringified template

I am trying to achieve this without the arrow function in the stringified component template.

Hi, this is not related to Vue, it's related to usinng modern js in older browsers. We provide a version that works on older browsers but we cannot control the code you write.

Remember you can use the forum or the Discord chat to ask questions!

If you want to use arrow functions and ship code for older browsers, you need to introduce a build step to transpile them. (Try Vue Loader with webpack.)

I understand that reading this issue might lead you to think it is not a vue issue, agreeing on that, I would still like to point out that the snippet I have put up is highlighting a major lack in Vue to be able to return an event handler in the component's template while the template is being mounted, which we can achieve in react, hence it is intuitive. Can we start a discussion somewhere (any preferred medium where I can seek your attention to convey this issue). Please beleive me it can be a good thing once adressed properly. Currently the problem is unsolvable to me, transpilers do not work inside stringified templates.

As indicated in the issue helper and my comment, use the forum or the chat, thank you.
The problem of arrow function support is completely unrelated to whatever framework you use, if you need to support older browsers without using a build step, then write js code that is supported by all browsers. This is valid in Vue, React and any other framework


fix: memory leak caused by watcher created in initComputed

After vue instance get destroyed, the watcher created in initComputed can still collect deps, which
cause the watcher can't be GC, so is the vue instance.
See the reproduction.
What kind of change does this PR introduce? (check at least one)

[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

having same issue

The bug has a serious impact on our production. We are using a forked version now. Can we make some progress here?


BlankDummyActivity don't find nim.animation_localization_activity_transition_out

ava.lang.NoClassDefFoundError: Failed resolution of: Lcom/akexorcist/localizationactivity/R$anim;
at com.akexorcist.localizationactivity.ui.BlankDummyActivity.onCreate(BlankDummyActivity.java:13)
at android.app.Activity.performCreate(Activity.java:6942)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1126)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2880)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2988)
at android.app.ActivityThread.-wrap14(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1631)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6682)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1520)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1410)
Caused by: java.lang.ClassNotFoundException: Didn't find class "com.akexorcist.localizationactivity.R$anim" on path: DexPathList[[zip file "/data/app/com.my.myapp-2/base.apk"],nativeLibraryDirectories=[/data/app/com.my.myapp-2/lib/arm, /data/app/com.my.myapp-2/base.apk!/lib/armeabi-v7a, /system/lib, /vendor/lib]]
Before this, my app was working fine, but after some changes on my code, my app began to crash when i'm trying to change App's language

I solved this issue, editing library's code. I commented BlankDummyActivity invocation in language transaction


Prepare settings

Subtasks

[ ] Linker settings
[ ] Member settings
[ ] Global settings

1h 35m

19m

Total: 1h 54m

37m

Total: 2h 31m


For Amex Cards, card details show as done before the entire cvv code is entered.

Describe the bug
In the CardField component, the onCardChange attribute takes a callback that is passed cardDetails as a parameter.  cardDetails has a boolean field "done"  that should return true when the card details are entered completely, and false otherwise.  In the case of amex cards though, it returns true after only 3 digits of the four digit cvv are entered.
To Reproduce
Steps to reproduce the behavior:
On a screen with the CardField, enter an amex card.
Log the done parameter of the cardDetails argument passed to the onCardChange callback.
After 3 digits are entered, the value changes to true.
Expected behavior
The cardDetails argument should have done set to false until all 4 cvv digits are entered

@stupidtools American Express cards have a 4 digit CVV on the back, but also provide a 3 digit CVV on the front of the card that also works.
The behavior is as we would expect:

It is valid after 3 digits
After 4 digits another callback is called that also has isValid = true


API_V1_1 and API_V2_0 should be v1.1 and v2.0?

There is example code which says
my_bittrex = Bittrex("<my_api_key>", "<my_api_secret>", api_version="<API_V1_1> or <API_V2_0>")
but when I execute this I get an error and I think it should be written as "v1.1" and "v2.0" which stops that error occuring.

There is example code which says
my_bittrex = Bittrex("<my_api_key>", "<my_api_secret>", api_version="<API_V1_1> or <API_V2_0>")
but when I execute this I get an error and I think it should be written as "v1.1" and "v2.0" which stops that error occuring.

Had a related problem with the Bittrex version and solved it by using the Beta "bleeding edge development" lib:
pip3 install git+https://github.com/ericsomdahl/python-bittrex.git


Can romana have traffic control？

such as title

Do you mean QoS or what?

yes, QoS

Hi @keontang Romana does not have QoS today, but it is possible. We've thought about how to implement various forms of traffic control. The simplest would be to use iptables' rate limiting functions. The Romana agent already configures packet filter rules using iptables, so rate limiting would not be a lot of additional effort.  We just have not gotten to it. Also, orchestration systems like Kubernetes don't support QoS in their network policy APIs, so this kind of feature would have to be applied through the Romana API directly or via annotations in k8s.


Idea: Allow search results to show multiple matches

Hi all! While digging into the platform and all of the great features available, I had a question about the search results page. Currently when you put in a term like x, the results show something like Matches column x_a, but there could be a lot of columns in that one table that match that term. It's potentially a bit misleading for users who are looking for something slightly more specific than what they typed in, because the phrasing/view implies that there's a single match in that table without telling the user there are more and they should either be more specific or look at the table to see what else exists.
Looking at the code, I believe this is the logic for that component/field selection.
Is there any appetite to making this component able to render n matches in a single table like Matches columns x_a, x_b, and x_c, or display something like Matches column x_a and n others? I'm not sure if there was a specific rationale behind limiting matches to a single field per table before, so I figured I would ask!

Hey @timcosta that's a great idea! Would you mind actually posting it to our Feature Requests page here so we can track it better?
I'm going to close out the "Issue" here since this isn't really an issue but would really appreciate if you could post it there :)


GUVNOR-2827: [Guided Decision Table] Not possible to create two conditions based on the same negated pattern

See https://issues.jboss.org/browse/GUVNOR-2827

@Rikkola @karreiro I've commented where the actual changes are.. otherwise it's all formatting.

Part of an ensemble:-

https://github.com/droolsjbpm/drools/pull/1105
https://github.com/droolsjbpm/drools-wb/pull/399


Fix build issues in Xcode version 6.1.1

SwiftHTTP is updated for Swift 1.2. If you upgrade to xCode 6.3, everything should work properly.


dagger-reflect more strict than dagger-compiler (scopes)

In our application we have structure similar to this one:
@Singleton
@Component
interface MainComponent {
  fun feature(): FeatureComponent
}

@Subcomponent
interface FeatureComponent {
  fun plus(module: SubFeatureModuleA): SubFeatureComponentA
  fun plus(module: SubFeatureModuleB): SubFeatureComponentB
}

@Scope
@Retention(RUNTIME)
annotation class SubFeatureScopeA

@Module
class SubFeatureScopeA {

  @Provides
  @SubFeatureScopeA
  fun provideSomething(something: Something): ISomething = something

}

@Subcomponent(modules = [SubFeatureModuleA::class])
@SubFeatureScopeA
interface SubFeatureComponentA {
  fun inject(fragment: SubFeatureAFragment)
}

(sometimes also FeatureComponent has some modules defined, but it's irrelevant in this case)
For such case, we get following exception in runtime:
Caused by: java.lang.IllegalStateException: Scope with annotations [@com.myapp.SubFeatureScopeA()] may not depend on unscoped
at dagger.reflect.Scope$Builder.<init>(Scope.java:167)
at dagger.reflect.ComponentScopeBuilder.get(ComponentScopeBuilder.java:115)
at dagger.reflect.ComponentInvocationHandler$SubcomponentMethodInvocationHandler.invoke(ComponentInvocationHandler.java:180)
at dagger.reflect.ComponentInvocationHandler.invoke(ComponentInvocationHandler.java:70)
at java.lang.reflect.Proxy.invoke(Proxy.java:913)
at $Proxy44.plus(Unknown Source)

while the dagger-compiler (2.26) allows such construct and works fine.

Same issue.


Defined hashedSelector in Select2Mixin, because it was undefined and c...

Defined hashedSelector in Select2Mixin, because it was undefined and causing errors.

Coverage increased (+0.2%) to 56.62% when pulling 5c18d5425156973de098e8eaaf76b7e9826ecce4 on johnrtipton:master into 42b73198b726e2e9278a0889a608ea7c31811d61 on applegrew:master.

Coverage increased (+0.2%) to 56.62% when pulling 5c18d5425156973de098e8eaaf76b7e9826ecce4 on johnrtipton:master into 42b73198b726e2e9278a0889a608ea7c31811d61 on applegrew:master.

Coverage increased (+0.2%) to 56.62% when pulling 5c18d5425156973de098e8eaaf76b7e9826ecce4 on johnrtipton:master into 42b73198b726e2e9278a0889a608ea7c31811d61 on applegrew:master.

Coverage increased (+0.2%) to 56.62% when pulling 5c18d5425156973de098e8eaaf76b7e9826ecce4 on johnrtipton:master into 42b73198b726e2e9278a0889a608ea7c31811d61 on applegrew:master.

Coverage increased (+0.2%) to 56.62% when pulling 5c18d5425156973de098e8eaaf76b7e9826ecce4 on johnrtipton:master into 42b73198b726e2e9278a0889a608ea7c31811d61 on applegrew:master.

Coverage increased (+0.2%) to 56.62% when pulling 5c18d5425156973de098e8eaaf76b7e9826ecce4 on johnrtipton:master into 42b73198b726e2e9278a0889a608ea7c31811d61 on applegrew:master.

I got hit by this as well.

Thanks, that should fix #154 :)

fixed in 12b00c108408a98bfe4b9a214d4c94592e1f2b54


Still takes a LONG time to load next image

I think time to find next image is growing with #labels (and #images, affecting initial minimum load time). Search for "next-best image" needs to be optimized to scale.
On investigation the process seems to take time at
combinedImage = combineImageLabelsToArr(image, category, threshold)
in combineImageLabels(image, threshold):
in file https://github.com/dcunhas/agdss/blob/2ad63ce326f0fca0aa0ed12a76b83444a0c35e23/image_ops/convert_images.py

I commented out combineAllImages in applyLabels function in views.py


Locally cache GCS data by default

It would probably make sense to add a fsspec simplecache by default, with files going into a "~/malariagen_data_cache/gcs" folder or something like that.

Won't do this.


Can't complete setup

I have followed the instructions in the readme.md file, but keep getting stuck at step 4. I have searched through Issues for the same error message but none appear to include a resolution.
:~/internet-pi $ ansible-playbook main.yml
[DEPRECATION WARNING]: Ansible will require Python 3.8 or newer on the controller starting with Ansible 2.12. Current version: 3.7.3 (default, Jun 29 2023, 18:03:57) [GCC 8.3.0]. This feature will be removed from ansible-core in version
2.12. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
[WARNING]: Unable to parse /home/oliver/internet-pi/inventory.ini as an inventory source
[WARNING]: No inventory was parsed, only implicit localhost is available
[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'
[WARNING]: Could not match supplied host pattern, ignoring: internet_pi
PLAY [Configure Internet Pi.] ***************************************************************************************************************************************************************************************************************
skipping: no hosts matched
PLAY RECAP ********************************************************************************************************************************************************************************************************************************** `
===============
I have tried the inventory as both of the below (where XXX is the actual IP address of my Pi. I am certain about the IP address because I SSH into it.
#[internet_pi]
#192.168.1.XXX ansible_user=pi
#Comment out the previous line and uncomment this to run inside Raspberry Pi.
<IP_ADDRESS> ansible_connection=local ansible_user=pi `

#[internet_pi]
192.168.1.XXX ansible_user=pi
#Comment out the previous line and uncomment this to run inside Raspberry Pi.
#<IP_ADDRESS> ansible_connection=local ansible_user=pi `
===============
Any guidance much appreciated, thank you

This is a fresh installation of Raspberry Pi OS Lite, with nothing else on it

Have tried uncommenting the first line and changing the ansible_user to the name of the local user (oliver) and same error message

I think you're on the right track here, since Raspberry pi OS no longer has the default pi user, you do need to substitute oliver for pi. (this probably should be updated on documentation)
if you're running the ansible script on the pi you're installing to, try changing it in the following line:
<IP_ADDRESS> ansible_connection=local ansible_user=pi
should be changed to:
<IP_ADDRESS> ansible_connection=local ansible_user=oliver
There should only be this line and the [internet-pi] lines uncommented.

Thanks for the response. Yes tried that too and same error message sadly

Then it might be a formatting or permissions issue.
My next step would be to delete the inventory.ini file, and re-copy/edit example.inventory.ini
Tried a couple different manglings of the inventory.ini file, but couldn't exactly replicate the error you got.
How are you coping/editing it?

I am using the unix cp command to copy and create new file
I can attempt a fresh copy tomorrow evening when back at my PC. Given you mentioned potential permissions issue, should I also chmod It to something else

(sorry miss click while trying to edit)

I am copying with the unix cp command
As you say a possible permissions issue, should I attempt to chmod to something different?
I am using cat and vi to view and edit so assume not a formatting issue but happy to try again tomorrow evening when next at my pc
Thank you for trying to help

Since you're using native *nix commands i'm less concerned about formatting, i was trying to eliminate some windows editing/copy scenario, and vi is for brave souls.
Just tested chmod/chown:
chown root:root inventory.ini  no change/error
chmod 000 inventory.ini same 4 errors
clean config for me is:
chown user:user inventory.ini
chmod 644 inventory.ini
Actually all files and dirs are user:user
all files are 644 and directories are 755
Hopefully this helps.

<IP_ADDRESS> ansible_connection=local ansible_user=oliver

OK, this got it working for me. Making sure that the IP and User were correct. I think Jeff uses "localhost ansible_connection=local" which results in errors.


feat(ci/dx): add pre-commit

Add precommit, initialize it with necessary checks to keep code change abide by a standard.
Please look at .pre-commit.config for all the hooks that are added.
For reviewer's sake, listing some config that have changed alot of files:

mdformat, restricting the line length auto fixed multiple files.
toml-sort, sorted all toml files alphabetically.
trailing-whitespaces
end-of-file-fixer

Note: This introduces a discrepancy in the checks between CI and pre-commit, it won't be hard (if someone wanted to) bypass precommit checks and push the code changes. Given adding all the hooks to CI as well might slow CI down, I thinks this discrepancy is the sweet spot. CI has checks for very absolutely necessary checks and pre-commit has some necessary and many nice-to-have checks.

Thanks @JaeAeich. I'm actually not so sure about having different checks for the pre-commit hook and the CI. Either we really care about things (and then we should enforce them, through the CI), or we don't (then why bother people at all?). Which is why I never ran with committing pre-commit checks at all and just do them for myself to save time on the overhead of CI checks. Thus, I would actually prefer to match the actual requirements across CI and hooks (minus long-running tests or tests that are difficult to run local). Would we really want to rely on users setting up the hooks to avoid spelling mistakes (which are hard to find even during reviews)?
Btw, given our work mode where we squash merge, I think using a pre-push hook would be more appropriate. We allow feature branches to be messy, so no need to raise the bar for people to commit. For example, I sometimes commit and don't push when I feel I have reached a milestone, either because I feel that it's a commit that what really stand on its own, or just because I want or need to store my current work to check out some other branch. Sure, I could just skip the hook, but given that commits on feature branches aren't really the units we care about, I think the more natural timepoint to run checks in this flow would be prior to pushin.

@uniqueg Yeah makes sense (thats what happened in cloud-component lol, thats why I wrote the PS in desc), on that note I have remove pre-commit as a git hook but left it in the CI, as General checks in PR Evaluation, if you think thats not an overkill, merge #182 and then this. On the other hand if it feels like an overkill and these files should be time linted by dev on their own, thats also fine, please feel free to close this PR :).

Let's leave it open for now and see which of these checks might be worth including in the CI, because I think there are certainly some.

Closing for now - can still be used as reference for CI future updates


I am a noob with Conty but, some programs ran in wine complain about no space left?

So, for testing, I tried to run the PortableApps menu in wine using Conty. It launches, but, it complains about lack of space when doing app updates.
I presume I am doing something wrong somewhere or missing something.
The command I used to launch is:
HOME_DIR="$PWD" ./conty.sh wine Start.exe
I can install PortableApps using downloaded exes, but using the built-in app fetching thing is hit or miss, and updates fail. The common theme is lack of space. The menu says there is 1.8GB of space but nothing available.

You aren't doing anything wrong, this is merely due to how Wine sees partitions by default.
By default in Wine there are C: and Z: drives. Z: drive is root (/), and since root in Conty is read-only and has no free space, some applications that have free space checks may show errors. Your /home, of course, might have plenty of free space, but for Wine Z:\home is still Z: drive, even if home is  on a different partition (which it is in case of Conty).
However, the solution is pretty simple, just open winecfg and add your /home (or /home/username) as an additional drive (for example, D:).
$ ./conty.sh wine winecfg

Excellent, this did the trick. Thank you.