Use fs.readFile instead of openTextDocument

Fix https://github.com/microsoft/vscode/issues/174888

Interesting choice on TextDecoder, why not just assume the file is UTF-8?

@joyceerhl well in node.js Buffer.toString() would convert to a string using UTF-8.

Oh I see, I guess you're suggesting to do something like this:
Buffer.from(fileContents).toString('utf-8');

I usually use TextDecoder because I almost always want portability across web and node (I know the extension-editing extension does not run in web today but we could port it eventually).

👍

Hm, I am still uncertain why the use of TextDecoder here given the entire code is written for node.js and not web. I see a lot of node.js dependencies. So I would just do the node.js way here.


Ease of Use on Linux

Hi! I've just got a couple feedback notes regarding the linux build script and Readme. I run Fedora 32, and initially ended up rebooting into windows to try this out because I couldn't figure it out last on linux night. I'm not incredibly tech-savy, but am no stranger to building from source either. I understand that with the wide range of distros folks run, linux support can be hard to streamline, but I think this awesome project should ideally be straight-forward to install even for those without experience tinkering, and hope my feedback can help;
Building with cmake as currently recommended in the readme tried to build a binary with Alsa, Jack, and Pulse libs, none of which it could find, but a hackernews thread suggested building with g++ -O2 -march=native -mtune=native -D__LINUX_PULSE__ -D__LINUX_ALSA__ -D__UNIX_JACK__ lcc_rtaudio.cpp RtAudio.cpp -o lcc -pthread -ljack -lasound  -lpulse-simple -lpulse.
Removing the Jack/Alsa bits and installing pulse's devel packages and was all I needed to do.
I ran into another issue during setup. The directions suggest creating a sink with module-combine-sink, joining the system output to the speakers much like the virtual cable does in the Windows instructions, but the issue is that RAudio pipes the sink monitor to the speakers, and the sink itself (being a combined sink module with the stereo speakers configured as a slave) also outputs to the speakers, creating the audio equivalent of seeing double. I fiddled with my pulseaudio inputs and outputs for a bit, but once I was sure no configuration was going to fix this, I resolved it by instead using module-null-sink to make a sink without any slaves to serve as our virtual cable.
As mentioned, I'm not incredibly tech-savy, and curiously can hear a distinct difference between outputting to my speakers and outputting through the null-sink even with LCC set to Off, so not everything is quite right (it's boom-ier, for lack of a better desc.; maybe the jack and alsa deps were important), but this has been my experience building and running LCC on Fedora. I absolutely love the effect and the strong center channel it creates.
I look forward to information on Parameter Tuning, as my only remaining complaint is that the enhanced echos and reverberations (as well as "ambient" center-channel sounds like white-noise, water, and wind sounds in mixes) tend to be much too clear, and can sound grainy, gritty, or harsh. I imagine I could EQ it out, but would be thrilled to have a deeper understanding of what's happening and whether any of the provided settings could help (LLC_decaygain?). Thanks for doing this awesome work c:

I wrote the linux instructions.
Thank you for the correction with pulseaudio.
I maintain a fork that is developed on linux.
I added updates there according to your feedback.
https://github.com/adct-the-experimenter/lcc
I may make a pull request in the future soon.


Testbranch

Pull Request Test Coverage Report for Build 3826

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 36.225%

Totals

Change from base Build 3824:
0.0%

Covered Lines:
2712

Relevant Lines:
6673

💛  - Coveralls


CLI option collisions

It seems like Electron or something reacts to some options like --debug (prints "Debugger listening on port 5858"). Also, all browserify options should go after a -- stop to ensure we don't run into collisions with hihat options (like proposed --node option #7).

fixed


rework sample code for Microsoft Graph Starter

@xscript @yungez @aovechki

@ZhijunZhao,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   71.95%   71.95%
=======================================
  Files          58       58
  Lines        1216     1216
  Branches      117      117
=======================================
  Hits          875      875
  Misses        274      274
  Partials       67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1147e1...d1bafa2. Read the comment docs.


Pylance should detect methods of a cached_property

Environment data

Language Server version: pylance v2022.4.0
OS and version: Windows 10, VS Code 1.66
Python version (& distribution if applicable, e.g. Anaconda): python 3.7, anaconda

Expected behavior
Pylance should detect a method of a cached_property. i.e. it should be able to show its documentation for example.
It already works with normal properties.
Actual behavior
Pylance does not find the docs (or definition) of a cached property, but is does when there is a normal property.
Code Snippet / Additional information
from cached_property import cached_property

class MyProperty:
    def method(self):
        """
        Method to find
        """
        pass

class MyClass:
    @cached_property
    def my_property(self) -> MyProperty:
        return MyProperty()

def main():
    my_class = MyClass()
    my_class.my_property.method()

In the main function, the method call is not identified.

When I say method not identified, I mean that when you place the cursor over the method call, it does not find the documentation for example.
Sorry the script was incorrect, I was trying to make a minimal reproducible example, now it is solved. The problem I mentiond happens when using cached_property from the cached_property. This function was not introduced in the python standart library until python 3.8, and my project uses python 2.7.

Pyright (the type checker that pylance is built upon) contains a bunch of special-case knowledge of property. This includes logic to propagate docstrings from the getter and/or setter method to the resulting property symbol. It's able to do this because it has internal knowledge of how the property class works.
Other descriptor classes like functools.cached_property that implement the descriptor protocol are not special-cased, at least not in a general way that always forwards docstrings from a decorated function to the resulting descriptor object. That's not generally possible because a static type checker can't have knowledge of the internal behaviors of all descriptor classes.
There is one way that a descriptor class can indicate to pyright that it acts as a decorator for a getter method and therefore should "adopt" the docstring for the getter method. This technique involves the use of a ParamSpec, which is described in PEP 612.
Currently, the typeshed stubs define functools.cached_property as follows:
    class cached_property(Generic[_T]):
        func: Callable[[Any], _T]
        def __init__(self, func: Callable[[Any], _T]) -> None: ...
        @overload
        def __get__(self, instance: None, owner: type[Any] | None = ...) -> cached_property[_T]: ...
        @overload
        def __get__(self, instance: object, owner: type[Any] | None = ...) -> _T: ...
        ...

If we change the definition to use a ParamSpec, pyright then knows to forward the docstring.
class cached_property(Generic[_P, _R]):
    func: Callable[_P, _R]
    def __init__(self, func: Callable[_P, _R]) -> None:
        ...
    @overload
    def __get__(
        self, instance: None, owner: type[Any] | None = ...
    ) -> "cached_property[_P, _R]":
        ...
    @overload
    def __get__(self, instance: object, owner: type[Any] | None = ...) -> _R:
        ...

I can't tell from your example whether you're importing cached_property from functools or whether you're defining your own descriptor class called cached_property. If it's the latter, you'll need to make a similar change in your code. If you're using functools.cached_property, you could file an issue (and optionally submit a PR) in the typeshed project to update functools.pyi. Pyright and pylance regularly pick up updates to typeshed, so any improvements in these type stubs will be reflected in new versions of pylance.

By using the functools.cached_property, pylance works as expected and find the documentation. The problem appears when using the decorator cached_property.cached_property, where cached_property is a public library: https://github.com/pydanny/cached-property

The cached_property library is completely unannotated, so there's no type information beyond what pyright can infer. I recommend either switching to functools.cached_property or contacting the maintainer of cached_property and encouraging them to add the relevant type information.

Switching to functools.cached_property is not possible as the project I am working on uses python 3.7.
I thought it should be possible to support this in pylance, because PyCharm correctly detects the methods by using cached_property.cached_property, but no idea how pycharm works.

After discussion with the team, we are not going to special case libraries. One option would be to contribute stubs for cached_property.


Wrong icon in iOS multitask view

In iOS, with the app running, press the home button twice to bring up the multitask view. Notice the icon for the app is actually the default Cordova icon.

Good find!

Also in the Settings menu

So it looks like we are missing a few icon types in the dev app, which is why this issue is occurring. This shows which icons are needed for iOS 9.
Specifically:

Icon-Small@3x
Icon-40@3x
Icon-83.5@2x

Icon-Small@3x is the one that fixes this particular issue.
@timkim

Some solution to this bug ??

We just need to add those missing icon files and that solves the issue.
Are you seeing this within your own apps @mikeoliveira?

i work with build in cloud (phonegap build), i copy the images to MyApp\www\res\icon\ios
yet still continues with the bug, Do i need change the config.xml ?

You will need to update your config.xml to use those icons, take a look at that file for this project to see how it is done. But there is a bug with Build where some icons do not get copied over properly. Still working on it.
https://github.com/phonegap/phonegap-cli/issues/636

Hello, I am waiting since cli-6.0.0 (around 6 months) to create apps with phonegap build with the correct icons. Like shown in this thread, the push, the multiview and the settings icon on iphone 6+/6s+ is the default pgb icon.
It would be great if this bug could be corrected by the build team. For us it is a really important bug, you cannot sell app creations with missing icons.
@surajpindoria you are the first phonegap member, who seems to realize, that it is a bug in pgb, thanks for that!!!! All my hope is with you ;-)

Hey @wuppit,
I am chatting with the Build guys now and they are looking into it. I'll post an update when I know more.

The issue with Build has been fixed!
@wuppit @mikeoliveira

That's so fantastic, THANK YOU!!!!!!!!

Tested this out, above commit does the trick.

I changed config.xml and added the icons but the problem wasn't solved.


Cilium Agent fails on Fedora Core 40 if SELinux is enabled

Is there an existing issue for this?

[X] I have searched the existing issues

Version
higher than v1.16.0 and lower than v1.17.0
What happened?
Unless I disable SELinux, I cannot get the cilium pod to start.  Cilium is being installed on k3s.
Pinging @pchaigno per a chat on Mastodon.
Here's my /etc/rancher/k3s/config.yaml:
cluster-init: true
disable:
  - servicelb
  - traefik
disable-kube-proxy: true
disable-network-policy: true
flannel-backend: none
selinux: true
write-kubeconfig-mode: "0644"

Here's how I am installing cilium:
cilium install \
  --version 1.16.0 \
  --set ipam.operator.clusterPoolIPv4PodCIDRList="<IP_ADDRESS>/16" \
  --set kubeProxyReplacement=true \
  --set operator.replicas=1 \
  --set envoy.enabled=false \
  --set k8sServicePort=6443 \
  --set k8sServiceHost=<IP_ADDRESS>

If prior to running the cilium install I execute sudo setenforce permissive the issue does not occur.
How can we reproduce the issue?

Download Fedora CoreOS 40.20240701.3.0 iso
Add an ignition file to it based on the one below
post-install, log into the host and run export KUBECONFIG=/etc/rancher/k3s/k3s.yaml
run the cilium install command listed above

variant: fcos
version: 1.5.0
passwd:
 users:
   - name: gene
     groups: ["wheel", "sudo"]
     ssh_authorized_keys:
       - ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIBjigwV0KnnaTnFmKjjvnULa5X+hvsy2FAlu+lUUY59f gene@rainbow-planet
systemd:
 units:
   - name: "rpm-ostree-install-k3s-dependencies.service"
     enabled: true
     contents: |
       [Unit]
       Description=Install k3s dependencies
       Wants=network-online.target
       After=network-online.target
       Before=zincati.service
       ConditionPathExists=|!/usr/bin/kubectl
       ConditionPathExists=|!/usr/share/selinux/packages/k3s.pp

       [Service]
       Type=oneshot
       RemainAfterExit=yes
       ExecStart=rpm-ostree install --apply-live --allow-inactive --assumeyes kubectl k3s-selinux

       [Install]
       WantedBy=multi-user.target
   - name: "k3s.service"
     enabled: true
     contents: |
       [Unit]
       Description=Run K3s
       Wants=network-online.target
       After=network-online.target

       [Service]
       Type=notify
       EnvironmentFile=-/etc/default/%N
       EnvironmentFile=-/etc/sysconfig/%N
       EnvironmentFile=-/etc/systemd/system/%N.env
       KillMode=process
       Delegate=yes
       LimitNOFILE=1048576
       LimitNPROC=infinity
       LimitCORE=infinity
       TasksMax=infinity
       TimeoutStartSec=0
       Restart=always
       RestartSec=5s
       ExecStartPre=-/sbin/modprobe br_netfilter
       ExecStartPre=-/sbin/modprobe overlay
       ExecStart=/usr/local/bin/k3s server --kubelet-arg="config=/etc/rancher/k3s/kubelet.config"

       [Install]
       WantedBy=multi-user.target
   # Node shutdown leaves pods with status.phase=Failed and status.reason=Shutdown,
   # so delete them automatically on startup.
   # This may delete some pods that failed for other reasons, but --field-selector doesn't
   # currently support status.reason, so it's the best we can do.
   - name: "k3s-cleanup-shutdown-pods.service"
     enabled: true
     contents: |
       [Unit]
       Description=Cleanup pods terminated by node shutdown
       Wants=k3s.service

       [Service]
       Type=oneshot
       Environment=KUBECONFIG=/etc/rancher/k3s/k3s.yaml
       ExecStart=kubectl delete pods --field-selector status.phase=Failed -A --ignore-not-found=true
       Restart=on-failure
       RestartSec=30

       [Install]
       WantedBy=multi-user.target
storage:
 disks:
   - device: /dev/disk/by-id/coreos-boot-disk
     wipe_table: false
     partitions:
     - number: 4
       label: root
       size_mib: 8192
       resize: true
     - label: var  # not specifying "number", so this will go after the root partition
       size_mib: 0 # means "use the rest of the space on the disk"
 filesystems:
   - path: /var
     device: /dev/disk/by-partlabel/var
     format: xfs
     wipe_filesystem: false # preserve /var on reinstall (this is the default, but be explicit)
     with_mount_unit: true  # mount this filesystem in the real root
 files:
   - path: /etc/hostname
     mode: 0644
     contents:
       inline: fcos-vm1
   - path: /etc/rancher/k3s/config.yaml
     mode: 0644
     contents:
       inline: |
         cluster-init: true
         disable:
           - servicelb
           - traefik
         disable-kube-proxy: true
         disable-network-policy: true
         flannel-backend: none
         selinux: true
         write-kubeconfig-mode: "0644"
   - path: /etc/yum.repos.d/kubernetes.repo
     mode: 0644
     contents:
       inline: |
         [kubernetes]
         name=Kubernetes
         baseurl=https://pkgs.k8s.io/core:/stable:/v1.30/rpm/
         enabled=1
         gpgcheck=1
         gpgkey=https://pkgs.k8s.io/core:/stable:/v1.30/rpm/repodata/repomd.xml.key
   - path: /etc/yum.repos.d/rancher-k3s-common.repo
     mode: 0644
     contents:
       inline: |
         [rancher-k3s-common-stable]
         name=Rancher K3s Common (stable)
         baseurl=https://rpm.rancher.io/k3s/stable/common/coreos/noarch/
         enabled=1
         gpgcheck=1
         repo_gpgcheck=0
         gpgkey=https://rpm.rancher.io/public.key
   - path: /usr/local/bin/k3s
     overwrite: true
     mode: 0755
     contents:
       source: "https://github.com/k3s-io/k3s/releases/download/v1.30.2%2Bk3s2/k3s"
       verification:
         hash: "sha256-3b7f74edcc9b4a7649426b6816a7d3d6d76ddf742384ac63b86ee66e230de758"
   - path: /etc/rancher/k3s/kubelet.config
     mode: 0644
     contents:
       inline: |
         apiVersion: kubelet.config.k8s.io/v1beta1
         kind: KubeletConfiguration
         shutdownGracePeriod: 60s
         shutdownGracePeriodCriticalPods: 10s
   # Schedule automatic updates for 4am PT = 12pm UTC on weekends.
   - path: /etc/zincati/config.d/55-updates-strategy.toml
     contents:
       inline: |
         [updates]
         strategy = "periodic"
         [[updates.periodic.window]]
         days = [ "Saturday", "Sunday" ]
         start_time = "12:00"
         length_minutes = 60

Cilium Version
$ cilium version
cilium-cli: v0.16.13 compiled with go1.22.5 on linux/amd64
cilium image (default): v1.15.6
cilium image (stable): v1.16.0
cilium image (running): 1.16.0

Kernel Version
Linux fcos-vm1 6.8.11-300.fc40.x86_64 #1 SMP PREEMPT_DYNAMIC Mon May 27 14:53:33 UTC 2024 x86_64 GNU/Linux
Kubernetes Version
$ kubectl version
Client Version: v1.30.3
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.30.2+k3s2

Regression
No response
Sysdump
cilium-sysdump-20240729-112931.zip
Relevant log output
gene@fcos-vm1:~$ kubectl get pods -A
NAMESPACE     NAME                                      READY   STATUS                  RESTARTS       AGE
kube-system   cilium-operator-6579888c7d-h79zf          1/1     Running                 0              69m
kube-system   cilium-qh4vw                              0/1     Init:CrashLoopBackOff   18 (78s ago)   69m
kube-system   coredns-576bfc4dc7-w2txz                  0/1     Pending                 0              79m
kube-system   local-path-provisioner-86f46b7bf7-8j5k6   0/1     Pending                 0              79m
kube-system   metrics-server-557ff575fb-m4mpd           0/1     Pending                 0              79m
kube-system   sysdump-kxd5r                             0/1     Error                   0              38m

gene@fcos-vm1:~$ ./k8s-cilium-exec.sh
==== detail from pod cilium-qh4vw , on node fcos-vm1
error: you must specify at least one command for the container

gene@fcos-vm1:~$ kubectl -n kube-system logs cilium-qh4vw
Defaulted container "cilium-agent" out of: cilium-agent, sysdump-1722266971 (ephem), config (init), mount-cgroup (init), apply-sysctl-overwrites (init), mount-bpf-fs (init), clean-cilium-state (init), install-cni-binaries (init)
Error from server (BadRequest): container "cilium-agent" in pod "cilium-qh4vw" is waiting to start: PodInitializing

gene@fcos-vm1:~$ kubectl -n kube-system logs cilium-qh4vw -c mount-cgroup
exec /usr/bin/sh: permission denied

gene@fcos-vm1:~$ kubectl -n kube-system logs cilium-qh4vw -c sysdump-1722266971
Error from server (BadRequest): container "sysdump-1722266971" in pod "cilium-qh4vw" is waiting to start: CreateContainerConfigError

gene@fcos-vm1:~$ kubectl -n kube-system logs cilium-qh4vw -c apply-sysctl-overwrites
Error from server (BadRequest): container "apply-sysctl-overwrites" in pod "cilium-qh4vw" is waiting to start: PodInitializing

gene@fcos-vm1:~$ kubectl -n kube-system logs cilium-qh4vw -c mount-bpf-fs
Error from server (BadRequest): container "mount-bpf-fs" in pod "cilium-qh4vw" is waiting to start: PodInitializing

gene@fcos-vm1:~$ kubectl -n kube-system logs cilium-qh4vw -c config
Running
2024/07/29 01:25:37 INFO Starting
time="2024-07-29T01:25:37Z" level=info msg="Establishing connection to apiserver" host="https://<IP_ADDRESS>:6443" subsys=k8s-client
time="2024-07-29T01:25:37Z" level=info msg="Connected to apiserver" subsys=k8s-client
time="2024-07-29T01:25:37Z" level=info msg="Reading configuration from config-map:kube-system/cilium-config" configSource="config-map:kube-system/cilium-config" subsys=option-resolver
time="2024-07-29T01:25:37Z" level=info msg="Got 126 config pairs from source" configSource="config-map:kube-system/cilium-config" subsys=option-resolver
time="2024-07-29T01:25:37Z" level=info msg="Reading configuration from cilium-node-config:kube-system/" configSource="cilium-node-config:kube-system/" subsys=option-resolver
W0729 01:25:37.678323       1 warnings.go:70] cilium.io/v2alpha1 CiliumNodeConfig will be deprecated in cilium v1.16; use cilium.io/v2 CiliumNodeConfig
time="2024-07-29T01:25:37Z" level=info msg="Got 0 config pairs from source" configSource="cilium-node-config:kube-system/" subsys=option-resolver
2024/07/29 01:25:37 INFO Started duration=49.457083ms
2024/07/29 01:25:37 INFO Stopping
2024/07/29 01:25:37 INFO health.job-module-status-metrics (rev=2) module=health

gene@fcos-vm1:~$ kubectl -n kube-system describe pod cilium-qh4vw
[ trimming bits before events list ]
Events:
  Type     Reason   Age                    From     Message
  ----     ------   ----                   ----     -------
  Warning  BackOff  48m (x114 over 72m)    kubelet  Back-off restarting failed container mount-cgroup in pod cilium-qh4vw_kube-system(c96ec6d7-5f4f-4bc7-938d-af0e0a40b68d)
  Normal   Pulled   3m27s (x192 over 43m)  kubelet  Container image "quay.io/cilium/cilium:v1.16.0@sha256:46ffa4ef3cf6d8885dcc4af5963b0683f7d59daa90d49ed9fb68d3b1627fe058" already present on machine

Anything else?
I have envoy.enabled=false because of the note in the docs that that is not supported under SELinux.
Cilium Users Document

[ ] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I found today that running the install with --set securityContext.privileged=true makes it work. Is this expected behavior?

After running in permissive mode and with --set securityContext.privileged=false what's the output of:
sudo ausearch -m avc -ts today | audit2allow -w -a

I think I got the same issue as @genebean but on OpenSuSE MicroOS instead of Fedora. I'm also running k3s.
So answering the question from @aanm with my own results:

ausearch -m avc -ts today | audit2allow -w -a

type=AVC msg=audit(1734286501.526:469): avc:  denied  { transition } for  pid=11033 comm="runc:[2:INIT]" path="/usr/bin/dash" dev="overlay" ino=62390 scontext=system_u:system_r:unconfined_service_t:s0 tcontext=system_u:system_r:spc_t:s0 tclass=process permissive=0
	Was caused by:
		Missing type enforcement (TE) allow rule.

		You can use audit2allow to generate a loadable module to allow this access.


Update SNAP after installation

Shot in the dark, but I have a feeling this will fix the issue described in https://github.com/DHI-GRAS/crop-classification-workflow/pull/30
Also sets GPT as entrypoint.

if it hit anything

🎯


Confusing Key Rule

Hello,
I am currently using this template for my own key rotation and was wondering about this part of the runbook:
    If ($credentialId -eq 'key1') {         return "key2"     }     Else {         return "key1"     }
https://github.com/Azure/KeyVault-Secrets-Rotation-StorageAccount-PowerShell/blob/main/AKVStorageAccountRotation/run.ps1#L21-L27
I am just beginner so I thought I will ask directly. For me it looks like you are returning key2 when key1 should be returned. In my environment I guess that is why keys are always mixed up. Is there a reason for this or is it just a typo?
Cheers.

The function is to get alternate key. If current key is key1 (which you get from the event), you return key2.
You always rotate alternate key to avoid disruption to application which using current key to connect to Storage.
Based on RP this function needs to be updated - it can be PrimaryKey, SecondaryKey or User1, User2 etc...  You always need to have 2 credentials for resource and rotate alternate one, so application using the key is not disrupted during rotation.


[CP] Fix Windows powershell script not being able to update Dart SDK

Issue Link
https://github.com/flutter/flutter/issues/132592
Commit Hash
7ee864e
Target
beta (3.14)
PR Link
https://github.com/flutter/flutter/pull/132762
Changelog Description
Ensure the existing //flutter/bin/cache/LICENSE.dart_sdk_archive.md is moved before unzipping a new Dart SDK, preventing the powershell script from hanging.
Impacted Users
Windows developers
Impact Description
Once users get on an affected version, their NEXT flutter upgrade will leave them in a bad state where they can't extract the new Dart SDK. Re-running the tool will not help, as the batch entrypoint will still detect the Dart SDK is not present, and then run the powershell script to download and unzip the Dart SDK.
Workaround
The workaround would be to run flutter upgrade until it hangs, kill the process, delete //flutter/bin/cache/LICENSE.dart_sdk_archive.md, and then re-run to complete extracting the zip and building the tool.
Risk
medium
Test Coverage
yes
Validation Steps
No response

https://github.com/flutter/flutter/pull/132669 is currently going through code review, I will ensure it is merged and open a CP PR in the morning.

upstream PR merged, CP PR forthcoming...

CP PR: https://github.com/flutter/flutter/pull/132762

@zanderso can you review, and if approving, add cp: approved label?

lgtm


Build #196 [take 2]

This is the second attempt to meteor-build-client.
I executed meteor-build-client ../docs --path "" the first time also but this time beforehand I did meteor npm install and also tested with meteor in localhost.

@Arachnid idk how to test the meteor-build-client result but I got a different output from meteor-build-client after doing meteor npm install. This may have fixed the build.

Looks like that worked - thank you!


There's no "union" function, use "intersect"

Even if the documentation says there's an "union" function that computes
the union of two sets, looking at Hugo's source code, there's no such
function.
Use "intersect" instead. It's more appropriate, too, because it will
eliminate duplicates in the two lists, if there are any.
Signed-off-by: Marcelo E. Magallon<EMAIL_ADDRESS>

The functions are absolutely not equivalent. See https://gohugo.io/functions/intersect/ and https://gohugo.io/functions/union/.


Add basic code/examples

@all-contributors please add @Neale2 for ideas

alright imma add myself now
@all-contributors please add @catdogmat for code


Videostream crashes when PCMD buffer is empty

This issue is Bebop related, but not sure if it's shared between all ArDrone3 products.
When videostream is enabled and no intermediate PCMD commands of (0,0,0,0) are sent at a fixed time interval, the videostream crashes as soon as a non-zero PCMD command is sent. (e.g. stream video, take off, rotate right/left).
I assume this is because there is some internal caching of the latest PCMD commands for video stabilization & that this buffer does not get bound checked if it's not full yet. Currently, I use a workaround by sending zero-PCMD commands at a fixed time interval while the drone is idle/hovering, but this is not expected behaviour.
Also, there's a noticable delay/hiccup on video when rotating, even with the official app.
Kind regards
Cedric

Hi,
This is the normal behavior of the devices (both on Bebop and on Jumping sumo).
You can find some explanations here, but the basic idea is that your "workaround" is actually the proper way to do.
Regards,
Nicolas.

I understand some packets are needed for wifi quality estimation, but I would assume that the ping messages are used for this (since they inherently are sent at a fixed time interval). Is there any reason PCMD commands are used for this estimator? I can do a flip just fine at a higher framerate so it seems sort of strange that it can't handle the video throughput for a simple rotation.

We use the PCMD as the source of the estimator because they're the most important commands during flight (And because the job of the estimator is to make sure that these commands are not blocked by the video, as a wifi link is in fact half-duplex).
We could use any other periodic commands, but tests proved that using the PCMD commands directy gave a better reaction time (lowering the bandwidth of the video when the wifi quality lowers, so the piloting is still possible) than other tested methods.
Regards,
Nicolas.

Thank you for your fast response.
It's not an intuitive solution, but I understand the reasons behind it.
Perhaps this should made be more clear in the documentation.
Kind regards,
Cedric


Glitched Actor lists

While searching how Impa's working I searched in the scene where the actor is used, and I noticed that the latest alternate header of the spot00 (hyrule field) scene (spot00_room_0ActorList_001D40) has a glitched actor list that extends after what should be the end of the array

(since #266 replaced #224, the fix for this issue, it can be closed now)


Adjust docker image to support mac

At the moment, the docker image used to build apps requires Linux (user id = 1000).
Add support for mac users (at least user id 501)

This will require complicated workaround for Docker. At the moment, we recommend using Linux for development purposes.


Bumping versions to fix vulnerabilities

Describe the bug
Hi again, I'd like to suggest a PR bumping vulnerable dependency versions to avoid the known vulnerabilities in them.
Example: I'd like to bump decode-uri-component to the 0.2.1 version in order to avoid GHSA-w573-4hg7-7wgq.
There are currently 68 vulnerabilities to be fixed (according to Scorecard analysys), let me know whether a PR would be welcome and I'll start to work on them right away.
Thanks!
Expected behavior
None
Reproduction code
No response
Reproduction URL
No response
Version
main
Environment
No response
Additional context
No response

If it's a casual bump should be fine to accept PR, however meanwhile would like to understand how it actually exposes a vulnerabilities as rxjs does not have any dependencies.

The one I've mentioned (GHSA-w573-4hg7-7wgq) is a dependency of the "decision-tree-generator" tool.
But for each one I solve I will try explain in the PR how the vulnerable dependency would impact users or the project.

Hi @kwonoj I've explored more the finding vulnerabilities (I've started with the package.json and package-lock.json on the root folder) by starting with handling the vulnerabilities reported by npm audit:

The changes related to the npm audit fix --force run can be seen in the following PR https://github.com/joycebrum/rxjs/pull/2/files --- I've created the PR to wait for #7341 resolution and use the ci to validate each upgrade I've made (the local run of npm test and npm run compile did run with success, but I'd like to double check).
In the meantime, I've analyzed the vulnerable dependencies and they were all either dev dependencies or docs_app dependencies, so there won't be any breaking change for the end users. Although the attack surfaces are a bit different for dev and runtime dependencies, it is still important to try to use not vulnerable dependencies whenever possible, but let me know what you think.
Besides, I may take some time to work on all the vulnerabilities.

Ah thanks for bringing that up. I was struggling too to be able to correctly bumping the right versions since there are lots of vulnerabilities found in indirect dependencies 😓  (sometimes deep in the dependency tree).
Let's wait this changes and hopefully the work here will be simpler. Feel free to ping me when that got merged!


Move travis decrypting to after_success.sh (no pull requests)

This PR should fix travis failures on pull requests. As @ajkannan spotted encrypted variables are not available to pull requests from forks, as documented here:

Encrypted environment variables are not available to pull requests from forks due to the security risk of exposing such information to unknown code.

This PR moves the decrypting code to the after_success.sh script and avoids running it on PRs.

Yep -- someone could have a PR that echos out encrypted variables... exposing our deployment keys for example... Anything that needs encrypted stuff (ie, system tests) running after the merge seems reasonable to me.

Looks good, thanks for the fix.


⚠ Bofrost.be has degraded performance

In 6eae5a4, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1125 ms

Resolved: Bofrost.be performance has improved in 0ef1ffd.


Please build a preview release.

Those of us on Android Q beta can't use scrcpy until a new build is released with the recent Q commits.
I've tried building it multiple times and constantly run into issues as the instructions leave out a ton of important steps.
Thanks for the awesome work thus far!

Those of us on Android Q beta can't use scrcpy

Why that? Only the "turn screen off" feature should be broken on Android Q in v1.9. Is there anything else?

Why that? Only the "turn screen off" feature should be broken on Android Q in v1.9. Is there anything else?
So it was! I was having weirder display issues, testing it again and everything seems to be working much better. Not sure what I was thinking that I got that all mixed up.

For which platform do you try to build? What are the problems you encounter?
I was using the latest release of Ubuntu. After multiple attempts I actually got everything released on it and was able to build the app, but I use Windows on my main machine that I want it on so that was a waste. I have yet to be able to get the MakeCrossfile.Windows work and just gave up after a while. Ran into too many java related issues or server location issues.

I will probably start over and try again sometime in the future after I'm less annoyed at it. My main point of contention was that the wiki specifically states "Don't worry, it's not that hard" and then it ends up being much harder because there are a lot of in between steps that aren't included so you're constantly trying to install something new or configure something else.

there are a lot of in between steps that aren't included

What are those steps not included?


code doesn't upload - warning: espcomm_sync failed

ludo@idefix:.../esp8266/esp8266-dht22-sensor % platformio run -t upload
Building .pioenvs/esp01/firmware.bin
Looking for upload port...
Auto-detected: /dev/cu.SLAB_USBtoUART
Uploading .pioenvs/esp01/firmware.bin
warning: espcomm_sync failed
error: espcomm_open failed
error: espcomm_upload_mem failed
*** [upload] Error 255
======================================================= [ERROR] Took 17.42 seconds =======================================================
ludo@idefix:.../esp8266/esp8266-dht22-sensor %

Fixed! In changing the board type, I use a NodeMCU board.
ludo@idefix:.../esp8266/esp8266-dht22-sensor % git diff                                                                       22:03 #4327
diff --git a/platformio.ini b/platformio.ini
index 123995e..10c0333 100644
--- a/platformio.ini
+++ b/platformio.ini
@@ -18,9 +18,10 @@
 # targets = upload

 [env:esp01]
-platform = espressif
+platform = espressif8266
 framework = arduino
-board = esp01
+board = esp12e
 targets = upload
 # Optimize for binary size
 #build_flags=-Os
+lib_deps = 19
ludo@idefix:.../esp8266/esp8266-dht22-sensor % ```


cryptomator portable 1.6.1-8 does not load settings on system start up

Hi guys,
thanks for the amazing work.
I just faced an repeatable issue:
When Cryptomator starts on system start up on Windows 10 Enterprise, it does not load the settings.
After exiting Cryptomator and starting it once again, all setting were loaded.
Greetings

@marcus3333 If you have enabled "Start on startup" through the UI then yes it's normal that it doesn't work because it will not run the cryptomator-portable.exe wrapper. Check in the Windows Task Scheduler setting the path to the exe and set it to cryptomator-portable.exe.


Added the SVG coloured heart icon:

Removed the heart emoji
Added the SVG heart icon in app/assets/images/emoji/heart.svg

Resolves #153
Description

Added the heart icon in app/assets/images/emoji/ directory.
Successfully replaced the emoji with the icon

Type of change

Bug fix (non-breaking change which fixes an issue)

Screenshots

Awesome! Thank you for this contribution!


[EC-66] Provide support for download of the state trie (as the host)

This PR add sending of MPT / contract storage / evm code when doing fast download

Apart from some of the things mentioned on #50 and that maybe we should have some tests for MptNode downloading, LGTM!

Will add test for that
śr., 22.02.2017, 16:07 użytkownik Nicolás Tallar<EMAIL_ADDRESS>napisał:

Apart from some of the things mentioned on #50
https://github.com/input-output-hk/etc-client/pull/50 and that maybe we
should have some tests for MptNode downloading, LGTM!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/input-output-hk/etc-client/pull/57#issuecomment-281695579,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABovlDXwilER-h06QiE0JaOBtySDUbK2ks5rfE8-gaJpZM4MInQx
.

I changed encodeUncles
because I was getting warning
[warn] /Users/adam/iohk/etc-client/src/main/scala/io/iohk/ethereum/network/p2p/validators/BlockValidator.scala:37: reflective access of structural type member method encodeUncles should be enabled
[warn] by making the implicit value scala.language.reflectiveCalls visible.
[warn] This can be achieved by adding the import clause 'import scala.language.reflectiveCalls'
[warn] or by setting the compiler option -language:reflectiveCalls.
[warn] See the Scaladoc for value scala.language.reflectiveCalls for a discussion
[warn] why the feature should be explicitly enabled.
[warn]     val encodedOmmers = encode(BlockBody.rlpEncDec.encodeUncles(block.body.uncleNodesList))
[warn]                                                    ^
[warn] one warning found

LGTM


Code sample
Example from quick start - https://github.com/satya164/react-native-tab-view#quick-start
Screenshots (if applicable)
left devices on the screen is ios - all good, and on the right is android - second scene is visible

Your Environment

software
version

ios or android
android

expo
react-native-web 0.14.4

react-native
0.63.4

react-native-tab-view
2.15.2

react-native-gesture-handler
1.9.0

react-native-reanimated
1.13.2

node
15.2.1

npm or yarn
yarn 1.22.10

I ran into the same issue, too. It turns out that it happened in 2.13.0. The culprit seems to be caused by the change in TabView.tsx which wraps the Pager in GestureHandlerWrapper.
I wrapped the TabView inside a View with the same style, and this issue is resolved.
    <View style={{ flex: 1, overflow: 'hidden' }}>
      <TabView />
    </View>

Hope this helps.

I ran into the same issue, too. It turns out that it happened in 2.13.0. The culprit seems to be caused by the change in TabView.tsx which wraps the Pager in GestureHandlerWrapper.
I wrapped the TabView inside a View with the same style, and this issue is resolved.
    <View style={{ flex: 1, overflow: 'hidden' }}>
      <TabView />
    </View>

Hope this helps.

I ran into the same issue, too. It turns out that it happened in 2.13.0. The culprit seems to be caused by the change in TabView.tsx which wraps the Pager in GestureHandlerWrapper.
I wrapped the TabView inside a View with the same style, and this issue is resolved.
    <View style={{ flex: 1, overflow: 'hidden' }}>
      <TabView />
    </View>

Hope this helps.

I did it, but I want it to work correctly by default from library.

I ran into the same issue, too. It turns out that it happened in 2.13.0. The culprit seems to be caused by the change in TabView.tsx which wraps the Pager in GestureHandlerWrapper.
I wrapped the TabView inside a View with the same style, and this issue is resolved.
    <View style={{ flex: 1, overflow: 'hidden' }}>
      <TabView />
    </View>

Hope this helps.

I did it, but I want it to work correctly by default from library.

Closing since overflow is hidden by default in latest version.


Fix double precision attribute transitions

Change List

Handle 64bit attribute
Fix issue in transitioning normalized buffers

Coverage decreased (-2.7%) to 80.909% when pulling f02c56f48109fd3f8ef04f2e4e5858bb1bf1f052 on x/attribute-transition-fix into 4ff387e3d455b7f062ac8c464b889729b11e08d4 on master.


I need help POKEMONGoMap

I need help with PokemonGoMapWin program, install it tells me the error below (Put the link of the image) and can not start properly, by placing my ID did not load maps tells me there is an error with the javascrit and not and fix it.
I hope you can help me ...
Windows 10 PRO 64b
http://oi65.tinypic.com/2ec0ynd.jpg

Unfortunately this has nothing to do with Google Play Music or GPMDP and I fail to see why your asking for help here. I would ask for help wherever you received that software.


Nested directory structures

Not sure if it is problem of Erebos or actually Swarm, but it is not possible to add nested directory structure using uploadDirectory method.
For example
const dir = {
      [`foo-${uploadContent}.txt`]: {
        data: `this is foo-${uploadContent}.txt`,
        contentType: 'plain/text',
      },
      [`bar-${uploadContent}.txt`]: {
        data: `this is bar-${uploadContent}.txt`,
        contentType: 'plain/text',
      },
      [`some/folder/bar-${uploadContent}.txt`]: { // <-------
        data: `this is bar-${uploadContent}.txt`,
        contentType: 'plain/text',
      },
    }

The file some/folder/bar-${uploadContent}.txt is not uploaded, or at least the list() does not return manifest that would either return the whole entry some/folder/bar-${uploadContent}.txt or at least some that would point to nested manifest.
Not sure what is the correct behavior or if it is a problem of Swarm, yet this is definitely unexpected behavior.

Could you open a PR with a test case please?
I just tried it out locally and it worked as expected, I could see the folder in the common_prefixes array of the manifest.

Hmm maybe I am missing something from my not-complete understanding of Swarm, but I have created the #120 that for me locally fails.

Yes I think there's a misunderstanding of the expected behavior, the payload of the bzz.uploadDirectory() request and bzz.list() response are not the same, as you can see in the DirectoryData and ListResult interfaces.

Yeah, you are right. Thanks for the insight!


Ensure result computing dask.array.isnull() always gives a numpy array

pandas.isnull() will return Python booleans when given Python scalars as inputs,
which can break things in strange ways, e.g., as manifested in #3822.
I still don't know exactly what went wrong there, but this fixes it.

[x] Tests added / passed
[ ] Passes flake8 dask

Well, pandas.isnull can definitely only handle NumPy arrays. In the long
term, we probably want to switch to relying on our own version of this
helper function in xarray.
On Sat, Jul 28, 2018 at 8:22 AM Matthew Rocklin<EMAIL_ADDRESS>wrote:

Looks good. Thanks @shoyer https://github.com/shoyer. Merging.
I wonder if, in the future, we'll regret adding np.asarray calls within
the codebase if we have sparse/gpu/other ndarray containers floating around.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/3825#issuecomment-408614973, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABKS1kcyBMJIDZvFiaVP6VGVGXN9iLXNks5uLIGzgaJpZM4Vk7oi
.


"Look rotation viewing vector is zero" spam in The Forest

Noticed this happened with one player connected, not sure if it's triggered by a cheat or what.

Not currently an issue that I can see.


Changes to Sonarqube helm chart to add MySQL support instead of Postgres.

So I made few changes to the Sonarqube base chart to add MySQL support , currently we have Postgres as the database in Sonarqube chart.
Wondering if this could be a new chart in the chart repo ?

Hi @irajdeep ! Do you mind explaining a little bit more about the nature of the change that you made? I'm wondering if instead of a new chart, it would make the most sense to use values.yml to allow the user to control whether they wanted to use postgres or mysql in the sonarqube chart?

Hi @mattjmcnaughton ! Sure. So the changes are primarily in values.yml file and in few changes in deployment.yaml and requirements.yaml. We can go ahead with adding the mysql support in the same helm chart but what I am concerned about is that it will cause a bunch of if/else statements in couple of file.
So primarily there would be 4 cases , if we decide to go with the same helm chart.

postgres : external / internal
mysql : external / internal
I feel adding both the options in the same chart might create confusion ( Something like turning on both the database options which might lead to inconsistent sonarqube behavior)  to the users of the chart in addition to introducing a bunch more of logic in the existing chart .  What would you suggest ?

@rjkernick your views ?

I would rather some if statements than a separate chart that will need managed. It's easy enough to follow the pattern that is there for postgres and add some templating for mysql.

/assign

Alright, So just to clear we are on the same page , a given release could have either Postgres database (internal / external) or MySQL database (internal / external) right ?

Yep. Sounds good. Look forward to seeing it in action.


python version and pip version

please tell me,  which python version and pip version used by salesgpt?  i  cannot run this program now

now i use python 3.7.2,but it doesn't work.when i pip openai package , it show me 2 errors


LUCENE-9356: Change test to detect mismatched checksums instead of byte flips.

This makes the test more robust and gives a good sense of whether file formats
are implementing checkIntegrity correctly.

do we really need the linefiledocs? If the test has rare failures, we'll want to reproduce them.
practically, linefiledocs just prevents reproducibility (uses a different file in CI than developers use, etc). I'd avoid it.

I removed the dependency on LineFileDocs. Interestingly, this test caught an issue with vectors, which don't close index inputs on all paths. cc @mayya-sharipova since there are in-progress PRs that make changes to vectors formats

Thanks Adrien for catching errors with vector files.


How to process longer Video-Files ?

Hi there I just tested the tool, but it is not able to process bigger video files, because the option that is recommended "stream=true" isn't available.
Any Idea ?
Best regards

I processed 1 minute long videos @ 25 FPS fine.
I recently came across a much more effective video handler, Decord. Which makes io more efficient. You could change the video reader using that, and see it it helps.
What exactly is the error when you say 'unable to process'?
If its system memory issues, i'm unaware how cv2.VideoWriter operates, but it may somewhere be accumulating things on the CPU memory.
A fix would be to simply dump the blurred frames of a large video, and then create a video of it, rather than writing it with the writer which probably is accumulating stuff.


New Colors added

Now all CSS default colors included as requested #268

I wonder if a large number of static instances might negatively affect build and/or load time? I think we need to answer that question before introducing so many names. I think we strip unused stuff, but that's later after build, and possibly not on debug builds.
@duckers Any idea on that?

Yeah I'm not too keen on adding a lot of bloat to a "plain fuse app". These colors (including their string names) can never be stripped away from any export, because {Resource xxx} must find these as a global fallback.
Instead, let's add colors to packages that are optionally linked in to projects.
For example, create a new package called Fuse.UXKits.CSSColors and declare the colors there. They should also be declared in UX files as ux:Global to make them easier to maintain.

I'll give that a try. Thanks for the comments.


unused-variable improvement

Would be nice if the unused variables weren't checked for as part of function arguments, i.e.
Wreck.get('https://google.com/', function (err, res, payload) {
    /* do stuff */
});

Here I will use err and payload, but the res which I have no choice but to add since the function signature shows up this way, will still be reported.  This is annoying if I can't do anything about it.
Function signatures should be ignored because you'll want to show what was passed.

This change has already been made in v3.0.1. See https://github.com/hapijs/lab/issues/453 for the discussion.

ah, perfect :)


Instructions frame

Safely allow entry of HTML/CSS.

Currently just allowing HTML b/c anything we host is manually reviewed, but should clean to allow limited set of tags & avoid scripting (probably)

Moved to lookit/ember-lookit-frameplayer#37


Showing displacement as collour?

On the bottom left you can see the colorramp is connected to the base color (which is connected to the material output node) Everything seems as it should be but still I'm getting the wrong color on my mountain, please help :)

Great addon btw!

Nvm found the problem, bump node was connected to the emission of the material (for some reason)

What should the bump node be plugged into?

What should the bump node be plugged into?

This new release fixed this issue. Please update.
https://github.com/oormicreations/Blendpeaks/releases/tag/0.1.6

I just installed 0.1.6 and it's working as expected. Thanks!


Filter ROIs in ROI connectivity table

Some filter function would be useful to select and show fewer ROIs.

meant for neuPrintExplorer


MotionLayout Custom custom property bug

The custom property bug is due to different lifecycle it seems
The calls are captured before the layout
example -- proper interpolation of
1/ custom colors (top/bottom colors of the gradient)
2/ some float value, used to compute final color and thus distinguish between "current item" vs others (the current item has value of 1, rest have nothing so
0). So no need to have a notion of progress or who's the main item, just have the option to pass the motionproperties and use them.
https://user-images.githubusercontent.com/15019413/173118367-db978754-77cd-4069-bafd-9668a98a044a.mov

Current tip of tree showing the broken behavior:
https://user-images.githubusercontent.com/23424811/173119478-9ba68043-c9b2-4b7c-b757-d81f45dfe9fb.mov

I think it might work by just calculating the custom properties with the motionProgress value at recomposition. I think the custom properties should work more like a stateless class that gets updated during composition with the progress value and transition to interpolate.


Use Icon with Toast?

Is there a way to use an Icon with Toast? If so, how would I float the icon to the right?

As per design guidelines, Icons are not part of Toast
So we wont have this with our toast
But if you want to have this with your project, you can go ahead with fork and modify as per your need


Projection wms sample

Reproduction of this https://github.com/Mapsui/Mapsui/issues/1918 (No fix yet)

Things done:
Fixed Projection Provider (Resolution was not projected).
Fixed WmsProvider Extent (Axis switch)
Fixed WmsProvider general axis switch not only 4326
Added Projection Wms Sample


Added support for vertical markers in Line Charts

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
Feature enhancement: https://github.com/reaviz/reaviz/issues/109

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 109
What is the new behavior?

Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@shaswat-indian - I just realized that in your implementation the lines are fixed. Those should have been a value based ... like
{
   key: date,
   data: [5, 10]
}

and then line would start at 5 and go to 10 height wise.


Bug: The example config has a mistake

The example options code in README.md has a mistake. It needs a ',' after " options = {} ".
Thanks.

Thanks, it's fixed


Own lists in Trakt gives 401 bad requests

Elementum can't display my Trakt lists anymore. I can briefly see the error from line 408 in the kodi.log in Kodi notification popup.
TV-show Progress, Watchlist, Collection, every Trakt list I try come up as bad request. This is also not an isolated incident. Confirmed on another box running Devuan (Debian old stable) with Kodi 17.1. This happened the first time almost a week ago I believe.
kodi.log

You should try to re-authorize Trakt in Elementum.
Settings -> Trakt

Okay, That fixed it, but I don't understand why it broke in the first place? I didn't try to reauthorize since my Trakt account was visible in Elementum and in the kodi.log so I assumed smthng else was wrong. Also it broke on another box with another Trakt account which got Elementum installed at a much later date which furthermore added to my assumption about a something else broke. I'll go ahead and reauthorize that box as well. Thanks for a great addon!

@ThurahT Trakt does authorization of a session, so maybe they have invalidated it. It seems they can do it if token was not used for some time. That happens sometimes.

Trakt errors regarding authorization now show with an alert in Kodi.


How do you create the first Gogs user via the API ? What's missing?

Upon fresh install, I've tried POSTing to the /admin/users following the API and I get a 403.
After disabling CAPTCHA
curl -X POST -i 'http://gogs/api/v1/admin/users ' --data '{ "source_id": 1, "login_name": "apiuser", "username": "apiuser", "email"<EMAIL_ADDRESS>"password": "password" }'
[Macaron] 2019-03-26 23:47:54: Started POST /api/v1/admin/users for <IP_ADDRESS>
[Macaron] 2019-03-26 23:47:54: Completed POST /api/v1/admin/users 403 Forbidden

Is this possible or does Gogs not allow the first user to be create via the API ?

How do you create the first Gogs user via the API ?

You can not.

How do you create the first Gogs user via the API ?

You can not.


HeanCMS: Add login preference

The extension is sending the Authorization header, but i can't test if this actually get the pages (maybe @vinaysb can help)
Closes #2056
Closes #2079
Checklist:

[ ] Updated extVersionCode value in build.gradle for individual extensions
[x] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[ ] Added the isNsfw = true flag in build.gradle when appropriate
[x] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[x] Have tested the modifications by compiling and running the extension through Android Studio
[ ] Have removed web_hi_res_512.png when adding a new extension

Just tried it out, the login does work. But the images do not load anymore. Based on some tinkering I did, I think its because the images them self do not need the auth token (atleast this is the case for omega scans).

I removed the authHeaders from imageRequest, is working now?

Yes it works right now 👍

@vinaysb can you test again?

@bapeey it is still working


docs: Update BUILD.md

Fixes #135

CI Vulkan-ExtensionLayer build queued with queue ID 8600.

CI Vulkan-ExtensionLayer build # 200 running.

CI Vulkan-ExtensionLayer build queued with queue ID 8615.

CI Vulkan-ExtensionLayer build # 201 running.

CI Vulkan-ExtensionLayer build # 201 passed.


Stoped in ..Initializing

Hello
Just I installed the addon in my Home Assistant 2023.5.3.
Everything was ok, I got permissiona to my Ondrive account after linkt ik, but the addon is stopped in Initializing..
The log show several mentions to "Microsoft.Graph.ServiceException: Code: accessDenied"

This is the log in verbose mode.
05/17/2023 10:51:26 [8] Info: Backup interval configured to every 72 hours
05/17/2023 10:51:26 [8] Info: File Sync Disabled
05/17/2023 10:51:28 [8] Error: Error getting free space: Status Code: Forbidden
Microsoft.Graph.ServiceException: Code: accessDenied
Message: Access denied
Inner error:
AdditionalData:
date: 2023-05-17T08:51:28
request-id: 11acc314-3803-4b26-b20b-f2ede9031ff1
client-request-id: 11acc314-3803-4b26-b20b-f2ede9031ff1
ClientRequestId: 11acc314-3803-4b26-b20b-f2ede9031ff1
at Microsoft.Graph.HttpProvider.SendAsync(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationToken cancellationToken)
at Microsoft.Graph.BaseRequest.SendRequestAsync(Object serializableObject, CancellationToken cancellationToken, HttpCompletionOption completionOption)
at Microsoft.Graph.BaseRequest.SendAsync[T](Object serializableObject, CancellationToken cancellationToken, HttpCompletionOption completionOption)
at Microsoft.Graph.DriveRequest.GetAsync(CancellationToken cancellationToken)
at hassio_onedrive_backup.Graph.GraphHelper.GetFreeSpaceInGB() in /src/Graph/GraphHelper.cs:line 215
05/17/2023 10:51:28 [8] Error: Unexpected error. System.NullReferenceException: Object reference not set to an instance of an object.
at hassio_onedrive_backup.Hass.HassOnedriveFreeSpaceEntityState.UpdateOneDriveFreespaceSensorInHass(OneDriveFreeSpaceData freeSpaceData) in /src/Hass/HassOnedriveFreeSpaceEntityState.cs:line 29
at hassio_onedrive_backup.Orchestrator.Start() in /src/Orchestrator.cs:line 77

To mention that the account that I want to link is a deveolper account. I had no issues to link with rclone, and sync drives. I'm not sure if this is part or the root cause of my problem

Hi,
What do you mean a developer account ? This requires a personal MS account. Work / School account (OneDrive for business) is not supported.

Hi I have the same issue, with a personal account, on 2023.04.6
Seems to have stopped backing up yesterday or two days ago. No upgrades on my system, a reboot didn't change anything. Maybe something  changed on MS's side?

Maybe something in the token was revoked. Coudl you try to uninstall and reinstall see if this still happens so we rule out anything API related ?

Maybe something in the token was revoked. Coudl you try to uninstall and reinstall see if this still happens so we rule out anything API related ?

uninstall and reinstalling fixed it me for me (so far).


OpenAPI 3.0

Thanks for the amazing project. I'm not involved at the moment and don't expect anything.
OpenAPI 3.0 Spec has been out for a while, I was wondering if there are any plans for supporting that? Thanks <3

I am interested in contributing to this. My employer is using the gem for one of our projects and we'd like to be able to use OpenAPI 3.0 features. Is there anyone else working on, or interested in working on this capability?

I'd be interested in contributing to this as well. I'm using openapi-generator to generate API clients, and it looks like there's only a few errors that I need to fix:
Exception in thread "main" org.openapitools.codegen.SpecValidationException: There were issues with the specification. The option can be disabled via validateSpec (Maven/Gradle) or --skip-validate-spec (CLI).
 | Error count: 4, Warning count: 0
Errors:
	-attribute paths.'/templates'(get).[per_page].max is unexpected
	-attribute paths.'/templates'(get).[per_page].min is unexpected
	-attribute paths.'/templates'(get).[page].min is unexpected
	-attribute paths.'/templates/{template_id}/submissions'(post).[create_submission_body].properties is not of type `object`

	at org.openapitools.codegen.config.CodegenConfigurator.toClientOptInput(CodegenConfigurator.java:559)
	at org.openapitools.codegen.cmd.Generate.run(Generate.java:341)
	at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:62)

I'd also be interested in this

@tadassce have you maybe progressed on this issue?

@domaindrivendev thanks for the project! just bringing your attention to this issue. Do you have any plans re this one? Thanks again!

+1

+1

I am interested in contributing to this. My employer is using the gem for one of our projects and we'd like to be able to use OpenAPI 3.0 features. Is there anyone else working on, or interested in working on this capability?

I'd like to contribute to this as well. We are using rswag extensively in our projects, and current version isn't enough for us. Especially for multiple requests/responses, e.g. oneOf.

I am currently working on a 3.0 compliant fork off of this gem. I am not sure exactly the right way to proceed however. One decision I made early on in coding up the 3.0 complaint version is that for simplicity it would NOT be backward compatible with 2.0 swagger output. Basically if you want to generate 3.0 swagger, you would use the open-api-3-rswag gem.
I find rswag to be an incredible library, we have adopted it at a couple projects - and its made an enormous impact. It seems like the current owner is not too interested in adding new features, moving to 3.0. It looks like PRs are kind of stagnating, etc. Which is perfectly fine!! :) He has certainly done more than his fare share, at his leisure he can progress it when (if?) it suits him. Thank you @domaindrivendev and all who have created the gem as it is today.
So, my fork has a branch that has 3.0 compliant output working right now in very limited scenarios. It is NOT ready for global use. I am working on updating all the existing specs to pass given the 3.0 structure shift in output. I also like some defaults for capturing request and response output in the generated swagger, and made some opinionated decisions to incorporate these into the framework.
Eventually, I would like to release a 3.0 version of my branch to a different named gem (open-api-3-rswag or something) assuming that is ok with the original owner @domaindrivendev. I really haven't contributed much before, so I think that is the proper etiquette - but please let me know if not.

https://github.com/jdanielian/open-api-rswag
If you are interested in watching the progress- here is the repo. I need to update the readme, add some additional tests, and update the Travis CI script to publish the gems to rubygems.org.
So be patient, but I have a 3.0 compliant version of this pretty close to working. Eventually I’ll be a maintainer, open it up to contributions etc. So my goal is that we’ll have an OpenApi 3.0 version of this fabulous gem ready to go soon!

@jdanielian heads up, its OpenAPI not OpenAPI so maybe the repo name should be openapi-rswag. Cool to see you're doing the work!

@jdanielian that was awesome!

Hey @jdanielian this is great! I noticed you don't have issues enabled for the repo though, so what is the best place to file bugs?

@jdanielian and other readers to this issue. This gem is now part of an organization, I'll be looking into potential OpenAPI 3 upgrades including your fork of the gem. I'd love to see if we can pull your contributions back in to the main line, or upgrading to it by other means. And other contributors are always very welcome to a project.

That is fine - not sure you will be happy with my work, as I made some opinionated decisions on NOT making the 3.0 branch backwards compatible. But feel free to take what you need.

@jdanielian thanks for such a great work. I've noticed too that Issues are disabled for your fork. I have a question about request_body_json. It's a bug or I missunderstood documentation.

@jdanielian Amazing work! Thank you.

@BookOfGreg  - Ready to volunteer so I can update my API docs.  You have any contrib guidelines to follow?

Contributors always welcome. Contributing.md
Currently I've been making a list of things to remove and add for OpenAPI3, theres incredibly little docs for the differences between the two because they almost always point to the automated tools which isn't a huge help when I'm trying to make an automated tool 😆 .
The trick is trying to do it in a way that causes us no breakages which I think I can actually do.

@BookOfGreg this spreadsheet with all the keywords might help you keep track of it all. https://docs.google.com/spreadsheets/d/1KT7WlHM5ED-yWbLEovEGjN8ieqnY2_agkj3pkRRAw1Y/edit?usp=sharing
I made this working on things for @stoplightio, trying to make sure our OAS2 and OAS3 support is as complete as possible. Just chuck in "Y", "No" or "na" and it'll count things up.

I can't access this at work but I will be working from this soon enough, this is very appreciated.

Are there any timetables for either getting the fork (or similar features) into the mainline? I'd prefer to avoid switching to a fork that has/will diverge from where the main gem is heading/headed.

I'm doing this in my own personal time and nobody seems to be helping so I can only say it will happen when it happens. I'm one person and this is open source.
The difference between the fork and this is I'm going to try do it while maintaining backward compat, probably by detecting if you're writting to a swagger 2 or 3 file and allowing extensions for openapi3 if you're on it.
Phil Sturgeon above already posted an extremely helpful guide on the differences between the two for me so that will make the job easier when we get to it.

@BookOfGreg being able to support backwards compatibility is great. however, this issue has been here for two years now. imo it's a lot more beneficial to have working but breaking support for 3.0 than no support at all.
It'll be helpful if you can clarify the direction of you're taking with this gem, as well as the best way for folks to contribute (is there a todo or wish list? do you have a wip PR folks can contribute to?).
Many thanks for doing this!

I normally try to +1 in emoji, but I just had to say I 100% agree with @zinosama - 3.0 support is more important than backwards compatibility in my mind and for my use cases.
Also agree that having a clear framework in place for contributing (what needs to be done etc) will go a long way.

Agree, we would like to try it and help too. Maybe this would be more than a PR (until it is ready to merge back into this repo). Would it need a repo fork with its own issues and so on? And yes, definitely breaking change would be fine for us too.

https://github.com/rswag/rswag/pull/286
Nearly there.

Merged. Version 2.3.0 of rswag supports Openapi 3.0.
Just change your swagger_helper from swagger: 2.0 to openapi: '3.0.1' and it will attempt to output openapi3 with no changes needed to your tests.
You will get deprecation warnings if there's anything that can be made more like openapi 3's syntax, usually done in the swagger_helper.
If anyone notices that it does not generate valid openapi3 on their existing tests please open an issue. Not we know that the common trick of adding example onto the response metadata will result in a validation warning, we will look at that for 2.4.x
Hope this helps!


Cannot update to the latest 1008 app version

Capy ...1008 (github)
Android 14
OnePlus CPH2399
Current Capy version
...1007 (IzzySoft)
Installer does nothing.

Can you add a screenshot of what you're seeing when installing the newer version?

Gotcha. This sounds like a device issue, not an app issue. Can you provide a screen recording instead?

OnePlus should have a built-in screen recorder in Quick Access via the notification drawer.
I'm guessing it's some sort of package conflict, maybe due to the source? I was able to upgrade from 1007 to 1008 on a test device without issue, but both were from GitHub.

Good! I'll keep an eye on this going forward. Please reopen if you see it again.


Can't issue cert via DNS-01 with Cloudflare

Do you want to request a feature or report a bug?
Bug
What did you do?
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    meta.helm.sh/release-name: longhorn
    meta.helm.sh/release-namespace: longhorn-system
  labels:
    app: longhorn-ingress
    app.kubernetes.io/instance: longhorn
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/name: longhorn
    app.kubernetes.io/version: v1.0.2
  name: longhorn-ingress
  namespace: longhorn-system
spec:
  rules:
  - host: longhorn.k8s.home.lex.la
    http:
      paths:
      - backend:
          serviceName: longhorn-frontend
          servicePort: 80
        pathType: ImplementationSpecific

What did you expect to see?
Valid HTTPS connection to longhorn.k8s.home.lex.la
What did you see instead?
time="2020-11-29T09:18:14Z" level=error msg="Unable to obtain ACME certificate for domains \"longhorn.k8s.home.lex.la\": unable to generate a certificate for the domains [longhorn.k8s.home.lex.la]: error: one or more domains had a problem:\n[longhorn.k8s.home.lex.la] [longhorn.k8s.home.lex.la] acme: error presenting token: cloudflare: failed to find zone k8s.home.lex.la.: Zone could not be found\n" routerName=websecure-longhorn-ingress-longhorn-system-longhorn-k8s-home-lex-la@kubernetes rule="Host(longhorn.k8s.home.lex.la)" providerName=prodssl.acme
Output of traefik version: (What version of Traefik are you using?)

2.3.3
Codename:     picodon
Go version:   go1.15.5
Built:        2020-11-19T17:43:21Z
OS/Arch:      linux/arm64

What is your environment & configuration (arguments, toml, provider, platform, ...)?
repositories:
  - name: traefik
    url: https://helm.traefik.io/traefik

releases:
  # https://artifacthub.io/packages/helm/traefik/traefik
  #
  # Check this page before upgrade
  # https://doc.traefik.io/traefik/migration/v2/
  #
  - name: traefik
    namespace: traefik-system
    chart: traefik/traefik
    version: 9.11.0
    installed: true
    values:
      - service:
          annotations:
            metallb.universe.tf/address-pool: traefik
        additionalArguments:
          # Disable internal ssl check
          - "--serversTransport.insecureSkipVerify=true"
          # SSL for testing
          - "--certificatesresolvers.stagessl.acme.caserver=https://acme-staging-v02.api.letsencrypt.org/directory"
          - "--certificatesresolvers.stagessl.acme.dnschallenge.provider=cloudflare"
          - "--certificatesresolvers.stagessl.acme.storage=/data/stage-acme.json"
          # SSL for prod
          - "--certificatesresolvers.prodssl.acme.dnschallenge.provider=cloudflare"
          - "--certificatesresolvers.prodssl.acme.storage=/data/acme.json"
          - "--entrypoints.websecure.http.tls.certresolver=prodssl"
          - "--log.level=DEBUG"
        env:
          - name: CF_DNS_API_TOKEN
            value: XXX

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
time="2020-11-29T09:18:11Z" level=debug msg="Using DNS Challenge provider: cloudflare" providerName=prodssl.acme
time="2020-11-29T09:18:11Z" level=debug msg="legolog: [INFO] [longhorn.k8s.home.lex.la] acme: Obtaining bundled SAN certificate"
time="2020-11-29T09:18:12Z" level=debug msg="legolog: [INFO] [longhorn.k8s.home.lex.la] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz-v3/8946364152"
time="2020-11-29T09:18:12Z" level=debug msg="legolog: [INFO] [longhorn.k8s.home.lex.la] acme: Could not find solver for: tls-alpn-01"
time="2020-11-29T09:18:12Z" level=debug msg="legolog: [INFO] [longhorn.k8s.home.lex.la] acme: Could not find solver for: http-01"
time="2020-11-29T09:18:12Z" level=debug msg="legolog: [INFO] [longhorn.k8s.home.lex.la] acme: use dns-01 solver"
time="2020-11-29T09:18:12Z" level=debug msg="legolog: [INFO] [longhorn.k8s.home.lex.la] acme: Preparing to solve DNS-01"
time="2020-11-29T09:18:13Z" level=debug msg="legolog: [INFO] [longhorn.k8s.home.lex.la] acme: Cleaning DNS-01 challenge"
time="2020-11-29T09:18:13Z" level=debug msg="legolog: [WARN] [longhorn.k8s.home.lex.la] acme: cleaning up failed: cloudflare: failed to find zone k8s.home.lex.la.: Zone could not be found "
time="2020-11-29T09:18:14Z" level=debug msg="legolog: [INFO] Deactivating auth: https://acme-v02.api.letsencrypt.org/acme/authz-v3/8946364152"
time="2020-11-29T09:18:14Z" level=error msg="Unable to obtain ACME certificate for domains \"longhorn.k8s.home.lex.la\": unable to generate a certificate for the domains [longhorn.k8s.home.lex.la]: error: one or more domains had a problem:\n[longhorn.k8s.home.lex.la] [longhorn.k8s.home.lex.la] acme: error presenting token: cloudflare: failed to find zone k8s.home.lex.la.: Zone could not be found\n" routerName=websecure-longhorn-ingress-longhorn-system-longhorn-k8s-home-lex-la@kubernetes rule="Host(`longhorn.k8s.home.lex.la`)" providerName=prodssl.acme

Same from lego itself (with same token):
2020/11/29 12:21:07 [INFO] [longhorn.k8s.home.lex.la] acme: Obtaining bundled SAN certificate
2020/11/29 12:21:07 [INFO] [longhorn.k8s.home.lex.la] AuthURL: https://acme-v02.api.letsencrypt.org/acme/authz-v3/8946411068
2020/11/29 12:21:07 [INFO] [longhorn.k8s.home.lex.la] acme: Could not find solver for: tls-alpn-01
2020/11/29 12:21:07 [INFO] [longhorn.k8s.home.lex.la] acme: Could not find solver for: http-01
2020/11/29 12:21:07 [INFO] [longhorn.k8s.home.lex.la] acme: use dns-01 solver
2020/11/29 12:21:07 [INFO] [longhorn.k8s.home.lex.la] acme: Preparing to solve DNS-01
2020/11/29 12:21:10 [INFO] cloudflare: new record for longhorn.k8s.home.lex.la, ID 31bca54a57651af5bf1a798af62169c1
2020/11/29 12:21:10 [INFO] [longhorn.k8s.home.lex.la] acme: Trying to solve DNS-01
2020/11/29 12:21:10 [INFO] [longhorn.k8s.home.lex.la] acme: Checking DNS record propagation using [google-public-dns-a.google.com:53 google-public-dns-b.google.com:53]
2020/11/29 12:21:12 [INFO] Wait for propagation [timeout: 2m0s, interval: 2s]
2020/11/29 12:21:18 [INFO] [longhorn.k8s.home.lex.la] The server validated our request
2020/11/29 12:21:18 [INFO] [longhorn.k8s.home.lex.la] acme: Cleaning DNS-01 challenge
2020/11/29 12:21:19 [INFO] [longhorn.k8s.home.lex.la] acme: Validations succeeded; requesting certificates
2020/11/29 12:21:20 [INFO] [longhorn.k8s.home.lex.la] Server responded with a certificate.

Related:
https://github.com/go-acme/lego/issues/1303

Welp.
          - "--certificatesresolvers.prodssl.acme.dnschallenge.resolvers=<IP_ADDRESS>:53,<IP_ADDRESS>:53"
Just fixed my problem.


menus: Tweak JS handling of clicks.

Prior to this change, if you clicked a menu to open it, then clicked to
close it, the menu heading would still have a grey background
highlighting it. That's due to a CSS rule in pure-menu that causes
focused elements to have a highlighted color. To fix: unfocus the menu
when it is closed via mouse (but leave it focused when it is closed via
keyboard).
Remove a mouseover handler that is not needed anymore.

r? @Nemo157 @GuillaumeGomez

Need to check locally to confirm it but the code looks good.

Tested it out and it works great, thanks :) It does keep the highlighting when you use space to close, but I think that's intentional because it shows the tag that's in focus.


Add Makie icon

depends on GLFW  https://github.com/JuliaGL/GLFW.jl/pull/170

awesome! those compilation times though....^^

sadly I wish it loaded faster, not sure if anything can be done about those  (does PackageCompiler help
?)

PackageCompiler will hopefully help soon!


Docker compose fix

Fixed CQL version mismatch.

Coverage decreased (-0.02%) to 78.44% when pulling 382a4785ea360edfdaa52b9d56c4dc5aaccf2304 on goru97:docker-compose-fix into e6de32ff53ed32cc348adbff8ae3692415820e1d on rackerlabs:master.

@shintasmith Take a look!

Included in #696


Make date field required

Is this possible ?

@blaindy Surely this should be handled by your app, not the plugin. What language are you using?

Hi, I have the same issue,it is because the script add readonly attribute to the field so the field didn't get validate correctly.


IEnumValue should implement ISymbolBase

Hi! Thanks for your great lib!
It looks like IEnumValue lacks ISymbolBase inheritance thus there is no way to get Declaring type info

The idea was to treat enum values as ordinal constant literals, it is how they are perceived from a programmer's perspective.
IEnum will get EnumUnderlyingType or UnderlyingType property in the next version.

Enum values are Members AFAIR
Thanks for your fast reaction!

Yes, they are implemented as a const field by the runtime, but I preferred to use language-level abstraction.

So I expected ability to get the Type that defines IEnumValue, but actually got the ability to get Enum's base type which is completely different feature

OMG, I have no idea how I messed up Declaring type with UnderlyingType , I should not write code during summer vacations :D.
Anyway, why would you need DeclaringType on IEnumValue? IEnumValue as I remember is only available in the context of IEnum.Values, thus declaring type should always be known ....


backwards-compatible handling of WEST equilibria and MEPHIT

The suggested change allows three use cases for field_divB0.f90:

The “default” use case of other versions of this file, were a standard gfile is read according to field_divB0.inp, was broken because tetra_grid_settings_mod was referenced in field.
After field_divB0.inp is read, settings can be modified; this is now done in load_tetra_grid_inp instead of field.
After field_divB0.inp is read, immediately reading the gfile can be skipped. This is necessary for MEPHIT, which modifies gfile data conditionally.

@pazathoth the change breaks tests with error message
GORILLA - Guiding-center ORbit Integration with Local Linearization Approach
At line 68 of file /Users/runner/work/GORILLA/GORILLA/SRC/field_divB0.f90 (unit = 1738, file = 'field_divB0.inp')
Fortran runtime error: End of file

 Tetrahedronal Grid: Loaded input data from tetra_grid.inp
Error termination. Backtrace:
#0  0x10b3ebaae
#1  0x10b3ec7a5
#2  0x10b3ed32b
#3  0x10b6[31](https://github.com/itpplasma/GORILLA/actions/runs/5000498171/jobs/8957976062?pr=11#step:6:32)fb3
#4  0x10b62b31d
#5  0x10b62c0fa
#6  0x10aa16ac2
#7  0x10a9efb9c
#8  0x10a9ea72a
#9  0x10aaaf3b8
Error: Process completed with exit code 2.

pls check

... and now there's some module problem with input_files

Converted to draft until we have an integrated solution with libneo.


publish<EMAIL_ADDRESS>

Requested by: @loewenheim
Quick links:

View changes
View check runs

Assign the accepted label to this issue to approve the release.
Targets

[ ] crates
[ ] github
[ ] registry

Targets marked with a checkbox have already been executed.  Administrators can manually tick a checkbox to force craft to skip it.

@loewenheim or @Swatinem please disable the failing check entirely and re-submit.


The left side of the screen in some cases is unused

During play or during analysis, and even in study, the left side of the screen holds little valuable information. Could we add a docking mechanism to it?

See https://github.com/prettierlichess/prettierlichess/issues/178, too

Implemented before v2.1.37 in Move options list


Feature request: allow website to add a descriptive text to signing requests

It is something useful to be able to tell the user why the website requires signing a payload. For example, when using Keychain to login into Steemit. If you upload an image into their post editor, this comes up:

This screen does not tell much.

I would argue against this feature.  As it could be a way to get you to sign something you do not want to sign.


generalise bitmap construction and expose heuristics

This PR generalises efficient construction of bitmaps. This introduces a few extra constructors and marker interfaces, which I expect need socialising amongst users. This breaks the interface of OrderedWriter yet again, but this is unlikely to affect any user but myself, no warnings or compiler errors are introduced anywhere else. The aim is to be able to make optimisations to bitmap build times without needing to modify source code within the library, by providing various toggles, and to make the choice between implementations simpler to switch between using generics.

OrderedWriter becomes RoaringBitmapWriter because it can accept writes in any order
Adds add(long min, long max) to RoaringBitmapWriter
Adds addMany(int.. data) to RoaringBitmapWriter
Generalises Container and MappeableContainer with the introduction of a marker interface as a generic type bound
Generalises appending to RoaringArray and MutableRoaringArray via a marker interface
Implements a "wizard" to allow construction of any mutable variety of bitmap
Introduces heuristics for bitmap construction, such as the range of values to expect, how best to initialise the RoaringArray, whether to partially sort data first, whether to expect mostly array, runs or bitmaps
Allows fast construction of FastRankRoaringBitmap - it's possible FastRankRoaringBitmap could be properly integrated into FastAggregation and ParallelAggregation by adopting this approach to constructing bitmaps.

For example, to create a large, contiguous "existence bitmap"
RoaringBitmapWriter<RoaringBitmap> writer = RoaringBitmapWriter.writer()
.expectedRange(0L, Integer.MAX_VALUE) // initialises RoaringArray accordingly
.get();
writer.add(0L, Integer.MAX_VALUE);
RoaringBitmap existence = writer.get();

To create a FastRankRoaringBitmap with constant memory during construction:
RoaringBitmapWriter<FastRankRoaringBitmap> writer = RoaringBitmapWriter.writer()
.constantMemory() // use an 8kB array to buffer writes during construction to reduce allocations
.fastRank() // indicate that fast rank and select operations are desired
.expectedDensity(0.001) // useful if this can be guessed
.get();
writer.addMany(0, 25, 250000);
FastRankRoaringBitmap bitmap = writer.get();

And to build a buffer bitmap:
RoaringBitmapWriter<MutableRoaringBitmap> writer = RoaringBitmapWriter.bufferWriter()
.optimiseForRuns() // if known, let the writer know that the best guess id RunContainer
.initialCapacity(20) // tune the size of the MutableRoaringArray
.get();
IntStream.range(0, 20 * 0xFFFF).forEach(writer::add);
MutableRoaringBitmap bitmap = writer.get();

Coverage decreased (-0.03%) to 91.655% when pulling 84daf481b80d2b362d7b8bd25e61f605bb969f7f on richardstartin:ordered-writer-array-heuristics into 5c0d441e054d2e50532aeefe2d3be634af0b18eb on RoaringBitmap:master.

The build is timing out on this:
Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/roaringbitmap/RoaringBitmap/0.7.22-SNAPSHOT/maven-metadata.xml
[WARNING] Could not transfer metadata org.roaringbitmap:RoaringBitmap:0.7.22-SNAPSHOT/maven-metadata.xml from/to apache-snapshots (https://repository.apache.org/snapshots/): Connect to repository.apache.org:443 [repository.apache.org/<IP_ADDRESS>] failed: Connection timed out (Connection timed out)
[WARNING] Failure to transfer org.roaringbitmap:RoaringBitmap:0.7.22-SNAPSHOT/maven-metadata.xml from https://repository.apache.org/snapshots/ was cached in the local repository, resolution will not be reattempted until the update interval of apache-snapshots has elapsed or updates are forced. Original error: Could not transfer metadata org.roaringbitmap:RoaringBitmap:0.7.22-SNAPSHOT/maven-metadata.xml from/to apache-snapshots (https://repository.apache.org/snapshots/): Connect to repository.apache.org:443 [repository.apache.org/<IP_ADDRESS>] failed: Connection timed out (Connection timed out)
Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/roaringbitmap/RoaringBitmapParent/0.7.22-SNAPSHOT/maven-metadata.xml
The job exceeded the maximum time limit for jobs, and has been terminated.

The build to finish first seems to time out the other.

Great work. Maybe someone wants to review this ?
(I will review.)

OK. I have just removed one of the marker interfaces to reduce the verbosity required for type bounds over the different implementations.
Since there are quite a few interesting features contributed by various users it would be good to try to tie them together into a consistent API somehow: this PR attempts to start that process by generalising construction. I am happy to make changes if necessary.

I have just asked @blacelle and @rafael-telles to review... It would be great to get wider feedback.

I've fixed an existing bug where the key wraps.

I've put it in the bitmap builders codebase I maintain. I love the API, all is clear, and suited for advanced users. I can see differences in processing time between different heuristics used. LGTM! great job!
As next step I would imagine a support for users in deciding, which heuristics to enable. Given that some of my bitmaps collections are quite similar every day I build them, I'd like to decide which heuristics to use. The simplest version could be a tool to analyse some simple statistics like
public BitmapStatistics analyse(Iterator<RoaringBitmap> bitmaps)
where BitmapStatistics contains the number of containers each type, container cardinality distribution. Given that used could make some smarter decision on which wizard features to use.
The more advanced would be
public BuilderRecommendation analyse(Iterator<RoaringBitmap> bitmaps)
where BuilderRecommendation would return more detailed recommendations like optimiseForArrays together with expectedValuesPerContainer(128).

@ppiotrow that would be quite useful. Actually, I'm interested in automated data quality checks and producing a significantly different "recommendation" day on day would be a very cheap indication that a new dataset is significantly different. Do you have ideas about how to implement it?

Looking at your code, the most powerful method seems to be expectedValuesPerContainer.
Maybe good enough recommendation is just to return average number of elements per containers?
I wonder if we could use information about number of array, bitmap and run containers, also the average number of elements per each container type to apply some expert rules. But no better ideas now.

The performance rationale for the writer abstraction in this PR, along with the benefits of doing a partial radix sort, is described here.

Are there any concerns to be addressed?

The org.roaringbitmap slowly became bag of classes - not only because of this PR. There are around 40 java files. Maybe builders can be stored in org.roaringbitmap.builders package with some of classes being package private?

I'm inclined to agree. Perhaps there could be a bit of a spring clean in another PR?

I think this might be good place&time to share. While building gigabytes of bitmaps we are getting best results by not using G1GC.
Optimising for throughput this setup has proven to be twice to infinity (as G1 can just fail) times better for our huge data.
-XX:+UseParallelGC -XX:+UseParallelOldGC -XX:MaxGCPauseMillis=10000

@ppiotrow does that relate to the features in this PR? Or just GC tuning advice?

General tip for creating Roaring Bitmaps. I assume, that the new builders code (if used smartly) should decrease number of allocations. Still I expect better results with ParallelGC than G1 using new builders code, as this is generally advised setup while optimising for throughput.
I think this might be useful to compare/mention if you publish results from your improvement.
Also quite worth is to at least consider such options in the JMH benchmarks . .shouldDoGC(true).jvmArgs("-Xmx128M", "-XX:+UseG1GC").

OK. I guess they don't call it the "throughput collector" for nothing! Maybe you could get yourself onto JDK11 and give ZGC a try? Performance wise, these features are designed for mostly ordered insertions, and for completely random insertions could only be slightly worse than repeatedly calling RoaringBitmap.add. For completely or mostly ordered insertions, the performance should be a lot better.

If you have 32 threads, 32 * 8kB = 256kB really isn't that much memory, particularly compared to what you're building or what it's being built from, or considering container transitions. I think it might be a good idea to allow resetting the writer (clearing the buffer and reinitialising the underlying bitmap) and then you would always have a lot less than 1MB for buffering.

I meant holding millions of bitmaps in memory to build them. Think of new OrderedWriter[5000000]. This allocates 40GB just for buffers.

I don't know anything about how your application works but the moment you put a single bitmap container in those 5M bitmaps you have 40GB anyway, so it feels like having 5M bitmaps, let alone building 5M bitmaps at the same time in a single process, could be part of the problem. @lemire discusses two encoding strategies for reducing the number of bitmaps required here.

Not if this is array or run container.

Sure, but 1 BitmapContainer per bitmap = 40GB, because you have 5 million bitmaps.

That is what I meant. The previous API was just classic "space–time tradeoff" example where OrderedWriter used Space (8kB per bitmap) to get better Time results. The new API is beautiful because I can "prefer bitmap" for my dense features, while "preferring arrays" for sparse features (most of features I have are sparse). Also I can help preallocating valid sizes for arrays. Good job, I can't wait to try it.

No I understand entirely, and hope I didn't give you the impression I didn't like what you were saying. I just never imagined anyone creating 5 million of these!

Ok. So this looks good to me.
We lost 0.005% in coverage and somehow coveralls thinks this warrants a red flag. Mysterious.

We can issue a new release.


Lazyload on click not respected when image inside viewport on load or window resize

This may be a question, rather than an issue.
I have set the click event as a trigger for the lazyload,
$('#' + elemId).lazyload({event: 'click'});
but that only works when the image is "bellow the fold" on page load, if the image is in the viewport when the page is loaded, lazyload is triggered and the images are loaded without click event.
I understand that the code bellow is responsible for this behavior, it checks if the image is inside the viewport on document ready. I was wandering if there should be a check if the event is different than scroll so not to trigger this behavior. This also happens on window resize.
/* Force initial check if images should appear. */
$(document).ready(function() {
    update();
});

function update() {
    var counter = 0;

    elements.each(function() {
        var $this = $(this);
        if (settings.skip_invisible && !$this.is(":visible")) {
            return;
        }
        if ($.abovethetop(this, settings) ||
            $.leftofbegin(this, settings)) {
                /* Nothing. */
        } else if (!$.belowthefold(this, settings) &&     <------- Right here
            !$.rightoffold(this, settings)) {
                $this.trigger("appear");
                /* if we found an image we'll load, reset the counter */
                counter = 0;
        } else {
            if (++counter > settings.failure_limit) {
                return false;
            }
        }
    });
}

Same problem here.
I have set a custom event as trigger, but this is ignored for images above page fold.

I modified the update function, like bellow:
function update() {
    var counter = 0;

    elements.each(function() {
        var $this = $(this);
        if (settings.skip_invisible && !$this.is(":visible")) {
            return;
        }
        if (settings.event != "scroll") {  /// Stop lazyloading when above the fold for events different then scroll
            return;
        }
        if ($.abovethetop(this, settings) ||
            $.leftofbegin(this, settings)) {
                /* Nothing. */
        } else if (!$.belowthefold(this, settings) &&
            !$.rightoffold(this, settings)) {
                $this.trigger("appear");
                /* if we found an image we'll load, reset the counter */
                counter = 0;
        } else {
            if (++counter > settings.failure_limit) {
                return false;
            }
        }
    });
}

@lucas-barros Thank you for your quick reply! That solution works perfectly.

@khinkelthein-dotsource you're welcome!

This is by design. If you only need to load images on click this plugin is quite moot. You could achieve load by click with something like:
$("#foo").one("click", function(event) {
    $(this).attr("src", $(this).attr("data-original"));
});


hardcode relation id on table with relations when loading fixtures

In my test database, I load some configuration tables from xml files with Symfony console command application.
I also load some tables with hautelook alice fixtures. My problem comes when I try in my fixture, to set a relation column (one-to-many, many-to-one, ...) from a table previously filled by my console command.
If I fill the relation column id with the id value previously generated, the relation column is always NULL and the fixture loading fails.
For instance, I have a table T1 with a primary key id column = 33. This table is loaded by console command application.
I also have a T2 table with a relation column to T1 pk id, loaded by a fixture.
The yaml fixture's excerpt is :
T2:
   data1:
    id: 1 # T2 primary key
    t2_relation_id: 33 # always set to NULL because of the tables relation

I need the relation because it eases the Doctrine DQL queries, otherwise I need to manually join the tables and this is dirty coding with an ORM. I also need relations to define foreign keys.
Is there a way to bypass relation objects to hardcode relation id directly ?
I tried to use metadata to bypass relations as I do with AUTOINCREMENT ids, but never succeed.
I also tried to set dummy relation entities but it was not working because of entity database persistence :(

Hi @dlanoire, May be you can try this, similar to T2 fixture, you must be having T1 fixture. Assuming it is like this (given below),
T1: t1_data:
id: 1 # T1 primary key (sorry for this sort of formating ;))
Now, for your T2 fixture try this,
t2_relation_id: '@t1_data33'
Hope this helps. Please revert if it doesn't.
Thank you.

Hi @tejasnavghane,
Thank you for you answer but this is not working because it tries to insert data in T1 previously loaded by a Symfony application, so I get a duplicate key error.
To summarize my problem : part of my data are loaded by a Symfony application (console command) and the remaining, by a yaml Alice fixture and they have relations to table not loaded by fixtures.
Have a nice day (night ?) :)
Regards

Hi,
You can inject those related objects while loading it: https://github.com/theofidry/AliceDataFixtures/blob/master/src/LoaderInterface.php#L25
For further support questions, please ask on the Symfony slack or other


Config options for compilation

We should provide configuration options for the LSP compiler. The supported options should match options configurable in TOML config files - https://github.com/Ackee-Blockchain/woke/blob/main/woke/config/data_model.py.

Implemented in #5


Does makisu support that It still use local cache even the push registry is provided?

Does makisu support this user case:
different makisu instance build concurrently with the same makisu-storage folder,
and the folder is mounted with PV in kubernets cluster by different build job.

Shared storage folder would not work - different makisu processes doesn't a good way to share locks, and the cleanup logic would cause trouble.


Notify users of need to upgrade fluxd

From time to time, we will want people to upgrade fluxd, either to get (critical) bug fixes, or to enable some new bit of protocol (e.g., for git sync).
Without going as far as automatically updating fluxd (see #477), we should at least notify users that their fluxd is out of date, or in any case that upgrading would be a good idea.
How do we know the daemon is out of date?
In some cases, we'll know because the daemon will be connected to an old register endpoint. (When we change the protocol, this endpoint ought to change too).
In some cases (probably because we've changed the protocol but not the endpoint), the daemon will not understand an RPC and an error will be returned.
Lastly, we can test specifically for particular versions using the RPC Version; but only as a last resort (say if there's a particular version that's horribly buggy).
How can we show a notification?
Any errors returned by the RPC client will make their way to the user as failed operations. Inserting a humane error there would cover many bases. Returning an ErrUpgradeNeeded humane error from the platform implementation used for old endpoints is a special case.
Being more pro-active, we could have a system for showing notifications in the web UI (and in fluxctl status? In fluxctl ... somehow?). This can be triggered by a daemon connection to an old endpoint, for example (and cleared by a connection to a new endpoint).

Checkpoint will log when there's a new release available. And, some of the mechanisms above are in place now:

calling deprecated APIs shows a helpful error
calling deprecated RPCs shows a helpful error
calling RPCs that the daemon doesn't support shows a helpful error

I have moved the remainder, which is really to do with the service, to https://github.com/weaveworks/service-ui/issues/1177.


Schedule command returns past events

Ignore events before current time in schedule command

Corrected in release 3.5.0


Asp.Net Core Bug

Hi, Asp.Net Core Team, I am currently using Hangfire framework in Asp.Net Core Application. I encountered a problem，https://github.com/HangfireIO/Hangfire/issues/1394#issuecomment-481644190

This was already fixed by https://github.com/aspnet/AspNetCore/commit/010139ac8a3ad9f4cebdf7013baba2c844f155f1. If you'd like the fix now, please download our nightlys here: https://github.com/dotnet/core-sdk


RFM - pulse

I DON'T Want To Become The Maintainer

[x] I have followed the Package Triage Process and I do NOT want to become maintainer of the package;
[x] There is no existing open maintainer request for this package;

Checklist

[x] Issue title starts with 'RFM - '

Existing Package Details
Package URL: https://chocolatey.org/packages/pulse
Package source URL: https://github.com/dtgm/chocolatey-packages
Date the maintainer was contacted (in YYYY-MM-DD): 2021-12-13
How the maintainer was contacted: Email

dtgm's package and software not updated for 9 years now.
So, no need to update it.