[HUDI-705]Add unit test for RollbacksCommand

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
Add unit test for RollbacksCommand
Brief change log

Add unit test for RollbacksCommand

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[x] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #1611 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1611      +/-   ##
============================================
+ Coverage     71.77%   71.80%   +0.03%
  Complexity     1087     1087
============================================
  Files           385      385
  Lines         16575    16575
  Branches       1668     1668
============================================
+ Hits          11896    11901       +5
+ Misses         3951     3945       -6
- Partials        728      729       +1

Impacted Files
Coverage Δ
Complexity Δ

...e/hudi/common/table/log/HoodieLogFormatWriter.java
77.88% <0.00%> (+0.96%)
0.00% <0.00%> (ø%)

...src/main/java/org/apache/hudi/metrics/Metrics.java
67.56% <0.00%> (+10.81%)
0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54b4b8...760726d. Read the comment docs.

@nsivabalan : Would be ok reviewing this. If not reassign to me.
THanks,
Balaji.V

@yanghua you can review this as well if possible :)

@yanghua you can review this as well if possible :)

OK

@yanghua : thanks for taking it over. Will leave it to you to review this.


timeout for databricks

this will address one of the problem in #1033 .
Default timeout is 30s, which failed on my test - a query with where clause on 30G+ dataset.
sql> select * from transactions where hash = '0xeabc0e3694a6e202c360a48b380b4205ee15541b816d66f56da687b3a3a0fd79';
Error An internal error occurred while processing the query. Show technical details with '.error'
No data returned for query

Increase it to 120s fixed the issue, result is returned successfully.
By
params:
  timeout: 120s

sql> select * from transactions where hash = '0xeabc0e3694a6e202c360a48b380b4205ee15541b816d66f56da687b3a3a0fd79';

+--------------------------------------------------------------------+-------+-------------------+--------------------------------------------+--------------------------------------------+-------+-------------+-------+-----------------------------+------------------+--------------------------+--------------+----------------+-----------------------+--------------+--------------------------------------------------------------------+-----------------+--------------------------+------------------+-----------------------------+-----------+
| hash                                                               | nonce | transaction_index | from_address                               | to_address                                 | gas   | gas_price   | input | receipt_cumulative_gas_used | receipt_gas_used | receipt_contract_address | receipt_root | receipt_status | block_timestamp       | block_number | block_hash                                                         | max_fee_per_gas | max_priority_fee_per_gas | transaction_type | receipt_effective_gas_price | end_block |
+--------------------------------------------------------------------+-------+-------------------+--------------------------------------------+--------------------------------------------+-------+-------------+-------+-----------------------------+------------------+--------------------------+--------------+----------------+-----------------------+--------------+--------------------------------------------------------------------+-----------------+--------------------------+------------------+-----------------------------+-----------+
| 0xeabc0e3694a6e202c360a48b380b4205ee15541b816d66f56da687b3a3a0fd79 | 18    | 74                | 0xdc4392cfde1d0e467a3d7602bbbc500bfe20304d | 0xdc4392cfde1d0e467a3d7602bbbc500bfe20304d | 46814 |<PHONE_NUMBER>8 | input | 3950477                     | 21000            |                          |              | 1              | +54048-12-19T15:20:00 | 14100236     | 0x000d2ed73601ebe1cadd19bec68cf2e59a44239bf8ee29e43da801d0d49fa2ed |<PHONE_NUMBER>02    |<PHONE_NUMBER>               | 2                |<PHONE_NUMBER>8                 | 14441014  |
+--------------------------------------------------------------------+-------+-------------------+--------------------------------------------+--------------------------------------------+-------+-------------+-------+-----------------------------+------------------+--------------------------+--------------+----------------+-----------------------+--------------+--------------------------------------------------------------------+-----------------+--------------------------+------------------+-----------------------------+-----------+

Query took: 1008.800289729 seconds. 1/1 rows displayed.

I went ahead and checked out this branch and ran it with the following in the dataset.yaml:
params:
  timeout: 300s

I got the following when trying to run a query with a where clause (that matches a liquid clustered column):
sql> select * from TABLE_NAME where ip = '<IP_ADDRESS>';
Error An internal error occurred while processing the query. Show technical details with '.error'
No data returned for query

sql> .error
Status { code: Internal, message: "Parquet error: Parquet error: AsyncChunkReader::get_bytes error: Generic S3 error: Error after 1 retries in<PHONE_NUMBER>25s, max_retries:10, retry_timeout:180s, source:error sending request for url (https://s3.us-east-1.amazonaws.com/BUCKET/CATALOG/__unitystorage/schemas/GUID/tables/GUID/part-GUID.c000.snappy.parquet): operation timed out", source: None }

@ablyler thanks for trying this out. I think the timeout does resolve one issue, but we are likely bumping into another issue described here https://github.com/delta-io/delta-rs/issues/2301.
I will get this partial fix merged. Meanwhile, will investigate the new symptom.


Icons Vol15

Epic for Icons Volume 15
Icons to be added for next icon release:
@Stela-Stamenkova , please refer to issue #3296 for examples and details for #1-7. These icons should be consistent in style, size & weight with the text-editing icon set currently in the Clarity library.

Strikethrough
Subscript
Superscript
Foreground color
Highlight color
Indent (Increase Indention)
Outdent (Decrease Indention)
Storage adapter (FC HBA) Reference #3237
Label for BETA (similar to the "new" label icon in Clarity) - request from @reddolan

Hello everyone!
Icons_Vol15.zip
I am attaching the icons, let me know how they work.
Best,
Stela

Do we anticipate these making it into the 2.0 release?

@reddolan
2.0 is in release candidacy. I think it's more likely these make it into 2.1. @gnomeontherun could add more info on that.

@mathisscott thank you. I will plan to get these icons ready for the 2.0 resource work that aligns with #3258

Hello,
I am adding them again per comment by Lilia.
Let me know how they work now.
icons_Vol-15.zip

Looks good, @Stela-Stamenkova. Thank you!

Do we happen to know which categories each will reside in?

I am assuming

Text Editing: Strikethrough, Subscript, Superscript, Foreground color, Highlight color, Indent, Outdent
Technology: Storage adapter
Essential: Beta

@reddolan Agreed!

I see beta-line, but am not seeing beta-solid. Was this intentional? new has line and solid

Good catch @reddolan. @Stela-Stamenkova would you please add a solid version of "Beta"? Thank you!

I am also seeing something weird with the beta one where the TA are not showing in the SVG when importing it into Sketch or Figma. Is there something different with the TA?

Also, the names of Indent and Outdent are reversed

Hello again!
Red, I am sorry, here they are again, with solid version and bug fixed.
Vol15.zip

Hi @Stela-Stamenkova
The solid beta icon is a filled polygon with white text. That's not going to to work. What we need is a solid polygon with the text cut out. In Illustrator terms this would be a "subtract" merging of these paths, I believe. When you get that taken care of could you post the new solid beta icon here?
Thanks!

Once I get an updated beta-solid icon, I can move this into review.

@mathisscott,
Here's the corrected beta icon:
beta_solid.svg.zip

Regarding the new icon added here "Storage adapter (FC HBA) Reference #3237".
Even after updating the icons to version 2.0.2 , I do not see the svg file for storage-adapter in the technology-shapes.zip. Is this not available yet?
The clarity website icons section is displaying the icon though.

@abbyhtml
The vol. 15 icons were merged into master last week. The website auto-updated and published the icons documentation. So while they are on the website, the icons have not been released yet. They will be available in 2.0.3. I would expect that release to happen next week.


Support less fancy terminals

The new bankai has pretty fancy terminal logging! But not everyone runs it in a terminal that supports all these fancy features. For example, term-mode in Emacs really dislikes the fact that bankai takes over the terminal. Also, if you're using bankai on the server side, it can get in the way of your server logging. While I think we should keep these features, I think there should be a configuration option for basic logging (like the old bankai logging) that works on simpler terminals.
We could by default make the decision to use basic or fancy logging based on the TERM environment variable.

Ya, agree - we should do a TTY check and then just output a log stream.
On Sat, Sep 30, 2017 at 3:27 AM Christian Howe<EMAIL_ADDRESS>wrote:

The new bankai has pretty fancy terminal logging! But not everyone runs it
in a terminal that supports all these fancy features. For example,
term-mode in Emacs really dislikes the fact that bankai takes over the
terminal. Also, if you're using bankai on the server side, it can get in
the way of your server logging. While I think we should keep these
features, I think there should be a configuration option for basic logging
(like the old bankai logging) that works on simpler terminals.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/choojs/bankai/issues/251, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWlemAaW_ClNiEwETksj_9aiPFE8rGBks5sne1WgaJpZM4PpeXi
.

For now if it doesn't work, you can always pass --silent; it'll only warn on error.

I believe its --quiet :)
bankai --help
  $ bankai <command> [entry] [options]

  Commands:

    build       compile all files to dist/
    inspect     inspect the bundle dependencies
    start       start a development server

  Options:

    -d, --debug       output lots of logs
    -h, --help        print usage
    -q, --quiet       don't output any logs
    -v, --version     print version

Well, I have something kinda working that might help this... I hacked together a version of ui.js that will log to stdout instead.

This allows bankai to be used programmatically without it blowing away existing sever logs :) It would be nice to detect tty but also enable this under a flag... but I'm not certain.
@yoshuawuyts any other thoughts on this?

pushed WIP code to branch if you're interested in seeing it (not merge ready hehe) https://github.com/choojs/bankai/compare/simple-logs

@Flet this is cool!


Save scores to stats file

Would be a nice feature if users scores were saved to the stats file and sorted by tribe and or channel.

Score saving would likely take on a different form than the stats.json file for readability. Closing as stale for now.


Static analysis integration

The static analysis APIs are now better integrated with the P# compiler.
Its now easy to write custom passes after the rewriting process to check the user P# code and give appropriate errors/warnings (see (https://github.com/p-org/PSharp/blob/master/Libraries/StaticAnalysis/Analyses/NoGenericStatesAnalysisPass.cs for example). This can potentially allow us to have more compile-time checks versus runtime-checks (introduced a new pass today for ensuring states cannot be declared generic, only machines).
If there is an analysis error, then the compiler exits with appropriate bug reports (previously it would just spit out an executable). The data race analysis is disabled by default (enable by /check-races), the data-flow analysis is also disabled by default (enable by /dfa, or /check-races which runs dfa as a pre-pass), since these two are considered more experimental features. The analysis APIs are designed to be scalable and fast (milliseconds) so have insignificant compilation overhead.


Add documentation for with_columns_renamed()

Proposed changes
Add documentation for with_columns_renamed() helper function.
Types of changes
What types of changes does your code introduce to quinn?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation Update (if none of the other choices apply)

Further comments
Fixes #137

@SemyonSinchenko @MrPowers Did you get a chance to review this PR?


auto complete suggestion does not work inside paper dialog

When the auto complete suggestion wrapper has a scrollbar and we try to scroll it, a blur event is triggered and the suggestion list closes immediately.

This has been fixed in v2.1.3


Argument placeholder not replaced

The __ARG__ placeholder is not replacing when using version 1.3.3 of the plugin.
For instance:
plugins {
    id("com.github.johnrengelman.shadow") version "6.1.0"
    id("io.micronaut.application") version "1.3.3"
}

version = "0.1"
group = "hello"

repositories {
    mavenCentral()
    jcenter()
}

micronaut {
    runtime("netty")
    testRuntime("junit5")
    processing {
        incremental(true)
        annotations("hello.world.*")
    }
}

dependencies {
    implementation("io.micronaut:micronaut-validation")
    implementation("io.micronaut:micronaut-runtime")
    implementation("io.micronaut:micronaut-http-client")
    runtimeOnly("ch.qos.logback:logback-classic")
}

application {
    mainClass.set("hello.world.Application")
}

java {
    sourceCompatibility = JavaVersion.toVersion("1.8")
    targetCompatibility = JavaVersion.toVersion("1.8")
}

running the command:
./gradlew dockerBuild

yields a Dockerfile like:
FROM openjdk:15-alpine
WORKDIR /home/app
COPY build/layers/libs /home/app/libs
COPY build/layers/resources /home/app/resources
COPY build/layers/application.jar /home/app/application.jar
EXPOSE 8080
ENTRYPOINT ["java", "__ARGS__", "-jar", "/home/app/application.jar"]

Additional Notes

The __ARGS__ argument is not replaced on the ENTRYPOINT instruction.
If args are specified through the task, the placeholder is still remains.
The placeholder does not remain when using version 1.3.2.

There is a PR open to fix this issue.

Fixed in #127.
@ihcnet you can manually downgrade the plugin version until we release a new one with the fix.

@ihcnet I've published 1.3.4 version with the fix.


feat: improve compatibility for CLI args

What this PR does / why we need it:
提高 lb-controller 命令行参数的兼容性
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @hanxueluo @hicaistar

Release note:

NONE

/lgtm


[FAQ]How to customize the axis label display spacing?

A line chart like (https://visactor.io/vchart/demo/line-chart/basic-line),

How to realize the display spacing of custom axis labels?

Solution
The solution varies depending on the chart library being used. Based on the provided demo, you simply need to set the corresponding field to false in order to disable stacking.

MinGap can be used to customize the minimum spacing between labels (unit: pixels). Only takes effect when axis sampling starts (sampling: true). This configuration affects the results of axis sampling.

Code Example
const spec = {
  type: 'line',
  data: {
    values: [
      {
        time: '2:00',
        value: 8
      },
      {
        time: '4:00',
        value: 9
      },
      {
        time: '6:00',
        value: 11
      },
      {
        time: '8:00',
        value: 14
      },
      {
        time: '10:00',
        value: 16
      },
      {
        time: '12:00',
        value: 17
      },
      {
        time: '14:00',
        value: 17
      },
      {
        time: '16:00',
        value: 16
      },
      {
        time: '18:00',
        value: 15
      }
    ]
  },
  xField: 'time',
  yField: 'value',
  axes: [{
      orient: "bottom",
      label: {
          minGap: 80
      }
  }]
};

Results
Online demo：https://codesandbox.io/s/customize-axis-label-spacing-9ml6nv

Related Documentation
Basic Line Chart Demo：https://www.visactor.io/vchart/demo/line-chart/basic-line
Line Chart Tutorial：https://www.visactor.io/vchart/guide/tutorial_docs/Chart_Types/Line
Related api：https://www.visactor.io/vchart/option/lineChart#axes-band.label.minGap
github：https://github.com/VisActor/VChart


Align webauthn-swift more closely with Authentication Services Framework

The existing entry points for webauthn-swift do not readily accept the data provided by Apple Authentication Services Framework.  Here two new entry points are proposed.
A Swift server may handle standard web traffic, but it will also quite likely support native clients also written in Swift.  Let's look at the details on the latter scenario.  The registration flow sees the ASAuthorizationControllerDelegate performing registration after an ASAuthorizationPublicKeyCredentialRegistration is generated by the Authentication Services Framework.  This object contains a rawAttestationObject:Data? and rawClientDataJSON:Data.  In the Swift⇄Swift architecture, these two data objects would be passed by the client to the server for validation in webauthn-swift.  The server might simply invoke a function like this:
public static func validateAuthenticatorAttestationResponse(_ rawAttestation: Data, clientDataJSON:Data, challengeProvided: Data, origin: String, logger: Logger) throws -> CredentialData {
A similar entry point should be added to handle the authentication flow.
Under the covers, the proposed entry points and the existing ones share considerable code.  We are currently using a fork of webauthn-swift with these additions which can be contributed.
P.S. I am very thankful for @0xTim and @marius-se for their work on this library.  This has saved considerable time and effort and I know that webauthn-swift will become part of many projects in the months ahead.  But...  There is an existential question that I cannot resolve in my mind.  If Apple is serious about passkeys/webauthn and is serious about growing the Swift on Server community, then surely this functionality should be included in the Apple Authentication Services Framework to better support the Swift⇄Swift architecture.

Apple Authentication Services is only available on Apple Platforms - it's unable to be used on Linux (and Windows) so frankly is not a concern of this library. We could try and maintain some kind of compatibility layer but a) Apple platform APIs evolve much slower than an open source library and b) we'll be constraining ourselves to whatever paradigms the Authentication framework is built upon. They have very different use cases, one's a client library and one's a server library so they are likely to be significantly different.
As an aside - the focus of the package to provide a server implementation for WebAuthn no matter the type of client. Swift is bigger than whatever is happening on Apple platforms.


[WFCORE-2635] Upgrade WildFly Elytron to 1.1.0.Beta35 and Backport Latest Changes

:warning: Commits from this branch are used in numerous other topic branches so please do not cherry-pick or rebase. :warning:
This PR resolves the following issues: -
https://issues.jboss.org/browse/WFCORE-2553
https://issues.jboss.org/browse/WFCORE-2574
https://issues.jboss.org/browse/WFCORE-2517
https://issues.jboss.org/browse/WFCORE-2371
https://issues.jboss.org/browse/WFCORE-2556
https://issues.jboss.org/browse/WFCORE-2482
https://issues.jboss.org/browse/WFCORE-2614
https://issues.jboss.org/browse/WFCORE-2625
https://issues.jboss.org/browse/WFCORE-2474
https://issues.jboss.org/browse/WFCORE-2581
https://issues.jboss.org/browse/WFCORE-2635
https://issues.jboss.org/browse/WFCORE-2636

Core - Full Integration Build 4677 outcome was FAILURE using a merge of c66be917d3e68b5fa7d2be7b104887066a6387b3
Summary: Tests passed: 226, ignored: 11; compilation error: Compiler (new) Build time: 00:02:34

Full integration - Windows Build 3103 outcome was FAILURE using a merge of c66be917d3e68b5fa7d2be7b104887066a6387b3
Summary: Tests passed: 226, ignored: 11; compilation error: Compiler (new) Build time: 00:04:51

Experimental Build Parameters: -

WildFly Core *

Repository - https://github.com/wildfly-security-incubator/wildfly-core.git
Branch - WFCORE-2635

WildFly *

Repository - https://github.com/wildfly-security-incubator/wildfly.git
Branch - WFLY-8527

Experimental Builds: -
https://ci.wildfly.org/viewLog.html?buildId=54056&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperiments
https://ci.wildfly.org/viewLog.html?buildId=54060&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperimentsWindows

Replacement Windows Build
https://ci.wildfly.org/viewLog.html?buildId=54063&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperimentsWindows

retest this please

Core - Full Integration Build 4678 outcome was FAILURE using a merge of c66be917d3e68b5fa7d2be7b104887066a6387b3
Summary: Tests passed: 226, ignored: 11; compilation error: Compiler Build time: 00:02:36

Full integration - Windows Build 3104 outcome was FAILURE using a merge of c66be917d3e68b5fa7d2be7b104887066a6387b3
Summary: Tests passed: 226, ignored: 11; compilation error: Compiler Build time: 00:04:14

I increased the timeout on the windows experiments job rerun at https://ci.wildfly.org/viewLog.html?buildId=54135&tab=buildResultsDiv&buildTypeId=WF_WildFlyCoreIntegrationExperimentsWindows


Remove a click in the Extractor UI flow -- automatically advance user to Entity Selection

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1057
Originally created by @dmor on 2019-09-26 17:31:07

Current workflow:

Select extractor to run
Wait for the extractor to complete
When complete, select green button to move onto entity selection

Suggested workflow:

Select extractor to run
Automatically advance user to the entity selection step

Reason: There is no other path the user can take, so there is no need to make them think about a decision to move forward. This is an unnecessary click/friction.
It is true they might want to add other extractors, but it would not make sense to do that and then do entity selection (lose context)

View 3 previous comments from the original issue on GitLab


Extension 'Theme Tester' is not installed

Testing #153318

Open https://insiders.vscode.dev/theme/vscode.theme-red
Use command Theme Tester: Preview Theme
Enter with default option

vscode.dev changes to the default theme azemoh.one-monokai successfully
Reload the vscode.dev tab
:bug: Get notification Extension 'Theme Tester' is not installed

I got it a few times when I tested last week, but it looks like I can no longer repro, so I'll close this out.


Add several multi-subject inverse models via Mutar

This PR generalizes the current GroupLasso solver to include all multi-task models of Mutar https://hichamjanati.github.io/mutar/.

shall I review @hichamjanati ?

Yes please :)
On Tue, Dec 24, 2019, 4:43 AM Alexandre Gramfort<EMAIL_ADDRESS>wrote:

shall I review @hichamjanati https://github.com/hichamjanati ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/hichamjanati/groupmne/pull/17?email_source=notifications&email_token=AECC63HEHCYNM7YHX7YYF63Q2H7T7A5CNFSM4J63BY6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHTE26A#issuecomment-568741240,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AECC63DEQFXEBGN6PHGZVYTQ2H7T7ANCNFSM4J63BY6A
.

for MNE users this API will still be too low level. compute_group_inverse should take as input a list of forward objects and a list of evoked object.

The compute_inv_data step that returns np arrays can be be private indeed so that the user only works with MNE objects.

fwds <- compute_fwds
stcs <- compute_group_inverse(fwds, evokeds, ...)

To hide the transition to numpy arrays and also avoid recomputing the aligned and filtered leadfields + permutations I created an InverseOperator class. Wdyt about this api @agramfort ?

can you work with fwds assuming the fwds have been modified by
prepare_forwards so no further check is needed?
basically prepare_fowards will make you have new fwds that are compatible
out of the box.

I'm not sure whether I can modify instances of fwds by removing some vertices and reordering them. The souvenir I have from last year's adventures (https://github.com/mne-tools/mne-python/issues/5349) is that it requires hacking all mne objects (SourceSpaces, Forward.. ) to have vertices in a -not sorted- order.

you will have a problem when you save the forward to disk.

True I forgot MNE objects are just dictionaries. Ok so we can add the gains / permutations as new attributes to fwd instances. Maybe we can avoid overwriting stuff in fwds so as not to have problems if the user calls single subject mne solvers on a modified fwd ?

sure that would be a good idea.

Please make it a test

ok. Shall we merge this one as is or do it in this PR?

I vote for merging this one once it's green to keep PRs independent + we need to discuss the preprocessing in mne before doing anything

ok green !


format with ruff

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.24%. Comparing base (8af53fb) to head (5f107d4).
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation:  There is a different number of reports uploaded between BASE (8af53fb) and HEAD (5f107d4). Click for more details.
HEAD has 3 uploads less than BASE

Flag
BASE (8af53fb)
HEAD (5f107d4)

4
1

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   77.97%   68.24%   -9.73%
==========================================
  Files          35       35
  Lines        2574     2573       -1
==========================================
- Hits         2007     1756     -251
- Misses        567      817     +250

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feature suggestion: contextual tags

Hi,
Firstly: thanks for the great library. I have been thinking it would be useful to add support for contextual (maybe "scoped" is a better term) tags. Right now our options for adding tags are either:

Globally at MetricsBuilder configuration time
Locally at the call-site of a metrics invocation, i.e. as a parameter to Increment() etc.

There are times where it would be useful to have something in the middle. A recent example is #300 wherein they wanted the ability to add "user id" or "device" tags. It would be handy if we could do that at an earlier stage (e.g. middleware in a web app) and all subsequent metrics calls inherit those tags. Example code:
public class UserIdTagsEnrichmentMiddleware
{
	private readonly RequestDelegate _next;
	private readonly IMetrics _metrics;

	public UserIdTagsEnrichmentMiddleware(RequestDelegate next, IMetrics metrics)
	{
		_next = next;
		_metrics = metrics;
	}

	public Task Invoke(HttpContext context)
	{
		var tags = new MetricTags(new[] {"user_id", "user_type"}, new[] {"1234", "paid"});
		using (_metrics.PushTags(tags))
		{
			await _next(context);
		}
	}
}

In terms of implementation, we could use AsyncLocal<T> in .Net Standard and CallContext in .Net 4.5.2 to maintain a stack of contextual tags. This is how Serilog's LogContext does it.
What do you think? If you think the idea is worthwhile, I'd be very happy to submit a PR for you to review and make changes as you see fit.

Hi @aidansteele,
Happy you find it useful.
Happy for this as a new feature and more than happy for a PR 😉
Example code looks good to me.

Thanks for the speedy response @alhardy! I'll try to get an initial version of this submitted quite soon 👍

Sorry for the delayed response. I started working on this today and came up with a few questions that I'd like to clarify before continuing with the PR.
What's the purpose of context labels? Specifically, how are they distinct from tags?
Why does MetricTags have arrays of strings for keys and values, instead of perhaps a Dictionary<string, string>? https://github.com/AppMetrics/AppMetrics/blob/9adf17a6fa99052f3379af73d416efe33508f639/src/App.Metrics.Abstractions/MetricTags.cs#L15-L18
The JSON formatter calls MetricTags.ToDictionary(), which has the following line: https://github.com/AppMetrics/AppMetrics/blob/9adf17a6fa99052f3379af73d416efe33508f639/src/App.Metrics.Abstractions/MetricTagExtensions.cs#L44
This will return an ArgumentException if the key already exists, e.g. if there are already global or scoped tags with the same key. Would this still be the desired behaviour, or would we want to prefer most specific tags over the least specific?
Sorry for all the questions, but I figure I should first understand the rationale for the current implementation before making any changes.

Was any progress made on this? This feature would be a godsend for me right now :)

This looks dead, so I've started working on it myself.
I've written the core of it, the part that can push new tags and remove them when exiting the scope.
I'm wondering how to expose it in IMetrics - Just a plain method like shown in the OP, or perhaps as a method under one of the existing services? IManageMetrics looks roughly right but I don't really understand the responsibilities of each service.
Any thoughts on this @alhardy ?

Any news for this feature?

The original middleware prototype example from aidansteele shows access to HttpContext. But there does not seem to be any good way to gain access to HttpContext with the current solution (Contextual tags #552).
For example, this is not ideal:
services.AddMetrics(metricsBuilder =>
{
    metricsBuilder.Configuration.Configure(options =>
    {
        options.AddServerTag();
        options.ContextualTags.Add("someTag", () =>
        {
            var sp = services.BuildServiceProvider(); //<-- not ideal; but how to get HttpContext??
            var httpContextAccessor = sp.GetRequiredService<IHttpContextAccessor>();
            return "something from http context";
        });
    });
});

Am I missing something? Or is this an oversight?


Massive amounts of generated blocks

Sometimes, even with moderately sized data, we end up with hundreds of millions of blocks being generated. Here are some learned predicates from the Georgia Contributions data that we have been using recently that generated nearly 500,000,000 blocks (from a dataset of about 1,200,000 records with about 480,000 records actually being blocked)
CompoundPredicate
    TfidfTextPredicate: (0.6, cont_name)
    TfidfNGramPredicate: (0.8, address)

CompoundPredicate
    SimplePredicate: (tokenFieldPredicate, cont_name)
    SimplePredicate: (firstIntegerPredicate, address)

CompoundPredicate
    SimplePredicate: (commonThreeTokens, cont_name)
    SimplePredicate: (sortedAcronym, cont_name)

CompoundPredicate
    TfidfTextPredicate: (0.8, address)
    SimplePredicate: (sameSevenCharStartPredicate, cont_name)

CompoundPredicate
    TfidfNGramPredicate: (0.6, zip)
    SimplePredicate: (sameSevenCharStartPredicate, cont_name)

CompoundPredicate
    TfidfTextPredicate: (0.4, address)
    TfidfTextPredicate: (0.8, cont_name)

Closed by 11ab80d8da2e3369a0767ed2c15bda9e7ffb4d27


Table 10 2016 values

dashes in FI and exploitation rate

Aren't you talking right now. Impressive.

Done.


pep-8

Cool library but please implement stuff respecting pep-8. Methods named like characterAt()makes every Python developer sick.

Refactored with PEP8 Styling in this PR: https://github.com/btwael/superstring.py/pull/7 but since I branched off from the testing branch (https://github.com/btwael/superstring.py/pull/6) that will need to be merged before I re-open the styling PR.


Reading only some lines

Hello.
How can tell feather to read only lines from 10000 to 20000?
In case of very long files this could be very important to save time and memory.
And how to read 100 random lines?
Regards

Closing in favor of https://issues.apache.org/jira/browse/ARROW-8391


Removed annoying warnings and updated project for Xcode 7

Title says everything ;)
Also it fixes #17

Apologies for that. Fixed by 38c90c8eeb56878a332875607447721f88fc453b and 87ed94538b67cfad1a99de60741a2e3e5664bab3.


allow ref to be set on textfields

Should fix #514

Oops, yea. Fixed

+1

@robstrong Would you like to resubmit this PR to resolve the conflicts?

Updated PR

Sorry about that, updated

Thanks @robstrong

Not fixed in 1.0


Added Japanese translations

I have added Japanese translations.
Thanks,

Excellent. Merged! Thank you @onkbear  for taking the time to put this PR together. I'm sure it'll help other too.
Cheers!


How to triger the MSTestV2 programatically?

I am using specflow with MsTestV1. I am using orderedTest to run. Since V2 does not support orderedTests, is there any way to Triger the tests programmatically in V2. I checked the unit tests, I dint get it
I am trying like this
https://social.msdn.microsoft.com/Forums/vstudio/en-US/ccd08ce1-a86b-4965-af68-1db8cd7d6715/how-to-execute-test-methods-programmatically-using-c-may-be-using-reflection?forum=vsunittest
For V2 I refered this. but not getting it
https://github.com/microsoft/testfx/blob/master/test/UnitTests/MSTest.CoreAdapter.Unit.Tests/MSTestExecutorTests.cs
I dont want to run using command line..the test name will be in a list,I have to invoke them.

Have you tried the vstest console wrapper? Or is that something you want to avoid as well? https://github.com/nohwnd/vstest-examples/blob/main/PartioningTests/Program.cs#L73 in mstestv2 tests are ordered based on method names btw.

i tried like this but its not discovering https://github.com/saiparth/consoleRunner
through console its working using dotnet test command

@nohwnd
Thank you. I was able to fix and run like shown in example. please suggest for below scenario.
I have a framework which is build in C# (Version=v4.6.1)
this uses specflow and mstest V1. It uses orderedtest for grouping test. already hundreds of tests are there so I cant avoid ordertests. problem is mstest V2 will not support orderedtests. so I am thinking to use like vstest.console.exe sample.orderedtest /logger:trx to run. is this running ordertests supported in future or is there any other option to keep the tests in external file and use that. filtering will not work . I have checked. Please suggest.

@saiparth Support for ordered tests in the future seems to be unlikely (see https://github.com/microsoft/testfx/issues/25#issuecomment-790955113). We fixed our (few) tests which really require ordering by merging them into a single test method which executes them sequentially.

@N-Olbert
My problem is that I am using specflow which behind the screen generates the testmethods. and same test case can be present in Smoke test, regression multiple suites. so tags/ alphabetical order will not work. only way is I have to put tests in external file and invoke them programmatically. using Nunit its possible to do like this.
ITestEngine engine = TestEngineActivator.CreateInstance();
TestPackage package = new TestPackage("TestProjectdllPath");
ITestRunner runner = engine.GetRunner(package);
TestFilterBuilder fil = new TestFilterBuilder();
fil.AddTest("NameSpace.TestName");
TestFilter filter = fil.GetFilter();
XmlNode result = runner.Run(new MyEventListener(), filter);
runner.Dispose();

since my framework was using Mstest V1, I thought of continuing MstestV2

@saiparth Is it something you are still interested in having?

Yes, Is there solution?

Not sure, I need to look into it. I just wanted to confirm there was a need for it.
Could you confirm the kind of usage you would like to achieve? Because depending on them, there might be a need to use Test Platform (or not).

I am looking for support of orderedtest in MSTEST V2. There was an option in V1 which displayed all unit test in project and we could generate a xml file by picking specific testcase. Good thing was execution order was same as test names in external file even though it was the list was not alphabetical order.
Using some tools we can run the test from external files. But it wont execute in the order that we mention. Its not possible to mention the execution order for the test using attributes due to various reasons. The tests would execute randomly. Some of the test wont support parallel execution and we need sequential execution. Also the test list may not be in alphabetical order

I will make tests but I fear that to run in order you would need to call MSTest n times with 1 test per call.

@Evangelink Since you were interested in this issue and seem make a roadmap for MSTest v3 and v4.... are there any plans to fix the main reason for this request and provide a way to specify the execution order of the tests (by an attribute, a custom IComparer-instance that has to be registered somewhere or whatever). Even if the corresponding issue #25 has already been closed, I think this is an important feature for integration and acceptance testing. In fact this lack of functionality is the main reason i would struggle to use MSTest in a new project.

Hey @N-Olbert. Yes, I'd like to work on a feature to give users the ability to have better control on the order of their tests but I haven't yet given enough thoughts to suggest something now. For sure, it won't be part of v3, I will see if it could fit v4.

I had a quick look and sadly with current architecture, there is no way for you to control the order. As I said previously, you would need to make a lot of calls with 1 assembly and a filter to match only 1 test of that assembly.
As for the programmatically doing the calls, you can:

Make multiple calls to vstest.console.exe or dotnet test with 1 source and a filter for each test. See https://learn.microsoft.com/visualstudio/test/vstest-console-options and https://learn.microsoft.com/dotnet/core/tools/dotnet-test.

Reference Microsoft.TestPlatform.TranslationLayer NuGet package and call the available APIs. You can use our E2E tests as example (see https://github.com/microsoft/testfx/blob/main/test/E2ETests/Automation.CLI/CLITestBase.e2e.cs#L51).

Call directly MSTestExecutor class from the test adapter dll. This last option might be easiest but you will lose all the extra features (blame, trx, logs...) provided by the test platform.

Hey there, as you may have noticed we are about to start shipping MSTest runner and this runner will greatly facilitate most of the requests open in this issue.
Please look at the code and let us know what you think.


Add helper function for ensuring a function is run in the gui thread

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description

Looks good to me, you are okay to add some unrelated changes to the PR :-)


Set html[lang] during navigation

Closes #967
Change the <html> element's [lang] attribute during navigation. Currently, this isn't possible from applications (without a lot of trouble), since the turbo:before-render event is scoped to the newBody.
In order to support this behavior, change the PageSnapshot constructor to accept an instance of HTMLHtmlElement (the <html> element) so that that element can be accessible from the PageRenderer.

@afcapel thank you for merging this! I wonder if it's worth merging other (or all?) attributes as well.


🐛 When adding device with Admin user, entities never work and create JSON error in logs

What version of Integration has the issue?
2.5.7
System Health details
System Information

version
core-2023.1.4

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.10.7

os_name
Linux

os_version
5.15.76-v8

arch
aarch64

timezone
Europe/London

config_dir
/config

Home Assistant Community Store

GitHub API
ok

GitHub Content
ok

GitHub Web
ok

GitHub API Calls Remaining
4993

Installed Version
1.29.1

Stage
running

Available Repositories
1203

Downloaded Repositories
10

Home Assistant Cloud

logged_in
false

can_reach_cert_server
ok

can_reach_cloud_auth
ok

can_reach_cloud
ok

Home Assistant Supervisor

host_os
Home Assistant OS 9.4

update_channel
stable

supervisor_version
supervisor-2022.12.1

agent_version
1.4.1

docker_version
20.10.19

disk_total
28.5 GB

disk_used
6.6 GB

healthy
true

supported
true

board
rpi4-64

supervisor_api
ok

version_api
ok

installed_addons
CEC Scanner (3.0), File editor (5.4.2), Check Home Assistant configuration (3.11.0), Terminal & SSH (9.6.1), AirCast (3.5.1)

Dashboards

dashboards
1

resources
0

mode
auto-gen

Recorder

oldest_recorder_run
4 January 2023 at 15:26

current_recorder_run
13 January 2023 at 10:10

estimated_db_size
85.79 MiB

database_engine
sqlite

database_version
3.38.5

Solcast PV Forecast

can_reach_server
ok

remaining_requests
9

rooftop_site_count
1

polling_hours
6 -> 17 and once at midnight

Sonoff

version
3.3.1 (b20e33c)

cloud_online
2 / 2

local_online
0 / 0

Spotify

api_endpoint_reachable
ok

Checklist

[X] I have enabled debug logging for my installation.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).

Describe the issue
I added the integration through HACS and entered admin details for the integration.
The integration finds the watch, but the entities never update. The log shows:
Error requesting xplora_watch- data: 0, message='Attempt to decode JSON with unexpected mimetype: text/html', url=URL('https://api.myxplora.com/api')
Reproduction steps

Install integration
Connect with Admin User
Entities dont get values and error message in logs

Debug logs
have enabled debug logs as per intruction but cannot see any output in normal logs - please tell me if they should seomwhere else

Hi unfortunately this is a problem of Xplora. I can't handle the exception because the service goes down mostly at night.

@Ludy87 anything else I can do here to help?
Not sure about your comment about the API going down at night, i have tried several time to start or restart the connection but it never gets data and always presents the same error message

please wait until the new update is released.

After update: No error message in logs but still doesnt update entities - how can I debug this?

Not fixed in 2.7.0
To be clear, password is accepted, the name of the watch loads correctly so I can be sure that login works.
However, the entities never get a real value:

I have tested logging in with phone number or email, as well as leaving timezone options as default or changing to my region (London).
It is the same in all cases.

@FattusMannus Hi, you are using an account without admin rights.

@Ludy87 this is the admin account.

Is there a debug output?

Debug logging is enabled
There's nothing in the "home assistant core" logs.
If I need to look somewhere else, please tell me.
Thanks
Andrew

search for "xplora"
click "load full log"
post the content here, please DO NOT remove your private content, but anonymize it with fake data.
Please no image but as text, if necessary you can also attach the log file here, note point 3!

If no data is available, the debugging mode is not active

Screenshot shows the option to "disable debug logging" so I assume it's enabled - plus a copy of my log.
If I need to look somewhere else, please tell me where

this is not the right mode, you have to enter this in the configuration.ymal: https://github.com/Ludy87/xplora_watch#debug

hello, I can add the integration but no entities  are created
2023-11-21 21:42:49.664 DEBUG (MainThread) [custom_components.xplora_watch.switch] {'__typename': 'Child', 'id': '10fb383d0889d11eebe5d9b070c2251a7', 'guardian': {'__typename': 'User', 'id': None, 'userId': None, 'name': None, 'nickname': None, 'gender': None, 'birth': None, 'birthStr': None, 'weight': None, 'height': None, 'firstName': None, 'lastName': None, 'countryCode': None, 'city': None, 'address1': None, 'address2': None, 'zipCode': None, 'emailAddress': None, 'countryPhoneCode': None, 'phoneNumber': None, 'mobilePhoneNumber': None, 'faxNumber': None, 'emailConfirm': None, 'description': None, 'status': None, 'file': None, 'lastLoginDate': None, 'changePasswordDate': None, 'loginFailCount': None, 'extra': None, 'xcoin': None, 'currentStep': None, 'totalStep': None, 'create': None, 'update': None, 'roles': None, 'children': None, 'contacts': None}, 'ward': {'__typename': 'User', 'id': '0111003b103a5f5f775f5f7369671633', 'userId': '__w__sikey_194c358d0889c11ee8fd0074e4b1b6a16', 'name': 'Alice', 'nickname': 'Alice', 'gender': 'UNKNOWN', 'birth': 0, 'birthStr': '', 'weight': '', 'height': '', 'firstName': '', 'lastName': '', 'countryCode': 'it', 'city': '', 'address1': '', 'address2': '', 'zipCode': '', 'emailAddress': '', 'countryPhoneCode': '+39', 'phoneNumber': 'xxxxx', 'mobilePhoneNumber': 'xxxxx', 'faxNumber': '', 'emailConfirm': 'NO', 'description': '', 'status': 'ENABLE', 'file': {'__typename': 'File', 'id': '1a9a981e0889f11ee8e9d192d0dbd70fd', 'name': 'file.jpg', 'origName': 'file.jpg', 'contentType': 'image/jpeg', 'description': '', 'ipaddress': '', 'extra': {}, 'create':<PHONE_NUMBER>, 'update':<PHONE_NUMBER>}, 'lastLoginDate': 0, 'changePasswordDate':<PHONE_NUMBER>, 'loginFailCount': 0, 'extra': {'lang': 'it', 'timeZone': 'Europe/Rome'}, 'xcoin': 0, 'currentStep': 0, 'totalStep': 0, 'create':<PHONE_NUMBER>, 'update':<PHONE_NUMBER>, 'roles': [], 'children': [], 'contacts': []}, 'flag': 'SECOND', 'approval': 'COMPLETE', 'listOrder': 0, 'create':<PHONE_NUMBER>} b34cf1b8a458d70d00450885314d4ff3 - no config options
2023-11-21 21:42:49.665 DEBUG (MainThread) [custom_components.xplora_watch.notify] init Notify Service


Versioning and release

Store version information in binary, link up with GitHub version tags. Makes it possible to print version of binary. Nice for diagnostics and "is this version out of date?" questions that will pop up sooner or later.

Seems to be done

Seems to be done


replace any with better types and move types to index.d.ts

Improve types
move types to index.d.ts

:tada: This PR is included in version 6.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Paging for actions

When tons of actions are dispatched, rendering all of them gets very expensive. Some sort of paging based on the widget size would help dramatically.

Instead of doing paging, I'm probably going to implement this:
https://github.com/jsdotlua/virtualized-list-lua


Qustions about the BreastPathQ dataset.

Thanks for your effort for releasing this great code, I have some issues towards the BreastPathQ dataset. I wander where can i get the target of the testing set of BreastPathQ dataset, since the official site on grand challenge only have labels of training and validation set.

The BreastPathQ challenge dataset is publicly available here: https://wiki.cancerimagingarchive.net/pages/viewpage.action?pageId=52758117
Corresponding details regarding the dataset can be found in this paper: https://www.spiedigitallibrary.org/journals/journal-of-medical-imaging/volume-8/issue-3/034501/SPIE-AAPM-NCI-BreastPathQ-Challenge--an-image-analysis-challenge/10.1117/1.JMI.8.3.034501.full


Alerting on complete withdrawal of configured prefix

An ARTEMIS user may want to monitor their own prefixes for a complete withdrawal from the global BGP table.  It's a sort of self hijack, not via BGP path, but via misconfiguration.
To achieve this in ARTEMIS, including a configuration attribute like "monitor_for_withdrawal" could be added to the rule definitions with a value of True or False.  If set to True, each prefix within the configured rule would alert if there's a complete withdrawal from the global table, much like how active hijack alerts on complete withdrawal now.
Thanks for taking a look, guys

I think this is a really nice idea.
Maybe it could be specified as a minimum allowed visibility. I.e., if less than x% of (or less than n) monitors see this prefix announced following the rest of the rule parameters then trigger a low-visibility alert.

Since everything in ARTEMIS has been built around the concept of early detection of BGP hijacks, and migrating to a withdrawal event monitoring logic requires a totally new set of modules/microservices, this will be moved to release 2.0 since it requires major changes/extensions to the tool.
@slowr @pgigis if you have ideas on how to integrate this smoothly in the current logic, please feel free to comment here.


Fix README for '1221-domain-with-resources' example

The README file for '1221-domain-with-resources' example is incorrect (it is the one which one used for '1221-appdeploy' sample). Please add appropriate instructions in the README (related to the Data Source and JMS infra setup)

@abhirockzz mind to provide a Pull Request with what you have in mind?

@abhirockzz any chance you can provide a PR to fix this issue?

@abhirockzz can you submit a pull request?

done... PR #168


Disable pedantic warnings only for mavlink_types.h

Just rather than turn off the "pedantic" warnings (issued when something does not conform to the specified standard, in this case ISO C99) for the whole project, only turn them off for the offending file that we have no control over (mavlink_types.h).

Cool!


[B13] Wonky golem pathfinding

Golems get stuck when blocks are placed diagonally next to eachother like this:
BX
XB
Where B is a block and X in air.
In this case, the golem will try to get to the top-right X from the bottom-left X even though it can't due to the blocks.
Golems also get stuck on the edges of blocks sometimes. I'm guessing this is also because it wants to go diagonally but gets stuck on a block that's partly in the way.
Also, wheeled golems still try to pathfind up onto 1-high blocks even though as far as I know they should only be able to go up slabs and stuff like that. Sometimes they even succeed in going up those blocks.

Also, golems can't really pathfind up properly, one just kept jumping and going in circles while it just had to go walk around and up the stairs I made for them.

Some people have had luck fixing pathfinding issues in previous versions by using half-slabs and such. I know it's not a fix, but it may help in the meantime.


Btm 227 index transaction data

I can't approve as I opened the PR but I've read through it. Definitely don't understand all of the cloudformation stuff but nothing jumped out at me.


Change comment file path to relative instead of absolute URI

This PR replaces the absolute file path with the relative one in the comments in the assets.dart file. The reasoning behind this is because when working in a team, every time when a team member runs the code generation command, the assets.dart file will change, while the only changes in the file were the comments. ex:
This:
  /// ![](file:///Users/khaleel/my_app/assets/svg/img-placeholder-user1.png)

Would change to this:
  /// ![](file:///Users/ahmed/my_app/assets/svg/img-placeholder-user1.png)

In case of PR approved, this is the end result:
  /// ![](assets/svg/img-placeholder-user1.svg)

Why this was not merged?


Fixing error response for CosmosDB 2020-06-01-preview

All SDK Contribution checklist:
Swagger PR: https://github.com/Azure/azure-rest-api-specs/pull/12800
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ x If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[x] Include updated management metadata.
[x] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@nichatur Could you fix the failing ci tests?

Hey @YalinLi0312, the ci is failing bcz of discrepancy in generated code and reference. The discrepancy arise bcz we are using preview version to generate this code and our swagger specs define stable version as the default tag. In this PR we intend to check in and release the preview apiVersion. We don't want to change our default version in swagger just to get this checked in.
Please help us merge this PR in its current state.

Reviewed code generation diff. It is correct. Overriding the error.


Mark notification as completed

Notifications have the readAt value to show if they have been read
However nothing marks the notification as completed when accepting, perhaps we could add "completedAt" when the callback is called.

fixed in https://github.com/kthcloud/go-deploy/pull/358


Lime 1096 test

Proposed changes
What changed

Why did it change

Issue tracking

LIME-XXXX

Other considerations

Testing PR


site: add gitinfo

We've enabled gitinfo for docsy, but I don't see a reference to the commit in the generated site. Maybe something is broken?
This is valueable for #46 so we can reverse reference a preview, and to see the latest commit deployed to production.

docsy includes git info via https://github.com/google/docsy/blob/main/layouts/partials/page-meta-lastmod.html, but it's not clear the doc layout we're using includes it. Seems like this might be a bug, or an issue with having a misconfigured footer.


Update sbt to 1.7.2

Updates org.scala-sbt:sbt from 1.7.1 to 1.7.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (1.7.1).
You might want to review and update them manually.
yarn.lock

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-sbt", artifactId = "sbt" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Codecov Report

Merging #616 (966a7c1) into main (9fd4560) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #616   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           65        65
  Lines         2843      2843
  Branches       475       475
=========================================
  Hits          2843      2843

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Superseded by #655.


Retrying transactions with backoff

Porting from Android and web.

@mikelehen you'll need to remove your changes requested flag for this to proceed.


[nrf noup]: logging: Logger fixes

This PR includes fixes for following issues:

asserts not printed
device hangs on going to deep sleep mode when JLink is not connected

Fixes are needed to enable proper automated testing on nRF52 Desktop devices.
With the next mergeup, these commits shouldn't be included anymore (they come from upstream).

Holding off because of upmerge https://github.com/NordicPlayground/fw-nrfconnect-zephyr/pull/94


How to use the admon plugin through the mdformat api?

Other plugins can be used with the api (see the example below), but if I try to use mdformat-admon I get error:
plugin = mdformat.plugins.PARSER_EXTENSIONS[name]
KeyError: 'admon'
import mdformat

mdformat.text(
        content,
        options={"wrap": 80, "end-of-line": "keep"},
        extensions={
            "gfm",
            "tables",
            "footnote",
            "frontmatter",
            "configblack",
            "mkdocs",
        },
        codeformatters={
            "python",
            "bash",
            "sh",
            "json",
            "toml",
            "yaml",
            "javascript",
            "js",
            "css",
            "html",
            "xml",
        },
)

versions:
mdformat==0.7.16
mdformat-admon==1.0.0
Thanks

Thanks for trying the plug-in!
I think the issue is that I need a minimum version constraint on 'mdit-py-plugins' to ">=0.3.2"
What version of Python are you using? Can you update that dependency?
I'm flying home now and I'll troubleshoot when I'm back on my laptop

Thanks for developing the plug-in, it is very useful.
I'm using python 3.9, and generating dev dependencies with pip-compile:
mdit-py-plugins[linkify]==0.3.3
# via
#   jupytext
#   mdformat-footnote
#   mdformat-frontmatter
#   mdformat-gfm
#   mdformat-mkdocs

I was definitely overthinking it! You'll want to add "admonition" instead of "admon". I could alias admon to support either, but I would prefer to have just one way
I've added a test here to make sure this use-case is supported:
https://github.com/KyleKing/mdformat-admon/blob/b3872f044651f3d9269b122d7a55abdbc396692b/tests/test_mdformat.py#L10-L16
Let me know if that works!

@KyleKing Thanks a lot.


Add FlatList, SectionList & VirtualizedList support

As far as 0.43 is out, it would be great to support new list views (ref: https://facebook.github.io/react-native/blog/2017/03/13/better-list-views.html)

cc @patrick91

Thanks 🙏🏻


[KOGITO-4691] remove drools protobuf v7 serializer (WIP)

JIRA https://issues.redhat.com/browse/KOGITO-4691

Jenkins this is ok to test

this is ok to test.

this is ok to test


[FEATURE] Geo Chart

Hey guys,
Has anyone thought about creating a Geo Chart?
I couldn't see any existing plugins with one. If not I may look into how to create one. Any advice?

In my opinion, this type of chart is radically different than what is currently available in Chart.js. I do not think that it would fit well with our current library, and it would require a lot of new code to be written. With all this code would come an increase in file size, and I do not see many users needing this functionality.
Honestly, I think your best bet would be to turn to a different library for this functionality.

I agree that the chart proposal is very different from anything on chart.js.
But I do not think we should limit ourselves to not increasing the size of the library. For this we could modularize the library, for example: Core (all the basic code shared by all the charts), and a module for each type of chart, or group of chart, so who will use only imports the modules that are actually used , that is, it only "pays" for what it "uses". This would improve even the current state of the library.

@fernandocode I've suggested a similar thing a while ago, and that's actually how it worked for v1. However, I can't seem to remember why we never implemented in in v2.

Closing because it will not be implemented in the core library but can be easily initiate by anyone who wants to work on it as an external plugin.


pyinfra: fix paramiko dependency with patch

Description of changes
Fix pyinfra with patch for paramiko dependency from @pbsds proposed in #256796 until paramiko version requirement change gets merged upstream.
Without this patch, pyinfra is currently broken, so the sooner this gets merged the better.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I was in the process of cherry-picking this commit to a new PR, but you got ahead of me.
I'll refrain merging this since I consider that a self-merge, but LGTM.
ZHF #265948 fixes https://hydra.nixos.org/build/238888742

@ofborg build pyinfra pyinfra.passthru.tests


Move from Todo.md to Issues

A Todo File is definitely a good start for brainstorming, but shouldn't we start to use issues ?

Sure, feel free to create them!

I created all issues. Should i delete the markdown file ?

👍

i deleted the Todo file


Print job EOF immediately after setup section

Version: CUPS Windows Driver 6.0
CUPS.org User: h.blischke
System: Windows XP SP2, CUPS driver for Windows 6.0
When printing documents containing high resolution images from Adobe InDesign CS3, the print job transferred to the printer is aborted just after the EndSetup comment line (one additional line doing a save is still present).
When, instead of printing, writing a PostScript file, the job contains pages the size of which is somewhere between 100 and 250 megabytes.

When using the driver without the CUPSxx6 stuff, printing is OK.

No longer maintaining the Windows driver.


hang when try to rotat phone

hi i am using your library in my android project
but when i try to rotate phone portrait to landscape its hand for 3 or 4 sec

need more information, like phoneModels and logs

maybe no useful log


Add plugin cerebro-shorten-url

Both plugin cerebro-gitio and cerebro-bitly are not working hence this plugin.
Thanks

Thank you :D


Functional tests for shared code use added (closes #294)

\cc @AlexanderMoskovkin
PR

/r-

FPR

/r-

rebase to upstream/master required

FPR
\cc @helen-dikareva, take a look, please

/r-

FPR

lgtm

lgtm
@MargaritaLoseva please review the current version with corrections

lgtm


[tf.data] Use output_shapes from python for batch dataset

This is a PR from JIZHI, the AI platform in Tencent.
This pr is related to #40938 . It removes the output shape calculation in C++ for BatchDatasetOp and PaddedBatchDatasetOp and use the shapes passed from python instead.
Thank you for your time on reviewing this pr.

@jsimsa
Could you have a look at this pr? Thank you!

@jsimsa
Could you have a look at this pr? Thank you!

Hi @zhuzilin sorry for the delay in response. I was out of office for an extended period of time and am still catching up.
What is the motivation for your PR? I would prefer to keep the shape inference in C++ for the following reasons.
In general, we could rewrite the tf.data graph in a way that would allow the C++ shape inference to be more accurate. For instance, if the rewrite would set the drop_remainder attribute to True. If use the shapes from the original Python shape inference, than we lose this ability.
In other words, there are reasons for having separate C++ and Python shape inference and I would prefer to keep both.

@jsimsa
Thank you for your nice explanation! This pr is just me wondering why we need both c++ version and python version of the shape inference.


Add search.removeWidget

The same way we have addWidget we should have removeWidget that would allow clean the DOM, call private destroy method etc..

react-instantsearch is gonna implement unmounting, this should allows us to do that in ISV2 #1459


Merge upload song feature

Changes on client side branch need to be merged to Dev before closing this pull request


Fixes DF-1601 - fix incomplete filtering

Fixes behavior of filters when partial date ranges are entered.
Fixes #261 and #365.
Additions

Adds formatDateString function for formatting the values returned from the date inputs.
Adds jsdoc comment to isValidDateRange.

Changes

Makes the date range displayed for results only display as a single month + year when both start and end date range are the same.
Changes validDateRange function name to isValidDateRange to better convey it returns a boolean.

Testing

Visit /blog/ or /newsroom/ and play around with the dates in the filtering.

Review

@jimmynotjim
@sebworks
@Scotchester

Preview

Notes

The swapping behavior seems kind of off to me. I'm wondering if perhaps more ideally the user would be prompted that there's an error in how they entered the range and whether they'd like to swap the values. That's out of scope for this PR however.

I think auto swapping the dates if the user inverted them is helpful UX. Why make them have to stop and think about what they meant to do instead of just fixing it for them? It's one of those things no one will really notice but appreciate if they knew it was handled for them.

LTGM

I think auto swapping the dates if the user inverted them is helpful UX. Why make them have to stop and think about what they meant to do instead of just fixing it for them? It's one of those things no one will really notice but appreciate if they knew it was handled for them.

Yeah, no doubt this was done for that reason. Thinking about it, here's what bothers me about it: There's no reason the date range couldn't mean "from a more present date to one in the past". Take this range:

I'd kind of expect that the posts would be returned in reverse chronological order from Feb 2011 to Jan 2011, which is what happens. However, the swapped values make it look like it should be displaying posts in chronological order, starting from January 2011:

So that's essentially says "display posts from January 2011 to February 2011" ... but what's actually displayed in posts from February 2011 in reverse chronological order back to January 2011.

Ah, I didn't notice the label was reversed. I definitely agree that part should be fixed.

That is, in fact, exactly why we did the swapping behavior. To play a little devil's advocate:

Does anyone ever expect blog/news posts to be returned in chronological order?
This is a filtering function, not a sorting function. I was surprised to hear your interpretation of "from/to" as "top-to-bottom of the results". I would expect most users to only take it to mean "I want results form this month to that month". But you know what they say about assumptions. Probably something worth doing some usability testing on.

It depends, but if I'm filtering by date without a keyword to match, I kind of expect them to be sorted by date as well.
Since the API does return them chronologically, we may want to include a label so it's obvious or add a sorting option (even if it's just simply "sort by oldest/newest").

Thanks for the input @Scotchester, hope it doesn't feel like I'm trashing the logic you guys put into the project! :)
Fundamentally, I'd kind of expect the interface to do what I told it to do. If I can put in a date that was not allowed, I'd kind of prefer the interface didn't allow me to enter erroneous info in the first place.

Doesn't feel like that at all :) Our decisions are always up for constructive criticism.
One thing I meant to say in my previous comment that didn't: I agree that it doesn't need to be swapped at all. The result set is the same (ordering aside) if the from and to dates are swapped, so let's not confuse the user by swapping them.
On your second paragraph, Ans: agreed. I think we always intended to have better client-side validation "when we get around to it". We should prevent users from entering bad/impossible selections, when possible.

Moved to https://github.com/cfpb/cfgov-refresh/issues/416


Partially cut road label

https://www.openstreetmap.org/#map=13/48.25005/7.20737&layers=P

This is on the radar and technically hard to solve with carto. This will be solved by rendering raster tiles from vector tiles on demand. In next year we'll have a prototype for that.


Support producing messages to topics from a rule executor

See https://phabricator.wikimedia.org/T133221 for some background.
I'm not 100% sure we really want to allow this or not (should all the event production go through the eventlogging-service, or would we allow doing shortcuts like this?)
cc @wikimedia/services

Tests depend on https://github.com/wikimedia/swagger-router/pull/40

Coverage increased (+0.1%) to 94.697% when pulling b0b9a292214a49778f7cc544d8c44f2331c97f6d on Pchelolo:produce_endpoint into 43f67829ce434377569ab205dd056bfdb51fcc31 on wikimedia:master.

Coverage increased (+0.08%) to 95.238% when pulling 447ee90234b78783363f563113503fbb40fdd86e on Pchelolo:produce_endpoint into 3107d7d3c8578d581ef60065004cc6653820851b on wikimedia:master.

I'm :+1: on the general approach.
We discussed making the interface more similar to the eventbus proxy service:

use an events entry point
per-event meta element, specifying the topic & other bits

One potential issue we found is that the eventbus proxy requires meta elements like dt to be supplied, but doing so in each rule handler would get quite repetitive. We might want to fill in several of those meta properties in this end point, so that rule handlers only need to specify the essentials.

@gwicke Ye, I've updated it

Coverage decreased (-0.6%) to 94.608% when pulling a56413a127dd1f0bccaf5a907790eb06e50dec0d on Pchelolo:produce_endpoint into 3107d7d3c8578d581ef60065004cc6653820851b on wikimedia:master.


Add support for US v1.0

Totally not urgent, but would be nice to have for those who only have 1.0 cartridges available.
If this is something that's mostly a matter of typing it out (i.e. "take the 1.1 config and update a wall of offsets with correct ones from Tool X") I can try to look at this, but I'm not sure how much actually changed beyond the high score fix.

You'd need to make a complete disassembly of that version, identify all the same assets we have identified in 1.1 and then make ast_ yamls containing the addresses of all the assets in the game updated to 1.0.


Update ListOfMultiples.py

Description
Write here what you have changed
Issue No.- #

Type issue number after hash(#)

Checklist

[ ] Yes, this task assigned to me.
[ ] My code follows the style guidelines(Clean Code) of this project
[ ] I have performed a self-review of my own code
[ ] My Filename is in camelCase format
[ ] I have added Problem statement, Problem link in file.

Issue no. help us reduce spam PR. There is no issue number to verify that the issue was assigned to you or someone else.


How can I get follower after logged in ?

What do you mean by follower? You should be able to get the profile with fetchProfile https://github.com/tkporter/react-native-fabric-twitterkit/blob/master/FabricTwitterKit/FabricTwitterKit.m#L37

I am taking about follower @tkporter . api from twitter https://dev.twitter.com/rest/reference/get/followers/list

Doesn't seem like there is that functionality at the moment. Feel free to submit a PR if you end up needing this :)


Enhance NODE level stop/maintain and shutdown

sub-story of [FEATURE] Optimize for Frequent Power-off/Power-On
draft:
NODE drain, maintain, flush file systems, backup important files, shutdown ...

Harvester has supported to put a node into maintenance mode, it will migrate all VMs away.
https://docs.harvesterhci.io/v1.2/host/#node-maintenance

I guess we need a way to control "shutdown all VMs" or "pause them persistent" when initiating a shutdown / poweroff.. - same challenge with kvm where we can save the state to disk during shutdown and load it during startup..
What does harvester do in single node scenarios when initiating poweroff? Will it tell the VMs to shutdown and wait until they are stopped?


doc/chore: move discussions from gitter to this repo

Point to GitHub discussions rather than the gitter forum
Use the new GitHub issue template system

Closes #124

Closes #124


Modal window appears shifting of the all page content

When i click and window opens - all my page content (including html background) shifts to the right a bit.
I think it caused by
html.remodal-is-locked { overflow: hidden}
If i remove this property - everything is ok, but scrollbar on the right of modal background appears (not good)

Having a similar issue here and there are solutions out there. The reason the class does what it does is, it makes all of the content on the page not scollable, which means browsers will remove scroll bars on content that has no overflow to scroll to.
On most browsers (I believe IE is an exception here) the scroll bar is not factored in. For example a centered block factors in the scroll bars when centering so when the scroll bar vanished on overflow:hidden, it re-positions the center line, moving all your content to the right.
If you google how to compensate for the lack of scroll bar you will find a few different ways of over coming this.
Hope that helps, as I was looking into this as well.

Thanks for reply. When i tried google-d solutions - i didn't receive proper result. Sometimes i realized "body" proper behavior, sometimes "html" proper behavior, but never both of them. My solution - i commented  lockScreen() and unlockScreen() procedures, but i don't understand - is it ok or not for overall usability?

Are those functions the ones used in the javascript to lock the screen? So you mean you have left it so if a modal is open, you can still scroll? Honestly I could not be hassled with trying to solve the issue so left the scroll bars on so you can scroll.
I feel like if a user has initiated a popup/etc they are reading the contents of it and either end up clicking the contents or if they want to continue going through content on page, they can exit the modal and scroll. Users should naturally close the modal before continuing. Unless it is not obvious how to close the modal because being able to scroll with a non-closable modal/popup screams glitchy to me.
I am sure there are easier solutions out there but for the time being I am ok with this usability sacrifice...


Incompatibility with typescript 2.6.1

Since I updated to latest version of typescript "runtypes" lib is not working!
Here below a screenshot of the sample in your documentation.

Instead of a screenshot could you post a minimal, self-contained code example?

Ah, just literally the example code? What are the full error messages, leaving out the tslint ones?

import { Array, Boolean, Literal, Number, Record, String, Tuple, Union } from "runtypes";

const Vector = Tuple(Number, Number, Number);

const Asteroid = Record({
  type: Literal('asteroid'),
  location: Vector,
  mass: Number,
})

const Planet = Record({
  type: Literal('planet'),
  location: Vector,
  mass: Number,
  population: Number,
  habitable: Boolean,
})

const Rank = Union(
  Literal('captain'),
  Literal('first mate'),
  Literal('officer'),
  Literal('ensign'),
)

const CrewMember = Record({
  name: String,
  age: Number,
  rank: Rank,
  home: Planet,
})

const Ship = Record({
  type: Literal('ship'),
  location: Vector,
  mass: Number,
  name: String,
  crew: Array(CrewMember),
})

const SpaceObject = Union(Asteroid, Planet, Ship);

Compiled with tsc --strict ./test-runtypes.ts
This is the output:
node_modules/runtypes/lib/reflect.d.ts(58,33): error TS2344: Type 'Reflect' does not satisfy the constraint 'Runtype<any>'.
  Type '{ tag: "never"; } & Runtype<never>' is not assignable to type 'Runtype<any>'.
    Types of property 'And' are incompatible.
      Type '<B extends Runtype<any>>(B: B) => Intersect2<{ tag: "never"; } & Runtype<never>, B>' is not assignable to type '<B extends Runtype<any>>(B: B) => Intersect2<Runtype<any>, B>'.
        Type 'Intersect2<{ tag: "never"; } & Runtype<never>, any>' is not assignable to type 'Intersect2<Runtype<any>, any>'.
          Types of property 'And' are incompatible.
            Type '<B extends Runtype<any>>(B: B) => Intersect2<Intersect2<{ tag: "never"; } & Runtype<never>, any>,...' is not assignable to type '<B extends Runtype<any>>(B: B) => Intersect2<Intersect2<Runtype<any>, any>, B>'.
              Type 'Intersect2<Intersect2<{ tag: "never"; } & Runtype<never>, any>, any>' is not assignable to type 'Intersect2<Intersect2<Runtype<any>, any>, any>'.
                Types of property 'And' are incompatible.
                  Type '<B extends Runtype<any>>(B: B) => Intersect2<Intersect2<Intersect2<{ tag: "never"; } & Runtype<ne...' is not assignable to type '<B extends Runtype<any>>(B: B) => Intersect2<Intersect2<Intersect2<Runtype<any>, any>, any>, B>'.
                    Type 'Intersect2<Intersect2<Intersect2<{ tag: "never"; } & Runtype<never>, any>, any>, any>' is not assignable to type 'Intersect2<Intersect2<Intersect2<Runtype<any>, any>, any>, any>'.
                      Types of property 'withConstraint' are incompatible.
                        Type '<K>(constraint: ConstraintCheck<Intersect2<Intersect2<Intersect2<{ tag: "never"; } & Runtype<neve...' is not assignable to type '<K>(constraint: ConstraintCheck<Intersect2<Intersect2<Intersect2<Runtype<any>, any>, any>, any>>,...'.
                          Type 'Constraint<Intersect2<Intersect2<Intersect2<{ tag: "never"; } & Runtype<never>, any>, any>, any>,...' is not assignable to type 'Constraint<Intersect2<Intersect2<Intersect2<Runtype<any>, any>, any>, any>, any>'.
                            Types of property 'constraint' are incompatible.
                              Type 'ConstraintCheck<Intersect2<Intersect2<Intersect2<{ tag: "never"; } & Runtype<never>, any>, any>, ...' is not assignable to type 'ConstraintCheck<Intersect2<Intersect2<Intersect2<Runtype<any>, any>, any>, any>>'.
                                Types of parameters 'x' and 'x' are incompatible.
                                  Type 'any' is not assignable to type 'never'.
test-runtypes.ts(5,25): error TS2345: Argument of type '{ type: Literal<"asteroid">; location: Tuple3<Number, Number, Number>; mass: Number; }' is not assignable to parameter of type '{ [_: string]: Runtype<any>; }'.
  Property 'type' is incompatible with index signature.
    Type 'Literal<"asteroid">' is not assignable to type 'Runtype<any>'.
      Types of property 'Or' are incompatible.
        Type '<B extends Runtype<any>>(B: B) => Union2<Literal<"asteroid">, B>' is not assignable to type '<B extends Runtype<any>>(B: B) => Union2<Runtype<any>, B>'.
          Type 'Union2<Literal<"asteroid">, any>' is not assignable to type 'Union2<Runtype<any>, any>'.
            Types of property 'alternatives' are incompatible.
              Type '[Literal<"asteroid">, any]' is not assignable to type '[Runtype<any>, any]'.
                Type 'Literal<"asteroid">' is not assignable to type 'Runtype<any>'.
test-runtypes.ts(11,23): error TS2345: Argument of type '{ type: Literal<"planet">; location: Tuple3<Number, Number, Number>; mass: Number; population: Nu...' is not assignable to parameter of type '{ [_: string]: Runtype<any>; }'.
  Property 'type' is incompatible with index signature.
    Type 'Literal<"planet">' is not assignable to type 'Runtype<any>'.
      Types of property 'Or' are incompatible.
        Type '<B extends Runtype<any>>(B: B) => Union2<Literal<"planet">, B>' is not assignable to type '<B extends Runtype<any>>(B: B) => Union2<Runtype<any>, B>'.
          Type 'Union2<Literal<"planet">, any>' is not assignable to type 'Union2<Runtype<any>, any>'.
            Types of property 'alternatives' are incompatible.
              Type '[Literal<"planet">, any]' is not assignable to type '[Runtype<any>, any]'.
                Type 'Literal<"planet">' is not assignable to type 'Runtype<any>'.
test-runtypes.ts(26,27): error TS2345: Argument of type '{ name: String; age: Number; rank: Union4<Literal<"captain">, Literal<"first mate">, Literal<"off...' is not assignable to parameter of type '{ [_: string]: Runtype<any>; }'.
  Property 'name' is incompatible with index signature.
    Type 'String' is not assignable to type 'Runtype<any>'.
      Types of property 'Or' are incompatible.
        Type '<B extends Runtype<any>>(B: B) => Union2<String, B>' is not assignable to type '<B extends Runtype<any>>(B: B) => Union2<Runtype<any>, B>'.
          Type 'Union2<String, any>' is not assignable to type 'Union2<Runtype<any>, any>'.
            Types of property 'alternatives' are incompatible.
              Type '[String, any]' is not assignable to type '[Runtype<any>, any]'.
                Type 'String' is not assignable to type 'Runtype<any>'.
test-runtypes.ts(33,21): error TS2345: Argument of type '{ type: Literal<"ship">; location: Tuple3<Number, Number, Number>; mass: Number; name: String; cr...' is not assignable to parameter of type '{ [_: string]: Runtype<any>; }'.
  Property 'type' is incompatible with index signature.
    Type 'Literal<"ship">' is not assignable to type 'Runtype<any>'.
      Types of property 'Or' are incompatible.
        Type '<B extends Runtype<any>>(B: B) => Union2<Literal<"ship">, B>' is not assignable to type '<B extends Runtype<any>>(B: B) => Union2<Runtype<any>, B>'.
          Type 'Union2<Literal<"ship">, any>' is not assignable to type 'Union2<Runtype<any>, any>'.
            Types of property 'alternatives' are incompatible.
              Type '[Literal<"ship">, any]' is not assignable to type '[Runtype<any>, any]'.
                Type 'Literal<"ship">' is not assignable to type 'Runtype<any>'.

Looks like it’s running afoul of —strictFunctionTypes.

You're right, and it also takes ages to compile my project!
Disabling strictFunctionTypes in tsconfig
...
"strict": true,
"strictFunctionTypes": false,
...

Brings things to the normality.

This looks to be due to a bug in TypeScript. I've implemented a workaround in the meantime.


Add additional control over Reveal.js Server

it bothers me a little that reveal.js server is started by default. I want to have control over starting and stopping the server, so I added 2 commands "start server" and "stop server", as well as an option for automatic start (it's enabled by default for backward compatibility). I've built it and checked that it works in my vault

This can be marked as fixes #169


Docs: create a new users API for fetching and updating users.

This adds the product docs for the new users API.

@emmerich There are no changes in the files for some reason.

@deepakprabhakara Yes sorry, opened the PR in error!


LTSC to SAC requires a product key to keep apps. I have edited the post via github.

You will need to use the Product Key switch if you want to keep your apps. If you don't use the switch the option 'Keep personal files and apps' will be grayed out. The command line would be: setup.exe /pkey xxxxx-xxxxx-xxxxx-xxxxx-xxxxx using your relevant Windows 10 SAC product key. For example, if using a KMS, the command line would be setup.exe /pkey NPPR9-FWDCX-D2C8J-H872K-2YT43

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08436cb0-d0b6-0961-9e57-291b24d73644
Version Independent ID: 36264f52-d3ac-4e50-f8e8-b09d6b210490
Content: Windows 10 upgrade paths (Windows 10)
Content Source: windows/deployment/upgrade/windows-10-upgrade-paths.md
Product: w10
Technology: windows
GitHub Login: @greg-lindsay
Microsoft Alias: greglin

@officedocsbot assign @jvsam

Hi @andrewjohnporter from my understanding, you've suggested an update to this documentation. Is there a pull request made to this commit 0787b37 so we can track? Thank you.

@jvsam : That would be PR https://github.com/MicrosoftDocs/windows-itpro-docs/pull/4548 (from the commit page, in the parenthesis)

Awesome, thank you @illfated
Hi again @andrewjohnporter, the changes have been merged and will be displayed at docs.microsoft.com in the next scheduled publishing run, so please monitor this doc. We will now close this issue and consider it resolved, thank you.

@officedocsbot close


How do color and depth images align

How do color image and depth image align using realsense D435i？

Hi @sunbin1357  If you need to know about both depth to color alignment and about color to depth alignment, Intel's white-paper document about projection, texture mapping and occlusion provides a useful reference in the link below.
https://dev.intelrealsense.com/docs/projection-texture-mapping-and-occlusion-with-intel-realsense-depth-cameras#section-3-4-stream-alignment
The opening section of the documentation for the Align sample program provides further useful information.
https://github.com/IntelRealSense/librealsense/tree/master/examples/align#overview

Hi @sunbin1357   Did the information above answer your question pleae?  Thanks!

Case closed due to no further comments received.


Question: node_modules folder in other place

I use the .yarnrc file to specify where the node_modules folder is located. I don't have to know where the place is, yarn knows.
https://github.com/FormidableLabs/enzyme-matchers/blob/master/packages/jest-enzyme/README.md
How do I have to specify the setupTestFrameworkScriptFile in the package.json?

Hi,
setupTestFrameworkScriptFile: 'jest-enzyme' is enough.

Yes this is working fine, when the node_modules folder is in the project <rootDir>/node_modules/...., but when it is placed somewhere else I got:
yarn run v1.7.0
$ jest
● Validation Error:

  Module jest-enzyme in the setupTestFrameworkScriptFile option was not found.


Images arent closed after transforms

[ x ] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

What are the steps to reproduce?
I upload an image with multer, then with Sharp I transform it to .webp and then save the image as .webp, then I try to delete the previous image but I can't because sharp keeps it open even though it has finished doing all its work.
I already checked and Multer is not the problem. I am trying to delete the images with fs.rm. I also tried with fs.unlink but to no avail.
Also to double check I tried to delete another image uploaded manually and then used to create a new image but the result was the same.
All the images that Sharp uses to create new ones does not close automatically. I also tried deleting the images manually but I get the same error (the problem is not fs.rm or fs.unlink), it only stops giving me the error if the application closes
Please provide sample image(s) that help explain this problem
Functions

Main

Error

Please see https://github.com/lovell/sharp/issues/415


Create new DrawBadgesApi to give a cleaner API for drawing badges

This requires you to have an instance of the API object (like the ZoomApiWrapper), and allows updating each badge individually, rather than all at once.
I haven't actually tested this or converted the existing usages of drawEverythingToImage to use this new API, but I think some of them should be simplified by not needing to keep track of the unchanged badges.  Note that we will need to get rid of all usages of drawEverythingToImage in order for the state to be correctly tracked by the DrawBadgesApi wrapper.

This seems like a good start; would you like me to continue completing the DrawBadgeApi? Or you prefer to work on it later?


Tone.Sampler clicks on the edges of attack (end of attack) or release (start of release)

You can see the darker parts indicating noise at the end of the attack and start of the release.
I tried to see if this was due to a gain jump by blocking the gain to 1.0 and it fixes the issue.
I will continue to investigate why the gain jumps like this and post any findings here.

can you post a snippet of the code for sampler?

const samples = Object.assign
( {}
, ...[ 0, 1, 2, 3, 4, 5, 6, 7 ].map ( k => ( { [ `A${ k }` ]: `/assets/piano/A${ k }v7.mp3` } ) )
)
const synth = new Tone.Sampler
( samples
, { onload: () => {
      console.log ( 'All samples loaded' )
    }
  , attack: 0.0
  , release: 0.5
  }
)
.chain ( Tone.Master )

The samples used are: http://archive.org/details/SalamanderGrandPianoV3
But the clicks are really audible and should happen with any sample material. Just use a velocity of 0.6 for example.

Hi, I'm having the same issue. Were you able to resolve it? I recreated a very minimal sampler below. The notes in the r12 demo definitely "click" compared to the r11 demo.
https://neutonfoo.github.io/ToneJS-Sampler-Bug/

kind of curious about how is this issue going. Any shareable progress or findings?

i'm pretty sure the issue is coming from this line. When it was canceling the previously scheduled stop, it would set it's gain value to 1, which would cause a discontinuity at that moment.
i've fixed it in my local dev, but in a refactor broke some tests that rely on the BufferSource. hope to have some time soon to address this and the other Sampler issue which i think is related.

It's not ideal, but I reverted to https://github.com/Tonejs/build/tree/35c2014724d5cdf83815ceec9cdfe41dc1e3f1d5 for now. This seems to be the latest version that didn't have the clicking noise.

Thank you !! 🙏❤


fix(assets): [WIP] Ensure DockerImageAsset are build and published correctly

This PR addresses https://github.com/awslabs/aws-cdk/issues/2070.

Pull Request Checklist

[ ] Testing

Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
CLI change?: coordinate update of integration tests with team
cdk-init template change?: coordinated update of integration tests with team

[ ] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated

[ ] Title and Description

Change type: title prefixed with fix, feat will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[ ] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Hi @alex-berger,
Have you considered the following solution:

always build, tag and push as latest (uses Docker layer caching mechanism, should be fast in most of the cases, in CI use --cache-from)
extract the repo digest (sha256) using docker image inspect <image> -f {{.RepoDigests}}
use the repo digest in the Task Definition / Container Definition. This is perfectly valid and looks like<PHONE_NUMBER>12.dkr.ecr.eu-west-1.amazonaws.com/image@sha256:1df2b010465f7f9b7e6409f32038096ad73f4e4634dfb9829e31346c202501ed

This optimizes for least deployments because if from the repo's point of view the image is the same, there is no update to the task definition and then no stack update.
There's a build and a push (latest) for every cdk deploy but Docker will use the layer cache during build and see that some or all the layers already exist in ECR during push. Resulting in little overhead for cdk deploy while ensuring correctness and minimizing deployments.

@jogold I started with a naive implementation without any optimizations because I first wanted a solution that works correctly. My primary goals for this PR are:

Ensure images are pushed to ECR whenever they changed, so we need reliable and correct change detection for Docker as well as for OCI images. This is way I started with image Id as it results from content based addressing. I agree, this might produce unnecessary updates to the CloudFormation Stack as the Id's underlying hash also covers metadata (not just the image's layers), however the behaviour will still be correct. Hopefully, we will find a better solution (in the fashion of calculateImageFingerprint) some day which will address this.
Identical and reproducible behavior for local and CI builds (principle of least surprise), this also implies that CI optimizations like --cache-from should not happen by default, but of course we can provide opt-in behavior (e.g. allowLayerCaching: true).
Support optional user provided tag names, for uses cases beyond ECS/Fargate, e.g. for EKS/Kubernetes and maybe in the long run to enable multiple different images (tags) per
adopted ECR repository. This is the reason why I removed latest. Maybe we can use a tag based on the assed.id instead of latest.

Please also be aware of the following facts:

RepoDigests array will be empty for newly built images. Furthermore, I guess it is not part of the OCI image specification and only available for Docker images.

RepoDigests array will be empty for newly built images. Furthermore, I guess it is not part of the OCI image specification and only available for Docker images.

As soon as you push, it's available. What about supporting user provided tags in ECR as you suggest but referencing the repo digest (sha256:...) in the task definition?

Note, I have not yet tested that code. I pushed it for discussion purposes.

Hey @alex-berger, I think it's time we get feedback from awslabs/aws-cdk-team on this.
Like you I'm just contributing to this project...

Making sure @sam-goodwin is aware of this change, as he is planning a refactor of how we build and publish assets. @rix0rrr can you also take a look?

@sam-goodwin, @rix0rrr as https://github.com/awslabs/aws-cdk/issues/2070 is a show stopper for us, how is this PR supposed to proceed? If there is anything I can help with, please let me know.

If there is anything I can help with, please let me know.

Yes. I need more context on this PR before I can properly review it. I'd like to understand what exactly the observed problem, the diagnosed root cause and the proposed solution are, because I feel I don't have a handle on the problem described in clear terms.
From the linked issue:

When applying small changes to a Docker image calculateImageFingerprint might return unchanged hash

What kind of "small change"? Can you give an example? Does this always happen.

However, from our findings this is not the cause of the problem.

So it wasn't calculateImageFingerprint? Then what did it turn out to be?
Also, is the caching change related, or another optimization you want to add, and how does it relate to @jogold 's automatic CI caching change?

I am going to close this PR as it does not look there is going to be any movement on it. Feel free to reopen in case of renewed interest.


Diff window reopens immediately after closing

When I use Git:Status and then press d to view the diff of a modified file, Meld gets opened as diff viewer which seems to be default on ubuntu. When I close it, it will reopen again. To break this loop I have to close the status tab, but it's pretty hard because it's only possible for a very short time until the window reopens.
My environment:
ubuntu 14.04 LTS
Meld 1.8.4
Sublime3 (Build 3065)
SublimeGit 1.0.32

I have the exact same issue. @bkahraman , did you find a workaround for this issue?


Update README.md

Fixed solution of Math/Donation, and some typos!

Thanks for the fixes @Aryan9592!

Mention Not!
Hey @0xJuancito, If I need any kind of guidance or help from you..which is the best platform to contact you (other than twitter). It's just I am on the same track which you already accomplished and it be better to have some kind of mentor..That's what I think. It be great if you got any discord.
and Thanks for this good repository!


Support compiling files in order

This is helpful for when you want to ensure that only specific files in a directory are parsed and also seems to ensure that they are parsed in a specific order, allowing you to reference schemas across files when compiling.
As such, relates to #13.
Additionally, some small tweaks:

updates maven central URL to https
adds --verbose_failures flag to help debug testing

@chenrui333 what do you think?