[framework] prototype - improve Notification API performance

currently this is unnecessarily breaking due to the method rename.

It would be cool if ViewportBoundary could just be an implementation detail of the Viewport widget (without the need to expose something like ViewportInternal)... As an idea: could the Viewport widget's custom element _ViewportElement just override dispatchNotification with the depth increasing logic?

dispatchNotification would skip any Element that isn't a notification element by design. We'd have to expose some APIs for overriding that allow other element types to participate in the notification tree.
I think you're right though, this is probably the way to go and involves fewer breaking changes.
I'll think about this one some more....

Tried to do some stuff with mixins but it is quite tricky.

OK!

Need to fill out docs more obvs...

I'm running a full presubmit right now 👯

I did spend some time going through the migration guide today. I guess I'm sort of concerned that for folks that don't override visitAncestor on Notification ... we're going to create a bunch of churn for no reason. Maybe I need to do a package survey to see if anyone actually does

I looked through google3 and while I found several notification classes none of them override the visit ancestor functionality. I am going to change this back to it was to reduce churn and we can re-evaluate if anyone flags it as an issue

I am slightly confused by this now, but maybe I misunderstood the original plan. I thought the idea was to deprecate Notification.dispatch and Notification.visitAncestor, but keeping their implementation untouched. In the deprecation notice, we would redirect people to the new BuildContext.dispatchNotification and tell them what to do if they want filtering logic that previously went into visitAncestor.
As it stands, this PR now redirects Notification.dispatch directly to BuildContext.dispatchNotification, bypassing Notification.visitAncestor altogether. So, if I relied on visitAncestor I'd still be broken - even worse, it would likely be a runtime breakage.

Oh, I think I missed https://github.com/flutter/flutter/pull/98451#issuecomment-1048931199. That makes sense then. Let's be very clear in the docs to visitAncestor that this method is no longer used. Implementing it has no effect since it is deprecated.

Sorry for the confusion - yes - since all of the subclasses of notification I looked at do not override visit Ancestor, I'm worried about additional churn when we don't really need to make the change a compile error.

TODO migration guide:
  /// Applied to each ancestor of the [dispatch] target.
  ///
  /// The [Notification] class implementation of this method dispatches the
  /// given [Notification] to each ancestor [NotificationListener] widget.
  ///
  /// Subclasses can override this to apply additional filtering or to update
  /// the notification as it is bubbled (for example, increasing a `depth` field
  /// for each ancestor of a particular type).
  ///
  /// This functionality was deprecated after v1.11.0 because of poor performance.
  /// If you have a Notification subtype that overrides this method, you can instead
  /// manually implement the old-style notification dispatch with the following
  /// snippet:
  ///
  /// ```dart
  ///  void dispatchNotificationSlowly<T extends Notification>(T notification, BuildContext context) {
  ///    context.visitAncestorElements((Element element) {
  ///       // Perform visit ancestor logic.
  ///       notification.myAncestorLogic(element);
  ///       if (element is ProxyElement) {
  ///         final Widget widget = element.widget;
  ///         if (widget is NotificationListener<T>) {
  ///           return widget.onNotification?.call(notification) ?? true;
  ///         }
  ///       }
  ///       return true;
  ///    });
  ///  }
  /// ```

Updated this PR by deleting the visitAncestor method - i'll use the notes I collected for a migration guide

for some reason my changes disappeared, sorry! Let me find them....

Draft migration guide at https://github.com/flutter/website/pull/6865


Training log of losses

Hi,
Thank you for your awesome research!
I am training the model with my own dataset, i want to know the training logs of losses if it is possible.
Discriminator loss seems to converge so fast (close to 0) , is it right?
Best regards,
Hankyu Jang

Hi, thanks for your interest of our work. The loss of D would not converge to 0 under normal conditions. Which loss logs do you want to know, I could send them to your mail.

Thank you for your answer.
Can I know the graphs of G, D losses  in the tensorboard?

Hi, part of the training logs of FFHQ-256 could be viewed here.
Loss of G, loss of D and r1_val.

Thank you!


Explore gometalinter to replace our own set of shell scripts

The fewer things we have to maintain the better. While I wrote custom scripts to make sure we regress on goreport, it may be a good idea to replace them by gometalinter. Careful to not overdo it and introduce awkward checkers that make us bend backwards to eliminate unhelpful warnings.

See https://github.com/kubernetes-incubator/cri-o/blob/master/.tool/lint


[Slack-V2] Make the bot answer with an agent picker if we could not route the message

If a message sent to the Slack bot could not be routed (ie: no linked channel, no ~mention), the slack bot should answer with a interactive select menu (see example here) to allow the end user to pick an agent and then post a user message with a mention to the select agent(s).
You can see the Slack interactive message documentation here:
https://api.slack.com/messaging/interactivity

Closing as stale

For the record we decided to not implement this for two reasons:

Not important enough
Users would get confused with a dropdown and potentially 100+ assistants in the list.


ClusterNetwork/DefaultNetworks error message improvements

What would you like to be added:
Currently in case of ClusterNetwork/DefaultNetwork error, multus gives ambiguous error messages and cannot identify error and not found.
Why is this needed:
Ease of troubleshooting

closed because the latest multus adds more messages than before.


expanded DAG tests for alignment. others WIP.

What problem is the PR solving / What's new?
Our workflow is complex. This means many edge-cases can arise.
Testing a build is cumbersome, since it relies on Jenkins and uploading to git.
This PR takes the DAG tests out of Jenkins, and into a shell script that can be executed locally.
With this we can test the logic connecting rules much more easily, and more thoroughly.
What did change
DAG tests are taken from the Jenkinsfile and placed in dag_tests.sh.
This script will be called by the Jenkinsfile
DAG tests are expanded to include more logic (replicates, conditions, etc.)
Between tests, files are touched to reduce the complexity of the DAG where possible without compromising the complexity of the test (e.g. bam files are touched after alignment tests are completed)
Does this need additional test(s)?
I AM THE ONE WHO TESTS!

Really nice! Is the idea that we call this script in the Jenkinsfile? Or that we keep them separate?

P.s. installing conda takes really long at the moment. Can I ask you to take a look at this? :angel:

This will eventually be called in Jenkins, yes!
btw, the method is already finding the edge-cases I was talking about. Quite a few steps (QC reports and trackhubs) break when using >1 assembly. I hope I can find the issues before the transfer to seq2science.

the script (so far) is working, yay!

@siebrenf please ping me when it's ready for review.


Fix first path passed to protoc

Fix relative path passed to protoc when using RELPATH but NANOPB_GENERATE_CPP_APPEND_PATH not set. In this case the path provided by RELPATH should be passed to protoc first instead of the current source directory.
This was working before and broke with 8cc860c.

@kurddt can you have a look as you did the changes in 8cc860c?

It would be great to have some test cases for this, but I don't really know how each CMake option is supposed to be used.

I never wrote any tests for cmake stuff :(

@twam the line
https://github.com/nanopb/nanopb/blob/8ef41e0ebd45daaf19459a011f67e66224b247cd/extra/FindNanopb.cmake#L147
should be changed to
list(APPEND _nanopb_include_path "-I${ABS_PATH}")

I currently don't have any way to test this so could you check it and make a PR if it works for you ?

Thanks for the quick check. That also works fine.

Thanks both!


Generalized linear model plugin

This PR adds a generalized linear model plugin. The plugin models the data based on the modeltype and the method mentioned using glm in R. The input and output for this plugin is .csv file.

Same issue with #82. Please fix and open a new PR.


BUG: UCC Import from Add On Builder does not work if you are using Global Account Settings Setup Parameters

Description
Hello,
Running into what I think is a bug. I am trying to convert my add on builder app to a splunk packaged app using ucc. However, I am getting the following error:
ERROR: placeholder option found for configuration tab 'account' -> entity field 'username'. We recommend to use help instead (https://splunk.github.io/addonfactory-ucc-generator/entity/).
Deprecation notice: https://github.com/splunk/addonfactory-ucc-generator/issues/831.
Recreation steps:
Create an app using Splunk Add on Builder -> Add Global Account Settings to Set up Parameters -> use UCC import from AOB function
I could very well be missing something as I am new to using UCC. But, there does not look to be a way that I can stop using the placeholder option in username as this is a global account setting and doesnt really have a changeable option. Is there a way to fix this or to ignore the error?

What UCC version are you using?
splunk-add-on-ucc-framework=5.50.1
Additional System Info
Python Version: Python 3.8.16

@TTony5, thank you for the feedback!
Removing the placeholder is an intentional decision. This attribute is often overused in misleading UX patterns, so we dropped its support since it is frequently misused. Read about issues placeholders can cause.
Please help me understand your use case. Do you want to make a read-only field?
If it is "very" static, you can set it's value in globalConfig.json via defaultValue. Here is an example:

Would this work for you?

It needs to be dynamic unfortunately as it will allow us to have multiple accounts with multiple tokens. I created a bash script that will automatically convert the add on builder app and move it into a Gitlab repository. Halfway into the script, it pops that error due to a placeholder being somewhere in the Global Account Settings. I am using the username as the holder of the account ID and the password as the holder for the bearer token. From Add On Builder, is there a way to change the username and password entities from placeholder?

@TTony5
To provide a more accurate response, additional context is needed regarding where username value is stored. Is it stored in a configuration file? If so, it can likely be retrieved using the same method as other field values.
In the absence of more details, here's a potential solution based on common patterns:
The common pattern is we allow users to create account with user-provided account name

but we don't allow to change the name during update

it can be achieved for any field with
"options": {
    "disableonEdit": true
},

@TTony5, have you tried changing the placeholder attributes in your AOB add-on's globalConfig, replace that text with help and then running the ucc-gen build command?


Using this model for labelling, how is metric calculated

The metric in this project seems to be calculated for depth, but the model predicts a disparity map. Does this metric need to be modified?

Hi, this numerical calculation function is used for metric depth predictions.

I understand that it is used for depth metric calculations, however the model outputs the inverse of depth

Hi, this numerical calculation function is used for metric depth predictions.

I understand that it is used for depth metric calculations, however the model outputs the inverse of depth


Add suspended annotations

Closes BE part of https://github.com/weaveworks/weave-gitops-enterprise/issues/3546

What changed?
Add suspended-by and suspended-comment annotations to objects being suspended
Remove suspended-by and suspended-comment annotations from objects being resumed

Why was this change made?
To log who/what performed the suspending action on the resource

How was this change implemented?
Adding the annotations needed indicating suspended-by and suspended-comment that could possibly include extra details regarding the suspension

How did you validate the change?

unit tests
manually check annotations returned in objects suspended

Release notes

Documentation Changes

Lets add this little snipped to the makefile and run it to fix the ci lint job
https://github.com/weaveworks/weave-gitops/pull/4005/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R145-R148


Repo Description Doesn't Link to Docs

Can we change the repo description to include a link to the docs just like we do for PyFolio and AlphaLens? I always expect it to be there but have to scroll down and find it in the readme.
http://www.zipline.io/

Done!


DRILL-5917: Ban org.json:json library in Drill

@arina-ielchiieva Please review

@vrozov when I have deployed Drill with your changes on test cluster, Drill start up failed with the following error:
2017-11-13 01:30:12,3367 ERROR JniCommon fs/client/fileclient/cc/jni_MapRClient.cc:616 Thread: 26996 Mismatch found for java and native libraries java build version <IP_ADDRESS>680GA, native build version <IP_ADDRESS>680.GA java patch vserion $Id: mapr-version: <IP_ADDRESS>680GA 44680:b0ba7dcefd80b9aaf39f05f3, native patch version $Id: mapr-version: <IP_ADDRESS>680.GA 44680:b0ba7dcefd80b9aaf39f05f
2017-11-13 01:30:12,3368 ERROR JniCommon fs/client/fileclient/cc/jni_MapRClient.cc:626 Thread: 26996 Client initialization failed.
Exception in thread "main" org.apache.drill.exec.exception.DrillbitStartupException: Failure during initial startup of Drillbit.
	at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:353)
	at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:323)
	at org.apache.drill.exec.server.Drillbit.main(Drillbit.java:319)
Caused by: org.apache.drill.common.exceptions.DrillRuntimeException: Error during udf area creation [/user/root/drill/udf/registry] on file system [maprfs:///]
	at org.apache.drill.common.exceptions.DrillRuntimeException.format(DrillRuntimeException.java:49)
	at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.createArea(RemoteFunctionRegistry.java:277)
	at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.prepareAreas(RemoteFunctionRegistry.java:234)
	at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.init(RemoteFunctionRegistry.java:105)
	at org.apache.drill.exec.server.Drillbit.run(Drillbit.java:167)
	at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:349)
	... 2 more
Caused by: java.io.IOException: Could not create FileClient
	at com.mapr.fs.MapRFileSystem.lookupClient(MapRFileSystem.java:626)
	at com.mapr.fs.MapRFileSystem.lookupClient(MapRFileSystem.java:679)
	at com.mapr.fs.MapRFileSystem.makeDir(MapRFileSystem.java:1239)
	at com.mapr.fs.MapRFileSystem.mkdirs(MapRFileSystem.java:1276)
	at org.apache.hadoop.fs.FileSystem.mkdirs(FileSystem.java:1917)
	at org.apache.drill.exec.expr.fn.registry.RemoteFunctionRegistry.createArea(RemoteFunctionRegistry.java:254)
	... 6 more

Without your changes start up was successful.

@arina-ielchiieva Please attach the full log to JIRA.

@vrozov I have posted all content of drillbit.out. drillbit.log just had information that could not create remote function registry directory.

@arina-ielchiieva Please test with the latest commit. I changed mapr version back to 5.2.1, note that 2.7.0-mapr-1707 is compiled with 5.2.2

@arina-ielchiieva Please test

Test cluster is down for the weekend. You can test it locally, just run {{mvn clean install -Pmapr}}.

I already tested mapr and default profile locally. Once test pass on your cluster, let me know and I'll squash commits.

I see some functional test failures but I don't think they are related, it might be that your branch is not based on the latest master, so +1, LGTM.
@vrozov thanks for making the changes!

rebased to upstream/master and squashed commits.


Response of a get with a http url is nil but using https it succeeds (unit test)

"https://httpbin.org/get" works when doing a get but "http://httpbin.org/get" doesn't (response is nil)

You're likely running into an issue with ATS. Please check Apple's documentation for more details.
These types of questions are best suited for Stack Overflow and tag Alamofire. We use our GitHub project for bug reports and feature requests.
Best of luck! 🍻

From our Contribution Guidelines
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.


Show number of search results

Is your feature request related to a problem? Please describe.
As a user using the search I want to know how many results are found.
Describe the solution you'd like
This is relevant on both web and native and probably for both the normal category search and the city search. Somewhere a number of search results should be shown. Or do you disagree and think the number of search results is not necessary?

Describe alternatives you've considered
None.
Additional context
Relates to #2352.

@steffenkleinle can you tell me what these items are that are shown when no search term has been entered yet?
Is it possible in this case to shoe "most searched" items?

Ok, I think then we don't need to implement it. What was the reason for implementing the number of search results? @steffenkleinle

I think it was somehow related to accessibility/have a better overview. However, if you think it does not make sense from an UI/UX perspective we can also just reject this :)

@steffenkleinle here is the link to the design for web and native.

@steffenkleinle here is the link to the design for web and native.

Looks great, thanks. No comments or requests from my side :)


Load headers immediately

This PR removes the throws MessagingException from getHeader family of methods in the Part interface. Those were necessary because LocalMessage loaded headers lazily from the database, which might have thrown. This exception was problematic because there was no good way to deal with it, and the relevant error handling code did everything but handle the error correctly.
The lazy loading "optimization" itself a remnant of the old database structure, where we had a headers table which kept one row per header, which made this query fairly expensive. At this point, we can just join the header field of the root part in when we load all other data of LocalMessage and be done with it.

Please try to keep pull requests small and focused on one change. For this one 6969120 + d1cae83 would have sufficed.
I realize it might be a bit more work if you make the changes as part of a larger feature. But reviews will be faster and there's less mental context-switching required when reviewing and addressing review comments.

I kept the unit test changes in here because I thought the other changes depended on them (as in, tests failed otherwise). But that's only true for the following commit which isn't in this PR yet. Will try to be more careful :)

:+1: Please rebase and merge.


Unknown block ID crash

crash-2016-05-16_03.08.46-client.txt
Any chance that could be fixed?. Thanks.

@GmanAtheist This crash is caused with UnwrittenFun utils aka CommonFun/WorldTeleporters and has nothing related to mekanism. Try removing them.

Thanks. I think there is a conflict between the Teleporters in Mekanism and [1.7.10] SecurityCraft v1.8.1. Because when I try and link a Camera to the hand-held monitor I get this crash report.  I won't use the cameras in SecurityCraft, a shame because they used to work fine before I installed Mekanism . I am not a fundy at this . Just a gamer. looking for some help. :-)

@GmanAtheist interesting...  I can't help you with this issue as

I am not a fundy at this . Just a gamer.
Sorry.

I am fairly confident that this is not on my end. I've never actually seen a crash like this before.

Thanks for the replies. I can live without the cameras. :-)


Pokegive isnt existing

cannot give doughnutchicken my best friend a mareep without trading :(

Added to default, command is /pokegift


CRITICAL in loader.py/machine_state.py

Description
A CRITICAL error is given with the address mentioned below using the command below:
How to Reproduce
Inputmyth -v4 analyze -1 -a 0x04c4b45aacc60dcbb8e5d09695b95935319f5c76
Output
mythril.mythril.mythril_analyzer [CRITICAL]: Exception occurred, aborting analysis. Please report this issue to the Mythril GitHub page.
Traceback (most recent call last):
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/support/loader.py", line 38, in read_storage
contract_ref = self.storage_cache[contract_address]
KeyError: '0x4c4b45aacc60dcbb8e5d09695b95935319f5c76'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/ethereum/interface/rpc/client.py", line 74, in _call
return response["result"]
KeyError: 'result'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/mythril/mythril_analyzer.py", line 155, in fire_lasers
disable_dependency_pruning=self.disable_dependency_pruning,
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/analysis/symbolic.py", line 163, in init
self.laser.sym_exec(world_state=world_state, target_address=address.value)
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/svm.py", line 144, in sym_exec
self._execute_transactions(symbol_factory.BitVecVal(target_address, 256))
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/svm.py", line 198, in execute_transactions
execute_message_call(self, address)
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/transaction/symbolic.py", line 67, in execute_message_call
laser_evm.exec()
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/svm.py", line 228, in exec
new_states, op_code = self.execute_state(global_state)
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/svm.py", line 286, in execute_state
).evaluate(global_state)
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/instructions.py", line 195, in evaluate
result = instruction_mutator(global_state)
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/instructions.py", line 143, in wrapper
new_global_states = self.call_on_state_copy(func, func_obj, global_state)
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/instructions.py", line 85, in call_on_state_copy
return func(func_obj, global_state_copy)
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/instructions.py", line 1394, in sload
state.stack.append(global_state.environment.active_account.storage[index])
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/state/account.py", line 68, in getitem
index=int(item.value),
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/support/loader.py", line 46, in read_storage
contract_address, position=index, block="latest"
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/ethereum/interface/rpc/base_client.py", line 71, in eth_getStorageAt
return self._call("eth_getStorageAt", [address, hex(position), block])
File "/home/danc2/.local/lib/python3.6/site-packages/mythril/ethereum/interface/rpc/client.py", line 76, in _call
raise BadResponseError(response)
mythril.ethereum.interface.rpc.exceptions.BadResponseError: {'jsonrpc': '2.0', 'id': 1, 'error': {'code': -32602, 'message': 'invalid argument 0: json: cannot unmarshal hex string of odd length into Go value of type common.Address'}}
Expected behavior
Symbolic Execution should run without error(s).

@Danc2050 thanks for the bug report, I am thinking this might be a one time response, can you rerun it and check because I can't reproduce this but am getting a different bug when I ran it.

@norhh Of course.
My apologies, the machine_state.py error occurs in Docker, whereas I still get the loader.py error using the pip3 CLI version:
Traceback (most recent call last):
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/support/loader.py", line 38, in read_storage
    contract_ref = self.storage_cache[contract_address]
KeyError: '0x4c4b45aacc60dcbb8e5d09695b95935319f5c76'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/ethereum/interface/rpc/client.py", line 74, in _call
    return response["result"]
KeyError: 'result'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/mythril/mythril_analyzer.py", line 155, in fire_lasers
    disable_dependency_pruning=self.disable_dependency_pruning,
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/analysis/symbolic.py", line 163, in __init__
    self.laser.sym_exec(world_state=world_state, target_address=address.value)
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/svm.py", line 144, in sym_exec
    self._execute_transactions(symbol_factory.BitVecVal(target_address, 256))
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/svm.py", line 198, in _execute_transactions
    execute_message_call(self, address)
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/transaction/symbolic.py", line 67, in execute_message_call
    laser_evm.exec()
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/svm.py", line 228, in exec
    new_states, op_code = self.execute_state(global_state)
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/svm.py", line 286, in execute_state
    ).evaluate(global_state)
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/instructions.py", line 195, in evaluate
    result = instruction_mutator(global_state)
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/instructions.py", line 143, in wrapper
    new_global_states = self.call_on_state_copy(func, func_obj, global_state)
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/instructions.py", line 85, in call_on_state_copy
    return func(func_obj, global_state_copy)
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/instructions.py", line 1394, in sload_
    state.stack.append(global_state.environment.active_account.storage[index])
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/laser/ethereum/state/account.py", line 68, in __getitem__
    index=int(item.value),
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/support/loader.py", line 46, in read_storage
    contract_address, position=index, block="latest"
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/ethereum/interface/rpc/base_client.py", line 71, in eth_getStorageAt
    return self._call("eth_getStorageAt", [address, hex(position), block])
  File "/home/danc2/.local/lib/python3.6/site-packages/mythril/ethereum/interface/rpc/client.py", line 76, in _call
    raise BadResponseError(response)
mythril.ethereum.interface.rpc.exceptions.BadResponseError: {'jsonrpc': '2.0', 'id': 1, 'error': {'code': -32602, 'message': 'invalid argument 0: json: cannot unmarshal hex string of odd length into Go value of type common.Address'}}

Docker, using the command docker run mythril/myth -v4 analyze -1 -a 0x04c4b45aacc60dcbb8e5d09695b95935319f5c76, I get the machine_state.py error:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/laser/ethereum/state/machine_state.py", line 63, in __getitem__
    return super(MachineStack, self).__getitem__(item)
IndexError: list index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/mythril/mythril_analyzer.py", line 170, in fire_lasers
    custom_modules_directory=self.custom_modules_directory,
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/analysis/symbolic.py", line 179, in __init__
    self.laser.sym_exec(world_state=world_state, target_address=address.value)
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/laser/ethereum/svm.py", line 158, in sym_exec
    self._execute_transactions(symbol_factory.BitVecVal(target_address, 256))
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/laser/ethereum/svm.py", line 212, in _execute_transactions
    execute_message_call(self, address)
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/laser/ethereum/transaction/symbolic.py", line 67, in execute_message_call
    laser_evm.exec()
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/laser/ethereum/svm.py", line 244, in exec
    new_states, op_code = self.execute_state(global_state)
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/laser/ethereum/svm.py", line 294, in execute_state
    self._execute_pre_hook(op_code, global_state)
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/laser/ethereum/svm.py", line 584, in _execute_pre_hook
    hook(global_state)
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/analysis/modules/base.py", line 56, in execute
    self._execute(statespace)
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/analysis/modules/dos.py", line 58, in _execute
    issues = self._analyze_state(state)
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/analysis/modules/dos.py", line 85, in _analyze_state
    target = util.get_concrete_int(state.mstate.stack[-1])
  File "/usr/local/lib/python3.6/dist-packages/mythril-0.21.17-py3.6.egg/mythril/laser/ethereum/state/machine_state.py", line 66, in __getitem__
    "Trying to access a stack element which doesn't exist"
mythril.laser.ethereum.evm_exceptions.StackUnderflowException: Trying to access a stack element which doesn't exist

Yes I got the second error, am currently working on it.
For the first one can you post the output of pip freeze? As the cause for that is a dependency issue.

Here it is...sorry it is a long list.
https://pastebin.com/3CD9SdDX


Create python-package-conda.yml

cc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Upgrade BucketReplicationProps interface to use V2 schema

Is your feature request related to a problem? Please describe.
If I try to programmatically add a replication rule to the ELB access logs bucket created within the log archive account, this error is thrown:
An error occurred (InvalidRequest) when calling the PutBucketReplication operation: Number of distinct destination bucket ARNs cannot exceed 1
This appears to be due to the BucketReplicationProps interface enforcing the V1 schema of the replication configuration. The primary difference between V1 and V2 being that Prefix is replaced by Filter in V2 and that V2 supports RTC.
Describe the feature you'd like
It'd be nice to convert this schema to V2 so it's supportive of use cases where someone needs to replicate their bucket's contents to more than one destination bucket.
Additional context
I'd be more than happy to implement this if accepted! :smiley:

Thank you for reaching out, @StephenBedard and for utilizing the Landing Zone Accelerator on AWS solution. I've gone ahead and filed a feature request for this issue. Should you have any questions or concerns in the meantime, I will keep this issue open for further communication and update you on the status of this issue. Also, as a temporary workaround, you can make use of the customizations layer to set up the replicate rules to multiple S3 destination buckets for the ELB Bucket.


remove committer from node

The commiter is a singleton, and KZG are no longer seriously considered as a candidate for verkle trees. Other parts of the code have already been simplified and only accept IPA-based primitives. The committer is a leftover from the time that it was possible to use both KZG commitments and IPA. It no longer makes sense to maintain this interface, and therefore readability would be improved if all references to it were removed from the code.

done, closing


output UserAgent string verbatim if it cannot be parsed

I signed it!

Thanks for the contribution, could you please make sure your commit matches our convention and add a unit test for this?

Done and done. :ghost:

One more thing, could you please rebase onto the latest canary version please

Done.

Thanks!


fix remove some CHECKs in Tablet::revise_tablet_meta

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Generate Open API 3 definition

Generate to a single OpenAPI Specification file

All models to schemes
All routes
Authentication
Sample data
JSON / YML format

d58bdb42f4bc5539220a66bbafda41d4b7286800


Starting Ghost with missing active theme breaks Design Settings screen

Issue Summary
If the selected active theme does not exist in the filesystem the Design Settings screen errors and is unusable.
The problem occurs because Ghost's API is returning an unexpected state - when requesting a list of themes none of them has the active: true flag.
The preferred solution is to cater for this state in Admin somehow
e.g. have a blank-slate state for the design settings screen indicating that no theme is active and point user to the change-theme screen
Steps to Reproduce

Activate a custom theme
Stop Ghost and delete or rename the custom theme directory
Start Ghost
Try to access the design settings screen

Ghost Version
5.16
Node.js Version
16
How did you install Ghost?
ghost install
Database type
MySQL 8
Browser & OS version
No response
Relevant log / error output
<img width="630" alt="image" src="https://user-images.githubusercontent.com/101513/193117369-f2947482-993a-440e-91c8-6f5cc11a5c37.png">

Code of Conduct

[X] I agree to be friendly and polite to people in this repository

Do i have to have a NodeJS knowledge to work on the issue or having a plain JS knowledge woulod suffice, if it would, i would like to work on the issue.

Hi @Walexero, this is a bug in our Ember.js admin client. If you understand the code enough to fix the issue, then you have enough knowledge... the only person who knows if you have enough knowledge is you!

Hello @ErisDS, i already pulled ghost and trying to work on it locally, i first starteed the server with yarn dev but just gave the home page and didn't provide the theme option, tried signing up locally but doesn't provide options beyond those provided before signing up. Then i stopped the server and ran it with yarn dev:admin but the server errored out with deprecation issues. I had ghost set up with the configuration guidelines on https://ghost.org/docs/install/source/[ghost setup guideline] so is there anything wrong with the setup i did?

Doesn't sound like there was anything wrong with your setup. This is a bug in Ghost's admin panel, which lives at /ghost/.

do you have a way to figure this out so i can work on this open issue

I have updated the source install docs to include the location of Ghost Admin when using yarn dev. I am not sure that there is anything else to figure out?
Beyond framework knowledge there are certain product concepts in Ghost that you need to understand to fix this bug: that Ghost Admin exists and how to access it, and what a theme is and how to use one. This is all covered in our documentation, but Ghost is a large project.

Apart from being able to review the source code for the theme implementation and accessing it through the Ghost Admin to make changes, do you think the code readability would be an issue for me based off the fact you said its a large project and is there a way to get in touch with you whilst making the change implementation

Hi @ErisDS, I took a quick look at this issue and came up with this.

I've added a "none selected" to the change theme button and the section in the middle informing the user that there isn't any active theme. I do have one question though. Should the Brand dropdown in the menu be hidden, or disabled maybe? If not  I'll go ahead and submit a PR.

@kristophesankar sorry for missing this question and thanks for opening a PR 🙏


Restore command consuming only the latest file for each shard

I create an incremental portable backup every 6 hours (with the time range starting 6 hours ago) and all backup files always go into the same directory. Each backup process creates files for all shards existing in the database, though only the last 1 or 2 files contain any data, as the shard duration is 1 day. The data for each shard are therefore split between 4 to 5 files (remaining shard files don't contain any data).
The problem is that (according to the logs) the restore command consumes only the latest file for each shard, ignoring all previous files, so the restored database ends up incomplete (max. 25% of all data).
I believe the problem lies here:
e := shards[sh.ShardID]
if e == nil || sh.LastModified > e.LastModified {
    shards[sh.ShardID] = &sh
}

As you see, the shards mapping can contain only one shard file for each shard ID.
Obviously, it's wrong to assume that each shard can be in just one file in case of incremental backups. Moreover, the backup command always creates shard files for all shards (regardless of the start-end range), so the actual result in the case described above is that only the latest 1 or 2 shards are populated with data, as the latest files for previous shards are empty (while older, non-empty files are ignored).
Instead, the restore command should load all files present in the directory.
This issue makes incremental backups totally useless.
Unfortunately, I'm not familiar with the Go language, not to mention InfluxDB internals :(

This shouldn't be closed.

This is really important.

i have the same problem with you.


Is Creating Patch in SWE Agent means issue is resolves? How do I ensure issue is resolved?

Describe the issue

Optional: Relevant documentation page
No response

no, creating a patch means it thinks it resolved the issue, but sometimes it is wrong. you need to run swe-bench evaluation.

Okayy!!!, How to run this swe-bench evaluation?


Udeploy collector not showing up application metrics

We are not able to see any application metrics in udeploy widget.
UCD collector integration is successful as I am getting the list of applications from UCD.
But once we select the application and save we do not get any data.
We want to configure pipeline view also which we are not able to configure.
UCD version 6.2.4
Hygieia 2.0.5

@ameetsvshah  Follow https://github.com/capitalone/Hygieia/issues/1084 for updates

@ameetsvshah  - Reopen if issue not resolved


Update Get-AdfsGlobalWebContent

This PR removes the ErrorPageSupportEmailText property from the output object, as it does not exist.

Docs Build status updates of commit 23551b5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/adfs/Get-AdfsGlobalWebContent.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@get-itips @tseward
Peer review needed for this PR. Thanks.


[ADD]: LONELY PHANTOM GAME 👾

PR Description 📜

This PR is about adding Lonely Phantom Game

Fixes #1121

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Screenshots 📸

Thank you soo much for contributing to our repository 💗

Thank you @0xabdulkhalid ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@0xabdulkhalid Resolve the conflicts

@Arun9739, Conflicts are resolved!

Thank you  @0xabdulkhalid , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


CAMEL-11954: Renamed HA packages to cluster

Fix for issue: https://issues.apache.org/jira/browse/CAMEL-11954
Refactored 'ha' packages to cluster' in camel-core as well as other associated component.
Changes to spring boot starter components. The tests and build of components work fine.

rebase and conflict resolution seems needed, since git gives warning already..

Still conflicts for the same files after manually resolving them ? My branches are all up to date as i can see.

I am closing this PR as my branch is messed up. Will open a new PR for this.


Update Vagrant to 1.9.3

Update to Vagrant 1.9.3

@tovletoglou thanks for the contribution! I've published this to the galaxy as v1.0.6

Great! Works perfectly.


Add support for docker

Changes

Add support for docker runtime.
Add a yaml to deployment docker runtime daemon.
run bash hack/update-deps.s to update dependencies.

Test result:

Test case: https://github.com/julz/freeze-proxy/blob/master/cmd/sleeptalker/main.go
TODO: add sleep talk case into this repo.

cc @psschwei

kind/feature


⚠ Bofrost.fr has degraded performance

In 539bdef, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1031 ms

Resolved: Bofrost.fr performance has improved in 6eccef5.


Add links to installer files

Add links to installer files
Can you add links to installer files in the README.md ?
Example :
[filename.ext](https://www.github.com/jaquaradro/NBTExplorer/releases/download/version/filename.ext)

Is it that hard to just click the releases thing on the right sidebar


Intero cannot find Paths_* module

Hi there, I hope I'm not missing something obvious.
If I try to load a module that references an auto-generated Paths_* module, I get an error from intero, while stack repl is happy to load it for me.

Is this expected?

Right, a stack build first should sort this. I think this'll be fixed in the next stack release.

Cool, I'll try again with the next version. Right now, a stack build doesn't help unfortunately.

Surprising that a stack build doesn't help.  But yes, the next version of stack will make the --no-build flag unnecessary, because it will only do some initial build steps (run preprocessors and generate file like Paths_*.hs)

@passy The latest release should have this fixed. :clamp:

@chrisdone, I have stack 1.3.2 and intero 0.1.20, and I still have this problem. What should I try?

I just noticed the guy was using stack exec intero. It should be stack ghci --with-ghc intero

@chrisdone @deepfire I was using the emacs integration back then, but wanted to have a more minimal test case - which is why I tried stack exec.

stack ghci calls stack build implicitly creating the Paths_ file. Intero would call it with --no-build, therefore not creating the file. Then @mgsloan made it so it'd generate those things anyway without needing a full build in the recent stack.
So stack exec would never do any of that good setup stuff. And intero itself doesn't look at your package's config, it relies on stack to call it in the right way.

@chrisdone Gotcha! Thanks for the explanation!

@chrisdone, so.. I still feel like I'm in the dark as to how to proceed..

@deepfire Can you provide a test case?


CLICKHOUSE-3800: Enable compilation to llvm by default

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Test passing 00290_shard_aggregation_memory_efficient locally.

something strange with PR commits


vectors.lua

2D vector functions. This is far from complete and should be added to over time, but I've found these functions handy in projects like my "endless breakout" game.
I've also never done a pull request before so if I whiff this, be gentle.  :)

Very useful, thanks so much!


Improve callout to reference match

Improve callout to reference match by removing parentheses often seen in callouts.
As seen in the docs, callouts often include parentheses.
https://grobid.readthedocs.io/en/latest/training/fulltext/
I saw many occasions that these parentheses prevent matching the correct references.
See the red boxes when trying arxiv.org/pdf/1801.01290.pdf

Coverage remained the same at 38.434% when pulling 11cbbcfbae570dd992c491c6f8c93fde3c11a2b8 on mash:callout-to-reference-author-match into ff109685cbb7d15935836af0bc06a505c757e1b7 on kermitt2:master.

Many thanks @mash ! Very good finding, for some reasons I was thinking that the parenthesis were removed somewhere upstream in the process, but you're absolutely right.
In addition to your example PDF, here's the evaluation for callout resolution on the PMC set (1943 PDF - 139,835 reference callouts), branch update_header without your PR:
Precision citation contexts:     81.32
Recall citation contexts:        69.13
fscore citation contexts:        74.73

and with your PR:
Precision citation contexts:     81.41
Recall citation contexts:        69.86
fscore citation contexts:        75.2

Note that there are many references with numerical reference markers in PMC, so the positive impact should be much larger with arXiv for instance.


Audio playing error

Get the following error when trying to play a verse in Chrome 59.0.3071.115

Staging or production?

Production

So, the issue is with Adblock Plus. If you have Adblock Plus installed, then it will block the audio files. I haven't seen this before on other sites, but if I am having this issue, I am sure others are as well. Perhaps there is a workaround to this.

@ahmedre ^^

can you run the javascript console and add the error message you're getting when you try to play using Adblock Plus so that we can know where the actual issue is?

We could definitely do that! Let's add that ask an issue

@ahmedre the first issue is what the JavaScript console produces.

Is this Issue still open ??
I've installed Adblock plus and it's working like charm. Either on staging or production.

if it's fixed, just close it then.

Would you matter to check it now ?

Trying to play Surah al-Fatiha ...
Same issue running on Chrome:
raven.min.js:2 Audioplayer mounted but no file available
a.(anonymous function) @ raven.min.js:2

Firefox has the same errors. Here's something extra:

Salam brothers, I'm closing this. Issue have been fixed, but staging build are failing. Preparing for production build, and need to clear the fixed issues. They're scary :)


Bugfix/Datarace in CMsgSubscriber Destruction

simplified logic in message subscriber to avoid data races in destruction phase (proven with applied test from Kerstin)
Pull request type

Please check the type of change your PR introduces:

[X] Bugfix

What is the current behavior?
Message subscriber crash while destruction based on data race when message callback is under heavy use.
Issue Number: #701
What is the new behavior?
No more crashing by simplified callback deactivation logic based on one class member only instead checking additional "active" boolean.

@rex-schilasky please take a look. It's the threadsafe way to protect all accesses to the member callback function with a std::mutex. However, I kept the lock to only accessing the pointer, e.g. to prevent deadlock situations.
Also I test was added that causes a crash in the current master implementation.
If we decide to merge, it should be sherry-picked to release branches.


Crashlytics

What about crashlytics? Will it work with this library implementation?

Yes, you need to invoke crashlytics, or other crash reporter, after AppCrash:

    AppCrash.init(this);
    Crashlytics.start(this);


cmake doesn't install anything

Description
There are no install instructions in the code so there is no install target for make.
Environment:

OS: FreeBSD 13.1
Python version: 3.9

Hi @yurivict , there are instructions for using cmake to run the tests. Otherwise this is intended to be used a header only library.

@arcondello  Header-only libraries should also be installed. Packages are created for them and then used to build other packages.

The include folder contents should probably be installed into include/minorminer.

Yuri,
The person who wrote the CMake files is no longer a contributor to this repo, and that's not my area of expertise.  If you're able to contribute an installation recipe, I'll be willing to maintain it.

Ok, I will submit a PR for this.


[Release 2.0.0]  Support for celluloid 0.18

Summary

Added support for celluloid 0.18

Changelog

The server and the client supporto also a log_level option to set the logging level
When a client publishes to a channel where there are no subscribers the server will save those messages in the registry and will send them as soon as a client registers to that channel, afterwards those messages are deleted.
Currently those messages are saved in memory.

Known Issues:

Does not work on Ruby 3.0.0 due to some errors with celluloid/io . Need to investigate that further

Coverage increased (+4.02%) to 78.223% when pulling bdb8b969d4c768de44707ab61629e98175436eec on brada/compatibility-with-latest-celluloid into e5558257c04e553b49e08ce27c130d572ada210d on master.

Coverage increased (+4.02%) to 78.223% when pulling bdb8b969d4c768de44707ab61629e98175436eec on brada/compatibility-with-latest-celluloid into e5558257c04e553b49e08ce27c130d572ada210d on master.

Coverage increased (+4.02%) to 78.223% when pulling bdb8b969d4c768de44707ab61629e98175436eec on brada/compatibility-with-latest-celluloid into e5558257c04e553b49e08ce27c130d572ada210d on master.

Coverage increased (+4.02%) to 78.223% when pulling bdb8b969d4c768de44707ab61629e98175436eec on brada/compatibility-with-latest-celluloid into e5558257c04e553b49e08ce27c130d572ada210d on master.


Weird atomic CSS class generating issues depending on render mode

Description
I'm testing out VPS with 2 atomic CSS frameworks: Tailwind CSS, and UnoCSS. Neither of them work 100%. Behavior depends on the rendering mode of the page. Follow the reproduction steps below along with the linked minimal reproduction to see the issues.
Minimal Reproduction
https://github.com/AaronBeaudoin/vps-issue-atomic-css
First, The Setup
npm install postcss autoprefixer tailwindcss unocss
Tailwind CSS Files
// postcss.config.js

module.exports = {
  plugins: {
    tailwindcss: {},
    autoprefixer: {}
  }
};

// tailwind.config.js

module.exports = {
  mode: "jit",
  content: [
    "./pages/**/*.{vue,js}",
    "./renderer/_default.page.server.js"
  ]
};

/* pages/index.css */

@tailwind base;
@tailwind components;
@tailwind utilities;

UnoCSS Plugin Config
// vite.config.js

import { defineConfig } from "vite";
import VitePluginUnoCSS from "unocss/vite";

export default defineConfig({
  plugins: [
    ...
    VitePluginUnoCSS({
      presets: [],
      rules: [
        [
          // Lets you do `bg-red`, `bg-blue`, etc...
          /^bg-([a-z]+)$/,
          match => ({ "background-color": match[1] })
        ]
      ]
    })
  ]
});

_default.page
// _default.page.server.js

import "/pages/index.css";
import "uno.css";
...

// _default.page.client.js

import "/pages/index.css";
import "uno.css";
...

I import in both, because I wanted to try and make sure that my issue isn't coming from the stylesheet no being available on one side or the other (server vs client).
The Actual Page

<template>

tailwind

unocss

</template>

Reproduction Steps
SSR Mode
No issues! Everything works fine. 🎉
SPA Mode
Change index.page.vue to index.page.client.vue and restart the dev server. (Any CSS that was generated so far seems to be cached, so you need to do a full server restart to clear things out.)
Now, first of all, HMR doesn't work in SPA mode, but we already know that from https://github.com/vitejs/vite/issues/9341.
But aside from that, this is what I'm seeing:

On the initial server start, both elements get a blue background color no problem.
Change blue for both elements to red and save. Refresh the page in the browser (since HMR is broken right now).
Only UnoCSS updates properly. Tailwind CSS doesn't seem to be able to update for some reason. The element class updated, but Tailwind CSS doesn't seem to be able to recognize the change and create CSS for the new class.
Restart the dev server. Now both elements have a red background color as expected.

HTML-Only Mode
Change index.page.vue to index.page.server.vue and restart the dev server again.

On the initial server start, both elements get a red background color no problem.
Change red for both elements to green and save.
Only Tailwind CSS updates properly this time. UnoCSS doesn't seem to be able to update for some reason. The element class updated, but UnoCSS doesn't seem to be able to recognize the change and create CSS for the new class.
Refresh the page in the browser. Notice that didn't change anything.
Restart the dev server. Now both elements have a green background color as expected.

Error Stack
No response

I guess these issues are unrelated to vps?

You're probably right. A main goal of mine right now is to figure out how to create minimal reproductions for these sorts of things without VPS so I can totally rule it out.

Note that even if the presence of vps is causing problems, it still is most likely a problem on their side.

Made an issue for UnoCSS: https://github.com/unocss/unocss/issues/1351
Still have yet to make one for Tailwind CSS. I think I might just wait till the client HMR thing is figured out so that issue can be demonstrated in isolation a little bit better.

I guess we can close this in the meantime.
Let's re-open if it turns out to be a vps problem.


virt-handler metrics trigger API DoS with list calls to virtualmachineinstances

https://github.com/kubevirt/kubevirt/blob/d7a7d09b7c7ef9f67c9a9a598d7f6d2ec083cb57/pkg/util/lookup/lookup.go#L19
Prometheus metrics collection triggers a list call to virtualmachineinstances from each virt-handler. This can hit the Kubernetes API server pretty hard in larger clusters. Perhaps we can find a more efficient way to reflect this information. Further, this list call doesn't set a resourceVersion, which hits the etcd backend rather than allowing API cache to serve the request.
The call to API server, triggered by prometheus metrics collection, looks like this:
{
  "kind": "Event",
  "apiVersion": "audit.k8s.io/v1",
  "level": "Request",
  "auditID": "d6328a34-0e8f-4d94-bbf4-3825b8b01199",
  "stage": "ResponseComplete",
  "requestURI": "/apis/kubevirt.io/v1alpha3/virtualmachineinstances?labelSelector=kubevirt.io%2FnodeName+in+%28node01%29",
  "verb": "list",
  "user": {
    "username": "system:serviceaccount:kubevirt:kubevirt-handler",
    "uid": "702c7284-9432-4c07-b505-a32422a4fcfe",
    "groups": [
      "system:serviceaccounts",
      "system:serviceaccounts:kubevirt",
      "system:authenticated"
    ]
  },
  "sourceIPs": [
    "<IP_ADDRESS>"
  ],
  "userAgent": "virt-handler/v0.0.0 (linux/amd64) kubernetes/$Format",
  "objectRef": {
    "resource": "virtualmachineinstances",
    "apiGroup": "kubevirt.io",
    "apiVersion": "v1alpha3"
  },
  "responseStatus": {
    "metadata": {},
    "code": 200
  },
  "requestReceivedTimestamp": "2021-03-10T19:39:32.179339Z",
  "stageTimestamp": "2021-03-10T19:39:32.182319Z",
  "annotations": {
    "authorization.k8s.io/decision": "allow",
    "authorization.k8s.io/reason": "RBAC: allowed by ClusterRoleBinding \"kubevirt-handler\" of ClusterRole \"kubevirt-handler\" to ServiceAccount \"kubevirt-handler/kubevirt\""
  }
}

Prometheus metrics collection triggers a list call to virtualmachineinstances from each virt-handler.

Thanks for pointing this out. I find it frustrating that this got merged. We probably need to figure out a way to begin locking down when new k8s api server calls occur so it's harder for things like this to inadvertently slip in.
For this issue, i bet the fix is fairly simple.
all the VMIs on the each node are already cached in this virt-handler informer, https://github.com/kubevirt/kubevirt/blob/fab812ce1eda7d853c11a79deb4a34f3285fca3e/cmd/virt-handler/virt-handler.go#L218
we probably just need to pass that informer to the Prometheus collector here, https://github.com/kubevirt/kubevirt/blob/fab812ce1eda7d853c11a79deb4a34f3285fca3e/cmd/virt-handler/virt-handler.go#L308 and then use that for the lookup.

Thanks for pointing this out. I find it frustrating that this got merged. We probably need to figure out a way to begin locking down when new k8s api server calls occur so it's harder for things like this to inadvertently slip in.

Yes frustrating. It slipped through on a PR which I reviewed in 2019 already. The whole lookup package is an issue. For instance the node controller there also lists all VMIs from the apiserver since that change. I will take care of the node controller when #5269 is merged.


publish a complex example

Hi,
That would be nice that you provide with Hugo a complex example involving all hugo functionalities in one single project, a theme and contents.
Regards,
Laurent

We do that already.  It's the Hugo website: https://github.com/gohugoio/hugoDocs

Thanks  moorereason. Following your link and instructions:
git clone https://github.com/gohugoio/hugoDocs.git
cd hugoDocs/
hugo server
Error: Unable to locate config file or config directory. Perhaps you need to create a new site.
       Run `hugo help new` for details.


Level blockout

Finished the level blockout for the playtest level and finished the primitive assets for it.

Resolved merge commit issue: variable randVal changed to spawnLocPrefab in develop, functionality is (mostly) identical


docker-compose up error

Specs

Leon version: 1.0.0-beta.4
OS (or browser) version: mac os big sur
Node.js version: v14.5.0
npm run docker:dev output:

 Could not find ffmpeg executable, tried "/app/node_modules/@ffmpeg-installer/linux-x64/ffmpeg", "/app/node_modules/@ffmpeg-installer/ffmpeg/node_modules/@ffmpeg-installer/linux-x64/ffmpeg" and "/app/node_modules/@ffmpeg-installer/linux-x64/ffmpeg"

Expected Behavior
Actual Behavior
How Do We Reproduce?

npm install. (Run this under mac os host)
npm run docker:dev

Extra (like a sample repo to reproduce the issue, etc.)
The possible reason is ffmpeg is lack of linux-x64 version when run npm install in mac os. And docker is using linux-x64 version. @Divlo

Thanks for your report! @arlyxiao
I think you should not do npm install on the host, do it after, first do npm run docker:dev then npm install if you want to have all the auto-completion from your IDE etc.
I'm pretty sure, Docker need to have the linux executable, not the macOS one.
Could you please try with npm run docker:run (production environement) ?

'npm run docker:run' works.   It would output:
leon-ai    | ><EMAIL_ADDRESS>train /app
leon-ai    | > babel-node scripts/run-train.js "expressions"
leon-ai    |
leon-ai    | sh: babel-node: not found
leon-ai    | npm ERR! code ELIFECYCLE
leon-ai    | npm ERR! syscall spawn
leon-ai    | npm ERR! file sh
leon-ai    | npm ERR! errno ENOENT
leon-ai    | npm ERR<EMAIL_ADDRESS>train: `babel-node scripts/run-train.js "expressions"`
leon-ai    | npm ERR! spawn ENOENT
leon-ai    | npm ERR!
leon-ai    | npm ERR! Failed at the<EMAIL_ADDRESS>train script.
leon-ai    | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
leon-ai    | npm WARN Local package.json exists, but node_modules missing, did you mean to install?
leon-ai    |
leon-ai    | npm ERR! A complete log of this run can be found in:
leon-ai    | npm ERR!     /root/.npm/_logs/2021-04-20T03_26_09_246Z-debug.log
leon-ai    | npm ERR! code ELIFECYCLE
leon-ai    | npm ERR! errno 1
leon-ai    | npm ERR<EMAIL_ADDRESS>dev:server: `npm run train expressions && cross-env LEON_NODE_ENV=development nodemon --watch server ./server/src/index.js --ignore server/src/tmp/ --exec babel-node "&&" "npm" "run" "dev:app"`
leon-ai    | npm ERR! Exit status 1
leon-ai    | npm ERR!
leon-ai    | npm ERR! Failed at the<EMAIL_ADDRESS>dev:server script.
leon-ai    | npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
leon-ai    | npm WARN Local package.json exists, but node_modules missing, did you mean to install?
leon-ai    |
leon-ai    | npm ERR!  It would output the ffmpeg path error above.

Right, we'll need to investigate! I'll look into that. :smile:

I think, I fixed the issue! :smile:
Could you please try:
git checkout chore/fix-docker-dev
npm run docker:dev

If it doesn't work straightforward, could you please try removing the leon images and containers, before trying again.
Thank you for your help! @arlyxiao

Unfortunately, reopening, because it seems like my PR didn't fixed the issue.
We would appreciate a lot your help to fix the issue, feel free to open a PR if you think you have a working solution, thanks!

Fixed the issue
https://github.com/leon-ai/leon/pull/242/files


Streams closed while data still in buffer

Hey,  Not sure if this is desired behaviour or not, but I've run into an issue where the data in the buffer doesn't ever get written.
As per example:
$connector->create('www.google.com', 80)->then(function (React\Stream\Stream $stream) {
    $stream->write('...');
    $stream->close();
});

From what I can see, the $stream->write() appends the data to the buffer and doesn't do a lot else at that point; it waits for the next tick of the event loop to come and write the buffer out.  Because of that, when you follow it immediately with $stream->close(), it closes it and flushes the buffer.
As I said, I'm not sure if this is expected behaviour, and I can see benefits in both.  As a work around, I'm doing this:
$connector->create('www.google.com', 80)->then(function (Stream $stream) use ($template) {
    $stream->write('…');
    $stream->getBuffer()->on('full-drain', function() use($stream) {
        $stream->close();
    });
});

Is this as simple as a doc update?

Is this as simple as a doc update?

Yes, this is expected behavior and hence a rather pointless example :-)
Using end() instead of close() would likely resolve this here, I suppose?
Other than that, we should probably add some documentation to the stream component and link there. What do you think?

Yeah, that actually makes sense once reading the stream documentation.  It all totally makes sense to function the way it does, so I guess just updating the example would be the best thing to do.
Thanks for clarifying this for me.

Thanks for reporting back @calcinai.
The documentation has now been updated via #46, so I suppose this can be closed :+1:


TIL section parsing support

I know it is not yet supported, but would be nice to have the issue at least to track the progress (if there will be any)

https://github.com/aerosoul94/tilutil

There is some information about types (from the IDA runtime point of view though) is available in IDA Pro import extension in GHIDRA.

Fixed since https://github.com/williballenthin/python-idb/commit/c192b72ae5e81414d0218f8e28a73c83bacaf050
Is anyone has an issue with that code or a missing feature - please open a separate bug.


Fix: Binaries paths

:tada: This PR is included in version 3.6.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Can't edit Admin account for Misskey

stop.voring.me (general)
therian.club (focused)
furry.band (focused)

@ThatOneCalculator I have updated furry.band as they were already in our database, however if you wanna add your instance you can follow the automated adding system. https://furryfediverse.org/add-instance let me know if the automated adding of the instances fails. We cannot just add instances to the system as we want to ensure we have consent of the instance owner.

Gotcha. Seems like I can't edit this textbox?

yike yep you caught an oversight of mine let me fix that real quick

@ThatOneCalculator should be patched now, you may need to clear your cache to get the updated page.

I got this immediately after hitting "submit"

Also, there's a typo. It should be "Administrator", not "Administator".

an env variable was off throwing me off... but it should be all fixed and your spelling mistake you noticed fixed please try again I was able to successfully add my test server

Just woke up and I got another error ^^;

That is because in your screenshot you have "mastodon" as the API selected

Ah 🤦


chore(doc): display some debug info when inspecting the HTML of a widget

Fix #403

That's awesome, does it only toggle this mode when you click on "view html"? Or is it always activated

That's awesome, does it only toggle this mode when you click on "view html"? Or is it always activated

Yes, only when you toggle -> I think it was more convenient.

Yes it's more convenient but I wonder if that's easy to understand. Actually I think that's not easy to understand at all because you trigger a tab on the right and it triggers a behavior also on the left so you could discover this by trying only (= luck).
What about a checkbox/button on the right of "widget display" in your screenshot that says "view underlying css classes" or "toggle css debug" "view class names"?

Yes good point, not yet sure where to put it to look nice.

OK, I've another proposal: always highlight the first level once the View HTML button is clicked, I think it's the best of the 2 worlds:

Yes should be sufficient, if at some point it still not obvious we will think again


Creates project from URL when press ENTER

Fixes #2437

Could you please use "Closes #2437" or "Fixes #2437" instead of "solves #2437" as the latter is not detected by GitHub?

@wetneb Yes, sure. Sorry, I'll keep this thing in mind for next time.

@wetneb I agree with you. Let me try that. Thanks for the suggestion.


[21.05] qemu: fix CVE-2021-3527, CVE-2021-3682, CVE-2021-3713

Backport patches for 6.0.0
https://nvd.nist.gov/vuln/detail/CVE-2021-3527
https://nvd.nist.gov/vuln/detail/CVE-2021-3682
https://nvd.nist.gov/vuln/detail/CVE-2021-3713

Motivation for this change
For https://github.com/NixOS/nixpkgs/issues/143003
Includes https://github.com/NixOS/nixpkgs/pull/143296
Closes https://github.com/NixOS/nixpkgs/issues/138694
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Patches look sensible to me:

CVE-2021-3527 - patches two files that have barely changed since 6.0.0, stack to heap change shouldn't really have a visible effect beyond the function.
CVE-2021-3682 - again barely any changes since 6.0.0, looks like a fairly obvious oversight in the original function.
CVE-2021-3713 - zero changes to this file since 6.0.0, changes only reference fairly locally scoped definitions or symbols which are already used similarly elsewhere in the function.

Still building for darwin.


class reference proofreading

Hi 🙂
I was looking for something utterly specific in the docs earlier and saw a few typos/weird things. So I made a dirty script to send all the XML content through my local LanguageTool server and quickly proofread the errors that made the most sense fixing.
I'm not used to PR-ing the class reference, so I hope I didn't make a mistake in the process of updating this.

I was looking for something utterly specific in the docs earlier and saw a few typos/weird things. So I made a dirty script to send all the XML content through my local LanguageTool server and quickly proofread the errors that made the most sense fixing.

I've been there too :eyes:

Thanks!

As a side note, one thing LanguageTool suggested I didn't end up doing (I wasn't sure it was necessary) was removing "of" in every construction like "inside/outside of the ...". Here's the rule details.
E.g.

This container fits controls inside of the delimited area.
Clips the area outside of the region.
Attenuates the frequencies inside of a range around the AudioEffectFilter.cutoff_hz and cuts frequencies outside of this band.

Cherry-picked for 3.3.

@akien-mga The documentation here is incorrect in 3.3 and 3.x, as the default FOV is 70, but it says 75 in this cherry-picked doc.

@akien-mga The documentation here is incorrect in 3.3 and 3.x, as the default FOV is 70, but it says 75 in this cherry-picked doc.

PR welcome to fix it :)


Use voluptuous for LiFX

Description:
Migration of the configuration check to voluptuous.
Related issue (if applicable): fixes 127528299
Example entry for configuration.yaml (if applicable):
light:
  platform: lifx
  server: <IP_ADDRESS>
  broadcast: <IP_ADDRESS>

@bradsk88, would be nice if you could take a look at the changes and run a quick test. Thanks.

🐬

I only vaguely remember mentioning something about voluptuous.
I can tell you that the tox tests run and hass works fine on localhost.
Can't remember what the original problem was.

Thanks for your feedback.


Added function type support (pipermerriam/web3.py) Issue #164

These changes add support for the function type in solidity (ethereum/solidity#1122).

FYI, test failure is unrelated to this PR.  I'll handle addressing it.

Can you get a few tests added for this new type.
https://github.com/pipermerriam/ethereum-abi-utils/blob/master/tests/encoding/test_encode_single.py

ping

closed in favor of #15


Link in README.md not working

Link from "Slider Events" section is broken https://github.com/angular-slider/angularjs-slider#slider-events
I believe broken link should be to http://angular-slider.github.io/angularjs-slider/index.html

Thanks


How can I change the timerDelayInMilliseconds in HystrixCollapserProperties dynamically, when the program is running?

Hi

when I change the timerDelayInMilliseconds by using the constructor，it seems not work。
so, can I change the timerDelayInMilliseconds in HystrixCollapserProperties dynamically, when the program is running? how to do?
Thanks!

You can try the below command :-
ConfigurationManager.getConfigInstance().setProperty("hystrix.collapser.ShopCollapseCommand.timerDelayInMilliseconds", 100);


Value String Coercion In .hmset Is Too Naive: '[object Object]' Ends Up Being the Value

Maybe I am generally using this incorrectly, but I have objects that I am storing that I do not necessarily know the structure of. Sometimes these objects have values that are themselves objects. It appears that these values have .toString() called on them, making the value '[object Object]' when actually stored.
I am currently traversing the object myself before using hmset, and forcing the objects to be string representations of the object, but I feels too one-offed and I feel this tool should probably take care of that for me...

@JohnPostlethwait I'm having the same issue so I'm probably wrong as well: what were you doing wrong?

@unlucio hmset will accept objects that do not have any nested objects and arrays.


Fix: Implement ToOwned correctly

To do that, we would need to update <leon::Tempalte as Clone>::clone to call .to_owned on Cow::Borrowed, which is a breaking change and would need documentation.

Also, leon::Item can only contains & str, so even if we fix the implementation of <leon::Template as Clone>::clone, the leon::Template::items would still contains reference, not String.
To fix that, it has to be changed to Cow<'_, str>.
I didn't remember why we didn't use Cow<'_, str> @passcod .
https://github.com/cargo-bins/leon/blob/2209aba032962b6dd44261c9045bf13e8337aada/crates/leon/src/template.rs#L12

Probably just missed it when refactoring

Got it, I would just change it to Cow<'_, str> then


It looks like this is using the connecter webparts (controls that ship with SharePoint).  Unfortunately, that is outside the scope of this issues list.  You will need to open a ticket with support.

It looks like this is using the connecter webparts (controls that ship with SharePoint).  Unfortunately, that is outside the scope of this issues list.  You will need to open a ticket with support.
Originally posted by @patmill in https://github.com/SharePoint/sp-dev-docs/issues/7483#issuecomment-970612710
I accept that this is off-topic. However, none of the support options from within Sharepoint work. There is not a support link and the Microsoft support page wiki link is broken.

Hi, as mentioned on the other thread, you would need to open a support ticket with Microsoft. Have you tried this method?
https://docs.microsoft.com/en-us/microsoft-365/business-video/get-help-support?view=o365-worldwide

I have now, thank you


unable to run elastalert

My working environment

Mac OS (Terminal)
python 2.7.10

I just downloaded "elastalert" zip file and extracted them and executed with following command

$ sudo pip install -e .
move to ../elastalert-master/elastalert
$ python -m elastalert.py --verbose --rule ../example_rules/example_frequency.yaml --config ../config.yaml.example

However, it prints out following error.
/System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python: No module named elastalert.py

Is this because my python version(2.7.10) is too low? should I upgrade it to 3.7.2?
need your kind advices
Thank you

Thank you after following the document(https://elastalert.readthedocs.io/en/latest/running_elastalert.html#running-elastalert)
I was able to install elastalert successfully.


Update deck.gl whats new doc

Background

Per review discussion

Change List

What's New

@ibgreen , I just pushed a small change to this PR, please pull the latest if making any changes.

@ibgreen , I just pushed a small change to this PR, please pull the latest if making any changes.

@1chandu so sorry didn't see this. I just rebased and pushed :(
I'll land and maybe you can rebase and open a new PR?


There is no definition of "cudnnGetErrorString"

Hi,
when I try to compile the purine code with "make" command, it show there is no definition of "cudnnGetErrorString", please check

Are you using cudnn R1 version? In this version, the function has not been defined, you need to implement it in cuda.hpp/cuda.cpp. In purine2, cudnn R2 has been used.

hi, this problem is solved by using cudnn v2 rc3, the cudnn R1 version has no definition of "cudnnGetErrorString"


Impersonate Chrome

Implementation of curl-impersonate that impersonates Chrome.
The changes that were required to make this work:

Compiling curl with BoringSSL instead of OpenSSL. This was way easier than I had thought and basically works by replacing OpenSSL with BoringSSL.
Some TLS extensions were enabled, others were disabled and some were modified.
The order of HTTP/2 headers that Curl sent was messed up. It was modified to match Chrome's.

The resulting curl-impersonate has identical TLS handshake and identical HTTP/1.1 & HTTP/2.0 headers to Chrome.
This is still work in progress.
TODO:

[x] Currently the build is in a separate file Dockerfile.chrome. Either merge the Dockerfiles or put them in separate directories as separate builds.
[x] The patch files should live in separate directories as well. The patches in this PR should not be applied to the Firefox version of curl-impersonate as they will mess it up.

I finally got a chance to test this, and it works like a charm. You, my friend, are brilliant.
Thank you for your work. Also bravo on the docker build process. So easy.

Thank you, I'm glad you find it useful.


Add main I2C sensor Retry-loop

This is a result of having retries in the drivers/wrappers, and a desire for them to be faster (more interrupt like). We are therefore removing unnecessary delays while waiting to retry one sensor multiple times, and instead retrying the entire suite of sensors up to three times before failing that periodic reading event.
I was trying to add another driver with a long retry time, and this work was the result instead. See #564
This is unfinished, as currently it will evaluate all sensors again, instead only failing ones need be retried.
There will be a follow up PR to remove any unnecessary retries during I2C sensor data reads once this is merged.

@brentru ready for review


Mercator projection not supported in nested simulations

Hi,
CMAQ docs says:

CMAQ can use any of the four map projections defined for WRF. The four map projection coordinate systems are regular latitude-longitude geographic, Lambert conformal conic, Mercator, and Polar stereographic

but I noticed that mercator projection is actually not supported by modules ICON and BCON with  the m3conc option.
In order to implement this projection:

IOAPI v3.2 is required (because 3.1 has a bug that affects directly to this matter)
Add these lines to files PREP/bcon/src/common/lat_lon.F and  PREP/icon/src/common/lat_lon.F at line 115:

      ELSE IF ( GDTYP .EQ. EQMGRD3 ) THEN  ! Equatorial Mercator

         IF ( .NOT. SETEQM( SNGL( P_ALP ),        !  first, initialize
     &                      SNGL( P_BET ),        !  for EQM2LL()
     &                      SNGL( P_GAM ),
     &                      SNGL( XCENT ),
     &                      SNGL( YCENT ) ) ) THEN
            MSG = 'Eq Mercator projection setup error for CTM CONC file'
            CALL M3EXIT( PNAME, 0, 0, MSG, 2 )
         END IF

         X = X0 + FLOAT( COL ) * SNGL( XCELL )
         Y = Y0 + FLOAT( ROW ) * SNGL( YCELL )
         IF ( .NOT. EQM2LL( X, Y, LON, LAT ) ) THEN
            MSG = 'Eq Mercator conversion error for CTM CONC file'
            CALL M3EXIT( PNAME, 0, 0, MSG, 2 )
         END IF

Thanks
Pedro

Hi Pedro,
Thank you for alerting us to this issue in the documentation and for sharing a solution for ICON and BCON.  We will update the documentation to reflect that we currently only support three map projections.  Note that in addition to ICON and BCON, there are other PREP and POST tools in the CMAQ repository that also do not currently support Mercator map projections.  We will consider adding support for Mercator in a future release.


Endianness and Sign report for PCM Matroska tracks

Signed-off-by: Maxime Gervais<EMAIL_ADDRESS>

Some issues with it:

if BitDepth is before CodecID, crash
it may have some differences between the File_Pcm instance creation and the cast part due to different test.

I reworked it in https://github.com/MediaArea/MediaInfoLib/pull/709.


Pf microg gmscore

This PR allows replacing /e/'s GmsCore with the version from MicroG Download page, and  adds some information about GsmCore to the README
Tested in a clean custom build for lilac. Seems to work. There is a known bug with registering apps for Cloud messaging /e/ issue #3365, which exists also in the official MicroG version

thx @petefoth :tada:


List all suitable/available zones while creating networks

Currently, network creation forms (shared,L2,isolated) only lists one zone:
L2:

Shared:

Isolated:

Post Fix:
L2:

Shared:

Isolated:

However, from the deploy instance view - we still restrict the zone during network creation to the zone specified in the deployment wizard:

@blueorangutan package

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/873 (JID-3692)


[PE-D][Tester A] Extra semicolon at the end of the sentence for Deleting a resource

Labels: type.DocumentationBug severity.VeryLow
original: Merrickneo/ped#4

inavlid


The DepthwiseConv2dNative() function ignores the dilations argument

Hi!
I am using Tensorflow v1.7.0.
I am invoking the DepthwiseConv2dNative() function with a dilations argument that is [1, 2, 2, 1]. Despite of this, the dilations value is being ignored.
Looking at the tensorflow source code, it is evident that the dilations argument is presumably being disregarded (depthwise_conv_op.cc, around line 400) in both CUDNN and non-CUDNN scenarios. Yet, there is no mention of this in the documentation.
Thanks!

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

Hi!
Apologies for not including the required information to begin with. I am using TensorFlow under Windows 10, in CPU mode. Bazel version is 0.14.1.
While I am fully aware of the fact that Windows is not an officially supported platform, reading through the TensorFlow source code creates an impression that this is a yet-to-be-implemented feature. Still, the documentation bears no trace of this (to the contrary, the "dilations" argument is even being described in detail; see: https://www.tensorflow.org/api_docs/cc/class/tensorflow/ops/depthwise-conv2d-native).
Have a look at line 400 of depthwise_conv_op.cc (under tensorflow/tensorflow/core/kernels/):
  // TODO(yangzihao): Send in arbitrary dilation rates after the dilated
  // conv is supported.
  launcher_(context, use_cudnn_, cudnn_use_autotune_, input,
            reshaped_filter, /*row_dilation=*/1, /*col_dilation=*/1,
            stride_, stride_, padding_, output, data_format_);

While this particular block pertains to CUDNN, there is no trace of dilation information being passed in the CPU variant, the code for which is right below that block.
Thanks!

Nagging Assignee @chsigg: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I have found the same problem， with tf.nn.depthwise_conv2d_native（）， the parameter 'dilations' do not take effect，dilations=[1, 2, 2, 1] will have the same result with dilations=[1, 1, 1, 1].  @PavelPr  had pointed the bug in tensorflow's  implementation.

@chsigg @yzhwang -- are there current plans to add dilation parameters to DepthwiseCov2dNative? If not, should the docs be updated?

Nagging Assignee @chsigg: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

This definitely sounds like a problem that can reduce the accuracy of your models, but it might go unnoticed by some.
If the cudnn path does not support the dilated convolution in this case yet, maybe it would be a good idea to just use the native path if the dilation rate is > 1?

Nagging Assignee @chsigg: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @chsigg: It has been 45 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @chsigg: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @chsigg: It has been 90 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Meet the same issue. Any update? If this can not be supported in short term, I think at least the doc should be updated first, it took me much time to figure out there is a misalignment between doc and real behavior.

@PavelPr  Is this still an issue with the latest TF1.13 and TF2.0? Thanks!

Closing due to lack of recent activity, but please let me know if I'm mistaken. Since this issue is old at this point, please reopen the issue if it still occurs when tried with the latest version of Tensorflow. Thank you.

@jvishnuvardhan The issue still exists in v1.13.1.

@weichiche Could you create new issue with the issue details and context. Thanks!

I just stumbled on this thread while looking at tf.nn.depthwise_conv2d. I assume tf.nn.depthwise_conv2d is a wrapper for tensorflow::ops::DepthwiseConv2dNative, and I will share my experiments in hope it is useful for someone.
I'm on Linux, testing on CPU mode with tensorflow 1.14.0(https://storage.googleapis.com/tensorflow/linux/cpu/tensorflow-1.14.0-cp37-cp37m-linux_x86_64.whl), and dilation seems to work. Below is a self-contained script for testing.
%reload_ext autoreload
%autoreload 2
%matplotlib inline

import matplotlib.pyplot as plt
import numpy as np

import tensorflow as tf
tf.enable_eager_execution()

x = np.random.rand(32,64,3);x.shape

plt.figure()
plt.title('X')
plt.imshow(x)

num_channels = 3
box_filter = np.ones([2, 2, 3, 1]) / 4
dilation_size = 2

y_with_dilation = tf.nn.depthwise_conv2d(
    np.expand_dims(x, axis=0),
    box_filter,  # [filter_height, filter_width, in_channels, out_channels]
    dilations=[dilation_size, dilation_size],
    strides=[1,1,1,1],
    padding="VALID",   # No padding
    data_format="NHWC"
)

y_without_dilation = tf.nn.depthwise_conv2d(
    np.expand_dims(x, axis=0),
    box_filter,  # [filter_height, filter_width, in_channels, out_channels]
    strides=[1,1,1,1],
    padding="VALID",   # No padding
    data_format="NHWC"
)

def plot_y(y, title=''):
    y = tf.squeeze(y)
    plt.figure()
    plt.title(title)
    plt.imshow(y)

plot_y(y_with_dilation, 'With dilation')
plot_y(y_without_dilation, 'Without dilation')

Please don't ask me why I'm using a uniform filter :)


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210323093512251 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210323093512251 to main with localized lcls

Pull Request Test Coverage Report for Build 679092551

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.001%) to 43.371%

Totals

Change from base Build 677581894:
-0.001%

Covered Lines:
25457

Relevant Lines:
53546

💛  - Coveralls


frontend pod CrashLoopBackOff(storage-plugin container) with msg="unknown flag: --trace-server-enable"

Steps to reproduce
Deploy following by steps in https://github.com/kubewharf/kelemetry/blob/a832d2856bccdbdedefbe2a437d05c709e22f5bd/docs/DEPLOY.md
#helm install kelemetry oci://ghcr.io/kubewharf/kelemetry-chart --values values.yaml
Expected behavior
All pods and svc run up fine and tracing data can be browsed from UI.
Actual behavior
frontend pod CrashLoopBackOff, check from log
kubectl logs kelemetry-frontend-75c566859f-mw44x -c storage-plugin
time="2023-07-17T13:59:40Z" level=error msg="unknown flag: --trace-server-enable"
run the docker image, no "--trace-server-enable"" in kelemetry:0.1.0
#docker run -d ghcr.io/kubewharf/kelemetry:0.1.0
af6e0f708046cbae26858de58df97a56442fabe8490646cc0aa61689564ac8d4
#docker exec -it af6e0f708046cbae26858de58df97a56442fabe8490646cc0aa61689564ac8d4 sh
kelemetry --help
...
--span-cache-local-cleanup-frequency duration                          frequency to collect garbage from span cache (default 30m0s)
--tracer string                                                        implementation of tracer. Possible values are ["otel"]. (default "otel")
--tracer-otel-endpoint string                                          otel endpoint (default "<IP_ADDRESS>:4317")
--tracer-otel-insecure                                                 allow insecure otel connections
--tracer-otel-resource-attributes stringToString                       otel resource service attributes (default [service.version=dev])
--usage string
As with the frontend failed, not sure if need to switch to  kelemetry:0.2.0? but how about other components, kelemetry-consumer, kelemetry-informers. [tried with 0.2.0, informers pod CrashLoopBackOff with
kubectl logs kelemetry-informers-84c49bc575-hs5dg
time="2023-07-18T01:30:12Z" level=error msg="unknown flag: --diff-cache-use-old-rv"]
and for the kelemetry-collector, already one issue https://github.com/kubewharf/kelemetry/issues/122 for the version 1.42, it does not listen to 4317.  What version shall we use to get the tracing work?
there are also flood of such message in the "kelemetry-collector" pod.
{"level":"info","ts":1689602342.3532155,"caller":"grpc@v1.55.0/server.go:932","msg":"[core][Server #6] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams received bogus greeting from client: \"\\x16\\x03\\x01\\x01\\x1b\\x01\\x00\\x01\\x17\\x03\\x03a\\x9a\\xd36\\x81\\x87\\xba\\xb0\\xdb\\xe8\\xdcp\\xa9\""","system":"grpc","grpc_log":true}
{"level":"info","ts":1689602359.958463,"caller":"grpc@v1.55.0/server.go:932","msg":"[core][Server #6] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams received bogus greeting from client: \"\\x16\\x03\\x01\\x01\\x1b\\x01\\x00\\x01\\x17\\x03\\x03c\\uf448\\xb2$\\xf7\\x02\\x1f\\xee\\x13\\xe9\\x87\""","system":"grpc","grpc_log":true}
{"level":"info","ts":1689602562.2759514,"caller":"grpc@v1.55.0/server.go:932","msg":"[core][Server #6] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams received bogus greeting from client: \"\\x16\\x03\\x01\\x01\\x1b\\x01\\x00\\x01\\x17\\x03\\x03Z\\xfb\\x05A=0\\xb0mi\\x12\\x1a\\xfa\\xd6\""","system":"grpc","grpc_log":true}
{"level":"info","ts":1689602634.1497142,"caller":"grpc@v1.55.0/server.go:932","msg":"[core][Server #6] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams received bogus greeting from client: \"\\x16\\x03\\x01\\x01\\x1b\\x01\\x00\\x01\\x17\\x03\\x03PO\\xb9#%W־\\x03\\x1a\\xac\\t\\x9a\""","system":"grpc","grpc_log":true}
{"level":"info","ts":1689602778.7651076,"caller":"grpc@v1.55.0/server.go:932","msg":"[core][Server #6] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams received bogus greeting from client: \"\\x16\\x03\\x01\\x01\\x1b\\x01\\x00\\x01\\x17\\x03\\x03e\\xd6z4\\xccLq\\xb286\\xb4\\x02z\""","system":"grpc","grpc_log":true}
{"level":"info","ts":1689602918.8066566,"caller":"grpc@v1.55.0/server.go:932","msg":"[core][Server #6] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams received bogus greeting from client: \"\\x16\\x03\\x01\\x01\\x1b\\x01\\x00\\x01\\x17\\x03\\x03\\xb7\\x98\\xea\\xe3\\xd0\\x12\\xb2@\\xe7\\xc7S\\xe0\\x19\""","system":"grpc","grpc_log":true}
{"level":"info","ts":1689602953.5312855,"caller":"grpc@v1.55.0/server.go:932","msg":"[core][Server #6] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams received bogus greeting from client: \"\\x16\\x03\\x01\\x01\\x1b\\x01\\x00\\x01\\x17\\x03\\x03K\\x15\\x01\\xf9\\x1cϋ\\xfb\\xc6xr7\\xe2\""","system":"grpc","grpc_log":true}
{"level":"info","ts":1689603063.8368163,"caller":"grpc@v1.55.0/server.go:932","msg":"[core][Server #6] grpc: Server.Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams received bogus greeting from client: \"\\x16\\x03\\x01\\x01\\x1b\\x01\\x00\\x01\\x17\\x03\\x03\\xa9J\\x9bȨު\\xa8\\xb6\\x1bP\\xca\\xee\""","system":"grpc","grpc_log":true}
Kelemetry version
0.1.0
Environment
Kubernetes version :1.24.15
Jaeger version: 1.4.2

Hi, please use version 0.2.0 instead.

Already tried 0.2.0, kubectl logs kelemetry-informers-84c49bc575-hs5dg
time="2023-07-18T01:30:12Z" level=error msg="unknown flag: --diff-cache-use-old-rv"], manually disable this flag, though the pods are up and running. flood of message "...Serve failed to create ServerTransport: connection error: desc = "transport: http2Server.HandleStreams received bogus greeting from client.." in the "kelemetry-collector" pod as showed as above.

我也遇到了这个错误，当替换为0.2.0时，kelemetry-informer报错time="2023-07-18T13:05:58Z" level=error msg="unknown flag: --diff-cache-use-old-rv"


Influxdb 1.2. Collectd service.  Multiple data sources for measurement don't work correctly.

Bug report
System info: Influxdb 1.2, collectd-4.10
Steps to reproduce:

enable collectd service in influxdb
enable df plugin in collectd, configure collectd to send data to influx collectd service
check measurements created in influxdb
use types.db with:
df                      used:GAUGE:0:1125899906842623, free:GAUGE:0:1125899906842623

Expected behavior:
Expected is to have one measurement df with values stored in fileds named "used" and "free".
At least it's how it's described on mailing list:
https://mailman.verplant.org/pipermail/collectd/2015-June/006551.html
Actual behavior:
Two separate measurements
df_used, df_free created
Additional info:
I've tried changing the ds names in types.db from used to df_used, the result was creation of measurement:
df_df_used
I suspect that data source is simply concatenated to the measurement name instead of beeing used as filed name in case of multiple values returned from measurement.

@cinek810 I've spent some time reading the influxdb collectd service code. I think what is happening is by design - good or bad.
The construction of the InfluxDB measurement name is done here:
https://github.com/influxdata/influxdb/blob/master/services/collectd/service.go#L395 . This, as you guessed, is concatenating collectd's ValueList.Identifier.Plugin field and ValueList.DSName for each value in the ValueList.
Identifier.Plugin is from collectd here: https://github.com/collectd/go-collectd/blob/master/api/main.go#L47
DSName is from collected here: https://github.com/collectd/go-collectd/blob/master/api/main.go#L82
Changing this behavior seems pretty straight forward but would require a configuration flag to opt in to the new measurement name encoding.

Since in new versions of influxdb we don't have joins it would be desired..
because now it's for example impossible to use collectd standard df plugin
to display percent of drive used..
2017-05-31 21:00 GMT+02:00 Ryan Betts<EMAIL_ADDRESS>
@cinek810 https://github.com/cinek810 I've spent some time reading the
influxdb collectd service code. I think what is happening is by design -
good or bad.
The construction of the InfluxDB measurement name is done here:
https://github.com/influxdata/influxdb/blob/master/services/
collectd/service.go#L395 . This, as you guessed, is concatenating
collectd's ValueList.Identifier.Plugin field and ValueList.DSName for
each value in the ValueList.
Identifier.Plugin is from collectd here: https://github.com/collectd/
go-collectd/blob/master/api/main.go#L47
DSName is from collected here: https://github.com/collectd/
go-collectd/blob/master/api/main.go#L82
Changing this behavior seems pretty straight forward but would require a
configuration flag to opt in to the new measurement name encoding.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/influxdata/influxdb/issues/8426#issuecomment-305284503,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGSwFwK5_V8k0O9SS8rTOCunX_vT4jnuks5r_biygaJpZM4NmJ2i
.

Resolved by https://github.com/influxdata/influxdb/pull/8523


[fix][gws][board] initially set other site's groups on replying

Coverage decreased (-0.06%) to 84.472% when pulling 206dea06333cc9501ae7e17488f7e9fc35669709 on fix-gws-board-reply into 5e5bf6d80d529f65ff81010db252b81f9b29cfa5 on master.


What's the difference between sdata & webdataset?

Why not use the raw webdataset class?

import webdataset as wds
Create a webdataset object
dataset = wds.WebDataset("/path/to/data")
Load the data
data = dataset.load()
Process the data
...
The raw webdataset class is not recommended for use because it is not as efficient as the other classes in the webdataset library.

webdataset format is efficient for training large models and related data is bundled together in this format. where sdata is in simple text format or json format, each line contains a data sample, good for training small or medium models.


facts: refact and optimize memory consumption

there's no need to run this task on all nodes.
This uses too much memory for nothing.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1856981
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

jenkins test centos-container-all_daemons

jenkins test centos-container-all_daemons

jenkins test centos-container-lvm_osds