Validation not working on textarea of dynamic form.

I am trying to get validate to work with a form I create. I create the form dynamically (on the fly) and when they click the "Add" button I run validate.
	var formValid = false;
    if (planningEventValidators[this.eventType].valid()) {
        console.log("Valid form");
        formValid = true;
    }
    return formValid;

I have the following code(below) where I initialize the validate. And below the code is a screen capture from the browser of the Console, I run the validate manually and it returns true, even though admissionDetails is blank/empty.
I am using CHROME.
Help Please!
J
planningEventValidators[this.eventType] = $("#" + this.eventType + "FormId").validate({
	errorContainer: $validateErrorBox,
	errorLabelContainer: $("ul", $validateErrorBox),
	wrapper: 'li',
    errorClass: "error",
    validClass: "",
    rules: {
        dayCount: {
            required: true,
            number: true
        },
        iaLocation: {
            required: true
        },
        icuBed: {
        },
        admissionDetails: {
            required: true,
            minlength: 5
        }
    },
    // Custom Error Message (default is Field is required)
    messages: {
        iaLocation: "Location selection is a required",
        admissionDetails: "Admission Details are required",
        icuBed: "ICU Bed selection is required",
    }
});

Below is screen capture from browser where I run valid() manually (for testing). As you can see from the console.log, admissionDetails value is empty, when I run the valid() method it returns true even though it has a rule for admissionDetails(required/minlenght 5).

EDIT
I got it at least somewhat working and (after stripping down a lot of code) got it up on Fiddle.
It currently shows the error container but I have to manually call submit on the form, where as when I have it as a static popup, it calls it when I close the dialog box. Also it does not display the actual error message until you click somewhere in the background of the popup.
Steps to reproduce

Load Fiddle Example
Click  "Admit" button, which brings up a popup with two fields.
Click "Add Event" button, which should throw error because Admission details is empty.

Any thoughts on this????

Hi @bchdubois
I did a quick look at your code, you demo sometimes is working as you described and sometimes I don't see any error message. But, here are my thoughts so far:

If I'm not wrong, you're initializing the validator in your code after opening your dialog (using dialog("open")) which I tend to think that the validator will not be initialized as the form doesn't exist on DOM yet due to the modal is not rendered yet. If that's the case, you should call $("form selector").validate(options) after the modal is shown. To do that, listen to dialogopen event and initialize the validator inside the event handler.
I also see that you try to initialize the plugin inside the click handler of your button. You don't need to do that. The plugin is design to be initialized only once, any subsequent call will only return the created plugin instance on your form.

I will try to do another look on your code when I have some free time.

I had a form using jquery-validation on a section of a page and decided to move it into a Jquery UI Dialog widget.  As soon as I did that validation stopped working.  Moving the .validate() call to inside a dialogopen hook did not fix it.  I think there is something else about these inputs once inside a dialog  that at the time .valid() is called your code assume it can just ignore/filter them.

This issue is fairly old and there hasn't been much activity on it.
Closing, but please ping me to re-open it if it still occurs.

I am facing this issue.
I am using the rich text editor ckeditor5. I have defines rules as required and minlength to textarea but it is not working. can you please let me know if this query is already answered or still this is an isssue.

@vishwakarmanikhil  I was never able to successfully solve this issue and we ended up writing custom validation to check and then push them onto errors list.

ok, thank you @bchdubois


IPC code writes data with insufficient alignment

Describe the bug
FileWriter and StreamWriter should ensure that the data is written with appropriate alignment such that arrays can be used without copying to a more-aligned buffer.
In particular, as of Rust 1.77.0 and LLVM 18, i128 now has a 16-byte alignment requirement even on x86 (ARM always had this requirement), i.e. std::mem::align_of::<i128> == 16. So Decimal128Arrays must be aligned to a 16-byte boundary when serialized into an IPC buffer. The pad_to_8 used everywhere in the IPC code causes it to pad insufficiently.
This prevents readers of the IPC data generated by this crate from doing true zero-copy reads (e.g. mmapping) since the data may be insufficiently aligned.
On some platforms, SIMD may also be significantly slower if the beginning of the IPC block isn't aligned to a 16-, 32-, or 64- byte boundary (as discussed in the Arrow spec document).
To Reproduce
See the test test_decimal128_alignment8_is_unaligned in PR #5554 - the fact that this test throws an error shows that alignment is not currently respected.
Expected behavior
See the test test_decimal128_alignment16 in PR #5554 - increasing alignment should allow us to do "true" zero-copy reads.
Additional context
IpcWriteOptions already has an "alignment" field but it is not being respected throughout the IPC code.
Related PRs and issues:

https://github.com/apache/arrow-rs/pull/2884
https://github.com/apache/arrow-rs/commit/32c9dea9c3003e114b9981cae15acdfc8448971b
https://github.com/apache/arrow-rs/issues/2882
https://github.com/apache/arrow-rs/pull/2883

label_issue.py automatically added labels {'arrow'} from #5554

label_issue.py automatically added labels {'arrow-flight'} from #5554


Create an official, Automated Build image on Docker Hub

Docker Hub allows you to create Automated Builds from source: https://docs.docker.com/docker-hub/builds/
It would add another packaging/distribution/installation method, whose buildings would be triggered automatically on each commit. It also allows to create different image tags from git tags & branches.
Also, documentation could easily include a canonical docker run statement to quickly spin up a Dataux instance with just a single command.
By making the image build via an AB, you give the resulting image verifiability and auditability. Also, the build is fully automatic. You can have the latest image tag build from HEAD and individual image tags from git's release tags.
Some people avoid non-verifiable (manually uploaded) images due to security & traceability reasons.
Docker search command clearly displays AB when listing images (mine is shown):
$ docker search dataux
NAME                      DESCRIPTION     STARS     OFFICIAL   AUTOMATED
pataquets/dataux          dataux          0                    [OK]

Just a free Docker Hub account and a quick setup would do. Ping me if you need help.

thanks for the ticket and great write up, yes i agree, I will see if i can get this soon!

@araddon : I'm watching the repo and seeing lots of commits. An AB would help people test them easier. Let me know if you need any help to move this forward. It's all done under 10min.
Just register a free account at Docker Hub, link your Github and follow the wizard under 'Create->Automated build' top right button.
I would like to help by doing it myself, but even registering the account, I have no writer Github access (nor should I).

Thanks, I had to get some of the dependencies cleaned up to run an automated build:

Removed test packages that should not have been imported. https://github.com/dataux/dataux/pull/66
found a wrong dependency lock.  https://github.com/dataux/dataux/commit/2e78073167b52fd1d83f8e7c0d37ab4bd0b9f1a1#diff-836546cc53507f6b2d581088903b1785
created docker-compose files for test emulators.  https://github.com/dataux/dataux/blob/master/docker-compose.yml

Am trying to find a place to host the CI testing that will work with those emulators.

And, although not yet CI/Automated build, do have script to upload docker images, and binary releases now.
https://github.com/dataux/dataux/blob/master/release.sh

@araddon : Any news on this? I see lots of changes happening, and would like to test them (easily).

If you're concerned of the AB not working right away, it can be worked out later, and I can even be of some help.

@araddon : The public image on the readme file doesn't work:
$ docker pull gcr.io/dataux-io/dataux:latest
Error response from daemon: unauthorized: You don't have the needed permissions to perform this operation, and you may have invalid credentials. To authenticate your request, follow the steps in: https://cloud.google.com/container-registry/docs/advanced-authentication

Is the image URL correct? Maybe the image is private? I would suggest you to set up an AB on Docker Hub, since GCP might inccur in charges for outgoing bandwidth.


refactor(lint): modularize json linters

refactor linters using json to use "from_json"
still wip
prep for "guard-collection"

I think can output_fmt rename to parser ?

Ready for review.
Code actually works very nicely. All linters have been refactored - only 20 lines max!
Seeking advice in file guard/lint.lua - how to organize functions from_regex and from_json and not repeating code.
Should the file be extracted to lua/guard/util.lua? Or is it fine and wait for guard-collection before putting too much work in?

The unified conversion interface looks good. But git log can be a bit confusing
Better to use git rebase.

I'm bad at git lol. Closing this and re-opening with cleaner git history.


[easy] Fix the backref relationship type hints

Description
The can_see* attributes should be on Group and not on User.
Test plan
checked the relationship declarations

are you missing a migration? Or how are these associations working?

These associations are created by the backref calls (see https://github.com/chanzuckerberg/aspen/blob/ca6dc1e3a59a410a79c1aec39ea9ae8514f59266/src/py/aspen/database/models/cansee.py#L40-L48)

These are only type hints.

oh i see


[JENKINS-31886] Added support for Selenium Html Report plugin

https://issues.jenkins-ci.org/browse/JENKINS-31886

Already merged from master, added a releases notes entry and squashed those commits to a single one.
Thanks


v0.1.10

Current dependencies on/for this PR:

main

PR #84   👈

This stack of pull requests is managed by Graphite.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (45ff12c) 94.00% compared to head (c063811) 94.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   94.00%   94.00%
=======================================
  Files          14       14
  Lines         200      200
=======================================
  Hits          188      188
  Misses         12       12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update 0001-getting-started.md

Thank you for contributing, but your PR appears empty.

@Githubbiograf Hi Michael, please let me know if you need any help from us. Otherwise I'm going to close this in couple days if there is no update.


A JavaScript error occurred in the main process

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:  1.80.1
OS Version:  Windows Server 2016 (OS build 1439..6167)

Steps to Reproduce:

Launch Visual Studio Code with elevated privileges
Receive error message "A JavaScript error occurred in the main process"
Re-installing the application fixes the problem but this is happening almost every weekend.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Reinstalling fixes indicates you might have an extension that is messing with the VSCode sources, can you run with a fresh --extensions-dir to confirm this.

I did have the same issue when I was using 1.80.1. Wanted to open a recently open project, the windod opened but without any UI. Wanted to restart VSCode and figured I could update at the same time, so went to Help -> Install update. It took too long to update, so closed VSCode completely and got this error while trying to restart

Thanks, couldn't find it as I was searching for A JavaScript error occurred in the main process (which is not written in this issue)

Any ideas how to fix this? We are facing the same situation with multiple users since updating to 1.80.0 Reinstall helps only temporary. After some time the issue re-occurs. The issue mentioned by @deepak1556 does not have any updates since 02/2022

Hey @deepak1556, this issue might need further attention.
@asuarez24, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Feature Request: Output residual statistics and evaluation measures

Feature Description
I propose the integration of residual statistics and evaluation measures for regression models in the polars-ols package. This feature would include metrics such as R-squared, RMSE (Root Mean Square Error), MAE (Mean Absolute Error), as well as residual statistics such as skew and kurtosis, essential tools for diagnosing the fit of regression models.
Motivation
Currently, after fitting a regression model using polars-ols, users need to manually calculate performance metrics or use external libraries to evaluate model fit. Especially in the case of rolling ols, this becomes extremely inefficient to do after the coefficients have already been calculated. Integrating these metrics directly into polars-ols would streamline the analysis process, making it more efficient and accessible, especially for new users or those integrating polars into their data science workflows.
Suggested Implementation
Similarly to coefficients, residual statistics and evaluation measures can be output as structs. User's could indicate which of these they want included, by passing a list of "modes" or flag arguments.
Benefits
This feature would significantly enhance the utility of polars-ols by providing critical tools for model validation and diagnostics directly within the library. It would improve user experience, reduce dependency on other libraries for model evaluation, and could increase adoption of polars-ols in academic and professional settings.
Happy to discuss this proposal further and contribute to testing.

Hi @stout-yeoman, thanks for the feature suggestion - think adding some main statistics metrics like these makes sense.
We can add residual statistics like R2 / RMSE / etc and also add core statistics on features like t-values + standard errors / confidence bands which might be handy too. The output would be a struct with descriptive field names and either float or list values depending on if it’s a residual or feature statistic (so similar to what you hinted at).
This shouldn’t be too bad to write with the caveat that for L1 and non-negative models the statistics produced would need to be taken as approximate as they’d violate some assumptions which a  straightforward OLS/WLS/Ridge implementation of closed form statistics makes. Can perhaps log a warning for those. For rolling models inverse(XTX) needs to be updated per time step which can be done efficiently but would require a little more effort. perhaps a good starting point is to implement for non moving window models first, then update the rolling/recursive models next (or just implement residual statistics only for those).
I expect to be bandwidth constrained over the next days, but I will try to have a go at this feature request when possible and share with you a draft pull request which you could opine on / test locally

Hi @stout-yeoman, apologies for the delay,  latest version should support this for OLS / WLS / Ridge

Implementation: https://github.com/azmyrajab/polars_ols/blob/main/src/statistics.rs
Example: https://github.com/azmyrajab/polars_ols/blob/main/tests/test_ols.py#L998 (tested against statsmodels)
Currently supports MSE, MAE, R2, standard errors, t-values, and p-values
It returns a struct with scalars for 'residual statistics' (MSE, MAE, R2) and list[f64] values for 'feature statistics' (standard errors, tvalues, pvalues). I also output feature names and coefficients for convenience
Use mode="statistics" to get these out, similar to 'coefficients'. The overhead of producing incremental statistics is fairly small so we just return all of them

statistics = (df.select(
   pl.col("y").least_squares.ols(pl.col("x1", "x2"), mode="statistics", add_intercept=True)
)
.unnest("statistics")  # results stored in a nested series by default
.explode(["feature_names", "coefficients", "standard_errors", "t_values", "p_values"])
)

print(statistics)

shape: (3, 8)
┌─────────┬──────────┬─────────┬──────────────┬──────────────┬─────────────┬───────────┬───────────┐
│ r2      ┆ mae      ┆ mse     ┆ feature_name ┆ coefficients ┆ standard_er ┆ t_values  ┆ p_values  │
│ ---     ┆ ---      ┆ ---     ┆ s            ┆ ---          ┆ rors        ┆ ---       ┆ ---       │
│ f64     ┆ f64      ┆ f64     ┆ ---          ┆ f64          ┆ ---         ┆ f64       ┆ f64       │
│         ┆          ┆         ┆ str          ┆              ┆ f64         ┆           ┆           │
╞═════════╪══════════╪═════════╪══════════════╪══════════════╪═════════════╪═══════════╪═══════════╡
│ 0.99631 ┆ 0.061732 ┆ 0.00794 ┆ x1           ┆ 0.977375     ┆ 0.037286    ┆ 26.212765 ┆ 3.0095e-8 │
│ 0.99631 ┆ 0.061732 ┆ 0.00794 ┆ x2           ┆ 0.987413     ┆ 0.037321    ┆ 26.457169 ┆ 2.8218e-8 │
│ 0.99631 ┆ 0.061732 ┆ 0.00794 ┆ const        ┆ 0.000757     ┆ 0.037474    ┆ 0.02021   ┆ 0.98444   │
└─────────┴──────────┴─────────┴──────────────┴──────────────┴─────────────┴───────────┴───────────┘

hi @azmyrajab , how to calculate these statistics on a rolling window ?

would something like this work? Ie normal polars  rolling applied with the polars ols statistic function. It should still be fast
https://github.com/azmyrajab/polars_ols/issues/23#issuecomment-2308908438


Build errors with Xcode 7.0.1 and Swift 2

Not sure if anybody else got the same error, but, building the latest code of Example project, my Xcode complained "'array' is unavailable: please construct an Array from your lazy sequence: Array(...)" on line 55 and 86 in ViewController.swift.
After changing them to:
let key: AnyObject = Array(self.json.dictionaryValue.keys)[row]
the build passed. Any other thought?

Just fixed in master.
Thx for pointing it out.
:beers:


Reorganize workspace

Moves the windows crate into a common libs folder beside the other library crates. This just simplifies the repo structure and makes it easier to work with all of the library crates as first-class citizens.

Neat, this indeed seems a lot easier to navigate!


created the branch for submission

In this branch i:

[ ] created for the submission of the capstone project

In this project, I

[ ] built 2 pages home page and an about page and styled them accordingly
[ ] ensured that my website is adaptive to all screen sizes
[ ] Ensured that the home page has a link to the about page and also the about page to the home page
[ ] Ensured that when the mobile screen size has a hamburger menu that displays the mobile menu and also closes when any link is clicked
[ ] The mobile menu has a close button that closes the menu
[ ] The featured speakers is created dynamically in Javascript from my script.js file


Update 1

Welcome to UESTC Open Source Commnunity 👏

Add a issue link after Fix:, if you have created a issue

Fix:

/retest

/hold
/area ci
/assign

/hold cancel


Lenient error handler doesn't always include location information

Describe the issue
Warning messages created without context. Example:
2023-10-17 09:40:44.629 | 10:40:44.629 [hl7v2-receiver-endpoint_hl7v2_in_adt_siu-19] WARN  c.u.fhir.parser.LenientErrorHandler - Resource is missing required element: value
Environment (please complete the following information):

HAPI FHIR Version: 6.8.0, build f33627087f 2023-08-17
OS: Linux

Recommended mod to https://github.com/hapifhir/hapi-fhir/blob/master/hapi-fhir-base/src/main/java/ca/uhn/fhir/parser/LenientErrorHandler.java:
public void missingRequiredElement(IParseLocation theLocation, String theElementName) {
	if (myLogErrors) {
		ourLog.warn("{}Resource is missing required element: {}", describeLocation(theLocation), theElementName);
	}
}

There are other calls to ourLog.warn() that would benefit similarly.


feat: support new DPO data format

What does this PR do ?
This PR makes the dpo dataset use chat format tokens from the model's config yaml instead of hardcoding chat/special tokens in the jsonl data file.
Currently, each datapoint inside a DPO jsonl data file, looks like this:
{
  "prompt": "<extra_id_0>System\n\n<extra_id_1>User\nbacillus subtilus\n<extra_id_1>Assistant\n",
  "chosen_response": "Bacillus ... and industry alike.\n<extra_id_1>",
  "rejected_response": "The Bacillus ... fields of study.\n<extra_id_1>",
  "rejected_reward": 3,
  "chosen_reward": 4
}

With this PR it should be like this (OpenAI list of messages format with no chat/formatting tokens):
{
  "prompt": [
    {
      "role": "system",
      "content": ""
    },
    {
      "role": "user",
      "content": "bacillus subtilus"
    }
  ],
  "chosen_response": {
    "role": "assistant",
    "content": "Bacillus ... and industry alike."
  },
  "rejected_response": {
    "role": "assistant",
    "content": "The Bacillus ... fields of study."
  },
  "chosen_reward": 4,
  "rejected_reward": 3
}

Additionally There is a script added to convert old data files into the new format.
python nemo_aligner/data/nlp/scripts/undo_special_tokens.py <path_to_old_format_dpo_jsonl_file>

A new file will be written in the same location as the old format file.
Changelog

Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"
Pre checks:

[ ] Make sure you read and followed Contributor guidelines
[ ] Did you write any new necessary tests?
[ ] Did you add or update any necessary documentation? Make sure to also update the NeMo Framework User Guide which contains the tutorials

Checklist when contributing a new algorithm

[ ] Does the trainer resume and restore model state all states?
[ ] Does the trainer support all parallelism techniques(PP, TP, DP)?
[ ] Does the trainer support max_steps=-1 and validation?
[ ] Does the trainer only call APIs defined in alignable_interface.py?
[ ] Does the trainer have proper logging?

Additional Information

Related to # (issue)

closing in favor of #403


Add the ability to do inference on images

This is a big task and it is broken down into subtasks:

[x] add react-navigation to the examples/objectdetection project. Familiarize yourself with how to use a native stack navigator and to create screens here
[x] take what is currently in App.tsx and move it to a new screen (react-navigation concept) called Main.tsx
[x] Create a new App.tsx which contains a native stack navigator and two screens, Main and Photo.
[x] Add a button (<Pressable>) to the main screen at the bottom and have the onPress handler navigate to the Photo screen
[x] Create placeholders for photo and settings screens
[ ] Add icons to the tabs - see react-navigation docs
[ ] Create a new photo screen that whenever it is navigated to, prompts the user to pick a photo
[ ] For photo picking, you will use react-native-camera-roll . be sure to follow the instructions to set it up including changing the manifest files to request the appropriate permissions, as we did for accessing the camera.
[ ] Once the user has selected a photo, then do inference on the photo, using the detectImage on the object returned from useObjectDetection().
[ ] render the selected photo, as well as rectangles and a label similar to the camera detection code.

Extra credit: implement the ability to save and share the photo with more buttons.

[ ] You will need to save the file to the camera roll. react-native-camera-roll provides this functionality.
[ ]  This will require you to create an image with the drawn skia elements. See this page for some hints how to do this.
[ ] To implement sharing, use react-native-share

duplcate of #31


Made generateConfig public and switched order of merge

My config requires plugins ordered in a particular order which makes using the preset as it is right now impossible.
import plugin from "./plugin.json" with { type: "json" };

export default defineConfig(merge(
	deckyPlugin(),
	{
		plugins: [
			nodeResolve({ browser: true }),
			codegen.default(),
			mdx({ providerImportSource: '@mdx-js/react' }),
			commonjs(),
			json(),
			typescript(),
			externalGlobals({
				react: 'SP_REACT',
				'react-dom': 'SP_REACTDOM',
				'@decky/ui': 'DFL',
				'@decky/manifest': JSON.stringify(plugin)
			}),
			replace({
				preventAssignment: false,
				'process.env.NODE_ENV': JSON.stringify('production'),
			}),
			importAssets({
				publicPath: `http://<IP_ADDRESS>:1337/plugins/${plugin.name}/`
			})
		],
	}
));

To help with this I propose 2 changes

export the generateConfig method so the file reading can be skipped if the config is already known:

import plugin from "./plugin.json" with { type: "json" };

export default defineConfig(merge(
	generateConfig(plugin),
	...
	)
)

Switch around the order the arguments are provided to mergeAndConcat which means that the provided arguments actually override the base argument.

// Should override input with "test.ts" rather than the default
deckyPlugin({input: "test.ts"});

I didn't add it yet but I would also like an option to provide the config as an object rather than having the deckyPlugin method read the file itself.
-export default function deckyPlugin(options = {}, sourceRoot = ".") {
-    const manifest = JSON.parse(readFileSync(join(sourceRoot, "plugin.json"), "utf-8"));
+export default function deckyPlugin(options = {}, plugin = undefined) {
+    const manifest = plugin || JSON.parse(readFileSync(join(sourceRoot, "plugin.json"), "utf-8"));
    const defaultOptions = generateConfig(manifest);

Ideally we would also change the mergeAndConcat to just merge so I can skip having to do the merge myself. I need to purely overwrite the plugin order not merely add to it. If that were done I could switch to using this package as intended although with the downside that it still reads the file itself.


versions table should be updated on a new release

We have versions table which stores all the latest releases for a component which is used by the wfm api server(prod and staging clusters) and client gets the information from server to see if the update is available.

Updating the versions database on a new component release was implemented in deis/jenkins-jobs#235.


bump version

Change Description
bump version in parent project
API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Nothing to update from a lib perspective; just the example is updated...


Slow memmove() used

Hi,
I was just looking at the code, and I came across this:
https://github.com/OneOfEleven/uv-k5-firmware-custom/blob/024c4bb79de6caba88d65c748b670ad80e3b270c/ui/main.c#L531C9-L531C9
Checking the source and destination buffers, they don't overlap, so memcpy() would be better as memmove() use a third buffer to copy the data from src to dest.
Do you want me to make a PR ?
Cheers.
...
Daniel

You'll find I used memmove elsewhere too (or was doing), I was going to use memcpy but simply decided to keep them all as memmove so as not to include another system function (memcpy) so as to save a teeny bit of flash. Probably makes no difference though.

Okay,
but memcpy() is already used multiple time in the FW, and is faster in the end.
If you want, I can make a pass of small change/optimization (BTW, I'm one of the OpenGD77 dev team).

Yes for sure, change the moves to cpy's and upload :)

I can close this none issue now.
Thanks.


[BUG]: Misalignment of Send Message button in Footer of Menu page

The Send Message Button in Contact Us section in Footer of Menu page is not appropriately aligned.
Here's a screenshot,

Hello @khushi-joshi-05 and @sunny0625
Please assign me this issue under GSSOC'24
Thank You!

Hello @sunny0625  and @khushi-joshi-05
Please assign me this issue under GSSOC'24.


Suggestion for new chart type: table chart

I really like ECharts, thank you for releasing as open source. I'd like to suggest a new chart type: table chart. Google Charts includes a table chart that can be sorted and paged.
Here's a link to the Google Table Chart page: https://developers.google.com/chart/interactive/docs/gallery/table
It would be great if ECharts could create a similar but even better version of Google's table chart.
Thanks.

Thanks for your appreciation.  We won't add table chart in the near future . You can use other alternatives like https://datatables.net/

Ok. Thanks for suggesting datatables.net, I'll check it out.


Copy logical size from ancestor timeline when branching on the last position

See https://neondb.slack.com/archives/C036U0GRMRB/p1657747809541039

Looks like https://github.com/neondatabase/neon/pull/2094 is related. @knizhnik what is the status of the other PR? Should we merge that or wait for @hlinnaka for another review?

Yes. Optimization in https://github.com/neondatabase/neon/pull/2094 may help to reduce logical database size calculation after restart, bot not after branching (because branch is separate timeline and cache of ancestor timeline relations will not help)

Thanks for the clarification. Changes in this patch generally LGTM. However, I don't understand why you need to implement separate Tenant::get_local_timeline_with_load and Tenant::load_local_timeline functions. Why don't just modify the load_local_timeline function.

Yes. Optimization in #2094 may help to reduce logical database size calculation after restart, bot not after branching (because branch is separate timeline and cache of ancestor timeline relations will not help)

Thanks for the clarification. Changes in this patch generally LGTM. However, I don't understand why you need to implement separate Tenant::get_local_timeline_with_load and Tenant::load_local_timeline functions. Why don't just modify the load_local_timeline function?

I have to make load_local_timeline because otherwise  get_local_timeline_with_load is called recursively (because I need to locate ancestor timeline from init_logical_size and it cause error on attempt of recursive exclusive lock of  TENANTS.
y original idea was to completely eliminate load_local_timeline function and call method instead of it. But it requires mute reference to tenant cause Rust error in usage of this function in attach_downloaded_tenant.
I will be pleased if you can suggest way how to solve this issue.

Just tried to run this patch with new test_branch_creation_heavy_write and test_branch_creation_many. The result is slower than/equal to what we have in main. This seems to be because we copy the logical size on load [1] not on branch creation [2]:
[1]:
if ancestor_pgdir.tline.get_last_record_lsn() == inmem_timeline.get_ancestor_lsn() {
     ancestor_logical_size = Some(ancestor_pgdir.get_current_logical_size());
     debug!("Branching: copy ancestor logical size");
 }

[2]: (in branch_timeline function)
// If no start LSN is specified, we branch the new timeline from the source timeline's last record LSN
let start_lsn = start_lsn.unwrap_or_else(|| {
    let lsn = src_timeline.get_last_record_lsn();
    info!("branching timeline {dst} from timeline {src} at last record LSN: {lsn}");
    lsn
});

The if statement in [1] is mostly false because in the test, upon loading the child, the ancestor branch is being updated. IMHO, it's better to move the logical size copy step to on branch creation. With that, we can make sure that the logical size is in sync and use that to construct the child branch.
That said, the loading speedup for child branch should be an improvement. The question is how much?

I do not understand how this patch may slowdown something. It just allows to eliminate some non-incremental calculations of logical database size. Even if check [1] is always false, then... we do exactly the same as main branch. The only added overhead is check itself, for which we need to locate and load ancestor timeline. Can this extra timeline lookup significantly slowdown tests? If so, then there is something wrong with timeline lookup and loading...

I do not understand how this patch may slowdown something. It just allows to eliminate some non-incremental calculations of logical database size. Even if check [1] is always false, then... we do exactly the same as main branch. The only added overhead is check itself, for which we need to locate and load ancestor timeline. Can this extra timeline lookup significantly slowdown tests? If so, then there is something wrong with timeline lookup and loading..

You're right. Parameters of the test are initialized randomly, so maybe that's why there is a difference. I'll need to measure the performance more carefully.

@knizhnik as https://github.com/neondatabase/neon/pull/2139 is merged, should we close this one?

Replaced by #2139


Messer has to have sudo permissions

Description
Messer requires super user permissions. Specifically, it tries to mkdir in the package's folder (which is dumb).
Solution
mkdir in $HOME/.messer or something. This will isolate messer state files from other users of the system
Expected behavior: messer
Actual behavior: sudo messer
Versions
messer - v0.4.0

resolved


Replace yum with dnf

yum(8) is deprecated in favour of dnf(8).
dnf replaced yum as the default package manager in Fedora 22.
RHEL 8/9 uses dnf(8) as default.

I think the changes for Amazon Linux 1 (AMI) and 2 are wrong - they still use yum instead of dnf.  Same for RHEL 7 and its derivatives.
With that, I'm not sure it's a great idea to change yum to dnf in the places that combine all of those like "building from source" page.   I think at least RHEL has a fallback from yum to dnf anyway, does Fedora ship the same symlink or a binary?

RHEL7 is almost EOL'd. I don't even have yum on my Fedora...

AFAIK Amazon Linux 2023 uses dnf but it ain't worth arguing about, I'm sure people know what they should be using anyway, even if copy and pasting won't just work...


Set RoaringBitmapFactory.DEFAULT_COMPRESS_RUN_ON_SERIALIZATION = true

Currently, Roaring bitmaps are only usable in Druid without run compression. We have  RoaringBitmapFactory.DEFAULT_COMPRESS_RUN_ON_SERIALIZATION set to false. I'm all for conservatism, as nobody likes to introduce bugs in complex systems... but in this instance,  I can see no practical reason to leave performance gains on the table.
We have demonstrated at length, on various forums and even in a peer reviewed paper that run compression makes Roaring generally better...

Daniel Lemire, Gregory Ssi-Yan-Kai, Owen Kaser, Consistently faster and smaller compressed bitmaps with Roaring, Software: Practice and Experience, 2016. https://arxiv.org/abs/1603.06549

I realize that one might not want to enable new code paths lightly... but thanks to Gregory's work (and others), RoaringBitmap-0.6.27 has a high test coverage (90%). The run-compression approach is used in other important systems like Apache Kylin and Apache Spark with no bug report (so far... fingers' crossed).
The only problem I can imagine is if one creates a Druid database using the latest code and then tries to open it up with a Druid engine running on old code (e.g., using Roaring 0.4). The old code won't be able to read the run-optimized format... but even then, you will not get corruption and other random mayhem... you'll just get the Roaring library that complains about an unrecognized data format... and bails out. I stress that this would only happen to a user that creates the database using recent code, and then tries to operate it with very old code... That's not something that anyone should ever do in any case.
Anyhow, I think that good performance gains are left on the table with the current code.
This is somewhat related to this PR:
https://github.com/metamx/bytebuffer-collections/pull/35

@lemire, in the upcoming Druid 0.9.2 we actually don't use the default constructor here. We always pass in our own compressRunOnSerialization flag, and Druid's defaults to true (see discussion on https://github.com/druid-io/druid/pull/3228).
Could still be worth changing the default here, but it won't affect Druid.

@gianm
Then feel free to discard my issue as being irrelevant.


Possibility to create candidates and job applications

I have some situations where I want to use this Ruby wrapper to create candidates and job applications. I added methods for those two use cases in this PR.
Feel free to navigate me in the right way when it comes to code convention for your gem :)

Hi there!
Sorry for the delay, I didn't receive any notification about this PR. I'll try and get a review done during tomorrow 😊

@bzf I have updated the pull request with the proposed changes😄. It would be nice to make this API more ActiveRecord-looking in the future, but I agree that it's a big change. I have a new branch now where I am working with the upload-part of the API (creating an upload for a candidate), and for each new create-method in client.rb I feel it just gets more messy.
An inspiration for ActiveRecord-like APIs is ActiveResource: https://github.com/rails/activeresource. Teamtailor::Candidate. new(first_name: "Daniel", ...) would be a cool way to work with the API!🔥

I'll look at doing a release with this after we get #4 in as well. :)


Troubleshooting "undefined is not an object (evaluating 'RNSound.IsAndroid')"

The most common problem developers experience with this library is undefined is not an object (evaluating 'RNSound.IsAndroid').
This is caused by the library's native code not being linked. This is a tooling issue and seems to have a variety of different specific resolutions, depending on your environment.
See these related threads:

#36 (48 comments)
#215 (30 comments)
#128 (16 comments)
#471 (14 comments)

If you're experiencing this issue and want help troubleshooting it, please review those threads first. If you aren't able to resolve the problem, please open a new issue with a link to a project that reproduces the project, information about your environment, and information about the steps you have tried.
Meanwhile, it would be very helpful if someone could collect the troubleshooting advice from those sources, and write it up in the readme.
Note, also reported here:

#57
#352
#446
#541
#567

Any Solution?

cd ios
pod install
fixed my problem

None of these fixed the issue at RN 0.60.4, also manual linking is not working at all.. So what to do?

@losheredos You can open a new issue and fill out the template, and hopefully someone can help you troubleshoot.

@BenjaminLiCN i found this worked after I ran XCode -> clean build folder and then pod install

react-native link react-native-sound not work use react-native 0.61.2

pod install did not solve my problem  react-native 0.61.2

linking and pod installing solved this issue in 61.2 for me in both android and ios

https://stackoverflow.com/questions/57698661/undefined-is-not-an-object-evaluating-rnsound-isandroid
If I get it right, I can never get this to work when my App is made with Expo? I am new to React-native and just did buy a course to learn and wanted to try to implement react-native-sound and keep getting this error. My package.json looks like this: { 	"main": "node_modules/expo/AppEntry.js", 	"scripts": { 		"start": "expo start", 		"android": "expo start --android", 		"ios": "expo start --ios", 		"web": "expo start --web", 		"eject": "expo eject" 	}, 	"dependencies": { 		"expo": "^33.0.0", 		"pod": "^0.9.0", 		"react": "16.8.3", 		"react-dom": "^16.8.6", 		"react-native": "https://github.com/expo/react-native/archive/sdk-33.0.0.tar.gz", 		"react-native-sound": "^0.11.0", 		"react-native-web": "^0.11.4", 		"react-navigation": "^3.11.0" 	}, 	"devDependencies": { 		"babel-preset-expo": "^5.1.1" 	}, 	"private": true }

@VictorVermeulen correct. It's not possible to use any module not supported by Expo when you're using expo, so your issue does not really belong here, and is a natural cause. So yes, if you're using Expo, you need to use the expo-av library (which is very unstable afaik..).
Anyway.
I'm getting this error on Android (not iOS) after linking. I've checked the manual linking steps as well, but it looks right too me (except the manual steps say compile while all other lines in my RN project say implementation  so I'm assuming that the instructions are old..?
Here are screenshots from the changes applied in my project after linking (not displaying iOS here since it works there):

I just set up a brand new project using react-native init followed by yarn install react-native-sound and react-native link react-native-sound and got these changes after linking:
---
 android/app/build.gradle                                     | 1 +
 android/app/src/main/java/com/soundtest/MainApplication.java | 1 +
 android/settings.gradle                                      | 2 ++
 ios/Podfile                                                  | 2 ++
 4 files changed, 6 insertions(+)

diff --git a/android/app/build.gradle b/android/app/build.gradle
index ee614be..23490f4 100644
--- a/android/app/build.gradle
+++ b/android/app/build.gradle
@@ -179,6 +179,7 @@ android {
 }

 dependencies {
+    implementation project(':react-native-sound')
     implementation fileTree(dir: "libs", include: ["*.jar"])
     implementation "com.facebook.react:react-native:+"  // From node_modules

diff --git a/android/app/src/main/java/com/soundtest/MainApplication.java b/android/app/src/main/java/com/soundtest/MainApplication.java
index 4af8585..34d32ee 100644
--- a/android/app/src/main/java/com/soundtest/MainApplication.java
+++ b/android/app/src/main/java/com/soundtest/MainApplication.java
@@ -4,6 +4,7 @@ import android.app.Application;
 import android.content.Context;
 import com.facebook.react.PackageList;
 import com.facebook.react.ReactApplication;
+import com.zmxv.RNSound.RNSoundPackage;
 import com.facebook.react.ReactNativeHost;
 import com.facebook.react.ReactPackage;
 import com.facebook.soloader.SoLoader;
diff --git a/android/settings.gradle b/android/settings.gradle
index d73c393..6a32120 100644
--- a/android/settings.gradle
+++ b/android/settings.gradle
@@ -1,3 +1,5 @@
 rootProject.name = 'soundtest'
+include ':react-native-sound'
+project(':react-native-sound').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-sound/android')
 apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings)
 include ':app'
diff --git a/ios/Podfile b/ios/Podfile
index 48dec66..5afea82 100644
--- a/ios/Podfile
+++ b/ios/Podfile
@@ -34,6 +34,8 @@ target 'soundtest' do
   pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
   pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

+  pod 'RNSound', :path => '../node_modules/react-native-sound'
+
   target 'soundtestTests' do
     inherit! :search_paths
     # Pods for testing
--

As you can see, one change is missing here, namely new RNSoundPackage(), in MainApplication.java,.

I eventually got past this error, but I have no idea how. Probably a combination of rebuilding node_modules, removing old builds, running ./gradlew cleanBuildCache etc.

I had this issue when working with Android Studio and got past it, although my mistake was a pretty amateur one (note that this will be Android Studio specific). In the documentation, the React developers mention that you need to run both
$npx react-native start
and
$npx react-native run-android
to get the app running on your emulator. Well, the second command threw an error for me ("missing tool.jar" - that was a whole other nightmare to figure out), and there is a typo in the documentation that I found confusing. Since I could get my app to show up in the emulator while just running the first command, however, I continued only doing that. Turns out that the "react-native link react-native-sound" CLI command will not link this and other libraries properly if you don't actually run the second command. After managing to run "npx react-native run-android" without errors, I tried the "react-native link react-native-sound" command and it worked.
Beginner's mistake, but hopefully I will save somebody else some time by putting it here.

When I run "npx react-native run-android"
Still facing the issue for android "undefined is not an object (evaluating 'RNSound.IsAndroid')".
Anyone got the solution to resolve it. Please reply need urgently.

I fixed by performing the following

Stop any react-native processes you have running.
Uninstall your app from your emulator / phone.
Do react-native link react-native-sound
Clear Android build cache with cd android && ./gradlew cleanBuildCache
Start react-native with npm run start or whatever
Do a fresh build with npm run android or whatever.

In my case, I am able to solve this error, by re-linking the libraries react-native link (not only the react-native-sound) and installing the app  npm run android again.
on Android Emulator:
"react": "16.13.1",
"react-native": "0.63.1",
"react-native-sound": "^0.11.0",

Fixed this bug on react-native 0.61.5:
add in Podfile
pod 'RNSound', :path => '../node_modules/react-native-sound'
pod install

RN 0.63.*
yarn
cd ios && pod install
``

Then you must close and re-compile app. Simply running yarn and pod install will cause OP's error.

https://stackoverflow.com/questions/57698661/undefined-is-not-an-object-evaluating-rnsound-isandroid
If I get it right, I can never get this to work when my App is made with Expo? I am new to React-native and just did buy a course to learn and wanted to try to implement react-native-sound and keep getting this error. My package.json looks like this: { "main": "node_modules/expo/AppEntry.js", "scripts": { "start": "expo start", "android": "expo start --android", "ios": "expo start --ios", "web": "expo start --web", "eject": "expo eject" }, "dependencies": { "expo": "^33.0.0", "pod": "^0.9.0", "react": "16.8.3", "react-dom": "^16.8.6", "react-native": "https://github.com/expo/react-native/archive/sdk-33.0.0.tar.gz", "react-native-sound": "^0.11.0", "react-native-web": "^0.11.4", "react-navigation": "^3.11.0" }, "devDependencies": { "babel-preset-expo": "^5.1.1" }, "private": true }
Edit: I guess I have to use this then? https://docs.expo.io/versions/latest/sdk/audio/
Edit 2: That seems to be it. You can't use native modules with Expo unless you want to work around it: https://docs.expo.io/versions/latest/expokit/eject/
*I will just leave this here in case it helps other people. I am probably not the only beginner trying to do this. Feel free to delete it if this does not belong here :)

I use this function successfully sovled my problem. anyone who use Expo can try this way.


Confirmation for Undo?

Undo is the only action that cannot be undone. The old GameController therefore required the user to click an action twice to undo it (after the first click, the button label turned into "Undo ...?", including all following actions).

can we have a redo instead of a confirmation?  confirmations usually don't stop me from making a mistake.


Randomizing reboot

Randomizing the reboot does not seem like a good idea. The effect this has is that the web roles will start with incorrect TLS/cipher configuration, and then after a random time it will reboot and fix itself. If you have customers using old ciphers (which I assume is the entire point of this guidance) then this will break compatibility with your customers at random times for random lengths of time. It would be better to restart immediately, and then add instructions that this script can only be used if you deploy via staging area.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6435e9f9-f345-e1b1-65bd-809c87419153
Version Independent ID: cff91a6d-eeb9-cd7c-af75-611d266d6635
Content: Troubleshooting issues caused by applications that don’t support TLS 1.2
Content Source: articles/cloud-services/applications-dont-support-tls-1-2.md
Service: cloud-services
GitHub Login: @mimckitt
Microsoft Alias: tagore

@nitramavfank
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@mimckitt
Can you please check and add your comments on this doc update request as applicable.

We are currently cleaning up old issues and closing out items that are greater than 90 days old. If an issue is still present, please open a new feedback item on the document so we can prioritize correctly.
#please-close


Parsing Errors With LogSeq

I'm having a similar issue as:
https://discuss.logseq.com/t/my-zotero-logseq-zettlr-word-workflow/8900/17?u=flan
Also, under Linux.
Here is an example Zotero item:

Here are my "Locating  MD Files" settings:

Not shown in the screenshot above, I've also tried entering optional Metadata Keywords (multiple iterations—e.g., "extra," "Citation Key", etc.—all rejected due to special characters).
This is what the LogSeq YAML looks like:

Here is an example of a parsing error I get:
{
"citekey": null,
"citekey_metadata": null,
"citekey_title": null,
"zotkeys": [],
"zotids": [],
"name": "zt-zhangBayesianMixedHidden2014",
"path": "/home/onomat/GitProjects/FlogSeq3/pages/zt-zhangBayesianMixedHidden2014.md"
},
I'm not technical enough to find the parsing error very informative.
Thank you for developing this plugin. I'd appreciate any insight you might have.

Hi @mruderman -- Try using this regex pattern instead:
^zt-(.+)\.md$

Make sure you've upgraded to https://github.com/daeh/zotero-markdb-connect/releases/tag/v0.0.21

@daeh Thanks for your reply. I think the XPI is missing from https://github.com/daeh/zotero-markdb-connect/releases/tag/v0.0.21
I forgot what modifications need to happen in the zip before changing the extension to xpi. Thanks again.

THANK YOU @mruderman ! Goodness, I don't know how that got by me. It's updated now.

(Note the string you enter should just be ^zt-(.+)\.md$, not /^zt-(.+)\.md$/i)

Apologies for the delayed response...it's working! This plugin is a lifesaver for me, thank you for developing it!

Great. Thanks for the update!
closed by 52ad81a18310b5695c9ad5933fea7861b29342de


Add OCI annotations

what

Add OCI annotations to published images

why

Standard compliance and better support for third-party tooling

references

OCI annotations
Supersedes and closes #915

michael@seki geodesic-cp % uname -a
Darwin seki 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:28:45 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6020 arm64
michael@seki geodesic-cp % git fetch
...
michael@seki geodesic-cp % git checkout oci-labels
make all | tee oci-labels-build.txt
...
Step 18/86 : ENV GEODESIC_OS=debian
 ---> Using cache
 ---> 88ed1bcaefc4
Step 19/86 : ARG TARGETARCH
 ---> Running in bcdd94688c5c
Removing intermediate container bcdd94688c5c
 ---> 755e2ea071de
Step 20/86 : ARG TARGETOS
 ---> Running in 74c5cf99f11a
Removing intermediate container 74c5cf99f11a
 ---> b7a850c2cf2e
Step 21/86 : RUN [ "$TARGETARCH" = "amd64" ] || [ "$TARGETARCH" = "arm64" ] || (echo "Unsupported TARGETARCH: \"$TARGETARCH\"" && false)
 ---> Running in edfd0e580eac
Unsupported TARGETARCH: ""
The command '/bin/sh -c [ "$TARGETARCH" = "amd64" ] || [ "$TARGETARCH" = "arm64" ] || (echo "Unsupported TARGETARCH: \"$TARGETARCH\"" && false)' returned a non-zero code: 1
make[2]: *** [docker/build] Error 1
make[1]: *** [docker:build] Error 2
make: *** [debian.build] Error 2
michael@seki geodesic-cp %

Fixes are in #915

michael@seki geodesic-cp % uname -a
Darwin seki 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:28:45 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6020 arm64
michael@seki geodesic-cp % git fetch
...
michael@seki geodesic-cp % git checkout oci-labels
make all | tee oci-labels-build.txt
...
Step 18/86 : ENV GEODESIC_OS=debian
 ---> Using cache
 ---> 88ed1bcaefc4
Step 19/86 : ARG TARGETARCH
 ---> Running in bcdd94688c5c
Removing intermediate container bcdd94688c5c
 ---> 755e2ea071de
Step 20/86 : ARG TARGETOS
 ---> Running in 74c5cf99f11a
Removing intermediate container 74c5cf99f11a
 ---> b7a850c2cf2e
Step 21/86 : RUN [ "$TARGETARCH" = "amd64" ] || [ "$TARGETARCH" = "arm64" ] || (echo "Unsupported TARGETARCH: \"$TARGETARCH\"" && false)
 ---> Running in edfd0e580eac
Unsupported TARGETARCH: ""
The command '/bin/sh -c [ "$TARGETARCH" = "amd64" ] || [ "$TARGETARCH" = "arm64" ] || (echo "Unsupported TARGETARCH: \"$TARGETARCH\"" && false)' returned a non-zero code: 1
make[2]: *** [docker/build] Error 1
make[1]: *** [docker:build] Error 2
make: *** [debian.build] Error 2
michael@seki geodesic-cp %

Fixes are in #915

Although I like your code a lot more

@arcaven Generally, people do not need to build Geodesic itself, so we are going to require buildkit to build it. I added an error message.


Problems with testing

Hello, on the CK + data set, I took the model with the highest accuracy (93.556%) of 10% cross-validation and then took a test in each of the CK + facial expression pictures, but none of the facial expressions were correctly identified , May I ask why this happens? Thank you

I checked the code again，I am sure that  all preprocessing is aligned with your code ~ But the result is still the same as before.I am very confused.Can you give me some suggestions on this issue?Thank you ~

if you test in all CK + data sets, it also includes the validation set. If the accuracy reaches 90%, it is impossible to have the problem that every picture is wrong. I think it must be a bug, please check your code again~

您好，非常感谢您的回复，我已经仔细检查了代码，但是现在出现了一个新的问题：在fer2013数据集上，我发现您的代码中已经采取了各种防止过拟合的措施，但是我画了loss-epoch图，发现还是出现了过拟合现象（训练集上loss一直下降，accuracy一直上升，但是测试集上loss先下降后上升），请问怎么解决呢？再次感谢您的回复~祝好
------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2020年5月5日(星期二) 下午3:16
收件人<EMAIL_ADDRESS>抄送: "玉纸尘"<2445155412<EMAIL_ADDRESS>主题: Re: [WuJie1010/Facial-Expression-Recognition.Pytorch] Problems with testing (#86)
if you test in all CK + data sets, it also includes the validation set. If the accuracy reaches 90%, it is impossible to have the problem that every picture is wrong. I think it must be a bug, please check your code again~
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

您好，非常感谢您的回复，我已经仔细检查了代码，但是现在出现了一个新的问题：在fer2013数据集上，我发现您的代码中已经采取了各种防止过拟合的措施，但是我画了loss-epoch图，发现还是出现了过拟合现象（训练集上loss一直下降，accuracy一直上升，但是测试集上loss先下降后上升），请问怎么解决呢？再次感谢您的回复~祝好
…
------------------ 原始邮件 ------------------ 发件人<EMAIL_ADDRESS>发送时间: 2020年5月5日(星期二) 下午3:16 收件人<EMAIL_ADDRESS>抄送: "玉纸尘"<2445155412<EMAIL_ADDRESS>主题: Re: [WuJie1010/Facial-Expression-Recognition.Pytorch] Problems with testing (#86) if you test in all CK + data sets, it also includes the validation set. If the accuracy reaches 90%, it is impossible to have the problem that every picture is wrong. I think it must be a bug, please check your code again~ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

我虽然采用了过拟合策略，但不能完全避免过拟合~FER一般训练150+ epoch就可以达到最佳的结果~


Refactor Exists and NotExists validators

Q
A

Documentation
yes

BC Break
yes

QA
yes

Description

Removes all setters and getters
Removes inheritance so both classes can be final
Removes compat with legacy Laminas\File\Transfer api
Improves docs and tests

Happy for this one to be merged @froschdesign ?


Fix "open an issue" link

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
[x] I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
[x] I've written tests to cover the new code and functionality included in this PR.
[x] I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Fix "open an issue" link to display link and be bold.
Previously:

Now:

Related Issues

n/a

Test strategy

No tests.

Coverage remained the same at 85.665% when pulling 87e9c5d4a8bde8da06e19290d4dfd09cbf14a628 on tnws:fix-contributing-link into cbe9da5fbd38a22cbf7fe7b7253a6fdefe6a4df3 on slackhq:master.

Oh, this is lovely!


Using a function pointer for constructor/destructor

This would be a first step towards creating proper vtables. Right now it works by essentially creating a function for the reference type and then using a switch case to pick the correct overload based on the type. This can be really slow if there are many options, most notable on the void reference which needs to do cleanup for every possible reference type. Another issue is that sometimes it's unclear if the overload even appears in the list.
let a: *int = zero_allocate(int)
let b: & = make_ref(*a)
// This never gets cleaned up currently because it doesn't *know* that &int does ever get assigned to &

This is mostly an issue with make_ref but it should be addressed anyway. It does work correctly for interfaces because it decides if a type is part of the overloads based on the first type of a function when it's defined. It does that reliably, but there's no such thing for the void reference and destructors.
While it would make sense to move to a vtable (inside *Type) completely, the priority should be first to make copy constructors and destructors part of *Type.
For making a vtable it is necessary to find a way to map a function name to an offset. I'm not quite sure how yet but I'll update this issue when I have an idea for it.

Implemented in 1ff0289cc3eadd349715e759229e78a610d3eb62
Performance impact seems to be marginal, but this is definitely the way forward.


AasServer and registry: environment variable naming

Hi,
I am trying to run an AAS Server and registry in docker. I am using the prebuilt docker images. Both the server and registry should use an external database. As far as I can tell this can be configured via .properties files within the containers or via environment variable.
From looking at loadFromEnvironmentVariables() in BaSyxConfiguration.java I can tell that for the registry to use an SQL-database as its backend I must set the env variable BaSyxRegistry_registry.backendto SQL.
In order to set this variable I would normally add the following to my docker-compose file:
environment:
  BaSyxRegistry_registry.backend: SQL

but because docker thinks all environment variables should follow the convention of only using ALL_CAPS it converts the variables name. So in my container I get BASYXREGISTRY_REGISTRY.BACKEND instead of BaSyxRegistry_registry.backend:

As a workaround one might try to set the variable via the terminal within the docker container, this yields an error because of the period in the variable name:

So currently it seems to be impossible to configure the basyx components in their docker containers without building a new image where the .properties files get overwritten, which is very cumbersome.
An easy fix for this would be to change the implementation of loadFromEnvironmentVariables() in BaSyxConfiguration.java to expect the environment variables to follow convention and be in ALL_CAPS with no periods.

You can configure the components either by passing the environment variables defined here  or by mounting an external folder containing the configuration files, see here.

Ah, thanks a lot. That first link is exactly the piece of documentation I was looking for.
Because I was looking in the Docker section and the examples I was not able to find it, maybe it would be helpful to provide a link to the pages describing the different configuration options on these pages too.

Thanks a lot for pointing out this gap in our documentation. I updated the docker section accordingly


[admin] Publish

Docs Build status updates of commit 9ece74b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/overview/script-storage.md
:bulb:Suggestion
View
Details

docs/develop/excel-async-model.md
:white_check_mark:Succeeded

docs/develop/external-calls.md
:white_check_mark:Succeeded
View

docs/develop/scripting-fundamentals.md
:white_check_mark:Succeeded
View

docs/images/code-editor-feedback.png
:white_check_mark:Succeeded
View

docs/images/power-automate-params-tutorial-1.png
:white_check_mark:Succeeded
View

docs/images/power-automate-tutorial-2.png
:white_check_mark:Succeeded
View

docs/overview/excel.md
:white_check_mark:Succeeded
View

docs/resources/add-ins-differences.md
:white_check_mark:Succeeded
View

docs/resources/vba-differences.md
:white_check_mark:Succeeded
View

docs/testing/power-automate-troubleshooting.md
:white_check_mark:Succeeded
View

docs/testing/troubleshooting.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/overview/script-storage.md

Line 28, Column 131: [Suggestion-preserve-view-not-set] Did you mean to link to a specific version? It's usually better not to specify a version, so the link always goes to the canonical version. If you really need to link to a specific version, add &preserve-view=true to the URL: /microsoft-365/compliance/search-the-audit-log-in-security-and-compliance?view=o365-worldwide#search-the-audit-log. Otherwise, remove the view parameter.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Gulp always runs the "default" task

If we have gulpfile.js file with the next content:
var gulp = require("gulp");
gulp.task("test", []);

and run gulp test command, it shows Task default is not in your gulpfile error in console.
Lets try to add the "default" task to our gulpfile.js file:
var gulp = require("gulp");
gulp.task("test", []);
gulp.task("default", []);

Then gulp test command runs the "default" task, although it must run the "test" task.
node version: v0.10.33
npm version: 1.4.28

Unable to replicate on node 0.10.36 with gulp 3.9 installed

Sorry, the problem was in windows command line. It doesn't see additional command line arguments, which I passed to the gulp. The issue resolved. Thanks.


Using React Router, the javascript for Materializecss is not working on the routed links

simply load the script with the component


Cache enabled clients produce error

Following the example code for caching as described in the docs produces an typeError.
Both client_mem_cache = pokepy.V2Client(cache='in_memory') and client_disk_cache = pokepy.V2Client(cache='in_disk', cache_location='/temp') lead to:
~\Python36\lib\site-packages\beckett\clients.py", line 194, in __init__
    super(BaseClient, self).__init__(*args, **kwargs)
TypeError: object.__init__() takes no parameters

The regular client = pokepy.V2Client() works just fine. Python version is 3.6.4, OS Windows 10.

I'm assuming you have version 0.4.0 from pypi.
Caching is only available on version 0.5.0, which is still not on pypi (I'm still testing it out).
That's my bad for having already described the feature on the docs.
It will be out until the end of the week.
If you don't want to wait you can install it from github with the following command:
pip install git+https://github.com/PokeAPI/pykemon.git@master

Thanks, I'll close the issue then.

@lianne-hufkens pykemon version 0.5.0 is now live.
You can now install it "normally":
pip install pokepy


Artifact accessURL broken when stored in Connector

I cannot query my artifact data because the access URL of the artifact description is changed when it is saved to the DSC database.
Using DSC v5 from dev branch I create an artifact:
curl -X 'PUT' \
  'http://localhost:8080/api/artifacts/7862747a-24d1-465e-9375-ce66700c70f6' \
  -H 'accept: */*' \
  -H 'Content-Type: application/json' \
  -d '{
  "title": "DWD Artifact",
  "accessUrl": "https://maps.dwd.de/geoserver/dwd/ows/?service=WFS&version=1.0.0&request=GetFeature&typeName=dwd%3AWarnungen_Gemeinden&outputFormat=application%2Fjson&download=true"
}'

When I query the artifact, I'm getting the following error:
2021-05-19T13:15:18,574 [http-nio-8080-exec-8] WARN - Could not connect to data source. [exception=(Unexpected code Response{protocol=http/1.1, code=404, message=Not Found,
url=https://maps.dwd.de/geoserver/dwd/ows/%2F**?service=WFS&version=1.0.0&request=GetFeature&typeName=dwd%3AWarnungen_Gemeinden&outputFormat=application%2Fjson&download=true&download=true}
With Body: <!DOCTYPE html>\r\n<html style="" xml:lang="de" lang="de">\r\n  <head>\r\n    <meta http-equiv="content-type" content="text/html; charset=UTF-8">\r\n    <meta http-equiv="X-UA-Compatible" content="IE=edge">\r\n    <meta charset="utf-8">\r\n    <meta name="viewport" content="minimum-scale=0.25, maximum-scale=5.0, initial-scale=1.0">\r\n    <title>Wetter- und Klimainformationen für Premiumkunden - Deutscher Wetterdienst - Fehlerseite</title>\r\n    <meta name="description"
...

As can be seen in the warning message the URL is different than the one I used to create the artifact. There is an extra %2F** before the parameters begin. This is why the DWD service responds with a 404 and the data cannot be retrieved.
I also tried to use this URL
https://maps.dwd.de/geoserver/dwd/ows
Then the error message is:
WARN - Could not connect to data source. [exception=(Unexpected code Response{protocol=http/1.1, code=404, message=Not Found, url=https://maps.dwd.de/geoserver/dwd/ows/%2F**}

Hi,
i have tried the first and the second provided url on the provider site and have no problem receiving data. I have looked into the stored url and the url used to send the request and they are identically to the provided one.
Can you please further describe your setup?

Some update: I just realized, that the consumer can download the artifact when the contract is requested:
curl -X 'POST' \
  'http://localhost:8082/api/ids/contract?recipient=http%3A%2F%2F<IP_ADDRESS>%3A8080%2Fapi%2Fids%2Fdata&resourceIds=http%3A%2F%2F<IP_ADDRESS>%3A8080%2Fapi%2Foffers%2F71a9d3cd-7088-4424-ae7c-162073abf5f2&artifactIds=http%3A%2F%2F<IP_ADDRESS>%3A8080%2Fapi%2Fartifacts%2Fb5d143e3-80f5-4b52-bf1c-c7839ba484b1&download=true' \
  -H 'accept: */*' \
  -H 'Content-Type: application/json' \
  -d '[ {
        "@type" : "ids:Permission",
        "@id" : "http://localhost:8080/api/rules/5041c3e5-4933-419d-87d9-474b98ced678",
        "ids:description" : [ {
          "@value" : "provide-access",
          "@type" : "http://www.w3.org/2001/XMLSchema#string"
        } ],
        "ids:title" : [ {
          "@value" : "Example Usage Policy",
          "@type" : "http://www.w3.org/2001/XMLSchema#string"
        } ],
        "ids:action" : [ {
          "@id" : "idsc:USE"
        }],
        "ids:target" : "http://<IP_ADDRESS>:8080/api/artifacts/b5d143e3-80f5-4b52-bf1c-c7839ba484b1"
} ]'

The consumer can then consume the locally stored artifact data.
However, if the consumer tries to download the artifact from the provider to then consume it:
curl -X 'GET' \
  'http://localhost:8082/api/artifacts/fbafcdb1-e516-4e6e-a504-ff5a17dbc989/data/**?download=true&agreementUri=http%3A%2F%2F<IP_ADDRESS>%3A8080%2Fapi%2Fagreements%2F9954899e-1348-48bb-a8c0-442fa3316c58' \
  -H 'accept: */*'

The error message is raised since the provider reloads the broken URL from its database.

The script to create the resource on the provider side can be found here: https://gist.github.com/sebplorenz/d9fadc2b5dc72b9bef73ffe6a15dcfe0

The problem is here https://github.com/International-Data-Spaces-Association/DataspaceConnector/blob/dc293bd3e761611d374bbb3dbc27cd520b6ea0a3/src/main/java/io/dataspaceconnector/services/HttpService.java#L160
The query input at this point is "/**" and it is appended to the data URL. How can I prevent this?

I believe the problem only occurs when using the Swagger UI since the path in the Swagger UI is /data/**.


Accuracy drop after fuse_layer_norms

I encountered an unexpected precision loss while using Quarot. I conducted comparison experiments on LLaMA-2-7b:
Performing w4a16 RTN quantization on the model resulted in a PPL (Perplexity) of 7.354664.
Performing only fuse_layer_norms without rotation operations resulted in a PPL of 7.641615. Based on this, the precision of these two results should be the same.
I also replaced RMSN with LlamaRMSNorm in fuse_layer_norms and set self.weight to 1, which resulted in a PPL of 9.577629.
Logically, these three results should be equal, shouldn't they?
`class RMSN(torch.nn.Module):
def init(self, hidden_size, eps=1e-6):
"""
LlamaRMSNorm is equivalent to T5LayerNorm
"""
super().init()
self.weight = torch.nn.Parameter(torch.ones(hidden_size)).to(torch.float16)
self.variance_epsilon = eps
def forward(self, hidden_states):
    input_dtype = hidden_states.dtype
    hidden_states = hidden_states.to(torch.float32)
    variance = hidden_states.pow(2).mean(-1, keepdim=True)
    hidden_states =self.weight * hidden_states * torch.rsqrt(variance + self.variance_epsilon)
    return hidden_states.to(input_dtype)

`

The reason for removing the non-equivalence is that the weight in rms cannot be multiplied by the end of XQ. Otherwise, Q.T cannot be canceled.


Create the UserInformation component

This component will be rendered within the main page of the dashboard. Specifically, render the following pieces of information:

Name
Email
Total daily usage
Please do not attempt to render other pieces of information within this component

I'd like to work on this


How to use?

I am having a hard time trying to figure out how i could use this. Could you please explain to me in detail the process to successfully getting the raw values as output.

@rockangator , take a look at my answer here...
https://github.com/mharthoorn/Muse.Net/issues/2


Isar v4 release build windows fails

Steps to Reproduce
Trigger release build.

error: failed to run custom build command for `mdbx-sys v0.0.0 (D:\a\isar\isar\packages\mdbx_sys)`

Caused by:
  process didn't exit successfully: `D:\a\isar\isar\target\release\build\mdbx-sys-f25058ecc33a1f64\build-script-build` (exit code: 101)
  --- stdout
  cargo:rerun-if-changed=build.rs

  --- stderr
  thread 'main' panicked at packages\mdbx_sys\build.rs:75:10:
  called `Result::unwrap()` on an `Err` value: Error { kind: NotFound, message: "program not found" }
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
mv: cannot stat 'target/x86_64-pc-windows-msvc/release/isar.dll': No such file or directory
Error: Process completed with exit code 1.

Code sample
Provide a few simple lines of code to show your problem.

Details

Platform: iPhone 13 Pro, Galaxy S7, x86 Android Emulator on Windows etc.
Flutter version: [e.g. 3.0.0]
Isar version: [e.g. 2.5.0]

[ ] I searched for similar issues already
[ ] I filled the details section with the exact device model and version
[ ] I am able to provide a reproducible example

There's something different in the build agent environment between v4 and v3. The rust compiler doesn't find the make command in v4

Workaround is in place, some action/tool breaks the search path in the windows environment, effectively deleting mingw from the path


View full reading history (all chapters)

Describe your suggested feature
Currently History tab shows only the date of the most recently touched chapter from each series, even though the app has data about every chapter.
It should be possible to view this information from within the app rather than only thorugh external tools or by deleting most recently read chapter from history.
Other details
Possible implementations within History tab:

Add History\Show/Hide all chapters toggle option next to History\Remove everything option

Replace History\Remove everything option with History\Overflow option and then add a Show/Hide all chapters toggle option there

Replace History entry\Delete option with History entry\Overflow option that would contain a Show all chapters option, which would open a screen with  read history of all chapters from only that title

Add History entry\Hold action that would activate the option for that entry

Possibly this data could also be visible in Chapters view as mentioned here
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.16.5.
[X] I will fill out all of the requested information in this form.

calling it "objectively wrong" seems a bit far out

Taking that seriously is what "seems far out". It was clearly a joke, there was even a freaking emoji! щ(゜ロ゜щ)

I suggest closing this issue to not have duplicates

Closing as a duplicate of #1123 (since they clarified what they wanted in the comments)


Contributor find method

@umarrasydan can't seem to deliver correct response based on this
Even just removing everything in the findContributor handler and putting just a res.json() with a mock object, does not work. In my Postman response, nothing.

there is something wrong with the route


New chipset

Just received a SP25BIOS-0042-ND from digikey.  This was hinted at in the documentation, but so far no results from attaching it.

This will come in use later, and is immediately obvious when needed


fix: LEAP-447: Fix Number tag validation  monorepo

Hi @Gondragos!
This PR was created in a response to PRs in upstream repos:

https://github.com/HumanSignal/label-studio-frontend/pull/1649

closing this as monorepo was merged to develop branch


EFRS-1227/Feature Added support of new rest api from 1.0.0 version to…

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA


NumSharp does not allow building with IL2CPP via Unity

Hi, I am having trouble with building an Android app that is using a NumSharp package in Unity.
This is the error that I keep receiving:
IL2CPP error for type 'NumSharp.LAPACKProviderType' in assembly '/UnityProject/Temp/StagingArea/assets/bin/Data/Managed/NumSharp.Core.dll'
Additional information: Value of type 'int' is too large to convert to short.
Any help would be much appreciated! Thanks

Where you ever able to solve this?


Update weaver dependencies and repository links

chore: update all go module dependencies, add all go tests to workflow
fix(weaver-go-sdk): use updated weaver protobuf for fabric and corda view
chore: add script to generate checksums for go modules
fix: update broken corda repository links
chore: use node 18 for besu asset exchange workflow

Looks like we are using Node 16 (as per the diff) and not Node 18 (as per the above comment). Right?

Looks like we are using Node 16 (as per the diff) and not Node 18 (as per the above comment). Right?

Yes we are using Node 16, sorry that was old description, just now edited the PR desciption.


Use DBT_PROJECT_DIR if available and fix paths to configured subfolders

It can be safely assumed that if DBT_PROJECT_DIR is set, the user wants to call dbtdoc on that directory. If this environment variable is unset, the second best bet is that the user wants to run dbtdoc in the current working directory.
When parsing dbt_project.yml, the macro-paths etc. paths were not prepended by the dbt_dir path.
Include model, macro, and test folders by default.

thanks for the PR


Update Url.roc to not use Str.appendScalar

PR #6395 removed Str.appendScalar from builtins. The code should be updated to user roc-lang/unicode instead.

roc-lang/unicode does not have this function implemented yet. I'll write up a pure Roc solution for now.

I think we should just remove the need for Str.appendScalar instead of implementing it a different way.
Change percentEncode to accumulate to a List U8. Then do a single Str.fromUtf8 that crashes on failure to parse (cause that should be impossible).

Yeah, we should copy this from basic-cli but crash instead of using withDefault: https://github.com/roc-lang/basic-cli/commit/6208966e479f44457800ce593de8a38140078b1b#diff-f2522523f2f51a7e343e40fc784e44fecce8bb276db26027f3353c63f475807bR197-R228


Better plural stemmer than minimal_english

This originated from https://github.com/elastic/elasticsearch/issues/42892 originally authored by @markharwood (nice job Mark!). The PR is licensed ALv2 and never found a home in Elasticsearch. The improvements over the buggy lucene implementation are substantial so I'm opening a PR to include it in OpenSearch 2.4.

@markharwood - do you think this TokenFilter should eventually make it's way back into lucene?

Thanks for picking this up, Nick. Yes, I think this would be a natural fit as a Lucene contribution.

Yes, I think this would be a natural fit as a Lucene contribution.

Thanks @markharwood!!!  Maybe we incubate this here in OpenSearch and then look at contributing it back to lucene. Let us know if you want to contribute it back, or someone here can and we'll copy you on the PR.


fix(pyright): set useLibraryCodeForTypes to false

According to the official setting document, the default value of python.analysis.useLibraryCodeForTypes should be false. See pyright/docs/settings.md
When this option's value is true, it will significantly affect the completion speed of the code, and I hope to merge it as soon as possible.

When this option's value is true, it will significantly affect the completion speed of the code, and I hope to merge it as soon as possible.

you can set it to false in your local right ? why you so hurry ?

When this option's value is true, it will significantly affect the completion speed of the code, and I hope to merge it as soon as possible.

you can set it to false in your local right ? why you so hurry ?

Sorry I didn't express myself well; my problem.
Today at noon, I used only Pyright as the language server in Neovim and VSCode, and Neovim's code completion was much slower.
So I started looking for the problem and finally found that it was the useLibraryCodeForTypes option.

Of course, now I've finished.
Thank you for your positive response!

if you set it to default value. i think should be  remove this field.

if you set it to default value. i think should be remove this field.

Yes, you are right!
I have removed this field now.

Did you test this before merging? This is not a fix but a regression, and it should be reverted. I say this both as the person who added the language server and former neovim/lspconfig maintainer.
There's a reason this was enabled, it matches the upstream vscode default: https://github.com/microsoft/pylance-release/blob/main/README.md used in their language server (which forwards the settings the pyright).
Without this, if libraries don't ship typestubs pyright will have degraded behavior, and users will be confused why neovim is "worse" than vscode. Here's a clear test case that illustrates this.
https://github.com/microsoft/pyright/issues/4827

Did you test this before merging? This is not a fix but a regression (and that's not what the conventional commit would be anyways), and it should be reverted. I say this both as the person who added the language server and former neovim/lspconfig maintainer.
There's a reason this was enabled, it matches the upstream vscode default: https://github.com/microsoft/pylance-release/blob/main/README.md used in their language server (which forwards the settings to pyright, thus overriding the pyright "defaults").
Without this, if libraries don't ship typestubs pyright will have degraded behavior, and users will be confused why neovim is "worse" than vscode. Here's a clear test case that illustrates this.
microsoft/pyright#4827
This isn't a unique case, a cursory search reveals tons of people get directed to turn on useLibraryCodeForTypes:
https://github.com/microsoft/pyright/search?q=uselibrarycodefortypes&type=issues https://github.com/microsoft/pylance-release/search?q=uselibrarycodefortypes&type=issues
The correct fix for this is to file an upstream bug with pylance/pyright (replicated in vscode) showing the degraded behavior as this benefits everyone, not disabling functionality for neovim users. If you want this as the default, you should change it in your config.

My mistake; You make a good point; blame me too shallow.

I'm sorry for all of this.

It's not your responsibility to know these things, you just filed a PR. My message is directed at glepnir as maintainer.

I'm sorry to bother you all again.
Just now, I updated my neovim from  HEAD-bad218c to HEAD-8b7fb66.
I found that even if I set python.analysis.useLibraryCodeForTypes = true, the huge completion delay I had before disappeared. Now it really works as it does in VSCode.
It seems to be an upstream issue.

From looking at the commit reords there is nothing that could be relevant (I wrote a signifiant chunk of the performance critical part of the LSP client and none of that has been touched). It's more likely you updated pyright.

From looking at the commit records there is nothing that could be relevant (I wrote a signifiant chunk of the performance critical part of the LSP client and none of that has been touched). It's more likely you updated pyright.

Thank you very much for your reply! Yes, the problem is with Pyright! I just rolled back my version of Pyright, and it reproduced my problem.


Adding .travis.yml.

Adds a .travis.yml file. Will close #5 .

ping @somexpert @damonkelley

:+1: This looks good.
We are going to need to update runtests.py though. This build should be failing. The test script is not returning an accurate exit code upon failure. But you are probably already aware of this. :wink:

:thumbsup:

yay fail, fail, fail now! Just like we hoped. :) you want to check the last commit @somexpert @damonkelley https://github.com/unt-libraries/pyuntl/commit/c7e0335d1e809d94bfcb8682da76938bc81bb91e

:+1:

:thumbsup:


feat: Improved the issue where the GitHub icon pointed to only the "website" repository.

Description
Improved the issue (#46) where the GitHub icon pointed to only the "website" repository. It has now been changed to a dropdown, allowing users to choose between accessing "opendigger" or "opendigger-website."

Resolved issues
Closes #46

It makes sense to use dropdown item here. I commit to:

It should be GitHub rather than Github
For links, we should remove GitHub and redundant words to keep it neat
If we do not need the icon, we could just remove the css rather than comment them

But still, I think the icon is much better looking than GitHub plain text, but I can not figure out how to add a dropdown list to an icon in the navbar.
@Neilblaze WDYT? Is there any way to add link list to an icon and make it a dropdown item?

@frank-zsy, @Peng99999 I don't have edit/write privileges (since I'm a non-member of x-lab2017), so I'm linking my reviews/suggestions herewith. Just replace the current content for docusaurus.config.ts and custom.css with my content, which can be found → here .
Preview:

Landscape Preview
Mobile Preview

Btw, now that I've already mentioned it, I'm really curious to know how an existing contributor can be a part of X-lab2017 GitHub org? 🤔

@frank-zsy, @Peng99999 I don't have edit/write privileges (since I'm a non-member of x-lab2017), so I'm linking my reviews/suggestions herewith. Just replace the current content for docusaurus.config.ts and custom.css with my content, which can be found → here .
Preview:
Landscape Preview Mobile Preview

Thank you, @Neilblaze , for the great solution.😄  @frank-zsy, Can we invite @Neilblaze to join in X-lab2017 GitHub org?

@Neilblaze Great, if you are interested in our work, I can invite you as a member of X-lab and committer of this repo.

@frank-zsy Sure, would love to be a part of the family! 😃

@Neilblaze Invitation sent. Welcome to X-lab and OpenDigger~~


chore: Stop including unnecessary files in published packages (packages/dds)

Description
Start of moving to package.json's files property to determine the exact files that get into published packages. This PR only applies the change to the 14 packages within packages/dds, which have few changes in the final files that get published and are easy to analyze.
A whitelisting approach is more robust against including files by mistake and would make it more obvious if we missed adding something that is necessary. My plan is to move the whole repo to this approach if there are no objections.
Reviewer Guidance
The contents of package.json's files is the same in all the updated packages:
"files": [
  "dist/**",
  "!dist/test/**",
  "lib/**",
  "src/**",
  "!src/test/**"
],

Feedback welcome on reasons why we should not do this, or why we should keep some of the affected files. E.g. there's an argument that might suggest we keep tsconfig.*.json, to allow consumers to re-compile the packages from the source code (which we include already) for a different target (CommonJS/ESM, es6/es2017/es2020/etc). Do we even want to make this a possibility? I don't expect we'd support it.

Below are diffs showing the files that stopped being published for each package. The following are common for almost all packages:
.eslintrc.js
.mocharc.js
CHANGELOG.md
api-extractor.json
prettier.config.cjs
tsconfig.esnext.json
tsconfig.json

Some diffs show files that don't really go into the published package but ended up here as part of the packing process when run locally several times (e.g. map.test-files.tar for @fluidframework/map or matrix.test-files.tar for @fluidframework/matrix).
Some packages do show other files that were being included but seem ok to not include, like the bench/ folder for @fluidframework/matrix and @fluidframework/shared-object-base, or the docs/ and .vscode/ folders for @fluidframework/merge-tree and @fluidframework/sequence. @fluid-internal/test-dds-utils is a bit of an outlier in its changes but they also look correct.

AB#4135

Feedback welcome on reasons why we should not do this, or why we should keep some of the affected files.

My main concern with this change is that it can be a "timebomb" that detonates only at package publish time, which is when the stakes are highest.
Most developers don't think about what's in the published package when they're making changes, and the current approach protects against mistakes of that kind.
That said, one thing we could do to make this safer is add a simpler way for people to verify that the contents of the package is whey expect, and a build step that breaks if anything's added but not published.
It may be a controversial option, but I like build steps that force acknowledgement of a "side effect" to a change. Type tests are an example of this.

My main concern with this change is that it can be a "timebomb" that detonates only at package publish time, which is when the stakes are highest.
Most developers don't think about what's in the published package when they're making changes, and the current approach protects against mistakes of that kind.

True. It goes both ways somewhat (with different degrees of impact to each side, granted). In #15560 I discovered that @fluidframework/aqueduct and @fluidframework/data-object-base are 50% and 200% bloated because of the inclusion of a file that doesn't need to be in the package. It doesn't impact the bundle size for a webapp and arguably our package size isn't as critical for a Node app, so not the end of the world, but I still consider it an error on our part.
That said, I agree that if we're not thinking about what's in the published package, it's (potentially much) worse to fail to include something functional VS failing to notice something unnecessary sneaked in. Case in point, we just had to deal with issues because @fluentui/react and its related packages recently published borked versions that stopped including important folders that were there before. But that seems like a low probability thing for our packages given how homogeneous they are; most of them just need to keep publishing dist/, lib/, and src/ (with the tests excluded). The few that do something "special" regarding the files they need to include seem to be our internal tooling ones like mocha-test-setup or eslint-build-config.
I guess part of my motivation is that I think we should start being more deliberate about what goes in the published packages; make it second nature. And our standard setup for a package probably has us covered in 99% of cases already, so to me the risk feels relatively low.

That said, one thing we could do to make this safer is add a simpler way for people to verify that the contents of the package is what they expect, and a build step that breaks if anything's added but not published.
It may be a controversial opinion, but I like build steps that force acknowledgement of a "side effect" to a change. Type tests are an example of this.

I don't have anything against the approach in general, but I'm trying to think of how it applies here and don't like the result. Feels like we have to maintain an explicit list of either the exact files (not globs, or we risk edge cases where we miss something) that we want in there or the exact files we don't want in there, and both options feel... unwieldy.

I echo @tylerbutler's general concerns. If we do miss something, we likely won't discover it until we're customers try using our newly published package versions.

That said, one thing we could do to make this safer is add a simpler way for people to verify that the contents of the package is what they expect, and a build step that breaks if anything's added but not published.
It may be a controversial opinion, but I like build steps that force acknowledgement of a "side effect" to a change. Type tests are an example of this.

I don't have anything against the approach in general, but I'm trying to think of how it applies here and don't like the result. Feels like we have to maintain an explicit list of either the exact files (not globs, or we risk edge cases where we miss something) that we want in there or the exact files we don't want in there, and both options feel... unwieldy.

It would be nice to at least have a utility that generates a report of what files would be published given a package's config (post build). That way devs could easily audit any changes they make to the config. This would be useful in either world (npmIgnore or files). CI enforcement would be nice, but as @alexvy86 noted, it likely amounts to maintaining an explicit list of files, which would likely not scale well. But just having a utility to generate a report that we could include in PR descriptions when making publish config changes would be useful.

I opened #15573 which addresses some of the concerns here (and in the related PRs) but sticking to our current .npmignore approach (except two packages because they already use files; we can debate separately if we should change that).


Allow wildcards in allowlist

I'm hereby breaking the first rule from CONTRIBUTING.md by not opening an issue before submitting a pull request but we needed this feature urgently since we were being drowned in non-critical audit advisories obscuring any critical vulnerability.
Background
The existing allowlist functionality is great but not powerful enough to keep us from being spammed with "vulnerabilities" deeply nested below some non-critical dev-tool that will never reach production. We are experiencing that that the number of reported vulnerabilities for such tools grow faster than they are fixed, leaving us with an ever-growing and increasingly hard-to-maintain allowlist.
Solution
Allow the use of wildcards in the allowlist. This lets replace our old allowlist looking something like this:
[
  "12345|webpack-dev-server>some>vulnerable>submodule",
  "23451|webpack-dev-server>some>other>vulnerable>submodule",
  "34512|webpack-dev-server>yet>an>other>vulnerable>submodule",
  "666|real>critical>vulnerability>hiding>here"
  "45123|webpack-dev-server>oh>no",
  "51234|webpack-dev-server>i>give>up",
  ...
]

with something like this:
[
  "*|webpack-dev-server>*",
  "666|real>critical>vulnerability>hiding>here"
]

Thanks for the background! The code looks great. Out of curiosity, does allowlisting just webpack-dev-server work in this scenario? If so, does that suffice?

If we allowlist just webpack-dev-server it only allows vulnerabilities that module but issues in the submodule tree will not be allowlisted. One current example is advisory 178796 with path webpack-dev-server>selfsigned>node-forge. Allowlisting
webpack-dev-server won't help here since the vulnerability is in a sub module. Allowlisting the sub module node-forge will work but also hide all current and future vulnerabilities related to using this unpatched module in production code which is definitely not what we want...


[fix] spelling of .DS_Store

The spelling of .DS_Store in the default config is incorrect. As a result, .DS_Store files are not filtered out from the files array passed to the service worker.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Should we just use a case insensitive regex, or is this always .DS_Store?

thanks!

Should we just use a case insensitive regex, or is this always .DS_Store?

i've never seen it cased any other way (except in our docs, apparently)

This isn't just changing the docs, it's also changing Kit, so this would need to include a changeset in order to be released.

OK, I’ve added a changeset. Let me know in case any other adjustments are needed.


optional outbound tx confirmation (outtx tracker) verification

Closing as it seems no longer relevant with the current state of the project. Feel free to reopen it.


pipenv update fails on 2018.6.25

pipenv 2018.6.25:
$ pipenv update
../.local/lib/python3.5/site-packages/pipenv/vendor/requests/__init__.py:83:
Running $ pipenv lock then $ pipenv sync.
Locking [dev-packages] dependencies...
ite-packages/pipenv/resolver.py", line 37, in main
    from pipenv.utils import create_mirror_source, resolve_deps, replace_pypi_sources
ImportError: cannot import name 'create_mirror_source'

Works with: pipenv-2018.5.18

Hi @gsemet, I'm looking into this issue now.  Can you fill out the issue template by running the command python -m pipenv.help?  It would greatly aid in troubleshooting.

Stop breaking stuff!!! :)
Is that the right pipenv? Seems like multiple versions

@gsemet @techalchemy I can't reproduce this issue at this point in time.  If you could post the help diagnostic info that would be great.

Indeed seems like you have multiple instances installed and one (the new version) tries to import the other (the old version). create_mirror_source is added in the latest release.

Hi. I have removed long time ago all reference to pipenv, so the one in ~/.local/bin is the only one.
I cannot reproduce anymore, going back and forth with pipenv-2018.5.18 works, so now it seems the upgrade is fine. It did failed in some of our CI pipelines, however that annoy me more.
You can close it if this is no more reproducible

For CI, it might help to pip uninstall -y pipenv and install it again. Maybe it is trying to import from the old bytecode, even after the source update… I vaguely remember there is an environment variable to fix that as well.

PYTHONDONTWRITEBYTECODE=1

Reproduced today. I had another pipenv on python2 in .local. Removed by pip uninstall -y pipenv. I use pip3 install pipenv.
So there can be contamination between module imports somehow, from the python3 pipenv, it somehow include a module from python2 dist-packages, which should not happen


Infinite Scroll | fix redundant rest calls

Describe your changes

Sent time parameters holdinng on ranges component to not make duplicate rest calls
INITIAL_EXTRA_REQUEST_THRESHOLD=20 added to managing sending initial request to add more data (prev value was: 40)
base+quote address useEffect checked with ref values to not make redundant refreshes on infinite scroll
Data change effector which sending initial request is wired into oldestTxTime to make meaningful initial request into backend
Loggers added to check duplicate call catches (can be removed while merging)
Extra gatekeeper added to show loading state on infinite scroll component to handle async issues

Link the related issue
Closes #0000
Checklist before requesting a review

[ ] Is this PR ready for merge? (Please convert to a draft PR otherwise)
[ ] I have performed a self-review of my code.
[ ] Did I request feedback from a team member prior to the merge?
[ ] Does my code following the style guide at docs/CODING-STYLE.md?

Instructions for Reviewers
Functionalities or workflows that should specifically be tested.

Environmental conditions that may result in expected but differential behavior.

If relevant, list additional work to complete pre-merge (delete logging, code abstraction, etc)

this PR content is already merged with
https://github.com/CrocSwap/ambient-ts-app/pull/4314