[BUG] paint.GetTextPath() doesn't respect paint.TextAlign property

Description
Halo Text position doesn't match with actual text if paint.TextAlign property different than SKTextAlign.Left
I think the reason is that paint.TextAlign property not been included in the paint.GetTextPath() method.
Code
SKPaint paint = new SKPaint();
paint.TextAlign = SKTextAlign.Center;
// Draw Halo
canvas.DrawPath(paint.GetTextPath("Test Text", 0, 0), haloPaint);
// Draw text
canvas.DrawText("Test Text", 0, 0, paint);
Attached a screenshot of red text with blue halo underneath (using above code), the halo was off because the text Align is Center, but Halo seems still using TextAlign.Left
Actual Behavior

Basic Information

Version with issue:  2.80.1
Last known good version:  1.68.3
IDE:  Visual Studio
Platform Target Frameworks:  tested in Windows, but I believe applies to all platforms

I think SKPaint.GetTextPath should be deprecated, because it is actually defined on the new SKFont, and that calls the native SkTextUtils::GetPath function.
However, since SKFont doesn't have any text alignment, it is dropped
You can align the path yourself with e.g.
path.Transform(SKMatrix.CreateTranslation(-path.Bounds.Width / 2f, 0));
or by applying a transform to the canvas.
I agree that if GetTextPath is kept on SKPaint, that is should take text alignment into account, maybe just calling Transform for you...


Windows Universal support

Currently, I can see Zenject only support Windows 8.0 and Windows Phone 8.0 SDK.
Have you ever planned to support Universal Apps for Windows ? Indeed, there is some bugs when it compiles a build (Tuple namespace, not existing assembly).
Thanks.

I hadn't thought about it, but it would be nice to maintain support for that.  I don't have a windows 8 machine currently so am not able to test it yet.

All Windows Store types including universal should be supported now


In multi-gpus, trainer.test Error when ModelCheckpoint specifies the filename.

🐛 Bug

In ddp mode (trainer(accelerator='ddp') with multi-gpus, the trainer could not find the saved custom-named checkpoints when .test(), which would lead to the following error:

In addition, the program could hang, not be closed (even with CTRL-C)   and the main GPU's Volatile is always 100%:

The following modelcheckpoint would lead to the problem:
ckpt = ModelCheckpoint(dirpath='./checkpoints/', monitor='valid_loss', mode='min', filename="{epoch}-{valid_loss:.4f}")

If removing the filename, the program can work well:
ckpt = ModelCheckpoint(dirpath='./checkpoints/', monitor='valid_loss', mode='min')

Please reproduce using the BoringModel
The code is based on the pl_example  in https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pl_examples/basic_examples/autoencoder.py.
The whole code could be found in https://paste.ubuntu.com/p/2Qp4GRns7f/

Environment

CUDA:
- GPU:
- GeForce RTX 3090
- GeForce RTX 3090
- available:         True
- version:           11.1
Packages:
- numpy:             1.19.4
- pyTorch_debug:     False
- pyTorch_version:   1.8.0+cu111
- pytorch-lightning: 1.2.5
- tqdm:              4.53.0
System:
- OS:                Linux
- architecture:
- 64bit
- ELF
- processor:         x86_64
- python:            3.6.9
- version:           #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021

Additional context

Hi @ShomyLiu,
This could be resolved in your code by adding sync_dist=True parameter to reduce the metric across GPUs.
self.log('valid_loss', loss, on_step=True, sync_dist=True)

But yes, better Error Handling could be added. We will look into it.

@kaushikb11  Thanks for your solution. It did work after adding sync_dist=True.
Another small question, when using multi gpus   the output of test phase will be multiple, so which one should be used?
Just using the above code, the output is:
DATALOADER:0 TEST RESULTS
{'test_loss': 0.04038815572857857, 'test_loss_epoch': 0.045426301658153534}
--------------------------------------------------------------------------------
[{'test_loss_epoch': 0.045426301658153534, 'test_loss': 0.04038815572857857}]
[{'test_loss_epoch': 0.046016596257686615, 'test_loss': 0.05867530405521393}]

Would you mind explaining these three outputs more clearer?
I guess that the first one is the final result and the last two are the outputs of different processes.  In addition, what's the difference between test_loss_epoch and test_loss?
Thanks

@ShomyLiu: test_loss_epoch is aggregated test_loss over one epoch.


Mechanisms for Explosion Power and Explosion Radius

I request a feature to modify the mechanisms "Explosion Power" and "Explosion Radius" for eplosive entities similiar to the the parameters already existing in vanilla minecraft.
example command from vanilla: /summon Fireball ~ ~1 ~ {ExplosionPower:5,ExplosionRadius:3}
having those mechanisms implemented could proof usefull to further utilize the "shoot" and "summon" command in interesting ways.

Added ( thanks to @mergu !) in build DEV-811+


KubeDNS dns hostname resolution does not work in ingress nginx (load balancer)

Rancher versions:
rancher/rancher:2.0.2
rancher/rancher-agent:2.0.2
Infrastructure Stack versions:
healthcheck:
ipsec: -
network-services: -
scheduler: -
kubernetes: 1.10.1
Docker version:
Client:
Version:      18.03.1-ce
API version:  1.37
Go version:   go1.9.2
Git commit:   9ee9f40
Built:        Thu Apr 26 07:12:25 2018
OS/Arch:      linux/amd64
Experimental: false
Orchestrator: swarm
Server:
Engine:
Version:      18.03.1-ce
API version:  1.37 (minimum version 1.12)
Go version:   go1.9.5
Git commit:   9ee9f40
Built:        Thu Apr 26 07:23:03 2018
OS/Arch:      linux/amd64
Experimental: false
Operating system and kernel:
4.14.32-rancher2
Type/provider of hosts:
Bare-metal
Setup details:
Single node, internal DB
Environment Template:
Kubernetes
Steps to Reproduce:

Create a simple pod with no authentication, say a static html page.
Give it a ClusterIP service (at port 80). Name it: no-auth-service in namespace no-auth-ns
Create a second pod with basic authentication.
Also give it a ClusterIP service (at port 80). Name it: auth-service in namespace auth-ns
Create a load balancer pointing to the first.
Give the load balancer the following annotation:
nginx.ingress.kubernetes.io/auth-url=http://auth-service.auth-ns.svc.cluster.local

Upon navigating to the hostname of our load balancer, the basic authentication of our auth-service
should pop up, and after authenticating, the static page of our first service should load.
Results:
We are greeted with a 503 service temporarily unavailable error, as ingress nginx could not find the authentication endpoint, as it does not receive DNS resolution from KubeDNS.
ingress-nginx is also the only service without the environment variables pointing to our Kubernetes services. It's nameserver seems to be pointing at the network router, instead of KubeDNS.
The example does work perfectly if the service's IP address endpoint is provided to the annotation, demonstrating that the functionality itself works.
In the container (nginx ingress controller) however, dns hostname resolution doesn't work at all, ping doesn't recognize any of the hostnames. In every other container, it works perfectly.
This makes things problematic, as in order to point at a service currently in annotations and such is to provide the service's endpoint IP, which may change.

I'm getting the same error, heh, I'm also using the same service name. Though I'm getting a 502 back.
[error] 50#50: *706 auth-svc could not be resolved (2: Server failure), client: <IP_ADDRESS>, server: _, request: "GET /config/api/v1/apps HTTP/1.1", subrequest: "/_external-auth-L2NvbmZpZw", host: "<IP_ADDRESS>"
[error] 50#50: *706 auth request unexpected status: 502 while sending to client, client: <IP_ADDRESS>, server: _, request: "GET /config/api/v1/apps HTTP/1.1", host: "<IP_ADDRESS>"

FYI I filed a report above, using the full FQDN should work - I tested that out, and my service is in the default namespace, and it appears to have worked.

I'm having the same issue, tried to use in one my services to point to another internal service and NGINX logs shows that it can't resolve the name.
type: ExternalName
externalName: k8smain-pentaho.k8smain.svc.cluster.local

For my specific case using External Names, I was able to get it working by updating my service definition to “Alias of another DNS record’s value” and point it to my existing service which seems to tell NGINX the cluster IP instead the FQDN

Close in favor of https://github.com/kubernetes/ingress-nginx/issues/3426

Close in favor of kubernetes/ingress-nginx#3426

Excuse me, could you provide a little bit more details? Did you close this issue in favor of another closed and unresolved issue?

This is still reproducing with k8s.gcr.io/ingress-nginx/controller:v0.41.2. For requests coming from within clusters where $host is a FQDN all the requests cannot be resolved. If hardcoded static IP is used it works fine but this is not a solution as there are multiple scenarios when IP is not known at deployment time.
Please reopen it as it seems there is no solution yet


[#3198] feat(spark-connector): Add IT for Iceberg RestCatalog with JdbcCatalog backend

What changes were proposed in this pull request?
Add IT for  Iceberg RestCatalog with JdbcCatalog backend.
Why are the changes needed?
Add IT for  Iceberg RestCatalog with JdbcCatalog backend.
Fix: https://github.com/datastrato/gravitino/issues/3198
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New ITs.

@FANNG1 would you please help to review this?

@FANNG1 would you please help to review this?

this pr depends on #3151 and #3194. maybe we can review #3151 and #3194 at first. thank you.

You should mark this pull request draft.

@FANNG1 would you please help to review this?

this pr depends on #3151 and #3194. maybe we can review #3151 and #3194 at first. thank you.

You should mark this pull request as draft.

got it, thanks


Authenticator as a System Plugin

Hi,
We need to integrate Digdag within a system using oAuth2.
Before starting working on a PR we'd like to have feedback on our plans:

Making the Authenticator interface a system plugin and move it to the SPIs.
Make the JwtAuthenticator the default plugin to keep things as they are.
Create an oAuth2 "Authenticator" plugin that could be enabled and configured by properties.
Make the WebUI able to do oAuth2 Implicit Grant auth when configured to do so.

1 and 2 would be one PR while 3 and 4 another one.
Let me know of any issue with this plan.
Thanks,
Pierre

Some notes.
"3.1.2. Implicit Grant" in "OAuth 2.0 Security Best Current Practice" says as follows.

In order to avoid these issues, clients SHOULD NOT use the implicit grant (response type "token") or any other response type issuing access tokens in the authorization response, such as "token id_token" and "code token id_token", unless the issued access tokens are sender-constrained and access token injection in the authorization response is prevented.

OAuth should not be used for authentication. OpenID Connect is a better option for the purpose. See "The problem with OAuth for Authentication".

Hi @pdelagrave, I'm not 100% sure what you want to design and impl. But at least for your 1st and 2nd items, it's ok for us to make extension point for authenticator as system plugin. And can you take a look @TakahikoKawasaki's comment and any thoughts?
@TakahikoKawasaki thank you for your comment.

@TakahikoKawasaki

Some notes.
"3.1.2. Implicit Grant" in "OAuth 2.0 Security Best Current Practice" says as follows.

In order to avoid these issues, clients SHOULD NOT use the implicit grant (response type "token") or any other response type issuing access tokens in the authorization response, such as "token id_token" and "code token id_token", unless the issued access tokens are sender-constrained and access token injection in the authorization response is prevented.

OAuth should not be used for authentication. OpenID Connect is a better option for the purpose. See "The problem with OAuth for Authentication".

Can't argue with that, thanks for providing links to documents.
The usage of implicit grant was proposed because given specific circumstances, it can be secure enough while being the simplest grant type. Though I agree that the point 4 I suggested isn't the most secure by default.
To your points, it would better to use OpenID Connect on top of the auth code grant. That seems to be the best that can be done for a Single Page Application like Digdag UI.
https://tools.ietf.org/id/draft-parecki-oauth-browser-based-apps-00.html
@muga
We can start with a PR for point 1 and 2 and discuss a UI patch later.
Thanks
Pierre

Hi @muga,
I've submitted 2 PRs related to this issue:
https://github.com/treasure-data/digdag/pull/1098
https://github.com/treasure-data/digdag/pull/1099
The first one is only about extracting the Authenticator interface into an SPI and making the existing JwtAuthenticator into a plugin.
The second one is a new Authenticator plugin that does basic auth. This is useful for many situations where a user deploys Digdag in a lesser than prod environment but still require some sort of auth.
In either cases, the JwtAuthenticator plugin is the default one and the PRs don't introduce any breaking changes.
Thanks,
Pierre

Already merged. Close.


Homepage cards for my profiles

GitHub
Medium
Twitter
LinkedIn
Speaker Deck
Google Plus
Blast Cap Games

Not going to do right now


The Wagtail repo has moved to its own organisation

[x] verified that the CMS I'm adding modifying is still maintained.
[x] read CONTRIBUTING.md.
[x] did not generate README.md.

thanks for the update @tomdyson!


Tell github not to render generated files by default in diffs

For info on how this works, see https://docs.github.com/en/github/administering-a-repository/managing-repository-settings/customizing-how-changed-files-appear-on-github.

Known issues: #25004 #26595
The "Basic Tests C# Windows" failure is an infrastructure timeout.


Use small datasets for non-extended unit-tests.

Signed-off-by: Harkishen-Singh<EMAIL_ADDRESS>

bors r+

bors r+


安装nsfl-ctl时报错

Build proto successfully.
INFO: Repository rules_python instantiated at:
/root/zhn/federate/federated-learning-main/WORKSPACE:2:15: in
Repository rule git_repository defined at:
/root/.cache/bazel/_bazel_root/cb5c4cd825dbca79ce4440ddff3ab78c/external/bazel_tools/tools/build_defs/repo/git.bzl:199:33: in
ERROR: An error occurred during the fetch of repository 'rules_python':
Traceback (most recent call last):
File "/root/.cache/bazel/_bazel_root/cb5c4cd825dbca79ce4440ddff3ab78c/external/bazel_tools/tools/build_defs/repo/git.bzl", line 181, column 30, in _git_repository_implementation
update = _clone_or_update(ctx)
File "/root/.cache/bazel/_bazel_root/cb5c4cd825dbca79ce4440ddff3ab78c/external/bazel_tools/tools/build_defs/repo/git.bzl", line 36, column 20, in clone_or_update
git = git_repo(ctx, directory)
File "/root/.cache/bazel/_bazel_root/cb5c4cd825dbca79ce4440ddff3ab78c/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 91, column 12, in git_repo
_update(ctx, git_repo)
File "/root/.cache/bazel/_bazel_root/cb5c4cd825dbca79ce4440ddff3ab78c/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 101, column 9, in _update
init(ctx, git_repo)
File "/root/.cache/bazel/_bazel_root/cb5c4cd825dbca79ce4440ddff3ab78c/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 118, column 15, in init
_error(ctx.name, cl, st.stderr)
File "/root/.cache/bazel/_bazel_root/cb5c4cd825dbca79ce4440ddff3ab78c/external/bazel_tools/tools/build_defs/repo/git_worker.bzl", line 190, column 9, in _error
fail("error running '%s' while working with @%s:\n%s" % (command_text, name, stderr))
Error in fail: error running 'git init /root/.cache/bazel/_bazel_root/cb5c4cd825dbca79ce4440ddff3ab78c/external/rules_python' while working with @rules_python:
src/main/tools/process-wrapper-legacy.cc:80: "execvp(git, ...)": No such file or directory
ERROR: no such package '@rules_python//python': error running 'git init /root/.cache/bazel/_bazel_root/cb5c4cd825dbca79ce4440ddff3ab78c/external/rules_python' while working with @rules_python:
src/main/tools/process-wrapper-legacy.cc:80: "execvp(git, ...)": No such file or directory
INFO: Elapsed time: 0.159s
INFO: 0 processes.


Didn't list all modded moons but a few.

Besides, I installed 4 moons(Orion, Wateridge, Celest, Aquatis) from LethalExpansionCore and LEDefaultModules but they didn't display in the terminal like the former patch ; I played the same profile yesterday and everything worked properly as well.

These moons are loaded and detectable but unable to display in the terminal.

solved. Thank for ur timely

怎么解决的，我也这样


Add goo.gl on URL scheme prefix

A way to short a little more the URL sent by Beacon

Hi adonaiarruda. The new Bluetooth 5 specification has much more room for how much data can be advertised -- https://blog.bluetooth.com/exploring-bluetooth5-whats-new-in-advertising -- so there should be less reason to fight for space with URL shorteners.
(That aside, this is more of a feature request than a pull request. The current specification reflects what many manufacturers have implemented. Changing it means creating a new version of the Eddystone specification, persuading manufacturers to implement it, etc. etc.)

Hey

How are u


Termination Plan is not invoked on delete request of service template instance

Instance data is removed from internal state of container but the actual termination plan on BPS is never called.

Fixed within UI and Container


Invalid interval string in Airflow Cluster Dashboard

I see "Invalid interval string, expecting a number followed by one of "Mwdhmsy"" in Executor open slots, what does it mean?

How can I add selection of the env like the one in "Airflow cluster dashboard" also in "Airflow DAG dashboard"

You should add templating variable in dashboard settings, in "Variables". Your variable should be something like label_values(airflow_id)

I see Invalid interval string, expecting a number followed by one of "Mwdhmsy" in Executor open slots, what does it mean?

Not sure what it is, check your Prometheus query, it should return proper series.


Config path

Pull request checklist
Make sure you:

[x] Signed the Contributor License Agreement
[x] Followed the commit message guidelines

For non-trivial changes, please make sure you also:

[x] Added/Updated related documentation.
[x] Added/Updated related tests.

Short description of the change(s)

Add support for paths in the configuration
Rename getRuleName to getRulePath

This is finally ready to review 🎉

@alrra seems to be a platform issue with a couple of the tests. Looking into it.

@alrra, @sarvaje this should be (hopefully) ready to review.

@alrra @sarvaje feedback addressed and conflict solved 🎉

Merged as https://github.com/sonarwhal/sonarwhal/commit/1e2e54f8c9a46a1d11df219c8c7f2ac6b33c1a72 & https://github.com/sonarwhal/sonarwhal/commit/232564d4e80b163208b0295faacaa98e53a07da4 .


fixing issues

Fixes #
Proposed Changes
changed line86 in .spectral.yml
from
"/^([A-Z][a-z0-9]-)*([A-Z][a-z0-9])+/"
to
"^[A-Z][a-z0-9]*(?:-[A-Z][a-z0-9]*)*$"

File was auto formatted, will re-fix the issue


Fix yunet return negative coordinates

Yunet returns negative coordinates if it thinks part of the detected face is outside the frame. This fixes that by reset the start point to zero.

pylint fails. would you please fix them.
************* Module deepface.detectors.YunetWrapper
deepface/detectors/YunetWrapper.py:58:8: R1731: Consider using 'x = max(x, 0)' instead of unnecessary if block (consider-using-max-builtin)
deepface/detectors/YunetWrapper.py:60:8: R1731: Consider using 'y = max(y, 0)' instead of unnecessary if block (consider-using-max-builtin)

also, adding a comment would be good in that line why we did it.

also, adding a comment would be good in that line why we did it.

done

This time fails because of this:
deepface/detectors/YunetWrapper.py:59:0: C0301: Line too long (105/100) (line-too-long)

It was complaining about the wrong line but the new commit should fix it.


add presentation section for July 13th

Just a small section for presentations (per Wranglin' guidelines). Communicated with Presenters to confirm titles and format (obtained 50% confirmation). I'll likely submit an identical request immediately after the meeting to update the section to something like "Our last meeting featured the following presentations: " and our next meeting's presentations are to be announced."
This is my first PR and I feel like I missed something regarding branches. Let me know if I need to polish it up and thanks for your time!

LGTM!  1 pro tip, however: you should generally make a new branch for a pull request -- don't use the same branch name as the target branch name, because then it's a little trickier to keep in sync with the upstream target branch.
But this is fine for this PR -- I'll merge this, and then you'll have your main back again.


Incorrect Aerosol Optical Depth

Wavelength-dependent Aerosol Optical Depths (AODs) are computed incorrectly due to aerosol_monochromatic_optics_wavelength being read as a list of integers as opposed to reals by the GOCART2G gridded component.
This array of wavelengths (channels) are provided in units of m and therefore read as 0s:
aerosol_monochromatic_optics_wavelength: 4.7e-7 5.5e-7 6.7e-9 8.7e-7

These wavelengths are further multiplied by 1.e-09 internally before computing AODs using the diagnostic Mie lookup table.
I suggest entering the aerosol_monochromatic_optics_wavelength in units of nm for consistency with other settings and updating the internal code appropriately. The configuration label may also be updated as aerosol_monochromatic_optics_wavelength_in_nm to reflect this change and to improve consistency. For example:
wavelengths_for_profile_aop_in_nm: 470 550 670 870
wavelengths_for_vertically_integrated_aop_in_nm: 470 550 670 870
aerosol_monochromatic_optics_wavelength_in_nm: 470 550 670 870

@rmontuoro  Agreed.   I know @amdasilva had strong opinions on whether things were in nm or m.   I thought he preferred nm, so I'm a bit surprised the other form survived review.
Do you have a PR, or should I assign this to @weiyuan-jiang ?

@tclune - PR #65 addresses this issue. Please let me know your preference regarding renaming the config label.

rc files specify wavelengths in nm, internally calculations use m. This issue has been dealt with.


Added test SC17020 - Revoke All Sessions from System Console

Summary
Added test to verify Revoke All Sessions functionality in the System Console. This includes the following steps:

Login as System Admin and navigate to Users page.
Check if the Revoke All Sessions button is displayed.
Click on the Revoke All Sessions button. A message "This action revokes all sessions in the system. All users will be logged out from all devices. Are you sure you want to revoke all sessions?" should be displayed.
Click on Cancel in the confirmation message. The user's session should still be active.
Click on the Revoke All Session button and confirm.
Check if the current user is logged out and redirected to the login page.

Ticket Link
JIRA Ticket: MM-17020
Related Pull Requests
None
Note
This test expects the changes mentioned in the PR to be merged to the master branch.
https://github.com/mattermost/mattermost-webapp/pull/3033
Until the PR is merged, it could be tested on the PR instance. Credentials for sysadmin user is mentioned here and needs to be changed in the file cypress/fixtures/users.json

@srkgupta Added comments, let me know if you have any questions.
I also want to note that this new test should NOT be an issue when we start parallelizing our tests runs. They way we are leaning towards is that each folder will run it's tests serially in their own environment (e.g. Mattermost instance), so I don't think revoking all users will impact tests downstream from this one.
Lastly, it may be worthwhile to have a test though where we are logged in with a plain jane user, and then we hit the new revoke all users API endpoint and then verify that the user get's logged out? That would cover both the admin and end user experiences, IMO.

Hi @thekiiingbob,
Regarding point 1, we should somehow figure out that this test is running simultaneously and would not work when running it in parallel. This is because, when this test is executed, all the users who are logged into to the instance will be logged out whenever we issue the request to Revoke All Sessions.
Regarding point 2, since multiple sessions were not supported by Cypress,  I was breaking my heads trying to verify this. But thanks to your input, I was able to handle this by issuing an external request. The test has been updated accordingly.

Hi @thekiiingbob
Updated the test based on your comments.


Add functional test cases for Linux platform

Run ninja / tests etc.
similar to what the template generator does

I added a ninja invocation here: https://github.com/vkottler/yambs/commit/e54ae551c731006cb5b72afed7bea701228bb465#diff-49eb4306b228afe8e922619dde44c009f7dcb045cc19da65587cc776ea79d750
I think that's good enough for now.


nixpkgs.overlays not working inside NixOS containers

Describe the bug
Since the introduction of the containers.*.pkgs option in  https://github.com/NixOS/nixpkgs/pull/85570 on master and https://github.com/NixOS/nixpkgs/pull/88402 for release-20.03, overlays defined in containers with nixpkgs.overlays are no longer working.
To Reproduce
Execute this test: https://github.com/NixOS/nixpkgs/pull/88619/commits/0eec48c89a147ccc057d9512b6b51aef104ae952
Expected behavior
Overlays should work inside the containers.
Notify maintainers
@adisbladis (author of the change)
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.39, NixOS, 20.03.1942.6d68b920eb2 (Markhor)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.4`
 - channels(kea): `""`
 - channels(root): `"home-manager-20.03, nixos-20.03.1942.6d68b920eb2, nixos-19.09-19.09.2503.2efedf8fc74, nixos-unstable-20.09pre226148.0f5ce2fac0c"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
- containers.*.pkgs
- nixpkgs.overlays

# a list of nixos modules affected by the problem
module:
- nixos/modules/virtualisation/containers.nix

I propose to revert the change for the current stable release-20.03: https://github.com/NixOS/nixpkgs/pull/88619
The option seems useful and should be kept on master for the next release, but it needs to be fixed to work with overlays.

It appears 20.09 is affected by this.  While trying to upgrade to 20.09 my containers that use personal overlays fail to build.
# nixos-rebuild test
building Nix...
building the system configuration...
error: attribute 'fuzzyd' missing, at /etc/nixos/overlays/fuzzyd/modules/fuzzyd.nix:37:17
(use '--show-trace' to show detailed location information)

Looking at the git history for tag 20.09, I see ab37d7e in the history, but not the revert commit a808fe4, and commit logs for nixos/modules/virtualization/containers.nix does not include a fix for this bug.
@jonringer

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/20-09-unable-to-use-overlay-in-containers/10442/2


add in-domain documentation for Artworld

Chronicle v0.7 supports generating domain-specific documentation from in-domain doc comments!

CHRON-405
Relates to: CHRON-145
Signed-off-by: Joseph Livesey<EMAIL_ADDRESS>

What's a good way to render this? The GraphQL playground just shows the markup and cargo doc doesn't seem to be building it for me, perhaps it needs some special option? So far I'm resorting to opening main.rs in VS Code and hovering.

What's a good way to render this? The GraphQL playground just shows the markup and cargo doc doesn't seem to be building it for me, perhaps it needs some special option? So far I'm resorting to opening main.rs in VS Code and hovering.

I don't know you mean about the client and markup. If you look in the docs and schema within the client the docs will be in those.

What's a good way to render this? The GraphQL playground just shows the markup and cargo doc doesn't seem to be building it for me, perhaps it needs some special option? So far I'm resorting to opening main.rs in VS Code and hovering.

What's a good way to render this? The GraphQL playground just shows the markup and cargo doc doesn't seem to be building it for me, perhaps it needs some special option? So far I'm resorting to opening main.rs in VS Code and hovering.

You can run RUST_LOG=debug cargo run --bin chronicle --features inmem -- serve-api from Chronicle, having pasted in whatever domain you'd like.

Aha, thank you, that is helpfully illustrative.
I was curious about the intended targets because there are a few possibilities and I wondered if the docs' markdown suited all the relevant parsers' dialects or how readily we can notice if not.
For reviewing it all, it's helpful to have a not-piecemeal view of it rendered according to the intended Markdown dialect rather than having to click separately through it all but perhaps there's no alternative.
main.rs is now full of nice markup that VS Code renders decently on hover but I couldn't easily see how to collect together into target/doc/ - from what you say, my guess is, that's not an intended destination anyway.
The Docs tab in the GraphQL playground shows it a bit ropily in places, e.g.,

Altair does better in some places but even there we get rendering like,

which I think is probably meant to be a bulleted list.
So, that's why I wondered how to see a good overview of it all in the intended manner.
I don't know if some of the rendering failures are of text that is rendering better in other situations, reused in other places, and that makes it worth leaving as-is anyway.


Copy annotations color bug

to replicate:

load data.xlsx
data.xlsx

suggest annotation

add the property block

save t2wmlz file

once again, load dataset.xlsx

select "Copy annotation". choose previouly saved file.

the property block is colored purple instead of orange, and initially seems to be treated like a qualifier block -- no partial csv preview. i clicked it, it opened with "property" selected in role dropdown. i switched away from property and then back to property, and this successfully triggered the partial csv loading, but the block remained purple colored.

data.xlsx

Yeah, I've seen this happen before as well, can't place where it's coming from, will take a look tomorrow.

I can't reproduce this one, is it possible that it was recently fixed a long with other issues?

it's possible. I'll close it, and reopen it if I see it happen again.


PWA Assets generation on the fly

    VitePWA({
      pwaAssets: {
        image: 'logo.png',
        includeHtmlHeadLinks: true,
        overrideManifestIcons: true
      },
    })
  ]

This config doesn't produce image files in build folder.
Please tell be what I doing wrong.

In dev server, the images are not generated, only when running the build command. If running the build command and png files not being generated I'll check what's the problem.

Yes, I use vite build command.

In the meantime try using external pwa assets config file: https://github.com/vite-pwa/vite-plugin-pwa/tree/main/examples/assets-generator

It seems we've a problem when resolving the pwa assets configuration, the disabled flag is false and so the module not being loaded.

@LoranRendel released new v0.19.3, should be fixed with this version


Proxy should check that contract exists at the configured address

fixed in https://github.com/raiden-network/microraiden/pull/208


python3Packages.pysonos: 0.0.45 -> 0.0.46

Motivation for this change
Update to latest upstream release 0.0.46
Change log: https://github.com/amelchio/pysonos/releases/tag/v0.0.46

Related Home Assistant change: https://github.com/home-assistant/core/pull/50544
Target Home Assistant release: current, only dependency update no changes

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 122880 at 6b788d75 run on x86_64-linux 1

1 package failed to build:

home-assistant

2 packages built successfully:

python38Packages.pysonos
python39Packages.pysonos

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@GrahamcOfBorg test home-assistant


Try using Cubatura format.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.


Normalize line endings

Follow this instruction: https://help.github.com/articles/dealing-with-line-endings/
Without this, you will have problem when install from git:
bower showdown#053288f2feb6b1db36044b212bb24294fb305df1          ECMDERR Failed to execute "git checkout 053288f2feb6b1db36044b212bb24294fb305df1", exit code of #1 error: Your local changes to the following files would be overwritten by checkout: 	license.txt Please, commit your changes or stash them before you can switch branches. Aborting

Additional error details:
error: Your local changes to the following files would be overwritten by checkout:
	license.txt
Please, commit your changes or stash them before you can switch branches.
Aborting

This is weird. Can you help me, step by step, reproducing the issue?

On Linux, this can be reproduced by cloning the repo to your machine, you will see the license.txt is modified and cannot revert its change.

Might be related to this commit: https://github.com/showdownjs/showdown/commit/413511c73125907d31d0050b8f0d340efa0cb9f2


CurrentContent attribute and value-resolver

(Closes #78)
--
Introduces new attribute and value-resolver to apply the current IPublishedContent to a POCO property.
An example...
public class MyModel
{
    [CurrentContent]
    public MyOtherModel MyProperty { get; set; }
}

This would be the equivalent of: foo.MyProperty = content.As<MyOtherModel>().

Just to clarify, there are two things going on here.
The [CurrentContent] attribute sets the properties resolved value as the current contents IPublishedContent. The things that then converts the value into the end entity type (MyOtherModels in Lees example) is because a new clause has been added to the main ditto conversion code that if the raw value type is IPublishedContent and no better converter could be found for the resulting type, then it falls back to doing a Ditto .As() call.
A couple of things that play on my mind are, should the CurrentContent attribute be something more like [CurrentContentAs] and have that call .As() internally, such that it's all self contained and explicit, and doesn't rely on a "magic" fallback (one argument could be, just using CurrentContent could result in another type converter being found to be a better match and being used instead of .As() thus producing unexpected results?, so CurrentContentAs is explicit that .As() is used).
Maybe we have two attributes
[CurrentContent]
public IPublishedContent Node { get; set; }

[CurrentContentAs]
public MyModel MyProp { get; set; }

The other thing is that I can't decide if the magic .As() fallback in the ditto conversion code should be there? It does make sense, that if it can't find a better way to convert, and the type is IPublishedContent, then it does it's best to return the type you asked for, it's just you didn't explicitly tell it to use Ditto to resolve it.


[build] Support 64bit APK building

As detailed in this post, future Android apps should target 64bit architectures (aarch64) and API level 26. GCC compiler is being removed from Android NDK, so, CLang is becoming the default compiler.
I started porting raylib Android compilation to new requirements but it doesn't seem to be a smooth transition, as expected (not to be).
Some flags have been added to raylib source compilation to -target aarch64, despite some small issue on mini_al trying to MAL_ENABLE_OSS, it compiled ok.
Problems pop-up when generating APK, code compiled ok but linker through a bunch of errors:
First issue, hundreds of undefined references:
...
core.c:(.text.Vector3Transform+0x28): undefined reference to `__mulsf3'
core.c:(.text.Vector3Transform+0x38): undefined reference to `__mulsf3'
core.c:(.text.Vector3Transform+0x44): undefined reference to `__addsf3'
core.c:(.text.Vector3Transform+0x54): undefined reference to `__mulsf3'
core.c:(.text.Vector3Transform+0x60): undefined reference to `__addsf3'
core.c:(.text.Vector3Transform+0x70): undefined reference to `__addsf3'
core.c:(.text.Vector3Transform+0x80): undefined reference to `__mulsf3'
core.c:(.text.Vector3Transform+0x90): undefined reference to `__mulsf3'
core.c:(.text.Vector3Transform+0x9c): undefined reference to `__addsf3'
core.c:(.text.Vector3Transform+0xac): undefined reference to `__mulsf3'
core.c:(.text.Vector3Transform+0xb8): undefined reference to `__addsf3'
core.c:(.text.Vector3Transform+0xc8): undefined reference to `__addsf3'
core.c:(.text.Vector3Transform+0xd8): undefined reference to `__mulsf3'
core.c:(.text.Vector3Transform+0xe8): undefined reference to `__mulsf3'
core.c:(.text.Vector3Transform+0xf4): undefined reference to `__addsf3'
core.c:(.text.Vector3Transform+0x104): undefined reference to `__mulsf3'
core.c:(.text.Vector3Transform+0x110): undefined reference to `__addsf3'
core.c:(.text.Vector3Transform+0x120): undefined reference to `__addsf3'
...

It coudl be solved just adding -static to linkage (it seemed not to link with math library properly) but after that...
Second issue: Can not link with several libraries:
C:/android-sdk/build-tools/26.0.2/aapt package -f -m -S android.standard_game/res -J android.standard_game/src -M android.standard_game/AndroidManifest.xml -I C:/android-sdk/platforms/android-21/android.jar
C:/android_toolchain_arm64_api21/bin/aarch64-linux-android-clang -c ..\../src/external/android/native_app_glue/android_native_app_glue.c -o android.standard_game/obj/native_app_glue.o -std=c99 -target aarch64 -ffunction-sections -funwind-tables -fstack-protector-strong -fPIC -Wall -Wa,--noexecstack -Wformat -Werror=format-security -no-canonical-prefixes -DANDROID -DPLATFORM_ANDROID -D__ANDROID_API__=21
C:/android_toolchain_arm64_api21/bin/aarch64-linux-android-ar rcs android.standard_game/obj/libnative_app_glue.a android.standard_game/obj/native_app_glue.o
C:/android_toolchain_arm64_api21/bin/aarch64-linux-android-clang -c standard_game.c -o android.standard_game/obj/standard_game.o -I. -I..\../release/include -I..\../src/external/android/native_app_glue -std=c99 -target aarch64 -ffunction-sections -funwind-tables -fstack-protector-strong -fPIC -Wall -Wa,--noexecstack -Wformat -Werror=format-security -no-canonical-prefixes -DANDROID -DPLATFORM_ANDROID -D__ANDROID_API__=21 --sysroot=C:/android_toolchain_arm64_api21/sysroot
C:/android_toolchain_arm64_api21/bin/aarch64-linux-android-clang -c screens/screen_logo.c -o android.standard_game/obj/screens/screen_logo.o -I. -I..\../release/include -I..\../src/external/android/native_app_glue -std=c99 -target aarch64 -ffunction-sections -funwind-tables -fstack-protector-strong -fPIC -Wall -Wa,--noexecstack -Wformat -Werror=format-security -no-canonical-prefixes -DANDROID -DPLATFORM_ANDROID -D__ANDROID_API__=21 --sysroot=C:/android_toolchain_arm64_api21/sysroot
C:/android_toolchain_arm64_api21/bin/aarch64-linux-android-clang -c screens/screen_title.c -o android.standard_game/obj/screens/screen_title.o -I. -I..\../release/include -I..\../src/external/android/native_app_glue -std=c99 -target aarch64 -ffunction-sections -funwind-tables -fstack-protector-strong -fPIC -Wall -Wa,--noexecstack -Wformat -Werror=format-security -no-canonical-prefixes -DANDROID -DPLATFORM_ANDROID -D__ANDROID_API__=21 --sysroot=C:/android_toolchain_arm64_api21/sysroot
C:/android_toolchain_arm64_api21/bin/aarch64-linux-android-clang -c screens/screen_options.c -o android.standard_game/obj/screens/screen_options.o -I. -I..\../release/include -I..\../src/external/android/native_app_glue -std=c99 -target aarch64 -ffunction-sections -funwind-tables -fstack-protector-strong -fPIC -Wall -Wa,--noexecstack -Wformat -Werror=format-security -no-canonical-prefixes -DANDROID -DPLATFORM_ANDROID -D__ANDROID_API__=21 --sysroot=C:/android_toolchain_arm64_api21/sysroot
C:/android_toolchain_arm64_api21/bin/aarch64-linux-android-clang -c screens/screen_gameplay.c -o android.standard_game/obj/screens/screen_gameplay.o -I. -I..\../release/include -I..\../src/external/android/native_app_glue -std=c99 -target aarch64 -ffunction-sections -funwind-tables -fstack-protector-strong -fPIC -Wall -Wa,--noexecstack -Wformat -Werror=format-security -no-canonical-prefixes -DANDROID -DPLATFORM_ANDROID -D__ANDROID_API__=21 --sysroot=C:/android_toolchain_arm64_api21/sysroot
C:/android_toolchain_arm64_api21/bin/aarch64-linux-android-clang -c screens/screen_ending.c -o android.standard_game/obj/screens/screen_ending.o -I. -I..\../release/include -I..\../src/external/android/native_app_glue -std=c99 -target aarch64 -ffunction-sections -funwind-tables -fstack-protector-strong -fPIC -Wall -Wa,--noexecstack -Wformat -Werror=format-security -no-canonical-prefixes -DANDROID -DPLATFORM_ANDROID -D__ANDROID_API__=21 --sysroot=C:/android_toolchain_arm64_api21/sysroot
C:/android_toolchain_arm64_api21/bin/aarch64-linux-android-clang -o android.standard_game/lib/arm64-v8a/libmain.so  android.standard_game/obj/standard_game.o  android.standard_game/obj/screens/screen_logo.o  android.standard_game/obj/screens/screen_title.o  android.standard_game/obj/screens/screen_options.o  android.standard_game/obj/screens/screen_gameplay.o  android.standard_game/obj/screens/screen_ending.o -shared -I. -I..\../release/include -I..\../src/external/android/native_app_glue -Wl,-soname,libmain.so -Wl,--exclude-libs,libatomic.a  -Wl,--build-id -Wl,--no-undefined -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -Wl,--warn-shared-textrel -Wl,--fatal-warnings  -u ANativeActivity_onCreate -L. -Landroid.standard_game/obj -Landroid.standard_game/lib/arm64-v8a -LC:/android_toolchain_arm64_api21\sysroot\usr\lib -static -lraylib -lnative_app_glue -llog -landroid -lEGL -lGLESv2 -lOpenSLES -lm -ldl -lc
C:\android_toolchain_arm64_api21\bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/bin\ld: cannot find -llog
C:\android_toolchain_arm64_api21\bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/bin\ld: cannot find -landroid
C:\android_toolchain_arm64_api21\bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/bin\ld: cannot find -lEGL
C:\android_toolchain_arm64_api21\bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/bin\ld: cannot find -lGLESv2
C:\android_toolchain_arm64_api21\bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/bin\ld: cannot find -lOpenSLES
clang60.exe: error: linker command failed with exit code 1 (use -v to see invocation)

It's weird because required libraries are available in android_toolchain_arm64_api21\sysroot\usr\lib, library path is configured properly and I checked libraries were ELF64.

Does adding -isysroot android_toolchain_arm64_api21/sysroot help?

Already added, also path directly specified with -LC:/android_toolchain_arm64_api21\sysroot\usr\lib, it's very weird...

Just a side note: wouldn't you think replacing GCC everywhere with CLang would be better for stability?

@gen2brain you're probably right, I was trying to link with libc (or current equivalent for Android... that I don't really know what it is in NDK r17!). Already provided right API toolchain headers.
Actually, standalone toolchain is just an stripped version of current NDK for an specific architecture and API level (2GB full NDK vs 500MB standalone). About android_native_app_glue, that's a good idea.

@raysan5 about the standalone toolchain, I also prefer to install it somewhere in /opt and just reference that, compile external libs there etc. but, without whole NDK you cannot install standalone t., there is no such option for download.
And there were problems before with NDK versions, when they switched from bash to python tool for that, then unified headers were added etc., everything depends on some version. With ANDROID_NDK_HOME or similar, requirement is just to extract archive and set env.

ok, I found the issue. I was compiling raylib with compiler option -mgeneral-regs-only that was causing:

Generate code which uses only the general-purpose registers. This will prevent the compiler from using floating-point and Advanced SIMD registers but will not impose any restrictions on the assembler.

Consequently, it failed on final library linkage (my_game.so). Corrected in commit https://github.com/raysan5/raylib/commit/1f0cc57ec7e4c56baf013ecaaab2050282b0733b


Enable Graphs to be constructed from URLs

It would be useful to be able to create a Graph by providing URLs for the schemas, properties and view.

This should be done after gh-100.

Merged into develop.


colmena crashes on paths containing '@'

[nix-shell:~/nix]$ colmena repl
error: '/home/user@domain/nix' is not a valid URL
[ERROR] -----
[ERROR] Operation failed with error: Child process exited with error code: 1
Hint: Backtrace available - Use `RUST_BACKTRACE=1` environment variable to display a backtrace

[nix-shell:~/nix]$ colmena repl -f .
[INFO ] Using configuration: /home/user@domain/nix
Lix 2.90.0-rc1
Type :? for help.
warning: ignoring error writing repl history to<EMAIL_ADDRESS>No such file or directory
error: syntax error, unexpected '@', expecting ';'
       at /run/user/1234/colmena-repl-N0PAvs.nix:1:130:
            1| with builtins; let eval = import /run/user/1234/colmena-assets-3t9Yu2/eval.nix; hive = eval { rawHive = import /home/user@domain/nix; colmenaOptions = import /run/user/1234/colmena-assets-3t9Yu2/options.nix; colmenaModules = import /run/user/1234/colmena-assets-3t9Yu2/modules.nix; }; in  hive.introspect (x: x)
             |                                                                                ^
[ERROR] -----
[ERROR] Operation failed with error: Child process exited with error code: 1
Hint: Backtrace available - Use `RUST_BACKTRACE=1` environment variable to display a backtrace

I think this is a duplicate of #204 !


Hotfix [0.2] discount priority

discount should apply from high to low
priority => 1: Low, 5: Medium, 10: High

Has something happened by changing the order that's caused the tests to fail? Just wondering if there is a deeper issue.

Has something happened by changing the order that's caused the tests to fail? Just wondering if there is a deeper issue.

the ordering definitely gonna impact the outcome of the calculation, but before fixing the test, we need to establish whether the current order is wrong

Has something happened by changing the order that's caused the tests to fail? Just wondering if there is a deeper issue.

the ordering definitely gonna impact the outcome of the calculation, but before fixing the test, we need to establish whether the current order is wrong

Yeah I think we do want to order High > Medium > Low

Has something happened by changing the order that's caused the tests to fail? Just wondering if there is a deeper issue.

the ordering definitely gonna impact the outcome of the calculation, but before fixing the test, we need to establish whether the current order is wrong

Yeah I think we do want to order High > Medium > Low

should be ready now, added orderBy('id') for when discount is same priority


refactor DIA-NN step 1

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!

[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.

[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

@vdemichev This is the command for the library generation we will be using.
diann   `cat library_config.cfg` \\
            --fasta ${fasta} \\
            --fasta-search \\
            ${min_pr_mz} \\
            ${max_pr_mz} \\
            ${min_fr_mz} \\
            ${max_fr_mz} \\
            --missed-cleavages $params.allowed_missed_cleavages \\
            --min-pep-len $params.min_peptide_length \\
            --max-pep-len $params.max_peptide_length \\
            --min-pr-charge $params.min_precursor_charge \\
            --max-pr-charge $params.max_precursor_charge \\
            --var-mods $params.max_mods \\
            --threads ${task.cpus} \\
            --predictor \\
            --verbose $params.diann_debug \\
            --gen-spec-lib \\
            |& tee diann.log

@daichengxin maybe you can put in the conf/dia_test the maximun number of modifications to 2. to speed up the process.

@vdemichev This is the command for the library generation we will be using.
diann   `cat library_config.cfg` \\
            --fasta ${fasta} \\
            --fasta-search \\
            ${min_pr_mz} \\
            ${max_pr_mz} \\
            ${min_fr_mz} \\
            ${max_fr_mz} \\
            --missed-cleavages $params.allowed_missed_cleavages \\
            --min-pep-len $params.min_peptide_length \\
            --max-pep-len $params.max_peptide_length \\
            --min-pr-charge $params.min_precursor_charge \\
            --max-pr-charge $params.max_precursor_charge \\
            --var-mods $params.max_mods \\
            --threads ${task.cpus} \\
            --predictor \\
            --verbose $params.diann_debug \\
            --gen-spec-lib \\
            |& tee diann.log

@vdemichev we use something called SDRF from HUPO-PSI that containers the annotations of the modifications, check an example for this CI/CD here: https://github.com/nf-core/test-datasets/blob/quantms/testdata/dia_ci/PXD026600.sdrf.tsv this is parse and converted into the library_config.cfg file that is pass by command to diann.
Other parameters can be seen here https://github.com/bigbio/quantms/blob/dev/nextflow.config.


New inline imports

Summary
Implements the new design for inline imports that originated from Proposal: Module and Package Changes and was later refined in multiple Zulip discussions.
New syntax
Imports are defs now:
# top-level
import pf.Stdout

# alias
import json.Core as Json

# exposed names
import pf.Task exposing [await]

# ingested files
import "data.json" as data : List U8

query =
    # nested inside defs or expressions
    import pg.Sql exposing [select, where, like]
    ...

expect
    # nested inside expectations
    import TestHelper
    ...

In this iteration, module header imports are internally converted to the new import defs, so they are still supported. An upcoming PR will introduce the new module headers, and running roc format will upgrade all the syntax automatically.
Module system improvements
In order to support the new inline imports, I had to rewrite bigs parts of load and can, and in doing so many general improvements to modules were made:

Apps don't have to import package modules that are only used transitively.
#5477
Unused import warnings now differentiate between unqualified and qualified references. Previously, we wouldn't report an unused exposed name even if it was only used through a qualified reference.
Unexposed type aliases cannot be imported anymore
Warning for builtin imports without an exposing keyword, and for builtin types that appear in exposing:
#4096
When a name in exposing conflicts with something else in scope, we will now report this instead of crashing
Errors for all the kinds of module name conflicts

@ayazhafiz Thanks for such a great review! I addressed all the actionable comments. I liked your idea of moving References to Env, and I will try that in a future PR.
When you have some time I'd love your feedback on the load changes. I'm going to start working on the headers PR now.


Subtitle Error

Hi,
When using the subtitles on Song 84 (Childrens version for meeting of Dec 17-23) each set of subtitles is preceded by {\an7} throughout the video.
Thanks for your hardwork on these apps.
Jon

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Windows version
Other important information about your environment

@jsquiggz Thanks. The codes are ASS tags (not standard srt), but many players support some of them. I will modify OnlyM to remove the codes.

@jsquiggz Fixed

Great. Thank you so much!!!
On Fri, 16 Nov 2018, 17:45 Antony Corbett<EMAIL_ADDRESS>wrote:

@jsquiggz https://github.com/jsquiggz Fixed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AntonyCorbett/OnlyM/issues/105#issuecomment-439471473,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AnmOOmJSRZMRD-HNMMYEH5uJquuELOh-ks5uvvmagaJpZM4YaG2T
.

Hi. Question to you @jsquiggz …
Were you get the sub file? when I had a look on the website I couldn't find it.. 😅

Hi,
I downloaded them from tv.jw.org. i have ticked the "display subtitles when
available" box.
On Mon, 10 Dec 2018, 17:57 TalkingDragon<EMAIL_ADDRESS>wrote:

Hi. Question to you @jsquiggz https://github.com/jsquiggz …
Were you get the sub file? when I had a look on the website I couldn't
find it.. 😅
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AntonyCorbett/OnlyM/issues/105#issuecomment-445910044,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AnmOOt0PIUhe_Tv4so2UAQZdpJ5N5GGmks5u3qB3gaJpZM4YaG2T
.


chore(main): release react 0.0.20-experimental

:robot: I have created a release beep boop
0.0.20-experimental (2024-11-13)
🧹 Chore

main: release react 0.0.19-experimental (8332a4b)
release main (99afb8e)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

react-v0.0.20-experimental
:sunflower:


Add Weave as a network option.

Feature Request
Feature
It would be nice to be able to choose Weave Net as a networking option on cluster creation.
Tradeoffs
I know it's just another networking option, but it may well be an important one.  It offers container networking encryption, which isn't offered by calico or flannel, as well as policy driven isolation, that I think fit well with the Typhoon ethos.  It's maintained and open sourced by a company, meaning no overhead  over and above versioning.

I'm aware of Weave. I remain displeased with its product upsell focus and its obfuscated/missing/disorganized materials. Its a chore just to audit and evaluate it. Let alone add and maintain. Signup for Weave Cloud to get a token to see one of the Kubernetes manifests with scraping? No thanks.
Right now, I would not use Weave or recommend it. I don't have plans to add it. That said, I'm sure it will improve over time. It can be re-evaluated in future.
Note: Iff another CNI provider is supported (maintenance burden) Cilium is the leading next candidate.


Better test the media types formatter

These should be integration tests and test the various constructors.

Done in #39


PG::ConnectionBad: FATAL:  role "my_role" does not exist

Hi,
I can run the task which accesses PostgreSQL database using rake command without any error.
rake "my_namespace:my_task"
But when I run the task with whenever, I am getting PG::ConnectionBad: FATAL:  role "my_role" does not exist error.
set :output, 'log/whenever.log'
every 1.minute do
  rake "my_namespace:my_task"
end

Has anyone had this issue before?

Where is my_role defined?
This isn’t a whenever bug so I’m going to close the issue.

Hi @benlangfeld
Thanks for reaching out.
I can run the task without creating my_role role but when running the task with whenever it requires that my_role role.
I am not sure why this requires.

Because you have configured your application wrong in some way. Grep your source code for my_role

I just checked with grep my_role but nothing was there.
I am just weird since I can the task manually by rake "my_namespace:my_task"
And in whenever schedule.rb, used this same command.


Fix host-components systemd usage

From enarx created by MikeCamel: enarx/enarx#849
Description
The existing use of systemd does not follow good practice (including the README.md)  In particular:

the example in the README relies on pkill - this should be better
the<EMAIL_ADDRESS>file could be better sited (in, for instance, ~/.config/systemd/user/* or ~/.local/share/systemd/user/*
reloading a newly compiled version of the binary should only require 'systemctl try-restart 'enarx-keep@*', not removing, relinking, etc.
the service file redirects (possibly unnecessarily) via Environment
logging and error-handling should be better handled (e.g. with 'StandardOutput=file:/home/mike/keeploader-%i.log')

Note that it seems that the redirect of the params via Environment may be required: leaving for now.


Enum fields are yelling.

They currently yell (GENERATIONS) when they should be quiet (Generations).  Clippy doesn't flag this b/c it doesn't look like a CamelCase violation.

This issue is there for both TimeUnits and SizeFunction.

closed via #91


Feature Request: parallel packer build

Is your feature request related to a problem? Please describe.
parallel image build
Describe the solution you'd like
build {
sources = [
"source.ibmcloud-vpc.ubuntu-focal",
"source.ibmcloud-vpc.ubuntu-jammy"
]
.
.
}
Describe alternatives you've considered
sequential build as of now
Additional context
packer  parallel build seems not working, maybe I can request as a feature in github later, For example:
build {
  sources = [
    "source.ibmcloud-vpc.ubuntu-focal",
    "source.ibmcloud-vpc.ubuntu-jammy"
  ]
.
.
}

The packer plugin creates the same directory for both ssh key, and one of the build instance fails as below, then the failed instance delete the ssh key pair folder/files:
==> Some builds didn't complete successfully and had errors:
--> ibmcloud-vpc.ubuntu-jammy: Packer experienced an authentication error
when trying to connect via SSH. This can happen if your username/password are
wrong. You may want to double-check your credentials as part of your
debugging process. original error: ssh: handshake failed: ssh: unable to
authenticate, attempted methods [none publickey], no supported methods remain

==> Builds finished. The artifacts of successful builds are:
--> ibmcloud-vpc.ubuntu-focal: Image Name: ubuntu-0-1-0-ba54-focal || Image
ID: r006-5f4592f3-3032-4d44-a035-c83b356645d6

Issue was solved on v3.0.1


Yor Doesn't Pick Up Tags When Resource Field Removed In Terraform

Describe the bug
Yor will not pick up that a resource was updated if you remove one of its fields.
To Reproduce

Establish a resource in your terraform file.  When you run yor, it will detect the resource and apply the yor tags.

resource "aws_iam_user" "supercooluser" {
  name = "SuperCoolTesting"
  path = "/verycoolpath/"
}

resource "aws_s3_bucket" "demo3_test_bucket" {
  bucket        = "demo3_test_bucket"
  acl           = "private"
  force_destroy = true
}

Edit that resource to remove one of the optional attributes.  In the example above, you can remove the path attribute for the aws_iam_user resource and the force_destroy attribute for the aws_s3_bucket resource

resource "aws_iam_user" "supercooluser" {
  name = "SuperCoolTesting"
  tags = {...}
}

resource "aws_s3_bucket" "demo3_test_bucket" {
  bucket        = "demo3_test_bucket"
  acl           = "private"
  tags        = {...}
}

Expected behavior
The expected behavior is that your would change the git_commit_id since the resource has been changed.  It does not though
Screenshots

Desktop (please complete the following information):

OS: Ubuntu 22.0 LTS
Yor Version: v0.1.178

This is an interesting one. Yor bases itself on running git blame, and for something that disappears... Yes I see the issue.
We basically iterate over the existing lines and set the history for them, instead of looking at the resource lines / running through the history of the file. I'm open to ideas and a contribution here!
The relevant function:
https://github.com/bridgecrewio/yor/blob/main/src/common/gitservice/blame.go#L22

@nimrodkor any idea what would be the fix for the above issue? We are experiencing the similar problem. What logic should be used here to record the resource-level changes (deleted lines)?

Commenting to keep this open as its still an issue.  I see there is a PR open for it! https://github.com/bridgecrewio/yor/pull/409

@J-Scriv-Oblak I've just merged the fix PR, please let me know in case of an issue.


Roadmap

I'd like to get started planning out where our IDE work will go over the next few months. There are a few things I'd particularly like to see happen:

[ ] Graphics and Plotting, including separate plotting pane
[ ] Error line highlighting and linking, as in LT
[ ] Linting
[ ] Console autocompletion
[ ] Single-keystroke access to docs
[ ] Integration between autocompletion and documentation (e.g. signatures and one-line summaries)
[ ] Integrated plotting

What else is high on people's priority lists? All suggestions are welcome, and if someone is willing to work on a feature I'm very happy to add it to the roadmap.

This isn't really high on my list, but: a pane that shows the current variables in the environment and a brief summary of their types and values. Bonus: double-click a variable to automatically plot it in a way sensible for its type.

Also, hotkeys to efficiently switch between panes, especially the editor and console.

What about a spreadsheet like dataframe and array explorer? Spyder and Rstudio both have this feature.

Only a couple of lines, since I'm nowhere near an actual PC right now :
Regarding plotting: I'm not sure whether a plotting pane really is the way to go. Imo displaying the plot in its own floating window (Matlab style) is more convenient, and should be easily done via atom-shell (or whatever it's called now)...
The last point is something that Visual Studio does nicely,  so that's how I'd try to do it here too.
And I'd like to second @malmaud 's suggestion of a variable browser.

Well, 'Matlab style' for plotting was actually my inspiration, since it lets you dock the floating plot window onto the main workspace, which I was my usual workflow. But whether it's docked or floated in the Atom IDE isn't a big deal to me compared to other wish-list features.

Heh, good point. I never used Matlab with docked plots since I always found it super convenient to be able to compare multiple plots by having them in their own window and next to each other (poor man's subplot, so to speak ;-)).
But yeah, that's just a matter of taste...
Thinking on it: Juno can only handle plots for some plotting packages realistically, right? No one would really want to lose the interactivity of a pyplot-plot,  and drawing that in Atom seems rather impossible to me.

It could draw as an SVG and then just be rendered natively by chromium,
couldnt it?
On Wed, Aug 26, 2015 at 3:51 PM, Varanas<EMAIL_ADDRESS>wrote:

Heh, good point. I never used Matlab with docked plots since I always
found it super convenient to be able to compare multiple plots by having
them in their own window and next to each other (poor man's subplot, so to
speak ;-)).
But yeah, that's just a matter of taste...
Thinking on it: Juno can only handle plots for some plotting packages
realistically, right? No one would really want to lose the interactivity of
a pyplot-plot, and drawing that in Atom seems rather impossible to me.
—
Reply to this email directly or view it on GitHub
https://github.com/JunoLab/atom-julia-client/issues/10#issuecomment-135151997
.

Yeah,  sure, but that'd mean no more interactivity. What might be nice is a small rendered plot inline or underline which opens the real plot somewhere when clicked on.

Integrated plotting is definitely important – I added that to the readme. I'm planning to support both inline panes and windows equally well so that shouldn't be an issue.
I'm a big fan of the idea of having a really nice spreadsheet component for dataframes, matrices etc., but getting that working really well is a fairly large project.

@one-more-minute  Jupyter team is working on an IDEish thing called phosphor. This is the spreadsheet component: https://github.com/jupyter/spreadsheet
Perhaps it would be good to piggy pack off their progress.

Ok, that looks interesting. It would be great if someone could look into the feasibility of integrating that work with Atom.

+1 to spreadsheet view. I can imagine tons of interesting things one can do with this. Perhaps this can be implemented in Escher. Cc: @shashi

A question: how will this be different from Hydrogen (https://atom.io/packages/hydrogen) which is a good package in its own right? I'm excited to see all these efforts to get a nice IDE for Julia on Atom - don't get me wrong - but I'm confused by the number of choices.

Out of curiosity what is the goal behind this project? Is the intent to provide some IDE like features that can mimic the matlab interface?  Or  more generally to provide a real IDE for Julia along the lines of MATLAB (which would be great); If so,  don't you think that atom would be too  limiting in the  long run when needing to add advanced functionality? I mean atom has some real potential, but I can't help notice  how slow it is and the number of times it has frozen has made it unusable for me.

It is intended to be like Matlab/RStudio. In the general case, an Atom panel is just a web browser that can handle arbitrary html and javascript, so I'm not sure I see why it wouldn't have enough  power.

I'm not sure I get this objection either - I know the plural of "anecdote" is not "data" but I've been using Atom now for about 6 months (since pre-1.0) and the speed hasn't been an issue.
(The inability to open large files - now fixed, I believe - was an issue, however.)
I'm still wondering what this package will offer over Hydrogen. It might make sense to combine efforts to produce something that's truly outstanding.

@sbromberger Hydrogen is nice, but very much tied to IPython. My set of packages is intended to be really modular, with ink providing the UI components (inline results, console etc.) and julia-client hooking that UI up to a Julia backend. You could hook those UI bits up to an IJulia kernel too, if you wanted (to recreate something like Hydrogen), but you'd find it pretty limiting: The notebook interface is fundamentally very different from an editor+console, and mashing the two together doesn't really work that well.
@mmoh Atom's performance is definitely still a bit variable on different systems. For me it works great, though I've heard it can freeze up a bit more for others. The team at GitHub really care a lot about performance, though, and that's improving quickly. We've reviewed a lot of options and I really think it's the only viable route forward, at least in the short term.

I kinda hope that it'd be more than just matlab -- the instREPL and the stuff Mike does with evaling into modules is a very useful (and powerful) utility imo. And let's be honest: Not everything the Matlab IDE does is all that great.
Your concerns about Atom are kinda understandable regarding stability and speed (compared to, say, SublimeText or something like that), but then it's very powerful and extendable from what I've seen so far and is furthermore backed by GitHub. I wouldn't worry about it in the long term.
About Hydrogen: It only works with iPython/Jupyter -- that's reason enough for me to look for something else. I find it a bit annoying to have to set up python in order to get a nice Julia IDE. Though Hydrogen looks really nice, granted ;)

@Varanas ah, that's definitely something I overlooked, since I use both Python and Julia. Thanks for bringing that restriction up.

I don't know if this is the right place to ask, but what I really enjoy from an editor (Matlab, eclipse, visual studio, Rstudio, even Excel VBA) is the ability to set breakpoints and step through/debug the code. Would that be possible with atom?
Let me know if I can do anything to help achieve such a visual debugger.
I'm also excited by atom and even more you guys working on it. Thanks and good luck!

That is good to hear. I'm looking forward to the future of this project. I hope one day I don't have to use MATLAB. The IDE, fast 2d/3d plotting and documentation are really the only things keeping me. I have been testing Julia and playing around with it bit by bit and am really enjoying it thus far.
@sbromberger  True it is my anecdote. But yesterday I was installing this package and several other themes and it atom consistently froze after each installation (even after a syntax download)  to the point where I had to shutdown and restart atom to get it working again. Again this is my experience on Windows. I've tested atom on my surface pro 3 and again same issues so I don't think its my computer in particular. I'm not sure if the developers tested atom on windows but it really sucks as of version 1.09.

We all want that, but there is no debugger for Julia (text or GUI) at the
moment because of how hard a technical challenge it is to write one for a
JITed language like Julia. The core debugging support will eventually be
developed for Julia, at which time it should be relatively straightforward
to add a GUI.
On Tue, Sep 1, 2015 at 12:54 PM, Ken-B<EMAIL_ADDRESS>wrote:

I don't know if this is the right place to ask, but what I really enjoy
from an editor (Matlab, eclipse, visual studio, Rstudio, even Excel VBA) is
the ability to set breakpoints and step through/debug the code. Would that
be possible with atom?
Let me know if I can do anything to help achieve such a visual debugger.
I'm also excited by atom and even more you guys working on it. Thanks and
good luck!
—
Reply to this email directly or view it on GitHub
https://github.com/JunoLab/atom-julia-client/issues/10#issuecomment-136793115
.

@mmoh Just to provide another data point/anecdote: I too have been using Atom for a bit on Windows and so far haven't had any crashes or freezes (at least none that weren't entirely my fault), although Atom feels a bit slow to me sometimes. But then again the Matlab IDE is pretty slowish too...
@Ken-B Debugging is in the works, iirc, but a long way from done. Stepping through code on the other hand is dead simple with Juno (with one major drawback: Can't step into a function call): You just eval one line after the other or select a block and eval that.

Are there plans to simplify the setup process? It would be great if there was just one julia package that one can install from within Atom, and then everything just works.

@davidanthoff As Mike explained here, the goal would probably be to phase out Juno/LightTable, and make Juno/Atom the standard bundle. Given that JunoLT is currently available as an "official" IDE bundle on the julialang website, I suppose that in the (near?) future, a Juno/Atom bundle could take its place, with a similar out-of-the-box experience.
Of course this would require 0.4 to be released first, as Atom requires 0.4 and you wouldn't want an "official" IDE based on a nightly build...

I almost think that the most user friendly would be to actually not have a bundled download for Atom/Julia, but instead just ask users to download Atom and then install ideally one package to get julia integration.
The JunoLT download always had the problem that it was just a zip and didn't have an installer. For inexperienced users that is a real hurdle. But getting a proper setup program going that handles all the required corner cases is really difficult. I'm think especially about handling Atom updates, julia updates etc. in some meaningful way.
I could see an argument that the atom plugin could download and install julia itself, although I almost feel it would make more sense to try to get the official julia setups somehow register installed versions of julia (on Windows e.g. in the registry) so that things like the Atom plugin have an easier time finding the julia.exe.

I agree, @davidanthoff, though I can see the appeal of a complete bundle.
But since Atom is so much more than just a soon-to-be base for a Julia IDE, an extra step in the installation is warranted, imho. Some kind of three step installation would be my choice, I think: Download and install Atom, download and install Julia, install julia-client from Atom which handles all dependecies (on the Atom and the Julia side, which shouldn't be all that difficult).
Regarding registering Julia in the registry: Isn't there an option to add Julia to the PATH when installing? We could encourage that and not worry about anything else, right?

It would definitely be cool to have the plugin auto download and update Julia. I don't see that happening for a while, though, unless someone is interested in stepping in to make it happen.

-1 for autodownloads (or at least -0 if we could disable it). I use several versions for testing and want to make sure my IDE doesn't overwrite my working environment

Notifying when a new stable version of Julia is available and autoupdating Atom.jl would be a nice thing, imo.

@Varanas no issues with notification at all. Autoupdating isn't an Atom feature - notification is - so perhaps we could just do that? Autoupdate has security implications as well.

Yes, I'm with Seth here, this might be a good idea when there's a stable Julia environment (1.0?), but currently with 0.3.11, a just released 0.4, and a 0.5.0-dev branch this doesn't make sense.

Ok, when I say "auto-updating" I mean something like a popup that asks if you want to upgrade, and if you do saves the bother of downloading and linking everything. We certainly wouldn't want to overwrite environments by default. I very much doubt will have this before 1.0 anyway so it's not a huge deal.

@one-more-minute ah, that's more appealing. Is there any way to hook into Atom's squirrel notification when updates are available? That'd be really slick.

I think the main short term thing would be to

Make things such that users only have to install one Atom package (which might trigger the installation of other Atom packages, but it would be good if the user was shielded from that)
Have the plugin install and udpate the Atom.jl package
Get the JuliaParser folks to tag a version, so that no checkout is needed

I feel at that point the whole setup thing would be good enough for quite a while.

I would like an auto-download prompt.


CodeceptJS：Can you support third-party browsers?

What are you trying to achieve?
except chromium，Firefox，webkit,
Details

CodeceptJS version:3.0.7
NodeJS Version:
Operating System:
puppeteer || webdriverio || testcafe version (if related)
Configuration file:

I believe codeceptjs supports what the engines support. (wdio, puppeteer, etc.)

yes, everything that Playwright or webdriverio supports is supported


Transparency on PNG

Hi
I save from original png with transparency and when i save loose the transparency and put a black background.
$imageObj = Image::make($request->file('activityUploadPhoto'))->orientate();
$imageName = substr(md5(Auth::user()->id), -10) . '_' . md5(microtime()) . '.' . $request->file('activityUploadPhoto')->getClientOriginalExtension();
$imageObj->save(config('paths.storage_tmp_imgs') . $imageName)
I have this version             "version": "2.3.7",
Is a bug?
Thanks

I'm having a similar issue, where the PNG's shadow that is semi transparent is converted to flat black.
If you upload this....

to this...
https://www.apps.regenr8web.com.au/image-preparation/
you get this...

The controller simply resizes to max size and saves as JPEG with quality of 85.
Thoughts or ideas? Most recent version of the plugin (as of right now).

JPEG does not support alpha channel / transparency. If you want the background in another color than black, I would suggest you create an empty image with canvas() with the desired background color and insert() your semi-transparent image into this container.

Like this:
$png = Image::make('transparent.png');
$jpg = Image::canvas($png->width(), $png->height(), '#ff0000');
$jpg->insert($png);
$jpg->save('foo.jpg');

with imagick run correctly the plugin, with gd no

that did the trick with both GD and imagick drivers.
@olivervogel I wonder if this is a sensible default that should be apart of the framework. Is this a pull request you would consider if I put it together (or someone else)?
I figure if the image is being converted to a jpg, by default it should have a white background and keep the original images transparency (with the white behind it of course).

I think total transparency is converted to white and everything in between becomes black. That's just the way GD works.


proposal: Go 2: make short variable declaration re-declare already declared variables

The current behavior of short variable declaration (:=) when one of the declared variables already exists is assignment. One of the consequences of this design is that errors can often be ignored by mistake when reusing the canonical err variable:
func() {
    x, err := FunctionThatMayFail()
    _ = x
    // Compiler error - err not used
}

func() int {
    x, err := FuncThatMayFail()
    if err != nil { return; }
    y, err := AnotherFuncThatMayFail()
    return y
    // No compiler error - invalid value of y when err != nil
}

My proposal is to strengthen the rules of short variable declaration operator (:=) so it (semantically) re-declares all variables, no matter if they're used or not. This will prevent the silent failure demonstrated in the above example. Compiler could detect when variable can be re-used.
This proposal would also make this valid Go, as it would be needed for complete robust error handling:
func() {
    x, err := FuncThatMayFail()
    // ...
    x, err := AnotherFuncThatMayFail()
    // ...
}

The consequences of this change seem small - when using the := operator in a scope deeper than the original variable's scope, Go re-declares the variable anyway:
func() {
    x := 0
    for i := 0; i < 10; i++ {
        x, y := i, i+1
        _, _ = x, y
    }
    fmt.Println(x) // prints zero
}

One of the edge cases I can think of is return values - in which case it would make sense to create a "special case" and return the last declaration of the re-declared variable:
func() (x int) {
    x, err := FuncThatMayFail()
    // return value x is updated
    x, err := AnotherFuncThatMayFail()
    // return value x is updated again
}

Another would be pointers:
func() {
    x, err := FuncThatMayFail()
    // ...
    xp1 := &x
    x, err := AnotherFuncThatMayFail()
    // ...
    xp2 := &x
    // do xp1 and xp2 point to the same variable?
}

In this case, it would make sense to make xp1 and xp2 equal, for the sake of backwards compatibility - as making them different could break code that relied on := doing assignment on same-named variables. So the "re-declaration" would be strictly a semantic property - a signal to the compiler that the value needs to be re-used after the re-declaration.

This change is (seems?) completely backwards-compatible - i.e. all valid Go programs would still be valid and have identical behavior. Some currently invalid Go programs would become valid after this change.
I have a feeling that I've missed quite a few details, since this proposal seems to fit the language well and has good consequences (robust error handling - lack of which is a common criticism of the language), but I can't think of any other edge cases right now.
I'm eagerly awaiting feedback on this. Cheers!

Please fill out https://github.com/golang/proposal/blob/master/go2-language-changes.md when proposing language changes

What about closures, especially ones that are handed to defer or go? Unless I'm misunderstanding something, the following (contrived) example's behavior would change:
func Example() (err error) {
  ok := true
  defer func() {
    if !ok { // With the proposed change, this variable isn't updated by the := assignment below.
      err = errors.New("failed")
    }
  }()

  v, ok := os.LookupEnv("SOMETHING")
  if ok {
    fmt.Println(v)
  }
  return nil
}

Please fill out https://github.com/golang/proposal/blob/master/go2-language-changes.md when proposing language changes

Since this is a backwards compatible change, does it still qualify for Go2 language change? I was following the New external API or other notable changes format, which does not required all the Go2 language change paperwork.
This is an honest question, if I'm wrong with this line of thinking, then I'll fill it out.

What about closures, especially ones that are handed to defer or go?

Assuming the "re-declaration" becomes simply a matter of sematics (the underlying variable, i.e. memory address, stays the same - it's just that the compiler signals to the user that the variable needs to be re-used after the "re-declaration"), then the behavior in the closures would stay the same.

The "edge cases" are backwards incompatible, and this is a change to the language spec.

Assuming the "re-declaration" becomes simply a matter of sematics (the underlying variable, i.e. memory address, stays the same - it's just that the compiler signals to the user that the variable needs to be re-used after the "re-declaration"), then the behavior in the closures would stay the same.

O.K., but just a slight change breaks that, then:
func Example() (err error) {
  ok := true
  defer func() {
    if !ok {
      err = errors.New("failed")
    }
  }()

  v, ok := os.LookupEnv("SOMETHING")
  fmt.Println(v)
  return nil // With the proposed change, ok isn't treated as used. This is valid, if weird code, but it would suddenly break.
}

I see. Thanks for the input. I have updated the original post with the Go2 language proposal paperwork.
Sorry for posting with different accounts, I seem to have opened the wrong Firefox container.

Perhaps we could have done this initially, but making this change today would not be backward compatible.  It would cause code that currently works, and is correct, to stop compiling.  I don't think we can make this change to the language.
It might be feasible to check for this case in vet or some other static analyzer.  That would be worth exploring.
But as a language change this is a likely decline.  Leaving open for four weeks for final comments.

No further comments.


Removing the Anonymous types in public-preview version

Issues:
 Anonymous types during SDK generation.

Solution:
Created the models for each anonymous type and referred.

I see no readme.typescript.md in this folder https://github.com/Azure/azure-rest-api-specs/tree/dev/v-mnali/Clearing-Anonymous-types/specification/managednetworkfabric/resource-manager but it's referenced https://github.com/Azure/azure-rest-api-specs/tree/dev/v-mnali/Clearing-Anonymous-types/specification/managednetworkfabric/resource-manager#typescript

@qiaozha Author has resolved the comments, please re-review


Remove random print() statements

I'd like to use twobitreader in one of our projects, but the random print() in longs_to_char_array() breaks nose tests and will inevitably confuse some of our users. This PR removes that and also adds python 3.5 to the list of supported versions and runs the nose tests on it.

looks good to me

Awesome, thanks for getting this on pypi so quickly!


Fixed spelling: clihandler/cmd/control.go

Thank you @AlexsJones :)
Do you mind reopening the PR against the dev branch? Thank you for your contribution

https://github.com/armosec/kubescape/pull/255


Make it possible to compile datafusion-common without default features

Which issue does this PR close?
Closes #7624
Rationale for this change
Currently datafusion-common has a default feature of parquet. But some of the parquet functionality was not guarded by  #[cfg(feature = "parquet")] conditionals, so it was not possible to compile the crate with the parquet feature disabled.
What changes are included in this PR?
This PR adds conditionals. It also sets default-features = false for all of the datafusion crates that depend on datafusion-common but don't require the parquet functionality.
Are these changes tested?
By adding default-features = false to the crates that depend on datafusion-common but don't need parquet support, we ensure that it's possible to compile datafusion-common without the default features.
Are there any user-facing changes?
no

I took the liberty of pushing a commit to this branch that fixes the cargo.toml formatting to get CI to pass.

Thanks!


SelectedIndex issue

Hi, i can't find SelectedIndex in your lib , does this lib support it ?

We have a XAML property called SortedColumnIndex


Support Minecraft's modified unicode

The cesu8 crate looks like it provides methods for javas modified unicode.
Make sure to get an example chunk with this unicode to test with.
This should be backwards compatible since any chunks with modifier unicode would have failed to parse. I don't consider being able to parse more things correctly a breaking change.

Added in 1.1.


[WIP] Oc-react-template support

[x] support for oc-template-react (client-side rendering only atm)
[ ] First oc-template-react, oc-template-jade and oc-template-hadnlebars to be published

related PRs:

https://github.com/opentable/oc-template-react/pull/1
https://github.com/opentable/oc-template-handlebars/pull/13
https://github.com/opentable/oc-template-jade/pull/3

@nickbalestra I assume this is mostly a playground PR than a real one? I don't think I would like the react template to be part of the core, but rather to have a way for the core (registry and clients) to be extended

@matteofigus yes, and imho that should be true for all templates, not just react (jade, handlebars)

https://github.com/opentable/oc/pull/415 addressed what this PR was all about.
Upcoming PRs needed to bring it all together:

[ ] Registry expose via context all the supported templates (This need to introduce the ability for registry owners/mantainers to white-list specific oc-templates)
[ ] oc-client component (browser) will take advantage of context so that it can programmatically register the needed templates.
[ ] Support on the node client
[ ] SSR


Add automatic labels

Closes #214
Signed-off-by: Michael Lavers<EMAIL_ADDRESS>

@kolanos I suggest we mark this "Work in Progress" while we decide what/how much auto-labels we'd like to do


Ft browser location

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (33e1a15) to head (0fe6d56).

Additional details and impacted files
@@               Coverage Diff               @@
##           demo-fn-19-07       #31   +/-   ##
===============================================
  Coverage         100.00%   100.00%
===============================================
  Files                  1         1
  Lines                  4         4
  Branches               1         1
===============================================
  Hits                   4         4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Only test on current and upcomming python version (dev)

Codecov Report

Merging #260 (2dbaf75) into dev (dd6f8b1) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #260      +/-   ##
==========================================
- Coverage   43.60%   43.60%   -0.01%
==========================================
  Files          33       33
  Lines        4639     4630       -9
==========================================
- Hits         2023     2019       -4
+ Misses       2616     2611       -5

Impacted Files
Coverage Δ

assemblyline_core/dispatching/dispatcher.py
76.80% <0.00%> (-0.27%)
:arrow_down:

assemblyline_core/plumber/run_plumber.py
93.33% <0.00%> (-0.22%)
:arrow_down:

assemblyline_core/ingester/ingester.py
75.78% <0.00%> (-0.05%)
:arrow_down:

assemblyline_core/metrics/helper.py
0.00% <0.00%> (ø)

...mblyline_core/scaler/controllers/kubernetes_ctl.py
13.88% <0.00%> (+0.04%)
:arrow_up:

assemblyline_core/updater/run_updater.py
27.73% <0.00%> (+0.07%)
:arrow_up:

assemblyline_core/scaler/controllers/docker_ctl.py
14.66% <0.00%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd6f8b1...2dbaf75. Read the comment docs.

Cannot be merged


What is the usage logic of this API client?

Hi,
I'm trying to figure out this package but due lack of docs its hard to find a logic flow...
It does not seem to run in parallel with the actual API functions
eg from https://developers.google.com/youtube/v3/docs/
Youtube data api > videos -> list
but in the api this is Youtube -> videos -> ListVideos
Why??
Also the classes initiated when doing $youtube->videos->ListVideos is actually Google_Service_YouTube_Channel_Resources and not just Google_Service_YouTube_Channel. Why?
And then how can I for example use functions like:
Google_Service_YouTube_Channel->getContentDetails
Google_Service_YouTube_Channel->getContentOwnerDetails
Google_Service_YouTube_Channel->getSnippet
Thanks!

Sorry, but for questions, consider using stackoverflow


Issues/8: add ability to remove test comments

What(What have you changed/added/removed?)

add ability to remove test comments

Why(Why did you change/add/remove it?)

Fixes: https://github.com/komuw/ote/issues/8
If you have a module that relies on module a/b in test files and then you run ote; it will add a // test comment next to module a/b
If days later you start to also use module a/b in non-test files and you run ote; it should now remove the // test comment next to module a/b since that module is no longer a test only dependency

Codecov Report

Merging #10 into master will increase coverage by 1.14%.
The diff coverage is 70.27%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   64.24%   65.38%   +1.14%
==========================================
  Files           2        2
  Lines         165      182      +17
==========================================
+ Hits          106      119      +13
- Misses         43       46       +3
- Partials       16       17       +1

Impacted Files
Coverage Δ

ote.go
61.53% <52.94%> (-0.63%)
:arrow_down:

comment.go
88.46% <85.00%> (+6.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b624c87...c422701. Read the comment docs.


Include krb5 package

Add krb5 package to avoid the inclusion of krb5-mini by the OBS
solver. Krb5-mini causes some dependencies conflics with many
packages that expects krb5 and not krb5-mini.
Fixes #54

lgtm


Can't make JerryScript Work with Zephyr

I'm simply not able to make JerryScript work with Zephyr. I have tried different processes with different outcomes:
1>
Tried running the command below (just like this tutorial) in the targets\os\zephyr, but changing the toolchain in the CMakeLists:
west build -p auto -b waveshare_nrf5240_eval_kit

Changes to the CMakeLists:
from this:
--toolchain=${JERRY_BASE}/cmake/toolchain_mcu_stm32f4.cmake)
to this:
--toolchain=${ZEPHYR_BASE}/boards/arm/waveshare_nrf52840_eval_kit/board.cmake)
Result:
Build files have been written to: C:/company/projects/tst/west-workspace/jerryscript/targets/os/zephyr/build
ninja: error: '../../../../build/lib/libjerry-core.a', needed by 'zephyr/zephyr_prebuilt.elf', missing and no known rule to make it
FATAL ERROR: command exited with status 1: 'C:\Program Files\CMake\bin\cmake.EXE' --build 'C:\company\projects\tst\west-workspace\jerryscript\targets\os\zephyr\build

2>
So, tried running the command to generate the libjerry files from the jerryscript folder:
python tools\build.py, but this gave me this error:
[...]
running 'nmake' '-?' failed with the system cannot find the file specified
[...]

So I set up the python build to use the ninja (because Zephyr uses ninja, and it is already configured in my machine) using CMake GUI, also set the following with CMake GUI:
CMAKE_C_COMPILER <= C:/GNU_ARM_EMBEDDED/bin/arm-none-eabi-gcc.exe
CMAKE_C_COMPILER_WORKS <= TRUE

Also set the configs in the jerryscript\targets\os\zephyr\CMakeLists.txt  in CMake GUI
And then ran the command python tools\build.py, the build is succeeded. After that tried building jerryscript\targets\os\zephyr with west.
Result:
[...]
fatal error: sys/printk.h: No such file or directory
   19 | #include <sys/printk.h>
[...]

3>
Then tried running west command in the jerryscript directory (after deleting the contents in the build folder, of course):
west build -p auto -b waveshare_nrf52840_eval_kit

The build was succeeded, but got the following warning:
CMake Warning:
  Manually-specified variables were not used by the project:

    BOARD
    WEST_PYTHON

-- Build files have been written to: C:/moduhub/projects/jerryscript_test/jerrytest/jerryscript/build
-- west build: building application
[3/29] Generating ../amalgam/jerryscript.c, ../amalgam/jerryscript.h
WARNING:root:[2] Include not found (C:\company\projects\jerryscript_test\jerrytest\jerryscript\jerry-core\jmem\jmem-allocator-internal.h:32): "memcheck.h"
[29/29] Linking C static library lib\libjerry-ext.a

Then returned to targets\os\zephyr, removed the build folder and ran:
west build -p auto -b waveshare_nrf52840_eval_kit

Got:
[...]
fatal error: sys/printk.h: No such file or directory
   19 | #include <sys/printk.h>
[...]

So I removed the #include <sys/printk.h> header, as it is not required for printk anymore, and re-ran the west command.
Result:
[...]
fatal error: zephyr.h: No such file or directory
   19 | #include <zephyr.h>
[...]

4>
Update Zephyr to 3.1.0, setup the the build in the jerryscript folder with CMake GUI, the same way as described above and ran west in targets\os\zephyr
Result:
c:/gnu_arm_embedded/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld.exe: error: zephyr\zephyr_prebuilt.elf uses VFP register arguments, ../../../../build/lib/libjerry-core.a(jerryscript.c.obj) does not

But that was fixed by setting float ABI to use soft float calling conventions using menuconfig/guiconfig:

After that I re-ran the west build command, the build was succeeded, so I flashed to the board and openned the Arduino's Serial Monitor, the program simply stops, note how the "js>" is not printed:

Tried sending print('Test') through the serial monitor, but nothing happens.
When debbug with Ozone, the problem is in the jerry_init() function in the jerry-main.c, a MemManage exception heppens:

Maybe the warning in try number 3 has something to do with it:
[...]
WARNING:root:[2] Include not found (C:\company\projects\jerryscript_test\jerrytest\jerryscript\jerry-core\jmem\jmem-allocator-internal.h:32): "memcheck.h"
[...]

Comments
I haven't setup Zephyr according to the JerryScript tutorial, because Zephyr is already setup and running.
Platform: Windows 10
Zephyr version: 2.7.0 and 3.1.0
JerryScript Version: 3.0.0

Are you guys alive overthere?

Well, yes, thanks for asking. A gentle ping would have sufficed.

It seems system headers are missing, maybe something is not installed. We don't know your platform, but somebody at zephyr community might know more.

Well, yes, thanks for asking. A gentle ping would have sufficed.

@akosthekiss Sorry, it sounded funny on my head

I asked overthere yesterday, but as it isn't considered a Zephyr issue, that got moved to the discussion, still nothing though it is recent, so that is expected. BTW I'm working on making Jerry a Zephyr module, lets see how that turn out

Unfortunately I cannot really comment on the "top of stack" issue. The memcheck.h is needed by valgrind, did you enabled its support?

A stack issue just came to my mind. I had a multi threaded experiment before, where I accidentally placed the whole jerry heap on thread stack, and it crashed instantly. This is an unlikely case, but maybe it helps.

Unfortunately I cannot really comment on the "top of stack" issue. The memcheck.h is needed by valgrind, did you enabled its support (passing JERRY_VALGRIND to the compiler)?

Actually I haven't done that. But as of now, the Jerry module for zephyr is working to some extent, but I have some features to fix. Either way, thanks for the help!

Update:
Here is a repository of a modified version of JerryScript to be built for Zephyr. * It might suffer modifications, but it is working great so far *
And here is a test/sample repo on how to use JerryZ

Hi there, I've tried out the current Zephyr version (2.7) with latest JerryScript (that is for stm32f4-discovery device). I've followed the documentation (targets/os/zephyr/README.md) and everything worked fine - my OS is Ubuntu 20.04. After flashing the binary to the board, the header of the demo app appeared as expected, while the prompt does not.
*** Booting Zephyr OS build zephyr-v2.7.0 ***

JerryScript build: Jan  3 2023 16:17:15
JerryScript API 3.0.0
Zephyr version 2.7.0

The prompt problem is solved by applying #5033 modification.