Update the consensus bundles

This patch divides the ouroboros-consensus and
ouroboros-consensus-packages into library and test bundles:

Creates the ouroboros-consensus-test bundle, containing:

ouroboros-consensus-test
ouroboros-consensus-mock-test
ouroboros-consensus-tutorials

Creates the ouroboros-consensus-cardano-test bundle, containing:

ouroboros-consensus-byronspec
ouroboros-consensus-cardano-test
ouroboros-consensus-byron-test
ouroboros-consensus-shelley-test

Updates the ouroboros-consensus and ouroboros-consensus-packages bundles by removing the test packages.

Bundle update and creation is done by adding changelog.d symlinks and creating or updating the CHANGELOG.md files inside each package.
Checklist

Branch

[ ] Commit sequence broadly makes sense
[ ] Commits have useful messages
[ ] The documentation has been properly updated
[ ] New tests are added if needed and existing tests are updated
[ ] Any changes affecting Consensus packages must have an entry in the appropriate changelog.d directory created using scriv. If in doubt, see the Consensus release process.
[ ] Any changes in the Consensus API (every exposed function, type or module) that has changed its name, has been deleted, has been moved, or altered in some other significant way must leave behind a DEPRECATED warning that notifies downstream consumers. If deprecating a whole module, remember to add it to ./scripts/ci/check-stylish.sh as otherwise stylish-haskell would un-deprecate it.
[ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.

Pull Request

[ ] Self-reviewed the diff
[ ] Useful pull request description at least containing the following information:

What does this PR change?
Why these changes were needed?
How does this affect downstream repositories and/or end-users?
Which ticket does this PR close (if any)? If it does, is it linked?

[ ] Reviewer requested

bors r+

bors r+


Organisation custom logo field hidden

The "Custom logo" file input element isn't shown when choosing "Use custom logo for organisations exempt from the single identity".
Steps to replicate the problem:

Edit an organisation (e.g. https://whitehall-admin.integration.publishing.service.gov.uk/government/admin/organisations/cabinet-office)
Choose "Use custom logo for organisations exempt from the single identity" from the "Logo crest" menu
Observe the absence of the "Custom logo" file input field
Save the organisation
Observe that the organisation can't be saved because "Logo can't be blank"
Observe the presence of the "Custom logo" file input field

I would expect the "Custom logo" file input field to appear as soon as I choose "Use custom logo for organisations exempt from the single identity" from the "Logo crest" menu.

Cannot reproduce. Now seems to display input field fine:


text spacing issue in the navbar of shlok page

Description
Describe the bug:
the blog tab is not aligned properly also the hover effect is missing
Reproduction Steps
Steps to reproduce the behavior:

Go to 'http://<IP_ADDRESS>:5500/shlok_page/motivation.html'
see the nav bar

Screenshots

Additional Information
Device (please complete the following information):

OS: Linux
Browser Chrome
Version : Ubuntu 22.04.1 LTS

Additional context:

I would like to work on this issue under gssoc!

kindly assign me this issue under gssoc!

I am interested to work on this issue under GSSoC 2023 as a contributor

Please assign this issue to me I will solve this issue under GSSOC'23. I will solve the mentioned issue with the help of the required HTML and CSS code. I have also worked on the realignment of the shloka page in previous issue


[TF 2.0 API Docs] tf.keras.backend.count_params

System Information
Tensorflow version 2.9
URL(s) with the issue:
https://www.tensorflow.org/versions/r2.0/api_docs/python/tf/keras/backend/count_params
Description of issue (what needs changing):
Clear description
The description is not clear, no details on how to use this symbol
Raises listed and defined
No errors have been defined
Request visuals, if applicable
No visuals? an example using arrays could be represented in visual form for clarification
Submit a pull request?
No

@lkmandy,
Example code is available, which demonstrates how to use this functionality. Can you please confirm if this is what you are looking for? Thanks!


The change event doesn't fire sometimes.

source code
md-slider(
  min="0",
  max="2",
  step="1",
  [value]="byTypeValue",
  [disabled]="disabled",
  (change)="onSet($event)")

What are the steps to reproduce?
change the value by clicking the track line. clicking or dragging the thumb icon several times will increase the chance to meet this issue.
What is the current behavior?

(NOTE: the spinner will be shown if the change event is emitted, otherwise there is no spinner)
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
angular-4.3.1
angular-material-2.0.0-beta.10
macOS-10.12.3
chrome-60.0.3112.113
typescript-2.3.2

I think this may have been resolved already, I'm not able to reproduce it anymore: https://stackblitz.com/edit/angular-material2-issue-a4v7w8


git to website movement

setup so we can push updates to a git system also to awww, easier to copy stuff around.
maybe use jGit:
http://eclipse.org/jgit/download/

along with that, use it to backup stuff on S3 via a master repo:
http://www.fancybeans.com/blog/2012/08/24/how-to-use-s3-as-a-private-git-repository/


#740 | Popup Image viewer for NFTs

Fixes #740
Description
This PR adds a new component to preview the image in a popup dialog. This dialog can be resized and also includes a button to download the image.
Test scenarios:

https://deploy-preview-758--dev-mainnet-teloscan.netlify.app/address/0xe7209d65c5BB05Ddf799b20fF0EC09E691FC3f11?tab=nfts
In this link you can see tree cases in the same page:
A normal size NFT:

A really small one:

And a big image case:

You can also change the image preview size on the table row by clicking the "Media"  title at the top of the column.

On mobile https://deploy-preview-758--dev-mainnet-teloscan.netlify.app/address/0xe7209d65c5BB05Ddf799b20fF0EC09E691FC3f11?tab=nfts if you maximize an image, there is a tooltip that says: Toggle fit to screen of original size , if you maximize and minimize image this tooltip does not disappear and looks "off"


Support Java 10 JRE

TestNG Version

Note: only the latest version is supported

Running trying to run testng with some suite xml files (worked on version 6.9.10) on Java 10.
Expected behavior
TestNG runs my tests successfully.
Actual behavior
I got an error:
[TestNG] [ERROR] java.lang.IllegalArgumentException: InputStream cannot be null
Exception in thread "main" java.lang.NullPointerException
at org.testng.TestNG.getStatus(TestNG.java:211)
at org.testng.TestNG.main(TestNG.java:1324)
Is the issue reproductible on runner?

[ X] Shell

Test case sample

Please, share the test case (as small as possible) which shows the issue

@hezico5 - I am not quite sure I u'stand what combination doesn't work for you ?
Can you please let us know what happens when you use TestNG 6.14.3 (latest released version) with JDK10 ?

And it may depend on how you are running the test (classpath or module).
Fyi, we are not supporting (because not really tested) java9 yet: #1642 or #938

Java 10 is not a target but it should not failed.
We will check it with https://github.com/cbeust/testng/issues/1808


Reading serilog configuration from appsettings.json file

Hi, i'm tring to use the oracle sink with "serilog/serilog-settings-configuration" package, reading the connection configuration from the appsettings file, but it doesn't seem to work.
I don't get any error but my oracle table contains no log data.
Insted if i use the configuration from code it works fine.
This is the configuration section from my appsettings file
 "Serilog": {     "Using": [ "Serilog.Sinks.Oracle" ],     "MinimumLevel": "Information",     "WriteTo": [       {         "Name": "Oracle",         "Args": {           "connectionString": "my oracle connection string",           "tableName": "my oracle log table"         }       }     ]
what am i doing wrong?

Please enable self-logging and check first:
https://github.com/serilog/serilog/wiki/Debugging-and-Diagnostics

Well the issue is that the package is not setup to use appsettings... It expects only config Action:
2022-10-13T08:12:19.8990225Z Unable to find a method called Oracle for supplied arguments: connectionString, restrictedToMinimumLevel, tableSpaceAndTableName. Candidate methods are:
Oracle(configureFunction, restrictedToMinimumLevel)


Statistic helpers

Split out some helper code for statistic-counters from SR-2901 / PR #5588 change.
Includes correction to use a do { ... } while (0) block in the helper macro.

@swift-ci please smoke test and merge


Default Node GDScript Template has Warnings/Errors with new Untyped Declaration Warning

Godot version
v4.2.dev5.official [e3e2528ba]
System information
Godot v4.2.dev5 - Windows 10.0.19045 - Vulkan (Mobile) - dedicated NVIDIA GeForce GTX 980 Ti (NVIDIA; <IP_ADDRESS>99) - Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 Threads)
Issue description
When creating a new GDScript with the default Node template, untyped declarations are used:
extends Node3D

# Called when the node enters the scene tree for the first time.
func _ready():
	pass # Replace with function body.

# Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta):
	pass

I believe this is a bug because a template that has untyped declarations will cause warnings or errors if the new "Untyped Declaration" warning is enabled in the project settings. Additionally, the default template described in the documentation uses typed declarations and does not match the default template currently used by the editor.
Steps to reproduce

Ensure that no Editor-defined templates exist
Create a new project
Under Project Settings (Advanced Settings) -> Debug -> GDScript -> Untyped Declaration: Set to Warn or Error
Create a new GDScript through the FileSystem panel or by choosing Attach Script on a new scene's root node
Note that the new GDScript uses untyped declarations and does not match the documentation

Minimal reproduction project
N/A

Make sure the text_editor/completion/add_type_hints editor setting is enabled:

Make sure the text_editor/completion/add_type_hints editor setting is enabled:

Maybe it makes sense to have this enabled by default now?

Maybe it makes sense to have this enabled by default now?

Note that the UNTYPED_DECLARATION, INFERRED_DECLARATION, and UNSAFE_* warnings are disabled by default. We assume that if users want static typing, they will enable the desired settings themselves. The documentation and demo projects also use untyped GDScript by default, although there is a suggestion to use static typing in demo projects.

Make sure the text_editor/completion/add_type_hints editor setting is enabled:

Confirmed that setting "Add Type Hints" to On changes the default template to use typed declarations.
But I think there is still a usability issue that exists here... When a project has the new Untyped Declaration set to Warn or Error it is not obvious to the user that they need to change additional editor settings to play nice with this project setting.
I found out about the Untyped Declaration warning when searching for a way to disable dynamic typing in GDScript, but I had no idea that I might need to make additional editor settings changes to make the script editor play nicely with my new project settings.
Additionally, if a project is shared between multiple developers, all developers may not intuitively understand that they need to adjust their editor settings to play nice with the project settings.
I think it would be good to brainstorm a way to make this a bit more intuitive to new users, either in this issue thread or maybe  in a new proposal...

Here are a couple of options that could address the usability issue relating to Untyped Declaration warnings/errors and Add Type Hints:

Type Hints are always on when Untyped Declaration is set to warn or error in the current project. The "Add Type Hints" editor setting is ignored and has a note saying that the setting is only respected when Untyped Declaration is set to ignore in the current project settings.
Type hints default is changed to on. (This sounds like a bad idea because it conflicts with the default dynamic typing behaviour of Godot.)
The default Node GDScript template is updated to always use type declaration, similar to how it is currently shown in the documentation.
The Untyped Declaration documentation/tooltip is updated to say something like "When setting this to Warn or Error, consider changing the Add Type Hints setting to On in the Editor Settings".

Unless option 3 is implemented, the documentation should be updated to match the default Godot behaviour.
I think, at the very least, option 4 should be implemented. Maybe even before 4.2 launches as stable. This way when the new Untyped Declaration project setting is officially launched, users will know how best to configure their Editor Settings when using it.

Regarding the default template described in the documentation, I've made a separate docs issue and PR.

It looks like the original issue was that I didn't read the final section on the page that describes how type hints will be removed if the Add Type Hints editor settings is turned off.

Whoops, accidentally commented on the wrong issue.


(1-\beta) multiplying on learning rate instead of gradients while applying momentum in TF version QHM

According to the paper, the moment should be

and also in torch version
https://github.com/facebookresearch/qhoptim/blob/e81dea3f2765780cf4fbb90b87b22ba7604b8625/qhoptim/pyt/qhm.py#L133
However, the TF version has a different implement that set the learning rate to
https://github.com/facebookresearch/qhoptim/blob/e81dea3f2765780cf4fbb90b87b22ba7604b8625/qhoptim/tf/qhm.py#L131
Doesn't that makes the formula into

?
Is this a typo, or am I misunderstand something?  TIA 😁

Hi @allenwoods , it's been a while since I last looked at the TF code but IIRC the tensorflow momentum buffer is updated as follows:
g_{+ 1} = g + \nabla L

and thus we need to scale it by 1 - beta in order to ensure consistency with the paper.

Thanks for the quick reply！The TensorFlow momentum buffer is updated as follows：
accum = accum * momentum + grad
var -= lr * accum

where var is the weights.
In that case, if the lr is nu * (1.0 - momentum) * learning_rate, it seems both momentum and grad are scaled by 1-beta, while the paper indicates we only need to scale the gradient. Therefore, I modified the momentum_op to
        momentum_op = training_ops.resource_apply_momentum(
            var.handle,
            momentum_buffer.handle,
            nu * learning_rate,
            (1.0 - momentum) * grad,
            momentum,
            use_locking=self._use_locking,
            use_nesterov=False,
        )

Is it right?

I believe the code is correct as written. The reason you need to scale by the extra (1 - momentum) term is that the accum term as you describe it is "unnormalized" relative to the momentum buffer used by the paper.

I am confused, does that mean momentum_buffer in TF is 1/(1-momentum) of momentum_buffer in torch? Therefore, we need to apply (1 - momentum) term on both momentum and grad when using the TF version, while in the torch version, we only need to apply it to grad?
However, I couldn't find the code that leads such a difference in the torch version, since the only place multiplying  (1 - momentum) (as far as I can find) is https://github.com/facebookresearch/qhoptim/blob/e81dea3f2765780cf4fbb90b87b22ba7604b8625/qhoptim/tf/qhm.py#L131

See https://github.com/facebookresearch/qhoptim/blob/master/qhoptim/pyt/qhm.py#L133 .

That is exactly the line I reference in the first post, in which the momentum was multiplied by beta only, then added by (1-beta)*grad. Then the momentum was multiplied by nu.
However, in the TF version code
        momentum_op = training_ops.resource_apply_momentum(
            var.handle,
            momentum_buffer.handle,
            nu * (1.0 - momentum) * learning_rate,
            grad,
            momentum,
            use_locking=self._use_locking,
            use_nesterov=False,
        )

where both momentum and grad are multiplied by (1-beta)*nu. Therefore, the TF version's momentum is multiplied by (1-beta)*beta instead of beta before multiplied by nu.
Did I miss something?


Confusing statement in Blob binding attributes

These two sentences are nonsensical together:"If the app setting name begins with "AzureWebJobs", you can specify only the remainder of the name here. For example, if you set connection to "MyStorage", the Functions runtime looks for an app setting that is named "MyStorage.""

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fff7ae2f-4f02-7ed9-c2ed-a2715e407975
Version Independent ID: 542016c1-3c25-f6af-cc83-0c5b6218e0ce
Content: Azure Blob storage bindings for Azure Functions
Content Source: articles/azure-functions/functions-bindings-storage-blob.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@gregsmi Thank you for providing feedback with this precision of detail. I will have the content team evaluate this information and make an update as appropriate.

Thanks, @gregsmi
This issue is resolved in production.
#please-close


Can't access websocket (ws://) url using marathon-lb

I have a container running a jupyter gateway which requires two urls to be accessible a http and websocket url.
On localhost, for example, these urls are http://<IP_ADDRESS>:8888 and ws://<IP_ADDRESS>:8888.
When I start my app with marathon and ssh into the mesos slave running the container I can access both of these urls functionality using my client that makes requests to the jupyter gateway. Which tells me the jupyter gateway in the container is working fine.
However when I am trying to access the jupyter gateway through the marathon load balancer my client tells me it can reach the http:// url fine but it times out when trying to connect to the ws:// url which I need to be able to access.
I believe marathon-lb supports forwarding websockets without extra configuration so I am not sure what the issue is but I suspect it could do with the following haproxy config in my marathon app labels.
Labels:
HAPROXY_0_MODE=http
HAPROXY_0_PATH=/jupyter-gateway-container-path
HAPROXY_0_VHOST=ourwebsite.com

What did you do to resolve this?


export  'toDisplayString'

Version
3.0.0-beta.14
Reproduction link
https://github.com/znck/vue-developer-experience
Steps to reproduce
git clone https://github.com/znck/vue-developer-experience.git
pnpm install
pnpm run build
<EMAIL_ADDRESS>examples/simple/
What is expected?
no error
What is actually happening?
Error :: Module '"./node_modules/vue/dist/vue"' has no exported member 'toDisplayString'. (code 2305)

Please add export {toDisplayString} from '@vue/shared' in vue.d.ts
related issue: https://github.com/znck/vue-developer-experience/issues/13

@yyx990803 When will 3.0.0-beta.15 released？


mDNS lookup failed, attempting fallback to reading device log

[ +108 ms] success
[        ] (lldb)     safequit
[ +107 ms] Process 267 detached
[  +53 ms] Application launched on the device. Waiting for observatory port.
[   +2 ms] Checking for advertised Dart observatories...
flutter问题可真多，bug量估计创新纪录了。提个小建议：能否不要急着扩展类库组件、新特性，先把bug解决差不多吧！！
(google translate)
The flutter problem is really much, and the bug count is an innovative record. A small suggestion: Can you not rush to extend the library components, new features, first solve the bug almost! !
我的情况是可以运行，但是hotreload不能工作：
[+5014 ms] mDNS lookup failed, attempting fallback to reading device log.
[        ] Waiting for observatory port.

flutter --version
Flutter 1.9.1+hotfix.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision cc949a8e8b (11 days ago) • 2019-09-27 15:04:59 -0700
Engine • revision b863200c37
Tools • Dart 2.5.0

➜  shuichan_app git:(master) ✗ flutter doctor -v
[✓] Flutter (Channel stable, v1.9.1+hotfix.4, on Mac OS X 10.14.6 18G84, locale zh-Hans-CN)
• Flutter version 1.9.1+hotfix.4 at /Users/fy/tools/flutter
• Framework revision cc949a8e8b (11 days ago), 2019-09-27 15:04:59 -0700
• Engine revision b863200c37
• Dart version 2.5.0
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/fy/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• ANDROID_HOME = /Users/fy/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.1, Build version 11A1027
• CocoaPods version 1.8.1
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 40.0.2
• Dart plugin version 191.8423
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] IntelliJ IDEA Ultimate Edition (version 2019.2.1)
• IntelliJ at /Applications/IntelliJ IDEA.app
• Flutter plugin version 39.0.5
• Dart plugin version 192.6262.58
[✓] VS Code (version 1.38.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.5.1
[✓] Connected device (1 available)
• iPhone • 55a7454b0af851ec72fb276cc45d3130f53d9817 • ios • iOS 13.1.2
• No issues found!

It work correct under the latest stable version v1.9.1+hotfix.4 .

Hi, @felixyin
given your last message I feel safe to close this issue,
if you disagree please write in the comments
and I will reopen it

I\ am\ trying\ to,\ wait\ a\ moment

after flutter upgrade:
Launching lib/main.dart on iPhone in debug mode...
Automatically signing iOS for device deployment using specified development team in Xcode project: XMXKKWB4BQ
Running Xcode build...
Xcode build done.                                           11.6s
Could not find the built application bundle at build/ios/iphoneos/Runner.app.
Error launching application on iPhone.

f**k,

i deploy ios to app store, what way?
i use xcode change the project name，难道就不行了？

i deploy ios to app store, what way?
i use xcode change the project name，难道就不行了？

I just trapped on https://stackoverflow.com/a/58050017, but no idea if it's actually possible to change the name and this is a bug

you can close the issue，rename to Runner that's works well.

My name has been set to Runner and I'm having the same issue.

Any idea what to do here?
I still have this issue when trying to debug iOS (iPhone XS attached via USB) using VS Code.
[  +87 ms] Application launched on the device. Waiting for observatory port.
[   +4 ms] Checking for advertised Dart observatories...
[+5016 ms] No pointer records found.
[   +3 ms] mDNS lookup failed, attempting fallback to reading device log.
[        ] Waiting for observatory port.

Output from flutter doctor -v

[✓] Flutter (Channel master, v1.12.5-pre.14, on Mac OS X 10.15.1 19B88, locale en-US)
    • Flutter version 1.12.5-pre.14 at /Users/username/Documents/dev/flutter
    • Framework revision 6e10719dc5 (3 hours ago), 2019-11-18 17:23:30 -0800
    • Engine revision 9832bc8f2e
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
    • Android SDK at /Users/username/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.2.1, Build version 11B500
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 41.1.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.40.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.6.0

[✓] Connected device (1 available)
    • iPhone • [id] • ios • iOS 13.1.3

• No issues found!

@elliott-io Do you have a specific network environment? I'm getting this issue when using the guest network at the office, but it works just fine otherwise.

i had the same issue, the problem was MacOS firewall. In firewall-settings you can choose to block all incoming connections (not the stealth mode). Everything works fine after disabling.

had issue with

@elliott-io Do you have a specific network environment? I'm getting this issue when using the guest network at the office, but it works just fine otherwise.

was related to wlan environment in a public cafè. connected with hotspot of my iphone solved the issue.

When I connected my iPhone to wifi, then It started working. For some reason, it was not working when my iPhone connected to carrier's internet

Im having the same issue, always waiting for the observatory port on any iOS device.
[  +87 ms] Application launched on the device. Waiting for observatory port.
[   +3 ms] Checking for advertised Dart observatories...
[+5027 ms] No pointer records found.
[   +3 ms] mDNS lookup failed, attempting fallback to reading device log.
[        ] Waiting for observatory port.

and there's my flutter doctor logs:
[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.15.1 19B88, locale en-ES)
    • Flutter version 1.12.13+hotfix.5 at /Users/alex/Documents/flutter
    • Framework revision 27321ebbad (3 weeks ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.1)
    • Android SDK at /Users/alex/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3, Build version 11C29
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 42.1.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.41.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.7.1

[✓] Connected device (1 available)
    • iPhone • cb08e67bf810e983f7a8034301b88e356c7bb988 • ios • iOS 13.3

• No issues found!


Add Basic Global gitignore file

We can keep adding to this as more cases pop up.

IMO, things that are user specific (OSX files, editor files) should not be in repo .gitignore files. Use global .gitignore instead.
Repo .gitignore is for build artifacts, etc.

Hmm could see us going either way on this. Advantage of keeping user-specific stuff out:

Cleaner, simpler .gitignore files
Semantically more accurate (project is just project specific stuff)
Easier to maintain

Advantages of keeping it in there:

Not everybody realizes global gitignore exists (I did not). This way when someone clone the project, they don't even worry about those files. One .gitignore to rule them all.

Well known project that has user-specific stuff:
https://github.com/mitsuhiko/flask/blob/master/.gitignore
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/.gitignore
I still lean towards a big file Kubernetes style.

No problem to make that decision as the owner. Just something to be aware of that not all project welcome personal .gitignore additions

Yes I am trying to figure out what's best for GCP projects across the board. I think we should have a standard approach, these sample projects are something we collectively own.

Lets keep this in ignore branch rather than master right now. That way project owners that want can still grab this file, but it won't clutter up projects by default. (Also what I did for the .travis.yml file) @jeffmendoza does that satisfy your concerns?

Either way is fine.

Thinking about it more I agree more with Jeff, I vote to just abandon.

SGTM


feat: display currency in receive flow

Was thinking the same things that useDisplayCurrency and usePriceConversion should be merged because its essential that the display currency stays in sync with the price feed.

we also have useUsdBtcAmount

Yup this should go away.

Ok. I think you have more context than I do so I'll let you do those changes, unless you want me to look into it


Error in get_score_color.py:6

Hi,
first of all, thanks for such nice action. I just installed it in my action pylint_badge.yaml and used the basic syntax.
However my run failed, please see attached logs.
Here's the detail of the error:
Successfully installed colorama-0.4.6 pygame-2.5.2 slack-sdk-3.26.1
Run pkgs_pth=$(python3 -c 'import re; print(" ".join(re.findall("([^\s]+)", ".")))')
  pkgs_pth=$(python3 -c 'import re; print(" ".join(re.findall("([^\s]+)", ".")))')
  pylint --exit-zero --output-format=text:pylint_score.txt,colorized $pkgs_pth
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.13/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib
************* Module .
__init__.py:1:0: F0010: error while code parsing: Unable to load file __init__.py:
[Errno 2] No such file or directory: '__init__.py' (parse-error)
Run python /home/runner/work/_actions/Silleellie/pylint-github-action/v1/get_score_color.py
  python /home/runner/work/_actions/Silleellie/pylint-github-action/v1/get_score_color.py
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.10.13/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.10.13/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.10.13/x64/lib
Traceback (most recent call last):
  File "/home/runner/work/_actions/Silleellie/pylint-github-action/v1/get_score_color.py", line 6, in <module>
    numeric_score = re.search(r"(?<=\s)(\d+\.\d+)\/\d+(?=\s)", pylint_result).group().split("/")[0]
AttributeError: 'NoneType' object has no attribute 'group'
Error: Process completed with exit code 1.

Thank you for looking into it,
Jarda

Hello, thank you for opening this issue. I will look into it and update you as soon as I can :)

Hey, sorry for the late response! The issue is that the package-path parameter in your GA points to the root of the repository, which is not a package since there's no __init__.py file. So you can solve this in two ways:

You can simply specify as package-path the python file to lint (which seems main.py in your case)
Or you can put your main.py file in a package (create a new directory with the __init__.py file) and put the path to this newly created package as value to the package-path parameter

I'm realizing that maybe "package-path" is an unfortunate name for the parameter, and maybe I should change it to "lint-path" and update the documentation for your case (which is a valid one). In the meantime, please try one of the two solutions provided and let me know!

Hey, now this issue is fully solved as the new v2 release of this github action better documents the behaviour of linting single python files.
Feel free to reopen this issue if something's wrong!


ISSUE: module 'homeassistant.components.mqtt.models' has no attribute 'Message'

Click on add Integration after install from HACS and restart; "Installing Keymaster...could not load config flow".
ODROID-N2+ Home Assistant Bundle - Blue
2021-07-29 05:50:15 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/aiohttp/web_protocol.py", line 422, in _handle_request
resp = await self._request_handler(request)
File "/usr/local/lib/python3.9/site-packages/aiohttp/web_app.py", line 499, in _handle
resp = await handler(request)
File "/usr/local/lib/python3.9/site-packages/aiohttp/web_middlewares.py", line 119, in impl
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 60, in security_filter_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 77, in forwarded_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 24, in request_context_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 78, in ban_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 144, in auth_middleware
return await handler(request)
File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 135, in handle
result = await result
File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 128, in post
return await super().post(request)
File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 63, in wrapper
result = await method(view, request, *args, **kwargs)
File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 72, in post
result = await self._flow_mgr.async_init(
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 153, in async_init
flow, result = await task
File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 171, in _async_init
flow = await self.async_create_flow(handler, context=context, data=data)
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 696, in async_create_flow
integration.get_platform("config_flow")
File "/usr/src/homeassistant/homeassistant/loader.py", line 498, in get_platform
cache[full_name] = self._import_platform(platform_name)
File "/usr/src/homeassistant/homeassistant/loader.py", line 503, in _import_platform
return importlib.import_module(f"{self.pkg_path}.{platform_name}")
File "/usr/local/lib/python3.9/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1030, in _gcd_import
File "", line 1007, in _find_and_load
File "", line 972, in _find_and_load_unlocked
File "", line 228, in _call_with_frames_removed
File "", line 1030, in _gcd_import
File "", line 1007, in _find_and_load
File "", line 986, in _find_and_load_unlocked
File "", line 680, in _load_unlocked
File "", line 850, in exec_module
File "", line 228, in _call_with_frames_removed
File "/config/custom_components/keymaster/init.py", line 30, in
from .binary_sensor import generate_binary_sensor_name
File "/config/custom_components/keymaster/binary_sensor.py", line 219, in
class OZWNetworkReadySensor(BaseNetworkReadySensor):
File "/config/custom_components/keymaster/binary_sensor.py", line 229, in OZWNetworkReadySensor
def async_check_ozw_status(self, msg: models.Message):
AttributeError: module 'homeassistant.components.mqtt.models' has no attribute 'Message'
/usr/local/lib/python3.9/site-packages/urllib3/connectionpool.py:1013: InsecureRequestWarning: Unverified HTTPS request is being made to host '<IP_ADDRESS>'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
warnings.warn(

Dupe of #208

yep you must be on the beta. We will release a beta supported version of keymaster soon


Codec and runtime support for images

First part of adding support for the <image> tag - add an encoding and decoding format.
To avoid making the main decoding loop async, we instead break it into two phases - pre-command and post command. During the precommand phase, we can decode images, paints, shaders, et cetera. Image decoding is kicked off by the listener but not awaited. Then when the decoder hits the first command, it checks if it encountered any image tags. If so, it returns an object that allows the decode call to resume for the current position. The caller is then repsonsible for ensuring that all images are decoded before invoking the decode call and passing in the same object.
This does not add compiler support yet.
https://github.com/dnfield/vector_graphics/issues/84

Removed support for encodings besides PNG, which also allowed me to drop width/height

Looks like a test is failing


sqlite3: 3.14.1 -> 3.15.0

Motivation for this change
Row values allow paging without offset :)
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Tested on Darwin

As a bonus, I enabled FTS5 which seems like an awesome full-text search extension. See it in use at http://charlesleifer.com/blog/using-the-sqlite-json1-and-fts5-extensions-with-python/#fts5-with-python

@edolstra any objections?

I had to add libm to the link flags for fts5 on nixos:
diff --git a/pkgs/development/libraries/sqlite/default.nix b/pkgs/development/libraries/sqlite/default.nix
index 57ec463..cc99b8d 100644
--- a/pkgs/development/libraries/sqlite/default.nix
+++ b/pkgs/development/libraries/sqlite/default.nix
@@ -47,6 +47,8 @@ stdenv.mkDerivation {
       export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -DUSE_PREAD64 -D_LARGEFILE64_SOURCE"
     fi

+    export NIX_LDFLAGS="$NIX_LDFLAGS -lm"
+
     echo ""
     echo "NIX_CFLAGS_COMPILE = $NIX_CFLAGS_COMPILE"
     echo ""

Thanks @Mic92!
I added that line and confirmed it to build, so since now it's tested on Linux and Darwin and there were no objections I'm merging.


[ZEPPELIN-525] Test failing in zeppelin-interpreter

RemoteSchedulerTest.test was fall when CPU switched RemoteScheduler execution (which executes a job in a separate thread) back to test main thread execution after changing job status to Status.FINISHED but before updating running jobs list:
job.setStatus(lastStatus);

// if thread execution is switched here to the main thread test will fall

synchronized (queue) {
    running.remove(job);
    queue.notify();
}

Test checked job status, saw that job was terminated and expected to see an empty jobs runing list.
while (!job.isTerminated() && cycles < MAX_WAIT_CYCLES) {
    Thread.sleep(TICK_WAIT);
    cycles++;
}

// this assert will fail because a job was not removed from running list yet
assertEquals(0, scheduler.getJobsRunning().size());

But scheduler.running list still contained the last job and the assertion failed.
What is this PR for?
The goal is to synchronize updating of a job status and a scheduler running jobs list when a job is terminated.
What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-525
How should this be tested?
You may place a Thread.sleep(1000); code to the RemoteScheduler.java class after the job.setStatus(lastStatus); (line number 354). This will increase probability of threads switching after this line. Test should not fail.
Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

look reasonable.
CI is green,  merging if no more comment

LGTM


Correctly use HttpClient instances across the entire framework

HttpClient is intended to be reused as much as possible throughout the entire application.
Internally, it uses an object of type HttpClientHandler, which actually makes the HTTP requests. By default, even when disposed, the underlying socket will not be immediately released, keeping them with the TIME_WAIT state. When in TIME_WAIT, the socket cannot be reused, and under heavy loading it can cause a socket exhaustion, preventing the system from making more requests (for a limited amount of time).
LightAPI uses an instance of HttpClient under the hood, obviously using one instance for each LightAPI instance.
As it doesn't change the default implementation of HttpClientHandler, we will inevitably face the problem above.
To fix this problem, Microsoft created a library called HttpClientFactory, which managed the creation of HttpClient instances and their HttpClientHandler's.
The Liquid Framework should use this library by default when dealing with HttpClient-based requests.
HttpClientFactory can also be extended. By default, it has options for setting up resilient requests for every HttpClient created (the same thing as LightAPI does, and it also uses Polly)

Completely agree. Do you belive this to be priority? Are we seeing errors related to socket pool exhaustion?

As I have not used Liquid in a production environment scenario, I have not seen it yet, but setting up manual stress testing (using real life numbers, not absurd values), I was able to face port exhaustion occasionally.
At the same time I think it's an important issue, we still have other crucial problems to solve (such as stopping calling asynchronous methods synchronously).
I would like to reiterate that I still haven't used Liquid in production yet and an exhaustion (in heavy loading) is a strong possibility to happen.
So I'd consider this not to be a priority at the moment.

I'll mark it as a bug, but we will treat it as low priority.


IFileSystem.fileExists returns false even when a file exists.

This breaks conda and virtual environments

These environments are no longer listed as interpreters, hence absolutely nothing works for conda or virtual environments.

In master.
I believe the logic of checking the file stat is incorrect.
We're checking if the file type == FIle when checking if a file exists.
However fstat could indicate that its a symbolic link.
Not sure this is the issue, but likely. Either way still is incorrect.
I.e. I don't think we should be comparing == File, we might want to check if !== Directory instead. I.e. allow other values except directory. I.e. its possible Unknown could be returned for a file (just as with symbolic links & others).
Proposed solution

If checking for a file, then ensure fstat !== direcrtory
If checking for a directory, then ensure fstat !== file

The problem is we're treating the FileType as an enum and comparing ===.
However these are bit values and we need to use bitwise operations.

Other issues across the code:

We have other issues in the code as well if (await this.fs.fileExists(dir)) {
Checking === instead of using bitwise operations.

    public async getFiles(dirname: string): Promise<string[]> {
        return (await this.listdir(dirname))
            .filter(([_name, fileType]) => fileType === FileType.File)
            .map(([name, _fileType]) => this.paths.join(dirname, name));
    }

I think the changes as part of IFileSystem PR contain two things:

Change IFileSystem implementation to use vscode API
Change extension code to use IFIleSystem instead of native fs access
Other changes?

I think both should have been done separately and incrementally.

The old code for fileExists() used fs.Stats.isFile(), which is equivalent to checking for FileType.File.  I don't think there's a need to change that approach.

@ericsnowcurrently
Please see my comment here https://github.com/microsoft/vscode-python/issues/8890#issuecomment-561781532
That's where the bug is.

Right.  I have a fix for that. :)


Fixed a spelling mistake

Small error in the Detailed Explanation section.

Math typos, the worst kind! thank you


Add fusion calling to rnaseq pipeline

pizzly (a fusion caller that uses evidence from kallisto) and grolar (parses pizzly output into more readable form) need to be added to the rnaseq pipeline

Yup, closing now


Merging changes from Zoubarevm

Merging changes from Zoubarevm in issue https://github.com/tabler/tabler-react/issues/20.

Closing this due to version 2 being written in typescript


v1.13 Release Planning

Release team
Release lead: @JoshVanL
Release lead shadow(s): @mikeee
Perf test lead:  @yaron2
Longhaul test: TODO
Build manager: TODO
Read about the Dapr release lifecycle
Milestone dates
Feature definition starts:  2023-10-24
Feature definition ends: 2023-11-07
Feature freeze: 2023-12-19
Code freeze (Endgame starts ~2 weeks stabilization): 2024-01-16
RC Release day: ~2024-01-30
Announcement day: 2024-02-15 < - Docs, Samples and Runtime, CLI, Release notes
Feature proposals that impact multiple repos, that maintainers can use to triage
Priorities for this release

[x] [P0] New name resolver https://github.com/dapr/dapr/issues/3256
[ ] [P0] Presence of AppChannelAllowInsecureTLS feature flag https://github.com/dapr/dapr/issues/7149
[x] [P0] Go 1.21 https://github.com/dapr/dapr/issues/7228
[ ] [P0] Hot reloading (Components) https://github.com/dapr/dapr/issues/1172

[ ] [P1] Hot reloading (Resiliency) https://github.com/dapr/dapr/issues/5435
[ ] [P1] Hot reloading (Subscriptions) https://github.com/dapr/dapr/issues/7139

[ ] [P0] Identity improvements https://github.com/dapr/dapr/issues/5756
[x] [P0] Metrics cardinality https://github.com/dapr/dapr/pull/6919 needs docs
[ ] [P0] Distributed scheduler planning+beginning implementation https://github.com/dapr/proposals/pull/44
[ ] [P0] Workflow as stable {Phase 1} https://github.com/dapr/dapr/issues/7156
[ ] [P0 needs owner] Bulk pubsub as stable https://github.com/dapr/dapr/issues/7157
[ ] [P1 start work] Component Resiliency (TODO) @berndverst
[ ] [P1] Auto-configure middleware pipelines https://github.com/dapr/dapr/issues/6660
[ ] [P1] Reduce the flakyness in E2E tests https://github.com/dapr/dapr/issues/7128
[ ] [P1] Error code standardization https://github.com/dapr/dapr/issues/6068
[ ] [P1] Trust distribution https://github.com/dapr/proposals/pull/42 & CA rotation https://github.com/dapr/dapr/issues/5958
[ ] [P1 needs owner] Local developer experience https://github.com/dapr/cli/issues/1354
[ ] Not service invocation for non Dapr endpoints (TODO) @yaron2  ~
[ ] [P1] Actor state TTL https://github.com/dapr/dapr/issues/5899
[ ] [P1] Implement DAPR_API_TOKEN across SDKs

[ ] https://github.com/dapr/rust-sdk/issues/111
[ ] https://github.com/dapr/cpp-sdk/issues/59
[x] https://github.com/dapr/js-sdk/issues/547

[ ] [P1] Actor Log and metrics improvements (Delete Actor support, Diagnostics Logs in actor State store logs)

[ ] https://github.com/dapr/dapr/issues/6992
[ ] https://github.com/dapr/dapr/issues/6993

[ ] [P1 needs owner & proposal] Dapr SDKs constructing a Service Invocation client with resiliency, TLS etc. (TODO) @mikeee
[ ] [P1 EPIC] Contributor docs improvements https://github.com/dapr/dapr/issues/5885

Not prioritized

Migrating redis to SQLite as default state store

Moved to v1.14

[ ] [P1 needs owner] Scoping Dapr to run in a single namespace natively https://github.com/dapr/dapr/issues/6611
[ ] [P1 needs owner] GRPC middleware https://github.com/dapr/dapr/issues/4153
[ ] [P2 needs owner] Change logger to slog, implemented by zap or similar. https://github.com/dapr/dapr/issues/6129 (needs issue in dapr/kit).

Repo milestones
Dapr - https://github.com/dapr/dapr/milestone/TODO
CLI - https://github.com/dapr/cli/milestone/TODO
Docs - https://github.com/dapr/docs/milestone/TODO
Components-contrib - https://github.com/dapr/components-contrib/milestone/TODO
Java-SDK - https://github.com/dapr/java-sdk/milestone/TODO
Python-SDK - https://github.com/dapr/python-sdk/milestone/TODO
Dotnet-SDK - https://github.com/dapr/dotnet-sdk/milestone/TODO
Js-SDK - https://github.com/dapr/js-sdk/milestone/TODO
Go-SDK - https://github.com/dapr/go-sdk/milestone/TODO
Dashboard: https://github.com/dapr/dashboard/milestone/TODO
Quickstarts (aka Tutorials) - https://github.com/dapr/quickstarts/milestone/TODO

What is the plan for #4541 please?

Endgame issue: https://github.com/dapr/dapr/issues/7410

What is the plan for #4541 please?

Commented on the issue

According to the log provided by dapr runtime in 1.12.4, NATS streaming will be removed with version 1.13, but we could not fully switch to JetStream due to parallel processing and dependency on this component throughout our applications. What is the plan for 3115

According to the log provided by dapr runtime in 1.12.4, NATS streaming will be removed with version 1.13, but we could not fully switch to JetStream due to parallel processing and dependency on this component throughout our applications. What is the plan for 3115? ty

Responded on https://github.com/dapr/components-contrib/issues/3115

Dapr v1.13 has been released https://github.com/dapr/dapr/releases/v1.13.0


Error for duplicating DNS records doesn't have a proper error message.

Description
When I tried to create a DNS record with same name, type, and value on staging, it would give me this error message page:

While it does prevent users from duplicating DNS records, I imagine the message is not very helpful for users, so some text should be there to explain what's wrong.
Recreating the bug
On staging, create 2 DNS records with the same name, type, and value.

Some update:
After talking to Denes, it seems it shouldn't even throw error when creating duplicates of same name+type+value.
Also, the error screen is currently without the text:

STR:

create an A Record with name test and value <IP_ADDRESS>
create a second A Record with name test and value <IP_ADDRESS>
notice the Application Error

Discussion from meeting today: we should rename doesDnsRecordExist to isDuplicateCname, and change the logic so that it only errors if the record is a CNAME with a value that already exists (i.e., we'd allow duplicates of other types of records):
https://github.com/DevelopingSpace/starchart/blob/main/app/models/dns-record.server.ts#L111-L132

I think it should be OK, since our PK is an incrementing integer.  If it's going to break something, I'm also OK with not allowing it. We're not building DNS for an advanced user, only for students who can't manage it on their own.

Yeah, I don't think it would break the database.


Weird Electron Webpack Error

[0]   WARNING in ./node_modules/shell-env/node_modules/cross-spawn/index.js
[0]   Module not found: Error: Can't resolve 'spawn-sync' in '/Users/nem/code/sme/spear/sal/node_modules/shell-env/node_modules/cross-spawn'
[0]    @ ./node_modules/shell-env/node_modules/cross-spawn/index.js 32:26-47
[0]    @ ./node_modules/shell-env/node_modules/execa/index.js
[0]    @ ./node_modules/shell-env/index.js
[0]    @ ./node_modules/shell-path/index.js
[0]    @ ./node_modules/fix-path/index.js
[0]    @ ./src/main/index.js
[0]    @ multi ./node_modules/electron-webpack/out/electron-main-hmr/main-hmr ./src/main/index.js

Yet I do not see cross-spawn being used anywhere in this code base up from 0.3.0.
0.3.0 is where I am seeing this issue and cross-spawn does exist in our project dependencies but as a devDependency only. cross-spawn is also only being used by a unit test.
Anyway I was wondering if anyone had any ideas?

Ahh here is why. This was not fixed until 6.X .

So to resolve this y'all need to update execa in here to something newer using cross-spawn 6.X .
https://github.com/sindresorhus/execa/blob/master/package.json


fix: Set an unknown label when the user is not found

@mergify queue

@mergify dequeue

@mergify queue


Migrate Next.js images to the new future image component

What internal change would you like to have?
Migrate Next.js images to the new future image component.
What problem will this change solve?

Better performance
Anticipate migrating to this component in the next Next.js major

Do you want to help make the feature?
Yes
Is there anything else we need to know?
No response

Next.js v12.3.0 merged, this can be done now.


[clkmgr, top] Test case for frequency measurement / timeout through low power

The frequency measurement / timeout features in clkmgr typically do not work with dynamic clock gating or clock switches.
The only exception is when the measured clocks are specifically requested by pwrmgr via the enable inputs to shut-off.
In these cases, the measurement / timeout modules should automatically disable since one of the clocks is about to go offline.
We should create either a chip level or a block level test case to target this scenario and ensure that the measurement / timeout features can be turned on and left in place.
There may already be a test for this, it should be double checked.

@jeoongp FYI

The chip_sw_ast_clk_outputs, chip_sw_clkmgr_sleep_frequency, and chip_sw_clkmgr_reset_frequency tests check this.
Tim, are you okay if I close this?

Closed after consultation with Tim.


[WPT_ChromeDriver] Unstable test test_invalid_address[port\]

test_invalid_address[port\]

Successful run.
Failed run.

test_invalid_address[host]

Successful run.
Failed run.

When I run it locally, it passes ~all the time.
Maybe the instability is present solely in the CI environment.


CI: Update and modernize

Use build to build sdist
Run mypy
Test import before installing test requirements
Switch python 3.6 to ubuntu-20.04
Add python 3.11

This will fail, so I'll add a second commit we can revert later that disables the mypy and pytest steps.

Not intended to be squashed.


build(.devcontainer): add gh CLI

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #411

Relates to
https://github.com/freeCodeCamp/classroom/pull/395
https://github.com/freeCodeCamp/classroom/pull/396
and https://github.com/freeCodeCamp/classroom/pull/439

Please contact @GuillermoFloresV if you have further questions about this. Thanks!

Already done by https://github.com/freeCodeCamp/classroom/pull/396


Sends User to uFrame when plotting

@oceanzus uFrame now requires a "user" field for all Synch requests.  This fixes plotting.

@oceanzus


Sealer delete node needs to be stable enough to be as error-free as possible

sealer delete may also fail when executed after an installation failure, so sealer delete needs to be stable enough.

Hi @bxy4543 , can you assign to me?

Hi @bxy4543 , can you assign to me?

sure, thank you for your contribution

Hi @bxy4543, I read the source code for the sealer delete process. Sealer delete will return failed if there is no cluster file under $HOME/.sealer folder. Then it mast do some clean work manually based on the faq description. http://sealer.cool/docs/help/faq.html#how-to-clean-host-environment-manually-when-sealer-apply-failed
So, how about add clean works to the delete process  when the cluster file inexistence such as follow:

umount rootfs or apply mount if it existed
delete rootfs directory if it existed
delete kubernetes directory if it existed
delete docker registry if it existed
kubeadm reset
delete kube config and kubelet if it existed

@neo502721
I think we only need to think about Clusterfile when it exists.
You listed clean works correctly. need a little tweaking:

delete docker registry if it existed
kubeadm reset force, if it existed
delete kubernetes directory if it existed
delete kube config and kubelet if it existed
if rootfs existed {
exec rootfs/scripts/clean.sh if it existed
umount rootfs dir and umount mount dir if it mounted
delete rootfs directory if it existed
}

@neo502721 I think we only need to think about Clusterfile when it exists.
You listed clean works correctly. need a little tweaking:

delete docker registry if it existed
kubeadm reset force, if it existed
delete kubernetes directory if it existed
delete kube config and kubelet if it existed
if rootfs existed {
exec rootfs/scripts/clean.sh if it existed
umount rootfs dir and umount mount dir if it mounted
delete rootfs directory if it existed
}

I found all those process already exists when the Clusterfile exists scenario. Maybe only need a small change like add rm -rf /usr/bin/kube* about RemoteCleanMasterOrNode.
https://github.com/alibaba/sealer/blob/331b8bc729e0da3078e788a1b7a495fd99d15851/pkg/runtime/masters.go#L57
So, this issue want to refactor the delete process or anything else？

yes, just a little bit of optimization is enough.

Need to make sure that delete is also successful after installation error.
For example, if the rootfs directory does not exist, executing the $rootfs/scripts/clean.sh step in unmountRootfs will report an error, and skip it if it is necessary to judge that the rootfs does not exist.
https://github.com/alibaba/sealer/blob/331b8bc729e0da3078e788a1b7a495fd99d15851/pkg/filesystem/filesystem.go#L236
add rm -rf /usr/bin/kube*


WakuMessage is missing waku pubkey and signature

I'm submitting a ...
[ ] bug report
[X ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary

WakuMessage is missing the Waku pubkey and message signature.

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

This is useful for dapps that want to confirm origin and authenticity of message

Should be sorted with #74

I had more thought on that, see https://forum.vac.dev/t/eth-dm-learnings-and-what-is-next/84

This may be a dupe of https://github.com/vacp2p/rfc/issues/373 actually as we have yet to define format and schema to use.
Would you want it being only signature or always coupled with encryption?

@bgits can you please go in more details on your expectations here?
What signature scheme would you expect? What is your use case? We are thinking about providing a standard way to do encryption and signature with Waku (see https://github.com/vacp2p/rfc/issues/373) but we'd need more concrete information on your needs to be sure we go in the right direction.

@bgits can you please go in more details on your expectations here?
What signature scheme would you expect? What is your use case? We are thinking about providing a standard way to do encryption and signature with Waku (see vacp2p/rfc#373) but we'd need more concrete information on your needs to be sure we go in the right direction.

Effectively a dapp should be able to verify a message itself (https://docs.ethers.io/v5/api/utils/signing-key/#utils-verifyMessage).
This can be used for several cases. The main cases I have in mind are around creating proofs. In applications that require data submission this could be used to create proofs that later allow submitters to claim compensation by proofing ownership of the key to claim onchain.

Thanks, so your focus would be in signing using the user Ethereum's account to possibly push the data on the blockchain. Noted.

Thanks, so your focus would be in signing using the user Ethereum's account to possibly push the data on the blockchain. Noted.

Not signing the Ethereum account but claiming from any Ethereum account. In order to do that they need to create a proof using their Waku key.
Another use case could be for incentives around Waku itself. Nodes can accumulate signed messages from other nodes when relaying or storing and then reconcile occasionally on the main chain.

@bgits What do you mean by "Waku key" exactly? There is no such term in https://rfc.vac.dev/spec/10/ and in https://rfc.vac.dev/spec/11/#protobuf-definitions we explicitly disable it due to StrictNoSign policy (privacy).
At the WakuMessage layer https://rfc.vac.dev/spec/14/#version-1 with version=1 there's a concept of keys, but key agreement is out of band. This is the same method as with Waku v1 with SECP-256k1 ECDSA and providing for asymmetric/symmetric encryption/signatures see https://rfc.vac.dev/spec/7/ and https://rfc.vac.dev/spec/6/#payload-encryption This signature is only accessible if you are able to decrypt the payload (privacy).
There is also PeerId at libp2p level which may or may not be the same https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md
For the Status protocol specifically, Whisper/Waku key is a pubkey for chat with HD derivation path m/43’/60’/1581’/0’/0 see https://specs.status.im/spec/2#terms-glossary  and https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1581.md (In addition to the double ratchet protocol, which sits on top). This isn't enforced at Waku layer, but would generally be seen as good practice to decouple Ethereum address from Chat address (though this depends on use case).
In the chat2 example only symmetric key is used and derived from the content topic, similar to Status public chats.

In general, I'd suggest we try to find a way to use Waku Message version 1, unless we have some fundamentally strong reasons not to. It is fairly agnostic to exactly where the keys come from etc. Using any ECSDA keypair - including Ethereum key - it should be possible to do a claim from any Ethereum account, with a combination of signatures and out of band key discovery or a derivable symmetric key (secret, pseudo-secret or transparent).
Exactly what that looks when it comes to interacting with a dapp etc I'm not 100% sure on and would require a bit more though, but it seems to me like we have all the building blocks necessary already?

I'm also thinking about Waku incentivization, regardless of what the design will look like, it seems there would need to be reliance on someone proving message origination. I agree speaking about keys specifically may not be the only solution, perhaps there are ways to do this in zero-knowledge as well.

@bgits happy to talk/hear ideas re Waku incentivization, let's do that outside of this issue though to keep it more limited in scope

Moving the discussion to the forum as I think there should be a broader discussion about encryption/signature in waku v2: https://forum.vac.dev/t/signature-and-encryption-in-waku-v2/85

@bgits I saw you mentioned

proving message origination.

Is the message private or public?
If it is public, then everyone can claim ownership of the message. In this case, the signature does not help. Let's say there is a message m that is a solution for a puzzle and anyone who knows it will be rewarded. In such a case, if someone publishes m and a signature on m cannot prove the ownership, because someone else can see and copy m and make a similar claim.
However, I guess you are looking for the non-repudiation property of signatures i.e., the signer of a message won't be able to deny her signed message. Then, you want to track down the signer's public key (signature verification key) and e.g., remove it from the system (some sort of punishment).  Is this what you want?
In any case, as also @oskarth mentioned, the use of signature is disabled in waku v2 to preserve user anonymity. Otherwise, all the messages signed by the same user are linkable. We might be able to think about using zero-knowledge proof, but the use-case must be clear.  For example, in the case of voting, zero-knowledge proof of membership must work, similar to what we are doing in RLN-Relay https://rfc.vac.dev/spec/17/ https://vac.dev/rln-relay

I believe this is now done, see the task list in the description.
if Waku Message version 1 lacks some characteristics that you need, please open an issue or discussion in https://github.com/vacp2p/rfc first.
If you encounter any issue using version 1 with js-waku or question, feel free to open a new issue!


[Storage] Fix issue #14054 to avoid None type error

Description

Add check for None type
Add message in debug information for loading module error

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Storage

/azp run

/azp run

/azp run

Please follow the PR title convention:

[Storage] Fix #14054: Avoid NoneType error

And link this PR to the original issue with

Fix #14054

in the PR description.


Run locally on MacOS

Describe the issue
Could we run the bot locally on MacOS?

If by "the bot" you mean any application-hosted media bot, then no. Perhaps with a virtual machine running Windows on top of your MacOS.
If you are talking about remote-media bots, then yes. You can run those on MacOS. They don't rely on Windows platform specifics.
See this documentation for choosing between the two. If your use-case is best covered by application-hosted media, then you will not be able to run/host the bot on MacOS platform.


Reduce cubic interpolated animation hitch

Reduce cubic interpolated animation hitch
Cubic interpolation didn't wrap around first and last keys, clamping
pre and post keys to first and last before interpolating values.
Fixes #20087

Thanks for opening a pull request :slightly_smiling_face:
Pull requests (especially ones that break backwards compatibility) should be opened against the master branch instead of 3.x. This is because feature development occurs in the master branch. We can then cherry-pick specific PRs to the 3.x branch if they don't break backwards compatibility.

Pull requests should be opened against the master branch instead of 3.x (as long as the feature/fix is relevant for master). This is because feature development occurs in the master branch. We can then cherry-pick specific PRs to the 3.x branch if they don't break backwards compatibility.

Sorry, I can't PR against master branch because I can't test changes as my machine is not vulkan capable (and not even sure it compiles at all). I was looking for bugs in the 3.x branch for that reason, but I forgot this bug was still present in master.
My apologies.

I can't PR against master branch because I can't test changes as my machine is not vulkan capable (and not even sure it compiles at all).

The master branch now has OpenGL support for 2D rendering, which you can enable by using the --rendering-driver opengl3 --single-window command line arguments:
You can create a new project from the command line as follows:
touch /tmp/test/project.godot
~/godot/bin/godot.linuxbsd.tools.64 --rendering-driver opengl3 --single-window /tmp/test/project.godot

The master branch now has OpenGL support for 2D rendering, which you can enable by using the --rendering-driver opengl3 --single-window command line arguments.
You can create a new project from the command line as follows:
# Create an empty `project.godot` file within a folder.
mkdir -p /tmp/test
touch /tmp/test/project.godot

# Replace "~/godot/bin/godot.linuxbsd.tools.64" with the path to your compiled Godot executable.
~/godot/bin/godot.linuxbsd.tools.64 --rendering-driver opengl3 --single-window /tmp/test/project.godot

The 3D editor viewport won't display anything, but you should be able to switch to the 2D tab and see sprites added there.

Amazing! I'm trying to compile it right now, disabling all third party modules that throw errors. if I'm able to make it run, I could replace this PR with a new one against master, and try to use it for future ones.
Thanks!

The PR for master is #54811
I was able to compile it patching 2 thirdparty libraries (icu4c and basis_universal). Should I open an issue/PR for them or they are outside Godot scope being thirdparty libs?
Although the editor works (in 2D as you said), I can't run the scenes. I got this message:
Your video card driver does not support any of the supported Vulkan or OpenGL versions.
Please update your drivers or if you have a very old or integrated GPU, upgrade it.
If you have updated your graphics drivers recently, try rebooting.

For this PR this was not a problem, as the hitch was noticeable directly in the editor.

I was able to compile it patching 2 thirdparty libraries (icu4c and basis_universal). Should I open an issue/PR for them or they are outside Godot scope being thirdparty libs?

We don't modify thirdparty libs unless we really can't fix issues differently. I'm not aware of any build issue for those libs on any platforms supported in our official builds though, I assume you're on a more exotic system? Please open issues for these.

Note: Perhaps this whole text should be it's own issue entry. I can move it to one if you want and delete it here. Thanks in advance, and I know this is not a common-enough scenario to be really attendend.

I assume you're on a more exotic system? Please open issues for these.

Yes, I'm on FreeBSD. Before opening issues for this (for basis_universal is only add one more defined comparison to get the same #include as MacOS), I want to confirm the building module system is working as expected.
I mean, I understand that they are options and modules (mainly talking about icu4c here) that can be enabled or disabled because:

They are optional and not needed to compile a working version of Godot, and/or
They can be provided system wide (aldreay present in the OS) instead as a Godot module when compiling.

When I tried to compile with builtin_icu=no, compilation fails due to others thirdparty modules dependences on it:
[ 29%] build_gdnative_api_struct(["modules/gdnative/include/gdnative_api_struct.gen.h", "modules/gdnative/gdnative_api_struct.gen.cpp"], ["modules/gdnative/gdnative_api.json"])
[ 32%] modules/text_server_adv/text_server_adv.cpp:38:10: fatal error: 'thirdparty/icu4c/icudata.gen.h' file not found
#include "thirdparty/icu4c/icudata.gen.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 34%] 1 error generated.
[ 37%] tza_to_cpp(["thirdparty/oidn/weights/rtlightmap_hdr.gen.cpp"], ["thirdparty/oidn/weights/rtlightmap_hdr.tza"])
scons: *** [modules/text_server_adv/text_server_adv.linuxbsd.tools.64.llvm.o] Error 1
scons: building terminated because of errors.
[Time elapsed: 00:00:28.468]

So, I proceed with module_text_server_adv_enabled=no, and then it's the turn for basis_universal to fail. Again, no problem, time to disable that module too with module_basis_universal_enabled=no, and continue compiling.
And then, finally, when we try to execute it following the previous indication for OpenGL, we have a core dumped:
$ godot.linuxbsd.tools.64.llvm --rendering-driver opengl3 --single-window -e .
Godot Engine v4.0.dev.custom_build.e8870ddef - https://godotengine.org
ERROR: Property not found: rendering/quality/2d/use_nvidia_rect_flicker_workaround
   at: _get (core/config/project_settings.cpp:246)
ERROR: Property not found: rendering/quality/shading/force_lambert_over_burley
   at: _get (core/config/project_settings.cpp:246)
ERROR: Property not found: rendering/quality/shading/force_blinn_over_ggx
   at: _get (core/config/project_settings.cpp:246)
OpenGL Renderer: Mesa DRI Intel(R) HD Graphics 3000 (SNB GT2)
ERROR: Condition "!props.has(p_prop)" is true.
   at: set_custom_property_info (core/config/project_settings.cpp:977)
ERROR: Condition "!props.has(p_prop)" is true.
   at: set_custom_property_info (core/config/project_settings.cpp:977)
ERROR: Property not found: rendering/quality/2d/use_software_skinning
   at: _get (core/config/project_settings.cpp:246)
ERROR: Property not found: rendering/quality/2d/ninepatch_mode
   at: _get (core/config/project_settings.cpp:246)
  Undefined symbol "snd_dlpath"
  Undefined symbol "snd_config_is_array"
W: [(null)] caps.c: Normally all extra capabilities would be dropped now, but that's impossible because PulseAudio was built without capabilities support.

ERROR: TextServer: Unable to create TextServer interface.
   at: setup2 (main/main.cpp:1859)
ERROR: A Thread object has been destroyed without wait_to_finish() having been called on it. Please do so to ensure correct cleanup of the thread.
   at: ~Thread (core/os/thread.cpp:124)
Segmentation fault (core dumped)

First of all, compiled with the patched modules (with all the default modules enabled at compilation time) works good enough. Secondly, we can really ignore the core dump, as the important part is the ERROR: TextServer: Unable to create TextServer interface. message I think. Is module_text_server_adv mandatory?
Perhaps if the text_server_adv module could use system wide ICU, then no additional module modification would be needed at all. Otherwise, disabling the ICU module should disable text_server_adv automatically.
I don't mind trying to generate elaborated patches to thirdparty modules if it will fix the compilation problem to a runnable executable.

If you disable text_server_adv, you need to enable text_server_fb (fallback), which has less features but should give you a functional editor.
But yes, please open issues about the compilation problems for basis_universal and icu4c, they should be fixed.

Fixed by #54811.

Closing as superseded by #54811 so we keep reviews in a single place (the master PR should be trivial to cherry-pick to 3.x once approved and merged).

I was too fast, the master PR says that things likely need a different implementation for 4.0 so it definitely makes sense to keep the 3.x implementation around.

Superseded by #58651.


Fix/#593 incomplete debug message

Closes #593

Thanks to your reproduction and logs, I could verify that indeed the debug message was split in between.


Error: Unable to fetch auth token. Error: (invalid_request) AADSTS90014: The request body must contain the following parameter: 'client_id'.

This is a just reporting.
On my O365 enterprise environment, account.connection.request_token fails with following error.
Unable to fetch auth token. Error: (invalid_request) AADSTS90014: The request body must contain the following parameter: 'client_id'.
To resolve issue, I modified request_token in connection.py as follows.
    def request_token(self, authorizated_url, store_token=True, token_path=None):
:
:
        if self.session is None:
            raise RuntimeError("Fist call 'get_authorization_url' to generate a valid oauth object")
        client_id, client_secret = self.auth  #<<<<
:
:
        try:
            self.token = self.session.fetch_token(token_url=self._oauth2_token_url,
                                                  authorization_response=authorizated_url,
                                                  client_secret=client_secret,
                                                  client_id=client_id) #<<<<

For me it works without passing the client_id.
I'll check if it works also passing the cliend_id and commit the change if all is ok.
Thanks!

client_id is now passed to fetch_token as you requested.


Open Mobile Map (mmpk) sample

I'm opening this PR to track work related to the sample for opening a mobile map from an mmpk.

At this point most platforms are done, but Android is still WIP.

@dkemlage Can you take a look at this when you get a moment? Pending any review suggestions, I believe this is ready to go.

I'm closing this PR per Mike's feedback. I'll open another PR once I've implemented the correct approach to offline data for this sample.


Add a way to programmatically change the selected items

Hi,
I need to chage the selected items programmatically this widget but I don't found a way to do this after setting the initial items parameter.
The only way I can make this kind of changes is creating a new unique key for each rebuild, making flutter discard the old state and create a new from the initial items but I think it is not very efficient.
Thank you.

@victorcatn Hello,
Can you clarify how you would like to manage the selected items and which widget you are trying to do this with?
A code example would also be helpful.
Typically, I'll have my own list of selected items set as the initialValue, and just manage that.
initialValue not working as expected #5 - maybe this is relevant

#40 I was able to do it by modifying the build method of the widget refer to the issue motioned. In bloc architecture it is not possible to maintain the same reference value as with each sate change entire new object is created with a new reference. So unless the internal reference of the _selectedItems is updated it will not be possible to modify it in the bloc architecture .

@CHB61 Are you planning to work on this issue, please?

Hi,
I need to manage the selected items from outside this widget but I don't found a way to do this after setting the initial items parameter.
I tried creating a GlobalKey and changing its state but didn't work. The only way was creating a new unique key for each build, making flutter discard the old state and create a new from the initial items but I think it is not very efficient.
Thank you.

If your goal is to update the selected items by clicking on the chip, It can be done by returning the updated value at the MultiSelectChipDiplay::onTap method, like so:
onTap: (item) {
    _selectedAnimals.remove(item);
    return _selectedAnimals;
}

I think the thing that people are asking for is some kind of controller to programmatically change the content of the selected items. Currently I think the reason people are having problems is because "initialValue" is the only way to set the internal state without selecting things from a dialog or sheet. In multi_sellect_dialog_field.dart its only use is
  void initState() {
    super.initState();
    if (widget.initialValue != null) {
      _selectedItems.addAll(widget.initialValue!);
    }
  }

this doesn't allow for changing the internal state after the widget has been created. It would be nice if there were a way to do this without manually destroying the widget and rebuilding it.

Thanks for the PR niccord! Can anyone with permissions please review the PR and approve to get this added functionality? I would need it but am happy to help if I can :)

I solved this problem by interfering with the library. This works for me.
I took the set code of the library and wrapped it with the GetStorage block. In this way, I would be able to trigger my code from the outside. (You can use something else to trigger it. It will probably work.) The main reason I'm doing this here is that setState cannot interfere with the library from outside.
I added the set initial default value part.

Here, I have run my code by triggering it under any method.

Good job everyone, hope it works for you.

I think the thing that people are asking for is some kind of controller to programmatically change the content of the selected items. Currently I think the reason people are having problems is because "initialValue" is the only way to set the internal state without selecting things from a dialog or sheet. In multi_sellect_dialog_field.dart its only use is
  void initState() {
    super.initState();
    if (widget.initialValue != null) {
      _selectedItems.addAll(widget.initialValue!);
    }
  }

this doesn't allow for changing the internal state after the widget has been created. It would be nice if there were a way to do this without manually destroying the widget and rebuilding it.

How do you manually destroy and rebuild it?

Set the 'key' parameter to GlobalKey(). Ex:
MultiSelectChipField<String?>(                                 key: GlobalKey(), )

@asanet Can You help me in programmatically change the selected items?

@asanet Can You help me in programmatically change the selected items?

Hi @prkhrv !
I am doing this way:
MultiSelectChipField<String?>(     key: GlobalKey(), // You must set the key parameter to GlobalKey(), otherwise setState wont work     scroll: false,     selectedChipColor: Colors.grey,     chipColor: Colors.black,     chipShape: RoundedRectangleBorder(         borderRadius: BorderRadius.circular(100),         side: BorderSide(color: Colors.grey, width: 2)     ),     textStyle: TextStyle(color: Colors.grey),     selectedTextStyle: TextStyle(color: Colors.white),     decoration: const BoxDecoration(border: null),     initialValue: _selectedValues, // This is a list of strings with the selected values     headerColor: Colors.black,     showHeader: false,     items: List.generate(         _allValues.length,         (index) => MultiSelectItem(             _allValues.elementAt(index), // My labels are the same of my values             _allValues.elementAt(index),         )     ),     icon: Icon(Icons.check, color: Colors.green),     onTap: (values) {       setState(() {         _selectedValues = values; // Setstate the value.       });     },   ),

@asanet Thanks a Lot!

Set the 'key' parameter to GlobalKey(). Ex:
MultiSelectChipField<String?>( key: GlobalKey(), )

Thank you guy. I think that is best solution for the moment.

@asanet Can You help me in programmatically change the selected items?

Hi @prkhrv !
I am doing this way:
MultiSelectChipField<String?>(
    key: GlobalKey(), // You must set the key parameter to GlobalKey(), otherwise setState wont work
    scroll: false,
    selectedChipColor: Colors.grey,
    chipColor: Colors.black,
    chipShape: RoundedRectangleBorder(
        borderRadius: BorderRadius.circular(100),
        side: BorderSide(color: Colors.grey, width: 2)
    ),
    textStyle: TextStyle(color: Colors.white),
    selectedTextStyle: TextStyle(color: Colors.white),
    decoration: const BoxDecoration(border: null),
    initialValue: _selectedValues, // This is a list of strings with the selected values
    headerColor: Colors.black,
    showHeader: false,
    items: List.generate(
        _allValues.length,
        (index) => MultiSelectItem(
            _allValues.elementAt(index), // My labels are the same of my values
            _allValues.elementAt(index),
        )
    ),
    icon: Icon(Icons.check, color: Colors.green),
    onTap: (values) {
      setState(() {
        _selectedValues = values; // Setstate the value.
      });
    },
  )

Everytime I want to change the selected values, I change the variable "_selectedValues" then I call setState. This only works with you attribute the GLobalKey() to the parameter "key" in MultiSelectChipField.
Hope it helps!

Great, Thanks brother. It works.


Cache warming

Add functionality to re-cache pages that were cleared on a Craft event.

I'll just +1 this.
Though thanks for this plugin!

@maxstrebel Thanks for the feedback and support. I'm curious, do you use this plugin in any production sites you've built? We use it on all our client sites but we are not aware of anybody outside of our agency using it.

@ryanbrookepayne I'm just about to use it in a weird constellation. I use craft as a kind of static site generator for a client which is not allowed to host neither a CMS nor to use element-api. Though I have to confess: if this works out well, I'll also use it to warm the cache in other projects - not with varnish but with presto cache plugin.

@maxstrebel Good deal. Well let me know it works out and feel free to submit an issue if you run into any problems or have suggestions.

@ryanbrookepayne sure thing, I will. One thing to note – I'll have to make the file ending dynamic (because in this case I'll need .php files as output).
Would you welcome a dynamic implementation, where the default can changed from html to php as a pull-request?
Something like this, linked to a setting field?
$extension = isset($pathInfo['extension']) ? pathInfo['extension'] : settings.cacheDefaultExtension;

@maxstrebel yeah man. feel free to submit and we'll take a look. Not sure if we'll ever have an implementation like that, but it wouldn't hurt to have it in there.


Method not found: Error

I keep getting the error in the attached image

I am using visual studio 2019 ver 16.8.5
I have downgrade the model builder and still got the error.
I have re-upgrade and still the same error.
molder builder error.txt
I was trying to go through ML.net tutorial text classification.
thank you for your help

Hi @Picaso2
Did you also try other datasets or other scenarios? Does that also cause the same error?

Hi
I get the same error doing another project.
From: Xiaoyun Zhang<EMAIL_ADDRESS>Sent: Wednesday, February 24, 2021 1:23 PM
To: dotnet/machinelearning-modelbuilder<EMAIL_ADDRESS>Cc: Picaso2<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [dotnet/machinelearning-modelbuilder] Method not found: Error (#1259)
Hi @Picaso2https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPicaso2&data=04|01||14e38ac309524e515c4e08d8d8f13125|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637497877711067713|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=KteDGOdYodbloc8AW2Sb1FXQnXebqApjbAZOlw5gwAw%3D&reserved=0
Did you also try other datasets or other scenarios? Does that also cause the same error?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fmachinelearning-modelbuilder%2Fissues%2F1259%23issuecomment-785277910&data=04|01||14e38ac309524e515c4e08d8d8f13125|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637497877711077711|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=3GLZxPfh5133jOtoAoQ5mUCYGfgdUh8dQmC2KvbqX4M%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASTD6EHPQG2V7OFQMU4NEI3TAU7XRANCNFSM4X6IR3XA&data=04|01||14e38ac309524e515c4e08d8d8f13125|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637497877711087700|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=JzH5b76Zltpwi8ud1tdDeTlSHaFWrGVDA8zhR4ADu64%3D&reserved=0.

Hi
Ii have tried another set and event another computer and I still get the error.
From: Xiaoyun Zhang<EMAIL_ADDRESS>Sent: Wednesday, February 24, 2021 1:23 PM
To: dotnet/machinelearning-modelbuilder<EMAIL_ADDRESS>Cc: Picaso2<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [dotnet/machinelearning-modelbuilder] Method not found: Error (#1259)
Hi @Picaso2https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPicaso2&data=04|01||14e38ac309524e515c4e08d8d8f13125|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637497877711067713|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=KteDGOdYodbloc8AW2Sb1FXQnXebqApjbAZOlw5gwAw%3D&reserved=0
Did you also try other datasets or other scenarios? Does that also cause the same error?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fmachinelearning-modelbuilder%2Fissues%2F1259%23issuecomment-785277910&data=04|01||14e38ac309524e515c4e08d8d8f13125|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637497877711077711|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=3GLZxPfh5133jOtoAoQ5mUCYGfgdUh8dQmC2KvbqX4M%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASTD6EHPQG2V7OFQMU4NEI3TAU7XRANCNFSM4X6IR3XA&data=04|01||14e38ac309524e515c4e08d8d8f13125|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637497877711087700|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=JzH5b76Zltpwi8ud1tdDeTlSHaFWrGVDA8zhR4ADu64%3D&reserved=0.

Same here. I just selected image classification, select a path with a bunch of photos, and after pressing the "train" button I received this message.

@agausachs @Picaso2
we push a preview release which should fix this bug, can you try it if had any time?
preview release url:
https://aka.ms/mb-preview/atom.xml

With the preview release it's working perfect now (CPU mode, I haven't tested GPU). Thank you!

@agausachs @Picaso2
we push a preview release which should fix this bug, can you try it if had any time? Please be reminded that the preview release also contains some other new features (like re-entrancy) which hasn't been documented. We are also looking forward to the feedback for these new features as well!
preview release url:
https://aka.ms/mb-preview/atom.xml

solve my problem ,Thank you

Fixed in preview


Added support for more than 5 browsers

Hey guys - we use your software pretty extensively and have many browsers installed, but your UI only allows for 5 or 6 browsers before the CSS in the UI clips out. When you have more than that it is annoying to click around!
This should fix that but let me know if you have any questions.

is that fix for https://github.com/aerokube/selenoid-ui/issues/138 ?

Ah yeah this will also fix that exact issue.

Thank you! That's a nice compact fix. Released as 1.6.6


Bookings widget

Implemented widget for bookings.
Updated Readme file.

The using of the already created page doesn't work @realabdullah ? I mean creating the iframe and passing source of getfidia.com/book/${username}/${slug}?

The using of the already created page doesn't work @realabdullah ? I mean creating the iframe and passing source of getfidia.com/book/${username}/${slug}?
didn't really look into it much but i realized we'd be importing a lot of js files if embedding the url directly and also there's just a little change in UI and doing this gives room for a little bit of flexibility

Feel free to merge when you update the success modal @realabdullah


Lots of errors when compiling native("jvm") module, “not meant for this backend” error can disappear

If I compile an empty module with the following module descriptor (modeled after ceylon.ast.redhat):
native ("jvm")
module tmp "1.1.1" {
    shared import ceylon.ast.core "1.1.1";
    shared import com.redhat.ceylon.typechecker "1.1.1";
    import ceylon.interop.java "1.1.1";
}

I get the following errors:

error encountered [cannot find module artifact com.redhat.ceylon.typechecker-1.1.1.js
- dependency tree: tmp/1.1.1 -> com.redhat.ceylon.typechecker/1.1.1] at 4:4-4:55 of module.ceylon
error encountered [Module not meant for this backend: tmp] at 2:7-2:9 of module.ceylon
error encountered [cannot find module artifact ceylon.interop.java-1.1.1.js
- dependency tree: tmp/1.1.1 -> ceylon.interop.java/1.1.1] at 5:4-5:38 of module.ceylon
3 errors.

I think any errors other than the “Module not meant for this backend” shouldn’t be there.
Even worse: If I copy the Continue.ceylon file from ceylon.ast.redhat over:
import ceylon.ast.core {
    Continue
}
import com.redhat.ceylon.compiler.typechecker.tree {
    Tree {
        JContinue=Continue
    }
}

"Converts a RedHat AST [[Continue|JContinue]] to a `ceylon.ast` [[Continue]]."
shared Continue continueToCeylon(JContinue \icontinue) {
    return Continue();
}

"Compiles the given [[code]] for a Continue
 into a [[Continue]] using the Ceylon compiler
 (more specifically, the rule for a `continue`)."
shared Continue? compileContinue(String code) {
    if (is JContinue jDirectiveStatement = createParser(code).directiveStatement()) {
        // continueDirective doesn’t contain the semicolon
        return continueToCeylon(jDirectiveStatement);
    } else {
        return null;
    }
}

I get the following errors:

Error: Errors found. Compilation stopped.
Note: Created module tmp/1.1.1
error encountered [type declaration does not exist: 'JContinue'] at 19:11-19:19 of Continue.ceylon
error encountered [could not determine type of function or value reference: 'continueToCeylon'] at 21:15-21:30 of Continue.ceylon
error encountered [parameter type could not be determined: 'continue' of 'continueToCeylon'] at 21:32-21:50 of Continue.ceylon
error encountered [type declaration does not exist: 'JContinue'] at 11:33-11:41 of Continue.ceylon
error encountered [package not found in imported modules: 'com.redhat.ceylon.compiler.typechecker.tree' (add module import to module descriptor of 'tmp')] at 4:7-4:49 of Continue.ceylon
error encountered [function or value does not exist: 'createParser'] at 19:43-19:54 of Continue.ceylon
warning encountered [declaration does not exist: 'JContinue'] at 10:25-10:42 of Continue.ceylon
ceylon compile-js: 7 errors.

The “Module not meant for this backend” error vanished!

First I think this is actually two issues in one:

any errors other than the “Module not meant for this backend” shouldn’t be there.

missing “Module not meant for this backend” error

Of which I can't reproduce the second one on the command line. I just get the same errors as the first example and no errors at all from Continue.ceylon as it gets ignored because of the faulty module file. So I'm guessing this is a IDE-specific problem, not the JS compiler itself. Could you confirm that @lucaswerkmeister and move the issue there?

I agree, the compiler should just abort immediately once the native annotation is seen.
Perhaps it’s because of the “Compilation stopped” – it aborts before it gets to print the “wrong backend” error?

And I’m on the CLI.

And I’m on the CLI.

In that case I'm unable to reproduce it with the information given above.

I can reproduce it with:
cd /tmp
rm -rf source
mkdir -p source/tmp
cat > source/tmp/module.ceylon << 'EOF'
native ("jvm")
module tmp "1.1.1" {
    shared import ceylon.ast.core "1.1.1";
    shared import com.redhat.ceylon.typechecker "1.1.1";
    import ceylon.interop.java "1.1.1";
}
EOF
echo 'package tmp;' > source/tmp/package.ceylon
ceylon compile-js tmp
cat > source/tmp/Continue.ceylon << 'EOF'
import ceylon.ast.core {
    Continue
}
import com.redhat.ceylon.compiler.typechecker.tree {
    Tree {
        JContinue=Continue
    }
}

"Converts a RedHat AST [[Continue|JContinue]] to a `ceylon.ast` [[Continue]]."
shared Continue continueToCeylon(JContinue \icontinue) {
    return Continue();
}

"Compiles the given [[code]] for a Continue
 into a [[Continue]] using the Ceylon compiler
 (more specifically, the rule for a `continue`)."
shared Continue? compileContinue(String code) {
    if (is JContinue jDirectiveStatement = createParser(code).directiveStatement()) {
        // continueDirective doesn’t contain the semicolon
        return continueToCeylon(jDirectiveStatement);
    } else {
        return null;
    }
}
EOF
ceylon compile-js tmp

That's what I already had, but I can't reproduce it with that. Maybe because I don't have ceylon.ast. Are you able to reproduce it without depending on that?

Oh, yeah, I suppose it depends on that being published. Same behavior without the ceylon.ast.core line though. (I edited the comment above to remove it.)

Is this still happening?

With the above script, I’m still getting three errors from the first compile command (two “cannot find artifact”, one “module not meant for this backend”), and four (plus three warnings) from the second one (including an NPE in GenerateJsVisitor).

Compiling the empty module doesn't output anything, so the module not meant for this backend is still missing, although I'm not sure that should happen; if you're compiling several modules in one go, ignoring the jvm-only modules seems the right thing to do.

Actually there is a bug here: I tried to compile a default module and the native module for JVM, and nothing happens if the non-js module is present; everything is ignored instead of just the non-js module.

if you're compiling several modules in one go, ignoring the jvm-only modules seems the right thing to do

If you're specifically mentioning the module on the command line it should definitely give the error. Only if you do something like ceylon compile-js '*' should JVM modules be ignored, but the ModuleWildcardsHelper already takes care of that for you.

I specifically mentioned the module on the command line and nothing happened. And I do mean nothing, as in the default module (which isn't native) didn't get compiled either

I'm not sure I understand, so you typed something like ceylon compile-js jvmmodule default and it didn't compile the default module?

Right.
It does show warnings though, if there are any in the code, but that's it.

If I try it a default.js file is generated but doesn't run correctly.
And I get an error for the JVM module:
./source/jvmonly/module.ceylon:1: error: module not meant for this backend: jvmonly
"Only the JVM compiler should be allowed to compile this"

(the error should be changed but at least it's there)

The behaviour is exactly the same in the JVM compiler backend btw

Grrr I said "I think this fixes" GitHub, you should be able to tell the difference between that and "THis fixes" ;)

Anyway, take a look @chochos and @lucaswerkmeister to see if this actually fixes it and if not we reopen.

Now ceylon compile-js default x gives me this:
source/x/module.ceylon:1: error: module not meant for this backend: x
native ("jvm")
       ^

Cool! The default module was not compile, though.

Well , like I said, the JVM compiler does the same. It might not be correct, I don't know, but at least both exhibit the same behaviour :)
And fixing that would be another issue IMO

Sure. Closing, then.

:laughing: