To renew a certificate it is necessary to delete it's order file

To renew a certificate we need to run manuale issue <domains> command.
When the certificate is expired the issue command will fail as the link for the challenges are expired.
When a certificate isn't expired will pass and the certificate will be generated with the same expiration date from the previous one.
It is necessary to delete the order file to "renew" the certificate.
For the scenario with an expired certificate we should delete the previous order and start over.
For the scenario of a certificate missing some days to expire(i.e 20 to 10 days) we should act as an expired certificate, for certificates newer than that we should ask the user if he want's to overwrite the order and issue a new order.

The fix here was to check if the order is valid. The problem here is that the new expire date comes with a extra field:
2020-07-18T20:10:20.678626972Z instead of 2020-07-18T20:10:20Z
This is braking the expire verification because I'm formatting the mask as %Y-%m-%dT%H:%M:%SZ.
Still trying to figure our what .678626972 means as %z fails to format the string to date and ValueError is thrown.

It is an inconsistency with the return of dates where it could come as a seconds with a fractional value. I'm not converting this I'll trim the date until I get to the seconds.
I think they are trying to get fixed. See: https://community.letsencrypt.org/t/inconsistent-datetime-format-in-some-responses/61452/3
It looks to be merged here https://github.com/letsencrypt/boulder/pull/3706 but I'm still seen it.

Is there a mess in every part of the computer??

I don't know. I think I got that by accident as this could happen or not.
Funny that on #42 they were experiencing an intermittent issue where some dns challenges were failing on staging but stopped when moved to production. I wonder that was the cause because that is fixed on challenges maybe this is still happening at the order response. Also, why staging behaves different that production?

Back then in API v1 + manuale times everything was so nice.
Could you repeat that?

@szepeviktor, do you mean that the date and time in the v1 was nice with manuale?
The issue is the date that comes from the API V2. I'll start to log order creation and fulfillment dates.
I'm just trying to figure out what I should do here.  The protocol is order based instead of certificate or domain based.
I think they changed to scale from V1 to V2 and some complexity was added, it is necessary to handle thing locally before sending things to them.

do you mean that the date and time in the v1 was nice with manuale?

I man that manuale - to me - was perfect.

I still have this error.

Find a solution for that issue. During the first query I'll have an 404 for the query resource, I'll set the order as expired and authorize will take care of the rest. New order will be created and we can go on.

@piraz Bumped into this right now.
Could you send a commit?


Jupyter-js-widgets resize event

So, the browser does not provide resize events for DOM elements (except for the browser window itself).
Many Jupyter widgets (ipyleaflet, bqplot, and the new matplotlib widget) need to know when their containing element was resized so as to re-layout.

recompute the svg viewbox for bqplot, then relayout the plot area
invalidatesize for leaflet to download the tiles for the right area
recomputing the png for matplotlib with the right size.

In the case of phosphor layouts, which only use absolute sizing and positioning, we do know when a containing element for a widget was resized.
Hence, in both the cases of the legacy notebook and the notebook in Jupyterlab, we know when the width of a widget area changed. (on window.resize in the first case and on resize of the phosphor notebook widget in the second case).
Now in the case of the CSS layouts used in ipywidgets, things get a bit more complicated. Essentially, besides the window resize event, the other thing that can trigger size changes are change in (or of) layout trait attributes of widgets. However, when you have nested Box widgets (which are based on css flexbox), any change of layout in a widget of that hierarchy will bubble up and down into resize events in all of them.
We can only hope that not too many or those Box widgets are nested since any change of layout of any widget will bubble up to the top widget area.
Proposal: I would like the two following approaches to be used:

implement the expensive bubbling of resize events triggered by changes in the layout attributes. The worst case scenario is that everything gets re-laid out at the level of the widget area.
provide addition container widgets that use phosphor layouts.

@sccolbert

This is much easier with the switch to phosphor in #627.

@SylvainCorlay - is this done now?

Yes, it's done now.


Add non-ATTAINS catchments to GetATTAINS, error handling updates

This PR modifies GetATTAINS() to include an option for "filling in" NHD catchments for WQP observations that do not have any ATTAINS assessment unit(s) associated with them. This option required pretty substantial reworking of the function and the structure of what it returns, mostly because it produces a lot of different combinations of arguments (and therefore a lot of if_else'ing was needed). This also required making a new function, fetchNHD(), which downloads the NHD catchment features. Another downstream consequence of adding this filling in option was the need to modify TADA_ViewATTAINS() to handle the new "without_ATTAINS_catchments" features.
I also made some changes to fetchATTAINS() in hopes of speeding up the API pull for grabbing that ATTAINS data. Basically, if there are very few (<100) WQP sites and the bounding box of those sites is massive (about the size of California) -- or the bounding box is a tad smaller (think size of New Hampshire), but far less observation locations (25ish), it is quicker to go site by site, as opposed to doing a single batch pull from the API.
Lastly, I added new language in our geospatial vignette (Module 2) to address the changes to the functions.
Though this does not fully close issue 441 (https://github.com/USEPA/EPATADA/issues/441), it is getting closer. I would still like to come up with a way for pulling in the hexagonal features that are used instead of catchments for large bodies of water (think coastal AUs, the Great Lakes, etc.).
Please also stay tuned for an additional PR incorporating "WaterType" as a returned column to ATTAINS features per the new issue, "Adding assessment unit type to GetATTAINS() features" (#520).
Looking forward to your feedback!
-Katie and the ROSSyndicate team

@kathryn-willi Your updates look great - thank you for all your hard work! I created a new PR which includes all updates from this PR & in addition pulls in upstream changes from develop/handles the merge conflicts. Is there anything else you wanted to add before this is merged in?

@kathryn-willi Your updates look great - thank you for all your hard work! I created a new PR which includes all updates from this PR & in addition pulls in upstream changes from develop/handles the merge conflicts. Is there anything else you wanted to add before this is merged in?

Hi @cristinamullin , if @mhweber is happy with the newest commit I made (being able to pull in NHD flowlines and waterbodies as well as catchments in fetchNHD()) then this should be it for now! I plan to submit a separate PR with some updates that address #520 in the next week or so - should be a tighter, more succinct PR. :)

Hi @cristinamullin , if @mhweber is happy with the newest commit I made (being able to pull in NHD flowlines and waterbodies as well as catchments in fetchNHD()) then this should be it for now! I plan to submit a separate PR with some updates that address #520 in the next week or so - should be a tighter, more succinct PR. :)

@kathryn-willi Yes, looks great!

created a new PR that include these updates & resolves merge conflicts: https://github.com/USEPA/EPATADA/pull/527


Add a proper Table of Content for the syllabus pages

Hi @bebatut
I'm an outreachy Intern, can I be assigned this issue.

Hello. I am Gimbiya, an Outreachy applicant and content writer. Please assign me this task.

Hello I’m dorcas, an outreachy applicant can I be assigned to this task

@bebatut, what should be in the table of content because it's currently empty? could you explain, please?

The table of content should contain the different headers. It should be automatically created

Ok.

@bebatut 👀 May I please be assigned this issue? 🙏

Thanks @bebatut.
I've marked the PR as ready for review.

Fixed with  #682


Add to_ieee754_32 Presto function

Resolves https://github.com/facebookincubator/velox/issues/4425

@aditi-pandit please review the PR when you get time. I have made the adjustment after the file split (refactoring PR).

fuzzer output from local run
I20230418 15:30:42.551452 1518462 ExpressionFuzzer.cpp:974] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230418 15:30:42.551465 1518462 ExpressionFuzzer.cpp:978] to_ieee754_32 6803 100.00% 223252
I20230418 15:30:42.551483 1518462 ExpressionFuzzer.cpp:984] ==============================> Bottom 1 by number of rows processed
I20230418 15:30:42.551497 1518462 ExpressionFuzzer.cpp:986] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230418 15:30:42.551510 1518462 ExpressionFuzzer.cpp:991] to_ieee754_32 6803 100.00% 223252
I20230418 15:30:42.551525 1518462 ExpressionFuzzer.cpp:1004] ==============================> All stats sorted by number of times the function was chosen
I20230418 15:30:42.551538 1518462 ExpressionFuzzer.cpp:1006] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230418 15:30:42.551553 1518462 ExpressionFuzzer.cpp:1010] to_ieee754_32 6803 100.00% 223252

@ashokku2022 Left some comments. On the Presto side, I also see Hex representation.
presto> select to_ieee754_32(10.3);
    _col0
-------------
 41 24 cc cd
(1 row)

@majetideepak that is just for display purposes (the hex conversion, maybe to save space) and I have noticed that too but based on documentation the output should be varbinary and not hex.

@mbasmanova could you please review, thanks!

@mbasmanova could you please review, thanks!

Adding @Yuhta Jimmy also.

@ashokku2022 : Please rebase your code.

@aditi-pandit @Yuhta have rebase and updated the code (just like to_ieee754_64). Please review, thanks!

fuzzer test output:
velox_expression_fuzzer_test  --seed 123456 --duration_sec 60 --logtostderr=1 --minloglevel=0  --only to_ieee754_32  --v=1 2>&1 | tee fuzzertest2.out
I20230504 15:46:39.856527 5610506 ExpressionFuzzer.cpp:1070] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230504 15:46:39.856540 5610506 ExpressionFuzzer.cpp:1074] to_ieee754_32 6547 100.00% 212966
I20230504 15:46:39.856581 5610506 ExpressionFuzzer.cpp:1080] ==============================> Bottom 1 by number of rows processed
I20230504 15:46:39.856596 5610506 ExpressionFuzzer.cpp:1082] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230504 15:46:39.856611 5610506 ExpressionFuzzer.cpp:1087] to_ieee754_32 6547 100.00% 212966
I20230504 15:46:39.856645 5610506 ExpressionFuzzer.cpp:1100] ==============================> All stats sorted by number of times the function was chosen
I20230504 15:46:39.856683 5610506 ExpressionFuzzer.cpp:1102] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20230504 15:46:39.856698 5610506 ExpressionFuzzer.cpp:1106] to_ieee754_32 6547 100.00% 212966

Hi @ashokku2022, @mbasmanova pointed out that the semantics of your to_ieee754_32 and to_ieee754_64 is incorrect, they should return binary form of the data (32 bits and 64 bits) instead of the string binary (32 bytes and 64 bytes).  Can you correct them?

The correct value returns in Presto Java:
presto:di> select to_ieee754_32(real '10.3');
    _col0
-------------
 41 24 cc cd
(1 row)

@ashokku2022 In the initial version you convert the bitset to string and write it to output.  It is the same results as current version.  What Presto Java has is the binary values in the output directly, you just need to use folly::Endian::big(input) and write it to output.  All the unit tests need to fixed though.

@Yuhta Jimmy, thanks for the feedback, highly appreciate it. Let me work on it and update code. Once this to_ieee754_32 PR is done, will open another one to address to_ieee754_64. Thank you!

Hi @ashokku2022, shall we close this since Krishna will add this function in https://github.com/facebookincubator/velox/pull/5336?


Add VCF data donation processing

@madprime couple of copy/paste things + one question; feel free to merge though :)


Suppress command output unless an error occurs or --verbose

Problem
automake always complains about --missing files, which  screws up compilation output buffers
Summary of Changes

Capture command output and suppress unless an error actually occurs (or --verbose)
shellcheck nits (unused variables)

fixes #45

CC @gerickson

closing in favor of #48


some small fixes

fixed crystal armor nbt
removed CARROT (invalid id, the real id is CARROT_ITEM)
added wiki link to CARROT_ITEM

Keep CARROT, items exist with that id. Other than that, it looks good

Keep CARROT, items exist with that id. Other than that, it looks good

okay done


HIVE-28603 Fixing Multiple Flaky tests in module serde which are due to non determinism

What changes were proposed in this pull request?
Sorting the fields in function getDeclaredNonStaticFields() in ObjectInspectorUtils.java class in order to make the function deterministic. The below flaky tests will be fixed by this.
Why are the changes needed?
Multiple flaky tests were detected in serde module while trying to run the tests using the nondex tool. NonDex is a tool for detecting and debugging wrong assumptions on under-determined Java APIs.
Steps to reproduce flakiness using nondex -
mvn install -pl serde -DskipTests

mvn -pl serde test -Dtest=org.apache.hadoop.hive.serde2.objectinspector.TestProtocolBuffersObjectInspectors#testProtocolBuffersObjectInspectors

mvn -pl serde edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=org.apache.hadoop.hive.serde2.objectinspector.TestProtocolBuffersObjectInspectors#testProtocolBuffersObjectInspectors

ERROR logs:
[ERROR] Failures:
[ERROR]   TestProtocolBuffersObjectInspectors.testProtocolBuffersObjectInspectors:71 expected:<test> but was:<[one, two]>

Reason for Failure
The method getDeclaredNonStaticFields(Class<?> c) in class ObjectInspectorUtils.java uses class.getDeclaredFields() method which is nondeterministic as per java docs.
 Field[] f = c.getDeclaredFields();

As per the test cases, it is assumed that the return order of the fields will always be the same, which may not be the case.
All the below test cases are impacted because of the same reason :

org.apache.hadoop.hive.serde2.objectinspector.TestProtocolBuffersObjectInspectors.testProtocolBuffersObjectInspectors
org.apache.hadoop.hive.serde2.objectinspector.TestThriftObjectInspectors.testThriftObjectInspectors
org.apache.hadoop.hive.serde2.objectinspector.TestReflectionObjectInspectors.testReflectionObjectInspectors
org.apache.hadoop.hive.serde2.columnar.TestLazyBinaryColumnarSerDe.testLazyBinaryColumnarSerDeWithEmptyBinary
org.apache.hadoop.hive.serde2.columnar.TestLazyBinaryColumnarSerDe.testSerDeInnerNulls
org.apache.hadoop.hive.serde2.lazybinary.TestLazyBinarySerDe.testLazyBinarySerDe
org.apache.hadoop.hive.serde2.TestStatsSerde.testLazyBinarySerDe
org.apache.hadoop.hive.serde2.lazy.TestLazySimpleSerDe#testSerDeParameters
org.apache.hadoop.hive.serde2.binarysortable.TestBinarySortableSerDe#testBinarySortableSerDe

Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
The changes were tested by running the unit tests locally. The code is already covered in the above test cases and is actually fixing the flaky tests.
Please let me know if you have any questions or would like to discuss this further for any clarificaitions.

LGTM, pending one comment.

@nikunjagarwal321 please retrigger the build, it needs to pass

Thanks @difin !

@nikunjagarwal321 Hi, It appears that this commit does not work with JDK 17 and has resulted in multiple test failures. Could you please check this issue?
You can check out the PR here: https://github.com/apache/hive/pull/5404

@nikunjagarwal321 Hi, It appears that this commit does not work with JDK 17 and has resulted in multiple test failures. Could you please check this issue?
You can check out the PR here: #5404

Hey,
Thanks for bringing this to my attention. From my understanding, the current master branch is still on Java 8, and the changes I made were based on that version. The modifications I implemented focused on resolving flaky tests in the existing main code, and all related unit tests passed successfully at the time.
I see that the transition to Java 17 is a new initiative you're working on. If the previous changes are not fully compatible with Java 17, we may need to explore alternative approaches. I’d be happy to provide more context on my changes or collaborate on finding a resolution.
Let’s continue the discussion in the new PR where the Java 17 upgrade is being worked on, as this change seems primarily related to the version upgrade and keeping all discussions in one place would be helpful.


feat/exclude setting

feat: add smoke test
feat: add test case

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.08%. Comparing base (462bbae) to head (d61597b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   88.10%   83.08%   -5.02%
==========================================
  Files           5        5
  Lines         479      479
  Branches      103      105       +2
==========================================
- Hits          422      398      -24
- Misses         54       78      +24
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


IBlockState parameters: state or block?

In many places, IBlockStates are used in places where Block would have been in the past. I almost want to call parameters of that type block since it makes more sense to me. What do you think?
Additionally, this opens up the question of whether IBlockState should simply be renamed to IBlock, and Block to BlockType, or something? Though maybe that's a bit too early - should wait for what Mojang is going to do to Blocks, at the very least..?

state.
And IBlockState should stay as it is, IMO.

Similar with ItemStack. I think of it as an instance of an item more than a stack which only comes into play for stackable items anyway. I do think of IBlockState as an instance of a block in the world too, when it is passed into methods like this.

Why not unambiguous parameters like itemStack, blockState?

@mezz Because they're long and not really add anything. Ideally a parameter shouldn't be named after the type but its use in the code. And in use, I often think of said parameter as "the 'item' the method is operating on".
It might be confusing because we have the Item class but say we renamed that to ItemType, which makes more sense to me since an instance of Item is not an item instance but describes a type of an item, it would remove this confusion.

From what has been discussed in irc various times, it sounds like are going with state unless there is multiple kinda of states such as more than 1 BlockState or a BlockState and FluidState in the context.

Yes.


add Chinese translation of tutorial01

@colachg Please review.

LGTM

Ok, could you  approved these changes?

LGTM

Ok, could you approved these changes?

Yes, what should I do?  A button to click or anything else?

LGTM

Ok, could you approved these changes?

Yes, what should I do? A button to click or anything else?

https://help.github.com/cn/github/collaborating-with-issues-and-pull-requests/approving-a-pull-request-with-required-reviews

Thanks :heart:


[marvin, VMware] Fix test_06_disk_offering_strictness_false observed on 'main' branch

Description
This PR fixes the test failure observed on main branch for test_06_disk_offering_strictness_false
The main reason for the failure, is that the volume fails to resize on change of service offering reporting that the volume has a parent.
022-02-14 07:22:01,410 ERROR [c.c.h.v.r.VmwareResource] (DirectAgent-80:ctx-df1ac830 <IP_ADDRESS>, job-59/job-60, cmd: ResizeVolumeCommand) (logid:02e59892) Resize of volume in VM [name: i-6-7-VM] is not supported because Disk device [path: i-6-7-VM] has Parents: [6000C296-e4fb-b280-4d56-8e62cda83de9].
2022-02-14 07:22:01,410 ERROR [c.c.h.v.r.VmwareResource] (DirectAgent-80:ctx-df1ac830 <IP_ADDRESS>, job-59/job-60, cmd: ResizeVolumeCommand) (logid:02e59892) Failed to resize volume of VM [name: i-6-7-VM] due to: [Resize of volume in VM [name: i-6-7-VM] is not supported because Disk device [path: i-6-7-VM] has Parents: [6000C296-e4fb-b280-4d56-8e62cda83de9].].
java.lang.Exception: Resize of volume in VM [name: i-6-7-VM] is not supported because Disk device [path: i-6-7-VM] has Parents: [6000C296-e4fb-b280-4d56-8e62cda83de9].
        at com.cloud.hypervisor.vmware.resource.VmwareResource.getDiskAfterResizeDiskValidations(VmwareResource.java:951)
        at com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:878)
        at com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:569)
        at com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

For resizing volumes in VMware it is required that vmware.create.full.clone be true. Hence, the test has been modified to set it to true at the start of the test and reset it back on completion.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2598

@blueorangutan matrix

@blueorangutan test matrix

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-3324)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35504 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3324-kvm-centos7.zip
Smoke tests completed. 88 look OK, 4 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_primary_storage_disabled_host
Error
0.69
test_primary_storage.py

test_01_primary_storage_nfs
Error
0.11
test_primary_storage.py

ContextSuite context=TestStorageTags>:setup
Error
0.18
test_primary_storage.py

test_01_secure_vm_migration
Error
159.95
test_vm_life_cycle.py

test_02_unsecure_vm_migration
Error
270.58
test_vm_life_cycle.py

test_03_secured_to_nonsecured_vm_migration
Error
143.19
test_vm_life_cycle.py

test_08_migrate_vm
Error
43.89
test_vm_life_cycle.py

test_02_list_snapshots_with_removed_data_store
Error
8.62
test_snapshots.py

test_02_list_snapshots_with_removed_data_store
Error
8.62
test_snapshots.py

test_hostha_kvm_host_degraded
Error
701.92
test_hostha_kvm.py

test_hostha_kvm_host_fencing
Error
681.44
test_hostha_kvm.py

Trillian test result (tid-3325)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36377 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3325-vmware-65u2.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_offline_migrate_VM_and_root_volume
Error
91.84
test_vm_life_cycle.py

test_03_live_migrate_VM_with_two_data_disks
Error
65.47
test_vm_life_cycle.py

Thanks @Pearl1594 do you think you can include further fixes for the 2 failing tests on this PR or prefer to create a separate PR?

@blueorangutan package

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2604

@blueorangutan test matrix

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan package

Trillian test result (tid-3331)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34568 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3331-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_disable_oobm_ha_state_ineligible
Error
1512.42
test_hostha_kvm.py

Trillian test result (tid-3332)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46182 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3332-vmware-65u2.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_invalid_upgrade_kubernetes_cluster
Failure
3605.56
test_kubernetes_clusters.py

test_02_upgrade_kubernetes_cluster
Failure
3602.65
test_kubernetes_clusters.py

test_03_deploy_and_scale_kubernetes_cluster
Failure
0.08
test_kubernetes_clusters.py

test_04_autoscale_kubernetes_cluster
Failure
0.06
test_kubernetes_clusters.py

test_05_basic_lifecycle_kubernetes_cluster
Failure
0.05
test_kubernetes_clusters.py

test_06_delete_kubernetes_cluster
Failure
0.05
test_kubernetes_clusters.py

test_07_deploy_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.04
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
52.48
test_kubernetes_clusters.py

@blueorangutan package

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Trillian test result (tid-3330)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56360 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3330-xenserver-71.zip
Smoke tests completed. 89 look OK, 3 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_06_download_detached_volume
Error
491.72
test_volumes.py

ContextSuite context=TestVolumes>:teardown
Error
73.51
test_volumes.py

test_deploy_vm_from_iso
Error
1513.29
test_deploy_vm_iso.py

test_02_upgrade_kubernetes_cluster
Failure
3611.83
test_kubernetes_clusters.py

test_03_deploy_and_scale_kubernetes_cluster
Failure
60.48
test_kubernetes_clusters.py

test_04_autoscale_kubernetes_cluster
Failure
0.07
test_kubernetes_clusters.py

test_05_basic_lifecycle_kubernetes_cluster
Failure
0.05
test_kubernetes_clusters.py

test_06_delete_kubernetes_cluster
Failure
0.05
test_kubernetes_clusters.py

test_07_deploy_kubernetes_ha_cluster
Failure
1.11
test_kubernetes_clusters.py

test_08_upgrade_kubernetes_ha_cluster
Failure
0.10
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.08
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
95.18
test_kubernetes_clusters.py

@blueorangutan test matrix

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-3361)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33701 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3361-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-3362)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35695 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3362-vmware-65u2.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File


PXE: Fix BaseCode::discover optional argument

NOTE: This commit changes the API for BaseCode::discover, but should continue to be source-compatible. Edit: DiscoverInfo will break in cases where the generic can't be inferred, or where it's explicitly declared (eg, DiscoverInfo<[Server; 4]> needs to be changed to DiscoverInfo<4>).
The info parameter in BaseCode::discover is an optional pointer argument (it may be NULL), but is incorrectly specified in the Rust extern definition as Option<*const T>. This type is (at least) one byte larger than a Pointer on all platforms, making it incompatible with the Optional Pointers in EFI. Two possible fixes:

Remove Option wrapper (this is what the PR contains)
Convert to Option<&T> (chose not to use this since converting references requires unsafe)

The DiscoverInfo struct had odd bounds associated with it, and being generic over T: ?Sized doesn't make sense when the server list has to be a fixed size. This could be removed or broken out into a separate commit if needed.
Checklist

[x] Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
[x] Update the changelog (if necessary)

Should I include the #[must_use] attributes that it's complaining about in the lints? I don't think they're appropriate here.

Yes, please add must_use there. The idea is that if you call a function that doesn't do anything except, say, return a bool, then not using the return value is likely a bug.

Lgtm, thanks again for the PR :)


Flashlight does not work with MacForge in Catalina

Beta 7 - Does not load commands via spotlight like expected
Really unclear what the System Info tab is saying. Application blacklist shows mySimbl which makes me wonder whether that load is being blocked. SIP is disabled.

The blacklist is a list of apps that MacForge will not try to load into.
Flashlight loads into the Spotlight application.
It's most likely that Flashlight needs updating for Catalina.

Ah. Any plans to fix that? Any way to transfer this bug over there?
On Sep 5, 2019, at 4:28 PM, Wolfgang Baird<EMAIL_ADDRESS>wrote:

The blacklist is a list of apps that MacForge will not try to load into.
Flashlight loads into the Spotlight application.
It's most likely that Flashlight needs updating for Catalina.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/w0lfschild/MacForge/issues/13?email_source=notifications&email_token=ALRHQ3IXV4A7DHY3CQNNRNTQIFTXTA5CNFSM4IUBETVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AU4WQ#issuecomment-528567898, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALRHQ3JXDGOF7QBBHGMUYOLQIFTXTANCNFSM4IUBETVA.

I will look into this at some point, yes.

Just gonna cross link the same issue from the Flashlight repo. I'm willing to PayPal someone $20 if they can get it running well on Catalina.
https://github.com/w0lfschild/Flashlight/issues/65

U need to grant the program full access, turn off disk check and encryption, then go into recovery, (cmd + r) Select terminal from the drop down menu, type csrutil disable.
At some point you might have to sudo the program in terminal. Apple has been very serious with Catalina and its Security, personally I do not like MacOS Catalina and will be willing to help anyone downgrade as well

https://github.com/w0lfschild/Flashlight/issues/65#issuecomment-569994756


Azure Redis Spec missing aof-backup-enabled from redisConfiguration.

The Azure Redis spec here: https://github.com/Azure/azure-rest-api-specs/blob/23d896b00311e101dbbd6fea04c9ae9f0006be92/specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json#L1823 is missing aof-backup-enabled. You can not enable AOF without it. Its an available option in the ARM Template below:
{
    "$schema": "http://schema.management.azure.com/schemas/2014-04-01-preview/deploymentTemplate.json#",
    "contentVersion": "<IP_ADDRESS>",
    "parameters": {},
    "resources": [
        {
            "name": "cach16",
            "type": "Microsoft.Cache/redis",
            "apiVersion": "2021-06-01",
            "location": "eastus",
            "dependsOn": [],
            "properties": {
                "sku": {
                    "name": "Premium",
                    "family": "P",
                    "capacity": 1
                },
                "redisConfiguration": {
                    "aof-backup-enabled": "true",
                    "aof-storage-connection-string-0": "[concat('DefaultEndpointsProtocol=https;AccountName=sa175538bf;BlobEndpoint=https://sa175538bf.blob.core.windows.net/;AccountKey=', listKeys('/subscriptions/SUBSCRIPTIONID/resourceGroups/resource_group83501aec/providers/Microsoft.Storage/storageAccounts/sa175538bf', '2015-06-15').key1)]",
                    "aof-storage-connection-string-1": "[concat('DefaultEndpointsProtocol=https;AccountName=sa175538bf;BlobEndpoint=https://sa175538bf.blob.core.windows.net/;AccountKey=', listKeys('/subscriptions/SUBSCRIPTIONID/resourceGroups/resource_group83501aec/providers/Microsoft.Storage/storageAccounts/sa175538bf', '2015-06-15').key1)]",
                    "preferred-data-persistence-auth-method": "sas"
                },
                "enableNonSslPort": false,
                "redisVersion": "6"
            },
            "tags": {}
        }
    ]
}

If anyone is in this area, can they also add the missing notify-keyspace-events property?


Toast: Escape toast HTML content that is not wrapped in "-pharos-" tag

User supplied strings can end up being part of a toast messages content. This is a XSS risk.
This change: (check at least one)

[x] Adds a new feature
[ ] Fixes a bug
[ ] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[x] Yes
[ ] No

Is the: (complete all)

[x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[x] Test suite(s) passing?
[x] Code coverage maximal?
[ ] Changeset added?
[ ] Component status page up to date?

What does this change address?
A clear and concise description or a direct link to an issue [e.g. #15]
If adding a feature, a rationale for its addition goes here.
How does this change work?
A clear, detailed description of how this change addresses the issue.
This could be a bullet list if there are several moving parts.
Additional context
Add any other context here.

@daneah I agree that this pattern of using a library to manually sanitize HTML is generally problematic and isn't a pattern we want to adopt. I do however wonder if there is a middle ground here.
To your point about consumers being responsible for escaping content, many modern frontend frameworks (React, Vue) do provide built-in escaping of HTML to prevent XSS out of the box, and don't make it a responsibility of their consumer. Content is made safe by default and something like dangerouslySetInnerHTML is required if you want to pass it in and not have it be escaped. I'm curious if Lit does that as well?
From what I remember from the report which surfaced this, the same content that is causing issues in the Toast is displayed elsewhere on the page via Pharos components without the potential XSS, which makes me think it might. (@michael-iden does that sound right?)
From what I can tell, this instance in the Toast component is the only place in the codebase that the element.innerHTML function is used to set the content directly. Perhaps if we were to refactor it to use the normal output methods of Lit like the other components, we could get Lit's default handling of content, without needing to manually sanitize the output?
I haven't had a chance to look into it to verify my assumptions, but I'm curious if that makes any sense to you and is worth looking into?

@brentswisher good points and yes, I think that would be worth looking into! I am remembering some strife with using slots here, but as usual the details have been lost to the annals of time in my brain 😓

Right now the effort to deal with this pseudo-vulnerability is not really worth it in out opinion. Maybe we can come back to this later. For now I am closing this PR.


Environment Setting and Dependencies

Could anyone share a detailed requirements.txt and the Python version to run the code? Have spent several useless days.

你好，我想请问一下您弄出来了吗，可以分享一下嘛

同问

你好，我想请问一下您弄出来了吗，可以分享一下嘛

同问

I shared it in an new issue.


[pure k8s] Export job config yaml in PAI runtime

Export job config yaml in PAI runtime. Python SDK would use it.

Done with k8s runtime. Closing


Create jasyoung314.md

Thanks for this contribution, @JasYoung314. I had to make one small tweak to the filename in https://github.com/python-namibia/python-namibia.github.io/commit/cf248ae5cef931083b5096339c8fae93aaa6d5ea, but you can now see your entry on https://python-namibia.github.io/.
In related news: Kudos to you and @drvinceknight for delivering a Git and GitHub tutorial! Much appreciated! :bow:


Cannot open or close indexes on HTTPS ES endpoint

Elasticsearch version: 5.6.8
cerebro: 0.7.2
I use IIS on Windows 2012 R2 as a proxy in front of ES to allow only HEAD, POST, and GET verbs to prevent template changes and index deletion. The IIS site for ES is configured with HTTPS, and cerebro can connect to ES after I follow the guide to trust the Root CA certificate in #6 . However, after connected, I cannot open or close indexes. The error message is Operation failed and the following details are in Chrome Dev Tools
body:{,…}
error:
"<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN""http://www.w3.org/TR/html4/strict.dtd">
<TITLE>Length Required</TITLE>
<META HTTP-EQUIV="Content-Type" Content="text/html; charset=us-ascii">

Length Required

HTTP Error 411. The request must be chunked or have a content length.

"
status: 411

cerebro works fine if I connect directly to the ES RESTAPI. Could anyone help me figure out this issue?
Thanks,

@anhlqn Is this still an issue? And does this happens only with close/open indices, and the rest of actions work fine?

@lmenezes Yes, I just checked. GET and PUT work fine (I can toggle allocation and update index templates if I allow PUT in IIS), but POST doesn't work.

@anhlqn and you have the same problem if you try a search request(using POST), through the rest client?

I'm able to search as well as open and close indexes via the rest client interface.


Unittesting a bool operator fails

I detailed the issue I am having here:
http://stackoverflow.com/questions/38330348/continuous-error-21-library-routine-called-out-of-sequence
I have since narrowed it down to a piece of code.  This passes:
	TEST_FIXTURE(DatabaseFixture, TryToCreateATable)
	{
		database db(test);
		CHECK(db.exec("CREATE TABLE test (id INTEGER PRIMARY KEY, value TEXT)"));
	}

But this fails (normally it is REQUIRE CHECK(db) but I removed it to make sure it isn't REQUIRE causing issues).
	TEST_FIXTURE(DatabaseFixture, TryToCreateATable)
	{
		database db(test);
		CHECK(db);
		CHECK(db.exec("CREATE TABLE test (id INTEGER PRIMARY KEY, value TEXT)"));
	}

The db boolean check is
operator bool() const { return connected_; }

If you replace the CHECK(db); line with the following:
if (!db) std::cout << "Not connected! " << db.error() << std::endl;

It passes.  You can see the bool operator is called by placing a cout in there just to acknowledge the call.
While I initially thought it was Sqlite3 related it appears it is the boolean operator causing the issue.

One of the eagle eyed developers on SO points out it is related to https://github.com/unittest-cpp/unittest-cpp/issues/7


[BEAM-7816] [BEAM-7817] Support Avro dates and enums in Schemas

Add support for Avro enums (type=enum) and dates (type=int, logicalType=date) to Schemas. Avro dates become FieldType.DATETIME, and Avro enums become FieldType.STRING.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run JavaPortabilityApi PreCommit

R: @reuvenlax

Friendly reminder about a review request, @reuvenlax.

@RyanSkraba Thanks! time-millis isn't supported because, I didn't find any use-case for it in our codebase (or any other) and was lazy coding it, but it could be built in a separate PR if needed. You are right regarding timestamp-micros, it isn't possible to map it on DATETIME without losing precision, but it should be possible once we change the representation of DATETIME.
@reuvenlax I'm going to continue and merge this PR given that it got a review. Let me know if you have questions or suggestions.


conditional materialized view refresh and create-replace for the view

for issue: #88
hi I've started testing  quary in the production and hitting dependencies errors: If I follow the logic of DROP/CREATE view  I can't do it without CASCADE deleting all dependencies. The same with materialized views.
I suggest that for the view and materialized view there would be no DROP command and then changed creation commands:

view : CREATE OR REPLACE VIEW ...
materialized view: checking if the view exists first and based on that either REFRESH MATERIALIZED VIEW .. or CREATE MATERIALIZED VIEW ... In case of REFRESH there is no issue with dependent views.

thank you

The fundamental problem with this approach is that if you change the model between the runs, the behavior is vastly different from what you would expect, e.g., changing the model as expected.
We do have a system for this, though, which I think we can rely on our "cached views" system. It's mainly defined in this file: https://github.com/quarylabs/quary/blob/main/rust/core/src/automatic_branching.rs.
We currently use it for our development flow; suppose you have models A, B, and C that depend on each other as follows, and you are pushing them to production in a materialized way.
A --> B --> C

It essentially measures the diff between your local setup and what's in production and tries to use as much "production" as possible to rely on materialized models as much as possible. So if your local models change C to C', you can still rely on production A and B because those are identical.
At its core, it's a "diffing system" that I think we can use here as well, to both speed up builds by

running refresh if the model is materialized but the definition is the same
skipping create/replace steps for views that are identical.

I hope some of the above makes sense.
As we were discussing,

Ben, thank you, yes it makes total sense.

https://github.com/quarylabs/quary/pull/141 The beginning!


sqlBatch multiple keys

Please add support pass multiple keys to sqlBatch.
Example:
const MatchRound = new GraphQLObjectType({
	description: 'A match round type',
	name: 'MatchRound',
	sqlTable: 'match_rounds',
	uniqueKey: ['match_id', 'id'],
	fields: () => ({
		id: { type: new GraphQLNonNull(GraphQLID) },
		events: {
			type: new GraphQLNonNull(new GraphQLList(new GraphQLNonNull(MatchRoundEvent))),
			// sqlJoin: (matchRoundsTable, matchRoundEventsTable) => `
			// 	${matchRoundEventsTable}.match_id = ${matchRoundsTable}.match_id AND
			// 	${matchRoundEventsTable}.round_id = ${matchRoundsTable}.id
			// `

			sqlBatch: {
				thisKey: ['match_id', 'round_id'],
				parentKey: ['match_id', 'id']
			}
		}
	})
})

This would be difficult. Batches work by using a WHERE IN clause to match on the value of the "parentKey" .
WHERE "comments"."post_id" IN (2,8,11,12)

I don't see a straightforward way to ask for a list of pairs of values. Any ideas?

I know something like this is possible in Postgres:
select * from comments where (comments.post_id, id) in ((2, 18), (3, 132)

But I to my knowledge most SQL databases don't support this.


Use isEnabledAndContentLengthBigEnough as the statistical condition of isAcceptEncodingAllowed

Commit Message: Use isEnabledAndContentLengthBigEnough as the statistical condition of isAcceptEncodingAllowed
Additional Description: isEnabledAndContentLengthBigEnough is a special condition for judging whether no_accept_header_ should be statistic, so it is directly passed in isAcceptEncodingAllowed as a parameter to prevent misunderstandings like #14115
Risk Level: Low
Testing: Add unit test to verify when compression is disabled, or content-length less then minimum length, no_accept_header_ shouldn't be statistic.
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @rojkov

Forgot to mention... Please don't do git rebase and force push next time. This way it's easier to see what's changed since the previous review.

Forgot to mention... Please don't do git rebase and force push next time. This way it's easier to see what's changed since the previous review.

Hi @rojkov
Sorry for I notice this after to force push again...
I have try to move isEnabledAndContentLengthBigEnough as a parameter for isAcceptEncodingAllowed, it will increase the consumption of one function stack compared with the original solution in these case, but it will make the logic of the code expression clearer. Do you think this is acceptable?

Hi @rojkov, I agree with you here maybe will lost some readability, and I have try to add some comments to highlight it. I think that explains the problem to some extent.
Besides, I have update code for all comments, could you help me review again? Thanks!

/assign-from @envoyproxy/senior-maintainers
for a second pass.

Hi @mattklein123 . Could you help me review this PR when you are free? So thanks!


Follow/unfollow feature and private timelines

We have added follow/unfollow-feature. This means that when signed in, a user can follow other users/authors and then these users' cheeps show up on the signed in users private timeline. However other users private timeline will only show their own cheeps.

Delightful. There may be use for a bit of refactoring


Configure GitHub workflows for the repo

This PR adds three workflows:

build
publish image
publish release image
Build workflow is running on every PR and push.
It runs linter, builds code, and runs unit tests.
Publish image workflow is running on every merge to master.
It builds image and push it with three tags: latest, master,
sha-<commit_sha>

Publish release image workflow is running on every tag push.
It builds image and push it with version tag, e.g. 0.1.1

I checked these workflows with my repo fork.
I think we need to explicitly enable GitHub actions for the repo to trigger validation from this PR.
@adrianchiris  @moshe010 Do you have required permissions to enable GitHub actions for this repo?

@ykulazhenkov i think GA is enabled for this project. for security reasons changes to workflows will not be applied from PRs IMO

I pushed code to internal branch in the repo. This PR is replaced by
https://github.com/k8snetworkplumbingwg/accelerated-bridge-cni/pull/27
I will address comments in it.


TypeError: Cannot read property 'codeGen' of undefined

Ionic version:  (check one with "x")
[ ] 1.x
[x ] 2.x
[ ] 3.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

Expected behavior:

The project builds succesfully
Steps to reproduce:

Related code:
By debugging it would seem that the problem is that
var compiler_cli_1 = require("@angular/compiler-cli"); no longer has a __NGTOOLS_PRIVATE_API_2
Other information:

[18:53:05]  ionic-app-scripts 1.3.5
[18:53:05]  build prod started ...
[18:53:05]  clean started ...
[18:53:05]  clean finished in 1 ms
[18:53:05]  copy started ...
[18:53:05]  ngc started ...
[18:53:06]  ionic-app-script task: "build"
[18:53:06]  TypeError: Cannot read property 'codeGen' of undefined
TypeError: Cannot read property 'codeGen' of undefined
    at Object.doCodegen (/Users/abrahampolishchuk/github/flock/flock-app-client/node_modules/@ionic/app-scripts/dist/aot/codegen.js:6:50)
    at /Users/abrahampolishchuk/github/flock/flock-app-client/node_modules/@ionic/app-scripts/dist/aot/aot-compiler.js:42:30```

**Ionic info:** (run `ionic info` from a terminal/cmd prompt and paste output below):

Cordova CLI: 6.5.0
Ionic Framework Version: 2.0.0
Ionic CLI Version: 2.2.2
Ionic App Lib Version: 2.2.1
Ionic App Scripts Version: 1.3.5
ios-deploy version: 1.9.1
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v6.10.2
Xcode version: Xcode 8.3.1 Build version 8E1000a

Looks like a dupe of app-scripts #918 to me.

Hello all! I am going to close this issue as a duplicate of https://github.com/driftyco/ionic-app-scripts/issues/918


Update index.js

I tested it on my local machine. Now the environment map is downloaded correctly

Thanks!


Q: What is status of ROCm on RX 5700/XT?

Hello!
What is the status of ROCm on the new RX 5700 & RX 5700XT video cards?
Thanks!
And thanks for making ROCm!

To save me time digging through the internal repos to try to find the PCI IDs, do you have the device ID for either of those cards? I can't find them on pci.ids, but I would assume that we'd have some support for them.

Hi Kent, I don't have the IDs. All I have is pci.ids also. It' OK, we will learn more when the cards hit the shelves.

would be nice to know what expected version ROCM 2.7? ROCM 3.x?

No support yet?

Sorry, I should've updated this previously. We have full compute support for Navi10 (Radeo 5700 and 5700XT). We don't have display capabilities yet (2.7 or 2.8) due to some issues with the display code, so we had to disable display to allow the GPU to work at all with our stack. We are aiming to get full display support for Navi10 to go with the already-present full compute capabilities in the 2.9 release.

Hi Kent, thanks for the update.
Just to verify my understanding: an RX 5700/XT will run compute jobs under ROCm but cannot yet produce video output; thus I could use 5700/XT in a headless compute machine or install a different card alongside a 5700/XT if video out is required.
Is this correct?

I should clarify that the support is in the kernel for RX5700/XT. I don't know what the status is on the runtime and OCL, but I was speaking specifically from the kernel/firmware perspective, I should have said that first. Sorry for any confusion that I may have caused.

OK, that's cool. Thanks for the details, Kent. Are the ROCm devs aiming for RX5800/RX5800 launch day support, by any chance? I know that for compute the 5700 would be OK, but really at this point a VII or Vega 64 make more sense. I'm guessing "big Navi" will be more powerful for FP32 at least.

I don't have any specifics unfortunately. Plus, they likely wouldn't want to give out firm deadlines in case things slip, or if we push the date up and release things earlier. We've always got to consider the amount of work that it takes to get the basic (amdgpu) support in the kernel, then the compute kernel (amdkfd) support, and ironing out those bugs as the runtime is brought up, then finally getting to performance testing instead of just basic functionality, which always makes it tougher than giving basic Display or kernel functionality, which tends to come along pretty early on.
I'd love to give you an answer, but all I can say is to watch the "Supported Hardware" listing in the ROCm documentation. Anything outside of that list is considered to be unsupported. But bear in mind that some things might just not be confirmed. The kernel will have support for new chips pretty quickly, since that gets brought in by the amdgpu and amdkfd components. The thunk (ROCT)  is usually pretty quick to follow along there (and is usually pretty stable unless some new hardware features need to be considered), and the SMI is just a layer to interface with the sysfs files, so that's under kernel support. But once you get beyond that, you're looking at the runtime, which is where support for the hardware gets dicier. So even if something isn't in the "Supported Hardware" list, it may have some limited functionality. And since it's all open-sourced, we always invite help from the ROCm community to help to bring these ASICs along.

Are there any further update on supporing navi cards? I'm really looking foward to run some computation on my RX 5700~

I understand that over the past year there has been some fuss about Navi10 support in ROCm. While we can see that it is not yet officially supported, is there an estimate? I purchased this card a month ago with the intention on working on ML projects, as well as gaming, but I (wrongly) assumed that almost a year after the launch of RX 5700/XT the support would already be there. However, if support is expected in the coming ~2 months, then I would keep this card. If you could also let us know that support won't be here for a year or so (or never?!?), then I would return it to get a more suitable alternative (e.g. Radeon VII).
So, is there any chance you'll let us know about your plans regarding RX 5700 XT and ROCm? Is anybody working on it? Is the architecture inherently unsuitable for deep learning?

@soutzis I recommend you acquiring a Radeon VII or even better which is the Radeon Instinct MI100 (gfx908) ...
There's no telling when AMD's ML libraries or their HCC compiler will support GFX10/RDNA's instruction encoding. A lot of AMD's ML libraries use hand optimized assembly that's only compatible with GFX8/GFX9 GPUs ...

@Degerz Thanks. I will give the GFX10 1-2 more months, otherwise I will have to go back to NVidia. The black screen driver issues haven't helped me love this card much so far.

@soutzis I don't think waiting will be necessary ...
AMD doesn't plan on adding GFX10 support for their HCC compiler until maybe after 2022 ? That's assuming that AMD's strategy will change and they go back to reconverging and maintaining a single unified family of architectures again ...
I imagine that their next generation CDNA 2 GPU will be based on gfx910. The safest bet IMO so far is the MI100 in which you can expect 5 years of quality support from AMD with the entire software stack but the next best thing is a Radeon VII if you're looking for the best possible support out of a regular consumer GPU ...

@Degerz I see. Thanks for your insight.
Hopefully, I hope that in time everything will go well for AMD, so they can hire more people to work on software.

@soutzis TBH, AMD's software support for more HW is contingent on their strategy rather than the size of their software team ...
AMD could drop supporting GFX9 GPUs altogether tomorrow and start redeveloping their entire software stack based around GFX10 GPUs with lower performance than they had originally envisioned ...
Or they could maintain and release new products based on the GFX9 architecture so that they can avoid rewriting huge parts of their software stack and they can optimize their HW design for even better performance on compute applications compared to GFX10 based HW. I can see why AMD would vastly prefer this path even though the community here wouldn't like it. I do wish that if AMD were committing to this route that they would at least release some cheap compute accelerator SKUs under $1000 so that there could still be a widespread option to do work or develop on their platform ...
If the worst comes to pass then the community could just add HCC compiler support for GFX10 GPUs and start porting AMD's ML libraries if they want to get either Tensorflow or PyTorch up and running since all of this is open source ...


fix(grafana): fix grafana dashboard export error

What's changed and what's your intention?
Fix bug that one cannot automatically  export grafana dashboard, and fold all panels for observation.
Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)
Bug bash, close https://github.com/singularity-data/risingwave/issues/2461

When exporting dashboard, we can disable Default of datasource name, which allows one to export the JSON file directly.


Add worker vCPU info to fsadmin report capacity command

provide more information about worker state

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.10 please


[jansson] Update to 2.13.1

Describe the pull request

What does your PR fix? Update jansson package to 2.13.1
https://github.com/akheron/jansson/releases/tag/v2.13.1

Hi @Jimmy-Hu
Thanks for this PR.
Could you please resolve the conflicts and also address the review suggestions?

Hi @Jimmy-Hu
Thanks for this PR.
Could you please resolve the conflicts and also address the review suggestions?

@NancyLi1013 Thank you for your reply. Let me check and update that.

LGTM now. Thanks for your efforts.


Migrate to api.postcode.eu

Hey 👋
I noticed api.postcode.nl has changed to api.postcode.eu.
Their site https://developer.postcode.eu/ doesn't really seem to provide any information about the switch, what's changed, or about deprecation of api.posstcode.nl. But I still wanted to get this issue on the radar.
It seems like they support more countries now. So I can imagine that this switch isn't as simple as flipping the URL.
Are there any plans to update this gem?

I have some additional info about the migration to api.postcode.eu (in dutch)

Pas hiervoor API aanroepen als volgt aan:
api.postcode.nl/rest/addresses/2012es/30
api.postcode.nl/rest/addresses/postcode/2012es/30

worden:
api.postcode.eu/nl/v1/addresses/postcode/2012es/30

api.postcode.nl/rest/postcode-ranges/postcode/2012es
wordt:
api.postcode.eu/nl/v1/postcode-ranges/postcode/2012es

Verdere aanpassingen in je implementatie zijn niet nodig! Je kunt voortaan gewoon gebruik blijven maken van het nieuwe domein.

I haven't looked into the gem code yet, but it seems a simple change in the API paths should suffice.
If I submit this patch, will it be accepted? And will a new version be published?
Or am I going to need to fork / monkey-patch / roll my own?


if you put ShadingSphere in Chinese folder，SQLCasesLoader and SQLCasesLoader can not load File

Bug Report
https://github.com/apache/incubator-shardingsphere/blob/master/sharding-sql-test/src/main/java/org/apache/shardingsphere/test/sql/loader/SQLCasesLoader.java
https://github.com/apache/incubator-shardingsphere/blob/master/shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/SQLParserTestCasesRegistry.java
Example  code：
File[] files = new File(url.getPath())
if url has Chinese garbled code ，the files is not exist。

On Windows ?

@kimmking  No ，on mac  os .  I think this path , use utf-8 decode will better..

Can you submit a pr to fix it.

ok,I will fix it .

use utf-8 decode will better..

How about if default character is not uft-8?

@terrymanu  ues  toURI() and  then  URI.getPath()  What do you think?

You should modify it and then try it in your case.


Need a CODEOWNERs file in this repo

Need a CODEOWNERS file in this repo. Will work with the SSWG to make that happen.

@parispittman there's a CONTRIBUTORS.txt file. Is there much difference between this and the CODEOWNERS file?

@cmcgee1024 CODEOWNERS is used by GitHub to automatically assign reviewers on new PRs


[Tutorial/Basic] 06 flatlist section

Change ScrollView to FlatList

FlatList will be better if you treat multiple components are repeated.


why Different network connection closed

hi muaz-khan
I have problems
peer to peer
same network Work all normal
but Different network Could not work connection closed (RTCMultiConnection.connection.onPeerStateChanged failed)
why? STUN / TURN server Configuration error? Or what problem？
(work on UDP)
@muaz-khan

If you use Chrome, did you check chrome://webrtc-logs/ ?

I'm also facing same issues got any solution.

@aliahmadpasha please check this: https://github.com/muaz-khan/RTCMultiConnection/issues/710
Now RTCMultiConnection doesn't includes any default TURN-server. So you need to download codes, and modify/default/declare connection.iceServers array to use your own TURN-servers.

@aliahmadpasha please check this: #710
Now RTCMultiConnection doesn't includes any default TURN-server. So you need to download codes, and modify/default/declare connection.iceServers array to use your own TURN-servers.

can you give me any demo example for this & want to install this on linux server ?


Add MongoDB database agent

Description: Created an agent designed to interact with and query a MongoDB database using PyMongo. The agent is very similar to SQL Database. Currently, it only supports one database per instance MongoDatabase class using URI, and the database name must be appended to the end of the URI.
See docs/docs/integrations/toolkits/mongo_database.ipynb for an example of usage.
Note: To run PyMongo queries, it checks the input string using regex that it follows the db.collection.find ... format and runs it using eval(), which is bad practice and may be dangerous (if anyone finds a better solution, feel free change that). Additionally, the tests pass locally due to having MongoDB installed since the tests use the tmp/mongodb-27017.sock Unix socket, but do not pass Github Actions test workflows for the same reason, and since we weren't sure whether it would be good practice to edit the workflow and haven't figured out a good way to mock PyMongo's MongoClient/Database that isn't unnecessarily complex or makes the unit tests superficial, we left it as is.
Issue: Closes Connection with mongo db #3399
Dependencies: pymongo (dependency already existed, but changed from optional to not)

@eyurtsev Hi, could you please take a look at our PR? Ty!!

Thank you sooooooo much!!! @hwchase17


Syncbot: zendesk error needs context

When syncbot runs into a closed Zendesk ticket, the current error message is"
(cc @sqweelygig) The following message could not be delivered to Zendesk. Please try again in a few minutes. Message preview:
"Good Morning Nimish, The last I see on this ticket is us recommending that raspb ..."
Error: Zendesk returned error: (422) RecordInvalid
It would be more helpful for the message to let the agent know the ticket is likely closed, and their options are to re-open the ticket if it's not yet solved, or create a new ticket.
Example:
https://app.frontapp.com/open/cnv_4l6s95

Created https://github.com/resin-io/resin-integrations/issues/12


Add Nashorn support for script mediator

Related issue: https://github.com/wso2/product-ei/issues/850

Fixed in https://github.com/wso2/devstudio-tooling-esb/pull/217


Add Breadcrumb Component

I would like to work on this component please assign it to me.

@PiperGuy  Sure! Just go through the Contribution guidelines in CONTRIBUTING.md
Keep me updated with your progress.
Also star the repository if you like it! Thank you 😄


Cannot Toggle scratchpads due to errors

Hi, I've been trying to use this for my setup but it keeps giving out the following error
ERROR:scratch:client_info of  must be a dict: None
scratchpads::run_toggle(('term',)) failed:

Traceback (most recent call last):
  File "/home/red/.local/pipx/venvs/pyprland/lib/python3.11/site-packages/pyprland/plugins/scratchpads.py", line 124, in updateClientInfo
    assert isinstance(client_info, dict)
AssertionError

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/red/.local/pipx/venvs/pyprland/lib/python3.11/site-packages/pyprland/command.py", line 75, in _callHandler
    await getattr(plugin, full_name)(*params)
  File "/home/red/.local/pipx/venvs/pyprland/lib/python3.11/site-packages/pyprland/plugins/scratchpads.py", line 275, in run_toggle
    await self.run_show(uid)
  File "/home/red/.local/pipx/venvs/pyprland/lib/python3.11/site-packages/pyprland/plugins/scratchpads.py", line 385, in run_show
    await self.updateScratchInfo(item)
  File "/home/red/.local/pipx/venvs/pyprland/lib/python3.11/site-packages/pyprland/plugins/scratchpads.py", line 317, in updateScratchInfo
    await scratch.updateClientInfo()
  File "/home/red/.local/pipx/venvs/pyprland/lib/python3.11/site-packages/pyprland/plugins/scratchpads.py", line 129, in updateClientInfo
    raise AssertionError(e) from e
AssertionError

Steps to recreate this
pypr
pypr toggle term
Gives out this exception
Is it due to python version ? If so what version should I set it up using, thank you!

Hi! I don't think it's Python related.
Which pyprland version are you using ?

In every case, you may want to download & install https://github.com/hyprland-community/pyprland/tree/onlylazy to see if this problem still happens. I plan to merge this branch into the main one.

First of all thank you so much for the reply
And second, I'd like to apologize but... How would I go about installing this? I tried pyprland from paru and pipx and it worked flawlessly, But as this is a different branch it only contains python files
Please let me know at your convenience

No worries.
I don't know pipx but it looks like you can use this syntax:
pipx install https://github.com/hyprland-community/pyprland@onlylazy

Thank you very much !
For anyone else wondering I used
pipx install git+https://github.com/hyprland-community/pyprland.git@onlylazy

To install it

Thank you very much !

So just to be 100% clear: using this version solved your issue ? :)
If you confirm, I'll make it the official branch, it works well for me for a couple of days.

Thank you very much !

So just to be 100% clear: using this version solved your issue ? :)
If you confirm, I'll make it the official branch, it works well for me for a couple of days.

Yes, functions perfectly !


Path finding for JIT compiling CUDA launch sites

NOTE: Do not merge or review this with view to merge, it's exploratory.
As per the title, this somewhat scrappy patch is path finding for what it takes to JIT compile the launch sites for the CUDA target. The basic idea is to ctypes bind to the CUDA kernel launch function, close over a kernel pointer and then generate a JIT call that splats the arguments from a CPU dispatcher matching the launch site into the void** that a CUDA kernel expects. There's some additional complexity involved in that NumPy arrays need round tripping to the device if they are present, @overloads calling objectmode handle this but it would also be possible to just JIT a similar call to the CUDA library function to copy the memory etc.
Current things that work:

Standard kernel launches (not cooperative launch) going via CPU JIT code.
Automatic to/from device handling of NumPy arrays (see caveat below about tuples).
Most of the unit tests!

Current issues:

36 of the unittests are skipped due to problems (see 256ac65). Of those which are more serious failures, there seems to be three or four common themes in the failing tests so it's probably not that many individual problems.
CUDA's device array needs to be its own type, but it's a bit too close to types.Array in some cases which prevents specialisation. e.g. if you compile a function with a NumPy array first it won't recompile when a CUDADeviceArray type is presented.
CUDA's device array boxing is too raw, the MemoryPointer needs more consideration, at present it's just using an int as the address and MemoryPointer is hacked to cope with this. I've also some unspecified concerns about references and lifetimes of these managed pointers in relation to this, it just seems likely an area that could present issues.
Record arrays are entirely broken as they are ignored by the current patch (cause of some of the unittest skips).
Cooperative launches are still going via the ctypes path.
Exception handling is still done via ctypes, does not propagate through the JIT launch.
Passing tuples containing np.ndarray as kernel args is not handled, the tuple needs duplicating at runtime with a switch out for a device array and back (cause of some of the unittest skips). It's doable but prohibitively complicated for this pathfinding.
"extensions" arg to the kernel does not work. This should probably be handled via the type system as it looks like it's just a workaround for externally defined types.

Current issues that could be problems in the future:

Closing over the kernel function pointer will silently break on disk caching (addresses baked in).
There's something going on with types of arrays that ends up with them often being "A" order which is a less specific than the CPU dispatcher default/preference. I think this is all fixable (see outcomes), but it might alter the way users code is typed.

Outcomes:

This patch proves that JIT kernel launch is possible. On a NOP 4 arg kernel launch is about 1.75x faster.
I'm now pretty convinced that this refactor cannot be completed without also changing the way kernel launches are structured. It seems like the kernel is compiled and specialised on arguments too early in the launch sequence, which means a CPU JIT launcher can struggle to match the args at the call site for the kernel. This comes from the kernel essentially being compiled with a signature which then blocks further compilation and permits various degrees of casting to the arguments, this is mostly fine, but there's cases where it is not. For example, if a kernel ends up compiled with "A" ordered arrays but the CPU JIT code decides they are "C" ordered, it breaks. Similarly if a kernel has a signature specified saying it e.g. takes a float32, but then the user executes it with a python float, the CPU JIT function will type that as float64 and then the kernel packed args will be of the wrong types which ends up with incorrect results/segfaults. I'm of the view that the kernel, launch config and CUDA dispatcher all need to be type specialising dispatchers in their own right such that types and signatures correctly propagate through a call graph like cuda dispatcher - > launch config -> kernel. This also has the secondary effect of making is reasonably likley that launching CUDA kernels from CPU jitted functions would "just work" or at least work with a minor amount of effort.

Closing as path finding work is complete.


Variable-sized brackets and bold text break character alignment in Firefox

Shared Program: https://code.world/#PL1P3DfDlbKvMjslV59Pugg
Description
Consider lines 10 and 11 of the above program:
change(w, KeyRelease("Left")) = w { leftReleases = leftReleases(w) + 1 }
change(w, _)                  = w

In Chrome, they look fine:

But in Firefox, the alignment is wrong:

Note the = w on line 11 is too far to the left. The same number of characters are there when you count, and it copies and pastes right, so it's just a display bug.

Yes, this isn't surprising.  It's an artifact of the way brace highlighting is done.  Outer braces are rendered larger with a letter-spacing CSS property to try to compensate, but the exact right value for letter-spacing was chosen empirically.  See https://github.com/google/codeworld/blob/master/web/css/codeworld-cm.css#L38
This is going to be tough to fix, I'm afraid.  If we're lucky, maybe there's a better CSS unit that behaves consistently, but perhaps there's a way to do it by measuring the right letter-spacing value at runtime and modifying the CSS rules at runtime based on that measurement.

I investigated this some more. It turns out that the font-size and letter-spacing have a little bit to do with it, but they're not responsible for most of it. (#820 fixes this bit, though.) The major culprit is that in Firefox, the Source Code Pro font takes up more horizontal space per character when it's bold. This doesn't happen with the standard "monospace" font, and it doesn't happen at all in Chrome. I'm not sure what's causing this, or what the best way to fix it is. I'll keep looking though.

Okay, I see what's going on. The problem is that we're not loading the bold version of Source Code Pro, so the browsers are making one up themselves, and they're each doing it differently. Another PR coming up.

Result of both changes in Chrome:

And in Firefox:


rework highlights

Added GitSignsInline and GitSignsLnInline to be used with word diff

GitSigns*LnInline is used for word diff with config.word_diff
GitSigns*Inline is used for word diff in hunk previews

Added GitSignsVirtLn and GitSignsVirtLnInline to be used with
config.show_deleted.

Define GitSigns highlights conditionally as opposed to only defining
them if certain features are enabled.

I'm struggling to figure out how to configure the highlight groups for word_diff after this change. Before the change it looked perfectly fine, but after the change it's unusable. Now that it's no longer hard coded, how can we configure the highlight groups properly for word_diff to get previous behaviour?


Deep linking

Allow deep linking from markdown to other documents, images, etc within an image.

Added in 0.23


Add query proxy methods

The Model object should proxy following methods directly to the instance of QueryBuilder:

where()
custom scopes
insert()
update()
find() and findOrFail()

Fixed in b3be456feddff8970f79be930a14114d4f8f1c38


Update Route meta type to a user-extensible empty interfaces

What problem does this feature solve?
Currently a route's meta field is listed as "any". This makes it impossible for users to define the structure of their own metadata. As an example, I wish to use the "meta" property for middleware. I've created a Middleware type and would like an interface like the following:
declare module "vue-router" {
    interface Route {
        meta: {
            middleware?: Middleware[]
        }
    }
}

If I try to define it this way, I get an error saying that all declarations of "meta" must have identical modifiers, and that "meta" was already defined in router.d.ts... However if I DON'T define it this way then I lose the ability to statically type check this property and catch developers who accidentally pass an incorrect type (e.g. passing a string containing the middleware's name, instead of the middleware object itself)
Now there's admittedly a limitation of this. Currently, it's possible to pass a non-object for the meta of a route. If you want to stick just a number or a string in there, it's completely valid. Making this a user-extensible interface would eliminate that use case (and therefore be a breaking API change) -- but I find it highly suspect that anyone is using the meta field in that way in a production app of any meaningful size. Without key-value pairs, storing only a single string into the "meta" field doesn't feel very useful.
What does the proposed API look like?
export interface Route {
  path: string
  name?: string | null
  hash: string
  query: Dictionary<string | (string | null)[]>
  params: Dictionary<string>
  fullPath: string
  matched: RouteRecord[]
  redirectedFrom?: string
  meta?: {} // <-- replaced "any" with "{}"
}

Currently, it's possible to pass a non-object for the meta of a route. If you want to stick just a number or a string in there

It is possible but not supported, only object literals are really supported inside meta. In vue-router-next, its type is Record<string | number, any>, to allow putting anything in there, requiring the user to cast things later on.
I'm open to proposals that are able to keep it the way it is for people not willing to type their meta properties and also to allow different types of meta (should be doable with union types.
You can try out implementing a proposal at https://github.com/vuejs/vue-router-next/blob/master/test-dts/createRouter.test-d.ts. You need to first build the lib with yarn build && yarn build:dts and then run yarn tsd to run the type test

BTW I tried using meta?: {} and it won't work. One possible solution is exporting an interface that can be extended:
// in vue-router
export interface RouteMeta
  extends Record<string | number | symbol, any> {}

// in your app
declare module 'vue-router' {
  interface RouteMeta {
    foo?: number
  }
}

BTW I tried using meta?: {} and it won't work. One possible solution is exporting an interface that can be extended:
// in vue-router
export interface RouteMeta
  extends Record<string | number | symbol, any> {}

// in your app
declare module 'vue-router' {
  interface RouteMeta {
    foo?: number
  }
}

@posva Tested w/<EMAIL_ADDRESS>and this works. Would be great if we could have this in the current vue-router but I guess this would break users who are not using key-value pairs for it.

For future finders of this issue, to enhance (not override) vue router’s existing type definitions as shown in https://github.com/vuejs/vue-router/issues/3183#issuecomment-621676818, you also have to import vue router in the shims file:
import 'vue-router'

declare module 'vue-router' {
  interface RouteMeta {
    title?: string
  }
}

Otherwise, declaring the module vue-router will override all types that are provided by the original vue-router module.


$ invalid character

Information

Apktool Version: 2.3.3
Operating System: Mac
APK From? Other

I write here but I don't know if it's a problem with apktool.
I am decompiling an apk and in the resources there are the following files:
.//res/drawable-v21/$avd_show_password__2.xml
.//res/drawable-v21/$avd_show_password__1.xml
.//res/drawable-v21/$avd_show_password__0.xml
.//res/drawable-v21/$avd_hide_password__2.xml
.//res/drawable-v21/$avd_hide_password__0.xml

The problem is that I then use the decompiled resources in another project but this character is invalid '$' and block project's mergeDebugResources (i use this tool: https://forum.xda-developers.com/android/software/tool-dexpatcher-modify-android-dex-apk-t3060854/page22)
Is it normal for apktool to generate these resources?
thanks!
attached you find the source file
Amazfit 2.4.0.DEV.apk.zip

Is it normal for apktool to generate these resources?

Apktool is only generating what is in the application. If a resource name has a $, apktool will decode it as such.

@iBotPeaches thanks for reply!
do you have any idea how it is possible that they have inserted a resource with such a name?

I see this is similar like #1776, I know 1776 issue mention it's sing aapt2 but I am seeing similar issue with aapt as well.
[WIP] With the tool (DexPatcher) which was mentioned by @edotassi, I was not yet able to run gradle with aapt2. I have latest apktool.jar with fix/workaround put by @iBotPeaches in this commit https://github.com/iBotPeaches/platform_frameworks_base/commit/ad643be8174e740124b4bc59e4cc1e70541f6a4e. I will update if I make progress with dexpatcher + aapt2

@vkadam read this: https://forum.xda-developers.com/showpost.php?p=76529130&postcount=221

@iBotPeaches I have used apktool with --use-aapt it raised as what issuer said. on v2.3.4.

please see here: https://github.com/DexPatcher/dexpatcher-gradle/issues/22


[Feature Request] slf4j静态封装

Checklist

[X] I searched exising issues and no one else requests similar feature.
[X] I think that 25%+ users are positive towards this feature.

Describe the feature
todo
Additional context
No response

Hello @unknowIfGuestInDream. This issue is marked as deprecated and closed.


authentication URL no longer working (Jan 2021)

authentication URL no longer working
Tesla has switched to using a separate SSO service (auth.tesla.com) for their app and website. This replaces the previous password grant that was directly on the Owner API. They have also added MFA support with TOTP authenticators.

Is someone working on this or not ?

I have switched over to https://github.com/teslajs, but to be honest, it is only working inconsistently (10%) of the time.
Feel free to see my code and perhaps point out issues?!
https://github.com/wga22/nodejs/blob/master/tesla/teslaFramework.js

TeslaJS is working reliably for me and many other users. And the Tesla Control  app is also working reliably as well.
The main issues with reliability seem to have to do with the Tesla WAF blocking cloud providers and users that send too many requests. Since login should be rare this is not a problem for most users.

I am not consistently connecting as well.  Thank you for all the hard work that went into this!!


Error in S3 compute_checksum()

There is an issue with the way CRC32 and CRC32C checksums are computed in compute_checksum(). They are treated as the same, which is incorrect. See this line. Consequently, the tests for compute_checksum() are incorrect, see
https://github.com/getmoto/moto/blob/6b2ee153e61def632808015d35ea3e32ac585483/tests/test_s3/test_s3_utils.py#L139C1-L144
The correct value of CRC32 for somedata is Uwy90A==
The correct value of CRC3C for somedata is dB9qBQ==
CRC32C computation is best handled with crc32c.

Hi @badmetacoder, welcome to Moto! That is indeed not implemented yet, for a few reasons:

I wanted to avoid introducing a new dependency for functionality that will be unnoticed/unused for 99% for users
Libraries that compute crc32c are either a license-mess, and/or do not support ARM architectures

Do you have a specific test case were you need Moto to support the CRC32C checksum?

Hi @badmetacoder, welcome to Moto! That is indeed not implemented yet, for a few reasons:

I wanted to avoid introducing a new dependency for functionality that will be unnoticed/unused for 99% for users
Libraries that compute crc32c are either a license-mess, and/or do not support ARM architectures

Do you have a specific test case were you need Moto to support the CRC32C checksum?

I am guessing this could be an [optional] install for those who need it. My use cases are

clients uploading data via pre-signed URLs and wanting to ensure data integrity (large files containing important data);
processes generating reports and uploading them to S3 and then allowing external parties to download and verify integrity of downloaded data.

I have tests for these cases and right now can only verify that I am setting the Checksum algorithm to a specific type. It's something, but not ideal and doesn't test for checksum validation failures.

This is now part of moto[s3crc32c] >= 4.1.14.dev8. Alternatively you can just install crc32c manually and Moto will use that module to compute the checksum.
Docs here: http://docs.getmoto.org/en/latest/docs/services/s3.html
Just let us know if you run into any other issues @badmetacoder


[Feature]: How to Implement FFmpeg with React Native Video?

Description
I’m working on a React Native app that uses the react-native-video library for video playback. I would like to implement FFmpeg to manipulate video streams (e.g., transcoding, trimming, etc.) within the app. Is there a recommended approach to integrate FFmpeg functionality alongside react-native-video?
Why it is needed ?
I need FFmpeg functionality in my React Native app to manipulate video streams directly within the app.
Possible implementation
No response
Code sample
No response

duplicate of https://github.com/TheWidlarzGroup/react-native-video/issues/3106


Sebastian wesolowski/issue11

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


OpenSSH8.4p1 and OpenSSL1.1.1h not working on Linux 2.6.33.x device

Hello,
I cross compiled openssl 1.1.1h for a PowerPC processor (e500v2) and when I tested it in the host it works fine.
However, when I cross compiled openssh8.4p1 with openssl1.1.1 any openssh binary(ssh, sshd, sshkeygen..) I try to run hangs in command prompt.
When I cross compile openssh8.4p1 with openssl1.1.0l it works fine.
I would like to use the most recently version of openssl1.1.1, how can I debug this to know what is happening ??
I found a similar problem in this issue #10181 but without a solution.
Can you help me to solve this issue ??
Architecture: PowerPC e500v2
System/OS: Linux kernel <IP_ADDRESS>-rt1
configure and compile commands for openssl1.1.1h:
./Configure linux-ppc enable-zlib shared threads --with-zlib-include=/home/serza/eNodeB/OPENSSL_1.1.1/powerpc/zlib-1.2.11/usr/include --with-zlib-lib=/home/serza/eNodeB/OPENSSL_1.1.1/powerpc/zlib-1.2.11/usr/lib

make CC=/opt/freescale/usr/local/gcc-4.5.55-eglibc-2.11.55/powerpc-linux-gnu/bin/powerpc-linux-gnu-gcc

configure and compile commands for openssh8.4p1:
`./configure --host=powerpc-linux-gnu --prefix=/usr CC=/opt/freescale/usr/local/gcc-4.5.55-eglibc-2.11.55/powerpc-linux-gnu/bin/powerpc-linux-gnu-gcc CXX=/opt/freescale/usr/local/gcc-4.5.55-eglibc-2.11.55/powerpc-linux-gnu/bin/powerpc-linux-gnu-g++ LDFLAGS="-L/tmp/build_enb_distro/rootfs/usr/lib -L/home/serza/eNodeB/OPENSSL_1.1.1/powerpc/openssl-1.1.1h/lib" CFLAGS="-O1 -te500v2 -Wl,-rpath=/opt/freescale/usr/local/gcc-4.5.55-eglibc-2.11.55/powerpc-linux-gnu/powerpc-linux-gnu/libc/te500v2/lib:/opt/freescale/usr/local/gcc-4.5.55-eglibc-2.11.55/powerpc-linux-gnu/powerpc-linux-gnu/libc/te500v2/usr/lib -Wl,--dynamic-linker=/opt/freescale/usr/local/gcc-4.5.55-eglibc-2.11.55/powerpc-linux-gnu/powerpc-linux-gnu/libc/te500v2/lib/ld.so.1 -I/tmp/build_enb_distro/rootfs/usr/include" CPPFLAGS="-O1 -te500v2 -Wl,-rpath=/opt/freescale/usr/local/gcc-4.5.55-eglibc-2.11.55/powerpc-linux-gnu/powerpc-linux-gnu/libc/te500v2/lib:/opt/freescale/usr/local/gcc-4.5.55-eglibc-2.11.55/powerpc-linux-gnu/powerpc-linux-gnu/libc/te500v2/usr/lib -Wl,--dynamic-linker=/opt/freescale/usr/local/gcc-4.5.55-eglibc-2.11.55/powerpc-linux-gnu/powerpc-linux-gnu/libc/te500v2/lib/ld.so.1 -I/tmp/build_enb_distro/rootfs/usr/include" -with-ssl-dir=/home/serza/eNodeB/OPENSSL_1.1.1/powerpc/openssl-1.1.1h/usr --with-zlib=/home/serza/eNodeB/OPENSSL_1.1.1/powerpc/zlib-1.2.11/usr --with-pam --with-cflags --with-cppflags  --with-ldflags --disable-strip`

make

Thanks in advance,
Sergio.

Most probably it is waiting on /dev/random read. You can try to find out with strace command.

If it is the case you can try to supply more entropy with rngd.

Hi Tomás
Thank you for the quick answer.
I am a little bit lay at openssl, so some terms I wil need a more detailed explanation.
Can you explain how to use strace command and what do you mean on supply more entropy with rngd ??? what is rngd ??
Thank you and sorry for so many questions.

I am afraid I'll have to point you at Google for details but:
https://en.wikipedia.org/wiki/Strace
https://github.com/nhorman/rng-tools

There are also other alternative entropy supplying daemons - haveged for example.
http://www.issihosts.com/haveged/

Don't worry about that. It helped to give me a direction.
I will research more about this and try some ways.
I will return as soon as I have more information
Thanks

I used strace to run ssh and apparently it stucks at that point after oppening /dev/random and select:
[...]
open("/dev/null", O_RDWR|O_LARGEFILE)   = 3
close(3)                                = 0
brk(0)                                  = 0x2024d000
brk(0x2026e000)                         = 0x2026e000
futex(0x2012dc5c, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
futex(0x2012dc60, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
futex(0x2012dc64, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
futex(0x2012dd0c, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
futex(0x2012dc6c, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
futex(0x2012dc70, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
futex(0x2012e020, FUTEX_WAKE_PRIVATE,<PHONE_NUMBER>) = 0
SYS_359(0x2024fea8, 0x20, 0, 0x7fffffff, 0) = -1 ENOSYS (Function not implemented)
shmget(0x72, 1, 0)                      = -1 ENOENT (No such file or directory)
uname({sys="Linux", node="bsc913x", ...}) = 0
open("/dev/random", O_RDONLY)           = 3
select(4, [3], NULL, NULL, NULL

Then what I wrote above about supplying entropy applies.

Hi Tomás,
Thank you so much for your help. You were right.
I activeted rngd in Linux and Openssh8.4p1 + Openssl1.1.1h worked as expected.
I tried havaged daemon and cross-compiled it for PowerPC, he also did the job to supply more entropy.
Regards.

I cannot recommend havaged, it's entropy expansion process lies about how much entropy it really has.  By a factor of about 30.
I do recommend cpujitter which is using the same basic concept but doesn't lie and makes more effort to output "good" randomness.

Hi Pauli,
Thanks for the suggestion.
I cross compiled cpujitter, it was a little bit more painful than haveged to build, but it also did the job of supply entropy.


Spotted responsive bug in scholarship page

Description
The footer is overlaping in the scholarship page when viewed in responsive page.
Steps to Reproduce
I will refactor the code, make clean UI for scholarship page, improve the responsive styling.
Expected Behavior
The footer page should not overlap the card in the scholarship page rather it should be visible at the end of the page.
Actual Behavior
The footer is overlapping the cards in the scholarship page making it bad UI experience for the users viewing in the different platform like mobile phones.
Screenshots

Additional Information
No response
What browser are you seeing the problem on?

[ ] Firefox
[x] Chrome
[ ] Safari
[X] Microsoft Edge

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

assign it under gssoc

this issue has been solved, so we are closing this issue.


[Chore] Bump app versions to 0.4.0

What happened 👀
Bump app versions to 0.4.0.

Codecov Report

Merging #64 (8113e0f) into feature/16-home-surveys-integrate (e2fe196) will not change coverage.
The diff coverage is n/a.

@@                        Coverage Diff                         @@
##           feature/16-home-surveys-integrate      #64   +/-   ##
==================================================================
  Coverage                              68.20%   68.20%
==================================================================
  Files                                     51       51
  Lines                                    821      821
  Branches                                 131      131
==================================================================
  Hits                                     560      560
  Misses                                   202      202
  Partials                                  59       59

Flag
Coverage Δ

unittests
68.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


CLI doesnt update packages.php

Pagekit: 1.0.15
using the command line (or marketplace):
./pagekit install package packagename
fails to update packages/packages.php therefore, removing packages when a ./pagekit update packages is executed.
adding your packages to /packages/packages.php solves this issue. For example, the following packages.php will keep the specified packages from being removed on update.

<?php return array(
	'pagekit/blog'      => '*',
	'pagekit/theme-one' => '*',
	'mhdev/calendar'    => '*',
	'abeautifulsite/simpleimage' => '*',
	'bixie/formmaker' => '*',
	'bixie/pk-framework' => '*',
	'lusitanian/oauth' => '*',
	'shw/gallery' => '*'

);

Problem:
Composer->install has four parameters, but we pass only three.
https://github.com/pagekit/pagekit/blob/develop/app/installer/src/Helper/Composer.php#L63
https://github.com/pagekit/pagekit/blob/develop/app/installer/src/Package/PackageManager.php#L49
So, we use prefer sources as write config and use the default for prefer source.
For the console update command the update is even suppressed. I did not check for deletion. So, as far as I see it here, this whole feature needs to be checked and reworked.


Make plugin work with modern Gradle dependencies declarations

The current version of the plugin (1.7.3) does not work correctly when your project declares dependencies in modern Gradle style, such as implementation, testImplementation, testRuntimeOnly etc.
You get classpath errors when Gauge runs, unless you use compile, testCompile etc.

Works with gauge-gradle-plugin version 1.7.3


doc url fixed for containerd

@dawlysd : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@dawlysd : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The following users don't have valid GitHub IDs, or are not collaborators on this repo: microsoftdocs/public-repo-pr-review-team

This change has been applied in the live article. I'll close this PR now. Thanks.


Support HTTPS with external SSL handoff

Love the project - it's really improved the productivity in our team!
However, a few weeks ago before HTTPS support was added to the project I forked the library to support our use case which is to use HTTPS, but have the SSL handoff done externally (HAProxy in our case).
We have a few microservices running in our development environment under the same domain so it simplifies things that the SSL handoff is centralised.  We also use a real certificate rather than a self-signed one.
For the app we are using with elm-watch we have a backend server (running on port 4000) that serves the HTML pages and then elm-watch backend running on port 4001.  HAProxy routes https://my-domain/*:443 to port 4000, and wss://my-domain/elm-watch:443to 4001.
My fork is hardcoded and hacky (https://github.com/lydell/elm-watch/compare/main...chazsconi:elm-watch:wss) but works.  However, I would like to do this properly and create a PR for a setup like this with some extra optional configuration parameters for elm-watch.json but would like some feedback first:
My idea is to have these extra parameters:

A ssl_handoff field which defaults to true, but I would set to false. This would cause elm-watch to run the backend with ws (not wss) on the port specified by port regardless of if the browser is using wss or not.
A frontend_port field which would default to the port field, but I would set to 443 in my case.
A path field for the websocket that overrides the default /.  I would set this to /elm-watch. This would allow HAProxy (or similar) to route the traffic to elm-watch backend without having to use a different port on the frontend.  (I already tried without this and having HAProxy to rewrite /elm-watch to / but it seemed to confuse the browser.)

elm-watch (the beta version, currently) serves both HTTP and HTTPS (so, both ws and wss) on the same port. (Yes, that’s possible!)
If you have a proxy in front, can you direct it to HTTP/ws of elm-watch? Then there shouldn’t be any SSL problems, or am I missing something?

I'm now trying the latest beta and have made some progress....
So now the backend serves both HTTP and HTTPS that avoids the need to disable SSL handoff.
However, the path is still an issue:
I only have access to port 443 on the front-end (in fact the setup is quite complex and a remote development environment running under Kubernetes).  I can set the port in elm-watch.json to 443 which will cause the frontend URL for the websocket to be wss://my-domain:443/ and although the backend will also be running on 443 it will be accessed with HTTP (not HTTPS).
However to route the elm-watch traffic to port 443 on the backend and not 4000 (for all other traffic) all I have to differentiate is the query parameters in the websocket URL e.g. elmWatchVersion.  Unfortunately I can only match on paths and not on query parameters in the Kubernetes Ingress (which in fact is using NGINX not HAProxy as I wrongly stated before).
However I don't think that the websocket path needs to be configurable - if it was hardcoded on /elm_watch rather than / then that would be fine as it's easy to match on, and can't imagine if this would have a negative impact on any other users.  In fact I've tried changing the code of the beta and it all works fine with this change.  Happy to create a PR with just this change if you think this is acceptable?

That sounds like a very good solution! I would like the path to be /elm-watch with a dash and no trailing slash.
Some tips if you make a PR:

Run the tests without changes first. Some will probably fail, because I have a problem with flakiness (#3). So don’t spend time on tests failing that seem completely unrelated to what you were changing.
Temporarily add .only to the tests you are working on and only run that file, for example npx jest tests/Hot.test.ts.
Run Jest with the -u flag to update snapshots, but beware of “wrong” changes being brought in in flaky tests. Sometimes easier with find-and-replace for changes that affect many snapshots.

OK - thanks for the tips!  Will work on the PR.