The saved reference frames are not the original frames

** The generated video's reference frames are not the same to the original one's.
As I noticed, the original reference frames have, in my case, size 1280, 720. The saved reference frames are first resized to 1280,704,  and than later resize back to 1280, 720. This makes the saved reference frames not identical to the original frames anymore.
And this will have artifacts on the interpolated frames.
The easiest solution, I considered, is to first patch the video width and height to some multiple of 32, to avoid the resize, and cut the patch after interpolation.
** The reverse normalization does not give the same result.
Another issue is that, the reverse normalization TP, do not give the same image.

Thanks for pointing this out. I will add the padding logic shortly.

Thanks for pointing this out. I will add the padding logic shortly.

The reverse normalization does not give the same result.

Can you elaborate more on this issue? And also specify your setup.

So, if you remove the resize and pre-process the frames to proper size no matter you crop them or pad them, the normalization and reverse normalization will leave some artifacts on the reference frames. I suggest that when it is the reference frame you just “copy“ them into the temp output folder with the same size as interpolated frames

I don't understand why the normalization would cause artifacts. In the implementation, it's just subtraction and addition of a constant from the image. Well anyway I can change the implementation to  copy the original image, but if you have artifacts on the interpolated frame due to normalization then it would still be very noticeable.

I don't understand why the normalization would cause artifacts. In the implementation, it's just subtraction and addition of a constant from the image. Well anyway I can change the implementation to copy the original image, but if you have artifacts on the interpolated frame due to normalization then it would still be very noticeable.

you know the color is stored as 0-255 integers, and when you do normalization and reverse, it may cause some small difference. Maybe you can test more about this.

you know the color is stored as 0-255 integers, and when you do normalization and reverse, it may cause some small difference. Maybe you can test more about this.

The dataloader in this code stores pixel intensities as float in range 0-1. I'll try to make some modifications. Personally, I have not seen any artifacts on my system (CPU and GPU).

I'm not entirely sure if it's the case in this given situation, but i've had some experience with ffmpeg, when i extract frames to png for example, they also have some other metadata which sets something gamma i think, which changes the look of the image. PIL however doesn't care and while it loads that metadata, it doesn't resave it. Which causes those images opened and resaved to be slightly different due to lack of gamma, despite the RGB values being the exact same for each image. I initially noticed this myself making something similar as superslomo, where instead of loading reference images, i just copied them to the output folder with the correct name/index. Opening  the images in a image viewer and stepping through the folder the change between interpolated images and original ones really shows.
I do however note, ffmpeg doesn't care about it when creating an output video, so no flickering happens, it either keep or just strips the gamme values from the images, so it's not a big deal in practice, assuming it's the same bug.
I also think padding images is smarter than croppping, and can be done with PIL quite easily, and added to the Transforms for normalization.


fix(strong name): perform actual signing of the assembly

What does it do exactly?

What does it do exactly?

It switches us away from PublicSign which only uses the public key side of it, to doing it "properly". The downside of that is, that it requires the private key to be available during build time - but for us, this isn't an actual problem. As previously stated, Strong Names aren't security, they're used for identity and our private key resides in the repo.
The problem with PublicSign itself is that it doesn't actually sign the assembly, which means that in some cases, the verification will fail (these cases are pointed out in the .NET Core repo), like a partially trusted AppDomain.
TL;DR: I'm proposing we do full signing. I'm keeping this PR as draft because I'm still researching if there is a downside I'm forgetting/not seeing.

Yes, this PR is the best way forward. Since you have the private key and public key pair (596 bytes, while only public key is 160 bytes), you can fully sign and disable PublicSign. This will be the best.
It's good to fully sign whenever possible, and in your case you're lucky since the private key is already in the repo (this is the recommended approach). When you fully sign, no need to either PublicSign or DelaySign.
One should never DelaySign. If you don't have the private key, prefer PublicSign since that works in most scenarios (except 1) GAC 2) partial trust and 3) appdomains).
It's important to have a strong name because it's viral and if someone is not strong named, they cause a lot of pain for all consumers. To use IVT the consumers have to be strong named (so you can specify the public key of the consumers that you want to expose your internal APIs to). Since Roslyn is strong named and relies on IVT heavily, it kind of "poisons" the entire ecosystem into strong naming.
To verify whether an assembly is fully signed, public signed or delay signed, you can use https://github.com/KirillOsenkov/CodeCleanupTools#lbi-listbinaryinfo
To convert an assembly from delay-signed to public-signed, you can use the FakeSign utility (the difference is a single bit, FakeSign.exe just flips the bit). Here's FakeSign: https://www.nuget.org/packages/fakesign


[freeimage] Enable version information in FreeImage.dll

Describe the pull request

What does your PR fix?
Fixes #19605

Add FreeImage.rc to build FreeImage  to enable the version information showed in Freeimage.dll.
Note: No feature needs to test.

Depends on https://github.com/microsoft/vcpkg/pull/19633.

/azp run

Depends on https://github.com/microsoft/vcpkg/pull/19628.

/azp run

Thanks for the bugfix!


Non nullable list input is not validated

Describe the bug
Non nullable list input is not validated but described as non nullable in graphql schema
To Reproduce
Use this class as mutation input
    public class ItemInput
    {
        public List<string> Ids { get; set; }
    }

In graphql schema this type generated as:
input ItemInput {
  ids: [String!]!
}

Send this request
{
  "operationName": "SaveItem",
  "variables": {
    "item": {}
  },
  "query": "mutation SaveItem($item: ItemInput!) {\n  saveItem(item: $item)\n}\n"
}

Then in mutation method I receive item.Ids as null
Expected behavior
Validation error is expected :)
Variable 'item' got an invalid value.
If you declare ids field as null validation works fine.
{
  "operationName": "SaveItem",
  "variables": {
    "item": { "ids": null }
  },
  "query": "mutation SaveItem($item: ItemInput!) {\n  saveItem(item: $item)\n}\n"
}

Desktop (please complete the following information):

OS: Win 10
Version: HotChocolate 11.0.0-rc2
C# nullables enabled

As I see validation is skipped for any required field despite of it's type if you declare this field as undefined in gql request.


Logging v2 - rke logs not seen in Elasticsearch after upgrading to latest 3.9.x RC

What kind of request is this:
bug
Steps to reproduce:

Install Rancher version v2.5-head
Install the logging v2 (chart 3.8.201)

Use a clusteroutput and clusterflow pointing to an Elasticsearch instance.

Validate the RKE logs are flowing
Upgrade the chart to 3.9.002-rc01 from Dashboard.

Result:

After upgrade the logs are not seen in the Elasticsearch output
No errors in the rke-aggregator pods

Other details that may be helpful:
Elasticsearch version: elasticsearch:7.8.0
Environment information

Rancher version: v2.5-head (03/16/2021) 868c715
Installation option: HA

https://github.com/rancher/rancher/issues/31309

Using a different output (the example logging app) this works as expected.

I am able to get rke logs on 3.9.400-rc02 on es 6 and 7.
The es clusters were installed on the same downstream kubernetes cluster as logging.
GET /all-logs/_search?pretty&q=stderr
returns
{
        "_index" : "all-logs",
        "_type" : "_doc",
        "_id" : "AASSqXgBQJqxLMczhkOr",
        "_score" : 0.46689463,
        "_source" : {
          "filename" : "/var/lib/rancher/rke/log/kube-controller-manager_10a0caf893f464940f06a6c330ea7950d26a8dc408c53e663ade371b9774ca19.log",
          "log" : "I0406 23:42:14.980525       1 event.go:291] \"Event occurred\" object=\"es7/elasticsearch-master-elasticsearch-master-0\" kind=\"PersistentVolumeClaim\" apiVersion=\"v1\" type=\"Normal\" reason=\"FailedBinding\" message=\"no persistent volumes available for this claim and no storage class is set\"\n",
          "stream" : "stderr",
          "time" : "2021-04-06T23:42:14.980689962Z"
        }
      }

flowsandoutputs.zip

Confirmed this is working now with chart version 3.9.400.rc02


Document post-mortems

There's a google drive for these.

Can we close this now that we have https://github.com/pulibrary/pul-it-handbook/blob/main/norms/incident_response.md?


Feature example gotests

This PR provides end2end test sh files to go_tests for rules/examples so that it can be executed from any OS platform by running go test -v ./...

These changes merged into develop branch. Hence closing the PR.


Change LUT word length

We can continue to discuss the right thing to do here, but here's the PR to switch to storing 1 byte per entry when bits allocated is 8, if we decide to use it. I vote for merging this

I tend argue that we should only do this if we can set VR to "OB". Otherwise, receiving applications will likely decode the data incorrectly.
However, that would require chancing the dictionary of pydicom and since that is auto-generated from the table in the standard, it would require a change in the standard.
I would leave it as is until we have further clarity. It's currently definitely not wrong. The VR is OW and the data is 16-bit.

We have decided to disallow 8bit LUTs entirely for the time being. See #177. Closing this.


Disable Bracket Pair Colorization by default

This PR fixes #148977

Cancelling It because of comments.

why?


[FEATURE] Change 'inactive' to 'job queued' or similar when jobs are stalled in jobs panel list

'inactive' confuses users

done in #558


Unable to use in iOS App Extension due to sharedApplication

What steps will reproduce the problem?

1. Create an iOS app and app extension using Xcode
2. Follow instructions to use Endpoints in iOS client:
https://cloud.google.com/appengine/docs/python/endpoints/consume_ios
3. Include Google API Obj-C Client in app extension

What is the expected output? What do you see instead?

To be able to use the client / endpoints API inside an App Extension

Instead, I get the following error when trying to build:

GTMHTTPFetcher.m: 'sharedApplication' is unavailable: not available on iOS (App
Extension) - Use view controller based solutions where appropriate instead.

What version of the product are you using? On what operating system?

Xcode: 6.1.1
iOS: 8
Mac: 10.10.1

Please provide any additional information below.

It works properly in the main app, just not in an app extensions

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 15 Jan 2015 at 11:43

Having the same issue here. Any idea on how to fix that?

How to write an articlePick something current?Use two independent sources?Read your sources before writing the story in your own words?. Do choose a unique title? before you start.Follow Wikinews' structure? for articles, answering as many of who what when where why and how? as you can; summarised in a short, two- or three-sentence opening paragraph. Once complete, your article must be three or more paragraphs.If you need help, you can add {{helpme}} to your talkpage, along with a question, or alternatively, just ask?Use this tab to enter your title and get a basic article template.[RECOMMENDED. Starts your article through the semi-automated {{develop}}—>{{review}}—>{{publish}} collaboration process.]
Welcome! Thank you for joining Wikinews; we'd love for you to stick around and get more involved. To help you get started we have an essay that will guide you through the process of writing your first full article. There are many other things you can do on the project, but its lifeblood is new, current, stories written neutrally.As you get more involved, you will need to look into key project policies and other discussions you can participate in; so, keep this message on this page and refer to the other links in it when you want to learn more, or have any problems.


Remove catkin_virtualenv from .rosinstall (after it's synced)

We're waiting on the next sync of Melodic to have the 0.6.1 version of catkin_virtualenv available via apt.
After this, the catkin_virtualenv entry should be removed from mros1_reasoner.rosinstall
Keep a look at https://discourse.ros.org/tag/release to see when that's happening

This can already be solved as V  0.6.1 version of catkin_virtualenv is now available via apt


WinSCP: Update ProjectSourceUrl

Description
The ProjectUrl was referring to SourceForge, but the page no longer exists. The source code is now on GitHub.
Motivation and Context
WinSCP 5.17.1 is held in moderation because the ProjectUrl is invalid. This change should resolve that issue.
How Has this Been Tested?
The URL is valid and is the location of WinSCP source.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[x] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the chocolatey test environment.
[x] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review


Dhi13mancpp

Improved code in a lot of files; made generalized; more readable; added comments.

@Dhi13man Have you tried running all of them before making PR???

@Dhi13man Have you tried running all of them before making PR???

Yes I have tested out my modifications. They are working as intended.

@Dhi13man The main issue in the repo is the programs inside the Cpp Programs folder are not all grouped. Can you group them inside folders.

@Dhi13man The main issue in the repo is the programs inside the Cpp Programs folder are not all grouped. Can you group them inside folders.

Okay I will do that.

@iampavangandhi do check out my latest commits. I have added my own contributions and arranged the programs into relevant folders as best as I can.

@Dhi13man Merged :+1:


Type Image leads to memory error

Hi there
I have a column of SQL Server which is of type image. SQL Server reports MaxLength =<PHONE_NUMBER>. This results in the following error in arrow-odbc-py:
memory allocation of<PHONE_NUMBER>50000 bytes failed
Somehow I cannot even catch this error. I guess you are using kind of a buffer that grows too much with such a high max length. I propose to impose a max length and throw an error that is recoverable - or really fix it by not using a fixed-sized buffer

Given  #11 I think it would be best to allow the user to define an upper limit of bytes per column. If the ODBC Field Length is not meaningful (<=0) or greater then the max length specified, try using the given limit and if it exceeds the limit, throw. This way I could set 32K as an Upper Limit of a Column if I know that this should be enough. If I increase this size and want so same me some RAM I could just decrease the Batch Size

Hello @aersamkull ,
thanks for opening the issue. In short specifying an upper limit can make sense. I wonder if I could better understand and reproduce the error first.

I have a column of SQL Server which is of type image

Two questions here:

Do you mean Microsoft SQL Server? Or another kind of server
Since IMAGE is not a standard SQL type. What is the exact declaration of the column.

I am asking about the type, since part of me is afraid that arrow-odbc might try to fetch the image as an UTF-8 string, since this is the catch all for all unknown types. So I would like to reproduce that first.

memory allocation of<PHONE_NUMBER>50000 bytes failed
Somehow I cannot even catch this error.  I guess you are using kind of a buffer that grows too much with such a high max length.

Your guess is on the spot. The buffer does not grow though. It is preallocated in one go. Giving a recoverable error feels to, me like a seperate issue in its own right. Users might specify an upper bound which is still to high. The reason you can not catch anything is that it is very likely that the underlying native Rust code in this scenario just aborts execution. We'll have to use a failable allocation than creating the buffer and forward the error. Then this should be recoverable.

- or really fix it by not using a fixed-sized buffer

I think that might be much harder to do then one might guess 😅 . Maybe even impossible. ODBC demands preallocated buffers, which are able to hold an entire batch. I can not grow them mid query. That being said, there are streaming interfaces for large individual values. However large indivual values are not the primary scope of this library, but bulk fetching lots of rows into columnar storage. The interface for streams would also be very different. A lot of the fancier ODBC features are also a bit of hit and miss in terms of support with different drivers. Microsoft SQL seems to work great though.
Sugested workaround:
One of the things you might try, to get done what you need to get done until this is fixed:
Since buffer_size = max_field_size * batch_size. Setting the batch_size to one might help avoiding the allocation error in the meantime.
Cheers, Markus

Yes I mean MS SQL Server. image is an old deprecated type, see MSFT Docu. It's basically a varbinary(MAX) type from the last century
For me a user-defined max-size would be good enough. I've seen guys using a SQL Column to store a Json with a Base64 Encoded PDF in it but that's not me or my company ;) My use case is user-entered HTML or something the like which won't grow over 32K Characters or so

Hello @aersamkull ,
version 0.1.19 of arrow-odbc has been released. It will raise a recoverable error instead of arborting program execution in case of an allocation error for a binary or varchar column.
This of course only concludes the "bug" part of your experience. Question is: "Is your usecase enabled, too?".
I was happy to see in the tests that an Image column is reported to be a LONG_VARBINARY within the ODBC type system. For me a query like SELECT CAST(my_image as VARBINARY(2048)) FROM MyTable worked fine.
Does this work for you? How do you feel about that?
Cheers, Markus

Hi Markus
Thanks for this very fast release! It makes my life easier as I can now skip the error parts with image/nvarchar(MAX)/varbinary(MAX). However the acutual use case is not covered yet.
MS SQL Server has only support for in-row for up to 8000 bytes. If you need more, you have to use the MAX types. Such types exist in other RDBMS, too; the just have different names. MySql for example has a number of BLOB types which don't delivery a meaningful length, too (it's a very large number in their INFORMATION_SCHEMA.COLUMNS). For these types a configurable Max Size is needed, so that I can tell arrow-odbc-py that my fields all have at most N bytes, no matter what ODBC says. This would enable a number of use cases. Meaning ODBC would probably return 0 or something very large for the field size but you truncate it to the given number of bytes (or throw, doesn't matter). Often we use this type of fields for JSON or long User-written texts in any language and don't need more then 100K Bytes per field. If I have a decent server with 200GB RAM I can load a lot of these.
Regards,
Adrian

Hello Adrian,

Thanks for this very fast release! It makes my life easier as I can now skip the error parts with image/nvarchar(MAX)/varbinary(MAX). However the acutual use case is not covered yet.

Thank you for the feedback, this took me the better part of a Saturday, so it is nice to know you appreciate it.
Also thanks for elaborating on your usecase. Especially the hint with the rough size of 100kb has been helpful. Otherwise I might have suggested that it is out of scope, since large pictures probably shouldn't be fetched in bulk, but streamed individually.
I think specifying a maximum binary size of an element in a buffer, might be the way to go (as you suggested). However I need to see how I can check for truncation in a perfromant way. If I just forward the argument the truncation done by ODBC will be VERY silent. I would like for the default behaviour to emit an exception, but maybe that will have to wait for a second iteration.
It would also be nice if I had a way to report warnings to the user, but I've not interfaced the Python logging with Rust yet in any way.
As of now I can not make any promises then I get to this, or how long it will take me.
Regards, Markus

Hello Markus
Yes you're right, large files should be fetched differently. MS SQL Server even has a streaming feature for those so you don't have to load these completely to RAM.
Well the silence of the truncation is not nice, but I personally could live with it - I could check the size at server level.
Just by the way: We did a lot of checks regarding performance using various approaches and this library was by far the fastest.
For me this is not urgent and if it gets urgent I can still do a quick and dirty hack by using a fork ;) (I don't have Rust experience nor Python Interop experience...)
Regards,
Adrian

Hello Adrian,
arrow-odbc 0.1.20 does support specifying upper limits for binary and text column buffers. I am leaving this issue open, still because the upstream change I made to provide fallibable allocations, seemed to have some performance issues, I've been unaware of.
See: https://github.com/pacman82/odbc-api/issues/192
I am still thinking about what the best behaviour for this crate should be, given that the cost for the check is high, but also that the allocation error is hard to spot for a Python user, which might not even see the panic.

Great news! Thanks!
I'll test asap and give you Feedback.
About the memory error: this is much more unlikely now, I'd be fine with an unrecoverable error if it causes perf trouble

Hello Adrian,
Closing this issue as I assume this is now solved for you. Would still like to hear about it. You can opt out of the fallibale allocations by setting falliable_allocations to False.
Cheers, Markus


Detect historical or non-standard citations

First, thanks for eyecite. @kfunk074 and I are historians working on American legal history, and we intend to use eyecite for a project in progress.
eyecite does very well with citations from the twentieth century on (post-Bluebook?) but it does not detect citations from case reporters in the nineteenth century. To give one example: before Georgia created official case reports, the de facto standard reporter for Georgia's case law was Kelly's Reports. When Georgia began official reports, it adopted the first five volumes of Kelly as its official reports. So, 1 Kelly 254 = 1 Ga. 254 and so on. Of course citations before the Georgia reports all go to Kelly, but even after the official reports, Kelly might still be cited directly. eyecite will detect the Georgia reports, but not Kelly.
The same is true for basically every state jurisdiction in the U.S. I believe there are issues on this repository that are subsets of this problem. I suspect, e.g., that the reporters listed in this issue (#27) are the same kind of problem as described for Georgia. And it depends on the corpus, of course, but such citations can be a substantial body that are missed by eyecite.
We are currently compiling a list of these "antique" reporters. We would like to contribute a pull request that adds these reporters to eyecite. A few questions.

Would such a pull request be welcome?
If so, could you please give us some guidance about how best to do that. I've looked through the eyecite code, though not in great detail just yet. My understanding is that we would contribute the data to the reporters-db repo, but we could use some advice about how best to do so.
On a secondary issue. Bluebook usually standardizes citations, e.g., to 3 Or. 534 for Oregon. But historically, it's common for such citations to be written as 3 Oreg. 534. We'd also like to contribute some variant abbreviations, and aren't sure what the best way to do that is.

Wow, this sounds great. A few replies:

Would this be welcome?

Yes, absolutely. This is exactly the kind of thing we want eyecite to excel at.

How?

The reporters_db is exactly the right answer for how to do this. The basic trick there is to add these reporters to reporters.json. Once they're added there, we'll update the reporters_db dependency here in eyecite, and that usually will do it. Tests are nice to have too, to make sure things work as expected.
As for how to update reporters_db, the readme should get you pretty far. If it doesn't answer something, I'd be happy to field questions. I'd suggest doing a small contribution first, then adding more and more as you get comfy.

Variants?

reporters_db is organized around reporter abbreviations, and each has the ability to have variants. Here's Or. for example (using jq to filter to it):
↪ curl -s https://raw.githubusercontent.com/freelawproject/reporters-db/main/reporters_db/data/reporters.json | jq '."Or."'
[
  {
    "cite_type": "state",
    "editions": {
      "Or.": {
        "end": null,
        "start": "1853-01-01T00:00:00"
      }
    },
    "mlz_jurisdiction": [
      "us:or;supreme.court"
    ],
    "name": "Oregon Reports",
    "variations": {
      "O.": "Or.",
      "Or": "Or.",
      "Ore.": "Or."
    }
  }
]

You an see that there's a variations key that includes O., Or, and Ore.. If you wanted to add Oreg. that'd be the place to do it.
Thanks for this offer of help. It sounds like it'll add a lot of nice citation formats.

@mlissner Cool. Thanks for the prompt reply. Seems straightforward enough.
I wasn't clear whether the CSV or the JSON in reporters-db was the standard, but now I see it in the documentation. And the variations makes sense.
Two follow up questions:

If we don't know the start and end dates for reporters, can we leave those fields as null? We have not specifically been collecting that data. What's the best approach?
I'm not familiar with multilingual Zotero. Is there a list of the jurisdictions somewhere that we can consult, or should that field also be left blank if unknown? The README seems to indicate that it can be left blank, but wanted to verify.

If we don't know the start and end dates for reporters, can we leave those fields as null?

You can, but if it's possible to have them, they're helpful. We use them in CourtListener to disambiguate citations. I don't have an example offhand, but what often happens is that there is a reporter of decisions who works in one court for a period of time and then moves to another one later. By having the dates of each, we can then figure out if a citation is from the first court or the second one.
So, null is fine, yes, but having them helps.

I'm not familiar with multilingual Zotero. Is there a list of the jurisdictions somewhere that we can consult, or should that field also be left blank if unknown? The README seems to indicate that it can be left blank, but wanted to verify

Honestly, I'm not either, and I don't think these are used anywhere. We'll probably yank them eventually, but for now, what I do is just copy the values from other nearby reporters. Usually that works pretty well, if that'd be OK.

Okay, makes sense. And yes, I completely agree about disambiguation via dates.
We will send a sample pull request to make sure we are doing it right once we've got the right data.

When Georgia began official reports, it adopted the first five volumes of Kelly as its official reports.

In case you haven't come across this yet, the term in legal citation for this practice is "nominative", e.g. "1 Kelly" is the nominative citation and "1 Ga." is the official citation. There's a bug over on reporters-db here for this that includes some more examples.
reporters-db knows about some nominatives and not others -- it knows about all of the nominative citations that the Indigo Book knows about. So for example for Massachusetts it can recognize these nominative cites:

Allen
1861–1867
e.g., 83 Mass. (1 Allen)

Gray
1854–1860
e.g., 67 Mass. (1 Gray)

Cushing
1848–1853
e.g., 55 Mass. (1 Cush.)

Metcalf
1840–1847
e.g., 42 Mass. (1 Met.)

Pickering
1822–1839
e.g., 18 Mass. (1 Pick.)

Tyng
1805–1822
e.g., 2 Mass. (1 Tyng)

Williams
1804–1805
1 Mass. (1 Will.)

But the Bluebook (and thus Indigo Book, and thus reporters-db so far) doesn't know about any nominative cites for Georgia, so eyecite can't recognize 1 Kelly yet.
(reporters-db also knows about whatever else it's been told about, of course, so for example it knows about whatever nominative reporters came into CAP's collection listed over at https://cite.case.law/ )
I don't know why the Bluebook includes parallel nominative citations for some states and not others, but my hunch is that there's a line-drawing problem about figuring out whether a given nominative cite was ever actually used. When I was doing the research behind the bug I linked, you can see I petered out around 86 N.J. Eq., published in 1916, because there continue to be nominative citations for volumes after that but it's not clear they were ever used for anything -- and even the earlier ones were only used a handful of times in published cases. The books continued to be published with front matter suggesting that 86 N.J. Eq. may also be cited as 1 B. Stockton, but no one actually did.
Of course it's great to include any cite format that was in fact used, and it also makes sense to include every time a book itself provided nominative numbering, whether or not it was cited that way. I'm glad you're taking a look at it!
I'll also throw in for those with unrestricted CAP access that a reasonably quick way to check for nominatives is to look at the volume PDFs (which is how I generated the tables in that other bug). For example over in Georgia I can see that the second reporter, Cobb, numbered his first volume as 6 instead of 1, so I know not to expect nominative cites in Georgia after Kelly.

@jcushman Thanks for the very helpful background. The term "nominative cite" is helpful; we had been using "antique cite" as shorthand.

I think this has already been fixed in reporters-db.
Regarding the other nominative reporters (e.g. Ridgely's Notes) some changes have already been made here: https://github.com/freelawproject/reporters-db/pull/192


DEX: Access to previous snapshot data

Get the previous snapshot data from DEX for BALN token in a pool, total LP tokens in a pool and balance of individual LP token holders.

@gedanziger ask @ajaya-man if you need more clarity


precompilation error in Docile with julia v0.4

Hi,
When I try to do using Gadfly on julia v0.4 I'm getting a precompliation error involving Docile:
julia> using Gadfly
INFO: Recompiling stale cache file /Users/bward/.julia/lib/v0.4/Gadfly.ji for module Gadfly.
WARNING: Module Docile uuid did not match cache file
  This is likely because module Docile does not support  precompilation but is imported by a module that does.
WARNING: deserialization checks failed while attempting to load cache from /Users/bward/.julia/lib/v0.4/Gadfly.ji
INFO: Precompiling module Gadfly...
INFO: Recompiling stale cache file /Users/bward/.julia/lib/v0.4/Gadfly.ji for module Gadfly.
WARNING: Module Docile uuid did not match cache file
  This is likely because module Docile does not support  precompilation but is imported by a module that does.
ERROR: __precompile__(true) but require failed to create a precompiled cache file
 in require at ./loading.jl:268

Julia version is Version 0.4.6-pre+34 I think that's more recent than v"0.4.0-dev+6521", but not 100% sure.

It's supported precompilation up until now fine as far as I know, can you delete all the cached files in .julia/lib/v0.4 and see if it still happens?

Yep I'll check, first I gotta wait for a new julia compilation, I wondered if I'd messed something up so I rm -rf'd the folder and am installing again.

Yeah, I've seen these kind of errors before, but typically deleting the cache has work things out... hopefully that's the case here too.

Your suggestion works! Thanks @MichaelHatherly


Implement Shadows V2 and bump version up to next minor version

Implement the revamped shadows. Detailed changes below

Updated shadow values for all sizes.
Added XL size
Updated shadow color token values.
Added "inset-top" "inset-bottom" shadows. (Need to discuss how this gets implemented)

New shadow values :  LIGHT THEME.  |  DARK THEME

New shadow color token values :  PRE-BRAND EVO. | POST-BRAND EVO

New "inset" shadows : HERE

FIGMA - SHADOW v2 (branch)
Acceptance Criteria
References

Made a quick fix to the branch
FIXES

Changed dark mode shadow opacity from 40% to 20%
Fixed light mode overlay color from #000 40% to #000 60% to match production


feat(AFHTTPRequestOperationManager): PUT Request w/ Constructing block

A PUT request that accepts a AFMultipartFormData Protocol block

Can we reopen this discussion? I'd be very useful to have a PUT that supports construction block.


branch.subscribe only works for branch urls

Hey,
After some trouble with setting up my configuration properly (which I think I finally nailed down :) ) I have a strange behaviour in iOS.
When the application is running in the background and I click a non branch url https://myapp.com/content/path the app starts and I can see continueUserActivity in called in AppDelegate.m.
BOOL handledByBranch = [RNBranch continueUserActivity:userActivity];
handledByBranch is YES.
I added my domain to branch_universal_link_domains in our plist.
branch.subscribe callback is also called but with null for params, uri and error
I'm trying not to use Linking.addEventListener('url', this.handleOpenURL); here.
Any advice?

UPDATE: I see that the branch.subscribe callback is called with null values even when restoring the app from background manually (not by clicking a link) which leads me to think that the callback is never called for non branch links.
@jdee any ideas?

On android I managed to handle all incoming links using only branch.subscribe
My code looks like this:
branch.subscribe(({params, uri, error}) => {
    if (error) {
        console.error(error);
    } else if (params) {
        // branch urls
    } else if (uri) {
        // non-branch urls
    }
    // not sure
});

Would be awesome to be able to have the same thing running on iOS

@kfiroo I'm glad you were able to solve some of your problems. In short, I think the behavior you're seeing on Android is unintentional. I think what you're trying to do makes a lot of sense, but it requires a little research for us to get it right in a future release. At the moment, what you want to do just won't work, at least not consistently. You're best off sticking with the two-stage approach you have until we can integrate properly.
The uri argument should only be populated if the link is a custom URI, not a Universal Link or App Link. If it's being populated with App Links to your domain on Android, that may mean that the two unintentionally share a code path. Perhaps you're using the same intent receiver for both, but I'm speculating.
On iOS, you'll need to do something like:
// Respond to URI scheme links
- (BOOL)application:(UIApplication *)application openURL:(NSURL *)url sourceApplication:(NSString *)sourceApplication annotation:(id)annotation {
  return [RNBranch handleDeepLink:url] ||
     [RCTLinkingManager application:application openURL:url
                      sourceApplication:sourceApplication annotation:annotation];
}

// Respond to Universal Links
- (BOOL)application:(UIApplication *)application continueUserActivity:(NSUserActivity *)userActivity restorationHandler:(void (^)(NSArray *restorableObjects))restorationHandler {
  return [RNBranch continueUserActivity:userActivity] ||
    [RCTLinkingManager application:application
              continueUserActivity:userActivity
                restorationHandler:restorationHandler];
}

This will ensure that the right layer (ReactNative.Linking or react-native-branch) is called for a given URI/URL.
In JavaScript, you'll have to call both branch.subscribe and Linking.addEventListener. I think the most sensible thing would be to have a separate code unit that handles URL routing and then pass the URLs from both these callbacks (the resolved URL from params['$canonical_url'] or params['$desktop_url'], etc. in the case of Branch links) to the same place.
In the future, we can simplify this, but that's how it works in the current release.

@kfiroo Another option that could be simpler for you:
callback = (event) => {
  var url = event.url
  if (!url) {
    // must be from Branch
    url = event.params ? event.params['$canonical_url'] : event.uri
  }

  if (!url) return // no URL found

  // now handle the URL, wherever it came from
}

Linking.addEventListener('url', callback)
branch.subscribe(callback)

@jdee Thanks!
Btw, I'll be happy to contribute in any way I can, let me know if you think I can help out :)
My iOS code looks very similar, i just have some Facebook integration code in there.
The javascript code is also very close to what you have here, only I noticed I sometimes get the url in params['+non_branch_link'] is that expected?
I guess what confused me was this part of the docs (both Branch & non-Branch)
// Subscribe to incoming links (both Branch & non-Branch)
// bundle = object with: {params, error, uri}
branch.subscribe((bundle) => {
  if (bundle && bundle.params && !bundle.error) {
    // grab deep link data and route appropriately.
  }
})

I was struggling to get the subscribe to work for all links, universal and app links.

@kfiroo Sorry for the delay. I think I was wrong about this. In fact, the +non_branch_link parameter is a supported feature, at least in the iOS SDK. I still have to test it out on Android. There are some changes required for the +non_branch_link parameter to make it through on iOS. I'll have something for you to try out soon. Sorry for the confusion.

@kfiroo If you have the chance, please try out the master branch (if you're using 1.0.x) or the maintenance-0.9 branch (if you're using 0.9.x). The uri field should show up for non-Branch links. What you had working for Android should work on iOS as well.

@jdee Amazing! Thanks for the quick response! :)
I'll test it out first thing tomorrow morning and let you know

@jdee Hey, I tested the changes on master on iOS and unfortunately it's still not working as expected :(
When clicking a non-branch url (https://mydomain.com/path/to/content) on both warm and cold starts (app is running in the background and app is completely closed respectively) trigger the subscribe callback with {params: null, uri: null, error: null}


Enhancements to Box Plots

Box Plots:

I would like to see the screen have the list of the outliers (outside the 50th percentile or a user defined percentile) or have the option to download the outliers.

It would be nice if the user could add color to the box plot to make it “pop” better.

Whenever I use a boxplot, I have an explanation that I use. It would be nice to have an explanation of the quartiles, outliers, etc on the screen for new people to use and old people to cut and paste into slide shows.

you can now hover and see what the outlier are. Not sure if downloading those would be an easy task or not...off-hand I don't know an easy way to do that.
like the orange?
hmmm....I'll try to dig something up.

Like the hover id but you can't tell where the point is unless you download the data and find it that way.  Is there a way to add the site/county too?  Probably not as there isn't much space.  Just thinking out loud here...

Love the orange!  This looks good.  Festive too.

How about this for an explanation graphic?

Oh I see we've added those cross-whiskers.


Please check: "We have improved My Sign-ins and My Security-Info to give you more clarity on the types of Microsoft Authenticator other Authenticator apps a user has registered."

Hello,
please check if 'or' is missing from this string: "We have improved My Sign-ins and My Security-Info to give you more clarity on the types of Microsoft Authenticator other Authenticator apps a user has registered." under "General Availability - My Security-info now shows Microsoft Authenticator type".
I think it should read: "We have improved My Sign-ins and My Security-Info to give you more clarity on the types of Microsoft Authenticator or other Authenticator apps a user has registered."
Currently, the sentence is not clear and translators are having trouble interpreting it.
Kind regards,
Anne H., QC

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a89edb7f-c01c-00d7-0c2e-2e07921b89ee
Version Independent ID: 0325cc56-f493-07e5-3792-249c684fca85
Content: What's new? Release notes - Microsoft Entra
Content Source: articles/active-directory/fundamentals/whats-new.md
Service: active-directory
Sub-service: fundamentals
GitHub Login: @OWinfreyATL
Microsoft Alias: owinfrey

@QueryCoordinator
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


App session and app state update to 3.1

@dougbu has anything changed in 3.0 for app and session state - that we need to document?
19.3K PV

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 76e22150-f1f1-5e4f-0e97-39b1ac089297
Version Independent ID: 687172c3-b7d8-525d-39dc-658b4a0f526f
Content: Session and app state in ASP.NET Core
Content Source: aspnetcore/fundamentals/app-state.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Whoever has free time first can grab this.

@guardrex I'm not aware of anything new or different. @mkArtakMSFT❔ @rynowak❔

I had problems accessing HttpContext.Session, I got a Error: an object reference is required
I fixed it adding
@inject IHttpContextAccessor HttpContextAccessor
And then calling the Session methods using:
HttpContextAccessor.HttpContext.Session.SetString(...

@mkArtakMSFT please assign someone to review 3.0 changes to App session and app state. Customer reports changes.

When I examine ((Microsoft.AspNetCore.Builder.ApplicationBuilder)app)._components.Select(comp => comp.Target) at the end of my Configure method, I see no entry for SessionMiddleware, so apparently some other middleware is now doing its job in ASP.NET Core 3.0.0.  I'm not sure what, though.  The docs should be updated to reflect this.

@JunTaoLuo who can review session state changes for 3.0? We're getting lots of issues that things have changed for 3.0
cc @mkArtakMSFT

@anurse who would be the best person to review this?

@Tratcher would probably know if anything changed in Session. I'm not aware of any significant changes.

Session hasn't changed in 3.0. The samples do need to be updated for endpoint routing though.

@jez9999 does your app call UseSession?

@jcmarcanotrias that sounds like a problem with HttpContext in your razor page, not Session.

@Rick-Anderson Related to this work :point_right: https://github.com/dotnet/aspnetcore/issues/18081#issuecomment-572209346

Ah yeah, I forgot this was already on the docket :). Cool. I'll capture the gist of that linked issue here and close the aspnetcore one since we're tracking updates to this doc already.

Related to this work 👉 dotnet/aspnetcore#18081 (comment)

We should update the brief section we have detailing storing arbitrary objects using JSON serialization by ensuring that a 3.1 version of 					aspnetcore/fundamentals/app-state/samples/2.x/SessionSample exists that uses System.Text.Json in SessionExtensions

Could I just ask if there is a code sample anywhere on how to replace the Newtonsoft.Json sample here for a System.Text.Json version now that is the default?
For example, this is the current sample:
    public static class SessionExtensions
    {
        public static void Set<T>(this ISession session, string key, T value)
        {
            session.SetString(key, JsonConvert.SerializeObject(value));
        }

        public static T Get<T>(this ISession session, string key)
        {
            var value = session.GetString(key);

            return value == null ? default(T) :
                JsonConvert.DeserializeObject<T>(value);
        }
    }

@tdykstra do we have any System.Text.Json samples like the preceding?

If you replace JsonConvert.SerializeObject(value)
with JsonSerializer.Serialize(value) and JsonConvert.DeserializeObject<T>(value) with JsonSerializer.Deserialize<T>(value)  it should just work, depending on what types you're trying to store. See the How to Migrate from Newtonsoft.Json article.
cc @ahsonkhan

Thank you for replying So, this is what I ended up doing, not sure if this is correct or not but seems to work:
using System.Text.Json;
using Microsoft.AspNetCore.Http;

namespace Web.Extensions
{
    public static class SessionExtensions
    {
        public static void Set<T>(this ISession session, string key, T value)
        {
            session.SetString(key, JsonSerializer.Serialize(value));
        }

        public static T Get<T>(this ISession session, string key)
        {
            var value = session.GetString(key);
            return value == null ? default : JsonSerializer.Deserialize<T>(value);
        }
    }
}

Could I just ask if there is a code sample anywhere on how to replace the Newtonsoft.Json sample here for a System.Text.Json version now that is the default?
For example, this is the current sample:
    public static class SessionExtensions
    {
        public static void Set<T>(this ISession session, string key, T value)
        {
            session.SetString(key, JsonConvert.SerializeObject(value));
        }

        public static T Get<T>(this ISession session, string key)
        {
            var value = session.GetString(key);

            return value == null ? default(T) :
                JsonConvert.DeserializeObject<T>(value);
        }
    }


Remove libssh2 workaround

CentOS 8 repo no longer contains libssh2 rpm and installing from ManageIQ copr repo won't conflict, so removing the workaround.


Using container.copy to insert content of a file into a string

Hello! I am using the following method (which I found in stackoverflow) to redirect the stdout into a variable.
def with_captured_stdout
  begin
    old_stdout = $stdout
    $stdout = StringIO.new('','w')
    yield
    $stdout.string
  ensure
    $stdout = old_stdout
  end
end

In conjuction with the container.copy('/etc/hosts') { |chunk| puts chunk } function, I am retrieving the content of a text file ("Hello") in a string with the following code:
str = with_captured_stdout { sss.copy('/etc/output.txt') { |chunk| puts chunk }  }

Nonetheless, printing the string results in the following output
irb(main):018:0> print str
output.txt0100644000000000000000000000000612442645754011357 0ustar0000000000000000Hello

=> nil

As I can see in the documentation, .copy exports the contents as tars. Could you suggest me how to use .copy to insert the content of a text file in the container into a string?

This worked, note the very important error handling, as null file names (result of something following too long of a file name) was wiping out the parent dir permissions.
      def extract_files(container, from = '/project/target', to = '.')
        # or something like
        tar_stringio = StringIO.new
        container.copy(from) do |chunk|
          tar_stringio.write(chunk)
          # puts "#{chunk}"
        end

        tar_stringio.rewind

        input = Archive::Tar::Minitar::Input.new(tar_stringio)
        input.each { |entry|

          # Need to check the file name length to prevent some very bad things from happening.
          if entry.full_name.length > 255
            puts "ERROR - file name length is > 255 characters: #{entry.full_name}"
          elsif entry.full_name.length <= 0
            puts "ERROR - file name length is too small: #{entry.full_name}"
          else
            puts "Extracting #{entry.full_name}"
            input.extract_entry(to, entry)
          end
        }
      end

If there were a wiki, I'd put this in it...

This seems to be more in the scope of Archive::Tar::Minitar's wiki.  Since the issues are searchable, I think it's fine to leave here.  If we get more people asking how to work with tars from docker, we can throw something small in the README.  One thing to note is most ruby tar libraries aren't perfect and most don't support the PAX extended headers that docker will export.


Namespace name normalization and safety/convenience mkdir

Figured you may wanted a few simple fixes I put through. First time use of the plugin throws dump to console when fallback directory is not present and didn't check for it. Also I 'normalized' some of the namespace names, the lt- or lt_ is really unconventional. In order to prevent a lt.plugins.snippets.snippets, I renamed the latter to a mere snip (src/lt/plugins/snippets/snip.cljs) but left a few other anomalies in tact for now so to speak (behavior naming convention and underscore commands are typically not done either but this might impact experience by user preferences hard referencing those names - in other words: to remain backwards compatible, unless people eval strings in their settings but that is impossible to not break otherwise)

Cheers !
This plugin was one of my first adventures into clojure/clojurescript land. There are probably lots of less than idiomatic implementation details. Using the project name as the root namespace name is not totally unheard of, (clj-http springs to mind), but yeah it the exception rather than the norm. But the lt-snittets.clj file naming makes little sense and there is a lovely mix of underscore and hyphens (:
With regards to the directory issue, I actually have created a fix for that but hadn't pushed (and set the default to a sub dir of the user plugin instead)
If you feel inspired to submit addtional pr's in the future, leave the compiled stuff out. (I'll put a contribute section in the readme).
Cheers for you contribution. Glad to see that someone is using the plugin !


Add location proptypes

Deploy preview for calpa ready!
Built with commit 9a0e6426b5a1a789bed4fea6f0eff1445a95369d
https://deploy-preview-61--calpa.netlify.com

@MCLofton Thank you for your contribution, and your pull request is merged.

Solve #35


Fixing incorrect Skuber url (doriordan/skuber)

Just fixing a wrong url.
The doriordan/skuber is the correct link (295 stars as of today), hagay3/skuber is a fork with 2 stars.

 Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
I have now signed this

/check-cla

Hey there! @briansterle, looks like you haven't signed the CLA yet. Could I please have you do that? https://github.com/kubernetes/community/blob/master/CLA.md

Hey Jim, just signed & submitted!

bump @jimangel

👋 @briansterle .
I plan to close this pull request. At any time, you can reopen this PR and continue to work on the changes.
/close


Set headers (meta) with context.req

Is your feature request related to a problem? Please describe.

Our app is served from multiple domains and we want to customize the headers (favicon, title, etc..) from the domain. I suppose I can get the origin domain (host) from the context.req but I need to dynamically set the headers.
Describe the solution you'd like

An api tp call in a serverMiddleware or other to dynamically set the metas.
export default function ({ app, req }) {
  if (req.headers.referer == 'myDomain.com') app.meta.set({title: 'my custom title'})
}

But I don't find any apis to dynamically set the headers apart from the head method
 which doesn't take the context in parameters. And I want to set it once far all the pages.

Yes head function does not take context in parameters but asyncData take the context. Inside asyncData you can read requested host and then use it in head function.
  asyncData({ req }) {
    const host = req ? req.headers.host : location.host;
    return {
      host: req.headers.host
    };
  },
  head() {
    // this.host is  ready to use
    return {};
  },

@ThomasKientz You should be able to do this with Nuxt as-is. See https://codesandbox.io/s/wizardly-hermann-sl9my?file=/pages/index.vue for a minimal example.


Design principles

I'm rewriting the contrib doc to make easier to read and consume.

Codecov Report

Merging #255 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   92.17%   92.14%   -0.04%
==========================================
  Files          35       35
  Lines        3158     3158
==========================================
- Hits         2911     2910       -1
- Misses        247      248       +1

Impacted Files
Coverage Δ

databricks/koalas/__init__.py
88.88% <0%> (-3.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3e5160...e8a606c. Read the comment docs.

LGTM. Thanks, @rxin and all.

I made a mistake that the merge didn't include my final commit. I had to push that commit directly to master.


docs: add hono guide

Status

READY
Description
I added guide for Hono
Related PRs
none
Todos

[x] Tests
[x] Documentation
[x] Changelog Entry (unreleased)

Steps to Test or Reproduce
none

I fixed word a little.

@melloware
Could you review again ?


uORB::Publication simplify and cleanup

drop linked list
base class is now template
virtualization no longer required
type safety!
ekf2 updated to only publish with uORB::Publication

Tested on Pixhawk 4 V5 f-450
Modes Tested
Position Mode: no issue
Altitude Mode: no issue
Stabilized Mode: no issue
Mission Plan Mode: switch to hold mode
RTL:  switch to hold mode
Notes:
no mission mode and no rtl mode upload to master firmware and no issues
pr tested log:
https://review.px4.io/plot_app?log=b93bbe2b-d7b4-409a-97c6-3e00998db9ca

Your home position wasn't being published. Can you please try again with the current state of the PR?
Thanks

I'm wait 10 minutes for GPS Lock on the pr, change to master and have GPS Lock on 30 seconds, I'm flight again for confirming

Tested on Pixhawk 4 mini v5
Modes Tested

Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

Procedure
Arm and Take off in position mode, after flying for approximately one minute, switched to altitude then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.
Notes:
No issues noted, good flight in general.
Logs:
PR 12210

https://review.px4.io/plot_app?log=0e8905d1-97cb-4178-a039-cca3fc19dc50

Master

https://review.px4.io/plot_app?log=b014c23c-c92a-45fd-8bc7-062bac5d909e

Tested on Pixhawk 4 V5
Modes Tested
Position Mode: Good.
Altitude Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.

Procedure
Arm and Take off in stabilized mode, position mode, altitude, and mission mode

Notes:
No issues noted good flight in general.
pr Log:
https://review.px4.io/plot_app?log=2c809d10-c7f7-49bd-b278-c7efa225bf9c
master log:
https://review.px4.io/plot_app?log=71a5aa74-1e6e-4c9c-ae20-2baff55f3daf

Tested on PixRacer V4
Modes Tested
Position Mode: Good.
Stabilized Mode: Good.
Mission Plan Mode (Automated): Good.
RTL: Good.
Procedure
Arm and Take off in position mode, after flying for approximately one minute,then stabilized mode proceed to switch to mission plan mode then make sure that vehicle follows all waypoints as shown in QGC, once completed all waypoin activate RTL and see landing behaviour.
Notes:
No issues noted, good flight in general.
Logs:
https://review.px4.io/plot_app?log=e6d7dc6a-5843-461c-8931-630b18e1634b
MASTER COMPARISON
https://review.px4.io/plot_app?log=8705340c-1489-47db-adf4-81e32bf1fd55


Batched inference support

Does the model support batched inference support?
I removed the 1 image per GPU constraint and sent a tensor of shape [32, 3, 704, 1344] into the model (SipMask-mmdetection/mmdet/configs/sipmask/sipmask_r101_caffe_fpn_gn_ms_4x.py), but the output from the model is the same for shapes [32, 3, 704, 1344] and [1, 3, 704, 1344]

@SamSamhuns I am not sure about batched inference.


ActiveRecord relations operates only with static data, so can be converted to static

When investigate relation life cycle - it can be defined before the concreate instance of class created. So in fact this functionality can be moved to static functions.
little refactoring required in ActiveRecord to manage:
getRelation()
hasOne()
hasMany()
_behaviors
as static members.
The customer - relation definitions will be changed to static as well:
public static function getCategory()
{
return static::hasOne(Category::className(), ['id' => 'main_category_id']);
}
As result if we need to access relation data in static context we don't need to instantiate a dumb object to obtain relational data.

it can not, creating a relational query needs an AR instance: https://github.com/yiisoft/yii2/blob/master/framework/db/BaseActiveRecord.php#L378

Can't it be  '$query->primaryModel = new $modelClass;' where $modelClass=get_calling_class(); or something?

if you run a relational query, you need not only an instance of the record but the one that has this relation including its attributes. e.g. to get relations for user 1, you need exactly this instance.

in this particular situation, the all of the relational data is aggregated in the _relations member which collect the relational data. It use 'getXXX' method just to get the definition, and linking can be done on later stage. IE:
ConcreateAR
{
public static $_relations;
public $__relations;
public static function getXXX(){
return new ActiveQuery()->with_some_conditions();
}
}
when we instantiate class

we scan for all of the relations and populate static $_relations member -  this is something like cache - because happen only once per concreate AR subclass.
per user access to relation like $a->xxx
we obtain apropriate ActiveQuery instance, clone it, then initialize with primary record with $this, execute query and ->pupulateRelation(with_the_query_result); The real place where we need to bind query with primary model is here. On the phase 1) real instance is doesn't matter until all schema info is static.

I we do this, and we allow calling the relation method statically, the result of that method call is undefined. The case where you call $post->getIAuthor()->where(...)->one() needs a non static call to create the correct query. Post::getAuthor()->where(...)->one() is missing a context.


Support chunked file uploads

Currently files can only be uploaded with a single API call, meaning that files that don't fit in either the client or server memory can't be uploaded.

Have you tested this? I am pretty sure the server supports streamed requests which are dumped to a temporary file.

It would still be a good feature but I don't think there should be any memory issues with the current implementation.

I did some testing, and it turns out you're absolutely correct. I tried uploading a ~21 gig file (on my machine with 16 gig RAM), and found that it worked fine when running in Docker. Running the server locally did give me an error: Uncaught error in POST /api/libraries/1/entries: write /tmp/multipart-1223679258: no space left on device, but that's because my /tmp mount is only 8 gig. I'm not sure how that's set up by default on other machines (Windows, Ubuntu, etc) but I don't think it should be an issue there. For now I'll close this issue ^^

Yeah it differs a lot per linux distro. Most ubuntu distros don't have a separate /tmp mount I believe. Most arch distros have a ramdisk mount on /tmp of 50% your ram. On windows the TEMP dir is just a directory on your C drive.


Graphics behind the transparent label backgrounds are not showing.

Hello,
I figured out a rendering bug. If user adds label to map with transparent backgroundColor (like Color(0, 0, 0, 0.15) and sets showBackground to true, graphics behind the label are not showing but only world imagery.
Sandcastle example: Click to see.
Browser: Google Chrome 83.0.4103.116 & Internet Explorer 11.1282.17753.0
Operating System: Windows 10 Enterprise
What Actually Happens: Graphis behind the label are not showing.

Expected Behavior: User can see other graphics behind the label. For instance, graphics that behind a polygon are rendering as expected.

Thanks for reporting @Aknbb - this does appear to be a bug to me.

Hello, is there any update about this bug?

Also reported in https://github.com/CesiumGS/cesium/issues/10745
As @onderaltintas added:

You cannot pick labels easily and have to hit exactly on letters when you do background: false. Lowers user experience. If pick algorithm would be fixed for labels, no need to fix this one for me.

Also reported on the forum: https://community.cesium.com/t/incorrect-overlay-with-material/26965/2

This is the same I think
https://community.cesium.com/t/cesium-not-show-anything-under-transparent-background/23062/7


[HELP] Will etcd data be lost if microshift restarts?

Will etcd data be lost if microshift restarts?

etcd data is persisted in /var/lib/microshift directory and it's not lost on MicroShift restart.
To clean all the MicroShift-specific data, use the following script.
$ /usr/bin/microshift-cleanup-data
Stop all MicroShift services, also cleaning their data

Usage: microshift-cleanup-data <--all | --ovn>
   --all   Clean all MicroShift and OVN data
   --ovn   Clean OVN data only

@ggiguash  Thank you for your answer


Parser mishandles ^/POWER

In working on #210, I've run into what appears to be a parsing issue with exponentiation.

The latest issue is a mix of operator precedence and formatting/parsing complex numbers. I think, essentially, that x^1-2i is supposed to be parsed as X ^ (1-2i), but is instead being parsed as (X^1) - (2i).

This appears to be a bug in the parser. The Quil grammar specifies that ^/POWER is right-associative, so I think you are right that X ^ (1-2i) is the correct parsing
Originally posted by @Shadow53 in https://github.com/rigetti/quil-rs/issues/210#issuecomment-1588149103

I think the main problem is actually the parsing of complex numbers. quil-rs parses the real and imaginary parts separately, so, e.g. 1-2i parses into
Infix{operator: Minus, left: Number(real!(1.0)), right: Number(imag!(2.0)) }

instead of
Number(Complex64::new(1.0, -2.0))

As pointed out to me elsewhere, my personal understanding of complex numbers doesn't jive well with how we should handle them. Just put parentheses where you need 'em, @genos.


Start testing sphinx 1.8

Should we deprecate sphinx 1.3 and 1.4?
Tests should pass after https://github.com/rtfd/readthedocs-sphinx-ext/pull/53 is merged

Should we deprecate sphinx 1.3 and 1.4?

Yea, that makes sense to me. 👍


Regenerate API only if it is needed.

Instead of regenerating the API with every call of generate, using a simple checksum (for example with checksumdir or a custom impl) can avoid unnecessary API generation.

Investigate if zserio itself could support this using timestamps checking which would work everywhere. Please note, that currently we don't know which sources are generated.

Investigate if zserio itself could support this using timestamps checking which would work everywhere. Please note, that currently we don't know which sources are generated.

Another idea is to calculate checksum of sources (this will be provided by core) and to calculate checksum of generated sources. These checksums can be stored in generated directory. Please note that checksum of generated sources are necessary because user can delete or change something in generated directory.

Another idea is to calculate checksum of sources (this will be provided by core) and to calculate checksum of generated sources. These checksums can be stored in generated directory. Please note that checksum of generated sources are necessary because user can delete or change something in generated directory.

This issue will be solved directly be zserio compiler: ndsev/zserio#286


Enhancement: OpenAI Assistant automatically starts a thread without user message

What features would you like to see added?
Has the ability to enable/disable when OpenAI Assistant is selected can start the thread and call run without any messages
so the Assistant with the instructions defined will provide a response of welcome and hints for the user:

More details
Sometimes we need that Assistant start the conversation with some user hints for better usability (this is part of the instructions). Using OpenAI Assistant playground you can get that  when you click on Run without any message, then it will create the thread and run the thread and then you get a response from the assistant with the user hints as initial conversation.
Which components are impacted by your request?
Endpoints
Pictures
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I didn't know this was a feature, will have to think about how to integrate this


Show / hide all buttons don't set header group visibility state

This PR is related to #1013

@KevinVandy
We have a table with repeating column groups with the following leaf columns:

Evaluation
Detail A
Detail B
Detail ...

for those where a evaluation is present only the evaluation should be visible by default and for those without the details should be always visible.
We also implemented a detail switch wich shows those columns where a evaluation is present.
But when a column group is hidden as a whole and the detail view is enabled those column groups which should remain hidden appear again because there is no other way of determining if those columns should be set to visible again since we can't rely on the Evaluation column.

@ThisIsHG I think I'll just change TanStack Table like this:

@ThisIsHG If v2.12.1 works for you, we can close this PR.

Will validate it first thing in morning tomorrow! But thanks in advance!

@KevinVandy works like a charm!
Thanks for bringing it so fast into the Table!


Update WritingTests.md

Example for middleware testing should destructure the store param that is being passed through invoke(). Currently, the example shows invoke((dispatch, getState) => { ... }) on LINE 456, but it should read as invoke(({ dispatch, getState }) => { ... }).

Thanks!

@timdorr Actually... I was wrong. I was using the middleware+thunk example to write a test for custom middleware and I was handling the inner logic differently. The example on the website is already correct. Can I take this back, haha? :sweat_smile:

No worries. That tripped me up too! I'll revert.


#20925 [Chrome] Cards inside .card-columns stack differently

https://github.com/twbs/bootstrap/pull/22378

Have any explanation for the changes? Or a JS Bin demo of the before/after?

http://codepen.io/trackleft/pen/ZedaXb

Never saw an updated example, and given the lack of context here, I'm going to close this out for now. Happy to revisit in the future with an example that explains the changes!


Updated most npm deps [Dec 2024]

Leaving React Router v7 for now
@coderabbitai ignore

@coderabbitai ignore


Link specified as plain text

Link specified as plain text
This class URLClassLoader implements the interface Closeable, so condition 'contextClassLoader instanceof Closeable' is always 'true'

Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[ ] Verify documentation

LGTM, thanks for the contribution!

Thank you for approving this pull request.

@bot-gradle test and merge

No milestone for this PR. Please set a milestone and retry.

@bot-gradle test and merge

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bodhili A test is failing because you changed the class in wrapper jar. This hash code needs to be updated, too.
https://ge.gradle.org/s/dnjnhqbengqzc/tests/:wrapper:forkingIntegTest/org.gradle.integtests.WrapperGenerationIntegrationTest/generated wrapper files are reproducible?top-execution=1

@bodhili A test is failing because you changed the class in wrapper jar. This hash code needs to be updated, too.
https://ge.gradle.org/s/dnjnhqbengqzc/tests/:wrapper:forkingIntegTest/org.gradle.integtests.WrapperGenerationIntegrationTest/generated wrapper files are reproducible?top-execution=1

Hmm,  I'm sorry,  I'm still at the beginning, and I don't quite know how to update the hash code, can you help me, thanks

@bodhili A test is failing because you changed the class in wrapper jar. This hash code needs to be updated, too.
https://ge.gradle.org/s/dnjnhqbengqzc/tests/:wrapper:forkingIntegTest/org.gradle.integtests.WrapperGenerationIntegrationTest/generated wrapper files are reproducible?top-execution=1

Hmm, I'm sorry, I'm still at the beginning, and I don't quite know how to update the hash code, can you help me, thanks

Is this hash code bb7cd61bf1c9aa32212b8ad809abba72f050d162f1eed17acf1321bb80d9ce1f to replace 577b2de036000db2e0f04f2ec842a4f1e648c8b6f9c87f29a8d8253acb17?

Exactly.

@bot-gradle test and merge

OK, I've already triggered a build for you.


Navigation by Up/Down arrows

Describe the solution you'd like
Navigation in arrow direction like it is in MathQuill. For example, when pointer in the last atom of an exponent then down arrow moves pointer on one level down.
Difficulty: How difficult would it be? (Trivial, Very Easy, Easy, Moderate, Hard, Very Hard, Tedious, Backbreaking)
Easy.
Additional context

This is covered by Left/Right arrows.

This is covered by Left/Right arrows.

For now yes but for superscripts/subscripts/fractions it would be normal to use up/down.


feature/other

add new tests

Just change 'contain' with 'have.text' where we just check text message.

In some places I couldn't use have.text instead of contain.


Best practices to fetch all referenced data

Hello,
I'm trying to find best solution for fetching whole referenced data.
We've got following "database" structure:
{
  genresById: {
    1: {
      name: "Crime",
      titles: [
        $ref('titlesById[1]'),
        $ref('titlesById[3]')
      ]
    },
    2: {
      name: "Comedy",
      titles: [
        $ref('titlesById[2]'),
        $ref('titlesById[4]')
      ]
    }
  },
  titlesById: {
    1: {
      name: "Godfather"
    },
    2: {
      name: "La vita è bella"
    },
    3: {
      name: "Pulp Fiction"
    },
    4: {
      name: "Intouchables"
    }
  }
}

Question: What is the best way to fetch all titles for genre with id 1?
The only way I've found is to do overfetch, like this:
model
  .get(["genresById", 1, 'name'],
       ["genresById", 1, 'titles', {to: 100}, ["name"]],
       ["titlesById", {to: 100}, "name"]
      )

For me it seems that it shouldn't work like that, as we are querying for more data than exists in database. Am I right?
It could be great if documentaion will have some examples how to do that properly.
Full working example could be found here: https://github.com/Animagani/falcor-referenced-data

The way I always approach this problem is:

Get into a real-world mindset and assume the database list ("titles", in your case) would eventually grow to have more things than would fit in browser memory, or at least more than would be appropriate to load into a single view.
Build my list view to support some kind of pagination from the start, and decide up-front how many things to display per page. This decision is informed purely by UX factors like available screen space and load time, rather than being a guess of how many items might exist in the DB.
In the list view, if the result is undefined (as is the case in an over-fetch) then simply don't render it or render some kind of blank "tile" or placeholder, depending on the mechanics of the view.

It sounds like you're misunderstanding something.  Why are you fetching titlesById directly?  The items in genresById[1].titles reference titlesById, and Falcor will follow this reference directly.  So if you just want the titles in genre 1, ["genresById", 1, "titles", {from: 0, to: 100}, "name"] is sufficient.


refactor some code

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #4623 (8dd4543) into master (709a50d) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #4623      +/-   ##
============================================
- Coverage     66.96%   66.95%   -0.02%
- Complexity     7916     7917       +1
============================================
  Files          1096     1096
  Lines         31319    31311       -8
  Branches       2824     2822       -2
============================================
- Hits          20972    20963       -9
  Misses         8718     8718
- Partials       1629     1630       +1

Impacted Files
Coverage Δ

.../shenyu/plugin/context/path/ContextPathPlugin.java
77.77% <75.00%> (-7.94%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Spike: investigate adding connectrpc support

We need a comprehensive solution to support not only gRPC and HTTP2 but also seamlessly fallback on HTTP when HTTP2 is not available.

@suchak1 @dmihalcik-virtru @suchak1, added some links I found to the description

Results
platform: All RPCs, clients, and registration functions were converted: https://github.com/opentdf/platform/pull/1521
Only one auth interceptor was converted (auth disabled).
otdfctl: All handlers were converted and platformEndpoint issue corrected: https://github.com/opentdf/otdfctl/compare/main...feature/connect
Challenges
A full conversion to connect has required hundreds of changes. It would require many more in DSP (including tructl, and PEPs), resulting in large breaking changes.
Ideas
We could wrap the RPCs, create v2 versions of services, handlers, clients, etc, and package both grpc-gateway and connect implementations (perhaps on different ports). This wouldn't require new major versions, and we could convert downstream dependencies gradually.


Monsters don't show up in naming menu anymore

I think this is because of the HD portraits fix (I just updated to 0.1.2 and didn't check if this issue happened with 0.1.1) but when you tame a monster and the game goes to the menu to name it, the monster doesn't show up anymore. I've tried with 2 boss monsters and a Wooly and they all look like this:

Sorry this took so long, been very busy at the moment but this should be fixed in the latest release. That is unless there's more parts of the game where it has 3D previews but hopefully this is it!


0801-Deploying Windows with AutoPilot

Module: 08
Lab/Demo: 01
Description of issue
The 'important' note at the start of this lab makes no sense.

SEA-W10-CL3 is also a Virtual Machine, it also has a Virtual TPM. The only thing we can't do from any VM in the labs is the Autopilot Reset + self-deploying.
We can use SEA-WS4 for the initial Autopilot deployment in the same way we did in MD-101 for years. In my opinion, this note should be removed and we should continue to use SEA-WS4 for lab 0801.

@maquinl
I see you updated Lab 0801 with this commit : https://github.com/MicrosoftLearning/MD-102T00-Microsoft-365-Endpoint-Administrator/commit/da8373a7d999387bc2d0ddbcc5e06d5cce90ccf7
The text still makes no sense. Windows 11 works fine for the Autopilot user-driven scenario.

@WigF1 thanks for the feedback, we will review this further and update the lab.

I've just been through the lab simultaneously on SEA-WS4 and SEA-WIN10-CL3 and it worked fine.
Well, I say "simultaneously" but SEA-WS4 sat at 1% until the other machine had almost finished its installation.

It also works on SEA-WS1, SEA-WS2 and SEA-WS3 like it always did. As I mentioned in #49 it's only the self-deploy that we can't do with a Virtual TPM. This lab works fine.

@WigF1 - thanks for bump. Tagging the content dev, @MSFT-rstearman for further review.

We are currently reviewing the course and will create an alternative to this lab.


[RPC API Improvement] - Add object type to transaction effect [SUI-62]

Made some initial changes towards the addition of object type to transaction effect.
@patrickkuo Please review my progress til now and confirm that I am on the right path.
I know that those changes don't pass all the test yet.

we cannot doen all actions properly

nice

Closing as stale! I believe, we have this change today.


The text box that sends the message should be in a fixed location

Validations

[X] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that requests the same enhancement

Problem
Sometimes when you read the historical conversation records, ask questions according to the historical conversation, because the input box is not fixed, resulting in the need to scroll back, which is very inconvenient, because many times you need to ask questions against the chat records
Solution
Improvement plan:

Ensure that the position of the information input box is fixed
Add a scroll bar so that you can quickly drag to the scroll bar and support clicking to scroll to the bottom or top

I'd like to work on this issue.


Fix bad relative path in example 07

./tmp/07 -> ./07.volumes/tmp/ ensures jet steps actual builds
successfully.

Figured I wrote bash wrong and thus the retry loop would actually only retry once in Step 18. That should be fixed now.

What's interesting, last week a single retry was still good enough. Now it is not anymore. Having the slight hunch, that starting containers is slowing down in Codeship Pro? Could there be any relation of Janus having "higher" load and thus Jet having a harder time getting containers to run? Any idea @GeorgeMac ?

@LarsFronius could indeed be. Worth investigating.

Might have been related to all the janus load?!


simplify multicast detection

Extracted from issue #87.
Currently weave detects multicast by checking for the specific the MAC address prefixes signifying IPv4 and IPv6 multicast frames, as per http://en.wikipedia.org/wiki/Multicast_address#Ethernet
However, weave does not care about protocols, so we could simply check for anything signifying ethernet multicast, i.e. MACs with the LSB of the first octet set.

@rade Does this code path imply that every multicast packet is sent up to the miss handler in user space where it gets replicated to out?  or does the replication get done in a flow?

@chino you are commenting on an issue that was closed nearly three years ago; a time when Weave Net passed all packets through user space. These days, when Weave Net's fastdp mode is in operation, all packet routing, including for multicast, happens in kernel space.


Add Line/Route Number to HTML Journey Report

I love this Adapter - Thank you !
I am outputting this via IOBroker to Jarvis HTML Widget, and when i select ALL DEPARTURES from our town, there is NO Bus Line Number visible.
Current Columns are:
TIME / DIRECTION / PLATFORM / DELAY / TYPE

I see in the JSON File Results that all information is available, but I am not good enough to extract the columns from JSON to the JSON Widget.
Or provide instructions how we can extract the Information we need from the JSON file in the documentation.
Ideal would be:
Bus Line Number / Scheduled Arrival Time / Delay / Direction /
Thanks !

Hello @flyboy70
There are so different preferences for the output. But all fields are direct object in ioBroker.
I don't no Jarvis, but in normal VIS it is possible to reference ioBroker objects in HTML code. So you could create a table as you prefer.
Maybe you can ask in the ioBroker Forum or someone who knows Jarvis ?
Kind regards, Ralf


Update .dockerignore

Due to changes in https://github.com/rhasspy/wyoming-satellite/commit/5088b590a63da61c01db78d35c259a4babaf6e53 file VERSION is required within the docker image and must be allowlisted in .dockerignore

Thank you!


Visualize computation graph

We should provide a good way to visualize the computation graph.

#193 is a first pass at this.


Add dependency info to maven jar generation

This fixes not being able to use the provided jar to compile a dependent plugin because of missing brigadier dependency info.


Therapeutic Regimen Error

Therapeutic regimen UI allows the saving of corrupt phenopackets that then will block the reloading of the previously created phenopaket

@belkassaby I did not have this error occur on dev.

This might be due to a corrupt phenopacket that you had previously created on sqa (the old instance)
i would clear up all you phenopackets in sqa and then you could try once more to see if that happens on sqa

@belkassaby Logoff and login are working fine on both dev and sqa sites this morning. Problem is solved.


XAxis LabelCount is off by one

It looks like an issue in the implementation from #3 exists where the config for the LabelCount and the actual label count are off by one.  There is always one extra label printed than what is specifically configured.

This seems to only happen with the line_chart-2 example.  Smaller datasets behave correctly.

This behavior was looked at closer today.  In detail what's happening is a combination of the following:

The BoundaryGap behavior necessitates that an additional tick mark is made to center the label between.  This significantly complicates the tick logic, and is the source of why the additional label is rendered in this bug.
In addition in large / dense datasets the centering functionality is not correctly applied due to not factoring in the next tick index being likely invisible.  Fixing this without fixing the bullet above results in text collisions.

Although the first bullet has a non-trivial solution (or at least one not yet found), understanding this behavior better has allowed me to limit the exposure of this issue significantly.
In commit https://github.com/go-analyze/charts/commit/fdf474cdd55c7750d56c5b1587fbd22f8e83f5d4 the extra label behavior was limited to only when the BoundaryGap configuration is enabled.  In a following commit the default behavior of this configuration option was changed.  We already disabled at a certain threshold for the chart rendering, and now we also use the same threshold for disabling the axis centering.
The end result is that this issue is not likely to be hit unless you have a dense dataset and are manually enabling the BoundaryGap.  Under these conditions you will have an extra label rendered.  In addition, instead of the labels being centered between the ticks it will be centered below the tick (rather than aligned to the tick).
Aligned with tick:

BoundaryGap dense dataset:

With these changes I believe we are producing fairly nice looking graphs in all configurations.  The bug remains that dense datasets may render an extra label.  For that reason I am leaving this issue open for comment for now.  We may still want to reconsider how the BoundaryGap is configured and defaulted.


PYPE-753 maya extract review refactor

Changes:

Changed misleading name to extract_playblast
fps is taken from instance or context
Camera options are taken now from capture preset
rendering is forced to png instead of jpg

:warning: requires PR: pype-config now includes values previously hardcoded in plugin

requires PR: pype-config now includes values previously hardcoded in plugin

have you made the branch locally and forgot to push ;) ?

forgot to push to pype-config, fixed now.


FEAT-#2363: fix index name setter in OmniSci backend

What do these changes do?

[x] passes flake8 modin
[x] passes black --check modin
[x] signed commit with git commit -s
[ ] Resolves #?
[ ] tests added and passing

Codecov Report

Merging #1 into issue-2298 will decrease coverage by 9.58%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           issue-2298       #1      +/-   ##
==============================================
- Coverage       61.63%   52.05%   -9.59%
==============================================
  Files             112      112
  Lines           12760    12430     -330
==============================================
- Hits             7865     6470    -1395
- Misses           4895     5960    +1065

Impacted Files
Coverage Δ

.../experimental/engines/omnisci_on_ray/frame/data.py
0.00% <0.00%> (ø)

modin/engines/dask/task_wrapper.py
0.00% <0.00%> (-100.00%)
:arrow_down:

modin/engines/dask/pandas_on_dask/io.py
0.00% <0.00%> (-100.00%)
:arrow_down:

modin/engines/dask/pandas_on_dask/frame/data.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...ngines/dask/pandas_on_dask/frame/axis_partition.py
0.00% <0.00%> (-100.00%)
:arrow_down:

...din/engines/dask/pandas_on_dask/frame/partition.py
0.00% <0.00%> (-80.00%)
:arrow_down:

...nes/dask/pandas_on_dask/frame/partition_manager.py
0.00% <0.00%> (-58.83%)
:arrow_down:

modin/pandas/dataframe.py
39.93% <0.00%> (-48.45%)
:arrow_down:

modin/engines/base/frame/axis_partition.py
38.46% <0.00%> (-26.36%)
:arrow_down:

modin/data_management/utils.py
56.25% <0.00%> (-18.75%)
:arrow_down:

... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9709266...82edc35. Read the comment docs.


Add initial recovery interface

Add power interface and linux implementation.
Add recovery interface.

okay so no interface but at least public functions which can be used by different *boot implementations ?

One interface should stay - and then one concrete implementation of that interface that uses reboot as recovery method.
In terms of code we would have:
// interface that every concrete implementation has to implement
type Recoverer interface {
    Recover() error
}

// example recoverer that reboots
type RebootRecoverer struct {
    // whatever fields are necessary, e.g. `Sync`
}

func (rr RebootRecoverer) Recover() error {
    if rr.Sync {
        // flush stdout and stderr
    }
    if rr.Reboot {
        // do reboot
    } else {
        // do shutdown
    }
}

// then here we can have other implementations of a Recoverer. For example we may have something that logs what happened and keeps booting the machine instead of rebooting it. This is just an example and doesn't have to be implemented in this PR.
type PermissiveRecovere struct {
    // whatever fields
}

func (pr PermissiveRecoverer) Recover() error {
    // log what happened, maybe push metrics somewhere or "call home" to some endpoint
    // then continue booting and let the infra around it to deal with this host
}

Just one nit on logging, but this is good to merge


Invalid scratch slugs lead to ugly 404 pages

https://decomp.me/scratch/eYSpD (For example)

Surprised that app/error.tsx isn't triggered at this route - I could be misunderstanding the docs, or it could be a Next.js beta bug...
Hopefully placing an app/scratch/[slug]/error.tsx that reexports the aforementioned Error should fix it.

This is a Next.js bug! https://github.com/vercel/next.js/issues/45385
Looks like they've deprecated head.tsx in favour of exporting a metadata object from the page, will use that instead

Unblocked once #705 is merged


just corrected shebang

I use gomp.py (legacy) without alias, so:
alex@vosjod::~/bin $ ./gomp
-bash: ./gomp: usr/bin/env: bad interpreter: No such file or directory

alex@vosjod::~/bin $ vi gomp
alex@vosjod::~/bin $ ./gomp
usage: gomp [-h] [--key] [--recut] [src] dest
gomp: error: too few arguments

Thanks for the PR. Would it be possible to change in accordance with https://stackoverflow.com/questions/6908143/should-i-put-shebang-in-python-scripts-and-what-form-should-it-take/19305076#19305076
to use #!/usr/whatever python2 and #!/usr/whatever python3 as appropriate?
Also, could you please format the commit message as [PATCH] what this PR accomplishes

Also, could you please format the commit message as [PATCH] what this PR accomplishes

@philipkiely-markforged we should add a contributions guidelines if we're going to make asks like that :)

Done 😄


Handle sibling light client ids

The change introduced in https://github.com/unionlabs/union/pull/2676/files#diff-c892888648fbdbf0682e3fe59a8eb8496acd57d0ff106ddf4ab3eac0fe5b21fbR175-R180 is a placeholder until we correctly handle extra indirection lead by sibling clients.

replaced by state lens


Functions advanced

Closes #122

Thanks @yakutovicha for the thorough comments 😉 I addressed the quick ones with a commit from GitHub. I'll take care of the rest with a few more commits. I'll ask a final, quick review when done.


Gentelella set nav-sm on start

setting nav-sm on body for making sidebar take least real state on any layout , it works on desktop size, but for tablet it does not hide it like nav-md or on phone it does not hide it like nav-md used to. what is the best way to set side-bar menu to take least real state as possible for any screen size.

Hi there @justinhomes,
Can you please provide us some screenshots for a better understanding of what's bothering you there ?
Thanks !

This is what i want below: everything is as i expected except Desktop
Normal Desktop

Exapnded Desktop

Normal tablet

Expanded tablet

Normal Mobile

Expanded Mobile

Hi again @justinhomes ,
I see what you mean now, will try to find a solution for that sidebar on mobile :)
Regards,
Andrew.

Hi  @justinhomes,
Have you founded a solution?

@AndreiCN  Hi!
Have you founded a solution?
Thanks

@AndreiCN - This issue should be kept open until a solution is delivered.

Hi there @justinhomes , did you found a solution for your problem ?
@paulagoulartprados do you have exactly the same issue ?

Hi @AndreiCN , yes. We have the same issue.
Thanks

Ok, we'll provide a solution for it ASAP.

Hello,
Maybe I didn't understand correctly, but it seems this is more like a subjective issue that a general bug, based on your desire to to start with an unexpanded sidebar menu.


[docs] defaultLocale conflict when using root

Just left a quick suggested docs PR that would have addressed the problem I ran into so I don't forget! Adjust as necessary!

size-limit report 📦

Path
Size

/index.html
10.72 KB (-0.01% 🔽)

/_astro/*.js
15.96 KB (0%)

/_astro/*.css
8.87 KB (0%)


Python mismatch causes latest dds_cli executable to crash on Ubuntu Linux

Latest executable for Ubuntu Linux (dds_cli v2.2.5) generates a python-related error:
$ ./dds --version
[449478] Error loading Python lib '/tmp/_MEIl3sj2v/libpython3.9.so.1.0': dlopen: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.35' not found (required by /tmp/_MEIl3sj2v/libpython3.9.so.1.0)

Reason seems to be that some python library included(?) in the executable requires a specific version of libc (basically requiring python version 3.9), but the system has python 3.8 (and libc 2.3.1).
As far as I can see, the minimum python requirement for the executable is not documented in the README.md.

Python versions on the server:

$ python -V
Python 2.7.18
$ python3 -V
Python 3.8.10

OS: Ubuntu 20.04.5 LTS

Libc version: 2.3.1

Aha ok! Thanks, we'll have a look.

Hi again, have had a look now and unfortunately I cannot reproduce this. The executables are not suppose to have a specific python requirement, that should be built in. I have created a venv with Python 3.8 and downloaded v2.2.6 and v2.2.5, and both of them work.
Just checking something - did you rename the executable to ./dds?

Dear @i-oden ,
Yes, I did rename https://github.com/ScilifelabDataCentre/dds_cli/releases/download/v2.2.6/dds_cli_ubuntu_x86_64 to dds.
I took the time to try all previous ubuntu x86_64 executables and the code causing the error on the server was introduced at some point between v2.2.3 and v2.2.4. That is, versions prior to v2.2.3 works, but version 2.2.4 and after generates the same error message:
[575271] Error loading Python lib '/tmp/_MEI1oLUlo/libpython3.9.so.1.0': dlopen: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.35' not found (required by /tmp/_MEI1oLUlo/libpython3.9.so.1.0)

I couldn't find a description in the repository on how you build the executables, so I don't know where to start looking for clues. pyinstall may be one candidate, however.
My colleagues could download their data with the older versions, but I just thought I would give you a heads up in case someone else is sitting on an older server (without the sudo power to upgrade)...
Cheers
Johan

Thanks for looking into this!
The executables are generated in this action, here: https://github.com/ScilifelabDataCentre/dds_cli/blob/d769da3db1aa3a9edc8dde176c650e27f784079a/.github/workflows/release-cli.yml#L52
Yes, thanks for the heads up!

Just to dig deeper into the pyinstaller issue: the "one-file" executable built by pyinstaller will create an unpack files in a temporary directory (named "_MEI"), and then load necessary additional files from the file system. This will pose problems if using objects with dynamic dependencies. The installation procedure for dds specifies the explicit use of python 3.9, and apparently, this generates the error we saw.
I don't know how to work around this with pyinstaller, unless there is a way of statically build all of the dependencies of the bundle/executable. An alternative may be to tell users to use a minimum required python version (and perhaps all other versions that dds may be dependent on).
/Johan

Just making a note here: the issue is the change of ubuntu-latest from ubuntu-20.04 to ubuntu-22.04 in the Github Actions workflows.
Adding another binary for ubuntu-20.04 in the matrix should solve it.

Fixing as we speak. Will post here when there's an executable for 20.04 to try.

@nylander There's a new executable now, for Ubuntu 20.04: https://github.com/ScilifelabDataCentre/dds_cli/releases/tag/v2.2.62
Try it out and let us know if it works now? 🙏🏻

Going to close this now as solved, but let us know if this is not the case! Thanks for reporting the issue


Flex Delegate bazel build for C api

Hi, A bit unsure as to what category this would fall under so Iv chosen miscellaneous.
There is no documentation regarding the usage of flex delegates for the C api
I have tried the command
bazel build --config=android_arm64 --config=monolithic --cxxopt=--std=c++11 --define=with_select_tf_ops=true -c opt //tensorflow/lite/c:libtensorflowlite_c.so //tensorflow/lite/delegates/flex:delegate
however it fails, i can provide the logs if required.
What are the ways to go about building a libtensorflowlite_c.so file that support flex delegates for android?
Thank you

@henry8th
Can you please refer to this link and let us know.

Hi thanks for getting back to me It includes details for all supported
languages bar C,
The c++ option doesn't work for me.
I have opted to use other languages as opposed to forcing it with C
Many thanks
On Tue, 16 Feb 2021, 08:10 Saduf2019<EMAIL_ADDRESS>wrote:

@henry8th https://github.com/henry8th
Can you please refer to this link
https://www.tensorflow.org/lite/guide/ops_select and let us know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/47120#issuecomment-779662393,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AP52P6YWJNJUX4WUAJH4V6LS7IR7TANCNFSM4XRGBCAA
.

@thaink don't we have a way to build flex via C api ? (at least via selective build?)

@terryheo @henry8th The //tensorflow/lite/delegates/flex:delegate rule is not intended to build standalone .so file for flex delegate.
Can you try adding following line to //tensorflow/lite/delegates/flex/BUILD:
load("//tensorflow/lite:build_def.bzl", "tflite_cc_shared_object")

tflite_cc_shared_object(
    name = "tensorflowlite-select-tf-ops",
    features = ["windows_export_all_symbols"],
    linkopts = select({
        "//tensorflow:macos": [
            "-Wl,-exported_symbols_list,$(location //tensorflow/lite:tflite_exported_symbols.lds)",
        ],
        "//tensorflow:windows": [],
        "//conditions:default": [
            "-Wl,-z,defs",
            "-Wl,--version-script,$(location //tensorflow/lite:tflite_version_script.lds)",
        ],
    }),
    per_os_targets = True,
    deps = [
        ":delegate",
        "//tensorflow/lite:tflite_exported_symbols.lds",
        "//tensorflow/lite:tflite_version_script.lds",
    ],
)

The build it with --nocheck_visibility and try it.

How to use the libtensorflowlite_flex.so in my project built with cmake