Challenge Pull Request

@OykuMelikoglu It looks like you are trying to submit B1, however it seems like the following submission criteria are problematic:

Logs are missing

confirmed:ID1
account1:3FBb7UXwhvJCvA4WP8ktexuppBJzKLhJFZKVCvveNxwxy4Thtt
account2:3oY3mwdUvMa8b5Ka2jXfNixckL2uPjEfRXzKeDz6g75SaJwR7S

rejected:B1
It looks like you are trying to submit B1, however it seems like the following submission criteria are problematic:

Logs are missing
We’ve thus marked B1 as rejected, however if this is a mistake, please upload the log summary and we can re-review.

rejected:B1
It looks like you are trying to submit B1, however it seems like the following submission criteria are problematic:

Logs are missing
We’ve thus marked B1 as rejected, however if this is a mistake, please upload the log summary and we can re-review.

confirmed:ID2
account1:3b5zohMRQy52cUfod7WTkDmapJJm2JB3FhMq9MsN1gwHT9DNaB
account2:36hocuya7Sb7j81hJGHjPeK1zBE2c9AUnD34sgKvpK5v3TLxbt
PublicDataAttributes:Verified
DeviceMake&Model:Verified

confirmed:ID3
DocumentType:verified
Nationality:verified
DeviceDetails:verified
Experience:verified
Screenshot:verified

confirmed:ID3
DocumentType:verified
Nationality:verified
DeviceDetails:verified
Experience:verified
Screenshot:verified

confirmed:ID4
AccountAddress:3b5zohMRQy52cUfod7WTkDmapJJm2JB3FhMq9MsN1gwHT9DNaB
DeviceDetails:verified

confirmed:ID4
AccountAddress:3b5zohMRQy52cUfod7WTkDmapJJm2JB3FhMq9MsN1gwHT9DNaB
DeviceDetails:verified

confirmed:B4
address:3b5zohMRQy52cUfod7WTkDmapJJm2JB3FhMq9MsN1gwHT9DNaB
baker:745

confirmed:B4
address:3b5zohMRQy52cUfod7WTkDmapJJm2JB3FhMq9MsN1gwHT9DNaB
baker:745

Form Submitted.
Friday 29.04.22 12:20 GMT +3


add support for MERGE statement

This PR adds support for MERGE statement based on the Snowflake syntax:
https://docs.snowflake.com/en/sql-reference/sql/merge.html
but should work with Hive based one neverthless.
https://cwiki.apache.org/confluence/display/hive/languagemanual+dml#LanguageManualDML-Merge
Signed-off-by: Maciej Obuchowski<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

157 of 184 (85.33%)  changed or added relevant lines in 3 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.06%) to 90.484%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/ast/mod.rs
23
36
63.89%

src/parser.rs
44
58
75.86%

Files with Coverage Reduction
New Missed Lines
%

src/ast/mod.rs
5
77.36%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
7341

Relevant Lines:
8113

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

166 of 196 (84.69%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 90.312%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/ast/mod.rs
31
42
73.81%

src/parser.rs
46
65
70.77%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
7439

Relevant Lines:
8237

💛  - Coveralls


Rework the JDBC TCK

This do the following:

merge the method testRegisteredProperties / testMinimumOneDataSourceFactory as it is not compliant to only test there is one valid DSF but all need to implement all required properties
check that the description (if given) is a string property
check that the capability is either a string or a String[] type
join the individual testCapabilityX into one method as actually one needs to check all declared capabilities of one source fulfills the overall contract of at least provide one.

Fix https://github.com/osgi/osgi/issues/529
Fix https://github.com/osgi/osgi/issues/530
@bjhargrave @stbischof please have a look. This should now be consistent to the spec and could test any number of DSF registered.
Additionally this now also check that a DSF at least implements one of the valid values (in contrast to before where it was only checked that one DSF declares any value) and also checks that the property if of the desired type String+

I have now applied the suggested changes.

Thanks for this PR!

Thx @laeubi good job


Add editor icons for VisualScript and VisualShader expression resources

Follow-up to https://github.com/godotengine/godot/pull/51702.
Preview

Thanks!


Bug: gruvbox theme

I have been using lightline and https://github.com/shinchu/lightline-gruvbox.vim
The grey background for normal mode in lualine looks like its faded/disabled. This might just be me though. Can I change individual colors on the colortheme for lualine from my lua config?

Yes you can check out customizing themes
Also make sure you have true color support enabled (termguicolors)

Ah I didn't see that fold. Thanks

I tried setting a different bg color, but getting a green line in between the section and the seperator.
theme.normal.a.bg = "#b8bb26"

Actually thats there with any color. I've tried different fonts too..

I'll close this and create a issue for that instead.


RePack with rn_nodeify

Hi, I've been trying to add rn_nodeify library available in my rePack project but it's not working
What rn_nodeify does:
It provides your react-native project with core nodeJs modules
How it works:
It recurses down node_modules and modifies all the package.json's in node_modules to add/update the browser and react-native entry fields and it does it in the post-install script when yarn is ran
In my case I need only the crypto library, so I installed certain core node_modules
Adding rn_nodeify
After adding rn_nodeify adds this library, I stated only what I needed  in my postinstall script -
  "postinstall": "./node_modules/.bin/rn-nodeify --hack --install crypto,stream,process,events,vm-browserify",
yielding the below

By default, it maps all these modules to the browser and react-native fields, In my case

It also adds shim.js to the root of the project which is in turn imported in the entry point of the project, index.js
Shim.js populates some necessary nodeJs module
if (typeof __filename === 'undefined') global.__filename = '';
if (typeof process === 'undefined') {
  global.process = require('process');
} else {
  const bProcess = require('process');
  for (var p in bProcess) {
    if (!(p in process)) {
      process[p] = bProcess[p];
    }
  }
}

process.browser = false;
if (typeof Buffer === 'undefined') global.Buffer = require('buffer').Buffer;

// global.location = global.location || { port: 80 }
const isDev = typeof __DEV__ === 'boolean' && __DEV__;
process.env['NODE_ENV'] = isDev ? 'development' : 'production';
if (typeof localStorage !== 'undefined') {
  localStorage.debug = isDev ? '*' : '';
}

Installation Aftermath
After all the above steps, it works perfectly with metro but with repack, fistly I had to edit webpack config cuz I got an invariant cannot be resolved in all the modules, react native included

After adding this, that error was resolved

Latly, in the shim.js, I cannot log the process library but I can log its typeof which is an object (I can do both with metro)
Also I removed this -
process.env['NODE_ENV'] = isDev ? 'development' : 'production'
because I was getting lefthand side assignment error probably because process.env['NODE_ENV'] was likely undefined
Everything works fine with metro but not repack, please any suggestion on what I can I do. Thanks
I also tried everything under this issue to no avail - Issue 296

This is a reproducible repo for the rn_nodeify implementation with =>

A freshly install of react native  v 0.72.5
rn_nodeify installed with a post install script to install only the nodeJs modules needed
and encryption and decryption code with its use

https://github.com/vlack-coder/nodifypack

Hi @vlack-coder,
I'll take a look at this when I have some spare time, since it's using rn_nodeify it's a very low priority.
May I ask what do you need it for?


fix encoding signatures

something is wrong, this isn't the version I pushed.  closing

again, there is a bug in github PRs, had to bypass.


Unable to upload files using Testcafe in headless browser due to difference in behaviour with normal browser run.

What is your Scenario?
We have a Test cafe test that tries to upload a file using the setFilesToUpload method. The test works fine when run in normal chrome browser, but the test fails in headless browser mode.
What is the Current behavior?
Based on our investigations it looks like the cancel event is triggered first in the headless browser mode while in the normal mode the cancel event is not triggered.
What is the Expected behavior?
File upload behaves the same in normal vs Headless browser execution.
What is the public URL of the test page? (attach your complete example)
Created a sample app to reproduce the issue we are facing. The app is accessible at https://jsfiddle.net/dreadlord2203/e7qrgtzc/
On click of the upload button two event handlers are registered (cancelHandler and changeHandler), when either of the events is triggered we remove the event listeners and process the received event.
For the example we are logging a message when the handler is called.
What is your TestCafe test code?
import { Selector, t } from 'testcafe';

fixture('Example File Upload').beforeEach(async () => {
  await t.navigateTo('https://jsfiddle.net/dreadlord2203/e7qrgtzc/');
});

const dataFilesPath = `${process.cwd()}/e2e/src/data/files`;
const uploadButton = Selector('#uploadButton', { timeout: 60000 });
const uploadInput = Selector('#myFile', { timeout: 60000 });
const filePath = `${dataFilesPath}/allTypes.csv`;
const consoleElement = Selector('#console', { timeout: 60000 });
test('Js Fiddle file upload', async () => {
  await t.click(consoleElement);
  await t.switchToIframe(Selector('main [name="result"]', { timeout: 60000 }));
  const uploadButtonElement = await uploadButton();
  await t.click(uploadButton);
  await t.setFilesToUpload(uploadInput, filePath);
  await t.switchToMainWindow();
  await t.wait(10000);
  await t.takeScreenshot('FileUploadErrorTest/image.png');
});

Your complete configuration file
{
"color": true,
"compilerOptions": {
"typescript": {
"configPath": "e2e/tsconfig.json",
"customCompilerModulePath": "../typescript"
}
},
"pageLoadTimeout": 5000,
"appInitDelay": 3000,
"browserInitTimeout": 60000,
"selectorTimeout": 5000,
"assertionTimeout": 5000,
"testExecutionTimeout": 600000,
"runExecutionTimeout": 10800000,
"speed": 1,
"screenshots": {
"path": "e2e/artifacts/screenshots",
"takeOnFails": true,
"pathPattern": "${FIXTURE}/${TEST}-${DATE}-${TIME}.png"
},
"videoPath": "e2e/artifacts/videos",
"videoOptions": {
"singleFile": false,
"failedOnly": false,
"pathPattern": "${FIXTURE}/${TEST}-${DATE}-${TIME}.mp4"
},
"disablePageCaching": true
}
Running with Native Automation enabled
Your complete test report
No response
Screenshots
Screenshot1 - In normal browser mode

The console shows that the change event was triggered and value was set properly.
Screenshot 2 - In chrome headless mode

The console shows that the cancel event was triggered, and due to that the change handler is never called.
Steps to Reproduce
Run the above test code against the example URL.
TestCafe version
"testcafe": "3.3.0"
Node.js version
v18.18.2
Command-line arguments
-r spec -r html:report.html  -b=chrome and for headless -b=chrome --headless
Browser name(s) and version(s)
No response
Platform(s) and version(s)
No response
Other
No response

Duplicate #8082


Azure Network Security Group Analytics retirement

My customer has Azure Network Security Group Analytics already installed and is wondering if there is an estimated schedule for complete retirement.
Also, will the Service administrator receive email as notification when this happens?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4c04951f-ef92-c32f-50b7-ee33119531cf
Version Independent ID: e0003350-d744-6c2e-efb5-9e83b3549612
Content: OMS portal moving to Azure
Content Source: articles/log-analytics/log-analytics-oms-portal-transition.md
Service: log-analytics
GitHub Login: @bwren
Microsoft Alias: bwren

@v-maroge Thanks for the feedback! We are currently investigating and will update you shortly.

I don't have a date when it won't be available in the marketplace anymore, but that doesn't affect it's functionality.  As described in https://docs.microsoft.com/en-us/azure/log-analytics/log-analytics-azure-networking-analytics#azure-network-security-group-analytics-solution-in-log-analytics It's been moved to community support and will continue to function.

@bwren So does that mean "Customers who have already installed the solution can continue to use it until further notice." is no longer accurate?

There are no current plans from the engineering team to stop that solution from being used, and I suspect that it will work indefinitely.  That being said, there's no guarantee of that, and the recommendation is to eventually move to Traffic Analytics.  We haven't been given any guidance beyond that.


Ringtone permissions

Fatal Exception: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.liveultrahealthy.violet/com.liveultrahealthy.violet.ui.settings.SettingsActivity}: java.lang.SecurityException: Permission Denial: reading com.android.providers.media.MediaProvider uri content://media/external/audio/media/50 from pid=19062, uid=10187 requires android.permission.READ_EXTERNAL_STORAGE, or grantUriPermission()
       at android.os.Parcel.readException(Parcel.java:1546)
       at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:185)
       at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:137)
       at android.content.ContentProviderProxy.query(ContentProviderNative.java:421)
       at android.content.ContentResolver.query(ContentResolver.java:513)
       at android.content.ContentResolver.query(ContentResolver.java:448)
       at com.lge.media.RingtoneManagerEx.getActualDefaultRingtoneUri(RingtoneManagerEx.java:244)
       at android.media.RingtoneEx.getTitle(RingtoneEx.java:177)
       at android.media.RingtoneEx.getTitle(RingtoneEx.java:145)
       at com.liveultrahealthy.violet.ui.settings.SettingsFragment$1.onPreferenceChange(SettingsFragment.java:65)
       at com.liveultrahealthy.violet.ui.settings.SettingsFragment.bindPreferenceSummaryToValue(SettingsFragment.java:80)
       at com.liveultrahealthy.violet.ui.settings.SettingsFragment.onCreatePreferences2(SettingsFragment.java:152)
       at android.support.v7.preference.XpPreferenceFragment.onCreatePreferences(XpPreferenceFragment.java:53)
       at android.support.v7.preference.PreferenceFragmentCompat.onCreate(PreferenceFragmentCompat.java:216)
       at com.liveultrahealthy.violet.ui.settings.SettingsFragment.onCreate(SettingsFragment.java:102)
...

Device: LG H634
Android 5.1.1

Do we have any workaround for this?
Lately I see more and more crashing sessions because of this issue.

Yeah, me too, just about yesterday I grew tired of it and just wrapped the Ringtone.getTitle call in try-catch and just set the summary to "???" if it fails.
Here's what I found out:

This will happen when the user has a default ringtone from external storage and the app is not granted the READ_EXTERNAL_STORAGE permission. Those are apps that do not specify it in their manifest below API 23 and apps over API 23 that have not been granted the runtime permission.
For devices with API <23 just request the permission in manifest. It will solve you a lot of headaches, not just this one. For example Samsung Gallery doesn't grant you URI permissions when obtaining images, so you have to rely on the manifest permission anyway to actually read the image.
On API 23+ there are two cases:
a) The user has granted you READ_EXTERNAL_STORAGE permission, set a ringtone from external storage and then revoked the permission. You can work around this one by also saving the ringtone title when it's picked.
b) The user hasn't granted you the runtime permission yet so you have no means of getting the ringtone title. And you don't want to flash the Permission dialog for no apparent reason.

In my case I have READ_EXTERNAL_STORAGE in manifest, so it's fine on older APIs.
I don't do anything with ringtones until the user picks one with RingtonePreference.
Based on what you describe I should maybe try to get the title of the default ringtone with
RingtoneManager.getRingtone(context, RingtoneManager.getDefaultUri(RingtoneManager.TYPE_RINGTONE)).getTitle(context);

in a try-catch before XpRingtonePreferenceDialogFragment is shown and if the exception is thrown the permission should be asked for, correct?

The ringtone picker only lists ringtones from external storage if the permission is already granted. There's no problem there.
The problem is that RingtoneManager.getDefaultUri(RingtoneManager.TYPE_RINGTONE)) may be located on external storage. getTitle would then throw.
I don't think it's good practice to open the permission dialog automatically when the user opens the settings. Maybe ask for the permission before opening the ringtone picker. But that still involves having the "???" or some other placeholder string when the permission is not granted upon first entry.
I'm afraid I have no best answer.

The ringtone picker only lists ringtones from external storage if the permission is already granted. There's no problem there.

There must be as this is where my app crashes. I don't do anything with ringtones, I only let the user select one with RingtonePreference
java.lang.SecurityException: Permission Denial: reading com.android.providers.media.MediaProvider uri content://media/external/audio/media from pid=, uid= requires android.permission.READ_EXTERNAL_STORAGE, or grantUriPermission()
    at android.os.Parcel.readException (Parcel.java:1620)
    at android.database.DatabaseUtils.readExceptionFromParcel (DatabaseUtils.java:183)
    at android.database.DatabaseUtils.readExceptionFromParcel (DatabaseUtils.java:135)
    at android.content.ContentProviderProxy.query (ContentProviderNative.java:421)
    at android.content.ContentResolver.query (ContentResolver.java:493)
    at android.content.ContentResolver.query (ContentResolver.java:435)
    at android.media.RingtoneManager.getUriFromPath (RingtoneManager.java:951)
    at android.media.RingtoneManager.getActualDefaultRingtoneUri (RingtoneManager.java:755)
    at android.media.RingtoneManager.getRingtone (RingtoneManager.java:1163)
    at android.media.RingtoneManager.getRingtone (RingtoneManager.java:688)
    at net.xpece.android.support.preference.x.run (XpRingtonePreferenceDialogFragment.java:410)
    at android.os.Handler.handleCallback (Handler.java:739)
    at android.os.Handler.dispatchMessage (Handler.java:95)
    at android.os.Looper.loop (Looper.java:148)
    at android.app.ActivityThread.main (ActivityThread.java:5418)
    at java.lang.reflect.Method.invoke (Native Method)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:726)
    at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:616)

Oh crap, you're right, the picker crashes when trying to play the default ringtone from external storage.
I'll make it go quiet by default but I'll try to provide a pluggable listener so you can open permissions dialog when that happens.

I thought we were talking about the same, but I'm glad that the stacktrace helped to identify the issue.
So until you prepare a new release I guess we can use the method I described in the previous post (checking if exception is shown when trying to get title before actually showing the picker).

@dirkam Please update to 1.3.1. There was a NullPointerException possibility in 1.3.0.


Add documentation and script to update the nuclides.dat file data

On the review of https://github.com/terrapower/armi/pull/998 there was a request to create more detailed documentation on how the data for nuclides.dat was acquired and to provide a script that accesses the RIPL-3 library data and the IAEA chart of the nuclides API to more readily allow a future developer to update these the nuclides in the framework. This is a great request, but would take more time to close out that PR. This issue is related to completing that documentation of the process.

@jakehader  This ticket is still assigned to you.  That's cool with me, but if you aren't planning on working on it, please un-assign it.
(You are not being singled out, I am going through all the ARMI tickets.)

Thanks @john-science for the call out! Sounds like a fun weekend activity 😁

Hi, guys! This is my very first contact with ARMI community. I hope in the long run to prove helpful in this oustanding and incredibly interesting project, still, I'm aware that my first steps can be painful and should be taken with care...
Anyway, I hope you wouldn't mind if I took a try at this issue. In fact I've already started some implementation efforts but at the moment I'm facing two questions that are beyond my current rather limited knowledge in nuclear engineering area in general, and ARMI in particular. I plan to provide a  Python module with a bunch of classes responsible for gathering and processing external data, and then creating/updating nuclides.dat file. Before I submit PR I'd like to make sure it is of decent completness and quality. Thus, the aforementioned questions:

A considerable number of entries in nuclides.dat is missing from RIPL3 mass-related data files, 13Li being the first, and 20B, 21B or 11O among others. How can one define the "AMRI full set of nuclides"? What is the source data for such a "full set"?  I hope it won't turn out to be a chicken and egg situation ;-) because among other features I'd like the new module to provide the functionality of creating nuclides.dat from scratch which means I need some way of determining initial "AMRI full set of nuclides" (possibly also providing some comfortable way for modifying such "init set").
Furthermore, when there is no external mass excess data avaliable how should one find nuclide's amu mass (for 13Li, 20B, etc.)? Quick inspection of RIPL3 materials led me for instance to Duflo-Zuker mass formula. Is that the way to go? If so, futrther questions are bound to arise, I'm afraid, but at least the direction is set for me.

If you consider taking a look at my first implementation worth your time, please let me know. I can already open PR in its current state - a bit dirty and definitely incomplete, albeit functional and accompanied with tests. But of course I'm not going to do that without some kind of upfront invitation on your part as it still cannot be consider ready in terms of Standards and Practises.

Hi @gorbion , thanks for your questions and your interest in contributing.
I think you might have picked quite a thorny issue to start your ARMI experience with :-) As you've noted, there are a few ambiguous questions with this one. @jakehader would be the one to answer those questions, since he put together the nuclides.dat file.
Speaking frankly, unless @jakehader has some pointers for you, unfortunately I think that this might not be the best issue for a newcomer. If you are interested in contributing to ARMI in other ways, I'd recommend that you take a look at our issues and make a comment on any of them before you begin working to see if it would be suitable. That way you don't get too far before getting stuck in a quagmire.

Hi @keckler, thank you for the response! I guess I fully understand your scepticism about whether I'm the right person to get involved into the task - especially as the first assignment ever... Still, I firmly believe the only way to truly gain experience in something is to get one's hands dirty. The dirtier, the better ;-) (not beyond common sense, of course). And I have tried to do exactly that. Moreover, as I understand nuclides' data lies at the very bottom of what we're dealing with here. As such, its reliability and up-to-dateness is crucial, and automation of external data retrieval and processing seems to be the only simple way to guarantee just that. Basically that's the motivation behind my dedication to this issue.
Now, apart from questions to be asked I also do have some results. Please find attached:

The updated nuclides.dat file (I had to add superfluous .txt extension to satisfy GitHub upload rules) that has been generated by the current version of my module (full automation, all resources downloaded on-the-fly). Having no clue as for how to deal with "missing data for some nuclides" (I've recently asked about that) I decided to introduce the mode in which entries for which there is no external data are simply left intact. Such are the contents of the attached file. Diff it against current ARMI nuclides.dat to get the full picture.
diff_summary.txt file that contains simplified, "tabulated" summary of the differences betwen the old and the new nuclides.dat (I've used ARMI's tabulate utility - it's such a canny tool!).

I've double checked decent amount of those differences and I believe all ground state related data is correctly updated in full accordance with current state of external sources. At the same time excited/metastable states data is a different story. As you might imagine, I've had some really hard time trying to identify the rules governing extraction of those states from RIPL-3 Discrete Levels and Decay Data library files. I believe the output now seems reasonably reliable, nevertheless thorough expert-level review is needed. No doubt about that.
@jakehader, I would greatly appreciate if you took a look at what has already been said and at the provided material in order to decided whether it all looks like a decent half-product worth "final brush strokes" or I should indeed give it up, and look for some more-novice-friendly taks(s).
nuclides.dat.txt
diff_summary.txt

Hi @gorbion - here is the original RIPL-3 reader / parser that was removed when the nuclide data was updated. While RIPL-3, is a good source for nuclide data, I did notice various inconsistencies across RIPL-3, ENDF-B/V-II.1, TENDL, and other sources that leverage ENDF data for visualization (e.g., chart of nuclides from the IAEA JANIS app, nndc).
Some of the hopefully nearer term vision for ARMI is to remove the global nuclides state from the system (#473) and to allow users within the application or for their specific use case to configure nuclide data from sources that they wish to use as opposed to enforcing it through a single and difficult to interpret text file (nuclides.dat).
I think for this clean up effort, there is a lack of documentation for how I obtained the data now in nuclides.dat, but an audit of the data would be very valuable  (#1085).
First, welcome and thank you for reaching out to help! I think there are many attempts at nuclide definitions out there on various nuclear engineering GitHub projects but if you'd like to catalog different resources available and perform some comparisons independently that may help users in the future decide which library they'd like to use. Additionally, ARMI could even provide a nuclide starter kit for single sources (e.g., pure RIPL-3, pure ENDF, pure TENDL, etc.). Right now nuclides.dat is an amalgamation of sources where if at least 2 sources agreed on a value that value was taken as "truth". The metastable state and more obscure nuclides are the ones that likely have the most uncertainty and therefore likely vary the most between sources. Documenting the "confidence" in this data could also be pretty important. Most reactor design calculations rely on a few key nuclides, including fission products, so having large uncertainties or low confidence could be deemed acceptable for some applications / use cases, but not all applications / use cases are the same and it should be left up to the end user to determine if the defaults provided by ARMI are truly acceptable.
These are some of my thoughts on this, but since it looks like you're excited to get into it, feel free to post some ideas of where you'd like to start and I'm happy to provide more pointers towards different sources.

Hi, guys! This is my very first contact with ARMI community. I hope in the long run to prove helpful in this oustanding and incredibly interesting project, still, I'm aware that my first steps can be painful and should be taken with care...
Anyway, I hope you wouldn't mind if I took a try at this issue. In fact I've already started some implementation efforts but at the moment I'm facing two questions that are beyond my current rather limited knowledge in nuclear engineering area in general, and ARMI in particular. I plan to provide a Python module with a bunch of classes responsible for gathering and processing external data, and then creating/updating nuclides.dat file. Before I submit PR I'd like to make sure it is of decent completness and quality. Thus, the aforementioned questions:

A considerable number of entries in nuclides.dat is missing from RIPL3 mass-related data files, 13Li being the first, and 20B, 21B or 11O among others. How can one define the "AMRI full set of nuclides"? What is the source data for such a "full set"?  I hope it won't turn out to be a chicken and egg situation ;-) because among other features I'd like the new module to provide the functionality of creating nuclides.dat from scratch which means I need some way of determining initial "AMRI full set of nuclides" (possibly also providing some comfortable way for modifying such "init set").
Furthermore, when there is no external mass excess data avaliable how should one find nuclide's amu mass (for 13Li, 20B, etc.)? Quick inspection of RIPL3 materials led me for instance to Duflo-Zuker mass formula. Is that the way to go? If so, futrther questions are bound to arise, I'm afraid, but at least the direction is set for me.

If you consider taking a look at my first implementation worth your time, please let me know. I can already open PR in its current state - a bit dirty and definitely incomplete, albeit functional and accompanied with tests. But of course I'm not going to do that without some kind of upfront invitation on your part as it still cannot be consider ready in terms of Standards and Practises.

@gorbion - The full set of nuclides in ARMI is definitely an ambiguous definition. My previous comment mentions use cases, so in this case the set available aligns with our use cases. For instance, we care very little about B-20 since it is very far from the island of stability, it does not exist in typical nuclear reactor applications since transmutation or decay to B-20 would be extremely rare or unquantifiable.
I like your idea of exposing data parsers / readers or having them available for the community (see above about global nuclides), but I'm not exactly sure the best way to maintain them. Out of curiosity, are you working with ARMI to make an app where any differences you noticed are important?

@jakehader Thanks for your inavaluable feedback! It turns out my orignal viepoint was seriously limited. I took for granted that there exists something like "ARMI full set of nuclides". As if there could exist such thing as "ARMI-centric nuclides model"... Obviously now I understand there can't, rightly so. Let me rephrase basic idea. ARMI can (even should) provide some standardized "models" in this regard (e.g. RIPL-based, ENDF-based, etc.) but in general the user should be free to (re)define their own "model" that drives their needs. I thought that the current nuclide model's "global" characteristics had been introduced "by design". I only now see it's just the other way round - globality has to be get rid of. ASAP. Hope I get it all right now.
Anyway, while "digging" around #1013 I somehow missed #473 and problems referenced therein. I'd love to help here, however I'm not sure if I can be productive enough right away (without prior experience in ARMI). One thing is to manage and serve the models in efficient/convinient way but another is to get and prepare (pre-process?) reliable models in the first place. So instead how about if I made an attempt at preparing some generalized abstract nuclides model along with, say, three first implementations, namely "legacy ARMI", "pure RIPL-3", and "pure ENDF"? Standardized interface, specialized create/refresh procedures, etc. For the time being I have no idea how to deal with "certainty metrics" or "error levels" or whatever we call among-models inconsistencies in the long run. Some issues undoubtedly up for discussion/decision, I definitely need guidance here but I believe this is almost exactly what you've had in mind in your comments. And I could start practically right away.
Furthermore, such models could potentially be directly utilized by means of some strategy design pattern to dynamically load on-the-fly in ARMI applications' local scope. Full, flexible customization by end users is another, more complcated story but at least we're taking it into account from the very beginning. Along the way I should also take care of #1085 (at least to some extent as my current limited level of expertise in nuclear engineering nitty-gritty details and unevitable traps can surely become evident...)
Ideally, after I finish what is described above, you can directly use the abstract nuclides model and its first implementations in #473. Alternatively, if by that time #473 will already have its own model in place, I should at least be able to quickly make necesary adaptations (I definitely opt for preparing some flexible, loosely-coupled components) in order to provide #473 with ready-to-use model incarnations.
What do you think? If all seems reasonable (or even needs some serious refinement but otherwise makes perfect sense) I'd love to confirm the details of the first steps. And get going :-)


Prep for registering ClimaAtmos

This PR preps for a new release. I've changed the names of the CompatHelper and TagBot files, to match what is suggested in the julia docs, and I've added the authors entry to the Project toml.

bors r+


There should/will be a feedback channel about relevancy and usefulness of information in the knowledge base (content).

From @czdiana2321 on June 15, 2018 17:34
Copied from original issue: Microsoft/Access2Justice#155

Is this a valid requirement? @breeglej @grawdon

This is probably a Carlos question. I'm assuming they'll want something like this for their evaluation of the usefulness of the system and the states would want it to help see what content might need to be revised.

Agree.  This needs to be something the evaluation team prescribes if necessary.


UpdateViewHook should not add extra groups to a view

If a user just requests edge1 then the UpdateViewHook should not add edge2 as well. Otherwise the user would end up getting back things they didn't ask for.

Merged into develop.


TS2307: Cannot find module 'moment'.

I m having issue with importing moment in to my angular 8 project.
Angular version = 8.3.26
Type script version = 3.6.2
moment version = 2.25.0
i'm getting error TS2307: Cannot find module 'moment'. and i have used
import moment from 'moment'; .
i have add "moduleResolution": "node" and "allowSyntheticDefaultImports": true, in tsConfig
can any one help on this

try version 2.24, my tests started to fail on new version but fine with previous

try version 2.24, my tests started to fail on new version but fine with previous

I have tried. but same error came.

what does the line for moment in package.json look like?

its working with 2.24.0  may be deployment error in 2.25.0
Please deploy the new version with fix.

if you use yarn, add  resolutions block to package.json to override versions of sub-dependency, it work for me
  "resolutions": {
    "moment": "2.24.0"
  }

Seems that Typescript module resolution can't find moment. Using a relative path works ./node_modules/moment/moment. @codebrent Thanks, it's now working with 2.24.0 version.

In 2.25 this has been added to package.json.  But if I understand no corresponding location exists for the typedef file. Perhaps this broke the typings?
"typesVersions": {
    ">=3.1": {
      "*": [
        "ts3.1-typings/*"
      ]
    }
  },

its working with 2.24.0 may be deployment error in 2.25.0
Please deploy the new version with fix.

No its not working for me

what does the line for moment in package.json look like?

"moment": "^2.25.0",

All moment imports returning error

what does the line for moment in package.json look like?

try changing to "moment": "2.24.0", make sure that there isn't a ^ in it. delete node_models and re npm install. also if you have package-lock.json you may need to delete it. Otherwise npm will keep installing 2.25

I'm seeing the same issue, and according to the Dependabot Compatibility score for moment, I'm not the only one.
Downgrading to 2.24.0 may be a a work-around, but it effectively prevents at least some users from using 2.25.0.

try changing to "moment": "2.24.0", make sure that there isn't a ^ in it. delete node_models and re npm install. also if you have package-lock.json you may need to delete it. Otherwise npm will keep installing 2.25

The safer, canonical way to do this is simply npm install<EMAIL_ADDRESS>You do not need to delete anything or change anything manually.
I can confirm that downgrading to 2.24 fixes the issue.

In locally its running after down grade to  . but when i deploy this to Azure to its giving same error.

My question is if it is same package.json running both local and azure.

try changing to "moment": "2.24.0", make sure that there isn't a ^ in it. delete node_models and re npm install. also if you have package-lock.json you may need to delete it. Otherwise npm will keep installing 2.25

The safer, canonical way to do this is simply npm install<EMAIL_ADDRESS>You do not need to delete anything or change anything manually.
I can confirm that downgrading to 2.24 fixes the issue.

In locally its running after down grade to 2.24.0 . but when i deploy this to Azure to its giving same error.

My question is if it is same package.json running both local and azure.  i have attached error log in server

I can confirm 2.25.0 give this issue but not at 2.24.0.

I also confirm that 2.25.0 give this issue. Moment 2.24.0 works fine.
I experienced this problem during docker image build.

its not working with 2.24.0 for me

Downgrading fixed the issue here too. Maybe the TypeScript version may play a role in having the bug or not?

I use moment-timezone
Its not working with fixing moment version to 2.24.0 in package.json

its not working with 2.24.0

you probably did not downgrade to 2.24.0. Remove your package-lock file and node_modules folder, then run this command :

npm install --save --save-exact<EMAIL_ADDRESS>npm install

I'm also experiencing the same issue in a typescript project and the build is failing all of a sudden because we didn't pin the dependency in package.json.
error TS2307: Cannot find module 'moment'.
error Command failed with exit code 2.

pinning the version to "2.24.0" fixes the issue.

Can try with resolutions field in package.json
Add

"resolutions": {
"moment": "2.24.0"
}

I also confirm that with 2.25.0 I have the same issue with typescript 3.8.3 and running with ts-node 8.9.1. Downgrading to 2.24.0 solved the problem.

@zhuyuedlut @leafqi

its not working with 2.24.0

you probably did not downgrade to 2.24.0. Remove your package-lock file and node_modules folder, then run this command :

npm install --save --save-exact<EMAIL_ADDRESS>npm install

thx. my problem has been solved. its working with 2.24.0
correct usage
"moment": "2.24.0"
wrong usage
 "moment": "^2.24.0"

"moment": "2.24.0" is working for me also..

Same, locking in 2.24.0 fixed it.
This is on an angular 7.2 app built with webpack ^4.2.0

Yes,  2.24.0 is working fine. Does anyone know what is the change they've made?

Same, issue got fixed by setting fixed version to "2.24" instead of "^2.24"

Do we have an ETA for this fix?
It's Friday and I am wondering if I should downgrade to 2.24.0 before the weekend.

try changing to "moment": "2.24.0", make sure that there isn't a ^ in it. delete node_models and re npm install. also if you have package-lock.json you may need to delete it. Otherwise npm will keep installing 2.25

Issue got fixed by downgrading the version to 2.24.0

try changing to "moment": "2.24.0", make sure that there isn't a ^ in it. delete node_models and re npm install. also if you have package-lock.json you may need to delete it. Otherwise npm will keep installing 2.25

Thanks. Issue got fixed by downgrading the version to 2.24.0

You are no longer living in the moment though :)

try changing to "moment": "2.24.0", make sure that there isn't a ^ in it. delete node_models and re npm install. also if you have package-lock.json you may need to delete it. Otherwise npm will keep installing 2.25

Thanks, Issue got fixed by downgrading version from 2.25.0 to 2.24.0. Also I did "^2.24.0" to "2.24.0"

If the downgrade von 2.25.0 to 2.24.0 does not work and you get the same error again, try to uninstall the module completely and re-install it again.
Using npm:

npm uninstall moment
npm install<EMAIL_ADDRESS>
Hope it helps.
Cheers
Unkn0wn0x

Any Idea when the fix will be released ?  I see this is a broken issue and I don't have access to make changes in Master to set the moment version to 2.24 now and production builds is failing left and right.
Please share release ETA thanks

I had this issue also, and i fixed it
by removing those lines
  "typesVersions": {     ">=3.1": {       "*": [         "ts3.1-typings/*"       ]     }   },
lines 150-156
in
.\node_modules\moment\package.json

I had this issue also, and i fixed it
by removing those lines
 "typesVersions": { ">=3.1": { "*": [ "ts3.1-typings/*" ] } },
lines 150-156
in
.\node_modules\moment\package.json
and after i did this, it's working completely fine with version 2.25

this will work locally, but for CI pipelines, I doubt

Thanks everyone :D 2.24.0 worked for me as well..

Downgraded to 2.24.0, and it's working fine.

2.25.1 released

Tested 2.25.1, issue still occurs.

Tested 2.25.1 , issue is gone. Thanks

Yeah, I tested this too and didn't experience any issues.

Indeed, upgraded minutes after it was published and all is well: thanks for the speedy fix!

Finally it works for me. downgrading to 2.24.0 working. but make sure to put "moment": "2.24.0"
instead of "moment": "^2.24.0"

version 2.25.1 solved the Cannot find module 'moment' problem, but I am testing in an Angular 8 application and it throws the following error:
WARNING in ./node_modules/moment/src/lib/locale/locales.js
Module not found: Error: Can't resolve './locale' in '/home/project/node_modules/moment/src/lib/ locale', has anyone else experienced this failure?

I'm also getting warnings in 2.25.1 about some of the other functions I'm referencing:
"export 'utc' (imported as 'moment') was not found in 'moment'
"export 'max' (imported as 'moment') was not found in 'moment'
"export 'min' (imported as 'moment') was not found in 'moment'

For me it was
    "moment": "2.24.0",
    "moment-timezone": "^0.5.31",

I think you can update moment to version 2.29.0
 npm uninstall moment
npm install<EMAIL_ADDRESS>TS2307: Cannot find module 'moment' in Angular 8

npm install moment --save

// import moment from "moment";
import * as moment from 'moment'

https://stackoverflow.com/questions/61537526/typescript-error-cannot-find-module-moment


community: Add support for Upstash Vector

Description
Adding UpstashVectorStore to utilize Upstash Vector!
#17012 was opened to add Upstash Vector to langchain but was closed to wait for filtering. Now filtering is added to Upstash vector and we open a new PR. Additionally, embedding feature was added and we add this to our vectorstore aswell.
Dependencies
upstash-vector should be installed to use UpstashVectorStore. Didn't update dependencies because of this comment in the previous PR.
Tests
Tests are added and they pass. Tests are naturally network bound since Upstash Vector is offered through an API.
There was a discussion in the previous PR about mocking the unittests. We didn't make changes to this end yet. We can update the tests if you can explain how the tests should be mocked.

Thanks for the review @baskaryan!
Should we resolve all the failing CI checks to merge this PR or are we waiting for review/approval from other people?
I didn't try to resolve all CI issues because we want to offer some functionality on top of what is possible with the VectorStore interface (like embeddings). Since you approved the PR I am not making further changes

Thanks for the review @baskaryan!
Should we resolve all the failing CI checks to merge this PR or are we waiting for review/approval from other people?
I didn't try to resolve all CI issues because we want to offer some functionality on top of what is possible with the VectorStore interface (like embeddings). Since you approved the PR I am not making further changes

Resolving CI failures would be great!

Hi again @baskaryan,
CI errors are resolved. Used VCR to record the integration tests aswell!

Hi @baskaryan,
It looks like all tests pass except Vercel deployment, which got Canceled by a more recent commit in the same branch error


browser: avoid process.version split before process.browser

Should fix https://github.com/crypto-browserify/pbkdf2/issues/43,  @neil-morrison44 could you check?

@dcousens still won't work, the "process" isn't a global within the browser.
  Are you using browserify?  process should be defined.

@dcousens If you want this to work add an explicit dependency on https://www.npmjs.com/package/process (which has support for process.browser) and var process = require("process") in every file which uses it.

The bundle-test works perfect in Chrome... w/ process defined.
What am I missing?

@dcousens ah, huh, good point. Wonder what's going wrong then... possibly not a real issue then.

ping @calvinmetcalf


[dv,dma] Corrections and enhancements to DMA interrupt checking.

This PR was created to fix the failing 'dma_intr_test' vseqs but during investigation it was found to be necessary to make more extensive changes to the DMA interrupt prediction within the DV environment.
The first commit makes some small changes to assist with the 'intr_test' vseq bring up, but is unable to form reliable predictions of the interrupt signals whilst the sequence is performing CSR traffic because the interrupt signals change immediately in response to the INTR_TEST write cycle starting, but the scoreboard is not notified of the register write until the end of the cycle.
Commit 2 introduces for each interrupt signal a queue of the predicted events and a maximum latency before the event must be observed.
Coupled with checking of all interrupt signals on every clock cycle, but one cycle delayed to handle the situation described above, the DV environment is now able to detect not only the occurrence of unexpected interrupts, but also the absence of expected interrupts.
This allows dma_intr_test to completely successfully and has no apparent impact upon other DMA tests (all sequences still passing).
Note: It requires the small RTL change in PR #20598 for some stress sequences/seeds, since the DV detects the bus error on 'clear interrupt' write traffic too and uses this to inform the prediction of an 'ERROR' interrupt rather than 'DONE.'

This seems reasonable to me. I think I understand the logic of "interrupt N must be asserted in the next ten cycles". But how does the scoreboard handle it when the DUT is told to clear an interrupt? I haven't yet found the bit where we're saying "I expect to have seen interrupt N in at most 10 cycles, but it can be cleared again once it has been asserted".

The scoreboard is aware of write accesses to the interrupt-related register (intr_enable, intr_state and intr_test) and forms predictions accordingly in the process_reg_write function.


test.go: Change the default from all flavors to mysql57.

This way a simple "./test.go unit" won't run the test for all flavors.
I've added "all" as a placeholder for all available flavors.

LGTM


Add creating many objects in one request

This change is

Reviewed 4 of 4 files at r1, 1 of 1 files at r2, 4 of 4 files at r3, 3 of 3 files at r4.

Comments from Reviewable

Reviewed 8 of 8 files at r5, 1 of 1 files at r6.
Review status: 1 of 9 files reviewed at latest revision, 1 unresolved discussion.

.idea/vcs.xml, line 1 at r1 (raw file):
Previously, jgoclawski (Jakub Gocławski) wrote…
Don't commit this file.

OK

Comments from Reviewable

Reviewed 4 of 4 files at r7, 3 of 3 files at r8, 1 of 1 files at r9.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


DMP-1625 arm create media manifest file

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DMP-1625
Change description
Created ARM media metafile
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ x] No

As discussed, please add Integration or Functional tests to handle various use cases.


dependency issue

Hi, I am getting this dependency issue while installing via pip
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
requests 2.26.0 requires charset-normalizer~=2.0.0; python_version >= "3", but you have charset-normalizer 2.1.1 which is incompatible.
prefect 0.15.3 requires requests<2.26,>=2.20, but you have requests 2.26.0 which is incompatible.
msal-extensions 0.3.0 requires portalocker~=1.0; platform_system != "Windows", but you have portalocker 2.3.0 which is incompatible.
This I think is creating the following error when trying to load  'parse_instance_ids'
from pangeo_forge_esgf.parsing import parse_instance_ids

TypeError                                 Traceback (most recent call last)
/tmp/ipykernel_331/23446803.py in
----> 1 from pangeo_forge_esgf.parsing import parse_instance_ids
/srv/conda/envs/notebook/lib/python3.8/site-packages/pangeo_forge_esgf/parsing.py in
24
25
---> 26 def parse_instance_ids(iid: str) -> list[str]:
27     """Parse an instance id with wildcards"""
28     facets = facets_from_iid(iid)
TypeError: 'type' object is not subscriptable

Are you using this on windows? I unfortunately have little experience with running anything on windows these days. I wonder though if a conda-forge distro might help?
Just to double check, can you post a reproducible code snippet so I can confirm that this does not happen on unix systems?

Hi Julius,
Many thanks for the reply.
I am running this on Linux, but through Jupyter running on a kubernetes pod. Just loading the module after installation gives me this error
!pip install git+https://github.com/jbusecke/pangeo-forge-esgf.git
from pangeo_forge_esgf.parsing import parse_instance_ids
When I tried installing the version in pypi, I got the error 'no module named pangeo_forge_esgf.parsing'

When I tried installing the version in pypi, I got the error 'no module named pangeo_forge_esgf.parsing'

Yep the last release did not include the module at all, that is correct.
When installing from main I actually ran into another dependency error (requests is missing). I will start a PR and actually add some rudimentary tests. Ill report back once that is done, and hopefully that will resolve your issue. Sorry for the inconvenience.

Hi @rahulsivankutty, could you try installing from #8 and see if that fixes your issue? I can also merge it now if that helps you with testing.

Many thanks @jbusecke.
I could use this branch without any error (Not in the original location as I lost access to the server temporarily due to a maintenance which is going on. I tried it in another Linux platform and didn't get any issue)

Ok that sounds promising. I will then merge this and issue a bugfix release. I will close this now, but feel free to reopen if the problem returns/persists with the released version!


Motor remains slow

I have a technic large motor connected to the build hat, and tried a bit of example code:
from buildhat import Hat
from buildhat import Motor

def handle_motor(speed, pos, apos):
    """Motor data

    :param speed: Speed of motor
    :param pos: Position of motor
    :param apos: Absolute position of motor
    """
    print("Motor", speed, pos, apos, "Vin", hat.get_vin())

hat = Hat()
print(hat.get())
print(hat.get_vin())
hat.set_leds(color='voltage')

motor = Motor('A')
motor.when_rotated = handle_motor
motor.run_for_seconds(10, speed=-100)

The motor doesn't go over speed 30, and around 25 most of the time.
The Vin stays above 7.8V.
I tried using set_speed_unit_rpm(True) as well, but no change in speed.

@vliedel you need to set motor power limit.
motor.plimit(1)

Thanks! With motor.plimit(1) and set_speed_unit_rpm(True), I finally reached speed 100 :)


Re-check security posture against the k8s admission control threat model

Acceptance criteria
Following the k8s admission controller threat model document listed in kubernetes/sig-security/issues/7, check all threats and mitigations to see if we need to re-implement or add anything. Check if we want to provide a production setting with specific policies deployed by default (pod-privileged not allowed on same node as controller, etc).
In addition, list any stack differences if any on the Kubewarden stack, and provide a threat model analysis for those.
Create followup cards with the work to be done if necessary.

The Kubernetes Sig-security has finished their threat model study:
https://kubernetes.io/blog/2022/01/19/secure-your-admission-controllers-and-webhooks/
https://togithub.com/kubernetes/sig-security/tree/main/sig-security-docs/papers/admission-control

Okay. There are 18 threats mapped in the document shared in https://github.com/kubewarden/kubewarden-controller/issues/129#issuecomment-1019851853. I'll discuss each one sharing a brief description of it, possible mitigation and what I think we should do about it (if necessary). If you need more details about each threat, go to the original document. The threats are:
Thread 1 - Attacker floods webhook with traffic preventing its
An attacker who has access to the Webhook endpoint, at the network level, could send large  quantities of traffic, causing an effective denial of service to the admission controller.
Mitigation
Webhook fails closed. In other words, if the webhook does not respond in time, for any reasion, API server should reject the request. We are safe on this. Kubewarden default behavior  already does that.
Thread 2 - Attacker passes workloads which require complex  processing causing timeouts
An attacker, who can access the admission controller at a network level, passes requests to  the admission controller which require complex processing, causing timeouts as the  admission controller uses compute power to process the workloads
Mitigation
Webhook fail closed and authenticate callers. We are safe, Kubewarden already does that.
Threat 3 - Attacker exploits misconfiguration of webhook to bypass
An attacker, who has rights to create workloads in the cluster, is able to exploit a mis-configuration to bypass the intended security control
Mitigation
Regular reviews of webhook configuration catch issues. We need to provide some mechanism to notify operators when a webhook is changed. Maybe the controller can watch its webhooks and fix when the configuration is changed and notify the operator.
Threat 4 - Attacker has rights to delete or modify the k8s webhook  object
An attacker who has Kubernetes API access, has sufficient privileges to delete the webhook  object in the cluster.
Mitigation
RBAC rights are strictly controlled.
I think most of the RBAC is not responsibility. But we can help our users if we:

Warning them in our docs and suggest some minimum RBAC to be used.
Provide a policy which detect RBAC changes and maybe block them.

Threat 5 - Attacker gets access to valid credentials for the webhook
An attacker gains access to valid client credentials for the admission controller webhook
Mitigation
Webhook fails closed
Kubewarden is failed closed. Thus, we should be fine.
Threat  6 - Attacker gains access to a cluster admin credential
An attacker gains access to a cluster-admin level credential in the kubernetes cluster.
Mitigation
N/A
I cannot see what Kubewarden can do here.
Threat 7 - Attacker sniffs traffic on the container network
An attacker who has access to the container network is able to sniff traffic between the API  server and the admission controller webhook.
Mitigation
Webhook uses TLS encryption for all traffic
Kubewarden are safe. Because the webhook connections are encrypted.
Threat 8 - Attacker carries out a MITM attack on the webhook
An attacker on the container network, who has access to the NET_RAW capability can  attempt to use MITM tooling to intercept traffic between the API server and admission  controller webhook.
Mitigation
Webhook mTLS authentication is used.

Kubewarden should implement mutual TLS authentication
Add in the recommended policies from the kubewarden-defaults Helm chart a policy to drop the NET_RAW capability.

Threat 9 - Attacker steals traffic from the webhook via spoofing
An attacker is able to redirect traffic from the API server which is intended for the admission  controller webhook by spoofing.
Mitigation
Webhook mTLS authentication is used.

Kubewarden should implement mutual TLS authentication

Threat 10 - Abusing a mutation rule to create a privileged container
An attacker is able to cause a mutating admission controller to modify a workload, such that  it allows for privileged container creation
Mitigation
All rules are reviewed and tested.
We may came up with some tests to cover this rules reviews
We  should carefully review a PR changing the rules in the policies deployment
Threat 11 - Attacker deploys workloads to namespaces that are  exempt from admission control
An attacker is able to deploy workloads to Kubernetes namespaces that are exempt from the  admission controller configuration.
Mitigation
RBAC rights are strictly controlled
I think most of the RBAC is not responsability. But we can help our users if we:

Warning them in our docs and suggest some minimum RBAC to be used.
Provide a policy which detect RBAC changes and maybe block them. Is this possible?

Threat ID 12 - Block rule can be bypassed due to missing match (e.g.  missing initcontainers)
An attacker created a workload manifest which uses a feature of the Kubernetes API which  is not covered by the admission controller
Mitigation
All rules are reviewed and tested.
We may came up with some tests to cover this rules reviews
We  should carefully review a PR changing the rules in the policies deployment
Threat ID 13 - Attacker exploits bad string matching on a blocklist to  bypass rules
An attacker, who has rights to create workloads, bypasses a rule by exploiting bad string  matching.
Mitigation
All rules are reviewed and tested.
We may came up with some tests to cover this rules reviews
We  should carefully review a PR changing the rules in the policies deployment
Threat ID 14 - Attacker uses new/old features of the Kubernetes API  which have no rules
An attacker, with rights to create workloads, uses new features of the Kubernetes API (for  example a changed API version) to bypass a rule.
Mitigation
All rules are reviewed and tested.

We may came up with some tests to cover this rules reviews and API versions.
We may create a configuration to reject by default requests with not cover in the specified API version.
We should warning policies developers to cover all the supported API version in theirs tests and reject all of others.

Threat ID 15 - Attacker deploys privileged container to node running  Webhook controller
An attacker, who has rights to deploy privileged containers to the cluster, creates a privileged  container on the cluster node where the admission controller webhook operates.
Mitigation
Admission controller uses restrictive policies to prevent privileged  workloads
We have a policy to prevent privileged workloads in the recommended policies in the kubewarden-default helm chart. But we can improve by:

We may need to define all the API versions cover by the recommended policies
We can create a configuration to reject by default requests with not cover API version.
We should warning policies developers to cover all the supported API version in theirs tests and reject all of others.

Threat ID 16 - Attacker mounts a privileged node hostpath allowing  modification of Webhook controller configuration
An attacker, who has rights to deploy hostPath volumes with workloads, creates a volume  which allows for access to the admission controller pod’s files.
Mitigation
Admission controller uses restrictive policies to prevent privileged  workloads

We can add a recommended policy in the kubewarden-default Helm chart to prevent this.

Threat ID 17 - Attacker has privileged SSH access to cluster node  running admission webhook
An attacker is able to log into cluster nodes as a privileged user via SSH.
Mitigation
N/A
I don't think Kubewarden can help on this
Threat ID 18 - Attacker uses policies to send confidential data from  admission requests to external systems
An attacker is able to configure a policy that listens to admission requests and sends  sensitive data to an external system.
Mitigation
Strictly control external access for webhook
We may define some network configuration to block external access from the Kubewarden pods.

This looks great! Starting to review made me think, should we open an RFC with this content, for review, and posterity?

This looks great! Starting to review made me think, should we open an RFC with this content, for review, and posterity?

Hm, yeah. I think it makes sense. :)

https://github.com/kubewarden/rfc/pull/2


There is no ecmascript 7 async and promises

Does anyone need?

What do you have exactly on mind (usecase)? Because I was just wondering that it might be really useful to have "fail" callback. Somehow like jQuery.getScript loads scripts. But that returns promises and seems like this project creator intentions were to remove promises altogether.
My usecase: [try to load Google Maps API] ->  -> [fallback to offline solutions (e.g. OSM)]

This package used promises at the beginning. The problem was that it added some huge dependency to project + I needed (still need) to support older browsers, so I also can't simply use native promises or async.
If you'll look at the code, you'll see that it's really easy and that's why I rewrite it from coffeescript to pure js and removed all dependencies too. Now anyone can use it and it matters not what your current environment is.
But I'm not saying that I woudn't like it. :smiley: Oh and what I also like is the idea about some fail callback.  On my weekends I'll write code ;)

Hi, I was thinking about it again and I think that I found a solution which could be good for everyone. We can keep current code just like it is now and create new file which will contain wrapper around the current code with ES7 support.
With this approach every developer can choose the best option for them.
What do you think about it?

Would love to see promises implemented in this library.  Much cleaner and can then be used with the awesome async keyword in TypeScript/ESwhatever.

@davidkudera I like your idea, wrapper is better solution. I will think about it

Hi and sorry for the long human-timeout. Promises are back :wink:
Please check out the new version 4.1.1. It's now written in typescript and supports await/async.


Fails when converting html table to docx

Running this code:
        var result = HtmlToWmlConverter.ConvertHtmlToWml(
            "", "", "",
            XElement.Parse("

asger

"),
            HtmlToWmlConverter.GetDefaultSettings());

Throws this exception:
System.NullReferenceException

Object reference not set to an instance of an object.

   at OpenXmlPowerTools.HtmlToWml.HtmlToWmlConverterCore.GetTableGrid(XElement element, HtmlToWmlConverterSettings settings)
   at OpenXmlPowerTools.HtmlToWml.HtmlToWmlConverterCore.Transform(XNode node, HtmlToWmlConverterSettings settings, WordprocessingDocument wDoc, NextExpected nextExpected, Boolean preserveWhiteSpace)
   at OpenXmlPowerTools.HtmlToWml.HtmlToWmlConverterCore.<>c__DisplayClass20_0.<Transform>b__3(XNode n)
   at System.Linq.Enumerable.WhereSelectEnumerableIterator`2.MoveNext()
   at System.Xml.Linq.XContainer.AddContentSkipNotify(Object content)
   at System.Xml.Linq.XContainer.AddContentSkipNotify(Object content)
   at System.Xml.Linq.XContainer.AddContentSkipNotify(Object content)
   at OpenXmlPowerTools.HtmlToWml.HtmlToWmlConverterCore.UpdateMainDocumentPart(WordprocessingDocument wDoc, XElement html, HtmlToWmlConverterSettings settings)
   at OpenXmlPowerTools.HtmlToWml.HtmlToWmlConverterCore.ConvertHtmlToWml(String defaultCss, String authorCss, String userCss, XElement xhtml, HtmlToWmlConverterSettings settings, WmlDocument emptyDocument, String annotatedHtmlDumpFileName)
   at OpenXmlPowerTools.HtmlToWmlConverter.ConvertHtmlToWml(String defaultCss, String authorCss, String userCss, XElement xhtml, HtmlToWmlConverterSettings settings)

Can anybody help me spot what, I am doing something wrong? :)

It seems the converter expects that table cells have a width. I was able to get around a similiar problem by adding
width="auto"
to every table cell.

@nojan1 thanks! In my case it was solved by not nesting text nodes directly inside , but using some text	 instead.


Creating snapps via API with  TAGS_AS_PREFIX: "true" failing

Continue getting {"message":"This Snapps has no prefix selected, please include one."}
'{
"shortcode": "geo",
"original_url": "https://example.com",
"disabled": false,
"tags": ["test"],
"userId": "u5s79579"
}'
{"message":"This Snapps has no prefix selected, please include one."}%

look like i didn't included tags in snapp creation payload, fixing it

Fixed now :)


The Mysterious Case of the Vanishing Wi-Fi and Rebellious Notepad

Bug Report:
The Mysterious Case of the Vanishing Wi-Fi and Rebellious Notepad
Describe the bug
Oh boy, have we got a bug tale for you! So, picture this: you're all excited to load up the latest version of the Windows tool on your trusty Surface Book 2, ready to conquer the digital world. But alas! As soon as the installation completes, things go haywire faster than a caffeinated squirrel on a power line. Notepad refuses to open text files, and just when you thought it couldn't get worse, your Wi-Fi network mysteriously vanishes into thin air. Poof! Just like that, it's gone.
To Reproduce
Now, let's retrace our steps through this techno-maze and try to recreate the chaos:

The adventure begins with the installation of various programs, including Obsidian, Gmail, Chrome, GDrive, and VeraCrypt.
Next, visit the mystical land of Github to download the current version of the Windows tool. Trust us, it's an adventure in itself.

Oh, by the way, be sure to consult the GitHub page for the Windows tool for the download quest.

Armed with the command, dive headfirst into the process, choosing the default options like a brave warrior.
When prompted, select the "Laptop" option because we all know your Surface Book 2 is your trusty steed.
Now, take a deep breath, and prepare for the inevitable. Reboot your system and witness the chaos unfold.
As the dust settles, observe the wretched state of affairs: Notepad refuses to play nice with text files the only file it can load, and your beloved Wi-Fi network has pulled a disappearing act worthy of a Houdini impersonator.

Expected behavior
In a perfect world, my dear troubleshooter, this is how things should have gone down: The Windows tool should have danced smoothly with your Surface Book 2, causing no disruptions to the harmonious functioning of my laptop. Notepad should have eagerly opened text files, and the Wi-Fi network should have remained as reliable as your grandma's secret cookie recipe.
Additional context Alas, no screenshots were provided to document this wild journey. However, I have stumble upon an intriguing CMD output I don't possess any secret knowledge that might shed light on this confounding issue, but if you do please share it with me. I am all ears and ready to delve deeper into this mystical realm of glitches and mayhem.
On a serious note, I'm happy to test it, if you figure out what's happening, I know there are not a lot of surface books out there.
cheers
tom
cmd output.txt

Same happened with me. Did not check anything else, but wifi stopped working. Driver could not be installed. I did everything the same on other laptop and everything OK.

There's a bug now that disables Windows Management Instrument (WMI) instead of making it manual, given the timing quite likely culprit.
https://github.com/ChrisTitusTech/winutil/issues/735
Basically just do the same steps but set it to manual (instead of disabled) and start it.

Thanks exostalker, will try that


fix: set zookeeper volume size via kblib and change default storage size to 10Gi

When creating a Zookeeper cluster, the minimum storage value is set to 10Gi, but it's actually created with 4Gi.
fix cloud issue #5999

cherry-pick release-0.9

/cherry-pick release-0.9


@next/font/google: Hash filenames used in virtual file paths

This uses hex-encoded hashes so that filenames for virtual assets for @next/font/google are unique. Previously, every virtual asset generated by @next/font/google would have the same path to the asset, impacting the quality of sourcemaps. This also keeps the basename consistent between the js and css module counterparts This also keeps the names consistent between the js and css module counterparts.
This also implements DeterministicHash for &str this type.
Test Plan: Given
import {Inter} from '@next/font/google';
import {Open_Sans} from '@next/font/google';

const inter = Inter({weight: "500"});
const sans = Open_Sans({weight: "500"});

...Chrome shows a tree of sourcemapped sources of:
[embedded_modules]/@vercel/turbopack-next
  internal
    font/google
      2c0be0907019305d.js
      aaae6c750be3e27d.js
      2c0be0907019305d.module.css
      aaae6c750be3e27d.module.css

Current dependencies on/for this PR:

main

PR #2963

PR #2964

PR #2965

PR #2978   👈

This comment was auto-generated by Graphite.


model.fit very slow validation, more evident with Intel Phi

I have a similar problem of this old issue(wrongly closed because stale), in all epochs, the validation calculation is slower than the epoch training part.
Both validation and training sets have the same number of examples.
The two phases take the same time with a 18 cores Xeon CPU, but validation takes 4 times the training time with Intel Phi architeclure (and tensorflow MKL binary).
I think/suspect that model evaluation for validation calculation does not take advantage of parallelization/multi-threading. This could be the core of the problem. Please check.
Regards
Please make sure that the boxes below are checked before you submit your issue.
If your issue is an implementation question, please ask your question on StackOverflow or on the Keras Slack channel instead of opening a GitHub issue.
Thank you!

[x ] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/keras-team/keras.git --upgrade --no-deps

[x ] Check that your version of TensorFlow is up-to-date. The installation instructions can be found here.

[x] THE LINKED OLD ISSUE ALREADY HAS IT. Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

I’m encountering the same issue on GPU with a MSE loss.  At least 4x as long to validate 1/10th of the samples used in training.


Variable jsonObjectResponse in never used

The variable jsonObjectResponse is greyed out and displays warning:
Variable jsonObjectResponse in never used
Is this a cause for concern?

Nothing to be concerned about... Basically it your prerogative to work with tge json object response or not


feat: add function for obtaining a list of holders in a given block number

Close #1134
1. Online API feature
POST
https://github.com/BoostryJP/ibet-Wallet-API/blob/b0ba9c92653a0b1f8525f3d58c7fbc0e90c710e7/docs/ibet_wallet_api_v2.yaml#L1996

Added POST endpoint.
This api expect “contract_address” in path, “list_id” and “block_number” in body.
”list_id” is assumed to be UUID.
If existing combinations of block_number and contract_address is given, this api will return existing list_id.

GET
https://github.com/BoostryJP/ibet-Wallet-API/blob/b0ba9c92653a0b1f8525f3d58c7fbc0e90c710e7/docs/ibet_wallet_api_v2.yaml#L2064

This api expect “contract_address” and “list_id “ in path.

2. Batch feature

It syncs all events from 0 to given block number.
If it has already collected events from 0 to some block number and stored data in DB, it can reuse the data.
Token holders address is excluding issuer address as we cannot get totalSupply at specific block_number(If all events we may fetch, it could).

3. others
https://github.com/BoostryJP/ibet-Wallet-API/blob/b0ba9c92653a0b1f8525f3d58c7fbc0e90c710e7/docs/ibet_wallet_api_v3.yaml#L1272-L1279

In swagger v2 format, “example” phrase in request parameter is not permitted.

In the past PR(#1127 ) I added this mistakenly, then now fixed.

Sorry for committing again.
I have fixed some points.

removed hard-coded token types
added entrypoint of batch.

I want to be reviewed including latest commit.

Sorry for committing again.
I have fixed some points.

removed hard-coded token types
added entrypoint of batch.

I want to be reviewed including latest commit.

@YoshihitoAso
thank you for your review.
I have fixed return value of GET token holders list.
(and API docs/ tests)


[257] JavaScript Snippet Issue for NEAR Transfer

Title:
JavaScript Snippet Issue for NEAR Transfer
Description:
The javascript snippet for Transfer NEAR does not work, NearPromise line must start with return for the transfer to be executed
Summary:
Customer is experiencing issues with the JavaScript snippet for NEAR transfers, specifically that it does not function unless 'return' is included at the start of the NearPromise line.
Info
Reported by: Guest<EMAIL_ADDRESS>- Open in Gleap
Location: US
Type: 🚨 BUG
🔗 Open share link
🌍 Open ticket in Gleap
Metadata
browserName: Chrome(<IP_ADDRESS>)
userAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
browser: Chrome
systemName: MacOS
sessionDuration: 2226
devicePixelRatio: 2
screenWidth: 3360
screenHeight: 1890
innerWidth: 2258
innerHeight: 1838
currentUrl: https://docs.near.org/build/smart-contracts/anatomy/actions
language: en-US
sdkVersion: 13.7.3
sdkType: javascript
environment: prod

Internal note 📝: Customer is experiencing issues with the JavaScript snippet for NEAR transfers, specifically that it does not function unless 'return' is included at the start of the NearPromise line.


Dashboard: Fix failing settings page karma test

Summary
The publisher logo keyboard test was failing because we were not allowing for enough tabs through the page to get to the element after adding in the support menu item (count was off). Adding a click to the container of the logos to then use keyboard off of and increasing tab-able count as a back up if click should not take in time.
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions
All dashboard karma tests should now pass
(you shouldn't get this)

Fixes #

Looks good. Looks like we have a couple un-related test failures for the publishing flow, so we can probably just re-run those.


[macOS] Rework PowerShell installation

Description
Currently, we install powershell using brew, which brings OpenSSL 3.0* in the process. To avoid such situation, we need to rework current approach of powershell installation.
Related issue: #4719
Check list

[ ] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run macos1015, macos11, macos12


[mvn] Update to maven 3.6.0, wrapper 0.4.2

dropping jar file as no longer necessary.
Check List:

Fixes n/a
Unit tests : n/a
Javadoc with a code example (API only) : n/a

Simply brings maven wrapper usage up-to-date.

Thanks for taking care of the maven side of things @hazendaz !


map value

Feature request
In daily query, only the key of the map can be defined. I hope that the value of the map can also be defined, which can be returned directly Map<Integer, Integer>
public interface NoticeMapper {

  @MapKey("status")
  @MapValue("count")
  Map<Integer, Integer> groupStatus();

}

<mapper namespace="org.apache.ibatis.submitted.mapkey_value.NoticeMapper">

  <resultMap id="groupStatusMap" type="hashmap">
    <result column="count" javaType="Integer" property="count"/>
    <result column="status" javaType="Integer" property="status"/>
  </resultMap>

  <select id="groupStatus" resultMap="groupStatusMap">
  select count(*) as count , status
    from notice group by status
  </select>

</mapper>

https://github.com/mybatis/mybatis-3/pull/2863

Feature request
In daily query, only the key of the map can be defined. I hope that the value of the map can also be defined, which can be returned directly Map<Integer, Integer>
public interface NoticeMapper {

  @MapKey("status")
  Map<Integer, HashMap<Integer, Integer>> groupStatus();

}

<mapper namespace="org.apache.ibatis.submitted.mapkey_value.NoticeMapper">

  <select id="groupStatus" resultMap="hashMap">
  select count(*) as count , status
    from notice group by status
  </select>

</mapper>

#2863

Similarly, we want to support a collection of map value objects rather than a single example for jpa:
  @ElementCollection
  private Map<Long, Money> creditReservations;

Feature request
In daily query, only the key of the map can be defined. I hope that the value of the map can also be defined, which can be returned directly Map<Integer, Integer>
public interface NoticeMapper {

  @MapKey("status")
  Map<Integer, HashMap<Integer, Integer>> groupStatus();

}

<mapper namespace="org.apache.ibatis.submitted.mapkey_value.NoticeMapper">

  <select id="groupStatus" resultMap="hashMap">
  select count(*) as count , status
    from notice group by status
  </select>

</mapper>

#2863

Similarly, we want to support a collection of map value objects rather than a single example for jpa:
  @ElementCollection
  private Map<Long, Money> creditReservations;

It's hard to do, but I thought you could do it through association
<mapper namespace="org.apache.ibatis.submitted.mapkey_value.NoticeMapper">
  <resultMap id="elementCollection" type="org.apache.ibatis.domain.blog.Notice">
    <result column="id" javaType="Integer" property="id"/>
    <result column="status" javaType="Integer" property="status"/>

    <association property="authors" column="id"  javaType="org.apache.ibatis.domain.blog.Author"
                 select="org.apache.ibatis.domain.blog.mappers.AuthorMapper.selectAllAuthorsMap"/>
  </resultMap>

  <select id="elementCollection" resultMap="elementCollection">
    select * from notice
  </select>

</mapper>

public interface AuthorMapper {

  @MapKey("id")
  Map<Integer, Author> selectAllAuthorsMap();
}

<mapper namespace="org.apache.ibatis.domain.blog.mappers.AuthorMapper">

  <select id="selectAllAuthorsMap" resultType="org.apache.ibatis.domain.blog.Author">
    select * from author
  </select>

</mapper>

However, after execution, it is found that mybatis association only considers a single object, collection, array

Hello @min1854 ,
Thank you for the idea and the PR.
I don't understand the @isfong 's request (please open a new issue if it's not exactly the same request), but the original request seems to be the same as #2672.
As I wrote in the issue, there are many similar but slightly different requests and, personally, I would expect users to use ResultHandler or Java's stream for this type of requirements.
However, if other committers are interested in supporting @MapValue, I would not object (I may add a few requests on #2863 if it's green-lit, though).

Yes, the two requests are the same, but since the map keys are already available and values cannot be defined, one dto needs to be defined at a time. Using  Java's stream and ResultHandler  is not convenient and elegant in code
Whenever there are only two columns, I need to define an additional DTO instead of directly converting the results into a map, so encoding also requires repeating the additional definition of DTO
I think most people want to directly convert to a map when querying two columns, but when they find that 'MapKey' can only support keys and cannot define values, they can only define dto. I often use this question when using it
In the end, only DTO can be defined and converted to a map using 'Java's stream'
So I hope to add the function of defining map value

Feature request
In daily query, only the key of the map can be defined. I hope that the value of the map can also be defined, which can be returned directly Map<Integer, Integer>
public interface NoticeMapper {

  @MapKey("status")
  Map<Integer, HashMap<Integer, Integer>> groupStatus();

}

<mapper namespace="org.apache.ibatis.submitted.mapkey_value.NoticeMapper">

  <select id="groupStatus" resultMap="hashMap">
  select count(*) as count , status
    from notice group by status
  </select>

</mapper>

#2863

Similarly, we want to support a collection of map value objects rather than a single example for jpa:
  @ElementCollection
  private Map<Long, Money> creditReservations;

I think this is difficult and requires a lot of consideration

Hello @min1854 ,
Thank you for the idea and the PR.
I don't understand the @isfong 's request (please open a new issue if it's not exactly the same request), but the original request seems to be the same as #2672.
As I wrote in the issue, there are many similar but slightly different requests and, personally, I would expect users to use ResultHandler or Java's stream for this type of requirements. However, if other committers are interested in supporting @MapValue, I would not object (I may add a few requests on #2863 if it's green-lit, though).

Yes, the two requests are the same, but since the map keys are already available and values cannot be defined, one dto needs to be defined at a time. Using  Java's stream and ResultHandler  is not convenient and elegant in code
Whenever there are only two columns, I need to define an additional DTO instead of directly converting the results into a map, so encoding also requires repeating the additional definition of DTO
I think most people want to directly convert to a map when querying two columns, but when they find that 'MapKey' can only support keys and cannot define values, they can only define dto. I often encounter this problem when using it
In the end, only DTO can be defined and converted to a map using 'Java's stream'
So I hope to add the function of defining map value

@min1854 ,
Sorry for the belated reply. I was writing a reply, but forgot to post it.
I just wanted to let you know that if your @MapValue satisfies your requirement, custom DTO class won't be necessary.
@Select("select status, count(*) cnt from ...")
List<Map<String, Object>> selectMaps();

Map<Integer, Integer> statCountMap = selectMaps().stream()
  .collect(Collectors.toMap(e -> (Integer) e.get("status"), e -> (Integer) e.get("cnt")));

Also, you can put the stream processing code in a default method of the mapper.
default Map<Integer, Integer> getStatCountMap() {
  return selectMaps().stream()
    .collect(Collectors.toMap(e -> (Integer) e.get("status"), e -> (Integer) e.get("cnt")));
}

(

This is not elegant, In my opinion, this should be the work done by the framework.
I think the mapping work should be addressed by the framework

@min1854 ,
Sorry for the belated reply. I was writing a reply, but forgot to post it.
I just wanted to let you know that if your @MapValue satisfies your requirement, custom DTO class won't be necessary even with the current version.
@Select("select status, count(*) cnt from ...")
List<Map<String, Object>> selectMaps();

Map<Integer, Integer> statCountMap = selectMaps().stream()
  .collect(Collectors.toMap(e -> (Integer) e.get("status"), e -> (Integer) e.get("cnt")));

Also, you can put the stream processing code in a default method of the mapper.
default Map<Integer, Integer> getStatCountMap() {
  return selectMaps().stream()
    .collect(Collectors.toMap(e -> (Integer) e.get("status"), e -> (Integer) e.get("cnt")));
}

This is not elegant, In my opinion, this should be the work done by the framework.
I think the mapping work should be addressed by the framework
Maintaining duplicate default methods is also a hassle point


text_edit auto_completion

replaced similarity with begins_with
closes https://github.com/godotengine/godot/issues/16045
New version(you can see the old in the issue)

This is something I wasn't looking for but it seems to work better now(still not perfect).
Old version

New version

related? https://github.com/godotengine/godot/issues/20565

What happen if you type something that's not an exact match?

Example - "Not exact"
looking for OS.get_executable_path

the load keyword is missing as a keyword in the docs.
http://docs.godotengine.org/en/latest/getting_started/scripting/gdscript/gdscript_basics.html
It looks like preload is missing '(' and they both(load/preload) don't activate the auto_completion like connect does now.

Could you squash commits together and edit the commit log to be more descriptive?

Still a weird commit log, but code looks fine, thanks :)


Old compilers do not like this:

Hi,
The things that needed to be done to get this working with icc 2016 (welcome to the HPC world, where the tools are old and the build procedures are scary). Please check whether you can do sth from it.
diff --git a/extern/scorep_plugin_cxx_wrapper b/extern/scorep_plugin_cxx_wrapper
--- a/extern/scorep_plugin_cxx_wrapper
+++ b/extern/scorep_plugin_cxx_wrapper
@@ -1 +1 @@
-Subproject commit 74401d74e634f528b1dff1438f7c3baf488cc0f0
+Subproject commit 74401d74e634f528b1dff1438f7c3baf488cc0f0-dirty
diff --git a/src/x86_energy_measurement_thread.cpp b/src/x86_energy_measurement_thread.cpp
index 035378f..8aa2e2c 100644
--- a/src/x86_energy_measurement_thread.cpp
+++ b/src/x86_energy_measurement_thread.cpp
@@ -5,6 +5,8 @@
  *      Author: gocht
  */

+#include <type_traits>
+
 #include <x86_energy_measurement_thread.hpp>

 x86_energy_measurement_thread::x86_energy_measurement_thread(std::chrono::microseconds intervall_)
diff --git a/src/x86_energy_plugin.cpp b/src/x86_energy_plugin.cpp
index 10f34a0..85c9724 100644
--- a/src/x86_energy_plugin.cpp
+++ b/src/x86_energy_plugin.cpp
@@ -60,7 +60,10 @@ x86_energy_plugin::x86_energy_plugin()
         {
             source.init();
             logging::debug() << "Add Source: " << source.name();
-            active_sources.push_back(std::make_unique<x86_energy::AccessSource>(std::move(source)));
+            active_sources.push_back(
+               std::unique_ptr<x86_energy::AccessSource> {
+                  new x86_energy::AccessSource(std::move(source))
+               } );
         }
         catch (std::exception& e)
         {
diff --git a/src/x86_energy_sync_plugin.cpp b/src/x86_energy_sync_plugin.cpp
index 844ca1c..3a7ce3b 100644
--- a/src/x86_energy_sync_plugin.cpp
+++ b/src/x86_energy_sync_plugin.cpp
@@ -94,7 +94,10 @@ x86_energy_sync_plugin::x86_energy_sync_plugin()
         {
             source.init();
             logging::debug() << "Add Source: " << source.name();
-            active_sources.push_back(std::make_unique<x86_energy::AccessSource>(std::move(source)));
+            active_sources.push_back(std::unique_ptr <x86_energy::AccessSource>
+            {
+                new x86_energy::AccessSource(std::move(source))
+            });
         }
         catch (std::exception& e)
         {

The problem is not intel2016 but gcc4.8, where the last version is released in 2014. Ass gcc5 is around nearly since 2014 as well, which is C++14 feature complete, I am not sure, if it is a good idea supporting as old compilers.
Best,
Andreas


Find area of a right angled triangle

Description
Area of right angled triangle = 0.5 × Base × Height
Base   : 2
Height : 3

Area : 3

Program added successfully :tada:
Thanks for your contribution :hugs:


Not working with Edge 25.10850.00

There isn't enough information here to figure out what's going on. If you can share a code sample and a test file, please reopen and we can take a look.


Enforce step_delta consistency

The number of intervals per day (step_delta) is hard-coded in partition.py and may therefore be inconsistent with user specification of this interval in a model run:
https://github.com/eho-tacc/episimlab/blob/8b0b66b8ce866b21650ac1f4e018d6a34e4a2ead/episimlab/partition/partition.py#L127
Refactor to use utils/datetime.py to set a datetime interval. Remove assertion in seir/base.py that works around this hard-coding bug by asserting step_delta is one day.

step_delta is not surfaced in the CLI, but it is set by CLI-dependent helper functions (with the current workflow being to create a new CLI script for each use case).
https://github.com/eho-tacc/episimlab/blob/eeb2cea5273367ef49a015d6c1a905d467e07609/scripts/DemoATX.py#L49


Support more colors

When there are a lot of lines/bars etc in a chart, the same color gets reused, which can make it hard to read.

Could use this list as a guide
https://gist.github.com/leodido/c08577236b46834e5ba181450046e95b
Unfortunately I don't know where I got the original color palette from. It'd be great to document it this time.


Improving the string repr

We've discussed improving the html repr but the string repr could also be improved.
It currently looks like this:
DataTree('None', parent=None)
│   Dimensions:  ()
│   Data variables:
│       foo      <U6 'orange'
└── DataTree('a')
    │   Dimensions:  (y: 3)
    │   Coordinates:
    │     * y        (y) int64 0 1 2
    │   Data variables:
    │       bar      int64 0
    ├── DataTree('b')
    │       Dimensions:  ()
    │       Data variables:
    │           zed      float64 nan
    └── DataTree('c')
        └── DataTree('d')

Some things that could be better:

We don't need to say DataTree over and over

This is a product of the recursive way we currently write the reprs, but it's redundant. Xarray Dataset's repr doesn't say Variable over and over again. Instead we should just have it say <datatree.DataTree> once at the top, and then the node structure given is enough to imply that the nodes are also DataTree objects, with just the node names listed.

Automatically truncate long dataset outputs

We need to automatically use xarray's options for truncating dataset reprs pretty brutally to try to keep the string repr size down.

Whether root node has a parent

Datatree objects can be parentless (i.e. a root node) or have a parent (i.e. a subtree). Currently this is communicated by the parent=... part of the first line of the repr. This was motivated by the idea of the repr being executable, but I don't think it's great. It doesn't neatly communicate the idea that there is the rest of the tree above this node, and it's not actually executable either.
What might be better is just to have some kind of ... continuation above the first node.

Representing nameless root nodes

Datatree allows the root node (and the root node only) to have a name of None. (See https://github.com/xarray-contrib/datatree/issues/81). What's the best way to disambiguate this from having a root node named "None"? Should we use <None>, or would that be ambiguous with "<None>? Should we use string quotation marks around the names of all other nodes (which would be inconsistent with how xarray displays variable names)?

With all these suggestions together we might get something like this:
<datatree.DataTree>
...
│
<None>
│   Dimensions:  ()
│   Data variables:
│       foo      <U6 'orange'
└── a
    │   Dimensions:  (y: 3)
    │   Coordinates:
    │     * y        (y) int64 0 1 2
    │   Data variables:
    │       bar      int64 0
    ├── b
    │       Dimensions:  ()
    │       Data variables:
    │           zed      float64 nan
    └── c
        └── d

Do we think that's any better?

I think all of these ideas were discussed and or implemented upstream in https://github.com/pydata/xarray/pull/9064


Bug: Unable to download pictures

Type
UI-related issues
Bug description
Hello, I've noticed that I'm unable to download certain images from Yande.re no matter how many times I try. The screenshots indicate that the downloads failed without providing any specific reason.
Thank you for your attention.
Steps to reproduce
The error seems to occur randomly. I tested the app on another phone (Android 10), and the 'broken' images were downloadable.
Android version
13.1
App version
1.4.0
Screenshots or videos

Solution
No response
Additional context
No response
Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.

After conducting some tests, I have discovered that every image file name that fails to download contains the character colon ":". I hope this information can be helpful.

After conducting some tests, I have discovered that every image file name that fails to download contains the character colon ":". I hope this information can be helpful.

Thanks! I tried on my phone and it's failed too.


Resource Manager user directory child folders not accessible

Description of bug
As an authenticated non admin user with access to the RM you are able to upload a zip file.  If you include a directory in the zip file it will upload but you cannot access the files in it.
Steps to reproduce
List the precise steps to reproduce the bug:

Go to a page with the RM module and it's settings enabled for user mode and the default directory set to the users directory.
As a non admin user upload a zip file with a directory of some type of image or just a .txt file.
Once uploaded you should see the newly created folder in the user's directory.
Click on the folder
There is no error but you cannot drill down into the folder to view it's contents.

Current behavior
Use can upload zip files with folders with show in the RM but the user cannot access it's contents.
Expected behavior
A user should be able to access the contents of their uploaded zip files which can include a child directory.
Screenshots
Error information
No error.
Additional context
I am assuming that allowing users to create folders in this fashion is acceptable but this may be wrong.
Affected version

[ ] 10.00.00 alpha build
[X ] 09.11.00 release candidate
[ ] 09.10.02 release candidate
[ ] 09.10.01 latest supported release

Affected browser

[X ] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 11
[ ] Microsoft Edge (Classic)
[ X] Microsoft Edge Chromium

After looking a bit more I believe that the RM in user mode should be rendering the tree menu for non admin users.  The folder mapping gear icon would be host/admin only.   It is via the tree menu that users can drill down but if it is not visible they will probably click on the main display folder which doesn't do anything.  This issue may be irrelevant once the tree menu is restored to non admins.

should be rendering the tree menu
This has been fixed but not yet released

mapping gear icon would be host/admin only
Same, has been fixed but not yet released

The rest of this bug report needs to be tested against current codebase

These are looking installation specific so this should be closed.  The GetFolders call is not returning folders for certain installations I am looking at.  I am not sure why yet but it is a non issue for everyone else.  The default installation for DNN doesn't allow .zip files but when I enable it and check on a cleaner install and the updated RM it works as expected.


Update specs2-core to 4.12.4-js-ec

Updates org.specs2:specs2-core from 4.11.0 to 4.12.4-js-ec.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2", artifactId = "specs2-core" } ]

labels: test-library-update, semver-minor

Superseded by #77.


Slim application errors

Slim Application Error
The application could not run because of the following error:
Details
Type: Propel\Runtime\Exception\PropelException
Message: Unable to execute INSERT statement [INSERT INTO pv_activation (id, uid, act_id, act_uuid, expire_time, act_time, user_agent) VALUES (:p0, :p1, :p2, :p3, :p4, :p5, :p6)]
File: /var/www/html/PitchVision-Dev/database/classes/pitchvision/db/pitchvision/Base/PvActivation.php
Line: 1125

That isn't because of Slim, it's because there's an error in the ORM you're using (Propel).


Removed JMX port 9404 already exposed by the base image

Type of change
Select the type of your PR

Bugfix

Description
Remove the JMX port 9404 from Zookeeper Dockerfile because already exposed by the base image. It's not really a bugfix but a really trivial change just to be polite.
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging

@tombentley I don't think it's a problem and we have the issue #101 for adding metrics to Kafka Connect as well.

@scholzj that's a good point. I see your point because we could say the same for the kafka artifacts. The kafka base image just download and provides kafka and jmx exporter artifacts then used in the derived images which should expose the ports (as already happen for kafka and zookeeper). I'll change the other way around. @tombentley do you agree ?

@scholzj @tombentley I did as Jakub suggested but I haven't exposed the JMX port in the Kafka Connect image yet, because we don't have fixed the #101 yet. So the initial @tombentley concern is addressed as well.