Unable to repair corrupted class

OrientDB Version: 3.0.37
Java Version: Oracle JDK 1.8.0_251
OS: Linux CentOS 7
I'm using OrientDB to store IoT metrics. Because I've a high ingestion ratio, I've configure it to switch in read-only mode when storage free space is below 4GB via "storage.diskCache.diskFreeSpaceLimit" property.
Despite this when the DB operate the switch a table (a class) becomes corrupted.
After adding more space and restarting server,  trying to read the last 10 inserted records an exception is logged (the full stack is attached at the end)
[OLocalPaginatedStorage]Exception `21D9DF3B` in storage `plocal:/wos1/orientdb/databases/iot_exp_26a`: 3.0.37 - Veloce (build 6a0e4724c10d51a0b19700fca46da8e41ae006f5, branch 3.0.x)
java.lang.NullPointerException
       at com.orientechnologies.orient.core.storage.cache.chm.AsyncReadCache.releaseFromRead(AsyncReadCache.java:290)
       at com.orientechnologies.orient.core.storage.impl.local.paginated.base.ODurableComponent.releasePageFromRead(ODurableComponent.java:167)
       at com.orientechnologies.orient.core.storage.cluster.v1.OPaginatedClusterV1.internalReadRecord(OPaginatedClusterV1.java:562)
       at com.orientechnologies.orient.core.storage.cluster.v1.OPaginatedClusterV1.readRecord(OPaginatedClusterV1.java:534)
       at com.orientechnologies.orient.core.storage.cluster.v1.OPaginatedClusterV1.readRecord(OPaginatedClusterV1.java:517)
       at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.doReadRecord(OAbstractPaginatedStorage.java:5472)
       at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.readRecord(OAbstractPaginatedStorage.java:2179)

While broken record is skipped on select, a NPE is fired when I try to insert a new record into the table.
CHECK DATABASE command reported no problem. I have however exec REPAIR DATABASE command with no luck.
Corrupted table is a simple class (it doesn't extends vertex or edge) and have mainly simple properties: string, long, embeddedMap of string.
I've also tried to attach the database to latest OrientDB 3.1.x and 3.2.x but no one is able to fix the table.
Table is using a single cluster.
The only way to bypass the problem was a full database export/import into a new one. This action takes hours because the database contains millions of records.
Expected behavior
Have the table corruption  detected and repaired by CHECK DATABASE and REPAIR DATABASE commands.
The ideal solution will be to have a CHECK CLASS and REPAIR CLASS command to focus on the problematic class  and save time (other classes could be bigger than the corrupted one)
Actual behavior
CHECK and REPAIR commands doesn't identify the problem and the table stay corrupted.
Steps to reproduce
I'm unable to programmatically replicate the problem in a newly created database. I've a full copy of the corrupted one I can use to test a fix against.
orientdb-error.txt

I too have the similar problem.
On a restart of system(k8s cluster). OrientDB crashed while loading OSystem DB. To recover, have deleted "OSystem" database and restarted OrientDB. OrientDB started but then it failed to load my database. with following error
 SEVER Exception `<ID>` in storage `plocal:/orientdb/databases/OSystem`: 3.2.18 (build 75890139e2e64b786a59c95b913af9fbb86c5cfc, branch UNKNOWN) [OLocalPaginatedStorage]
com.orientechnologies.orient.core.exception.OStorageException: Exception during execution of atomic operation inside of storage OSystem
	at com.orientechnologies.orient.core.storage.impl.local.paginated.atomicoperations.OAtomicOperationsManager.executeInsideAtomicOperation(OAtomicOperationsManager.java:146)
	at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.open(OAbstractPaginatedStorage.java:531)
	at com.orientechnologies.orient.core.db.OrientDBEmbedded.getAndOpenStorage(OrientDBEmbedded.java:590)
	at com.orientechnologies.orient.core.db.OrientDBEmbedded.openNoAuthorization(OrientDBEmbedded.java:517)
	at com.orientechnologies.orient.core.db.OrientDBEmbedded.openNoAuthorization(OrientDBEmbedded.java:87)
	at com.orientechnologies.orient.core.db.OSystemDatabase.openSystemDatabase(OSystemDatabase.java:86)
	at com.orientechnologies.orient.core.db.OSystemDatabase.checkServerId(OSystemDatabase.java:165)
	at com.orientechnologies.orient.core.db.OSystemDatabase.init(OSystemDatabase.java:153)
	at com.orientechnologies.orient.server.OServer.initSystemDatabase(OServer.java:1147)
	at com.orientechnologies.orient.server.OServer.activate(OServer.java:430)
	at com.orientechnologies.orient.server.OServerMain$1.run(OServerMain.java:49)
Caused by: java.lang.NullPointerException

I tried CHECK DATABASE it did not detect any problems.
REPAIR DATABASE --fix-graph -v failed with following error
orientdb {db=abbodb}> repair database --fix-graph -v
Repair of graph 'plocal:/orientdb/bin/../databases/abbodb' is started ...
Scanning 19950 edges (skipEdges=0)...

Error: java.lang.NullPointerException

orientdb {db=abbodb}>

Any hit to recover database?


Add days 1 and 25

Added solutions with contracts. Fun!

Oops. Needs tests - please hold!

Probably just unlucky, but I think hypothesis-generated args can easily make these functions run for prohibitively long. These are left as TODOs for now.

Btw., if it is not much work, try to record and document the bugs in your implementation that you discovered either with crosshair or with icontract-hypothesis (see the directory recorded_failures). These records are super useful as showcases.

Btw., if it is not much work, try to record and document the bugs in your implementation that you discovered either with crosshair or with icontract-hypothesis (see the directory recorded_failures). These records are super useful as showcases.

Oooh, I missed these. Yeah, I remembered a few bugs along the way and added those. But next time I'll be more ready!

@pschanely are permissions set correctly so that you can merge yourself?

Apparently!


foundations.submit broken

Hi,
I'm using your custom_docker_image to repeat your experiment done on https://www.dessa.com/post/deepfake-detection-that-actually-works. However, the Foundations package I found on pypi does not seem to have a .submit member and I can't find an other foundations module that does contain this member.
It's regarding this section in hparams_search.py.
for job_ in range(NUM_JOBS):     print "packaging job " + str(job_)     hyper_params = generate_params()     print hyper_params     Foundations.submit(scheduler_config='scheduler', job_directory='.', command='main.py', params=hyper_params,                        stream_job_logs=False)

@huang-da I am experiencing the same issue. Could you advise how you resolved this? Thanks


2.5.0

I think this also needs adjusting: https://www.prisma.io/docs/reference/tools-and-interfaces/prisma-client/sorting#can-i-perform-case-insensitive-sorting

Any idea why the netlify preview doesn't work and says "Not Found"?
https://deploy-preview-772--prisma2.netlify.app/

Any idea why the netlify preview doesn't work and says "Not Found"?
deploy-preview-772--prisma2.netlify.app

We renamed the deployment this morning. Can now be found at: https://deploy-preview-772--prisma2-docs.netlify.app/


[Bug] getStoryContext (globalThis) returns undefined

Describe the bug
storyContext is undefined
// test-runner.js
const { getStoryContext } = require("@storybook/test-runner");

module.exports = {
  async postRender(page, context) {
    const storyContext = await getStoryContext(page, context);
    console.log(storyContext) // undefined
    const globalThis = await page.evaluate(() => globalThis);
    console.log(globalThis) // undefined
  },
};

Steps to reproduce the behavior
Use the above file
Expected behavior
To be able to access the storyContext like here https://github.com/storybookjs/test-runner/blob/next/.storybook/test-runner.ts
Screenshots and/or logs
n/a
Environment

OS: mac
Node.js version: Tried both 14 and 16

Additional context
~I think the problem may be because default test-runner-jest.config.js is missing the globalSetup and globalTeardown operations that this repo is using.~ I was wrong about this, test-runner-jest.config.js does get the setup and teardown from getJestConfig.
Could this be because globalThis has been introduced in Jest 28 but we're still on Jest 27?

It turned out that globalThis.__STORYBOOK_PREVIEW__.storyStore.loadStory({ storyId }) contained circular dependencies and Playwright doesn't allow you to return Js objects with circular dependencies, which is why I was getting undefined. I'm not sure where they came from, but I think this would be common. Here's my not-so-elegant solution:
    const storyContext = await page.evaluate(
      async ({ storyId }) => {
        const getCircularReplacer = () => {
          const seen = new WeakSet();
          return (key, value) => {
            if (typeof value === "object" && value !== null) {
              if (seen.has(value)) {
                return;
              }
              seen.add(value);
            }
            return value;
          };
        };

        return JSON.parse(
          JSON.stringify(
            await globalThis.__STORYBOOK_PREVIEW__.storyStore.loadStory({ storyId }),
            getCircularReplacer()
          )
        );
      },
      {
        storyId: context.id,
      }
    );

Oh wow! That's new to me. Thanks a lot for sharing this @VickyKoblinski ! 🙌  I'll have to chew on this for a bit.
cc @shilman

Seeing the same issue, am not able to get this patch to work, @ndelangen any guidance here?

have been getting
page.evaluate: TypeError: Cannot read properties of undefined (reading 'storyStore')
at getStoryContext (node_modules/@storybook/test-runner/dist/cjs/playwright/hooks.js:17:15)

@myufa can you share a reproduction for us to take a look? thanks!

Any update on this?, we're facing this too. Thank you.


Added more information for Shopify Product

Thanks for bootstraping this project! I look forward to working on it. So far I've added more information for Product as well as Variants. As I need more, I'll be adding more Shopify Entities as well as Tests. Let me know if you have any questions or comments.

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #20   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           8      8
  Lines         229    229
=====================================
  Hits          229    229

Impacted Files
Coverage Δ

product.go
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64825aa...54df2fc. Read the comment docs.

@jerairrest Thanks for the contribution :beer:


Enable mTLS for pilot e2e tests

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt
Assign the PR to them by writing /assign @myidpt in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test istio-pilot-e2e

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
9ad34e6fbff3587647e5e2f29e9e123a0016fcb0
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c52237e1950cbb67ca514a355dab87fbcced32a7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c52237e1950cbb67ca514a355dab87fbcced32a7
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
c52237e1950cbb67ca514a355dab87fbcced32a7
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
c52237e1950cbb67ca514a355dab87fbcced32a7
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
c52237e1950cbb67ca514a355dab87fbcced32a7
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
c52237e1950cbb67ca514a355dab87fbcced32a7
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
c52237e1950cbb67ca514a355dab87fbcced32a7
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
48bd7ca0fcc3d2ec0d0420f1270baa011e5e18b0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
48bd7ca0fcc3d2ec0d0420f1270baa011e5e18b0
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
48bd7ca0fcc3d2ec0d0420f1270baa011e5e18b0
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
48bd7ca0fcc3d2ec0d0420f1270baa011e5e18b0
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ef624486537d65bc575655df3c62264a38641287
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
ef624486537d65bc575655df3c62264a38641287
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-bookInfoTests-v1alpha3.sh
ef624486537d65bc575655df3c62264a38641287
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
2ea141b316bbcdc6830c667cd06f23c29a0d7655
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
2ea141b316bbcdc6830c667cd06f23c29a0d7655
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simple

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: andraxylia
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: myidpt
Assign the PR to them by writing /assign @myidpt in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andraxylia, wattli
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [wattli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Confused

Hi,
My lack of understanding and confusing examples leave me to wonder: is there any check being done on the class names at all?? Because
let fii1 = """
<Foo>
    <Bar>
        Hahaha
    <Bar>
</Foo>
"""

type Foor() =
    let mutable bar = Unchecked.defaultof<string>
    member x.Bar
        with get() = bar
        and set(v) = bar <- v

Why does that work? Foor != Foo

Nvm I see it now ><


[api-docs] Tweak application_id wording on message object (#4244)

Tweak application_id wording on message object

Update Channel.md

Co-authored-by: Ian Webster<EMAIL_ADDRESS>

A new commit was made into the api-docs repo.
https://github.com/discord/discord-api-docs/commit/46f028029697051d0897f6d03d24aad3f9e24d84
This is a bot created issue.

application_id? | snowflake | if the message is an Interaction or application-owned webhook, this is the id of the application |

discord update wording, if the message is an interaction OR it's webhook then application_id is the id of the application

#1860


Environment variable app update

Description of the new feature / enhancement
Currently the Environment variable page is very limited for 'readability'.  Things like path are super important as well as understanding order.
Wouldn't it be fanatic if we could

Show path in a more consumable way
Test paths
Filter
Allow items that act like lists to be inserted like lists (Path vs PathExt)

Scenario when this would be used?
When you have to understand why things may be executing oddly: example same executable but different versions being called via terminal
Supporting information

Remove duplicate paths as well, though this is more of a functionality change for cmd.exe's path builtin (since the duplicates may be due to an entry in both system & user paths). Currently I have a lpath.bat that consists of path|tr ";" "\n"|awk "!v[$0]++" (places each entry on a separate line, removes duplicates without reordering).
It would also be useful to know which program placed False \bin in my path...

I think a merge preview would be great where you can see what the results of merging machine and user will be. (Including respecting the naming and value behavior. *)
*) For the name the machine var has priority over user var and vor the value it's the opposite.

@stefansjfw I have looked at the code a bit. You have a copy-paste mistake in signing json: modules\\ColorPicker\\PowerToys.EnvironmentVariables*

modules\ColorPicker\PowerToys.EnvironmentVariables

Nice catch! :) Fixed

@stafansjfw
Are there any special requirements? I have cloned your branch and neither settings, nor env var app is working.

@stefansjfw
Are there any special requirements? I have cloned your branch and neither settings, nor env var app is working.
It looks like a problem with Win App SDK/Runtime. But it is installed.

I also had these problems. I think you need to install it manually and not over the store

@stefansjfw
Are there any special requirements? I have cloned your branch and neither settings, nor env var app is working.
It looks like a problem with Win App SDK/Runtime. But it is installed.

I also had these problems. I think you need to install it manually and not over the store

I didn't installed anything from Store.

@stefansjfw
Are there any special requirements? I have cloned your branch and neither settings, nor env var app is working.
It looks like a problem with Win App SDK/Runtime. But it is installed.

I also had these problems. I think you need to install it manually and not over the store

I didn't installed anything from Store.

I also didn't, but for me this helped: https://github.com/microsoft/WindowsAppSDK/discussions/1933#discussioncomment-1882397_

@stefansjfw
Are there any special requirements? I have cloned your branch and neither settings, nor env var app is working.
It looks like a problem with Win App SDK/Runtime. But it is installed.

I also had these problems. I think you need to install it manually and not over the store

I didn't installed anything from Store.

I also didn't, but for me this helped: https://github.com/microsoft/WindowsAppSDK/discussions/1933#discussioncomment-1882397_

I don't think that the sdk is the problem. Up to date forks/sub branches of the main branch are working.

@htcfreek WinAppSDK 1.1.0-preview1 is used for EnvVar on that branch. Settings app on main uses 1.0.3. Do you have 1.1.0-preview1 installed?

@crutkas
I read somewhere that you started a survey.
I think we should use tabbed view because:

It makes the implementation of the merged results view easier. (For the required code and behavior we can reuse the code from PT Run.)
Having two different areas makes it more clear.
It allows us to handle user and system vars in seperate ways. Then we can let users change the user vars without elevation very easy. (Same as is currently.)

but then you run the problem of a combine view for system and user

@htcfreek Try running EnvVar directly ?

@htcfreek Try running EnvVar directly ?

Same

I've been using  Rapid Environment Editor to manage environment variables and maybe the features of this software can provide some inspiration to PowerToys.

@crutkas , @stefansjfw

We should add a name filter search for long variable lists.
The "add new" dialog should

warn, if the var name already exists.
count the dummy name for new variables like (new), (new 2), ...

The new dialog needs to account for different states (lists for instance) and yes, we need validation

Any progress here?

this isn't planned for 0.62, niels was on vacation, we're still hammering out UI

@crutkas
Any progress updates?

Nope, we still need to nail the UX and due to vacations and people being sick, it has been hard to land.

Updated the UX impression in the original post!

Updated the UX impression in the original post!

@niels9001
Are the applied values only the list of all applied profile vars or is this the list of the currently active variable set/environment? If it is a preview of the current environment you should merge all the variables in the preview.

The work associated with this issue has been released as part of the 0.75 sprint. Please update PowerToys to the latest. https://github.com/microsoft/PowerToys/releases


Question on cyclic dependency in fluent packages

To use any fluent package, it will get start with IAzure interface, which is in Microsoft.Azure.Management.Fluent
https://docs.microsoft.com/en-us/dotnet/api/microsoft.azure.management.fluent.iazure?view=azure-dotnet
But Microsoft.Azure.Management.Fluent depends all other fluent component, that means if user only wants to operate with VM, he'll also need to install Microsoft.Azure.Management.Fluent, and thus all non-VM related packages.
If so, what's the value for splitting those packages? Why not provide a single package to include all, since user has to indeed install all?
Could someone please clarify the design? Please also guide the correct way for using the fluent SDK packages.

You don't have to work with the entire Azure rollup package, if you just need a service-specific subset.
You'd authenticate via that service's specific Manager, e.g.
IComputeManager computeManager = ComputeManager.Authneticate(...);

The corresponding I*Manager exposes only its own subset of resource collections - much less than IAzure.
If you want to pick and choose which manager you want to work with, you need to authenticate with each explicitly, like above.
You can also see some more advanced examples in the tests.
(Note though that some more complex services, such as Compute, have a dependency on some other service packages as well, but far from all that is in the Azure rollup package)

Yeah, that did the trick. Appreciate the help.
It would be nice to have a note in README, since most people will get start there. Current examples are all using IAzure.


Extension support

Bruno should be built with extensibility in mind to allow customization and enhancement of the application. It would be nice to have something similar to what VS Code have

Hey @helloitsm3
Totally onboard with this.
I'd broadly categorise extensions into two kinds.

Theme extensions (Theme Store)
Functionality extensions (Bruno Plugins)

We'll start with supporting Theme extensions and build a theme store, we can use the experience we gain from this and then move on to functionality extensions (which is more complex to design well)
Now before we get started with theme extensions, we need to have a good schema model ready so that theme authors can easily author a team. We must note that its not easy to change this schema (once people publish themes).
So it's very important to get the schema right (as right as possible).
Ive got something decent to start with here. https://github.com/usebruno/bruno/blob/main/packages/bruno-app/src/themes/light.js
This needs to be further refined. Once this is done, we will build some popular themes like monokai, dracula, material etc as support it by default. And after this we will design a system for devs to publish their theme extensions.
A long way to go, Here is how the approx timeline looks like atm

[ ] Ratify theme schema (mid of nov) - want to take sufficient time to ratify this
[ ] Support popular themes (end of nov)
[ ] design system for others to publish theme extensions (dec)
[ ] allow people to publish their own themes (beginning of jan)

Sounds good. I'm happy to discuss this further. How can we go about doing this?

This work ranks lower in priority compared to some of the other features we have in the pipeline like #45 and #46
We just launched the product to public on Oct 17th, I feel its too early to jump into working on extensions before we get some traction.
As is stands today, I look forward to get the theme schema ratified by mid nov 2022 post which we can start working on supporting popular themes.

Theming is being implemented as a part of the Pro Edition of Bruno.
The Pro Edition code is not opensource.
Hence closing this issue.


Add dependency "@types/react-wait"

Fixes #306

Ah, seems we need to export the Waiter component along with the useWait hook because they must be used together. But TypeScript doesn't allow us to set an arbitrary property on a function.
I've pushed a change which exports both values separately.

:tada: This PR is included in version 10.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Nuxt.js] Datepicker stop working on SSR

Overview of the problem
Buefy version: 0.5.1
Vuejs version: 2.4.2
OS/Browser: Mac / Linux
Nuxt.js: 1.0.0-rc8
Description
The datepicker component works perfect in Nuxt until you refresh the page and the page is rendered in the server side, you get navigator is not defined
Steps to reproduce

Add a date picker component into a .vue file
Navigate to that page and verify that the component is working
Refresh page (cmd + R or F5)
:bomb:

Expected behavior
Render the date picker without any error
Actual behavior
Page is not working since navigator is not defined (screenshot below)

It's fixed!
Anyway if you want to use native datepicker, you have to inject current user agent to enable the correct mobile detection because Buefy depends on existence of window.navigator.userAgent to do it.

Lovely, thanks @jtommy!

We've also seen this with a Nuxt.js project and observed a different and somewhat non-sensical error message in the server logs related to the time/date pickers (expected Date, got Date), but wrapping the b-datepicker / b-timepicker component references in   tags resolved the issue.  (The pickers were working fine on the client, just throwing errors in the server log.)
Just an FYI for anyone looking for a workaround.

Thanks @davegriffin but maybe the correct place is this issue https://github.com/buefy/nuxt-buefy/issues

Fair point!  Googling found this first, but I'll make mention of it there as well  (perhaps it can be resolved!)  Thank you!


Rational.hashCode is very slow for small, whole numbers

It seems that Rational.hashCode is less than optimal for small, whole numbers. Here is a little benchmark:
import ichi.bench.Thyme
import spire.math.Rational

object RationalHashCodeBench extends App {
  val a = Rational(1,3)
  val b = Rational(3)
  val th = Thyme.warmed(warmth = Thyme.HowWarm.Bench, verbose = println)
  th.pbenchWarm(th.Warm(a.hashCode), title = s"$a.hashCode")
  th.pbenchWarm(th.Warm(b.hashCode), title = s"$b.hashCode")
}

And the result:
Benchmark for (1/3).hashCode (60 calls in 1.897 s)
  Time:    15.00 ns   95% CI 14.46 ns - 15.54 ns   (n=20)
  Garbage: 0.03576 ns   (n=6 sweeps measured)
Benchmark for (3).hashCode (60 calls in 1.469 s)
  Time:    183.8 ns   95% CI 175.3 ns - 192.3 ns   (n=20)
  Garbage: 1.526 ns   (n=19 sweeps measured)

As you can see, calling hashCode on a whole number <= Long.MaxValue is way slower than it has to be. The reason is that the hashCode method checks if the number is small enough for the unifiedPrimitiveHashcode by converting it to a BigInt, among other things:
  override def hashCode: Int =
    if (isWhole && toBigInt == toLong) unifiedPrimitiveHashcode // toBigInt is wasteful for this check!
    else 29 * (37 * num.## + den.##)

I think a simple override of LongRational.hashCode should fix this. Whole numbers within the range of Long are always represented as LongRational, right? Or is it possible to have e.g. a BigRational(3,1)?

No, you're right, the invariant is that they will always be long rationals.
Great catch! I think your proposed solution is right.

Then it should be possible to override BigRational.hashCode to always do 29 * (37 * num.## + den.##), and LongRational to something like this:
override def hashCode: Int =
  if(d == 1)
    unifiedPrimitiveHashcode
  else
    29 * (37 * num.## + den.##)

, right?

Yes, this looks right to me.


Hugo executable files are gone after adding custom dependencies

Steps to reproduce
yarn add [some package]
I found it while following this article, adding medium-zoom :
https://github.com/gethyas/doks/discussions/545
Description
yarn add command works fine,
but node_modules/gethyas/node_modules/.bin/hugo/* folder disappears after this process
and postinstall command fails.
yarn dev command does not work after this too.
To recover
clean and re-install packages, including node_modules and etc. , resolves the error.
yarn run clean
yarn

Opinion
I think it is better to fix postinstall process/command,
or give specific guide to users who wants to add custom modules to theme.
I'm newbie to Hugo and really like Doks theme. Thanks for reading!
Environment
nodejs: v18.17.1
@hyas/doks-core: 1.0.7
gethyas: 2.2.0

Confirmed — using yarn 1.22.19
I will be looking into this. Please use npm or pnpm for now (or temporarily accept the inconvenience )

Known and (still) an open issue — see https://github.com/yarnpkg/yarn/issues/5476

Linked yarn issue seems to relate with problems that postinstall command is not executed.
In my case, postinstall command works fine.
However, node_modules folder in gethyas module blows up and it fails to copy on root folder's node_modules folder.
yarn add v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning "@hyas/doks-core > gethyas ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@hyas/doks-core > gethyas ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>[5/5] Building fresh packages...
success Saved 1 new dependency.
info Direct dependencies
└─<EMAIL_ADDRESS>info All dependencies
└─<EMAIL_ADDRESS>$ shx rm -rf ./node_modules/.bin/hugo && shx mkdir node_modules/.bin/hugo && shx cp node_modules/gethyas/node_modules/.bin/hugo/* node_modules/.bin/hugo
cp: no such file or directory: node_modules/gethyas/node_modules/.bin/hugo/*
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

I'm not sure that it is possible to ignore node_modules/gethyas/node_modules folder while yarn cleaning process is running, and it can be other options too.

Ignoring in a .yarnclean file doesn't seem to work for me (I tried a few things)
Another option, a bit bold — but it works:
yarn clean:install && yarn

I finally changed to use npm instead of yarn when I'm upgrading Doks to 1.0.7 -> 1.2.0
As mentioned before, no issue when setting up with npm
Hugo also follows it for example:
https://gohugo.io/hosting-and-deployment/hosting-on-github/
It'll be better to specify on documents and other places that npm or pnpm is recommended, not yarn
This issue has been stale for a while by the way, so I'll close this issue.


Profile_card - Akbar Anung Yudha Saputra

Hey @akbarsaputrait !
Thank you for your valuable contribution. As I found, they(Hacktoberfest) are verifying the code in the PR so I recommend that you add your code to a "code folder" as well to avoid any consequences (your code should be in a folder named after you). Sincerely apologize for the inconvenience.

Hallo @DiyaVj Thanks you for reminding me for that. Here are the PR https://github.com/DiyaVj/Profile-Card-Collection/pull/64
I appreciate you✌🏼


Parenthesis symbols with no defined reading.

It seems that pull requests are not accepted, so I will post it as an issue.
The symbols are read as "だぶるみにゅーと", "ののかぎ" or "つめかっこ".
https://github.com/google/mozc/blob/db37db71b53c9accc9ad66d12ad8196b25c771b3/src/data/symbol/symbol.tsv#L535-L536
Perhaps the following places also need to be changed.
https://github.com/google/mozc/blob/db37db71b53c9accc9ad66d12ad8196b25c771b3/src/data/symbol/symbol.tsv#L55-L99
https://github.com/google/mozc/blob/db37db71b53c9accc9ad66d12ad8196b25c771b3/src/data/symbol/categorized.tsv#L166-L167
https://github.com/google/mozc/blob/db37db71b53c9accc9ad66d12ad8196b25c771b3/src/data/symbol/ordering_rule.txt#L39-L59
https://github.com/google/mozc/blob/db37db71b53c9accc9ad66d12ad8196b25c771b3/src/base/util.cc#L1012-L1023
https://github.com/google/mozc/blob/db37db71b53c9accc9ad66d12ad8196b25c771b3/src/base/util_test.cc#L913-L932
Sorry if there are any omissions.

Hi mikunimaru,
Thank you for your suggestion and sorry for our late response.
We are going to update the entries based on your suggestions.
Thank you for your feedback.

https://github.com/google/mozc/commit/4610acaa4b7292efc43566d3f2567cf48473c946 added data for 〝〟 based on your suggestions.
Thank you!

Thanks for the great solution.
Conversion from brackets is also possible and has become very convenient.
https://github.com/google/mozc/blob/4610acaa4b7292efc43566d3f2567cf48473c946/src/base/util.cc#L932-L941
I have a feeling that this part of the code also needs a symbol.

Thanks for the great solution. Conversion from brackets is also possible and has become very convenient.
https://github.com/google/mozc/blob/4610acaa4b7292efc43566d3f2567cf48473c946/src/base/util.cc#L932-L941
I have a feeling that this part of the code also needs a symbol.

Very sorry. I tried to fix that part, but it didn't solve the issue.


Bug Report - Unable to deploy Deploy-MDFC-Config v3.1.0 over top of an existing v3.0.0 deployment

Unable to deploy Deploy-MDFC-Config v3.1.0 over top of an existing v3.0.0 deployment.
Getting the following error code when I attempt to deploy that latest master commit of ALZ-Bicep into a tenant which has previously deployed an older version of ALZ-Bicep.  Seems like none of the parameters have defaults so perhaps this isn't a bug, but I'm now left wondering what the processes is to deploy updates?
{"code":"DeploymentFailed","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.","details":[{"code":"InvalidPolicySetParameterUpdate","message":"The policy contains new parameter(s) 'enableAscForCosmosDbs' which are not present in the existing policy and have no default value. New parameters may be added to a policy only if they have a default value."}]}
To Reproduce
Steps to reproduce the behaviour:

Checkout ALZ-Bicep Repo @ v0.10.6 tag
Run:  az deployment mg create --name alz-policy --management-group-id $(targetManagementGroupId) --location $(targetLocation) --template-file "$(alz-repo-dir)/infra-as-code/bicep/modules/policy/definitions/customPolicyDefinitions.bicep"  --parameters "$(alz-repo-dir)/infra-as-code/bicep/modules/policy/definitions/parameters/customPolicyDefinitions.parameters.all.json" --parameters parTargetManagementGroupId=$(targetManagementGroupId)
Checkout Latest ALZ-Bicep Repo @ v0.11.0
Run:  az deployment mg create --name alz-policy --management-group-id $(targetManagementGroupId) --location $(targetLocation) --template-file "$(alz-repo-dir)/infra-as-code/bicep/modules/policy/definitions/customPolicyDefinitions.bicep"  --parameters "$(alz-repo-dir)/infra-as-code/bicep/modules/policy/definitions/parameters/customPolicyDefinitions.parameters.all.json" --parameters parTargetManagementGroupId=$(targetManagementGroupId)

Expected behaviour
Be able to deploy updated ALZ-Bicep policies by simply running the command documented here:  https://github.com/Azure/ALZ-Bicep/tree/main/infra-as-code/bicep/modules/policy/definitions#azure-cli
Screenshots 📷

Thanks for raising @jim-mclean we are aware and have made the fix this morning upstream. We will be pulling it into this repo pretty soon. Hopefully by end of the week, just wrapping a few other bits in it as well.

Thanks @jtracey93!


Unoptimized APK at play store

With your android exemple I'm blocked with play store at:
Unoptimized APK
Warning:
This APK results in unused code and resources being sent to users. Your app could be smaller if you used the Android App Bundle. By not optimizing your app for device configurations, your app is larger to download and install on users' devices than it needs to be. Larger apps see lower install success rates and take up storage on users' devices.
Resolution:
Use the Android App Bundle to automatically optimize for device configurations, or manage it yourself with multiple APKs.

Hi,
Qt doesn't support building App Bundles at the moment. It will be possible in the 5.14 releases. (see QTBUG-68202)
For now, you can safely ignore this warning, which is not a blocker.

Then I will wait you version 5.14, thanks for your greate jobs

Any plan for android arm64_v8a and 5.14?


[magnum/magnum-plugins] Fix patches for --head builds

Hi all!
I updated the magnum and magnum-plugins portfiles to work with current HEAD.
As per usual the maintainer of Magnum, @mosra, will quickly review and approve the PR.
Best,
Jonathan

@JackBoosY Thank you for the review!
I made changes accordingly. Please have another look.

@Squareys Don't forget to update version info : )
Documentation.

@JackBoosY Ah, right, thanks! 🙏
Done with latest commit.

And magnum-plugins version update?

Yes, sorry, @mosra just pinged me on that, too. Totally forgot I had changed that aswell 🙄

LGTM, we need to test all features.

Build failure with magnum[al-info,anyimageimporter,anyaudioimporter,anyimageconverter,anysceneimporter,audio,debugtools,distancefieldconverter,fontconverter,gl,gl-info,glfwapplication,imageconverter,magnumfont,magnumfontconverter,meshtools,objimporter,tgaimageconverter,opengltester,primitives,sdl2application,scenegraph,shaders,text,texturetools,tgaimporter,trade,wavaudioimporter,windowlesswglapplication,eglcontext,cglcontext,glxcontext,wglcontext,windowlesseglapplication,eglcontext,windowlessglxapplication]:x86-windows:
CMake Error at src/Magnum/Platform/CMakeLists.txt:515 (message):
  X11 library, required by some applications, was not found.  Set
  WITH_*X*APPLICATION to OFF to skip building them.

Looks like you forgot to pass in the following parameters:
CORRADE_TARGET_UNIX          - Defined if compiled for some Unix flavor
CORRADE_TARGET_APPLE         - Defined if compiled for Apple platforms
CORRADE_TARGET_IOS           - Defined if compiled for iOS (device or
CORRADE_TARGET_IOS_SIMULATOR - Defined if compiled for iOS Simulator
CORRADE_TARGET_WINDOWS       - Defined if compiled for Windows
CORRADE_TARGET_WINDOWS_RT    - Defined if compiled for Windows RT
CORRADE_TARGET_EMSCRIPTEN    - Defined if compiled for Emscripten
CORRADE_TARGET_ANDROID       - Defined if compiled for Android

@JackBoosY The magnum port has platform dependent features, e.g. windowlessglxapplication. If you build [*], then all are included. We have an open PR on that https://github.com/mosra/magnum/pull/368, but didn't come to a consensus on how this should behave.
Do you have a suggestion?
CC @mosra

The inability to use [*] is a separate problem that needs a dedicated solution from our side and due to time constraints we weren't able to resolve that yet. @JackBoosY Would it be possible to merge this as-is?
The build should work on Windows if you install magnum[al-info,anyimageimporter,anyaudioimporter,anyimageconverter,anysceneimporter,audio,debugtools,distancefieldconverter,fontconverter,gl,gl-info,glfwapplication,imageconverter,magnumfont,magnumfontconverter,meshtools,objimporter,tgaimageconverter,opengltester,primitives,sdl2application,scenegraph,shaders,text,texturetools,tgaimporter,trade,wavaudioimporter,windowlesswglapplication,wglcontext] (i.e., with eglcontext, cglcontext, glxcontext, windowlesscglapplication, windowlesseglapplication, windowlessglxapplication, which are Linux- and macOS-specific, omitted).

@Squareys If some features are not supported by some triplets, you should add error message in portfile.cmake before vcpkg_configure_cmake.
Such as:
if ("eglcontext" IN_LIST FEATURES AND NOT VCPKG_TARGET_IS_WINDOWS)
    message(FATAL_ERROR "Feature eglcontext only support windows")
endif()

Okay, we'll need to roll out our own FindOpenAL that correctly links to winmm on Windows (or uses the exported OpenAL Soft CMake config), the builtin CMake module doesn't. Is that a blocker for this PR? This issue was there probably since ever.
Good idea with the FATAL_ERROR.

@mosra Yes, we need all features to be successfully tested.

@mosra @Squareys @JackBoosY It is okay if not all features are passing. We just don't want to introduce any additional failures (which is why we test all the features). Since this feature combination seems to have been failing since the beginning, I would be OK with merging this PR.

@dan-shaw Okay.


Send update event only if http client is ready

Change controller's behaviour to only send update reports if http client is ready.
Current behaviour doesn't make sense to me. We're sending update reports always, just because httpClient can, no matter if any jars changed. But when some jars do change, we want to send it, even though client can't send it.

Changed PR to only send data if client is ready AND there are jars to send.


refactor: decouple object methods into reusable primitives

Decouples object methods into standalone primitives to enable usage in restricted environments without async and SystemTime, like ZKVMs. This allows critical functions (e.g., verify_update) to run in synchronous ZK proving environments, facilitating on-chain verification of beacon chain state.

Addressed comments & CI. One notable change was going from .clone() to clone_from() to make clippy happy here: https://github.com/succinctlabs/helios/blob/6e0e4f122038d8b570f9c5af9a834c79ec597c29/consensus-core/src/consensus_core.rs#L149-L155


telegram group chat open

i am working on project where i need to open the community group of telegram as i work i can only open the individually chat but i need to open the community group how can i open that
can you please guide me
Thanks in advance

You may just open link to that group using url_launcher package.


Extendable builders (better types)

Coverage remained the same at 92.223% when pulling 0e5b493bbdd9c04dee202433e22708d6ada6eb7a on DominicVonk:master into 84af57a9f641b81fbd174253f38b81c66aba0f6a on knex:master.

@OlivierCavadenti Hi, this is a pull request to fix the types in typescript (when we alter them)


Review the use of the attribute @CONTENTTYPESPECIFICATION

If we have more than one representation, the proposed vocabulary does not make sense. For example, we can have an AIP with two representations with a SIARD2 and a SIARD2.1.

I agree with Miguel.
Even if we say that this attribute should only be at representation level, then there can be scenarios where the representation also contain several content information types (It could be an ERMS submitted as a relational database, or a relational database with geodata or any other combo.)
Regarding Content Information Type as a vocabulary or classification we must be cautious about how we treat:

the  mutual exclusiveness of categories ( can one object only be placed in one category within the whole classification universe) ?
collectively exhaustivity (an object must be able to be placed in a meaningful category in the classification universe) ?

If we use an attribute to determine "what kind" a representation is, then we lock ourselves in a way that there is (or should be) a classification universe. I don't think we are anywhere near to be able to create such a universe and nor do we have the resources or plan to maintain it.
I suggest that Content Information Type should be described as free text in an element. Then the different Content Information Type Specifications specify what the specific value should be within this element.

More investigation needed. Connected with #10

Vocabulary contains both values MIXED and OTHER so all possibilities of describing the content is present.


Multiple additions

adding reduceRight
adding some
adding every
adding findIndex
adding size
adding Object.assign
adding now
adding templates

Thank you @AutoSponge! :+1:


Update Java version from 1.8 to 1.11

Update Java version to 11

[ ]  create branch "dev"
[ ]  open pom.xml
[ ]  change "maven.compiler.source" and "maven.compiler.target" to 11
[ ]  create a pull request and merge changes to "main"

Changed status to in-progress


Live Auctions Logo Questions

Looking at this:

We don't have any images that would work in the space where it says Christies ATM. Should this be a small display name in garamond, or would it work better as the square profile image we use in the sale information VC?

@orta as you can (hopefully) see in the spec that's not their logo it's just type, at size 17px I think. It's just the partner name only.

:+1:


Running TFLite model with custom operations

Hi!
Can Firebase MLKit run TfLite models with custom operations?
The provided examples use models with built in operations but not models with custom ops.
For example, the smartreply model has 3 custom operations which gives an error while loading the Model using MLKit.
Stacktrace :
 W/System.err: Caused by: com.google.firebase.ml.common.FirebaseMLException: Internal error has occurred when executing Firebase ML tasks
        at com.google.android.gms.internal.firebase_ml.zzgp.zza(Unknown Source:15)
    	... 5 more
    Caused by: java.lang.IllegalArgumentException: Cannot create interpreter: Didn't find custom op for name 'Normalize'
07-23 18:01:16.018 21726-21726/io.github.the_dagger.mlkit W/System.err: Didn't find custom op for name 'ExtractFeatures'
    Didn't find custom op for name 'Predict'
    Registration failed.
        at org.tensorflow.lite.NativeInterpreterWrapper.createInterpreter(Native Method)
        at org.tensorflow.lite.NativeInterpreterWrapper.<init>(NativeInterpreterWrapper.java:63)
        at org.tensorflow.lite.NativeInterpreterWrapper.<init>(NativeInterpreterWrapper.java:51)
        at org.tensorflow.lite.Interpreter.<init>(Interpreter.java:90)
07-23 18:01:16.019 21726-21726/io.github.the_dagger.mlkit W/System.err:     at com.google.android.gms.internal.firebase_ml.zzhn.zzey(Unknown Source:102)
        at com.google.android.gms.internal.firebase_ml.zzha.zzfb(Unknown Source:75)
        at com.google.android.gms.internal.firebase_ml.zzha.call(Unknown Source:0)
        at com.google.android.gms.internal.firebase_ml.zzgp.zza(Unknown Source:0)
07-23 18:01:16.020 21726-21726/io.github.the_dagger.mlkit W/System.err: 	... 5 more
07-23 18:01:21.529 21726-21733/io.github.the_dagger.mlkit I/zygote64: Do partial code cache collection, code=123KB, data=88KB
07-23 18:01:21.530 21726-21733/io.github.the_dagger.mlkit I/zygote64: After code cache collection, code=123KB, data=88KB
    Increasing code cache capacity to 512KB

The relevant code can be found here :
https://github.com/the-dagger/MLKitAndroid/blob/master/app/src/main/java/io/github/the_dagger/mlkit/activity/SmartReplyActivity.kt
P.S. Docs here outline that I should write native code for custom operations to be used with TFLite but I couldn't find a way on doing it with ML Kit.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/lite/g3doc/custom_operators.md
Thanks!

@samtstern Managed to resolve this issue by building a custom tflite build with source code for the missing custom operations (yes, I enjoyed my weekend).
Using a custom build resolved this issue, but presented me with another issue which I am clueless about.
07-29 00:14:07.340 6489-6489/? W/System.err:     at com.google.android.gms.internal.firebase_ml.zzgq.run(Unknown Source:4)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.os.HandlerThread.run(HandlerThread.java:65)
    Caused by: java.lang.IllegalArgumentException: DataType error: DataType 5 is not recognized in Java (version 3)
        at org.tensorflow.lite.DataType.fromNumber(DataType.java:54)
        at org.tensorflow.lite.Tensor.<init>(Tensor.java:211)
        at org.tensorflow.lite.Tensor.fromHandle(Tensor.java:32)
        at org.tensorflow.lite.NativeInterpreterWrapper.getInputTensor(NativeInterpreterWrapper.java:245)
        at org.tensorflow.lite.NativeInterpreterWrapper.run(NativeInterpreterWrapper.java:110)
        at org.tensorflow.lite.Interpreter.runForMultipleInputsOutputs(Interpreter.java:168)
        at com.google.android.gms.internal.firebase_ml.zzho.runForMultipleInputsOutputs(Unknown Source:2)
        at com.google.android.gms.internal.firebase_ml.zzhn.zza(Unknown Source:459)
        at com.google.android.gms.internal.firebase_ml.zzhn.zza(Unknown Source:2)
        at com.google.android.gms.internal.firebase_ml.zzgu.call(Unknown Source:15)
        at com.google.android.gms.internal.firebase_ml.zzgp.zza(Unknown Source:0)
    	... 5 more

I'm using the smartreply tfLite model which expects input as a String, but the default datatypes in TFLite only support FLOAT,INT,BYTE and LONG.

The default example over in the docs uses image detection which works well with INPUT_TYPE set to BYTE, but there's no explanation whatsoever for String inputs.
@isaisachen @gkaldev any leads would be appreciated!

@the-dagger thank you for the update!  That's super cool that you managed to get a custom build going, let's see if I can find someone about that DataType 5 issue.

@the-dagger Thanks. Awesome that you got to build your own custom TFLite, which is needed if you want to have custom TFLite Ops.
You are right that String is not natively supported in MLKit at the moment. We should be able to add that. Let me try to get back to if we can find a workaround in the mean time using existing types.

@psanketi @samtstern Thanks for the update!
I opened a (similar issue)[https://github.com/tensorflow/tensorflow/issues/21213] on TFLite github repo as well since on exploring further it turns out that even the TfLite data type only supports 4 data types.
Turns out that it currently doesn't support dynamic/static String input and output and this is something that's on the team's radar.
@psanketi Would it be possible to hack around and modify the current custom op that accept a String input to accept a Byte array instead?
I tried this but that ended up with the same DataType 5 error.

@the-dagger Thanks for reporting.
As @psanketi and @jdduke responded earlier, String is not well supported in Java APIs. It's only supported with C++ API.
Could you describe your planned use case? As of now, if you want to keep using Java APIs (ML Kit or TF Lite), you will have to modify ops to do data parsing and normalizing yourself:

The open-sourced smart reply implementation uses string_utils here which populates a String Tensor w/ pre-defined protocol.
ML Kit is expecting fixed output dimension which is not the case for smart reply.

All above doesn't sound like worth the effort.
If you just want to model against smart reply and implement some new custom model yourself, I'd suggest using TFLite C++ API directly. Smart Reply TFLite integration code is here

Hi @isaisachen thanks for the detailed explanation, it makes sense now.
As for the user case, I was just playing around with the given models in an attempt to implement the upcoming MLKit API for smart reply myself using the smart reply model.
I can do it using the C++ APIs, but I wanted to use it with Firebase MLKit for a blog I was planning to write on the same.
But anyways, I have decided to use a different model for the blog for now, will wait for the Java APIs to support String input/output.
@psanketi Do let me know in case you stumble upon any workaround for this using the Java APIs and built in APIs.
Thanks!

@the-dagger I see. Cool. Could you shoot a quick email to @samtstern? It's listed on his profile. Thanks.

@the-dagger just so you know, your comments have spawned some really productive internal conversations about how we can support use cases like yours in the future.  No concrete plans, just want to say thanks for pushing us in the right direction.

@samtstern @isaisachen you're welcome, glad to be useful.

We've got some feature requests and bugs filed internally for this discussion.  Going to close it here as there's nothing we can do in this repo in the short/medium term.  Will update if I hear anything!

Since I couldn't find a good guide that outlined building a TensorFlow Lite build with custom Operations, I went ahead wrote one.
https://heartbeat.fritz.ai/compiling-a-tensorflow-lite-build-with-custom-operations-cf6330ee30e2
Will probably help others who stumble upon this issue :slightly_smiling_face:

@samtstern
Hi Sam,
I am currently trying to implement smart replies using the ML Kit SmartReply model in Python so that it can be used in Django application. I was able to get the tflite model file from the sample android project but could not find the custom ops header files used for that model.
I was planning to build a wrapper library using PyBind to create a stand-alone CPython shared library similar to this.
I could easily find the header files for the model from TensorFlow site  but that model seems to be a different one.
Q-
Could you please tell me where can I find the header files for the custom ops for the ML Kit model?
Thank you!


[SPARK-41376][CORE][3.3] Correct the Netty preferDirectBufs check logic on executor start

What changes were proposed in this pull request?
Backport #38901 to branch-3.3.
Fix the condition for judging Netty prefer direct memory on executor start, the logic should match org.apache.spark.network.client.TransportClientFactory.
Why are the changes needed?
The check logical was added in SPARK-27991, the original intention is to avoid potential Netty OOM issue when Netty uses direct memory to consume shuffle data, but the condition is not sufficient, this PR updates the logic to match org.apache.spark.network.client.TransportClientFactory
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual testing.

Merged to branch-3.3. Thank you, @pan3793 .


No support for international keyboards with dead keys

Hi, I'm having a problem with typing some characters in my terminal, such as ~, " and '. It happens because I'm using a EN-US keyboard with dead keys. It just won't type those characters.
OS: MacOS 10.13.2
Extraterm: v0.35.2

Keyboard and shortcuts handling will be getting some attention after the next Extraterm release.

Iv'e tested all 3 platforms which Extraterm runs on, Windows 10 and Linux work fine with dead keys and variations on the latin alphabet. Dead keys don't work correctly on macOS.


Update color to match default theme embed background

Updates messageEmbed color to match the default theme background.
This might improve the look of the bot messages. You could also try #36393f
Link to relevant reddit thread... https://www.reddit.com/r/discordapp/comments/9l0l0m/the_new_colorless_embedded_messages_look_lit/
Fixes #6

Looks way better now!


Wrong download link in module.json

Hey
I think the module.json for 3.1.3 has a mixup in the download link.
The url still points to the zip for version 3.1.2 instead of 3.1.3 leading to an infinite update loop.
Cheers and thanks for all the work!

🤦🏻

Pushing 3.1.4 now.


WFLY-4658,WFLY-3449 merge Jipijapa source into WildFly (removed Hibernate 3.x) and add test for packaging Hibernate 4.1.x jars with deployment

Linux Build 6517 is now running using a merge of 8926aced4d012541ef53836addb96211e3dc424e

Windows Build 1595 is now running using a merge of 8926aced4d012541ef53836addb96211e3dc424e

Linux with security manager Build 1423 is now running using a merge of 8926aced4d012541ef53836addb96211e3dc424e

Linux with security manager Build 1423 outcome was SUCCESS using a merge of 8926aced4d012541ef53836addb96211e3dc424e
Summary: Tests passed: 829, ignored: 319 Build time: 0:06:03

Windows Build 1595 outcome was SUCCESS using a merge of 8926aced4d012541ef53836addb96211e3dc424e
Summary: Tests passed: 2863, ignored: 374 Build time: 0:55:14

Linux Build 6517 outcome was FAILURE using a merge of 8926aced4d012541ef53836addb96211e3dc424e
Summary: Tests failed: 2 (2 new), passed: 2860, ignored: 374, muted: 1 Build time: 0:56:07
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.jca.moduledeployment.InflowFlatTestCase.testRegistryConfiguration: <no details avaliable>

org.jboss.as.test.integration.jca.moduledeployment.InflowFlatTestCase.testMetadataConfiguration: <no details avaliable>

Linux Build 6520 is now running using a merge of 7990428f13844519f5cda662319aa66f8ddbb980

Linux with security manager Build 1426 is now running using a merge of 7990428f13844519f5cda662319aa66f8ddbb980

Windows Build 1598 is now running using a merge of 7990428f13844519f5cda662319aa66f8ddbb980

Linux with security manager Build 1426 outcome was SUCCESS using a merge of 7990428f13844519f5cda662319aa66f8ddbb980
Summary: Tests passed: 829, ignored: 319 Build time: 0:05:59

Windows Build 1598 outcome was FAILURE using a merge of 7990428f13844519f5cda662319aa66f8ddbb980
Summary: Tests failed: 1 (1 new), passed: 2866, ignored: 374 Build time: 0:49:36
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.clustering.cluster.ejb.stateful.StatefulFailoverTestCase(SYNC-tcp).simpleFailover: <no details avaliable>

Linux Build 6520 outcome was SUCCESS using a merge of 7990428f13844519f5cda662319aa66f8ddbb980
Summary: Tests passed: 2865, ignored: 374, muted: 2 Build time: 0:53:25

Linux with security manager Build 1457 is now running using a merge of 6e2b633d4053146e6d8810e6277982a464258b85

Windows Build 1629 is now running using a merge of 6e2b633d4053146e6d8810e6277982a464258b85

Linux Build 6552 is now running using a merge of 6e2b633d4053146e6d8810e6277982a464258b85

Linux with security manager Build 1457 outcome was SUCCESS using a merge of 6e2b633d4053146e6d8810e6277982a464258b85
Summary: Tests passed: 829, ignored: 319 Build time: 0:05:13

Linux Build 6552 outcome was SUCCESS using a merge of 6e2b633d4053146e6d8810e6277982a464258b85
Summary: Tests passed: 2866, ignored: 374, muted: 1 Build time: 0:46:40

Windows Build 1629 outcome was SUCCESS using a merge of 6e2b633d4053146e6d8810e6277982a464258b85
Summary: Tests passed: 2867, ignored: 374 Build time: 0:47:16

Windows Build 1672 is now running using a merge of 85fb7cc636e6a224789445749580aabedfb73911

Linux with security manager Build 1500 is now running using a merge of 85fb7cc636e6a224789445749580aabedfb73911

Linux Build 6596 is now running using a merge of 85fb7cc636e6a224789445749580aabedfb73911

Linux with security manager Build 1500 outcome was SUCCESS using a merge of 85fb7cc636e6a224789445749580aabedfb73911
Summary: Tests passed: 829, ignored: 319 Build time: 0:06:05

Windows Build 1672 outcome was SUCCESS using a merge of 85fb7cc636e6a224789445749580aabedfb73911
Summary: Tests passed: 2867, ignored: 374 Build time: 0:48:00

Linux Build 6596 outcome was FAILURE using a merge of 85fb7cc636e6a224789445749580aabedfb73911
Summary: Tests failed: 1 (1 new), passed: 2866, ignored: 374 Build time: 0:49:09
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.timerservice.mgmt.NonPersistentCalendarTimerManagementTestCase.testResourceExistence: <no details avaliable>

Just rebased

Linux Build 6597 is now running using a merge of 1efff2b5439cd3e7b9cca30d96ca84cc04984de9

Windows Build 1673 is now running using a merge of 1efff2b5439cd3e7b9cca30d96ca84cc04984de9

Linux with security manager Build 1501 is now running using a merge of 1efff2b5439cd3e7b9cca30d96ca84cc04984de9

Linux with security manager Build 1501 outcome was SUCCESS using a merge of 1efff2b5439cd3e7b9cca30d96ca84cc04984de9
Summary: Tests passed: 836, ignored: 320 Build time: 0:05:02

Windows Build 1673 outcome was SUCCESS using a merge of 1efff2b5439cd3e7b9cca30d96ca84cc04984de9
Summary: Tests passed: 2878, ignored: 375 Build time: 0:47:50

Linux Build 6597 outcome was SUCCESS using a merge of 1efff2b5439cd3e7b9cca30d96ca84cc04984de9
Summary: Tests passed: 2877, ignored: 375, muted: 1 Build time: 0:49:21

Windows Build 1709 is now running using a merge of 380cebbfcdea0d9032808641d8bc7119408e544a

Linux with security manager Build 1536 is now running using a merge of 380cebbfcdea0d9032808641d8bc7119408e544a

Linux Build 6632 is now running using a merge of 380cebbfcdea0d9032808641d8bc7119408e544a

Linux with security manager Build 1536 outcome was SUCCESS using a merge of 380cebbfcdea0d9032808641d8bc7119408e544a
Summary: Tests passed: 836, ignored: 320 Build time: 0:05:25

Linux Build 6632 outcome was SUCCESS using a merge of 380cebbfcdea0d9032808641d8bc7119408e544a
Summary: Tests passed: 2887, ignored: 375, muted: 1 Build time: 0:47:21

Windows Build 1709 outcome was SUCCESS using a merge of 380cebbfcdea0d9032808641d8bc7119408e544a
Summary: Tests passed: 2888, ignored: 375 Build time: 0:47:50

Windows Build 1711 is now running using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02

Linux Build 6634 is now running using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02

Linux with security manager Build 1538 is now running using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02

Linux with security manager Build 1538 outcome was SUCCESS using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02
Summary: Tests passed: 837, ignored: 320 Build time: 0:05:48

Windows Build 1711 outcome was FAILURE using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02
Summary: Tests failed: 1 (1 new), passed: 2872, ignored: 375 Build time: 0:47:45
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.clustering.cluster.ejb.stateful.StatefulFailoverTestCase(SYNC-tcp).failoverOnStop: <no details avaliable>

Linux Build 6634 outcome was SUCCESS using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02
Summary: Tests passed: 2873, ignored: 375 Build time: 0:50:00

retest this please

Windows Build 1760 is now running using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02

Linux with security manager Build 1587 is now running using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02

Linux Build 6686 is now running using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02

Linux with security manager Build 1587 outcome was FAILURE using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02
Summary: Exit code 1 (new) Build time: 0:00:25
Build problems:
Process exited with code 1

Linux Build 6686 outcome was FAILURE using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02
Summary: Exit code 1 (new) Build time: 0:00:44
Build problems:
Process exited with code 1

Windows Build 1760 outcome was FAILURE using a merge of 121e675567439ee2541b5beb7daff6ab18ecaf02
Summary: Exit code 1 (new) Build time: 0:01:16
Build problems:
Process exited with code 1

will rebase to sync up with latest master

Linux with security manager Build 1605 is now running using a merge of c910e1f194d861f7d13d5b7cda386989b9dbf58f

Windows Build 1778 is now running using a merge of c910e1f194d861f7d13d5b7cda386989b9dbf58f

Linux Build 6704 is now running using a merge of c910e1f194d861f7d13d5b7cda386989b9dbf58f

Linux with security manager Build 1605 outcome was SUCCESS using a merge of c910e1f194d861f7d13d5b7cda386989b9dbf58f
Summary: Tests passed: 841, ignored: 322 Build time: 0:05:35

Linux Build 6704 outcome was SUCCESS using a merge of c910e1f194d861f7d13d5b7cda386989b9dbf58f
Summary: Tests passed: 2877, ignored: 377, muted: 1 Build time: 0:45:55

Windows Build 1778 outcome was SUCCESS using a merge of c910e1f194d861f7d13d5b7cda386989b9dbf58f
Summary: Tests passed: 2877, ignored: 377, muted: 1 Build time: 0:48:02

@Sanne asked about getting Hibernate ORM 5.0 into WildFly 10, I have another local change based on this PR to do that.  Any ETA on merging this pr, so we can push on getting ORM 5 into WF 10?


[Accessibility] Audio Cues doesn't work in web editor

CC @isidorn:
Version: 1.66.0-insider
Commit: 521a3d858570ebc9ce9d5602802f4525a02e045c
Date: 2022-03-29T07:32:43.053Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.75 Safari/537.36
Reproducible steps

Run Help: List Audio Cues and see if you hear any audio cues.
It does not work.

Vào 08:50, T.2, 11 Th4, 2022 JooYoung Seo @.***> đã
viết:

CC @isidorn https://github.com/isidorn:
Version: 1.66.0-insider
Commit: 521a3d8
https://github.com/microsoft/vscode/commit/521a3d858570ebc9ce9d5602802f4525a02e045c
Date: 2022-03-29T07:32:43.053Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36
(KHTML, like Gecko) Chrome/100.0.4896.75 Safari/537.36
Reproducible steps

Run Help: List Audio Cues and see if you hear any audio cues.
It does not work.

—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/147190, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXWFI3WVIAESHZ5RJE2GQBTVEOAOHANCNFSM5TBWHHAQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

We forgot to test that feature indeed for vscode web.
That's the error:

Refused to load media from 'https://vscodeweb.azureedge.net/insider/521a3d858570ebc9ce9d5602802f4525a02e045c/out/vs/workbench/contrib/audioCues/browser/media/error.opus' because it violates the following Content Security Policy directive: "media-src 'none'".

Has this issue been resolved? I still don't hear audio cues in the latest GitHub VSCode insider.

I just tried with https://insiders.vscode.dev/ which contains the fix and I can still reproduce the problem. Folded areas do not produce a sound for me. Let me reopen and @hediet can also double check on his machine.

Hmm, it actually works on my machine. @isidorn can you clear all caches and try again?

@hediet I just cleared caches and tried in a new incognito window and still does not work - weird. My steps

insiders.vscode.dev
Open folder locally -> choose vscode
Set that error audio cues get read
Open cglinceses.json top level, there are a bunch of errors and none produce a sound when navigating on that line

I might be doing something wrong.
@jooyoungseo can you repro with insiders.vscode.dev?

@isidorn can you try out the help command for audio cues?

@hediet yup I can reproduce with the help command. Here's an error from the dev console
Error while playing sound DOMException: Failed to load because no supported source was found.
playSound @ audioCueService.ts:77

After updating all my browsers, it works for me in the latest chrome, firefox and edge.
However, safari does not seem to support opus. Maybe we should provide a mp3 file for unsupported browsers?

@deepak1556 can we control what audio files work for electron?
Otherwise we would have to ship different audio files based on if we are in electron or web.

Current builds only supports the following non-proprietary codecs

.opus
.webm (encoded with opus codec, the default encoding with vorbis codec is not supported)
.flac

We can get support for proprietary codecs, but we would have to go through some CELA loop before it can be shipped. It has been a while so I don't know the exact steps. I can ask around MS-Teams runtime folks who might be familiar with shipping proprietary codecs.

Assigning to August since we will be able to use mp3 soon.
@hediet I have reached out to the sound designer so he provides all the audio cues in mp3.

We will no longer ship the opus codec in the next release. So the change to mp3 is a must do :)
Our sound designer confirmed he will provide sounds in mp3 next week.

Deepak has updated electron so this should be possible now.
And the sound designer has provided MP3 files for these sounds.

@isidorn -- Thanks for the update, but the Audio Cues does not work in github.dev. It's working in vscode.dev though. Does it take some time for github.dev?

@jooyoungseo yeah, github.dev updates a bit slower than vscode.dev. I expect that they will pick up the update in the next couple of weeks.
Glad to hear you are using vscode.dev. Do let us know if you have any other feedback regarding it. Thanks!

@isidorn -- Aw, I see. Thanks for your prompt reply. I will keep checking github.dev update, and will keep you posted.

@isidorn -- Please correct me if I am wrong, but github.dev still does not support the audio cues while it seems to have picked up the update.

Aw, I see. @isidorn, thanks for investigating this. I will wait some more weeks then.

Seeing the same error as above

fyi @joaomoreno since I think the fixed it the last time and might have more context.

@bpasero Can you check if the recent changes to CSP caused this to regress?

Oh 🤦 , yeah its the removal of https:.

PR up: https://github.com/microsoft/vscode-dev/pull/879

works in safari

@Jooyoungseo has reported this still doesn't work on Chrome, which is an important issue

I just tried and audio cues work for me both in Chrome and Edge. Here are my steps:

Open vscode.dev
F1 > list audio cues
Navigate through them -> hear sound ✅

@meganrogge can you reproduce the issue?

Able to reproduce in github.dev with the error message:
5Refused to load media from '<URL>' because it violates the following Content Security Policy directive: "media-src <URL>
            <URL>".

@meganrogge that is not under our control though, GitHub controls the content security policy, they will have to do a similar change as we did: https://github.com/microsoft/vscode-dev/pull/879/files

@bpasero is there a github.dev repo where we can go and file an issue for this, so we mark this as upstream?

@isidorn I would talk to @jkeech or Gideon Cheruiyot.
All I know is the Codespaces repo: https://github.com/github/codespaces

Thanks. Since the issue repros also in a Codespace I opened an issue here https://github.com/github/codespaces/issues/14609
Thus marking this as an upstream and moving to backlog since we can not fix it on our side.


The app does not display snippets

[
https://user-images.githubusercontent.com/71305756/128990820-a24ca8f3-9c04-4615-a596-13cd728f6071.mp4
](url)
When I go to home and change some filters, even though it should display snippets it doesn't I have attached a video in which this happens

The snips start appearing again when I click the cross in the search bar

I am very thankful to you for reporting this bug.
I will try to fix this and release the next version in a minimum time possible.
The bug above shows that when you come back to All languages, it is not showing all of them.

Not only is it not showing all languages, when I go in python it doesn't show

Also a bit off this issue, shouldn't the releases tab have the installer of the app instead of the source code

ohok will manage to fix that too.

Well, I am done with the above issue you listed and some other issues I found myself.
Here is the V1.1 release https://github.com/Abdesol/CutCode/releases/tag/V1.1
And let me know if there are any other issues.
Have a good time :)


components: Deprecate tree-related APIs

Should we deprecate ControlledTree in AppUI also or should we leave for a while as it might be used without presentation stuff?

Good point, I'd vote for deprecating it. @GerardasB, thoughts?


python3Packages.domeneshop: 0.4.2 -> 0.4.3

Description of changes
This is a meta module, only used by urllib3 to detect whether it was installed with the [secure] extras marker. This marker is now deprecated as of 15th of July 2022. This package was not added to pythonPackages, as it is only a meta-package.
Updates domeneshop to fix the issue where a dependency on urllib[secure] fails due to the missing meta-package urllib-secure-extra, which we apparently prefer not to package.
ZHF: #199919
Should fix python3Packages.domeneshop

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build python3.pkgs.domeneshop

Should i add myself as a maintainer to this meta-package?

The urllib3 roadmap doesn't mention a date for 2.x, unfortunately. The removal of urllib3[secure] will primarily affect modules which are not maintained.
From my point of view we should not add urllib3-secure-extra but simply patch urllib3[secure] out in the affected modules.

I got upstream to fix it. I'm now force-pushing the PR to instead update domeneshop. A quick grep shows me that these packages still use urllib3[secure] in my local checkout:

runway-python
tank-utility
selenium

https://github.com/ofborg build python3.pkgs.domeneshop

Some packages still have urllib3.optional-dependencies.secure which has to be removed in the future.

runway-python

Is patched out

tank-utility

Is patched out

selenium

I updated the package which solved it.

Result of nixpkgs-review pr 200681 run on x86_64-linux 1

2 packages built:

python310Packages.domeneshop
python39Packages.domeneshop


Animation blend nodes do not slerp quaternions along shortest path

Godot version
v4.1.1.stable.mono.official [bd6af8e0e]
System information
Godot v4.1.1.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2080 (NVIDIA; <IP_ADDRESS>23) - Intel(R) Core(TM) i7-4770K CPU @ 3.50GHz (8 Threads)
Issue description
When blending animations together, quaternion interpolation are not always along the shortest path. I think that should be the case
The issue occurred with different AnimationTree Nodes :

Blend2
BlendSpace1D
BlendSpace2D

Steps to reproduce

Extract the given "AnimBlendIssue" sample project then Open it
Open main.tscn
Select the AnimationTree node
In the AnimationTree panel  play with the blend slider of the Blend2 Node

=> The prism in the viewport rotates 270° clock side will I'm expecting 90° counter clock side
Note : For convenience the animation clips Rotation1 and Rotation2 consist of only one rotation track with only one keyframe :

Rotation1 : x = -0.062; y = 0.997; z = -0.003; w=0.052
Rotation2 : x=0.046; y=-0.742; z=-0.042; w=0.668

Minimal reproduction project
AnimBlendIssue.zip

Reproduced with :

v4.2.dev4.official [549fcce5f]

Dupe of https://github.com/godotengine/godot/issues/81021. See also https://docs.godotengine.org/en/latest/tutorials/animation/animation_tree.html#for-better-blending.
The appropriate reference angle must be set manually as Rest or RESET. It does not make sense to get the shortest path from the immediately preceding frame. Even if it is the shortest path when comparing blends, it may not be the shortest path during playback of the animation.


Added more options to tabs

Two things have been added to tabs:

Option to change the thickness of the tab lines.
Hiding the close button [X] by default and only show when you hover over the tab.

Also because of the extra options tab_line_colors.css has been renamed to tabs.css.

Hi @Shourai, thanks for the pull.
I'm a little hesitant to merge only because I've been trying to keep the changes in ShadowFox to purely color scheme based things.  This helps avoid the inevitable problem of everyone having different tastes and people having to come up with workarounds to revert a certain setting back to FF's defaults.
I do think both of the changes you made would be great additions to the More Tweaks wiki page, however.
For people who are using the updater scripts, all they would have to do is copy/paste your code into their userChrome_customization.css file.

Hey @overdodactyl, I totally understand.
I overlooked the "more tweaks" page, excuse me for that.
But I agree that this would be a better addition to the wiki to not pollute the
purely color scheme based settings.


add data table for image API

change data structure of data source on frontend, so no compatibility within v0.3.0

on v0.3.0, data source is dealt with list like ["key": ["src1"]], this structure complicates data schema on DB and not fit for other data like sound, graphs and so on. So changed as ["key": "src"] simply.

~please merge #114 first.~

I am satisfied with the table naming, so I will merge.


add  claude-3-5-sonnet-latest and claude-3-opus-latest

add  claude-3-5-sonnet-latest and claude-3-opus-latest

Summary by CodeRabbit

New Features

Expanded model options with the addition of two new Anthropic models: "claude-3-5-sonnet-latest" and "claude-3-opus-latest."

Improvements

Updated KnowledgeCutOffDate for better management of model cutoff dates.
Enhanced LaTeX rendering by modifying the DEFAULT_SYSTEM_TEMPLATE for improved output formatting.


Repo reorganisation + extract reusable stuff

Anything to rename? Move?
Also, try to extract as much "framework" stuff as possible (hint: those classes that starts with Ltd like LtdSlider etc.)

Also make sure to take a look around, see if everything is in good order etc.
Add comments if/where needed.


px4io firmware: Allow actuator update rates down to 45Hz, as this is exa...

...ctly where standard Spektrum receivers work.
Note that the default update rate stays at 50Hz, so this is only an optional change for users who want to adapt their PX4IO output to the 45Hz/22ms output by Spektrum RC receivers.

This change is odd - why would you need to pace at 45 Hz?

Apart from not understanding why your RC control has anything to do with your servo output, I'm open to drop this to 20 Hz - but not 45. I still think that its a mistake though to link your output rate to your remote control - I can't come up with an architecturally valid reason why one would need that - unless of course you have really odd peripherals connected via PWM.

A min. 20Hz update rate is also OK for us. I think we should not limit the PX4IO output frequency ABOVE the output frequency of common RC receivers. A Spektrum receiver, outputting at 45Hz, is one example, and setting the PX4IO update rate to 20Hz would thus cover this. Shall I adapt this PR to 20Hz?
(In our special case, we have a Spektrum RC Receiver and PX4IO connected in parallel to an output multiplexer - and we want both outputs to happen at the same frequency to always supply the Servos at the same update rate).

Unless you have analog servos the update rate to them won't make any significant or even noticeable difference between 45 and 50 Hz - still not sure what problem you're trying to solve. What piece of data does suggest this would be helping?
I'm also presuming that you're familiar with IO's multiplexing capability - its deployed now to about ~100'000++ drones and flying actively on all of them - how many units of your multiplexer exist and what is your statistical confidence in it being necessary or safer? I'm not at all against its use, I'm just raising a statistical / scientific argument about the real failure probabilities of the components involved. By adding the multiplexer, you've added another single point of failure.
Allowing down to lets say 25 Hz would be acceptable to us though, so if you feel you have to do this, then please feel free to send an updated PR.

Actually, why we want to do this is because we are seeing another problem on the RC outputs (quite some stuttering when compared to the standard RC outputs). We want to have the same output frequencies to exclude any obvious difference in the outputs. We have seen this issue for more than a year now, but now just found the time to look at it. I'll open another discussion in the forum on it later.
Ok, I will update the PR to 25Hz. It's not about having to feel to do this, it's more that we should allow to set the same output frequency that a major RC equipment manufacturer uses.

The technical flexibility makes sense to me and which is why I'm merging this. The technical argument doesn't make any sense to me, because most manufacturers use 50 Hz and its what your servo manufacturer most likely designed his system for.


[Feature] Recipe management/adjustment

I would like to be able to adjust the recipes for all the different pieces of the plugin or disable them all together so that another plugin can handle the crafting of the items.
If this is already a feature then please just let me know where/how I can do that.

It's not yet a feature, not sure how another plugin would be able to handle the crafting since some NBT are created on the newly crafted items.
I'll take a look at letting server configurations adjust recipes.

But a feature for disabling crafting completely would be amazing!

https://www.spigotmc.org/resources/customcrafting-advanced-custom-recipe-plugin-1-16-1-18-free.55883/ Theres this amazing plugin that allows you to take items from other mods and create custom recipes for them, Being able to disable your recipe for the items will enable us to create our own custom Recipes which can be more expensive and use other items from other plugins to be able to create your Storage System/Drives. Please look into having an Option to Disable the Crafting Recipes.


Provide grapenve(-py) helper scripts

Provide helper scripts for use in grapevne modules. These will be imported in the module Snakefiles and used to redirect input/output filename, etc. This will 1) dramatically simplify the Snakefile construction process by handling input/output namespace redirection automaticall (with the use of simplified wrappers), and 2) provide a level of abstraction that can be used to automate Snakemake 7 and 8 support.
For example, existing rules require something like this:
indir = config["input_namespace"]
params = config["params"]
infile = params["Filename"]

rule demo:
    input:
        infile = f"results/{indir}/{infile}"
    ...

This would be replaced with wrapper scripts (input and params in this case), abstracting away the namespace connections and permitting e.g. remote file access to be used depending on context and Snakemake version:
rule demo:
    input:
        infile = input(params("Filename"))

Since these wrapper would be required in the Snakefie (outside of any conda environment), they would need to be installed and available on the host system. To facilitate this we propose bundling each workflow with a grapevne_helper.py script that checks for, installs the most recent grapevne package and exposes its namespace to the Snakefile (this can be done in several ways).
This greatly simplifies the users' exposure to namespace mapping, reducing the risk of error, and permits #189, #146

The grapevne wrapper system is available here: https://github.com/kraemer-lab/grapevne-py
Published on PyPI here: https://pypi.org/project/grapevne/
Tests are available in the wrapper respository, with specific attention drawn to the workflow examples: https://github.com/kraemer-lab/grapevne-py/tree/main/tests/test-repo/workflows
Each modules comes with a workflow/grapevne_helper.py script that can be used to install the grapevne package from PyPI and expose its functionality in the Snakefile (this can be done as named imports [as below], as a context manager, or references to a Helper object instance).
As a usage example, a simple copy module might be implemented like this:
"""Copy file from one directory to another.

This version demonstrates use of the helper by importing function names ('script', 'resource', etc. into the namespace)
"""
configfile: "config/config.yaml"

from grapevne_helper import *
import shutil

init(workflow, config)

rule copy:
    input:
        filename=input(params("filename")),
        dummy_script=script("dummy.sh"),
        dummy_resource=resource("dummy.txt"),
    output:
        filename=output(params("filename")),
    log:
        log("copy.log"),
    run:
        shutil.copy(input.filename, output.filename)

@joetsui1994 @abhidg Comments welcome on the above proposal. I have a working version but will need to modify existing modules for compatilbility and rework the central documentation, so would welcome any comments before I embark on that. A side-benefit of providing this functionality is that we can provide updates through the grapevne (PyPI) package itself from now on.

This makes sense and looks useful. My only (and perhaps unfounded) concern is whether this would present an additional barrier to people who already has some experience with Snakemake and is starting to work with GRAPEVNE?

Looks good @jsbrittain! Do we want to be able to specify the grapevne-py version when installing? If backwards compat is guaranteed, then not an issue.

@joetsui1994 @abhidg - thanks for comments!
With regards snakemake familiarity, it's a slightly different way of thinking for us (who have developed grapevne modules already), but having converted a few I can already see how much cleaner/simpler it makes the snakefiles. At present, writing grapevne modules you need to know 1) how to use snakemake, and 2) recognise the intricacies of grapevne (i.e. they need to know and remember that all results are expected to go into a 'results/{indir}' folder, and that indir comes from config['input_namespace']). With the proposed approach we deal with all of that behind the scenes. And, of course, we don't expect every user to interact directly with the snakefiles themselves, but for those that do it provides a coherent framework, rather than a set of arbitrary rules.
With regards versioning, I wasn't entirely sure what the best approach was here or where the user should specify it. The fact that we need grapevne-py installed in the base environment means we can't simply add it as a conda dependency, which is why the helper function exists. I could extend the init function with an optional version=1 parameter so that it is controllable in the Snakefile (i.e. user would specify init(workflow, version=1), and then only import grapevne at the init stage (presumably with a special case to install v0 if v1 is not found). Does that sound more reasonable?

With regards versioning, I wasn't entirely sure what the best approach was here or where the user should specify it. The fact that we need grapevne-py installed in the base environment means we can't simply add it as a conda dependency, which is why the helper function exists. I could extend the init function with an optional version=1 parameter so that it is controllable in the Snakefile (i.e. user would specify init(workflow, version=1), and then only import grapevne at the init stage (presumably with a special case to install v0 if v1 is not found). Does that sound more reasonable?

That sounds good!

Closing as complete. Further refinements can be considered on the grapevne-py repo: https://github.com/kraemer-lab/grapevne-py.


Remove hardcoded year value 2017

Related to the issue: #271

Closing this because we want the year to be burned into the project at the time the template is executed..


Publishing method to stage is tricky and error-prone

To stage content on Drought, you have to:

Add a "staging" tag to the page, and click Update
Wait for a minute or so
Then make your changes, and click Update

This method does not always work reliably, and it's hard to tell if that's the fault of the editor or not. It doesn't work for the homepage at all. This is hampering our ability to pass publishing tasks to stakeholders.
Request that we have a staging and publishing process that is easier and works reliably for all pages that need updating.

I believe the correct tag is staging-only..  staging, which has been used several times, is ignored.

I believe the correct tag is staging-only..  staging, which has been used several times, is ignored.
@carterm I thought we were supporting both tags?

The tag name would be in the Wordpress endpoint config in the project.

I believe the correct tag is staging-only..  staging, which has been used several times, is ignored.
@carterm I thought we were supporting both tags?

The tag name would be in the Wordpress endpoint config in the project.

Just "staging"
   "tags_exclude": [
      "staging",
      "development"
    ]

Doing further tests.  Confirmed 'staging' works.  Wondering if when I alternated staging -> staging-only, the first update failed, and the second update caused the first to finally go thru. I'm using coin-flips now to alternate between the two tags...

Doing further tests. Confirmed 'staging' works. Wondering if when I alternated staging -> staging-only, the first update failed, and the second update caused the first to finally go thru. I'm using coin-flips now to alternate between the two tags...

There is a delay between performing an update, and when the correct tags are displayed in the API.  Could explain it.

For sure. In further tests I found that switching from not having the 'staging' tag to having it sometimes caused an errant production publish the first time.  Subsequently it works. Definitely sounds like related to that delay.

Possible work-around (which Peggy may be already doing) is to add the staging tag without doing any other updates (except maybe adding some whitespace), and then do an update. This will possibly go to production, but is harmless. Definitely a bogus workaround to have to do, however.  I'm wondering what we can do to fix this.

Testing 15 second delay...

After inserting a 15 second delay at a crucial spot, I'm not seeing any issues with this. Previously 3 out of 8 tests did not sync correctly. Now 8/8 tests worked.

Removing p0 tag, since this is behaving better.

From 10/1/2021 call:

[ ] Test solution
[ ] Sync again on longer term solution- is tagging the best path?


add the maven central badge

shows the current version of dependencies in the maven central

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage     91.89%   91.89%
  Complexity       54       54
=========================================
  Files             6        6
  Lines           148      148
  Branches         16       16
=========================================
  Hits            136      136
  Misses            7        7
  Partials          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d956e...e7d1abb. Read the comment docs.


[ci:component:github.com/gardener/hvpa-controller:v0.13.0->v0.14.0]

Release Notes:
Fixed a bug that caused HVPA reconciliation to fail with `expected pointer, but got v2beta1.MetricSpec type` when the HPA spec had changed.

/lgtm
Fixing a bug that @istvanballok saw in our systems

/kind bug

/test pull-gardener-integration

/cherry-pick release-v1.76

/cherry-pick release-v1.75

/cherry-pick release-v1.74


Commandline parsing fails to produce errors

Almost all professional software on unix uses a similar user interface when it comes to the commandline.
All of the executables that bitcoinclassic ships, however, do their own thing.  This works Ok for most cases, but many of the common user errors are not detected and will not be reported. Causing the usability of the software to be lower.
Specifically;

when a user passes in an argument that doesn't exist, no warning is give. For instance if a user types '-deamon' instead of '-daemon', the argument is ignored and nothing is reported to the user.
required arguments are not required.
for instance when you use the argument -rpcuser=<user> and you pass in --rpcuser without any arguments, no complaints are generated.

I suggest checking for command line parsing libraries like getopt.

There is also the case of silent conversions of option values in not-so-expected ways.
Try specifying an integer argument as a hex value ... this would be very useful for version.
The number parsing on UNIX could auto-detect the base-16, but it's hardcoded not to, seemingly because intelligent string to number conversion is not available in the Windows platform's libraries.
What happens when one specifies 0x1234 ? It gets silently converted to 0.
/rant

I would support the complete drop of the feature of command line options on Windows. Maybe just the standard 'version' and others that make the tool quit immediately after, but no more.
They can still do everything they want in the config file.
What I expect is that there is some code that describes all the command line options and stores them in some commandlineparser class. It does the checking and it does the printing of the options.
Then you use an instance of that class to get your data out.
There are tons out there, this is one I have experience with for the idea.
https://doc.qt.io/qt-5/qcommandlineparser.html
Maybe there is a good one in boost (since we probably don't want to pull in the qtcore library ;)


Sticky Highlighting on 'Community' Nav Bar Button

On beta/staging, if you click the community button on the nav bar, it remains highlighted even after you navigate away and the menu closes. I believe this is unintentional and if the menu is not open, it should not remain highlighted in the navbar.

Right, I see. what you mean. hovering on the community button displays the drop down menu, clicking on the community button has no actual effect (unlike the others in the nav bar), so it remains highlighted. This is my first attempt at helping an open source project, so I'll give it a go and get back to you! :nerd_face: