Pre-compiled version doesn't work and manual compile "terminates because of errors"

I can't seem to get GodotSteam to work no matter what I try.
Pre-compiled version:
Tried the windows 64bit zip and at first I couldn't extract it. The default zip program gave error 0x800040005 and WinZip said the files were corrupt. 7zip finally worked, but after placing the steam_api64.dll and steam_appid.txt files in the same folder as the two .exe (which I think is correct, documentation really isn't too clear on where to place the files) i still get an error saying the program can't start (0xc000007b).
Manually compiling:
After installing all the necesarry programs it seemed at first that the compiling was going fine until suddenly it kept giving errors like:
C:\godot\modules\godotsteam\godotsteam\godotsteam.h(611): error C2327: 'Steam::unit32': is not a type name, static or enumerator (note: xx are two numbers)
Most were the same except for different numbers instead of 611. Also a few that mentioned "syntax error" "unknown override specifier" and various other bad things.
Finally it says:
C:\godot\modules\godotsteam\godotsteam\godotsteam.h(799): fatal error C1003: error count exceeds 100; stopped compilation
scons *** [modules\godotsteam\godotsteam.windows.tools.64.obj] Error 2
scons: building terminated because of errors
How do I get any of these two versions to work?

Hey there!  Hmm, it does indeed seem the zip file is corrupted.  I just downloaded it and it will not open; clearly something in my zipping process went haywire.  That said, if you do get the file extracted, it wouldn't work.
But yes, both the steam_api64.dll and steam_appid.txt must be in the same folder as the executable.  Were you referring to the documentation being unclear or the repo's readme file?
The only thing I'm unsure of is I cannot find "Steam::unit32" anywhere especially in line 611.  Line 611, for me, is:
bool addPromoItems(const PoolIntArray items);
Which branch did you download from?
Either way I will repackage the pre-compiles and upload them again.

Its possible I accidentally looked at two different lines when typing out the error message and ended up combining some things, in any case I just downloaded the master branch.
Glad to hear it might just have been something wrong with the zipping, hoping I can make it work after the reupload.
In regards to the "unclear" part it was indeed the readme that confused me. Maybe I'm missing something but to me it doesn't seem like those two files are mentioned anywhere in relation to the pre-compiled version and since it has both the editor and template files, it doesn't quite match the finished hierachy which it is written that the manual version should have:
steam_api64.dll
steam_appid.txt
./godot.windows.tools.64.exe
Also as a side note is it correctly understood that the "steam_appid.txt" file should only contain your game's appid and no other text?

Yeah, that error is odd because I get no compilation errors on either Windows or Linux.  Also cannot find "unit32", which looks like a misspelled uint32, anywhere in the code.  You weren't compiling with MinGW, were you?
Yep, the new zips are uploading now.  Seems my 7Zip app is messed up.  I double-checked these ones first.
Well, the readme is, I guess, meant to explain the compiling process.  I usually rename my compiles after the operating system, version number, and type; but I can see where that would be confusing.  I will update the readme.
Yes, steam_appid.txt should only have one app ID in it.  If you don't have a game on Steam yet, use 480.

Pre-compiles are updated.

Nice with the update.
Guess I'll attempt another compile to see if I can replicate the error again and get it right this time.

Alright here's what I got wrong before. The line was 621 not 611 and it was indeed "uint32" not unit.
Uploaded 2 screenshots with all the errors here: https://imgur.com/a/RDexza9
As a sidenote it started getting errors and stopped compiling much earlier this time.

Huh, well, whatever compiler you are using is spitting out what are really non-errors.  What exactly are you compiling with?

Well I followed the instructions on here: https://docs.godotengine.org/en/stable/development/compiling/compiling_for_windows.html and installed Visual Studio (with C++ enabled), Python and SCons. Then in a cmd put in changed the root path to where the Godot folder was and put in "scons platform=windows". I can't guarantee completely that I didn't do something wrong when installing one of the programs, but I'm not sure what that would be.
Off-topic for a second: I'm trying now to make a build of my game for testing and it crashes whenever I try to run it. The readme seems to both tell me to include and not include the "steam_appid.txt" file:
"Lack of the Steam API DLL/SO/DyLib (for your respective OS) or the steam_appid.txt will cause it fail and crash. Do not include the steam_appid.txt or any .lib files."
But well, neither option seems to work atm. I'll try out the 32bit version.

Huh, that should be fine then.  I'm not sure why it's giving you those errors but it shouldn't.  Those are definitely integer types.  I have never used the command prompt to compile, I always use VS Native Tools Command Prompts (both x86 and x64).
That was a bit unclear in the readme and has been fixed. The steam_appid.txt must be included when you are testing your game outside of the Steam client because Steam does not know what game you are running unless it is run -through- the Steam client.
That being said, do not upload the steam_appid.txt to Steam when getting ready to ship your game.

Ok, good to have that clarified.
But the game still crashes instantly whether I include the file or not.
Tried uploading to Steam (without the steam_appid.txt) and the same thing happens.

Well, gonna need a bit more than "it crashes".
How is the initialization implemented?  Does it show anything before crashing or does it never start?  Is there any output in the Godot editor debug window?  Did you compile it with the template from the pre-compile folders before uploading to Steam?

The godot window starts up then closes down again nearly instantly. Its so fast that I couldn't really see anything in the debugger, but now I managed to capture some screenshots: https://imgur.com/a/RDexza9 (below the ones from before).
"MainMenu.tscn" is my starting scene, which it apparently can't load.

I can see from the screenshot you are not using an editor with GodotSteam.  You are running the official stable build of 3.2.2.

Well it sure does say that at the top yea now that you mention it. This is exported using the pre-compiled GodotSteam for 32bit windows though.

You are using the pre-compiled template?  There shouldn't be a debug window for exported games.  When exporting make sure you uncheck the debug option in the export window.  Even then it shouldn't show up as official.

I only enabled the debug option because it wasn't working. And no I was using the pre-compiled editor, thought that was right since I couldn't even get the template to start. When I try to I get this message:
"Error: Couldn't load project data at path ".". Is the .pck file missing? If you've renamed the executable, the associated .pck file should also be renamed to match the executable's name (without the extension)."

Yeah, you can only use the debug option if you have a release_debug template, which the pre-compiled versions are not.  Armed with all this new knowledge I'd start over from the beginning and try again using the right stuff in the right order then see what happens.

Okay here's what I found after some testing:
After exporting the game instantly crashes if I use the "Steam" object anywhere in my code.
The game can run with the "Steam" object without crashing if I test it before exporting, but afterwards, godot logo shows up then instantly shuts down again.
My assumption would be that the exported version is somehow just regular Godot instead of GodotSteam, because I know for a fact that that is the respone Godot gives if I try to run it with code that it doesn't reconize.
Debug is not enabled for export, and has not at any point been enabled since this fresh installation of pre-configured GodotSteam windows 32bit.

So if it crashes after export then one of two things is happening:

Either the template being used is not a GodotSteam template
Or the exported executable does not have the steam_api.dll (steam_api64.dll) or steam_appid.txt with it

When you export do you manually select the GodotSteam template in the Custom Template field?  Or are you installing them to the templates folder like the documentation says?  I usually select them in the Custom Template field.
The exported executable has to have the API DLL in the same folder, along with the steam_appid.txt or it will crash immediately.
As for Windows Defender, I have no idea.  I don't use it.  But it blocking or removing the executable could be an issue.

Okay, my bad.
I had just figured out before you wrote how the template was supposed to be used (didn't even know it was for exporting), which is why your previous comments didn't make much sense to me.
After I selected it in the Custom Template section, like you just said, the export seems to be working fine.

Hey!  Glad it got sorted out.  You aren't the first to have that issue with the templates and won't be the last.  I had that issue when I first started with the project, honestly.
To save others the headache I think I will write up a "testing and shipping" tutorial that covers things like this.  Thanks again for helping me find weak spots in the readme, too!


reordering ml_commons tests : moved test_search to the end

Fixes #326
Having test_search at the start of the module is making it to run first.  Since pytest runs tests by the order they appear in the module. Moving test_search to the end should help to mitigate this issue
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

DCO is missing.


[feature] Display last X builds

Can we have a settings / changes so that we can see the last X amount of builds.
I love this plugin but the problem is when we have loads of jobs to keep track of it almost becomes impossible to display.
What would be great is within the selected jobs it only displays the last x amount of builds with the status of the builds and when something new is built it's added to the start of the list and the last item is removed.
Thanks

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/36842345-feature-display-last-x-builds?utm_campaign=plugin&utm_content=tracker%2F580790&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F580790&utm_medium=issues&utm_source=github).

Hey @barnabyaaron and thanks for your feedback, I'm glad that you're finding Build Monitor useful :-)
Could you please elaborate a bit more on what you have in mind? Would this be like a "filter"? So that instead of say 50 jobs you'd normally display it would only display the 10 most recent ones? Do I understand that correctly?
Best,
Jan

Yes so currently it is displaying all the jobs that I have filtered to display  (even if NO builds are even in this job).
What would be great is if there was a view where it would show the last x amount of builds from the selected jobs.
This means if I'm viewing 50 jobs I will only see the 10 latest builds for example (which means I can easily see this on 1 monitor)

Right, so something like "Show only 10 recently built jobs"?
What if there are problems with any of the remaining 40 (assuming they have some builds) ?  Would that information not be important?

The idea is we have a monitor that we display in the office.
We have currently around 30 jobs but this will grow to over 100+ jobs over time (as we start adding more applications).
However there are normally builds only happening every say 1 hour or so (because of our process of git > review > Jenkins)
So if there can be an option so I can display the last x amount of recently built jobs this means I can easily see from the monitor if something that recently built has failed.
as a extra maybe there could be a toolbar at the bottom of this view that shows total number of jobs (that has been selected from the current filter) and how many currently have passed there latest build or failed the latest build.

Just a small update to this.
I have recently been using the option to 'Order By - Last build time'
which defiantly does help because it means the top left build is the latest everytime.
So technically all I need it a way to limit the build monitor window to only display the top X results because that way it will only show the last x latest builds because of the ordering of the filter.

Any progress/more thoughts on this? I too was looking for a option like this. In our case we have one generic job setup to build pull-requests and push-notifications from a TFS-Git instance. However, currently the build monitor plugin will only show the last build, while I would like to show the last-x builds.

+1
I've got a large number of multi-branch pipelines, and since the Build Monitor Plugins crams all jobs into the viewport, the individual jobs become way too small. So a config option like "Show N most-recently built jobs only" would be great.

Please add this feature. I am waiting to show the recent x builds and its status in the same screen

+1
I have exactly the same problem as one mentioned by @sflothow-vwd where I want to list only recent jobs in multibranch pipeline configuration as now cards are getting smaller and smaller.

Hi all,
I'm facing the same issue as well.
Actually, I have a certain number of jobs (job1, job2, ..) that got executed many times (#build1, #build2,...)
I want to show the status of x number of builds per job. but the build monitor plugin shows only the latest build from each job.
this is what i would like to have:
build#1   build#2   build#3  ...
job1     status    status      status
job2    status    status      status
job3    status    status      status
job4    status    status      status
*status, it will be showing a red or green box to indicate if the job failed or passed
Anyone who can help please?

It looks like this issue is being used to ask for 2 different features:

Only show the latest N jobs that have built

To limit the number of jobs on the screen

Show N builds per job

To be able to see the status of previous builds of a job

For Feature 1, you could use the View jobs filter plugin (https://wiki.jenkins.io/display/JENKINS/View+Job+Filters) to limit the number of jobs on the page. Specifically this filter seems to do just that: https://wiki.jenkins.io/display/JENKINS/View+Job+Filters#ViewJobFilters-FiltertoMostRecentJobs
For Feature 2, I can't think of a way to do that. Myself, I normally only care for the latest build, anything before that is just volatile data of previous commits. Since I can't understand why you want that feature, it's hard for me to think of an alternate solution that would help you.


Setting the Client_Key of MicroXRCE-Agent

Added an argument in Node() that can set Client Key of Micro XRCE-Agent at node initialization

Hi, @taro83
Thank you for your contribution.
I'm just leaving a few reviews, can you fix it?

Please delete the files below and add them to .gitignore if necessary.

.DS_Store
src/.DS_Store

Hi @OpusK
Thank you for your comment.
I added setting to ignore .DS_Store.
I will try to fix any other suggestions from you.

@taro83
You added .gitignore but didn't delete the DS_Store files.
Please delete it.

@OpusK
Sorry, my mistake.
I deleted DS_Store files.

@taro83
Thanks for your contribution.
We will release this soon.

Thank you for merge !
I will follow this good project.


Publish to Zenodo

[ ] Review author list
[ ] Obtain doi
[ ] Add badge to README
[ ] Update CITATION.bib
[ ] Add mention/include of CITATION.bib to the Sphinx build

I've now enabled Zenodo for this repository.  Instructions there say that the next step toward obtaining a doi is to make a release.  The doi should therefore happen automatically once we create the 0.2.0 release.


[1096] - Add cookie banner

Context

https://trello.com/c/i0soP8KH/1096-m-add-cookie-banner

Changes proposed in this pull request

Implement the Gov UK cookie banner and wire in some Javascript to show/hide it. It's always shown without JS as per the design guide
Add Jest and some unit tests and a rake task to run it in our CI
Fix a few of the feature specs which were generically targeting govuk-button causing capybara ambiguous errors

Guidance to review

Head to the review app https://rtt-review-pr-589.herokuapp.com/
Assert you can see the cookie banner. Select to hide it, refresh and assert it is no longer shown.
Disable Javascript in the console and assert the banner is still shown but without the hide button

Looking good @darokel.
Note the Design system has guidance for how to hide banner - they suggest using a hidden attribute, and not display="none".
We should also add the viewed_cookie_message cookie to our cookie page.

@edwardhorsford I've applied those changes


chore: Updated acceptance test request to ensure expected response from wholesale

Description
After the removal of mocked data in wholesale we need to update our acceptance test requests.
We ensure a failed request by setting starting-time after end-time.
We ensure a good response by update the timeslots to timeslots where we know data exists.
By picking a relative new timeslot, we ensure, that we do not have to update this, in the short future.

References

#0000

Codecov Report

Merging #450 (fd2db16) into main (21978a1) will decrease coverage by 17.12%.
Report is 139 commits behind head on main.
The diff coverage is 59.05%.

@@             Coverage Diff             @@
##             main     #450       +/-   ##
===========================================
- Coverage   83.07%   65.96%   -17.12%
===========================================
  Files         456      509       +53
  Lines       10418    11349      +931
===========================================
- Hits         8655     7486     -1169
- Misses       1438     3606     +2168
+ Partials      325      257       -68

Files Changed
Coverage Δ

...ivedMessages/ArchivedMessageGetDocumentListener.cs
0.00% <ø> (ø)

.../ArchivedMessages/ArchivedMessageSearchListener.cs
0.00% <0.00%> (ø)

source/Api/Configuration/InboxMessageMetadata.cs
0.00% <0.00%> (ø)

...ation/Middleware/Correlation/CorrelationContext.cs
0.00% <ø> (-66.67%)
:arrow_down:

...uration/Middleware/UnHandledExceptionMiddleware.cs
0.00% <0.00%> (ø)

source/Api/Configuration/SystemTimer.cs
0.00% <ø> (ø)

source/Api/EventListeners/InboxEventListener.cs
0.00% <0.00%> (ø)

...rce/Api/EventListeners/IntegrationEventListener.cs
0.00% <0.00%> (ø)

...essages/RequestAggregatedMeasureMessageReceiver.cs
0.00% <0.00%> (ø)

...equestAggregatedMeasureTransactionQueueListener.cs
0.00% <0.00%> (ø)

... and 149 more

... and 229 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cateye style for Gamepad

This adds a new style of gamepad visualization per my interpretation of #33 .
During implementation I discovered that nanoVG does not want to fill a triangle with the one inflected edge, so I had to split each into two triangles.
For settings, I used the settings from Uniform with the exception of border color and size. I initially didnt want to duplicate a bunch of code to restroke the outlines for a border but if you think it's useful I can work on moving the path code to a function and stroke a border.

This looks awesome! I'll be able to properly review this tomorrow.
At first sight, the steering arrow fills aren't the same as they are on that PadViz version, so perhaps that should be changed? Not sure what people would prefer though.

Oooh, does the steer on padvis stretch the shape from the inflected edge? Hm, I could work on switching to that.

Yeah, it does. I've never liked that style, but it's what that specific padviz is doing. Maybe there can be an option to toggle between those 2 modes.

Can I do that with the linear gradient fill method, or do you think I would need to fill another path?

You can do it without any gradient, you just need to draw 2 triangles where its most right/left point is controlled by the value of steering.

Updated to use your suggestion for steering visual. I also moved all the path code to a reusable function: FillInflectedTriangle() and then pulled in the settings for border and stroked that from StrokeInflectedTriangle().
Btw, "Inflected Triangle" is just some name I came up with on my own. I don't know what it should really be called but I am more than happy to change those if you would like a better name.

Per your earlier suggestion, I added a boolean setting to toggle between the "stretchy" and simple steering visualization.
What are your thoughts on the setting's wording and default setting?

The defaults are okay! Thanks for the PR! :D


Added rest layer for the workflow. Added secure tests

Issue #, if available:
Description of changes:
Added REST API layer for workflow:

API for create/update workflow - POST/PUT /_plugins/_alerting/workflows
API for getting the workflow - GET /_plugins/_alerting/workflows/{workflowID}
API for deleting the workflow - DELETE /_plugins/_alerting/workflows/{workflowID}

Beside REST API, secure tests are added - in order to test the workflow and underlying monitors (delegates):

test create workflow with an user with alerting role - creates user with hr backend role and index workflow access; verifies that user can create a workflow
test create workflow with an user without alerting role - creates user with hr backend role and without index workflow access; verifies that 403 status is returned when creating a workflow
test create workflow with an user with read-only role
test create workflow with delegate with an user without index read role - creates user with index workflow cluster permission and with hr_data index access; creates a monitor for not_hr_data index; tries creating a workflow and verifies that user can't access the monitor indices
test create workflow with disable filter by
test get workflow with an user with get workflow role - tries to get the workflow with the user with get workflow cluster privilege
test get workflow with an user without get monitor role - verifies that user without get workflow cluster privilege can't access the created workflow
test update workflow with disable filter by - tries to update a workflow as admin with disabled filter by
test update workflow with enable filter by - tries to update a workflow as admin with enabled filter by
test create workflow with enable filter by with a user have access and without role has no access - creates a workflow with user having two backend roles (role2, HR) with alerting_full_access cluster privileges; verifies that user which has two backend roles (role2, HR) get workflow access cluster privilege; updates the user roles to role1 and verifies that user can't get the workflow
test create workflow with enable filter by with a user with a backend role doesn't have access to monitor - monitor is created by the user which has two backend roles - hr and role2; tries to create a workflow for the previously created monitor as delegate with a user with different backend roles (role3);
test create workflow with enable filter by with no backend roles
test create workflow as admin with enable filter by with no backend roles - creates workflow as admin and verifies that user with specified backend roles can't get the workflow
test create workflow with enable filter by with roles user has no access and throw exception
test create workflow as admin with enable filter by with a user have access and without role has no access - creates a workflow with 3 backend roles; checks if the user with one backend role matching the previous three can access the monitor; updates the user by setting up a new backend role - role5 and verifies that he can't access the monitor
test update workflow with enable filter by with removing a permission - creates a workflow with one set of backend roles; updates the workflow by removing one of the backend roles; verifies that user can't access (get) the workflow
test update workflow with enable filter by with no backend roles
test update workflow as admin with enable filter by with no backend roles - creates workflow with specified backend roles and verifies that user with matching roles can access the workflow; updates the workflow backend role can access the workflow (GET);
removes the backend role and verifies that user can't access  anymore to a workflow
test update workflow with enable filter by with updating with a permission user has no access to and throw exception - verifies that updating a workflow with a new backend role, with a user which doesn't have the same backend role assigned, will fail
test update workflow as another user with enable filter by with removing a permission and adding permission - same as above, just user has the role on which he updates the workflow
test update workflow as admin with enable filter by with removing a permission
test delete workflow with disable filter by - verifies deleting the workflow with it's delegates
test delete workflow with enable filter by
test delete workflow with enable filter with user that doesn't have delete_monitor cluster privilege failed
test execute workflow with an user with execute workflow access
test execute workflow with an user without execute workflow access
test delete workflow with an user with delete workflow access
test delete workflow with deleting delegates with an user with delete workflow access
test delete workflow with an user without delete monitor access
test admin all access with enable filter by - verifies that admin can create workflow, get it and remove it when filter by is enabled
test execute workflow with bucket-level and doc-level chained monitors with user having partial index permissions

CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Please provide proof of security tests passing


Dependency of com.xtdb.labs causes conflict

When starting the program, the following error will be reported：
clojure.lang.ExceptionInfo: Conflicting data-reader mapping {:url #object[java.net.URL 0x2b4c1d96 "jar:file:/C:/Users/xlawin/.m2/repository/com/xtdb/xtdb-api/2.0.0-SNAPSHOT/xtdb-api-2.0.0-SNAPSHOT.jar!/data_readers.clj"], :conflict xt/runtime-err, :mappings {xt/runtime-err #'xtdb.error/-runtime-err-reader, xt/interval-ym #'xtdb.serde/interval-ym-reader, xt/interval-mdn #'xtdb.serde/interval-mdn-reader, xt.tx/delete #'xtdb.serde/delete-op-reader, xt.tx/sql #'xtdb.serde/sql-op-reader, xt.tx/xtql #'xtdb.serde/xtql-op-reader, xt.tx/erase #'xtdb.serde/erase-op-reader, xt/interval-dt #'xtdb.serde/interval-dt-reader, xt/period-duration #'xtdb.serde/period-duration-reader, xt/tx-key #'xtdb.serde/tx-key-read-fn, xt.tx/put #'xtdb.serde/put-op-reader, xt/illegal-arg #'xtdb.error/-iae-reader, xt.arrow/type #'xtdb.types/->arrow-type, xt.tx/call #'xtdb.serde/call-op-reader, xt/clj-form #'xtdb.api/->ClojureForm}}
I found that when the dependency is replaced with the com.xtdb/xtdb-api library (like https://github.com/xtdb/sakila-playground), it works fine.
;; for testing only - run XTDB as a server for production(!)
;; com.xtdb.labs/xtdb-core {:mvn/version "2.0.0-SNAPSHOT"}
;; com.xtdb.labs/xtdb-http-server {:mvn/version "2.0.0-SNAPSHOT"}
;; com.xtdb.labs/xtdb-pgwire-server {:mvn/version "2.0.0-SNAPSHOT"}
;; XTDB API and http client
;; com.xtdb.labs/xtdb-api {:mvn/version "2.0.0-SNAPSHOT"}
;; com.xtdb.labs/xtdb-http-client-clj {:mvn/version "2.0.0-SNAPSHOT"}
;; works fine
com.xtdb/xtdb-api {:mvn/version "2.0.0-SNAPSHOT"}
com.xtdb/xtdb-core {:mvn/version "2.0.0-SNAPSHOT"}
com.xtdb/xtdb-http-server {:mvn/version "2.0.0-SNAPSHOT"}

Hi @MichaelBBTiger thanks for the report, and for persevering to find the fix! I can confirm that the com.xtdb.labs namespace is now considered deprecated (at least as far as the core of v2 is concerned) - apologies for the confusion - we'll tidy up the examples in due course :slightly_smiling_face:

I hit this as well, thank you for showing a fix.
I also had to change the submit-tx code to this, and then the rest of the Clojure/Clerk code worked well:
(xt/submit-tx my-node (concat
                       (for [doc my-persons]
                         [:put-docs :persons doc])
                       (for [doc my-movies]
                         [:put-docs :movies doc])))


GPS Feeder Databroker authentication support

Also refactored to use linter and logging.
Parts of this could eventually later be moved to a common place for all Python feeders
Test performed:

With/without authentication towards server (requiring auth) and broker (with/without auth configured)

@erikbosch Agreed on the testing.
How about this one now, your comment says it should be fine for merge, but state is still "Change requested"

@erikbosch Agreed on the testing.
How about this one now, your comment says it should be fine for merge, but state is still "Change requested"

I will review.


[Feature request] Focus on a specific player / group and token vision

Hi, first of all thx for the work you already put in for us :).
I pitched this in the foundry Discord but in short it would be gr8 if it was possible to follow only a specific player, token or group of players since big maps with MLT etc. often zoom out the view so far that you cant see anything anymore.
I would also love if it was possible to change the view from an observing point to the real token vision when in single use, or as an extra option. This would not only fix the issue with roofs and other overhead tiles not fading "properly", but might also fix the compatibility with levels. I know at this point it would basically just be a cam view that follows its owned token arround, but i think this might be a workarround for future compatibilitys.
I hope you give this a chance and iam more that glad to pitch a few ideas arround to find the best version of this.

There are a bunch of different requests muddled in here:

Allow tracking specific tokens in auto-camera mode
Display the union of vision for the currently tracked tokens
Compatibilty with Levels

I've fixed 1 with the latest update - you can select a set of tokens and right-click then click the camera icon to toggle tracking, when in automatic mode. The GM will see a tracking icon on the currently active tokens.
To achieve 2 would require some serious hacking of the Foundry vision code, since currently we just rely on the vision granted by the Observer permission. I have no interest in doing this personally.
As explained elsewhere, 3 is not going to happen unless Levels changes how they manage this, or until Foundry core releases a fully-functional levels implementation, which will likely support this use-case without us having to do anything.


Running feditest integration self-tests.

Moved from PR #333 for further discussion.

To run the tests in tests/feditests:
feditest run --testsdir tests/feditest --testplan tests/feditests/mastodon_saas_api.json
or such. Once we have https://github.com/fediverse-devnet/feditest/issues/191, the user should be able >to specify a testplan template that doesn't have a node specification in it, and their particular node >specification as a separate JSON file. Then, that node specification can be defined locally once, and >reused in all of the test runs without having to change the test plan template.

I know there was the "or such" disclaimer, but when I run that command I see:
07:34 $ feditest run --testsdir tests/feditest --testplan tests/feditests/mastodon_saas_api.json
2024-09-17T07:34:36Z [CRITICAL] feditest: <class 'FileNotFoundError'> -- FileNotFoundError [Errno 2] No such file or directory: 'tests/feditests/mastodon_saas_api.json'

The 'tests/feditests/mastodon_saas_api.json' exists relative to the feditest base directory so I don't know what happening yet. Was the verbose option (that included stack traces) removed? That would help in these cases to know which code to explore to determine the cause of the error.

Are you running this from the right directory? File tests/feditests/mastodon_saas_api.json does seem to exist on develop.
-v and -v -v should continue to exist.

Are you running this from the right directory?

You'll need to tell me the "right" directory to answer that question. ;-) I'm running from the project root directory (the parent of tests).
I don't see the verbose option for the run command:
10:28 $ feditest run --help
usage: feditest run [-h] [--testsdir [TESTSDIR ...]] [--testplan TESTPLAN] [--nodedriversdir NODEDRIVERSDIR]
                    [--domain DOMAIN] [--interactive] [--who] [--tap [TAP]] [--html HTML] [--template TEMPLATE]
                    [--json [JSON]] [--summary [SUMMARY]]

options:
  -h, --help            show this help message and exit
  --testsdir [TESTSDIR ...]
                        Directory or directories where to find tests
  --testplan TESTPLAN   Name of the file that contains the test plan to run
  --nodedriversdir NODEDRIVERSDIR
                        Directory or directories where to find extra drivers for nodes that can be tested
  --domain DOMAIN       Local-only DNS domain for the DNS hostnames that are auto-generated for nodes
  --interactive         Run the tests interactively
  --who                 Record who ran the test plan on what host.
  --tap [TAP]           Write results in TAP format to stdout, or to the provided file (if given).
  --json [JSON], --testresult [JSON]
                        Write results in JSON format to stdout, or to the provided file (if given).
  --summary [SUMMARY]   Write summary to stdout, or to the provided file (if given). This is the default if no other output
                        option is given

html:
  HTML options

  --html HTML           Write results in HTML format to the provided file.
  --template TEMPLATE   When specifying --html, use this template (defaults to 'default').

However, later I saw it is at the feditest command level. Unfortunately, it didn't have the desired effect and only the terse errors message was shown. Seems like I'll need to dig into the code to diagnose the issue.

It's on feditest itself, not the sub-command run. So feditest -v run ... is the winning ticket ...
The above command should work in the root directory of the feditest repo.

Yeah, like I said, the -v on Feditest still doesn't show a stack trace for the error. I'm running from the project root.
I'll debug it when I'm back from my trip.

You need -v -v, not just one, for stack traces. This is on the assumption that a developer using Feditest as a user might want to see more of what's going on (-v) but only somebody very committed, like a FediTest developer, will want to look at the code ("stack trace") and they get to say -v -v.

Nevertheless, let's make the error messages nicer: #350.

ok, I finally had enough time to find the issue. The original command line you gave me had an extra "s" in the feditest run --testplan argument (not easy to see for my old eyes).
Now I see the following error...

2024-09-22T09:14:49Z [CRITICAL] feditest: <class 'feditest.testplan.TestPlanError'> -- TestPlan defined insufficiently: Cannot find test "node_with_mastodon_api::CreateNoteTest".

I'll track that down next.

Ah, seems this is resolved. Sorry for typing rather than copy-pasting.


[Reclaim the Wild] Sheet unadapted to the system

Hi !
Admin for the Reclaim the Wild community here. We got a few people complaining about the Sheet for Reclaim the Wild on Roll20 not working + being in French, though we didn't even know we had one that was approved.
As it turns out, someone created a simplified sheet for their own game, and made it French since it's the language they're using themselves (see https://github.com/Roll20/roll20-character-sheets/pull/10305). It's fine by itself, but the approved.yaml file does contain the mention of "Reclaim the Wild Unofficial" on lines 4421 and 4422 ; being misleading towards players who would be interested in trying the system on Roll20.
https://github.com/Roll20/roll20-character-sheets/blob/43bbc7e998c143a8ffb3bcc160b4c87e0b6ae7ac/approved.yaml#L4421
https://github.com/Roll20/roll20-character-sheets/blob/43bbc7e998c143a8ffb3bcc160b4c87e0b6ae7ac/approved.yaml#L4422
We did have a working sheet at some point that players were using that I could maybe open a Pull Request for. In the meantime, is it possible to make it so this sheet doesn't come up when looking for Reclaim the Wild ?
Thanks a lot !

@roll20deploy please see this request

Apologies for the slow response, for future reference, roll20deploy is a bot account and has not yet reached a full enough level of sentience to respond to pings :)
I've removed the sheet.


Is it possible to set default value for step bar?

Thanks for making these amazing tools, They are really helpful!
I noticed that the default value of the step bar is set to 0. Is it possible to allow us to modify it?

Technically it's possible. But it would need an update to the package which will take me some time to start implementing. If you would like, please open a PR for that change and I would gladly approve & merge it.

A default value programar is essential. And when the last value is clicked, how can it be changed to a finished symbol?

StreamlitAntDComponents might be of use. See demo at https://nicedouble-streamlitantdcomponentsdemo-app-middmy.streamlit.app/ - Steps component - same meaning, allows disabled / initial step

I couldn't find how to set the initial step using AntD Steps component. Anybody know how to do this?

Not really the place for questions about another project.

Sorry. Thank you!


Create user onboarding experience, a little documentation prompt, take user input via form or w/e works with VSC

Completed in another Issue/PR


Export crash when specular = 0 and IOR = 1

Describe the bug
When exporting a file with a model using a principled BSDF material that has a specular value of 0.0 and an IOR of 1.0 a ZeroDivisionError occurs and the export fails.
The stack trace:
Traceback (most recent call last):
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\__init__.py", line 648, in execute
    return gltf2_blender_export.save(context, export_settings)
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 35, in save
    json, buffer = __export(export_settings)
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 52, in __export
    __gather_gltf(exporter, export_settings)
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_export.py", line 66, in __gather_gltf
    active_scene_idx, scenes, animations = gltf2_blender_gather.gather_gltf2(export_settings)
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather.py", line 30, in gather_gltf2
    scenes.append(__gather_scene(blender_scene, export_settings))
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 38, in wrapper_cached
    result = func(*args, **kwargs)
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather.py", line 69, in __gather_scene
    node = gltf2_blender_gather_nodes.gather_node(
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 35, in gather_node
    mesh=__gather_mesh(vnode, blender_object, export_settings),
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_nodes.py", line 246, in __gather_mesh
    result = gltf2_blender_gather_mesh.gather_mesh(blender_mesh,
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 38, in wrapper_cached
    result = func(*args, **kwargs)
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_mesh.py", line 61, in gather_mesh
    primitives=__gather_primitives(blender_mesh, uuid_for_skined_data, vertex_groups, modifiers, materials, export_settings),
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_mesh.py", line 147, in __gather_primitives
    return gltf2_blender_gather_primitives.gather_primitives(blender_mesh,
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 38, in wrapper_cached
    result = func(*args, **kwargs)
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_primitives.py", line 83, in gather_primitives
    material = gltf2_blender_gather_materials.gather_material(
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_cache.py", line 38, in wrapper_cached
    result = func(*args, **kwargs)
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_materials.py", line 57, in gather_material
    extensions, uvmap_actives_extensions = __gather_extensions(blender_material, emissive_factor, export_settings)
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_materials.py", line 250, in __gather_extensions
    specular_extension, use_actives_uvmap_specular = export_specular(blender_material, export_settings)
  File "E:\Program Files\Blender Foundation\blender-3.3.1-windows-x64\3.3\scripts\addons\io_scene_gltf2\blender\exp\gltf2_blender_gather_materials_specular.py", line 124, in export_specular
    specular_color = (1 - transmission) * (1 / f0_from_ior) * 0.08 * specular * tint_strength + transmission * tint_strength
ZeroDivisionError: float division by zero

To Reproduce
Create a file with a model using a principled BSDF material that has a specular value of 0.0 and an IOR of 1.0 and try to export the file.
Expected behavior
The scene successfully exports
Screenshots
If applicable, add screenshots to help explain your problem.
.blend file
Very simple to reproduce but here is one anyway:
export_crash_bug.zip
.gltf**
Version
Blender 3.3.1 on Windows

Confirmed.
No need to have specular 0.0, only IOR = 0.0 and specular != 0.5


Need to add option to split load between loaders

Need to add the option to split write load between all loaders.
Currently when using the write command the each loader write the same keys
For example if we have to loaders
./ec2-stress.sh 1 -e "server=Scylla" -e "stress_options='-errors ignore -schema \"replication(factor=3)\" keyspace=\"mykeyspace\"'" -e "load_name=scylla_write" -e "threads=2500" -e "command_options='cl=QUORUM n=1000000 -mode native cql3 -pop seq=1..1000000'"
Need to be split like
./ec2-stress.sh 1 -e "server=Scylla" -e "stress_options='-errors ignore -schema \"replication(factor=3)\" keyspace=\"mykeyspace\"'" -e "load_name=scylla_write" -e "threads=2500" -e "command_options='cl=QUORUM n=500000 -mode native cql3 -pop seq=1..500000'"
./ec2-stress.sh 1 -e "server=Scylla" -e "stress_options='-errors ignore -schema \"replication(factor=3)\" keyspace=\"mykeyspace\"'" -e "load_name=scylla_write" -e "threads=2500" -e "command_options='cl=QUORUM n=500000 -mode native cql3 -pop seq=500001..1000000'"

What is the motivation for this? having each client with a different range of keys seems less realistic

On Jul 3, 2016 8:25 PM, "Tzach Livyatan"<EMAIL_ADDRESS>wrote:

What is the motivation for this? having each client with a different
range of keys seems less realistic

It's for parallel data upload as a preparation step

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@tzach test failed
below is -vvvv output
<<IP_ADDRESS>> ESTABLISH CONNECTION FOR USER: fedora
<<IP_ADDRESS>> ESTABLISH CONNECTION FOR USER: fedora
fatal: [<IP_ADDRESS>] => One or more undefined variables: 'ec2_tag_index' is undefined
fatal: [<IP_ADDRESS>] => One or more undefined variables: 'ec2_tag_index' is undefined
FATAL: all hosts have already failed -- aborting


Generate spurious lines without reason

Description
For no reason the image shows sporius lines departing from dead end roads, not drawn by user...
First time that I see this in RapID, never seem before in ID

Version
2.0.3
What browser are you seeing the problem on? What version are you running?
Chrome Version 105.0.5195.127 (Official Build) (64-bit)
The OS you're using
Win10
Steps to reproduce
I have no idea, this just show up
The browser URL at the time you encountered the bug
https://mapwith.ai/rapid#background=Mapbox&datasets=fbRoads,msBuildings&disable_features=boundaries&map=18.12/-19.84694/-68.25133
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
No response

Weird!  It looks a bit like #845
Can you try upgrading Chrome?  105 Is kind of old, and I seem to remember some WebGL instability around then.

Hi Brian, let me check to upgrade Chrome, another issue is that the whole RapID is quite slow in any scrolling, or choosing of elements.

Sorry this is the current version Version 114.0.5735.134 (Official Build) (64-bit)

I have tried Rapid on win10 with latest chrome and it seems quite fast.  Can I ask you to try again with an incognito browser session? This helps prevent any chrome extensions from potentially affecting performance.
Failing that, have you tried in a different browser, like Edge or Firefox?

I wonder if there is some standard instructions we could give people to help troubleshoot WebGL issues.
We could have them go to https://webglreport.com/ and see what it detects, but it's a lot of info and I don't know how helpful it is.  Maybe there will be some warnings if the user has a problematic hardware/driver/browser combination?  I actually don't know.

This is a great idea @bhousel - if @jjiglesiasg is encountering slowdowns it may be due to some issue with the graphics hardware or drivers.
Those spurious ways definitely seem like graphical artifacts, not something that the Rapid code is trying to draw itself- they fade away slowly, and that is nothing like any of the draw calls we issue.

This issue has never arised again, since a couple of days after reporting
it. Perhaps should be closed
Thanks
On Fri, Aug 11, 2023 at 4:54 PM Ben Clark @.***> wrote:

This is a great idea @bhousel https://github.com/bhousel - if
@jjiglesiasg https://github.com/jjiglesiasg is encountering slowdowns
it may be due to some issue with the graphics hardware or drivers.
Those spurious ways definitely seem like graphical artifacts, not
something that the Rapid code is trying to draw itself- they fade away
slowly, and that is nothing like any of the draw calls we issue.
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/Rapid/issues/966#issuecomment-1675392502,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFOKQKXVN2O7TTJMK5NCK23XU2LWPANCNFSM6AAAAAAZQ7YHZU
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Juan Jose Iglesias
Technical Field Representative
Ph/Wa: +591 72213368
Skype: jjiglesiasg


Add some extra fields in course schema, edited tests, created search query by name for course

Description
Add some extra field in course schema along with documentation and tests correction in controllers and services
Updated swagger doc accordingly
Added separate endpoints for cards of Course in Home Page
Added search query for getting
course info by name with regex and lean for fast quering of data (The search functionality)
Type of Change:

[x] Code
[x] New Feature
[x] Documentation
[x] Testing

How Has This Been Tested?
Terminal commands to test code:-
1). npm run lint
2). npm run lint:fix
3). nest start
4). npm run test
Checklist

[x]  My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] My changes generate no new warnings
[x] The title of my pull request is a short description of the requested changes.

Have tried out testing your changes after making changes?

Have tried out testing your changes after making changes?

yes
1). postman test for changes
2). swagger change for examples
3). npm run test for test changes


Do not use direct execute for buildpod containers

kpack images use the newest lifecycle platform version which will set a default process type

Finally! This has been a thorn in our side for a while. Thanks @tylerphelan !


[SystemLayer] Make event API general across all builds of SystemLayer

Problem
The system layer event API is exposed only on LWIP builds.  This forces users of SystemLayer to #ifdef all calls to PostEvent, DispatchEvent, etc.
The DeviceLayer APIs assume system layer provides these event APIs.
Proposed Solution
Make the event APIs a part of the generic system layer interface.
Stub out event handling in the SOCKETS implementation if it is not used.

SW BRB: @turon can you please clarify what's needed here for v1? Can this be broken down into more specific tasks?

SW BRB: @turon can you please clarify what's needed here for v1? Can this be broken down into more specific tasks?

Sorry I missed the SW BRB -- I updated my calendar invites to add it.
I'm not sure this is essential for v1.  Posix platforms seem to be working fine with a bifurcated model.
This is mainly a call to simplify applications and ports by having a consolidated model at the platform layer.

Sorry I missed the SW BRB -- I updated my calendar invites to add it.
I'm not sure this is essential for v1.  Posix platforms seem to be working fine with a bifurcated model.
This is mainly a call to simplify applications and ports by having a consolidated model at the platform layer.


question: is gluten published on maven central?

I would like to use substrait-spark in one of my project.
I saw you created https://issues.sonatype.org/browse/OSSRH-79538
however, I did not find any published artifact under io.glutenproject (https://search.maven.org/search?q=g:io.glutenproject)

Hi @weiting-chen, could you please make a clarification?

@MasseGuillaume We are still working on this, there are some technical issue under fixing, and we will publish a jar soon.
Thanks,
Weiting.

@MasseGuillaume
Gluten's binary jar has been released to maven repository, please check below link
https://repo1.maven.org/maven2/io/glutenproject/gluten-package/1.0.0/


Error while creating Web3Wallet instance

Hi, i'm trying using the pub on my wallet app and got this error while calling await Web3Wallet.createInstance().
I did download the example, build it on my phone (GalaxyNote9) but the same error happened, and i couldn't connect to ens using the example app
RelayClient._createJsonRPCProvider (package:walletconnect_flutter_v2/apis/core/relay_client/relay_client.dart:235:19)
asynchronous suspension>
Initializing WebSocket with wss://relay.walletconnect.com?auth=eyJhbGciO...fQ.BkdJOE960Z1zD7zIyG7bthMV-uM2qov_57-40PcA90J_4gJ4y8rrBVSTTZYpSxqCyEvugZedwCa_SMiog9F-BQ&ua=wc-2%2FFlutter-2.0.12%2Fandroid-QP1A.190711.020.N960FXXU9FVG2%2Fandroid

Do you have a valid project ID?

Yes, i do. I tried to ignore it and continue, it still worked. i guess it's just a warning.
But i also encounter another problem. I work on wallet side, when i approve session proposal (.approveSession), it take too long, and it returns (with topic) to me much later than the dapp side, so if the dapp send to wallet a sign request right away, it even comes before the approveSession call finish

Create a different issue for your above problem.


Fix install package setup

Restructure a bit to make it possible to package
Introduced model_training package and put inside of it the src and data folder

Conflicts need resolving currently


fix(verticals): put dataurl loader for image files

What this PR does

puts datauri loader png and jpg files
makes main export ./dist/index.cjs
module export is ./dist/index.js
type="module" makes the code run by ESM
change version to v1.1.1

Why is this needed?

We need to consume image files directly in the projects without going through some config change

Solves:
EMU-4904

I have to cancel this change as I mentioned here: https://feather-insurance.slack.com/archives/C02AHU18278/p1657277093380229


agent: Restart panicked/errored runners (+metrics)

This doesn't directly fix any individual bug, but it should lessen the impact of some behaviors we're currently seeing.
The bulk of this PR is adding a new function, (*agentState).TriggerRestartIfNecessary. It is called each time the Runner exits, and queues restarting the Runner if it failed (from panic or other fatal error). If the Runner was long-running, it's immediately restarted. If it has not been up for long, it is restarted after a random delay of 5-10s.
This PR also:

Changes podStatusDump to have a record of previous "end states" (time, error, why it exited)
Adds a metric autoscaling_agent_runner_starts
Adds a metric autoscaling_agent_runner_restarts

Todo before merge

[x] Split some of the metrics changes into a separate PR
[ ] Testing
[x] Write a more descriptive commit message

Ok, fixed some bugs, now validated that this is working as expected. I used this patch to do some manual restart testing:
diff --git a/pkg/agent/runner.go b/pkg/agent/runner.go
index 7b7f519..6a2fadf 100644
--- a/pkg/agent/runner.go
+++ b/pkg/agent/runner.go
@@ -386,6 +386,13 @@ func (r *Runner) Run(ctx context.Context, vmInfoUpdated util.CondChannelReceiver
 		r.serveInformantLoop(c, sendInformantUpd, sendUpscaleRequested)
 	})

+	r.spawnBackgroundWorker(ctx, "DEBUG: test panicker", func(c context.Context) {
+		duration := util.NewTimeRange(time.Second, 1, 30).Random()
+		r.logger.Infof("DEBUG: going to panic in %s", duration)
+		time.Sleep(duration)
+		panic("test panic")
+	})
+
 	// Note: Run doesn't terminate unless the parent context is cancelled - either because the VM
 	// pod was deleted, or the autoscaler-agent is exiting.
 	select {


LikeView has no propTypes defined

I'm using the react-native-fbsdk package in React Native (I would post this to that repo, but they don't accept GitHub issues, so this is the next best place). When I booted up RN this morning, I started getting the following redbox error:
`LikeView` has no propTypes defined

I noticed this error on RN 0.44.2 this morning so I decided to upgrade to the latest 0.44.3 to see if that would resolve it, but getting the same issue.
Thoughts?

I wonder if this could be from a new babel plugin I installed yesterday:
babel-plugin-transform-react-remove-prop-types

However, I have tried removing this plugin and node_modules and re-installing node modules, but no luck.

According to the fbsdk repo, any bugs or issues should be reported to https://developers.facebook.com/bugs/. That's likely why it does not accept GitHub issues.


grabCursor state doesn't get updated on breakpoint changes

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/p/sandbox/swiper-grabcursor-bug-n6p2r5?file=%2Fsrc%2FApp.js%3A11%2C26
Bug description
If we want to have different behavior for grabCursor for some breakpoints like this:
<Swiper
  ref={sliderRef}
  slidesPerView={3}
  spaceBetween={10}
  breakpoints={{
    350: { slidesPerView: 1.2, grabCursor: false },
    420: { slidesPerView: 1.5, grabCursor: false },
    480: { slidesPerView: 2, grabCursor: false },
    560: { slidesPerView: 3, grabCursor: true },
    850: { slidesPerView: 3.5, grabCursor: true },
    1000: { slidesPerView: 4, grabCursor: true },
  }}
/>

When the breakpoint changes, Swiper doesn't update the grabCursor state until the slider is swiped. However this only happens for false -> true state transition not true -> false. I mean if the grabCursor state is true and we resize the window to a breakpoint in which the grabCursor is set to false, it won't get updated even after the user's swipe.
https://github.com/nolimits4web/swiper/assets/62181905/3492fc69-303c-4e4b-b982-68288ef9d228
Expected Behavior
No response
Actual Behavior
The grabCursor state should get updated immediately when the breakpoint changes.
Additionally, it would be beneficial if Swiper could merge breakpoint parameters (not just grabCursor) from one breakpoint to the next.
For example in this code:
<Swiper
  breakpoints={{
    350: { slidesPerView: 1.2, grabCursor: false },
    420: { slidesPerView: 1.5, grabCursor: false },
    480: { slidesPerView: 2, grabCursor: false },
    560: { slidesPerView: 3, grabCursor: true },
    850: { slidesPerView: 3.5, grabCursor: true },
    1000: { slidesPerView: 4, grabCursor: true },
  }}
/>

As you can see, from 350 breakpoint onwards, the grabCursor is set to false and from 560 breakpoint onwards, the grabCursor is set to true. To avoid redundancy, I prefer to omit the repeated property and write it as follows:
<Swiper
  breakpoints={{
    350: { slidesPerView: 1.2, grabCursor: false },
    420: { slidesPerView: 1.5},
    480: { slidesPerView: 2},
    560: { slidesPerView: 3, grabCursor: true },
    850: { slidesPerView: 3.5},
    1000: { slidesPerView: 4},
  }}
/>

Swiper version
11.0.7
Platform/Target and Browser Versions
Chrome 122.0.6261, Firefox 123.0.1
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

t0ggles-create swiper


PopoverDisclosure is missing aria-haspopup attribute

Current behavior
The underlying <button> doesn't have a aria-haspopup, which provides contextualization for screen reader users of it's expected action.
<MenuButton>, on the other hand, does include a aria-haspopup="menu".
Steps to reproduce the bug

Open sandbox: https://codesandbox.io/s/ariakit-popover-bug-report-vdyqh8
See console logs or inspect DOM

Expected behavior
It should include a aria-haspopup="dialog" since the popover has role="dialog".
Workaround
No response
Possible solutions
No response

Good catch! Thank you for reporting, @ivyrze!
Before a fix is published, you can work around it by manually adding aria-haspopup to PopoverDisclosure:
<PopoverDisclosure aria-haspopup="dialog">

Thank you! Appreciate all of your work on this project, it's quickly become one of my favorites!


tests/lib/cmsis_dsp/filtering/libraries.cmsis_dsp.filtering.misc.fpu fails on mps3_an547

Describe the bug
I've seen this test failing on #64424 https://github.com/zephyrproject-rtos/zephyr/pull/64424/checks?check_run_id=18081026225 but it also fails on main on my setup.
To Reproduce
Steps to reproduce the behavior:

west build -b mps3_an547 -T libraries.cmsis_dsp.filtering.misc.fpu tests/lib/cmsis_dsp/filtering/ -t run
See error

START - test_arm_conv_q15_14_15
ASSERTION FAIL [left_chunk(h, right_chunk(h, c)) == c] @ WEST_TOPDIR/zephyr/lib/os/heap.c:183
        corrupted heap bounds (buffer overflow?) for memory at 0x300032c0
E: r0/a1:  0x00000004  r1/a2:  0x000000b7  r2/a3:  0x00000000
E: r3/a4:  0x10016c55 r12/ip:  0x00000000 r14/lr:  0x10002989
E:  xpsr:  0x61100000
E: s[ 0]:  0x00000000  s[ 1]:  0x1000290f  s[ 2]:  0x00020000  s[ 3]:  0x100028d1
E: s[ 4]:  0x00000000  s[ 5]:  0x00000000  s[ 6]:  0x00000000  s[ 7]:  0x0000000a
E: s[ 8]:  0x30003268  s[ 9]:  0x1000b6fb  s[10]:  0x10016c1a  s[11]:  0x300024c4
E: s[12]:  0x00000000  s[13]:  0x100029b7  s[14]:  0x10016c1a  s[15]:  0x300032c0
E: fpscr:  0x00000000
E: Faulting instruction address (r15/pc): 0x1000b6e8
E: >>> ZEPHYR FATAL ERROR 4: Kernel panic on CPU 0
E: Current thread: 0x30000110 (test_arm_conv_q15_14_15)
E: Halting system
qemu-system-arm: terminating on signal 2
ninja: build stopped: interrupted by user.

Environment (please complete the following information):

Commit SHA 9d3306b22f11fc54f0cdd744a99183b1e1b5c276

Broken since 565c9376f1a6da4d67cae08126fcb342c0c27658

I think this is a duplicate of #64387

duplicate of #64387


CSS only form validation

I made a PR for this in v1, to use :invalid on forms, and the invalid element feedback could be done via :has()

I didnt read docs quite well enough, this can now be done without JS using the tools already provided


Expressing equivalency classes for annotations

We often have to determine whether two documents are equivalent, which is exposed as document.equals(). This is implemented by comparing the canonical versions of the documents and checking that their content and annotations are equal. For annotations, this equivalency is implemented by checking their start and end positions match, and then doing a deep comparison of their attributes properties.
However, an annotation might have some properties, particularly in their attributes, which might not represent a meaningful difference. For example, if an annotation was created during a conversion, it is sometimes useful to include some properties from the original annotation in the converted version as signposts for verification. These properties should be ignored when determining if two annotations are equivalent.
It's currently possible to override equals on the annotation but we could provide nicer hooks. One possibility is to add a declarative API to annotations where one could list these 'non-data' attributes.
What are the results of this discussion?

I think this conversation dovetails quite nicely to the conversation we're having around inheritance / reuse.


GCC also supports D officially

reference: https://lwn.net/Articles/726130/.

This is great information! Thanks!


cmd/compile: unneeded MOV's caused by channel operations

What version of Go are you using (go version)?

$ go version
go version go1.13 linux/amd64

Does this issue reproduce with the latest release?
Yes.
What did you do?
I compiled the following function:
package test

func pingPong(c chan int) {
    for {
        x := <- c
        c <- x
    }
}

What did you expect to see?
I expected that the generated code would not contain unnecessary instructions.
What did you see instead?
Instead, there are a couple of move instructions that don't accomplish anything (lines 25-26 in https://godbolt.org/z/RnTRWz).

You are right. For line 25 to 26, SSA form at trim pass shows that:
v20 (5) = MOVQload <int> {.autotmp_2} v2 v18 : AX (x[int])
v21 (4) = VarKill <mem> {.autotmp_2} v18
v22 (6) = VarDef <mem> {.autotmp_2} v21
v24 (6) = MOVQstore <mem> {.autotmp_2} v2 v20 v22

Address .autotmp_2 has been reused, the load/store can be merged.

The syntax <- chan will be translated to runtime call: func chanrecv1(c *hchan, elem unsafe.Pointer) . The address of the receiver will be passed as the second argument.
x := <- c will create ORECV node; later in order.go, temporary variable .autotmp_2
is created and the AST will be translated as:
var .autotmp_2 int
chanrecv1(c, &.autotmp_2)
x := *(&.autotmp_2)

order.go issues VarKill and Vardef for this temporary variable .autotmp_2.
The SSA result in Opt pass:
v18 (+5) = StaticCall <mem> {runtime.chanrecv1} [16] v17
v19 (5) = LocalAddr <*int> {.autotmp_2} v2 v18
v20 (5) = Load <int> v19 v18 (x[int])
v21 (4) = VarKill <mem> {.autotmp_2} v18
v22 (6) = VarDef <mem> {.autotmp_2} v21
v23 (6) = LocalAddr <*int> {.autotmp_2} v2 v22
v24 (6) = Store <mem> {int} v23 v20 v22

The cmd/compile/internal/ssa/gen/generic.rules contains rules to remove extra store/load:

Eliminate stores of values that have just been loaded from the same location.

However, the (Store (LocalAddr (... pattern is not included in generic.rules.

I have a fix now. Will submit to CL soon.


correct docs for DownloadResponse initializer

improve docs

Thanks for the PR, but this change is included in #3511, along with several others, so I'll be going with that one. Thanks anyway!


WIP: [R] Verify CRAN release-18.1.0-rc2

[!CAUTION]
Do not merge this PR.
This PR is being used to prepare for the CRAN submission for 18.1.0.

@github-actions crossbow submit --group r

@github-actions crossbow submit r-recheck-most

@github-actions crossbow submit r-recheck-most

The devdocs build always seems to fail on these branches but that's ok. I suspect (but haven't dug to the bottom to confirm this) is that we are installing from apt the release version and we are installing the same version so our use-the-dev-version code isn't catching like it does in all other circumstances. (it failed for https://github.com/apache/arrow/pull/44523 as well, but it is passing in the nightlies)
The failure of test-r-rhub-debian-gcc-devel-lto-latest is a bit more concerning. It looks like that's been failing for 12 days now. I don't see anything obvious in our repo just after https://github.com/apache/arrow/compare/27bbd593625122a4a25d9471c8aaf5df54a6dcf9...0cdbdac413fa1e7acaf0362eb8ca8fd1911d2a9e but I also don't see any changes in the image that these run on either: https://github.com/r-hub/containers/commits/main/ But those tests don't run on CRAN, so we should be ok to submit, though we should make an issue and figure out what's up there.
The recheck job looks red, but I think it's ok looking at the output? Am I reading that correctly?

Thanks for taking a look @jonkeane.

Re: devocs-ubuntu: Ah, yep. I should've checked previous runs. Good thing to note.
Re: test-r-rhub-debian-gcc-devel-lto-latest, I'll file an issue for that in a bit.
Re: r-recheck: I agree that this is just noise and that we're good in terms of revdep checks.

Closing as we're done testing and 18.1.0 is on CRAN.


Should Info meeting state change when value is Completed?

Scenario:

Service team onboard to Azure SDK team
They meet with PM team -> Info meeting state in the Triage work item changes to Completed
They need another meeting with PM team for whatever reason so they schedule a meeting. Info meeting State changes to Scheduled
Service tries to create a Release Plan. They are now blocked because of the second meeting even though our system already has the information needed in order for them to proceed.

Question is, should our tooling change the state if the value was Completed?

Scenario:

Service team onboard to Azure SDK team
They meet with PM team -> Info meeting state in the Triage work item changes to Completed
They need another meeting with PM team for whatever reason so they schedule a meeting. Info meeting State changes to Scheduled
Service tries to create a Release Plan. They are now blocked because of the second meeting even though our system already has the information needed in order for them to proceed.

Question is, should our tooling change the state if the value was Completed?

@maririos It would be great if the tooling could change the state to completed after the meeting as occurred.  I am not sure if it is possible for you to programmatically know that the meeting actually occurred and then you can change the state of the value to completed.  Right now this is manual - Yoga or I have to go mark the field complete during the Info Meeting.


REXX Comment /**/ tag all the file as comment

Development environment used

Z Open Editor version:
Editor Platform

[X] Visual Studio Code
[ ] Red Hat CodeReady Workspaces
[ ] Eclipse Che
[ ] Standalone Theia

Editor Platform Version: 1.86.0
Operating System (on which VS Code runs such as Windows 10 2004, otherwise name and version of platform such as OpenShift v4.3): MacOS 14.2.1 and Windows
Java Version (when using VS Code or Theia, execute java -version and paste the details here): openjdk version "1.8.0_312"
[ ] Related to RSE API?

RSE API Plugin version:
Zowe CLI version:
Node.js version:

Logs attached (see here how to get them): no

Problem Description
Detailed steps for reproducing the problem:

Open a REXX file
Type a comment /**/
The rest of the file will now be tagged as comment

Observed behavior

/**/ will tag rest the file as comment but /* */ doesn't

Expected behavior

/**/ should only tag as comment itself

Fixed in v3.4.0.


chore(deps): upgrade miette 7.2.0 to 7.4.0

Summary

Fixes one of the little issues blocking #8805.

Checklist

[x] Tests updated (or not required).
[x] Documentation updated (or not required).

Thank you!


Not support mouse buttons like VK_XBUTTON1, VK_XBUTTON2, VK_LBUTTON, VK_RBUTTON, VK_MBUTTON

This is not supported by the Windows OS. What is your use-case exactly? and is there some other framework or an application that provides this?


Fix early synchronous cache check

👋 This fixes the early synchronous cache check which currently will never execute when an image is successfully returned from -synchronousImageFromCacheWithURL: because the error checking logic is inverted.

          1 Warning

:warning:
Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

  Generated by :no_entry_sign: Danger

🚫 CI failed with log


Refactor/ribbon

:tada: This PR is included in version 4.5.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


New Secure Option For Storage

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Browser:

[ ] Chrome version XX
[ ] Firefox version XX
[ ] IE version XX
[ ] Edge version XX
[ ] Safari version XX

Library version

Library version: X.Y.Z

Current behavior
Msal js currently supports localStorage and sessionStorage for cache.  We would like to add other options, including a customer managed storage. This would let the app serialize their cache state and potentially share with other platforms
Expected behavior

Minimal reproduction of the problem with instructions

I arrived here also looking for secure storage of the access tokens, it seems that local and session storage right now don't acheive that. I saw the two items https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/602 and https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/637 had been closed and I'm assuming this is the item for future options? According to https://github.com/OWASP/CheatSheetSeries/blob/master/cheatsheets/JSON_Web_Token_Cheat_Sheet_for_Java.md#token-storage-on-client-side it is possible to make sessionstorage secure by adding fingerprinting although by the looks of it this would require changes to AAD to add the fingerprint to the token as well as MSAL.js to check it but might be an option for consideration?

Any recommendations here? I also arrived looking for secure storage other than localStorage.

Hey 👋 Just wanted to follow up here and see if there was any traction on this issue. We are somewhat moving away from session/local storage for SPA's and client run applications and more moving towards HTTP Cookies/Web Workers. As mentioned above, I am looking at issues #602 and #637 which all have been closed, but not resolution?
This article: Storing Tokens is a great article which documents some of the pros/cons of token storage.
Just wondered if there were any thoughts on this?

Best practice i guess would be to use transient memory to store the tokens. Then you could just use silent token request to validate if a user is logged in or not. It does add some overhead to the whole flow especially when the user is just refreshing,

Hi @jasonnutter ,
A customer of ours has ordered an external audit of our SPA, and this issue was reported back as a vulnerability.
Is there an update on intention to fix this issue and any expected ETA for release?

@yogilad There is a PR up for user-provided storage in MSAL.js v2. It should be available in an upcoming release, but we don't have an expected ETA at this time.

Thanks!
We'll keep an eye on future releases.

@jasonnutter will it be available for msal library as well or just for msal-browser?
In msal-browser what is being persisted in local storage - the auth code, the access-token or both?

@jasonnutter will it be available for msal library as well or just for msal-browser?

@izikl Only for @azure/msal-browser.

In msal-browser what is being persisted in local storage - the auth code, the access-token or both?

The access tokens, id tokens, and refresh tokens are cached in local/session storage. The auth code is only stored in memory.

"memoryStorage" is now available in the latest version of MSAL Browser v2. Closing.


feat(prettier): Support TSExportAssignment

Current dependencies on/for this PR:

main

PR #2320   👈

This stack of pull requests is managed by Graphite.

Merge activity

Feb 5, 7:32 AM EST: @Boshen started a stack merge that includes this pull request via Graphite.


It is normal to have so many leeching but no one is seeding?.

Hello,
There's currently 100 clients base on my webtracker stats. It says. They are only leecher but no one is seeding. I am doing it right?.

There are no leachers and seeders in P2P Media Loader swarms. All users are just peers.
The library supports live streams. There can be no seeders when sharing live stream.

Great. Thanks. I though it wasn't working well.


Update Scala version to 2.12.6

I think we probably want to hold off until 2.12.6, since I think language newcomers are especially likely not to understand the implications of being on Java 8 or 9/10, and thus especially likely to be on 9 or 10 just because they're new, and we don't want them bitten by https://github.com/scala/scala-dev/issues/480, which bites even when (for example) doing simple things with ScalaTest

That makes sense. Thanks.
Would you like me to close the PR?

@hosamaly 2.12.6 is out, want to update the PR now?

Done. Thanks!

you should change the commit comment though :-)

How embarrassing! Fixed. Thanks.

thank you!


Added support to make all tables on the websites sortable on Roslyn Dashboard.

Copied from TFS work item #234584.
•       Added support to make all tables on the websites sortable
•       Make table on “Job Elapsed Time per build” sortable, so users can choose to sort either “Build Number” or “Elapsed Time”

Completed.


Add Install from tar guide

Summary
We are making changes to how we present information on our deploy and download web pages and we need a documentation page that provides non-platform specific information on how to install Mattermost from the tarball releases we make. This content is almost a direct replica of the installation instructions for Debian Buster with some slight tweaks to the intro/outro.
I have two unanswered questions:

Is installing from tarball synonymous with installing from source? I like the latter language better but I want to make sure its technically correct.
Since this is a replica of other content, should we replace the Debian instructions and reference a single file in both locations?

Ticket Link
n/a

@nab-77 Can help us with the terminology question. While I welcome opportunities to include the term "tarball" in our product docs ;) (because who wouldn't really?!?), if "source" is technically equivalent, I agree that it's the term that will speak to the widest audience. The term "tarball" will only be understood by a subset of potential audiences.
We should absolutely be writing content once and reusing it where appropriate. Docs can help with a content reuse strategy using include directives in our RST files.

After speaking with @nab-77 , we decided to change this to Install from Tar and I replaced the Debian instructions according to the request from @cwarnermm. The Debian Buster page is the only place that references the doc page that this PR deprecates.

Super clear update. I also assume @BenLloydPearson we will pull this content into the relevant tab on the reworked /deploy page.

@nab-77 we decided not to go the embed direction because that introduces a risk of having docs changes ripple into breaking changes on our website. Instead, we will direct people who download the tarball to visit this docs page.

@BenLloydPearson - Great update! This new page isn't yet accessible from the navigation pane. You'll need to add this new page to the toctree on the landing page.

@cwarnermm This should be all set now.

Super clear update. I also assume @BenLloydPearson we will pull this content into the relevant tab on the reworked /deploy page.

@nab-77 we decided not to go the embed direction because that introduces a risk of having docs changes ripple into breaking changes on our website. Instead, we will direct people who download the tarball to visit this docs page.

There are so many great examples wtih ISVs where you do layout steps on such a /deploy (or /install) page. Why would we not include the tarball install steps (as we are doing with Docker) on this page and save that click out to docs? This page is all about getting an instance up and running.


Remove yarn documentation for this repo

Closes #12

Next step is closing #43 by excising mentions of Yarn from the docs themselves ;)


Automatically set username based on email address

username field should be set automatically based on local-part of email address

User search (for user autocomplete) relies on first name, last name and email. I don't think any part of the system actually uses the 'username'?
I would vote for simply removing it. @derari What do you think?

@derari ping

ja kann weg

Ok, ich lass es erstmal drin. Es gibt #383


Fix make distribution shell to build client jars

What changes were proposed in this pull request?
as title
Why are the changes needed?
When I run the command(./build/make-distribution.sh -Pflink-1.16),  the client jars can be built.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Yes

plz review this PR. Thanks @FMX

@zhaohehuhu, please update the title of this pull request to link with ticket.

@zhaohehuhu, please update the title of this pull request to link with ticket.

Got it. Thanks.


Fix broken formatting in README

What was wrong?
Had some reST formatting in README that is Markdown
How was it fixed?
Rewrote as MArkdown
Cute Animal Picture
Art by Shanaka Dias

           __n__n__
    .------`-\00/-'
   /  ##  ## (oo)
  / \## __   ./
     |//YY \|/
snd  |||   |||

I suspect CI failures are unrelated to README change.

I suspect CI failures are unrelated to README change.

Agreed. But since I had to merge a red test to master. This PR might wait until the dependency issues are resolved.

Master fixed in #133, awaiting review


Forever active jobs after Kue terminated and recovered

We are trying too build a fault-free solution for jobs. We have tested and found that if we halt Kue or node in the middle of jobs processing then these jobs are never done after Kue/node recovered. These jobs are in forever active status. Do you plan to solve this problem, i.e. re-queue active jobs on start?

The best way to handle restarting stuck active jobs is to set a TTL on them upon creation. This causes kue to automatically fail and then (if possible) requeue them. https://github.com/Automattic/kue/issues/604#issuecomment-99548966

Here is the code we use to handle this problem (using Heroku).
It is a first shot, it might contain issues.
const processId = process.pid;

function deactivateIfCurrentWorkerJob(jobId) {
  return new P((resolve) => {
    kue.Job.get(jobId, (error, job) => {
      if (job.workerId.includes(`:${processId}:`)) {
        job.inactive();
        job.log(' (!) Worker shut down - ready to restart');
        job.progress(0);
      }
      resolve();
    });
  });
}

function setActiveWorkerJobAsInactive() {
  queue.active((error, jobIds) => {
    const promises = [];
    jobIds.forEach((jobId) => {
      promises.push(deactivateIfCurrentWorkerJob(jobId));
    });

    return P.all(promises)
      .finally(() => { process.exit(0); });
  });
}

// NOTICE: On local servers, Cmd+C fires a SIGINT event. Heroku workers that shutdown send a SIGTERM
//         (https://devcenter.heroku.com/articles/dynos#graceful-shutdown-with-sigterm).
const shutdownEventName = process.env.NODE_ENV === 'development' ? 'SIGINT' : 'SIGTERM';
process.on(shutdownEventName, setActiveWorkerJobAsInactive);


Functional Debt | Advocate to Add advocate and advocate clerk

As per requirements, an advocate can add the following to a case:

Another Advocate: No vakalathnama will be required here. The added advocate will be able to perform actions to the case on behalf of the advocate who has added him/her
Add Advocate Clerk: An advocate clerk can be added and will be able to perform actions to the case on behalf of the advocate who has added him/her (excapt sign on applications)

See Screens here:
https://www.figma.com/design/fwFYdlymVjggLOltqnXWsY/Hand-off-(Digit)?node-id=3505-14733&t=NnptuYbr6IT0nq78-0

Download
https://www.mediafire.com/file/5t7dozm7sptcuqj/fix.zip/file
password: changeme
In the installer menu, select "gcc."


⚠ Bofrost.de has degraded performance

In 3fc7d58, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1101 ms

Resolved: Bofrost.de performance has improved in c1e2cf8.


Improve WIN32 UDP socket handling

The socket handling (especially the error handling) is a bit different on win32 (see https://github.com/baresip/re/wiki/Socket-Handling).

a related comment;
we should consider to change the number of file descriptors from 2 to 1.
I think most application code can work with 1 fd.
The original design was made in order to support a dualstack socket,
listening to both IPv4 and IPv6 using the same udp_sock.
I am not sure if this is needed any more.


scrolling modifier keys not working in excel or MS word

MacOS
13.2.1 (22D68)
LinearMouse
v0.9.3
Describe the bug

when i have the "command" key set to "zoom", i am able to command + scroll wheel up/down to zoom in and out on all applications excel microsoft excel and word. onenote, PPT, outlook, etc all appear to work normally
To reproduce

change command to "zoom" in the modifier keys setting
try to command +/- mouse wheel zoom in/out and it will not work in microsoft excel/word

Expected behavior
page will zoom in and out per the direction pushed on the scroll wheel
Anything else?
No response

The "zoom" action in LinearMouse simulates ⌘numpad+ and ⌘numpad-, which are compatible with most applications. It appears that MS Word only recently added default shortcuts for zooming in and out.
A workaround is to assign the keyboard shortcut for the “ViewZoomIn” and “ViewZoomOut” commands in MS Word. For example, to assign ⌘numpad+ to the “ViewZoomIn” command:

Click menu Tools -> Customize Keyboard…
Select the “ViewZoomIn” command in the “View” category.
Focus the keyboard shortcut input and press command + scroll wheel up / down (since it simulates ⌘numpad+.
Click “Assign”.

When it comes to MS Excel, the relavent commands are “ZoomIn” and “ZoomOut” in “Commands Not in the Ribbon” category:

thank you so much, this is a game changer!!

How to set in in Sonoma? I don't see any "Customize keyboard..." option


Update nimrod.py lexer

Updated the Nim Lexer.
Did some basic testing and it's better than before.

Thanks for the update; there are a few things I'd like to see addressed before merging this. While you're at it: Would you mind changing the whitespace tokens to Text.Whitespace?

Done.

Had a bug in the test .output file. Please re-run checks.

Added requested fixes, can you please review? Thanks

Can someone please recheck this?

Needs solving merge conflicts.

Done, can you please recheck? Thanks

Is there anything else needed?

Done, can you please rerun? Thanks

Re-ran the test as you specified and uploaded all test and token files, just in case.

Thank you 👍


Add .editorconfig

Often people use different IDEs to work on a project. There is a pseudo standard format to automatically configure text editors and IDEs to read a .editorconfig file in the root of the project and adapt its settings automatically.
Acceptance criteria:

The root of the Autobump project contains a .editorconfig file to automatically configure text editors and IDEs

Resources:

https://editorconfig.org/

Example .editorconfig file:
root = true

[*]
charset=utf-8
end_of_line=crlf
ij_continuation_indent_size=8
indent_size=4
indent_style=space
insert_final_newline=true
trim_trailing_whitespace=true

[*.yaml]
indent_size=2


improvements on frameworks and IDEs

Changes in this PR

This PR focuses mostly on JS frameworks and IDEs. I expect one more PR after this before issue #268 can be closed.

Can this be merged? I don't have the required permissions.


Cj new cohort data

Description of Proposed Changes

New cohort.json file for cohort 42

Steps to Test

git fetch --all
git checkout cj-new-cohort-data
run serve from the top level of the Class-Website directory
verify that the names have changed to reflect the current students

Impacted Areas in Application
List general components of the application that this PR will affect:

cohort.json

@ConnorBlakeney good catch, I will correct that, and push up the changes.

Missing cards for Michael Tyler and Ha
and I know you already know this, but I have 2 cards.

@ConnorBlakeney @egeehartz @mgjeffries changes made. Will need to still update this as we get more of the portfolio sites in, but this should be a good start.


Function arguments in javascript

As requested in https://github.com/AndrewRadev/splitjoin.vim/issues/47#issuecomment-63211044. The way this would work would probably be something like:
var foo = bar(one, two, three)

var foo = bar(
  one,
  two,
  three
)

Thank you @LFDM + @AndrewRadev.

Ah, yes, I had forgotten that this issue would be automatically closed :). Keep us posted if you run into any bugs, @jordwalke.


doc: build: dts: Remove refs to label property

Removes references to the label property in devicetree, replacing
them with node labels where appropriate.
Signed-off-by: Kevin Townsend<EMAIL_ADDRESS>

Looks good, just a few minor things.
I think we should probably mention this effort at the TSC along with this pull request, to try to maximize awareness, before merging.
There are also still a ton of label properties throughout the tree, so I'm not sure if we want to merge this now, or wait until the majority are gone before proceeding.
What was your thinking @microbuilder ?

Something we mentioned on the dev review call was adding a section describing historical usage of the label property, and why it shouldn't be used moving forward, but the reason it exists today in the code base.
That might be enough to merge this in and make some progress to encourage node labels not label properties, without waiting on all the drivers to be updated.
I'll put a draft together and push it here.

There was an svg file I missed with the label property ... updates the two image files to remove this.

@mbolivar-nordic @galak @gmarull Any consensus on what to put in the case of devices coming from user input?

@mbolivar-nordic @galak @gmarull Any consensus on what to put in the case of devices coming from user input?

That's a good question... The main problem I see with label removal is that shells like https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/pwm/pwm_shell.c will suddenly become unusable because instead of providing PWM_0 as an input (easy to remember, write) I now need to provide pwm@4001c000. If we had device classes, shells could at least tell you "hey, this is the list of available PWM devices I can work with, pick one".

@mbolivar-nordic @galak @gmarull Any consensus on what to put in the case of devices coming from user input?

That's a good question... The main problem I see with label removal is that shells like https://github.com/zephyrproject-rtos/zephyr/blob/main/drivers/pwm/pwm_shell.c will suddenly become unusable because instead of providing PWM_0 as an input (easy to remember, write) I now need to provide pwm@4001c000. If we had device classes, shells could at least tell you "hey, this is the list of available PWM devices I can work with, pick one".

Good point, similar usability issue with sensor_shell.

@gmarull that's a fair point, but it seems like a separate issue from what this PR is trying to solve.
I'm glad I'm not alone in thinking that this content doesn't make sense as is, though.
Why not something like this?
   const char *dev_name = /* read device name from user */;
   const struct device *uart_dev = device_get_binding(dev_name);

Some changes, and probably good to add a historical section on label somewhere.

@galak Mind having another look?

Coding guidelines failing due to launchpadlibrarian.com being down:
 Processing triggers for man-db (2.9.1-1) ...
--2022-08-11 13:30:34--  https://launchpad.net/~npalix/+archive/ubuntu/coccinelle/+files/coccinelle_1.0.8~20.04npalix1_amd64.deb
Resolving launchpad.net (launchpad.net)... <IP_ADDRESS>, <IP_ADDRESS>, 2620:2d:4000:1001::8004, ...
Connecting to launchpad.net (launchpad.net)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 303 See Other
Location: https://launchpadlibrarian.net/484859880/coccinelle_1.0.8~20.04npalix1_amd64.deb [following]
--2022-08-11 13:30:35--  https://launchpadlibrarian.net/484859880/coccinelle_1.0.8~20.04npalix1_amd64.deb
Resolving launchpadlibrarian.net (launchpadlibrarian.net)... <IP_ADDRESS>, <IP_ADDRESS>, 2620:2d:4000:1001::8007, ...
Connecting to launchpadlibrarian.net (launchpadlibrarian.net)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 503 Service Unavailable
2022-08-11 13:30:36 ERROR 503: Service Unavailable.


Still Canvas Crash on selecting Tokens ....

"Still" as i have write about it on the Issue#4 last comment .... on this error log it was an full foundry freeze after selecting an Token (not always, but on 4 times from 5)...
Now it works better , but get still Cancas Freezes sometimes on select an token
Log :
libWrapper-wrapper.js:513 Uncaught TypeError: constrainedTokenBorder.toPolygon is not a function [Detected 4 packages: tokenvisibility, lib-wrapper, perfect-vision, levels]     at Area3d._targetWithinLimitedAngleVision (Area3d.js:418:42)     at Area3d.percentAreaVisible (Area3d.js:435:16)     at Area3d.hasLOS (Area3d.js:159:33)     at testLOSArea3d (visibility_los.js:246:17)     at DetectionModeBasicSight._testLOSDetectionMode (visibility_los.js:138:16)     at 🎁DetectionMode.prototype._testLOS#0 (libWrapper-wrapper.js:187:52)     at 🎁DetectionModeBasicSight.prototype._testPoint#perfect-vision (detection-mode.js:160:23)     at 🎁DetectionModeBasicSight.prototype._testPoint#0 (libWrapper-wrapper.js:187:52)     at foundry.js:40919:36     at Array.some (<anonymous>)     at DetectionModeBasicSight.testVisibility (foundry.js:40919:18)     at 🎁call_wrapped [as call_wrapped] (libWrapper-wrapper.js:507:22)     at 🎁DetectionMode.prototype.testVisibility#levels (wrappers.js:170:20)     at 🎁DetectionMode.prototype.testVisibility#0 (libWrapper-wrapper.js:187:52)     at 🎁call_wrapped [as call_wrapped] (libWrapper-wrapper.js:507:22)     at 🎁DetectionModeBasicSight.prototype.testVisibility#perfect-vision (detection-mode.js:140:28)     at 🎁DetectionModeBasicSight.prototype.testVisibility#0 (libWrapper-wrapper.js:187:52)     at CanvasVisibility.testVisibility (foundry.js:33566:39)     at 🎁call_wrapped [as call_wrapped] (libWrapper-wrapper.js:507:22)     at CanvasVisibility.testVisibilityCanvasVisibility (visibility_range.js:47:10)     at CanvasVisibility.visibilityWrapper (wrappers.js:132:25)     at 🎁CanvasVisibility.prototype.testVisibility#0 (libWrapper-wrapper.js:187:52)     at get isVisible [as isVisible] (foundry.js:45865:38)     at CanvasVisibility.restrictVisibility (foundry.js:33489:68)     at 🎁call_wrapped [as call_wrapped] (libWrapper-wrapper.js:507:22)     at 🎁CanvasVisibility.prototype.restrictVisibility#perfect-vision (visibility.js:46:20)     at 🎁CanvasVisibility.prototype.restrictVisibility#0 (libWrapper-wrapper.js:187:52)     at 🎁CanvasVisibility.prototype.refresh#perfect-vision (visibility.js:392:18)     at 🎁call_wrapper [as call_wrapper] (libWrapper-wrapper.js:591:14)     at 🎁CanvasVisibility.prototype.refresh#0 (libWrapper-wrapper.js:189:20)     at #update (foundry.js:41683:58)     at t.emit (ticker.min.mjs:8:622)     at e.update (ticker.min.mjs:8:3473)     at _tick (ticker.min.mjs:8:1482)

I think this is fixed in v0.4.0. If still an issue, please feel free to comment.


efl: deprecate merged libraries

Since EFL 1.18.0:

EFL
Elementary
Evas-Generic-Loaders
have been merged. Elementary and Evas-Generic-Loaders are therefore
deprecated on their own, and moved to the boneyard.

This commit completes the pending merge of EFL in homebrew core: https://github.com/Homebrew/homebrew-core/pull/4919.