Push Page weird behavior

Hi, I already ran the original  code and I happen to  have a very weird issue.
Whenever I reach the "Second Modal" and press the "Push Page" button nothing happnes. However, when I do "pop modals" I happen to come across with the pages that I actually "Pushed" on the Second Modal... which can be described like this:
At frist:
Home Page -> First Modal -> Second modal (PUSH)
After push:
Home Page -> Pushed Page from second modal -> First Modal -> Second Modal
After poping pushed page:
Home Page -> First Modal -> Second Modal
I dont know if I made my self clear, any ways, I'm tyring to figure out what is going on but I happen to hae the exact same issue when working along with my own solution...
Thank you!

@LoneStar1994 After looking at your flow.  This is working as I would expect it.
Sextant (like Xamarin Forms) has two distinct navigation stacks managed by the NavigationService.  You can push and pop to these stacks independent of each other.
What your experiencing is a scenario where the developer has allowed the user to push multiple pages onto the modal stack.  The user is then allowed to push a navigation page onto the stack.  The page being pushed onto the Page Navigation stack, doesn't give it screen precedence (i.e. it doesn't display over the top of the modal pages).  It is hidden behind the modal stack until the modal stack is cleared.  This is why when you push the page, then pop the other two pages you are on the "Red Page".
This is useful for moments when you might want to push a modal, navigate away from the underlying screen, pop the modal so the user doesn't see two navigations.
The onus is on the developer to manage the navigation stack for the user.
Does this answer your question?

Alright! I'll try it out, thank you a lot.

I've been trying around with lots of different combinations but can't make it work... I belive that there is something behind the "IObservable" rutine that I'm missing.  How do you implement this?:
(Sorry for being so annoying)
After that all you have to do is call one of the methods inside your ViewModels:
    /// <summary>
    /// Pops the <see cref="IPageViewModel"/> off the stack.
    /// </summary>
    /// <param name="animate">if set to <c>true</c> [animate].</param>
    /// <returns></returns>
    IObservable<Unit> PopModal(bool animate = true);

    /// <summary>
    /// Pops the <see cref="IPageViewModel"/> off the stack.
    /// </summary>
    /// <param name="animate">if set to <c>true</c> [animate].</param>
    /// <returns></returns>
    IObservable<Unit> PopPage(bool animate = true);

    /// <summary>
    /// Pushes the <see cref="IPageViewModel"/> onto the stack.
    /// </summary>
    /// <param name="modal">The modal.</param>
    /// <param name="contract">The contract.</param>
    /// <returns></returns>
    IObservable<Unit> PushModal(IPageViewModel modal, string contract = null);

    /// <summary>
    /// Pushes the <see cref="IPageViewModel"/> onto the stack.
    /// </summary>
    /// <param name="page">The page.</param>
    /// <param name="contract">The contract.</param>
    /// <param name="resetStack">if set to <c>true</c> [reset stack].</param>
    /// <param name="animate">if set to <c>true</c> [animate].</param>
    /// <returns></returns>
    IObservable<Unit> PushPage(IPageViewModel page, string contract = null, bool resetStack = false, bool animate = true);

Cannot make what work exactly?

What is the use case that you are solving that you are unable to accomplish?

The code you referenced is either the NavigationView or the ViewStackService both of which are sourced in this project, so you can view the implementations.

1.- I'm trying to do what you suggested, to clear the stacklayout. And I thought that using the "IObservable" implementation I could make it work, cus I see you have a "ResetStack" option, which I belive is what I need... some how...
2.- I have two modal pages. a "Login" page and a "Home" page... my idea is to PushModal from Login to Home and then push pages from homes... but everytime I pushpages from home they wont appear but next to the "LoginPage". So I expect to "flush" the stackview to prevent Loggin page to appear when pressing "back button" and also poping all pages to the second modal page...

If you could provide a sample repository to show what you are attempting that would be great.
I will go back to there are two navigation stacks that are not aware of each other.
I think the problem (this is without having looked at any code sample) is that your expectation of how modals work in Xamarin.Forms.  More specifically as the Xamarin Forms Modal Navigation docs state, modals must be explicitly dismissed from the screen.
If you push something onto the modal stack, it must be dismissed by the user (Popped from the modal stack) before elements on the Page Navigation stack are seen.  Unless I am wrong, you cannot push a Page to the Page stack from a modal page.
So I believe in the example you just provided, you would need to Pop the login page from the Modal Stack and then Push a Navigation Page to the PageStack.  You are attempting to start navigation from a modal page which I am not sure is possible.  And if it is in Xamarin Forms, then it would be a limitation of this library that you cannot currently do this.
when you set Current.MainPage = new NavigationPage(new Page()); in your App.xaml.cs of a Xamarin.Forms application, you aren't pushing a modal, you are setting a page that is wrapped in a navigation page to MainPage of the app.
Does that make sense?
Have you tried your same example in Xamarin.Forms just by using the INavigation interface?  I'd be interested if a Modal Page allows you to go directly into Hierarchical Navigation.
Additional reading

INavigation
Xamarin Forms Navigation

Modal Page
Hierarchical Navigation
A modal is generally a Page that is put in front of the user that demands attention.  Think of a JavaScript pop up that comes out and forces the user to interact.    It isn't apples to apples, but that is basically what is going on.  When you push a modal, you can push as many as you want onto a stack specifically for Modal Pages.  All the Hierarchical pages still exist behind all the modals, but until the modals are dismissed, the user cannot interact with them.  I explicitly call out the user interaction because the developer can still push and pop pages from the Hierarchical stack while modals are presented to the user.
So I am going to assume you have figured out how to make work what you needed?

Oh!! I Get It!!
So you use this "Modal" as a substitute for the "Master Detail" where "Master" is the Pop Modal" and the "Page" is just the subordinated of the root page... So that is why you cannot push pages from a modal! because modal is an auxiliar page but not ment to act as a "Main Page wich pushes subpages"...
If that is so then I think I'm getting the deal here.

Awesome.  Glad you're headed down the right path.  I am going to close this issue.  If you have anything else, feel free to reopen, or create a new issue.


[SPARK-5945] Spark should not retry a stage infinitely on a FetchFailedException

All - I've added a map to track the reasons, and counts / reason for stage failures. I then check whether to abort a stage based on whether there is a sufficient number of failures for a single reason.
The open questions are:

Is it really safe to assume that a FetchFailedException means that the BlockManager has failed, and it will work if we just try another one? E.g. does retrying the failed stage even make sense?
For the equality check, I'm using the failureMessage inside the handler for FetchFailed. Is it safe to assume that string will be consistent between subsequent stage failures or are there any counters or such in there that will change? If this isn't a safe item to use for comparison, is there any metric that can be used to track the number of failures for a particular reason?
How many attempts for a stage should be made before aborting? I know that a task can have up to 4  failures before it's aborted but since a stage may see multiple fetch failures from concurrent tasks, I assume this number should be higher.

Test build #30773 has started for   PR 5636 at commit 40aefbe.

Test build #30773 has finished for   PR 5636 at commit 40aefbe.

This patch fails Scala style tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

 case class StageFailure(failureReason : String)

This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30773/
Test FAILed.

Test build #30775 has started for   PR 5636 at commit f8744be.

Test build #30775 has finished for   PR 5636 at commit f8744be.

This patch fails Scala style tests.

This patch merges cleanly.

This patch adds the following public classes (experimental):

 case class StageFailure(failureReason : String)

This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30775/
Test FAILed.

Test build #30778 has started for   PR 5636 at commit 8fe31e0.

Test build #30778 has finished for   PR 5636 at commit 8fe31e0.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30778/
Test FAILed.

Test build #30779 has started for   PR 5636 at commit 729b7ef.

Test build #30779 has finished for   PR 5636 at commit 729b7ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30779/
Test PASSed.

Thanks @ilganeli  I took a quick look and have some high-level comments:

Checking for the exact same string is too restrictive IMO.  Eg., will the failure message include host names of the fetch failed? Even without that detail, I bet there are a lot of cases where the same real error can result in different msgs.
I think the count for stage failure should be reset every time the job completes.  If you have a really long running job , I could imagine some stage that is dependency on many downstream stages (eg., imagine a streaming job, where some common RDD is joined against lots of incoming batches).  On a big cluster, eventually nodes will go down and stages will fail, but as long as the subsequent retry works, everything is fine.  Over time, that same stage might fail a number of times, but as long as there is no more than one failure between each success, it would be completely normal (even expected to some extent).
Maybe we should still allow the old behavior of infinite retry, eg., maybe if the spark.stage.maxFailures is set to -1?  Though to be honest I can't really think of any reason you'd want infinite retry, I just wonder if we should leave the door open since it is a behavior change.

thanks for working on this!  This will be a great addition, I've seen this come up in a number of cases and its really hard for the average user to figure out what is going on, this will be a big help.

@squito Given that we can't check against the failure message, any ideas on what we can do instead? Is this information exposed in any way at the level of the DAGScheduler or do I need to figure out a mechanism to propagate the error info up in a more detailed way. I can add the config change to allow infinite retries and I'll add the clear at the end of the job - that seems reasonable.

Test build #30893 has started for   PR 5636 at commit d5fa622.

Test build #30896 has started for   PR 5636 at commit 0335b96.

Test build #30893 has finished for   PR 5636 at commit d5fa622.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30893/
Test PASSed.

Test build #30896 has finished for   PR 5636 at commit 0335b96.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30896/
Test FAILed.

retest this please

retest this please

Test build #30947 has started for   PR 5636 at commit 0335b96.

retest this please

Hi @ilganeli thanks for updating this.  Not sure if you are still working on this or not, but we definitely need tests for the new behavior as well.  There are tests around fetch failures in DagSchedulerSuite already, so you can probably add something which follows those examples.

btw I have no idea what is going on in those test failures ... do the tests pass when you run them locally?

No Imran - they don't. However I see the same on he master branch. I don't think they have anything to do with my changes.
Sent with Good (www.good.com)
-----Original Message-----
From: Imran Rashid [notifications<EMAIL_ADDRESS>Sent: Friday, April 24, 2015 09:55 PM Eastern Standard Time
To: apache/spark
Cc: Ganelin, Ilya
Subject: Re: [spark] [SPARK-5945] Spark should not retry a stage infinitely on a FetchFailedException (#5636)
btw I have no idea what is going on in those test failures ... do the tests pass when you run them locally?
—
Reply to this email directly or view it on GitHubhttps://github.com/apache/spark/pull/5636#issuecomment-96120951.

The information contained in this e-mail is confidential and/or proprietary to Capital One and/or its affiliates. The information transmitted herewith is intended only for use by the individual or entity to which it is addressed.  If the reader of this message is not the intended recipient, you are hereby notified that any review, retransmission, dissemination, distribution, copying or other use of, or taking of any action in reliance upon this information is strictly prohibited. If you have received this communication in error, please contact the sender and delete the material from your computer.

Roger - I'll add tests to the suite.
Sent with Good (www.good.com)
-----Original Message-----
From: Imran Rashid [notifications<EMAIL_ADDRESS>Sent: Friday, April 24, 2015 09:54 PM Eastern Standard Time
To: apache/spark
Cc: Ganelin, Ilya
Subject: Re: [spark] [SPARK-5945] Spark should not retry a stage infinitely on a FetchFailedException (#5636)
Hi @ilganelihttps://github.com/ilganeli thanks for updating this. Not sure if you are still working on this or not, but we definitely need tests for the new behavior as well. There are tests around fetch failures in DagSchedulerSuite already, so you can probably add something which follows those examples.
—
Reply to this email directly or view it on GitHubhttps://github.com/apache/spark/pull/5636#issuecomment-96120931.

The information contained in this e-mail is confidential and/or proprietary to Capital One and/or its affiliates. The information transmitted herewith is intended only for use by the individual or entity to which it is addressed.  If the reader of this message is not the intended recipient, you are hereby notified that any review, retransmission, dissemination, distribution, copying or other use of, or taking of any action in reliance upon this information is strictly prohibited. If you have received this communication in error, please contact the sender and delete the material from your computer.

retest this please

Test build #30990 has finished for   PR 5636 at commit 0335b96.

This patch fails Spark unit tests.

This patch merges cleanly.

This patch adds no public classes.

This patch adds the following new dependencies:

tachyon-0.6.4.jar
tachyon-client-0.6.4.jar

This patch removes the following dependencies:

tachyon-0.5.0.jar
tachyon-client-0.5.0.jar

Test build #31083 has started for   PR 5636 at commit 914b2cb.

Test build #31083 has finished for   PR 5636 at commit 914b2cb.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

retest this please

Test build #31107 has started for   PR 5636 at commit 914b2cb.

Test build #31107 has finished for   PR 5636 at commit 914b2cb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

@squito I've added a unit test to confirm this code is working as expected (and fixed a bug that was there). Please let me know if this is what you had in mind or if this needs anything else. Cheers!

Thanks for the update @ilganeli !  my comments are mostly minor.  The only thing which is bugging me is that the tests don't really show how the stage failure gets pushed up to the user code.  Eg., do they get a SparkException with a good message -- or does the DAGScheduler end up in some weird state where it stops running any additional jobs?  I think it should work, but the DAGScheduler code is hairy enough that I'd really prefer a test.  But I can't come up with a good way to write a unit test (or test manually for that matter).  Maybe something like this test in ShuffleSuite?
https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/ShuffleSuite.scala#L264
The problem is you don't have a good way to delete the shuffle files between stage attempts ... but maybe we could swap-in a different diskBlockManager that always fails to find the files or something.  I'll think about it a little more.

Imran - I believe they would get the Exception since the call to abortStage throws a SparkException. I believe I can check for that to confirm the end to end behavior.
Sent with Good (www.good.com)
-----Original Message-----
From: Imran Rashid [notifications<EMAIL_ADDRESS>Sent: Wednesday, April 29, 2015 02:35 AM Eastern Standard Time
To: apache/spark
Cc: Ganelin, Ilya
Subject: Re: [spark] [SPARK-5945] Spark should not retry a stage infinitely on a FetchFailedException (#5636)
Thanks for the update @ilganelihttps://github.com/ilganeli ! my comments are mostly minor. The only thing which is bugging me is that the tests don't really show how the stage failure gets pushed up to the user code. Eg., do they get a SparkException with a good message -- or does the DAGScheduler end up in some weird state where it stops running any additional jobs? I think it should work, but the DAGScheduler code is hairy enough that I'd really prefer a test. But I can't come up with a good way to write a unit test (or test manually for that matter). Maybe something like this test in ShuffleSuite?
https://github.com/apache/spark/blob/master/core/src/test/scala/org/apache/spark/ShuffleSuite.scala#L264
The problem is you don't have a good way to delete the shuffle files between stage attempts ... but maybe we could swap-in a different diskBlockManager that always fails to find the files or something. I'll think about it a little more.
—
Reply to this email directly or view it on GitHubhttps://github.com/apache/spark/pull/5636#issuecomment-97323086.

The information contained in this e-mail is confidential and/or proprietary to Capital One and/or its affiliates. The information transmitted herewith is intended only for use by the individual or entity to which it is addressed.  If the reader of this message is not the intended recipient, you are hereby notified that any review, retransmission, dissemination, distribution, copying or other use of, or taking of any action in reliance upon this information is strictly prohibited. If you have received this communication in error, please contact the sender and delete the material from your computer.

great, thanks Ilya.   btw, the test you have is good, and is exactly what I had initially requested -- sorry I am adding more stuff as we go.

Imran - I think a easy check for this is to use the Spark listener as I've added to the test. Because failJobAndIndependentStages posts to the listenerBus when a stage fails, we just need to confirm that the listenerBus sees this message since it's then propagated up to the user via the Log listeners. Please see updates to the TestSuite

Merged build triggered.

Merged build started.

Test build #31333 has started for   PR 5636 at commit 77555b9.

Test build #31333 has finished for   PR 5636 at commit 77555b9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31333/
Test FAILed.

Retest this please

Merged build triggered.

Merged build started.

Test build #31345 has started for   PR 5636 at commit 77555b9.

Test build #31345 has finished for   PR 5636 at commit 77555b9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31345/
Test FAILed.

Sigh. Streaming tests. Retest this please

Merged build triggered.

Merged build started.

Test build #31355 has started for   PR 5636 at commit 77555b9.

Test build #31355 has finished for   PR 5636 at commit 77555b9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31355/
Test PASSed.

this looks good, thanks!  Mostly all cosmetic things, just one question about a couple lines in the test.

Merged build triggered.

Merged build started.

Test build #31459 has started for   PR 5636 at commit 1243b65.

Test build #31459 has finished for   PR 5636 at commit 1243b65.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31459/
Test FAILed.

@kayousterhout -- I think there is just really minor stuff left, do you want to a take quick look?  I will check it out and try it on some failure generating cases I have.  Assuming that goes OK I'll be ready to check this in tomororw

Merged build triggered.

Merged build started.

Test build #31462 has started for   PR 5636 at commit e26ae6e.

Test build #31462 has finished for   PR 5636 at commit e26ae6e.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31462/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #31463 has started for   PR 5636 at commit 75952ea.

Test build #31463 has finished for   PR 5636 at commit 75952ea.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31463/
Test PASSed.

@ilganeli Can you update the PR description, now that these questions have been resolved, to describe what this does (since the PR description is what gets included in the commit message)?

@squito based on our other conversation in the comments, I wonder if it would be better to track the number of failures in ShuffleMapStage (so this would mean we'd track the failures of the map stage rather than the stage that reads the shuffle), and then explicitly call it "numFetchFailures" or similar? I just think that might be more clear to someone reading the code, since these failures only happen for fetches.

hmm, it seems a little clearer to me in the shuffle read stage, since that is the one that is "actively" failing.  We could also rename the methods & variables added in this pr to make it more clear that its just tracking fetch failures.  Though honestly, I don't have very strong feelings, so I certainly wouldn't mind it being changed if you'd feel better about it that way.

All - I've updated the tests and code to (I believe) reflect the discussion here. Please let me know if I correctly understood the intent.
Thanks!

Merged build triggered.

Merged build started.

Test build #31783 has started for   PR 5636 at commit bc88aa1.

Test build #31783 has finished for   PR 5636 at commit bc88aa1.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31783/
Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #31785 has started for   PR 5636 at commit bc88aa1.

Test build #31785 has finished for   PR 5636 at commit bc88aa1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31785/
Test PASSed.

Merged build finished. Test PASSed.

Hi Ilya,  unfortunately I think this is not doing quite what we want.  The tests aren't quite testing the right thing -- its confusing b/c in the test environment the TaskScheduler is mocked and we are manually doing some of the stage submission.
Sorry this turned out to be quite complicated in the end -- I think since we've missed 1.4, we should probably wait till we figure out the concurrent stage attempt issue, it really makes it a lot harder to fix.  I know its frustrating but I think for now we should just sit on this.  (I hope to have a PR for dealing w/ the concurrent attempts later this week, but I expect that to also need a lot of scrutiny before it can be merged.)
I'll drop a few notes inline as well on the details of what needs to be changed, but even with those changes I think the concurrent attempt thing will still be a blocker.

Merged build triggered.

Merged build started.

Test build #36138 has started for   PR 5636 at commit 560a381.

Test build #36138 has finished for   PR 5636 at commit 560a381.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Hi @ilganeli I think https://github.com/apache/spark/pull/6750 is getting close to being merged -- that will give you what you need to pick this back up (specifically, each task knows its stage attempt).  Just wanted to give you a heads up if you want to try to bring this one up to date and address the other issues.

Awesome, thanks Imran. I'll jump on this once things are merged in!
Thank you,
Ilya Ganelin
-----Original Message-----
From: Imran Rashid [notifications<EMAIL_ADDRESS>Sent: Monday, July 13, 2015 05:57 PM Eastern Standard Time
To: apache/spark
Cc: Ganelin, Ilya
Subject: Re: [spark] [SPARK-5945] Spark should not retry a stage infinitely on a FetchFailedException (#5636)
Hi @ilganelihttps://github.com/ilganeli I think #6750https://github.com/apache/spark/pull/6750 is getting close to being merged -- that will give you what you need to pick this back up (specifically, each task knows its stage attempt). Just wanted to give you a heads up if you want to try to bring this one up to date and address the other issues.
—
Reply to this email directly or view it on GitHubhttps://github.com/apache/spark/pull/5636#issuecomment-121074092.

The information contained in this e-mail is confidential and/or proprietary to Capital One and/or its affiliates and may only be used solely in performance of work or services for Capital One. The information transmitted herewith is intended only for use by the individual or entity to which it is addressed. If the reader of this message is not the intended recipient, you are hereby notified that any review, retransmission, dissemination, distribution, copying or other use of, or taking of any action in reliance upon this information is strictly prohibited. If you have received this communication in error, please contact the sender and delete the material from your computer.

@ilganeli #6750 has been merged, so this PR can now be updated!

Merged build triggered.

Merged build started.

Test build #38270 has started for   PR 5636 at commit 76f226a.

Test build #38270 has finished for   PR 5636 at commit 76f226a.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38271 has started for   PR 5636 at commit fe647d0.

Test build #38271 has finished for   PR 5636 at commit fe647d0.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38277 has started for   PR 5636 at commit ddfe46c.

Test build #38277 has finished for   PR 5636 at commit ddfe46c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Merged build finished. Test FAILed.

@squito Thanks for the complete example, this really helped clarify what's going on. I've updated the three tests cases I had based on this code and added a bunch of comments.

Merged build triggered.

Merged build started.

Test build #38585 has started for   PR 5636 at commit 34d69fa.

Test build #38585 has finished for   PR 5636 at commit 34d69fa.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

I think there are two more tests we need.  I think maybe one of these was the original intent of that test case which I thought shouldn't be added (or maybe that test should get added and I'm forgetting something)

If one stage attempt has a bunch failures from one attempt, we should proceed with another attempt for that stage.  Eg., add a test that is like your existing ones but:

stage 1 has 8 tasks val reduceRdd = new MyRDD(sc, 8, List(shuffleDep)) (I think, you should confirm this by looking at the task set and seeing how many tasks it has)
make attempt 0 of stage 1 fail all 8 tasks with fetch failures
have attempt 1 of stage 0 & stage 1 complete with no failures
everything should be happy

If a stage fails a few times with fetch failures, then succeeds, then fails again a few times, it should be allowed to go over the 4 failure limit in total.  This is a little more complicated, you will need to add a test with 3 stages.  You can follow this example.  Then you would

complete stage 0 successfully
go through some iterations of failing stage 1, retrying stage 0 & stage 1, so get 3 failures total of stage 1.
on attempt 4 of stage 1, have it succeed
then try stage 2, but it should have one fetch failure
that will result in a 5th attempt for stage 1.  Go through another round of failures for stage 1, retrying stage 0 & 1, so that you get another 3 rounds of fetch failures on stage 1.
Finally complete the next attempt on stage 1 successfully.  (I guess thats 8 attempts total.)
Then complete the next attempt of stage 2 successffully.  Then check the job has completed successfully.

Thanks for picking this up again Ilya.  Sorry its a lot work on writing these tests, but this is really appreciated.

Merged build triggered.

Merged build started.

Test build #38717 has started for   PR 5636 at commit e101ed7.

@squito I submitted updates based on our discussion, the one open question is whether I'm verifying success of stages correctly in the second test or if there's a better way. The other tests are coming shortly.

Merged build triggered.

Merged build started.

Test build #38724 has started for   PR 5636 at commit daad2e4.

Merged build triggered.

Merged build started.

Test build #38737 has started for   PR 5636 at commit f23c31b.

Test build #38717 has finished for   PR 5636 at commit e101ed7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #38724 has finished for   PR 5636 at commit daad2e4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #38737 has finished for   PR 5636 at commit f23c31b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38783 has started for   PR 5636 at commit 9978575.

Test build #38783 has finished for   PR 5636 at commit 9978575.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38856 has started for   PR 5636 at commit b66d74e.

Test build #38856 has finished for   PR 5636 at commit b66d74e.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38857 has started for   PR 5636 at commit 2e058ba.

Merged build triggered.

Merged build started.

Test build #38860 has started for   PR 5636 at commit f79011b.

Test build #38860 has finished for   PR 5636 at commit f79011b.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

@kayousterhout Do you want to take another look at this?  I have a handful of small comments, but I think this is basically ready

Merged build triggered.

Merged build started.

Test build #38857 has finished for   PR 5636 at commit 2e058ba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #38872 has started for   PR 5636 at commit 62532fa.

Test build #38872 has finished for   PR 5636 at commit 62532fa.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #38882 has started for   PR 5636 at commit 1c1cb72.

Merged build triggered.

Merged build started.

Test build #38888 has started for   PR 5636 at commit 17e85de.

Test build #38882 has finished for   PR 5636 at commit 1c1cb72.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #38888 has finished for   PR 5636 at commit 17e85de.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #39757 has started for   PR 5636 at commit cf94850.

Test build #39757 has finished for   PR 5636 at commit cf94850.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39761 has started for   PR 5636 at commit 7c6f60f.

Test build #39761 has finished for   PR 5636 at commit 7c6f60f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

thanks @ilganeli !  All of my comments are super minor.  I think the cleanup on the tests makes things easier, we could probably even clean up some of the other tests similarly (but we can do that separately).
ping @kayousterhout @markhamstra -- this is all but l g t m

One other minor bit of housekeeping @ilganeli -- can you update the PR description, since that will go in the commit msg?
I should probably also update the jira ... right now its a bit rambly with a few different thoughts, I shoudl make it more focused.

Merged build triggered.

Merged build started.

Test build #39920 has started for   PR 5636 at commit 13af970.

Test build #39920 has finished for   PR 5636 at commit 13af970.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39923 has started for   PR 5636 at commit 09929da.

Test build #39923 has finished for   PR 5636 at commit 09929da.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #39929 has started for   PR 5636 at commit eb15503.

Test build #39929 has finished for   PR 5636 at commit eb15503.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Jenkins, retest this please

Merged build triggered.

Merged build started.

Test build #240 has started for   PR 5636 at commit eb15503.

Merged build triggered.

Merged build started.

Test build #39967 has started for   PR 5636 at commit eb15503.

Test build #240 has finished for   PR 5636 at commit eb15503.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test build #39967 has finished for   PR 5636 at commit eb15503.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

lgtm!  (last couple nits could even be fixed by the commiter)

Merged build triggered.

Merged build started.

Test build #40036 has started for   PR 5636 at commit 01d6841.

Test build #40036 has finished for   PR 5636 at commit 01d6841.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #40075 has started for   PR 5636 at commit 01d6841.

Test build #40075 has finished for   PR 5636 at commit 01d6841.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

(this is a test comment to test a Jenkins + Spark-PRS integration affecting long comment threads)

Merged build triggered.

Merged build started.

Test build #41265 has started for   PR 5636 at commit 1dd4840.

Test build #41265 has finished for   PR 5636 at commit 1dd4840.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41265/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #41269 has started for   PR 5636 at commit 4da18a1.

Test build #41269 has finished for   PR 5636 at commit 4da18a1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41269/
Test FAILed.

retest this please

@kayousterhout @markhamstra @pwendell @mateiz would really appreciate it if you would take a look at this one.  Its way over the 1-week maintainer waiting period, and I do feel pretty good about (long ago had an extensive discussion w/ Kay on the right unit tests, which we've got covered now).  Still I'd like to give you another chance to take a look before merging (into master, not 1.5), given the risk of scheduler changes.

@kayousterhout @mateiz @markhamstra @pwendell forgot about this last week, but I will merge tomorrow unless anybody has any objections, and I'll fix the minor nits while I'm at it.

I'll have a close look at this later today, but at a quick glance the high level approach seems reasonable.


add Swift 5.2 to the readme

Motivation:
Swift 5.2 is already available as developer snapshots and Xcode 11.4
beta got released which also includes Swift 5.2.
Modifications:

add 5.2 support to the readme
showcase SwiftPM's package syntax for 5.2

Result:
the future is here.

Where we're going we don't need roads.


Update navbar.md

Updated class from "fixed" to "sticky" for Sticky navbar. Currently, the content on the page below will be hidden behind the navbar. Changing it to sticky fixes the layout.

Closes #
📑 Description

Status

[x] Not Completed
[ ] Completed

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] I have checked the page with https://validator.unl.edu/
[ ] All the tests have passed
[ ] My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

sticky doesn't extend the bottom border, and it is not desirable for this situation.
Thank you for your contribution.


Adding missing -D option to Readme

I found a problem with the -D option and noticed that it was missing from the Readme page.

Hi @csutherl,
Merged! thanks!


Security Center OR Compliance Center?

The article mentions the Security & Compliance Center as a single admin center.
We have 2 admin centers: the Security Center and the Compliance Center. Which of the 2 does the article refer to? Please amend article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5bb1b82-5bde-ce65-ca17-9e982b030a5c
Version Independent ID: 704d9708-5308-4b5d-0ffa-d6b31fa7d0f3
Content: Auto-forwarded messages insight - Office 365
Content Source: microsoft-365/security/office-365-security/mfi-auto-forwarded-messages-report.md
Service: o365-seccomp
GitHub Login: @chrisda
Microsoft Alias: chrisda

@dennish78, actually, for the purposes of this discussion, there are three admin centers from oldest to newest:
Security & Compliance Center https://protection.office.com
Compliance Center https://compliance.microsoft.com
Security Center https://security.microsoft.com
All three are equally alive and well. New features are still being added to the Security & Compliance Center.
At some point, as there becomes more parity between features in the SCC and the SC, we'll likely convert all of the SCC topic content (procedures, UI, etc.) to the SC.

Hi Chris,
Good to know that, thanks.
It's weird then that the SCC is no longer a link in the list of Admin
Centers. We have a choice of SC and CC. Guess I'll add the SCC to my
bookmarks and patiently await its deprecation.
Perhaps you could add a link to this (Classic? Legacy?) Center in the doc
to help other admins who also no longer have a direct link from the Admin
Center.

@dennish78 Thank you for the feedback. I have added the LInk to security and compliance center to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/2739
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @dennish78 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Prerequisites

[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.

Criteria

[X] Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)
[X] English interface (or at least English documentation)
[X] Latest stable version
[X] Full version (i.e. not a trial version)
[X] Fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)

Name
dolphin
Description
A file manager focusing on usability. KDE's file manager that lets you navigate and browse the contents of your hard drives, USB sticks, SD cards, and more.
Homepage
https://github.com/KDE/dolphin
Download Link(s)
https://binary-factory.kde.org/job/Dolphin_Release_win64/
Some Indication of Popularity/Repute
well-known linux file manager

Done, now wait.

thanks


WPP-61 Adds pre-interceptor for user attributes in header values

You can configure your portlet to use user-attributes and pass them along in headers of your own naming.
Also configured javadoc plugin to work with those still using java 7 (I know, not using for long).

Great stuff! Thank you for maintaining the new docs

https://issues.jasig.org/browse/WPP-61


The BottomNavigationBar and FloatingActionButton are jacked up by the keyboard

          "_When I was using flutter 3.0 and above, I found that when the input box is focused, bottomNavigationBar and floatingActionButton will be pushed up by the soft keyboard, even if resizeToAvoidBottomInset: false is set, it is invalid. Such a checkup is not very friendly. Is there any solution please?_" - Google Translate

Hi @shijia2118
I can not reproduce the issue with below sample code. When setting resizeToAvoidBottomInset: false, the bottomNavigationBar and floatingActionButton are not pushed up by the keyboard.

Sample code
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  static const String _title = 'Flutter Code Sample';

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      title: _title,
      home: MyStatefulWidget(),
    );
  }
}

class MyStatefulWidget extends StatefulWidget {
  const MyStatefulWidget({super.key});

  @override
  State<MyStatefulWidget> createState() => _MyStatefulWidgetState();
}

class _MyStatefulWidgetState extends State<MyStatefulWidget> {
  int _selectedIndex = 0;
  static const TextStyle optionStyle =
  TextStyle(fontSize: 30, fontWeight: FontWeight.bold);
  static List<Widget> _widgetOptions = <Widget>[
    Column(
      children: [
        Text(
          'Index 0: Home',
          style: optionStyle,
        ),
        TextField(),
      ],
    ),
    Text(
      'Index 1: Business',
      style: optionStyle,
    ),
    Text(
      'Index 2: School',
      style: optionStyle,
    ),
  ];

  void _onItemTapped(int index) {
    setState(() {
      _selectedIndex = index;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      resizeToAvoidBottomInset: false,
      appBar: AppBar(
        title: const Text('BottomNavigationBar Sample'),
      ),
      body: Center(
        child: _widgetOptions.elementAt(_selectedIndex),
      ),
      bottomNavigationBar: BottomNavigationBar(
        items: const <BottomNavigationBarItem>[
          BottomNavigationBarItem(
            icon: Icon(Icons.home),
            label: 'Home',
          ),
          BottomNavigationBarItem(
            icon: Icon(Icons.business),
            label: 'Business',
          ),
          BottomNavigationBarItem(
            icon: Icon(Icons.school),
            label: 'School',
          ),
        ],
        currentIndex: _selectedIndex,
        selectedItemColor: Colors.amber[800],
        onTap: _onItemTapped,
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () {

        },
        child: const Icon(Icons.add),
      ),
    );
  }
}

Demo
https://user-images.githubusercontent.com/104349824/189588006-3d8ffe19-735a-4a81-9704-c5cb87421dd6.mp4

Please provide a completed and minimal reproducible code sample so that we may verify this. Also, please provide the output of flutter doctor -v as well.
Thank you!
Originally posted by @huycozy in https://github.com/flutter/flutter/issues/111334#issuecomment-1243280812

I also encountered the problem that BottomNavigationBar and FloatingActionButton are pushed up by the keyboard, but it is caused by nesting an extra layer of Scaffold. According to the provided example demo, adding an extra layer of Scaffold will also appear to be pushed up The case where the keyboard is raised

I also encountered the problem that BottomNavigationBar and FloatingActionButton are pushed up by the keyboard, but it is caused by nesting an extra layer of Scaffold. According to the provided example demo, adding an extra layer of Scaffold will also appear to be pushed up The case where the keyboard is raised

@override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Scaffold(
        resizeToAvoidBottomInset: false,
        appBar: AppBar(
          title: const Text('BottomNavigationBar Sample'),
        ),
        body: Center(
          child: _widgetOptions.elementAt(_selectedIndex),
        ),
        bottomNavigationBar: BottomNavigationBar(
          items: const <BottomNavigationBarItem>[
            BottomNavigationBarItem(
              icon: Icon(Icons.home),
              label: 'Home',
            ),
            BottomNavigationBarItem(
              icon: Icon(Icons.business),
              label: 'Business',
            ),
            BottomNavigationBarItem(
              icon: Icon(Icons.school),
              label: 'School',
            ),
          ],
          currentIndex: _selectedIndex,
          selectedItemColor: Colors.amber[800],
          onTap: _onItemTapped,
        ),
        floatingActionButton: FloatingActionButton(
          onPressed: () {

          },
          child: const Icon(Icons.add),
        ),
      ),
    );
  }

My solution: Reducing nested Scaffold solved my problem

Closing the issue as solved by yourself. When you have an issue in the future, please try to provide all or some of the information indicated in the template so that we can address this issue properly.

Issue Template
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
- https://flutter.dev/
- https://api.flutter.dev/
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent

If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports

Steps to Reproduce

Please tell us exactly how to reproduce the problem you are running into.

Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.

If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.

1. ...
2. ...
3. ...

Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?

Target Platform:
Target OS version/browser:
Devices:

Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.

Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.

Finally, paste the output of running `flutter doctor -v` here.


ref: replace deprecated classes

@adil192 thanks for the contribution! I also couldn't find a way to make it look cleaner, so ended up with a large Map of characters -> physical/logical keys. Seems to work fine. I've moved some of the changes here (+ renamings), as well as fixed builds for Flutter 3.22.0 in https://github.com/kekland/simulator/commit/fcddc892ce78652dcab4a5a9c572634c5239ef3d


Allow to disable default resolver

By default eslint merges the config, making it impossible to use a custom resolver with option without the default resolver node being added.
Try 1
settings: {
  'import/resolver': {
    [path.resolve(__dirname, './resolver')]: { /* some options */ },
  },
},

Then the following resolvers are used:
{
  '/home/.../eslint-config/resolver': {},
  node: { extensions: [ '.js', '.jsx', '.json' ] }
}

Try 2:
settings: {
  'import/resolver': {
    [path.resolve(__dirname, './resolver')]: { /* some options */ },
    node: false,
  },
},

Then the following resolvers are used:
{
  '/home/.../eslint-config/resolver': {},
  node: false,
}

And the node resolver is still used, same with null, undefined or other
Try 3:
I can only disable resolver node by doing this, but I can't pass any options:
settings: {
  'import/resolver': path.resolve(__dirname, './resolver'),
},

I propose as a solution not to use a resolver if its configuration is equal to false.

I would definitely expect false to work here.


Got the following error when including the package

Compiler message:
../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:218:12: Error: Expected an identifier, but got '('.   setState(() {            ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:218:15: Error: Expected ')' before this.   setState(() {               ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:222:3: Error: A method declaration needs an explicit list of parameters. Try adding a parameter list to the method declaration.   _yController.value = 1.0;   ^^^^^^^^^^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:222:22: Error: Only factory constructor can specify '=' redirection. Try making this a factory constructor, or remove the redirection.   _yController.value = 1.0;                      ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:222:24: Error: Expected an identifier, but got '1.0'.   _yController.value = 1.0;                        ^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:222:24: Error: Expected ';' after this.   _yController.value = 1.0;                        ^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:222:3: Error: The name of a constructor must match the name of the enclosing class.   _yController.value = 1.0;   ^^^^^^^^^^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:222:24: Error: Expected a class member, but got '1.0'.   _yController.value = 1.0;                        ^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:222:27: Error: Expected a class member, but got ';'.   _yController.value = 1.0;                           ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:224:27: Error: Expected ')' before this.   _indexToPosition(index) / MediaQuery                           ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:223:3: Error: The name of a constructor must match the name of the enclosing class.   _xController.animateTo(   ^^^^^^^^^^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:230:24: Error: Non-optional parameters can't have a default value. Try removing the default value or making the parameter optional.   Duration(milliseconds: 500) * widget.animationFactor,                        ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:230:31: Error: Expected ')' before this.   Duration(milliseconds: 500) * widget.animationFactor,                               ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:229:3: Error: The name of a constructor must match the name of the enclosing class.   Future.delayed(   ^^^^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:236:26: Error: Expected an identifier, but got '0.0'.   _yController.animateTo(0.0,                          ^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:237:11: Error: Non-optional parameters can't have a default value. Try removing the default value or making the parameter optional.   duration: Duration(milliseconds: 300) * widget.animationFactor);           ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:236:3: Error: The name of a constructor must match the name of the enclosing class.   _yController.animateTo(0.0,   ^^^^^^^^^^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:236:3: Error: '_FluidNavBarState.animateTo' is already declared in this scope.   _yController.animateTo(0.0,   ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:223:3: Context: Previous declaration of '_FluidNavBarState.animateTo'.   _xController.animateTo(   ^^^^^^^^^^^^^^^^^^^^^^^^... ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:239:3: Error: Expected a class member, but got 'if'.   if (widget.onChange != null) {   ^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:239:6: Error: Expected an identifier, but got '('.   if (widget.onChange != null) {      ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:239:23: Error: Expected an identifier, but got '!='.   if (widget.onChange != null) {                       ^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:239:26: Error: Expected ')' before this.   if (widget.onChange != null) {                          ^^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:239:7: Error: Type 'widget.onChange' not found.   if (widget.onChange != null) {       ^^^^^^^^^^^^^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:218:3: Error: The method '_FluidNavBarState.setState' has fewer positional arguments than those of overridden method 'State.setState'.   setState(() {   ^ ../../flutter/packages/flutter/lib/src/widgets/framework.dart:1196:8: Context: This is the overridden method ('setState').   void setState(VoidCallback fn) {        ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:74:7: Error: The implementation of 'setState' in the non-abstract class '_FluidNavBarState' does not conform to its interface. class _FluidNavBarState extends State<FluidNavBar>       ^^^^^^^^^^^^^^^^^ ../../flutter/packages/flutter/lib/src/widgets/framework.dart:1196:8: Context: The method 'State.setState' has more required arguments than those of overridden method '_FluidNavBarState.setState'.   void setState(VoidCallback fn) {        ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:218:3: Context: This is the overridden method ('setState').   setState(() {   ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:69:26: Error: Method not found: '_FluidNavBarState'.   State createState() => _FluidNavBarState();                          ^^^^^^^^^^^^^^^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:91:15: Error: Too many positional arguments: 0 allowed, but 1 found. Try removing the extra positional arguments.       setState(() {});               ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:222:22: Error: Expected a function body or '=>'. Try adding {}.   _yController.value = 1.0;                      ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:222:24: Error: Constructors can't have a return type. Try removing the return type.   _yController.value = 1.0;                        ^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:237:13: Error: Constant expression expected. Try inserting 'const'.   duration: Duration(milliseconds: 300) * widget.animationFactor);             ^^^^^^^^ ../../flutter/.pub-cache/hosted/pub.dartlang.org/fluid_bottom_nav_bar-1.0.1/lib/src/fluid_nav_bar.dart:237:43: Error: Getter not found: 'widget'.   duration: Duration(milliseconds: 300) * widget.animationFactor);                                           ^^^^^^

The stack trace is unreadable...
I don't know what happens for you, but clearly this is not an issue of this library. Many people use this version without any issue.

Did you solve your issue? If yes can you provide more relevant informations how you solved it to help others in cas they encounter the same issue?

Did you solve your issue? If yes can you provide more relevant informations how you solved it to help others in cas they encounter the same issue?

Unfortunately, I couldn't solve the issue.

Did you try flutter clean, upgrade to the latest stable version of SDK, flutter and this library?  It seems to be a compilation error on the library code itself

Yes I did that...it didn't seem to work at that point but I'll do it again just in case.

Since there is no additional information, I close this problem. Do not hesitate to reopen it if necessary.


Update Dockerfile to Python 3.12

It's now in sync with template https://github.com/ghga-de/microservice-repository-template/blob/main/Dockerfile

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.108%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
149

Relevant Lines:
186

💛  - Coveralls


"go build" with cache is still slow with Docker for Mac using CND

This might be due to Docker for Mac filesystem performance issues.

Closed by #8


Make dropship fab printing take 3 seconds

About the PR

Title.
Why / Balance

parity!
Technical details

Media

Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: Dropship fabricator printing is much faster

Is this a recent change? From testing locally in 13 it takes 10 seconds, not 3

Very recent yup! https://github.com/cmss13-devs/cmss13/pull/7151 got merged today-ish


Fix It Plus in Google Chrome Issue

Transcript-a-thon uncovered a potential browser issue with the transcript-editor at Google Chrome version 63.0.3239.84

Fine in current Chrome versions


Add dfdx to crates

Do I need to add anything else like links to github or crates.io?

@coreylowman This just failed CI:
unknown variant `reinforcement-learning`, expected one of `scientific-computing`, `gpu-computing`, `neural-networks`, `metaheuristics`, `data-preprocessing`, `data-structures`, `clustering`, `decision-trees`, `linear-classifiers`, `reinforcement`, `nlp` at line 114 column 31

Once that's corrected, it can be merged.

Thanks @anowell, should be fixed now!

Thanks. Merged.


Do not remote leading zeros in trace ID hex string

Resolves #1578
Open question: this change may prevent ES backend from reading the old traces if their IDs had leading zeroes, because previously the zeroes were not added to string representation, and now they are. Roughly one in 16 traces will be affected.

@pavolloffay please review, and any thoughts on the ES question?  One option is to add a backwards compatibility mode by doing a fallback search with unpadded trace ID strings if full-length strings are not found. It would be an option people can configure.

cc @jpkrohling (I think Pavol is on PTO)

I will have a look at this one, hod for the moment

Open question: this change may prevent ES backend from reading the old traces if their IDs had leading zeroes, because previously the zeroes were not added to string representation, and now they are. Roughly one in 16 traces will be affected.

Indeed, spans previously stored with with id like 1 are not searchable after this change. We definitely need a way to be backward compatible.

Something like this should work https://github.com/yurishkuro/jaeger/pull/1/files it needs some tests though.
@yurishkuro could you please summarize why adding leading zeros is necessary?

@pavolloffay I added motivation to description.

thanks @yurishkuro. It makes sense. I have updated my PR to your branch.

We should list this in breaking changes as it might impact integrations


proposal: include metadata about modules in binaries

There are many scanners for finding known vulnerabilities (CVEs).  Typical scanner could be based on e.g. RPM index.
CVEs are reported also about go modules (see example here) but due to static linking it is difficult to recognize if a given binary has known vulnerability.
Go compiler could augment the binaries with metadata about included modules and their versions.
Implementers of vulnerability scanners could leverage this metadata for introducing support for go binary scanning.

Dup of https://github.com/golang/go/issues/26404
https://go-review.googlesource.com/c/go/+/144220 has just been merged too


Fix DBus Tray Icon when the org.kde.StatusNotifierWatcher service is unavailable

What does the pull request do?
What is the current behavior?
_serviceConnected was set to true when any NameOwnerChanged signal occured, which lead to an exception because the service doesn't actually exists.
What is the updated/expected behavior with this PR?
No exception is thrown when the service is unavailable.
How was the solution implemented (if it's not obvious)?
Checklist

[ ] Added unit tests (if possible)?
[ ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues

You can test this PR using the following package version. 11.0.999-cibuild0035972-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0035984-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Application Hangs after Traceback errors

🐛 Summary
Traceback error comes up and app seems to freeze while trying to scan files during YARA section.
To reproduce
Log into Win2012R2 server as domain admin, go to chirp directory and kick off app via Powershell (admin mode)  /.chirp.exe
Left the process running overnight.  Following day found app window with errors:
Traceback errors (see attached).
CHIRP process still in Task Manager, but stuck at 0% CPU utilization.
This occurs on version 1.03 and 1.04 on Win2012R2
Ran version 1.05 on Win2012R2 and still getting Traceback error.
Expected behavior
Tool is expected to run to completion.
Any helpful log output or screenshots

Version 1.05
PS C:\kworking\chirp> cd..
PS C:\kworking> cd chirp1.05
PS C:\kworking\chirp1.05> ./chirp.exe
16:20:23 EVENTS   Reading Windows Powershell event logs.                                                     scan.py:69
16:20:24 EVENTS   Reading KernelMode event logs.                                                             scan.py:69
EVENTS   Reading Application event logs.                                                            scan.py:69
16:20:25 REGISTRY Reading HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\sibot                 scan.py:65
REGISTRY Key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\sibot does not exist. registry.py:93
REGISTRY Reading HKEY_LOCAL_MACHINE\Software\Microsoft\CTF                                          scan.py:65
REGISTRY Reading HKLM\SOFTWARE\Wow6432Node\Microsoft\Windows NT\CurrentVersion\Image File Execution scan.py:65
Options
REGISTRY Found 0 hit(s) for Sibot - Registry indicator.                                             scan.py:47
REGISTRY Found 0 hit(s) for Teardrop - Registry Activity indicator.                                 scan.py:47
REGISTRY Found 0 hit(s) for IFEO Persistence indicator.                                             scan.py:47
YARA     Enumerating the entire filesystem due to ['simpleseesharp : Webshell Unclassified',        run.py:141
'reGeorgTunnel : Webshell Commodity', 'sportsball : Webshell', 'Detection for the use of
procdump to dump LSASS process memory.', 'CISA Solar Fire', 'CISA Teardrop', 'CrowdStrike
Rempack', 'CrowdStrike Sunspot', 'FireEye Cosmic Gale', 'FireEye Sunburst']... this is
going to take a while.
16:20:49 EVENTS   Reading Security event logs.                                                               scan.py:69
16:29:26 YARA     Beginning processing.                                                                      run.py:100
Traceback (most recent call last):
File "C:\Users<account>\AppData\Local\Temp\ONEFIL~3\chirp.py", line 17, in
run.run()
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~3\chirp\run.py", line 20, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~3\chirp\run.py", line 30, in run_plugins
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~3\asyncio\base_events.py", line 616, in run_until_complete
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~3\chirp\run.py", line 44, in _run_coroutines
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~3\chirp\plugins\network\scan.py", line 44, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~3\chirp\plugins\network\network.py", line 37, in parse_dns
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 4544: invalid start byte
16:35:55 YARA     We're still working on scanning files. 50000 processed.                                     run.py:96
16:40:34 YARA     We're still working on scanning files. 100000 processed.                                    run.py:96
16:43:17 YARA     We're still working on scanning files. 150000 processed.                                    run.py:96
16:45:09 YARA     We're still working on scanning files. 200000 processed.                                    run.py:96
Add any screenshots of the problem here.

One of our Win2016 servers is also hanging on version 1.05.  See output below:
17:24:02 NETWORK  Read 507 records, found 0 IoC hits.                                                        scan.py:56
REGISTRY Reading HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\sibot                 scan.py:65
REGISTRY Key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\sibot does not exist. registry.py:93
REGISTRY Reading HKEY_LOCAL_MACHINE\Software\Microsoft\CTF                                          scan.py:65
REGISTRY Reading HKLM\SOFTWARE\Wow6432Node\Microsoft\Windows NT\CurrentVersion\Image File Execution scan.py:65
Options
REGISTRY Found 0 hit(s) for Sibot - Registry indicator.                                             scan.py:47
REGISTRY Found 0 hit(s) for Teardrop - Registry Activity indicator.                                 scan.py:47
REGISTRY Found 0 hit(s) for IFEO Persistence indicator.                                             scan.py:47
YARA     Enumerating the entire filesystem due to ['simpleseesharp : Webshell Unclassified',        run.py:141
'reGeorgTunnel : Webshell Commodity', 'sportsball : Webshell', 'Detection for the use of
procdump to dump LSASS process memory.', 'CISA Solar Fire', 'CISA Teardrop', 'CrowdStrike
Rempack', 'CrowdStrike Sunspot', 'FireEye Cosmic Gale', 'FireEye Sunburst']... this is
going to take a while.
17:24:03 EVENTS   Reading KernelMode event logs.                                                             scan.py:69
EVENTS   Reading Security event logs.                                                               scan.py:69
18:09:53 EVENTS   Reading Application event logs.                                                            scan.py:69
18:11:59 YARA     Beginning processing.                                                                      run.py:100
18:14:55 EVENTS   Reading Windows Powershell event logs.                                                     scan.py:69
18:16:20 EVENTS   Read 399688 logs, found 0 matches.                                                        scan.py:138
18:16:32 YARA     We're still working on scanning files. 50000 processed.                                     run.py:96
18:19:16 YARA     We're still working on scanning files. 100000 processed.                                    run.py:96
Traceback (most recent call last):
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~1\chirp.py", line 17, in
run.run()
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~1\chirp\run.py", line 20, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~1\chirp\run.py", line 30, in run_plugins
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~1\asyncio\base_events.py", line 616, in run_until_complete
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~1\chirp\run.py", line 44, in _run_coroutines
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~1\chirp\plugins\yara\run.py", line 162, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~1\aiomultiprocess\pool.py", line 145, in results_generator
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~1\aiomultiprocess\pool.py", line 308, in results
aiomultiprocess.types.ProxyException: Traceback (most recent call last):
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~1\aiomultiprocess\pool.py", line 110, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~1\chirp\plugins\yara\run.py", line 111, in _run
UnicodeEncodeError: 'utf-8' codec can't encode character '\ud8d0' in position 33: surrogates not allowed

Interesting, two separate Unicode errors. I will try to push a patch this evening! I will ping when I merge and build.

We have another Win2016 Server that is having a similar issue, with a different Unicode error.  The program, like the others, hangs after a while and never completes. Please see below:
16:42:58 EVENTS   Reading Security event logs.                                                               scan.py:69
16:42:58 EVENTS   Reading KernelMode event logs.                                                             scan.py:69
EVENTS   Reading Windows Powershell event logs.                                                     scan.py:69
16:42:58 EVENTS   Reading Application event logs.                                                            scan.py:69
16:42:58 REGISTRY Reading HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\sibot                 scan.py:65
REGISTRY Key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\sibot does not exist. registry.py:93
REGISTRY Reading HKEY_LOCAL_MACHINE\Software\Microsoft\CTF                                          scan.py:65
16:42:59 REGISTRY Reading HKLM\SOFTWARE\Wow6432Node\Microsoft\Windows NT\CurrentVersion\Image File Execution scan.py:65
Options
REGISTRY Found 0 hit(s) for Sibot - Registry indicator.                                             scan.py:47
REGISTRY Found 0 hit(s) for Teardrop - Registry Activity indicator.                                 scan.py:47
REGISTRY Found 0 hit(s) for IFEO Persistence indicator.                                             scan.py:47
YARA     Enumerating the entire filesystem due to ['simpleseesharp : Webshell Unclassified',        run.py:141
'reGeorgTunnel : Webshell Commodity', 'sportsball : Webshell', 'Detection for the use of
procdump to dump LSASS process memory.', 'CISA Solar Fire', 'CISA Teardrop', 'CrowdStrike
Rempack', 'CrowdStrike Sunspot', 'FireEye Cosmic Gale', 'FireEye Sunburst']... this is
going to take a while.
16:46:54 YARA     Beginning processing.                                                                      run.py:100
Traceback (most recent call last):
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp.py", line 17, in
run.run()
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\run.py", line 20, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\run.py", line 30, in run_plugins
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\asyncio\base_events.py", line 616, in run_until_complete
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\run.py", line 44, in _run_coroutines
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\plugins\network\scan.py", line 44, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\plugins\network\network.py", line 37, in parse_dns
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 5617: invalid start byte
16:51:21 YARA     We're still working on scanning files. 50000 processed.                                     run.py:96
16:57:46 YARA     We're still working on scanning files. 100000 processed.                                    run.py:96
17:01:50 YARA     We're still working on scanning files. 150000 processed.                                    run.py:96
17:05:25 YARA     We're still working on scanning files. 200000 processed.                                    run.py:96
17:08:16 YARA     We're still working on scanning files. 250000 processed.                                    run.py:96
17:11:27 YARA     We're still working on scanning files. 300000 processed.                                    run.py:96
17:14:19 YARA     We're still working on scanning files. 350000 processed.                                    run.py:96
17:18:14 YARA     We're still working on scanning files. 400000 processed.                                    run.py:96

Interesting, two separate Unicode errors. I will try to push a patch this evening! I will ping when I merge and build.

Thank you for looking into this.

Another server having similar issues with Unicode errors, but different position.
17:00:04 REGISTRY Reading HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\sibot                 scan.py:65
REGISTRY Key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\sibot does not exist. registry.py:93
REGISTRY Reading HKEY_LOCAL_MACHINE\Software\Microsoft\CTF                                          scan.py:65
REGISTRY Reading HKLM\SOFTWARE\Wow6432Node\Microsoft\Windows NT\CurrentVersion\Image File Execution scan.py:65
Options
REGISTRY Found 0 hit(s) for Sibot - Registry indicator.                                             scan.py:47
REGISTRY Found 0 hit(s) for Teardrop - Registry Activity indicator.                                 scan.py:47
REGISTRY Found 0 hit(s) for IFEO Persistence indicator.                                             scan.py:47
YARA     Enumerating the entire filesystem due to ['simpleseesharp : Webshell Unclassified',        run.py:141
'reGeorgTunnel : Webshell Commodity', 'sportsball : Webshell', 'Detection for the use of
procdump to dump LSASS process memory.', 'CISA Solar Fire', 'CISA Teardrop', 'CrowdStrike
Rempack', 'CrowdStrike Sunspot', 'FireEye Cosmic Gale', 'FireEye Sunburst']... this is
going to take a while.
17:00:05 EVENTS   Reading Application event logs.                                                            scan.py:69
17:00:08 EVENTS   Reading KernelMode event logs.                                                             scan.py:69
17:00:10 EVENTS   Reading Windows Powershell event logs.                                                     scan.py:69
17:00:20 EVENTS   Reading Security event logs.                                                               scan.py:69
17:02:22 YARA     Beginning processing.                                                                      run.py:100
Traceback (most recent call last):
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp.py", line 17, in
run.run()
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\run.py", line 20, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\run.py", line 30, in run_plugins
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\asyncio\base_events.py", line 616, in run_until_complete
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\run.py", line 44, in _run_coroutines
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\plugins\network\scan.py", line 44, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\plugins\network\network.py", line 37, in parse_dns
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 5910: invalid start byte
17:07:03 YARA     We're still working on scanning files. 50000 processed.                                     run.py:96
17:12:38 YARA     We're still working on scanning files. 100000 processed.                                    run.py:96

Win2016 Server with similar UnicodeError with different location.  Adding output below.
16:45:57 EVENTS   Reading Security event logs.                                                               scan.py:69
16:46:05 REGISTRY Reading HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\sibot                 scan.py:65
16:46:06 REGISTRY Key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\sibot does not exist. registry.py:93
REGISTRY Reading HKEY_LOCAL_MACHINE\Software\Microsoft\CTF                                          scan.py:65
REGISTRY Reading HKLM\SOFTWARE\Wow6432Node\Microsoft\Windows NT\CurrentVersion\Image File Execution scan.py:65
Options
REGISTRY Found 0 hit(s) for Sibot - Registry indicator.                                             scan.py:47
REGISTRY Found 0 hit(s) for Teardrop - Registry Activity indicator.                                 scan.py:47
REGISTRY Found 0 hit(s) for IFEO Persistence indicator.                                             scan.py:47
YARA     Enumerating the entire filesystem due to ['simpleseesharp : Webshell Unclassified',        run.py:141
'reGeorgTunnel : Webshell Commodity', 'sportsball : Webshell', 'Detection for the use of
procdump to dump LSASS process memory.', 'CISA Solar Fire', 'CISA Teardrop', 'CrowdStrike
Rempack', 'CrowdStrike Sunspot', 'FireEye Cosmic Gale', 'FireEye Sunburst']... this is
going to take a while.
16:57:18 EVENTS   Reading Windows Powershell event logs.                                                     scan.py:69
16:57:26 EVENTS   Reading Application event logs.                                                            scan.py:69
16:58:10 EVENTS   Reading KernelMode event logs.                                                             scan.py:69
17:00:57 YARA     Beginning processing.                                                                      run.py:100
Traceback (most recent call last):
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp.py", line 17, in
run.run()
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\run.py", line 20, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\run.py", line 30, in run_plugins
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\asyncio\base_events.py", line 616, in run_until_complete
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\run.py", line 44, in _run_coroutines
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\plugins\network\scan.py", line 44, in run
File "C:\Users<username>\AppData\Local\Temp\ONEFIL~2\chirp\plugins\network\network.py", line 37, in parse_dns
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xff in position 5105: invalid start byte
17:20:09 YARA     We're still working on scanning files. 50000 processed.                                     run.py:96
17:36:38 YARA     We're still working on scanning files. 100000 processed.                                    run.py:96
17:48:44 YARA     We're still working on scanning files. 150000 processed.                                    run.py:96
17:54:40 YARA     We're still working on scanning files. 200000 processed.                                    run.py:96
17:56:18 YARA     We're still working on scanning files. 250000 processed.                                    run.py:96
18:03:33 YARA     We're still working on scanning files. 300000 processed.                                    run.py:96
18:15:59 YARA     We're still working on scanning files. 350000 processed.                                    run.py:96
18:25:48 YARA     We're still working on scanning files. 400000 processed.                                    run.py:96
18:38:49 YARA     We're still working on scanning files. 450000 processed.                                    run.py:96
18:55:09 YARA     We're still working on scanning files. 500000 processed.                                    run.py:96
19:20:22 YARA     We're still working on scanning files. 550000 processed.                                    run.py:96
19:44:00 YARA     We're still working on scanning files. 600000 processed.                                    run.py:96
19:58:25 YARA     We're still working on scanning files. 650000 processed.                                    run.py:96
20:21:57 YARA     We're still working on scanning files. 700000 processed.                                    run.py:96
20:37:50 YARA     We're still working on scanning files. 750000 processed.                                    run.py:96

When #33 is merged, I will build the release for this fix.


Audited qiskit.org links

This PR replaces any qiskit.org links with 1XP or github equivalents. Need to wait to merge until I can update the deprecation policy and maintainer guide links after https://github.com/Qiskit/qiskit/pull/11218/ merges.
This should partially resolve #297 , however for the api links we'll need to make updates for those directly in the repos where the API refs live (maybe this is beyond the scope of the original issue?)

however for the api links we'll need to make updates for those directly in the repos where the API refs live (maybe this is beyond the scope of the original issue?)

I intended it to be in scope. But we could create a follow up issue if we want?

I intended it to be in scope. But we could create a follow up issue if we want?

Yeah, like with other API updates I think first and foremost this should be the responsibility of the devs that create the API reference. At least for now as our workload is so high as is

like with other API updates I think first and foremost this should be the responsibility of the devs that create the API reference.

I'm fine with that in general in the future for long-term maintenance. But as the team responsible for the qiskit.org migration, I do think it's appropriate for our team to do.
It should be fine if this slips from https://github.com/Qiskit/documentation/milestone/3 to https://github.com/Qiskit/documentation/milestone/5 thanks to redirects.


normalize the lambdas in lambdamart objective

[x] benchmark

ndcg at Yahoo LTR:

Metric
original
norm

ndcg@1
0.72757
0.732981

ndcg@3
0.731267
0.735689

ndcg@5
0.750774
0.75352

ndcg@10
0.791388
0.793498

ndcg at Yahoo LTR:

Metric
original
norm

ndcg@1
0.512893
0.519751

ndcg@3
0.50118
0.499677

ndcg@5
0.505995
0.5058

ndcg@10
0.524724
0.524123

I think the results with norm is better, so I will enable it by default.

Is there a technical report or a paper you could share with the learning-to-rank research community that explains what this normalization does and how it was derived/it mathematically makes sense?

@sbruch
It is just a simple trick for tree-based model, not for the general learning-to-rank applications.
The idea is similar to the reg_sqrt in regression tasks.
In short, the tree model is sensitive to the label ranges, for its outputs are the average of label values.
For the skew distribution, the leaf outputs will be drifted to the large outputs.
And add normalization can somehow solve this problem.

@StrikerRUS is this okay to merge?


Background is not substracting

Hello, I tried to use your code (only the part of substracting the background) , but seems like nothing is happening. The image i give input, the code simply shows me the same image.

please give more information about the issue


Remove EditorConfig options

.editorconfig is obsolete with linter configurations.

Decided to keep it in for the time being.


Move hash_bytes_into_chunks from execution-engine to Digest type.

We want to reuse the chunking logic in more places, to chunk other data types that just trie, and they all have to follow the same scheme:

be chunked before storing
have chunks' IDs being computed (in the fetcher) in a way that is aligned with how the data is stored

By moving this method from execution engine to Digest type we're making it easier for developers to use the correct logic instead of writing a new version of it.
Closes https://github.com/casper-network/casper-node/issues/3265 and https://github.com/casper-network/casper-node/issues/3264

bors merge


Write fake source code for compiler model

It would be useful to have a tool that, given some compiler model (from a .car file or a -model.js file or whatever), wrote some equivalent Ceylon code for the declarations in that model (eliding the actual code, of course – empty blocks).
For one, the IDE currently can’t load -model.js files, so unless that’s resolved first, to work with TypeScript modules using the IDE the TypeScript loader will have to create some form of .src file from which the IDE can load declarations. This tool would use the JS backend to read the -model.js file and write out files that can then be zipped up into an appropriate .src file.
This will probably be a separate project (using ceylon.ast, hopefully), but I’m filing the issue here for now.

Can typescript APIs be fully described in terms of Ceylon source?
I thought about this for Dart, but the typechecker supports things like static members and maybe-optional types that are necessary but aren't part of the language.

Hm, that’s a good point. For full support, we’d have to make up fake syntax for these features, then teach the IDE to load them…
Still, some support could be better than no support, I think.


Add setup.py and make renderdown an entry_point.

@jeffhung Hi, thank you for the pull request. I can perhaps merge this request but honestly this project is no longer being developed. If you are interested in continuing its development would you like to take over maintainership? If so I would update the README.md to point to the new location.

@goodmami Thanks for creating this handy tool. It fit perfectly to my project. I would like to canonicalize the installation, first by adding setup.py so it could be installed with pip. But if it could be available on PyPI eventually, that would be even better.
I have no problem to take over maintainership. However, I think you as the original author shall be honored. And I have no intention to take over your credit. So, please let me know in what approach you would prefer. :-)

@jeffhung I'm glad it's working for you. I still think Markdown generation is an underdeveloped area, but for my projects I ended up just going with restructuredText and Sphinx to generate documentation because I didn't have time to maintain my own document preparation system.
For taking over maintainership, I appreciate your desire to keep attribution. I have created issue #6 which explains some steps you can take to do that while taking ownership. Does that sound good to you?


feat(style checks): allow underscore lambda params

We should allow __ to denote that a (required) lambda parameter is unused.
(I didn't do this for standard method parameters, as that seems overkill for our purposes. After all, no-argument methods are allowed in Java - but no-argument lambdas are not.)
As discussed in this StackOverflow post.

It's not in the official style guide.
@averikitsch @kurtisvg thoughts?

Per offline conversation with @lesv and internal research - the right answer here is to use single-letter variable names. (The underscore approach suggested here has been considered in the past, and was previously decided against.)


Is --default-backend-service really required for Nginx Ingress Controller?

Why --default-backend-service flag for nginx-ingress-controller is required?
Couldn't we just serve nginx static 404 page by default if no default backend is provided?
Idea to deploy and expose one more service in cluster just for simple 404 page is pretty strange. Do I miss something?

Couldn't we just serve nginx static 404 page by default if no default backend is provided?

Yes, is possible to do that but the goal is to be compatible with the GCE controller where is not possible to expose an internal static resource.
Besides that using a service to expose the default error page allows custom content without the need to use a custom nginx controller image.

My point is to leave flag --default-backend-service, but make it optional.
If we specify --default-backend-service everything works like just now, and we have all those benefits and compatibilities.
If we do not specify this flag, just serves default static 404 page.
So... Both the wolves have eaten much and the sheep have not been touched!
If this is OK, I'll made a pull request to implement.

@tyranron honestly I prefer to keep the flag.
@bprashanth  ping

We should keep the flag, I don't mind defaulting it to something implementation specific if user doesn't supply it. We should make the defaults of a given implementation:

cross platform friendly so people who switch over aren't surprised
more natural to people who already use that implementation, so ingress on-boarding isn't a burden

@bprashanth I think I am starting to understand your goals, but still not very well.
To switch over implementation, user should explicitly specify manifest of ingress controller to be switched on, so he exactly knows what he is providing (no surprises). GCE and Nginx ingress controllers manifests have different image names, executable command name...so having slightly different flags and their behaviour is really so bad in this case? Why should we abstract exactly on flags? Is there ingress controller pod abstraction not enough?
The first thing coming in mind to satisfy 1 and 2 is just to serve exactly the same static page that is exposed by default-backend-service.
P.S. Sorry for making noise. I'm just trying to understand underneath ideology.

.so having slightly different flags and their behaviour is really so bad in this case? Why should we abstract exactly on flags? Is there ingress controller pod abstraction not enough?

We should abstract on behavior, not flags. In this case the flag influences user facing behavior, which would be bad in the case where an admin has deployed 2 ingress controllers with default flag values, and the user is just going to create one ingress with ingress.class=nginx, test it, then graduate it to production by flipping the annotation to ingress.class=aws/gce. The behavior of what's returned on a particular url shouldn't change.

@bprashanth @aledbf
Ok. Sorry for late reply.
What about providing some "magic" value of --default-backend-service arg and not making it default?
For example: --default-backend-service=:static.

@bprashanth @aledbf any suggestions?

Sincerely, I have agree with @tyranron.

@KristianWindsor you may. It's optional since 0.20.0.

i have the issue when create pod nginx-ingress-controller, the "kubectl logs " shows :  "F0401 08:46:56.430858       8 main.go:72] Please specify --default-backend-service"
actually, i have deoloy the default-backend-service
anyone knows how to debug it ? thanks so much

@chencheng696 check if correct version of Docker image is used, or check carefully other flags and settings in ConfigMap whether they require default backend service mandatory.


Added option to select lines in an input file

Closes #529
Took most of the coding from the playlist selection.

tangou check failed, everything else is fine
@iawia002 fix it or leave it?

tests failed due to pornhub extractor, I'll try to fix it or just ignore it

Fixed the issues


Preferred display name (row-name) for linked entities

Use common annotation and logic shared with #358 to determine a preferred way of referring to entities in a foreign domain table. Replace foreign key values with this preferred entity name when displaying the link.
Karl suggests extending the display annotation at table level with another field like row_name that uses a template to form a row name from row values.  The name field is already used for the display name of the table.  The display annotation at column level can rename the foreign key column using the name field, and at column level this new row_name field should be ignored as irrelevant.
This should be done using the Reference API.

I updated the display annotation with a new row_name field.
https://github.com/informatics-isi-edu/ermrest/blob/annotation-update/user-doc/annotation.md#2015-display

Issue moved to informatics-isi-edu/ermrestjs #159 via ZenHub