Compiler error handling - syntax of actions

Add error handling and validation to the syntax below the action proerty

@oritstone could you give more information on this issue?
Do we want to verify that keys like python_script, java_action, className, methodName are respected?

Yes.
Also that we enforce the exact syntax.
For example. that below the action property there is either the java_action or the python_script property, and that below java_action there are always the className & methodName properties etc...

I just committed syntax validation under java_action property (see above). This involves changes in Java_ActionTransformer class.
If we want to validate the following cases:
(1)

operation_action_multiple_types:
action:
python_script:
print 'why am I here?'
java_action:
className: com.hp.thing
methodName: someMethod (currently java_action is used in this case silently)

(2)
- missing_action_properties:
action:
java_action: (fails with missing python script message)
(3)
- missing_python_script:
action:
python_script:
In order to verify these cases I see two approaches:
Complex approach:

validate in ExecutionStepFactory->createActionStep method
in order to do that we must distinguish between the 2 cases: key is present but empty / key is not  present (currently both are interpreted as null value)
for that I think I should modify the TransformersHandler->runTransformers method (and probably other methods / transformers - may not be a good  idea (?))

Simple approach:

1 is considered ok
2 + 3 would fail with a common message like "invalid action data" (ExecutionStepFactory->createActionStep)

WDYT?

:+1: Simple approach

I think that the error message should be more accurate. For example:

If under action you something other than python_script: or java_action, you should say that only those 2 are allowed
If under java_action you don't have both className & methodName, you should say which attribute is missing
1 above is wrong - there can't be both


Allow bare type variables in the RHS only if they appear bare in the pattern

In his proof Richard showed that this definition should not be accepted as injective:
type family F a = r | r -> a
type instance F [a] = a

Reason: F [F Int] ~ F Int (from equation for F) and from injectivity we have [F Int] ~ Int.
Proposed solution: allow bare type variables in the RHS only if they appear bare in the LHS pattern.

It's worse than just this. Not only do they have to appear bare on the LHS, the bare variable must be the only variable on the LHS.
 So, the only injective type family with a bare variable on the right is Id a = a.

Urgh.

Now, we can see that F (F Bool Bool) Int ~ F Bool Bool and thus, by injectivity, Int ~ Bool.

Equally interestingly we can also see F Bool Bool ~ Bool. We just created a new type family equation :-)

Almost done - kind polymorphism trips my current implementation:
type family F (a :: k) = (r :: k) | r -> a where
  F a =a

Internally k is also an argument to F and so it seems F has two patterns rather than one.

Already implemented.


clightning: <IP_ADDRESS> -> 0.7.3

Motivation for this change
New release. Requires gettext to build as mentioned in the changelog (https://github.com/ElementsProject/lightning/blob/v0.7.3/CHANGELOG.md).
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions (ArchLinux)

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @jb55

@jonringer sorry I didn't test on a NixOS machine before. It's fixed now after adding devtools/sql-rewrite.py to the patchShebang list.

all good

oops forgot to push

@GrahamcOfBorg build clightning


Accuracy .

Hi,
Thanks for your work.
I just gave it a run .. to have a feeling how it is working
the network is not really giving the right object .. it gives a prediction of tv monitor while im showing a bottle.
I tried it with and Android mobile  without GPU and another Android with GPU. they needed almost the same time. I just noticed that the GPU Android get heated quickly. maybe capture image and send it for prediction would be good idea instead of keep sending frames.
one last thing, any recommendations for the network size? the pb file? I have around 1800 images and many objects inside them.

Hi Szaza,
I'm not able to run your YoloV2 app after export (finished training with my own dataset) both of my .pb and label.txt file to android/asset/folder to replace tiny-yolov2.pb and label.txt.
Please kindly advise.


Merge refs/heads/issue/aggregations-behavior into alpha

Merge refs/heads/issue/aggregations-behavior into alpha

This PR has been merged into alpha and tagged as 2.0.0-alpha-202308211441. Thanks for your contribution!


vast-front doesn't create static global variables

Seems like it doesn't go through VisitVarDecl at all for some reason (normal global variables do go through it)
Fails silently - the crash occurs when we attempt to get the defining op in processing of a use of the variable
It also isn't present in the resulting MLIR
Minimal example:

static int a = 2;
int main(int argc, char *argv[]) {
    int x = a;
    return 0;
}

Make sure to also try having the static int a within the function definition, i.e. lexical != semantic decl context.

Also be sure to try:
static int a = 2;
int main(int argc, char *argv[]) {
  int x;
  if (argc) {
    static int a = 1;
    x = a;
  } else {
    static int a = 2;
    x = a;
  }
  return x;
}


Pending task

Just wanted to add to this, that I decided to make the default for spinner to be false (even though it seems like we most frequently want it set).  It seemed somehow more appropriate, and the extra boilerplate not horrible, if it forces developers to think about it it a little. Happy to be convinced otherwise -- we could also bring back LoadMask, just to default that flag, but that seemed like extra complexity that would not be worth it.


feat: export bindActionCreators

Checklist

[x] npm test passes
[ ] tests are included
[ ] documentation is changed or added
[x] commit message follows commit guidelines

Description of change

any feature?
close https://github.com/dvajs/dva/ISSUE_URL

Coverage remained the same at 87.282% when pulling c83672ed52afc9943f8c69ddf59f9c2de01bc8c7 on zhanba:master into 0ff10e08829746778d3a78526102de55dff4f9a9 on dvajs:master.

Need bindActionCreators when use dva-model-creator.


Ask which profile file the user want to modify

Ask which profile file the user want to modify

Done! That change is already on the master branch


Omit tract in septuagesima feria days

In Septuagesima feria days for which last Sunday propers are used tract should be omitted.

Fixed in #85


InventoryTransactionResult IllegalStateException

ItemStack record = ItemStack.builder().itemType(ItemTypes.RECORD_CAT).quantity(1).build();
Text name = Text.of("test");
record.offer(Keys.DISPLAY_NAME, name);
InventoryTransactionResult result = player.getInventory().offer(record);

will result in
java.lang.IllegalStateException
	at com.google.common.base.Preconditions.checkState(Preconditions.java:161) ~[guava-17.0.jar:?]
	at org.spongepowered.api.item.inventory.transaction.InventoryTransactionResult$Builder.build(InventoryTransactionResult.java:181) ~[InventoryTransactionResult$Builder.class:?]
	at org.spongepowered.common.item.inventory.adapter.impl.Adapter$Logic.appendSequential(Adapter.java:222) ~[Adapter$Logic.class:?]
	at org.spongepowered.common.item.inventory.adapter.impl.Adapter$Logic.appendSequential(Adapter.java:193) ~[Adapter$Logic.class:?]
	at org.spongepowered.common.item.inventory.adapter.impl.MinecraftInventoryAdapter.offer(MinecraftInventoryAdapter.java:72) ~[MinecraftInventoryAdapter.class:?]

It also seems to add the unnamed item into the inventory

Ah I see what's happened. Before I rebased I didn't know that InventoryOperationResult had been replaced with InventoryTransactionResult in the API, so when I rebased I naturally replaced my concrete classes with the new one from the API, since the contract looked the same. However as you can see, before it was deleted my OperationResult defaulted to SUCCESS and expects a failure state to be set only if necessary, however it seems the contract on [InventoryTransactionResult] is actually different and requires SUCCESS to be set explicitly.
The data in the itemstack is currently removed because I need to consult with @gabizou about cloning the data on item stacks. The item stacks are currently defensively copied before insertion but this currently omits the metadata (hence the TODOs).
I will be generally tidying up Inventory anyway and these issues are both easily fixed.

Ah I see what's happened. Before I rebased I didn't know that InventoryOperationResult had been replaced with InventoryTransactionResult in the API, so when I rebased I naturally replaced my concrete classes with the new one from the API, since the contract looked the same. However as you can see, before it was deleted my OperationResult defaulted to SUCCESS and expects a failure state to be set only if necessary, however it seems the contract on [InventoryTransactionResult] is actually different and requires SUCCESS to be set explicitly.
The data in the itemstack is currently removed because I need to consult with @gabizou about cloning the data on item stacks. The item stacks are currently defensively copied before insertion but this currently omits the metadata (hence the TODOs).
I will be generally tidying up Inventory anyway and these issues are both easily fixed.

@Mumfrey Thankya <3

@Mumfrey Thankya <3

@clienthax can you check this works for your use, it works in my tests now.


footer: fix rel=noopener attribute

There's no need to use rel=noopener without target=_blank, but otherwise, it should be used since it's a potential security issue.

BTW @mdo CodeQL and LGTM did catch these 😛


Unit Tests: Update on Missing or Incomplete Unit Tests

Current status: 156 passed, 8 skipped
8 skipped:

test_DesignOverview.py (s) (Bugfix G-30112)
test_ModelCheck.py (s) (Method does not exist: model_check__get_object_groups_operation)
test_SectionDialogue.py (s) (Method does not exist: create_section_favorite_list)
test_concreteDesign.py (s) (Type does not exsit: concrete_durability)
test_objectInformation.py (sss) (Type does not exist: array_of_get_center_of_gravity_and_objects_info_elements_type)
test_steelEffectiveLengths.py (s) (Bugfix G-30112)

All tests missing asserts are covered. Skipped were only those that pytest ignore (@pytest.mark.skipif).

See main comment at top of pull request regarding status of skipped unit tests.

158 passed, 7 skipped in 199.21s version 6.02.0023.119.f2143bd6214


Asteroid Config XML

Hi zmasterfox,
I've added the medium asteroid bit to asteroidConfig.xml and it looks pretty reasonable except the Iridium ore has the texture for Dilithium.
Is this a reasonable config?
<Asteroids>
	<asteroid name="Small Asteroid" distance="10" mass="100" massVariability="0.5" minLevel="0" probability="1" richness="0.2" richnessVariability="0.5">
		<ore itemStack="minecraft:iron_ore" chance="15" />
		<ore itemStack="minecraft:gold_ore" chance="10" />
		<ore itemStack="minecraft:redstone_ore" chance="10" />
	</asteroid>
	<asteroid name="Med Asteroid" distance="10" mass="500" massVariability="0.5" minLevel="0" probability="0.5" richness="0.2" richnessVariability="0.5">
	    <!-- ore0 is Dilithium, 8 is Rutile, 9 is Aluminium and 10 is Iridium -->
		<ore itemStack="libvulpes:ore0" chance="20" />
		<ore itemStack="libvulpes:ore0 8" chance="20" />
		<ore itemStack="libvulpes:ore0 9" chance="20" />
		<ore itemStack="libvulpes:ore0 10" chance="20" />
	</asteroid>
</Asteroids>

I looks good in the Observatory, I'll launch a rocket to mine it next.

I would personally make iridium have a lower chances so you get smaller quanities of it, but that's up to you if you want to do that or not.
Also, item texture for iridium is now fixed.

Thanks is was just a question to see I was doing this in the correctly, the balance is not reasonable and I think the distance should be larger, so it takes longer and need a better Observatory. Looks like the Observatory now collects data. And the texture is now correct.
Thanks a lot.

No problem


Build APK fails with unknown property 'runtimeConfiguration' error

when i try to build apk from my current application i get this error:

FAILURE: Build failed with an exception.

Where: Initialization script 'C:\flutter\packages\flutter_tools\gradle\aar_init_script.gradle'
line: 122

What went wrong: Could not get unknown property 'runtimeConfiguration' for object of type
com.android.build.gradle.internal.api.LibraryVariantImpl.

and i'm not sure whats that and how can i resolve
gradle-wrapper.properties:
#Fri Jun 23 08:50:38 CEST 2017
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.2-all.zip

build.gradle:
classpath 'com.android.tools.build:gradle:3.5.2'

doctor command output:
[√] Flutter (Channel beta, v1.11.0, on Microsoft Windows [Version 6.1.7601], locale en-US)
    • Flutter version 1.11.0 at C:\flutter
    • Framework revision 856a90e67c (3 weeks ago), 2019-11-08 18:00:01 -0800
    • Engine revision af04338413
    • Dart version 2.7.0

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at G:\software\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = G:\software\sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[√] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 41.1.2
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] VS Code (version 1.40.0)
    • VS Code at C:\Users\mahdi\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.6.0

[√] Connected device (1 available)
    • WAS LX1A • 2XJDU17C14006203 • android-arm64 • Android 8.0.0 (API 26)

! Doctor found issues in 1 category.

Hi @MahdiPishguy
could you please provide your flutter build --verbose ?
Thank you

@iapicca yes sure,
G:\Projects\Flutter\unlimited_power_pro>flutter build --verbose
[  +70 ms] executing: [C:\flutter\] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +74 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 856a90e67c9284124d44d2be6c785bacd3a1c772
[        ] executing: [C:\flutter\] git describe --match v*.*.* --first-parent --long --tags
[ +100 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[   +1 ms] v1.11.0-0-g856a90e67c
[   +8 ms] executing: [C:\flutter\] git rev-parse --abbrev-ref --symbolic @{u}
[  +37 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/beta
[        ] executing: [C:\flutter\] git ls-remote --get-url origin
[  +34 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
Missing subcommand for "flutter build".

Hi @MahdiPishguy
the logs seems to point to a androidx incompatibility in the plugins
[   +2 ms] The built failed likely due to AndroidX incompatibilities in a plugin.
The tool is about to try using Jetfier to solve the incompatibility.

do the proposed solutions fix the issue?
thank you

@iapicca i tested your linked me solution before creating new issue here, unfortunately it doesn't any change :(
gradle.properties :
org.gradle.jvmargs=-Xmx1536M
android.enableR8=true
android.useAndroidX=true
android.enableJetifier=true

app build.gradle:
defaultConfig {
    // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
    applicationId "xx.xxxx.xxxxxxxxx"
    minSdkVersion 16
    targetSdkVersion 29
    versionCode flutterVersionCode.toInteger()
    versionName flutterVersionName
    testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
    multiDexEnabled true
}

@MahdiPishguy
I got the same issue of  packaging audioplayer and the error message, "build fail with unknown property 'runtimeConfiguration'",  also quite similar with you.  But all things  was ever going well before downgrading flutter to v1.11.0, so I upgrade flutter back to v1.12.13+hotfix.3, then I got an error message as below:
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':audioplayer:verifyReleaseResources'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
   > Android resource linking failed
     C:\Users\gordianknot\.gradle\caches\transforms-2\files-2.1\0a271e99b6771ad4a84318244d532fb7\core-1.0.0\res\values\values.xml:57:5-88:25: AAPT: error: resource android:attr/fontStyle not found.

     C:\Users\gordianknot\.gradle\caches\transforms-2\files-2.1\0a271e99b6771ad4a84318244d532fb7\core-1.0.0\res\values\values.xml:57:5-88:25: AAPT: error: resource android:attr/font not found.

     C:\Users\gordianknot\.gradle\caches\transforms-2\files-2.1\0a271e99b6771ad4a84318244d532fb7\core-1.0.0\res\values\values.xml:57:5-88:25: AAPT: error: resource android:attr/fontWeight not found.

     C:\Users\gordianknot\.gradle\caches\transforms-2\files-2.1\0a271e99b6771ad4a84318244d532fb7\core-1.0.0\res\values\values.xml:57:5-88:25: AAPT: error: resource android:attr/fontVariationSettings not found.

     C:\Users\gordianknot\.gradle\caches\transforms-2\files-2.1\0a271e99b6771ad4a84318244d532fb7\core-1.0.0\res\values\values.xml:57:5-88:25: AAPT: error: resource android:attr/ttcIndex not found.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 36s
Running Gradle task 'assembleRelease'...
Running Gradle task 'assembleRelease'... Done                      37.4s
The built failed likely due to AndroidX incompatibilities in a plugin. The tool is about to try using Jetfier to solve the incompatibility.
Building plugin audioplayer...
Running Gradle task 'assembleAarRelease'...
Running Gradle task 'assembleAarRelease'... Done                    3.6s
NDK is missing a "platforms" directory.
If you are using NDK, verify the ndk.dir is set to a valid NDK directory.  It is currently set to D:\Users\gordianknot\AppData\Local\Android\android-sdk\ndk-bundle.
If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove this warning.

Incremental java compilation is an incubating feature.

BUILD FAILED

Total time: 3.336 secs

FAILURE: Build failed with an exception.

* Where:
Initialization script 'E:\flutter\packages\flutter_tools\gradle\aar_init_script.gradle' line: 122

* What went wrong:
Could not get unknown property 'runtimeConfiguration' for object of type com.android.build.gradle.internal.api.LibraryVariantImpl.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

The plugin audioplayer could not be built due to the issue above.

and I set compileSdkVersion of audioplayer to 28 to match the sdkversion used in my project.
android {
    compileSdkVersion 28 // 25
//    buildToolsVersion '25.0.3'
    ...
}

then It works....
hope it works for you.

I had the same situation change "audioplayer" plugin for "audioplayers" and it worked.

Hi @MahdiPishguy
are you experiencing the issue with the latest stable version of flutter?
Please note that both audioplayers (github) and audioplayer (github) are 3rd party plugin;
if you believe the issue being caused by said plugins,
please open an issue in the dedicated gitub
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

i had this issue too,
i solve the error by changing my library package  from audioplayer to another one.
you can use other library like
audioplayers,
audiofileplayer or just_audio


Member::$user->bot

$message->mentions is a collection of User objects, so you should do if ($target->bot).
Change the first line as well: $message->author->user. You should also check if it is a PM, as $message->author will be a User object already if it is a PM.

Works, thanks!


Pager ALL THE THINGS

Make all sub-models self iterate so we stop getting "only returned X" bugs

This was resolved in #231


Fix typos in "Load Secrets from .env"

"gets loading" to "gets loaded"
"environment variables called" to "environment variable called"

Thank you!


很好的工作，但是... Good work, but ...

如果你们让QMIX用8个进程，增大Batch Size和或者每次训练epoch次数，最后加上 TD(lambda)<=0.5
QMIX能把这些算法干趴下
参考我们的简略调参 https://arxiv.org/abs/2102.03479
我真的发现 MARL这个领域 由于调参的问题导致一大堆错误的结论和实验甚至motivation出发就错了，涉及十篇+ CCFA顶会paper
尤其是 AAAI 这个会议的文章连证明是错的都能 accept

English Version
If you let QMIX also use 128 processes (8 is fine), increase the Batch Size and or the number of epochs per training, and finally add TD(lambda)<=0.5
QMIX can take these algorithms down
Refer to our abbreviated tuning reference https://arxiv.org/abs/2102.03479
I really found that MARL is a field where the problem of parametrization leads to a lot of wrong conclusions and experiments and even motivation is wrong from the beginning, involving 10+ CCFA top papers

Thanks for the comments.
We are not surprised that with better tuning, QMix can be even better. However, this is parallel to our focus. What our paper shows is that policy gradient algorithms, which are typically assumed to be less sample efficient, can be surprisingly effective compared with the off-policy algorithms, which are used the most in the existing MARL literature.
Regarding the wrong conclusions and motivations, as one of the initial contributors of deep MARL literature, I partially agree that some of the conclusions might worth re-examinination but disagree that they are all wrong. It is possible that the execution procedure of research ideas can be improved but strong evidence would be expected before making such claims. I would encourage the authors to carefully study the existing literature and analyze what specifically is problematic to benefit the community.
Here is a really nice example of how researchers from Google did so in a scientific manner previously: https://arxiv.org/abs/1802.10031

English Version
If you let QMIX also use 8 processes, Increase the Batch Size and or the number of epochs per training, and finally add TD(lambda)<=0.5
QMIX can beat all these algorithms.
Refer to our simple tuning: RIIT https://arxiv.org/abs/2102.03479
I really found that MARL is a field where the problem of hyperparameters leads to a lot of wrong conclusions and experimental results and even the motivation is wrong from the beginning, involving 10+ CCFA top papers

Hi, thanks for your search about the implementation tricks. However, I think more experimental results and theoretical analyses are expected to support your strong conclusion.
Most of the papers studied in your work are not motivated by tasks in the SMAC benchmark. Some SMAC tasks do not require a high degree of coordination among agents and typically do not suffer from problems like relative overgeneralization. For example, on the map corridor, independent PPO has good performance. On more complex tasks like predator and prey, theoretically and empirically, algorithms like WQMIX and QPLEX would have better performance.
Therefore, depending on several maps from the SMAC benchmark without analyses of the task structure may not benefit the MARL community. More experiments characterized by unique challenges of multi-agent learning would be expected for a more beneficial discussion.

English Version
If you let QMIX also use 8 processes, Increase the Batch Size and or the number of epochs per training, and finally add TD(lambda)<=0.5
QMIX can beat all these algorithms.
Refer to our simple tuning: RIIT https://arxiv.org/abs/2102.03479
I really found that MARL is a field where the problem of hyperparameters leads to a lot of wrong conclusions and experimental results and even the motivation is wrong from the beginning, involving 10+ CCFA top papers

Hi, thanks for your search about the implementation tricks. However, I think more experimental results and theoretical analyses are expected to support your strong conclusion.
Most of the papers studied in your work are not motivated by tasks in the SMAC benchmark. Some SMAC tasks do not require a high degree of coordination among agents and typically do not suffer from problems like relative overgeneralization. For example, on the map corridor, independent PPO has good performance. On more complex tasks like predator and prey, theoretically and empirically, algorithms like WQMIX and QPLEX would have better performance.
Therefore, results on several maps from the SMAC benchmark without analyses of the task structure may not benefit the MARL community. More experiments characterized by unique challenges of multi-agent learning would be expected for a more beneficial discussion.

都是中国人，那我直接用中文回答吧。假设 Predator Prey 比 SMAC 更复杂吧，很明显这个 Task 更适合用连续控制来做（参考 MADDPG）。
我直接用 Deep Multi-Agent Reinforcement Learning for Decentralised Continuous Cooperative Control 里面的实验结果说明。
这里使用的 Predator-Prey 是完全合作性质的，如下图所示，所以干掉单调性约束性能增强了？

Thanks for the comments.
We are not surprised that with better tuning, QMix can be even better. However, this is parallel to our focus. What our paper shows is that policy gradient algorithms, which are typically assumed to be less sample efficient, can be surprisingly effective compared with the off-policy algorithms, which are used the most in the existing MARL literature.
Regarding the wrong conclusions and motivations, as one of the initial contributors of deep MARL literature, I partially agree that some of the conclusions might worth re-examinination but disagree that they are all wrong. It is possible that the execution procedure of research ideas can be improved but strong evidence would be expected before making such claims. I would encourage the authors to carefully study the existing literature and analyze what specifically is problematic to benefit the community.
Here is a really nice example of how researchers from Google did so in a scientific manner previously: https://arxiv.org/abs/1802.10031

吴教授，您好
我觉得您的这份工作很好，提出一些存在的问题。
谢谢


Connecting with only one Connection

This is not urgent, just might be a convenience.
If I have just one IBM i to connect to e.g.

Could it just jump immediately to the password prompt so I don't have to click the connection.

A nice to have idea for sure. I can work on this :)


Clean up code

As of right now Vide'reLonge' isn't very messy however it could be better especially as I add more features to it.

Partially done but there are a few improvements to be made.

Partially complete


Develop satellite

Initial PR for develop_satellite to develop,  to start review comments.

Fixed

@dwfncar I went through and resolved the outstanding issues. The merge conflict I think should be resolved as follows:
                            if obs_type == 'pt_sfc':
                                pairdf = pairdf.set_index(grp_dict['data_proc']['ts_select_time'])

                            # Specify ts_avg_window if noted in yaml file.
                            if 'ts_avg_window' in grp_dict['data_proc'].keys():
                                a_w = grp_dict['data_proc']['ts_avg_window']
                            else:
                                a_w = None

I think once that is fixed this is good to go.

Fixed final conflict - should be good to merge.


Crash when fetching device model

Submitting this on behalf of a customer.
Currently their app is logging crashes when it accesses the line at https://github.com/mixpanel/mixpanel-iphone/blob/v2.6.2/Mixpanel/Mixpanel.m#L297 which can be found in the most recent release at https://github.com/mixpanel/mixpanel-iphone/blob/master/Mixpanel/Mixpanel.m#L871. Since this pod is old the issue could have been resolved, but since the code has not changed I wanted to post this here.
Suggested fix by the customer is to handle this as an exception, but I might argue we simply ignore assignment of the property in this instance. Here is their fix:
- (NSString *)deviceModel
{
size_t size;
sysctlbyname("hw.machine", NULL, &size, NULL, 0);
char answer[size];
@try {
sysctlbyname("hw.machine", answer, &size, NULL, 0);
NSString *results = @(answer);
return results;
}
@catch (NSException *exception) {
return @"";
}
}

Here is the stack trace:
0
libsystem_platform.dylib 0x0000000197585a80 OSAtomicDequeue + 8
1
libsystem_malloc.dylib 0x000000019752d064 nano_malloc + 40
2
libsystem_malloc.dylib 0x000000019751d3e4 malloc_zone_malloc + 112
3
CoreFoundation 0x0000000184f96e08 _CFRuntimeCreateInstance + 372
4
CoreFoundation 0x0000000185083f28 __CFStringCreateImmutableFunnel3 + 2196
5
CoreFoundation 0x0000000184f9857c CFStringCreateWithBytes + 40
6
Foundation 0x0000000185eca6b8 -[NSPlaceholderString initWithBytes:length:encoding:] + 140
7
Foundation 0x0000000185eca608 +[NSString stringWithUTF8String:] + 156
8
Redacted 0x00000001002e9c8c -[Mixpanel deviceModel] (Mixpanel.m:297)
9
Redacted 0x00000001002f5a94 -[MixpanelPeople collectAutomaticPeopleProperties] (Mixpanel.m:1745)
10
Redacted 0x00000001002f5904 -[MixpanelPeople initWithMixpanel:] (Mixpanel.m:1730)
11
Redacted 0x00000001002e8f88 -[Mixpanel initWithToken:launchOptions:andFlushInterval:] (Mixpanel.m:138)
12
Redacted 0x00000001002e8e1c __50+[Mixpanel sharedInstanceWithToken:launchOptions:]_block_invoke (Mixpanel.m:111)
13
libdispatch.dylib 0x00000001973ad954 _dispatch_client_callout + 12
14
libdispatch.dylib 0x00000001973ae82c dispatch_once_f + 92
15
Redacted 0x00000001002e8dc0 +[Mixpanel sharedInstanceWithToken:launchOptions:] (once.h:68)
16
Redacted 0x00000001003cb4cc -[MTAppDelegate trackAppOpen] (MTAppDelegate.m:392)
17
Redacted 0x00000001003c8df0 -[MTAppDelegate application:didFinishLaunchingWithOptions:] (MTAppDelegate.m:103)
18
Redacted 0x000000010010c714 -[DAAppDelegate application:didFinishLaunchingWithOptions:] (DAAppDelegate.m:48)
19
UIKit 0x0000000189ba7124 -[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:] + 400
20
UIKit 0x0000000189dbe7e8 -[UIApplication _callInitializationDelegatesForMainScene:transitionContext:] + 2372
21
UIKit 0x0000000189dc119c -[UIApplication _runWithMainScene:transitionContext:completion:] + 1500
22
UIKit 0x0000000189dbf70c -[UIApplication workspaceDidEndTransaction:] + 180
23
FrontBoardServices 0x000000018d8f93c8 __31-[FBSSerialQueue performAsync:]_block_invoke_2 + 28
24
CoreFoundation 0x000000018507427c CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK + 16
25
CoreFoundation 0x0000000185073384 __CFRunLoopDoBlocks + 308
26
CoreFoundation 0x00000001850719a8 __CFRunLoopRun + 1752

According to the log, it is not sysctlbyname() which is throwing, but @(answer). In fact, sysctlbyname() cannot throw.
A simple check on size != 0 would be better than the try-catch.

You are totally right, @Coeur . Thanks for the PR :)


Migrate infrastructure definitions from our Github Actions to Terraform

As we're migrating our infrastructure definitions to Terraform, we should also consider moving all the infrastructure definitions being done inside our GitHub Actions to Terraform.

Issue moved to ZcashFoundation/infra #8 via Zenhub


Help remapping volume keys to M, <, > via Karabiner

Aloha,
If anyone has help and input it would be greatly appreciated!  New to remapping and using karabiner.  My goal here is to remap my mute, volume down and volume up keys to M, < and > respectively.  My modifier keys would be Shift left + Command left + ______ (remapped key).
Heres what my coding looks like in my private doc
</item> 	<name> Volume Key Adjust: Cmd + Shift + M<> </name>         <identifier>private.coolaj86_cmd_shift_volume</identifier>         <autogen>             __KeyToKey__              KeyCode::M,             ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,             KeyCode::VOLUME_MUTE         </autogen>         <autogen>             __KeyToKey__              KeyCode::COMMA,             ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,             KeyCode::VOLUME_DOWN         </autogen>         <autogen>             __KeyToKey__              KeyCode::DOT,             ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,             KeyCode::VOLUME_UP         </autogen> </item>

You mix up the order of the key, full doc can be found here about keytokey
https://pqrs.org/osx/karabiner/xml.html.en#keytokey-syntax
The following code should work :)
</item>
<name> Volume Key Adjust: Cmd + Shift + M<> </name>
<identifier>private.coolaj86_cmd_shift_volume</identifier>

<autogen>
__KeyToKey__
<!-- from -->
KeyCode::VOLUME_MUTE,
<!-- to -->
KeyCode::M, ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,
</autogen>

<autogen>
__KeyToKey__
KeyCode::VOLUME_DOWN,
KeyCode::COMMA, ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,
</autogen>

<autogen>
__KeyToKey__
KeyCode::VOLUME_UP,
KeyCode::DOT, ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,
</autogen>
</item>

@dunkarooftop Mahalo!  Unfortunately iʻm getting an error indicating: that there is an error in the XML.  </Users/JustinB/Library/Application Support/Karabiner/private.xml>(1): expected <
Also, I have another code that iʻm using to change the JKLI to arrow keys, could this be conflicting?   I tried running each separately, and the code for the arrow keys work fine, but once the volume keys are added, it gives the error above.  Any advice?  Iʻll attach my entire code below.  Thank you very much!!!
`
Home Row Arrow Keys: Cmd + Shift + IJKL to ^<>v
private.coolaj86_cmd_shift_homerowarrows

KeyToKey
KeyCode::I,
ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,
KeyCode::CURSOR_UP

KeyToKey
KeyCode::J,
ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,
KeyCode::CURSOR_LEFT

KeyToKey
KeyCode::K,
ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,
KeyCode::CURSOR_DOWN

KeyToKey
KeyCode::L,
ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,
KeyCode::CURSOR_RIGHT

 Volume Key Adjust: Cmd + Shift + M<>
private.coolaj86_cmd_shift_volume

		__KeyToKey__

		KeyCode::VOLUME_MUTE,

		KeyCode::M, ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,

		__KeyToKey__
		KeyCode::VOLUME_DOWN,
		KeyCode::COMMA, ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,

		__KeyToKey__
		KeyCode::VOLUME_UP,
		KeyCode::DOT, ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,

 `

a few typo from my earlier code. Here is a tested working one.
<item>
<name> Volume Key Adjust: Cmd + Shift + M</name>
<identifier>private.coolaj86_cmd_shift_volume</identifier>

<autogen>
__KeyToKey__
<!-- from -->
ConsumerKeyCode::VOLUME_MUTE,
<!-- to -->
KeyCode::M, ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,
</autogen>

<autogen>
__KeyToKey__
ConsumerKeyCode::VOLUME_DOWN,
KeyCode::COMMA, ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,
</autogen>

<autogen>
__KeyToKey__
ConsumerKeyCode::VOLUME_UP,
KeyCode::DOT, ModifierFlag::SHIFT_L | ModifierFlag::COMMAND_L,
</autogen>
</item>

Mahalo @dunkarooftop but it still does not seem to work, i may have some conflicting code thats preventing it from working.  Thank you very much for your help though!

Do you get error while reloading XML or it load ok but not work as expected ? If XML load ok. Open Karaniner go to last page and open Event Viewer try it there see what keycode get out put


Mimic integration

Similarly to #136 , the Mimic plug-in could be used to improve compatibility with other plug-ins.

Custom Items 9.14 will have partial Mimic integration: it will register its custom items to Mimic, but can't use Mimic items that are registered by other plug-ins in crafting recipes.


obfuscator:disable/enable tags not removed from result

I noticed that when using tag comments likes /* javascript-obfuscator:disable */ that these remain in the output. They should be removed so as not to brand output with the name of a tool.

Agreed

Released as 1.2.0

Released 1.2.2 with a performance regression fix


Turn notebook execution back on

close #333

"auto" is the keyword!

"auto" is the keyword!

LOL I should look it up instead of guess the keyword


pr-pull: disable --workflow flag

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?
[x] Have you successfully run brew man locally and committed any changes?

Replaced by --workflows.

Review period will end on 2020-12-21 at 15:10:35 UTC.

Review period skipped due to critical label.


Improve promString performance

When profiling a large scrape for CPU + Memory, creating this replacer + compiling the regex stood out a lot due to the number of calls to promString. Moving them to package level should help improve this.

Awesome thanks a lot!

Hey @thomaspeitz , happy new year! 🎉
Any chance you can look again at this PR during the week? This has been running in production for a while now and proved useful!

Sorry for the long delay was doing some vacation.
Hope to release it on Thuersday :)

Thanks @thomaspeitz!


bindfs: enable darwin

Motivation for this change
Provide bindfs on macOS
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 115319 run on x86_64-darwin 1

1 package built:

bindfs


Chart: functionality: Climate change vulnerability scrolly

"Scrolly: Climate change vulnerability and readiness:

“Low-income countries are the most at risk from” too much is underlined.
when you scroll back up, the banner covers the title and top of the axis on the graph. It goes when you scroll back down but can be a bit annoying.
You cannot get pop-ups for bubbles underneath other bubbles. Particulalry an issue for China which covers like 8 other countries.  "

@lpicci96 what do you think? Anything to be done or shall we remove this issue (as wontfix)?

@jm-rivera  wontfix but we should revisit the scrollies. I see issues on several pages


Fix invalid frame rate for 29.97, 59.94 and other

When a media files with 29.97fps (or 59.97fps or any frame rate with decimal numbers) is parsed the $absoluteValue for media files with 29.97fps will be 29.970 and the $textValue will be 29.970 (30000/1001) FPS.
The first one would be flattened to number 29 and would lost the precision leading to bugs in applications that would use it. The fix is to cast the value to float value as it was done in version 2.0.

Thanks @piotr-lwks  nice catch, in order to not introduce backward incompatibility changes, I've created a PR to fix this bug, in this PR their is two modifications:

Rate::absoluteValue is now rounded (that fix the problem for 29.999 that rounded to 29 instead of 30)
A new attribute type FloatRate was introduced with method getFloatAbsoluteValue that return float value of attribute.

For more detail see https://github.com/mhor/php-mediainfo/pull/138
In any case, thank you for your contribution :+1:


fix: remove strict pattern on grafanaDependency

Resolves part of:

#279

You can disable specific validations for your plugin via a configuration file as described here https://github.com/grafana/plugin-validator?tab=readme-ov-file#using-a-configuration-file

It is not clear how I can disable this specific check for the grafanaDependency entry.
Until I can, my only other options are to disable this check entirely, or change my version range to something simpler like >=10.4.11 to comply.

Additionally, this file is a fallback for the validator, the validator always fetches the latest schema from the grafana/grafana repository https://github.com/grafana/grafana/blob/ad3fc957558022dc4199a6c060f06bf038c7d7bd/docs/sources/developers/plugins/plugin.schema.json#L

That is definitely a problem here.

Alternatively maybe you can propose an updated regex that covers the condition instead of removing it?

I don't believe a regex is a the best tool for parsing a valid semver version range. It would be difficult (if possible?) to derive an exhaustive pattern that covers all cases, and it would be repetitious and hard to read as a human. I gave it a time-boxed try, and failed to find something satisfactory.
In #279, I suggest an alternative check which makes use of the semver library itself. I don't think that's an option though if we're just checking through the schema.

@academo, I have closed this PR since based on what you said it doesn't disable the pattern (due to it being expressed in grafana/grafana). This is still a unresolved problem for our project. See #279 for more detail.

You can disable specific validations for your plugin via a configuration file as described here https://github.com/grafana/plugin-validator?tab=readme-ov-file#using-a-configuration-file

Looking at the documentation, it is not clear how I can disable this specific check for the grafanaDependency entry. Any help would be appreciated.

Disabling the analyzers seems to be the best solution for our project:
global:
  enabled: true
  severity: warning
  jsonOutput: false
  reportAll: false
analyzers:
  license:
    enabled: false
  # The metadatavalid metadataschema checkers are too strict for our plugin
  # Our grafanaDependency version range is complicated,
  # and our plugin ids have internal dashes.
  metadatavalid:
    enabled: false
  metadataschema:
    enabled: false


Enable caching using memcached

Jira: OSPRH-1524

We might need to improve functional tests to make sure this new dependency is satisfied.
This means we should first get memcached into the environment (suite_test.go):
err = memcachedv1.AddToScheme(scheme.Scheme)
Expect(err).NotTo(HaveOccurred())

Then, in glance_test_data.go we should define the resources used by the *controller related
tests:

const (
	// MemcachedInstance - name of the memcached instance
	MemcachedInstance = "memcached"
)

type GlanceTestData struct {
...
...
MemcachedInstance      string
GlanceMemcached        types.NamespacedName

and later in the same file we can have an instance of the new variables:
GlanceMemcached: types.NamespacedName{
			Namespace: glanceName.Namespace,
			Name:      MemcachedInstance,
		},
...
...
MemcachedInstance:   MemcachedInstance,

At this point in glance_controller_test.go we can add this instance as a prerequisite for the whole test to run.
Basically, w/o memcached glance is not going to work anymore as a standalone component.
I think we can initialize a common Spec for all the test blocks:
var _ = Describe("Glance controller", func() {
	var memcachedSpec memcachedv1.MemcachedSpec

	BeforeEach(func() {
		memcachedSpec = memcachedv1.MemcachedSpec{
			Replicas: ptr.To(int32(3)),
		}
	})
...
...

and finally, for each BeforeEach block, we can have:
DeferCleanup(infra.DeleteMemcached, infra.CreateMemcached(namespace, glanceTest.MemcachedInstance, memcachedSpec))
infra.SimulateMemcachedReady(glanceTest.ManilaMemcached)

Also, the same applies to glanceapi_controller.go.
The above can be slightly different, but it's pretty much what we need to make the functional tests pass (see [1] to have an example).
[1] https://github.com/openstack-k8s-operators/manila-operator/pull/164

I think we need to either find a way to propagate the memcached config to the underlying subCR (via API?) or move the existing controller logic to the glanceapi controller.

Thanks for your help on this. The latest update does this. I confirm now that  glance-config-data does not have the memcached_servers while glance-default-single-config-data (for my testing) does.
I still need to add memcached to the functional test which I'll do in my next update.

We might need to improve functional tests to make sure this new dependency is satisfied.

Thanks for all of your guidance in this. I've added the tests but they're not yet passing. I'll keep debugging tomorrow.
https://github.com/openstack-k8s-operators/glance-operator/compare/f7c145679abbf9ae6424f789083279325d44ea2c..0fb6a4649c1574edc738327bd331be8486664b58

All my functional test errors have a timeout waiting for Informers to sync [1]. I'm going to focus on the following error though since memcached is the only change and the same tests pass if I switch to the main branch in my env.
"failed to get API group resources: unable to retrieve the complete list of server APIs: memcached.openstack.org/v1beta1: the server could not find the requested resource"

[1]
[fultonj@hamfast glance-operator{memcached}]$ make test > log
[fultonj@hamfast glance-operator{memcached}]$ grep ERROR log | awk -F 'T| +' '{print substr($0, index($0, $5))}' | sort  | uniq
after stop sequence was engaged	{"error": "failed to wait for glance caches to sync: cache did not sync"}
get informer from cache	{"error": "failed to get API group resources: unable to retrieve the complete list of server APIs: memcached.openstack.org/v1beta1: the server could not find the requested resource"}
get informer from cache	{"error": "Timeout: failed waiting for *v1beta1.KeystoneEndpoint Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1beta1.KeystoneService Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1beta1.MariaDBAccount Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1beta1.MariaDBDatabase Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1.CronJob Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1.Job Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1.NetworkAttachmentDefinition Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1.PersistentVolumeClaim Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1.RoleBinding Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1.Role Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1.Secret Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1.ServiceAccount Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1.Service Informer to sync"}
get informer from cache	{"error": "Timeout: failed waiting for *v1.StatefulSet Informer to sync"}
wait for Cache to sync	{"controller": "glance", "controllerGroup": "glance.openstack.org", "controllerKind": "Glance", "error": "failed to wait for glance caches to sync: cache did not sync"}
[fultonj@hamfast glance-operator{memcached}]$

All my functional test errors have a timeout waiting for Informers to sync

This is now resolved.


Registered key-value will not be included in the configuration

For dynamic refresh, user can register some keyvalues as watchedSettings. The provider will monitor whether the watchedSettings are changed, if so, the provider will refresh all keyvalue it loaded. But the JS provider will only include keyvalues which selected by selector. The watchedSettings will not be included in the configuration provided by the provider.
This behavior is inconsistent with .NET provider. The screenshot below shows the .NET provider's behavior.

It's by design. IMO the sentinel should not be included into configuration if it's not covered by any selector. I remember it has been discussed in the design review.
/cc @zhenlan to confirm that.

I understand this behavior is different from .NET, but I also remember this has been discussed in a design review. I don't remember the exact reason. Is it consistent with our providers for python and k8s?


Private repository pull failed

Hello, I'm using private repository to store docker images. I have setup cluster also providing docker cfg. When starting pods I receive:
myservice registry.my.com/user/myservice Waiting image pull failed for registry.my.com/user/myservice, this may be because there are no credentials on this request. details: (Authentication is required.)
However, I'm able to pull these images directly with docker on master and node.

Please share actual logs.

Not sure which one..?
docker events only shows gcr.io/google_containers/pause:0.8.0 image container being created and started, which itself does not log anything.
There is no sign of myservice image pulling and starting..

Where did you see the errors you described above?

Same issue here. It started today after I updated. Using on Windows through Vagrant. Probably got new versions of your code and new CoreOS (681.0.0) at the same time.
After doing successful docker login, I have copied the .dockercfg from /home/core to / and /root and /var/lib/kubelet. Nothing seems to help. When I ssh to node and do docker pull, it works.
Some logs from node's journalctl
May 19 13:40:33 node-01 dockerd[5649]: time="2015-05-19T13:40:33Z" level=info msg="GET /images/ent.changed.com:5000/firewall:latest/json"
May 19 13:40:33 node-01 dockerd[5649]: time="2015-05-19T13:40:33Z" level=info msg="+job image_inspect(ent.changed.com:5000/firewall:latest)"
May 19 13:40:33 node-01 dockerd[5649]: No such image: ent.changed.com:5000/firewall:latest
May 19 13:40:33 node-01 dockerd[5649]: time="2015-05-19T13:40:33Z" level=info msg="-job image_inspect(ent.changed.com:5000/firewall:latest) = ERR (1)"
May 19 13:40:33 node-01 dockerd[5649]: time="2015-05-19T13:40:33Z" level=error msg="Handler for GET /images/{name:.*}/json returned error: No such image: ent.changed.com:5000/firewall:latest"
May 19 13:40:33 node-01 dockerd[5649]: time="2015-05-19T13:40:33Z" level=error msg="HTTP Error: statusCode=404 No such image: ent.changed.com:5000/firewall:latest"
May 19 13:40:33 node-01 kubelet[1442]: E0519 13:40:33.144374    1442 kubelet.go:1767] Cannot get host IP: host IP unknown; known addresses: []
May 19 13:40:33 node-01 dockerd[5649]: time="2015-05-19T13:40:33Z" level=info msg="GET /containers/json"
May 19 13:40:33 node-01 dockerd[5649]: time="2015-05-19T13:40:33Z" level=info msg="+job containers()"
May 19 13:40:33 node-01 dockerd[5649]: time="2015-05-19T13:40:33Z" level=info msg="-job containers() = OK (0)"
May 19 13:40:33 node-01 dockerd[5649]: time="2015-05-19T13:40:33Z" level=info msg="GET /containers/json"
'kubectl get events' does not have much:
Tue, 19 May 2015 13:34:02 +0000   Tue, 19 May 2015 13:48:34 +0000   88        firewall-scqcn          Pod       spec.containers{firewall}           failed    {kubelet <IP_ADDRESS>}   Failed to pull image "ent.changed.com:5000/firewall:latest": Authentication is required.

More logs from node's journalctl.
May 19 13:53:05 node-01 dockerd[5649]: time="2015-05-19T13:53:05Z" level=info msg="-job pull(ent.changed.com:5000/firewall, latest) = ERR (1)"
May 19 13:53:05 node-01 kubelet[1442]: W0519 13:53:05.378777    1442 manager.go:1403] Failed to pull image "ent.changed.com:5000/firewall:latest" from pod "firewall-scqcn_default" and container "firewall": Authentication is required.
May 19 13:53:05 node-01 kubelet[1442]: I0519 13:53:05.378766    1442 event.go:203] Event(api.ObjectReference{Kind:"Pod", Namespace:"default", Name:"firewall-scqcn", UID:"0bf84892-fe1e-11e4-822d-0800270db324", APIVersion:"v1beta3", ResourceVersion:"32722", FieldPath:"spec.containers{firewall}"}): reason: 'failed' Failed to pull image "ent.changed.com:5000/firewall:latest": Authentication is required.

Please see https://github.com/GoogleCloudPlatform/kubernetes/issues/7954

@janroos I've had issues with something like this before, and in the end it wasn't related to docker stuff at all but rather the kubelet not being able to read .dockercfg. I've just merged @AntonioMeireles 93cebf8 hoping to fix it. Can you please retry with it and let us know?

Thanks Pires! Tried but unfortunately it did not help. The .dockercfg gets copied from host to /home/core and to /root.
Works when I manually do docker pull or sudo docker pull

For others that are struggling with this. Here's my current workaround:
Run this on all nodes:
journalctl | grep -o 'Failed to pull image "[^"]*' | grep -o ent.ch**|sort -u|xargs -L1 docker pull
sudo systemctl restart docker
Explanation:
It greps the logs for errors pulling from private registry (in my case registry address starting with "ent.ch"), filters out duplicates and then runs docker pull for each missing image.
After this I restart docker daemon - so it starts to re-deploy immediately.

This is something with the kubelet. Can you please share logs?

Maybe worth to note here is that I am using self-signed certificate. Here's how I install it on every coreos host:
cp self-signed.pem /etc/ssl/certs/
sudo update-ca-certificates
sudo systemctl restart docker
After this was done, I ran on master:
kubectl create -f firewall-controller.yaml
This is the whole log of a node.
https://dl.dropboxusercontent.com/u/57064515/node.log
Search for "firewall"

May 21 08:40:44 node-01 dockerd[5595]: time="2015-05-21T08:40:44Z" level=info msg="-job image_inspect(ent.coolbet.com:5000/firewall) = ERR (1)"
May 21 08:40:44 node-01 dockerd[5595]: time="2015-05-21T08:40:44Z" level=error msg="Handler for GET /images/{name:.*}/json returned error: No such image: ent.coolbet.com:5000/firewall"
May 21 08:40:44 node-01 dockerd[5595]: time="2015-05-21T08:40:44Z" level=error msg="HTTP Error: statusCode=404 No such image: ent.coolbet.com:5000/firewall"

This is it. I've seen this before and @erictune at the time told me what it was - IIRC something with the kubelet. I will try and hunt for what fixed it.

Maybe this is a hint: http://ask.projectatomic.io/en/question/179/authenticating-kubernetes-for-private-images-on-docker-hub/
according to the reply, the .dockercfg has to be in the working directory of kubelet.
To get the cwd I executed on a node:
core@node-02 ~ $ sudo ls -ld /proc/$(pidof kubelet)/cwd
lrwxrwxrwx 1 root root 0 Jun  1 13:18 /proc/999/cwd -> /

so it`s the root.
see #108 for an example kubelet config. With changing the working directory of the kubelet, the kubelet is able to pull private repositories when authenticated with .dockercfg.

For people who still have a problem with this, try adding https:// to your .dockercfg. I found this to work for me:
{
	"hub.example.com:1024": {
		"auth": "asdf=",
		"email"<EMAIL_ADDRESS>	},
	"https://hub.example.com:1024": {
		"auth": "asdf=",
		"email"<EMAIL_ADDRESS>	}
}

Without the https block, I was logged in from console (core user), but kubelet would throw auth errors (even when the .dockercfg file in its working directory, /root/, exists and is readable).

@analytik would you be so kind and provide a PR with an update to README.md with your conclusion in the Troubleshooting section?

Or put it in: the "Configuring Nodes to Authenticate to a Private Registry"
section of "docs/images.md".
On Thu, Jun 25, 2015 at 8:27 AM, Paulo Pires<EMAIL_ADDRESS>wrote:

@analytik https://github.com/analytik would you be so kind and provide
a PR with an update to README.md with your conclusion in the
Troubleshooting section?
—
Reply to this email directly or view it on GitHub
https://github.com/pires/kubernetes-vagrant-coreos-cluster/issues/97#issuecomment-115292843
.


Test-Json ignores if else statement in json-schema

Issue: Test-Json scripts overlooks/ ignores "if then else" conditions in json schema for attribute checks.
Steps to reproduce
Json schema:
{
    "$schema": "http://json-schema.org/draft-07/schema#",
    "$id": "http://example.com/example.json",
    "type": "object",
    "title": "The root schema",
    "description": "The root schema comprises the entire JSON document.",
    "required": [
        "sqlConfig"
    ],
    "properties": {
        "sqlConfig": {
            "$id": "#/properties/sqlConfig",
            "type": "array",
            "title": "The sqlConfig schema",
            "description": "Contains sql configuration information",
            "uniqueItems": true,
            "additionalItems": true,
            "items": {
                "$id": "#/properties/sqlConfig/items",
                "anyOf": [
                    {
                        "$id": "#/properties/sqlConfig/items/anyOf/0",
                        "type": "object",
                        "title": "The first anyOf schema",
                        "description": "SQL properties",
                        "if": {
                            "properties": {
                                "family": {
                                    "pattern": "^(?i)(azuresql)$"
                                }
                            }
                        },
                        "then": {
                            "required": [
                                "sku",
                                "family",
                                "type",
                                "keyvault",
                                "serverName",
                                "administratorLogin"
                            ]
                        },
                        "else": {
                            "required": [
                                "sku",
                                "family",
                                "keyvault",
                                "serverName",
                                "administratorLogin"
                            ]
                        },
                        "properties": {
                            "sku": {
                                "$id": "#/properties/sqlConfig/items/anyOf/0/properties/sku",
                                "type": "object",
                                "title": "The sku schema",
                                "description": "database sku",
                                "required": [
                                    "capacity",
                                    "name"
                                ],
                                "properties": {
                                    "capacity": {
                                        "$id": "#/properties/sqlConfig/items/anyOf/0/properties/sku/properties/capacity",
                                        "type": "integer",
                                        "title": "capacity",
                                        "description": " # In Vcores for GP, BC, HS. In DTU for others."
                                    },
                                    "name": {
                                        "$id": "#/properties/sqlConfig/items/anyOf/0/properties/sku/properties/name",
                                        "type": "string",
                                        "title": "sku service objective name",
                                        "description": "ServiceObjectiveName - Get-AzSqlServerServiceObjective -Location <location>"
                                    }
                                },
                                "additionalProperties": false
                            },
                            "family": {
                                "$id": "#/properties/sqlConfig/items/anyOf/0/properties/family",
                                "type": "string",
                                "title": "database family",
                                "pattern": "^(?i)(azuresql|postgresql|mariadb|mysql)$",
                                "description": "type of database server"
                            },
                            "firewallRules": {
                                "$id": "#/properties/sqlConfig/items/anyOf/0/properties/firewallRules",
                                "type": "array",
                                "title": "The firewallRules schema",
                                "description": "firewall rules for the database",
                                "uniqueItems": true,
                                "additionalItems": true,
                                "items": {
                                    "$id": "#/properties/sqlConfig/items/anyOf/0/properties/firewallRules/items",
                                    "anyOf": [
                                        {
                                            "$id": "#/properties/sqlConfig/items/anyOf/0/properties/firewallRules/items/anyOf/0",
                                            "type": "object",
                                            "title": "The first anyOf schema",
                                            "description": "An explanation about the purpose of this instance.",
                                            "required": [
                                                "endIpAddress",
                                                "startIpAddress"
                                            ],
                                            "properties": {
                                                "endIpAddress": {
                                                    "$id": "#/properties/sqlConfig/items/anyOf/0/properties/firewallRules/items/anyOf/0/properties/endIpAddress",
                                                    "type": "string",
                                                    "format": "ipv4",
                                                    "title": "The endIpAddress schema",
                                                    "description": "An explanation about the purpose of this instance."
                                                },
                                                "startIpAddress": {
                                                    "$id": "#/properties/sqlConfig/items/anyOf/0/properties/firewallRules/items/anyOf/0/properties/startIpAddress",
                                                    "type": "string",
                                                    "format": "ipv4",
                                                    "title": "The startIpAddress schema",
                                                    "description": "An explanation about the purpose of this instance."
                                                }
                                            },
                                            "additionalProperties": false
                                        }
                                    ]
                                }
                            },
                            "keyvault": {
                                "$id": "#/properties/sqlConfig/items/anyOf/0/properties/keyvault",
                                "type": "object",
                                "title": "The keyvault schema",
                                "description": "An explanation about the purpose of this instance.",
                                "required": [
                                    "serviceTag",
                                    "passwordsecretName"
                                ],
                                "properties": {
                                    "serviceTag": {
                                        "$id": "#/properties/sqlConfig/items/anyOf/0/properties/keyvault/properties/serviceTag",
                                        "type": "string",
                                        "title": "The serviceTag schema",
                                        "description": "An explanation about the purpose of this instance."
                                    },
                                    "passwordsecretName": {
                                        "$id": "#/properties/sqlConfig/items/anyOf/0/properties/keyvault/properties/passwordsecretName",
                                        "type": "string",
                                        "title": "The passwordsecretName schema",
                                        "description": "An explanation about the purpose of this instance."
                                    }
                                },
                                "additionalProperties": false
                            },
                            "serverName": {
                                "$id": "#/properties/sqlConfig/items/anyOf/0/properties/serverName",
                                "type": "string",
                                "title": "The serverName schema",
                                "description": "An explanation about the purpose of this instance."
                            },
                            "databaseNames": {
                                "$id": "#/properties/sqlConfig/items/anyOf/0/properties/databaseNames",
                                "type": "array",
                                "title": "The databaseNames schema",
                                "description": "An explanation about the purpose of this instance.",
                                "uniqueItems": true,
                                "additionalItems": true,
                                "items": {
                                    "$id": "#/properties/sqlConfig/items/anyOf/0/properties/databaseNames/items",
                                    "anyOf": [
                                        {
                                            "$id": "#/properties/sqlConfig/items/anyOf/0/properties/databaseNames/items/anyOf/0",
                                            "type": "string",
                                            "title": "The first anyOf schema",
                                            "description": "An explanation about the purpose of this instance."
                                        }
                                    ]
                                }
                            },
                            "type": {
                                "$id": "#/properties/sqlConfig/items/anyOf/0/properties/type",
                                "type": "string",
                                "title": "The type schema",
                                "description": "An explanation about the purpose of this instance."
                            },
                            "administratorLogin": {
                                "$id": "#/properties/sqlConfig/items/anyOf/0/properties/administratorLogin",
                                "type": "string",
                                "title": "The administratorLogin schema",
                                "description": "An explanation about the purpose of this instance."
                            }
                        },
                        "additionalProperties": false
                    }
                ]
            }
        }
    },
    "additionalProperties": false
}

Json file:
{
  "sqlConfig": [
    {
      "keyvault": {
        "passwordsecretName": "databasepassword",
        "serviceTag": "kvaultcorerg"
      },
      "sku": {
        "name": "free",
        "capacity": 5
      },
      "administratorLogin": "databaseowner",
      "serverName": "commonserver"
    }
  ]
}

Imported above files and ran a test against json file.
The output is true that JSON matches SCHEMA but expectation with test is to fail as FAMILY and TYPE are missing.

  PS > $schema = Get-Content -raw $SchemaFile
  PS > $json | Test-Json -Schema $schema -Verbose
  True

Expected behavior
FALSE.
Required properties are missing from object: family, type.

Actual behavior

If else validation is overlooked. It doesn't look at anything "required" and everything passed. Ideally it should fail because family and type are missing.

if do same validation through other validation tools, i get correct response.

Environment data
PS> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.0.0
PSEdition                      Core
GitCommitId                    7.0.0
OS                             Linux 5.3.0-1035-azure #36-Ubuntu SMP Thu Aug 6 09:21:33 UTC 2020
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

/cc @iSazonov

I guess it is NJsonSchema issue and it is better to open new issue there.

any chance of changing the library to Newtonsoft.Json.Schema?

License of the library doesn't allow.

The JSON Schema implementation has been recently updated to JsonSchema.Net and is available in the latest Powershell snapshot.  Please retest this to see if it is still a problem.


Is the implementation of channels planned?

Now only groups are displayed

Thanks a lot @robvanderleek , I will try to get Baileys to add the feature


modal / agreement text should look nicer

Right now the shown text is basically suitable for copy pasting, but not much else.
To review it also in this format, it would be nicer to display it differently.

You mean https://github.com/contributoragreements/ca-cla-chooser/tree/main/agreement_texts ?
Or something else?
One issue that I think we need to address is that in general people do not sign CLAs on paper anymore, so we should support a more digital and potentially bot/CI-driven way of signing and collecting.
If that is out of scope of this issue, let me know and I’ll open a new one.


fw_update: refactor download_and_write_flash() to simplify and reduce variables

A series of commits to simplify the logic in golioth_fw_update.c:download_and_write_flash(), in preparation for adding an OTA delta feature in the near future, and to address this comment about there being too many variables to keep track of in download_and_write_flash.
This series of commits does not change the observable behavior of download_and_write_flash(), and thus can be considered a "refactor" of the internal implementation of that function.
The primary structural change introduced in this sequence of commits is to split the processing of individual OTA blocks into three separate stages, where the output of one stage is connected to the input of the next stage via function pointer:
download() -> decompress() -> handle_block()

This decouples the individual processing stages from each other, and makes it easy to insert a new patch stage in future commits, as part of the OTA delta feature implementation.

Thanks a lot of this refactoring, it is in much better shape now. The fact that all the processing stages are separate now makes this code much easier to read and understand. As a side effect we are really close to supporting decompression of any type of artifacts/blobs downloaded from Golioth cloud, not just FW artifacts. The only comment I have right now is about the name of the file golioth_block_processor.c to make it clear it is FW related (still at this point). Otherwise LGTM!


Proxy port issue

I am testing ILEvator right now, and something goes wrong with the determination of the port of the proxy.
My proxyserver is proxy.abc.local:8080,  but the iv_url_parse stores 80 in url.port, because no proxy is determined.

Would the correct way to fix this not be to introduce a proxy_url, equal to url, and store all proxy related information in there? Then use it when use of a proxy is enabled, instead of copying url back and forth? - When using a proxy, it still has to be handed the correct content of url anyway.

I 100% agree -  however, the current implementation has "forgotten" to reimplement the "opaque" proxy feature ( opposite the transparent CONNECT that works great) while converting the code from C to RPGLE. I am looking at it right now ...

Proxy support was not on the list of planned features, see #1 .


Use group forces

The code for now comments out 4 lines for group forces in 'simulater.cpp', and also these forces are not accumulated to the force vector when computing the final force.Since I want to observe the group formation with these forces enabled, so I wonder is there a easy way to use these forces?

Yes and yes. The commented out sections were side effects of debugging, The forces are always computed as long as grouping is enabled


Fix ballerina test remote debugging support [master]

Purpose

Fixes #22471.
Adds minor debug adapter fix related to stack frame mappings.

Reamarks
Related PR - #22500.
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[x] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #22669 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22669   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd74066...1f662a3. Read the comment docs.


The dimension about the Av and Ao

Hello, it's very kind and excellent of you to share your work! The logic of this article is very clear, but as a green-hand, I am confused about the Nv and No in Av and Ao. The Nv and No are the numbers of verbs and objects about which dataset or things else? Looking forward to your answer~ ^_^

Hi, N_v and N_o are the numbers of verb categories and object categories respectively. For example, on HICO-DET, N_v is 117 and N_o is 80. A_v is the verb-HOI co-occurrence matrix and A_o is the object-HOI co-occurrence matrix. You can see this line of the code: https://github.com/zhihou7/HOI-CL/blob/7d2b55947f8e5a75d32345508f70c929c8d4e8d1/lib/networks/tools.py#L88
For example, if the i HOI category is composed by verb j and object k, we have A_v[j][i] == 1 and A_o[k][I] == 1.
Regards,

Thanks! I am also confused that lo is the label of an object,  is it also an one-hot label? But what is the label dimension for a new object?  y = (loAo)&(lvAv), so the lo should be 1*80, but the new object is not in HOI's obj_class.

    Sorry to bother you again. In "Visual Compositional Learning for Human-Object Interaction Detection", according to my own understanding, I calculated according to equation (1) and (2), but it seems that only the composited HOIs which have appeared in the list of datasets' HOIs will be valid. For example, if the composited HOI is 'play basketball', it will be valid only when there is an annotation of 'play basketball' in the list of datasets' HOIs. But if there has 'play baseball' in the datasets' annotations, and there is no 'play basketball',  the composited HOI of 'play basketball' will be invalid, right? Could you please tell me about it in detail? Thank you very much !
------------------ 原始邮件 ------------------
发件人:                                                                                "zhihou7/HOI-CL"                                                                                @.>;
发送时间: 2021年5月24日(星期一) 下午3:12
@.>;
<EMAIL_ADDRESS>主题: Re: [zhihou7/HOI-CL] The dimension about the Av and Ao (#4)
Hi, N_v and N_o are the numbers of verb categories and object categories respectively. For example, on HICO-DET, N_v is 117 and N_o is 80. A_v is the verb-HOI co-occurrence matrix and A_o is the object-HOI co-occurrence matrix. You can see this line of the code: https://github.com/zhihou7/HOI-CL/blob/7d2b55947f8e5a75d32345508f70c929c8d4e8d1/lib/networks/tools.py#L88
For example, if the i HOI category is composed by verb j and object k, we have A_v[j][i] == 1 and A_o[k][I] == 1.
Regards,
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks! I am also confused that lo is the label of an object, is it also an one-hot label? But what is the label dimension for a new object? y = (loAo)&(lvAv), so the lo should be 1*80, but the new object is not in HOI's obj_class.

Currently, we only consider the objects whose categories are the same or a subset of object categories of HOI dataset.

Thanks! I am also confused that lo is the label of an object, is it also an one-hot label? But what is the label dimension for a new object? y = (loAo)&(lvAv), so the lo should be 1*80, but the new object is not in HOI's obj_class.

Currently, we only consider the objects whose categories are the same or a subset of object categories of HOI dataset.

Yes, it is right. Thanks for your nice question.
However, you can simply set the co-occurrence matrix by hand to enable the composite HOI of 'play basketball'. Then, the model can learn 'play basketball' although there are no 'play basketball' instance in HICO-DET.
regards,

thank you^-^
---Original---
From: @.>
Date: Wed, May 26, 2021 22:15 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [zhihou7/HOI-CL] The dimension about the Av and Ao (#4)
Yes, it is right. Thanks for your nice question!
However, you can simply set the co-occurrence matrix by hand to enable the composite HOI of 'play basketball'. Then, the model can learn 'play basketball' although there are no 'play basketball' instance in HICO-DET.
regards,
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes, it is right. Thanks for your nice question!
However, you can simply set the co-occurrence matrix by hand to enable the composite HOI of 'play basketball'. Then, the model can learn 'play basketball' although there are no 'play basketball' instance in HICO-DET. Well, I guess this also answer your question about composing HOIs with novel types of objects. In fact, our next work also address your problem. we'll release it once it is accepted.
regards,

Hi! How can I set the co-occurrence matrix?

hi @rouge012, the co-occurrence matrix $A\in R^{N_v \times N_o} $ is a two dimension matrix, where Nv indicates the length of verb categories and No indicate the length of object categories. We can initialize A as a zero matrix. For each object, there are annotated verbs. We can set the corresponding position of the matrix A as 1. For each example, if the apple is combinable with "eat", "cut" in the dataset, we set corresponding position of and in A as 1.
Feel free to post if you have further questions
Regards,

Thanks for the quick and detailed clarification, and I am wondering where I can find the code for setting the co-occurrence matrix. Thank you!

Hi @rouge012,
I have posted in #25. If you need to generate a matrix by yourself, you can just open the three files "https://github.com/zhihou7/HOI-CL/blob/master/misc/hico_list_hoi.txt", "https://github.com/zhihou7/HOI-CL/blob/master/misc/hico_list_obj.txt", "https://github.com/zhihou7/HOI-CL/blob/master/misc/hico_list_vb.txt", and link them together according to the object name and verb name. I think it requires just several lines of code.


Update needed for Starscream from 4.0.4 to latest

When using Socket.IO-Client for iOS, the StarscreamAdapter+Delegate files, didReceive methods enum has updated and throws an error to add the .peerClosed case. Without this enum case added it fails and can't be fixed. I see the starscream package is set to exactly 4.0.4, as of this ticket 4.0.6 is latest, this should either be set regularly or next minor etc.

a


Test

final test

Deployment started for this pull request.

Deployment successful. Deployed application.

Deployment started for this pull request.

Deployment successful. Deployed application.


Verison updates + SQL query copy

Codecov Report

Merging #46 (0c507db) into main (4a8b6e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 0c507db differs from pull request most recent head 650cc19. Consider uploading reports for the commit 650cc19 to get more accurate results

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   97.07%   97.07%
=======================================
  Files          29       29
  Lines        1912     1916    +4
=======================================
+ Hits         1856     1860    +4
  Misses         56       56

Flag
Coverage Δ

pytest
97.07% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...mes/applied_function/applied_function_tds_frame.py
92.85% <100.00%> (+0.54%)
:arrow_up:

.../core/tds/frames/applied_function/head_function.py
95.45% <100.00%> (+0.21%)
:arrow_up:


SmartBFT

Hyperledger Fabric is an enterprise-grade, permissioned distributed ledger platform that offers modularity for a broad set of industry use cases. One modular component is a pluggable ordering service that establishes consensus on the order of transactions and batches them into blocks. This proposal suggests integrating the SmartBFT consensus library into Hyperledger Labs to enhance its blockchain frameworks with a robust, scalable, and resilient consensus mechanism designed for practical BFT deployment.
This lab provides a BFT consensus library based on the BFTSmart protocol and written in Go. The library is tailored to the blockchain use case yet general enough to cater to a wide variety of other uses. The BFT library's design and integration into Fabric address crucial aspects that were left unsolved in all prior work, making it unfit for production use.

@hyperledger-labs/lab-stewards Ideally I would be happy to see this library as Fabric subproject, aka fabric-smartbft, but IMO starting with Labs, is a right path to pull this project under Hyperledger governance processes.
I am all for moving this consensus library into Labs, given it's project agnostic design hopefully others might also consider using it as well. Anyway, this library is going to be a part of the Fabric 3.0 milestone, hence IMO we should accept it.
Hopefully other Fabric maintainers will also support it (@denyeart, @yacovm, @cendhu).

I support it. Make sure you move the repo as-is and preserve the git commit history :-)

I support it. Make sure you move the repo as-is and preserve the git commit history :-)

Guess this is something we need to ask from @ryjones

@yacovm @C0rWin when the lab is approved, we can walk through the transfer process. it's easy.

I support this proposal as well!

shall we get this one merged? or have to wait for more approvals? @tkuhrt @denyeart

@ryjones what are the next steps?

@pfi79 create an issue here to transfer a repo, then send it to me, ryjones and I will put it in labs. thanks

@ryjones https://github.com/hyperledger-labs/governance/issues/45


Handle Markdown Frontmatter in File Explorer Preview

Summary of the new feature/enhancement
In the current (v0.18.1) version of File Explorer Preview, Markdown files with frontmatter are not displayed correctly. The frontmatter is rendered like normal markdown which is not always helpful. It would be better to recognize Markdown files that have a frontmatter block at the top and handle rendering it differently. The image below demonstrates the issue.

I believe either hiding the frontmatter or displaying it without Markdown rendering would be an improvement to the Preview.
Proposed technical implementation details
Frontmatter in a Markdown document contains metadata about the document as a whole. For example, in a blog post the frontmatter could contain the post title, publish date, etc. A frontmatter block is a set of key/value pairs set off by --- above and below (which is also Markdown syntax for a horizontal rule). An example of Markdown frontmatter can be seen in the image below.
There are a couple of different ways other tools handle Markdown frontmatter; I don't know which fits the vision of the product better. The Markdown preview in VS Code just omits rendering frontmatter altogether. In GitHub, frontmatter it turned into a table display, which can get unweildly for files with a lot of frontmatter.

I think that even just displaying it as a code block at the top would help - in the current Preview, all of the text gets crammed together into one block as shown in the first image.

@sweenr  can you provide some valid frontmatter syntax via a code block or a zip file.  Wonder if github can render it.

@crutkas, I published it in a minimal repo here to show how Github renders it now:
https://github.com/sweenr/markdown-sample/blob/master/Sample.md
I see that Github seems to render if differently now that it did when I posted this enhancement. It renders closer to my second suggestion of showing a code block at the top that contains the frontmatter contents.
Let me know if there's anything else I can do to help!

feature ask for the MD engine we which looks to support this.

if we do this, can easily do looks like #5405 as well

With Markdig enabled processing for it, it renders like VS Code style.

Fixed in 0.23 of PowerToys.  https://github.com/microsoft/PowerToys/releases/


fix(flannel): use default iface for starting flannel except vagrant

fixes #4217

LGTM. I tested and verified this fixes things on GCE and works on vagrant.

I tested and verified this fixes things on GCE and works on vagrant.

Thanks @mboersma. Once this passes, I'm good to merge. Code LGTM.

btw this approach - quay.io/coreos/flannel:${FLANNEL_VER} /opt/bin/flanneld --ip-masq=true did not help on GCE

did not help on GCE

Can you elaborate on what you're seeing? Is it a specific error?

@carmstrong  Need to provision a new testing cluster and check errors

right now even etcd does not start with that small flannel fix, tried latest stable, beta and alpha versions, still the same problem

@rimusz I provisioned from master + this PR and followed our docs to install coreos-stable-647-2-0-v20150528 on GCE. I didn't see any problems and got Deis installed and working with deisctl. I'm doing some other tests right now but I'll try GCE again in a bit and see if I can reproduce what you ran into.

@mboersma I did use the latest versions of coreos

that's crazy, provisioned (fresh pull) from master + this PR and it did work this time

and it did work this time

Well, that's good to confirm! Thank you!

@mboersma Are you good to ship?

:SHIP:


sink(ticdc): turn off multi statement sql by default

What problem does this PR solve?

Issue Number: close #8622
What is changed and how it works?
Turn off multi statement sql, we need to locate the large packet problem.
Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/run-all-tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-7.0@bb4d4f2). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 1df81d5 differs from pull request most recent head f473b11. Consider uploading reports for the commit f473b11 to get more accurate results

Additional details and impacted files

Flag
Coverage Δ

cdc
66.6751% <0.0000%> (?)

dm
56.0335% <0.0000%> (?)

engine
66.7498% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             release-7.0      #8652   +/-   ##
================================================
  Coverage               ?   61.9385%
================================================
  Files                  ?       1033
  Lines                  ?     139690
  Branches               ?          0
================================================
  Hits                   ?      86522
  Misses                 ?      45908
  Partials               ?       7260

/merge


DEAD REPO ? NEED HELP / NEW MAINTAINERS ?

Seems that this excelent tool with not so much alternatives but very famous is not working any more on many edge cases because it it outdated (dependencies / LE CA etc ...)
The beauty of open source is that we can help and make this work. Do you need any help with the project ? PRs (7 unmerged so far) ? Maintenainers ?
Sorry if that sound rough but i do want to see this tool updated and worked again. Even Mirantis Lens with it's included port-forwarding is not so easy to use.

It`s a shame ... such a beauty no maintenance =/
I test with the latest active LTS Version and a hard reset at this time , fingers cross !
But looks nearly like a fresh start would be better ;D
`

npm install --legacy-peer-deps
npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm WARN deprecated<EMAIL_ADDRESS>standard 16.0.0 and eslint-config-standard 16.0.0 no longer require the eslint-plugin-standard package. You can remove it from your dependencies with 'npm rm eslint-plugin-standard'. More info here: https://github.com/standard/standard/issues/1316
npm WARN deprecated<EMAIL_ADDRESS>This loader has been deprecated. Please use eslint-webpack-plugin
npm WARN deprecated<EMAIL_ADDRESS>babili has been renamed to babel-minify. Please update to babel-preset-minify
npm WARN deprecated<EMAIL_ADDRESS>babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
npm WARN deprecated<EMAIL_ADDRESS>Support has ended for 9.x series. Upgrade to @latest
npm WARN deprecated<EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.

added 1772 packages, and audited 1773 packages in 3m
184 packages are looking for funding
run npm fund for details
10 vulnerabilities (3 low, 5 moderate, 2 critical)
To address issues that do not require attention, run:
npm audit fix
Some issues need review, and may require choosing
a different dependency.
Run npm audit for details.
`

I'd like to help maintain

JFTY, we are discussing this in another thread and I opened a PR updating overall dependencies here, it’s working with node 22 and pnpm
https://github.com/pixel-point/kube-forwarder/pull/108

@hcavarsan thank you putting effort in maintaining this great project ! Would be pleased to test your fork if needed !
We can close this issue then

closed in favor of #100


Wrong color for solarized light theme

VSCode Version: Code 1.11.0 (9122ec4b1068bd391e41974f46a4b54c1b9c90f9, 2017-04-05T20:52:01.201Z)
OS Version: Darwin x64 16.5.0
Extensions:

Extension
Author
Version

python
donjayamanne
0.6.0

cpptools
ms-vscode
0.10.5

csharp
ms-vscode
1.8.1

Steps to Reproduce:

The solarized light theme has a color for selection that's too dark. Was a different color before update.

Possibly related to #24040

@justinchuby Do you mean the light or the dark theme? Please correct either the issue title or the description.

@aeschli It should be the light theme. Sorry about that.

duplicate of #24040


[GOLANG]Can not import the compiled binary package gotvm.a in Golang with version > 1.12

Hi,
I am using TVM Golang API for neural model inference. However, I can not import the compiled binary package gotvm.a in my code. The environment information as follows:

Golang 1.14.6
Ubuntu 18.04/amd64

Thanks for notifying this issue. I will  try to spend some time to upgrade golang version.
You are most welcome to contribute, if you are already progressing with upgrade.

ping @srkreddy1238


Improve governance docs

          @miggland we aim to keep the bugfix branches stable and add new stuff only to stable - that needs to be documented better for sure.

Originally posted by @matmair in https://github.com/inventree/InvenTree/issues/4898#issuecomment-1563334904

Turns out that is already in the docs https://github.com/inventree/InvenTree/blob/master/CONTRIBUTING.md#bugfix-branches


Issue with    nginx-ingress-controller-65455699d5-7whpd   0/1       CrashLoopBackOff

Hello I have an issue with nginx-ingress-controller is getting crash-loop-backoff...
I have used below commands to install this..
from below link  have used to create my ingress-controller,,....
https://github.com/kubernetes/ingress-nginx/blob/master/deploy/README.md#mandatory-commands
curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/namespace.yaml
| kubectl apply -f -
curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/default-backend.yaml
| kubectl apply -f -
curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/configmap.yaml
| kubectl apply -f -
curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/tcp-services-configmap.yaml
| kubectl apply -f -
curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/udp-services-configmap.yaml
| kubectl apply -f -
Install without RBAC roles
curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/without-rbac.yaml
| kubectl apply -f -
but my backend service is running..... I have used kubernetes 1.8 version.

If your service is not running, check this for debugging : https://kubernetes.io/docs/tasks/debug-application-cluster/debug-service/
If service is running but you pods seems not, check this for debugging:

https://kubernetes.io/docs/tasks/debug-application-cluster/debug-application-introspection/
https://kubernetes.io/docs/tasks/debug-application-cluster/debug-pod-replication-controller/
https://kubernetes.io/docs/tasks/debug-application-cluster/determine-reason-pod-failure/

It doesn't look like your report is a documentation issue. So closing ...

I tried but it doesn't work...
I will show my ingress-controller yaml file can u check and please tell me error if u fin
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
annotations:
deployment.kubernetes.io/revision: "7"
creationTimestamp: 2017-11-11T23:29:01Z
generation: 7
labels:
app: ingress-nginx
name: nginx-ingress-controller
namespace: ingress-nginx
resourceVersion: "792711"
selfLink: /apis/extensions/v1beta1/namespaces/ingress-nginx/deployments/nginx-ingress-controller
uid: 19861249-c738-11e7-867e-005056bf5570
spec:
replicas: 1
selector:
matchLabels:
app: ingress-nginx
strategy:
rollingUpdate:
maxSurge: 1
maxUnavailable: 1
type: RollingUpdate
template:
metadata:
annotations:
prometheus.io/port: "10254"
prometheus.io/scrape: "true"
creationTimestamp: null
labels:
app: ingress-nginx
spec:
containers:
- args:
- /nginx-ingress-controller
- --default-backend-service=$(POD_NAMESPACE)/default-http-backend
- --configmap=$(POD_NAMESPACE)/nginx-configuration
- --tcp-services-configmap=$(POD_NAMESPACE)/tcp-services
- --udp-services-configmap=$(POD_NAMESPACE)/udp-services
env:
- name: POD_NAME
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: metadata.name
- name: POD_NAMESPACE
valueFrom:
fieldRef:
apiVersion: v1
fieldPath: metadata.namespace
image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.9.0-beta.17
imagePullPolicy: IfNotPresent
livenessProbe:
failureThreshold: 3
httpGet:
path: /healthz
port: 10254
scheme: HTTP
initialDelaySeconds: 10
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
name: nginx-ingress-controller
ports:
- containerPort: 80
name: http
protocol: TCP
- containerPort: 443
name: https
protocol: TCP
readinessProbe:
failureThreshold: 3
httpGet:
path: /healthz
port: 10254
scheme: HTTP
periodSeconds: 10
successThreshold: 1
timeoutSeconds: 1
resources: {}
terminationMessagePath: /dev/termination-log
terminationMessagePolicy: File
dnsPolicy: ClusterFirst
restartPolicy: Always
schedulerName: default-scheduler
securityContext: {}
terminationGracePeriodSeconds: 30
status:
conditions:

lastTransitionTime: 2017-11-11T23:29:01Z
lastUpdateTime: 2017-11-11T23:29:01Z
message: Deployment has minimum availability.
reason: MinimumReplicasAvailable
status: "True"
type: Available
observedGeneration: 7
replicas: 1
unavailableReplicas: 1
updatedReplicas: 1

can u please tell me

Still, try the links I provided you. If there are things that don't work, go stackoverflow.com of some other sites for a help. You question and the answers will help others. If you believe there is a bug, file one on kubernetes/kubernetes project.


[Bug]: menu is on the top

What happened?

Reproduction
see the image, it should under the graph.
Last Working Version
No response
Version
demo
Operating System
windows11
Obsidian Version
N/A
Which browsers can you reproduce this in?
Chrome
Relevant log output
N/A

Additional Info
No response

Oh interesting haha, I'll fix this.


ignore_index in the loss calculation

Hello,
In case I would like to ignore certain areas of images, how could it be done?
I suppose we have to add "ignore_index" parameters in the loss function but not sure how to set it in this framework.
Many thanks and best regards,
T.

There are probably two possible ways:

To pre-process the images and exclude the regions with the ignore_index value
Or to include the ignore_index in the function load_criterion (this function is used to define the loss criteria for a specific task)