Question regarding the weird operation of GPT-J 6B's XQA on MLPerf 4.0 version TensorRT-LLM.

Hello TensorRT-LLM experts!
I have a question regarding the weird operation of the XQA kernel function supported in NVIDIA's official MLPerf 4.0 version of TensorRT-LLM.
First of all, I want to tell you the environment in which I conducted my tests.

CPU architecture: x86_64
GPU name: NVIDIA RTX 4090
NVIDIA Driver version: 535.183.01
CUDA Version: 12.2
OS: Ubuntu 20.04

When testing the GPT-J 6B (FP8 quantized model, beam_width = 4) using the customized cnn_daily_mails datasets (I truncated the input length from 128 ~ 512), I observed that the computation speed somewhat increased at the specific sequence length.
Specifically, I found that when the input length became a multiple of 256, there was a slight speed improvement in generation phase compared to the other input lengths.
When measured with Nsight Compute, I observed the following differences in memory transfer size.
The image below shows the measurements taken during the first generation phase after the context phase when the input sequence length is 255 or 256.

First, in both images, it can be figured out that approximately 8MB of data (e.g. KV Cache: 2 * 1byte * 256 * 4096 * 4, the last number indicates batch_size) is read from device memory to L2 cache.
However, the truly strange part is the amount of data that shared memory reads from L2 cache.
The former reads 50MB from the L2 cache, while the latter reads only 12MB. The only difference between the two is the input sequence length is only longer by 1.
What's even more strange is that this phenomenon similarly occurred with input sequence lengths of (511, 512) or (767, 768).
To understand this results, I checked the NVIDIA Nsight Memory Analysis video, but I couldn't get the cause of the strange XQA's operation.
I know that the source code for XQA will not be opened to public. However, it would be very helpful to know if this issue has been resolved in the current version of TensorRT-LLM or if it remains an area for improvement in XQA. I hope this information would greatly assist in the use of TensorRT-LLM! :bow:

What you observed is a result of the kernel design. XQA is efficient for beam search because in beam search, the KV cache entries generated by the input tokens are always shared among all beam search candidates. XQA is optimized for this case.
XQA uses one thread block to handle all beam search candidate sequences. When it iterates through the KV cache, it will load one tile (256 for your case) of tokens per iteration. If all tokens in this tile is from input, then XQA knows that it only needs to load them once because they are uniform for all beam search candidates. This optimization happens with granularity of a tile (256 tokens for your case).
If a tile contains at least one generated token, then XQA will fallback to normal mode for this tile, i.e. load once for each beam search candidate. If the tile contains both input and output tokens, the input tokens in this tile will be loaded multiple times and may cause extra L2 traffic.
Does above explanation makes sense to you?
We are not yet checking output tokens to see if some of them are also uniform for all beam search candidates. It's one potential optimization for generation-heavy tasks. We are aware of this but it's not yet prioritized.

Thank you @lowsfer  for providing a detailed answer about what I was really curious about!
After reading your comment, I reviewed the Beam Search method of PagedAttention and its code, considering the optimized XQA operation. Indeed, I can see that the method you provided is the best approach.
Of course, I don't know the actual internal code!
:thinking: However, I still have unresolved questions and would like to propose an optimization candidate for the current XQA operation (from the perspective of memory access rather than computation), although the priority is not high.
The following figure illustrates my understanding of XQA operation.
Let's assume that one Tile reads 256 tokens.

The input tokens are shared and read across beam requests, as shown by the blue boxes.
However, when there are any generated tokens, tokens need to be read separately for each beam request, as indicated by the red boxes.

By examining the above and below cases, we can calculate how much memory size (especially, KV Cache) is transferred.
We have already defined beam width = 4 and batch size = 4.

The  above case will read approximately 33.55MB.
The below case will read approximately 8.52MB (after re-measuring, it was found to be 8.52MB instead of 10MB).

:thinking: Here, I met an unresolved issue. When I analyzed with Nsight Compute, the memory amounts read are actually 50.53MB and 12.92MB, respectively.
Interestingly, these values are about 1.5 times the theoretically calculated values (as indicated by the SPECIAL NUMBER in the figure). Moreover, this 1.5x ratio remained nearly consistent across various input sequence length!
In summary, the current total amount of memory transfer size from the L2 cache to shared memory is 50% more than the expected value (although I considered only the KV cache). I think this result indicates a potential optimization problem.
Due to my poor CUDA abilities and the inability to read the actual code, it is difficult to determine whether this issue arises from bank conflicts or uncoalesced memory access.
If you could clarify

whether I have misunderstood, :sweat_smile:
whether this is an optimization issue that needs to be addressed,
whether the additional data (50% size of KV Cache) should be read and used in the XQA kernel,
or if it is a matter that only TensorRT-LLM core developers can access,

it would be greatly enhance our trust in the operation of XQA!
If it is difficult to answer, I would appreciate it if you could let me know that you cannot provide a response.
I would be delighted if this analysis could contribute, even slightly, to the improvement of XQA operation and TensorRT-LLM.

@bongwonjang It's a known issue by design. On GPUs with small shared memory per SM (e.g. your GeForce GPU), we have to limit the shared memory buffer size for VRAM->SharedMem prefetch. As a result, for K cache loading, we have to read only 64 bytes per cache line (128 byte) in one iteration. So there will be 2x L2 traffic amplification. V cache does not have this problem and L2 traffic will be 1x of VRAM. So the total amplification will be the average, i.e. 1.5x. Fortunately, L2 bandwidth is larger than 1.5x of VRAM bandwidth, so L2 bandwidth will not be a bottleneck and this problem will not impact performance much.
On GPUs with larger shared memory per SM (e.g. A100 or H100), there will be no such problem.


Method nodes fail tree merge if their default values are not exactly the same

@searls reported that Tapioca would (silently) fail to merge the generated signatures and the bundled signatures of a method defined like the following:
sig { params(a: T::Boolean).void }
def foo(a: false)
end

This happens because when Tapioca generates the RBI for the foo method it generates it as:
sig { params(a: T::Boolean).void }
def foo(a: T.unsafe(nil); end

Note that the default value in the generated RBI file does not match the default value in the bundled RBI file, so the merge fails this check, which itself fails because of this comparison.
This PR adds a test case to exhibit the behaviour and adds a hacky fix that considers T.unsafe(nil) to be equivalent as a default value to any other value. We probably need a more general fix for this though.

Ok, removed the comparison of values when comparing OptParam and KwOptParam nodes. I had to change 1 test that was assuming that a different default value would create a merge conflict, which in the new reality it doesn't.

Thank you!


Specify the expected semantics of clear APIs in tests

It has been clear from earlier discussions that not everybody is aligned on what should be the semantics of our clear APIs.
We need to agree on those and materialize them as unit tests both as a mean of specification and to prevent regressions.
Related: the implementation of #3023  revealed some flakiness issues that should have been caught by these tests to-be.
Some examples
Assuming that we're querying for LatestAt("frame", 2): what are the expected semantics for this?
rr.set_time_sequence("frame", 1)
rr2.log("points", rr2.Points2D([[0, 0], [1, 1]]))
rr2.log("points", rr2.Clear(True))

Or this?
rr.set_time_sequence("frame", 1)
rr2.log("points", rr2.Clear(True))
rr2.log("points", rr2.Points2D([[0, 0], [1, 1]]))

What about this?
rr.set_time_sequence("frame", 1)
rr2.log("points", rr2.Points2D([[0, 0], [1, 1]]))
rr2.log("points", rr2.Clear(True))
rr2.log("points", rr2.Points2D([[0.5, 0.5], [1.5, 1.5]]))

I.e. do clear APIs follow the usual no-global-ordering/per-thread-row-id-ordering model, or do they break away from that in order to make distributed clears easier to work with?
Update: also, what about the very weird case where a row comes in that contains both ClearSettings component and a bunch of other components? For now, #3023 will make it so the ClearSettings component "wins" over everything else.

Quoting @jleibs:

The existence of pending clear is to handle cases where data is received after the clear event, but still has a time stamp <= the clear event.

So then the most important thing to specify and test is what happens to rects in e.g.
rr.set_time_sequence("frame", 1)
rr2.log("points", rr2.Points2D([[0, 0], [1, 1]]))
rr2.log("points", rr2.Clear(True))

rr.set_time_sequence("frame", 0) # !!
rr2.log("points", rr2.Rect2D([...]))

Today, this implicitly follow the same behavior as any other data: RowId order defines the "winner". I'm going to make that behavior explicit in a test, and we can decide to change it in the future if needed.

Except the RowId in question will be the RowId generated by the cascaded clear mechanism, which as far as the end user is concerned might as well be unspecified behavior.
So no, we have no way to formalize that at the moment (other than documenting that it is in fact undefined behavior).


#2: Initial commit with a basic setup of game stuff.

Going to force-push this initial PR so we have a basis to work off of.


Store function_call_id in actions

Description
https://github.com/dust-tt/dust/issues/5040
This PR changes a bit the code to store the function call id on actions.
Done in this PR:

[x] Edit the Dust app to return the function_call_id on the output block.
[x] Add a new column functionCallId to all our action run models: AgentTablesQueryAction, AgentRetrievalAction, DustAppRunActionType & AgentProcessAction.
[x] Propagate the function call id from the Dust app output to where we save it on db.
[x] On renderConversationForModelMultiActions, retrieve the functionCallId from the new column or keep the fallback that we add before, based on the action id.

How does it work?
runMultiActionsAgent calls the multi-actions Dust app that returns the id of the function call along with their name and arguments, which yields "agent_action" with a new param functionCallId.
This even is listened on runMultiActionsAgentLoop that will call runAction with the added param functionCallId.
On runAction, for each action runRetrieval/runDustApp/runTablesQuery/runProcess we add the param functionCallId that is used to create the related run model with the field functionCallId set.
Risk
Low since not rolled out.
Can be rolled back.
Deploy Plan

Deploy prodbox, run init_db to create the new columns.
Deploy Front.

@PopDaph @fontanierh I've metidated more about this.
I almost convinced myself to not store it and instead have rendering functions to create actions that look like each provider.
But!
I suspect they might/will use this to cache requests and provide lower prompt token pricing so I would err on the side of doing both :+1:

@spolu

I suspect they might/will use this to cache requests and provide lower prompt token pricing so I would err on the side of doing both 👍

Interesting

Sorry for the delay!


Integration with google oss-fuzz fuzzing service

Hi @marcusklaas, Based on this comment: https://github.com/raphlinus/pulldown-cmark/pull/562#issuecomment-1011322702 if you are interested, I would like to help integrate this project into OSS-Fuzz.

As an initial step for integration I have created this PR: https://github.com/google/oss-fuzz/pull/8624, it contains necessary logic from an OSS-Fuzz perspective to integrate pulldown-cmark.

OSS-Fuzz is a free service run by Google that performs continuous fuzzing of important open source projects, you can find more details in our FAQ.

If you would like to integrate, the only thing I need is a list of email(s), it must be associated with a google account like gmail (why?). by doing that, the provided email(s) will get access to the data produced by OSS-Fuzz, such as bug reports, coverage reports and more stats.

Notice the email(s) affiliated with the project will be public in the OSS-Fuzz repo, as they will be part of a configuration file.

We have some fuzzers now. The Gmail account may be a problem, how it is exactly used for authentication? This account receives many e-mails?
Thanks.

I have created the following Google account for the project<EMAIL_ADDRESS>Which would be the next steps?
Thanks.

OK, then please create it.
Thanks.

@Martin1887, do you still own<EMAIL_ADDRESS>

Yes, I can login in that account.


Registered uuid

Current coverage is 97.54%

Merging #12 into master will not affect coverage as of bb2635c

@@            master     #12   diff @@
======================================
  Files            4       4
  Stmts          122     122
  Branches        21      21
  Methods          0       0
======================================
  Hit            119     119
  Partial          1       1
  Missed           2       2

Review entire Coverage Diff as of bb2635c

Powered by Codecov. Updated on successful CI builds.


[CHANGELOG] add breaking changes

Link to https://github.com/callemall/material-ui/pull/1210/files

Thanks for catching this breaking change. Sorry I missed it. :(

Don't worry


Hot load theming

Is there something special I have to get this to work? I'm passing inline styles in but I'm only seeing changes after a hard-reload.

@KyleAMathews I haven't tried hot reloading yet, but I wonder if it's related to react-themeable. cc @markdalgleish
Any chance you could provide a repo that demonstrates the issue?

Closing for now.

@KyleAMathews This should be resolved in 3.5.0

:+1:


LogDB has to use environment settings

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/630/ for details

No pylint warnings for pull request 6277:

Unit test changes for pull request 6277:

WMCore_t.Services_t.LogDB_t.LogDB_t.LogDBTest:test_apis changed from error to success
WMCore_t.Services_t.LogDB_t.LogDB_t.LogDBTest:test_checks changed from error to success
WMCore_t.Services_t.LogDB_t.LogDB_t.LogDBTest:test_cleanup changed from error to success
WMCore_t.Services_t.LogDB_t.LogDB_t.LogDBTest:test_delete changed from error to success
WMCore_t.Services_t.LogDB_t.LogDB_t.LogDBTest:test_docid changed from error to success
WMCore_t.Services_t.LogDB_t.LogDB_t.LogDBTest:test_get changed from error to success
WMCore_t.Services_t.LogDB_t.LogDB_t.LogDBTest:test_get_all_requests changed from error to success
WMCore_t.Services_t.LogDB_t.LogDB_t.LogDBTest:test_prefix changed from error to success
WMCore_t.Services_t.LogDB_t.LogDB_t.LogDBTest:test_report changed from error to success
WMCore_t.Services_t.LogDB_t.LogDB_t.LogDBTest:test_thread_name changed from error to failure

@ticoann please merge. I leave the last one to you that the thread names are not matching up.

Thanks Eric,


only fetch visible entries

Requires https://github.com/theia-ide/timeline-chart/pull/117
Signed-off-by: Matthew Khouzam<EMAIL_ADDRESS>

Thanks for the effort. #740 was merged for fetching only visible rows. I'm closing this one since not needed anymore.


write blobs to disk if crane-version is tip

@imjasonh @mattmoor, is this still needed?

no, we did something else :)


Sanity test cases

This is a set of test cases to ensure the following is always true in our repo:

The application starts up.
The root API is accessible without any auth, returns 200.
The database can be created without any errors.

As we continue, this can be extended.

Can I work on this issue ?

Yes, would be good. Assigning

I'll take some of the starter testcases.

@ChiragJS what's the status on this?

Yea , so as we had to get the backend stuff started , skipped writing the tests, but @chrisvrose did add some but had to remove it, because we were having some build issues

Most likely from missing configuration. Will look into it over the couple
of weekends. If anyone else wants to look at it at present, please
feel free.
On Sat, 1 Jun, 2024, 13:23 ChiragJS, @.***> wrote:

Yea , so as we had to get the backend stuff started , skipped writing the
tests, but @chrisvrose https://github.com/chrisvrose did add some but
had to remove it, because we were having some build issues
—
Reply to this email directly, view it on GitHub
https://github.com/IEEE-RVCE/GateKeeper/issues/16#issuecomment-2143348355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADX32PDQA3N4D5IDZZROY4TZFF4XPAVCNFSM6AAAAABDMC33UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGM2DQMZVGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Any luck on this ?

Yup, I'm still working on it. Didn't get much chance since last weekend
since there's work going on, but I'll be pushing out small chunks of tests
over the weekend.
On Sat, 15 Jun, 2024, 11:23 Prajwal prakash, @.***>
wrote:

Any luck on this ?
—
Reply to this email directly, view it on GitHub
https://github.com/IEEE-RVCE/GateKeeper/issues/16#issuecomment-2169146859,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADX32PCLRQYWJBUE3MANEDLZHPJHDAVCNFSM6AAAAABDMC33UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGE2DMOBVHE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Placeholder not displayed for ordinals that have been embedded by another site

A user reported that this Ordinal (and ordinals like it) are not displayed in the Hiro Wallet:
https://ordinals.hiro.so/inscription/14effa0e0a947cc05cab869d50626cdaf2ad1cbc05f81dbc8d99cb763116f117i0
On ord.io it is displayed like this:
https://www.ord.io/bc1pd4fjc9cyg8wfgc3x7d3pcxc99tmn6vqw5gstp6hhmputm06rw2tqdqdtxd
If it isn't displayed for security reasons on ordinals.hiro.so, do we still expect a placeholder image to be displayed in the wallet? I was unable to verify that that is the case.

Let's tackle this with https://github.com/hirosystems/wallet/issues/4077


Bloodhound 4.1 released, new edges added

Hi,
Bloodhound 4.1 was released yesterday. With that came three new edges.  "AddKeyCredentialLink", "AddSelf" and "WriteSPN". See the slidedeck  for more info.
You already support "AddKeyCredentialLink" (shadow credentials) but does your tool work when only the edge "AddKeyCredentialLink" and not "GenericWrite" or "GenericAll" is available? The same goes for "WriteSPN". At least you used to be able to write SPNs.
Will you support the new edges?

You can already exploit those edges manually using bloodyAD. You can write SPNs using the 'setAttribute' function.
I could however add AddSelf and later AddKeyCredentialLink in autobloody. I will let this issue opened to remember.
The problem for AddKeyCredentialLink as you experienced, is that you need a Windows 2016 functional level and a DC with a certificate for pkinit and Sharphound doesn't check those conditions.

Thanks. Could you write an example on how to write an SPN? Also, are you saying that "AddSelf" will not work using bloodyAD.py or that it already can be used using the "addObjectToGroup" function in bloodyAD.py?

I think something like should work:
python bloodyAD.py -u john.doe -d bloody -p Password512! --host <IP_ADDRESS> setAttribute 'computer1$' servicePrincipalName ["HTTP/www.contoso.com","TERMSRV/FRONTRM.contoso.com"]
Be aware that it will not keep the old values so if you want to keep it use getObjectAttributes first and note the SPN value

Can I use a URL with this...appears to be a great tool

Could you be more explicit? I don't understand your question.


WL-5330 SAK-43815

Can one of the admins verify this patch?

@nicholaswilson100 this is ready to go.


Wizard: Detection API response parsers

This PR introduces helper parsers for the two API endpoints supported by the Wizard detection API:

Parser for the supported Place types and properties API. It also validates the responses.
Parser for the column/header detection API for Places and Dates. It also validates the responses.
Unit tests for both (esp the validation).

Thanks for the useful review! A couple of questions back.


[nrf fromtree] net: wifi_shell: Display correct power save status

Display power save status correctly.


feat(instances): Introduces TailLogs

This commit introduces a utility method for the tailing of kraftcloud vm instances logs, which:

Uses a go routine and a channel for sending and receiving log lines which allows for asynchronous and uninterrupted reading and displaying of logs;
Uses larger to smaller page size in order to retrieve logs, overall reducing the number of initial calls to gather previous logs whilst increasing the granularity of subsequent calls in order to display more lines in real-time.

Signed-off-by: Alexander Jung<EMAIL_ADDRESS>

just had this
panic: runtime error: slice bounds out of range [16325:0]

goroutine 24 [running]:
sdk.kraft.cloud/instances.(*client).TailLogs.func1()
        /home/cez/unikraft-io/go-sdk/instances/instance_log.go:140 +0x815
created by sdk.kraft.cloud/instances.(*client).TailLogs in goroutine 1
        /home/cez/unikraft-io/go-sdk/instances/instance_log.go:61 +0x15e
➜  nginx git:(main) ✗ ~/kraftkit/main cloud instance logs test-python --tail 20

it does not happen consistently

Also --follow seems to be default yes now, maybe I don't want to follow logs ;d


changes to closure capture in Rust 2021 affect drop order of ignored arguments

Playground demo
This code:
pub struct ArgWithDropGlue;
impl Drop for ArgWithDropGlue {
    fn drop(&mut self) {
        println!("dropped");
    }
}

#[async_trait]
pub(crate) trait Create: Sized {
    async fn create(arg: ArgWithDropGlue) -> Result<Self, ()>;
}

struct Foo;

#[async_trait]
impl Create for Foo {
    async fn create(_: ArgWithDropGlue) -> Result<Self, ()> {
        Ok(Foo)
    }
}

triggers the 2021 edition migration tooling to insert a let _ = &__arg0; line, in order to try to avoid the edition change changing drop ordering. If you don't do that, and change the edition, it really does change drop ordering:
fn main() {
    println!("create future");
    let f = Foo::create(ArgWithDropGlue);
    println!("drop future");
    drop(f);
}

in edition 2018:
create future
drop future
dropped

in edition 2021:
create future
dropped
drop future

but regular async functions don't work that way, even in edition 2021 playground:
async fn create(_: ArgWithDropGlue) -> Result<Foo, ()> {
    Ok(Foo)
}

fn main() {
    println!("create future");
    let f = create(ArgWithDropGlue);
    println!("drop future");
    drop(f);
}

prints:
create future
drop future
dropped

I think we do want the argument to be captured here, to match the behavior of async functions. That would also incidentally stop rustfix from making the odd suggestion. Surprisingly, the suggestion rustfix makes does actually work, which also seems like a bug to me -- I would have expected the __arg0 arguments to have some kind of hygiene which prevented them from being named.

I found this while running the 2021 edition migration over the Fuchsia codebase, you can see the full example pre-minimization in https://fuchsia-review.googlesource.com/c/fuchsia/+/684586/1/src/settings/service/src/tests/setting_handler_tests.rs if that's interesting.

https://github.com/dtolnay/async-trait/pull/203 seems to fix it for _ patterns as arguments, but not patterns with underscores nested inside them:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=2d998a28f5b49520167ef0868f0beab5
It drops the argument early if edition is set to 2021, and produces the migration lint.

The initial fix in 0.1.55 also broke a pattern that used to work:
#[async_trait]
trait Generic<T> {
    fn takes_ref(&self, thing: &T);
}

// no need for T: Send + Sync bound on this impl because &T is not used
#[async_trait]
impl<T> Generic<T> for () {
    fn takes_ref(&self, _: &T) {}
}

I believe the remaining edition-sensitive cases have been resolved in #232 and #234.


Refactor comment and submission status

Issue #:
https://github.com/bcgov/met-public/issues/740
Description of changes:
Refactor comment and submission status
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report

Merging #836 (4414d1a) into main (cfa5d3c) will increase coverage by 0.37%.
The diff coverage is 93.02%.

@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
+ Coverage   72.40%   72.78%   +0.37%
==========================================
  Files         172      172
  Lines        4482     4449      -33
  Branches      294      294
==========================================
- Hits         3245     3238       -7
+ Misses       1199     1173      -26
  Partials       38       38

Flag
Coverage Δ

metweb
65.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

met-api/src/met_api/resources/comment.py
66.17% <ø> (ø)

met-api/src/met_api/resources/survey.py
66.12% <ø> (ø)

met-api/src/met_api/schemas/submission.py
100.00% <ø> (ø)

met-api/src/met_api/schemas/survey.py
100.00% <ø> (ø)

met-api/src/met_api/services/comment_service.py
68.85% <ø> (ø)

met-web/src/apiManager/endpoints/index.ts
100.00% <ø> (ø)

met-web/src/services/surveyService/index.ts
20.00% <ø> (ø)

met-api/src/met_api/services/submission_service.py
83.33% <83.33%> (ø)

met-api/src/met_api/models/submission.py
69.56% <87.50%> (ø)

met-api/src/met_api/schemas/comment.py
84.00% <90.00%> (ø)

... and 19 more


Allow listening for events without annotations

Currently, the event system requires the use of annotations. This is quite inconvenient, especially for plugins implementing a kind of dynamic event registration, for example if all needed events are not known at compile time. This affects especially scripting plugins which would always need to add a separate event handler method for every event accessible through their scripting API.
As an example, Pore uses dynamic event registration for calling Bukkit's events already, however currently it has to generate classes at runtime to make that work. There should be an easy way to register events using a simple interface additionally instead of just using annotations, for example something like this:
interface EventHandler<T> {
    void handleEvent(T event);
}

interface EventManager {
    // ...
    <T extends Event> void register(Object plugin, Class<T> eventClass, EventHandler<T> handler);
}

game.getEventManager().register(plugin, ServerStartedEvent.class, new EventHandler<ServerStartedEvent> {

    @Override
    public void handleEvent(ServerStartedEvent event) {
        // Do something
    }
});

The only thing missing here would be the Order of the event and ignoreCancelled, but that could be just added as additional overload for the registration method.

@Minecrell
Issue is we would have a chicken and egg problem...unless you would want lifecycle events to remain annotation-based.

@Zidane
You mean like if I would want to register something like PreInitializationEvent without annotations?

Yes

@Zidane
This is not supposed to replace the current annotation-based event system. Plugins still need to add a @Plugin class so they can just add the annotation-based handler there. This is only to help when you don't know exactly which events you will want to listen to at runtime, and obviously you do know that with the state events.

@Minecrell
Right but some may ask for whichever way to pull off not needing annotated events at all.

I also need this for my Plugin.

@Minecrell
The EventManager should probably have some more wildcards.
<T extends Event> void register(Object plugin, Class<T> eventClass, EventHandler<? super T> handler)
or
<T extends Event> void register(Object plugin, Class<? extends T> eventClass, EventHandler<T> handler)
There is only one requirement to skip all event handler annotations for plugins.
The event handler (registration) must be accessible when creating the plugin instance, that way the registration of the event handlers could be done in the plugin constructor.
public MyPlugin() {
    super();
    Game.getGame().getEventManager()
        .register(this, GameStateEvent.class, new GameStateEventHandler(this));
}

(Or via injecting the EventManager in the constructor directly)


CI: Update Node.js version to v16.20.0

By using the bundled Node from emsdk, which is no longer outdated.
See: emscripten-core/emsdk@d7327b4

Needs to fix a style failure.

It looks like the style check CI is having some issues:
/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +b17ab4b5ede3fc9a34cf4eafa98ab36cbe98ee4f:refs/remotes/pull/3321/merge
Error: fatal: unable to access 'https://github.com/rust-lang/libc/': The requested URL returned error: 429
The process '/usr/bin/git' failed with exit code 128
Waiting 19 seconds before trying again
/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +b17ab4b5ede3fc9a34cf4eafa98ab36cbe98ee4f:refs/remotes/pull/3321/merge
Error: fatal: unable to access 'https://github.com/rust-lang/libc/': The requested URL returned error: 429
The process '/usr/bin/git' failed with exit code 128
Waiting 16 seconds before trying again
/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +b17ab4b5ede3fc9a34cf4eafa98ab36cbe98ee4f:refs/remotes/pull/3321/merge
Error: fatal: unable to access 'https://github.com/rust-lang/libc/': The requested URL returned error: 429
Error: The process '/usr/bin/git' failed with exit code 128

The 429 (Too Many Requests) error is an HTTP status code that often occurs when you've hit a request limitation of an API, perhaps too many CI jobs were running?

maybe you can rebase and trigger the check again

No need to do that, we can just: @bors r+

:hourglass: Testing commit 5841067de1341dd8744fdbb585c465b73ad07855 with merge 10e072473e03911cc99a0b3c81df8227e9719b8a...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 10e072473e03911cc99a0b3c81df8227e9719b8a to main...


test(py): add precommit hooks and pytest-bdd

There appears to be a number of empty files. Was this intended?

They are not empty, GH just reports nonsense here.

There appears to be a number of empty files. Was this intended?

They are not empty, GH just reports nonsense here.

It does actually report the permissions change. Rather than "Empty file. " it should just display nothing, that would be clearer I think.

bors r+

bors r+


Add HackerNews example application

Adds another example application built based on Traytter which grabs latest Hacker News posts.

Love it, thank you!

No problem, pretty cool library!


Hunter: Missing mobs

*Description of issue:
The three following mobs are missing from the Hunter job:
  slime
  magma_cube
  wither_skeleton

Maybe slime and magma slime were left out intentionally, but it's definitely a bug to not be paid for wither_skeleton. I would make a pull request to add these mobs, but I was wondering if there needed to be a discussion on reward balancing. Slimes give you the reward for each slime and slime child killed, so $0.50 seemed fair to me. My suggestion for wither skeleton is $15.
Suggested additions to the jobs config file under hunter kills:
      wither_skeleton:
        income: 15.0
        points: 15
        experience: 15.0
      slime:
        income: 0.5
        points: 0.5
        experience: 0.5
      magma_cube:
        income: 0.5
        points: 0.5
        experience: 0.5

Some entities contains wither_skeleton fixed in this commit. Magma_cube and slime works correctly.

Is that an issue related to recognizing the entities? Those 3 mobs are still missing from the Jobs Config file, which is what I was referring to: https://github.com/Zrips/Jobs/blob/master/src/main/resources/jobConfig.yml

Whoever has downloaded the plugin should learn how to use the configuration, not adding every single materials/entities to the configuration, as in the next update the jar file will almost reach 1 MB. Anyway, whoever wants that entity to give money to, just add it to the list and it's done.

I see. I will update our jobConfig and leave the Zrips repo config as is.


Fields in streaming subscriptions must be in ascending order

https://discord.com/channels/720378361880248621/1062730209943629915/1263245802394878074

This is already implemented, but I've added a test to make this explicit


docs: fix github url in sandboxes/front_proxy.rst

@victorgs Thanks for the PR, can you sign the CLA? https://oss.lyft.com/cla/#!/signature

You're welcome :) signed


Use error bars in dygraphs.

WIP implementation of error bars for metrics with multiple values. The graph shows the mean; the lower bound is the minimum, the upper bound is the maximum.
See this example in dygraphs: https://dygraphs.com/gallery/#g/temperature-sf-ny
This is how it looks in our dashboard:

This PR also makes minor changes to the graph rendering. This is because with error-bar we cannot use filled graphs. I took the opportunity to simplify things a bit.
In particular, the graphs now always show the origin, fixing https://github.com/ocurrent/current-bench/issues/103.
Before:

After:

This makes the small variations barely visible on some graphs as you can see. But I think it's a reasonable trade-off.

Related to the multi-value datapoints: it would be good to show min/avg/max in the tooltip. I'll add this in a follow-up PR.

This is great, as in #103, I like seeing the origin.
For example in the dashboard example, you immediately see that the big (relative) change is in merge_duration_us.


[nginx] Always skip on missing config file

Coverage decreased (-0.01%) to 37.525% when pulling 1fcecda8e5ccd96ffc761ee596e18024c8cba848 on no_nginx into b0b929d1950dc29efaf1fcd630c64f5398bd6e3d on master.


Received "self signed certificate in certificate chain" error when cloning complete-typescript-course.git

I tried to clone complete-typescript-course.git but received an error "SSL certificate problem: self signed certificate in certificate chain".
Please see steps to replicate for more information.
Steps to replicate

Open git bash.
Paste in git clone https://github.com/angular-university/complete-typescript-course.git into the terminal window.
Press enter. The below output appears.

$ git clone https://github.com/angular-university/complete-typescript-course.git
Cloning into 'complete-typescript-course'...
fatal: unable to access 'https://github.com/angular-university/complete-typescript-course.git/': SSL certificate problem: self signed certificate in certificate chain

This is happening with other repos as well. Closing.


hovering over links in longer notes automatically jumps me to the top of the page instead of creating a hover editor preview

I notice this happens a lot when on longer notes with lots of links in them... when I hover over a link instead of getting a hover editor preview it automatically jumps me to the top of the page instead....
https://user-images.githubusercontent.com/65312761/173556748-0cd2a8b4-ccba-4c63-a6da-a92bad6423e1.mov

Same issue with me too

I'm not able to reproduce this: can you share your hover editor settings, and also any editor settings?  Is it only in reading view, or also live preview?  Source mode?  Does it happen with the stock theme or in the sandbox vault?  We need to be able to reproduce the problem in order to figure out what's happening.

Thanks for getting back to me! Below are some answers to those questions and screenshots of the my current hover editor and editor settings. Also, I only ever notice this bug in my longer notes that have lots of links... in order to replicate it you may need to try on a longer note - short notes don't seem to have this problem (possibly because there is no room to jump up to in the first place?). Let me know if you need anything else.

It seems to only occur in Reading View for me-- the issue doesn't occur in live preview mode

It happens with any theme I've used including the default obsidian theme

Hover Editor settings:

Editor settings:

I can't replicate this either, even on very long notes. Could you try replicating this with all plugins disabled except for Hover Editor and see if it persists? If it doesn't occur with the other plugins disabled, we'll need you to narrow down which plugin is causing the adverse reaction.

"Bartender", perhaps.
I closed the plugin, the problem just gone.

Updating to Hover Editor 0.11.7 and Obsidian 1.0.3 may fix this issue for anyone who is still having it; if it persists after update and restart, please let us know.


refactor: make RedditListing generic

This (hopefully) fixes #88.

@JamesxX I listed you as a co-author on this change since you jumpstarted the work in 8b6ccd524b05436f4dc785b48095ce33115a2db9. Is that alright with you?

Codecov Report

Merging #91 (ce83c06) into master (17bbe89) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thislooksfun any chance we can chat on discord?

[If] you use default generic parameters like in 8b6ccd5, you might be able to save yourself making an extra type alias, and modifying too many files.

That's true, but doing it this way makes it more explicitly generic. Using a default generic parameter like in 8b6ccd524b05436f4dc785b48095ce33115a2db9 it would indeed work with fewer changes, but would mean that code like this
export function fakeListingAfter(after: string): RedditListing {
  return { after, children: [] };
}

would still compile, despite the fact that it should really be generic as well. Not having the default parameter means every place we were using/will use RedditListing we now need to make a conscious decision of "should this be strongly typed, or should it be generic?", which should lead to fewer changes down the line. This way touches some more places now, but it means we can be certain going forwards that anywhere that takes or returns a non-generic RedditListing is doing so intentionally.

@thislooksfun any chance we can chat on discord?

While I'm not oppose to it in theory, I also would prefer to keep all snoots discussion as public as possible (with the obvious exception of any active vulnerabilities, but those shouldn't be reported on Discord either). Do you have a specific need that would be better suited for a Discord conversation?

Was more about progressing my other PRs, having lots of branches locally makes it an absolute pain making new commits.


document 'magic' virtual elements

the readme mentions magic-virtual-element, but doesn't say when/why we should use it over virtual-element, and both element repos have blank readmes.

after scrolling the source code, I think it is about syntax sugar for attribute, such as automatically join the array in attribute class  using space.

Yeah we need to document both of those. I'll try and get them up this week.

@anthonyshort Any progress ?

Fixed thanks to @askmatey

https://github.com/dekujs/magic-virtual-element/commit/aeed13e935e0ec152e7ca68b1af03be7d3d2080b


[0.94a4] Circle splatter only showing in the center of Preview2D when zoomed out.

Is this intended behavior or a bug? Feels like the repats should be just clones of the center image...
Edit: Actually, seemingly, I need new glasses: No shapes of any sort show up there - the + and x rays made from shapes do not show either. So only gradients repeat.

No, it's the intended behavior. Material Maker does not manipulate images but shaders. Those shaders are defined beyond the generated image (and beyond pixel precision both in terms of size and value precision), that's what 2D preview shows.
If you want to see how your texture tiles, you just have to add a Transform node and set it in repeat mode.
Gradients repeat because that's how they are defined (not sure it's a good choice).

No, it's the intended behavior. Material Maker does not manipulate images but shaders. Those shaders are defined beyond the generated image (and beyond pixel precision both in terms of size and value precision), that's what 2D preview shows.
If you want to see how your texture tiles, you just have to add a Transform node and set it in repeat mode.
Gradients repeat because that's how they are defined (not sure it's a good choice).

Ah, understood. I sort of suspected that, but didn't really find an explanation so far. Closing then.

Ah, understood. I sort of suspected that, but didn't really find an explanation so far. Closing then.


Upgrade Handler is using full version, instead of releaseVersion

So, when I just used noderelease2proposal it produced an json for upgrade name v18.0.0, but I was expecting to see v18.
I don't know if this is something that can be pulled automatically, or if it will require a manual step to determine the releaseVersion needed.

Related to https://github.com/zeta-chain/node/pull/2646

Is it still relevant with https://github.com/zeta-chain/node/pull/2646 completed?


Add support for Jupyter notebooks in DockerDriver

Add support for Jupyter notebooks in DockerDriver. AFAIK Jypyter needs a base url parameter that matches the proxied path, so we will probably need to introduce some new configuration parameters and a mechanism for dynamic parameters for Docker instances

This needs an option to skip rewriting the url, as jupyter notebook already has the option to serve from a certain base path


Collapsible enhancements

Better handling for up/down/left/right arrows to escape collapsible when it's the last/first element in the root/shadowroot

Hey @fantactuka, great stuff. Wanted to get your thoughts on #4187 on using a block cursor vs adding paragraphs or it's possible I've misunderstood the changes. Feel free to close this issue if you think it makes sense.

As of now block cursor is only applicable to decorators and won't help much with elements since element node that has children won't receive selection (unlike decorators).

I discovered a small bug when playing with those changes, when it's the top node and the empty paragraph node is delete using "delete" key, it deletes the collapsible section, but if "backspace" is used it deletes correctly. Video below:
First deletion is using "delete", second deletion is using "backspace"
https://user-images.githubusercontent.com/7893468/230738957-393a9f38-e212-48cb-ac58-39c87516f69e.mp4

I discovered a small bug when playing with those changes, when it's the top node and the empty paragraph node is deleted using "delete" key, it deletes the collapsible section, but if "backspace" is used it deletes the empty paragraph correctly. Video below:

I think it's a general issue, e.g., adding with Heading instead of collapsible and trying to press delete while on line just above it, it'll replace heading with regular paragraph

I discovered a small bug when playing with those changes, when it's the top node and the empty paragraph node is deleted using "delete" key, it deletes the collapsible section, but if "backspace" is used it deletes the empty paragraph correctly. Video below:

I think it's a general issue, e.g., adding with Heading instead of collapsible and trying to press delete while on line just above it, it'll replace heading with regular paragraph

You are right. To tackle for another day.

I discovered a small bug when playing with those changes, when it's the top node and the empty paragraph node is deleted using "delete" key, it deletes the collapsible section, but if "backspace" is used it deletes the empty paragraph correctly. Video below:

I think it's a general issue, e.g., adding with Heading instead of collapsible and trying to press delete while on line just above it, it'll replace heading with regular paragraph

#4380 - addresses the issue


feat: allow getting all matching workers from pool

This lets us get all workers when running locally and retrieving all subscribers for an event.

Codecov Report

Merging #211 (4633510) into develop (88cd72b) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #211      +/-   ##
===========================================
- Coverage    54.74%   54.41%   -0.33%
===========================================
  Files           43       43
  Lines         4468     4495      +27
===========================================
  Hits          2446     2446
- Misses        1872     1899      +27
  Partials       150      150

Flag
Coverage Δ

unittests
54.41% <0.00%> (-0.33%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/worker/pool.go
59.62% <0.00%> (-12.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88cd72b...4633510. Read the comment docs.


Report bug: Color or thickness of the text does not match

Briefly describe the bug
First, please forgive me if my English is bad, I used deepl to translate the language.
The build is not according to my design, like the color and bold of the writing nothing has changed

Operating System
Fedora 37

What is the expected behavior?
If in the design I make text with green color writing and bold text, then it should be green in color

Please provide step by step instructions on how to reproduce the bug
https://www.figma.com/file/bDoxirghKIWzStChgp2CnL/Untitled?type=design&mode=design&t=ttJ8EvMPFNC9VySb-1

Hey @tarokeitaro!
To resolve the love heart emoji, I would find the emoji as an image (.png) and add to your project path instead I would just simply download an image and add to your /project path and add the image to your gui code (will need to install pillow)
As for the coloured text, I believe it's a common thing as I had the same issue. Only thing I'd recommend is adding in the text manually with the coloured text.
(Please note, I'm using customtkinter in this example, just change CTkLabel to Label)
self.gui = CTkLabel(self.gui.right_frame, text="Test", font=("Lato-Regular", 24, 'bold'), text_color="#FFFFFF")
self.gui= CTkLabel(self.gui.right_frame, text="Testing", font=("Lato-Regular", 24, 'bold'), text_color="#4282FF")

Hope this helps :)


switch items arrow keys or mouse click  QuickLook don't change image

Description
switch items arrow keys or mouse click  QuickLook don't change image.
In Files each time change image(item) with arrow keys or mouse  need to press on Space key to see changes on QuickLook
Steps To Reproduce
No response
Expected behavior
This is in system files explorer

Files Version
v <IP_ADDRESS>
Windows Version
Windows 11 Pro Insider Preview 22478.1012
Relevant Assets
No response

@xBLACKICEx this issue should be resolved with #6543.


Thunder R4.4 Build Error Fixed when ProcessContainer enabled

Fixed Thunder R4.4..1 Compilation error when enabled ProcessContiainer
Correct the UnLock spelling
Correct the messaging  header file
updated the ProcessContainers::ProcessContainerization into Trace::Information

We agreed this PR to be closed and the fixes to be incorporated into a fix for the remaining process containers issues


injectedJavascript not working

Hi,
I try to run a minimal example with injectedJavaScript prop. However the javascript code seems to be not executed.
Versions used:
"expo": "~38.0.8",
"react-native": "https://github.com/expo/react-native/archive/sdk-38.0.2.tar.gz",
"react-native-web": "^0.13.8",
"react-native-web-webview": "^1.0.2",
"react-native-webview": "^10.7.0"
Setup steps:

Init project: expo init
Install react-native-webview: yarn add react-native-webview
Install react-native-web-webview: yarn add react-native-web-webview
create webpack.config.js:  expo customize:web
Alias the package and add rule to webpack config:

const createExpoWebpackConfigAsync = require('@expo/webpack-config');

module.exports = async function (env, argv) {
  const config = await createExpoWebpackConfigAsync(env, argv);
  // Customize the config before returning it.
  config.resolve.alias['react-native-webview'] = 'react-native-web-webview';
  config.module.rules.push({
    test: /postMock.html$/,
    use: {
      loader: 'file-loader',
      options: {
        name: '[name].[ext]',
      },
    },
  });
  return config;
};

This is the minimal sample app:
import React from 'react';
import { View } from 'react-native';
import { WebView } from 'react-native-webview';

export default function App() {
  const runFirst = `
  document.body.style.backgroundColor = 'red';
  setTimeout(function() { window.alert('hi') }, 2000);
  true; // note: this is required, or you'll sometimes get silent failures
  `;
  return (
    <View style={{ flex: 1 }}>
    <WebView
      originWhitelist={['*']}
      source={{ html: '
This is a static HTML source!
' }}
      injectedJavaScript={runFirst}
    />
  </View>
  );
}

The HTML gets rendered but javascript not executed.
Also is the injectJavascript method method supported or is it planned?

Same issue here...

@jo-fra I think I found the bug..
In https://github.com/react-native-web-community/react-native-web-webview/blob/master/src/index.js#L20 the function returns without updating the injected javascript if source has no method.
So in your minimal sample app add , method: 'get' :
    <WebView
      originWhitelist={['*']}
      source={{ html: '
This is a static HTML source!
', method: 'get' }}
      injectedJavaScript={runFirst}
    />

I'm having the same issue - tried the approach mentioned but didnt work for me...

@bwoodlt I think method: 'get' only works if you use the uri instead of the html. If you already have the html string, I think you can just append it to the end like so.
<WebView
      originWhitelist={['*']}
      source={{ html: `<h1>This is a static HTML source!</h1>${runFirst}` }}
    />

i just tried this out and the javascript only runs in android _ it does not run in ios or web :
"dependencies": {
    "expo": "~40.0.0",
    "expo-splash-screen": "~0.8.0",
    "expo-status-bar": "~1.0.3",
    "expo-updates": "~0.4.0",
    "react": "16.13.1",
    "react-dom": "16.13.1",
    "react-native": "~0.63.4",
    "react-native-gesture-handler": "~1.8.0",
    "react-native-reanimated": "~1.13.0",
    "react-native-screens": "~2.15.0",
    "react-native-unimodules": "~0.12.0",
    "react-native-web": "~0.13.12",
    "react-native-web-webview": "^1.0.2",
    "react-native-webview": "^11.0.2"
  },


fix a tiny typo

Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:

Describe the scope of your change--i.e. what the change does and what parts
of the code were modified.  This will help us understand any risks of integrating
the code.

Describe any known limitations with your change.  For example if the change
doesn't apply to a supported platform of the library please mention it.

Please run any tests or examples that can exercise your modified code.  We
strive to not break users of the code and running tests/examples helps with this
process.

Thank you again for contributing!  We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request.  There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).
Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request.  Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.
After reviewing the guidelines above you can delete this text from the pull request.

We've merged this PR, however this library is no longer supported. We are only supporting use of CircuitPython libraries. Please see the Adafruit CircuitPython MCP3xxx library for using the MCP3008.


Change how to set the API key

Will be inside the PaymentRequest object rather than the static method

PR: #26


Todo example does not have round corners when run inside sway

Running the todo list example from the book results in a window with square corners, when using sway:

Command to reproduce:
cd book/listings
cargo xtask install
cargo run --bin todo_8

Update: Forcing csd through sway config fixes the corners (they appear round then). I find this weird, becaue I always thought that gtk does not support server side decorations.

Definitely not a bindings issue.


Align using distance sensors

USe distance sensors to stay a certain distance from the backdrop

Tested this but prove inconsistent


Add --provider flag to README

I think especially a lot of people that are new to Laravel don't know that they can use the --provider flag to just publish assets for a single package so this should make this more clear.

Thanks, but what we have now is "OK" I thinl. :)


Add pilight dimmer as light component

Description:
I would like to make a new attempt to add the pilight dimmer as light component.
I refactored the pilight switch so that there should no duplicated code.
The event bus is still used for device communication to not break an existing feature (see #7344 and #7372).
Related PR: https://github.com/home-assistant/home-assistant/pull/9114
Example entry for configuration.yaml (if applicable):
light:
  - platform: pilight
    lights:
      test2:
        on_code:
          protocol: kaku_dimmer
          id: 23298822
          unit: 10
          'on': 1
        off_code:
          protocol: kaku_dimmer
          id: 23298822
          unit: 10
          'off': 1
        on_code_receive:
          protocol: kaku_dimmer
          id: 23298822
          unit: 10
          state: 'on'
        off_code_receive:
          protocol: kaku_dimmer
          id: 23298822
          unit: 10
          state: 'off'

Checklist:

[X] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[X] There is no commented out code in this PR.
[ ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Could someone give me some hints how to fix the CI errors?

@Trekky12 sure thing, you can take a look at the individual errors by clicking on Details and then navigating to Azure DevOps. In your particular case I would suggest you read the development checklist which should help you solve the formatting and linting error.

Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤
Please, add your GitHub username to the manifest.json of this integration.
For more information about "code owners", see: Architecture Decision Record 0008: Code owners.


Added more ninja names for #53

Added 'Itachi', 'Madara' and 'Obito' to the set of ninja names.

Thanks @Raxerz!


Change onPermissionGranted to onPermissionResult(isGranted: Boolean)

First of all, great library and thanks for maintaining it actively!
Currently the PermissionUtil.askNotificationPermission.onPermissionGranted callback only triggers when the permission was actually granted. I would like to receive a negative response too so I can handle it accordingly. This PR adds this functionality.

This is implemented in v1.2.0-alpha02 version


enh(cpp) simpler struct matching

Resolves #2736.
Changes

Adds new beforeMatch compiler extension
Simplified struct/class/enum/union matcher
adds title.class sub-scope support. Related #2521.

Seems to do about as well as GitHub now.

Checklist

[ ] Added markup tests, or they don't apply here because...
[ ] docs for beforeMatch
[ ] Updated the changelog at CHANGES.md

Right now I'm using .title-class... but I wonder if perhaps we shouldn't a bit grander:
.title--class
.title__class

This is currently rebased on the multi-class stuff (so I could finish it), but in review that can be ignored.


visualize last update on mapmarkers

hi i received the following email (sorry its in german):
Eine Visualisierung, wie alt die Positionsdaten sind, wäre ganz gut.

Nicht sekündlich, aber alle 5-10 Sekunden etwas dunkler.
Zum Beispiel wie beim Lightningmaps.org.

Viele Grüße
Tilo

i think that if we implement something like that, we should make the difference in color very subtle in order to not confuse people. also it might be tricky to communicate to the user what those different colors actually mean.
what's your opinion on this?

I see ( and had ) the problem - also not really sure if colorizing would really help. Perhaps we should first try attack the root of the problem - the latency in updates. At the moment the data is synced all 12s - that means it might be 24s latency. How the problem could be attacked:

sync server-sync and location-updates
leverage gcm for updates ( might also be good for battery )
use polyline encoding / optimize the protocol ( at the moment it is really blown up with all the latitude / longitude keywords )
..

I don't think the colouring solution is feasible. Something like that would only make sense if every position was individually colored which would require timestamps, individual updates of the markers etc. and would probably a pretty good hit on performance.
I think the real problem the user has, is that he feels he cannot trust the locations shown. So thinking about it this way might open up some new solutions for fixing it.

obviously we should make sure the server works as intended. one thing that still baffles me, is, that when @cbalster pulled data with his python script, he saw delays. when i look at what my timelapse rendering, i cant see any significant delays.
lets look into server problems when i have uploaded that code. (sorry for not having done that already)
so if coloring them separately doesn't make too much sense, how about having a badge that counts down to the next update and up from the last successful update?

I just played around with fake GPS on my phone and had at the web-map what would happen.. in 4 tries the delays in position update i experienced were 3:40min; 4:30min; 20sec; 3:20min; 4:10min.
4 minutes means beeing off more than 600m at 10kmh traveling speed. :/
I very much like the idea of transmitting the timestamp of the actual GPS update. That would allwo a heatmap style diesplay of the Data.


Problem in data preprocessing

Hi Yinjun,
Your work on self-supervised features extraction is amazing! However, here is still a few problems when I try to set Selfee up on a online platform (as RTX3090 is still not that accessible for our traditional biology lab).
The first problem is in the "data preprocessing" step. I tried to use your rodenttracker to extract frames and remove background. I modified the Supertracker_OFT_Template script as suggested (I don't know if I have modified the correct script):

When running it in terminal, it returns a error like this:
error: OpenCV(4.1.2) /io/opencv/modules/imgproc/src/color.cpp:182: error: (-215:Assertion failed) !_src.empty() in function 'cvtColor'
I search the internet for it and find some say it is because the path is relative path but not absolute path. But there seems to be no relative path pass to any functions. Could you please give some more detailed instructions to me on this problem? Many thanks! Hoping to hear from you soon.

Thank you for your fast reply! Here is the feedback in the terminal.
I used 'Featurize' and used terminal to remote connection to server.
There is some problem with the GUI before, so, I set the 'preview' as False, and comment some code including "imshow" out, I guess this could still not solve all the problems.

Thanks for your kind instruction! I see!


Encoder branch: use realtime mode or faster settings

TToo ssllooww

Using the 'good' deadline and 'cpuused' value of 4 seems to be a good tradeoff.


New API endpoint

Created API endpoint /api/inputoutput to manually store user input and bot output in current session history

I'm unsure what the use case is for this?

Maybe a bot?
I use this discord bot https://github.com/chrisrude/oobabot with ooba's ui/api currently.

I see. I can't really add it as is, though, with the hard-coded bot name and all. I added something equivalent instead that's a little more general but should work just as well. You'd have to call it twice, once with a request:
{ text: <your user input> }  // default author is the user name or None if running in freeform mode

Then with:
{ author: "Chatbort", text: <your bot output> }

I haven't tested it, but it should work. Let me know if there are any issues with it.

that looks good to me!


How to customize theme styles?

I like this theme a lot, but would like to tweak it a little bit. Is there a way to add my own stylesheet in order to override some of the existing rules or add new ones?

For everyone following this issue: this feature has just been released in version 1.1.0 of the theme.


Keysign Mobile - App Update - 1

Link to the milestone and objectives table.
ADD LINK HERE
Detailed log of all completed objectives including valid proof of work.
1
2
3
4
5
6
7
It is also already live on the ios store can be tested live
Project Wallet
fe06754d2dbf23509e975809e9023b620509c1e6618472f16c9659f59e940337

Some of the texts are not getting translated.

Approved for 20000TNBC


Hello i wanted to know if the project can work seamlessly with javascript   I saw this  line  as i taking a look   import { NextRequest, NextResponse } from "next/server";

Yeah. You will get the full benefits though if you use typescript but you
can use it with JavaScript no worries.
On Tue, Jan 23, 2024, 9:51 PM Barack _ Ouma @.***>
wrote:

—
Reply to this email directly, view it on GitHub
https://github.com/amosmachora/react-daraja/issues/42, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATQQT6V4CS22MZFC2EHGT5TYQABDRAVCNFSM6AAAAABCHQDHHGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4TMNZXGA2TSNQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Next time how about you create a discussion, not an issue?


Replacement of end tick by current tick within the simulation scheduler

Resolves #159

What is the error about?


Review the usage of the Virtual Machine object

Currently the Virtual Machine object is used by the Cloud Virtual Machine event.
Are there any other applicable use cases? For example, virtual machines are used on a desktop or laptop computer.

This opened up a much larger conversation regarding the cloud category. Will be discussed with those category and class owners.


Wrapper update

Hello,
This little pull request is to update the dependencies and to make the code more simple to use; by example there is a new field in some entities to know if the object has all it's content loaded from the ENT. I also fixed a bug where if a post on any ENT is any other type than a "actualite" the URL to fetch it's content is different. This is why the wrapper now use the "type" field to know what will be the URL to fetch for the post.

Yes I tried it with a local server which reproduce the requests and all seem good


Problem Of Connection

Whenever I start my Ubuntu through vncserver , after a couple of minutes it is showing me a message of connection lost even I have an excellent wifi speed.
Please solve this problem as soon as possible

connection lost of what? internet or vncserver?

try run vncserver -localhost no
with this you can view VNC using your local IP from wifi or hotspot

Hello. I have two problems with:

VNC Viewer freezing
storage device overflow.
My devices are:
Huawei MatePad 11 with Harmony OS
Poco F3 with Android 12 under MIUI Global 13.
------ VNC Viewer freezing ------
In Termux everything is ok (I think so):
Report issues at https://termux.dev/issues
~ $ ubuntu
AlIv@localhost:~$ vncstart
DBUS_SESSION_BUS_ADDRESS=unix:abstract=/tmp/dbus-Sfgj7bj4pZ,guid=211add0a25a243ce8d80a1046398da60
DBUS_SESSION_BUS_PID=12306

New Xtigervnc server 'localhost.localdomain:1 (AlIv)' on port 5901 for display :1.
Use xtigervncviewer -SecurityTypes VncAuth -passwd /home/AlIv/.vnc/passwd :1 to connect to the VNC server.
In VNC Viewer:
After one-two click on any fold/icon on the screen the Ubuntu OS is freezing finally. But I can move the cursor.
------ storage device overflow ------
Poco F3 has additional problem. All free device memory about 200 GB is full by Termux files.
I am ready to provide additional information on your requirement. Please note that I am a new with Linux OS.

termux.md

termux.md

this problem is fixed.


not working for animated images

I tried this control with a gif file and the file is not animating. this control doesn't works for animated gif files.

As this only accepts a BufferedImage object, it is not intended to work for animated gif images. However you can fix this by extending the ImageIO library of Java, by a library like Twelvemonkeys IO, then loading individual images of the gif (unpacking it) and updating the ImageViewer with them with a timer on a separate thread


Performance issue with 500+ polygons

Google maps for Android native app gets very laggy when 2k polygons are added to the map. I have implemented the same functionality also on the web, where I display 2k polygons on the Google maps. The same mobile device is less laggy when I view the web implementation from browser. Why Google Maps Android SDK is slower and how can I match the performance as I was using the browser. Is there a similar function to https://developer.apple.com/documentation/mapkit/mkmultipolygon ?

i have the same issue exactly. they told me that its not gmaps-utils issue but maps itself. i opened an issue to the guys there, but no response 6 months now


Styled API

Add support for styled-components style API:
import tw from 'tailwind.macro'

let Header = tw.header`bg-red text-center`

Should we use the default export like above, or use a separate named export? For example:
import { styled } from 'tailwind.macro'

let Header = styled.header`bg-red text-center`

Should be able to support something like this:
In
import tw from 'tailwind.macro'

let Header = tw.button`
  uppercase
  ${props => props.size === 'large' ? tw`text-lg` : tw`text-sm`}
`

Out
import _styled from '@emotion/styled'

let Header = _styled('button')(
  { textTransform: 'uppercase' },
  props => props.size === 'large'
    ? { fontSize: '1.125rem' }
    : { fontSize: '.875rem' }
)

It would be useful to use it to extend so instead of
const Paragraph = tw.p`font-muli mb-8 text-gray-800 font-light`
const ParagraphLarge = styled(Paragraph)`
  ${tw`text-lg text-gray-500`}
`

We could do
const Paragraph = tw.p`font-muli mb-8 text-gray-800 font-light`
const ParagraphLarge = Paragraph`text-lg text-gray-500`

It would be useful to use it to extend [...]

You can do this already in pretty much that same way you would with standard emotion/styled-components:
import tw from 'tailwind.macro'

const Paragraph = tw.p`font-muli mb-8 text-gray-800 font-light`
const ParagraphLarge = tw(Paragraph)`text-lg text-gray-500`

@bradlc Do you know why when I get this error? It looks like you've wrapped styled() around your React component (h3), but the className prop is not being passed down to a child. No styles will be rendered unless className is composed within your React component.
Has error
const Test = tw.h3block w-40 mx-auto pt-4 pb-6 cursor-pointer;
No error
const Test = styled.h3`
  ${tw`block w-40 mx-auto pt-4 pb-6 cursor-pointer`}
`;

No error
const Test = tw.divblock w-40 mx-auto pt-4 pb-6 cursor-pointer;
It seems to me it only happens when it's tw other than a div.

@schrapel are you still seeing this on v1.0.0-alpha.5?

Can this work with styled-components or only @emotion?

Adding classes based on props doesn't work when using tw.button syntax. I had to switch to styled-components to achieve that.
To illustrate, this won't work:
import { ComponentType } from 'react'
import tw from 'tailwind.macro'

export const Button = tw.button`
  rounded
  py-2
  px-4
  m-1
  text-white
  uppercase

  focus:outline-none

  ${({ color }: ButtonProps) =>
    color === 'primary'
      ? `bg-red-500 hover:bg-red-700`
      : `bg-gray-500 hover:bg-gray-700`}
`

This will:
import { ComponentType } from 'react'
import styled from 'styled-components/macro'
import tw from 'tailwind.macro'

export const Button = styled.button`
  ${tw`
  rounded
  py-2
  px-4
  m-1
  text-white
  uppercase

  focus:outline-none
  `}

  ${({ color }: ButtonProps) =>
    color === 'primary'
      ? tw`bg-red-500 hover:bg-red-700`
      : `background-color: gray;`}
`

@bradlc I do not see this anymore. Sorry I somehow missed this notification. Thanks for the great package.


can it run in parallel?

when run on web: it must be handled by the caller
when run on node: ?
https://github.com/audreyt/node-webworker-threads ?

will optimize(#60) before going into multithreading


fluentd is not sending path, hostname when forwarder logs..........................?

{
"_index" : "fluentd-2014.10.18",
"_type" : "fluentd",
"_id" : "id",
"_score" : 3.0,
"_source" : {
"message" : "some log message",
"@timestamp" : "time"
}
}
I mention "path" in input config, then why fluentd is not sending path with above json data.
Need : data like that format
{
"_index" : "fluentd-2014.10.18",
"_type" : "fluentd",
"_id" : "id",
"_score" : 3.0,
"_source" : {
"message" : "some log message",
"path" : "path"
"@timestamp" : "time"
"hostname" : "hostname"
}
}

please help me .

i am sorry, by mistake click on close ?
Please help me .

Hi Shubham,
Share your td- agent configuration and sample log which you are trying to
move/parse by td-agent
On Sep 6, 2018 7:08 PM, "jain108shubhamtbt"<EMAIL_ADDRESS>wrote:

Closed #2120 https://github.com/fluent/fluentd/issues/2120.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/fluent/fluentd/issues/2120#event-1830426003, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AcClF1qp4BP3-1D7HK_5_ZVHDP55wXnQks5uYSVxgaJpZM4Wckj8
.

Hi Capt-abhi,
This is configuration which am i using :

    type tail
    path /tmp/*/*-json.log
    pos_file /tmp/fluentd-docker.pos
    path_key source
    tag docker.*
    format json

    @type elasticsearch
    logstash_format false
    index_name indexname
    host ip
    port port

This is not Fluentd core issue.
It seems that fluent-plugin-elasticsearch issue. Closed.


Page counter is broken

Each page had a page counter which let folks know how many times it had been read.  Unfortunately this broke.  Anyone have a good alternative?

I saw there are alternative services in description of that service, and digging trough them lead me to https://plantree.github.io/project-docs/visitor-badge/introduction.html .

A great alternative from @arysom
I created a test badge that works on my fork.
I did not create a badge for the main site, as this requires a secret key to be created by @selwynpolit
Here is the badge code and the badge itself
![image](https://api.visitor.plantree.me/visitor-badge/pv?label=visitors&color=informational&namespace=maks-oleksyuk.github.io&key=d9book)

We can probably change the theme or color if needed

Thanks @maks-oleksyuk and @arysom - I implemented this on the index and actions page.  Let me know what you think.

I like the following option more:

It's a different style, it's not the main information and I don't think it needs to stand out as much as in ?style=for-the-badge
A more general text was used for the text on the badge ("views"). I think it is more appropriate and is used on many sites

I'm not good at designing things but I agree with Maks' opinion. Of course the final decision is up to you Selvyn. The book won't loose anything even without page's view counter :)

I created a request (#62) to change all badges to new ones


Fix kinvolk/Flatcar#351: Add headings for clarity

Add headings to the static IP section to clarify the two alternative formats under consideration
The docs for static IP settings during Ignition run specify two alternative formats for the IP configuration passed on the kernel command line, but as written, this wasn't necessarily obvious on first reading. It appears as though the initial author had intended to insert subheadings but that they had gotten dropped. This commit adds headings, which clarify the meaning and make it easy to recognize the two formats and their differences on a first reading.
How to use
Read the docs!
Testing done
Prosaic alterations were tested using GitHub's markdown renderer, both before and after committing. HTML/CSS output from GitHub was subsequently processed using Firefox to render a final result. This result was transmitted to an IPS panel display. Emissions from the display were recorded using an organic photo-optical sensor array and transmitted in realtime to a neural network for processing and evaluation.

Thanks :)

(Will be live tomorrow)


ford: issue with strin[]

when I ask Ford to give me some keywords, the response is like that
keyword:

one
" two"
" three"
....
only the first one has not a space before..

thanks! perfect


feat(syslog-ng): upgrade syslog-ng 3.35.1

:tada: This PR is included in version 1.109.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Cloud formation script nodegroup bug

Hello,
i'd like to report a bug or a error in the nodegroup script.
when selecting the subnets, it's not explicit that we have to pick them in the right order.
i thought the script would obviously put the lower one <IP_ADDRESS> on the first ENI and the higher one <IP_ADDRESS> on the second ENI, and go on like that for more and more subnets if we add more.
unfortunatly its first picked first introduced in the ENI, which is very easy to make mistakes with.
Cheers

I will add it in the documentation, mentioning @Lautreck .  Subnets are taken in the same order , It wouldn't be correct for the cloudformation to override the provided order, as some users might want to keep <IP_ADDRESS> as eth1 and <IP_ADDRESS> as eth2.


Coordinated-fanout

Signed-off-by: Nitesh Balusu<EMAIL_ADDRESS>I need some help, the final signed tx is not being accepted by bitcoin-core. i am able to decode the constructed tx and it shows the inputs and outputs though.
Ready for review.
2 new bos commands:

create-fanout-group and join-fanout-group
For given inputs (can pass your own) it generates equal amount outputs of the size you want.
Min group size is 3
The coordinator decides the output size for all peers, joiners can decide how many outputs they want.
Default output count is 1 excluding change

Important note: this is a breaking change for group-open commands.
The tlv encoding and decoding for funding scripts has changed which would break group open. So the version number has been bumped.

seems like it needs integration test, similar to the group ones

also i think it may break some existing integration tests

All the existing integration tests are passing. Can make new ones for this.

Added a integration test.

why does it put so many inputs in the fanout tx?

my guess is what's going on is that if you don't select inputs it is putting all the inputs in which is why i see a change output that has thousands of BTC in the integration test, so I think it's simple to just always require that all participants always explicitly select all UTXOs

Should be fixed now.

Utxos are now required. Updated the integration test.

Ok should be good now. Peering step has been removed.

Fixed max size and utxo check.

Fixed.

Removed unused stuff in all fanout files.


WAITING has very low contrast in references section

Info:

OS: macOS Monterey
Logseq ver: 0.8.5
Theme ver: 2.1.6
[x] ⚠ Do i have issue on SolExt theme with DISABLED my custom.css? Yes
[x] ⚠ Do i have the same on default theme? No

Description:
In linked/unliked references section (and, in general, other search results) the background is darker and the WAITING marker is hardly visible because of low contrast. This also happens with the Logseq_original preset.
Screenshots

how about this styling?

Looks nice to me!

will be in next release soon

Great, thank you very much!

check latest release

Looks great!


RestoreEBSgroup.ps1 inline comments missleading

Comment says to pass the snapshot group "Name" as a parameter, but script actually expects to match on the tag "Snapshot Group"

Closed with commit ID #3c3cc9bd248148b0b8ef6c149e33c4a16c919a6e. Merged back to master with commit ID #a77d0f2c3a3c0b178a68aaa70e7021085ca1cc4e


Schema Generation

Is there a way to generate some sort of schema file that could be ran later to re-build a DB? If not, are there any plans to add this in?

Hi! Sorry for the delay.
I assume you mean something similar to active record's schema.rb.
To be honest I believe having to recreate the schema each time based on migrations ensures that you won't have any inconsistency between the migrations and the schema file. I had to deal with this problems in large projects with lots of migrations and it's a pain.
I think I prefer having this "only source of truth", unless there's a use case that cannot be achieved.
What use case do you have in mind?

I wasn't necessarily thinking about something like the schema.rb. I'm more thinking about the case of a test DB. Let's say you want to run specs against a test DB. You run some script that builds the DB based on the schema. Then you could drop the database completely, and re-create it at any time by loading the schema. This would be different from a normal database dump because in development or test, you may not want the data to be imported.
Let me know if that makes sense.

For cases like these I have used a Makefile like with a task like this one:
db_test_prepare:
	@dropdb --if-exists $(TEST_DB)
	@createdb -E utf8 -O `whoami` $(TEST_DB)
	@PG_URL="postgres://`whoami`@localhost/$(TEST_DB)" bin/micrate up

This runs the migrations each time the test database is set up, but I don't really think that's a problem. To avoid doing this every time, you could combine it with cleaning up all data before running the specs.
Also, note that you can also use the -s flag in pg_dump to create a schema-only dump it you wanted to.
Would any of these work?


Open the sidebar when clicking a node

Description of new feature

When a node is clicked (i.e. selected), open the sidebar if it’s not open already.
The sidebar already flashes a bit because of the loading indicator for the gene list, so the sidebar may be salient enough already for the case where you click a node with the sidebar already open.

Motivation for new feature

Users want to see the genes when they click a node.
The sidebar might have been closed by the user before clicking a node.  Clicking the node in this case is confusing.  Nothing happens.
#88

Should the sidebar be opened automatically on small screens (e.g. iPhone) as well?
In that case, the "floating" sidebar will probably hide the selected node.

Summary:

How about disabling automatically opening the sidebar for small-screen devices?
Optional enhancement:  If you click an already selected node, then you can open the sidebar.

Explanation:
In the short term, I don't think we need to worry too much about mobile.  It's important in the medium-to-long-term.  One of the people I spoke with wanted to pull up the app on their phone as soon as they started using the app:  "I'd spend my time looking at the app while I'm commuting on the subway, so I want to confirm that it would work on my phone."  I didn't mention this before, because it's not worth obsessing over for now.
So, I don't think we need a perfect solution for now.  We just need something that's sufficient, and we can improve on it later.
If we go forward with the automatic zoom (#105) -- which is useful on mobile, where you have less screen space -- then automatically opening the sidebar on tap isn't great:  You tap, because you want to see more.  You couldn't even read the labels before you tapped, because they're so small when zoomed out, so you click to zoom in.  But everything gets hidden by the sidebar.  You don't even know what you clicked, so you don't know what the info in the sidebar is for.
So, maybe the simplest thing for now is to not automatically open the sidebar when tapping a node only if you're on a small-screened device.  The user could open the sidebar manually after that, or we could offer a simple feature addition:  If you tap on a node when it's already selected, it opens the sidebar.

Good reasoning, Max.
I disabled the automatic opening for small-screen devices.
I'm not sure about the optional enhancement (click again to open it), so let's keep it simple for now.

Great.  Let's leave this open for now.  I'll create a new issue for the open-on-second-tap idea, so we can consider it later on when we're focussing more on mobile.  After I post that new issue, I'll close this one.

New issue: Method to conveniently open the genes sidebar on mobile #111


https://inferno.healthit.gov/inferno/bOhlG3KtlKE/strict/  -- missing links

The links mentioned are not present:
"For more information of the Conformance Statement, visit these links:
Conformance
Argonaut Conformance Requirements
SMART on FHIR Conformance
"

Hello,
Thanks for reporting this issue. These links should be fixed in our latest build.


Test for lgolding

Hi @lgolding, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla-ppe.dotnetfoundation.org.

TTYL, DNFBOT;


Installing with --auth-jamf-client and --auth-mdm-failover-to-user=ALWAYS Fails

Situation:
Applying config profile
AuthMDMFailoverToUser
ALWAYS
Installing with options below
--auth-jamf-client=any incorrect value
--auth-jamf-secret=any incorrect value
Returns a failed install, even when using the below to attempt to bypass the MDM auth fail as an installation parameter...
--auth-mdm-failover-to-user=ALWAYS
The goal was my attempt to forcefully causing an MDM failover to user to check its working...

This is the expected behavior.
During super installation any errors are reported back to the Jamf log so you can identify installation problems. Most commonly you may have miss-typed the credentials. In this case, in order for the Jamf policy to recognize the error, super must exit and report the error.
Thus, failover only becomes active after super installation is complete.
I understand the desire to test failover, but the appropriate method would be to get super installed properly and then disable the network or rotate the Jamf API secret and run super again.


APP-151 [Objective-C] Basic level Apps: Notifications

@kaa-leeroy add to whitelist

Can one of the admins verify this patch?

@kaa-leeroy test this please

@kaa-leeroy test this please

Can one of the admins verify this patch?

LGTM

@kaa-leeroy test this please


running demo in local server

Sorry to disturb.
I visit this url: https://jeromeetienne.github.io/AR.js/three.js/examples/mobile-performance.html in my chrome with an android phone. It worked excellent.
I download the demo and run in local server.
I visit http://localhost/AR.js/three.js/examples/mobile-performance.html. It shows nothing,no error either.
Can you help and analyse this issue?

only run in https!

Exactly that!
I should do a section on that in the readme
On Mon, Apr 24, 2017, 10:34 AM yjfeng<EMAIL_ADDRESS>wrote:

only run in https!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jeromeetienne/AR.js/issues/47#issuecomment-296576758,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPcImytdFiT7U7bZUqa15_MYfd0qtpxks5rzF59gaJpZM4NCpGt
.

Actually what is the reason first I would like to understand it first about HTTPS ... ?

This is a security requirement from chrome. I will find links and post that
in the readme
On Mon, Apr 24, 2017, 11:46 AM Karan Ganesan<EMAIL_ADDRESS>wrote:

Actually what is the reason first I would like to understand it first
about HTTPS ... ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jeromeetienne/AR.js/issues/47#issuecomment-296598030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPcIqm-r26SVVLEO3gq4bNMKKK9Jgwwks5rzG9bgaJpZM4NCpGt
.

great. I haven't found that different!
Keeping focus on this project!

according from part:browser support.
I have another doubt:
It can't work on Android 4.4.2 above or Android 5?  No browser support yet? even chrome?

Runs on my S3 with Android 4, using Chrome. (Old native Android browser probably not/never)

I still faced a problem when i running the aframe demo.
eg:https://jeromeetienne.github.io/AR.js/aframe/examples/basic.html
I found a loop error in my browser console:
aframe.js:64445 Uncaught TypeError: Cannot read property 'setSize' of undefined
at HTMLElement.value (aframe.js:64445)
at bound (aframe.js:67157)
at tick (aframe-ar.js:1174)
then it did not work either.
anyone knows about the issue?

Here is more info on the https requirement for WebRTC
https://tokbox.com/blog/the-impact-of-googles-new-chrome-security-policy-on-webrtc/

I will look when I reach home
On Tue, Apr 25, 2017, 4:06 PM tcwyjno1<EMAIL_ADDRESS>wrote:

I still faced a problem when i running the aframe demo.
eg:https://jeromeetienne.github.io/AR.js/aframe/examples/basic.html
I found a loop error in my browser console:
aframe.js:64445 Uncaught TypeError: Cannot read property 'setSize' of
undefined
at HTMLElement.value (aframe.js:64445)
at bound (aframe.js:67157)
at tick (aframe-ar.js:1174)
then it did not work either.
anyone knows about the issue?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jeromeetienne/AR.js/issues/47#issuecomment-297060206,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPcIqFvGyHybVtLtoxg6Kel0L8HLf7Jks5rzgvagaJpZM4NCpGt
.

great...  I need get a VPN to visit the link....
We China can not visit lots of  technique website. It's frustrating ..
I have another problem and I have no idea to do.
I made a simple html with only code below:
 <a-scene embedded artoolkit="sourceType: webcam">       <a-video  id="inputVideo" src="roger.mp4" width="0" height="0" position="0 0 -20"></a-video>    </a-scene>
It can open my camera and load the video to play.
I want to do below things:
1.open the camara and scene a picture. eg: https://jeromeetienne.github.io/AR.js/data/images/HIRO.jpg
2.distinguish the jpg.
3.play the video.
I do not konw how to distinguish the picture.
just like demo
https://jeromeetienne.github.io/AR.js/three.js/examples/mobile-performance.html
why i move the jpg .the cube move with the pic. How can the camera distinguish the picture
and draw the cube on it.

@tcwyjno1 ,I think my be "ar-code"  is your need:
https://jeromeetienne.github.io/AR.js/three.js/examples/arcode.html

@yjfeng I want to understand why the cube always stays on the hiro picture in https://jeromeetienne.github.io/AR.js/three.js/examples/mobile-performance.html
Is there any possible that I can change hiro picture to another picture?

@tcwyjno1, I think the maker just as the Base position for element that you want to show, and I don't know how to change the maker to any marker you want,I think Just two marker you can choose.
(如果没有一个基本的面来作为参考，加载进来的3d元素将无法知道以何种方向放在何处，所有基于maker的ar相关的app也都是这样吧。目前我只知道基于web的2个marker图案好像是硬写到js里的，无法改变。以上只是个人理解，不一定正确，我也是刚尝试。)

@yjfeng Thanks,I do think so too. Maybe I can find the base position and change it.(原来同为国人..幸会幸会,我想做的是通过HTML5把手机摄像头打开以后,对准中国电信的标志,然后假设可以识别出这是中国电信的标志(也许不能识别,对吧?),那么就播放一段视频. APP是可以实现,现在就是要用HTML5实现,真让人头大...)
@jeromeetienne ,Is the understanding of @yjfeng  right?

@tcwyjno1 ,不支持苹果，不支持微信，你确认要用吗？

@yjfeng 确认啊..上级命令压死人. 都说了不支持了,还是想实现一下..  我看这个ar.js好像也不支持扫描哦.

@yjfeng 方便加个QQ之类的,问你点问题么

@tcwyjno1 ,qq:790543010

@jeromeetienne, I think the issue @tcwyjno1 is having is not relating to HTTPS in Chrome since the literal hostname localhost (along with the loop back IP of <IP_ADDRESS>) will work fine without a secure connection. I've tested this myself in Chrome 57. I think this is caused by something unrelated.

@yjfeng 确认啊..上级命令压死人. 都说了不支持了,还是想实现一下.. 我看这个ar.js好像也不支持扫描哦.

你好，方便留个联系方式吗？微信或者QQ都可以，我现在使用AR.js也遇到需要翻墙了才能识别出来的问题，能帮我一下吗

@MasonGhost this repository is old. Go to: https://github.com/AR-js-org/AR.js


CommonStaticAnalysis recipe does not change calls to getter/setters on camel casing changes.

What version of OpenRewrite are you using?

I am using

rewrite-static-analysis_ v1.0.8

How are you running OpenRewrite?

I am using the Moderne CLI v 1.1.0.
mod build .
mod run .  --recipe=CommonStaticAnalysis
mod apply . --last-recipe-run
What is the smallest, simplest way to reproduce the problem?

// lombok annotation
@Data
class A {
private String variable_name1;
private String variable_name2;
    // do something
}

class B {
  void setAData (){
     A a = new A();
     a.setvariable_name1("some value 1");
     a.setvariable_name2("some value 2");
   }
}

class C {
  void retreiveAData(A a) {
   String data1 = a.getvariable_name1();
   String data2 = a.getvariable_name2();
  }
}

What did you expect to see?

// lombok annotation
@Data
class A {
private String variableName1;
private String variableName2;
    // do something
}

class B {
  void setAData (){
     A a = new A();
     a.setVariableName1("some value 1");
     a.setVariableName2("some value 2");
   }
}

class C {
  void retreiveAData(A a) {
   String data1 = a.getVariableName1();
   String data2 = a.getVariableName2();
  }
}

What did you see instead?

// lombok annotation
@Data
class A {
private String variableName1;
private String variableName2;
    // do something
}

class B {
  void setAData (){
     A a = new A();
     a.setvariable_name1("some value 1");
     a.setvariable_name2("some value 2");
   }
}

class C {
  void retreiveAData(A a) {
   String data1 = a.getvariable_name1();
   String data2 = a.getvariable_name2();
  }
}

What is the full stack trace of any errors you encountered?

There are no errors while running the CommonStaticAnalysis v1.0.8 recipe.

Are you interested in contributing a fix to OpenRewrite?

moved to correct repository issue: rewrite-static-analysis
https://github.com/openrewrite/rewrite-static-analysis/issues/189