Testing confirm

How do i mock the service.confirm alert? I need to test the function that happens when the 'Yes' button is pressed

I'am not sure that you can do this at all.
But looks like a nice idea to work about.
I'll try to implement it this weekend

@artemsky this is nice project, could you reduce the amount of code and how to print a message without the tittle or even pass your own massage like ng2-flashmessage.

@gbrigens I'll try to do something with it)
Could you create new issue with your suggestion, and add more info (link) about ng2-flashmessage

I saw this module today and I love it, it has more option and functionality that I like. lemme go through it and give you my feedback where you could improve on.

@maxxt Sorry for your waiting. Hand no time, to review.
I found that you can call that action.
When you calling any type of toast it returns self id
Then you can get current toast object with snotifyService.get(id) that represent the following structure
{
   "id":1055795966222,
   "title":"Snotify title!",
   "body":"Lorem ipsum dolor sit amet!",
   "config":{
      "showProgressBar":true,
      "timeout":3000,
      "closeOnClick":false,
      "pauseOnHover":true,
      "buttons":[
         {
            "action": function()
            "text":"Yes",
            "bold":false
         },
         {
            "action": function()
            "text":"No",
            "bold":true
         }
      ],
      "placeholder":"Enter answer here...",
      "bodyMaxLength":80,
      "titleMaxLength":15,
      "backdrop":-1,
      "type":6
   }
}

So you can call you action by accessing this object.
const id = snotifyService.confirm("title", "body", {
      buttons: [
        {text: 'Yes', action: () => doSomeJob(), bold: false},
        {text: 'No', action: () => doAnotherJob(), bold: true},
      ]
    });

snotifyService.get(id).config.buttons[0].action()

For testing, its fine.
But its not recommended to call it pragmatically in production for now. I have an issue, where toast is not hiding, if you calling snotifyService.remove(id) inside action;
Need to fix it.

@artemsky thanks for the reply.
Inside the action I am not passing an ID as a param to remove() and it works just fine.

@maxxt Without id it removes all notifications)

@artemsky Nope, in my case it doesn't.


Display error

Hello, the datetimepicker popover is looking like that:

And when we select a date, the day is always one number less then we have selected, sorry about the english, hope u guys understand. Nice plugin, thank you.

I have the same problem. I have made a JSF page and write directly the value without this component and date and hours are correct. But when I use this component, I view 1 day less and also one hour less.


EPIC: Community contribution

What
Look at how we can enable community contributions for the service manual.
Why
For the service manual to grow and develop to meet its users' needs and maintain consistent, usable NHS products and services, we need teams to raise and discuss issues they face and tell us how things test with users.
Without regular contributions, the service manual will ultimately fail.
Must
Project kickoff

[x] Project kick-off workshop

User research

[x] Plan user research activities based on outcomes of the project kick-off workshop
[x] Complete desk research into online communities, collaboration and contributions

Survey

[x] Plan and distribute community contribution survey
[x] Analyse community contribution survey responses
[x] Present survey analysis to the team

Interviews

[x] Plan community contribution user interviews
[x] Run community contribution user interviews
[x] Analyse community contribution user interviews
[x] Present community contribution user interviews analysis

Usability testing

[x] Plan community contribution usability test

Design
Sense making

[x] Synthesise research findings into actionable artefacts pt 1 [Persona/Behaviour archetype]
[x] Synthesise research findings into actionable artefacts pt 2 [Journey map]

Problem statements

[x] Generate problem statements & how might we (HMW)
[x] Prioritise all the HMW by effort/impact

Hypothesis
Do it now HMW

[x] Brainstorm session to generate ideas against HMW
[x] Brainstorm session to generate ideas against HMW pt II
[x] Matrix & Measurements of top ideas to test against HMW pt I

Do it next HMW

[ ] Brainstorm session to generate ideas against HMW pt III
[ ] Brainstorm session to generate ideas against HMW pt IV
[ ] Matrix & Measurements of top ideas to test against HMW pt II

Prototyping

[ ] Build idea to test
[x] Map out current contribution guidance on the service manual / GitHub repos
[ ] Research & review contribution guidance from other design systems

Measure success

[ ] Conduct & record outcomes of tested idea(s)
[ ] Baseline GitHub contribution figures - to help us measure success

@davidhunter08 - Does the task here need updating to reflect where we are?
Progress - The user research is complete, now to make those into meaningful information for further action

Updated the 'design' section of the epic @davidhunter08

The write up for the user behaviour is done and was played back to the team today 17-Dec-2020
See presentation slide here -> Contribition behaviour archetype II.pptx
Next up: #848 Journey map of all behaviour types

@lucyha - Should we continue to use this Epic or do we create a new one to track things

@Tosin-Balogun we can discuss at our meeting later today but I think we'll need to set-up a new epic


Create python-package-conda.yml

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

Hello @samsung-ro, Please accept license agreement.
Please add PR's description.

Hello @rackspace-sudo, Please add PR description and if possible working images too

Hi @Top-Chief,
I've moved files from your other PR's to this PR.

Moved file to Common PR #10289, Closing this PR to make it less complex.
You can still open this PR if needed.
Thanks,
Prasad

Hello @Top-Chief, Do we have any updates over here 🙂

Hello @Top-Chief,
Can you please respond to the above messages

Hello @Top-Chief, We are waiting for your response


Pulsar 2.0

Pulsar 2.0 is a much faster version of pulsar, it brings some changes to the core API while maintaining backward compatibility as much as possible
Core components are imported via the
from pulsar.api import ...

construct rather than
from pulsar import ...

in pulsar 1.x
The application layer remain similar to pulsar 1.x

Codecov Report

Merging #292 into deploy will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           deploy     #292   +/-   ##
=======================================
  Coverage   84.89%   84.89%
=======================================
  Files         139      139
  Lines       15692    15692
=======================================
  Hits        13322    13322
  Misses       2370     2370

Impacted Files
Coverage Δ

pulsar/cmds/linux_wheels.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27fa136...10b7a10. Read the comment docs.


Adding Discount Test Script

Adding testing script to confirm, discount functionality

I would appreciate a README.md rework. Not needed for this PR, but as a future upgrade.

Removed debug states per request


bugfix: 修复 Windows Agent 安装报错 STATUS_OBJECT_NAME_NOT_FOUND 的问题 (fixed…

… #1732)

Codecov Report

Merging #1733 (05d43ac) into v2.4.0-dev (d7df934) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##           v2.4.0-dev    #1733      +/-   ##
==============================================
+ Coverage       73.63%   73.80%   +0.16%
==============================================
  Files             393      393
  Lines           26452    26453       +1
==============================================
+ Hits            19479    19524      +45
+ Misses           6973     6929      -44

Files Changed
Coverage Δ

apps/backend/agent/solution_maker.py
90.21% <100.00%> (+0.03%)
:arrow_up:

...ackend/components/collections/agent_new/install.py
88.88% <100.00%> (ø)

... and 8 files with indirect coverage changes


diagnostic validation.py stops in _get_provenance_record distinct simulation alias needed

Describe the bug
When I run the diagnostic validation.py with EMAC data (two simulations/experiments, see dataset line below) the diagnostic gives an error when searching for the simulation name (_get_provenance_record). I suppose that the reason is an inconsistency in the handling of datasets with identical names (EMAC == EMAC) in the preprocessor and in the applied diagnostic.
A first attempt to solve this, was to change the delimiter in _disentagle_iden_datasets in shared/validation.py to "" (below # assemble new datasets). In consequence the diagnostic finishes, but results in incorrect labelling of the plots.
Maybe a consistent way / function to produce a distinct simulation alias would be useful all over the ESMValtool for those datasets which can only be separated by their experiment name.

{dataset: EMAC, project: EMAC, ensemble: EMAC, exp: PSRF-2000-03, channel: ECHAM5-selvar-p-mm, raw_name: tm1_ave}
{dataset: EMAC, project: EMAC, ensemble: EMAC, exp: E5RF-2000-03, channel: ECHAM5-selvar-p-mm, raw_name: tm1_ave}

Please attach

E5RF-PSrad_recipe_validation.txt
main_log_debug.txt
I can provide the whole output with preprocessed files if needed or make a setup with different simulations on levante

Hi @FranziskaWinterstein, thanks for raising this issue! Actually, ESMValTool (strictly speaking ESMValCore) already assigns an alias to all datasets, see here. This function uses the keys ('project', 'activity', 'dataset', 'exp', 'ensemble', 'version') to create this alias, so it should work in your case. The alias can be accessed similar to all other facets in the diagnostic (i.e., use dataset['alias'] instead of dataset['dataset'], dataset['project'], etc.).
Would this be a solution here?

Yes, that sounds good. I suppose the preprocessor is using these aliases. It just has to be applied in the validation.py as well. It seems to me, that it is applying its own function, maybe based on an earlier version, where the alias was not available and therefore being inconsistent with the preprocessor. A one point in _get_provenance_record, if I read the code right, it reads the file names of the preprocessed files but does not know about the alias. Maybe _disentagle_iden_datasets can be replaced by that, however, I think the diagnostic must be checked thoroughly.

cheers for raising this @FranziskaWinterstein - I wrote validation.py long ago, when all these fancy aliases and facets were not available. Would you have time to write a fix that includes the new handling please? That would be most appreciated, if not I can do it. Cheers :beer:

@valeriupredoi I can make one attempt, if I fail I come back to you, because I am not too familiar with the newest version of the tool. Just one question about the diagnostic itself: It is designed for two datasets (exper + control) and one observation dataset only, right? Or can I display more than that?

@valeriupredoi I can make one attempt, if I fail I come back to you, because I am not too familiar with the newest version of the tool. Just one question about the diagnostic itself: It is designed for two datasets (exper + control) and one observation dataset only, right? Or can I display more than that?

awesome, good luck and let me know if I can help, please! Indeed it is designed like that: only two CMIP models and one (optional) OBS. It's a very basic diag that a software engineer like myself (not  an atmospheric scientist) could write, but it proved out to be one of the more popular diagnostics :grin:


Separate hardware query interface from domain description

For the partition load balancer (and other balancers in the future) local node information is used to perform the balancing as encapsulated in the hw::node_info type. This improperly ties domain information to details about the node configuration: there may be multiple ranks per node and the number of cores need not be the same as the number of desired threads.
Currently we overwrite the fields of hw::node_info as required, but then the semantics are awry: it no longer describes the node, but instead the domain.
Proposal:

hw::node_info is renamed to domain_info; the num_cpu_cores field is renamed num_threads.
hw::get_node_info is renamed or removed (providing instead top-level functions for retrieving the number of local cpu cores and GPUs).
A domain_info constructor queries the global (or in the future, contextual) thread information and hardware gpu count to make the default use case straightforward.

With domain_info renamed to proc_allocation, this is resolved in PR #531.


How would you implement Concatenation like CNN using MLP

How would you replicate concatenated/merged layers?

How would you replicate concatenated/merged layers?

Hi! I am not certain what exactly do you mean. If you simply want to concatenate outputs from conv layers, you do not need any modifiications in the conv layer implementation. Could you maybe provide an example of the functionality you want with the usual nn.Conv2d?


Base Pipeline in Rasa Init with Rasa==2.0.0.a1 Comments Out config.yml

I'm playing around with Rasa==2.0.0.a1. This is what happens when you run rasa init.
python -m rasa init
Welcome to Rasa! 🤖

To get started quickly, an initial project will be created.
If you need some help, check out the documentation at https://rasa.com/docs/rasa.
Now let's start! 👇🏽

? Please enter a path where the project will be created [default: current director
y] .
? Directory '/Users/vincent/Development/breakoutbot' is not empty. Continue?  Yes
Created project directory at '/Users/vincent/Development/breakoutbot'.
Finished creating project structure.
? Do you want to train an initial model? 💪🏽  Yes
Training an initial model...
The configuration for policies and pipeline was chosen automatically. It was written into the config file at './config.yml'.
Training NLU model...
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/__main__.py", line 120, in <module>
    main()
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/__main__.py", line 109, in main
    cmdline_arguments.func(cmdline_arguments)
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/cli/scaffold.py", line 206, in run
    init_project(args, path)
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/cli/scaffold.py", line 118, in init_project
    print_train_or_instructions(args, path)
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/cli/scaffold.py", line 58, in print_train_or_instructions
    args.model = rasa.train(domain, config, training_files, output)
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/train.py", line 58, in train
    nlu_additional_arguments=nlu_additional_arguments,
  File "uvloop/loop.pyx", line 1456, in uvloop.loop.Loop.run_until_complete
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/train.py", line 114, in train_async
    nlu_additional_arguments=nlu_additional_arguments,
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/train.py", line 207, in _train_async_internal
    old_model_zip_path=old_model,
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/train.py", line 246, in _do_training
    additional_arguments=nlu_additional_arguments,
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/train.py", line 541, in _train_nlu_with_validated_data
    **additional_arguments,
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/nlu/train.py", line 75, in train
    trainer = Trainer(nlu_config, component_builder)
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/nlu/model.py", line 142, in __init__
    components.validate_requirements(cfg.component_names)
  File "/Users/vincent/Development/breakoutbot/venv/lib/python3.7/site-packages/rasa/nlu/components.py", line 59, in validate_requirements
    f"Not all required importable packages are installed. "
Exception: Not all required importable packages are installed. To use this pipeline, you need to install the missing dependencies. Please install the package(s) that contain the module(s): spacy

When inspecting the config.yml I now see this;
# Configuration for Rasa NLU.
# https://rasa.com/docs/rasa/nlu/components/
language: en

pipeline:
# # No configuration for the NLU pipeline was provided. The following default pipeline was used to train your model.
# # If you'd like to customize it, uncomment and adjust the pipeline.
# # See https://rasa.com/docs/rasa/nlu/choosing-a-pipeline/ for more information.
#   - name: SpacyNLP
#   - name: SpacyTokenizer
#   - name: SpacyFeaturizer
#   - name: RegexFeaturizer
#   - name: LexicalSyntacticFeaturizer
#   - name: CountVectorsFeaturizer
#   - name: CountVectorsFeaturizer
#     analyzer: char_wb
#     min_ngram: 1
#     max_ngram: 4
#   - name: DIETClassifier
#     epochs: 100
#   - name: EntitySynonymMapper
#   - name: ResponseSelector
#     epochs: 100

# Configuration for Rasa Core.
# https://rasa.com/docs/rasa/core/policies/
policies:
# # No configuration for policies was provided. The following default policies were used to train your model.
# # If you'd like to customize them, uncomment and adjust the policies.
# # See https://rasa.com/docs/rasa/core/policies/ for more information.
#   - name: MemoizationPolicy
#   - name: TEDPolicy
#     max_history: 5
#     epochs: 100
#   - name: MappingPolicy
#   - name: FormPolicy

This leaves me with the following;

It seems like we've introduce spacy to be part of the standard pipeline. If this is intentional then we should add it as a mandatory install when installing Rasa as opposed to an optional install. If it isn't intentional we should remove spaCy as a component from the standard pipeline.
Do we want to comment out the config.yml? It's somewhat confusing to have a model commented out here while it is being used.

Versions
> rasa --version
Rasa Version     : 2.0.0a1
Rasa SDK Version : 2.0.0a1
Rasa X Version   : None
Python Version   : 3.7.7 (v3.7.7:d7c567b08f, Mar 10 2020, 02:56:16)
Operating System : Darwin-19.3.0-x86_64-i386-64bit
Python Path      : /Users/vincent/Development/breakoutbot/venv/bin/python

One thing about the spaCy dependency as well. You might need to download a language model from spaCy as well if you'd like it to work. This can get the initial modelling pipeline to become somewhat heavy-weight.

Thanks for checking out the alpha 👍

is duplicate of https://github.com/RasaHQ/rasa/issues/6326
That's to indicate that it was injected by the auto config. Do you haev other ideas? And could you please rename the PR so it reflects that this only refers to part 2) ?

If it is injected by the auto config that's fine, but why add the comments? Commenting (be it yml or python) suggests to me that something has been turned off. I now see a config file where most of the settings seem turned off but is still able to generate a model during rasa init. That, at least to me, was confusing.

What would be alternatives for you?

No comments at all: Confusing as the user doesn't know which config was used to train the model
Adding config without comments: We don't know if the config was suggested by Rasa Open Source or if they user supplied it. We need to know which one, as the former would mean we could replace it with better / other suggestions.

I might not have all the information that went into the decision making for the auto-config. But I wonder ... Why don't we have the auto-config generate a config.yml file? As in, the pipeline that is used to train the model when we run rasa init, why isn't that in the config.yml file that is generated?

The main idea of the Suggested Config feature was that in the beginning users don't have to bother with the config.yml.

If we already have an opinion of what the best pipeline is, why not place that as the configuration without commenting parts out?

This is what Tobias' point 2. in his last reply refers to. I'll try to explain it more:
If the Suggested Config feature would automatically generate a config.yml without commenting out the configuration, the generated file is indistinguishable from a config.yml that the user might have written themselves.
This would a problem when training new models later on: If the pipeline in the config.yml was provided by the user, we have to keep it and not overwrite it with any suggested configuration. But if the pipeline was automatically put there by the Suggested Config feature, we want to run this automation again every time a new model is trained (overwriting the result of the previous Suggested Config run), such that potential improvements to the suggested pipeline are automatically included.
Commenting the automatically suggested configuration out allows us to distinguish between these two cases.

This sentence from the logs does suggest that we've got a working file that is generated.

Yes, and we do. The generated file works: With each rasa train, the Suggested Config is run again, so the training will automatically use our default pipeline (and write it into the config.yml as comments, overwriting the old comments).


Insert text - Terminal (Atom 1.14.1)

Hello! I just recently installed the 'Terminal-Plus' package and unfortunately I can not insert text via my keyboard, nothing is written.

I think this package is no longer maintained (last realise on Nov 26, 2015)
Try to use https://atom.io/packages/termination


My Coroutine suddenly started to load on each rerender, any changes?

I was working for other part of my App and today started Dioxus UI.
And realized that Coroutine does not keep it's state between renders.
Any breaking changes?

There were some breaking changes in 0.4, but coroutines should work the same. Can you post the code that you found caused this issue?

The code where error happens:
let signal = use_coroutine_handle::<Signal>(cx).unwrap();

The error:
web_ui_new.js:548 panicked at src/ui/leftbar/public_workers_list.rs:46:57:
called `Option::unwrap()` on a `None` value

(anonymous) | @ | web_ui_new.js:548
-- | -- | --
  | logError | @ | web_ui_new.js:252
  | imports.wbg.__wbg_error_f851667af71bcfc6 | @ | web_ui_new.js:545
  | $console_error_panic_hook::error::h98176e1eb99b42a3 | @ | web_ui_new_bg.wasm:0x3c9290
  | $console_error_panic_hook::hook_impl::h7651885b11676d73 | @ | web_ui_new_bg.wasm:0x29d646
  | $console_error_panic_hook::hook::h449fb69308b80b3a | @ | web_ui_new_bg.wasm:0x40e536
  | $core::ops::function::Fn::call::hc6e3583df8385e33 | @ | web_ui_new_bg.wasm:0x3f63cd
  | $std::panicking::rust_panic_with_hook::h16f4a3f1bc99a7a8 | @ | web_ui_new_bg.wasm:0x3464d4
  | $std::panicking::begin_panic_handler::{{closure}}::h52956d8279f8ee18 | @ | web_ui_new_bg.wasm:0x3820b5
  | $std::sys_common::backtrace::__rust_end_short_backtrace::h361d82971966b5e8 | @ | web_ui_new_bg.wasm:0x41e203
  | $rust_begin_unwind | @ | web_ui_new_bg.wasm:0x3d03cf
  | $core::panicking::panic_fmt::hc8d244d75a61c60d | @ | web_ui_new_bg.wasm:0x409415
  | $core::panicking::panic::hf0089cc8d90e5a39 | @ | web_ui_new_bg.wasm:0x3f4ef2
  | $core::option::Option<T>::unwrap::hfd0082385e2d81ff | @ | web_ui_new_bg.wasm:0x3ac88f
  | $web_ui_new::ui::leftbar::public_workers_list::components::Worker::he57bd8dcfc93e5cd | @ | web_ui_new_bg.wasm:0x20f661
  | $<dioxus_core::any_props::VProps<P> as dioxus_core::any_props::AnyProps>::render::{{closure}}::h2defddc86cef81dc | @ | web_ui_new_bg.wasm:0x169bac
  | $core::ops::function::FnOnce::call_once::h53cd0f1f3d1f577d | @ | web_ui_new_bg.wasm:0x3dffc6
  | $<core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::hc614f16b7b02ef1d | @ | web_ui_new_bg.wasm:0x3f94a8
  | $std::panicking::try::do_call::hd32eef172f3c5780 | @ | web_ui_new_bg.wasm:0x351d82
  | $std::panicking::try::heeaaae6fb4a57f8a | @ | web_ui_new_bg.wasm:0x2fe14f
  | $std::panic::catch_unwind::h4854a0b4537ef7ee

That is likely related to https://github.com/DioxusLabs/dioxus/issues/1350. Does https://github.com/DioxusLabs/dioxus/pull/1351 fix the issue?


ref: move specific accelerator code x/n

Hello @williamFalcon! Thanks for opening this PR.

In the file pytorch_lightning/accelerators/base_backend.py:

Line 167:13: W292 no newline at end of file

Do see the Hitchhiker's guide to code style


Update Timeline “2022-06-16t15-40-38-831z-campaign”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
4d2a2ea0be7e1f3db9d8c5087b0432474416c578

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/6338adde15de03000adcc1cd


Refined Storage doesn't autocraft mekanism induction cells

Issue description:
I want to make a autocrafting recipe for my induction cells, but the Crafting Manager says that i am missing the energy cubes. Even if i have the amount to make all induction cells it still says the same.
What happens:
I try to autocraft induction cells. Crafting Manager says i dont have any Energy Cubes
What you expected to happen:
I successfully autocraft the cells
Steps to reproduce:
1.Make the Energy Cube recipe
2.Make a Induction Cell recipe
3.Try to autocraft the Induction Cell
Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: forge-<IP_ADDRESS>47
Refined Storage: refinedstorage-1.6.15.jar

Does this issue occur on a server? [no]

Duplicate of #2334 , #2064
Make the recipe by hand and disable oredict to make it work.


Q-sphere phase colors does not match IQX phase colors

Information

Qiskit Terra version: master
Python version:
Operating system:

What is the current behavior?
As pointed out by @HwajungKang, it is a bit tricky to figure out that the color wheels are more or less rotated by pi.  It is even harder to decode due to the implicit phase re-normalization in the Qiskit Q-sphere that is not mentioned anywhere:
https://github.com/Qiskit/qiskit-terra/blob/dc3a2a667b8dc22512ca409ecae347d8dbdd944c/qiskit/visualization/state_visualization.py#L761
Qiskit:

IQX:

Steps to reproduce the problem
What is the expected behavior?
Suggested solutions

@nonhermitian Can I have a go at this? I am still pretty new and would to try out some smaller issues.

@abhobe sure.

@nonhermitian The color scheme for IQX gate color scheme is not enabled by default and the original scheme is kept when looking at #5063. Do want to the same structure as #5063 or just keep IQX as default.

And do you have the official hex colors?

@abhobe are you still working on this? can I try this one? @1ucian0

@alejomonbar Sure I will try to work on this, but If you find a solution feel free to create a PR. We can work on this together if you would like to.

Sure @abhobe. I was looking at the code. It's supposed to be a new input argument as style or something for the qsphere as style = 'iqx' and display the colormap for "iqx"? @1ucian0

@alejomonbar I am not sure about that in the exact terms of how the code needs to execute. But that can easily be fixed in the end. The function that needs to be changed would be in the qiskit.visualization.state_visualization.py module. The exact function, I will leave to you to figure it out. If you have any other questions, feel free to contact me in slack under the handle @abhobe

I think simply rotating the colorwheel by pi is good enough. The exact color match is probably not needed. But having phase match colorwise is probably a good thing to have.

@nonhermitian what do you think about the solution https://github.com/Qiskit/qiskit-terra/pull/5212?


After a partial downgrade from >=11.0, the browser nag remains (and the browser is unusable from a partial downgrade from 11.1/11.2 where the browser was not downgraded)

This happened when I downgraded a New3DSXL on 11.0 by downgrading its NFIRM to 10.4 with dgtool, making a NAND backup, tinyformatting, and then trying the downgrade from oot3dhax. The first time, the system crashed to the Nintendo Error screen when trying to install<PHONE_NUMBER>008F02.cia (it partialed). After powering off, and powering back on, I tried to use browserhax but the browser nag (which I had before the downgrade) remained, so I had to use oot3dhax with the New3DS 9.2 payload to get back into HBL and downgrade again (the downgrade succeeded the second time). However, people without a primary or secondary cart exploit downgrading from 11.1 or 11.2 (with 10.4 NFIRM) would be stuck here, as the iptable/browser nag bypass doesn't work on the 11.1/11.2 browser. People on 11.0 who used the iptable method successfully would still be able to use it, unless they got the browser nag at some point.
Conclusion: If a 9.2 partial downgrade does not downgrade the 11.2/11.1 browser, people will need a primary or secondary cart exploit to get back into HBL and complete the partial downgrade. If they downgraded from 11.0 and do not have the browser nag, they can use the iptable method with the 9.2 payload on their SD card as already directed in the guide. However, if they already have the browser nag on 11.0, they will need a secondary or primary cart exploit to get back into HBL to complete the downgrade, as TinyFormat removes secondary exploits stored on the SD card (like steelhax).

No longer matters because soundhax.

This happened to me, I have a partial 9.2 and soundhax does not work anymore.


Overscroll indicator for MaterialList

Specifying clampsOverscrolls:true for MaterialList causes it to limit scrolling to the list's contentExtent. Attempting to drag the list past the ends displays an "overscroll indicator": an emphemeral translucent arc that looks roughly like what many native Android applications display on overscroll.
Overscroll indicators and TBD "pull-to-refresh" progress indicators are displayed with a ScrollableListPainter. Scrollbars are already displayed that way.
Updated the gallery "list" demo to use a MaterialList.
Added dragStart() and dragEnd() methods to ScrollableListPainter.

flutter screenshot for glorious pictures in pull requests? :D

flutter screenshot for glorious pictures in pull requests? :D

LGTM

@HansMuller Very pretty, thank you. :D


python311Packages.python-rtmidi: 1.5.7 -> 1.5.8

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.python-rtmidi is: A Python binding for the RtMidi C++ library implemented using Cython
meta.homepage for python311Packages.python-rtmidi is: https://github.com/SpotlightKid/python-rtmidi
meta.changelog for python311Packages.python-rtmidi is: https://github.com/SpotlightKid/python-rtmidi/blob/1.5.8/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.5.8 with grep in /nix/store/0r8ygvjyhmvdv6wkghzrjsnc8gzcsj4n-python3.11-python-rtmidi-1.5.8
found 1.5.8 in filename of file in /nix/store/0r8ygvjyhmvdv6wkghzrjsnc8gzcsj4n-python3.11-python-rtmidi-1.5.8

Rebuild report (if merged into master) (click to expand)

10 total rebuild path(s)

10 package rebuild(s)

First fifty rebuilds by attrpath
cantoolz
ledfx
open-stage-control
pianotrans
python310Packages.mido
python310Packages.piano-transcription-inference
python310Packages.python-rtmidi
python311Packages.mido
python311Packages.piano-transcription-inference
python311Packages.python-rtmidi

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0r8ygvjyhmvdv6wkghzrjsnc8gzcsj4n-python3.11-python-rtmidi-1.5.8 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.python-rtmidi https://github.com/r-ryantm/nixpkgs/archive/24f7f8375d11622278016d118aa319a84493bb0e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/24f7f8375d11622278016d118aa319a84493bb0e#python311Packages.python-rtmidi

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0r8ygvjyhmvdv6wkghzrjsnc8gzcsj4n-python3.11-python-rtmidi-1.5.8
ls -la /nix/store/0r8ygvjyhmvdv6wkghzrjsnc8gzcsj4n-python3.11-python-rtmidi-1.5.8/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @mweinelt for testing.

Result of nixpkgs-review pr 269075 run on x86_64-linux 1

19 packages built:

cantoolz
cantoolz.dist
ledfx
ledfx.dist
open-stage-control
pianotrans
pianotrans.dist
python310Packages.mido
python310Packages.mido.dist
python310Packages.piano-transcription-inference
python310Packages.piano-transcription-inference.dist
python310Packages.python-rtmidi
python310Packages.python-rtmidi.dist
python311Packages.mido
python311Packages.mido.dist
python311Packages.piano-transcription-inference
python311Packages.piano-transcription-inference.dist
python311Packages.python-rtmidi
python311Packages.python-rtmidi.dist


[feature] real time filter preview results within the edit>filters and triggers menu

Version and OS
v0.40.0, lin/docker.
feature request
need real time or on demand preview of results of the filtering being applied to page as we adjust the filter/triggers.  As I make small adjustments, I'd like positive feedback to how it will act or what results would be. Currently, I have to save my filter (not knowing if it will work), then go to the main screen and hit recheck, then click DIFF. (~1-2mintues, then iterate again if its not what I want).
Describe the solution you'd like
Cache the current page, as the filter is being applied, you will see real time filter.
or use an integration of test your xpath (test your json, test your jq, etc) + current page's data

ticket#1068


[feature] Can we implement Drupal multisite (more than one url per docker container)?

Seems LAGOON_ROUTE only supports one url, is it possible to have comma delimited (any other character) list of URLs that the sites can be reached on?
https://github.com/pygmystack/pygmy/blob/main/service/library/status.go#L134

Unfortunately, I'll need to refer you to this one.
We can't support it in Pygmy unless it's supported in the images Pygmy uses.
https://github.com/amazeeio/docker-haproxy/pull/3

Would you care to weigh in @tobybellwood ?
I'm not completely sure of your positioning with this feature...

We should be able to recreate that old PR in the right repo for the images. Will transfer and have a look


Fix displaying demographics in rectangle select tooltip

Overview

Testing Instructions

Use the rectangle select on the project screen

Closes #236

@maurizi Should this be for #324 instead of #236 ?

@pcaisse Yes... yes it should.


HTML

HTML
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that i can easily find and read information
##Acceptance Criteria
Given a prework study guide website
When I visit the website in my browser
Then i see four boxes titles HTML, CSS, GIT and Javascript with associated notes listed

updated


util/log,cli: channel abstraction; new configuration system

PR: https://github.com/cockroachdb/cockroach/pull/57134
From release notes:

A new command cockroch debug check-log-config prints out the logging configuration that results from the provided combination of --store, --log, and other logging-related flags on the command line. [#57134][#57134] {% comment %}doc{% endcomment %}

Closed by #10273.


Mind adding a short section on how to build the plugin to the README?

For example I don't know at first glance if I'd have to build AdvancedSessions even if I only wanted to use AdvancedSessionsSteam.
Adding a short section in the README outlining what has to be added to the ProjectName.build.cs file would be aweseome.

@Zenahr you don't need to add it to the build.cs if using it as a BP plugin, only if trying to call into it from code (which you shouldn't be doing generally). Its a plugin to expose what already exists in C++ to BP.
I did have an installation notice on the old repo, must have forgotten to port it over.

@Zenahr you don't need to add it to the build.cs if using it as a BP plugin, only if trying to call into it from code (which you shouldn't be doing generally). Its a plugin to expose what already exists in C++ to BP.
I did have an installation notice on the old repo, must have forgotten to port it over.

I was trying to add it to a cpp based project and if I remember correctly it said the modules had to be rebuilt and I got compilation errors.

I was trying to add it to a cpp based project and if I remember correctly it said the modules had to be rebuilt and I got compilation errors.

They have to be built in visual studio yes, but you don’t have to add them to build.cs, just add them to the plugins folder and regenerate your project files and compile.
From: Zenahr Barzani<EMAIL_ADDRESS>Sent: Wednesday, January 27, 2021 12:18 AM
To: mordentral/AdvancedSessionsPlugin<EMAIL_ADDRESS>Cc: Joshua (MordenTral) Statzer<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [mordentral/AdvancedSessionsPlugin] Mind adding a short section on how to build the plugin to the README? (#6)
I was trying to add it to a cpp based project and if I remember correctly it said the modules had to be rebuilt and I got compilation errors.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/mordentral/AdvancedSessionsPlugin/issues/6#issuecomment-768037211 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABC3YT4VQL57PMSSZJDGPPDS36OXPANCNFSM4WQREVFQ .  https://github.com/notifications/beacon/ABC3YT26PQKGXWUCLSD54MDS36OXPA5CNFSM4WQREVF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFXDVCWY.gif

They have to be built in visual studio yes, but you don’t have to add them to build.cs, just add them to the plugins folder and regenerate your project files and compile.
From: Zenahr Barzani<EMAIL_ADDRESS>Sent: Wednesday, January 27, 2021 12:18 AM
To: mordentral/AdvancedSessionsPlugin<EMAIL_ADDRESS>Cc: Joshua (MordenTral) Statzer<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [mordentral/AdvancedSessionsPlugin] Mind adding a short section on how to build the plugin to the README? (#6)
I was trying to add it to a cpp based project and if I remember correctly it said the modules had to be rebuilt and I got compilation errors.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/mordentral/AdvancedSessionsPlugin/issues/6#issuecomment-768037211 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABC3YT4VQL57PMSSZJDGPPDS36OXPANCNFSM4WQREVFQ .  https://github.com/notifications/beacon/ABC3YT26PQKGXWUCLSD54MDS36OXPA5CNFSM4WQREVF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFXDVCWY.gif


SDK doesn't work across multiple event loops

Package Name: azure-identity
Package Version: 1.15.0
Operating System: Windows
Python Version: 3.8

Describe the bug
When using the SDK across multiple event loops the credential is closed, resulting in request failure.
NOTE: The client is still open, and there is no way to tell besides the error that the event loop is closed.
To Reproduce
Using Azure App Configuration:
import os
import asyncio
from azure.appconfiguration.aio import AzureAppConfigurationClient
from azure.identity.aio import DefaultAzureCredential

ENDPOINT = os.environ.get("AZURE_APPCONFIG_ENDPOINT")
credential = DefaultAzureCredential()

async def main():
    global AZURE_APP_CONFIG
    AZURE_APP_CONFIG = AzureAppConfigurationClient(ENDPOINT, credential)
    message = await AZURE_APP_CONFIG.get_configuration_setting(key="testapp_settings_message")
    print(message.value)

async def getSecond():
    global AZURE_APP_CONFIG
    message = await AZURE_APP_CONFIG.get_configuration_setting(key="testapp_settings_message")
    print(message.value)

async def end():
    global AZURE_APP_CONFIG
    print("Closing connection")
    await AZURE_APP_CONFIG.close()
    await credential.close()

asyncio.run(main())
asyncio.run(getSecond())
asyncio.run(end())

Result:
RuntimeError: Event loop is closed
Expected behavior
The azure SDK should be able to be used in web frameworks such as Flask when in async each request is it's own event loop.

@pvaneck, I gave that as the simple sample but if you try to use the SDK in a Flask or Django app it acts the sample I gave.


Web Export

Are there any viable solutions to export to web? Or is all hope lost until korge is good enough? Even if it was though, you have to sacrifice all the cool java libraries built over the years for kotlin multiplatform. I've heard rumours about teavm or something called dragome but I don't know much about them.

TeaVM is an alternative to GWT, but I think the LibGDX backend is just a proof of concept rather than a working solution. You can go through the forks to see if anyone picked up after the TeaVM author. As a side note, TeaVM itself is a really cool project, probably with the highest quality among similar libraries.
JTransc transpiles JVM bytecode to Haxe and then to Flash, JavaScript and a couple other platforms. Again, I'm not sure how feature-complete this is, but it's worth a try. I think the author moved on to create Korge, so there's that.
xpenatan maintains a few web backends, with Dragome backend being the most feature-complete (I think). It might be your best bet as far as working solutions go, but I believe the code quality is just not the best. For a while it used to be an Eclipse project without Maven/Gradle setup, mostly copying and modifying existing GWT sources without tests, refactoring, etc. Dragome never took off and I don't think it's actively maintained anymore.

One thing to note though is that web games written in other languages than JS/TS tend to be harder to debug and more error-prone. It's cool that you can write your game once and export for multiple platforms, but realistically - even with pure Java and no complex LibGDX extensions - supporting the web is a pain. I don't think I've ever had a worse experience debugging my code than with GWT.
LibGDX and KTX are the best fit for mobile games. Sadly, if you want to focus on web games, I think JS frameworks are your best bet. TypeScript is a surprisingly good language.

Thanks for the detailed overview. I just recently learned that web games are stuck to being single threaded even if I did find a solution, which is a necessity for my game. It looks like I just have to give up on supporting web, which is kind of a relief tbh, I was not looking forward to all the issues that come with supporting web.

Well, there are web workers that you could use, but since they cannot share state like Java threads, you'd probably have to rewrite significant portions of your game. You can also simulate "green threads" or coroutines with async operations, similar to how KotlinJS/TeaVM achieve this despite JS being single-threaded, but obviously that isn't true parallel processing.

It looks like I just have to give up on supporting web, which is kind of a relief tbh, I was not looking forward to all the issues that come with supporting web.

In my experience, if you want to support the web, you should start with the web, as it's the most limited platform by far. Even with plain Java + LibGDX you need to constantly track GWT compilation and performance if you don't want to end up with an unplayable application.

I'm currently working on this, using Bytecoder and WebGl. I'm working on it until 30 January 2021(my traineeship for Computer Science Bsc degree). Check my project and latest findings here: https://github.com/squins/libgdx-wasm-with-bytecoder
We really would like to have a LibGDX backend for web that can be used with Kotlin. That is the goal :smile:.
I am now working on getting audio and WebGl to work.

@CoenRijsdijk That's a very cool project, keep us updated!


New version: JetBrains.PyCharm.Professional.EAP version 231.6471.3

Result: Installation Failed

Manifest
Add/Remove Programs

Name
PyCharm Professional Edition (EAP)

Version
231.6471.3

Publisher
JetBrains s.r.o.

ProductCode

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 5729
Microsoft Reviewers: Open in CodeFlow

/azp run

/azp run


New Command: aad approleassignment remove. Closes #1872

New Command: aad approleassignment remove that deletes an app role assignment for the specified Azure AD Application Registration. Closes #1872

Awesome 🚀
Thanks @aakashbhardwaj619 we will review shortly 👏

Merged manually. Thank you! 👏


Fixing my fix... fumbled a little.

This one is correct - please ignore my previous edit. MD editor in GitHub not so much... ;P

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/display/ImplementingRenderer.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[c++14] absl::make_unique --> std::make_unique

@ctiller Just out of curiosity, why this change is made at this moment? I believe std::make_unique<> has been introduced since C++11?


Feature: let dledger complete responseFutures after applying entries to statemachine

let dledger complete responseFutures after applying entries to statemachine

@RongtongJin please take a look

LGTM～


EIP1559 strict balance validation

This PR clears up the accounting and validation related to max_fee_per_gas and base_fee in order to match the EIP1559 spec.
Essentially this PR swaps the checks done by validation and during execution.
Before:

validation checked sender's balance against base_fee (plus applicable tip)
execution deducted initial fee based on max_fee_per_gas

After this PR:

validation checks sender's balance against max_fee_per_gas
execution deducts initial fee based on base_fee (plus applicable tip)

TODO:

[ ] One thing I would like to be sure of is that a txn with max_fee_per_gas < base_fee can't be included -- should execute() check this or should it assume that this is properly checked during validation?
[ ] Additional tests?
[ ] Other TODOs in code comments

@sorpaas Conflicts resolved :+1:


fix: narrow generated API types

The lack of required properties in the Swagger yaml results in the generated types to have unnecessary optional properties, which results in avoidable conditional checks on the applications side. This PR fixes that issue on the "supply side" for a few of the most impactful properties, but does not remove the conditional checks.

Looks like there are annotations we can add to the proto files as seen here: (https://grpc-ecosystem.github.io/grpc-gateway/docs/mapping/customizing_openapi_output/). Updated the PR.

One small issue I'm running into that is somewhat unrelated:
Is it possible to change the type of the dimension_value field to a string instead of the broader google.protobuf.Value? This resulted in some type errors via the linting, but I'm not sure how or why this would be returned as anything other than a string.
Relatedly, this is being used to populated the list of possible dimension values when adding a filter, though it doesn't seem designed for that. Is there a better way to get a list of these values (max 100) filtered by a search parameter?

Looks like there are annotations we can add to the proto files as seen here: (https://grpc-ecosystem.github.io/grpc-gateway/docs/mapping/customizing_openapi_output/). Updated the PR.

Yeah this looks promising. Would it be satisfactory for you if we initially limited it's use to the api.proto files, especially the response types?

One small issue I'm running into:
Is it possible to change the type of the dimension_value field in MetricsViewComparisonRow to a string instead of the broader google.protobuf.Value? Changing it resulted in some type errors via the checks, but I'm not sure how or why this would be returned as anything other than a string. Want to hold off on fixing the errors if there's a reason I'm missing for using the other type.

Dimension values can also be integers or bools IIRC (and a number of other types from the SQL side, though those would become strings in the API response type).

Relatedly, this MetricsViewComparisonRow type (and related query) is being used to populate the list of possible dimension values when adding a filter, though it doesn't seem to be designed for that considering it's also pulling in measure data. Is there a better way to just get a plain list of these values (max 100) filtered by a search parameter?

Yeah, you can use the MetricsViewAggregation API for that – it doesn't require requesting a measure.
In fact, the MetricsViewAggregation API can do everything that the MetricsViewComparison, MetricsViewTotal and  MetricsViewToplist APIs can do, and should be preferred over those (which will eventually be deprecated). We're also working on making the MetricsViewAggregation API support the use cases that MetricsViewTimeSeries supports (namely supporting null filling of missing time bins).


Plotting Spaced out Sparsity

Changes

Reduce every matrix to 32x32
For every 2x2 block, count how many zeros and if >= 3, replace block with 1, else 0
Multiply the amount of nonzero elements in the 32x32 matrix by percentage sparsity
Plot this metric against the time for every algorithm

The plot seems to have failed.


chore: Add filters and words so full repo passes cSpell

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask<EMAIL_ADDRESS>(or NullMDR in github) for additional help.

I didn't update the CI workflow in script/spellcheck.ts because the filtering from the util is also used by the prettier task and would cause a bunch of other formatting changes

I've cherry-picked a few of the "functional" pieces in here to separate PRs since this larger change seems stalled

I've cherry-picked a few of the "functional" pieces in here to separate PRs since this larger change seems stalled


go swagger generated code is not fully golint-able

given
{
  "consumes": [
    "application/x-www-form-urlencoded"
  ],
  "info": {
    "name": "formData test"
  },
  "paths": {
    "/testing/{client_id}": {
      "get": {
        "parameters": [
          {
            "in": "path",
            "name": "client_id",
            "type": "integer"
          }
        ],
        "responses": {
          "200": {
            "description": "Success message"
          }
        }
      }
    }
  },
  "produces": [
    "application/json",
    "application/json; charset=utf-8"
  ],
  "swagger": "2.0"
}

in swagger.json the generated code is tiny little bit golint incompatible:
$ swagger generate client
2016/04/18 11:57:17 building a plan for generation
2016/04/18 11:57:17 planning definitions
2016/04/18 11:57:17 planning operations
2016/04/18 11:57:17 grouping operations into packages
2016/04/18 11:57:17 planning meta data and facades
2016/04/18 11:57:17 rendered client parameters template: operations.GetTestingClientIDParameters
2016/04/18 11:57:17 rendered client responses template: operations.GetTestingClientIDResponses
2016/04/18 11:57:17 rendered operation group client template: operations.OperationsClient
2016/04/18 11:57:17 rendered client facade template: client.RestClient
$ golint ./...
client/operations/get_testing_client_id_parameters.go:31:49: method parameter clientId should be clientID

This is because id is "common initialism" as it's called in golint's source code. Maybe go swagger can copy the code as lintName is not exported. Or even better if golint's lintName gets exported and then is used by go swagger.

While investigating it turn out that go swagger already has a copy of the code and the problem is just in case of method arguments in the helper 'With*' case.


[FEATURE] Embed quickstart YouTube video into quickstart guide

Description
At the top of the quickstart docs it would be good to embed the YouTube video for it https://linkfree.eddiehub.io/docs/quickstart
YouTube video https://www.youtube.com/watch?v=05HEeCQSKRE
Screenshots
No response
Additional information
No response

I want try it Eddie, can you assign me?

Sure @Ertan222

Hey  @eddiejaoude  Can i embed the video in the documentation file as i was doing so but apparently it's already assign to someone.  Please allow me if i can make changes.

Sure @Ertan222

Can i work on this ? @eddiejaoude

@sidharthviz please see the comments and timeline above, it was already requested recently and assigned

@sidharthviz please see the comments and timeline above, it was already requested recently and assigned

Okay..got it.

@eddiejaoude I am having a problem with tests. Don't know what is the reason and while having a problem in my local repo, maybe ı shouldn't open a PR for production. Also, this problem going to block my feature tests. Maybe you should assign to another person. Sorry for that, after ı fix the problem, going to contribute again :)

can i work on it ? @schmelto

@eddiejaoude I am having a problem with tests. Don't know what is the reason and while having a problem in my local repo, maybe ı shouldn't open a PR for production. Also, this problem going to block my feature tests. Maybe you should assign to another person. Sorry for that, after ı fix the problem, going to contribute again :)

Hey @Ertan222 meanwhile you can try with Gitpod setup that might work maybe for you.

@eddiejaoude I am having a problem with tests. Don't know what is the reason and while having a problem in my local repo, maybe ı shouldn't open a PR for production. Also, this problem going to block my feature tests. Maybe you should assign to another person. Sorry for that, after ı fix the problem, going to contribute again :)

Hey @Ertan222 you can try with Gitpod setup that might work maybe for you.

I forget the gitpod, you are right. Thanks, trying right now :)

There was a problem with test and Dan fixed it. I am going work on it again.

@eddiejaoude I am having a problem with tests. Don't know what is the reason and while having a problem in my local repo, maybe ı shouldn't open a PR for production. Also, this problem going to block my feature tests. Maybe you should assign to another person. Sorry for that, after ı fix the problem, going to contribute again :)

Hey @Ertan222 you can try with Gitpod setup that might work maybe for you.

I forget the gitpod, you are right. Thanks, trying right now :)

Great..👍🏼

Closing as Pull Request has been merged.


Vivaldi, it does not work

I use Firefox, Vivaldi, Iridium together.
I have installed browser-extension "PassProtect" but "icon" is not reflected in the tool bar (URL bar) in Vivaldi, it does not work.
usage environment:
Windows 10 Home (64-bit) 1709 build:16299.431
Vivaldi 1.15.1147.42 (Stable channel) (64-bit)

Hey there, what extension? I haven't released a Firefox version of the extension just yet. I'm still building one...

Dear rdegges,
The subject is about Vivaldi of Browser.
Vivaldi can be installed from the Chrome Web Store

I installed it but "icon" does not exist in the URL bar.
Likewise, Iridium installs from the Chrome Web Store. About this, "icon" exists in the URL bar and it works normally.
These two browsers are based on Chromium.
As reference:
Iridium: https: //iridiumbrowser.de/
Vivaldi: https: // vivaldi.com/

Thanks, I'll look into this! Not familiar with those tools.


KEP-21: Upgrading KUDO

What this PR does / why we need it:
At the moment, we do not have a process or code for upgrading KUDO.
This is an early draft to invite discussion.

@ANeumann82 ping... what is next here

retargeting for 0.13.0


Unspecified unit for retry interval

Please make it clear what the interval units are.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 652bfe4c-4644-a3c0-4174-8c708555a539
Version Independent ID: 036e14c4-b3bd-c57d-fd22-ce5a8250b70a
Content: Handle Azure Functions bindings errors
Content Source: articles/azure-functions/functions-bindings-errors.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Thanks for the feedback! We will review and get back to you shortly.

I've put in a PR to update the description of these properties to specify the format is "HH:mm:ss"


🏷 Model badges in trainer documentation

What does this PR do?
Fixes #2149
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a GitHub issue? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

https://github.com/user-attachments/assets/3977ea1d-9c2f-4cd2-833d-e4d992fc2348


JavaScript Error

Second. Running version 1.4.4
Can't launch application. Same error.
Redownloaded and unzipped. The new download then throws this error.

Same here with version 1.4.3 and 1.4.4 both freshly downloaded and unzipped.

This was working fine but stopped working today with the same error. 1.4.4
I've just installed 3dsmax 2018, so that might have updated something about my javascript?

@reformstudios I don't use 3ds max and didn't install any software. A friends of mine has got the same issue and didn't change something as well.

Try deleting AppData folder and restart.

@markwoon Yeah, that worked for me! Thanks for the hint!

@markwoon Brilliant, thank-you!

I've experienced this error as well.

Not stale.


Pretrained checkpoints (HO-3D & DexYCB) do not work

Hello, thank you for your works.
I tried to follow up your code with the uploaded pretrained checkpoint of models (HO-3D & DexYCB).
However, I think the checkpoint does not work in my environment.
Actually, I commented out the neural_renderer part in here. (Also I erase which are related with it.)
However, I think it does not affect the forward of the module, if not I apologize for my fault.
As I checked the checkpoints, the 'epoch' of the trained checkpoint is 12, while the paper said you trained 25 epochs.
Also, when I visualize the network output, the hand and object are not reconstructed well.
Significantly, the hand does not look the hand, and the object coordinates far from the hand.
Here is the visualizing result in DexYCB.

Thank you for your replying.

Hi,
Can you please first confirm that you can reproduce the Table 2 results using the weight
The visualization looks to me more like that you are not connecting vertices by the correct faces

In my settings, MJE / MCE / PD = 8.955 / 364.84 / 0.0.
Also, the mesh faces are not wrong, as in vertices visualization below.

I think, something's wrong in my setting.
Again, I re-examine my setting thoroughly.


Hi, When will you release the evaluation code?

Thanks for your great work, and when will you release the evaluation code?

when will you release the inference code?

@SpursGoZmy


Provide smart restrictions for users

Is your feature request related to a problem? Please describe.
Users should be discouraged from performing questionable actions in CSX.
Describe the solution you'd like
~1. If a user tries to connect an array feature with a single value feature they should not be able to form a 1:1 connection. (similar logic for other connections)~
2. Users should only be able to add new properties to single value features in the overview graph.
3. Users should only be able to use appropriate search/filter nodes with appropriate values.
This should be generalised to all actions

is completed in the improvements branch

is completed in the improvement branch

Was implemented as part of the improvements branch


travis: add CI for the optional tokio feature

This makes sure the project builds both with tokio and without.

Thanks!


feat: Implement Network Info

Context
Network settings have data that’s sourced from configuration files, which can be served over the network to clients dynamically upon connection.  Right now we have the NetworkInfoProvider, with an HTTP service then reading values from the cardano-db-sync DB. Our service design means a Node.js application could also bypass the HTTP service to read values straight from the source by wiring up say the NetworkInfoDbSyncProvider.
As a developer wishing to connect dynamically to a network
We need to have the option of using a remote service to access network-specific information.
Proposed Solution
Important Changes Introduced

create DbSyncNetworkInfoProvider and NetworkInfoBuilder
add 'cardano-configurations' as a submodule to cardano-services
implement 'extractGenesisData' method to load genesis configs and extract needed info on provider initialisation
create timeSettingsConfig for mainnet and testnetnet, NetworkMagic mapping
extend env vars with CARDANO_NODE_CONFIG_PATH required for NetworkInfo service in run.ts and cli.ts
create NetworkInfoHttpService and extend HTTP server with it, attached on demand
attach OpenApi spec and validation on NetworkInfo http service
create db queries for extract the relevant network information from db-sync
refactor loadHttpServer with factory method (get rid of switch-case)
create networkInfoHttpProvider in cardano-services-client
cover UtxoHttpService with entrypoints (run/cli) tests by request
extend NetworkInfo['network'] interface with id, align BlockfrostNetworkInfo provider with it

Note

wait for updated DB snapshot and fixtures in order to test the queries with actual Network info data (the current db seed doesn't have most of it )
I need help with reviewing the DB-sync queries introduced within the PR, especially live and active stake

Need to rebase this on master, there are 5 conflicts

blockfrost package changes in feat(cardano-services): create NetworkInfo service seem to belong to feat(core): extend NetworkInfo interface. Also, if a commit has changes in multiple packages, omit the scope, e.g. in this case it would become. feat: extend NetworkInfo interface


refactor: log breadcrumb handle

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.1%) to 41.463%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Breadcrumb.php
0
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-2.1%

Covered Lines:
17

Relevant Lines:
41

💛  - Coveralls

@jozefrebjak note about log- added to README file.


Display warnings and errors in GitHub Annotation section

In here:

Maybe we need to expand core.setFailed('Compilation failed!'); with longer text. One call with warnings, another with errors.
Docs:

https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/setting-exit-codes-for-actions

E.g. https://github.com/EA31337/EA31337-classes/actions/runs/464634703

E.g. https://github.com/EA31337/EA31337-classes/actions/runs/464634703


How can we set the Edge extension as the default browser for live server?

I have installed Microsoft Edge Extension into VS Code editor.
and when I click on 'Open with Liver Server', it's always opening the external default browser. instead of opening external browser and VS Code, I am exploring the possibility to set this extension as the default browser (at least for VS Code); so that when I click on 'Open with Live Server', preferably it opens inside the VS Code with the Edge extension.
PS: I have searched online to see if I can do this, but most of the answers seems to be telling I can go to settings and pick Edge as the default browser, but then it opens with the external Edge browser, not the extension I have installed.
If there is already support for this feature, my apologies, I missed to find it. If this was not provided yet, can you please consider adding this in the future releases, so it would be very helpful for us.
I hope I am not the only one wishing for this! :-)
Is your feature request related to a problem? Please describe.

Describe the solution you'd like:

Describe alternatives you've considered:

Additional context:

Thanks for reaching out. No, there is no current support for this feature. But this has been requested before, so it's definitely on our backlog. We just haven't had the chance to prioritize it yet.
I'll close this issue as a duplicate of #1453 which we are using to track this already.
Thanks!

Thank you for your response!
Looking forward to some updates sometime in the future.


Fix: Passing const of model type to @example

fix #4544

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Nuxt 3 TypeScript Error window is not defined

hello i'm using
"nuxt": "^3.5.2"
and
"datatables.net-vue3": "^2.1.1"
i'm using data tables like this in my components

but it got error when i run the project

Can you create a mini repo for me showing the error please?
While you are using ESM style imports, something is converting that back to CommonJS which might be causing the issue.

Can you create a mini repo for me showing the error please?
While you are using ESM style imports, something is converting that back to CommonJS which might be causing the issue.

Sure,
here's the repo
https://github.com/geofany/nuxt3-datatables
i'm Using
Node 18.16.0
and
Yarn

@geofany You can temporary fix the issue by surrounding the component with ClientOnly tag

Sorry for the delay in replying here! I had inverted logic in the CommonJS loader when checking for a windowed environment. Doh! Fix committed here.
I'll tag 1.13.6 which will have this fix next week.


Unable to parse dot separated placeholder in v10.8.1 cli

Which version and edition of Flyway are you using?
In Teams v10.8.1
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Command-Line
Which database are you using? (Type & version)
Postgres 15
Which operating system are you using?
Windows 10
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
flyway -url="jdbc:postgresql://<server>:<port>/database" -user=<user> -password=<password> -mixed=true -defaultSchema=<schema> -ignoreMigrationPatterns="repeatable:missing" "-placeholders.holder_key1=<value>" "-placeholders.holder-key2=<value>"  "-placeholders.this.causes.a.parse.error=<value>" -locations="filesystem:<.../sql/>" migrate
What did you expect to see?
No error. This syntax was supported in v9.20.0 which is the most recent version we used before attempting to upgrade.
What did you see instead?
ERROR: Unable to parse command line params.

Thank you for your issue @vzdm
This would be caused by changes to our configuration structure over the last year. Unfortunately dot separated placeholders were not a consideration in the redesign as we had not had a use case using them previously. Currently, placeholders.this.causes.a.parse.error would be considered multiple levels of depth in the new configuration model and not simple as a key and value in the placeholders map. We would need to investigate if this is something we could support.

I have a schema history that already contains dot separated placeholders. I chose placeholder labels based on the way placeholders are passed in command line - with a . separation, like this
-placeholders.myscope:config.username="mock-config-username"

There was no limitation/best practice for placeholder label charset in the previous versions. I do not think that my choice of label notation would be in any way obviously misconceptional, taking into consideration that flyway already used . within the command line argument syntax.
Now with this update, I am unable to migrate to any newer version of flyway, because i either lose the ability to start a new instance of the DB from scratch (if i keep the old scripts as they are - because they contain dot-separated placeholder labels which i have no way of interpolating in the old scripts) or I lose the ability to maintain the existing (prod) databases using flyway (if i change the placeholder label notation in my existing scripts to be conform with the newest restriction, it will mess up flyway history hashes).
This is a serious deal-breaker.

Could we at least get a way to escape the dot on the command line? That seems to me like the least painful solution.


Avoid intermediate ctx to scheduler in case of ULTs

Original issue: https://charm.cs.illinois.edu/redmine/issues/1712

If a ULT yields, we currently context switch back to the scheduler thread always, even if the next task in the scheduler's queue is another ULT that we then have to context switch to.
ArgoBots already has this optimization to context switch directly to the next ULT in this case.

Original date: 2018-02-09 15:56:06

Seonmyeong, can you take a look at this? You have more knowledge of our ULTs and Csd module. The idea here is just to avoid the intermediate context switch to the scheduler in the case where the currently running thing is a ULT and the next thing in the scheduler is also a ULT.

Original author: Seonmyeong Bak
Original date: 2018-02-09 20:07:42

Maybe, the current implementation tries to follow the priority order of the converse queues.
If we want to process all the ULTs in the specific queue, we may need to consider it is worth changing the order.
Currently, OpenMP integration works in the way you described. It process all the ULTs in TaskQueue within each OpenMP parallel region before it comes back to the converse scheduler.
We may construct a common function to process all the ULTs in a specific queue until the queue is empty.
For OpenMP, taskqueue, and For AMPI, maybe scheduler Queue?

Original date: 2018-02-09 20:14:31

I hadn't thought of that, but it might be good. I meant that if a ULT is running and is about to suspend, then we should check if whatever the next thing that will be scheduled is also a ULT. If so, do the direct context switch. In any other case, context switch back to the scheduler thread. That would require being able to run the main scheduler loop on the ULT though.
Also, if it matters AMPI doesn't use message priorities at all. All of its messages are [expedited].

Original author: Seonmyeong Bak
Original date: 2018-02-09 21:01:20

I think only function checking the queues in the converse queue efficiently is enough for your purpose. If all the queues are empty and ULTs come next, we can schedule ULT without switching to the converse scheduler.
Lightweight version of CsdNextMessage (Not pop message but check if the queues are empty) can work for our purpose here.
Or, we can adopt the way I suggest.  checking all the queues also cause overhead comparable to what switching to the main scheduler causes.
Currently, the context switching cost is reduced a lot by the uFcontext. What we suggest here may not be more efficient.


8 use persistence api

This adds  'take snapshot' and 'restore snapshot' buttons to test the persistence api and closes #8.
It also updates voyager electron to use the npm published library.
Note: this depends on https://github.com/vega/voyager/pull/390 and deploying a new version of the library to npm. It also depends on some package.json fixes to voyager that @vlandham is working on. So we should hold off on merging this for a bit.
ping @vlandham @kanitw

This PR has been updated with your suggestions @kanitw, however restoring snapshots depends on https://github.com/vega/voyager/issues/398 being resolved.

@kanitw this is now ready for review. With an upgrade to a new version of voyager that fixes the state serialization, one can take and restore state snapsots.

ping @kanitw. requested changes have been made.


Support for multiple installed OE installations

Problem encountered:
When extensions starts it sometimes tries to start the OE client before port is provided so the extensions stops working.
To recreate:
Start the extension and wait for error in debug console:

Pleas check if you can recreate this issue.


Waiting for one of the selectors or alert windows

I want to use this library to automate my daily tasks, like giving a job id, go to a page find all the pallets of this job and process these pallets one by one. Or giving an asset id, I verify if all the processing data are valid for this asset, etc.
When I click a button, it may show out different content, or alert messages according to the data.
What's the proper way in playwright-go to process these situation?
What's the correct way to do this in playwright-go?
    await page.goto(loadLink)

    // if load id is valid, this PALLET DETAILS table will show out
    const hdTable = "#ctl00_ctl00_LoadPallet"
    // if load id is invalid, it will show warning window with this close button
    const closeButton = "#ctl00_ctl00_LoadGridClose"
    await Promise.race([
        page.click(closeButton).then(() => false),
        page.waitForSelector(hdTable).then(() => true)
    ]).then(value => {
        if (!value) {
            console.log("wrong load id: ", loadID)
            return
        }
    })

Thanks

Hi sorry for the late response, maybe using time.After in combination with a switch to have similar Promise.race behaviour could work.
For automating daily tasks I would probably use JavaScript since in Go its kinda abstract.

Thanks for the advise.


Revert "Add html5 doctype to static renderer (#486)"

This reverts commit 3081f5521a7bfc10e4b3087f5744887a1c7f4947 which causes failing snapshots.

The rest of the failing tests are from #483. Those are caused by an extra blank line after the title tag.

CC @AndrewBarba


hotfix/myClasses -> dev

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Move creation of exec ctx

This change is

Codecov Report

Merging #1009 (ed2554d) into main (39083f5) will increase coverage by 0.45%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
+ Coverage   66.83%   67.29%   +0.45%
==========================================
  Files          51       51
  Lines        6185     6293     +108
  Branches     6185     6293     +108
==========================================
+ Hits         4134     4235     +101
- Misses       1674     1684      +10
+ Partials      377      374       -3

Files
Coverage Δ

.../blockifier/src/transaction/account_transaction.rs
94.31% <100.00%> (+0.02%)
:arrow_up:

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Improve startup time of workers

During evaluation, we observed delays ranging from 3s to 20s+ between a program message and the first values coming back, regardless of the size of the data. For better usability, this time should be reduced as much as possible, since this

delays the table view showing up
and later causes another delay for the profiling.

A few modules in the library constitute most of the delay:

(Measure-Command { python -c "import seaborn" }).TotalSeconds: 1.21s
(Measure-Command { python -c "import torch" }).TotalSeconds: 1.24s
(Measure-Command { python -c "import torchvision" }).TotalSeconds: 1.90s
(Measure-Command { python -c "import openpyxl" }).TotalSeconds: 0.26s

We should get major improvements regarding startup by:

Lazily loading our own classes in __init__ files (apipkg) why is this not the default behavior in Python?!
Lazily importing external libraries.

Unfortunately, many libraries currently import all their stuff into a global package, so if we use anything from, say seaborn, there will still be the 1.21s. This can only be fixed by the libraries themselves.
Regarding the runner, we will need to have a primed process ready that can handle the execution of the next pipeline. Ideally, we would also keep those processes alive and reset them after pipeline execution is done, so we don't have the startup delay again and again.

Ideally, we would also keep those processes alive and reset them after pipeline execution is done, so we don't have the startup delay again and again.

@lars-reimann This is somewhat supported, as metapath (for loading our pipelines) is already reset after a pipeline ends. The process could theoretically be reused, but this behavior would not guarantee correctness in all cases. States from external libraries (like seaborn) however, is not reset.

Regarding the runner, we will need to have a primed process ready that can handle the execution of the next pipeline.

I'll try something out for tomorrow, maybe something like that can be achieved.

There's also a new release of the library now, containing your hash functions and your other improvements, as well as the lazy imports.

:tada: This issue has been resolved in version 0.12.0 :tada:
The release is available on:

v0.12.0
GitHub release

Your semantic-release bot :package::rocket:


chore: bump to nightly-2023-07-15

[ ] depends on: https://github.com/leanprover/std4/pull/188

This will need a fix to Std4.

This is currently failing in tests/CommDiag.lean, but I can't reproduce the failure locally.

Now it is failing on the simpNF linter.

Thanks! :tada:
bors merge

bors d+
The succAbove thing is probably out of scope.

bors merge


feat: Encode chart information into metadata

What this PR does / why we need it:
As a helm user we want to retrieve information about state of
our helm deployments, so that we can have a cluster-level dashboard for it.
Our approach was employing https://github.com/sstarcher/helm-exporter to
expose helm metadata via prometheus. Unfortunately with the chosen secret
storage backend, read access is required to get the information about deployed
chart and application versions.
Kubernetes does not allow to differentiate between different types of secrets
on a namespace, so providing read access to secrets could leak other secret
information (API Tokens, Certificate Keys, Credentials) through such an
exporter.
This change exposes chart and application versions in the metadata, so we
don't have to provide read access to secrets for helm-exporter anymore, but
helm-exporter could simply use a "list" RBAC permission to read the
metadata.
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[x] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

I think most users will not benefit from this feature

As a general rule, we try not to discourage others by weighing in on whether their contribution will benefit the larger community. Instead we try to talk about whether a feature makes sense from a design standpoint. In other words, does a feature fit into the use case a package manager would solve? If so, let's talk about it.
As an example, we thought Rudders were going to be the next big thing when it was released in Helm 2. We spent WEEKS on the design, and it was a large part of the code base. It was rarely used and eventually removed in Helm 3. helm serve is another similar example of a feature we thought others would benefit from.
This seems dangerous from a design standpoint, though. Releases should not expose any chart information in plain sight. If you can determine the chart name and the chart version used, as an attacker you can look up what exploits are available for the app/version. It exposes information an attacker can use to determine an exploit. These are known as version disclosure attacks. Apache and nginx are well-known targets for this particular exploit.

This seems dangerous from a design standpoint, though. Releases should not expose any chart information in plain sight. If you can determine the chart name and the chart version used, as an attacker you can look up what exploits are available for the app/version. It exposes information an attacker can use to determine an exploit. These are known as version disclosure attacks. Apache and nginx are well-known targets for this particular exploit.

First of all, thanks @bacongobbler for your quick and extensive feedback and sharing your concerns about potential version disclosure attacks. I think Kubernetes still provides enough prevention from that to happen.
What would an attacker need to gather the same information from helm?

On an RBAC-enabled Cluster: "list" permissions to secrets vs. "read" permissions to secrets. It still would require authorized access to gather the information.

What would an attacker know already from "list" permissions?

Chart Name, Modification/Creation Date to make guesses if the release has been fixed (e.g. a deployment prior to a fix being published).

What would users do currently to get the same level of information?

Provide read permission to secrets or use a different storage provider. Neither of it is ideal, since it would disclose more information (e.g. potentially hardcoded creds in the chart or rendered yaml).

Back to the version disclosure risk: For the helm-exporter, I definitely see that risk, since it would expose the data on an endpoint, that might be unsecured. I see that outside of helm's scope though and eventually helm-exporter needs to be secured in order to only allow authorized access.

@mattfarina are you suggesting to add those labels (i.e. rename the labels added in this PR) to the helm secret? If so, that definitely would solve it.
As of right now, if defined within the chart, the labels would get added to the objects the chart deploys. To access them we would require cluster-level list access to all objects vs. with this approach only to secrets. Some charts only might deploy a specific CRD so it would be really hard to catch all of them.

@mrueg I was not thinking of adding them to the secret. Your information around access helps to understand this. Thanks.

We talked about this on the Helm developer call. An angle I had not thought about was the security angle. There is a difference between list and get on secrets for RBAC. Moving this information to labels moves this information to be available on list as well as get (I think).
This left me wondering if there was another way to make this information available.

I may be missing something, but I'm not sure necessarily how the security angle applies here. Listing secrets is a discrete permission that can be either granted or denied via RBAC. If someone has a fear of version disclosure attacks, then all they have to do is ensure that they don't allow users/roles to list secrets within their cluster.
This PR gives user's options and a gradient with which to disclose chart specifics. In general, I think that it solves a security problem by giving the cluster administrator more options for disclosing chart specifics. If they just want to expose versions of chart deployments they can now do so by granting list instead of granting access to the entire secret via read. If they want to give access to the entire secret then they can do so by granting list and read. And if they don't want to give away any information about helm secrets they can choose to do so by not granting either list or read.
I think that this PR also increases consistency within Helm itself. For the same reason that these labels are valuable on helm managed objects (like deployments, pods, services, etc.), these labels are also valuable on the secrets that helm keeps for itself. It seems that the security argument that is being made here could equally be applied to the labels helm puts on all of the Kubernetes objects that Helm manages. And yet these labels are considered a standard in the way that Helm works within the cluster.

@mattfarina apologies for getting back to so late, I concur with @aauren here on the consistency point, most helm charts add those labels to other objects as part of the chart as well.
Is this something that could get you convinced to accept this PR?

@mattfarina @bacongobbler still interested in this PR, anything that I could change to convince you to get it in (e.g. a feature-flag or similar)?

Almost one year later and I'm still interested in this PR too :)

Closing this PR as there seems to chance to integrate it. If anyone else is interested, feel free to reopen a new PR.