Consistently hitting heap limits during optimize-vscode

VSCode Version: master
OS Version: Ubuntu 16.04

The build server doesn't seem to be experiencing the same problem, I tried restarting and re-cloning vscode and it was the same.
$ gulp vscode-linux-x64-build-deb
...
[15:21:21] Starting 'optimize-vscode'...

<--- Last few GCs --->

   82576 ms: Mark-sweep 1031.1 (1434.8) -> 1030.9 (1434.8) MB, 744.4 / 0 ms [allocation failure] [GC in old space requested].
   83317 ms: Mark-sweep 1030.9 (1434.8) -> 1030.9 (1434.8) MB, 741.0 / 0 ms [allocation failure] [GC in old space requested].
   84076 ms: Mark-sweep 1030.9 (1434.8) -> 1030.9 (1434.8) MB, 758.3 / 0 ms [last resort gc].
   84831 ms: Mark-sweep 1030.9 (1434.8) -> 1030.9 (1434.8) MB, 755.7 / 0 ms [last resort gc].

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0xcab8d9c9e59 <JS Object>
    1: _parseMappings(aka SourceMapConsumer_parseMappings) [/home/daimms/dev/Microsoft/vscode/node_modules/concat-with-sourcemaps/node_modules/source-map/lib/source-map-consumer.js:~423] [pc=0x26dfc44e34d1] (this=0x90dba049d09 <a BasicSourceMapConsumer with map 0x26b0e916b2a9>,aStr=0x90dba04a951 <Very long string[1943]>,aSourceRoot=0x90dba049989 <String[44]: file:///home/daimms/dev/Microsoft/vsc...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
Aborted (core dumped)

@Tyriar Do you run node in 32 or 64bit? The former has a heap limit of around 1GB, after that you get into GC hell

@jrieken not sure, sounds reasonable though. I'll check it out when I'm in the office.

Definitely 64 bit and still hitting this on my laptop after syncing:
~
❯ node
> require('os').arch()
'x64'
>

I am not they guy for optimise. Maybe @joaomoreno or @alexandrudima

Yeah I've seen this in my Linux desktop, although never in our build machines...

Are you on node 5.10?

@joaomoreno potentially, I'll have to check. Could ./scripts/npm.sh, code.sh and/or gulp check the node version and warn on this if so?

If will soon delete editor/standalone-languages (14.7KLOC). Maybe that will help

@Tyriar still an issue?

Nope, I may have been on an old version of node, I'm on 6.2.2 now and it works.

Hi folks, I just ran into the same issue. VSCode version: 1.3.1
Platform: Windows 7, x64:
C:\Users\matt\code\github\vscode>node -v
v6.3.1

C:\Users\matt\code\github\vscode>node
> require('os').arch()
'x64'

While trying to build via gulp vscode-win32:
[11:05:15] Starting 'optimize-vscode'...

<--- Last few GCs --->

  144155 ms: Mark-sweep 1043.6 (1434.8) -> 1043.6 (1434.8) MB, 1260.3 / 0 ms [allocation failure] [GC in old space reque
sted].
  145415 ms: Mark-sweep 1043.6 (1434.8) -> 1043.5 (1434.8) MB, 1259.8 / 0 ms [allocation failure] [GC in old space reque
sted].
  146690 ms: Mark-sweep 1043.5 (1434.8) -> 1043.5 (1434.8) MB, 1275.1 / 0 ms [last resort gc].
  147930 ms: Mark-sweep 1043.5 (1434.8) -> 1043.5 (1434.8) MB, 1239.8 / 0 ms [last resort gc].

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0000033BE92C9E51 <JS Object>
    1: _parseMappings(aka SourceMapConsumer_parseMappings) [C:\Users\matt\code\github\vscode\node_modules\concat-with
-sourcemaps\node_modules\source-map\lib\source-map-consumer.js:483] [pc=0000031EBD45EEA4] (this=00000008B10C35B1 <a Basi
cSourceMapConsumer with map 000003658B9F7DE1>,aStr=00000008B10CE2D9 <Very long string[10520]>,aSourceRoot=00000008B10C32
49 <String[47]: file:///C:/Users/IG...

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

@mattdsteele I think we switched the version to 1.4.0 almost a month ago, does it happen on master?

Just rebuilt, and it didn't occur for me on master. Looks like it might have been resolved.

This has been happening again for me on master/Windows 10/node 6.9.2.

V8 has a strict heap limit of 1.7gb, it can be increased like so:
node --max-old-space-size=4096 ./node_modules/gulp/bin/gulp.js watch
gulp watch --max-old-space-size=4096 should also work

We should consider either adding this to the npm run watch script and/or adding it to the build wiki page

Yeah. @isidorn has this too. I hit it a couple of times too.
We should add it and inform everyone to use npm run watch instead of gulp watch.

This is still happening for me on the latest merge into my ARM builds (although it's happening for Intel 32/64 as well).
I'm trying to tune max_old_space_size and max_new_space_size ( <-- although I'm fairly sure max_new_space_size has nothing to do with the problem ).
Did Tyriar's commit (3e418e1) resolve this for you guys?

@headmelted Yes, make sure you use npm run watch.

Testing that out now.
Should the package.json also be changed to use "npm run watch"?
It's strange to me that your master builds are still running with the package.json calling "gulp watch" and mine are not, and it makes me slightly suspicious I have something else out of whack.
In any case, I'll keep digging at this side.  Thanks!

Should the package.json also be changed to use "npm run watch"?

What do you mean? npm run watch will run what's defined in package.json: gulp watch --max_old_space_size=4096.
I'll change our builds to run npm run watch. The build fails occasionally, not every time.

I've now got to the bottom of my issue. Tyriar's above fix solved my immediate problem, but it was still falling over, which after checking my build logs turns out to have been due the Linux packaging scripts also failing for the same reason (*-build-deb).
In my case, I needed to increase the heap limit for building the packages, too, i.e.:
gulp "vscode-linux-armv7l-build-deb" --silent --max_old_space_size=4096;
It may be worth adding this to your travis script for the subsequent node child scripts, or better yet, setting the increased heap size globally for the duration of the run.

I've needed to do this on Linux when building packages recently as well, we'll probably need to make the workaround more visible.


Fix bug in service connector, Closes #1720

Describe changes
Fix the bug found when trying to create a new GCP connector when using GCP secrets because the generated secret has uppercase letters.
Pre-requisites
Please ensure you have done the following:

[x ] I have read the CONTRIBUTING.md document.
[x ] If my change requires a change to docs, I have updated the documentation accordingly.
[x ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[x ] I have added tests to cover my changes.

Types of changes

[ x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

@soubenz good catch ! Thanks for your contribution !


Code Smells: Identify & Refactor

The current first-iteration playable implementation has the following Code Smells:
Application-level smells:

Duplicated code: identical or very similar code exists in more than one location.

e.g. Not many reusable methods/interfaces were used. Unity API was used directly most of the time for familiarization.

Class-level smells:

Large class:  a class that has grown too large. See God object.

e.g. GameManager currently knows & does too much.

Lazy class / Freeloader: a class that does too little.

e.g. AsteroidBehaviour subclasses really don't do much at the moment.

Method-level smells:

Long method: a method, function, or procedure that has grown too large.

e.g. See duplicated code above. Most solutions were written with a direct approach.

The current implementation has been largely refactored. :melon:
The code smells may now be on the opposite side of the spectrum. :rainbow:

Issue may be reopened when glaring code smells are identified and require resolution.


The first parameter in plugin.install.apply can also be defined as: null or undefined

Whether the first parameter in plugin.install.apply can be null or undefined. In fact, at the same time when the plugin is installed, the plugin can get the context of the current plugin. It is not necessary to pass the context via install.apply.

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[ ] Feature
[ ] Code style update
[x] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Thanks, but having the plugin object as the context in the function is convenient for plugin authors. This could also break existing plugins 😄

@posva  Thank you for the reply


[Enhancement] Deprecate Fungible Token declarative macros.

Closes https://github.com/near/near-sdk-rs/issues/1049

This seems to be an a good shape for another round of reviews.

@ruseinov The only remaining item left is the CI. Add the offending packages to the ignore list and create a separate issue to address it in the future.


Display error message when an error occurs

Crash report: b10a15ae2bf1de9cf6c4c97dc04953c5
I think when an error occurs, the message part of the crash report should be displayed to the user. When running deliver during the initial setup, I logged in and got the message Error occurred with the setup program! Reverting changes now!. It would be more helpful to pull the message from the json crash report to display to the user. In my case, the issue was as simple as not putting the app into iTunesConnect:
"message": "RuntimeError: \u001b[31mCould not find app with app identifier 'com.manahan.MyApp' in your iTunes Connect account (chrismanahan - Team: 477707)\u001b[0m",

Oh yeah, @ohwutup is currently working on rewriting the setup, this will also include this change. Thanks for your feedback :+1:


Possible wrong enqueue handling in SnackBarMessageQueue.cs

I tried to implement the very nice Snackbar feature in my application and run into problems. I wanted to show the message every time, even if it is the same. It seems that everything, to use this kind of behavior, is implemented but not used.
public void Enqueue(object content, bool neverConsiderToBeDuplicate)
        {
            if (content == null) throw new ArgumentNullException(nameof(content));

            _snackbarMessages.AddLast(new SnackbarMessageQueueItem(content));
            _messageWaitingEvent.Set();
        }

public void Enqueue(object content, object actionContent, Action actionHandler, bool promote)
        {
            if (content == null) throw new ArgumentNullException(nameof(content));

            _snackbarMessages.AddLast(new SnackbarMessageQueueItem(content, actionContent, actionHandler));
            _messageWaitingEvent.Set();
        }

In both cases the boolean variables, which to my understanding, are responsible for this kind of behavior  are not used.

I have also experienced this bug. I forced duplicates by appending a variable number of \0's at the end of messages, which causes equality tests to fail. A bit hacky, but it won't affect appearance.

This bit me on my project as well. PR submitted with proposed fix.


help

PS C:\new> npm install
npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>request-promise-native has been deprecated because it extends the now
deprecated request package, see https://github.com/request/request/issues/3142
npm WARN deprecated<EMAIL_ADDRESS>Use cheerio-select instead
npm WARN deprecated<EMAIL_ADDRESS>this library is no longer supported
npm ERR! code ENOENT
npm ERR! syscall spawn git
npm ERR! path git
npm ERR! errno -4058
npm ERR! enoent Error while executing:
npm ERR! enoent undefined ls-remote -h -t https://github.com/YogaSakti/video-url-link.git
npm ERR! enoent
npm ERR! enoent
npm ERR! enoent spawn git ENOENT
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent
npm ERR!      C:\Users\Administrator\AppData\Roaming\npm-cache_logs\2021-02-04T09_49_06_476Z-debug.log
ini kenapa ya kok pas di npm install malah error

The request package is deprecated, try asking the developer to find an alternative which you can find here


dots in url segment

while "npm run dev"
can not use dots in url segments like: http://localhost:6655/app/accounts/avagram.ru/checkpoint
error: "Cannot GET /app/accounts/avagram.ru/checkpoint"
running on real server - no problem.
screen: http://joxi.ru/a2XVPqWf1lXwxr

I assume you use vue-router? Anyway, you provide too little information.

yes. i use vue-router. what else can i provide? let me know. i'm not professional in JS/Node.

Well, some code would be helpful. Also, you should see error messages in your Terminal if the devserver can't serve what you request.
Or maybe you are just using the router in history mode and tr to access an url by hand through the adress bar?
I just tested this with a fresh project and had no problems:

Close because OP didn't reply and I couldn'T reproduce the issue.

Ah, just remembered something: The devServer uses connect-history-api-fallback to serve index.html for any route.
This package doesn't like dots in paths:


Excercise n1

Created an initial implementation that parses the provided test-output file and stores the result into a test-output-parsed file.

The Reuse Compliance Check fails because the following files have no copyright and licensing information:

test-output
test-output-parsed

consider using the CC0 license for this files.
I think there are a generated file, so you can use a DEP5 file in order to execlude them. Here have an example
https://github.com/edgehog-device-manager/edgehog-device-runtime/blob/main/.reuse/dep5

Never add huge blobs (such as test-output and test-output-parsed) to git repos, they bloat down the repository, they are harder to manage, and etc.
Let's make smaller reference files that are easier to understand and manipulate.

It looks like that test-output and test-output-parsed are not referenced from any line of code, so maybe they shouldn't be here.

It looks like that test-output and test-output-parsed are not referenced from any line of code, so maybe they shouldn't be here.

Yes, I agree with this. I was keeping them versioned because I wanted to ensure I was not changing the behaviour of the parser during development. But now that there are more unit tests (also in the PR of excercise 2) they should be removed.


Please do not silently drop unknown argument types in PhpNodeVisitor

Currently there is:
 default: $function->addArgument();
So, if the argument is not Scalar_String, Scalar_LNumber or Scalar_DNumber then the argument is silently discarded. It would be very helpful if the class could at least call an empty protected method so that a child class can then decide what happens with that argument without completely overriding createFunction(). Drupal has the following syntax to supply context info: t("Translatable string","",["context"=>"Context string"]); Unfortunately the array type in the 3rd argument is discarded and there's no easy way to get to it even in a child class.

Ok, fair enough.
I've added the ability to handle not only scalar values but also arrays. Could you test it to know if it can be adapted to Drupal before release a new version?

Yes, I just tested this. It works and it is incredibly helpful. A huge improvement in contrast to the 4.x version where I had to include a full-fledged PHP-array token parser. Hundered of crazy code lines => gone! Amazing. Would be very happy if you could include this change in the next release.

v1.1.0 released including this change


explore using app-site-association and URL for orbot launch

instead of custom URI scheme (which can be hijacked), we instead use https://orbot.app/start/foo URL to launch Orbot since we can authentication this with apple appsite association feature.
We can also add a page to the Orbot.app website to tell the user to install Orbot if they don't have it, which is a nice failover.

@n8fr8, where's the source for https://orbot.app?

Forget it, I found it: https://gitlab.com/guardianproject/orbot-app-website

Uupsi. Just recognized, I use https://orbot.app/rc/ instead of /start/. Good enough or should I change?


Admins Can Configure Zones in Storage Class

The PR https://github.com/kubernetes/kubernetes/pull/38505 added zones optional parameter to Storage Class for AWS and GCE provisioners.
That's why documentation needs to be updated accordingly.
Target release: 1.7
@jsafrane PTAL

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.7 Features: set Milestone to 1.7 and Base Branch to release-1.7
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is

Thanks for letting me know this is for 1.7. I'm moving this PR to the release-1.7 branch.

@jsafrane Sorry, this PR picked up other commits when I moved it from master to release-1.7, so the changes are just to docs/concepts/storage/persistent-volumes.md.

@chenopis sorry, after I fixed your comments I also rebased the PR to the tip of the master. That's why this PR picked the other commits.

@pospispa No worries. Thanks!

lgtm from tech side


feat: add 'gymnasium-robotics' pip package

Please add the following dependency to the rosdep database.
Package name:
https://pypi.org/project/gymnasium-robotics/
Package Upstream Source:
https://github.com/Farama-Foundation/Gymnasium-Robotics
Purpose of using this:
This package can be used to train RL on robotics systems.
Distro packaging links: N/A
Additional comments
I omitted a python/python3 prefix since this package is unavailable as a python2 package.
Checks

[x] All packages have a declared license in the package.xml
[x] This repository has a LICENSE file
[x] This package is expected to build on the submitted rosdistro

I made this PR a draft since this should not be merged until a decision is taken on https://github.com/ros/rosdistro/pull/38243#issuecomment-1683584262.

I think we can safely merge this since system dependency conflicts will only exist on Ubuntu 20.04 (see https://github.com/ros/rosdistro/issues/38332 and https://github.com/ros/rosdistro/pull/38243#issuecomment-1690254962).

Sorry, can you clarify how this is only a python2 package?
Almost every system that these rules will match are going to be python 3.
And we follow the debian naming convention even if it's not in debian for consistency for readers.
And please clarify your statement that this will only conflict on 20.04. On that system it will install a newer version of numpy implicitly? But not on the other systems. A summary of the different versions here with links to references would be helpful to get us all on the same page.

Sorry, can you clarify how this is only a python2 package?
Almost every system that these rules will match are going to be python 3.
And we follow the debian naming convention even if it's not in debian for consistency for readers.

@tfoote Of course. Sorry for being unclear. The gymnasium-robotics package is relatively new and therefore requires Python >=3.7. It was never released; therefore, it is a Python3-only package. Judging from the CONTRIBUTING.md. I, therefore, think the key would need to be python3-gymnasium-robotics-pip. I, however, noticed that a lot of rules don't have the python3:
https://github.com/ros/rosdistro/blob/9c23c70f8a9dc8afe5a6b14f73708fe258300097/rosdep/python.yaml#L1-L21
To name a view. I, therefore, needed clarification about whether the python3 prefix was required. If the python3 prefix is necessary, I think we should also update the gymnasium key added in https://github.com/ros/rosdistro/pull/37334 not that it hasn't been in the repository for too long.

And please clarify your statement that this will only conflict on 20.04. On that system, does it will install a newer version of numpy implicitly? But not on the other systems. A summary of the different versions here with links to references would be helpful to get us all on the same page.

The issue is the other way around. If rosdep installs Numpy, then only Ubuntu 20.04 version 1.17.4 (see https://pkgs.org/search/?q=python3-numpy) will be installed, while both the gymnasium and gymnasium-robotics packages require numpy=>1.20.1. Users will only encounter this issue when they work on Ubuntu 20.04. You can checkout https://github.com/ros/rosdistro/issues/38332, which I created for Gymnasium but also applies to gymnasium-robotics.

The reason why I haven't yet added the Python3 prefix is because the gym and gymnasium now don't have the Python3 prefix.
https://github.com/ros/rosdistro/blob/8637df61552d43091c5b5b49e9ba36a6e5d7ff4a/rosdep/python.yaml#L208-L233

Thanks for putting that all together. You're right that those other rules are not following our naming conventions and as they are just landed we should probably update them now instead of maintaining them as is. And reach out to anyone observed using the key publicly to make sure it's not a major problem.
@cottsay @nuclearsandwich
For the incompatibility on 20.04. The best thing to do on that is to simply declare a version specific 'null' entry for that version of Ubuntu and use the wildcard syntax to cover the other versions. Then rosdep will tell you that it can't be installed successfully instead of trying and getting runtime issues later. That could also be propagated.

Thanks for putting that all together. You're right that those other rules are not following our naming conventions and as they are just landed we should probably update them now instead of maintaining them as is. And reach out to anyone observed using the key publicly to make sure it's not a major problem.
@cottsay @nuclearsandwich
For the incompatibility on 20.04. The best thing to do on that is to simply declare a version specific 'null' entry for that version of Ubuntu and use the wildcard syntax to cover the other versions. Then rosdep will tell you that it can't be installed successfully instead of trying and getting runtime issues later. That could also be propagated.

@tfoote, I updated this pull request to reflect the changes you requested. I also created a pull request to update the gymnasium-pip key to python3-gymnasium-pip (see https://github.com/ros/rosdistro/pull/38341/files). We can safely merge this pull request since it was introduced relatively recently.
For the gym-pip rule, I don't think it is wise to update this rule since it was introduced four years ago. A gymnasium has replaced further gym, so it will be appreciated in the future (see https://github.com/openai/gym?tab=readme-ov-file#the-team-that-has-been-maintaining-gym-since-2021-has-moved-all-future-development-to-gymnasium-a-drop-in-replacement-for-gym-import-gymnasium-as-gym-and-gym-will-not-be-receiving-any-future-updates-please-switch-over-to-gymnasium-as-soon-as-youre-able-to-do-so-if-youd-like-to-read-more-about-the-story-behind-this-switch-please-check-out-this-blog-post).

@rickstaa I just merged the other PR and resolved conflicts here.  Can you double check my resolution?
One thing I noticed when resolving conflicts is that the python3-gymnasium-pip key resolves to gymnasium-robotics based on (https://github.com/ros/rosdistro/pull/38341/files).  Is that desired or was it a typo?

O wait, it looks like other things went wrong.

Ah looks like I got confused because of how Vscode displayed the git diff. I checked it here and I think the PR is good to be merged 👍🏻.

Thanks for iterating!


GPT-3 Moderation

Would be nice to add option to pass prompt and result through GPT-3's moderation endpoint and reject flagged results.

@lightninginabox sounds cool feel free to submit a PR, or I'll definitely put this on the roadmap

@lightninginabox happy to update its now merged


Updated footer

Related Issue
Closes #issue_number

Description

Screenshots

Checklist

[ ] My code adheres to the established style guidelines of the project.
[ ] I have included comments in areas that may be difficult to understand.
[ ] My changes have not introduced any new warnings.
[ ] I have conducted a self-review of my code.

@Esha-01 the footer looks small as well as there is a extra white space

add issue number in pr description

issue id is #381

@Esha-01 , What does the text area serve

As this is duplicate PR Ill be closing it


Merge se_estimation in develop branch.

This change is

Codecov Report

Merging #50 into develop will decrease coverage by 3.45%.
The diff coverage is 90.08%.

@@             Coverage Diff             @@
##           develop      #50      +/-   ##
===========================================
- Coverage    96.17%   92.71%   -3.46%
===========================================
  Files           11       16       +5
  Lines          470      879     +409
===========================================
+ Hits           452      815     +363
- Misses          18       64      +46

Impacted Files
Coverage Δ

grmpy/test/test_unit.py
100% <100%> (ø)
:arrow_up:

grmpy/simulate/simulate.py
100% <100%> (ø)
:arrow_up:

grmpy/simulate/simulate_auxiliary.py
99.21% <100%> (+0.15%)
:arrow_up:

grmpy/test/test_integration.py
100% <100%> (+3.7%)
:arrow_up:

grmpy/read/read_auxiliary.py
87.93% <100%> (ø)
:arrow_up:

grmpy/read/read.py
100% <100%> (ø)
:arrow_up:

grmpy/test/auxiliary.py
54.54% <44.44%> (-45.46%)
:arrow_down:

grmpy/check/custom_exceptions.py
60% <60%> (ø)

grmpy/check/check.py
70% <70%> (ø)

grmpy/estimate/estimate_auxiliary.py
85.98% <85.98%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f39d8...ae75353. Read the comment docs.

Reviewed 5 of 8 files at r3, 24 of 24 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 2 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


'wincolor' highlight missing with "below" virtual text

Problem:  'wincolor' highlight missing with "below" virtual text.
Solution: Subtract n_attr_skip from n_attr.  Combine 'wincolor' with
other highlights when 'nowrap' is set.

This should also make the applying of CursorLine/CursorColumn/ColorColumn highlight consistent on line without text property vs. line with text property:

ColorColumn is shown over CursorLine
CursorColumn is not shown on current line

https://github.com/vim/vim/assets/35768171/11fb5961-d5b4-4179-8b40-e63a5ec2af3f

thanks!


How to get current player state like current postion?

catch state event. and you can also get mCurrentState to get state value

Okay, I added this to my video view now I want to the listener for player current state how to use it? This not interface which I can implement in my activity

see demo MyJZVideoPlayerStandard, and smallChangeUiActivity.  There is no listener,  you must extends JZVideolPlayerStandard first.


Reverse pull request to get all on dev branch

@joeskeen ok, here is the trimmed repo, updated. Please take a nice code review of this :)


How can I contribute to this project?

Hi, I am new to Open source, so I am trying to contribute to open source projects, I found your project interesting. I wanna contribute to it? How can I?

If you want to contribute, you could start with trying to build GevOS by following the guide on our wiki. And then, If you believe that you have made good changes or maybe a good new feature, you should make a pull request. We will then review that pull request and if we like it, we will accept it and merge it. Otherwise, we will decline it and post a comment with feedback or reasoning why we declined your change.

If you want to contribute, you could start with trying to build GevOS by following the guide on our wiki. And then, If you believe that you have made good changes or maybe a good new feature, you should make a pull request. We will then review that pull request and if we like it, we will accept it and merge it. Otherwise, we will decline it and post a comment with feedback or reasoning why we declined your change.

OK, for now I am not able to Make PR. It says I have No permission.

OK, for now I am not able to Make PR. It says I have No permission.

That's weird. We have had people do pull requests before.

That's weird. We have had people do pull requests before.

I have not idea, why is it so.

I have not idea, why is it so.

The way we have done it before is through GitHub and not just plain git. You need to have a fork of GevOS on your GitHub profile and then create a pull request in GitHub.

The way we have done it before is through GitHub and not just plain git. You need to have a fork of GevOS on your GitHub profile and then create a pull request in GitHub.

alright. Got it.

alright. Got it.


Enum values can be unicode

Rather than requiring six as a dependency, let's just dump Python2 altogether. With Django dumping Python2 completely I'm much more comfortable making that call.

It's a flake8==3.5.0 issue https://github.com/tholo/pytest-flake8/issues/34
with flake8==3.4.x works fine

I think that if it is possible - it is better to keep compatibility with Python2. There are still very many projects using 2.x (even thought they're planning to switch to 3.x like us).
As for six in dependencies - as for me it is not critical. It's almost always in dependencies after all. Django (<2.0), jinja, requests, boto, billiard to name a few, all of these depends on six.
P.S.: Talking about Django - Django 2.0 is not LTS, so some of the django users (on 2.x especially :)) ) will stay on django 1.11.

Hmm. That's a fair point. Maybe it's better to tie this project's abandonment to Marshmallow's itself. @sloria Do you have any plans for moving Marshmallow to just Python3?

I removed six dependecy. May be it's a good point to use compability things from marshmallow?
https://github.com/marshmallow-code/marshmallow/blob/2.x-line/marshmallow/compat.py


refactor: shared common types

ref #84

@drodil

Looks good, some tsc problems still, @antoniomuso

Done!


Android 11 - 64 bit support - ARMv8-A based CPUs

For 64 bit support, we have added ARMv8-A based CPU in the gradle but while updating the target SDK from 29 to 30, the Camera feature of App is not working in Android 11, although its working perfect with targetSDK 29 in Android.
As per new PlayStore policy, after August 5, 2021 its mandatory to define the targetSDK version 30 and above for every new app.
So, In Android 11 its not working with targetSDK 30 and enabling the 64 bit support .

@yogeshwar-quantum4u did you find any solution for this? we have the same issue here.

did you find any solution to this problem?
I have the same issue here.

Unfortunately this library was abandoned, it had enormous potential

@YuantaoLiu @ducanh3005 @jonataslaw Do you have any solution to this problem?


[DRAFT] Refactor: remove ColumnOptionDef

Resolves #981
Currently work in progress :)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

62 of 62 (100.0%)  changed or added relevant lines in 11 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 98.431%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
39212

Relevant Lines:
39837

💛  - Coveralls


Tabular ray

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/platform_tests ref=tabular_ray


Trigger Completion Generation On Cell Execution

Trigger Completion Generation On Cell Execution
This PR hooks into the runner code execution path to trigger completion generation when a cell finishes execution.
This works for both interactive and non-interactive cells.
This reverts the approach taken in #1744 of intercepting the OnDocumentChangeEvent and goes with the alternative approach of triggering events from _doExecuteCell. We use the event reporter which is already reporting executions to Foyle to also trigger completions.
The problem with relying on vscode DocumentChangeEvents is that it only works for non-interactive cells. For interactive cells, Runme uses a custom renderer to show an xterm.js widget for the terminal. As a result, we don't trigger vscode DocumentChangeEvents when the outputs get updated.
The approach of using doExecuteCell to trigger completions works for both interactive and non-interactive cells. Previously, the outputs for interactive cells wasn't included was due to a bug fixed in #1756.
In the current PR, completions are only generated when a cell completes execution. This means for long running commands (e.g. kubectl get pods -w) we wouldn't periodically generate completions as the output changes. I think that's a bit of an edge case that we don't need to support yet. The current approach should extend well to that use case because we are using the event reporter to trigger completions and @sourishkrout recently added an RXJS queue inside event reporter. So we are well setup to enqueuing updates on the client and debouncing them.
Other Fixes
Include the CELL_TRIGGER enum in Foyle completion requests. I think I dropped when resolving some of the merge conflicts.
Fix https://github.com/jlewi/foyle/issues/309

@sourishkrout This is ready for review.


select toolchain like cmake -t "v140"?

what about selecting toolchain like cmake -t flag?

I have supported this feature, you can install and try it. https://github.com/tboox/xmake/releases/download/v2.2.2/xmake-v2.2.2.exe
$ xmake f --vs_toolchain=14.0
$ xmake

xmake project do not generate a solution with right vs toolset


Center fixed scale does not provide the correct scale with EPSG:3857

When using a center and a scale with the projection EPSG:3857 the scale is converted to a geodetic scale instead of keeping the asked for scale.
For the feature to match with its real length we need to set "geodetic": true for the scalebar and the label.
I think the problem come from the calculation of the bounding box in CenterScaleMapBounds.toReferencedEnvelope() , in which the the discriminant for geodetic bboxes is based on the unit of the projection  (degree).
But  EPSG:3857 is a geodetic projection with a distance unit in meter, the calculated bounding box is then false.
Setting the map attribute zoomSnapGeodetic to true or false doesn't change the outcome.
You will find an example of this behaviour in https://gist.github.com/didier-coignet-dict/7c9903c0a50b6135848d

Is it still the case?

I can confirm I have exactly the same issue on my side. Are there any solutions for this?

Does anyone have any work-arounds for this issue?
I've also encountered it while trying to configure the solution - https://gis.stackexchange.com/q/397526


push docs to docs branch

Proposed changes:

build docs onto the docs branch instead of gh-pages (this will allow us to deactivate github page hosting of the docs)
fixes #998

Status (please check what you already did):

[x] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog

I'll close this for now, please let us know if you have any further questions.


Instafeed stopped pulling pictures..

But console shows no errors..
http://derodewinkel.nl/collectie/
Any idea? Other sites where I used this plugin are working fine..
UPDATE: found out it has something to do with filtering on a certain tag..

it could be caused by changes to the API terms

It is stuck in sandbox mode - so it stopped after 20 pics..


Bump the conditional auth version for 1.2.11

Changes in this PR

$subject to get the changes done from https://github.com/wso2-extensions/identity-conditional-auth-functions/pull/108

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/2931462568

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/2931462568
Status: success


Support for proto3 optional fields, with EmitUnpopulated enabled on the gRPC gateway

Hello,
This should close out #5. I'm mildly concerned about the requirement on
EmitUnpopulated.
Please review the following commits I made in branch dan/optional:
27487d426cc7c8f8a263f19b9599de6e9110b531 (2024-04-22 08:37:21 -0700)
Support for proto3 optional fields, with EmitUnpopulated enabled.
Issue: https://github.com/dpup/protoc-gen-grpc-gateway-ts/issues/5
Code review reminders, by giving a LGTM you attest that:

Commits are adequately tested
Code is easy to understand and conforms to style guides
Incomplete code is marked with TODOs
Code is suitably instrumented with logging and metrics

This PR looks fine as a starting point. Keeping the conversation going about the best TypeScript representation of optional fields here: https://github.com/dpup/protoc-gen-grpc-gateway-ts/issues/5#issuecomment-2070288613


Small fix

What does that fix actually?

What does that fix actually?

#43
Toggles off crashing asus props if transparency = 100

What does that fix actually?

#43
Toggles off crashing asus props if transparency = 100

Well, if prop transparency is at 100 percent then it should just remove them, why remove this check, i dont have any crashes at 100 percent even with the check.

What does that fix actually?

#43
Toggles off crashing asus props if transparency = 100

Well, if prop transparency is at 100 percent then it should just remove them, why remove this check, i dont have any crashes at 100 percent even with the check.

But i have, and some people have too.
I think this fix will fix some crashes

And this fix cant do this hack worse than now

And this fix cant do this hack worse than now

This sentence didnt make sense, ill pretend that i didnt read that

And this fix cant do this hack worse than now

This sentence didnt make sense, ill pretend that i didnt read that

:((((((

I don't see what you're trying to do with this.

Are you using the latest changes to the branch (specifically 9bd1130f1e0d800edae9f88fb2107ac2577d9523)? One of the changes there may fix the issue.


Provide instructions to install mkdocs on python virtualenv.

Purpose
Avoid dependency issues occur while installing mkdocs

Will make it buildable with Docker instead


[Bug] Every Other Page are Gray Pages

Hi,
I'm trying to convert a manga from PDF to EPub and every time I convert, every other page in the epub file contains a page filled with gray. I'm using a Kobo Clara HD with Manga Mode, Stretch/Upscale, and Cropping Mode with the power at 1.00x enabled. Is this a bug or is there an option that I can enable to get rid of this issue?
Eg. Every page has the actual manga content like so:

But then a gray page like this appears:

And this pattern repeats for the whole ePub file.

If you open the epub on a PC do you still see the gray pages? The pdf might just have small gray images...

So on Calibre and when unzipping the epub, the gray pages are still there. I'm looking at the pdf and there doesn't seem to have small gray images in there other than the manga being black and white.

Are pages being replaced with gray? Or are additional gray pages being added?

Additional gray pages are being added.

Hmmm, my suspicion is that it's a problem with the source file. Are you able to obtain a CBZ instead? Or an image folder? Can you test with just a folder of .jpgs?

So when I obtain the CBZ, it still is producing the same issues. The issue isn't here with a random JPG folder. Attached are some pages of the PDF, let me know if you need more information.
よつばと! 第01巻_removed.pdf

I'll test myself soon. In the meantime, are you on the latest stable version 5.6.2?

Yes, I’m on the latest stable version 5.6.2.
From: Alex Xu @.>
Sent: Saturday, June 17, 2023 8:48 PM
To: ciromattia/kcc @.>
Cc: Michael Xie @.>; Author @.>
Subject: Re: [ciromattia/kcc] [Bug] Every Other Page are Gray Pages (Issue #540)
I'll test myself soon. In the meantime, are you on the latest stable version 5.6.2?
—
Reply to this email directly, view it on GitHubhttps://github.com/ciromattia/kcc/issues/540#issuecomment-1595911655, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AK4OK3GKSGHP5YW4EPH7Q5LXLZF4ZANCNFSM6AAAAAAZCMFOX4.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

A single gray pixel is being generated between pages.

The pdf file must have stray single gray pixels between pages... Are you able to get a better source?

Sorry, I don't have a better source for this :(
Is there a way to delete these files, I'm fine if I have to manually do it, but if I manually delete each single gray pixel file, how would I repackage the image files into an epub?

I would try another program to extract the images out of the pdf. And then use the extracted file in KCC.

Can you test #546 @Derzz

Sorry, but what should I do with #540? I have the release version right now and there's no python file for me to edit in the release. Can you elaborate on what I should do to test this PR?

clone the branch of the PR and run it.

or run my branch directly
https://github.com/axu2/kcc/tree/skip-pdf-pixels


Endogenous retroviral region

Definition: A region derived from viral infection of germ cells that has been stably integrated into the host genome and is passed on from generation to generation.
Parent: biological_region (SO:0001411)
Justification: A term other than the current endogenous retroviral gene (SO:SO:0000100) is desired because: In many cases, the entire viral genome - not a single gene - is integrated into the mouse chromosome. Some are complete and capable of producing active virus and/or of reintegrating at a new site, whereas others are incomplete or mutant and can no longer be activated.

Response from @keilbeck
[Term]
id: SO:0000113
name: proviral_region
def: "A viral sequence which has integrated into a host genome." [SO:ke]
subset: SOFA
synonym: "proviral region" EXACT []
synonym: "proviral sequence" RELATED []
is_a: SO:0001039 ! integrated_mobile_genetic_element
Should your proposed term be a child of this?
--K


tune2fs: Could not allocate block in ext2 filesystem while trying to create journal file

I have recently added the Silk GUI to one of my projects using NodeOS and I get this error:
tune2fs: Could not allocate block in ext2 filesystem
	while trying to create journal file

Maybe the filesystem is too small and you need to increase its size?
El 17/5/2017 4:03, "SpaceboyRoss01"<EMAIL_ADDRESS>escribió:

I have recently added the Silk GUI to one of my projects using NodeOS and
I get this error:
tune2fs: Could not allocate block in ext2 filesystem
while trying to create journal file
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NodeOS/NodeOS/issues/358, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgfvtASxzIcrGdzY1sauEay4T5_WfFZks5r6lVWgaJpZM4NdSWe
.

Any update on this @SpaceboyRoss01?


Getting errors in linux.

I'm getting the following error when trying to run in Red Hat, Rocky Linux and Fedora:
called Result::unwrap() on an Err value: reqwest::Error { kind: Decode, source: Error("expected value", line: 1, column: 1) }
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
And the following error in Ubuntu:
thread 'main' panicked at src/things/comment.rs:123:14:
called Result::unwrap() on an Err value: reqwest::Error { kind: Request, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("oauth.reddit.com")), port: None, path: "/api/editusertext", query: Some("raw_json=1"), fragment: None }, source: hyper::Error(Connect, ConnectError("dns error", Custom { kind: Uncategorized, error: "failed to lookup address information: Try again" })) }
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
Was only able to get it running on Windows. Any help with this? I wish I knew better rust to help troubleshooting.

Same here. on WSL.
  2024-09-10T01:58:00.704591Z DEBUG  No shreddit.env config file found.
    at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/shreddit-0.9.3/src/main.rs:37

thread 'main' panicked at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/shreddit-0.9.3/src/access_token.rs:21:10:
called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Request, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("www.reddit.com")), port: None, path: "/api/v1/access_token", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("dns error", Custom { kind: Uncategorized, error: "failed to lookup address information: Temporary failure in name resolution" })) }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Same here @ccampo133 - works 100% on MacOS, 0% on Ubuntu :(

I created a Go port that works on Linux if you're interested. It's not yet feature complete though https://github.com/ccampo133/shreddit-go

I use Ubuntu as well and it works fine for me. I'm on 24.04.
Please post details of your environment, like the specific Ubuntu version as well as the error you get. Otherwise there isn't much I can do.

I've updated the title of this issue to the specific error message. If anyone is getting a different error please create a separate issue.

Could someone who's getting this DNS error please post the specific command / config they're using (redacting any sensitive info like client secret / password)?

It's trivial to reproduce this with GitHub actions with the latest Ubuntu runner using a Docker image such as https://hub.docker.com/r/dmintz37/shreddit-dockerized.
I can post details later as I'm on my mobile at the moment but it should be fairly self explanatory. Just create a workflow to run that image and you'll see the error.

Could someone who's getting this DNS error please post the specific command / config they're using (redacting any sensitive info like client secret / password) as well as the shreddit version?

Shreddit version 0.9.3
Ubuntu 22.04.5 LTS
Command:
./shreddit --username [USERNAME] --password [PASSWORD] --client-id [CLIENTID] --client-secret [SECRET]

Output:
thread 'main' panicked at /home/[USERNAME]/.cargo/registry/src/index.crates.io-6f17d22bba15001f/shreddit-0.9.3/src/things/post.rs:168:10:
called `Result::unwrap()` on an `Err` value: reqwest::Error { kind: Decode, source: Error("expected value", line: 1, column: 1) }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


Will I get current location even if the app is killed or terminated ?

I want to get user current location even if the app is killed or terminated. And When user start walking, location must be updated even if the app is killed or terminated.. Is it possible ??

@KrLikeblue You can monitor for significant location changes
https://developer.apple.com/reference/corelocation/cllocationmanager/1423531-startmonitoringsignificantlocati

If you start this service and your app is subsequently terminated, the system automatically relaunches the app into the background if a new event arrives.

Does this mean that even if I have subscribed to continuous updates using subscribeToLocationUpdatesWithBlock my app will not get notified if application terminates. To get notified after the app has been terminated, I need to subscribe using subscribeToSignificantLocationChangesWithBlock also and when didFinishLaunchingWithOptions is called with UIApplicationLaunchOptionsLocationKey, I need to subscribe again with subscribeToSignificantLocationChangesWithBlock and subscribeToLocationUpdatesWithBlock.
Can you please confirm ?
Thanks.

@bishtpradeep Correct. If your app is terminated, you can only get location updates using significant location changes (every ~500m or so).

Thank you for such a quick response.
I was not sure about the re-subscription at launch-after-termination. The README says:
Note that when the app terminates, all of your active location requests & subscriptions with INTULocationManager are canceled. Therefore, when the app launches due to a significant location change, you should immediately use INTULocationManager to set up a new subscription for significant location changes in order to receive the location information.
and then in example it re-subscribes.

(BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
// If you start monitoring significant location changes and your app is subsequently terminated, the system automatically relaunches the app into the background if a new event arrives.
// Upon relaunch, you must still subscribe to significant location changes to continue receiving location events.
if ([launchOptions objectForKey:UIApplicationLaunchOptionsLocationKey]) {
INTULocationManager *locMgr = [INTULocationManager sharedInstance];
[locMgr subscribeToSignificantLocationChangesWithBlock:^(CLLocation *currentLocation, INTULocationAccuracy achievedAccuracy, INTULocationStatus status) {
// This block will be executed with the details of the significant location change that triggered the background app launch,
// and will continue to execute for any future significant location change events as well (unless canceled).
}];
}
return YES;
}

@bishtpradeep Apologies; it's been a while. If that's the case in the readme, then I would go that approach (re-subscribe).

okay. Thanks again.

Hi, @iwasrobbed thanks for the awesome lib . But in iOS11 ,maybe it is not working.
In iOS 11 startMonitoringSignificantLocationChanges working fine in background but not working if killed the app.
I am using NSLocationAlwaysAndWhenInUseUsageDescription and NSLocationWhenInUseUsageDescription both key i added in plist. Always authorization i am getting. Even in background its working fine. but if kill the app, location update is not working.
What i have to do fix this issue? Please help on this.

@mrshyi I haven't used this library in a couple of years now (and I'm not the maintainer). To be completely honest, you're probably better off just using the iOS APIs since they are fairly simple to use. Keep in mind you need to test on device and iOS 11 had a lot more privacy changes in it so I'd look around for others having issues with the significant updates.

if you are willing to use VOIP push see this link - https://www.appcaretaker.com/2018/06/05/how-to-get-iphone-ipad-current-location-even-if-app-is-terminated-not-running-in-background/

Use FusedLocationProviderClient and start stop location updates using Broadcast instead of services as according to Android docs in future updates in os will limot assess use of services due to optimisation check location updates in background example application https://www.freakyjolly.com/android-background-geolocation-service-without-any-kill/

@sheshnathiicmr link is not working. is any other option.


Check out initial resources to derive search terms and potential contacts

Prof Bouter suggested that we contact the key people at the following organizations:

https://www.ukrn.org/
https://reproducibilitea.org/
https://www.openscience.nl/en/open-science-communities

Prof Bouter suggested the following articles as a starting point:

https://doi.org/10.12688/f1000research.74831.1
https://doi.org/10.1093/scipol/scab039
https://doi.org/10.1371/journal.pbio.3000246

@lwjohnst86 @danielibsen @MarioGuCBMR Forgot to tag you in! I'm just emailing each of the suggested organizations to get the ball rolling :)

Great @hchats. There should be enough time until our next working day for me to go through the links and papers.


Problem with compiling rails apps

Hello, I have some problem with compiling rails apps.
Log operations at this gist.
Can I fix this problem?
Thx.

did you use rubyc version v0.4.0?

I have different problems at 0.4, and 0.5 versions. Currently I using 0.5 version from master branch.

I used rubyc for packing my rails app, and I had some problems with v0.5.0. Successful build was with v0.4.0. So I suggest:

try to use v0.4.0
try to build app without problem gems(comment nokogiri in Gemfile)

Nokogiri is dependency at gem rails-dom-testing, and rails-dom-testing is  dependency at many core rails gems.

I created little example how to pack rails app with nokogiri gem https://github.com/iamsimakov/rubyc-usage-example
There I used docker to build application. So just try it.
If it helps to you, it will be so cool)


Update error messages which returned from ibc-go

Closes: #XXX
Description

PR author checklist:

[ ] Added changelog entry, using unclog.
[ ] Added tests: integration (for Hermes) or unit/mock tests (for modules).
[ ] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

Wow, thanks for noticing and fixing this!

Good catch, thank you for the fix!
@ljoss17 and I bumped into this copy/past error just yesterday. We decided not to to anything with it until we understand what's up with the sdk_error_from_tx_result and the ClientError type.
My findings so far are:

It seems like we introduced this new type as part of error type refactoring in #988 and never made use of it.
Originally, the code comes from a big lift of Soares to categorize all error types and improve error handling overall in the relayer pipeline: #950 (file ref here). That PR was never merged, but I think the changes somehow slipped in master via #988.
That being said, I am on the fence whether to delete the code altogether or keep it around. It's unused so not a big maintenance burden or liability + it may prove useful in the future.

Since you fixed it for us, it seems like a good idea to keep the code, unless Romain has a different opinion -- will defer to him.

Just for my own understanding, were these error message changes done so that they would match the errors returned by ibc-go?

Just for my own understanding, were these error message changes done so that they would match the errors returned by ibc-go?

The error string was wrong (copy/paste error). The changes were not done so that they match ibc-go, but so that the error string is consistent with the error type. The error codes have been copied from IBC-Go.

Thanks for the catch. Yes it was copy/paste errors when copying the error messages from the original definitions to the new error definitions using flex-error. Since there are so many error definitions, it was easy to slip up and copy wrongly.


Advance Topic: Composite storage items

Content request
One of the new things that we have been experimenting with in the FRAME team is composite storage item. These are not a new abstraction that FRAME provides, but rather something that we have learned to do over time, and I think it is valuable for the community to also follow.
It goes like this: If you have multiple storage items that are highly inter-linked together, and updating one will need to trigger updates in other ones as well, it is highly advisable for you to:

Make these storage items as private as possible.

Write a wrapper struct for them, that manages these update for you.

This wrapper will:

forces you to think about the entry points where you could potentially mutate these inter-linked data, and helps you make sure you don't miss anything.

Here's the only example of this that exists in FRAME now: https://github.com/paritytech/substrate/blob/c087bbedbde16711450c186518314903a2949cb3/frame/election-provider-multi-phase/src/signed.rs#L116
I personally consider this a low-priority work, since it is an experimental opinion about how to do things, not even a FRAME feature per-se.
Are you willing to help with this request?
Yes!

Great, thanks for surfacing this @kianenigma ! This sounds like it should be a short write-up in our best practices page. I'll start by writing something up and if its not too high priority we can include it in the new restructured docs and have it published there once it's ready.
A couple of questions:

In what scenarios would someone want to have a composite storage item?
What does this optimize?
What are the risks involved if this recommendation is not followed?
(this more for my understanding) Is this related to FRAME's transactional macro at all? If yes how and if not how do they contrast in terms of usage and whats happening under the hood?

In what scenarios would someone want to have a composite storage item?

When you have multiple storage items that are interlinked. For example, where mutating one of them must always follow with mutating another one as well. A simple example of this would be a map with a counter, although now we have CountedMap as well.

What does this optimize?

It prevents developer errors and common pitfalls, otherwise performance wise it is the same.

What are the risks involved if this recommendation is not followed?

You might end up with inconsistent state.

Is this related to FRAME's transactional macro at all?

In my opinion they are fully unrelated.

Please let me know if my example of counter is sensible, that's an important foundation to get.

The example of a counter makes sense, yep. Thanks

has any progress been made on this? otherwise I'd like to try and write something myself.

has any progress been made on this? otherwise I'd like to try and write something myself.

No, not yet. Please go ahead ! This will be useful content in our soon-to-be "Design" section (under: Storage design decisions).


Make grid size configurable

It would be nice to make the grid size configurable.

Done in 7b17412a652a5cbfffd630a3073233d576f34a94.


DBZ-5821 Quarkus outbox extention never finish open tracing span

https://issues.redhat.com/browse/DBZ-5821

Applied to main (=2.1) and branch 2.0.


[MSTeams][Android/Ios] [Adaptive card input.choice set placeholder not getting displayed]

Platform
What platform is your issue or question related to? (Delete other platforms).

Android
iOS

Author or host
MsTeams
Details
I used the placeholder property of adaptive cards in the input.Choiceset schema of adaptive cards. I added the placeholder text for the input.Choiceset drop down. The placeholder text was displayed in the desktop teams but when i checked it for mobile teams(android/ios) the placeholder text was not displayed.
I then tried adding the value field to the placeholder and then tried to render it for both the platforms. The teams desktop i am getting default placeholder text displayed in card but this time in mobile(android/ios) teams the card displayed the first value from the drop down list. In both the cases i was not able to display the placeholder text in mobile(android/ios) teams.
As well in desktop teams also i am getting the default text value (Select an option) even if give other placeholder values.
please find attachment for more details
PlaceHolderIssueJson.txt

I need a fix for this issue as it is creating a roadblock in my project. Please help.

@Sujit-Gaikwad
This is not an officially supported feature across the all the renders; we do have a road map for it, but at this point only JS renderer (desktop) supports it.

@siduppal / @dclaux could you help with the Desktop aspect of this question (see description above):

As well in desktop teams also i am getting the default text value (Select an option) even if give other placeholder values.

any updates on this issue??

Any update on this

@almedina-ms would the work around Input evolution address this behavior at all or were we saying PlaceHolders are not something the Accessibility team has been advocating for features and we should deprecate support for it? @dclaux for FYI also

Any progress / update on this issue??

@shalinijoshi19 , @jwoo-msft Are there any timelines for this? This bug was part of the P0 bugs that I had earlier shared with the team

any updates on this??

@jwoo-msft, @shalinijoshi19,
This issue applies to the placeholder in input.choice set component as per the title.
We have a similar issue(4484) created for other input components as well.
Hope this bug(4484) will also be addressed as part of the current fix.
cc: @VikrantSingh01, @anbah34, @shbhadra

@Gunashree-R-V we have been re-evaluating guidance and support for placeholder elements and usage in card design over various discussion, esp due to bad Accessibility implications on the card design they may have- Are you able to leverage labels that shipped with adaptivecards 1.3 earlier last month for these scenarios? Do you actually have a use case for placeholders in the card design here?


rename repository

the current name describes what it contains but not what is does.
suggestion: phovea_common_style

Further suggestion: phovea_app_style

and: phovea_ui


Resolved.
Forgot to add rbenv to .bashrc


CoL+ spoils data presentation in authorstrings

Please compare original authorstring presentation in FishBase taxa:
Aphyosemion calliurum ahli (non Myers, 1933) | misapplied name for Aphyosemion herzogi Radda, 1975 | FishBase
Aphyosemion calliurum ahli (non Myers, 1933) | misapplied name for Fundulopanchax gardneri (Boulenger, 1911) | FishBase
Aphyosemion calliurum ahli Myers, 1933  | synonym for Aphyosemion ahli Myers, 1933 | FishBase
http://www.catalogueoflife.org/annual-checklist/2019/search/all/key/Aphyosemion+calliurum+ahli/fossil/1/match/1
and presentation after CoL+ transformations:
Aphyosemion calliurum ahli | misapplied name for Aphyosemion herzogi Radda, 1975 | FishBase
Aphyosemion calliurum ahli | misapplied name for Fundulopanchax gardneri (Boulenger, 1911) | FishBase
Aphyosemion calliurum ahli Myers, 1933 | synonym for Aphyosemion ahli Myers, 1933 | FishBase
http://workbench.catalogueoflife.org/col_plus/search/all/key/Aphyosemion+calliurum+ahli/fossil/1/match/1
It would be better, if CoL+ do no take off any parts in authorstrings.
Expected behavior: Identified issues in authorstrings should be reported to GSD authors and editors for their decisions.
Another example of CoL+ problems with authorstrings is automatic exclusion of names with "ined." and "comb. ined." portions in authorstrings. These issues should be reported, but not modified without editorial decision.

These are not removed really, just parsed into different parts.
Taxon concept phrases like the one for misapplied names, e.g. "non XYZ" are found in the API in accordingTo and rendered in the CoL+ UI.

I take this as a bug to fix the export!

Authorstrings are empty in a product.

It is wrong to remove (non Myers, 1933) from the authorstring, because it says a lot to taxonomists.

The manuscript name exclusion is done deliberately and you agreed with it:
https://github.com/Sp2000/colplus-backend/issues/350
@yroskov If you don't want that anymore we can easily remove the automatic filtering again. It's done on purpose to avoid excessive manual decisions. There is no point in manually removing all of them. Either they all stay in or all are out. Or what would be the reasoning for deciding on manuscript names case by case?

All cases of manuscript names are different.
There are about 500 provisionally proposed names in WCSP, WPlants & WFerns. GSD authors intended to present consistent classification based on modern data. We must not simply delete all these species without asking authors first.

please reopen the issue above and explain your expected behavior instead if you want that to be changed

done: #269

blocked by #598

we are using verbatim authorships in the export now, so not blocking milestone anymore


Facet & Continuous Colorscale, multiple CLims

If you do facet_grid and have multiple continuous colorscales, they each are mapped on the full scale, instead of their respective domains.
See for example this code:

figure
g = gramm('x',repmat(1:10,1,20),'y',1:200,'color',1:200)
g.geom_line()
g.facet_grid([repmat({'1'},40,1);repmat({'2'},160,1)],[])
g.draw

Same thing for facet_wrap.
And here is a screenshot of the output.

Ooops, a line that shouldn't have been commented was.... It's corrected now. I also added a way to set continuous color colormaps, so now your example can be turned to this if you want parula. I also added a 'group' for separating the lines.
figure
g = gramm('x',repmat(1:10,1,20),'y',1:200,'color',1:200,'group',reshape(repmat(1:20,10,1),1,200))
g.geom_line()
g.facet_grid([repmat({'1'},40,1);repmat({'2'},160,1)],[])
g.set_continuous_color('colormap','parula')
g.draw


A* pathfinding

SS13 have some AI mob I think they move according to an A* pathfinding algorithm.

However, it is not needed to implement the algorithm in advance because I assume that it will not be used in next couple of years.


Missing parameter destroys following

This does not work, $1 and $2 empty:
 "pass-arguments-to-command":
    [
      {
        "source": "payload",
        "name": "actor.username"
      },
      {
        "source": "string",
        "name": "/home/myself/website"
      }
    ]

This works, $1 has value, $2 empty:
"pass-arguments-to-command":
    [
      {
        "source": "string",
        "name": "/home/myself/website"
      },
     {
        "source": "payload",
        "name": "actor.username"
      },
    ]

Which version of webhook are you using and what is the payload you are sending the hook. Sounds like an old bug we fixed where parameter extraction would stop after first fail (which explains your examples).

I am running the default webhook from the Ubuntu ppa, like a good citizen ;)
How to determine? webhook -version does not show me anything, and webhook -help shows no version output?

Yeah, then you're running a 2.5.x which was affected with the issue #106.
The issue has been fixed in 2.6.0, I highly recommend downloading the latest version from the releases page.
Prior to the 2.6.0 the only way to determine the version was to run the webhook with -verbose flag and to check stdout.

Thank you... wish the ppa was updated though... :


doesn't work inside module

Hey @dtolnay, thanks a lot for this crate.
I'm trying to register submits from different modules, and it only works at the top level. Am I missing something?
  inventory::submit! {
      OcamlFunc::new("something") # this works
  }

  pub mod inside_mod {
      inventory::submit! {
          super::OcamlFunc::new("something_else") # this doesn't appear in the iter
      }
  }

@mimoo Did you figure out what was causing your issue? Could you help me understand what went wrong?

no, I ended up using another crate (const-random)


W codes

running jshint produces something like:

editor.js: line 132, col 27, Did you mean to return a conditional instead of an assignment? (W093)

where can I find a map of these "W" codes to the option names? couldn't we just include the option name in the error message (so I know what to turn off)?

You can find it here (but it is a little outdated):
https://jslinterrors.com/?linter=jshint

This information is not currently available. There is a long-standing feature request for that, though: https://github.com/jshint/jshint/issues/1270. This issue is essentially a duplicate of that one, so I'm going to close it.


"Hold open" doesn't work with "Dub's bad hygiene"

Describe the bug
"Hold open" toggle resets when a pawn walks thru the door.
To Reproduce
Steps to reproduce the behavior:

Load any save
Designate a door to be held open
Draft a pawn and make them walk thru it
The door is now held open
Make the pawn go thru the door again.
The door closes

I actually noticed if you click hold open again after they started walking out of the cell, it will stay open. Pls confirm

I actually noticed if you click hold open again after they started walking out of the cell, it will stay open. Pls confirm

Did some more testing into this issue and have found Dub Bad Hygiene to be a near probable cause of this. Tested without Dubs and doors are held open just fine and are working as intended, enabled Dubs and this issue immediately came back.
Very reproducable, all you need to do is enable both RT and Dubs Bad Hygiene, start a new world, force a door to be held open and bam, bug rears it's head. Recorded some footage below to show consistency of bug.
https://www.youtube.com/watch?v=kaXpNjXE7tE

Did some more testing into this issue and have found Dub Bad Hygiene to be a near probable cause of this. Tested without Dubs and doors are held open just fine and are working as intended, enabled Dubs and this issue immediately came back.
Very reproducable, all you need to do is enable both RT and Dubs Bad Hygiene, start a new world, force a door to be held open and bam, bug rears it's head. Recorded some footage below to show consistency of bug.
https://www.youtube.com/watch?v=kaXpNjXE7tE

Confirmed to be dubs hygiene 100%

Confirmed to be dubs hygiene 100%

Seems to have been fixed on the dubs side with their recent update
Tested by Nextia and me.


git clone with proxy encountered bug

Windows Version
Microsoft Windows [Version 10.0.22621.3527]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-2
Distro Version
Ubuntu 22.04
Other Software
No response
Repro Steps

Proxy Client : v2ray, i use it to do proxy for my windows, and set in .wslconfig autoproxy=true, like:

[wsl2]
networkingMode=mirrored
dnsTunneling=true
autoProxy=true
localhostForwarding=true

Then I try clone my repository from github to my wls home dirctory, but i get :

and i can see it in v2ray log, github.com is proxy status

if i turn v2ray off , tring clone in wsl, and i will get access my proxy port 10809 failed, it still tries to use proxy, this is also not normal behavior i think.
please help me, why i get this, and how to figure it out.

Expected Behavior
complete cloning
Actual Behavior
git clone interrupted by some thing else
Diagnostic Logs

additionally, i can use proxy to complete "git clone"m, so i think there is some problem with wsl network with proxy

Hi. Can you please collect networking logs by following the instructions below?
https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#collect-wsl-logs-for-networking-issues


Clean up tutorial

This addresses two issues with the tutorial:

There was an inconsistency in the number format for the credit statement example.
The get and set commands around the absolute value calls have been split into two lines to increase readability.

Docs Build status updates of commit b138d0b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/tutorials/excel-tutorial.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


chore: remove unused InstrumentationConfig#path

Which problem is this PR solving?
Short description of the changes
Removed the unused field InstrumentationConfig#path as it seems it's not used anywhere. The comment there is also outdated so can't tell if it was ever used.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
CI
Checklist:

[x] Followed the style guidelines of this project
[ ] Unit tests have been added
[ ] Documentation has been updated

Actually I'm not sure if changes like this in experimental modules should be marked as breaking or housekeeping.

Actually I'm not sure if changes like this in experimental modules should be marked as breaking or housekeeping.

I think it's ok to mark it as chore in this case


Scaling tool, first version

scaling tool for x,y,z scaling
undo/redo of scaling not implemented yet
issue: scaling in xyz will reset previous values

Not bad for a first version. Can you fix the issues before i merge it?
The handles are also a bit weird...especially if the model is really big. You could use the arrow handles from the TransformTool for now. Ideally it should look like this, but arrows are ok too.

That issue was a hard one :/
Scaling of tool is not fixed. There is a problem:
The method gameObjectSelected() is never called. So i can't scale the handles.
I looked in translateTool it where it is working and called.
I don't get the point why it is not working ...

Hmm, that's strange. I did a quick test, and it gets called.
Switching between tools is still a bit messy, because it always defaults to the TranslateTool if no tool is selected.

Click ESC to reset your current tool.
Select the scale tool
Right click on the object.
gameObjectSelected() in the scale tool will be called (once)

AHH. Ok i always used the outline. Learned something new :-)
It will not be called if the user only uses the outline to select the object.

That's good. This is how we discover bugs and un-userfriendly ux ;)
I'll create a issue for that.

Pretty nice, thanks!


Release v1.0.0 - First Stable Version

Develop and release the first stable version of the Telegram Notifier package. This package will handle incoming requests via an API and send notifications to Telegram. Ensure the package is fully functional, well-documented, and adheres to best practices.

Resolved in #3 !


Better README

Since this is now a public project, I would suggest improving upon the README to clearly explain what this package aims to do. This would give viewers and possible contributors a clear idea of what's expected.
:)

The README will be expanded in due time, opening an issue for this is not helpful.

The README will be expanded in due time, opening an issue for this is not helpful.

In that case, would you mind explaining to me the purpose of this project here? What does Weasel aim to achieve?
When having an open source project, I firmly believe in making the purpose of the project clear. This makes contributing and comparing easier.

@adrianeboyd.


.CR2 raw image parsing

Many requests involve analysing RAW images. Currently, PyTrx is compatiable with JPG and PNG images. This is largely because of differences in the image EXIF information, which PyTrx uses to gather information about each image. Routines are needed to ensure that RAW images can be ingested with compatible information.

Completed with new package import, rawpy. Remember to add this to dependencies.


ODIN doesn't converge

For whatever reason ODIN's loss doesn't want to converge.

#17 is also relevant here because it would make it easier to see why.


JavaSyntaxError when using Java 8's stream.toArray

When using Stream.toArray(), a JavaSyntaxError is raised because it doesn't understand how to parse the .toArray(Object[]::new) call.
example:
 Person[] men = people.stream()
                      .filter(p -> p.getGender() == MALE)
                      .toArray(Person[]::new);

Even I am facing a similar issue. And there are other java 8 constructs which haven't been looked upon. Is there a scope of adding java 8 support to this super exciting project?

You could always open a pull request to add support for what you need :-)


Remove metering from deep insights capability

Signed-off-by: Shirly Radco<EMAIL_ADDRESS>
Description of the change:
Since metering is a deprecated feature, removed it from the Deep Insights capability level requirements.
Links to deprecation notice:

https://github.com/kube-reporting/metering-operator
https://docs.openshift.com/container-platform/4.8/metering/metering-about-metering.html

Motivation for the change:
Incorrect requirements for Deep Insights capability level creates confusion.
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

@camilamacedo86 please review

@dmesser Please review this PR

/lgtm


Build fail of exchange_perftest.cpp

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)

Debug build with option -DCMAKE_BUILD_TYPE=DEBUG.
mkdir build
cd build && cmake .. -DCMAKE_BUILD_TYPE=DEBUG && make -j 7

2. What did you expect to see? (Required)
No error message.
3. What did you see instead (Required)
Though executable file tiflash successfully built, some error messages are output to the terminal.
tiflash/dbms/src/Flash/tests/exchange_perftest.cpp:527:25: error: no member named 'addTunnel' in 'DB::MPPTunnelSetBase<DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>>'
            tunnel_set->addTunnel(tunnel);
...
...
...
tiflash/dbms/src/Flash/Mpp/MPPTunnel.cpp:197:26: error: no member named 'write' in 'DB::tests::(anonymous namespace)::MockWriter'
            if (!writer->write(*res))
                 ~~~~~~  ^
tiflash/dbms/src/Flash/Mpp/MPPTunnel.cpp:281:21: note: in instantiation of member function 'DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>::sendJob' requested here
                    sendJob();
                    ^
tiflash/dbms/src/Flash/tests/exchange_perftest.cpp:525:21: note: in instantiation of member function 'DB::MPPTunnelBase<DB::tests::(anonymous namespace)::MockWriter>::connect' requested here
            tunnel->connect(writer.get());
                    ^
In file included from tiflash/dbms/src/Flash/tests/exchange_perftest.cpp:29:
tiflash/dbms/src/Flash/Mpp/MPPTunnel.cpp:225:17: error: no member named 'writeDone' in 'DB::tests::(anonymous namespace)::MockWriter'
        writer->writeDone(grpc::Status::OK);
        ~~~~~~  ^
tiflash/dbms/src/Flash/Mpp/MPPTunnel.cpp:168:25: error: no member named 'tryFlushOne' in 'DB::tests::(anonymous namespace)::MockWriter'
                writer->tryFlushOne();
...

And IDE shows that no member function for addTunnel().
4. What is your TiFlash version? (Required)
Current master branch.

Closed as duplicated to https://github.com/pingcap/tiflash/issues/4276
Workaround by using make -j7 tiflash


False positive with monorepo ESLint plugin package

I think I have found a bug with an unresolved import on knip version 2.40.1.
Steps to reproduce:
git clone git@github.com:IsaacScript/isaacscript.git
cd isaacscript
git checkout aa5b9e68ca3ec147d0b87ec83da8bd8a536dcf61
yarn
npx knip

Part of the output is as follows:
Unresolved imports (11)
eslint-plugin-isaacscript/recommended  .eslintrc.cjs
eslint-plugin-isaacscript/recommended  packages/docs/.eslintrc.cjs
eslint-plugin-isaacscript/recommended  packages/eslint-config-isaacscript/.eslintrc.cjs
eslint-plugin-isaacscript/recommended  packages/eslint-plugin-isaacscript/.eslintrc.cjs
eslint-plugin-isaacscript/recommended  packages/isaac-lua-polyfill/.eslintrc.cjs
eslint-plugin-isaacscript/recommended  packages/isaac-typescript-definitions/.eslintrc.cjs
eslint-plugin-isaacscript/recommended  packages/isaacscript-cli/.eslintrc.cjs
eslint-plugin-isaacscript/recommended  packages/isaacscript-common-node/.eslintrc.cjs
eslint-plugin-isaacscript/recommended  packages/isaacscript-common-ts/.eslintrc.cjs
eslint-plugin-isaacscript/recommended  packages/isaacscript-common/.eslintrc.cjs
eslint-plugin-isaacscript/recommended  packages/isaacscript-spell/.eslintrc.cjs

Here, eslint-plugin-isaacscript is one of the packages in the monorepo, containing monorepo-specific ESLint rules. This kind of thing is sort of common in JavaScript/TypeScript monorepos.
Thus, this is a false positive, and I believe Knip should not be showing me the output. However, this is kind of a tricky situation, because normally, ESLint plugins are installed in the "package.json" file as a dependency. IMO it doesn't make sense in a monorepo for the root monorepo itself to depend on one of the child packages that it contains, as that would be a dependency cycle. So for my monorepo, the build output is copied to the root "node_modules" folder in a postinstall script. I'm not 100% sure if this is idiomatic in the TypeScript ecosystem, but this was the solution that I landed on after consulting both the official TypeScript and ESLint Discord servers.
So in this case, it's reasonable for Knip to not know that a monorepo subpackage is being manually copied to the root node_modules, but on the other hand, Knip should know that eslint-plugin-isaacscript is a subpackage, because I already have a specific workspace entry for it in my knip.json file. So I think Knip should be smart enough to be able to figure this one out on its own. Or barring that, I should be able to specify something in the knip.json file like internalPackages: ["eslint-plugin-isaacscript"] to suppress this error.

This is a very specific convention of ESLint only: the /recommended part is not a path, but a config identifier. Since the eslint-plugin-isaacscript/recommended does not lead to a JS file (e.g. packages/eslint-plugin-isaacscript/recommended.js does not exist) this is listed as unresolved. What the Knip's eslint plugin should do here is make an exception, but only for the plugin:isaacscript/recommended specifier in extends options that are prefixed with plugin: (because without the plugin: it should resolve to a JS file).

:rocket: This issue has been resolved in v2.41.1. See Release 2.41.1 for release notes.


android: remove default textColor of #0 on Android.

This was introduced in 8919a6aeb, to achieve consistancy with iOS.
With the changes made in 4db472a2e, this becomes the cause of an
inconsistancy where setting system dark mode in android, makes the
text colors black within a dark colored alert dialog box, giving a
poor color contrast and overall bad look to the dialog box.
This commit makes the color white on dark background and black on
light background, based on the theme.
Similar issue on upstream:
https://github.com/facebook/react-native/issues/31345
Discussion on CZO:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/Dark.20theme.20issue.20on.20Android
Before

After (Dark)

After (Light)

@chrisbobbe you may take a look at this.

Thanks! Merged, with a small tweak: I changed the CZO link so it points to a specific message instead of the whole topic, since we don't know what future discussion might happen in the topic. 🙂


Turn bounding_box class to function

The bounding_box class:
https://github.com/ACCESS-NRI/replace_landsurface/blob/2dcc1d77ca4fb7d4dcb6311db575bd2b21d700b4/src/replace_landsurface_with_ERA5land_IC.py#L37-L115
ultimately, is used to get the extents of the input file in terms of min and max longitudes and latitudes (lonmin, lonmax, latmin and latmax).
The class does not currently hold any methods (apart from the __init__) or attributes apart from the lat/lon extents it needs to produce.
I suggest turning it into a function to:

simplify the code
simplify testing

Indeed, the single method/__init__ only class is a sign of unclear design. Also, __init__ is doing multiple things: file I/O, lat/long calcs, control flow, array ops & setting member vars. It's a sign to break down the problem into smaller pieces.
Shapely may suit for providing generic geometry data structures too:
https://shapely.readthedocs.io/en/stable/manual.html


Adding prometheus metrics to OADP must-gather

Adding prometheus metrics to OADP must-gather

Looks good, I'm going to hold off on merging as the actual exposed metrics are changing potentially... will get this in the next few days.


Add UUID to latency1 model

This PR uses the mechanism introduced in #17 to save the UUID of each incoming HTTP connection in the request's context. Then, the UUID is retrieved from latency1's  /authorize handler, added to the in-memory session and eventually to the archival data.
This establishes a link between the UDP-based latency1 measurement and the TCP connection that started it, and allows joining the latency1 data with uuid-annotator's annotations in BigQuery.
Stacked on top of #17.

This change is

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 7 (57.14%)  changed or added relevant lines in 2 files are covered.
16 unchanged lines in 1 file lost coverage.
Overall coverage increased (+1.1%) to 84.361%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/latency1/latency1.go
3
6
50.0%

Files with Coverage Reduction
New Missed Lines
%

internal/handler/handler.go
16
86.01%

Totals

Change from base Build<PHONE_NUMBER>:
1.1%

Covered Lines:
766

Relevant Lines:
908

💛  - Coveralls


feature:(arrayEquals) fixes 171, search param order shouldn't matter

I modified the arrayEquals function so that we don't sort before doing cheaper condition checks (isArray, length).
Since the search params array will just be an array of strings maybe a sort on both before every item comparison.
In addition I changed every to some so that it stops iterating once it has found a non match.
Fixes #171

you might need to fix the prettier as well

Updated the branch, I amended to the original commit. Actually ran lint this time, and added a test for the mutation of the original arrays.

Thanks for taking this change in so quickly. And many thanks for providing the addon, it's extremely useful.


Flutter - method  getDialogs() does not return public dialogs to others users -

Specify the sample to which the issue belongs (use [x]):
[x] Chat sample
[ ] P2P Call sample
[ ] Conference Call sample
Platform (use [x])
[x] Android
[x] iOS
Describe the bug:
I am using the connectycube flutter sdk, the issue am facing is that when I call method getDialogs() so I can get public dialogs it only return groups a user is added and the ones he created. Please help out.

If your user wants to get public dialogs, he should subscribe to it first. Use this API for subscription to public dialogs.


Add Previously Undetected Bot Spotter Accounts to Blacklist

Adds "jflessauSpam", "bryster125" and "MobileTekReview" Twitter accounts to blacklist.

Updated the issue with more accounts.


upgrade to 3.4 and fix interface changes

Note: Can we create a separate branch for this change to merge into? The changes are only compatible with scala-deequ version >=2.0.4  and not backward compatible. It will look fractional if we make it work universally since for the same class both new and old interfaces need to be invoked.

Issue #, if available:
https://github.com/awslabs/python-deequ/issues/148
Forward compatibility issue for scala deequ version >=2.0.4.
Description of changes:
Update the invocation code according to the change of the Scala "deequ-2.0.6-spark-3.4" version interfaces
The interface changes include

Analyzer class

Compliance
Histogram
MaxLength
MinLength
Mean

Check methods

hasMaxLength
hasMinLength
satisfy

Logic change

prioritize StringColumnProfile over StandardColumnProfile

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Note: Can we create a separate branch for this change to merge into? The changes are only compatible with scala-deequ version >=2.0.4 and not backward compatible. It will look fractional if we make it work universally since for the same class both new and old interfaces need to be invoked.

Currently we don't want to maintain separate branch for different version combinations. I agree we shouldn't make the code fractional to achieve the goal and we are working with a long-term plan with changes in Deequ core ideally. I'll share more details around early Jan.
Let's keep this PR open for more ideas.

Thanks for your update. That sounds good.
获取 Outlook for iOShttps://aka.ms/o0ukef

发件人: Chenyang Liu @.>
发送时间: Thursday, December 14, 2023 11:18:31 PM
收件人: awslabs/python-deequ @.>
抄送: Angelo Ni @.>; Author @.>
主题: Re: [awslabs/python-deequ] upgrade to 3.4 and fix interface changes (PR #178)
Note: Can we create a separate branch for this change to merge into? The changes are only compatible with scala-deequ version >=2.0.4 and not backward compatible. It will look fractional if we make it work universally since for the same class both new and old interfaces need to be invoked.
Currently we don't want to maintain separate branch for different version combinations. I agree we shouldn't make the code fractional to achieve the goal and we are working with a long-term plan with changes in Deequ core ideally. I'll share more details around early Jan.
Let's keep this PR open for more ideas.
―
Reply to this email directly, view it on GitHubhttps://github.com/awslabs/python-deequ/pull/178#issuecomment-1856041367, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AK7M4FCIMNLP76WRBDXMIJDYJMKEPAVCNFSM6AAAAABAUDCBQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGA2DCMZWG4.
You are receiving this because you authored the thread.Message ID: @.***>

Hey @anqini @chenliu0831, is there a potential date to merge this PR? Looks like Deequ is already adding support to Spark 3.5

Closing this PR for now - we do not plan to maintain multiple branches and the changes mostly likely have to go to Deequ


Adding 103-Fire-Effect

Adds challenge 103 - Fire Effect (although the same project is labeled as "Flames" in some places)
I've also modified index.json, comparing the file with other challenges and specifically the file from challenge 102 - 2D Water Ripples:

"languages": added processing since the challenge includes a Processing version
"codeExamples": included the links for the p5js web editor and connected code in a single entry
"groupLinks": added descriptions for the references and videos associated with the challenge

Finally, I've updated one of the contributions to link to the source code in the "source" field.

Let me know if you need more changes @kfahn22.
I saw you modified the index.json file in other similar pull requests and I will follow your lead.

Thank you for porting a challenge page!!  If you wanted to choose a couple of key topics (the entire list was auto-generated) and add icons, that would be great.

Similarly to the challenge for the 2D water ripple I've tried to list the steps in the timestamps field. Hopefully it's satisfactory.

Thank you, this looks great!!  Do you want to add any images? If not, I can add later.

Should I take a few frames from the video?

We have been running the code and getting an image using Coding Train Colors.  Here is a collection of the ones I have done, for reference.  I would be happy to create the index image, if you would prefer.
https://editor.p5js.org/kfahn/collections/aiHkHeT8h

The image relative to the demo makes absolute sense. I'm not familiar with the "Coding Train Colors" tool though. If I can learn how to process the image I'm up to it. Whichever way you prefer.

Running the demo and clicking "Save Image As..." seems to do the trick.

Would that be enough?

Oopsie, I got confused with the simple particle system.

Hey @borntofrappe thank you for doing this! You can add one of the images you have shown here to the image folder, and add the name of the image file to the image attribute of the code example. I'll add an image with coding train colours for index.png later on before we merge it

Here are the Coding train colors.

You would need to add an images folder and then add the code example images to the folder.

Thank you for the support @kfahn22 and @DenisovichDev

If you wanted to look at an example, 174-graphics-applesoft-basic would be a good one.

Great job!!!

There is one last optional thing you can add, but this is totally up to you!
We have been grabbing screenshots of the showcases.  For example, here is a screenshot of contribution2.  This image would be named contribution2.jpg and added to the showcase folder.  The one thing to be aware of is that there are size limits on the images (800px wide and max 500kb)
Otherwise, I will mark this as approved.  Again, thank you for doing this!!

If you don't mind to wait a few minutes I'll try my best. Had to leave my pc for a moment.

You are going great!!  And there is no rush.  Dan is really busy getting ready for the event is appearing at this weekend.

Just wanted to say thank you so much for contributing and @kfahn22 for helping facilitate!! Do we need the hacktoberfest-accepted label for it to count? I wonder if we should put that label on all pull requests this month just in case? I'll be back to reviewing things later this weekend and can answer questions ,etc!

Yes I think that would be wise too. Have great time at the event this weekend!

Unfortunately the fourth contribution doesn't have a live demo. Let me know if the other are sufficient 👍
Thanks again to everyone :)

Thank you so much @borntofrappe

Yes, it is not possible to get an image for all the showcases.  Thank you so much for doing this!!

@borntofrappe Thanks for the contributions!
@shiffman

Do we need the hacktoberfest-accepted label for it to count? I wonder if we should put that label on all pull requests this month just in case? I'll be back to reviewing things later this weekend and can answer questions ,etc!

For a PR to be accepted to hacktoberfest, any one of the following should be true:

The PR must be merged; or
The PR should have a hacktoberfest-accepted label; or
The PR must have an overall approving review.

i.e. The label is not really required to count for hacktoberfest, but it is an easy way to quickly 'accept' the PR, without actually merging it. So, I think we can put the label on all PRs to prevent the contributors from waiting for the PR to be merged to the repo.

I've removed the unnecessary fields as per #640
There was also a URL missing from one of the videos, apologies.

@dipamsen ah! thank you for the clarification! Good to know we don't need the label so if we forget it's not the end of the world!

This is so fantastic, great work @borntofrappe, I am so grateful for your contribution!
@kfahn22 if you want to work your magic and make a main thumbnail image for this one (and #635) in a separate pull request feel free!


MP4 Output

User should be able to output audio and video to an MP4 file.

When mp4 output will be available on the roadmap?


Bug: adds linked module react to the bundle on serverside

If I transpile a module that requires react internally, It will add that instance of react to the server bundle. In other words the node_modules directory of the transpiled modules is not added to webpack externals on server side.
This causes multiple instances of react to be loaded server side render and famous react hooks error.
I use NextJS 9.1.4.

Looks like this is not maintained anymore, https://github.com/martpie/next-transpile-modules/issues/50.


Configs aren't loading with the 5/22 update

Not sure why but I didn't change anything except deleting the custom_config.cfg file and updated the launch params to what's in the ultimateconfig.cfg file:
-lv -high +precache_all_survivors 1 -noborder -novid -console -nojoy -noforcemaccel -noforcemparms -noforcemspd +mat_motion_blur_percent_of_screen_max 0 +clientport 27666

Just noticed it isn't the configs that aren't loading but you put -noborder in the launch options. The screen brightness doesn't take effect unless you are in full screen mode under display mode in the option. That was what was making me think the configs weren't working.
Can you share the old launch options you had before the recent edits? With the new launch options here with noborder removed I still have to go into options every time and set the display mode to full screen since the game resets it every time i quit:
-lv -high +precache_all_survivors 1 -novid -console -nojoy -noforcemaccel -noforcemparms -noforcemspd +mat_motion_blur_percent_of_screen_max 0 +clientport 27666

Hi @HairyMilkshakes
I have reverted the commit and updated (removed mat_motion_blur_percent_of_screen_max) the launch parameters.
The old launch parameter did not have -noborder.
You can copy the new launch parameters that I have just updated.
You will also have to update autoexec.cfg file back to the file that I have reverted to.
The reason for switching to noborder was to reduce the amount of time this game hangs when you alt tab and out. This game has support for NVIDIA Freestyle filters, as such my intention was to allow it to be used instead of using the in-game brightness settings.
I will make this optional in the future edit with explanation.
Cheers and thank you!
J.

Thanks for the quick fix the reverted commits work well from tests just now. As FYI borderless windows display mode also doesn't support the below two cvars:
mat_monitorgamma								1.6		//# Brightest 1.6 - Darkest 2.6
mat_monitorgamma_tv_enabled						1		//# Set to 0 if the game is too bright for you

Hi @HairyMilkshakes
You are correct. The alternative way is to use GPU filters or ReShade to make the game brighter if we were to use borderless mode.
I will put this as an optional thing for a future update.
The reason for going borderless was to reduce the crashes and hangs that happen due to alt tabbing when map switching or loading into map, or just when randomly L4D2 decides to stop working when alt tabbed one too many times.
Cheers!
J.