Add settings.InitTLS after parsing the cmd line

Signed-off-by: Dominique Vernier<EMAIL_ADDRESS>Close: #4755
What this PR does / why we need it:
This PR allows to use environment variables like "HELM_TLS_ENABLE", "HELM_TLS_VERIFY"....
Special notes for your reviewer:
I just added a call to the settings.InitTLS(flags) in the helm.go and this will allow to read the environment variables:
var tlsEnvMap = map[string]string{
	"tls-hostname": "HELM_TLS_HOSTNAME",
	"tls-ca-cert":  "HELM_TLS_CA_CERT",
	"tls-cert":     "HELM_TLS_CERT",
	"tls-key":      "HELM_TLS_KEY",
	"tls-verify":   "HELM_TLS_VERIFY",
	"tls":          "HELM_TLS_ENABLE",
}

https://github.com/helm/helm/blob/master/pkg/helm/environment/environment.go#L124
to be taken into account.
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

Hi @itdove, thank you for the PR. Would you mind writing unit tests to cover these cases? That way we can verify that this fixes the issue it intended to solve. Thanks!

Have a look at TestRootCmd for an example. https://github.com/helm/helm/blob/744cd20eab4e0525bccbea957da2047d6b469e61/cmd/helm/helm_test.go#L159

After looking at the unit tests, it looks like we already cover the case where environment variables are being set on the command line. Would you mind looking further into what the issue is on your end? Thanks.

Don't how it could be on my end as with that change the HELM_TLS_ENABLE variable is taken into account otherwise is not....
If you look at the code you will see that the initTLS wasn't called.
When I display the settings and the tt.settings in that test all parameters are still at their orignal value
{ 300 kube-system /Users/dvernier/.helm false   false false  /Users/dvernier/.helm/ca.pem /Users/dvernier/.helm/cert.pem /foo} { 300 kube-system /Users/dvernier/.helm false   false false  /Users/dvernier/.helm/ca.pem /Users/dvernier/.helm/cert.pem /foo}```

for example the HELM_TLS_ENABLE is not set to true..
Wonder if there is a defect in the test too?
@bacongobbler

ok my bad... it seems it was already solved... I just did a build from master and it works... I don't know if it was a recent fix or if I tested with a to old version.


Add Fragment to the default export

Solves #5889
I'm not interested in signing the Contributor License Agreement, so anyone who wants to can go ahead and fork what I have to get this merged in.

Maybe just stop using default exports? And stop mixing both, it's a hack. This way is much cleaner.
import * as React from 'react';

@TrySound, thank you for sharing that workaround. It might be just what some people are looking for. Perhaps you could also share it with the maintainers over at prettier.io and other opinionated code formatting projects?
However, since default exports are part of the ES6 spec and it seems that Flow is trying to provide type information for the default export for React, is there harm in adding Fragment?

It's not related to formatting. In the future react will not be available as default export. Forcing yourself and others to use named exports with react will simplify transition.

In the future react will not be available as default export.

Interesting. I hadn't heard about that and my googlefu is failing me at the moment. Would you mind sharing where you found it?
Until the default export is removed, however, it is still just one opinion between valid options. If people want to continue using the default export up to the last minute (or up until there is a codemod script to do the heavy lifting for them), shouldn't they be allowed to?

Well flow force you to start using named exports. It doesn't make sense to add even more properties which still will be deprecated.

@TrySound this is about React's actual export. It is good, when flow forces me to import type { Node } from 'react';. But Fragment is not a magical type. It is an export of the library and it is really there.
Babel relies on that valid export and in my case I can not force it to use my local Fragment instead of React.Fragment. As result I get a valid code, which flow reports as invalid. The goal of flow is to provide types for the actual implementation (and the docs, of coarse https://reactjs.org/docs/fragments.html. There is no info about imports). Flow should not hide implementation details and confuse the users. Am I right?
One more to note. There are some folks (like me), that believe, that one should explicitly declare dependencies instead of saying 'I want to use here all the React can provide for me' (moreover React.Node is not that nice comparing to simply Node). I can't follow that code style, because it will break existing tooling, like babel, which will use React.Fragment behind the scenes and produce the code, that flow thinks to be invalid.

This probably can be closed.
/cc @vkurchatkin


Taze does not find updates

Describe the bug
I have a very simple project.
I did a fresh pnpm install.
I tried to use taze to update the dependencies.
It did not work.

nlx taze major did not show any updates
pnpm outdated did show updates
the npm-check-updates` also shows updates

See screenshot.

Reproduction

use this package.json
run npm i or pnpm i
run npx taze or with major or latest ; even with a globally installed version of taze
=> does not show any updates
run pnpm outdated or npm outdated and it shows updates

{
  "name": "kuddl-dev",
  "private": true,
  "type": "module",
  "scripts": {
    "build": "nuxt build",
    "dev": "nuxt dev",
    "generate": "nuxt generate",
    "preview": "nuxt preview",
    "postinstall": "nuxt prepare"
  },
  "dependencies": {
    "nuxt": "3.11.2",
    "vue": "3.4.26",
    "vue-router": "4.3.2"
  },
  "prettier": "3.2.5",
  "prettier-plugin-tailwindcss": "0.5.13",
  "devDependencies": {
    "@nuxt/fonts": "0.6.1",
    "@nuxt/ui": "2.15.1",
    "tailwindcss": "3.4.3"
  }
}

System Info
System:
    OS: macOS 14.5
    CPU: (8) arm64 Apple M1 Pro
    Memory: 160.67 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - ~/.version-fox/temp/1721340000-99154/nodejs/bin/node
    npm: 10.5.0 - ~/.version-fox/temp/1721340000-99154/nodejs/bin/npm
    pnpm: 9.5.0 - /opt/homebrew/bin/pnpm
    bun: 1.1.12 - ~/.bun/bin/bun
  Browsers:
    Chrome: 126.0.6478.183
    Edge: 126.0.2592.102
    Safari: 17.5

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

Contributions

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests (actually just go ahead and do it, thanks!)

Have you tried taze -f? By default taze caches the metadata for half an hour or so

It seems that the problem is that the version numbers are pinned and don't have a range.
I have the same problem in a repo where all dependencies are pinned.

Try the -l / --includeLocked flag.
I always run taze like so:
bunx --bun taze newest -rflI


Can share the super parameters to reproduce the result on CUB-200-2011?

I use the super parameters  given in the run script to reproduce the work of WeightLoss, but I can not get the same result as reported.  My best result as follow:
Epoch-130 0.6411  0.7437  0.8301  0.8981  0.9458  0.9731
Would you please give me some help?

We rerun our script and the performance is as below:
Epoch-200 0.6595  0.7601  0.8427  0.9067  0.9465  0.9738

@bjkite  I think the problem of not get similar performance is hard mining:
you should change the hard_mining in  the loss:  /losses/Weight.py
self.hard_mining = hard_mining
Make self.hard_mining to be not None.
I will fix  this problem in these days.


ODS - Component - Chips: Suggestion

@mccart77  & @Tayebsed93 : I do not see the suggestion chips in the list. Have we decided to take them away?

Chips in Flutter are using M3 components, so i think we have an issue with chips in Flutter being aligned with Android M2


Autocomplete in jetbrains

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: windows 10
- Continue: 0.0.46
- IDE: pycharm 2023.1.1

Description
When i use the tab autocomplete in pycharm, and the pycharm also wants to complete me, it creates conflicts with the plugin, which scrambles the output as such:

In addition, if I press tab to complete with the plugin, it chooses the pycharm, so I can't use the plugin to complete me.
To reproduce
Here is the config:
{
tabAutoCompleteModel: {
Title: deepseek-7b,
Provider: openai,
Model: deepseek-7b,
ApiBase: http://my-api-base,
ApiToken: my-api-token,
ContextLength: 10000
},
tabAutoCompleteOptions: {
Disable: false
},
DisableSummaries: true,
CompletionOptions: {
Temperature: 0.25
}
}

Log output
No response

thanks for sharing this. I'll probably not fit this in for the release I'm making today, but will look to make a fix for the following release

@sestinj sounds good. Can you tell me when this new version is expected to come out?

@eladamittai I'm going to look into it before the release I'll send out tomorrow, and depending on whether this is a simple fix or not it should be ready either Friday or next week if not

@sestinj great! Thanks! 🙏🙏🙏

@sestinj hey, was the fix released as part of the 0.0.47 release or will it be added in the next release? It's just a bit of a process for me to download versions because of some issues I have with my computer, so I would prefer to know before downloading.

Hey, I was checking the 0.0.50 release to see if it's fixed, and while it is better, it still writes weird stuff. It keeps doubling the suggestion, and when the IDE and plugin completion suggestions are clashing, I can't choose the plugin suggestion with tab.

same here.


provision_lab.yml is requiring Ansible 2.6 but it seems that is not officially available

Hello guys. As you described within README, I'm using Ansible 2.5 for provisioning environments,  but recently I see that provision_lab.yml was updated:
- name: make sure we are running correct Ansible Version
  assert:
    that:
      - ansible_version.minor >= 6
      - ansible_version.major >= 2

name: grab information about AWS user
aws_caller_facts:
region: "{{ ec2_region }}"
register: whoami

It' seems that Ansible 2.6 is necessary for aws_caller_facts, but in my understanding it's in development stage right now, isn't it?
ERROR! no action detected in task. This often indicates a misspelled module name, or incorrect module path.
Because I'm having an error using Ansible 2.5. Could you help me with that?
Thanks in advance!

Hey Robert,
The 2.6 branch is still in devel but you grab a nightly rpm here:
https://releases.ansible.com/ansible/rpm/nightly/devel/epel-6-x86_64/
Install with a yum install local
Sorry about the requirement, otherwise AWS api is not consistent with the
2.5 modules and we will end up with unhappy users because random tasks will
report errors and timeouts
On Tue, May 8, 2018 at 9:58 PM Robert J. Calva<EMAIL_ADDRESS>wrote:

Hello guys. As you described within README, I'm using Ansible 2.5 for
provisioning environments, but recently I see that provision_lab.yml was
updated:

name: make sure we are running correct Ansible Version
assert:
that:
- ansible_version.minor >= 6
- ansible_version.major >= 2

...

name: grab information about AWS user
aws_caller_facts:
region: "{{ ec2_region }}"
register: whoami

It' seems that Ansible 2.6 is necessary for aws_caller_facts, but in my
understanding it's in development stage right now, isn't it?
ERROR! no action detected in task. This often indicates a misspelled
module name, or incorrect module path.
Because I'm having an error using Ansible 2.5. Could you help me with that?
Thanks in advance!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/network-automation/linklight/issues/8, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AGPB0Pyf7xOq81e-VxtgLRZNBCWzk7WEks5twk0bgaJpZM4T3l69
.

Hey Robert, does that work for you?

Hey Sean! How you doing today?
I'm sorry for the delay. I'm just trying to install but it seems that Python 2.6 is required and I'm using Python 2.7:
Error: Package: ansible-2.6.0-0.0.devel.201805082046git.ea489b3f33.el6.ans.noarch (/ansible-2.6.0-0.0.devel.201805082046git.ea489b3f33.el6.ans.noarch)
Requires: /usr/bin/python2.6
Thanks a lot for your quick response and support!

if you are not using tower... it might be easier for you to just use pip to install dev branch quickly->
pip install git+https://github.com/ansible/ansible.git@devel

more directions at-> http://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html

Dear Sean,
After that, everything is working like a charm.
Thanks for your kind support!
Regards.


pypi package (0.5) will not install

The tarball is missing HISTORY.rst, so the package install fails.

Thanks for the report, what install system are you using?

OK, reproduced with pip install --no-binary :all:
Will get a fixed version up tomorrow

Uploaded version 0.6 to PyPi which fixes this issue.

Thank you.  I'll try it tomorrow.
On September 8, 2015, at 13:32, Sam Washington<EMAIL_ADDRESS>wrote:
Uploaded version 0.6 to PyPi which fixes this issue.
—
Reply to this email directly or view it on GitHub.￼


Implement vcs similar to go get

For private repositories and git over ssh repositories implementation of
dep was different from go get.
Examples:
  go get example.com/repo.git

Will use remote
  (scheme)://example.com/repo

The most important part that suffix .git tells go get to access the path
as git, but it drops the suffix to actually access the remote.
Go get will clone this repo as
  git clone git+ssh://example.com/repo $GOPATH/src/example.com/repo.git

It is very unfortunate that you will end up with .git suffixes but at least it
works, this is the only way to make go get to recognize this import as
git.
But in case of dep
  import "example.com/repo.git"

Will result for dep to try to access remote as
  (scheme)://example.com/repo.git

Which makes it impossible to teach go get to work with dep.
This change is making consistent behavior between go get and dep by
always dropping suffix .git for remotes (which is also not ideal, but
at least it works now with go dep).
Other changes related to the schemas, I made the order match to the
default schemes in go get (this one I reverted, as there are a lot of tests failed)

What does this do / why do we need it?
After fixing this issue I believe go get and dep will have good working solution for private git repos (as many people complain in other tickets that it does not work).
If you have your own private git repository available on git+ssh://example.com/repo you will be able to reference it in the go source like
import (
   "example.com/repo.git"
)

That will clone the git+ssh://example.com/repo under $GOPATH/src/example.com/repo.git, where suffix .git is not ideal, but at least it works.
And after that you will be able to run dep init and dep ensure which also behave similarly to go get by cloning example.com/repo.git from remote (scheme)://example.com/repo in path vendor/example.com/repo.git
What should your reviewer look out for in this PR?

Look on the issue and the problem described https://github.com/golang/dep/issues/1716
(this one I reverted, as there are a lot of tests failed) I have changed order of schemes to match it with go get as well vcs.go#L48-L54
Look on regex in go get to load vcs path and scheme vcs.go#L1019-L1022
Look on how go get handles this regex to resolve the remote, see vcs.go#L683-L751

Do you need help or clarification on anything?

None

Which issue(s) does this PR fix?
fixes #1716
fixes #174 (maybe?)

I signed it!

@sdboyer curious, did you have a chance to look into this? Just want to know if this is something that can be considered to be merged?
I definitely do not want to maintain my own fork of dep, so if this change cannot be merged - I will try to find different way how to make it work for me.
Also I am happy to iterate, add more explanations if needed, docs for how to work with private repos, etc.

@hoshsadiq

being required to update the import to have a .git suffix is a big no-no

Could you explain why? Unfortunately go get already requires you to have .git as a suffix for the git path, so if you just want go get to be able to resolve dependencies you need to write import 'example.com/somelib.git/somepackage', where go get will understand that example.com/somelib.git is the git repo and /somepackage is the package in this git repo. It will resolve git repo in $GOPATH/src/example.com/somelib.git. Not having .git in the path does not allow tools to understand what is the repo and what is the path, as import 'example.com/somelib/somepackage' can be a repo=example.com/somelib, package=/somepackage or actually repo=example.com/somelib/somepackage, package=/.
So in my PR the only thing I do just trying to make dep to work exactly the same as go get.

I think if we can check the source first, and ignore the name for location checking (i.e. the name is just a local vendor path when source is declared), surely that would be a fix?

Not sure I understand the proposal, could you explain on example?

Reason being when you develop multiple projects, your $GOPATH/src layout will be:
src/git.myorg.com/team/project1
src/git.myorg.com/team/project2

Let's imagine project2 depends on project1, and you've made a change in projet1.
If you have the .git suffix, dep will force download project1 into project2/vendor/.../project1.git, which means it won't pick up the changes of project1. The only way to force it to pickup changes in project1 is by committing, pushing, and then doing (iirc) dep ensure -update. Even breakpoints would have to be set in the files inside project2/vendor/.../project1.git as opposed setting them inside src/git.myorg.com/team/project1
Not having the git suffix means go will simply pick up your project1 without having to push or running dep every time you push.
Having this PR merged is certainly better than nothing, but this issue needs to be addressed correctly. Glide for example manages this correctly.
As for the proposal, I've not looked at how dep works internally, however, from what I've observed is that it's sees the name attribute as everything so please correct me if I'm wrong. This is fine because it can imply where we can find the source for the imported library. However, with this issue, this isn't the first thing should check. We should set the source the be the name if and only if there's no source present. I.e. this
[[constraint]]
  name = "github.com/pkg/errors"

is the same as
[[constraint]]
  name = "github.com/pkg/errors"
  source = "github.com/pkg/errors"

Then we resolve stuff, we only care about the source attribute. Finally, once the source location has been resolved, we can check it out in vendor/src/<value of name>. This way, we can set force the source to have a .git suffix, and leave name as it is. Go would pick up everything correctly, and if you already have that project in your $GOPATH it wouldn't clone the repo. Hope that helps. Again, I'm not sure how viable this solution would be considering I'm not really sure how the internals of go get and dep work.

Considering the current state of dep and vgo, I assume we can just close (abandon) this PR
Please just make sure that this will be well covered in vgo ;)
Thank you!

Considering the current state of dep and vgo, I assume we can just close (abandon) this PR

Please just make sure that this will be well covered in vgo ;)

Sorry, but i'm not doing work on vgom as i believe it is fundamentally the wrong direction. i'll keep this in mind with the successor tool to dep.

(note that this should not be an issue in vgo, as it uses none of our code. i'm also pretty sure that the concern i raised above is something we handle automatically, so incorporating this should be pretty easy.)


Adds go-sdk to sdk test github workflow with corresponding commands

Branched from #6304, part of https://github.com/dapr/dapr/issues/5797
Job can be manually triggered on a PR with the commands /test-sdk-all or test-sdk-go.

/test-sdk-all

Not for this PR, but I believe we need to enhance running tests against SDKs.
As it exists right now, this workflow tests the PR code against master branch of the SDK. But in certain scenarios that is not the right approach, for example running against a PR against a release branch, ideally we would need to run against the latest stable version of the SDK.
I propose we add another parameter for the individual commands /test-sdk-java release-1.9 so that it tests the PR against the release branch specified. For the /test-sdk-all the current behavior is good.
cc @artursouza @yaron2 WDYT?

Not for this PR, but I believe we need to enhance running tests against SDKs. As it exists right now, this workflow tests the PR code against master branch of the SDK. But in certain scenarios that is not the right approach, for example running against a PR against a release branch, ideally we would need to run against the latest stable version of the SDK. I propose we add another parameter for the individual commands /test-sdk-java release-1.9 so that it tests the PR against the release branch specified. For the /test-sdk-all the current behavior is good.
cc @artursouza @yaron2 WDYT?

Agree.


Can I disable enter?

Hey. I need this plugin only for "input" tags, not for "textarea". So I need to disable enter button. Is there a way to do that?
Also I don't need paragraphs and br tags. This is not necessary, I can delete them later in back-end, but this would be nice anyway.
I tried to add "p" to tagsToRemove. But this breaks everything. Evey line in editor is wrapped with paragraph. So when I type some content, then switch to viewHTML and back, it deletes everything. So I don't think this is the way to do it.

Arf, nope, there is no solution nor hack to achieve something like that :/


Add sub command for completion and documentation generation

What this PR does / why we need it:
See #480
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #480
Special notes for your reviewer:
Needed to upgrade cobra dependency to 0.0.4 because it has a helper method that simplifies argument parsing. Should the command be added to to documentation?
Documentation:
None
Release note:
`completion` and `doc` added for shell complation and documentation generation

@eqrx Regarding the documentation question, a quick document explaining how to activate the completion and generate documentation would be nice. Maybe even just putting quick description in the README would work as well.

/retest


Inventor Artillerist Cannon action missing in <IP_ADDRESS>

The Artillerist's cannon actions seem to be missing in <IP_ADDRESS>. This was not an issue in <IP_ADDRESS>.

Summon a Flamethrower cannon (medium)
Use the Command Cannon bonus action
End turn
On cannon's turn, the Flamethrower action is not there

Force Ballista is also affected. Tiny Flamethrower is also affected, as it does not show the bonus action.
cannon_action_repro.zip

(Tiny) Protector is also affected by this

fixed in dev. thanks.


Migrating  unittest to pytest (Part 7)

Description
This should cover all the files.

Reviewing this, could you please fix the style failures? Also, should part 6 go in first, or part 7? I don't have a hard stance on it, but getting both done this week would be great.

Reviewing this, could you please fix the style failures? Also, should part 6 go in first, or part 7? I don't have a hard stance on it, but getting both done this week would be great.

Both ore independent so doesn't matter. We can work on them simultaneously.


barbar buffer picking

barbar has implemented a buffer-picking option which highlights the key required to select the particular buffer.
the highlight color seems a bit jarring (see image). can this color be changed to be more cohesive with the colorscheme?

appreciate the report – i don't use this personally so please let me know if anything else looks off

thanks for the early response! appreciate it.


errors during npm install on clean machine

On a clean machine I tried to get monterey running (clone, npm install then gulp watch)
First it threw an error about python not being installed, so I installed python (must be 2.7, not 3.0). Had to tick the checkbox to add python to the PATH variable
Then it gave me this:
Installing app dependencies for arch x64 to C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app

><EMAIL_ADDRESS>install C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog
> node-gyp rebuild

C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
MSBUILD : error MSB4132: The tools version "2.0" is unrecognized.  System Windows_NT 10.0.14393
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog
gyp ERR! node -v v6.3.1
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok
<EMAIL_ADDRESS>C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app
`-- (empty)

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "--production"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the nslog package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs nslog
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls nslog
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\npm-debug.log
npm ERR! code 1
Unhandled rejection Error: C:\Program Files\nodejs\node.exe exited with code 1
    at ChildProcess.childProcess.on.code (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:137:14)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:852:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
From previous event:
    at spawn (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:112:9)
    at spawnNpmProduction (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:46:9)
    at Object.installDependencies (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:24:120)
    at C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\install-app-deps.ts:29:2
    at next (native)
    at runCallback (timers.js:570:20)
    at tryOnImmediate (timers.js:550:5)
    at processImmediate [as _immediateCallback] (timers.js:529:5)
From previous event:
    at tsAwaiter (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\awaiter.ts:10:47)
    at main (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\install-app-deps.ts:22:3)
    at Object.<anonymous> (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\install-app-deps.ts:34:7)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.runMain (module.js:575:10)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3

npm WARN optional Skipping failed optional dependency /electron-builder/appdmg:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /7zip-bin/7zip-bin-linux:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /7zip-bin/7zip-bin-osx:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>
From the node-gyp README I saw that I needed to run npm install --global --production windows-build-tools
Afterwards the error changed into:
C:\Users\Jeroen\Downloads\monterey-master\monterey-master>npm install

><EMAIL_ADDRESS>postinstall C:\Users\Jeroen\Downloads\monterey-master\monterey-master
> install-app-deps

Installing app dependencies for arch x64 to C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app

><EMAIL_ADDRESS>install C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog
> node-gyp rebuild

C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog>if not defined npm_config_node_gyp (node "C:\Program Files\nodejs\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  main.cc
  nslog_win.cc
  win_delay_load_hook.c
C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\src\win_delay_load_hook.c(34): error C2373: '__pfnDliNot
ifyHook2': redefinition; different type modifiers [C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_m
odules\nslog\build\nslog.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\delayimp.h(134): note: see declaration of '__pfnDliNot
  ifyHook2'
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)
gyp ERR! System Windows_NT 10.0.14393
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog
gyp ERR! node -v v6.3.1
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok
<EMAIL_ADDRESS>C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app
`-- (empty)

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "--production"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the nslog package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs nslog
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls nslog
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\npm-debug.log
npm ERR! code 1
Unhandled rejection Error: C:\Program Files\nodejs\node.exe exited with code 1
    at ChildProcess.childProcess.on.code (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:137:14)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:852:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
From previous event:
    at spawn (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:112:9)
    at spawnNpmProduction (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:46:9)
    at Object.installDependencies (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:24:120)
    at C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\install-app-deps.ts:29:2
    at next (native)
    at runCallback (timers.js:570:20)
    at tryOnImmediate (timers.js:550:5)
    at processImmediate [as _immediateCallback] (timers.js:529:5)
From previous event:
    at tsAwaiter (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\awaiter.ts:10:47)
    at main (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\install-app-deps.ts:22:3)
    at Object.<anonymous> (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\install-app-deps.ts:34:7)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.runMain (module.js:575:10)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3

npm WARN optional Skipping failed optional dependency /electron-builder/appdmg:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /7zip-bin/7zip-bin-osx:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /7zip-bin/7zip-bin-linux:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>

remembered I needed npm@next: npm install npm@next -g:
><EMAIL_ADDRESS>postinstall C:\Users\Jeroen\Downloads\monterey-master\monterey-master
> install-app-deps

Installing app dependencies for arch x64 to C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app

><EMAIL_ADDRESS>install C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog
> node-gyp rebuild

C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog>if not defined npm_config_node_gyp (node "C:\Users\Jeroen\AppData\Roaming\npm\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild )
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
  main.cc
  nslog_win.cc
  win_delay_load_hook.cc
     Creating library C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog\build\Release\ns
  log.lib and object C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog\build\Release\nsl
  og.exp
  Generating code
  Finished generating code
  nslog.vcxproj -> C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog\build\Release\\nslo
  g.node
  nslog.vcxproj -> C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\nslog\build\Release\nslog
  .pdb (Full PDB)

><EMAIL_ADDRESS>postinstall C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app
> electron-rebuild -f -p -w pty.js

Couldn't find electron-prebuilt and no --node-module-version parameter set, always rebuilding
Bad argument
TypeError: Bad argument
    at TypeError (native)
    at ChildProcess.spawn (internal/child_process.js:278:26)
    at Object.exports.spawn (child_process.js:372:9)
    at C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\electron-rebuild\lib\spawn.js:28:43
    at Promise.exports.(anonymous function).target.(anonymous function).function.target.(anonymous function).F (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\core-js\library\modules\$.export.js:30:36)
    at exports.default (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\electron-rebuild\lib\spawn.js:25:10)
    at getElectronModuleVersion$ (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\electron-rebuild\lib\main.js:126:65)
    at tryCatch (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\babel-runtime\regenerator\runtime.js:72:40)
    at GeneratorFunctionPrototype.invoke [as _invoke] (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\babel-runtime\regenerator\runtime.js:334:22)
    at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\node_modules\babel-runtime\regenerator\runtime.js:105:21)

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\Jeroen\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "install" "--production"
npm ERR! node v6.3.1
npm ERR! npm  v3.10.7
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>postinstall: `electron-rebuild -f -p -w pty.js`
npm ERR! Exit status<PHONE_NUMBER>
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script 'electron-rebuild -f -p -w pty.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the monterey package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     electron-rebuild -f -p -w pty.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs monterey
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls monterey
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Jeroen\Downloads\monterey-master\monterey-master\app\npm-debug.log
Unhandled rejection Error: C:\Program Files\nodejs\node.exe exited with code 1
    at ChildProcess.childProcess.on.code (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:137:14)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:852:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:5)
From previous event:
    at spawn (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:112:9)
    at spawnNpmProduction (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:46:9)
    at Object.installDependencies (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\util.ts:24:120)
    at C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\install-app-deps.ts:29:2
    at next (native)
    at runCallback (timers.js:570:20)
    at tryOnImmediate (timers.js:550:5)
    at processImmediate [as _immediateCallback] (timers.js:529:5)
From previous event:
    at tsAwaiter (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\util\awaiter.ts:10:47)
    at main (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\install-app-deps.ts:22:3)
    at Object.<anonymous> (C:\Users\Jeroen\Downloads\monterey-master\monterey-master\node_modules\electron-builder\src\install-app-deps.ts:34:7)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.runMain (module.js:575:10)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3

npm WARN optional Skipping failed optional dependency /electron-builder/appdmg:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /7zip-bin/7zip-bin-linux:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /7zip-bin/7zip-bin-osx:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>
changed ./node_modules/.bin/electron-rebuild -f -p -w pty.js to ./node_modules/.bin/electron-rebuild -f -w pty.js
this finally allows npm install  to finish

so if we're keeping node-gyp the new setup instructions are;
npm install --global --production windows-build-tools npm@next
npm install
cd app
jspm install

Look like a lot like the npm -g install npm@next I potsed in team chat few days ago.
Think I found is somewhere in visual studio forum, after a update to visual studio community you had to run the latest for compiling native sources on windows
Was driving me crazy there for a while

fixed by @vegarringdal


about datase build

when i run hgtector database -o db_dir --default
I get the below error

Done.
Total number of genomes in categories: 288353.
Filtering genomes...
Traceback (most recent call last):
File "/project/liuguohong/anaconda3/envs/hgtector/bin/hgtector", line 96, in
main()
File "/project/liuguohong/anaconda3/envs/hgtector/bin/hgtector", line 35, in main
module(args)
File "/project/liuguohong/anaconda3/envs/hgtector/lib/python3.8/site-packages/hgtector/database.py", line 134, in call
self.filter_genomes()
File "/project/liuguohong/anaconda3/envs/hgtector/lib/python3.8/site-packages/hgtector/database.py", line 394, in filter_genomes
self.df['accnov'] = self.df['accession'].str.split('.', 1).str[0]
File "/project/liuguohong/anaconda3/envs/hgtector/lib/python3.8/site-packages/pandas/core/strings/accessor.py", line 129, in wrapper
return func(self, *args, **kwargs)
TypeError: split() takes from 1 to 2 positional arguments but 3 were given

I solved it

I solved it

Hello，I‘m encountering the same problem. How do you solve it？ Looking forward your replay.
You may have to completely delete the conda environment and create it again.
please use this......
conda create -n hgtector -c bioconda python=3.7.7 pyyaml=5.3.1 pandas=1.0.3 matplotlib=3.1.3 scikit-learn=0.22.1 diamond blast=2.9.0

Hello @manik-123 @zouminghong Thanks for reporting this bug. Sorry that I didn't get to it until now. Well I just fixed it (#118 ). It was a compatibility issue with newer versions of Pandas. You can update HGTector with:
pip install --force-reinstall --no-cache-dir git+https://github.com/qiyunlab/HGTector.git

Then the problem should be solved. Please let me know if that works for you. Thanks!

Thank you so much

@manik-123 Just fixed another bug #119 You need to update again if you did so in the past few minutes :)


Ability to store the entire access token object

Hello, do you think it would be possible to add the ability to store and retrieve the entire body containing the access token, refresh token etc. in the AccessToken class? The reason I need it is that when I make a call to Azure AD, it also return an id_token and I need to retrieve it later on.
I understand that it is more OpenID related and this is OAuth2 library, so that's why I am inquiring whether it was possible to store it this way, rather than adjusting it for use of id_token directly.
I can create a PR to implement both scenarios. Is this something that would be accepted?

You could create an extension of AccessToken and use it in the createAccessToken method.

I think that would complicate the fact that whenever something is changed in the official library regarding the AccessToken class, it would require an update (of course the plugin can be locked to the latest known  supported version). I will see how much effort it would take to extend the AccessToken instead of building it in.

Well no... you'd make the modification in your custom provider, so that upgrades would never effect your changes.

Okay, that makes perfect sense now, thanks for the guidance. I will post here once the modification is done.

This is now resolved in my dev branch so I am closing this issue. Thanks for the guidance.

Refs #518 not sure why I didn't link it in the commit.

I was adding some additional validation for Azure AD tokens so it is fine, however before the merge of https://github.com/TheNetworg/oauth2-azure/issues/16 to my master, I am going to probably make it to use your implementation of the storage, so it remains efficient and doesn't do things twice.


Dependency issues - Laravel 9

Hi,
I've got this issue when trying to install on Laravel 9:
Your requirements could not be resolved to an installable set of packages.
Problem 1

Root composer.json requires ryangjchandler/filament-spatie-laravel-activitylog ^0.0.2 -> satisfiable by ryangjchandler/filament-spatie-laravel-activitylog[v0.0.2].
ryangjchandler/filament-spatie-laravel-activitylog v0.0.2 requires illuminate/contracts ^8.73 -> found illuminate/contracts[v8.73.0, ..., 8.x-dev] but these were not loaded, likely because it conflicts with another require.

Would you please share a workaround?
Thank you in advance,
Keep up the great work

@a-zog Doesnt support L9 yet. Will sort soon.

Hi, any updates regarding this issue?
Thank you in advance


Add within / outside of business hours

Arrgh, there's already #during_business_hours?. Saw it too late.


Fixing sd_vehicle_interface

Fix sd_vehicle_interface problems. Last semester we were having issues with the Twizy stalling on inclines, so might have to try some of the following:

[x] talk to StreetDrone about any issues through zendesk

[x] create a Ros package for testing that allows the user to enter a desired Twist value to control the Streetdrone

[x] create a Foxglove configuration to show graphs of the error between command twist and current twist (/sd_current_twist)

[ ] tune/calibrate the PID loops - create a new branch for this

[ ] go through the control code and fix things like:

[ ] steering_map
[ ] torque_map
[ ] control loops

x2-3 people

@dtonda8 @jin-ramen let's schedule a kick-off meeting for this.
Are you guys free tomorrow night 6.30pm?

yea i'm free 6:30 tmr

Asked them about the SD_Vehicle_Interface here

I can't seem to view the post: it says "The page you were looking for doesn't exist"

I edited the doc for this issue to describe the testing package we were talking about today - lmk if it needs clarification

Issues with HIL demo:

fixed braking kicking us out
sometimes when vehicle is stopped in CARLA, Twizy periodically spins its wheels a little bit

Yeah so use that one

Just need a good and simple way to test the Streetdrone by being able to command certain velocities and comparing with how well the Streetdrone response is
But it's not too important how this testing stuff is set up so it should just be something that is quickly set up.
Using Foxglove is a good way of displaying graphs - see here for some sort of guide on how to set up.
RVIZ also has some graph plugins but Foxglove might be a bit easier.

So I didn't get much time to set up some launch files with foxglove and everything. I was trying to upgrade the Alienware to Ubuntu 22 (not necessary, but I'll do it sometime this week). But here is an outline of what you have to do:

Download and install Foxglove Studio
`sudo apt install ros-$ROS_DISTRO-foxglove-bridge
ros2 launch foxglove_bridge foxglove_bridge_launch.xml - this will run a websocket server that listens to ROS2 topics and publishes them over websockets (default port 8765)
run sd_vehicle_interface
publish twist commands
Open Foxglove Studio, open a websocket connection to ws://localhost:8765
Press the 'Add Panel' button in the top left of Foxglove Studio, add a plot, and you can add different series to the plots to visualise your data.

I think someone fixed that but I don't think they've pushed their changes uhh
But inside sd_control if you half the torque then it should work, you could probably ask @jaimasters if he's there

https://github.com/Monash-Connected-Autonomous-Vehicle/autoware/assets/126840142/437d5127-fdec-4903-be54-fe7d61c71181

StreetDrone responded:

Hey @jin-ramen @dtonda8 where is your test_twist branch? I can't see it anymore?

11-12-23
Assigning @m076em to assist with PID tuning
We should try contacting Hoam Chung to help us with this too
We should talk to Pascal about how we can test the Twizy without a supervisor present
Double check that the sd_speed_source is using the wheel encoders (rather than IMU)

UNDO_STREETDRONE_SCALING_FACTOR = 720
Previously, our twist commands were divided by 720 and the current twist was multiplied by 720
After removing UNDO_STREETDRONE_SCALING_FACTOR I (roughly) analysed a few different speeds:

twist_cmd (m/s ?)
current_twist (m/s ?)
speedometer

0 < x < 0.05
0.9-0.12
13-15

0.1
0.2
23

0.2
0.3
35

0.3
0.4
46

FYI 0.1 m/s = 0.36 kmh = 0.22 mph, so scaling is still an issue
Speeds where a lot more consistent after 0.1 m/s twist_cmd, for example, with twist_cmd.linear.x = 0.3 is shown here:

Can't seem to get speedometer below 13 with a non-zero positive twist command, even with twist_cmd.linear.x = 1e-20.
Speedometer reads 0 (i.e. wheels stop spinning) only if the twist cmd is set to precisely 0.
So most likely there is some sort of minimum torque.

After talking to @owenbrooks
In UNDO_STREETDRONE_SCALING_FACTOR, 0.5 is the factor in the DBC file
100 is a Streetdrone mistake??
3.6 is kmh to mps - not sure why we're diving by 3.6 instead of multiplying

See this page for an explanation of the scaling
https://www.notion.so/monashcav/StreetDrone-Vehicle-Interface-e8c8c8a634574df4ac0d533dcbcc05f3?pvs=4
Also the Twizy might not be designed to work on non flat surfaces so we should probs just focus on testing on flat surfaces for now

I created a new scale factor NEW_SCALE_FACTOR = 51.4 to scale current_twist appropriately and scale down twist_cmd requests to whatever scale the Twizy is using (which happens to be ~51.4 times smaller that the expected twist, see last column).

twist_cmd (m/s ?)
current_twist (m/s ?)
speedometer (mph)
expected current_twist (m/s) (converted from speedometer)
Scale Factor (expected/actual)

0 < x < 0.05
0.09-0.12
13-15
-
-

0.1
0.2
23
10.28
51.41

0.2
0.3
35
15.65
52.17

0.3
0.4
46
20.56
51.4

Previously, the ANTI_FUSSINESS_TWIZY = 0.1 which happens to be the gap between the twist_cmd and current_twist. I also scaled this down to 0.00175 here. I'm guessing the ANTI_FUSSINESS_TWIZY is used to prevent exceeding the speed limit.
Whenever the current_twist was within ANTI_FUSSINESS_TWIZY from the twist_cmd, the Integration error/contribution was reset to 0. See here
I have changed this to now reset decrease the Integration error/contribution by 2.5% here.
I have also decreased the FF_Contribution_Pc by 20% here. The FF_Contribution_Pc was providing the base torque for each (probably to counteract rolling resistance), so will probably will need to revert my change here whenever testing the Twizy on the road.
I didn't use any of Owen's scaling, but it might be worth noting that his scaling factor is precisely 14 times larger than mine. New scaling seems to work, only off by $\pm 1$ mph when stabilised:

twist_cmd ($m/s^{-1}$)
speedometer (mph)

1 (2.24 mph)
3

2 (4.47 mph)
4

3 (6.71 mph)
6

4 (8.95 mph)
9

Only issue now is that the current_twist oscillates quite a bit ($\pm 3$ mph) before stabilising. We'll also need to scale up the speed index to correctly use the steer_map and torque_map.

Great work david!
Although now the current_twist and twist_cmd values match up, I don't think adding a custom scaling factor is a good thing to do in this case. Based on my previous comments, everything except the '100' term in the UNDO_STREETDRONE_SCALING_FACTOR makes sense and apparently the current_twist and twist_cmd values were matching up last semester.
It would be good though to keep a copy of these values for now somewhere so that at least we have the Twizy working as expected on blocks.

To be fair, the current_twist and twist_cmd were already kinda matching up; they were only 0.1 away from each other. My scale factor didn't actually improve this difference. It only improved when I modified the Integration error and decreased ANTI_FUSSINESS. And when the Twizy is on blocks, I could now request speeds below 13 mph.
Owen's scaling factor makes logical sense like you said.  Mine is purely based on the Twizy's speedometer and just aimed to make our twist_cmd and current_twist seem more realistic. Without any scaling, twist_cmd=0.3 resulted in 46 mph. But if I remember correctly 0.3 m/s < 1 mph 😆.
I'll have another look at those notion pages and Owen's work.

everything except the '100' term in the UNDO_STREETDRONE_SCALING_FACTOR makes sense

I think Owen added this $\times 100.0$ since the StreetDrone's program divides the current velocity by 100 (for no apparent reason) here. So the  $\times 100.0$ pretty much reverts this.
I now understand that linear velocity should be calculated like this (like Owen suggests here):
CurrentLinearVelocity = ((double)CurrentVelocity8bit)*0.5*KPH_TO_MPS
But SD calculates the velocity like this:
CurrentLinearVelocity = (CurrentVelocity8bit*KPH_TO_MPS)/100.0
If the goal of UNDO_STREETDRONE_SCALING_FACTOR is to scale SD's formula to the correct one, I'm thinking UNDO_STREETDRONE_SCALING_FACTOR should be 100*0.5 = 50 (not to far off what I observed earlier), so that:
Correct_CurrentLinearVelocity = SD_CurrentLinearVelocity * UNDO_STREETDRONE_SCALING_FACTOR
But UNDO_STREETDRONE_SCALING_FACTOR is actually 3.6*100.0/0.5 = 720. SD's formula already coverts it to m/s using KPH_TO_MPS, so I'm a little confused as to why 3.6 is being used.

Yeah looks like I've doubled up with 3.6. I'd say you're onto it with UNDO_STREETDRONE_SCALING_FACTOR = 100*0.5

Thank you for confirming. Your docs helped me a ton in understanding CAN msgs.

Are there any issues if we directly fix the formula in sd_lib_mcav.h rather than multiplying by the scaling factor? Otherwise we'll need to scale torque/steer maps in sd_control.cpp.

Do you mean in the case where you are creating new mappings?
If you change the formula in sd_lib_mcav you’ll have to change the mappings.
The scaling factor was introduced so that we don’t have to touch the torque/steer mapping but we can still have sensible control message in our software (m/s).
So for sending control commands we take m/s, convert it to streetdrone’s weird speed, use SD’s torque map and PID gains comparing to the current_twist that they have computed.
And when reporting current speed, we take SD’s weird speed, convert it to m/s just before publishing.
So essentially inside that node the speeds are all weird and outside that node they are normal.

Does the maps use m/s or SD's units? If it's configured for SD's units then you're right. To me, the maps and comments seem to suggest that they're intended to use m/s.

Uses SD units I’m fairly sure. Yeah the comments and variable names suggest m/s but if you actually feed it m/s it tries to accelerate/decelerate too fast and locks you out of autonomous mode.

The intention would be m/s but I don’t think it’s the result they got. The interface “works” as it was given to us, with odd speeds.

@dylan-gonzalez could you elaborate on Twizy's steering? Should we try to use Ackermann instead of angular velocity?

Since Autoware outputs an AckermannControlCommand msg type, it would be a good idea if we add support for SD vehicle interface to use that as well

I created a new branch "ackermann" for  AckermannControlCommand support here. The Twizy's CAN interface uses %Angle (i.e +/-100% = steering wheel to lock left/right).
2 issues tho:

Autoware Control outputs tire angles in radians, not as a percentage. So the ackermann branch turns tire_angle inputs as a fraction of the max steering angle, then multiplies it by a 100: (angle_request_rad / MAX_STEER_ANG) * 100. However, I couldn't find the official maximum steering angle of the Twizy. I could only estimate $40 \degree$ based on this thesis (see graph on p.19).
AckermannControlCommand has acceleration and jerk control, which I'm not sure how to implement.


How to initiate oAuth without passport

I am looking for a way to implement oAuth of Azure without using passport. Can you please guide me regarding documentation

@muhammadfaizan we're not set up to provide general support in GitHub issues on this sample. Since this is outside the scope of this particular sample, the best I can point you at is https://github.com/AzureAD/microsoft-authentication-library-for-js (the Microsoft auth library, which has an alpha for Node support), and https://docs.microsoft.com/azure/active-directory/develop/v2-oauth2-auth-code-flow for the protocol details.


Update configuration section of get-start

Select Settings in the dropdown menu will open the Settings UI instead of open file since the release version v1.6.10571.0
But this page is not up to date, so I edit it.

Docs Build status updates of commit 331fbd6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/get-started.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thanks @nidbCN!


Wrong link in Module.json

Clicking on the link provided on FoundryVTT download the file, does not bring to the Github.

thanks, fixed :)


Blog app: add API endpoints

Blog app: add API endpoints
Hello Code reviewer
In this milestone, we have-:

Created an API endpoint to list all posts for a user.
Created an API endpoint to list all comments for a user's post.
Created an API endpoint to add a comment to a post.
API endpoints receive JSON and respond JSON as well.

Much obliged @danielufeli


WIP: Add github actions runner setup for windows instances

this adds the following new flags to the mapt aws windows create and mapt azure windows create commands:
--install-ghactions-runner        Install and setup Github Actions runner in the instance
--ghcations-runner-name string    Name for the Github Actions Runner
--ghcations-runner-repo string    Full URL of the repository where the Github Actions Runner should be registered
--ghcations-runner-token string   Token needed for registering the Github Actions Runner token

Fixes #211

Dunno how you will reconcile the commits after re factor but may you can add doc information about the feature.
Like something on the main README.md and also on each mapt usage doc inside the doc folder

Hey can you add the snippet for mac as well? or do you prefer handle it on a different PR?

Hey can you add the snippet for mac as well? or do you prefer handle it on a different PR?
Ensure to check #211 (comment)

yeah, I'd prefer to do it in a separate PR :)


Add new exercise Rotational Cipher

Hello!
I added Rotational Cipher exercise 🙂

@CRivasGomez thank you for your contribution!
At the moment, the build is not succeeding.  It appears there are a number of formatting-related issues identified by our linting library.
If you run the command npm run lint locally, you can see the error messages, and correct the formatting to pass linting.
If you need any assistance, please don't hesitate to ask, we're happy to help.

Hey @matthewmorgan ! I was just pushing fixes now 🙂

OK great.  Let me pull down your branch and check it against the canonical tests, and I can give you feedback.  I'll get to this ASAP, but it may be tomorrow morning.

OK, looks great.  Nice work!


Permission error on deleting files

A STANDARD user can still delete a file by making an api request directly even if the delete button on the webpage is invisible to him/her.

New permission system has been applied to the project, not STANDARD user can still delete a file. Indeed, users with right permission (i.e., ask_required_permissions.manage_study_data) has the right to delete file.
This condition has been already checked.
const hasPermission = await permissionCore.userHasTheNeccessaryPermission(
task_required_permissions.manage_study_data
...


HTML being parsed and executed on message reply

Hey guys,
It looks like replying to messages that contain HTML tags executes them.
[edit] This happens when using the mobile app's reply function on a message between people in a chat. Tested on an android device as the one replying, and on a Windows 10 PC running Teams version <IP_ADDRESS>72
For instance, if I write:

<b>some text</b>

It will show up exactly like that for me, but if someone replies to the message then in the quoted text it would show (for me) as:

some text

To the replying party, it seems like it would just show up empty.
It works with styling but also with links and img tags.
I have not been able to gauge the scope of the issue, I assume that if it's just HTML then it's probably fine - but maybe an <href> tag with javascript could be more interesting to look at...
I have not seen this 'bug' posted earlier, but maybe I missed it - sorry if it's a duplicate.

Hello,
Is it related to replying with bot or doing from Teams Desktop client?
Please confirm.
Thanks

Hey!
It happened in a chat between two people, one (sending the HTML) from desktop, and the other was replying from Android, using the reply function that is only available on mobile as far as I know.

Thanks for the reply. It seems like it is product related question so I am adding a teams-product  tag.


Error with data-target and href

Hello,
With tab, wee can keep href to a specific url (for seo) and toogle tabs with data-target.
ex :
Profile

with plugin it becomes :

Profile

As you see : data-target="#infos" href="#infos-collapse" make collapse not working properly

you have to edit in library by replacing href with data-target (not on all places) it will work then i have done that too


Keras integration

Hi,
Any news on whether I can integrate hub models with Keras ones?
Thanks

At the moment there is no Layer implementation that wraps a hub.Module.

Is there any plan?

We are planning to work on Keras integration though the effort is still in
early stages.
On Tue, Jun 26, 2018 at 11:38 PM bhack<EMAIL_ADDRESS>wrote:

Is there any plan?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/hub/issues/13#issuecomment-400471488, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AbunTK4t-bnTOCL_5YKM0JLrTQov5xA7ks5uAqnigaJpZM4TKABT
.

A temporary workaround until it is read:
https://towardsdatascience.com/elmo-embeddings-in-keras-with-tensorflow-hub-7eb6f0145440

That work around is limited in that it will fail if one tries to fine-tune the module as the lambda layer does not captures the variables, updates and losses needed by the python function it wraps.
See https://groups.google.com/a/tensorflow.org/forum/#!topic/hub/Y4AdAM7HpX0 for a bug report around that.

Any news on this?

I've been able to create a simple custom Keras layer that wraps TF Hub text embedders, but would love some guidance on whether or not it's the 'right way' to do it, especially since there's a few hacks I've had to put in to get it working.
Based on this: https://github.com/strongio/keras-elmo/issues/7 except I'm doing some nightmare-fuel to get the output shape
class TFHubTextLayer(keras.layers.Layer):
    """
    Layer that encapsulates the following:
    - Take full text level input
    - Return TFHub model's output according to provided input and output signature

    # Input Shape
        1D string tensor with shape `(batch_size)`
    # Output Shape
        Determined by the output_key
    """

    def __init__(self, output_key, module_uri, max_strlen=10000, **kwargs):
        super(TFHubTextLayer, self).__init__(**kwargs)
        self.input_spec = keras.engine.InputSpec(
            ndim=2, dtype=tensorflow.string)

        self.output_key = output_key
        # lol fucking tensorflow hub can't handle unicode URIs
        self.module_uri = str(module_uri)
        self.max_strlen = max_strlen

    def get_config(self):
        config = {
            'output_key': self.output_key,
            'module_uri': self.module_uri,
            'max_strlen': self.max_strlen,
        }
        base_config = super(TFHubTextLayer, self).get_config()
        config.update(base_config)
        return config

    def build(self, input_shape):
        # TODO(ZJ): gonna force trainable to false for now
        # https://github.com/strongio/keras-elmo/issues/7
        self.embedder = tfhub.Module(self.module_uri, trainable=False)
        self.embedder_spec = tfhub.load_module_spec(self.module_uri)
        super(TFHubTextLayer, self).build(input_shape)

    def call(self, str_inp):
        # we're basically always going to let TFHub modules do space
        # tokenization for us

        # blech, it's not really possible to actually define a Keras input w/a shape of ndim 1
        str_inp_squeezed = tensorflow.squeeze(str_inp, axis=1)

        # let's apply the max strlen to prevent OOM hopefully
        str_inp_cutoff = tensorflow.strings.substr(str_inp_squeezed, 0, self.max_strlen)

        return self.embedder(str_inp_cutoff, as_dict=True)[self.output_key]

    def compute_output_shape(self, input_shape):
        output_shape_spec = map(int, self.embedder_spec.get_output_info_dict[self.output_key].get_shape()._dims)
        # change this to be whatever the batch size is
        output_shape_spec[0] = input_shape[0]
        return output_shape_spec

Haven't put in the trainable parts yet (haven't needed to).

An update from the release 0.4.0 is that hub.KerasLayer (for Hub/TF2 modules) can be used in graph mode and can be converted to/from a Keras config.

With the 0.7 release hub.KerasLayer can also use old Hub Modules both in eager and graph mode.


Reef Check - Access to Reef Check’s database

Get access to Reef Check’s database and determine if we could easily add an API or if we need Reef Check to send quarterly updates (or whatever timeframe we decide).
Eric is waiting to get access to Reef Check’s database. Once Eric gets access, we have to make a decision whether we want to create an API from their database to stream data into Aqualink or have Reef Check send us quarterly updates. Please note that Reef Check does not have a programmer or anyone with the skill set to create an API. Therefore, we have to create the API. I don’t know how much it would take to create an API, so please let Pete and Caesar know how much time you estimate that it can take.
There are several benefits to an API. For example, real-time data has no storage in our database, and it also opens up new opportunities in the future. For example, if a Reef Check user uploads data to Reef Check, maybe Reef Check can add an option on their website for the Reef Check user to start managing the Aqualink site and upload images, etc. It would be ideal if the data were instantly on Aqualink as well as the dashboard being created instantly instead of 3 months away.
Please have a look at the Reef Check Report to understand how this project will be built. If you have any questions, please email Caesar at<EMAIL_ADDRESS>

We got access to the main data here - https://drive.google.com/drive/folders/1J6bTyIAes7YRvZmqpaLgJrIqklUrj949
We want to upload the data into our database, with this in mind:

Merge new sites with old ones when they fall within 100m
Upload most of the data that can be useful, use new dedicated tables


Move the crypto polyfill into the library itself

Description
This lets us keep support for Node 16 and 18, while running under 19 or newer will default to the now-built-in crypto support.
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Would this work on Edge runtime?

@hadihallak If I'm reading the docs right, it should be a no-op on Cloudflare Edge https://developers.cloudflare.com/workers/runtime-apis/web-crypto/

I tested this PR on CF workers and saw it won't work smoothly. Trying to import the polyfill causes issues when importing specific Node modules. I also tried dynamic imports, but CF workers still try to import the polyfill, and the same problems happen at build time.

Closing this PR.


Add Hoster

Thanks, @Houfeng. It looks like this app is not in English. Can you add a locales array to your YML file? I think this is Chinese simplified.. right? If so, it should look like this:
locales:
  - zh-cn

You might want to add some other keywords too like development, hostnames, ip address, dns, etc.

@zeke
Locales has been added, and the keywords have been updated
thx


Add section on IDE integration

Looks like this issue is done as there is already a section on IDE integration...
Suggest to add VS Code, also as blanks for now as it's popular vscode-cpptools extension doesn't appear to support test output yet (c.f https://github.com/Microsoft/vscode-cpptools/issues/1079)
While you're at it -
For the distribution section you could add linux package manager.
On Fedora catch is included in catch-devel package:
>dnf list catch-devel
catch-devel.x86_64       1.10.0-1.fc27

Also, refs [6] & [7] at the bottom credited to Phils Nash. Who he?
A great resource, thanks.

Thanks!

Also, refs [6] & [7] at the bottom credited to Phils Nash. Who he?

Argh...

[ ] Fix Phil's name in refs 6, 7
[ ] Add Visual Studio Code to IDE integration
[ ] Add Linux package manager(s)

there is also a debian package for doctest :)

and more...


Question:  Can I assert and test a value?

For example if my returned text from the LLM always contained text like "Score: 90%"  or "Score:10%" and I wanted to make pass based on score>50% or something.
Possible?

Yep, you can do this in one of two ways:

With the javascript orpython assertion type.  Write some code that parses the number out and assert that it's greater than the threshold score.

If you are doing this for many assertions, the postprocess property may come in handy.

You'll still have to write a little Javascript to parse the number from output.  Here's a one liner that I use:
postprocess: 'parseFloat(/\d+(?:\.\d+)?/.exec(output)?.[0])'


Preserve indentation when using parseDocument

This fixes #283 (with some qualifications).
Documents like the following now get their indentation preserved:
foo0:
- a
- b
- c
foo2:
  - a
  - b
  - c
foo8:
        - a
        - b
        - c
bar:
       more:
                     indentation:
                                             is: needed

when you enable the new option preserveCollectionIndentation and also enable the keepSourceTokens option:
const document = parseDocument(yamlContents, {
  keepSourceTokens: true,
  preserveCollectionIndentation: true,
});

If you insert/edit/move around nodes in this document, or insert them into others, their indentation is also preserved.

I added the new option preserveCollectionIndentation purely as a backwards compatibility measure. It could also default to true, in which case you'd only need to enable keepSourceTokens for it to work.
Unfortunately at least with the way the parser is structured right now, we do need the source tokens since they contain the relevant indentation information that makes the preservation possible.

I added a new test similar to the example above which ensures that the document round-trips exactly, maintaining all indentation.
I also added a test that verifies all documents in the yaml-suite can be round-tripped twice to verify that this doesn't break them (not that we'd expect that).
The one special edge case is that if we have a document like
list:
- not indented
- at all

and we replace the list with an object like {greeting: "hello"} as in:
const doc = parseDocument(yamlContents);
doc.set('list', {greeting: "hello"});

console.info(doc.toString());

then we need to insert some new indentation; lists are allowed to have an indentStep of 0 since the hyphen marks that the item starts, but non-lists are not:
# right
list:
  greeting: hello

# wrong (missing indentation changes meaning of document)
list:
greeting: hello

in this case, we default back to the configured indentStep (e.g. 2).

Is this a good idea to include as a partial implementation first, or do we need to ensure that it also covers block sequences and flow collections?

It handles block sequences in the sense of knowing how much indentation occurs before a - which is the common case when used as a list in a map (or a list of fields), see the updated example in the PR description.
The less common case is where you have indentation after the -, as in:
-
  -
    - foo
    - bar
  -
    - baz

Similarly, it reformats
list_map2:
  -
    foo: 1
    bar: 2
    qux: 3
  -
    foo: 4
    bar: 5
    qux: 6

into
list_map2:
  - foo: 1
    bar: 2
    qux: 3
  - foo: 4
    bar: 5
    qux: 6

Since these kinds of structures are less common (in my experience) I think it's fine as a first step to exclude them, and then revisit the approach in a later PR.

Similarly, I'm skipping over flow collections, since they're just fairly different. They have different kinds of indentation/spacing concerns so the implementation would probably be fairly different. And in my experience they're usually much smaller e.g. single-line, with little variation in how they're formatted, so they're more likely to just be preserved anyway.

What happens when a new key/value pair is added to a map that has pairs with a set srcIndentStep? Could/should the value (also?) be set on the collection rather than the pair?

My main goal in this change is to avoid making unnecessary edits to the original, rather than trying to "preserve style". So in this case, if a new "block" is made, that block will have a regular indent step (e.g. 2). So for example, if we had the following document:
count:
          animals:
                    cat: 1
                    dog: 2

if we write doc.setIn(["count", "animals", "lizard"], 3) then we get
count:
          animals:
                    cat: 1
                    dog: 2
                    lizard: 3

because the indentation before lizard belongs to the Pair with key animals. So this behaves exactly as we expect.
On the other hand, if we have
count:
        mammals:
                cat: 1
                dog: 2

and we write doc.setIn(["count", "reptiles"], {"lizard": 3, "snake": 4}); then we get
count:
        mammals:
                cat: 1
                dog: 2
        reptiles:
          lizard: 3
          snake: 4

So the yaml is still valid, but the new block is not indented as much as its sibling blocks. I think that there is a case to be made that the parent block could infer a "desirable" step for new children pairs, but as far as addressing my original goal of eliminating redundant diffs, it makes no difference. So I'm ambivalent about including this now, since it might be nice, but it would be more work and doesn't directly help my use-case.

Closing due to inactivity.


Is the depth in the dataset metric?

Hi,thank you for your outstanding contribution.
I have a question, is the depth in the dataset in metric?

The original depth is in millimeter and save as 16bit format in our Dataset. The depth file loading function is at here

Thanks for your quick reply, I get it. Thanks again!


Dependency Conflict - SLF4J

In v0.27, flexmark-java seems to expose a dependency on org.slf4j:slf4j-log4j12:jar:1.7.25:compile, which causes problems for example when using Spring Boot 1.5.6 due to a conflicting dependency.
The symptom is SLF4J warning about multiple bindings, such as:
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/.m2/repository/ch/qos/logback/logback-classic/1.1.11/logback-classic-1.1.11.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/.m2/repository/org/slf4j/slf4j-log4j12/1.7.25/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [ch.qos.logback.classic.util.ContextSelectorStaticBinder]

Per the SLF4J documentation:
Embedded components such as libraries or frameworks should not
declare a dependency on any SLF4J binding but only depend on slf4j-api.

https://www.slf4j.org/codes.html#multiple_bindings
Any chance flexmark-java could be changed to avoid exposing a full dependency on slf4j? (Note that things still function correctly, in my app at least. The multiple bindings warning is just that, a warning. So this is a low-impact issue... I just don't like the extra warnings when launching my app!)
BTW flexmark-java is fantastic, keep up the good work!
-- neverness

@neverness74, the dependency is coming from docx4j library. If you exclude the flexmark-docx-converter module then there should be no dependency on slf4j and a lot more. That library pulls in a lot of dependencies.


Warn if any resource in an incoming offer is set to zero

JIRA issues: MARATHON-8283

This doesn’t warn for instances with no GPUs right?

I agree with @timcharper – GPUs are a scarce resource by design, so naturally lots of offers will never provide any.
Also keep in mind that the default for disk in an app or pod definition is 0. Marathon will still be able to launch tasks if there's no disk offered and not explicitly requested so I'd argue that we should only warn for zero valued CPU and MEM offers.


feat: add --git-client to explicitly set the type of forge

codeberg is running Forgejo and it may not be possible to infer that from the URL alone. The same is true for GitHub Enterprise Server.

This is probably not how you would like that implemented and I'm ready to make improvements. The original author of the patch may also be willing to improve upon it.

added tests

Hey @earl-warren , this looks a great idea!
I see you already added some tests, thx a lot!
After a quick check looks good to me, I will deeply check it in a while :rocket:

Overall looks great to me!
Just a couple of missing things:
* Could you please add the same `git-client` param in the [`action.yaml`](https://github.com/kiegroup/git-backporting/blob/main/action.yml#L3-L72) for the GHA

* If I run `npm run build` locally I see the following diff:

   "query",
   "search",
-  "hash",
 ];

 // Create handlers that pass events from native requests
@@ -6325,7 +6324,7 @@ RedirectableRequest.prototype._processResponse = function (response) {
      redirectUrl.protocol !== "https:" ||
      redirectUrl.host !== currentHost &&
      !isSubdomain(redirectUrl.host, currentHost)) {
-    removeMatchingHeaders(/^(?:(?:proxy-)?authorization|cookie)$/i, this._options.headers);
+    removeMatchingHeaders(/^(?:authorization|cookie)$/i, this._options.headers);
   }

   // Evaluate the beforeRedirect callback
diff --git a/dist/gha/index.js b/dist/gha/index.js
index b50c45c..21cc4e7 100755
--- a/dist/gha/index.js
+++ b/dist/gha/index.js
@@ -7621,7 +7621,6 @@ var preservedUrlFields = [
   "protocol",
   "query",
   "search",
-  "hash",
 ];

 // Create handlers that pass events from native requests
@@ -8055,7 +8054,7 @@ RedirectableRequest.prototype._processResponse = function (response) {
      redirectUrl.protocol !== "https:" ||
      redirectUrl.host !== currentHost &&
      !isSubdomain(redirectUrl.host, currentHost)) {
-    removeMatchingHeaders(/^(?:(?:proxy-)?authorization|cookie)$/i, this._options.headers);
+    removeMatchingHeaders(/^(?:authorization|cookie)$/i, this._options.headers);
   }

Do you mind to double check this?

I have no clue why it does that in my environment. I'll remove these hunks and figure that out later.

* Could you please add the same `git-client` param in the [`action.yaml`](https://github.com/kiegroup/git-backporting/blob/main/action.yml#L3-L72) for the GHA

Fixed https://github.com/kiegroup/git-backporting/compare/0f0812afb92578ca7750ba44c2bc8441f60262ae..391771b92479930af07bc05dd80e99e4618a1c70

Spurious hunks removed at https://github.com/kiegroup/git-backporting/compare/391771b92479930af07bc05dd80e99e4618a1c70..5f12c50c451e799fb6300483c377f0e741958500

Here is the output of npm run build on my environment. There evidently is a difference in my environment that matters but I don't know how to figure that out. Do you have a suggestion? Not that it matters in the context of this PRs but it would be nice to have clean content the next time around :pray:
earl-warren:~/software/git-backporting$ npm run build

><EMAIL_ADDRESS>build
> npm run clean && npm run compile && npm run package

><EMAIL_ADDRESS>clean
> rm -rf ./build ./dist

><EMAIL_ADDRESS>compile
> tsc -p tsconfig.json && tsc-alias -p tsconfig.json

><EMAIL_ADDRESS>package
> npm run package:cli && npm run package:gha

><EMAIL_ADDRESS>package:cli
> ncc build ./build/src/bin/cli.js -o dist/cli

ncc: Version 0.36.0
ncc: Compiling file index.js into CJS
1105kB  dist/cli/index.js
1105kB  [950ms] - ncc 0.36.0

><EMAIL_ADDRESS>package:gha
> ncc build ./build/src/bin/gha.js -o dist/gha

ncc: Version 0.36.0
ncc: Compiling file index.js into CJS
1095kB  dist/gha/index.js
1095kB  [1009ms] - ncc 0.36.0
earl-warren:~/software/git-backporting$ git diff
diff --git a/dist/cli/index.js b/dist/cli/index.js
index a3f1819..77ad9bf 100755
--- a/dist/cli/index.js
+++ b/dist/cli/index.js
@@ -5891,6 +5891,7 @@ var preservedUrlFields = [
   "protocol",
   "query",
   "search",
+  "hash",
 ];

 // Create handlers that pass events from native requests
@@ -6324,7 +6325,7 @@ RedirectableRequest.prototype._processResponse = function (response) {
      redirectUrl.protocol !== "https:" ||
      redirectUrl.host !== currentHost &&
      !isSubdomain(redirectUrl.host, currentHost)) {
-    removeMatchingHeaders(/^(?:authorization|cookie)$/i, this._options.headers);
+    removeMatchingHeaders(/^(?:(?:proxy-)?authorization|cookie)$/i, this._options.headers);
   }

   // Evaluate the beforeRedirect callback
diff --git a/dist/gha/index.js b/dist/gha/index.js
index 21cc4e7..b50c45c 100755
--- a/dist/gha/index.js
+++ b/dist/gha/index.js
@@ -7621,6 +7621,7 @@ var preservedUrlFields = [
   "protocol",
   "query",
   "search",
+  "hash",
 ];

 // Create handlers that pass events from native requests
@@ -8054,7 +8055,7 @@ RedirectableRequest.prototype._processResponse = function (response) {
      redirectUrl.protocol !== "https:" ||
      redirectUrl.host !== currentHost &&
      !isSubdomain(redirectUrl.host, currentHost)) {
-    removeMatchingHeaders(/^(?:authorization|cookie)$/i, this._options.headers);
+    removeMatchingHeaders(/^(?:(?:proxy-)?authorization|cookie)$/i, this._options.headers);
   }

   // Evaluate the beforeRedirect callback


'status_code': 2,     'unknown6': [{   'response_type': 6, 'unknown2': {   'unknown1': 1L}}]}

I am on Mac OS.  I downloaded an encrypt.so file online which solved the "OSError: dlopen(encrypt.so, 6): image not found" problem.  I then ran "python pokecli.py -a ptc -u blah -p blah -l “blah”" and got the error message:
'status_code': 2,
'unknown6': [{   'response_type': 6, 'unknown2': {   'unknown1': 1L}}]}
Any idea what needs to be done now?

I'm not familiar with that error. Did you get your encrypt.so from here? If not, try the one from there. Make sure you download the right file (if you're on Mac, get libencrypt-osx-64.so) and name it as encrypt.so.

@BobbyWibowo , thank you for the response.  That actually isn't the encrypt.so file I downloaded. However, it still didn't work.  I downloaded the one you linked, put it in the base directory, renamed to encrypt.dll (anything else generates the response "OSError: dlopen(encrypt.dll, 6): image not found"), and then ran the script.  It ran for a little bit, but once again terminated with:
'status_code': 2,
'unknown6': [{ 'response_type': 6, 'unknown2': { 'unknown1': 1L}}]}
I really don't know what to do.

I really don't know what to do. I thought that this 'unknown6' value error was the reason why the new API was made in the first place.

Which was why I mentioned that I wasn't familiar with that error, since it was supposed to be fixed and I haven't seen anything like that for many hours after I got my bot working. I can only suggest running pip2 install -r requirements.txt --upgrade for now. That'll upgrade the requirements file and hopefully upgrade pgoapi as well.

@BobbyWibowo Well the pip2 install -r requirements.txt --upgradeworked, but after that I ran `python pokecli.py -a ptc -u blah -p blah -l “blah” and it spit back the same error code:
'status_code': 2,
'unknown6': [{   'response_type': 6, 'unknown2': {   'unknown1': 1L}}]}
Thank you for the help though!

@veil98 Rename it from encrypt.dll to encrypt64.dll

@GitPupper That gives me the error message OSError: dlopen(encrypt.dll, 6): image not found
It seems that for me, the script will not run unless the file is strictly named encrypt.dll

Sorry, I'm pretty much lost for now. You'll have to wait for someone who has more knowledge in this.

As there have been many updates since this issue was posted, I'm assuming this has been resolved.

@RedViper9 do you mean updates on the API?


rego-cpp throws when opa has no issues

I'm using a locally built rego cpp interpreter but it throws an error instead of returning the expected value false for a given query.
Example

policy.demo.rego:
package demo
import future.keywords.if
default allow := false
allow if {
    count(trim_space(input.foo)) > 0
}

input.demo.json:
{ "bar": "baz" }

The following query would throw:
./bin/rego_interpreter -d policy.demo.rego -i input.demo.json -q data.demo.allow

rego_interpreter: /home/ubuntu/demo/src/unifier.cc:1248: std::optional<RankedNode> rego::UnifierDef::resolve_rulefunc(const trieste::Node &, const trieste::Nodes &): Assertion `rulefunc->type() == RuleFunc' failed.
Aborted

Whilst the regular https://play.openpolicyagent.org/ has no issues with evaluating, equally the opa cli works with the following results:
./opa eval data.demo.allow --data policy.demo.rego --input input.demo.json

{
  "result": [
    {
      "expressions": [
        {
          "value": false,
          "text": "data.demo.allow",
          "location": {
            "row": 1,
            "col": 1
          }
        }
      ]
    }
  ]
}

The expectation is that the query should not fail due to a missing key (most likely) in the input.

This is resolved as of 0.3.0.


No wheels for Python > 3.6?

The latest supported Python version supported by the provided wheels seems to be 3.6:
https://github.com/bastibe/python-soundfile/blob/5f650bc017176424cb39ffbc544f4d80ca5179e9/setup.py#L9-L12
I'm wondering why there haven't been any complaints about that so far ... or am I missing something?

Good question. Perhaps 3.7/3.8 users have been downloading the source-only wheel? Or something conda-related?
This might actually explain the (small number of) complaints we see pop up from time to time about (mostly) Windows users missing the libsndfile library.
Or perhaps soundfile is more commonly downloaded via apt these days?
At any rate, adding the newer versions or some kind of wildcard is probably a good idea.

Note that the current wheels already include the py2.py3 tag which makes any extra cp and pp tags redundant.  py2.py3 is the 'universal' Python tag and is enough to match all current versions of CPython and PyPy.
I can personally verify that soundfile-0.10.3.post1 installs and runs fine on Python 3.10 x64.
The extra Python tags don't cause problems other than making the wheel filename harder to read.


WIP nothing to see

This change is

test-me-pleas

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please


Creating a portable application package for macOS 10.15 Catalina

Hi,
Following instructions to create a portable application package for macOS from
https://neutralino.js.org/docs/distribution/overview#creating-a-portable-application-package-for-macos
I got an error message on macOS 10.15.7

Is it possible to add support for macOS 10.15 Catalina ?
Thank you,
Pierre

The supplied server binaries are built for MacOS 11 or later but the binary can be built for earlier OS's (eg: Catalina/Mojave/High Sierra). Possibly the devs don't have access to a Mac earlier than 11 to do the builds.
Need python3 installed on Mac (will use buildzri) then -
git clone https://github.com/neutralinojs/neutralinojs.git
--> Cloning into 'neutralinojs'...
cd neutralinojs
./scripts/bz.py
--> ascii splash
--> Compiling Neutralinojs...
--> OK: Neutralinojs compiled into ./bin/neutralino-mac_x64
If rebuilding a server binary from a standard release then the release client library (neutralino.js) should be OK to use otherwise both the server and client binaries need to be built. Building the client library is documented in the client repo under Developer FAQ - also uses git clone method.
Build on iMac i7 takes c. 40 seconds.
Note:
neutralinojs  - server repo
neutralino.js  - client repo


update spring boot

Closes #
https://github.com/boomerang-io/roadmap/issues/339
Changelog
New

N/A

Changed

Update Spring Boot to 2.6.6

Removed

N/A

Testing / Reviewing
Tested and verified locally

@tlawrie Did you want to review?


updating doc according to blender exporter 5.6

https://github.com/BabylonJS/Exporters/issues/155

#556


[1.5.x] Set version 1.5.0-SNAPSHOT

Many thanks for submitting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[ ] You have read the contributors guide
[ ] Your code is properly formatted according to this configuration
[ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
[ ] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
[ ] Pull Request contains link to the JIRA issue
[ ] Pull Request contains link to any dependent or related Pull Request
[ ] Pull Request contains description of the issue
[ ] Pull Request does not include fixes for issues other than the main ticket

How to retest this PR or trigger a specific build:

Pull Request
Please add comment: Jenkins retest this

Quarkus LTS checks
Please add comment: Jenkins run LTS

Native checks
Please add comment: Jenkins run native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

The Linux check has failed. Please check the logs.

Jenkins restest this

Jenkins retest this

The Linux check has failed. Please check the logs.

Error is not related to this change but is a more global problem with invoker


Jetty 10/11

Jetty 10 and 11 has been released for a while and it is recommended to upgrade to the newer version.

Thank you for filing the issue.
Jetty 10 and 11 require JVM 11 or newer. If we upgrade Jetty we'll break Gniazdo for people who still use JVM 8.
For as long as JVM 8 is still supported, for example through the AdoptOpenJDK project, I think we should keep Gniazdo compatible and refrain from upgrading Jetty.

Thank you for filing the issue.
Jetty 10 and 11 require JVM 11 or newer. If we upgrade Jetty we'll break Gniazdo for people who still use JVM 8.
For as long as JVM 8 is still supported, for example through the AdoptOpenJDK project, I think we should keep Gniazdo compatible and refrain from upgrading Jetty.

FWIW, I ported to jetty 10 before I saw this
https://github.com/stalefruits/gniazdo/pull/40
I need it either way, but maybe the community won't want to pull it in for the reasons cited above.  In any case, its there if anyone else can use the work.

Note that the version of jetty used in gniazdo (9.4.35.v20201120) has these vulnerabilities:

CVE-2020-27223
CVE-2021-28163
CVE-2021-28165
CVE-2021-28169
CVE-2021-34428

So even if an upgrade to Jetty 10 or 11 isn't on the cards, an upgrade to the latest version in the 9.x series (9.4.46.v20220331, at the time of writing) is highly desirable.

So even if an upgrade to Jetty 10 or 11 isn't on the cards, an upgrade to the latest version in the 9.x series (9.4.46.v20220331, at the time of writing) is highly desirable.

Thanks for the heads-up; 1.2.1 is out.


Create thumbnail for episodes

Currently episode images are displayed "as is" -  images with size 3000x3000 and >1MB for showing them at 128x128 (past episodes) and 160x160 (most recent episode or player image) resolution.
This commit fetches the images and saves a thumbnail into the public asset directory.
An episode thumbnail is 160x160 and ~10KB in size with the current settings.
Pro:

page load increase - happy users

Cons:

Build time increase (synchronous filesystems checks) - sad devs
Repo size increase (negligible)

I guess there are quite a few improvements to be made, hence it is a draft PR for now.
Feedback welcome.

I think if we're going for this we should go "all the way" so to speak and don't generate jpg files but webp files.

Done!
Size of 160x160 is okay?

Nice, thank you @dnlggr. This is such amazing feedback!
Good catch with the dimensions - I certainly would not have noticed..

Next.js has image optimization features built in already. [...] Do you know more about that?

No, I know nothing about image optimization in nextjs yet. I will definitely read into it and will adapt the code and report my findings.
¡Muchas gracias!

will adapt the code

It's very well possible that it doesn't work or only works with a lot of hassle with statically exported sites. So if it is too much of a time sink, the manual approach is fine too!

will adapt the code

It's very well possible that it doesn't work or only works with a lot of hassle with statically exported sites. So as I said if it is too much of a time sink, the manual approach is fine too!

You were right again, it really is a lot of hassle. After many attempts, I could not get it to work properly.
See discussion here: https://github.com/vercel/next.js/discussions/19065
But I could not get the proposed solution with next-optimized-images to work, as many others.
Also:

I would warn against anyone using next-optimized-images since it's not being maintained. You'll be stuck on next.js v11 for the foreseeable future. - https://github.com/vercel/next.js/discussions/19065#discussioncomment-2013457

See also their proposed improved "wording" to in their documentation.
But all in all I think the current approach of downloading and rescaling the images can be improved with some of the new things I came across thanks to your links. Hope to have it by end of the week.

You were right again, it really is a lot of hassle. After many attempts, I could not get it to work properly.

Damit, I was hoping a "custom loader" could be a callback that downloads the original image and next does the rest...
Well, then let's stick with the custom approach. We just need to make sure the images are still crisp on higher resolution displays. 🖼 ✨

will adapt the code

It's very well possible that it doesn't work or only works with a lot of hassle with statically exported sites. So as I said if it is too much of a time sink, the manual approach is fine too!

You were right again, it really is a lot of hassle. After many attempts, I could not get it to work properly.
See discussion here: https://github.com/vercel/next.js/discussions/19065
But I could not get the proposed solution with next-optimized-images to work, as many others.
Also:

I would warn against anyone using next-optimized-images since it's not being maintained. You'll be stuck on next.js v11 for the foreseeable future. - https://github.com/vercel/next.js/discussions/19065#discussioncomment-2013457

See also their proposed improved "wording" to in their documentation.
But all in all I think the current approach of downloading and rescaling the images can be improved with some of the new things I came across thanks to your links. Will push an update soon.

Changes:

thumbnail size to 400x400
use squoosh instead of imagemagick
download/transforming images in bulk (while preventing massive parallel downloads)
hopefully all visual discrepancies fixed

Will squash into single commit after review.

Cool, almost there! Images look good now. 👌
See my inline comments, Nothing big, let's merge this today! 😄

Loads mich faster now—nice! 👏