Remove files from old Gatsby docs theme

@trevorblades Removing the netlify.toml will also mean that the docs/generate-docs.sh file will never get run. Do we need to add an extra config somewhere in the docs repo to account for this?

Good question @jgarrow. That script takes the repo readme and writes it as the index.md file in the docs. My hunch is that we'll be fine because the index.md file that it generates is already checked into git, and this is an older version of the software, so perhaps its readme isn't going to get updated very much going forward. If it does, we can always manually run docs/generate-docs.sh and check the result in to git.
@martinbonnin what are your thoughts?

Sounds fine 👍 . We had this script to avoid some duplication between the repo README.md and the docs index.md but release-2.x isn't going to move much going forward so it's fine to edit in 2 places if needed.


generate_command_inventory.py is not compatible with Python 2 .x

generate_command_inventory.py does not import print_function from future and will fail to print on Python 2.x

Cleaning u old issues, reopen if this is still active.


Diesis or not #diesis?

Expected behaviour
Actual behaviour
Steps to reproduce
Environment

Browser:
Version:
Operating System:
Version:

Console errors (if any)
Link to where the bug is happening

I am confused about statement new Plyr().
In all examples, the first argument contains a diesis, for instance:
var player = new Plyr('#bb-video',  etc.
but doing this results in a black still image replacing the player on my WordPress site (https://lebonheurestpossible.org/aseem-malhotra-interview/).
Only if I remove the diesis, things work perfectly. Does it really matter?
Below is the full code for implementing my player:

Sorry, part of the code was erased, presumably because it contained external links. The full code is in the attached file.
code.txt


Require py>=3.6.1 for PySlice_AdjustIndices

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Precompiled elixir 1.13?

I see
https://github.com/elixir-lsp/elixir-ls/pull/620
but I don't see an asset for 1.13 in
https://github.com/elixir-lsp/elixir-ls/releases/tag/v0.9.0
Building from master works fine :)

Thanks for the report! I'm adding 1.13 to the CI task that builds the releases: https://github.com/elixir-lsp/elixir-ls/pull/641


M10 - HTML Index work up

Sections for about and search history etc...

create html structure to start project
add bootstrap CDN


[Feature request] OV9782 support

Add a branch of the depthai-ros that points to depthai-core's branch multi_cam_support where OV9782 is supported.

I believe this should already be supported now that multi_cam_support was merged?

I'll close that when there'll be an example of use :slightly_smiling_face:


silx view: AttributeError error when opening a group containing external links

Reproduce

Open the file /data/id11/3dxrd/blc12852/id11/analysis/bmg_l1_bmg_dct2/difspots.h5
Try to open the group difspots
Unhandled exception pop-up appears

I tried on slurm (nice) and locally with the same result.
Error details
'ExternalLink' object has no attribute 'attrs'   File "/usr/lib/python3/dist-packages/silx/gui/hdf5/NexusSortFilterProxyModel.py", line 89, in lessThan
  File "/usr/lib/python3/dist-packages/silx/gui/hdf5/NexusSortFilterProxyModel.py", line 106, in __isNXentry

Post-scriptum
It takes some time but jupyterlab-h5web opens it fine :smirk:

ulimit -Sn unlimited fixed the issue, this is indeed a too many files opened issue


[SPARK-22599][SQL] In-Memory Table Pruning without Extra Reading

What changes were proposed in this pull request?
In the current implementation of Spark, InMemoryTableExec read all data in a cached table, filter CachedBatch according to stats and pass data to the downstream operators. This implementation makes it inefficient to reside the whole table in memory to serve various queries against different partitions of the table, which occupies a certain portion of our users' scenarios.
The following is an example of such a use case:
store_sales is a 1TB-sized table in cloud storage, which is partitioned by 'location'. The first query, Q1, wants to output several metrics A, B, C for all stores in all locations. After that, a small team of 3 data scientists wants to do some causal analysis for the sales in different locations. To avoid unnecessary I/O and parquet/orc parsing overhead, they want to cache the whole table in memory in Q1.
With the current implementation, even any one of the data scientists is only interested in one out of three locations, the queries they submit to Spark cluster is still reading 1TB data completely.
The reason behind the extra reading operation is that we implement CachedBatch as
case class CachedBatch(numRows: Int, buffers: Array[Array[Byte]], stats: InternalRow)
where the stats is a part of every CachedBatch, so we can only filter batches for output of InMemoryTableExec operator by reading all data in in-memory table as input. The extra reading would be even more unacceptable when some of the table's data is evicted to disks.
We propose to introduce a new type of block, metadata block, for the partitions of RDD representing data in the cached table. Every metadata block contains stats info for all columns in a partition and is saved to BlockManager when executing compute() method for the partition. To minimize the number of bytes to read,
How was this patch tested?

unit test: add 3 new unit tests

performance test:

Environment: 6 Executors, each of which has 16 cores 90G memory
dataset: 1T TPCDS data
queries: tested 4 queries (Q19, Q46, Q34, Q27) in https://github.com/databricks/spark-sql-perf/blob/c2224f37e50628c5c8691be69414ec7f5a3d919a/src/main/scala/com/databricks/spark/sql/perf/tpcds/ImpalaKitQueries.scala

Test build #84151 has started for PR 19810 at commit b4f51ed.

Test build #84152 has started for PR 19810 at commit accd549.

Test build #84152 has finished for PR 19810 at commit accd549.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #84151 has finished for PR 19810 at commit b4f51ed.

This patch fails due to an unknown error code, -9.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84151/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84152/
Test FAILed.

Merged build finished. Test FAILed.

jenkins, retest it please

retest this please

Test build #84153 has started for PR 19810 at commit accd549.

Test build #84155 has started for PR 19810 at commit a853ce6.

Test build #84153 has finished for PR 19810 at commit accd549.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84153/
Test FAILed.

Test build #84155 has finished for PR 19810 at commit a853ce6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84155/
Test FAILed.

retest this please

Test build #84178 has started for PR 19810 at commit a853ce6.

Test build #84178 has finished for PR 19810 at commit a853ce6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84178/
Test FAILed.

Test build #84181 has started for PR 19810 at commit 9d450ad.

Test build #84181 has finished for PR 19810 at commit 9d450ad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84181/
Test PASSed.

Merged build finished. Test PASSed.

ping @cloud-fan @viirya @gatorsmile @felixcheung @hvanhovell @HyukjinKwon

Retest this please.

Test build #84240 has started for PR 19810 at commit 9d450ad.

are you trying to optimize the case that data is too large to fit in memory? Spark RDD cache doesn't work well for this case.

Hi, @cloud-fan, this PR is not only for the case where the data size is larger than the memory size, even when all data is in-memory, I observed up to 10-40% speedup  because the implementation here
(1) read less data
(2) started less tasks
you can understand this PR as it implement the functionality of Parquet's footer for the in-memory table

Test build #84240 has finished for PR 19810 at commit 9d450ad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84240/
Test PASSed.

When all data is in memory, what do you mean by reading less data? Starting less tasks makes sense.

reading less data is a observation from the input metrics in Spark UI which includes both of local/remote read in BlockManagers, and also the overhead in BlockManager layer itself (especially when the user chooses to cache with serialized format)
but I didn't count how much it contributes to the speedup (and a small portion of data is in disk in my perf test)

@cloud-fan  would you mind continuing the review?

@sadikovi thanks for the review, I replied in comments

store_sales is a 1TB-sized table in cloud storage, which is partitioned by 'location'. The first query, Q1, wants to output several metrics A, B, C for all stores in all locations. After that, a small team of 3 data scientists wants to do some causal analysis for the sales in different locations. To avoid unnecessary I/O and parquet/orc parsing overhead, they want to cache the whole table in memory in Q1.

 For that case, if a partition is on the disk, Spark needs to load the entire partition to memory before filtering blocks.
It sounds like something can be done better in 3rd party data sources, or we need to change the Spark core just for a better table cache, which seems risky.

@cloud-fan for this case, if the data has been dumped to disk or some non-local tasks are started, I/O is involved in addition to the overhead to start extra tasks. If all data is in-memory, only the overhead related to tasks' launching is there

It sounds like something can be done better in 3rd party data sources, or we need to change the Spark core just for a better table cache, which seems risky.

Yes, some work can be done in 3rd party data sources, e.g. to avoid parsing overhead in parquet,
Regarding the risk, in the current implementation, I directly modify the core part to add a new type of block and make it recognizable by BlockManager. The new RDD and dependency implementation is in SQL module. An alternative way to do that is implementing this new type block in SQL as well (but it needs some small refactoring to make BlockManager open to anything outside of Spark Core)
I personally think it's a good feature to add without that much threat to existing code

@CodingCat Is this still active?

@maropu , this looks rather cold :sunglasses: , but extremely interesting and relevant.

If the author is inactive, its ok to take this over by someone. But, we should first discuss more to get consensus for this feature. I'm not sure we could get enough performance gains at the expense of the current simple cache logic.

When I contributed it back, the community is as looking at something else, so I didn’t spend too much time to convince the people to review....but if the interests are raised again now, I am happy to pick it up again,

Test build #97714 has finished for PR 19810 at commit 9d450ad.

This patch fails to generate documentation.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97714/
Test FAILed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4244/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4260/
Test PASSed.

Build finished. Test FAILed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15781/
Test PASSed.


The great 0.0.13 virtual-dom upgrade

This is an issue for blockers on the upgrade

[x] @raynos write a test in mercury for examples/bmi-counter.js
[x] @raynos upgrade virtual-hyperscript to 0.0.13 + author tests for virtual-hyperscript
[x]  @Matt-Esch upgrade main-loop to 0.0.13 + author tests for main-loop
[x] @raynos add getElementsByClassName to min-document
[x] @Matt-Esch upgrade mercury to 0.0.13
[x] @Matt-Esch upgrade vdom-thunk, virtual-hyperscript, main-loop in mercury
[x] manually test all examples
[x] rebase the branches on master + test those examples
[x] #shipit

This has completed, issue can be closed.

Cool :)

@kumavis I added you as a collaborator :)


Sync'ed credentials requirement

Sync'ed account is not needed when using AzFilesHybrid module.

@khdownie -
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Checking with devs on this. I believe that in at least some situations, synced credentials are required.

@Mine-MSFT can you confirm the synced credentials requirement for AzFilesHybrid?

I made some updates to this article that included this change. #please-close


Overlapping graph with extreme values

fix https://github.com/bancorprotocol/carbon-app/issues/987
fix https://github.com/bancorprotocol/carbon-app/issues/972

Initialize min & max differently if market price is below 1wei
Change graph ratio to support large difference between price range and between market price & price.
Ensure price initialization in production mode

[ ] when dragging the handles in the chart, the input prices do not change to reflect
[ ] at some point, when dragging the handles, the price reset to a high value for some reason
https://github.com/bancorprotocol/carbon-app/assets/40430285/0989ddde-d4a3-483c-8284-4642ff42d1df


Implement Struct

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Needs CI to be ran again as it got confused and ended up not running


⚠ Bofrost.com has degraded performance

In 9c3a0f4, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 503
Response time: 839 ms

Resolved: Bofrost.com performance has improved in f16a753.


Display text bluer when we  reset text

i have added code in viewDidLoad
let  aTextField.frame = CGRect(x:20, y:300, width:UIScreen.main.bounds.width-40, height:45)
aTextField.delegate = self
aTextField.text = "hello"
aTextField.placeholder = "Password"
aTextField.errorText = "error"
self.view.addSubview(aTextField)
clear text to my custom logic like this way
aTextField.text  = ""
then is display blur

hello,
      can you please re check the code in declaration you giving frames

but there is not textfield object can you get your code to me so that i can
check it?
On Fri, 14 Apr 2017 at 4:05 PM, kirti301290<EMAIL_ADDRESS>wrote:

i have added code in viewDidLoad
let aTextField.frame = CGRect(x:20, y:300,
width:UIScreen.main.bounds.width-40, height:45)
aTextField.delegate = self
aTextField.text = "hello"
aTextField.placeholder = "Password"
aTextField.errorText = "error"
self.view.addSubview(aTextField)
clear text to my custom logic like this way
aTextField.text = ""
then is display blur
[image: screen shot 2017-04-14 at 4 04 21 pm]
https://cloud.githubusercontent.com/assets/10956919/25041207/2416f4c2-212c-11e7-9f50-f80d3331a37e.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ErAbhishekChandani/ACFloatingTextfield/issues/19, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANMZ18xH6P7EtrSmh5JyVSaBXOOX2KmWks5rv0v7gaJpZM4M9pS7
.

--
Thanks & Regards
Er. Abhishek Chandani

thank you for reply
attached source code
click on button you will find problem
On Fri, Apr 14, 2017 at 4:13 PM, Er Abhishek Chandnai <
<EMAIL_ADDRESS>wrote:

hello,
can you please re check the code in declaration you giving frames
but there is not textfield object can you get your code to me so that i can
check it?
On Fri, 14 Apr 2017 at 4:05 PM, kirti301290<EMAIL_ADDRESS>wrote:

i have added code in viewDidLoad
let aTextField.frame = CGRect(x:20, y:300,
width:UIScreen.main.bounds.width-40, height:45)
aTextField.delegate = self
aTextField.text = "hello"
aTextField.placeholder = "Password"
aTextField.errorText = "error"
self.view.addSubview(aTextField)
clear text to my custom logic like this way
aTextField.text = ""
then is display blur
[image: screen shot 2017-04-14 at 4 04 21 pm]
<https://cloud.githubusercontent.com/assets/10956919/25041207/2416f4c2-
212c-11e7-9f50-f80d3331a37e.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ErAbhishekChandani/ACFloatingTextfield/issues/19,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/
ANMZ18xH6P7EtrSmh5JyVSaBXOOX2KmWks5rv0v7gaJpZM4M9pS7>
.

--
Thanks & Regards
Er. Abhishek Chandani
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ErAbhishekChandani/ACFloatingTextfield/issues/19#issuecomment-294134241,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKcwd4shUk4Shgg8uJVLS8PyyAF8s-Zuks5rv03agaJpZM4M9pS7
.

i could not find any attachment ?
On Fri, 14 Apr 2017 at 5:25 PM, kirti301290<EMAIL_ADDRESS>wrote:

thank you for reply
attached source code
click on button you will find problem
On Fri, Apr 14, 2017 at 4:13 PM, Er Abhishek Chandnai <
<EMAIL_ADDRESS>wrote:

hello,
can you please re check the code in declaration you giving frames
but there is not textfield object can you get your code to me so that i
can
check it?
On Fri, 14 Apr 2017 at 4:05 PM, kirti301290<EMAIL_ADDRESS>wrote:

i have added code in viewDidLoad
let aTextField.frame = CGRect(x:20, y:300,
width:UIScreen.main.bounds.width-40, height:45)
aTextField.delegate = self
aTextField.text = "hello"
aTextField.placeholder = "Password"
aTextField.errorText = "error"
self.view.addSubview(aTextField)
clear text to my custom logic like this way
aTextField.text = ""
then is display blur
[image: screen shot 2017-04-14 at 4 04 21 pm]
<
https://cloud.githubusercontent.com/assets/10956919/25041207/2416f4c2-
212c-11e7-9f50-f80d3331a37e.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ErAbhishekChandani/ACFloatingTextfield/issues/19,
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/
ANMZ18xH6P7EtrSmh5JyVSaBXOOX2KmWks5rv0v7gaJpZM4M9pS7>
.

--
Thanks & Regards
Er. Abhishek Chandani
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/ErAbhishekChandani/ACFloatingTextfield/issues/19#issuecomment-294134241
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AKcwd4shUk4Shgg8uJVLS8PyyAF8s-Zuks5rv03agaJpZM4M9pS7
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ErAbhishekChandani/ACFloatingTextfield/issues/19#issuecomment-294141857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANMZ1yMnMaGYzgdvAHkwcLpTtd2DXuq6ks5rv16ugaJpZM4M9pS7
.

--
Thanks & Regards
Er. Abhishek Chandani

here is attached file
ACFloatingTextField-Swift.zip

ya its an issue i will fix this ASAP..
On Wed, 19 Apr 2017 at 8:35 PM, kirti301290<EMAIL_ADDRESS>wrote:

@ErAbhishekChandani https://github.com/ErAbhishekChandani waiting for
your reply
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ErAbhishekChandani/ACFloatingTextfield/issues/19#issuecomment-295302326,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANMZ1-om6QzBibV__zw9eel63H9yblmcks5rxiLGgaJpZM4M9pS7
.

--
Thanks & Regards
Er. Abhishek Chandani

Hello Kirti,
This issue has been resolved , please checkout the latest version of pod . Thanks  for bringing this issue .
Thanks.


I wish /docs/api-reference/v1/operations/definitions/ existed

I wish /docs/api-reference/v1/operations/definitions/ existed

That has never existed. there is .../operations/ and .../definitions/ but never /operations/definitions.
See: https://github.com/kubernetes/kubernetes/tree/gh-pages/_v1.1/docs/api-reference/v1

Closing as there's no way to tell where to redirect such a request and it doesn't look to be valid


Can't build or test locally

Compiler version
3.6 nightly
Minimized example
clean
scala3-bootstrapped/clean
scaladoc/clean
scaladoc-js-main/clean
scaladoc-js-main/test

Output
[error] error while loading scaladoc,
[error] TASTy file /Users/odersky/workspace/dotty/scaladoc-js/out/bootstrap/scaladoc-js-common/scala-3.6.0-RC1-bin-SNAPSHOT-nonbootstrapped/classes/dotty/tools/scaladoc/CodeSnippets.tasty could not be read, failing with:
[error]   Backward incompatible TASTy file has version 28.5-experimental-1, produced by Scala 3.6.0-RC1-bin-SNAPSHOT-nonbootstrapped-git-0cf25db,
[error]   expected stable TASTy from 28.0 to 28.5, or exactly 28.6-experimental-1.
[error]   The source of this file should be recompiled by a later version.
[error]   Usually this means that the classpath entry of this file should be updated.
[error]   Please refer to the documentation for information on TASTy versioning:
[error]   https://docs.scala-lang.org/scala3/reference/language-versions/binary-compatibility.html

Expectation
No Tasty conflict. Note also that it claims that the version it has 28.6-experimental-1 is among the versions that it expected, yet there's still an error.
This is a blocker for me to debug the test failures in my latest commit. Without this being fixed we cannot expect any forward progress in fixing issues.

I'm not able to reproduce this locally 😥

I cleaned my out directory and that fixed it. It seems there were artefacts from previous runs that were not cleaned by scala3-boostrapped/clean. Probably worth checking why that happens.
The original error is now gone on my side as well. But I still get the following test failure:
[error] All tests passed after retry, indicating that some tests are flaky.
[error] This build is configured to reject flaky tests.
[error] Failed: Total 661, Failed 0, Errors 0, Passed 661, Ignored 7
[error] (scala3-compiler-bootstrapped / Test / testOnly) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 1488 s (24:48), completed 18 Sep 2024, 14:32:30

Do we know which tests are flakey and can we do something about it?
Even so, it's workable now, so removing the blocker status.

Do we know which tests are flakey and can we do something about it?

I believe that this error message was introduced by the new develocity plugin. We do publish reports in https://develocity.scala-lang.org/ so maybe some extra information can be found there

Do we know which tests are flakey and can we do something about it?

Yes I also think this message comes from the Develocity plugin. Probably you should see the failing tests in the logs, if you scroll back enough. Or maybe they are flagged as flaky in the test report.
@dotta do you have an example of sbt test report with flaky tests?

I cleaned my out directory and that fixed it. It seems there were artefacts from previous runs that were not cleaned by scala3-boostrapped/clean. Probably worth checking why that happens.

The corrupted TASTy file was in the scaladoc-js-common project. To clean it you should do scaladoc-js-common/clean.

Also it's worth noting there were no flaky test in the entire history of  https://develocity.scala-lang.org/. So it could some changes locally or some corrupted state that cause the flakiness in your build @odersky.

Also it's worth noting there were no flaky test in the entire history of https://develocity.scala-lang.org/. So it could some changes locally or some corrupted state that cause the flakiness in your build @odersky.

Both @odersky and I had this message locally. For me, it was on a "fresh" clone of the repository (after running git clean -xfd).

I also think this message comes from the Develocity plugin. Probably you should see the failing tests in the logs, if you scroll back enough. Or maybe they are flagged as flaky in the test report.

No test failed for me locally, only this message appears at the end.

No test failed for me locally, only this message appears at the end.

Can you share the logs?

The previous run actually had the same errors, we just missed them 😅. I'm now wondering now why that the flakiness of that test wasn't detected before introducing develocity; last change was 3 months ago.

Do we know which tests are flakey and can we do something about it?

I also think this message comes from the Develocity plugin. Probably you should see the failing tests in the logs, if you scroll back enough. Or maybe they are flagged as flaky in the test report.
@dotta do you have an example of sbt test report with flaky tests?

@adpi2 Would you have a link to the specific build scan that was published when the output in this message was produced?
Asking because I had a quick look at build scans with test failures, and I noticed the second execution seems to be skipped in some cases (see this build scan for instance), and I wonder if that might explain why the test isn't marked flaky. But I'd prefer to have a look at the specific build scan as there may be a good reason why the build scan I was looking at is the way it is.
Btw, see https://docs.gradle.com/enterprise/sbt-plugin/#test_case_details_page for an example of a flaky test reported in the test case details page. And here you can see an actual build scan from the apache pekko project with a flaky test execution reported (beware though that the linked page will eventually disappear due to the data retention window).


Add patch to make package

If we make deb package, we can add patch file in debian directory.
If we make a rpm package, we can add patch file in rpm directory.
If we make AUR package,  we can add patch rule in PKGBUILD file and add patch file.
And about vcpkg, they also have patch rule.
When we wanan to change something in xmake package script, we need "io.replace" or "io.gsub", this is not flexible at all. Building package sometimes, we need customization.
So I think  we need patch enhancement while making package for xmake repo.

You can also use add_patches to add some patch files. see
https://github.com/xmake-io/xmake-repo/blob/7b44576aa1b54d67a04e4088e816d6a7143c4f0c/packages/b/bin2c/xmake.lua#L10
io.replace is only used to modify some small changes

cools


 Why not:
this._rowDefs.some((def: BaseRowDef) => !!def.getColumnsDiff())

?

Probably no particular reason; feel free to send a PR if you want to clean it up. Closing this since it's not a functional bug


div.row > div.six.columns (or other sizes) doesn't seem to break to block (100%) on Safari iOS

I designed / coded a page and in Chrome it's fine (tested using the responsive mode, aka device toolbar), but when I use on my actual phone, the div.row > div.six.columns doesn't seem to ocupy 100% of the width, breaking the whole viewport :( is it because of the @media queries using ppi instead of pixels? ( @media only screen and (max-resolution: 119dpi) and (min-resolution: 91dpi), not all html )

@robsheldon could you test it on Android or you had this behavior before?

I hadn't seen this behavior in previous device tests. I suspect there's some combination of html and the css that's causing this. I need to figure out the html part. I'll make time for it tomorrow at the latest.

@robsheldon to me it's an @media issue, more specifically @media (min-width: 40rem) the .row and .column being handled.
Even the official website has the same (bugged) behavior.
Chrome on Responsive Mode:

Real iPhone 8 Plus (tried Safari, Chrome, etc):

Seems to be an iOS issue as I said, ported from Miligram ( https://github.com/milligram/milligram/issues/136 ).
My fix was replacing the rem to px as below:
@media screen and (max-width: 639px) {
  .row {
    flex-direction: column;
  }
  .column, .columns {
    width: 100% !important;
    margin: 0 !important;
    padding: 0 !important;
  }
}

Thank you for doing so much leg-work on this issue. I do want to fix it, my hang-up has been on finding the right approach for it.
The media queries are given in rem units to help improve support for environments with scaled displays -- some people with poor eyesight may have browser options set to scale things and using rems supports that better than px.
I'm reluctant to just bump the max-width on that media selector from 40 to 45rem because there are still going to be a handful of handheld devices with this behavior.
I think the right thing to do is to switch to using device-width and pixels, but that's not a change I want to make in a point update.
So, I'm going to do a bugfix release for the other two bugs that have been reported, and then see if changing up the media queries is going to break anything. If not, I'll do a minor release with that fix.


Add web3.js in sdks section

I think the web3 package can be added as a resource in the sdk section

hi, Web3.js is already in the repository but in another section
https://github.com/FrancescoXX/free-Web3-resources#client-sdks

Ah I see. My bad


Error:module 'scatlasvae.tools' has no attribute 'transfer_umap'

run to the "Query-to-reference mapping to pan-disease CD8 T atlas" with code belowed:
adata_transfer.obsm["X_umap"] = scatlasvae.tl.transfer_umap(
adata_cd8.obsm["X_gex"],
adata_cd8.obsm["X_umap"],
adata_transfer.obsm["X_gex"],
method="knn",
n_neighbors=3,
)["embedding"]
the error message:
AttributeError                            Traceback (most recent call last)
Cell In[33], line 1
----> 1 adata_transfer_tex.obsm["X_retrain_umap"] = scatlasvae.tl.transfer_umap(
2     adata_cd8_tex.obsm["X_retrain_GEX"],
3     adata_cd8_tex.obsm["X_retrain_umap"],
4     adata_transfer_tex.obsm["X_retrain_GEX"],
5     method="knn",
6     n_neighbors=3,
7 )["embedding"]
9 adata_transfer_tex.obs["cell_subtype_4"] = vae_model_transfer.predict_labels(
10     return_pandas=True
11 )["cell_subtype_4"]
AttributeError: module 'scatlasvae.tools' has no attribute 'transfer_umap'
can i use code below instead?
adata_transfer.obsm['X_umap'] = umap.UMAP().fit_transform(adata_transfer.obsm['X_gex'])

please replace scatlasvae.tl.transfer_umap with scatlasvae.tl.umap_alignment. Sorry for the inconvenience due to the un-updated version of the documentation.

Thanks for your kind help. you are always helpful. haha


Organize styling

Some css is only used by one tab. We can remove it from the main stylesheet and add it as a style element on the html file it belongs to. When the tab is changed it is removed from memory.

Tailwind has handled most of this. We will still have some cleanup to do but it is much easier to navigate now.
v2.5 (command trigger system) will focus on getting tailwind usable, v2.6 => onward will use it properly. (functions, directives, apply,etc)


Issue while trying to remove the recipient.

-I've added two recipients i.e Arpan sir (F&F recipient) and saving account.

-When I'm trying to remove Arpan sir,it is showing that I'm removing account(but no name is specified below "Sending to").

-When I'm trying to remove Savings account,it is showing that I'm removing Arpan sir.

-Now app is crashing while trying to remove recipient.
-Tested on staging app version 1.3.1(164)

i too was able to recreate this

-Verified thisissue on dev app version 1.3.2(170)


Pretrained model

Hello,
First, I would like to thank you for this project.
I would like to get the pre-trained model ( frozen model .pb ) to use it for retraining the model with data augmentation and other images.
Can you send it?

No Sorry, I had not kept backup for this pb model.
Thanks
On Sat, 16 May 2020 at 05:52, Neji Abdechafi<EMAIL_ADDRESS>wrote:

Hello,
First, I would like to thank you for this project.
I would like to get the pre-trained model ( frozen model .pb ) to use it
for retraining the model with data augmentation and other images.
Can you send it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kotaielectronics-dot-com/Face-Mask-Detector/issues/3,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APOZMYETUW4SIDOFA2UNPU3RRXMDJANCNFSM4NCVLAKQ
.

--
Satya Sankar Sahoo
Director of Technical Services
Kotai Electronics Pvt. Ltd.
Click Here For Company Profile
https://drive.google.com/file/d/1-b2qBmXLKaD3MrtI7XwKhhP8kkfjgSJx/view?usp=sharing
[image: kotai electronics logo]
T: + 91 971 77 68653
M: +91 82 801 698 56
www.kotaiElectronics.com http://www.kotaielectronics.com/
1A, DF 35, Newtown Kolkata, India
[image: Facebook icon] https://www.facebook.com/kotai.electronics  [image:
LinkedIn icon] https://in.linkedin.com/company/kotai-electronics  [image:
Twitter icon] https://in.linkedin.com/company/kotai-electronics  [image:
Google Plus icon] https://in.linkedin.com/company/kotai-electronics  [image:
Youtbue icon] https://www.youtube.com/channel/UCjz-bda-fHRlRzehcAX3khw
This message (and any associated files) is intended only for the use of the
individual or entity to which it is addressed and may contain information
that is confidential, subject to copyright or constitutes a trade secret.
If you are not the intended recipient you are hereby notified that any
dissemination, copying or distribution of this message, or files associated
with this message, is strictly prohibited. If you have received this
message in error, please notify us immediately by replying to the message
and deleting it from your computer. Messages sent to and from us may be
monitored.

No Sorry, I had not kept backup of this pb file.
Thanks

Hello
Thanks for sharing a good code.
I want to know how to create a model.
Thans.


Support clang

Clang is not behaving like gcc and seems lacking some instructions:

[x] Add the clang support in configure (e.g. add -maltivec)
[x] Write the function replacements and use them only for clang
[x] Benchmark and test on clang as well.

Clang managed to issue a warning for ptrdiff_t usage in vec_vsx_ld and vec_vsx_st, beside that seems working fine, the workaround for vec_xxpermdi is slow as expected.

The current clang seems to work decently.


dart:math library asin function returns different results across native platforms

I have noticed a discrepancy in the behavior of the asin function from the dart:math library across different operating systems. Specifically, when executing the function on Ubuntu, the values -0.8613343773019345 and -0.8613328769698687 produce -1.0378903813942377 and -1.037887428215712, respectively. However, on Windows and macOS, the same input values yield -1.0378903813942375 and -1.0378874282157122, respectively. It is worth noting that the latter values match those returned by the Math.asin method in JavaScript.
Can it be clarified if the expected behavior is that the results in Ubuntu are necessarily identical to those in Windows and macOS? Alternatively, is the current behavior of the function considered as intended?
Environment:
Ubuntu 22.04

OS Version: 22.04.2 LTS
Kernel Version: 5.15.0-1036-azure
Image Version: 20230426.1
Systemd version: 249.11-0ubuntu3.9
Dart SDK version: 2.19.6 (stable) (Tue Mar 28 13:41:04 2023 +0000) on "linux_x64"

Windows Server 2022

OS Version: 10.0.20348 Build 1668
Image Version: 20230502.2
Dart SDK version: 2.19.6 (stable) (Tue Mar 28 13:41:04 2023 +0000) on "windows_x64"

macOS 12

OS Version: macOS 12.6.5 (21G531)
Kernel Version: Darwin 21.6.0
Image Version: 20230425.1
Dart SDK version: 2.19.6 (stable) (Tue Mar 28 13:41:04 2023 +0000) on "macos_x64"

I think current behaviour is considered as intended. We just call whatever implementation of asin that libc provides without any portability or precision guarantees.
/cc @lrhn

Agree. We do not try to invent our own trigonometric functions, we just use whatever is provided by the compiler.
As @mraleph says, it's not the platform/operating system as much as it is the C++ compiler's standard library (libc) that matters. (Or the browser's JavaScript implementation on the web, which can also differ between browsers. It might not - at least Firefox seems to agree with Chrome, at least on Math.asin, but I know there have been discrepancies in the past.)
We could try to standardize on a particular implementation on native platforms too,  say by copying the V8 implementation.
It's extra work, and may or may not be as efficient as what comes with the compiler anyway.


script cannot be loaded because not found in addons (Failed to load resource)

Hello thank you for your project, I try to learn programming and godot
I try to clone the repository and play it in godot and got this error,
any advice how to fix this issue?, when i look into addons folder this gd script cannot be found
Have a nice day :)

Godot Engine v3.5.1.stable.official.6fed1ffa3 - https://godotengine.org
OpenGL ES 3.0 Renderer: Intel(R) UHD Graphics 600
Async. shader compilation: OFF

Editing project: C:/Users/Acer/Projects/Pokemon-Battle (C:::Users::Acer::Projects::Pokemon-Battle)

Godot Engine v3.5.1.stable.official.6fed1ffa3 - https://godotengine.org
OpenGL ES 3.0 Renderer: Intel(R) UHD Graphics 600
Async. shader compilation: OFF

ERROR: Condition "err" is true. Returned: err
   at: load_source_code (modules/gdscript/gdscript.cpp:807)
ERROR: Cannot load source code from file 'res://addons/dialogic/Other/DialogicSingleton.gd'.
   at: (modules/gdscript/gdscript.cpp:2209)
ERROR: Failed loading resource: res://addons/dialogic/Other/DialogicSingleton.gd. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
ERROR: Can't autoload: res://addons/dialogic/Other/DialogicSingleton.gd.
   at: (editor/editor_autoload_settings.cpp:355)
ERROR: Cannot open file 'res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn'.
   at: (scene/resources/resource_format_text.cpp:1183)
ERROR: Failed loading resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
ERROR: Cannot open file 'res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn'.
   at: (scene/resources/resource_format_text.cpp:1183)
ERROR: Failed loading resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
WARNING: Couldn't load external resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn
     at: _parse_ext_resource (scene/resources/resource_format_text.cpp:157)
ERROR: Cannot open file 'res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn'.
   at: (scene/resources/resource_format_text.cpp:1183)
ERROR: Failed loading resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
WARNING: Couldn't load external resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn
     at: _parse_ext_resource (scene/resources/resource_format_text.cpp:157)
ERROR: Condition "!sdata.is_valid()" is true. Returned: nullptr
   at: instance (scene/resources/packed_scene.cpp:165)
ERROR: Condition "!node" is true. Returned: nullptr
   at: instance (scene/resources/packed_scene.cpp:167)
ERROR: Parameter "p_child" is null.
   at: add_child (scene/main/node.cpp:1280)
SCRIPT ERROR: Invalid set index 'editor_interface' (on base: 'null instance') with value of type 'EditorInterface'.
          at: _enter_tree (res://addons/dialogic/plugin.gd:26)
ERROR: Condition "err" is true. Returned: err
   at: load_source_code (modules/gdscript/gdscript.cpp:807)
ERROR: Cannot load source code from file 'res://addons/dialogic/Other/DialogicSingleton.gd'.
   at: (modules/gdscript/gdscript.cpp:2209)
ERROR: Failed loading resource: res://addons/dialogic/Other/DialogicSingleton.gd. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
ERROR: Can't autoload: res://addons/dialogic/Other/DialogicSingleton.gd.
   at: (editor/editor_autoload_settings.cpp:355)
ERROR: Condition "!info->node" is true. Continuing.
   at: update_autoload (editor/editor_autoload_settings.cpp:496)
Running: C:/Users/Acer/Downloads/Godot_v3.5.1-stable_win64.exe/Godot_v3.5.1-stable_win64.exe --path C:/Users/Acer/Projects/Pokemon-Battle --remote-debug <IP_ADDRESS>:6007 --allow_focus_steal_pid 9472 --position 171,84

Godot Engine v3.5.1.stable.official.6fed1ffa3 - https://godotengine.org
OpenGL ES 3.0 Renderer: Intel(R) UHD Graphics 600
Async. shader compilation: OFF

ERROR: Condition "err" is true.  Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
ERROR: res://addons/dialogic/Editor/Events/Templates/EventTemplate.tscn:4 - Parse Error: [ext_resource] referenced nonexistent resource at: res://addons/dialogic/Editor/Events/Parts/EventBlock/ExpandControl.tscn
   at: poll (scene/resources/resource_format_text.cpp:412)
ERROR: Failed to load resource 'res://addons/dialogic/Editor/Events/Templates/EventTemplate.tscn'.
   at: (core/io/resource_loader.cpp:206)
ERROR: Failed loading resource: res://addons/dialogic/Editor/Events/Templates/EventTemplate.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
ERROR: res://dialogic/custom-events/battle_anim/EventBlock.tscn:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://addons/dialogic/Editor/Events/Templates/EventTemplate.tscn
   at: poll (scene/resources/resource_format_text.cpp:412)
ERROR: Failed to load resource 'res://dialogic/custom-events/battle_anim/EventBlock.tscn'.
   at: (core/io/resource_loader.cpp:206)
ERROR: Failed loading resource: res://dialogic/custom-events/battle_anim/EventBlock.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)

You're right that there is no res://addons/dialogic/Other/DialogicSingleton.gd in the file path, and you're not the only one to encounter this problem. However, I don't really know how to solve this issue as it doesn't happen on my side. But what I can do is you look at your proposal.

Now that I've updated Dialogic to 1.4.5, could you play test it again to see whether you get the same error?

still cannot play the project with same error
Step to reproduce in Windows 11 and Godot 3.5.1:

git clone the latest update

mkdir upstream
cd upstream
git clone https://github.com/Pocket-Godot/Pokemon-Battle.git

open project in Godot

Godot Engine v3.5.1.stable.official.6fed1ffa3 - https://godotengine.org
OpenGL ES 3.0 Renderer: Intel(R) UHD Graphics 600
Async. shader compilation: OFF

Project is missing: C:/Users/Acer/Projects/Pokemon-Battle/project.godot
Scanning projects at: C:/Users/Acer/Projects/upstream/Pokemon-Battle
Found 1 projects.
Editing project: C:/Users/Acer/Projects/upstream/Pokemon-Battle (C:::Users::Acer::Projects::upstream::Pokemon-Battle)

Godot Engine v3.5.1.stable.official.6fed1ffa3 - https://godotengine.org
OpenGL ES 3.0 Renderer: Intel(R) UHD Graphics 600
Async. shader compilation: OFF

ERROR: Condition "err" is true. Returned: err
   at: load_source_code (modules/gdscript/gdscript.cpp:807)
ERROR: Cannot load source code from file 'res://addons/dialogic/Other/DialogicSingleton.gd'.
   at: (modules/gdscript/gdscript.cpp:2209)
ERROR: Failed loading resource: res://addons/dialogic/Other/DialogicSingleton.gd. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
ERROR: Can't autoload: res://addons/dialogic/Other/DialogicSingleton.gd.
   at: (editor/editor_autoload_settings.cpp:355)
ERROR: Cannot open file 'res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn'.
   at: (scene/resources/resource_format_text.cpp:1183)
ERROR: Failed loading resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
ERROR: Cannot open file 'res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn'.
   at: (scene/resources/resource_format_text.cpp:1183)
ERROR: Failed loading resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
WARNING: Couldn't load external resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn
     at: _parse_ext_resource (scene/resources/resource_format_text.cpp:157)
ERROR: Cannot open file 'res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn'.
   at: (scene/resources/resource_format_text.cpp:1183)
ERROR: Failed loading resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
WARNING: Couldn't load external resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn
     at: _parse_ext_resource (scene/resources/resource_format_text.cpp:157)
ERROR: Cannot open file 'res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn'.
   at: (scene/resources/resource_format_text.cpp:1183)
ERROR: Failed loading resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
WARNING: Couldn't load external resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn
     at: _parse_ext_resource (scene/resources/resource_format_text.cpp:157)
ERROR: Cannot open file 'res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn'.
   at: (scene/resources/resource_format_text.cpp:1183)
ERROR: Failed loading resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
ERROR: Cannot open file 'res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn'.
   at: (scene/resources/resource_format_text.cpp:1183)
ERROR: Failed loading resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
WARNING: Couldn't load external resource: res://addons/dialogic/Editor/Events/Parts/ResourcePickers/ResourcePickerMenu.tscn
     at: _parse_ext_resource (scene/resources/resource_format_text.cpp:157)
ERROR: Condition "!sdata.is_valid()" is true. Returned: nullptr
   at: instance (scene/resources/packed_scene.cpp:165)
ERROR: Condition "!node" is true. Returned: nullptr
   at: instance (scene/resources/packed_scene.cpp:167)
ERROR: Parameter "p_child" is null.
   at: add_child (scene/main/node.cpp:1280)
SCRIPT ERROR: Invalid set index 'editor_interface' (on base: 'null instance') with value of type 'EditorInterface'.
          at: _enter_tree (res://addons/dialogic/plugin.gd:26)
Running: C:/Users/Acer/Downloads/Godot_v3.5.1-stable_win64.exe/Godot_v3.5.1-stable_win64.exe --path C:/Users/Acer/Projects/upstream/Pokemon-Battle --remote-debug <IP_ADDRESS>:6007 --allow_focus_steal_pid 1116 --position 171,84

Godot Engine v3.5.1.stable.official.6fed1ffa3 - https://godotengine.org
OpenGL ES 3.0 Renderer: Intel(R) UHD Graphics 600
Async. shader compilation: OFF

ERROR: Condition "err" is true.  Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
ERROR: res://dialogic/custom-events/anim_unit/EventPart.tscn:3 - Parse Error: [ext_resource] referenced nonexistent resource at: res://addons/dialogic/Editor/Events/Parts/Text/CustomLineEdit.tscn
   at: poll (scene/resources/resource_format_text.cpp:412)
ERROR: Failed to load resource 'res://dialogic/custom-events/anim_unit/EventPart.tscn'.
   at: (core/io/resource_loader.cpp:206)
ERROR: Failed loading resource: res://dialogic/custom-events/anim_unit/EventPart.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)
ERROR: res://dialogic/custom-events/anim_unit/EventBlock.tscn:4 - Parse Error: [ext_resource] referenced nonexistent resource at: res://dialogic/custom-events/anim_unit/EventPart.tscn
   at: poll (scene/resources/resource_format_text.cpp:412)
ERROR: Failed to load resource 'res://dialogic/custom-events/anim_unit/EventBlock.tscn'.
   at: (core/io/resource_loader.cpp:206)
ERROR: Failed loading resource: res://dialogic/custom-events/anim_unit/EventBlock.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:270)

To fix the issue I do manual copy paste latest version of dialogic 1.4.5 to addons folder the Project can be play same  way the issue #3 fix his issue

Glad that you have resolved your issue on your own, though I'm still puzzled by how or why the project would try to access res://addons/dialogic/Other/DialogicSingleton.gd on your end.

Thank you, hope the project can be alternatives for pokemon essential in the future.


proposed-api-sample postinstall doesn't work on Windows

&& doesn't work on windows.
"postinstall": "vscode-dts dev && vscode-dts master"

I don't really want to introduce dependencies, and just learned install and postinstall run sequentially after installing deps. So opted to use that.

Yep, alternatively this works too:
		"downloadapi": "vscode-dts master",
		"postdownloadapi": "vscode-dts dev",
		"postinstall": "npm run downloadapi"

predownloadapi would be available too if we needed a third

Wow, didn't realize this was possible:

Additionally, arbitrary scripts can be executed by running npm run-script . Pre and post commands with matching names will be run for those as well (e.g. premyscript, myscript, postmyscript).

Changed to use that instead.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2019

Questions ?
Please refer to the Backport tool documentation


2.0.200，SRS crash, thread cycle failed.

Program terminated with signal 11, Segmentation fault.
#0  0x00000000004bbf98 in internal::SrsThread::thread_cycle (this=0x210f390) at src/app/srs_app_thread.cpp:239
239	        disposed = true;
Missing separate debuginfos, use: debuginfo-install glibc-2.12-1.107.el6.x86_64 libgcc-4.4.7-3.el6.x86_64 libstdc++-4.4.7-3.el6.x86_64
(gdb) bt
#0  0x00000000004bbf98 in internal::SrsThread::thread_cycle (this=0x210f390) at src/app/srs_app_thread.cpp:239
#1  0x00000000004bbff7 in internal::SrsThread::thread_fun (arg=0x210f390) at src/app/srs_app_thread.cpp:247
#2  0x000000000054a90a in _st_thread_main () at sched.c:327
#3  0x000000000054b0a4 in st_thread_create (start=0x54b81e <st_usleep+202>, arg=0x7eff69480b40, joinable=32511, stk_size=1758600752) at sched.c:591
#4  0x00000000004bba41 in internal::SrsThread::start (this=Cannot access memory at address 0x7ffffffd9
) at src/app/srs_app_thread.cpp:109
Backtrace stopped: previous frame inner to this frame (corrupt stack?)
(gdb)

(gdb) f 1
#1  0x00000000004bbff7 in internal::SrsThread::thread_fun (arg=0x210f390) at src/app/srs_app_thread.cpp:247
247	        obj->thread_cycle();
(gdb) p obj[0]
Cannot access memory at address 0x210f390

可见这个obj已经被释放过了的。


Feature to request different quality if another quality is already added.

Currently we can add any 1 quality through bot. and we cant add same title again as the bot says "Already Added".
is it possible to add this feature. this will be very useful specially for readarr. as some users want Audiobook and some want Ebook.
same applies for TV/Movies

Searcharr supports multiple quality profiles for each of the *arr apps, but a single profile has to be selected for each title. The *arr apps only support adding a given title one time. Many people maintain two copies of Radarr, one for HD and one for 4K. You could do the same with Readarr, one for eBook and one for Audiobook.

so I will have to deploy two different bots?

Yes, searcharr currently supports one instance of each *arr app. You will need a second instance of searcharr if you wish to use it for a second instance of the *arr app(s).
You can simplify the process of using two bots if you add them to a group and configure non-overlapping commands for the two bots. For example set the book command to /ebook for one bot and /audiobook for the other. That way only one bot will respond to each command and you/your users don't need to switch between bots themselves.


v-model on checkboxes inside button group

I try to implement a simple button group with checkboxes to define an address type.
The model looks like this:
{    ...    isClient: boolean,    isSupplier: boolean,    isManufacturer: boolean,    ... }
If I use the button group like this with checked = []
<button-group v-model="checked">     <checkbox name="isClient">         Client     </checkbox>     <checkbox name="isSupplier">         Supplier     </checkbox>     <checkbox name="isManufacturer">         Manufacturer     </checkbox> </button-group>
it's not possible to check a single button. If I check for example the isClient checkbox all types are set to true - not just the client checkbox which is expected.
If I use v-model on the checkboxes directly
<button-group>     <checkbox v-model="address.isClient" name="isClient">         Client     </checkbox>     <checkbox v-model="address.isSupplier" name="isSupplier">         Supplier     </checkbox>     <checkbox v-model="address.isManufacturer" name="isManufacturer">         Manufacturer     </checkbox> </button-group>
only selected checkboxes are set to true - which is the desired behaviour - but I got an javascript error in the console because checkbox is trying to update the parent (Cannot read property 'indexOf' of null).
So I see no way to implement this case without javascript error.
Any suggestions please?

Read the docs.  Example there works.  I think button-group has v-model, then each checkbox has a true-value attribute.

Of course I've read the (sadly often incomplete) docs @gswilcox01 !
If you've read my question you could see that I'm trying to bind a different model - which simply is not possible in this way. Used a hack.
thanks anyway!


Titlebar Backround color

I added button "Change Background color". On the click event, I call the this.SetTitleBarBackgroundColors(Microsoft.UI.Colors.Black);
And the color near the icon does not change

Aaaah if I do it delayed I see the behavior. It "fixes" itself after moving the window. This would be an AppWindow bug. You should log this over in the Windows App SDK repo.

with custom titlebar I don't have that bug


COLMAP step not working in Docker build

Inside Docker containers, the app crashes at the camera pose estimation stage with the following error:
no transforms.json detected
This is likely due to COLMAP crashing or not starting.

When submitting one of the examples, the following new error occurs:
==============================================================================
Feature extraction
==============================================================================

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/gradio/routes.py", line 427, in run_predict
    output = await app.get_blocks().process_api(
  File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1323, in process_api
    result = await self.call_function(
  File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1051, in call_function
    prediction = await anyio.to_thread.run_sync(
  File "/usr/local/lib/python3.10/dist-packages/anyio/to_thread.py", line 33, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
    return await future
  File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 807, in run
    result = context.run(func, *args)
  File "/app/app.py", line 131, in run_nerf
    with open(os.path.join(tempdir, "transforms.json"), "r") as transforms:
FileNotFoundError: [Errno 2] No such file or directory: '/tmp/tmp5dg4vjxy/transforms.json'
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/gradio/routes.py", line 427, in run_predict
    output = await app.get_blocks().process_api(
  File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1323, in process_api
    result = await self.call_function(
  File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1051, in call_function
    prediction = await anyio.to_thread.run_sync(
  File "/usr/local/lib/python3.10/dist-packages/anyio/to_thread.py", line 33, in run_sync
    return await get_asynclib().run_sync_in_worker_thread(
  File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
    return await future
  File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 807, in run
    result = context.run(func, *args)
  File "/app/app.py", line 161, in create_video_defaults
    return create_video(params)
  File "/app/app.py", line 164, in create_video
    checkpoint_file = [f.name for f in params[nerf_files] if f.name.endswith(".ingp")][0]
TypeError: 'NoneType' object is not iterable


Problems with dispose() on RC6

Again, new RC broke something in GodotRx, this time it's the dispose() functionality.
For instance, when dispose() is called by Autodisposer, an Attempt to call function 'null::dispose (Callable)' on a null instance. error is thrown.
I don't have time to take a deeper look into this myself at the moment, but I thought I'd let you know ;)

I see. Thank you very much. Yesterday, I tested it with RC5 and was happy everything worked. I'll take a closer look at it. I guess considering GD4 we are in a hot phase right now. I hope things become more consistent from update to update when GD4 finally releases.


Device filters to narrow the search to only one item

AFAIK the correct way to use data sources filters is to narrow the search until obtain a unique result, which can be accessed directly. Also timeout/retry parameter when the list of objects is null could be interesting.
Whats your general thought on this? Is this a bug, or maybe is the desirable behaviour and then is a feature.
Thanks for your provider, I'm starting to use and abuse it a lot.

Glad its working for you so far!
When I wrote this, the mindset on list data sources was "I want to get a list of thing", with filters being "I want a list of these certain things". This was inspired seeing how a few other providers handle list with filters. I'm not sure I've seen exactly what you are describing, can you link to an example? I'm not sure with the attributes exposed it'd always be possible to filter down to one result. It could be possible to refactor the single item data source to do this by expanding the logic in the class to look for something based on a combination of different attributes. Can you share use cases you had in mind?
Timeouts for everything would be a good addition, I'd have to look into how to implement them. I might pick this up when I do an update for v0.23.

Sure, I misunderstand the filters section in other providers. I will close the issue.


Azure Cosmos DB Filtered Vector Search

Description
Filtered Vector Search Integration:

CosmosDB Mongo vCore
CosmosDB NoSql

New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[ ] Yes
[ ] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[x] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

@masci Please review this PR. As discussed on the original PR to break that into multiple PR's


The volume can`t update

When I updated the polybar to 3.0.5.
I found it always show 0%.
When I clicked the button, it can be muted.
But, I must use the alsamixer to unmute.Click it does not work(although it show unmute)

Can you make sure that all your settings in the volume module are still correct (a mixer or soundcard may have changed).
The mute/unmute problem may be that "mute" mutes all the mixers but "unmute" only unmutes a single mixer leaving sound turned off. Can you confirm that this is happening using alsamixer?

@patrick96 I found the config is incorrect, but it can work the last version.But how to unmute all the mixer.

Setting this up can be tricky. Can you post your internal/volume module as well as the output of cat /proc/asound/cards.
/proc/asound/cards will contain a few entries, each prefixed with a number. For each of the entries can you post the output of amixer -c $N controls and amixer -c $N scontrols where you replace $N with the number of the entry.

internal/volume
[module/volume]
type = internal/volume

master-soundcard = default
speaker-soundcard = default
headphone-soundcard = default

master-mixer = Master
speaker-mixer = Bass Speaker
headphone-mixer = Headphone

headphone-id = 16

cat /proc/asound/cards
 0 [PCH            ]: HDA-Intel - HDA Intel PCH
                      HDA Intel PCH at 0xdf428000 irq 323

amixer -c 0 controls
numid=46,iface=CARD,name='HDMI/DP,pcm=10 Jack'
numid=22,iface=CARD,name='HDMI/DP,pcm=3 Jack'
numid=28,iface=CARD,name='HDMI/DP,pcm=7 Jack'
numid=34,iface=CARD,name='HDMI/DP,pcm=8 Jack'
numid=40,iface=CARD,name='HDMI/DP,pcm=9 Jack'
numid=16,iface=CARD,name='Headphone Mic Jack'
numid=15,iface=CARD,name='Headset Mic Phantom Jack'
numid=17,iface=CARD,name='Internal Mic Phantom Jack'
numid=18,iface=CARD,name='Speaker Front Phantom Jack'
numid=19,iface=CARD,name='Speaker Surround Phantom Jack'
numid=14,iface=MIXER,name='Master Playback Switch'
numid=13,iface=MIXER,name='Master Playback Volume'
numid=11,iface=MIXER,name='Headphone Mic Boost Volume'
numid=5,iface=MIXER,name='Headphone Playback Switch'
numid=57,iface=MIXER,name='PCM Playback Volume'
numid=1,iface=MIXER,name='Front Playback Volume'
numid=7,iface=MIXER,name='Capture Source'
numid=9,iface=MIXER,name='Capture Switch'
numid=8,iface=MIXER,name='Capture Volume'
numid=23,iface=MIXER,name='IEC958 Playback Con Mask'
numid=29,iface=MIXER,name='IEC958 Playback Con Mask',index=1
numid=35,iface=MIXER,name='IEC958 Playback Con Mask',index=2
numid=41,iface=MIXER,name='IEC958 Playback Con Mask',index=3
numid=47,iface=MIXER,name='IEC958 Playback Con Mask',index=4
numid=24,iface=MIXER,name='IEC958 Playback Pro Mask'
numid=30,iface=MIXER,name='IEC958 Playback Pro Mask',index=1
numid=36,iface=MIXER,name='IEC958 Playback Pro Mask',index=2
numid=42,iface=MIXER,name='IEC958 Playback Pro Mask',index=3
numid=48,iface=MIXER,name='IEC958 Playback Pro Mask',index=4
numid=25,iface=MIXER,name='IEC958 Playback Default'
numid=31,iface=MIXER,name='IEC958 Playback Default',index=1
numid=37,iface=MIXER,name='IEC958 Playback Default',index=2
numid=43,iface=MIXER,name='IEC958 Playback Default',index=3
numid=49,iface=MIXER,name='IEC958 Playback Default',index=4
numid=26,iface=MIXER,name='IEC958 Playback Switch'
numid=32,iface=MIXER,name='IEC958 Playback Switch',index=1
numid=38,iface=MIXER,name='IEC958 Playback Switch',index=2
numid=44,iface=MIXER,name='IEC958 Playback Switch',index=3
numid=50,iface=MIXER,name='IEC958 Playback Switch',index=4
numid=6,iface=MIXER,name='Auto-Mute Mode'
numid=4,iface=MIXER,name='Bass Speaker Playback Switch'
numid=3,iface=MIXER,name='Bass Speaker Playback Volume'
numid=58,iface=MIXER,name='Digital Capture Volume'
numid=10,iface=MIXER,name='Headset Mic Boost Volume'
numid=12,iface=MIXER,name='Internal Mic Boost Volume'
numid=2,iface=MIXER,name='Speaker Playback Switch'
numid=21,iface=PCM,name='Capture Channel Map'
numid=20,iface=PCM,name='Playback Channel Map'
numid=27,iface=PCM,name='ELD',device=3
numid=52,iface=PCM,name='Playback Channel Map',device=3
numid=33,iface=PCM,name='ELD',device=7
numid=53,iface=PCM,name='Playback Channel Map',device=7
numid=39,iface=PCM,name='ELD',device=8
numid=54,iface=PCM,name='Playback Channel Map',device=8
numid=45,iface=PCM,name='ELD',device=9
numid=55,iface=PCM,name='Playback Channel Map',device=9
numid=51,iface=PCM,name='ELD',device=10
numid=56,iface=PCM,name='Playback Channel Map',device=10

I'll also need amixer -c 0 scontrols.
Do you use pulseaudio in combination with alsa?

@patrick96
amixer -c 0 scontrols
Simple mixer control 'Master',0
Simple mixer control 'Headphone',0
Simple mixer control 'Headphone Mic',0
Simple mixer control 'Headphone Mic Boost',0
Simple mixer control 'Speaker',0
Simple mixer control 'Bass Speaker',0
Simple mixer control 'PCM',0
Simple mixer control 'Front',0
Simple mixer control 'IEC958',0
Simple mixer control 'IEC958',1
Simple mixer control 'IEC958',2
Simple mixer control 'IEC958',3
Simple mixer control 'IEC958',4
Simple mixer control 'Capture',0
Simple mixer control 'Auto-Mute Mode',0
Simple mixer control 'Digital',0
Simple mixer control 'Headset Mic',0
Simple mixer control 'Headset Mic Boost',0
Simple mixer control 'Internal Mic',0
Simple mixer control 'Internal Mic Boost',0

no pulseaudio

If you go into alsamixer and mute a single channel from inside alsamixer, does it mute the others too?

@patrick96 it does

Then this is an alsa issue and not a polybar one. I have only seen this happen on systems that have both alsa and pulse installed, even on my testing system this only happens once I install puleaudio. So please make sure you really don't have pulse installed.
As long as this happens in alsamixer too, it will happen in polybar, so there's nothing polybar can do, so I'm closing this.


Fixed typo

Fixed a typo. In the page it currently shows "ed5519" instead of "ed25519"

Thank you so much for the pull request!
Everything looks good except please remove the file "package-lock.json".

Ah my bad, I usually get gitignore to exclude it

Fantastic!  Thank you!

  Thank you so much!

Done :)

Adam20054, can you do me a favor and github star this repo? Thank you so much!

(For some reason, it does not show.🤔)

Ah my bad, forgot lists are no longer "auto-stared". Sorted :)


NIFI-6322: Introduced EvaluationContext to store state while making evaluator tree reusable

Description of PR
This is a followup PR to #3500 . It enables true re-usage of the evaluator tree once created for a prepared query in nifi's expression language. This, at least in our case, saves a ton of CPU.
This PR also includes a lot of tests for functions with stateful evaluators. This wasn't covered before.
#3500 was closed by me because the approach I took there was not thread safe. Instead of cleaning up the state in evaluators I now introduced a context that gets passed through a tree for each evaluation to get rid of state in the evaluators itself. All evaluators that need state (mostly for performance reasons) can store that state in the context. A new context is created for each evaluation. That should also result in lower garbage collection impact, because we are only throwing away the state that needs to be thrown away not the whole evaluator tree again and again.
Another related pull request is #3277 but that takes a different approach and only helps if no stateful evaluators are used in an expression. It also doesn't cover and + or even though they have state. Even if those will be excluded from optimization, I don't think it's the best approach because there are a ton of expressions (at least in our production scenario) that use functions that have stateful evaluators.
Some profiling tests we did show a performance improvement when compared with the current master (60b5c13ce95fd4d4a5edf0f08b81af19e71b67ee).
This is the test code:
@Test
public void testPerformance() {
    final Map<String, String> attributes = new HashMap<String, String>() {{
        put("hello", "Hello");
        put("boat", "World!");
    }};
    final StandardPreparedQuery prepared = (StandardPreparedQuery) Query.prepare("${allAttributes('hello', 'boat'):isEmpty():not():and(${hello:contains('o')})}");
    for (int i = 0; i < 1000000; i++) {
        assertEquals("true", prepared.evaluateExpressions(attributes, null));
    }
}

CPU Time for the evaluation loop (instrumented code):
current master - 97.48s
this PR - 23.78s
->75% performance improvement
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

 I hope someone gets a chance to review this. This fix should help everyone who uses NiFi productively.

Hey @FrederikP thanks for submitting this! It always makes me very happy when someone digs into the deep end on the framework stuff :) This is definitely a different approach than in PR 3277. I think this has some big benefits over PR 3277, but I think it has a few 'cons' as well.
Basically, I would say that the approaches boil down to:
PR 3277: Try to avoid recreating Evaluators. But if there is an Evaluator that is stateless, recreate them.
This PR: Never recreate Evaluators. Work around the issue of state by externalizing it, so that the evaluator need not be recreated.
The nice thing about this PR is that it actually offers even better performance gain than 3277, especially as you noted around stateful Evaluators.
The main con, though, is that it separates the trivial state that is held by Evaluators from the Evaluators themselves, pushing it into an external HashMap. This leads to more garbage collection (definitely worth the trade-off) but also muddies the API a little bit, resulting in additional 'State' types of classes for the Evaluators, and requiring that the EvaluationContext be pushed down throughout the whole stack.
So it got me thinking - can we accomplish the main goal of this PR - to allow Evaluators never to be recreated, by ensuring that they have fresh 'state' each time, without the need to push down the EvaluationContext and delegate to a map?
So I tried something a little different, that I think takes the best parts of this PR and the best parts of PR 3277 and combines them into one, and posted that as PR 3531 (https://github.com/apache/nifi/pull/3531). Here, it just introduces a new reset() method on the Evaluator and calls that each time that the Expression is to be evaluated. It means that the Evaluator can keep its state as member variables, results in a very small PR that changes little code, is just as fast as this PR, and doesn't change the Evaluator API.
Do you mind taking a look at that PR and see if you agree with it? I do believe it marries up both PR's well.
Also of note, you added some really great unit tests in this PR. I copied & pasted them in to verify that all of the tests pass, but then I removed them because I want to make sure that the code is attributed to you. So if you do agree that PR 3531 is the way to go, I'd appreciate it if you added in those Unit Tests on top, so that they are included and attributed to you.
Thanks again!

Hi @markap14 ,
thanks for your in-depth answer. Actually the approach you are taking in #3531 is pretty similar to what I've done in PR #3500 that I decided to close in the end. I have commented in detail why I did so on that PR, but to summarize:

profiling showed that iterating over the allEvaluators HashSet to reset is pretty expensive, I fixed that later on it that PR
most importantly: this approach works quite well single threaded but it is not thread safe at all!

Thread safety is not (and probably cannot be caught deterministically) in test cases, but we found out by trying out in our test cluster with concurrency enabled.
One thread will call reset and removing the state, while another is in the midst of using the state and NPEs will be thrown or (even worse) logical errors will happen without any exception.
I also think that, while the approach of this PR (#3518 ) is a little bit more complex, state should be separated from the evaluators. I also think that garbage collecting the state is not much worse that garbage collecting after the reset. Performance testing on our side supports that. And for either approach: The developer of a new stateful evaluator needs to be aware that he/she needs to (1) implement clean up or (2) use the EvaluationContext, so there is not much difference there.
My conclusion: I think the approach you take in #3531 is pretty much the same (without some optimizations) that I took in the final version of #3500. And that approach is not thread safe and will lead to NPEs and other issues when used concurrently. I still think this PR (#3518) is the best option of all those PRs.

@FrederikP thanks for the follow-up! And now that I think about it, you are very correct - the thread safety will be an issue here. Evaluators never needed to be thread-safe, so I didn't think about it, but once we start reusing the Evaluators like this, thread safety will be a concern... and of course I'd have figured that out the first time that I tried to actually use it in a fairly complex flow :) Great catch there!
OK, so given that, I am happy to go with this PR after I do some testing, etc. So I will likely have it merged today. The only thing that I would like to change is the name of EvaluationContext, if you are ok with it. I'd rather call it something like EvaluatorState for two reasons: a) The object is intended to store/retrieve state rather than provide a wholistic context around which the function is being applied, and b) I have been working on adding Parameters to NiFi, and in that branch I do actually introduce a new interface called EvaluationContext that replaces the current Map<String, String> attributes in the evaluator, and provides additional context. So when that is merged in, I want to have the EvaluationContext that you introduced renamed to something like EvaluatorState and then have the EvaluationContext wrap that, as well as the Map<String, String> attributes and other things. So if all goes well and I'm able to merge this in, if I've heard no objection from you, then I'll assume your'e ok with it and make that change before merging. Otherwise, please do object if that bothers you :)

@markap14 thanks for the quick answer!
I think renaming it makes sense especially because you are about to introduce a class where the name EvaluationContext is a better fit.
So if I understood you correctly, you are going to perform this change. Let me know if you need me to do something or if you have any more questions about my changes.

@FrederikP yes, I'll make the change and then merge to master, should be in today, I believe. Many thanks for the contribution! The code is great, very clean. Helpful unit tests, great analysis on the problem and the profiling - this will help a lot of users, so many thanks!

All looks good, @FrederikP. I have merged to master. Thanks again!


Add interop test with Cloudflare

It would be good if the CI tests included testing interop with Cloudflare's PQ test server: https://pq.cloudflareresearch.com/

Yup. Do we have contacts at Cloudflare to check whether there is interest to make this reciprocal?

Sure.


Add reliable resource ID generation checking cluster and namespace scopes by querying the Kubernetes discovery API

Fixes #181
This PR fixes a bug on cluster scoped resources, before this PR, we didn't check if the resource was cluster or namespace scoped, and the Resources Id have a part with the NS, by default if no ns was set we used default, so we would have default on all the cluster scoped resources, unless, by error the user set a namespace on the manifest, the apiserver would ignore that, however, kahoy no, so it would use the namespace for the resource ID.
Now we check the types with the apiserver and set default to all the cluster scoped resources besides they have the ns set.

Codecov Report

Merging #182 into master will decrease coverage by 0.35%.
The diff coverage is 78.87%.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   76.65%   76.30%   -0.36%
==========================================
  Files          27       27
  Lines        1221     1262      +41
==========================================
+ Hits          936      963      +27
- Misses        213      223      +10
- Partials       72       76       +4

Impacted Files
Coverage Δ

internal/kubernetes/client.go
0.00% <0.00%> (ø)

internal/storage/fs/factory.go
0.00% <0.00%> (ø)

internal/storage/fs/fs.go
66.36% <50.00%> (-3.37%)
:arrow_down:

internal/storage/kubernetes/kubernetes.go
90.62% <77.77%> (-1.69%)
:arrow_down:

internal/model/resource.go
96.15% <95.23%> (-3.85%)
:arrow_down:

internal/storage/git/factory.go
74.35% <100.00%> (+0.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b89f48...abe23c7. Read the comment docs.