Remove closure-util update from postintall scripts

It's a common trend these days to install packages for the front end via NPM, so this is how I have installed OpenLayers.
However, unfortunately the OpenLayers package forces NPM to install closure with closure-util update as its in the postinstall scripts.
Closure is not necessary for the front end use case and it can cause problems for people who are behind corporate proxies as reported here: https://github.com/openlayers/closure-util/issues/76
I'm looking forward to when #5623 is implemented as I'm sure it will resolve this issue, and also mean that I no longer have to package the whole OpenLayers source code in my application (yes, I am using dist/ol.js).
But in the mean time, is it acceptable to remove the postinstall script and ask developers to run closure-util update manually if they need to?

see discussion in #3157. If you're just using the build in dist/ then you don't need install.js either. closure-util update should be changed, as closure library no longer needs to be updated (see discussion at end of #4128). If this is just for your own use, it might be simpler to just create your own local package for the OpenLayers dist files and not use the NPM one.

But including the .js files manually defeats the point of using a package manger, the reason we'd like these installed via Node is to not have to keep the files locally and for easy updates.  What might be better is to have the .js files deployed via Bower instead.

as an update to this, the Closure lib/compiler has not been updated in closure-util for several months now, so there is no real need for update to be run. However, I'm not sure that removing it from postinstall fixes the problem, does it? closure-util is a dependency of the ol package, so anyone installing that also has to install closure-util, and part of that install is downloading the latest lib/compiler, which will also run into the same proxy issues, right? ISTM the basic issue here is the same as #3157: the ol package is intended for those using the compiler to create custom builds, not for accessing the full builds which are available on cdn.

It is actually possible to compile with OL3 without using closure-util.
We do it in a pilot project, the goal would be there to only depend on the closure-compiler npm package. It would make sense to not call closure-util update in this case in order to prevent downloading the closure library and an extra compiler version.
I will give feedback on this setup as soon as it is tested enough.

I think that only applies if you're compiling app code with OL, right? If you're not doing that and not providing the compiler with goog.provide/require, then you have to provide the compiler with a list of what you want exported. The current build script uses closure-util to do that. That could be changed, but as the longer-term plan is to change to ES6 modules anyway, I'm not sure it makes sense to spend much time on that atm.

It is fine to depend on closure-util and download it together with the other dependencies.
It is small and indeed needed to generate the full/custom builds exports (see tasks/generate-exports.js).
But there is no need to download the closure compiler and library for that (calling closure-util update).

so having the compiler package as an ordinary package.json dependency does not cause the proxy problems caused by closure-util update? If so, I'd agree that would be a good solution.

closure is indeed a very good util for fine level optimization. If someone needs the only js it very simple just download minified from /dist folder . why to change the development settings ? In fact every high end developer who want to optimize and save kb will be happy to see a function that loads only that class you need and not all of it. I am now making it compulsory for my team to use closure compiler.


Atar/better fbs

Reviewers
Functional:
Readability:

Changes

add
remove
modify

I think it would be better to upgrade explorer to use Go happy, since happy push will then build and push images, as is done in data portal here. @ebezzi Any reason we can't upgrade to Go happy in explorer?

I updated the workflow to use the happy go client.


The "@angular/compiler-cli" package was not properly installed.

Bug Report or Feature Request (mark with an x)
- [X ] bug report -> please search issues before submitting
- [ ] feature request

Versions.
λ ng --version
    _                      _                 ____ _     ___
   / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
  / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
 / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
/_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
               |___/
@angular/cli: 1.2.0
node: 8.1.3
os: win32 x64
@angular/common: 4.2.6
@angular/compiler: 4.2.6
@angular/core: 4.2.6
@angular/forms: 4.2.6
@angular/http: 4.2.6
@angular/platform-browser: 4.2.6
@angular/platform-browser-dynamic: 4.2.6
@angular/router: 4.2.6
@angular/cli: 1.2.0
@angular/compiler-cli: error

Repro steps.
Update old project by ncu command
 npm update && ng build --watch true

The log given by the failure.
The "@angular/compiler-cli" package was not properly installed.
Error: The "@angular/compiler-cli" package was not properly installed.
    at Object.<anonymous> (D:\Projects\Gamubs\gamubs-backend\node_modules\@ngtools\webpack\src\index.js:14:11)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (D:\Projects\Gamubs\gamubs-backend\node_modules\@angular\cli\tasks\eject.js:10:19)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)

Mention any other details that might be useful.
package.json :
{
  "name": "project-backend",
  "version": "1.0.0",
  "license": "MIT",
  "scripts": {
    "dev": "concurrently \"ng build --watch true\" \"nodemon server.js\" \"gulp dev\""
  },
  "dependencies": {
    "@angular/common": "^4.2.6",
    "@angular/compiler": "^4.2.6",
    "@angular/core": "^4.2.6",
    "@angular/forms": "^4.2.6",
    "@angular/http": "^4.2.6",
    "@angular/platform-browser": "^4.2.6",
    "@angular/platform-browser-dynamic": "^4.2.6",
    "@angular/router": "^4.2.6",
    "angular2-jwt": "^0.2.3",
    "body-parser": "^1.17.2",
    "concurrently": "^3.5.0",
    "core-js": "^2.4.1",
    "express": "^4.15.3",
    "express-promise": "^0.4.0",
    "fs": "0.0.1-security",
    "gulp": "^3.9.1",
    "gulp-concat": "^2.6.1",
    "jsonwebtoken": "^7.4.1",
    "mongoose": "^4.11.1",
    "mongoose-paginate": "^5.0.3",
    "rxjs": "^5.4.2",
    "zone.js": "^0.8.12"
  },
  "devDependencies": {
    "@angular/cli": "^1.2.0",
    "@angular/compiler-cli": "^4.2.6",
    "@types/jasmine": "2.5.53",
    "@types/node": "~8.0.10",
    "codelyzer": "~3.1.2",
    "jasmine-core": "~2.6.4",
    "jasmine-spec-reporter": "~4.1.1",
    "karma": "~1.7.0",
    "karma-chrome-launcher": "~2.2.0",
    "karma-cli": "~1.0.1",
    "karma-coverage-istanbul-reporter": "^1.3.0",
    "karma-jasmine": "~1.1.0",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.1.2",
    "ts-node": "~3.2.0",
    "typescript": "~2.4.1"
  }
}

I don't know why but after complete remove of node_modules now it's work --",(I have tried 2 times before, and now it's work)


textField Cursor misplaced in TextAlign.center or TextAlign.right

In textField, Cursor is misplaced when text align is TextAlign.center or TextAlign.right (TextAlign.end).

Please, see attach gif.
good.gif

misplace.gif

This has some conditions and results.
Conditions:

textAlign is TextAlign.center or TextAlign.right (TextAlign.end).
Cursor Must comes at the last of each line. (last of column)
Cursor Must NOT comes at the last of lines. (!last of row)
(TextAlign.center || TextAlign.right || TextAlign.end) && Cursor at the last of column && !Cursor at the last of row

Results:
Cursor places at exactly same as textAlign.start or textAlign.left. (It seems like texts are applied align option. But cursor is not.)
Only Cursor is misplaced. Texts are placed well.
TEST CODE
Nothing special
only
TextField( maxLines: null, textAlign: TextAlign.end );
or
TextField( maxLines: null, textAlign: TextAlign.center );
can test this situation.

Hi @kdm7173icomer
Can you please provide your flutter doctor -v your flutter run --verbose and a complete reproducible minimal code sample
Thank you

I made new issue with simple code and doctor -v. please see #62934.


Svelte 4 updates (Part 2)

Closes #813
📑 Description

[x] buttons/Button.svelte:81:0 A11y: svelte:element with click, keydown, keyup, mouseenter, mouseleave handlers must have an ARIA role
[x] dropdowns/DropdownItem.svelte:14:2 A11y: svelte:element with click, keydown, keyup, mouseenter, mouseleave handlers must have an ARIA role
[x] forms/Dropzone.svelte:14:0 A11y: Non-interactive element  should not be assigned mouse or keyboard event listeners.
[x] modals/Modal.svelte:126:8 A11y:  with keydown handler must have an ARIA role
[x] modals/Modal.svelte:91:2 A11y: Non-interactive element  should not be assigned mouse or keyboard event listeners.
[x] navbar/NavLi.svelte:13:2 A11y: svelte:element with click, keydown, keypress, keyup, mouseenter, mouseleave, mouseover handlers must have an ARIA role
[x] navbar/NavUl.svelte:25:2 A11y:  with click handler must have an ARIA role
[x] paginations/PaginationItem.svelte:13:0 A11y: svelte:element with click, keydown, keypress, keyup, mouseenter, mouseleave, mouseover handlers must have an ARIA role
[x] ratings/Star.svelte:10:0 A11y:  with click handler must have an ARIA role
[x] ratings/Thumbup.svelte:9:0 A11y:  with click handler must have an ARIA role
[x] ratings/Heart.svelte:9:0 A11y:  with click handler must have an ARIA role
[ ] tables/TableBodyCell.svelte:12:0 A11y: Non-interactive element  should not be assigned mouse or keyboard event listeners.
[x] utils/ChevronDown.svelte:24:0 A11y:  with click handler must have an ARIA role
[x] utils/ChevronLeft.svelte:24:0 A11y:  with click handler must have an ARIA role
[x] utils/ChevronRight.svelte:24:0 A11y:  with click handler must have an ARIA role
[x] utils/ChevronUp.svelte:24:0 A11y:  with click handler must have an ARIA role
[x] utils/InformationCircle.svelte:24:0 A11y:  with click handler must have an ARIA role
[x] utils/UserCircle.svelte:24:0 A11y:  with click handler must have an ARIA role
[ ] utils/Frame.svelte:84:2 A11y: svelte:element with click, mouseenter, mouseleave handlers must have an ARIA role
[ ] utils/Frame.svelte:99:2 A11y: svelte:element with click, mouseenter, mouseleave handlers must have an ARIA role
[ ] navbar/Menu.svelte:24:0 A11y:  with click handler must have an ARIA role
[x] carousels/Thumbnail.svelte:10:0 A11y: Non-interactive element  should not be assigned mouse or keyboard event listeners.

Status

[x] Not Completed
[ ] Completed

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] I have checked the page with https://validator.unl.edu/
[ ] All the tests have passed
[ ] My pull request is based on the latest commit (not the npm version).

ℹ Additional Information

Since Frame is used in different components, the role will be different depending on the tag.
I just leave it for now.


srl: ipv6 link-local address conflict between parent (srbase) and child (srbase-default) breaks unnumbered bgp

I've hit this issue while trying to test an unnumbered bgp session (ipv6 link local addresses) between two srl containers running 24.7.2 or 23.10.
It can be reproduced with the following minimal setup comprised of a leaf (srl/ixrd2l) and a spine (srl/ixrd3l). Port e1-51 of the leaf is connected to port e1-1 of the spine.
Configuration as in the attached files:
spine.txt
leaf.txt
The BGP session fails to establish, packet capture between the two containers shows that the ICMPv6 RA are correctly exchanged and one side attempt to establish the session. However, the other side replies with both SYN/ACK and RST before any OPEN has been sent which ends up the session prematurely.
11:48:09.367030 1a:98:1f:ff:00:01 > 1a:ed:07:ff:00:33, ethertype IPv6 (0x86dd), length 94: fe80::1898:1fff:feff:1.40955 > fe80::18ed:7ff:feff:33.179: Flags [S], seq<PHONE_NUMBER>, win 16384, options [mss 1024,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 0], length 0
11:48:09.368821 1a:ed:07:ff:00:33 > 1a:98:1f:ff:00:01, ethertype IPv6 (0x86dd), length 94: fe80::18ed:7ff:feff:33.179 > fe80::1898:1fff:feff:1.40955: Flags [S.], seq<PHONE_NUMBER>, ack<PHONE_NUMBER>, win 8896, options [mss 8908,sackOK,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>,nop,wscale 0], length 0
11:48:09.368874 1a:98:1f:ff:00:01 > 1a:ed:07:ff:00:33, ethertype IPv6 (0x86dd), length 74: fe80::1898:1fff:feff:1.40955 > fe80::18ed:7ff:feff:33.179: Flags [R], seq<PHONE_NUMBER>, win 0, length 0
11:48:09.370306 1a:98:1f:ff:00:01 > 1a:ed:07:ff:00:33, ethertype IPv6 (0x86dd), length 86: fe80::1898:1fff:feff:1.40955 > fe80::18ed:7ff:feff:33.179: Flags [.], ack 1, win 16384, options [nop,nop,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>], length 0
11:48:09.370341 1a:98:1f:ff:00:01 > 1a:ed:07:ff:00:33, ethertype IPv6 (0x86dd), length 143: fe80::1898:1fff:feff:1.40955 > fe80::18ed:7ff:feff:33.179: Flags [P.], seq 1:58, ack 1, win 16384, options [nop,nop,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>], length 57: BGP
11:48:09.372008 1a:ed:07:ff:00:33 > 1a:98:1f:ff:00:01, ethertype IPv6 (0x86dd), length 74: fe80::18ed:7ff:feff:33.179 > fe80::1898:1fff:feff:1.40955: Flags [R], seq<PHONE_NUMBER>, win 0, length 0
11:48:09.372036 1a:ed:07:ff:00:33 > 1a:98:1f:ff:00:01, ethertype IPv6 (0x86dd), length 74: fe80::18ed:7ff:feff:33.179 > fe80::1898:1fff:feff:1.40955: Flags [R], seq<PHONE_NUMBER>, win 0, length 0

Additionally, ping on the peer's link-local address reports duplicates:
A:LEAF# ping network-instance default fe80::182f:1fff:feff:1%ethernet-1/51.0
Using network instance default
PING fe80::182f:1fff:feff:1%e1-51.0(fe80::182f:1fff:feff:1%e1-51.0) 56 data bytes
64 bytes from fe80::182f:1fff:feff:1%e1-51.0: icmp_seq=1 ttl=64 time=1.14 ms
64 bytes from fe80::182f:1fff:feff:1%e1-51.0: icmp_seq=1 ttl=64 time=3.17 ms (DUP!)
64 bytes from fe80::182f:1fff:feff:1%e1-51.0: icmp_seq=2 ttl=64 time=1.84 ms
64 bytes from fe80::182f:1fff:feff:1%e1-51.0: icmp_seq=2 ttl=64 time=2.78 ms (DUP!)
64 bytes from fe80::182f:1fff:feff:1%e1-51.0: icmp_seq=3 ttl=64 time=1.81 ms
64 bytes from fe80::182f:1fff:feff:1%e1-51.0: icmp_seq=3 ttl=64 time=2.81 ms (DUP!)

After further investigation i believe this is because the parent interface inside the srbase container has a link-local address enabled, that happens to be the same than the child inside srbase-default. For example:
admin@SPINE:~$ ip netns exec srbase ip a ls dev e1-1
9384: e1-1@if9383: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9232 qdisc noqueue state UP group default
    link/ether 1a:2f:1f:ff:00:01 brd ff:ff:ff:ff:ff:ff link-netnsid 9
    inet6 fe80::182f:1fff:feff:1/64 scope link
       valid_lft forever preferred_lft forever

admin@SPINE:~$ ip netns exec srbase-default ip a ls dev e1-1.0
10: e1-1.0@if29: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
    link/ether 1a:2f:1f:ff:00:01 brd ff:ff:ff:ff:ff:ff link-netns srbase
    inet6 fe80::182f:1fff:feff:1/64 scope link
       valid_lft forever preferred_lft forever

Therefore, the SYN is received inside both containers, srbase rejects it with RST (which causes the issue) and srbase-default accepts it.
To confirm, i ran the following commands, in order to get rid of the link-local address on the parent interface:
admin@LEAF:~$ sudo ip netns exec srbase sysctl net.ipv6.conf.e1-51.disable_ipv6=1

admin@SPINE:~$ sudo ip netns exec srbase sysctl net.ipv6.conf.e1-1.disable_ipv6=1

After this, the BGP session establishes successfully, and ping no longer shows duplicate packets, which confirm the aforementioned assumptions.
As another workaround, using vlan-tagging on the p2p interfaces prevent the issue from happening.

Hi @spoignant-proton
Unfortunately I can't seem to reproduce this issue. I took your config examples and created a self-contained containerlab topology:
name: v6lla

topology:
  nodes:
    leaf1:
      kind: nokia_srlinux
      image: ghcr.io/nokia/srlinux:24.7.2
      startup-config: |
        interface ethernet-1/51 {
            description "To SPINE:e1-1"
            admin-state enable
            subinterface 0 {
                type routed
                ipv6 {
                    admin-state enable
                    router-advertisement {
                        router-role {
                            admin-state enable
                            max-advertisement-interval 120
                            min-advertisement-interval 30
                        }
                    }
                }
            }
        }
        network-instance default {
            admin-state enable
            interface ethernet-1/51.0 {
            }
            protocols {
                bgp {
                    autonomous-system 65001
                    router-id <IP_ADDRESS>
                    dynamic-neighbors {
                        interface ethernet-1/51.0 {
                            peer-group underlay_fabric
                            allowed-peer-as [
                                65004
                            ]
                        }
                    }
                    afi-safi ipv4-unicast {
                        admin-state enable
                        multipath {
                            allow-multiple-as true
                            maximum-paths 8
                        }
                    }
                    afi-safi ipv6-unicast {
                        admin-state disable
                    }
                    group underlay_fabric {
                        admin-state enable
                    }
                }
            }
        }
    spine1:
      kind: nokia_srlinux
      image: ghcr.io/nokia/srlinux:24.7.2
      startup-config: |
        interface ethernet-1/1 {
            description "To Leaf:e1-51"
            admin-state enable
            subinterface 0 {
                type routed
                ipv6 {
                    admin-state enable
                    router-advertisement {
                        router-role {
                            admin-state enable
                            max-advertisement-interval 120
                            min-advertisement-interval 30
                        }
                    }
                }
            }
        }
        network-instance default {
            admin-state enable
            interface ethernet-1/1.0 {
            }
            protocols {
                bgp {
                    admin-state enable
                    autonomous-system 65004
                    router-id <IP_ADDRESS>
                    dynamic-neighbors {
                        interface ethernet-1/1.0 {
                            peer-group underlay_fabric
                            allowed-peer-as [
                                65001
                            ]
                        }
                    }
                    afi-safi ipv4-unicast {
                        admin-state enable
                        multipath {
                            allow-multiple-as true
                            maximum-paths 8
                        }
                    }
                    afi-safi ipv6-unicast {
                        admin-state disable
                    }
                    group underlay_fabric {
                        admin-state enable
                        failure-detection {
                            enable-bfd true
                            fast-failover true
                        }
                    }
                }
            }
        }
  links:
    - endpoints: [leaf1:e1-51, spine1:e1-1]

This topology embeds the configs, so that you should have the nodes boot with the corresponding config bits applied. Once I deployed this topo I see the bgp established just fine:
--{ running }--[  ]--
A:leaf1# show network-instance default protocols bgp neighbor *
-------------------------------------------------------------------------------------------------------------------------------------------------
BGP neighbor summary for network-instance "default"
Flags: S static, D dynamic, L discovered by LLDP, B BFD enabled, - disabled, * slow
-------------------------------------------------------------------------------------------------------------------------------------------------
-------------------------------------------------------------------------------------------------------------------------------------------------
+----------------+-----------------------+----------------+------+---------+-------------+-------------+------------+-----------------------+
|    Net-Inst    |         Peer          |     Group      | Flag | Peer-AS |    State    |   Uptime    |  AFI/SAFI  |    [Rx/Active/Tx]     |
|                |                       |                |  s   |         |             |             |            |                       |
+================+=======================+================+======+=========+=============+=============+============+=======================+
| default        | fe80::187d:1ff:feff:1 | underlay_fabri | D    | 65004   | established | 0d:0h:0m:19 | ipv4-      | [0/0/0]               |
|                | %ethernet-1/51.0      | c              |      |         |             | s           | unicast    |                       |
+----------------+-----------------------+----------------+------+---------+-------------+-------------+------------+-----------------------+
-------------------------------------------------------------------------------------------------------------------------------------------------
Summary:
0 configured neighbors, 0 configured sessions are established, 0 disabled peers
1 dynamic peers

Hi @hellt and thanks for your reply,
That's interesting, because in your case you also have the same MAC address but the LLA are different, with the one on the srbase side derived from a different MAC address. It is my understanding that i'm experiencing the issue because the LLA are the same.
I tried to load a new topology from the file you shared on the same host system, and i observe the same than you:
admin@spine1:~$ ip netns exec srbase ip a ls dev e1-1
10779: e1-1@if10780: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9232 qdisc noqueue state UP group default
    link/ether 1a:b8:01:ff:00:01 brd ff:ff:ff:ff:ff:ff link-netnsid 1
    inet6 fe80::a8c1:abff:fe14:1ab8/64 scope link
       valid_lft forever preferred_lft forever

admin@spine1:~$ ip netns exec srbase-default ip a ls dev e1-1.0
7: e1-1.0@if10: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
    link/ether 1a:b8:01:ff:00:01 brd ff:ff:ff:ff:ff:ff link-netns srbase
    inet6 fe80::18b8:1ff:feff:1/64 scope link
       valid_lft forever preferred_lft forever

So it looks like something in my topology is preventing the LLA from being derived from that different MAC address, but it is not clear why and how i can avoid it. A key difference is that i'm bootstraping the containers with their default config, and load the actual config to be tested only later. This is because my config files are too big to be loaded using the startup-config node attribute.
I'll make further tests to try to narrow this further down.

i think we will pause this because we are under heavy time pressures to complete additional testing for a new deployment imminently.
if you dont mind leaving this open a few weeks, we can come back to the deep dive, for now, we have a workaround that works well enough

So the way the configuration is loaded (either directly using startup-config, or by our own means after the container is created to overcome size limit) is unrelated with this issue. As it turned out, the issue is triggered by having device creation ordering rules, for example if we want to start leaves only after spines have been created and configured.
The following is a reproducing topology:
name: v6lla

topology:
  nodes:
    leaf1:
      kind: nokia_srlinux
      image: ghcr.io/nokia/srlinux:24.7.2
      stages:
        create:
          wait-for:
            - node: spine1
              stage: configure
      startup-config: leaf1.txt
    spine1:
      kind: nokia_srlinux
      image: ghcr.io/nokia/srlinux:24.7.2
      startup-config: spine1.txt
  links:
    - endpoints: [leaf1:e1-51, spine1:e1-1]

leaf1.txt
spine1.txt
Results:
A:spine1# show network-instance default protocols bgp neighbor
---------------------------------------------------------------------------------------------
BGP neighbor summary for network-instance "default"
Flags: S static, D dynamic, L discovered by LLDP, B BFD enabled, - disabled, * slow
---------------------------------------------------------------------------------------------
---------------------------------------------------------------------------------------------
+---------+---------+---------+---------+---------+---------+---------+---------+---------+
|  Net-   |  Peer   |  Group  |  Flags  | Peer-AS |  State  | Uptime  | AFI/SAF | [Rx/Act |
|  Inst   |         |         |         |         |         |         |    I    | ive/Tx] |
+=========+=========+=========+=========+=========+=========+=========+=========+=========+
| default | fe80::1 | underla | D       |         | active  | -       |         |         |
|         | 84f:ff: | y_fabri |         |         |         |         |         |         |
|         | feff:33 | c       |         |         |         |         |         |         |
|         | %ethern |         |         |         |         |         |         |         |
|         | et-     |         |         |         |         |         |         |         |
|         | 1/1.0   |         |         |         |         |         |         |         |
+---------+---------+---------+---------+---------+---------+---------+---------+---------+
---------------------------------------------------------------------------------------------
Summary:
0 configured neighbors, 0 configured sessions are established, 0 disabled peers
1 dynamic peers

admin@spine1:~$ ip netns exec srbase ip a ls dev e1-1
10874: e1-1@if10873: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 9232 qdisc noqueue state UP group default
    link/ether 1a:53:01:ff:00:01 brd ff:ff:ff:ff:ff:ff link-netnsid 4
    inet6 fe80::1853:1ff:feff:1/64 scope link
       valid_lft forever preferred_lft forever

admin@spine1:~$ ip netns exec srbase-default ip a ls dev e1-1.0
7: e1-1.0@if10: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
    link/ether 1a:53:01:ff:00:01 brd ff:ff:ff:ff:ff:ff link-netns srbase
    inet6 fe80::1853:1ff:feff:1/64 scope link
       valid_lft forever preferred_lft forever

The issue no longer happens if the create section is removed from the leaf1 node definition.

FYI i'm using the latest clab version:
    version: 0.59.0
     commit: 9e964727
       date: 2024-10-23T02:44:27Z
     source: https://github.com/srl-labs/containerlab
 rel. notes: https://containerlab.dev/rn/0.59/

I can imagine how doing the delayed start between the nodes that share the same link might cause some issues.
Do you need this stage after all? Can you live without it? Stages work best when you either delay creation of nodes that do not connect one with another (like islands of your topology) or if they do not share the same link segment, like connecting over a bridge.

Its to manage the delivery of the topology inside a nominal host. our full topology is like 50 nodes and even with a decent sized host, it gets very sad during the initial standup because the cpus are murdered with all the provisioning.
stages allow to break up the startup hit, when the running topology sits happily inside the hardware we have on hand

Stages were also meant to have certain parts of the network start before others, e.g. have a ready core layer before starting fabrics. I've tried removing those and replacing with --max-workers N to reduce the cpu stress when starting the topology. It is not obvious to me why it should not be used in the first place. Eventually if a device must start at the same time than all other devices that it is connected to, inside our relatively complex topology that amount to say all device must start at the same time, and by reducing concurrency we may hit the same issue again.

As expected, after removing the stages section from all srl nodes, with --max-workers 4, i'm still hitting the issue:
admin@SPINE01:~$ ip netns exec srbase ip a ls dev e1-1
38: e1-1@if37: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 8986 qdisc noqueue state UP group default
    link/ether 1a:83:1f:ff:00:01 brd ff:ff:ff:ff:ff:ff link-netnsid 5
    inet6 fe80::1883:1fff:feff:1/64 scope link
       valid_lft forever preferred_lft forever

admin@SPINE01:~$ ip netns exec srbase-default ip a ls dev e1-1.0
4: e1-1.0@if8: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 8968 qdisc noqueue state UP group default qlen 1000
    link/ether 1a:83:1f:ff:00:01 brd ff:ff:ff:ff:ff:ff link-netns srbase
    inet <IP_ADDRESS>/32 brd <IP_ADDRESS> scope global e1-1.0
       valid_lft forever preferred_lft forever
    inet6 fe80::1883:1fff:feff:1/64 scope link
       valid_lft forever preferred_lft forever


feat(try-it-out): add more details to inline error messages

Round 2 without console errors:

Loom demo
Would love to see one with multiple errors but not sure how that'd play out.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/alert_role
I think this would be a good use case for the alert role, in which once it comes up the screen reader should pick it up.  Currently when the error comes up, it reads the first span and appends '...and 2 more items' - wondering if role="text" on the spans would fix that up, or if we can use one p tag instead?

Tested locally, LGTM. Made a slight adjustment to make it work nicely with voiceover.


[BEAM-986] Improve ReduceFnRunner prefetching

Hi @kennknowles , can you please take a look?
This refactoring ensures that for batches of elements or timers we have at most 2 fetches, one to prefetch the should fire bits and one to fetch the actual firing state.  The current behavior can end up with 2 fetches per window triggered.

The test failure looks unrelated to me and it passes locally for me. Is that a known flaky test or should I take a closer look?

Yea, not worried about the Travis failure. But Jenkins did not run, probably due to some transient infrastructure issue. Can you rebase and force push to the branch? That will kick Jenkins again.

Fixed some checkstyle issues

I think one of the reasons we didn't do this was concern about the potential memory impact -- doing a window at a time means we don't need all the state for all the windows to fit in memory at once. Have we measured that (1) this necessary and (2) this isn't going to cause additional memory pressure?

I have observed up to a 15% improvement in a nexmark benchmark where we
receive bundles of 10 timers at a time etc and without this we end up doing
10 serial get data requests for the key.
I think that memory impact is bounded since only prefetch up to 1MB from
each tag list and paginate the rest upon demand and thus doesn't seem like
to large a concern (or at least not any more than many timers firing for
many different keys at the same time).
On Tue, Nov 22, 2016 at 12:43 PM, Ben Chambers<EMAIL_ADDRESS>wrote:

I think one of the reasons we didn't do this was concern about the
potential memory impact -- doing a window at a time means we don't need all
the state for all the windows to fit in memory at once. Have we measured
that (1) this necessary and (2) this isn't going to cause additional memory
pressure?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-beam/pull/1366#issuecomment-262360122,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEOczMstsojUnUQD6tAYuaHYarSFAcGxks5rA1QHgaJpZM4KzJ0U
.

Noting that the build is actually "green" and the failure is unrelated issue in the apex runner dependencies. If you rebase atop recent changes it should clear up.

I'm running a performance test to make sure things still look good with the updated PR

LGTM and merging.


zinc cliques

In the context of the question "what treats common cold", we are getting back several related concepts around zinc.  There's Zinc, Zinc Lozenge, Zinc Gluconate, and Zinc Gluconate Lozenge.
Zinc Gluconate actually merges with its Lozenge in dev.
But Zinc Lozenge (UMLS:C1248424) doesn't seem to link to anything in UMLS or RXNORM.  So I'm not sure how we are going to handle this.  Do we need to just hand map it?
Also, zinc merges with zinc methionine, why doesn't it merge with zinc gluconate?

Part of the reason may be that in RxNorm, zinc methionine is a precise ingredient (PIN) with an ingredient of Zinc. But zinc gluconate is an ingredient itself.  There is a PIN but that is a more specific thing "zinc gluconate trihydrate".  So RxNorm doesn't have any kind of link from Zinc Gluconate to Zinc...

This may be pointing at the difficulty on relying on rxnorm for this kind of conflation.   It would also be very tricky to be based on deconstructing the salt smiles though because using a size way of figuring out what is the important part of the compound would end up merging zinc gluconate with gluconate, not zinc.


[Update]: Smart converter text area problem solved

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #1034
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?
Locally
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Screenshots or example output

@AbhiPatel10 , Please resolve the merge conflict.

@AbhiPatel10 , Please resolve the merge conflict.

Done


Broken link on hamler-lang.org home page

The link for "Basic Types, Functions and Operators" to github doc guide
has a spelling typo "...Fucntions..."  so it 404s.

https://github.com/hamler-lang/hamler.github.io/pull/41
Hey, thank you for pointing this out. It is now fixed.


data:harisdev

Changes proposed
Adding a profile to the LinkFree account
Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Note to reviewers
Thank you, for letting me create a profile on LinkFree.

Please change your json file so that this matches your GitHub username exactly:
from data/harisdev.json to data/harisdev-netizen.json

@SaraJaoude can you please guide me with changing my source json file?

@SaraJaoude can you please guide me with changing my source json file?

Here are a few screenshots that I hope help:
In Files Changed click on the three dots ... and then Edit

Change the current name from data/harisdev.json to data/harisdev-netizen.json

Scroll down and commit the changes to main

Thank you @SaraJaoude for the heads up. Did as you meantioned.

@SaraJaoude I have a question. I want to make few changes to my LinkFree, so after I am done doing changes should I create new branch or just commit directory to the main? I hope I'm not bothering you.

Hey @harisdev-netizen, it's always recommended to commit the changes into a new branch to avoid conflicts.
For a proper guide on editing your profile, you can check out these docs: https://linkfree.io/docs/how-to-guides/editing

Hey @harisdev-netizen, it's always recommended to commit the changes into a new branch to avoid conflicts.
For a proper guide on editing your profile, you can check out these docs: https://linkfree.io/docs/how-to-guides/editing

Understood and followed as mentioned in the docs but I am not able to find the harisdev-netizen.json I created. And the LinkFree > data shows Sorry, we had to truncate this directory to 1,000 files. 763 entries were omitted from the list.

It's because GitHub UI can only show 1000 files in a directory. You can find your File using the button Go to file  > Type your filename.
Here is the direct link to your file: https://github.com/EddieHubCommunity/LinkFree/blob/main/data/harisdev-netizen.json


[Snyk] Security upgrade python from 3.11.0 to 3.12.0

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

Dockerfile

We recommend upgrading to python:3.12.0, as this image has only 171 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

721
Out-of-bounds Write SNYK-DEBIAN11-GLIBC-5927133
Proof of Concept

829
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

829
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

829
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

829
Out-of-bounds Write SNYK-DEBIAN11-LIBWEBP-5893094
Mature

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Automatically generated patch by dependabot, denied.


Use gitlab v4 api

We should use version 4 of gitlab api. The api v3 will be removed in a future version later this year.

Rebased branch too from latest changes from master.


add a reference link for each tuner in the tuner overview page

The modification may look like below:

done. closed


install only the latest patch version of .net core

To comply with the guidelines https://github.com/gonchalo620/virtual-environments/blob/main/README.md#software-guidelines, the Install-DotnetSDK.ps1 script was modified so that it only installs the latest patch version of each major.minor version of .net core
Description
Improvement
To comply with the guidelines https://github.com/gonchalo620/virtual-environments/blob/main/README.md#software-guidelines in which it is mentioned that only the latest version of each major.secondary version will be installed. Therefore, the Install-DotnetSDK.ps1 script was modified so that it only installs the latest patch version of each major.minor version of .net core.

Currently the script is scheduled to install all patch versions other than preview/rc releases. Therefore it installs older versions, which contain uncorrected detected vulnerabilities.

Hello @gonchalo620 , thank you for contribution but I think the current installation process is fully compliant with our policy.
Our policy - For each feature version only latest patch is installed. It is not equal to only the latest version of each major.secondary version will be installed for .NET Core.
According to .NET Core documentation feature version is x.y.z* (major + minor + first digit of patch version):

the .NET SDK uses the concept of feature bands. For example, the first .NET 5 SDK was 5.0.100. This release corresponds to the 3.1.1xx feature band. Feature bands are defined in the hundreds groups in the third section of the version number. For example, 5.0.101 and 5.0.201 are versions in two different feature bands while 5.0.101 and 5.0.199 are in the same feature band. When .NET SDK 5.0.101 is installed, .NET SDK 5.1.100 is removed from the machine if it exists. When .NET SDK 5.0.200 is installed on the same machine, .NET SDK 5.0.101 isn't removed.

So I think we follow .NET Core versioning process correctly.


Start Menu tile color should be customized

Description of the new feature/enhancement

Windows Terminal's Start Menu tile uses whichever color the OS theme is using.  Maybe it can have a nice custom color?
Proposed technical implementation details (optional)

Perhaps a Campbell Blue, or a more universal Sysadmin Black?

IF an option to change the Tile colour is added, there should be a way to keep it Transparent.
The tile colour setting would have to be per-app, and not linked to profiles.

Please note that I'm not suggesting a "customizable" tile, but one which does not use the OS theme color ("customized").

Please note that I'm not suggesting a "customizable" tile, but one which does not use the OS theme color ("customized" by the Terminal developers).

That is what I read into your request, I just like to be able to use my Accent Colour for the tiles, and would not want it to change, without the ability to "undo" that change. 😃

For the record, I believe you may have stumbled into a holy war.
I'm not saying this as a designer or as someone with any UX expertise, but I'm not sure there is a consistent pattern here, either having a color or not. @cinnamon-msft might be able to hook us up with someone who does know.

Hey I'm gonna go out on a limb - with the changes to the Start Menu in recent insider's builds, maybe we shouldn't bother with this?

Agreed.


Prepare to run an OpenShift Traction Load Test

Create Sandbox Traction tenants for an issuer and a verifier, configure them as per the Aries Akrida "Quickstart", and adjust the environment (.env) configuration to point to those instances, and the OpenShift "dev" mediator.  Run low load tests to show that the environment is operational.
A guide for setting up a Sandbox Traction tenant is available here.
Request access to the dev mediator from @WadeBarnes.
This is the second step of the load test generator plan discussed in a meeting 2023.12.18, and summarized in this presentation.

Delivered a mediator invite to @Gavinok

As of now locustMediatorIssue.py, locustMediatorPing.py, and locustMediatorMsg.py are working. locustMediatorPresentProof.py on the other hand routinely fails during the presentation_exchange step with the error
Exception('Request was not successful: ', b'400: Record not found: connection/fc302da8-a400-4315-905b-399a7f6a523b.')

Completed — able to get to over 200/issuances per minute.


ERROR: failed building service 'web': failing invoking action 'build', building container: web at .: building image: exit code: 1, stdout: , stderr: ERROR: failed to solve: executor failed running [/bin/sh -c npm run build]: exit code: 1[Issue]

[ ] Make sure you've installed the latest version using instructions in the wiki

Output from azd version
Run azd version and copy and paste the output here:
Describe the bug
Description of issue you're seeing...
Deploying service api (Updating container app revision)
Deploying service api (Fetching endpoints for container app service)
- Endpoint: https://ca-api-4a73yskoiju2e.mangoisland-1cce6bd6.eastus.azurecontainerapps.io/

Deploying service web
Deploying service web (Building Docker image)

ERROR: failed building service 'web': failing invoking action 'build', building container: web at .: building image: exit code: 1, stdout: , stderr: ERROR: failed to solve: executor failed running [/bin/sh -c npm run build]: exit code: 1

Error: Process completed with exit code 1.
##[debug]Finishing: Deploy Application
To Reproduce
Steps to reproduce the behavior...
git clone and try to azd up (or do it via azure portal)
Expected behavior
A clear and concise description of what you expected to happen.
i expected it to deploy okay - i thought it might be because of some changes i had made

i checked line endings which were incorrectly clrf rather than lf
i also tried removing file changes and repushing original code

Perhaps i need to update FROM node:16.13-alpine AS build in the Dockerfile or perhaps update the package.json?
Environment
Information on your environment:
* Language name and version
* IDE and version : [e.g. Visual Studio 16.3]
Additional context
Add any other context about the problem here.

had some errors in my docker build - resolved


Add support for Font Awesome

Need to decide how this should fit in with Bootstrap icons. Should they be added to the Bootstrap icon enum in the base library (with a prefix perhaps). Or maybe an additional extension library with a separate enum and extra extensions for every method that takes an icon.

I have just publish two nuget packages which can help you :
https://www.nuget.org/packages/FluentFontAwesome/
https://www.nuget.org/packages/FluentFontAwesome.Mvc/


Prevent additional queries on qualifications

Context
ApplicationForm#qualification_in_subject is being called multiple times per row of data when exporting applications.
This happens because we iterate over relevant gcse subjects in order to present a summary. We've already included associated :application_qualifications in the main data export query, so this commit avoids additional queries to re-retrieve gcse and degree qualifications and uses Ruby instead to collate the relevant information.
For a single row of data we were making an additional query to find the 'first' degree and 3 more queries to find gcses
of various subjects.

Changes proposed in this pull request
Use Ruby to determine the first degree by date and gcses of relevant subjects.

Guidance to review
These 4 queries are currently run per row for an applications export, the HESA export only uses first_degree so it still has an n+1 issue which is addressed by this PR.
ApplicationQualification Load (0.9ms)  SELECT "application_qualifications".* FROM "application_qualifications" WHERE "application_qualifications"."application_form_id" = $1 AND "application_qualifications"."level" = $2 AND "application_qualifications"."subject" = $3 ORDER BY "application_qualifications"."created_at" ASC LIMIT $4  [["application_form_id", 397], ["level", "gcse"], ["subject", "maths"], ["LIMIT", 1]]
↳ app/models/application_form.rb:141:in `qualification_in_subject'
ApplicationQualification Load (2.4ms)  SELECT "application_qualifications".* FROM "application_qualifications" WHERE "application_qualifications"."application_form_id" = $1 AND "application_qualifications"."level" = $2 AND "application_qualifications"."subject" = $3 ORDER BY "application_qualifications"."created_at" ASC LIMIT $4  [["application_form_id", 397], ["level", "gcse"], ["subject", "english"], ["LIMIT", 1]]
↳ app/models/application_form.rb:141:in `qualification_in_subject'
ApplicationQualification Load (1.2ms)  SELECT "application_qualifications".* FROM "application_qualifications" WHERE "application_qualifications"."application_form_id" = $1 AND "application_qualifications"."level" = $2 AND "application_qualifications"."subject" IN ($3, $4, $5, $6) ORDER BY "application_qualifications"."created_at" ASC LIMIT $7  [["application_form_id", 397], ["level", "gcse"], ["subject", "science"], ["subject", "science single award"], ["subject", "science double award"], ["subject", "science triple award"], ["LIMIT", 1]]
↳ app/models/application_form.rb:141:in `qualification_in_subject'
ApplicationQualification Load (0.9ms)  SELECT "application_qualifications".* FROM "application_qualifications" WHERE "application_qualifications"."application_form_id" = $1 AND "application_qualifications"."level" = $2 ORDER BY "application_qualifications"."created_at" ASC LIMIT $3  [["application_form_id", 399], ["level", "degree"], ["LIMIT", 1]]
↳ app/decorators/application_choice_export_decorator.rb:30:in `first_degree'

This PR should prevent that.
There should be no changes to CSV output from this commit.

Link to Trello card
https://trello.com/c/nPjLMPC1/4048-spike-investigate-performance-of-data-exports-in-manage

Things to check

[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] Required environment variables have been updated added to the Azure KeyVault

I think the branch name containing a + symbol is causing problems with docker. Will fix.

Closing as the + in branch name causes build issues, see https://github.com/DFE-Digital/apply-for-teacher-training/pull/5453 for merged PR details


portfolio section

hi,
love your theme!
can you also add a portfolio section which can have multiple modal popups. kind of like "past work"  or "previous portfolio"
thanks!

Some thing like a carrousel ?

or something like the projects area in http://themes.gohugo.io/theme/creative/
P.S may I also highlight https://github.com/crakjie/landing-page-hugo/issues/19 (like http://themes.gohugo.io/theme/hugo-universal-theme/blog)
sorry for this - your theme is the best i have found!!!


How to view two pages in landscape orientation?

Is there is a way to view two pages in landscape orientation ?

We can do it with viewFraction. But it is not good as I want.
Anyway, 3 pages in landscape mode work very well with viewFaction: 1/3


Handle actions for different target TM_MADs

Description
Following this discussion. We've decided that better way to implement cross datastore transfer actions is to add check for action.<TM_MAD> file in the source tm driver directory. Where TM_MAD is destination datastore variable.
Use case
This change will allow to implement actions to transfer volumes between datastores with different TM_MADs. eg. copy images from shared to fs_lvm and from ceph to shared datastores and etc.
Interface Changes
If source datastore have TM_MAD=ssh, destination datastore TM_MAD=fs_lvm and user started clone operation. tm_mad.rb should check is tm/ssh/clone.fs_lvm file exist  (it might be symlink), and call it instead standard one. If not exist, then call standard action tm/ssh/clone.
The same goes for all other tm actions and drivers.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

PRs:
one: https://github.com/OpenNebula/one/pull/3574
infra: https://github.com/OpenNebula/infra/pull/303
docs: https://github.com/OpenNebula/docs/pull/716
all to master

@xorel will it also work for cpds mvds actions?

Yes, should work for every TM action if the action script exists.
On Tue, Aug 6, 2019 at 3:35 PM kvaps<EMAIL_ADDRESS>wrote:

@xorel https://github.com/xorel will it also work for cpds mvds actions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/OpenNebula/one/issues/3244?email_source=notifications&email_token=AAIMEBS4GPN3GCJBMVLACG3QDF43DA5CNFSM4HGT7KSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VE6CI#issuecomment-518672137,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIMEBVZY3UUHEMAFBYUV4DQDF43DANCNFSM4HGT7KSA
.

--
OpenNebula - Flexible Enterprise Cloud Made Simple
--
Jan Orel
Cloud Engineer at OpenNebula Systems
OpenNebula.Systems | @OpenNebula
--
Confidentiality Warning: The information contained in this e-mail and
any accompanying documents, unless otherwise expressly indicated, is
confidential and privileged, and is intended solely for the person
and/or entity to whom it is addressed (i.e. those identified in the
"To" and "cc" box). They are the property of OpenNebula.Systems S.L..
Unauthorized distribution, review, use, disclosure, or copying of this
communication, or any part thereof, is strictly prohibited and may be
unlawful. If you have received this e-mail in error, please notify us
immediately by e-mail at<EMAIL_ADDRESS>and delete the
e-mail and attachments and any copy from your system. OpenNebula's
thanks you for your cooperation.

Every thing is now merged in master, closing...


nicer way to report errors during init?

When running bref init, the process exited immediately and with a not-particularly-helpful exception message (The process has been signaled with signal "6".) coming from symfony/process.
I had to re-run with -v to find out where it was going wrong (the AWS configure step), and then try running the command myself just to see what's happening.
It might be nicer if we can catch some of these and give the information back to the user in a friendlier way
➜  bref-function$ vendor/bin/bref init

In Process.php line 426:

  The process has been signaled with signal "6".

init

➜  bref-function$ vendor/bin/bref init -v

In Process.php line 426:

  [Symfony\Component\Process\Exception\ProcessSignaledException]
  The process has been signaled with signal "6".

Exception trace:
 () at /Users/neal/Projects/bref-function/vendor/symfony/process/Process.php:426
 Symfony\Component\Process\Process->wait() at /Users/neal/Projects/bref-function/vendor/symfony/process/Process.php:235
 Symfony\Component\Process\Process->run() at /Users/neal/Projects/bref-function/vendor/mnapoli/bref/bref:39
 Silly\Application->{closure}() at n/a:n/a
 call_user_func_array() at /Users/neal/Projects/bref-function/vendor/php-di/invoker/src/Invoker.php:82
 Invoker\Invoker->call() at /Users/neal/Projects/bref-function/vendor/mnapoli/silly/src/Application.php:95
 Silly\Application->Silly\{closure}() at /Users/neal/Projects/bref-function/vendor/symfony/console/Command/Command.php:253
 Symfony\Component\Console\Command\Command->run() at /Users/neal/Projects/bref-function/vendor/symfony/console/Application.php:908
 Symfony\Component\Console\Application->doRunCommand() at /Users/neal/Projects/bref-function/vendor/symfony/console/Application.php:269
 Symfony\Component\Console\Application->doRun() at /Users/neal/Projects/bref-function/vendor/symfony/console/Application.php:145
 Symfony\Component\Console\Application->run() at /Users/neal/Projects/bref-function/vendor/mnapoli/bref/bref:160

init

➜  bref-function$ aws configure
dyld: Library not loaded: @executable_path/../.Python
  Referenced from: /usr/local/aws/bin/python2.7
  Reason: image not found
[1]    44135 abort      aws configure

:+1:
By the way is the aws configure error caused by something we should fix as well?

nope, that was caused by a broken python install!

Fixed by #323


make location of output of SuperBuild consistent

some projects (probably CMake-ones) have their build in x-prefix/src/x-build as opposed to x-build.
Also, INSTALL is currently hard-wired but should honour CMAKE_INSTALL_PREFIX.

indeed the default location for external projects is

If no PREFIX, EP_PREFIX, or EP_BASE is specified then the default is to set PREFIX to -prefix. Relative paths are interpreted with respect to the build directory corresponding to the source directory in which ExternalProject_Add is invoked.

TMP_DIR      = /tmp
STAMP_DIR    = /src/-stamp
DOWNLOAD_DIR = /src
SOURCE_DIR   = /src/
BINARY_DIR   = /src/-build
INSTALL_DIR  =
So far we only force the source directory to be  and contained in the build directory.
A better option IMO would be to have:
devel/
         -> sources
         -> builds
         -> install

https://cmake.org/cmake/help/v3.7/module/ExternalProject.html?highlight=EP_BASE

yes. This not a bad idea. It will be potentially somewhat confusing/dangerous though to have the superbuild build in
devel/builds/SIRG-SuperBuild

but writes its sources in
devel/sources/SIRF

etc. We certainly cannot have that by default in the SuperBuild. We could have a new CMake variable SRC_INSTALL_DIR ? Then on the VM or Docker we can set that according to your suggestion.
I also agree with your install suggestion, but again we can't have that by default in the SuperBulid. Let's fix this as in the VM. https://github.com/CCPPETMR/CCPPETMR_VM/issues/35
By the way, there is some confusion between all these ExternalProject_Add variables as some of them are used when using git, while others are used for the download-binaries, and others are used for the download-source cases (or at least I think so, as that's why there is currently a difference between e.g. SIRF and HDF5.
I'd be happy to just fix this for the git ones for now. we can fit the rest later.

On VM, target will be something like
devel/SuperBuildFiles
         -> sources
         -> builds
devel/install

I believe this is already implemented.

not really done. Example: SIRF source sits in the root-dir, but its actual build sit in SIRF-prefix/src/SIRF-build (not very logical). For non-CMake packages, this is different again.

with https://github.com/CCPPETMR/SIRF-SuperBuild/commit/f255b459fafab9d304df225c77db2a68c75b5855 I have set the build directories as proposed
I have a problem about ctest which picks the wrong data directory.

I've seen somewhere in the doc a reference to where the examples are etc, but I cannot find it anymore. In any case, this should be somehwere rather promiment. It's going to change with this PR, so put it in the README.md I think.

On Windows I use binary downloads for SWIG and FFTW. I notice that these get put in e.g.
build/SWIG-prefix/src/swigwin-3.0.12.zip and extracted into build/SWIG-prefix/src/SWIG. Arguably the zip file should go into downloads, and the extracted binaries into builds or also downloads (In prniciple, they could be extracted directly in the install location, but I don't think we can do that an dI don't really care).
Note also that currently downloads contains e.g. SIRF, STIR etc empty subdirs. That doesn't really bother me either.

sorry. could you please assign somebody else, pr be preated to wait :-;

Who else is installing on Windows?

@evgueni-ovtchinnikov, you're not using the superbuild yet, but this would be good to try. Not urgent though


[react/prop-types][react/no-unused-prop-types] ignores props in function of element inside jsx attributes

Here how ide highligts errors

Code
import React from 'react'

export const Foo = (props) => (

 props.bar(props.baz)}
    />
)

export const Hello = (props) => {
    return (

        )}>

 props.quoz()}/>

    )
}

I also get the same issue which looks to be related:
type Option =
    {|
        value: string;
        id: string;
    |}

type PropType =
    {|
        someText: string;
        someMoreText: string;
        options: Option[];
    |}

const Component = (props: PropType) => (

        { props.someText }
        { props.options.map(({ value, id }) =>
            {value}
            {props.someMoreText}
        }

)

eslint will raise an error for the values destructured by mapping over options and for props.someMoreText.
Destructuring props resolves the issue. Although it's not idea as I like to make the source of values transparent.

@umidbekkarimov can you provide command line output? How your IDE highlights things is an issue with your IDE; only the command line is important here.
@alex-deas I believe there might already be an open issue specifically around nested flow types, and another around prop usage inside callbacks.

@ljharb oh, guess it fixed already, can not reproduce it


Question regarding changes to text before callback is called

Describe the bug
Hi :wave: I was trying to build a plugin that would autocomplete packages within a programming language's dependency spec file (Dart's pubspec.yaml file to be specific). As the user types I would like to be able to queue a request to the search API and then populate items back to cmp. I wanted to do this asynchronously and also be able only query the API after the user has paused typing. The problem is that it seems like cpm expects the custom source to always call the callback before new calls to the defined complete function gets called again.
Minimal config based on this
if has('vim_starting')
  set encoding=utf-8
endif
scriptencoding utf-8

if &compatible
  set nocompatible
endif

let s:plug_dir = expand('/tmp/plugged/vim-plug')
if !filereadable(s:plug_dir .. '/plug.vim')
  execute printf('!curl -fLo %s/autoload/plug.vim --create-dirs https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim', s:plug_dir)
end

execute 'set runtimepath+=' . s:plug_dir
call plug#begin(s:plug_dir)
Plug 'hrsh7th/nvim-cmp'
Plug 'hrsh7th/cmp-buffer'
Plug 'hrsh7th/cmp-nvim-lsp'
Plug 'hrsh7th/vim-vsnip'
Plug 'neovim/nvim-lspconfig'
call plug#end()
PlugInstall | quit

" Setup global configuration. More on configuration below.
lua << EOF
local cmp = require "cmp"

local source = {}
source.new = function()
    local self = setmetatable({}, { __index = source })
    return self
end

source.is_available = function()
    return true
end

function source.get_debug_name()
    return 'test'
end

function source.resolve(self, completion_item, callback)
    callback(completion_item)
end

function source.execute(self, completion_item, callback)
    callback(completion_item)
end

function source.get_trigger_characters(self, config)
    return {'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', '_'}
end

function source.complete(self, params, callback)

    local cur_line = params.context.cursor_line
    local items = {}

    -- Look for the first word in the line
    name = cur_line:match('([%w_]+)(.*)')
    -- I'm using vim.defer_fn here as a placeholder for my async code that uses a timer.
    vim.defer_fn(function()
      print(name)
      table.insert(items, {label = name})
      callback(items)
      end, 2000)
end

cmp.register_source('test', source.new())

cmp.setup {
  snippet = {
    expand = function(args)
      vim.fn["vsnip#anonymous"](args.body)
    end,
  },

  mapping = {
    ['<CR>'] = cmp.mapping.confirm({ select = true })
  },

  sources = {
    { name = "test" },
    { name = "nvim_lsp" },
    { name = "buffer" },
  },
}
EOF

lua << EOF
local capabilities = require('cmp_nvim_lsp').update_capabilities(vim.lsp.protocol.make_client_capabilities())

require'lspconfig'.cssls.setup {
  capabilities = capabilities,
}
EOF

To Reproduce

User types r on a new line
My source parses the line and finds the new text
My source starts a timer that will run a curl request to the API after a duration (2 seconds)
The user types edux rapidly after the r (complete word is "redux")
My source has no way to know that new text was added since it hasn't called the callback with items yet

Right now, it seems like my source doesn't get a call to complete related to the edux text unless I call the callback.
Expected behavior

User types r on a new line
My source parses the line and finds the new text
My source starts a timer that will run a curl request to the API after a duration (2 seconds)
The user types edux rapidly after the r (complete word is "redux")
My source stops the timer
My source creates a new timer that will run the curl request after 2 seconds
The timer finishes, I make the request, I parse the response into items, I call the callback with the items

I would like to be able to receive a call to complete for my trigger characters even if I have a pending call to complete or some other way to be notified that new text was added so I can update the call I need to make. This would allow me to call the previous callback with nil so I can re-create my timer.
Additional context
I really appreciate all the hard work you've put into this and totally understand if this functionality isn't something you want to support. I just wanted to try to build something cool, but maybe this functionality is better to keep out of cmp. Thanks for your consideration.

It should be supported.

Do you have any initial thoughts on how this would be implemented? I'd be happy to put a pull request together. I'm a little concerned that this part of my comment might be a breaking change:

I would like to be able to receive a call to complete for my trigger characters even if I have a pending call to complete...

So maybe it would be better to come up with a new way to notify sources? I'll do some more reading in the nvim-cmp code and see if I can think of anything. Thanks!

The change in this PR seems to give me the behavior that I want but it's possible other sources are not expecting multiple calls to complete. You also probably left SourceStatus.FETCHING out of that call on purpose. I just wanted to demonstrate the behavior I was looking for.
https://github.com/hrsh7th/nvim-cmp/pull/450/commits/c889921db990cdafb2a78371af245a975c9741a0

I've pushed the improvements of isIncomplete=true handling.
You can specify callback({ isIncomplete = true, items = ... }).
nvim-cmp will check cursor moved after getting callback so your plugin get called again with latest current line state.

I pulled latest main and this does seem to work. Should my completion source ever pass {isIncomplete = true} with my items or is this change completely internal to nvim-cmp?
Thanks for the help :tada: I think this issue can be closed.

@PatOConnor43 nvim-cmp will accept { isIncomplete = true }. But you shoud add items = {} because LSP spec defines as so.


Update mdatp-portal-overview.png

Microsoft defender screenshot added

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/7377

@mjcaparas Please merge this PR. Thanks


Race condition calling RandomizedTest.isNightly

We are hitting a race condition evaluating RandomizedTest#isNightly. While the RandomizedContext is per thread, the group evaluator is shared and accessed across different ranzomized contexts, hence concurrent calls to GroupEvaluator#isGroupEnabled are not supported.
We get a NullPointerException on the last line despite the test group should be lazily added just before:
return testGroups.get(testGroupAnnotation).enabled;

This is unfortunate and comes from multiple threads calling RandomizedTest#isNightly concurrently. Simply calling the method before forking to multiple threads should fix it on our end, yet there is probably room for a better fix upstream. If the group evaluator is supposed to be shared across threads, perhaps it should be thread-safe?

Hmm. Looks like a bug indeed. I'll take a look during the weeekend.

I've committed a fix, @javanna . If you care to take a look (or have a way to test it?), it's be great to get a nod of approval. I'll release shortly.

Released 2.8.2.

Thanks @dweiss looks good!


Please share the path of your agda executable here

Currently on *nix we use which agda to locate the path, but it doesn't always work.
On Windows, we have to query the user about the path upon first installation.
We wish to improve the user experience and make agda-mode works out of the box.
To do so, we need to curate a list of paths where agda may be installed.
If you are willing to help us, please share the following information with us:

The path of the agda executable.
The OS you are using (Linux / Mac OS X / Windows ...)
The way of installation (via cabal install, with installer, build from source, ...)

Thanks :D

/Users/user/.local/bin/agda
OS X
stack install Agda

I'm regularly using Agda from Stackage LTS.
Thank you for all the work you do!

%APPDATA%\Roaming\local\bin\
Windows 10
stack install Agda

C:\Users\Robert\AppData\Roaming\cabal\bin\agda.exe
Windows 10
cabal install Agda

%appdata%\local\bin\
Windows 10
stack install Agda

/usr/local/bin/agda
macOS 10.14.6
brew install agda

~/.local/bin/agda
Fedora 30 x64 as well as Ubuntu 19.04
stack install after git clone ...

Thank you all! I'm closing this because we should have all major platforms covered for detecting the path automatically


Influxdb in windows

I was trying to install Influxdb in windows as per your video https://www.qamilestone.com/post/steps-to-setup-influxdb-on-windows.
But I got stuck at one point.
My influxd stopped stating the following line. \
C:\Users\User>cd C:\Program Files\InfluxData\influxdb
C:\Program Files\InfluxData\influxdb>dir
Volume in drive C has no label.

Looking forward to hearing from you.

looks like it is up and running....no crash indications, etc.  It is waiting for you send it data/queries/etc.

Closing since it's been awhile since the original report


Documentation on configuring for use in CI

Thank you for this project!
I have been struggling to work out how best to configure a CI for using DependencyCheck.
For example, I'd like to use the caching feature of GitHub actions with DependencyCheck to avoid redownloading all the CVEs on each build.

Is there a shared cache I can refer to?
If not; what's the "right" way to set up a shared cache for my project?

Ideally, this would be in the documentation.  I've been reading through the source code to do this myself, but have not found the right knobs to tweak.

here's an example: https://github.com/mprins/geoserver/blob/owasp-dep-scan/.github/workflows/owasp-scan.yml

@mprins Thank you!  After I opened this issue, I worked out the CVEs and data are stored under ~/.m2/repository, and I'm glad to see that confirmed in your action.
It would be helpful for the documentation to:

Note where data is cached by DependencyCheck, or note more prominently
Provide some instructions or tips on setting up CI (an open-ended thing, since there are many systems out there)

@binkley we accept PRs. If you willing to add to the documentation based on your struggles and successes it would benefit the community.

@jeremylong Excellent suggestion, will look at this during the week or this weekend.
I pulled down sources, and see it's a Maven project.  Is there any interest in a separate PR to add Maven wrapper?  I generally recommend this to clients and teams so the version of Maven used is fixed by the project's configuration, and not reliant on whichever version is installed locally.
https://github.com/takari/maven-wrapper

I don't see an issue using a maven-wrapper.  On the gradle side we are already using gradelw. This project was started back in 2011 and we just haven't switched over to using the wrapper for maven yet.  so sure send a PR.

@jeremylong A punt.  Would you prefer this documentation go to?

README.md, added in toto
`BUILD.md' with a link from the Readme, including refactoring (eg, pulling out "Development Usage" section)
CI.md, separate from other Readme instructions, but with a link from Readme
the GitHub Wiki

As I thought about the instructions over the week and weekend, I realized the style of presentation depends on the project.  I'm looking to make a PR which might be accepted on first pass, modulo typos, etc.

Is there any update on this issue? I'm also interested in understanding what I need to cache in Gradle-based projects to speed up the dependencyCheck task

I missed the question from @binkley earlier. Honestly, if you are still willing to write up what you've done - I think a CI.md might be best. We can adjust as needed.

@jeremylong I've picked this up again.  After forking the project and cloning (in preparation) for a PR, a local build complains:
[INFO] Running org.owasp.dependencycheck.utils.DownloaderIT
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.558 s <<< FAILURE! - in org.owasp.dependencycheck.utils.DownloaderIT
[ERROR] testFetchFile(org.owasp.dependencycheck.utils.DownloaderIT)  Time elapsed: 0.512 s  <<< ERROR!
java.net.MalformedURLException: no protocol:
        at org.owasp.dependencycheck.utils.DownloaderIT.testFetchFile(DownloaderIT.java:50)

[INFO] Running org.owasp.dependencycheck.utils.URLConnectionFactoryIT
[INFO] 46071 started on port: 46071
[INFO] 46071 resetting all expectations and request logs
Loading JavaScript to validate ECMA262 regular expression in JsonSchema because java.util.regex package in Java does not match ECMA262
Warning: Nashorn engine is planned to be removed from a future JDK release
[INFO] 46071 creating expectation:

Followed by a lot of JSON.
I am setup to use latest JDK 11 and Maven 3.6.3.  Am I doing something wrong?

I've been building this with java 8 - as we need to support 8+. As you are solely working on documentation I would suggest running only mvn site or possibly mvn package site -DskipTests=true.

@jeremylong My issue is solved using GitHub actions and caching for the Maven local copy of repositories, ie:
      - name: Restore cache
        uses: actions/cache@master
        env:
          cache-name: cache-dependencies
        with:
          path: ~/.gradle
          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{hashFiles('**/build.gradle.kts') }}
          restore-keys: |
            ${{ runner.os }}-build-${{ env.cache-name }}-
            ${{ runner.os }}-build-
            ${{ runner.os }}-

Apologies for the slow reply.

Is there any more fine-grained approach other than storing the entire .gradle? For example, https://docs.gradle.org/current/userguide/dependency_resolution.html#sub:cache_copy suggests to only cache three specific folders. Any chance we could do the same with the plugin?

@gmariotti Can you sketch out what that would look like?
I pasted in the recommended pattern for caching Gradle, but it has issues.   For example, sharing the daemon or workers directory leads me to sometimes need ./gradlew --stop before I launch the local CI container.  Your point is clear to me!

Sure, let me share what my team does with GitLab CI/CD
build:
  stage: build
  image: gradle:jre11-slim
  script:
    - ./gradlew check dependencyCheckAggregate
  cache:
    key: $CI_JOB_STAGE
    paths:
      - $GRADLE_USER_HOME/caches/modules-2/files-2.1
      - $GRADLE_USER_HOME/caches/modules-2/metadata-2.*
      - $GRADLE_USER_HOME/caches/modules-2/resources-2.1
      - $GRADLE_USER_HOME/dependency-check-data
  variables:
    GRADLE_USER_HOME: ${CI_PROJECT_DIR}/.gradle
    GRADLE_OPTS: "-Dorg.gradle.daemon=false"

We make sure that, inside the CI, we run without the Gradle daemon and that the Gradle user home is in the same directory of the project. And then, make sure to only cache those folders. I saw locally that DependencyCheck creates a .gradle/dependency-check-data folder, and it seems to speed up the CI a bit by avoiding to download the CSV every time, but I'm not sure it is enough.

@gmariotti Thank you for the cache list!  I'll update my own config, and see if my niggles with daemons goes away.
I presently run CI with ./gradlew --no-daemon verify, using GitHub actions for "real" CI, and Batect (https://batect.dev/) for local CI simulation.

Hi @jeremylong, just to follow up on this, is there anything more that can be done to speed up the job in the CI? Unfortunately, I don't have data to support it, but I have the feeling that the folders we currently cache are not enough for DependencyCheck

@gmariotti, Howdy!  Are you using Gradle or Maven for your build?
I use these settings for GitHub caches which seem to perform OK (I can provide timings if that helps):
      - name: Restore Gradle caches
        uses: actions/cache@master
        env:
          cache-name: gradle-cache
        with:
          path: ~/.gradle
          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{hashFiles('**/build.gradle') }}
          # TODO: See discussion: https://github.com/jeremylong/DependencyCheck/issues/2560#issuecomment-702098748
          restore-keys: |
            ${{ runner.os }}-build-${{ env.cache-name }}-
            ${{ runner.os }}-build-
            ${{ runner.os }}-

      - name: Restore Maven caches
        uses: actions/cache@master
        env:
          cache-name: maven-cache
        with:
          path: ~/.m2/repository
          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/pom.xml') }}
          restore-keys: |
            ${{ runner.os }}-build-${{ env.cache-name }}-
            ${{ runner.os }}-build-
            ${{ runner.os }}-

I'm using Gradle. The problem with caching the entire .gradle folder is that there is a lot of "garbage" coming from Gradle that you take around between builds. In the past, I had issues with it in the Gitlab CI because of permissions and how big the folder became, that's why I'd like to avoid it. I was hoping that, apart for dependency-check-data/, there was something else worth caching that could speed up the process.

@gmariotti Do you have a recommended YAML block in the GH action for Gradle?

Sorry @binkley, unfortunately, I never used GH actions, so I don't have any recommendation for it, but I think that the GitLab example can probably be rewritten for GH actions too

Answered in the issue chat.


[Bug]: Not all sliders show indicators

Requirements

[X] I checked the troubleshooting section in the README to verify that I have the latest Mushroom version.
[X] I did a search to see if there is a similar issue or if a pull request is open.
[X] I have read the state of card mod support (in pin issues) and understand card mod support is not provided in this repository.

Current Behavior
Only some of the mushroom-slider components are configured with showIndicator=true (which adds slider-track-indicator).
For instance the LightColorControl and LightColorTempControl show the indicator but LightBrightnessControl and FanPercentageControl do not.

Expected Behavior
All sliders should show the indicator.
Steps To Reproduce
No response
Context
YAML state

Environment
- Browser: Chrome
- HA Version: 2024.12.3
- Mushroom: 4.2.1

Anything else?
No response

Only the slider that have a gradient as background color have an indicator. For the other sliders, it's an active zone.
It's not a bug, it's like this by design. We can certainly improve the design by using the same slider as tile card is using which have a more subtle indicator.


Add project metadata to repo

To let people visiting our repository understand what we do, some metadata should be added.

Repo description and tags (in page header below repo name).
Short research description at the beginning of the Readme file.
Authors and lab attribution in the Readme file (see e.g. https://github.com/crocs-muni/eacirc).

Take some time formulating the short description -- think of it as an abstract: it should explain shortly what is the problem we are tackling, what we are doing and how we are doing it.

Authors added and short description as well. Need to add short research description at the beginning of the readme file.

Also add a (prominent) link to the wiki into the README.md file (browsing the project, I would almost not notice the wiki is used).

Great, done in my view.


Addition SHAP importance

I tested the repo in a real world scenario and found it to be a very useful approach. I think that adding the option to choose between model features importance and average absolute SHAP value could be integrated as a parameter in the main function. If you believe this could be a valuable addition, I am willing to start working on it.

Yes, this is currently one of the main issue and I could not find a nice solution up to now to generalize the way in which the feature importance is retrieved. As you have seen, I am using "hasattr" to check is coef_ or .feature_importances_ are available. If you have a better solution in mind, please go ahead and I will be happy to review your eventual pull request.


Server Management Commands

The following commands could be useful for server management:

/uptime
/restart and /stop
/usage to view cpu and ram usage
/cmd to run a Minecraft command

A command that could be added when the Spark Profiler is detected:

/profile

Something in the same vain of /uptime: /tps

I've decided against implementing a /restart, as it's rather complex.

The /profile command may be added in the future, but too much of a hassle to implement right now.

I've also decided against /cmd for now as that may lead to unwanted vulnerabilities and is not trivial in its implementation

/usage, /tps, /uptime and /stop are implemented now.


[1.18.2] Change Simplified Chinese fluid unit

Hi, please only submit translation adjustments to the latest branch, 1.20.5. I will merge them backwards to all supported versions myself. Additionally, 1.18.2 is no longer supported.


[add-resource] New Plugin: Foundation-for-sites

I would like to add my new plugin/theme to the Grav Repository.
Here are the project details: **Bibi40k/grav-plugin-foundation-for-sites

**

Apologies for taking so long to get this added to GPM. We do have plans to finish up our 'new gpm' solution that would not cause these bottlenecks.  But have a few things ahead of that first.
Added now, and should hopefully show up in the next hour.

Thank you


Update dependencies

arrow 53.1.0
datafusion 42.0.0

@phillipleblanc Hmm, just noticed the upgrade is also part of https://github.com/datafusion-contrib/datafusion-table-providers/pull/112.
Won't close this though, as it also switches to the upstream flight sql client (and removes the copy/pasted code). So I'll rebase once the other PR is merged (unless we find any reason to merge this one first).

@ccciudatu we can merge this first. The other PR is waiting on duckdb-rs to release a new version, which may take a while.


Pump Settings screen returns to prior value but doesn't say it cannot save

Trio is silent with a real Medtronic pump. By silent, I mean the Pump Settings screen returns to prior value but doesn't say it cannot save.
Loop doesn't report an error for too large a value because the guardrails will not allow you to send anything greater than what is allowed (by Loop). For my MDT 515, the max is 25 U (same as the guardrails).

If the rileylink is powered off, the modal alert that RL can't be found is prompt.
If the pump is out of range of the RL, takes longer but an Unable to Save alert is displayed.

Originally posted by @marionbarker in https://github.com/nightscout/Trio/issues/266#issuecomment-2146194540

This is connected to #247

Addressed in TCD / Trio 1.0.0-dev


Added pluginPath based on npm

There's a better way (tm).  Avoids shelling out.
var npm = require("npm")
var myConfigObject = {}
npm.load(myConfigObject, function (er) {
    if (er) return handleError(er)
    console.log(npm.get('prefix'));
})

All I ask is you tag one commit for credit.
git commit -m " grab prefix via npm module" --author="Justin J. Novack<EMAIL_ADDRESS>

I knew this method, but i need an synchronous get.

Per npm,

prefix Configuration
The prefix config defaults to the location where node is installed. On most systems, this is /usr/local, and most of the time is the same as node's process.installPrefix.

Try process.installPrefix instead?

I use NodeJS with nvm in OS X, process.installPrefix is undefined

That should mean it's /usr/local. Is that not the case?
Then I'd try process.execPath and remove /bin/node.
Either way, I'd desperately shell out.

FOUND IT!
process.config.variables.node_preifx
    > console.log(process.config.variables.node_prefix);
    /usr/local

You can have me commit some whitespace or something, feel free to take the meat and potatoes of the changes.

> process.config.variables.node_prefix
/
The correct is
/Users/userA/.nvm/versions/node/v5.5.0/lib/node

Welp, I'm out of ideas then. I guess shelling is the only option. :-1:

Could resolve

Thanks :)


[Feature Request] Version hard to find.

Is your feature request related to a problem? Please describe.
Not sure, which version of SWATE I'm currently using (i.e. on different Desktops + web) and cannot find version in the manifest.xml nor within the add-in. This makes it hard to check whether issues may be related to different versions.
Describe the solution you'd like
a) Rename archive behind swate.zip -> e.g. PreRelease_Swate-0.1.3
b) Add version to info icon (top right) within the add-in.

How it works:

The swate.zip is unchanged since the very first release pack.
What the add in does is it connects excel with a webpage that can also be accessed without excel (https://swate.denbi.uni-tuebingen.de/).
The webpage can interact with excel and the current version of Swate depends on the version we run on the server.
The current version of Swate up and running can be seen here:

Ah, right. Totally makes sense since SWATE isn't working as local standalone anyways. Thanks for clarification.


options: add request_client_cert to enable mutual TLS

This capability was already built-in but hard-coded to be disabled. Making it configurable as option (defaulting to off) enables mTLS connections between clients and mitmproxy. If true, mitmproxy will send a TLS CertificateRequest message to the client during the TLS handshake, upon which a client needs to present a client certificate to mitmproxy to successfully establish an mTLS connection.
This option can be used together with the client_certs option to also establish an mTLS connection between mitmproxy and the upstream server. In this case, mitmproxy needs to have a full client cert, including matching private key, that is trusted and accepted by the upstream server. This is a common scenario with MQTT or IoT connections.
Example usage:
$ mitmproxy --set request_client_cert=True --set client_certs=some_directory/
With some_directory/ containing a mqtt.example.com.pem x509 certificate file (including private key).
This allows a client connecting using mTLS, to be intercepted by mitmproxy, which is itself establishing an mTLS connection to the mqtt.example.com upstream server. Restricting the client_certs using a directory and PEM files named after the upstream domain, narrows down the mTLS requirement to this single domain, while leaving all other traffic through mitmproxy untouched (normal TLS without client certs).
Description

Checklist

[ ] I have updated tests where applicable.
[x] I have added an entry to the CHANGELOG.

reworded as suggested!

Happy to merge!


Mongo docker-compose.yml example env variable

Describe
In the mongo docker-compose.yml example it seems one of the env variables has the wrong name:
- DATABASE_AUTHENTICATION_DATABASE=strapi
Solution
Should be:
- AUTHENTICATION_DATABASE=strapi

Hi, thank your for the info ! I made the change :)


Using tf.feature_columns in exported estimators fails when using tf.feature_columns.indicator_column

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code: Yes
OS Platform and Distribution: Windows 10
TensorFlow installed from: binary
TensorFlow version: 1.14.0
Python version: 3.6.8
CUDA/cuDNN version: CPU

Tensorflow Serving information:
Using tensorflow serving docker image, tag latest, as of 05/08/2019 (August 5th):

TensorFlow ModelServer: 1.14.0-rc0
TensorFlow Library: 1.14.0

Describe the current behavior
I originally opened an issue at tensorflow/serving, but I got redirected here as it is a tensorflow issue.
Tensorflow serving doesn't handle a 'feature_columns input layer' in the Estimator model_fn.
When using tf.feature_columns.input_layer or tf.keras.layer.DenseFeatures to process feature_columns in the model_fn: If you have a feature_column that is a categorical_column wrapped by an indicator_column, Tensorflow serving fails.
Tensorflow serving doesn't seem to properly handle the indicator_column. It responds with:
{
    "error": "Input to reshape is a tensor with <n> values, but the requested shape has <n squared>\n\t [[{{node input_layer/<feature name>_indicator/Reshape}}]]"
}

The reshape op where the error is thrown
I asked around on stackoverflow, if there were workarounds, no response so far.
The main advantage of tf.feature_columns happens to be the indicator_column (which allows for easy one-hot encoding of features in the model code). It is also pushed in multiple Tensorflow guides as something that's used. I think this bug blocks practical use of the tf.feature_columns module in production.
When not using the indicator_column as a feature_column, all seems well
Describe the expected behavior
Tensorflow serving should just serve inference requests, (as it does when not using indicator_column)
Code to reproduce the issue
Script to export saved_models from estimators that use feature_columns:
"""Code for testing tensorflow serving reshape bug"""

import tensorflow as tf

feature_columns = [
    # Feature columns that use indicator column
    tf.feature_column.indicator_column(tf.feature_column.categorical_column_with_identity('test', 2))
]

estimator_params = {
    'feature_columns': feature_columns
}

def model_fn(features, labels=None, mode=None, params=None):
    is_training = (mode == tf.estimator.ModeKeys.TRAIN)

    inputs = tf.feature_column.input_layer(features, params['feature_columns'])

    if not is_training:
        return tf.estimator.EstimatorSpec(
            mode,
            predictions=inputs
        )

    a = tf.Variable(1, dtype=tf.float32, trainable=True)

    # Doesn't need to train, but the model needs to be trainable for exporting to work
    loss = tf.reduce_mean(a * inputs)

    optimizer = params.get('optimizer', None) or tf.train.AdamOptimizer(learning_rate=0.001)
    train_op = optimizer.minimize(loss, global_step=tf.train.get_global_step())

    return tf.estimator.EstimatorSpec(
        mode=mode,
        loss=loss,
        train_op=train_op
    )

def input_fn():
    return {'test': tf.constant([1, 0], dtype=tf.int64)}, tf.constant([3, 2], dtype=tf.float32)

def serving_input_fn():
    receiver_tensors = {
        'test': tf.placeholder(tf.int64, shape=[None, 1], name='test')
    }

    return tf.estimator.export.ServingInputReceiver(receiver_tensors, receiver_tensors)

# Custom estimator
estimator = tf.estimator.Estimator(model_fn=model_fn, params=estimator_params)
# Canned estimator
# estimator = tf.estimator.DNNRegressor([2, 2, 1], feature_columns=feature_columns)

estimator.train(input_fn=input_fn, steps=5)

estimator.export_saved_model('./', serving_input_fn)

Serve the generated saved_model with Tensorflow serving.
Now make requests to it.
Example body for custom estimators:
{
	"inputs": {
		"test": [0, 1]
	}
}

Example body for the canned estimator:
{
	"signature_name": "predict",
	"inputs": {
		"test": [0, 1]
	}
}

Source code / logs
All I get as response from tensorflow serving:
{
    "error": "Input to reshape is a tensor with 2 values, but the requested shape has 4\n\t [[{{node input_layer/test_indicator/Reshape}}]]"
}

It seems to always be: "... with n values", "... requested shape has n squared". Always in the reshape op.
I think it may be due to improper (de)serialization to or from Saved Model when using tf.keras.DenseFeatures or tf.feature_column.input_layer.
It may also be some bugged tensorflow op (just guessing)

@nielsgroen, Will it be possible to provide the code, which i can reproduce the reported issue on colab or jupyter notebook. Thanks!

@gadagashwini
If you must run it in google colab:

Put the code in a cell in google colab.
When in Colab, on the left you see an arrow to open a sidebar, open it.
Go to 'files'. (This puts you in the '/content' folder)
Once you ran the notebook, refresh the files. (The saved_model should be in /content folder)

Or just run it locally:

copy and paste the python code in a virtual environment with tf-1.14.0 installed.
run it (the saved_model appears in the same folder as that python file you pasted the code to)

Serve the saved_model
Now, since it is an issue which requires serving the said saved_model (remember, it is an issue with exported estimators, so we need to serve it up), we are going to serve the saved_model.
This requires tensorflow serving.
Follow the instructions to serve the model.
Make a POST request to tensorflow serving with header application/json and the body provided in the original post ^^.
If you feel like this is outside of your scope to reproduce, could you please reassign?
Thanks for your help.

I tried replicating the issue with Tensorflow 1.14.0 on Colab. I didn't get any error. Please see the colab gist. Thanks!

As is clearly stated in the issue: The script does not produce an error.
The script produces a saved_model.
(what is a saved_model)
When serving the saved_model:
Tensorflow serving produces the error (mentioned above) when a request is made (request body mentioned above).
With all due respect, someone who doesn't understand what the issue is about should not assign it to themselves. Whether it be due to a lack of a firm grasp of English (which is totally understandable) or due to other, less desirable, reasons.

Closing as there is a easy workaround found.
It turns out, when using the indicator_column, making the inputs strictly two-dimensional will work.
{
	"signature_name": "predict",
	"inputs": {
		"test": [[0], [1]]  // note the extra dimension
	}
}


[LOC] Invalid link in an article

There is an invalid link in an article.
Repro steps:

Go to https://docs.microsoft.com/en-us/Office365/Enterprise/performance-troubleshooting-plan
Search for "Plan for Internet bandwidth usage for Office 365" link
Click on the link

Actual results:
Link redirects to 404 error
Expected results:
Link redirects to an existing page or is removed from the article
GH article:
https://github.com/MicrosoftDocs/OfficeDocs-Enterprise/blob/live/Enterprise/performance-troubleshooting-plan.md

@officedocsbot assign @mypil

@OfficeGlobal - Thank you for pointing this out.
I will get this issue over to the Enterprise writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@mypil this issue is solved with the PR #401, Please review and Merge !

@ojrb - Let's first get the inputs from the author @MSFTTracyP if that portion should be removed or if there is a working link for this.
@MSFTTracyP - We need your insights on this issue. Do you have the correct URL for the "Plan for Internet bandwidth usage for Office 365" link? Or should this portion of the article need to be removed (PR #401 addresses the removal)? Please advise.
Thank you.

Sure @mypil  The problem with this link is that not exists an update on the link and is broken ! I wait for the @MSFTTracyP comments !

@MSFTTracyP - We would like to follow up. Do you have any updates? Thanks.

@OfficeGlobal -  From our understanding, the issue has been resolved but it may take a few days for the merged content to appear in the article. If you feel it hasn't been resolved, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close


I need to contact you.

where can I find your twitter or email? I'm having an issue with this pod, I'm on Xcode 7.3 and using Swift 2.2.

<EMAIL_ADDRESS>

Hello, good evening. I'm Henrique and I've tried to implement your pod in
my project but I can't figure out how to use it. Do you have an example
project?
Please help me, I loved the animations and really need it in my app, you
did a really good job on this one!!
Thanks in advance!
Best regards,
Henrique Dourado
On Mon, Mar 28, 2016 at 5:09 AM, Wei Zhao<EMAIL_ADDRESS>wrote:

<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/cp3hnu/CPImageViewer/issues/1#issuecomment-202294576

You are welcome. Yes, I have a example project and sent it to you email. You can also the pod in you project.

 Then add "pod 'CPImageViewer'"
Install pod
$ pod install
Open workspace(.xcworkspace)
You can use the pod by importing module("import CPImageViewer").
You can contact me if you have any questions.

You are welcome. This is example project.  I hope that would be useful for
you. You can contact me if you have any questions.
2016-03-29 7:02 GMT+08:00 Henrique Dourado<EMAIL_ADDRESS>
Hello, good evening. I'm Henrique and I've tried to implement your pod in
my project but I can't figure out how to use it. Do you have an example
project?
Please help me, I loved the animations and really need it in my app, you
did a really good job on this one!!
Thanks in advance!
Best regards,
Henrique Dourado
On Mon, Mar 28, 2016 at 5:09 AM, Wei Zhao<EMAIL_ADDRESS>wrote:

<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
<https://github.com/cp3hnu/CPImageViewer/issues/1#issuecomment-202294576

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/cp3hnu/CPImageViewer/issues/1#issuecomment-202617492

I know how to implement it, my problem is when I try to use it. Like when I try to assign an image to the UIImageView.image, it's crashing saying that it found nil

I don't known your problem. You can refer to the example project I sent to you email.

I managed to make it work. There's a bug tho. If I tap the image, close it
and tap it again, the image view dissppears
Em terça-feira, 29 de março de 2016, Wei Zhao<EMAIL_ADDRESS>escreveu:

I don't known your problem. You can refer to the example project I sent to
you email.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/cp3hnu/CPImageViewer/issues/1#issuecomment-202863928

I haven't met. Can you send me your project?

It was fixed already
Em quarta-feira, 13 de abril de 2016, Wei Zhao<EMAIL_ADDRESS>escreveu:

I haven't met. Can you send me your project?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/cp3hnu/CPImageViewer/issues/1#issuecomment-209683909