Bluetooth Problems

Is anyone using this keyboard with Bluetooth successfully?
I've been trying for a day or two to get it to work reliably. I can get it to connect to either of my two computers (a mac and a PC). It will work for a bit, but then after a while it seems to flake out and start typing random characters, or just stops working altogether.
At one point the keyboard worked itself into some kind of state where I couldn't type. I tried enabling/disabling bluetooth and USB to no avail. I finally fixed it by updating the firmware and restoring all of the files that it came with on the USB drive.

Were these "random characters" triggered by the pair-keys?
By default, pressing J and J within 10ms will send "You just triggered pair keys #0". Sending a sequence of keys like that may cause Bluetooth disconnection when Bluetooth signal is not good enough.
You can disable these pair-keys by comment out keyboard.pairs = [{35, 36}, {20, 19}] in code.py

No, definitely not. I'm familiar with pair keys and had already changed their function.
It's more like it will be delayed in sending what I type, and then it will start repeating things. Random characters is probably a bad description, I think it is probably related to what I type, just very delayed (like 10+ seconds) and sometimes repeated. I don't think it's a reception issue, because it happens on both the PC and the mac at the same time. My PC BT receiver is about 2 ft from the keyboard, and my Mac OS receiver is maybe 3 ft away. It seems to happen when I switch from one to the other.

It seems that there is a bug when switching between devices. Will look into it.

@CVYY39  The latest code in this repo may fix the issue. The keyboard will release all keycodes when changing devices.

That definitely improved things, but I'm still seeing some issues. Bluetooth seems to work perfectly connected to my Mac laptop. But the Windows desktop stopped accepting any input from the keyboard and, after I removed it as a BT device, no longer shows it as an option for pairing.
I thought it might be my PC's BT receiver, so I ordered a new one. I'll test that.
However, I also tested the keyboard by connecting it to my iPad Pro. I'm seeing the same weird behavior there as I mentioned in the earlier post. I was able to pair the keyboard to the iPad, and for a couple of seconds it seemed to work fine. Then after I had typed a couple of words, it slowed down considerably, and started repeating keys. It then backspaced the words I had typed.
I switched back to the Mac, and it worked again. Then I switched back to the iPad, and it let me type for maybe 20 seconds, and then the same thing happened.
I switched to the Mac again, and it worked again. Then when I switched back, the iPad would not accept any input from the keyboard. After a switched back and forth a few times, the connection to the iPad started working for a while, but the typing lag got longer and longer until it stopped working at all again.

That's weird. I have tested with a Surface Laptop 3 with Windows 2004, an Xiaomi MIX 3 with Android 9 and an iPhone 6s with iOS 13.2. I don't find the same issue yet. I will try to test more devices.
Maybe, it is an issue related to the Bluetooth connection interval. Different systems may have different requirements.
Currently, we set the connection interval to 11.25. We can remove the following lines to see if the issue still will occur or not.
https://github.com/makerdiary/python-keyboard/blob/f16fac90f9c4d0d1a291b8a3963ded2140909e2f/keyboard/__init__.py#L149-L156


add canxu in team page

Another note, the aspect ratio of your photo needs to be 640x480, otherwise it will be squished


Make entity param optional; fixes 566

Coverage increased (+0.03%) to 96.704% when pulling 9a94517dfd984a96a0ad2d96574083da210fdfa3 on jamiehannaford:fix_alarm_list into b4691a3b1d4aa46892cf051c841995670f27aea6 on rackspace:master.

This has been merged, the version bumped to 1.9.8, and released to pypi.


Multi-Cluster Support

This has been requested multiple times by the community and seems like a real "selling point" for users to pick up c9s.
Requires design both in terms of language (FROM <ctx> MATCH...?) and result naming convention.

Hey @AvitalTamir would love to work on this one with you if you'd like 🙏


Update mcc-isp-faq.yml

Updated hardware recommendations and added peering question.

Updated hardware recommendation content and added another faq on peering.

Closes #[Issue Number]

Changes

updated hardware recommendation and added question on peering.

Closing this PR since it's been moved to the private repo for additional edits.


How to access installed data in build.copy_directories?

I've scoured all through documentation, and I haven't found a way to access rock data installed via build.copy_directories in my code.

Some background - my code needs to load some JSON data before it can work, and I've gotten it to install on the system as part of the copy_directories directive. All other ones don't seem correct as they only deal with code, not data.

See https://github.com/hishamhm/datafile.

Related: https://github.com/keplerproject/luarocks/issues/305

Thank you, datafile worked great.


BlazeInfoRunnerImpl crashing @ bazel HEAD

As a result, IDEA doesn't recognize any WORKSPACE deps or generated code (which all worked fine a few weeks ago).
IDEA: 2017.1.4
Plugin:  2<IP_ADDRESS>
bazel: from source @ 9eea05d068a06ab642dd9d86d46ee5fa2e36b02e
ssertion failed
java.lang.Throwable
at com.intellij.openapi.diagnostic.Logger.assertTrue(Logger.java:168)
at com.intellij.openapi.diagnostic.Logger.assertTrue(Logger.java:177)
at com.google.idea.blaze.base.command.info.BlazeInfo.(BlazeInfo.java:89)
at com.google.idea.blaze.base.command.info.BlazeInfoRunnerImpl.lambda$runBlazeInfo$2(BlazeInfoRunnerImpl.java:79)
at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:108)
at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:41)
at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:77)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

I randomly selected a commit from 1 month ago: a79015e696f163436244887085d3b8a05ec1b0b1
And with that bazel everything works fine.
I have not attempted to binary search and figure out where bazel begins to error.

Could you paste the results of 'bazel info', using the broken version?
In particular, is 'execution_root' a parent directory of 'bazel-bin' and 'bazel-genfiles'?

If not, this is a dupe of https://github.com/bazelbuild/bazel/issues/3055

Aha, as you suspected. bazel-bin and -genfiles are in
execroot/$workspace_name while execution_root is in execroot/$dir_name
On Thu, Jun 15, 2017 at 12:02 PM, brendandouglas<EMAIL_ADDRESS>wrote:

If not, this is a dupe of bazelbuild/bazel#3055
https://github.com/bazelbuild/bazel/issues/3055
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/intellij/issues/100#issuecomment-308785032,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALF-0rHifi_O70dVUdx1WO6cFp6v78mtks5sEVWmgaJpZM4N7VHb
.

So I guess this can be hacked around by making the workspace.name == the root dir?

That should be enough to work around it. In the meantime, I'll handle this case in the plugin.

Even if I change the workspace name == root dir, I get a different exception:
java.lang.NullPointerException
	at com.google.idea.blaze.base.command.info.BlazeInfo.getGenfilesDirectory(BlazeInfo.java:118)
	at com.google.idea.blaze.python.resolve.BlazePyResolverUtils.resolveGenfilesPath(BlazePyResolverUtils.java:30)
	at com.google.idea.blaze.python.resolve.provider.PyThirdPartyGenfilesImportResolverStrategy.resolveToGoogle3Source(PyThirdPartyGenfilesImportResolverStrategy.java:22)
	at com.google.idea.blaze.python.resolve.PyDynamicImportResolverInitializer.lambda$registerImportResolvers$1(PyDynamicImportResolverInitializer.java:50)
	at com.google.idea.sdkcompat.python.PyImportResolverAdapter.resolveImportReference(PyImportResolverAdapter.java:20)
	at com.jetbrains.python.psi.resolve.PyResolveImportUtil$foreignResults$1.invoke(PyResolveImportUtil.kt:154)
	at com.jetbrains.python.psi.resolve.PyResolveImportUtil$foreignResults$1.invoke(PyResolveImportUtil.kt)

It works after restarting IntelliJ.

Me too, works after a restart.

Fixed Bazel-side: https://github.com/bazelbuild/bazel/issues/3055


[WIP] Add custom data interface for audio

First draft of AudioInterface

Exciting! Are you able to share a NWBFile on slack with this content? Would love to see how the extension widgets look

yes! Make sure however that you are not loading all the data into the widget, because currently it loads all data in for visualisation and this audio file is over 1 hour long.
This is on my todo list now to update a widget with having a data navigation.

yes! Make sure however that you are not loading all the data into the widget, because currently it loads all data in for visualisation and this audio file is over 1 hour long.

Oh my 😆

I'd also suggest adding a stub option to this interface for super-fast conversion + faster/lighter-weight sharing of files

@weiglszonja LGTM - given that this nice interface has nothing outright specific to the Fee lab, would you be open to creating a PR on NeuroConv to host this as the beginnings of a general-purpose interface for any audio file? (Only thing to-do to generalize would be to extend read capabilities beyond just .wav files)

@CodyCBakerPhD good idea, i'll create an issue for this so i won't forget :) also now that created the draft for the ephys data pipeline #21, this should be ported over there.


Permission for NT AUTHORITY\SYSTEM is necessary

Hi Team,
I believe this piece of information should be added in this document as it provides permission to the default system account and without this Always ON AG doesn't work.
use [master]
GO
GRANT ALTER ANY AVAILABILITY GROUP TO [NT AUTHORITY\SYSTEM]
GO
GRANT VIEW SERVER STATE TO [NT AUTHORITY\SYSTEM]
GO
GRANT CONNECT SQL TO [NT AUTHORITY\SYSTEM]
GO

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ee7ac6ba-8f0a-b6d9-99f4-a335afc63b99
Version Independent ID: 2b550681-c147-281d-15be-ff701387797f
Content: SQL Server Availability Groups - Azure Virtual Machines - Tutorial
Content Source: articles/virtual-machines/windows/sql/virtual-machines-windows-portal-sql-availability-group-tutorial.md
Service: virtual-machines-sql
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@aquibqureshi26 I have assigned this issue to the content author to investigate further and update the document as appropriate.

The requirement is listed in the prerequisite article. Complete the prerequisites for creating Always On availability groups on Azure virtual machines. Because it's the last section, would it make sense to move it from the prerequisite section to the tutorial section?

Hi Mike, I'm sorry I think I missed the part of prerequisite. Also in this page it's mentioned to complete the prereqs first before beginning. So it's present at the right place. placing the same information here would make it duplicate.
thanks for your reply.

#please-close


How to trigger riverpod in a function

I created a provider
final expressRiverpod = FutureProvider.autoDispose.family<ExpressRoot?, String>((ref, String id) async {
  final cancelToken = CancelToken();
  ref.onDispose((){
    cancelToken.cancel('页面取消请求');
  });
  final result = await utils.expressApi.fetchExpressData(token: cancelToken);
  ref.maintainState = false;
  return result;
});

What I want to do is to re-initiate the request when the page is refreshed
such as
EasyRefresh.custom(onRefresh: () async {
/// I want to trigger a page refresh here  (expressRiverpod)
})

What should i do

You will need a ProviderRef or WidgetRef/BuildContext obtained from a provider/consumer.
There is no way around it and this is voluntary.

Closing as this was answered
In case it wasn't clear, here is an example:
Consumer(
  builder: (context, ref, child) {
    return EasyRefresh.custom(
      onRefresh: () async {
        ref.refresh(myProvider);
      },
    );
  },
);


error trying to run gatsby dev mode

I have something I'd like to contribute to the docs about hooks - but I can't get the docs building in dev mode - output below.
Apologies if I'm missing something really obvious!

<EMAIL_ADDRESS>dev /home/james/coding/reactjs.org
gatsby develop -H <IP_ADDRESS>

success open and validate gatsby-configs - 0.012 s
success load plugins - 0.484 s
success onPreInit - 0.062 s
success initialize cache - 0.012 s
success copy gatsby files - 0.015 s
success onPreBootstrap - 0.022 s
success source and transform nodes - 0.987 s
error UNHANDLED REJECTION
TypeError: (0 , _graphql.isScalarType) is not a function

TypeMapper.js:88 TypeMapper.get
[reactjs.org]/[graphql-compose]/lib/TypeMapper.js:88:76

TypeMapper.js:608 TypeMapper.typeFromAST
[reactjs.org]/[graphql-compose]/lib/TypeMapper.js:608:17

TypeMapper.js:603 TypeMapper.typeFromAST
[reactjs.org]/[graphql-compose]/lib/TypeMapper.js:603:24

TypeMapper.js:105 TypeMapper.getWrapped
[reactjs.org]/[graphql-compose]/lib/TypeMapper.js:105:17

TypeMapper.js:272 TypeMapper.convertOutputFieldConfig
[reactjs.org]/[graphql-compose]/lib/TypeMapper.js:272:114

configAsThunk.js:19 resolveOutputConfigAsThunk
[reactjs.org]/[graphql-compose]/lib/utils/configAsThunk.js:19:41

ObjectTypeComposer.js:300 ObjectTypeComposer.getFieldConfig
[reactjs.org]/[graphql-compose]/lib/ObjectTypeComposer.js:300:58

toInputObjectType.js:44 fieldNames.forEach.fieldName
[reactjs.org]/[graphql-compose]/lib/utils/toInputObjectType.js:44:19

Array.forEach

toInputObjectType.js:38 toInputObjectType
[reactjs.org]/[graphql-compose]/lib/utils/toInputObjectType.js:38:14

ObjectTypeComposer.js:600 ObjectTypeComposer.getInputTypeComposer
[reactjs.org]/[graphql-compose]/lib/ObjectTypeComposer.js:600:84

node-interface.js:19 schemaComposer.getOrCreateOTC.tc
[reactjs.org]/[gatsby]/dist/schema/types/node-interface.js:19:8

SchemaComposer.js:382 SchemaComposer.getOrCreateOTC
[reactjs.org]/[graphql-compose]/lib/SchemaComposer.js:382:54

node-interface.js:7 getOrCreateNodeInterface
[reactjs.org]/[gatsby]/dist/schema/types/node-interface.js:7:37

node-interface.js:83 getNodeInterface
[reactjs.org]/[gatsby]/dist/schema/types/node-interface.js:83:7

schema-composer.js:18 createSchemaComposer
[reactjs.org]/[gatsby]/dist/schema/schema-composer.js:18:3

index.js:44 Object.
[reactjs.org]/[gatsby]/dist/schema/index.js:44:28

Generator.next

new Promise

⠋ building schema
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>dev: gatsby develop -H <IP_ADDRESS>
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/james/.npm/_logs/2019-06-14T22_02_14_700Z-debug.log

this is my fault - I was having trouble installing yarn, and trying it via npm - hoping it would work, despite the README - apologies!

meaning what exactly did you do ?


Store menu as instance variable

Don’t merge until PR #2 is merged.

@jrvanderveen without objection I'm going to merge this after your PR is merged and I fix conflicts


The scaling factors do not seem to be taken into account

The scaling factors like

https://github.com/KhronosGroup/glTF/tree/2.0/specification/2.0#normaltextureinfoscale
https://github.com/KhronosGroup/glTF/tree/2.0/specification/2.0#occlusiontextureinfostrength
(+possibly others)

do not seem to be taken into account. At least, for example the ao (which probably is the occlusion) seems to be read from the texture in https://github.com/KhronosGroup/glTF-WebGL-PBR/blob/master/shaders/pbr-frag.glsl#L259 , and multiplied with the color, unmodified.
(I did not yet dive deeply into the details of the code, for various reasons, but from what I have seen so far, these factors are not supported. Maybe I overlooked them...?)

Funny, I think @abwood was just talking about that this morning.  There may be some PRs coming...


[Doc]Fix SHOW USAGE RESOURCE GROUPS document link

Why I'm doing:
The documentation link for SHOW USAGE RESOURCE GROUPS incorrectly points to SHOW_RUNNING_QUERIES.md.
What I'm doing:
Fix the documentation link for SHOW USAGE RESOURCE GROUPS.
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[x] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.4
[x] 3.3
[x] 3.2
[x] 3.1
[ ] 3.0

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@dupen01 could you sign-off this PR by git commit -s

@dupen01 could you sign-off this PR by git commit -s

Sure


UVCIOC_CTRL_QUERY:UVC_SET_CUR error for SR300 when set F200_ACCURACY to 0

Required Info

Camera Model
SR300

Firmware Version
<IP_ADDRESS>

Operating System & Version
Linux

Kernel Version (Linux Only)
4.4.0-040400-generic

Build System
Makefile

In cpp-config-ui, when adjust F200_ACCURACY to 0, it will crash:
RealSense error calling rs_set_device_option(device:0xfa2830, option:F200_ACCURACY, value:0):
UVCIOC_CTRL_QUERY:UVC_SET_CUR error 5, Input/output error
X Error of failed request:  BadMatch (invalid parameter attributes)
Major opcode of failed request:  154 (GLX)
Minor opcode of failed request:  11 (X_GLXSwapBuffers)
Serial number of failed request:  4597
Current serial number in output stream:  4599
From  #2 , can find Valid accuracy options for F200 are [1,2,3],
but from tag v1.9.7, accuracy options for SR300 are [0,1,2,3], is it correct?

Should be [1,2,3] for the SR300 as well, will be resolved shortly.
Thank you!


[TACHYON-972]  Remove unused imports from LocalBlockOutStream.

#TACHYON-972 Remove unused imports from LocalBlockOutStream.
https://tachyon.atlassian.net/browse/TACHYON-972

Can one of the admins verify this patch?

I am very interested in Tachyon and would love to continue contribute to this community.
Following the instructions on new contributor tasks I edited Two of new contributor tasks real quick.
But I got a little issue here, as you can see both minor changes got included in One pull request.
Remove unused imports from LocalBlockOutStream.  Tachyon-972
Add log for file block creation in LocalBlockOutStream.  Tachyon-745
Do I have to undo the second change and wait for the 1st pull request get merged and redo the second change?
Surely for later bigger changes I will submit them one by one. :)
Thanks!
~Leo(Biao) Ma

Jenkins, test this please.

@LeoOnHack , welcome to the community! For minor changes, it's fine to combine them into one commits. But as you said, for larger ones, please open one PR at a time in the future. Also, please update the PR title to include both ticket numbers.
Hope to see more contributions from you :)

ok to test

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5084/
Test PASSed.

Thanks for the patch @LeoOnHack !

LGTM


changing flag colors to match the rest of TII

I don't think the color values are right... seemed out of order. Waiting for confirmation from Daniel Tidmas

We can't modify the assignment css file (library/src/morpheus-master/sass/modules/tool/assignments/_assignments.scss) since this will effect all plugins in Sakai. I vote we close this PR and continue to use the given colors in Sakai (since they line up closely)


[WIP] Adds journey step type to remove a user from a journey

Currently once a user starts a journey there is no way to remove them save for the API or having lots of gates that just branch a user off. This PR explores one possible solution which is to allow for a step type that can completely remove a user from a journey. The envisioned way this would be used is to create a secondary path (a new entrance) which would be considered the "exit criteria" path. If a user meets whatever requirements are in place by that path, you can then chose to remove them from the journey entirely. This would allow for almost infinite flexibility in how "exit criteria" is determined.

Hey @pushchris we were planning on doing that on our side here, do you have the plan to finish this anytime soon? otherwise we will work on something else


CodeCommit-CodePipeline: artifactName property of PipelineSource could be optional

Right now I have to type it, but artifact names seem like they're implementation details that I only very occasionally would care about.
Either default it to a fixed string ("SourceArtifact") or a guaranteed unique string (parent.name + this.name + "Artifact").

@skinny85 is this still on your radar?

This one is done 👍.


Write a Haskell program to convert seconds to days

Description
Write a Haskell program to convert seconds to days
1 day = 24 hours = 1440 minutes = 86400 seconds
Input  : 432000
Output : 5

How to contribute

Save the solution in program/convert_seconds_to_days.hs file
Add convert_seconds_to_days.hs file in convert-seconds-to-days folder

!assign


Error in prepare_histogram.py

Thanks for sharing such great work.
I was gonna try to run visualize.ipynb. To do that, I run
python prepare_histogram.py --data_root datasets --save_root results --stuff --thing

But I faced this error

Could you help me?
And if I want to get labels(masks) for unlabeled images, what should I run?
Thanks in advance.

Hi TNA8,
Thank you for your interest in our work! The visualization code is updated and it should work now.


Repackage to com.bendb.thrifty

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Ensure concurrent dind images won't use same CGROUP_PARENT

I just checked the code and thought about this.
But I don't actually understand deeply how this works so I thought I could send this PR to raise this point.
Is it a good thing to do?

I don't think this is needed since two DinD containers will result in unique cgroup (docker behavior).

Okay, thank you!


Separate node-follower workspace

Add node_follower directory
Common behavior only exists in node_follower/src/lib.rs
Update mobile_rewards to use node_follower
Update poc_iot_verifier to use node_follower

@jeffgrunewald @madninja I was thinking if I should move txn_service in this workspace as well (I have a patch ready to commit here). Its pretty isolated and only mobile_rewards and injector would be using it. Both of which implement pretty much the same module. Thoughts?

@jeffgrunewald @madninja I was thinking if I should move txn_service in this workspace as well (I have a patch ready to commit here). Its pretty isolated and only mobile_rewards and injector would be using it. Both of which implement pretty much the same module. Thoughts?

Why not?

@jeffgrunewald @madninja I was thinking if I should move txn_service in this workspace as well (I have a patch ready to commit here). Its pretty isolated and only mobile_rewards and injector would be using it. Both of which implement pretty much the same module. Thoughts?

Why not?

Added 787e9b2

I say ship it; it’ll make it much easier for me to update the proto version to the one that returns a “gateway not found” error which has additional levels to the proto struct that need to be handled; would love to handle that in only one place!


Update README.md

Purpose

fix #13
Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Pure bash implementation of AWS DynDNS

Added a pure bash option for embedded systems that are unable to support a full AWS CLI. Also added an install script and updated the documentation.

Hi Chuck. Thank you for the contribution. Your code looks great and I'm merging it.
I have one note. To keep things simple, instead of embedding the alternative AWS CLI implementation I would have created a separate script which accepts (almost) the same arguments. In this case that would be aws route53 change-resource-record-sets. The standard CLI accepts JSON while you send XML via Curl but we can easily extract the information in the JSON using the command jq. Alternatively, the aws-dyndns script could call the alternative CLI and provide all arguments as positional ones, if the standard aws command is not available. This leaves aws-dyndns very easy to read and audit, while also makes the alternative AWS CLI implementation easy to develop and test on its own.

Hi Famzah - Thank you!
I really like your idea for using jq to extract the data and generate XML for the curl command and I can confirm that the jq command appears in the basic install of the current EdgeOS (v2.0.9).
I also like your idea of separating the curl version into a separate file to keep aws-dyndns easy to read and audit. I had originally considered doing it that way, but I was worried that putting things into separate files would end up duplicating functionality. But your idea for using jq solves most of that.
As you alluded, I can just call the script something like aws-curl and accept the exact same arguments we are passing to the aws command. Then in the aws-dyndns main() function, I can set an AWS_CLI_COMMAND= variable to aws or aws-curl. Then the pollling loop never has to do a check, it simply executes a function that assembles the JSON and calls ${AWS_CLI_COMMAND} route53 change-resource-record-sets --hosted-zone-id "${AWS_ZONE_ID}"  --change-batch "${AWS_JSON_CMD}".
Inside of aws-curl I would use jq to turn the JSON into XML, and the rest is already done.
And now that I am thinking about this even further, that idea opens the can of worms to a different question - aws-curl could start out as a "one trick route53 pony" but this approach somewhat implies that it could start collecting other AWS CLI functionality for use in embedded IoT devices that have limited resources.
Given that - what do you think about this idea? What if we treat the AWS CLI as a plugin in aws-dyndns? I think all we would need to do is add a configuration variable AWS_CLI_COMMAND= to aws-dyndns.conf and make sure that it was consumed within aws-dyndns, and default it to aws if it was not found/unset.
In that way, if you want a pure bash AWS CLI for a constrained environment, you install my project and make the config change for aws-dyndns in /etc/aws-dyndns.conf.
I can start working on a patch for the plugin approach if you are ok with the general idea.

Hi. I had doubts if jq is available. Now that we know, I have a more robust proposal.
Refactor aws-curl into a separate GitHub project and then simply symlink it on EdgeOS as aws (/usr/local/bin/aws -> /usr/local/bin/aws-curl). This way aws-dyndns will never need to know if the full-featured or the Bash-only AWS CLI is installed. Because we always call aws and both implementations accept the same arguments.
AWS CLI is already an external dependency of aws-dyndns. So it's up to the system administrator to install the official AWS CLI or the pure Bash alternative implementation.
P.S. You can definitely implement other AWS CLI commands, if you need to.

Great idea. I will set up a separate aws-curl project and send you a pull request when I am ready.


Design: FR version of Date input in Figma

Adjusting card estimate to account for work involving replacing subcomponents with french versions

French component has been created
It has also been reviewed by Elise
https://www.figma.com/design/o4SguSZdar2CCFzSkWNrmB/Système-de-design-GC?node-id=851-3247&t=DfOHqJWpkrv3pz1M-0


docs(readme): fix typo

Coverage remained the same at 63.804% when pulling a052fe6bec06aee1e0bd09214980eedec3f6bb0f on FantasticFiasco:issue/readme-typo into a45d4a0239f071634804dd7901dd33b0d0d407c9 on visionmedia:master.

Thanks!


Add groupby.size

Add groupby.size function by F.count

This is my first groupby function PR. And i meet some problem when unitest. Can help me fix it?
ValueError: Unexpected values: (   B
A
1  1
2  2
3  3, A
1    1
2    2
3    3
dtype: int64)

Codecov Report

Merging #593 into master will decrease coverage by 2.32%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   93.31%   90.98%   -2.33%
==========================================
  Files          31       31
  Lines        4799     4849      +50
==========================================
- Hits         4478     4412      -66
- Misses        321      437     +116

Impacted Files
Coverage Δ

databricks/koalas/missing/groupby.py
100% <ø> (ø)
:arrow_up:

databricks/koalas/groupby.py
80.19% <100%> (+1.77%)
:arrow_up:

databricks/koalas/usage_logging/__init__.py
23.14% <0%> (-74.08%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
50% <0%> (-50%)
:arrow_down:

databricks/koalas/__init__.py
73.68% <0%> (-10.53%)
:arrow_down:

databricks/conftest.py
90.69% <0%> (-6.98%)
:arrow_down:

databricks/koalas/base.py
91.82% <0%> (-1.89%)
:arrow_down:

databricks/koalas/frame.py
93.9% <0%> (-0.82%)
:arrow_down:

databricks/koalas/plot.py
93.7% <0%> (-0.4%)
:arrow_down:

databricks/koalas/series.py
93.52% <0%> (-0.17%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54f7fb...73f87d5. Read the comment docs.

Thanks! merging.


AppVeyor: Update to latest version of Ruby

Signed-off-by: Takuro Ashie<EMAIL_ADDRESS>
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Docs Changes:
Release Note:

Sorry, it's not tested yet.


coot/ping <IP_ADDRESS>

handshake: make the code more readable
cardano-ping: modify proposed versions when quering
cardano-ping: printing of query result
cardano-ping: v<IP_ADDRESS>

LGTM.


fix: manual redirect handling in proxy

Fixes the website not redirecting deno.land/std to<EMAIL_ADDRESS>

Seems like we need to consume the result body to prevent sanitizer error in testing


Parallel pipelines

Problem: you republish of the dataset and it will take a few minutes even if only metadata changed.
Split the pipeline into: metadata and data pipelines

Pipelines now run in parallel.


Release/v1.4 Remove AKS-Engine

Reason for Change:

Backport ci to remove AKS-Engine.
Issue Fixed:

Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] relevant PR labels added

Notes:

/azp run Azure Container Networking PR - submodules


[discussion] Branch management

Discussion to work out what branches we need, what to call them and how we are going to organise them.
@space-is-hard - tagging you to make sure you see this.

This is going to have to be where our back-and-forth takes place today; apologies in advance.
I think first we need to outline what kind of structure we want KSLib to take. Do we want:

A "package" that gets updated in discrete increments; i.e. push out a release every now and then that's got new stuff that's been tested. Users would be encouraged to download the whole package and use what they need. This would require a develop branch to work with and a master branch to release from.

A continuously updating collection; i.e. library additions or improvements are constantly pushed to master after testing them. This would arguably only require a master branch.

Something else? Open to ideas.

Not really sure on this The continuous updates would probably be easier but people using this library (other than those contributing) probably wont check back very often (if at all) for updates if they are lots of small things.
If we want a way of informing people of updates then they should probably be larger updates.
I don't use ckan but we could potentially stick the kslib in as a recommended/ suggested download in the same way that the extra contract packs are for contract configerator.

Or the latest version of KSLib could be included in the kOS download, which I think would serve a dual-purpose of giving the user some useful functions for stuff and letting new users see examples of the code and of functions in general

In which case discreet updates are probably best.
We should also probably make a point of creating some scripts that use the newest language features for a release so to increase visibility of those features (for people that might not read the change log)

Agreed. Master already seems to be up-to-date, let's go ahead and get some of our PR backlog pushed to develop, test it, and push it to master for release of KSLib v0.1(?)

Ok i'm going to start going through the testing the PR's I will leave a comment on them once they are tested. If you could have a look at them for spelling etc and leave a comment if you get to that one first, or merge if i have already tested. (who ever gets there second merges it)

Sounds good

before we release we should probably go through an make sure everything has the
// This file is distributed under the terms of the MIT license, (c) the KSLib team

line in the header too.

The develop branch is way behind master; I don't think we need the develop branch anyways since KSLib is in a state of "continuous release". Does anybody have objections to deleting the develop branch?


Updated readme and cleaned up tests

This is mostly a feel good edit to make stuff more readable and can wait for the next release.

Since I haven't cut the release... let's do it


Add name property to el-upload input element

Without the name or id property the form field cannot be submitted as a regular non-xhr ajax request. I've opted for adding just the name attribute.
Please makes sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

I made a mistake in the syntax as well as the fact that there is another line that clears the input value for some reason.


Add editor setting to enable or disable zooming with ctrl + Mouse wheel

Supersedes #82928
Fixes godot-proposals#7997

Tooltip text: If true, allows zooming in the script and text-based shader editor with [kbd]Ctrl + Scroll wheel[/kbd].

Needs a rebase

Damn  messed up my commit history again

You used a merge commit to update your branch, please use rebase in the future instead, see here
Please squash your commits into one, see here

See the above instructions on how to fix it

I do not have the expertise to fix this Merge request.
Closed indefinitely.

I can help you if you need, but it'd be good to learn rebasing as it's an important skill in the PR workflow


wasapi: make render thread exist for the lifetime of the stream object

Took a crack at this to see what it might look like. See #534 for why I think this could be a good idea.

Converts cubeb_stream into a reference-counted object, and gets rid of
emergency_bailout logic
When reconfiguring, only restart a stream if it was already started
Removes timeout inside the render thread, as we can't guarantee events
while a stream is stopped

@kinetiknz
After stream_destroy, the only way I see that a callback would be executed is if WaitForMultipleObjects stalls, and then returns a refill/input_available event even though a shutdown event is also set. Do we know if WaitForMultipleObjects ever stalls, or if the stalls are just inside WASAPI?
After stream_stop is complicated. Even after calling IAudioClient::Stop, the events can still be triggered. I'm seeing usually one more event to fill up the buffer (which executes a callback), and then events with 0 frames left to fill (which doesn't execute a callback, but might unnecessarily add CPU load/thread context switches). How strict is the requirement not to execute callbacks after stream_stop? Thinking through this, I think the only way to accomplish this in every case would be to move the stream start/stop logic inside the render loop thread. Not that complex to code but increases the probability of encountering a stalled thread.

After stream_destroy, the only way I see that a callback would be executed is if WaitForMultipleObjects stalls, and then returns a refill/input_available event even though a shutdown event is also set. Do we know if WaitForMultipleObjects ever stalls, or if the stalls are just inside WASAPI?

Just WASAPI, so this case is fine and I'm just wrong about it.  stream_destroy is the important case, since we expect the caller to free resources after the stream is destroyed.

After stream_stop is complicated. Even after calling IAudioClient::Stop, the events can still be triggered. I'm seeing usually one more event to fill up the buffer (which executes a callback), and then events with 0 frames left to fill (which doesn't execute a callback, but might unnecessarily add CPU load/thread context switches). How strict is the requirement not to execute callbacks after stream_stop? Thinking through this, I think the only way to accomplish this in every case would be to move the stream start/stop logic inside the render loop thread. Not that complex to code but increases the probability of encountering a stalled thread.

I think this is fine for now, since it's no different from the behaviour before your changes.  Eventually we'll want to tighten this up for all backends, I think.

@kinetiknz Apologies for the delay on this. Rebased to current master (taking extra care around the changes to the thread/bailout logic), and based on the comments above this is ready for review as-is.

@kinetiknz Are you still interested in this? Happy to rebase and fix conflicts if so.

@kinetiknz any reason this wasn't merged?

Sorry about that, I think we forgot. I've rebased your initial patch, because the underlying code has changed a lot.
https://github.com/mozilla/cubeb/tree/wasapi_render_loop_lifecycle_rebase is my rebase. I'll change this branch so that it's cleaner, there are various things in a single commit at the moment and CI changes unrelated to your fix.
We now have CI for Windows (as of last week): https://github.com/mozilla/cubeb/actions/runs/4862284679/jobs/8668439986, and I'm trying the patch on Firefox's CI, running most of our media tests, we'll see.

@padenot I think you've made the typo. The original author of this code is @ligfx , not me. I've just discovered it when root causing the bug I was experiencing.

@padenot for the record, I've been running with the rebased branch for a few days so far and haven't encountered any issues (and it did indeed fix the problem I was having). Granted, that's even less coverage than mozilla CI provides, but at least I can confirm that this solves something ;P

Granted, that's even less coverage than mozilla CI provides

Yes, but the workloads are less synthetic, so it's useful to know, thanks for giving it a try! I'm going to re-read the patch myself and probably merge it.

@kinetiknz I'm merging this, it's green all around on treeherder and here. I've added a couple commits to be able to have clang-format that has the same results locally and on the CI but it's the same as the original patch (rebased) otherwise.


Add Metrics to OPC PLC

Purpose
Enable metrics emission from OPC PLC in addition to OTEL tracing added previously

Also, increase the version in version.json

@saixiaohui please confirm with LGTM.


Litmus webapp should be able to load from "/litmus" path inaddition to "/" path

We are not able to access litmus portal from /litmus path when we setup an ingress path for litmus portal within an enterprise, we need litmus app to be loaded from customized paths inaddition to root path "/". Hence request to configure litmus to load from "/litmus" path inaddition to "/" path.
Thanks.

Hi, @asibece Could you ask the same question by joining the Litmus slack channel as well?
Assigning @ksatchit this but just in case you don't get an immediate response here you surely will in our slack community for this as well as further questions!
To join the slack please follow the following steps!
Step 1: Join the Kubernetes slack using the following link: https://slack.k8s.io/
Step 2: Join the #litmus channel on the Kubernetes slack or use this link after joining the Kubernetes slack: https://slack.litmuschaos.io/
Thanks


refactor(instrumentation-perf-hooks): rename to instrumentation-runtime-node

Which problem is this PR solving?
This is my proposal for the name change, see #1956
Short description of the changes

renames the entire package instrumentation-perf-hooks to instrumentation-runtime-node
this is not a breaking change as it has not been released yet
adds an entry in the component label map so that labels are applied

@pichlermarc Looking at this again, I suspect we want to change PerfHooksInstrumentation to RuntimeNodeInstrumentation or something.

@pichlermarc Looking at this again, I suspect we want to change PerfHooksInstrumentation to RuntimeNodeInstrumentation or something.

@trentm opened another PR #1970


[SIL.rst] Add an Ownership SSA sub-section about forwarding uses.

Just resurrecting this against main.

@atrick I am going to fix your comments from the other PR but then I want to merge this. Lets do everything else post-commit.

@swift-ci smoke test

@gottesmm I don't remember what my comments were, but I think they were fundamental. I can re-review whenever those fundamentals are cleared up.


Add support for kali

Requesting a new feature 🧑💻
If you are proposing a new feature for deb-get please describe the proposed
feature with as much detail as possible here:
It doesn't work on Kali-Linux.
I tried to modify the script and avoid the check and then it works.Is it possible to add support for the distro ?

can you please post here

the contents of /etc/os-release (if it exists - else /usr/lib/os-release iirc) and
/etc/debian_version if that exists?


Dr Elephant on Mapr

I am trying to setup Dr.Elephant to monitor spark applications on Yarn in MapR environment. I see this error message in logs on startup
08-14-2017 11:18:20 INFO  [dr-el-executor-thread-0] com.linkedin.drelephant.ElephantRunner : Analyzing SPARK application_1500723496611_0033
08-14-2017 11:18:20 ERROR [dr-el-executor-thread-0] com.linkedin.drelephant.ElephantRunner : Couldn't find configured namenode
08-14-2017 11:18:20 INFO  [dr-el-executor-thread-1] com.linkedin.drelephant.analysis.AnalyticJobGeneratorHadoop2 : Retry queue size is 1
08-14-2017 11:18:20 ERROR [dr-el-executor-thread-2] com.linkedin.drelephant.ElephantRunner : Add analytic job id [application_1498492206511_0003] into the retry list.
08-14-2017 11:18:20 ERROR [dr-el-executor-thread-0] com.linkedin.drelephant.ElephantRunner : java.lang.IllegalArgumentException: Couldn't find configured namenode
at com.linkedin.drelephant.util.SparkUtils$class.fileSystemAndPathForEventLogDir(SparkUtils.scala:79)
at com.linkedin.drelephant.util.SparkUtils$.fileSystemAndPathForEventLogDir(SparkUtils.scala:312)
at org.apache.spark.deploy.history.SparkFSFetcher.doFetchData(SparkFSFetcher.scala:84)
at org.apache.spark.deploy.history.SparkFSFetcher$$anonfun$fetchData$1.apply(SparkFSFetcher.scala:74)
at org.apache.spark.deploy.history.SparkFSFetcher$$anonfun$fetchData$1.apply(SparkFSFetcher.scala:74)
at org.apache.spark.deploy.history.SparkFSFetcher$$anon$1.run(SparkFSFetcher.scala:78)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:360)
at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1575)
Did anyone see this issue before?

Hi @ntirupattur, sorry for the delayed response. I was on vacation for the last couple of weeks.
I am not much aware of the MapR system but it looks like it has a No-Namenode architecture in which case some extra code/configuration changes might be required in Dr. Elephant.


data-select2-id in all over places

When opening select2 dropdown its added data-select2-id in to all over pages, not same id but increase each time.
have a look in below image

I've got the same problem, tried updating and not there are some hash-like values instead of increasing numbers.

I've done a bit of digging and it seems this is ultimately caused by inconsistent values returned from the Utils.hasScroll method.
When first opening an initialised element, AttachBody.prototype._attachPositioningHandler is called, which invokes the above method:
var $watchers = this.$container.parents().filter(Utils.hasScroll);

The final part of hasScroll looks like this:
return ($el.innerHeight() < el.scrollHeight ||
  $el.innerWidth() < el.scrollWidth);

I noticed that for some elements $el.innerHeight() would be 28 whereas el.scrollHeight would be 29. Firefox's dev tools clearly showed the rendered size was 28px but for some reason scrollHeight returns an extra pixel, therefore all of the parent elements were being included in the return value from jQuery's filter (and subsequently given the data-* attribute).
This can be fixed by tweaking things like the element's height, line-height, and font-size CSS properties but this was not an acceptable solution for me.
Interestingly there's a comment at the beginning of Utils.hasScroll:
// Adapted from the function created by @ShadowScripter
// and adapted by @BillBarry on the Stack Exchange Code Review website.
// The original code can be found at
// http://codereview.stackexchange.com/q/13338
// and was designed to be used with the Sizzle selector engine.

My "fix" has been to include Bill Barry's original function inside Utils and replace the .filter(Utils.hasScroll) calls with .filter(':hasScroll').
The original function is as follows:
function hasScroll(el, index, match) {
    var $el = $(el),
        sX = $el.css('overflow-x'),
        sY = $el.css('overflow-y'),
        hidden = 'hidden', // minifiers would like this better
        visible = 'visible',
        scroll = 'scroll',
        axis = match[3]; // regex for filter -> 3 == args to selector

    if (!axis) { // better check than undefined
        //Check both x and y declarations
        if (sX === sY && (sY === hidden || sY === visible)) { //same check but shorter syntax
            return false;
        }
        if (sX === scroll || sY === scroll) { return true; }
    } else if (axis === 'x') { // don't mix ifs and switches on the same variable
        if (sX === hidden || sX === visible) { return false; }
        if (sX === scroll) { return true; }
    } else if (axis === 'y') {
        if (sY === hidden || sY === visible) { return false; }
        if (sY === scroll) { return true };
    }

    //Compare client and scroll dimensions to see if a scrollbar is needed

    return $el.innerHeight() < el.scrollHeight || //make use of potential short circuit
        $el.innerWidth() < el.scrollWidth; //innerHeight is the one you want
}

$.expr[':'].hasScroll = hasScroll;

It's likely there was a reason the function was adapted for Select2, so modifying it obviously has the potential to cause issues, but for now it seems to be working well for me.

Really annoying that this is tagged as Stale / Closed, still a real issue!

Really annoying that this is tagged as Stale / Closed, still a real issue!

And still an issue !

I have the same issue bump

Same issue from me.

4.0.13 still an issue

@kevin-brown Could this issue be reopened please, or should a new issue be filed?

This has something to do with line-height: 28px causing a 1 px overflow in the parent. Can be solved by adding the following CSS to the stylesheet:
.select2-container .select2-selection {
  overflow: hidden;
}


Keep support for old CLDR versions, easier mvn configuration, faster jar creation

Thanks for https://github.com/punic/data/pull/12 !
What about these improvements to that pull request?

👍


collect diagnostics via UI

update the UI to run the collect-logs.ps1 and maybe rename it to 'diagnostics' or something. also collect ipconfig information when running the script

duplicate of #201


Create student

@Acyric Could you please rename lib/domains/us/ca/k12/murrieta/student to lib/domains/us/ca/k12/murrieta/student.txt
Thank you.

@Acyric You might miss my previous comment. Please react.

What was the previous comment?
On Tue, Sep 4, 2018, 4:53 AM Philip Torchinsky<EMAIL_ADDRESS>wrote:

@Acyric https://github.com/Acyric You might miss my previous comment.
Please react.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/swot/pull/5177#issuecomment-418339118, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANCPmkIIi6-6x1s1VUBAF-UHQTqjQ_iWks5uXmnAgaJpZM4WOCmy
.

@Acyric

What was the previous comment?

Could you please rename lib/domains/us/ca/k12/murrieta/student to lib/domains/us/ca/k12/murrieta/student.txt
Thank you.

@Acyric Actually, there was an entry for this domain already. I merged the request but deleted the file because it had wrong filename, and the domain is already represented in this repository.


Preinstalled Container options to run pling (docker,singularity)

Dear dev,
Looking at all the dependencies of pling, is there a single container available (e.g., docker or singularity) containing all the preinstalled dependencies and envs that pling needs (so i can start the container and run pling inside)? Otherwise, it looks hacky to install with the various Python versions in a stable and reproducible manner, especially for workflows or routine applications.
Best, and thank you.

Hi there

Apologies you’ve had problems,  @babayagaofficial has  been working to eliminate the barriers to a simple bioconda installation (bioconda would also automatically generate containers). So this is not just "on the roadmap ", but in progress.
@babayagaofficial is on vacation for 10 days, but will get back to you soon after that

All the best
Zam

Thanks for the reply. A single bioconda install recipe would be great.


Allow definition of attributes/measures/units in info.json model

The current info.json structure allows the definition of new dataset-local dimensions, but it doesn't allow the definition of new dataset-local attributes/measures/units.
This task is to extend the existing info.json model so that it's possible to define attributes/measures/units dynamically, as well as allowing users to specify a CSV location for a code-list.
Note that we need to be able to support two forms for inputting CSV codelists:

a purely data-set local code-list with the standard label/notation/parent notation/sort order/description columns.
~a spliced code-list with label/uri/parent uri/sort order/description columns.~ We are not sure of how this will look yet.

We need to be able to take both of these formats in and represent them as distinct classes. The first should mapped to the existing NewQbCodeList (adding appropriate properties where required). The second should have a new class called NewSplicedQbCodeList which extends the abstract QbCodeList model.
Make sure you provide an updated JSON schema for the changes you make - but don't override it where it currently lives.

We can't really estimate this yet because we're still waiting to come to a decision on the result of the spike issue #84

After speaking with @rossbowen at the refinement session - we're happy to go along with the work @canwaf has done on info.jsonV1.2 for now, with @robons providing the modifications necessary for multiple measures/units.
We may end up needing to alter the structure of this if people find it too difficult or confusing to use.

Closing as duplicate of #158


refactor: use it.combinations instead of it.combinations_with_replacement

Overview
Description of the changes proposed in this pull request:
A small follow up from my previous PR #3761, comment by Connor: LINK
Checklist

[ ] All pre-commit checks pass.
[ ] Unit tests added (if fixing a bug or adding a new feature)

@connortann Any idea why this job is now failing on Windows?
https://github.com/shap/shap/actions/runs/10232378534/job/28309628156
I'm not sure why this problem didn't surface in your previous 2 PRs (just merged in) and commits though.

Hmm, strange. It looks like it might possibly be related to this issue:
https://github.com/astral-sh/uv/issues/1491

@connortann Any idea why this job is now failing on Windows?
https://github.com/shap/shap/actions/runs/10232378534/job/28309628156
I'm not sure why this problem didn't surface in your previous 2 PRs (just merged in) and commits though.

So it seems that Matplotlib recently deleted their 3.9.1 release wheel for Windows (source) due to a critical bug, so that explains why this problem didn't surface in earlier runs.
And this in turn resulted in matplotlib being built from source via uv, and some sort of build error caused it to fail (still unsure what). Strangely though, I tested here with a debug branch that using pip instead of uv to install matplotlib==3.9.1 (built from source) on windows doesn't cause an error.
So the actual fault seems to be a combination of windows + uv + matplotlib being built from source..
Regardless, I'm expecting that matplotlib 3.9.2 is going to be released soon (also reiterated by mpl's maintainers), where the wheels will be reintroduced back for windows. I suggest we just wait till then to rerun the CI.

Thanks for the analysis!
As a short-term workaround, we could also add a constraint in the test dependencies of matplotlib!=3.9.1

The 3.9.1 wheels on windows would, depending on import order, cause segfaults, see https://github.com/matplotlib/matplotlib/issues/28551#issuecomment-2266699619.
We deleted the bad wheels to avoid segfaults (which seemed like a good idea) but failed to anticipate that this would cause downstream projects to start trying to build mpl from source instead of pulling the 3.9.0 wheel.  We have now yanked the whole 3.9.1 release to fix these problems and will get 3.9.2 out as quick as we can.
To prevent this sort of thing in the future (trying to build something from source when you are not prepared to do so) I suggest using matplotlib --only-binary "matplotlib"  in your requirements file (which may be a good practice for all wheels that have extentions).
Sorry for the trouble.

As a side note, the install failing with uv but "working" with pip may in fact be a bug with pip as some of the other failure reports we got indicated building "worked" and Matplotlib was installed, but the c-extension modules were missing and we failed immediately on import.


Option for non-persistent filters

Currently when using multiple search queries, the queries stack. Make it possible to make the search requests non-persistent.

If you need a non-persistent search query, isn't the "title filter" more fitting?

Is there any way to set title filter as default search mode? I know need to type something random in the search field, press enter, select title filter from 3 dots menu, enter search query and delete the random thing I typed.

I don't understand why you need the step "type something random in the search field". Can't you just toggle the title filter and bypass the search page altogether?
Also, the quick actions displayed next to the 3 dot menu are configurable, so you could put there the title filter toggle (next to the regular search, or instead of it, whatever you prefer). It's in Settings > Thumbnails > Quick actions.

Ah, Thr location in settings is a little bit weird. Did not expect such a setting under "thumbnails"


[Azure] Enable Azure training environment for supported scenarios

Currently in Model Builder, we support the following scenarios and environments:

Scenarios
Local
Azure

Data classification
✅
❌

Value Prediction
✅
❌

Recommendation
✅
❌

Forecasting
✅
❌

Image classification
✅
✅

Object detection
❌
✅

Enable Azure as a training environment for all supported scenarios:

[ ] Data classification
[ ] Value prediction
[ ] Recommendation
[ ] Forecasting

For this work Item @luisquintanilla proposes options:
1.Run the ML.NET CLI in a custom environment (Docker). With this option, we get access to the model, mbconfig, and code-behind so we can download those down to the users' machine when training is complete. Also the benefit to this is we don't have to ship or create a custom environment with our proprietary training components MB users.
2. Run the training components we use in Model Builder on a custom environment (Docker). With this option, we are in full control of the training process and for the most part the behavior would be almost the same as the local environment, except you're running the training job in the cloud. The issue with this is that we'd probably have to ship our proprietary bits in the environment to perform the training process.
3. Use Azure AutoML. With this option, we just use what Azure provides us. The only scenarios we can provide there though are classification, regression, and time-series forecasting. We would have no control over the code-behind and would have to just get the model in ONNX format like we do today for image classification and object detection.
@JakeRadMSFT @beccamc @LittleLittleCloud   any  thought on this ?

I think that Option 1 is the most elegant. Running the ML.NET CLI in Azure just makes sense to me and seems easy to explain. Additionally...

Keeps us honest that everything in Model Builder also works in the CLI
Provides reproducibility for users outside of Model Builder

I don't like Option 3 as much. If users want to use Azure AutoML they can use Azure AutoML directly? I feel it adds confusion when we hide what we're doing and kick off a run that uses a completely different stack.
These are my initial thoughts! Others?

The question here is what do we want to earn from azure training: better model, better performance, or something else

+1 for Option 1.

The question here is what do we want to earn from azure training: better model, better performance, or something else

Using larger compute than you have locally.
Leverage the following Azure ML capabilities.

Dataset versioning
Model versioning
Experiment tracking

Similar to the one above, when working with data scientists / developers already using Azure ML, your ML.NET experiments and models don't have to be treated or worked with differently. You can track and manage everything in one place.


Datetime Widget with format option results in "Invalid date" when user enters empty string

Describe the bug
Let's say you have the following in your netlify-cms config.yml:
fields:
  - {label: "Datum", name: "date", widget: "datetime", format: "YYYY-MM-DD HH:mm", required: false, default: ""}

The idea is to have a non-required timezone-less datetime.
When the netlify-cms user deletes the field (enters empty string), then
Actual behaviour: the string  "Invalid date" is written to the YAML file
Expected behaviour: the empty string is written to the YAML
Seems like the isValidDate validation happens before .format is applied, and unfortunately:
 moment('').format("YYYY-MM-DD HH:mm") === "Invalid date"

I suppose, changing
      const formattedValue = moment(datetime).format(format);
      onChange(formattedValue);

to
      const formattedValue = datetime === "" ? "" : moment(datetime).format(format);
      onChange(formattedValue);

would fix this.
Applicable Versions:

Netlify CMS version: 2.9.7

Good catch, would take a fix for this. Simpler and less specific would be:
const formattedValue = datetime ? moment(datetime).format(format) : '';
onChange(formattedValue);

Sure, I made a pull request with my normal github account (I was using the SwissWoodSolutions for a netlify website project).

Any chance the fix from #2705 will be merged? 🙏  I'm fighting with this in client project and it's kinda annoying to add checking if dates are equal to Invalid date string.

@erquhart Wow, that was fast! 😲 Thank you! And of course thanks to @mb21 👍 👏


Missing curly bracket {} in api function

Hi Fabio,
Can you please add a { } to this function:
async function celltype_location(organism, celltype, measurement_type = "gene_expression")
cheers,

thank you, closed on 0.2.1


pull request for e2e test at 11/24/2016 05:56:08

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add basic support for custom error handling

This is a WIP.
Fixes: https://github.com/martinn/quickapiclient/issues/2

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.4%. Comparing base (68238c4) to head (1a51930).

Files with missing lines
Patch %
Lines

quickapi/exceptions.py
72.7%
2 Missing and 1 partial :warning:

quickapi/api.py
85.7%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #11     +/-   ##
=======================================
- Coverage   92.5%   91.4%   -1.1%
=======================================
  Files         14      14
  Lines        322     340     +18
  Branches      43      43
=======================================
+ Hits         298     311     +13
- Misses        22      26      +4
- Partials       2       3      +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Particles scroll factor wrong when zooming camera on CANVAS mode

Version

Phaser Version:
Phaser v3.17.0 (Canvas | Web Audio)
Operating system:
Windows 10
Browser:
Chrome

Description
When you change the camera zoom  to any other value than 1 the particle emitter position starts to go out of place and moves faster than the camera. Probably related to the scroll factor.
Example Test Code
https://codepen.io/anon/pen/gJmgVp
Click on the game to zoom, then change the type to WEBGL and click again. Notice how the particles end in a different spot.

I am also having an issue with this. A possibly simpler case can be seen from the examples:
https://labs.phaser.io/edit.html?src=src\game objects\particle emitter\follow sprite.js
where on line 30 add: this.cameras.main.zoom = 0.5; and change the renderer to CANVAS in the config.
Any help on this will be much appreciated :)

I was able to fix it by adding "extra" to the x and y positions of the emitter. It seems that under Canvas the particle emitters do not take into consideration the zoom level.
Here is my solution, maybe it will be helpful in fixing the bug:
`// The positions we want to place the particle emitter
let endX = 800;
let endY = 600;
// Take camera zoom and center
const zoom = this.scene.cameras.main.zoom;
const camCenterX = this.scene.cameras.main.worldView.centerX;
const camCenterY = this.scene.cameras.main.worldView.centerY;
// The extra x and y, which we need to add to endX and endY, so that the final position is indeed 800 and 600.
// We take the distance between endX and the center of the camera and multiply it by a transformation constant which depends on the camera
const extraX = (endX - cameraCenterX) ((1/zoom)-1);  // another way of writing this is (1-zoom)/zoom
const extraY = (endY-cameraCenterY)((1/zoom)-1);
endX+=extraX;
endY+=extraY;
`

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.

This issue has been mentioned on Phaser. There might be relevant details there:
https://phaser.discourse.group/t/zoom-tilemaps-parallax-global-vs-camera-zoom-broken/11786/1


TypeError: Wr is not a constructor

Hello I got an type error using nuxt-electron. I got this error when I try to used twurple :
  const chatClient = new ChatClient({
    authProvider: authBotProvider,
    channels: [read('streamerInfo')?.login as string]
  });

  chatClient.connect();

(node:36200) UnhandledPromiseRejectionWarning: TypeError: Wr is not a constructor
    at k_.connect (M:\codage\lion-bot-desktop\dist-electron\main.js:28:4580)
    at A_._tryConnect (M:\codage\lion-bot-desktop\dist-electron\main.js:28:3602)
    at A_.connect (M:\codage\lion-bot-desktop\dist-electron\main.js:28:1373)
    at j4.connect (M:\codage\lion-bot-desktop\dist-electron\main.js:31:7402)
    at _d.connect (M:\codage\lion-bot-desktop\dist-electron\main.js:31:33192)
    at lw (M:\codage\lion-bot-desktop\dist-electron\main.js:31:36802)
(Use `electron --trace-warnings ...` to show where the warning was created)

Any idea or clue to help solve this ?

Can you provide a minimal reproduction repo?

I found the issue. I come to my authBotProvider initialization. I move my code to the nuxt plugin and I got more informations (with the good class name)

I found the issue. I come to my authBotProvider initialization. I move my code to the nuxt plugin and I got more informations (with the good class name)


feat: add OSMWayLoader and highway2vec

Closing, as the pull request would become too large. OSMWayLoader and Highway2Vec will now become 2 separate Pull Requests. PR for OSMWayLoader is #166


refactorFixes

I refactor the if statement where we use multiple operator inside if statement.
The second thing is to remove the comments from the code.

@Ujjwal164 Please check the linting issues once.


[Bug]: docker run infinity failed and no log output

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Version or Commit ID
v0.5.0-dev5
Other environment information
OS: Linux ragflow 6.8.0-49-generic #49-Ubuntu SMP PREEMPT_DYNAMIC Mon Nov  4 02:06:24 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
CPU Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx lm rep_good nopl cpuid extd_apicid tsc_known_freq pni cx16 x2apic hypervisor lahf_lm cm
                          p_legacy cpb vmmcall arat

Actual behavior and How to reproduce it
According to the official Docker deployment documentation, the container cannot start and there is no log content output
Expected behavior
No response
Additional information
No response

The CPU model is too old and the instruction set is incompatible. Users can try compiling an binary using source code themselves but not use the prebuilt binary or Docker image.


implement authentication across all subdomains

is it possible to implement authentication across all subdomains like this ?
https://kanakkholwal.medium.com/how-to-implement-authentication-across-all-subdomains-using-next-auth-in-next-js-2ad8393c268d

Please, would you mind summarizing your objective?

Use case:
in some cases, companies want to host related webapps on multiple subdomains
e.g.,
example.com <-- marketing site
docs.example.com <-- docs site
console.example.com <-- dashboard site
billing.example.com <-- billing site
It make sense if end user login to console.example.com, they should be able to seamlessly login to other sister sites with same domain name i.e., *.example.com.
Options
To accomplish this,   we should be able to set session cookie at domain level.
I was using like this with AuthJS to setup cross-subdomain session cookie:
export const domain = new URL(envPub.PUBLIC_BASE_URL).hostname.replace(/^[^.]+\./g, '');

cookies: {
sessionToken: {
	name: cookieName,
	options: {
		httpOnly: true,
		sameSite: 'lax',
		path: '/',
		domain: domain == 'localhost' ? domain : '.' + domain,
		secure: useSecureCookie // process.env.NODE_ENV === 'production'
	}
}
}

I am planing to switch to hasura-auth and wonder how to do same with hasura-auth.

Closing as this is already supported.
In hasura-auth you will need to configure the client url and allowed urls (settings -> authentication). On the client side then use the redirectTo based on the domain you are in during sign up/in operations. This assuming each subdomain has their own login page. Otherwise, if you have a single "login" domain you don't need this (well, you will need the client url)

To accomplish this, we should be able to set session cookie at domain level.

Assuming you are using our sdks you can handle the behavior for dealing with cookies yourself overriding the ClientStorage.
If you have doubts or questions I'd suggest you to open a github discussion or reach out to us on discord.


Database summary - Add table size/record count to System Reset screen

Notes for Reviewers
This PR fixes #6333
Signed commits

[x] Yes, I signed my commits.

@UsmanDev09 what feedback do you have here?

Merge conflict

@Meyazhagan Please move Database Summary logic and state into its own component.

@UsmanDev09 I made the changes, and resolved merge conflict

@Meyazhagan The UI needs a bit of revamping.
You can try to be creative on your own or ping me to discuss how it should look like.

@UsmanDev09 I updated the UI

Looks good to me. Were you able to implement pagination too?

Were you able to implement pagination too?

@UsmanDev09 Thanks for reminding me. I added pagination

LGTM @Meyazhagan. Good Work!

@Meyazhagan before we merge will you push the Eslint fix??

@MUzairS15 I fixed the lint errors


Parsing XML posts not working?

In Rails 4.2.1, I added
config.middleware.insert_after ActionDispatch::ParamsParser, ActionDispatch::XmlParamsParser
to my Application in application.rb
But my XML post still isn't getting parsed.  I put debugger lines in the initializers for XmlParamsParser and for the core ParamsParser. Both initializers are called (probably from the line I added) but neither one's "call" is ever called.  And of course, by XML body isn't being parsed, either, as far as I can tell.  Do I have to do this manually, instead?  Hash.from_xml ?
First Rails 4.2.1 project, and first time with rails-api, so most likely I'm doing it wrong....
TIA

+1

Ah.  Problem mostly solved.  Looks like it's working when Rails is fully running.  I was trying to see the XML in  a post get parsed when in an spec unit test.  Something seems to be skipping the params parser and xml parser.  Maybe for speed?  Anyone know if it can be enabled, so I'm testing original API input ?  From a unit test perspective, I don't mind shifting my post to use a hash.  It was just confusing.

+1

Add this gem https://github.com/rails/actionpack-xml_parser and include the following into application.rb
  config.middleware.use ActionDispatch::XmlParamsParser
  config.api_only = false


Bug with custom attributes when translating to DocBook

Thanks for all your fixes. I've noticed a strange bug when using asciiidoctor-bibliography to convert to DocBook. The following works fine:
:bibliography-database: refs.bib
:bibliography-style: ieee
...
Look for further information in the GNU Make manual cite:[GMAKE].
Some text.
#Some highlighted text.#

But if I replace the last line with:
[.sb]#Some text in semibold#.

Asciidoctor-bibliography gets confused, the DocBook output is:
<simpara>Look for further information in the GNU Make manual <link
linkend="bibliography-default-GMAKE"><phrase role="1]</link>.
Some text.
[.sb">Some text in semibold.</phrase></simpara>"""

Sorry for some minor misspellings above, it shall be
[.sb]#Some text in semibold.#

And there are no triple quotes last in the translation.

@pela9 Thanks for the report!
I confirm this is a bug. I'm working on it in #103.

@pela9 v0.10.2 was just released to solve the issue.
Thanks for your detailed report!


Content of node not empty in spite of empty parent node

Hallo,
first of all thanks for your fantastic library, especially the parse tree and ABNF parts are quite helpful. I'm new on PEGTL and currently implementing a large grammar with PEGTL 2.8.1 and Visual Studio 16.4.6.
Doing this some problems are arising. Therefore here a reduced example:
#include <tao/pegtl.hpp>
#include <tao/pegtl/analyze.hpp>
#include <tao/pegtl/contrib/parse_tree.hpp>
#include <tao/pegtl/contrib/parse_tree_to_dot.hpp>

namespace peg = tao::pegtl;

namespace grammar {

  template< char... Cs > struct padded_keyword : peg::pad<peg::keyword<Cs...>, peg::space> {};
  template< char... Cs > struct padded_one : peg::pad<peg::one<Cs...>, peg::space> {};

  struct IDENT : peg::pad< peg::identifier, peg::space > {}; // allow whitespaces
  struct entry : peg::seq< IDENT, IDENT > {};
  struct entry_list : peg::star< entry, padded_one< ';' > > {};
  struct composition : peg::seq< entry_list, padded_keyword< 'f', 'u', 'n', 'c', 't', 'i', 'o', 'n' > > {};
  struct function : peg::seq< composition, padded_keyword< 'e', 'n', 'd' > > {};

} // namespace grammar

int main(int argc, char** argv)
{
  if (peg::analyze< grammar::function >()) {
    std::cerr << "analyze() found errors in grammar." << std::endl;
    return 1;
  }

  peg::memory_input<> in(
    "function\n"
    "end\n"
    "\n",
    "source");

  try {
    const auto root = peg::parse_tree::parse< grammar::function >(in);
    if (root == nullptr) {
      std::cerr << "parse() failed: root is nullptr" << std::endl;
      return 1;
    }
    peg::parse_tree::print_dot(std::cout, *root);
  }
  catch (const peg::parse_error & e) {
    const auto p = e.positions.front();
    std::cerr << e.what() << std::endl
      << in.line_at(p) << std::endl
      << std::string(p.byte_in_line, ' ') << '^' << std::endl;
    return 1;
  }

  return 0;
}

Here the output:
digraph parse_tree
{
  x000002B628295B30 [ label="ROOT" ]
  x000002B628295B30 -> { x000002B628295DE0 }
  x000002B628295DE0 [ label="struct grammar::function\nfunction\nend\n\n" ]
  x000002B628295DE0 -> { x000002B628295880, x000002B6282A9390 }
  x000002B628295880 [ label="struct grammar::composition\nfunction\n" ]
  x000002B628295880 -> { x000002B628293FA0, x000002B6282A3C50 }
  x000002B628293FA0 [ label="struct grammar::entry_list\n" ]
  x000002B628293FA0 -> { x000002B6282A91A0 }
  x000002B6282A91A0 [ label="struct grammar::entry\nfunction\nend\n\n" ]
  x000002B6282A91A0 -> { x000002B6282A9770, x000002B6282A52E0 }
  x000002B6282A9770 [ label="struct grammar::IDENT\nfunction\n" ]
  x000002B6282A9770 -> { x000002B6282A9840, x000002B6282A5210 }
  x000002B6282A9840 [ label="struct tao::pegtl::ascii::identifier\nfunction" ]
  x000002B6282A5210 [ label="struct tao::pegtl::ascii::space\n\n" ]
  x000002B6282A52E0 [ label="struct grammar::IDENT\nend\n\n" ]
  x000002B6282A52E0 -> { x000002B6282A3EB0, x000002B6282A3F80, x000002B6282A3B80 }
  x000002B6282A3EB0 [ label="struct tao::pegtl::ascii::identifier\nend" ]
  x000002B6282A3F80 [ label="struct tao::pegtl::ascii::space\n\n" ]
  x000002B6282A3B80 [ label="struct tao::pegtl::ascii::space\n\n" ]
  x000002B6282A3C50 [ label="struct grammar::padded_keyword<102,117,110,99,116,105,111,110>\nfunction\n" ]
  x000002B6282A3C50 -> { x000002B6282A54E0, x000002B6282A55B0 }
  x000002B6282A54E0 [ label="struct tao::pegtl::ascii::keyword<102,117,110,99,116,105,111,110>\nfunction" ]
  x000002B6282A55B0 [ label="struct tao::pegtl::ascii::space\n\n" ]
  x000002B6282A9390 [ label="struct grammar::padded_keyword<101,110,100>\nend\n\n" ]
  x000002B6282A9390 -> { x000002B6282A6660, x000002B6282A6B40, x000002B6282A6320 }
  x000002B6282A6660 [ label="struct tao::pegtl::ascii::keyword<101,110,100>\nend" ]
  x000002B6282A6B40 [ label="struct tao::pegtl::ascii::space\n\n" ]
  x000002B6282A6320 [ label="struct tao::pegtl::ascii::space\n\n" ]
}

Now I'm wondering why "entry_list" has empty content but "entry" contains
function
end

Can anybody give me a hint?
Regards
Ingo

That is a bug. The problem is that the star-rule always succeeds. In this case, however, star<A,B> could leave remnants of A even though B didn't match. The problem goes away if you use star<seq<A,B>> but, of course, that should not be necessary.
I'll try to find a fix...

Thanks for the fast answer. In the meanwhile I will integrate your workaround into abnf2pegtl and see if I get my large grammar run ...

We have identified a couple of potential solutions, however at the moment they all seem somewhat involved. We will take a bit of time to see how best to proceed. Hopefully the work-around with additional seq<> rules allows you to continue for now.

I committed a fix in the master branch. Can you try if it works for you? Do you need the fix to be backported to the 2.x branch?

Thanks for the fix. I tested it with the example and it works as expected.
Implementing my large grammar I found another issue #199.
According to 2.x: It depends on when you are planning to release 3.0.0 and if the master is already somehow stable.
From my side, I'm integrating your library the first time in our software and I'm able to wait 2-3 month for the 3.0.0.
Thanks a lot for your great work.

Thanks for checking. For now, we will continue to improve the fix in the master branch, but ultimately I'll try and backport it, if possible, when it stabilized for those users still stuck on C++11.
About the release date of the 3.0.0: Colin and me talked about it yesterday and once this issue is fully resolved (there might be a few more corner cases that we need to discuss), we will release 3.0.0. It is already stable for quite some time now and any additional (API-changing) features will have to wait for a future 4.x.


Need more writers

@jonas-schievink, @lthiery, and @dbrgn:
For redundancy, I have added @hannobraun as a maintainer to this repository. I figured it's a good idea to have a backup person just in case. This action was purely made to give someone other than myself (who's also active in the embedded Rust community) access to the repository.
That said, your contributions to this repository have been critical to its growth and I would like to ask if any of you are interested in having Writer access. If you feel you'd make for a good maintainer as well, I'm open to that too.
My goal here is to avoid getting in the way of progress because I'm too busy to review PRs.
I trust your judgement and believe the peer-review method we've been exercising thus far (i.e. - asking one another to sanity check code) is good enough for now. If things gets out of hand, we can always strategize a new plan.
Please let me know your thoughts.
Regardless of your answer, I'm grateful for your contributions! Thanks!

Thanks @arkorobotics for the offer :slightly_smiling_face: I'm happy to help with reviews and triaging of issues, however I still have to learn a lot about embedded software development (I'm a high-level software engineer by trade) and am not yet familiar with all the peripherals that ARM microcontrollers have. So feel free to add me to the project if you trust me, but I'd probably refrain from merging PRs myself :slightly_smiling_face:

Done! Welcome aboard!
Funny enough, I made a similar point Hanno that I'm just an electrical engineer with a background in circuit design and robotics, and that this HAL is just a hobby to me. I guess we're both flying by the seat of our pants here!

And I'm just some undifferentiated software developer who one day decided to specialize on embedded Rust, so... :-)


Fix dependency vulnerabilities in source packages

You can find patched security vulnerabilities in this fork repo - https://github.com/arpitjain099/palantir-python-sdk/pulls?q=is%3Apr+label%3Adependencies+is%3Aclosed
It is important to merge this as this SDK gets used by other developers as well.
Type

[x]  Improvement
[x]  Fix

Description Fix dependency vulnerabilities in source packages

[x]  Generate changelog entry

You can find patched security vulnerabilities in this fork repo - https://github.com/arpitjain099/palantir-python-sdk/pulls?q=is%3Apr+label%3Adependencies+is%3Aclosed
It is important to merge this as this SDK gets used by other developers as well.
Type

[X]  Improvement
[X]  Fix

Description Fix dependency vulnerabilities in source packages

[X]  Generate changelog entry


Upgrade bridge to latest version

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
Upgrade bridge to latest version
Affected area/feature

https://github.com/pulumi/pulumi-terraform-bridge/releases/tag/v3.49.0 would be most helpful.


Broken OAuth flow

I tried using the new OAuth flow. After accepting app access to my github data, I got redirected here:

Went back to Code, clicked refresh int he splitview header, got this:

Reloaded, expanded Assigned To Me, got the Login again, but this time it worked:

Thank you for testing this! I think perhaps the connection timed out between you initiating the login and accepting it, which is why it gave that cryptic error. You should have gotten an error message on the vscode side about the authentication failing, before you hit refresh, did you see it by any chance?

Unfortunately I didn't see it...

I've opened #188 and #189 to add more commands and UI to the authentication flow, and I've updated the web UI so it's less cryptic. I'm pretty sure this was a timeout issue, and there's not a lot I can do about that other than direct the user to try again (and having a command on vscode plus some more UI will hopefully help with that).


fix(#minor); Compound forks; use getMarketHourlySnapshotID function

nice catch!

@0xbe1 this should either be #patch and change and increment the version or nothing in (), but the change lgtm.

@dmelotik updated pr description


Register multiple callbacks to modals

Short description of what this resolves:
These changes allows for registering multiple listeners for onDidDismiss and onWillDismiss. It is backwards compatible and does not require any changes to registering.
This is useful for situations where you would want to build a provider (for example 'modalmanager') that serves a modal to another provider, where both providers want to register to onDidDismiss or onWillDismiss.
Changes proposed in this pull request:

Register multiple callbacks to onDidDismiss
Register multiple callbacks to onWillDismiss

Ionic Version: 3.x
Fixes: #

Any reason not to use EventEmitters instead? (already known to work, has support for subscribing and unsubscribing, and everyone knows them)

You've got a good point there. I thought it would be best to have backwards compatibility here, but we could also implement it both ways: support the current way and have extra event emitters. This way it would also not break existing apps relying on the current behaviour.
Will update my code accordingly within 2 days!

I did update my code to do the changes I hoped for, but also be fully backwards compatible for apps that rely on the current behaviour.
Therefore, the branch currently has the following changes:

Register multiple callbacks to onDidDismiss
Register multiple callbacks to onWillDismiss
Fully backwards compatible

Example code:
let modal = new MultiModal( LoginPage, {}, {} );
//Old way of registering
modal.onDidDismiss( (data: any, role: string) => {
    console.log('the old way of registering an event, still works as this is fully backwards compatible!');
} );
//New way of registering (multiple/extra handlers)
modal.onDidDismiss().subscribe((event: (data: any, role: string)) => {
    console.log('the new way of registering an event, handler 1!');
} );
modal.onDidDismiss().subscribe((event: (data: any, role: string)) => {
    console.log('the new way of registering an event, handler 2!');
} );

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!


feat: add tes token

Description
This PR adds a parameter for forwarding a JWT to a TES instance for authentication.
QC

[x] The PR contains a test case for the changes or the changes are already covered by an existing test case.
[x] The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

Thanks! One thing: when configuring like this, the token ends up in the shell history. I think it is better to use an environment variable for this instead of a CLI arg. Is there a default env var used in TES implementations already? If not we could name it just TES_TOKEN?

Hi Johannses, thanks for the review. Do you think, using env vars is required? Using an arg was in accordance to cwl-tes (see here: https://github.com/ohsu-comp-bio/cwl-tes). We also do not see a big security risk as the tokens' validity is generally short. E.g. in WESkit we document arguments as well as env vars that are set by the users anyhow.

Mhm, I think an env var is indeed better here. Also, it can be more convenient because it can be set without needing to tell it to Snakemake upon each invocation.

Thanks! One thing: when configuring like this, the token ends up in the shell history. I think it is better to use an environment variable for this instead of a CLI arg. Is there a default env var used in TES implementations already? If not we could name it just TES_TOKEN?

solved - added env var and documentation

@johanneskoester all is resolved - can we merge now?

Mhm, I think an env var is indeed better here. Also, it can be more convenient because it can be set without needing to tell it to Snakemake upon each invocation.

done

Thanks! One thing: when configuring like this, the token ends up in the shell history. I think it is better to use an environment variable for this instead of a CLI arg. Is there a default env var used in TES implementations already? If not we could name it just TES_TOKEN?

done

Thanks a lot!


Add ability to cast videos to smart devices

Implement a "cast" button (similar to the one that shows up on YouTube and Netflix) when you're connected to a wifi network with devices that can be cast to (Roku box, PS4, Xbox, Plex server, etc.).
Acceptance Criteria

Definition of Done

[ ]  Tested against acceptance criteria
[ ] Tested against the assumptions of the user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

Oh yes please, this would be fantastic.

If anyone is interested in giving it a go, there is a library to enable Cast capabilities for android apps. Plex has a fork of it whit several commits ahead:
https://github.com/plexinc/CastCompanionLibrary-android

Common almost four years have past from the initial request ...
LBRY/ODYSEE has gone way ahead since then, but unfortunately the mobile client it is still crap, it misses major functionality like able to cast any device at all!
That is is getting really ridicules for the number 2 streaming platform ...

I want to contribute to this but before implementing this feature app needs to register on the following link https://cast.google.com/publish/#/signup

I want to contribute to this but before implementing this feature app needs to register on the following link https://cast.google.com/publish/#/signup

I don't think that will be possible. Google banned Lbry from the play store.

I want to contribute to this but before implementing this feature app needs to register on the following link https://cast.google.com/publish/#/signup

I have not drilled into the requirements official Chromecast SDK, but libvlc can cast to chromecast without requiring any sort of Google registration and is available for android , ios.
It can also cast to varius UPnP renderers as a bonus.
https://www.videolan.org/vlc/libvlc.html

Registering on Google Cast website is only required when the user-visible UI is customized. It is not needed in order to just show content


Configure dbconfig.xml parameters explicitly to stop JIRA's healthcheck from complaining

Turns out JIRA works without these, but will complain, at least on
some versions. Also make the approach to variable naming a bit more
consistent.

Ref in atlassian doc. Apparently the part of documentation I was reading previously that talked about default values doesn't apply?
https://confluence.atlassian.com/jirakb/database-connection-settings-healthcheck-fails-in-jira-server-792636748.html

Note that I chose to use pick in jira::config´ instead of putting the defaults in init.pp`'s parameter list because that way the rest of the code is consistent and all the related logic is in the same place.


[BUG/Missing] [BK7231N / CB3S] deep sleep support

Hello,
I'm experimenting with libretiny and a battery powered door/window sensor.
My initial tries were done using OpenBeken, documented on this page:
https://www.elektroda.com/rtvforum/viewtopic.php?p=20586001#20586001
It uses the CB3S board with a BK7231N chip and no additional Tuya MCU, running on a battery.
After finding out about libretiny I wanted to give it a try as well.
So far the sensors work fine and connections can be established fast.
Deep Sleep support seems to be missing though.
The chip supports wake up on pin interrupt like ESP32, but it is not supported on libretiny yet.
And even when using the regular time based deep sleep it instantly wakes up again:

[08:02:52][C][lt.component:013]: LibreTiny:
[08:02:52][C][lt.component:014]:   Version: 1.0.2+sha.5c4da6e
[08:02:52][C][lt.component:015]:   Loglevel: 3
[08:02:52][C][deep_sleep:049]: Setting up Deep Sleep...
[08:02:52][C][deep_sleep:052]:   Sleep Duration: 300000 ms
[08:02:52][D][api:102]: Accepted <IP_ADDRESS>
[08:02:52][D][api.connection:958]: Home Assistant 2023.5.4 (<IP_ADDRESS>): Connected successfully
[08:02:53][D][sensor:102]: 'battery_adc': Sending state 329.00000 V with 0 decimals of accuracy
[08:02:53][D][sensor:102]: 'Battery Voltage': Sending state 2431.39038 mV with 0 decimals of accuracy
[08:02:53][D][sensor:102]: 'Battery Level': Sending state 28.92380 % with 0 decimals of accuracy
[08:02:53][D][main:098]: Updated battery
[08:02:53][I][deep_sleep:116]: Beginning Deep Sleep
[08:02:53][I][deep_sleep:118]: Sleeping for 300000000us
[08:02:53][D][lt.preferences:104]: Saving 1 preferences to flash...
[08:02:53][D][lt.preferences:132]: Saving 1 preferences to flash: 0 cached, 1 written, 0 failed
INFO Processing expected disconnect from ESPHome API for <IP_ADDRESS>
WARNING Disconnected from API
INFO Successfully connected to <IP_ADDRESS>
[08:02:57][D][sensor:102]: 'battery_adc': Sending state 328.00000 V with 0 decimals of accuracy
[08:02:57][D][sensor:102]: 'Battery Voltage': Sending state 2424.00000 mV with 0 decimals of accuracy
[08:02:57][D][sensor:102]: 'Battery Level': Sending state 28.00000 % with 0 decimals of accuracy
[08:02:57][D][main:098]: Updated battery
[08:02:57][I][deep_sleep:116]: Beginning Deep Sleep
[08:02:57][I][deep_sleep:118]: Sleeping for 300000000us
[08:02:57][D][lt.preferences:104]: Saving 1 preferences to flash...
[08:02:57][D][lt.preferences:132]: Saving 1 preferences to flash: 0 cached, 1 written, 0 failed
INFO Processing expected disconnect from ESPHome API for <IP_ADDRESS>
WARNING Disconnected from API
INFO Successfully connected to <IP_ADDRESS>
[08:03:01][D][sensor:102]: 'battery_adc': Sending state 328.00000 V with 0 decimals of accuracy
[08:03:01][D][sensor:102]: 'Battery Voltage': Sending state 2424.00000 mV with 0 decimals of accuracy
[08:03:01][D][sensor:102]: 'Battery Level': Sending state 28.00000 % with 0 decimals of accuracy
[08:03:01][D][main:098]: Updated battery
[08:03:01][I][deep_sleep:116]: Beginning Deep Sleep
[08:03:01][I][deep_sleep:118]: Sleeping for 300000000us
[08:03:01][D][lt.preferences:104]: Saving 1 preferences to flash...
[08:03:01][D][lt.preferences:132]: Saving 1 preferences to flash: 0 cached, 1 written, 0 failed
INFO Processing expected disconnect from ESPHome API for <IP_ADDRESS>
WARNING Disconnected from API

Device config:
bkwindow1.yaml.txt

Correct - deep sleep is not supported yet. It will be, in the future. Let's keep this issue open.

Thanks for the reply kuba!
I could try using my device to replicate the OpenBeken implementation and make it available for the BK7231N platform similar to ESP32.
Does it make sense to do this in this repo, or do you plan to shut it down once it has been merged into esphome? (I'm following the integration ticket there)

This repo, the one where you're posting this issue (kuba2k2/libretiny) will stay - it's the base platform of the port.
The kuba2k2/libretiny-esphome repo will be outdated as soon as it gets merged into ESPHome upstream.
However, adding new features like this needs to be done in both of these repos. The base platform needs to expose a common API (C/C++ headers and classes) for a particular feature. Then, it can be implemented within the ESPHome HAL.

Oh dang.. should have noticed this.. Sorry, I got confused with the repo links. In that case I'll have a look if I can get something in. Worst case will have to wait for another contributor with more knowledge of the code base.
Thanks for the clarification!


[sort-imports] update keyvault-secrets with respect to sort-imports rule

This PR is working in conjunction with other PRs to fix individual sections of the azure codebase with respect to the new sort-imports rule, as indicated in #9252.
In this PR, I have fixed all files under sdk/keyvault/keyvault-secrets.

Looks great @bzhang0 ! Thank you for your contribution!
I am hesitant to approve due to the large number of conflicts - but once you resolve all merge conflicts I'll be happy to review again 😄

Hi @maorleger - apologies for the late response! I'm just starting to fix these merge conflicts. I'm having some trouble understanding the syntax of merge conflicts, and I think it may be misleading me when understanding what really changes.
Consider the following conflict in sdk/keyvault/keyvault-secrets/test/public/list.spec.ts:
<<<<<<< sort-imports--keyvault-secrets
import * as assert from "assert";
import { Recorder, env, isRecordMode } from "@azure-tools/test-recorder";
=======
import { assert } from "chai";
>>>>>>> main
import { Context } from "mocha";
import { SecretClient } from "../../src";
<<<<<<< sort-imports--keyvault-secrets
import TestClient from "../utils/testClient";
import { assertThrowsAbortError } from "../utils/utils.common";
=======
import { assertThrowsAbortError, getServiceVersion } from "../utils/utils.common";
import { testPollerProperties } from "../utils/recorderUtils";
>>>>>>> main
import { authenticate } from "../utils/testAuthentication";
import chai from "chai";
import { testPollerProperties } from "../utils/recorderUtils";

I understand that this means there are conflicts between the current branch I'm in and the main branch that I'm trying to merge into. However, because git compares my branch (which has sorted the imports already) to the main branch (which has updated imports but aren't sorted), it seems like it ignores some imports. If I were to accept all these merges, I lose out on import TestClient from "../utils/testClient";, for example (line 13). You can see these are present within the main branch (line 13 here) and the branch I'm in currently (line 8 here).
I assume the best way to approach this would be to revert each file one at a time to the main branch's version, then sort it again. What kind of command can I use to do this?

I've fixed the merge conflicts for this branch, but I'd still really appreciate some guidance for approaching future merge conflicts in other branches! I will continue to look into this myself as well. Thank you!

I assume the best way to approach this would be to revert each file one at a time to the main branch's version, then sort it again. What kind of command can I use to do this?

I usually look at the changes in both branches and make edits to ensure intended changes from both are included.  Sometimes it's easier to take changes from main and add my changes. Sometimes it's the other way.  For simple ones the web UI at github.com may be good enough but often I need to use diff/merge tools or edit the affected file locally then push the updates.
There are some recommended merge tools at https://stackoverflow.com/questions/137102/whats-the-best-visual-merge-tool-for-git