💄Improve Docker module UI

Category

UI and code fix

Overview

Change appearance of Docker containers table such as buttons behavior and position. Also fix a problem with i18n on DockerActionBar and change DockerSingleton file's extension from .tsx to .ts (because no React stuff inside).

Screenshot

Why is the button to add to homarr inside the row?
Also could you write code to remove the image and ports rows if the user is on mobile ? Vue width < 900 px should do the trick.
This way the UI would be useable on mobile

Ideally @Skeeww if you want the UI to really be better you could make it so a mantine Menu is showed on right click on a line (context menu)
I believe this would be a nicer way to control containers. But it's harder to code.

Why is the button to add to homarr inside the row?
Also could you write code to remove the image and ports rows if the user is on mobile ? Vue width < 900 px should do the trick. This way the UI would be useable on mobile

The button add to homarr is inside the row because we allow only one container at the time to be added to homarr. Instead of ticking the container and click on "add to homarr" we just have to click on "add to homarr" button on the container of our choice.
Yep no problem, I'll fix the responsive issues.

Ideally @Skeeww if you want the UI to really be better you could make it so a mantine Menu is showed on right click on a line (context menu) I believe this would be a nicer way to control containers. But it's harder to code.

Looks like a great idea

Why is the button to add to homarr inside the row?
Also could you write code to remove the image and ports rows if the user is on mobile ? Vue width < 900 px should do the trick. This way the UI would be useable on mobile

The button add to homarr is inside the row because we allow only one container at the time to be added to homarr. Instead of ticking the container and click on "add to homarr" we just have to click on "add to homarr" button on the container of our choice.
Yep no problem, I'll fix the responsive issues.

I think I prefer it the old way. It makes the UI lighter. We could allow multiple selection and just "queue" the modals by using Mantine's modal manager by pushing a modal instead of having it on the page. It would also fix the issue of all the images loading and service matching before clicking that button, currently they are all loaded "in case" we want to add them to homarr (because the modal is on the component, just hidden)

Reviewing this now and changing things

I will do these changes now @Skeeww

@Skeeww I've made the changes. Continue on #393 if you want to 😄

@Skeeww I've made the changes. Continue on #393 if you want to 😄

Alright let's go 😎


word_dict_0.js code in ipython

Hi,
It would be nice to have the code to convert the result to word_dict_0.js file, not sure if i am missing anything. Also code for creating the segment table.

It's in the last of this file.


Dynamic values doesn't update and the initial value has replaced always at runtime

Describe the bug
I am using VS2019 preview 4.0 and dotnetcore rc1 version 3.0.
But, I have a bug with the following code.
<Canvas @ref="@canvas" Width="1500" Height="700">
   <Node @ref="node" X="100" Y="100" Width="100" Height="100"></Node>
</Canvas>

@code{
    Node node;
    Canvas canvas;
    Node node;
    public void UpdateWidth()
    {
        node.Width = 200;
        StateHasChanged();
    }
}

In the previous code, I have tried to change the “width” value of the node object, but immediately it reset to initialized value of “100” always.
It is working fine if I use the code as follows.
<Canvas @ref="@canvas" Width="1500" Height="700">
   <Node @ref="node" X="100" Y="100" Width="@width" Height="100"></Node>
</Canvas>

@code{
    float width = 100;
    Canvas canvas;
    Node node;
    public void UpdateWidth()
    {
       width = 200;
       StateHasChanged();
    }
}

Expected behavior
Our requirement is providing multiple child elements for root parent like above and we cannot provide property bind options for each property like x, y, width, height, and more for each child or nested child elements like node object.
So, is there any other solution for this issue? Or
is this a behavior of the Blazor control?
Additional context
Sample Project : https://github.com/Naganathan/SampleObjectDragging

Hi,
That's not the idiomatic way of achieving what you want in Blazor. You see the value always go back to  Width="100" because that's what it's being defined in the view.
When  UpdateWidth is invoked you set the value for Width of the current child component to 200, but then when StateHasChanged is run the parent page re-renders the component and sets the width to 100 again as defined in the view.
To accomplish what you are trying to achieve you should do something like
<Canvas @ref="@canvas" Width="1500" Height="700">
   <Node<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS></Canvas>

@code{
    NodeModel node = new NodeModel{
        Width = 100,
        Height = 100,
        X = 100,
        Y = 100
    };
    Canvas canvas;
    Node node;
    public void UpdateWidth()
    {
        node.Width = 200;
    }
}

I'm not sure I understand what you are doing as it is not a trivial component. From what I understand you compute the node being selected when the user click, update the position while you drag it and then i'm not sure what happens when you stop dragging it.
From what I see in your code you might be missing some @ in the property values https://github.com/Naganathan/SampleObjectDragging/blob/master/Pages/Canvas.razor#L25

Could you please confirm us that the property should only be updated with property binding for initial rendering nodes?

Bind hooks to OnChange and keeps the attribute value you are binding in sync with the instance you bind it to. If you don't want that behavior don't use @bind and simply set the values with value=@expression
does that anwer your question?


Popover toolbar item with hover interaction has a bug

https://react-science.pages.dev/stories/?path=/story/components-toolbar--control&args=popoverInteractionKind:hover
https://github.com/user-attachments/assets/9cd0f2d8-919d-4df8-80c3-5196e9c3179c

The bug was introduced by https://github.com/zakodium-oss/react-science/pull/756


Use extension from the json to define the asset extension to be loaded.

Changelog Description
This PR is to use extension from the json to define the asset extension to be loaded. Instead of using the current ayon setting to define the asset extension to be loaded, it would take the data from the json to tell unreal to load the assets in certain extension. The current ayon setting of "loaded asset extension"(which is renamed to "Priorized Loaded Asset extension"), is used as defining the loaded extension when the files are at the extension such as "ma" file.
Additional info
Test along with this PR: https://github.com/ynput/ayon-maya/pull/104
If users publish both fbx and abc representation with the assets, unreal would load fbx instead of abc as it saves more time to load the asset during loading layout.
Testing notes:

Load Layout
Should be all loaded as expected.

I have successfully loaded the Layout no any errors shown, but all my assets being FBX even tho just several assets having extension as FBX within the JSON for layout.
seems like its not taking it into account when loading assets (their extension)

If all assets are in fbx, then the extension in each asset would be labeled as fbx. If all assets are in abc, then the extension in each asset would be labeled as abc. If some assets are in fbx and some assets are in abc, some assets are loaded in fbx while some are loaded in abc.

@moonyuet yeah I have produced new JSON with mixture od representations (using that ayon-maya PR which feature it) so, it is malfunctioning atm (not taking the correct repre into account)
enclosing my JSON of layout I have used for checking....
QD_sh010_layoutMain_v011.json.txt

@LiborBatek can you test it again?

No I havent experienced any duplicated assets (but I already report about it and that its fixed) but Im more refering to mixture of repre within the Layout comming from maya as seen here:

as the repre type been written into JSON Im expecting it will succesfully propagate and load accordingly using those repre types (not just all in FBX or ABC)

https://github.com/user-attachments/assets/a26f8814-f3aa-45d1-9701-685e1cbd2b9b
@LiborBatek, I have done some tests on my side and it seems working. The only thing user needs to keep in mind is unreal would always load the fbx first during loading layout even when users have published alembic as it loads fbx way faster than abc.
This occasion only happens when users are publishing the assets in both fbx and abc formats at the same time.

I agree that it shouldn't ignore default settings and user settings - it should always respect those. And yes, we can have fbx as default option.
Question is - as @LiborBatek stated - what to do if the representation is missing in selected format. I propose to have "force load" option that if enabled, it will try to load the layout no matter of what without asking artist.
Keep in mind, that loader should be executed non-interactively. So if loader stops loading and asking artist for options, this is no-go. Only if the logic is much more sophisticated so we can detect interactive and non-interactive use (and I don't think we can do that right now).
In that light, I think "force load" should be on by default and the loader should produce warnings about instances loaded in different format.

Im also really confused by the option dialog with
Force load assets with loaded asset extension it should be more clear what it does and more simple...
Interestingly it did not take any effect too when choosing ABC in above option, it still brought in FBX not forcing anything.
I guess its a option just when missing repre but this is not communicated well (beside tool tip when hoovering over it.)
If I get it correctly, it should force load the available repre instead (if the prefered is missing) or?
If so, I would rather name it something like:
Force load available extension when missing asset.

@LiborBatek The updated commit should be loading the asset data accordingly to the extension from the json if the force-loaded is enabled.
Take this example below (screenshot from maya)
This is the loaded asset I want to export from maya to unreal

For modelSimple instance, it has been published with both abc and fbx format. The updated commit would load the object in abc format as shown in the recording below.
https://github.com/user-attachments/assets/db30db8e-f6bc-4072-a00b-bd93a9d95b84

Im also still thinking about the options when performing Load Layout (JSON) as they seems to be not so useful in the end...

As now the load action will bring whatever is written in the JSON file (repre types) which is good! But when playing with those options, I always get the same result and honestly there wont happen occasions for using them in the end as when some exact repre type been written to the Layout JSON its originated from maya and from loaded products (so they have to exists in that particular repre type for sure) ...what happens then in UE, no matter how these options set during Load Layout, it will always bring those missing repres into UE automatically resulting into exact match aka 1:1 (maya layout / UE layout - repre wise) ...so these wont actually make any change when using...
So what I propose to use those options for force load that repre type no matter what...so user can force the repre type via them basically ignoring what kind of repre been in the JSON, otherwise it looses any purpose imho.
@moonyuet  @antirotor what do you think? opinions?

Im getting one asset duplicated  during Load layout (JSON) for some reason..even tho its just one within the JSON which I am enclosing too

QD_sh010_layoutMain_v011.json.txt
its the MainChamber_modelMain asset


Bug in CSSmin

In the included CSSmin version is a bug that causes colors to be shortened when they are not actually colors. This bug has been fixed in newer versions of CSSmin. For more details tubalmartin/YUI-CSS-compressor-PHP-port#39.
Could you please update the dependency so that the fixed version is used?

@mrclay pushed two commits to master branch, but i see there's also 3.x branch. should it be merged? i suggest drop the 3.x branch, and keep 2.x and master only as the current way is confusing.
also there's milestone 3.0 which is expired. i suggest renaming it to 3.0.0 and close it

My plan was: 3.x is for fixes and new features. master for breaking changes.

would you please merge to proper branches and write down in readme your development model. currently seems my changes went to /dev/null.
altho as this project does not have active development, to avoid confusion, i'd ditch 3.x branch and keep just master, and 3.x releases cut from master.

Sounds good. I'll get to this later.

ping

Hi @mrclay, just pinging so you consider updating CSSmin lib version to v3.3.x or v4.x. v2.4.x branch should be considered buggy and obsolete.
v3.3.x and the new v4.x are the most stable by a large margin.

Ping once again, can you do a release with the correct patch applied?

See #599


Why does this log directory generate so many core files?

The service has crashed. You can use the file command to check which service has crashed.Memory is recommended to use 2 core 4G at least.

服务崩溃了，可以使用file命令检查是哪个服务崩溃了。内存建议至少使用2核4G。


Weird  behavior  about "Apply" button in preference page

Windows 11 x64
foobar2000 v2.0 x64
foo_midi v<IP_ADDRESS> x64
Normally, "Apply" button is greyed out when there are no changes in preference page.
If navigate to preference->Playback->Decoding->MIDI Player, the "Apply" button will available immediately.
Now, the "Apply" button will never go greyed out whatever you click it or even switch to other page until open preference page next time(not on "MIDI Player" page defaultly).
However "Apply" button still take effect.

Thx. for the report. Probably a bug in the state reporting. I'll look into it.

Fixed in v<IP_ADDRESS>.

Fixed in v<IP_ADDRESS>.

Hi. Dear stuerp. I still encounter this issue in v<IP_ADDRESS>.

Should be fixed in alpha7.

Hi. Dear stuerp. I can confirm that this issue fixed in alpha 7.
but change "BASS MIDI" --> "Volume" input field can't trigger "Apply" button active, and "OK" button don't save if only change "Volume" field.
other input field like "Sample rate" or "Decay time" is OK.

You're right. Fixed in the next release.

Released as v<IP_ADDRESS>.

Hello, dear stuerp. @stuerp
This issue again in 'processing' sub page on version <IP_ADDRESS>

Fixed: Apply button remained active even if nothing was changed. (alpha7)

Fixed in v<IP_ADDRESS>


do apply patch not work

What happened:
Some description not patch
What you expected to happen:
Patch apply success
How to reproduce it (as minimally and precisely as possible):

a crd gvk which in description not registered into k8s
this crd annotation does not have original data

we will get an nil patch ({}) , but return nil
https://github.com/clusternet/clusternet/blob/main/pkg/utils/deployer.go#L610

Import from   #666

cc @abstractmj


localize does not seem to run anymore duing boot

The localize script does not seem to run anymore duing boot. Neither live nor installed. Unless running it manually. Why?

Related?
% sudo service localize enabled
/usr/local/etc/rc.d/localize: WARNING: $ is not set properly - see rc.conf(5).

Check #212.

Closed?

Yes, I can verify that this solevd it.
Thank you so much @linuxkettle this really frustrated me a lot, so glad you were able to find a solution. :+1:


test(e2e): take element screenshot directive

Closes: #2266

:tada: This PR is included in version 5.0.0-beta.17 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.17.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Create loader abstract factory pattern

In GitLab by @fbastian on Aug 19, 2015, 12:25
Create an abstract factory pattern for the loaders.

In GitLab by @fbastian on Sep 8, 2015, 17:50
It was decided NOT to use an abstract factory pattern. And Loaders will be renamed Service

In GitLab by @fbastian on Sep 9, 2015, 24:04
mentioned in commit 15c75ffd23b672870de58c15803b3a8901b86484

In GitLab by @fbastian on Sep 9, 2015, 21:01
See 15c75ffd and 4f6a3bbd.


Update magic.py

update offset for game version <IP_ADDRESS>
test well for 3440*1440 in my pc

I can confirm it works for 2560*1080

mpm11011 is now dynamic search for hex address now.
I think my pr is useless now

I gotta get better about checking GitHub... completely missed this. Please let me know if the dynamic search works!


Fix leaks in map-layers-formats tests

@Jake-Screen was finally able to reproduce locally and we got:

So I made sure the tests never reach 'fetch'

@aruniverse please review


ModuleNotFoundError

ModuleNotFoundError: No module named 'palworld_save_tools'
How can I fix this error?
Please help

I already installed the 0.17.1 but still same error code

I am facing the same problem, I have installed tvdatafeed and the terminal shows all requirements satisfied. But when I run the code (the code is correct) it gives me this error

I had this error when I did pip install palworld-save-tools==0.17.1, but NOT when I did python -m pip install palworld-save-tools==0.17.1. Python has this hella annoying issue where if you have multiple Python versions, the python and pip can get out of sync. Maybe give it a shot?

Thank you
I solved the problem

I'll change the README to use this command instead, thanks!


OS X Plugin - "tab" command bug in iTerm

With the osx plugin using iTerm, the tab command opens a new tab and I can see the command (cd "/Users/mike"; clear; for example) entered but I have to hit return to get it to run. Terminal.app appears to be working correctly.
It might be as easy as adding a newline or something to the command on line 37 in the iTerm section
Thanks!

Which iTerm version does this affect <IP_ADDRESS>41103 or 2.9.20150221-nightly?

In <IP_ADDRESS>41103, it works without keystroke return.
In 2.9.20150221-nightly, the code doesn't work at all.

With just the following:
write text "Hello"

I get:
~ ❯❯❯ Hello
zsh: command not found: Hello


Microbeannotator database download error..

Traceback (most recent call last):
File "/home/adminuser/anaconda3/envs/microbeannotator/bin/microbeannotator_db_builder", line 18, in
from microbeannotator.database import conversion_database_creator as convert
File "/home/adminuser/anaconda3/envs/microbeannotator/lib/python3.7/site-packages/microbeannotator/database/conversion_database_creator.py", line 26, in
import wget
ModuleNotFoundError: No module named 'wget'
Hello Authors,
I am facing the above error while creating the database. I am trying to install the Microbeannotator in server wherein I cannot download the aspera connect so using the flag --no_aspera. I checked for the presence of wget in my server and it is present in /usr/bin/wget. So not able to resolve this error.
Please help me to solve this issue.
Thanking You
Sincerely,
Sowptika Pal

@sowptika Looks like your python environment is missing wget . Can you install  it with pip install wget  which hopefully resolves the ModuleNotFoundError: No module named 'wget'


Normal.log_cdf raises exception when called with float64

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Linux Ubuntu 16.04
TensorFlow installed from (source or binary):
Binary (pip)
TensorFlow version (use command below):
v1.12.0-0-ga6d8ffae09 1.12.0
Python version:
Python 3.6.4 :: Anaconda, Inc.

Describe the current behavior
Calling Normal.log_cdf(x) with a float64 raises a TypeError exception.
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
import tensorflow as tf

normal = tf.distributions.Normal(loc=0.0, scale=1.0)
normal.log_cdf(tf.constant(3.5, dtype=tf.float32))  # Operation created successfully as expected
normal.log_cdf(tf.constant(3.5, dtype=tf.float64))  # Exception

Exception is:

TypeError: Input 'y' of 'Sub' Op has type float32 that does not match type float64 of argument 'x'.

Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
trace.txt

(probably you want loc=np.float64(0.0), scale=np.float(1.0)) to make the Normal distribution's dtype float64.

Are you satisfied with the resolution of your issue? Yes No


New search link

User story
As a user, I want the ability to return to the search box on the welcome page so that I can do a new search.
Acceptance criteria

[x] Include a "Start Over" or a "New Search" link

Concrete example

Closed by #152


build: add conventional commits

Resolves #344
This PR enables check for commit messages.
There can be 2 flows:

When a new user git clones the project and runs yarn install then commit msg hook is installed in this postinstall script https://github.com/ubiquity/ubiquity-dollar/compare/development...rndquu:issue/344?expand=1#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R35
Existing users (who have already git cloned the project) have to manually run yarn postinstall in order to install commit msg hooks

Before this PR linter was not running in pre-commit hook, but now pre-commit hook is enabled and linter is running. I commented linter code because:

it is not clear what is the best strategy to run the linter
reenabling linter is out of scope of this task

P.S. I closed the previous PR https://github.com/ubiquity/ubiquity-dollar/pull/353 because it has conflicts in yarn.lock and after solving the conflicts the build fails due to https://github.com/ubiquity/ubiquity-dollar/issues/377

I wish there was a better solution for 2. Any ideas on how to enforce this? Perhaps we can on CI?

@rndquu can you suggest a way to enforce it in a github action ?

@rndquu anyway people can still bypass it if they want so for me it is fine we just have to check that commits are ok from time to time

I believe that we could fork a script somewhere (instead of handwriting a new one) to enforce in CI

I guess its hard for me to verify if the CI works because CI only runs from development
I suppose we could always merge and then finish on development if needed.

I guess its hard for me to verify if the CI works because CI only runs from development

CI action runs on PR to the development branch. So you pushed a commit https://github.com/ubiquity/ubiquity-dollar/pull/378/commits/6f0e4d2116d651af6122bc48c18feb01b35e5733 which expectedly failed the CI action because of invalid commit msg name

Does CI only check the latest one?

it runs on all commit messages

What happens if the bounty hunter has a ton of non-compliant commits previously?

This will be hard to solve. Bounty hunter will have to squash all PR commits into a single one with a valid commit msg, smth like git reset --soft HEAD~3 && git commit -m "feat: new feature"

This will be hard to solve. Bounty hunter will have to squash all PR commits into a single one with a valid commit msg, smth like git reset --soft HEAD~3 && git commit -m "feat: new feature"

I have a feeling that this will be an issue in the future, but again I can't figure out a better solution for this 😰

Can you demonstrate what you need to do here? I enabled auto-merge so assuming that your next commit passes, you will be able to merge this in to complete the bounty!

@pavlovcik
FYI, this PR is somehow automerged even with failed CI check

There were 2 CI issues: unresolved conversations (https://github.com/ubiquity/ubiquity-dollar/pull/378#discussion_r1045203487) and failed CI action "Conventional Commits" because of your test commit with invalid message (https://github.com/ubiquity/ubiquity-dollar/pull/378/commits/6f0e4d2116d651af6122bc48c18feb01b35e5733)
Then I clicked "resolve conversation" and PR automatically merged even with failed CI action

This is a pretty weird behaviour of github or I just don't understand smth about "auto merges"
Anyway the PR was ready for merging

Looks like this became a bit of a mess.
You disabled the prettier again on the latest commit in the pre-commit hook, which should remain enabled. It's still unclear to me why you want to remove it. I think that linter/prettier should not be loosely enforced because then we will accrue formatting issues over time. Since the tools are automated, it shouldn't be burdensome for the developers working on the code either.
It looks like the CI didn't run on your latest commit so I presume that it only checks on the merge PR event instead of the commit event (like when you write a GitHub Action and how it is supposed to run "on pull_request" or "on commit") which could be after your CI is supposed to run or something. I am unsure.

You disabled the prettier again on the latest commit in the pre-commit hook, which should remain enabled

Where do you see it? This line https://github.com/ubiquity/ubiquity-dollar/blob/development/.husky/pre-commit#L4 is uncommented + I've just checked the latest build from development branch and lint-staged is running as expected on commit.

I realized I was looking at your first commit, not your latest - sorry!


Repeating Header and Section upon Scrolling in Variant section

When scrolling down the page, the "Variants" section, along with the header, repeats unexpectedly. This results in a duplicated appearance of the header and section content, which disrupts the user experience and causes visual clutter.

Please fix it. Also, if there are similar minor issues in other page please check nd fix it

The footer's UI broke issue is assigned to someone else, so other than footer if any issue like above, Please fix it @saadgibawa

@aslams2020 Okay

@aslams2020 Should I update the scroll to top button in this section to match the one on the homepage and other pages?

No, I have updated the one in the homepage. @saadgibawa

yes thats what i am saying that the button is different in variant section and appearances section also.

Ohkay, then update it!
Thanks for noticing

Okayy


VSCode Explorer opens a source language file - z/Open editor reports an error and changes the tree structure to red

Development environment used

Z Open Editor version:
Editor Platform

[X] Visual Studio Code

Editor Platform Version:
Operating System (on which VS Code runs : Windows 10
Java Version (when using VS Code or Theia, execute java -version and paste the details here): Eclipse Temurin JRE
Node.js version:  16
Logs attached (see here how to get them): no

Problem Description
I have a VSCode Explorer written inhouse that displays a Source Control Management system tree structure. When an item is clicked it is retrieved from the mainframe and saved locally with a suffix appropriate to the language type.  The code then issues a VSCODE.showTextDocument to present the source file into the right hand window and IBM Z/Open Editor then manages the validation and editing process.
Before clicking the source file

As soon as IBM z/Open Editor finds an error, it reports the error in the problem window and the entire tree structure goes red.
After clicking the source file

If I then comment out the error line, the tree structure returns back to its regular color.

This Explorer has worked fine for the past 12 months.

I should  add that each of the small red dots  against every item states "Contains Emphasized items".


Fix incorrect computation of the maximum box ratio for frame tracks

Maximum box ratio determines the scaling factor for the boxes on the
track and is based on the largest box height and the average box height.
So far, this ratio was computed online whenever a timer was added. This
is incorrect as the average value (obviously) still changes with future
timers to be added.
We fix this be adding a Finalize() method to the FrameTrack class that
has to be called after all timers have been added.

Maybe like this?

Closed because this can be solved in a simpler way. Sorry, will follow up.


update workshop with new titan embeddings

Issue #, if available:
Description of changes:

updated notebooks to use the latest titan embeddings name

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Also change the cells that mentions all model IDs available with a link to the documentation, since these will changes over time.


SW-6251 Add history IDs to observation plots

To prepare for the ability to redefine subzones that already contain monitoring
plots, start recording which versions of plots were included in observations.
This will allow us to tell the user which subzone a plot was in at the time of
the observation, even if the site map has subsequently changed.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2614  👈 (View in Graphite)
#2613
#2611
#2610
#2609
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Nov 19, 6:11 PM EST: A user started a stack merge that includes this pull request via Graphite.


I would like to be able to use the Factorycube-edge and Factorycube-server without internet.

It often happens that there is no or only very unstable Internet at the customer, which is why you want to install both components on one device to use them locally.
However, the services do not start when you start the factorycube without it being connected to power.

partly solved with #269


Cleanup frontend logs causing too much noise

Coverage increased (+0.03%) to 66.494% when pulling 7c866e4a19e4746b7baa3eb2f7539da906b6b933 on samarabbas:frontend-logs-cleanup into 9169f8ffe30ed81e181337461f2ac1d4171fced0 on uber:master.


2019-08-09 update

I do agree with the philosophy and the objection to removing codes.  CPT 90689 in this case.
The merge request has the removal on the cdc-source file of cpt.xml.  This is the file as it existed for download, and the change that it represented.  The enhanced files that are the unique part of the codeset project did not take this removal into account, and the values as they were are preserved: link to base sets
I do think it's worth raising to the CDC (if someone knows who to contact) in case 90689 was accidentally removed.  If it was intentional, there's another conversation we can have as well.

I just sent an email with more details on CPT 90689. This should give the background on this code. We could follow up and get more information but my guess is that this is as much as they know about it. And for our purposes we really have a very low priority on CPT codes anyways. But I still don't want to delete it.

This is superceded by Pull #13


fix a bug in _compose_queries

Description
This fixes a bug in _compose_queries that only occurs if there is exactly one filter that needs to move to a new request group.
Fixes jira: DS2020-414
Checklist
Mark "not applicable" if item on the list does not apply to this pull request.

[x] I have created/adapted unit tests for new code

[ ] not applicable

[ ] I have added new dependencies as described at the Contributing page

[x] not applicable

[ ] I have made corresponding changes to the documentation (incl. tutorial, etc.)

[x] not applicable

[ ] I have provided release notes (in description or as comment) if this PR is a new feature OR a change worth mentioning for next release

[x] not applicable

[ ] I have obtained API approvals if a new SAP API or endpoint is used

[x] not applicable

needs #102 to fix tests I assume

needs #102 to fix tests I assume

Yes, you can merge main now into this


changes

I see you have updated the page and the installation notes. However the "sudo apt-get install...." fails. I am running a fresh copy of Ubuntu Server 18.04.3 LTS (located here - https://ubuntu.com/download/server)
This is what happens when I run the command.

Yes, but there isn't package for Ubuntu, only for centos. And any way, before you have to have access to repository. You can get it only after donate
Отправлено из Mail.ru для Android суббота, 26 октября 2019г., 05:47 +03:00 от SmoothAdmin<EMAIL_ADDRESS>:

I see you have updated the page and the installation notes. However the "sudo apt-get install...." fails. I am running a fresh copy of Ubuntu Server 18.04.3 LTS (located here -  https://ubuntu.com/download/server )
This is what happens when I run the command.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly,  view it on GitHub , or  unsubscribe .

Why you create new issues at the same title?)
Google please, I am not Google to solve your problems, if you cannot admin linux i think you should hire sysadmin :)


Verification of beacon LightClientBootstrap objects

Beacon LC bootstrap verification
Currently beacon LightClientBootstrap objects are not being verified.
In order not to spam the network with these bootstraps, we should define and implement verification.
The LightClientHeader in the bootstrap object can be verified as is described by the is_valid_light_client_header call, see consensus specs: https://github.com/ethereum/consensus-specs/blob/84c4aebfa8acbabcc23561b4d04910363795861d/specs/deneb/light-client/sync-protocol.md?plain=1#L66
The current_sync_committee of the bootstrap object can be verified with a is_valid_merkle_branch  check with the provided current_sync_committee_branch against the header.beacon.state_root.
That just leaves us with the requirement of verifying whether the BeaconBlockHeader in the bootstrap is canonical.
I currently see two ways to verify this, and both ways require for the node to be at least beacon LC synced.
Step 1
From the consensus light client spec:

"Full nodes SHOULD provide LightClientBootstrap for all finalized epoch boundary blocks in the epoch range [max(ALTAIR_FORK_EPOCH, current_epoch - MIN_EPOCHS_FOR_BLOCK_REQUESTS), current_epoch] where current_epoch is defined by the current wall-clock time. Full nodes MAY also provide LightClientBootstrap for other blocks."

Bridge nodes SHOULD  inject a LightClientBootstrap for each finalized epoch boundary block. Nodes that are beacon LC synced should have the latest LightClientFinalityUpdate and thus be able to verify the header.
If a node is not yet synced, it would not be able to verify and thus store content.
Which does leave us with a chicken and egg situation:
How can this network start if it requires nodes to LC sync to be able to accept data, but for LC sync it is required to retrieve that exact same data to be on the network?
Some possible solutions or a mix of solutions to this:

Start this network with a subset of nodes that don't verify initially.

Or similarly, we could still let the set of nodes do the verification but have these nodes started with a very recent trusted block hash (-> bootstrap) that is a block hash that is also default accepted as bootstrap by the nodes. Next it follows the optimistic and finality updates as normal.

Have a specific type of bridge node that is not just gossiping in data but can on the fly forward bootstrap / update requests to a full beacon node (REST API).
Have all nodes not verify initial data and purge after LC sync is completed (this sounds more risky).

Step 2:
With just step 1, a node would not be able to backfill bootstrap data. If a bridge node injects older bootstraps, even an LC synced node would not be able verify it is canonical, unless it walks back all blocks.
Is backfill required in the first place?
The network might just work fine without it but perhaps not in all conditions.
When the network gets started with a set of nodes + bridge nodes and these nodes run long enough before other nodes try to join, there might not be immediate problems, depending on how long back of a bootstrap gets requested.
However, this is not ideal. And side issues might disrupt this, e.g. Bridge issues leaving gaps in the range, forks occurring, network issues/overload/DoS, or just the fact that a (sudden) larger set of nodes that don't have the history of bootstraps could make it more difficult to find them (This issue would be aggravated in case we want bootstraps to be stored by distance to node id, which is currently not the case however).
Solution:
Add a block_roots proof that can be verified by using the roots in historical_summaries.
This works the same way as for how headers in the history network are verified from Capella onwards. See PR https://github.com/ethereum/portal-network-specs/pull/291
The proof is slightly simpler however and would look something like this:
HistoricalSummariesProof = Vector[Bytes32, 13] # Proof that BeaconBlockHeader root is part of historical_summaries

# Post-merge until Capella BlockHeader proof
LightClientBootstrapProof = Container[
    historicalSummariesProof: HistoricalSummariesProof,
    slot: Slot # Not fully necessary, could get slot from BeaconBlockHeader
]

Or just:
LightClientBootstrapProof = Vector[Bytes32, 13]

Important to mention that LC sync is still required as in order to get historical_summaries and verify those, we need to know the head of the chain.
Then it should also be decided if we want to store it with the proof or not (and thus provide it for retrieval also with proof or not).

I'm curious what your thoughts are on having clients source the object they need to initialize into the network from an external source?  A client should have a relatively strong guarantee of correctness if we implement any kind of M of N scheme where a few trusted parties (EF and Status?) make the latest versions of these objects available from one of our domains?

Based on my understanding, a client needs to bring their own LightClientBootstrap that they implicitly trust.  I think the following are appropriate ways to do this..

Client bakes one into their release.  This will eventually get too old but for some amount of time it will be valid.
User manually provides client with this object via CLI options or whatever.
Client fetches it from a centralized source such as the ethportal.net domain.

I also think that it is valid to have these objects available from the network, but a client should only grab one from the network after they have already synced/connected with their own object.  This way a client that reconnects to the network at least once every N days will always have a valid one, and only after being offline for an extended period will they need to depend on the centralized source.

How to bootstrap the beacon network
According to light client Altair specs, the light client starts syncing by fetching a LightClientBootstrap object with a configured trusted block root. The trusted block root should be within the weak subjectivity period:

The trusted block SHOULD be within the weak subjectivity period, and its root SHOULD be from a finalized Checkpoint.

A safe weak subjectivity period is considered to be ~4 months.
Some of the already mentioned  options to configure the trusted block root are:

Embed the trusted block root in the binary and make sure the bootstrap with the same block root is available on the network (or centralized server). This root should be valid for ~4 months and we will have enough time to bootstrap the network.
Provide the trusted block root via CLI. The caveat here is that the user can provide a block root that is invalid but available in the network. This can only happen if the nodes can't validate the bootstrap.

If we agree that when most of the nodes are in sync, all bootstraps pushed into the network will be validated, then I think that using option 1 and trusting only one single bootstrap to be valid for a set period of time (3-4 months) should be a good strategy to bootstrap the network.
After this initial period, we can enable a feature flag that will start validating all bootstraps, bridges can start pushing those objects into the network and we will remove the embedded block root. Users can then configure their nodes' trusted block root via CLI.
How to validate LightClientBootstrap

Add a block_roots proof that can be verified by using the roots in historical_summaries.
This works the same way as for how headers in the history network are verified from Capella onwards

Using the historical summaries accumulator that is already available in the network and pushing bootstraps with proof is a doable approach here. if we go with the bootstrap stage with the embedded root, most nodes should be in sync and start validating those proofs.

I should have clarified better in the issue that the verification steps explained there are specifically required for the gossiping of bootstrap data (the offer/accept flow), and not for requesting of a specific bootstrap, e.g. when starting the LC sync.
When starting a beacon LC client, typically a trusted block root needs to be provided, and the bootstrap for this gets requested on the network. This can be validated with that block root, see: https://github.com/ethereum/consensus-specs/blob/812ac2ce8fd436c757bb22d4aa5c90bf4923b664/specs/altair/light-client/sync-protocol.md?plain=1#L290C5-L290C34
This issue is rather about what a client can and cannot accept to store of bootstraps, and how it can decide on this. We've talked in the past about starting with some simple solutions such as only storing 1/few bootstraps (for example trusted-block-root that it provides at startup) or some centralized (continuously updated) list of some bootstraps or their block roots. But this is quite limited and the latter solution is not even that simple from deployment PoV.
However, as described in the issue, I believe it is not really that complicated to add validation.

Client bakes one into their release.  This will eventually get too old but for some amount of time it will be valid.

Possible solution for light client sync bootstrapping and clients are free to do this, but I don't like it much (and won't put it in Fluffy as long as there are better options) as a) it requires clients to update these bootstraps in their releases and b) more importantly, it can cause users that did not update their software in a while to fail startup if a is_within_weak_subjectivity_period check is done or have security issues when that check is not done.

User manually provides client with this object via CLI options or whatever.

That is a fair option to provide but from UX point of view the option of providing just the trusted block root and being able to retrieve the bootstrap from the network is a UX step up.

Client fetches it from a centralized source such as the ethportal.net domain.

As I mention up, I believe the distributed option is of similar (or less) complexity to deploy at this point in time.

Embed the trusted block root in the binary

Same thoughts as I mention above regarding baked in bootstrap

This way a client that reconnects to the network at least once every N days will always have a valid one, and only after being offline for an extended period will they need to depend on the centralized source.

Yes, that is the idea. Getting those bootstraps updated so that a user does not have to re-provide a trusted block root each time unless they went offline for a really long time (another UX step-up)

Client bakes one into their release. This will eventually get too old but for some amount of time it will be valid.

Further thinking about this, as long as there is a is_within_weak_subjectivity_period check, baking a bootstrap in is not really that different from the idea we are having of updating the bootstrap over time while the client is running and applying that check on restart.


Export Network.Wai.Middleware.Throttle.Address

Adding this type to the export list allows custom throttlers to be built
using a composition of the remoteHost address and other request characteristics
without having to reimplement Hashable for SockAddr.

@creichert Any concerns here? I forget if I released the last version or not, but happy to do so if you think this is okay.

@ystael can you bump the version?

Looks good to me. @dfithian Do you mind cutting a new release to Hackage?

Yes, I will take care of this tomorrow!


[JENKINS-46834] Add flexible inheritance strategies, deprecate 'blocksInheritance'

I believe this addresses the following issues in JENKINS-46834:

JENKINS-39873,
JENKINS-37904,
JENKINS-39409,
JENKINS-38356,
possibly JENKINS-36788,
JENKINS-24878 (sort of),

Incidentally as part of cleanup, JENKINS-33315 is also believed to be addressed.
Supersedes https://github.com/jenkinsci/matrix-auth-plugin/pull/15.
I may rewrite history.

@jenkinsci/code-reviewers

I probably need to restore full support for the blocksInheritance setters/getters and map those to/from best matching InheritanceStrategies. Too likely to break things otherwise.


[Help Wanted] First react native app fails with federatedinfo error

Creating my first React Native app which can connect to AWS services with Amplify and I am running into problems with authentication.
On npm start the app builds to 100% but then throws the following errors:
09:43:03: Finished building JavaScript bundle in 98737ms
09:43:11: Get item: key is federatedInfo with options undefined
09:43:11: Get item: key is federatedInfo with options undefined
09:43:11: Get item: key is federatedInfo with options undefined
09:43:11: Get item: key is federatedInfo with options undefined
These are the steps I followed:
create-react-native-app RNTuesday
cd RNTuesday
mkdir src
awsmobile configure (put in credentials)
awsmobile init (entered app details)
npm install --save aws-amplify
then added the following to my app.js:
import Amplify from 'aws-amplify';
import aws_exports from './src/aws-exports';
Amplify.configure(aws_exports);
Logged into AWS Mobile Hub. Selected project and added React app.
I then linked the app to the hub using: awsmobile init 15c482e2-2c3c-11e8-8692-sometext3
CLI responded : "Successfully linked AWS Mobile Hub project: happ1-datetime!"
However when I run npm start it throws the federatedinfo errors above.
I have attached redacted app.js and aws-export files. Please take a look if you have time.
Thanks,

@TheRealRed7 These messages are not errors. You need to import withAuthenticator from aws-amplify-react-native and you also need to link the cognito library. Please check this doc

Thank you for the input. I followed your advice and the doc as suggested.
The app still outputs the federatedInfo messages but I am going to close this question and create a new one as I realise now that my question is unclear.
Thanks again.


Replace sleepPromise (tests) with retryInSeconds

Today we have a lot of sleepPromise statements in our test-suite which has a random number as a parameter. We should try to make this more clever by changing them with a retry logic using retryInSeconds or similar.

Moved the ticket to: https://cognitedata.atlassian.net/browse/DEVX-22?atlOrigin=eyJpIjoiNDEzM2U0Yjc2YzhhNDc5ODhlMmM0ZmNlYTMzNjkxMzUiLCJwIjoiaiJ9


Added support for the source parameter when authenticating

Fixes #34.

Hey @rspeed -- thanks for the contribution (and sorry for the very very delayed response). I think I need to read up on this new (to me, at least) authentication stuff a bit before I can accept this. A few other notes in the meantime:

This bumps the PyMongo requirement to >= 2.5, so we should update setup.py (now requirements.txt in recent masters)
There's also a "mechanism" kwarg (this is what I need to learn more about) -- I imagine that is something flask-pymongo would want to expose, too, here.

If you're up for it, please take a crack at those items. If not, I'll get to it eventually, I hope.


Documentation not resulting in expected outcome

Check CONTRIBUTING guideline first and here is the list to help us investigate the problem.
Describe the bug
Documented procedure (setp 1) on docker-logging-efk-compose does not result in a working fluentd container. When following the instructions, the container won't start and returns the following message:
ERROR:  Error installing fluent-plugin-elasticsearch:
	faraday requires Ruby version >= 2.4.

To Reproduce
Follow the steps of the documentation up to step 1, on the building step of the fluentd container the message will be returned.
Expected behavior
A successful build with as output a runable container image.
Your Environment

Fluentd or td-agent version: n/a
Operating system: "Linux Mint 20 Ulyana"
Kernel version: 5.4.0-56-generic

Your Configuration
n/a
Your Error Log
$ docker-compose up
Building fluentd
Step 1/2 : FROM fluent/fluentd:v0.12-debian
 ---> 3bcd4366c0e6
Step 2/2 : RUN ["gem", "install", "fluent-plugin-elasticsearch", "--no-rdoc", "--no-ri", "--version", "1.9.2"]
 ---> Running in 63cec87798f2
ERROR:  Error installing fluent-plugin-elasticsearch:
	faraday requires Ruby version >= 2.4.
Successfully installed multi_json-1.15.0
Successfully installed elasticsearch-api-1.0.18
Successfully installed multipart-post-2.1.1
Successfully installed ruby2_keywords-0.0.2
ERROR: Service 'fluentd' failed to build : The command 'gem install fluent-plugin-elasticsearch --no-rdoc --no-ri --version 1.9.2' returned a non-zero code: 1

Additional context
When running the container build with RUN ["ruby","-v"] it appears that ruby 2.3.3p222 is installed instead of the required 2.4.

used wrong documentation


Move configuration files to the config/ directory

I think it would make sense to separate the configuration from the core application (the PHP classes). For this reason, I suggest moving all configuration files to the config/ directory. The src/ directory should be reserved for the application classes (e.g. the root of the App namespace).

Any feedback?


gcp_pubsub input runs administrative API call

The call of sub.Exists(existsCtx) in the Connect() function of the gcp_pubsub input requires use of the administrative call quota. In our use case, we were met with this quota being filled (by a bug in dataflow, we believe) and our benthos based pipelines would not run. However, with a quick removal of that call, they were able to successfully start, as no calls were made that used the quota: Administrator operations per minute
Would we be interested in merging in a option to run that Exists() call in the Connect() for that input only if a boolean is set to true? We could default it to true for backwards compatibility - or make the boolean negative (eg: skipExistsCheck: false). I would be happy to contribute the solution.

Hey @iluminae, since the call consumes quota I'd support simply removing it. From what I understand the call to Exists is just a nicety and if the subscription doesn't exist Benthos should report and recover as you would expect.
Since you are testing this already would you be willing to test what happens when the subscription doesn't exist when Benthos starts up with the Exists check removed? If it still begins consuming once the subscription does exist without needing a restart then that's ideal.

@Jeffail yep, I would support that. Im sure that will work, but I will test it to make sure. I will submit the change soon after.

@Jeffail it would appear that a failure from the Connect() code properly engages the throttling that is desired (normal throttling is set to 1/s i believe) but when a failure occurs in the read loop, the Connect() is called again, but without a throttle. I believe this is a bug, correct? im talking about this loop here in lib/inputs/reader.go
		msg, err := r.reader.Read()

		// If our reader says it is not connected.
		if err == types.ErrNotConnected {
			mLostConn.Incr(1)
			atomic.StoreInt32(&r.connected, 0)

			// Continue to try to reconnect while still active.
			for atomic.LoadInt32(&r.running) == 1 {
				if err = r.reader.Connect(); err != nil {
					// Close immediately if our reader is closed.
					if err == types.ErrTypeClosed {
						return
					}

					r.log.Errorf("Failed to reconnect to %v: %v\n", r.typeStr, err)
					mFailedConn.Incr(1)

					if !r.connThrot.Retry() {
						return
					}
				} else if msg, err = r.reader.Read(); err != types.ErrNotConnected {
					mConn.Incr(1)
					atomic.StoreInt32(&r.connected, 1)
					r.connThrot.Reset()
					break
				}
				//ADDED: if we add a throttle here, it fixes the issue.
				if !r.connThrot.Retry() {
					return
				}
			}
		}

Connect() will succeed, Read() will return types.ErrNotConnected, which will make this a infinite loop of for { Connect(); Read(); }
So if we add the throttle.Retry() shown above it fixes the issue.
I have this in my PR if you agree with that.

@Jeffail i opened the PR for reference, we can iterate on it if we need to.

Looks great, thanks @iluminae!

Released: https://github.com/Jeffail/benthos/releases/tag/v1.7.9


Not working with MacOS 13.5

I updated the XCode version and for some reason it started to compile for MacOS 14.2.  I am on XCode 15.2 and MacOS 13.5

dyld[88738]: Symbol not found: _$sSa034_makeUniqueAndReserveCapacityIfNotB0yyFyXl_Ts5
  Referenced from: <B9ED5B4E-5974-3AEE-B5B8-84DFB0E9056E> /private/var/tmp/_bazel_samantha/1f5feb78215e532536d307cb44606ce9/execroot/__main__/bazel-out/darwin_arm64-opt/bin/examples/sdxl (built for macOS 14.2 which is newer than running OS)
  Expected in:     <EAA43988-4F04-3D39-A0A6-D597E46E966E> /usr/lib/swift/libswiftCore.dylib

I was able to fix it using macos_command_line_application from apple_rules


chore: migrate to TS .projenrc.ts

Was getting annoyed with the lack of intellisense.

Fixed, this change was a mess lo. Sorry about that.


dev-deps missing

Fixes issue #21
I've added the missing deps-dev section for the fiddler.json. The no-dev mode still does have no effect so for the moment the deps-dev section will always be processed but it's a good start to already split up dependencies for production and development.

@beberlei Needs a README update as well.


The description of the parameter (fmt) of the function (numtodsinterval) in the document is incorrect

##Current Status
In the document, the parameter (fmt) of the function (numtodsinterval) is noted as follows.
The parameter (fmt) does not contain year and month.

However, when the parameter (fmt) are year and month, no error is reported and the result is correct.

Enhancement
Please confirm whether it is an error of document or an error of the function's logic.

please， report  the  bug  at https://github.com/IvorySQL/Ivory-www

@BingAo-Office , I think this problem is a bug in the function logic, not a bug in the documentation.
Because the parameters of the function (numtoyminterval) are year and month.

Thanks for your reporting. Issue has been fixed at IvorySQL 3.1.


feat(transaction): enhance IStoreTransaction with price and currency …

close #75

@M7md-Ebrahim, could you please update the CHANGELOG.md file?


Architecture: should Interfaces have their own namespace?

It's a code layout question. Each interface have an owner on its own. But should they have an independent namespace to secure from circular imports? Could circular imports be a problem at all? Or should interfaces be closer to their owners?

@jakos, would you like to state your opinion?


Jacob enemies

Sleep_Gremlins nodes were changed to enable animation functionality in Stove.  A Node2D was added as the root of the scene with the Kinematic2D then a child underneath.


merged: add escape_tags option to enable/disable escaping tag names and attribut...

...es from @trbs

I am reviewing this (sorry for the super unreasonable delay). My hesitation in merging is that this produces invalid HTML.
I am thinking the minifier should do it the hard way and deal specifically with "ambiguouos ampersands":
https://www.w3.org/TR/html5/single-page.html#syntax-ambiguous-ampersand


[FLINK-23678][tests] Harden KafkaSinkITCase#testWriteRecordsToKafkaWithExactlyOnceGuarantee

What is the purpose of the change
Before this change, multiple variables were changed across thread barriers without proper synchronization. The change introduces proper synchronization to alleviate the seen problem.
Brief change log

Use volatile variable for counting emitted records
Use lock to synchronize snapshotting and writing.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure


[TECH-482] Co2 Emissions Service

Description:
1. Four new endpoints was added to get the information about network emissions provided by immutable-insights:
Daily emissions, network emissions, network emissions per transaction and country emissions.
  Network Emissions and Network Emissions per transaction have a filter to limit the results by day, month, or year
  depending on the range of dates in the startTime and endTime in request parameter:

   If the date range is less than or equal to one month, the results will be displayed per day, if it is greater than one month
   but less than or equal to one year, they will be displayed per month and if it is greater than one year, they will be
   displayed per year

  **e.g. Per Day**
  {
      "name": "Network Emissions Camino",
      "Filter": "Per Day",
      "value": [
        {
          "chain": "camino-columbus",
          "time": "2022-12-01",
          "value": 14991.42
        },
        {
          "chain": "camino-columbus",
          "time": "2022-12-02",
          "value": 14991.42
        },
        {
          "chain": "camino-columbus",
          "time": "2022-12-03",
          "value": 14991.42
        }
      ]
  }

 **e.g. Per month**
  {
    "name": "Network Emissions Camino",
    "Filter": "Per Month",
    "value": [
      {
        "chain": "camino-columbus",
        "time": "2022-11-01",
        "value": 13141.33
      },
      {
        "chain": "camino-columbus",
        "time": "2022-12-01",
        "value": 14991.42
      }
    ]
  }

**e.g. Per Year**
  {
    "name": "Network Emissions Camino",
    "Filter": "Per Year",
    "value": [
      {
        "chain": "camino-columbus",
        "time": "2022-01-01",
        "value": 15168.96
      },
      {
        "chain": "camino-columbus",
        "time": "2023-01-01",
        "value": 13679.81
      }
    ]
  }

2. For the configuration of this endpoint, a new option was added in the services section of the config file, in which the url of the inmutableInsights service.
...
"services": {
"db": {
"dsn": "",
"driver": ""
},
"inmutableInsights": {
"urlEndpoint":"https://co2.api.immutableinsight.io",
"authorizationToken": ""
}
}
Additionally an environment variable must be set in commandline with the auth token of inmutable insights api
export authorizationTokenInmutable = "TOKEN"

@charalarg I fixed all the recommendations and corrections in the last commit, please take a look when you have time


mbrola: init at 3.3

Motivation for this change
espeak voices sound terrible. it might get a little better with mbrola
Closes https://github.com/NixOS/nixpkgs/pull/45580
Unsolved problems
espeak-ng don't find mbrola unless it's also installed. adding it as a dependency has not solved it
[davidak@ethmoid:~/code/nixpkgs]$ espeak -v mb/mb-de1 "ich mag züge"
mbrola: mbrola: No such file or directory
mbrowrap error: mbrola exited with status 1
Error: Could not load the specified mbrola voice file.

when i install mbrola, it don't finds the voices in /home/davidak/.nix-profile/share/mbrola. can we do anything about that except from waiting on upstream to solve it? https://github.com/numediart/MBROLA/issues/23
[davidak@ethmoid:~/code/nixpkgs]$ espeak -v mb/mb-de1 "ich mag züge"
mbrola: FATAL ERROR : cannot find file /usr/share/mbrola/voices/de1 !
mbrowrap error: mbrola closed stderr and did not exit
Error: Could not load the specified mbrola voice file.

maybe @jtojnar has some idea?
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

see also https://github.com/NixOS/nixpkgs/pull/45580

Yeah, the voices paths need to be solved in espeak, see the old PR.

It works now!
Here is a demonstration of the german voices. (it's still very bad)
https://peertube.social/videos/watch/285ff782-3b68-45b4-92e6-e2c17cb642e8
I'm not sure if it's OK to enable mbrola by default in espeak-ng, since it adds 648 MB to the closure. But without it it is not really usable. @aske any opinion?
I don't see a way to package the voices separately, since the path is hardcoded in the patch.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/250

I resolved the merge conflict.

Please do not merge master to resolve a merge conflict. This is the quick and dirty way but the proper way of rebasing and changing the line where the merge conflict is happening is required.

Sorry, didn't know GitHub does it that way. Will do it properly soon.

Now it's properly rebased. I have also tested it again.
builder for '/nix/store/l5wz7zhwvbnzkqyc24cgx1sciickh8yh-chromium-unwrapped-89.0.4343.0.drv' failed with exit code 1; last 10 log lines:
  tar: chromium-89.0.4343.0/third_party/libphonenumber/dist/resources/geocoding/pt/244.txt: Cannot write: No space left on device
  tar: chromium-89.0.4343.0/third_party/libphonenumber/dist/resources/geocoding/pt/245.txt: Cannot write: No space left on device
  tar: chromium-89.0.4343.0/third_party/libphonenumber/dist/resources/geocoding/pt/351.txt: Cannot write: No space left on device
  tar: chromium-89.0.4343.0/third_party/libphonenumber/dist/resources/geocoding/pt/239.txt: Cannot write: No space left on device
  tar: chromium-89.0.4343.0/third_party/libphonenumber/dist/resources/geocoding/pt/55.txt: Cannot write: No space left on device
  tar: chromium-89.0.4343.0/third_party/libphonenumber/dist/resources/geocoding/de/32.txt: Cannot write: No space left on device
  tar: chromium-89.0.4343.0/third_party/libphonenumber/dist/resources/geocoding/de/49.txt: Cannot write: No space left on device
  tar: chromium-89.0.4343.0/third_party/libphonenumber/dist/resources/geocoding/de/41.txt: Cannot write: No space left on device
  tar: Exiting with failure status due to previous errors
  do not know how to unpack source archive /nix/store/3ywbdy67xqisia5k3i7y8f0l0dr2p3c9-chromium-89.0.4343.0.tar.xz
cannot build derivation '/nix/store/i3hqazyipf7hng1mkbdhbk4fnv5agw14-chromium-dev-89.0.4343.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3728zpgs9viid2dphlyviczpk1j7nvdh-env.drv': 6 dependencies couldn't be built
[32 built (6 failed), 560 copied (7160.8 MiB), 3410.5 MiB DL]
error: build of '/nix/store/3728zpgs9viid2dphlyviczpk1j7nvdh-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/93401
6 packages failed to build:
chromium chromiumBeta chromiumDev navit tts ungoogled-chromium

13 packages built:
dasher direwolf espeak gnome3.orca google-chrome google-chrome-beta google-chrome-dev mbrola pantheon.elementary-session-settings python37Packages.phonemizer python38Packages.phonemizer python39Packages.phonemizer speechd

I rebased and tested again.
@SuperSandro2000 can you merge quickly before it diverges again?
To test:
[davidak@gaming:~/code/nixpkgs]$ nix run -f /home/davidak/code/nixpkgs/ espeak

[davidak@gaming:~/code/nixpkgs]$ for i in {1..8}; do echo "mb/mb-de$i"; espeak -v mb/mb-de$i "Er hat übermächtige Käsefüße!"; done
mb/mb-de1
mb/mb-de2
mb/mb-de3
mb/mb-de4
mb/mb-de5
mb/mb-de6
mb/mb-de7
mb/mb-de8

You should hear different voices.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 93401 run on x86_64-linux 1

1 package failed to build and already failed to build on hydra master:

navit: log was empty

3 packages failed to build and are new build failures:

chromium: log was empty
puppeteer-cli: log was empty
ungoogled-chromium: log was empty

13 packages built:

dasher
direwolf
espeak (espeak-ng)
orca (gnome3.orca)
google-chrome
google-chrome-beta
google-chrome-dev
mbrola
pantheon.elementary-session-settings
python37Packages.phonemizer
python38Packages.phonemizer
python39Packages.phonemizer
speechd

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

dasher:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/accessibility/dasher/default.nix:50:5:
   |
50 |     license = lib.licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

direwolf:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/radio/direwolf/default.nix:44:5:
   |
44 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
perl is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/applications/radio/direwolf/default.nix:19:3:
   |
19 |   buildInputs = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/radio/direwolf/default.nix:24:5:
   |
24 |     ./udev-fix.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: glibc.
Near pkgs/applications/radio/direwolf/default.nix:1:57:
  |
1 | { lib, stdenv, fetchFromGitHub, cmake, alsaLib, espeak, glibc, gpsd
  |                                                         ^

google-chrome-beta:

installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/browsers/google-chrome/default.nix:94:3:
   |
94 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

google-chrome-dev:

installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/browsers/google-chrome/default.nix:94:3:
   |
94 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

google-chrome:

installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/applications/networking/browsers/google-chrome/default.nix:94:3:
   |
94 |   installPhase = ''
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md

mbrola:

Unused argument: autoconf.
Near pkgs/applications/audio/mbrola/default.nix:1:33:
  |
1 | { stdenv, lib, fetchFromGitHub, autoconf, automake, which, libtool, pkg-config }:
  |                                 ^

Unused argument: automake.
Near pkgs/applications/audio/mbrola/default.nix:1:43:
  |
1 | { stdenv, lib, fetchFromGitHub, autoconf, automake, which, libtool, pkg-config }:
  |                                           ^

Unused argument: which.
Near pkgs/applications/audio/mbrola/default.nix:1:53:
  |
1 | { stdenv, lib, fetchFromGitHub, autoconf, automake, which, libtool, pkg-config }:
  |                                                     ^

Unused argument: libtool.
Near pkgs/applications/audio/mbrola/default.nix:1:60:
  |
1 | { stdenv, lib, fetchFromGitHub, autoconf, automake, which, libtool, pkg-config }:
  |                                                            ^

Unused argument: pkg-config.
Near pkgs/applications/audio/mbrola/default.nix:1:69:
  |
1 | { stdenv, lib, fetchFromGitHub, autoconf, automake, which, libtool, pkg-config }:
  |                                                                     ^

navit:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.
Near pkgs/applications/misc/navit/default.nix:86:5:
   |
86 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Package does not have a maintainer. Consider adding yourself?
Near pkgs/applications/misc/navit/default.nix:87:5:
   |
87 |     maintainers = [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
error: no-flags-spaces
cmakeFlags cannot contain spaces, please use cmakeFlagsArray in Bash.
Near pkgs/applications/misc/navit/default.nix:43:3:
   |
43 |   cmakeFlags = [
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/no-flags-spaces.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/misc/navit/default.nix:36:15:
   |
36 |   patches = [ ./CMakeLists.txt.patch ];
   |               ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

orca:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/applications/misc/orca/default.nix:48:5:
   |
48 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

pantheon.elementary-session-settings:

lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.
Near pkgs/desktops/pantheon/desktop/elementary-session-settings/default.nix:159:5:
    |
159 |     license = licenses.lgpl3;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
Unused argument: substituteAll.
Near pkgs/desktops/pantheon/desktop/elementary-session-settings/default.nix:4:3:
  |
4 | , substituteAll
  |   ^

Unused argument: at-spi2-core.
Near pkgs/desktops/pantheon/desktop/elementary-session-settings/default.nix:14:3:
   |
14 | , at-spi2-core
   |   ^

puppeteer-cli:

Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:359:7:
    |
359 |       meta = {
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
rsync is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:292:7:
    |
292 |       buildInputs = [ yarn nodejs rsync ] ++ extraBuildInputs;
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
yarn is a build tool so it likely goes to nativeBuildInputs, not buildInputs.
Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:292:7:
    |
292 |       buildInputs = [ yarn nodejs rsync ] ++ extraBuildInputs;
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Unused argument: version.
Near pkgs/development/tools/yarn2nix-moretea/yarn2nix/default.nix:67:5:
   |
67 |     version,
   |     ^

python37Packages.phonemizer:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/python-modules/phonemizer/default.nix:36:5:
   |
36 |     ./remove-intertwined-festival-test.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: python3Packages.
Near pkgs/development/python-modules/phonemizer/default.nix:5:3:
  |
5 | , python3Packages
  |   ^

Unused argument: pkgs.
Near pkgs/development/python-modules/phonemizer/default.nix:6:3:
  |
6 | , pkgs
  |   ^

Unused argument: pytestrunner.
Near pkgs/development/python-modules/phonemizer/default.nix:12:3:
   |
12 | , pytestrunner
   |   ^

python38Packages.phonemizer:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/python-modules/phonemizer/default.nix:36:5:
   |
36 |     ./remove-intertwined-festival-test.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: python3Packages.
Near pkgs/development/python-modules/phonemizer/default.nix:5:3:
  |
5 | , python3Packages
  |   ^

Unused argument: pkgs.
Near pkgs/development/python-modules/phonemizer/default.nix:6:3:
  |
6 | , pkgs
  |   ^

Unused argument: pytestrunner.
Near pkgs/development/python-modules/phonemizer/default.nix:12:3:
   |
12 | , pytestrunner
   |   ^

python39Packages.phonemizer:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/python-modules/phonemizer/default.nix:36:5:
   |
36 |     ./remove-intertwined-festival-test.patch
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Unused argument: python3Packages.
Near pkgs/development/python-modules/phonemizer/default.nix:5:3:
  |
5 | , python3Packages
  |   ^

Unused argument: pkgs.
Near pkgs/development/python-modules/phonemizer/default.nix:6:3:
  |
6 | , pkgs
  |   ^

Unused argument: pytestrunner.
Near pkgs/development/python-modules/phonemizer/default.nix:12:3:
   |
12 | , pytestrunner
   |   ^

speechd:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/development/libraries/speechd/default.nix:50:5:
   |
50 |     (substituteAll {
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

Thanks.


Cannot read property 'accessKeyId' of null, when trying to make API request.

Bug: “Cannot read property 'accessKeyId' of null” error
when trying to make API request getting an error mentioned above, after terminating the application and restarting, everything works fine.
this is the log  after performing window.LOG_LEVEL = 'DEBUG' , before terminating the application and trying to make API request
Get item: key is federatedInfo with options undefined ConsoleLogger.js:100 {[DEBUG] 49:33.147 AuthClass - error when pickup: "No current user"}[DEBUG] 49:33.147 AuthClass - error when pickup: "No current user"__proto__: Object AsyncStorageCache.js:523 Get item: key is federatedInfo with options undefined
after terminating the application and trying to make API request
{[DEBUG] 53:20.852 AuthClass: CognitoUser}[DEBUG] 53:20.852 AuthClass: CognitoUser {username<EMAIL_ADDRESS>pool: CognitoUserPool, Session: null, client: f…s.constructor, signInUserSession: CognitoUserSession, …}__proto__: Object ConsoleLogger.js:84 [DEBUG] 53:20.859 AuthClass - set credentials from session
{[DEBUG] 53:22.786 API - set credentials for api: {…}} [DEBUG] 53:22.786 API - set credentials for api: accessKeyId:"ASIAILCY4ZRUYFOXG7KQ" authenticated:true identityId:"ap-southeast-1:2f20e766-61fc-442e-ac05-43792asdda3b5b" secretAccessKey:"LDxl8NHasd6FrLy1yPQWMVjB0xD5P1dU5kfe" sessionToken:"xxxxxxxxx" __proto__:Object __proto__:Object
aws-amplify configuration
Amplify.configure({     Auth: {         region: 'xxx',           identityPoolId: 'xxx', x         userPoolId: 'xxx',          userPoolWebClientId: 'xxx',     },     API: {         endpoints: [             {                 name: "ProductionUrl",                 endpoint: "xxx"             }         ]     } });
aws-cognito-js configuration
`
AWS.config.update({ region: "xxx",accessKeyId:"xxx",secretAccessKey:"xxx" });
export const poolData = {
UserPoolId: "xxx",
ClientId: "xxx",
};
export const userPool = new AWS.CognitoIdentityServiceProvider.CognitoUserPool(poolData);
`
Versions used
"aws-amplify": "^0.2.3",
"react-native-aws-cognito-js": "0.0.7"
"react-native": "0.51.0"

@Sathyanarayan09 looks like you are on a pretty old version. I'm also not familiar with the react-native-aws-cognito-js lib you are using there. If you use aws-amplfiy + aws-amplify-react-native packages you should be able to do this just make sure your credentials and related IAM roles have the appropriate permissions. You could use the awsmobile-cli to automate this. There is a good starter here that does auth on react native with cognito: https://github.com/dabit3/react-native-auth-starter

@mlabieniec thanks for the reply, after upgrading the version to 0.2.11 got this problem #512 and
after upgrading to beta version everything seems to work fine..

@Sathyanarayan09 How did you upgrade to the beta version?

@LT-Joshi  npm install aws-amplify@beta


Fix flakey nested concurrent unit test in contrib/mesos/pkg/proc

Should resolve the test flake seen in #9265 (aka #9752)

fix intermittent deadlock w/ nested concurrent action scheduling
give each delegate its own errOnce

/cc @davidopp @guenter

LGTM
Since this only affects mesos code, which is currently not tested by any e2e, and I'm oncall, and it should unblock #9265, I'm going to go ahead and merge this now.


Fix handling inner exceptions

fixes #48

Coverage increased (+0.0%) to 90.164% when pulling e1ea40b37c9324c436489ff90a1469c4edc5d998 on 48-fix-handling-exceptions into c1d4858f622c7b05c825cc1f9d39cef6243ae3dc on master.


First value of inputs is ignored

I tried<EMAIL_ADDRESS>and found that the first value of the inputs is ignored.
Here is an example.
init : (Model, Effects Action)
init =
  (,) {
  , dimensions = (0, 0) -- this is dummy
  } Effects.none

app =
  StartApp.start
    { init = init
    , update = update
    , view = view
    , inputs =
      [ Signal.map Dimensions Window.dimensions ]
    }

I don't know the first value of dimensions so I need to put a dummy, but the dummy value is used until new dimensions come.
I think using Signal.Extra.foldp' may solve it, and then init should be Action -> (Model, Effect Action), but I'm not sure how API should actually be because not all signals have the first value.

I know about this issue and have some ideas to fix it. Don't want to track this here though. Thank you for the report!

I really enjoy Elm so far but this issue is very annoying. Is there any update? Why don't you wanna track it here? Is it being tracked somewhere else instead?

@sgronblo, @seanhess has been working on resolving this in https://github.com/evancz/start-app/pull/37. It helped me a lot!

@sgronblo @tomekwi Note that I can't really resolve the issue, since there's no interest from the maintainers in merging that pull request, but if you need this functionality you can use my fork as a workaround.

Thanks! That’s exactly what I did at https://github.com/magnificat/magnificat.surge.sh.


docs(readme): adding analytics badge

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 3.578%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
514

Relevant Lines:
16221

💛  - Coveralls


Documenting how to play the game

Part of #4. Need to make sure people know how to play it

Good enough guide already at a87b717. Low priority.


Correctly assign conntrack zone to return packets from upstream DNS resolvers.

Please provide a description of this PR:
Fixes https://github.com/istio/istio/issues/46935. Also cleaned up a couple places where comments did not match code that I saw when trying to track this down originally.

Hi @nberkley-gp. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@nberkley-gp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
53017aae0bf59cc5ec53b94731b163ac011f413d
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
53017aae0bf59cc5ec53b94731b163ac011f413d
link
true
/test release-notes

unit-tests-arm64_istio
53017aae0bf59cc5ec53b94731b163ac011f413d
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
53017aae0bf59cc5ec53b94731b163ac011f413d
link
true
/test release-notes

unit-tests-arm64_istio
53017aae0bf59cc5ec53b94731b163ac011f413d
link
true
/test unit-tests-arm64

unit-tests_istio
53017aae0bf59cc5ec53b94731b163ac011f413d
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
53017aae0bf59cc5ec53b94731b163ac011f413d
link
true
/test unit-tests-arm64

unit-tests_istio
53017aae0bf59cc5ec53b94731b163ac011f413d
link
true
/test unit-tests

release-notes_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
53017aae0bf59cc5ec53b94731b163ac011f413d
link
true
/test unit-tests

release-notes_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test release-notes

unit-tests-arm64_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test release-notes

unit-tests-arm64_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests-arm64

unit-tests_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests-arm64

unit-tests_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests

release-notes_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests

release-notes_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test release-notes

unit-tests-arm64_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test release-notes

unit-tests-arm64_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests-arm64

unit-tests_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests-arm64

unit-tests_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests

release-notes_istio
ef11f4c03677042465842f9f97fc5056ff0d645e
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests

release-notes_istio
ef11f4c03677042465842f9f97fc5056ff0d645e
link
true
/test release-notes

unit-tests-arm64_istio
ef11f4c03677042465842f9f97fc5056ff0d645e
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
4a5c5644058ab0a3a6bcddb2a535217e49cffd5b
link
true
/test unit-tests

unit-tests-arm64_istio
0792f60eee20a0bb02ec9ea10570de38945efccb
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
0792f60eee20a0bb02ec9ea10570de38945efccb
link
true
/test unit-tests-arm64

unit-tests_istio
0792f60eee20a0bb02ec9ea10570de38945efccb
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
0792f60eee20a0bb02ec9ea10570de38945efccb
link
true
/test unit-tests

unit-tests-arm64_istio
0792f60eee20a0bb02ec9ea10570de38945efccb
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nberkley-gp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
0792f60eee20a0bb02ec9ea10570de38945efccb
link
true
/test unit-tests-arm64

unit-tests_istio
0792f60eee20a0bb02ec9ea10570de38945efccb
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

looks right to me as well

/retest

Sorry it's taking a bit to get the CLA stuff sorted out. Thought we had this ironed out before opening this but for some reason our org isn't showing up.

CLA is finally sorted out. Could one of the network maintainers give it an approval?


chore(npm): updated webpack version and reworked configs [WIP]

webpack .23 has a significant breaking changes that requires reworking of configuration

They renamed left/right to pre/post
https://github.com/webpack/webpack/releases/tag/v2.1.0-beta.24

@leon thanks, I'm aware I'm on the webpack core team!!! 😅 😅  Just hadn't had the time to get back to the PR with some <3<3

@hansl after careful inspection, I have been able on a test project to get this to run successfully, but have no idea what is causing the e2e test failures. One thing I have noticed is that whenever I run the e2e test runner locally I find that the builds are still running against<EMAIL_ADDRESS>when they should be running against .25. See below.

Well hold that thought @filipesilva just mentioned that there are two package.json 🔥  that I have to update this in. I'm going to try this out locally first.


chore: update all packages

Description coming soon

This PR is superceded by a collection of other PRs that break up the upgrades, and also an upgrade to app-platform that is forthcoming


PIXIjs webgl canvas

PIXIjs: as JavaScript Libraries
Official:

https://www.pixijs.com/
https://www.pixiplayground.com
https://pixijs.io/examples/#/demos-basic/container.js
http://pixijs.download/release/docs/PIXI.html
https://www.html5gamedevs.com/forum/15-pixijs/
https://chrome.google.com/webstore/detail/pixijs-devtools/aamddddknhcagpehecnhphigffljadon

Github:

repo:  https://github.com/pixijs
core: https://github.com/pixijs/pixi.js

Example site:

https://www.google.com/doodles/halloween-2018
https://mmm.hsiao.science/
https://art4globalgoals.com/en
https://brandstudio.ru/en/
https://bonk2.io/beta/
https://game.hyeon.me/wbwwb/

Detection script:
window?.PIXI?.VERSION || global?.PIXI?.VERSION || PIXI?.VERSION;

Note: PIXI use webgl or canvas rendering (if webgl not available! (mostly in mobile), it fallback in canvas mode)
in most case , utility allow to see in what rendering mode.
PIXI?.utils?.isWebGLSupported(); // true:webgl rendering  false:canvas rendering

except if for x reason the developer has chosen not to include utilities with a custom build in productions. (byDefault utility are include in core)
You will need use classic way : https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/By_example/Detect_WebGL
Developer tool also allow detect PIXIjs, see link in official.
official logo:

Analytic
https://www.similarweb.com/website/pixijs.com/

Thanks! This one has been added.


logo is broken

https://cloud-cdn.nebula-graph.com.cn/vesoft-nebula-logo-white.png

https://cloud-cdn.nebula-graph.com.cn/vesoft-nebula-logo-white.png

It's been restored.


Opening the Author App is giving MismatchCert Issue

Seeing the above error from last few min when opening the Author App in MS Teams

Hi @grsandeep ,
Thank you for raising the query. Please respond to the below queries.

What is the deployment approach followed for CC?
What is the version of the app?
Please share the application insight logs. Here is the reference.
Go to resource group-->Application Insights-->Under investigate click Failures. Copy the logs and paste it in a text file. Share it here.


Replace File Attachment file

For https://trello.com/c/WvCPILCl/817-provide-means-to-edit-replace-an-attachment
This allows users to replace an existing file attachment's file with a new one.  If a file attachment is live then the original file will be redirected to the new file.  When upload a replacement file it is validated against the existing requirements for a file upload.  A separate PR will look at making additional checks as per the comments in the Trello card.
Current file attachment

Upload a new file

Replacement file

Update confirmation

Thanks @kevindew those last 2 comments should be addressed now.  I had a chat with Alex about the override, hopefully he can give you a bit more detail on that in person.

@kevindew this is a case of govspeak overwriting component's style when it's being used within the component, so we need to undo that. It could be addressed together with how we use render_govspeak across our application (which adds more markup than necessary) and we might want a more lightweight helper to handle our markdown content in the yml files.

This looks good to me. Just one thought on the feature spec, where we have scenarios for replacing attachments for draft and live attachments. Since there's no user-visible difference between the scenarios, and we already check this behaviour thoroughly lower down, I wonder if we can just have one scenario here?

@benthorner Emma is sick this afternoon so I've picked this up, I've simplified this to one scenario now.

@kevindew this is a case of govspeak overwriting component's style when it's being used within the component, so we need to undo that. It could be addressed together with how we use render_govspeak across our application (which adds more markup than necessary) and we might want a more lightweight helper to handle our markdown content in the yml files.

Sure, not sure we quite need govspeak in there but I could see it being a pain point for other places if we do put govspeak inside it. I guess we have to do something similar even if it doesn't have govspeak.