[CI] Upgrade oneAPI runtime to 2025.0.0

New base package is Deep Learning Essentials - https://www.intel.com/content/www/us/en/developer/tools/oneapi/base-toolkit-download.html?packages=dl-essentials&dl-essentials-os=linux&dl-lin=offline

Blocked by #2594.

torch-xpu-ops repo pin have been updated in the PyTorch repo:

https://github.com/pytorch/pytorch/pull/139986

Depends on:

#2701
#2690


Compile Razor pages

aspnet/Razor#1809

@Rick-Anderson I've been talking to Dan Roth about this one and have some detailed notes (and a sample app). I'll gladly take this on.

This was noted in #5404 but not obvious here since aspnet/Razor#1809 pertains to compiled Razor in libs.

Razor compilation is now part of every build. This means that Razor compilation issues are caught at design time instead of when the app is first run. Compiling the Razor views and pages also significantly speeds up startup time. And even though your view and pages are built up front, you can still modify your Razor files at runtime and see them updated without having to restart the app.


Bump version to 2.11.3

Edit: the CI wont pass until the following PRs are merged:

#631
#650

(This PR contains links to those sections in the release notes)

This PR needs to mark 2.11 as EOL

@mergifyio rebase 2.11.x


revise mā></mā> etc.

The following passage in https://dharmalekha.info/texts/INSIDENKHering rather clearly shows that simply encoding mā></mā> may not be sufficient:
(A22) rgaṇuṁ pu daṅhil· Irikaṁ lmaḥniṁ samaṅkana mā kā 1 su 13 mā 14 kunaṁ pamahli pu
<lb break="no" n="A22"/>rgaṇuṁ pu daṅhil· Irikaṁ lmaḥniṁ samaṅkana mā kā <num value="1">1</num>  su <num value="13">13</num> mā <num value="14">14</num><supplied reason="subaudible">,</supplied> kunaṁ pamahli pu
Because in the first case mā means mās and in the second case it means māṣa. It also shows that we should not consider the numerous collocations mā su as mere spelling equivalents for mās su I (which I think in some inscriptions encoded by Eko and me we have implied by using <choice> or by using <supplied> for the s).
I am presently inclined to think we should enrich our encoding of , in due course, as per EGC 7.3.1. I also suppose the machine will be able to help us because

<expan>mā<ex>ṣa</ex></expan> will normally be followed by <num>,
whereas
<expan>mā<ex>s</ex></expan> will normally be followed by another  (kā or, more commonly, su)
and the latter cases of  can be changed to <expan>kā<ex>ṭi</ex></expan> etc. by a massive search and replace operation.

I vaguely recall that the new version of EGD that Daniel is preparing has some new rules for use of  so we should in any case wait until that new version has been released. In due course, I hope @danbalogh and @michaelnmmeyer can advise us and help carry out any multi-file modification.

Thanks, acknowledged. I agree with the need for a more detailed encoding of these two cases of mā and will await advice from Daniel and Michaël on the best way forward.

Hello, the encoding rules for abbreviations have not changed since the last revision in 2022, which is reflected in the Google doc, though of course not in the PDF of the EGD v1. The format used by Arlo above, with expan containing abbr and ex, is the way to go. I'm not planning further revision for the v2 release. The only difference I see between the working document and the GDoc was that māsu is specifically mentioned in the introductory section for abbreviations. I have now copied that to the GDoc (see 7.3, before the subsection 7.3.1), and let me know if you wish to change that.

Thanks Dan. Re. the bit in 7.3, I am bothered by treating bahula-divase as a "more than one word", since Sanskrit compounds are by definition single words.
I'd forgotten about the solution proposed for māsu and the gist of my message above was that we'd treat it as follows:
<expan>mā<ex>s</ex></expan> <expan>su<ex>varṇa</ex></expan>
or, if we only bother about expanding ambiguous cases,
<expan>mā<ex>s</ex></expan> su>
I can live with any of these solutions.

I've added a note to revise "more than one word". Please confirm that you want the bit on tagging māsu as a single abbreviation deleted; my impression from what you say is that you will never want to tag māsu and instead always tag mā and su as two separate abbreviations, regardless of which (if any) you then resolve. The choice to resolve or not is up to you guys who know the texts, and not something that should or could be dictated by the guide.


Support of Progressive Web Apps / Offline Sync

Currently the only possibility to create a PWA with offline sync is using PouchDB together with CouchDB. If I like to integrate this into Starcounter it will be a mess. A better way would be if Palindrom supports PWA based on JSON patch.

Thanks for reporting that need. We were already considering writing Palindrom PWAs. Theoretically, JSON Patch (Versioned Queue & OT) should play well with offline behavior. We just didn't' start it before as we were focused more on already expressed customer needs, rather on our ideas of improvement and potentially useful new features.
Now, having your voice here, we have a reason to start it sooner than later. We will get back to you once we will have something to share.

Just quick note - together with @alshakero we talked with @jwillmer outside of this thread. Next step is to prepare some PoC by @alshakero so we can move forward.

@mmnosek Could you post your email to Jens here please? It has some ideas.

In the meeting we agreed to the following:

It’s not necessary to provide full functionality of the app in “offline mode”. However, some features (e.g. time tracking, filling up checklist forms) should work smoothly. The goal is to create rather simple applications than super complex offline systems. Starcounter is expected to support this on a product level.

Natural alternative and the candidate is a tandem of PouchDB + CouchDB that works as a client-side DB that synchronises with a central DB, Starcounter in this case. It may be used also as an inspiration for Starcounter. A disadvantage of this approach is having a stack separated from Starcounter, so any connection/synchronization is huge additional work. Using Starcounter would then makes less sense.

Theoretically, we have two ways of dealing with this:

PouchDB + Starcounter
Starcounter + (PWA Friendly) Palindrom. This approach is preferred by us to keep the client reasonably thin and not abandon all cool Starcounter features.

We would like to provide some kind of hybrid - make client only a little bit thicker in places where offline functionality is necessary. This would keep development effort reasonably low, provide full compatibility with other Starcounter Apps and fulfil PWA requirements. There are two major challenges with this:

Caching the actual database data on the client side
Design proper application flow and logic that doesn’t rely directly on the server as a single source of truth. Think validation and so on.
ServiceWorkers only work in HTTPS.
WebSockets are not supported in ServiceWorkers.

How to start
We decided that @alshakero is going to create a PoC of Palindrom with an additional ServiceWorker layer intercepting HTTP calls when there is no connection. Then we can test it with something real. Demo is expected soon :-) This will give us a much better understanding of the problem and how to solve it.
Other improvements in dealing with lost connection messaging etc. are obvious, to be reviewed later. Roadmap and overall (doable) idea is expected to be presented in the first half of January 2018 to make decisions.
This text is mostly wrttien by @mmnosek

The goal for us is to make all apps PWA-enabled. Network independence is one of 10 aspects of PWAs, and probably the hardest to implement.
 It should be possible to blend thin and fat views. The difference between the thin and fat views:

a thin view is a view that does not have application logic on the client side. It will be static and read-only when offline.
a fat view is a view that has client-side logic. To make a fat view operate when offline, the app developer provides a Service Worker that handles the CRUD operations performed by client-side logic. This could be for example done using REST calls.

Steps needed to achieve that:
Stage 0. Make Level1 bootstrapping HTML (PartialToStandaloneHtmlProvider.cs) cacheable by removing the session URI from it. The bootstraping HTML must be the same for app requests, including PWA. (https://github.com/Starcounter/Home/issues/333)
Stage 1. Create a Service Worker for Palindrom that (https://github.com/Palindrom/Palindrom/issues/185):
- Creates snapshots of view-models based on URL,
- When offline, respond with a patch that morphs the view-model to the snapshot based on current URL, so it covers URL-based navigation, not granular data changes,
- Maybe make the view-model read-only when its served from cache,
- Indicate when the app is actually offline.
Stage 2. Preload view-model snapshots to the app, so it can render URLs that were not rendered previously.
Stage 3. Allow app developers to provide Service Worker logic that handles view-model changes while offline, ideally without sacrificing blending capabilities. This is the difficult stage and some sacrifices must be made. We will have more meetings to discuss this. (Let's continue the discussion about this stage in https://github.com/Starcounter/RebelsLounge/issues/229).

Idea: Currently, by default all applications use PartialToStandaloneHtmlProvider.cs. To achieve some of the PWA capabilities (like making it available on home screen), more specific html is needed (different for iOS and Android). Shouldn't it be a separate middleware?

Shouldn't it be a separate middleware?

We're working on that https://github.com/Starcounter/Home/issues/334.

Idea: Currently, by default all applications use PartialToStandaloneHtmlProvider.cs. To achieve some of the PWA capabilities (like making it available on home screen), more specific html is needed (different for iOS and Android). Shouldn't it be a separate middleware?

We're working on that Starcounter/Home#334.

Not really, since Starcounter/Home#334 is about overwriting the bootstrapping HTML by a system app. It should not be advised to an app developer to overwrite this file.
See the following line in another issue, https://github.com/Starcounter/Home/issues/333:

Please note that to achieve blending compatibility, the bootstraping HTML must be the same for all apps, including mobile apps, PWAs, etc.

It is a very good observation, @mmnosek, that there are many needs for custom content in the <head>. But currently there is no other solution to it than to add it dynamically: https://github.com/Starcounter/Docs/issues/178
Please note that this question is out of scope for Palindrom. If needed, please open a dedicated issue in RebelsLounge.

Since the term "PWA" is quite ambiguous (like "Web 2.0"), this issue will be broken down into actual feature issues.


Update PR template to be more intuitive

Description
Updates the PR template so that each set of checkboxes has at least one that should be checked. I went through this myself once with a PR and found that I always expect to check at least one, so this change makes this a bit more obvious.
Areas changed

npm packages changed:

[ ] responsibleai/causality
[ ] responsibleai/core-ui
[ ] responsibleai/counterfactuals
[ ] responsibleai/dataset-explorer
[ ] responsibleai/fairness
[ ] responsibleai/interpret
[ ] responsibleai/localization
[ ] responsibleai/mlchartlib
[ ] responsibleai/model-assessment

Python packages changed:

[ ] raiwidgets
[ ] responsibleai
[ ] erroranalysis
[ ] rai_core_flask

Tests

[x] No new tests required.
[ ] New tests for the added feature are part of this PR.
[ ] I validated the changes manually.

Screenshots (if appropriate):
Documentation:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Since there were quite substantial changes since your reviews I'll reset your approvals @imatiach-msft and @gaugup. I reduced the sections significantly based on @imatiach-msft 's feedback (see corresponding thread). Let me know what you think!

@gaugup any thoughts? This is waiting on your input.

Codecov Report

Merging #1116 (9f52427) into main (88791b3) will decrease coverage by 5.92%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
- Coverage   86.36%   80.43%   -5.93%
==========================================
  Files          99       18      -81
  Lines        4569      322    -4247
==========================================
- Hits         3946      259    -3687
+ Misses        623       63     -560

Flag
Coverage Δ

unittests
80.43% <ø> (-5.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

raiwidgets/raiwidgets/error_analysis_constants.py

erroranalysis/erroranalysis/_internal/metrics.py

...iwidgets/raiwidgets/explanation_dashboard_input.py

...i/responsibleai/managers/counterfactual_manager.py

...ponsibleai/responsibleai/_managers/base_manager.py

...nsibleai/responsibleai/_managers/causal_manager.py

...tools/error_analysis/dashboard_schemas/__init__.py

responsibleai/responsibleai/_managers/__init__.py

raiwidgets/raiwidgets/constants.py

responsibleai/responsibleai/_config/__init__.py

... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88791b3...9f52427. Read the comment docs.


Use parseInt to cast integers, not bitwise

Bitwise operators cast every input to a 32-bit (max 2^32) integer
(whereas JavaScript integer operators allow you to deal in integers up
to 2^53)
~~2375120519 === -1919846777
// true

Ref: http://stackoverflow.com/a/12643063

Pull request rebased here because https://github.com/esatterwhite/node-tastypie/pull/19#issuecomment-220154021

@andjosh What happens if it isn't actually a number? The bitwise operator would at least return 0 which in the worst case is still an integer.
I'll write a new test case for this


Add<EMAIL_ADDRESS>

https://github.com/rabbitmq/rules_erlang/releases/tag/3.15.0

Please fix the check failures.


ErlNifEnv should be an empty type

It is supposed to be opaque. It should at least be of size 0.

The dummy member is not pub; where are you seeing it not be opaque?

The dummy pointer member disables Send and Sync.  There are other ways in unstable Rust.

Also at the time of writing I recall an error or warning for empty structs.  The recommended alternative was to use an empty enum, but I didn't like the way ErlNifEnv listed an enum in the docs, so stuck with struct.  I suspect this may have changed in current Rust.

When both points above can be resolved in stable Rust I'll happily make the struct size 0.

what the status of this?

Unless there's some concrete issue with the current implementation this should be closed.


adding a email sending file

adding an automated email sender written in python
hope this help.

Added an automated email sending file using SMTP module
script written in python
pull request reference #74


Adding Links to Workshop Exercises

https://github.com/SAEL-SWFSC/OpenScience/blob/0ee5d402a91d3e00699a854556d012f5c1fe9357/content/PAM-SI-Mtg-Exercises.qmd#L13-L25
Once we have finalized these exercises it would be great to add a link to each exercise page

Added links here


Fixes onboarding so user can finish last step

The promptButton defaults to disabled, but I neglected to re-enable it during the last step.
@steam I could go either way on the placement of enabled=false.  Looking at it a second time, are you still leaning towards putting it in style()?

@colinta, style seemed odd to me as well, but I wasn't sure where interaction control should be. Seems fine for now.


RHEL7+Canal breaks on network restart

It looks like the entire NAT table of iptables is lost when restarting networking on RHEL7 hosts. This issue probably affects CentOS7 hosts as well, but it's not part of our CI matrix currently.
Broken iptables (after restarting networking): http://pastie.org/private/e1ukaityh8km1tawk8gkg
Working iptables (without restarting networking): http://pastie.org/private/lk9nweocogixkwhjxsdtg

It seems the nat rules are ok after some time, but still, the connectivity from pods is broken. The check:
kubectl exec -it dnsmasq-xxxx --namespace=kube-system -- sh -c 'nc -nvw 3 -i 1 <IP_ADDRESS> 53' (just substitute the corrdct pod name). Works before the network restart, and doesn't works after

@adidenko helped to debug the env, the node running pods is missing some routes after network restarted. The problem looks similar to this https://github.com/projectcalico/felix/issues/1185

Which NAT rules are missing after the restart? I would assume the k8s service NAT rules are missing. These are rewritten periodically by kube-proxy, which would explain why it works after some time.
Currently restarting of networking is skipped in kargo when calico/canal is chosen. An alternative solution would be to kill/remove kube-proxy containers on all all nodes and wait for them to come up again. After they are up, k8s services should function properly again.

The routes are missing, not NAT rules, AFAICT

Ok, initially the issue was about iptable rules. Are these 2 different issues maybe?
Just did a fast test on a local Vagrant cluster with debian and flannel.
vagrant@k8s-01:/etc/dhcp$ sudo route
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
default         <IP_ADDRESS>        <IP_ADDRESS>         UG    0      0        0 enp0s3
<IP_ADDRESS>        *               <IP_ADDRESS>   U     0      0        0 enp0s3
<IP_ADDRESS>     k8s-02          <IP_ADDRESS>   UG    0      0        0 enp0s8
<IP_ADDRESS>     k8s-03          <IP_ADDRESS>   UG    0      0        0 enp0s8
<IP_ADDRESS>    *               <IP_ADDRESS>   U     0      0        0 docker0
<IP_ADDRESS>      *               <IP_ADDRESS>   U     0      0        0 enp0s8

vagrant@k8s-01:/etc/dhcp$ sudo systemctl restart networking && sudo route
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
default         <IP_ADDRESS>        <IP_ADDRESS>         UG    0      0        0 enp0s3
<IP_ADDRESS>        *               <IP_ADDRESS>   U     0      0        0 enp0s3
<IP_ADDRESS>    *               <IP_ADDRESS>   U     0      0        0 docker0
<IP_ADDRESS>      *               <IP_ADDRESS>   U     0      0        0 enp0s8

vagrant@k8s-01:/etc/dhcp$ # wait a few seconds
vagrant@k8s-01:/etc/dhcp$ sudo route
Kernel IP routing table
Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
default         <IP_ADDRESS>        <IP_ADDRESS>         UG    0      0        0 enp0s3
<IP_ADDRESS>        *               <IP_ADDRESS>   U     0      0        0 enp0s3
<IP_ADDRESS>     k8s-02          <IP_ADDRESS>   UG    0      0        0 enp0s8
<IP_ADDRESS>     k8s-03          <IP_ADDRESS>   UG    0      0        0 enp0s8
<IP_ADDRESS>    *               <IP_ADDRESS>   U     0      0        0 docker0
<IP_ADDRESS>      *               <IP_ADDRESS>   U     0      0        0 enp0s8

It looks like routes also disappear for a few seconds when flannel is used. Is this the same behavior you've seen?

Nope, NAT rules look irrelevant here

The issue I observed was related to calico, not flannel. On a broken env a lot of different things were missing, like: missing routes to cali* interfaces (not /26 net routing rules to other node), missing apr_proxy settings  (which was blocking traffic from/to container via veth pair), etc.

@adidenko thanks for details. Note, this bug is about Canal, which contains calico parts, not flannel itself.

@adidenko On which Cloud provider did you experience this issue? At the time you reported the issue, https://github.com/kubernetes-incubator/kargo/pull/749 was not merged yet. Without the PR, NAT was always disabled on CentOS (on non-gce) when network was restarted, resulting in k8s networking to fail.
I could only reproduce the network failure by removing the net.ipv4.ip_forward=1 line from the sysctl.conf. I also tried to reproduce on Debian and was not able to do so, because something else in the system was reenabling NAT all the time.
I did not observe that routes or iptable rules got lost and can not say how this is related with everything.
@adidenko Can you currently reproduce the issue?

I was troubleshooting broken env, I did not reproduce this issue myself. I run deployments on Ubuntu Xenial and did not notice any issues with Canal lately.

As @bogdando wrote on Slack, he was using GCE to reproduce the issue. This means that he was not affected by the missing PR https://github.com/kubernetes-incubator/kargo/pull/749
Still, it would be interesting if this is issue can currently be reproduced.

@adidenko Do you have a cluster currently running where you could test a network restart and check if networking on this node still works?

@codablock I've tested network restart on Ubuntu + Canal env (deployed an hour ago with latest kargo from master branch) and see no problems with it.

@mattymo I have the feeling that the issue reported by you and the issue reported by adidenko are two different issues. Can you currently still reproduce the original issue?

we could make CI jobs to restart networking and see how that works

note, the related calico bug was fixed upstream


Fix passing wrong parameter when calling newConfigurationException() in DotExpanderProcessor

Description
When calling newConfigurationException(), the first parameter should be processor type, not the tag key, DotExpanderProcessor passes wrong parameter, but the final response of the API such as create ingest pipeline API and simulate API is not affected, that's because the root cause exception is wrapped into another exception, so the original processor type is overrode.
No other callers of the method have this problem.
Related Issues
https://github.com/opensearch-project/OpenSearch/issues/10734
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
[x] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Could anyone help to review this PR? It's pretty straightforward.

URL: https://build.ci.opensearch.org/job/gradle-check/29215/

https://github.com/opensearch-project/OpenSearch/issues/5409
https://github.com/opensearch-project/OpenSearch/issues/10558

URL: https://build.ci.opensearch.org/job/gradle-check/29263/

https://github.com/opensearch-project/OpenSearch/issues/10006
https://github.com/opensearch-project/OpenSearch/issues/10193

URL: https://build.ci.opensearch.org/job/gradle-check/29268/

https://github.com/opensearch-project/OpenSearch/issues/10154

@gaobinlong could you please backport to 2.x manually?


chore: add support for OSSF scorecard reporting

Main Changes
This pipeline will proactively report the status of the project (every day and when a push is done to master branch) including critical fields (CI-Tests, Contributors, Dependency-Update-Tool, Webhooks) that are missing while running via OSSF cron jobs.
Context
Changes related

It's also possible that some repositories in your organization are already being automatically tracked by OpenSSF in this CSV file via weekly cronjob. One caveat: Automatically tracked projects do not include https://github.com/ossf/scorecard/issues/3438 in their analysis (CI-Tests,Contributors,Dependency-Update-Tool,Webhooks).
Source: openssf-scorecard-monitor documentation

Team discussion related

Ref: https://github.com/expressjs/security-wg/issues/2
Report: https://kooltheba.github.io/openssf-scorecard-api-visualizer/#/projects/github.com/expressjs/cors/commit/f539294bf844a0a487550de9802ab059b6486370

CI issues are not related to this change, so I will merge it.


Authenticator is always returning true for ::isAuthenticated()

I'm trying to implement your package and so far saving secrets and verifying codes is working great. But I want to use my own middleware and the following code always returns true (placed in a controller for debugging purposes, but same effect in my middleware).
$authenticator = app(Authenticator::class)->boot($request);
$authenticator->logout();
Google2FA::logout();
dd($authenticator->isAuthenticated(), $request);

Anything I could be missing? If you need more information please ask, not sure what else to tell you.

Do you know how to solve this?
I got the same thing.
Thanks


1-Wire protocol decode

Raw samples attached... Arduino 1-wire controller, reading temperature from a DS18B20, captured on an MSO-X 2024A... CSV format.
1wire.zip


Running multiple instances on same host with different ports?

Hello, not really an issue, but more of a question.  I've got a single instance running on 5800, but would like to run another 3-5 instances from the same VM host. I tried just iterating all the ports, but while the docker starts, it doesn't work.
if I curl http://host-ip:5801, I get "Empty reply from server"
Anyone running multiple instances that could point me in the right direction?
Thanks,
Ben

How did you created your containers ?  To have multiple instances, you should map port 5800 to a different port with the -p argument of the docker run command.
For example, the first instance could use -p 5801:5800, the second -p 5802:5800, etc.

Ah, I was running the following:
sudo docker run -d  --name=firefox5800  -p 5800:5800  -v /docker/appdata/firefox5800:/config:rw  --shm-size 2g  jlesage/firefox
sudo docker run -d  --name=firefox5801  -p 5801:5801  -v /docker/appdata/firefox5801:/config:rw  --shm-size 2g  jlesage/firefox
sudo docker run -d  --name=firefox5801  -p 5802:5802  -v /docker/appdata/firefox5802:/config:rw  --shm-size 2g  jlesage/firefox
I'll try your suggestion now, thank you!

your suggestion worked, thank you!


[$500] Notification - No notification when IOU request is received

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

[User A] Launch the app.
[User A] Background the app.
[User B] Send a money request.

Expected Result:
User A receives app notification for the IOU request.
Actual Result:
User A does not receive app notification for the IOU request.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
Uploading Bug6304391_1701951931125!Screen_Recording_20231207_165213_One_UI_Home.mp4…
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~014d4949f0fdc96771
Upwork Job ID:<PHONE_NUMBER>318093824
Last Price Increase: 2023-12-14
Automatic offers:

jjcoffee | Reviewer | 28062411

Not overdue.

I don't think this is still occurring, right?

@Julesssss I was able to reproduce it on my iOS device just now.

Ah thanks, I can also reproduce on Android now (I thought this was related to a different notification issue we just resolved)

Hi, I'm Artur from Callstack - expert contributor group - and I would like to work on this issue.

Sounds good @artus9033, please go ahead

@kbecciv @Julesssss I tried to track the issue cause and found that the notification is properly handled, but is purposedly not shown since it has the notificationPreference set to 'hidden':

I saved the almost-full Pusher payload here (the rest was cut off by Flipper, probably it is too long, however what we need is in the captured part): https://gist.github.com/artus9033/1eae1602bc1905bce31956e3fb4283ea

The above can be found here: https://gist.github.com/artus9033/1eae1602bc1905bce31956e3fb4283ea#file-expensify-32656-log-json-L102
It seems to me that the problem resides in backend, since the data contains fields that inform the frontend not to show the notification and as far as I've been able to track it, there does not seem to be a single place in frontend that would modify it. Moreover, there is one more field, childReportNotificationPreference that also is set to 'hidden': https://gist.github.com/artus9033/1eae1602bc1905bce31956e3fb4283ea#file-expensify-32656-log-json-L29
I tried changing the notification settings for the private conversation with User B on UserA's side, but nothing helped - the preference field coming from Pusher is still 'hidden'.

Thanks @artus9033. This seems possibly related to the room notification preference somehow...
cc @arosiclair

I tried changing the notification settings for the private conversation with User B on UserA's side, but nothing helped - the preference field coming from Pusher is still 'hidden'.

So to clarify, you're seeing the default notification preference is hidden and you can't change it? Is this also an issue in workspace chats?

@arosiclair indeed, Pusher receives properly notifications in chats. One thing to note is that simply minimizing the app (I understand this is what @kbecciv meant in the original post will not make the app use Airship to receive notifications. Going forward with this assumption, the logs state that the notification would be created (however it still is not since LocalNotification does not carry an actual implementation on native

To clarify, push notifications are always delivered using Airship on native. On web and desktop, new messages are delivered through Pusher and trigger local notifications here. That also happens on native but as you noticed, it is a no-op.
You don't need to background the app to make them display on either platform, only ensure you're not already looking at the chat/report when you receive the message.
It sounds like this might need some internal repro/testing @Julesssss

I'm ending my day now, but have loads of time to test this tomorrow if that's okay

Okay, I looked into this today with a modified debuggable prod build and noticed two things:

No Android logs occur when a Request notification is sent, which suggests the Urban Airship push is getting entirely dropped, or is erroring. We need to investigate further here -- we should also log failures, as I struggled to debug in Logsearch

here's an unrelated exception that occurs when sending a regular push notification that might be worth investigating:

There is also a good argument to be made that this should be attached to a wave

I was OOO. No change here

Working on some Wave 5 issues that are more critical, going to reduce priority here

Aiming to pick this up after my current wave 5 issue

Will pick up soon

Not yet prioritised in a project

Same as above

Same as above

We're going to prioritise this under wave-collect and get this fixed. First step is to build the the IOU string from the message/originalMessage data, then to call UrbanAirshipAPI::sendPushNotification for the IOU flows.
I'll start work on it tomorrow 🤩

Not 4 days overdue... stupid bot

I wrote out a comment yesterday but must have forgot to send it.
Yesterday I debugged the IOU commands and discovered that accountsToNotify doesn't include the receiver, it seems that they are marked as 'hidden'. Will continue my debugging today.

We appear to be marking Chat Reports with notificationPreference: 'hidden'...
Questions

When did this start happening
Why doesn't the notificationPreference matter for comments?

I think I have the answers:

IOU reports have their notificationPreferences rNVP set to 'hidden' by default, whereas chat reports have the notificationPreferences rNVP set to 'always'
This should be fine because users cannot modify the IOU notification preference
The problem is that we're using the IOU report preference when sending notifications when instead we should be using the associated chatReport preference
As a follow-up, perhaps we should not be setting the rNVP for IOU reports, as this is useless

I'm pausing work here to focus on more critical issues. But for my future reference:

Here is the cause and solution
My branch has logs for debugging the NVP value: jules-iouActionNotifications

I'm pausing work here to focus on more critical issues. But for my future reference:

Here is the cause and solution
My branch has logs for debugging the NVP value: jules-iouActionNotifications
Here are my most recent notes on the report default NVPs:

Here's a relevant discussions for the cause of this issue

Tomorrow I will be back to catch up, clear chores/reviews, attend an interview. Then can continue here

It's possible we'll bundle this into the wider notification project, but I still see this being a valid separate bug to be worked on simultaneously

It's possible we'll bundle these changes into the 'send notifications to correct experience' project, holding for now

Okay, the solution here will need to align with the wider changes. Holding.

The dupe-notifications project is still blocking this. But we may not solve as part of the project

Held on dupe notifications, which in turn is held on slow API fire

Same as above, will be the case for at least the next month

Attached to Hybrid project, but I have higher priority issues to work on.

Less important than other Hybrid issues for now

Less important than other Hybrid issues for now

Less important than other Hybrid issues

Way less important than other issues currently

I've kind of lost track of what we're actually going to do with this issue? Once we're notifying on the correct experience, won't this happen:

The first expense added to a report creates the IOUPREVIEW in the workspace chat and notifies
Every expense thereafter added to the report will not notify, because 1) the report preview doesn't move position anymore since comment linking and 2) the expense report's notificationPreference is hidden by default
[Coming soon, @garrettmknight?] For workspaces using delayed submission, when the expense report is submitted, we'll add a whisper to the workspace chat for the approver which will notify them that they have a report to approve.

I also am not certain this is still necessary. Let me get back to triaging this and verifying your points once other Hybrid issues have been resolved, as either way this is lower priority.

Sounds good!

FYI I'm OOO most of next week, so will find time for triaging when in Savannah

As above, this has to wait until next week at the earliest

Delaying again. I can't yet find time to triage

I'll be picking this up as we begin to work on the HybridApp notification polish issues

Lower down the list of HybridApp priorities

The initial issue was created so long ago that it might just apply to 1:1 money requests... One initial test would be to do the following:

I will set our DM to Notify: Mute
You can then request money from me
Lets see if I receive the money request notification

Every expense thereafter added to the report will not notify, because 1) the report preview doesn't move position anymore since comment linking and 2) the expense report's notificationPreference is hidden by default

Then, we should be able to verify this with a senior-leader expense approver, right?

Then, we should be able to verify this with a senior-leader expense approver, right?

Doesn't even need that. I just have to submit a second request to you.

I will set our DM to Notify: Mute

Why would you do that? Just leave it as Always. You'll get a notification for the first expense that creates the REPORTPREVIEW.
Then I'll send you another one, which adds to the same report and "updates in place" the REPORTPREVIEW, and you won't get notified about it.
That's all by design with how it works now.

Drop me a message tomorrow and we can test.

With HybridApp notifications working this one is closer to being prioritised.
Here are some blockers:

https://github.com/Expensify/Expensify/issues/424424
https://github.com/Expensify/Expensify/issues/428777

This should be working already. I refactored it in this PR a while ago. We have a test for it here as well. I think we can just close this unless there is something else broken.

Works for me, but we can wait for Jules to see this tomorrow before we close.

Great, lets close 👍

Cool, done.


Why the button on github repo page doesn't need a flash object

Hi, I'm going to use zeroclipboard in my another project. Thanks for your work.
But I've got a problem. The flash element will be on top of my "copy" button which will cause my "copy" button hide, because onmouseout or onmouseleave will make my "copy" button disappear.
I've double checked that the copy button on github repo page doesn't seem to use flash.
I right click on the github copy button, it's a normal context menu instead of a flash context menu.

And I cannot find any flash object element on the github page.
What trick did github use to not let the flash cover the copy button?

They utilize the HTML Clipboard API support in modern browsers first, if available, and fallback to ZeroClipboard.
See  #171 and PR #650 for more info.

thanks.


be able to run the hack scripts from any directory

now you can run the hack scripts from anywhere. Like if you are in the main source directory (parent of hack/) you can ./hack/cluster-openshift.sh up and it will work. Same with the others.

I just tested these scripts with the latest istio-0.5.1 and it all works when i run from the parent directory of /hack (so my commands were ./hack/<the script to run>


Why does a node without animations export with animations? (by design?)

Describe the bug
A node without any animations will show animations with the same name as the node.
To Reproduce
Steps to reproduce the behavior:

make a nodeA and NodeB
Add animation to NodeB and name it NodeA (yes name the animation the same as the name of the other node)
export as gltf + bin and selected objects
export gltf
open gltf in notepadd++

Expected behavior
don't export the node without animations as a node with animations.
Screenshots
If applicable, add screenshots to help explain your problem.
.blend file/ .gltf
If applicable, a zipped folder containing a .blend file for exporter issues and a .gltf file for importer issues. Please take care to include all resources, such as textures in the .zip file.
Version

OS: win 10
Blender Version 3.3.1

Additional context
MSFS allows for animation names the same as node names. but does not allow two animations with the same name.
test_Cube_3.3.zip
untitled.zip

Hello,
Some objects without any animation can be "animated", because of constraints.
Or because you selected only some children, not animated, of a parented animation.
So we need to bake all object animation, even if object is not animated.
If you want to avoid not needed animation, you can use "Optimize animation size", that should delete animation when animation is not needed.

Thank you checking "Optimize a fixed my issuenimation size"


check what is not implemented here

type BirdType = {
  wings: 2;
};

interface BirdInterface {
  wings: 2;
}

const bird1: BirdType = { wings: 2 };
const bird2: BirdInterface = { wings: 2 };

// Because TypeScript is a structural type system,
// it's possible to intermix their use too.

const bird3: BirdInterface = bird1;

// They both support extending other interfaces and types.
// Type aliases do this via intersection types, while
// interfaces have a keyword.

type Owl = { nocturnal: true } & BirdType;
type Robin = { nocturnal: false } & BirdInterface;

interface Peacock extends BirdType {
  colourful: true;
  flies: false;
}

interface Chicken extends BirdInterface {
  colourful: false;
  flies: false;
}

let owl: Owl = { wings: 2, nocturnal: true };
let chicken: Chicken = { wings: 2, colourful: false, flies: false };

function main() {
}

Error:
not implemented

implemented


Deflake tests using a new scheduler

The first commit of this PR is just from #2632. I'll wait until that's in before merging this. (I'll rebase so that we don't have extra merge commits etc.)
The second commit is trivial.
The third commit, um, isn't trivial. I'd suggest taking it in this order:

Review the FakeScheduler API (but not implementation) to see what you can do with it
Review the changes to the tests (which are mostly about changing how some of the tests interact with FakeScheduler)
Review the FakeScheduler implementation

Okay, I'm confused as to why this is still flaky. PTAL anyway - partly as you may spot something, and partly as I think I need a break from this anyway to clear my head about it.

I'm on it :)


[Bug-App]: Point Cloud visualization misses points (max_point limit?)

Describe the bug
Hi there,
there appears to be a bug with the visualization of large point clouds.
The uploaded Object3D should contain 385.000 points, however the white parts are incomplete.
The following shows the result uploading white+red Object3D (size=385.000 points), and the second contains only the white points (size=190.000 points).

I also checked the uploaded pts.json file and it contains all 385.000 points so it may be a bug on the visualization side. If I upload only white or blue, the visualizations work properly.
Perhaps there is a max_point limit that overrides the white ones (they are first in the data structure)?
UPDATE: Swapping white+red => red+white in the np.array yields this upload visualization. So it seems only the last parts up to a max point limit are shown. (Also same results on other browsers / devices)

(Also hint to my other feature proposal, while you're at it ;) https://github.com/wandb/wandb/issues/9009)
Kind regards

Hey @mokrueger Good day and thank you for writing in! Let me help you review this behavior, thank you for reporting this to us.
Would you mind sharing a code snippet as I would like to review how the setup is for the Object3D and I would also like to reproduce this from my end for investigation. Let me know if sharing a code snippet for repro is possible. Thanks!

Hi @paulosabile-wb, thanks for getting back to me.
Here's a snippet that recreates the issue:
import wandb
import numpy as np

x_min, x_max = 0, 1
y_min, y_max = 0, 1
z_min, z_max = 0, 1

num_points = 512 * 384

gt_values = np.random.uniform(
    low=(x_min, y_min, z_min),
    high=(x_max, y_max, z_max),
    size=(num_points, 3)
)

# Just to get some other points for reference
z_offset = 1

# Points will be above the others
prediction_values = gt_values.copy()
prediction_values[:, 2] += z_offset

# Rgb values
rgb_white = np.full((num_points, 3), fill_value=255)  # RGB: (255, 255, 255)
rgb_red = np.array([255, 0, 0])[np.newaxis, :]  # RGB: (255, 0, 0)
rgb_red = np.tile(rgb_red, (num_points, 1))

#Concat
prediction = np.hstack((prediction_values, rgb_red))
gt = np.hstack((gt_values, rgb_white))

# sort values by z such that we can see a cutoff in the visualization
prediction = prediction[np.argsort(prediction[:, 2])]
gt = gt[np.argsort(gt[:, 2])]

point_cloud1 = np.vstack((prediction, gt))
point_cloud2 = np.vstack((gt, prediction))

wandb.init()
wandb.log(
    {
        "pc1": wandb.Object3D.from_numpy(point_cloud1),
        "pc2": wandb.Object3D.from_numpy(point_cloud2)
    }
)

This yields the following visualizations:
pc1 (red+white):

pc2 (white+red):

The white and red arrays are sorted by z-value from low to high. The plots suggest that the first parts of the array are overridden after reaching a max number of points. Based on the cutoff, which lines up kind of nicely, I would assume the cutoff point lies at around 150.000 since both red and white should contain roughly 200.000 points.
Side view of pc1:

@paulosabile-wb, were you able to reproduce the issue?

Hi @mokrueger, thanks for sharing the code to reproduce the issue showing, that was very helpful.
I was able to reproduce this on my end and I am raising this as a bug with our engineering team and we will keep you posted with any updates.


Search-Task not starting after Calibration-Task

Hi,
when I try to search my data using the calibration and search task I recieve the followong warning message after completion of the calibration task:
currentResult.Ms1List.Count = 0 currentResult.Ms2List.Count = 0
datapointAcquisitionResult is null
Cannot proceed. No data files selected.
The search Task will not be started afterwards. The Output directory and the analyzed raw-file can be downloaded via:
https://www.dropbox.com/sh/i4e8hg4ndxu1rql/AADCtxAzuZz1xXL3GSd_1qt-a?dl=0
The MetaMorpheus version used was 0.0.260.0
As far as I understood the calibration task should output a mzML file but I can't see/find it anywhere :/
Any help would be appreciated.
Thank you
Best,
Franz

Hi Franz,
We're still investigating the Calibration Task issue, but from our tests it seems that running the Search Task with a 100ppm product tolerance gives much better results (5000 PSMs) than searching with the default 20ppm product tolerance (400 PSMs).  MetaMorpheus is generally intended for high-res MS1 and MS2 but it may still work with low-res MS2. I'm not seeing resolution info in the scan header of the MS2 scans, but is it indeed low-res MS2 data? I think for now, you will need to skip the Calibration Task (it's optional - you can go directly to the Search Task), but we will get back to you on this issue.
Rob

Hi Rob,
thank you for the info! MS2 spectra are indeed low res (ITMS + c). During calibration Task much more peptides are identified in comparison to solely performing the search task. That is why I was hoping to combine the calibration with the search task. Can calibration of the MS2 scans be an optional feature? In the end I would like to run overall 64 raw files with MetaMorpheus and would like to use the MatchBetweenRuns feature as well. MSI calibration would therefor be great (and probably enough for my needs :D)
Thanks!
Best,
Franz

Hi Franz,
There are a few things happening regarding this issue:

The error you got originally happened due to you having selected a product tolerance that is too restrictrive (25 ppm). This will be fixed in an upcoming release, by giving the user a suggestion of tuning their tolerances. For this file, Param-Medic recommends at least 100ppm, and I would use around 400 ppm product tolerance.
Even with using better initial tolerances, calibrating your files in release 0.0.260 still fails due to an unrelated issue, regarding empty scans with no peaks. This will be fixed in an upcoming release.
Calibration helps a little, by centering ms1 ppm errors around zero, see histogram below. MS2 errors also improve by a tiny amount, but searching even the uncalibrated file can be sufficient.

What do you mean by "much more peptides are identified in comparison to solely performing the search task"?
You assigned Deamidations as variable modifications. We do not recommend using any modifications other than Oxidation of M as variable, since they significantly slow down searches. Instead, try to use a G-PTM-D task prior to using a search task, with selecting a few common modifications in G-PTM-D. A search with an augmented database is fast and gives significantly more PSMs. By selecting these modifications in G-PTM-D "Mod\tDeamidation on N\t\tMod\tDeamidation on Q\t\tMod\tAmmonia loss\t\tMod\tPhospho on S\t\tPeptideTermMod\tAmmonia loss on Q\t\tPeptideTermMod\tAcetald+26", I am able to get around 6000 PSMs, instead of 5000 PSMs using the orginal databases

Oh and there is no need to uncheck Carbamidomethyl of U! Selenoprotein P with accession P49908 seems to be present in your sample, and scan 2299 seems to match  AEENITESC[Common   Fixed:Carbamidomethyl of C]QU[Common Fixed:Carbamidomethyl of U]R
More evidence for this protein is in scans 32398 32352 which match to peptide LVYHLGLPFSFLTFPYVEEAIK only present in that protein

@stefanks: Thank you for all the advice and the information and for looking into this issue and my data in such detail. I will run my files with your recommended settings :D
I will check out Param-Medic asap as well!
To answer your question:
"What do you mean by "much more peptides are identified in comparison to solely performing the search task"?" - Due to the less stringent parameters there are obviously more PSMs and (I would expect) more peptides identified in the sample file. This is of course obvious but slipped my mind somehow yesterday evening. (I am still a rookie in the field of mass spectrometry :/ -  this is the reason why I also missed the product tolerance completly despite my MS2 data being low res (thank you again stefanks and Rob for pointing that out).
"You assigned Deamidations as variable modifications." - This is typical in my lab...deamidations seems to happen a lot during in solution digestions. My colleagues are normally using it during Mascot searches. Deamidation seems to be less of an issue in more acidic milieu using these low pH protein digestion kits. I don't know about FASP digestion - haven't tried this yet.
Once again: Thank you for your help and the continuing development of this sweet piece of software!
Keep up the great work! :D
Best,
Franz

One point that Stefan was trying to make was that it is best practice to perform the G-PTM-D task, which has deamidation as one of the modifications. Then use that database in a search task, with only oxidized methionine as the variable mod. With G-PTM-D, you will see all the deamidations that you expect but you won't pay the same penalty in false discovery rate that you do when you use deamidation as a variable mod. As an experiment, I suggest that you take your data and run the standard G-PTM-D task with adjusted peak tolerances of (10ppm parent and 400ppm fragment). Then run the standard search task with those same tolerances and don't add deamidation. I think that you'll see several PSMs from deamidation.

@trishorts: thank you for clarifying this. I might have another question regarding the G-PTM-D editing of the database but I better check out the publication again first before asking stupid questions ;)

don't hesitate to ask.  Ask anyone that sees me daily. Also, good for others to read the answers. I guess many people will have similar questions.

@trishorts
Thanks! Will do so for sure :D

This should be fixed in 0.0.262, please give it a try!


Added CICERO_DATA environment variable to Cicero Server API

Signed-off-by: Martin Halford<EMAIL_ADDRESS>Issue #514
Added CICERO_DATA environment variable to Cicero Server API in order to allow data files to be located separately to the template archives.
Changes

Added reference to CICERO_DATA environment variable when creating data constant.

e.g. ${process.env.CICERO_DATA}/${req.params.template}/${req.params.data}

Added error handling to check that CICERO_DATA environment set prior to server start.
Added test to check that error handling for CICERO_DATA environment is functioning.

Coverage increased (+0.01%) to 96.25% when pulling 8301db23d0a48c31cf06f8297a27cbb5ca987302 on jeromesimeon:js-server-data into 17c50d86fb1c04bec2eab888bb958f600ece41f1 on accordproject:master.


Enable MeasurementBasedApClientTPC in 2G

Add a new util method to determine the band with the given channel.
Instead of only using the first radio, iterate over all the radios for each device when compute Tx power in MeasurementBasedApClientTPC.
Instead of hardcode the band as 5G, leverage the new method to determine the band for each radio.
Add test cases for the changes.

@pohanhf some questions regarding the radios and channels:

Is it possible to have a channel that cannot be mapped to either 2G or 5G?
Is it possible to have a device with two channels mapping to the same band? e.g. A device with two radios, whose channels are 36 and 60.

@elludraon When I ran "mvn spotless:apply", it formats all the files in the repository. Any way to only work on the changed files? I guess you will have a PR to format them, so I will revert the latest commit.

@elludraon When I ran "mvn spotless:apply", it formats all the files in the repository. Any way to only work on the changed files? I guess you will have a PR to format them, so I will revert the latest commit.

@wuweicaifb - If you want to apply the formatting changes for only your modified files, I believe you can use "ratchetFrom" in your pom.xml plugin configuration block:
<plugin>
  <groupId>com.diffplug.spotless</groupId>
  <artifactId>spotless-maven-plugin</artifactId>
  ...
  <configuration>
    <ratchetFrom>origin/main</ratchetFrom>  <!-- THIS LINE -->
    ...
  </configuration>
</plugin>

Add a new util method to determine the band with the given channel.
Instead of only using the first radio, iterate over all the radios for each device when compute Tx power in MeasurementBasedApClientTPC.
Instead of hardcode the band as 5G, leverage the new method to determine the band for each radio.
Add test cases for the changes.

@pohanhf some questions regarding the radios and channels:

Is it possible to have a channel that cannot be mapped to either 2G or 5G?
Is it possible to have a device with two channels mapping to the same band? e.g. A device with two radios, whose channels are 36 and 60.

I'm not Po-Han but I know about the first one:

We are only dealing with 2G and 5G now, but yes there may be 6G but also there are some "edge cases" of sub-1G bands and all... I'd say if it's outside of 2G and 5G, you can mostly ignore it for now... but please write the code so that we can add 6G to this list soon :)

Q: Is it possible to have a channel that cannot be mapped to either 2G or 5G?
A: No, channels 1 to 11 are only for 2G. channels 36 to 165 are only for 5G. Also, when we talk about channel here, we only mean "primary" channel. In other words, channel 38 is not the case here.
Q: Is it possible to have a device with two channels mapping to the same band? e.g. A device with two radios, whose channels are 36 and 60.
A: No, it is not possible as the above explanation.
Let me know if there are any questions. :)

Q: Is it possible to have a channel that cannot be mapped to either 2G or 5G? A: No, channels 1 to 11 are only for 2G. channels 36 to 165 are only for 5G. Also, when we talk about channel here, we only mean "primary" channel. In other words, channel 38 is not the case here.
Q: Is it possible to have a device with two channels mapping to the same band? e.g. A device with two radios, whose channels are 36 and 60. A: No, it is not possible as the above explanation.
Let me know if there are any questions. :)

Po-Han, I don't think the first answers the second. The second is asking if an AP can be part of two different channels on the same band... E.g., maybe one AP is used for two SSIDs on different channels and both happen to be 5G. Is that allowed?

Q: Is it possible to have a channel that cannot be mapped to either 2G or 5G? A: No, channels 1 to 11 are only for 2G. channels 36 to 165 are only for 5G. Also, when we talk about channel here, we only mean "primary" channel. In other words, channel 38 is not the case here.
Q: Is it possible to have a device with two channels mapping to the same band? e.g. A device with two radios, whose channels are 36 and 60. A: No, it is not possible as the above explanation.
Let me know if there are any questions. :)

Po-Han, I don't think the first answers the second. The second is asking if an AP can be part of two different channels on the same band... E.g., maybe one AP is used for two SSIDs on different channels and both happen to be 5G. Is that allowed?

Yes, it is allowed. It is called dual 5GHz radio mode (or something similar). In that case, that AP should have two unique bssids. Using bssids should be the way to do this.

Deleted the branch by mistake. Restore the branch and reopen the PR now.

@elludraon When I ran "mvn spotless:apply", it formats all the files in the repository. Any way to only work on the changed files? I guess you will have a PR to format them, so I will revert the latest commit.

@wuweicaifb - If you want to apply the formatting changes for only your modified files, I believe you can use "ratchetFrom" in your pom.xml plugin configuration block:
<plugin>
  <groupId>com.diffplug.spotless</groupId>
  <artifactId>spotless-maven-plugin</artifactId>
  ...
  <configuration>
    <ratchetFrom>origin/main</ratchetFrom>  <!-- THIS LINE -->
    ...
  </configuration>
</plugin>

It's just kinda inconvenient to adjust the xml file manually every time. Is there a way to use a parameter in the CLI command to choose files?

@wuweicaifb - Just waiting for most people to push their PRs first so everyone doesn't get merge conflicts. Will apply it to all files.


Benchmarks are failing

Context
https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/576
Test Case

Failure / Counter-example
Restore benchmarks:
restore: syncProgress: (-5830248147419103232) % 1 is out of bounds
--
  | CallStack (from HasCallStack):
  | error, called at src/Cardano/Wallet/Primitive/SyncProgress.hs:151:27 in cardano-wallet-core-2020.7.6-

Database benchmark:
db: timeInterpreter
--
  | CallStack (from HasCallStack):
  | error, called at test/bench/db/Main.hs:340:10 in main:Main

Latency benchmark:
Run benchmark - shelley | 0s
-- | --
  | Non-cached run
  | Action failed. Here are the captured logs:
  | latency: ProcessDidNotStart "cardano-node" cardano-node: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)

Resolution

QA

Fixed in a previous PR.


prototype extension

in jats: contributed-equally: yes/no; not even in jats:group,
author order in metadata?
see bioarchiv tsv for others?
check role (new jats4r recommendation)

see #26

about bioarchiv tsv: no indication about how to fill it:
Question: middle name/initial integration, suffix integration ?

Email
Institution
First Name
Middle Name(s)/Initial(s)
Last Name
Suffix
Corresponding Author
Home Page URL
Collaborative Group/Consortium
ORCiD

jats4r seem to include middle name initials in given-names (example  https://jats4r.org/authors-and-affiliations/#authors-and-affiliations-example1a)


Allow to open/pick a file on device

Problem description
At the moment it is not possible to open a file on the device without the usage of cordova plugins. We should allow to pick a single file and a set of files.
Code snippet
Example api:
const imageBlobs = await tabris.app.open('image/*', {quantity: 'multiple'});

It would also be great to get access to the ContentResolver API to be able to get data about images in the gallery directly, so that you can create galleries in the app without using outdated plugins

@fax1ty While that is an interesting proposal, the api is pretty complex to expose as part of this issue. We will focus on picking a file from the system ui first. Please open a new issue for your suggestions.

Related with https://github.com/eclipsesource/tabris-js/issues/1881

@fax1ty These are indeed related. But pose some technical differences on iOS. We will consider it though.

@fax1ty Btw this plugin allows to query a content resolver: https://github.com/r-cohen/cordova-ContentProviderPlugin

the new fs.openFile() api provides support for this issue.


Make "cshtml" a configurable \ exposed behavior of the view engine

We hardcode the extension in a couple of places today (RazorViewEngine, DefaultViewStartProvider etc). Would make sense to make this a behavior of the host instead.

@DamianEdwards lets decide if we want this for RTM (this is mostly depending on tooling, the fx change is minimal).


Edits from customer comments, issues 173 and 273

Plus some linting cleanup

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Consume-Packages/Configuring-NuGet-Behavior.md
:white_check_mark:Succeeded

docs/Create-Packages/Creating-a-Package.md
:white_check_mark:Succeeded

docs/Reference/extensibility/NuGet-Credential-Providers-for-Visual-Studio.md
:white_check_mark:Succeeded

docs/Reference/extensibility/nuget-exe-Credential-Providers.md
:white_check_mark:Succeeded

docs/Schema/Target-Frameworks.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-add.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-config.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-delete.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-environment-variables.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-install.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-locals.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-push.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-restore.md
:white_check_mark:Succeeded

docs/Tools/cli-ref-update.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@xavierdecoster Thanks for catching those glitches. I've fixed in https://github.com/NuGet/docs.microsoft.com-nuget/pull/612.


fix: multiaddress not constructed on startup

Description
This PR fixes a critical bug where a nodes multiaddr is not correctly constructed/formed. It introduces several improvements to our network operations and worker selection process:

Network Address Handling:

Refactored GetPriorityAddress to better handle public and private addresses
Added support for GCP external IP detection
Improved IP component replacement in multiaddresses

DHT and Peer Discovery:

Updated WithDht function to use NodeData for more comprehensive peer information
Enhanced peer discovery process in the DHT

Worker Selection:

Refactored GetEligibleWorkers to use DHT for finding peer information
Improved connection attempts to eligible workers with better error handling
Added shuffling of eligible nodes to avoid always selecting the same worker

Error Handling and Logging:

Enhanced error handling in Twitter scraper and other network operations
Improved logging throughout the codebase for better debugging

Code Structure:

Moved HTTP client operations to the network package for better organization
Updated imports and package references for consistency

Performance:

Adjusted timeouts and retries for better network performance
Added performance logging for worker selection process

Artifact Handling:

Updated artifact creation and handling process in the assistant

These changes aim to improve the robustness and efficiency of our network operations, especially in peer discovery and worker selection. The refactoring also enhances code organization and error handling across the project.
Testing:

Tested peer discovery and connection in various network conditions
Verified worker selection process with both local and remote workers
Ensured compatibility with existing network operations

Notes for Reviewers
Tested initially and handles current edge cases well even when remote worker node is behind a firewall with no open ports :)
Signed commits

[x] Yes, I signed my commits.

@restevens402 @mudler this is huge! I am sending this to main it works really well. Latency is higher but the stability is rock solid. We can optimize latency next. So stoked to get this out 🚀


feat: Allow specifying CloudTrail S3 kms key and output ECS task role

KMS key

If the cloudtrail s3 bucket is in another account and encrypted using KMS, it needs a decrypt permission to KMS key

ECS task role

Output the role ARN so IAM deny policy can be created & attached to limit permission

I have not tested this myself yet


Remove deprecated min_cluster_size from ScannBuilder in Python

min_cluster_size has been deprecated in proto. However, the Python code scann/scann/scann_ops/py/scann_builder.py still include it in the proto message, which results in a warning [libprotobuf WARNING external/com_google_protobuf/src/google/protobuf/text_format.cc:339] Warning parsing text-format research_scann.ScannConfig: 38:5: text format contains deprecated field "min_cluster_size".
This PR removes the deprecated min_cluster_size from the proto message from ScannBuilder.

+1


how to float a video player over all pages like youtube in flutter?

I want to create a video player like youtube which will appear all over the screen like youtube app.

How should i minimize the video so that it should work also for all screens and should look like this.

It's been weeks that I'm trying to solve this.
Thanks in advance

duplicate of https://github.com/flutter/flutter/issues/60048

Sir there is difference,
Picture in picture is not working for me I've tried to use this, i want
same as in YouTube.
PIP is not the same as this.
On Wed, 1 Jul 2020, 1:56 pm Taha Tesser<EMAIL_ADDRESS>wrote:

duplicate of #60048 https://github.com/flutter/flutter/issues/60048
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/60674#issuecomment-652289072,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AON7AZ4QYICBWOA6LO3AGH3RZL25PANCNFSM4ONER6GQ
.

@zeeshan-haider-shaheen
PiP isn't support yet but if it's implement, it will float over all pages but if you want exact players as Youtube from second screenshot your descriptuon, that would be custom implementation, please ask such questions on stackoverflow
This platform is not meant for assistance on personal code.
Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Thank you for explanation. Now i understand.
On Wed, 1 Jul 2020, 5:28 pm Taha Tesser<EMAIL_ADDRESS>wrote:

@zeeshan-haider-shaheen https://github.com/zeeshan-haider-shaheen
PiP isn't support yet but if it's implement, it will float over all pages
but if you want exact players as Youtube from second screenshot your
descriptuon, that would be custom implementation, please ask such questions
on stackoverflow
This platform is not meant for assistance on personal code.
Please see https://flutter.dev/community for resources and asking
questions like this,
you may also get some help if you post it on Stack Overflow and if you
need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree,
please write in the comments and I will reopen it.
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/60674#issuecomment-652388831,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AON7AZ53KFIEWUS4XEHMFGDRZMTXFANCNFSM4ONER6GQ
.

@zeeshan-haider-shaheen what you are looking for is https://proandroiddev.com/flutter-challenge-youtube-ec5ff36eca9b or https://pub.dev/packages/pip_view


Right eye with perspective distortion with multiview enabled in Vulkan on Oculus PCVR

Whoa. That was a hard title to write.
Here is the thing. An app I'm currently writing uses a shared codebase, based on OpenXR, to perform rendering in both standalone and PCVR modes in Oculus devices (Rift, Quest).
The standalone version performs quite nicely, and shows no undesired distortions whatsoever. That same code, when running in a desktop application for Windows (PCVR mode), is able to render fine in the left eye screen. The right eye, however, shows a noticeable perspective distortion, as in, objects are stretched and curved to the sides of the screen, with no plausible explanation.
Both standalone and PCVR apps use Vulkan, and both have the VK_KHR_multiview extension enabled. Since hello_xr works fine without the extension, I have no reason to think this would be a hardware problem. Debugging confirmed that the data being sent to the shaders regarding perspective and view matrices is the same in both apps. Validation layers do not report anything unusual.
Hardware used by the standalone version is an Oculus Quest 1; for the PCVR version, it is running in a MacOS desktop in Bootcamp, Windows 10, with the GPU being an AMD Radeon Pro Vega 48.
Unfortunately, I cannot imagine this as anything other than a software issue with OpenXR and/or its supporting components - this is why I would like to report the issue here. No workaround has been found so far.

sigh never mind. It is, after all, a driver-or-lower-level issue. The app performs just fine in a laptop with Nvidia hardware - just recently verified. Feel free to close this issue at your earliest convenience.

sigh Never mind. It is, after all, a driver-or-lower-level issue. The app performs just fine in a laptop with Nvidia hardware - just recently verified. Closing the issue as it never was an issue to begin with. Apologies for the inconvenience.


MAT-1466: primary code first revisions

MAT-1466: First pass at generating logic to set and retrieve an object's "primary code". Many of the more complex scenarios, namely choice types and nested paths, are not yet supported, and will be part of a subsequent release. Much of primary path architecture here is subject to change, as it needs to be enhanced to support those complex features.

 Here is an overview of what got changed by this pull request:

Coverage decreased per file
===========================
- src/collectionUtils/TypeScriptInterfaceTransformer.ts  -1

See the complete overview on Codacy


Prepopulate fields that supports it

When prepopulating the field, we only checked if there was no POST
data for the field. But we also need to make sure the field supports
prepoluation. If not, it can create bugs.

@michael-e do you have any objections ?

No, sorry, I just missed that this was awaiting my review.

Thanks!


[Question] confused, Cannot directly invoke  ChatModule._prefill_with_embed   interface with embedding.

❓ General Questions
For llava model,  I want to concateate the prompts embeding and image embedding, then call _prefill_with_embed to run.
But i find follow issues:
I call _embed_func() to get two prompt embeddings, then without image embedding feature, I concat those embedding, call _prefill_with_embed(), report error.

it's looks like we must first call _embed_func () get a embedding var, then call _prefill_with_embed()  with the embedding var, their shape must keep same.
If we directly invoke the _prefill_with_embed() func, report this issues:

Or, I missunderstand those interfaces.
Thanks !!!

I know why now


Make disks editable only in bulk

This is a pipe-dream dependent on the API supporting bulk resize operations. If it did, we could force you to make your disk resizes all at once. This way we could guarantee (or get closer to it) all the choices you make are reasonable. Without this, you can issue a bunch of resize jobs without any reason to believe any of them will ultimately succeed.


Error type": "urn:ietf:params:acme:error:unauthorized" validation file not uploading via ftp

Hello,
I have a WordPress site running on free hosting with byethost. Given this is free hosting I don't get much support and there isn't much documentation regarding getting SSL's on a website. Obviously I can configure anything related to the server nor can I do SSH or install win-acme on the same server as my website. :-)
I have win-acme running on my local Win10 laptop and am running it in full manual operation.  I get to the part about validation and it looks like my only option is ftp (I don't look to have zone file access in cpanel to add a TXT record) so I enter in my ftp credentials but it fails with the error I have provided below. From what I can see it doesn't copy the web.config file that I said "yes" to and it's not copying the validation file yet it was able to create the /.well-known/acme-challenge directory so it's getting access. I can upload files to this directory and I can browse them (I can read a test.txt file I placed in there.
I decided to try using the sslforfree manual solution which requires you to upload a validation file yourself which I did and when it tried to validate it came back with a bot error. This got me to thinking about my robots.txt file. I have denied all bots from crawling the site so I wasn't sure if this was impacting sslforfree and win-acme. I deleted this file and I also disabled Wordfence but the same issue persist with win-acme (the error below) and the bot error with sslforfree. I also added a web.config file that I found online for doing validations but this didn't make a difference. I'm not sure what else to look at or whether my hosting provider is blocking bots (or other things related to this). I emailed them but haven't heard back yet.
Any help would be greatly appreciated! Let me know if more info is needed. Thanks!!
Client version: 2.0.10
Windows version: Windows 10
Relevant part of log file:
[INFO] Authorize identifier: knwebsite.byethost4.com
[INFO] Authorizing knwebsite.byethost4.com using http-01 validation (FTP)
[INFO] Answer should now be browsable at http://knwebsite.byethost4.com/.well-known/acme-challenge/IRvo2YWKq2N9md542_EEaTLMdWZQnGT11Vz2_keOvD4
[WARN] Preliminary validation failed, found (null) instead of IRvo2YWKq2N9md542_EEaTLMdWZQnGT11Vz2_keOvD4.onii_vOsC1WaJ1q8G7QRJz6eamkZUrl4fM8N47656MU
[EROR] {
"type": "urn:ietf:params:acme:error:unauthorized",
"detail": "Invalid response from http://knwebsite.byethost4.com/.well-known/acme-challenge/IRvo2YWKq2N9md542_EEaTLMdWZQnGT11Vz2_keOvD4 [<IP_ADDRESS>]: "<script type=\"text/javascript\" src=\"/aes.js\" >

Hi, your website is probably running using Apache (or nginx) and not IIS. The first thing you need is administrative access to the server, which you may not have. To get SSL working on Apache/nginx you need to be able to update configuration files to set the certificate files etc.
Your host probably has an SSL option in their control panel but it may not be free.
One alternative that works well is to use free CloudFlare to handle your domain, then it gives you SSL automatically.

Thanks so much for the speedy reply!! Sorry, I forgot to mention the server is Apache which is one of the reasons I chose the "M" option.
I definitely can't control the config files so that's not an option however I heard back from the hosting provider and it sounds like they might be blocking such services like ACME (at least on their free hosting package). The email was hard to understand (I don't think English is the first language) so I don't think this is something I can get around. It sounds like the sslforfree error (bot being blocked) is probably accurate.. They have a free SSL option (self-signed) which is the very first thing I tried but they give no instructions on how to get it to work and provided none in their email reply even though I asked for details. I have asked again.
The site is just a test site which is why I didn't want to pay for hosting and I'm using one of the hoster's automated domains so I don't think I can use that on CloudFlare. Hopefully the hoster replies with how to work their free SSL.
Thanks again for your help!!! I greatly appreciate it.

I'm going to close this issue as it appears the process is failing due to the hosting provider blocking the validation process. I hope I get the opportunity to use this software in future. I would like to be able to generate a certificate with it. The support has also been great in response to my issue. Thanks to everyone who works on this software!


tpf.interact() enhancement - support showing background_mask

Problem description
TargetPixelFile.interact() currently marks the aperture pixels with white lines. It'd be great if it has an option to mark the background mask pixels too.
Example
As a proposal, the background mask pixels are marked with dark gray lines, if the user specifies so in interact() arguments.

Environment

lightkurve version (e.g. 1.0b6): 1.11

The request is because the feature would complicate pixel selection workflow without a viable proposal to solve it. See:
https://github.com/KeplerGO/lightkurve/pull/878#issuecomment-708077292


[WIP] Add and use Metadata in ConsulDiscoveryOptions

Description
Hello!
Thank you for delivering Steeltoe 😄 .
I was browsing through the good first issue label and wanted to contribue a change for #438.
I'd like to open discussions on the goals and some details regarding implementation before executing it without the alignment.
Here are my thoughts:

Currently ConsulDiscoveryOptions has a property called Tags (list of strings)
Tags are expected to be in format key=value
Internally some tags are added (such as group, instance zone)
Currently the fallback from Tags to Metadata happens in ConsulRegistration:

  Metadata = ConsulServerUtils.GetMetadata(agentServiceRegistration.Tags);

Here are my questions:

Would you like to keep the current behavior of usings tags as metadata? Should it be controlled by an option in ConsulDiscoveryOptions, f.e. for backwards compatibility?
I guess, you like to keep adding the internal metadata (such as group, instance zone)
What's the naming preference in ConsulDiscoveryOptions - should it be Metadata (well-known term) or Meta (Consul's AgentServiceRegistration propety is called Meta)

I hope, it's not too much - but I wanted to clarify before jumping to code immediately.
Once confirmed and agreed, I will finish the implementation (obviously including tests etc.).
Thanks in advance 😄 !
Fixes #438
Quality checklist

[x] Your code complies with our Coding Style.
[ ] You've updated unit and/or integration tests for your change, where applicable.
[ ] You've updated documentation for your change, where applicable.
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
[ ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
[ ] You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

Thank you for this PR. Since this PR is targeting main which will be release 4.x , we can deprecate the previous functionality with parsing tags as metadata. For functionality such as default groups, as well as property names, we should match as closely as possible the functionality described here: so Metadata for us. The prefix stays same as what is currently i.e. consul:discovery
When back porting to 3.x, we can consider a flag such as 'tagsAsMetadata'

Thanks for your response, @hananiel!
I've completed my first attempt at the implementation. Scope:

Added the Metadata to ConsulDiscoveryOptions
Switched the metadata generation (including the internal generated ones) from the original metadata  instead of Tags
Also exposed regular Tags to ConsulServiceInstance
I've adjusted unit tests

Please let me know if something needs to be adjusted or changed.
Thanks a lot in advance!

Thanks, @hananiel! You got it!
https://github.com/SteeltoeOSS/Documentation/pull/302


Documentation example needs a little bit more ... documentation

This one: https://github.com/nrdg/fracridge/blob/master/examples/plot_diabetes.py

Also, add examples in docstrings: https://github.com/nrdg/fracridge/blob/master/fracridge/fracridge.py#L56
Could follow the examples in the Matlab version: https://github.com/nrdg/fracridge/blob/master/matlab/fracridge.m#L81-L152

This is addressed in #5 , #6 , #7 , #8


Add endpoint /address/[address]/key/[key]

The light simulnet implementation tries to match as close as possible the blockchain behavior by:

Raising an error if the provided key is not a correct hex string
Sending back an empty string if the asked key is not found

Tests are needed and maybe we could also find a better way to provide a key to the method getAccountValue
Closes #186

Test FSWorld.getAccountValue - Non-existent key shows that full simulnet does not behaves the same as real blockchain.


Input normalization of tera and mockingjay

Hi, I found that there is a "_normalize_wav_decibel" function in the   TransformerBuilder, and I'm wondering whether mockingjay and tera always perform this operation regardless of it's training or testing phase.

Hi,
Yes, we apply this operation during training and testing, the target level value can be found here.
Andy

it is very clear, thanks! I really appreciate  the quick reply


Update vulkano 0.33 egui etc

Update to newest egui
Update to newest vulkano
Update to newest winit

To get started with #38, updating to newest egui and vulkano (current github master version).
To merge, I'm gonna wait for next vulkano release.

The next Vulkano release is here! No more waiting necessary.


support schemathesis for asyncapi

Hi @fmvilas
Tagging issue: [schemathesis](https://github.com/schemathesis/schemathesis/issues/713)
Currently, I am looking are their similar check can put for asyncapi,
I am not sure how can put restrictions on requests and responses in publish/subscribe mode? Could you please provide your input?
Some open API testable specifications
Input structure

200 OK responses must have a non-empty body

204 No Content and 205 Reset Content responses must have an empty body

302 Found responses to a POST request must allow the sub-sequent response to use either POST or GET methods

405 Method Not Allowed responses must have an Allow header listing supported methods

500 Internal Server Error responses are always errors

GET fails after successful DELETE (use-after-free rule) [4]

GET fails after an unsuccessful POST (resource-leak rule

Structure of API responses Tests

Check response has an undeclared status code

Check response has undeclared content-type

Check response body matches the schema

Check response has wrong headers or missing required headers

Non-conforming requests are rejected (negative testing)

No information leaks from unauthorized requests

I am not sure how can put restrictions on requests and responses in publish/subscribe mode? Could you please provide your input?

I'm not sure what you mean here. Are you trying to test an HTTP API with AsyncAPI?

I'm not sure what you mean here. Are you trying to test an HTTP API with AsyncAPI?

No, we have some generation tools which will generate messages from the schema and that will be sent over the channel.
In order, my generation tool is properly generating a proper message format according to schema specification.
Do we have any specifications to meet this requirement?


Remove org.apache.pulsar.discovery.service.PulsarServerException

Motivation
There are two PulsarServerException but there's no differences between them, and I don't see any reason for using a different class in this case.
Modifications

Remove org.apache.pulsar.discovery.service.PulsarServerException
Use org.apache.pulsar.broker.PulsarServerException instead

Result
Less duplicate code.

retest this please


Update PowerShell extension to v2021.2.2

This PR fixes https://github.com/PowerShell/vscode-powershell/issues/2993.
You'll need to upload the VSIX asset to your own blob storage

I believe we use it for the command explorer (which is a pane that shows currently defined commands in the UI): https://github.com/PowerShell/vscode-powershell/commit/cc74a42f5bc98d1f6f739e1ec1dd027401bbd3db

Shoot, well unfortunately the vscode-language-client was updated as well - and that's hardcoded to check the VS Code engine version on startup.
2/26/2021 1:50:24 PM [NORMAL] - Connecting to language service on pipe \\.\pipe\PSES_sxpedsvd.bwy...
2/26/2021 1:50:24 PM [ERROR] - The language service could not be started:
2/26/2021 1:50:24 PM [ERROR] - Error: The language client requires VS Code version ^1.52.0 but received version 1.48.0

So there's pretty much nothing we can do until ADS is updated to VS Code engine >= 1.52 if you wanted to get this version.
Is there an earlier version that we could at least update to in the interim until we catch up to VS Code here?

I believe you have the only earlier version, 2020.6.0. Since that version, as you identified we updated the vscode-language-client dependency from a prerelease at 7.0.0-next.14 which required vscode 1.51, to their stable release at 7.0.0 which came with a bump to 1.52. I wouldn't recommend we downgrade to a prerelease version, especially since that update was done in order to fix multiple build and audit issues. I suggest sticking with the previous stable version until ADS updates to 1.52 (which must be around the corner 😄).

Sounds good, we're working on the latest VS Code merge now which should get us up to that point so hopefully that'll make it in for our March release.

No problem. There was a major issue with the 1.54.0 release anyway, but 1.54.2 is dropping today which resolves it.

Hey @Charles-Gagnon, I was just wondering where you all were at with this? I'd also like to consider merging https://github.com/PowerShell/vscode-powershell/pull/3179 which would bring our minimum support VS Code to 1.53 (though I'd go higher if possible) so I want to know what minimum VS Code version you all need us to support. The current latest stable version of VS Code is 1.55.2. Thanks!

We're finishing up the VS Code merge to bring us up to 1.53 so once that's done we should be able to bring in the latest version.
https://github.com/microsoft/azuredatastudio/pull/14883
Beyond that though we haven't come to a decision on timeline for the other merges so can't say when we'd get 1.54+.

Great news, thanks! We may even have a new stable extension for you by then 😄

When do you think you'll have the new version out? We just merged in the VS Code merge so we can get the insiders gallery updated tomorrow if it's going to be at least a few days.

Ah, it'll be next few weeks, not days.

Sounds good. Could you :

Merge in the latest from release/extensions
Remove the changes to extensionsGallery.json (this still won't work on stable, we'll update that when we do our next release)
Update the min azdata engine version to 1.29.0

Once that's done then we can do some testing tomorrow with the linked build and if things look good we'll get this one out in the wild while we wait on further updates.

@Charles-Gagnon this should be done now

Thanks @rjmholt!

Unfortunately we had an issue with the merge that's blocking us from releasing so we don't have a new insiders build today...I'll update once we get that resolved 😄

New insiders build is out! I'll install the extension and run through a few things myself, but would you mind doing some basic testing yourself to make sure things work as you expect given your familiarity with the feature? Would be good to make sure things look good before releasing it to the public (since rolling back isn't easy)

Here's the uploaded VSIX to try to make sure that the one we have uploaded is the correct version : https://sqlopsextensions.blob.core.windows.net/extensions/powershell/ms-vscode.PowerShell-2021.2.2.vsix

So I can install it fine and some features seem to work, but the cmdlet view is empty and in the logs I see a bunch of errors like this which seem to be coming from the extension. These seem familiar to you?
rejected promise not handled within 1 second: Error: Internal Error - System.Management.Automation.ParseException: At C:\Users\chgagnon\AppData\Local\Yarn\bin\tsc.ps1:5 char:13
+     *CYGWIN*) basedir=`cygpath -w "$basedir"`;;
+             ~Unexpected token ')' in expression or statement.

At C:\Users\chgagnon\AppData\Local\Yarn\bin\tsc.ps1:8 char:3
+ if [ -x "$basedir/pwsh" ]; then
+   ~Missing '(' after 'if' in if statement.

At C:\Users\chgagnon\AppData\Local\Yarn\bin\tsc.ps1:8 char:5
+ if [ -x "$basedir/pwsh" ]; then
+     ~Missing type name after '['.

At C:\Users\chgagnon\AppData\Local\Yarn\bin\tsc.ps1:9 char:20
+ ... sedir/pwsh"  "$basedir/../Data/global/node_modules/.bin/tsc.ps1" "$@"
+                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~Unexpected token '"$basedir/../Data/global/node_modules/.bin/tsc.ps1"' in expression or statement.

At C:\Users\chgagnon\AppData\Local\Yarn\bin\tsc.ps1:9 char:72
+ ... sedir/pwsh"  "$basedir/../Data/global/node_modules/.bin/tsc.ps1" "$@"
+                                                                      ~~~~Unexpected token '"$@"' in expression or statement.
   at System.Management.Automation.ScriptBlock.Create(Parser parser, String fileName, String fileContents)
...

...is it being run under Cygwin?

*CYGWIN*) basedir=`cygpath -w "$basedir"`;;

Not purposely...the callstack is very weird. I have no idea what might be causing this but it goes away if I uninstall your extension...

Uhh @rjmholt any ideas?!

This looks like something is trying to run a POSIX shell script with PowerShell

Never seen anything like it before though

It looks like there are three languages involved here.
First a promise is being rejected, which is a JS/TS concept. So some TS program is running things at the top level. I assume through yarn or trying to run yarn.
Then the script that it's trying to run or parse has a ps1 extension, but wherever it's being handed to PowerShell it's failing to parse. What's more, it's not a normal parse error because it's telling you the API call that failed. It sounds like yarn is calling into something that tries to parse the script as a PowerShell script?
And then the thing being parsed is actually Bourne shell script. The syntax that it's failing on is all classic Bourne shell.

Any idea what is executing this code and when? Maybe a stack trace on the rejected promise?

Is bin\tsc.ps1 the "TypeScript Compiler (PowerShell script)"? Just checking an assumption here.

Looks like it's a script generated by this file, used by npm.
For some reason the sh script contents seem to be in the ps1 script.
Based on the top-level error message, I think this is a VSCode execution API trying to run that file somehow

@Charles-Gagnon should I perform a user install of ADS to repro this?

I'm having trouble reproducing it myself:

My suspicion is that something might be set in your local environment. In particular, the sh script has no extension and I wonder if for some reason that's just being picked up to run as a PowerShell script.
I think if we can find more information about where and when this error is occurring on your machine, we might be able to dig deeper.

Interesting, especially since the older (current) version of the extension seems to work fine. @alanrenmsft could you try installing the extension to see if it seems to work for you? If it does then we can probably release it as long as @rjmholt and @andschwa have signed off on it.

(I'll look more into this later, have some other things I need to take care of first)

So this is coming from the languageclient - it's sending a powershell/getCommand message which is then causing this error.
I'm poking around in the language service to see if anything sticks out as to why this would be failing like this

So the callstack of interest seems to be here :
   at System.Management.Automation.ScriptBlock.Create(Parser parser, String fileName, String fileContents)
   at System.Management.Automation.ExternalScriptInfo.ParseScriptContents(Parser parser, String fileName, String fileContents, Nullable`1 definingLanguageMode)
   at System.Management.Automation.ExternalScriptInfo.get_ScriptBlock()
   at System.Management.Automation.ExternalScriptInfo.get_CommandMetadata()
   at System.Management.Automation.CommandInfo.GenerateCommandParameterSetInfo()
   at System.Management.Automation.CommandInfo.get_ParameterSets()
   at Microsoft.PowerShell.EditorServices.Handlers.GetCommandHandler.<Handle>d__3.MoveNext()

from https://github.com/PowerShell/PowerShellEditorServices/blob/master/src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetCommandHandler.cs#L79
I looked around a bit but being not familiar with the code I'm not exactly sure what this System.Management.Automation.CommandInfo stuff is. Are you familiar enough with that to know what it's doing under the covers?
(side note - this actually repros in VS Code too so it does appear to be some environment problem for me)


Problem with html symbols at https://p5js.org/reference/#Foundation

Most appropriate sections of the p5.js website?
Reference
What is your operating system?
Mac OS
Web browser and version
128.0.6613.120 (Official Build) (x86_64)
Actual Behavior
For both the > and >= summary description as visible on https://p5js.org/reference/#Foundation errant symbols are being shown as seen in image below.

Expected Behavior
If mirroring approach that seems to happen for < and <= the symbols can just be omitted so that summary reads "The greater than or equal to operator evaluates to true if ..."
Steps to reproduce
No response
Would you like to work on the issue?
no

I'd like to work on this, I found a few other related bugs in the same foundation section of the reference, all related to the page and url name changes from < type symbols characters like "lt".

I left some discussion on a related issue here https://github.com/processing/p5.js-website/issues/447#issuecomment-2239528853 about how to diagnose the source of the issues, so that you can target a fix in the right spot. Maybe take a look and see where the same reasoning leads you for this one.

Update on this: turns out those operator references don't even exist any more in the p5.js repo! I thought I was going crazy haha, but I think the problem is that when we build the reference, it just creates/modifies new files, but never deletes old ones if items are removed from the reference.


'Amyloid-beta' vs. 'Beta-amyloid' in GO term names

Hello,
I have noticed a lack of consistency in nomenclature of some related terms, which makes it easy to miss a term during a search, if somebody is not aware of the different term 'template'.
Specifically:
'Amyloid-beta / Beta-amyloid' function and process terms use the spelling: 'Beta-amyloid', e.g. "response to beta-amyloid" or "beta-amyloid binding"; whereas the complex term is called "amyloid-beta complex".
Would it be possible to change "amyloid-beta complex" to "beta-amyloid complex" to keep it consistent with the other beta-amyloid terms?
Another subtle discrepancy, which I noticed, is the difference in spelling between:

"long term synaptic depression";
"long-term synaptic potentiation";
"short-term synaptic potentiation".
I am not sure whether the correct spelling should be with a dash / "-", or without it, but I suppose it makes sense to keep this consistent.

Thanks,
Barbara

Barbara, you decide and I fix the terms in the CP :) It's the same to me and happy to go with whatever the community uses preferentially.

Hi @BarbaraCzub
I'm working through the mentions of beta-amyloid in the ontology and for at least one term, there is an equivalence axiom that refers to the ChEBI entry which has the name beta-amyloid:
https://www.ebi.ac.uk/chebi/searchId.do?chebiId=CHEBI:64645
Since ultimately the equivalence axiom refers to a ChEBI id, the difference will not affect that part of GO, but we do like to be in agreement with ChEBI wherever possible, so I was wondering if you could open a ticket with ChEBI to ask if they could update the name entry, and synonyms, as well.  Thank you!

Hi @vanaukenk , thank you for working through these. I've submitted the ChEBI ticket as you suggested: https://github.com/ebi-chebi/ChEBI/issues/3318

I subscribed to the ticket but unfortunately, ChEBI seem to be rather slow working though their tickets. They never seem to have enough hands to deal with them.

Uniprot P05067 is "Amyloid beta A4 protein" - no hyphen. Should all get aligned...
Most discussion in #13388

Hi @bmeldal and @BarbaraCzub
Could one of you contact UniProt to ask if they are willing to update their entries, as well?
I made all of the changes to GO last Friday, but the merge request got hung up with a failed Travis check, so I need to try that again.

Hi @vanaukenk , I've emailed the UniProt helpdesk. I'll post again when they reply.

The Travis build was successful this morning, so the amyloid-beta changes are now committed.  I will keep this ticket open to also address the 'depression' and 'potentiation' issues.

Great. Thank you @vanaukenk.

So we are going for "amyloid-beta"?

Hi @bmeldal, yes,  @vanaukenk has edited the GO terms to contain 'amyloid-beta' (rather than beta-amyloid'). But as you've pointed out the ChEBI ticket has not been picked up by anyone yet, and I am also waiting to hear from UniProt. Hopefully, they'll be able to align the nomenclature with GO.

#13538

Hi @vanaukenk
I have received a reply from Anne at Swiss-Prot:
"Thank you for drawing our attention to the changes occurring in the GO nomenclature. I'll look for the inconsistencies in UniProtKB/Swiss-Prot and let you know. Please be patient, as it may take a little time."
I am aware that the next UniProt release is due out on the 5th of July, so I'll set a reminder to check the amyloid-precuror protein entries after this date, and only follow up on this, if the updates won't have happened by then.

Followed up today.

Swiss-Prot have now updated their entries and the changes should be live on September 27th (release 2017_09).

Anne wrote: "In the vast majority of entries, we were using "amyloid-beta", but we found close to 160 entries which contained the term "beta-amyloid". I made the corrections as you suggested and it should be consistent now."

The names have been updated in CHEBI as well:
https://github.com/ebi-chebi/ChEBI/issues/3318

this looks ready to close :)

Yes, SwissProt and ChEBI have both updated the terminology, as we requested.