fix(deps): bump

Applied mkpr on undefined
sed s/"github-repository-provider": "^.*"/"github-repository-provider": "^7.18.6"/

:tada: This PR is included in version 10.0.29 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Car Unrecognized Error

Describe the bug
I just replaced my front windshield and reconnected my comma 2 v0.8.12 for my 2021 Prius Prime and it started working in the beginning, but then I noticed I had the power cord hanging out the side panel and wanted it to  look better by coming out the hole from the rear view mirror. When I did that I ended up disconnecting the ethernet cord not knowing it disconnect and after that my display continues to say car unrecognized. I rebooted it, uninstalled the software and reinstalled it, reconnected everything and still get the same error.
What hardware does this issue affect?
comma two
Provide a route where the issue occurs
e8dd6bf379531625
openpilot version
0.8.12
Additional info
Not sure what provide a route means so I just wrote down my Dongle ID.

This means the comma power isn't properly connected. Ensure that it's fully seated in the OBD port and both ends of the ethernet cable are fully seated. Check out discord.comma.ai for help.

I checked the connections and they are both fully connected. I just checked again and get the same error.


Update version of webpack-dev-server to 4.1.1

Laravel Mix Version: 6.0.29

Description:
Currently, we're using webpack-dev-server 4.0.0-rc.1. It has a known issue with ansi-html 0.0.7. I suggest using webpack-dev-server 4.1.1 as they have resolved the issue by using another safe fork.

Thanks for merging. What do I have to do to get this update into my project? When I did npm install laravel-mix in a fresh folder it still shows as having the 4.0.0-rc.1 version of webpack-dev-server. Similarly yarn upgrade didn't seem to update the package.json file as I would have expected.

I'll be tagging and publishing a point release sometime tonight

@arborrow @tientv-geo I've published a new release. Should be good to go now!


fix rbac issues

fix rbac issues . because the k9s name do not support space .

Could you describe the issue and your use case?


GEODE-3075: initial flow adding the new client protocol to core.

Create ServerConnectionFactory, which creates either instances of LegacyServerConnection (identical in functionality to the old ServerConnection) or NewProtocolServerConnection (which is currently basically a stub, but will never get called unless a feature flag is set).
This is the initial work for GEODE-3074, and will allow us to continue to work on further tasks for that project.
An explicit goal with this PR is to not disturb any existing functionality. Unless a feature flag is set and a connection with a certain magic byte is received, server connections will work as before. If you see something that you think may break, please let me know.
Have a nice day!

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

I'm running precheckin on this PR & will merge it to develop when finished

There was a failure in one of the new tests
:geode-core:integrationTest
org.apache.geode.internal.cache.tier.sockets.ServerConnectionFactoryIntegrationTest > testNewProtocolHeaderLeadsToNewProtocolServerConnection FAILED
org.apache.geode.GemFireConfigException: The locators attribute can not be empty when the mcast-port attribute is non-zero.
at org.apache.geode.distributed.internal.InternalDistributedSystem.initialize(InternalDistributedSystem.java:603)
at org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:350)
at org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:338)
at org.apache.geode.distributed.internal.InternalDistributedSystem.newInstance(InternalDistributedSystem.java:330)
at org.apache.geode.distributed.DistributedSystem.connect(DistributedSystem.java:205)
at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:217)
at org.apache.geode.internal.cache.tier.sockets.ServerConnectionFactoryIntegrationTest.testNewProtocolHeaderLeadsToNewProtocolServerConnection(ServerConnectionFactoryIntegrationTest.java:50)

@bschuchardt Was that the only failure? It looks like another test had set mcast-port to a non-zero value and failed to clean up the environment
I'm rerunning precheckin; will continue working on top of this branch and hopefully this passes. If that's the only failure, I would think it should be safe to merge with the one-line added change.

This failed due to Spotless; closing in favor of #597.


Revert changes done for v3.7.1 release

Signed-off-by: Humble Chirammal<EMAIL_ADDRESS>Additional Note:
Required this change before we merge any PRs to release 3.7 branch.

Helm values.yaml and minikube.sh needs update too? https://github.com/ceph/ceph-csi/pull/3330/files

minikube.sh is already on canary. ptal.. thanks. @Rakshith-R


Lazy loading FIRStorage images with FirebaseCollectionViewDataSource (Swift)?

I'm currently setting images within populateCellWithBlock using a FIRStorage ref and dataWithMaxSize method. The images show, but as you scroll, there is a flicker of a previous image from the reused cell.
  self.dishesSource.populateCellWithBlock() {

        let cell = $0 as! dishCVCell
        let dish = $1 as! Dish

        let dishImgRef = FIRStorage.storage().referenceForURL(dish.imageURL)
        dishImgRef.dataWithMaxSize(1 * 1024 * 1024) { (data, error) -> Void in
            if (error != nil) {
                print(error)
            } else {
                cell.dishPhoto.image = UIImage.init(data: data!)
            }
        }
    }

To avoid having a previous image flicker, I've set the image to nil in the prepareForReuse method within my custom CollectionView Cell:
override func prepareForReuse() {
        dishPhoto.image = nil
    }

It works, but I was wondering if there was a more efficient/lazy loading way to load cell images in the background when using FirebaseUI FirebaseCollectionViewDataSource?

That sounds about right, I don't think your code can be more efficient/lazy than it currently is since there's no way to know what data will go in which cell until that cell is about to be presented.
A few things to note, though:

Looks like we don't document whether or not dataWithMaxSize(completion:) will execute its callback closure on the main thread or not, which is important here because you're setting UI stuff in that closure. Our docs have been kinda suffering, hopefully we get to that soon... :(
If your client is on really bad internet and dataWithMaxSize(completion:) takes a long time to finish, it may be possible for a stale callback block to present the wrong image on a cell. Also, if the user scrolls very quickly, you'll queue up a whole bunch of image downloads even though the amount of images you end up presenting doesn't actually increase. To fix these two issues you should cancel downloads if they're still running and the cell they should go into has scrolled off the screen.
prepareForReuse() requires a super call.

This sort of question is generally better suited for the StackOverflow format, but I'm answering it here because it's an especially common use pattern and it reflects flaws in our docs I'd like to fix at some point.

Gonna close this since it hasn't been active in a while.


Update tapir-core, tapir-http4s-server, ... to 1.8.5

About this PR
📦 Updates

com.softwaremill.sttp.tapir:tapir-core
com.softwaremill.sttp.tapir:tapir-http4s-server
com.softwaremill.sttp.tapir:tapir-json-circe
com.softwaremill.sttp.tapir:tapir-openapi-docs
com.softwaremill.sttp.tapir:tapir-refined
com.softwaremill.sttp.tapir:tapir-swagger-ui

from 1.8.4 to 1.8.5
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.tapir" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.softwaremill.sttp.tapir" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, version-scheme:early-semver, commit-count:1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (96eb5cf) 50.00% compared to head (bed22cf) 50.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #487   +/-   ##
========================================
  Coverage    50.00%   50.00%
========================================
  Files            5        5
  Lines           84       84
========================================
  Hits            42       42
  Misses          42       42

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add clusterwide compaction for dbs

COUCHDB-2492
Still missing: per view compaction

Does it works?
Compiled src/chttpd_httpd_handlers.erl
/home/kxepal/projects/asf/couchdb/couchdb/src/chttpd/src/chttpd_db.erl:236: syntax error before: 'end'
/home/kxepal/projects/asf/couchdb/couchdb/src/chttpd/src/chttpd_db.erl:17: function handle_compact_req/2 undefined
Compiling /home/kxepal/projects/asf/couchdb/couchdb/src/chttpd/src/chttpd_db.erl failed:

Does it works?

ah good catch, had some leftovers from the changes i already made for view copaction

+1 after indentation and squash

changing my mind on this to -1, I commented on the jira ticket COUCHDB-2492 with more justification.

feel free to revert it

its on master already

added some comments to the ticket


Get model value by string

Would be helpful to have a function that lets you get the current value of a model component by its name:
>>> model.get_component('parameter_1')
{'parameter_1':42}

>>> model.get_component(['parameter_1', 'parameter_2'])
{'parameter_1':42, 'parameter_2':64}

or maybe:
>>> model.components['parameter_1']
42

@enekomartinmartinez this would be cool to include in 2.0

Yes, I added the milestone because this was already added. I needed that function for another project. I also added the possibility of getting back the full lookup or data series that is used for interpolation with get_series_data:
getitem
get_series_data
Note get_series_data only works with external objects as the data information need to be retrieved from a full object.


Support reading random rows in read_csv

It is very common to read random rows in a large csv file, typically for testing with a small dataset, or fit the limit of memory. The parameter nrows is used for read the first n lines, but I didn't find any feature to read random lines. Such parameter might be named keeprows (opposite to skiprows), which supports:

int, e.g. keeprows=100 means keep 100 random lines (uniformly)
float in (0, 1), e.g. keeprows=0.05 means keep 5% of total lines
list of int(or iterable), e.g. keeprows=[1, 3, 8] mean to keep line 1, 3, and 8

duplicate of #3132
yes, this is a good idea.


PaginatedDataTable loading indicator compliance with Material Specification

his PR change the loading indicator of the paginated data table with a linear progress indicator like describe in the ticket (#102861)
List which issues are fixed by this PR. You must list at least one issue.
#102861
Pre-launch Checklist

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[x] I signed the [CLA].
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is [test-exempt].
[x] All existing and new tests are passing.

@wer-mathurin Thanks for your contribution! Are you interested in addressing the review comments? It's fine if not, we can save this PR and attach it to the issue so that someone else can pick it up in the future.

@wer-mathurin thank you for your contribution! i'm going to close this PR since it's not making progress but please don't hesitate to file a new one if you are interested in working on this again!


The creation of ReadStats should take into account the user configuration of sample_num

Bug Report

What version of TiKV are you using?
https://github.com/tikv/tikv/commit/a7d1595f5486616be34e0cf2bbf372edb5f0e85a
What did you expect?
The sample_num of ReadStats should be updated along with the user config. However, in the current implementation, TiKV uses ReadStats::default() to create each ReadStats without considering the actual sample_num config.
https://github.com/tikv/tikv/blob/a7d1595f5486616be34e0cf2bbf372edb5f0e85a/components/raftstore/src/store/worker/split_controller.rs#L397-L404
https://github.com/tikv/tikv/blob/a7d1595f5486616be34e0cf2bbf372edb5f0e85a/src/storage/metrics.rs#L26-L34
What did happened?
If the user adjusts the default config and sets a large sample_num, the Load Base Split may not work due to the insufficient number of the sampled key range.

/type bug
/severity Moderate

/assign JmPotato

can I try to fix it?

can I try to fix it?

@JayiceZ Of course! However, I don't have any idea how to fix this currently. The problem here is that we don't have a good place to pass the config to local_read_stats. Maybe you can take a explore here 🤔.

can I try to fix it?

@JayiceZ Of course! However, I don't have any idea how to fix this currently. The problem here is that we don't have a good place to pass the config to local_read_stats. Maybe you can take a explore here 🤔.

In my opinion.
SplitConfig Change happened here.https://github.com/tikv/tikv/blob/1047b51285456e702b66253da26c7f14d582ff0c/components/raftstore/src/store/worker/split_config.rs#L83
and maybe we can add a static var to replace DEFAULT_SAMPLE_NUM,like:
lazy_static! {     static ref SAMPLE_NUM ...... }
and it will be updated when ConfigChange in dispatch() contains "sample_num"
how's that?🤔

can I try to fix it?

@JayiceZ Of course! However, I don't have any idea how to fix this currently. The problem here is that we don't have a good place to pass the config to local_read_stats. Maybe you can take a explore here 🤔.

In my opinion. SplitConfig Change happened here.
https://github.com/tikv/tikv/blob/1047b51285456e702b66253da26c7f14d582ff0c/components/raftstore/src/store/worker/split_config.rs#L83
and maybe we can add a static var to replace DEFAULT_SAMPLE_NUM,like: lazy_static! { static ref SAMPLE_NUM ...... }
and it will be updated when ConfigChange in dispatch() contains "sample_num"
how's that?🤔

LGTM. One suggestion is that in order to keep everything tidy, you may want to make SplitConfigManager static rather than one of its fields and change all of its usages to the static variable.


Cultural Enrichment: Developer Music Playlist

Top 90s and Millenial hits for developers to work on.

Ira — All the metal. Vengeful Ascenion
Raul — More metal, hip hop, "all over the place". Low tempo techno.
Vinnie — Peaceful Piano Playlist on Spotify, Alan Walker - Alone, Game of Thrones Soundtrack
Tina — Peaceful Piano Playlist on Spotify. Skinny Puppy. Tori Amos. Listens to different music depending on tier of code she's working on.
Jorge — High BPM. Workout music. Programming playlist on spotify
Mohammed — Old stuff. The Doors. Led Zeppelin. Cher. Pink Floyd. Contemporary pop (Adele)
Scott — The National. Beck. Calexico.
Rae — Spotify playlist called "Women of Metal". Her own playlist. Glitch Mob.
Jes — Nothin'.


Error that has happend to every pointshop 1 after update..

[ERROR] addons/pointshop-master/lua/pointshop/sv_player_extension.lua:295: attempt to index field 'PS_Items' (a nil value)

PS_HasItem - addons/pointshop-master/lua/pointshop/sv_player_extension.lua:295
PS_HasItemEquipped - addons/pointshop-master/lua/pointshop/sv_player_extension.lua:299
3. fn - addons/pointshop-master/lua/pointshop/sh_init.lua:145
4. unknown - addons/ulib/lua/ulib/shared/hook.lua:110

I downloaded this from github repository and put it on my LocalServer (testing) with no addons but ulx and ulib. Could ulib / ulx be coursing this?
Errors everywere

Is it still getting errors?

Yes still happend with the 1.3 and master version.

Not happend if LUX isn't installed, haven't any problems now.


Block Factory Expansion: Generating Block Definitions for Blocks with Connections

Previously, generating the block definition depended on functions that acted on specifically BlockFactory’s workspace rather than any workspace provided as a parameter. This led to errors loading the page when the Block Exporter was generating block definitions for blocks with connections.
Functions shared between factory.js and Block Exporter Tools are now not specific to single workspace.

This change is

@picklesrus @vicng @evd2014

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


unable to create a pv due to VOL_DIR: parameter not set

I'm running rke2 version v1.22.7+rke2r2 in 3 nodes. Today I decide to reinstall my application and I'm not able to do it anymore due to a problem in claiming PV.
I have had never this problems before, and I think is due to an update on local-path-provisioner but I'm not sure I'm still a newbie about kube.
Anyway these are the commands I run before installing my solution:
kubectl apply -f https://raw.githubusercontent.com/rancher/local-path-provisioner/master/deploy/local-path-storage.yaml
kubectl patch storageclass local-path -p '{"metadata": {"annotations":{"storageclass.kubernetes.io/is-default-class":"true"}}}'

I omitted metallb. Then as a test I try to install the test you specified:
kubectl create -f https://raw.githubusercontent.com/rancher/local-path-provisioner/master/examples/pvc/pvc.yaml
kubectl create -f https://raw.githubusercontent.com/rancher/local-path-provisioner/master/examples/pod/pod.yaml

What I see is that the pvc stays in a PENDING status, then I check the pod creation in local-path-storage namespace and I see that the helper-pod-create-pvc-xxxx goes in error.
I try to get some logs and the only thing I was able to grab is this:
 kubectl -n local-path-storage logs helper-pod-create-pvc-dd8cecf3-d65b-48f7-9e04-d56a20573f8e -f
/script/setup: line 3: VOL_DIR: parameter not set

So it seems VOL_DIR is not set for whatever reason. But I never did a custom configuration, it always starts without problem, and to be honest I don't know what put in VOL_DIR env variable and where.
I tried also to reinstall a new fresh rke2 but same problem

Hello, I'm fixing the problem.
Please use v0.0.21 https://github.com/rancher/local-path-provisioner.git, thanks.

kubectl apply -f https://raw.githubusercontent.com/rancher/local-path-provisioner/v0.0.21/deploy/local-path-storage.yaml
I tested it ,works well.

Hello all,
The deploy manifest in master branch is fixed.
The master branch is for development, so please use the v0.0.x (stable release) for production use.


Add function to control UART FIFO trigger levels

The RP2040 has a register to change the UART FIFO level at which an interrupt will be generated, but this is not exposed in the SDK. The only time it is used is within the uart_set_irq_enables function, where it is set to the minimum value. I wrote a function uart_set_irq_fifo_levels to configure it to any of the possible values (1/8, 1/4, 1/2, 3/4, and 7/8 full).
There is a slight inconvenience that uart_set_irq_enables resets them to 1/8, so every time that function is called uart_set_irq_fifo_levels must be called again to set the chosen values. This could potentially be fixed by removing the lines in uart_set_irq_enables that does this, but I didn't want to change the functionality of an existing function to keep backwards compatibility.
I wrote some code to test this function, which can be found here, along with it's output.

I'm not sure if they're relevant to your change here, but see also #548 and #500 and #568


Wrong EPIC link in v3.0.54

I'm testing importing JIRA to ADO and the records don't map to the EPICs correctly.
It worked in the previous version i used earlier today.
The TargetOriginId attribute was changed from v2.3.117 to v3.0.54.
Before under Links it was:
{
"Change": 0,
"TargetOriginId": "AS-14",
"TargetWiId": 0,
"WiType": "System.LinkTypes.Related"
},
{
"Change": 0,
"TargetOriginId": "AS-12",
"TargetWiId": 0,
"WiType": "System.LinkTypes.Hierarchy-Reverse"
}
Now it is:
{
"Change": 0,
"TargetOriginId": "AS-14",
"TargetWiId": 0,
"WiType": "System.LinkTypes.Related"
}
The EPIC reference is now at a different place, and instead of "AS-12" it states the ID.
"Author": "xxx.com",
"Time": "2022-12-13T15:59:41.786+02:00",
"Index": 3,
"Fields": [],
"Links": [
{
"Change": 0,
"TargetOriginId": "15652",
"TargetWiId": 0,
"WiType": "System.LinkTypes.Hierarchy-Reverse"
}
If i manually change 15652 to "AS-12" it mapping is OK.
I'm using the same config file.
config-agile.json.txt
These are the exports of the same item in the old/ new versions:
Old.json.txt
New.json.txt
export logs:
jira-export-log-221227-184635.txt
jira-export-log-221227-184639.txt

Is it possible i'm missing something else ?
If i import record #2 while #1 is an epic, i get an error.
f i import record #2 while #3 is an epic, it is OK.
If i import EPIC record first and in a separate process the STORY, i get an error "'[Added] AS-15/4640->AS-12/-1 [System.LinkTypes.Hierarchy-Reverse]' - target work item for Jira 'AS-12' is not yet created in Azure DevOps/TFS." even tough "AS-12" already exists in ADO.
What is the proper way of importing records with "parent" and "epic" links ?

I had the same error:
[E][08:54:12] '[Removed] B4DPBBANCA-22/7410->B4BDBBANCA-20/-1 [System.LinkTypes.Hierarchy-Reverse]' - target work item for Jira 'B4BDBBANCA-20' is not yet created in Azure DevOps/TFS
[E][08:54:12] '[Added] B4DPBBANCA-22/7410->B4BDBBANCA-20/-1 [System.LinkTypes.Hierarchy-Reverse]' - target work item for Jira 'B4BDBBANCA-20' is not yet created in Azure DevOps/TFS.

TargetOriginId for Epic links are being set to issue ID instead of issue key.
Bug has been identified but not yet repoduced. We will work on a solution as soon as possible :)
@AssafVerona, if possible, include a screenshot of the epic issue and the issue with the epic link to help with bug reproduction. Make sure that the epic link is visible.

@AssafVerona! Looks about the same as my test run. I'm able to migrate epic links without problems.
Here is an example:

Your config looks the same as mine with regards to the epic link field and the link mapper for Epics, so I think we can rule that out.
Has the epic link field changed name in your Jira installation? The default is "Epic Link"

Hi,
The config i uploaded was wrong.
The "download-options" was set to 0.
You can close.

OK, great to hear! :)


Backend does not listen?

The service does not listen although it reports that the embedded Tomcat is initialized.
Tomcat initialized with port(s): 8080 (http)
No errors are reported.
I've tried the latest commit with Java9 and then checked out commit 492a3670ec0c8d0ba55981b52c2562350e6758e6 and tried Java8. Still the same problem.
Now, with Java8, I'm using the following command:
java -jar kafka-visualizer-rest-1.0-SNAPSHOT.jar --zookeeper=localhost:2181 --env=PROD --kafka=localhost:9094

What does the server log look like? Should print the following when it's ready to serve requests:
2018-02-27 17:57:45.964  INFO 15772 --- [main] s.b.c.e.t.TomcatEmbeddedServletContainer : Tomcat started on port(s): 8080 (http)
2018-02-27 17:57:45.970  INFO 15772 --- [main] com.enthusiast94.kafkavisualizer.App     : Started App in 12.262 seconds (JVM running for 13.85)

I can't find the 'Started App in...' in my stdout. It looks like the application hangs on something. Here is my log: https://gist.github.com/labedzkim/bc195fab4cb47cf0729217757d2e5bc0.

Hmm that's odd. After adding all the topics, it should move onto brokers and then start consuming messages from all these topics. In your case it seems to get stuck during the topic finding stage. Since I won't be able to reproduce this issue on my machine, you'll have to debug this by running the app in development mode (instructions included in the README.md). All the topic finding logic is contained within com.enthusiast94.kafkavisualizer.service.KafkaTopicsTracker.

In debug mode I've found some errors related to wrong configuration of kafka listeners. Need to check it.

I migrated from wurstmeister/kafka docker distribution to Confluent and now it's ok.

Oh so you were running it in docker? Do you mind contributing your docker integration work to this repo? It would be super useful to others as well. Thanks!

Hey! I'm not excluding this option. Now I'm running this as an outside-docker service but I'm a docker container seems unavoidable. When I have I'll make a pull request. Cheers!


Correct check for undefined variable

The code was comparing the result of typeof with a variable named undefined.
As typeof returns a string it should compare to 'undefined'.

LGTM

LGTM


Invalid BooleanDt object construction in tinder-generated objects

Tinder generated objects which use a ca.uhn.fhir.model.primitive.BooleanDt element (as  ca.uhn.fhir.model.dstu2.composite.CodingDt), use a BooleanDt default constructor which throws a NPE when element getter is called.
To Reproduce
BooleanDtTest in hapi-tinder-plugin project reproduces the bug
Expected behavior
BooleanDt not explicitly initialized should be initialized by default as new BooleanDt(false) instead of as BooleanDt(), which produces NPE when getter is invoked.
Environment:

HAPI FHIR Version: 6.2.5

Note to fixer: I think the template involved in the generation of the failing code is in file:
hapi-fhir/hapi-tinder-plugin/src/main/resources/vm/templates.vm (currently at line 105)
        public ${child.primitiveType} get${child.methodName}() {
		return get${child.methodName}Element().getValue();
	}

A better fix could be to change the BooleanDt constructor from
	public BooleanDt() {
		super();
	}

to
	public BooleanDt() {
		super();
		this.setValue(Boolean.FALSE);
	}

Solution is to check the BooleanDt property state before using the getter like this
!codingDt.getUserSelectedElement().isEmpty() && codingDt.getUserSelected();


Pandas notebook problems

[ ] .drop() example missing inplace=True. Might also want to use keyword for axis for clarity

and use 'columns' or 'rows', not 0,1 which was a crazy design decision on the pandas part.

Demo .sel since we say you can do it in the Xarray notebook


windows build

Trying to build a wasm code windows fails with the following error:

the docker build should work, please re-open or comment here if not


JSON output isn't in the expected JSON format.

I see, you are using xml2json but the JSON output isn't most appealing and easy to use.
For eg:
I get the response like below
[ { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '  <ListInventorySupplyResult>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '    <MarketplaceId>MarketplaceId</MarketplaceId>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '    <InventorySupplyList>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '      <member>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '        <Condition>NewItem</Condition>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '        <SupplyDetail/>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '        <TotalSupplyQuantity>1447</TotalSupplyQuantity>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '        <EarliestAvailability>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '          <TimepointType>Immediately</TimepointType>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '        </EarliestAvailability>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '        <FNSKU>FNSKU</FNSKU>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '        <InStockSupplyQuantity>147</InStockSupplyQuantity>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '        <ASIN>ASIN</ASIN>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '        <SellerSKU>SellerSKU</SellerSKU>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '      </member>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '    </InventorySupplyList>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '  </ListInventorySupplyResult>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '  <ResponseMetadata>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '    <RequestId>5ome-24ndom-id</RequestId>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '  </ResponseMetadata>' },   { '<ListInventorySupplyResponse xmlns="http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/">': '</ListInventorySupplyResponse>' } ]
While expected format is:
{"ListInventorySupplyResponse":{"xmlns":"http://mws.amazonaws.com/FulfillmentInventory/2010-10-01/","ListInventorySupplyResult":{"MarketplaceId":"MarketplaceId","InventorySupplyList":{"member":{"Condition":"NewItem","SupplyDetail":{},"TotalSupplyQuantity":"1447","EarliestAvailability":{"TimepointType":"Immediately"},"FNSKU":"FNSKU","InStockSupplyQuantity":"1447","ASIN":"ASIN","SellerSKU":"SellerSKU"}}},"ResponseMetadata":{"RequestId":"5ome-24ndom-id"}}}'
`
Is this fine and expected result?
Thanks

@igauravsehrawat
I have made some changes to fix it.
Would you please take the latest version and verify it?

What a treat, thank you so much.
Works good for the functionalities provided.
On digging deep, I found out it doesn't have functionalities for FulfillmentOutboundShipment. Not sure if it is within the scope of the package.
Thanks Again.

Yes, It is in our roadmap/ We'll be going to add that soon.

Awesome, great.
Thanks


Unify methods to fill advert slots

What does this change?
This PR is a refactor that merges the two different ways we can fill advert slots on the page.
Previously, non-dynamic (static, and what we previously called external) adverts could be filled either via:

fill-advert-slots.ts: this is where our bundle selects all of the slots from the DOM and attempts to fill them. We refer to the adverts picked up in this phase as static ad slots. We assume they're server side rendered, to guarantee presence in the DOM, regardless of when the commercial JS runs.
fill-external-slots.ts: this is where we select all of the external ads (marked by a prefix in their ids) from the DOM, but also add an event listener so external code can fire an event that notifies us to fill a slot. This is useful for when we can't guarantee the slot will be in the DOM before the commercial JS runs.

This PR unifies the two methods above into one by first renaming fill-advert-slots.ts to fill-static-advert-slots.ts, and removing the external path. The main observation here is that the external slots already present in the DOM will be filled as if they were static.
For any slots that we miss, we add an event listener as before so we can be notified that they require filling. We add this listener before we attempt to fill advert slots, so that we don't miss any events. Note this requires all adverts that aren't server-side rendered must fire an event, in case the commercial JS hasn't run before the slot is present in the DOM.
Finally, we add an E2E test with a thrasher that adds a slot with a couple of seconds of delay, before firing the event. This will exercise this new code path.
Why?
This should simplify the number of ways through which we can fill a slot on the page.

Is it possible that a gu.commercial.slot.fill event may be fired between the eventListener being created and the static ad slots on the page are collected? If so, this could mean displayAd() is called twice for an ad slot

I believe it is possible, although I think there's guards in place to prevent displayAd being called for a slot that's already been filled. It's just important we don't start listener some time after collecting up the slots, as this leaves a window in which we can miss eventd.
I'll leave it as it is for now, but I'll have a think about a way to make the guard logic more clear (it shouldn't matter if you fire an event for a slot that's already been filled, or vice versa).

What do you think to moving the call to createSlotFillListener(); to line 72 of fill-static-advert-slots.ts? That way, we don't set the listener if the user is adFree and we don't setup Prebid between the creation of the eventListener and the collection of the static ad slots.

I'm going to remove that ad free check as it's superfluous - we perform that check much earlier.
I've never seen issues with dynamic ad slots being filled before Prebid is ready, but it might be worth checking that separately.


MTB: changed flag input format

kubectl-mtb run -n test1,test --as nody,bob
Right now hardcoded for 2 tenants but can be made dynamic, will do when we will get that requirement as it will lead to a major change in generic way of writing code of a benchmark.
/assign @JimBugwadia

/lgtm
/approve

/lgtm
/approve


logger use milliseconds instead of seconds for reporting elapsed time (#5400)

By the way, if you put the issue number in the body of the comment message as "Fixes #5400" (rather than in the title), then GitHub will automatically close the issue when the patch lands.

Ah, that makes sense. Will do going forward, thanks!


Bulk Cropping support

Let me explain through example because i think that would be better. So i was watching a very old show which was made in 4:3 aspect ratio initially. I have this habit of taking a lot of screenshots of my favourite shows. Specially when the scene has a beautiful scenery or a memorable quote. Now i have to go through every pic one by one to crop the black borders. The same thing happens when i take screenshots from YouTube, i have to crop them in 16:9 ratio. In these scenarios i think a bulk cropping option would be super useful. Where you can just select multiple images, choose a aspect ratio and all the images will be cropped for respective setting.

I will try

I added ability to use AspectRatio preset, combine it with crop resize mode to achieve described result, for more info check  #1201
but, threr was no cropping, so i will add option to not fit also

Added option to disable fit

Thanks a lot


the first query is failure due to below error

thread 'tokio-runtime-worker' panicked at C:\Program Files\Rust\Cargo\registry\src\index.crates.io-6f17d22bba15001f\rusqlite-0.31.0\src\lib.rs:779:17: already borrowed: BorrowMutError note: run withRUST_BACKTRACE=1environment variable to display a backtrace thread 'tokio-runtime-worker' panicked at C:\Program Files\Rust\Cargo\registry\src\index.crates.io-6f17d22bba15001f\rusqlite-0.31.0\src\lib.rs:779:17: already borrowed: BorrowMutError thread 'tokio-runtime-worker' panicked at C:\Program Files\Rust\Cargo\registry\src\index.crates.io-6f17d22bba15001f\rusqlite-0.31.0\src\lib.rs:779:17: already borrowed: BorrowMutError thread 'tokio-runtime-worker' panicked at C:\Program Files\Rust\Cargo\registry\src\index.crates.io-6f17d22bba15001f\rusqlite-0.31.0\src\lib.rs:779:17: already borrowed: BorrowMutError

https://github.com/rusqlite/rusqlite/blob/6d9f01c06ee10a7fc6f2d2114fa8b91939606c03/src/lib.rs#L779
+
https://doc.rust-lang.org/std/cell/struct.RefCell.html#method.borrow_mut


Allow custom configuration of partition metadata producer

Moved from: https://github.com/spring-cloud/spring-cloud-stream/issues/744.
From @PedroAlvarado

At the moment, we use the DefaultKafkaProducerFactory to create a new producer to fetch partition metadata. This producer uses a combination of hard-coded and default producer configuration making it difficult to tailor its configuration.
A sample use-case for this feature is the case of local development where we want to fail fast when, say, the kafka broker is not working correctly. In this scenario, currently and out-of-the-box, spring cloud stream will wait 10 minutes (60000ms=max.block.ms * 10=SimpleRetryPolicy.maxAttempts) to fail. Moreover, there is not indication that retries are taking place, hence, the logs look like the application may have started successfully.

@PedroAlvarado With the recent provisioning changes, the issue mentioned here has become somewhat defunct. Prior to provisioning, we were using the DefaultProducerFactory for fetching partition metadata in both producer and consumer endpoint wiring and not allowing to configure that producer factory.
Now it is changed in such a way that the partition metadata fetching in  createProducerMessageHandler is using the common producer factory used for other operations in this method. Therefore, you can pass in various kafka producer properties and they will be honored by the producer factory when the partition info is fetched as it is no longer using a dedicated non-configurable producer factory.
In a similar vein, the partition metadata fetching logic in createConsumerEndpoint alsoe uses the common consumer factory. This consumer accepts any kafka consumer properties and will be honored during the partition metadata fetching as well.
See these changes for more details:
https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/blob/master/spring-cloud-stream-binder-kafka/src/main/java/org/springframework/cloud/stream/binder/kafka/KafkaMessageChannelBinder.java#L148
and
https://github.com/spring-cloud/spring-cloud-stream-binder-kafka/blob/master/spring-cloud-stream-binder-kafka/src/main/java/org/springframework/cloud/stream/binder/kafka/KafkaMessageChannelBinder.java#L210

@sobychacko This makes sense. That code reads much better now. I agree that we can call this issue obsolete. Thank you!

@PedroAlvarado Closing this issue now. Thanks!


Is it possible to set the font size for the axis labels?

A user of my library Data-Forge Plot is looking to change the font size for axis labels.
Is it possible to change font size for axis labels in ApexCharts?
I did a quick search of the docs for "font" and "size" and couldn't see anything.

Yes.
  xaxis: {
        labels: {
            style: {
                fontSize: '12px'
            }
       }
   }

https://apexcharts.com/docs/options/xaxis/#labelsFontSize

Thanks!

Hey guys,
would you also know if we can change the fontSize of the series array? I cannot seem to find an appropriate object I could pass. Or should this be edited via yaxis?

Hey!
I have 4  data
xaxis: {
categories: [
"Feb",
"Mar",
"Apr",
"May",
]
}
I want only the last labels should be bold "May"
Can you help me

I am interested in this too... junedchhipa

Hey! I have 4 data xaxis: { categories: [ "Feb", "Mar", "Apr", "May", ] } I want only the last labels should be bold "May" Can you help me


installed using sudo python3 -m pip install autosub

Will not run
had to
sudo ln -s /volume1/@appstore/py3k/usr/local/bin/autosub /usr/local/bin/autosub
autosub -h
 File "/usr/local/bin/autosub", line 136
    print "The given file does not exist: {0}".format(filename)
          ^

me too

From https://github.com/agermanidis/autosub/issues/146#issuecomment-521101771
Copyable (double click below):
pip install git+https://github.com/agermanidis/autosub.git


Add Vulkan-specific validation rules for atomics

Added atomic instructions validation rules from
https://www.khronos.org/registry/vulkan/specs/1.0/html/vkspec.html#spirvenv-module-validation

Fails Vulkan CTS master. Looking into this now.

Disabled the check which fails Vulkan CTS.

I filed https://github.com/KhronosGroup/SPIRV-Tools/issues/1278 to re-enable the check that was disabled, and to track the CTS change in flight to fix it.

Rebased and pushed into master as a61e4c13562
I didn't squash this time because I want to keep separate the commit that disables the check, so it can more easily be reversed.


Debug "Visible Collision Shapes" checkbox creating "MeshInstance"

Godot version:
3.3
OS/device including version:
Windows 64 bit
Issue description:
MeshInstance is created for each collision shape when checking the "Visible Collision Shapes" in Debug Menu

Steps to reproduce:
Just import the zip .tscn  or recreate the scene with the nodes as shown in the images above. Run it! and check the "Remote" view tree.
Minimal reproduction project:
issue.zip

Not a bug - in order to draw the debug shape, it needs to create a mesh instance.

But this is new in 3.3. Now, when I have to do a for loop looking for nodes, it will give errors because it's passing by that node too.

This was introduced by #46397.
Before, the MeshInstance used to show the shape was a CollisionShape child. But I move them at the CollisionObject level (the StaticBody in your case).
There are several solutions to this issue:

Do nothing (my favourite 😀) and let the user handle it (you can use get_tree().is_debugging_collisions_hint())
Document this behavior in the CollisionObject description
Move all the MeshInstances to an intermediate Spatial. Still, you must handle that extra node
Move the MeshInstance back to the CollisionShape (introducing a special case for it)

@trollodel That would be great if you're up for making the PR! It shouldn't be too complicated to do. You would just work with a RID instead of a mesh instance. Creation would be similar to this (using the mesh from the shape instead of the multimesh):
https://github.com/godotengine/godot/blob/c7b97f077a0f62d9e280adbddddc901f35e4f40f/scene/main/viewport.cpp#L458-L460
And destroying would be like this:
https://github.com/godotengine/godot/blob/c7b97f077a0f62d9e280adbddddc901f35e4f40f/scene/main/viewport.cpp#L515
You can test with the VisualServer equivalent on 3.x first (contact points are currently not working on master, so it's just to be sure you're not stuck because of a similar bug in the new rendering system).
Also my fix from #47848 using NOTIFICATION_PREDELETE wouldn't be needed anymore, since CollisionObject would manage its debug shapes without interacting with the tree.

IMO this is another issue because it'd make #46397 obsolete.

Yeah, it's fine. This can be changed separately.

@pouleyKetchoupp Thanks for the guidance!

Yeah, if it's possible to use servers API directly, that's the first thing to try when coding in C++. Control nodes also suffer from this "extra nodes" issue unfortunately. @KoBeWi previously proposed to implement "internal nodes" feature to handle cases like this, see PR #30391.

I have the same problem.
As a temporary solution, it is better to make the mesh instances the children of the collision shape nodes rather than their siblings.

By the way, there is probably a reason for another error report, but my collision shape changes dynamically, but after changing the collision shape, the rendering mesh serving just remains a dead weight without changes and completely useless confusing.

By the way, there is probably a reason for another error report, but my collision shape changes dynamically, but after changing the collision shape, the rendering mesh serving just remains a dead weight without changes and completely useless confusing.

@OlexiyKravchuk Yes, please open an issue with a minimal project and repro steps so it can be investigated.

Yes, please open an issue with a minimal project and repro steps so it can be investigated.

@pouleyKetchoupp ready
#https://github.com/godotengine/godot/issues/48281

https://github.com/godotengine/godot/issues/48281


docs: Add a simple architecture diagram for i.e. slides

Signed-off-by: Fabian Deutsch<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

cc @xsgordon

i'm unsure. can you tell me a little bit about the goal behind this new simplified diagram?

Any concerns @davidvossel ?


I don't want to load the gif,what can I do?

Sometimes I will get the gif url from server.But I don't want to show the animation image.What can I do.

you can download a placeholder image and control the playback using something like this

You can use    imageView.image=image.images.firstObject; after you download the gif.


feat(docker):Add the jattach tool to the docker container(#7538)

Test:

docker run -it linkedin/datahub-gms:head /bin/sh
run jattach

The following is a screenshot of the execution in my local environment

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[ ] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Conditionally, I am LGTM.
Specifically, are there any README's or other forms of documentation where it would be helpful to make a note that:

We added jattach to our Docker images
How to use jattach against datahub images, targeted at approximately a college new grad.  Specifically, can we get

docker run -it linkedin/datahub-gms:head /bin/sh
run jattach


feat(#95): Add Unit Test for ClassDirectives

Add unit test for ClassDirectives.
Closes: #95.

PR-Codex overview
This PR focuses on adding unit tests for the ClassDirectives class in the jeo.representation.asm package.
Detailed summary

Added ClassDirectivesTest class to test the ClassDirectives class.
Added test cases for parsing simple classes without constructors and with methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 3min)


PCM usage in multi-threaded application

Hi all, I hope this is the right place to ask my question. I would like to profile some sections of a multithreaded application.  Each code section is executed within one thread on a partition of the input. What i want to do is to profile each code section that runs on a specific core. I am a bit confused regarding the multi-threaded model of PCM. Can one PCM instance be shared across threads? Would that be expensive, e.g., is there a lock?Is this an intended way of using PCM or should one use it in a dedicated thread that samples stats every N milliseconds (e.g., like in the provided examples).
In short, my code would look like:
for (int i = 0; i < numThreads; ++i) {
     // set thread affinity to core i and numa
     auto* input = data[i];
     // start sampling events using PCM for core i
     // do some critical, coarse-grained work
     // stop sampling and report stats
     // do some other work
     for (int j = 0; j  < elementsInInput; ++j) {
          // start profiling again using PCM for core i
          // do some fine-grained work
          // stop profiling and report stats
     }
}

I am aware that this could also be done via Vtune but I would be interested in using pcm only.
EDIT: is allowMultipleInstance() meant to solve the above problem or is it to allow multiple PCM processes at a time?

what you should do is the following:
program pcm once

for (int i = 0; i < numThreads; ++i) {
     // set thread affinity to core i and numa
     auto* input = data[i];
     auto before = getCoreCounterState(i);
     // do some critical, coarse-grained work
     auto after = getCoreCounterState(i);
     // print metrics of interest, for example getL3CacheMisses(before, after);
     // do some other work
     for (int j = 0; j  < elementsInInput; ++j) {
         auto before = getCoreCounterState(i);
         // do some critical, coarse-grained work
         auto after = getCoreCounterState(i);
         // print metrics of interest, for example getL3CacheMisses(before, after);
     }
}

getCoreCounterState has only per-core/thread locks inside, so it should not matter for you

hi @opcm thank you very much for your help. Much appreciated. It works!
Please, feel free to close the issue or let me know if i can help making this snippet available for future use.

@opcm a followup question, if i may. Would it be possible to configure a different set of custom counters on each core? If that is not possible, would you recommend reprogramming the PCM instance with different counters every N units of time or should the PCM instance be untouched after program(..) is called? Thanks in adv. for your attention.

you can change the set of monitored events for all cores altogether: https://github.com/opcm/pcm/blob/4f326d4b45b29fe996e9a6b60034eeee28a6e8f6/pcm-core.cpp#L89
I expect reprogramming should work.

@opcm thank you! i confirm that reprogramming on-the-fly the PCM instance works.


[FLINK-5720] Deprecate DataStream#fold()

This PR deprecates the various DataStream#fold() methods and all related internal classes.

Man that stuff is everywhere isn't it...

I think we got them all now. I would have missed the one in TypeExtractor...
LGTM (looks good to merge) now!

merging.

Cool, thanks for working on this (and the fold PR): 👍

Sorry for commenting on this closed PR, but can you point me to documentation for what will replace fold? I'm starting a new project using 1.3 and don't want to use a deprecated API, but don't find much on what I should be replacing fold with.  Thanks

Hi @caddac ,  you can use AggregateFunction and KeyedStream.aggregate(AggregationFunction<T> aggregate) instead of fold.

Actually, KeyedStream.aggregate is protected and thus not accessible.
You may, however, access WindowedStream#aggregate(AggregateFunction<T,ACC,R>)  and AllWindowedStream#aggregate(AggregateFunction<T,ACC,R>)  for windowed streams and use a stateful map or flatmap for the rest.

In this document
https://ci.apache.org/projects/flink/flink-docs-release-1.4/dev/stream/operators/index.html#datastream-transformations
keyedStream.fold("start")((str, i) => { str + "-" + i })
I want to do the same thing, what am I supposed to do and and don't use deprecated API

Hi @iduanyingjie, the replacement for fold has not been implemented yet. So you have to stick with fold() for now.
fold's replacement will correspond to WindowedStream.aggregate(AggregateFunction).


Add CMake project

I ran into an issue when I tried to build with cmake. I got this:
CMake Warning at CMakeLists.txt:73 (find_package):
  By not providing "FindIconv.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Iconv", but
  CMake did not find one.

  Could not find a package configuration file provided by "Iconv" with any of
  the following names:

    IconvConfig.cmake
    iconv-config.cmake

  Add the installation prefix of "Iconv" to CMAKE_PREFIX_PATH or set
  "Iconv_DIR" to a directory containing one of the above files.  If "Iconv"
  provides a separate development package or SDK, be sure it has been
  installed.

I found the FindIconv.cmake file in cmake/modules but it wasn't being added to the CMAKE_MODULE_PATH because my cmake is 3.10 and that's only included for cmake less than 3.10. I changed the line to 3.11 and everything worked fine, but I have no idea if that's the correct solution. Any ideas?
Other than that, everything I tried worked great. Thanks again!

I found the FindIconv.cmake file in cmake/modules but it wasn't being added to the CMAKE_MODULE_PATH because my cmake is 3.10 and that's only included for cmake less than 3.10. I changed the line to 3.11 and everything worked fine, but I have no idea if that's the correct solution. Any ideas?

Yes, it was my mistake. FindIconv module is shipped with CMake starting from 3.11.

okay, thanks, I'll go ahead and just change the check to 3.11


Stream fixes

Fixed SM Power Bomb notification
Updated GT to not require SM bosses if GT crystal count < Ganon crystal count (Fixes #349 )
Switched quarter magic to the logic configs so that it's copied with configs (and because it does impact item placement and thus logic)
Added additional hint possibilities
Updated version

I updated the hint service to use delegates for hints because in the past the hint generation has proven to be slow already for multiworlds do to how it works, and with all of these additional hints it would have just made it worse. With the delegates, it compiles the list of possible hints, then only actually generates the amount necessary.


Implement LimitPushDown for ExecutionPlan

Which issue does this PR close?

Closes #9792
Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Output partition number of the UnionExec is the sum of partition number of its inputs. Hence we cannot rely on after UnionExec output partitioning is 1.

Thanks @Lordworms -- I took a quick look of this PR
I am probably missing something obvious but I don't understand the need for the pushdown pass in the physical optimizer.
If the usecase is to get a limit closer to StreamingTableExec then maybe we can pushing the fetch to the CoalesceBatchesExec rather than the StreamingTableExec ?
actually it has been pushed to CoalesceBatchesExec, and then carries down to StreamingTableExec
It seems to me that a limit in the StreamingTable exec can likely be implemented more efficiently, and would already be handled by the existing Limit pushdown in the LogicalPlan.
I agree I should add this logic in LogicalPlan Phases, I will save this one to draft and work on #9873 first.
Maybe @berkaysynnada or @mustafasrepo have some more context
Thanks for your review and Sorry for my immature design, I'll complete it later.

Thanks @Lordworms -- I took a quick look of this PR
I am probably missing something obvious but I don't understand the need for the pushdown pass in the physical optimizer.
If the usecase is to get a limit closer to StreamingTableExec then maybe we can pushing the fetch to the CoalesceBatchesExec rather than the StreamingTableExec ?
It seems to me that a limit in the StreamingTable exec can likely be implemented more efficiently, and would already be handled by the existing Limit pushdown in the LogicalPlan.
Maybe @berkaysynnada or @mustafasrepo have some more context

Thanks @alamb for the feedbacks. @Lordworms's strategy is actually intuitive and reasonable, but maybe we need another way to solve the problem.
If I summarize https://github.com/apache/arrow-datafusion/issues/9792, the problem is when a Limit exists above CoalesceBatches, CoalesceBatches waits until all rows are collected which are possibly not used after Limit. Therefore; we need CoalesceBatches to sense the fetch count of the Limit, and after that many rows are collected, it should be able to return them without waiting more.

Maybe @berkaysynnada or @mustafasrepo have some more context
Thanks for your review and Sorry for my immature design, I'll complete it later.

No worries at all -- we are all sorting this out together @Lordworms . Thank you for helping push it along


MultiQC reporting updates

Summary of the changes proposed on this PR:

Added the stats files generated by Picard CollectInsertSizeMetrics to the MultiQC report.
Fixed some minor formatting on the Stats summary tables (remove floating point where not necessary, include more decimal places where they seemed not enough - like percentage duplication).
Reorder the tables (Stats summary first).
Added a libsize estimate that mimics Picard behavior for paired fragments, but uses our "single" fragments. The rationale behind this is that in our case, our first mates are always representing a "pair" and even the ones that are somewhat orphan represent a unique event still, so I think it's OK to estimate like this. I checked what would Picard output with default paired-end deduplication, and it seems pretty correlated. I will run real-datasets experiments with this, but as it was, some ballpark estimate is still better than nothing, which is what we had (all values were NA on the table).
Added the number of reads after demultiplexing per sample to the stats_summary.txt and also to the MultiQC report.
Added another column called map_id to the stats_summary.txt. I noticed that MultiQC does not allow for rows with the same value in the first column, so it would just omit some libraries that were mapped to multiple references.
Bumped MultiQC version in the environment.yaml, since the issue with the figures has been fixed in MultiQC 1.13.
This resulted in noticing that for the latest snakemake version the pipeline crashes (to be further investigated, see #159 ), so I pinned it on the environment.yaml to one version that works.
Bumped minute version to 0.2.0 as I understand, this are minor non-breaking updates.

Should I provide some CHANGELOG, since there are now version numbers?

I’ll review this today.

Thanks for your review @marcelm ! It should be OK now. I added a CHANGES.md as you suggested. We technically don't have releases, so there isn't really a dev branch. I just put each version number together with the changes. Unless you have any objections I will probably merge once test pass.

Regarding releases: We have the Bioconda package, and I see only now that it [already is at version 0.2.0]((https://github.com/bioconda/bioconda-recipes/blob/master/recipes/minute/meta.yaml). Can you bump the version in setup.cfg to 0.3.0 instead? Then we can also push a tag afterwards and update the Bioconda recipe.
Looks good otherwise!


Delay device discovery during WeMo component initialization.

Description:
When network discovery finds multiple WeMo platforms (in my case switch and light) then both platforms depend on the WeMo component. Because we are running a one-shot discovery during component initialization which takes some time the second initialization failed.
This patch delays running the pywemo specific discovery to occur after the component initialization has completed.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Schedule device discovery to run after the WeMo component has finished
initializing. This avoids a situation where initialization fails because
discovery triggered initialization of two WeMo platforms that both
try to setup the WeMo component.

I don't think that I fully understand your description. We only setup each component once.
Discovery will wait doing setup until setup component is done.

I was seeing errors that the WeMo component was already being initialized.
The component is loaded either from the config because of a wemo: entry, or as a dependency of something like switch.wemo getting discovered by the discovery component.
The wemo component initialization takes quite a bit of time because it runs its own pywemo.discovery ans during this time another platform, for instance lights.wemo, may get initialized which also depends on the WeMo component.
On November 17, 2016 10:29:56 AM EST, Paulus Schoutsen<EMAIL_ADDRESS>wrote:

I don't think that I fully understand your description. We only setup
each component once.
Discovery will wait doing setup until setup component is done.

But as far as I know, the discovery component doesn't start discovery till
home Assistant starts, which is always after setup of the wemo component
On Thu, Nov 17, 2016, 07:36 Jan Harkes<EMAIL_ADDRESS>wrote:

I was seeing errors that the WeMo component was already being initialized.
The component is loaded either from the config because of a wemo: entry,
or as a dependency of something like switch.wemo getting discovered by
the discovery component.
The wemo component initialization takes quite a bit of time because it
runs its own pywemo.discovery ans during this time another platform, for
instance lights.wemo, may get initialized which also depends on the WeMo
component.
On November 17, 2016 10:29:56 AM EST, Paulus Schoutsen <
<EMAIL_ADDRESS>wrote:

I don't think that I fully understand your description. We only setup
each component once.
Discovery will wait doing setup until setup component is done.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/4435#issuecomment-261279448,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYJ2kjI1QZBb62PUFY1S5xS5BJfzSdZks5q_HRtgaJpZM4K1anE
.

I don't have wemo in my config at all, as well as chromecast and various others. Discovery is what gets those platforms and components loaded.
On November 17, 2016 10:52:00 AM EST, Paulus Schoutsen<EMAIL_ADDRESS>wrote:

But as far as I know, the discovery component doesn't start discovery
till
home Assistant starts, which is always after setup of the wemo
component
On Thu, Nov 17, 2016, 07:36 Jan Harkes<EMAIL_ADDRESS>wrote:

I was seeing errors that the WeMo component was already being
initialized.
The component is loaded either from the config because of a wemo:
entry,
or as a dependency of something like switch.wemo getting discovered
by
the discovery component.
The wemo component initialization takes quite a bit of time because
it
runs its own pywemo.discovery ans during this time another platform,
for
instance lights.wemo, may get initialized which also depends on the
WeMo
component.
On November 17, 2016 10:29:56 AM EST, Paulus Schoutsen <
<EMAIL_ADDRESS>wrote:

I don't think that I fully understand your description. We only
setup
each component once.
Discovery will wait doing setup until setup component is done.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub

https://github.com/home-assistant/home-assistant/pull/4435#issuecomment-261279448,

or mute the thread

https://github.com/notifications/unsubscribe-auth/ABYJ2kjI1QZBb62PUFY1S5xS5BJfzSdZks5q_HRtgaJpZM4K1anE

.

I think we may be talking about different device discoveries here because of my poor choice of wording for the PR description.
What this patch delays is a call to pywemo.discover_devices, not the device discovery using netdisco in the discovery component. The WeMo specific discovery duplicates what netdisco does, possibly in a slightly different way and is supposedly for people who want only their WeMo devices autodiscovered and to make the component more robust.
My argument against it is that it duplicates existing functionality and only does a one-time shot discovery during startup, while netdisco periodically rescans in the background and will be able to see devices that come online after hass is already running.

What is happening currently:

discovery component starts discovery at homeassistant_start
discovery discovers Wemo. Wemo is a component based discovery so it calls discovery.discover
helpers.discovery.discover will setup Wemo (without checking/acquiring the setup lock in the discovery method)
Wemo will call helpers.discovery.load_platform (which will wait till an ongoing setup is finished.)
Since helpers.discovery.load_platform waits till Wemo is setup before it starts to setup the light component and fire the platform_discovered event for wemo.

I think that the problem is not inside the wemo component but it is a problem inside the discovery helpers. The discover method should be made async and also acquire a lock just like async_load_platform. That way the discovery will wait if a setup is currently going on.

So by making the component setup faster, I just made the window for the race condition smaller, but the problem is still there.

I have resolved the discovery issue in #4463 👍

#4463 did not seem to have resolved the issue. Yesterday I ran 0.34.dev0 with only a change to revert the netdisco dependency in back to 0.7.5. I've extracted relevant parts of the log,
16-11-20 15:54:01 homeassistant.util.package: Attempting install of netdisco==0.7.5
16-11-20 15:54:19 homeassistant.bootstrap: Setting up discovery
16-11-20 15:54:19 homeassistant.core: Bus:Handling <Event component_loaded[L]: component=discovery>
16-11-20 15:55:23 homeassistant.core: Starting Home Assistant core loop
16-11-20 15:55:23 homeassistant.core: Starting Home Assistant
16-11-20 15:55:23 homeassistant.core: Bus:Handling <Event service_registered[L]: service=stop, domain=homeassistant>
16-11-20 15:55:23 homeassistant.core: Bus:Handling <Event service_registered[L]: service=restart, domain=homeassistant>
16-11-20 15:55:23 homeassistant.core: Bus:Handling <Event homeassistant_start[L]>
16-11-20 15:55:23 homeassistant.core: Timer:starting
16-11-20 15:55:23 netdisco.service: Scanning
16-11-20 15:55:52 homeassistant.components.discovery: Found new service: belkin_wemo ('Insight', 'Insight', 'http://<IP_ADDRESS>:49153/setup.xml', ...
16-11-20 15:55:52 homeassistant.components.discovery: Found new service: belkin_wemo ('WeMo Link', 'Bridge', 'http://<IP_ADDRESS>:49153/setup.xml', ...
16-11-20 15:55:53 homeassistant.loader: Loaded wemo from homeassistant.components.wemo
16-11-20 15:55:53 homeassistant.util.package: Attempting install of pywemo==0.4.7
16-11-20 15:56:12 homeassistant.bootstrap: Setting up wemo
16-11-20 15:56:13 homeassistant.components.wemo: Scanning for WeMo devices.
16-11-20 15:56:13 pywemo.subscribe: Listening on port 8989
16-11-20 15:56:21 homeassistant.components.wemo: Adding wemo at <IP_ADDRESS>:49153
16-11-20 15:56:21 homeassistant.core: Bus:Handling <Event platform_discovered[L]: discovered=('WeMo Link', 'Bridge', 'http://<IP_ADDRESS>:49153/setup.xml', ...), service=belkin_wemo>
16-11-20 15:56:21 homeassistant.core: Bus:Handling <Event platform_discovered[L]: discovered=('WeMo Link', 'Bridge', 'http://<IP_ADDRESS>:49153/setup.xml', ...), platform=wemo, service=load_platform.light>
16-11-20 15:56:21 homeassistant.components.wemo: Adding wemo at <IP_ADDRESS>:49153
16-11-20 15:56:21 homeassistant.loader: Loaded light.wemo from homeassistant.components.light.wemo
16-11-20 15:56:21 homeassistant.bootstrap: Attempt made to setup wemo during setup of wemo
16-11-20 15:56:21 homeassistant.bootstrap: Component wemo failed to setup
16-11-20 15:56:21 homeassistant.bootstrap: Unable to prepare setup for platform light.wemo because dependency wemo could not be initialized

Oh I think that I see the problem. Can you remove this if-statement and try locally?

:+1: that does the trick.


Profile Card

Star the repo this is mandatory and you can also follow me.

Done @abhijitmondal121

Star the repo this is mandatory and you can also follow me.

Hello, @abhijitmondal121  I have done star the repo and followed you. please merge my files.

Your pull request is conflicts. Plz make a new fork and pull request I will accept that.


What`s the different between go-gorm/gorm  and jinzhu/gorm?

I found two gorm on github, one is go-gorm/gorm  and other is jinzhu/gorm. I think jinzhu is the author of gorm, but ,which package should I import ?
If I use go-gorm/gorm function to query db,then judge the err is jinzhu/gorm ErrRecordNotFound or not ,is it work?
Or I should only import one kind of gorm in my project?

go-gorm/gorm is GORM V2 -> https://v2.gorm.io
jinzhu/gorm is GORM V1 -> https://v1.gorm.io

It would be beneficial if this was front and center in every readme and docs site as this was very confusing too. Also, there are links to issues in the gormv1 github that do not directly work but if you find the number in this repo it seems to be the same issue. (search this page for 1543: https://blog.depado.eu/post/gorm-gotchas)


Quick Start in README

I think the current README is good enough to mark this as solved, so I'm closing it now. Feel free to re-open if you think otherwise @satooshi


Minifier injects spaces between interpolated values

The latest html-minifier (@1.2) injects spaces between any interpolated values that are next to letters. I suspect html-minifier thinks these are tags and decides to add a space.
Calling jstify on a template like
string string-<%=attribute%>

Produces
string string- <%=attribute%>

After minify is called. Using html-minifier<1.2 or calling it with preserveWhitespace: false seems to avoid this issue.
/cc @zertosh

Nevermind, fixed with https://github.com/kangax/html-minifier/issues/506


[kong] add the ability to include adhoc pod labels

What this PR does / why we need it:
This PR adds the ability to include adhoc pod labels.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[X] PR is based off the current tip of the next branch and targets next, not master
[X] New or modified sections of values.yaml are documented in the README.md
[X] Title of the PR and commit headers start with chart name (e.g. [kong])

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm not against it but @aspring, can you elaborate on your use-case for this?

We run Kong with Istio and by adding labels to the pod spec they can be utilized by Istio for enhancing tracing as well as visualizations.

Interesting. I figured it would always be via annotations but I think label makes sense for this.

@aspring Please claim your contributor swag: https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt


How can I inference the Nuscenes point data(.bin) using simple_inference_waymo.py？

1: I got the Nuscenes point data(.bins), and put them in to the --input_data_dir;
2: I changed the .bin data load method (points = np.fromfile(pc_name, dtype=np.float32));
3: used the last.pth you provided and nusc_centerpoint_pp_02voxel_two_pfn_10sweep_demo.py for config;
But I got the detection results looks bad, is there something else I shoud change?

for nuscenes, all model are trained with ten frame data so it will be much worse if you only use single frame

for single frame, Waymo model works much better in my experience. You can send me an email to get those models (provided the dataset registration screenshot).

Thanks author!! I will learn the code thoroughly, than send you email to get these models.

Hi @tianweiy thanks for all your hard work!
One question: when getting the detections.pkl out from the inference script, what format are those 9-dim vectors in? For example, when running dist_test.py we get a .json out where a detection is a 10-dim vector of [center, quaternion, scaling]. Comparing both formats, I can only recover the scaling with the other 6 terms likely being the center (in some different frame) and possibly Euler angles?
I am asking because I just want to plot the results to get a better visual sense of how CenterPoint performs on my own dataset. Thanks in advance!


Compile OpenJDK 9 from Scratch on EV3 Brick

It is necessary to see if OpenJDK 9, it is possible to be compiled on EV3 Brick.
https://mihail.stoynov.com/2015/01/29/building-openjdk-9-on-a-osx-or-any-linux/
sudo apt-get install mercurial
apt-get --reinstall install python-support
apt-get --reinstall install mercurial mercurial-common
mkdir jkd9
cd jdk9
hg clone http://hg.openjdk.java.net/jdk9/dev jdk9.hg
cd jdk9.hg
chmod u+x get_source.sh
./get_source.sh
chmod u+x configure
./configure
make clean images

http://openjdk.java.net/jtreg/

I am experimenting with JDK tree now and I've just found a configuration that might work:
bash configure --openjdk-target=arm-linux-gnueabi --enable-headless-only --with-freetype-lib=/usr/lib/arm-linux-gnueabi --with-freetype-include=/usr/include --with-jvm-variants=client --with-extra-cflags="-Os -march=armv5te -mtune=arm926ej-s"

While trying to satisfy all the build requirements, I've made a mess in the jessie-cross container, so I can't post the required packages to install. But otherwise, the trial-and-error works quite well.

--openjdk-target=arm-linux-gnueabi → signals that this is  cross-compilation
--enable-headless-only → actually, I've got no idea what the real implications are, but it makes sense
--with-freetype-lib=/usr/lib/arm-linux-gnueabi --with-freetype-include=/usr/include → to find the armel variant of FreeType library.
--with-jvm-variants=client → just a guess, it should make the program start faster
--with-extra-cflags="-Os -march=armv5te -mtune=arm926ej-s" → optimize jvm for size and for the EV3 CPU; the latter is required, else the compiler defaults to armv4t, which is unsupported.
There are also a few interesting options worth thinking through: Minimal JVM and AOT compilation.

Apparently, -Wno-maybe-uninitialized is needed in CFLAGS, as otherwise the compilation stops with and error in c1_LIRGenerator_arm.cpp.

Problem: ASFLAGS does not contain extra CFLAGS
Solution: patch common/autoconf/flags.m4 to:
diff -r a08cbfc0e4ec common/autoconf/flags.m4
--- a/common/autoconf/flags.m4	Thu Aug 03 18:56:56 2017 +0000
+++ b/common/autoconf/flags.m4	Tue Dec 26 21:48:34 2017 +0000
@@ -30,7 +30,7 @@
 AC_DEFUN([FLAGS_SETUP_ABI_PROFILE],
 [
   AC_ARG_WITH(abi-profile, [AS_HELP_STRING([--with-abi-profile],
-      [specify ABI profile for ARM builds (arm-vfp-sflt,arm-vfp-hflt,arm-sflt, armv5-vfp-sflt,armv6-vfp-hflt,arm64,aarch64) @<:@toolchain dependent@:>@ ])])
+      [specify ABI profile for ARM builds (arm-vfp-sflt,arm-vfp-hflt,arm-sflt,arm-ev3,armv5-vfp-sflt,armv6-vfp-hflt,arm64,aarch64) @<:@toolchain dependent@:>@ ])])

   if test "x$with_abi_profile" != x; then
     if test "x$OPENJDK_TARGET_CPU" != xarm && \
@@ -51,6 +51,9 @@
     elif test "x$OPENJDK_TARGET_ABI_PROFILE" = xarm-sflt; then
       ARM_FLOAT_TYPE=sflt
       ARM_ARCH_TYPE_FLAGS='-march=armv5t -marm'
+    elif test "x$OPENJDK_TARGET_ABI_PROFILE" = xarm-ev3; then
+      ARM_FLOAT_TYPE=sflt
+      ARM_ARCH_TYPE_FLAGS='-mcpu=arm926ej-s -marm'
     elif test "x$OPENJDK_TARGET_ABI_PROFILE" = xarmv5-vfp-sflt; then
       ARM_FLOAT_TYPE=vfp-sflt
       ARM_ARCH_TYPE_FLAGS='-march=armv5t -marm'
@@ -1305,6 +1308,8 @@
   if test "x$OPENJDK_$1_OS" = xlinux; then
     if test "x$OPENJDK_$1_CPU" = xx86; then
       $2JVM_ASFLAGS="[$]$2JVM_ASFLAGS -march=i586"
+    elif test "x$OPENJDK_TARGET_ABI_PROFILE" = xarm-ev3; then
+      $2JVM_ASFLAGS="-mcpu=arm926ej-s"
     fi
   elif test "x$OPENJDK_$1_OS" = xmacosx; then
     $2JVM_ASFLAGS="[$]$2JVM_ASFLAGS -x assembler-with-cpp -mno-omit-leaf-frame-pointer -mstack-alignment=16"

Current configure line:
bash ./configure --openjdk-target=arm-linux-gnueabi --with-abi-profile=arm-ev3 --enable-headless-only --with-freetype-lib=/usr/lib/arm-linux-gnueabi --with-freetype-include=/usr/include --with-jvm-variants=minimal --with-extra-cflags="-Os -Wno-maybe-uninitialized"

The Minimal JVM will be sufficient for the beginning. Also, we have to use the --with-abi-profile option (vanilla would use arm-sflt).

Problem: Java on softfloat fails linking on __aeabi_dsub_glibc and similar.
Cause/Solution: http://mail.openjdk.java.net/pipermail/aarch32-port-dev/2016-November/000616.html

Hi @JakubVanek, nice to read your comments.
I was exploring OpenJ9, this project has better support for ARM for EV3.
Are you interested to participate?
Cheers

Hi,
I'm not sure OpenJ9 has better support for ARM. OpenJDK inherited the ARM port from the Oracle EJDK, which the leJOS JRE is using.
Regards

Interesting comment :)
Returning to previous point, so are you working to run OpenJDK 9 on EV3? What is the status? The idea is very promising. Run the JShell on the brick could be amazing:
https://docs.oracle.com/javase/9/jshell/introduction-jshell.htm#JSHEL-GUID-630F27C8-1195-4989-9F6B-2C51D46F52C8

Yes, I'm trying to get OpenJDK running on the EV3. It looks quite good - the build has finished successfully now. I can't test it at the moment though, because I don't have a spare microSD card.
I've uploaded my compressed images folder here, but beware: it might be needed to install libraries from jessie-backports (apt-mess in the container).
How to build:
## preparation:
# <setup docker container>
# <enter docker container>
# <enable backports (for JDK)>
# <install JDK8>
# <install armel libraries needed by JDK9, roughly these:
#   libcups2-dev:armel, libfreetype6-dev:armel, libasound2-dev:armel>

## build:
hg clone http://hg.openjdk.java.net/jdk9/jdk9 jdk9
cd jdk9
bash get_source.sh

# now save the build.patch and the float.patch to this directory
patch < build.patch # apply the build.patch to the *root jdk directory*
cd hotspot; patch < ../float.patch; cd .. # apply the float.patch to the *hotspot subdirectory*

# let's configure it
bash ./configure --openjdk-target=arm-linux-gnueabi \
    --with-abi-profile=arm-ev3 \
    --enable-headless-only \
    --with-freetype-lib=/usr/lib/arm-linux-gnueabi \
    --with-freetype-include=/usr/include \
    --with-jvm-variants=minimal \
    --with-extra-cflags="-Os -Wno-maybe-uninitialized -D__SOFTFP__" \
    --with-version-pre="mindstorms" \
    AR="arm-linux-gnueabi-gcc-ar" \
    NM="arm-linux-gnueabi-gcc-nm" \
    BUILD_AR="gcc-ar" \
    BUILD_NM="gcc-nm"

# let's build it
make clean images # hmm, this sounds nice
# j2sdk images should be in build/linux-arm-normal-minimal-release/images

build.patch:
diff -r a08cbfc0e4ec common/autoconf/flags.m4
--- a/common/autoconf/flags.m4	Thu Aug 03 18:56:56 2017 +0000
+++ b/common/autoconf/flags.m4	Wed Dec 27 00:52:44 2017 +0100
@@ -30,7 +30,7 @@
 AC_DEFUN([FLAGS_SETUP_ABI_PROFILE],
 [
   AC_ARG_WITH(abi-profile, [AS_HELP_STRING([--with-abi-profile],
-      [specify ABI profile for ARM builds (arm-vfp-sflt,arm-vfp-hflt,arm-sflt, armv5-vfp-sflt,armv6-vfp-hflt,arm64,aarch64) @<:@toolchain dependent@:>@ ])])
+      [specify ABI profile for ARM builds (arm-vfp-sflt,arm-vfp-hflt,arm-sflt,arm-ev3,armv5-vfp-sflt,armv6-vfp-hflt,arm64,aarch64) @<:@toolchain dependent@:>@ ])])

   if test "x$with_abi_profile" != x; then
     if test "x$OPENJDK_TARGET_CPU" != xarm && \
@@ -51,6 +51,9 @@
     elif test "x$OPENJDK_TARGET_ABI_PROFILE" = xarm-sflt; then
       ARM_FLOAT_TYPE=sflt
       ARM_ARCH_TYPE_FLAGS='-march=armv5t -marm'
+    elif test "x$OPENJDK_TARGET_ABI_PROFILE" = xarm-ev3; then
+      ARM_FLOAT_TYPE=sflt
+      ARM_ARCH_TYPE_FLAGS='-mcpu=arm926ej-s -marm'
     elif test "x$OPENJDK_TARGET_ABI_PROFILE" = xarmv5-vfp-sflt; then
       ARM_FLOAT_TYPE=vfp-sflt
       ARM_ARCH_TYPE_FLAGS='-march=armv5t -marm'
@@ -1305,6 +1308,8 @@
   if test "x$OPENJDK_$1_OS" = xlinux; then
     if test "x$OPENJDK_$1_CPU" = xx86; then
       $2JVM_ASFLAGS="[$]$2JVM_ASFLAGS -march=i586"
+    elif test "x$OPENJDK_TARGET_ABI_PROFILE" = xarm-ev3; then
+      $2JVM_ASFLAGS="-mcpu=arm926ej-s"
     fi
   elif test "x$OPENJDK_$1_OS" = xmacosx; then
     $2JVM_ASFLAGS="[$]$2JVM_ASFLAGS -x assembler-with-cpp -mno-omit-leaf-frame-pointer -mstack-alignment=16"

float.patch:
diff -r b756e7a2ec33 src/cpu/arm/vm/assembler_arm_32.hpp
--- a/src/cpu/arm/vm/assembler_arm_32.hpp	Thu Aug 03 18:56:57 2017 +0000
+++ b/src/cpu/arm/vm/assembler_arm_32.hpp	Wed Dec 27 01:08:37 2017 +0100
@@ -1234,10 +1234,17 @@

 // Imported code from glibc soft-fp bundle for
 // calculation accuracy improvement. See CR 6757269.
-extern double __aeabi_fadd_glibc(float, float);
-extern double __aeabi_fsub_glibc(float, float);
-extern double __aeabi_dadd_glibc(double, double);
-extern double __aeabi_dsub_glibc(double, double);
+
+//extern double __aeabi_fadd_glibc(float, float);
+//extern double __aeabi_fsub_glibc(float, float);
+//extern double __aeabi_dadd_glibc(double, double);
+//extern double __aeabi_dsub_glibc(double, double);
+
+// LinuxTARDIS hack
+#define __aeabi_fadd_glibc __aeabi_fadd
+#define __aeabi_fsub_glibc __aeabi_fsub
+#define __aeabi_dadd_glibc __aeabi_dadd
+#define __aeabi_dsub_glibc __aeabi_dsub
 };
 #endif // __SOFTFP__

Purpose of float.patch: _glibc overloads are supposed to be more precise. On EV3 this is not worth any better hack, so we redirect them to the default implementation.
Additional build flags:

-D__SOFTFP__ cflag - I've found this somewhere on the internet, it probably switches the JIT float implementation
--with-version-pre="mindstorms" - just for fun, changes the version string from 9-internal to 9-mindstorms
AR="arm-linux-gnueabi-gcc-ar" NM="arm-linux-gnueabi-gcc-nm" BUILD_AR="gcc-ar" BUILD_NM="gcc-nm" - removes warnings about LTO objects in archives
Java version numbers are not handled well, e.g. now I have 9-mindstorms+0-adhoc..jdk9.

Hmm, haven't heard of JShell yet, but it looks interesting. It should be included in linked build.

JShell for educational purposes could be nice.

Welcome to this Java project for Mindstorms!!!

Hi,
Thanks for the admission :)
I've tried running my OpenJDK9 in userspace QEMU, but with disappointing results.
When Java is started in the JIT mode, QEMU locks up, utilizes 100% of one core and responds only to SIGKILL.
$ qemu-arm-static -cpu arm926 /lib/arm-linux-gnueabi/ld-linux.so.3 ./java -version

When interpreted mode is activated, everything is OK:
$ qemu-arm-static -cpu arm926 /lib/arm-linux-gnueabi/ld-linux.so.3 ./java -Xint -version
openjdk version "9-mindstorms"
OpenJDK Runtime Environment (build 9-mindstorms+0-adhoc..jdk9)
OpenJDK Minimal VM (build 9-mindstorms+0-adhoc..jdk9, interpreted mode)

It might work on the brick, if it's only QEMU what has problems with the JIT.
I'll try to compile OpenJ9 for ARM to see, whether we have at least some alternative. :smile:

Try try, the idea is build a stable version for the whole community. It is a good challenge.
Cheers

This goal was achieved. Thanks @JakubVanek


Carthage ~> 2.3.0 checks out "2.0.0-beta.1"

So Carthage ~> 2.3.0 checks out 2.0.0-beta.1.
But I need RxSwift 4.0 ver.
Checking out master (d2cc0e9b9de6451b58dd77a690a32c2e26e7cd04) fails to build with error:
The following build commands failed: 	CompileC /Users/user/Library/Caches/org.carthage.CarthageKit/DerivedData/9.1_9B46/Action/d2cc0e9b9de6451b58dd77a690a32c2e26e7cd04/Build/Intermediates.noindex/ArchiveIntermediates/Action/IntermediateBuildFilesPath/Rx.build/Release-iphoneos/RxCocoa-iOS.build/Objects-normal/armv7/_RXObjCRuntime.o RxCocoa/Common/_RXObjCRuntime.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler (1 failure)
NB: I am using Carthage to build static lib of Action.
What can be done?

Please try this it should clean it up:  carthage update --use-submodules --no-build


refactor: extend fixture_collector with cmdline args and option to read HA config file

To simplify collection of test fixture by HA users fixture_collector is updated to read envoy ip, username, password and token from the Home Assistant core.config_entries file. With this change HA users can:

copy fixture_collector.py to the ha config folder
open terminal in HA
run the fixture_collector.py and find resulting zip file in the config folder.

command line arguments have been added to control the operation of the program. In simplest format use:
dshier:/config# python fixture_collector.py -r
Fixtures written to enphase-7.6.175
Zip file written to enphase-7.6.175.zip

Which is the format of the original version, without debug enabled and all needed information read from the HA config.
dshier:/config# python fixture_collector.py -h
usage: fixture_collector.py [-h] [-d] [-v] [-c] [-l LABEL] [-r [HA_CONFIG_FOLDER]] [-e ENVOYNAME]
[-u USERNAME] [-p PASSWORD] [-t TOKEN]

Scan Enphase Envoy for endpoint list usable for pyenphase test fixtures. Creates output folder
envoy_<firmware>[label] with results of scan. Zips content of created folder into envoy_<firmware>[label].zip.

options:
  -h, --help            show this help message and exit
  -d, --debug           Enable debug logging
  -v, --verbose
  -c, --clean           Remove created folder, but keep zip file
  -l LABEL, --label LABEL
                        Label to append to output folder and zip file
  -r [HA_CONFIG_FOLDER], --readhaconfig [HA_CONFIG_FOLDER]
                        Read envoyname, username, password and token from HA config file.
                        Use -c path_to_ha_config_folder. Default is current folder.
  -e ENVOYNAME, --envoyname ENVOYNAME
                        Envoy Name or IP address. Default is envoy.local
  -u USERNAME, --username USERNAME
                        Username (for Envoy or for Enphase token website)
  -p PASSWORD, --password PASSWORD
                        Password (blank or for Enphase token website)
  -t TOKEN, --token TOKEN
                        Enphase owner token or @path_to_file to read from file

If no commandline arguments are specified the original method of setting up environment variables for ENVOY_HOST, ENVOY_USERNAME, ENVOY_PASSWORD and ENVOY_TOKEN still applies.

ooops, my bad

replaced by https://github.com/pyenphase/pyenphase/pull/162 without all changes from the generator.


Contact mail symbol

Created a contact mail symbol to replace the "Kontakt" tag in the header by this symbol on the right.
There is however still a problem: The symbol does not have the same vertical size as the others and is not vertically centered, giving the impression that it is located a bit lower than the others.

Nice! Did some slight refactoring and resolved conflicts. :shipit:


feat: add support for custom authorization headers

coverage: 94.72% (-0.02%) from 94.742%
when pulling fcba4ddb31450a5c8b4457dba676c4bc26ce8b2c on feat-custom-auth
into 6d6455c515c1accd8ae0f4c0e8856229fc8027ea on main.


[Fix] Fix flaky test of #9952

fix https://github.com/apache/tvm/issues/9952

Thanks @wrongtest for the fix! If you can make sure the indeterminism doesn't happen again, please also kindly revert this hot fix PR (#9956) by removing the "skip" mark and the pytest import.
cc @junrushao1994 @Hzfengsy


Ruby package problem

I got this error :
err: /Stage[main]/Ruby/Package[ruby]/ensure: change from purged to present failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install ruby1.9.1' returned 100: Reading package lists...
==> default: Building dependency tree...
==> default: Reading state information...
==> default: The following extra packages will be installed:
==> default:   libruby1.9.1 libyaml-0-2
==> default: Suggested packages:
==> default:   ruby1.9.1-examples ri1.9.1 graphviz ruby1.9.1-dev
==> default: The following NEW packages will be installed:
==> default:   libruby1.9.1 libyaml-0-2 ruby1.9.1
==> default: 0 upgraded, 3 newly installed, 0 to remove and 66 not upgraded.
==> default: Need to get 4192 kB of archives.
==> default: After this operation, 12.7 MB of additional disk space will be used.
==> default: Get:1 http://us.archive.ubuntu.com/ubuntu/ precise/main libyaml-0-2 amd64 0.1.4-2 [56.9 kB]
==> default: Err http://us.archive.ubuntu.com/ubuntu/ precise-updates/main libruby1.9.1 amd64 <IP_ADDRESS>-1ubuntu2
==> default:   404  Not Found [IP: <IP_ADDRESS> 80]
==> default: Err http://us.archive.ubuntu.com/ubuntu/ precise-updates/main ruby1.9.1 amd64 <IP_ADDRESS>-1ubuntu2
==> default:   404  Not Found [IP: <IP_ADDRESS> 80]
==> default: Failed to fetch http://us.archive.ubuntu.com/ubuntu/pool/main/r/ruby1.9.1/libruby1.9.1_<IP_ADDRESS>-1ubuntu2_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
==> default: Failed to fetch http://us.archive.ubuntu.com/ubuntu/pool/main/r/ruby1.9.1/ruby1.9.1_<IP_ADDRESS>-1ubuntu2_amd64.deb  404  Not Found [IP: <IP_ADDRESS> 80]
==> default: Fetched 56.9 kB in 0s (103 kB/s)
==> default: E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
==> default:

It seems like you can't access the apt repository. Maybe it's caused by a VM connectivity problem. Have you tried to do a ping from the client to a external machine?


Move BeanUtils to implementation (processor-tools probably). Utility classes do not belong to API module

PR is https://github.com/helidon-io/helidon/pull/5448

Merged


Event number out of order

Event #4 comes before #3
2020-10-27 10:16:15.213125-0600 AEPSampleApp[31048:902979] [AEP SDK TRACE - <EventHub:dispatch(event:)>] Event #1, id: 5A8322D2-4B3A-4941-823A-33A0E65636D4 name: Configure with AppId type: com.adobe.eventType.configuration source: com.adobe.eventSource.requestContent data: Optional(["config.appId": "3805cb8645dd/672baf33bfa5/launch-75f8e0e6c8d2-development"]) timestamp: 2020-10-27 16:16:15 +0000 responseId: nil is dispatched.
2020-10-27 10:16:15.213185-0600 AEPSampleApp[31048:903061] [AEP SDK DEBUG - <EventHub:registerExtension(_:completion:)>] Edge successfully registered.
2020-10-27 10:16:15.213446-0600 AEPSampleApp[31048:902979] [AEP SDK TRACE - <EventHub:dispatch(event:)>] Event #2, id: BC256CBD-CFC5-4C7F-BF51-FE9A576E0C0E name: Configuration Update type: com.adobe.eventType.configuration source: com.adobe.eventSource.requestContent data: Optional(["config.update": ["lifecycle.sessionTimeout": 1]]) timestamp: 2020-10-27 16:16:15 +0000 responseId: nil is dispatched.
2020-10-27 10:16:15.213700-0600 AEPSampleApp[31048:903062] [AEP SDK TRACE - <Cache>] Cache object created with name rules.cache.
2020-10-27 10:16:15.213983-0600 AEPSampleApp[31048:903060] [AEP SDK TRACE - <SQLiteWrapper>] Successfully opened connection to database at /Users/stevebenedick/Library/Developer/CoreSimulator/Devices/2F61A6C8-0CC8-4765-9107-A32701E5803E/data/Containers/Data/Application/BC220901-83BD-4985-8322-F930F05A68D4/Library/Caches/com.adobe.module.identity
2020-10-27 10:16:15.219824-0600 AEPSampleApp[31048:903062] [AEP SDK TRACE - <EventHub:dispatch(event:)>] Event #4, id: CDEA5B42-CE96-45FD-9751-646FD7B694DB name: Configuration Request Event type: com.adobe.eventType.configuration source: com.adobe.eventSource.requestContent data: Optional(["config.appId": "3805cb8645dd/672baf33bfa5/launch-75f8e0e6c8d2-development"]) timestamp: 2020-10-27 16:16:15 +0000 responseId: nil is dispatched.
2020-10-27 10:16:15.219901-0600 AEPSampleApp[31048:902979] [AEP SDK TRACE - <EventHub:dispatch(event:)>] Event #3, id: A2D7832C-FAE2-48FF-8B70-B3BF972ED344 name: IdentityRequestIdentity type: com.adobe.eventType.identity source: com.adobe.eventSource.requestIdentity data: Optional(["authenticationstate": 1, "forcesync": false, "issyncevent": true, "visitoridentifiers": ["idType123": "idValue456"]]) timestamp: 2020-10-27 16:16:15 +0000 responseId: nil is dispatched.
2020-10-27 10:16:15.220251-0600 AEPSampleApp[31048:902979] [AEP SDK TRACE - <EventHub:dispatch(event:)>] Event #5, id: ABBE101A-7FB9-4000-932E-EA34D20A41B4 name: AEP Request Event type: com.adobe.eventType.edge source: com.adobe.eventSource.requestContent data: Optional(["xdm": ["beta demo": true]]) timestamp: 2020-10-27 16:16:15 +0000 responseId: nil is dispatched.

If I had to guess at an easy fix it would be to wrap the contents of the dispatch function in eventHubQueue.async {}. Looks like we have two events dispatched simultaneously and the dispatch function doesn't do a good job of handling them in-order.


Is there a plan to support php 8?

I'm not sure the project is still active but I just thought I'd take a chance and ask if there's a plan to support php 8.1+.  I've made a number of php 8 updates but what's consistent is the warning about dynamic properties.

Feel free to submit a pull request. I've been running this on php 8.x for clients for some time but perhaps the warning levels are set lower....


[enhancement] Print More Info about Model

Print more metadata when saving/pushing/pulling the model.

Blocked by #3


Add 16bit support for packed matmul

This PR addresses the issue https://github.com/tensorflow/tfjs/issues/694
Changes

Added a new PhysicalTextureType - PACKED_2X2_FLOAT16. This is used to determine which texture type / internal format are used to create packed WebGL textures.
Removed the check on WEBGL_RENDER_FLOAT32_ENABLED before sending ops to the packed matMul path

MobileNet v2 benchmarks
The inference times over 20 runs for MobileNet v2 on an iPhone6 Chrome average out to be 260.6ms. On the packed_16bit build, this is reduced to 117.8ms (+120%).
PERF

For repository owners only:
Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY
For more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md

This change is

@nsthorat

Yes, our unit tests will run the packed matmul tests on iOS.
I updated the PR description with MobileNet benchmark results.