useResizeColumns pb offset 3px

Hi I used the example found here https://codesandbox.io/s/github/tannerlinsley/react-table/tree/master/examples/full-width-resizable-table
And I realized that there is an offset of 3px every column.
Is there any way to avoid it?
Thanks

Also running into this

only visible on windows on linux for me, not OSX

Yes I tested it on chrome macOs

ok, so you get this bug on osx as well?

Yes I do
Le jeu. 16 avr. 2020 à 21:36, Torkel Ödegaard<EMAIL_ADDRESS>a
écrit :

ok, so you get this bug on osx as well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tannerlinsley/react-table/issues/2124#issuecomment-614854687,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFO24ES7ZGCROAYKJBH22ALRM5M5VANCNFSM4MEBECSQ
.

--
Cordialement, Julien Moulis 06 43 39 07 14

Found the reason for this, it's the native scrollbar taking up space for the rows but not for the header

A hack to fix this is to force scrollbars on the headers. 🤷♂  UI-probs amiright?!


Added missing keepOpenOnDateSelect prop

The DayPickerSingleDateController is using keepOpenOnDateSelect but that's not currently being passed to it from SingleDatePicker so it is instead always the default value of false.

Coverage remained the same at 86.266% when pulling f41548fb9bb4bfc06284e7a48ee073df6c3a6873 on erin-doyle:missing_keepOpenOnDateSelect_prop into d091b08f571e8e2daeec6ce0899081df10cf883c on airbnb:master.

Oh wow, not sure how I missed all of those! 😳  Fixed!

Coverage remained the same at 86.266% when pulling 164eca818bec98e57acc81970a4776de9c6d04e5 on erin-doyle:missing_keepOpenOnDateSelect_prop into d091b08f571e8e2daeec6ce0899081df10cf883c on airbnb:master.


IndexManager constructor can return with null dbQueue field

See also #280
If an exception is thrown, the caller isn't notified that something went wrong and dbQueue is null meaning every subsequent call will fail:
        try {
            queue = new SQLDatabaseQueue(filename, keyProvider);
            queue.updateSchema(new SchemaOnlyMigration(QueryConstants.getSchemaVersion1()), 1);
            queue.updateSchema(new SchemaOnlyMigration(QueryConstants.getSchemaVersion2()), 2);
            textSearchEnabled = ftsAvailable(queue);
        } catch (Exception e) {
            logger.log(Level.SEVERE, "Failed to open database", e);
            queue = null;
        }

@tomblench can this be closed?


support adding related having a specified relationship

e.g. add related People that "[are] sibling[s]"

I added an additional optional parameter to the /vertex/find-related route limitEdgeLabel


Fix issue 826 - correct python and pip fallback

 Closes #826
Ran across #826 while trying to refactoring pip wiki fix PR #749. The CI for #749 is also added here since it requires the pip fallback fix

[x] Use python2 or python3 rather than python
Currently with disgusting hack and thinking about either (need feedback!):

a new add_sys_path kwargs for ResolvedContext.get_environ and ResovledContext._execute, or
a new ResolvedContext.append_sys_path attribute which ResovledContext._execute and any other methods can use

[x] Fallback to more compatible pip version if possible

So wrt find_python_from_package:

Why recreate a context containing just python, rather than possibly [python, pip]? The pip package isn't going to provide a python exe so this seems unnecessary?

In terms of what to do about avoid system paths. We could fix this by providing some arg to execute_shell/etc like no_append_sys_paths. However it's not the right fix in the long run, when we (hopefully) have the more granular env-var control in place - once that's there, you should be able to do an execute_shell and redefine how any given var behaves anyway (eg inherits original value etc).

is basically what you'er suggesting (your 1.) but I think no_append_sys_paths is a bit better naming since no_append_sys_paths=False is definitely default behaviour. I would go with this. Definitely not with the hack in place currently, see comments.

Cheers
A

Why recreate a context containing just python, rather than possibly [python, pip]? The pip package isn't going to provide a python exe so this seems unnecessary?

Good point, the logic can be much simpler now too!

but I think no_append_sys_paths is a bit better naming since no_append_sys_paths = False is definitely default behaviour. I would go with this.

Cool, I'll go with

a new ResolvedContext.non_append_sys_path attribute which ResovledContext._execute and any other methods can use

Actually, I still prefer the name without the no_ prefix to avoid DNEG double negatives like in your example and also, to avoid statements like if not no_append_sys_path:

Ok cheers, pretty much ready to merge this. Ran out of time just now but this will be done soon.
Thx
A
ps - let's keep separate issues (eg installation CI) in separate PRs ;) The smaller the PR the easier it is for me to digest and merge it.

Cheers for the review! I've updated with changes to code comments.

ps - let's keep separate issues (eg installation CI) in separate PRs ;) The smaller the PR the easier it is for me to digest and merge it.

Sure thing, I'll keep that in mind next time!


High Severity Vulnerbility in Rekit-core

Hello,
Is there a workaround for this? It makes it unusable for our project as Rekit-Core currently includes "decompress" NPM package a with high severity vulnerability.
=== npm audit security report ===
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Arbitrary File Write                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ decompress                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ No patch available                                           │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ rekit-core                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ rekit-core > download-git-repo > download > decompress       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1217                            │
└───────────────┴──────────────────────────────────────────────────────────────┘
found 1 high severity vulnerability in 2148395 scanned packages

Here is the output from a scan using Snyk:
Tested 1870 dependencies for known issues, found 19 issues, 21 vulnerable paths.
Issues with no direct upgrade or patch:
✗ Arbitrary File Write via Archive Extraction (Zip Slip) [Medium Severity][https://snyk.io/vuln/SNYK-JS-DECOMPRESS-557358] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Arbitrary File Write via Archive Extraction (Zip Slip) [Medium Severity][https://snyk.io/vuln/SNYK-JS-DECOMPRESSTAR-559095] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>and 2 other path(s)
No upgrade or patch available
✗ Prototype Pollution [Medium Severity][https://snyk.io/vuln/SNYK-JS-DOTPROP-543489] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>><EMAIL_ADDRESS>This issue was fixed in versions: 5.1.1
✗ Use After Free [High Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-535497] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Out-of-Bounds [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-535498] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ NULL Pointer Dereference [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-535502] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Out-of-bounds Read [High Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540956] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Out-of-bounds Read [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540958] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Uncontrolled Recursion [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540964] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ NULL Pointer Dereference [High Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540974] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Denial of Service (DoS) [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540978] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Denial of Service (DoS) [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540980] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Out-of-bounds Read [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540990] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ NULL Pointer Dereference [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540992] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ NULL Pointer Dereference [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540994] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Out-of-bounds Read [High Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540996] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Out-of-Bounds [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-540998] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Use After Free [High Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-541000] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
✗ Out-of-bounds Read [Medium Severity][https://snyk.io/vuln/SNYK-JS-NODESASS-541002] in<EMAIL_ADDRESS>introduced by<EMAIL_ADDRESS>><EMAIL_ADDRESS>No upgrade or patch available
Organization:      nrydevopswatch
Package manager:   npm
Target file:       package-lock.json
Project name:      blackbird-scanner
Open source:       no
Project path:      /home/rbruscoe/dev/blackbird-scanner
Licenses:          enabled
Run snyk wizard to address these issues.

Hello, are you using rekit 2.x? For 3.x rekit-core is no longer a dependency of the projects.

I'm using Rekit 3.0.0 and I followed the instructions to build it on your README.md for a new project.

I just removed Rekit-Core 3.0.0 from the 'package.json'; deleted the 'package-lock.json' and the 'node_modules' folder. Then I did a fresh 'npm install' and tried to then do 'npm start' but it failed with several errors saying it could not find the 'rekit-core' dependency.


[support-question] I cant add this repo... Invalid Add-on repository!

Thanks for your work on Cloudflared it looks prommising. But I get the message "Invalid Add-on repository!" when trying to add this repo. Do you have any idea what i could be doing wrong?

Solved, probably a home-assistant update issue, thanks anyway.


[Tooling] Update launch.json in .vscode

Description
So we can debug same as for connectors
Risk
really na
Deploy
none

@philipperolet editing .vscode. You feeling sick @philipperolet ? :P


libaom: 3.7.0 -> 3.7.1

Changes: https://aomedia.googlesource.com/aom/+/refs/tags/v3.7.1
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

CVE-2023-6879 heap-buffer-overflow on frame size change
https://bugzilla.redhat.com/show_bug.cgi?id=2256053


Is 64-bit float for BIL format out of spec?

According to ESRI documentation, BIL/BIQ/BSQ raster format only support integers (signed/unsigned) for 1, 4, 8, 16, 32 bits but the current implementation in WBT is also allowing 32-bit and 64-bit floats. However, GDAL (and even ArcMap...) also digresses from spec as it provides support for 32-bit floats but not 64-bit...
All that means that a 64-bit floats BIL file produced by WhiteboxTools can't be read by ArcMap or QGIS (via GDAL). So should the option write 64-bit float be removed for this file format to avoid bad surprise outside WBT?

Rather than asking for WBT to remove features, why not instead ask the GDAL project to add support? There are certain operations that do commonly require double-precision floats in the output rasters, most notably depression handling in DEMs. It is difficult to fully support certain raster formats in WBT unless they can handle this largest of common data formats. As long as you are working within WBT, this feature should not cause any issue. Users who wish to go outside of the WBT platform with f64 data using the BIL format will promptly be informed by GDAL that 64-bits are unsupported for this format and will likely then convert the data to something else, e.g. GeoTIFF, which does support 64-bit floats.

Rather than asking for WBT to remove features, why not instead ask the GDAL project to add support?

That's a fair point.

As long as you are working within WBT, this feature should not cause any issue.

When I first started using WBT, I was using its DEP format for all intermediary files for this exact reason, I was sure that I wouldn't have any issue within WBT. For me, the only reason to use an other file format is specifically if you need to read this file outside WBT. Thus, I would have expected those files to be readable by other softwares. Specifications exist for compatibility reasons between systems so it's in the interest of everyone to respect those specifications.
For this specific case, the BIL format, maybe nobody care respecting its spec (if I even found the correct one) because almost nobody uses it. I don't know. I personally just tried it because of the 64-bit issue with FLT and extent problem with GeoTIFF, I already ditched it for SDAT that seems to be written/read by everyone in the same way.


resources name wrong

Hi everyone,
I starting developing my own operator and I want to create a new namespace.
What happened:
My namespaces have the wrong name.
pattern: operatorName-instanceName
What you expected to happen:
pattern: instanceName
How to reproduce it (as minimally and precisely as possible):
operator.yaml
name: "toto"
version: "0.1.1"
kubernetesVersion: 1.13.9
maintainers:
  - name: my name
    email<EMAIL_ADDRESS>url: https://mywebsite.org
tasks:
  test:
    resources:
      - namespace.yaml
plans:
  deploy:
    strategy: serial
    phases:
      - name: main
        strategy: parallel
        steps:
          - name: everything
            tasks:
              - test

namespace.yaml
apiVersion: v1
kind: Namespace
metadata:
  labels:
    app: {{ .Name }}
  name: {{ .Name }}

Anything else we need to know?:
I also try to specify by another way my name
apiVersion: v1
kind: Namespace
metadata:
  labels:
    app: {{ .Params.name }}
  name: {{ .Params.name }}

But the result is still the same
pattern: operatorname-(.Params.name)
Environment:

Kubernetes version (use kubectl version): v1.13.9-gke.3
Kudo version (use kubectl kudo version): 0.7.3

I think I'm :+1: in removing dynamic names entirely. @mpereira @zmalik @akirillov wdyt? You'd have to template that in with .InstanceName where you want it, but it removes all magical decoration happening under the hood. We have plenty of other places we can flex magic and after @alenkacz and I talked about it, I think this is a better path for clarity.

Are "dynamic names" the random suffixes appended to an operator instance name when installed without an explicit --instance?

@gerred SGTM but can you provide a list of fields (labels/names etc) where it was being added the suffix so we can take the logic inside the operator using .InstanceName

@mpereira This was on the actual resources templated it out.
@zmalik https://github.com/kudobuilder/kudo/blob/master/pkg/engine/renderer/enhancer.go#L55-L73
That's everything we're decorating in via Kustomize. In this case, we'd remove the NamePrefix.

Yeah I've been thinking about it and disabling generating names sounds like the best option to me. You can always opt in by templating to that, but you cannot really easily opt out...
Let's wait a bit more if someone comes up with some reason to not do that. It will definitely be a feature of 0.8.0 though @Eviato . But that is due sometimes next week or so...


Use lower minSdkVersion

Hi @AndyFrench can you review the Travis-CI configuration for your branch? You've updated the buildToolsVersion from 23.0.1 to 23.0.2 but the Travis-CI configuration is the same. Maybe Travis-CI environments does not support that library.
I'd also like to know why have you changed the versionCode and versionName.

You would need to update the build tools version in .travis.yml as well, but at the moment travis doesn't seem to know about 23.0.2 so even doing that wouldn't work. Have to stay on 23.0.1 until they update on Travis-side (saw a commit for it today, so probably will be fixed soon)

Reverted the unnecessary changes now. Sorry about that

@flipper83 can you review this PR?

I've tested and we have a problem, before api 15 some permissions don't exist, we have a issue open with this problem (https://github.com/Karumi/Dexter/issues/3) and we can not put this pull request in master until the problem with permission that not exist have been solved. The best solution is not merge in master, merge it in other branch support-api-10 for example. Sounds good for you @pedrovgs ?

Ok :+1:

But this is already the case with the actual min version right (API 14) ?
So, if it's a missing feature for API 14 why not lowering to API 10 anyway ?
On Wed, Nov 25, 2015 at 11:32 AM, flipper83<EMAIL_ADDRESS>wrote:

I've tested and we have a problem, before api 15 some permissions don't
exist, we have a issue open with this problem (#3
https://github.com/Karumi/Dexter/issues/3) and we can not put this pull
request in master until the problem with permission that not exist have
been solved. The best solution is not merge in master, merge it in other
branch support-api-10 for example. Sounds good for you @pedrovgs
https://github.com/pedrovgs ?
—
Reply to this email directly or view it on GitHub
https://github.com/Karumi/Dexter/pull/13#issuecomment-159565121.

The previous min sdk was 14. This branch can go directly to master :) You have my :+1:

ok, go ahead! but can we put a note on the readme, that before api 15 some permissions don't exist?

Thanks for your @AndyFrench we will publish this change with the next release!!


Implement optimizers based on "Quantum circuit structure learning" paper

The paper "Quantum circuit structure learning" proposes two new algorithms for optimizing parameterized quantum circuits, Rotosolve and Rotoselect.
These work by recognizing that, if all other parameters are frozen, then the optimum value of a single parameter can be written as a simple sine function, with terms determined by certain circuit evaluations at shifted parameters. Thus, one can "jump" directly to a minimum by inverting a simple equation. The drawback is that you only update one parameter at a time.
These algorithms seem very straightforward, and could possibly be coded up as separate Optimizer classes within PennyLane (though I haven't 100% worked out if any changes would needed to other parts of the codebase). This might make a good community PR!
(suggested by @willzeng :) )

I agree. I would love to contribute to this effort

After having had a look at the paper I think that this only works for VQC. If the objective function is a more complicated function of the inputs I don't see how to implement that approach, essentially because it is gradient free and just minimizes the expectation of the circuit. But in general optimization this must not give the optimal cost.

I'm currently working on a tutorial for these algorithms; hopefully it can serve as a guide for implementing them as optimizer classes or something similar. As long as the cost function is a linear sum of expectations I think they work fine.

This is now implemented over at https://pennylane.ai/qml/app/tutorial_rotoselect.html


Feature request: authentication via JWT token

We are looking for a proxy AI API that we can call from client code. Since credentials on the client cannot be protected, it would be great if the proxy could accept a user JWT token with limited availability and verify the valid of the token with a provided secret before proceeding with the request.
Ideally, the user id contained in the JWT is logged to be able to monitor how many requests each user generates and prevent abuse.

Hi @marcoancona, I've added an endpoint that issues temporary credentials in the JWT format. PR linked above and the documentation is here: https://www.braintrust.dev/docs/guides/proxy#temporary-credentials-for-end-user-access
Please let me know what you think!


Documentation fix: dx vs. x0

What existing problem does the pull request solve?

Purely a documentation/example error. Was misled/wasted time debugging because of this issue.
Description:
dx/dy are zero in onPanResponderGrant, not x0/y0. x0/y0 will be the coordinates relative to the granted element, which are rarely zero.

By analyzing the blame information on this pull request, we identified @sebmarkbage and @sahrens to be potential reviewers.

LGTM. Can you rebase first?

@hramos I auto-merged via GitHub. Is this good enough?

@facebook-github-bot shipit


Syntax for RegexString flags?

How to write multiline / case-insensitive / single line, etc., RegexString? Just like what's provided in Regex?
julia> r"a+.*b+.*?d$"ism
r"a+.*b+.*?d$"ims

julia> match(r"a+.*b+.*?d$"ism, "Goodbye,\nOh, angry,\nBad world\n")
RegexMatch("angry,\nBad world")

I didn't implement flags, because they are not spliced into the regex string like the other things are. But I think you could just pass the flags at the moment where you convert the RegexString into the actual Regex. Aren't the flags keyword arguments to the Regex constructor?
Maybe I should think about how to add a more convenient method for flags

The thing is,

there is no Regex(r::RegexString, flags). If I have a RegexString, I need to use Regex(rs.s, "m") to convert
How do I do the multiline part when constructing RegexString using *? I have to add * "\s*" in between. I have something like:

capture(
    either(
        rs"A",
        "b",
        "c",
    );
    as = "X",
) *
rs"\h*d =\h*" *
NUMBER *
rs",  a" *
NUMBER

where either & rs"\h*d =\h*" should be connected by a line break, now I have to add a \s* manually.

Yeah I could add a regex constructor with flags.
I don't understand the other question, what are you trying to do? \s is any whitespace, not specifically a newline

I don't understand the other question, what are you trying to do? \s is any whitespace, not specifically a newline

That's why I am using this package 😂. I am not very familiar with regexes, so I need to build regexes with code.

Maybe you can describe what you're trying to match, and I can help you what the best syntax would be?

Maybe you can describe what you're trying to match, and I can help you what the best syntax would be?

Just consider any multiline matching, or ignoring the case matching.


Crash when replacing gear in converter while axle is turning

Was testing out the following setup: BWM windmill - BWM axle - converter A - mystical mechanics axles - converter B - BWM axle - IE dynamo (using "better with engineering")
Noticed the dynamo didn't seem to generate power. Assumed it might be because of loss from the wooden gears (from mystical gears) I was using in the converters. Tried replacing the gear in converter B with an iron one and got the following crash:
https://paste.dimdev.org/qivigegudu.mccrash

Did some more testing without using BWE or BWG features and I seem to be getting crashes whenever I try setups where BWM axle power is converted to MM power then back to BWM, using converters:
https://paste.dimdev.org/vuhutuwuni.mccrash

Side question: is there a way to change the conversion ratio between MM & BWM axle power? It would be very useful to have a config for this.

Did more testing - even when it doesn't crash, putting more than one converter in series will make the axles keep rotating on their own even after removing all power sources

I can't reproduce the crash at all, but i'm dealing with the power feedback issue right now

Thank you! I hope it's ok if I create a new issue about adding a conversion ratio config. I have more details I can add.


Refactor IFluidObject into a few different types for different parts of the feature detection scenario

Work Item
Searching in the code for IFluidObject, it's used in a number of disparate ways and is a bit tricky to pin down its purpose. This issue is a proposal to refactor it a bit to be more self-descriptive. It does not drastically change the paradigm for how it's used.
Describe the outcome you expect
IFluidObject's use for feature detection is more readily discernable in the code, and other related but more suitable types are used when appropriate.
Approach
The proposal is to refactor IFluidObject as it's currently used into 3 types:

Introduce type alias type FluidUnknown = object; to use instead of IFluidObject in API signatures.

This keeps a special type in API signatures as a hint that you should query the thing, but is more "honest" about the uncertainty around what the thing is. When you go to query it, you can invoke a feature detection mechanism, whether that's casting to IFluidObject or something else. As-is we're tying this mechanism all our APIs dealing with unknown objects.
Alias object instead of unknown since it's always going to be an object
This may mask #2566 which could introduce runtime errors instead of compile breaks - so this part is blocked on fully addressing that issue.

Use interface FluidDataInterfaceCatalog extends Readonly<... & ...>{ } for registering new IProvide interfaces.

The name is much clearer for the purpose it serves.
Synthesize would use keyof FluidDataInterfaceCatalog instead of keyof IFluidObject

Restate IFluidObject as interface IFluidObject extends Partial<FluidObjectInterfaceCatalog> { } for use as a cast target

Since API signatures wouldn't use IFluidObject anymore, every usage of something formerly typed as IFluidObject will need to cast. I like this since it bring the mechanism in play when you need it. And maybe some of these favor casting as Partial<IProvideFoo> directly to be more explicit.
Consider another name - QueryableFluidObject, which I think better describes the mechanism here

Names of all these things are totally up for grabs, just starting somewhere.
Open questions

Buyoff from the team on this approach at all :)
Final names for the three types
Exact plan for staging the refactor properly

Additional context
Reminder: Switching the type used in API signatures is blocked on #2566
Acceptance criteria
IFluidObject type is only used when the feature detection mechanism is invoked, and other more self-descriptive and better suited types are used in other parts of the system.

I want to revisit this before it's closed


Quiche roll<PHONE_NUMBER>1354

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Do we need to upgrade QUICHE always?


server --dev should run in Flask development mode

The environment variable: export FLASK_ENV=development should be set somehow when running server --dev. This allows the debugger and other niceties to be there for developers.

Shall we do something like os.environ["FLASK_ENV"] = "development" in the code? Only if verbose?

Yes os.environ["FLASK_ENV"] = "development" should do the trick since the child processes will inherit it. I would only set it in --dev though and keep --verbose just for terminal output.


VendorID check fails if URL not available

Observed behaviour
Someone wrote me privately,

I tried out fontbakery today (out of sheer curiosity) and I noticed that it complained about my VendorID saying it is not valid (while it was registered last year). In my vendor entry there's no URL though, maybe that's the reason?

Expected behaviour
VendorIDs without URLs should still be accepted, but perhaps a WARN should be returned reminding the vendor to register a URL with Microsoft.

The code-test that I implemented today ensures that a vendor id without a URL will be properly parsed from the HTML o Microsoft's website. I did not change the check implementation in order for this new code-test to pass, so it means the implementation was not flawed in that aspect.
So there must be some other reason for the vendor ID not being recognized. I guess that's because our cache was a bit outdated. I have updated the cache and now hopefully the vendor ID will be recognized. @davelab6, please ask the user.
In order to make sure we always keep it up-to-date I have added a note to the release instructions at https://font-bakery.readthedocs.io/en/latest/maintainer/maintainer-notes.html#updating-the-distribution-package
I presume these measures fixed the problem, so I will close this issue. If the problem persists, please re-open it.


Regarding Timestamp

Can we generate the timestamp from this ulid? Is there a functionality already present in this package?

Good feature request! I've added it to the library in version 4.0 through the toTimestamp() method. Please see the updated usage examples in the README.


Add signin name to top right of pages

Top right would be nice to have a sign-in button, and display logged in name so user knows if they're logged in.

@kate-rose this is in the icebox right now, but it looks like @nowfred merged @jschnapper's PR for it already. Should it go in the done column?


Startup errors are not published

Describe the bug
Some startup errors are not published to UI which leads to confusion and makes debugging harder.

Steps to reproduce

introduce a syntax error in evcc yaml
restart
evcc does not start properly but now error banner at the bottom is shown

Reason for this is that the fatal key does not seem to be published with the correct content. I guess this has to do with the new error structure introduced in #13319.
Configuration details
-

Log details
-

What type of operating system are you running?
Linux
Version
No response

Überraschend... Das Problem hier ist, dass die "einfachen" Fehler sich nicht als JSON codieren und nicht fmt.Stringer() implementierten. Was wäre in dem Fall das erwartete Format? Wäre ein einfacher String ok?


KZL-557 - Add collection controller csharp

What does this PR do?
Add collection controller for csharp.
The documentation is converted from cpp sdk.
Snippet are converted as well. We are missing some SWIG magic wrapping for exceptions and custom classes so all tests are not green.
(and yes the converter is in ruby :3 )
How should this be manually tested?

Step 1 : https://deploy-preview-191--kuzzle-doc-v2.netlify.com/sdk-reference/csharp/1/collection/create/
Step 2 :
Step 3 :
...

Other changes

Boyscout

 Snippets tests reports   SDK Version Tests overview      v6                   :x:                                    v5                           :heavy_check_mark:                            v1        v1        v1        v1

@Njuelle: Isn't C# missing in prism-js?


Fixed the anchor link issues in markdown files

The PR is to fix the readme anchor link issue in API docs.
What is broken:
The anchor link inside of the readme does not jump to the right place.
With the fix, all future documents will have the right link behavior.
Additional fix: Original readme will open a new tab whenever we click the anchor link e.g. #get-started. With the fix, only new page will open a new tab, click on the anchor link will stay in the same page.

/check-enforcer reset

/check-enforcer override


RNAndroidAudioStore TypeError: Cannot read property 'getSongs' of undefined

Hello, I'm trying to use RNAndroidAudioStore as mentioned by @Drazail in https://github.com/cinder92/react-native-get-music-files/issues/42#issuecomment-473815037 but it seems to be undefined.
I'm importing it like so:
import MusicFiles, { RNAndroidAudioStore } from 'react-native-get-music-files';
Is this is a recent addition to react-native-get-music-files? Do I need to update the lib to make it work or what?

@eff-society yes, this is a new addition, you will need to install the package via GitHub and follow the instructions given here specifically these steps:

A new Class called RNAndroidAudioStore is implemented and should be imported separately in MainApplication.java ( if the functionality is need of course):

import com.drazail.rnandroidstore.RNAndroidStorePackage;

new RNAndroidStorePackage()

you can also find the example app here
please note that the default export of the module has not been changed, so this update should be 100% backwards compatible.
I am sorry for the inconvenience, will make a pull request with updated docs as soon as possible.

I followed your instructions but now the android studio throws me the following errors:
 error: package com.reactlibrary does not exist
import com.reactlibrary.RNReatNativeGetMusicFilesPackage;
error: package com.drazail.rnandroidstore does not exist
import com.drazail.rnandroidstore.RNAndroidStorePackage;
error: cannot find symbol
            new RNAndroidStorePackage()

I installed the package via github with yarn add Drazail/react-native-get-music-files

@Drazail A little help please!

@eff-society, can you reproduce the issue in a public repo?

It seems I wasn't installing the lib correctly. Did what you said and got it working (only to find out that RNAndroidAudioStore doesn't return artwork paths 😁, which is necessary for my project). Guess I'll have to stick with the MusicFiles. Anyway, thanks for all the help.

@eff-society
unfortunately the ALBUM_ART constant of MediaStore.Audio.AlbumColumns was deprecated in API level Q and always returns null, so there is no way of accessing the covers android extracts on each scan. the only way to get the covers currently is to extract the metadata directly from the file itself, save it and send the path over to JS, which as you can imagine is very slow. here i can think of two solutions:
1-  you can use other methods of RNAndroidAudioStore, for instance, you can query the songs using search or getSongs, and then get the covers of the songs you want to show to the user via getSongByPath.
2-  if you are using the development branch of my fork ( i made a pull request yesterday, so it should be merged into masters branch of this repo soon) you can use RNAndroidAudioStore.getAll with batchNumber and delay options specified to implement some sort of pagination.
having said that, I do understand the importance of proper pagination. we have internally implemented  pagination for RNAndroidAudioStore.search, however it hasn't been tested yet, will add it to this module as soon as that's done.

i have being getting this error from android studio after going through all the steps
error: package com.drazail.rnandroidstore does not exist
import com.drazail.rnandroidstore.RNAndroidStorePackage;

It seems I wasn't installing the lib correctly. Did what you said and got it working (only to find out that RNAndroidAudioStore doesn't return artwork paths , which is necessary for my project). Guess I'll have to stick with the MusicFiles. Anyway, thanks for all the help.

How did you install it this ti

@Joshmatjjen Follow the instructions in the manual linking section. Then, uninstall the app from your device/emulator and rebuild. That should work.

@farshed  I have done that..  i am getting an error that says:
null is not an object (evaluating 'RNAndroidStore.getSongByPath')

@farshed Only getAll function works well

@Joshmatjjen sorry I have no idea what the problem might be.

@Joshmatjjen

null is not an object (evaluating 'RNAndroidStore.getSongByPath')

Can please you reproduce the issue and share the code with us?

@Drazail  I have created a new Issue

https://github.com/cinder92/react-native-get-music-files/issues/74


tinyset:0.1.0

I am submitting

[x] a new package
[ ] an update for a package

Tinyset is a minimal and opinionated library that provides a handful of utility functions for writing pure math pros for homework / psets. It contains a prebuilt header along with several environments for proof / question / sub question etc. I also added some custom plain English shorthand for common math symbols such as implication.

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

[x] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Hullo! I read the warning regarding kebab case but did not realize that this name would trigger it. I could update the name if that would better, but I don't think of the two words as separate, but rather as a hybrid name. Thanks.

Thank you for being so friendly and welcoming to a beginner! I'm glad the the Typst foundation is in such good hands, this really made my day!


chore(version): prey: update to 1.5.0

Updates the preyproject binary to version 1.5.0

Thank you for the contribution. It was merged directly as 4108c2d13fd4b96dadcf3a4cbcd2b60930c9aeaa to keep commit history cleaner. Your contribution is still credited to you.

no worries, thank you!


Bumped into ResourceExhaustedError while testing fix_temporary_defaults

While reviewing PR#101, I tested fix_temporary_defaults by fitting some(~3k) real events (crunching on a  GPU) and I bumped into a ResourceExhaustedError error. The same fit with the full dataset (~3k events) converges on master.
The same fit converges without memory issues with 10, 100, 1000 events on fix_temporary_defaults, but fails with the ResourceExhaustedError with 1500 events on fix_temporary_defaults. It also failed when I reverted back to 1000 events, but converges with 500 events, and converges with 1000 events after that.
I have also checked that there are no other processes competing for the resources.
Is it possible for deepcopy to introduce memory leaks? (I guess memory leaks do occur in Python...)
The codes I used are(largely, not sure how much details to provide to make it helpful):
class mySource(fd.SR1ERSource):
    energies = tf.cast(tf.linspace(0., 13., 1000),
                       dtype=fd.float_type())

ll = fd.LogLikelihood(sources=dict(er=mySource, ac=myAC),
                                batch_size = 100,
                                free_rates = 'er',
                                ...
                                elife = nuisance_range['elife'],
                                progress=False,
                             )
bf = ll.bestfit(guess=ll.guess(), optimizer='scipy')

The error I bumped into is:
---------------------------------------------------------------------------
ResourceExhaustedError                    Traceback (most recent call last)
<ipython-input-40-d118ddff446a> in <module>
     27
     28     tt_start = dt.datetime.now()
---> 29     whack2_result = whack2.bestfit(guess=whack2_guess, optimizer='scipy')
     30     tt_stop = dt.datetime.now()
     31     print('Time taken run %i: %s' % (irun, tt_stop-tt_start))

~/flamedisx/flamedisx/likelihood.py in bestfit(self, guess, fix, bounds, optimizer, get_lowlevel_result, get_history, use_hessian, return_errors, nan_val, optimizer_kwargs, allow_failure)
    524         # Check the likelihood has a finite value and gradient before starting
    525         val, grad, hess = self.log_likelihood(**guess,
--> 526                                               second_order=use_hessian)
    527         if not np.isfinite(val):
    528             raise ValueError("The likelihood is - infinity at your guess, "

~/flamedisx/flamedisx/likelihood.py in log_likelihood(self, second_order, omit_grads, **kwargs)
    329                     omit_grads=omit_grads,
    330                     second_order=second_order,
--> 331                     **params)
    332                 ll += results[0].numpy().astype(np.float64)
    333

~/.conda/envs/fd-test/lib/python3.6/site-packages/tensorflow/python/eager/def_function.py in __call__(self, *args, **kwds)
    778       else:
    779         compiler = "nonXla"
--> 780         result = self._call(*args, **kwds)
    781
    782       new_tracing_count = self._get_tracing_count()

~/.conda/envs/fd-test/lib/python3.6/site-packages/tensorflow/python/eager/def_function.py in _call(self, *args, **kwds)
    844               *args, **kwds)
    845       # If we did not create any variables the trace we have is good enough.
--> 846       return self._concrete_stateful_fn._filtered_call(canon_args, canon_kwds)  # pylint: disable=protected-access
    847
    848     def fn_with_cond(*inner_args, **inner_kwds):

~/.conda/envs/fd-test/lib/python3.6/site-packages/tensorflow/python/eager/function.py in _filtered_call(self, args, kwargs, cancellation_manager)
   1846                            resource_variable_ops.BaseResourceVariable))],
   1847         captured_inputs=self.captured_inputs,
-> 1848         cancellation_manager=cancellation_manager)
   1849
   1850   def _call_flat(self, args, captured_inputs, cancellation_manager=None):

~/.conda/envs/fd-test/lib/python3.6/site-packages/tensorflow/python/eager/function.py in _call_flat(self, args, captured_inputs, cancellation_manager)
   1922       # No tape is watching; skip to running the function.
   1923       return self._build_call_outputs(self._inference_function.call(
-> 1924           ctx, args, cancellation_manager=cancellation_manager))
   1925     forward_backward = self._select_forward_and_backward_functions(
   1926         args,

~/.conda/envs/fd-test/lib/python3.6/site-packages/tensorflow/python/eager/function.py in call(self, ctx, args, cancellation_manager)
    548               inputs=args,
    549               attrs=attrs,
--> 550               ctx=ctx)
    551         else:
    552           outputs = execute.execute_with_cancellation(

~/.conda/envs/fd-test/lib/python3.6/site-packages/tensorflow/python/eager/execute.py in quick_execute(op_name, num_outputs, inputs, attrs, ctx, name)
     58     ctx.ensure_initialized()
     59     tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
---> 60                                         inputs, attrs, num_outputs)
     61   except core._NotOkStatusException as e:
     62     if name is not None:

ResourceExhaustedError: 2 root error(s) found.
  (0) Resource exhausted:  OOM when allocating tensor with shape[100,105,455] and type float on /job:localhost/replica:0/task:0/device:GPU:0 by allocator GPU_0_bfc
	 [[{{node while/body/_12/while/gradients/gradients_1/Lgamma_7_grad/mul_grad/Mul_1}}]]
Hint: If you want to see a list of allocated tensors when OOM happens, add report_tensor_allocations_upon_oom to RunOptions for current allocation info.

	 [[while/LoopCond/_1637/_204]]
Hint: If you want to see a list of allocated tensors when OOM happens, add report_tensor_allocations_upon_oom to RunOptions for current allocation info.

  (1) Resource exhausted:  OOM when allocating tensor with shape[100,105,455] and type float on /job:localhost/replica:0/task:0/device:GPU:0 by allocator GPU_0_bfc
	 [[{{node while/body/_12/while/gradients/gradients_1/Lgamma_7_grad/mul_grad/Mul_1}}]]
Hint: If you want to see a list of allocated tensors when OOM happens, add report_tensor_allocations_upon_oom to RunOptions for current allocation info.

0 successful operations.
0 derived errors ignored. [Op:__inference__log_likelihood_36332]

Function call stack:
_log_likelihood -> _log_likelihood

Update: Managed to fit without memory issues after decreasing the batch size from 100 to 50 and the median running time increased from ~5.7 mins to ~13.7 mins.

Thanks for reporting Pueh. It sounds like the GPU memory requirements have increased, forcing you to use a smaller batch size. However this

It also failed when I reverted back to 1000 events, but converges with 500 events, and converges with 1000 events after that.

is strange.
I also don't understand how a change in _set_temporarily could trigger this. That function is only used in simulate and annotate_data, and neither of these is called when computing a likelihood. Perhaps it's the calls to simulate/annotate earlier on (e.g. when constructing a likelihood) that reserve some memory that is not cleared, so you have less available when you start fitting?
I changed #110 to use copy instead of deepcopy now, maybe this helps.
Finally it's odd that tensorflow asks you to look into report_tensor_allocations_upon_oom, while this option seems to be absent in tensorflow 2. Maybe it's still accessible via the compatibility v1 API? Could be worth looking into to further diagnose this issue.

This error is indeed the result when using a too large batch size for the GPU: you will and should see this message if you use too large batch sizes on any branch (before or after #110).
A simple example to reproduce is:
import flamedisx as fd
df = fd.ERSource().simulate(3_000)
ll = fd.LogLikelihood(sources=dict(er=fd.ERSource),
                      data=df,
                      batch_size=1_500)
ll()

The exact maximum batch size depends on your GPU and maybe your application (I would guess a fit needs a bit more memory, especially if using the Hessian). The above is enough to trigger ResourceExhaustedError on a Tesla T4 on Colab; it can handle batch_size=1_000.

With batch_size = 500, the above code uses 8960 MiB on both master and #110, based on running nvidia-smi immediately afterwards (as noted in #106, tensorflow is not exactly keen on clearing memory).
If I add elife=(200e3, 800e3, 2), to the likelihood setup the memory usage jumps to 14376 MiB (1.6x) on #110, but actually decreases slightly to 8576 MiB on master (0.95x).
Adding more parameters, e.g. er_pel_a=(14., 17., 2), does not change the memory required.

So I can confirm your observation: after fix_temporary_defaults, our GPU memory footprint is increased by ~60%. Now let's try to figure out why...

Turns out the cause is much more mundane than I feared: It's not the bugfix's fault, but the bug. The bug caused a wrong -- too high -- electron lifetime to be used for bounds estimation. Suppose you do this:
# Simulate data (or load from file, does not matter)
df = fd.ERSource().simulate(3000)

ll = fd.LogLikelihood(sources=dict(er=fd.ERSource),
                      elife=(200e3, 800e3, 2),
                      batch_size=500)

On master, due to the bug, the source's default elife has now incorrectly been changed to 800e3 us. If you set_data(df) now (or equivalently pass data=df when making the likelihood) the data will be annotated assuming the elife is 800e3 us.
At high elifes / larger efficiencies, flamedisx's internal tensors are smaller and consume less memory.
To prove this is what is happening, you can follow up the code above with this on master:
# This resets the default elife to 452e3 us
# as a side-effect of simulate.
ll.simulate()

# Bounds estimation now uses the correct 452e3 us as elife
ll.set_data(df)
ll()

This will show the 60% increased memory consumption on master. We didn't apply the bugfix, but simply worked around the bug by resetting the defaults (with a simulate call).
So there is no problem with the bugfix: the increased memory usage is simply what is required to correctly compute the likelihood.
(In fact, if you had 1/elife as a parameter, or if flamedisx did the mu simulation for the high elife before the one for the low elife, you would see the opposite effect: master would consume more memory and the fixed branch would take less.)

Of course, just a friendly reminder that once I put my NEST structure updates into 'original' FLAMEDISX, tensor sizes growing won't be an issue anymore; that'll be handled by the variable stepping. For those of you who don't know what I'm talking about, all will be revealed in our meeting on Friday :P


illegal character U+00A0

If I edit the go code with some web browsers (eg. Chrome for Android), when I insert a carriage return into the code, apparently a line feed (LF) (U+00AO) character is added as well which causes the go compiler to give a "illegal character U+00A0" error when I press the "Format" or "Run" button.
However, if I use Firefox for Android however, this problem doesn't occur. I assume because this web browser doesn't put a LF after the CR when the user presses Return in a text editing field.
If the golang compiler can't handle LF characters then they should be filtered out by the web app before submitting the code to the golang compiler.

This is still an issue. Any plan to fix it.

Still not fixed; here is a quick example:
`
for i:=1; i<n; i++ {
}

`
Btw, if you can have some pointers, I will fixe that.


Standard Solr Mode: Failure in updating documents due to malformed update URL

I am facing in issue trying to run the connector in Standard Solr mode, where the ingestion of documents from the topic fails because the solr update URL that is being created is not correct.
With the below configuration of the connector -
{
  "name" : "httpSolrSinkConnector1",
  "config" : {
    "connector.class" : "com.github.jcustenborder.kafka.connect.solr.HttpSolrSinkConnector",
    "tasks.max" : "1",
    "topics" : "authors",
    "solr.url" : "http://indexer:8983/",
    "key.converter":"io.confluent.connect.avro.AvroConverter",
    "key.converter.schema.registry.url":"http://schema-registry:8081",
    "value.converter":"io.confluent.connect.avro.AvroConverter",
    "value.converter.schema.registry.url":"http://schema-registry:8081"
  }
}

I get the following error trace
pipelinesetup-connect-1          | [2022-10-24 06:55:37,850] WARN Failed to parse error response from http://indexer:8983 due to: java.lang.RuntimeException: Invalid version (expected 2, but 60) or the data in not in 'javabin' format (org.apache.solr.client.solrj.impl.ConcurrentUpdateSolrClient)
pipelinesetup-connect-1          | [2022-10-24 06:55:37,850] ERROR error (org.apache.solr.client.solrj.impl.ConcurrentUpdateSolrClient)
pipelinesetup-connect-1          | org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException: Error from server at http://indexer:8983: Not Found
pipelinesetup-connect-1          |
pipelinesetup-connect-1          |
pipelinesetup-connect-1          |
pipelinesetup-connect-1          | request: http://indexer:8983/update?wt=javabin&version=2
pipelinesetup-connect-1          |      at org.apache.solr.client.solrj.impl.ConcurrentUpdateSolrClient$Runner.sendUpdateStream(ConcurrentUpdateSolrClient.java:385)
pipelinesetup-connect-1          |      at org.apache.solr.client.solrj.impl.ConcurrentUpdateSolrClient$Runner.run(ConcurrentUpdateSolrClient.java:183)
pipelinesetup-connect-1          |      at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:209)
pipelinesetup-connect-1          |      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
pipelinesetup-connect-1          |      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
pipelinesetup-connect-1          |      at java.lang.Thread.run(Thread.java:748)

As you can see the Solr URL generated is  http://indexer:8983/update but it should be  http://indexer:8983/solr/authors/update
The connector works if I change the solr.url in the config to
"solr.url" : "http://indexer:8983/solr/authors",

This however will force the user to create one connector per topic.
To further make sense of the error stacktrace, especially
Invalid version (expected 2, but 60) or the data in not in 'javabin' format
Which is mentioned in the README as being caused due to version mismatch, is being caused here because when we hit the malformed URL, we get

<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
<title>Error 404 Not Found</title>

HTTP ERROR 404

Problem accessing /solr/update. Reason:

    Not Found

Here the first < has the ASCII value 60, which probably explains the error.
I am using Solr version 8.2.0 and my SolrJ version is the same too.

see #53


why (Vue3 + vue-tsc) so bad compaired to (React + TypeScript	) ?

Describe the bug
(Vue3 + vue-tsc) vs  (React + TypeScript)
Reproduction
(Vue3 + vue-tsc) vs  (React + TypeScript)
Expected behavior
(Vue3 + vue-tsc) vs  (React + TypeScript)
System Info
(Vue3 + vue-tsc) vs  (React + TypeScript)

Additional context
(Vue3 + vue-tsc) vs  (React + TypeScript)
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

TypeScript supports React internally, which vue does not. vue-tsc did a lot of great work to make type check works for vue combined with TypeScript. Please keep nice in the community.

@moHaHa what exactly is better? Im just curious


mWeb - BA - On tapping "next" in manually enter bank account page, user directed to continue setup

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:

Go to https://staging.new.expensify.com/home
Tap profile icon -- workspaces-- workspace
Tap more features - enable workflow
Tap workflow in workspace settings
Tap connect bank account
Complete the flow using region bank - selecting account ending 1111
Note user directed to continue set up page instead of "manually add bank account page"
Navigate to settings and tap connect bank - continue set up
On tapping next on manually enter bank account page, user directed to continue set up page again
When we revisit the page by tapping next, user directed to personal information page

Expected Result:
On tapping "next" in manually enter bank account page, user must not be directed to continue set up page
Actual Result:
On tapping "next" in manually enter bank account page, user directed to continue set up page again instead personal information page.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/7e4c3ae1-ba4c-45ab-8a6a-287c285d95f0
View all open jobs on GitHub

Production:
https://github.com/user-attachments/assets/ddf69774-1784-405c-b86a-10961e68b03a

Traced it to https://github.com/Expensify/App/pull/51315 - looking to see if we can maybe fix without reverting

it's specifically this useEffect - I'm not sure what that was added for so I hesitate just to remove

So it's not the blink, i think the description could be clearer.
Basically, when you are on the "Manually add your bank account" pane (usually gotten to by clicking "continue setup" or by clicking "back" from the Personal info pane), when you click next you should be brought to the Personal info pane, NOT the Continue Setup pane. This is the behavior that's wrong here.

It might also be a bug that existed before but was unearthed by this PR - the personal-information pane doesn't actually exist in the list of steps, so I think the logic doesn't know where to go from the new page...

I am checking

The offending Pr is reverted, we can close now and make sure its addressed with the PR going again


@ or this is not used for named arguments or own properties

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
The issue is that @ or this is not used for named arguments or own properties.
Here is the diff that solved my problem:
diff --git a/node_modules/ember-json-viewer/addon/templates/components/entry-viewer.hbs b/node_modules/ember-json-viewer/addon/templates/components/entry-viewer.hbs
index b799bea..e848d06 100644
--- a/node_modules/ember-json-viewer/addon/templates/components/entry-viewer.hbs
+++ b/node_modules/ember-json-viewer/addon/templates/components/entry-viewer.hbs
@@ -12,7 +12,7 @@
         {{! In order for copy/paste to work, the quoted key (e.g. '"foo": ')
           must be a single text node
         }}
-        {{quotedKey}}
+        {{this.quotedKey}}

   {{else}}
@@ -20,7 +20,7 @@
       {{! In order for copy/paste to work, the quoted key (e.g. '"foo": ')
         must be a single text node
       }}
-      {{quotedKey}}
+      {{this.quotedKey}}

   {{/if}}
   {{value-viewer
diff --git a/node_modules/ember-json-viewer/addon/templates/components/value-viewer.hbs b/node_modules/ember-json-viewer/addon/templates/components/value-viewer.hbs
index 4ff1666..adefb9d 100644
--- a/node_modules/ember-json-viewer/addon/templates/components/value-viewer.hbs
+++ b/node_modules/ember-json-viewer/addon/templates/components/value-viewer.hbs
@@ -12,20 +12,20 @@
       {{this.valueSummary}}

   {{else}}
-

+

       {{#if this.isObj}}
-        {{#each-in value as |key innerValue|}}
+        {{#each-in this.value as |key innerValue|}}
           {{entry-viewer
             key=key
             value=innerValue
             depth=this.depth
             path=(concat this.path "." key)
             displayOptions=this.displayOptions
-            isLast=(is-last value key)
+            isLast=(is-last this.value key)
           }}
         {{/each-in}}
       {{else}}
-        {{#each value as |innerValue index|}}
+        {{#each this.value as |innerValue index|}}

             {{value-viewer
               value=innerValue
@@ -33,7 +33,7 @@
               path=(concat this.path "[" index "]")
               displayOptions=this.displayOptions
             }}
-            {{#unless (is-last value index)}}
+            {{#unless (is-last this.value index)}}
               {{! In order for copy/paste to work, there cannot be extra whitespace around the delimiter }}
               ,
             {{/unless}}

This issue body was partially generated by patch-package.

@juliolegrec Thanks for reporting! We'll take a look at fixing this.


Esbuild file loader significant slowdown

Which @angular/* package(s) are the source of the bug?
compiler
Is this a regression?
Yes
Description
Esbuild config:
{
  absWorkingDir: '/Users/user/WebStorm/project',
  bundle: true,
  format: 'esm',
  assetNames: 'media/[name]-[hash]',
  conditions: [ 'es2020', 'es2015', 'module' ],
  resolveExtensions: [ '.ts', '.tsx', '.mjs', '.js' ],
  metafile: true,
  legalComments: 'eof',
  logLevel: 'silent',
  minifyIdentifiers: false,
  minifySyntax: false,
  minifyWhitespace: false,
  pure: [ 'forwardRef' ],
  outdir: '/Users/user/WebStorm/project',
  outExtension: undefined,
  sourcemap: 'external',
  splitting: true,
  chunkNames: '[name]-[hash]',
  tsconfig: '/Users/user/WebStorm/project/apps/project/tsconfig.app.json',
  external: [],
  write: false,
  preserveSymlinks: true,
  define: { ngJitMode: 'false', ngI18nClosureMode: 'false' },
  loader: {},
  footer: undefined,
  platform: 'browser',
  mainFields: [ 'es2020', 'es2015', 'browser', 'module', 'main' ],
  entryNames: '[name]-[hash]',
  entryPoints: {
    main: '/Users/user/WebStorm/project/apps/project/src/main.ts'
  },
  target: [
    'chrome123.0',
    'chrome122.0',
    'edge123.0',
    'edge122.0',
    'firefox124.0',
    'firefox123.0',
    'safari17.4',
    'safari17.3',
    'safari14.1'
  ],
  supported: {
    'async-await': false,
    'object-rest-spread': false,
    'class-field': false,
    'class-static-field': false
  },
  plugins: [
    { name: 'angular-sourcemap-ignorelist', setup: [Function: setup] },
    { name: 'angular-compiler', setup: [AsyncFunction: setup] },
    { name: 'project-esbuild-plugin', setup: [Function: setup] },
    { name: 'angular-external-packages', setup: [Function: setup] }
  ]
}

Build
Application bundle generation complete. [66.045 seconds] (Initial)
Application bundle generation complete. [24.893 seconds]
Application bundle generation complete. [11.307 seconds]
Application bundle generation complete. [10.102 seconds]
Application bundle generation complete. [9.114 seconds]

Adding file loader no code changes, no import of mp4 file
{
  absWorkingDir: '/Users/user/WebStorm/project',
  bundle: true,
  format: 'esm',
  assetNames: 'media/[name]-[hash]',
  conditions: [ 'es2020', 'es2015', 'module' ],
  resolveExtensions: [ '.ts', '.tsx', '.mjs', '.js' ],
  metafile: true,
  legalComments: 'eof',
  logLevel: 'silent',
  minifyIdentifiers: false,
  minifySyntax: false,
  minifyWhitespace: false,
  pure: [ 'forwardRef' ],
  outdir: '/Users/user/WebStorm/project',
  outExtension: undefined,
  sourcemap: 'external',
  splitting: true,
  chunkNames: '[name]-[hash]',
  tsconfig: '/Users/user/WebStorm/project/apps/project/tsconfig.app.json',
  external: [],
  write: false,
  preserveSymlinks: true,
  define: { ngJitMode: 'false', ngI18nClosureMode: 'false' },
  loader: { '.mp4': 'file' },
  footer: undefined,
  platform: 'browser',
  mainFields: [ 'es2020', 'es2015', 'browser', 'module', 'main' ],
  entryNames: '[name]-[hash]',
  entryPoints: {
    main: '/Users/user/WebStorm/project/apps/project/src/main.ts'
  },
  target: [
    'chrome123.0',
    'chrome122.0',
    'edge123.0',
    'edge122.0',
    'firefox124.0',
    'firefox123.0',
    'safari17.4',
    'safari17.3',
    'safari14.1'
  ],
  supported: {
    'async-await': false,
    'object-rest-spread': false,
    'class-field': false,
    'class-static-field': false
  },
  plugins: [
    { name: 'angular-sourcemap-ignorelist', setup: [Function: setup] },
    { name: 'angular-compiler', setup: [AsyncFunction: setup] },
    { name: 'project-esbuild-plugin', setup: [Function: setup] },
    { name: 'angular-external-packages', setup: [Function: setup] }
  ]
}

Build
Application bundle generation complete. [82.725 seconds] (initial)
Application bundle generation complete. [45.292 seconds]
Application bundle generation complete. [30.198 seconds]
Application bundle generation complete. [27.803 seconds]
Application bundle generation complete. [26.910 seconds]

With file loaders rebuild is almost 3x slower
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
No response
Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 17.3.0
Node: 20.12.1
Package Manager: yarn 1.21.1
OS: darwin arm64

Angular: 17.3.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, pwa, router, service-worker

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1703.0
@angular-devkit/build-angular   17.3.0
@angular-devkit/build-webpack   0.1703.0
@angular-devkit/core            17.3.0
@angular-devkit/schematics      17.3.0
@ngtools/webpack                17.3.0
@schematics/angular             17.2.0
ng-packagr                      18.0.0-next.3
rxjs                            7.6.0
typescript                      5.4.5
webpack                         5.90.3
zone.js                         0.13.0

Anything else?
No response

Duplicate of https://github.com/angular/angular-cli/issues/27116

If you use yarn 4, you can use yarn patch @angular-devkit/build-angular to apply this https://github.com/angular/angular-cli/pull/27120 yourself to the cli, to prevent the cli adding the externalPackagesPlugin which is causing the slowdown.

I used npx patch-package to do something similar. It would be great if CLI could support flag that would disable this plugin otherwise this may break any time (I hope it won't be soon 😁). Perf impact on bigger projects is huge IMO "angular-external-packages" takes twice as long as rest of recompilation, in my case also doing nothing.

The next RC (will be out this week) has a perf improvement for cases of only using file type loaders. The team is also evaluating improvements for the other types of loaders but will most likely land in the 18.x timeframe.


fix admin ui deps

had to pin a few s3 related deps (from poetry.lock) or pip couldn't resolve them

fixes #2843


💡 [REQUEST] - TTP Setup Steps

Implementation PR
No response
Reference Issues
No response
Summary
TL;DR
We need the following features:

mark certain steps as "setup steps"
have these steps run only when required (e.g. when an attacker tool must be compiled for the first time), not on every TTP execution

ART has this functionality in their dependencies blocks:
  dependency_executor_name: command_prompt
  dependencies:
  - description: |
      Computer must have python 3 installed
    prereq_command: |
      py -3 --version >nul 2>&1
      exit /b %errorlevel%
    get_prereq_command: |
      echo "Python 3 must be installed manually"

Background: Reasons to Separate Setup Steps and Regular Steps
Setup Step Execution Can Require Specialized Tooling
For example, it may require specialized kernel headers or a C compiler to build a kernel module TTP,
but deploying that TTP should just require copying the resulting .ko file
Setup Steps May Require Specific Network Connectivity
A setup step  that requires downloading mimikatz from github probably can’t even run in a network-locked-domain environment like a domain controller. However, that doesn't mean one shouldn't necessarily "assume breach"
and still run mimikatz TTPs that reference an already-downloaded binary.
Prerequisites May Take a Long Time to Run
You shouldn’t be building a giant executable from source every time you want to run it.
Prerequisites May be Shared Across TTPs
Suppose that you have a given TTP that uses the ttp: syntax to start multiple kubernetes pods from the same base docker image. That docker image shouldn’t get rebuilt every time.
Proposed Solution
We should reuse many of our existing steps for this purpose:
setup:
  steps:
    - name: download_mimikatz
       fetch_uri: ...
       download_path: mimikatz.exe
       success_criteria:
         file_exists:
           path: mimikatz.exe
           hash: ...

The steps: used in setup: can have the following custom behavior applied to them when invoked by ttpforge run:

the success_criteria checks will be run PRIOR to the execution of the step itself
if the success criteria is met, that step will be skipped (don't need to download mimikatz again if it is already there)
one can run ttpforge run --setup-only to run the setup steps without running the TTP - useful for situations where you want to package the TTP in a tar file and deploy it elsewhere

Basic Example
Example links:
https://github.com/redcanaryco/atomic-red-team/blob/master/atomics/T1003.002/T1003.002.yaml
https://github.com/redcanaryco/atomic-red-team/blob/0fbf08855e8955420672cb5e55db2f0e5f0e8588/atomics/T1609/T1609.yaml
Drawbacks
Sometimes you'll just want the "setup_step" to be part of the regular "steps:" array and have it get run
every time the TTP is executed.  For example, dropping mimikatz might be part of the TTP and you may wish to explicitly measure the associated telemetry/EDR response.
Unresolved questions
No response

Going to work on this after success criteria

Ya I think it looks like a good idea. Making specific success_criteria for specific steps would cut down on a lot of inline bash scripts.


Fix Contract Configurator version 1.6.1 and 1.6.2

The CKAN bot made a mess of things by using 1.6.2 and checking it in over 1.6.1.  Now there are some users who are on CKAN version "1.6.1" that actually have the latest, but others who are on the real 1.6.1 release.

Sigh...  I see the problem now, it's because I never updated my .version file.  Since having that wrong is going to cause me all kinds of other problems, I'm just going to release 1.6.3 in a bit to clean things up.  PR withdrawn.


Enhancing the login/signup page using Firebase integration

Description
This enhancement aims to streamline the user login and signup process on our website by integrating Firebase Google Authentication. By implementing Firebase, users will enjoy a seamless experience, as they can log in or sign up with their existing Google accounts with just a few clicks. This not only simplifies the authentication process but also enhances security by leveraging Google's robust authentication mechanisms. Integrating Firebase into the login and signup pages will contribute to an improved user experience, reducing friction and increasing user engagement. Let's make this platform easier and more secure for our users by implementing Firebase Google Authentication.

@hereisSwapnil you can assign this issue to me

@adarsh1001111 Ok, but I want the user to be stored in the MongoDB only

@hereisSwapnil We can export the users from firebase to mongoDb using script if we need both auth of firebase and Database as MongoDB, is this fine?

Ok :+1:


Order Creation

Coverage remained the same at 54.181% when pulling 6ead88967ac6171dbfe6c5be3e865014f0e1aa19 on cpacia:master into cc5736ed1d2011b56d44fffbb7e066661fee28a1 on OpenBazaar:master.


CCX L3 picture cache size

I think this picture might be wrong https://docs.csc.fi/img/mahti_ccd.png . Shouldn't the L3 cache be 16MiB/CCX and 32MiB/CCD ?

Fixed in #937


Sign in

As a user, when I open the application I want to sign in to my account via entering my email and password or via OpenID Connect

Details

Design Sign in page
figure out how openID connect works - link to user account
require this page, when opening the web app
link to the search page after login
display error message, if something went wrong

Done are:

link to user account
error message
have this as root path

[ ] add rerouting to search page after login
[ ] add skip button and design layout
[ ] map user account to person with mail address


How to import my own text data, as well as through and matchzoo generate the specified data text file

I have run some toy_example in matchzoo ,but  i want to train model and predict with my own text data, I  need your help please .

Do you mean you want to use the trained model in an interactive way ? Currently MatchZoo does not support this. But you can process the predicted score file by MatchZoo for your own purpose. You should prepare the input data according to the input format of MatchZoo.


Make createReadStream return an Either

Resolves #42 (at least for createReadStream)

:-1: from me, see reasoning in #42.


Hot restart bug will cause the socket to not listening

Title: Hot restart bug will cause the socket to not listen
Description:
     "listener": {
      "name": "virtual",
      "address": {
       "socket_address": {
        "address": "<IP_ADDRESS>",
        "port_value": 15001
       }
      },
     .....
     "listener": {
      "name": "<IP_ADDRESS>_15001",
      "address": {
       "socket_address": {
        "address": "<IP_ADDRESS>",
        "port_value": 15001
       }
      "deprecated_v1": {
          "bind_to_port": false
      }

    .....

When the 15001 listener appears at the same time, one of them will bind the socket and listening, and the other will not bind. In this case, the hot restart gets the socket of the previous process and may get the socket that is not listening.

The reason for this problem is because the query listener is queried through the port and address, this is not the only one to represent the listener. Two listeners exist on the same port and address
Repro steps:

The same listener appears twice, one listener bind and listening, the other does not bind, then triggers a hot restart to see if the hot restart is listening.

/assign @zyfjeff

Fixed.


Windows: introduce a new docker image for Windows

Introduce a docker image that is meant for CI purposes.  This is a complete docker image that should have the necessary components for building a Windows toolchain with some subst trickery.

@swift-ci please test


Set custom flutter_assets by add FLTAssetsPath to User-Defined variable

Discussion of related issues at https://github.com/flutter/flutter/issues/29281

cc @dnfield

cc @dnfield

Yes, You are right .
I change the way of get FLTAssetsPath   value.
Get FLTAssetsPath   value from AppFrameworkInfo.plist if exist

LGTM! Thanks!


Add versioning to format

This PR adds a "version" attribute to the format.
This proposes a two digit version specifier: MAJOR.MINOR, like a truncated semver specifier.

MAJOR increments mean that there are breaking changes
MINOR increments indicate additions. Any minor increments must strictly be additions to the specification and must be compatible with all previous minor releases within the major release series. If a reader is capable of reading a version 1.1 store, it must be able to read a version 1.0 store.
There is no PATCH, because it's unclear what a bug fix means in the context of specifications

Possible addition: development/ release candidate versioning
I would like to be able to have release candidates/ development versions for this specification. The main thing here is to give us a way to hack on the specification before committing to a final version. That way any files we write and share during this phase are clearly marked as potentially being invalid. I would propose following semantic versioning or python's PEP440 to support release candidates and development versions (notes on compatibility). The PEP is suggested since I don't believe I've seen many non-python projects use the semver release candidates and dev semantics.

semver
PEP440

Development
a little unclear
X.Y.devN

Release Candidate
X.Y-rcN
X.YrcN

This wouldn't strictly need to be documented in the spec, but it would be good to document somewhere.
Alternatives
No MINOR
When I reached out to OME-NGFF I was told they only intend to have a single digit version. They are only doing versions like 0.4 right now because it is still broadly unstable.
We could do the same thing here. However, we have discussed multiple additions that would not neccesitate full nD support, but would increase the scope of the spec. This includes: chunking, triangular formats, masked formats.
PATCH
The PATCH is not included because it's not clear what a bug fix for a file format should mean. There are specifications that use a patch release:
Prior art

CF conventions (NetCDF Climate and Forecast Metadata Conventions) uses a similar versioning scheme: http://cfconventions.org/Data/cf-conventions/cf-conventions-1.10/cf-conventions.html#revhistory
Arrow specifies the library and format number separately. While they do use 3 digits, I can't find an example where the third digit is used for the format post 1.0, and versions are referred to by two digits in the documentation and flat buffer spec
SBOL (systems biology language) uses a three digit version, though I don't believe they are following semver (e.g. 3.0.1 seems like it added features)
EML (Ecological metadata language) uses a three digit version where bug fixes can include typos in the specification. I don't think these need to be included in the file format, through do indicate a need for documentation that can be versioned separately from the format itself.

These changes look great! Could we also list the current version at the top of the spec document?

@ivirshup @willow-ahrens I added the version number to the top of the file and also changed the version to 0.5, which is what we had written in the notes.
Is this ready to merge?

LGTM! I just changed the version to 0.1 as suggested


Implement Queue using Two Stacks

Implement Queue using two Stacks

In this we are given a stack and we want to implement queue from it.

Language: C++

/assign

Hi, I want to work on this issue and want to upload this algorithm

Hi @Akhilesh2002,
I'd like to contribute by implementing a queue using two stacks in C++. Could you assign this issue to me?
Thank you!


various performance improvements

This PR contains has a few performance improvements for UniValue.  Most importantly, it adds move semantics, and a way to easily transition legacy code to make use of the new methods.
I've used BlockToJsonVerbose as my benchmark. With this PR alone the benchmark runs 1.26 times faster. When actually making use of the new move semantics in bitcoin's core_write.cpp and blockchain.cpp, this speeds up the benchmark by a factor of ~2.3 on my machine.

ns/op
op/s
err%
total
benchmark

63,370,373.00
15.78
0.9%
0.70
BlockToJsonVerbose master

50,111,950.00
19.96
0.7%
0.56
BlockToJsonVerbose this PR

27,775,808.00
36.00
0.4%
0.31
BlockToJsonVerbose this PR + using move semantics in core_write.cpp and blockchain.cpp

I got no response whatsoever on move-semantic PR on https://github.com/jgarzik/univalue/pull/79 from about 8 months ago, so I'm opening this PR here and close the other one.

@theuni you might also be interested in this.

That said, I'll review this in detail. There's certainly some low-hanging fruit here. Thanks @martinus!

Hi! I unfortunately didn't have any time to work on this lately. Here are some things I still wanted to do, that's why I've marked this PR as draft:

I don't like that there are so many push_back, pushKV methods. Maybe it's possible to get rid of all of them and have just a single templated version in the header. Care needs to be taken about automatic conversions.
Have a close look at https://github.com/cculianu/univalue which is supposed to be a c++17 rewrite of univalue, which was posted on reddit a while ago
Univalue's members make plain default constructor and destructor slow, because there are so many objects. It would be interesting to experiment with doing something else there

Needs rebase :octopus:

I accidentally rebased first to the wrong branch, so see git range-diff ced6a36...55265e8 for the actual rebase changes. Fixed a few conflicts in the includes

Maybe split up the first and last commit into a separate change? This way there'd be appendNumToString and std::move separate from each other.

@martinus note that now we've "unsubtree'd" univalue, so you could open this PR against bitcoin/bitcoin directly. At the same time you could drop WITH_UNIVALUE_COPY_OPERATIONS and directly use the new code.


Provide progress reporters for non TTY consoles

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

Command (mark with an x)
- [ ] new
- [x] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

GitLab CI Runner (Docker Executor: https://docs.gitlab.com/runner/executors/docker.html)
$ node -v
v11.6.0

$ npm -v
6.5.0-next.0

$ ./node_modules/@angular/cli/bin/ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 7.2.1
Node: 11.6.0
OS: linux x64
Angular: 7.2.0
... animations, common, compiler, compiler-cli, core, forms
... http, platform-browser, platform-browser-dynamic
... platform-server, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.12.1
@angular-devkit/build-angular      0.12.1
@angular-devkit/build-optimizer    0.12.1
@angular-devkit/build-webpack      0.12.1
@angular-devkit/core               7.2.1
@angular-devkit/schematics         7.2.1
@angular/cdk                       7.2.1
@angular/cli                       7.2.1
@angular/flex-layout               7.0.0-beta.22
@angular/material                  7.2.1
@angular/material-moment-adapter   7.2.1
@ngtools/webpack                   7.2.1
@schematics/angular                7.2.1
@schematics/update                 0.12.1
rxjs                               6.3.3
typescript                         3.2.2
webpack                            4.23.1

Repro steps

Execute a ci command which builds the angular application as part of it's execution. Ensure progress logging is enabled
./node_modules/@angular/cli/bin/ng build --progress=true

The log given by the failure

Desired functionality
Build progress is logged in a format which is readable in CI environments or where the output is not a TTY console.
Mention any other details that might be useful

Related PR: https://github.com/angular/angular-cli/pull/13405

Hi, what is the use case to enable progress in a CI environment?

Azure supports monitoring console via browser during CI builds.
However, more than anything I want the final CI output to be readable, which could be implemented either as part of progress (as suggested by this issue), or as a separate machine output flag (as #6478  more likely implies).

In version 11, the progress reporting has been revamped completely which should address this issue.
If the problem persists after updating to version 11. Kindly feel free to open a new issue.

In version 11, the progress reporting has been revamped completely which should address this issue.
If the problem persists after updating to version 11. Kindly feel free to open a new issue.


[WIP] Export bech32 and bech32m functions

Description
Export bech32 and bech32m functions. Fix issue https://github.com/trustwallet/wallet-core/issues/4100

How to test
Run Rust, C++, iOS, Android tests

Types of changes

Checklist

[x] Create pull request as draft initially, unless its complete.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

[x] I have read the guidelines for adding a new blockchain.

Hi @satoshiotomakan, could you help review it? Also, could you trigger CI to run the tests? I can't run the iOS, Android, or TypeScript tests due to my local environment.


feat: orchestrator not failing and requeing failed nonces

Overview

Checklist

[ ] New and updated code has appropriate documentation
[ ] New and updated code has new and/or updated testing
[ ] Required CI checks are passing
[ ] Visual proof for any user facing features like CLI or documentation updates
[ ] Linked issues closed with keywords

Summary by CodeRabbit

Performance Improvements

Optimized retry logic with adjusted parameters for quicker retry attempts.

New Features

Introduced a new constant to manage requeue behavior in the system.

Enhancements

Enhanced logging capabilities by adding debug-level logging for more granular troubleshooting.

Refactor

Updated several methods to accept context directly, improving the flow and control of operations.
Implemented a new method for conditional requeuing of tasks, enhancing the robustness of the system.

Bug Fixes

Fixed an issue where the application did not correctly handle error cases during startup and event processing.

Codecov Report
Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (2496504) 25.91% compared to head (e9a53f9) 25.83%.

:exclamation: Current head e9a53f9 differs from pull request most recent head 28e77c1. Consider uploading reports for the commit 28e77c1 to get more accurate results

Files
Patch %
Lines

orchestrator/orchestrator.go
0.00%
20 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   25.91%   25.83%   -0.09%
==========================================
  Files          29       29
  Lines        3044     3054      +10
==========================================
  Hits          789      789
- Misses       2160     2170      +10
  Partials       95       95

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.