systemtests - cli clients tests - wait for receivers to attach

Type of change

Bugfix

Description
This PR tries to make messaging client tests more stable, currently there are tests where receivers are started before senders and this is a source of failures in some environments...
To address that systemtests now detects when the receivers are attached reading the trace log from the clients, note some clients we use do not support any kind of trace log that we can use for this purpose.
a sleep in some tests where receivers are started before senders,

Checklist

[ ] Update/write design documentation in ./documentation/design
[x] Write tests and make sure they pass
[ ] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[x] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@enmasse-ci run tests profile=shared

Overall comment - much less scary! thanks @famartinrh

:x: Test Summary :x:
TEST_PROFILE: shared
TEST_CASE:
TOTAL: 211
PASS: 190
FAIL: 8
SKIP: 13
BUILD_NUMBER: 364
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testRoundRobinReceiver in io.enmasse.systemtest.shared.brokered.clients.artemis.MsgPatternsTest
testTopicSubscribe in io.enmasse.systemtest.shared.brokered.clients.artemis.MsgPatternsTest
testMessageSelectorTopic in io.enmasse.systemtest.shared.brokered.clients.artemis.MsgPatternsTest
testRoundRobinReceiver in io.enmasse.systemtest.shared.brokered.clients.openwire.MsgPatternsTest
testTopicSubscribe in io.enmasse.systemtest.shared.brokered.clients.openwire.MsgPatternsTest
testMessageSelectorTopic in io.enmasse.systemtest.shared.brokered.clients.openwire.MsgPatternsTest
testCannotOpenConsolePage in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest
testCreateDeleteTopic in io.enmasse.systemtest.shared.standard.web.FirefoxConsoleTest

@enmasse-ci run tests profile=shared

@enmasse-ci run tests profile=shared

:x: Test Summary :x:
TEST_PROFILE: shared
TEST_CASE:
TOTAL: 211
PASS: 196
FAIL: 2
SKIP: 13
BUILD_NUMBER: 376
:heavy_exclamation_mark: Test Failures :heavy_exclamation_mark:

testCreateDeleteTopic in io.enmasse.systemtest.shared.standard.web.ChromeConsoleTest
testSortConnectionsByContainerId in io.enmasse.systemtest.shared.standard.web.ChromeConsoleTest


db pull with multiSchema error on schema with 2 models with the same table name but in a different schema

Bug description
I get the following error when introspecting my PostgreSQL database
Error: [libs/dml/src/datamodel.rs:178:14] Every RelationInfo should have a complementary RelationInfo on the opposite relation field.

How to reproduce

create schema.prisma file
create PostgreSQL database from provided SQL
npx prisma db pull
Get error

Expected behavior
It should work?
Prisma information

datasource db {
  provider = "postgres"
  url      = env("TEST_POSTGRES_URI")
  schemas  = ["base", "transactional"]
}

generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["multiSchema"]
}

-- CreateSchema
CREATE SCHEMA IF NOT EXISTS "base";

-- CreateSchema
CREATE SCHEMA IF NOT EXISTS "transactional";

--
-- tables names are renamed so they are identical
-- Original names are User and Post
--

-- CreateTable
CREATE TABLE "base"."some_table" (
    "id" TEXT NOT NULL,
    "email" TEXT NOT NULL,

    CONSTRAINT "User_pkey2" PRIMARY KEY ("id")
);

-- CreateTable
CREATE TABLE "transactional"."some_table" (
    "id" TEXT NOT NULL,
    "title" TEXT NOT NULL,
    "authorId" TEXT NOT NULL,

    CONSTRAINT "Post_pkey2" PRIMARY KEY ("id")
);

-- AddForeignKey
ALTER TABLE "transactional"."some_table" ADD CONSTRAINT "Post_authorId_fkey2" FOREIGN KEY ("authorId") REFERENCES "base"."some_table"("id") ON DELETE RESTRICT ON UPDATE CASCADE;

Environment & setup

OS: macOS
Database: PostgreSQL
Node.js version: v16

Prisma Version
Dev setup with engines 4.5.0-35.7ed9e65490b6d360d03e2b531da2db29b6c7b919

The crash is reproduced in a test in https://github.com/prisma/prisma-engines/pull/3297


Allow dragging nodes

Currently, node dragging is disabled.
Allow dragging nodes, and expose a callback to update node latitude/longitude.

Implemented in https://github.com/zakjan/cytoscape-mapbox-gl/commit/e44a66681af2d5aac054ac1acf2e83002825cdfc


How to remove the whole node ?

Hi,
I created a custom plugin for adding a pre-defined text node, such as "select" "username", and  I want to delete the entire "select" when user tapping the delete key, is there a sample for this ?

Hi,
Please tell me the structure of the predefined text node.

Hi,
Please tell me the structure of the predefined text node.

Thanks for reply, the structure of predefined text node just like the math plugin, user can setup some variables by our popup panel, the json structure is like :  {'name': 'sales', 'express':'gte', 'value':100},  then the variable display as plain text in editor such as "sales > 100", and the entire node 'sales > 100' should be deleted when user tapping the delete key in editor.

Please refer to the sceenshot, user can delete chars to the defined plugin [select], but cannot delete the [select] when keep tapping the delete key

@JiHong88 I guess it's a BUG, in the sample (http://suneditor.com/sample/index.html), I can delete the entire math content by keep tapping the delete key in Chrome,  but it's not working on firefox.

Thank you.
I'll release new version when resolved this issue.

The 2.30.5 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


Improved test summary logging on CI

Clean up of logging of test results

Must faster to view the test failures now

Today in web & desktop test failures we have to wait for github actions to load the logs & expand the output, this is basically instantaneous, as opposed to waiting for 15-20 seconds (& even after that the logs displayed are useless)

Colors in the output
Consistent outputs whether its web or desktop (the failures are displayed in a single job)
Generate an ipynb file with a list of failed tests, including the output & screenshots

Old

New (no you can see the failures & the details) in <1s as opposed to 15s

Old
When you look at the logs,  you have no idea what output pertains to what test execution.
Hence when looking at a test failure, you have to:

Scan through the logs & look for the start & end of the test & extract the text file contents
You need to download all screenshots & look for the file

New
Note: I find this very useful, as I always scrape the output by looking for the start and end of the tests (this is why we have traceInfo(Start Test ${this.currentTest?.title}); in the test files, so we can capture the logs that are specific to a test run. This notebook alone will save me a lot of time when looking at the test failures.
These are attached to the job as artificats.

All failures in one ipynb
Each failure is a separate cell with its own output & screenshots

We have colorized outputs, which makes it much easier to find the errors (messages we're looking for in the logs)

Codecov Report

Merging #10680 (bbd2055) into main (5f5a5a0) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #10680   +/-   ##
======================================
  Coverage     70%      70%
======================================
  Files        475      475
  Lines      28214    28214
  Branches    4737     4737
======================================
+ Hits       19992    20009   +17
+ Misses      6342     6328   -14
+ Partials    1880     1877    -3

Impacted Files
Coverage Δ

src/kernels/installer/productInstaller.node.ts
74% <0%> (-5%)
:arrow_down:

...rc/kernels/debugger/debugLocationTrackerFactory.ts
96% <0%> (-4%)
:arrow_down:

...ebooks/controllers/notebookIPyWidgetCoordinator.ts
86% <0%> (-2%)
:arrow_down:

src/kernels/kernelDependencyService.node.ts
85% <0%> (-1%)
:arrow_down:

src/kernels/helpers.ts
63% <0%> (+<1%)
:arrow_up:

.../notebooks/controllers/vscodeNotebookController.ts
81% <0%> (+1%)
:arrow_up:

src/kernels/execution/cellExecution.ts
72% <0%> (+1%)
:arrow_up:

src/kernels/execution/cellExecutionQueue.ts
82% <0%> (+1%)
:arrow_up:

src/kernels/kernelFinder.base.ts
83% <0%> (+3%)
:arrow_up:

src/platform/common/process/baseDaemon.node.ts
54% <0%> (+3%)
:arrow_up:

... and 2 more


Failed to install sqlite3 with error msg "Could not locate a complete toolset."

Windows 10
VS Code
Hi, I'm new to C programming. I'm setting up VS Code as my editor. Seems like I need to install a library that contains header files. So I downloaded vcpkg and trying to install sqlite3. But there is the problem.
C:\Users\ryan\vcpkg>vcpkg install sqlite3
Computing installation plan...
The following packages will be built and installed:
    sqlite3[core]:x86-windows -> 3.33.0
Could not locate a complete toolset.
The following paths were examined:

C:\Users\ryan\vcpkg>

google this for a while, most of them are related to VS language setting. I'm not using or installed VS 2019 or any previous versions.
How can I fix this problem? Thank you.

VS Code does not have its own compiler/linker.
You need to install a compiler/linker such as Visual Studio 2017/2019 (Community Editions are Free), Intel, Cygwin, or Msys2 to name a few.

VS Code does not have its own compiler/linker.
You need to install a compiler/linker such as Visual Studio 2017/2019 (Community Editions are Free), Intel, Cygwin, or Msys2 to name a few.

I try to install Cygwin and SQLlite with it. After adding Cygwin directory to VS Code includePath that's ok to compile c file.
But after I installed Visual Studio 2019 (English language pack), and do integrate remove and install to vcpkg. I can't still install any package with vcpkg.
C:\vcpkg>vcpkg install sqlite3
Computing installation plan...
The following packages will be built and installed:
    sqlite3[core]:x86-windows -> 3.33.0
Could not locate a complete toolset.
The following paths were examined:
    C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat

I do the search for vcvarsall.bat in Microsoft Visual Studio directory and found nothing.
p.s. Under this path C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary, there is no Build folder in it.


Adds justification for using generators

.. to modify a host application.
Closes #38.

How about something about rails generators being standard, proven, robust, and good at providing feedback about what actions they take?

those are all good too! My main motivation here is to make sure that whatever the plugin is doing to the host app, it's easy to track down.

Sorry, I meant to say add.  I think both are valuable.


codegen: Fix incorrect type name when using template class

Fix incorrect type name generation when using templated classes.

Hello!
One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

thanks


evaluate invertible combine

E.g. with SMHasher -> https://github.com/rurban/smhasher

But only after #40


ragged tensor gnnexplainer implementation for xai benchmarks

I added my RaggedTensor capable implementation of GNNExplainer in literature.GNNExplain.GnnExplainer
I also made some changes & fixes to the other XAI code to make sure that the post-hoc explanation methods can also be used in train_visual_graph_dataset.py

I will check if the jupyter notebooks still run.


CVars for dynamic score limit

Marcaek Yesterday at 02:30
new svar suggestions
one for increasing score limit by base value + number of cps
and a variable for said value

Buu342 Yesterday at 02:59
Ah so it automatically increases the max score depending on the number of CPs in a map?

Added the following:
server int   dominatrix_scorelimitpercp     = 0;   	// Increase the max score by this number multiplied by the number of CPs.
server int   dominatrix_scorelimitperplayer = 0;   	// Increase the max score by this number multiplied by the number of players.
server int   dominatrix_timelimitpercp      = 0;   	// Increase the max time by this number multiplied by the number of CPs.
server int   dominatrix_timelimitperplayer  = 0;   	// Increase the max time by this number multiplied by the number of players.


move ocaml backend to proprietary repo

@pdaian please review

@pdaian looks like it successfully picks up the artifact for the OCAML backend from the maven repo where it was built by the rv-match repo. Please review.


mini.pairs: Temporarily cancel / disable auto pairing

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini.pairs
Description
I couldn't find an issue or discussion for this. How do you approach situations where you don't want auto pairing to get in the way, just temporarily? I feel like I'm missing something.

When using mini.pairs, it's kinda frustrating to type --[==[ on a line because I get --[==[]].
Use Case 2:
I realize I'm missing a quote on a word and just want to insert a single quote at the beginning/end.
But each time, the second quote is inserted, and removed when I backspace.
Available Solutions:

Use <C-V> before typing each character
Use DEL key after typing each character
Exit insert mode, and delete extra characters

Suggestion:
Would it make sense to provide a binding that for example disables autopair until leaving insert mode?

If you feel this is outside the scope of mini.pairs, then that's fine; I thought it would be useful to have the topic documented somewhere at least.

Use <C-V> before typing each character

Why is this not an appropriate solution? This is the one I use, as this happens not that often.
Of course, there is also a common way of disabling all 'mini.nvim' modules: via vim.g.minixxx_disable and vim.b.minixxx_disable variables.
You can, for example, make this mapping to toggle autopairing:
vim.keymap.set('i', '<M-m>', '<Cmd>lua vim.g.minipairs_disable = not vim.g.minipairs_disable<CR>')

Choose mode, key, and global/buffer-local variable for you liking.
Does this solve your issue?

I guess part of me was wondering how others deal with this situation. Thanks for your input! This does work, and it should also be pretty trivial to create an autocommand via keymap that then deletes itself.

This is the (lazy.nvim) configuration I'm using now:
  {
    "echasnovski/mini.pairs",
    event = "VeryLazy",
    config = function(_, opts)
      require("mini.pairs").setup(opts)

      vim.api.nvim_set_keymap("i", "<c-v>", "<c-v>", {
        silent = true,
        noremap = true,
        desc = "Temporarily disable auto-pairing",
        callback = function()
          vim.g.minipairs_disable = true
          vim.api.nvim_create_autocmd("InsertLeave", {
            callback = function()
              vim.g.minipairs_disable = false
              return true
            end
          })
        end
      })
    end,
  }

Edit: that is, I'd like to use <c-v>, but I'm not sure how to not mask the original <c-v> whilst doing so.

This is an almost perfect example of expression mappings. Those are first execute right hand side expression which should return an eventually needed value of right hand side. You can use it to first execute some of your code and then return <C-v>. Like this:
vim.keymap.set('i', '<C-v>', function()
  vim.g.minipairs_disable = true
  vim.cmd('au InsertLeave * ++once let g:minipairs_disable = v:false')
  return '<C-v>'
end, { silent = true, expr = true })

Yes, this code does have some Vimscript, but it has less nesting, so is better to me :)


SBT Plugin

I would like to use this like an SBT plugin, similar to: https://github.com/geekity/sbt-embedded-postgres
This would allow for using typesafe-config type of setups and using random local ports/etc as part of the sbt-test

@er1c
Could you please describe better the usage. What kind of functionality would you expected.
How would you like to provision dependencies to system run and check ?
Thanks


Dude, Where's My Taxonomy?

Hello,
I ran my samples through the EukDetect pipeline using the latests bowtie2/taxonomy files and everything went fine - thank you for making it so easy to run.
Anyway, I was looking to reconcile the *_filtered_hits_table.txt with the taxonomies found in marker_genes_per_species.csv and realized that at first glance my files are missing a few Taxid: 5579, 5658, 29901, 229219. Is this expected and/or am I missing something?
Just to give a little more details about this issue, one of my tables has these info:
Name    Taxid   Observed_markers        Read_counts     Percent_observed_markers        Total_marker_coverage   Percent_identity
Blastomyces     229219  4       7       2.7%    9.48%   100.0%
Malassezia globosa CBS 7966     425265  2       4       1.27%   10.34%  97.99%

and when I look for 229219 in marker_genes_per_species.csv nothing is found and where I look for Blastomyces, I actually found these but that Taxid is not present:
$ grep Blastomyces ~/EukDetect/eukdb/marker_genes_per_species.csv
Fungi,Ascomycota,Blastomyces_dermatitidis_ER-3,559297,51
Fungi,Ascomycota,Blastomyces_gilchristii_SLH14081,559298,55
Fungi,Ascomycota,Blastomyces_parvus,2060905,198
Fungi,Ascomycota,Blastomyces_percursus,1658174,200
Fungi,Ascomycota,Blastomyces_silverae,2060906,176
Fungi,Ascomycota,Blastomyces_sp_MA-2018,2164086,186

another example 29901, in one of my tables:
Mrakia  29901   2       4       1.89%   4.28%   100.0%

but not found:
$ grep Mrakia ~/EukDetect/eukdb/marker_genes_per_species.csv
Fungi,Basidiomycota,Mrakia_blollopis,696254,56
Fungi,Basidiomycota,Mrakia_frigida,29902,164
Fungi,Basidiomycota,Mrakia_psychrophila,72568,49

Thank you!

This is expected behavior. The taxonomy ID reported in the output is of the Blastomyces genus.
The NCBI taxonomy is hierarchical, and the species taxIDs are children of genus taxIDs. Since there is conflicting evidence at the species level about which Blastomyces is present, eukdetect does not report a specific species but rather considers there to be enough evidence that there is something in the Blastomyces genus present.
More info is in the methods section of the paper.

Take a look at the output in the {samplename}_filtered_hits_taxonomy.txt files - those provide the markers observed, number of reads observed, and other metrics for every taxonomic level above everything reported in the final filtered output.


remove required package lanms for Windows

Thank you for your contribution to the MindOCR repo.
Before submitting this PR, please make sure:

[✔] You have read the Contributing Guidelines on pull requests
[ ✔] Your code builds clean without any errors or warnings
[ ✔] You are using approved terminology
[✔ ] You have added unit tests

Motivation
when I run
pip install -r requirements.txt

it is failed because of  the package lanms, the package does not support the windows environment very well. So I read the origin paper : https://arxiv.org/pdf/1704.03155v2 ,and write the algorithm in pure Python.

and I also remain the lanms package for systems except Windows, the pure python based lanms only works in Windows.
Test Plan

check the lanms is ignored when pip install in windows

check the eval result is same as origin

check the eval result is same as the official version lanms

the author also provide a python version lanms( but is can not used by using pip install )
https://github.com/argman/EAST/blob/master/locality_aware_nms.py

Related Issues and PRs

本次进行了如下验证
（1） v0.3.2 分支进行了静态图验证
（2）master 分支用 MindSpore 2.2.14 进行了动态图验证（因为 eval 脚本里面存在 2.3 版本的特性，而当前 MindSpore 版本 MindSpore 不支持 CPU，无法验证）


Clean up Dashboard > System and Settings > Attributes section

There are a number of pages within this section of the Dashboard System and Settings. Let's ensure they're using the right styles for buttons and that they all look good in the v9 interface.
That means things like

Making sure any tabs included in the page actually work (the bootstrap 4 tab required markup is new.)
Making sure we use btn-secondary instead of btn-default.
Making sure we use float-left and float-right instead of the old pull classes.
Other legacy bootstrap 3 -> 4 conversion updates.
Make sure that we use the proper form classes for all inputs so that they look good, don't overhang the left hand side, align properly, etc...

Hi @aembler,
Here is the PR : https://github.com/concrete5/concrete5/pull/8627
:)

Looks like this was already done.


Add separate python.testing.pytestArgs settings for regular, debug and discovery runs

Evolved from #21190.
Related to #693, #19809, #19985 and some others.
Some of the pytest plugins may change how it works (e.g. running in parallel via pytest-xdist) or do some actions that are required on regular test runs but are unwanted on debug or discovery runs (e.g. generating a coverage report via pytest-cov). Currently vscode provides a single setting for configuring the args, and they are used for all the kinds of runs. Sometimes such behavior is inconvenient. Separating the single setting into 3 (for regular runs, for debug runs and for discovery runs) would make configuring pytest much more flexible.
Something like
"python.testing.pytestArgs": {
    "run": [], // equal to the current "python.testing.pytestArgs": []
    "debug": [],
    "discovery": []
}

or
"python.testing.pytestRunArgs": [],
"python.testing.pytestDebugArgs": [],
"python.testing.pytestDiscoveryArgs": []

Also related to  #18778. Here is that whole comment from there:
I would like to use additional pytest options when running tests, but not when discovering tests.
Scenario

I want to generate coverage data on every test run, so I have this in my settings.json:

    "python.testing.pytestArgs": [
        "src/unittests",
        "--cov=.",
        "--cov-report=xml:coverage.xml",
        "-vvv"
    ],

But I don't want to generate coverage when debugging a test, so I disable it in my launch.json:

        {
            "name": "Debug Tests",
            "type": "python",
            "request": "test",
            "console": "integratedTerminal",
            "env": {"PYTEST_ADDOPTS": "--no-cov"},
            "justMyCode": false
        }

I also don't want coverage data when tests are discovered because discovery is way faster without these options. This seems to be impossible at the moment.

What I need
I think I need either a possibility to inject the --no-cov option somewhere around https://github.com/microsoft/vscode-python/blob/e2bf90c991075aefcc15b16642a5122ceab84152/pythonFiles/testing_tools/adapter/pytest/_discovery.py#L65 or I need a possibility to just add the coverage options for non-debug test runs only.

Thank you to everyone who upvoted this issue! Since the community showed interest in this feature request we will leave this issue open as something to consider implementing at some point in the future.
We do encourage people to continue 👍 the first/opening comment as it helps us prioritize our work based on what the community seems to want the most.

I created a proposal with a solution for this problem, would love your input on the above issue! https://github.com/microsoft/vscode-python/issues/21845

closing as the proposal will guide the solution creation to your PR


[Announce] added a new feature "grammar search on the 1st pass"

A pull request has been merged that adds a new feature "grammar search on the 1st pass".  To use it, get the latest code on master branch.
It enables applying full grammar on the 1-pass, thus outputs more reliable (grammar-constrained) result at the 1st pass.
Background
The grammar-based recognition on Julius does not apply the full grammar on the 1st pass, but applies only the word-pair constraint extracted from the grammar for efficiency.  The errors on the 1st pass caused by the loose constraint will be recovered on the final pass, so the approximation basically does not impact on the final result.
However, there are cases in which the 1st pass result should be more precise, typically on a real-time application that aims to utilize the partial recognition output before audio input ends)
Effect
This update enables applying full grammar on the 1st pass.  When enabled, the generated word hypotheses on the 1st pass will be examined by the grammar parser at every frame and only the words that is allowed to connect on the context will be expanded.
This feature is enabled when a recognition grammar (a set of .dfa and .dict files) has an additional dfa file (.dfa.forward).  This also works on multiple grammar recognition.
No harm on old grammars, almost no impact on the recognition speed.
Usage

Re-run the updated grammar converter mkdfa.pl (or mkdfa.py) of the latest commit to your recognition grammar.  The output (.dfa, .dict) will be the same as the previous versions, but now it generates an extra file (*.dfa.forward).
Run Julius with the generated grammar.   It additionally reads .dfa.forward file if it exists, and enable the new feature.  The (progressive) result always conforms the given grammar from the head.

Restriction
You can not yet give the .dfa.forward file when throwing a grammar via module mode.  It is not implemented now.

There was some serious bug which causes segfaults with grammars without .dfa.forward file.
There was also a bug in that mkdfa.pl outputs wrong .dfa.forward when .grammar file does not end with newline.
These bugs are fixed in the recent commit (7e0cb3f1b62cf02ecdb11948034e80e426e635f9 and 4d2415b66d852849d9bf94cba4fc26130085b170).  Please use the latest version!


How to load initial weight after using TimeDistributed()?

I can load initial weight for the 'conv1' layer using hdf5 file by layer name as follow:
x = KL.Conv2D(64, (7, 7), strides=(2, 2), name='conv1', use_bias=True)(x)
####layers.name = 'conv1'#####
topology.load_weights_from_hdf5_group_by_name(h5py_file, layers)
When I using TimeDistributed() like this:
x = TimeDistributed(KL.Conv2D(64, (7, 7), strides=(2, 2), name='conv1', use_bias=True))(x)
The layer's name is no longer 'conv1', but 'time_distributed_1'. Since the weights are shared using TimeDistributed(), how to load the same initial weights for the 'time_distributed_1' layer using same hdf5 file?
My tensorflow and keras versions:
tensorflow == 1.3.0
keras == 2.0.8

@491734045  Could you try with a higher version of Tensorflow.

@491734045 As this is not a bug, this is a question better asked on Stack Overflow


Add rewrite-clj.zip of-string* and of-file*

These new zip API functions are the same as their of-string and of-file counterparts except that they do no auto navigation at all.
Closes #189

@mainj I think this matches what you had in mind, let me know if you agree.

This looks great @lread, especially the docs! Feel free to close that issue.

Thanks for taking a peek @mainej!


Update PhpStorm to 2016.2

Changes to a cask
Editing an existing cask

[x] Commit message includes cask’s name (and new version, if applicable).
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.

The cask has been on this version since may. You are way outdated. Run brew update.

The newest version of cask is 2016.1.2. But The PhpStorm just release 2016.2 on July 13, 2016.

Oh, right, missed that.
Still, it seems like you did not run the commands in the boxes you ticked, since sha256 was not ticked. Please submit again.

Done in https://github.com/caskroom/homebrew-cask/pull/22819.

Thanks for your help.


v1.1.0 breaks browserify API

I'm listening for package events in browserify and I'm using pkg.__dirname as documented.
With the latest release of this package, the __dirname points to all sorts of things. Sometimes the parent directory of the entry point, sometimes a .js file and in other cases it's correct.
Downgrading this module in my node_modules tree make it work fine again.

Appears to have broken in https://github.com/substack/node-resolve/commit/caff2ba60dc5d85eaded388dc6025afd05ba183b
the packageFilter is now getting triggered when loading as a file, previously this would only trigger for loading directories. the module-deps package gets confused by all the extra callbacks triggered, and will emit an incorrect pkg.__dirname in its 'package' event. I will shrinkwrap these updates out, but would like to add that even though I agree the many-small-modules-doing-one-thing-well architecture is the right way to go - this kind of highlights the need for a layer of integration testing of common composition of these modules (ie. browserify's makeup).

any thoughts on this one? or does this need to be fixed further upstream?

I'm working on some patches to resolve and module-deps that should address these issues.

I've fixed this bug and added some test cases to the suite for package events. Now I'm just waiting for https://github.com/defunctzombie/node-browser-resolve/issues/56

Yes, I can confirm that it's working fine again, also with browserify 8.1.3.
Thanks!


add partition Error 1564 (HY000): This partition function is not allowed

Your Question

The document you expected this should be explained

Expected answer

version：gorm.io/gorm v1.25.12
sql：alter table instance  ADD PARTITION (PARTITION yyy VALUES IN ('yyy') ENGINE = InnoDB);
comment：this sql can execute on dbeaver，but cannot be execute by gorm

the error was happened on the db side.


When the inverted index could be build on any table type ?

When i add inverted index on primary table, It report error:
Detail message: The inverted index can only be build on DUPLICATE table
I am so confused why The inverted index can only be build on DUPLICATE table. And if community have plan to support this request?

there's no promised timeline for this feature.


Vertical position of graph in new fitness trend is not static

In 6.0.2 stable, if you have a day with multiple activities or activities with a long title, the vertical position of the graph is pushed down when mousing over a day. This is because the list of activities in the top right wraps causing it to use a variable number of lines.
This means that when you move the mouse over the graph it jumps around a lot and is very jarring. I'd suggest you either truncate the list of activities or show them elsewhere. Perhaps below the graph or in the new mouse over pop up thingy.
Hopefully this is clear, if not let me know and I'll take some screenshots.

@stupid-beard I see what's going wrong. i limite the displayed activities to 2. I will truncate full text with ellipsis


Add authentication for rate and geo services for SREBench fault injections.

@menidd I believe I've addressed all of your comments with my latest commits. Let me know if you have anymore suggestions and thank you for all your help so far.

@menidd I just pushed in some changes that address your comments. I am currently having an issue with the tlsCertificates after pulling:
TASK [sample_applications : Deploy Deathstar Hotel Reservations] ************************************************************************************************************** fatal: [localhost]: FAILED! => {"changed": false, "command": "/usr/local/bin/helm upgrade -i --reset-values --create-namespace --set global.monitoring.otelAddress=otel-collector-hotel-reservations.hotel-reservations.svc.cluster.local --set global.monitoring.defaultJaegerEnabled=false --set global.monitoring.centralJaegerAddress=jaeger-collector.jaeger.svc.cluster.local --set global.monitoring.centralPrometheusAddress=http://prometheus-stack-kube-prom-prometheus.prometheus:9090/api/v1/otlp --set global.nameOverride=hotel-reservations hotel-reservations 'roles/sample_applications/DeathStarBench/hotelReservation/helm-chart/hotelreservation'", "msg": "Failure when executing Helm command. Exited 1.\nstdout: Release \"hotel-reservations\" does not exist. Installing it now.\n\nstderr: Error: template: hotel-reservation/charts/wrk2/templates/deployment.yaml:1:3: executing \"hotel-reservation/charts/wrk2/templates/deployment.yaml\" at <include \"hotelreservation.templates.wrk2-deployment\" .>: error calling include: template: hotel-reservation/templates/wrk2_deployment.tpl:3:7: executing \"hotelreservation.templates.wrk2-deployment\" at <eq $.Values.global.services.environments.TLS 1>: error calling eq: incompatible types for comparison\n", "stderr": "Error: template: hotel-reservation/charts/wrk2/templates/deployment.yaml:1:3: executing \"hotel-reservation/charts/wrk2/templates/deployment.yaml\" at <include \"hotelreservation.templates.wrk2-deployment\" .>: error calling include: template: hotel-reservation/templates/wrk2_deployment.tpl:3:7: executing \"hotelreservation.templates.wrk2-deployment\" at <eq $.Values.global.services.environments.TLS 1>: error calling eq: incompatible types for comparison\n", "stderr_lines": ["Error: template: hotel-reservation/charts/wrk2/templates/deployment.yaml:1:3: executing \"hotel-reservation/charts/wrk2/templates/deployment.yaml\" at <include \"hotelreservation.templates.wrk2-deployment\" .>: error calling include: template: hotel-reservation/templates/wrk2_deployment.tpl:3:7: executing \"hotelreservation.templates.wrk2-deployment\" at <eq $.Values.global.services.environments.TLS 1>: error calling eq: incompatible types for comparison"], "stdout": "Release \"hotel-reservations\" does not exist. Installing it now.\n", "stdout_lines": ["Release \"hotel-reservations\" does not exist. Installing it now."]}
I was wondering if you had any ideas why that might be happening. All the code I pushed I did test successfully, but the current state of the branch isn't working for me after pulling.


Time undefined on #horarie

Uncaught TypeError: Cannot read property 'time' of undefined
at Status.toString (status.js:9)
at status (heol.js:191)
at interpretList (lisp.js:48)
at interpret (lisp.js:55)
at interpret (lisp.js:53)
at Heol.Lisp.toString (lisp.js:103)
at Object.heol [as fn] (runic.js:73)
at stash.a.reduce (runic.js:38)
at Array.reduce ()
at _html (runic.js:36)

on
https://wiki.xxiivv.com/#horarie
Chrome 71, macOS 10.14.2

Are you still getting this issue?

(Welcome back to the internets!)
Negative. No error now.

If I time travel to when I reported the bug, there is no bug, but I also tried time traveling to before your website existed and a similar (if not the same) bug appears

that is super bizarre. It seems like the 9th of feb 2003 is not a valid time?!

I will keep this open until I figure it out :)

Fixed now :)


Improve tmp directory use and cleanup

tmp directories are used for yarn and npm lockfile generation.
Proposal 1: Reuse the same tmp dir per-repository to maximise node_modules reuse and speed

If npm/yarn caches are in use, does this make much improvement?
Could this result in any additional failure cases? (remembering we don't actually care what's in the node_modules, it's an unfortunate byproduct of getting the lock files)

Proposal 2: Clean up tmp dirs after each repository

For the case where renovate runs on a lot of repositories/package files, it's important that we don't keep accruing disk space until it's finished
I'm assuming that tmp is only removing these temporary directories after the full renovate run has finished

https://github.com/singapore/renovate/pull/140

I'm assuming that tmp is only removing these temporary directories after the full renovate run has finished

That is correct. If I remember correctly tmp hooks into process.on('exit', ()=>{}).

do you think this default could be returned, as long as we have a configuration to disable tmp cleanup?

I probably wouldn't bother with adding an extra configuration option for disabling the manual calls to the cleanup function. As you noted, Windows is a minor use case (and only relevant to me because we use Windows for development where I work).
Long term it would be more beneficial to track down the issue that causes the cleanup function to throw an exception on Windows. Unless anyone else uses Windows with renovate, that work should probably fall on me, or one of my co-workers.


[HUDI-3103] Enable MultiTableDeltaStreamer to update a single target table from multiple source tables.

What is the purpose of the pull request
The purpose of pull request is to update a single target table from multiple source tables.
Brief change log

Modify the HoodieMultiTableDeltaStreamer file so that it can generate the execution context of table based on source tables.
Modify the DeltaSync.java file so that the source table can associate with other tables and the source can configure independent checkpoint.
add UT

@nsivabalan

@nsivabalan
Thank you for the advice.
However, the resumeCheckpointStr calculation method in DeltaSync applies only to updating a single target table by a single source. If multiple sources update a single target table, this calculation method does not work. If multiple sources update a single target, set an independent checkpoint for each source so that each source can recover from any checkpoint. I only changed the methods for calculating resumeCheckpointStr and saving checkpoints to checkpointCommitMetadata in DeltaSync. Specifically, I added these methods. This does not affect the calculation logic when a single source updates a single target.

oh I see. my bad, I did not look closely. sorry about that. We can keep it open. give me a day or two. I will take a detailed look and leave comments.

oh I see. my bad, I did not look closely. sorry about that. We can keep it open. give me a day or two. I will take a detailed look and leave comments.
OK, thank you very much. You can see my new pull request. I want to close the current pull request.
https://github.com/apache/hudi/pull/4645

oh I see. my bad, I did not look closely. sorry about that. We can keep it open. give me a day or two. I will take a detailed look and leave comments.
@nsivabalan
OK, thank you very much. You can see my new pull request. I want to close the current pull request.
#4645


Navigation between iOS compose view controllers triggers LaunchedEffect and DisposableEffect when it should not

Describe the bug
After implementing a very basic and rudimentary navigation between screens that calls under the hood startActivity on Android and pushViewController on iOS, I started to notice unexpected behaviour, which might be related to #3889. On Android LaunchedEffect and DisposableEffect execute once per activity lifetime, but on iOS they would be called every time the UIViewController left the screen, even if the navigation was deeper into further view controllers, not back.
Affected platforms
Select one of the platforms below:

iOS

Versions

Kotlin version: 1.9.20
Compose Multiplatform version: 1.5.10
OS architecture (x86 or arm64):  arm64

To Reproduce
The pull request at this fork of the ios compose template contains the whole code. A ProxyNavigator interface is created and passed on to the compose screens, so that interaction in those screens can call back code implemented by the native platform:
interface ProxyNavigator {
    fun openNext()
}

The implementation of this interface on Android is fairly trivial:
class MainActivity : AppCompatActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        val navigator = object : ProxyNavigator {
            override fun openNext() {
                open()
            }
        }

        setContent {
            MainView(navigator)
        }
    }

    private fun open() {
        startActivity(Intent(this, FirstActivity::class.java))
    }
}

On iOS it is slightly more awkward, it adds a view controller weak variable to capture the result of calling ComposeUIViewController:
class MainNavigator: ProxyNavigator {
    weak var vc: UIViewController?

    func openNext() {
        let firstNavigator = FirstNavigator()
        let result = Main_iosKt.FirstViewController(proxyNavigator: firstNavigator)
        firstNavigator.vc = result
        vc?.navigationController?.pushViewController(result, animated: true)
    }
}

In both platforms the example app starts with basic root view, which then will open the first screen, and this in turn will add the second screen.
fun FirstScreen(proxyNavigator: ProxyNavigator) {
    MaterialTheme {
        Column(
            Modifier.fillMaxSize(),
            horizontalAlignment = Alignment.CenterHorizontally,
            verticalArrangement = Arrangement.Center,
        ) {
            Button(onClick = { proxyNavigator.openNext() }) {
                Text("Open second screen")
            }

            LaunchedEffect(Unit) {
                println("Launching First screen effect")
            }

            DisposableEffect(Unit) {
                println("Entry point of First screen disposable effect")
                onDispose { println("Disposing First Screeen!!!!! Bye bye!!!") }
            }
        }
    }
}

As can be seen, the compose button will call proxyNavigator.openNext(), which under the hood will either start another activity on android or push a new view controller on iOS. The second screen is just a dummy to highlight the effect.
When running the android app, the root screen opens the first screen, and the LaunchedEffect triggers once. The entry point of the DisposableEffect also triggers once. Now you can open the second screen and go back to the first as many times as you want, and no other side effects will trigger. Only when going back from the first screen to the root one will the onDispose trigger happen.
On the other hand, on iOS if you navigate from root -> First -> second, when entering second screen you will see that the dispose effects are triggered through logs. Going back and forth between the first and second screens will trigger all the launch and disposable side effects.
Expected behavior
On iOS the launch side effect should trigger once when entering the screen, but it triggers when you navigate back from the second to the first view controllers. Same thing with the disposable side effects, they should happen once, but they happen every time the user leaves the screen from the first to the second and back.
Additional context
I haven't tested this on SwiftUI, but I'm trying to integrate compose views into an old iOS architecture that uses UIViewController. The need for the Proxy navigation hack is really ugly because there's no way to access the opaque UIViewController created by compose multiplatform. This is making navigation quite messy with all the circular references and extra attributes.
Even ComposeUIViewControllerConfiguration could alleviate these hacks if the interface implemented passing as first parameter the view controller:
interface WishComposeUIViewControllerDelegate {
    fun viewDidLoad(vc: UIViewController) = Unit
    fun viewWillAppear(vc: UIViewController, animated: Boolean) = Unit
    fun viewDidAppear(vc: UIViewController, animated: Boolean) = Unit
    fun viewWillDisappear(vc: UIViewController, animated: Boolean) = Unit
    fun viewDidDisappear(vc: UIViewController, animated: Boolean) = Unit
}

With this kind of interface I would not need to store the UIViewController in extra variables, or rather could capture it inside viewDidLoad to later use it for navigation.

Hi @gradha ! Thank you for reporting the problem.
The lifecycle in Compose for iOS is indeed different from that on Android. We see that it causes different issues and we plan to approach this problem relatively soon. Unfortunately, there is no workaround for now, afaik.
We'll post an update here as soon as we have any news.

Hi! We also are facing this issue. For now we found a workaround that seems to work. We have yet to find any side effects.
By following the steps to use a UIKit/SwiftUI View/ViewControllers within compose we sidestep leaving the context.
This is not an ideal solution and a fix would be greatly appreciated. But this might allow others to continue working while they wait.
Link to docs on how to achieve this:
https://www.jetbrains.com/help/kotlin-multiplatform-dev/compose-ios-ui-integration.html#use-uikit-inside-compose-multiplatform
❤

Any updates regarding this issue ?
It's quite a critical bug, for example, it prevents using a Camera through the KMP implementation - which is a crucial part of features for some applications

the easiest way to reproduce is using UITabBarController:
final class RootTabBarController: UITabBarController {
    override func loadView() {
        super.loadView()
            let composePage = PagesKt.settingsPage()
            let nativePage = UIViewController()
            viewControllers = [composePage, nativePage]
    }
}

not only DisposableEffect is triggered, but also all remember states are lost. the whole page is reset to initial.

any update?

This should have been fixed in https://github.com/JetBrains/compose-multiplatform-core/commit/3083693a90f550c86ff84153bea0ab77892635c2.
Happened due to wrong reassigning of content that triggered global recomposition.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


In pdf reader, some pdf files are not displayed properly, whereas they look fine in the Firefox pdf reader

@serverfire See for example testcg in developer/app1. There is a black area instead of text. Could this be because we are not using the latest pdf.js version?

@libreliodev Yes it is.
I'm porting the project for pdf.js new version.
Hopefully there is not to much changes in new pdf.js API.

@serverfire OK, let's cross fingers

@libreliodev Strange, testcg is no longer exist in developer/app1?

@libreliodev Hi.
This comment is not related to this issue.
Issues between 189 and 200 are implemented.
You can test them now.
Publications/Issues section may have problems, I tried to make it bug free, But nothing is perfect.
Please use bower install before running grunt.
Thank you

Successfully tested.


Update Suggestion: INDIANAPOLIS LINK IS INCORRECT

Please change the Indianapolis link from the Telegram group of a Chicago meetup to the website "indybtc.com":
The link for the Indianapolis meetup under "Indianapolis" is a telegram group for one of the Chicago meetups. The Indy Meetup group has a website at indybtc.com. We appreciate the change made thank you!

Fixed
Apologies


Please, see the attached screenshot

There is no more screen transition. It is the same even when uploaded to other servers. Please fix it.

Hi,
please provide the full log if you want us to understand what is wrong with your setup.


Can you please provide the data set storage format and its path format? Also, how is ASCs calculated in detail?Thanks!

@FindOne1 Please kindly find the updated readme where the data link is provided. Thanks!

Hello! Thank you very much for providing the data link.
Would it be possible to have more details about the data structure? I am particularly interested in understanding what data['x_y_L_PhiH'] returns. I guess these are the ASCM parameters, but I'm struggling understanding each one is what.
Moreover, I am also interested in having the ASCs calculation in detail.
Thank you!

Hello! Thank you very much for providing the data link. Would it be possible to have more details about the data structure? I am particularly interested in understanding what data['x_y_L_PhiH'] returns. I guess these are the ASCM parameters, but I'm struggling understanding each one is what. Moreover, I am also interested in having the ASCs calculation in detail. Thank you!

x,y is the position, L is the length,  @helosana

Hello! Thank you very much for providing the data link. Would it be possible to have more details about the data structure? I am particularly interested in understanding what data['x_y_L_PhiH'] returns. I guess these are the ASCM parameters, but I'm struggling understanding each one is what. Moreover, I am also interested in having the ASCs calculation in detail. Thank you!

@helosana You can find the details in our published paper. We applied the OMP algorithm to obtain the parameters.


HLSL buffer size limits and synaptic data > 2gb

It is unclear what the actual size limits are for storage buffers in vulkan / HLSL.  This looks like the most relevant page: https://community.khronos.org/t/allocating-a-buffer-of-more-than-2gb/107460/21
Probably we can use a fixed size struct and index into that.. will experiment..
It is clear that in HLSL, the index into the buffer is limited to being a uint, so we need to index into something larger than the raw float32's.  I got uint64_t compiling by using dxc instead of glslc -- we should have been using this all along -- major side-benefit to this excursion, but it issued a warning about down-conversion when accessing the buffer.

Looks like the struct solution is working..  not sure all the bytes are actually making it up from CPU to GPU but nothing indicates that they are not -- no GPU error messages.
The MinusPhase and PlusPhase kernels are strangely slow with increasing NData so there is something strange there -- otherwise Cycle is scaling really nicely, going from 14 -> 44 secs for NData = 16, so that is essentially a 5x speedup overall -- probably better to combine with mpi at some point but anyway looking good for overall GPU scaling.

yep get a 4x speedup for NData = 8 -- a sweeter spot..


[5476] Improve bulk QTS recommend performance

Context
https://trello.com/c/cP6Ojw7t/5476-when-bulk-recommending-308-trainees-it-took-a-long-time-performance-test-bulk-recommendation
Changes proposed in this pull request

Speed up the processing time for the action BulkUpdate::RecommendationsUploadsController#update
New class BulkUpdate::RecommendationsUploads::TraineeLookup which uses hash maps built on-demand supporting trainee lookup by TRN, HESA ID or Trainee ID
Change Reports::TraineeReport so it only loads degree and course on demand (prevents hundreds of unnecessary DB calls during the creation of each row)

The processing time has gone from on average 30 seconds to 10-12 seconds.
Guidance to review

Go through the bulk recommend process locally using prod data to get an realistic idea of performance
Run the test on main branch and then switch to this PR branch to compare times

Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 When bulk recommending 308 trainees, it took a long time. Performance test bulk recommendation.

Just reviewed this in Prod Data. It was MUCH faster, but when I go back to the 'bulk recommend' page after recommending 331 trainees... It still shows those same 331 trainees available to be bulk recommended. The records also show as 'TRN Received'. Not sure how long its meant to take, but I would've expected at least some to have gone through from the background job already.

@jhenderson can you confirm this is not related to this PR?

LGTM but wonder if it's worth testing this with some real data before merging?

@claire-hughez Has already tested it in productiondata but the audit records cannot be verified as we don't run jobs in that environment. I tested it locally and could confirm that the audit records were created in the background.

@jhenderson please can we fix that before merging then?


Pages empty or 404s

All the pages on http://esri.github.io/calcite-bootstrap/ are either empty or 404s.

All the pages on http://esri.github.io/calcite-bootstrap/ are either empty or 404s.

At the moment the issue that is mentioned above is still present. What is the status of this project? What is the roadmap? We first have seen Boostrap-map, then calcite-maps and now calcite-bootstrap.
It looks like also this project has been halted (check the frequency before the last release (version 0.3.3)).
The strange thing is, calcite theme is as beta integrated in version 3.16 of the ArcGIS for JavaScript API. In the "What's new" of version 3.17 nothing is mentioned about calcite theme. So for my view, the only handhold that calcite is not halted is the integration from 3.16 of the JavaScript API

Apologies, the Components content does not exist. That said, the Open Data team, (main consumers of calcite-bootstrap) rely on the Bootstrap documentation (http://getbootstrap.com/) as calcite-bootstrap is simply a "Calcite" theme applied to bootstrap itself.
We are also planning to re-work this entire project so it's a "bootstrap theme" vs a custom build of bootstrap... timeframe TBD, but definitely in 2017


Responsiveness Problem in Food_Ordering_Website

Title and Issue number

Title :Responsiveness Problem in Food_Ordering_Website
Issue No. :#203
Code Stack :  html, css, Javascript
Close #203

Video (mandatory)

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[ ] I have updated the projectData.json file for my contribution
[ ] I have added the img of my project in the assets/img section

Additional context (Mandatory )
I am putting up some references related to what Changes I made

Are you contributing under any Open-source programme?

KWOC 2023

@bibhabasuiitkgp  great! Thanks for contributing!


auditwheel: 4.0.0 -> 5.1.2

Description of changes
https://github.com/pypa/auditwheel/releases

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 175173 run on x86_64-linux 1

1 package built:

auditwheel


Discuss use of OpenSSF Best Practices badge in lifecycle stage requirements.

Please share any additional details on this topic
As proposed by Jonathan Stone on the #tac channel in the ASWF Slack.... ( https://academysoftwarefdn.slack.com/archives/CKB8RR3FT/p1695761680176419 )

Hello all!
John Mertic and I have been discussing the pros and cons of requiring Silver and Gold OpenSSF badges for ASWF project graduation, and this seems like a topic that is interesting enough to open up for broader discussion.
Based on our conversation so far, here are some of the reasons that we might consider changing our lifecycle rules, maintaining Silver and Gold badges as aspirational goals for all ASWF projects, but not using them as blockers for project graduation:
No ASWF project has ever achieved either a Silver or Gold badge, including the foundational computer graphics projects that launched with the ASWF itself.
Our most recent graduating projects were approved unanimously without achieving either a Silver or Gold badge.
Outside of the ASWF, none of the foundational OSS projects in computer graphics (e.g. PBRT, Mitsuba, Embree, OpenUSD, Filament) has ever achieved either a Silver or Gold badge, and there's no evidence that they're currently pursuing them. One potential reason for this is the disconnect between the focus of the Silver and Gold badges (security guarantees, statement and branch coverage), and the emphasis of computer graphics projects on visual parity and visual regression testing.
We'd be very interested in additional thoughts from this group, and this could be a good discussion topic for a future TAC meeting.

Detail what actions or feedback you would like from the TAC
Discussion on how to proceed
How much time do you need for this topic?
At least 30 minutes

Analysis of OpenEXR and OSL where they haven't completed requirements.
https://docs.google.com/spreadsheets/d/1bEacUNFizeT8QtfsvqiRNNgvty8_tweHjassHko6OhQ/edit?usp=sharing

Two takeaways from the TAC Meeting:

Adjust the requirements to reflect progress towards badges, and then put in the following annual review that they should be completed. See proposal in #556.
More tactical guidance on how to complete the requirements. ( PR to be added ).

Thank you all for the great discussion!

Discussion from 12/13 TAC Meeting:

Plan is to determine which Silver/Gold requirements are unclear or problematic, and remove them from the TAC requirements for the Adopted Stage until the requirement is made clear and the concerns addressed.
For the 1/10 TAC Meeting, we will review those identified to be potentially problematic for the TAC to consider and approve.
After that, work in the CI WG to determine the specific concerns with the problematic requirements, and then work to (a) get clarity and upstream that into the Best Practices Badge project and/or (b) provide ASWF-specific guidance to complete.

Hi everyone!
Follow up as a prep for Wednesday's meeting:

I've analyzed the badge completion per project, using scoring to determine the most problematic requirements. See this at https://docs.google.com/spreadsheets/d/1bEacUNFizeT8QtfsvqiRNNgvty8_tweHjassHko6OhQ/edit#gid=67150143. Note this data is pulled via the REST API of the BadgeApp, so projects if you want to update your badges those changes should reflect in semi-realtime.
I've dumped the complete badge requirements for all levels with details in a doc at https://docs.google.com/document/d/1IgE_Jaeb0Yar_Dc_iCw5FUo_AFJZiIVdDBTxhY-9Vvs/edit?usp=sharing. Please review and add comments on sections that are unclear or problematic.

Thank you all, and I look forward to discussing this more on Wednesday!

Ask for @bcipriano, @carolalynn22, @kmuseth, @reinecke, @fpsunflower, and @jstone-lucasfilm - please review the Silver and Gold badge requirements for your projects. I've added direct links to the badgeapp for each of your projects in the headers for the Google Sheet

Somewhat related, but there is work to bring the badge management more into project workflows and not entirely within a disconnected app.
https://github.com/coreinfrastructure/best-practices-badge/issues/2094

Closing this as we will align on closing out with the language in #556


[v2] One UI for all

[] bug
[x] enhancement
[x] feature-discussion (RFC)

Hello,
I think it would be good idea that framework7 can be used as web UI like bootstrap or zurb f6.
Just we need some option to disable touch features and minify css and js files after that we can use it anywhere.

The idea is not bad,
But I think that the focus is for mobile.

F7 already works very well in standard websites on desktop browsers, was there any extra functionality you'd like to see?

Quasar is good but it is not easy to use while f7 is easy to use.
@zanderbrown  Yes. f7 work on browser but not optimized.

Could we have info about 'Quasar' and expand on your 'not optimized' comment?

Please check F7 in desktop mode.

for web app use f7 for application navigation and bootstrap for web control and design!

yes, bootstrap has good components.
bootstrap + f7 nav will become the best

Please check F7 in desktop mode.

Explain

Closing as not really an issue, and F7 has material design which is the widely used now for desktop apps/websites

True, but i think we should work on table components to have strong one like bootstrap table (search, sort, pages ..etc)


Add pt-br language

Since the number of brazilian players are increasing, this translation can help those who don't know any language that HSTracker supports.

Thanks @gabrieloliva !


[duilib] Enable unicode define

if use vcpkg to build duilib, can not use unicode define in CMakeLists.txt where in source code root dir, so add it to DuiLib/CMakeLists.txt

should i have to modify other files?

Except for the port-version, others are good for me now.

@w703710691d do you have a reasoning for this? I don't understand why duilib needs to be modified for vcpkg. Do the people behind duilib agree with this change? (@wangchyz?)

@w703710691d do you have a reasoning for this? I don't understand why duilib needs to be modified for vcpkg. Do the people behind duilib agree with this change? (@wangchyz?)

In duilib source, the root CMakeLists.txt has lines "add_definitions(-DUNICODE -D_UNICODE)" and "add_subdirectory(duilib)"。so the final library file use unicode function defines。But vcpkg only use "duilib"  subdirectory,  dosen't include unicode define。So the library file is different from the origin library file

@w703710691d do you have a reasoning for this? I don't understand why duilib needs to be modified for vcpkg. Do the people behind duilib agree with this change? (@wangchyz?)

In duilib source, the root CMakeLists.txt has lines "add_definitions(-DUNICODE -D_UNICODE)" and "add_subdirectory(duilib)"。so the final library file use unicode function defines。But vcpkg only use "duilib" subdirectory, dosen't include unicode define。So the library file is different from the origin library file


[BUG] ibmcloud iam account-settings-update --allowed-ip-addresses - No method to successfully disable/remove all IPs

Run  for example ibmcloud iam account-settings-update --allowed-ip-addresses <IP_ADDRESS>,<IP_ADDRESS>  and these ips replace the ones in the IP address access list and enable this setting.
However there is no way to reverse this. The docs and help say (default is "") but this does not work.
ibmcloud iam account-settings-update --allowed-ip-addresses ""  just give the result OK but does not change the setting, and the ip list is still enforced/enabled

While this is researched, you should be able to update this in the IBM Cloud console. Apologies for the inconvenience.

In release 2.28.0, there is a new option account-settings-update --unset-allowed-ip-addresses that should satisfy this need. Please reopen this issue as needed. Thank you


Discuss Next Steps DB Viz

Examples:
fcc
broadband
foreign assistance
Government Finances
Data Wrapper Maps
User Interaction

Should the US map be an interface tool that allows users to select sub-geographies to get additional information?
What stock choropleth style maps should be available as images with associated data?

Future Needs

Time Series Comparison (at least 2 year comparison, best if trend over n years)
Baseline comparison
Expansion of aggregate choice, selection UI
Visualization of delta between two time periods on a given metric

Normalization
Users should have the option to switch between visualization of actual aggregates (counts, sums) and the normalization of the aggregate by an appropriate baseline, such as area population.

normalize by population first
normalize by number of units as a next step (as appropriate)
other normalizing (such as percent of originations to demographic sub-groups)

Aggregate Extension
Available aggregates will be iteratively expanded to provide more information. This will include normalization of the new aggregates.
Aggregates for Geography Levels

Average VS Median table for geography: Loan Amount, Income, Age, Housing Stock Age
Loan Type: normalization by area population
Loan Type By Action Taken: normalization by area population
Loan Type by Derived Race:  normalization by area population
Loan Type by Derived Ethnicity: normalization by area population
Loan Type by Action Taken and Derived Race: normalization by area population
Loan Type by Action Taken and Derived Ethnicity: normalization by area population
Loan Amount, binned by 50K
Borrower Age, binned as per privacy modifications
Loan Purpose
Borrower Income binned at 50k and as a % of MSA/MD income as bucketed in this note
Note: The text on how normalization is done is very important in conveying the proper information to users.

Visualization Types

Histograms: Borrower age bins, income bins (at 50k), loan amount bins (at 50k),
Tables: Loan Purpose, Loan Type, Derived Race, Derived Ethnicity, Area demographics, open-end vs closed-end
Choropleth Maps of aggregates: averages and medians, normalized aggregates (to show activity relative to population)

Next Steps Ideas

More Maps with specific aggregates
Include toggle to switch between raw counts and normalization of aggregate
Aggregate CSV download
Map aggregates on choropleth. What selection or mouse over options should we enable?
Graphs for aggregates: how is it best to display these? What UI selection options make sense (list box? how many aggregates should we offer at one time?)?
Geographic comparison: IE county to county, county to state, county to national

NA and Exempt handling: Aggregation of and publication of aggregate data requires a stated policy about the handling of missing data values. The process by which missing values are handled needs to be documented and clearly communicated to users.

Consider how data is being pulled for the maps and how we're pulling it for DB; are we able to use the same method?


How to use Quill-task-list with ngQuill

Hi @koffeinfrei
I am trying to integrate this Quill extension into my project which is based on AngularJS/ES6/Webpack, I also used https://github.com/KillerCodeMonkey/ng-quill.
When I imported quill-task-list like this and use ngQuillConfig to set the tasklist.
import  './quill-task-list';

It will report the tasklist is not registered.
It is possible to use this tools as a standalone ES 6 module?
Thanks.

I don't know how to properly configure ng-quill.
Can you provide more code on how exactly your configuration looks like? Is the import statement executed before the configuration?

@koffeinfrei  Hi, Thanks for your reply.
Yeah, of course I can provide the configure code piece there.  I copied the codes in our project.  And in angular.config section, I used it like this.
import  './quill-tasklist';
import './quill-tasklist.styl';

  ngQuillConfigProvider.set(
    {
      toolbar: [
        ['bold', 'italic', 'underline', 'strike'],        // toggled buttons
        ['blockquote', 'code-block'],

        [{ 'header': 1 }, { 'header': 2 }],               // custom button values
        [{ 'list': 'ordered' }, { 'list': 'bullet' }],
        [{ 'script': 'sub' }, { 'script': 'super' }],      // superscript/subscript
        [{ 'indent': '-1' }, { 'indent': '+1' }],          // outdent/indent
        [{ 'direction': 'rtl' }],                         // text direction

        [{ 'size': ['small', false, 'large', 'huge'] }],  // custom dropdown
        [{ 'header': [1, 2, 3, 4, 5, 6, false] }],

        [{ 'color': [] }, { 'background': [] }],          // dropdown with defaults from theme
        [{ 'font': [] }],
       // [ 'task-list' ],
        [{ 'align': [] }],

        ['clean'],                                         // remove formatting button

        ['link', 'image', 'video']                         // link and image, video
      ],
      //'task-list': true
    }
  );

ngQuillConfigProvider is a standard Angular provider, and use for configure the Quill for ng-quill component/directive.
When I tried to add tasklist there, used the ngQuill editor, there is an empty placeholder in the position of tasklist, did not display the toolbar icon instead, and in the Chrome console log, it is complain tasklist is not registered.

Is your import statement actually loading the script? Can you add some debug statement (alert or console.debug or something similar) to quill-tasklist to see if the import actually is correct?

@koffeinfrei  I have tried to add some log in quill-tasklist source code, it is executed.

Did you manage to figure this out?
I'm guessing that the import of my plugin is too early, and the ng-quill instantiates the actual Quill instance later. My plugin should be executed only after the actual Quillgets instantiated.
Can you try to prepend import  'quill'; to the import  './quill-tasklist'; statement?

I'll close this due to inactivity. Feel free to reopen this when you get back to this.


Fix SyntaxError in text fixture sample app

Closing since it clobbers my PR listing page and I don't think anybody cares about it.


[0.16.0-rc] using a library which uses a .babelrc is broken

I'm developing a library that have a .babelrc and exposed both for web and native.
it contains:
{
  "presets": ["es2015", "stage-1", "react"]
}

I've creating an empty RN 0.16.0-rc project, add my lib in dependencies, and when trying to run, it breaks:

it still breaks the same if I just have ["es2015"].
Each library should be able to expose a .babelrc right? I thought this was the convention.

The tentative solution was to get library authors to omit .babelrc from npm packages but I'm finding that's not a scalable solution. In our fork of RN we disable babelrc support across the board.
cc @sebmck

Duplicate of #4062

This is affecting the 'alt' framework. Removing .babelrc works https://github.com/goatslacker/alt/issues/558

I've been running into this all over the place with Redux.
@NullDivision suggests removing the babel executable from ./node_modules/.bin so you can fallback to your global executable that you can run at version 5 of Babel.
Not an ideal workaround, but it can get things working again for the time being.
Ref https://github.com/rackt/react-redux/issues/206#issuecomment-162256169

I've been deep in the packager code lately...if I get a chance today maybe I'll take a look at how to ignore .babelrc's.

Thanks. BTW I've taken the path of writing a prepublish script ( https://github.com/ProjectSeptemberInc/gl-react/blob/master/package.json#L5-L9 ) to publish a "compiled" lib to NPM.
I think it's also safer (instead of publishing ES6+ / JSX code that might not work for everyone), more compatible with whatever the build tool is (browserify / webpack / RN packager) and also take less compilation time ;)
so anyway, let's stick with #4062 more general discussion. closing this issue.


rename classes

At least one Manager class should be renamed, because it confuses users that there are two different classes with the same name.

I should probably go with something like GameJoltAPI and GameJoltUI.
Yes, it looks a bit strange and redundant if you use the fully qualified name (GameJolt.API.GameJoltAPI), but who uses the fully qualified name? exactly, no one.


Farnsworth's Business Mod not working

When using Farnsworth's Business Mod https://www.gtagaming.com/farnsworths-business-mod-complete-v2-f21460.html you can't seem to buy any businesses or start working. Also noticed some corruption in the prompts. Im using 1070 version of gta 4.

Farnsworth's Business Mod use INI(Businesses.ini) file as a save.
And for this mod it only uses SettingFile.SetValue() function to save , in this dotnet translation layer it can not write data back to the INIfile.

Farnsworth's Business Mod use INI(Businesses.ini) file as a savefile.
And for this mod it only uses SettingFile.SetValue() function. HazardX original save() was automatically called during Unload, CheckState or Script termination. (ContentCache.RemoveAll()->ContentCache.SaveINIs()->Save())
In this translation layer SetValue() alone can not write data back to the INIfile. the mod itself must call save() each time.
I made a small change for Farnsworth's Business Mod in dnspy, add save() after the setvalue(). the mods runs fine and can be saved manually. (except the prompts text)
@ClonkAndre is it possible to make it call save() automatically within IVSDKDotNet when game/script terminated.

@ClonkAndre is it possible to make it call save() automatically within IVSDKDotNet when game/script terminated.

It is. Thanks for the insight, i will add this to my todo list!

Alright in the next version of IV-SDK .NET and this translation unit, scripts should now save their settings file when they get unloaded or when GTA IV closes!


network: make SrcAddrSocketOptionImpl safely handle null addresses

Description: Adds defensive handling since returned addresses may be null (especially after filtering: #1901).
Risk Level: Low
Testing: Local & On Device
Signed-off-by: Mike Schore<EMAIL_ADDRESS>

@snowp do you mind taking a look at this one as well?


feat: output the modulus hash from the circuit

What is the feature?
To optimize on-chain verification, we need to output the hash of the modulus from the circuit, which will enable us to check the signer from publicInputs inside the Verifier smart contract.

Merged #147


[ Do not review] For test

I don't know what you're doing here but I won't accept a PR that splits these scripts


Add LED Status Indicator Support

[ ] Define blink pattern for Status LED
[ ] Define blink pattern for battery LED
[ ] Add Interface for controlling LEDs on IO-Expander
[ ] Add status task triggered by timer to control LEDs on IO-Expander

@LIFsCode @OOHehir
An idea about the indicator system. I am sure it has some flaws in it. So please add or correct if you find improvements.
Somehow i think the battery LED should be used for other purposes as well. 90% of the time people will check the battery from the app anyway. I might remove the name "Battery LED" from the PCB as well.
And because it kind of fits in here i added the Buzzer also :)
Status LEDs:

Function
Status LED
Battery LED
Description

Booting
Alternating
Alternating
Status LED and Battery LED alternating

BT ready (not connected)
ON
Off
Status LED constantly ON

BT connected
ON
ON
Status LED and Battery LED both ON

Recording
Flashes (100ms per second)

Flashes for 30 seconds, reactivatable with knock sensor

Detecting

Flashes (100ms per second)
Flashes for 30 seconds, reactivatable with knock sensor

No SD card
flash fife times for 50ms every second
flash fife times for 50ms every second
Flashing at the sam time

Battery Low *
flash three times for 50ms every 5 seconds
flash three times for 50ms every 5 seconds
Flashing at the sam time

Firmware uploading/flashing
fast flashing
fast flashing
Both LEDs flash in a fast interval

Sleep
OFF
OFF
All LEDs OFF

*NOTE: The ELOC should have a battery threshold where it brings the ELOC to sleep and wakes up again when the battery is full enough. Not implemented yet, but the "Battery Low" is active, when the battery voltage is under that threshold.
Buzzer
Didn't try these frequencies yet. So not sure how they sound. But surely some of these sounds will be too annoying. Maybe implement the bold once first.
@LIFsCode I just had a look at the buzzer code again to find out if you need notes or frequencies. And then realized that this is not a copy and past thing. You actually wrote that. Very cool stuff.

Function
Frequency Hz 1
Frequency Hz 2
Frequency Hz 3
Description

Booting

No sound

BT ready (not connected)
261 (C4)
523 (C5)

play once, maybe 100ms each tone?

BT connected

Recording
261 (C4)
440 (A4)
523 (C5)
play once, reactivatable with knock sensor

Detecting
261 (C4)
330 (E4)
392 (G4)
play once, reactivatable with knock sensor

Battery Low
261 (C4)
98 (G2)

play twice, sweep 0.5 sec, triggered by knock sensor

BT turns off
261 (C4)
98 (G2)

Intruder alarm*
494 (B4)
1760 (A6)

repeated Sweep 0.5s  for 15 seconds

Press GPIO0 >5 sec or send "indi" via BT serial
EFGC DEF GABF AABCDE EFGC DEF GABF AABCDE EFGC DEF GGED GED GED GFEDC

Play Indiana Jones theme

*If the accelerometer goes crazy. Maybe good idea to scare animals or humans with it.


Update index.md

Update patches related to 'Hyperconvergence - Sharding aware geo-replication'

Sorry Kotresh, you have to update this again after I merged the restructured version.

I guess this can be closed since #58 has been merged.


Fix regression caused by resolveOptions

If opts was nil, resolveOptions would only update the local copy of opts. The pointer was never being updated and was therefore nil when passed to the New*Client methods.
Closes #17

Hey, that sounds good. I'll push some changes + new tests this afternoon.
Cheers,
Craig

@samcoe I was wondering if it was still desirable to allow the consumer to pass nil for ClientOptions.
e.g:
gh.HTTPClient(nil)
Then it would be up to the client methods to pass a valid api. ClientOptions.
func HTTPClient(opts *api.ClientOptions) (*http.Client, error) {
	if opts == nil {
		opts = &api.ClientOptions{}
	}
.....

The other option would be to ask he consumer to provide an empty api.ClientOptions.

My thought would be that it should be up to the client methods to pass a valid api.ClientOptions to resolveOptions even if they received nil, so exactly as you proposed 👍

I've pushed an implementation. I couldn't decide whether to include a nil check in resolveOptions so I left it out. I don't think it will ever be an issue to the consumer given that the client methods now handle the opts. Saying that though.. I'm more than happy to add something in if it's preferable!
Currently pondering on tests... it feels tricky because of config.Load() and mocking it would mean exporting some more things from the config package.. however I'm fairly fresh with Go so I might be overlooking something obvious.

Added some tests and rebased 👍

@samcoe appreciated 😄


Improved docs for git / github

Not yet ready for review
I am using this branch to improve the documentation for "getting started" - but more to come!

Should we assign this one to Sahar?  Since this is now older than the additions you made today - she might have to do a merge, a good learning step...

@Madejski I think it's up to you (as developer) to resolve the conflicts in the file. It looks like you can use the "Resolve Conflicts" button to do this: it'll open up a special editor, that shows you where the conflicts are, and helps you edit the file till there are no conflicts. You need to do this quite carefully to make sure that the ipynb file will still function: make sure you don't delete any lines by mistake, and try to check that the yaml code looks right (and there are no missing brackets, hanging commas etc etc). Good luck!

OK, will do.  I am getting more and more confident with git, but not 100% there yet...  If I follow your instructions as you wrote above, is there a way I can check it i a git window to see whether it runs without reloading it back to my instance of JupyterLab?

I think I removed the conflicts, and also changed the incorrect URL that we identified some time ago.  I assigned you, @drphilmarshall  to review - I hope this is the correct process...

I tried to load HelloWorld.ipynb and I got the error
File Load Error for HelloWorld.ipynb
Unreadable Notebook: /home/kadrlica/notebooks/StackClub/GettingStarted/HelloWorld.ipynb NotJSONError('Notebook does not appear to be JSON: \'{\\n "cells": [\\n {\\n "cell_type": "m...',)


I am trying to create a base image using "scratch" in redhat linux. This is the instruction that I am using : FROM scratch ADD mkdir dir/repos  and it is throwing this error :  exec: "/bin/sh": stat /bin/sh: no such file or directory

Description

Steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Additional information you deem important (e.g. issue happens only occasionally):
Output of docker version:
(paste your output here)

Output of docker info:
(paste your output here)

Additional environment details (AWS, VirtualBox, physical, etc.):

Can you please reformat this?
The title should be a brief description and the body should contain what's going on, preferably with the issue template filled out.
This is completely illegible as is.
Closing for now but can re-open when you update.
Thanks!


okcruby Pizza for April Meeting

Requesting pizza for approx 15 people for the okcruby meeting on 2016-04-14
cc @jagthedrummer @piisalie

Pizza is ordered


make_avsc_object()?

Are you planning on implementing it?

My bad, didn't notice you're using schema as dicts everywhere. < 3


chore: fix tests

PR-Codex overview
The focus of this PR is to update contract addresses and improve test readability.
Detailed summary

Updated contract addresses in src/__contracts/addresses.ts
Changed test data in multiple test files to reflect new contract addresses
Updated chain name in fetch:deployment.ts script
Updated mock addresses in tests/src/__contracts/mockAddresses.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

closing this as discussed


refactor: migrate to axum

Description
Migrate from warp to axum.
With current implementation i tried to preserve the same behavior as before.
I would suggest further improvements in the separate PRs.

Linked issue

Closes #3776

Benefits
Bring more simplicity to torii.

But Torii tests are failing.

Tests are fixed + added extra test for different wrong body errors, the problem was mainly because pytests didn't set proper headers.

@AlexStroke please take a look at torii pytests

Ignore first commit, it's extracted in separate PR and here only to make unit tests work


Fix bug in preferences

What do you mean with "has setup a exclude list etc," ? The exclude and ignore list entries will be stored in the CamelPreferencesService as it was before. I just replaced our custom JBTable and TableModel with AddEditRemovePanels.
Hope this answers your question? I also checked if the changes will be persisted and available after IDEA restart. That works fine 👍

@bennetelli Remember to Squash your commits when merge the pull-request  :-)


sound/test: add tests for virtio_sound.rs

Summary of the PR
This commit adds simple tests for the structures in virtio_sound.rs. The tests are split into two tests to fix a clippy error regarding the cognitive complexity when I have used a single test to cover both debug and clone.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:

[x] All commits in this PR are signed (with git commit -s), and the commit
message has max 60 characters for the summary and max 75 characters for each
description line.
[x] All added/changed functionality has a corresponding unit/integration
test.
[x] All added/changed public-facing functionality has entries in the "Upcoming
Release" section of CHANGELOG.md (if no such section exists, please create one).
[x] Any newly added unsafe code is properly documented.

@stefano-garzarella maybe we should prevent grcov from checking the Debug derives?
See https://github.com/mozilla/grcov/pull/416#issuecomment-612562052

@stefano-garzarella maybe we should prevent grcov from checking the Debug derives?
See mozilla/grcov#416 (comment)

That would be nice, but we are using llvm-cov IIRC, maybe there is a similar way, but we need to change rust-vmm-ci script.
I think for now we can go with this (in order to move the crate out from staging), then we can revert when we have the ci fixed.
Feel free to open an issue/pr on rust-vmm-ci.


Request: Shoot lowest choked packet

Shooting the lowest choked packet might increase the chance of hitting a fakelag

Duplicate of #663


docs: type printed in code blocks

The type of code is printed visibly on code blocks.
This seems to only occur on single line snippets.
For example here:
shell helm show values keptn/keptn > values.yaml

Possibly closed by #2751

fixed in #2751


bug: empty Set literals don't compile

Right now Set literals do not compile. For example:
This compiles fine (https://play.crystal-lang.org/#/r/9bu6):
MY_CONSTANT = Set(String){""}

This does not (https://play.crystal-lang.org/#/r/9bu5):
MY_CONSTANT = Set(String){}

And results in this error:
syntax error in eval:1
Error: for empty hashes use '{} of KeyType => ValueType'

@asterite thanks for replying to this one on Gitter :)

For context, I needed a Set for use in a macro, which is why it was important I use a literal vs just Set(String).new.


Multiple identical todo changes

From:
hello
hello

To:
helloa
hellob

The diff is:
Deleted tasks
-------------

 → hello

Changed tasks
-------------

 → hello
    → Changed subject ‘helloa’
    → Copied and changed subject ‘hellob’

It would be nice if it was detected that each task was changed, instead of one deleted and one copied.

Same behaviour happens with multiple identical TODOs that are completed, most likely for the same reason: the matching algorithm doesn't deprioritize already-matched TODOs.

This was fixed in https://github.com/Ekleog/todiff/commit/34350fe69742cde91ae61ec918a4990cb95a4139 , now merged

Indeed, thanks!


Enhance question/issue template

:green_heart: Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #1250 opened]

Start Time: 2020-06-23T08:17:21.759+0000

Duration: 3 min 16 sec


Can't set airco mode in web server

Since today on all my devices I am not able to select the airco mode (Cooling, heating, fan only etc in the web server anymore.
Even if I upload a old .bin file this functionality is gone.

Someone else I know has the exact same thing. The devices are on ESPHome 2023.4 version so it doesn't seem like it has updated or something, but it all started at the same time. The option is just gone. Instead it now says state "24".

I just checked and indeed the webserver has no possibility anymore to do settings etc.

It probabely has to do with this change on ESPHome, so I think the issue can't be solved by this Repo and therefore may be closed. Unless there's a workarround that can be provided?


Action and Func Delegates in CSharp jrliv

Jenkins CI build was successful. Closed pull request per the email instructions.


Generate DDL with schema name only (without database name)

Is your feature request related to a problem? Please describe.
A great feature of dbeaver is to be able to extract the DDL for most database entities like tables, keys, even whole schemas. The dialog window has a check box Use fully qualified names which will prefix the table names with their respective database and schema names:

By checking this box, CREATE TABLE my_table becomese CREATE TABLE my_database.my_schema.my_table.
However, there are two problems with this:

On Azure SQL, prefixing with database names is not allowed and leads to an error like this when executing the query:
Reference to database and/or server name in 'my_database.my_schema.my_table.' is not supported in this version of SQL Server.

I may run the statement on a different database with a different name, then i just need the schema name in the statement, not the database name (which may be entirely different).

Describe the solution you'd like
In addition to the "Use fully qualified names" have another checkbox for "include schema name".
Describe alternatives you've considered
Copy paste the generated DDL to another window, run find/replace all on it. Not particularly user friendly.
Another solution would be to just omit the server name at all for an Azure SQL database as it is of no use at all, but that would be a solution specific to Azure SQL. Would be happy with that as well.

Thanks for the idea!
We wonder how many users seek this feature.
So, for someone interested, please vote for the issue with 👍🏻 under the issue description to promote it to a higher priority.


Incorrectly Identifies New 3ds color

Reports my New 3DS XL black as red:

Do please let me know what info/logs/etc you need (not much familiar with 3ds stuff).

RED = New 3DS XL's code name (like how CTR is the code name for Old 3DS), it is not determining the colour. Considering this has been confusing a lot of users I may just decide to use the other code names instead. Also I notice your brightness says n3ds only, which is a bug and that will be fixed in the next release.

Understood, I'm a derp, and thx for the useful app!

No worries! BTW you may want to remove that first image since it displays a lot of your unique device info.
Also thanks for your donation, really appreciate it!

ofc!

Ah, glad i found this. Was going to make this exact post xd

Believe me, I made this almost exact issue when I first got my N3DS XL :)


 As for me for testing changes it's enough current oauth2_filter tests
Release notes: Fixed processing callback url with Non-ASCII characters in the OAuth2 filter
Fix issue #23167

Can you provide more context around this change? This is huge and it sounds quit scary from a security perspective. Thank you.
/wait

It's very strange why it's showed so many commits and changed files. I have changed only 2 files. May be I'll recreate PR

It's better now. You can look one commit with a small changes.

But non-ASCII characters are not allowed in the URI path accprding to https://datatracker.ietf.org/doc/html/rfc3986#section-3.3 ?
Are you trying to fix this for an application that sends malformed URI in the request?
/wait-any

@yanavlasov , No, no. Did you see a bug description?
I agree that non-ASCII characters are not allowed in the URI path. But all Non-ASCII symbols encode by URL encode according the same spec(https://datatracker.ietf.org/doc/html/rfc3986#section-2.1) . Any application can send Unicode symbols in URI using by HTML URL Encoding. My application sends all right.
The OAuth2 filter receives URI form only ASCII symbols. But after decoding URL to string, the string already contains Non-ASCII symbols, they were decoded.
And in this moment, http_parser library already cannot parser such string properly. GURL library is OK. It works good with URL with Non-ASCII symbols.

I see. This is a bug in the filter. the Http::Utility::PercentEncoding::decode decodes every single character, but in fact only characters from the reserved and unreserved character sets should be decoded, if I understand it correctly.
I do not think this is the right change, since it will produce an incorrect redirect URL with unescaped non-ASCII characters.
The right fix is to add a new Http::Utility::PercentEncoding::decodeURL function that only decodes characters from the reserved and unreserved sets and leaves all other encoding sequences as is.

I don't mind your suggestion. But I am not clear how to implement such function. Do you have a chance to create such function? I can just revert my changes and replace to your function and test after that

Also note that in the filter implementation we compare URL object with URL from setting of the filter. If URL will contain non-decoded characters in this case user need to know about it and have to set HTML encoding URL in the filter settings.
I think it's no user friendly.

I unfortunately do not have time to work on fixing this, but I can help you implement it.
You can see how the Http::Utility::PercentEncoding::decode function is implemented here: https://github.com/envoyproxy/envoy/blob/8285fca7c3da4b0ab9aa35e3febab659164ba987/source/common/http/utility.cc#L1024
The Http::Utility::PercentEncoding::decodeURI is the same but with additional check here https://github.com/envoyproxy/envoy/blob/8285fca7c3da4b0ab9aa35e3febab659164ba987/source/common/http/utility.cc#L1045
to see if ch is in either reserved or unreserved sets according to RFC: https://datatracker.ietf.org/doc/html/rfc3986#section-2.2
if it is - it should be decoded, if it is not in either of these sets ch should be set to % and i += 2; is skipped.
Then you can add unit tests similar to how it is done here: https://github.com/envoyproxy/envoy/blob/8285fca7c3da4b0ab9aa35e3febab659164ba987/test/common/http/utility_test.cc#L1614 in you case you can just decode a string with every ASCII character %encoded and check that only expected characters were decoded.
We can then go through making changes in the o-auth filter.
I have also added current owners @derekargueta @snowp of this filter, in case they would want to take this on.

@yanavlasov , could you provide test input and output example? I am not sure that I clear undestand you what I need to do

The standard allows query to contain: unreserved | pct-encoded | sub-delims | : | @ | / | ? This allows 4 characters out of the gen-delims set to be unencoded and only requires the #[] characters to be encoded.
The bigger question is if the redirect URI also contains query string. I do not know if OAuth allows query and fragment in the redirect URL. If it does, it means that the key/value separators in the redirect URL also have to be %-encoded to prevent incorrect interpretation.
If query and fragment are allowed in the redirect URL and assume that query key/value separators are = and &, then the test strings are:
input: %00%01%02 ...<replace ... with %-encoded sequences for all intervening characters> %FE%FF%
output: %00%01%02...%22#%24%25&%27...%3C=%3E...%5A[%5C]%5E...%FE%FF%
This is my best approximation for how URL should be encoded as part of a query parameter.

/wait

I dont' have time to reedit changes. I hope I will find a time for this

I had have been more time to think about your suggestion. I think my changes are correct. I am trying to explain.
You suggest to create a special decode function. I think there are already two function to encode and decode URL and they works excellent. Why you need to create third function for URL? You suggest to make a partial decoding in new function. I think it's strange.
Beside that, I don't produce non valid URL. The filter decodes the URL. The Http::Utility::PercentEncoding::decode function works right according specification. After decoding the redirect url is true by structure. GURL library confirms that this is a valid URL unlike the Http::Utility::Url.
We works with decoded URL in the filter. The redirect url will be encoded back by the filter at the end.
The GURL library is recieved just a plain URL. The url is not needed to be encoded. The Http::Utility::Url also need to work with any decoded URL true by structure, but it's not. And it's main problem

@yanavlasov, @mattklein123, I think my changes are perfect and fix the problem. I told above why I think so

I am busy to actualize code

This PR may be closed in favor of the #25278


Depreciate Orthonormalisation.

Hi all,
Ben's probably shaking his head at this one. The orthonormalisation is only significant once you include a certain number of zernike terms. I do not want the program to waste time on it if then number of terms is less than this threshold, but I also don't want to pixk a threshold as that is quite arbitrary. Instead I think that we depreciate this functionality and instead just cookie cutter the basis functions on the aperture.
What are your thoughts
Jordan

Aaah Ben is always right 😉
For the irregular shapes I would just go with cookie-cutter. Maybe just put the orthonormalisation code somewhere in utils, no need to remove functionality if it is already built!

This is still good functionality that can be used, lets keep it!


Set pvcstorageclass for metric storage

RHEV job is failing on telemetry adoption due to missing storage class FailedBinding persistentvolume-controller no persistent volumes available for this claim and no storage class is set(https://sf.hosted.upshift.rdu2.redhat.com/logs/23/523/5c1f579434e031b60bd4475fb64c240685f5b0f1/check-gitlab-cee/rhev-rhel9-osp18-base-adoption-test-archana/1664d8b/undercloud/data-plane-adoption-tests-repo/data-plane-adoption/tests/logs/test_minimal_out_2024-08-01T16:15:27UTC.log)

/lgtm

As discussed over slack, this change may not be required.


"Show example query" functionality not working on docs page

I noticed that "Show example query" is not working in docs page
Chrome console looks like this:
transaction.js:48 Uncaught Error: Cannot find module "../index"
(index):3896 Uncaught ReferenceError: Knex is not defined

Hmm... It started working again... I was getting following errors on Friday
transaction.js:48 Uncaught Error: Cannot find module "../index"
(index):3896 Uncaught ReferenceError: Knex is not defined

Closing...


Fix "Cannot read property 'split' of undefined"

What does this implement/fix?
This fixes the "Cannot read property 'split' of undefined" bug when using php-cs-fixer.
Does this close any currently open issues?
This bug closes this issue.

got this issue some time ago ,
just go to beautify setting,
remove cs-fixer phar path from exutable, and put into php setting,
at this point beautify will notice you that is deprecated,
just go to to you user folder (i'm assuming you are uing win10) ".../.atom\packages\atom-beautify\src\beautifiers" and edit file "php-cs-fixer.coffee" at line 46 from "cs_fixer_path: true" to "cs_fixer_path: false"
and it should work again


Break out reading logs into separate role

Right now the view role includes reading logs, which depending on your
circumstance you may or may not want.  This change pulls the logs
action into a separate role "view-logs" so a user must be assigned both
view and view-logs to have the previous behavior of view.
Signed-off-by: Darren Shepherd<EMAIL_ADDRESS>

I'm fine if you want to merge this for v0.5.0 @ibuildthecloud