question ask  Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy

Describe the bug
istiod logs
2022-05-16T08:18:46.709604Z	info	ads	RDS: PUSH for node:dubbo-sample-provider-v2-5576f45c6c-d9vn8.testhl resources:7 size:8.1kB cached:7/7
2022-05-16T08:18:46.976146Z	warn	ads	ADS:LDS: ACK ERROR deploy-1-6cb5d7d9cd-l4kk4.testhl-28 Internal:Error adding/updating listener(s) <IP_ADDRESS>_20880: Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy'
2022-05-16T08:18:46.976271Z	warn	ads	ADS:LDS: ACK ERROR deploy-3-58b5fbbd48-rvqhf.testhl-27 Internal:Error adding/updating listener(s) <IP_ADDRESS>_20880: Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy'
2022-05-16T08:18:47.052082Z	warn	ads	ADS:LDS: ACK ERROR deploy-2-7b9494bc47-vv8r4.testhl-29 Internal:Error adding/updating listener(s) <IP_ADDRESS>_20880: Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy'
2022-05-16T08:18:47.054691Z	warn	ads	ADS:LDS: ACK ERROR deploy-0-78df8b8f4f-vz2xx.testhl-30 Internal:Error adding/updating listener(s) <IP_ADDRESS>_20880: Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy'
2022-05-16T08:26:01.900748Z	info	ads	ADS: "<IP_ADDRESS>:50466" deploy-2-7b9494bc47-vv8r4.testhl-29 terminated rpc error: code = Canceled desc = context canceled
2022-05-16T08:26:02.470392Z	info	ads	ADS: new connection for node:deploy-2-7b9494bc47-vv8r4.testhl-36
2022-05-16T08:26:02.471481Z	info	ads	CDS: PUSH request for node:deploy-2-7b9494bc47-vv8r4.testhl resources:27 size:23.0kB cached:24/24
2022-05-16T08:26:02.471957Z	info	ads	EDS: PUSH request for node:deploy-2-7b9494bc47-vv8r4.testhl resources:24 size:3.1kB empty:0 cached:24/24
2022-05-16T08:26:02.475341Z	info	ads	LDS: PUSH request for node:deploy-2-7b9494bc47-vv8r4.testhl resources:18 size:41.1kB
2022-05-16T08:26:02.475952Z	info	ads	RDS: PUSH request for node:deploy-2-7b9494bc47-vv8r4.testhl resources:7 size:8.1kB cached:7/7
2022-05-16T08:26:02.749365Z	warn	ads	ADS:LDS: ACK ERROR deploy-2-7b9494bc47-vv8r4.testhl-36 Internal:Error adding/updating listener(s) <IP_ADDRESS>_20880: Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy'
2022-05-16T08:26:59.025330Z	info	ads	ADS: "<IP_ADDRESS>:53252" deploy-3-58b5fbbd48-rvqhf.testhl-27 terminated rpc error: code = Canceled desc = context canceled
2022-05-16T08:26:59.461693Z	info	ads	ADS: new connection for node:deploy-3-58b5fbbd48-rvqhf.testhl-37
2022-05-16T08:26:59.462322Z	info	ads	CDS: PUSH request for node:deploy-3-58b5fbbd48-rvqhf.testhl resources:27 size:23.0kB cached:24/24
2022-05-16T08:26:59.462777Z	info	ads	EDS: PUSH request for node:deploy-3-58b5fbbd48-rvqhf.testhl resources:24 size:3.1kB empty:0 cached:24/24
2022-05-16T08:26:59.465736Z	info	ads	LDS: PUSH request for node:deploy-3-58b5fbbd48-rvqhf.testhl resources:18 size:41.1kB
2022-05-16T08:26:59.466145Z	info	ads	RDS: PUSH request for node:deploy-3-58b5fbbd48-rvqhf.testhl resources:7 size:8.1kB cached:7/7
2022-05-16T08:26:59.553447Z	warn	ads	ADS:LDS: ACK ERROR deploy-3-58b5fbbd48-rvqhf.testhl-37 Internal:Error adding/updating listener(s) <IP_ADDRESS>_20880: Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy'
2022-05-16T08:27:15.064692Z	info	ads	ADS: "<IP_ADDRESS>:57826" deploy-0-78df8b8f4f-vz2xx.testhl-30 terminated rpc error: code = Canceled desc = context canceled
2022-05-16T08:27:15.571393Z	info	ads	ADS: new connection for node:deploy-0-78df8b8f4f-vz2xx.testhl-38
2022-05-16T08:27:15.572514Z	info	ads	CDS: PUSH request for node:deploy-0-78df8b8f4f-vz2xx.testhl resources:28 size:23.2kB cached:24/24
2022-05-16T08:27:15.572994Z	info	ads	EDS: PUSH request for node:deploy-0-78df8b8f4f-vz2xx.testhl resources:24 size:3.1kB empty:0 cached:24/24
2022-05-16T08:27:15.575904Z	info	ads	LDS: PUSH request for node:deploy-0-78df8b8f4f-vz2xx.testhl resources:18 size:44.4kB
2022-05-16T08:27:15.576230Z	info	ads	RDS: PUSH request for node:deploy-0-78df8b8f4f-vz2xx.testhl resources:7 size:8.1kB cached:7/7
2022-05-16T08:27:16.452550Z	warn	ads	ADS:LDS: ACK ERROR deploy-0-78df8b8f4f-vz2xx.testhl-38 Internal:Error adding/updating listener(s) <IP_ADDRESS>_20880: Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy'
and envoy logs
cds: added/updated 0 cluster(s), skipped 28 unmodified cluster(s)
2022-05-16T08:18:47.048726Z	warning	envoy config	gRPC config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) <IP_ADDRESS>_20880: Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy'
2022-05-16T08:27:15.561289Z	info	xdsproxy	connected to upstream XDS server: istiod-1-12.istio-system.svc:15012
2022-05-16T08:27:15.652299Z	info	envoy upstream	cds: add 28 cluster(s), remove 5 cluster(s)
2022-05-16T08:27:15.752772Z	info	envoy upstream	cds: added/updated 0 cluster(s), skipped 28 unmodified cluster(s)
2022-05-16T08:27:16.447914Z	info	envoy upstream	lds: add/update listener 'virtualInbound'
2022-05-16T08:27:16.448243Z	warning	envoy config	gRPC config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) <IP_ADDRESS>_20880: Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy'
[root@huangli-k8s:/home/yamls/aeraki]istioctl  ps
NAME                                                   CDS          LDS                            EDS          RDS          ISTIOD                           VERSION
deploy-0-78df8b8f4f-vz2xx.testhl                       SYNCED       STALE (Never Acknowledged)     SYNCED       SYNCED       istiod-1-12-6b7bc9f8df-gxcjw     1.12.3
deploy-1-6cb5d7d9cd-l4kk4.testhl                       SYNCED       STALE (Never Acknowledged)     SYNCED       SYNCED       istiod-1-12-6b7bc9f8df-gxcjw     1.12.3
deploy-2-7b9494bc47-vv8r4.testhl                       SYNCED       STALE (Never Acknowledged)     SYNCED       SYNCED       istiod-1-12-6b7bc9f8df-gxcjw     1.12.3
deploy-3-58b5fbbd48-rvqhf.testhl                       SYNCED       STALE (Never Acknowledged)     SYNCED       SYNCED       istiod-1-12-6b7bc9f8df-gxcjw     1.12.3
dubbo-sample-consumer-759fc7489d-d5476.testhl          SYNCED       SYNCED                         SYNCED       SYNCED       istiod-1-12-6b7bc9f8df-gxcjw     1.10-dev
dubbo-sample-provider-v1-98c5b9fd6-6m65m.testhl        SYNCED       SYNCED                         SYNCED       SYNCED       istiod-1-12-6b7bc9f8df-gxcjw     1.10-dev
dubbo-sample-provider-v2-5576f45c6c-d9vn8.testhl       SYNCED       SYNCED                         SYNCED       SYNCED       istiod-1-12-6b7bc9f8df-gxcjw     1.10-dev
istio-ingressgateway-5cfcfdf977-jph96.istio-system     SYNCED       SYNCED                         SYNCED       NOT SENT     istiod-1-12-6b7bc9f8df-gxcjw     1.12.3
test-1.istio-system                                    NOT SENT     NOT SENT                       NOT SENT     NOT SENT     istiod-1-12-6b7bc9f8df-gxcjw     65536.65536.65536
install aeraki  with istio, somesidecar use meta-protocol enovy,some use official envoy
then install dubbo demo
then eds become scale
and istiod logs ADS:LDS: ACK ERROR deploy-3-58b5fbbd48-rvqhf.testhl-37 Internal:Error adding/updating listener(s) <IP_ADDRESS>_20880: Didn't find a registered implementation for name: 'envoy.filters.network.meta_protocol_proxy'
root@huangli-k8s:/home/yamls/aeraki]istioctl  version
client version: 1.12.3
control plane version: 1.12.3
data plane version: 1.12.3 (5 proxies), 1.10-dev (3 proxies), 65536.65536.65536 (1 proxies)
it seems that  aeraki can not work  official envoy
can any way to work both? (some proxy is official and some is meta-proxy)

Hi @huanghuangzym
Aeraki Mesh will push configuration for MetaProtocol Proxy to the sidecar proxy, so if the sidecar proxy doesn't have metaProxoy Proxy TCP filter built in, it will report the "Didn't find a registered implementation for name: envoy.filters.network.meta_protocol_proxy'" issue.
If some of the services don't need to talk in MetaProtocol, say, they're just HTTP services, we could avoid send MetaProcol configuration to them by adding a workloadselector to the generated EnvoyFilters. It could be a very useful feature.

it seems outbound filter is auto generated at istio-system and no selector   by aeraki controll plane when create servicenentry use metaprotocol

if i add workload selector  , would it  recover by aeraki?

if i add workload selector , would it recover by aeraki?

You can't manually modify the generated Envoyfitlers. Your modification will be overwritten by Aeraki. Aeraki will officially support workloadselector in future releases.

We can scope the envoyfilter to a specific namespace, is this good enough? Or do you need it in the deployment level?

https://github.com/aeraki-mesh/aeraki/pull/226


'Too many open files' error

Hi,
I have a long running application that works great, but recently I upgraded it a bit, and it now serves a bit more images through Tornado web server than before, and after users have connected/disconnected to it lot's of times, at random times the application crashes and throws:
...
Too many open files (src/epoll.cpp:65)
Aborted (core dumped)

The first thing I tried is to set the maximum open file limit on the Ubuntu Linux the application is running on to 10 times more, but with no success, still get the error.
Any suggestion of what I else I could try to fix this?
Thanks

Mmm, my first guess is that the websockets might not be cleaned up properly (sockets are file descriptors too).
Is there anything specific about the update? Would you expect more websocket connections after it? Or are the images served via regular http requests?

Thanks for the quick reply.

Mmm, my first guess is that the websockets might not be cleaned up properly (sockets are file descriptors too).

Could be, yes, but currently I have no idea where this would occur.

Is there anything specific about the update? Would you expect more websocket connections after it? Or are the images served via regular http requests?

The biggest change is that previously the application was split into 2 sub-apps:
selection = flx.App(
   pages.Selection,
   title="App selection page"
)
selection .serve('Selection')
main= flx.App(
   pages.Main,
   title="Main page"
)
main.serve('Main')

and now it's just a single bigger app Main.
But there has been no increase in user traffic, there is usually only one user logged in, but I have tested it with two users simultaneously to try to reproduce it, but I couldn't. This always happens to a specific user, at random times, using Google Chrome (stock Chrome, no special plug-ins). All users access the app either locally or via VPN, no direct internet access.
All the new extra images (majority are .svg) are referenced by flx.ImageWidget or in a <img> tag in a label, and they are served by Tornado:
tornado_app = flx.current_server().app
tornado_app.add_handlers(
r".*",
[
    ...
    (
         r'/feather/(.*)',
         tornado.web.StaticFileHandler,
         {
              'path': os.path.join(working_directory, 'feather')
         }
    ),
    ...
]

The new widgets that were added in the upgrade do use a new method of creating an image on the fly if needed, in the Tornado directory, based on a monitored value and a limit value according to a scale (same is black, higher is redder, lower is bluer). But I tried continuously: loading the page with about 50 of these images, logging out, reloading the page with the 50 images, ... but could not reproduce this problem (mind that I didn't try this for long, about 10-20 reloads).

I don't see any red flags from the info you provide. But I found this code:
import os
import subprocess

pid = os.getpid()
out = subprocess.check_output(['lsof', '-wXFn', '+p', str(pid)], stderr=subprocess.DEVNULL)
print(out.decode())

You can run that in the process itself (or from another process, and then using the pid of the process of interest). It produces something like the below. Which looks like it may give some hints of the kinds of files being open.
p23679
f0
n->0x220ba76885751d5b
f1
n->0x33f28c6cd5efaf9e
f2
n->0x33f28c6cd5efaf9e
f3
nlocalhost:56063->localhost:50370
f4
n->0x531e76fc0357fe36

Hi @almarklein
Thanks for the suggestion. Here is the output of the command when two users are accessing the app simultaneously:
~$ sudo lsof -wXFn +p 1081
p1081
fcwd
n/home/test/app
frtd
n/
ftxt
n/usr/bin/python3.6
fmem
n/lib/x86_64-linux-gnu/libresolv-2.27.so
fmem
n/lib/x86_64-linux-gnu/libnss_dns-2.27.so
fmem
n/lib/x86_64-linux-gnu/libnss_files-2.27.so
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/backend/cython/_proxy_steerable.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/backend/cython/_device.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/backend/cython/_version.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/backend/cython/_poll.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/backend/cython/utils.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/backend/cython/socket.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/backend/cython/context.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/backend/cython/message.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/backend/cython/error.cpython-36m-x86_64-linux-gnu.so
fmem
n/lib/x86_64-linux-gnu/libgcc_s.so.1
fmem
n/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.25
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/.libs/libsodium-72341b7d.so.23.2.0
fmem
n/lib/x86_64-linux-gnu/librt-2.27.so
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/.libs/libzmq-39117701.so.5.2.1
fmem
n/usr/local/lib/python3.6/dist-packages/zmq/backend/cython/constants.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/lib/python3/dist-packages/cryptography/hazmat/bindings/_openssl.abi3.so
fmem
n/usr/lib/python3/dist-packages/_cffi_backend.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/lib/python3/dist-packages/cryptography/hazmat/bindings/_constant_time.abi3.so
fmem
n/lib/x86_64-linux-gnu/libuuid.so.1.3.0
fmem
n/usr/lib/python3.6/lib-dynload/_csv.cpython-36m-x86_64-linux-gnu.so
fmem
n/lib/x86_64-linux-gnu/libtinfo.so.5.9
fmem
n/lib/x86_64-linux-gnu/libncursesw.so.5.9
fmem
n/usr/lib/python3.6/lib-dynload/_curses.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/lib/x86_64-linux-gnu/libffi.so.6.0.4
fmem
n/usr/lib/python3.6/lib-dynload/_ctypes.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/local/lib/python3.6/dist-packages/tornado/speedups.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/lib/python3.6/lib-dynload/_json.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/lib/x86_64-linux-gnu/libssl.so.1.1
fmem
n/usr/lib/python3.6/lib-dynload/_ssl.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/lib/python3.6/lib-dynload/_asyncio.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/lib/python3.6/lib-dynload/_multiprocessing.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
fmem
n/usr/lib/python3.6/lib-dynload/_hashlib.cpython-36m-x86_64-linux-gnu.so
fmem
n/lib/x86_64-linux-gnu/liblzma.so.5.2.2
fmem
n/usr/lib/python3.6/lib-dynload/_lzma.cpython-36m-x86_64-linux-gnu.so
fmem
n/lib/x86_64-linux-gnu/libbz2.so.1.0.4
fmem
n/usr/lib/python3.6/lib-dynload/_bz2.cpython-36m-x86_64-linux-gnu.so
fmem
n/usr/lib/python3.6/lib-dynload/_opcode.cpython-36m-x86_64-linux-gnu.so
fmem
n/lib/x86_64-linux-gnu/libm-2.27.so
fmem
n/lib/x86_64-linux-gnu/libz.so.1.2.11
fmem
n/lib/x86_64-linux-gnu/libexpat.so.1.6.7
fmem
n/lib/x86_64-linux-gnu/libutil-2.27.so
fmem
n/lib/x86_64-linux-gnu/libdl-2.27.so
fmem
n/lib/x86_64-linux-gnu/libpthread-2.27.so
fmem
n/lib/x86_64-linux-gnu/libc-2.27.so
fmem
n/lib/x86_64-linux-gnu/ld-2.27.so
fmem
n/usr/lib/locale/locale-archive
fmem
n/usr/lib/x86_64-linux-gnu/gconv/gconv-modules.cache
f0
npipe
f1
n/home/test/app/output.txt
f2
n/home/test/app/error.txt
f3
n[eventpoll]
f4
ntype=STREAM
f5
ntype=STREAM
f6
n/dev/urandom
f7
n/dev/random
f8
n/home/test/app/log.txt
f9
ncan't identify protocol (-X specified)
f10
ncan't identify protocol (-X specified)
f11
ncan't identify protocol (-X specified)
f12
ncan't identify protocol (-X specified)
f13
ncan't identify protocol (-X specified)
f14
ncan't identify protocol (-X specified)
f15
ncan't identify protocol (-X specified)
f16
ncan't identify protocol (-X specified)
f17
ncan't identify protocol (-X specified)
f18
ncan't identify protocol (-X specified)
f30
ncan't identify protocol (-X specified)
f31
ncan't identify protocol (-X specified)
f32
ncan't identify protocol (-X specified)
f33
ncan't identify protocol (-X specified)

Not getting close to 1000 yet :P

I have no solution to this yet, but it's a issue that appears sporadically and seemingly only when one user with a Chrome browser logs on, and even then, it doesn't happen always.

I don't know what else to try, but am curious to what's going on. Please keep us posted!

Hey @almarklein , I got more information on the problem.
It seems that the trouble is caused by a single Windows machine that connects to the application. I tried a clean Windows machine on the same ethernet cable and it works without problems. So the user of the problem machine experimented a bit more. There are two things that stand out:

when the problem machine connects to the app, there are a lot of these type of file handles shown when observing with
sudo lsof -wXFn +p <process_id>:

f3
n[eventpoll]
f4
ntype=STREAM
f5
ntype=STREAM
...
f2156
n[eventpoll]
f2157
ntype=STREAM
f2158
ntype=STREAM

some of the images do not load in the browser for this problem user, noticeable with the missing-image-icon, example:

The images that do not load seems completely random, although it's the same images every time the user connects to the app.

This was tested on the problem machine on Chrome, Edge and Firefox: same behaviour on all three.
Also tried disabling the anti-virus, no difference.
Does this help in any way?

Thanks for the extra info. Strange though, and interesting how its bound to a specific machine, but independent of the browser used ...
Perhaps, something related to the firewall or other networking settings? Maybe it somehow fails to download the image and repeatedly tries again?

Could there be a way to detect this and disconnect the user if this happens?

The similarities between the two machines is that they are in the same network and they both have installed WithSecure (formerly F-Secure) anti-virus installed. Although the first user disabled this anti-virus to test if it would help, he could have not completely disabled all of it's functionality. We'll try uninstalling this anti-virus software to see if that might be the solution.

Update:
Updated the Python version from 3.6.9 to 3.11.0 and now it works on almost all browsers like Firefox, Chrome, Chromium, Opera, Edge. Only one still has the problem, SeaMonkey.


Suitable for Mac

Hey,
is there any chance that the bot could work on MacOS as well?

Hi!
It shouldn't be hard at all, but I don't own a Mac so I can't do it

Could you explain shortly how to pull this off?

I have no idea, I have never used mac. Maybe ask on the Discord server if some already managed to use ikabot on Mac

Apparently some people have already used ikabot on MacOS


node-debug not working in node > 0.10.32

Alright.  This is a weird thing.  I'm using nvm, and it seems like any version of node installed with nvm > 0.10.32 has the same problem.
To demonstrate the problem, this:
'use strict'
debugger;
var ChildProcess = require('child_process');

console.log('ok');

that script when run using  node-debug test.js  writes 'ok' to stdout, and then breaks inexplicably on  line 461 of node core's module.js.  there is no exception that has been generated, there's no breakpoint in place,  it's just breaking to indicate that Module.prototype._compile has finished execution
any ideas on what's going on?  This is making development kind of hard

This was fixed by moving to iojs


terminal colors are missing

We need sth. like this in this theme for neovim users:
https://github.com/joshdick/onedark.vim/blob/master/colors/onedark.vim#L471-L494
terminal buffers tend to look ugly without this.

I might use what is done for two-firewatch as a first iteration, need to work on this.

It's been hectic lately, and I'm trying to close as many issues as possible.
I just pushed a new version that addresses this issue, please have a look when you have some time.


Provide an example splunk-otel-go

Would be very useful add some example on documentation about implement splunk-otel-go on golang functions running on lambda

PTAL https://github.com/signalfx/tracing-examples/tree/main/opentelemetry-tracing/opentelemetry-lambda
I also created https://github.com/signalfx/tracing-examples/pull/114

@jpOlivo-uala Was it helpful? Have you succeeded?

@pellared the example was very helpful, I instrumented a golang function on Lambda following this example. Thank very much!


Fix broken links in docs

This PR fixes all the broken links in the docs.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@ac7e208). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage        ?   80.16%
=======================================
  Files           ?      120
  Lines           ?     6988
  Branches        ?        0
=======================================
  Hits            ?     5602
  Misses          ?     1386
  Partials        ?        0

Flag
Coverage Δ

unittests
80.16% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@ShreyaR Just fixed your comments.


Update java.md

In this pr, i updated the java.md to fit the current GRPC code, the old document is no longer available
Fixes #5093

@henta, remember to re-request review from reviewers for your latest update

@henta, remember to re-request review from reviewers for your latest update

Replaced by https://github.com/lightningnetwork/lnd/pull/6080 to speed up review process. Original commit author was preserved, thank you for your contribution.


k-fold cross-validation error

Hi timzatko,  i am currently working on a optimization project. I am using your tutorial as a start point but i am getting this error. I am new to ML , i looked web for a solution but i failed.
`clf = RandomForestClassifier(random_state=42)
nia_search = NatureInspiredSearchCV(
clf,
param_grid,
cv=5,
verbose=0,
algorithm='ba',
population_size=25,
max_n_gen=100,
max_stagnating_gen=10,
runs=5,
scoring='f1_macro',
random_state=42,

)
nia_search.fit(X_train, y_train)`
when i run this piece of code i got this error.
`/opt/anaconda3/envs/data-mining/lib/python3.8/site-packages/sklearn/utils/validation.py:70: FutureWarning: Pass scoring=f1_macro, n_jobs=None, refit=deprecated, cv=True, verbose=5, pre_dispatch=0, error_score=2*n_jobs, return_train_score=nan as keyword args. From version 1.0 (renaming of 0.25) passing these as positional arguments will result in an error
warnings.warn(f"Pass {args_msg} as keyword args. From version "
Any idea or comment how to solve this?
Versions of lib
sklearn-nature-inspired-algorithm 0.5.1
sklearn 0.24.2
Screenshots

Problem was version of sklearn-nature-inspired-algorithm 0.5.1 downgraded to 0.4.3. Problem solved.

Hi! It is fixed in 0.5.2.


Investigate ICDS environmental impact

What is the purpose of the work?
Evaluate the ICDS environmental impact and steps we can take to reduce our carbon footprint.
Inefficiencies such as:

serving 8MBs of search data

There will be greater value on focusing on components (rather than microsite), as that's where the efforts can be scaled.

Links to https://github.com/mi6/ic-ui-kit/issues/524

Duplicate - done


Problem with subclassing Window or WindowBase classes

I have been trying to subclass Kivy.core.window.Window or Kivy.core.window.WindowBase in order to create a custom window. But I've been ending up with errors.

the minute I import the Window class, it immediately launches a Window which gets hard for me to customize.

when I subclass Window or WindowBase and try to instantiate my custom window, it raises a type error
TypeError: new() takes 1 positional argument but 4 were given.
I certainly didn't supply 4 arguments anywhere.
If anyone faced such an issue and fixed it, I'm really in need of your help, I've tried going through the documentation a d source code back and forth but I'm still not seeing what I might be doing wrong.
Anyone to help, it'll be much appreciated.
Thanks

It's certainly going to be reaaaally inconvenient to do that, and it would be a big change for us to remove this automatic instanciation, do you really need to subclass the Window class? maybe there is a better solution for your problem.

If the purpose is simply to set the height, the .size attribute is not read-only like height is. Thus: Window.size = Window.width, 500

It's certainly going to be reaaaally inconvenient to do that, and it would be a big change for us to remove this automatic instanciation, do you really need to subclass the Window class? maybe there is a better solution for your problem.

The reason i wanted to subclass the Window or WindowBase class was that recently, one of the window settings was changed by a certain program on my laptop that every default window is launched in fullscreen mode with no easy way of changing the values. I actually do not even know how it happened, it i'm thinking maybe the default config file was changed or something.
Anyways, if their is anyway i could possible tweak window settings from my code, i would definitely  do that, but most times i create a window, it doesn't respond to toggling the fullscreen attribute from True to False.
i don't know if you have any advice on that

If the purpose is simply to set the height, the .size attribute is not read-only like height is. Thus: Window.size = Window.width, 500

Thanks, but i had noticed the height attribute was read only, i just left it in the screen shot for example purposes.
However my main problem is with the default fullscreen mode windows that kivy began creating everytime i launched a window.
i tried toggling the fullscreen attribute from False to True but still since the window was launched before receiving my new settings, it sticks to the old ones i guess (that's what i'm thinking).
And also it gets hard to manipulate window properties after it has been created. That's my main issue.

@ht.thomas: Did you tried to disable the fullscreen mode via Config by
adding at the begin of your main app python file (before you import
anything from Kivy/App/Window):
from kivy.config import Config

Config.set('graphics', 'fullscreen', '0')

See e.g. https://stackoverflow.com/questions/21891217/issue-setting-kivy-to-fullscreen
and https://www.geeksforgeeks.org/python-window-size-adjustment-in-kivy/
quoted from 2nd link:
Kivy has a configuration file which determines the default settings. In
order to change these settings, you can alter this file manually or use
the Config object.
Configuration options control the initialization of the App. In order to
avoid situations where the config settings do not work or are not
applied before window creation (like setting an initial window size),
Config.set should be used before importing any other Kivy modules.
Ideally, this means setting them right at the start of your main.py script.
Am Do., 12. Nov. 2020 um 00:38 Uhr schrieb ht-thomas <
<EMAIL_ADDRESS>
If the purpose is simply to set the height, the .size attribute is not
read-only like height is. Thus: Window.size = Window.width, 500
Thanks, but i had noticed the height attribute was read only, i just left
it in the screen shot for example purposes.
However my main problem is with the default fullscreen mode windows that
kivy began creating everytime i launched a window.
i tried toggling the fullscreen attribute from False to True but still
since the window was launched before receiving my new settings, it sticks
to the old ones i guess (that's what i'm thinking).
And also it gets hard to manipulate window properties after it has been
created. That's my main issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kivy/kivy/issues/7211#issuecomment-725745603, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA4U63W2BNJRAT53GA3T4ELSPMU77ANCNFSM4TR33EMQ
.

@ht.thomas: Did you tried to disable the fullscreen mode via Config by adding at the begin of your main app python file (before you import anything from Kivy/App/Window): from kivy.config import Config Config.set('graphics', 'fullscreen', '0') See e.g. https://stackoverflow.com/questions/21891217/issue-setting-kivy-to-fullscreen and https://www.geeksforgeeks.org/python-window-size-adjustment-in-kivy/ quoted from 2nd link: Kivy has a configuration file which determines the default settings. In order to change these settings, you can alter this file manually or use the Config object. Configuration options control the initialization of the App. In order to avoid situations where the config settings do not work or are not applied before window creation (like setting an initial window size), Config.set should be used before importing any other Kivy modules. Ideally, this means setting them right at the start of your main.py script. Am Do., 12. Nov. 2020 um 00:38 Uhr schrieb ht-thomas <<EMAIL_ADDRESS>…
If the purpose is simply to set the height, the .size attribute is not read-only like height is. Thus: Window.size = Window.width, 500 Thanks, but i had noticed the height attribute was read only, i just left it in the screen shot for example purposes. However my main problem is with the default fullscreen mode windows that kivy began creating everytime i launched a window. i tried toggling the fullscreen attribute from False to True but still since the window was launched before receiving my new settings, it sticks to the old ones i guess (that's what i'm thinking). And also it gets hard to manipulate window properties after it has been created. That's my main issue. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7211 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4U63W2BNJRAT53GA3T4ELSPMU77ANCNFSM4TR33EMQ .

Thank you so much. I think I've now understood it

I want the window to be transparent and the controls unaffected


Added runtime.slice for containerd runtime

Issue #, if available:
#1050
Description of changes:
This PR adds the runtime.slice and makes use of it when using containerd as the runtime as is recommended in the Kubernetes documentation.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done
I've built the AMI and test that containerd is now running under the runtime.slice .
[ec2-user@ip-10-52-14-250 ~]$ sudo systemctl status containerd
● containerd.service - containerd container runtime
   Loaded: loaded (/usr/lib/systemd/system/containerd.service; enabled; vendor preset: disabled)
  Drop-In: /etc/systemd/system/containerd.service.d
           └─00-runtime-slice.conf, 10-compat-symlink.conf
   Active: active (running) since Mon 2023-01-23 16:12:04 UTC; 5s ago
     Docs: https://containerd.io
  Process: 1311 ExecStartPre=/bin/ln -sf /run/containerd/containerd.sock /run/dockershim.sock (code=exited, status=0/SUCCESS)
  Process: 1309 ExecStartPre=/sbin/modprobe overlay (code=exited, status=0/SUCCESS)
 Main PID: 1314 (containerd)
    Tasks: 8
   Memory: 43.3M
   CGroup: /runtime.slice/containerd.service
           └─1314 /usr/bin/containerd

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

@cartermckinnon could you take a look at this and see if there is anything obviously wrong with the way I've configured containerd? I've tried overwriting the main unit file but it still uses the wrong cgroup. I don't have the infrastructure setup to build and test this myself and it might be worth trying it that way?

I've tried overwriting the main unit file but it still uses the wrong cgroup

You mean the containerd unit file, right? I modified the one on an AL2 instance (/usr/lib/systemd/system/containerd.service) to use Slice=runtime.slice and it looks correct to me:
> systemctl status containerd

● containerd.service - containerd container runtime
   Loaded: loaded (/usr/lib/systemd/system/containerd.service; disabled; vendor preset: disabled)
   Active: active (running) since Tue 2022-10-18 20:45:21 UTC; 5s ago
     Docs: https://containerd.io
  Process: 1090 ExecStartPre=/sbin/modprobe overlay (code=exited, status=0/SUCCESS)
 Main PID: 1122 (containerd)
    Tasks: 15
   Memory: 56.5M
   CGroup: /runtime.slice/containerd.service
           └─1122 /usr/bin/containerd

Can we add a dropin unit for containerd to set this?

@cartermckinnon this PR has the dropin file 00-runtime-slice.conf to do this. I was testing on an active EKS node so that might have been why it wasn't working correctly. Do you have automation in place to test this PR as based on your testing it should work?

@cartermckinnon have you had a chance to look at this again? It'd be good to get it working correctly.

@cartermckinnon would it be possible for you to get this tested or do I need to setup some infrastructure to test it myself?

@cartermckinnon I've now tested this and and would like to get it merged and released ASAP, is there anything else you need from me?
CC @bwagner5

@stevehipwell sorry for the radio silence -- this looks fine to me. I want to read through the k8s doc on this again to make sure I'm understanding the recommendations, but this should get merged by the end of the week.
Thanks for tackling it!

I'm not clear on the benefit of this without enabling the optional enforcement of KubeReserved/SystemReserved, I would guess some metrics are more accurate/fine-grained?

@cartermckinnon this is the documented way to set up Kubernetes with Containerd as the CRI. So that is the main benefit along with observability improvements.
It then also means that end users can decide to enforce kube reserved and/or system reserved by adding additional kubelet arguments.

@cartermckinnon I've made the suggested change, this should be good now.

LGTM, thanks @stevehipwell 🚀


add sample data

add some sample data to run streamDM

add iris.raff and hyperplane and randomtree data files


Add filters argument for image.list()

Added a simple filters=dict argument to your image.list() function.
It follows the same format as your container.list() function.

I didn't write the test codes for it since I haven't really studied your test codes yet. If you could tell me what is the best approach, I would implement it. I was thinking on the line of using docker.build(..., labels={"foo": "bar", ...}, ...) and listing out the images using docker.image.list(fitlers={"label": "foo=bar"}) and checking for the number to match. I looked into test_image.py, but couldn't fully understand how you would go about in an optimal way.

Thank you for the pull request! I'm on holidays right now but I'll take a look during the next days. I think it's a good idea to test using the labels but a simpler way could be to pull some images and filter by name. I'll take a look this week-end probably :)

@gabrieldemarmiesse Looking forward to it! Your project has been a lot of help, thank you so much!

I added a very small test, but it's enough to verify that the CLI invocation has no issues


Ownership of a brewingstand resets

The ownership of a brewingstand resets when a hopper tries to put items into a brewingstand.
Affected version: v4.15.0-devbuild
Serversoftware: Paper version git-Paper-20 (MC: 1.15)
other plugins: -none-
The environment was created just to test this bug with default configurations.
Steps to reproduce:

Place a brewingstand in the world.
Open the inventory of the placed brewingstand. The brewingstand will be registered.
Place a hopper next to the brewingstand facing to it.
Put any item into the inventory of the hopper.
Right click on the brewingstand multiple times.

Greetings.

You should disable ExploitProtections.Brew.PreventBrewingStandFillUps in generalConfig.

Thank you for your fast reply. I missed that option in the config. Maybe i am getting blind. Have a great day.


POC for testing

A small PR introducing unit testing for some modules.

@emjun do you mind taking a look at https://github.com/emjun/tea-lang/blob/c4b9e550ba8942477585305cab6f5e259f446a74/tea/api.py#L80-L83 ?
It seems like we create 'interval class' for 'ratio', is this expected?

@MaLiN2223 Thanks for catching that. I would expect creating a 'ratio' variable, too. I'm taking a closer look now.


Set LC_NUMERIC=C to avoid issues reading files

Related with this issue https://github.com/ignitionrobotics/ign-rendering/issues/101
Signed-off-by: ahcorde<EMAIL_ADDRESS>

@j-rivero to add tests.

We should address the underlying issue instead.


Move simple integration tests from JFR Test Framework to JUnit + Disable broken Custom War Packager integration tests

This change adds some unit tests which allow testing (and profiling) Jenkinsfile Runner without a heavy Jenkinsfile Runner Test Harness framework. "Hello world" test execution takes around 8 seconds on my machine with JDK11, mostly due to the extension indexing as discussed in #241

This change at least gets build to the demo stage.

The databound demo needs update of the core baseline:
[2020-05-10T00:11:21.685Z] [INFO] Scanning for projects...

[2020-05-10T00:11:24.202Z] [ERROR] [ERROR] Some problems were encountered while processing the POMs:

[2020-05-10T00:11:24.202Z] [ERROR] Non-resolvable import POM: Failure to find org.jenkins-ci.main:jenkins-bom:pom:2.150.2 in https://repo.jenkins-ci.org/public/ was cached in the local repository, resolution will not be reattempted until the update interval of repo.jenkins-ci.org has elapsed or updates are forced @ line 81, column 19

[2020-05-10T00:11:24.202Z]  @

I will merge this PR, because it pushes the build flow forward


Guidance for implementing IAsyncDisposable

It would be great if this documentation mentioned implementing IAsyncDisposable for asynchronous disposal and provided some guidance for how to extend the disposal pattern to include asynchronous disposal.
Related:

https://stackoverflow.com/q/58112716
dotnet/roslyn-analyzers#3675

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 572ef6c6-5066-4a14-76a0-c3fb4b62e604
Version Independent ID: 9c754da1-c234-fb12-580b-0fcf9ffe2c20
Content: Implement a Dispose method
Content Source: docs/standard/garbage-collection/implementing-dispose.md
Product: dotnet
Technology: dotnet-standard
GitHub Login: @gewarren
Microsoft Alias: gewarren

@ievangelist Do you want to take this one? It seems related to the work you did recently.

@IEvangelist Do you want to take this one? It seems related to the work you did recently.

Yes, I'll take it. Thank you

That's great!  Thanks so much @IEvangelist!  Very useful indeed.


How to import vue-paginate localy?

How to import vue-paginate localy?

Because you would like to only load vue-paginate when needed? This package is only about 9kb... It won't hurt to load it in main.js.

@shrue348 Could you please show me a quick example of this conflict?


withWebSocket does not report why errors occur, nor does it report when socket closed

https://github.com/valderman/haste-compiler/blob/master/libraries/haste-lib/src/Haste/WebSockets.hs#L62
This makes debugging a pain, because you know an error's occurred, but not which error.
(might implement this later if I can - how would the new function be named?)

Actually, there's a question. What's your policy on backwards-compatibility? Would it be acceptable to change the existing function signature?

As a rule, I'm trying to preserve backwards compatibility as much as possible. (Hence the counter-intuitive argument order of addChild and friends.) However, with 0.5 there's going to be some major breakage anyway from the GHC 7.10 transition, updated event API and other assorted "OK, this thing sucks, let's make it nicer while we're breaking stuff anyway" fixes. As such, pretty much any breakage which makes things nicer or more useful is OK for 0.5.
The important thing is that any breakage is very visible at compile time. Changes that require new type signatures are the best ones since they're pretty hard to miss. For changes to broken/annoying/inconsistent semantics that don't require a new type signature, it's probably best to introduce a new function with the new semantics and slap a deprecation warning on the old one.

The onerror event actually contains no error information at all. However, the onclose event does. The new WebSockets API provides a way to get at this information.


prisma-fmt-debian-openssl-1.1.x was not included into executable

When running prisma-client-rust I keep receiving the following error which prevents me from using this project.
> Downloading Prisma engines for Node-API for debian-openssl-1.1.x [========            ] 39%Error: File or directory<EMAIL_ADDRESS>was not included into executable at compilation stage. Please recompile adding it as asset or script.

I am running on Linux 5.13.0-35-generic #40~20.04.1-Ubuntu.
This error looks the same as prisma/prisma-client-go#449 but they seem to be struggling to debug it due to it being an intermittent issue. I have managed to make a Dockerfile here which reproduces this issue using prisma-client-rust but I am unable to get the same error when using prisma-client-go in a similar setup.

Does the Client set either PRISMA_QUERY_ENGINE_LIBRARY or PRISMA_MIGRATION_ENGINE_BINARY pointing to a file that contains the appropriate file prisma-fmt-debian-openssl-1.1.x? That should skip the download logic in the CLI.

If I use the following commands everything works. Thanks @janpio.
# Permission issue workaround -> Discussed below
sudo mkdir /snapshot
sudo chown -R $(id -u):$(id -g) /snapshot

# First CLI execution downloads the correct binary and throws the error. Send execution works correctly.
prisma-client-rust generate
export PRISMA_QUERY_ENGINE_LIBRARY=/snapshot/node_modules/prisma/node_modules/@prisma/engines/
prisma-client-rust generate

To fix this would it make sense for the prisma-client-rust CLI to determine if this file is needed, download it and set the environment variables or should a different version of the Prisma CLI be downloaded which includes the expected file.
It's also worth noting that the Prisma CLI is downloading the binaries to the /snapshot directory on my system. Writing files here is both undesired and also introduces permission issues for most Linux setups. Although this won't be an issue if prisma-client-rust is in charge of downloading the file.

That is generally a thing the Rust Client (which is modelled after how the Go Client works) should be doing. Seems for some reason it does not do that for you, leading to the suboptimal Prisma CLI included code for downloading to be triggered.
We also want to fix that /snapshot bug internally in the packaged CLI, but that is not a priority right now.


Eigen Include Error

In file included from /Users/TAS/PX4_src/sitl_gazebo/include/gazebo_multirotor_base_plugin.h:29:
/Users/TAS/PX4_src/sitl_gazebo/include/common.h:22:10: fatal error:
'Eigen/Dense' file not found
#include <Eigen/Dense>
^
1 error generated.
In file included from /Users/TAS/PX4_src/sitl_gazebo/src/gazebo_controller_interface.cpp:22:
/Users/TAS/PX4_src/sitl_gazebo/include/gazebo_controller_interface.h:23:10: fatal error:
'Eigen/Eigen' file not found
#include <Eigen/Eigen>
^
1 error generated.
Can be solved by updating the path to:  #include <eigen3/Eigen/Dense>.
Believe this was solved back in January, but the issue resurfaced today.

What is the exact diff in your local folder? Sorry about the regression - some well intended cleanup didn't apparently really work.

Lorenz,
The only thing missing was eigen3 before Eigen in the path.  I believe this
is the same issue that happened back in Jan (posted here:
https://groups.google.com/forum/#!searchin/px4users/eigen/px4users/3ttWk0GpwtU/9KTqh7-GFgAJ
), but I just forked that repository today to start working and had the
same issue with make.
After fixing the eigen issue I ran into the same optic flow sensor
follow-on issue as #4195, but removing Gazebo7 and installing 6 fixed the
issue.  Somewhere in your previous instructions they noted Mac users must
install Gazebo7, but I believe you've since removed that comment.
Thanks for all the great work on this SITL simulation.
-Traci.
On Wed, Apr 20, 2016 at 2:32 PM, Lorenz Meier<EMAIL_ADDRESS>wrote:

What is the exact diff in your local folder? Sorry about the regression -
some well intended cleanup didn't apparently really work.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/issues/4313#issuecomment-212571143

Can you please give me the output of git diff in Tools/sitl_gazebo? I don't understand what you changed.

Sorry it was unclear.  I did not make changes in Firmware/Tools/sitl_gazebo
Here is the output of git diff from ~/PX4_src/sitl_gazebo where I made the
changes:
diff --git a/include/common.h b/include/common.h
index 5d97a44..9ad9984 100644
--- a/include/common.h
+++ b/include/common.h
@@ -19,7 +19,7 @@
*/
-#include <Eigen/Dense>
+#include <eigen3/eigen/Dense>
#include <gazebo/gazebo.hh>
namespace gazebo {
diff --git a/include/gazebo_controller_interface.h
b/include/gazebo_controller_interface.h
index 8ae5c69..f29716b 100644
--- a/include/gazebo_controller_interface.h
+++ b/include/gazebo_controller_interface.h
@@ -20,7 +20,7 @@
#include <boost/bind.hpp>
-#include <Eigen/Eigen>
-Traci.
On Thu, Apr 21, 2016 at 1:53 AM, Lorenz Meier<EMAIL_ADDRESS>wrote:

Can you please give me the output of git diff in Tools/sitl_gazebo? I
don't understand what you changed.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/issues/4313#issuecomment-212771393

Ok, pushed something equivalent to master.


[iwyu] chttp2

@markdroth

Did you do this manually? Please make sure that none of the test failures are caused by this PR. Would this require to be cherrypicked?


Improvements to deprecated diseases and therapies

We now allow admins to manually deprecated diseases and therapies in the admin console and exclude deprecated entities from our typeaheads. However, there are a few improvements we should make on top of this:

We should visually show that a disease/therapy has been deprecated on its summary page
Tags should be styled to reflect that these items are deprecated
We need to double check our validation and our typeahead logic because I see entities in the database with linked accepted/submitted eids and aids, which the current logic should've prevented. E.g. disease 3461
Maybe there needs to be some sort of flagging job for eids/aids with deprecated diseases/therapies

PR #1047 implemented the consistent tag styling


Feature Request: Pass parameters to section / partial

It would be great to be able to add parameters to a section or partial similar to Dust.js's implementation.
Data:
{
   "name": "root",
   "anotherName": "root2",
   "A":{
      "name":"Albert",
      "B":{
         "name":"Bob"
      }
   }
}

Setting Strings
Template:
  {{#A.B foo="Hi" bar="good to see you"}}
      {{foo}} {{name}} {{bar}}
  {{/A.B}}

Output:
Hi Bob good to see you

Other Previously Defined Values
Template:
  {{#A.B foo=A.name bar=anotherName}}
      {{foo} {{name}} {{bar}}
  {/A.B}

Output:
Albert Bob root2

Combined with setting partials dynamically this would allow for a lot of really great componentized implementations.

Hey guys, I finding this feature to be really slow on data updates. Or, maybe I've gone a little crazy with it.
I have a div-based table setup.
{{#each groups}}
{{>group { like 10 keys passed } }}
{{/each}}
inside group
{{#each .groupItems}}
{{>item { like another 10 keys passed } }}
{{/each}}
in item:
{{#each item.field}}
{{> field { pass another 10 or more keys } }}
{{/each}}
Updates can take like 5 seconds or more. Trying to combine the variable updates.
Is this due to the template scoping? I notice the scope paths get giant (like enough to fill up my entire console log when there's an error). Should I go back to simply using the inherited scope like before?

@clintonskakun suggesting opening a different issue for this so we can mark it under performance.

What @fskreuz said, but as a brief response here, the problem is that you're creating lots of computations (object literal expressions) that are getting set as context in each partial. Direct access would be much more efficient, and using aliases would probably be pretty close in performance to direct access e.g. {{#each groups as group}}{{>group some.value as key, other.thing as otherKey}}{{/each}} where group, key, and otherKey are relatively quick to fetch and keep in sync with the model in the group partial.

@evs-chris Thanks for the tip. Yeah the literal computations were creating some serious overhead. Swapping it out for the aliases made a giant improvement. Where it'd 3-5 seconds to complete now does it in like <500ms. Thanks again.


Spyglass

There is a problem that spyglass with custom texture in itemframe is displayed incorrectly, and in the hand looks like a default spyglass.
Images:
https://imgur.com/hfhoZ2W
https://imgur.com/aJutqq5
Thank you in advance!

Duplicate of #137


printing ActiveRecord object issue

Hi,
It seems there is an error with printing ActiveRecord objects (rails 2.3.5):
Could you give it a look plz?
Thanks!
ArgumentError: wrong number of arguments (1 for 0)
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:42:in red' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:42:in send'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:42:in colorize' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:53:in awesome_self'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:26:in format' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/inspector.rb:97:in unnested'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/inspector.rb:64:in awesome' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:98:in awesome_hash'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:286:in indented' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:97:in awesome_hash'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:96:in map' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:96:in awesome_hash'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:25:in send' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:25:in format'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/inspector.rb:97:in unnested' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/inspector.rb:64:in awesome'
... 5 levels...
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:52:in awesome_self' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:26:in format'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/inspector.rb:97:in unnested' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/inspector.rb:64:in awesome'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:140:in awesome_object' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:286:in indented'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:139:in awesome_object' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:130:in map'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:130:in awesome_object' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:52:in awesome_self'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/formatter.rb:26:in format' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/inspector.rb:97:in unnested'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/inspector.rb:64:in awesome' 	from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/core_ext/kernel.rb:10:in ai'
from /home/konstantin/.rightscale_bundle/right_site/ruby/1.8/bundler/gems/awesome_print-2e75a163874a/lib/awesome_print/core_ext/kernel.rb:15:in `ap'

it was something like:
x = Product.find 100
ap x  # <--- exception here

Could you please double check with the latest 1.0.1?

Hi Kostya,
Good catch! :-) It's a bit weird use case but nevertheless it should work without glitches. Looks like:
216: a.reject! { |name| !name.is_a?(Symbol) && !name.is_a?(String) }
is a cleaner fix (just get rid of any non-method garbage). I am going to add a spec and make it part of 1.0.2 release.
Спасибо за находку :-)
Michael

Privet Misha
It is a very cool idea to display object methods in the way you do, but I'm not sure it is good to throw things out of an Array.
Lets say there is a code (don't ask my what is the use case for it ;) ):

  m = 0.methods
  m << 1
  ap m # oops... everything but 1 is displayed.
  pp m # 1 is there

This may make a debugging nightmare for someone who does not know about the trick..
I like the idea of displaying 'WTF?' notice much better.
But it is up to you ;)

OK, sure, it makes more sense to show WTF rather than strip it ;-)

Спасибо!

Just pushed 1.0.2 to Rubygems

спасибо!


Add run configurations

Is your feature request related to a problem? Please describe.
I am a long-time user of Jetbrains IDEs and I am trying Lapce because it performs better and is FOSS. But, I find myself missing Jetbrains-style run configurations.
Describe the solution you'd like
I would like to see two files, a run_configurations.[toml|yml|json|whatever] and another local_run_configurations file (with the same format). Two files can be present to allow committing some configurations for other developers, and having a .gitignored set for local-only use.
Each run configuration should specify one or more commands to run, other configurations that run first, and have its output parsed usefully (meaning if it is, for example, a cargo command that outputs an error with a line number I want to be able to click on it  and jump to that code). Additionally, a key combination should be present to run the last run configuration and a drop down box to select others to run.
Describe alternatives you've considered
Right now I just use the integrated terminal to run things, but this is a bit more tedious than having a simple key combination and a bit less organized than having specific run configurations.

An example of what the configurations could look like is this (I used YAML since that's my personal favorite but it does not matter)
run:
  commands:
    - cargo run
  run_first:
    - check
  options:
    - multiple_run # do not stop the last invocation when starting a new invocation
check:
  commands:
   - cargo check

This is already implemented

I couldn't find anything about that in the docs, UI, or via web search. Maybe I'm missing something obvious, but could you link me to the documentation for it?
On October 30, 2023 8:55:27 PM CDT, Jakub Panek @.***> wrote:

This is already implemented
--
Reply to this email directly or view it on GitHub:
https://github.com/lapce/lapce/issues/2725#issuecomment-1786313358
You are receiving this because you authored the thread.
Message ID: @.***>


AdBlock plus breaks video playback

At least in Firefox, AdBlock plus breaks the video playback. Even with the fallback which catches the error of the blocked ad file, the video just shows up as a black screen.

This seems to be not an issue anymore with the latest version combined with the latest video.js, so closing this for now.


fix(webpack): optimize bundle size. Fixes MEMB-758

before:

after:

this should reduce queries to the frontend, as chunks are disabled (well most of it, I didn't figure out how to disable json chunks).

hm, it does work locally but doesn't in docker in CI. will investigate.

works now

@WikiRik can you check this out?

:tada: This PR is included in version 1.0.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Make the user's name a link to edit themselves

It's quite a common use case, at least for GOV.UK developers, to want to change their own permissions to test some permission-based feature in an app, which involves going to the user section and searching for their user record. If they have to do this multiple times, it's tedious and introduces the risk that they'll change permissions for someone else by mistake.
The original destination for this link was to the Signon root page: this is consistent with other apps, where it makes sense to link through to Signon; when you're in Signon already, this isn't particularly useful, especially when the "GOV.UK Signon" link in the header takes you there already.
The logic to determine the link target depends on whether the user has permission to edit themselves. As the logic currently stands, every user in the system has permission to edit themselves to at least some extent, but we shouldn't assume this will always be the case.

@fofr: I suspect you may have Opinions on this.

I like this change very much :+1:

Fun fact:  On preview, for a non-admin user, /users/<n>/edit will work for any value of n, and let you edit yourself.  This may be a bug from the pundit changes. /cc @vinayvinay

This makes me happy; I have often wanted this :+1:


[8.x] Changing the dump and restore method for a PostgreSQL database

PR related to issue #34281

I wasn't able to reproduce this issue so don't feel comfortable changing the code at this time. Need more feedback from Pgsql users as to specifically what is happening.

No problem

PgSQL user here.
I see no problem with the PR and in fact would also argue it's more idiomatic to use -Fc (performance) and not name it .sql, because it simply isn't.

@mfn @d-stephane ever since this PR Postgres schema dump has been totally broken to be honest.
First, the migration data is never stored in the dump because this entire method no longer works:

It doesn't work because obviously this binary dump doesn't include SELECT statements it can parse out. This causes the subsequent migrations to break because Laravel thinks it always needs to reload the state because the migrations table is empty.

I have created a new PR to try to fix this: https://github.com/laravel/framework/pull/35018

I just tested, it works very well :)


Provision for Shake Sample Fails with stderr maxBuffer exceeded on Windows

During task deploy, errors occur indicating some sort of stderr, however, maxBuffer error is shown, and nothing about what the error is.
To Repro:
Windows 1709 Pro (Fall Creators Update)

run latest (devkit_install_win_<IP_ADDRESS>.zip) dev kit install.
Firmware on board is 1.2.0
Open Visual Studio Code & Plugin Card
Choose the ShakeShake Project.
Run the provision task

During provision task - finally see the below, and then it just is stuck.
Executing task: node "C:\Users\cicorias\azure-board-cli\out\cli.js" provision .bin <

  - checking pre-conditions of task: node.js version
  V node.js version: v7.2.1
  - checking pre-conditions of task: azure cli version
  V azure cli version: 2.0.21
  - checking pre-conditions of task: subscription
? What subscription would you like to choose? CSE NYC Tyrell Team Subscription (b00a4572-2115-4d17-a2e5-b83326ab371b<EMAIL_ADDRESS>  V subscription: b00a4572-2115-4d17-a2e5-b83326ab371b
  - checking pre-conditions of task: azure cli iothub
? Which Resource Group would you like to choose? Create new...
? Resource Group Name:  shawniottesting
Creating resource group [shawniottesting-group-acd0] ...
Create resource group [shawniottesting-group-acd0] Succeeded.
? IoT Hub Name:  cicorias
  V azure cli iothub: {"iotHubName":"cicorias-iothub-acd0","subscription":"b00a4572-2115-4d17-a2e5-b83326ab371b","resourceGroup":"shawniottesting-group-acd0"}
  - checking pre-conditions of task: function app
  V function app: function app name: cicorias-iothub-acd0-shakea3c0
  - checking pre-conditions of task: ARM template deployment
-   X ARM template deployment: Unexpected error when executing "C:\\Program Files (x86)\\Microsoft SDKs\\Azure\\CLI2\\wbin\\az.cmd" group deployment create --resource-group shawniottesting-group-acd0 --template-file ".bin\azuredeploy.json" --parameters "{\"iotHubName\":{\"value\":\"cicorias-iothub-acd0\"},\"iotHubSku\":{\"value\":\"F1\"},\"iotHubCapacity\":{\"value\":1},\"iotHubExisted\":{\"value\":\"\"},\"functionAppName\":{\"value\":\"cicorias-iothub-acd0-shakea3c0\"}}" : stderr maxBuffer exceeded. Error: stderr maxBuffer exceeded
    at Socket.onChildStderr (child_process.js:283:14)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at Pipe.onread (net.js:551:20)
(node:26264) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Unexpected error when executing "C:\\Program Files (x86)\\Microsoft SDKs\\Azure\\CLI2\\wbin\\az.cmd" group deployment create --resource-group shawniottesting-group-acd0 --template-file ".bin\azuredeploy.json" --parameters "{\"iotHubName\":{\"value\":\"cicorias-iothub-acd0\"},\"iotHubSku\":{\"value\":\"F1\"},\"iotHubCapacity\":{\"value\":1},\"iotHubExisted\":{\"value\":\"\"},\"functionAppName\":{\"value\":\"cicorias-iothub-acd0-shakea3c0\"}}" : stderr maxBuffer exceeded. Error: stderr maxBuffer exceeded
    at Socket.onChildStderr (child_process.js:283:14)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at Socket.Readable.push (_stream_readable.js:134:10)
    at Pipe.onread (net.js:551:20)
(node:26264) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
|

It seems ARM deployment failed on Azure side. Could you please check deployment log detail?
To find deployment log, do as following:

The deployment during storage account provision had three retries but eventually all succeeded. In the end, the deployment was 100% pass.
I suspect during the retries errors collected and blew out the stderr buffer.
Since then no further failures.
You can close as its working now, but it is choking in this situation. Azure status had some storage issues today on creation intermittent failures.

Thanks for your feedback. Then I will close this issue. Please feel free to open a new issue if you have any other questions.


.NET Core 2.1.1 released to nuget but no SDK/Runtime so error on run in VS.net

Where is the SDK for .NET Core 2.1.1?  You guys shouldn't be releasing packages to nuget until updates are ready on dot.net.

Exactly the same problem here. Why are the 2.1.1 packages even being offered to a site that's targeting 2.1.0 if they're just going to break it?
At least the new project file format makes it easier to downgrade, since you can't even do that from the package manager within Visual Studio.

Following steps allowed me to get going on Win x64 platform:

Remove previous 2.1 sdk installation
Install early access SDK from here: https://github.com/dotnet/versions/tree/7a833dddfddc27f2074b755b94234a25b9757637/build-info/dotnet/product/cli/release/2.1

Following steps allowed me to get going on Win x64 platform:

Remove previous 2.1 sdk installation

Install early access SDK from here: https://github.com/dotnet/versions/tree/7a833dddfddc27f2074b755b94234a25b9757637/build-info/dotnet/product/cli/release/2.1

Changed version of docker images to explicitly reference 2.1.301 version
e.g. FROM microsoft/dotnet:2.1.301-sdk AS build

@emasyakin-softheme Thanks.
I ended up using the version from here https://github.com/dotnet/versions/tree/master/build-info/dotnet/product/cli/release/2.1 which appears to be the RTM version anyway.
No need to uninstall previous SDK versions.
Just wish the ASP.NET Core team would get their act together with this kind of stuff.... and don't even get me started on the messed up versioning thats floating around the entire ecosystem.

That's still the preview release.  If you install it you'll have to do the purge.

Pretty sure that isn't the preview. The version certainly doesn't indicate it is: 2.1.301. I'm up and running with no purge required.

Look at the file name you posted and tell me if it's the preview....  You WILL need a purge when the real final version is released.

Assuming nothing changes, then that build will indeed be the final build. (see notes here: https://github.com/aspnet/Home/wiki/.NET-Core-2.1.1-Early-Access-Downloads)
The final SDK version does appear to be available to download - just not published on the front-facing websites. For example, VSTS will happily download and use the full SDK if asked from here: https://dotnetcli.azureedge.net/dotnet/Sdk/2.1.301/dotnet-sdk-2.1.301-win-x64.zip

Is there a new date for the release of 2.1.1 related SDK / Runtime?
The last announcement with date is this: https://github.com/aspnet/Home/wiki/.NET-Core-2.1.1-Early-Access-Downloads (June 19th)

Still the same preview.

The 2.1.1 deployment is still in progress, please use 2.1.0 in the meantime.

Any predictions? Today, Tomorrow, in a Week?
It's because i'm on the way to port 2.0 to 2.1 and the plan was to wait and to use 2.1.1, now it depend on the estimated release date

Looks like it's out now:

Damian Edwards:
#dotnetcore 2.1.1 SDK download is now live!! Thanks everyone for your patience as we worked through the deployment issues the last few days
https://twitter.com/DamianEdwards/status/1009932641460580352

Woot!


Metadata DB Integration

ScholarSphere will be the source for Open Access copies of journal article, with the Metadata DB having a listing of all citations for articles by PSU authors. When someone uploads an OA article to ScholarSphere, we need a way to provide a link to that article to the Metadata DB so it is aware there is an OA copy.
-check for embargoes when uploading a document (for that journal with open button)
-send MDDB a notification that there is an OA copy of a journal article

Is this 4.1 feature?


Update CMake badge

📋 Description
Initially I've opened the issue on simple-icons, but they redirected me to open it here. Basically I want to request the CMake logo to be updated to include color, similar to the example of Gitlab
🔗 Data

Found at: https://cmake.org/about/
🎤 Motivation
Default monotone color is hard to parse

Hello.
We haven't actually done it yet, but we decided a while back that our direction of travel is we're going to delete the remaining custom named icons and provide simple-icons as the only icon set.
See discussion at https://github.com/badges/shields/issues/9476
As such, it doesn't make sense for us to take on new custom named icons now.
That said, you can use any SVG you want on a badge. There's docs at https://shields.io/docs/logos but if you wanted to use the icon you've posted, you could do it like this:

https://img.shields.io/badge/cmake-icon-blue.svg?logo=data:image/svg%2Bxml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGRhdGEtbmFtZT0iTGF5ZXIgMiIgdmlld0JveD0iMCAwIDU0NS41IDU0NS45Ij48cGF0aCBkPSJNNTQ2IDUzNCAyODIgOWwzOSA0MzQgMjI1IDkxeiIgZGF0YS1uYW1lPSJyZWQgcmlnaHQiIHN0eWxlPSJmaWxsOiNmMzI3MzU7c3Ryb2tlLXdpZHRoOjAiLz48cGF0aCBkPSJNNTI1IDU0NiAxNzAgNDAzIDEgNTQ2aDUyNHoiIGRhdGEtbmFtZT0iZ3JlZW4gYm90dG9tIiBzdHlsZT0ic3Ryb2tlLXdpZHRoOjA7ZmlsbDojM2VhZTJiIi8+PHBhdGggZD0iTTI2MyAwIDAgNTIybDI4OC0yNDRMMjYzIDB6IiBkYXRhLW5hbWU9ImJsdWUgbGVmdCIgc3R5bGU9ImZpbGw6IzAwNjhjNztzdHJva2Utd2lkdGg6MCIvPjxwYXRoIGQ9Im0yOTEgMjk5LTEwNSA4OSAxMTcgNDgtMTItMTM3eiIgZGF0YS1uYW1lPSJncmF5IGNlbnRlciIgc3R5bGU9ImZpbGw6I2RjZTNlYztzdHJva2Utd2lkdGg6MCIvPjwvc3ZnPg==


Datepicker input box not showing

Hi,
I need some help.  The input box doesn't seem to be appearing.  I am not using app.js as it gives me problem with Buefy.  No error message on the debugging console.  Anything I did wrongly? Thanks.
`<!doctype html>

`

Sorry, I have no idea what Bueify is. Maybe best if you ask there.


Lost game data upgrading to 1.0

(Thanks for providing a snap for this game)
Saved game data, settings are lost on upgrading to version 1.0.
Reverting the snap brings them back.
I'm not sure which files need to be retained, but I think they are:
$HOME/snap/supertuxkart/<snap-revision>/.config/supertuxkart/<game-version>/*

Oddly, the name of the folder <game-version>, for the previous version, 0.9.3, is "0.8.2". Perhaps it is configuration data that is versioned, as the name of the folder for 1.0 is "config-0.10", so instead, for config data, the path should be:
$HOME/snap/supertuxkart/<snap-revision>/.config/supertuxkart/<config-version>/*

Maybe it was intended for save data to be lost, seeing as 1.0 is a major new version. I can't confirm.
Please close if this is the case. Sorry for taking a bit of your time with this issue ☹.


Response Content-Type is always "application/json"

Fix for https://github.com/visualeyes/halcyon/issues/51
Since the ContentType of the new OutputFormatterWriteContext is not set, the
JsonOutputFormatter defaults to "application/json".  Explicitly set that to
the type negotiated prior to invoking WriteAsync.

Cheers


killed and exit R

Hi, Thanks for your developping ALLCatchR, but when I play with it, it always report messages "Killed" and exit
even I played with your default data such as
....
allcatch(Counts.file = NA, ID_class = "symbol", sep = "\t")
test counts loaded...
0  of  15745  genes not found
ML prediction...
Classification using ssGSEA...
Killed
...

Yes, I work in our HPC cluster. I also agree that R is killed by OS.  I just test it in a login node, so the memory is not limited in principle.  Additionally, cmd allcatch(Counts.file = NA, ID_class = "symbol", sep = "\t") is very simple, and it seems only play with the demo count matrix. So, I do not think this is memory issue.

Thanks for the clarification!
Just to be sure, did the error also appear when you call
library(ALLCatchR)
allcatch()

?
Since it seems to be OS-related, it is hard to help here without any log files. Maybe you can have a look at something like (1) and/or get in contact with the admins from your cluster?


ClientException: No data returned for comment

hi, I'm trying to retrieve some comments with a given id. Some of the ids give this ClientException: no data returned
example below
reddit =praw.Reddit(client_id=client_id, client_secret=client_secret, user_agent=user_agent, check_for_async=False)
sub = reddit.comment(id='d966r70'); print(sub.body)
/usr/local/lib/python3.7/dist-packages/praw/models/reddit/base.py in getattr(self, attribute)
32         """Return the value of  'attribute'."""
33         if not attribute.startswith("_") and not self._fetched:
---> 34             self._fetch()
35             return getattr(self, attribute)
36         raise AttributeError(
/usr/local/lib/python3.7/dist-packages/praw/models/reddit/comment.py in _fetch(self)
198
199         if not data["children"]:
--> 200             raise ClientException(f"No data returned for comment {self.fullname}")
201
202         comment_data = data["children"][0]["data"]
ClientException: No data returned for comment t1_d966r70

I think that's normal if the comment doesn't exist anymore. Like if it was deleted.

That's strange, the deleted ones returned [deleted]
Thanks for replying

Could you provide a link to said somment?

Would you mind providing the following info:

PRAW version
OS