Feature Request: Add changeset execution time to database changelog table

Search first

[X] I searched and no similar issues were found

Description
I believe it would be beneficial to developers to be able to identify changesets that take a long time to run. To this end, I think a new column should be added to the database change log table that is execution_milliseconds.
In looking at liquibase-standard/src/main/java/liquibase/changelog/ChangeSet.java, a startTime and stopTime are already grabbed and used to display the execution time in milliseconds in the log.
So this change would be minimal in just exposing that data through the class and logging it in the database changeset tabl (and adding a column to the table to hold the information).
I am happy to do a PR, just wanted to make sure this sounded acceptable to the team before I did the actual coding!
Steps To Reproduce
N/A, feature request
Expected/Desired Behavior
Described above
Liquibase Version
No response
Database Vendor & Version
No response
Liquibase Integration
No response
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
No response
Additional Context
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR (Thank you!)

Nice ideia. +1

Hi @jasonlyle88,
Glad to see you around again. Hope you and your family are doing very well. How's the baby?
I think this could be beneficial for us when we start addressing some performance issues we still have in our backlog. So I would be keen if we move forward with this. Just out of curiosity is there any use case you have in mind or something in some project you are working on that motivates you to have something like this?
On the other hand, I guess you might see it as well but I was wondering whether we can make use of dateexecuted value we are already storing in the databachangelog table. However, I think it would make changeset execution time calculation more complex.

Hey @MalloD12!
Thanks! My wife and baby girl are doing wonderful, thanks for asking! My daughter is so close to getting ready to walk... so I have a feeling life is about to get a lot more interesting 🤣
For my motives, we've notice a slow down in a project install that is run by liquibase. There are several factors we are taking into account (such as a recent hardware architecture change). But it made me want to have some hard data on times for our changesets. Allowing us to see if any individual change sets are taking more time than others, are table creations/package creations/etc all comparable times within a given object type or does something specific stand out? In the day to day... probably not a super useful metric. But, I have a feeling when it is useful, it could be very useful!
As fare as the dateexecuted field, It could be used. However, the first changeset to execute and the last changeset to execute would not have a good method based on the dateexecuted data available in the table. It would also, as you said, be slightly more difficult to do (have to go back to the previous record inserted after every execution to be able to figure out the delta). Also, calculating via the delta in dateexecuted across records introduces time it takes from the end of the previous changeset's execution and everything liquibase does to start the next execution.
For all of these reasons, I decided it would be a better process to record a stop and start instant based on the actual execution starting and stopping in the Java code.
And, as you pointed out, internally this gives you a better resource to access the execution time!
I've actually already fully implemented my solution in MR #5595, and overall it is pretty simple!

Glad to know everything is going well and the baby is growing up very well. Seeing she is almost walking makes me see we haven't talked for a very while. Definitely things will start being much more fun soon :D.
Cool, that makes sense and I agree with you. Just wanted to know what was your motivation for raising this issue and implementing the fix for it.
Yeah, I saw the code changes and at first glance, they look well to me. We will be looking at it in more detail next sprint (which it could be next week).
Thanks,
Daniel.


gridlstm

Hello,
1- where can find an example for GRIDLSTM(2D) or multi_diagonal . i search in net but not found.
2- known that tensorflow support from keras . how can insert a tensorflow layer in keras .
THANKS

I think it's the other way around; Keras may be implemented in TensorFlow. I haven't heard of TF in Keras yet. @jeansely

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


Vote the fee TX error

Describe the bug
Tried to vote the fee on EOSWAX and EOSVIG with input "1" and received an error
To Reproduce
Steps to reproduce the behavior:

Go to Vote the Fee
Click on EOSWAX
Input "1"
See error

Expected behavior
Vote the fee for pool EOSWAX or EOSVIG
Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

Device: Iphone X
OS: iOS
Browser Safari
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@edgar-eoscostarica  can you reproduce this error?


How to move to a specific tab index  on button click ?

Hi,
I have a collectoin view and when i click on one item i need to open another view controller with  GUITabPagerViewController  and show corresponding tab. At this moment always it opens first tab.
Is there any solution for this?

(void)selectTabbarIndex:(NSInteger)index;
(void)selectTabbarIndex:(NSInteger)index animation:(BOOL)animation;

[self selectTabbarIndex:20];
[self selectTabbarIndex:20 animation:YES];


Swoole\Table::someMethod table is not created or has been destroyed

What did you do? If possible, provide a simple script for reproducing the error.

Use Swoole\Table in a connection tracking object property.

What did you expect to see?

Swoole table should not go away

What did you see instead?

**MOST** time it does work. But from time to time I see the following error:

PHP Fatal error:  Swoole\Table::get(): table is not created or has been destroyed in /var/www/apps/frontend/websocket/WsConnections.php on line 164
Symfony\Component\ErrorHandler\Error\FatalError^ {#117
  #message: "Error: Swoole\Table::get(): table is not created or has been destroyed"
  #code: 0
  #file: "/var/www/apps/frontend/websocket/WsConnections.php"
  #line: 164
  -error: array:4 [
    "type" => 1
    "message" => "Swoole\Table::get(): table is not created or has been destroyed"
    "file" => "/var/www/apps/frontend/websocket/WsConnections.php"
    "line" => 164
  ]
}

or

PHP Fatal error:  Swoole\Table::rewind(): table is not created or has been destroyed in /var/www/apps/frontend/websocket/WsConnections.php on line 404

What version of OpenSwoole are you using (show your php --ri openswoole)?

openswoole

Open Swoole => enabled
Author => Open Swoole Group<EMAIL_ADDRESS>Version => 4.11.1
Built => Sep 21 2022 11:26:35
coroutine => enabled with boost asm context
epoll => enabled
eventfd => enabled
signalfd => enabled
cpu_affinity => enabled
spinlock => enabled
rwlock => enabled
openssl => OpenSSL 1.1.1n  15 Mar 2022
dtls => enabled
zlib => 1.2.11
mutex_timedlock => enabled
pthread_barrier => enabled
futex => enabled
async_redis => enabled

Directive => Local Value => Master Value
swoole.enable_coroutine => On => On
swoole.enable_library => On => On
swoole.enable_preemptive_scheduler => Off => Off
swoole.display_errors => On => On
swoole.use_shortname => On => On
swoole.unixsock_buffer_size => 8388608 => 8388608

What is your machine environment used (show your uname -a & php -v & gcc -v) ?

Linux dev01 5.10.0-18-amd64 #1 SMP Debian 5.10.140-1 (2022-09-02) x86_64 GNU/Linux
PHP 8.1.10 (cli) (built: Sep 18 2022 12:52:19) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.10, Copyright (c) Zend Technologies
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/10/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa:hsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian 10.2.1-6' --with-bugurl=file:///usr/share/doc/gcc-10/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-10 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-10-Km9U7s/gcc-10-10.2.1/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-10-Km9U7s/gcc-10-10.2.1/debian/tmp-gcn/usr,hsa --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu --with-build-config=bootstrap-lto-lean --enable-link-mutex
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 10.2.1 20210110 (Debian 10.2.1-6)

It could be caused by lifecycle management of table, so please provide minimum code to reproduce the issue.

That error happens randomly. Haven't seen it since yesterday and I have absolutely no idea how to reproduce it reliably.
I use swoole/table for connection<->member login tracking on an object property. So I'm passing that object almost everywhere in my application which is websocket context:

server->onStart for initialization
server->onOpen when member connects
server->onMessage when members do actions in chat
server->onClose when members log out

//constructor
        $this->connections = new Table(self::MAX_CONNECTIONS_UNAPPROVED);
        $this->connections->column('fd', Table::TYPE_INT);
        $this->connections->column('state', Table::TYPE_STRING, 16);
        $this->connections->column('member_id', Table::TYPE_INT);
        $this->connections->column('user_json', Table::TYPE_STRING, 2048);
        $this->connections->create();

        $this->loggedInMembers = new Table(self::MAX_LOGGED_IN_MEMBERS);
        $this->loggedInMembers->column('member_id', Table::TYPE_INT);
        $this->loggedInMembers->column('connections', Table::TYPE_STRING, 128);
        $this->loggedInMembers->create();

At one place I need to search the table, I'm not sure if this may be causing some trouble:
for ($this->loggedInMembers->rewind(); $this->loggedInMembers->valid(); $this->loggedInMembers->next()) {
            //only calling $this->loggedInMembers->current() in here
}

Any advice/hint appreciated. I will report back when I have new information.


Price modifers should be language-aware

In both cart and order modifiers, there should be a way to make the label part display in a multilingual fashion. Right now, using gettext works, but the result of the gettext call gets saved in the database.
Therefore another user seeing the same order will see the label as translated in the original language.

Closed. Please check version 0.9.
They now are multilingual.


Fix CheckMap pass target handling

Summary
In the recently merged 5672c70649b4f83a6c7146c68a6a543d4a3908fd the CheckMap transpiler pass had issues when handling some Target inputs (which was added as a supported type in that PR). These issues were actually pointed out in code review during #9263 but the follow up slipped through. This commit makes the required fixes and also updates the signature of the CheckMap to match the other changes made in #9263.
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 12 (100.0%)  changed or added relevant lines in 2 files are covered.
12 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.02%) to 85.407%

Files with Coverage Reduction
New Missed Lines
%

qiskit/circuit/tools/pi_check.py
1
91.23%

qiskit/pulse/library/waveform.py
3
91.67%

crates/accelerate/src/vf2_layout.rs
8
86.44%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
67646

Relevant Lines:
79204

💛  - Coveralls

Oh yeah, I missed that comment on the second review because GitHub had helpfully hidden it behind the "show more conversations" button...  Whoops!


Online Screen Sharing

I thought that cool feature will be option that bot will connect to the voice channel and it will be giving a full screen sharing of victims computer. Is that possible to add to program ?

We are using a discord bot. Discord bots can't livestream. But we could maybe do something similar to the recordings, just as a screen capture.


Make upload process clearer.

Sitting there doing nothing is probably the absolute worst thing we could do. People are likely to think their internet is slow and try to upload again. (See #81).
Contrast this to GitHub's approach when forking large repositories:

When forking a large repo, three things happen:

You're immediately redirected to the correct place.
A message tells you something is going on.
It refreshes automatically when it's read.

Number 3 will be too hard for us to do right now. But we need to tackle 1 and 2.

That's the right approach.
What is the correct place isn't ready yet? Should we establish some form of file-based synchronization (since we don't have a database) that would mark a folder as containing fully processed repo?

Yeah, I think we should place a file called write.lock inside the SB_Files directory we're processing. (I think this is what Lucene does)
If the file exists, we'll say that someone is currently processing this repository. Then we can display a temporary page like GitHub does.
If the file doesn't exist, we will return the repository as usual.

This has been fixed in #87


brotli:x64-linux build failure

Host Environment

Archlinux (up to date as of 02/11/2020)
Compiler: gcc (GCC) 10.2.0

To Reproduce
Steps to reproduce the behavior:
./vcpkg --triplet x64-linux install cairo
Failure logs
20-11-02 18:07:38 abique@knot:~/d/vcpkg git:master> ./vcpkg --triplet x64-linux install cairo
Computing installation plan...
The following packages will be built and installed:
  * brotli[core]:x64-linux
  * bzip2[core]:x64-linux
    cairo[core]:x64-linux
  * dirent[core]:x64-linux
  * expat[core]:x64-linux
  * fontconfig[core]:x64-linux
  * freetype[bzip2,core,png]:x64-linux
  * libiconv[core]:x64-linux
  * libpng[core]:x64-linux
  * pixman[core]:x64-linux
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-linux...
Starting package 1/10: brotli:x64-linux
Building package brotli[core]:x64-linux...
Could not locate cached archive: /home/abique/.cache/vcpkg/archives/d4/d4e29d565a5af427af69da25079f3fe8be3f0803.zip
-- Using cached /home/abique/develop/vcpkg/downloads/google-brotli-e61745a6b7add50d380cfd7d3883dd6c62fc2c71.tar.gz
-- Cleaning sources at /home/abique/develop/vcpkg/buildtrees/brotli/src/6c62fc2c71-a8c4ea9278.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/abique/develop/vcpkg/downloads/google-brotli-e61745a6b7add50d380cfd7d3883dd6c62fc2c71.tar.gz
-- Applying patch install.patch
-- Applying patch fix-arm-uwp.patch
-- Applying patch pkgconfig.patch
-- Using source at /home/abique/develop/vcpkg/buildtrees/brotli/src/6c62fc2c71-a8c4ea9278.clean
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Building x64-linux-rel
CMake Error at scripts/cmake/vcpkg_copy_tool_dependencies.cmake:22 (message):
  Could not find PowerShell Core; please open an issue to report this.
Call Stack (most recent call first):
  ports/brotli/portfile.cmake:23 (vcpkg_copy_tool_dependencies)
  scripts/ports.cmake:135 (include)

Error: Building package brotli:x64-linux failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `./vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: brotli:x64-linux
  Vcpkg version: 2020.06.15-unknownhash

Additionally, attach any relevant sections from the log files above.
20-11-02 18:08:02 1 abique@knot:~/d/vcpkg git:master>

Additional context
I don't know why it is looking for PowerShell.

Can confirm I am seeing this on CentOS 7 as well.

This issue was introduced by: https://github.com/microsoft/vcpkg/commit/b7056e9f1f34f18b6648b1f1d9c4e9d31f04e91c

It's looking for powershell because the applocal.ps1 which tries to determine what each tool depends on to copy the right associated binaries over, is a powershell script.
It looks like that test has been broken "forever"; find_program doesn't create a FOO-NOTFOUND variable, it puts FOO-NOTFOUND into that variable. Looks like that bug comes all the way back from https://github.com/microsoft/vcpkg/commit/634c1043b01dff682dc9834f4987037683764034 -- there the "if (POWERSHELL-NOTFOUND)" branch is dead. In https://github.com/microsoft/vcpkg/commit/a6a1722cfa94caa5db98848679b99377bc5a0112 I changed it to try to use an installed pwsh if that is already present, but I didn't fix that "the branch is dead" bug, and in https://github.com/microsoft/vcpkg/commit/b7056e9f1f34f18b6648b1f1d9c4e9d31f04e91c I fixed the branch to not be dead. But maybe the branch should have been dead?
Even though that was wrong, because vcpkg_copy_tools_dependencies looks for ".exe", it never tried to invoke that powershell script on most *nix systems,
It passes in our CI because we have powershell core installed in our test VMs, so find_program finds it, and everything is OK.
Possible options:

We could make this function do nothing on non-Windows which will make the message go away
We could make sure that powershell core is acquired first by vcpkg; some ports assume powershell is available
We could change this bit to use vcpkg_find_acquire_program to get powershell.

I have submitted the "do nothing on non-Windows" change https://github.com/microsoft/vcpkg/pull/14366/

Thank you @BillyONeal I'll check the master again maybe today.

Also if a package needs powershell it should mention it in its metadata/build dependencies and vcpkg should acquire powershell I think.

Also if a package needs powershell it should mention it in its metadata/build dependencies and vcpkg should acquire powershell I think.

On Windows it's an assumed dependency:
https://github.com/microsoft/vcpkg/blob/master/toolsrc/src/vcpkg/build.cpp#L340


FIX: Update grandle for run app on android device

I can't run the example app on the Android device, so we make this PR for it

Thank you, but I ended up recreating the example dir with the current Flutter default.


Implements simulator recipe start options (state/effects)

This functionnality aims to use the simulator/solver to finish a already ingame started craft.
Actually, when using the simulation/solver, it takes the recipe, crafter attributes and crafter bonus (given by foods usualy). Then, solver will try to find the best simulation. This is just a awesome feature, but it has limitations since this is assuming that simulation starts from the begining of the craft, and the use for hard recipe is currently limited.
So, from simulator windows, we still can set bonus crafter given by foods. Plus, we can set durability/progress/quality/cp. For conditions & effects, we can open modal window and set values.
In addition of that, i have limited recipe combo list to crafter level. If i'm lvl26, it don't want to see lvl50 recipes since i can"t make it.
Feel free, to give back you're comments ;) Or if you don't want to integrate this, it will not be a problem ^^
Thanks anyway for this tool.

Interesting ideas! Could you separate the recipe selector changes into a different PR?

Sure, no problem. So, I have just created a new PR for the recipe filtering.


Dependency Updates

This PR updates dependencies to current versions and removes deprecated methods.  Will prevent breaking changes due to new sdk versions.

Please merge

Please merged this PR

@fennel-ptorchia could you also add the namespace to app/build.gradle file?

Complete but I do not have the ability to merge this, probably better off forking it

@fennel-ptorchia could you also add the namespace to app/build.gradle file?

Complete but I do not have the ability to merge this, probably better off forking it

Thank you. It is sufficient for me, as I use a reference to your branch. So I don't have to create a new fork.

@fennel-ptorchia
Use this code instead of normal namespace
if (project.android.hasProperty('namespace')) {         namespace 'com.homex.open_mail_app'     }


Updated games list test to be more useful

Checklist

[x] Use a separate branch in your local repo (not master).
[x] Test coverage is 100% (or you have a story for why it's ok).

I didn't feel like the test for games list was particularly useful as it didn't actually test what we're interested in testing. Now the test checks to ensure that the returned list contains the names of available games.

I signed it!

Coverage remained the same at 100.0% when pulling c3effc4293df3aa8307d8b17b15e657485d401b7 on iamchristopher:fix-games-list-test into b4bb3cd38dbb66a34306be7d66c4adeb5b7aa6f3 on google:master.

Thanks!


Expose and document a simpler public API for simplify expressions

Which issue does this PR close?
Closes #3709.
Rationale for this change
This api is very useful for other project which depends on datafusion, like filter pushdown, default-value when insert.
What changes are included in this PR?
Expose and document a simpler public API for simplify expressions
Are there any user-facing changes?
Added a public method simplify_expr.

@alamb, PTAL.

Github actions is having issues I think -- the CI failures are not related to changes in this PR

Github actions is having issues I think -- the CI failures are not related to changes in this PR

Yes, I see other pr also meets the same ci error :sweat_smile:.

Thanks @ygf11  -- I may propose some changes to this API as part of working through the examples in https://github.com/apache/arrow-datafusion/pull/3741.


Hardcode Bazel installation version

The apt method of installing Bazel isn't very consistent, and we
sometimes need to lock a specific version. This updates all of the devel
dockerfiles to install Bazel directly from the installer instead.

This was included in another PR, already merged.


chore(master): release 15.65.0

This release is too large to preview in the pull request body. View the full release notes here: https://github.com/oscrey/zigbee-herdsman-converters/blob/release-please--branches--master--components--release-please-action--release-notes/release-notes.md

:robot: Release is at https://github.com/oscrey/zigbee-herdsman-converters/releases/tag/v15.65.0 :sunflower:


Is it possible to get answers from custom questions answering in local language?

Hello @samthrusha123 - Could you please share the more information and steps for your query?

@samthrusha123 - Could you please share the more information and steps for your query?

In bot we're having Custom Question Answering right? We will maintain kb's t

@samthrusha123 - Could you please share the more information and steps for your query?

can we translate the QnA KB answers to another language instead of english?

@samthrusha123 - If you need to support a knowledge base system, which includes several languages, you can:
Use the Translator service to translate a question into a single language before sending the question to your knowledge base. This allows you to focus on the quality of a single language and the quality of the alternate questions and answers.
Create a custom question answering enabled language resource, and a knowledge base inside that resource, for every language. This allows you to manage separate alternate questions and answer text that is more nuanced for each language. This gives you much more flexibility but requires a much higher maintenance cost when the questions or answers change across all languages.
Ref Doc: https://learn.microsoft.com/en-us/azure/cognitive-services/language-service/question-answering/language-support#supporting-multiple-languages-in-one-knowledge-base


Add lint for checking that Subject attributes (RDNs) appear in the order prescribed by CABF BR <IP_ADDRESS>

Please add this lint for checking that Subject attributes (RDNs) appear in the order prescribed by CABF BR <IP_ADDRESS>.
Effective on 15 September 2023 as per CABF BR 2.0.0

Thnak you Chris.


activate planet IQ

This, combined with PR #138, fully activates Planet IQ. Zero diff before Planet IQ is available; intentionally not so after that.

So NOAA is getting the Planet IQ data now through a 6-month delivery order to Space Sciences and Engineering LLC (PlanetiQ) under the Radio Occultation Data Buy II (RODB-2) Indefinite Delivery, Indefinite Quantity (IDIQ) contract.  The delivery order for the Planet IQ data extends through Thursday, January 18, 2024.
This appears to be a web page where you can get information on NOAA's commercial data program:
https://www.space.commerce.gov/business-with-noaa/commercial-weather-data-pilot-cwdp/


How to Hide popup automatically when socket refresh

Hi,
I am showing popup when get some response from socket. But in this scenario i want to hide without touch the popup will close while get another response from socket...  How to do this one.. I tried button cancel action. But its not working.. Kindly help us..
i create this function in CZPickerView.m

(void)hide {
[self cancelButtonPressed:self];
[self buildBackgroundDimmingView];
}

Thans
Krishna

Hi, I don't think the current code support such requirement, you can add it your self.


Verification fails with cached dependency, succeeds without it

This is a case where a module M depending on N (both without interfaces) fails to verify when loading N.fst.checked, but verifies otherwise.
Sorry, I couldn't minimize this, but I can reproduce the issue consistently when N.fst.checked is recorded either using the --cmi flag or without using it.
To reproduce, checkout hacl-star@c33357683 and run  OTHERFLAGS="--admit_smt_queries true" make -j in code/experimental/sha3, and then
fstar.exe `OTHERFLAGS="--admit_except Hacl.Impl.SHA3.state_theta" make Hacl.Impl.SHA3.fst-in` Hacl.Impl.SHA3.fst
This should fail with at
(Hacl.Impl.SHA3.fst(142,2-145,52))      Query-stats (Hacl.Impl.SHA3.state_theta, 2)     failed
Now run rm .cache/Spec.SHA3.fst.checked and then again
fstar.exe `OTHERFLAGS="--admit_except Hacl.Impl.SHA3.state_theta" make Hacl.Impl.SHA3.fst-in` Hacl.Impl.SHA3.fst
This time it should succeed.
You can try the same with Makefile.old that doesn't use --cmi.
I'm using
$ fstar.exe --version
F* <IP_ADDRESS>~dev
platform=Windows_x64
compiler=OCaml 4.06.1
date=2018-10-18T10:21:10+0100
commit=059db0c8f527948202ced33ed871c0aa4a0fa3a4

I'm bumping the priority of this issue. The obvious workaround is not to use .checked files but that's undesirable.
I don't know how common is this issue and that makes it annoying because one can never tell whether a proof obligation fails because of this or it would fail as well if dependencies weren't loaded from .checked files.

I'm bumping the priority of this issue. The obvious woraround is not to use .checked files, but that's undesirable and doesn't work with --cmi.
I don't know how common is this issue, and that makes it annoying because one can never tell whether a proof obligation fails because of this or it woul fail as well if dependencies weren't loaded from .checked files.

I will take a look at it.

The proof fails at the function Hacl.Impl.SHA3:state_theta. This function calls salloc1_trivial from Lib.Buffer.fsti. The function salloc1_trivial is unannotated -- meaning the clients rely on the type computed by F*.
Without caches, F* lax checks Lib.Buffer.fsti and computes a wp for salloc1_trivial which is lax-computed, F* intentionally drops many guards from the wp in the lax mode. And with this wp the proof succeeds.
With caches, the file Lib.Buffer.fsti has been checked properly, and F* has computed a proper wp for salloc1_trivial. And with this wp, the function fails to verify.
I tried annotating the type of salloc1_trivial with its intended type (basically inlining the spec of the spec_inv argument in the requires):
inline_for_extraction noextract
let salloc1_trivial (#a:Type) (#res:Type) (h:mem) (len:size_t{0 < v len}) (x:a) (footprint:Ghost.erased B.loc)
  (spec:res -> mem -> GTot Type0) impl
  :Stack res (requires (fun h0 -> h0 == h /\
              (forall (h1 h2 h3:mem) (r:res).
               (        modifies0 h h1 /\
        modifies (B.loc_union (B.loc_all_regions_from false (get_tip h1))
                            (Ghost.reveal footprint)) h1 h2 /\
        modifies (B.loc_region_only false (get_tip h1)) h2 h3 /\
        ~(live_region h (get_tip h1)) /\
        spec r h2) ==> (spec r h3))))
             (ensures  fun h0 r h1 -> modifies (Ghost.reveal footprint) h0 h1 /\ spec r h1)
  = let trivial (h1 h2 h3:mem) (r:res) = () in
    salloc1 h len x footprint spec trivial impl

And with this, the proof in Hacl.Impl.SHA3 fails even without caches.
So, I think it is a legitimate failure, though a bit unintuitive.
A couple of things we can do:
-- @mtzguido suggests that instead of lax checking the dependencies, we should check them with --admit_smt_queries true, seems like a good idea to me.
-- We should remove --lax as an option altogether.
-- Always annotate top-level functions.

Kudos to Aseem for figuring this out. I would even call this an unsoundness (when one is not using checked files), since one can succesfully verify all the files in a project, but with inconsistent assumptions for each. For instance this setup verifies perfectly without caches:
module A

open FStar.ST

let f (r:ref int) =
    if !r = 1
    then r := 2
    else assert False

module B

open A
open FStar.ST

let g () : St int =
    let r = alloc 0 in
    f r;
    !r

But of course, we're breaking the (inferred) precondition of f. Annotating f, using caches, and moving f to module B all cause the intended failure, but this could very well slip under the radar. I think most projects are using .checked files now, but heads up.
I agree with the proposed solutions (1 and 2 in particular, both of them).

Many thanks @aseemr and @mtzguido for looking into this issue.
I should have known better and annotate salloc1_trivial. Unannotated top-level stateful functions are a recurrent source of confusion and we discussed many times making it a fatal error. It might be time to act on those discussions.
In the past I was opposed to remove --lax, but with cached modules and incremental extraction now in place I don't see situations in which --lax can't be replaced with --admit_smt_queries true.
The drawback is that this increases significantly the cost of loading dependencies from scratch, without .checked files.

Unannotated top-level stateful functions are a recurrent source of confusion and we discussed many times making it a fatal error. It might be time to act on those discussions.

Some concrete references for this: #143 and https://github.com/FStarLang/FStar/issues/1055#issuecomment-316404896


Restore original console log

Bind is unnecessary if people are calling the console.log function as console.log

Thanks for the PR; can you explain this? I always thought it was necessary to work across all browsers, since they expect the context of the log function to be bound to console.

ah nevermind, I see what is going on. thanks again

that's true, if you're calling console.log NOT on the console i.e this will fail:
var log = console.log
log() // error, thisArg is undefined or window, not console

or
var myConsole {
  log: console.log
}
myConsole.log() // error, thisArg is myConsole not console

:+1:

any chance you could fix this up so i can merge? also I can add you as a contributor to tap-console-parser, tap-dev-tool and hihat if you'd like

Damn, I broke that first PR into those two commits, and added the proceeding one to this so we wouldn't have this problem haha, oh well.

@mattdesl ok good to go

sure, add me

hmm how can i avoid the merge conflict here in future situations?
pushed 1.0.4 and added you as an npm collaborator to the three modules. Unfortunately GitHub won't let me just add a new single collaborator for some reason, maybe I don't have the right admin rights to Jam3 org. I'm going to chat with some other Jam3 devs and get back to you on that.

@timoxley invited you to the three repos, I think you'll need to accept since it's a "team" of collaborators.


Disable "stateChangesOnly"

Hi,
I would know if is possible o dissable the method "stateChangesOnly" or will be possible in the future.
Thanks and best regards, Javier

@jroda stateChangesOnly is not on by default unless you have globally configured a an alert handler. Is that the case? If so which one?

Yes, that was the problem. Thanks so much for fast answer @nathanielc .


Improvement: add test location to jest call

To improve the execution speed and ignore errors in other files one could add the path of the current test file to the jest call.
Jest only looks in this particular file and does not search for tests in all files.
E.g.
// Now:
jest -t "test name pattern"

// Better use:
jest -t "test name pattern" path/to/file.test.js

this feature is now implemented with https://github.com/firsttris/vscode-jest-runner/pull/11

included in version 0.2.5


get_board_number() returns -1 for a DaqDeviceDescriptor returned from get_daq_device_inventory()

The function get_board_number() returns -1 if a DaqDeviceDescriptor from the list of devices gathered by get_daq_device_inventory() is passed to it.
A USB-1408FS is used in this case.
devices = ul.get_daq_device_inventory(InterfaceType.USB)
for device in devices:
     print(ul.get_board_number(device))

We are also experimenting the same issue with the USB-2416 device. This seems to me like a quite severe issue since we can't get board_number dynamically where big part of the api depends upon a board number. Thank you to consider addressing this issue.

you get that result because no devices were found or instantiated.
Please review example a_in.py
You are trying to get the board number of the device before you have created an instance of the device.
in short, you need to call this:
daq_device = DaqDevoce(devices[array_index])
before you can call:
print(ul.get_board_number(daq_device))

Thank you for your answer,
Unfortunately I don't think this solves the issue.
I am not sure at what api you refer to. A search for DaqDevice returns nothing in the documentation. Nor in the a_in.py example (or I didn't found it)
Summarizing the example, it does:
ul.ignore_instacal()
devices = ul.get_daq_device_inventory(InterfaceType.ANY)
...
ul.create_daq_device(board_num, device) # I suppose that's the line you refer to with DaqDevoce(devices[array_index])
Then at that point I would be able to do a ul.get_board_number(device). Yes that works and I tried it. But this is not the same use case and I should have specified it earlier. This case uses the ul.ignore_instacal() so you need to create your own device library. The documentation says about ignore_instacal() :

Prevents the Universal Library from automatically adding a DAQ device has been stored in the cb.cfg file by InstaCal. This function must be the first Universal Library function invoked in the application.

But what if we precisely want to use the instacal library. This is the use case I am referring to. If we don't call ul.ignore_instacal(), we can configure the device and operate it. By providing the board number, everything works fine. So the board number exist somewhere that the api knows of how to associate it with the specified board. Except that calling ul.get_board_number(device) returns -1 even though we didn't call ul.ignore_instacal()
By the way, I can confirm that it is doing the same either with USB-2416 and also USB-2404ui.

My bad, I was thinking Linux version of UL library (uldaq), but you are running UL for python on Windows (mcculw).
but no matter.
Why are you trying to return the board number?  this is something you set so you already know what it it is.
this line:
ul.create_daq_device(board_num, device)
is what sets the board number.
I still recommend you step through one of the installed examples such as a_in.py and console_examples_util.py so you can see how the device object is created.
I edited the console_examples_util.py by adding ...
print('board num:')
print(ul.get_board_number(device))

...at the end of the existing code. It returns the correct value.  But as stated, since board_num is a variable set in a_in.py, you already know what it is going to be.
I modified a_in.py, line 38 to:
board_num = 5
so when I run the example, it prints:
board num:
5
The complete example print out is:
Found 1 DAQ device(s):
USB-2416 (87745) - Device ID = 208
board num:
5
Active DAQ device: USB-2416 (87745)
Raw Value: 8388645
Engineering Value: 0.000
Process finished with exit code 0
the example is installed in your C:\Users\Public\Documents\Measurement Computing\DAQ\Python\examples\console

Yeah, sorry for that, I should have specified I'm on Windows.
I understand the examples and I am already creating my own device registry doing the same as the example. And it is working. The issue is that I don't think I should have to build my own registry and this is due to the issue I am talking about. Let's say there are 2 main use cases dealing with device registries:

Building your own registry
Using the instacal registry (CB.CFG)

Use case # 1
This use case is the one demonstrated in the example and the one I am currently implementing because of the current bug. I have no issue with this one, it is working. This use case implies to call ul.ignore_instacal() as the first call of the api. here is a prototype of this use case:
ul.ignore_instacal() #tell the api to ignore instacal registry
devices = ul.get_daq_device_inventory(Interface.ANY) # get the devices
arbitrary_board_number = 0
ul.create_daq_device(arbitrary_board_number, device[0])

ul.set_config(..., arbitrary_board_number, ...)
ul.do_some_other_stuff(..., arbitrary_board_number, ...)
...

Use case # 2
This is the scenario that seems to me having an issue. Here is its prototype:
#### No call to ul.ignore_instacal() meaning we want to use instacal registry###
devices = ul.get_daq_device_inventory(Interface.ANY) # get the devices
instacal_board_number = ul.create_daq_device(device[0])

ul.set_config(..., instacal_board_number, ...)
ul.do_some_other_stuff(..., instacal_board_number, ...)
...

As said before, the documentation sais about ignore_instacal()

Prevents the Universal Library from automatically adding a DAQ device has been stored in the cb.cfg file by InstaCal. This function must be the first Universal Library function invoked in the application.

The file CB.CFG holds the catralog of devices associated with board_numbers. If we know the board_number of the board we want to use, then we can operate the device EVEN without calling create_daq_device(). This means that the registry is known to the api. The only line that is not working in this scenario is get_board_number(). The issue is that get_board_number(device) wrongly returns -1 even though the device is in the instacal registry. Since ul.ignore_instacal() was not called, it should return the board number according to the CB.CFG file.
I hope that it clarifies things.
Thanks you!

I don't know as I would call what is in cb.cfg a 'catalog' exactly.
This used to be required prior to having device discovery functions in the UL.
much of what you are referring to is there because we wanted to make the customer experience with our examples better. Our examples did not always work 'out of the box,' changes to range, rate, etc would need to be made.  So extra levels of information were added along with device discovery function.
How about this (a more direct access to the device)...
a_in_w_CBcfg.zip

hmm, you don't seem to want to recognize that as an issue. To me this is a broken flow. There is a method called get_board_number() that says it "gets the board number" but doesn't get the board number when ul.ignore_instacal() is not called. This is a method that does not do what it says. Maybe it is working as designed. Then I would find that rather weird. Anyway, I am making my own registry.
That was my last comment on that issue. I was not the one who opened that issue so at least two users found that problematic. I hope other users will back me if they share my opinion.
Thank you for your time.

Unfortunately, I had not enough time lately to comment on this issue.
Thank you very much @dlebelcimmi! You brought up exactly my arguments!
@jeffreyg3
If get_board_number() is not intended to work with the instacal configuration I would really appreciate if this could be documented.
Thank you.

Thanks @linuxrider !
By the way, personally I would not close this issue. If other users meet the same issue they will comment on the thread. I would rather let MCC decide whether they agree to see it as a bug or if it is behaving as intended. They would close it themselves providing their conclusion.

Thanks for the hint!


Docker compose not working: dagster image not found

Getting an error when after docker-compose up -d :
Error response from daemon: pull access denied for dagster, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
Trying to figure it, it seems there's no image named dagster at DockerHub or defined at Dockerfile or docker-compose.yml but it is referenced:
  dagster_dagit:     image: dagster
How that was working previously?

Hello, I'm not sure how to proceed after that error. Can you help?

I guess it's just and old dagster image. If you find a new one you might make it work, but not sure at all. I just stopped trying long ago.


SVG 'use' with External Source not working

Hi,
I'm using   tag to reference SVG from an external file, because that means that file can be cached by the browser. The SVG 'use' with External Source don't work with Turbolinks but when i define the shapes inside de page it works fine.
Is there a way to make external SVG links work with Turbolinks?
Thanks!

Could you point to a simple HTML page where we can reproduce the problem?


Highlighting of a diff from a patch/diff file

When creating a diff from a patch/diff file results in the line with additions to the patchfile being recognized as context instead of addition.

Duplicate of https://github.com/the-mikedavis/tree-sitter-diff/issues/1
This grammar focuses only on diff syntax: a separate tree-sitter-patch should be created to handle patch syntax and it can inject this grammar for the diff parts


IPv6 array membership: "Filter AST unknown type: &{Identifier fe80}" (regression at 9be1403)

(This issue was found via a re-run of the Rug tests.)
Consider the following test data:
$ cat sanip.zson
{
    san: {
        ip: [
            <IP_ADDRESS>,
            fe80::9d42:4c7d:e0dd:79e1,
            fe80::f970:1e0:96c4:2a96,
            fe80::5efe:ac10:9c
        ]
    }
}

At zq commit db76d01 that came right before the changes in #2072 (cc: @mccanne), this was working:
$ zq -version
Version: v0.29.0

$ zq -f zson -i zson 'fe80::5efe:ac10:9c in san.ip' sanip.zson
{
    san: {
        ip: [
            <IP_ADDRESS>,
            fe80::9d42:4c7d:e0dd:79e1,
            fe80::f970:1e0:96c4:2a96,
            fe80::5efe:ac10:9c
        ] (=0)
    } (=1)
} (=2)

However, ever since the changes in #2072, this has caused an error. Here it is failing with current zq at commit
$ zq -version
Version: v0.29.0-80-g3cc324e6

$ zq -f zson -i zson 'fe80::5efe:ac10:9c in san.ip' sanip.zson
Filter AST unknown type: &{Identifier fe80}

Verified in zq commit 890be30.
Repeating the original repro steps, now the matching record is returned instead of an error.
$ zq -version
Version: v0.29.0-104-g890be304

$ zq -f zson -i zson 'fe80::5efe:ac10:9c in san.ip' sanip.zson
{
    san: {
        ip: [
            <IP_ADDRESS>,
            fe80::9d42:4c7d:e0dd:79e1,
            fe80::f970:1e0:96c4:2a96,
            fe80::5efe:ac10:9c
        ]
    }
}

Thanks @nwt!


Sample editor

Current approach is to use external editor - e.g. audacity. To keep that part simpler we'll attempt to build a custom version of Audacity with advanced features removed or carefully hidden.

another variant: open an external editor

I've switched samples to standard wav (format: float32-mono-44.1kHz) see #36
Old samples are still loaded, new ones will be wavs. (Actually I expected that old files will be converted automatically because I don't mark them fresh, but something went wrong. I will probably fix this while working on the rest of the issues of this milestone).
Audacity can open our samples now, but saving back to original wav file involves too many user actions (menu File > Export, OK in the export dialog, find data directory, make sure output format is WAV).
Audacity only supports 16 bit PCM format, but WTS tool can open it no problem.

It may be a good idea to leave the choice of an external editor to the particular workshop organization and provide some tips.
Here is a list of free audio editors, although not all of them are suitable for wav sample editing (and not all of them work on both windows and mac). May be someone could compile a similar list of open source, freeware and cheap softwares that could be used to edit the WTS samples? The advantage is - if the instructors already know some wav editor, they could just use that.

the last one on the list - wavesurfer - is quite simple and its save action (apple+s on a mac, ctrl+s on a pc) saves back to the file that was open in the original format without asking any extra data. I have to investigate what plugins it supports (the original effects list is very limited).

A software tool for the manipulation of audio recordings.
" WaveSurfer is an Open Source tool for sound visualization and manipulation. It has been designed to suit both novice and advanced users. WaveSurfer has a simple and logical user interface that provides functionality in an intuitive way and which can be adapted to different tasks. It can be used as a stand-alone tool for a wide range of tasks in speech research and education. Typical applications are speech/sound analysis and sound annotation/transcription. WaveSurfer can also serve as a platform for more advanced/specialized applications. This is accomplished either through extending the WaveSurfer application with new custom plug-ins or by embedding WaveSurfer visualization components in other applications."
First impression, looks beautiful
Customizable - users can create their own configurations. Localization support.
Extensible - new functionality can be added through a plugin architecture
Embeddable - WaveSurfer can be used as a widget in custom applications
Scriptable - hosts a built-in script interpreter
There are no plug-ins available
Plug-in supports AU
Wavesurfer provides basic audio editing function, such as excision, copying, pasting, zero-crossing adjustment, and effects such as fading, normalization, echo, inversion, reversal, replacement with silence, and DC-removal.
Till now will be continued

Something to think about:
The sample editor we need is a basic environment for VST or AU plug ins.
The programs I've find till now are more complex.
I will try to make a MSP environment where you can load fee ware plug ins.
Is that worth a try?

Like I said - as long as a program can open WAV files that Watch That Sound tool creates and save them back to the same WAV with the same settings it should be OK. Next Monday I'll build a version that saves to WAV and release on the site. It will be available via an update on a mac.
I liked WaveSurfer, it supports customizations, so we could hide features we don't like. I just have to investigate if it supports external sound plugins like VST / AU.
Building a prototype sample editor in Max is OK, but how would you open a particular sample in it automatically?

MSP: If you have installed a plug in a patch it will stay there.
The weak point is probably the plugin installing on every user computer.
This weekend I will try to make a patch with a plug in and we will see what happens when We build it as an application for export.

I understand what you want to do with the plugin, but how will it open the wav?
with an application like Audacity or WaveSurfer I can right-click on a wav in Finder / Explorer and choose "Open with > Audacity". That means that I can also open a wav with such application from within WTS-tool. But is this possible with an MSP patch?
this is important: the filenames are confusing, we would want to be able to select a sample in WTS gui and open it in an external application.

Her I found some infas what a MSP?Max builld application does;
Mac Platform Information for Standalone Applications
Max builds universal binary standalone applications on the Mac. The standalone is an application package, which is also a folder that looks like a file in the Finder. Double-clicking on the file's icon launches the application.
YourApplication.app [ note: the .app is not shown in the Finder ]
I guess the last sentence means it will not appears in the "Open with "

yes, that will open the patch you exported. That will not open a wav file.
I've tested WaveSurfer further, it has the same problem - it can't open files from finder, which means we can't open samples in it programmatically on OSX.
I also looked tested more of Audacity, there are some preferences that make exporting to original file a bit easier. Also, the latest version of Audacity remembers the folder and filename of the open wav file and export dialog starts with them. Just pressing Enter then selects to write to the original file. The only annoyance left is that Audacity then says "there is already a file with that name, overwrite?".
Also it is possible to change the key bindings im Audacity properties, so that Apple+S (Crtl+S on windows) calls "Export..." and not "Save".

The latest idea is to see how much work it is to build a custom version of audacity.
The simplest is to fork audacity's code repository, build it with alternative filename (e.g. AudacityWTS or something) and make sure it is selected as the default program for opening WAV files in the OS. The customizations:

remove saving to audacity projects
export to a single format (WAV) and Apple+S / Ctrl+S exports under original name without asking / warning about overwriting
hard coded

Audacity build instructions mention that it requires wxwidgets 2.8.12, homebrew officially only provides 2.8.11. I will have to build my own or upgrade the homebrew recipe.
Further, homebrew recipe is 32-bit only, not sure if that's a problem for audacity.

The homebrew wxwidgets recipe was updated to 2.8.12, so I won't have to roll my own. I will have to build a 32-bit version of audacity if using it though.

The homebrew version of wxwidgets has no static libraries, which audacity wants. There is a topic on audacity forums describing how to build a compatible version of wxwidgets and audacity itself. I'll give it a try.
There is also a page on audacity wiki dedicated to developing on a mac.

building static debug version of the wxwidgets succeeds, using a modified version of the build script from audacity forum. Now audacity's build system complains about the Mac OS SDK 10.4. I've switched it to 10.5 (Leopard) which I have. Also switched the architecture to 32/64 bit intel. Only release targets were adjusting architecture, debug targets must be using default (build machine's native?).

apparently wxwidgets 2.8.12 aren't compatible with 64-bit architecture. So I will need to restrict audacity's build architecture to 32-bit.

I still have some problems building audacity, I asked about them on their forum. I'll try to disable the features that don't build now (we don't need them anyway).

Partial solution:

Prepended -Z to "Other Linker Flags". This linker option removes standard library search paths from consideration.
Added /Developer/SDKs/MacOSX10.5.sdk/System/Library/Frameworks to "Framework Search Paths" so that it finds OpenGL (which is apparently referenced by some audacity's dependency).

This ensures that /usr/local/lib is not searched. Next problem:
Undefined symbols:
  "_FLAC__ogg_encoder_aspect_set_defaults", referenced from:
      _set_defaults_ in libFLAC.a(stream_encoder.o)

(...)

  "_simple_ogg_page__get_at", referenced from:
      _update_ogg_metadata_ in libFLAC.a(stream_encoder.o)

(...)

ld: symbol(s) not found
collect2: ld returned 1 exit status

(there are more undefined symbols there, but they all are about libFLAC / ogg.

I've solved the latter problem as well. Analysis: libFLAC wasn't building ogg support, which probably explains why ogg includes directory wasn't configured for libFLAC (I added it earlier to get the subproject to build). Since I can't find how to disable FLAC / ogg support at the moment, I just added flac<->ogg modules to the build system and everything builds and links and runs now.
Conclusion so far: we can build Audacity from latest sources (it even sais that the version is "2.0.0", while the last release was "1.3.4").
Next question: how easy is it to disable some functionality (like extra formats support) and modify another (like it asking to overwrite modified wav-file).

Ok, I had a look on CleanSpeech and it's not exactly what we want and according to the forum:

CleanSpeach has been removed by the developers as it causes far too many problems

The customized audacity does what I wanted - Apple+S exports wav under its original name, quitting doesn't ask to save exported project. Later I can disable more functionality irrelevant for the workshops, but for now this is OK.


[explorer] bug: fix display mosaic amount issue

What was the issue?

Mosaic amount wrong display, when sending transaction attached mosaic's Id and namespace. read here
Explorer filtered by mosaic id and showing the amount, instead of sum the amount balance.

What's the fix?

removed unused method networkCurrencyMosaicBuilder.
sum the amount of mosaic filtered by mosaic id.
minor refactor on helper method.

@Jaguar0625 I rebased it to top of dev


Facing Unable to connect to Deepgram issue in given deepgram example

Hi,
I was facing issues with Deepgram connection in my project after upgrading from 0.0.41 to 0.0.47 so I tried a deepgram example given in the project but still faced the same issue. I also faced the same issue when trying to upgrade to 0.0.43 a few weeks back when it was the latest but gave up due to this issue. Please help me fix this, I'm tired of trying to make this work.
[Steps I took]

Downloaded 07c-interruptible-deepgram.py and runner.py
Ran python 07c-interruptible-deepgram.py

[System]
pipecat-ai              0.0.47
deepgram-sdk      3.7.5
MacOS Sonoma 16GB
[Logs]  (I had enabled deepgram debug logs so the extra logs are because of that. Hope it would be useful)
❯ python 07c-interruptible-deepgram.py
2024-10-24 18:23:21.596 | INFO     | pipecat.audio.vad.vad_analyzer:set_params:60 - Setting VAD params to: confidence=0.7 start_secs=0.2 stop_secs=0.8 min_volume=0.6
2024-10-24 18:23:21.596 | DEBUG    | pipecat.audio.vad.silero:__init__:114 - Loading Silero VAD model...
2024-10-24 18:23:21.689 | DEBUG    | pipecat.audio.vad.silero:__init__:136 - Loaded Silero VAD
Version.v ENTER
version: 1
path: deepgram.clients.listen.v1.websocket.async_client
class_name: AsyncListenWebSocketClient
Version.v succeeded
Version.v LEAVE
event subscribed: Results
2024-10-24 18:23:21.701 | DEBUG    | pipecat.processors.frame_processor:link:134 - Linking PipelineSource#0 -> DailyInputTransport#0
2024-10-24 18:23:21.701 | DEBUG    | pipecat.processors.frame_processor:link:134 - Linking DailyInputTransport#0 -> DeepgramSTTService#0
2024-10-24 18:23:21.701 | DEBUG    | pipecat.processors.frame_processor:link:134 - Linking DeepgramSTTService#0 -> OpenAIUserContextAggregator#0
2024-10-24 18:23:21.701 | DEBUG    | pipecat.processors.frame_processor:link:134 - Linking OpenAIUserContextAggregator#0 -> OpenAILLMService#0
2024-10-24 18:23:21.701 | DEBUG    | pipecat.processors.frame_processor:link:134 - Linking OpenAILLMService#0 -> DeepgramTTSService#0
2024-10-24 18:23:21.701 | DEBUG    | pipecat.processors.frame_processor:link:134 - Linking DeepgramTTSService#0 -> DailyOutputTransport#0
2024-10-24 18:23:21.701 | DEBUG    | pipecat.processors.frame_processor:link:134 - Linking DailyOutputTransport#0 -> OpenAIAssistantContextAggregator#0
2024-10-24 18:23:21.701 | DEBUG    | pipecat.processors.frame_processor:link:134 - Linking OpenAIAssistantContextAggregator#0 -> PipelineSink#0
2024-10-24 18:23:21.701 | DEBUG    | pipecat.processors.frame_processor:link:134 - Linking Source#0 -> Pipeline#0
2024-10-24 18:23:21.701 | DEBUG    | pipecat.processors.frame_processor:link:134 - Linking Pipeline#0 -> Sink#0
2024-10-24 18:23:21.701 | DEBUG    | pipecat.pipeline.runner:run:27 - Runner PipelineRunner#0 started running PipelineTask#0
AsyncListenWebSocketClient.start ENTER
options: {'channels': 1, 'encoding': 'linear16', 'interim_results': True, 'language': <Language.EN: 'en'>, 'model': 'nova-2-general', 'punctuate': True, 'profanity_filter': True, 'sample_rate': 16000, 'smart_format': True, 'vad_events': False}
addons: None
headers: None
members: None
kwargs: {}
AbstractAsyncWebSocketClient.start ENTER
addons: None
headers: None
kwargs: {}
combined_options: {'channels': 1, 'encoding': 'linear16', 'interim_results': True, 'language': <Language.EN: 'en'>, 'model': 'nova-2-general', 'punctuate': True, 'profanity_filter': True, 'sample_rate': 16000, 'smart_format': True, 'vad_events': False}
combined_headers: {'Accept': 'application/json', 'Authorization': 'Token **********', 'User-Agent'<EMAIL_ADDRESS>python/10.14'}
WebSocketException in AbstractAsyncWebSocketClient.start: server rejected WebSocket connection: HTTP 400
AbstractAsyncWebSocketClient.start LEAVE
AsyncListenWebSocketClient.start failed
AsyncListenWebSocketClient.start LEAVE
2024-10-24 18:23:23.283 | ERROR    | pipecat.services.deepgram:_connect:196 - DeepgramSTTService#0: Unable to connect to Deepgram
2024-10-24 18:23:23.283 | INFO     | pipecat.transports.services.daily:join:301 - Joining https://{domain}.daily.co/audiocall
2024-10-24 18:23:25.927 | INFO     | pipecat.transports.services.daily:join:320 - Joined https://{domain}.daily.co/audiocall
^C2024-10-24 18:23:30.186 | WARNING  | pipecat.pipeline.runner:_sig_handler:51 - Interruption detected. Canceling runner PipelineRunner#0
2024-10-24 18:23:30.186 | DEBUG    | pipecat.pipeline.runner:cancel:38 - Canceling runner PipelineRunner#0
2024-10-24 18:23:30.186 | DEBUG    | pipecat.pipeline.task:cancel:118 - Canceling pipeline task PipelineTask#0
2024-10-24 18:23:30.187 | INFO     | pipecat.transports.services.daily:leave:408 - Leaving https://{domain}.daily.co/audiocall
2024-10-24 18:23:30.203 | INFO     | pipecat.transports.services.daily:leave:417 - Left https://{domain}.daily.co/audiocall
AsyncListenWebSocketClient.finish ENTER
cancelling tasks...
AbstractAsyncWebSocketClient.finish ENTER
closing socket...
clean up socket...
cancelling tasks...
before running thread: MainThread
before running thread: asyncio_0
number of active threads: 2
threads joined
after running thread: MainThread
after running thread: asyncio_0
number of active threads: 2
finish succeeded
before running thread: MainThread
before running thread: asyncio_0
number of active threads: 2
threads joined
after running thread: MainThread
after running thread: asyncio_0
number of active threads: 2
finish succeeded
2024-10-24 18:23:30.204 | INFO     | pipecat.services.deepgram:_disconnect:201 - DeepgramSTTService#0: Disconnected from Deepgram
2024-10-24 18:23:30.205 | DEBUG    | pipecat.pipeline.runner:run:31 - Runner PipelineRunner#0 finished running PipelineTask#0

Looks like it was an issue with the dependencies not being upgraded with pipecat. Also had to initialise Deepgram like this to make it work:
    client = DeepgramSTTService(
          api_key=os.getenv("DEEPGRAM_API_KEY"),
          live_options=LiveOptions(
              model="nova-2",
              language=lang_code,
              sample_rate=16000,
              encoding="linear16",
          ),
      )


Blockchain Fuzzer - Part 2

Continue on the blockchain fuzzer so we can use it on the testnet

Stub, closing.


AP-2722 Remove ApplicationProceedingType from UsedDelegatedFunctionsController

Remove ApplicationProceedingType from UsedDelegatedFunctionsController
Link to story
The UsedDelegatedFunctionsController was set up to update both Proceeding records and ApplicationProceedingType records with DF date.  This PR removes the updates to the ApplicationProceedingType
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

@stephenrichards I had a question, https://dsdmoj.atlassian.net/browse/AP-2722 talks about removing the dependencies on proceeding_type in the remove_delegated_scope_limitations, add_delegated_scope_limitations and update_delegated_scope_limitations methods in UsedDelegatedFunctionsController. I know when I looked at this controller previously I thought we couldn't yet do that (because proceeding_type is required by AddAssignedScopeLimitationService which is called in multiple places) - do you think that is still the case?

Hi @kmahern - I'll look at this again, but I think that now the scope limitations data is held on the Proceeding record, and all the Check your answer pages, merits report and CCMS payload all use the Proceeding model for their data source, we don't really care any more what is on the application proceeding types scope limtiations records.  Having said that, I thought I'd removed a call to one of the services that takes care of all that, but I don't see that in the changes on this PR, so am going to take another close look.
Thanks for the heads-up


Crypto Primitives Abstraction Layer

This PR introduces an abstraction layer for cryptographic primitives in the hax_lib_protocol crate and rewrites the Noise example to use only that.
The abstraction layer at the moment is just a thin wrapper around libcrux but in the future could be extended to other backends.
Two things before this is ready for review:

[x] Docs for the abstraction layer
[ ] ProVerif extraction of the Noise example seems to go into an infinite loop

Fixes #453.

Just curious, will it fit with the crates in https://github.com/RustCrypto ?
They are interested in hacspec integration:
https://github.com/RustCrypto/meta/issues/9


Set explicitly output path for simulate_prod

Closes #680
Output paths are set explicitly for simulate_prod. Allows to run "cleaner" integration tests without spurious files leftover.
Requires to add --output_path ./ to obtain original behavior (meaning: writing the production configuration into the current directory).

@orelgueta - ok, these changes are fine with me. Do you approve the PR so I don't have to bypass the branch protection?

I merge main and it looks clean now. I am waiting for the tests before merging.


Html hexviewer for Metal Def tokens

Java code to generate a html hexviewer.
After generating the html, open the source file to load the hex editor

This code should probably be merged to metal-util

[Current coverage][cc-pull] is 84.48%

Merging [#41][cc-pull] into [master][cc-base-branch] will decrease coverage by 10.70%

@@             master        #41   diff @@
==========================================
  Files            70         71     +1
  Lines           769        825    +56
  Methods           0          0
  Messages          0          0
  Branches        160        171    +11
==========================================
- Hits            732        697    -35
- Misses           37        104    +67
- Partials          0         24    +24

Powered by Codecov. Last updated by [7b878e1...51a52eb][cc-compare]
[cc-base-branch]: https://codecov.io/gh/parsingdata/metal/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/parsingdata/metal/compare/7b878e197214711a014ac29f6c96b4c94723ce71...51a52ebb424758e66223b767f06d7dcbe9d66c0b
[cc-pull]: https://codecov.io/gh/parsingdata/metal/pull/41?src=pr


Powershell Core Windows Exporer integration disappears after automatic Windows Update

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Download PowerShell Core installer PowerShell-7.2.5-win-x64.msi
During installation select options:

Add 'Open here' context menus to Explorer
Add 'Run with PowerShell 7' context menu for PowerShell files
Choose options to allow updating PowerShell through Automatic  Windows Update.
Check that Windows Explorer Integration installed correctly.
Wait until PowerShell updates to version 7.2.6 with Automatic Windows Update.
Observe that Window Explorer Integration disappears

Expected behavior
Expected: PowerShell Core Windows Explorer Integration should not disappear after automatic Windows Update

Actual behavior
Powershell Core Windows Explorer integration installed with options:
- Add 'Open here' context menus to Exporer
- Add 'Run with PowerShell 7' context menu for PowerShell files
disappears after PowerShell was updated trhough Windows Update.

Environment:

[System.Environment]::OSVersion.Version

Major  Minor  Build  Revision
-----  -----  -----  --------
10     0      19044  0

$psversiontable

Name                           Value
----                           -----
PSVersion                      7.2.6
PSEdition                      Core
GitCommitId                    7.2.6
OS                             Microsoft Windows 10.0.19044
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

The previous powershell version installed was 7.2.5

Error details
No response
Environment data
$psversiontable

Name                           Value
----                           -----
PSVersion                      7.2.6
PSEdition                      Core
GitCommitId                    7.2.6
OS                             Microsoft Windows 10.0.19044
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals

Can you show $PSVersionTable before the update? Platform: Win32NT looks suspicious to me. From my experience with other programs, shell integration is one of the few things that does not work when installing 32bit programs on 64bit system, and the installer you mention is 64bit. So it may be a bug in Windows Update which incorrectly chooses 32bit version when upgrading.

There are also several options you can try to determine whether PowerShell is 32bit or 64bit https://stackoverflow.com/questions/8588960/determine-if-current-powershell-process-is-32-bit-or-64-bit

I am not sure how I can to show the $PSVersionTable of already updated version, but since I had installed it in a first place. I know for sure what it was:
PS D:\distrib\Microsoft\PowerShell\7.2.5> get-filehash *.msi

Algorithm       Hash                                                                   Path
---------       ----                                                                   ----
SHA256          632A69EA46F966A03A1EE0AA1647C5970DF7B5936BDF27DF3CF18E6C63C21198       D:\distrib\Microsoft\PowerShell\7.2.5\PowerShell-7.2.5-win-x64.msi
		632a69ea46f966a03a1ee0aa1647c5970df7b5936bdf27df3cf18e6c63c21198 *PowerShell-7.2.5-win-x64.msi

To fix the issue I removed  updated version 7.2.6 downloaded installer:
PS D:\distrib\Microsoft\PowerShell\7.2.5> get-filehash *.msi

Algorithm       Hash                                                                   Path
---------       ----                                                                   ----
SHA256          632A69EA46F966A03A1EE0AA1647C5970DF7B5936BDF27DF3CF18E6C63C21198       D:\distrib\Microsoft\PowerShell\7.2.5\PowerShell-7.2.5-win-x64.msi
		632a69ea46f966a03a1ee0aa1647c5970df7b5936bdf27df3cf18e6c63c21198 *PowerShell-7.2.5-win-x64.msi

and installed it. This is what $psversiontable looks right now:
$psversiontable

Name                           Value
----                           -----
PSVersion                      7.2.6
PSEdition                      Core
GitCommitId                    7.2.6
OS                             Microsoft Windows 10.0.19044
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

it shows Win32NT despite the fact I was installing PowerShell-7.2.5-win-x64.msi

> [Environment]::Is64BitProcess
True

(Are there any other issues open/closed similar to this?)

a few open ones, anyway :P I noticed a new version of PowerShell, and was hoping the change logs would mention this fix. alas.

https://github.com/PowerShell/PowerShell/issues/18791
https://github.com/PowerShell/PowerShell/issues/18479
https://github.com/PowerShell/PowerShell/issues/16886

/see: #20420


Update API docs

Currently the generated API docs include "api" in the path, eg,
http://<servername>/api/isValidMSA/:activityYear/:msa
However, no Kraken controller exists for /api and as such all the example routes are incorrect (dropping the /api part makes them valid).
Perhaps this was included in case the api was sitting behind a reverse proxy which required additional path components to reach the api but then only passed the remaining path fragments, eg, curl server/some/path/isValidMSA/12345 but the app only sees the /isValidMSA/12345 part.
Either way, I'd say remove /api from the docs and perhaps include a note about how to deal with the api not accepting requests at the root path of the server.

This is definitely a shortcoming in the documentation. To get around CORS issues, it is best to run the API bits behind a proxy within the same FQDN that the frontend (hmda-pilot) is running. This ensures that everything is requested from the same FQDN, thus eliminating issues with CORS.


Update MAINTAINERS.md

Add David Powers to list
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #649 (9123a9c) into main (3abb3f7) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #649      +/-   ##
============================================
+ Coverage     91.50%   91.61%   +0.11%
- Complexity      599      602       +3
============================================
  Files            75       75
  Lines          1813     1813
  Branches        152      152
============================================
+ Hits           1659     1661       +2
  Misses          116      116
+ Partials         38       36       -2

Impacted Files
Coverage Δ

...com/amazon/dataprepper/pipeline/ProcessWorker.java
91.42% <0.00%> (+5.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abb3f7...9123a9c. Read the comment docs.

Closing in favor of #650.


1.11.2 cherry pick

The following commits have been cherry-picked:
5ff18be6d92a50d40727e6e8729ce2074191c1fc (#23067) Fixes Issue #22992: docker commit failing.
e24f320dd1a05f03c4f6ad6ee028b12deae6c443 (#22922) Enable seccomp on ppc64le
bde0bcf2d8112615c3015ac49a481b5af2e08e23 (#23032) Fix directory walker error checking
6d17d5bf9e3df79ecca891c45423ced79a1f48d6 (#22918) Release memoryStore locks before filter/apply
a8dc0ba83a4da515d4a2b22a890fe8cdfa168b3d (#22836) Update port info on network connect/disconnect
966e9126bb7f1f77f70b85d29da72e998b7231a8 (#22561) Wait for discovery on container start error
4a26a657994881caeefbffe6b62d45fed5c9284f (#22227) Bump Go version to 1.6.2 from 1.6.1 where it was used
d84150ab382661dd50cfcb65b144c4a1523370da (#22168) Add refcounts to graphdrivers that use fsdiff

That should be all the cherry-picks, just need to wait for this to go green :)

can you update the description to include the last two cherry picks as well?

will do
On Fri, May 27, 2016 at 3:32 PM Sebastiaan van Stijn <
<EMAIL_ADDRESS>wrote:

can you update the description to include the last two cherry picks as
well?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/pull/23058#issuecomment-222267294, or mute
the thread
https://github.com/notifications/unsubscribe/APUifv1sv8hb4Mivromc1aZAS-hKZiG_ks5qF3D1gaJpZM4IonhV
.

Fixed the last cherry-pick @crosbymichael

LGTM

LGTM


feat: 🎸 return X-Revision header when possible on endpoints

it will help show the status of the cache entry on the Hub.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Codecov Report
Patch coverage: 53.33% and project coverage change: -2.87 :warning:

Comparison is base (a85b086) 90.03% compared to head (b2b6b77) 87.17%.

:exclamation: Current head b2b6b77 differs from pull request most recent head c2480d2. Consider uploading reports for the commit c2480d2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
- Coverage   90.03%   87.17%   -2.87%
==========================================
  Files         186       23     -163
  Lines        9986     1458    -8528
==========================================
- Hits         8991     1271    -7720
+ Misses        995      187     -808

Flag
Coverage Δ

jobs_cache_maintenance
?

jobs_mongodb_migration
?

libs_libcommon
?

services_admin
?

services_api
87.17% <53.33%> (-0.21%)
:arrow_down:

services_worker
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

services/api/src/api/routes/webhook.py
65.85% <30.00%> (ø)

services/api/src/api/routes/rows.py
69.34% <33.33%> (-0.40%)
:arrow_down:

services/api/src/api/routes/endpoint.py
77.86% <50.00%> (-0.47%)
:arrow_down:

services/api/src/api/utils.py
90.47% <83.33%> (-1.33%)
:arrow_down:

services/api/tests/routes/test_endpoint.py
100.00% <100.00%> (ø)

services/api/tests/test_app_real.py
80.64% <100.00%> (ø)

... and 163 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Does this project support "connection pool" for the moment?

As the title puts.

Hi,
There is actually no explicit support for connection pooling.
By default, cpp_redis uses tacopie for its network communication.
Tacopie does not do any connection pooling and cpp_redis does not do any on top of tacopie.
However, since yesterday with #58, it is possible to use cpp_redis without tacopie and to specify its own tcp_client implementation using the cpp_redis::network::tcp_client_iface.
From my point of view, you can do connection pooling at that place, but that requires some extra work considering the fact it is not provided by the cpp_redis itself.
I didn't have the time to write some documentation about that yet, but basically, you have to derive from tcp_client_iface and implement the abstract methods (connect, disconnect, is_connected, async_read, async_write) and make sure the async_read/async_write calls the given callbacks on completion.
Once done, you have to set get_tcp_client such that it is a function that returns your own tcp_client (your derived class of tcp_client_iface).
There is an "example" here. That's basically the implementation used for tacopie.
So not explicitly available, but achievable if necessary, though not convenient I must admit.
For your information, I do not plan to integrate this feature in a near feature (but PR are welcome of course).
Best

I close this issue but feel free to reopen it if necessary.
I'll also notify this ticket once the documentation about the custom tcp_client will be available.
Best

Much appreciated, Cylix =)


Android UserLAnd support

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

Absolutely nothing
Description

I've tried installing on android but after installation on each of the subsystems it never actually downloaded ANYTHING.
Please review this.

How did you try to install it?
#30839 tells you how to search.
#30860 gives example commands for an Android installation.
In principle:

you need a package (or packages) that gives you a command shell in a terminal "window" with a supported Python;
then follow the instructions for a Unix-like (POSIX) installation;
use the nightly build rather than the 2021.12.17 release - you would have to modify the final pip command in the above example to do that.

If you try to run the POSIX self-extracting build and no supported Python on your PATH is named python, you will need to make a link to a supported Python (maybe called python3) with that name in the PATH.
Having done any of this, you should have some terminal text to paste in the issue to illustrate any problem that occurs.

@Marty-coder-dev ?

Well, after trying all that, this still doesn't work, but it might be the problem that I've modified it. The modification makes it slightly bigger on the screen and the input is autocorrected once it tries to execute the command with an error and it doesn't show the autocorrected things, I could add the special commands, that might be the problem.

If that's the problem, I'll try to add the special command.

If that's the problem, I'll try to add the special command. And, I might just open my own repository for the mods I've made.

Anything that clarifies how you are using the program would help. For the moment I'm going to assume that you have a problem like this mentioned in #30839, and so close the issue (you are the support channel for your own code):

If your problem occurred when running another package that invokes youtube-dl, try to reproduce the problem with a youtube-dl ... command, or report it through the support channel for the other package; similarly if the problem occurred when running your own code.


upgrade storybook@alpha to use emotion version 10

I'm running into an issue using @emotion/core@next
export withCSSContext was not found in @emotion/core
this is due to the API changing in emotion 10.

@igor-dv do you know who might be able to look into this?

@igor-dv it's no longer in beta.

🔥
I suppose it will be handled soon by our @dependabot-bot . But you can submit a PR 😉

If in one project use last versions of storybook and emotion it cases missing styles in storybook UI

Probably the problem is that mjs module is loaded which uses an import statement of @emotion/core. Since it tries to resolve it uses the newer @emotion/core 10 version. Hopefully they fix this in the near future since Emotion 10 has some strong features (such as the css prop/attribute now can be used without the babel plugin which enables to fully compile with only TypeScript)

update on the progress:
I merged the PR into a feature branch that will go live in january.

#4086

nice

@ndelangen any chance this could be released before that major update? I can help out if needed.


Maybe make the changer for gloves?

Like the title.Inventory changer and skinchanger(knife/weapon) works perfectly.But the glove changer dose not work.
If you have time to make the function.That would be thankful!

He stated clearly that he doesnt support the SkinChanger anymore and got rid of it. v1 is a perfect base which you can simply modify. Gloves are now in the Viewmodel.
More Infos are in this UC Thread -> https://www.unknowncheats.me/forum/counter-strike-2-a/604003-change-gloves.html


Support static assets for Razor Class Libraries

Phase one

[ ] Plug-in Razor Class Libraries targets within the Razor SDK.
[ ] Implement GetAspNetCoreStaticAssets
[ ] Implement GenerateAspNetCoreStaticAssetsManifest

[ ] Capture static asset inputs (referenced packages, referenced projects, content paths) and generate a cache file.
[ ] Add tool to generate the manifest when the inputs get updated.
[ ] Add task to invoke the manifest generation tool with the provided inputs.

[ ] (External) Implement simple middleware/extension method to serve static assets based on the generated manifest file.

Phase two

[ ] Implement AspNetCoreAssetsGetCopyToPublishDirectory to copy files to the output directory.

I meant to create this as a draft pull request.


USER POLL: Maximum username length

We want people to be able to choose a username which suits them but longer names mean less space for chat messages, filenames, etc.
If we were to limit the maximum length of the username, what is the shortest limit which would be reasonable for Syncplay?

I don't know about the shortest, but preferably it'd be nice if three-character names are possible.

I would not go below 10 characters.

I think 16 is probably a reasonable maximum.

Across all mediums we had 15 responses to our lowest reasonable maximum username length poll:

13% were happy with less than 8 characters
27% were happy with 8+
60% were happy with 10+
73% were happy with 12+
80% were happy with 15+
100% were happy with 16+

Outside of this poll other ideas have been put forward such as having no limit, having a per-client limit, and having a 32-character limit.


[WIP] ElseifFixer - remove HHVM hack

remove hack after fix of https://github.com/facebook/hhvm/issues/4796
probably need to wait a bit for stable HHVM release

Maybe we should still include this work around, but just do a comparison on the hhvm version?

Looks like it'll be ages until this gets into the next hhvm lts release. We'll have to wait until 3.9 is released for that.

No need to merge it now, as I said we can wait a bit.
I hate any hacks for hhvm bugs, when they fix it we will remove it. We do not support multiple hhvm versions.

No need to merge it now, as I said we can wait a bit.

I'm suggesting we modify it to instead do a comparison of the hhvm version. It would be incorrect for us to apply this patch to hhvm 3.7+.

Yes, I do understand you, just not agree with it.
We do not support hhvm like 3.6, 3.7 etc. Just the latest stable.
This is not our bug that we should fix - it's hhvm's bug that they should fix. And they do.
We should not create a workaround for every bug that hhvm has have.
We are already super cool that we have removed hhvm from our allow_failures matrix ;)

I'm with @keradus, supporting the latest stable hhvm is enough.

@keradus HHVM 3.3 is an LTS version, so it should be supported too

HHVM 3.3 is an LTS version, so it should be supported too

That's what I said. Also, so is HHVM 3.6, and only HHVM 3.7+ has the fix.

Or, rather, 3.7+ has all the fixes, earlier versions had other stuff fixed.

@keradus HHVM 3.3 is an LTS version, so it should be supported too

then the bug fixes should go there, don't they?

then the bug fixes should go there, don't they?

They don't backport all bug fixes, no. See http://hhvm.com/blog/6083/hhvm-long-term-support for their description of what goes in the LTS.

then the bug fixes should go there, don't they?

No, only security fixes.

I really do not want to support bunch of hhvm version.
Personally I would throw hhvm support away, but I won't, due to fact some of us want to use it. It was hard enough to remove hhvm from our failure matrix.
Fb had already shown few times that they don't care to be compatible with PHP's tokenizer.
Therefore, IMO, is is enough to keep support of latest stable.
We could even terminate tool on unsupported version like we do with old PHP.

I really do not want to support bunch of hhvm version.

I agree.

Personally I would throw hhvm support away

I think we should still try to support HHVM though, even if we support the latest versions only.

We could even terminate tool on unsupported version like we do with old PHP.

if we terminate clearly (with an explanation), I agree about such change

Then decided.
To be honest I don't know how to properly detect version of hhvm - anyone willing to create such PR ?

@keradus they have a HHVM_VERSION constant. You already use the fact that the constant is defined to detect HHVM. Just use the value of the constant to get the version :smile:

HHVM version check added

btw, this started to work on hhvm-nightly ;)

@keradus looks like 3.5.0 is not actually the lowest version for which the current hacks are not necessary anymore

Yeah, we will need to bump it when current dev will become current stable, just don't know what the number will be.
One way or another it won't be merged until then, so we just need to wait a bit longer.

Yeah, we will need to bump it when current dev will become current stable, just don't know what the number will be.

Yes we do. The master hhvm branch will be the next minor version, guarenteed.

good to go

:+1:


Use Windows system commit to limit workers

Prerequisite for #25863

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.


update default value of --must-change-password cli flag

Fixes the confusion caused at https://github.com/go-gitea/gitea/issues/6005

Codecov Report

Merging #6032 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6032   +/-   ##
=======================================
  Coverage   38.72%   38.72%
=======================================
  Files         339      339
  Lines       49013    49013
=======================================
  Hits        18982    18982
  Misses      27284    27284
  Partials     2747     2747

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d8178b...bb8c2ba. Read the comment docs.