Flutter Devices: Add 'chrome on mobile' as a new deployment target

Use case
Developing for web is often mobile first and as such it would be great to test be able to launch the web app directly on an attached mobile device or emulator running chrome.
This should be possible
 flutter run -d chrome-mobile --web-hostname localhost --web-port 5000
Currently my workaround is:
 flutter run -d web-server --web-hostname <IP_ADDRESS> --web-port 5000
But this is lacking the debug connection back to the IDE and the website still has to be opened manually on the device. Also AFAIK firebase auth does not work without registering some local domain and adding a reverse proxy.
Proposal
Using adb it is possible to push a new tab to a connected Android device using the chrome devtools (chrome://inspect/#devices) and then inspect and debug it.
This connection should also be possible to be forwarded and directly attached to the flutter devtools.

As a first workaround I wrote a little script which can start the web-server and open it on android, debug/devtools connetion is still missing -  https://stackoverflow.com/questions/65024691/how-to-run-flutter-web-on-mobile-chrome-from-ide
`#!/usr/bin/expect -f
set timeout -1
spawn sh -i -c {
flutter run -d web-server --web-port 49403
}
set run_id $spawn_id
expect "For a more detailed help message, press "h". To quit, press "q"."
spawn sh -c {
adb reverse tcp:49403 tcp:49403
adb shell am start -a android.intent.action.VIEW -d http://localhost:49403
}
interact -i $run_id`


Raspberry Pi 4 support?

After completing steps from installation lcg doesn't work.
My go installation is for arm64 and it works and completes the build command.
But after creating a symlink when I try to run the command I get "command not found" or when in ~/.linux-command-gpt it says "cannot execute binary file".

For symlink I have just used the command provided in installation guide:

ln -s ~/.linux-command-gpt/lcg ~/.local/bin

There is my $PATH:

echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin

Something like that? Sorry I this is a dumb question, but my knowledge on linux is limited.

ln -s ~/.linux-command-gpt/lcg /usr/local/go/bin
Or can you tell me how to add this to $PATH correctly?

That is correct symlink, but you need sudo command as I know /user/ is owned by root

Working, thanks a lot!


Document user namespace changes in v1.27 (KEP-127)

Placeholder PR to document the changes in Kubernetes v1.27 for user namespaces (KEP-127)

cc @giuseppe

Remember to change the base branch and target the dev-1.27 branch
/milestone 1.27
/cc @mickeyboxell

@reylejano thanks, fixed that now!

Hi @rata  👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.
This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@mickeyboxell thanks, this should be ready for review now!

Pushed a new revision, PTAL

/label tide/merge-method-squash
/lgtm

@tengqm Can you PTAL?
I've added a new commit duplicating a warning about versions. It seems it is better to be super clear about this and not have it only in some pages and not others.
I'm trying to err on the side of being very clear as a learning from another (not related to this) bug report where doc was the issue.

/approve

Updated this PR to address similar comments that were raised in this other PR and also applied here: https://github.com/kubernetes/website/pull/40264

@sftim fixed all, thanks! PTAL

/lgtm
reapplied.


Breaking API change on minor version

First of all thanks for writing this component, it works very well and is very accessible.
While developing my project I noticed that my autocompletion code broke between two npm install – namely the onSuggestionUpdateRequested callback. The reason is quite simple: an API change was introduced in https://github.com/moroshko/react-autosuggest/commit/ef0934bea7429aea3e5b85bb53b05825f16daebf.
It might seem like a minor change to switch the function signature from onSuggestionsUpdateRequested(value) to onSuggestionsUpdateRequested({value, reason: 'string'} but it's more than enough to break the code that relies on this. If this project follows semver, such changes should be reflected by a major version bump so that people updating their dependencies can expect forward compatibility issues.
I don't think there is a particular fix for this instance of the issue. Version 3.2.0 was short-lived so it's mostly bad luck on my side to happen to download that particular one. I'd just advise caution for future updates.

@ThibWeb Thanks for this issue. I completely agree, and aware of semver. I was hoping that no one will be affected by this "short lived breaking change". This is a good lesson for me :) I'll try to do a better job in the future following semver.

:+1: it didn't cause much harm in the end, I figured it out quite quickly.
Thank you for your work!


fix(replace postcode autocomplete attr to postal-code): replace postcode

replace postcode autocomplete attr to postal-code
https://pins-ds.atlassian.net/jira/software/c/projects/ASB/boards/166?modal=detail&selectedIssue=ASB-341

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Concept: Portability

AB#9071

@jonvsm Is this addressed by the Multi-Cloud and Open-Source concept page?
Webpage: https://edge.docs.radapp.io/concepts/multi-cloud-concept/


[HUDI-2029] Implement compression for DiskBasedMap in Spillable Map

What is the purpose of the pull request
Based on our benchmark of ExternalSpillableMap with large data, we noticed that higher amount of data is spilled to disk when using DiskBasedMap when compared to RocksDb, causing much higher GET latencies. One strong reason for this was that compression was not being used in DiskBasedMap, while RocksDb uses compression. This PR adds a way to enable compression when storing KVs in DiskBasedMap that should alleviate such perf concerns.
Brief change log

Added compression and decompression when storing KVs in DiskBasedMap.java

Verify this pull request

Added tests to TestDiskBasedMap.java and TestExternalSpillableMap.java

Codecov Report

Merging #3128 (264aaba) into master (c08fbb4) will increase coverage by 3.86%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3128      +/-   ##
============================================
+ Coverage     46.01%   49.88%   +3.86%
+ Complexity     5306      394    -4912
============================================
  Files           911       66     -845
  Lines         39476     2919   -36557
  Branches       4254      318    -3936
============================================
- Hits          18166     1456   -16710
+ Misses        19456     1327   -18129
+ Partials       1854      136    -1718

Flag
Coverage Δ

hudicli
?

hudiclient
?

hudicommon
?

hudiflink
?

hudihadoopmr
?

hudisparkdatasource
?

hudisync
?

huditimelineservice
?

hudiutilities
49.88% <ø> (-8.50%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ies/exception/HoodieSnapshotExporterException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/hudi/utilities/HoodieSnapshotExporter.java
5.17% <0.00%> (-83.63%)
:arrow_down:

...hudi/utilities/schema/JdbcbasedSchemaProvider.java
0.00% <0.00%> (-72.23%)
:arrow_down:

...org/apache/hudi/utilities/HDFSParquetImporter.java
0.00% <0.00%> (-71.82%)
:arrow_down:

...he/hudi/utilities/transform/AWSDmsTransformer.java
0.00% <0.00%> (-66.67%)
:arrow_down:

...in/java/org/apache/hudi/utilities/UtilHelpers.java
40.69% <0.00%> (-23.84%)
:arrow_down:

...rg/apache/hudi/utilities/HoodieSnapshotCopier.java
0.00% <0.00%> (-13.80%)
:arrow_down:

...hudi/utilities/sources/helpers/KafkaOffsetGen.java
86.36% <0.00%> (-0.91%)
:arrow_down:

...e/hudi/sink/transform/RowDataToHoodieFunction.java

...rg/apache/hudi/cli/commands/HoodieSyncCommand.java

... and 838 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08fbb4...264aaba. Read the comment docs.

Looks like there are some checkstyle issues. Can you please look into it.

@nsivabalan do you want to take this home?

sure, will take care of this


Codegen writes too many files

Describe the bug
The types for the cli does state that some hooks (e.g. afterOneFileWrite) are not called if the generated file did not change.
This is not the case, files are written all the time. If these files are part of other watchers (e.g. typescript) this will trigger an unncessesary compile cycle.
To Reproduce
Steps to reproduce the behavior:
Have a setup with a graphql file and run the cli.
The hooks will be triggered and the timestamps on the FS changed.
Expected behavior
It would be good to not write files which are identical byte-by-byte.

We do have some code that should prevent writing to the FS during watch mode, when possible. Maybe something is broken and should be improved.
Thank you for reporting this @KnisterPeter , any chance you can share a reproduction of your setup?

Hi, maybe I've miss understood that. I was not referring to watch mode.
If you like I can propose a PR which implements the missing parts for non watch mode.

Hi, maybe I've miss understood that. I was not referring to watch mode.
If you like I can propose a PR which implements the missing parts for non watch mode.

Sure, this could be amazing. Here's a reference to the piece of code I mentioned: https://github.com/dotansimha/graphql-code-generator/blob/master/packages/graphql-codegen-cli/src/generate-and-save.ts#L56-L60 , I think it runs even on non-watch mode, but probably could be improved a lot.  Thank you!

I don't repro this bug with the latest version of codegen core and CLI.
If the source GraphQL documents and schema are unchanged, the generated file is untouched and the afterOneFileWrite hook is not called.


removed ConstructionBase from dependency

During the registration, auto-merge is blocked due to compatibility problems with ConstructionBase. See https://github.com/JuliaRegistries/General/pull/109685 for details.
This hotfix removes ConstructionBase from the dependencies. It shall go directly to main, and will be backported to dev afterwards.

Can't ConstructionBase just generally be removed from this repository? The usage is now only in QEDcore, no?

This is what this PR does 🤷♂


Doom PAL on NTSC-J not working

Playstation SCPH-7000
Cheap 1mb memory card in slot 2
Console tested with NTSC-J games: Silent hill, Tekken 1, Tekken 2, Grand turismo - every games work on first try both on stock boot and freePSXBoot
PAL Doom, tryed "Play", "Boot PAL->NTSC" same error, first try it start to spin normal, on second try it sometimes make weird cd-rom sound (like it spinning with max speed) for a sec and still give same error.

here is video of two boots same config PAL -> NTSC:
https://github.com/brad-lin/FreePSXBoot/assets/49843660/b9fee707-ce77-4de5-9894-603e423c8b88
Second video shows NTSC-J game loading on first try:
https://github.com/brad-lin/FreePSXBoot/assets/49843660/c1323fb7-2fcd-4758-9c1c-fdade6c765aa

ok i try this: https://github.com/brad-lin/FreePSXBoot/issues/113#issuecomment-2062164819
but it freeze on first loading screen


Run undockerized

Hi,
Is the anyway to use metabase-clickhouse in an undockerized metabase?

Thanks for your interest in this project. I recently updated the Readme with a section on how to test the driver using the official jar file. If you think the instructions should be improved, please create a PR. Basically, you'll just have to

Download a fairly recent MetaBase binary release (jar file) from the MetaBase distribution page.
Download the ClickHouse driver jar from this repository's "Releases" page
Create a directory and copy the metabase.jar to it.
In that directory create a sub-directory called plugins.
Copy the ClickHouse driver jar to the plugins directory.
Make sure you are the in the directory where your metabase.jar lives.
Run MB_PLUGINS_DIR=./plugins; java -jar metabase.jar.

Please let me know if you encounter any issues.

First of all, thank you for reply.
I did it all this things but i still dont get to quering a csv endpoint.
Do i have to create a Database in metabase using Database type "ClickHouse"? Whats the parameters to connect?
Do i have to install ClickHouse Database?
I just wanna consuming a csv like this:
SELECT
*
FROM url(
'https://raw.githubusercontent.com/oncletom/coursera-ml/master/week-1/people-example.csv',
CSVWithNames,
'firstname String, lastname String, country String, age UInt32'
)

This project is about connecting MetaBase with a ClickHouse database.
I noticed that @AlexeyKupershtokh has used a ClickHouse database for proxying in metabase/metabase#4831, but If you only want to consume CSV and have no other use cases for ClickHouse database, there are probably easier ways to make the data accessible via MetaBase.  E.g. use PostgreSQL foreign data wrapper for CSV.
If you still want to use a ClickHouse database, you'll have to install the database, and follow the instructions I posted above. You can then set up your ClickHouse database as a backend in your MetaBase application. If you encounter any issues with this driver, please let us know.


Buffers are stored with 0-length in header

When storing a buffer, the length will always be 0, which is obviously an issue when reading the data back.
var storage = require('filestorage').create();
var id = storage.insert('file.txt', new Buffer('hello world', 'utf-8'), null, function(err, id, stat) {
  console.log(stat);

  storage.stat(id, function(err,stat) {
    console.log(stat);
  });
});

$ node test.js
{ name: 'file.txt',
  extension: 'txt',
  type: 'text/plain',
  width: 0,
  height: 0,
  length: 0,
  custom: null,
  stamp:<PHONE_NUMBER>626 }
{ name: 'file.txt',
  extension: 'txt',
  type: 'text/plain',
  width: 0,
  height: 0,
  length: 0,
  custom: null,
  stamp:<PHONE_NUMBER>626 }

To work around this issue, one can wrap the buffer in a stream:
var stream = require( "stream" );
var bufferStream = new stream.PassThrough();
bufferStream.end( buffer );

Hi @oliversalzburg,
I'll check it today.
Thanks!

That'd be awesome :)
When I was debugging, I ended up at https://github.com/petersirka/node-filestorage/blob/master/index.js#L185. stats.size here refers to the stats object relating to the temporary file, which is still at 0. I hope that's helpful to you.
Cheers

I have fixed the problem with length. You can test it.
Thanks! I'll publish it today into the NPM.

Yep. Seems to work great. Thanks a lot for the quick fix :+1:

I have published a new version into the NPM.
Thanks.


[VS Code] The SSL connection could not be established, see inner exception.

Error:
The SSL connection could not be established, see inner exception.
Steps to Reproduce:

Version Data

extensionName
VSLS

extensionVersion
0.3.504

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.25.1

platformName
Linux

platformVersion
4.4.0-130-generic

@bagasmeyca  Can you please get the logs by running the Live Share: Export Logs command from VS Code command palette. The command will ask you for the zip file location, and will save the logs into that file. You can then attach the file to the issue.

Go into /etc/ssl/certs and look for the broken symlinks, then rm -rf them. This will certainly make Live Share work normally. The reason why it happens must be some symlink verification at the SSL certificates or something.


Sports Betting - Scalar Label

https://www.figma.com/file/42QoTLQcbObu7esoTPjWRv/Augur-Bet---Design-System?node-id=17%3A12
update the scalar label in betting/sports UI to look like the above.

Close?


Foundry v12 import actors not working

Versions
FoundryVTT: v12.328
DCC: v0.42.0
Description:
I try to import actors, but receive this error

Thanks for your report! I am going to push out a fix for the deprecation warning, but I don't think that was the actual source of the issue. 🤔  Once I push that fix out, please give it a try again, and post the purple sorcerer text you are using if you still have the issue.

Hello.
I tested it on v0.43.0, but the problem still exists. I disabled all modules, including dcc-qol and dcc-core-compendium. The error looks the same:

This time, I tried to import just one character; this is a plain text from Purple sorcerer:
Generator Settings
Source: Rulebook | Roll Mode: 3d6 | HP: normal | Augur: normal

0-level Occupation: Halfling mariner
Strength: 7 (-1)
Agility: 9 (0)
Stamina: 13 (+1)
Personality: 10 (0)
Intelligence: 7 (-1)
Luck: 6 (-1)

AC: 10; HP: 3
Weapon: Knife (as dagger) -1 (1d4-1)
Speed: 20; Init: 0; Ref: 0; Fort: 1; Will: 0

Equipment: Holy symbol (25 gp)
Trade good: Sailcloth (2 yards)
Starting Funds: 43 cp
Lucky sign: Seventh son (Spell checks) (-1)
Languages: English, Halfling
Racial Traits: Halfling ability: Infravision

It is working for me. Are you self hosted or on Forge?

Also you might try in a fresh world and see if that makes a difference.

@algnc I host foundry on EC2 in AWS.
@cyface, this is a new empty world; I just started preparing for my first game in this system.
This world was migrated from foundry v11 to v12; this may be an issue. I'll try today to create a new world and test it there

I tested this in an empty world without any scenes or modules.
Error the same:

Plain text for import:
Generator Settings
Source: Rulebook | Roll Mode: 3d6 | HP: normal | Augur: toggle

0-level Occupation: Jester
Strength: 14 (+1)
Agility: 11 (0)
Stamina: 8 (-1)
Personality: 15 (+1)
Intelligence: 7 (-1)
Luck: 11 (0)

AC: 10; HP: 1
Weapon: Dart +0 (1d4+1)
Speed: 30; Init: 0; Ref: 0; Fort: -1; Will: 1

Equipment: Rope - 50' (25 cp)
Trade good: Silk clothes
Starting Funds: 29 cp
Lucky sign: Born under the loom (Skill checks, including thief)
Languages: Common

0-level Occupation: Soldier
Strength: 12 (0)
Agility: 10 (0)
Stamina: 5 (-2)
Personality: 10 (0)
Intelligence: 8 (-1)
Luck: 6 (-1)

AC: 11; HP: 1
Weapon: Spear +0 (1d8)
Speed: 30; Init: 0; Ref: -1; Fort: -2; Will: 0

Equipment: Waterskin (5 sp)
Trade good: Shield
Starting Funds: 37 cp
Lucky sign: Struck by lightning (Reflex saving throws) (-1)
Languages: Common

0-level Occupation: Dwarven mushroom-farmer
Strength: 9 (0)
Agility: 15 (+1)
Stamina: 15 (+1)
Personality: 8 (-1)
Intelligence: 13 (+1)
Luck: 8 (-1)

AC: 11; HP: 2
Weapon: Shovel (as staff) +0 (1d4)
Speed: 20; Init: 1; Ref: 1; Fort: 1; Will: -1

Equipment: Iron spike (1 sp)
Trade good: Sack
Starting Funds: 28 cp
Lucky sign: Survived the plague (Magical healing) (-1)
Languages: English, Dwarf, Gnome
Racial Traits: Dwarven ability: Infravision

0-level Occupation: Halfling haberdasher
Strength: 10 (0)
Agility: 10 (0)
Stamina: 11 (0)
Personality: 9 (0)
Intelligence: 11 (0)
Luck: 8 (-1)

AC: 10; HP: 1
Weapon: Scissors (as dagger) +0 (1d4)
Speed: 20; Init: 0; Ref: 0; Fort: 0; Will: -1

Equipment: Flint and steel (15 cp)
Trade good: Fine suits (3 sets)
Starting Funds: 19 cp
Lucky sign: Resisted temptation (Willpower saving throws) (-1)
Languages: English, Halfling
Racial Traits: Halfling ability: Infravision

Also, I tested it in few different browsers, but result is the same.

Can you try it locally?
On Wed, Jul 10, 2024 at 2:53 AM Alexandr Semenov @.***>
wrote:

I tested this in an empty world without any scenes or modules.
Error the same:
image.png (view on web)
https://github.com/foundryvtt-dcc/dcc/assets/8062502/0ae50253-22b5-483e-a752-1f271acd6350
Plain text for import:
Generator Settings
Source: Rulebook | Roll Mode: 3d6 | HP: normal | Augur: toggle
0-level Occupation: Jester
Strength: 14 (+1)
Agility: 11 (0)
Stamina: 8 (-1)
Personality: 15 (+1)
Intelligence: 7 (-1)
Luck: 11 (0)
AC: 10; HP: 1
Weapon: Dart +0 (1d4+1)
Speed: 30; Init: 0; Ref: 0; Fort: -1; Will: 1
Equipment: Rope - 50' (25 cp)
Trade good: Silk clothes
Starting Funds: 29 cp
Lucky sign: Born under the loom (Skill checks, including thief)
Languages: Common
0-level Occupation: Soldier
Strength: 12 (0)
Agility: 10 (0)
Stamina: 5 (-2)
Personality: 10 (0)
Intelligence: 8 (-1)
Luck: 6 (-1)
AC: 11; HP: 1
Weapon: Spear +0 (1d8)
Speed: 30; Init: 0; Ref: -1; Fort: -2; Will: 0
Equipment: Waterskin (5 sp)
Trade good: Shield
Starting Funds: 37 cp
Lucky sign: Struck by lightning (Reflex saving throws) (-1)
Languages: Common
0-level Occupation: Dwarven mushroom-farmer
Strength: 9 (0)
Agility: 15 (+1)
Stamina: 15 (+1)
Personality: 8 (-1)
Intelligence: 13 (+1)
Luck: 8 (-1)
AC: 11; HP: 2
Weapon: Shovel (as staff) +0 (1d4)
Speed: 20; Init: 1; Ref: 1; Fort: 1; Will: -1
Equipment: Iron spike (1 sp)
Trade good: Sack
Starting Funds: 28 cp
Lucky sign: Survived the plague (Magical healing) (-1)
Languages: English, Dwarf, Gnome
Racial Traits: Dwarven ability: Infravision
0-level Occupation: Halfling haberdasher
Strength: 10 (0)
Agility: 10 (0)
Stamina: 11 (0)
Personality: 9 (0)
Intelligence: 11 (0)
Luck: 8 (-1)
AC: 10; HP: 1
Weapon: Scissors (as dagger) +0 (1d4)
Speed: 20; Init: 0; Ref: 0; Fort: 0; Will: -1
Equipment: Flint and steel (15 cp)
Trade good: Fine suits (3 sets)
Starting Funds: 19 cp
Lucky sign: Resisted temptation (Willpower saving throws) (-1)
Languages: English, Halfling
Racial Traits: Halfling ability: Infravision
Also, I tested it in few different browsers, but result is the same.
—
Reply to this email directly, view it on GitHub
https://github.com/foundryvtt-dcc/dcc/issues/412#issuecomment-2219936364,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAMEH6CNZVJMFPK2HZDA2TZLTY7FAVCNFSM6AAAAABKRJYXGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJZHEZTMMZWGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes, locally, it works with the same version of DCC and FoundryVTT.
Can I provide some additional information, maybe some logs?

@cyface @algnc
Oh, it works now, after I restarted the server in AWS. Strange, but OK. Anyway, thank's for your support!


issue: builder Radio input

Version Number
V7
Codesandbox/Expo snack
the bug is on the builder
Steps to reproduce

Go to 'builder'
add type 'radio'
nothing appears on code
See error

Expected behaviour
Each time you add an input in the builder the code generate automatically, which is not the case with radio button input.
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@BrainDev333 The bug is because you don't add a Options when you create a radio input, if you add Options the code it will generate.
I proposal a change on the page build to add a required validate on input Radio and Select.
PR: https://github.com/react-hook-form/documentation/pull/861

@BrainDev333  @bluebill1049  I think we close this issue when we merge the #866, what do you think?

thanks @AdaltonLeite for the update 🙉


DiscordIpcClient doesn't implement Debug

The structs DiscordIpcClient for both platforms don't use derive(Debug) causing issues with Clippy.

just pushed a fix for this, thanks <3

just pushed a fix for this, thanks <3

tysm <3 @vionya


Crashing with complicated less selector

I have selected CSSComb in Atom to beautify the code, and it seems to have crashed on a complicated CSS selector.
Here is the error message:
Unsupported beautification result 'Parsing error: Please check validity of the block starting from line #703 CSScomb Core version: 4.2.0

701 | } 703*| button[class^="ch-button-"], 704 | a[class^="ch-button"]:not([class$="alternative"]), 705 | {

Syntax: less Gonzales PE version: 3.4.7'.
Unsupported beautification result 'Parsing error: Please check validity of the block starting from line #703
CSScomb Core version: 4.2.0
701 | }
703*| button[class^="ch-button-"],
704 | a[class^="ch-button"]:not([class$="alternative"]),
705 |  {
Syntax: less
Gonzales PE version: 3.4.7'.
Hide Stack Trace
Error: Unsupported beautification result 'Parsing error: Please check validity of the block starting from line #703
CSScomb Core version: 4.2.0
701 | }
703*| button[class^="ch-button-"],
704 | a[class^="ch-button"]:not([class$="alternative"]),
705 |  {
Syntax: less
Gonzales PE version: 3.4.7'.
    at beautifyCompleted (/Users/petrchutny/.atom/packages/atom-beautify/src/beautify.coffee:140:17)
    at tryCatcher (/Users/petrchutny/.atom/packages/atom-beautify/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/petrchutny/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/Users/petrchutny/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/Users/petrchutny/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/Users/petrchutny/.atom/packages/atom-beautify/node_modules/bluebird/js/release/promise.js:689:18)
    at Async._drainQueue (/Users/petrchutny/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/Users/petrchutny/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:143:10)
    at Async.drainQueues (/Users/petrchutny/.atom/packages/atom-beautify/node_modules/bluebird/js/release/async.js:17:14)
    at <anonymous>

Hi @petrchutny, the issue is in the LESS snippet above, you have a trailing comma before opening bracket which makes code invalid from LESS point of view.


tea: 0.9.0 -> 0.9.2

Diff: https://gitea.com/gitea/tea/compare/v0.9.0...v0.9.2
Description of changes
https://gitea.com/gitea/tea/releases/tag/v0.9.1 (0.9.2 contains non-code CI related changes)
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 217088 run on x86_64-linux 1

1 package built:

tea


After selection of a commit only the changes of this commit will be shown. When selecting a range of commits the diff of this range is shown.

The "Show changes since your last review" mechanism github uses is implemented, too.
When reviewing a single commit or a commit range the "Viewed" functionality is disabled.
Screenshots
The commit dropdown

Selecting a commit range

Show changes of a single commit only

Show changes of a commit range

Fixes https://github.com/go-gitea/gitea/issues/20989
Fixes https://github.com/go-gitea/gitea/issues/19263

Hmm…
I wonder how that will play with #19007.
I can foresee at least three bugs that will become more present compared to now:

#24813
The architecture is built at the moment to use the newest review as the latest review to compare against.
As long as you only move forward in the time, this is not a problem.
There's no performant way around this issue, as it would otherwise mean a very expensive comparison what the latest commit a review happened on is.
With your proposed approach, we can also backtrack in time, potentially leading to comparing the state against an older one than necessary.
The other way around is most likely true as well (didn't test it):
If you review a PR on the newest file, and then switch to an older commit, files you haven't viewed yet will probably be marked as viewed.

I think for now, the easiest thing to combat all these problems is to disable the viewed checkboxes (at best with a tooltip explaining why) (or alternatively hiding it completely) when you are only reviewing a specific commit of the PR.

Hmm… I wonder how that will play with #19007. I can foresee at least three bugs that will become more present compared to now:

Files are viewed on too new commits #24813
The architecture is built at the moment to use the newest review as the latest review to compare against.
As long as you only move forward in the time, this is not a problem.
There's no performant way around this issue, as it would otherwise mean a very expensive comparison what the latest commit a review happened on is.
With your proposed approach, we can also backtrack in time, potentially leading to comparing the state against an older one than necessary.
The other way around is most likely true as well (didn't test it):
If you review a PR on the newest file, and then switch to an older commit, files you haven't viewed yet will probably be marked as viewed.

I think for now, the easiest thing to combat all these problems is to disable the viewed checkboxes (at best with a tooltip explaining why) (or alternatively hiding it completely) when you are only reviewing a specific commit of the PR.

Thanks for your feedback - disabling the Viewed Checkboxes should be an easy thing. I'll add this.
... by the way this reminds me to analyse the missing headcommit infomation ;-)

As for UI:

I don't think radio button is the right. If at all, it should have a checkbox.
It would be nice to aallow selection of unbroken commit ranges, which will require a bit of JS to get working.
There needs to be a border between dropdown elements
All text-holding elements need to ellipsis-wrap, there is a helper class for it.

thanks @silverwind - do you mean all span (class description and text) should have the class gt-ellipsis?

At least the commit message and author line will needed it. Commit hash is fixed width, so doesn't.

At least the commit message and author line will needed it. Commit hash is fixed width, so doesn't.

Thanks - i've pushed an updated version:

@silverwind are there any more ui / review comments that I'll need to address?
@delvh is the current solution (disabling file viewed when loading specific commit) ok for you?

Looks good. Something to test:
What happens when number of commits is large. Will the dropdown become scrollable?

@delvh is the current solution (disabling file viewed when loading specific commit) ok for you?

Yep, of course. Otherwise I wouldn't have suggested it.

@sebastian-sauer install a https://editorconfig.org/ plugin in your editor.

Thanks @silverwind - i've now added a max height and overflow-y auto to add scrollbar for long lists.
The following screenshot is with 500 commits in one PR:

I guess we can reduce item padding a bit in that dropdown specifically, maybe padding: 6px 3px.

padding: 6px 3p

I was thinking the same working on it

Apologies,
I wrongly put the #. Github is trying to be oversmart some time. 😅

I've reduced padding and the margin of the divider:

Bit too smal actually, I will check out the branch and correct it, before making any more misguided requests :D

Did a number of UI enhancements. Looks much better to me now:

Your support is much appreciated @silverwind - thank you!

I wonder if there is any performance import to this on PRs with many commits. I guess not as the commits are already retrieved currently, right?

I wonder if there is any performance import to this on PRs with many commits. I guess not as the commits are already retrieved currently, right?

Yes - the commits are already loaded in prInfo *git.CompareInfo. So there is no additional loading of data.

Is there anything blocking a second approval / merge?

My tests look good - i've updated PR description and screenshots.
Any feedback / approve / comment is much appreciated!

UI looking good. A backend integration test might be nice to have.

I've added integration tests for the new urls.

CI failure is related.

Will review again after latest Vue changes.

I've improved the integration tests with a pr that has more files to really ensure the correct files are shown.
Happy to get any feedback.

Is there any chance to have this functionality in 1.20 release?

no as v1.20 is already in feature freeze and branched out ... so it would take a backport.
backport's are only done fore bug-fixes and trivial enhancements

When I try this branch I get a 500 on PR files tab, it seems to be caused by this PR:
GetReviewByIssueIDAndUserID, Error 1728 (HY000): Cannot load from mysql.proc. The table is probably corrupted

CI also shows a few 500s, I think they might be the same cause.

Overall it looks pretty good to me. Need to sort out the 500, then I will test again.

Instead of adding more and more testing fixtures/repositories, could the existing data be reused for testing purpose?

Yep - just debugged this problem... Looks like there is a bug in FindLatestReviews
the max ( ) should be max() for mysql  (without the space)

Instead of adding more and more testing fixtures/repositories, could the existing data be reused for testing purpose?

I didn't find a good one for these tests with multiple commits in a PR.

@silverwind i'd really like to add a divider / header line in the dropdown like github does:

(but maybe in a second PR)
Are you aware of any good template / place to "copy" from?

Issue label filter has a fake "header" in the dropdown, but I guess it's not the cleanest implementation IIRC.

regarding the 500 on mysql:
Looks like there is a bug in FindLatestReviews (already existing function - introduced in #24796)
the max ( ) should be max() for mysql (without the space)

would it be worth to backport a fix for this only to 1.20/1.19?

regarding the 500 on mysql:
Looks like there is a bug in FindLatestReviews (already existing function - introduced in #24796)
the max ( ) should be max() for mysql (without the space)

would it be worth to backport a fix for this only to 1.20?

I think this was introduced only on main - at least i couldn't find the method in 1.20 (https://github.com/go-gitea/gitea/blob/release/v1.20/models/issues/review.go)

all your review comments are now adressed (hopefully ;) ) and the hint for commit range selection via shift has been added.
Are there any more comments / feedback? Thanks

Sorry for asking again - is there a chance to get this reviewed/merged or is there something else I need to add/modify?

Please wait, until re-reviewed. Lot of files has been changed. This may take lil more time to review. No need to sorry, you are fine. 😄

@sebastian-sauer did you remove the max width I set earlier? This is definietly too wide at over 800px. GitHub sets these dropdowns to static width of 380px.

Sorry @silverwind - if i did so, that was not intended. I'll check and readd the max-width

One more thing: There is a double border-top issue coming from the .menu > .menu nesting, you should remove one of these .menu.

Sorry @silverwind - if i did so, that was not intended. I'll check and readd the max-width

Thanks, I recommend something like width: min(380px, 96vw).

Sorry @silverwind - if i did so, that was not intended. I'll check and readd the max-width

Thanks, I recommend something like width: min(380px, 96vw).

I've added the max-width and reused shortsha and removed the double border-top

Hmm, it does give a 500 now for the SHA thingy:

Hmm, it does give a 500 now for the SHA thingy:

Strange - just clicked through all urls and still working in my environment.
Which url did you use to get this error?

Trying again today, it seems to work. Double border is still an issue, checking...

Pushed some CSS tweaks:

What happened to the second line there? Previous screenshots showed <user> 5 days ago but now it only shows a ISO timstamp?

Sorry silverwind, I'll recheck this. Probably this broke during refactoring. Thanks!

Rechecked the dropdown and fixed the display of committer/author. This also fixed the relative-time component:

For 1, add text light-2 or even text light-3 class to the help text.

Thanks for your feedback. I'll check and try to fix your suggestions asap.
Regarding the timestamps - at least in my browser they worked yesterday evening. (i did recheck them).

Just had a quick look at 2: looks like the relatve time component doesn't work in firefox. In Chrome it works perfectly - in FF it's not working.
The format of the timestamp was not valid for Firefox. I changed it to a well defined format and now it's working in FF and chrome

Indeed, I recall Spidermonkey's date parser is stricter than Blink. I think in this case Blink is actually in error but they are probably too afraid to change it to be standards-conform.

@delvh isn't 1 & 3 now resolved as well?
The click message is in a light colour and the timestamps don't take that much space as they are displayed as they should :)

Just for the record, this is the date issue. We should ensure to never communicate bare time strings to browsers in the future.
$ eshost -e "new Date('2009-11-10 23:00:00 +0000 UTC')"
#### JavaScriptCore
Invalid Date

#### spidermonkey
Invalid Date

#### v8
Wed Nov 11 2009 00:00:00 GMT+0100 (Central European Standard Time)

True, didn't notice it, but you are absolutely correct.
I've edited the message now.

$ eshost -e "new Date('2009-11-10 23:00:00 +0000 UTC')"

How is that invalid? Because of the +timezone timezone?

Related: https://github.com/github/relative-time-element/issues/266

@delvh i just added a new commit that makes the dropdown usable with keyboard navigation. At least in Chrome and FF this looks good to me - but i'd really appreciate your feedback on this.

https://github.com/go-gitea/gitea/pull/25528/commits/172418185895393502d2b0802293b7e8d3a2d9e6 adds a "Show all commits" link to the showing only commits message:

This fixes 7 from @delvh's findings

And commit https://github.com/go-gitea/gitea/pull/25528/commits/f7acf4a986eedbadf7aa17680614261275c49ad7 adds an improved commit range selection (hopefully very close to the github one ;) )
This fixes point 5 + 6 from the list

Some changes:

Bypass the XORM bug for max ( id )
There were class "commit-selector-menu" and id "commit-selector-menu", it seems that only ID is enough, now only use id="diff-commit-selector-menu" (the prefix is used to prevent from conflicting from other IDs)
Use loading-indicator instead of battling with "menu::after"
Wrap some pretty long lines to multiple lines
Add @click.ctrl.exact and @click.meta.exact, it brings the consistent user experience if the user would like to open the link in a new window.

Thanks @wxiaoguang for your changes - these look good to me!

@sebastian-sauer I've updated your screenshots now with the current state.

@sebastian-sauer please fix the merge conflicts. :tea:

Thank you @delvh for resolving the merge conflict. And thanks to all of you for all your support! It's always fun contributing to gitea!

I'll check this and push a fix asap.

Fixed.

I've just noticed something strange, which is present both in my new screenshots and in the original ones:
The count of added and deleted lines doesn't add up with the reality, especially when only reviewing a single commit of a PR:
My third screenshot for example shows 2 additions, 1 deletion. At the same only 1 file changed, and this file has 1 addition, 0 deletions. How can that be?

hm - is there anything special with your commit? in my local environment it shows the exact number of lines changed.

@delvh do you got Ignore Whitespace active? This could be the reason

I mean, it doesn't appear to occur on every commit.
Let's just book it under Cannot reproduce and be happy.
We'll see it again when a bug report about is opened.

I mean, it doesn't appear to occur on every commit. Let's just book it under Cannot reproduce and be happy. We'll see it again when a bug report about is opened.

Please see my last comment - maybe it's caused by ignore whitespace option?


[Feature Request]: Code editor read only mode ?

Description
changing editor configurations should be possible via ace.editor() returned instance (I belive you save it as a ref).
Is there any way to get this instance, or change some editor configurations, like setting the mode to read only ?
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate requests

editor ref is not really necessary at this point, setting ace config is enough for now ace.config.set('readOnly', true).

IDK if there would be a more advances use case where editorRef would be necessary, but I'll surrey get back here 😄
Thanks, nice ui-kit!

Hello Nichita,
The code editor currently does not support a read-only mode, but it is on our radar. The main concern is the impact on the bundle size the code editor has. Ideally, we want the readonly variant to be lightweight.
A viable alternative four now could be, for instance, https://prismjs.com/ to bring syntax highlight to the code snippets.

@pan-kot @nichita-pasecinic  any updates on this?
by far my solution is prevent any keydown or mousedown events but when I press backspace or delete, the code editor still displays the changed value
// MyCodeEditor.tsx

function preventChangeIfNeeded(event: KeyboardEvent) {
  // 'backspace' and 'delete' do not go into this
  const { target } = event;

  if (target && (target as HTMLTextAreaElement).classList.contains('ace_text-input')) {
    event.preventDefault();
    event.stopPropagation();
  }
}

function hideCursor(event: MouseEvent) {
  const cursorLayer = document.querySelector('.ace_cursor-layer');

  if (cursorLayer) {
    event.preventDefault();
    event.stopPropagation();
    (cursorLayer as HTMLDivElement).style.display = 'none';
  }
}

function MyCodeEditor({readonly}) {
// ...
  useEffect(() => {
    if (readonly) {
      window.addEventListener('keydown', preventChangeIfNeeded);
      window.addEventListener('mousedown', hideCursor);

      return () => {
        window.removeEventListener('keydown', preventChangeIfNeeded);
        window.removeEventListener('mousedown', hideCursor);
      };
    }
  }, [readonly]);
// ...
}

@fr0stf0x you could just change the config of the global 'Ace' instance to readOnly mode
useEffect(() => {
    import('ace-builds').then((aceLib) => {
      aceLib.config.set('themePath', CDN);
      aceLib.config.set('basePath', CDN);
      aceLib.config.set('modePath', CDN);
      aceLib.config.set('themePath', CDN);
      aceLib.config.set('workerPath', CDN);
     // this one
      aceLib.config.set('readOnly', readOnly);
      aceLib.config.set('showPrintMargin', false);
      setAce(aceLib);
      setLoading(false);
    });
  }, [readOnly]);

In my case readOnly is a component prop

The older answer still applies: https://github.com/cloudscape-design/components/issues/456#issuecomment-1311578595
As the name suggests, code editor is for editable use-cases only. For read-only cases use another component. Loading Ace library for read-only use-case is a very big overkill. There are more lightweight options out there.
Updated the issue title to reflect what it really tracks (providing an official component for viewing code)

We have recently released the CodeView component. Details and examples can be found on the component's page on our website.


Make color change for already-read submissions more dramatic

The styling we apply to already-read submissions is hard to discern on bright themes, as noted here:
https://www.reddit.com/r/slide_ios/comments/9n99pz/question_great_app_one_question/e7x1q0u
Perhaps we should make the post itself a little darker/lighter depending on the theme?

I like that idea.

Issue would be with AMOLED themes

We might be able to get away with that if we just make the text color difference more dramatic.

Done!


How to support SPM in XCode 11 with Resources

Steps to reproduce:

Add SwiftDate as SPM dependency in Xcode 11
Add code with relative (localized) date formatting
Run app

Expected results:

App should load language specific settings from langs/(ID).json file

Current results:

App is crashing because file couldn't be loaded.

It looks like
let fullURL = Bundle(for: RelativeFormatter.self).resourceURL?.appendingPathComponent("langs/\(langID).json") generates path for Host App Bundle.

Can confirm. Project crashes inside SwiftDate when installed via SPM, but it's good in Cocoapods.
@malcommac Since Xcode 11 is now "Gold Master" and this error is still occurring do you think you could take a look at it? I imagine there will be a ton of issues on the 19th once it's live otherwise.

Did you know some tricks or workaround?

Would this work?
If binary size is not a concern. Embed resource files in a source file as base 64 encoded data in a string literal. (A tool of mine, Workspace 4, can automate this.) Then as long as the source file is checked in, the resources will be embedded in the executable and available no matter how the package is used. This allows you to treat the files as resources during development, but they are technically no longer separate resources after compiling. (The annoying binary bloat is why I watch this thread so closely, hoping for a better future.)
https://forums.swift.org/t/swift-pm-bundles-and-resources/13981/50

SE-0271 looks to be addressing this:
https://github.com/apple/swift-evolution/blob/master/proposals/0271-package-manager-resources.md

^The above SE has been implemented for Swift 5.3

fixed in 6.2.0


Remove datainterpolation hotfix

https://github.com/EarthSciML/EarthSciData.jl/blob/cc6c7b502d4d2ece5596e2f1b11fc1b31e563643/src/EarthSciData.jl#L14
Once this error is resolved: https://github.com/SciML/DataInterpolations.jl/issues/331

cc @jialinl6 , GasChem.jl will probably have the same problem.


enable processing to be cancelled

If processing a large file, it can take a long time and the user may wish to cancel in that time. Additionally, I have come across a scenario where a video I've been supplied throws an error in mp4box that doesn't cancel the process, and progress goes above 100% without ever finishing (I allowed it to get to >800% before refreshing the page, meanwhile CPU usage is 100%). If running using webWorkers, throwing an Error from the progress function doesn't stop the process either.
Can you please enable functionality to pass in a cancellation token in options?

Hi. Thank you for raising these issues. They are valid points.
Are you able to share the file that is going beyond 100%, for testing?
If you have a chance to start implementing these improvements, feel free to
send pull requests. Otherwise I will work on them when I find the time.
On Thu, 27 Jan 2022 at 04:01, gunta987 @.***> wrote:

If processing a large file, it can take a long time and the user may wish
to cancel in that time. Additionally, I have come across a scenario where a
video I've been supplied throws an error in mp4box that doesn't cancel the
process, and progress goes above 100% without ever finishing (I allowed it
to get to >800% before refreshing the page, meanwhile CPU usage is 100%).
If running using webWorkers, throwing an Error from the progress function
doesn't stop the process either.
Can you please enable functionality to pass in a cancellation token in
options?
—
Reply to this email directly, view it on GitHub
https://github.com/JuanIrache/gpmf-extract/issues/49, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIX77Z6O37L5ADPZHYRXW3UYCYSBANCNFSM5M4WTE4A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks. I've made the video available at https://1drv.ms/u/s!At523gPWXcusgQMPo3Peix57UjS0?e=mUfEat
This video is clearly corrupted, since it won't even open in VLC, but the extractor does recognise it as a GoPro file and attempts to extract telemetry. I have also tried the file at https://goprotelemetryextractor.com/free/ and get the same results (extraction process never ends)

Thank you for the sample file. I made two changes:

Error handling was completely broken within the readBlock files. Should be better now (but the error with that specific file seems hard to handle in a more elegant way. See below)
If the progress goes beyond 200% the file is rejected. I set a generous margin because in the past files were doing weird things with the progress, so I wouldn't want to cancel something that will succeed even if it's over 100%. There could be better solutions.

The crash itself comes from mp4box and I have no direct control over it, nor the knowledge or time to improve that within mp4box at the moment. If you make additional findings about that, please let me know.
Adding the cancel function will require a bigger refactor, so I'm not sure when/if I'll be able to work on that. PRs in that direction are welcome.

Easy enough to implement for browserMode, because the data is read in chunks.
I'm new to github: how do I create a PR when I can't push a branch to this repo?

You can fork the project, make your changes and then send the PR request to
the dev branch. There must be good tutorials about this, but in any case if
you get it working on your fork of the repo I can just copy the changes.
Juan Irache
Independent Software Developer
https://prototyping.barcelona
On Tue, 1 Feb 2022 at 02:30, gunta987 @.***> wrote:

Easy enough to implement for browserMode, because the data is read in
chunks.
I'm new to github: how do I create a PR when I can't push a branch to this
repo?
—
Reply to this email directly, view it on GitHub
https://github.com/JuanIrache/gpmf-extract/issues/49#issuecomment-1026390536,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABIX776PDW5KDPLKSXSZFL3UY4ZRVANCNFSM5M4WTE4A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Hi Juan,
I notice that you changed resolve(null) to reject('Canceled by user'). All good, but the documentation needs updating as I wrote it to reflect resolving with null.

Good catch


chore: automated PR to update VHDVersion for 202306.19.0 VHD

This is an automated PR to bump VHDVersion for the VHD release with image version 202306.19.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall First build on imageBump/202306.19.0 at 61.476%

Totals

Change from base Build<PHONE_NUMBER>:
61.5%

Covered Lines:
2558

Relevant Lines:
4161

💛  - Coveralls


Meteor-Angular Application freeze when loading two Components.

Hey guys
I got a Problem with my Meteor/Angular2 application. I got a start Component (AppComponent) and I can load this just fine everything works as I want. But now I added the tag 'map' to my AppComponent template and created the component MapComponent. Now everytime i try to open the application (on localhost:3000) the App freezes and crashes. I can't open the developer tool nothing and I need to close the browser with taskmanager. I recreated the App in plain Ang2 and it worked, so there need to be a Problem with Meteor-Angular.
I used this as a the Project Template (https://github.com/Urigo/angular2-meteor-base) and just changed some files.
Here I send you my Files:
app.module.ts:
import { NgModule } from "@angular/core";
import { BrowserModule } from "@angular/platform-browser";
import { AppComponent } from "./app.component";
import { MapComponent } from './map/map.component';

@NgModule({
  // Components, Pipes, Directive
  declarations: [
    AppComponent,
    MapComponent

  ],
  // Providers
  providers: [],
  // Modules
  imports: [
    BrowserModule
  ],
  // Main Component
  bootstrap: [AppComponent]
})
export class AppModule {
}

app.component.ts
import { Component } from "@angular/core";
import template from "./app.component.html";
import style from "./app.component.scss";

@Component({
  selector: "app",
  template: `Navbar

    <map></map>

Footer`,
  styles: [ style ]
})
export class AppComponent {
}

map.component.ts
import { Component } from '@angular/core';
@Component({
    selector: 'map',
    template: `

    Test

`,
    styleUrls: ['../app.component.scss']
})
export class MapComponent {

}

Meteor<EMAIL_ADDRESS>package.json
{
  "name": "angular2-meteor-base",
  "private": true,
  "scripts": {
    "start": "meteor run",
    "start:prod": "meteor run --production",
    "build": "meteor build ./build/",
    "clear": "meteor reset",
    "meteor:update": "meteor update --all-packages",
    "test": "meteor test --driver-package practicalmeteor:mocha",
    "test:ci": "meteor test --once --driver-package dispatch:mocha-phantomjs"
  },
  "devDependencies": {
    "@types/chai": "3.4.34",
    "@types/meteor": "^1.3.31",
    "@types/mocha": "2.2.34",
    "chai": "3.5.0",
    "chai-spies": "0.7.1",
    "meteor-node-stubs": "0.2.4"
  },
  "dependencies": {
    "@angular/common": "2.4.1",
    "@angular/compiler": "2.4.1",
    "@angular/core": "2.4.1",
    "@angular/forms": "2.4.1",
    "@angular/platform-browser": "2.4.1",
    "@angular/platform-browser-dynamic": "2.4.1",
    "@angular/router": "3.4.1",
    "angular2-meteor": "0.7.1",
    "angular2-meteor-polyfills": "0.1.1",
    "angular2-meteor-tests-polyfills": "0.0.2",
    "babel-runtime": "^6.18.0",
    "meteor-rxjs": "0.4.7",
    "reflect-metadata": "0.1.9",
    "rxjs": "5.0.2",
    "zone.js": "^0.7.4"
  }
}
{
  "name": "angular2-meteor-base",
  "private": true,
  "scripts": {
    "start": "meteor run",
    "start:prod": "meteor run --production",
    "build": "meteor build ./build/",
    "clear": "meteor reset",
    "meteor:update": "meteor update --all-packages",
    "test": "meteor test --driver-package practicalmeteor:mocha",
    "test:ci": "meteor test --once --driver-package dispatch:mocha-phantomjs"
  },
  "devDependencies": {
    "@types/chai": "3.4.34",
    "@types/meteor": "^1.3.31",
    "@types/mocha": "2.2.34",
    "chai": "3.5.0",
    "chai-spies": "0.7.1",
    "meteor-node-stubs": "0.2.4"
  },
  "dependencies": {
    "@angular/common": "2.4.1",
    "@angular/compiler": "2.4.1",
    "@angular/core": "2.4.1",
    "@angular/forms": "2.4.1",
    "@angular/platform-browser": "2.4.1",
    "@angular/platform-browser-dynamic": "2.4.1",
    "@angular/router": "3.4.1",
    "angular2-meteor": "0.7.1",
    "angular2-meteor-polyfills": "0.1.1",
    "angular2-meteor-tests-polyfills": "0.0.2",
    "babel-runtime": "^6.18.0",
    "meteor-rxjs": "0.4.7",
    "reflect-metadata": "0.1.9",
    "rxjs": "5.0.2",
    "zone.js": "^0.7.4"
  }
}

ResourceLoader doesn't work in the previous versions of Angular Meteor. So you have to update Angular Meteor Compilers to latest version.
You can look at our examples at;
https://github.com/Urigo/angular-meteor/tree/master/examples
We are going to add a new tutorial for MeteorCLI. If your issue is still encountered, you can open a new issue.


osu-lazer: 2020.1204.0 -> 2020.1212.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for osu-lazer is: "Rhythm is just a click away"
meta.homepage for osu-lazer is: "https://osu.ppy.sh"
meta.changelog for osu-lazer is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2020.1212.0 with grep in /nix/store/23lrq7kiip4svf4nhms4272k9g0xdjyf-osu-lazer-2020.1212.0

directory tree listing: https://gist.github.com/ee812566e868363d5e490cfdffe836f1

du listing: https://gist.github.com/abc886208961bec92f102e93806e8b48

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
osu-lazer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/23lrq7kiip4svf4nhms4272k9g0xdjyf-osu-lazer-2020.1212.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A osu-lazer https://github.com/r-ryantm/nixpkgs/archive/57786033b4c394bba735ec947623e39d688c9670.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/23lrq7kiip4svf4nhms4272k9g0xdjyf-osu-lazer-2020.1212.0
ls -la /nix/store/23lrq7kiip4svf4nhms4272k9g0xdjyf-osu-lazer-2020.1212.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

osu-lazer

Maintainer pings
cc @oxalica for testing.

It doesn't launch. See #106377 for fix. @ryantm


Allow Arbitrary Tags Lightstep Tracing

Is your proposal related to a problem?

Not entirely, my proposal is related to a feature... one that would allow additional (arbitrary) tags to be added to the lightstep tracing configuration. The metadata that is passed to lightstep is pretty minimal, this would allow users to add more metadata (possibly that would match external labels?).
Describe the solution you'd like
I would like the option of adding key value pairs that match the opentracing.Tags object to the lightstep tracing configuration. This would be something like this:
      - args:
        - query
        - |
          --tracing.config=type: LIGHTSTEP
          config:
            tags:
              tag1: milkshake
              yard: boys
              "lightstep.env": prod

The opentracing.Tracer can take this in the options object.
Links:

https://github.com/opentracing/opentracing-go/blob/master/tracer.go#L267
https://pkg.go.dev/github.com/lightstep/lightstep-tracer-go#Options
https://github.com/thanos-io/thanos/blob/main/pkg/tracing/lightstep/lightstep.go#L15

Describe alternatives you've considered
Just leaving it as is and living with the lack of additional metadata?
Additional context
Links can be found in the Describe the solution you'd like section.

This looks straight-forward to implement. Contributions are welcome :)


Docs slightly off

See https://github.com/ScottyFillups/key-controller/blob/master/lib/rotate.js#L5

Closing since I don't remember what I was trying to do :^)


Use correct config property (ambari.server_fqdn)

The previous PR #69 used the incorrect attribute name for the Ambari server. The correct attribute is ambari['server_fqdn'] as you can see at https://github.com/caskdata/coopr-provisioner/commit/249c95a5bcb413c5b25423ffb2b2d7f88664d0ba#diff-aeb5bf0a0488f561614f392b39da6429R6 so use that, instead.

LGTM


Dagster ETL documentation

PR Overview

PR Checklist

[ ] Merge the most recent version of the branch you are merging into (probably dev).
[ ] All CI checks are passing. Run tests locally to debug failures
[ ] Make sure you've included good docstrings.
[ ] For major data coverage & analysis changes, run data validation tests
[ ] Include unit tests for new functions and classes.
[ ] Defensive data quality/sanity checks in analyses & data processing functions.
[ ] Update the release notes and reference reference the PR and related issues.
[ ] Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

Ok! The minimum viable documentation has been created. I still need to update the devtools notebooks which I'll do in a separate PR.

Why isn't there a "Materialize All" option when looking at the ferc_to_sqlite_fast job?
This is because ferc_to_sqlite is a graph of ops, not a pile of assets (which are like platonic data products tied to actual ops that produce them) like etl is. It's confusing 🤷

Will this run the XBRL and DBF extractions in parallel?
Yes - if you look in the run itself & click on the little stopwatch icon, it will show you the timings & that they are running in parallel!

When I select ferc_to_sqlite_fast and go to Launchpad and click Launch Run, both the DBF and XBRL extractions fail, ultimately tracing back to sqlite3OperationalError: unable to open database file but I'm not sure if it's having trouble reading one of our databases, or one of the internal Dagster databases that it creates.

I will look into this... can you shove a couple logline in pudl.extract.xbrl._get_sqlite_engine() to see if it's successfully getting the PUDL-related sqlite engines? Something like this...
diff --git a/src/pudl/extract/xbrl.py b/src/pudl/extract/xbrl.py
index 95047c95..2e45619b 100644
--- a/src/pudl/extract/xbrl.py
+++ b/src/pudl/extract/xbrl.py
@@ -85,7 +85,10 @@ def _get_sqlite_engine(
         f"Dropping the old FERC Form {form_number} XBRL derived SQLite DB if it exists."
     )
     db_path = output_path / f"ferc{form_number}_xbrl.sqlite"
+
+    logger.info(f"Connecting to SQLite at {db_path}...")
     sqlite_engine = sa.create_engine(f"sqlite:///{db_path}")
+    logger.info(f"Connected to SQLite at {db_path}!")
     try:
         # So that we can wipe it out
         pudl.helpers.drop_tables(sqlite_engine, clobber=clobber)

Ah okay. Now looking at the logging output it appears that for the xbrl2sqlite process, it's able to create the ferc1_xbrl engine, but then is not finding the XBRL metadata JSON file:
Logging & Errors
2023-03-08 13:06:47 -0600 - dagster - DEBUG - ferc_to_sqlite_fast - 7e3b9946-f94f-43db-9537-44b72e01a8f6 - 14600 - LOGS_CAPTURED - Started capturing logs in process (pid: 14600).
2023-03-08 13:06:47 -0600 - dagster - DEBUG - ferc_to_sqlite_fast - 7e3b9946-f94f-43db-9537-44b72e01a8f6 - 14600 - xbrl2sqlite - STEP_START - Started execution of step "xbrl2sqlite".
2023-03-08 13:06:47 [    INFO] catalystcoop.pudl.extract.xbrl:84 Dropping the old FERC Form 1 XBRL derived SQLite DB if it exists.
2023-03-08 13:06:47 [    INFO] catalystcoop.pudl.extract.xbrl:88 Connecting to SQLite at /Users/zane/code/catalyst/pudl-work/outputs/ferc1_xbrl.sqlite...
2023-03-08 13:06:47 [    INFO] catalystcoop.pudl.extract.xbrl:90 Connected to SQLite at /Users/zane/code/catalyst/pudl-work/outputs/ferc1_xbrl.sqlite!
2023-03-08 13:06:48 [    INFO] catalystcoop.ferc_xbrl_extractor.xbrl:190 Parsing taxonomy from <_io.BytesIO object at 0x175f99440>
2023-03-08 13:06:51 -0600 - dagster - ERROR - ferc_to_sqlite_fast - 7e3b9946-f94f-43db-9537-44b72e01a8f6 - 14600 - xbrl2sqlite - STEP_FAILURE - Execution of step "xbrl2sqlite" failed.

dagster._core.errors.DagsterExecutionStepExecutionError: Error occurred while executing op "xbrl2sqlite"::

FileNotFoundError: [Errno 2] No such file or directory: '/Users/zane/code/catalyst/pudl-work/outputs/ferc1_xbrl_taxonomy_metadata.json'

Stack Trace:
  File "/Users/zane/mambaforge/envs/pudl-dev/lib/python3.10/site-packages/dagster/_core/execution/plan/utils.py", line 55, in op_execution_error_boundary
    yield
  File "/Users/zane/mambaforge/envs/pudl-dev/lib/python3.10/site-packages/dagster/_utils/__init__.py", line 471, in iterate_with_context
    next_output = next(iterator)
  File "/Users/zane/mambaforge/envs/pudl-dev/lib/python3.10/site-packages/dagster/_core/execution/plan/compute_generator.py", line 121, in _coerce_solid_compute_fn_to_iterator
    result = invoke_compute_fn(
  File "/Users/zane/mambaforge/envs/pudl-dev/lib/python3.10/site-packages/dagster/_core/execution/plan/compute_generator.py", line 115, in invoke_compute_fn
    return fn(context, **args_to_pass) if context_arg_provided else fn(**args_to_pass)
  File "/Users/zane/code/catalyst/pudl/src/pudl/extract/xbrl.py", line 147, in xbrl2sqlite
    convert_form(
  File "/Users/zane/code/catalyst/pudl/src/pudl/extract/xbrl.py", line 187, in convert_form
    xbrl.extract(
  File "/Users/zane/mambaforge/envs/pudl-dev/lib/python3.10/site-packages/ferc_xbrl_extractor/xbrl.py", line 56, in extract
    tables = get_fact_tables(
  File "/Users/zane/mambaforge/envs/pudl-dev/lib/python3.10/site-packages/ferc_xbrl_extractor/xbrl.py", line 194, in get_fact_tables
    taxonomy.save_metadata(metadata_path)
  File "/Users/zane/mambaforge/envs/pudl-dev/lib/python3.10/site-packages/ferc_xbrl_extractor/taxonomy.py", line 295, in save_metadata
    with open(filename, "w") as f:

It turns out this was because while I had set PUDL_OUTPUT to an appropriate path, I had not created the outputs directory for it to use, assuming that it would be created automatically based on the documentation around coming from the old PUDl setup.
After creating that directory, the FERC to SQLite extraction appears to succeed.

The xbrl2sqlite job takes a lot longer than the dbf2sqlite job. Would it be hard to split out the different FERC XBRL forms into their own jobs so they can all run in parallel?
With the FERC DBs populated, I'm then able to run the fast ETL with the "Materialize All" button.
It satisfyingly maxes out all of my CPUs for a couple of minutes early in the process, and then spends a few minutes using just one CPU in the eia_transform op.
Having successfully gotten through a fast ETL, I then tried to run the full ETL, starting with the complete FERC extraction. However this failed because it finds the existing databases, and clobber is set to False. Is there a way to tell it to clobber from within the dagit interface? Or do I just have to delete the databases by hand?
After rm -rf *-ing everything under outputs I kicked off a full ferc2sqlite extraction and it seemed to be happy again. However I am unsure whether deleting those files manually would confuse Dagit about the status of the outputs it had generated. After 390s both of these tasks had completed!
Then I kicked off a full ETL run, but I did not delete the old pudl.sqlite first, and the system didn't complain about it existing already, so I don't know if it's getting clobbered or appended to, or the individual tables in the existing DB are being dropped and overwritten.
It manages to run extract_eia860, extract_eia923 and plants_steam_ferc1 (all long, slow processes) in parallel, which seems like a big improvement. And when the EIA extractions finish they continue on into the EIA transformations, while FERC chugs along. I'm a little surprised that there were no issues with with running out of memory. It looked like it maybe peaked at 26GB of memory usage.
Next it gets kind of hung up on eia_transform which is the only thing running for a long while. So maybe it is worth splitting those transformation functions up into their own individual assets, pre-harvesting. Maybe even just at the dataset level (eia860, eia861, eia923) first.
And then the EPA CEMS marathon begins. I think partitioning this by year probably makes the most sense (in terms of work units that get handed out and done in parallel). And maybe also for the partitioned file outputs, so each of them is a few hundred MB instead of a few MB. Clearly the biggest parallelization opportunity.

It'll take some getting used to but it looks good!

Having successfully gotten through a fast ETL, I then tried to run the full ETL, starting with the complete FERC extraction. However this failed because it finds the existing databases, and clobber is set to False. Is there a way to tell it to clobber from within the dagit interface? Or do I just have to delete the databases by hand?

I ran into this too. The error message is misleading, you need to set clobber to True. I'll push up a fix to that. You can tweak the individual op configs by adding this at the top level of the yaml in the launchpad:
ops:
  dbf2sqlite:
    config:
      clobber: true
  xbrl2sqlite:
    config:
      clobber: true

I figured there was probably a way to do it in dagit, but I couldn't figure out how to edit any of the configurations. Probably just my lack of familiarity with the interface.

Thank you everyone for your contributions and comments!
Some answers for @zaneselvans

I'm not sure how things are being parallelized in ferc-xbrl-extractor but I can include this idea in the FERC extract -> main DAG issue (I still need to write it up).
Looks like @jdangerx answered your question about using dagit to configure the ferc_to_sqlite job. I'm planning on creating a new doc section that goes into more detail on how to use dagster / dagit.
The pudl ETL no longer has a clobber argument because the pudl_sqlite_io_manager deletes the existing data in a table when a table's asset is rerun. We're not dropping the table so we don't have to recreate the table schema. The schemas for all of the tables are created when the pudl.sqlite file is initially created.
I didn't feel like dagsterifying eia_transform because I'm not super comfortable with the harvesting logic. There might be a way to break it into separate assets.

The pudl ETL no longer has a clobber argument because the pudl_sqlite_io_manager deletes the existing data in a table when a table's asset is rerun. We're not dropping the table so we don't have to recreate the table schema. The schemas for all of the tables are created when the pudl.sqlite file is initially created.

At what point does the DB get recreated from scratch? What do we need to do when the DB schema changes? (add/remove a column, add/remove a table)

The DB needs to be created from scratch when the schema changes. Currently, you have to manually delete the database. I started working on a PR that throws an error if the database schema and pudl.metadata schema differ. It might have to wait until dagster-asset-etl is in dev.

For now we should at least document the need to manually delete the SQLite DB whenever the schema changes, since it will probably change quite frequently with all the new data we want to bring in. I didn't see it anywhere in the Running the ETL Pipeline docs.
What do you think is the right way to deal with this in the longer term?

Wow this is very cool! Some thoughts as I run through this for the first time.
I anticipate setting up PUDL_CACHE and PUDL_OUTPUT will be a relatively confusing step for many less-technical users.

set -Ux returns a bash error for me when running on Linux. Did you mean set -ux?
I'm presuming that these folders can be set up in a sub-folder, rather than in the root directory (e.g. /user/Desktop/Catalyst/pudl-work vs /user/pudl-work). If not, it would be helpful to note this explicitly in the documentation, maybe with an example.
Would be helpful to specify where a full path is required and where ~ can be used in the following steps. Particularly, it'd be helpful to explicitly note that path/to/dagster here is a full path:

echo "export DAGSTER_HOME=/path/to/dagster_home/dir" >> ~/.zshrc # zsh
echo "export DAGSTER_HOME=/path/to/dagster_home/dir" >> ~/.bashrc # bash
set -Ux DAGSTER_HOME /path/to/dagster_home/dir # fish

set -Ux returns a bash error for me when running on Linux. Did you mean set -ux?

set -Ux is only for fish shell users 🐟  I can make that clearer and also update the absolute-path stuff.
There's a bunch of implicit assumptions in these docs that are definitely confusing! ("if a path starts with /, it's probably an absolute path", "our users care a lot about alternative shells like fish", "you can set the directories wherever you want but it will be easiest to follow our documentation if you put it where we put it")


redpanda: use resource.Quantity

This commit upgrades all redpanda values types to use the resource.Quantity struct where we had previously been using other types due to a lack of compatibility.
It also adds a new UnmarshalInto function to the helmette package that allows working around go's type system in cases where an any needs to be upgraded into a resource.Quantity.

The partial values in this PR is going to be incorrect until https://github.com/redpanda-data/helm-charts/pull/1354 gets (fixed and) merged


[Run] Pressing Enter executes the currently selected item, even if the search has not completed

Hi all,
In my quest to replace both the Start Menu and the Run box with PowerToys Run, I discovered an interesting behavior that differs from the Start Menu and breaks a bit of my workflow. As I use these search utilities, they learn which results I expect for a given search term. Over time, I can enter a search term and immediately press Enter, knowing that my preferred result will be found and selected. Even moreso with a path, if I enter c:\users, I know that the path exists and should be opened.
However, when typing a search term and immediately pressing Enter in PowerToys Run, instead of waiting for the search to complete, the currently selected item (usually the result of my last search) is selected.
For search terms where I know the first result will be the one I want (especially paths), there's no reason for me to wait for the search to finish before pressing enter. Instead, the search should finish, and then the first result should be selected. (This is how the Start Menu behaves.)
ℹ Computer information

PowerToys version: v0.25.0
PowerToy Utility: PowerToys Run
Running PowerToys as Admin: Yes
Windows build number: [run "winver"] 2004 (19041.572)

📝 Provide detailed reproduction steps (if any)

Type a known command, such as winver, or a known path, such as c:\users
Immediately press Enter, before the search has completed.

✔ Expected result
The search completes, and the first result is selected.
❌ Actual result
The currently selected item (at the time of pressing Enter) is selected before the search completes.
📷 Screenshots
N/A
(My apologies if this is already an open issue, but I could not find it.)

@micahmo, can you do a recording?  On my PC, i can't repro this with 0.35

@crutkas You're right, the issue appears to have been fixed! It looks like the overall performance is much better with the latest, so I can't press Enter before the search finishes anymore. :-)
Thanks for the follow-up. I'll close this.


Reduce GH cache usage during build workflow

Use case
We split build workflow into two jobs: packages (to build packages required to build EVE-OS image) and eve (to compose final EVE-OS image). We share the data between jobs using GitHub cache. The problem is in limited size of the cache. It uses some kind of FIFO and removes old stored caches. In case of several PRs comes to build concurrently we loose the cache between jobs.
I observed that during packages job we fill the cache with images that are already published, which is sub-optimal as we can pull them directly in eve job. We try to split our changes and modify only packages should be modified in one PR. We should not fill the cache with unneeded data.
Describe the solution you'd like
To reduce cache usage I see three possible solutions:

Introduce some kind of cleanup for published images in linuxkit. We have cache clean command in linuxkit to remove entire cache, possibly we can add keep-unpublished flag to clean only published images.
Introduce optional flag in linuxkit to validate only and to not pull the image during pkg build. In that case we still need to pull the images we depends on (if image B depends on image A, A was published and we want to build B, we still need A to be pulled into linukit cache). But we do not want to have published images in cache regardless of dependencies.
Add logic on EVE-OS side to check if image already exists in external OCI registry before build (again we should somehow solve dependency problem).

cc @deitch

Introduce some kind of cleanup for published images in linuxkit. We have cache clean command in linuxkit to remove entire cache, possibly we can add keep-unpublished flag to clean only published images

I am not greatly enamoured of the idea of adding too much logic to the cache clean command. There are other tools that can check if an image is published or not, and then we can use the cache clean.
I could be convinced otherwise, however.
But our issue here really isn't clearing stuff out of the cache as opposed to not getting it in in the first place. Our specific problem is that we build all packages in the build step, but don't really need them. The fact that we download them is just a secondary artifact of the fact that lkt pkg build will either build or download. In the build job, we don't really want it there unless we have to build it.
That brings us to the second option you raised:

Introduce optional flag in linuxkit to validate only and to not pull the image during pkg build

This is the most efficient solution you propose. And it is fairly easy to implement. The question is, does it make sense in the context of lkt?

lkt pkg build currently means: "I want the package built in my cache. Whether you pull it down to build it, I don't care, but make it happen or fail." This has a simple logic and fits normal use cases.
lkt pkg build --validate-only (or --no-pull or whatever) is useful for us, but does it make sense in the context of normal linuxkit usage? What is the equivalent of "I want this in my cache, pull it or build it" of the current behaviour? The answer could very well be, "we just proved the use case". Or perhaps it is, "I want the package to exist either in the registry or my cache." I have a hard time seeing it, though.

One side issue you raised is:

we still need to pull the images we depends on (if image B depends on image A, A was published and we want to build B, we still need A to be pulled into linukit cache). But we do not want to have published images in cache regardless of dependencies

No, it isn't an issue. When we use buildkit to build, and it sees that B depends on A, it looks for A in the registry, finds it and uses it inside the buildkit container. Only if it cannot find it in the registry does it fail. linuxkit itself has wired into buildkit to override that by finding it in its local cache, but if it doesn't find it in local cache, buildkit does its usual thing and pulls from registry.
You can test it easily. Create a pkg, have it depends on something public, and do lkt pkg build. Despite it not being in the lkt cache, it will build fine, the output will be in lkt cache, but the dependency (A) will not.
Which brings us to your third option:

Add logic on EVE-OS side to check if image already exists in external OCI registry before build

This is the equivalent of your second option.
If your second option is: "build only if it is not already published via: lkt pkg build --no-pull pkg/foo", then this is "build only if it is not already published via:
TAG=$(lkt pkg show-tag pkg/foo)
[ exists-in-registry ] || lkt pkg build pkg/foo

I think I prefer this last option over any other. Only call lkt pkg build if you want to populate the cache. On the other hand, we would need some way to implement [ exists-in-registry ]. There are tools to do it (docker inspect does not work on remote images, only locally downloaded, although you could do docker pull to see if it exists, that is a bit overkill) , but the easiest tool at hand is... linuxkit. So we could do:
lkt pkg show-published pkg/foo

or even
lkt pkg show-tag --published pkg/foo

but I am not convinced that buys us all that much more than just going all the way to: lkt pkg build --validate-only.
Maybe we should do both?

Seems we exceeded the cache limit in our runs: https://github.com/lf-edge/eve/actions/runs/3387572937/jobs/5628487487#step:17:3
Warning: Failed to save: Cache size of ~10630 MB<PHONE_NUMBER>7 B) is over the 10GB limit, not saving cache.

Ah, sorry, I did not try to push you. Actuality it is not great that we exceed the limit of this kind, because we will not be able to rebuild the whole EVE-OS for example while modifying of some base package (eve-alpine) and all dependencies. Probably we can avoid such PRs and split them.

We still need to fix it. But that will become a big issue.

Well, It was another issue: https://github.com/lf-edge/eve/pull/2904

Thank you!
Will work on integration them here.


Old Message status download Expired

Dear Team,
I keep on getting this error/message again and again. I tried to download a Status report for a sent message and same was done by one more Author and we keep on getting this message at specific time. How can this be stopped as its annoying. It can report it once that's it but every day 4 messages are being sent.
Please assist. Rest downloading and Company Communicator App functions are fine.

I am having the same issue...was this resolved for you?  If so, what steps did you take to resolve?

@Sheshank-TCS @garystewart247 Do you still have this issue ? Please upgrade to latest version and let us know if its still happening.

I am not having any issues.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Priyank Saxena @.>
Sent: Tuesday, June 15, 2021 12:15:09 AM
To: OfficeDev/microsoft-teams-apps-company-communicator @.>
Cc: garystewart247 @.>; Mention @.>
Subject: Re: [OfficeDev/microsoft-teams-apps-company-communicator] Old Message status download Expired (#231)
@Sheshank-TCShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSheshank-TCS&data=04|01||4463789491314ebd3dc408d92fb42a92|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637593273120866308|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Lu%2FZ3v7V%2FVu6dq6buz9r7ZutaJ184C1A7L%2F9HMkhYYY%3D&reserved=0 @garystewart247https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgarystewart247&data=04|01||4463789491314ebd3dc408d92fb42a92|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637593273120876298|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=gHIpzSVCMSpeqI39ki2giqCaux6y%2F9IZcJhoLMKnIEE%3D&reserved=0 Do you still have this issue ? Please upgrade to latest version and let us know if its still happening.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FOfficeDev%2Fmicrosoft-teams-apps-company-communicator%2Fissues%2F231%23issuecomment-861155188&data=04|01||4463789491314ebd3dc408d92fb42a92|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637593273120886295|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=B9aZf9MDF7FbuHPI9I39rP7Sb1WpIoMOD%2FZBefF4%2Beo%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAAMCKKZJ43UFSULBQ4BBG3TS3HU3ANCNFSM4TFB6FCA&data=04|01||4463789491314ebd3dc408d92fb42a92|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637593273120886295|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=RmZAv5KTM7AsvIzvrmBGSQo8jpUpC%2BbUPtMVdcj%2FuHk%3D&reserved=0.


[SideNavigation][a11y] contrast does not meet 3 to 1 ratio

Description

The selected SideNav item color does not meet 3 to 1 contrast ratio with the adjacent background colors.
Steps to reproduce

Go to the docs site for side nav
Observe the selected standard variant, the background color of the selected variant compared to the background color of the adjacent SideNav items background colors

Expected behavior

The contrast between the non-selected and selected SideNav items MUST be at least 3:1.
Screenshots

Additional context
This is a failure of WCAG Success Criteria: 1.4.11 Non-text Contrast (Level AA) – WCAG 2.1
WCAG Understanding document: https://www.w3.org/WAI/WCAG21/Understanding/non-text-contrast

/attempt #2210

Current failure on latest code: insufficient color contrast of 2.01 (foreground color: #b1b1b1, background color: #f8f8f8, font size: 10.5pt (14px), font weight: normal). Expected contrast ratio of 4.5:1 for .spectrum-SideNav > .is-disabled.spectrum-SideNav-item > .spectrum-SideNav-itemLink[href="#"] > .spectrum-SideNav-link-text
https://opensource.adobe.com/spectrum-css/?path=/story/components-side-nav--default&globals=testingPreview:!true


libsqsh uses size_t for file sizes/offsets

Describe the bug
On a 32 bit system, the max value of a size_t is 4 GiB. A squashfs archive is allowed to be much larger than that (or should be allowed to start at an offset larger than that.
For example, the SqshMemoryMapperImpl::init function is expected to write the source size to a size_t *size pointer, and the map function recieves an offset in a sqsh_index_t offset (where sqsh_index_t is a typedef for size_t) parameter.

There are lot's of conversation issues on 32bit at the moment. I'll take a look at it. Thanks for reporting!


Fixed format issue in create-a-phone-system-auto-attendant.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/6057.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@MikePlumleyMSFT PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Support co-location of multiple NMs on the same node

Could be:

NMs from the same framework (super flex-up)
NMs from different frameworks/clusters
NMs from different versions/distros of Hadoop

This is really three more specific issues:

Let Mesos assign ports to the NM (currently static).
Ensure NM don't use the same logging directories (This is mostly a concern if Hadoop is installed locally).
Change policy to allow more than one NM per node.
The first and second bullets provide for multiple NMs from different framework/clusters to run on a single host.  The third is necessary for "super flex-up".

Great point! Let's file new issues for these subtasks.


Rewrite PriceModel marker rendering

This widget has logos that overlap sometimes, depending on shifts on real-world p/e ratios. It would be nice to rewrite which logos are visible using a system as found in the 200Y projection widget. In short:

Make an ordered list of markers we have.
From first to last, only render those markers which do not overlap with any of the markers with a lower index.
ETH should be first on this list.
The rest of the companies should be ordered by familiarity with the general public.
PE ratios sometimes come back null from the API. Skip those.

Hi Alex, here's a take on the PE marker rendering issue.
https://github.com/ultrasoundmoney/frontend/pull/254#issue-1465287175


Local testing mode support for V2 primitivse

Summary
Similar to #1495 but for V2 primitives.
Details and comments
Fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

53 of 54 (98.15%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 83.476%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/fake_provider/local_service.py
28
29
96.55%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
6163

Relevant Lines:
7383

💛  - Coveralls


rbenv install --list does not include all versions from ruby-build --definitions

I am trying to install Ruby 2.1.5 on Mac OS X 10.10.1.  I installed rbenv and ruby-build via Homebrew and I have upgraded both to the latest versions (0.4.0 for rbenv, 20141113 for ruby-build).
The output for rbenv install --list for regular Ruby stops at 2.1.0-preview1.
The output for ruby-build --definitions goes all the way to 2.2.10.
It looks like rbenv install <version.no> should just call ruby-build <version.no> , so there should not be a conflict.
Is there something to do to update rbenv install to be sure that all definitions of ruby-build are available?
Many thanks.

@mislav I don't have a plugins folder in .rbenv directory. Any advise?

@wilferrel Do you have the same problem: rbenv install --list not being equal to ruby-build --definitions? Can you post the result of the following:

ls `rbenv root`/plugins
which -a ruby-build rbenv-install

Thank you

My alternative to removing the directory all together was to add an alias to my dot files:
alias rbenv-update='cd ~/.rbenv/plugins/ruby-build/ && git pull'

however, not to promise this will include the bleeding edge builds.

Removing ~/.rbenv/plugins/ruby-build help me too. Thanks.

Thank you. It works for me too.

Removing ~/.rbenv/plugins/ruby-build help me too. Thank so much!

When I originally install rbenv with homebrew, homebrew said:
To use Homebrew's directories rather than ~/.rbenv add to your profile:
export RBENV_ROOT=/usr/local/var/rbenv
I removed that line from my profile and then removed any signs of rbenv in the /usr/local/var directory.
Now when I do echo $(rbenv root) you should get  /Users/<username>/.rbenv instead of /usr/local/var/rbenv.
Now everything works fine.

Think I have the problem described above. How do I remove ~/.rbenv/plugins/ruby-build ?

Sorry for the late post
Homebrew is only available on OSX. Another solution is to updage your ruby-build plugin.
cd ~/.rbenv/plugins/ruby-build/
git pull origin master
cd -
rbenv install -l

It should work on any patform.

If you install ruby-build not as a plugin, you can do so
brew update
brew upgrade ruby-build

If you install ruby-build not as a plugin, you can do so
brew update
brew upgrade ruby-build

Yes, under a homebrew install of ruby-build the ~/.rbenv/plugins directory doesn't exist.  This solves the issue for that case.  Thank you!

Sorry for the late post
Homebrew is only available on OSX. Another solution is to updage your ruby-build plugin.
cd ~/.rbenv/plugins/ruby-build/
git pull origin master
cd -
rbenv install -l

It should work on any patform.

Thank you! this worked perfectly.

Not anymore, I do not have that directory (nor the plugins dir)

For devops engineers and these ones who can't find ruby-build, here is the readme file:
https://github.com/rbenv/ruby-build#installation
Worked for me :)

@Dkilpatrick31   context: OS X mavericks with homebrew.  Homebrew is understandably complaining about me not succumbing to OS churn [gulp] tyranny.  Going to that directory and pulling assumes the directory was set as a git repository.
@danielmyasnikov 's suggestion works immediate wonders.  I can now toy  (and keep focus) with 2.7.2 and 3.0.0 on a stable OS.


[Bug] ADMM verbose doesn't work anymore

If ADMM is run with verbose = true, it throws an error in line 207 in ADMM.jl since the variable iteration doesn't exist.
I'm guessing that state.iteration instead, should fix it but I didn't look through the code thoroughly.

Yes that should fix it. I can push that change to master but the earliest time I can do that is in 2+ days

Maybe a more fundamental question is if we can replace verbose with some callback that has verbose printing for each solver or if we can replace verbose with Julias logging system.
I havent used the keyword yet, so Im not sure whats the most convenient from a user perspective. Do you have a preference?
Or maybe @JakobAsslaender you have one?
I could maybe sketch up verbosecallback in the next week

Hmm, my first instinct is that a callback is a rather complicated way of printing some convergence measures. Beyond this first instinct, I would try and keep it similar to other packages, but I would need look into the common practices.

Thanks. I don't have any preferences. FYI, the outputs in lines 267-271 also need a state..

Should be fixed with the latest (currently being released) version. I've also added tests for the verbose keyword


Revolut - The job location is "Romania" instead of "Remote"

ENVIRONMENT: production
URL: https://solr.peviitor.ro
Browser: Chrome
Device: Laptop
OS: Windows 11
STEPS TO REPRODUCE:
1.Open the URL in the browser
2.Execute Query for "Revolut" Company
3.Check the location for all jobs
4.Open https://www.revolut.com/careers/?city=Romania+-+Remote
5.Check the location for all jobs
EXPECTED RESULTS:
The job location is "remote" as on the company's website
ACTUAL RESULTS:
The job location is "Romania" instead of "Remote"

Fixed!

Partial fixat.
Solr, Ok!
Peviitor, OK!
scrapers.peviitor.ro, Database Error!


Mouse cursor flickers between default and Hand shape when hovering URL

System
Archlinux kernel 4.19
rust 1.32.0
i3 on x11
alacritty master 76dd84b
Behavior
When hovering across a highlighted URL, the cursor will flip back and forth between the default cursor for the context and the Hand shapes.
Expectation
Mouse cursor shape should always be Hand when on top of an URL.
Reproduce
Try echo "https://google.com" or similar command/input to get an URL
Move mouse cursor across the output, cursor should change shape as described
Extra
This issue was discovered while trying to make an enhancement to text selection, and is introduced in 84aca67. The behavior described is first seen in a99547c.
More context in this pull #2661

Could you test #2666?


Account used for AzCredential can't use MFA

The script fails with the error "Unable to acquire token for tenant" if the account used as AzCredential requires MFA (and if its password is expired as well). It took me a few hours to realize it, so it may be worth mentioning it somewhere

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2f7e3b4a-30fb-4068-32b1-943cd483f531
Version Independent ID: fc78fd4f-2626-e0b9-8ac0-7ea1938ff419
Content: Deploy MySQL resource provider on Azure Stack
Content Source: azure-stack/operator/azure-stack-mysql-resource-provider-deploy.md
Service: azure-stack
GitHub Login: @mattbriggs
Microsoft Alias: mabrigg

@Cyr-Az Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@Cyr-Az Thanks for your feedback. I've added a note in the topic. Thanks! Matt
#please-close


Update custom events documentation example

The interface for the DfE::Analytics#with_data method has changed.
It requires a data key at the top level containing the data hash.
If not provided, the data hash gets ignored when creating the event.
Related to https://github.com/DFE-Digital/dfe-analytics/issues/182

Superseeded by https://github.com/DFE-Digital/dfe-analytics/pull/184


swift-api-digester: diagnose removal/addition of dynamic attribute under abi mode.

@swift-ci please smoke test and merge


MemoryError for get_halos_per_forest

When trying to convert the temporal indices to the tree local ones (function convert_indices in convert_indices.py) for the 2048^3 simulation I hit a MemoryError when calling get_halos_per_forest from the common.py module.
Traceback (most recent call last):
  File "run_convert_indices.py", line 30, in <module>
    ID_fields, index_mult_factor)
  File "/home/jseiler/.local/lib/python3.6/site-packages/astro3D-0.0.0.dev2-py3.6.egg/astro3D/genesis/utils/convert_indices.py", line 82, in convert_indices
    forestID_field)
  File "/home/jseiler/.local/lib/python3.6/site-packages/astro3D-0.0.0.dev2-py3.6.egg/astro3D/genesis/utils/common.py", line 298, in get_halos_per_forest
    forests_binned = np.bincount(halo_forestids)
MemoryError

I've added some print statements and I'm baffled by this error.  The arrays that it's using aren't excessive in size.  The only thing that could be happening is that the open HDF5 file is chewing up all the RAM?  However, I've run this through the queue on OzStar with 200GB of RAM requested and still hit the same issue...
@manodeep : If you have time during the retreat, could you look into this?  The dev branch has all the updated filepaths.  You should be able to run these with the scripts in the run_scripts directory; in particular, the run_convert_indices.py file.

This might be because of the histogram that numpy is trying to create based on the forestids.
What’s the reasoning for the histogram?

It counts the number of occurences of each forestID in the Snapshot.  That is, the number of halos belonging to each forest in the Snapshot.  I could make the variable name a bit clearer...
I think I've found out what's happening.  np.bincount generates an array with len(max(halo_forestids)).  For the 2048^3 simulation, the forestID values seem to account for the 1e12 multiplication factor. As a result, np.bincount is generating an array with length > 1e12.
@pelahi : For L105, N2048^3 simulation, the halos have inconsistent values for the ForestID field. For Snapshot 0 they are all small numbers
In [20]: f["Snap_000"]["ForestID"][:]
Out[20]:
array([ 1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14, 15, 16, 17,
       18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34,
       35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46])

But for all other snapshots they seem to be scaled by the 1e12 factor
In [22]: f["Snap_001"]["ForestID"][0:10]
Out[22]:
array([1000000000001,<PHONE_NUMBER>002,<PHONE_NUMBER>003,<PHONE_NUMBER>004,
<PHONE_NUMBER>005,<PHONE_NUMBER>006,<PHONE_NUMBER>007,<PHONE_NUMBER>008,
<PHONE_NUMBER>009,<PHONE_NUMBER>010])

For the L500, N1024^3 simulation all of the values WEREN'T scale by the 1e12 factor.   Which of these conventions is correct?  Could you check your conversion codes to see if something went wrong for Snapshot 000 in the L105, N2048^3 simulation?

Can you use np.unique instead of np.bincount?