Milestones for the first release

[x] Support for multiple users  https://github.com/openshift-pipelines/manual-approval-gate/pull/125

[x] Handle when approvalRequired is not given
[x] Handle deletion of approvaltasks when customrun is deleted
[x] Add labels/annoations (pipelinerunName, customrun name, etc)

[x] Adds auth by configuring webhook controller https://github.com/openshift-pipelines/manual-approval-gate/pull/127
[x] Timeout for approvaltask https://github.com/openshift-pipelines/manual-approval-gate/pull/132
[x] Add support for description https://github.com/openshift-pipelines/manual-approval-gate/pull/143
[x] Support for message while approving the approvaltask https://github.com/openshift-pipelines/manual-approval-gate/pull/128
[ ] Handle the scenario when approvals list is not given but approvalsRequired is given (as of today oc edit works for this, oc patch won't work) (future tkn should add this)
[x] Add CLI to approve the approval task

[x]  https://github.com/openshift-pipelines/manual-approval-gate/pull/141
[x] https://github.com/openshift-pipelines/manual-approval-gate/pull/153
[x] https://github.com/openshift-pipelines/manual-approval-gate/pull/154
[x] https://github.com/openshift-pipelines/manual-approval-gate/pull/154

[x] Improve logs

[x]  compute the hash of Approvaltask spec and store as an annotation,
in further reconciliation we compute hash of ApprovalTask spec and check with
annotation, if they are same then we skip updating the object
otherwise we update approvaltask state based on the input

Does it work on kubernetes1.26 tekton v0.40.0 version?


Provide strict validation

Would be nice with a way to run this validation without using the ::clean() function, as this modifies data.

Might be possible; what's your use case? Is it for validating input-data or data thats already existing/stored in a database – and in what scenario is this causing you issues? Just curious =)
The clean-method seems to make little to zero impact on the actual validation results. Will investigate and see what the idea behind this was at the get-go.

@tomsommer A new release is available (https://github.com/olssonm/swedish-entity/releases/tag/v1.2.0) where the Clean-method is no longer automatically applied.
Thank you for your feedback.


Search page results after hovering jumps on top each other

https://fakeflixapp.vercel.app/search?q=divi
Here,
maybe it should act like in homepage, where other images slides to both sides?

Nope, that layout was made on purpose, same as Netflix


Remove clear_password assertions for storage/passwords tests

POST requests to the /storage/passwords endpoint should not return the clear_password back in plaintext. The POST response should mask the clear_password but the Python SDK tests specifically check for the created or updated password. I removed those assertion checks.

Hey @dgao1029 I think the change that we actually want that will ensure that the clear_password is available as it was before to end-users is to force a state refresh after password creation. Following the Java SDK which you were just investigating this will update our StoragePassword model using the GET response.
So if you revert your testing changes and change this line: https://github.com/splunk/splunk-sdk-python/blob/develop/splunklib/client.py#L1847
to
storage_password = StoragePassword(self.service, self._entity_path(state))

I believe that will allow users to retrieve the password.clear_password as they were before without removing functionality.

@dgao1029 thank you for the PR, closing the PR as the change is not required.


Sample Application Broken

I tried integrating your sample application, but when i try to create a new group i get a crash here:
NoMethodError at /groups/new
undefined method `name' for #<Group id: nil, type: nil>

  <% end %>

    <%= f.label :name %>

    <%= f.text_field :name %>

    <%= f.submit %>

<% end %>

Any ideas?

The default Groupify migration doesn't add a name column to the groups table. You'd have to modify it and add it yourself. See #41


election-day: No mention of spec for nil argument to VoteCount function

The test reveal that 0 should be returned

Maybe I'm understanding what you are saying wrong, but the instructions for that task and the example given do tell what to do in the nil case.

Yep: https://github.com/exercism/go/blob/main/exercises/concept/election-day/.docs/instructions.md#2-get-number-of-votes-from-a-counter
That pretty clearly says exactly what to do in the nil case for VoteCount.


Completely breaks Discord.

So, I did a fresh install of Discord and I installed BD using
$ betterdiscordctl install

but when I restarted Discord (the app), not only BD didn't launch but the app started behaving as if it was the browser version.

Duplicate of #96.


alternate script format not being converted when type declarations before script

I have a feeling this one is old too

I think this has been fixed unintentionally at some point


Add migration to show plan end date as current legal end date

Also add isCurrentLegalVersion bool so the UI can still indicate which is currently legal (vs looking for a null effective end date).
@okanji fyi, just ping me if you need any more info : ).

#202


Improve bumpversion regex matching

With current configuration, bumpversion will find&replace any occurrence of the version number in setup.py and my_project/init.py
This leads to trouble typically when setup.py mentions a dependency which has by hazard the same version number as our project (thus the dependency will get it version upped)
This fix precises to bumpversion a regex to match in the files in order to prevent such mistake.

Thanks @touilleMan!


clubs: changing stop mechanism to be 'heard'

This changes our "stop" mechanism from echoes to already heard. So each piece of gossip travels with a unique identifier and if we've already heard that uid then we just ignore it. If we haven't heard it, we continue to gossip it to everyone and process like before. So at most we should hear n facts, where n is the number of group members, because the initial sender sends one, which everyone gossips to everyone else, so we should hear one per person. One of these will get recorded in our heard set and the rest ignored.
Clarifying because this was unclear to me: the reason we initially send to everyone and also gossip to everyone is that this ensures that we get close to proper ordering in the case of sender/receiver ships going offline in tandem and then coming online out of order. If the receiver comes back online and hasn't heard the senders poke yet (because they're offline) the gossipers should conceivably poke the gossip first before poking any other messages that they would have sent as well, conserving order.
@jamesacklin flagging that this is breaking change we should communicate to third party devs.

Notably this breaks connection between people on the old version of clubs vs the new. Started to go down a path to making it backwards compatible, but I wasn't sure how to mesh the two methods.

Pinging for review, one note here is that we talked about trying to make these backwards compatible by potentially hashing the contents but I think that only works forward aka old trying to talk to new. If we left echoes I suppose it could work for old as well?

working on backwards compat, just making sure we don't merge yet


await client.list_contacts(request=request)

Environment details

OS type and version:
Linux host-name <IP_ADDRESS>-microsoft-standard-WSL2 # 1 SMP Fri Apr 2 22:23:49 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Python version: python --version
Python 3.10.10
pip version: pip --version
pip 23.0
google-cloud-essential-contacts version: pip show google-cloud-essential-contacts
Name: google-cloud-essential-contacts
Version: 1.1.1
Summary: Essential Contacts API client library
Home-page: https://github.com/googleapis/python-essential-contacts
Author: Google LLC
Author-email<EMAIL_ADDRESS>License: Apache 2.0
Location: /home/splash/.local/lib/python3.8/site-packages
Requires: google-api-core, proto-plus

Steps to reproduce

Hello,
I am trying to make this example work, but from what i have noticed, it lacks the await client.list_contacts(request=request)
This example: https://github.com/googleapis/python-essential-contacts/blob/main/samples/generated_samples/essentialcontacts_v1_generated_essential_contacts_service_list_contacts_async.py
2. Otherwise it throws this error:
TypeError: 'async for' requires an object with aiter method, got coroutine
sys:1: RuntimeWarning: coroutine 'EssentialContactsServiceAsyncClient.list_contacts' was never awaited
Code example
Here is my working code example:
from google.cloud import essential_contacts_v1
import asyncio

async def sample_list_contacts():
    # Create a client
    client = essential_contacts_v1.EssentialContactsServiceAsyncClient()

    # Initialize request argument(s)
    request = essential_contacts_v1.ListContactsRequest(
        parent="projects/GCP_PROJECT_ID",
    )

    # Make the request
    page_result = await client.list_contacts(request=request)
    async for response in page_result:
        print(response)

async def main():
    await sample_list_contacts()

asyncio.run(main())

Stack trace
# example

Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

Thanks for reporting this issue. I'm going to transfer this issue to the repository for the code generator that produces the sample code:
https://github.com/googleapis/python-essential-contacts/blob/main/samples/generated_samples/essentialcontacts_v1_generated_essential_contacts_service_list_contacts_async.py#L47
page_result = client.list_contacts(request=request)

should be
page_result = await client.list_contacts(request=request)


Checkout Payment Gateway

Fake payment is working.
I am implemented my own payment gateway. But I am having problems leaving JSON on mobile for magento2. I send the field and the information but return the error as if I didn't have the information in JSON.
The info marks I need to send are VAT, card number, validity ...  I send it in Checkou's JSON, but it doesn't work.
My gateway does not need to redirect the page, but I found this solution. In my case, would this be the most suitable solution?
https://magento.stackexchange.com/questions/99396/magento-2-rest-api-checkout-payment-gateway-redirect

Hey @sid3291, can you provide more details it's not clear what is going on your end?
Fake payment is working.
What do you mean?
But I am having problems leaving JSON on mobile for magento2. I send the field and the information but return the error as if I didn't have the information in JSON.
What are you sending? What endpoint? What is the error?

We are trying to send a json to the bank's module, but it returns error 104, as if we weren't sending all the needed information.

I don't think I can understand what is going on without code.


Compatibility issues with latest Oban release (2.18.3)

Report
I'm not sure if it's related to using an older version of Elixir or not, but since this last update our CI is breaking and we are not able to update Oban's version:
https://github.com/oban-bg/oban/blob/696df17de5e0af966a6b4cbee9b14f4e9a7a2c8e/lib/oban/nursery.ex#L27
Environment

Oban Version: 2.18.3 (Free)
PostgreSQL Version: 13-alpine
Elixir & Erlang/OTP Versions: Elixir 1.13.4 (compiled with Erlang/OTP 25)

Current Behavior
Stacktrace from CI:
** (Mix) Could not start application my_application: MyApplication.Application.start(:normal, []) returned an error: shutdown: failed to start child: Oban
    ** (EXIT) shutdown: failed to start child: {:via, Registry, {Oban.Registry, {Oban, Oban.Nursery}}}
        ** (EXIT) shutdown: failed to start child: {Oban.Registry, {Oban, Foreman}}
            ** (EXIT) an exception was raised:
                ** (ArgumentError) expected :strategy option to be given
                    (elixir 1.13.4) lib/dynamic_supervisor.ex:516: DynamicSupervisor.init/1
                    (elixir 1.13.4) lib/dynamic_supervisor.ex:258: DynamicSupervisor.start_link/1
                    (stdlib <IP_ADDRESS>) supervisor.erl:420: :supervisor.do_start_child_i/3
                    (stdlib <IP_ADDRESS>) supervisor.erl:406: :supervisor.do_start_child/2
                    (stdlib <IP_ADDRESS>) supervisor.erl:390: anonymous fn/3 in :supervisor.start_children/2
                    (stdlib <IP_ADDRESS>) supervisor.erl:1273: :supervisor.children_map/4
                    (stdlib <IP_ADDRESS>) supervisor.erl:350: :supervisor.init_children/2
                    (stdlib <IP_ADDRESS>) gen_server.erl:851: :gen_server.init_it/2

Expected Behavior
One minor version behind the application would start just fine.
In application.ex we are using strategy: :one_for_one and starting Oban normally:
    {Oban, Application.fetch_env!(:my_application, Oban)}

Config:
config :my_application, Oban,
  repo: MyApplication.Repo,
  plugins: [
    {
      Oban.Plugins.Cron,
      crontab: [
          # ...
      ]
    }
  ],
  queues: [
    # ...
  ]

We are also using latest migration version:
Oban.Migrations.up(version: 11)

This is because you're using an older Elixir version. Oban v2.18 requires Elixir 1.14+ (incorrect in the README, but stated in mix.exs). We'll update the README to reflect the correct minimum for v2.18.
You'll need to either upgrade Elixir, or stick to Oban v2.17 (upgrading Elixir is highly recommended)


Failed to get convolution algorithm. This is probably because cuDNN failed to initialize

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version: 1.14
Python version: 3.7.6
Installed using virtualenv? pip? conda?: pip
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: CUDA -- 10.0, cuDNN -- 7.4.2
GPU model and memory:

Quadro RTX 4000 -- 8G
GeForce RTX 2080 ti -- 12G
Describe the problem
I have two GPU on two machines, Quadro RTX 4000 and GeForce RTX 2080 ti. And I install the same NVIDIA-driver 440.59. I did the cuDNN sample test and it passed the test. And I ran the tensorflow benchmark using the below commands.  I used a small enough batch to avoid the OOM issue. The machine with GeForce RTX 2080 ti can successfully run the benchmark. But the machine with Quadro RTX 4000 cannot run the benchmark, which said "Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above." Do you have any idea about this issue? Is it related to hardware?
Provide the exact sequence of commands / steps that you executed before running into the problem
$python tf_cnn_benchmarks.py --data_format=NCHW --batch_size=32 --model=resnet50 --optimizer=momentum --variable_update=replicated --nodistortions --gradient_repacking=8 --num_gpus=2 --num_epochs=90 --weight_decay=1e-4 --use_fp16 --train_dir=/home/lab2
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
I0426 23:04:18.110438<PHONE_NUMBER>83968 session_manager.py:502] Done running local_init_op.
INFO:tensorflow:Starting standard services.
I0426 23:04:24.543723<PHONE_NUMBER>83968 supervisor.py:737] Starting standard services.
INFO:tensorflow:Starting queue runners.
I0426 23:04:24.543950<PHONE_NUMBER>83968 supervisor.py:743] Starting queue runners.
Running warm up
2020-04-26 23:04:29.404714: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcublas.so.10.0
2020-04-26 23:04:30.068934: I tensorflow/stream_executor/platform/default/dso_loader.cc:42] Successfully opened dynamic library libcudnn.so.7
2020-04-26 23:04:31.178428: E tensorflow/stream_executor/cuda/cuda_dnn.cc:329] Could not create cudnn handle: CUDNN_STATUS_INTERNAL_ERROR
2020-04-26 23:04:32.225534: E tensorflow/stream_executor/cuda/cuda_dnn.cc:329] Could not create cudnn handle: CUDNN_STATUS_INTERNAL_ERROR
2020-04-26 23:04:32.261894: E tensorflow/stream_executor/cuda/cuda_dnn.cc:329] Could not create cudnn handle: CUDNN_STATUS_INTERNAL_ERROR
2020-04-26 23:04:32.295444: E tensorflow/stream_executor/cuda/cuda_dnn.cc:329] Could not create cudnn handle: CUDNN_STATUS_INTERNAL_ERROR
INFO:tensorflow:Error reported to Coordinator: <class 'tensorflow.python.framework.errors_impl.UnknownError'>, 2 root error(s) found.
(0) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
[[node tower_0/v0/cg/conv0/conv2d/Conv2D (defined at /tmp/tmpq2hyfuxj.py:12) ]]
(1) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
[[node tower_0/v0/cg/conv0/conv2d/Conv2D (defined at /tmp/tmpq2hyfuxj.py:12) ]]
[[Reshape_603/_2957]]
0 successful operations.
1 derived errors ignored.
Errors may have originated from an input operation.
Input Source operations connected to node tower_0/v0/cg/conv0/conv2d/Conv2D:
Cast (defined at /root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py:101)
tower_0/v0/cg/conv0/Pad (defined at /root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py:204)
Input Source operations connected to node tower_0/v0/cg/conv0/conv2d/Conv2D:
Cast (defined at /root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py:101)
tower_0/v0/cg/conv0/Pad (defined at /root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py:204)
Original stack trace for 'tower_0/v0/cg/conv0/conv2d/Conv2D':
File "tf_cnn_benchmarks.py", line 73, in
app.run(main)  # Raises error on invalid flags, unlike tf.app.run()
File "/root/anaconda3/lib/python3.7/site-packages/absl/app.py", line 299, in run
_run_main(main, args)
File "/root/anaconda3/lib/python3.7/site-packages/absl/app.py", line 250, in _run_main
sys.exit(main(argv))
File "tf_cnn_benchmarks.py", line 68, in main
bench.run()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 1880, in run
return self._benchmark_train()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 2076, in _benchmark_train
build_result = self._build_graph()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 2110, in _build_graph
(input_producer_op, enqueue_ops, fetches) = self.build_model()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 2828, in build_model
gpu_compute_stage_ops, gpu_grad_stage_ops)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 3345, in add_forward_pass_and_gradients
outputs = maybe_compile(forward_pass_and_gradients, self.params)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 3542, in maybe_compile
return computation()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 3199, in forward_pass_and_gradients
input_list, phase_train, nclass)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/models/model.py", line 293, in build_network
self.add_inference(network)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/models/resnet_model.py", line 308, in add_inference
cnn.conv(64, 7, 7, 2, 2, mode='SAME_RESNET', use_batch_norm=True)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py", line 209, in conv
kernel_initializer=kernel_initializer)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py", line 134, in conv2d_impl
use_bias=False)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/util/deprecation.py", line 324, in new_func
return func(*args, **kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/layers/convolutional.py", line 424, in conv2d
return layer.apply(inputs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/keras/engine/base_layer.py", line 1479, in apply
return self.call(inputs, *args, **kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/layers/base.py", line 537, in call
outputs = super(Layer, self).call(inputs, *args, **kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/keras/engine/base_layer.py", line 634, in call
outputs = call_fn(inputs, *args, **kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/autograph/impl/api.py", line 146, in wrapper
), args, kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/autograph/impl/api.py", line 450, in converted_call
result = converted_f(*effective_args, **kwargs)
File "/tmp/tmpq2hyfuxj.py", line 12, in tf__call
outputs = ag.converted_call('convolution_op', self, ag.ConversionOptions(recursive=True, force_conversion=False, optional_features=(), internal_convert_user_code=True), (inputs, self.kernel), None)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/autograph/impl/api.py", line 356, in converted_call
return _call_unconverted(f, args, kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/autograph/impl/api.py", line 255, in _call_unconverted
return f(*args)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/ops/nn_ops.py", line 1079, in call
return self.conv_op(inp, filter)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/ops/nn_ops.py", line 635, in call
return self.call(inp, filter)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/ops/nn_ops.py", line 234, in call
name=self.name)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/ops/nn_ops.py", line 1953, in conv2d
name=name)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/ops/gen_nn_ops.py", line 1071, in conv2d
data_format=data_format, dilations=dilations, name=name)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/framework/op_def_library.py", line 788, in _apply_op_helper
op_def=op_def)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/util/deprecation.py", line 507, in new_func
return func(*args, **kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/framework/ops.py", line 3616, in create_op
op_def=op_def)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/framework/ops.py", line 2005, in init
self._traceback = tf_stack.extract_stack()
I0426 23:04:32.326952<PHONE_NUMBER>83968 coordinator.py:224] Error reported to Coordinator: <class 'tensorflow.python.framework.errors_impl.UnknownError'>, 2 root error(s) found.
(0) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
[[node tower_0/v0/cg/conv0/conv2d/Conv2D (defined at /tmp/tmpq2hyfuxj.py:12) ]]
(1) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
[[node tower_0/v0/cg/conv0/conv2d/Conv2D (defined at /tmp/tmpq2hyfuxj.py:12) ]]
[[Reshape_603/_2957]]
0 successful operations.
1 derived errors ignored.
Errors may have originated from an input operation.
Input Source operations connected to node tower_0/v0/cg/conv0/conv2d/Conv2D:
Cast (defined at /root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py:101)
tower_0/v0/cg/conv0/Pad (defined at /root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py:204)
Input Source operations connected to node tower_0/v0/cg/conv0/conv2d/Conv2D:
Cast (defined at /root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py:101)
tower_0/v0/cg/conv0/Pad (defined at /root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py:204)
Original stack trace for 'tower_0/v0/cg/conv0/conv2d/Conv2D':
File "tf_cnn_benchmarks.py", line 73, in
app.run(main)  # Raises error on invalid flags, unlike tf.app.run()
File "/root/anaconda3/lib/python3.7/site-packages/absl/app.py", line 299, in run
_run_main(main, args)
File "/root/anaconda3/lib/python3.7/site-packages/absl/app.py", line 250, in _run_main
sys.exit(main(argv))
File "tf_cnn_benchmarks.py", line 68, in main
bench.run()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 1880, in run
return self._benchmark_train()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 2076, in _benchmark_train
build_result = self._build_graph()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 2110, in _build_graph
(input_producer_op, enqueue_ops, fetches) = self.build_model()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 2828, in build_model
gpu_compute_stage_ops, gpu_grad_stage_ops)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 3345, in add_forward_pass_and_gradients
outputs = maybe_compile(forward_pass_and_gradients, self.params)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 3542, in maybe_compile
return computation()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 3199, in forward_pass_and_gradients
input_list, phase_train, nclass)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/models/model.py", line 293, in build_network
self.add_inference(network)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/models/resnet_model.py", line 308, in add_inference
cnn.conv(64, 7, 7, 2, 2, mode='SAME_RESNET', use_batch_norm=True)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py", line 209, in conv
kernel_initializer=kernel_initializer)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py", line 134, in conv2d_impl
use_bias=False)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/util/deprecation.py", line 324, in new_func
return func(*args, **kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/layers/convolutional.py", line 424, in conv2d
return layer.apply(inputs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/keras/engine/base_layer.py", line 1479, in apply
return self.call(inputs, *args, **kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/layers/base.py", line 537, in call
outputs = super(Layer, self).call(inputs, *args, **kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/keras/engine/base_layer.py", line 634, in call
outputs = call_fn(inputs, *args, **kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/autograph/impl/api.py", line 146, in wrapper
), args, kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/autograph/impl/api.py", line 450, in converted_call
result = converted_f(*effective_args, **kwargs)
File "/tmp/tmpq2hyfuxj.py", line 12, in tf__call
outputs = ag.converted_call('convolution_op', self, ag.ConversionOptions(recursive=True, force_conversion=False, optional_features=(), internal_convert_user_code=True), (inputs, self.kernel), None)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/autograph/impl/api.py", line 356, in converted_call
return _call_unconverted(f, args, kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/autograph/impl/api.py", line 255, in _call_unconverted
return f(*args)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/ops/nn_ops.py", line 1079, in call
return self.conv_op(inp, filter)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/ops/nn_ops.py", line 635, in call
return self.call(inp, filter)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/ops/nn_ops.py", line 234, in call
name=self.name)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/ops/nn_ops.py", line 1953, in conv2d
name=name)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/ops/gen_nn_ops.py", line 1071, in conv2d
data_format=data_format, dilations=dilations, name=name)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/framework/op_def_library.py", line 788, in _apply_op_helper
op_def=op_def)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/util/deprecation.py", line 507, in new_func
return func(*args, **kwargs)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/framework/ops.py", line 3616, in create_op
op_def=op_def)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/framework/ops.py", line 2005, in init
self._traceback = tf_stack.extract_stack()
Traceback (most recent call last):
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1356, in _do_call
return fn(*args)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1341, in _run_fn
options, feed_dict, fetch_list, target_list, run_metadata)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1429, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.UnknownError: 2 root error(s) found.
(0) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
[[{{node tower_0/v0/cg/conv0/conv2d/Conv2D}}]]
(1) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
[[{{node tower_0/v0/cg/conv0/conv2d/Conv2D}}]]
[[Reshape_603/_2957]]
0 successful operations.
1 derived errors ignored.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "tf_cnn_benchmarks.py", line 73, in
app.run(main)  # Raises error on invalid flags, unlike tf.app.run()
File "/root/anaconda3/lib/python3.7/site-packages/absl/app.py", line 299, in run
_run_main(main, args)
File "/root/anaconda3/lib/python3.7/site-packages/absl/app.py", line 250, in _run_main
sys.exit(main(argv))
File "tf_cnn_benchmarks.py", line 68, in main
bench.run()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 1880, in run
return self._benchmark_train()
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 2085, in _benchmark_train
return self._benchmark_graph(result_to_benchmark, eval_build_results)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 2294, in _benchmark_graph
is_chief, summary_writer, profiler)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 2430, in benchmark_with_session
collective_graph_key=collective_graph_key)
File "/root/benchmarks/scripts/tf_cnn_benchmarks/benchmark_cnn.py", line 869, in benchmark_one_step
results = sess.run(fetches, options=run_options, run_metadata=run_metadata)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 950, in run
run_metadata_ptr)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1173, in _run
feed_dict_tensor, options, run_metadata)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1350, in _do_run
run_metadata)
File "/root/anaconda3/lib/python3.7/site-packages/tensorflow/python/client/session.py", line 1370, in _do_call
raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.UnknownError: 2 root error(s) found.
(0) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
[[node tower_0/v0/cg/conv0/conv2d/Conv2D (defined at /tmp/tmpq2hyfuxj.py:12) ]]
(1) Unknown: Failed to get convolution algorithm. This is probably because cuDNN failed to initialize, so try looking to see if a warning log message was printed above.
[[node tower_0/v0/cg/conv0/conv2d/Conv2D (defined at /tmp/tmpq2hyfuxj.py:12) ]]
[[Reshape_603/_2957]]
0 successful operations.
1 derived errors ignored.
Errors may have originated from an input operation.
Input Source operations connected to node tower_0/v0/cg/conv0/conv2d/Conv2D:
Cast (defined at /root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py:101)
tower_0/v0/cg/conv0/Pad (defined at /root/benchmarks/scripts/tf_cnn_benchmarks/convnet_builder.py:204)

I added the following codes at the beginning of the benchmark file. The issue was gone.
from tensorflow.compat.v1 import ConfigProto
from tensorflow.compat.v1 import InteractiveSession
config = ConfigProto()
config.gpu_options.allow_growth = True
session = InteractiveSession(config=config)
But I still want to figure out if it is related to hardware?
Is there other solution to solve it stably?

@Young768
Glad to know the issue got resolved.Please, go through the link1, link2 , link3 and see if it helps you. Please, close this thread as your issue was resolved. Thanks!

@Young768
Glad to know the issue got resolved.Please, go through the link1, link2 , link3 and see if it helps you. Please, close this thread as your issue was resolved. Thanks!


Richtext can't be edited after rearranging blocks

Link to reproduction
https://github.com/christoph-reps/payload/tree/richtext-cant-edit
To Reproduce

Add new item to Seite collection
Add Richtext Block with some text
Add a second Richtext Block with some text
Move second Richtext Block before the first one
Try to edit the text

Describe the Bug
After carrying out these steps the richtext editor no longer accepts inputs and the console reports following error.
Uncaught TypeError: editor.selection is null
    onKeyDown RichText.tsx:369
    isEventHandled index.es.js:4640
    onKeyDown index.es.js:4289
    React 15
        callCallback
        invokeGuardedCallbackDev
        invokeGuardedCallback
        invokeGuardedCallbackAndCatchFirstError
        executeDispatch
        processDispatchQueueItemsInOrder
        processDispatchQueue
        dispatchEventsForPlugins
        dispatchEventForPluginEventSystem
        batchedUpdates$1
        batchedUpdates
        dispatchEventForPluginEventSystem
        dispatchEventWithEnableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
        dispatchEvent
        dispatchDiscreteEvent
2 RichText.tsx:369:44

Payload Version
1.7.5

Hey @christoph-reps — thank you for the report! Fix incoming. Gonna do some further testing but expect this to be merged shortly.
Especially thanks for the REPRODUCTION repo! That is so helpful, you have no idea.


Electron website fails colour contrast

It's important that all users are able to read a website with ease be it when being viewed by someone having colour deficits or when viewed on a black and white screen.
We should be aiming for all colours to be at least AA compliant.
Unfortunately the Electron website doesn't pass AA compliance in a lot of areas- this means that the contrast is not enough for users with vision problems to be able to view the text easily.
Hero area

Links in hero area

Links on white

Top bar navigation

More features area

All text should pass AA compliance for it to be good enough for everyone to use. If you'd like me to talk through this in more detail I'd be happy to.
cc @simurai @mdo @connors @jlord

I believe @simurai is in the process of redesigning this whole thing anyway. Is that right, Simon?

@amosie Thanks for raising this issue, would you mind moving it to the repository for the website? https://github.com/atom/electron.atom.io

@kevinsawicki eeek sorry - done https://github.com/atom/electron.atom.io/issues/191


Text size fails to convert to double

Describe the bug
When using one of the font size classes (text-base for example) in a custom component, I'm getting a runtime error saying "1rem" cannot be casted to a double, followed by an application crash:

I'm not able to figure out why it is behaving like this, maybe due a custom font? or because of the custom component?
import React, {FC} from 'react';
import {
  Platform,
  StyleSheet,
  Text,
  TextProps,
  Switch as RNSwitch,
  SwitchProps,
} from 'react-native';

type ITProps = TextProps;

export const T: FC<ITProps> = ({children, style}) => {
  return <Text style={[styles.baseText, style]}>{children}</Text>;
};

// And then on my component
<T className="text-base">Quack</T>

Expected behavior
1rem class should not be passed to the text component but rather the actual number size.

Classes using REM units are not available in the current stable. If you upgrade to next (see pinned issue #308) you can use them.

You closed this too fast, I don't care about rem units, just want to set a smaller font size, which in theory does not require next
I'm also having problems updating to next, the only example you provided is for expo, but the current configuration I have doesn't seem to be working:
// eslint-disable-next-line @typescript-eslint/no-var-requires
const {getDefaultConfig} = require('metro-config');
// eslint-disable-next-line @typescript-eslint/no-var-requires
const withNativewind = require('nativewind/metro');

module.exports = (async () => {
  const {
    resolver: {sourceExts, assetExts},
    ...rest
  } = await getDefaultConfig(__dirname);
  const config = {
    ...rest,
    transformer: {
      babelTransformerPath: require.resolve('react-native-svg-transformer'),
    },
    resolver: {
      assetExts: [...assetExts.filter(ext => ext !== 'svg'), 'bin', 'jar'],
      sourceExts: [...sourceExts, 'svg'],
    },
  };
  console.warn('config before native wind');
  console.warn(config);
  console.warn('config AFTER native wind');
  console.warn(withNativewind(config));

  return config;
})();

Any idea what might be wrong?

I managed to get metro to work with the following config:
// eslint-disable-next-line @typescript-eslint/no-var-requires
const {getDefaultConfig} = require('metro-config');
// eslint-disable-next-line @typescript-eslint/no-var-requires
const withNativewind = require('nativewind/metro');

module.exports = (async () => {
  const {
    resolver: {sourceExts, assetExts},
    ...rest
  } = await getDefaultConfig(__dirname);
  const config = {
    transformer: {
      babelTransformerPath: require.resolve('react-native-svg-transformer'),
      getTransformOptions: rest.transformer.getTransformOptions,
    },
    resolver: {
      assetExts: [...assetExts.filter(ext => ext !== 'svg'), 'bin', 'jar'],
      sourceExts: [...sourceExts, 'svg'],
    },
  };

  return withNativewind(config);
})();

But now when the app loads the bundle I get a runtime error:
Error: tailwindcss plugin function argument object prop "web" not implemented, js engine: hermes

You closed this too fast, I don't care about rem units, just want to set a smaller font size, which in theory does not require next

NativeWind overrides your theme fontSizes to px values, so if text-base is giving an rem value then I assumed you had overridden it's value, or were using a plugin that sets it.
If I test text-base in a new project, it render correctly without error and the Expo Snacks appear to be working fine.

Error: tailwindcss plugin function argument object prop "web" not implemented, js engine: hermes

I would need to see your tailwind.config.js to debug

@ospfranco What platform are you using iOS/Android/Web/etc?

ah, now I understand, yeah, I was using TWRNC which did allow to replace the fontSizes with rem values. After removing the sizes now it works.
I hope the problems I faced with next are still useful to you though. Thanks a lot for the help!


Handle error: NameError: name 'SignatureExpired' is not defined

Error handling appears to fail during invalid cookie due to missing import.
I have itsdangerous 1.1.0 installed in pip3 but still get the error.  Fixing the import should solve that.
Received this error:
NameError
NameError: name 'SignatureExpired' is not defined

Traceback (most recent call last)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/flask_oidc_ext/__init__.py", line 375, in _get_cookie_id_token
return self.cookie_serializer.loads(id_token_cookie)
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/itsdangerous/jws.py", line 143, in loads
self.make_signer(salt, self.algorithm).unsign(want_bytes(s)),
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/itsdangerous/signer.py", line 169, in unsign
raise BadSignature("Signature %r does not match" % sig, payload=value)
During handling of the above exception, another exception occurred:
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/flask/app.py", line 1948, in full_dispatch_request
rv = self.preprocess_request()
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/flask/app.py", line 2242, in preprocess_request
rv = func()
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/flask_oidc_ext/__init__.py", line 437, in _before_request
self.authenticate_or_redirect()
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/flask_oidc_ext/__init__.py", line 457, in authenticate_or_redirect
id_token = self._get_cookie_id_token()
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/flask_oidc_ext/__init__.py", line 376, in _get_cookie_id_token
except SignatureExpired:
NameError: name 'SignatureExpired' is not defined
The debugger caught an exception in your WSGI application. You can now look at the traceback which led to the error.
To switch between the interactive traceback and the plaintext one, you can click on the "Traceback" headline. From the text traceback you can also create a paste of it.

Brought to you by DON'T PANIC, your friendly Werkzeug powered traceback interpreter.

DCO 1.1 Signed-off-by: Andrew R. Freed<EMAIL_ADDRESS>

Updated PR with additional perceived syntax errors in error handling

I'm also getting this error, hope this can be merged soon!

Sorry about the delay here, this lgtm, merging and will do a release soon.

@Apexal @andrewrfreed released: https://pypi.org/project/flask-oidc-ext/1.4.3/

Thanks @svintit for the merge and release!


Release Camunda Modeler v1.15.0

[ ] make sure dependencies are released (rm -rf node_modules && npm i && npm run all works)

bpmn-js, dmn-js, cmmn-js, *-properties-panel, *-moddle, ...

[ ] smoke test to verify all diagrams can be created
[ ] update CHANGELOG before releasing
[ ] semantic release (npm run release)
[ ] wait for CI infrastructure to build the release
[ ] execute integration test on released artifacts

[x] Works on Linux
[ ] Works on Mac
[ ] Works on Windows

[ ] write blog post on blog.camunda.org
[ ] create pull request updating download version of Camunda Modeler at camunda.com
[ ] spread the word

[ ] @alle to trigger customer mail
[ ] tweet

Release blog post on branch.


PLT-8019: Improve Home page

@coderabbitai: ignore

Maybe, like your earlier commit, but below (without the code coverage count as that is not available in the /runs api now)

Agreed with Anusree. I have some ideas for improvements but I'll move them to a future sprint as it is outside of the current scope of the ticket.


[tests] Create .travis.yml to enable continuous integration

Adds Travis CI to run tests for Ubuntu 14.04 LTS Linux architecture. This requires configuring this project on the Apple Travis CI account: https://travis-ci.org/apple
A build status image has been added to the README.md. Example using this branch:

:+1: Great

It's cool.

Thank you, but we are working on setting up continuous integration for the whole swift.org project.  It is coming soon.

Alright. swift-corelibs-foundation builds are currently failing due to lack of CI: https://github.com/apple/swift-corelibs-foundation/commit/972863924a978c993eee0bb44e3fd743a196af35#commitcomment-14812834. I hope this is fixed really soon.


⚠ mstdn.jp has degraded performance

In 031e9e3, mstdn.jp (https://mstdn.jp/health) experienced degraded performance:

HTTP code: 0
Response time: 0 ms

Resolved: mstdn.jp performance has improved in b4d1755 after 2 hours, 4 minutes.


Add release notes for WithFieldName interface

Description
Release notes for https://github.com/opensearch-project/OpenSearch/pull/15765
Related Issues
Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta - I don't think we need the backport labels since the CHANGELOG will be cleared for main and 2.x branches!

@reta - I don't think we need the backport labels since the CHANGELOG will be cleared for main and 2.x branches!

@jainankitk someone has to clear the CHANGELOG manually :(


Media limits API

Documentation: https://docs.google.com/document/d/1fI4ZqQcyAyBEPMtS1MCZWpN84kEPdm9SDw6SVZsJvYY/edit
Author: @Half-Shot
Date: 04/05/2018
PRs: #1189

(This has been ready for a while now, can it get reviewed?)

@Half-Shot who do you think should be reviewing it - can you include them in the thread?

Anyone from the Riot side would be fine, I'll pick @lukebarnard1 :grin:

Luke, will you be able to help with this?

RIGHT - we've picked this up as part of a clear the MSC backlog mission; sorry for the delay.
Having spoken it through, there are some conclusions on the 'Shortcomings' section, and with these now incorporated, it lgtm.  @dbkr, @turt2live (and anyone else) can you give an upvote for an lgtm?


Bring the chain executable spec in sync with the current chain spec

As the chain spec and its executable counterpart were developed in parallel, the latter does not match the former. We should modify the executable spec to match its latex version.
Also we need to make sure the comments in this PR are properly addressed.

This is an old one, and @mdimjasevic is working on synchronizing the two specs anyway. So I'm closing this one.


fix icon performance

currently icon rendering is in CPU and is done every time the scripts are run so for lists the number of icons increases the lagginess of the scrollable widget and creates huge CPU utilisation for nothing. find a solution for this - best path seems to be to change theme to cache two themes and flip between them, icon function creation function prerenders in both theme colors and the render just uses the cache.

icons now operate a cache based on using the icon source data pointer as an index, they only render once during a session
incidentally fixed startup/shutdown issues, on windows dangling processes due to using /C - all removed now working perfectly too.


Fix Amazon-specific provider_tag_mapping_spec

Due to a change in ManageIQ/manageiq-providers-amazon#684, flavors are
now in the list of objects in the inventory collection. This code
however had hardcoded indexes into the collections list, which broke
because of that addition. Instead, this changes the lookup to find the
correct object type making it more resilient to changes.
@jrafanie @agrare Please review.  This fixes the broken master from ManageIQ/manageiq-providers-amazon#684

Moving forward this test should probably live in the amazon provider, but I'd like to merge this anyway to get master back to green.


Add data volume in connection details

Task/Issue URL: https://app.asana.com/0/0/1206581639382040/f
Description
See attached task descriptionn
Steps to test this PR
https://app.asana.com/0/0/1206643439001998/f

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

develop

#4184

#4195

#4196   👈

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karlenDimla and the rest of your teammates on  Graphite


QuickPick no longer sets activeItems to an empty array when no items are visible

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.88.0-insider
OS Version: MacOs

Steps to Reproduce:
In the python and python debugger extension we use the QuickPick, we add an option to accept the value in the input. It was working in stable, but in insiders it doesn't work.
Steps:

Open a picker
Write some text in the input box, make sure that it match with one option at first.
Click enter, to select the text in the input box.
The last value that appeared in the list is the one that is selected.

https://github.com/microsoft/vscode/assets/17892325/1e227ee4-87a0-4869-9f62-e08f8bd00f3b
You can check the implementation here.
I was debugging the code a little bit, and found that in stable when you press enter, the function onDidAccept is called.
But in insider when you press enter instead of call that function, the function onDidChangeSelection is called.

Verification:

Install Python extension
Open a python workspace
Open the debug pane and click the "create a launch.json file"
Choose Python Debugger
Choose Django
Type ONLY 'b' and notice that "Browse Files" becomes the active item
Type then, 'z' and notice that the list is empty
hit ENTER and notice that the launch.json gets created with "bz" in the "program": "bz"

The fix fully resolves https://github.com/microsoft/vscode-python-debugger/issues/287 as well!

Resolves my issue as well.


Feature/ga docker

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (b36d909) to head (a2ec641).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           21        21
  Lines          368       368
  Branches        48        48
=========================================
  Hits           368       368

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Comment out unused code, add test scripts and increase code coverage

Codecov Report

Merging #122 (08bfb48) into master (efdc4a0) will increase coverage by 0.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   75.66%   76.16%   +0.49%
==========================================
  Files         117      117
  Lines       33584    33482     -102
==========================================
+ Hits        25413    25502      +89
+ Misses       8171     7980     -191

Impacted Files
Coverage Δ

dynadjust/include/memory/dnafile_mapping.cpp
89.65% <ø> (+27.75%)
:arrow_up:

dynadjust/include/memory/dnafile_mapping.hpp
100.00% <ø> (+14.28%)
:arrow_up:

dynadjust/include/parameters/dnadatum.cpp
96.49% <ø> (+20.10%)
:arrow_up:

dynadjust/include/parameters/dnaprojection.cpp
100.00% <ø> (+77.96%)
:arrow_up:

dynadjust/include/parameters/dnaprojection.hpp
100.00% <ø> (+20.00%)
:arrow_up:

dynadjust/include/parameters/dnadatum.hpp
100.00% <100.00%> (+18.18%)
:arrow_up:

...st/dynadjust/dnaimportwrapper/dnaimportwrapper.hpp
55.55% <0.00%> (-2.78%)
:arrow_down:

dynadjust/include/io/dnaiosnxwrite.cpp
98.99% <0.00%> (-0.01%)
:arrow_down:

dynadjust/dynadjust/dnaadjust/dnaadjust.cpp
86.86% <0.00%> (+0.01%)
:arrow_up:

...t/dynadjust/dnaadjustwrapper/dnaadjustprogress.cpp
61.32% <0.00%> (+3.86%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdc4a0...08bfb48. Read the comment docs.


migrate to modern logger implementation

perform one more attempt to jump onto any modern logger (log4j2x or logback).
Seems like the only blocker is ThreadLogAppender as of now

done: https://github.com/zebrunner/carina/pull/1582
also adjusted carina-demo: https://github.com/zebrunner/carina-demo/pull/207
and carina archetype accordingly...
to test run regular regressions from carina-demo (branch: master) and inspect test logs carefully...

Created a separate issue https://github.com/zebrunner/reporting/issues/2338


Plugin with id 'com.android.library' not found.

First I'd like to thank you for all your hard work. I really love your project and without it the Psono app would not be possible!
Now to the problem. I have recently upgraded gradle and so on yet now I receive this error:
FAILURE: Build failed with an exception.

* Where:
Build file '/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_sodium-0.1.9/android/build.gradle' line: 1

* What went wrong:
A problem occurred evaluating root project 'flutter_sodium'.
> Plugin with id 'com.android.library' not found.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 9s

The plugin flutter_sodium could not be built due to the issue above.

Googling it brought be to this stackoverflow article.
https://stackoverflow.com/questions/33508777/gradle-error-in-android-studio-plugin-with-id-com-android-library-not-found/33513015
Which blames this line here https://github.com/firstfloorsoftware/flutter_sodium/blob/master/android/build.gradle#L1
I downgraded again to com.android.tools.build:gradle:3.6.4 and things are working again.

Thanks for reporting this issue. What version of Gradle did you install which caused the issue?

I tried with com.android.tools.build:gradle:4.0.1 and com.android.tools.build:gradle:4.0.2
You can check out the full source code here btw https://gitlab.com/psono/psono-app as its open source ;)

Seems to work on my machine. Here's what I did:

Clone the psono-app source (app looks awesome btw!)
Update android/build.grade and modified line 9 as follows classpath 'com.android.tools.build:gradle:4.0.2'
flutter clean, build and run in Android simulator, all good apart from a couple of Android deprecated API warnings

I'm using Flutter 1.22.4 (latest stable) on MacOS
Am I missing something?

I was missing a crucial point. Try a flutter build apk

That makes sense, and interestingly enough it works fine as well. I did run into another issue (Transform's input file does not exist) which was resolved using this workaround -> https://github.com/flutter/flutter/issues/58247#issuecomment-636500680
So first I did a flutter build apk --profile:
flutter build apk --profile
Signing with debug keys
Note: /Users/xx/Source/flutter/.pub-cache/hosted/pub.dartlang.org/device_info-0.4.1+4/android/src/main/java/io/flutter/plugins/deviceinfo/DeviceInfoPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/xx/Source/flutter/.pub-cache/hosted/pub.dartlang.org/in_app_purchase-0.2.2+4/android/src/main/java/io/flutter/plugins/inapppurchase/InAppPurchasePlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/xx/Source/flutter/.pub-cache/hosted/pub.dartlang.org/in_app_purchase-0.2.2+4/android/src/main/java/io/flutter/plugins/inapppurchase/MethodCallHandlerImpl.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/xx/Source/flutter/.pub-cache/hosted/pub.dartlang.org/package_info-0.4.0+13/android/src/main/java/io/flutter/plugins/packageinfo/PackageInfoPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Running Gradle task 'assembleProfile'...
Running Gradle task 'assembleProfile'... Done                      47.6s
✓ Built build/app/outputs/flutter-apk/app-profile.apk (33.5MB).

If you are deploying the app to the Play Store, it's recommended to use app bundles or split the APK to reduce the APK size.
    To generate an app bundle, run:
        flutter build appbundle --target-platform android-arm,android-arm64,android-x64
        Learn more on: https://developer.android.com/guide/app-bundle
    To split the APKs per ABI, run:
        flutter build apk --target-platform android-arm,android-arm64,android-x64 --split-per-abi
        Learn more on:  https://developer.android.com/studio/build/configure-apk-splits#configure-abi-split
Signing with debug keys
WARNING: [Processor] Library '/Users/xx/.gradle/caches/modules-2/files-2.1/org.robolectric/shadows-framework/4.3/150103d5732c432906f6130b734e7452855dd67b/shadows-framework-4.3.jar' contains references to both AndroidX and old support library. This seems like the library is partially migrated. Jetifier will try to rewrite the library anyway.
 Example of androidX reference: 'androidx/test/runner/lifecycle/Stage'
 Example of support library reference: 'android/support/annotation/NonNull'
Running Gradle task 'assembleRelease'...
Running Gradle task 'assembleRelease'... Done                      43.8s
✓ Built build/app/outputs/flutter-apk/app-release.apk (22.6MB).

Try
git clone git@gitlab.com:psono/psono-app.git
adjust the grade version

docker run -v `pwd`/psono-app:/psono-app -it psono-docker.jfrog.io/openjdk:8-jdk /bin/bash
cd /psono-app
export ANDROID_COMPILE_SDK="29"
export ANDROID_BUILD_TOOLS="29.0.2"
export ANDROID_SDK_TOOLS="4333796"
export FLUTTER_VERSION="https://storage.googleapis.com/flutter_infra/releases/stable/linux/flutter_linux_1.22.4-stable.tar.xz"
apt-get --quiet update --yes
apt-get --quiet install --yes wget tar unzip lib32stdc++6 lib32z1
wget --quiet --output-document=android-sdk.zip https://dl.google.com/android/repository/sdk-tools-linux-${ANDROID_SDK_TOOLS}.zip
unzip -d android-sdk-linux android-sdk.zip
echo y | android-sdk-linux/tools/bin/sdkmanager "platforms;android-${ANDROID_COMPILE_SDK}" >/dev/null
echo y | android-sdk-linux/tools/bin/sdkmanager "platform-tools" >/dev/null
echo y | android-sdk-linux/tools/bin/sdkmanager "build-tools;${ANDROID_BUILD_TOOLS}" >/dev/null
export ANDROID_HOME=$PWD/android-sdk-linux
export PATH=$PATH:$PWD/android-sdk-linux/platform-tools/
yes | android-sdk-linux/tools/bin/sdkmanager --licenses
wget --quiet --output-document=flutter-sdk.tar.xz $FLUTTER_VERSION
tar -xf flutter-sdk.tar.xz
export PATH=$PATH:$PWD/flutter/bin
echo flutter.sdk=$PWD/flutter > android/local.properties
flutter build apk

Still works. Installed docker, followed all the steps, it takes forever to compile, but eventually it succeeds. The only extra step I took before I could execute flutter build apk was to run flutter pub get. Running flutter build without caused compilation errors.
Proof:
flutter build apk
You are building a fat APK that includes binaries for android-arm,
android-arm64, android-x64.
If you are deploying the app to the Play Store, it's recommended to use app
bundles or split the APK to reduce the APK size.
    To generate an app bundle, run:
        flutter build appbundle --target-platform
        android-arm,android-arm64,android-x64
        Learn more on: https://developer.android.com/guide/app-bundle
    To split the APKs per ABI, run:
        flutter build apk --target-platform
        android-arm,android-arm64,android-x64 --split-per-abi
        Learn more on:
        https://developer.android.com/studio/build/configure-apk-splits#configur
        e-abi-split
Signing with debug keys
Note: /psono-app/flutter/.pub-cache/hosted/pub.dartlang.org/device_info-0.4.1+4/android/src/main/java/io/flutter/plugins/deviceinfo/DeviceInfoPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /psono-app/flutter/.pub-cache/hosted/pub.dartlang.org/in_app_purchase-0.2.2+4/android/src/main/java/io/flutter/plugins/inapppurchase/InAppPurchasePlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /psono-app/flutter/.pub-cache/hosted/pub.dartlang.org/in_app_purchase-0.2.2+4/android/src/main/java/io/flutter/plugins/inapppurchase/MethodCallHandlerImpl.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /psono-app/flutter/.pub-cache/hosted/pub.dartlang.org/package_info-0.4.0+13/android/src/main/java/io/flutter/plugins/packageinfo/PackageInfoPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Running Gradle task 'assembleRelease'...
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.                            WARNING: [Processor] Library '/root/.gradle/caches/modules-2/files-2.1/io.flutter/flutter_embedding_debug/1.0.0-2c956a31c0a3d350827aee6c56bb63337c5b4e6e/d766fe2feb740ead017d002eae7d82dd4f337a93/flutter_embedding_debug-1.0.0-2c956a31c0a3d350827aee6c56bb63337c5b4e6e.jar' contains references to both AndroidX and old support library. This seems like the library is partially migrated. Jetifier will try to rewrite the library anyway.
 Example of androidX reference: 'androidx/annotation/NonNull'
 Example of support library reference: 'android/support/annotation/NonNull'
WARNING: [Processor] Library '/root/.gradle/caches/modules-2/files-2.1/io.flutter/flutter_embedding_profile/1.0.0-2c956a31c0a3d350827aee6c56bb63337c5b4e6e/83d8a0724d36e78214f1a7f4004a97b524f3202b/flutter_embedding_profile-1.0.0-2c956a31c0a3d350827aee6c56bb63337c5b4e6e.jar' contains references to both AndroidX and old support library. This seems like the library is partially migrated. Jetifier will try to rewrite the library anyway.
 Example of androidX reference: 'androidx/annotation/NonNull'
 Example of support library reference: 'android/support/annotation/NonNull'
WARNING: [Processor] Library '/root/.gradle/caches/modules-2/files-2.1/org.robolectric/shadows-framework/4.3/150103d5732c432906f6130b734e7452855dd67b/shadows-framework-4.3.jar' contains references to both AndroidX and old support library. This seems like the library is partially migrated. Jetifier will try to rewrite the library anyway.
 Example of androidX reference: 'androidx/test/runner/lifecycle/Stage'
 Example of support library reference: 'android/support/annotation/NonNull'
Running Gradle task 'assembleRelease'...
Running Gradle task 'assembleRelease'... Done                     332.5s (!)
✓ Built build/app/outputs/flutter-apk/app-release.apk (22.7MB).

I'm closing this issue due to inactivity.


404 on Train/Test Dataset download links

Thank you for the excellent work Tassano & fellow authors.
Unfortunately, the link to download train/test datasets are producing a 404 on dropbox. https://www.dropbox.com/sh/m9mpz1m1b55x420/AAAt1wes43brv37BmBxw07jna?dl=0
Could you kindly let us know where we can download the .mp4 files
Thanks
Daran

Hi not to worry. I found your conversion code and converted them with the necessary settings. Thank you for providing the script.

Hi Daran,
I just updated the link anyway if you still need it.
Best,
Matias


figcaption

There's something always bothers me all over the web: the figcaption has no difference from the body text.
I strongly believe the figcaption should have at least the same font-size of small.
What do you think?

Which styles would you suggest?

Hi, @jonathantneal . Please, forgive my late answer. I lost this github notification.
The wikipedia uses:
    line-height: 1.4em;
    padding: 3px;
    font-size: 94%;

The The Chicago Manual of Style says:

Captions should be capitalized in sentence style (see 8.156), but formal titles of works included in captions should be capitalized in headline style (see 3.22).

But I think a smaller font size is enough.
figcaption {
    font-size: 80%; /* The same as used by `small` */
    line-height: inherit;
}

figcaption p,
figcaption small {
    font-size: 1em;
    margin: 0;
}

I usually use font-size: 81.25%;.
Thank you for your attention, @jonathantneal !

I like this suggestion. I really appreciate that you did your research and can show examples of how it is used. I am in favor of adding this. I am confused by figcaption p; would p have changed the font size?

Hi, @jonathantneal .
Thank you for your attention. I also like the idea of an italic font, but I guess it's too much a personal preference.
I added p because of it's margins. You're right. They should be two rules:
figcaption p {
  margin: 0;
}
figcaption small {
  font-size: 1em;
}

I think we should pass on this, only because sanitize changes tend to “reset” styling more than create new styling.


Use one column for urls

This means that a project can have more than one production or staging site, as with some of the Wordpress projects we have. Once this is merged, I can remove the existing "Production URL" and "Staging URL" columns from Airtable.

 Merge production/staging URLs in AirTable into a single "URLs" column


Make auth server oauth 2.0 compliant

access tokens should have an expiry
refresh token should be implemented.
remove passport.js local login strategy.

done in https://github.com/Tbaut/hasura-auth/pull/9


Critical images beacon JS is injected in a place where it doesn't end up running

"
After enabling pagespeed I noticed a weired isssue with a IP Board Installation.

When using the quote button, apart from the quote I alsso get this text:

"

Out of curiosity, what tags (if any) occur after the script on your page?  It
looks like we're injecting the script in the wrong place and that's what's
causing the trouble, and I'd like to diagnose why this might be.

That's what I see in the inspector... do you want me to expand the div or is
that enough?

    <!DOCTYPE html>

               <--- This is the script in question

            <input id="hte_editor_52fd475215632" type="text" style="position: absolute; left: -1000px; display: none;" undefined="position:absolute;left:-1000px;display:none;"></input>

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 18 Feb 2014 at 4:33

I ran into the same issue. Setting 'ModPagespeedCriticalImagesBeaconEnabled false' did the trick for me.

Do you have a page or URL that demonstrates the problem? That would help a lot in tracking down the issue.

@jlporter http://www.babyimage4d.sbi1b.sitesell.com/ . You'll notice the JS code appearing for few seconds before the slider at the top right corner is rendered.
Do you think turning ModPagespeedCriticalImagesBeaconEnabled off will have any adverse effect? Documentation says "If you disable image beacons but enable filters that use them, the filters will work but not as well as when beacons are enabled.". But its not so clear what the implications are. Would you know?

Thanks for the test case, that's very helpful and I see what the problem is. The critical image beacon JS gets injected immediately before the first image on the page. On your page, the first image is in the slideshow div. There is a bit of JS that runs on your site to cycle through the various images by setting display: block on each image in the slideshow in succession. This slideshow JS is also applying display: block to the JS snippet, which is causing it to be displayed. Is it possible for you to update your JS to ignore the script tag being injected into the slideshow?
To your other question, the main benefit of the critical images beacon is in improving the behavior of the lazyload images filter. When beaconing is enabled, the above the fold images will not be lazy loaded, improving the perceived loading time of the page. It can be a nice win, but like so many of these things, depends a lot on the specific properties and layout of your page. You can read a bit more about it here.

One other benefit of the image beaconing I neglected to mention is that it can improve the behavior of [inline_preview_images](https://developers.google.com/speed/pagespeed/module/filter-inline-preview-images_ and inline_images. When beaconing is used with these images, only the above-the-fold images will be inlined. This allows the images at the top of the page to be displayed quickly, while keeping the images at the bottom of the page outlined to prevent bloating up the size of the HTML.

@jlporter Thanks for looking into this issue. I see what's going on. That's a client site and I don't have direct access to edit the source.
I'm rolling out Pagespeed to few thousand client sites, so I'll need to figure out a more generic solution. I'm sure at least few of them will have some sort of similar slider plugin. Right now I'm rolling out with ModPagespeedCriticalImagesBeaconEnabled turned off. Would be great if we could find a generic solution.

Fixed by c6f01f2


Add some kind of notification in case of build fails

In order to not having to check each day if the JMC build for failure, it would be great to have the build emitting an failure either via email or Slack.

Hello @reinhapa ,
i believe to achieve automated failure notifications via email or Slack for the JMC build in the adoptium/jmc-build, GitHub Actions (which already supports notifications and integrations with both email and Slack) can be used.
I would like to be assigned so that i may try and solve the issue.
Thanks!

@reinhapa  I just submitted a PR in regards to this issue, Please have a review.
Thanks!


Fix how requests are rewritten for sending to the proxy

In the case a request is re-sent through the pipeline, we need to only set the extra headers once. Previously we were neglecting the required modification of the request to actually redirect it to the proxy.

API change check
API changes are not detected in this pull request.


compiler: fix RegexSet bug

When compiling a RegexSet, it was possible for the jump locations to
become incorrect if the last regex in the set had a starting location
that didn't correspond to the beginning of its program. This can happen
in simple cases like when your set consists of the regexes a and β.
In particular, the program for β is:
0: Bytes(\xB2) (goto 2)
1: Bytes(\xCE) (goto 0)
2: MATCH

Where the entry point is 1 instead of 0. To fix this, we compile a
set of regexes similarly to how we compile a|β, where we handle the
holes produced by sub-expressions correctly.
Fixes #353

:pushpin: Commit cd8f6eb has been approved by BurntSushi

@bors r+

:hourglass: Testing commit cd8f6eb with merge 8a1b2bb...

:sunny: Test successful - status-appveyor, status-travis
Approved by: BurntSushi
Pushing 8a1b2bba721ddfadfb1eadc73bb6140696d8d238 to master...


3.x

Lets start this up!
Todo:

[x] Fix issues where {primaryKey} isn't a valid replacement (like on entity creation).
[x] Ensure phpcs passes
[x] Create a separate, companion plugin/behavior(?) that just does file upload validation. Standalone, use it or don't. Nope, deal with it yourself.
[x] Potentially re-add thumbnailSizes. Honestly, I might just chuck this and show in the docs how to create thumbnails of various sizes. Nope, use a custom transformer and a library.
[x] Test shells
[x] Ensure polymorphic behavior works
[x] Add some goddamn tests and write some docs.

Bam 100% unit test coverage. Now to add docs and test polymorphic behavior.

@ADmad mind updating all the docs for the new version?

Okay, this is going to be master meow.


add strong typing to setState function

Strong Typing for TypeScript
#6
setState accepts either an object or a function to successfully execute. This PR will provide strong typing and type safety by changing state: any to state: Partial<T> | stateFunc<T>
The Object (Partial<T>)
Users need the ability to send only portions of T. To do so, we can leverage Partial<T>  which makes all  properties on T optional. Since the observable store uses Object.assign, there are no logic changes that need to occur. Existing code will work "as-is" as long as you have the correct properties in place 😄 .
The Function (stateFunc<T>)
Users also need the ability to send in an function that will perform an update on the state model, such as a capitalize, sort, etc.  Since the user needs to know what that function should look like, a new type was created named stateFunc:
export type stateFunc<T> = (state: T) => Partial<T>;`

Existing code will work "as-is", provided the function accepts a state and returns T or Partial<T>
Bonus
There is an example of a function in the angular-store sample which returns only a portion of the State model. This works because the function returns Partial<T>
Tests:
An additional test was added to verify that a function which returns only a portion of a model will work.
should execute an anonymous function on a slice of data

[:heavy_check_mark:]  manual test angular-simple-store
[:heavy_check_mark:]  manual test angular-store
[:heavy_check_mark:]  manual test react-store

Before/After JS comparisons.
A before and after comparison in the TypeScript Playground shows no additional JS is generated.
before / after
Additional Readings:

<EMAIL_ADDRESS>https://fettblog.eu/typescript-built-in-generics/#partial
https://mariusschulz.com/blog/typing-functions-in-typescript
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-1.html#mapped-typescript

Thanks for going above and beyond and putting in the extra effort to the show the before/after generated code. Very helpful there. Really appreciate the new code!


Not able to publish components of size > 500MB

I am not able to publish a component (which is of size 570 MB) to AWS s3 bucket from local computer (Mac OS X Sierra).
I often see the below error when it fails,
An error happened when publishing the component: Error: socket hang up
I tried to publish the component in below manner,

node index.js bucket= region= key= secret=
oc registry add http://localhost:3000
oc publish
Output:
Packaging -> goes fine
Compressing -> goes fine
Publishing -> component url
An error happened when publishing the component: Error: socket hang up
any workaround for this ??

Hi @NapoleanReigns I never tried to publish a big component like that, but it should work. The file limits are exposed here: https://github.com/opentable/oc/blob/master/src/registry/middleware/file-uploads.js#L14 - I can try testing locally and see how it goes.
Out of curiosity, have you tried publishing other components with success?

yes i am able to publish other (smaller in size) components successfully.

Trying to reproduce locally, I managed to get this error during the upload of the huge file:
{ TimeoutError: Connection timed out after 10000ms
    at ClientRequest.<anonymous> (/Users/mfigus/Documents/gh/opentable/oc/node_modules/aws-sdk/lib/http/node.js:83:34)
    at ClientRequest.g (events.js:291:16)
    at emitNone (events.js:86:13)
    at ClientRequest.emit (events.js:185:7)
    at TLSSocket.emitTimeout (_http_client.js:629:10)
    at TLSSocket.g (events.js:291:16)
    at emitNone (events.js:86:13)
    at TLSSocket.emit (events.js:185:7)
    at TLSSocket.Socket._onTimeout (net.js:342:8)
    at ontimeout (timers.js:380:14)
  message: 'Connection timed out after 10000ms',
  code: 'NetworkingError',
  time: 2017-06-11T12:06:34.230Z,
  region: 'eu-west-1',
  hostname: 'oc-registry.s3-eu-west-1.amazonaws.com',
  retryable: true }

In my case, I have a big video. So, this is the first thing I'll try to handle.

I got a PR opened for fixing various things.
After that being merged

the options.s3.timeout needs to be amplified for large uploads. Default is 10s, for large files uploads possibly I recommend customising to 2m
A new setting options.timeout added for the server to accept long connections to stay opened. Current default to 2m can be possibly augmented to 10m.

With server timeout set to 10m (so that we don't have express hanging with a ECONNRESET) and s3 timeout set to 2m (uploads happen in chunks after this PR so this may be even not strictly necessary) I managed to upload ~300MB components without problems (takes a couple of mins but all seems to work).

@matteofigus so you think we should be able to publish components that big? I am not sure if this is the right approach.

@mattiaerre I think I prefer the user to have his own opinions. More specifically, the framework can have opinions in terms of defaults (10s for AWS reqs, and 2m for responses timeout seems like in line with having small and optimises resources in your components), but I like the idea of the contributor being able to change this settings to satisfy different business needs.
Also, 2 more things to keep in mind:

The PR changes the AWS upload modality to be chunked, which is something more robust for relatively small files too (5-10MB videos/images are possibly very common in a legitimately small component too)
The possibility to hack on connection timeouts are possibly independent from the file dimension. When uploading from countries where connections are very slow or unstable, the same problem can apply to relatively small components too, and having the possibility to change this timeouts is a good feature to add

In conclusion, my main goal with #516 is to make some good optimisations that became visible after investigating the issue. If in parallel, I can also solve this, I am happy :)

I understand your point of view but my concern is that we should always pick up the right tool for the right job and to me hosting big assets inside component is not the right approach. As we will end up with huge components at every publish. Very good w/ the side effects w/ this PR btw this is really cool 😎

Hey guys just to give you some more info,

Yeah, 2m total for multiple s3 uploads could be not enough and making it configurable could be  a quick win

@NapoleanReigns I just published 0.37.10 which possibly should allow you to complete the upload for you (after changing the default settings as explained in my previous comment). I would recommend s3.timeout => 120000 (2m) and registry timeout 600000 (10m).
Can you try and let me know?
Thanks


add --labels flags to install/upgrade commands

Fixes #7007
I also needed functionality described in #7007 , so took the stab at implementing it. Labels added here can also be used to filter releases while listing using the functionality introduced in #8532
If applicable:

[x] this PR contains documentation
[ ] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

ah, sorry I missed #8099 which is doing same thing ... so I am closing this PR .

@himanshug is it possible to revive this PR? would be super awesome to see it merged and released with 3.6

@strekm this is addressed in #8099 and since that PR existed already, I closed this one.


Add support to fetch  user settings

References
Add any related links that will help us understand the resource, including vendor documentation, related GitHub issues, and Go SDK documentation.
Requirement CIS 2.0.0 > 1.3 Ensure that 'Users can create Azure AD Tenants' is set to 'No'

As per CIS 2.0.0 > 1.3

Please note that at this point of time, there is no Azure CLI or other API commands
available to programmatically conduct security assessment for this recommendation.


use webpack-node-externals to exclude node modules

Use webpack-node-modules to extract node modules from server bundling.
Closes #104

Thanks @liady. This looks great!

@RickWong thanks! removed the caret

Hey, any news on this?


refactor(core): reduce amount of observables

Best way to do this is probably to create single changes behavior subject into the control which gets "events" that have name and value. These event can then be filtered to match what ever.


UI code generation issue with Client Certificate authentication option

Documentation in this page suggest pfx property as following line,
"pfx": "aGVsbG8g...d29ybGQ=",
Which is correct. But when user is pasting their base64 encoded pfx into the pfx field then Connector UI generates pfx property as below.
"pfx": "@{base64('aGVsbG8g...d29ybGQ=')}",
After execution connector throw an error as "Bad Request. Could not load the certificate private key. Please check the authentication certificate password is correct and try again".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4a0dd3aa-82c2-4510-1413-a109eddf6303
Version Independent ID: 21f0f699-9267-821f-07aa-998f7dfc32f2
Content: Trigger and action types reference - Azure Logic Apps
Content Source: articles/logic-apps/logic-apps-workflow-actions-triggers.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

Hi @cihanduruer Thank you for your feedback! We will review and update as appropriate.

@cihanduruer Can you try removing @{base64('')} from the code view and mention only pfx string as shown below and check if it is working?
"HTTP": {
                "inputs": {
                    "authentication": {
                        "password": "<SomePassword>",
                        "pfx": "MIIPAAIBAzCCDrwGCSqGSIb3DQEHAa................anDpATzqKHO9hCGerKAgIH0A==",
                        "type": "ClientCertificate"
                    },
                    "method": "GET",
                    "uri": "<https://contoso.com>"
                },

Thank you for your answer all. @Ketan. it just works if i do manual changes. Looks like UI just generate wrong code.
By the way problem is also persist in MS Flow and unfortunately you cannot access to JSON in MS Flow. Do you have any other ideas ?

@cihanduruer I am not sure about the MS Flow. But in Logic App you can change by updating the json as mentioned in last post. I have provided the feedback to the product group and they confirmed that this is expected that the designer adds the base64 encoding since we don’t know if the string is already encoded or not and the expected format is base64 encoded. So the only option is to use code view or input the not encoded value.

@cihanduruer we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Appsody Liberty stacks should be based on UBI SFJ images

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Actual behaviour
What is the actual behaviour.
Environment Details (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

If applicable please specify:

CLI version:
Stack you are using:

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

@gcharters @Emily-Jiang I would like to get your thoughts on this.
Appsody would like to host stacks based on images that people are using today. This reduces the barrier for entry and helps with adoption.
Kabanero project consumes Appsody stacks and adds UBI images for their users.

@arthurdm any comments on this?

hi @irobins - I definitely agree with using UBI-min instead of Ubuntu, and back in July I had made a PR (https://github.com/appsody/stacks/pull/90) with this exact change.
@neeraj-laad - is the issue main with IBM Small Footprint Java?     We are about to launch a new OL image which would have UBI-min + AdoptOpenJDK + OL, thus keeping everything open source.  Would that be a better fit?
UBI and UBI-min can be used by anyone, so in the cases we have those available I think we should use even in Appsody - it reduces the amount of changes a customer goes through when moving from Appsody into Kabanero.

Having the Appsody stack based on a ubi image would be helpful from the Kabanero collection perspective as it would allow us to use the base Docker files without the need to modify them.
Currently we build a stack on the ubi8 base because we didn't have an image available with stack elements matching the base, sounds like this new image will solve that problem.

I'm not convinced we want ubi images as the default within Appsody. As @neeraj-laad has said, we are looking to use technologies as close to folks' current technology stack - which at this stage will be ubuntu not ubi. This is currently a major -1 from me.

hey guys, sorry for being away from the conversation for so long - this had dropped off my radar.
I think with the recent efforts to bring appsody stack and kabanero collections together we should revisit the decision to not use UBI images.
For Liberty, most customers will go into product using one of our new UBI 8-based images, so it would be consistent with best practices to use the same image for both dev and prod scenarios.
The UBI 8 standard image is viewed as more enterprise-ready and secured as compared to Ubuntu.    Customers can continue to use their RHEL satellites, and know that even their dev images would pass Red Hat certification.
Updating the Open Liberty stack would be as easy as changing this line to be:
FROM openliberty/open-liberty:kernel-java8-openj9-ubi

Assigned to @uberskigeek .... Can you please look at, from an appsody perspective, is there a "Go template" to easily switch the base image?    If so, then a Champ who wanted to build off Ubuntu e.g. would only need to modify this one property.   (If not it might be worth an issue against the appsody CLI since this would seem useful).  Thanks.

Planning on marking this resolved with the pending #650 PR.
A couple clarifications:

We are only making this change for the java-openliberty stack.   If we care to revisit this decision for any other stack, including java-microprofile, we can do that in a separate issue.
We are not going to use an SFJ image, but a more feature-rich UBI image, in fact the one suggested by arthurdm:

FROM openliberty/open-liberty:kernel-java8-openj9-ubi


move some test code into beforeEach Hook

[test/limits.js] move some code into beforeEach hook

Thanks @ZWkang !


add subgraph feature of a Graph

This adds a subgraph field to a Graph. It is useful for defining and then selecting sections of the graph based on the provided output node. This will be used in NVTabular for selecting subsets of a Workflow that transforms User and Item features.

this is spectacular! @nv-alaiacano

I added one additional piece of logic, which is to ensure that the subgraph is part of the "main" graph. You can see from the test that this is a little weird.
def test_subgraph_with_unrelated_subgraph():
    sg1 = ["a", "b"] >> BaseOperator()
    sg2 = ["a", "c"] >> BaseOperator()
    sg3 = ["c", "d"] >> BaseOperator()

    # same input as sg3, but not included in the combined Graph.
    unrelated = ["c", "d"] >> BaseOperator()

    combined = sg1 + sg2 + sg3

    with pytest.raises(ValueError):
        Graph(combined, subgraphs={"sub1": sg1, "unrelated": unrelated})

Even though unrelated and sg3 are the same, we don't detect that unrelated's output node is in the graph, and so this raises a ValueError. It could be rare to do something like this, but potentially confusing if someone does. What are your thoughts on it @karlhigley @jperez999 ?

rerun tests


Project does not compile -> /src/main/java/com/xebia/sikuli/KeyConversionFactory.java error: cannot find symbol

It seems this part is not working, is there a workaround or fix available?

As a Maven Project, we used the Maven M2E Plugin with Eclipse for ease of use.  Right click on the project, and select "Maven Update Project" which will add some dependencies to correct the issue.  I've had this one before.
Setup:
1.From a command line go to the source directory, navigate to the proper directory for OASIS-Maven, and execute "install.bat" or "install.sh".  The command should add the necessary dependencies from the plugins and lib directories to your .m2 directory
2.Open Eclipse and select File > Import > Existing Maven Projects > Next > Select the proper root directory (OASIS-Maven) > OK > Finish
3.Right click the new entry (OASIS-Maven) from the project explorer, go to Maven > Update Project > Click OK
4.Open up a command line and navigate to the OASIS-Maven directory
5.Run command "mvn -Pfitnesse test"

I should learn to read, tried compiling without eclipse.
With eclipse it works just fine, thanks!

Np


Image Helpers: implicit conversion from 'int' to 'float' changes value

Clang 12 (and possibly some older versions as well) report issues such as:
https://github.com/KhronosGroup/OpenCL-CTS/blob/657283799482433cc35d119ddab220dcad1f00aa/test_common/harness/imageHelpers.cpp#L2724-L2727
imageHelpers.cpp:2727:21: error: implicit conversion from 'int' to 'float' changes value from<PHONE_NUMBER> to<PHONE_NUMBER> [-Werror,-Wimplicit-const-int-float-conversion]
Another occurence:
https://github.com/KhronosGroup/OpenCL-CTS/blob/657283799482433cc35d119ddab220dcad1f00aa/test_common/harness/imageHelpers.cpp#L2893-L2896

The first one looks like we're relying on the compiler's implementation of (int)2147483648.f to saturate back to<PHONE_NUMBER>, which bypasses the purpose of the macro (ie, to provide RNE rounding, and saturation of out of range values). 32-bit integer conversions should promote to doubles for the comparisons, which would avoid the need for all the inexact magic going on in these.

Clang 10.0.4 reports this as [-Werror,-Wimplicit-int-float-conversion], bypassing the current CMakeLists.txt workaround. I'm working on a fix for the root cause

This was reported as #855. There was apparently some internal work on fixing it that was reported back in mid 2020, but there has been no update on that work since.

Sorry for the delay, I'm putting up a PR now


Remove unused dart:async imports

Since Dart 2.1, Future and Stream have been exported from dart:core

ping @ochafik


Would like to see a way installing any hook as an independent module if reasonable

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Ideally, being able to install a hook individually. However, I am aware that this has caveats and even lodash is deprecating this functionality in its next major release (v5) because using one module is fine, but the dependencies are pulled into that module w/i node_modules, thus if you use 2 or 3 of these lodash methods as separate packages it can be become more cumbersome. To quote the author:

Although they may seem more lightweight, they will usually increase the size of node_modules and webpack/rollup bundles in a project that transitively depends on multiple per method packages and/or the main lodash package. Whereas many methods in the main lodash package share code, the per method packages internally bundle copies of any code they depend on.

For example, throttle uses debounce internally. In a project using both methods from the main lodash package, throttle will import the same debounce module as any code that imports debounce directly, so only one copy of debounce will wind up in a webpack bundle.

On the other hand, if a project imports throttle from lodash.throttle, the extra copy of the debounce code internally bundled into lodash.throttle will wind up in the webpack bundle, in addition to debounce from the main lodash package or lodash.debounce.

Now I haven't looked at the library to see how its laid out or if one hook depends on another, etc.. if this is not an issue and I could see why it might not be as much of one with hooks then installing single hooks would be awesome.
However, I am also aware that modern tree-shaking bundlers such as webpack can avoid bundling code you don't use or need. So maybe the entire idea is moot. Just wanted to share thoughts.
Describe alternatives you've considered
Due to concerns above, perhaps It would be nice if I could install a subset of hooks, say by the way they are organized. This would keep the application size smaller and give me maybe just 1 or 2 hooks that i'd be likely to use in the same app.

I'd also like to see this 👍🏻  Side note: There's an existing issue open for this #1019

I'd also like to see this 👍🏻  Side note: There's an existing issue open for this #1019


[PT] Adding ptbr support

Moving on with https://github.com/allo-media/text2num/pull/52

Hey @rtxm can you take a look at this merge request?

Closes #52

@joaoalvarenga Thank you very much for your contribution.


[DOC][MINOR] Add shell interpreter docs to _navigation.html

What is this PR for?
After #1087 merged, a new docs shell.md was added. But in the docs website, still Shell interpreter link points to pleasecontribute.html. So I changed this link, applied TOC and added more descriptions.
What type of PR is it?
Documentation
Todos

[x] - Change pleasecontribute.html -> shell.html
[x] - Apply TOC(table of contents)
[x] - Add more description to shell.md

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

LGTM

@felixcheung agree.
@AhyoungRyu thanks for the integration.

@felixcheung I updated shell.md as you suggested :)
I also applied TOC(Table of Contents) to rest-credential.md which is from #1030.

LGTM


Can't delete files

We should be able to delete the files somehow, ideally from h5ai.

You also can from the ruTorrent interface. Right click on a torrent > Delete... Then you can choose to only remove the torrent from rtorrent or completely remove the files and the torrent.

I tried that but it didn't work @EpocDotFr.

Any error message?

Did anyone fix this ?

The image migrated to deluge, which enables moving and deleting the content of torrents.
if it doesn't work (it does, trust me), you could still ssh to the box and do whatever you want !


Update Repository.php

php7.1 fiexed.

Wasn't this part of #12?

Yes, you are right, I see I fixed the same thing because of the annoying warnings in my logs... :-)


chore: React spring upgrade for animation performance improvement

Description
Animations on slower machines might fall into an infinite loop, upgrading to fix it
Fixes #9545
Type of change
perf task
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=847914b

closing this in favour of https://github.com/appsmithorg/appsmith/pull/10427 as there seems to be an missing code change that is not being reflected in the build.


[TW#26743] menuconfig option CONFIG_DUPLICATE_SCAN_CACHE_SIZE

@Weijian-Espressif
Is it possible that setting CONFIG_DUPLICATE_SCAN_CACHE_SIZE with minimal possible value (10) is taking almost 50kB from heap?
I have very simple app for testing purpose (memory leak in ble scan) and without scan duplicates filter im having about 160kB free heap, with filter about 110kB.

CONFIG_DUPLICATE_SCAN_CACHE_SIZE only consume controller heap size. I print free heap size with
scan duplicate enaable and diasble, the free heap size is same.

@Weijian-Espressif I dont know, when i compile app with and without this option i see this difference and in ble library this is never used before. I will do more tests with esp-idf example to confirm. Thanks.

@chegewara What is the conmmit id ? It would be better if you could provide the test code.

@Weijian-Espressif I will do all by the book this time. esp-idf example and report all. This is commit:
221eced06daff783afde6e378f6f84a82867f758

@chegewara thanks for your help.

Looks like i had to change something else, my bad sorry.


🐛 [Bug]: CanvasRowColContainer.vue组件 拖拽后预览时报找不到标签

Environment
nodejs v18.18.0
Version
latest
Version
latest
Link to minimal reproduction
about:srcdoc:160 [Vue warn]: Failed to resolve component: canvas-col
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.
at
at
console. @ about:srcdoc:160
about:srcdoc:160 [Vue warn]: Failed to resolve component: canvas-row
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.
at
at
console. @ about:srcdoc:160
about:srcdoc:160 [Vue warn]: Failed to resolve component: canvas-row-col-container
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.
at
at
Step to reproduce
拖拽行列容器设计状态正常，预览时提示找不到canvas-row canvas-col
What is expected
No response
What is actually happening
No response
Any additional comments (optional)
No response

能不能拉下进群

已知问题，修复中，感谢反馈。
Known issue, fix in progress, thanks for the feedback.


Fix issue with command dictionary creation

Fixes https://github.com/NASA-AMMOS/aerie-ui/issues/650

Move command dictionary create logic into component
Make sure command dictionary error clears between sessions
Update create command dictionary request
Reset expansion stores when needed

Not a critique, but just a question about an observation, is there a reason for moving the toast actions out of the effects file and into the component itself?

The reason is because I moved the try-catch to the component, and the fail toast is called in the catch so it came with it. I moved the try-catch because we are only calling that create function in the dictionary component, and it is less-buggy to just catch the errors in the component and set error state accordingly (including the toast). We then only depend on local state and don't have to worry about cleaning out the store when the component get's destroyed.