enable cpu adam op on powerpc architectures

I am trying to build DeepSpeed on a PowerPC architecture (Power9).  I run into two issues.
First, the -march option is not supported in gcc on this platform, though it seems like -mcpu could be a substitute for it.  To support that, one change replaces that C++ flag.
Second, the cpuid.h and x86intrin.h headers do not exist on this system.  To work around that, I've protected including those behind an x86 compile guard.
This allows the CPU_ADAM op to build, however, I don't have a good way to verify that the resulting build is actually valid.

The asynchronous I/O op similarly has an -march=native flag in op_builder/async_io.py and includes for cpuid.h and x86intin.h in csrc/aio/py_lib/deepspeed_py_copy.h.

@adammoody, thanks so much for porting DeepSpeed to PowerPC, this is very important and greatly appreciated. In terms of validating the builds for both cpu_adam and aio, is it possible to run the unit tests? To get started you may want to initially focus on the specific unit tests for cpu_adam and aio.

@adammoody, this PR is failing CI now because of code formatting issues. Please see this. Thanks!

@adammoody, thanks so much for porting DeepSpeed to PowerPC, this is very important and greatly appreciated.

Thanks.  I'm happy to be help where I can.

In terms of validating the builds for both cpu_adam and aio, is it possible to run the unit tests? To get started you may want to initially focus on the specific unit tests for cpu_adam and aio.

Yes, I'll try to give this a shot.

Has this by chance changed something in the nvme extension build process, as our nvme test started failing to jit build after 0.4.3 release:  https://github.com/huggingface/transformers/issues/12715

update: false alarm, the problem was solved by rm -rf ~/.cache/torch_extensions/ as suggested by
@tjruwase

@tjruwase , is this the proper way to run the cpu_adam test?
>>: pytest tests/unit/test_cpu_adam.py
============================================================ test session starts =============================================================
platform linux -- Python 3.7.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /path/to/DeepSpeed
collected 6 items

tests/unit/test_cpu_adam.py ......                                                                                [100%]

============================================================= 6 passed in 11.89s =============================================================
Config: alpha=0.001000, betas=(0.900000, 0.999000), weight_decay=0.000000, adam_w=1

Yes, it is. And it looks like a 6 tests passed.
Also,  you can run verbose mode by adding -sv flags:  pytest -sv tests/unit/test_cpu_adam.py.

For the aio test, I get:
============================================================ test session starts =============================================================
platform linux -- Python 3.7.10, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /path/to/DeepSpeed
collected 28 items

tests/unit/test_aio.py ............................                                                                                [100%]

======================================================= 28 passed in 129.68s (0:02:09) =======================================================

I'm guessing both of these might be slow compared to x86, since on PowerPC, both fall back to use a non-SIMD implementation.  Can you judge performance from this?

To get aio to actually build on my Redhat system, I also had to make this change:
diff --git a/op_builder/async_io.py b/op_builder/async_io.py
index 78aa2fe..9c6dde6 100644
--- a/op_builder/async_io.py
+++ b/op_builder/async_io.py
@@ -50,7 +50,7 @@ class AsyncIOBuilder(OpBuilder):
         return ['-laio']

     def is_compatible(self):
-        aio_libraries = ['libaio-dev']
+        aio_libraries = ['libaio-dev', 'libaio-devel']
         aio_compatible = self.libraries_installed(aio_libraries)
         if not aio_compatible:
             self.warning(
diff --git a/op_builder/builder.py b/op_builder/builder.py
index 3eeb4e4..bd6bfa8 100644
--- a/op_builder/builder.py
+++ b/op_builder/builder.py
@@ -151,9 +151,8 @@ class OpBuilder(ABC):

     def libraries_installed(self, libraries):
         valid = False
-        check_cmd = 'dpkg -l'
         for lib in libraries:
-            result = subprocess.Popen(f'dpkg -l {lib}',
+            result = subprocess.Popen(f'rpm -q -l {lib}',
                                       stdout=subprocess.PIPE,
                                       stderr=subprocess.PIPE,
                                       shell=True)

That's related to the issue @stas00 opened here: https://github.com/microsoft/DeepSpeed/issues/1126854101593

I wrote most of the code to handle 3 flavors of linux here:
https://github.com/microsoft/DeepSpeed/issues/1126#issuecomment-854101593
@adammoody, if you'd like to integrate and PR it that would be super helpful!

Solution #2 sounds good to me, and such a PR would be greatly appreciated. Thanks @stas00  and @adammoody.

I'm guessing both of these might be slow compared to x86, since on PowerPC, both fall back to use a non-SIMD implementation. Can you judge performance from this?

SIMD perf is not important to aio as it is an NVMe library.

Sure, I'll work on solution #2 to get started.
However, I suspect my conda setup doesn't quite fit properly with those three package managers, since my build isn't actually using the libaio from the rpm.  Solution #4 to test a compile/link might work.  Maybe something with compiler.has_function like described on this page would work?
https://www.cac.cornell.edu/wiki/index.php?title=Python_Distutils_Tips#How_to_find_if_a_library_exists
compiler=distutils.ccompiler.new_compiler()
if compiler.has_function('timer_create',libraries=('rt',)):
  user_macros.append(('HAVE_POSIX_TIMER','1'))

I can investigate that, as well.  In my build of DeepSpeed, I'm externally setting CC, CXX, and CFLAGS to point to conda-specific items (like the include path to libaio.h) and that gets picked up in the build.

I think there should be an easy way to do this for a typical user, which is what approach 2 was trying to do and then allow anybody to do it in their own way by overriding the default checking.
The problem with solution 4 is that we can't tell the user what to do if it fails, so we still need to know what system they are on and what library to tell them to install - as you can see they are differently named on different flavors of linux.
Chances are very low that users will already have this library installed.
Also may I ask why the rpm library doesn't work for you? No sudo access to install it?

Thanks @stas00 , I'll stick with the plan to implement solution 2.
In my case, I don't have sudo access on this particular system.  The system admins have installed the libaio-devel rpm on the host system.
Having said that, in this case, I'm trying to avoid using the existing system install.  That's because I'm using a base install of IBM's OpenCE for PyTorch and other software, which uses conda.  Under this conda environment, it's best practice to only build against software installed within the same conda environment rather than using "external" system-installed packages.  I don't think this will be a common problem for others, though other OpenCE users might be interested.

Thank you for explaining your particular needs.
This is great, so as suggested earlier the solution should include the generic automatic package-manager-based approach which should cater to the majority, and the manual solution for when either the automatic version doesn't cover the yet to be supported platform and when one doesn't want to use the former and wants to provide their own (your case). So there needs to be a way to tell the builder - I'm taking over, here is all the details you need.

Hi,
I wanted to add that a minor issue still persists on PowerPC architectures, cause by the following:
https://github.com/microsoft/DeepSpeed/blob/98cc35b6a8e53e15829ce64fd8da835db0c61da9/deepspeed/ops/adam/cpu_adam.py#L78
Which results in KeyError: 'vendor_id_raw'.
I fixed it by simply replacing it with self.cpu_vensor="PowerPC". I guess the string doesn't really matter.
Should I create a new pull request?

Should I create a new pull request?

This is an excellent idea, @FarzanT


[Feature]: Improve the URL for git connected apps by removing branch=master as query parameter

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
In an effort to have cleaner URLs, we should remove the query parameter ?branch=master as the default query parameter as the default shareable URL. Only if the user is sharing the app via another branch should this query parameter be present. In the default branch, the query parameter should be omitted and be derived.
Why should this be worked on?
Having clean URLs makes sharing Appsmith URLs easier for users. Also, for deployed applications, the branch parameter doesn't make sense for the app viewer. Hence, by default, the branch query parameter should be omitted.

@abhvsn @IAmAnubhavSaini can we pick this up as sub part of [EPIC] Git performance & UX #13823
I will attach this on zenhub.

Abhijeet : This can break the apps for some users who are relying on query parameter for branch for certain actions.

This should just be tied to RBAC and devs should be able to restrict the branches that a user has access to. @riteshkew


Feature/rearch

Hey Ado, just messing around with a new backend library I've been cooking up, rearch-dotnet.  C# port of rearch-dart.  Still very much in development and slow going, but thought you'd maybe be interested in giving it a look.

Hey, yes I already had a look at your implementation, interesting approach. Even if I'm not absolutely an expert of the state management in the flutter world I still can see many advantages on using rearch especially when linked to a persistence library like ReactorData.
Keep up the good work!

Hi @adospace
If you could join forces with https://github.com/taublast/DrawnUi.Maui.Demo you could build something similar to Flutter or even better but for .NET MAUI.


feat: Argument Bag, aliases, help lines

#1 hell yeah
Adds additional functionality to the console app by creating a ConsoleArgumentBag.
The bag is a class responsible for:
a) holding all of the arguments passed to function
b) creating ConsoleInput, which is a prepared list of available arguments with values. This can throw if the count of arguments doesn't match handler's method signature
It also adds support for:

aliasing commands
aliasing arguments

I've decided to go with help as an array, I think that for more advanced CLI apps, this could be benefitial.
I think we should have description and help as two separate entities.
Help would be responsible for providing information on how different values of an argument can affect execution, whereas description just expands on the name or illustrates the use-case.

@brendt lemme know what you think!

Both my comments aren't blockers btw, just curious about your input.

Also lemme know if contributions this early are helpful for you - I love this project and would love to help as much as possible, but I don't want to come off as intrusive. So if it's counterproductive atm because of the stage lemme know - do not want to disrupt your vision.  As long as you're willing to put up with me sometimes requiring a couple of days before being able to review code, and my reviews in general, we're totally fine :)


Cannot use user-defined types with New-AzResourceGroupDeployment

Bicep version
0.21.1
Describe the bug
I use PowerShell commands to deploy Bicep files. If I try to deploy a Bicep file that has user-defined types with New-AzResourceGroupDeployment, I get an error: Error BCP007: This declaration type is not recognized. Specify a parameter, variable, resource, or output declaration.
I have updated the az.resources PowerShell module to the latest version, 6.11.1
To Reproduce
Steps to reproduce the behavior:

Create a simple bicep file with a user-defined type, for instance:

type myType = 'bicep' | 'arm' | 'azure'
param myParam myType = 'bicep'
output myOutput string = myParam

Deploy the bicep file with PowerShell:

New-AzResourceGroupDeployment -resourceGroupName 'rg-Test1' -TemplateFile .\testFile.bicep

Additional context
I note that I can deploy the exact same bicep file successfully using the corresponding cli command az deployment group create -g rg-Test1 --template-file .\testFile.bicep. This leads me to believe the PS commands simply haven't been updated yet. When will this occur? All our automation uses the PS commands, and I'd like to begin using user-defined types, since the feature is now GA.

Could you run bicep --version and make sure that the copy of the Bicep CLI on your $PATH is the correct version?
One gotcha with using both az CLI and the Az PowerShell module is that the CLI maintains its own copy of the bicep CLI, whereas the PowerShell module looks for the bicep CLI in your $PATH. Since the az CLI will prod users to update when new versions are available, the CLI version used by az bicep will frequently be out of sync with the CLI version invoked by bicep. For example, this is what I have installed locally:

(I'm an az CLI user.)

I didn't realize that PowerShell used a different copy; I thought that when I updated the PS commands it would update bicep, just like the CLI. Turns out my install of Bicep was quite old. I installed the latest and it works now. Thanks for your help!

Closing as installing the latest bicep version fixed the issue


Error module stream in ESM build

Hi!
I'm using this lib in 5.0.6 version with Vite (using the ESM build) and have an error when load the Parser:
browser-external:stream:3 Uncaught Error: Module "stream" has been externalized for browser compatibility and cannot be accessed in client code.
    at Object.get (browser-external:stream:3)
    at json2csv.esm.js:1870

I'm not using the Streaming API, only the synchronous so don't know if it's possible to disabled.
Thanks!

Maybe you can set this option in vite? https://vitejs.dev/config/#optimizedeps-exclude
Or the rollup options here https://vitejs.dev/config/#build-rollupoptions

I'm trying with this, but happend the same error
optimizeDeps: {
    exclude: ["stream"]
  },

Any disclosure for that? I'm facing the same issue.

Can you reproduce the issue and upload it as a repo for us to look at?

I found a temporary workaround using umd instead
import { parse } from 'json2csv/dist/json2csv.umd'

Using a resolve.alias configuration of { "json2csv": "json2csv/dist/json2csv.umd.js"  } works as well and does not break the TypeScript definitions.

The problem happens when packaging the library for frontend since it uses some Node libraries. Like the stream library.
In v6 this, will be changed to minimize the node-specific parts and we should reconsider how we expose the different APIs to clearly separate node APIs from standard JS APIs

I found a temporary workaround using umd instead
import { parse } from 'json2csv/dist/json2csv.umd'

works for me

Another solution could be to import directly the module that you want to use.
Something like
import parser from 'json2csv/JSON2CSVParser'

Closing since a workaround has been given.

took long enough....
v6, which has moved to a new repo and broken down into smaller packages is in esm.
Full docs here: https://juanjodiaz.github.io/json2csv/

Still same issue with vite and json2csv@v6 (latest). But the UMD workaround still works.


Create intl_es.arb

Spanish translation
What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update

Description
Featured Covered in this PR

[ ] Task 1
[ ] Task 2

Related Tickets & Documents

Related Issue #
Closes #

Screenshots, Recordings
Please replace this line with instructions on how to test your changes, or any screenshots or recording you can attach here.
Tested Feature??

[ ] In Real Device.
[ ] In Emulator

Thanks for contributing, no need to create a new folder lib, you can place this file inside l10n folder along with other intl_ files


Unable to validate ghauth

Hi @RichardLitt 👋🏼
I've used this great module in the past to programmatically manage what repos I'm watching. I just installed this module anew and got an error when trying to use it:
$ watch-gh-repos --org --watch zeke
Your GitHub username: zeke
Your GitHub password: ✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔

(node:11873) TimeoutOverflowWarning:<PHONE_NUMBER>000 does not fit into a 32-bit signed integer.
Timer duration was truncated to<PHONE_NUMBER>.
(Use `node --trace-warnings ...` to show where the warning was created)
(node:11873) TimeoutOverflowWarning:<PHONE_NUMBER>000 does not fit into a 32-bit signed integer.
Timer duration was truncated to<PHONE_NUMBER>.
Unable to validate ghauth

$ node --version
v14.13.0

I think this is because the ghauth module recently had to be changed significantly to account for a newly deprecated GitHub auth API: https://github.com/rvagg/ghauth#ghauth
I know @bcomnes and @rvagg worked to update ghauth to still work (thanks! ✨ ), and I think consumers of ghauth like this module might have to make some changes to use the new version, but I haven't looked into the details yet.

Only change you need to make is to set up a client id for watch-gh-repos if you want to support the oauth device flow (you should do this).  Any existing PAT that ghauth generated before should still work.  You can also opt to just have users manually generate and enter a PAT instead of an oauth token generated from device flow.    LMK if you run into any issues relating to ghauth.

Only change you need to make is to set up a client id for watch-gh-repos if you want to support the oauth device flow (you should do this).  Any existing PAT that ghauth generated before should still work.  You can also opt to just have users manually generate and enter a PAT instead of an oauth token generated from device flow.    LMK if you run into any issues relating to ghauth.

Thanks, @zeke and @bcomnes! @bcomnes: am I right in thinking that I need to add documentation for each user use to set up a client ID? Do you have a link to that documentation so that I can add it here?
@zeke If you're more familiar with this, a PR would be great. I don't have the bandwidth to get to this this week.

Thanks, @zeke and @bcomnes! @bcomnes: am I right in thinking that I need to add documentation for each user use to set up a client ID? Do you have a link to that documentation so that I can add it here?
@zeke If you're more familiar with this, a PR would be great. I don't have the bandwidth to get to this this week.

No, only the owner of the CLI needs to set up a client ID, and it gets baked into the CLI code (its like an app ID basically).  This can live on your user account or an org account.  You set it up in developer settings, and should be documented adequately in ghauth.  Let me know those instructions don't make sense and we can improve.

No, only the owner of the CLI needs to set up a client ID, and it gets baked into the CLI code (its like an app ID basically).  This can live on your user account or an org account.  You set it up in developer settings, and should be documented adequately in ghauth.  Let me know those instructions don't make sense and we can improve.

Ah, got it. In that case, I'll look at this in a bit. Thanks, Bret, for your work.

Ah, got it. In that case, I'll look at this in a bit. Thanks, Bret, for your work.

I tried to update by adding the clientId, and it seems to break Octokat now, and I'm not sure why. I wonder if the token is messed up? I'm not sure that it updated, and I don't see a token stored in ~/.config/ on my machine.
Here is my latest commit: https://github.com/RichardLitt/watch-gh-repos/commit/74e82ecb51cedc9328fe9bdf8b0b44c05fc0b616.
I also couldn't figure out how to turn on items 4 and 5 from this list. They weren't present in my UI. Thoughts?

I tried to update by adding the clientId, and it seems to break Octokat now, and I'm not sure why. I wonder if the token is messed up? I'm not sure that it updated, and I don't see a token stored in ~/.config/ on my machine.
Here is my latest commit: https://github.com/RichardLitt/watch-gh-repos/commit/74e82ecb51cedc9328fe9bdf8b0b44c05fc0b616.
I also couldn't figure out how to turn on items 4 and 5 from this list. They weren't present in my UI. Thoughts?

I tried to update by adding the clientId, and it seems to break Octokit now, and I'm not sure why.

How did it break?  Did the device flow appear to work? Are you requesting the correct scopes?

I'm not sure that it updated, and I don't see a token stored in ~/.config/ on my machine.

It uses https://github.com/LinusU/node-application-config which is OS dependent.  What OS are running on?

I also couldn't figure out how to turn on items 4 and 5 from this list. They weren't present in my UI. Thoughts?

Looks like GitHub changed the setup of device flow because its out of beta maybe.  I will update the docs.

I tried to update by adding the clientId, and it seems to break Octokit now, and I'm not sure why.

How did it break?  Did the device flow appear to work? Are you requesting the correct scopes?

I'm not sure that it updated, and I don't see a token stored in ~/.config/ on my machine.

It uses https://github.com/LinusU/node-application-config which is OS dependent.  What OS are running on?

I also couldn't figure out how to turn on items 4 and 5 from this list. They weren't present in my UI. Thoughts?

Looks like GitHub changed the setup of device flow because its out of beta maybe.  I will update the docs.

Here is my latest commit: 74e82ec.

Going to try and find some time to take it for spin

Here is my latest commit: 74e82ec.

Going to try and find some time to take it for spin

I can't reproduce, seems to work for me.

I can't reproduce, seems to work for me.

Great news!
I'm on OSX. Any way I can see where ghauth stored its config files so I can flush them?

Great news!
I'm on OSX. Any way I can see where ghauth stored its config files so I can flush them?

I'm on OSX. Any way I can see where ghauth stored its config files so I can flush them?

Should be in ~/Library/Application Support/watch-gh-repos/config.json. I think the location changed in ghauth 4 and you could be right that it used to live in ~/.config/something on 3 or lower.

I'm on OSX. Any way I can see where ghauth stored its config files so I can flush them?

Should be in ~/Library/Application Support/watch-gh-repos/config.json. I think the location changed in ghauth 4 and you could be right that it used to live in ~/.config/something on 3 or lower.

Any luck?

Any luck?

Got it working by removing the file you suggested. Excellent! Thank you. Sorry about the extra confusion there.
One thing I am unclear on: do I commit my clientId?

clientID is like a public identifier of the app, so it should get shipped in the code of the CLI.  So yeah, commit that.

I believe this can be closed now. \o/

It works! Thank you very much @RichardLitt and @bcomnes 🙌🏼
$ npm i -g watch-gh-repos@latest
...
$ watch-gh-repos --org --watch zeke
  Authorize with Github by opening this URL in a browser:

    https://github.com/login/device

  and enter the following User Code:
  (or press ⏎ to enter a personal access token)

✔ Device flow complete.  Manage at https://github.com/settings/connections/applications/bfec45dffc45ea593ead
✔ Authorized for zeke
Wrote access token to "/Users/z/Library/Application Support/watch-gh-repos/config.json"
Watched: zeke/.com
Watched: zeke/12factor
Watched: zeke/18f.gsa.gov
Watched: zeke/404_color_bars
Watched: zeke/accessibility-developer-tools
...

Yes, thank you @bcomnes. :)
Zeke - since you use this, want to be a comaintainer? Load is minimal.

Sure. 👍🏼


Update xmake.lua

update version: 1.x.x -> 2.3.0.
change include from pyincpp/pyincpp.hpp to pyincpp.hpp.
update tests.
requires C++17 -> C++20.

commit 里面不要加 中文

Ok，我重新提交


Add iCE40 ChipWhisperer Target board support

This requires the constraints PR https://github.com/hdl/constraints/pull/6 .
This is a very basic additional iCE40 board, we plan on using neorv32 as part of some demos on so would be convenient to avoid our own fork. Happy to adjust anything as needed.

Great work! Thanks for contributing!
I suggest to wait until hdl/constraints#6 is merged so we can update that submodule before merging this.

Somehow I cannot update this branch... 🤔
Anyway, you might want to update this PR from main and also add your setup to the implementation workflow to have up-to-date bitstreams generated on every repository update by GitHub actions.

Got it - so switch the PR to come from my "main" branch you mean right? I'll close this one & re-open a new one to avoid weird git issues if so (along with adding the integration).

@colinoflynn I believe he meant rebasing your ice40cw312-support branch on top of the main branch of this repo. No need to close and recreate this PR, just force-push the branch.

@colinoflynn
@umarcor is right, sorry for the confusion 😅

Got it - I misread "update", doing a rebase makes way more sense! Thanks for clarifying. I spend too long with ohshitgit.com I guess I'm too trigger-happy to just blow it away ;-)

Looks good to me! :+1:
Please add your setup to the front page's readme (I can also do that after merging if you like). :wink:
Btw, it would be great if you could verify the generated bitstream on your hardware. You can find the bitstream file(s) in the assets of the setup's implementation workflow.

I confirmed the artifact works on my HW, so seems nothing got mangled!

Is there any "official" documentation yet for the board? Or even a place to purchase it?
Then we could add a link to the overview in the front page's readme.

@stnolting you could use a ref to https://hdl.github.io/constraints/Data/Boards/index.html#ice40cw312, so when the doc refs are updated there, users can find all of them without updating the info here.

Oops missed the github ping this AM! The "most stable" link is the github design docs (https://github.com/newaetech/chipwhisperer-target-cw308t/tree/main/CW312T_ICE40UP) it gets rendered to another site (rtfm.newae.com) but those URLs may change if things get rearranged. It's not available yet as a "real" product so it's still just the design files.
The constraints file is already pointing there, so that seems like a safe method too (and maybe shows the value of the constraints file).

Great, I will add that link.


Assign task length depending on the resource

Is there a way to assign a task length depending on the resource that is going to be assigned?

+1, Same issue


[Suggestion] Use default highlight group for diagnostic icons

The plugin can use custom diagnostic icons
By default nvim already has the DiagnosticSign* highlight group
But currently the plugin uses LspDiagnosticsSign, as seen here
It would be interesting to change the origin of the icons to the nvim default
A plugin that would be useful for this is ray-x/navigator.lua, which sets icons using the default highlight group
This would make it easier to define icons, and also more practical to have uniform icons in nvim
If the person already uses ray-x/navigator.lua, the icons will be taken from there, or if not, you can set the icons as it is currently done, just changing the name of the highlight used.
The function where the severity is obtained is also necessary to change, changing Warning to Warn and Information to Info

Severity function code
Current code:
local diag_severity_to_string = function(severity)
  if severity == vim.diagnostic.severity.ERROR then
    return "Error"
  elseif severity == vim.diagnostic.severity.WARN then
    return "Warning"
  elseif severity == vim.diagnostic.severity.INFO then
    return "Information"
  elseif severity == vim.diagnostic.severity.HINT then
    return "Hint"
  else
    return nil
  end
end

Modified code:
local diag_severity_to_string = function(severity)
  if severity == vim.diagnostic.severity.ERROR then
    return "Error"
  elseif severity == vim.diagnostic.severity.WARN then
    return "Warn"
  elseif severity == vim.diagnostic.severity.INFO then
    return "Info"
  elseif severity == vim.diagnostic.severity.HINT then
    return "Hint"
  else
    return nil
  end
end

If the suggestion is accepted, I can make these changes

I think I had the Lsp* hl groups because that was the standard in earlier versions and I never saw the change. I think it would be good to move to the standard names, but this is a breaking change so some care would need to be taken to ensure that the old LspDiagnostic* groups would still work the same if anyone had defined their own settings for those groups.

It would be interesting to change the origin of the icons to the nvim default

Are there default icons that I can be using?

I think I had the Lsp* hl groups because that was the standard in earlier versions and I never saw the change. I think it would be good to move to the standard names, but this is a breaking change so some care would need to be taken to ensure that the old LspDiagnostic* groups would still work the same if anyone had defined their own settings for those groups.

Yes, Lsp* are the past versions, and from what we find in these PR that the group names have been changed
One way to maintain compatibility is to use the solution used in ray-x/navigator.lua
It checks if vim.diagnostic exists, which was implemented along with the name change, if it returns false it uses the old nomenclature

Are there default icons that I can be using?

I particularly use these icons
error '' | nf-mdi-close_circle
warn '' | nf-mdi-alert
info '' | nf-mdi-information
hint '' | nf-mdi-lightbulb

With the highlight groups, it's not that I care what version of nvim the user is one so much as I care about whether or not they are defining the old style of highlight groups themselves, either before or after the Neo-tree config runs. If they do, and we switch to using the new style internally, then their carefully selected colors will suddenly stop being used.
I think the answer right now, in v1.x, is that when we check for the existence of those groups in setup, if they don't yet exist we will try to link them to the new style if that exists before defining them with our default values. Of course, if someone defines them later after our config runs, it could cause an error if they don't first unlink that group, so it could still be a breaking change.
I think this is a good idea, but it should wait for 2.x, which is coming soon.
On the icons issue, it doesn't sound like there are any default icons at all, so we will need to stick with the current strategy of telling users how to define their own in the docs. Maybe that should be elevated to the Quickstart in the readme.

I second this change for 2.x. As I changed DiagnosticSign* for the LSP diagnostics I quickly noticed that the ones in NeoTree had not been changed and thought initially that it may have been a problem with NeoTree itsellf. Elevating to Quickstart would be helpful. In the end the aren't that many configuration parameters, and these will become more relevant as nvim users migrate to LSP.

+1 for the 2.x
The icons for those who have not defined can be the letters (E I W H) as is already done.
A deprecation notice would be great too.


added bot.recipesAll()

Also made a minor fix to api.md which was bugging me.
I needed to be able to access the recipe of a crafting table before I had made the planks (using Dutie). This seemed to be the best solution. It just doesn't check on wether the bot has enough materials or not.

Recipe.find is basically the same thing as your recipesAll.
I'm okay with the api.md change, it would be easier if it was in an other PR (you should use branches on your fork to do different PRs)

We could add a requirementsMetForRecipe boolean parameter to recipesFor if you want instead ?

I didn't want to add a parameters because I still wanted to be able to check for the crafting table (to better organize the possible recipes) as well as make it easier to understand when reading people's codes.
I don't want to use Recipe.find due to reasons of having to pass through a function rather than easily receiving an array. Otherwise it'd just be remaking a function that would always do the same thing.

Okay I guess it doesn't hurt to have one more function for this. Merging.


Returning the error 400 instead of 500 when creating a new object with non-existent foreign keys.

Resolving #7

Hi @estush , I noticed that the commit messages could be more descriptive and specific. It would be helpful to use meaningful commit message titles that explain the changes made in each commit. This will improve code readability and make it easier to understand the purpose of each change. Please consider updating the commit messages accordingly. Thank you!

OK
בתאריך יום ה׳, 26 בספט׳ 2024 ב-10:56 מאת Ruti Rozenberg <
@.***>:

Hi @estush https://github.com/estush , I noticed that the commit
messages could be more descriptive and specific. It would be helpful to use
meaningful commit message titles that explain the changes made in each
commit. This will improve code readability and make it easier to understand
the purpose of each change. Please consider updating the commit messages
accordingly. Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/npmStart0/server/pull/9#issuecomment-2376200683, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BGMNBRWPS3N4YDKB4RW77ATZYO4ZNAVCNFSM6AAAAABOYF5RUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZWGIYDANRYGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

#10
-my Issues
Thank you!

Conflicts must be dealt with before requesting a review.


Added dutch language to the time elements and modified the time eleme…

now the times are in dutch notation ^.^cheers

Before anyone wonders why I did the review. @lenmen is a colleague of mine and asked to do the review as well 😄

fixed comments. @robinvdvleuten thanks for the review^^

@lenmen thanks for the evening effort 👍

Any updates on this PR?

Hi, can someone say when this is adding to the site?

+1

So sorry guys for the delay... just merged. Thanks!

When will it be available on wit.ai?

@Woutje99 per https://wit.ai/blog/2017/05/01/new-duckling wit.ai moved to a new Haskell-based Duckling (in particular to handle a fast-growing load). The new Haskell-based Duckling is at https://github.com/facebookincubator/duckling it's still open source and you can contribute rules (the format is slightly different, but the philosophy is the same).

@ar7hur Yeah I read that. But does it mean that this translation not will be used on Wit.ai?

@Woutje99 yes, unless of course somebody pulls it into the Haskell version


does any demo about rain or snow?

hi, @squarefeet . I am learning your ParticleEngine repo. the examples are all cool, but would you please give a demo about rain or snow like stemkoski's this page?
https://github.com/stemkoski/stemkoski.github.com/blob/master/Three.js/Particle-Engine.html
thanks.

This is my snow demo: http://weiserhei.github.io/threejs-experiments/christmas2015/
Its based roughly on stemkoski in a simple scene and the code is on github: https://github.com/weiserhei/threejs-experiments/blob/gh-pages/christmas2015/js/app/snowParticles.js

@weiserhei  thanks. it works well.

Hi @dyh333. To change texture at run-time, you'll have to do a few things. I'll give you an example below. I'm currently working on quite a few additions to this library (it's been a while!) and one of them will be a function on SPE.Group that will do this for you. In the meantime, to change a texture on a particleGroup once you've created it (and following your example above):
particleGroup.texture = loadTexture( './img/snowflake.png' );
particleGroup.uniforms.texture.value = particleGroup.texture;
particleGroup.material.needsUpdate = true;

Hope that helps!

@squarefeet  thanks very much. i will try.

@squarefeet
it works. thanks again.

Ah good, glad it worked :)


Beta: images with no description display long text about it

Summary:
On beta, on images with no description, rather than just saying 'No description' the description shows 'this file has no description, and may be...'. Probably an upstream bug.
See https://github.com/commons-app/apps-android-commons/pull/2681#issuecomment-477765766
Screen-shots:

See https://phabricator.wikimedia.org/T219578


Button to quote (add "> " before each new line) for highlighted text

I've seen this in some other apps, and it'd be nice to have. Currently the only alternative is to type "----" to add a separator line around quotes, since pasting "> " before each line is difficult on a touchscreen.

@benguild great first PR opportunity 😉
Sent with GitHawk

@benguild great first PR opportunity 😉
Sent with GitHawk

I'll see what I can do 👨🏼🍳


More detail on Pixtral training

Does Pixtral supports mix dataset (text-only + image-text) like Qwen2-vl. The code seems to bug when I trained with mix dataset.

it might not support mixed data for now


refactor(behavior_path_planner/start_planner): fix docs typo

Description
Fix a line break mistake on docs markdown.

Tests performed

Not applicable.
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

This is fixed in the latest main branch.


Development: Introduce module-API for Atlas

Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] I chose a title conforming to the naming conventions for pull requests.

Motivation and Context
As part of my master thesis, I am trying to create more well-defined boundaries between different modules. The main motivation is to improve the developer experience and test efficiency.
Description
Each module (subpackages of de.tum.cit.aet.artemis) will have its own api-subpackage. Classes from other modules are only allowed to access functionality from this api folder which acts as a facade to services (and repositories) within each module. Apart from the api-subpackage, other modules can access all classes/interfaces in domain and dto. This module API can be seen as part of the presentation layer - same as the Resources (Rest Controllers). However, instead of exposing a REST-API to the client, this module API exposes a Java-API (i.e. method calls) to other modules.
Traditional Layered Architecture Diagram:

This diagram might fall short in explaining that JavaAPI and REST-API are part of the presentation layer, but have a different way of exposing their API. The below diagram might be more explicit about this:
Hexagonal Architecture Diagram:

Access Within a Module

A RestController can services, and repositories from the same module. We will restrict the access to repositories in the future. A RestController cannot access module APIs from the same module
A module API can access services and repositories from the same module
A service can access other services and repositories from the same module

Access Between Modules

A RestController can access module APIs from other modules, but cannot access services/repositories from other modules
A service can access other module APIs from other modules, but cannot access services/repositories from other modules
RestControllers, ModuleAPIs, and Services can access Entities/DTOs from other modules

The access to module-external services will also enforced be enforced by Arch-Tests. Currently, only enforced for the atlas module.
Out of scope / Future

Module APIs use repositories from the same module - we will change
Currently, the APIs are using repositories from the same module. In the future, we will change to only use services instead of repositories.
Extend the arch tests to enforce that controllers cannot access module APIs from the same module
Warnings for modules that do not fullfil these requirements (with these changes, one can only enable the tests for the module which would cause the test step to fail)
We will add the concept of "SimpleServices" (not attached to the name yet) that aim to move functionality from the Repositories to the Service-Layer). This, for instance, includes default methods or logic beyond the unimplemented interface-methods or queries).

Testserver States

[!NOTE]
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress
Code Review

[x] Code Review 1
[ ] Code Review 2

Summary by CodeRabbit

New Features

Introduced multiple new API controllers for managing competency progress, prerequisites, learning paths, and science events.
Added methods for updating competency progress asynchronously and synchronously.

Refactor

Replaced CompetencyProgressService with CompetencyProgressApi across various services and controllers, enhancing modularity and API interactions.
Updated service dependencies in CourseService, ExerciseService, LectureService, and others to utilize the new API structure.

Tests

Updated integration tests to reflect changes in competency progress handling, ensuring they interact with CompetencyProgressApi instead of CompetencyProgressService.

What is the rational for preventing RestControllers from accessing the API from its module?


[ACI] Internal container name appearing at prompt in bash shell commandline

Describe the bug
The containers internal name gets thrown onto the bash command pompt.
It takes up a lot of room on the line additionally the text is right where typed command text goes into.
Command Name
az container exec
To Reproduce:

az container exec --container-name somecontainer --name someinstance --resource-group somegroup --exec-command /bin/bash

Environment Summary
Linux-5.3.0-19-generic-x86_64-with-debian-buster-sid
Python 3.6.5
Shell: bash

azure-cli 2.0.75

Additional Context

@nofunatall Apologies for the late reply. Could you please confirm if you are still running into this issue ? This issue is open for quite sometime. Please let us know if you need any further assistance on this.


error

Ruleset: Historical, Mode: arcade
Map: Testmap, Source: Modern Historians, Character: 1
!! Traceback (most recent call last):
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/main.py", line 12, in
game.Game(main_dir, error_log)
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/game.py", line 739, in init
self.run()
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/game.py", line 1150, in run
self.menu_char_select(mouse_left_up, mouse_left_down, mouse_scroll_up,
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/common/game/menu_char_select.py", line 26, in menu_char_select
self.start_battle(self.char_selected)
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/common/game/start_battle.py", line 9, in start_battle
self.battle_game.prepare_new_game(self.ruleset, self.ruleset_folder, self.team_selected,
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/battle.py", line 534, in prepare_new_game
self.subunit_animation_pool = self.main.create_sprite_pool(direction_list, self.main.troop_sprite_size,
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/common/game/create_sprite_pool.py", line 13, in create_sprite_pool
weapon_common_type_list = tuple(set(["" + value["Common"] + "" for key, value in weapon_list.items() if
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/common/game/create_sprite_pool.py", line 13, in
weapon_common_type_list = tuple(set(["" + value["Common"] + "" for key, value in weapon_list.items() if
!! TypeError: can only concatenate str (not "int") to str

Thanks for the report, This error should be fixed with the newest update. Made a mistake not checking for the error before commit :P

I got this:
Ruleset: Historical, Mode: arcade
Map: Testmap, Source: Modern Historians, Character: 1
!! Traceback (most recent call last):
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/main.py", line 12, in
game.Game(main_dir, error_log)
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/game.py", line 744, in init
self.run()
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/game.py", line 1150, in run
self.menu_char_select(mouse_left_up, mouse_left_down, mouse_scroll_up,
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/common/game/menu_char_select.py", line 26, in menu_char_select
self.start_battle(self.char_selected)
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/common/game/start_battle.py", line 13, in start_battle
self.battle_game.run_game()
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/battle.py", line 892, in run_game
pygame.mixer.music.load(self.musiclist[self.music_current[self.picked_music]])
!! IndexError: list index out of range

yeah I notice this error. Although I can't commit the update I am working yet. Will let you know when it done.

ok thx

The new update should fix this issue now.

why is there a black box around the caracthers?

or soldiers

Is it still there? I don't see any.

also how to change weapons?

Well that is very weird. Wonder if it related to pygame version or macOS. This never happen in the previous version before rework update right?
To change your character weapon, just press 1 or 2 (the one not on numpad).

yes

For the weird black box, can you try run this code below?
class HeroUI(pygame.sprite.Sprite):
weapon_sprite_pool = None
def __init__(self, screen_scale, ):
    self._layer = 10
    pygame.sprite.Sprite.__init__(self)
    self.screen_scale = screen_scale

    self.image = pygame.Surface((200 * self.screen_scale[0], 200 * self.screen_scale[1]), pygame.SRCALPHA)

    self.health_bar_size = (10 * self.screen_scale[0], self.image.get_height())
    self.health_bar = pygame.Surface(self.health_bar_size, pygame.SRCALPHA)
    self.health_bar.fill((0, 0, 0))
    self.health_bar_original = self.health_bar.copy()
    self.health_bar_rect = self.health_bar.get_rect(topright=(self.image.get_width() - self.health_bar_size[0], 0))
    self.health_bar.fill((200, 0, 0))

    self.health_bar_height = self.health_bar.get_height()

    self.stamina_bar = pygame.Surface(self.health_bar_size, pygame.SRCALPHA)
    self.stamina_bar.fill((0, 0, 0))
    self.stamina_bar_original = self.stamina_bar.copy()
    self.stamina_bar_rect = self.stamina_bar.get_rect(topright=(self.image.get_width(), 0))
    self.stamina_bar.fill((0, 200, 0))

    self.image.blit(self.health_bar, self.health_bar_rect)
    self.image.blit(self.stamina_bar, self.stamina_bar_rect)

    self.rect = self.image.get_rect(topleft=(0, 0))

import pygame
pygame.init()
wndsize = (400, 400)
window = pygame.display.set_mode(wndsize)
clock = pygame.time.Clock()
test = HeroUI((1, 1))
run = True
while run:
clock.tick(60)
for event in pygame.event.get():
    if event.type == pygame.QUIT:
        run = False
window.fill((255, 255, 255))

window.blit(test.image, test.rect)

pygame.display.update()

where?

seem to work fine on that end then. well this is quite weird since it use the same setup. Can you check in game again with the newest update to see if it still has the same bug?

there are still black boxes

Tested the game on another pc and no black box issue. Guess it is likely related to macOS. Will have a test on that later.

maybe

Have you figured out why black boxes are appearing on my screen?

I got !! Traceback (most recent call last):
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/main.py", line 15, in
game.Game(main_dir, error_log)
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/game.py", line 559, in init
self.change_ruleset()
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/game.py", line 587, in change_ruleset
self.troop_data, self.leader_data, self.faction_data = make_faction_troop_leader_data(self.main_dir,
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/common/game/setup/make_faction_troop_leader_data.py", line 12, in make_faction_troop_leader_data
troop_data = datastat.TroopData(main_dir, weapon_images, ruleset_folder, language)
!!   File "/Users/Emma/Documents/GitHub/AnchientBattleSimulator/gamescript/datastat.py", line 252, in init
self.weapon_lore |= {key: value for key, value in weapon_lore_list.items() if key
!! TypeError: unsupported operand type(s) for |=: 'dict' and 'dict'

Unfortunately not, I have no access to macOS to test it yet. The last error is because you need python 3.10 to run the game.

oh ok

did you get a macOS yet to test the error?

Probably will be a little while longer, I don't have access to my pc yet and my laptop is not good enough for virtual machine. Will let you know when I manage to do it. For now, can you try update the game and all python library to see if it work now?

ok

The black boxes might actually be hit boxes.

I also found out the boxes size depends on the units size.

I see thanks for checking, well I should be able to test the game on macOS soon. Will let you know when I mange to get to it.

so I managed to run the game on macOS 12 in my virtual machine and could not manage to replicate the black box issue. So I think the issue may be from outdated requirement on your pycharm. Can you post a screenshot of your package list?
Here is what mine look like: For some reason pygame 2.3 can not be run on my macOS so I had to revert to 2.1 version.

Well you should also try run pip install -r requirements.txt too to check if it really is the issue with library.

If that still not work, I will make a new release for macOS for you to test with the release version.

it doesn't work

Just release mac version in the newest update. Can you try it from here?
https://github.com/remance/Masendor/releases/tag/<IP_ADDRESS>

it still doesn't work

the background is has no green. it's just grey with curved lines everywhere.

I can't even see the bases

Also can you post screenshot for the animation maker too?

So if this blackbox only appear in the newer version, I think this may solve the issue.
Can you try downgrade Pillow library from 9.4.0 to 9.3.0. And maybe all of the following libraries below to these specific version? Maybe the newer one are incompatible with your system.
iniconfig==1.1.1
numpy~=1.22.2
pandas~=1.4.1
Pillow~=9.3.0
pygame~=2.1.2
pyperclip==1.8.2
pywin32-ctypes==0.2.0
screeninfo~=0.8.1
pathfinding~=1.0.1
scipy~=1.8.0

Thank you for the screenshot, the black box around mouse icon make it more obvious now that there is some issue with transparency. Likely with pygame and your system for some reason. I will have a try to make a quick test for this.

What happen when you run Aliens.py game? You can find it in python folder (not sure where it is in your macOS system). Here is an example of where mine is : C:\Program Files (x86)\Python\Lib\site-packages\pygame\examples

In any case, can you post your system spec, the pygame version you are running on? If nothing is working, I think I will have to go ask in a forum or pygame issue.

So I receive a suggestion to replace pygame with pygame-ce. So can you try update the game, and uninstall pygame from your pycharm and then install pygame-ce instead?

aliens.py does not have any black boxes

Did you try uninstall pygame and install "pygame-ce" instead yet?

where is the folder that contains the soldiers

Well that is bad to hear :( Can you post screenshot of animation maker?
Do you mean the troop sprite or data (like attack stat and stuff)?
For sprite it is here: data\sprite\subunit
For data it is here: data\ruleset\historical\troop\preset

The issue is not related to troop itself though since even the mouse surface also not working.

Also I am going to submit this issue on pygame-ce github. Can you list the following info below?

Operating system (e.g. Windows, Linux(Debian), Linux(Ubuntu), Mac):
Python version (e.g. 3.7.9, 3.8.5) : (Shown when run game)
SDL version (e.g. SDL 2.0.12):  (Shown when run game)
PyGame version (e.g. 2.0.0.dev10, 1.9.6):  (Shown when run game)
Relevant hardware (e.g. if reporting a bug about a controller, tell us the brand & name of it):

what do you meen?

what do you meen?

To which comment are you asking this?
If you mean this one:

Also I am going to submit this issue on pygame-ce github. Can you list the following info below?

Operating system (e.g. Windows, Linux(Debian), Linux(Ubuntu), Mac):
Python version (e.g. 3.7.9, 3.8.5) : (Shown when run game)
SDL version (e.g. SDL 2.0.12):  (Shown when run game)
PyGame version (e.g. 2.0.0.dev10, 1.9.6):  (Shown when run game)
Relevant hardware (e.g. if reporting a bug about a controller, tell us the brand & name of it):

Then I need your system information so I can ask the pygame developer to check with this issue we are having.

my mouse and the game mouse does not align and I don't know how to do what you are asking me

You can get your computer system specification by following the step in this link: https://kb.wisc.edu/helpdesk/page.php?id=8208

I need to know the information in graphic/display and the one shown in the image above.
Then I need to know your python version and all library version like the one in image below.

There is no more info on my mac

That is weird. Do you have other computer to test the game?

Now that I think about it, have you try testing other games made in pygame so far?

Maybe try this one: https://ghastly.itch.io/meltdown or https://github.com/Gooodgis/dont-touch-my-presents or https://internal.markop1.cz/chess/

I tried dont touch my presents before. It works like a charm!

Well this is even weirder. Although the game use older version of pygame. I wonder why this game does not work when both use pygame.

yeah

tHE BLACK BOXES ARE REMOVED I THINK, BUT THE BACKGROUND ISN'T LOADING PROPERLY. The background loads properly when you just start the battle, but after about 1 second, the background changes into a more lazy version of the background.

Well somehow that one things fixed itself. Can you post 2 screenshots of before and after the background change?

ok

You should add romans and make the game kind of similar to shield wall on steam: https://store.steampowered.com/app/1216320/Shieldwall/ , because romans were very cool and popular and you should know that romans were pretty famous for their shield wall.

Hmm yes roman battle would be a great addition. What do you think is more interesting, Romans vs barbarian (german or celt), vs carthage, parthia, egypt, greek, or maybe against roman themselves (civil war)?

Hmm yes roman battle would be a great addition. What do you think is more interesting, Romans vs barbarian (german or celt), vs carthage, parthia, egypt, greek, or maybe against roman themselves (civil war)?

A whole campaign against them all ;)

yes

Well if have enough time, sure. At least it is possible to reuse roman troops in all those battle. :)

before  after

Can you solve this?

Also. I can't use the map editor.

Hello @Hamster-lord
Is the original Issue with the black boxes solved?
Can we consider that bug fixed, so we can close this issue ticket?
Would it be possible that you report every bug in a different issue ticket?
Like, what do you do to trigger the bug, does it happen 100% of the times with those stepes?
I think it's going to be easier to track and fix them that way.
Thanks!

before  after

Can you solve this?

Even the before image already doesn't look right. So I think something is wrong with map effect instead now. I will have a try to fix it.

@remance can you show a screenshot of how it should look like? (ie., how it looks on your local computer)
What's the macOS version you are uding @Hamster-lord ?
What about the python interpreter version and the rest of the python libraries?
I can try myself to trigger the bug in a VM with the problem environment, but first I need to know the details to reproduce it in the same circumstances.
Any information will be of help.

12.6.3

@RybenHill
Here is what mine look like before and after the snow weather effect got added. Actually my previous was misinformed before. The before image seem to be what the game look like few second before the weather effect kick in. And I can see that the blackbox issue is not really fully solved yet. I can still see blackbox around the snow sprite on Hamster-lord screenshot. So there is something between different between the way image is loaded for troops and other sprites that fix the black box issue.

@Hamster-lord ok I just tried something. Can you update the game and have a test again? I think it should (hopefully) fix your issue.

If the new update still does not work. Can you screen shot what this part look like on your system?

not working

this is for huge battle

So two things I manage to derive from the last screenshot. The sprite transparency work fine IF they are blitted on to another surface first (for example weapon icon on top left UI). The transparency issue seem to occur mostly for sprite that are blit on UI interface mostly. But I am not sure why map weather effect transparency also does not work. At least this narrow down what to look for.

OK for the next step, Can you post what this screen look like on your system?

for some reason, there is no settings under rename project

never mind I found it

also, the new updates caused the black boxes to come back to the soldiers.

So first thing first, you need to uninstall pygame 2.3.0. Try run the game after that and see how it go.

now it says No module named 'pygame.freetype'

did you delete pygame-ce as well? If so try reinstall only pygame-ce and try again.

I still have pygame-ce installed

Ok, will try to do a bit more test. Will let you know when the next update is.

So here is what I found.  But it is not related to pygame-ce version for sure. Wonder if they actually manage to fix it on normal pygame. Maybe can you try remove pygame-ce and reinstall pygame only again?

not working

So it become similar to this image before, yes?

correct!


[object Object] in mastodon URLs

mastodon.social profile and follow URLs other than my own have [object Object] instead of mastodon.social in the URL:

Having the same issue

same


Does it support multiple GPUs training?

Does it support multiple GPUs training?

Not not yet. It's on the roadmap though.

Oh duplicate of #36 and others - on the roadmap, but our core mission is to create the world's best single GPU finetuning library, since that's what the majority of people need. Sadly we also have to prioritize since we're a 2 person team, although I want to thank the OSS community for helping us as well :)


Review code organization

Review code organization(to be easy for contributors to read and contribute.

Action item: create a document explaining the code structure.
If code is self explanatory, define a structure that simplifies code reading

won't do, to be addressed on the upcoming AWS LZ


Niantic broke it?

try again. intel was totally down for a while
On Tue, Apr 7, 2020 at 3:45 PM Darr247<EMAIL_ADDRESS>wrote:

[image: IITCBroken]
https://user-images.githubusercontent.com/1146636/78726384-d1cba800-78ff-11ea-96ec-cf9485aefa49.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/iitc-project/ingress-intel-total-conversion/issues/1312,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEI3PKXHP7ZJWBKV2OUHRBTRLOUIFANCNFSM4MDPLYZA
.

--
Visit my store on Teepublic https://www.teepublic.com/user/crystalwizard and
grab something cool today!


Update to support pytest 3.5

This is still a work in progress, I need to verify everything.
This is an effort resolve #126

Coverage decreased (-0.006%) to 97.683% when pulling db429d478747fa6140f95b2796331f206c79d28e on tws-support-new-pytest into 0d047b7a7e0a0801afe6f0545ba2b8e73bf0e61b on master.

Coverage decreased (-0.006%) to 97.683% when pulling db429d478747fa6140f95b2796331f206c79d28e on tws-support-new-pytest into 0d047b7a7e0a0801afe6f0545ba2b8e73bf0e61b on master.

Coverage decreased (-0.006%) to 97.683% when pulling db429d478747fa6140f95b2796331f206c79d28e on tws-support-new-pytest into 0d047b7a7e0a0801afe6f0545ba2b8e73bf0e61b on master.

Coverage decreased (-0.006%) to 97.683% when pulling db429d478747fa6140f95b2796331f206c79d28e on tws-support-new-pytest into 0d047b7a7e0a0801afe6f0545ba2b8e73bf0e61b on master.

Coverage decreased (-0.006%) to 97.683% when pulling db429d478747fa6140f95b2796331f206c79d28e on tws-support-new-pytest into 0d047b7a7e0a0801afe6f0545ba2b8e73bf0e61b on master.


"scroll_to_content:" option on tabs can be problematic with sticky header

When using tabs while using a sticky header, something very common these days, using "scroll_to_content:true" in data-options will result in somewhat unexpected behaviour: clicking on a tab item will scroll to content just fine but it will hide the tab list under the sticky header.
I believe this is caused by the scrollIntoView method called in the toggle_active_tab function. Since the scrollIntoView method does not allow the offset to be defined (e.g. top:50), i believe foundation would be better off using another method for performing this action.

Interesting. What other method can you suggest? We're interested in hearing more about this.


Device list is not displayed after remove last device from the page

Steps to reproduce the problem:

Create some devices

Remove the last device from a page

Affected version: 63.2-20190820

Solved with dojot/dojot#1179

Problem remains in version v0.4.2.

Test OK.

last device on page 3

last device

Tested in v0.5.0-alpha.1

This has not been fixed in v0.4.3-rc.2

last device on page 3

remove device

click page 2

But has been fixed in v0.5.0-alpha.4

last device on page 3

remove device

It has fixed in 0.5.x version.


Fallback to Proxy

Can Object.observe polyfill be made to fall back to Proxy?
The fact that Object.observe was deprecated and and dropped in V8 4.9 suggests that Proxy could be used as drop-in replacement, if possible.

Unfortunately, that is not possible, as already explained in the documentation. The problem is that while Object.observe watches for changes in a given object, a proxied object catches changes in a copy of the object. Which means that is a change is made on the original object, it won't be caught by the proxied object's handlers.
Anyway, I consider the development of this polyfill as concluded - at least on my part. I'm willing to deliver security fixes only.
More than that, the whole package is deprecated, as O.o is gone. Modern web application should head to different approaches than observing an object for changes, namely functional programming. For the rest, Proxy is the way to go.

Sorry, I've missed that readme part, thank you for the explanation. I was looking for the library to embrace both Object.observe and Proxy and switch between them, depending on which one is available. Do you have one at your sight by chance?

None that I'm aware of.
And after all, I wouldn't recommend to use Object.observe altogether, since it's gone on the sole platform that supported it. And I'm not sure about any package that mixes it with Proxy, since we're talking about different approaches to the problem.
My suggestion is to use just Proxy objects or, if you have to deal with older platforms, targeted libraries like Polymer's observe-js.
If you don't mind, I'm closing this issue. Feel free to comment further, though.

Thanks, you've helped indeed, totally forgot about Polymer's observe-js.


Start a Release Review

Passing Release Review is a required step before making a first public release. Deadline for passing the review is Nov 30th, 2018. Release review takes some time to complete, so it makes sense initiating it as soon as possible.

[ ] Start Release Review
[ ] Update Release Review Tracker

Additional information:

How to submit a release review
Eclipse Handbook

A part of Eclipse Metro project:
https://projects.eclipse.org/projects/ee4j.metro


No support for tarballs larger than 4GB

The implementation implicitly uses unsigned, etc which is often compiled as 32-bit words. In this case offsets will silently wrap for tarballs longer than 4GB and cause errors.
The easiest fix would be to add a separate method (mtar_add_pos(unsigned pos, unsigned offset)) which checks that the position doesn't wrap silently while doing the addition. Support for a 64-bit implementation would be nice as well :)

Use size_t type.


Run tests with TF GPU support to catch any GPU vs. CPU behaviour differences

Description
Tensorflow can run on both CPU and GPU (and TPU), and some functions have behaviour differences, for instance

tf.nn.embedding_lookup (at least, according to the docs of tf.compat.v1.nn.embedding_lookup):

validate_indices: DEPRECATED. If this operation is assigned to CPU, values in indices are always validated to be within range. If assigned to GPU, out-of-bound indices result in safe but unspecified behavior, which may include raising an error.

This parameter doesn't exist in tf.nn.embedding_lookup and defaults to False in tf.compat.v1.nn.embedding_lookup

tf.gather

Note that on CPU, if an out of bound index is found, an error is returned. On GPU, if an out of bound index is found, a 0 is stored in the corresponding output value.

One option would be to have an agent queue that includes GPU (e.g. using g4dn.xlarge which seems to be the cheapest GPU-supporting EC2 instance at USD$0.526/hour on demand) and run tests using it only occasionally (e.g. once per day, or on Tuesdays and Thursdays each week). The latency of these tests wouldn't be important, and so could have a small limit, like 1, to avoid costs spiralling out of control even if we make a mistake and leave it running for an extended period.
Another would be having buildkite run on a machine-with-GPU that we own.

The buildkite-g4dnxlarge agent pool has been created.

Tag is queue=g4dnxlarge
EC2 instance is g4dn.xlarge
Min scale is 0, max is 1
Scale down period is 600s (same as the t2large pool)
EBS volume is 80GBs (same as the t2large pool)


Added Docker and profiling instructions

Added some documentation.

No longer needed since https://github.com/jbloomAus/DecisionTransformerInterpretability/pull/87 covers everything except the profiling docs, which aren't really needed anyway.


Build is failing with parquet-scrooge errors.

The build is currently failing for all PRs in Travis CI. According to Alex:

. . . one of the scrooge dependencies transitively pulled in a snapshot that has since been purged. Seems like that dependency was improperly published. Upgrading the scrooge plugin should fix this.

Reporter: Ryan Blue / @rdblue
Assignee: Ryan Blue / @rdblue
Related issues:

Restore scrooge-maven-plugin to 3.17.0 or greater (is related to)

PRs and other links:

PR #187

Note: This issue was originally created as PARQUET-268. Please see the migration documentation for further details.

Ryan Blue / @rdblue:
Fixed in #187. Had to downgrade the plugin dependency version to 3.16.0.

Alex Levenson / @isnotinvain:
Looks like downgrading won't work for us.
Spoke with the scrooge folks and they are working on doing a release to fix the issue, but I think we are stuck until then.

Ryan Blue / @rdblue:
I'm going to do the downgrade and ignore the failing tests. We know that the library works right as long as Scrooge does, so I think it is reasonable. I'll ping you on the PR for review.

Alex Levenson / @isnotinvain:
Looks like you beat me to it, I was doing the same thing. The scrooge folks are working on a fix so we can roll forward once that's out.

Alex Levenson / @isnotinvain:
Issue to watch:
https://github.com/twitter/scrooge/issues/184
Summary of the issue is the version we were using (3.17) depended on a snapshot that has been deleted (it was a bug that it depended on a snapshot)


Typo "SQL managed instance"→"SQL Managed Instance"

https://docs.microsoft.com/en-us/azure/security-center/recommendations-reference
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#please-close


Add gapic-google-cloud-logging-v2-docs

Add gapic-google-cloud-logging-v2-docs

Also, I accidentally submitted some comments on your old commit, which looks like it got overridden. Please disregard those.

PTAL

Sorry, just did amend again.


OKCoin returning  CNY/BTC value instead of USD/BTC

Hello following code returns CNY/BTC value instead of USD/BTC

  Ticker ticker = null;
        try {
            ticker = xchange.getPollingMarketDataService()
                    .getTicker(new CurrencyPair("BTC/USD"));

        } catch (ExchangeException | NotAvailableFromExchangeException | NotYetImplementedForExchangeException | IOException ex) {
            logger.error(ex);
        }

Are you  using OKCoin international?

What do you mean by international? I just use XChange OKCOin library. I am sorry if I have missed something but I didn't find  anything at wiki about OKCoin International.

A snippet from examples:
specification.setExchangeSpecificParametersItem("Use_Intl", true);

Thank you very much! I have missed that.

No wonder, it's not really a documentation :)

I'll write a brief wiki entry on how to configure OkCoin.

It would be grate because I did not succeeded with setting
specification.setExchangeSpecificParametersItem("Use_Intl", true);

I'm still getting CNY.

Please see the many examples how to instantiate an exchange from an exchange specification and how to set exchange specific parameters. Basic framework is:
ExchangeSpecification exSpec = new ExchangeSpecification(exchangeClass);
exSpec.setExchangeSpecificParameters(params);
...
Exchange exchange = ExchangeFactory.INSTANCE.createExchange(exSpec);

Thanks jheusser, I did set specs after I the exchange instance was created. Now it's fine.


Make AppsV1Service.createApplication static

1. What could be improved

Making AppsV1Service.createApplication static.
2. Why should this be improved
It does not require any field in AppsV1Service and it's useful to be able to create a client without a bearer token

Closing because i realized it requires the instance, while the bearerToken could be left blank.


WIP: Pygeoapi provider

First attempt at creating a CDMS Provider for pygeoapi.
The long term aim is to allow from opencdms.pygeoapi import CDMSProvider which can be configured to work with any supported CDMS.
The current version only implements ClimsoftProvider for working with Climsoft CDMS:
from opencdms.pygeoapi.climsoft_provider import ClimsoftProvider.

[x] publish observationfinal table as a collection
[x] visualize on items page
[x] visualize single item
[x] implement sorting
[ ] test sorting
[x] implement filtering
[ ] test filtering
[x] implement bbox filtering
[x] test bbox filtering

@isedwards
I have added this last section in main readme to explain how to use climsoft provider: https://github.com/opencdms/pyopencdms/tree/pygeoapi-provider#running-pygeoapi-server
I have updated this readme to demonstrate the current state of climsoft provider
https://github.com/opencdms/pyopencdms/tree/pygeoapi-provider/opencdms/pygeoapi

@isedwards
In this image, the bbox is [-180, -90, 180, 90] - which covers the whole map and we get all the data

In this image the bbox is [1, 1, 180, 90] - this returns no data. Because our station is located at latitude: -17.83
longitude: 31.02 and there is no station with all positive lat/lng

@faysal-ishtiaq - this is looking good.  Are the id's all the same at the moment (are we return the station id for every result)?
Any thoughts on why we're not seeing the background map?

@faysal-ishtiaq - this is looking good. Are the id's all the same at the moment (are we return the station id for every result)?
Any thoughts on why we're not seeing the background map?

We have observation data from only one station. And apparently that station is in the sea

Are the lon (x) and lat (y) the right way around?

Are the lon (x) and lat (y) the right way around?

here it says that longitude is x and latitude is y
https://gis.stackexchange.com/questions/11626/does-y-mean-latitude-and-x-mean-longitude-in-every-gis-software#:~:text=Latitude is the Y axis,180 longitude system is use.

Agreed, but it looks like you've plotted (lat, lon) instead of (lon, lat). Could you try the coordinates the other way round? If you do, it looks likely that the station will be plotted correctly in Zimbabwe.

yes, it was an error from my side. I have fixed it

Also for some url (such as, http://localhost:5000/collections/climsoft/items?obsDatetime=2000-01-19 06:00:00&sortby=+obsValue ), I get the following error

When I looked into for the error message, I found it here https://github.com/geopython/pygeoapi/blob/master/pygeoapi/api.py#L1419
Which implies that the sort key was not found in db.fields . But obsValue is in the fields (the OrderedDict)
>>> "obsValue" in a.keys()
True

I am not sure what I am missing.


webvr boilerplate fixes

resolves #1506 - wrong canvas dimensions on homepage
resolves #1504 - incorrect aspect ratio when switching between editor
cameras
fixes boilerplate regressions - canInitiateCameraMove and
getContainerDimensions now back where they were.

lgtm; however please make sure you've done this:

apply the changes to our fork of boilerplate/webvr-manager (webvr-1.0-vizor branch)
rebuild the boilerplate (npm run build)
copy build/webvr-manager.js into our repo (into browser/vendor/borismus/)
commit both


Add --vertical_fontlist option to tesstrain.py

Porting from https://github.com/tesseract-ocr/tesseract/pull/3434 (not merged) .

This Pull Request adds --vertical_fontlist option to tesstrain.sh to specify a list of fontnames to render vertical text.
The format for specifying a list of fontnames is the same as for --font_list option.
If --vertical_fontlist  option is specified, it will override the VERTICLA_FONTS variable(defined in language-specific.sh) with the specified list of fontnames.

In the current version, the VERTICAL_FONTS variable is hardcoded in language-specific.sh. So, when creating training data for vertical text such as Japanese, users need to edit the source code even if they specify a list of fontnames with --fontlist and --font_dir.

Looks like this was closed accidentally

For vertical text, it is hard to use without this option.
However, I have developed a more powerful script to replace text2image/tesstrain.py, so I don't use tesstrain.py anymore.

If I understand "Makefile training" correctly, this "src/tesstrain" is not used for training at the moment.
AFAIK these python script are based on old shell training scripts. I suggest to keep them and maybe we can find the way how to integrate it to current training process...

@nagadomi : can you update this PR to recent git code?

According to my request in #307, there basically are two ways to train Tesseract inside this repository:

The Makefile-based approach to train on real data.
The Python-based approach to train on artificial data, corresponding to the old Bash-based approach.

My suggestion had been to actually document this somewhere as this is not always clear, but due to the harsh stale automation and (at least in the past) rather restricted responses, this has been buried into closed issues.

As I mentioned in other PR - I am interested in python based training as "make training" is difficult run on windows and it requires tool that could be easily replaced by python (unzip, wget, bc ...). I would suggest to merge/rework current open PR and then move forward (review issues/PR marked as "stale"...

committed in https://github.com/tesseract-ocr/tesstrain/commit/2c7c6e8feaf8aa1f2d1750b689fa46473453885e


Gallery

Is It possible to slide through other images o lightbox elements in the page like a gallery?

No, sorry (See #11, #82).


Automatic saving of notes

Automatically save the note a second after typing has stopped (to avoid excessive saving on every keystroke).

Current dependencies on/for this PR:

master

PR #72   👈

This comment was auto-generated by Graphite.


JSX open html tag flow with space

it may not fully related to this, but i just found out that in React
if you render html <h1> {'here is my react demo'}</h1>  (with a space after html<h1>), this will render a empty span,
is there any rule to warning this? many thanks

Duplicate of #191.
There is no rule for now, but I would accept a PR for this ;)

thanks for the update


refactor: updated copyright year

This PR updates the copyright year, form 2017 to 2020.

Plase, can we keep the online documentation updated with the SDK development ?

@skyzenr We have updated the copyright year. And JS documentation is updated on the Contentstack Docs site.


RefreshingEnabled = false, not working?

I want to disable pull to refresh, assumed I had to set RefreshingEnabled to false, but still it shows the spinning animation when pulling down.
Is there another way to disable it?

There are open bugs with the RefreshView in MAUI that we are using.
https://github.com/dotnet/maui/issues/12977

Are there any known workarounds for this?

As a temporary solution that worked for me you can try this:

Define a Refresh command in the viewmodel and set it a function that does nothing :)
Define a boolean observableproperty called isRefreshing and set its value to false inside the Refresh command.
Bind that boolean observableproperty to the "IsRefreshing" property of the datagrid as below:

<dg:DataGrid ItemsSource="{Binding Users}" PullToRefreshCommand="{Binding RefreshCommand}" IsRefreshing="{Binding IsRefreshing}">
    <dg:DataGrid.Columns>
        <dg:DataGridColumn Title="Name" PropertyName="userName"/>
        <dg:DataGridColumn Title="Surname" PropertyName="userSurname"/>
    </dg:DataGrid.Columns>
</dg:DataGrid>


[FLINK-34015][checkpoint] fix that passing ignore-unclaimed-state through dynamic props does not take effect

What is the purpose of the change

fix that passing ignore-unclaimed-state through dynamic props does not take effect

Brief change log

when parsing parameters of '-s' option to config map, just filter out the none setting to avoid replacing the value that comes from dynamic props.

Verifying this change
Documentation

Does this pull request introduce a new feature? (no)

Thanks for the pr. PTAL my comments. BTW, Could we also provide a UT to verify this ?

Sorry to reply so late, I have refactor the code according to your comments, and add some unit tests to verify the behavior.

@flinkbot run azure

@flinkbot run azure

@flinkbot run azure

Sorry for jumping in but I have mixed feelings... Is this a common problem that also applies for other options and shall we implement a generic solution for all similar options.


Serious functionality issues.

Copilot Chat Extension Version: This is what copilot says when i ask for version: I am based on the GPT-4 Turbo version of OpenAI's GPT models.
Version: 1.91.0 (system setup)
Commit: ea1445cc7016315d0f5728f8e8b12a45dc0a7286
Date: 2024-07-01T18:52:22.949Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.19045

They overwrite my code very wrongly. It gives me syntax errors all the time.
2. He is not able to understand a simple thing, like finding my variable "variableX" and replacing it with "variableY".
3. He is not able to read all the code. (I have 3100 lines)
4. It generates basic solutions that have nothing to do with the code I already have. for example, if I tell him to generate a function that inserts some values into a table, using the already programmed function x, he generates his own function for me.
It created a lot of nerves for me. If you stay at home and just try to code, or if you are just a beginner, it can help you, but when you have deadlines, the site could use a little help, it confuses you even worse. A mess. Do it in such a way that it interprets all the code. I'm sorry I called him. So I can't get over my nerves because I spent half the day explaining to him basic things that a beginner programmer would have understood.
Then for the second script I started from the beginning with the explanations.
Should I have expected a poor quality solution when it comes to Microsoft?

@hyperclassteam What programming language are you using? How large is the selection that you make? Are you using inline chat or sidebar chat. Here I am using inline chat to replace a variable with another variable and it is working:
https://github.com/user-attachments/assets/e4885fd4-e01c-4aae-aa03-c91a944398fc

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

Closing as we need further information to investigate this issue


fixthe union node should not pass through children in some case

Proposed changes
Issue Number: close #xxx
Problem summary
the union node will make children pass through in wrong condition. If the children's materialized slots are different from union node, children can't be passed through.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.96 seconds
load time: 635 seconds
storage size:<PHONE_NUMBER>9 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221222110953_clickbench_pr_67241.html


How to confirm the eslint-oxlint success of my project?

I followed the documentation, but it still feels like eslint is taking a long time to run. How do I make sure the plugin is running and how do I view the output?
precommit": "npx oxlint && eslint src --quiet --ext .jsx,.js,.tsx,.ts -f json -o ./.ci/eslint.json",

Hey, yes, you can try a eslint --print-config file.js (target any file that should be linted, just to test) and see which rules apply.


add sex check

From @cseed on August 28, 2015 15:51
If you're not Alex and you're working on this, talk to Alex.  He has some ideas about how this should be done.
Copied from original issue: cseed/hail#30

In.


docs(v2): Added 'X-Merchant-Id' to headers in Profile API docs

Type of Change

[ ] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[x] Documentation
[ ] CI/CD

Description

Add X-Merchant-Id to headers in Profile endpoints for v2
Additional Changes

[ ] This PR modifies the API contract
[ ] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[ ] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

Mintlify Screenshots (Notice the header field):


Remove broken link in README to inexistent page in PyPUG

Summary of changes

Closes #4173
Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in newsfragments/.
(See documentation for details)

Thank you very much @chrysle.


Add GitHub Actions to validate UWP via CMake

Also adds MinGW64 and AArch64 (ARM64) Clang coverage to Git Hub Actions.

MinGW on ADO fails because it needs a newer VCPKG release. I'm waiting for the next time they 'tag' a release.


Data table fixed header scrolling bugfix

Fixes #1696
This was an interesting bug! When tabbing and therefore focusing on headers outside the visible area the browser has to make a decision on how to bring them into view, which apparently defaults to "scroll the parent container." Since the headers are absolutely positioned as far as the rendering engine is concerned that parent is .slds-table_header-fixed_container rather than the table header that actually contains them. The browser then "scrolls" that parent left by an arbitrary amount in order to bring the focused element into view. Since .slds-table_header-fixed_container actually has overflow: hidden no scrollbar is shown, and .slds-table_header-fixed_scroller appears "clipped" because it is retaining the actual width of the parent container as it is scrolled left to reveal the hidden content. The effect looks quite goofy but it actually makes sense once you understand what's going on!
I tried a few different approaches to fixing this bug such as making the container have overflow-x: auto and the scroller overflow-y: auto, but that introduced other visual bugs. The simplest, most elegant solution I found was to add an onScroll event to the container that sets its scrollLeft value to a variable and checks if it surpasses 0. If so, the container's scrollLeft is reset to 0. Since both the container and scroller share the same width, the pre-reset scrollLeft value can then be applied to the scroller itself and effectively bring the focused content into view. The scroller's listeners then kick in and make sure to reposition / resize the headers correctly as expected, and everything looks as it should!

CONTRIBUTOR checklist (do not remove)
Please complete for every pull request

[ ] First-time contributors should sign the Contributor License Agreement.  If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
[ ] npm run lint:fix has been run and linting passes.
[ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

[ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
[ ] Tests have been added for new props to prevent regressions in the future. See readme.
[ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
[ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
[ ] Review tests are passing in the browser. Open http://localhost:8001/.
[ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

Required only if there are markup / UX changes

[ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
[ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
[ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
[ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@interactivellama this is ready for re-review


2 VPs panic on Query, commandline updated to peer peer

Description:
Previous commandline of ./peer peer, is now peer peer, no need for manually building into the docker containers.  But we still have a panic when attempting to do a query after a successful login, deploy and invoke.
Steps:

Setup a 4 peer network with security and privacy enabled.
Run the docker image commandline as outlined in https://github.com/hyperledger/fabric/blob/master/docs/dev-setup/devnet-setup.md
Use Postman or your favorite tool to login lukas
Do a deploy, copy the TID you get back
Do an invoke on that TID
Attempt a query on the TID

Results:
Two VPs panic
Expected results:
The query should succeed or fail gracefully.
peer panic 4 of 4.txt
peer panic 3 of 4.txt
peer panic 2 of 4.txt
peer panic 1 of 4.txt
peer panic ca.txt

This is the same problem as #1294


openssl error trying to run on ubuntu 22.04 jammy

Ubuntu 22.04 jammy no longer has openssl1 so the current release fails to run there:
# /usr/local/sbin/unbound-telemetry
/usr/local/sbin/unbound-telemetry: error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory

# dpkg -L libssl3 | grep libssl.so
/usr/lib/x86_64-linux-gnu/libssl.so.3

@furlongm I think you might be trying to run this code instead?

Yep - sorry for the noise! Looks like that one is deprecated so will look at switching here.


test add leading tpch

Proposed changes
Using leading hint to adjust tpch benchmark plan shape
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.67 seconds
stream load tsv:          536 seconds loaded<PHONE_NUMBER>9 Bytes, about 133 MB/s
stream load json:         21 seconds loaded<PHONE_NUMBER> Bytes, about 107 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size:<PHONE_NUMBER>0 Bytes

run p0


Enabling node debugging causes reentrant error in asp.net

enabling the node services debugging like so:
               services.AddNodeServices(options =>                 {                     options.LaunchWithDebugging = true;                     options.DebuggingPort = 5858;                 });
causes a crash in the asp.net code with a task has already been finalized reentrant error.
Any work arounds because this is very handy when server side pre-rendering goes nuts and you can't figure out why.

Let me investigate, thanks for pointing this one out John!

@JohnGalt1717 do have an example of this failing? I can't reproduce

It's fixed as of .net 2.0. Closing.

@JohnGalt1717 I assumed that was the case, but I didn't want to just say "It works for me" :)


[Bug] VelaUX does not set the default value of Trait "cpuscaler"

Describe the bug

VelaUX does not set the default value of Trait "cpuscaler"
To Reproduce

install valaux

create one application

go to the detail page of this application

edit the default Component "webservice"

click button "+ " to. add one new trait

select "cpuscaler"

the Trait Properties are filled by default value

click Create button

check request in Chrome devtool's network tab

the value of "cpuscaler" is not set

Expected behavior

the default value should be set

Screenshots

KubeVela Version
UI Version: v1.6.4-2f68a03
API Version: v1.6.4-git-1a6b724

Additional context

if change the default, value can be set correctly.

@StevenLeiZhang The actual rendering result should be correct, right?

@StevenLeiZhang The actual rendering result should be correct, right?

No, When you click "cpuscaler", the detail page is blank.

/assign


slack and twitter embeds experiment [WIP]

Creating a preview to test metadata markup in slack and twitter.

I will delete this in a bit. See for details: https://github.com/fluxcd/website/issues/165#issuecomment-897957232


QUIC as secure transport

Overview
Add QUIC as transport protocol within NATS ecosystem (client<->server, server<->server).
Clients and Tools

[ ] Schemas @ripienaar
[ ] CLI @ripienaar
[ ] Terraform @ripienaar
[ ] Github Actions @ripienaar
[ ] Go @piotrpio
[ ] Java @scottf
[ ] JavaScript @aricart
[ ] .Net @scottf
[ ] C @levb
[ ] Python @wallyqs
[ ] Ruby @wallyqs
[ ] Rust @Jarema @caspervonb
[ ] .Net V2 @mtmk

Other Tasks

[ ] docs.nats.io updated @bruth
[ ] Update ADR to Implemented
[ ] Update client features spreadsheet

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

Better to track the server issue here than open an issue in this repository for it.
https://github.com/nats-io/nats-server/issues/3140


aws-sdk-go in istio 1.11

Good day all,
Is there any plan to update the aws-sdk-go version in istio 1.11?

No. Any reason we should?

Actually its EOL, so we definitely will not: https://istio.io/latest/news/support/announcing-1.11-eol-final/


LUN-138: Resusable-SingleChoiceListItem

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword LUN.
I decided to keep this refactoring quite small because we have to keep the color logic in the component because its depending on state. I could have made a SingleChoiceItemWrapper but it's not worth in my opinion. To use the ListItem would mean to but a lot of additional logic inside which would make the component itself too complicated. Feel free for discussion if there are better proposals for refactoring

And please delete other not used LUN-138 branch if no longer needed.


Merge the Avatar MediaCache into the user profile cache, and then use the user profile cache everywhere

This includes not only the user profile logic, but also the timeline logic where user's displayable names and avatars are shown.
The reason for this is that when the server is slow, a request to fetch a profile takes a very long time, e.g., even in excess of 30 seconds per request (yikes). That means that it is likely for a user profile pane to be hidden long before the fetched profile response becomes available, meaning that the cache itself will never get updated.
In addition, the user profile sliding pane may have different (more recently updated) info than what is being shown in the timeline, causing a confusing mismatch until the timeline also gets updated. We should only have one source of this info, hence the need to merge the two caches.
This cache should also be used when fetching and drawing user displayable names and avatars, as a sort of "backup" option when the timeline itself doesn't have full info on all members of the room (which can happen in larger rooms where a fetch_members() command takes a very long time).
This means we also need to move the logic for applying updates to the cache to a place that gets called more frequently, e.g., the timeline event handler.
Also, for added clarity, we should rename AvatarInfo to something like UserProfileAndRoomId to be more clear, since that info does not strictly pertain to avatars.
Unknown: i'm not sure how to listen for timeline-driven updates to user profiles such that we can update our own cache, which exists separately from the matrix_sdk::Client's internal cache or the matrix_sdk_ui-driven internal cache.

for the Unknown above, we could potentially subscribe to all room updates in order to watch for events that result in an update to a user profile/avatar. But that'd be like drinking from the firehose.
We could reduce that a bit by subscribing to updates from just select rooms.

There's apparently no means to receive update streams for user profiles, even when specifically calling fetch_members() on a room. So we have no choice but to merge the caches and then always query the SDK-internal cache first, and only use our external merged user profile cache as a backup query.

Marking this closed by #106, however I decided to not merge the two caches, but rather to keep them separate.
The real key design difference was using the user profile cache as a backup when querying for user profiles for the sender of each timeline event.


Two way syncinc

Awesome! Thanks for the contribution!!
I noticed the sync is not two ways, e.g in the ES6 usage demo the input number will not reflect back into the code. Perhaps that could be considered?

I have not any idea of how to do it. Do you have any idea?

Didn't gave it too much thought, but for example it could listen to the rendered instance $data changes and compare the new state with the source code one, and update as required.

Hello. This is interesting. I would like to add my own thoughts and hope you will find them useful. However, I would like to try the thing before I say anything, so please fix the demo not appearing issue (#2). Thanks.

@QingWei-Li github looks dosen't support syntax like close #1...

Actually I didn't implement it. @reverland

I suspect whether this feature is possible now,,, with eval the whole js and even import other file's data if you decide to accept #8


Upgrade to go 1.18

Currently used Go version in go.mod file is 1.17, latest version is 1.18

go 1.17 specifies minimal go compiler version that can build the binary. Go1.18 was released just two weeks ago, and isn't universally adopted yet. SOCKSForce wouldn't benefit from new features like generics, and marginal performance optimizations don't matter for this project, since most of the time is spent in io.Copy between connections, which is the most optimized function in the whole language as is.
I'll bump the version up in a couple of months, or earlier if some new feature would benefit from generics, but it seems like this project already is feature-complete.


Update readme

Issue #, if available: N/A
Description of changes: Update README to reference Workshop and correct syntax problems
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Documentation correction


fix: deprecated image for special images

Handle hacbs_test_output result output for missing images.

Can we have please more elaborate description, It's not clear from commit msg what the fix is fixing.
Also it misses signed-off

Hi @srivickynesh !
We see a new silent error in some of our e2e tests.

/retest

/retest

/retest