Fix Record#forEach

説明 / Description
Record クラスの forEach のハンドラーに渡される局面が間違っていたのを修正する。
チェックリスト / Checklist

MUST

[x] npm test passed
[x] npm run lint was applied without warnings
[x] changes of /docs/webapp not included (except release branch)
[x] console.log not included (except script file)

RECOMMENDED (it depends on what you change)

[ ] unit test added/updated
[ ] i18n

Codecov Report
Patch coverage: 50.00% and no project coverage change.

Comparison is base (222616f) 69.95% compared to head (df8c96e) 69.95%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   69.95%   69.95%
=======================================
  Files          83       83
  Lines       17388    17388
  Branches     2318     2318
=======================================
  Hits        12163    12163
  Misses       2931     2931
  Partials     2294     2294

Files Changed
Coverage Δ

src/common/shogi/record.ts
70.17% <50.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


bin/mtd.js won't run

I'm getting an error using ES6 style imports in the mtd.js implementation.
import Rx from 'rx'
^^^^^^
SyntaxError: Unexpected token import

I've got Node version v6.2.1 installed.
Any ideas?

@continuata Issue was fixed here — https://github.com/tusharmath/Multi-threaded-downloader/commit/84fceee6
Please use version 1.5.2


Correct the correct url

This PR fixes a deprecated URL in Jupyter note to point to a valid URL.

any feedback?

@jeffxtang


Feature/icm/834 fix ingress annotation conflict in icm web chart

PR Type

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes

What Is the Current Behavior?
Issue Number: Closes #834
What Is the New Behavior?
Does this PR Introduce a Breaking Change?

[ ] Yes
[x] No

Target branch main instead of develop/icm @skiesewetter-intershop?

Target branch main instead of develop/icm @skiesewetter-intershop?

Oh, like nearly always I selected to wrong branch. But why is no new build triggered if I change the target branch?

[...] But why is no new build triggered if I change the target branch?

Our current workflow triggers don't react on such edited activity type, but by default only on open, synchronize and reopened:
https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request


Config For Dataset Fold

Hello, I'd like to know whether I can get the configuration file for training the fold dataset?

Hi! I'm currently re-organizing the codebase for the fold dataset and configs and it may take some time. I'll notify you when the codes are ready (before the notification of ICLR).

You mean Nov 05 22 03:00 AM CAT ? :)

I mean by Jan 21 '23 04:00 AM CAT.
For the GearNet-Edge model on Fold, the configs should be the same with that on EC and GO except the optimizer and scheduler. We train the model with SGD optimizer for 300 epochs and use StepLR to adjust the learning rate. You can find the detailed hyperparameters in the paper.
Could you sharing the details about the environment, command and results for running the model on EC and GO? Maybe I could help you find out the reasons why the model cannot achieve good performance.

I mean by Jan 21 '23 04:00 AM CAT.
For the GearNet-Edge model on Fold, the configs should be the same with that on EC and GO except the optimizer and scheduler. We train the model with SGD optimizer for 300 epochs and use StepLR to adjust the learning rate. You can find the detailed hyperparameters in the paper.
Could you sharing the details about the environment, command and results for running the model on EC and GO? Maybe I could help you find out the reasons why the model cannot achieve good performance.

I mean by Jan 21 '23 04:00 AM CAT.
For the GearNet-Edge model on Fold, the configs should be the same with that on EC and GO except the optimizer and scheduler. We train the model with SGD optimizer for 300 epochs and use StepLR to adjust the learning rate. You can find the detailed hyperparameters in the paper.
Could you sharing the details about the environment, command and results for running the model on EC and GO? Maybe I could help you find out the reasons why the model cannot achieve good performance.

Thank you for your kindness!!!
Here is my EC training log. I use two RTX-3090 to reproduce your work. According I change the batch size from 2/GPU two 4/GPU, and the rest parameters are the same as your config file.
I trained the EC task for 150 Epochs(In order to show the result timely, the model will show valid and test result once finished one training epoch). However, I can't get the $F1_{max}$ (81.0) in my experiment.  My f1_max is about 0.74.
May I ask you for the two-GPU training parameters? (Sorry that I can't use 4 GPU at the same time, and I am curious about the model perfermance)
EC_GearNet.log

I have some questions

In your paper, you wrote the GNN dropout is 0.1 for EC and GO, and for Fold and reaction the dropout is 0.2. But I didn't see the dropout setting for the EC dataset according to the existing config file.
Did you add the ReduceLROnPlateau scheduler for the EC and GO dataset?
For the Fold dataset, the task is a multi-class classification, and I am curious about the loss function you used to train GearNet-Edge.(Maybe you use the cross-entropy instead of the binary cross-entropy? cause the EC and GO is a multi-label task which is different from the fold dataset).
Actually the accuracy function implemented in TorchDrug is the micro-averaged. And I think the paper result is the micro-accuracy? ( In the paper, you said that "For fold and reaction classification, the performance is measured with the mean accuracy")

Thanks for providing your log! I'll try to figure out the reason. I'm now working on the ICLR rebuttal, so maybe I'll reply to you later.
To answer your questions,
1 & 2. I've simplified the codebase and removed the parts that are not neccessary. Ideally, you can achieve the performance reported in the paper with the current version. So you can refer to this repo, where the dropout and scheduler are discarded. I'll update the paper later.
3. Yes. For fold classification, you need to use the tasks.PropertyPrediction with cross entropy loss instead of tasks.MultipleBinaryClassification in TorchProtein.
4. Yes. The reported accuracy is micro-accuracy, which is commonly used in this task (see this).

Thank you for your reply! I will try more to reproduce your work. Good luck!

Hey, Recently I re-run the script for reproducing the EC tasks. This time I use 4 RTX-3090 to reproduce your work. However, I still can't achieve the f1 max (0.82). I run about 90 epochs and after 20 epochs, the f1 max is still 0.6~0.7. Here is my training log.
full_ec.log

I can share my log file with you. It's a little outdated with different names of API, but should be fine for reference. It seems that your optimization is much slower than mine. Also, here is the package versions on my cluster.
python=3.8
cuda=11.1
pytorch=1.8.0
pytorch-cluster=1.5.9
pytorch-scatter=2.0.8
rdkit=2021.09.2

Have you ever modified the training or model codes?
gearnet_edge_ec_50epoch.txt

It was kind and generous of you to share the config and log files with me， I will re-run the experiment based on your python environment. Best Wishes!

Hi! Sorry for the late response!
I re-run the code with the current codebase and get similar results as yours, too. Then, I compare it with my previous codebase and find that the ReduceLROnPlateau scheduler is very important for optimization. Therefore, I add it back in 437333f and now can reproduce the results in the paper. I attach the log file here.
gearnet_ec_50epoch_4gpu.txt
I'm really sorry for the inconvenience!

Hi!
The configs for Fold3D and GearNet_Edge_IEConv have been released.


/hosting/WopiTestFrame.aspx  Validation Application doesn`t work

Office Online Server 2016 local closed network installation.
View and Editing documents functions work successful.
Convert binary file doesn't work.
Co-authoring work only for one user (one user in two windows) only Excel.
I trying to find mistakes in my implementation in vain.
Validation Application doesn't work. I have two actions in hosting/discovery.
All of them let to server error Location:/error.html?aspxerrorpath=/hosting/WopiTestFrame.aspx
without any CorrelationId.

Hi @puch868 - the WOPI validator is not expected to work in Office Online Server. It is a cloud service-only thing. The validator was erroneously advertised in WOPI discovery in a previous OOS release but that is fixed in the version released earlier this month.

Do you have any idea ? Why binary documents conversion  doesn't work.
I send http request to http://oos.local/we/WordConvertAndEdit.aspx?WOPISrc=http://my.domain/wopi/files/6233/?access_token=xxxxxxxxxxxxxxxxx
I check the URL http://my.domain/wopi/files/6233/ it returns correct CheckFileInfo result:
{"BaseFileName":"test.doc","OwnerId":"ownerid","UserId":"userid","UserFriendlyName":"userName","Version":"2","Size":3992,"UserCanWrite":"true","SupportsUpdate":true}
And I check _http://my.domain/wopi/files/6233/contents_ it returns correct file content.
But when I try to invoke conversion  App (_http://oos.local/we/WordConvertAndEdit.aspx?WOPISrc=http://my.domain/wopi/files/6233/?access_token=xxxxxxxxxxxxxxxxx_ )
I have a blank page. In html code of this page I  can see content of conversion  dialogs
<body class="word " dir="ltr" onload="WopiConverter.SetupAndRun()">
In headers I see X-CorrelationId, and go to office online serve to read logs.
Office Online Server doesn't try to send PutRelativeFile request and doesn't try to take file from wopi host.
But editing of docx documents is successful. That uses the same WOPISrc path;
Line 23526: 11/24/2017 10:56:17.17 	w3wp.exe (0x132C)                       	0x03D4	Office Online                 	Office Online common          	ajba4	Medium  	WAC Server HttpModule: Beginning request at target [/we/WordConvertAndEdit.aspx?&ui=ru-Ru&showpagestats=0&WOPISrc=http%3A%2F%2Fmy.domain%2Fwopi%2Ffiles%2F6239%2F%3Flang%3Dru%26access_token%3DREDACTED_32] in session [62131c05-fb8b-4c75-91d7-3269efee8a73] server build [16.0.7766.8550] client build [<IP_ADDRESS>]	62131c05-fb8b-4c75-91d7-3269efee8a73 	Line 23526: 11/24/2017 10:56:17.17 	w3wp.exe (0x132C)                       	0x03D4	Office Online                 	Office Online common          	ajba4	Medium  	WAC Server HttpModule: Beginning request at target [/we/WordConvertAndEdit.aspx?&ui=ru-Ru&showpagestats=0&WOPISrc=http%3A%2F%2Fmy.domain%2Fwopi%2Ffiles%2F6239%2F%3Flang%3Dru%26access_token%3DREDACTED_32] in session [62131c05-fb8b-4c75-91d7-3269efee8a73] server build [16.0.7766.8550] client build [<IP_ADDRESS>]	62131c05-fb8b-4c75-91d7-3269efee8a73 	Line 23527: 11/24/2017 10:56:17.17 	w3wp.exe (0x132C)                       	0x03D4	ULS Logging                   	Logging Correlation Data      	xmnv	Medium  	UserSessionId=62131c05-fb8b-4c75-91d7-3269efee8a73	62131c05-fb8b-4c75-91d7-3269efee8a73 	Line 23527: 11/24/2017 10:56:17.17 	w3wp.exe (0x132C)                       	0x03D4	ULS Logging                   	Logging Correlation Data      	xmnv	Medium  	UserSessionId=62131c05-fb8b-4c75-91d7-3269efee8a73	62131c05-fb8b-4c75-91d7-3269efee8a73 	Line 23528: 11/24/2017 10:56:17.17 	w3wp.exe (0x132C)                       	0x03D4	Services Infrastructure       	Services Infrastructure Logging	a22ei	Medium  	CheckBaseDocumentInternal: {"UserLogString":"","RequiresVersion":false,"fUserCacheLookup":true,"BaseDocumentCache":true,"IsChecked":true,"IsMiniChecked":false}	62131c05-fb8b-4c75-91d7-3269efee8a73 	Line 23529: 11/24/2017 10:56:17.17 	w3wp.exe (0x132C)                       	0x03D4	Office Online                 	Office Online common          	af46w	Medium  	WACServer HttpModule: Completed request with status code [200]	62131c05-fb8b-4c75-91d7-3269efee8a73

Closing since we can't provide support for Office Online Server through this repo.


Validate: change message for getUsername

@joesepi @jrefano  cc: @be-dmitry
adobe-community/issues#5237

:+1:

:+1:

Also, we typically require @Aintaer's thumb on BeFF or NBD changes since he's of the main authors. Just a heads up for future PRs

@mrjoelkemp
Ah, no prob. I will definitely tag him for any future PRs.

:+1:

LGTM

Merged and cut a patch release for you. You'll need to update the network's version number of BeFF to 2.9.2


added report file validate code

https://github.com/Be-Secure/besecure-developer-toolkit/issues/27

Added report files validate module.
Added error message for GitHub API rate limit exceeded.

command:
bes-dev-kit validate-report-file [for check all reports]
bes-dev-kit validate-report-file REPORT_NAME  . . . REPORT_NAME [for check specific one or more than one reports]
inputs:
issue_id: int
ossp-name: str
github_username: str
branch: str

@pramit-d did you add the command in Readme.md file?

@sudhirverma will add this to readme after PR merge


Test fails can't mount app

Not sure If I've set this up wrong but I get the following error
TypeError: Cannot read properties of undefined (reading 'vueApp')
https://stackblitz.com/edit/nuxt-starter-uz1buo?file=tests%2Fapp.spec.ts
Running on windows 10 if that helps

I've been having the problem for the day, and finally found a solution. There is a mistake in the installation guide. The documentations tells you this to set the environment (step 3 in installation guide):

export default defineVitestConfig({
test: {
environment: 'nuxt',
// you can optionally set nuxt-specific environment options
// environmentOptions: {
//   nuxt: {
//     rootDir: fileURLToPath(new URL('./playground', import.meta.url)),
//     overrides: {
//       // other nuxt config you want to pass
//     }
//   }
// }
}
})

Actually, I changed to this, and it suddenly worked:

export default defineVitestConfig({
environment: 'nuxt',
// you can optionally set nuxt-specific environment options
// environmentOptions: {
//   nuxt: {
//     rootDir: fileURLToPath(new URL('./playground', import.meta.url)),
//     overrides: {
//       // other nuxt config you want to pass
//     }
//   }
}

i get this error now TypeError: Environment "nuxt" is not a valid environment. Path "C:/Users/gregf/dev/todo-nuxt/node_modules/vitest-environment-nuxt/dist/index.mjs" should export default object with a "transformMode" method equal to "ssr" or "web".

After one night, I'm not sure about my suggestion. I think moving the environment field outside of test juste make it ignored, and then vitest just fall backs to default environment.
Actually, I've just got back to happy-dom, because it fits my needs, and it works well:
test: {
    environment: "happy-dom",
}

I really doubt about my first proposition...


hugo env: show content of PATH environment variable

We have:
hugo env  #  Print Hugo version and environment info
$ hugo env
Hugo Static Site Generator v0.32.4 linux/amd64 BuildDate: 2018-01-11T09:58:37+01:00
GOOS="linux"
GOARCH="amd64"
GOVERSION="go1.9.2"

We can see hugo errors like this
ERROR 2018/01/16 11:12:59 asciidoctor / asciidoc not found in $PATH: Please install.
It would we cool, it the hugo env command would print the content of the PATH environment as well. Or maybe provide the content of $PATH in the error message above?
Motivation:
https://discourse.gohugo.io/t/asciidoctor-asciidoc-not-found-in-path/10017/3

@it-gro can this issue be closed?

can this issue be closed?
Since it would not have helped here (path within snap) and there may be security or "secrecy" downsides on printing the PATH on a public forum - I think this issue can be closed.


Add speculative sampling support

Description
Add speculative sampling support on scripts/inference/inference_hf.py and scripts/inference/gradio_demo.py.
Related Issue
None

Please also update scripts/README.md


Future2021 theme in Grav Repository is wrong linked

Hello.
The Future2021 theme recently uploaded to the Grav repository is mislinked. It is now linked to a fork of grav-theme-future in my repository, however it should be linked to this repository:
https://github.com/pmoreno-rodriguez/future2021
I just uploaded all the files to regenerate the repository as it was. And I've numbered the version number one, not to confuse it with the old Future theme.
Thank you.

I updated this but for the future please follow Grav's nomenclature standard grav-theme-<your_theme_name>.
Thanks!

Updated Future2021 to grav-theme-future2021


feat: make skipFiles of launch config configurable

The launch configuration used for attaching the debugger sets skipFiles to ["<node_internals>/**", "**/node_modules/**"] to make sure you are only debugging your own code. We experienced issues with the debugger being extremely slow to hit the first breakpoint. Experienced the same behaviour if we used this config with Jest. Setting it to an empty array resolved the issue for us.
Sometimes we also want to debug the node_modules so I made this configurable, defaults to ["<node_internals>/**", "**/node_modules/**"].

Can you use the exclude config instead? You can use it as the skipFiles in the debug setting

That's meant to exclude test files, it doesn't influence skipFiles.
How would I be able to use this setting as skipFiles in de debug setting?

How about renaming it to debugExclude

Ok, I renamed the setting to debugExclude.


Execute PluginVersionSweepCoordinator on GENERIC threadpool

Issue #, if available: #1075
Description of changes:
Change threadpool to generic to avoid blocking clusterApplierService#updateTask thread.
CheckList:

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@r1walz why are we offloading to generic threadpool? Is there any context?


Bug: Using placeholder (:any) before {locale} in routes cause incorrect $localeSegment value.

PHP Version
7.4
CodeIgniter4 Version
4.1.9
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
macOS
Which server did you use?
apache
Database
MySQL 5.6
What happened?
Incorrect $localeSegment when route is set as: $routes->get('(:any)/lang/{locale}', 'Language::index');
Using placeholder in routes cause problem in getting:
$localeSegment = array_search('{locale}', preg_split('/[\/]*((^[a-zA-Z0-9])|\(([^()]*)\))*[\/]+/m', $key), true);

at line 375.
The $localeSegment suppose to be 3 but returned value is 2
Steps to Reproduce
$routes->get('(:any)/lang/{locale}', 'Language::index');

URL: https://domain.name/test/lang/bg
App Config:
public $defaultLocale = 'en';
public $supportedLocales = ['en', 'bg',];

Expected Output
expect to set locale as 'bg'
Anything else?
No response

Can't reproduce
public $defaultLocale = 'en';
public $supportedLocales = ['en', 'uk', 'bg'];

$routes->get('(:any)/lang/{locale}', fn () => service('request')->getLocale());

test/lang/uk -> uk
test/lang/bg -> bg
test/lang/aaa -> en
(:any)/lang/{locale}
  0     1      2

@iRedds Did you test on 4.1.9?

@MGatner yep

Let me post my specific case and some debugging results:
Routes.php
$routes->group('emenu', ['namespace' => 'Emenu\Controllers'], static function ($routes) {     $routes->get('/', 'Home::index');     $routes->get('(:any)/lang/{locale}', 'Language::index'); });
App.php
`    /**
* --------------------------------------------------------------------------
* Default Locale
* --------------------------------------------------------------------------
*
* The Locale roughly represents the language and location that your visitor
* is viewing the site from. It affects the language strings and other
* strings (like currency markers, numbers, etc), that your program
* should run under for this request.
*
* @var string
*/
public $defaultLocale = 'bg';
/**
 * --------------------------------------------------------------------------
 * Negotiate Locale
 * --------------------------------------------------------------------------
 *
 * If true, the current Request object will automatically determine the
 * language to use based on the value of the Accept-Language header.
 *
 * If false, no automatic detection will be performed.
 *
 * @var bool
 */
public $negotiateLocale = false;

/**
 * --------------------------------------------------------------------------
 * Supported Locales
 * --------------------------------------------------------------------------
 *
 * If $negotiateLocale is true, this array lists the locales supported
 * by the application in descending order of priority. If no match is
 * found, the first locale will be used.
 *
 * @var string[]
 */
public $supportedLocales = ['bg', 'en', 'es', 'ru', 'fr', 'de', 'gr', 'ro'];`

Call url: https://domain.dev/emenu/pod-vishnata/lang/en
Debug result:
Router.php:
` // Reset localeSegment
$localeSegment = null;
        $key = $key === '/'
            ? $key
            : ltrim($key, '/ ');

        $matchedKey = $key; **"emenu/(.*)/lang/{locale}"**

        // Are we dealing with a locale?
        if (strpos($key, '{locale}') !== false) {
            $localeSegment = array_search('{locale}', preg_split('/[\/]*((^[a-zA-Z0-9])|\(([^()]*)\))*[\/]+/m', $key), true); **2**

            // Replace it with a regex so it
            // will actually match.
            $key = str_replace('/', '\/', $key);
            $key = str_replace('{locale}', '[^\/]+', $key); **"emenu\/(.*)\/lang\/{locale}"**
        }

IncomingRequest.php: /**
* Sets the locale string for this request.
*
* @return IncomingRequest
*/
public function setLocale(string $locale) $locale: "lang"
{
// If it's not a valid locale, set it
// to the default locale for the site.
if (! in_array($locale, $this->validLocales, true)) {
$locale = $this->defaultLocale; sets default locale back to bg
}
    $this->locale = $locale;
    Locale::setDefault($locale);

    return $this;
}`

@kpeu3u Have you tested this against the develop branch? There have been so many unreleased changes that 4.1.9 is hard to judge anymore.

@MGatner I haven't test against develop branch, i just checked line $localeSegment = array_search('{locale}', preg_split('/[/]((^[a-zA-Z0-9])|(([^()])))*[/]+/m', $key), true); for regular expression changes. Changes in method that determine locale segment refers to variable name changes only.


Default modules and configurable module list

Description
See details high level description and reasoning HERE
This ticket is more about detailed implementation details.
The KEB will need to offer only in the initial provisioning phase options for user to decide if new Kyma instance should have:

default modules only
no modules
given selected modules from given channels

API proposal

Only one new modules parameter and then we need to recognize if it is a) not provided, b) provided but empty or c) provided with modules list

or

Two new parameters: modules and defaultModules

{
  "defaultModules": "false",
  "modules": ["istio","btp-operator"]
}

and/or
{
  "defaultModules": "false",
   "modules" : [
     {"name":"istio", "channel":"fast", "customResourcePolicy":"Ignore"},
     {"name":"serverless"}
  ]
}

The defaultModules and modules parameters are optional. When not provided KEB uses default modules. When modules provided

another idea:

{
"modules": {
    "default": "",
    "list": [ ]
  }
}

AC

[ ] 1) Design API first
[ ] 2) Extends swagger and documentation about new functionality
[ ] 3) Feature flag per landscape
[ ] 4) Fail fast when user provides list of modules. We check them against moduleTemplates in the KCP environment.

implementation details: when failed, return which module was not found, and provide a list of modules that are available

[ ] 5) Adjust how we create Kyma resource. We can still use keb-config template for default modules. We still do not watch Kyma resource status. Just create.
[ ] 6) Refresh ERS on dev/stage/prod

Links

Cookbook wiki about BTP cockpit form rendering

@ukff decision made, see: https://github.com/kyma-project/control-plane/issues/3027#issuecomment-1748701364


Audio latency for HLS, any way to fix or detect latency?

Hi I'm trying to stream live video on mobile by slicing input to jpegs, and playing audio from HLS, this all works, but problem is that audio is 15-30 seconds late. Do you notice from my config that I'm doing something wrong? Is there an option to detect how late audio is so that I can somehow sync images with sound? Thanks in advance!
My config:
 http {
        server {
         listen       8081;
        server_name  localhost;

        location / {
            root   html;
            index  index.html index.htm;
        }
        location /hls {
        types {
            application/vnd.apple.mpegurl m3u8;
            video/mp2t ts;
        }
        alias /dev/shm/hls;
    add_header Cache-Control no-cache;
    }

    location /stat {
        rtmp_stat all;
        rtmp_stat_stylesheet stat.xsl;
    }

    location /stat.xsl {
        root /usr/local/src/nginx-1.6.2/nginx-rtmp-module;
}
}
rtmp {
    server {
        listen 1935;
        application live {
            live on;
            wait_video on;
            wait_key on;

            exec_push mkdir -p /dev/shm/feeds/$name;

        exec_push /usr/bin/ffmpeg -i rtmp://<IP_ADDRESS>/live/$name -vf fps=120/60 /dev/shm/feeds/$name/$name_%08d.jpg;
            exec_push /usr/bin/ffmpeg -i rtmp://<IP_ADDRESS>/live/$name -vn -acodec libfdk_aac -vcodec copy -tune zerolatency -analyzeduration 0 -f flv rtmp://<IP_ADDRESS>/hls/$name;
        }
        application hls {
            live on;
            hls on;
            hls_path /dev/shm/hls;
            hls_fragment 2s;
            hls_playlist_length 8s;
            hls_sync 300ms;
      }
        application audio {
            live on;
        }
    }
 }

@AVasic Hi, I have the same request, have you figured out how to achieve that? Thx!

Try tune ffmpeg input params for images:
exec_push /usr/bin/ffmpeg -i "rtmp://<IP_ADDRESS>/live/$name live=1 buffer=8000" ...
and for audio:
exec_push /usr/bin/ffmpeg -i "rtmp://<IP_ADDRESS>/live/$name live=1 buffer=300" ...


blendMode can be changed when filter applies.

blendMode can be changed when filter applies. No changes in current filters are required.

However, demo from https://github.com/pixijs/pixi.js/issues/1598 wont work on that, because Multiply operation is not additive. Those small squares in intersections are black if you dont apply filter:

how it works:
container.filters = [bloomFilter];
container.filterBlendMode = PIXI.BLEND_MODES.ADD;

That patch has solved this case: http://www.html5gamedevs.com/topic/19029-cant-set-blendmode-with-filters/

By the way, PIXI.Container doesnt have blendMode on its own , so filterBlendMode can be good solution for two other cases:

blendModes that arent supported by glBlendFunc

use of globalCompositionMode in canvas fallback on whole container

This PR can't be merged for a couple reasons:

It creates new properties on the object during runtime, which destroys the hidden class optimizations. Any property on the object must be created at constructor time.
I don't think this is the right way to do this, You have render target access in the apply methods of filters, I wonder if it makes sense for the filter to be applying a blend mode there.

Help me with 1, I know you can change PR before you apply it.
As for 2, I dont want to change other filters, and for example, BlurFilter does apply two times.
I thought about that stuff for 5 days already, and I dont see other solutions. BlendMode is using data from renderTarget  , its not a filter, its a special case.
Also, to implement all standart blendModes we'll have to use "readPixels", we cant avoid that.

what do you guys think about putting the filter blend mode property as a property on the filter as it feels like its more of a filter specific thing?

It makes sence only for last filter in the list, and we have to implement that thing inside FilterManager, so filters will be able to call that special method which is taking care of blendMode.


Generic icon component with typescript

Hi. please provide an example of typescript code.

@celsoft For which package?

@celsoft For which package?

lucide-react

@celsoft I'm not sure what you exactly want.
We have some exported type you can you use but the rest of the examples that are provided on https://lucide.dev/docs/lucide-react is also valid typescript.
Or do you mean we need to give examples how you can use lucide types in your typescript project?
If so, can you provide a use-case you currently missing in our current documentation.
This is our typescript declaration file:
import { SVGAttributes } from 'react'

declare module 'lucide-react'

// Create interface extending SVGProps
export interface LucideProps extends Partial<React.SVGProps<SVGSVGElement>> {
    size?: string | number
}

export declare const createReactComponent: (iconName: string, iconNode: any[]) => (props: LucideProps) => JSX.Element;

export type Icon = React.FC<LucideProps>;

// Generated icons
export declare const Accessibility: (props: LucideProps) => JSX.Element;
export declare const Activity: (props: LucideProps) => JSX.Element;
export declare const AirVent: (props: LucideProps) => JSX.Element;
export declare const Airplay: (props: LucideProps) => JSX.Element;
export declare const AlarmCheck: (props: LucideProps) => JSX.Element;
export declare const AlarmClockOff: (props: LucideProps) => JSX.Element;
// ... All icons

Hi. I need to load icons by name in a loop.

Thank you

Does not work anymore:
TS2551: Property AArrowDown does not exist on type
{     'a-arrow-down': () => Promise;     'a-arrow-up': () => Promise;     'a-large-small': () => Promise<...>;     ... 1446 more ...;     'zoom-out': () => Promise<...>; }
. Did you mean arrow-down?


On Cloudflare Pages only production branch works, but any other fails

Would you know what is happening here? On Cloudflare Pages only production branch works, but any other fails with this error.
error calling partial: "/opt/buildhome/repo/themes/tailbliss/layouts/partials/head.html:24:47"
<pre class="c_jh c_bu c_ik c_il c_nt c_nu c_de c_jv c_oz c_pa c_pb c_fo c_fp c_nv c_bw c_pc">

22:39:38.139 | Building sites … ERROR 2023/04/20 20:39:38 render of "page" failed: execute of template failed: template: _default/single.html:5:7: executing "_default/single.html" at <partial "head.html" ...>: error calling partial: "/opt/buildhome/repo/themes/tailbliss/layouts/partials/head.html:24:47": execute of template failed: template: partials/head.html:24:47: executing "partials/head.html" at <resources>: can't evaluate field PostProcess in type interface {}
-- | --
22:39:38.139 | ERROR 2023/04/20 20:39:38 render of "taxonomyTerm" failed: execute of template failed: template: _default/list.html:5:7: executing "_default/list.html" at <partial "head.html" ...>: error calling partial: "/opt/buildhome/repo/themes/tailbliss/layouts/partials/head.html:24:47": execute of template failed: template: partials/head.html:24:47: executing "partials/head.html" at <resources>: can't evaluate field PostProcess in type interface {}
22:39:38.139 | ERROR 2023/04/20 20:39:38 render of "home" failed: execute of template failed: template: index.html:5:7: executing "index.html" at <partial "head.html" ...>: error calling partial: "/opt/buildhome/repo/themes/tailbliss/layouts/partials/head.html:24:47": execute of template failed: template: partials/head.html:24:47: executing "partials/head.html" at <resources>: can't evaluate field PostProcess in type interface {}
22:39:38.164 | Total in 35 ms
22:39:38.164 | Error: Error building site: failed to render pages: render of "taxonomyTerm" failed: execute of template failed: template: _default/list.html:5:7: executing "_default/list.html" at <partial "head.html" ...>: error calling partial: "/opt/buildhome/repo/themes/tailbliss/layouts/partials/head.html:24:47": execute of template failed: template: partials/head.html:24:47: executing "partials/head.html" at <resources>: can't evaluate field PostProcess in type interface {}
22:39:38.172 | Failed: build command exited with code: 255
22:39:38.927 | Failed: error occurred while running build command

</pre>

I accidentally forgot to add newer HUGO_VERSION env var to the non-production builder.


Disallowed range operator after route set name in <filter>

[ ]  Allow range operator after any route set in filter.

A route set name can also be followed by one of the operators '^-',
'^+', example, { <IP_ADDRESS>/8, <IP_ADDRESS>/8 }^+ equals { <IP_ADDRESS>/8^+,
<IP_ADDRESS>/8^+ }, and AS1^- equals all the exclusive more specifics of
routes originated by AS1.

I just doublechecked this rule. We do comply with them.
The large number of warnings I see are "route set names" followed by the other operators—^n and ^m-n. Base on this rule in the RFC, those are not allowed, but apparently, they are used everywhere.
Originally posted by @SichangHe in https://github.com/SichangHe/internet_route_verification/issues/41#issuecomment-1703671305

I counted 4724 of them by parsing the log.
disallowed_range_operator_in_filter.txt


fix: Update the Wallets page to put bank accounts at top.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/46242
PROPOSAL: https://github.com/Expensify/App/issues/46242#issuecomment-2251546887
Tests

Go to /settings/wallet
Verify the design with the mock up attached below

[x] Verify that no errors appear in the JS console

Offline tests

Go to /settings/wallet
Verify the design with the mock up attached below

QA Steps

Go to /settings/wallet
Verify the design with the mock up attached below

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Could we get some mobile screenshots as well? 😄

Let us know when this is ready for review. Also, do you have the correct design asset for this? I think the screenshot in the original comment is actually just a mockup from Figma, right?

Sounds good, here is the asset you need which should be shown at 262x152: emptystate__big-vault.svg.zip

According to the mock in this issue the currency should be using our Expensify New Kansas typeface. I'm not 100% sure the exact style/class to apply but it's the one we use on a report/expense screen.

Here's the mock from @shawnborton :

Yup, I'm using our standard h1 styles in Figma for that one. But my thinking is to make it look a bit more like the amount field in the expense view elsewhere in the app:

...which uses h2, so maybe we just use h2 here and we get this:

@trjExpensify @anmurali @danielrvidal @kevinksullivan did we decide that we want the assigned cards section to be at the very bottom, or right below bank accounts?

I'm not entirely sure how contributors can enable a wallet. @joekaufmanexpensify do you have any ideas there?
From my testing though, it looks like the transfer balance page is working as expected:
https://github.com/user-attachments/assets/e3a61785-f49b-4c71-9cc9-fce5c0b37726

I think h2 so it's consistent with how the expense view displays totals.

@shawnborton I don't think there's a way for them to test wallets now unless they have a US address and SSN. We are working on creating a set of test wallet credentials that can be used here.

I would say for titles, we do not want the trailing period.

I will bump them internally.

I will review once the latest batch of requested changes are addressed. I'll check back on Monday.

Where can I find updated screenshots that also included an assigned cards section?

Okay, let me spin up a test build and I can test it on my account.

Looks good from a design perspective. I think this can be merged!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.18-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.18-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Is pt suitable for simple real-time rendering? Can this be implemented?

It would be great to have a simple real time rendering method on the CPU in pure Go that could be used to preview a model before rendering, is this feasible? When I say real time I mean rendering to a image type in a decent fraction of a second.

Not really. Most renders can take quite a while. Most of the 2560x1440px examples on the README took 30+ minutes, for example.

Even using GPU resources and a very much simplified path tracer it takes a while to render with path tracing: this is the best I can find at doing "interactive" rendering. It's quite a lot to expect a pure CPU implementation could keep up.

Am wondering if cycle based rendering helps ?
This is when the precision is lowered.
The other way is to allow tile based rendering. At least this allows speeding things up by throwing more servers at the problem.

"Throwing more servers at it" is already easily doable. Each server can produce its own image and then the images can be combined. Since each server starts with a different random seed, the sampling will be just as if a single machine did 2x, 3x, etc the work.
This is what the combine script in the repo is for. :)

Tiles based is different from what you do now ? To render one image 50
times faster, can I use 50 servers ?
I saw the combine script and was wondering...
On Fri, 5 Feb 2016, 03:00 Michael Fogleman<EMAIL_ADDRESS>wrote:

"Throwing more servers at it" is already easily doable. Each server can
produce its own image and then the images can be combined. Since each
server starts with a different random seed, the sampling will be just as if
a single machine did 2x, 3x, etc the work.
This is what the combine script in the repo is for. :)
—
Reply to this email directly or view it on GitHub
https://github.com/fogleman/pt/issues/11#issuecomment-180170516.

@joeblew99 See my slides on path tracing: https://speakerdeck.com/fogleman/path-tracing
Specifically the section on Noise. Maybe that will help you understand.

Yes i saw it thanks. I see what it is
This is all super but can I please get a straight answer to the original
question pretty please ?????
On Fri, 5 Feb 2016, 14:29 Michael Fogleman<EMAIL_ADDRESS>wrote:

@joeblew99 https://github.com/joeblew99 See my slides on path tracing:
https://speakerdeck.com/fogleman/path-tracing
Specifically the section on Noise. Maybe that will help you understand.
—
Reply to this email directly or view it on GitHub
https://github.com/fogleman/pt/issues/11#issuecomment-180380389.

It's just that I have used many rendering engines and yet to see anyone
solve the shared memory model aspects for distributed rendering of photonic
ray tracing.
On Fri, 5 Feb 2016, 17:35 Joe Blue<EMAIL_ADDRESS>wrote:

Yes i saw it thanks. I see what it is
This is all super but can I please get a straight answer to the original
question pretty please ?????
On Fri, 5 Feb 2016, 14:29 Michael Fogleman<EMAIL_ADDRESS>wrote:

@joeblew99 https://github.com/joeblew99 See my slides on path tracing:
https://speakerdeck.com/fogleman/path-tracing
Specifically the section on Noise. Maybe that will help you understand.
—
Reply to this email directly or view it on GitHub
https://github.com/fogleman/pt/issues/11#issuecomment-180380389.

@joeblew99

To render one image 50 times faster, can I use 50 servers?

Yes.

Tiles based is different from what you do now?

It is different.
If you wanted to run 256 samples per pixel, you could:

Run 256 on 1 machine
Run 128 on 2 machines
Run 64 on 4 machines

Etc.
Then you literally average the images and get a result equivalent to the full 256 samples.

I would like to try it. Will have a look at see if the code has some sort
of render director.
On Fri, 5 Feb 2016, 23:27 Michael Fogleman<EMAIL_ADDRESS>wrote:

@joeblew99 https://github.com/joeblew99
To render one image 50 times faster, can I use 50 servers?
Yes.
Tiles based is different from what you do now?
It is different.
If you wanted to run 256 samples per pixel, you could:

Run 256 on 1 machine
Run 128 on 2 machines
Run 64 on 4 machines

Etc.
Then you literally average the images and get a result equivalent to the
full 256 samples.
—
Reply to this email directly or view it on GitHub
https://github.com/fogleman/pt/issues/11#issuecomment-180619881.


Wrong cmdlet specified

Hi,
In the section 'Install and configure the proxy service', steps 5 and 7 reference the wrong cmdlet for testing the proxy. Both specify to use 'Test-AzureADPasswordProtectionDCAgentHealth' but the correct cmdlet is 'Test-AzureADPasswordProtectionProxyHealth'. As the DC agent is not present on the proxy, the 'Test-AzureADPasswordProtectionDCAgentHealth' errors.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 23e000f0-84ce-7ec7-e5ed-4bd9c49f5d49
Version Independent ID: e636b9d1-be81-0f00-97c4-ff4fa9078be3
Content: Deploy on-premises Azure AD Password Protection - Microsoft Entra
Content Source: articles/active-directory/authentication/howto-password-ban-bad-on-premises-deploy.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@Hindy-UK
Thanks for your feedback! We will investigate and update as appropriate.

@Hindy-UK someone fixed it recently #please-close


fix tests

PR to be merged after JuliaGeo/GeoJSON.jl#68 is merged. It fixes JuliaEarth/GeoTables.jl#24, to summarize the errors we obtained were because:

There was a bug in GeoJSON.jl that was saving MultiLineStrings as Polygons.
The file ne_110m_land.shp needs Float64 precision when reading with GeoJSON as suggested by @eliascarv .

Codecov Report

Merging #27 (6b7a528) into master (c4aa434) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   91.20%   91.20%
=======================================
  Files           3        3
  Lines         125      125
=======================================
  Hits          114      114
  Misses         11       11


Add an option for macro keywords to replace the original schema

What version of Ajv you are you using?
Latest
What problem do you want to solve?
What do you think is the correct solution to problem?
While struggling to implement a keyword that would remove invalid entries from a JSON, I realized that it would be great if macro keywords had an option to replace/modify the original schema rather than extend it. That would allow for greater flexibility when implementing custom keywords – without having to resort to code generation. With such an option in place, the aforementioned keyword could have been implemented as follows:
ajv.addKeyword({
  keyword: 'removeInvalid',
  replace: true,
  macro: (schema, parentSchema) => {
    const originalSchema = { ...parentSchema };
    delete originalSchema.removeInvalid;
    return { _removeInvalid: originalSchema };
  }
});

ajv.addKeyword({
  keyword: '_removeInvalid',
  modifying: true,
  compile: (schema, parentSchema) => {
    const validate = ajv.compile(schema);
    return function(data, ctx) {
      if (!validate(data)) {
        delete ctx.parentData[ctx.parentDataProperty];
      }
      return true;
    }
  }
});

Example schema:
{
  "type": "object",
  "properties": {
    "phone": {
      "type": "string",
      "pattern": "^\\+?\\d+$",
      "removeInvalid": true
    }
  }
}

Will you be able to implement it?
I'm not that fluent in TypeScript, unfortunately.

I don't think it should be supported, sorry. I will keep it open to see any other comments.

This would be handy if we wanted to use the format keyword for type coercion 😢


failed to compile tensorflow (V2.4_RC4) in debug mode

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Debian 4.19.117.bsk.4
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version: 2.4_rc4
Python version:Python 3.7.3
Installed using virtualenv? pip? conda?: build from source
Bazel version (if compiling from source):bazel 3.1.0
GCC/Compiler version (if compiling from source):gcc (Debian 8.3.0-6) 8.3.0
CUDA/cuDNN version: Cuda compilation tools, release 11.1, V11.1.105
GPU model and memory: V100(32G), host memory>120GB

Describe the problem
I want to compile Tensorflow from source code, using the debug model, when I pass args to the bazel, it ends up with failure as below:
ERROR: /home/chengyang/src/tf-src/tensorflow_2.4_rc4/tensorflow/BUILD:724:1: Linking of rule '//tensorflow:libtensorflow_framework.so.2.4.0' failed (Exit 1): crosstool_wrapper_driver_is_not_gcc failed: error executing command
(cd /home/chengyang/.cache/bazel/_bazel_zhoudongyan.daniel/b440c4e0619e08e4030082228cc9dfe0/execroot/org_tensorflow &&
exec env -
CUDA_TOOLKIT_PATH=/usr/local/cuda-11.1
GCC_HOST_COMPILER_PATH=/usr/bin/x86_64-linux-gnu-gcc-8
LD_LIBRARY_PATH=/opt/XXX/jdk/jre/lib/amd64/server:/opt/XXX/lib/native:/opt/XXX/lib/native/ufs:/opt/XXX/lib/native:/opt/XXX/lib/native:/opt/XXX/lib:/usr/local/cuda/compat:/usr/local/cuda/lib64:
PATH=/home/chengyang/.cache/bazelisk/downloads/bazelbuild/bazel-3.1.0-linux-x86_64/bin:/home/chengyang/software/bazelisk:/usr/local/cuda/bin:/home/chengyang/system_op/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/tige
r/arnold/arnold_entrypoint/tools:/opt/XXX/bin:/opt/XXX/bin:/home/chengyang/.local/bin
PWD=/proc/self/cwd
PYTHON_BIN_PATH=/usr/bin/python3
PYTHON_LIB_PATH=/usr/lib/python3/dist-packages
TF2_BEHAVIOR=1
TF_CONFIGURE_IOS=0
TF_CUDA_COMPUTE_CAPABILITIES=3.5,7.0
TF_NEED_CUDA=1
external/local_config_cuda/crosstool/clang/bin/crosstool_wrapper_driver_is_not_gcc @bazel-out/k8-opt/bin/tensorflow/libtensorflow_framework.so.2.4.0-2.params)
Execution platform: @local_execution_config_platform//:platform
/usr/bin/ld: bazel-out/k8-opt/bin/tensorflow/stream_executor/cuda/libcublas_plugin.pic.lo(cuda_blas.pic.o): relocation R_X86_64_PC32 against undefined symbol `_ZN15stream_executor3gpu12_GLOBAL__N_120CUDABlasLtMatmulPlan14kMaxBatchCountE' can n
ot be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: nonrepresentable section on output
collect2: error: ld returned 1 exit status
Target //tensorflow/compiler/xla/tools:run_hlo_module failed to build
INFO: Elapsed time: 111.012s, Critical Path: 93.19s
INFO: 2174 processes: 2174 local.
FAILED: Build did NOT complete successfully
Provide the exact sequence of commands / steps that you executed before running into the problem
bazel build //tensorflow/compiler/xla/tools:run_hlo_module  --config=v2 --config=noaws --config=nogcp --config=nohdfs --config=cuda --compilation_mode=dbg --strip=never --copt="-g" --cxxopt="-g" --copt="-O0" --cxxopt="-O0"  --verbose_failures
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
I have successfully compiled the source code with --compilation_mode=opt --strip=never --copt="-g" --cxxopt="-g"  --verbose_failures,  however, it turns out to be that "-O2" is enabled, and I hope to pass "-O0" to track the execution with GDB.

@NEWPLAN
Can you please try with CUDA 11.0? TF 2.4 (and nightly) is built and tested against CUDA 11.0, not 11.1.

@NEWPLAN
Can you please try with CUDA 11.0? TF 2.4 (and nightly) is built and tested against CUDA 11.0, not 11.1.

Thanks for your reply, I would follow your suggestion to recompile it. Additionally, what are the expected arguments passing to the bazel?  That's how can I disable the "-O2" flag in debug mode?

@NEWPLAN  Have you tried with the dbg conf? See https://github.com/tensorflow/tensorflow/issues/27744

@NEWPLAN Have you tried with the dbg conf? See #27744

did not try all the approaches mentioned in the link, but compiling the src codes with dbg has been practiced. Still, got the same errors as above.

As --compilation_mode=opt --strip=never Is already working for you have you tried the same with dbg instead of opt?

As --compilation_mode=opt --strip=never Is already working for you have you tried the same with dbg instead of opt?

sure, when repalcing the opt with dbg, the compiling is failed (as above), however, using the opt means the src code would be optimized by the compiler such as -O2, which is conflicted with debugging the code step by step.

Ok Just to be sure about the reproducibilty can you try in the devel image (you have already the source there) https://www.tensorflow.org/install/docker?hl=en?

Ok Just to be sure about the reproducibilty can you try in the devel image (you have already the source there) https://www.tensorflow.org/install/docker?hl=en?

sure, thanks for your help, I would like to try it soon.

Hi, I have tried the new command to compile the tensorflow in debug mode, the compile cmd is
" bazel build //tensorflow/tools/pip_package:build_pip_package  --config=v2 --config=noaws --config=nogcp --config=nohdfs --config=cuda --compilation_mode=dbg --strip=never --copt="-fPIC" --cxxopt="-fPIC"  --copt="-O0" --cxxopt="-O0" --dynamic_mode=off --verbose_failures --linkopt=-L/usr/local/cuda/lib64 --linkopt=-lcudart"
the log is shown as follows.
"tf-src/tensorflow_2.4_rc4/tensorflow/BUILD:724:1: Linking of rule '//tensorflow:libtensorflow_framework.so.2.4.0' failed (Exit 1): crosstool_wrapper_driver_is_no
t_gcc failed: error executing command
(cd /home/tiger/.cache/bazel/_bazel_zhoudongyan.daniel/b440c4e0619e08e4030082228cc9dfe0/execroot/org_tensorflow &&
exec env -
CUDA_TOOLKIT_PATH=/usr/local/cuda-11.1
GCC_HOST_COMPILER_PATH=/usr/bin/x86_64-linux-gnu-gcc-8
LD_LIBRARY_PATH=/opt/tiger/yarn_deploy/jdk/jre/lib/amd64/server:/opt/tiger/yarn_deploy/hadoop_current/lib/native:/opt/tiger/yarn_deploy/hadoop_current/lib/native/ufs:/opt/tiger/yarn_deploy/hadoop/lib/native:/opt/tiger/yarn_deploy/hadoop_current/lib/native:/opt/tiger/yarn_deploy/hadoop_current/lzo/lib:/usr/local/cuda/compat:/usr/local/cuda/lib64:
PATH=/home/tiger/.cache/bazelisk/downloads/bazelbuild/bazel-3.1.0-linux-x86_64/bin:/home/tiger/chengyang/software/bazelisk:/usr/local/cuda/bin:/home/tiger/system_op/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/tiger/arnold/arnold_entrypoint/tools:/opt/tiger/yarn_deploy/hadoop/bin:/opt/tiger/yarn_deploy/hive/bin:/home/tiger/.local/bin
PWD=/proc/self/cwd
PYTHON_BIN_PATH=/usr/bin/python3
PYTHON_LIB_PATH=/usr/lib/python3/dist-packages
TF2_BEHAVIOR=1
TF_CONFIGURE_IOS=0
TF_CUDA_COMPUTE_CAPABILITIES=3.5,7.0
TF_NEED_CUDA=1
external/local_config_cuda/crosstool/clang/bin/crosstool_wrapper_driver_is_not_gcc @bazel-out/k8-dbg/bin/tensorflow/libtensorflow_framework.so.2.4.0-2.params)
Execution platform: @local_execution_config_platform//:platform
/usr/bin/ld: bazel-out/k8-dbg/bin/tensorflow/stream_executor/cuda/libcublas_plugin.lo(cuda_blas.pic.o): relocation R_X86_64_PC32 against undefined symbol `_ZN15stream_executor3gpu12_GLOBAL__N_12
0CUDABlasLtMatmulPlan14kMaxBatchCountE' can not be used when making a shared object; recompile with -fPIC"

Hi, I have tried the new command to compile the tensorflow in debug mode, the compile cmd is
" bazel build //tensorflow/tools/pip_package:build_pip_package --config=v2 --config=noaws --config=nogcp --config=nohdfs --config=cuda --compilation_mode=dbg --strip=never --copt="-fPIC" --cxxopt="-fPIC" --copt="-O0" --cxxopt="-O0" --dynamic_mode=off --verbose_failures --linkopt=-L/usr/local/cuda/lib64 --linkopt=-lcudart"
the log is shown as follows.
"tf-src/tensorflow_2.4_rc4/tensorflow/BUILD:724:1: Linking of rule '//tensorflow:libtensorflow_framework.so.2.4.0' failed (Exit 1): crosstool_wrapper_driver_is_no
t_gcc failed: error executing command
(cd /home/tiger/.cache/bazel/_bazel_zhoudongyan.daniel/b440c4e0619e08e4030082228cc9dfe0/execroot/org_tensorflow &&
exec env -
CUDA_TOOLKIT_PATH=/usr/local/cuda-11.1
GCC_HOST_COMPILER_PATH=/usr/bin/x86_64-linux-gnu-gcc-8
LD_LIBRARY_PATH=/opt/tiger/yarn_deploy/jdk/jre/lib/amd64/server:/opt/tiger/yarn_deploy/hadoop_current/lib/native:/opt/tiger/yarn_deploy/hadoop_current/lib/native/ufs:/opt/tiger/yarn_deploy/hadoop/lib/native:/opt/tiger/yarn_deploy/hadoop_current/lib/native:/opt/tiger/yarn_deploy/hadoop_current/lzo/lib:/usr/local/cuda/compat:/usr/local/cuda/lib64:
PATH=/home/tiger/.cache/bazelisk/downloads/bazelbuild/bazel-3.1.0-linux-x86_64/bin:/home/tiger/chengyang/software/bazelisk:/usr/local/cuda/bin:/home/tiger/system_op/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/tiger/arnold/arnold_entrypoint/tools:/opt/tiger/yarn_deploy/hadoop/bin:/opt/tiger/yarn_deploy/hive/bin:/home/tiger/.local/bin
PWD=/proc/self/cwd
PYTHON_BIN_PATH=/usr/bin/python3
PYTHON_LIB_PATH=/usr/lib/python3/dist-packages
TF2_BEHAVIOR=1
TF_CONFIGURE_IOS=0
TF_CUDA_COMPUTE_CAPABILITIES=3.5,7.0
TF_NEED_CUDA=1
external/local_config_cuda/crosstool/clang/bin/crosstool_wrapper_driver_is_not_gcc @bazel-out/k8-dbg/bin/tensorflow/libtensorflow_framework.so.2.4.0-2.params)
Execution platform: @local_execution_config_platform//:platform
/usr/bin/ld: bazel-out/k8-dbg/bin/tensorflow/stream_executor/cuda/libcublas_plugin.lo(cuda_blas.pic.o): relocation R_X86_64_PC32 against undefined symbol `_ZN15stream_executor3gpu12_GLOBAL__N_12
0CUDABlasLtMatmulPlan14kMaxBatchCountE' can not be used when making a shared object; recompile with -fPIC"

Thanks for all of the help I have received. I just find a practical solution to my problem, i.e., compile the tensorflow with "--per_file_copt". I would like to share with the community and hope it works  as expected.
bazel build //tensorflow/compiler/xla/python:xla_client --per_file_copt="//tensorflow/compiler/.*\.cc,-//tensorflow/stream_executor/.*\.cc@-g,-O0"  --per_file_copt="//tensorflow/stream_executor/.*\.cc@-g,-O1" --config=v2 --config=noaws --config=nogcp --config=nohdfs --config=cuda --compilation_mode=dbg --strip=never -c opt --copt="-m64" --cxxopt="-m64" --copt="-mcmodel=large" --cxxopt="-mcmodel=large" --config=avx2_linux --config=xla --verbose_failures


[SUPPORT] undrop table

Specifies the identifier for the table to restore. If the identifier contains spaces or special characters, the entire string must be enclosed in double quotes. Identifiers enclosed in double quotes are also case-sensitive.

Restoring tables is only supported in the current schema or current database, even if the table name is fully-qualified.
If a table with the same name already exists, an error is returned.
UNDROP relies on the Snowflake Time Travel feature. An object can be restored only if the object was deleted within the. The default value is 24 hours.

https://docs.snowflake.com/en/sql-reference/sql/undrop-table.html

@melin Thank you for raising this feature request!  I created a Jira ticket to track the work and let's follow up there: HUDI-4891.  Closing this support ticket.


fix: Use new .build.slsa extension

Fixes #2265 #2264 #2263 #2262 #2261 #2260 #2259

BTW, I think most of the builders so far create attestation names like foo.intoto which means our files will be foo.intoto.build.slsa.

BTW, I think most of the builders so far create attestation names like foo.intoto which means our files will be foo.intoto.build.slsa.

+1. Created https://github.com/slsa-framework/slsa-github-generator/issues/2273 for tracking.


Can't figure out how to make  open the file but at the same time close the sidebar

Read through the doc and tried changing the  mapping to 'focused' and 'open_drop' but that didn't work. Any suggestions? Sorry to create an issue about this, but I really couldn't figure it out.

Keep it mapped to "open" but add this instead.
https://github.com/nvim-neo-tree/neo-tree.nvim/wiki/Recipes#auto-close-on-open-file
I'd prefer to ask these kinda questions in discussions but you are nothing wrong to ask here as well ;)

You should also consider that if you want to auto close the sidebar every time you open a file, maybe you don't really want to use a sidebar at all. The "current" or "float" positions might be better suited to your workflow.

Thanks @pysan3, thats perfect! I'll post these kinds of things to discussions in the future.
@cseickel Great suggestion! You actually made me change my mind, I ended up using the "float" position, thanks.
Closing, issue.


Extract resources when saving

I have a project where I want to save specific components and resources.
Components was simple enough to get working by providing my own SaveFilter starting from deny_all() (Something like #5 would make this much better!)
But I also want to save a resource which led me to create a custom save() function with these additional lines.
    builder.with_resource_filter(filter.resource);
    builder.extract_resources();

It would be great if moonshine_save could do this out of the box

Thanks for raising this. I pushed a CL which lets you specify resources in SaveFilter. This should simplify things for you since you don't need to manually deal with the DynamicSceneBuilder.
But it's still far from an ideal solution. The problem is that we have no way to "mark" resources like we can mark entities with Save component. On top of that, some Bevy components derive Reflect but aren't serializable, so I can't rely on types which implement Reflect either.
I'm thinking of introducing an .add_saved_resource function to flag and register saved resources in a single call, but this wouldn't be customizable per save pipeline.
I'm gonna keep the issue open until I figure out a better solution to this.

Thanks for the blazing fast fix!
The deny_all() seems like only sensible default for resources to stick with the philosophy of you explicitly pick want you want to save. Although by a different mechanism. There could for sure be serialisable resources I don't care about from other parts of the system.
I quite liked the of the save pipeline builder which could then have something like a with_resource_filter(.., filter: SceneFilter)

In v0.3.2, you can use save_default().include_resource::<R>().into_file("example.ron") to include resources into a save pipeline.


[Bug] The "Submit Anyways" button doesn't work.

Describe the bug
In the latest updates to UNICEF Mexico, if you fill in the Child Follow up, Pregnancy Follow up, or Lactating Mother Follow up visit, don't fill in all the questions, and try to submit anyway, the submit anyway is not available. Can we please add it back?

To Reproduce
Steps to reproduce the behavior:

Go to Contigo app and pick a already registered caregiver or child
Select Follow up visit
Fill some of the questions and then hit "Submit", no "Submit any way" is available, but it use to be.

Expected behavior
If I don't fill all the questions in the follow up visit forms and hit submit, the submit anyway will appear.
Additional context
Add any other context about the problem here.
Implementation plan

Bulleted pointed list of notes on the plan to address this issue
Can be added, expanded, and modified by the assignee

This is broken but we need to figure out where it was configured. This is a product issue

Hi @f-odhiambo cc: @msschroeder
I believe we have default hidden the "submit anyway" button from the product if there are mandatory fields unfilled. There was an issue I created here #3503 that was worked on by Aleem for the WB demo app (based on GIZ EIR).
Fikri worked on this https://github.com/opensrp/fhircore/issues/3549 and it seems to still be configurable by form, so you could still show the dialogue & "submit anyway" option if non-mandatory fields are left blank.
We should not enable the "submit anyway" button for UNICEF Mexico if there are any mandatory fields. Hope that clarifies things.


x86 build would fail because Zeranoe builds don't exist anymore

Context:

https://twitter.com/Zeranoe/status/1300596971934224385
https://github.com/jellyfin/jellyfin-server-windows/blob/0945956643a7d932b5f3d25a79dd9ceafeb5010c/build-jellyfin.ps1#L64

Possible solutions:

Remove x86 building completely, as the docs mention it's deprecated anyways
Add x86 Windows builds to https://github.com/jellyfin/jellyfin-ffmpeg/releases

Note that I haven't tried if they would fail for another reason, too.

Ah thank you for bringing this up - I believe we package our own at this moment (though of course we should document that better).


feat: wire up idle opportunities [WIP]

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #3315

PR #3338

PR #3316

PR #3343

PR #3345

PR #3355   👈

PR #3342

This comment was auto-generated by Graphite.

Opening for early review - will give this one a last self-review pass and testing tomorrow but the guts of it have been tested


Minor tweaks to Classic Kerberos Delegation Check.

Following Harry's example, created a separate function for Classic Kerberos Delegation check.

Found some typos. Cancelling. Will create new pull request.


[BugFix] Fix grascale upgrade between main and lower version

TOlapScanNode.columns_desc should be optional instead of required.
BTW, some codes in BE use thrift_olap_scan_node.columns_desc directly. This is safe, because the default value of thrift_olap_scan_node.columns_desc is an empty std::vector<>.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE Incremental Coverage Report]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/planner/OlapScanNode.java
2
2
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/planner/OlapScanNode.java
2
2
100.00%
[]

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)


Rename and improved language

Hello again, I have completed the Chinese Traditional translation. OAO
I think the file should be renamed to zhtw.

The project is no longer active, so I decided to close this.


geom2d/intersectLineCircle.m

It seems you forgot to update the help string.
Also I applied minor fixes to mixtures of spaces and tabs in several lines.
I fixed my doc to use NaN instead of NA. Has matlab not implemented NA yet?

Hi,
I'm migrating the repository to a new "mattools" organisation, so the reference repository for matGeom will now be https://github.com/mattools/matGeom.
I have updated the doc in the commit bdfb0138fc47257caa2f5b1d00cc846a6cef10e4
For what I know, Matlab supports NaN as part of IEEE norm, but does not include specific "NA" logic. See the doc: https://fr.mathworks.com/help/matlab/ref/nan.html

Hi,
Good, it seems github redirected my fork automatically to the new repo.
I am working to try to update the Octave fork automatically with matGeom (as much as possible), this will reduce delays between the two.

Hi,
Great! I made some modifs yesterday and apparently the redirection is working well.
ok for updates.
cheers.


Add support for sepolia

Let me know if i have to change something else^^
It works ( on my computer :P)
I bump the sp1-sdk to 2.0.0 version since the proof verification said:
Proving should work.: error: "InvalidArgument" message: "version SP1 circuit version v1.2.0 is not supported. Supported versions are: v1.1.0, v2.0.0, v3.0.0-rc1 - For more info, see: https://docs.succinct.xyz/generating-proofs/prover-network/versions"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Sepolia spec took if from here: https://github.com/paradigmxyz/reth/blob/b4d5adeeb1a0a3dce0c6e49b102910e4e072f7a0/crates/chainspec/src/spec.rs#L58
Wait! with that sepolia specs i cannot execute properly the blocks D: investigating!

Oki, for some reason, if i copy the specs it just fail computing the state root!?
somehow i cannot put timestamp in multiple forks like here: https://github.com/paradigmxyz/reth/blob/main/crates/ethereum-forks/src/hardfork/ethereum.rs#L363
I have to let only 1 timestamp and the rest to 0s, don't understand why yet TT


Remote install broken

Did you read the README?

[X] I have read the README, the theme is installed/configured correctly and the "Troubleshooting" section contains no information related to my problem

Do you have the latest versions of Spicetify, Spotify and Bloom?

[X] I'm using the latest versions of Spicetify, Spotify and Bloom

Is there already an issue for your problem?

[X] I have checked older issues, open and closed

Is your problem definitely caused by the theme?

[X] I have checked the app behavior without the theme and it is different

Environment & Computer Info
- Spotify version: <IP_ADDRESS>0.ga4a70a0e
- Installed from: Spotify site
- Spicetify version: 2.36.11
- Color scheme: dark
- Bloom installation method: PowerShell script

Description
1: Run Powershell script
2: Run remote option
2: Run Spotify
Some of the control icons are out of alignment or even just missing (such as shuffle). The control panel seems to also be too low in the window than what is shown in the description screenshots.
Screenshots

It is fixed in this pull hope @nimsandu merges it
https://github.com/nimsandu/spicetify-bloom/pull/352

also checkout better-bloom theme. i rewrote all the css and js

It is fixed in this pull hope @nimsandu merges it
#352

@sanoojes hey!! sorry for delays! well thanks to you, its fixed!
@cmdshft ill close the issue, please reopen if anything goes wrong again!

no probs can i re write the theme i rewrote the whole code and made a new theme with advancements if you like it we can merge the project @nimsandu

it was previously named better-bloom now its called Lucid => https://github.com/sanoojes/Spicetify-Lucid
also am also looking forward to make a discord bloom theme

@sanoojes , Hey, I've already seen it (I even starred the repo), and I absolutely love it! It's a completely new experience and it's really nice. I remember @SunsetTechuila created a mica-simulated version for Bloom that felt just like this, and I personally adore it!
So, Sanoojes, I truly believe Lucid deserves to be an independent theme. If you want, I can let you integrate it with Bloom, but personally, I'd love to see it stand out because you've worked hard and completely redefined it. I created this using the Fluent theme by William Ha, and look how far we've come! I think you can embark on a journey like that. I will personally assist with anything!
We don't do this for ourselves; we never have. It's all about making people's lives a little bit better. It needs evolutions! I see you can conquer Spicetify with this wonderful theme.
so what do you think?

@nimsandu  Thank you so much for the incredibly kind words and support!
i would like to integrate the theme with bloom with its own spice !
| sorry for been bad at communicating in english |

okayy! as you will! @sanoojes !
so here is the plan;
we introduce this as a separate scheme for bloom just like the violet coffee schemes etc.
in order to do that we can include lucid in a sub files in the repo and edit the installation scripts asking the users to choose what scheme they want to install! just like we already ask users to choose Remote and Local during installation! this will let end user to choose with ease while giving lucid the proper place it deserves! this kind of approach will help you to integrate the upcoming discord theme with ease too! also allowing our contributors to do what you do easily!

@sanoojes also, open a discussion, that will help us discuss better! (also no need of good English when the code speaks ;)

yes sure i will do that now am going to rewrite some css and fix the theme issues

okayy! as you will! @sanoojes ! so here is the plan; we introduce this as a separate scheme for bloom just like the violet coffee schemes etc. in order to do that we can include lucid in a sub files in the repo and edit the installation scripts asking the users to choose what scheme they want to install! just like we already ask users to choose Remote and Local during installation! this will let end user to choose with ease while giving lucid the proper place it deserves! this kind of approach will help you to integrate the upcoming discord theme with ease too! also allowing our contributors to do what you do easily!

yes sure we can do like it ! do you have discord or any other app for development chat ? @nimsandu

@sanoojes im on discord, well somehow your link isnt working!
heres mine : discord


Fix minor formatting errors

Codecov Report

Merging #253 (769f853) into master (d9ce387) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #253   +/-   ##
=========================================
  Coverage     67.36%   67.37%
  Complexity     1057     1057
=========================================
  Files           136      136
  Lines          3711     3712    +1
  Branches        501      501
=========================================
+ Hits           2500     2501    +1
  Misses          975      975
  Partials        236      236

Impacted Files
Coverage Δ

...eedu/address/logic/commands/LessonEditCommand.java
73.58% <ø> (ø)

...c/main/java/seedu/address/model/lesson/Lesson.java
78.82% <100.00%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ce387...769f853. Read the comment docs.


ES2015 standards

Hi,
I am using this generator to kickstart most of my ExpressJS projects, and it's real good, but I always wonder why you use var and functions instead of let/const and arrow functions?
I always change it myself when I kickstart a project.
Is there any particular reason for that? If not, I can make change and and create a pull request.

Hi @bluzi the generator is designed to support the same version range of Node.js that Express.js itself supports, which is Node.js 0.10 and higher. Node.js 0.10 does not understand let/const and arrow functions, which is why the generated code doesn't use them.
Now, that's just the history. There is no reason why someone could not add in the ability to generate both the old ES5 style and the newer ES2015 style under a switch to let the users choose between the two. The generator could even automatically generate using ES2015 if the user didn't specify which one and the generator was run on a version of Node.js that supported ES2015.

Hi @dougwilson , Thanks for the response.
I will create a PR soon :)

@dougwilson @bluzi Is this still being worked on? What else needs to be done?

Hi @benhalverson, I couldn't find time to work on it yet. However, it seems like @sisisin created an ES2015 template on his fork, so maybe you should check that out.

yes I guess majority of us are embracing eslint and es6 these days, if express-generator can catch up on this it will be fantastic.

a commandline flag would be a good choice for this.
-6, --es6      generate output using ES6 features
-7, --es7      generate output using ES7 features

etc.

I wish I was smart enough to help get PR #176 ready to be merged, but I'm not there yet with my coding.
However, as a new guy, I'm trying to focus my learning on ES2015/classes designs, and this would really help. Any update?
Thanks, guys.

As https://github.com/expressjs/generator/pull/176 seems to have stalled and contains too many unrelated changes anyways I've created https://github.com/expressjs/generator/pull/200 that adds an --es6 flag. Feedback appreciated.


Firefox: baseline alignment doesn't work with nested flex blocks

Bug: align-items: baseline doesn't properly align flex items of nested blocks with display: flex.
Workaround: Use display: inline-flex instead.
Demo: http://codepen.io/wilddeer/pen/aObevX
Tested in Firefox 37.0.1

Thanks, I noticed this too and reported it on Bugzilla about a month ago. The bug was accepted so quickly I thought perhaps it'd be fixed quickly too, so I didn't take the time to make a Flexbug for it.
It looks like I probably should though.

Added via d65774781950e211a1831c29b071b0eb343ca3e8.


Optimize store_ids_for_new_records by getting rid of the O(n^2) lookups

Optimize store_ids_for_new_records by getting rid of the O(n^2)
lookups. These lookups can take hours when we go over 50-100k records
being processed by store_ids_for_new_records.
And seems like there might be a Rails issue, since by doing
association.push(new_records) at
https://github.com/Ladas/manageiq/blob/48aa323551c8825e02170e251afa717ca807d2ed/app/models/ems_refresh/save_inventory_helper.rb#L69-L69
The association has the records doubled, the association is passed
into store_ids_for_new_records as 'records' parameter
https://github.com/Ladas/manageiq/blob/48aa323551c8825e02170e251afa717ca807d2ed/app/models/ems_refresh/save_inventory_helper.rb#L114-L114
And here when we do:
records.count => 50k
records.uniq.count => 25k
records.reload.count => 25k
That was slowing down the store_ids_for_new_records method even
more it seems.
Partially fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1436176

cc @Fryguy

@chrisarcand hola, could it be that ems.association.push(new_records) has new issues in new rails? It doubles the records there as described in the PR description.

@Fryguy not sure what is the history of this complex casting
r.send(k) == r.class.type_for_attribute(k.to_s).cast(h[k])
but I am just basically doing
r.send(k).to_s == h[k].to_s

@Fryguy not sure what is the history of this complex casting
r.send(k) == r.class.type_for_attribute(k.to_s).cast(h[k])

This is because a provider author could pass, say, a number into a string column.  ActiveRecord does just fine in handling writing that number into this string column.  However, when we try to do the comparison between the value in the ActiveRecord object and the value from the parser, they will be different because 0 != "0".  Casting, allows them to match based on the column type.

@Fryguy right, 0 != "0" should be ok when both are .to_s. And seems to me all datatypes that are a candidate for an index should be ok, I could be wrong though. :-)

And seems like there might be a Rails issue, since by doing
association.push(new_records) at
https://github.com/Ladas/manageiq/blob/48aa323551c8825e02170e251afa717ca807d2ed/app/models/ems_refresh/save_inventory_helper.rb#L69-L69

How can the records be there twice if we are only adding the new_records?

@Fryguy right, 0 != "0" should be ok when both are .to_s. And seems to me all datatypes that are a candidate for an index should be ok, I could be wrong though. :-) But you know, the refresh specs are passing, so it must be all good. :-)

Why not just leave it?  This particular change is irrelevant to this PR, and could be done in a follow up PR if necessary, or am I missing something?

association.push is not saving the record

Correct, and if I recall that was intentional.  It allowed the actual saves to get pushed down to when the parent record was saved, but perhaps that no longer makes sense if we are always returning the ids.

@cben explained in https://github.com/ManageIQ/manageiq/pull/14542#discussion_r108961970
@agrare @cben
The issue with new records I described is only issue if you would need that id to be filled as a foreign key elsewhere. In that case we do the manual saving step as visible e.g. here https://github.com/Ladas/manageiq/blob/1c203b0401e357e338bd6ddc2ed90b32e5d81299/app/models/ems_refresh/save_inventory_network.rb#L188-L188
So it's not really an issue, unless you would have some actual foreign_keys using those, then you need to remember to use ^. But this should be visible in refresh specs, that are testing these foreign_keys relationshpis.

Doing benchmark on storing AWS s3 objects (is applicable to every saving the uses  store_ids_for_new_records method)
40k s3 objects being refreshed:
before this PR: 4802s
after this PR: 58s

LGTM.  Wow, 1.5hour :snail: :rocket: 1min!
Can this be euwe/yes?

New records — but if you don't actually need the ids, why call store_ids_for_new_records at all?
Ah, I'm starting to get it.  You still get old records indexed.  You mean it's sometimes useful compromise that first refresh won't be perfect and following refresh will flesh out the links?
I'll contemplate a followup renaming it to store_ids_for_old_records or something :-)

@cben good point indeed, but in general it's hard to say if you need the store_ids_for_new_records. You would need to manually go through the parser and check what points to what, then you could delete the store_ids_for_new_records, if it's not needed. It's easier for the containers, since the saving code is not shared by many different providers.
In graph refresh, you can infer this automatically. Cause you check can if there is a edge, that would need the :id. Though right now, the :id assignment is basically a noop, there might be other strategies that will be more like it is now. E.g. for super large tables(like CustomAttribute, which is quickly going over >100k), I want to try to generate SQL queries, that will update/create thousands records at once, instead of 1 record at a time. Then we would need this post indexing, but only if there is an edge that would require one. :-)

it's hard to say if you need the store_ids_for_new_records

Originally, this was used to store only the ids in the hash that were needed by later save methods.  Then they would have the id in place for foreign keys, so they wouldn't need to fetch the object...that is, the id gets placed in the hash, and due to hash reference sharing it's just automatically available later.  Then, people saw a pattern and just started putting store_ids_for_new_records everywhere, even if it's not needed.  Conceptually, it should never be an method call, so there was no harm on it.
@ladas do you have measurements on how much time this method contributed to the overall time?  It should be trivial to add a Benchmark.realtime_block to add to the refresh timings.

@ladas this is great!  Awesome work!
@agrare one it goes green, I think this will be good to merge

@Fryguy not an exact measuring. Doing the AWS perf tests, eliminating store_ids_for_new_records had cut the refresh time by 15-30%. But the perf specs were probably hitting this bug. So it might be much less in the end.

Fine backport details:
$ git log -1
commit 708fd26720a82d09c40babbc1ddb0d2dcac5323e
Author: Adam Grare<EMAIL_ADDRESS>Date:   Sat Apr 1 14:22:13 2017 -0400

    Merge pull request #14542 from Ladas/optimize_store_ids_for_new_records

    Optimize store_ids_for_new_records by getting rid of the O(n^2) lookups
    (cherry picked from commit 053c16e673d1ba73b98b6ebf73d98f46d2853c75)

Euwe backport details:
$ git log -1
commit 23f6fbbaf8117d8af0a1af1fe179a06dc78e7bfa
Author: Adam Grare<EMAIL_ADDRESS>Date:   Sat Apr 1 14:22:13 2017 -0400

    Merge pull request #14542 from Ladas/optimize_store_ids_for_new_records

    Optimize store_ids_for_new_records by getting rid of the O(n^2) lookups
    (cherry picked from commit 053c16e673d1ba73b98b6ebf73d98f46d2853c75)

    https://bugzilla.redhat.com/show_bug.cgi?id=1436176

Turns out the new code here is a near duplicate of class TypedIndex.
https://github.com/Ladas/manageiq/blob/b4c143ac1626892847080df2f60a7c4059509cbb/app/models/ems_refresh/save_inventory_helper.rb#L2-L34

@cben yeah, it might be doing similar thing on lower number of lines. TypedIndex is a bit complex for what it does (it's not present in Graph refresh)


For added nodes select button by group value

Instead of selecting button based on element data,
make selection by group value.
Fixes vaadin/flow#7823

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: openapi request bodies

Description
This PR fixes #935
Summary
This PR does add request bodies to openapi implementation.
PR Checklist
Please ensure that:

[x] The PR contains a descriptive title
[x] The PR contains a descriptive summary of the changes
[x] You build and test your changes before submitting a PR.
[x] You have added relevant documentation
[x] You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

[x] Ensure that you have run the pre-commit hooks on your PR.

The body should resemble the style of query params

@VishnuSanal , this should be the interface
class CustomBody(TypedDict):
    file: bytes
    file_name: str

@app.post("/sync/multipart-file")
def sync_multipart_file(request: Request, body: CustomBody):
    files = request.files
    file_names = files.keys()
    return {"file_names": list(file_names)}

https://github.com/sparckles/Robyn/actions/runs/10579769894/job/29313024961 please try rerunning. Issue is with websocket tests.

@VishnuSanal , is this PR up for review?

@VishnuSanal , could you please show the example of the openapi page generated?
Attach a screenshot?

@VishnuSanal , is this PR up for review?

Yep

class CreateItemBody(TypedDict):
    name: Optional[str]
    description: str
    price: float
    tax: float

@app.post("/upload/file")
def create_item(request: Request, body=CreateItemBody):
    return request.body

Amazing! ✨
Next update should be to make them look like the following
class CreateItemBody(TypedDict):
    name: Optional[str]
    description: str
    price: float
    tax: float

@app.post("/upload/file")
def create_item(request: Request, body: CreateItemBody):
    return request.body

But we can address that in the next PR when we add support for response schemas! GG @VishnuSanal . Need to give a final review

Love this @VishnuSanal ✨
Doing a final review before merging


typia with webpack using esbuild-loader

Hi,
We have recently looked at moving from  using ts-loader to esbuild-loader in our webpack.
From what I can see typia won't really work with esbuild-loader. Is that right?
Is this something that is possible?
Many thanks :)

No way. Just recommend to use vite


Add missing <pthread.h>. This has been prohibiting building atom on Darwin

:apple: :bug:
Also, in Xcode settings, change libstdc++ to libc++ —  Apple's libstdc++ is a legacy library from GCC 4.2.1, and has no c++11 support.

I don't know what that failure is, but I know it's not mine!


Instructions are not clear

In azure portal and inside API Management Service, where do I need apply policy xml.
I cannot find option Enable negotiate client certificate option for the Gateway endpoint under Custom Domains. Is it available only for standard, Premium and developer SLA.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 51769134-4b97-0a48-3031-cbcea10ca714
Version Independent ID: dc70bd8c-54be-1592-2137-aed9cae0094b
Content: Secure APIs using client certificate authentication in API Management - Azure API Management
Content Source: articles/api-management/api-management-howto-mutual-certificates-for-clients.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

@anilsoni85 Thank you for the feedback. We are actively investigating and will get back to you soon.

@anilsoni85

In azure portal and inside API Management Service, where do I need apply policy xml.

Since you would usually want to authenticate users before forwarding the request to the backend, you would use this policy in the inbound block.

I cannot find option Enable negotiate client certificate option for the Gateway endpoint under Custom Domains. Is it available only for standard, Premium and developer SLA.

For the Developer, Basic, Standard, or Premium tiers, you need to enable it for each custom domin, like below

For the Consumption tier, you need to enable it on the Custom Domains blade itself, like below

@anilsoni85 Just following up here... Hope my previous comment clears things up.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Refactor the notification code

You might want to use https://github.com/containrrr/shoutrrr for notifications

You might want to use https://github.com/containrrr/shoutrrr for notifications


NoPointerException

I am using the framework for a while but I didn't get the NoPointerException yet.
I am confused, is it working properly or not? :thinking:

absolutely，it works perfect, it brings lots of benefits ,no exception,no error , no warining ,even no info


Dead Harvesting

https://cmsweb.cern.ch/reqmgr2/fetch?rid=mcremone_HARVEST-Run2016B-v2-ZeroBias2-17Jan2017_8020_170125_064007_1366
and
https://cmsweb.cern.ch/reqmgr2/fetch?rid=mcremone_HARVEST-Run2016B-v2-ZeroBias3-17Jan2017_8020_170125_001614_5508
don't look super healthy.
FYI @mcremone

transferring the input dataset to the sitewhitelist would help.
Not a WMCore issue, closing.

alright, that's a lock/harvesting race condition. it was on disk just enough to get the wqe through to acquired, and now the agent does not find it anymore, right ?

Yes, that's right. The agent managed to pull down that WQE but before it was injected into WMBS, a data location updated kicked out and updated the element locally.
I'm planning to expose the WQE ids (for stuck in local workqueue database) to wmstats as well, it should be done in a week or two.


How to pass arguments to another page using transaction?

I have edited the transaction code:
Transition({
    required Widget child,
    TransitionEffect transitionEffect = TransitionEffect.FADE,
    Curve curve = Curves.ease,
    Object? argument,
  })  : this.child = child,
        this.transitionEffect = transitionEffect,
        this.curve = curve,
        super(
          /// Called to obtain the child widget.
          pageBuilder: (BuildContext context, animation, _) => child,
          settings: RouteSettings(arguments: argument),
          transitionsBuilder: (BuildContext context, animation, _, __) {
            switch (transitionEffect) {
              case TransitionEffect.FADE:
                return FadeTransition(opacity: animation, child: child);
              case TransitionEffect.SCALE:
                return ScaleTransition(scale: animation, child: child);
              default:
                var tween =
                    Tween(begin: transitionEffect.value, end: Offset.zero)
                        .chain(CurveTween(curve: curve));
                return SlideTransition(
                  transformHitTests: false,
                  position: animation.drive(tween),
                  child: child,
                );
            }
          },
        );

Added Object to pass arguments to other pages
Please update the package at pub.dev.org

Thank you for writing your opinion!
I will update it within today after the test.
Thank you!


Multiple GPU support for finetuning

@yannikkellerde, Thank you so much for creating this amazing package—it's incredibly useful. I was wondering if there's any way to leverage multiple GPUs for fine-tuning the model using this package?

Well, there I do not think that there is anything stopping you in principle from fine-tuning transformer-heads models using multiple gpus. I myself have sucessfully done some DDP (Distributed Data Parallel) training of transformer-heads models with multiple GPUs. For more advanced stuff such as FSDP I recommend checking out some of the existing libraries for multi-gpu training (there are a lot) and modifying their code to load transformer-heads models.
In the transformer-heads library itself I do not plan to include anything about multi-gpu training as I think other libraries serve that purpose better.

@yannikkellerde Thank you very much for your response. I'm quite new to this field, and I'd appreciate any suggestions for libraries that I could explore. Additionally, would it be possible to include an example notebook for DDP training with transformer-heads in this repository?

DDP really does not require any effort from your side. Accelerate and Huggingfaces Trainer basically handles all that stuff for you.
If you actually want to run bigger models using e.g. FSDP / Deepspeed  I'd recommend learning about it without transformer-heads first. It can be quite a hassle to get going.


Add --show-labels for nodes, configmaps and other resources.

Show labels as i see is for pods and deployment only.
('sl', '--show-labels', ['g'], ['oyaml', 'ojson']
         + diff(res_types, ['po', 'dep'])),

I'm able to write: kgsl nodes but not kgnosl or kgslno same for configmaps and other k8s objects.
If there any reason for us to not add them other resources, can we add them up too

This is mainly an optimization to reduce number of rarely used aliases generated.
I strongly encourage you make a fork and re-generate this for your use case.
I tend to think people don't use labels as much for ConfigMaps etc. :) Nodes have labels by default and Pods do, too. That's why it is the way it is.


[WIP] adding autodocumentation for python and C++

Framework for #384
Relies on doxygen to autogenerate C++ documentation, integrates it with sphinx and sphinx-apidoc python documentation using breathe. Can investigate a tool like sphinx-js for hooking in javascript as well.
Initial TODOs

[ ] add JSDoc config w/ babel support
[ ] fix sphinx-js bug with sphinx value iteration
[ ] hook in sphinx-js

https://github.com/mozilla/sphinx-js/issues/94

@texodus don't merge this yet

@texodus good to go, i'll flesh out the rest in a separate PR

@JHawk @sc1f take a look, and start planning on writing docstrings accordingly

Thanks for the PR!
There are already full JSDoc strings for all public APIs.  It would be nice if we could unify the docs across packages to output something consistent - I'd like to not have half of the docs in Github and half in readthedocs if possible.  In the meantime, this is a strict improvement over the 0% python docs we currently publish.


docs: init documentation

Update AboutUs, UserGuide, Index.md to reflect team information

@laney0808 @alex-setyawan @NatLeong Please assist in updating your information in future PRs. I'll force merge this PR for now as an init commit.


After UCP upgrade cluster switched to swarm mode

Problem description
From DDC customer.
[EDITED to remove potential sensitive information]
Problem location

The customer couldn't find the information they wanted. They expected to find it near the following URL: https://docs.docker.com/datacenter/dtr/2.1/guides/install/upgrade/
Other: release notes for UCP 2.0.x

Project version(s) affected
UCP 2.0.x
Suggestions for a fix
We should say that UCP 2.0 requires swarm mode and that updating from 1.x will enable swarm mode in the engine.

@leenamba this is a public repository, so I've removed the link you included in the issue.