esp32: improve toolchain management

Rebased to fix conflict. PR ready for review.

@sylvioalves - I'm ok with this going in as there are no code changes and it is mainly toolchain-related. Have you run twister  successfully with some representative hardware in the loop? I would like to know with some certainty that this change will not introduce any regressions.

@sylvioalves - I'm ok with this going in as there are no code changes and it is mainly toolchain-related. Have you run twister successfully with some representative hardware in the loop? I would like to know with some certainty that this change will not introduce any regressions not covered by CI.

@cfriedt As far as I know, there is not CI for Espressif devices regarding hardware tests (yet).  Zephyr's CI also does not run twister for variant espressif.

@cfriedt As far as I know, there is not CI for Espressif devices regarding hardware tests (yet). Zephyr's CI also does not run twister for variant espressif.

Have you been able to test this out with fairly decent coverage? No compiler / linker bugs or things of that sort?

@cfriedt As far as I know, there is not CI for Espressif devices regarding hardware tests (yet). Zephyr's CI also does not run twister for variant espressif.

@sylvioalves Have you been able to test this out on hardware with fairly decent coverage? No compiler / linker bugs or things of that sort?

Yes. It is very straightforward. Let me bring up some background:
Currently, ESP32 toolchain path needs to be exported for each SOC as below:
export ESPRESSIF_TOOLCHAIN_PATH="${HOME}/.espressif/tools/riscv32-esp-elf/<IP_ADDRESS>_64eb9ff-8.4.0/riscv32-esp-elf"
export ESPRESSIF_TOOLCHAIN_PATH="${HOME}/.espressif/tools/xtensa-esp32-elf/esp-2020r3-8.4.0/xtensa-esp32-elf"
This is difficult to maintain for new SoCs and toolchain update. So this PR makes a common toolchain path, which enables build projects for esp32, esp32s2, esp32c3 (and so) without having to change ESPRESSIF_TOOLCHAIN_PATH at all.
export ESPRESSIF_TOOLCHAIN_PATH="${HOME}/.espressif/tools/zephyr"

cc @tejlmand @gmarull - this mainly touches docs & build. No code paths, but I see it as a significant improvement that should probably be in v2.7.0. Are you able to ack?

@nashif - should this wait for TSC approval, or are we able to merge before then?

Looks like this will likely be going into a dot release.

Looks like this will likely be going into a dot release.

@cfriedt I am working on it. Hope there is still room for another round.

@tejlmand

I think we should ensure that if users have a setup with the old style then that will still be supported.

This update allows using already configured environment as you requested.

But this just ask user to re-install, but a user already having the toolchain installed should not need to re-install it.

I kept this message and it will only be displayed when no toolchain is exported into path.

because I only have python3 and no python link.
Why not use the python that was already invoked with west ?

I also added into this PR the necessary changes to use ${PYTHON_EXECUTABLE} as part of the scripts. There were a few places where python was hardcoded.
@cfriedt However, I had to update west.yml in order to get things in place in hal side. Now, #38543 needs to be merged before this MR. Once that gets merged, we can merge this. Do you think it can be accomplished before 2.7.0?

The release team says they would prefer it to go into a dot release.

The release team says they would prefer it to go into a dot release.

Ok, so we wait. Thanks.

Added the DNM label just until we are out of the stabilization period

@cfriedt Only rebased to fix merge conflict.


Problems updating the icons

I installed Imagemagick and tried to run the two commands through cmd.exe navigated to the folder but it just puts out an error that "'npm'/'node' is not recognized as an internal or external command, operable program or batch file." Any idea what I'm doing wrong?

You also need to install nodejs.

It fails while unzipping, my guess is that http.get doesn't handle redirects. Can you try changing the URL in the update-icons.js file to start with https:// instead of http://? Line 11 should read:
const gameIconsUrl = "https://game-icons.net/archives/png/zip/ffffff/000000/game-icons.net.png.zip";

Still didn't work, so I messed with some stuff and got it working. I'll explain how I did it here so it can help if someone else has this issue:
Install Imagemagick https://www.imagemagick.org

Install nodejs https://nodejs.org/en/

Download http://game-icons.net/archives/png/zip/ffffff/000000/game-icons.net.png.zip

Rename it "temp.zip" and put it in the root folder

Edit "update-icons.js" in notepad++ or something doing the following IN ORDER:

	Change line 18 and 19 to:
//const processIconsCmd = "magick mogrify -background white -alpha shape *.png";
const processIconsCmd = `magick mogrify -alpha copy -channel-fx "red=100%, blue=100%, green=100%" *.png`
	Change line 179 to:
.catch(err => console.log("Error", err));
	Delete line 171
	Delete lines 20-36

Run cmd.exe, navigate to the root folder then run the following commands:
	npm install
	node ./resources/tools/update-icons.js

Alternatively replace your "update-icons.js" with mine:
Semi-manual Icon Update.zip

Thanks @wereHamster for fixing the update icons script!
@Laucian32 could you try again with the fixed script?

It doesn't work for me :

mogrify.exe: unrecognized option `-channel-fx' @ error/mogrify.c/MogrifyImageCom
mand/4214.

``


Add Legend to Salesforce Metadata Backup Dashboard

Green  = Success
Red = Failure
Yellow = Not Yet Executed

added dashboard legend and added Stopped and Terminated status


Rework allow_reuse in decorators

Closes #4436.
This implements pretty much the same behavior that pyright and ruff/flake8 (via F811) enforce.

@dmontagu feedback addressed

My only concern is whether we should keep the parameter and raise an error or warning, rather than remove it?

I kept it for the V1 decorators and added a warning. But I removed it for the V2 decorators, I think a minor breaking change like that in an alpha is okay.


Fix bug with package names containing underscores

Hello @NeilGirdhar,
thank you for trying to contribute to poetry :+1: But what issue are you trying to solve? Your suggested change, is what is done in module_name(name) the line below.
fin swimmer

@finswimmer Oh, I see that now.   Unforunately, I'm having a problem where the poetry backend is having trouble installing my library with an underscore in its name:
Obtaining file:///home/neil/src/cooperative_dataclasses
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
    Preparing wheel metadata ... done
Installing collected packages: cooperative-dataclasses
  Attempting uninstall: cooperative-dataclasses
    Found existing installation: cooperative-dataclasses 0.2.4
    Uninstalling cooperative-dataclasses-0.2.4:
      Successfully uninstalled cooperative-dataclasses-0.2.4
  Running setup.py develop for cooperative-dataclasses
    ERROR: Command errored out with exit status 1:
     command: /home/neil/.pyenv/versions/3.8.2/bin/python3.8 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/neil/src/cooperative_dataclasses/setup.py'"'"'; __file__='"'"'/home/neil/src/cooperative_dataclasses/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps
         cwd: /home/neil/src/cooperative_dataclasses/
    Complete output (6 lines):
    running develop
    running egg_info
    writing cooperative_dataclasses.egg-info/PKG-INFO
    writing dependency_links to cooperative_dataclasses.egg-info/dependency_links.txt
    writing top-level names to cooperative_dataclasses.egg-info/top_level.txt
    error: package directory './cooperative_dataclasses' does not exist
    ----------------------------------------
  Rolling back uninstall of cooperative-dataclasses
  Moving to /home/neil/.pyenv/versions/3.8.2/lib/python3.8/site-packages/cooperative_dataclasses-0.2.4.dist-info/
   from /home/neil/.pyenv/versions/3.8.2/lib/python3.8/site-packages/~ooperative_dataclasses-0.2.4.dist-info
  Moving to /home/neil/src/cooperative_dataclasses/cooperative_dataclasses/
   from /home/neil/src/cooperative_dataclasses/~ooperative_dataclasses
ERROR: Command errored out with exit status 1: /home/neil/.pyenv/versions/3.8.2/bin/python3.8 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/neil/src/cooperative_dataclasses/setup.py'"'"'; __file__='"'"'/home/neil/src/cooperative_dataclasses/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' develop --no-deps Check the logs for full command output.

The setup.py is generated from dephell, so I don't see why it's not working.

Can you please open a new issue for this with more details, so we can reproduce it? Or join discord to discuss it.


Display issues on page Bob Deinterlacing Algorithm

This issue was created by @drmandarin from https://github.com/MicrosoftDocs/feedback/issues/453
On this page:
https://docs.microsoft.com/en-us/windows-hardware/drivers/display/bob-deinterlacing-algorithm
Multiple display issues in formulae in the text, e.g:
0 <= i <= Mâˆ’1
0 <= j <=Nâˆ’1
(9*(b+c)âˆ’(a+d)+8)>>4
Please fix these issues.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b462c0f4-2d56-05a4-cc3c-c071a609590b
Version Independent ID: 19e783f6-82c2-50c5-c344-01924ab9ea90
Content: Bob Deinterlacing Algorithm
Content Source: windows-driver-docs-pr/display/bob-deinterlacing-algorithm.md
Product: windows-hardware
GitHub Login: @nabazan-microsoft
Microsoft Alias: windowsdriverdev

Thanks for raising this, @Powerhelmsman
@mimisasouvanh can you please see if this is correct or needs editing? It looks the same as the WDCML version.

No problem. I couldn't attach a screenshot to the original message, but
here's one for your reference so that you can clearly see an example of the
issue:
[image: image.png]
On Mon, 25 Jun 2018 at 18:48, Eliot Graff<EMAIL_ADDRESS>wrote:

Thanks for raising this, @Powerhelmsman https://github.com/Powerhelmsman
@mimisasouvanh https://github.com/mimisasouvanh can you please see if
this is correct or needs editing? It looks the same as the WDCML version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/windows-driver-docs/issues/605#issuecomment-400037662,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvbZxYVNfBGvbs7iwAjjarDO0EdOCsnks5uASKCgaJpZM4U2hz0
.

This has been fixed. Thank you for bringing this up!

No problem and thanks for fixing.
Please check the correction of this equation:
(9*(b+c)âˆ’(a+d)+8)>>4
I have raised it because, since e.g. Mâˆ’1 was corrected to M-1, I would
expect that the fragment " âˆ’ " should be corrected to " - ".
Hence I would have expected that
(9*(b+c)âˆ’(a+d)+8)>>4
would be corrected to
(9*(b+c)-(a+d)+8)>>4
but this is not the case. Please review. Perhaps it was a typo on the
original incorrect page, so it isn't clear what the equation should be.
On Mon, 23 Jul 2018 at 18:04, Mimi Sasouvanh<EMAIL_ADDRESS>wrote:

Closed #605
https://github.com/MicrosoftDocs/windows-driver-docs/issues/605.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/windows-driver-docs/issues/605#event-1748237666,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvbZ_5-43fED-Mu-VXg9RpPs-PJ-bYaks5uJgI4gaJpZM4U2hz0
.

I went ahead and made this fix. Thank you so much!


Reduce amount of  WP dependencies

Was the reason that react was wrapped by @wordpress/element is so that if react is updated in the future with a breaking change, then WP team can wrapper react in a compatibility layer. Isn't this an issue here too?

We'll eventually load/bundle React in a way that we are in full control of the version used in conjunction with editor. This is important especially once we go beyond WordPress. But even in WordPress, we want to to be able to use the latest and greatest features of React without having to force users to update their WordPress version. So if we're in full control, any compatibility layer is irrelevant as we can steer updates.

Why not add our own react wrapper? That in WP uses @wordpress/element otherwise defaults to React?

What would be the benefit of that be? That basically equals two separate code bases that have to be tested and maintained.


[Feature Request] config.json should be ignored

In my opinion the config.json file should be added to .gitignore, so that users' changes won't be overwritten.
If needed, there can also be a config.json.example file so that users know how to configure it even if they've modified the config.json file.

24639a5c7cf87eeb4ac9b61e4df6e093fafb5720
config.json is now created with default values on first startup. Added to gitignore so users can make changes and update without the changes being overwritten.


Define commands to insert RFC XML elements

I think @opoudjis is most familiar with RFC XML elements and can come up with good examples 👍

I've found a few examples, one in python, and learned it more or less. Now it makes more sense for me.

@ronaldtse, I don't understand what this ticket is asking for; is it asking for passthrough injecting of RFC XML into the Asciidoc? That's done by passthrough, using a ++++ delimiter. Or are you merely asking for sample Asciidoc?


README Change for Non ENV users

The README currently notes the following:
Mapkick uses Mapbox GL JS v1. To use tiles from Mapbox, create a Mapbox account to get an access token and set ENV["MAPBOX_ACCESS_TOKEN"] in your environment.
This is not entirely accurate. When I dug into the code, I found you could also just pass in your access_token to the js_map method:
= js_map([{latitude: 'lotsOnumbers', longitude: 'EvenMOREnumbers'}], access_token: Rails.application.credentials.mapbox[:access_token], style: "mapbox://styles/mapbox/outdoors-v12", zoom: 15, controls: true, width: '100%', height: '600px')
I would suggest changing the text to something like:
Mapkick uses Mapbox GL JS v1. To use tiles from Mapbox, create a Mapbox account to get an access token and set ENV["MAPBOX_ACCESS_TOKEN"] in your environment. If you are using Rails.application.credentials instead of ENV variables, you can provide your token directly to the js_map method by passing in access_token: my_awesome_token.
Something like that :)
Most importantly, thanks for the gem! I needed just something like this for a friend's site and it was so awesomely easy to use and creates a lovely map. Really appreciate all the great work!!
P.S. Apologies for not creating a fork and pul request ... slammed at work this week and wanted to send this thought along before I forgot!

Hey @imageaid, thanks for the suggestion. I think most users will want to set it globally, so added a note about Mapkick.options[:access_token].

Heh. Was just about to note you had a much better option and I'll be changing mine shortly! I literally threw it together last weekend and haven't even had a chance to go back and refactor LOL
Thanks, again!


List: index out of range (tools/test.py)

Hello, I've used the command python3 tools/test.py     configs/faster_rcnn/faster_rcnn_r50_fpn_1x_coco.py     checkpoints/faster_rcnn_r50_fpn_1x_coco_20200130-047c8118.pth --eval bbox to test faster_rcnn on a custom dataset that is converted to coco format. I have not made any modifications to the models. I simply have a file instances_val2017.json in the annotations folder and a folder for images. I have referred to issue #5407 but the solution is not possible for me as I don't possess enough data for training. Please help me resolve this. Thanks, in advance.

you should check out your dataset. You need change the class name of coco datasets, more details please refer to tutorials

Thank you for your response @BIGWangYuDong. I've followed the steps in customize_datasets.md. I use only 2 classes, person and car. I don't why but the models keep detecting bicycles and persons even though the labels only have categories: person and car and the classes in coco.py are person and car. I'm not sure why that happens.

Hello @BIGWangYuDong , I've tried to reconvert my dataset, setting only one category: "car" and modifying the config files consequently. When visualising the results, this is the output:

Why is the result like this? The car class is the only class in both the config file and the categories.

Did you modify the code in config files?

I did. The result you see above is after the modification of the data.train,test and val with the new class which is just 'car'. I also modified num_classes in the model itself.

Hello try to modify the classes in mmdetection/mmdet/dataset/coco.py

I am having the similar issue. I modified coco.py as well but now I am getting  File "/home/UNT/sd0570/mmdetection/mmdet/core/evaluation/mean_ap.py", line 463, in print_map_summary
label_names[j], num_gts[i, j], results[j]['num_dets'],
IndexError: tuple index out of range
Please how to solve this

@Balazizo @FirasKedidi did anyone solve this?


Cannot read properties of null (reading 'server_members')

I just followed the tutorial for self hosting primo on vercel, however I get the following server side error when opening the deployed page:
TypeError: Cannot read properties of null (reading 'server_members')
    at file:///var/task/.svelte-kit/output/server/entries/pages/_layout.js:15:37
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async load (file:///var/task/.svelte-kit/output/server/entries/pages/_layout.js:10:37)
    at async load_data (file:///var/task/.svelte-kit/output/server/index.js:585:18)
    at async file:///var/task/.svelte-kit/output/server/index.js:1911:18

I just tried it again today and the error resolved itself. I'm not able to reproduce it anymore :/

@SpyrexDE okay, lemme know if it comes back up. I've noticed this too but it doesn't seem to cause any usability issues & it doesn't make sense to me. It's happening here because 'user' is coming up empty as if the user isn't authenticated, but if they're not authenticated it should redirect before that.

Okay did a big refactor to use the new Supabase SvelteKit helpers & this isn't happening anymore.


No addFeature/changefeature event is thrown

Describe the bug
When adding @addFeature to a ol-source-vector there should be events for whenever a feature is added to the ol-source-vector. Such an event is never thrown. Seems to be the case for other events as well, although the documentation states, that all events of OpenLayers are handled.
Affected version(s)
v10.0.1, did not test others
To Reproduce
Steps to reproduce the behavior:

use this code

<template>
<ol-map
  ref="map"
  :loadTilesWhileAnimating="true"
  :loadTilesWhileInteracting="true"
  style="height: 400px"
  :controls="[]"
>
  <ol-view
    ref="view"
    :center="center"
    :zoom="zoom"
    :projection="projection"
  />
  <ol-tile-layer ref="osmLayer" title="OSM">
    <ol-source-osm />
  </ol-tile-layer>

  <ol-control-bar>
    <ol-toggle-control
      html="🔘"
      className="edit"
      title="Point"
      :onToggle="(active) => changeDrawType(active, 'Point')"
    />
  </ol-control-bar>

  <ol-source-vector @addFeature="handleAddFeature">
  <ol-interaction-draw
    :type="drawType"
    @drawend="drawend"
    @drawstart="drawstart"
  >
  </ol-interaction-draw>
</ol-source-vector>
</ol-map>
</template>

<script setup>
import { ref } from "vue";

const center = ref([34, 39.13]);
const projection = ref("EPSG:4326");
const zoom = ref(6);
const view = ref(null);

const drawEnable = ref(false);
const drawType = ref("Point");

const changeDrawType = (active, draw) => {
drawEnable.value = active;
drawType.value = draw;
};

const drawstart = (event) => {
console.log(event);
};

const drawend = (event) => {
console.log(event);
};

const handleAddFeature = (event) => {
  console.log(event);
}

const osmLayer = ref(null);
</script>

Add a point
There should be an event visible in the console, but it is not.

Expected behavior
adding
Additional context
According to https://github.com/MelihAltintas/vue3-openlayers/blob/ee8fb7fff2a21138a266da1a27b9cc82e6e5a893/src/composables/useOpenLayersEvents.ts#L41 these features are defined as FEATURE_EVENTS

the problem might be, that the Openlayers event is actually addfeature and not addFeature ?


RST-4668 - RSpec improvements

Jira
https://tools.hmcts.net/jira/browse/RST-4668

new branch opened


Update readme resources url

This was resolved earlier in the day and has been passed out to the latest release.
Thanks for the input though it is really appreciated.


MAVSDK server not connecting with JMAVSIM - Windows WSL

I am running jmavsim on wsl and the GUI seems to work fine with the wsl commands to takeoff and land but I am trying to connect it to the MAVSDK server and its not connecting
here are my logs and code:
px4 sitl mode for jmavsim
[1/2] launching px4 jmavsim_iris (SYS_AUTOSTART=10017)

| ___ \ \ \ / /   /   |
| |/ /  \ V /   / /| |
|  __/   /   \  / /| |
| |     / /^\ \ ___  |
_|     /   /     |_/
px4 starting.
INFO  [px4] startup script: /bin/sh etc/init.d-posix/rcS 0
env SYS_AUTOSTART: 10017
INFO  [param] selected parameter default file parameters.bson
INFO  [param] importing from 'parameters.bson'
INFO  [parameters] BSON document size 316 bytes, decoded 316 bytes (INT32:13, FLOAT:3)
INFO  [param] selected parameter backup file parameters_backup.bson
INFO  [dataman] data manager file './dataman' size is 7872608 bytes
INFO  [init] jMAVSim simulator
INFO  [simulator_mavlink] using TCP on remote host localhost port 4560
WARN  [simulator_mavlink] Please ensure port 4560 is not blocked by a firewall.
INFO  [simulator_mavlink] Resolved host 'localhost' to address: <IP_ADDRESS>
INFO  [simulator_mavlink] Waiting for simulator to accept connection on TCP port 4560
Buildfile: /mnt/e/PROJECTS_UTF/PX4-Autopilot/Tools/simulation/jmavsim/jMAVSim/build.xml
make_dirs:
compile:
create_run_jar:
copy_res:
BUILD SUCCESSFUL
Total time: 10 seconds
Options parsed, starting Sim.
Starting GUI...
INFO  [simulator_mavlink] Simulator connected on TCP port 4560.
Init MAVLink
INFO  [lockstep_scheduler] setting initial absolute time to<PHONE_NUMBER>012000 us
INFO  [commander] LED: open /dev/led0 failed (22)
WARN  [health_and_arming_checks] Preflight Fail: ekf2 missing data
INFO  [uxrce_dds_client] init UDP agent IP:<IP_ADDRESS>, port:8888
INFO  [mavlink] mode: Normal, data rate: 4000000 B/s on udp port 18570 remote port 14550
WARN  [health_and_arming_checks] Preflight: GPS fix too low
INFO  [mavlink] mode: Onboard, data rate: 4000000 B/s on udp port 14580 remote port 14540
INFO  [mavlink] mode: Onboard, data rate: 4000 B/s on udp port 14280 remote port 14030
INFO  [mavlink] mode: Gimbal, data rate: 400000 B/s on udp port 13030 remote port 13280
INFO  [logger] logger started (mode=all)
INFO  [logger] Start file log (type: full)
INFO  [logger] [logger] ./log/2024-07-09/19_34_24.ulg
INFO  [logger] Opened full log file: ./log/2024-07-09/19_34_24.ulg
INFO  [mavlink] MAVLink only on localhost (set param MAV_{i}BROADCAST = 1 to enable network)
INFO  [mavlink] MAVLink only on localhost (set param MAV{i}_BROADCAST = 1 to enable network)
INFO  [px4] Startup script returned successfully
pxh> WARN  [health_and_arming_checks] Preflight: GPS fix too low
INFO  [tone_alarm] home set
WARN  [health_and_arming_checks] Preflight: GPS fix too low
INFO  [commander] Ready for takeoff!
server logs:
mavsdk_server_win32.exe -p 50051 udp://<IP_ADDRESS>:18570
[12:29:12|Info ] MAVSDK version: v0.35.0 (D:\a\MAVSDK\MAVSDK\src\core\mavsdk_impl.cpp:20)
[12:29:12|Debug] New: System ID: 0 Comp ID: 0 (D:\a\MAVSDK\MAVSDK\src\core\mavsdk_impl.cpp:417)
[12:29:12|Info ] Server started (D:\a\MAVSDK\MAVSDK\src\backend\src\grpc_server.cpp:45)
[12:29:12|Info ] Server set to listen on <IP_ADDRESS>:50051 (D:\a\MAVSDK\MAVSDK\src\backend\src\grpc_server.cpp:46)
[12:29:12|Info ] Waiting to discover system on udp://<IP_ADDRESS>:18570... (D:\a\MAVSDK\MAVSDK\src\backend\src\connection_initiator.h:21)
I tried running it on every port including the default 14540 and every combination with or without the IP <IP_ADDRESS>
here is my python edited code on takeoff and land example from mavsdk-python
print("Starting the drone connection script...")

# Connect to the MAVSDK server
drone = System(mavsdk_server_address='localhost', port=50051)
await drone.connect(system_address="udp://:18570")

Also ran this code on every port but its stuck at connection with drone, earlier it was not even running with x64 version I found someone running it on x32 so shifted to that seems like my python is connecting with it but not the jmavsim
logs of takeoff_and_land.py:
Starting the drone connection script...
Waiting for drone to connect...
what could be the problem?

Shouldn't you use udp://:14550 (or udp://:14540) instead of udp://:18750? 🤔

I have used all the ports including udp://:14550 and udp://:14540, this is solved by running the python script within my wsl env. I didn't need to use the webserver separately either.


BooleanBiFunction -> CombinationRule

It is used exclusively combining voxel shapes or bit set voxel sets.

https://github.com/FabricMC/yarn/commit/1520549e3dea23f6804e46d6b929ca3640cf7b7e#diff-aa2bc7ebf401f48a9c4f9f6c1baae28e
Looking at this, the field names are from some legacy unobfuscated names. I wonder if we should revisit these...


Create a widget for adding a new category or editing an existing one

Textfield for the name of the category
Save button

no longer needed


RDKit fails building on Windows with VS2015 Update 2

it looks like the VS2015 Update 2 (19.00.23918) breaks the RDKit build on Windows with this error message:
C:\build\rdkit\Code\GraphMol\FilterCatalog\FilterCatalog.cpp(235): error C2996: 'RDKit::Dict::toany': recursive function template definition [C:\build\rdkit\build\Code\GraphMol\FilterCatalog\FilterCatalog.vcxproj]
The problem seems related to this report and references therein:
http://stackoverflow.com/questions/21139528/what-does-it-mean-if-visual-studio-2012-throws-a-compile-error-that-shouldnt-ex
The build succeeds only setting RDK_USE_BOOST_SERIALIZATION=OFF.
I noticed this after rebooting my Windows machine, which probably triggered the update. It would be great if someone who is still on Update 1 could check if the build succeeds, which would definitely point to Update 2 being the culprit.

After reading the comments and following through the threads, this is certainly changed behavior for boost serialization.  We may be able to fix the problem at the cost of breaking backwards serialization support, I think this might be a small cost to pay if necessary, I'm unsure if anyone has used the serialization capabilities yet.

I just built successfully with VS2015 Update 1


refactor: reference version file instead of fvmrc

When working in teams, it is ideal to define the flutter versions that we are currently using and commit them to version control. But the working local version should not be checked into version control.
The problem
Updating the .fvmrc file with the current working local version of flutter causes the file to contain modifications and could potentially be committed and pushed.
The Solution
Instead of modifying the .fvmrc file, we could have a separate file, which is not version controlled, that contains the current working version.
There is already a file that exists within the project, .fvm/version, that could be used for this functionality.
Changes
This PR introduces the change to remove the flutter/flutterSdkVersion from config_model.dart effectively removing it from the .fvmrc and .fvm/fvm_config.json files.
By removing flutterSdkVersion  from the .fvmrc file, the version will be retrieved from .fvm/version instead.

@mrgnhnt96 It seems you are on 🔥!
Removing the versioning won't be possible, as this is a critical piece that people depend on and indicates the code's version. However, I do agree with the use case.
What do you think of the idea of doing a .fvmrc_override that is used if it exists and that can be added to .gitignore?
Thanks for the PRs!

Removing the versioning won't be possible, as this is a critical piece that people depend on and indicates the code's version. However, I do agree with the use case.

Do they still need to depend on it if .fvm/version exists?
Perhaps we approach this differently:

If flutter is defined within .fvmrc, it is consumed & updated
If flutter is not defined, .fvm/version is used instead

Then its an optional entry and wouldn't break peoples current workflow.

What do you think of the idea of doing a .fvmrc_override that is used if it exists and that can be added to .gitignore? Also, this should be fairly straightforward as we just have to do a ProjectConfig load on that file and merge during the creation of the context.

This could work, but I don't think that _override is the proper naming here. I wouldn't expect fvm to update my overrides file with the changed local flutter version, which is what this file would exist to do (in this use case).

We could have another convention like .fvmrc_local. There are a lot of use cases currently dependent on fvmrc, including integration with third-party services.
Flutter version is the reason .fvmrc exists, as it becomes the source of truth.
If the Flutter version is unnecessary, isn't it better to add .fvmrc to gitignore?
I might be missing something here. Because there are files that will change if a dev changes the sdk like the pubspeck.lock might change for example.
So the case is no 100% clear

After thinking about this some more, I think that my approach to this might have been wrong. Ima close this PR for now, if in the future I find a better argument that supports this use case, then I'll re-open it!
Thanks for the quick responses here!


fix bug:  'dict_keys' object is not subscriptable when 'load_from_hf' in 'load_dataset'

PR types
 Bug fixes
PR changes
 Others
Description
 fix bug:  'dict_keys' object is not subscriptable in Python3, so dict.keys() need change to list

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: kev123456:x: wangkaifuwangkaifu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your contributions!

It seems that 1 out of 2 committers have not signed the CLA, please sign the CLA agreement.
And the commit is https://github.com/PaddlePaddle/PaddleNLP/pull/2364/commits/274fc5b45bcf641ec8d30c2bc362bcab88aca5da, maybe checkout a new branch from the latest develop, update the changes and re-push it without this commit also would be OK.


Sub interface method overload with base interface parameter is not checked for correctness

TypeScript Version:  2.4.2
Code
interface Base {
    can(x: number);
}

interface Special extends Base {
    can(x: number);
    can(x: Base);
}

class A implements Base {
    a: string;
    constructor() { this.a = "A" }
    can(x: number) {
    }
}

class B implements Special {
    b: string;
    constructor() { this.b = "B" }
    can(x: number);
    can(x: A);
    can(x: number | A) {
        // Why is this implementation sufficient?
        console.log("Given: " + x);
    }
}

let a = new A();
let b: Special = new B();
b.can(b);

Expected behavior:
The definition of class B should not be correct, because the can(x: Base) method is missing from B.
Actual behavior:
No errors. can(x: number | A) is called with a B. By writing "class X implements I", I want to ensure that the interface is correctly implemented. However, the missing method is not reported.

It works for the same reason that
const b: Base = new A();
const s: Special = new Special();
s.can(b);

works.

I do not understand that reasoning, because the following triggers a type error:
let a = new A();
let b = new B();
b.can(b); // type error

In general, the interface allows more objects than the implementation type, because the implementation type contains further properties and methods.

Furthermore, the union type number | A should not accept B, however, that is what is passed to the method in the initial example.

you can find some explanation for this in https://github.com/Microsoft/TypeScript/wiki/FAQ#why-are-function-parameters-bivariant

FYI, I implemented a tslint rule for collecting type information (interfaces and classes), and a second rule that creates failures if an implementation does not provide a method as is described in one of its interfaces, i.e. all interface methods need to be present in an implementation (with types matching the exact description in the interface).
Therefore, in the initial example, an error message would be present at the B#can(...) method, stating that an implementation is missing for Special#can(x: Base).
I still fail to understand why this check cannot be performed by TypeScript and why the current behaviour is considered correct.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Handle symmetric and inverse predicates

corr={
        "message": {
            "query_graph": {
                "edges": {
                    "e00": {
                        "subject": "n00",
                        "object": "n01",
                        "predicate": "biolink:correlated_with"
                    }
                },
                "nodes": {
                    "n00": {
                        "id": "MONDO:0001627",
                        "category": "biolink:Disease"
                    },
                    "n01": {
                        "category": "biolink:ChemicalSubstance"
                    }
                }
            }
        }
    }

Returns no answers.  But if I swap subject and object on e00, I do get answers.  biolink:correlated_with is symmetric, so it should be found either way.

We haven't implemented symmetric predicates yet. @patrickkwang is this something I should work on?

This should fit pretty well with our augmented query graph approach. Are we using the original qgraph or the augmented one to filter out results we receive from KPs? It needs to be the latter or we'll have problems here.

This has been fixed.


Why use the 8-bit floating numbers to compute the original cost?

Hi,
The work is amazing.
When I looked through the code, I foud that you employed the 8-bit floating numbers to compute the original cost and store
it as a lookup table. I wondered why not use the 32-bit floating(not use the flag "--half" in the pretraining process) or use the 16-bit floating (use the flag "--half" in the pretraining process)? Could you please clarify that?
Thanks a lot!

Sorry, I got it.
It seems that you employed the 8-bit as the baseline


Normalize Segment approach

Use same styles and techniques as our other growth apps:

Extract identify_hash, intercom_hash, and campaign_hash.
Rename partial _analytics.
JavaScript escape the page title in page() event names.
Pass campaign_hash as properties into page() events.
Use SEGMENT_KEY environment variable name.

:+1:


[Release] sdk/resourcemanager/cosmos/armcosmos/2.5.0

https://github.com/Azure/sdk-release-request/issues/4113

@Alancere , can you fix CI failures?


Use stable toolchain channel

Closes https://github.com/hermitcore/rusty-loader/issues/140.

bors try

bors r+


release torchscript versions of the current models

And put them in a release of winsfer.

related to #69


Voice over in Mac book issue

While editing  in any file with voice over in macbook,
It is reading out entire file many times in middle  of file editing without  reason
it is telling file name
it is telling you are in a text area so many times
Before  I was using Windows, now it is manditory to use macbook. please fix if possible. In windows i use  NVDA screen reader  so easily that i do not even notice these type of issues.
This issue making us really disabled.
Please let me knoe if there are any   editors , which works perfectly with voice over.

testing steps:

turn on voice over Macbook
press command + F5

open any file in vs code and try to listen while typing.
voice over is reading out filename and some times entire file and telling so many times you are in a text area.
This unrelated announcements are making me  Inefficient.

press command + F5 to turn off  voice over again.


Output 0 of MatMul8bitLtBackward is a view and is being modified inplace.

I would like to report a bug using MatMul8bitLt.
When I used the following three in my code:

flash_attn_varlen_func from flash_attn (v2.0.8, Github Link),
MatMul8bit from bitsandbytes (v0.41.1),
Linear8bitLt from PEFT (v0.3.0dev0, Github Link),

I came across the following error:
RuntimeError: Output 0 of MatMul8bitLtBackward is a view and is being modified inplace. This view was created inside a custom Function (or because an input was returned as-is) and the autograd logic to handle view+inplace would override the custom backward associated with the custom Function, leading to incorrect gradients. This behavior is forbidden. You can fix this by cloning the output of the custom Function.
The error can be fixed by modifying Line 440 and 441 of bitsandbytes/autograd/_functions.py:
clone_func = torch.clone if len(output_shape) == 3 else lambda x: x
return clone_func(output.view(output_shape))

to
if len(output_shape) == 3:
    return output.view(output_shape).clone()
else:
    return output

This error happens because:

flash_attn_varlen_func requires the q,k,v inputs of self-attention to be 2D of shape (total_tokens, hidden_size);
in case of 2D inputs, output_shape is 2 and torch.clone is not used;
in Linear8bitLt.forward, the result from bnb.nn.Linear8bitLt is modified inplace: result += output;
for some reason, the autograd logic does not allow this.

I got this error too when I tried to fine tune a 8bit model with peft

me too!

same here

I get the same error.

Same error.

Will try to go down the rabbit hole to fix it

The same error occurred for me.

The same error occurred for me.

I provided a fix. Hope it helps.


Improve configuration structure for backends

On our path to make Spartacus more adaptable for other backends and third-party systems, we like to make our configuration more specific. We currently allow to configure the Commerce baseUrl and endpoint configuration in a structure that is not semantic enough to understand. Moreover, it is too generic and wil not scale.
Currently we have these items in the root of the config:
server: {
    baseUrl: environment.occBaseUrl,
    occPrefix: '',
}
endpoints: {
    product: '',
    productReviews: ''
}
site: {
    baseSite: ''
}

These are too generic, and would become unclear as soon as we start adding other backends (Service Factory, Yotpo, etc.). Therefor we like to use:
backend: {
    occ: {
        baseUrl: '',
        prefix: '',
        site: '',
        endpoints: {
            product: '',
            productReviews: ''
        }
    }
}

We keep site where it is now. The rest of proposed config format is ok.

QA steps:

configure custom (fake) baseUrl, occ prefix and endpoints in backend.occ config property and verify that HTTP calls are made to custom url
configure baseUrl in meta tag in index.html and verify that HTTP calls are made custom base url
Configure valid baseUrl and travel quickly through whole application (because almost every feature makes calls to OCC) - manual smoke test.

[X] configure custom (fake) baseUrl, occ prefix and endpoints in backend.occ config property and verify that HTTP calls are made to custom url
Changed it to this:

backend: {
occ: {
baseUrl: 'https://hybris.com:9001',
},

And confirmed that the calls were being made to the custom url.

[X] configure baseUrl in meta tag in index.html and verify that HTTP calls are made custom base url
Changed this:

And confirmed that the calls were being made to the custom url.

[ ] Configure valid baseUrl and travel quickly through whole application (because almost every feature makes calls to OCC) - manual smoke test.
Configured this:

backend: {
occ: {
baseUrl: 'https://dev-com-19.accdemo.b2c.ydev.hybris.com:9002',
},

Went quickly through the application. Was not able to perform a complete smoke test though, because the login screen is missing the login form on dev19 (was like this even before those changes. Gil was troubleshooting this issue but it hasn't been solved yet).
We only have dev19 for making changes for QAing.

I just saw the Wiki page is not up-to-date with this change. I wanted to create a PR for this, but apparently that is not possible for the Wiki pages. Could you please update the Wiki page to reflect this config change ?
https://github.com/SAP/cloud-commerce-spartacus-storefront/wiki/Setup-and-Installation


Getting tracking info of (yet) unused tracking number fails validation

Hi,
I'm attempting to get the tracking info of several parcels, and I know a lot of them might not have been used yet, or will never be used. Currently, I'm getting the following error tracking these parcels:
{
    "name": "SDKValidationError",
    "cause": {
        "issues": [
            {
                "code": "invalid_type",
                "expected": "string",
                "received": "undefined",
                "path": [
                    "tracking_history",
                    0,
                    "status_date"
                ],
                "message": "Required"
            }
        ],
        "name": "ZodError"
    },
    "rawValue": {
        "tracking_number": "<REDACTED>",
        "carrier": "ups",
        "servicelevel": {},
        "transaction": "<REDACTED>",
        "address_from": {
            "city": "<REDACTED>",
            "state": "<REDACTED>",
            "zip": "<REDACTED>",
            "country": "US"
        },
        "address_to": {
            "city": "<REDACTED>",
            "state": "<REDACTED>",
            "zip": "<REDACTED>",
            "country": "US"
        },
        "test": false,
        "tracking_history": [
            {
                "status_details": "Pre-Transit: Shipment information has been transmitted to the shipping carrier but it has not yet been scanned and picked up.",
                "object_created": "2024-05-06T11:37:39.842Z",
                "object_updated": "2024-05-06T11:37:39.842Z",
                "object_id": "<REDACTED>",
                "status": "UNKNOWN"
            }
        ],
        "messages": []
    }
}

The tracking history clearly mentions Pre-Transit, but the status there is UNKNOWN, that seems quite conflicted to me. This seems like either something that has to be fixed in the API response, or something that has to be fixed in the validation, because this seems like a perfectly valid state in tracking.

status_date is required according to our API specification.  I'm checking with the team whether this is actually the case.

I've confirmed this is a bug and is actively being worked, I'll close this ticket once the fix has been released.

Thanks for the quick responses the last few days!

quick update - this has been fixed but it doesn't look like it made yesterday's cutoff, should go out on Monday

Any news on the fix yet? I'm still getting the same amount of API errors

I'm trying to track that down... I see the fix was merged but don't see it in the deployment logs, will update this ticket with an ETA later today

looks like it will be going out today, still not sure why it didn't go yesterday

Sadly I'm still getting the same errors

apparently it isn't all the way fixed... I'm just going to update the client to not require status_date, at least until this issue gets resolved.  you'll still get the status_details "Pre-Transit: Shipment..." and status "UNKNOWN" until the underlying issue is actually resolved, but at least the calls won't explode.  I'll update this ticket once the fix is published.

https://www.npmjs.com/package/shippo/v/2.2.5 will fix the validation error you're getting.
I expect the tracking status fix to go out early next week, feel free to re-open if you're still getting wonky results

actually, something went wrong with publication, that package I linked was published two days ago, investigating

https://www.npmjs.com/package/shippo/v/2.2.6


[manila-csi-plugin] added AZ/topology support

The binaries affected:

[ ] openstack-cloud-controller-manager
[ ] cinder-csi-plugin
[ ] k8s-keystone-auth
[ ] client-keystone-auth
[ ] octavia-ingress-controller
[x] manila-csi-plugin
[ ] manila-provisioner
[ ] magnum-auto-healer
[ ] barbican-kms-plugin

What this PR does / why we need it:
This PR adds support for Manila AZs and topology.
Documentation, examples, Helm chart and the sanity test have been updated as well.
Which issue this PR fixes:
fixes #938
Our take on availability zones is two-fold:

we provide users with a way of specifying Manila AZs via a storage class parameter
this parameter is completely opaque to the CO and doesn't contribute to scheduling decisions on compute nodes
this is sufficient because usually all compute nodes should have connectivity to the storage
not always, though: if the nodes are partitioned into their own compute AZs and only certain compute AZs are able to reach a subset of Manila AZs, the cluster operator is able to deploy csi-manila with topology-awareness enabled and define the mapping between compute and storage AZs in StorageClasses

A couple of user-facing changes:

added new StorageClass parameter availability : specifies AZ for Manila side of things
added --with-topology cmd flag: enables topology-awareness of the driver (i.e. enables advertising of VOLUME_ACCESSIBILITY_CONSTRAINTS CSI capability)
added --nodeaz cmd flag: sets the AZ of the node
Helm chart:

added csimanila.enableTopologyAwareness into values.yaml: passes --with-topology and --nodeaz  to the manila-csi-plugin executable
added csimanila.nodeAZ into values.yaml: this value is sources into the --nodeaz cmd arg

manila-csi-plugin: added support for Manila availability zones and topology-aware dynamic provisioning

This change is

I think this is ready for review, PTAL @gouthampacha @tombarron @tsmetana @ramineni @adisky

/test cloud-provider-openstack-acceptance-test-csi-manila

/lgtm
And I've been running locally with topologyAwarenessEnabled and haven't hit any "surprises".

/lgtm
/assign ramineni

/test cloud-provider-openstack-unittest

/test cloud-provider-openstack-unittest

/test cloud-provider-openstack-acceptance-test-csi-manila

The CI job cloud-provider-openstack-acceptance-test-csi-manila is broken after the recent multi-arch changes, i'll work on a fix.

The CI job cloud-provider-openstack-acceptance-test-csi-manila is broken after the recent multi-arch changes, i'll work on a fix.

I think @ricolin is working on that, just FYI to avoid duplicating efforts.

/test cloud-provider-openstack-acceptance-test-csi-manila

/test cloud-provider-openstack-acceptance-test-csi-cinder

/test cloud-provider-openstack-acceptance-test-k8s-cinder

Some CI jobs are not triggering, I'll try to rebase.

@tombarron @gouthampacha please reapply your LGTMs
@ramineni please if you could offer feedback and/or help us merge this

@gman0  @gouthampacha Added my responses. We can get this into 1.18 if it is required by you guys. But please check on my comments on having additional flag to enable topology or not. IMO its not needed . Other things like automation of getting nodeAZ can be added later also in followup PR if needed and agreed, so that shouldn't be a blocker for this PR.

@gman0 @gouthampacha Added my responses. We can get this into 1.18 if it is required by you guys. But please check on my comments on having additional flag to enable topology or not. IMO its not needed . Other things like automation of getting nodeAZ can be added later also in followup PR if needed and agreed, so that shouldn't be a blocker for this PR.

@ramineni - thank you. We'd like this in, and I agree that the code and minor doc fixes suggested can come as enhancements later... It'd be valuable to eliminate the redundancy in the flags, but, I agree this isn't a blocker. Thank you for reviewing this diligently..

/lgtm

/test cloud-provider-openstack-unittest

/test cloud-provider-openstack-acceptance-test-csi-manila

After discussion with @gman0 on slack, I think this should be good to go.
/approve

/test cloud-provider-openstack-unittest

/test cloud-provider-openstack-unittest


MS-IK: Update Scheme failure

Task Description
The update scheme option for MS-IK fails, specifically when the existing vault has UTXOs, thereby executing the vault migration flow. The error toast stating "current block height retrieval has failed" is presented.

Verified this issue on keeper app v 1.3.2(439)


🔊 Improve error message for invalid function matchers

Because we're (rudimentarily) serializing TextMatch functions, they can't reference outer closure scope.
Example
// ✅ This is supported
screen.getByText(content => content.startsWith('Foo'))

// ❌ This is not supported
const startsWithFoo = (content: string) => content.startsWith('Foo')

screen.getByText(content => startsWithFoo(content))

This adds a "known limitation" entry to the readme describing this limitation and attempts to detect TextMatch functions with external references in order to print a helpful error message.

@sebinsua I know this may seem a bit like overkill just to add this one error message, but it's also a bit of a proof of concept for additional I'd like to do eventually (somewhat related to #491)

I also want to figure out how to preserve the ANSI formatting in the Testing Library errors.

etc.
I'm thinking in order to do this and other error "prettification" I may have to serialize errors back over from Testing Library to Playwright.

I think I found a bug -- see my comment.
But, also, there's nothing wrong with a little bit of tactical "overkill" that improves DX and that is needed for future work. :) Open-source work isn't paid so needs to be a little fun!


Half-Elf should have two non-CHA ability scores increased by 1.

For the Half-Elf, on page 6, the SRD states:

Ability Score Increase.
Your Charisma score increases by 2, and two other ability scores of your choice increase by 1.

The part about "two other ability scores of your choice increase by 1" isn't present in the database.

What do you think might be the best way to display this? I'm not sure it will really work with how the ability score increases are currently shown in the system.

I think a selection would be best, similar to how current selection exist. The current way is kind of flawed and the next one is rather flexible. But yeah, it's not the same as what currently exist. The template can be used for other half-mandatory, half-selection templates.
{
  "fixed": [{"ability": "CHA", "mod": "+2"}],
  "selection": {
    "choose": 2,
    "from": [
      {"ability": "STR", "mod": "+1"},
      {"ability": "DEX", "mod": "+1"},
      {"ability": "CON", "mod": "+1"},
      {"ability": "INT", "mod": "+1"},
      {"ability": "WIS", "mod": "+1"},
    ]
  }
}

Would it make sense to have the bonus as a string +1 or just as an integer? Even if you have a negative bonus, I think it would still make sense.

It would make sense, indeed. There are several instances of choice in the repository and I'd say the best is to be consistent with the rest of the repository. Abilities are usually added using integers so let's be consistent and use numbers instead of strings. I wrote that originally on my smartphone without thinking much, just trying to quickly match it with the other choices.

I think that sounds reasonable then. If you put together a PR, I'll be happy to look it over. I can't guarantee when I'll be able to make one.

Well, that's kind of the point of me raising an issue rather than putting up a PR: currently "ability_bonuses" maps to an array, but if I were to make those changes, it would map to either an array for all races except Half-Elf or an object for Half-Elf (and other official races outside of the SRD, such as Changeling and Kalashtar). So for the sake of consistency, there should be a switch to a different template than the current array one.
So if that's OK with you my PR will contain changes to all races.

I think it makes sense to make the change to all races. @adrpadua, any thoughts?

Actually, can you think of any examples where you can make the same stat choice twice? Or does it always have to be unique? As far as I know, you aren't supposed to for Half-Elf but I don't know if that is the general rule.

Kalashtar, an official race for D&D (not SRD), has CHA +1, WIS +1, Any +1 (including CHA and WIS).

I think that's fine. I meant more for where you choose multiple like Half-Elf but it would let you choose the same stat twice.

That was awesome! Thank you!


Added a support for search (search_after parameter)

Description
Added a sample that uses search_after parameter for https://github.com/opensearch-project/opensearch-py/issues/337.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

One more thing. Maybe we can write a sample that inserts many records and paginates through N pages instead until there are no more results? That seems more useful than a synthetic example with just 3 values.


Question : AWS S3

Is the library suitable for s3? are there any tips to make it work with s3 ? Thanks in advance

This package can only optimise local images. Copying from/to S3 is out of scope.

This does not suit me I have a non-persistent data app. Thanks


Filename information

Hi,
I work for ViQi Inc. and I've been exploring jump datasets to run our AI-based image analysis on. We'd like to work with your dataset and I have a quick question. In the cellpainting gallery, in the jump-pilot for example, there is a folder in workspace called load_data_csv that contains filenames/plate numbers/well/site etc. Where can I get this information for each of your image file names in the lincs-cell-painting dataset? Thanks for your time and all your efforts! Very excited to dig in.
Cheers, Reese

Hi @tfindley15 - thanks for reaching out!
@shntnu - do you happen to know how to access this? Maybe we can add to this repo? (I don't believe I have access to the S3 bucket anymore)

Hi @shntnu,
Just following up, any further information you could find regarding filename metadata? Thank you for your time!
Cheers, Reese

Hi @tfindley15, we do have this available but it needs a bit of a lift for someone to get to it
For our notes, someone will need to

[ ] restore these files https://imaging-platform.s3.amazonaws.com/projects/2015_10_05_DrugRepurposing_AravindSubramanian_GolubLab_Broad/workspace/load_data_csv/2016_04_01_a549_48hr_batch1 using these scripts
https://github.com/broadinstitute/imaging-backup-scripts/blob/master/restore_intelligent.py
[ ] inspect them for correctness and fix paths
[ ] upload them to cpg0004-lincs


fix: catch error if ssm extension is not ready

Lambda SSM extension might not be ready yet when we request. So, we need to handle properly otherwise it will crash lambda and error loop

This change deals with the lock, nothing with SSM related?

This change deals with the lock, nothing with SSM related?

Sorry, I will create a separated PR to fix lock.
For the SSM cannot read nRF Cloud API Key, the root cause is that reading parameter from outside handler might be failed due to lambda parameter store is not ready yet. Therefore, I reverted the previous changes and commit the new fix.


Error when I try to run main.py

Hello, I get this error when I try to run main.py , am I doing something wrong?

I have nearly the same error tracking in my instance. However, I only installed poetry using pip and ran a simple python3 main.py to receive the following output. It looks like the output is saying that my db is not valid or does not exist, but I can 1000% confirm it is the correct DC name.

I have nearly the same error tracking in my instance. However, I only installed poetry using pip and ran a simple python3 main.py to receive the following output. It looks like the output is saying that my db is not valid or does not exist, but I can 1000% confirm it is the correct TARGET_DB name.

We updated some dependencies which were causing installation issues. Can you check again? The previous user's issue was due to a change in Enum values after the VECTR backend was migrated. Your error is different.
If you continue to have issues, I'd recommend manually running commands in isolation with a graphql client to make sure your API key can create assessments.


Negotiate with bootstrap

This PR rolls bootstrap back from 5.2.1 to 4.6.2, and in so doing re-adds the spacing between the main panel and the right sidebar. It also changes the header so it stretches across the entire top of the screen (thus matching the footer), getting rid of the text-spilling-beyond-navbar-div bug (i.e. fixes #352). (I think the header would look better if it was the same width as the content + sidebar [when the window is wide, the Cantus logo ends up waaay off on the left side of the window], but this at least looks more tidy than it did)
PREVIOUSLY:

NOW:

Does this work for Safari?

This header looks still off. It is not how it used to be. It was the same width as the content, not the footer. See attached  (staging) for the expected layout.

Does this work for Safari?

I've been testing primarily with Safari, so yes. I also tried it on Chrome and Firefox

This header looks still off. It is not how it used to be. It was the same width as the content, not the footer. See attached (staging) for the expected layout.

Acknowledged:

It also changes the header so it stretches across the entire top of the screen (thus matching the footer), getting rid of the text-spilling-beyond-navbar-div bug (i.e. fixes #352). (I think the header would look better if it was the same width as the content + sidebar [when the window is wide, the Cantus logo ends up waaay off on the left side of the window], but this at least looks more tidy than it did)

I settled for something that's less ideal, thinking that if we had something that at least looked neat and tidy, it would be good enough for now and we could move on to improving the site's functionality. Maybe in the future we can get someone who's good at frontend to sort it out. If you (Junhao) want to spend some time figuring out how to make this work, I'd welcome that. But I don't think it's an effective use of my own time.

Ok, you can close this for now.


Can't enable Google Analytics 4 because Docsy version is too old

Subject says it all. This is related to #92.
Tasks:

[ ] Upgrade docsy. For some discussion about this see the next comment below.
[ ] Finalize GA4 setup started via #93:

[ ] Uncomment GA ID in Hugo config file
[ ] Drop daprblog/layouts/partials/hooks/head-end.html

/cc @nate-double-u

As a first step I'd suggest upgrading to v0.1.0. In doing so I've already noticed some local partial overrides that are causing problems, for example, notice how the TOC is misplaced:

It will be some effort to upgrade Docsy to the latest version. It might be worth considering the following first:

https://github.com/dapr/docs/issues/2948

close


keypadButtonBackgroundDrawable attribute is not working.

Hi,
I want to change keypad buttons background. There is an attribute that call keypadButtonBackgroundDrawable but it is not working. I put drawable to this attribute but it makes background as a primary color. Is there any possible solution to change background of keypad buttons?

The keypad button background color is taken from colorPrimary.


[draft] remove action_manager context

this is more of a PR to get some feedback from @Carreau, but provides an alternative to #2914.
@Carreau, I'm playing here with the removal of the context object on the action manager, which I'm still kind struggling with Please let me know if I've overlooked something big here, particularly with the active_layer context...
The primary difference here is that the register_viewer_action decorator is doing the job of converting all of the one-argument functions to zero-arg functions that operate on the current viewer, rather than trying to encode that in the action_manager context.

I have no opposition to this, basically you do want all action to be callable without any arguments, and it's up to the action creator to load access the right globals right ?


Fix Double Underline over Discord in Footer

Please resolve the merge conflicts and update the PR. @devilkiller-ag

Good job @devilkiller-ag
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

SignIn / SignUp in ClueLess Website.

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.

https://www.clueless.tech/profile/admin/43639341 @Rajdip019


"This authorization code has been used" error in passport-facebook

This is my piece of code
var passport = require('passport')
  , FacebookStrategy = require('passport-facebook').Strategy;

passport.use(new FacebookStrategy({
    clientID: <some_id>,
    clientSecret: '<some_secret>',
    callbackURL: "http://localhost:3000/auth/facebook/callback"
  },
  function(accessToken, refreshToken, profile, done) {
    console.log("Auth done");
  }
));

app.get('/auth/facebook', passport.authenticate('facebook'));

app.get('/auth/facebook/callback',
  passport.authenticate('facebook', { successRedirect: '/',
                                      failureRedirect: '/login' }));

First time after authorization it succeeds and and print "Auth done" for me and i can also see "authToken" and all other params coming. After that i think from the callback url i get below error.
failed to obtain access token (status: 400 data: {"error":{"message":"This authorization code has been used.","type":"OAuthException","code":100}})
    at
node_modules/passport-facebook/node_modules/passport-oauth/lib/passport-oauth/strategies/oauth2.js:125:38
    at exports.OAuth2.getOAuthAccessToken
(node_modules/passport-facebook/node_modules/passport-oauth/node_modules/oauth/lib/oauth2.js:131:18)
    at passBackControl
(node_modules/passport-facebook/node_modules/passport-oauth/node_modules/oauth/lib/oauth2.js:77:9)
    at IncomingMessage.exports.OAuth2._request.request.on.callbackCalled (node_modules/passport-facebook/node_modules/passport-oauth/node_modules/oauth/lib/oauth2.js:94:7)
    at IncomingMessage.EventEmitter.emit (events.js:126:20)
    at IncomingMessage._emitEnd (http.js:366:10)
    at HTTPParser.parserOnMessageComplete [as onMessageComplete] (http.js:149:23)
    at CleartextStream.socketOnData [as ondata] (http.js:1367:20)
    at CleartextStream.CryptoStream._push (tls.js:526:27)
    at SecurePair.cycle (tls.js:880:20)

Not able to figure out if i am doing something incorrectly.

thanks a lot.  in my case, i had a type, but reading this was what spurred me to catch the typo.  definitely needed is the:
done(null, ..whatever..);

I have the same same error and I have tried every possible code but still it doesn't works.
`(accessToken, refreshToken, profile, done) => {
User.findOne({ facebookId: profile.id }, (err, user) => {
if(err) { return next(err); }
if(!user) {
// If user is not registered
// Create new user
console.log(profile);
newUser = new User({
firstname: profile._json.first_name,
lastname: profile._json.last_name,
// email: profile.email,
facebookId: profile.id
});
// Save user
newUser.save((error) => {
if(error) {
console.log(error);
}
return done(err, newUser);
});
    } else {
      return done(err, user);
    }
  });

}));
};
`

any resolutions on this? still stuck on the same problem

same issue

any solutions?

@kiknag
On line 3 have you tried using "done" instead of "next"
if(err) { return next(err); } -> if(err) { return done(err); }

If you're getting this its possible youre redirecting back to the auth route after successfully authenticating once.

If you're getting this its possible youre redirecting back to the auth route after successfully authenticating once.

That was my issue. Dumb, but I'd swapped the redirects for the original call and the callback.
To paraphrase Deep Throat: follow the routes.

If you're getting this its possible youre redirecting back to the auth route after successfully authenticating once.

That was my issue. Dumb, but I'd swapped the redirects for the original call and the callback.
To paraphrase Deep Throat: follow the routes.


Be more descriptive about whats going on

I just had one of my testers call me up about this.  The liberty distro that we are using with the plugin uses runtimeUrl and pulls the file out of our artifactory server.  Its 160 megs and takes a while to get to the desktop.    Add additional project.logger.lifecycle() statements to tell the user whats going on, if its downloading something, then tell them.  possibly dump a status bar to the screen or something.  The more you tell users, the less support calls I get and support calls = money.

Do you mean something similar to: https://github.com/michel-kraemer/gradle-download-task

yes, exactly.  my testers are getting hung up when the thing just sits there and doesn't tell them whats going on.  if the dev is over the vpn, that file could take several minutes to download.  the testers are thinking the build is hung because its not communicating anything and kill it, not knowing that its actually downloading a file in the background.
this would solve that.

Version 2.0 of the plugin updates installLiberty to allow you to install using a dependency to Maven Central or your artifactory server. Configure it using the libertyRuntime dependency.
dependencies {
libertyRuntime group: 'com.ibm.websphere.appserver.runtime', name: 'wlp-webProfile7', version: '<IP_ADDRESS>'
}
When you download a dependency, you will get the progress indicator automatically.


invisible

hi! Can you do this? so that when the property is invisible, the captcha icon in the right, bottom corner is not visible. You can give a webview component, for example, flex = 0. And the background Loading component, darkening. Users are annoyed by this banner

it would be necessary to set the default color for the indicator for android, otherwise it is not visible

I think that is better to create a Prop to pass a custom ActivityIndicator.

I would like a way to do this too! When you say "create a prop to pass a custom ActivityIndicator", is that something we can do using the library or would we have to modify this repo's source code?

Done in 1.2.0 https://github.com/douglasjunior/react-native-recaptcha-that-works/releases/tag/1.2.0

could you please give an example of how to use the latest version (1.2.0) to hide the captcha icon on the bottom right corner? Would I pass a custom webview prop, custom modal prop, or a custom loading component?

could you please give an example of how to use the latest version (1.2.0) to hide the captcha icon on the bottom right corner? Would I pass a custom webview prop, custom modal prop, or a custom loading component?

@victor-cui-brigit , using the hideBadge prop alongside size=hidden

Take a look at the docs section: https://github.com/douglasjunior/react-native-recaptcha-that-works#props


espcoredump: Support for not overwriting existing core dump in flash (IDFGH-10907)

If there's an unattended boot loop or a crash that causes another crash on the next boot, it needs to be possible to avoid overwriting a saved core dump with another core dump.
Add an option to do this and skip writing core dumps if the partition isn't empty.
Fixes #12027.

"Not overwriting existing core dump"

Think this would be more clear:
"Existing coredump found. Will not overwrite."

I've rewritten the warning message to be clear about what happened

sha=ee3e01cf5c556e80615fd58b1baacf570865f679

The MR has been merged internally, it will be synced to Github after passing the internal CI

Thanks for contribution again, changes have been merged with https://github.com/espressif/esp-idf/commit/1feb3c9f9b4a9f193b5df7f8abdb19a772817018.


Verify packages install in a 32bit environment

I believe the package verifier should also check if the package installs/uninstalls on a 32bit environment (or at least with --x86 being passing on 64bit environment)
As far as I've understood only the 64bit edition of a package is currently tested, which may sometimes in rare cases report that the package works even if it doesn't in a 32bit environment.
If the package was also verified to work in a 32bit environment this could potentially reduce any package issues for users only wanting the 32bit version of the package.
https://github.com/chocolatey/choco/issues/1149#issuecomment-274490156

We used to run the verifier with -x86 as well, but that was against the 64bit system and sometimes would fail when there was only 64bit support or for 32 items that refuse to install on 64bit platforms. I think adding more platforms is a great idea - something I thought of initially but getting something shipped got us the current verifier. That being said, there will be improvements.


[resotocore][fix] Fix outer edge merge handler

Description
Fixed a bug where the existing edges were not overwritten, and therefore deleted during the collection
To-Dos

[ ] Add test coverage for new or updated functionality
[ ] Lint and test with tox
[ ] Document new or updated functionality (someengineering/resoto.com#XXXX)

Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

Codecov Report

Merging #956 (01e8bc1) into main (2666acc) will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
- Coverage   90.21%   90.19%   -0.02%
==========================================
  Files          68       68
  Lines       10202    10203       +1
==========================================
- Hits         9204     9203       -1
- Misses        998     1000       +2

Flag
Coverage Δ

resotocore
90.19% <57.14%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

resotocore/resotocore/db/graphdb.py
93.13% <50.00%> (-0.26%)
:arrow_down:

...tocore/action_handlers/merge_outer_edge_handler.py
88.88% <100.00%> (-0.14%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2666acc...01e8bc1. Read the comment docs.


Replace isort with Ruff

Import sorting was implemented in charliermarsh/ruff#465, and quickly fixed to be highly compatible with isort modulo one detail affecting (arguably improving) two of our import statements.
As long as we’re upgrading Ruff, also add some other newly-implemented error categories (one by me: charliermarsh/ruff#688).

Merged, huge thanks for doing this @andersk!


Dropbox integration reached its user limit

https://github.com/wulkano/kap/issues/486

@m2mathew Hey, I just upgraded the app to the next status and it says now it allows 500 users. I'm applying for it go to production level, but until then it has a cap of 500. Could you try again and let me know if it works?


[HOTFIX] File type metadata form display issues

Fixed it by removing use of formatDate() for file type temporal data.

@mauriel133 Can you review this small change?

+1


Feature/add term env dumb to win32

This change is definitely a nice-to-have, let me know if controlling output via environment variables is not something you want. It will help integration with some non-standard windows terminals. I also prefer the multiple line output.
It is kind of weird using "TERM" on windows though... any other idea?
Would address:
https://stackoverflow.com/questions/46970462/how-to-enable-multiline-logs-instead-of-single-line-progress-logs

I also prefer the multiple line output.

I use ninja | cat for that on Linux. Is there some Windows way for this, too?

It will help integration with some non-standard windows terminals.

Which ones? Using Ninja on MSYS2 will already disable smart terminal mode for example.

I use ninja | cat for that on Linux. Is there some Windows way for this, too?

Sadly I cannot find a Windows way to do this.  I'm sure PowerShell has this capability, but regular MS-DOS is poorly documented and has weird behaviors when it comes to pipes and redirects.  Redirecting stout to stdout like 1>&1 just results in "The handle could not be duplicated".  No way to pipe to echo since the pipe acts like a stream in another cmd.exe instance.  type requires a filename.  The only thing close is ninja | more, but if the output is longer than your display size it just says -- More? --, haha.

Which ones? Using Ninja on MSYS2 will already disable smart terminal mode for example.

Thanks for the input, using MSYS is an option I suppose, I just hate having 4 different unix emulators.  The one I'm using specifically is a proprietary Eclipse plugin which cannot take stdin and doesn't support re-writing lines (trust me, I hate it, just work stuff).
On second thought, this could be merged with something like https://github.com/ninja-build/ninja/pull/1230, would that be better?

On second thought, this could be merged with something like #1230, would that be better?

No, I would keep the frontend changes to a minimum.
I don't like the TERM=dumb behavior, but since we support it on Linux, we might as well do it on Windows, too.
Since LinePrinterTest basically repeats the functionality of LinePrinter, you could also skip testing this. Doesn't hurt either though ... I'm undecided.

Thanks for review, I will address comments.

Since LinePrinterTest basically repeats the functionality of LinePrinter, you could also skip testing this. Doesn't hurt either though ... I'm undecided.

My first commit didn't have this behavior, but then testing would fail on "actually dumb" terminals because I could never set them to "smart" unless I mocked out the OS calls (not super easy either since platform specific and multiple includes).

A test here https://github.com/ninja-build/ninja/blob/master/misc/output_test.py would be perfect, that script doesn't work on Windows yet though.
Maybe just skip testing this, is a relatively trivial change and there aren't any Linux tests for it either.

Thx!


Mac: Script/bootstrap fails to install apm

2018-12-04T18_33_48_069Z-debug.log
Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
When attempting to build atom on mac osx, I get the following error when it gets to the install apm step. This is when running script/bootstrap for the first time.
Error: The module '/Users/ryan/github/atom/atom/apm/node_modules/atom-package-manager/node_modules/git-utils/build/Release/git.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 64. This version of Node.js requires
NODE_MODULE_VERSION 57. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).

Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: Things to get bootstrapped
Actual behavior: Failed to install deps for apm install
Reproduces how often: 100%
Versions
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.
Node:	v10.10.0
Npm:	v6.4.1
Additional Information
Latest master
Any additional information, configuration or data that might be necessary to reproduce the issue.

Does running script/clean before building again clear things up for you?

It doesn't. The error comes back the same way after a script/clean. Also, if I completely delete the atom repository from my computer and re-clone before running script/bootstrap, I get the same issue. I attached a full npm log to the issue above, if that helps out at all.

@ryanolsonx Thanks for sharing the log file. After looking at the log, it looks like the build fails when trying to use node-gyp to build oniguruma. What's the output of python -V on your system?

python -V:
Python 2.7.15

In my case I found the "node" executable in the "atom-package-manager/bin" folder is v8.9.3.   I removed  it and copied my node v11.3.0 binary in there.  it then runs apm..  That was able to get me past this error in the bootstrap script..

I'm unable to reproduce this on macOS 10.14 and Ubuntu 16.04.
Builds were run on master branch (aad7705) using Node.js 11.3.0, npm 6.4.1, and Python 2.7.15.
It looks like the module version mismatch error originally reported might be a red herring caused by running either npm rebuild or npm install. The original error is not found in the shared log file, but instead reports a problem with building Oniguruma (v6.2.1). At first I had hoped this was caused by building with Python 3, but it seems like that is not the case after all.
@ryanolsonx Are you able to build Oniguruma on your system? Try something like the following
$ mkdir /tmp/foo && cd /tmp/foo
$ npm install<EMAIL_ADDRESS>--no-save

@parlock Would that indicate that we should upgrade the node binary in atom-package-manager? I'll give that a try in a bit here.
@thomasjo I was able to build oniguruma on my system with my node version 10.14.1 and npm version 6.4.1.

In my case if I do a script/clean it just puts back the old node binary when doing a script/bootstrap again.  So its not fixed, they need to update the bundled node binary to the newer version.

Figured it out, once you install the released Atom app, it went away.  So that must install something different that fixes the issue.  Odd, that you can't start clean with the source.

Figured it out, once you install the released Atom app, it went away. So that must install something different that fixes the issue.

Just to clarify @parlock, you need to do more than just a script/clean and then run bootstrap to reproduce the problem?

To reproduce, you have to not have Atom installed on the machine.  Then grab the source code fresh from GitHub.  Then doing a script/clean and script/bootstrap will fail.  Installing Atom appears to put in a working copy of apm that fixes it.  But apm won't build clean from source from a fresh setup..

I can confirm this is still an issue setting up a fresh install. I was able to reproduce with a stable version of Atom installed on my machine.
macOS: 10.14.3
Node: v11.11.0
npm: 6.9.0

With @50Wliu's great pull request removing node-gyp dependency in atom/apm#832 and #19189 it seems to fix the issue on my machine.

Curious how you reproduced this @vinkla?  I remember running script/clean and then removing  the installed Atom app I had from Applications/, but I wasn't able to reproduce.
Did you just run a script/clean and then script/bootstrap would reproduce the error for you?

Did you just run a script/clean and then script/bootstrap would reproduce the error for you?

Yes, that is correct. Didn't know removing the Atom application from the Applications directory was necessary. Is it?

Yes, that is correct. Didn't know removing the Atom application from the Applications directory was necessary. Is it? If so, should we add it to the hacking on Atom core guide?

Oh sorry, no that's not necessary for building - I was unable to reproduce the error mentioned in this issue by just running clean before bootstrap but I saw this comment above:

To reproduce, you have to not have Atom installed on the machine

I assumed that also meant that you if you installed Atom normally with the .zip, that would affect whether you could reproduce.


Ability to reset jit data

(hi! this is awesome, I can't believe I haven't run across samply until last week)
I've got Samply doing mixed Native + Mono/C# profiling in Unity on OSX via jitdump (nothing else can do this today!). However, Unity will frequently reload the entire .NET domain, and will re-jit the world when source needs to be recompiled. All existing jit mappings need to be invalidated at that point. Samply doesn't handle this today -- I don't think the jitdump format really handles it either. I've got two ideas:

Extend the jitdump format to add a "flush" record. Would just clear out all existing mappings. Teach samply about this flush record.
Have Samply (optionally via flag) treat a jitdump file that gets closed via eof or JIT_DUMP_CLOSE as a flush, and have it expect to receive a new jitdump file via the normal mechanism.

2 might be simplest -- I think I'd just have to remove the synthesized jit library from the profile. However, samply doesn't seem to have support for this? Is there support in the output format for points in time when process libs change (vs. just get added to)?

Hi Vlad! That's awesome that you're using it for Mono/C# profiling!
Samply should already be getting the right JIT symbols even in the "re-jit the world" case, as long as the JIT_CODE_LOAD timestamps are set correctly. On the current main branch, these timestamps are expected to be CLOCK_MONOTONIC nanoseconds (see here). (But I'd like to change it to be mach_absolute_time nanoseconds soon, because those values are easier to get from various timestamp classes used in browser engines.)
It should work as follows: When the re-jitted functions are added, they cause any overlapping old JIT functions to be evicted. Any samples which are taken after the re-jitting (i.e. any samples whose timestamps are >= the JIT_CODE_LOAD timestamp of the new function) will be symbolicated with the new function names.
There might be leftover JIT functions which don't exist any more but also aren't overlapping with any new JIT functions. I think that's fine - their code isn't executed so we won't see code addresses in those ranges.
I was considering option 2 in the past, but then I realized that I wouldn't need it if I new JIT functions just removed any overlapping existing JIT functions, so I implemented that instead.
Does that sound reasonable? Do things work correctly with the right timestamps for you?
You can check if the timestamps are correct by looking at the "Marker Chart" tab of the profiler, because we create JitFunctionAdd markers for every JIT_CODE_LOAD record. If the timestamps are correct, you should see those markers show up in the right place. If the timestamps are wrong, the markers might be outside the recorded range and won't be displayed.

Oh! That should 100% work. Amazing, will dig in and give it a shot!

Seems to work! Closing this. Markers look correct, and I see domain reloads happening (lots of re-jits) and things continue to look correct afterwards in the profile.


make externals dependencies work with yarn berry

Hi there,
Is your feature request related to a problem? Please describe.
Using Yarn Berry, bundling fails when using any external dependencies in esbuild config.
Code breaks because when hasExternals variable is true, commands related to yarn1 (e.g. yarn list) and not compatible with yarn berry are being invoked.
Describe the solution you'd like
Being able to declare external dependencies while using Yarn Berry.
Describe alternatives you've considered
I've patched the plugin so I could still bundle my lambdas with these 2 hotfixes, which are only temporary:

In pack.ts

-     const packagerDependenciesList = hasExternals
-        ? await packager.getProdDependencies(this.buildDirPath)
+        const packagerDependenciesList = {}

In packagers/yarn.ts

+        fs.writeFileSync(path.join(cwd, 'yarn.lock'), '');
         const args = useLockfile
-            ? ['install', '--frozen-lockfile', '--non-interactive', ...extraArgs]
-            : ['install', '--non-interactive', ...extraArgs];
+           ['install', ...extraArgs];

Sadly, it makes my lambdas .zip node_modules contain the entirety of their dependencies.
Additional context
If that's something you feel relevant, I would be happy to help implementing it !
Cheers 👋

Linked to https://github.com/floydspace/serverless-esbuild/issues/327
A fair bit of refactor will need to be done to support yarn2+ and pnpm. If you have time - be my guest. Otherwise, yeah I'll have to buckle up and get it done at some point


Save config for google chat notifications

Fixes #1177

Configures a google chat notifier when a build is passes / fails / timeouts on the master branch.
https://cloud.google.com/build/docs/configuring-notifications/notifiers

How does it work?

Cloud run free tier:

Tested by removing the "master" filter and triggering a cloud build. A notification was sent to the google chat space after the build was complete.

@gino-m  PTAL?
P.S. The same config can be extended to be used for web repo

Codecov Report

Merging #1194 (330aa81) into master (10e0938) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1194   +/-   ##
=========================================
  Coverage     29.64%   29.64%
  Complexity      783      783
=========================================
  Files           291      291
  Lines          7638     7638
  Branches        346      346
=========================================
  Hits           2264     2264
  Misses         5266     5266
  Partials        108      108

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

The config looks much less intimidating than I expected! Qq - does this also enable email notifications?

No, email notifications would require configuring a SMTP server and saving the sender email credentials in the secret manager. https://cloud.google.com/build/docs/configuring-notifications/configure-smtp

@gino-m Can we merge this now?

@JSunde Can you please approve this?


Create a HOWTO for newcomers to the repo

The problem
During the BoF meeting in TPCiG, it was suggested that a how to guide to get into the documentation would be good.
Suggestions
Create it as a markdown or POD6 page so that everyone can follow it. Link all relevant pieces of knowledge that are needed, from the POD6 specification to how to work with PRs and issues.

I just wrote a post on perl6 users and suggested this. I have begun to review documentation with the intent of drafting something.

Great. It will really help this hacktoberfest, and beyond.


Collision Code Readability

Improve the readability of the wall and platform collision code.

git fetch origin
git checkout 9-collision-code-readability


Sana (as of brokenj language) has no method overloading

Sana still does not support method overloading, and method duplication is allowed.
These needs to be introduced at least in ooj language.

This should be fixed now (by this commit d5424b9)

This should be fixed now (by this commit d5424b9)


TI errors.

Traceback (most recent call last):
File "D:\kohya_ss\train_textual_inversion.py", line 498, in
train(args)
File "D:\kohya_ss\train_textual_inversion.py", line 260, in train
train_util.patch_accelerator_for_fp16_training(accelerator)
File "D:\kohya_ss\library\train_util.py", line 1345, in patch_accelerator_for_fp16_training
org_unscale_grads = accelerator.scaler.unscale_grads
AttributeError: 'NoneType' object has no attribute 'unscale_grads'
I am getting a few errors when trying to do a TI training and this is just one of them. Another is about - File "D:\kohya_ss\train_textual_inversion.py", line 356, in train
unwrap_model(text_encoder).get_input_embeddings().weight[index_no_updates] = orig_embeds_params[index_no_updates]
RuntimeError: Index put requires the source and destination dtypes match, got Half for the destination and Float for the source.
File "D:\kohya_ss\train_textual_inversion.py", line 498, in
train(args)
File "D:\kohya_ss\train_textual_inversion.py", line 260, in train
train_util.patch_accelerator_for_fp16_training(accelerator)
File "D:\kohya_ss\library\train_util.py", line 1345, in patch_accelerator_for_fp16_training
org_unscale_grads = accelerator.scaler.unscale_grads
AttributeError: 'NoneType' object has no attribute 'unscale_grads'

I don't have enough vram to remove that option (I chose fp16 vs bf16) and how do I find out which version of accelerator I have?


Build automation breaking because of missing rexml

Describe the Bug
When PRs are submitted to this codebase, platform-ios verification fails with LoadError - cannot load such file -- rexml/document
Steps To Reproduce
Submit any PR to this repo
Replicable on Example App?
Yes
How I can Help
I'm going to submit a PR in attempt to fix this

This has apparently happened because the server automation moved to Ruby 3.0.5. I'm told by the interwebs that Ruby 3.0+ builds need to explicitly specify rexml instead of counting on the defaults. This is why automation was broken.


Refresh

Required Features

[x] Files search

fuzzy search
inside project
ignoring hidden folders
https://github.com/liuchengxu/vim-clap ?

[x] Grep-like
[x] List buffers
[ ] Kill buffer and open previous one without closing pane
[x] Autocomplete
[x] Linter
[x] Comment

Plug 'tpope/vim-commentary'?

[x] Tmux support

Why not use Vim's C-W prefix? Seems to work for me. · Issue #193 · christoomey/vim-tmux-navigator · GitHub

Clojure

[ ] work with forms

move  elements
move parenthesis

[ ] connect to a REPL
[ ] start a REPL
[ ] eval buffer
[ ] eval current form
[ ] run current test
[ ] good test feedback
[ ] rename variables
[ ] code actions
[ ] autoimport namespaces

GitHub - technomancy/slamhound: Slamhound rips your namespace form apart and reconstructs it.

[ ] format
[ ] smart parenthesis

GitHub - eraserhd/parinfer-rust: A Rust port of parinfer.

[ ] Align maps, variables

junegunn/vim-easy-align ?

[ ] clean up namespace
[ ] snippets

Dart/Flutter

[x] auto format on save
[x] run test file

https://github.com/vim-test/vim-test/pull/511 !!
GitHub - tpope/vim-dispatch: dispatch.vim: Asynchronous build and test dispatcher
GitHub - radenling/vim-dispatch-neovim: Adds neovim support to vim-dispatch

[x] rename variables
[x] refactoring actions
[x] linter
[x] show arguments
[x] auto complete
[x] auto import
[x]  organize imports
[ ] snippets

React Native

[ ] Syntax básica

JSX/TSX

Optional Features

[ ] Space-vim-like shortcuts

GitHub - liuchengxu/vim-which-key: Vim plugin that shows keybindings in popup
GitHub - liuchengxu/space-vim: Lean & mean spacemacs-ish Vim distribution
https://github.com/SpaceVim/SpaceVim

[x] List marks
[x] Font with icons

nerd-fonts/patched-fonts/JetBrainsMono at master · ryanoasis/nerd-fonts · GitHub
GitHub - ryanoasis/vim-devicons: Adds file type icons to Vim plugins such as: NERDTree, vim-airline, CtrlP, unite, Denite, lightline, vim-startify and many more

[ ] Project per tab
[ ] Files tree

NERDTree? (+ nerd tree-git-plugin)

[ ] Manipulate FS

GitHub - tpope/vim-eunuch: eunuch.vim: Helpers for UNIX

[ ] Git commands

GitHub - tpope/vim-fugitive: fugitive.vim: A Git wrapper so awesome, it should be illegal

GitHub - tpope/vim-projectionist: projectionist.vim: Granular project configuration
[ ] Distraction free mode

goo.vim
limelight.vim

[ ] Markdown preview

https://github.com/iamcco/markdown-preview.nvim#buy-me-a-coffee-

[ ] Indent guides

GitHub - nathanaelkane/vim-indent-guides: A Vim plugin for visually displaying indent levels in code

[ ] vim-repeat?

I can confirm the plugin for markdown iamcco/markdown-preview.nvim works great and customer config  let g:mkdp_browser = 'safari' but you can choose the browser you like more

Merging this way, I'll create other PRs focusing on Clojure and optional features.