dropUnique() failing when a column is part of foreign key constraint (mysql bug)

Hi guys,
I encountered this issues with a migration rollback failing to remove a unique index (in my case, composed) if one of the columns used in it are also used in a foreign key constraint and, hence, in a automatically created index.
This seems to be a known bug in mysql: http://bugs.mysql.com/bug.php?id=37910%22%3EMySQL
If I have the following code in the up() method of the migration:
Schema::table('group_user', function (Blueprint $table) {             $table->unique(['user_id', 'group_id']);  });
I expect the down() method to remove the unique index:
Schema::table('groups_users', function (Blueprint $table) {             $table->dropUnique('group_user_user_id_group_id_unique'); });
But the dropUnique() fails with the following error:
[PDOException] SQLSTATE[HY000]: General error: 1553 Cannot drop index 'group_user_user_id_group_id_unique': needed in a foreign key constraint
The workaround suggested in the link to mysql bug report is to recreate a foreign key index in the same mysql statement right after a unique index is dropped.
Unfortunately, the way the dropUnique() method is written, it doesn't allow for chained methods to drop and create index in the same query.
This sql query executed directly works:
ALTER TABLEgroup_user DROP INDEXgroup_user_group_id_user_id_unique, ADD INDEX (user_id), ADD INDEX (group_id) ;
The most obvious use case for that would be when we have a pivot table that we want to have unique records (friendship relationships, group relationships, etc.).
One of the solutions would be to allow chaining of dropUnique() with index().
Best regards,
Alex

Why don't you do something like this before dropping any foreign keys etc ..
Schema::dropForeignKeyConstraints();

// Your code

Schema::enableForeignKeyConstraints();

Feel free to discuss on the forums. :)

Thanks for the response. Yep, seems that disabling the foreign keys in the migration would work for the purpose of dropping the unique index. : )

I ran into the same problem today as well. I found that disabling foreign key constraints did not help. I also found that there was slightly different behaviour depending on whether all migrations were run in a batch, or the most recent migration was run in its own batch.
In the end I decided to go with this which, while not the greatest, works:
if (DB::connection() instanceof MySqlConnection) {
    DB::statement('ALTER TABLE `foos` DROP INDEX `foos_bar_id_name_unique`, ADD INDEX (bar_id)');
} else {
    Schema::table('ratings', function (Blueprint $table) {
        $table->dropUnique(['bar_id', 'name']);
    });
}

Note: If the index being added were to be named according to the foreign key (i.e. how laravel usually does it) then the ADD INDEX part should read:
ADD INDEX `foos_bar_id_foreign` (bar_id)

but this breaks if you do two migrate/rollback cycles (on the second rollback it complains about having a "duplicate key name"). With this solution, if you do two migrate/rollback cycles then you end up with two indexes on bar_id.

@GrahamCampbell Why close this? The bug looks legit.
Here is what I found:
I have two migrations set up like this:
// First migration:
$table->integer('experiment_id')->unsigned()->nullable();
$table->foreign('experiment_id')->references('id')->on('experiments');
$table->integer('order_batch_id')->unsigned();
$table->foreign('order_batch_id')->references('id')->on('order_batches')->onDelete('set null');

// Second migration:
$table->unique(['experiment_id', 'order_batch_id'], 'exp_batch');

Running them yields the following SQL schema:
# After the first migration:
mysql> SHOW INDEX FROM orders;
+--------+------------+-------------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| Table  | Non_unique | Key_name                      | Seq_in_index | Column_name    | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment | Index_comment |
+--------+------------+-------------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| orders |          0 | PRIMARY                       |            1 | id             | A         |           0 |     NULL | NULL   |      | BTREE      |         |               |
| orders |          1 | orders_experiment_id_foreign  |            1 | experiment_id  | A         |           0 |     NULL | NULL   | YES  | BTREE      |         |               |
| orders |          1 | orders_order_batch_id_foreign |            1 | order_batch_id | A         |           0 |     NULL | NULL   | YES  | BTREE      |         |               |
+--------+------------+-------------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+

# After the second migration:
mysql> SHOW INDEX FROM orders;
+--------+------------+-------------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| Table  | Non_unique | Key_name                      | Seq_in_index | Column_name    | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment | Index_comment |
+--------+------------+-------------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+
| orders |          0 | PRIMARY                       |            1 | id             | A         |           0 |     NULL | NULL   |      | BTREE      |         |               |
| orders |          0 | exp_batch                     |            1 | experiment_id  | A         |           0 |     NULL | NULL   | YES  | BTREE      |         |               |
| orders |          0 | exp_batch                     |            2 | order_batch_id | A         |           0 |     NULL | NULL   | YES  | BTREE      |         |               |
| orders |          1 | orders_order_batch_id_foreign |            1 | order_batch_id | A         |           0 |     NULL | NULL   | YES  | BTREE      |         |               |
+--------+------------+-------------------------------+--------------+----------------+-----------+-------------+----------+--------+------+------------+---------+---------------+

We can see the index orders_experiment_id_foreign disappear when the second migration is run and therefore a subsequent call to $table->dropUnique('exp_batch'); crashes with
Cannot drop index 'exp_batch': needed in a foreign key constraint (SQL: alter table `orders` drop index `exp_batch`)

The workaround I came up with is to manually add the foreign key index during the rollback so that the table actually comes back as it was before the migration.
// Rollback script
Schema::table('orders', function($table)
{
    // Add the missing index
    $table->index('experiment_id', 'orders_experiment_id_foreign');
});
Schema::table('orders', function($table)
{
    $table->dropUnique('exp_batch');
});

The original poster's issue was resolved. If you have an issue that you feel is a bug, create an new issue with details. It does look like expected behavior though.

I created the compound unique index for some columns before creating it for the individual columns. I think this may be what caused it for me. In my migration, I dropped the foreign keys, then I removed the unique index, then re-added the foreign keys. This was all that would work for me.

Thank you, @hmil . I'll follow your approach.
I agree that this bug should be reopened until Laravel fixes this unexpected behavior.

Thanks @hmil - it worked for me too

I created the compound unique index for some columns before creating the foreign keys for the individual columns. I think this may be what caused it for me. In my migration, I dropped the foreign keys, then I removed the unique index, then re-added the foreign keys. This was all that would work for me.

For me, this is the best solution.

Be careful for disable foreign key checks, even you can drop the unique index successfully, you may have triggered another MySQL bug https://bugs.mysql.com/bug.php?id=68148, which will break your application.

I second @resuta566, that also worked for me.

@hmil I've tried your solution, but when I add the index with the $table->index, the index is not removed when the $table->unique() is run, doing exactly like your code, anyone has other thougths?


TileDB-SOMA 1.2.6 pre-release check

Following our currently established procedure at
https://github.com/single-cell-data/TileDB-SOMA/wiki/Branches-and-releases
As always (please see the above wiki) this isn't to be released but rather to check the feasibility of tagging a release.
Food for thought: The four PRs at the tip of https://github.com/single-cell-data/TileDB-SOMA/commits/release-1.2 as of today are all app-level -- and as such shouldn't affect package pins -- except for https://github.com/single-cell-data/TileDB-SOMA/pull/1484/files. That PR affects the numba pin, only for Python 3.11: from 0.57.0rc1 to 0.57.0. However, in this repo's recipe/meta.yaml we have no numba constraints so I don't understand what we do or do not need to do new here.
Another note: I haven't re-renedered yet but I will attempt to check to see if we need to re-render.

TIL @jdblischak -- thanks -- always one more thing to put into my runbook!

That PR affects the numba pin, only for Python 3.11: from 0.57.0rc1 to 0.57.0. However, in this repo's recipe/meta.yaml we have no numba constraints so I don't understand what we do or do not need to do new here.

I had previously raised concern about the the lack of a numba pin. However, I remembered that currently tiledbsoma-py is only built for Python 3.7, 3.8, 3.9, and 3.10
https://github.com/TileDB-Inc/tiledbsoma-feedstock/blob/7610f021f4b7c7d09b5934f84a89bdbaf04404c6/recipe/conda_build_config.yaml#L16-L21
And even conda-forge doesn't yet build for Python 3.11
https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/28852e81a79eeb6f9ab63370647e582f8769021b/recipe/conda_build_config.yaml#L669-L674
I skimmed  https://github.com/single-cell-data/TileDB-SOMA/issues/1463 and https://github.com/single-cell-data/TileDB-SOMA/pull/1472, but the constraints are not entirely clear to me. Python 3.11 appears to require numba 0.57, which we don't need to worry about in this recipe until we start building binaries for Python 3.11. But what about Python 3.7, 3.8, 3.9, and 3.10? Can they really not work with numba 0.57? If that's the case, then yes, we should add a pin such as numba <0.57

Can they really not work with numba 0.57?

@jdblischak that's not the reason for the 0.57 pin for Python 3.11 only
It was the other way around, in fact -- older numba wouldn't work with Python 3.11, and in fact, we couldn't support tiledbsoma-py on Python 3.11 at all until numba 0.57.0rc1 came out
Links:

https://github.com/single-cell-data/TileDB-SOMA/issues/544
https://github.com/single-cell-data/TileDB-SOMA/issues/1463

If we aren't doing Python 3.11 in this feedstock repo, and if only Python 3.11 leads to the numba==0.57 constraint, then I'm in favor of not adding any numba constraints right now. (Solving is hard, and the more pins we add, the harder it gets.)

Looking at the release notes for numba 0.57, my understanding is that numba 0.57 is the first to add support for Python 3.11, and that the minimum required version was bumped to Python 3.8. Thus for the purposes of this recipe, we could update the numba pin to enforce that Python 3.7 requires numba < 0.57. However, one could reasonably argue that this is overkill. Since numba 0.57 dropped support for Python 3.7, conda-forge obviously isn't building a binary for this combination (in fact it has dropped automatic support for Python 3.7, and feedstocks have to opt-in to continue building for Python 3.7 like we have for tiledbsoma-py).

If we aren't doing Python 3.11 in this feedstock repo, and if only Python 3.11 leads to the numba==0.57 constraint, then I'm in favor of not adding any numba constraints right now. (Solving is hard, and the more pins we add, the harder it gets.)

@johnkerl agreed

Another note: I haven't re-renedered yet but I will attempt to check to see if we need to re-render.

I rerendered locally to test. The only update was dropping the R 4.1 build. As long at the R 4.1 build continues to succeed, I see no rush to remove it (and thus recommend skipping rerendering for this release)

Also, I confirmed in the linux-64 build that the locally built libtiledbsoma was always installed when solving the environments to build the API clients (ie the recent addition of {{ pin_subpackage('libtiledbsoma', exact=True) }} to the host requirements is continuing to work as expected)


chore: update deprecated merge_imports && fmt

What does this PR do

merge_imports is deprecated now, update it to imports_granularity.
Format code

Reference: https://github.com/rust-lang/rustfmt/issues/3362 for context. Change looks good to me. The fmt output looks no different to me
cargo fmt -- --check
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.

I'll fix the above error in my CI branch.

Yeah, this feature needs a nightly toolchain


Notification setColor Android Lollipop

I was able to add my custom notification icon, with guidance from issues found here, but when I add the setColor call to the NotificationCompat.Builder the plugin fails to build. Has anyone else added this to set the background color of the notifiation circle on lollipop? Its just a very plain gray by default.

I updated the 'android-support-v13.jar' from the copy in my SDK (android-sdk\extras\android\support\v13) and then it worked.


feat: document restricting numbers within a range

This is something new people bump into relatively often, so it seems nice to document the new manner in which they can achieve this.

I've already simplified the example, but I'm still thinking of a better category to place it.


feat: add support for shadow DOM styling

Close #41

I don't think the original file lt2-paper-slider,js should be renamed (is the original file from the source library).

@paodb I'm not sure how to name the web-components. (I think it's a breaking change either way)


anrDetection integration in renderer is causing an error for console.assert

Is there an existing issue for this?

[x] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
[x] I have reviewed the documentation https://docs.sentry.io/
[x] I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?
Sentry Saas (sentry.io)
Electron SDK Version
4.24.0
Electron Version
31.7.3
What platform are you using?
MacOS
Link to Sentry event
No response
Steps to Reproduce
Hi! I'm pretty new to development, electron, and sentry, so forgive me if I'm missing something here.
I'm trying to enable anrDetection for my electron application. Per the documentation, I've added it in both the main and renderer process. However when I booted up electron, my console in main process outputs this at start:
[0] [48570:1116/133807.614927:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
[0] [48570:1116/133807.614997:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
[0] [48570:1116/133807.657118:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
[0] [48570:1116/133807.657147:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
[0] [48570:1116/133807.912459:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
[0] [48570:1116/133807.912488:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
[0] [48570:1116/133807.912510:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
[0] [48570:1116/133807.912541:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
[0] [48570:1116/133807.912558:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
[0] [48570:1116/133807.912583:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
[0] [48570:1116/133807.912653:ERROR:CONSOLE(1)] "console.assert", source: devtools://devtools/bundled/core/sdk/sdk.js (1)
I'm including the number of times it was repeated as a possible indication for the workers process which might be causing this.
This message does not appear in DevTools.
When I disable anrDetection in renderer, but keep the integration in main, the errors go away.
Expected Result
No console messages of any kind
Actual Result
Main Configuration

Renderer Configuration

Hello @tsekiguchi, thanks for filing this.
I'm not really spotting anything wrong from your config, would you mind providing a minimal reproduction repo so we can investigate this further?

Closing this for cleanup. @tsekiguchi if you're able to provide a reproduction we can re-open and keep investigating. Thanks!


Fix English names of Finnish numbering areas Uusimaa and Häme

Fix the English names of Finnish numbering areas Uusimaa and Häme
in geocoding list according to the official numbering plan:
http://www.viestintavirasto.fi/attachments/maaraykset/Regulation_32.pdf
The previous names were seemingly user-made translations that are not
actually in use (confirmed by Google search as well), but were listed in
Wikipedia (with no references/sources).
The changes are:
Tavastia => Häme
Nylandia => Uusimaa
I've made this PR on top of PR #566 since otherwise they would conflict.

Rebased on top of updated 566.
Also, updated the commit message. I found some actual uses of "Häme = Tavastia" on internet after all, though still nothing official.
I still think Häme would be better, since it is used by all official sources for the region, e.g. the Regional Councils of Häme in English:
http://www.hameenliitto.fi/en/hame-region

Hi, sorry this took so long...
If you can merge the changes from upstream I'll approve and merge this as-is.
Since you signed the CLA, if you can't get to it just let us know and we'll implement it.
Thanks for your patience!

Merged changes from upstream as requested, no conflicts. Let me know if want me to rebase instead.

Nope, this is great, thanks!


Added editorconfig file

#6

Tab please

I changed the default behaviour and the js files to tabs but left yml to spaces because that seems to be the standard for it


Update virtual-user.md

The description "Preview mode" in the note field is confusing to customers as it is no longer used in the M365 Admin Center UI.  I've updated the note to reflect the label on the toggle switch for "The new admin center" mode in the upper left hand corner of the M365 Admin Center UI.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dstrome PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


No output or errors from nunit tests - 1.10.0-beta2

Environment data
dotnet --info output:
.NET Command Line Tools (1.0.4)

Product Information:
 Version:            1.0.4
 Commit SHA-1 hash:  af1e6684fd

Runtime Environment:
 OS Name:     debian
 OS Version:  8
 OS Platform: Linux
 RID:         debian.8-x64
 Base Path:   /usr/share/dotnet/sdk/1.0.4

VS Code version:
C# Extension version: 1.12.1
omnisharp-vscode: 1.10.0-beta2
Steps to reproduce
Here is a repo which exactly reproduces this https://github.com/tomzo/bug-nunit-no-output-vscode
Just run
dotnet restore
dotnet test DefaultTests/DefaultTests.csproj

Then try the same in vscode by clicking on run test on one of the tests.
Expected  behavior
There are tests which are failingand there is standard output printed in one of the tests.
[Test]
        public void Test1()
        {
			new Class1 ();
            Console.WriteLine("Test body running..");
        }

		[Test]
        public void Test2()
        {
            Assert.AreEqual(2,26);
        }

I would expect to see both the stdout and especially failed asserts from nunit test cases.
Actual behavior
In VsCode  .NET Test Log output just counts the failed tests
NUnit Adapter <IP_ADDRESS>: Test discovery starting
NUnit Adapter <IP_ADDRESS>: Test discovery complete
NUnit Adapter <IP_ADDRESS>: Test execution started
Running selected tests in /ide/work/nunit-repro/DefaultTests/bin/Debug/netcoreapp1.0/DefaultTests.dll
NUnit3TestExecutor converted 2 of 2 NUnit test cases
NUnit Adapter <IP_ADDRESS>: Test execution complete

Total tests: 1. Passed: 0. Failed: 1. Skipped: 0

The output when running with dotnet is fine:
$ dotnet test  DefaultTests/DefaultTests.csproj
Build started, please wait...
/usr/share/dotnet/sdk/1.0.4/Sdks/Microsoft.NET.Sdk/Sdk/Sdk.targets(40,3): warning MSB4011: "/usr/share/dotnet/sdk/1.0.4/Microsoft.CSharp.targets" cannot be imported again. It was already imported at "/ide/work/nunit-repro/ExampleLib/ExampleLib.csproj (28,3)". This is most likely a build authoring error. This subsequent import will be ignored.
Build completed.

Test run for /ide/work/nunit-repro/DefaultTests/bin/Debug/netcoreapp1.0/DefaultTests.dll(.NETCoreApp,Version=v1.0)
Microsoft (R) Test Execution Command Line Tool Version <IP_ADDRESS>
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
NUnit Adapter <IP_ADDRESS>: Test execution started
Running all tests in /ide/work/nunit-repro/DefaultTests/bin/Debug/netcoreapp1.0/DefaultTests.dll
NUnit3TestExecutor converted 2 of 2 NUnit test cases
NUnit Adapter <IP_ADDRESS>: Test execution complete
Failed   Test2
Error Message:
   Expected: 2
  But was:  26

Stack Trace:
at DefaultTests.UnitTest1.Test2() in /ide/work/nunit-repro/DefaultTests/UnitTest1.cs:line 20

Total tests: 2. Passed: 1. Failed: 1. Skipped: 0.
Test Run Failed.
Test execution time: 1.8351 Seconds

Hello @tomzo!
Are you using the alpha version of NUnit?
  <ItemGroup>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0"/>
    <PackageReference Include="NUnit" Version="3.6.1"/>
    <PackageReference Include="NUnit3TestAdapter" Version="3.8.0-alpha1"/>
  </ItemGroup>

Hi @bernardbr ,
Exactly, as you can see here

Hello @tomzo!
I cloned your example and changed only .csproj and after this worked fine.  Could you check if it resolves your problem?
bug-nunit-no-output-vscode.zip

Oh, I also created the config files launch.json and tasks.json

I cloned your example and changed only .csproj and after this worked fine

It does not help for me, we must have something different in environment?
I downloaded your example. Ran dotnet restore then opened in vscode, and this is the output I see after clicking on run test above Test2:
NUnit Adapter <IP_ADDRESS>: Test discovery starting
NUnit Adapter <IP_ADDRESS>: Test discovery complete
NUnit Adapter <IP_ADDRESS>: Test execution started
Running selected tests in /ide/work/nunit/DefaultTests/bin/Debug/netcoreapp1.1/DefaultTests.dll
NUnit3TestExecutor converted 2 of 2 NUnit test cases
NUnit Adapter <IP_ADDRESS>: Test execution complete

Total tests: 1. Passed: 0. Failed: 1. Skipped: 0

Other than simplifying the csproj, you have changed target framework to netcoreapp1.1, which was netcoreapp1.0, do you think this would have any impact? I am running all this on top of official docker image microsoft/dotnet:1.0.5-sdk
I will add you as collaborator to that repo. Please push to some branch, instead of the zips.

@tomzo In my machine, your project won't works with DebugType tag on DefaultTests.csproj
I Just removed it and the tests ran!

In my machine, your project won't works with DebugType tag on DefaultTests.csproj
I Just removed it and the tests ran!

Tests are running fine in my environment either with or without DebugType. But the issue is about the test output in vscode.
Test2 is failing because of  Assert.AreEqual(2,26);  and the error is not shown. Can you post your output from visual studio code when you run that test?

But in my machine the output for test task works fine:
Build started, please wait...
C:\Program Files\dotnet\sdk\1.0.4\Sdks\Microsoft.NET.Sdk\Sdk\Sdk.targets(40,3): warning MSB4011: "C:\Program Files\dotnet\sdk\1.0.4\Microsoft.CSharp.targets" cannot be imported again. It was already imported at "c:\Projetos\testes\bug-nunit-no-output-vscode\ExampleLib\ExampleLib.csproj (28,3)". This is most likely a build authoring error. This subsequent import will be ignored.
Build completed.

Test run for c:\Projetos\testes\bug-nunit-no-output-vscode\DefaultTests\bin\Debug\netcoreapp1.0\DefaultTests.dll(.NETCoreApp,Version=v1.0)
Ferramenta de Linha de Comando de Execução de Teste da Microsoft (R) Versão <IP_ADDRESS>
Copyright (c) Microsoft Corporation. Todos os direitos reservados.

Iniciando execução de teste, espere...
NUnit Adapter <IP_ADDRESS>: Test execution started
Running all tests in c:\Projetos\testes\bug-nunit-no-output-vscode\DefaultTests\bin\Debug\netcoreapp1.0\DefaultTests.dll
NUnit3TestExecutor converted 2 of 2 NUnit test cases
NUnit Adapter <IP_ADDRESS>: Test execution complete
Test2 com falha
Mensagem de erro:
   Expected: 2
  But was:  26

Rastreamento de pilha:
at DefaultTests.UnitTest1.Test2() in c:\Projetos\testes\bug-nunit-no-output-vscode\DefaultTests\UnitTest1.cs:line 20

Total de testes: 2. Aprovados: 1. Com falha: 1. Ignorados: 0.
Falha na Execução de Teste.
Tempo de execução de teste: 2,5723 Segundos

Let's compare our enviroment settings:
Dotnet info:
.NET Command Line Tools (1.0.4)
Product Information:
Version:            1.0.4
Commit SHA-1 hash:  af1e6684fd
Runtime Environment:
OS Name:     Windows
OS Version:  6.1.7601
OS Platform: Windows
RID:         win7-x64
Base Path:   C:\Program Files\dotnet\sdk\1.0.4
VsCode version:
Version 1.12.1
Commit f6868fce3eeb16663840eb82123369dec6077a9b
Date 2017-05-04T21:26:50.689Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0
Omnisharp-vscode version:
1.10.0-beta2
Nunit version:
3.8.0-alpha1
In my case I'm running on Windows. I'll try run on Ubuntu.

@bernardbr thank you for helping with this. But I think that you keep invoking a different action.
When I run a test task like you just did, then I also get the correct output:
Starting test execution, please wait...
NUnit Adapter <IP_ADDRESS>: Test execution started
Running all tests in /ide/work/nunit/bug-nunit-no-output-vscode/DefaultTests/bin/Debug/netcoreapp1.0/DefaultTests.dll
NUnit3TestExecutor converted 2 of 2 NUnit test cases
NUnit Adapter <IP_ADDRESS>: Test execution complete
Failed   Test2
Error Message:
   Expected: 2
  But was:  26

Stack Trace:
at DefaultTests.UnitTest1.Test2() in /ide/work/nunit/bug-nunit-no-output-vscode/DefaultTests/UnitTest1.cs:line 20
Total tests: 2. Passed: 1. Failed: 1. Skipped: 0.
Test Run Failed.
Test execution time: 1.8279 Seconds

But that runs all tests.
There is no output however when I click on run test above the test name. Like on this screenshot

Ooh! Ok. I'm sorry, I didn't understand it before!
I don't know, but for me, in this case, the nunit do the "focus" only in "ran test" ignoring the other ones. You can try run the Test1 and see this output:
Running test DefaultTests.UnitTest1.Test1...
Microsoft (R) Build Engine version 15.1.1012.6693
Copyright (C) Microsoft Corporation. All rights reserved.

C:\Program Files\dotnet\sdk\1.0.4\Sdks\Microsoft.NET.Sdk\Sdk\Sdk.targets(40,3): warning MSB4011: "C:\Program Files\dotnet\sdk\1.0.4\Microsoft.CSharp.targets" cannot be imported again. It was already imported at "c:\Projetos\testes\bug-nunit-no-output-vscode\ExampleLib\ExampleLib.csproj (28,3)". This is most likely a build authoring error. This subsequent import will be ignored.
  ExampleLib -> c:\Projetos\testes\bug-nunit-no-output-vscode\ExampleLib\bin\Debug\netcoreapp1.0\ExampleLib.dll
  DefaultTests -> c:\Projetos\testes\bug-nunit-no-output-vscode\DefaultTests\bin\Debug\netcoreapp1.0\DefaultTests.dll

Build succeeded.

C:\Program Files\dotnet\sdk\1.0.4\Sdks\Microsoft.NET.Sdk\Sdk\Sdk.targets(40,3): warning MSB4011: "C:\Program Files\dotnet\sdk\1.0.4\Microsoft.CSharp.targets" cannot be imported again. It was already imported at "c:\Projetos\testes\bug-nunit-no-output-vscode\ExampleLib\ExampleLib.csproj (28,3)". This is most likely a build authoring error. This subsequent import will be ignored.
    1 Warning(s)
    0 Error(s)

Time Elapsed 00:00:02.31

NUnit Adapter <IP_ADDRESS>: Test discovery starting
NUnit Adapter <IP_ADDRESS>: Test discovery complete
NUnit Adapter <IP_ADDRESS>: Test execution started
Running selected tests in c:\Projetos\testes\bug-nunit-no-output-vscode\DefaultTests\bin\Debug\netcoreapp1.0\DefaultTests.dll
NUnit3TestExecutor converted 2 of 2 NUnit test cases
NUnit Adapter <IP_ADDRESS>: Test execution complete

Total tests: 1. Passed: 1. Failed: 0. Skipped: 0

I miss an option to run and debug all test fixtures, but I'm afraid this doesn't exist on VsCode.

I miss an option to run and debug all test fixtures, but I'm afraid this doesn't exist on VsCode.

That's not a big problem.

You can try run the Test1 and see this output:

Yes, I can see that output from the very begging.
To be clear - my point is that for Test2 it should contain Error message and stack trace:
NUnit3TestExecutor converted 2 of 2 NUnit test cases
NUnit Adapter <IP_ADDRESS>: Test execution complete
Failed   Test2
Error Message:
   Expected: 2
  But was:  26

Stack Trace:
at DefaultTests.UnitTest1.Test2() in /ide/work/nunit/bug-nunit-no-output-vscode/DefaultTests/UnitTest1.cs:line 20

But now it is just
NUnit Adapter <IP_ADDRESS>: Test discovery starting
NUnit Adapter <IP_ADDRESS>: Test discovery complete
NUnit Adapter <IP_ADDRESS>: Test execution started
Running selected tests in /ide/work/nunit/DefaultTests/bin/Debug/netcoreapp1.1/DefaultTests.dll
NUnit3TestExecutor converted 2 of 2 NUnit test cases
NUnit Adapter <IP_ADDRESS>: Test execution complete

Total tests: 1. Passed: 0. Failed: 1. Skipped: 0

I agree with you!
But I don't know if it is a fail of OmniSharp or a limitation of NUnit test adapter!

Looks like this is an NUnit issue. The NUnit adapter has only ever been used in Visual Studio before. In Visual Studio the errors are displayed in a test results window, not in the output. I created an xUnit project and they output the results to the output so we should do the same.

This issue was moved to nunit/nunit3-vs-adapter#329

Thanks, @rprouse !
:smile:

@tomzo in this case you can close this issue!
I hope I have helped!
Best regards.

Thanks @bernardbr
Nice to see some progress on the way


Apparent missing GIHWR

I'm new to this utility, so it's possible I am misunderstanding what I'm seeing.
Please refer to the below screenshot.
8 of the cards in the pack have GIHWR of 0.0, which seems like it must be a bug.
I spot-checked Yavimaya Steelcrusher and it appears that it should be showing GIHWR=54.75.

I'm new to debugging with Python, but I'll give it a go.

After debugging, I realized that the card has been seen less than 200 times in Quick Draft (which only started recently), so GIHWR is being set to 0.0 intentionally.
Switching to Premium Draft data source resolves the issue.


NO-ISSUE: Sync release 0.1

Sync release-0.1 with latest main changes preparing for COO 0.3 release

/lgtm


Getting Server error got 500 despite successful testflight publish

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

Recently, we started getting inconsistent Server error got 500 errors at the very end of the upload_to_testflight step despite the fact that the testflight push successfully completed and the app was published.  Interestingly, this does not happen for us on another app despite basically the same exact Fastfile, fastlane version, etc. At first, I thought it was related to the ITSAppUsesNonExemptEncryption issue from #13452, but that's not it. The error also changes from Server error got 500 to an Apple authentication issue occasionally.
Command executed

upload_to_testflight(
  api_key_path: API_KEY_PATH,
  skip_waiting_for_build_processing: false,
  beta_app_feedback_email: "...",
  changelog: commit[:message],
  groups: ["..."],
  distribute_external: true,
)

Complete output when running fastlane, including the stack trace and command used

2021-08-06T22:04:15.1944150Z INFO [2021-08-06 15:04:15.19]: -----------------------------------------------------
2021-08-06T22:04:15.1946570Z INFO [2021-08-06 15:04:15.19]: Successfully uploaded package to App Store Connect. It might take a few minutes until it's visible online.
2021-08-06T22:04:15.1948730Z INFO [2021-08-06 15:04:15.19]: -----------------------------------------------------
2021-08-06T22:04:15.1982990Z INFO [2021-08-06 15:04:15.19]: Successfully uploaded the new binary to App Store Connect
2021-08-06T22:04:15.1986090Z INFO [2021-08-06 15:04:15.19]: If you want to skip waiting for the processing to be finished, use the `skip_waiting_for_build_processing` option
2021-08-06T22:04:15.1989690Z INFO [2021-08-06 15:04:15.19]: Note that if `skip_waiting_for_build_processing` is used but a `changelog` is supplied, this process will wait for the build to appear on AppStoreConnect, update the changelog and then skip the remaining of the processing steps.
2021-08-06T22:04:15.1992040Z DEBUG [2021-08-06 15:04:15.19]: App Platform (ios)
2021-08-06T22:04:15.2727100Z INFO [2021-08-06 15:04:15.27]: Waiting for processing on... app_id:<PHONE_NUMBER>, app_version: 0.0.7, build_version: 11, platform: IOS
2021-08-06T22:04:15.4778340Z WARN [2021-08-06 15:04:15.47]: Read more information on why this build isn't showing up yet - https://github.com/fastlane/fastlane/issues/14997
2021-08-06T22:04:15.4782310Z INFO [2021-08-06 15:04:15.47]: Waiting for the build to show up in the build list - this may take a few minutes (check your email for processing issues if this continues)
2021-08-06T22:04:45.6668150Z INFO [2021-08-06 15:04:45.66]: Waiting for the build to show up in the build list - this may take a few minutes (check your email for processing issues if this continues)
2021-08-06T22:05:15.8317190Z INFO [2021-08-06 15:05:15.83]: Waiting for the build to show up in the build list - this may take a few minutes (check your email for processing issues if this continues)
2021-08-06T22:05:48.8236550Z INFO [2021-08-06 15:05:48.82]: Waiting for App Store Connect to finish processing the new build (0.0.7 - 11) for IOS
2021-08-06T22:06:19.5459960Z INFO [2021-08-06 15:06:19.54]: Waiting for App Store Connect to finish processing the new build (0.0.7 - 11) for IOS
2021-08-06T22:06:49.9040310Z INFO [2021-08-06 15:06:49.90]: Waiting for App Store Connect to finish processing the new build (0.0.7 - 11) for IOS
2021-08-06T22:07:20.2701010Z INFO [2021-08-06 15:07:20.26]: Waiting for App Store Connect to finish processing the new build (0.0.7 - 11) for IOS
2021-08-06T22:07:51.1647260Z INFO [2021-08-06 15:07:51.16]: Successfully finished processing the build 0.0.7 - 11 for IOS
2021-08-06T22:07:51.3586500Z INFO [2021-08-06 15:07:51.35]: Successfully set the beta_app_feedback_email and/or beta_app_description
2021-08-06T22:07:51.4987020Z INFO [2021-08-06 15:07:51.49]: Successfully set the changelog for build
2021-08-06T22:07:51.4991820Z WARN [2021-08-06 15:07:51.49]: Using App Store Connect's default for notifying external testers (which is true) - set `notify_external_testers` for full control
2021-08-06T22:07:51.4994810Z INFO [2021-08-06 15:07:51.49]: Distributing new build to testers: 0.0.7 - 11
2021-08-06T22:07:51.6805140Z WARN [2021-08-06 15:07:51.67]: Export compliance has been set to 'false'. Need to wait for build to finishing processing again...
2021-08-06T22:07:51.6809480Z WARN [2021-08-06 15:07:51.68]: Set 'ITSAppUsesNonExemptEncryption' in the 'Info.plist' to skip this step and speed up the submission
2021-08-06T22:07:52.5219380Z Timeout received! Retrying after 3 seconds (remaining: 5)...
2021-08-06T22:07:52.7156470Z Timeout received! Retrying after 3 seconds (remaining: 4)...
2021-08-06T22:07:52.9206320Z Timeout received! Retrying after 3 seconds (remaining: 3)...
2021-08-06T22:07:53.1182550Z Timeout received! Retrying after 3 seconds (remaining: 2)...
2021-08-06T22:07:53.3376900Z Timeout received! Retrying after 3 seconds (remaining: 1)...
2021-08-06T22:07:53.3393410Z WARN [2021-08-06 15:07:53.33]: Lane Context:
2021-08-06T22:07:53.3404190Z INFO [2021-08-06 15:07:53.33]: ***:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios beta", :BUILD_NUMBER=>"11", :SIGH_PROFILE_TYPE=>"app-store", :MATCH_PROVISIONING_PROFILE_MAPPING=>***"com.[...].assessment"=>"match AppStore com.[...].assessment<PHONE_NUMBER>"***, :IPA_OUTPUT_PATH=>"/Users/[...]/actions-runner/_work/[...]/[...]/[...]/ios/[...].ipa", :XCODEBUILD_ARCHIVE=>"/Users/[...]/Library/Developer/Xcode/Archives/2021-08-06/[...] 2021-08-06 14.43.21.xcarchive", :DSYM_OUTPUT_PATH=>"/Users/[...]/actions-runner/_work/[...]/[...]/[...]/ios/[...].app.dSYM.zip"***
2021-08-06T22:07:53.3410840Z ERROR [2021-08-06 15:07:53.33]: Server error got 500
2021-08-06T22:07:53.3939730Z INFO [2021-08-06 15:07:53.39]: Successfully generated documentation at path '/Users/[...]/actions-runner/_work/[...]/[...]/[...]/ios/fastlane/README.md'
2021-08-06T22:07:53.9550810Z
2021-08-06T22:07:53.9583510Z +------+------------------------------------------+-------------+
2021-08-06T22:07:53.9586790Z |                       fastlane summary                        |
2021-08-06T22:07:53.9589560Z +------+------------------------------------------+-------------+
2021-08-06T22:07:53.9591440Z | Step | Action                                   | Time (in s) |
2021-08-06T22:07:53.9594010Z +------+------------------------------------------+-------------+
2021-08-06T22:07:53.9604040Z | 1    | default_platform                         | 0           |
2021-08-06T22:07:53.9605480Z | 2    | last_git_commit                          | 2           |
2021-08-06T22:07:53.9606500Z | 3    | increment_build_number                   | 14          |
2021-08-06T22:07:53.9607600Z | 4    | Switch to ios configure_codesigning lane | 0           |
2021-08-06T22:07:53.9608660Z | 5    | sync_code_signing                        | 5           |
2021-08-06T22:07:53.9609690Z | 6    | update_project_provisioning              | 0           |
2021-08-06T22:07:53.9610700Z | 7    | build_app                                | 1232        |
2021-08-06T22:07:53.9612420Z | 💥   | upload_to_testflight                     | 293         |
2021-08-06T22:07:53.9613990Z +------+------------------------------------------+-------------+
2021-08-06T22:07:53.9614640Z
2021-08-06T22:07:53.9616070Z ERROR [2021-08-06 15:07:53.95]: fastlane finished with errors
2021-08-06T22:07:54.0282230Z
2021-08-06T22:07:54.0284930Z Looking for related GitHub issues on fastlane/fastlane...
2021-08-06T22:07:54.0287750Z Search query: The request could not be completed because:
2021-08-06T22:07:54.0289850Z    Server error got 500
2021-08-06T22:07:54.0290650Z
2021-08-06T22:07:54.0292920Z URL: https://api.github.com/search/issues?q=The%20request%20could%20not%20be%20completed%20because%3A%0A%09Server%20error%20got%20500+repo:fastlane/fastlane
2021-08-06T22:07:55.2274320Z ➡  beta_pa path is relative to the fastlane directory, not the project directory
2021-08-06T22:07:55.2277790Z     https://github.com/fastlane/fastlane/issues/500 [closed] 4 💬
2021-08-06T22:07:55.2279390Z     22 Sep 2016
2021-08-06T22:07:55.2280040Z
2021-08-06T22:07:55.2282350Z ➡  Server error got 500 when submitting to TestFlight
2021-08-06T22:07:55.2284180Z     https://github.com/fastlane/fastlane/issues/19148 [closed] 2 💬
2021-08-06T22:07:55.2289050Z bundler: failed to load command: fastlane (/Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/bin/fastlane)
2021-08-06T22:07:55.2292220Z Spaceship::InternalServerError: [!] The request could not be completed because:
2021-08-06T22:07:55.2293820Z    Server error got 500
2021-08-06T22:07:55.2295940Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/spaceship/lib/spaceship/connect_api/api_client.rb:191:in `handle_response'
2021-08-06T22:07:55.2298840Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/spaceship/lib/spaceship/connect_api/api_client.rb:124:in `post'
2021-08-06T22:07:55.2301870Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/spaceship/lib/spaceship/connect_api/testflight/testflight.rb:115:in `post_beta_app_review_submissions'
2021-08-06T22:07:55.2304320Z   /usr/local/Cellar/ruby@2.7/2.7.2/lib/ruby/2.7.0/forwardable.rb:235:in `post_beta_app_review_submissions'
2021-08-06T22:07:55.2306830Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/spaceship/lib/spaceship/connect_api/models/build.rb:180:in `post_beta_app_review_submission'
2021-08-06T22:07:55.2309680Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/pilot/lib/pilot/build_manager.rb:404:in `distribute_build'
2021-08-06T22:07:55.2312310Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/pilot/lib/pilot/build_manager.rb:179:in `distribute'
2021-08-06T22:07:55.2314890Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/pilot/lib/pilot/build_manager.rb:62:in `upload'
2021-08-06T22:07:55.2317570Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/actions/upload_to_testflight.rb:32:in `run'
2021-08-06T22:07:55.2320380Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:263:in `block (2 levels) in execute_action'
2021-08-06T22:07:55.2323180Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/actions/actions_helper.rb:69:in `execute_action'
2021-08-06T22:07:55.2325950Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:255:in `block in execute_action'
2021-08-06T22:07:55.2328560Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:229:in `chdir'
2021-08-06T22:07:55.2331170Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:229:in `execute_action'
2021-08-06T22:07:55.2333840Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:157:in `trigger_action_by_name'
2021-08-06T22:07:55.2336510Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/fast_file.rb:159:in `method_missing'
2021-08-06T22:07:55.2338370Z   Fastfile:45:in `block (2 levels) in parsing_binding'
2021-08-06T22:07:55.2340370Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/lane.rb:33:in `call'
2021-08-06T22:07:55.2342970Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
2021-08-06T22:07:55.2346070Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
2021-08-06T22:07:55.2348670Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
2021-08-06T22:07:55.2351300Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/lane_manager.rb:47:in `cruise_lane'
2021-08-06T22:07:55.2353980Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
2021-08-06T22:07:55.2356750Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane/lib/fastlane/commands_generator.rb:109:in `block (2 levels) in run'
2021-08-06T22:07:55.2359370Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:187:in `call'
2021-08-06T22:07:55.2361820Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/command.rb:157:in `run'
2021-08-06T22:07:55.2370430Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/runner.rb:444:in `run_active_command'
2021-08-06T22:07:55.2373650Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/fastlane-2.191.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
2021-08-06T22:07:55.2376290Z   /Users/[...]/actions-runner/_work/[...]/[...]/[...]/vendor/bundle/ruby/2.7.0/gems/commander-4.6.0/lib/commander/delegates.rb:18:in `run!'
2021-08-06T22:07:55.2377530Z     a week ago
2021-08-06T22:07:55.2377920Z

Environment

Mac Mini CI server on Big Sur, fastlane `2.172.0`

Hi @CatalinVoss , could you update fastlane to the newest version and confirm if the issue still occurs?

@lucgrabowski yep, confirmed that the issue occurs with 2.191.0

Could you execute fastlane run spaceship_logs (which will show you spaceship logfile's path), open logfile and see if you can find the answer why server returns 500?

@lucgrabowski It seems to have something to do with Apple's localization API?
2021-08-09T23:01:12.6154900Z INFO  [23:01:05]: >> GET betaAppLocalizations: [undefined body]
2021-08-09T23:01:12.6157320Z DEBUG [23:01:06]: << GET betaAppLocalizations: 200 ***"data"=>[], "links"=>***"self"=>"https://api.appstoreconnect.apple.com/v1/betaAppLocalizations?filter%5Bapp%5D=1578806524"***, "meta"=>***"paging"=>***"total"=>0, "limit"=>50***
2021-08-09T23:01:12.6159250Z INFO  [23:01:06]: >> GET betaBuildLocalizations: [undefined body]
2021-08-09T23:01:12.6162520Z DEBUG [23:01:06]: << GET betaBuildLocalizations: 200 ***"data"=>[], "links"=>***"self"=>"https://api.appstoreconnect.apple.com/v1/betaBuildLocalizations?filter%5Bbuild%5D=05c785e8-285b-448b-9143-1c51b1e9c2f0"***, "meta"=>***"paging"=>***"total"=>0, "limit"=>50***
2021-08-09T23:01:12.6166000Z INFO  [23:01:06]: >> POST betaAppReviewSubmissions: ***"data":***"type":"betaAppReviewSubmissions","relationships":***"build":***"data":***"type":"builds","id":"05c785e8-285b-448b-9143-1c51b1e9c2f0"***
2021-08-09T23:01:12.6169110Z DEBUG [23:01:06]: << POST betaAppReviewSubmissions: 500 ***"errors"=>[***"status"=>"500", "code"=>"UNEXPECTED_ERROR", "title"=>"An unexpected error occurred.", "detail"=>"An unexpected error occurred on the server side. If this issue continues, contact us at https://developer.apple.com/contact/."***]***
2021-08-09T23:01:12.6172610Z INFO  [23:01:06]: >> POST betaAppReviewSubmissions: ***"data":***"type":"betaAppReviewSubmissions","relationships":***"build":***"data":***"type":"builds","id":"05c785e8-285b-448b-9143-1c51b1e9c2f0"***
2021-08-09T23:01:12.6175670Z DEBUG [23:01:07]: << POST betaAppReviewSubmissions: 500 ***"errors"=>[***"status"=>"500", "code"=>"UNEXPECTED_ERROR", "title"=>"An unexpected error occurred.", "detail"=>"An unexpected error occurred on the server side. If this issue continues, contact us at https://developer.apple.com/contact/."***]***
2021-08-09T23:01:12.6179790Z INFO  [23:01:07]: >> POST betaAppReviewSubmissions: ***"data":***"type":"betaAppReviewSubmissions","relationships":***"build":***"data":***"type":"builds","id":"05c785e8-285b-448b-9143-1c51b1e9c2f0"***
2021-08-09T23:01:12.6182950Z DEBUG [23:01:07]: << POST betaAppReviewSubmissions: 500 ***"errors"=>[***"status"=>"500", "code"=>"UNEXPECTED_ERROR", "title"=>"An unexpected error occurred.", "detail"=>"An unexpected error occurred on the server side. If this issue continues, contact us at https://developer.apple.com/contact/."***]***
2021-08-09T23:01:12.6186540Z INFO  [23:01:07]: >> POST betaAppReviewSubmissions: ***"data":***"type":"betaAppReviewSubmissions","relationships":***"build":***"data":***"type":"builds","id":"05c785e8-285b-448b-9143-1c51b1e9c2f0"***
2021-08-09T23:01:12.6190530Z DEBUG [23:01:07]: << POST betaAppReviewSubmissions: 500 ***"errors"=>[***"status"=>"500", "code"=>"UNEXPECTED_ERROR", "title"=>"An unexpected error occurred.", "detail"=>"An unexpected error occurred on the server side. If this issue continues, contact us at https://developer.apple.com/contact/."***]***
2021-08-09T23:01:12.6210370Z INFO  [23:01:07]: >> POST betaAppReviewSubmissions: ***"data":***"type":"betaAppReviewSubmissions","relationships":***"build":***"data":***"type":"builds","id":"05c785e8-285b-448b-9143-1c51b1e9c2f0"***
2021-08-09T23:01:12.6213500Z DEBUG [23:01:07]: << POST betaAppReviewSubmissions: 500 ***"errors"=>[***"status"=>"500", "code"=>"UNEXPECTED_ERROR", "title"=>"An unexpected error occurred.", "detail"=>"An unexpected error occurred on the server side. If this issue continues, contact us at https://developer.apple.com/contact/."***]***
2021-08-09T23:01:12.6215050Z
2021-08-09T23:01:12.6216390Z [23:01:12]: Result: ["/tmp/spaceship1628549809_8787_5000.log"]

@lucgrabowski Any indication what this might be or what localization settings could be involved that might affect this?

As the error is on the server side, the only thing that comes to my mind is reporting the issue on https://developer.apple.com/bug-reporting/
If there is a need for more data on the request, you could setup Charles as a proxy, run fastlane commands, look for the request in Charles and copy cURL request.
https://github.com/fastlane/fastlane/blob/master/spaceship/docs/Debugging.md
https://github.com/fastlane/fastlane/blob/master/ToolsAndDebugging.md

A really good post, very thankful and hopeful that you will write many more posts like this one.
DinarGuru

I ran into a similar 500 error when running create_app_online. I look in the spaceship logs and found:
INFO  [10:39:25]: >> GET users: [undefined body]
DEBUG [10:39:27]: << GET users: 500 {"errors"=>[{"status"=>"500", "code"=>"UNEXPECTED_ERROR", "title"=>"An unexpected error occurred.", "detail"=>"An unexpected error occurred on the server side. If this issue continues, contact us at https://developer.apple.com/contact/."}]}

In create_app_online I was sending the property itc_users: []. Since that was the only clue in the error logs I removed it (it's not really needed anyway), and this fixed the issue. This was not giving a 500 error last week.

We also ran into 500 errors when uploading the app to external testers(distribute_external: true in fastlane), in our case it was because we were distributing a newly created app and the Test Information fields in Appstore Connect were empty.


Docs page is not found

https://docs.ragas.io/en/latest/howtos/applications/compare_embeddings.html shows 404

https://docs.ragas.io/en/latest/howtos/applications/compare_embeddings.html shows 404

this could be the most relevant one
https://docs.ragas.io/en/stable/howtos/applications/compare_embeddings.html

hey guys - thanks for reportings these
the main docs page has a few missing links since we revamped it for v0.2 😅
will clean up all of these before the release 🙌🏽


docs: add introduction and features doc

Summary
add introduction and features doc
Related Links

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

How to make codspeed ignore changes of some paths?


Address build failures

Xcontent classes were moved in this PR https://github.com/opensearch-project/OpenSearch/pull/5902 causing builds to fail.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #367 (f7908d0) into main (3869c74) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main     #367      +/-   ##
============================================
- Coverage     73.30%   73.27%   -0.04%
- Complexity      698      699       +1
============================================
  Files           110      110
  Lines          4612     4614       +2
  Branches        606      608       +2
============================================
  Hits           3381     3381
  Misses          980      980
- Partials        251      253       +2

Impacted Files
Coverage Δ

...ain/java/org/opensearch/commons/authuser/User.java
87.82% <ø> (ø)

...ommons/alerting/action/AcknowledgeAlertResponse.kt
41.66% <ø> (ø)

...h/commons/alerting/action/DeleteMonitorResponse.kt
20.00% <ø> (ø)

...earch/commons/alerting/action/GetAlertsResponse.kt
100.00% <ø> (ø)

...rch/commons/alerting/action/GetFindingsResponse.kt
70.83% <ø> (ø)

...ch/commons/alerting/action/IndexMonitorResponse.kt
66.66% <ø> (ø)

...selectorext/BucketSelectorExtAggregationBuilder.kt
46.03% <ø> (ø)

...ation/bucketselectorext/BucketSelectorExtFilter.kt
40.00% <ø> (ø)

...egation/bucketselectorext/BucketSelectorIndices.kt
0.00% <ø> (ø)

...g/opensearch/commons/alerting/alerts/AlertError.kt
31.81% <ø> (ø)

... and 65 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thank you @MaxKsyunz !

@peternied @lezzago could you label this PR with backport to 2.x?
Now that XContent refactor is in OpenSearch 2.x, common-utils 2.x build fails. I confirmed locally that backporting these changes is sufficient to make it build again.


react-docgen: exclude node_modules and files outside project

This updates the internal react-docgen plugin to prevent running against files that are in node_modules or outside of the project root.
I realized we should do this when working on converting a large project over to use the vite builder as an experiment, and found that it took ~20 minutes to load the first storybook page after the browser opened.  After digging, I found that most of this time was spent processing files that were in other parts of the monorepo, like icons, which did not need docgen info.  After making the changes in this PR, the time was reduced to less than 2 minutes on a cold start.  The number of processed files dropped from 1668 to 958.  And the time drops to 20 seconds for a cold boot with storyStoreV7 (processes 39 files).
I'm making a few assumptions here:

Components in node_modules should not get docgen information.  I think this is reasonable, since it's unlikely you need to document imported components, they should be documented elsewhere.
Components outside of your project root (technically, I'm using process.cwd() here)  should likewise not get docgen.  This may not always be a good assumption to make, and by supplying this exclude pattern as a default parameter, I'm thinking we could easily pull this plugin into a separate package and allow users to customize it.  But, more often than not, I think this is the right decision to exclude them.  Curious to hear other's thoughts though.

This breaks the workspace example.  I need to find another way to handle this, perhaps we can just keep the plugin configurable and if a project needs to modify it, they can use viteFinal to adjust it.


Adds an IP reputation system to the SNI rate limiter

This concept is simple, yet allows for the rate limit plugin to chose an IP to block based on previous events, rather than just randomly blocking users. It intentionally only works as a global plugin right now, and it also requires a notion of "pressure" to be functional.

[approve ci]

Needs a rebase.

[approve ci rocky]

Rebased on current master.

[approve ci fedora]

[approve ci]

Cherry-picked to v9.2.x


Change of top line of script to better identify the widget

I suggest to change the top line of your script from
script "com.sk.tristate.livecodescript"
to
script "com.sk.widget.tristate"
This seems to be in line with other script widgets and it shows up better in "tinyDict" and dictionary.

Changed (in external editor as not possible within LC). As there are a few changes I'll put this down as minor point release to keep track - thank you Bernd!


Have break after images

The "Back to Top" link shouldn't be right next to the image
Should be a quick fix

See?


ParseRSAPublicKeyFromPEM returns wrong error ErrNotRSAPrivateKey (copy+paste issue?)

See https://github.com/dgrijalva/jwt-go/blob/master/rsa_utils.go#L64
It is:
return nil, ErrNotRSAPrivateKey

Should it be another new error type ErrNotRSAPublicKey?

Yep.  That's definitely a bug.  Thanks for reporting.


Feat autocomplete

First pass on adding autocomplete support for instructions and registers. I had a ton of fun putting this together.
The basic flow/ concepts I used to implement this are as follows:

At startup, we communicate to the server that the LSP client is capable of providing completions, as well as document sync

In the main loop, we now look for some more messages from the server:

Document sync notifcations: Everytime a notification comes in, we use it to update the program's local copy of the text buffer
Completion Requests: Everytime a request comes in, we return a list of completions if possible

Completions:

Using the Tree-sitter Rust bindings, whenever a completion request is received, we construct a tree of the current buffer, and issue a series of queries about the cursor's current line within this tree. If any of these queries match, we can check the type of node the cursor is currently at
If the cursor is at an instruction or register node, we offer completions accordingly.

Currently, autocomplete seems to function properly on the GAS file, but sometimes doesn't work on the GO file. As far as I can tell this is because the tree-sitter-asm grammar doesn't fully support GO's syntax in its parsing. I'd like to look into contributing a PR upstream to the grammar, but I'll have to look into it more, and hope that the project is accepting PRs.
Gif of autocomplete in action:

Some potential TODOs for cleanup before merging or future PRs:

Better labels for suggestions:
- Currently, register suggestions are labeled as Variable and instruction suggestions are labeled as Operator. We're limited by the types defined in the LSP spec, but maybe the spec will be expanded in the future. See: https://github.com/gluon-lang/lsp-types/issues/270
Clean up logic in get_comp_resp:
- This function is pretty long and unwieldy. I'd like to break it up a bit without over-abstracting/ introducing overhead if possible.
Incremental Parsing:

From what I've read, one of Tree-sitter's strengths is its incremental parsing. Currently the LSP doesn't take advantage of this and instead creates a fresh new tree every time parse is called.
I had trouble finding a good way to map incremental edit information from the lsp_server's notifications to the format that Tree-sitter is expecting. This appears to be a known issue, see: https://github.com/tree-sitter/tree-sitter/issues/210

To investigate this, change the text_document_sync in src/bin/main.rs from TextDocumentSyncKind::FULL to TextDocumentSyncKind::INCREMENTAL
Inside the main_loop in src/bin/main.rs, when a Message::Notification is received of type DidChangeTextDocument, a list of edits will be included. These edits will need to be applied to the local copy
of curr_doc, and then translated into the form Tree-sitter is expecting for a .edit() call on the Tree object. Currently, the tree is constructed inside of get_comp_resp(). Edit information is expected to include both byte offsets and row/column coordinates.

"Correct" register completion suggestions

Currently when an completion request is received for a register, a list is sent with all register names. Some simple translation code could filter this list to only suggest registers that match the type required for the given instruction. This can probably be done in the following manner:

When a tree_sitter::Query matches, we get the instruction name by calling .utf8_text() on the @instr_name capture. We could then issue a lookup into the NamesToInstructions map, and iterate through the instruction forms to find valid operand types (This would require a translation between the OperandType and RegisterWidth enums). A quick filter on the vector of register completions so that only registers that match this criteria could then be done.

Happy to fix this to get it up to standards, and squash the commits down once this is in a merge-able state.

Very impressive! And thanks for the detailed description. It's been really helpful! 💯
I tried it out quickly and it works just fine!
I haven't looked at the code yet but after reading the description and trying it out, a few comments:

There's autocompletion for both the name of the instruction name e.g., PUSH as well as the instruction form in its GAS/GO forms (see pic). Would showing the PUSH instruction name help? Perhaps we should be offering only the instruction form alternatives as options ? Also I get the name of the instruction twice in my autocomplete suggestions. Not sure if this is the server that sends it twice or maybe an issue w my LSP client?

Some potential TODOs for cleanup before merging or future PRs

Might be useful to put these as concrete issues in the repo. This way either me or someone else could pick these up and contribute

hope that the project is accepting PRs.

Yeah good point. I guess it's more about whether the project is actively maintained atm or not. I saw you've also made another PR to their repo and it's not answered yet. If that doesn't work out we can always fork it and push a modified version of it ourselves to cargo.

Some more things to note:

Let's amend the README stating that we now support autocompletion
The GIF you uploaded looks great. Let's put this in the README so that users now what to expect from the autocompletion

Would showing the PUSH instruction name help?

I think showing the name of the instruction is helpful so that we still kinda support Intel syntax (from what I understand at least), but if this isn't something you want it can be filtered out at load time pretty easily.

I get the name of the instruction twice in my autocomplete suggestions

This is is because it's showing both the x86 and x86_64 suggestions, since both architectures are loaded by default. I also saw this while testing and thought it was a little weird. Maybe it makes sense to switch the default config behavior to support both GAS and GO but only x86_64? (This would be a simple fix to adjust the struct default implementations in src/types.rs)

Might be useful to put these as concrete issues in the repo.

Makes sense! I can draft those soon.

If that doesn't work we can always fork it and push a modified version of it ourselves to cargo.

Sounds great! I'm looking forward to learning more about parsing!

Some more things to note:

Let's amend the README stating that we now support autocompletion
The GIF you uploaded looks great. Let's put this in the README so that users now what to expect from the autocompletion

Sounds great, I'll work on this now :)

One other quick follow up. Given that this is a new feature, does this PR getting merged warrant a new version/ release on crates.io? I don't know much about how that stuff works but wanted to ask :)

This is is because it's showing both the x86 and x86_64 suggestions, since both architectures are loaded by default. I also saw this while testing and thought it was a little weird.

Could we, before sending the results over to the client, filter them for duplicates?

I think showing the name of the instruction is helpful so that we still kinda support Intel syntax

👍🏾

One other quick follow up. Given that this is a new feature, does this PR getting merged warrant a new version/ release on crates.io? I don't know much about how that stuff works but wanted to ask :)

Sure, it's actually quite simple to publish a new version to crates.io. Once you've merged to master, you can create and push a new tag to the repo, e.g., v0.6.0 - git tag v0.6.0 && git push --tags. Then automatically github will run the publish.yml actions here, since they listen to new tag events, and will build and publish the code after that. There's a cargo registry token registered as a secret in the repo which is used to authenticate with crates.io

Could we, before sending the results over to the client, filter them for duplicates?

Added this using hashset. As far as I can tell it's removing all the duplicates but let me know :)

Sure, it's actually quite simple to publish a new version to crates.io. Once you've merged to master, you can create and push a new tag to the repo, e.g., v0.6.0 - git tag v0.6.0 && git push --tags

OK, so there's actually an intermediate step to all this - that is changing the package version in Cargo.toml

https://github.com/bergercookie/asm-lsp/actions/runs/6997139891

There's also a bug in that, currently it  tries uploading a version for the semver that's written in Cargo.toml - 0.4.2  but since that's already on crates.io that raises an error. That error however doesn't mark the gh actions job as failed.

Ideally it would be great to set this version dynamically so we don't have to make this edit in two places (git tag and Cargo.toml file) but currently AFAICT this isn't possible - https://github.com/rust-lang/cargo/issues/6583

Ah that makes sense, I was wondering what happened. Thanks so much for clearing that up!


[AutoPR sql/resource-manager] Add instancePools.json to sql readme.md

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6281

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/3620


[Question] Is the responseTimeout configuration item of the httpclient plugin useful?

Question
I see the responseTimeout configuration item in the HttpClientProperties class, but I don't see this configuration item used in any Java code. Is this configuration item effective?

I haven't seen it used in the HttpClientPluginConfiguration class


Create Kwm plist

@koekeishiya @napcae
With discussion on #23 on creating a brew formula for kwm on the devel-only tap It would be nice to have Kwm start on login through the launchd mechanism.
To test this locally update line 9 of kwm.plist to be the full path of the executable on your machine.
With that change, just link the plist file via ln -sf full/path/to/kwm.plist ~/Library/LaunchAgents then logout/login to have Kwm start automatically.
There is a way to specify the plist file through the homebrew formula and that may be the preferred route

Seems useful for future stable releases.

When kwm is started using this option, it is no longer able to load hotkeys.so, however it no longer requires accessibility to be enabled for the entire terminal.

You are correct that this will automatically restart kwm when it is killed by the user, which may not be optimal when developing. Removing the KeepAlive option on line 13-14 prevents kwm from restarting once it is killed manually.

Alright good to know, I will mention it in the README. I do like that support for release usage, however not optimal when developing indeed.

Hotkeys.cpp need to use the full path to kwmc to work


Null pointer exception when trying to start clerk, running bb clerk-watch

Just pulled the tip of main, I am getting
$ bb clerk-watch
Execution error (NullPointerException) at gen.dynamic.choice_map.ChoiceMap/iterator (choice_map.clj:90).
null

Full report at:
/tmp/clojure-12396741036507490247.edn
Error while executing task: clerk-watch

Attaching full error report (has to be .txt according to GitHub).
clojure-12396741036507490247.edn.txt

I'll get that patched today, I found that error in my SCI branch. The fix is in the choicemap impl, adding an if-let to the result of .seq.


Updated README

I just removed the GSoC section as this is not sponsored by the GSoC.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4

Relevant Lines:
4

💛  - Coveralls

Documentation is also failing. Will fix that in a moment.

Lets merge #5 first to see if the documentation is built correctly in this one and then merge this one. It does build correctly in my computer.


(chore): RWAble → AxisStorable, InMemoryElem → RWAble

[x] Towards #1634
[ ] Tests added
[ ] Release note added (or unnecessary)

@ilan-gold check out if you like 856526860ff64453578a12b7c4c3b32bedcda124

Yup, works for me


Move OptimismHardfork to new crate reth_optimism_forks

Closes https://github.com/paradigmxyz/reth/issues/10518

Adds crate reth-optimism-forks
Moves reth_ethereum_forks::OptimismHardfork and reth_ethereum_forks::OptimismHardforks to reth-optimism-forks

that makes sense, but I wonder if this breaks --dev mode for op
https://github.com/paradigmxyz/reth/blob/0746479e3c873e0f83c533871598dd1d749d0041/crates/chainspec/src/spec.rs#L108-L115

let me try :)

re-request review @mattsse


Add screenshot test for highlights visibility when layer selection/active layer changes

References and relevant issues
Closes #7315
Description
Add a test checking the highlight behavior when changing selection of a layer (Shapes layer). Check that the select layer data highlight is visible only when the layer is selected/active

@Czaki what's the status on this PR now, are we happy with the changes?

@DragaDoncila code look good. I do not have time to test it manually yet.

I do not have time to test it manually yet.

You mean like, running the test manually? The original functionality for ensuring highlight isn't visible when layer isn't active has already been merged


Code Tests

The code base should have tests. They should check:

The applications can start
Widewine is working correctly
Possibly test every streaming service (If possible)

An update:
Tests haven't been added and are not in the work due to the difference in Electron version between Linux and Mac. I have found settings up tests with older versions of Electron painful and I don't want to maintain two sets of tests.


help me anyone

Is your feature request related to a problem? Please describe.

Describe the solution you'd like:

Describe alternatives you've considered:

Additional context:

We can't if you don't tell us what's wrong. Drink lots of liquids and go for walks to take breaks.


SW-3797 Add Spanish CSV templates

Add Spanish versions of the accession, seedling batch, and species CSV templates.

Current dependencies on/for this PR:

main

PR #1231

PR #1232

PR #1233   👈

This comment was auto-generated by Graphite.

@sgrimm started a stack merge that includes this pull request via Graphite.

Graphite rebased this pull request as part of a merge.

@sgrimm merged this pull request with Graphite.


Update pt-br.json

Translation update 22/10/18

@gabrielcbe Thanks so much for keeping this up to date!


docker rm --link lacks sufficient error messages

I created and linked to containers.  When I try to remove a link  as per the example here:
https://docs.docker.com/reference/commandline/cli/#rm
The example doesn't work. The example shows a leading slash but this appears to be problematic.  Including the leading slash causes the command to return with and apparently remove the link. But it doesn't.
$ docker ps
CONTAINER ID        IMAGE                      COMMAND                CREATED             STATUS              PORTS                     NAMES
8e9c5dd470b7        training/webapp:latest     "python app.py"        2 minutes ago       Up 2 minutes        <IP_ADDRESS>:49159->5000/tcp   web
5551a83d8f32        training/postgres:latest   "su postgres -c '/us   2 minutes ago       Up 2 minutes        5432/tcp                  db

mary at meepers in ~/repos/distribution on docs-part-two [!]
$ docker ps
CONTAINER ID        IMAGE                      COMMAND                CREATED             STATUS              PORTS                     NAMES
8e9c5dd470b7        training/webapp:latest     "python app.py"        3 minutes ago       Up 3 minutes        <IP_ADDRESS>:49159->5000/tcp   web
5551a83d8f32        training/postgres:latest   "su postgres -c '/us   3 minutes ago       Up 3 minutes        5432/tcp                  db

mary at meepers in ~/repos/distribution on docs-part-two [!]
$ docker inspect -f "{{ .HostConfig.Links }}" web
[/db:/web/db]

mary at meepers in ~/repos/distribution on docs-part-two [!]
$ docker rm --link /web/db
/web/db

mary at meepers in ~/repos/distribution on docs-part-two [!]
$ docker inspect -f "{{ .HostConfig.Links }}" web
[/db:/web/db]

mary at meepers in ~/repos/distribution on docs-part-two [!]
$ docker ps
CONTAINER ID        IMAGE                      COMMAND                CREATED             STATUS              PORTS                     NAMES
8e9c5dd470b7        training/webapp:latest     "python app.py"        4 minutes ago       Up 4 minutes        <IP_ADDRESS>:49159->5000/tcp   web
5551a83d8f32        training/postgres:latest   "su postgres -c '/us   4 minutes ago       Up 4 minutes        5432/tcp                  db

Specifying a totally bogus link appears to work:
$ docker rm --link /web/df
/web/df

But of course the link didn't exist:
Here is the only command that works:
mary at meepers in ~/repos/distribution on docs-part-two [!]
$ docker rm --link web/db
web/db

mary at meepers in ~/repos/distribution on docs-part-two [!]
$ docker inspect -f "{{ .HostConfig.Links }}" web
<no value>

Here is how I think it should work:

If a user specified a link that doesn't exist, we should tell them
If a user specifies the leading slash or not, we should remove the link -- the alternative is to return an error if the leading slash is include (or fix this command)

I met the same issue, it's strange, I sent a workaround https://github.com/docker/docker/pull/12921, hope we can get some help there.

@moxiegirl the second point in your post is already handled with @hqhq pr being merged in master, about telling the user the link doesn't exist I'm +1 (I think it just breaks api, maybe asking someone other is better) and I can help with that

rm --link is pretty mysterious feature for me. Not sure if it worth to explain and fix it today.
ping @thaJeztah

Looks like it's actually resolved;
docker run -dit --name db busybox
docker run -dit --name web --link db busybox

docker inspect -f "{{ .HostConfig.Links }}" web
[/db:/web/db]

docker rm --link /web/db
web/db

docker inspect -f "{{ .HostConfig.Links }}" web
[]

So closing it


Tutorial fix

What does this implement/fix? Explain your changes.
At least one broken tutorial and others with too lengthy titles. Also added some of the verification ones to be shown again.

In the MVMDS vs PCA tutorial, it seems like there's something weird going on with the ari scores. For both the noiseless and noisy case, the score are exactly the same. Also, for the noisy case, the printout shows MVMDS having a better score, but it says pca performs better.

In the MVMDS vs PCA tutorial, it seems like there's something weird going on with the ari scores. For both the noiseless and noisy case, the score are exactly the same. Also, for the noisy case, the printout shows MVMDS having a better score, but it says pca performs better.

Fixed. Cells were run out of order.


feat(franka_gazebo): add 'log_level' parameter to 'FrankaGripperSim' gazebo plugin

This pull request adds the 'franka_gripper/log_level' parameter to the 'FrankaGripperSim' Gazebo Plugin. This parameter allows users to get rid of the excessive logging of received action server commands. I need this in my fork since the logging slows down my training script. Another solution would be to change the ROS_INFO_STREAM_NAMED console logs to ROS_DEBUG_STREAM_NAMED (see #214).

Which "excessive logging" actions are we talking about? Usually you should only get one line saying New XYZ Action goal received ...

You can also change the verbosity on the fly with something like:
rosservice call /gazebo/set_logger_level "{ logger: 'ros.franka_gazebo.FrankaGripperSim', level: 'warn' }"

Can this help your performance problem?

@gollth Thanks for your answer that solves my problem. I will close this pull request and #214.

Glad I could help


Notification config.json Schema Validation

We need to validate notification config files during job submission. Ideally, a user would attempt to deploy a job with a malformed json file and OneFuzz would immediately fail the job submission and return the failure to the user.
One potential solution would be to detail some kind of schema that can be used to check incoming configs against.
AB#45445

I think what your proposing here is sematic validation, right?


Finding MSBuild via environment variable supports Visual Studio detection

If the user points MSBUILD_EXE_PATH to an msbuild inside Visual Studio, then the BuildEnvironment should be configured to the Visual Studio file layout.

@dfederm


SliverPersistentHeaderDelegate.build overlapsContent parameter not working for a pinned header

This example creates.a pinned SliverPersistentHeader that should turn orange when the list scrolls below it, per the overlapsContent SliverPersistentHeaderDelegate build parameter. When scrolled the header clearly overlaps the content.
https://dartpad.dev/?id=480b464ca764096be8cf775270977617&channel=master

Interestingly, if you add a header right after the first one, it works as expected. Reading the code in the rendering layer, it looks like the overlap is computed based on the slivers that come before it, but the docs are really clear that is not the case:

/// The overlapsContent argument is true if subsequent slivers (if any) will
/// be rendered beneath this one, and false if the sliver will not have any
/// contents below it. Typically this is used to decide whether to draw a
/// shadow to simulate the sliver being above the contents below it. Typically
/// this is true when shrinkOffset is at its greatest value and false
/// otherwise, but that is not guaranteed. See [NestedScrollView] for an
/// example of a case where overlapsContent's value can be unrelated to
/// shrinkOffset.

import 'package:flutter/material.dart';

class TitleBar extends SliverPersistentHeaderDelegate {
  const TitleBar(this.topPadding);

  final double topPadding;

  @override
  double get minExtent => 56 + topPadding;

  @override
  double get maxExtent => 56 + topPadding;

  @override
  Widget build(BuildContext context, double shrinkOffset, bool overlapsContent) {
    return Container(
      color: overlapsContent ? Colors.orange : Colors.blue,
      padding: EdgeInsets.only(top: topPadding),
      alignment: Alignment.center,
      child: const Text('Settings', style: TextStyle(fontSize: 18)),
    );
  }

  @override
  bool shouldRebuild(TitleBar oldDelegate) {
    return topPadding != oldDelegate.topPadding;
  }
}

class TestOverlapsContent extends StatelessWidget {
  const TestOverlapsContent({ super.key });

  static const int itemCount = 50;
  static const Color startColor = Colors.blue;
  static const Color endColor = Colors.red;

  @override
  Widget build(BuildContext context) {
    final double topPadding = MediaQuery.paddingOf(context).top;

    return Scaffold(
      body: CustomScrollView(
        slivers: <Widget>[
          SliverPersistentHeader(
            pinned: true,
            delegate: TitleBar(topPadding),
          ),
          const SliverPersistentHeader(
            pinned: true,
            delegate: TitleBar(0),
          ),
          SliverList(
            delegate: SliverChildBuilderDelegate(
              (BuildContext context, int index) {
                return Card(
                  color: Color.lerp(startColor, endColor, index / itemCount)!,
                  child: ListTile(
                    textColor: Colors.white,
                    title: Text('Page $index'),
                  )
                );
              },
              childCount: itemCount,
            ),
          ),
        ],
      ),
    );
  }
}

class TestOverlapsContentApp extends StatelessWidget {
  const TestOverlapsContentApp({ super.key });

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(useMaterial3: true),
      home: const TestOverlapsContent(),
    );
  }
}

void main() {
  runApp(const TestOverlapsContentApp());
}

Possible work around is to use shrinkOffset > maxExtent - minExtent

Per https://github.com/flutter/flutter/issues/126448#issuecomment-1542596317, I don't think it's really working as expected.  If 3 or more headers are included their overlapsContent parameters should become true, one at a time, as the following content scrolls underneath them.  What happens now is that headers 1-N  overlapsContent=true as soon as content scrolls under header N, and (as noted already) header 0 always gets overlapsContent=false.

their overlapsContent parameters should become true, one at a time, as the following content scrolls underneath them

I am not entirely sure yet that they can do that. Each sliver is independent. They have a little information about the slivers that come before them, but they don't know about the slivers that come after them, since they are laid out sequentially.
So the first header has no idea that the second header is also pinned, does not know the second header's extent, or if the content is only under the second header and not yet under the first. I am still investigating, but I do not know that this particular scenario is possible yet.

Turns out this is a dupe of https://github.com/flutter/flutter/issues/26667, closing to refer to that issue.


Hung up at / Uploading files... when performing Amplify push

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
No response
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
9.1.0
What operating system are you using?
Windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No
Amplify Categories
api
Amplify Commands
push
Describe the bug
When pushing the schema using the command amplify push, the cli is hung at - Uploading files...
Expected behavior
The cli should deploy the changes.
Reproduction steps
Unfortunately I can not provide a reproducible example since I believe the issue might be specific to certain users only and not much debug info is provided by the cli.
GraphQL schema(s)

# Put schemas below this line

Project Identifier
No response
Log output

# Put your logs below this line

Additional information
No response

@ykethan
Sure the environments I have tried so far are CMD, PowerShell and Git bash.
Hitting return does not continue the process.

I gave it a try in WSL and the issue isn't there. Seems to be specific to CMD, PowerShell and Git bash.

Hey @rezab777 , glad to hear that you are up and running. Could please let us know if you are using Amplify CLI hooks in your application. https://docs.amplify.aws/cli/project/command-hooks/

Hi @ykethan
Not using any CLI hooks.

Thank you for the information. When using the terminal inside Vscode such as CMD and powershell in my windows PC I was unable to replicate the issue. As a workaround using WSL seems to mitigate the issue. With that being said I will be closing the issue. Please feel free in reaching out to us, we would be happy in assisting you.


Update to cudf conditional join change that removes null equality argument

Updates the plugin code to reflect the breaking cudf API change in https://github.com/rapidsai/cudf/pull/9096.  Now that operators can be null-aware and there's separate EQUAL vs. NULL_EQUAL, it's no longer necessary to specify at the top level whether nulls compare as equal.

build

build


Position of tabs on Main Activity is wrong for a while

Summary:
For a while, position of Main Activity tabs are not centered in both half of the page, they are centered on whole page instead. They weren't like that previously, something should have break them.
Expected behaviour:
They both should be centered to both half of the page.

@maskaravivek is that considered an issue ?

@maskaravivek is that considered an issue ?

I believe the idea is that on any size screen the tabs should both be 50% the width of the screen.

i will solve it

@4D17Y4 we have a completely different Ui now so we can close this issue


Blog post/financial modeling

Description & motivation

This PR contributes the Financial Modeling blog post which was drafted and discussed within Issue #1415. Let me know if I added too many gifs. I noticed this was a very dense blog post and thought it could use some reprieve between the steps.
Additionally, I was not sure about a few of the checklist items below. Let me know if I missed anything!
To-do before merge

Prerelease docs
If this change is related to functionality in a prerelease version of dbt (delete if not applicable):

[ ] I've added versioning components, as described in "Versioning Docs"
[ ] I've added a note to the prerelease version's Migration Guide

Checklist
If you added new pages (delete if not applicable):

[ ] The page has been added to website/sidebars.js
[X] The new page has a unique filename

If you removed existing pages (delete if not applicable):

[ ] The page has been removed from website/sidebars.js
[ ] An entry has been added to _redirects

@fivetran-joemarkiewicz Your post is live! Feel free to share in #i-made-this or your personal socials. We'll also be sharing on the official LI and twitter accounts on friday at 830 ET! Congrats, this is an awesome post Joe!!!

@fivetran-joemarkiewicz Joe, I wrote up your social media posts, but then I totally forgot to schedule them 🥴 I'm so sorry! I've scheduled them in Hubspot for next Thursday, September 15th at 8:30am (for real this time!!). Sorry about the mix-up!!!


Updating docs with new labels being added.

Depends on #344 and #345

cc @rjnagal

This will need updating if you update external_id on the other PR.

@rjnagal: Updated docs

@rjnagal: e2e is green :dancers:


Quick starts

Describe the documentation issue
A clear and concise description of the issue in the document.
Describe the enhancement
A clear and concise description of the  proposed enhancement.
Additional context
Add any other context here.

As there are no details at all, I'm assuming this was opened in error and will resolve. Please re-open and share details if you would like to report an issue or feature request.


Incorrect error 'The model "App\Models\X" must have the required orchid/platform traits.'

Because of the way Orchid\Crud\Arbitrator checks if the model implements the required traits (Filterable), it only finds the trait if the model directly uses it... but not if the model extends a model that has use Filterable;
Three solutions come to mind:

Write a new function like the trait_uses_recursive helper function that also traverse the parent classes.
Stop validating the traits and rely on the developers to understand the Call to undefined method Illuminate\Database\Eloquent\Builder::filters() error they'll get.
Improve the error to state that the trait must be included directly on the Model being used as a resources.

I'm mostly raising this issue so that if someone else runs into the error, they don't spin their wheels for 5 hours like I did. If nothing changes, at least this issue report may come up in their search.
In the meantime, I suggest at least a documentation update.
https://github.com/orchidsoftware/orchid.software/commit/8aded3540441a9c1eff28c1a8d7a5c5af788985e

@vilocity-brian you saved my day, bro


Change in commands:

start: Start the production app. If not available throw an error or build the app.
dev: Start development environment with option to watch
Don't watch by default on dev.

Since we don't need any config while running the production app it's better not to have a script for that and use start for the development environment. We still need to have an option to specify whether to watch or not


Event from reaction is routed before the inititial event is dispatched to target

This leads to an issue, when there is an event (UserSignedIn) which creates another event as a reaction (UserConsentRequested) and they both are dispatched to a single entity (SessionProjection) with the first event (UserSignedIn) actually creating it, and the second event requiring a repository (SessionRepository) query to be routed to the correct target.
As of now, after routing an event to a projection, a DispatchEventToSubscriber command is posted to the System Bounded Context, after which the next event from queue gets dispatched.
This means that upon dispatching two events from the DispatchQueue, when it comes to the second  event, the first one is not dispatched, but scheduled to be dispatched in the System Bounded Context.

@armiol, do you think this is a bug?

@dmitrykuzmin can you please check if this is still reproducible?

@dmitrykuzmin maybe we need an integration test on this matter.

The issue can no longer be reproduced.
A test for the described scenario was added in #1128.

This behavior is now reproducible again. However, it does not look an outstanding issue, as the read-side by contract is eventually consistent. While in this scenario the code relies not only upon the ordering of the events dispatched to the projection (which is guaranteed by the framework) but onto the projection state changes that presumably should have taken place.


Make --strict toggleable for mkdocs build

Fixes #77
Revert commit d525ea0f069b6615aa352a7f385c21b31f29b985.
Make the addition/usage of the --strict option toggleable according to a new warnings_as_errors boolean input.
By default, this is set to true and must explicitly be set to false.
If warnings_as_errors is set to false, a warning will be emitted in the Actions workflow run.

How would you use this in a downstream ci file? You can just link me to the documentation of how to use this

In general, the documentation exists here: https://sintef.github.io/ci-cd

Great, thanks!


Message with long text is cropped

I've begun upgrading this to use Autolayout which I fixes this problem. Not without issues yet but hope to release into the wild early next week:


Incompatibility with Nexus NuGet Server: Unexpected XML Response

Description:
Hello,
I’m encountering an issue while using the NuGet Package Manager GUI extension for VSCode with our Nexus NuGet server. The extension is expecting JSON responses for package searches and management, but our Nexus server is returning XML instead. This leads to the following error in the VSCode Developer Tools console:
Unexpected token '<', "<?xml version="1.0" encoding="utf-8" standalone="yes"?> ..." is not valid JSON.

Here are the relevant details:

Nexus Server Version: v3
Endpoint URL: https://nexus.xxxxx.corp/repository/nuget-hosted/query?q=automapper&preRelease=false&semVerLevel=2.0.0&skip=0&take=10
Response Format: XML

I believe the extension may need to handle XML responses or allow for configuration of the expected response format.
Could you please look into this issue? Any guidance on how to resolve this would be appreciated.
Thank you!

I found that sonatype nexus has both XML and JSON formats. Initialy I thought that it only has XML but I was wrong.


Fix typos in webhook creators

Description:
This PR fixes a couple of typos in the webhook creator code paths.
Affected area:

Functional Area

Other
[x]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? No.

Is this a breaking change? No.

Codecov Report

Merging #4350 (e6784a2) into main (5c7931b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4350      +/-   ##
==========================================
+ Coverage   69.13%   69.16%   +0.02%
==========================================
  Files         212      212
  Lines       14446    14447       +1
==========================================
+ Hits         9987     9992       +5
+ Misses       4407     4403       -4
  Partials       52       52

Flag
Coverage Δ

unittests
69.16% <100.00%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/injector/webhook.go
89.01% <100.00%> (ø)

pkg/messaging/broker.go
88.99% <100.00%> (+0.05%)
:arrow_up:

pkg/validator/patch.go
84.11% <100.00%> (ø)

pkg/certificate/rotor/rotor.go
86.95% <0.00%> (+2.17%)
:arrow_up:

pkg/messaging/workqueue.go
100.00% <0.00%> (+10.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7297153...e6784a2. Read the comment docs.


How do I get an owned Info?

Cargo.toml:
[package]
name = "repro"
version = "0.1.0"
edition = "2021"

[dependencies]
png = "0.17.11"

main.rs:
use std::fs::File;
use std::path::Path;

use png::{Decoder, DecodingError, Info};

fn main() {
    decode_and_return_info("irrelevant.png").unwrap();
}

fn decode_and_return_info<P: AsRef<Path>>(png: P) -> Result<Info<'static>, DecodingError> {
    let dec = Decoder::new(File::open(png.as_ref()).unwrap());
    let mut rdr = dec.read_info()?;
    rdr.finish()?;
    Ok(rdr.info().clone().to_owned())
}

Expected result: Code compiles.
Actual result:
error[E0515]: cannot return value referencing local variable `rdr`
  --> src\main.rs:14:5
   |
14 |     Ok(rdr.info().clone().to_owned())
   |     ^^^---^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |     |  |
   |     |  `rdr` is borrowed here
   |     returns a value referencing data owned by the current function

error: aborting due to previous error

I'm trying to read a PNG, make slight modifications, then save a new PNG, and ran into the above error when trying to put the decoding part into its own function. I can't find any way to get an Info<'static>.

Seems we were returning the Info struct with the wrong lifetime parameter... just opened #465 to fix


ZEPPELIN-3672. spark interpreter: Java output (to the console) is lost

What is this PR for?
This is to fix the bug of redirecting java stdout to zeppelin frontend
What type of PR is it?
[Bug Fix]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3672

How should this be tested?

Unit test added

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

Will merge if no more comments


Screenshot1 Android Aos3

2030 screenshot

@CodeAWS1
It would be great if you could elaborate your query and add a link to the documentation you are following for these steps? This would help us redirect the issue to the appropriate team. Thanks!

<!-- (c) 2005, 2024. Authorize.Net is a registered trademark of CyberSource Corporation --> <div class="AuthorizeNetSeal"> <script type="text/javascript" language="javascript">var ANS_customer_id="ca36d066-82ac-4830-a755-a65f6518a0a3";</script> <script type="text/javascript" language="javascript" src="//verify.authorize.net:443/anetseal/seal.js" ></script> </div>

@CodeAWS1
Please Note, GitHub forum is dedicated for Microsoft docs related issues. Please elaborate your query and add a link to the Microsoft documentation you are following.

@CodeAWS1
We are going to close this thread, if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.
#Please-close


Allow SelectionPrompt to have an initial selection

fixes #508

[x] I have read the Contribution Guidelines
[x] I have commented on the issue above and discussed the intended changes
[x] A maintainer has signed off on the changes and the issue was assigned to me
[x] All newly added code is adequately covered by tests
[x] All existing tests are still running without errors
[x] The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

SelectionPrompt now has a DefaultValue property that can be used to set the item that should be initially selected.

Please upvote :+1: this pull request if you are interested in it.

This, for me, is the number one missing feature.
Often we presents the users with a large list of operations
until this PR they had to scroll through the list every time (because they often repeat commands).
Now we simply set the last command they executed as the default.
Just tested this and it works great:
var fruit = AnsiConsole.Prompt(
    new SelectionPrompt<string>()
        .Title("What's your [green]favorite fruit[/]?")
        .PageSize(10)```
        .DefaultValue("Banana") // <--- Setting the default value
        .MoreChoicesText("[grey](Move up and down to reveal more fruits)[/]")
        .AddChoices(new[] {
            "Apple", "Apricot", "Avocado",
            "Banana", "Blackcurrant", "Blueberry",
            "Cherry", "Cloudberry", "Cocunut",
        }));

AnsiConsole.WriteLine($"I agree. {fruit} is tasty!");