Performance: investigate faster sorting options

Currently splat sorting uses AMD Fidelity FX based radix sorting. I actually have no idea how "good" or state-of-the-art it is, but some other options might be worth looking into:

Alter the same sorting routine to not sort on full 32 bits of depth -- maybe 16, 20 or 24 bits would be just fine, especially if depth is quantized to be only within object's range. The current sort code is doing 4 bit radix rounds, so that would cut down on the number of rounds it does.
Look into other sorting approaches. State of the art seems to be OneSweep radix sort, but that one might not work on all platforms (I think due to lack of globallycoherent on Metal?), plus most implementations of it seem to be hardcoded to nvidia SIMD width.

Hi @aras-p I'm the author of the OneSweep implementation for Unity.
It should be relatively simple to make a generalized version of my code that would support both Nvidia and AMD hardware. As for Metal, an older technique, reduce-then-scan can be used, which, based on my own testing in CUDA, is about 85% the performance of OneSweep. Regardless, it would still be significantly faster than Fidelity FX due to the 8-bit radix.
I'm not sure if maintaining multiple shader variants for different platforms is feasible, but if you're interested I would love to contribute. Currently, I am currently working on implementing DietGPU in compute shaders, which is GPU based ANS compression, and could possibly be useful in piping data to the GPU.

I still need to test on AMD but preliminary results on iteration_30000 bicycle medium asset preset, indicate about a ~30% framerate increase. On my 2080 super I went from about ~70 fps to about ~95 fps. You can use performance uplift in the following frame nsight frame captures:
Previous:

New:

Honestly, I don't have very much experience debugging shaders, so my integration testing was very janky--I basically dispatched the sorting routine immediately during the GpuSorter.dispatch function call instead of through the command buffer. Then I checked if whatever was in the srcKeyBuffer at the time was sorted correctly, so it will definitely need more testing, but the image appears to be free from visual artifacts.
I can make a pull request now if you want to try it out yourself on a beta branch while I begin testing on AMD hardware.

Implemented by #82


[$500] [Form Provider Refactor] CloseAccountPage

Coming from here, we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.
This issue is specific to refactoring src/pages/settings/Security/CloseAccountPage.js
cc @kowczarz
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e0b63c230cc9d136
Upwork Job ID:<PHONE_NUMBER>605139456
Last Price Increase: 2023-10-05

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

waiting on PR
Payments:

Reporter: N/A
C+: software mansion - no payment
PR Reviewer: @narefyev91

@luacmartins it looks like you were the reviewer on PR (https://github.com/Expensify/App/pull/28627) attached to the bug report you linked above
Which PR did @narefyev91 review that warrants payment via this particular GH?

We still don't have a PR for this issue. I think @narefyev91 got assigned to review the upcoming PR, but we gotta wait a bit

Still waiting on the PR.

Still working on other form PRs.

Hello, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I would like to work on this task. Kamil reassigned it to me.

No payments required.
This is a refactor - also no checklist needed.


[SSR/Astro] DOM Not Updated from State by Client Updates onMount

Describe the bug
When SSRing with state and that state is updated on the client immediately/onMount, the new value is not reflected in the DOM.
Your Example Website or App
https://stackblitz.com/~/github.com/NexRX/astro-solid-nanostore
Steps to Reproduce the Bug or Issue
Using my example which demos a simple theme toggle defaulting to 'dark' mode...

Click the toggle to change the state to 'light' mode.
Reload the page
Observe page reflects 'light' mode (because store subscriber is changing this) but controls show the 'dark' mode.
a. Press the button to console log state which shows store actually holds 'light'

Expected behavior
When the client takes over after SSR the DOM reflect the updated state from onMount
Screenshots or Videos

Platform

OS: Windows 11
Browser: Chrome
Version: 124

Additional context

You can afterward toggle it a couple times which fixes the issues only after.
When rendering with astro using client:only the problem goes away (but not ideal)
The nanostore-persistant uses nanostore's version of onMount but I did fork and try using solid-js's onMount to the same effect

Hi all, this has been sitting here for a bit now. Anything I can do to contribute to fixing this? :)

Well trying to decide what to do here. Solid is acting exactly how I'd expect it to. But I can see why the situation is awkward. Server renders dark, it hydrates thinking light, it assumes it matches which it doesn't and we don't do corrections. Then when you toggle it to light.. the client already thinks it is light so it doesn't propagate any change.. You have to change it to dark to change it to light again.
Your best bet is to have the server and client always match on initial render and then have the localStorage kick in. Which means it needs to hydrate dark. Which means nano-stores persistent atom isn't helping you here.
Changing your component to this works:
const nanoTheme = useStore($theme);
const [theme, setTheme] = createSignal("dark")
createEffect(() => {
   setTheme(nanoTheme())
})

But it does feel a bit like it isn't leveraging the the niceness of what nanostores is trying to offer. That being said persistent store as a source of truth with hydration seems like it isn't a good pattern in general.

Yeah the more I look at this the more I can't say this is a bug. Persistent storage is always going to cause rendering to not match unless you apply it after mount/hydration.

Ah okay, thanks for the insight at least. What would be your goto for applying after mount? I tried using createEffect/onMount but had no luck. I assume you mean post the point of a onMount triggering and running?

No I meant onMount or createEffect. I edited the example and it seemed to switch fine. The problem is that the persistent nanostores start in the "correct" state which is wrong for hydration. So the server rendering and the client have to start at the fixed value and then apply the localStorage after. Typically in Solid I'd just be doing this by directly grabbing from localStorage in a onMount but given that the desire in your example was for nanostores to stay in sync I did that sort of createEffect syncing thing. Since I can't imagine this toggle is a hyper performance area the fact it writes in an effect should be fine.

I think a better approach is to update the state from browser storage once hydration is complete. Using onMount or createEffect can be cumbersome when managing global state. Instead, wrap your code in createRoot and initialize it in entry-client.tsx after mount is much easier for me.


xbox + 4k = problems²

Hi,
few days ago I started testing on the Xbox. The results so far are somewhat disappointing, unfortunately. Full HD playback is working in most cases, but when it comes to 4k playback, the results rather appear to be like with Raspberry PI than with a contemporary gaming console. I don't mean to blame anybody or anything, I really don't know what it is and it's very possible that the error is on my side.
The symptoms are primarily about stuttering/pausing of playback, which means that processing is simply too slow to playback continuously. In the worst cases, it can be like 10s pausing for 1s of playback. It appears that the more data is moved around, the worse it gets. There's a dependency on the bandwidth of the source material, but also on later stages in the playback chain. For example, a video which plays almost fluently in SDR is hanging/stuttering once the device is set to HDR mode.
The bottleneck appears to be system (CPU) memory. There's a limit of 1GB RAM for UWP apps and this always gets hit instantly when starting playback (there's a capability to extend this to 1.5 GB, but it doesn't help much.
There's also not much difference when switching between SystemDecoder and FFMpegSoftwareDecoder. In none of those cases does it appear to use a purely GPU-based video pipeline - otherwise memory usage shouldn't increase so steep.
Any ideas what it can be and what I should try?
Is there some log output (like from ffmpeg) that I can acquire?
Are there any options that I should set in a certain way?
And finally, what does "System Decoder" mean, actually?
Thanks

Hi,
We never tested this on an xbox. None of us has an xbox for testing.
System decoder should be the way to go forward in xbox.
It means we only do demux in our library, and the system handles the decoding. We passthrough encoded samples to the OS to use its internal codecs to do the decoding, this should be the same as using MediaSource.FromStream or Uri.
So system decoder is different than the D3D or software options in which we do both demux and decoding.
I think D3D decoder does not work on xbox. No idea why. It might be some API incompatibility.

Maybe you are feeding too fast/much?

Is it a pull or a push model?

This kind of memory build up usually occurs when the timestamps of the samples are "wrong", they do not come at the current playback position but at an earlier or later position. So the system keeps buffering samples instead of playing them.

I happens with every 4k video. Even a H.264 one. Only onee with very low bandwidth are playing (more or less).

but remember these are compressed samples in the system decoder scenario, so it shouldn't go overboard.

Yea, such blowup rather looks like software decoding. How can I see what's actually happening with ffmpeg. Is there a log output?

If you can attach a debugger you can see some logs in the output window, there's also the ILogProvider interface you can use.
But the scenario of us accidentally doing a software decode is unlikely. When we use System decoder option, we create VideoEncodingProperties that fit the target format (h264, h265, vp9, etc see https://learn.microsoft.com/en-us/uwp/api/windows.media.mediaproperties.videoencodingproperties?view=winrt-22621), and when we use software decoder we use nv12 format.
So if we were to feed nv12 (output of software decoder) into those h264/265/whatever formats, you'd usually get a green screen and not see any video at all.

I think I figured it out why I always got software decoding:
I was setting the VideoDecoderMode after FFmpegMediaSource.CreateFromUriAsync. I had set it once at an earlier point, but then I got no video, just audio, so I moved it back to afterwards.
Probably it needs to be set before. But that just replaces one problerm with another one...

The HEVC files are playing fine with regular playback (like MediaSource.CreateFromUri(uri))
From the comparison, I could see that playback startup in the failing case is much faster, wich likely indiicaes that there's not even an attempt being to set up and initialize video decoding.

When I set VideoDecoderMode to Automatic, I see this in the debug output:
Exception thrown at 0x00007FFAC7223EEC (KernelBase.dll) in My.Client.Uwp.exe: WinRT originate error - 0x80070057 : 'Adjusted video area is smaller than supported by format'.
Exception thrown at 0x00007FFAC7223EEC (KernelBase.dll) in My.Client.Uwp.exe: WinRT originate error - 0x80070057 : 'Adjusted video area is smaller than supported by format'.

I think the automatic will pick up directx decoder because the hardware technically supports the codecs, but ffmpeg then fails to decode properly.

I made a little progress and got a few new findings. As usual, it's getting more complicated  instead of easier.
@brabebhin,  you were right - at least in regards to one of the files, which is a 4k H.264 file. And hw decoder on the xbox doesn't support resolutions > FullHD.
This applies to both cases, ForceSystemDecoder and Automatic. In both cases it falls back to software decoding. In the latter case, ffmpeg outputs:
>>>> Debug [h264 @ 0000012AB8EF3880] Format d3d11 not usable, retrying get_format() without it.
>>>> Debug [h264 @ 0000012AB8EF3880] Format yuv420p chosen by get_format().
>>>> Info [h264 @ 0000012AB8EF3880] Reinit context to 3840x2160, pix_fmt: yuv420p

I don't think it's a technical limitation since the GPU can decode HEVC 4k, which is much more compute intensive. Probably it's about cost which they wanted to avoid (paying to AMD for GPU features).
That makes sense when considering another detail: HEVC playback is locked behind a restricted capability. Without that, you cannot even switch display to HDR mode. I'm confident though, that we will get this granted. It's just a measure to avoid paying license fees for all xboxes. By tracking which apps are installed on how many boxes, they'll be able to pay only for those devices where an app is installed that needs it.
Anyway, H.264 4k is not a big deal. We'll mark this as unsupported and then the server will transode in those cases.

HEVC
For HEVC it's getting interesting. Now that I have the logging attached, I can better see and understand what's actually happening.
Altogether there are 4 ways how to playback HEVC videos:
1. FFmpegInteropX   with ForceFFmpegSoftwareDecoder
This is basically working but it's way too slow, it hangs and stutters and not useful practially.
2. Windows.Media MediaSource
Without FFmpegInteropX, all cases are working well (4k yes/no, HDR yes/no).
3. FFmpegInteropX with ForceSystemDecoder
This hasn't been working so far - but more precisely: It does play in fact and no error is logged. Audio is playing and FFmpeg continuously downloads the video data. I even see some log messagess from DX11VA dlls.
"Only" problem: The screen remains dark - no picture. But also no error.
Then I did a comparison of the VideoEncodingProperties from case 2 and this one (in the MediaOpened event).
I noticed that the SubType was set to "HEVC" in case 2 and "HEVCES" in this case.
Elementary Streams ("ES") are a concept of MPEGTS so I wonder why it's set to HEVCES even though I never played an MPEGTS?
But then I did, and wonder what? In those cases it's working fine and the videos are visible.
=> My suspicion would be that there's something with the data it gets, which causes it to assume that it gets an elementary stream  Maybe, then it's just parsing and waiting for data it can recognize. (which never happens)
4. FFmpegInteropX with Auto (FFmpeg HW Decoding)
There's no general issue like that FFmpeg couldn't do D3D11VA decoding on the Xbox.
It is working successfully with an H.264 FullHD video.
I hadn't tested this "Auto" setting much before, because "Auto" might often be convenient, but for testing something, it's rarely a good choice, because "Auto" often implies that you won't know what's happening.
The few times I tested it, I must have a mismatch between the active screen's HDR mode and the HdrSupport setting (Enable or Disable), because that causes the app to freeze forever and I had experienced that as well.
If the HDR settings match, then it's playing - basically. But not as good as in case 2.
Here, it depends on the framerate. 24fps videos (HEVC, 4k, HDR) are playing ok, but with 60fps videos, I see hanging and stuttering.
Maybe this can be improved by tweaking ffmpeg parameters, I'll try that.
I couldn't compare with 3 because I don't have am mpegts video with 60fps.
My priority would be trying to fix 3 rather than fiddling around, in tweaking 4.
Even though the exact same HW decoders being used in both cases, there are differences in the way how the decoding is orchestrated (surface pool counts, surface allocation, releasing, recycling, forwarding for presentation, supplying data via staging surfaces, etc.).
FFmpeg DXVA decoding is not optimized for use in a player, while MS' implementation is surely very well optimized for playback, most likely with the help or done by the manufacturer (AMD) in case of a product like xbox.
@brabebhin - you said already that ForceSystemDecoder is the way to go on xbox and I think you are very right about that.
Does any of you have an idea what it could be in case of 3?

Wow @softworkz  thanks for the detailed breakdown.
I have checked the code, and we don't explicitly set HEVCES subtype anywhere, so this must somehow come from ffmpeg or something.
The next step I can think of here is trying to reproduce this in one of the samples, maybe we a debugger attached we can better understand what's going on.
Would it be possible to share that HEVCES video?

Just for reference, here are the available decoders on my Xbox (Xbox S) alongside the color formats being used:
{1b81bea3-a0c7-11d3-b984-00c04f2e73c5}: DXGI_FORMAT_NV12  DXVA_ModeVC1_D/DXVA_ModeVC1_VLD - VC-1 variable-length decoder
{1b81be68-a0c7-11d3-b984-00c04f2e73c5}: DXGI_FORMAT_NV12  DXVA_ModeH264_E/DXVA_ModeH264_VLD_NoFGT - H.264 variable-length decoder, no film grain technology
{ee27417f-5e28-4e65-beea-1d26b508adc9}: DXGI_FORMAT_NV12  D3D11_DECODER_PROFILE_MPEG2_VLD - MPEG-2 variable-length decoder
{efd64d74-c9e8-41d7-a5e9-e9b0e39fa319}: DXGI_FORMAT_NV12  DXVA_ModeMPEG4pt2_VLD_Simple - MPEG-4 Part 2 variable-length decoder, Simple profile
{705b9d82-76cf-49d6-b7e6-ac8872db013c}: DXGI_FORMAT_NV12  DXVA_ModeH264_VLD_Multiview_NoFGT - H.264 MVC variable-length decoder, multiview
{5b11d51b-2f4c-4452-bcc3-09f2a1160cc0}: DXGI_FORMAT_NV12  DXVA_ModeHEVC_VLD_Main - H.265 variable-length decoder, Main profile
{107af0e0-ef1a-4d19-aba8-67a163073d13}: DXGI_FORMAT_P010  DXVA_ModeHEVC_VLD_Main10 - H.265 variable-length decoder, Main 10 profile
{463707f8-a1d0-4585-876d-83aa6d60b89e}: DXGI_FORMAT_NV12  DXVA_ModeVP9_VLD_Profile0
{a4c749ef-6ecf-48aa-8448-50a7a1165ff7}: DXGI_FORMAT_P010  DXVA_ModeVP9_VLD_10bit_Profile2

I have checked the code, and we don't explicitly set HEVCES subtype anywhere, so this must somehow come from ffmpeg or something.

Yes, I checked that as well. This seems to be set by the Windows.Media framework.  FFmpegInteropX also isn't setting any properties (https://learn.microsoft.com/en-us/uwp/api/windows.media.mediaproperties.videoencodingproperties.properties), which are populated like this:

Would it be possible to share that HEVCES video?

This happens for all videos I tried, which were mp4 and mkv.
(also for .ts - but for those it's correct)
I'll try now on desktop Windows to see how that compares.

Please try with branch from fix-hevc-passthough. It should fix playback on XBOX.
The HEVCES subtype seems to be created when we use VideoEncodingPropertiex.CreateHevc(). But it does not cause problems once the NAL packet parsing bug is fixed. Works all fine now for me.

Please try with branch from fix-hevc-passthough. It should fix playback on XBOX.
The HEVCES subtype seems to be created when we use VideoEncodingPropertiex.CreateHevc(). But it does not cause problems once the NAL packet parsing bug is fixed. Works all fine now for me.

Excellent - that was it. Thank you very much!


Issue on playing video on ios

Description
Hey there i am trying to send video message its working fine the url i am getting after uploading video is not working. when i trying to play that url in any video player in react native its not playing giving me error of "The server is not correctly configured".  its working fine android successfully playing video but on ios its not playing my video url is
"https://a41.chat.agora.io/41909830/1147502/chatfiles/1c4ba910-0c33-11ee-b19d-0b7dfceb0053"
i went to mention its working fine before 1.1.2-beta5 i have tested at that time its working good but now its not playing the url although if you paste this url on chrome its downloading the video not playing it.
Version
1.1.1
Output of npx react-native info
System:
OS: macOS 13.0
CPU: (8) arm64 Apple M2
Memory: 134.06 MB / 8.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 19.7.0 - /opt/homebrew/bin/node
Yarn: 1.22.19 - /opt/homebrew/bin/yarn
npm: 9.5.0 - /opt/homebrew/bin/npm
Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.12.0 - /Users/algoacepc/.rvm/gems/ruby-2.7.6/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
Android SDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9619390
Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
Languages:
Java: 11.0.18 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.1.0 => 18.1.0
react-native: 0.70.6 => 0.70.6
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
npx react-native run-android
create a video message by
    const thumbnailPath = response?.path?.replace('file://', '');
    console.log('thunbnail response', response);

    //creating video message
    const msg = ChatMessage.createVideoMessage(convId, filePath, convType, {
      displayName: fileName,
      thumbnailLocalPath: thumbnailPath,
      duration: 5,
      width: 200,
      height: 200,
      isChatThread: false,
    });

then after uploading try to play video url with some video player for that i am using react native video
Snack, code example, screenshot, or link to a repository
https://github.com
Platform

[ ] All
[ ] Android
[X] iOS

SimulatorOrDevice

[X] All
[ ] Simulator
[ ] Device

iOSVersion

[ ] All
[ ] iOS Earlier than 8
[ ] iOS 8
[ ] iOS 9
[ ] iOS 10
[ ] iOS 11
[ ] iOS 12
[ ] iOS 13
[X] iOS 14
[X] iOS 15
[X] iOS 16 or above
[ ] Android Earlier than API Level 23
[ ] Android API Level 23
[ ] Android API Level 24
[ ] Android API Level 25
[ ] Android API Level 26
[ ] Android API Level 27
[ ] Android API Level 28
[ ] Android API Level 29
[ ] Android API Level 30
[ ] Android API Level 31
[ ] Android API Level 32
[ ] Android API Level 33 or above

Can you give a specific example of your video file path?

https://a41.chat.agora.io/41909830/1147502/chatfiles/1c4ba910-0c33-11ee-b19d-0b7dfceb0053
this is video url i am trying to play if i paste this in browser its downloading rather then playing and if i try to play this url in react native video player its giving me error "The server is not correctly configured

Streaming is not supported. It is recommended to download to the local and use the local url to play.

See also the examples here. Including the processing of receiving and sending video messages.
https://github.com/AsteriskZuo/rn_msg_demo

hey there i have checked on android the video streaming working fine but on ios is not working is there any way to stream the video because before video streaming is working fine on previous version but now its not.

hey there i have read your source code there i found following code
const VideoMessageRenderItemDefault: ListRenderItem =
React.memo(
(info: ListRenderItemInfo): React.ReactElement | null => {
const { item } = info;
const msg = item as VideoMessageItemType;
const { width: wWidth } = useWindowDimensions();
const [width, setWidth] = React.useState(wWidth * 0.6);
const [height, setHeight] = React.useState((wWidth * 0.6 * 4) / 3);
const video = React.useRef({} as any);
const [status, setStatus] = React.useState({} as any);
const [url, setUrl] = React.useState(msg.remoteUrl ?? msg.localPath);
  const onCheck = async () => {
    const ret = await new FileHandler().isExisted({
      fileUri: updateUrl(msg.localPath),
    });
    if (ret) {
      setUrl(updateUrl(msg.localPath));
    }
  };

  const hw = (params: {
    height: number;
    width: number;
  }): { width: number; height: number } => {
    const { height, width } = params;
    let ret = params;
    if (width / height >= 10) {
      const w = wWidth * 0.6;
      ret = {
        width: w,
        height: w * 0.1,
      };
    } else if (width * 4 >= 3 * height) {
      const w = wWidth * 0.6;
      ret = {
        width: w,
        height: w * (height / width),
      };
    } else if (width * 10 >= 1 * height) {
      const h = (wWidth * 0.6 * 4) / 3;
      ret = {
        width: (width / height) * h,
        height: h,
      };
    } else {
      // width / height < 1 / 10
      const h = (wWidth * 0.6 * 4) / 3;
      ret = {
        width: 0.1 * h,
        height: h,
      };
    }
    return ret;
  };

  if (item.state === 'recalled') {
    return <RenderRecallMessage {...item} />;
  }

  return (
    <View
      style={[
        styles.container,
        {
          flexDirection: msg.isSender ? 'row-reverse' : 'row',
          // maxWidth: '80%',
        },
      ]}
    >
      <View
        style={[
          {
            marginRight: msg.isSender ? undefined : 10,
            marginLeft: msg.isSender ? 10 : undefined,
          },
        ]}
      >
        <Ionicons name="person-circle" size={24} color="black" />
      </View>
      <Pressable
        onPress={() => {
          if (status?.isPlaying) {
            status.isPlaying
              ? video.current?.pauseAsync()
              : video.current?.playAsync();
          }
        }}
      >
        <Video
          ref={video}
          style={{ height: height, width: width, borderRadius: 10 }}
          source={{
            // uri: "https://d23dyxeqlo5psv.cloudfront.net/big_buck_bunny.mp4",
            uri: url,
          }}
          useNativeControls
          resizeMode={ResizeMode.CONTAIN}
          isLooping
          onPlaybackStatusUpdate={(s) =>
            setStatus(() => {
              dlog.log('video:onPlaybackStatusUpdate:', s);
              return s;
            })
          }
          onReadyForDisplay={(e) => {
            dlog.log('video:onReadyForDisplay:', e);
            const ret = hw(e.naturalSize);
            setHeight(ret.height);
            setWidth(ret.width);
          }}
          onError={(e) => {
            dlog.log('video:onError:', e);
            onCheck();
          }}
          onLoad={(s) => {
            dlog.log('video:status:', s);
          }}
        />
      </Pressable>
      <View
        style={[
          {
            marginRight: msg.isSender ? 10 : undefined,
            marginLeft: msg.isSender ? undefined : 10,
            opacity: 1,
          },
        ]}
      >
        <StateLabel state={msg.state} />
      </View>
    </View>
  );
}

);
in this code for veiwing the video you are not downloading the video rather then you are just checking if video exit in local storage or not if any error occur while playing video. and also i had notice that you url for playing video is  following look like this
// uri: "https://d23dyxeqlo5psv.cloudfront.net/big_buck_bunny.mp4"
but  i am recieving of video url like this following
https://a41.chat.agora.io/41909830/1147502/chatfiles/1c4ba910-0c33-11ee-b19d-0b7dfceb0053


[Hackadoc] Adding "Manage Access To Azure Storage Resources" page

Why does the article end at a TOC


Introduce admin advisory banner component

Purpose
This PR introduces the admin advisory management module. This module is used for displaying an admin advisory banner in management console login page and authentication endpoint. The PR introduces a SOAP service for management console and the same service class is registered as an OSGI service to be used for the REST API.
Also the banner related changes are added to the login.jsp file.
Related Issues

Issue https://github.com/wso2/product-is/issues/15521

Related PRs

PR https://github.com/wso2/carbon-identity-framework/pull/4536
PR https://github.com/wso2/identity-api-server/pull/441
PR https://github.com/wso2/identity-apps/pull/3872
PR https://github.com/wso2/product-is/pull/15700

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/4742697222

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/4742697222
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/4743058677

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/4743058677
Status: success


Replace purne by prune

Describe the bug
There are eight files with text similar to "system purne in progress" where prune is misspelled.
Suggest changing purne into prune.
See this code search

Interested in opening a PR?

See pull request https://github.com/containers/podman-tui/pull/515


Doesn't support signed fields

Thanks you very much for reporting this issue!
And sorry for delay in responding.

Thanks for fixing it! <3


Remove hardcoding from New-VesterConfig

Oh boy, lots of talking. <inhale>...
The primary purpose of this PR is overhauling New-VesterConfig, removing all hardcoded lines to pull values. Instead, it now dynamically pulls values based on all the .Vester.ps1 tests found in the module folders. This is an important step in making new tests as easy to contribute as possible.
I added the following fields to every .Vester.ps1 file:

$Description: One sentence describing what the test does. Helpful to expose to the user during New-VesterConfig, but also just nice to have when anyone is manually reviewing a test file
$Type: By moving this out of the $Desired area, I believe this solves the typing concerns we've been running into (s/o @noesberger, @haberstrohr). Almost everything here will be bool/int/string/string[]

After each scope (e.g. "Cluster"), New-VesterConfig will display the values it found to the screen. I started writing code to help the user change those values right away, but it was pretty buggy, so I left that commented out. For the forseeable future, changing values should continue to be done by opening up the config.json file in a text editor.
I need to update the unit tests for New-VesterConfig, but that'll be done later. The private functions are just modularizing some code that helps me write better unit tests.

Reviewing now. Just one comment that I think editing the JSON file after the configuration is created is fine.


Loading Profiles with C# client

Based off your example I've been making my own little console app to select saved profiles in OpenRGB.
As long as the profiles saved are in Mode Direct, all is fine but if a profile saved is say Daylight as Mode then when my client loads that profile but nothing happens.
BTW this bulb is a Philips Wiz.
Any thoughts?
Thank you

I guess this project is dead.


Update Emitter utility method

Proposed changes
Adding a common usecase for the analytics.on() method
Merge timing
ASAP
Related issues (optional)

Hey @silesky I agree, I did provide the ready() method as well, but the customer wanted to fetch the Ids right after AJS initialisation, and did not want to wait for/be impacted by destinations being initialised.
So the on() method seems to make more sense that way.
Let me know your thoughts..

Hey @silesky I agree, I did provide the ready() method as well, but the customer wanted to fetch the Ids right after AJS initialisation, and did not want to wait for/be impacted by destinations being initialised. So the on() method seems to make more sense that way. Let me know your thoughts..

Customer is mistaken, there is basically no difference in initialization timing between ready and initialized, they are virtually the same -- both wait for plugins to be registered. For all intents and purposes,  they are interchangeable.

Hi Seth, thanks for the clarification, here is a thread on this topic with cradek, where he proposed this as a solution: https://twilio.slack.com/archives/CATJY9BDW/p1700193167765019
Just a bit confused on the usage of on() hence sharing this with you to review.
Apologies for the delay in getting back to you.


[Feature Request] Compiling the app to only allow a single server

This might sound weird, but assume that I start my own server, I would like to make the desktop client to only access my server, or at least treat my server as "first class" such that I can distribute the compiled app binaries to my fans/users.
Is it possible to make a config file for this?

https://github.com/RocketChat/Rocket.Chat.Electron#pre-release-configuration


[Request] random_account return dictionary

Currently an ordered list is returned which works but it'd be better if a named dictionary were used.
return {'user': try_username, 'password': password, 'email': try_email}

I thought that was supposed to close this issue, but perhaps the 'closes' keyword in the commit is case sensitive or something.  In any case, I concur that a dict is a better design decision, and have made the change for future versions.


agent: Add start/stop resource to rust agent

This is to suppliment python agent start_target.  It does not do any movement if the resources is started, nor does it try to force a start in a particular place.
Related #1464
Signed-off-by: Nathaniel Clark<EMAIL_ADDRESS>

This change is

Why does this supplement the python start_target instead of replacing it?

Why does this supplement the python start_target instead of replacing it?

Because of all the other work that start_target does (looking for paired ZFS resources, and movement of resources)

Looks like there is a failure in the integration tests.


[MM-9769] Fix that after clicking "Add comment" from preview mode, it won't exit preview mode

Summary
Fix that after clicking "Add comment" from preview mode, it won't exit preview mode
Ticket Link
https://github.com/mattermost/mattermost-server/issues/8430
Jira Ticket
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed

Thanks @CoolTomatos! Looks like there's a build failure, can you help take a look?

@jasonblais sure. I am checking the details.

@jasonblais sorry I didn't double check before committing.
Now the building failure has been fixed. Please check again.

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

Spinmint test server created at: http://i-05a9c84aabe297286.spinmint.com
Test Admin Account: Email<EMAIL_ADDRESS>| Password: user-0
Test User Account: Email<EMAIL_ADDRESS>| Password: user-1
Instance ID: i-05a9c84aabe297286

Spinmint test server destroyed

@jasonblais Mattermod is cute. Why delete his comments 😜😜😜

Hey @CoolTomatos and the group,
As per the discussion in the above thread (https://github.com/mattermost/mattermost-webapp/pull/935#discussion_r174126662), there are concerns that accepting these changes will result in race conditions and possible regressions. In fact, they revert a previously found fix for a race condition submitted here https://github.com/mattermost/mattermost-webapp/pull/844
As a result, we won't be able to accept this PR - it completely our fault as we shouldn't have created the help wanted ticket yet.
We would first want to submit a PR to handle the state in Redux as described above, then submit a bug fix for https://github.com/mattermost/mattermost-server/issues/8430. If your group is interested, you could expand the PR to moving the state to Redux, or we can close the PR for now and do that work separately. Let us know what works the best for you.
Really apologize that our process failed here.

@jasonblais
Np, I will close it.


fix: oneline textarea bug

Works correctly on firefox browser now
closes #452

@AbhinavMV could you check how this one works now for you?

Btw there are no tests for this component.
Should we add one basic test in this PR only or create a new issue? @Y0moo

no tests? wow how did that slip by, yeah please add them @AbhinavMV TY

Have added some basic tests for all stories.
And also added this component in readme file.


Poor performance with high brush sizes

Here's a video comparing performance at different brush sizes.
https://github.com/outobugi/Terrain3D/assets/98223724/f1bd3c17-7197-4a1e-b5b1-95a122aac8af
Quickly tried Unreal's built in terrain editor and it does perform better at seemingly 4x the brush size (assuming I'm right about the units). Whatever the case a performance improvement when drawing at some point in the future is definitely possible and would be nice to have.

Happen’s the same with me, it mainly because it painted on the cpu unlike using the gpu see  https://github.com/outobugi/Terrain3D/issues/174

see #174
Ah, i thought that was about painting on the textures and not terrain for drawing/sculpting.

This is indeed a duplicate of #174. All sculpting, texturing, coloring, roughness are painting operations. All heightmap terrain editors are just fancy painting apps.
BTW, if you're going to use the terrain stamps turn off jitter in the advanced brush settings.
Also in the video you are painting an area 600m across.


add getDimension static method for VictoryLegend

adds the static method getDimension(props) which return an object with the calculated width and height for the legend
closes https://github.com/FormidableLabs/victory/issues/898
closes https://github.com/FormidableLabs/victory/issues/854

@boygirl Could you explain how to use this?
I try to use it in the following fiddle but I am getting a width: NaN, height: NaN
https://jsfiddle.net/803xmr24/4/

Hey @boygirl, I'm trying to understand this as well, how can i use this getDimensions? Thanks

@bgold0 If you are still wondering, i figured out. you need to pass in the font size.


[Header] Header actions buttons with dropdowns styling

Moving over internal issue https://github.ibm.com/ai-applications/pal/issues/368
—————
Trying to explore the header action buttons with dropdowns and the styling doesn't match what is shown in the storybook

@dianatran18 Where did you get the incorrect screenshot from?

Oh this wasn't created by me — this was created by Josh on this internal issue and I was just creating an issue here to track it on the dev side back then.
If this is fixed, then we can close both internal/external issues.

I believe this has been fixed, but it's hard to recreate. Feel free to re-open if the problem persists.


User cannot type char that is equals to placeholder char

Hi,
in the handleCellInputChange we have something like this:
    val formattedNewValue = newValue.replace(placeHolder, String.EMPTY)         .replace(obscureText, String.EMPTY)
Is the method for replace placeholder really needed? Currently in my project i need to have placeholder set as "0", but i need to allow user to type "0" in the cell. This function blocks user for typing "0" because this input char is removed

Yep, I guess it was used for something else but it's not needed anymore. it's now fixed in 1.0.8.
Please check it out and thanks for your feedback 🙏.


[1.20.1] CRASH: Upgrading Medieval Weapons to Netherite with Better Nether installed

Minecraft Version
1.20.x
Mod Loader Version
0.14.22
Mod Version
medievalweapons-1.4.7.jar
Describe the Issue
Issue: Placing weapons from the Medieval Weapons into the smithing table slot, the game crashes with the following message:

Description: mouseReleased event handler
java.lang.AbstractMethodError: Receiver class net.medievalweapons.item.Long_Sword_Item does not define or inherit an implementation of the resolved method 'abstract void putEnchantments(net.minecraft.class_1799, java.util.Map)' of interface org.betterx.betternether.interfaces.InitialStackStateProvider.
at net.minecraft.class_8060.handler$zfb000$betternether$bcl_assemble(class_8060.java:540)
at net.minecraft.class_8060.method_8116(class_8060.java)
at net.minecraft.class_4862.method_24928(class_4862.java:100)
at net.minecraft.class_4861.method_7609(class_4861.java:106)
at net.minecraft.class_4861$3.method_5431(class_4861.java:96)
at net.minecraft.class_1277.redirect$baa000$fabric-transfer-api-v1$fabric_redirectMarkDirty(class_1277.java:543)

This only occurs with BetterNether installed, probably a compat issue again.
Without BetterNether:

latest.log
crash-2023-08-30_14.59.34-client.txt
Do you use any other mods except the required ones?
better-nether-9.0.9.jar
cloth-config-11.1.106-fabric.jar
bclib-3.0.13.jar

For Record: BetterNether has now 2 different sets instead of one.
They also changed names and enchantments

Fixed with https://github.com/Globox1997/MedievalWeapons/commit/cd81b95686cd3ee585797fe3fcd9118486bc633c


Migrate HostMessages to PlatformMessages

We'll eventually remove HostMessages because it's just a pass-through to
PlatformMessages, but that will be a separate step.

@jason-simmons
This is the last one.

LGTM


If bridge V3 don't run for binance and rinkeby and other fixes

Fix federator retrie condition
Clean log context after transaction
Combine logs to compact information on screen
Add chainId to IBridgeV3 constructor to filter Binance and Rinkeby from running
Add harcoded version after checking the version with the factory to reduce network calls
Fix ntfIntegrationTest db path

Coverage remained the same at 95.56% when pulling 640056d1cef97092042efa7661b8d3290ef5b6e3 on TBRE-452 into bbc7974cdcd981d4f64d51ce9de51682176c745f on TBRE-455.


[stable/influxdb] Support list of ranges for loadBalancerSourceRanges

What this PR does / why we need it:
Support list of ranges for loadBalancerSourceRanges.
For some reason the previous code would only work with a single element, if several IP ranges were given it will fail with
Error: YAML parse error on influxdb/templates/service.yaml: error converting YAML to JSON: yaml: line 13: did not find expected key

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] title of the PR contains starts with chart name e.g. [stable/chart]

/assign @jackzampolin

/assign @davidkarlsen

Seems like @jackzampolin is the only owner of the chart but can't be assigned to the PR

/ok-to-test

/test pull-charts-e2e

/lgtm


[@react-spectrum/icon] peer dependencies

add @adobe/react-spectrum as a peer dependency

mark both @adobe/react-spectrum and @react-spectrum/provider as optional peer dependencies

Closes #1713
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue.
(n/a) Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[x] Filled out test instructions.
(n/a) Updated documentation (if it already exists for this component).
(n/a) Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Use a package manager that is strict about peer dependencies (e.g. PNPM)
Create a project that has @adobe/react-spectrum as a dependency
Add @react-spectrum/icon as another dependency
Confirm there are no peer dependency errors

🧢 Your Project:
Adobe / Adobe Research / internal project

closing, see discussion


Fix for excessively padded R and S

Fix for this rare exception when R or S starts with 00.

Thanks @MiniGlome ! idk how i forgot to give the credit to ya. I Had infact linked your github when i wrote about making a transaction in python.


Add comment

The intended way to leave a comment is supposed to be in a GitHub issue via utterance.  However, it has been broken (at least on my blog) for some time now.  Want to help me fix that?  Here is one option: https://shipit.dev/posts/from-utterances-to-giscus.html

Do you use Brave now? It has element blocking built in, which I also use to block certain Stack Overflow elements since you showed me how.

I do not.  I still use Google Chrome and uBlock origin.


#26 Polish translation

This translation is my little comittment to this nice project.

Awesome!! Thank you very much


UI Enhancement for BMI CALCULATOR

Which pre-existing JavaScript project will you be working on?
BMI Calculator
Describe your enhancement/improvement
The interface of the BMI calculator looks disarranged and unaligned.
Describe the solution you'd like:
I would like to restructure the interface to give the user a user-friendly experience.
Provide List details under what BMI values a person is overweight, underweight......
Anything you need to say to the Reviewers
No response
Add any other context or relevant screenshots about the enhancement here.

@swapnilsparsh please review the issue. I would like to work on this

i can make the UI better for better user intersection. assign this task to me

@swapnilsparsh, Hello! I'm new to this repository, and I'm eager to contribute to this project. Could you please assign me a task or suggest an area where I can get started? Thank you!

@swapnilsparsh, Hello! I'm new to this repository, and I'm eager to contribute to this project. Could you please assign me a task or suggest an area where I can get started? Thank you!

This issue is already resolved you can try on other repo of same repository

Hey I can improvise the UI and make it look professional ! Assign me to it


Solve #22 - Use format method

Solve #22
Description
An error occurred during the execution of certain use cases. The error was caused by improper usage of the format method within the validation of the use case class. In this PR, the validation has been removed, and the format method is now being utilized instead.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
613

Relevant Lines:
613

💛  - Coveralls


GEOMESA-895 Add HashAttributeProcess for styling by any attribute

Added a HashAttributeProcess and a HashAttributeColorProcess
Takes an attribute name from the environment params and hashes modulo
a configurable param to an integer.  Can be used to select a color
per attribute
Added a Point2Point process that creates line strings via a join on
an attribute specified by the caller

Signed-off-by: Anthony Fox<EMAIL_ADDRESS>

making two tweaks and merging.

merged as<PHONE_NUMBER>3ad6781ee8e114628a80fc4c234273


Can limit the display items' count?

Can limit the display items' count?

@luozhanming what do you mean?
You can use layoutManager.setMaxVisibleItems(NUMBER) to control how many items are visible on each side. The default value is 2, so only 2 additional items (exclude the center one) on each side will be visible.


Retrain helen dataset

from #84

Also I was wondering how often I have to retrain this dataset. Does it get updates or is it a one time train dataset.

I have questions.

What does it mean 'retrain'?
What does it mean 'updates'?

I guess you need to resume or train additinal image for existing model. Is it correct?
If so, answer is NO.
Because shape_predictor_trainer does not provide resume function unlike dnn trainer class.
It is limitation of dlib.

hi, yeah I mean in order to improve the model, the detection of faces and facial landmarks. It needs updates / retraining to improve.
Despite the limitation of Dlib do we have to worry about an outdated Helen model. And if so should we look more to applications dat use machine learning to detect faces.


[Storage] Fix api-extractor related issues

Fixed ae-forgotten-export warnings by exporting those types
Changed to pack the rolled-up typing file from api-extractor output

Resolves #3513

/azp run js - storage-blob - tests


Break scale option

I was wondering whether it would be possible to enhance d3 scales with "break scale" option in a generic way. It's a very useful option when you have to draw Y axis at zero, but all the numbers are very high and the difference between them is visually close to zero.
Is there a way to make such concept generic and build it into library, without making chart-specific hacks? When a value is inside the "break scale" range then it just shouldn't be plotted.
As an example of "break scale" effect, you can see http://stackoverflow.com/questions/20249054/nvd3-js-d3-js-scale-break  ,the "wavey" effect on Y axis in the chart in the answer.

In D3, a scale is a mathematical transform -- you're thinking of an axis. There might be a good way to implement this with polylinear scales, but it's going to involve some rooting through the axis source and understanding SVG paths. Value plotting is completely independent of axis drawing; you'd have to filter your data to the correct range. It would be nice to include this in D3 but you may have better luck with one of the charting libraries built on top of it, like C3 or NVD3.

I was thinking along the lines that for a scale, you could define one or more ranges were the value is in the "break scale" range. This can still remain a mathematical transform.
What I'd like to achieve is that automatic tick plotting would take break scale definition into consideration. Furthermore, returning a value from scale function when result is in break scale should perhaps return a special type of value, so that my code could recognize that a point is in the break scale range and decide not to plot it.
I'm yet to create a proof of concept for that, perhaps once I implement it outside D3, then I'll have a more precise suggestion on how could D3 help in creating such visualisations. I'd say that the ability to define an "abyss" in the data range definition should be generic enough for many use cases.

Why don't you take this to the mailing list and we can discuss further?

@mgold @voltcode
Should this still be left open?  What happened in the forum?  Should any other notes be put on this issue?  Just trying to lower the number of open issues.  If it should be open, leave it open, just leave a note or something.

I'm not the package maintainer but would support closing.

The d3fc-discontinuous-scale component adapts any other scale (for example a d3 time scale) adding the concept of discontinuities.
These discontinuities are determined via a 'discontinuity provider', for example, here is a linear scale with a 'break' between 50-75:
var scale = fc.scaleDiscontinuous(d3.scaleLinear())
    .discontinuityProvider(discontinuityRange([50, 75]))
    .domain([0, 100])
    .range([0, 550]);

var axis = d3.axisBottom()
    .scale(scale);

It also has some built in discontinuity providers, for example the discontinuitySkipWeekends allows you to skip weekends.
Here's an example:
const skipWeekendScale = fc.scaleDiscontinuous(d3.scaleTime())
      .discontinuityProvider(fc.discontinuitySkipWeekends());

And here's a complete demo: https://bl.ocks.org/ColinEberhardt/0a5cc7ca6c256dcd6ef1e2e7ffa468d4

It seems to me that this demo has some problems with the labels. Look at the values before and after clicking the checkbox. The ticks moved but the labels didn't change so I guess the values went wrong.

well spotted @Loksly - I'll investigate

Just FYI this bug has been fixed (some confusion around when the weekend starts / ends, 00:00:00 vs. 23:59:59!). Anyhow, the example now works correctly.
Thanks @Loksly for spotting and highlighting this issue.


Include legacy.js in the list of files to publish

This file is needed by browser.js

LGTM 🚀

LGTM 🤘 🚀

😴 ?

LGTM :eyeglasses:

Please guys :-)

Please merge this soon. Its breaking out builds.
LGTM. 👍

🙌


[Document] Fix some typo in alter table document

Proposed changes
Fix some typos in document that confusing users.
Types of changes
What types of changes does your code introduce to Doris?

[x] Documentation Update (if none of the other choices apply)

LGTM


UserDefinedFunctionProvider Obsolete

The UserDefinedFunctionProvider.Invoke is obsolete, should be updated to CosmosLinq.InvokeUserDefinedFunction as per this PR - https://github.com/Azure/azure-cosmos-dotnet-v3/pull/2206
Also, documentation on how to invoke user defined functions from Linq is non-existent, had to really hunt for it, I only figured it out by finding this PR.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7af26f57-f473-916a-bd4d-0918ef9eefcd
Version Independent ID: b553182a-4d34-96d6-219e-1abbd031c642
Content: LINQ to SQL translation in Azure Cosmos DB
Content Source: articles/cosmos-db/sql-query-linq-to-sql.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @timsander1
Microsoft Alias: tisande

@danielgerlag Thanks for your feedback! We will investigate and update as appropriate.

@danielgerlag thank you for reporting, I fixed it in the above PR. Changes will be live tomorrow.
We will close this issue now.
#please-close


Documentation quality edit

Applied first round of edits to Documentation Quality capability.

It looks like you branched off of an old version of main. I recently made changes to this capability page that covers some of the same scope you covered. I don't have time to fix this now, but I'll give it a go early next week.

Shoot. I'm so sorry. I need to review the start of my process. Here's what I've been doing:


Fix Windows Build guide.

Minor update that fixes the build process on Windows.

Actually, we need to ensure that the path is setup properly because the tests depend on it.  Please update the cmd template.


Can I have few zipkin-servers(nodes) that will receive and save all data to one storage(elasticSearch) without loses? If yes, what settings should I do?

What kind of issue is this?

[x] Question. This issue tracker is not the place for questions. If you want to ask how to do
something, or to understand why something isn't working the way you expect it to, use Gitter
or Stack Overflow. https://gitter.im/openzipkin/zipkin https://stackoverflow.com/questions/tagged/zipkin

[ ] Bug report. If you’ve found a bug, spend the time to write a failing test. Bugs with tests
get fixed and stay fixed. If you have a solution in mind, skip raising an issue and open a
pull request instead.

[ ] Feature Request. First, look at existing issues to see if the feature has been requested
before. If you don't find anything, tell us what problem you’re trying to solve. Often a
solution already exists! Don’t send pull requests to implement new features without first
getting our support. Sometimes we leave features out on purpose to keep the project small.

If yes, what settings I should do?

P.S. I've build two zipkins-servers.
Steps for first one:

cloned project
execute command "./mvnw -DskipTests --also-make -pl zipkin-server clean install"
execute command java -jar ./zipkin-server/target/zipkin-server-*exec.jar

Steps for second was the same exept of changing server port variable to  "port: ${QUERY_PORT:9410}" before buildeng the executable .jar.
So, two servers are running. I run two ui: first with port http://localhost:9411 and second with http://localhost:9410. Ui with port 9411 shows the information about spans, second not.

There is no shared state between servers. You want to point them at the
same elasticsearch service. Zipkin does not do any application layer
replication and is a stateless service. You can check into what
elasticsearch has though.

In addition to Adrian's comment, you do not need to build Zipkin Server yourself. You can use the pre-built package we provide as a JAR or Docker image, mentioned in the Quick Start: https://github.com/openzipkin/zipkin/tree/master/zipkin-server#quick-start
You can configure it to connect to Elasticsearch as mentioned in the documentation: https://github.com/openzipkin/zipkin/tree/master/zipkin-server#elasticsearch-storage
Come chat with us on Gitter if you have additional questions: https://gitter.im/openzipkin/zipkin


ci: add manual trigger to bump the versions accordingly

Stack from ghstack (oldest at bottom):

-> #90
#89
#88
#87
#86

This GH Actions workflow uses the previously created script to bump the versions automatically. The workflow can be triggered manually as a workflow_dispatch, and you just have to give it the input of wanting to do a patch release, a minor release, or a major release. It then bumps to the appropriate release version, commits it and tags it. Afterwards, it automatically bumps the version to the next snapshot version.
As the new release version is tagged, an release can be created when checking out this tag.

Please just review the PR and DO NOT merge it!


Validate the TLD, matching it with real and accepted TLDs

Validating with a regex is great... but it's not reliable. It says that<EMAIL_ADDRESS>is a valid e-mail :-1:

Link to the "The Public Suffix List":
https://github.com/publicsuffix/list/blob/master/public_suffix_list.dat

With the large amount of gTLD's being added each year, it seems highly unlikely that this is feasible as it would be difficult to maintain correctly.

Yes... but we can read the whole file @EsteveAguilera attatched, and update it when necessary. It seems simple to parse.

Maybe using the list within a git submodule is the best option here

Having that file on a GitHub repo could be a great idea. I like it a lot!
By the way, as author of the idea, feel free to create it. We'll star it for sure, and hopefully use it as a submodule! :·)

I have created a branch in my fork with this implemented but it will not build at present despite passing all tests in my IDE. I have not worked with a non-Android gradle based project before, so am not sure what I have done wrong. @rocboronat could you potentially email me to discuss this?

Of course! Here we go!

Hi @ed-george ! Just merged your development to our develop branch :·) THANK YOU!
Next step: validate the TLD using SuffixUtils.isValidSuffix()

Glad I could help! Fingers crossed I will get a bit spare time to look into doing some more sometime

Released at 2.0.0
Thanks @ed-george for your work! :·)

My pleasure - Will take a look at the code base again when I have some downtime


Bug 2183177: [release-4.13] enable multiclusterservice on storagecluster

When requested, enable multiclusterservice on StorageCluster in all the ManagedClusters referenced by MirrorPeer. It depends on Submariner resource to provide ClusterID used for network connection.

/lgtm


Build failure: system76-power

Steps To Reproduce
Steps to reproduce the behavior:

Add the following to the configuration.nix
boot.kernelModules = [ "system76_acpi" "system76_io" "k10temp" ];
hardware.enableAllFirmware = true;
services.power-profiles-daemon.enable = false;
hardware.system76.enableAll = true;

Rebuild

Build log
warning: The interpretation of store paths arguments ending in `.drv` recently changed. If this command is now failing try again with '/nix/store/6ang6g3hkygpymgz6kggl3bvamxvyh17-system76-power-1.1.23.drv^*'
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/n9sfla7fskrba6gg4dma3lm44n9j7ylm-source
source root is source
Executing cargoSetupPostUnpackHook
unpacking source archive /nix/store/h3z8z705cn9ly3cysjll22yr0xq8gz2a-system76-power-1.1.23-vendor.tar.gz
Finished cargoSetupPostUnpackHook
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Executing cargoSetupPostPatchHook
Validating consistency between /build/source/Cargo.lock and /build/system76-power-1.1.23-vendor.tar.gz/Cargo.lock
Finished cargoSetupPostPatchHook
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Executing cargoBuildHook
cargoBuildHook flags: -j 12 --target x86_64-unknown-linux-gnu --offline --profile release
error: failed to get `sysfs-class` as a dependency of package `system76-power v1.1.23 (/build/source)`

Caused by:
  failed to load source for dependency `sysfs-class`

Caused by:
  Unable to update https://github.com/pop-os/sysfs-class#ab63e7f6

Caused by:
  can't checkout from 'https://github.com/pop-os/sysfs-class': you are in the offline mode (--offline)

Additional context
This is on the unstable channel and the package has no maintainers
Notify maintainers
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.54, NixOS, 24.11 (Vicuna), 24.11.20241009.5633bcf`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.8`
 - channels(root): `"home-manager, hyprland, nixos"`
 - nixpkgs: `/nix/store/60sn02zhawl3kwn0r515zff3h6hg6ydz-source`

Add a :+1: reaction to issues you find important.

Duplicate of #349872


non-overlapping cast error should suggest casting to the narrowest possible type instead of unknown

Suggestion

🔍 Search Terms
overlap cast error unknown conversion

List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily and help provide feedback.
✅ Viability Checklist

My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
given the following three types: A, B extends A and C extends A, this error message could be improved if instead it suggested the narrowest common ancestor type instead of unknown
before:

Conversion of type 'B' to type 'C' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

after:

Conversion of type 'B' to type 'C' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'A' first.

📃 Motivating Example
interface A {
    a: number
}

interface B extends A {
    b: number
}

interface C extends A {
    c: number
}

interface D {
    d: number
}

declare const foo: B

// Conversion of type 'B' to type 'C' may be a mistake because neither type sufficiently overlaps with the other.
//  If this was intentional, convert the expression to 'unknown' first.
foo as C

//when using unknown, it's easier to accidentally cast to a completely unrelated type:
foo as unknown as C
foo as unknown as D //no error

//when using A, you get an error if you do that:
foo as A as C
foo as A as D //error

💻 Use Cases

makes casting a little bit safer
helps users learn the casting rules more easily

when i was new to typescript i had no idea why casting to unknown fixed these overlapping type errors, and i think many users probably feel the same and just blindly follow the suggestion in the error message without having a clear understanding of what it means

makes casting a little bit safer

If the cast is between non-overlapping ones, isn't it already straight unsafe?

Well, I thought it works more like this:

I'm trying to assert B to C
TS tells me that B and C are incompatible
Oops, something's wrong
If I want to force-cast (because I know what I'm doing), just do as unknown to shut tsc
In the future, if someone's refactoring the code, this as unknown stands out as conspicuous bad smell and they would not try to change C to D without getting rid of the as unknown first

Assuming that tsc actually does keep an ORM-like structure somehow and is able to emit this hint, doesn't it at best make explicit bad smell more implicit? With a downward assertion you are already going out into the wild.

I guess the theory (which I’m not sure I agree with) is that side-casting, e.g. from one subtype to another where there’s a common supertype, is safer than casting to a completely unrelated type, but casting through unknown allows both equally.

This isn't a bad idea (this is what I do in my own code when I need to sidecast) but I don't particularly want to take on the large amount of extra code we'd have to write to correctly find the least common ancestor (or have people complaining that the ancestor we did pick wasn't "good enough").

Reference link: diagnostic message ts(2352) (diagnosticMessages.json#L1815-L1817)


Some thoughts regarding the application

For this to really take off the whole nation needs to be on the app. What's the incentive to be on the app as opposed to just watching the news and staying clear of pockets of high infection. What's the plan to get people on board at scale?
Who's the target audience? Essential workers in sectors such as healthcare, transportation etc? Most people are in self-quarantine right now and WFH so they won't be going outside much.
How specific are we getting when it comes to marking locations on the map as to an infection location? Are we marking neighborhoods? Individual homes? The concern is the privacy aspect, because if you're marking individual homes then it's easy to figure out who lives there, especially if you live on the same street.

Hey hmalik88,
This app has two value propositions

For Users: Aggregate, credible up-to-date information translated into Spanish or Arabic, as well as a one-stop shop for English speakers to find everything they need on prevention (air, surface, etc.) spread (infections reporting and connecting to screening apps)

For Public Health Officials: Aggregate, macro-view of patients PRIOR to initial screening, who are engaged and reporting symptoms

Target audience - Users seeking out information, primarily ages 25-45. Especially those who would like to self-report their symptoms in an effort to engage proactively in their own health monitoring
Marketing Location - I suggest at the city level, but defer to our team-members with a data anonymization background. Privacy concerns are less pressing since this is publicly reported data, and self reported data.

Great points, Nathan! I'm just commenting as a remind to edit this comment with a few additional points / updates tomorrow. Mainly, after a call with a pulmonary doctor this evening, that we decided targeting already-overwhelmed public health officials who are unlikely to trust the information we collect until we reach scale and are HIPPA-compliant is out of scope.
Will comment with more details tomorrow - but all great points! Just want to add my two cents as well :)

For this to really take off the whole nation needs to be on the app. What's the incentive to be on the app as opposed to just watching the news and staying clear of pockets of high infection. What's the plan to get people on board at scale?

The app will be a clear, no nonsense decision tree of guidelines that each user clicks through. The plan is to disseminate through social media channels and get public health officials on board to include in their suggested apps and newsletters to our targeted population.

Who's the target audience? Essential workers in sectors such as healthcare, transportation etc? Most people are in self-quarantine right now and WFH so they won't be going outside much.
-See https://docs.google.com/document/d/15i7vBDCFqGHCf3B-D9Miw0_3I1M6_rn3v4fzA1PAAK4/edit#heading=h.o2dkx9wkrwkg. he audience will be those less likely to abide by social distancing and more likely to be caregivers for at risk populations with comorbidities and immunocompromised systems.
How specific are we getting when it comes to marking locations on the map as to an infection location? Are we marking neighborhoods? Individual homes? The concern is the privacy aspect, because if you're marking individual homes then it's easy to figure out who lives there, especially if you live on the same street.
-it should be neighborhoods - zipcodes. And we ca avoid showing counts and instead show probabilities of our user characteristics to obscure individual identifiability.
Thoughts?

@awu556 @tesla809 or anyone else willing - would you want to consolidate these notes into another document we have and then close this issue? Just to clear out our backlog.

Sure! I'll do it right now in a google doc

Alright, all set. Feel free to close or delete the issue


KeyError

I am in the Usage Tier 1 for OpenAPI and I correctly input my OpenAPI key via the export command in the instructions, however it still gives me an error when I test the connection

When I try to execute pentestgtp, I can get to the part where I input something, like 'discuss', but it then immediately errors out with a KeyError:

Any help would be appreciated!

May I confirm if you're using the latest version? How did you install the tool?

I tried both the 0.9 release and the latest branch build from March 29th

I have the same problem, is there any solution?
Thanks for any help!

I have the same problem, is there any solution?
Thanks for any help!

I haven't had any luck yet

A full reinstall of Python 3.10.9 and pentestgpt seemed to have done the trick. I'm not sure what exactly went wrong, but fully reinstalling both seemed to have fixed the issue.


Fix broken links in /docs/examples/graphmd

Currently published snapshot is broken due to relative paths or 404 due to third party website reorganization:

http://ipfs.io/ipfs/QmYNQJoKGNHTpPxCBPh9KkDpaExgd2duMa3aF6ytMpHdao/docs/examples/example-viewer/example#../graphmd/README.md

@lidel I’ve tried to address this over in ipfs/docs#115. When that merges, you should probably close this.


fix: add cache for orchestrator build to reduce the re-build time

Description
issue
composer will do orchestrator build every time. some big bot may take 15min. It is a long time to wait even the lu files don't update.
fix
Add the cache of LabelResolvers for orchestrator build. the build worker will re-use the resolvers and reduce the re-training time.
In my local test, the first time will use 15min and the second only use 800ms.

Task Item
#minor

Screenshots

Coverage increased (+0.02%) to 52.935% when pulling 74059a4c3435862f77e61e37240ba5aea0b0fa7f on lei9444:retraining into 8dc322d37835e588974a43adccb0fea7ea0f2fa1 on microsoft:main.


Remove translated languages from all but English index

Let me get your thoughts @pragmaticivan
This closes #270

👍 🍻

Thanks @pragmaticivan


Support AArch64/ARM64 architecture

This is not an issue in general for MacOS (OS covers compatibility issues), but that's an issue for linux systems. Probably for windows it also isn't huge issue (has to be checked), but for linux we should compile not only x86, but also ARM64.
Simplest solution could be add into our matrix (on github scenario) ubuntu for ARM64, but github supports only x86. Well we have to use cross-comiling features for rust and electron (both support it as well).

postponed until direct request from users


My switch has an unknown topology

I have one error in Network/Switch - "Switch "switch0" has an unknown topology - the VLAN settings might not be accurate."
I think the problem is here - https://github.com/openwrt/luci/commit/8cd6e4efe8351735f93f4c40882ac0cc9c773751
Router DLink DIR-860L B1
kernel 3.18.36
Powered by LuCI Master (git-16.274.24536-185e4c1) / OpenWrt Chaos Calmer 15.05.1 r49389
This is my board.json -
{
        "network": {
                "lan": {
                        "ifname": "eth0",
                        "create_vlan": true,
                        "macaddr": "72:41:81:7b:e2:51"
                },
                "wan": {
                        "ifname": "eth0",
                        "create_vlan": true,
                        "macaddr": "72:41:81:7b:e2:52"
                }
        },
        "switch": {
                "switch0": {
                        "enable": true,
                        "reset": true,
                        "vlans": {
                                "lan": [
                                        1,
                                        2,
                                        3,
                                        4
                                ],
                                "wan": [
                                        0
                                ]
                        },
                        "cpu_port": 6
                }
        }
}

CC with trunk LuCI is not supported.


LCC hung on aws s3 cp step

Studio times out when trying to launch, checked cloudwatch logs and the lifecycle configuration hangs on the aws s3 copy step for auto shutdown from s3 bucket.
aws s3 cp s3://sagemaker-auto-shutdown-us-east-1-REDACTED/sagemaker_studio_autoshutdown-0.1.5.tar.gz .auto-shutdown/extension.tar.gz | + aws s3 cp s3://sagemaker-auto-shutdown-us-east-1-REDACTED/sagemaker_studio_autoshutdown-0.1.5.tar.gz .auto-shutdown/extension.tar.gz

VPC flow logs showing rejects to confirm as well.

Found the solution here security groups need to be added to default_user_settings not just at the domain settings level


Add property to show specific year item number for year picker - Feature #2331

Feature for #2331 I've noticed that this behavior wasn't implemented.
Instead of implementing NxM year values grid, I've just replaced 'magic numbers' for year periods to provided property. It is easy to show NxM year values grid using this property and changing CSS.
I've added property yearItemNumber to show specific number of year value items. Also, I've refactored code using new internal constant (=12 by default) for default value of number of years, instead of previously used 'magic numbers'.
Corresponding behavior has been covered with tests.
Example provided.

You forgot to update the types y have an issue with the attribute yearItemNumber and typescript.

same here

Me too


Feat: Add Our Contributor Page.

Describe the feature
Add Our Contributor Page.
Show Image , Total Contribution ,Github Profile In Card.
Add Link Of that page in Quick Links In Footer.

Add ScreenShots
NA
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Suchitra-Sahoo Please assign me this task !
Thank You !


Initial Climate Data Model standard (subset)

This epic captures the timeframe to the initial version of the WMO Climate Data Model (CDM) storage standard being available.
Due to the majority of this work occurring outside of the OpenCDMS project, this epic may only contain a single issue (to create SQLAlchemy models for CDM) - however, the epic will also be a dependency required by other issues.
Or multiple issues, undertaken in OpenCDMS RI

[ ] Station
[ ] Subset of metadata

Approach TBD

Toolchain to create SQL DDL, then we inspect with automated tools to make Python object models
Write models directly in Python (requires knowledge of SQLAlchemy)

Test data required

[ ] observations, long time period (30 years+) for one station
[ ] observations, one month for multiple stations in region
[ ] discovery metadata
[ ] station metadata for those included in observations (from OSCAR Surface)
[ ] provenance metadata


Close pull request

User story:
As a developer,
When I close a pull request,
I want Autobump to ignore the bump and not notify me again about this update until a new version of the same dependency is available.

BitBucket integration in seperate ticket.


allow to use IAM user arn or IAM role arn.

The amazon sp-api integration allows to use IAM user entity or IAM role entity. amazon documentation
if we use a user based arn we need to use another function from the boto3 client to get the required credentials role
This will allow to integrate with apps configured with user arn entity in the amazon seller central app.

I'm not sure if I get you wrong, but apps that use the user simply have to omit the role_arn parameter.
See the docs: https://sp-api-docs.saleweaver.com/from_code/

mmm 🤔 , have you tested that? I can see in the code base that the role_arn is a required parameter, so I think you can't leave it in blank.
you can check that I fixed this same issue in the airbyte integration
https://github.com/airbytehq/airbyte/pull/12523

you cannot call the assume_role function on the sts client using a user based role because you get this error:
{ClientError}An error occurred (InvalidClientTokenId) when calling the AssumeRole operation: The security token included in the request is invalid.
instead you need to use the function get_session_token

assume_role isn't called when no role_arm is set. I'm sure that it works as it is. Please try it.

Your’re right. it is not necessary to call the sts client session when you have a user based role. Today I learned a new thing. Thanks 🙏

Thanks anyways for the contribution!


KeyError: wr.athena.read_sql_query()

awswrangler version: 1.0.0
wr.athena.read_sql_query() raises a KeyError when I tried to execute following:
sample.py
import awswrangler as wr

wr.athena.read_sql_query(
  "select * from companies limit 5",
  database="foo",   # dummy value
  workgroup="bar",  # dummy value
)

traceback
I do not encrypt in Amazon S3 so EncryptionConfiguration is seemed to be not set a value.
Traceback (most recent call last):
  File "sample.py", line 6, in <module>
    workgroup="bar",
  File "/home/nagomiso/develop/.venv/lib/python3.7/site-packages/awswrangler/athena.py", line 408, in read_sql_query
    wg_s3_output, _, _ = _ensure_workgroup(session=session, workgroup=workgroup)
  File "/home/nagomiso/develop/.venv/lib/python3.7/site-packages/awswrangler/athena.py", line 546, in _ensure_workgroup
    wg_encryption: Optional[str] = config["EncryptionConfiguration"].get("EncryptionOption")
KeyError: 'EncryptionConfiguration'

other library versions
boto3==1.12.39
botocore==1.15.39

Thank you @nagomiso! We will fix it ASAP.

@nagomiso fix available on version 1.0.1. Thanks!


fix(android): fix footer position bug

Fixes #47
v0.12 included a "test" code that caused regression issue. The code is suppose to fix orientation bug which I will handle in a separate PR.

:rocket: This pull request is included in v0.12.2. See Release 0.12.2 for release notes.


feat: transaction-scoped dataloaders

Why
An interesting idea from @ide: within a transaction, subsequent reads should be able to be cached locally as long as the local cache is kept consistent (not in the cache adapter though).
How
Keep a separate dataloader per-transaction that is invalidated synchronously.
Test Plan
Not tested yet.

Abandoning for now. While this would be a small perf increase, ~98% of loads in the EAS use case are non-transactional so it would be minimal.


1103 validation for form fields in UI

Description
Input validation for contribute/create page.
The type for each input field is specified.
Input types used are "text", "tel", "url" and "email".
Fixes #1103
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[ ] Immediately
[x] Within a week
[ ] When possible

Type of changes
Please select a relevant option:

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:
Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[x] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Merging to develop


Added OneTable™ support

See alexdebrie.com/posts/dynamodb-single-table/ for more information on how a single DynamoDB table can run an application.
Added support, examples, tests & documentation 🚀

Closes #12.


Update the manual with newer screenshots and recent changes.

This includes changes to reflect what happened in recent months to the Double Sided flag and to the Occlusion map handling, as well as updated screenshots due to node input changes made prior to the release of Blender 2.80 RC 1.

https://developer.blender.org/D5261

Thanks @donmccurdy.  I finally bit the bullet and got the whole Blender Manual source & local build system setup on my machine at home, so I'm good there.
Let's not merge this until the Blender Manual admins merge on their side.  I've found it's much easier to resolve merge conflicts here in git (they're using svn).

It's committed!  https://developer.blender.org/rBM5545


Update README.md

Added a way to work with SonataAdminBundle if needed extending it's form twig template and also fixed README.md formatting at "The KeyValueCollection" section.

I would recommend to merge PR. Took me ages to find the solution when using sonata admin

done


More flexibility when it comes to boto auth

Considering that the application may run inside a VPC without having to auth at all in order to use aws resources,
or that the user may have MFA or AWS SSO enabled and thus, next to key and secret, the session token argument must also be provided;
I believe the aws_access_key and aws_secret_key should NOT be required arguments, but only passed to boto if provided, allowing boto session instance to be created without these arguments if needed.
P.S. i'm not sure how to run the tests locally, when i run pytest i just get a
=============================================================== 87 failed, 22 passed, 3 warnings in 57.71s ===============================================================
all errors being AuthorizationErrors or MissingCredentials even though i exported them as env vars beforehand,
similar to this open discussion https://github.com/saleweaver/python-amazon-sp-api/discussions/485

Hi @saleweaver , any thoughts on this topic?

Hey @nicuzs,
sorry, I was away for some days.
I was looking into this before as well, do you want the changes to make it run better on AWS, or to use other credentials in general?

Hey @nicuzs,
sorry, I was away for some days.
I was looking into this before as well, do you want the changes to make it run better on AWS, or to use other credentials in general?

Hi, sure, no problem, thanks for getting back to me.
I want to make these changes mainly because my app runs in a VPC, so for any other previous interactions i had with other aws resources, I didn't use authentication by allowing boto to connect without providing any.
Also, in my dev environment,(because of MFA) I'm forced to use a set of temporary credentials, meaning next to aws aws_access_key_id and aws_secret_access_key, i MUST also provide the aws_session_token, otherwise the authentication is not successful, but this is currently not supported by python-amazon-sp-api either.
So for both my use cases, the  current auth approach used in python-amazon-sp-api makes it unusable so I had to fork it and install the app directly from the git fork repo in order to bypass this limitation.
Also, conceptually speaking, boto provides by default a few authentication methods:

no auth
auth by providing aws_access_key_id&aws_secret_access_key as kwargs
auth by providing aws_access_key_id&aws_secret_access_key & aws_session_token as kwargs
auth by providing AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY as environment variables
auth by providing AWS_ACCESS_KEY_ID & AWS_SECRET_ACCESS_KEY & AWS_SESSION_TOKEN as environment variables
maybe other options which I'm not aware of, or which will be added in the future

while python-amazon-sp-api is sort of a wrapper on top of boto3( or more accurately is a library using boto3 just to connect to sts or a couple other aws resources), why would it pick just the 2.nd auth method? and make all other unsupported?
Looking forward to your opinion, thanks !

@saleweaver Any reason for closing this ?

@saleweaver more details about closing this please? was this already merged into master from other source ?


fixing Issue #1893 - removing hardcoded color border from

In this case, it'd be more appropriate to use a new variable I think:
@hrBorderColor: @grayLighter;

We use @grayLighter and other variables in so many places that it might have unintended effects when customizing.

Manually addressed in 2.0.1-wip.


Peer to Peer code review

Well done on your Leaderboard app exercise. Your code looks clean and your use of gitflow is fantastic!
However you can try to improve on the UI especially your submit button. Maybe you can try giving it a dark color for easy visibility.

well done @GhostEsso keep doing good work. Happy coding


dict_array and dict_map container classes added.

Depends on https://github.com/tonlabs/TON-Compiler/pull/117

And btw, why not dict_set and dict_map?


Inherit area_fraction_top, center_time and median_time from peaklets

Before you submit this PR: make sure to put all operations-related information in a wiki-note, a PR should be about code and is publicly accessible
What does the code in this PR do / what does it improve?
Depends on https://github.com/AxFoundation/strax/pull/941
Can you briefly describe how it works?
Can you give a minimal working example (or illustrate with a figure)?
Please include the following if applicable:

[ ] Update the docstring(s)
[ ] Update the documentation
[ ] Tests to check the (new) code is working as desired.
[ ] Does it solve one of the open issues on github?

Notes on testing

Until the automated tests pass, please mark the PR as a draft.
On the XENONnT fork we test with database access, on private forks there is no database access for security considerations.

All italic comments can be removed from this template.

coverage: 89.427% (-0.05%) from 89.479%
when pulling fb17f924e11545a68ad007a8627a5f5fcd594a85 on add_center_time_median_peaks
into 4d2c89e906e3bcd46c9702ff6700675ddf455bf3 on master.


Added an option to truncate the title after a specified number of cha…

…racters
Needed for Dilps project

Hi Luca !
Glad to see you here contributing to this project.
Unfortunately, you couldn't have known, but your PR conflicts with two commits (one of them was still on my local repo when you submitted) : https://github.com/Ecodev/natural-gallery-js/commit/bc0d9f1c2bc3e480329e4502e9cda494b44e0f74 and https://github.com/Ecodev/natural-gallery-js/commit/5b8fb7a36a39a49f662189991f79b4d820619efb.
Allowing line breaks has been implemented due to this request : https://support.ecodev.ch/issues/5543. That means we can now have html in title and a truncation can interrupt the tag and break the page.
Due to the infinite diversity of tasks each developper would want to apply on the title, the gallery cannot provide tools for them all because they are all too much specific. In general the task you want to perform should be implemented on the controller (in ListComponent.formatImages https://github.com/Ecodev/dilps/blob/master/client/app/list/list.component.ts#L223) where the title is forged with artists.
The gallery can provide some tools, but they have to provide an additional value related to the gallery features. A truncation of e.g 50 characters that applied unconditionally on each image is not relevant on a gallery where each image has a different width. A typical truncate tool the gallery could provide would be something like : a dynamic truncate feature that considers the width of the images to prevent the label to exceed two lines.


SyntaxError: Unexpected token

Environment
I am facing an issue while trying to upload the source map on Sentry.. I'm doing this with Manually Setup with Webpack and I am using Sentry's recommended plugin "@sentry/webpack-plugin" but the issue is when I'm loading/importing this plugin in Webpack config I'm getting the below error.
node: 14,
webpack: 4.44.2,
@sentry/react: 7.52.1,
@sentry/webpack-plugin: 2.5.0,
react and typescript
Steps to Reproduce

installation: npm install @sentry/webpack-plugin --save-dev
import/require: const { sentryWebpackPlugin } = require('@sentry/webpack-plugin');
While running "npm start" or "npm build" getting an error

const { sentryWebpackPlugin } = require('@sentry/webpack-plugin'); // if I remove this line it's working fine.

node_modules/path-scurry/dist/cjs/index.js:363
    #resolveParts(dirParts) {
                 ^
SyntaxError: Unexpected token '('

Expected Result
Serve project successfully
Actual Result
Getting Error.
const { sentryWebpackPlugin } = require('@sentry/webpack-plugin'); // if I remove this line it's working fine.
node_modules/path-scurry/dist/cjs/index.js:363
#resolveParts(dirParts) {
^
SyntaxError: Unexpected token '('

Sure, I will check and update here.

Updated webpack to version 4.46.0 and also added a babel plugin for private class properties @babel/plugin-transform-private-methods but still getting the same error.. also checked private class methods support in node and the list shows it's supported from node 12 and I have node 14.

Here is the stack trace.