Fix: #11197 automatic backing-field for @ref

This change makes @ref define a field for you by default. We didn't do
this originally because we weren't sure if the compiler generating a
field would always be what you want, and more importantly,
we didn't have the expressiveness to add an opt-out.
Now that we have directive attributes, it's easy to create an opt-out
for the field generation. The special thing about it is that where
you opt-out has to be static. For this reason the @ref:suppressField
attribute cannot be used with a value, you either have the flag or not.
Additionally, we don't support automatic field generation for
generics, because usually we can't write the field name. If we
want to in the future could make this work when the generic
type arguments are specified. So in the case of generics,
you have to opt-out, and you will get a diagnostic
that tells you so.
Feedback welcome on the naming and style of this. I felt like @ref:suppressField made the most sense, but open to other options.

The design looks great. I like the API for suppressing it.
When this propagates to aspnetcore it will cause a bunch of compiler errors at first, won’t it? Is the plan to let the automation create a PR for it, then append a commit to that branch that fixes the clashing-field errors?

When this propagates to aspnetcore it will cause a bunch of compiler errors at first, won’t it? Is the plan to let the automation create a PR for it, then append a commit to that branch that fixes the clashing-field errors?

Yes, I'll have to babysit the build 😆 - I will know the pain that Ajay has known.


Recurring payments via a billing agreement ID (BAID) : Token expire

Hi,
i have followed the installation instructions and the Recurring payments via a billing agreement ID (BAID) instruction but on every recurring payment i get this message "This Express Checkout session has expired. Token value is no longer valid."
so there is any thing i'm missing or i have to do ?

Please use the mailing-list for implementation questions. See also https://github.com/killbill/killbill/blob/master/.github/CONTRIBUTING.md for reporting issues.


Update Set-FeatureConfiguration.md

@jiwei0722, I'm taking this PR out of Draft and merging the changes into the articles in the branch. You can make any future updates directly in the article.


Remove users

For various reasons, e.g. annual leave, these users are unable to rotate
their SSH key immediately (as mitigation against CVE-2016-0777).
Until they are able to rotate their keys, we may as well remove their
users (rather than have a public key of REPLACE ME).

Also, remove users that have left GOV.UK.

:+1: LGTM. Merge when ready.

puppet is now failing to run in Integration:
Jan 18 16:11:14 monitoring-1.management puppet-agent[17050]: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find class users::chrisroos for monitoring-1.management.integration.publishing.service.gov.uk on node monitoring-1.management.integration.publishing.service.gov.uk

Thanks @surminus, addressed in https://github.com/alphagov/govuk-puppet/pull/3958.


[JENKINS-64881] Bump dependencies to avoid PCT failure

See JENKINS-64881
This PR fixes a PCT failure (MsBuildBuilderTest#configRoundtrip) by updating HtmlUnit via updating the parent pom. We use the bom to better manage the dependencies.
In addition it improves the log printed in this method to know the root exception.
This also adds dependabot to the repository.

Optional reviewers: @rsandell @jtnord @olamy @bitwiseman @car-roll


Headline curl command has insecure redirect

The cited curl command to install Envoy has an insecure HTTP redirect.
curl -L https://getenvoy.io/cli

Currently redirects (HTTP 302) to http://www.getenvoy.io/cli which redirects (HTTP 301) to https://raw.githubusercontent.com/tetratelabs/getenvoy/master/godownloader.sh
$ curl -sD /dev/stdout https://getenvoy.io/cli -o /dev/null
HTTP/2 302
location: http://www.getenvoy.io/cli
date: Tue, 14 Jan 2020 18:33:04 GMT
content-type: text/html; charset=UTF-8
server: ghs
content-length: 223
x-xss-protection: 0
x-frame-options: SAMEORIGIN

Add www to your URL and it's OK, skipping the http://www.getenvoy.io... entirely.
$ curl -sD /dev/stdout https://www.getenvoy.io/cli -o /dev/null
HTTP/2 301
cache-control: public, max-age=0, must-revalidate
content-length: 93
content-type: text/plain; charset=utf-8
date: Tue, 14 Jan 2020 18:36:23 GMT
location: https://raw.githubusercontent.com/tetratelabs/getenvoy/master/godownloader.sh
age: 0
server: Netlify
x-nf-request-id: 0e857497-b232-46f9-8507-184285747421-3628950

I don't know when or how, but it seems fixed. please re-open if not and thanks for raising!
$ curl -sD /dev/stdout https://getenvoy.io/cli -o /dev/null
HTTP/2 301
cache-control: public, max-age=0, must-revalidate
content-length: 93
content-type: text/plain; charset=utf-8
date: Fri, 16 Apr 2021 02:27:26 GMT
age: 31690
server: Netlify
location: https://raw.githubusercontent.com/tetratelabs/getenvoy/master/godownloader.sh
x-nf-request-id: 918ec5b4-7a7e-4e88-ae79-12b6d8d64805-16990412


⚠ ClamAV has degraded performance

In 9f3d905, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 200 ms

Resolved: ClamAV performance has improved in 24ba35b after 5 minutes.


How to replace '_' characters by whitespaces?

This masks replaces missing numbers by '_' charactes. I whish it would be ' ' characters.
How to replace '_' characters by whitespaces?

https://github.com/text-mask/text-mask/blob/master/componentDocumentation.md#placeholderchar

any way to remove this placeholder chars so that the user can not enter text in between spaces? it makes the design confusing for the user.


[Bug Report] The display problem of the Select selector binding object

Element UI version
1.3.7
OS/Browsers version
Win10 / Chrome 58.0.3029.110 (64-bit)
Vue version
2.3.0
Reproduction Link
https://jsfiddle.net/9zbx1e6c/12/
Steps to reproduce
Run OK in jsfiddle,
In contrast, when the select selector binds String and Object
What is Expected?
When the select selector binds V-model to an object, the value in the object can be displayed normally,
Like binding String
Thanks in advance :)
What is actually happening?
When the select selector binds V-model to an object, the value in the object is not loaded

https://jsfiddle.net/9zbx1e6c/14/
When an object is bound to v-model, make sure it points to the same object as one of the options because { a: 1 } !== { a: 1 }.


Build front-end application into webserver container

Build the webapp into a Docker volume used by the webserver container. Write a Make target to control that process
See issue #43

@erikjasso right now the frontend is set up to use the create-react-app defaults (Webpack) to do builds and I don't see a need to change that in the future. You can do a build in that directory with the command npm run build and it looks like this:
mkw@M4600:~/Documents/repos/recordexpungPDX/recordexpungPDX/src/frontend$ npm run build

><EMAIL_ADDRESS>build /home/mkw/Documents/repos/recordexpungPDX/recordexpungPDX/src/frontend
> react-scripts-ts build

Creating an optimized production build...
Starting type checking and linting service...
Using 1 worker with 2048MB memory limit
(node:8496) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
Compiled successfully.

File sizes after gzip:

  34.18 KB  build/static/js/1.be79822f.chunk.js
  3.56 KB   build/static/js/main.7dcb98c8.chunk.js
  1.02 KB   build/static/css/main.60428d27.chunk.css
  763 B     build/static/js/runtime~main.229c360f.js

The project was built assuming it is hosted at the server root.
You can control this with the homepage field in your package.json.
For example, add this to build it for GitHub Pages:

  "homepage" : "http://myname.github.io/myapp",

The build folder is ready to be deployed.
You may serve it with a static server:

  npm install -g serve
  serve -s build

Find out more about deployment here:

  http://bit.ly/CRA-deploy

If we decide to use Hugh's server-rendered HTML (Flask, Jinja) code then we can close this issue since there will be no separate frontend app.

@maxkwallace I've never used Webpack. What does it do?

@erikjasso Webpack is a tool that's primarily used to transform Javascript code files on the filesystem (i.e. what we edit in a repo) into static assets, typically and most importantly, one big Javascript file that's the result of bundling together and minifying all the code you need.


Implement _geoBoundingBox filter

Pull Request
Related issue
Fixes #2761
What does this PR do?

Implements _geoBoundingBox((lat, lng), (lat, lng)) filter

PR checklist
Please check if your PR fulfills the following requirements:

[x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
[x] Have you read the contributing guidelines?
[x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@gmourier sorry, we took time to prioritize the review of your PR. Could you rebase it please?

bors try

Closed in favor of https://github.com/meilisearch/meilisearch/pull/3405


Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2

Signed-off-by: Nick Dimiduk<EMAIL_ADDRESS>

FYI @ZhaoBQ , looks like your patch applies well enough to branch-2. Can you confirm that it can be applied without modification -- the configs you manipulate in this branch don't need some different action for the next 2.x release, and that there are not other uses of addDeprecation on branch-2 that need to be corrected? Thanks for the contribution!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  3s
branch-2 passed

+1 :green_heart:
compile
10m 53s
branch-2 passed

+1 :green_heart:
checkstyle
2m 51s
branch-2 passed

+0 :ok:
refguide
4m 59s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
21m 52s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 13s
the patch passed

+1 :green_heart:
compile
14m 27s
the patch passed

+1 :green_heart:
javac
14m 27s
the patch passed

+1 :green_heart:
checkstyle
3m 24s
root: The patch generated 0 new + 58 unchanged - 3 fixed = 58 total (was 61)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+0 :ok:
refguide
5m 20s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
16m 34s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
19m 40s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

124m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3271

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml refguide

uname
Linux 6399b106467e 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 1bb16fea5b

Default Java
AdoptOpenJDK-1.8.0_282-b08

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
126 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 31s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 19s
branch-2 passed

+1 :green_heart:
compile
2m 53s
branch-2 passed

+1 :green_heart:
shadedjars
8m 36s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
5m  1s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m  9s
the patch passed

+1 :green_heart:
compile
3m 52s
the patch passed

-0 :warning:
javac
3m 52s
root generated 1 new + 33 unchanged - 1 fixed = 34 total (was 34)

+1 :green_heart:
shadedjars
9m 42s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
6m 10s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
184m 55s
root in the patch passed.

236m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3271

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a7ea992c4b5c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 1bb16fea5b

Default Java
AdoptOpenJDK-11.0.10+9

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/testReport/

Max. process+thread count
6025 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 46s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 35s
branch-2 passed

+1 :green_heart:
compile
2m 52s
branch-2 passed

+1 :green_heart:
shadedjars
7m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m  5s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 28s
the patch passed

+1 :green_heart:
compile
2m 42s
the patch passed

-0 :warning:
javac
2m 42s
root generated 1 new + 33 unchanged - 1 fixed = 34 total (was 34)

+1 :green_heart:
shadedjars
7m 45s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 20s
the patch passed

_ Other Tests _

-1 :x:
unit
330m 39s
root in the patch failed.

374m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3271

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 403c1020d25c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 1bb16fea5b

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/artifact/yetus-jdk8-hadoop2-check/output/diff-compile-javac-root.txt

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/testReport/

Max. process+thread count
4762 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
branch-2 passed

+1 :green_heart:
compile
8m 46s
branch-2 passed

+1 :green_heart:
checkstyle
2m  5s
branch-2 passed

+0 :ok:
refguide
3m 50s
branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
spotbugs
11m 38s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 19s
the patch passed

+1 :green_heart:
compile
8m 42s
the patch passed

+1 :green_heart:
javac
8m 42s
the patch passed

+1 :green_heart:
checkstyle
2m  4s
root: The patch generated 0 new + 58 unchanged - 3 fixed = 58 total (was 61)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+0 :ok:
refguide
3m 20s
patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.

+1 :green_heart:
hadoopcheck
11m 42s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
12m 25s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

82m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3271

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml refguide

uname
Linux 0c0699a94e8a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 1a8d3c3b6b

Default Java
AdoptOpenJDK-1.8.0_282-b08

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-general-check/output/branch-site/book.html

refguide
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-general-check/output/patch-site/book.html

Max. process+thread count
141 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 43s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 46s
branch-2 passed

+1 :green_heart:
compile
3m  9s
branch-2 passed

+1 :green_heart:
shadedjars
7m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 29s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 31s
the patch passed

+1 :green_heart:
compile
3m  7s
the patch passed

-0 :warning:
javac
3m  7s
root generated 1 new + 33 unchanged - 1 fixed = 34 total (was 34)

+1 :green_heart:
shadedjars
7m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
4m 24s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
240m 28s
root in the patch passed.

285m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3271

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 033a767c345b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 1a8d3c3b6b

Default Java
AdoptOpenJDK-11.0.10+9

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/testReport/

Max. process+thread count
4074 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m  0s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 33s
branch-2 passed

+1 :green_heart:
compile
2m  8s
branch-2 passed

+1 :green_heart:
shadedjars
5m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 29s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 15s
the patch passed

+1 :green_heart:
compile
2m 12s
the patch passed

-0 :warning:
javac
2m 12s
root generated 1 new + 33 unchanged - 1 fixed = 34 total (was 34)

+1 :green_heart:
shadedjars
5m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
3m 33s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
321m 17s
root in the patch passed.

359m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3271

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 477ccf1ae865 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 1a8d3c3b6b

Default Java
AdoptOpenJDK-1.8.0_282-b08

javac
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk8-hadoop2-check/output/diff-compile-javac-root.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/testReport/

Max. process+thread count
4662 (vs. ulimit of 12500)

modules
C: hbase-common hbase-server hbase-mapreduce . U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Error with calendar.date_search() and Google Calendar

I am using this library to fetch events of a meeting room calendar from Google Calendar.
When I try to search events by date I have the following error:
ERROR:caldav:Deviation from expectations found.  Please raise an issue at https://github.com/python-caldav/caldav/issues or reach out to<EMAIL_ADDRESS>include this error and the traceback and tell what server you are using
Traceback (most recent call last):
  File "[...]/__env__/lib/python3.11/site-packages/caldav/lib/error.py", line 28, in assert_
    assert condition
AssertionError
Traceback (most recent call last):
  File "[...]/./gcal.py", line 78, in <module>
    events = calendar.date_search(start=start_date, end=end_date)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]/__env__/lib/python3.11/site-packages/caldav/objects.py", line 907, in date_search
    objects = self.search(
              ^^^^^^^^^^^^
  File "[...]/__env__/lib/python3.11/site-packages/caldav/objects.py", line 1069, in search
    if any(key in component for key in recurrance_properties):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]/__env__/lib/python3.11/site-packages/caldav/objects.py", line 1069, in <genexpr>
    if any(key in component for key in recurrance_properties):
           ^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable

You will find a minimal example to reproduce this issue in the following article: https://blog.lasall.dev/post/tell-me-why-google-and-caldav/

Thanks for the report.
I don't know when I will have time to look properly into it, but if you could dig a bit and eventually write a pull request, it would be much appreciated.  Here is the code section that fails (assuming you're on v.1.2.1):
            for o in objects:
                ## This should not be needed
                o.load(only_if_unloaded=True)
                component = o.icalendar_component
                recurrance_properties = ["exdate", "exrule", "rdate", "rrule"]
                if any(key in component for key in recurrance_properties):
                    o.expand_rrule(start, end)

Apparently it breaks because component is None, while it's expected to be a icalendar object from the icalendar library.  The trivial work-around is to throw in something like this:
                if component is None:
                    continue

However, the interesting thing here is ... why is it None in the first place?  Could you debug a bit and send me the output of o.data?  (if it's non-public, you can mask out private parts of it.  If it's neither confidential nor public, you may send it by email)

I already tried the if not component: continue  to workaround the issue while I am working on my project, but it cause issues later (missing vevents  (KeyError: 'vevent')). So it is a really temporary "fix" ^^

I modified to code to log o.data:
            for o in objects:
                print("-"*80)  # XXX
                print(o.data)  # XXX

and I got the following result (CALNAME anonymized):
[...] previous events are ok so I do not paste them here...
--------------------------------------------------------------------------------
BEGIN:VCALENDAR
PRODID:-//Google Inc//Google Calendar 70.9054//EN
VERSION:2.0
CALSCALE:GREGORIAN
X-WR-CALNAME:XXXXXXXXXXXXXXXX (10)
X-WR-TIMEZONE:Europe/Paris
BEGIN:VTIMEZONE
TZID:Europe/Paris
X-LIC-LOCATION:Europe/Paris
BEGIN:DAYLIGHT
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
TZNAME:CEST
DTSTART:19700329T020000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:CET
DTSTART:19701025T030000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU
END:STANDARD
END:VTIMEZONE
END:VCALENDAR

ERROR:caldav:Deviation from expectations found.  Please raise an issue at https://github.com/python-caldav/caldav/issues or reach out to<EMAIL_ADDRESS>include this error and the traceback and tell what server you are using
Traceback (most recent call last):
  File "[...]/__env__/lib/python3.11/site-packages/caldav/lib/error.py", line 28, in assert_
    assert condition
AssertionError
Traceback (most recent call last):
  File "[...]/./gcal.py", line 77, in <module>
    events = calendar.date_search(start=start_date, end=end_date)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]/__env__/lib/python3.11/site-packages/caldav/objects.py", line 907, in date_search
    objects = self.search(
              ^^^^^^^^^^^^
  File "[...]/__env__/lib/python3.11/site-packages/caldav/objects.py", line 1071, in search
    if any(key in component for key in recurrance_properties):
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[...]/__env__/lib/python3.11/site-packages/caldav/objects.py", line 1071, in <genexpr>
    if any(key in component for key in recurrance_properties):
           ^^^^^^^^^^^^^^^^
TypeError: argument of type 'NoneType' is not iterable

the event looks empty compared to the previous one that take 286 lines...

Yes, it's empty, contains only timezone information.  Probably such events should be filtered out.  Perhaps something like this (if I had more time I would have embedded the empty icalendar data in a unit test and fixed this myself):
            for o in objects:
                ## This would not be needed if the servers would follow the standard ...
                o.load(only_if_unloaded=True)

            ## Google sometimes returns empty objects
            objects = [o for o in objects if o.icalendar_component]

            for o in objects:
                component = o.icalendar_component
                recurrance_properties = ["exdate", "exrule", "rdate", "rrule"]
                if any(key in component for key in recurrance_properties):
                    o.expand_rrule(start, end)

cause issues later (missing vevents (KeyError: 'vevent')).

From my code?  I should rewrite it to use the icalendar library rather than vobjects.

From my code? I should rewrite it to use the icalendar library rather than vobjects.

Nope, this one was in my code... But I handled it properly now :)

An other strange behavior is that sometime when I search by date it returns me old instances of recurrent events that are ended in the calendar:

Example (Event B & D)

--------------------------------------------------------------------------------
 => Event A
    Tue May 30 14:00:00 2023
--------------------------------------------------------------------------------
 => Event B
    Mon Jan  2 09:30:00 2023
--------------------------------------------------------------------------------
 => Event C
    Tue May 30 14:30:00 2023
--------------------------------------------------------------------------------
 => Event D
    Tue May 30 11:00:00 2023
--------------------------------------------------------------------------------
 => Event E
    Tue May 30 09:30:00 2023
--------------------------------------------------------------------------------
 => Event F
    Tue May 30 17:30:00 2023
--------------------------------------------------------------------------------
 => Event G
    Tue May 30 09:30:00 2023
--------------------------------------------------------------------------------
 => Event D
    Tue Jan 24 11:00:00 2023
--------------------------------------------------------------------------------
 => Event B
    Tue Jan  3 09:30:00 2023
--------------------------------------------------------------------------------
 => Event B
    Fri Dec 30 09:30:00 2022
--------------------------------------------------------------------------------
 => Event B
    Tue Apr  4 14:00:00 2023
--------------------------------------------------------------------------------
 => Event H
    Tue May 30 16:00:00 2023
--------------------------------------------------------------------------------
 => Event I
    Tue May 30 10:00:00 2023
--------------------------------------------------------------------------------
 => Event B
    Wed Jan 11 09:30:00 2023
--------------------------------------------------------------------------------
 => Event J
    Tue May 30 09:00:00 2023
--------------------------------------------------------------------------------
 => Event B
    Wed Mar  8 09:30:00 2023
--------------------------------------------------------------------------------
 => Event K
    Tue May 30 15:00:00 2023

I managed to filter those events but maybe I should report this as a new issue?

calendar.date_search is legacy and stays there for backward compatibility, use calendar.search instead.

Oh, good to know, I will use  calendar.search() then :)

I confirm it passes here:
                if any(key in component for key in recurrance_properties):
                    print("X"*80)  # XXX
                    print(o.data)  # XXX
                    o.expand_rrule(start, end)

It seems to be a Google side issue. They send a big VCALENDAR with multiple VEVENT... for the Event B, it was moved to an other meeting room, so it exists today but in an other calendar... I do not know how they messed up with that... ¬_¬'

It seems like they can't handle the expanding correctly, perhaps that's why it messes up the meeting rooms too.  Up until recently, Google didn't even try to do expansion.
The caldav library asks the server to do the expansion, originally because I deemed it too difficult to do it on the client side.  Someone eventually helped me to fix client side expansion, but it's only done if the server doesn't do expansion.
The simple workaround for this is to simply not ask the server to do expansion.  Find those lines and try to rip them out:
       if expand:
            if not start or not end:
                raise error.ReportError("can't expand without a date range")
            data += cdav.Expand(start, end)

Now that the library supports client-side expansion, client-side expansion should eventually be the default, however, I'm worried that such a change of behaviour may break something for someone.

The more proper fix would be to add a parameter server_side_expand to the search method, default value True in 1.x and changed to False in 2.0, and then perhaps ...
       if expand:
            if not start or not end:
                raise error.ReportError("can't expand without a date range")
            if server_side_expand:
                data += cdav.Expand(start, end)

I'll close this ticket ... and possibly open another one on the client/server side expansion.


CCDIMTP-443

In this PR, all Link that are external link will all open up in a new Tab.

reviewed and safe to merge


Compatibility error with Let's Do Meadow mod makes negative durability watering can crash the game

Game version:
1.20.1 (Forge 47.2.17)
Mods loaded:
architectury-9.2.14-forge.jar
letsdo-API-forge-1.2.9-forge.jar
letsdo-meadow-forge-1.3.8.jar
morered-1.20.1-<IP_ADDRESS>.jar
How to reproduce:

Get a negative durability watering can from Meadow on survival mode;
(this happened naturally as the Meadow mod was updated and its durability cap was nerfed)

Use it on a grass block.
(this does not happen if the game runs without morered)
Relevant crash log chunks:
java.lang.IllegalArgumentException: Cannot set property IntegerProperty{name=damage, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4, 5]} to 100 on Block{meadow:watering_can}, it is not an allowed value
[...]
Thread: Render thread
Suspected Mods:
[Let's Do] Meadow (meadow), Version: 1.3.8
	at TRANSFORMER/meadow@1.3.8/net.satisfyu.meadow.item.WateringCanItem.m_5965_(WateringCanItem.java:180)

More Red (morered), Version: <IP_ADDRESS>
	Issue tracker URL: https://github.com/Commoble/morered/issues
	at TRANSFORMER/morered@**.**.**.**/commoble.morered.MoreRed.onUseItemOnBlock(MoreRed.java:471)

Use Item on Block Event (useitemonblockevent), Version: <IP_ADDRESS>
	Issue tracker URL: https://github.com/Commoble/useitemonblockevent/issues
	at TRANSFORMER/useitemonblockevent@**.**.**.**/commoble.useitemonblockevent.internal.MixinCallbacks.fireUseItemOnBlock(MixinCallbacks.java:43)

Note
To save you some time, I believe "at TRANSFORMER/meadow@1.3.8/net.satisfyu.meadow.item.WateringCanItem.m_5965_(WateringCanItem.java:180)" refers to the following lines of code in the watering can's source code:
protected BlockState getPlacementState(BlockPlaceContext blockPlaceContext) {
    BlockState state = super.getPlacementState(blockPlaceContext);
    if(state != null) state = state.setValue(WateringCanBlock.DAMAGE, blockPlaceContext.getItemInHand().getDamageValue());
    return state;
}

does the crash happen without useitemonblockevent

Yes it does. I should have made this thread on MoreRed's repository, but the URL in the crash log sent me here.
Adding useitemonblockevent to the mods fixed the issue when using these mods only, is it a dependency?
But I had isolated these mods to test what was causing the issue, using my entire modpack it now says Create is causing this crash:
    Suspected Mod:
Create (create), Version: 0.5.1.f
	Issue tracker URL: https://github.com/Creators-of-Create/Create/issues
	at TRANSFORMER/create@0.5.1.f/com.simibubi.create.foundation.events.ClientEvents.onTick(ClientEvents.java:137)

Maybe Meadow is actually the mod causing the issue? I'll test if doing this with only Meadow and Create+addons causes the game to crash.

I tested and no, the game didn't crash with architectury, letsdoAPI, meadow and create+addons loaded only.
Then I tried running my entire modpack but without both morered and useitemonblockevent and it does not crash the game, so the bug seems to be related to them directly.
Running with only architectury, letsdoAPI, meadow, create+addons and useitemonblockevent (without morered) crashed the game but for some reason only on the second time I used the watering can on a grass block and it was on creative mode (until now it had only crashed on survival mode). If this didn't happen I'd close this thread and open another at MoreRed.

If you just have meadow and no other mods, and shift-click a block with a watering can with an invalid damage value, does it crash?

No.

well, in any case, the problem is this piece of code in meadows doesn't validate the damage value
    @Nullable
    @Override
    protected BlockState getPlacementState(BlockPlaceContext blockPlaceContext) {
        BlockState state = super.getPlacementState(blockPlaceContext);
        if(state != null) state = state.setValue(WateringCanBlock.DAMAGE, blockPlaceContext.getItemInHand().getDamageValue());
        return state;
    }

So, presumably meadow is validating the damage value elsewhere (otherwise it would crash on its own), but any mod that tries to get the placement state from a blockitem in order to simulate anything will cause invalid watering cans to crash (more red trips over this because it checks whether the block being placed would intersect with nearby wires).
The best fix would be for meadows to validate the damage value of the item in getPlacementState and make sure it's not setting invalid values in the blockstate.


Is atom-racer bad for SSDs?

We use temporary files to communicate with racer and need to place them along with your source files.
We shaped them as .racertmpXXXXX because the .* files are ignored by default by Atom.

As I understand, atom-tracer writes a file every time it requests a completion, then deletes it. Doesn't this constant writing/deleting has significant inpact on SSD health?

Save your SSD!  my fork (racer-plus) doesn't use temporary files: https://github.com/Xaeroxe/atom-racer


Disabling Comments

Desired Feature: Ability to disable/hide comments either globally and/or by page/chapter/book.
For my purposes (Technical Documentation for a small team), the comments section, for the most part, is an unneeded resource. I totally under the utility for others, but I do not intend on using it.
As a result, it would be nice to be able to disable it. I don't have a preference if that switch is global, by book, by chapter, or by page.  Turning it off would remove an unused a page component and clean up the UI a bit.
Thank you!

I like this idea. Definitely like the idea of having book/chapter level control of comments.
I realize you want to keep this simple @ssddanbrown but would this be something that we could potentially look at adding to a Chapter/Book Settings menu?

+1

+1 for me!

We would greatly appreciate this feautre as well

+1

Ok, there a few ways this can be done,

Option
Role

Global option
Only administrator can do this.

Option on the book
People who have modify access to the book

Option on the chapter
People who have modify access to the chapter

Option on the page
People who have modify access to the page

I think row 1 and 2 should suffice. Let me know what you guys think. Once we have the requirements nailed down and @ssddanbrown has taken a look, I can submit a PR.

@abijeet: I concur. Chapter and page are likely too granular. Per-book or global rights fit much better in terms of generating forms for documentation.
Thank you for your work!

Yeah, I think we should keep this at a global level. Will mark up for next feature release (v0.19). @Abijeet Feel free to go ahead with this one if you'd like.

Have started working on this, few things to note -

Added an option under app settings - Disable comments
If this is turned on then,

Adding comments is disabled.
Existing comments will not be shown.
The entire comments section is removed and no message is shown stating that comments are disabled.

Two things are debatable here,

Do we show a message stating that comments are disabled? Not sure if it's needed, but can be easily added.
Do we show existing comments? I removed them to save an extra query to fetch the comments.

For what it's worth, my opinion would be that if you disable comments, don't show them. I like what you said about saving ourselves the extra query.

I think the absence of comments is clear enough that they are disabled. My goal with disabling them is to have as little extra stuff as possible on the page.

IMHO @Abijeet choices are good ones. :)

I totally agree, Just hide all existence of comments with the option enabled.

Featured now added by @Abijeet within #593. Will be in the next release.


Error with num GPUs when using 0.8.0rc1

I am trying to run my trainer while utilising 4 GPUs on my system.
I launch my trainer as follows:
trainer = Trainer(gpus=-1, distributed_backend='ddp')

This somehow goes into a tizzy and compares about some hyper parameter that was not even added by me. So the error is:
train_siamnet.py: error: unrecognized arguments: --gpus 4

The thing is that I did not pass this argument, so this is something probably added by PL somewhere down the line.
The model that I use and the launch script is as here:
https://github.com/PyTorchLightning/pytorch-lightning/issues/2069

So it seems one solution is to have the --gpus parameter exposed in the training file and basically ignore it from your end and let PL fill it while calling the script. Is that documented somewhere or is this not something I should be doing?

So it seems one solution is to have the --gpus parameter exposed in the training file and basically ignore it from your end and let PL fill it while calling the script. Is that documented somewhere or is this not something I should be doing?

I'm also having this issue in 0.8.0rc1! Can you describe more how you fixed this?

The ddp mode now (since 0.8.0) launches your script several times. It expects you to have an argument parser with that gpus argument. It will call your script internally with
python train_siamnet.py --gpus 4, right @williamFalcon ?
so the fix is to add this argument to your script and pass it to Trainer.

or use backend="ddp_spawn" which can be slower.

@williamFalcon is this solved in #2212?

yes


I have error with captcha

I get this error!
Unknown error -> --> [Captcha] ERROR. captcha page found. No implementation exists for this yet!
link is
https://seriehd.zone/

Try with version 3.3.0 ? And try with the new example code.

Closed due to inactivity.

I have new version Kyranrana


Random sort appears to be fixed

I finally got around to trying out the random sort behaviour mentioned in #6, and it appears that the result may be cached, or the randomness otherwise isn’t so random.
Requesting https://collections.museumvictoria.com.au/api/items?perpage=1&sort=random seems to consistently return item 58742, "Medal - Jacques Delille, France, 1821”!
I’ve verified this behaviour on multiple systems and with clean caches. Jacques is just so random! 😜

whoops yes I am indeed aggressively caching the results... might wanna turn that off for random sort requests -_-

Thanks! Thanks to the changes in #6, I was able to request just one item per tweet, but this will let me make just one request, rather than two! 😃

Well I probably should have picked this up but that endpoint is the wrong one to call if you want to apply any sorting which is maybe a separate issue that needs addressing.  At the moment the search endpoint is the only one that will allow sorting, so maybe try this url.
https://collections.museumvictoria.com.au/api/search?recordtype=item&perpage=1&sort=random
As the results are random each time it shouldn't be caching it either.

Aha! Perfect 😃

Following up: this worked! 😄


参数量与计算量这个文件的显示错误修正

修改这个文件的部分显示错误

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Invalid auth tokens fail confusingly

Describe the bug
When the saved auth token ($HOME/.flank/UserToken) is invalid for any reason, it is hard to understand why it is invalid. It also does not clean itself up.
To Reproduce

Steps to reproduce the behavior:

Run java -jar flank.jar auth login
Login
Wait long enough for this token to expire (I don't know how long this is)
Run flank again on the same computer

Expected behavior

A clear and concise description of what you expected to happen.

I don't have a clear idea of what expected behavior is.
Idea 1 - Detect that the token is invalid, throw an error, and tell the user to run auth login again.
Idea 2- Automatically delete the token and fall back to env var credentials (via $GOOGLE_APPLICATION_CREDENTIALS)
Idea 3 - Clear log statement showing where flank is trying to pull credentials from, so at least when they see auth related errors, they know where to look
Details (please complete the following information):

Have you tested on the latest Flank snapshot?
Post the output of  flank --version.
Actual behavior:

I believe I had an expired token. When I tried running flank, I saw the error:
Caused by: com.google.api.client.http.HttpResponseException: 400 Bad Request
POST https://oauth2.googleapis.com/token
{
  "error": "invalid_grant",
  "error_description": "Bad Request"
}

I was playing around with $GOOGLE_APPLICATION_CREDENTIALS, but I had to manually step through the code to realize that I had a locally saved token that was taking precedence over the env var.
Additional context

Add any other context about the problem here.

@RainNapper Thanks for the report, it is moved to ranked and will be investigated shortly.


frases of the kingdom

Is your feature request related to a problem? Please describe.

Describe the solution you'd like:

Describe alternatives you've considered:

Additional context:

Closing as incomplete.


Add support for immutable collections

@mohsen-biglari this has been released as part of the v0.9.0 release. Check it out whenever you get a chance next!


IE<=9 blur.placeholder

Placeholder attribute becomes the value of the element when triggering "blur.placeholder"

<input type="text" name="name" placeholder="e.g. John Doe" onkeyup='firePlaceholderKeyup()'>

function firePlaceholderKeyup() {
    $(this).trigger('blur.placeholder');
}

This is the case for IE<-9 where the placeholder value ends up in the value attribute of the element. The text from the palceholder remains in the attribute value if the class is removed and all the action performed with the value attribute contain the text from placeholder.
Possible solution is:
to add the following code to the else branch of setPlaceholder method, just before the

$input.remove(className);

$input[0].value = ($input[0].value !== $input.attr('placeholder'))? $input[0].value: '';

I can confirm that the fix jli3238 posted works too.


WWDC 2022 Viewing Guide

推荐收录
链接
https://useyourloaf.com/blog/wwdc-2022-viewing-guide/

June 2022: What’s new in the Swift Community?
https://www.createwithswift.com/june-2022-whats-new-in-the-swift-community/


adding a system prompt gets an error

I tried adding a system prompt with the default chat_template. I looks like it should support having a system prompt, but it seems like there is a logic error:
invalid operation: Conversation roles must alternate user/assistant/user/assistant/... (in chat_template:1)

When I look in the code it's this part that seems to be off when a system prompt is supplied.
if (message['role'] == 'user') != (loop.index0 % 2 == 0)

Could you please provide the model you are using? Some models do not support system templates, and that error is intentional.

Sorry, it was the mistral model:
$ mistralrs-server --port 1234 --log output.log mistral

The Mistral Instruct model is one of the models that do not support a system prompt, so the chat template disallows that. Perhaps you could prepend the system prompt text to the user message?

Oh, thanks. Sorry for the noise and thanks for taking the time!

No problem!

there is one way to do that
in tokenizer_config.json
in chat template key-
put
"{% if messages[0]['role'] == 'system' %}{% set contains_sys_prompt = 1 %}{% else %}{% set contains_sys_prompt = 0 %}{% endif %}{{ bos_token }}{% for message in messages %}{% if (message['role'] == 'user') != ((loop.index0 + contains_sys_prompt) % 2 == 0) %}{{ raise_exception('Conversation roles must alternate (system/)user/assistant/user/assistant/...') }}{% endif %}{% if message['role'] == 'system' %}{{ '[INST] <>' + message['content'].strip() + '<>' }}{% elif message['role'] == 'user' %}{{ (' ' if contains_sys_prompt == 1 and loop.index0 == 1 else '[INST] ') + message['content'].strip() + ' [/INST] ' }}{% elif message['role'] == 'assistant' %}{{ message['content'].strip() + eos_token}}{% else %}{{ raise_exception('Only system, user and assistant roles are supported!') }}{% endif %}{% endfor %}"
by doing this u will be able to use system prompt and this follows mistral instructions

Recently, there was an even easier way added: you can pass in a custom chat template. Here is the doc:
 -c, --chat-template <CHAT_TEMPLATE>
          JINJA chat template with `messages`, `add_generation_prompt`, `bos_token`, `eos_token`, and `unk_token` as inputs. Used if the automatic deserialization fails. If this ends with `.json` (ie., it is a file) then that template is loaded

From this section.
For example, you can make a custom chat template file (saved as a JSON), which looks like this:
{
    "chat_template": "..."
}

And then run:
./mistralrs-server --port 1234 --log output.txt --chat-template <FILENAME HERE> mistral
We provide the ChatML template and the HF default here.  Hopefully this helps!


Changes lot picker text for cycle 2 release

Description
Changes to lot picker text to "Explore our curricula for 2024/2025." for cycle 2 release.
Issue(s)
Fixes CUR-947
How to test

Check text unchanged at https://deploy-preview-2872--oak-web-application.netlify.thenational.academy
Check when cycle 2 enabled locally text changes to "Explore our curricula for 2024/2025."

:tada: This PR is included in version 1.586.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


move-logs-to-opt fails to install if var-log.mount is masked

After downloading the .ipk artifact from this PR, and transferring it to my rM, I attempted to opkg install ./move-logs-to-opt.ipk, which failed
reMarkable: ~/ opkg install ./move-logs-to-opt_0.0.1-1_rmall.ipk
Package move-logs-to-opt (0.0.1-1) installed in root is up to date.
Configuring move-logs-to-opt.
Warning: Stopping systemd-journald.service, but it can still be activated by:
  systemd-journald.socket
  systemd-journald-dev-log.socket
Moving log files to new location
Failed to enable unit: Unit file /lib/systemd/system/var-log.mount is masked.
Collected errors:
 * pkg_run_script: package "move-logs-to-opt" postinst script returned status 1.
 * opkg_configure: move-logs-to-opt.postinst returned 1.

The core issue here seems to be Failed to enable unit: Unit file /lib/systemd/system/var-log.mount is masked..
I am running OS version <IP_ADDRESS> on my reMarkable 2.
I'm unsure why it was 'masked' -- this is a new concept to me.

I wasn't sure what to do here, so asked in Discord and someone suggested I run systemctl unmask var-log.mount and try again.
After doing so, I ran opkg remove move-logs-to-opt, attempted an install again, and all was well.
(it seemed as though some install-related files hung around even for the above-failed installed)

We don't want to add code to unmask something we aren't masking to a package, so we don't want to work around it that way. I'm surprised that the unit was masked though, as it doesn't appear to be masked in the 3.3.2 OS image, as it doesn't exist. Since this package is creating a brand new var-log.mount unit and starting it, this really shouldn't be happening.
Since we don't support 3.3.2 yet, this'll have to be on the backburner for now. It'll be something we need to test and ensure that it doesn't happen when we get 3.3.2 merged.


Cleanup displayName type

I think this is just wrong type in ProjectConfig: https://github.com/facebook/jest/blob/c6e63f331b491082075aef4c48ced355ae72add5/packages/jest-types/src/Config.ts#L87-L92.
We normalize this to an object in jest-config (if passed): https://github.com/facebook/jest/blob/c6e63f331b491082075aef4c48ced355ae72add5/packages/jest-config/src/normalize.ts#L829-L858
So type out should be either object or missing entirely, not a string.
E.g. here it deals with it just being a string, which I'm pretty sure cannot actually happen: https://github.com/facebook/jest/blob/c6e63f331b491082075aef4c48ced355ae72add5/packages/jest-reporters/src/utils.ts#L18-L34
#8612 also introduces some code around this.

Can I try to work on this issue? If I understand the issue correctly, the type DisplayName should only be an object right? Thanks


Add .idea/ to .gitignore

Add IntelliJ IDE files to the .gitignore.

Are we sure we want to do this? It might be nice to have .idea checked in, to make it easier to get started.

It makes sense to check in if we think that everyone is going to use the same plugin to open the project with. 👀


Update vigilance_meteo.md

:tada: This PR is included in version 1.24.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Create editor groups from ViewColumn as needed (refs #123270)

This is a bit of a semantic breaking change, so asking for more people to have a second look. This will:

make sure that all code paths in the IEditorService that involve creating an editor input are async so that we are not hit by async vs not async issues like #123270
fundamentally changes how ViewColumn is mapped onto IEditorGroup [1]
adopts this in a few places in text editor and notebook land

[1] Explainer
Prior to this change, we would:

use ACTIVE_GROUP even if an extension passes in a specific ViewColumn or ViewColumn.Beside if overall no editors are opened
use SIDE_GROUP if a ViewColumn cannot be found

With this change, we will:

open an editor to the side of the empty main editor group when ViewColumn.Beside is used and no editor is opened
create up to ViewColumn.Nine empty editor groups as needed if a ViewColumn does not exist

Overall I think this is somewhat the correct thing to do because it makes the API work as advertised, however it could have a bit of breakage for extensions that were not properly using ViewColumn. Specifically I think we could now see more editors open to the side of the empty primary group, simply because ViewColumn.Beside was used.
Example of ViewColumn.Beside:

Example of ViewColumn.Four:

This PR fixes #123270

👏 Tested the branch and verified that I no longer saw errors in https://github.com/microsoft/vscode/issues/148368#issuecomment-1207090450 .
I also tried running test Opening a notebook from markers view is broken I can confirm that the notebook editor is opened successfully from the UI side when I changed override to Exclusive as suggested in https://github.com/microsoft/vscode/issues/123270#issuecomment-864186804. The only catch is that the test doesn't pass as it can't find the text document in EH (I guess it's still about how editors/textDocuments travel to EH)
  1) Notebook API tests
       #106657. Opening a notebook from markers view is broken :
     Error: Could NOT open editor for "vscode-notebook-cell:/9f41cdb679196f46.vsctestnb#W0sZmFrZS1mcw%3D%3D".
      at ExtHostEditors.showTextDocument (file:///C:/Users/rebor/code/vscode/src/vs/workbench/api/common/extHostTextEditors.ts:91:10)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (c:\Users\rebor\code\vscode\extensions\vscode-api-tests\src\singlefolder-tests\notebook.api.test.ts:199:3)

@lramos15 is it still suggested that Exclusive should be used here? When it's not set to Exclusive, it still opens the text editor.

Merging in to get more days of insiders coverage since Jo is out for another week.


github: Report code coverage

Closes https://github.com/gluxon/nldl/issues/4

@ernestask In case you were curious, we had to add the Ubuntu version to the Swatinem/rust-cache@v1 cache key before this worked as expected. https://github.com/gluxon/nldl/commit/75e29c1781518c23353770b22f439f2b51a6d340
Thanks again for your work here. Was fairly surprised by this and thought I'd pass knowledge.

Oh, thanks! It made no sense when I was looking at it.


engine 'PLOCAL' was not found

OrientDB Version: v.3.0.4
Java Version:  openjdk version 1.8.0_222
OS: Ubuntu 18.04
I see lots of examples online where they do things like
CREATE DATABASE PLOCAL:/tmp/mydb
or
CONNECT plocal:../databases/GratefulDeadConcerts admin my_admin_password
When I try using PLOCAL I get the following error:
Error: com.orientechnologies.orient.core.exception.OConfigurationException: Error on opening database: the engine 'PLOCAL' was not found. URL was: PLOCAL:/tmp/mydb. Registered engines are: ["embedded","remote"]

I can still connect doing this
CONNECT remote:localhost root my_root_password

Also there is a lot of CONNECT REMOTE:localhost... in the documentation.
All of these doesn't work.
Lowercase is the only working pattern.


Remove device from url

Purpose
Device token is a secret. We want to remove it from the url.
Changes
Removing device from url
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

Please, update the endpoint description in the readme too


Start Unity Project

Added baseline project from VR Core along with README and LICENSE: https://github.com/GeoffreyXue/badgersafari


0.12.0 release prep

TP,
When are these changes hoping to make it back into master?
Thanks.

This is now merged, there is also a release on the forge as well. https://forge.puppetlabs.com/puppetlabs/mongodb/changelog


Ability to include attachment with text in the comment

Added option "includeAttachmentInPost" for enable write text and add attachment in the comment

Thank you for the pull request! We've however implented the same functionality in a slightly different way. The new codes are now in master branch, so we're closing this request.


Refactor TaskRun execution

Goals:

Expose errors creating the TaskRun and the pod
Do not wait until timeouts hit when there is an error
Stream logs as they arrive

TODO:

[x] Cleanup
[x] Stop following logs when container exits

This is ready for review. I know there can be a slight glitch in the order of logs under some circumstances but I think we can still merge this as the issue is minor.


This docs page (found searching google) pops up and then promptly disappears

Describe the bug
Tried this on my macbook OSX 11.1 on chrome and safari.
https://chillicream.com/docs/hotchocolate/v10/data-fetching/pagination
Both places, page appears briefly, then screen clears.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Desktop (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Thanks for report @pkellner  :)
Meanwhile you can find this under:
https://github.com/ChilliCream/hotchocolate/blob/main/website/src/docs/hotchocolate/v10/data-fetching/pagination.md
We track this bug in #2941

Thanks for report @pkellner  :)
Meanwhile you can find this under:
https://github.com/ChilliCream/hotchocolate/blob/main/website/src/docs/hotchocolate/v10/data-fetching/pagination.md
We track this bug in #2941


Export jemalloc stats to prometheus

What have you changed? (mandatory)
Exporting 6 jemalloc stats to prometheus. Details of these counters can be found in http://jemalloc.net/jemalloc.3.html (search for, e.g. "stats.allocated"). Rough meaning of them are:

allocated: how much memory user code (the whole tikv in this case) requested.
active: how much jemalloc allocated to satisfy the allocation requests (because jemalloc has size classes, e.g. user request for 3.9k memory, and the closest size class is 4k, so jemalloc end up allocate 4k).
metadata: extra usage by jemalloc itself, e.g. to keep track of allocation size of each item
resident: close to actual memory used by jemalloc.

These counters should be useful to monitor jemalloc memory fragmentation ratio.
What are the type of the changes? (mandatory)
Improvement
How has this PR been tested? (mandatory)
Run the code in IDC.
Grafana snapshot:

Does this PR affect documentation (docs) update? (mandatory)
Not sure if we document exported metrics.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)

First time rust and tikv coder! Any detailed comments are welcome.
For the PR I also upgrade jemallocator. Jemallocator 0.1.9 doesn't come with stats. Please let me know if it is not okay.

Instead of starting a new thread, what about implementing the prometheus::Collector trait? Like this one https://github.com/tikv/tikv/blob/206209fbcc4c45ae50e1a66fc5df3ac39a6570f1/src/util/metrics/threads_linux.rs

will take a look.

Please sign-off.

@yiwu-arbug
Don't forget to send a PR to add this in Grafana here https://github.com/pingcap/tidb-ansible

/test

/test

@siddontang sure thing.

@breeswish @overvenus addressed comments. mind take a look again?


Implement BIP322

I would suggest to avoid try{}catch{} with empty catch because it makes the developers' live miserable, any bug is hidden and you will never understand why.

Sadly not possible when parsing a witscript and a transaction without massive refactoring. The try/catch is however quite contained to parsing them.

Sadly not possible when parsing a witscript and a transaction without massive refactoring. The try/catch is however quite contained to parsing them.

But cannot you know the type of the exception that would be thrown at least?


Create LEARNING.md

Added the one resource I know of at the moment. It's a bit basic, but the guided tutorials hit the basics.

Nice! Thank you :)


Added missing functions from utilities to unittester

Added all functions from utilities to unittester. Still need to fix copying null values to vectors, but all other utility functions work as expected. Resolved #55

I tested this and the unit test to nullCopyVector failed -- here's the error.
00000020: <error>	() Input to util::nullCopyVector failed. IN: {4, nullInt, 5, nullInt, 124}, {3, 5, 8, 5, 1265}


Add zoo, aerodrome, nature_reserve, locality to landuse polygons

The SF zoo is missing, and the animals there are sad.
tourism:zoo

And pilots at SFO are rioting. Or was that the London Underground people? Whatever.

And we're missing Pt Reyes national seashore north of SF, which has these tags
leisure:nature_reserve
landuse:conservation

Urban areas are in:
place:locality

The SF zoo is missing, and the animals there are sad.
tourism:zoo

Taginfo says that tourism=zoo exists for some points as well. Should we add this to the pois layer? If so, maybe at z16?

And we're missing Pt Reyes national seashore north of SF, which has these tags
leisure:nature_reserve
landuse:conservation

We are already pulling in leisure=nature_reserve. I did some digging, and it looks like it does appear in the tiles. But I'm not sure why it's not rendering when I view it in tangram (I was expecting green).
http://vector.mapzen.com/osm/all/12/649/1579.json
As an aside, we're not querying for landuse=conservation, but that can be added.

Urban areas are in:
place:locality

Looks like there are lots of nodes tagged like this. Should it be added to the pois layer too, z16?

It looks like a style problem, not a data one -- looks like the landuse layer in the demo is only showing specific kind values, and that is not one of them. I think this was @meetar's attempt to cut out some of the notorious New Jersey "farm" areas, but perhaps went too far. Easy to change: https://github.com/tangrams/tangram/blob/master/demos/scene.yaml#L195
(side note, that layer is also requiring features to have a name, but that's overly restrictive since that's just a polygon layer, I can fix that)

That explains it, thanks @bcamper! My vote would be to keep the name requirement for the landuse_labels layer, but drop it for landuse.

Name is required for landuse_labels at the query level (can't label
something without a name :), but not for the actual landuse polygons
(which you could also label using some other data field if you wanted).
On Wed, Aug 5, 2015 at 4:13 PM, Robert Marianski<EMAIL_ADDRESS>wrote:

That explains it, thanks @bcamper https://github.com/bcamper! My vote
would be to keep the name requirement for the landuse_labels layer, but
drop it for landuse.
—
Reply to this email directly or view it on GitHub
https://github.com/mapzen/vector-datasource/issues/124#issuecomment-128134049
.

@nvkelso love that you are looking out for the pilots. I was trying to make a map of airports recently and the polygon data was not available so I started tracing them out and it's a lengthy process and not that accurate. Does the aeroway:aerodrome return polygons or points?
Thanks @meetar :)

Does the aeroway:aerodrome return polygons or points?

@souperneon both [1]. Currently the pr has things set up such that the polygon areas will appear in the landuse layer, and the points in the pois layer.
[1] http://wiki.openstreetmap.org/wiki/Tag:aeroway%3Daerodrome

@rmarianski You're right, Point Reyes was hiding in plain site as landuse:conservation only. Updated the original commit above.

@rmarianski For urban areas, reviewing https://taginfo.openstreetmap.org/keys/residential#values it looks like landuse=urban and landuse=rural are more likely candidates. These should just be landuse polygons without poi or landuse_labels (if they have names, we should probably ignore them).

@rmarianski For zoos, let's set the default min_zoom to 13 (not z16), yes for also include the labels. Is it better to put it into landuse_labels than POI?

@rmarianski For the landuse=urban and landuse=rural, I suspect our grouping of several OSM keys into the same "kind" bucket results in odd stuff happening where a less interesting key's value overwrites the more interesting landuse key's value. For instance, I'm seeing a bunch of "residential" values in the returned landuse tiles, and those are usually a refinement of urban/rural.

I updated the pr (#125):

removed place=locality
add landuse=urban and landuse=rural to landuse layer
add tourism=zoo to pois layer at z13

Wrt the kind collisions, we can always return back the landuse value in addition to providing a kind. I think we've done something like that for the roads layer already, where just the kind might not have been able to provide sufficient information.

PR updates look good.
Yes, let's try returning back also the explicate landuse value in addition to the kind object. We might also need to do that for boundaries, I'll make a new issue for that.

Is it ok for me to merge in the pull request as is, and create a new issue for adding in the landuse value in the response?

Yes.

Created ticket to include landuse tag: #132


Latest run has landed me in facebook jail

Unfortunately, facebook detected I was deleting my comments and thinks I'm a bot/spammer now.
Now, randomly, I cannot reply to comments anywhere.

Sounds like a win win to me

@Skullduggeryism are you still banned from commenting?


[deploy] Maven metadata files missing when publishing snapshots to Nexus2

Task List

[x] Steps to reproduce provided
[ ] Stacktrace (if present) provided
[ ] Example that reproduces the problem (link to git repository is ideal)
[x] Full description of the issue provided (see below)

Steps to Reproduce

Configure a Maven Nexus2 deployer with a snapshot project
Stage artifacts and deploy

Expected Behaviour
Deployed artifacts should be resolvable from another build.
Actual Behaviour
Build tool fails to find snapshot artifacts due to missing maven-metadata.xml files.
Environment Information

Operating System: N/A
JReleaser Version: 1.5.0
JDK Version: N/A

Example of missing files:
https://s01.oss.sonatype.org/content/repositories/snapshots/io/github/gordonmu/gordonmu-coio/maven-metadata.xml
https://s01.oss.sonatype.org/content/repositories/snapshots/io/github/gordonmu/gordonmu-coio/0.8.0-SNAPSHOT/maven-metadata.xml

Released in v1.5.0 -> https://github.com/jreleaser/jreleaser/releases/tag/v1.5.0


Add /etc/ssl/certs/ca-certificates.crt symlink for Ubuntu compatibility

Fedora uses ca-bundle.crt. Ubuntu uses ca-certificates.crt. Supply both
to be compatible. Example use case: a ~/.msmtprc file that is used with
NixOS/Fedora or NixOS/Ubuntu. (We cannot do anything about Fedora/Ubuntu
differences.)

So I happened across this while doing some research on https://bugzilla.redhat.com/show_bug.cgi?id=1053882 . FWIW, the one location you've wound up with is a rather odd one.
/etc/ssl/certs/ca-bundle.crt is not a canonical location for Fedora/RHEL. The canonical location is /etc/pki/tls/certs/ca-bundle.crt. /etc/ssl/certs/ca-bundle.crt is actually a compatibility symlink which was added in response to https://bugzilla.redhat.com/show_bug.cgi?id=572725 . It's actually a rather odd duck, because it's not at all clear what it's providing compatibility with - /etc/ssl/certs is a Debian-ish location, but as far as we can currently tell, Debian has never provided a file /etc/ssl/certs/ca-bundle.crt , only /etc/ssl/certs/ca-certificates.crt. The bug report claims /etc/ssl/certs/ca-bundle.crt made some old version of the Firefox Flash plugin work, but I couldn't dig out references to it being used by anything else at all.
My reading of the situation is the most common locations, by far, ought to be /etc/pki/tls/certs/ca-bundle.crt as a bundle file (Fedora/RHEL, derivatives, and things that aren't derivatives but use or remain compatible with Fedora's system), and /etc/ssl/certs as a hashed directory of certificate files and /etc/ssl/certs/ca-certificates.crt as a bundle file (Debian and derivatives).
Mageia provides /etc/pki/tls/certs/ca-bundle.crt in its rootcerts package (see e.g. here.
SUSE has its own system for generating a system trust store (which makes three, along with Fedora's and Debian's...joy) - https://github.com/openSUSE/ca-certificates . As I read the code, at least, there is no /etc/pki/tls/certs/ca-bundle.crt nor any bundle file in /etc/ssl/certs, but /etc/ssl/certs should work as a hashed directory.
Arch uses the Fedora system, since 2014-09.
So...yes, this does vary across distributions, but the single location you've chosen is an odd one. I don't understand NixOS well enough to make any recommendations - I'm not sure exactly the context in which this file 'exists' for NixOS, or what it's being used for - but just thought I'd point out what I know (from my perspective as a Fedora QA person who keeps running into cases where this trust store location issue comes up).


Add example to show line clear

Line clear can be done on 3 ways

toEnd
toStart
whole line
demo should show this...

fixed in 0.1.2


app/scanningcabinet/scancab: staticcheck

Closing this, see my comment here:

https://github.com/perkeep/perkeep/pull/1405#issuecomment-894727096


Implement support for yarn.lock

In addition to package-lock.json, we also should support yarn.local for JS packages.

I may be able to get to this as part of the osv-scalibur work.

Do we have an issue for pnpm-lock? That's probably more valuable than yarn tbqh.

Do we have an issue for pnpm-lock? That's probably more valuable than yarn tbqh.

I don't think we do


Submission: Autocomplete - twobox with autocomplete

Form: teaching_submissions

twobox is not supported in the DSpace7
in v5 it looks like this:


JSON API Reference is missing information on metadata 2.2 and 2.3 fields

Describe the bug
This JSON API reference: https://github.com/pypi/warehouse/blob/main/docs/dev/api-reference/json.rst
Is missing documentation on the "dynamic" and "provides_extra" fields, added in versions 2.2 and 2.3 of the core metadata specification (https://packaging.python.org/en/latest/specifications/core-metadata/).
The example output shown in the reference is missing them entirely, yet they can currently be seen if you query the JSON API.
Expected behavior
API reference should include these fields

@konstin re: https://github.com/pypi/warehouse/pull/13606

Thanks! I've added the "Good First Issue" label to this issue.

Perchance could you comment here w/ what those fields look like when populated (or point to a package where they are not null, I had trouble finding one)

Thanks!

Working on this


ROX-14763: Verify namespace details refactor

Description

Refactor the Verify namespace details test.
User-facing documentation
(must be 2 items and both must be checked)

[x] CHANGELOG update is not needed
[x] Documentation is not needed

Testing

[ ] inspected CI results

Automated testing
(must be at least 1 item and all items must be checked)

[x] modified existing tests

How I validated my change

[x] Manual test with OCP and GKE clusters
[ ] CI

/test gke-qa-e2e-tests

/test gke-qa-e2e-tests

/test gke-qa-e2e-tests

/test gke-qa-e2e-tests


Carousel and setup.py.

Dear Mr. @rougier,
This branch includes Carousel directive, customized Container and setup.py script.  Could you please merge them?
Sincerely yours

Thank you very much. for your contribution. Does it work ok with bootstrap v4 ?

I tried rst2bootstrap4 and other console scripts on Python v3.5.2 and Ubuntu 16.04.4 LTS.
The rst2bootstrap4 adds URL to bootstrap v4 css.
The rst2bootstrap3 adds a link to local bootstrap v3 and URL to v4 css.
If you find any issues, please let me know.

Thank you very much.  I really appreciate it.


Fix tests raising unwanted Deprecation Warnings

fixed up tests that were calling recently moved .music_library methods. Closes issue #366.

@dundeemt This is great - thanks.  Any chance of moving these tests into their own module? They probably don't belong in test_core.py anymore.

Sure, I'll update the PR this weekend.
Are you asking that I create a test_deprecations.py and move the
deprecation tests to that, or a test_music_library.py and move all
.music_libary based tests to that?
On Fri, Oct 2, 2015 at 9:12 AM, Lawrence Akka<EMAIL_ADDRESS>wrote:

@dundeemt https://github.com/dundeemt This is great - thanks. Any
chance of moving these tests into their own module? They probably don't
belong in test_core.py anymore.
—
Reply to this email directly or view it on GitHub
https://github.com/SoCo/SoCo/pull/367#issuecomment-145032443.

--
Best,
Jeff Hinrichs
<EMAIL_ADDRESS>402.218.1473

The latter would be excellent
Lawrence

@dundeemt this has been sitting around here for a while. Do you plan to make the changes you and @lawrenceakka discussed?


Not building on Windows

After I configure CMake for example: cmake -B build . -A x64 on Windows and it picks up VS2022, I get the first error complaining about the added switch -Wno-initializer-overrides.
After removing that switch, I get many compilation errors later on.
Is this supposed to build on Windows?
I try switching to clang with:
cmake -B build . -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++

Also, to no avail.
It builds on Linux though.

Hello, sorry to hear things aren't working for you. To get a little more detail, are you trying to build the examples in the repo with the root CMakeLists.txt?

Yes, correct. Configuring from the root. As I said, the same steps work on Ubuntu 24

Thanks, what version of clang on windows are you using?

For context in terms of what I'm trying to figure out - I'm able to build the examples with CLion + Cmake + Clang 18 on Windows 10

C:\Program Files\Microsoft Visual Studio\2022\Professional>clang --version
clang version 17.0.3
Target: x86_64-pc-windows-msvc
Thread model: posix
InstalledDir: C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\Llvm\x64\bin

C:\Program Files\Microsoft Visual Studio\2022\Professional>

Interesting, would you be able to paste the whole output of the compile that fails?

Most Windows users don't use CLion . Either VS community edition, VS Pro, VS Code, etc.
Can you try with VS community edition 2022?

Ok, I figured it out.
It turned out the way I was configuring CMake on Windows was still picking 'cl' instead of 'clang-cl'.
The proper way to fix this in Windows, is to configure as such:
cmake -B build -T ClangCL

Note the -T to select the proper toolchain.

Cheers and thanks for your help!

No worries, and I'll make sure that I make a note of that somewhere - it's always good to collect platform specific compiler quirks! 🙂


Translate basics into Chinese

Just finished translating the basics chapter into Chinese.
Tested on my own machine, looks fine.
Hope this can be merged soon!

Hey @cizixs do you plan to re-open this PR?


Navigating to an earlier time freezes video for other Funimation watchers

When navigating to an earlier time than current, the position of other Funimation watchers' videos gets updated, but the loading spinner remains in a freezed state, and the video doesn't start up again before people have clicked pause and play.
This is probably because the Brightcove player gets confused by the video state jumping backwards outside of it's control logic. Something gets stuck. In this state, the class of the video element contains "vjs-playing vjs-seeking vjs-waiting".
I'd like to fix this, but it may require more insight into how Brightcove works than I want to spend time gaining right now. I'll leave this issue open until I (or someone else) comes up with a fix for it.

The solution may be to make an exception for Funimation, and use the Brightcove player api instead of using the HTML5 video api directly, as we do with the others:
https://player.support.brightcove.com/coding-topics/player-events.html
The players that Wakanim and CrunchyRoll use, seem to be fine with handling the direct HTML5 calls whereas Brightcove seems to break on this more frequently. I was trying to fix dub changes too, so they wouldn't affect other watchers. But I hit similar issues with weird behaviour that may be caused by control conflicts with Brightcove when using the HTML5 api.

I believe this has been fixed as of 17b0d79cf61818af7bc8c92fdca8011fb6aa604b


Add pop() to memory history

Hi,
First of all, thanks for your amazing work! :rocket:
I started using history with <NavigationExperimental /> in react-native. NavigationExperimental provides two different methods to go back to a previous route: jumpTo() (similar to go() with createMemoryHistory() ) and pop(). However: this one is missing in history. The goal of pop() is to update the index and pop out a route from the entries (when go() just updates the index in history).
This PR is a simple implementation of pop() method.
Thanks

I believe this does the same thing as API that we already have. Closing.

Hi! Sorry for the late reply!
As you said, pop() and history.goBack() or history.go(-1) act the same way. The only difference I tried to highlight is how they act under the hood.
In react-native for instance, we can use navigator.pop() to go back and then unmount the current scene. navigator.jumpBack() does the same thing as navigator.pop() but it doesn’t unmount the current scene while going back. This mean that we can then come back to this scene afterwards through a “next” button for instance. With navigator.pop(), after you’ve triggered the back action, you can’t come back again on the scene you just left.
Therefore, while we do have navigator.jumpBack() in react-native that acts like goBack() in history, we do not have a pop() method in history that could suit the need of unmounting the scene (like navigator.pop() does).
The goal of this PR is to add this pop() method so that history could act like navigator.pop() if we use it in react-native. For instance you’ll have:
const initial = {
  ...history,
  index: 1,
  entries: [{ pathanme: '/scene1' }, { pathname: '/scene2' }],
}

const afterGoBack = {
  ...history,
  index: 0,
  entries: [{ pathanme: '/scene1' }, { pathname: '/scene2' }],
}

const afterPop = {
  ...history,
  index: 0,
  entries: [{ pathanme: '/scene1' }],
}

That's why we do need these two types of “back methods” in react-native, and it would be great that history supports them.

@mjackson ?

Hey, sorry for the slowness. Been super busy :) I asked a question on the PR.

Hey @LeoLeBras :) We're working on getting great support for React Native in React Router v4. We've already got code that works in our react-router-native package which we'll be releasing this next week.
Would you be able to take a look and test it out? I think there may be something here, but I'm still not 100% sure.

Closing due to inactivity.


Adjusting the waveform rendering parameters

First of all, happy new year!
Now on to my issue.  Though this is less of an issue and more of a request for advice.
I am trying to modify the way in which the waveform renders so that it fills more of the display area, top to bottom in the same way that the 'soundcloud' rendered waveforms do. Currently there appears to be a 25% margin on both the top and the bottom, making the waveform itself too 'slim' for the purposes.
In other words I would almost like to be able to render a 'compressed' version so that the average loudness is brought up, creating a 'thicker' waveform.  My guess is that this would require modification of the equation used in your script.
The visual style of waveform I am looking to create can be seen here:-
http://soundcloud.com/groups/pretty-waveforms
I have toyed with the equation somewhat but to no avail.  Perhaps you have some insight as to how I might go about achieving this?
Many thanks!

I have managed to solve this issue...
The code required is as follows:-
replace:
$v = (int) ( $y / 255 * $height );
with:
$x = ($data - 128.0) / 128.0;
$y = 128 + 127 * sign($x) * pow(abs($x), 0.4);
$v = (int) ( $y / 255 * $height );
And add a seperate function:-
function sign($x) {
if($x > 0) return 1;
if($x < 0) return -1;
return 0;
}
This will essentially apply a gamma curve to the data.  The arc of this curve can be adjusted by changing the number '0.4' in the second line.
It works a treat, especially with imagethickness set to around 4.  It looks pretty much identical to soundclouds waveform.
With one exception, which I will open a seperate issue for.
Incidentally, this wuld be a nice addition to the script in my opinion.  Perhaps offering a new option value to change the level of audio compression applied to the waveform.  Regardless, Hopefully someone will find it useful.

Great work! I'm going to give your code a try on my end so I can peak at the results myself.
I only had a few minutes yesterday to play around, but my first thought was to draw a rectangle (using imagefilledrectangle of about 5-10 pixels in width, as opposed to a single pixel line). The results actually weren't too bad, a little blocky looking at a higher zoom/detail level, but acceptable. Sounds somewhat like we were thinking of the same solution in different ways perhaps.
I also found this discussion some time ago which discusses using a root mean square calculation on a particular block size of data points (a detail level?) to better calculate and plot an "average" peak data set rather than plotting each individual peak point separately and only skipping arbitrarily. This should be something I look into, as this would probably give better, more accurate waveform results over a whole audio file.
As far as adding audio compression, the best way to do this would probably be with the LAME decoding of the original MP3. There's some mentions of compression options in the LAME command line options page. I'll play around a bit, but going this route would be my first option, rather than performing different calculations to the plotting algorithms to achieve the same effect?

Very interesting regarding the mean square calculation.  This is something I may look into myself also.  Regardless my waveforms now look fantastic and far better than 'soundcloud's might I add. :-)
Now to do some work on png optimization.  My app will be filtering thousands of songs in real time, without refreshing the page (via tempo sliders, drag and drop genre's etc) the png's are currently sitting at about 16kb a piece, I need to get them down to around 4-5kb ideally.  I'll take a look at OptiPng and see what that can do.


Update Build/Program window styles

Sketch file ref Vizor UI 151105
In current form, quite confusing as to which tab you are currently on.

tabs for this have been fixed. (but not yet the rest of looks)


Fix a typo in date.ts

@UeiWang please see https://github.com/microsoft/vscode/wiki/How-to-Contribute#spell-check-errors

@UeiWang please see https://github.com/microsoft/vscode/wiki/How-to-Contribute#spell-check-errors

Sorry, I forgot about that.... Should I close this pull request?


cosole: shell: Add 'exit' command to leave a module

In shell, to select a module, we use 'select <module_name>'. When inside a module, there is no indication on how one has to leave the module. So add 'exit' command to leave a module.
I know (after reading code) we can use 'select' without an argument to go back to default module but having an exit will make it more obvious. Besides, people are used to hitting 'exit' or 'quit' to leave a prompt so I thought it makes sense to have it here as well.

Besides, people are used to hitting 'exit' or 'quit' to leave a prompt

Indeed, people are used to that, but your patch doesn't do that, so it may only get confusing.
Otherwise, your patch "exit"s where? To a place where the only useful thing you can do is to issue another select <submodule> command. Then maybe we should just print "select" as an available command in any submodule's help.

Commit message:

cosole:

A typo. Besides, I'd say, "console" is superfluous here, it should start with just "shell:".

Indeed, people are used to that, but your patch doesn't do that, so it may only get confusing.

I presumed changing the prompt to the module's name and listing only commands available in that module in the help command is as close as we can get to entering/leaving a prompt in this case.
What you say does make sense, but listing "select" as an available command in all submodule's help (without the the list of module names) is also equally confusing/counter-intuitive.

A typo. Besides, I'd say, "console" is superfluous here, it should start with just "shell:".

Fixed.

I though select alone would unselect the current module, actually it does work for me:
shell> select net net> select shell>

My comment is not really related to this PR but I have always wondered why do we need to select the module in the first place. I mean that if the commands in different modules are unambiguous, the system should automatically be able to execute the correct handler. Only if there are commands that have same name, one should need to either select the module or add module name before the command.

@Vudentz:

I though select alone would unselect the current module, actually it does work for me:

Indeed that works. I have mentioned this in my initial comment as well. The discussion is to leave that as an unadvertised feature (as it is right now) and implement exit to leave current module.

@jukkar:

why do we need to select the module in the first place.

Having modules does a lot of niceties. For instance, it allows namespaces. In real world applications, I think we can easily cross 10 commands per module and all of them will tend to have a set/get -ish commands, therefore making collusion a real possibility.
This is not mentioning the fact that you may (very quickly) have to scroll the output of help command in a unified namespace. For this reason alone, I'd go with this modular approach.


Move our PVC tests to work with hostPath

We have pretty consistent failures under storage tests, that connected to the fact that k8s sometime fails to login or logout ISCSI session(it will re-run login and logout command, but tests will already fail on timeout).
Currently provided images:

alpine: http://dl-cdn.alpinelinux.org/alpine/v3.7/releases/x86_64/alpine-virt-3.7.0-x86_64.iso
custom: just empty filesystem

PR overview:

add disks images provider daemon set
adapt functional tests
remove ISCSI daemon set and image

Signed-off-by: Artyom Lukianov<EMAIL_ADDRESS>

Btw - I'm not against this.

OK to test

retest this please

Thakns for explaining where the image comes from :)
So, in general not to worried, the only thing that comes to my mind is that we eventually want to use local PVs, as outlined here: https://github.com/kubernetes-incubator/external-storage/tree/master/local-volume

So, in general not to worried, the only thing that comes to my mind is that we eventually want to use local PVs, as outlined here: https://github.com/kubernetes-incubator/external-storage/tree/master/local-volume

@fabiand yup, we can transition to local storage at some point. I think what @cynepco3hahue has done here with hostPath is a great first step to stabilizing our test suite though. I'm pretty happy to get rid of iscsi as soon as possible.

OK to test

@cynepco3hahue looks great. Will help a lot for the tests.


Added automation tests for location

Successful run: https://github.com/SoftwareAG/cumulocity-asset-properties-widget/actions/runs/7261232956/job/19792387362

HYG for the successful run https://github.com/SoftwareAG/cumulocity-asset-properties-widget/actions/runs/7401641179/job/20137809824


GroupBy Schema Evolution 0 - Ignore streaming rows or tiled IRs for decode failures

Summary

Currently, the group bys are designed to be immutable. Therefore, when there is a group by schema change in place, the streaming rows or tiled IRs will have decode issues when the group by serving info is updated by the group by batch upload job.
This PR will handle the decoding errors gracefully by ignoring the failed streaming rows or tiled IRs. Therefore, it won't fail loudly but with proper error log statement. For the streaming rows or tiled IRs that can be decoded successfully, it will be still included in the fetcher to construct the group by response.
The long term goal is to enable group by schema evolution.
Why / Goal

For a smooth online serving path.
Test Plan

[ ] Added Unit Tests
[x] Covered by existing CI
[ ] Integration tested

Checklist

[ ] Documentation update

Reviewers
@airbnb/zipline-maintainers

Discussed offline, the ignored failures on streaming write decoding might cause incorrect fetched feature data if we don't restart the streaming job when there is a schema update on GB.
For now we can rely on instrumentation to surface these issues and restart the streaming jobs if necessary for the users.

👋 Would it be possible to change this so that the behavior can be controlled by a feature flag or configuration? These decoding issues would cause us to surface partial data, which most of our models aren't prepared to handle, and have some use cases where users would prefer to fail hard.

I noticed that you guys are using a FlagStore to control it here. I am curious to learn more about it and apply it here.

@better365 - yeah it would be great to leverage the flag store for this.
Here's the original flag store scaffolding pr - https://github.com/airbnb/chronon/pull/686/files
And use in a PR (I see you've already started looking at that one) - https://github.com/airbnb/chronon/pull/682/files#diff-9ea959844a5006c401298a8b18ac1b693a917a310345d563a10b76558127a297R255
We could chat sync about this topic in our bi-weekly next week as well.

@better365 - yeah it would be great to leverage the flag store for this. Here's the original flag store scaffolding pr - https://github.com/airbnb/chronon/pull/686/files And use in a PR (I see you've already started looking at that one) - https://github.com/airbnb/chronon/pull/682/files#diff-9ea959844a5006c401298a8b18ac1b693a917a310345d563a10b76558127a297R255
We could chat sync about this topic in our bi-weekly next week as well.

Thanks @piyushn-stripe. Somehow I missed the initial PR for it. Let's sync up tomorrow and I'd like to implement one at our side as well!

@piyushn-stripe I made it configurable with a new param disableErrorThrows. In the long run, we can make it configurable from flag store, custom json in the config, and lastly the fetcher client.
The current approach will not change the behavior. It will first take the flag from flag store. If not present, then use disableErrorThrows.


Color overhaul

The enums.Color is now a packed struct made of R, G, B and I u8 elements, which allows for casting straight to a u32, along with easy field access to each color value.
A couple functions have also been updated to build on the latest Zig and most functions that require a color param have been updated to accept the new Color type

Great...thank you


5.0.2 gives warning about deprecated rules

Using tslint with 5.0.2 I get this:
Warning: no-duplicate-case rule is deprecated. Replace your usage with the TSLint no-duplicate-switch-case rule.
Warning: no-var-self rule is deprecated. Replace your usage with the TSLint no-this-assignment rule.
Warning: valid-typeof rule is deprecated. Replace your usage with the TSLint typeof-compare rule.
Seems these rules were removed in the main part of the recommended rules set, but then they are turned on again at the end:
    /**
     * Deprecated rules.  The following rules are deprecated for various reasons.
     */
    "missing-optional-annotation": false,  // now supported by TypeScript compiler
    "no-duplicate-case": true,
    "no-duplicate-parameter-names": false, // now supported by TypeScript compiler
    "no-empty-interfaces": false, // use tslint no-empty-interface rule instead
    "no-missing-visibility-modifiers": false, // use tslint member-access rule instead
    "no-multiple-var-decl": false,         // use tslint one-variable-per-declaration rule instead
    "no-stateless-class": true,
    "no-switch-case-fall-through": false,  // now supported by TypeScript compiler
    "no-var-self": true,
    "react-tsx-curly-spacing": true,
    "typeof-compare": false,               // the valid-typeof rule is currently superior to this version
    "valid-typeof": true,

I would also love to understand how rules are supposed to be deprecated.
The README.md states about recommended_rules.js:

Also, please note that adding a rule to the recommended ruleset is considered backwards compatible. If you rely on version ranges in your dependencies then you may find that new rules being added to the product create violations and fail your build.

These sentences are confusing for me a bit since it seems like they contradict each other.
But if tslint-microsoft-contrib offers a "stable recommended rule set" that one can extend from, instead of en- or disabling rules that moved to/ should be replaced by core rules, is there a clear flight plan for how this happens?
Would it be an option to just enable those recommended new rules instead of the deprecated ones, by putting those changes behind a proper semantic version increase?

@karfau - Rules are deprecated when something is added to TypeScript or TSLint that makes the rule obsolete. Typically, we turn the rules off in recommended_ruleset.js for a release or two. Eventually we remove the rule from the code base.
As we add new rules, if they are good rules, then we recommend that people turn that rule on in recommended_ruleset.js.
Any change to recommended_ruleset.js will be versioned.
It sounds like what you're asking for is to increase the major version number for every new rule added to the recommended_ruleset.js because it might break somebody's build if they rely on version ranges. I personally don't see the point, but others may disagree. Feel free to file a an issue for this and if a bunch of people upvote then I can do it. At the end of the day, there is the same problem regardless: if you use wildcards then you have a chance to take a bad dependency and fail your build, which is try for project dependency.


Fix access to _read yielding move-only value.

When calling a method off of a _read yielded move-only value, it's suppose to be yielded as borrowed
(i.e. BorrowedObjectRead). But part of SILGen was trying to treat it like a OwnedAddressRead.
That happened because there wasn't a LoadExpr, like the code pattern-matching expected.

@swift-ci please smoke test

Closing this in favor of https://github.com/apple/swift/pull/63822