wikimedia commons

I tried to modify the plugin to make it work with wikimedia common but the bounds have given me problems
https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=query&list=geosearch&gsbbox=37.8|-122.3|37.7|-122.4
Some ideas? Thanks

Did you see https://github.com/MatthewBarker/leaflet-wikipedia which actully I stole code from
Although it seems to use gscoord ratehr than gsbbox
https://github.com/MatthewBarker/leaflet-wikipedia/blob/master/source/leaflet-wikipedia.js
origin = this._map.getCenter(),
data = {
format: 'json',
action: 'query',
list: 'geosearch',
gslimit: this.options.limit,
gsradius: this.getRadius(),
gscoord: origin.lat + '|' + origin.lng
},
But should be do do something similar.
In GEographs case, I had the GEograph Server understand the 'standard' BBOX string


refactor dummy tasks

dummy tasks are currently split into multiple modules with lots of duplicate code

We still need each one of the four task to be executable, and their if __name__ == "__main__" blocks do look slightly different (minor differences in the arguments, but most importantly that block should call the right function).

What is very simple to do (and I am doing it right now) is to merge the pairs (dummy, dummy_fail) and (dummy_parallel, dummy_parallel_fail) - by adding a flag raise_error=True/False.
What is less obvious (and I don't see a clear advantage in doing it - for such small testing tasks) is to merge dummy and dummy_parallel, since they have a different call signature (one takes component, the other one does not).


It is not clear how to update your local fork. Please extend the documentation or raycast

Description
It is not clear how to update your local fork. Please extend the documentation or raycast to allow in an easy way to maintain the local version and keep it up to date

Yeah. After 50% the clone of the repo went through an error.


Prepared documentation for publication

Checks all documentation headers; fixes #19
Checks all documentation code blocks; fixes #20
Checks all documentation tables; fixes #22
Checks all blockquotes; fixes #23
Checks for content. Added a section on processors, and added "TODO" items in incomplete sections. Fixes #21

Additionally, this converts the documentation to mkdocs, adds a cover page, and adds build automation.
Preview documentation: https://zendframework.github.io/zend-log/

:+1:


Use more generic name for NFD features host directory volume

NFD hooks are deprecated and going away:
https://github.com/kubernetes-sigs/node-feature-discovery/issues/856
This makes the mount names more future-proof, and shows where later changes need to be done (to change operator mount directory, and switch hook-using deployments e.g. to feature files).
I decided to split this from PR https://github.com/intel/intel-device-plugins-for-kubernetes/pull/1118, so that same change can be done for all plugins (GPU + SGX), to avoid complicating later switch away from hooks.  Added SGX part is not tested, but that change is identical to GPU one.

e2e-gpu
This request was automatically failed because there were no enabled runners online to process the request for more than 1 days

@mythi Any idea when runners will be available?

Any idea when runners will be available?

WIP, the host is down for some reason.

@tkatila thanks!   Let me know when GPU runner is up again, and I'll rebase this to HEAD, to force re-testing.

/lgtm  Doc looks good now (and I checked that all links are fine).

@eero-t e2e gpu became online and tested ok.


WFLY-8664 - Update description of binary-keyed-jdbc-store and mixed-keyed-jdbc-store

Upstream Issue: WFLY-8664
Issue: JBEAP-10553
Note that as the changes modifies the schema, I've bump the version to 4.1. I do expect the changes to the subsys are "big enough" to warrant bumping to 5.0, but I may be utterly wrong on that. I also removed a test on a no longer supported storage.

@pferraro  OK, so I really need to figure out why not bumping the version lead to some unit test to fail. i assume, wrongly apparently, this was done by designs, to ensure that any changes to the XSD would lead to a version bump. Clearly I'm wrong :)
I'll give it an other stab and let you know.

Superseed by https://github.com/wildfly/wildfly/pull/10224 - @pferraro As suggested by @kabir I've simply update the XSD to mention the deprecation of the two attributes, rather than removing them from the schema.

Superseeded by https://github.com/wildfly/wildfly/pull/10224 now merged.


Concurrent upload block blob from file, concurrent download blob to file

/check-enforcer reset

@damirault @danieljurek @Azure/azure-sdk-eng Can you please review this commit? I made some change to eng/ to make CI pass.

@RickWinter for your awareness

I saw this earlier today and have a similar fix in another PR for it. But this one is more likely to go in first so I can rebase. Thanks for making this change!
This is the right change to make for now but in the future it'd be nice if we didn't have to install dependencies from vcpkg just to generate doc artifacts. I've already got an issue tracking this here: #196

Thank you very much for your quick approval.


Missing env file

Hi,
In the last pull request, I forgot to include the .env file. This file is needed by to build or start the compose.

Great! Thank you


Please clarify Reverse Proxy behavior for Unhealthy instances

The documentation doesn't make clear the behavior when there an instance is known to be up, but unhealthy. This GitHub issue (open as of Feb 2019) indicates that traffic will still be routed to unhealthy instances.
https://github.com/Azure/service-fabric-issues/issues/607
I'd be interested to read about the extent/limits of the relationship between Reverse Proxy, Naming Service and Health Store.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31e0a1d2-789d-240f-be0b-892d43f80b66
Version Independent ID: aac58453-4adc-5c04-8067-d7107dc2df45
Content: Azure Service Fabric reverse proxy
Content Source: articles/service-fabric/service-fabric-reverseproxy.md
Service: service-fabric
GitHub Login: @BharatNarasimman
Microsoft Alias: bharatn

Thanks for the feedback! We are currently investigating and will update you shortly.

@lukepuplett I will assign this to the content authors to review and see if it makes sense to add that info here.
CC @BharatNarasimman

@lukepuplett
I've closed the other issue, and this one will be closed shortly.
Please review the following:
https://docs.microsoft.com/azure/service-fabric/service-fabric-diagnostics-event-generation-app
https://docs.microsoft.com/azure/service-fabric/service-fabric-health-introduction
https://docs.microsoft.com/azure/load-balancer/load-balancer-custom-probe-overview
https://azure.microsoft.com/resources/samples/service-fabric-watchdog-service/
As stated in the referenced issue, this feature request is redundant to Azure Loadbalancer probes functionality; use them in Azure to ensure traffic is only routed to healthy services. If on prim, configure your LB to only route traffic to healthy services.
It sounds like you should review your telemetry and ensure you are accurately modeling your services health; as it isn't correct if your service is available but unhealthy.
E.G. You can use a Watch Dog services to collect custom health telemetry of your services, and inform your SF cluster the service is unhealthy; while ensuring your LB's is configured with appropriate rules to determine the service is available to accept traffic.
I.E. A simple LB rule that checks if a service endpoint is discoverable/returns some payload, isn't sufficient to catch implementation faults, that doesn't cause the service to terminate or return a payload that implies unhealthy; These experience probes are only one part of the solution you should be measuring. You have Infrastructure performance to measure, and internal service implementation to monitor for your service to be determined available and healthy.
@MicahMcKittrick-MSFT #please-close

Thanks. I'm not sure this is satisfactory or perhaps everyone on my team and the other guy that posted on the other thread are misunderstanding the health model.
My issue is that the current behavior of the local Reverse Proxy service, when an instance is unhealthy, is not stated in the documentation, i.e. that the RP will continue to send traffic to an instance that is known to be in a status "Error".
The second issue I'll explain in a new comment here:
https://github.com/Azure/service-fabric-issues/issues/607

@aljo-microsoft I understand your remark with the LB. But how can we do this if all traffic is routed by the LB to the Reverse proxy endpoint? The loadbalancer Probe check will be valid because this is checking the RP endpoint on 19081 not the individual service endpoints.
I have same feeling as @lukepuplett that when using the Reverse Proxy behind a Loadbalancer the reverse proxy should only route to healthy nodes.
Can you please elaborate on this and not close the topic as this is a valid question.

Any update on this, @aljo-microsoft ? I have the same question as other here. If the request is going from Azure LB -> SF Reverse Proxy ->  then the Azure LB will always forward request to the SF reverse proxy. At this point it is up to the reverse proxy to decide which node to send the request to. Does the reverse proxy check to see if an application is is healthy state on a node before sending the request to that particular node? What if the application is being upgraded on a particular node, it seems that SF Reverse proxy will still send the requests to that node.

it's closed, but not answered? or at least, I don't see a valid anwser on how the reverse proxy will stop sending traffic to unhealthy instances?


Current program allows sql injection

As the code is sending raw strings to the SQL database it may be vulnerable to sql injection. Pray use parameterised queries in the production version.

solved using parameterised queries.


stage_performance_2_agent_date

Hello,
I want to try Stage Performance Tasks, but the three bots in the game did not start performing as I expected, but were still thinking about collecting wood... And only one of the three bots moved, while the other two just stood there in a daze. Is there something wrong with my settings? Here is my startup code:

Stage Performance Tasks are developed by @lovekdl and I don't familiar with this part of code. I just checked this part of code and I found there may be some mistake.
I will submit a pull request soon, and provide a simple example to show how to get enuough information of stage performance tasks.
And sorry for that I have no time to provide a complete example because I'm busy with other projects. If you implement a good stage performance tasks example, you can submit a pull quest. I will carefully review it and try my best to get it merged.

I have merged the pr. You can use git pull origin main to get latest code. The new example is scripts/stage_performance_task.py.
And I fixed the mistake in description files. I know you found that, too. 😄 😄 Be free to create a pull request if you want.

To be honest, I'm not sure.
But according to alex_example.py, it looks correct.

thanks!


[tflite] add fp16 support for evaluation tools

Most NN accelerators on Android devices don't support FP32. To evaluation their capabilities, we should call Interpreter::SetAllowFp16PrecisionForFp32(True) so that NNAPI delegate will call the corresponding ANeuralNetworksModel_relaxComputationFloat32toFloat16() when used.
This patch adds fp16 related support so that we can do something like
./imagenet_accuracy_eval \
--model_file=tflite-models-new/float/mobilenet_v1_1.0_224.tflite \
--ground_truth_images_path=ilsvrc_images \
--ground_truth_labels=ilsvrc_validation_labels.txt \
--model_output_labels=labels.txt \
--output_file_path=accuracy_outputs/mobilenet_v1_1.0_224_float_nnapi.txt \
--delegate=nnapi \
--allow_fp16=1 \
--num_images=0

on Android devices

Hi Chao, can you look at this one?

Hi Chao, can you look at this one?

Sure.

@multiverse-tf Agree that SetAllowFp16PrecisionForFp32() may not be great, but it seems execution_preference, which I think should stick to what NNAPI has, is not the right place to add the fp16 option (I submitted Java wrapper to the execution_preference before, 996f0ec). I can add a fp16 field after this to replace the Interpreter option, but that means more places should be changed, including benchmark_model, evaluation code, Java wrapper, etc.

@multiverse-tf Agree that SetAllowFp16PrecisionForFp32() may not be great, but it seems execution_preference, which I think should stick to what NNAPI has, is not the right place to add the fp16 option (I submitted Java wrapper to the execution_preference before, 996f0ec). I can add a fp16 field after this to replace the Interpreter option, but that means more places should be changed, including benchmark_model, evaluation code, Java wrapper, etc.

TBH, I think adding this fp32->f16 relaxation option to nnapi delegate is simpler and less invasive than this one. In particular, as for tooling side change, you just need to add the new option to nnapi_delegate_provider.cc  to enable the support across evaluation/benchmark tools w/o changing evaluation-inference-stage internals. From this perspective, the approach is more general, benefiting the benchmark tool as well as improving the nnapi delegate implementation itself.
In addition, I think it's straightforward to change this in separate smaller PRs (or in a single PR if you want) :

add the option to C++ nnapi delegate implementation
Basically, one could pass the 'delegate_options' retrieved in NNAPIDelegateKernel::Init to NNAPIDelegateKernel::BuildGraph where context->allow_fp32_relax_to_fp16 is used, and then use the new option.
add the option to the Java wrapper.
support the option on the tooling side via nnapi_delegate_provider.

I'm happy to review the PRs.

rebased, added an option to NNAPI delegate, changed evaluation tools to use the newly added option by --nnapi_allow_fp16 , and added it to benchmark_model.
I'll send Java related changes in another PR because I don't have good Java development environment to test them now.


Jsoup not retaining &lt in data attributes

Jsoup not retaining &lt in data attributes value if there is <
In the example below < is converted to < in the output after parsing.
Please let me know how to retain it.
Example:
http://notes.io/Gww
@uggedal
@krystiangor
@tc
@bbeck

Can anyone explain why do we parse html entities within org.jsoup.parser.TokeniserState.AttributeValue_doubleQuoted? Shouldn't all quoted values be left unchanged?

@krystiangor
I think the correct fix should be something like below:
I am testing it out to see if it is good in all scenarios. Please let me know your opinion.
case '<':
// xhtml and in attribute
if (inAttribute && escapeMode == EscapeMode.xhtml)
accum.append("<");
// NOT in attribute
else if (!inAttribute)
accum.append("<");
// NON XHTML  and In attribute
else
accum.append(c);
break;

Tests run: 11, Failures: 3, Errors: 0, Skipped: 1, Time elapsed: 0.107 sec <<< FAILURE!
testOutputEncoding(org.jsoup.nodes.DocumentTest)  Time elapsed: 0.004 sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<...p title="π">π & [<] > </p>> but was:<...p title="π">π & [<] > </p>>

It took me a while to understand this -- the allowed characters in an XML attribute are different to HTML
HTML: https://html.spec.whatwg.org/multipage/syntax.html#attributes-2
XML: http://www.w3.org/TR/xml/#NT-AttValue


Test runner fails when no java opts are specified

While helping out with editing poly docs, I decided to give the external test runner a whirl.
Working from the poly example tutorial project, if I configure the external test runner as described in the README and then run:
clojure -M:poly test

I get:
Projects to run tests from: command-line

Could not create valid test runner for the command-line project: java.lang.NullPointerException: Cannot invoke "java.lang.CharSequence.length()" because "this.text" is null
Cannot invoke "java.lang.CharSequence.length()" because "this.text" is null

The fact that poly is swallowing the stack trace doesn't help much, but I found if I provide some java opts:
POLY_TEST_JVM_OPTS=-Dfoo.bar=true clojure -M:poly test

All seems good:
Projects to run tests from: command-line

Running tests for the command-line project using test runner: Polylith org.corfield.external-test-runner...
Running tests from the command-line project, including 2 bricks: user, cli

Testing se.example.cli.core-test

Ran 1 tests containing 1 assertions.
0 failures, 0 errors.

Test results: 1 passes, 0 failures, 0 errors.

Testing se.example.user.interface-test

Ran 1 tests containing 1 assertions.
0 failures, 0 errors.

Test results: 1 passes, 0 failures, 0 errors.

Execution time: 1 seconds

Seems like the current code might be assuming java opts are always set?
https://github.com/seancorfield/polylith-external-test-runner/blob/5a4518dd310daa5ccf592047d3e770df1c375f2b/components/external-test-runner/src/org/corfield/external_test_runner/core.clj#L107

Nice catch! I've never run it without at least some JVM options... oops!

Try:
io.github.seancorfield/polylith-external-test-runner
{:git/tag "v0.3.0" :git/sha "9f6391a"
 :deps/root "projects/runner"}

Thanks @seancorfield, 0.3.0 fixes the issue for me!


jsx-indent behaving badly

The jsx-indent rule is misbehaving when functional component arguments are not on one line.
working correctly:
const Component = ({one, two, three}) => (
  <Foo>
    <Bar/>
  </Foo>
)

Not correct (adding additional indent in JSX):
const Component = ({
  one,
  two,
  three
}) => (
    <Foo>
      <Bar/>
    </Foo>
)

The above needs to happen when the arguments are many and extend over 120 characters.
.eslintrc
{
  "parser": "babel-eslint",
  "extends": "airbnb",
  "plugins": [
    "react",
    "react-hooks"
  ],
  "env": {
    "node": true,
    "es6": true,
    "browser": true,
    "jest": true
  },
  "rules": {
    "max-len": ["error", 120],
    "consistent-return": 0,
    "class-methods-use-this": 0,
    "import/prefer-default-export": 0,
    "no-unused-expressions": ["error", { "allowShortCircuit": true }],
    "no-param-reassign": ["error", { "props": false }],
    "camelcase": "warn",
    "no-underscore-dangle": "warn",
    "newline-before-return": "warn",
    "object-curly-newline": 0,
    "no-bitwise": 0,
    "no-restricted-syntax": 0,
    "arrow-parens": ["error", "as-needed", { "requireForBlockBody": true }],

    "react/jsx-filename-extension": 0,
    "react/jsx-sort-props": "warn",
    "react/no-unescaped-entities": 0,
    "react/prefer-stateless-function": "warn",
    "react/forbid-prop-types": 0,
    "react/destructuring-assignment": 0,
    "react/jsx-one-expression-per-line": 0,
    "react/state-in-constructor": ["warn", "never"],
    "jsx-a11y/no-static-element-interactions": 0,
    "jsx-a11y/anchor-is-valid": 0,
    "jsx-a11y/mouse-events-have-key-events": 0,

    "jsx-a11y/label-has-associated-control": [ "error", {
      "required": {
        "some": [ "nesting", "id"  ]
      }
    }],
    "jsx-a11y/label-has-for": [ "error", {
      "required": {
        "some": [ "nesting", "id"  ]
      }
    }],
    "import/no-extraneous-dependencies": [
      "error",
      {
        "devDependencies": true,
      }
    ],
    "import/no-unresolved": "off",
    "react-hooks/rules-of-hooks": "error",
    "react-hooks/exhaustive-deps": "warn"
  }
}

Could be that my eslint config is incorrect. Any help would be muchly appreciated.

Also potentially a bug.

Any updates?

nope, it has "help wanted" which means it's awaiting a PR.

I tried to replicate the same piece of code and it worked for me. @SirCameron do you have Prettier installed by chance? I wonder if that what was causing the indent to move. I removed Prettier and it seemed fine.
const Component = ({one, two, three}) => (   <Foo>     <Bar/>   </Foo> )

When using prettier, you also need to use eslint-config-prettier (and their /react config) to disable conflicting rules, including jsx-indent.
Closing until the OP confirms the problem still exists.

May I try to solve this bug?

@Moong0122 it's not clear this is a bug, but if you can provide failing test cases, that'd be great.


Add skip parameter to the InsistentInputStream streamBuilder

Changes the streamBuilder function accepted by the InsistentInputStream to be a (skip: Long) => InputStream function.
This allows us to create more efficient input streams in some cases where the inner input stream cannot skip efficiently, but can be created with an initial offset. For example, to stream data from an HTTP URL:
def stream(url: String): InputStream = {
  val builder = (skip: Long) => {
    val connection = new URI(url).toURL.openConnection().asInstanceOf[HttpURLConnection]
    if (skip > 0) connection.setRequestProperty("Range","bytes="+skip+"-")
    connection.getInputStream
  }
  new InsistentInputStream(builder)
}

This LGTM! Can you just add tests for this new behavior?


CSharp Client "Content-Disposition"-Header in request is generated invalid

I generated a CSharp openApi client with a file upload to support chunked file uploads.
The CSharp client-generated Content-Disposition is not inserted into the request header as expected.
It seams to be dropped by request_.Headers.TryAddWithoutValidation(..., by replacing it with request_.Headers.Add(... throws an AggregateException.
System.AggregateException: "One or more errors occurred. (Misused header name, 'Content-Disposition'. Make sure request headers are used with HttpRequestMessage, response headers with HttpResponseMessage, and content headers with HttpContent objects.)"
Example OpenAPI Part of for endpoint:
"post": {         "summary": "Upload file segments.",         "operationId": "Endpoints_TestContentDispositionHeader",         "parameters": [{                 "name": "Content-Disposition",                 "in": "header",                 "description": "Name of attachment",                 "required": true,                 "schema": {                   "type": "string"                 },                 "example": "attachment; filename='file.ext'"             },             {                 "name": "X-Session-ID",                 "in": "header",                 "description": "Session ID",                 "required": true,                 "schema": {                 "type": "string"                 },                 "example": 123456789             },             {                 "name": "X-Content-Range",                 "in": "header",                 "description": "Byte Range of uploaded segement (segmentStart-segmentEnd/totalFileSize)",                 "required": true,                 "schema": {                     "type": "string"                 },                 "example": "bytes 0-10000/200000"             }],         "requestBody": {             "description": "Segment of the file, corresponding to the range that was specified in \"X-Content-Range\" headers ",             "content": {                 "application/octet-stream": {                 "schema": {                     "type": "string",                     "format": "binary"                 }                 }             }         },         "responses": {           "200": {             "description": "The comparison result.",             "content": {               "application/json": {                 "schema": {                   "type": "string"                 }               }             }           }         }       }

well, it's not affecting only Content-Disposition header, but rather all content related headers. Generated client code is trying to add content headers into HttpRequestMessage.Headers collection, which takes no real effect.  Content headers should be added into HttpRequestMessage.Headers.Content.Headers collection:


Spread Attributes / Functional Update Syntax

Original issue: https://github.com/stoically/syn-rsx/issues/27

JSX is
 (https://zhenyong.github.io/react/docs/jsx-spread.html#spread-attributes)

Yew went with
, inspired by Rust's functional update syntax (https://doc.rust-lang.org/stable/reference/expressions/struct-expr.html#functional-update-syntax)

This might already be possible with the transform_block configuration, but not exactly sure yet.

The proposed solution:
Use syntax ...spread as in JS. But don't enforce user to use braces {}.
Expect to have spread syntax only at end of attributes declaration.
Motivation:
The syntax ... was used in rust before, as inclusive range, but for now it is kept unused.
So it is impossible to find ... in valid rust expressions, thats why using braces is not necessary.
Also, if someone want to implement spread syntax as {...foo} it will be available using transform_block feature.
The yew syntax ..foo is conflicting with our attribute parsing, and can't be supported atm.
On other hand<EMAIL_ADDRESS>at its current form detect .. as part of range expression.
We using syn to parse attribute value, so using spread syntax after attribute value is imposible (example: foo="bar" ...spread is invalid)
Thats why we limit ...spread syntax to only apear at end of attributes declaration.
Examples:
Examples of some cases that would and wouldn't parse as spread syntax
❌ attribute x=y is not expected after spread syntax

❌ spread syntax should contain 3 dots, this syntax would be treated as range expression

✅ Spread syntax at end is valid, even if it is formatted incorrectly

<Baz ...spread />

Limitations:
At MVP, i propose to only support one apearance of spread syntax.


Prepare and ship release 1.1.3

Tasks

[ ] Create a branch release/1.1.3
[ ] Enter Code name into file doc/changes_1.1.3.md, proposal: Remove transitive dependency junit:junit
[ ] Enter current date into file doc/changes_1.1.3.md
[ ] commit
[ ] get approval by reviewers
[ ] merge

Release is performed automatically by GitHub workflows

Last release attempt failed as code name had been missing in file dic/changes/changes_1.1.3.md:
E-PK-CORE-197: Code name in '/home/runner/work/maven-plugin-integration-testing/maven-plugin-integration-testing/doc/changes/changes_1.1.3.md: https://github.com/exasol/maven-plugin-integration-testing/actions/runs/9402967881/job/25898327362


Implementation of the intermediate representation

This includes the definition (and in-code documentation) for the intermediate representation as well as a transpiler for emitting it into a text file in a human-readable format.
Closes #8.

Coverage decreased (-1.2%) to 72.155% when pulling ff20f2624c8e775595657e1da5edc7f8080503de on issue/8 into f55ffde891f3ba8e85369065d2161b6461515309 on master.


Ability to conditionally set sveltekit:noscroll

Describe the problem
I have a component that renders an anchor with other elements inside. I originally needed the sveltekit:noscroll attribute set in all cases, but I recently ran into a scenario where I didn't want sveltekit:noscroll to be defined on the anchor element. I discovered that there is no way (that I could tell) to conditionally disable the sveltekit:noscroll attribute in that one case. Looking at the code, it seems to check for the existence of the attribute only, instead of optionally checking its value.
Describe the proposed solution
I would like to be able to use sveltekit:noscroll with an optional value -
This would still work:

This would also work:

Alternatives considered
The alternative is that I have to either make an exact copy of the component except without the sveltekit:noscroll, or remove the anchor and create two new parent components, one with and one without noscroll. These aren't deal breakers, but it is unnecessarily chatty for just wanting to make an attribute conditional.
Importance
nice to have
Additional Information
No response

You can do this like you'd conditionally set any attribute on an element in Svelte (that the browser doesn't recognize as a known boolean attribute) - sveltekit:noscroll={noscroll || null}.

 I assumed false would behave the same way. It never occurred to me to use null or undefined. Thanks a bunch for the help!


Make an error instead of a warning when a chart is in requirements.yaml but not in the charts/ directory!

I'm developing the rocket.chat chart.
So, in the mean time, I'm installing/upgrading it with the relative path.
This morning, I wanted to update the docker image to latest.
I got a little warning:
Warning: mongodb is in requirements.yaml but not in the charts/ directory!

As usually, I safely ignored the warning. What a mistake this time!
If you know helm better than I do, you already know what happened, it deleted my mongodb... with the attached volume... then I had to restore a snapshot, but still lost some data on the way.
I was really surprised that a warning had such an unattended effect.
I'd like to warn other people, and maybe propose to print an error and exit in such a scenario. I don't see any reason why somebody would want to deploy something without the dependencies. Or even worst, remove the dependency and its data during an upgrade.

Marked this as a starter. I think it's safe to do this one.


how can i integrate for flutter web?

No. The way this plugin was created, cannot be implemented for web.

Any other method or other way available ?

Use payment gateways

How can other websites are using upi payments without gateways?. Their might be a way available without payment gateways.

I don't think you can do that. As far as I know all use some kind of payment gateway may it be paytm, paypal or razorpay. If you want to create a complete payment solution yourself check this: https://stackoverflow.com/questions/2647430/building-a-complete-online-payment-gateway-like-paypal/2652309#2652309


⚠ Bofrost.nl has degraded performance

In 9382cdd, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 998 ms

Resolved: Bofrost.nl performance has improved in 8ef893c.


Google Policy Issue

Can you authenticate google account? I had tried your samples, it was okay long time ago when you released first commit. But unfortunately right now I can't do that again. It seems google has new policy for web view. When I tried to authenticate my firebase using google got this message
403 Error

"This user-agent is not permitted to make OAuth authorisation request to Google as it is classified as an embedded user-agent (also known as a web-view). Per our policy, only browsers are permitted to make authorisation requests to Google. We offer several libraries and samples for native apps to perform authorisation request in browser."

Hi,
Thanks for reporting this.
I just tried the following on my live version of PizzaApp.

I relogged with my Google Apps account (which is the same as Gmail), had no problem.
I deleted my account from the Firebase console and signed up fresh and still no issues.

You can try the following:
In StageWebView/Feathers WebView there's a setting to use the native web view or the built in from AIR. Try setting that to true and false to see if there's any difference.

Hi,
Have you read this? https://www.theregister.co.uk/2016/08/23/google_to_block_web_views_from_using_its_oauth/
Even though I followed your example in Auth section, the problem still hasn't been solved yet. But when I copied url of webview.location in function changeLocation() to chrome, authentication UI showed off.
https://github.com/PhantomAppDevelopment/firebase-as3/tree/master/auth
I think google only allows access the url only from browser to provide security.

I did read the post from the google dev blog and they mentioned they won't allow generic web views but you can still use native web views (which AIR provides).
Try to debug on your phone on both native and non native web views to see if there's any difference since the user agent is different there.
I also have been using the latest versions of AIR. You can try using the just released version 25.
You can go further and try the apk from the Releases tab in the PIzzaApp repository. That version is not linked to the PlayStore.

I just gave it a try in a new app.
In new apps it doesn't work at all, it only works on old apps and it's very likely to break in the next weeks.
I tried setting a different userAgent, changing to native and non native but nothing worked. The only thing to do is not to use Google login for the meantime.
I researched what have the AIR competitors done (Cordova, Ionic, Xamarin) and they opted to follow Google's guidelines with their equivalent of ANEs.

But we can use e-mail/password connections ?

Yes, Email with Pass, Anonymous should work with no problem since they tied directly with Firebase.
Facebook and Twitter should work fine for the time being.
I was thinking that there may be a simple fix for Google. I will investigate about custom URI schemas in AIR.

Thanks you😀
Le 17 mars 2017 00:34, "Mr. Phantom"<EMAIL_ADDRESS>a écrit :

Yes, Email with Pass, Anonymous should work with no problem since they
tied directly with Firebase.
Facebook and Twitter should work fine for the time being.
I was thinking that there may be a simple fix for Google. I will
investigate about custom URI schemas in AIR.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/PhantomAppDevelopment/firebase-as3/issues/10#issuecomment-287224358,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMYpy_hr9IVdbM9FMB8Vsvh6Jer8AHeuks5rmccOgaJpZM4Md89W
.

Good news.
I was able to implement one of the new methods Google suggests.
You can check it here:
https://github.com/PhantomAppDevelopment/socialmedia-as3/tree/master/google
If it works for you I can try and port it so it can work with Firebase.

I tried on mobile device. Still doesn't work. Seems google taking seriously this webview issue.

Thanks for reporting back.
In which mobile device do you tried?
I had success with an Android 5.1 on AIR 25.


Parse all tokens from document in sway-lsp

Currently, when a document is opened in VScode, the editor sends the text to the server which then parses it to collect the Tokens. In sway-lsp we have a Vec<Token> that is populated by matching on the parsed result returned from the parse() fn in sway-core which is a SwayParseTree. We can then access each individual AstNode by looping over the sway_parse_tree.tree.root_nodes.
The content field in AstNode can be either:
pub enum AstNodeContent {
    UseStatement(UseStatement),
    ReturnStatement(ReturnStatement),
    Declaration(Declaration),
    Expression(Expression),
    ImplicitReturnExpression(Expression),
    WhileLoop(WhileLoop),
    IncludeStatement(IncludeStatement),
}

At the moment, we are only matching on the Declaration and Expression variants. There are further variants within those enums that are also not getting matched on. For example, we are not parsing the following Declaration variants.
Declaration::ImplTrait,
Declaration::ImplSelf,
Declaration::AbiDeclaration,
Declaration::ConstantDeclaration,
Declaration::StorageDeclaration,

In relation to Expression, we are matching on CodeBlock and FunctionApplication but are ignoring all of the following.
Expression::Literal,
Expression::LazyOperator,
Expression::VariableExpression,
Expression::Tuple,
Expression::StructExpression,
Expression::IfExp,
Expression::MatchExp,
Expression::AsmExpression,
Expression::MethodApplication,
Expression::SubfieldExpression,
Expression::DelineatedPath,
Expression::AbiCast,
Expression::ArrayIndex,
Expression::DelayedMatchTypeResolution,
Expression::IfLet,
Expression::SizeOfVal,
Expression::SizeOfType

I ended up looking at this section of the code when trying to understand why rust-analyzer was providing richer information regarding the same test file. It seems a good starting point before working on testing the current capabilities is to catch more of these unimplemented variants.
@leviathanbeak did you have any thoughts on this?

I started from the most basic ones and many of them were not even offered at that time.
Each of these could now be a ticket in itself - this issue could offer a starting point for the next feature implementation.

This has mostly been solved in #2121. Going to close for now and will reopen smaller issues if we notice that certain tokens aren't being collected by the server.


Upgrade org.pitest:pitest-maven 1.13.1 -> 1.13.2

This PR contains the following updates:

Package
Type
Update
Change

org.pitest:pitest-maven (source)
build
patch
1.13.1 -> 1.13.2

Release Notes

hcoles/pitest
v1.13.2
Compare Source

#638  Ensure % shows as 100 when all mutants killed (thanks @Vampire)
#1197 Show start up info when logging set to VERBOSE_NO_SPINNER (thanks @Vampire)
#1198 Logging improvements (thanks @Vampire)
#1200 Warn if parallel test execution enabled during coverage collection (thanks @Vampire)
#1199 Switch to System.nanoTime for test timings (thanks @Vampire)
#1207 Support for removal of class level annotations

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade pitest-maven-plugin 1.13.1 -> 1.13.2

See:
- https://github.com/hcoles/pitest/releases/tag/1.13.2
- https://github.com/hcoles/pitest/compare/1.13.1...1.13.2

Version 1.14.0 also LGTM.


How to convert the current time for scheduling?

I want to schedule a Notification with
await AwesomeNotifications().createNotification(
        content: NotificationContent(
          id: 2,
          channelKey: 'scheduled',
          title: "",
          body: "",
        ),
        schedule: NotificationCalendar(
            minute: 19,
            second: 0,
            repeats: true));

but as soon as I specify the hour it doesn't work.
I have tried to convert the desired time to UTC and use that "hour" value, didn't work.
I have tried to convert this UTC back to local and use its "hour", also didn't work.
So how do I convert the time in order to get it shown at the desired time?

Ok so the problem is that the conversion to UTC doesn't take daylight saving time into account. Is there a way around it?

We use UTC for internal system processment just because it doesnt take daylight saving into account.
Time zones are political and very complex to deal. Take a look at this video to see where the rabbit hole ends:
The Problem with Time & Timezones - Computerphile
Convert your local date into utc and extract the date components from it.

That video is pretty accurate 😆 Ok I'll dig into it.


Enable code syntax highlighting in mock implementation monaco editor

Description

Need to enable JS code highlighting here and better to mention the supported ECMA script version
Steps to Reproduce

Create an API
Choose mock type endpoint on endpoints page

Affected Component
APIM
Version
4.1.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

Re triggered the cypress tests. https://github.com/wso2/apim-apps/pull/422


Positional embedding in based model?

Great work! But I have a question on positional embedding.
I find that there is no positional embedding used in the based model. I wonder if you plan to add positional embedding in the future? And why Based model can outperform Transformer without ROPE (as claimed in the zoloogy blog) ?

Hi thanks for the question -- we used rotary positional embeddings in the reported downstream Pile experiments.


Server continues to try to pair with rejected client?

If we force an auth failure, the server will continue to send heartbeats to the client for some time. The client doesn't know what to do with these:
2022-09-23T14:52:23.130602Z  INFO webrtc_unreliable_client::webrtc::peer_connection: ICE connection state changed: connected
2022-09-23T14:52:23.132988Z  INFO webrtc_unreliable_client::webrtc::peer_connection: peer connection state changed: connected
2022-09-23T14:52:24.087938Z  INFO jernau::networking::client::events: Client was rejected!
2022-09-23T14:52:27.733648Z  WARN webrtc_unreliable_client::webrtc::crates::sctp::association::association_internal: [] unable to parse SCTP packet heartbeat should only have HEARTBEAT param
[ repeat this heartbeat warn on client until the server closes the connection ]

After a bit, the server times out the connection, but then tries to begin a new channel connection. This doesn't work because the client is no longer engaged:
2022-09-23T14:52:23.132703Z  INFO webrtc_unreliable::client: DTLS handshake finished for remote <IP_ADDRESS>:64607
2022-09-23T14:52:23.887893Z  INFO jernau::networking::server::events: auth event!
2022-09-23T14:52:23.888111Z  INFO jernau::networking::server::events: rejected!
2022-09-23T14:52:24.136325Z  INFO jernau::networking::server::events: auth event!
2022-09-23T14:52:24.136591Z  INFO jernau::networking::server::events: rejected!
[ heart beats are still sent here ]
2022-09-23T14:53:00.981007Z  INFO webrtc_unreliable::server: connection timeout for client <IP_ADDRESS>:64607
2022-09-23T14:53:00.981312Z  INFO webrtc_unreliable::server: client <IP_ADDRESS>:64607 removed
2022-09-23T14:53:02.717221Z  INFO webrtc_unreliable::server: beginning client data channel connection with <IP_ADDRESS>:64607
2022-09-23T14:53:41.281051Z  INFO webrtc_unreliable::server: connection timeout for client <IP_ADDRESS>:64607
2022-09-23T14:53:41.281332Z  INFO webrtc_unreliable::server: client <IP_ADDRESS>:64607 removed
2022-09-23T14:53:43.203230Z  INFO webrtc_unreliable::server: beginning client data channel connection with <IP_ADDRESS>:64607

I would expect that a rejection would close to the connection, not send heartbeats, and not attempt to renegotiate with a rejected client.

Yep currently naia works by establishing it's own protocol on top of an established WebRTC data channel. This is not ideal. Authentication should happen before WebRTC establishes a connection, not after. Thank you for the heads up on this :+1:

This was fixed in https://github.com/naia-lib/naia/releases/tag/v0.23.0, where the underlying auth mechanism was adjusted to happen during session signaling, and not after the WebRTC connection was established.


Demo on Heroku is down

This demo
https://hydralit-secure-sample.herokuapp.com/
is not up and running. Maybe you have a link to the streamlit-cloud?

yes it is, the code for it is still available: https://github.com/TangleSpace/hydralit-example


:sparkles: add performance module to quilt_rails

Description
This PR introduces the Rails implementation of @shopify/koa-performance as a module within quilt_rails called Quilt::Performance. Most of the details of how this works can be found in the tests and the documentation.
See the demo branch on web-rails-proving-ground for a working example.

We noticed that this PR modifies the behaviour of CSRF tokens in this application. Our team will take a look soon, but for now please consider what the best CSRF behaviour for your application is. If the controller in question is meant to be used mostly as an API by non-browser clients, a sane option is protect_from_forgery with: :null_session (since APIs don't usually send CSRF tokens or use sessions anyway). If this endpoint is interacted with from a browser (via a form POST or similar), then it is good to use the stricter protect_from_forgery with: :exception. If you'd like to read more about Rails CSRF protection, there's some great Rails documentation on it: https://guides.rubyonrails.org/security.html#csrf-countermeasures.


chore(ci): 合并 changelog 时加上 --squash 将 commit 合并成一个

👀 PR includes

🔧 Chore

[ ] Test case
[ ] Docs / demos update
[x] CI / workflow
[ ] Release version
[ ] Other ()

📝 Description
之前 CI 自动合并时会携带 latest 分支的所有 commit, 不太美观, 虽然合并 pr 的时候会 sequash, 但是 commit 本身还有相关信息

🖼 Screenshot

Before
After

❌
✅

🔗 Related issue link

🔍 Self-Check before the merge

[ ] Add or update relevant docs.
[ ] Add or update relevant demos.
[ ] Add or update test case.
[ ] Add or update relevant TypeScript definitions.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Enforcing HTTPS for /login when no tab/page is set as default login page (default login ctl)

Description
If no Login page is specified in the Page Defaults of Site Settings, DNN uses the core (ctl login state(?)),  to show the account login. By this method, it will allow that login state to display as http even if the rest of the site and pages are set as https. It seems that, in this scenario, the login page falls through the cracks and is not enforced as https.
To clarify, if you have a tab/page with a login module on the page where that tab is set to IsSecure, and within Site Settings that tab is specified as the Login page for the site, then DNN will properly load the http://www.domainname.com/login URL enforced over to https://www.domainname.com/login on page load.
However, if you do not have an actual page set in the SiteSettings, it must be that there is nothing to clarify the IsSecure status and it therefore shows the login state as http.
I feel that if the Site Settings have SSL Enabled and Enforced, then this default view of login should be loaded as https.
Steps to reproduce

In a Portal in which Site Settings have SSL Enabled & SSL Enforced
Within Site Settings > Site Behavior > Default Pages: clear or set the Login Page settings to
Clear cache for good measure
load http://www.domainname.com/login

Current result
http://www.domainname.com/login will load as http even if the Site Settings SSL Settings are set to Enabled & Enforced
Expected result
If there is no specific Login page specified AND Site SSL Settings are set to Enabled & Enforced, the ctl=login state should load as https
Affected version
I have confirmed it affecting 9.1.1, it may affect previous, can test further and confirm...

[x] 9.2
[x] 9.1.1
[ ] 9.1
[ ] 9.0

Affected browser
All (browser inspecific)

[X] Chrome
[X] Firefox
[X] Safari
[X] Internet Explorer
[X] Edge

For anyone reading this, a viable workaround can be to create a custom login page.  Instructions on how to do this can be extracted from the wiki article below.
http://www.dnnsoftware.com/wiki/how-to-ensure-ssl-for-all-authenticated-sessions

Right-o Will! The solution for users setting up their DNN Portals is to make sure that they set each one up with an actual Login page. This is something that we got in the habit of back in the day to help with all the duplicate pages that would get crawled and indexed relating to the

login control
legal text/page control
privacy text/page control
and so we'd setup a page for each manually when setting up every new portal. That, of course, helps in this situation too.

However, for sites where other editors and admin are in charge of adding portals and content, they have an assumption that if they've set and enforced SSL within portal settings, that now the portal will behave by enforcing https in all situations, especially one like the Login screen/control.
My recommendation is that the core needs to be updated so that it can be aware of the setting and serve up the login control according to the portal ssl settings.

Peter Donker has suggested a change to the way that the HTTPS settings in DNN might control the whole of page settings... this might help with this issue
https://github.com/dnnsoftware/Dnn.Platform/issues/2808

In the spirit of cleaning up the backlog and since #2808 looks like the solution to this, I am closing this issue so we have only one to manage for the same problem.


Confusions about Prometheus monitoring

Hey,
I tried to setup monitoring with prometheus now for quite some time and I noticed that there are some things quite confusing and should be streamlined.
Problem in the documentation of the PodMonitor
I'm installing cert-manager via the manifests and not using helm currently. I then tried to use the pod monitor that is documented here: https://cert-manager.io/docs/usage/prometheus-metrics/#regular-manifests
The problem with it is that this resource is referring to the pod's port http but the port 9402 is not labeled with that name. I could solve it by adding the name to the deployment / pod. Not very nice since I can't work with the manifests out of the box.
Why use PodMonitor when helm chart uses ServiceMonitor?
Next thing is that documentation suggests to use a PodMonitor resource instead of a ServiceMonitor which will be deployed when setting prometheus.servicemonitor.enabled to true. The service itself is also only deployed when prometheus.enabled is set to true. In the manifests the service is also deployed so I see no reason why we should use the PodMonitor for manifests deployment and ServiceMonitor for helm deployment.
Any best practice / recommendation about how it should look like? In my opinion the same type of monitoring should be used regardless of how the deployment is done. So i'd vote for the service monitor approach and to fix documentation or just put the service monitor manifest into the repo itself.

I found the same issue this morning with the manifests.  Setting the cert-manager deployment port name to http also resolved the issue for me.  Without this the PodMonitor doesn't match the  endpoint.

@r0bnet if you open port forwarding to the cert-manager-controller on port 9402, do you see metrics?
I deployed cert-manager same as you, using manifests, but I'm not able to get metrics out of it...
running this command
kubectl port-forward pod/cert-manager-... 9402
then opening a browser tab or running curl
curl http://localhost:9402/metrics
I receive a completely empty response :(
Thanks in advance for any suggestion!

@bygui86 sorry for my late reply. I'm getting the metrics if I'm doing the same as you mentioned before. Output looks like this (redacted):
$ kubectl port-forward cert-manager-... 9402
$ curl localhost:9402/metrics
# HELP certmanager_certificate_expiration_timestamp_seconds The date after which the certificate expires. Expressed as a Unix Epoch Time.
# TYPE certmanager_certificate_expiration_timestamp_seconds gauge
certmanager_certificate_expiration_timestamp_seconds{name="xxx",namespace="xxx"} 1.610458124e+09
certmanager_certificate_expiration_timestamp_seconds{name="xxx",namespace="xxx"} 1.610285646e+09
certmanager_certificate_expiration_timestamp_seconds{name="xxx",namespace="xxx"} 1.612617036e+09
[...]

@r0bnet no worries, I found out my mistake! or better my "misassumption"...
right after startup, cert-manager DOES EXPOSE METRICS, but simply there are NO METRICS to be returned.
All metrics are initialized just at the first increment/usage.
So instead of having a bunch of metrics all with values 0 (zero), there are no metrics returned.
After couple of test issuing self-signed certificates and let's encrypt signed certificates, I got some metrics!
Anyway your initial issue is right:

why use PodMonitor instead of ServiceMonitor?
that section of documentation is a bit out of sync in respect to the rest of the repo/doc

I think the both questions can be answered by: docs got a bit out of date, many parts of our monitoring stack in the Helm chart are external PRs made an I think we overlooked the docs a bit. PRs welcome there!

/kind documentation
I'll close this issue, but  please contribute improvements to the documentation of cert-manager monitoring at https://github.com/cert-manager/website if you have time. I'll help with reviews etc.
/close

/kind documentation
I'll close this issue, but  please contribute improvements to the documentation of cert-manager monitoring at https://github.com/cert-manager/website if you have time. I'll help with reviews etc.
/close


create a search results page

Hey, can you provide more details

This is just a project for a Uni course so we dont need any help


ValueError: This model does not support image input.

Reminder

[X] I have read the README and searched the existing issues.

System Info

llamafactory version: 0.9.2.dev0
Platform: Linux-6.1.85+-x86_64-with-glibc2.35
Python version: 3.10.12
PyTorch version: 2.3.1+cu121 (GPU)
Transformers version: 4.46.1
Datasets version: 3.1.0
Accelerate version: 1.0.1
PEFT version: 0.12.0
TRL version: 0.9.6
GPU type: Tesla T4
Bitsandbytes version: 0.45.0

Reproduction
models: unsloth/Llama-3.2-11B-Vision-Instruct, meta-llama/Llama-3.2-11B-Vision-Instruct
The colab example provided is also failing
ValueError: This model does not support image input.
Traceback (most recent call last):
  File "/usr/local/bin/llamafactory-cli", line 8, in <module>
    sys.exit(main())
  File "/content/LLaMA-Factory/src/llamafactory/cli.py", line 112, in main
    run_exp()
  File "/content/LLaMA-Factory/src/llamafactory/train/tuner.py", line 50, in run_exp
    run_sft(model_args, data_args, training_args, finetuning_args, generating_args, callbacks)
  File "/content/LLaMA-Factory/src/llamafactory/train/sft/workflow.py", line 101, in run_sft
    train_result = trainer.train(resume_from_checkpoint=training_args.resume_from_checkpoint)
  File "/usr/local/lib/python3.10/dist-packages/transformers/trainer.py", line 2122, in train
    return inner_training_loop(
  File "/usr/local/lib/python3.10/dist-packages/transformers/trainer.py", line 2426, in _inner_training_loop
    batch_samples, num_items_in_batch = self.get_batch_samples(epoch_iterator, num_batches)
  File "/usr/local/lib/python3.10/dist-packages/transformers/trainer.py", line 5038, in get_batch_samples
    batch_samples += [next(epoch_iterator)]
  File "/usr/local/lib/python3.10/dist-packages/accelerate/data_loader.py", line 550, in __iter__
    current_batch = next(dataloader_iter)
  File "/usr/local/lib/python3.10/dist-packages/torch/utils/data/dataloader.py", line 631, in __next__
    data = self._next_data()
  File "/usr/local/lib/python3.10/dist-packages/torch/utils/data/dataloader.py", line 675, in _next_data
    data = self._dataset_fetcher.fetch(index)  # may raise StopIteration
  File "/usr/local/lib/python3.10/dist-packages/torch/utils/data/_utils/fetch.py", line 54, in fetch
    return self.collate_fn(data)
  File "/content/LLaMA-Factory/src/llamafactory/data/collator.py", line 163, in __call__
    features = super().__call__(features)
  File "/content/LLaMA-Factory/src/llamafactory/data/collator.py", line 107, in __call__
    fake_messages = self.template.mm_plugin.process_messages(fake_messages, fake_images, [], self.processor)
  File "/content/LLaMA-Factory/src/llamafactory/data/mm_plugin.py", line 210, in process_messages
    self._validate_input(images, videos)
  File "/content/LLaMA-Factory/src/llamafactory/data/mm_plugin.py", line 76, in _validate_input
    raise ValueError("This model does not support image input.")
ValueError: This model does not support image input.

My Custom dataset does not have images also i tries using dataset in colab example still same issue dataset="identity,alpaca_en_demo",
chat template mllama is throwing same error
Expected behavior
No response
Others
No response

please use correct template https://github.com/hiyouga/LLaMA-Factory/issues/4614

please use correct template #4614

@hiyouga  this issue is in both templates llama3 & mllama for the above models

@hiyouga  v0.9.1 is working with existing code


Allow to create a new value based on a list of unions

Allow to create a new value based on a list of unions as long as they contain the same type

is there a unit test you can create/update?

unionlist should be:
l := b.LeafList(m, "l")
dt := b.Type(l, "union")

constructor is private but even if public, wouldn't get you far because a lot of private fields.

I tried the following code as a test but it doesn't work
func TestToUnionList(t *testing.T) {
	b := &meta.Builder{}
	m := b.Module("x", nil)
	l := b.LeafList(m, "l")
	dt := b.Type(l, "union")
	if err := meta.Compile(m); err != nil {
		t.Error(err)
	}
	v, err := NewValue(dt, []int{1, 2})
	if err != nil {
		t.Error(err)
	} else if sl := v.Value().([]int); sl[0] != 1 || sl[1] != 2 {
		t.Errorf("Coersion error: %v", sl)
	}
}

=== RUN   TestToUnionList
value_test.go:61: x/l - unions need at least one type
value_test.go:65: could not coerce [1 2] into UnionList

i'll take a look at this tomorrow

i did look at this and unions are bit more complicated then I realized. this will take me a few more days.

I think this pull-request should be closed...


Segmentation GeoJSON should contain human-readable filename

No-op, only for informational purpose.

Once implemented, this TODO should also be resolved: https://github.com/ssciwr/adaptivefiltering/blob/main/adaptivefiltering/execute.py#L122

I am not sure what you mean by filename, I would just use the filter title as a filename.


Navbar color change

Looks like you have two "Contribution Rules" sections in index.html and i'm not sure the color change had any effect? 😃 here is a live version of this pr so fare https://lingonsaft-hacktober-gvccmzlhkd.now.sh/


Capturing Line and Position when querying

I am using the pboettch/json-schema-library for validation. When an error is found it does not print the line and position where the anomaly was found. While line and position are printed when anomalies are found when reading the JSON string in your library, are the line and character position stored afterwards so the validator error message can include this information? I have not found this looking at the documentation. If it is there, how would the information be accessed?
We will need this on Linux, Windows and Mac.  I am using version 3.7.0.

This information cannot be accessed after parsing.


Bitmap Subtitle is displaying middle of the screen

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
2.5.9
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Own custom app
If custom app, can you reproduce the issue using our demo app?
Yes, able to reproduce issue in demo app
What browser and OS are you using?
Chrome and Mac
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?

What did you do?

Play a content which has bitmap based subtitle
What did you expect to happen?
Subtile should not display middle of the screen
What actually happened?

Subtile is displaying middle of the screen. After investigation I found
Below is sample for subtitle segment
<layout> 	<region tts:extent="100.00% 20.67%" tts:origin="0% 78%" xml:id="region0"/> 	<region tts:extent="100.00% 6.76%" tts:origin="0% 86%" xml:id="region1"/> </layout>
In /lib/text/ttml_text_parser.js
parseCueRegion_ function
percentage = TtmlTextParser.percentValues_.exec(extent);
shaka.text.TtmlTextParser.percentValues_ =
/^(\d{1,2}(?:.\d+)?|100)% (\d{1,2}(?:.\d+)?|100)%$/;
percentValues_ regex there is no support for decimal point for 100

What are the manifest and license server URIs?

You skipped this question.  Without a sample, we will be unable to reproduce your issue or work on a fix.

@joeyparrish Thanks for quick reply.
I will share manifest url soon.

@joeyparrish Do you have an email where i can send the manifest url "

Hello @kumarashu123 , you can send it to<EMAIL_ADDRESS>.

Hi @joeyparrish,
I will be mailing you the manifest URL.
Summarizing the issue,
This is the  we are getting in the manifest:

And in ttml_text_parser.js, we parse this  with the following regex:
shaka.text.TtmlTextParser.percentValues_ = /^(\d{1,2}(?:.\d+)?|100)% (\d{1,2}(?:.\d+)?|100)%$/;
As you can see above, this regex works fine for "100%", but not for "100.00%", as given in the  example above.
Proposed fix:
/^(\d{1,2}(?:.\d+)?|100(?:.0+)?)% (\d{1,2}(?:.\d+)?|100(?:.0+)?)%$/

@kumarashu123, since you already have a fix, I've gone ahead and marked this as a bug and added the "help wanted" label.  Please send a PR with your fix.  Thanks so much!

@joeyparrish I have sent the manifest URL to<EMAIL_ADDRESS>


ERR Cannot read properties of undefined (reading 'dragStartDisposable')

Found this in devtools, I played a bit with settings:
ERR Cannot read properties of undefined (reading 'dragStartDisposable'): TypeError: Cannot read properties of undefined (reading 'dragStartDisposable')
    at ListView._splice (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/list/listView.js:334:22)
    at ListView.splice (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/list/listView.js:319:29)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/list/splice.js:14:45
    at Array.forEach (<anonymous>)
    at CombinedSpliceable.splice (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/list/splice.js:14:30)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/list/listWidget.js:1105:67
    at EventBufferer.bufferEvents (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:939:23)
    at TreeNodeList.splice (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/list/listWidget.js:1105:32)
    at TreeNodeList.splice (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/tree/abstractTree.js:1075:19)
    at IndexTreeModel._setListNodeCollapseState (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/tree/indexTreeModel.js:266:23)
    at IndexTreeModel._setCollapseState (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/tree/indexTreeModel.js:237:33)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/tree/indexTreeModel.js:233:63
    at EventBufferer.bufferEvents (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/event.js:939:23)
    at IndexTreeModel.setCollapsed (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/tree/indexTreeModel.js:233:39)
    at ObjectTreeModel.setCollapsed (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/tree/objectTreeModel.js:155:31)
    at TOCTree.collapseAll (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/browser/ui/tree/abstractTree.js:1353:24)
    at SettingsEditor2.triggerSearch (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/preferences/browser/settingsEditor2.js:1089:34)
    at SettingsEditor2.onSearchInputChanged (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/preferences/browser/settingsEditor2.js:1032:24)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/workbench/contrib/preferences/browser/settingsEditor2.js:383:60
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode/out/vs/base/common/async.js:276:32

@rzhao271 Let me know if you can repro and find out the issue is deep in the list/tree.

@rzhao271 Got you repro steps!

Make the workbench window rather small.
Go into 2x2 editor layout, so you get even smaller editors
Press Cmd , to open the Settings Editor in one of the editor groups
Search for sash
Press Cmd W to close the Settings Editor

🐛 That exception shows up!
https://github.com/microsoft/vscode/assets/22350/c5e21e7c-f3b2-4325-9414-358b77598b72


Config file clarification

Maybe it's just because I'm tired, but it took me a long time to figure out that if you're only defining one bot in the config file, don't forget to take it out of the object brackets that the example includes. For example:
{
    "nickname": "test2",
    "server": "irc.testbot.org",
    "token": "slacktoken2",
    "channelMapping": {
      "#other-slack": "#new-irc-channel"
    }
}

instead of
[
  {
    "nickname": "test2",
    "server": "irc.testbot.org",
    "token": "slacktoken2",
    "channelMapping": {
      "#other-slack": "#new-irc-channel"
    }
  }
]

Maybe a little wiki clarification? If not, at least this is documented so some poor soul doesn't pull their hair out all night.

Hi! Were you looking at the example on the wiki? I've removed it now, as it hasn't been kept up to date, like the one in the README, here: https://github.com/ekmartin/slack-irc#example-configuration
If you have any suggestions towards making it more readable they're more than welcome.
I think you may have met some other issue while testing though, because having array brackets around a single configuration will work just the same as without them. Do you have an error output I can look at?

Funny enough I cannot reproduce the error anymore. You can probably close this :)

Glad you got it working, feel free to reopen if you manage to reproduce the error later.


Basically finished class 6

closes #5
I'm not quite sure why it doesn't let me automatically merge.
Moreover, there's a file needed for the class's exercise which I can't find anywhere... some 311.zip file... know anything about it?

Sorry, can't seem to spot the 311.zip file anywhere. @HagaiHargil do you happen to have a copy of it lying around?
Also, there's a conflict in the introduction's file. @GalBenZvi do you mind resolving it and pushing again?

@ZviBaratz There's a link in assignment 4. It's a zipped CSV file.


Adding tfvars to Vale vocab

What changed, and why it matters
tfvars is a specific file extension for Terraform. Requesting to add this word to Vale's accept.txt for builds to pass.

Where are we using tfvars as a word rather than in code/literal markup? @TibsAtWork will probably chime in but if it's not an English word (or technical term or prooper noun that we use), then it shouldn't be in accept.txt most of the time.

I agree with Lorna.
The accept.txt file is a very blunt stick, and we'll be changing approach soon anyway, to a proper dictionary approach.
That makes me want to keep the dictionary for actual words, and anyway I think I'd be marking things like this up as
``tfvars``

in reStructuredText (the equivalent of tfvars) to indicate they're a technical artefact (the same way I'd talk about .txt files).

Thanks for the suggestion @lornajane & @TibsAtWork
I've fixed the original PR using tfvars and am closing this PR as this is no longer required.


account_tx doesnt return data on my node in testnet

requesting account_tx with:
address rU28T5aeXcDCup9eZH2aBWkb1wyqEqYgKV
forward true
https://s.altnet.rippletest.net:51234 returns 6 txs
my node response:
{"result":{"account":"rU28T5aeXcDCup9eZH2aBWkb1wyqEqYgKV","ledger_index_max":6759348,"ledger_index_min":6756959,"limit":0,"status":"success","transactions":[]}}

Check which ledgers those transactions are in (you can look for the ledger_index field in the results). Your node only has ledgers 6756959-6759348. If all of those transactions are outside that range (specifically before 6759348), you're node is not going to have them. Some of the nodes on the altnet have older ledgers, so you can wait for yours to backfill, BUT note that the altnet nodes intentionally do not keep a lot of history, so I can't make any promises. (This is not the case on the production network, where there are several "full history" nodes that serve old ledgers.)

@ximinez i started my node about 3 weeks ago. Why there is no history transaction on it? How to download it?

It comes down to how you've got the node configured. By default, you're going to have a decent amount of history, but not everything. You might want to look at your settings for online_delete, advisory_delete, and ledger_history. If you make changes, you'll need to restart.
Another possibility is that your settings are fine, but your node does not have the extra bandwidth and/or processing power to get ahead enough to request historical ledgers so it can backfill.

@ximinez
i set
full

...
advisory_delete=0
online_delete=0```

also tried online_delete=100000000
but looks like now delete everything but last ledger.
how to disable data deleting?
i need full history node.

If you want full history, your best bet is to remove or comment out online_delete entirely


Support for approxEqual

Hi!
As far as I can tell, it seems like we cannot currently evaluate if two DenseMatrix instances are approximately equal without stepping through some extra hoops.  For instance:
scala> val a = accumulate(DenseVector(1/5D, 2/5D, 3/5D))
a: breeze.linalg.DenseVector[Double] = DenseVector(0.2, 0.6000000000000001, 1.2000000000000002)

scala> a == DenseVector(0.2D, 0.6D, 1.2D)
res9: Boolean = false

It would seem to me that this should return true, or we should be able to do something like:
a approxEquals(1e-6) DenseVector(0.2D, 0.6D, 1.2D)
or
a approxEquals DenseVector(0.2D, 0.6D, 1.2D)
or
a === DenseVector(0.2D, 0.6D, 1.2D)

I would be happy to submit a PR to add an approximate equal method or otherwise address this issue if approximate equality testing isn't already supported, but I'd need a bit of guidance on the best way to implement it.

bump
I plan to close this issue in a couple days if there are no comments, as I'm assuming that means there is not enough interest for it.

bleh sorry, missed it.
Breeze has breeze.linalg.isClose(dv1, dv2[, optional tolerance]) already.
I'd be on board with adding a =~= or ≈ operator or something like it.
On Wed, Mar 9, 2016 at 4:28 PM, Alex Gaudio<EMAIL_ADDRESS>wrote:

bump
I plan to close this issue in a couple days if there are no comments, as
I'm assuming that means there is not enough interest for it.
—
Reply to this email directly or view it on GitHub
https://github.com/scalanlp/breeze/issues/501#issuecomment-194587536.

Ah thank you for this!  Rather than add a redundant operator, I'll added isClose to the wiki documentation:  "Reduction UFuncs" page in https://github.com/scalanlp/breeze/wiki/Universal-Functions.

In case it's helpful to anyone in the future, I found that there is a closeTo for Doubles defined in a couple places
source code for a rich double implicit:
import breeze.util.Implicits._
1D.closeTo(1.00001)  // --> true

breeze.numerics package also defines closeTo for double:
import breeze.numerics.closeTo
closeTo(1D, 1.00001)

lol, probably I should probably pick one
On Fri, Mar 11, 2016 at 4:02 PM, Alex Gaudio<EMAIL_ADDRESS>wrote:

In case it's helpful to anyone in the future, I found that there is a
closeTo for Doubles defined in a couple places
source code
https://github.com/scalanlp/breeze/blob/f4c326f9f219859156a8c55bc667369813fa4b52/math/src/main/scala/breeze/util/Implicits.scala#L43
for a rich double implicit:
import breeze.util.Implicits._
1D.closeTo(1.00001)  // --> true
breeze.numerics package
https://github.com/scalanlp/breeze/blob/44a9c4d6c9e591dc90273cc42ba266b0738be72f/math/src/main/scala/breeze/numerics/package.scala#L681
also defines closeTo for double:
import breeze.numerics.closeTo
closeTo(1D, 1.00001)
—
Reply to this email directly or view it on GitHub
https://github.com/scalanlp/breeze/issues/501#issuecomment-195609627.


Client Credentials for OAuth 2.0 service in SCP Neo

For one of our integration scenarios we need to call an application hosted in SCP Neo. This application provides an OAuth 2.0 service for authentication purposes. I tried to retrieve a client credentials token via the ClientCredentialsTokenFlow which results in a 401 with the message { "error": "unauthorized_client" }.
According to your documentation the ClientCredentialsTokenFlow should be compliant to rfc6749. However, in contrast to the RFC no authentication header is send for the client credential grant.

Hi @StueberMa
yes you are right!
We faced encoding issues with Basic Authorization header, don't remember the details. So that we have adapted all client libs to send client_id / client_secret via request parameter instead of Basic Authorization header. They are now encoded using the
"application/x-www-form-urlencoded" encoding algorithm.
Reference to UAA token flows:
https://docs.cloudfoundry.org/api/uaa/version/74.21.0/index.html#client-credentials-grant
cc @strehle

Thanks for the reply @nenaraab
Since CF UAA supports both modes would it be possible to extend this library to allow toggling how client credentials are transferred - body or authorization header?
If you lack resources I might find time tomorrow to file the changes as PR ...

Basic authentication is rather problematic, see https://github.com/cloudfoundry/uaa/issues/778
Form parameters mitigate this issue.

Hi @mwdb
thanks for referencing the issue.

Closing the ticket as we will not support client_id/secret as part of the Basic Authorization header.


deflateBound and compressBound tests for Google Test

Based on #1236 and already existing deflateBound test code we had in there.

Some tests are expected to fail until the pull request for fixing the calculation is merged in. As I already said in the original issue, I'm all in for improving testing for both cmake and configure...

@Dead2 Should be merged along with #1236... I have no personal preference on which one gets merged first. Due to requirement for cmake 3.12 or newer for Google Test framework (and benchmarks), the tests are not mutually exclusive, as quite many Linux systems are still limited to cmake 3.10 or older (For example, my own Ubuntu only has 3.10.2).

Rebased.

This seems to be failing all over the place. Problem with the test or the fix?

Rebased and issue @mtl1979 mentioned is fixed.


Add a verbose option

A few things that come to mind

Show commands spawned by ncu
Show HTTP request response, in particular responses that could not be parsed as JSON (e.g. when Jenkins authorization fails, it returns XML)
Pipe stdout and stderr, also do not use spinners if verbosity is on in case the output is overwritten

Reminder: this is not yet fixed because of 3 in the OP


Broken link in example site

https://themes.gohugo.io//theme/academic/talk/example/slides/example-slides
On: https://themes.gohugo.io//theme/academic/talk/example/

Thanks for reporting this.
Hugo's demo of Academic is locked down and modifies the configuration slightly. Also, bear in mind that the demo is only updated by Hugo team occasionally and is not a live representation of the code in the master branch.
We would need to investigate how they modify the config and deploy - possibly it might be an addition like relativeURLs breaking some things.

Their theme gen. script is at https://github.com/gohugoio/hugoThemes/tree/master/_script


Add Windows build

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Awesome! What can I do to help @shadowwalkersb?

Appveyor was blocked and it may take some time to restart. But, I had failures on my fork. I was wondering if I am doing something different than you, @jeromekelleher . You mentioned that you tried and it worked, https://github.com/conda-forge/gsl-feedstock/issues/7#issuecomment-255589705.

Restarted Appveyor build.

Restarted Appveyor build.

Don't do that. You will get sent to the end of the queue :smile:
AppVeyor fixed whatever was blocking our builds earlier today and we are slowly clearing the backlog.

I was wondering if I am doing something different than you, @jeromekelleher . You mentioned that you tried and it worked, #7 (comment).

Getting GSL to compile with the CMake recipe was easy enough, but I was never able to actually link against the libraries generated. I spent quite a while fiddling with it and eventually gave up. I suspect it would be an easy fix for an experienced windows dev...

We will see here when Appveyor picks up, but I couldn't build on my fork. It complained about a missing file, gsl_version.h or something like that. I suspect that the code changed after CMakeLists.txt was added which was 3 years ago according to git logs. We may have to patch up CMakeLists.txt and that is no fun for an autoconf project.

https://github.com/ampl/gsl uses 2.1, this recipe's version is 2.2.

Appveyor is still pending for conda-forge, but it finished on my fork. Fails with unresolved external symbols. I can't find mentioned fp_env_string to be defined anywhere. There are no other libraries listed for gsl as dependencies, so, I am not sure where it should be read from. The only lines that the variable is mentioned were added to help with building issues on Windows. May have to contact upstream.

FYI: You might need to pull from the latest version of the CMake-ified GSL @shadowwalkersb. They've just fixed a problem with building shared libraries:
https://github.com/ampl/gsl/issues/10#issuecomment-267772566

https://github.com/ampl/gsl is not the official repo. Should we use it at least for Windows, maybe, @ocefpaf ?

https://github.com/ampl/gsl is not the official repo. Should we use it at least for Windows, maybe, @ocefpaf?

Ideally we should patch the original source with the changes. I know that is painful and using the repo is much easier. But we need a clear and transparent way to identify what code is going into the package.

That means a patch with more than 200 files involved!
@jeromekelleher , I don't think the fix you mentioned addresses the problem we have. They changed the source on their repo, which we don't want to pull from, not the CMakeLists.txt which I pulled from them. So, that shouldn't change anything for us. I don't know how much we can trust their CMakeLists.txt considering the version differences is something else to keep in mind.

How about we change our downloads to pull from https://github.com/ampl/gsl rather than the official mirror? https://github.com/ampl/gsl seems to have CMake support. I just tried a Windows build and was successful the first try.

Actually, it seems like https://github.com/ampl/gsl have v2.2.1. I had to go through their commit history to find out. In that case, we might get a nice patch. Sorry for the noise.

This is great progress @shadowwalkersb, fantastic!

Any suggestions/feedback, @ocefpaf ?

Circle failed with
Downloading http://ftpmirror.gnu.org/gsl/gsl-2.2.1.tar.gz
Success
Error: SHA256 mismatch: '945170809e149a6894228a6cd24fba862d15e1a00f18d4944d649fdfe4d31e5c' != '13d23dc7b0824e1405f3f7e7d0776deee9b8f62c62860bf66e7852d402b8b024'

I guess that is a transient failure, correct?

This should be ready for another round of review. Not sure how to test the package on Windows?

ping

Anything else? CircleCI passes the tests, but fails to upload. So, ready to merge?

CircleCI passes the tests, but fails to upload. So, ready to merge?

It should not try to upload... Weird...


Add permissive mode which accepts nearly anything if an unrecognized extension is used. Uncertain whether this mode should be the default.

@dneto0 how do we know if an extension is "unrecognized" ?

"Recognized by the validator" = there is code in the validator to accommodate that extension's changes to the validation rules.
Currently no extensions are recognized.  But there are extensions published on the SPIR-V registry:
https://www.khronos.org/registry/spir-v/
For example SPV_KHR_shader_ballot says its new features (a few more instructions, and a few enums) are enabled by a new capability, and that capabilty should only be recognized by current environments only when we additionally also see OpExtension "SPV_KHR_shader_ballot".
Thankfully, the grammar file already is set up to automatically set up the dependency checks from enums to capabilities.
So, for example consider this example:
        OpCapability Shader
        OpCapability SubgroupBallotKHR
        OpMemoryModel Logical GLSL450
        OpEntryPoint Vertex %foo "foo"

%void = OpTypeVoid
%voidfn = OpTypeFunction %void
%bool = OpTypeBool
%true = OpConstantTrue %bool

%foo =  OpFunction %void None %voidfn

%entry = OpLabel
   %v = OpSubgroupBallotKHR %void  %true ; Right, shouldn't be void, but that's beside the point right now
        OpReturn

        OpFunctionEnd

The validator allows OpSubgroupBallotKHR to be used because it sees the corresponding capability SubgroupBallotKHR.  But if you comment out that capability declaration, then the validator complains, saying:
error: 10: Opcode SubgroupBallotKHR requires one of these capabilities: SubgroupBallotKHR

Excellent!
So the remaining piece is:  Unless an environment specifically has brought a particular capability into its core functionality, then use of that capability must be accompanied by a matching OpExtension instruction.    None of the current target environments include SPV_KHR_shader_ballot in core.  But a future environment, e.g. Vulkan20.0 could.

Note that the JSON grammar file encodes the dependency from the capability to the extension name.
E.g. for SPV_KHR_shader_ballot: https://github.com/KhronosGroup/SPIRV-Headers/blob/master/include/spirv/1.0/spirv.core.grammar.json#L5101
So we'd just need some general purpose code to use that in a check.

Debate about how to expose this at the API level:

https://github.com/KhronosGroup/SPIRV-Tools/pull/554#discussion_r100881139
https://github.com/KhronosGroup/SPIRV-Tools/pull/554#discussion_r100904827

Basic question:  What optional behaviours should the validator have? How should they be exposed: brand new entry point for each? Or add an options mask?

I recall that @kbenzie requested a "give me as many errors as you can" mode.  That's a candidate for an extra coarse-grain behaviour.

There's also an open issue for parameterizing the validator limit checks.  https://github.com/KhronosGroup/SPIRV-Tools/issues/500
This would argue toward a more general options argument, e.g. similar to Shaderc's compile options object.  See https://github.com/google/shaderc/blob/master/libshaderc/include/shaderc/shaderc.h#L217 and related API entry points.  That's more complex because the client has to manage the options object lifetime.

Given the discussion in the SPIR meeting, the consensus seems to be that the Validator should not skip many checks even if there exists an unrecognized extension. It is difficult to tell where the line should be drawn and how lenient the Validator should be. It could in fact create more confusion for its users.
If the user needs the Validator to bypass certain checks for their extension, they could in fact contribute to the Validator so that it becomes "aware" of the extension.
I am closing this issue. If, in the future, we see any significant reason for making a lenient Validator, we can reopen the issue.


Only allow one replica of Citadel

This PR is for the issue: https://github.com/istio/istio/issues/13383

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ymesika
If they are not already assigned, you can assign the PR to them by writing /assign @ymesika in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @jcetkov

@lei-tang: GitHub didn't allow me to request PR reviews from the following users: jcetkov.
Note that only istio members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jcetkov

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lei-tang I'm OOO this week, I can have a look next week, if it's not too late

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5dcfb6c94ce8afd85899b2abc2244cc1ee71cd6b
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5dcfb6c94ce8afd85899b2abc2244cc1ee71cd6b
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
5dcfb6c94ce8afd85899b2abc2244cc1ee71cd6b
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
Could you please set up an experiment and verify that this fix prevents us from setting replica via variable?

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JimmyCYJ, lei-tang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ymesika
If they are not already assigned, you can assign the PR to them by writing /assign @ymesika in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: JimmyCYJ, lei-tang, myidpt
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ymesika
If they are not already assigned, you can assign the PR to them by writing /assign @ymesika in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JimmyCYJ, lei-tang, mandarjog, myidpt
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog https://github.com/istio-ecosystem/istio-installer/pull/45 has been created on https://github.com/istio-ecosystem/istio-installer.

#https://github.com/istio-ecosystem/istio-installer/pull/45

Thanks @lei-tang.  This will be in 1.1.4


Use current version of audit tables and bring over start values

Bring __start value into derived tables
Use current audit table instead of historical audit table
Separate locally filled requests in core requesting report
Filter out improperly configured PALCI locations (Bobst and South Charleston)

Apologies for the delay in reviewing this.


Add shop greeting messages

Implements #63
Shop greetings are stored in a std::vector in StoreGreetings.h, which can be easily expanded as needed. random_greeting uses C++11 random library features to return a random greeting from the std::vector.

Hi @Mego, does this build successfully on your machine? Travis CI is encountering build errors for some reason.

The issue is tangentially related to my edits - there is a function prototype in Common.h that takes a std::string as an argument, but string is not #included in Common.h. It only works in other compilation units because of the order of the #include statements. I'll make a commit to fix that.

I'm getting a runtime error which outputs the following and crashes the game:
terminate called after throwing an instance of 'std::logic_error'
  what():  basic_string::_M_construct null not valid
Aborted (core dumped)

To replicate this, enter the store and keep entering selections. Eventually the game crashes. Tested on Linux.

It looks like the exception occurred as a result of a mistake on my part - I mistakenly wrote the random choice code as if std::uniform_int_distribution(a, b) returned ints from the range [a, b) (like the equivalent random.randrange in Python), when in fact it returns from the range [a, b]. The latest commit should fix the error.

Yeah, that fixed it. Thanks for helping out! My favorite message is "We're happy to separate you from your money!".


Update 2023-kubecon-eu.md

Update errors.

Thanks for fixing it!

Thanks for fixing it!

Thanks for catching all the errors!


config["flat/recommended"] and config["flat/standard"] rules have no file scope

placing ...eslintPluginToml.configs["flat/base"], in the top level of an eslint.config.js works well because the rules block in flat/base includes a file scope for "**/*.toml" files.
placing ...eslintPluginToml.configs["flat/standard"], or ...eslintPluginToml.configs["flat/recommended"], in the top level on enslint.config.js also expands "flat/base" rules which behave as expected, but since neither rht standard or recommended rules blocks include a file scope, eslint tries to to apply those toml rules to other kinds of files, like json or markdown. This crashes eslint because the source object doesn't have the properties that the toml rules expect because they weren't parsed as toml.
TypeError: Error while loading rule 'toml/no-unreadable-number-separator': Cannot read properties of undefined (reading 'defineCustomBlocksVisitor')
Occurred while linting /Users/aj/Code/codex/package.json

I suggest that that flat/standard and flat/recommended rules each include a files line like flat/base does:
{
  files: ["*.toml", "**/*.toml"],
  rules: {
    ...
  }
},

Workaround
expand flat/base to do most of it. Then create a custom rules block that imports the extended ruleset with files scope.
...eslintPluginToml.configs["flat/base"],
{
  files: ["*.toml", "**/*.toml"],
  rules: {
    ...eslintPluginToml.configs["flat/recommended"].rules,
  },
},

eslint-plugin-yml has the same issue, but I wanna see your thoughts on this before I open an identical issue over there.

Thank you for posting this issue.
I think the problem is that this plugin is not compatible with language plugins other than @eslint/js.
Specifically, this plugin needs to be fixed so that it doesn't crash.
This plugin and plugin-yml are designed to work with .vue etc, so I don't want to configure it to enable rules by extension.

By the way, how do other plugins such as typescript-eslint work around this problem? 🤔

Hmm. I tried @eslint/js but those rules also crash on json languages.
I'm not sure what the best way to do that is 🤔
Online Demo

I guess my real question here is about consistency.

This plugin and plugin-yml are designed to work with .vue etc, so I don't want to configure it to enable rules by extension.

The eslint-plugin-toml base configuration uses a files filter that already excludes the base configuration rules from anything but *.toml files.
The toml standard and recommended configurations apply their rules to every file and include the base configuration. Using the recommended configuration therefore only filters some rules by file extension and applies others to every file.
I think adding a files definition to the standard and recommended rulesets would alleviate this inconsistency.
An alternative would be to remove the files filter from the base configuration and specify in the documentation that the usage occur with user specified files blocks similar to the @eslint/json documentation.
As it is, It's possible to use the toml plugin today alongside json & markdown files either by using the workaround I presented above which leverages your convenient base configuration or the user can rewrite the base configuration themselves to include the standard, recommended, or custom rules they like, but that removes much of the utility of preset configurations.
The typescript-eslint codebase is large but a cursory look indicates that including any of the typescript-eslint configurations replaces the current parser (likely js) with @typescript-eslint/parser. That parser comprehensively handles JS, TS,  JSON, JSX and TSX.  Whereas the @eslint/js parser does not handle json and crashes in a similar manner trying to apply js rules to it. However typescript-eslint/parser does not include parsers for other languages, so if for instance, *.md is included in a block that doesn't define an markdown parser, eslint will throw a parsing error. If using typescript-eslint with markdown linting I would have to segregate it into a files: ["**/.js", "**/.ts"] block.
You mentioned .vue compatibility, but I'm not aware of ways that toml or yaml would occur inside .vue files. Are there vue option blocks that might contain toml or yaml?

If you want to use the recommended config only for your specific files, you can do so like this:
import eslintPluginToml from 'eslint-plugin-toml';
export default [
  ...eslintPluginToml.configs['flat/recommended']
    .map(config=>({...config, files: ['path/to/*.toml']})),
}

The <i18n> block can use different languages using the lang attribute.
https://github.com/intlify/bundle-tools/tree/main/packages/vite-plugin-vue-i18n#locale-messages-formatting

That is more compact than what I'm doing, thanks.


Add mp2p_icp for indexing

Add mp2p_icp for indexing
Please Add This Package to be indexed in the rosdistro.
rolling
The source is here:
https://github.com/MOLAorg/mp2p_icp
Checks

[X] All packages have a declared license in the package.xml
[X] This repository has a LICENSE file
[X] This package is expected to build on the submitted rosdistro

NOTE: This package is right now already published within another package ("mola") but in the next release it will be released as an independently package & git repository, hence this PR.

Hey @jlblancoc, I don't see the license file. Would you add a license file at the top of the repository?

Hey @jlblancoc, I don't see the license file. Would you add a license file at the top of the repository?

Hi @audrow ! It's there, named "copying"... Old fashion 😄 should it be renamed or linked somehow for better visibility?

Hi @audrow ! It's there, named "copying"... Old fashion 😄 should it be renamed or linked somehow for better visibility?

I think it would be optimal to refer to it in the file= attribute of the <license> tag in package.xml https://www.ros.org/reps/rep-0149.html#license-multiple-but-at-least-one that way it can be found by automation without relying on the LICENSE / COPYING filename convention but it's not required.

New package review:

[x] At least one of the following must be present

[x] Top level license file: https://github.com/MOLAorg/mp2p_icp/blob/master/COPYING
[ ] Per package license files

[x] License is OSI-approved:  BSD-3-Clause
[x] License correctly listed in package.xmls

[x] mp2p_ipc: https://github.com/MOLAorg/mp2p_icp/blob/master/package.xml#L16

[x] Public source repo: https://github.com/MOLAorg/mp2p_icp/tree/master/
[x] Source repository contains ROS packages and each package meets REP-144 naming conventions

[x] mp2p_ipc


Broken links on the Startup page

The solution was migrated from https://github.com/sfb2csolutionarchitects/b2c-crm-sync to https://github.com/SalesforceCommerceCloud/b2c-crm-sync but based on metadata when you install solution links on the Startup page still links to the old page, which causes 404 page error.

Fixed in the PR#31, merged in the release/0.0.9


update lwip to 0.0.8

lwip 0.0.8 adds support for the latest versions of Node.js (v4+). Please consider merging and releasing this change so that gulp-lwip can be used with Node v4+. Thank you.

Sorry for the delay, and thanks for the patch.
I'll merge your PR during this weekend and publish a new version on npm.


Themes support for NativeAOT

When trying to compile ILSpy using NativeAOT, application compiles, but do not run due to the exception
Sorry, we crashed
System.IO.FileNotFoundException: Cannot load assembly 'Avalonia.Themes.Default'. No metadata found for this assembly.
   at System.Reflection.Runtime.General.ReflectionCoreCallbacksImplementation.Load(AssemblyName, Boolean) + 0x7e
   at Avalonia.Shared.PlatformSupport.AssetLoader.GetAssembly(String) + 0x136
   at Avalonia.Shared.PlatformSupport.AssetLoader.GetResAsmAndPath(Uri) + 0x24
   at Avalonia.Shared.PlatformSupport.AssetLoader.GetAssembly(Uri) + 0x55
   at Avalonia.Shared.PlatformSupport.AssetLoader.GetAssembly(Uri, Uri) + 0x56
   at Avalonia.Markup.Xaml.AvaloniaXamlLoader.Load(Uri, Uri) + 0x67
   at Avalonia.Markup.Xaml.Styling.StyleInclude.get_Loaded() + 0x27
   at Avalonia.Markup.Xaml.Styling.StyleInclude.Avalonia.Controls.IResourceProvider.AddOwner(IResourceHost) + 0x10
   at Avalonia.Styling.Styles.<OnCollectionChanged>g__Add|52_1(IList) + 0x73
   at Avalonia.Styling.Styles.OnCollectionChanged(Object, NotifyCollectionChangedEventArgs) + 0x3c
   at Avalonia.Collections.AvaloniaList`1.NotifyAdd(T, Int32) + 0x7a
   at ICSharpCode.ILSpy.App.!XamlIlPopulate(IServiceProvider, App) + 0x1e5
   at ICSharpCode.ILSpy.App.Initialize() + 0x24
   at Avalonia.Controls.AppBuilderBase`1.Setup() + 0x132
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime[T](T, String[], ShutdownMode) + 0x53
   at ICSharpCode.ILSpy.Program.Main(String[]) + 0x32

The issue seems to be coming when use <StyleInclude Source="avares://ThemeAssembly/DefaultTheme.xaml"/>

Since our StyleInclude isn't yet compiled, and finds assembly in runtime, you need to update .rd file so Default/Fluent theme won't be trimmed.
This project has an example of Avalonia with NativeAOT https://github.com/teobugslayer/AvaloniaCoreRTDemo


add pre-commit configs

added pre-commit configs on a followup from previous PR #83
added related docs
ran the pre-commit on all files of main

Ive just seen the works of #91. @mithun2003 mind doing some review here?

Is this pre-commit check for print statements in the code beneficial? It ensures that prints are reviewed before committing changes.

@mithun2003 seems there are only two print statements in this repo. Not sure print reviews are needed.

Maybe we should remove the print statements at once and use proper logging for the worker, checking whether there are print statements would be useful in this case.
By the way, how do you guys feel about moving the worker script from app to core/utils?

Agree with the proper logging. What about creating a worker folder under core?
app/worker.py -> app/core/worker/settings.py, app/core/worker/functions.py
That much depth maybe too much and redundant for now, but I believe there is room for expansion for arq worker.

Yeah, I think it's a good approach. Stuff like dynamic prioritization, scheduling, custom retry would be cool.

Yeah, lots can be done with workers.
@igorbenav any thoughts about the PR? I though about creating a separate part on readme to further explain pre-commit to the people who fork the repo. For now, I only added an extra step to the Contributing part.

I think it's a good idea, @luca-medeiros. Do you want to add it to this PR or do it in the future? I'll merge it.

@igorbenav refactored the contributing docs.