Text Editor: Reached the end of the rope iterator! after inserting a String lf after a hidden character (with a beReplaced text attribute)

aText := 'Text' asRopedText.
(aText from: 4 to: 4) attribute: (BrTextAdornmentDynamicAttribute new
		beReplace;
		stencil: [ BlElement new size: 0@0 ])

BrTextEditor new
	text: aText;
	insertString: String lf at: aText size.

Waits to be reviewed by @syrel.

This works now.


Using Custom Image for Rating Icon

First of all thank you for the awesome library. It is exactly what I need for my current project with the ability to provide custom size.
I was wondering if there is a possibility that we can use a custom star image for the rating icons ?
Thanks

Hi, I'm glad it's being helpful !
Currently that's not possible, because the library doesn't use any images to draw the stars.


Upload aarch64 packages

Hi, as we discussed in #2, I have now the compiled binaries for aarch64, I compiled it using the build-locally script, which was working exactly the same as on a x86_64 machine. The packages are available here on my channel ready to copy them to conda-forge: https://anaconda.org/andfoy/qt-main
cc @conda-forge/core @conda-forge/qt-main

@isuruf, is it possible to have any help with this one?

Do you have the logs?

I will need to save them to a file, I will reproduce them and post them here

@isuruf, this is the build log for aarch64: https://drive.google.com/file/d/1mL-mGCryLw05PcuejwVRMSjHuB9ERXQR/view?usp=sharing

@isuruf, is it possible to copy and upload this one?

Done


Which SQL Server versions are supported as the migration source?

Please can you add a FAQ entry to clarify which SQL Server versions are supported, as a migration source? It's a pretty fundamental question, it needs to be covered explicitly.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f233fef5-5db2-8444-22ab-92045e36b119
Version Independent ID: c243f2b3-febe-22aa-03de-0fa068fb7243
Content: FAQ about using the Azure Database Migration Service
Content Source: articles/dms/faq.md
Service: database-migration
GitHub Login: @HJToland3
Microsoft Alias: jtoland

Thanks. The question I asked related to the Azure Data Migration Service, whereas the page you gave relates to the Data Migration Assistant. It's not obvious whether these are the same thing (they are listed as separate items at https://blogs.msdn.microsoft.com/datamigration/2017/10/13/differentiating-microsofts-database-migration-tools-and-services/).
I think we need an explicit answer for the Data Migration Service.
Also note: the Data Migration Assistant page doesn't list Azure SQL Database Managed Instances as a potential target, but this is an option for the Service (in Preview). So the two do not always offer the same support matrix, it seems.

@jtuliani Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@jtuliani, I have added the following question and answer to the FAQ -
Q. What versions of SQL Server does the Azure Database Migration Service support as a source?
When migrating from SQL Server, the Azure Database Migration Service supports SQL Server 2005 through SQL Server 2017.
The change should go live later this afternoon or by mid-morning tomorrow at the latest.  Thanks for your feedback!

#please-close

@jtuliani We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


sort containers in react

currently they're sorted by the api, it makes more sense in react

done


Fix dependency cycle for .env

Resolves #2230.

#2242 might be a better solution, use discretion @gaearon

OK, let's go with https://github.com/facebookincubator/create-react-app/pull/2242 for now.


HSEARCH-2469 Ability to fail over to the next host when a request to an Elasticsearch host fails

This PR is based on #1329 , which will have to be merged first.
https://hibernate.atlassian.net/browse/HSEARCH-2469
Luckily I didn't have to implement anything: failover is already implemented in the official REST client, which we switched to in #1328. So this is only tests and documentation.

Jenkins, retest this please

Looks good.
I don't think we'll want to test too many implementation details of the Rest Client but it's good to have the basics.
So the failed nodes are no longer contacted. Do you know for how long? I expect the client to eventually try to see if they recover..
Merging.

@Sanne The code handling the blacklisting time is located in DeadHostState. It seems to start with 1 minute, and then increase with the number of failures to up to 30 minutes.
    private static final long MIN_CONNECTION_TIMEOUT_NANOS = TimeUnit.MINUTES.toNanos(1);
    private static final long MAX_CONNECTION_TIMEOUT_NANOS = TimeUnit.MINUTES.toNanos(30);


Performance issue at whisper in many aspects : latency, reproducibility, and more

System Info

GPU : A100 (80G)
Driver : 550.54.15
CPU : x86-64
Docker base image : nvcr.io/nvidia/tritonserver:24.03-py3
tensorrt-llm version : 0.11.0.dev2024060400

Who can help?
Information

[X] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[X] My own task or dataset (give details below)

Reproduction
I benchmarked trtllm-whisper served by triton, (built by newer version, the trtllm-build command. older ver was built by python build.py) but  It was slower than flash-attention-implemented huggingface, faster whisper. The bottleneck of latency was decoding, which was about 500~700ms. (for 1s audio).
Also the transcription result was not correct and inconsistent even with max_beam_width of 1. I remember the built by older trtllm version was good in transcription.
After multiple tests, I tried to terminate tritonserver, but below error has thrown.
Any help or advice would be appreciated!
[06/05/2024-15:25:21] [TRT] [E] 1: [defaultAllocator.cpp::deallocate::52] Error Code 1: Cuda Runtime (an illegal memory access was encountered)
[06/05/2024-15:25:21] [TRT] [E] 1: [defaultAllocator.cpp::deallocate::52] Error Code 1: Cuda Runtime (an illegal memory access was encountered)
[TensorRT-LLM][ERROR] tensorrt_llm::common::TllmException: [TensorRT-LLM][ERROR] CUDA runtime error in ::cudaFreeHost(ptr): an illegal memory access was encountered (/home/jenkins/agent/workspace/LLM/main/L0_PostMerge/tensorrt_llm/cpp/tensorrt_llm/runtime/tllmBuffers.h:168)
1       0x7f2a9666ae9a tensorrt_llm::runtime::MemoryPool<tensorrt_llm::runtime::PinnedAllocator>::~MemoryPool() + 282
2       0x7f2cd0819495 /usr/lib/x86_64-linux-gnu/libc.so.6(+0x45495) [0x7f2cd0819495]
3       0x7f2cd0819610 on_exit + 0
4       0x7f2cd07fdd97 /usr/lib/x86_64-linux-gnu/libc.so.6(+0x29d97) [0x7f2cd07fdd97]
5       0x7f2cd07fde40 __libc_start_main + 128
6       0x560e37d701a5 /opt/tritonserver/backends/python/triton_python_backend_stub(+0x271a5) [0x560e37d701a5]

My project is combiation of official whisper example, trtllm-python backend implementation and triton client example
I compiled my fine-tuned, huggingface whisper with below procedures.

convert hf to openai model : python3 convert_from_distil_whisper.py --model_name /workspace/models/whisper-large-v2/2 --output_dir /workspace/models/whisper-openai --output_name large-v2
convert checkpoint to tensorrt-llm way : python3 convert_checkpoint.py --model_dir /workspace/models/whisper-openai --output_dir /workspace/models/whisper-tensorrt-llm --model_name large-v2 --dtype float32 --logits_dtype float32
Build trtllm encoder engine : trtllm-build --checkpoint_dir /workspace/models/whisper-tensorrt-llm/encoder --output_dir /workspace/models/1/encoder --paged_kv_cache disable --moe_plugin disable --enable_xqa disable --use_custom_all_reduce disable --max_batch_size 16 --gemm_plugin disable --bert_attention_plugin float32 --remove_input_padding disable
Build decoder engine : trtllm-build --checkpoint_dir /workspace/models/whisper-tensorrt-llm/decoder --output_dir /workspace/models/1/decoder --paged_kv_cache disable --moe_plugin disable --enable_xqa disable --use_custom_all_reduce disable --max_beam_width 1 --max_batch_size 16 --max_output_len 100 --max_input_len 1024 --max_encoder_input_len 1500 --gemm_plugin float32 --bert_attention_plugin float32 --gpt_attention_plugin float32 --remove_input_padding disable

Expected behavior
Faster than huggingface, faster whisper with consistent cer performance
actual behavior
Slow inference,(RTF was about 1.0), inconsistent transcription result, and the server was unstable.
additional notes
Let me share my dockerfiles for reproduce this issue.

For model compile

# Use the NVIDIA CUDA image with development tools and Ubuntu 22.04
FROM nvidia/cuda:12.1.0-devel-ubuntu22.04
#FROM nvcr.io/nvidia/cuda:12.1.0-devel-ubuntu22.04
# Set the working directory
WORKDIR /workspace

# Environment variables for MPI
ENV MPI_HOME=/usr/local/mpi
ENV PATH="$MPI_HOME/bin:$PATH"
ENV LD_LIBRARY_PATH="$MPI_HOME/lib:$LD_LIBRARY_PATH"

# Install necessary packages
RUN apt-get update && apt-get -y install python3.10 python3-pip openmpi-bin libopenmpi-dev git git-lfs

# copy pip.conf
COPY .tmp/pip.conf /root/.config/pip/pip.conf
# copy cacert.pem
COPY .tmp/cacert.pem /opt/conda/lib/python3.10/site-packages/certifi/cacert.pem

# Inform Git about the CA bundle for certificate verification
RUN git config --global http.sslCAInfo /opt/conda/lib/python3.10/site-packages/certifi/cacert.pem

# Upgrade pip and install necessary Python packages
RUN pip install --upgrade pip setuptools wheel

# Clone the TensorRT-LLM repository
RUN git clone https://github.com/NVIDIA/TensorRT-LLM.git /workspace/TensorRT-LLM && \
    cd /workspace/TensorRT-LLM && \
    git checkout b777bd6
WORKDIR /workspace/TensorRT-LLM
#RUN pip install -r examples/whisper/requirements.txt

RUN pip install --no-cache-dir --extra-index-url https://pypi.nvidia.com tensorrt-llm==0.11.0.dev2024060400 tiktoken datasets kaldialign openai-whisper librosa soundfile safetensors transformers janus

# Setup Git LFS
RUN git lfs install

COPY models/whisper-large-v2 /workspace/models/whisper-large-v2
COPY ./assets /workspace/TensorRT-LLM/examples/whisper/assets

For tritonserver

FROM nvcr.io/nvidia/tritonserver:24.03-py3

RUN apt update && apt-get install -y ffmpeg
RUN python3 -m pip install --no-cache-dir --extra-index-url https://pypi.nvidia.com tensorrt-llm==0.11.0.dev2024060400
RUN python3 -m pip install mpmath==1.3.0 gradio==3.50.2 tritonclient[all]

COPY stt_task/tensorrt_llm/triton/requirements.txt /workspace/requirements.txt
WORKDIR /workspace
RUN python3 -m pip install -r requirements.txt

# COPY model
COPY ./models/whisper_large_v2_tensorrt_llm /workspace/models/whisper-large-v2-tensorrt-llm/1/whisper-large-v2

# COPY src
COPY ./stt/triton/server /workspace/models/whisper-large-v2-tensorrt-llm/1
COPY ./config.pbtxt /workspace/models/whisper-large-v2-tensorrt-llm
COPY ./launch_server.sh /workspace/launch_server.sh

Investigating internal.

@lionsheep24  Would you mind trying fp16 precision ? I thought you're using fp32 here.
Also, what's the performace number e.g. RTF, WER you got by running the official example https://github.com/NVIDIA/TensorRT-LLM/blob/main/examples/whisper/run.py. On A100, I expect you could finish decoding the huggingface audio test set in 8 secs with fp16.
After reporting the RTF number with offcial whisper run.py, could you paste the logs with your custom model  combining with whisper/run.py ?

@yuekaizhang
Run convert_checkpoint with fp16 argument, you mean? since my audio sample is 1s audio and the results are clear. However, no results were obtained.

@lionsheep24  We need to first make sure if you could reproduce the offcial recipes' performance. Could you report what RTF and WER numbers you got after running example/whisper/run.py?

Run convert_checkpoint with fp16 argument, you mean?
Just remove the --fp32 options in your commands.

@yuekaizhang
Trying fp16 precision throws an error during trtllm-build (encoder). I guess the model should be fp16(in openai-way)
[06/07/2024-04:13:17] [TRT-LLM] [W] Parameter was initialized as DataType.HALF but set to DataType.FLOAT
[06/07/2024-04:13:17] [TRT-LLM] [I] Set dtype to float16.
[06/07/2024-04:13:17] [TRT] [I] [MemUsageChange] Init CUDA: CPU +15, GPU +0, now: CPU 148, GPU 72666 (MiB)
[06/07/2024-04:13:22] [TRT] [I] [MemUsageChange] Init builder kernel library: CPU +1939, GPU +348, now: CPU 2223, GPU 73014 (MiB)
[06/07/2024-04:13:22] [TRT] [W] profileSharing0806 is on by default in TensorRT 10.0. This flag is deprecated and has no effect.
[06/07/2024-04:13:22] [TRT-LLM] [W] allreduce algorithm is selected automatically during execution now. use_custom_all_reduce will be deprecated in future releases.
[06/07/2024-04:13:22] [TRT-LLM] [I] Set nccl_plugin to None.
[06/07/2024-04:13:22] [TRT-LLM] [I] Set use_custom_all_reduce to False.
[06/07/2024-04:13:22] [TRT] [E] 4: [convolutionNode.cpp::validateTypes::76] Error Code 4: Internal Error (WhisperEncoder/conv1/conv1d/CONVOLUTION_0: input and kernel weights must have same type)
Traceback (most recent call last):
  File "/usr/local/bin/trtllm-build", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 489, in main
    parallel_build(source, build_config, args.output_dir, workers,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 368, in parallel_build
    passed = build_and_save(rank, rank % workers, ckpt_dir,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 327, in build_and_save
    engine = build_model(build_config,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 320, in build_model
    return build(model, build_config)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/builder.py", line 841, in build
    model(**inputs)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/module.py", line 40, in __call__
    output = self.forward(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/models/enc_dec/model.py", line 1797, in forward
    x = self.conv1(x)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/module.py", line 40, in __call__
    output = self.forward(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/layers/conv.py", line 212, in forward
    return conv1d(input, self.weight.value,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/functional.py", line 3375, in conv1d
    output_2d = _create_tensor(layer.get_output(0), layer)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/functional.py", line 607, in _create_tensor
    assert trt_tensor.shape.__len__(
AssertionError: tensor WhisperEncoder/conv1/conv1d/CONVOLUTION_0_output_0 has an invalid shape

Let me share my build script.

python3 convert_checkpoint.py --model_dir /workspace/models/whisper-openai --output_dir /workspace/models/whisper-tensorrt-llm --model_name large-v2
trtllm-build --checkpoint_dir /workspace/models/whisper-tensorrt-llm/encoder --output_dir /workspace/models/1/encoder --paged_kv_cache disable --moe_plugin disable --enable_xqa disable --use_custom_all_reduce disable --max_batch_size 16 --gemm_plugin disable --bert_attention_plugin float16 --remove_input_padding disable

@yuekaizhang Trying fp16 precision throws an error during trtllm-build (encoder). I guess only fp16 model works (like large-v3). Can you clarify this issue?
[06/07/2024-04:13:17] [TRT-LLM] [W] Parameter was initialized as DataType.HALF but set to DataType.FLOAT
[06/07/2024-04:13:17] [TRT-LLM] [I] Set dtype to float16.
[06/07/2024-04:13:17] [TRT] [I] [MemUsageChange] Init CUDA: CPU +15, GPU +0, now: CPU 148, GPU 72666 (MiB)
[06/07/2024-04:13:22] [TRT] [I] [MemUsageChange] Init builder kernel library: CPU +1939, GPU +348, now: CPU 2223, GPU 73014 (MiB)
[06/07/2024-04:13:22] [TRT] [W] profileSharing0806 is on by default in TensorRT 10.0. This flag is deprecated and has no effect.
[06/07/2024-04:13:22] [TRT-LLM] [W] allreduce algorithm is selected automatically during execution now. use_custom_all_reduce will be deprecated in future releases.
[06/07/2024-04:13:22] [TRT-LLM] [I] Set nccl_plugin to None.
[06/07/2024-04:13:22] [TRT-LLM] [I] Set use_custom_all_reduce to False.
[06/07/2024-04:13:22] [TRT] [E] 4: [convolutionNode.cpp::validateTypes::76] Error Code 4: Internal Error (WhisperEncoder/conv1/conv1d/CONVOLUTION_0: input and kernel weights must have same type)
Traceback (most recent call last):
  File "/usr/local/bin/trtllm-build", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 489, in main
    parallel_build(source, build_config, args.output_dir, workers,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 368, in parallel_build
    passed = build_and_save(rank, rank % workers, ckpt_dir,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 327, in build_and_save
    engine = build_model(build_config,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/commands/build.py", line 320, in build_model
    return build(model, build_config)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/builder.py", line 841, in build
    model(**inputs)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/module.py", line 40, in __call__
    output = self.forward(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/models/enc_dec/model.py", line 1797, in forward
    x = self.conv1(x)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/module.py", line 40, in __call__
    output = self.forward(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/layers/conv.py", line 212, in forward
    return conv1d(input, self.weight.value,
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/functional.py", line 3375, in conv1d
    output_2d = _create_tensor(layer.get_output(0), layer)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/functional.py", line 607, in _create_tensor
    assert trt_tensor.shape.__len__(
AssertionError: tensor WhisperEncoder/conv1/conv1d/CONVOLUTION_0_output_0 has an invalid shape

Let me share my build script.

python3 convert_checkpoint.py --model_dir /workspace/models/whisper-openai --output_dir /workspace/models/whisper-tensorrt-llm --model_name large-v2
trtllm-build --checkpoint_dir /workspace/models/whisper-tensorrt-llm/encoder --output_dir /workspace/models/1/encoder --paged_kv_cache disable --moe_plugin disable --enable_xqa disable --use_custom_all_reduce disable --max_batch_size 16 --gemm_plugin disable --bert_attention_plugin float16 --remove_input_padding disable

@lionsheep24  Our internal fix which may related to this issue would sync to github in a week. Or you could manually convert your model to fp16 first. E.g. model = model.half()

@yuekaizhang
I converted model to fp16 with below script but the result was same.
from transformers import AutoModelForSpeechSeq2Seq

batch_model = AutoModelForSpeechSeq2Seq.from_pretrained(
    model_ckpt,
)

batch_model_fp16 = batch_model.half()

batch_model_fp16.save_pretrained(save_dir)

@yuekaizhang
As you said, simply add .half() to model = AutoModel.from_pretrained(model_name, use_safetensors=True) solved the issue.
The wer problem was fixed. The root cause was language prompt.
Please refer to my 1s audio benchmark (my use case is transcribing short audio for streaming)

Method
Latency (sec)

tensorrt-llm
0.21

faster-whisper
1.43

huggingface
1.7

openai
2.1

p.s : In my benchmark results, the tokens per second were higher for 5-second and 10-second audio inputs. Why doesn't the transcription speed scale linearly with the length of the input audio?

@yuekaizhang As you said, simply add .half() to model = AutoModel.from_pretrained(model_name, use_safetensors=True) solved the issue. The wer problem was fixed. The root cause was language prompt. Please refer to my 1s audio benchmark (my use case is transcribing short audio for streaming)
Method	Latency (sec)
tensorrt-llm	0.21
faster-whisper	1.43
huggingface	1.7
openai	2.1
p.s : In my benchmark results, the tokens per second were higher for 5-second and 10-second audio inputs. Why doesn't the transcription speed scale linearly with the length of the input audio?

where can I find model = AutoModel.from_pretrained(model_name, use_safetensors=True)?

@yuekaizhang As you said, simply add .half() to model = AutoModel.from_pretrained(model_name, use_safetensors=True) solved the issue. The wer problem was fixed. The root cause was language prompt. Please refer to my 1s audio benchmark (my use case is transcribing short audio for streaming)
Method	Latency (sec)
tensorrt-llm	0.21
faster-whisper	1.43
huggingface	1.7
openai	2.1
p.s : In my benchmark results, the tokens per second were higher for 5-second and 10-second audio inputs. Why doesn't the transcription speed scale linearly with the length of the input audio?

where can I find model = AutoModel.from_pretrained(model_name, use_safetensors=True)?

Please check "/TensorRT-LLM/examples/whisper/distil_whisper/convert_from_distil_whisper.py"
line 59

@lionsheep24 for streaming purpose what was your analysis in terms of approach and results? wont 1 sec audio chunks hurt the accuracy of the transcriptions(as it is mentioned to use 30 secs chunks)?


Created deprecated constructor for Webhooks.

Closes #2528.
This PR adds a deprecated constructor for org.wiremock.webhooks.Webhooks class with logging that passing the class name is no longer required and may lead to compatibility issues in the future.

Thanks for creating this. Do we risk ending up with two instances of Webhooks being loaded by doing it this way?

@tomakehurst Thanks for the review. Yes there is a risk of having two instance of Webhooks ( one formed with the constructor public Webhooks(       WireMockServices wireMockServices,       ScheduledExecutorService scheduler,       List<WebhookTransformer> transformers) and one from the deprecated constructor).
Do you think maybe we could throw an exception after logging from the deprecated constructor to solve this problem ?

I wonder if a better solution would be to look for that particular value in the extensions parameter, remove it before processing and log a warning.

Hi @tomakehurst . Happy new year. I am sorry I didn't get you there. Are you suggesting that we should add a check while loading the extensions using Extenstions' load method

I would probably make most sense to put the check somewhere it'll affect both CLI and programmatic initialisation of WireMock, so Extensions.load() or somewhere beneath.


OpenAI Extension

The OpenAI extension adds OpenAI API support to TurboWarp. It supports text and chat completions.

this is the second OpenAI extension in the PRs now, wow

That's what happens when your app becomes the fastest growing lol

That's what happens when your app becomes the fastest growing in history lol

true 😂
yours appears to be different anyway so I don't think it's even a problem lol, not that it would've been to begin with

Thanks!

the reason the other PR is stalled is because storing the API key inside the project is very scary and will almost definitely cause someone's credit card to be charged for API requests they didn't make. IF possible I would prefer these types of extensions to have some custom UI that they use to ask for the API key rather than storing it in the scripts

the reason the other PR is stalled is because storing the API key inside the project is very scary and will almost definitely cause someone's credit card to be charged for API requests they didn't make. IF possible I would prefer these types of extensions to have some custom UI that they use to ask for the API key rather than storing it in the scripts

Like creating a variable?

The problem with a secure system is how it works. Would it be a proxy server the dev has to setup? Would it be encryption (it can't be sha256 or md5 for obvious reasons)? I will look into it further

hey! I wrote an openai extension with built-in apikey. Would you like to take a look?
turbowarp-openai

hey! I wrote an openai extension with built-in apikey. Would you like to take a look?
github.com/zmh-program/turbowarp-openai turbowarp-openai

please submit a pull request instead of commenting about new extensions on existing ones

hey! I wrote an openai extension with built-in apikey. Would you like to take a look?
github.com/zmh-program/turbowarp-openai turbowarp-openai

please submit a pull request instead of commenting about new extensions on existing ones

Thanks, I know. And I'm trying to figure out how to adapt the extension (because I write based on Turbowarp-ClipX and typescript).

#497


Corrupted Properties file generated for multivalued Request Mapping

If there is a request mapping as below:
@RequestMapping(value={"/path1", "path2"})
Then in the generaeted properties file entries of this is found as below:
/{"/path1",\ "/path2"}.POST.param.operationType=
As a result the swagger api can't find the request mapping in the properties file as it searches for entries like:
/path1.POST.param.operationType.
The fix should be to generate multiple entries in the properties file like:
/path1.POST.param.operationType /path2.POST.param.operationType
for each of the values of maultivalued request mapping.

Oof, this is a big one.
The code in the doclet currently only expects one value/path.
I also noticed that the method param will be ignored if you specify multiple methods, because the code only expects one method as well.
This means the whole doclet has to be rewritten with support for multiple paths and methods. It can no longer use one StringBuilder per Annotation and simply use AnnotationValue.toString().
The code has to check if AnnotationValue.value() is an array of AnnotationValue objects and then produce multiple entries in the properties file.
This will probably be a big rewrite and take some time.


LTR languages doesn't render correctly

The application (as far as I explored) contains no handlers to change the layout entirely or a portion of it in response of Right To Left text. That is why it renders all types of texts as Left to Right without taking the locale in consideration.
See the below (Git-It in Kurdish language)

Not just that, But there is a mix of English and Kurdish words to deliver the context and preserve some terminology as it is which makes more sense in English, so the text got mixed as well, especially when the EN words are in the middle of the sentence.
See the below (Git-It in Kurdish Language - Using Terminal Section as example)

Hey Akam,

The application (as far as I explored) contains no handlers to change the layout entirely or a portion of it in response of Right To Left text. That is why it renders all types of texts as Left to Right without taking the locale in consideration.

Hm, yeah. I thought about that already, i was just not sure, if kurdish is really written as rtl. I'll have a look into.

Not just that, But there is a mix of English and Kurdish words to deliver the context and preserve some terminology as it is which makes more sense in English, so the text got mixed as well, especially when the EN words are in the middle of the sentence.

How do you think about this? Do you have another way in mind? Do you know how such stuff is handeled on other applications, that refer to some other english text? Or was that just meant as kind of an information? Until now i thought this is a quite good way, i also did it similar in german translations (Just with the difference, that german uses the same letters as english...).
Greets, :)
Jonas

Hey Jonas,

Hm, yeah. I thought about that already, i was just not sure, if Kurdish is really written as rtl. I'll have a look into.

Yeah Kurdish actually is rtl, because it uses Arabic letters and some other Kurdish specific letters which are collectively rtl.

How do you think about this? Do you have another way in mind? Do you know how such stuff is handeled on other applications, that refer to some other english text? Or was that just meant as kind of an information? Until now i thought this is a quite good way, i also did it similar in german translations (Just with the difference, that german uses the same letters as english...).

I explored some options, one was setting direction: rtl on the html tag of the pages, but that messed some layout, like the language select element. Tried to change some containers to direction: rtl and the result seems good, and it looks like just changing the direction to rtl solves the sentence with mixed direction words problem. for instance look at below if you can notice I changed the parent of Using Terminal section's direction to rtl:

And then I noticed there is  a div.content inside div.wrapper so You can set the direction: rtl and only the content changes and the layout remains good looking.

but there is one more issue with both ways, if you noticed, the code parts are changed to rtl because they inherit direction property from their parents which changed to rtl.

I think one workaround is setting code's parent elements to be direction: ltr maybe in the CSS because it is ltr all the time as they wont be translated anyway.
Cheers ☕

I explored some options, one was setting direction: rtl on the html tag of the pages, but that messed some layout, like the language select element. Tried to change some containers to direction: rtl and the result seems good, and it looks like just changing the direction to rtl solves the sentence with mixed direction words problem. for instance look at below if you can notice I changed the parent of Using Terminal section's direction to rtl:

Thank you for this - that helped me a lot not to have to search for this...
And now i also recognized, what you meant with the mixed directions... I just didn't recognize, as i don't know at all, what is written there :D

Concerning the code sections, see the PR, i right-aligned them now additionally, is that the proper layout for rtl-language?

Thank you for this - that helped me a lot not to have to search for this...
And now i also recognized, what you meant with the mixed directions... I just didn't recognize, as i don't know at all, what is written there :D

Glad, that helped you :D

* Concerning the code sections, see the PR, i right-aligned them now additionally, is that the proper layout for rtl-language?

Nice job, I checked it out, and confused where to discuss it you mentioned me on PR and here, I decided to reply here and discuss the things as we started here, anyway.
that is okay to be right aligned to me, but in my opinion, code sections are nice to be left aligned as they show up everywhere like that, especially in the terminal. Also I just commented out align: right portion of the code and it looks much better for me and looks "cleaner" , also there is no norm in Kurdish language forcing to right align all non-kurdish texts just because the language itself written from right to left.
you can look at this to screen shots, you wrote codes in JS but I show you in CSS as it better looking than JS strings :D

your PR set this

div.code {
direction: ltr;
text-align: right;
}

I changed to this

div.code {
direction: ltr;
}

Nice job, I checked it out, and confused where to discuss it you mentioned me on PR and here, I decided to reply here and discuss the things as we started here, anyway.

Haha, sorry. 🙈

that is okay to be right aligned to me, but in my opinion, code sections are nice to be left aligned as they show up everywhere like that, especially in the terminal.

Ok, good to me. To me that looked properly, but just as i only know it like everything beeing left-aligned. This is why i ask you - I just don't have any glue on this. ;)
-> I'll remove it 👍

-> I'll remove it +1
Yeah, that is okay.

Please notify me anytime you need reviewing things like that, I loved the app and I'm happy to keep it great.


docker: remove alpine build

Signed-off-by: Loong<EMAIL_ADDRESS>Part of #19781
Commit Message: do not build for alpine anymore.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Please review again.


Can't input Unicode in Internal Console

From<EMAIL_ADDRESS>on 2012-06-04T21:14:33Z
Spyder Version:  2.1.10
Python Version:  2.6.5
Qt Version:      4.7.2, PyQt4 (API v2) 4.8.4 on Windows
What steps will reproduce the problem?

Open internal console

input following code into internal console:
 a=u"あ" What is the expected output? What do you see instead? exception raised:

Traceback (most recent call last):
File "C:\Python26\lib\site-packages\spyderlib\widgets\internalshell.py", line 336, in keyPressEvent
self.postprocess_keyevent(event)
File "C:\Python26\lib\site-packages\spyderlib\widgets\shell.py", line 791, in postprocess_keyevent
ShellBaseWidget.postprocess_keyevent(self, event)
File "C:\Python26\lib\site-packages\spyderlib\widgets\shell.py", line 336, in postprocess_keyevent
self._key_enter()
File "C:\Python26\lib\site-packages\spyderlib\widgets\shell.py", line 454, in _key_enter
self.on_enter(command)
File "C:\Python26\lib\site-packages\spyderlib\widgets\internalshell.py", line 325, in on_enter
self.execute_command(command)
File "C:\Python26\lib\site-packages\spyderlib\widgets\internalshell.py", line 385, in execute_command
self.run_command(cmd)
File "C:\Python26\lib\site-packages\spyderlib\widgets\internalshell.py", line 394, in run_command
self.interpreter.stdin_write.write(cmd + '\n')
UnicodeEncodeError: 'ascii' codec can't encode character u'\u3042' in position 6: ordinal not in range(128)
Please provide any additional information below
. I debuged this for a while, and here is the result:
def run_command(self, cmd, history=True, new_prompt=True):
print repr(cmd) # << add this line
when I input a="あ", the output is: u'a = "\u3042"'
when I input b=u"あ", the output is: u'b = u"\u3042"'
to get a="あ" works, I need to change the following code in run_command:
self.interpreter.stdin_write.write(cmd.encode("utf-8") + '\n')
to get b=u"あ" works, I need to change the code to:
self.interpreter.stdin_write.write(cmd.encode("unicode_escape") + '\n')
to get both works I change the code in run_command() to:
self.interpreter.stdin_write.write(cmd.encode("utf-8") + '\n')
and then change Interpreter.push() to:
return InteractiveConsole.push(self, "#coding=utf-8\n" + line)
I don't know better method to solve this problem.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1079

From<EMAIL_ADDRESS>on 2012-07-04T17:36:48Z
The internal console widget is very helpful for debugging pyqt applications. I found this unicode issue when I embed it into my developing application which use Japanese.

From ccordoba12 on 2012-07-04T08:23:07Z
Thanks for the fix. I'll try to push it soon.
But may I ask: why do you want to have unicode on the internal console? I say it because it's a very simple console that show internal messages and lets us explore the Spyder namespace, so I don't clearly see the importance of adding unicode to it.
Status: Accepted
Owner: ccordoba12
Labels: Cat-Console MS-v2.2

From ccordoba12 on 2012-07-06T09:32:15Z
This issue was updated by revision a5232108e9cc .
Thanks to<EMAIL_ADDRESS>for the fix
Status: Fixed


wiggle: generate offset accessors for structs

Adds methods of the shape GeneratedStruct::offset_of_<field_name>() -> u32 to allow clients to get the same offsets used in the generated read and write methods. I don't believe there is currently a way to get these otherwise for applications that wish to selectively read and write to fields.
I considered a couple alternatives to this:

Add methods like read_<field_name> and write_<field_name>. The interface to these ends up being awkward because the GuestType impls are currently for owned types, so these methods would be forced to either take ownership of the entire struct to write one field, or else silently clone the field.

Add #[repr(C)] to the generated struct definition so that clients could use tools like memoffset to calculate the offset themselves. I didn't want to depend on the witx offsets coinciding with repr(C), though.

I extended the Wiggle records to exercise these new methods.

The witx offsets are supposed to align with repr(C) for the wasm32 ABI defined by clang, but that wont be the same as the repr(C) on the host.

Ahh, of course! Glad I didn't pursue that, then. This seems to be good enough for anyone who really needs this to do what they want with GuestPtr, even if it's not super convenient. Convenience is for wit-bindgen at this point

Yep this is a perfectly fine way to get the right inputs for your GuestPtr operations. The wiggle generator has all that information, so there's no reason not to expose it to the user if they want it.


Where For Dinner TAP 1.4 Compliance Updates And Ehancements

There Where For Dinner application has needs for the following:

AppSSO 2.0.0 updates for deprecated features.  Specifically the issuerURI has been deprecated and will no be supported in future updates.  The accelerator needs to use the tls.disabled: false technique as described in the AppSSO migration guide and remove the field for the issuerURI
A Redis cache option (vs a simple in memory cache) has been available but no utilized.  This enhancement will add a Redis instance to the application when selected by the accelerator and enable the implementation in the search-proc service.
The search crawler service has been available for some time, but not utilized.  This enhancement adds the crawler service to the application stack.

Closing post code merge.


Need to renew softlayer ci ssl certificate cert and move to the corresponding domain

@dpb587-pivotal Dmitriy ever gave us the cert for cpi and stemcell ci/cd pipeline site for IBM Cloud. through LastPass (softlayer ci ssl certificate), it's already expired, could you please help renew it? Actually we didn't use it before, do you know what domain is addressed by this cert, we need to apply for the domain name through aws route53? Thanks.
/cc @jfmyers9 @mfine30

I do not think we are managing CI environments nor certificates for SoftLayer. I do not know what environment you are referring to - can you be more specific?
If this concerns sensitive environments or details, please start an email thread with us instead of a public GitHub issue.

After some discussions with Danny, we decided to try with Let's Encrypt, there is a bosh release for use or reference -> https://github.com/dpb587/caddy-bosh-release

Requested a new cert for bosh-sl-ci.bluemix.net from `Let's Encrypt", closing this issue.


Change tab name - license and citation

Original report on BitBucket by Taina Jääskeläinen.

Change the tab name from ‘License and Citation’ to ‘License and citation’ in detailed vocabulary view in the UI, to be in line with the other tabs.
Maja to decide first if it is changed to ‘Licence and citation’, i.e. to British instead of American spelling.

Change the tab name from ‘License and Citation’ to ‘Licence and citation’

Will be fixed with merged PR #570.

Ready for 3.1.0 release


Doc updates for Semantics; always reset SemanticsNode

Fixes https://github.com/flutter/flutter/issues/11731, https://github.com/flutter/flutter/issues/11716, https://github.com/flutter/flutter/issues/11775


[HTML Image] - Try using HTML images.

To make the visual tree even simpler try using an HTML image.

This feature is implemented in another repo: https://github.com/asadullahrifat89/honk-buster-game-uno-platform


Failed to login - Piazzetta

Hello,
Is it just me or are there other people who are not able to login anymore.
I'm having a Piazzetta stove.
This is the log in HA when trying to add the integration.

Logger: aiohttp.server
Source: /usr/local/lib/python3.11/site-packages/aiohttp/web_protocol.py:403
First occurred: 16:14:20 (1 occurrences)
Last logged: 16:14:20

Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request
    resp = await request_handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 85, in security_filter_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 100, in forwarded_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/ban.py", line 80, in ban_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 236, in auth_middleware
    return await handler(request)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/headers.py", line 31, in headers_middleware
    response = await handler(request)
               ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 148, in handle
    result = await handler(request, **request.match_info)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/decorators.py", line 63, in with_admin
    return await func(self, request, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/config/config_entries.py", line 177, in post
    return await super().post(request, flow_id)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/http/data_validator.py", line 72, in wrapper
    result = await method(view, request, data, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/data_entry_flow.py", line 110, in post
    result = await self._flow_mgr.async_configure(flow_id, data)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 293, in async_configure
    result = await self._async_handle_step(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 394, in _async_handle_step
    result: FlowResult = await getattr(flow, method)(user_input)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/aguaiot/config_flow.py", line 87, in async_step_user
    await agua.connect()
  File "/config/custom_components/aguaiot/aguaiot.py", line 119, in connect
    await self.login()
  File "/config/custom_components/aguaiot/aguaiot.py", line 204, in login
    self.token = res["token"]
                 ~~~^^^^^^^^^
KeyError: 'token'

Hi,
maybe somebody can help me. I,ve got the same problem, but i don't where the problem is. I know my username and password is correct. I tried different configurations.

Home Assistant 2023.10.2
Supervisor 2023.10.0
Operating System 10.5
Frontend 20231005.0 - latest
Micronova Agua IOT v0.1.8
And I have a Piazzetta. Maybe the mistake is mine.
Thank you for your help.

Same for me since this morning. Turning on debug log and starting the Micronova Agua IOT integration tells me my credentials are incorrect, but same credentials still work with the MyPiazetta app contrikkubg the Piazetta pellet stove.
2023-10-13 22:40:30.525 ERROR (MainThread) [custom_components.aguaiot] Wrong credentials for Agua IOT

Hi,
I've install the upgrade just now but i've the same error:
Cette erreur provient d'une intégration personnalisée
Logger: custom_components.aguaiot
Source: custom_components/aguaiot/init.py:82
Integration: Micronova Agua IOT (documentation, issues)
First occurred: 10:04:31 (3 occurrences)
Last logged: 10:17:15
Agua IOT Unauthorized: Failed to login, please check credentials

This seems an issue isolated to Piazetta. Maybe they changed something on their environment. Was there an Piazetta app update for mobile recently?

This seems an issue isolated to Piazetta. Maybe they changed something on their environment. Was there an Piazetta app update for mobile recently?

Hi,
Last update of the app is the 08/31/2023.
In my case, i had no problem with the previous stable version. Only since the upgrade to 0.2.0 this morning

Please install v0.2.1-beta1 and check the home assistant errors logs. There should be the response from the Piazetta API.

Please install v0.2.1-beta1 and check the home assistant errors logs. There should be the response from the Piazetta API.

I've install the beta.
In my logs i see:
`Cette erreur provient d'une intégration personnalisée
Logger: custom_components.aguaiot.aguaiot
Source: custom_components/aguaiot/aguaiot.py:206
Integration: Micronova Agua IOT (documentation, issues)
First occurred: 20:47:34 (3 occurrences)
Last logged: 21:11:10
Failed to login. Code: 500, Response:`
and:
`Cette erreur provient d'une intégration personnalisée
Logger: custom_components.aguaiot
Source: custom_components/aguaiot/init.py:82
Integration: Micronova Agua IOT (documentation, issues)
First occurred: 20:47:34 (3 occurrences)
Last logged: 21:11:10
Agua IOT Unauthorized: Failed to login, please check credentials`

The configuration "program version" I tried 2.0.0 and 2.1.0
Log Viewer:
2023-10-15 00:20:34.363 ERROR (MainThread) [custom_components.aguaiot.aguaiot] Failed to login. Code: 500, Response:
I checked my password and username again and they are correct

Piazetta must have changed something to their custom login mechanism. It also stopped working with the older (v0.1.8) version. Sadly their login does not report any error, but just an empty response.
Trying to figure out what is happening, but since everything is closed source, it will take some time. If someone is good a decompiling android apps, help is appreciated.

Does somebody tried without indicating the login URL?

I created a Piazetta account (although I don’t have the stove) and did some testing. Couldn’t get it to work yet.

Does somebody tried without indicating the login URL?

I've tried but not works better.
`Cette erreur provient d'une intégration personnalisée
Logger: custom_components.aguaiot.aguaiot
Source: custom_components/aguaiot/aguaiot.py:206
Integration: Micronova Agua IOT (documentation, issues)
First occurred: 14 octobre 2023 à 20:47:34 (7 occurrences)
Last logged: 13:24:00
Failed to login. Code: 500, Response:
Failed to login. Code: 404, Response: {"Success":false,"Error":"1103","Text":"LOGIN_USER_NOT_FOUND"}`

Piazetta must have changed something to their custom login mechanism. It also stopped working with the older (v0.1.8) version. Sadly their login does not report any error, but just an empty response.
Trying to figure out what is happening, but since everything is closed source, it will take some time. If someone is good a decompiling android apps, help is appreciated.

App version is 1.9.5 since 31/8 ( also day of breakdown)
The response is also empty here.

Does somebody tried without indicating the login URL?

Yes, I did, negative

Found a possible fix: #61

Please try v0.2.1-beta3 and make sure that Application version in the configuration is set to 1.9.5 (or at least higher than 1.9.0)

Problem solved! Vincent, you're the best!
Thanks a lot!

AMAZING. it works.

Same changes make the homebridge plugin work again, thanks so much. I assumed these headers were optional and therefor didn't even consider adding them


Remove-PnPTermLabel fails to execute and returns an error

Reporting an Issue or Missing Feature
When using Remove-PnPTermLabel the command fails and returns an error.
Expected behavior
I expected the Term to be removed without error
Actual behavior
Received the following error:
Remove-PnPTermLabel : Cannot bind parameter 'Connection'. Cannot convert the "PnP.PowerShell.Commands.Base.PnPConnection" value of type
"PnP.PowerShell.Commands.Base.PnPConnection" to type "PnP.PowerShell.Commands.Base.PnPConnection".
At line:1 char:107

... f-40c8-c000-680f-6d94c8b54c5f -WhatIf -Connection $connection -Verbos ...

                                                  ~~~~~~~~~~~

CategoryInfo          : InvalidArgument: (:) [Remove-PnPTermLabel], ParameterBindingException
FullyQualifiedErrorId : CannotConvertArgumentNoMessage,PnP.PowerShell.Commands.Taxonomy.RemoveTermLabel

Steps to reproduce behavior
Execute the command:
Remove-PnPTermLabel -Label "1atest3 lavel" -Term 0abadf9f-40c8-c000-680f-6d94c8b54c5f -WhatIf -Connection $connection -Verbose -Debug
What is the version of the Cmdlet module you are running?
Get-Module -Name "PnP.PowerShell" -ListAvailable
Directory:  [Blacked out]

ModuleType Version    Name                                ExportedCommands

Manifest   1.7.1      PnP.PowerShell                      {Add-PnPClientSidePage, Add-PnPClientSidePageSection, Add-PnPClientSideText, Add-PnPClientSideWebP...
Manifest   1.7.0      PnP.PowerShell                      {Add-PnPClientSidePage, Add-PnPClientSidePageSection, Add-PnPClientSideText, Add-PnPClientSideWebP...
Manifest   1.6.0      PnP.PowerShell                      {Add-PnPClientSidePage, Add-PnPClientSidePageSection, Add-PnPClientSideText, Add-PnPClientSideWebP...
Which operating system/environment are you running PnP PowerShell on?

[X ] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

@adaptandadopt - is this still reproducible ? Can you try with latest version and check ? Was not able to reproduce this issue.

Closing this due to no response.


[WIP] Dist KV Op and Resource Cube Config

增加了general dist kv op
增加了在python paddle_serving_server 的__init__阶段，检查workflow当中是否有dist kv的op，如果有，就在ResourceConf增加cube config。
相应的，在resource.cpp增加ResourceConf的检查，如果发现cube字段就增加cube init
增加相关脚本

目前还需要添加的内容

Criteo CTR 分布式稀疏参数预测 的 完整运行文档

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: wangjiawei04:x: rootroot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Managed memory

Add test for "managed memory", i.e. omp_get_memory_space API.

Can we customize this test based on result of omp_get_num_devices() so this does not fail on single-device tests?

Done: now test only effective when multiple devices are available.


Constants import failure on build runner generation

I am pretty sure a minor but breaking drift_dev error started occurring after upgrading new build_runner or source_gen after flutter 3.10 / dart 3 support was rolled out a few days back.  After building, the generated files have altered imports (Constants top level instead of ex: i3.Constants) and the (edit: run time) compilation fails. I can try to give more details but curious if anyone else has run into this yet.

I can reproduce the issue and I know how to fix it, but I need to check which AST nodes could be affected by this. I hope I can get a fix out tomorrow!
As a temporary workaround, it might work a bit better if you temporarily downgrade to analyzer: '>=5.11.0 <5.12.0' by adding it to your dependency_overrides if that doesn't cause another dependency conflict in your app.

Thanks for the speedy answer and suggestion; just wanted to make sure it wasn't something specific to what I did since other possibilities existed as I upgraded to 3.10.

I hope I can get a fix out tomorrow!

Not urgent at all, don't rush.  Thanks again for your supreme work on this lib, Simon 🙏

Should be fixed in drift_dev: ^2.8.1.

Works perfectly here :+1:


Fixed table referencing

Fixes the order of storing table references to match the order in which the tables are deserialized so each reference points to the correct table.
Dupes that were saved with wrong table references still can't be opened, if anyone know a nice way to correct them please let me know, otherwise this can be merged.
.
Fixes #34

I managed to open broken dupes but they can't be fixed before the deserialization starts, the way of deserializing needs to be altered instead (for files using codec revision 4). I don't know if this is worth adding though, only one issue with opening the broken file has been posted so far, and people got the EOF error when saving, so most of them probably managed to fix and save it properly.

Fixed in 7ee9239f0ccae5c1f4b24c40026c61e7a5210648


Xplora WAtch and Device Tracker

Hello.

Please could you provide more guide on how to get it to work?
Regards,
Martin

If you filter entities by watch at Developet Tools/State, you see the watch tracker with a zone as the state? If you have set up zones in /config/zones the watch should recognize when it is inside one of those zones, at least that works for me.
And then I use the map in a dashboard. Works also to use the Device card to select the watch tracker for my childrens watches to get the zone they are in.

I'm struggling with the tracker status too. Sometimes it finds the right zone, but most often it just states as not_home (or Out)
@westis - Have you configured all of your zones in the configuration.yaml? Or have you added them through GUI?

@westis - Have you configured all of your zones in the configuration.yaml? Or have you added them through GUI?

Only via the GUI. But I haven't used it for more than a couple of days and it seems the location sometimes doesn't update for a few hours and the battery level often reports -1.

I have investigated and I found that binary watch safe zone is showing as On but I the watch has 2 safezones:  Home and School.
So that is not possible to see which safezone the watch is in.

@MartinAM80 But you can set up zones in Home Assistant and see what zone the watch is in.
However, my problem is that the watches are very unreliable in updating their position. Sometimes it can take hours before they update, not sure why.


Polish PESEL - check digit 0

https://en.wikipedia.org/wiki/PESEL
Checksum calculation
Having a PESEL in the form of ABCDEFGHIJK, one can check the validity of the number by computing the following expression:
A×1 + B×3 + C×7 + D×9 + E×1 + F×3 + G×7 + H×9 + I×1 + J×3
The checksum is the last digit of result of the above expression subtracted from 10. If this last digit is 0 then the checksum is 0.
If the result of the last operation is not equal to the last digit (K) of a given PESEL, the PESEL is incorrect. This system works reliably well for catching one-digit mistakes and digit swaps.
test value:<PHONE_NUMBER>0 should be valid.
Running it against https://calculla.com/calculators/decoder/poland_pesel_decoder validator
Also tested it against this lib https://github.com/radarsu/validate-polish/blob/master/src/index.ts#L50
return 10 - (control === 0 ? 10 : control) === dig11;
PDF article: https://www.oecd.org/tax/automatic-exchange/crs-implementation-and-assistance/tax-identification-numbers/Poland-TIN.pdf it doesnt say what happens when its 10?

proposed fix:
 if (String(10 - (sum === 0 ? 10 : sum)) !== check) {
      return { isValid: false, error: new exceptions.InvalidChecksum() };
}

The better fix in these cases is (10 - sum) % 10)

Fixed in PR #65

I know you don't have Polish TIN in this lib yet, but one thing that is interesting the TIN (on page 3 of that pdf) specifically spells out 4. Check digit = remainder (if remainder = 10, the TIN is not valid)


A simple way to pre-check entity types

We observed many cases when users enter ligands/rna as proteins, we need a way to at least warn users about this

covered in #9


problem about training the track transformer

Hello, thank you for presenting this interesting work. I am attempting to reproduce the training based on the Libero dataset.
However, I've noticed that when training the track transformer, the train_dataset_list and val1_dataset_list obtained through:
train_dataset_list = glob(os.path.join(root_dir, f"{suite_name}//train/"))
val1_dataset_list = glob(os.path.join(root_dir, f"{suite_name}//val/"))
are empty. I'm wondering if the data preprocessing stage requires additional processing of the data obtained from preprocess_libero.py? Many thanks!

I checked the dataset inside linero_goal as an example. The dataset structure is shown as follows.
-- libero_goal
-- open_the_middle_drawer....
--images
--videos
--demo_0.hdf5
--demo_1.hdf5
--....hdf5
--env_meta.json

I realized that I just need to create these two folders by myself... Now I can train the model...

I realized that I just need to create these two folders by myself... Now I can train the model...😂😂

Thank you very much I have just come with this problem as well 😂😂

@KaiTang98 训练的结果怎么样，能够完成任务吗

I found the script you are suppose to run here is the command:
python3 scripts/split_libero_dataset.py --folder data/atm_libero --train_ratio 0.9

Thank you very much for pointing this out. The "train" and "val" folders are generated by scripts/split_libero_dataset.py. Sorry for missing this important step in README. I have updated it.

Thank you very much for pointing this out. The "train" and "val" folders are generated by scripts/split_libero_dataset.py. Sorry for missing this important step in README. I have updated it.


fatal error: in "TensorflowLiteParser/ParseReLu": memory access violation at address: 0x00000034: no mapping at fault address

I followed this guild "Configuring the Arm NN SDK build environment for TensorFlow Lite"
and try to run unitest on RPi4 with 4GB RAM. I encountered this issue.
pi@raspberrypi:~/tflite_ws/armnn-tflite/armnn/build $ ./UnitTests
Running 1859 test cases...
unknown location(0): fatal error: in "TensorflowLiteParser/ParseReLu": memory access violation at address: 0x00000034: no mapping at fault address
/home/pi/tflite_ws/armnn-tflite/armnn/src/armnnTfLiteParser/test/Activations.cpp(71): last checkpoint: "ParseReLu" fixture entry.
*** 1 failure is detected in the test module "UnitTests"
ARMNN cmake option:
$ cmake .. -DARMCOMPUTE_ROOT=$BASEDIR/ComputeLibrary -DARMCOMPUTE_BUILD_DIR=$BASEDIR/ComputeLibrary/build -DBOOST_ROOT=$BASEDIR/boost -DTF_GENERATED_SOURCES=$BASEDIR/tensorflow-protobuf -DPROTOBUF_ROOT=$BASEDIR/protobuf-host -DBUILD_TF_LITE_PARSER=1 -DTF_LITE_GENERATED_PATH=$BASEDIR/tensorflow/tensorflow/lite/schema -DFLATBUFFERS_ROOT=$BASEDIR/flatbuffers -DFLATBUFFERS_LIBRARY=$BASEDIR/flatbuffers/libflatbuffers.a -DARMCOMPUTENEON=1

switch google flatbuffers library to v.1.10 to fix this problem.


404 Page not found

Hi,
I'm mixing zabbix and grafana.
When i access localhost:8686, it display 404 page not found.
Could anyone help me ?

The reporter does not serve any html at the root endpoint (ip:port/ or <IP_ADDRESS>:8686 in your case). You need to request a specific dashboard as explained in the readme, for example ip:port/api/v5/report/{dashboardID} where, for example, {dashboardID} is jn7wAe3ik in your example screenshot.

Then there is also a potential problem with Zabbix not correctly rendering PNGs via the Grafana API. See #29.

My dashboard link is : http://<IP_ADDRESS>:3000/d/jn7wAe3ik/host-186?orgId=1. So my dashboardID is jn7wAe3ik.
My API key is eyJrIjoiMFltNjBvTlNSMXN3dWVoVUpxVU5WSG1nMDU4eWRveEoiLCJuIjoiR3JhZmFuYS1SZXBvcnRlciIsImlkIjoxfQ==
I have just everything. So, what i can to do to fix this bug ?

Aah, I see in your screenshots you confused the ports. As explained above and in the readme, you need to call the correct endpoint on the reporter (:8686) with the correct parameters. Based on your screenshot and info that would be
 http://<IP_ADDRESS>:8686/api/v5/report/jn7wAe3ik?apitoken=eyJrIjoiMFltNjBvTlNSMXN3dWVoVUpxVU5WSG1nMDU4eWRveEoiLCJuIjoiR3JhZmFuYS1SZXBvcnRlciIsImlkIjoxfQ==

Thanks for your help, it's running now.
But, how i can setup the time of the report ?
For exp, I want export report about 1 month. What i have to and into the link ?

To add time you can look at the animated gif in the readme: check the include time range button in the grafana link setting. This adds from and to query parameters.  For example
 http://<IP_ADDRESS>:8686/api/v5/report/jn7wAe3ik?apitoken=eyJrIjoiMFltNjBvTlNSMXN3dWVoVUpxVU5WSG1nMDU4eWRveEoiLCJuIjoiR3JhZmFuYS1SZXBvcnRlciIsImlkIjoxfQ==&from=now-3h&to=now

The background colour is hard coded.


Add automatic linting on commit

Is your feature request related to a problem?
It's frustrating to forget to lint the project before committing and pushing up to remote, only to realize later on and have to make a subsequent commit with the sole purpose of correcting any linting issues. This means that the commit history is muddied with unnecessary entries, and Blame becomes more difficult to follow, among other probable issues the author has not researched.
Describe the solution you'd like
Running the lint-staged task during the commit process would ensure that no linter errors make it into the commit history.
Describe alternative solutions you've considered
A git pre-commit hook would work nicely, as well, though this is something which any developer of the project would have to remember to place into the correct directory before working on the project. This was the approach taken with the Storytelling Tool, though it didn't have great cross-environment compatibility, and any time the remote was cloned it had to be re-copied.
Additional context or notes
N/A

One note about this: we would need to work around fluid-lint-all to do this. The approach taken with We Count was to use Husky to configure a git pre-commit hook for lint-staged. The way this works is that you define a blob, e.g. *.scss, and a command to lint files which match that blob, which sets up lint-staged to run <command> <filepath> for each matching file. So for SCSS files, one would need to use Stylelint directly, as the resulting command is stylelint somefile.scss. fluid-lint-all can't be used to lint a single file by definition. This makes me wonder if perhaps moving away from fluid-lint-all to individual linters might make sense for Trivet but I'd be keen to hear other perspectives.

cc: @jobara @amb26 @the-t-in-rtf

My personal preference is to not force linting at these stages. It depends on your personal workflow/style as you may want to be able to commit intermediate stages and have those tracked in history or decide to squash those down into something cleaner. Having this as optional would be useful.
Regarding moving away from fluid-lint-all, I'll defer to @amb26 and @the-t-in-rtf. I wonder if there can be a feature added to fluid-lint-all to target specific files and/or linters for cases like this.

My personal preference is to not force linting at these stages.

Turning off lint on commit could certainly be an option but providing the configuration would be great for those who want it.

I wonder if there can be a feature added to fluid-lint-all to target specific files and/or linters for cases like this.

I don't know what the benefit would be to piping a linting tool through fluid-lint-all for the purpose of linting a single file. It seems contrary to the purposes of fluid-lint-all, namely, to run all your linters on all lintable files as a batch.

I've discovered that the husky npm package is already configured and runs both fluid-lint-all and commitlint as a pre-commit hook, work added in #14.
Please feel free to either close this issue or to leave open it as a venue to discuss whether Husky should be left in or removed.

Seems like you figured out what you needed, but I just wanted to respond.
By design, the checks in fluid-lint-all are not all or nothing.  Although some projects will be fine with a single configuration for everything, I can easily imagine cases in which you'd want different checks/rules for some content regardless of the file type.  Test fixtures are a good example, another would be forked copies of third-party code.  Although lots of us opt those out of checks altogether, you should also be able to check content more or less rigorously as needed.
One way of doing this is to create a separate config file for the content you want to check differently, and then call fluid-lint-all using the configFile option.

I'm going to close this issue as per https://github.com/fluid-project/trivet/issues/196#issuecomment-1023904393.


Update GAP Launcher to support the latest AEM project archetype

Currently the GAP Launcher doesn't work with archetype version 37 as it doesn't define POD_NAME environment variable for the dispatcher.

now supports 39


improve constructor parameter names of EventStorageEngine

Hi, while serializer was perhaps a bit ambiguous, the suggested aggregateSerializer isn’t really correct. I’d suggest snapshotSerializer’ instead.  When you use the AggregateSnapshotter`(default), the snapshot is the aggregate itself, but it’s not a requirement.

Hi,
Initially I renamed the param to snapshotSerializer. Until I realized that a ‘snapshot’ is the serialized thing and the aggregate is what’s being serialized. Hence I went for aggregateSerializer.


frontend problems new-eventstore

Org:

[ ] Add Org with my user as owner not possible if i change on second page, no button available
[ ] Set Primary Domain button should only be available on verified domains (boolean seems inverted in UI)

Project:

[ ] Show Detail of Granted Project not possible
[ ] On global org its not possible to add a project (ORG_PROJECT_CREATOR)

Application:

[ ] App flow doesnt work, App Type is not set correctly

LoginPolicy on Org:

[ ] Klick on + Multifactor doesnt make anything
[ ] Klick on + SecondFactor doesnt make anything

Authorizations:

[ ] Edit User Grant calls GetProjectGrantByID instead of userGrantByID

Personal Information

[ ] Change Email calls Change Phone
[ ] Phone is not formatted with +41...
[ ] Add OTP label should be named add Factor
[ ] Add OTP doesn't work, after clicking add otp nothing happens
[ ] Add U2F doesn't work, nothing happens
[ ] Add Passwordless doesn't work, nothing happens

User:

[ ] Add Member Type Project doesnt work, project id missing
[ ] Add Member Type Project Grant doesnt work, grant id missing

Human:

[ ] Change Profile doesnt work, display name missing (display name should be editable)

Machine:

[ ] When creating a machine user, input fields / form a resized when they're valid, but there's no message
[ ] Change name not possible, field not editable

https://user-images.githubusercontent.com/9405495/111904186-d2444c80-8a45-11eb-88f4-7d6c217cf436.mov

On App State translation not correct:


Test CodeAction.disabled

Test for #85160

[ ] AnyOs @eamodio
[ ] AnyOs @alexr00

Complexity: 4
Overview
The new CodeAction.proposed property lets extensions tell VS Code why a specific code action is not available. This is used in a few ways:

Disabled actions are not shown in the normal lightbulb menu
Disabled action are show in specialized code action menus, such as refactor (but they should never be applied
If a user explicitly requests a disabled code action, we show the .disabled message

Testing
Using the Code Action Sample, test the proposed .disabled property.

Confirm the expected behavior stated above
Make sure you can never apply a disabled action
Try creating cases where a provider returns all disabled actions
Try creating cases where a provider returns a mix of enabled and disabled actions

@mjbvz How do you do this?

If a user explicitly requests a disabled code action, we show the .disabled message

Tested on Windows.


System sent acceptance (Email) notification to applicant.

When an Admin sets the status of an application to "Accepted" the system can send out an email to the applicant to notify them that they have been accepted.
As far as an "acceptance packet" I think it is best to simply have a place where any document can be uploaded for students. The email would be simple and genetic, with a link sending them back to where they applied, and there would be where they can download the welcome packet.

timtimmytime/ywam-staff-webapp-firebase#10


Add support for Two-Factor-Authentication

This PR adds support for two-factor authentication. This should close #86, even if the ticket mentions two-step-auth; which is super confusing a different, older 2-* auth variant from Apple.
Most people will use the modern one that pops up an alert.
This now works with my account, but should be tested with a few more people.
This uses API that's 10.9 and higher, I assume that's fine? AppKit is already dirty enough :)
Binary (DEBUG release, but performance doesn't really matter here)
https://cl.ly/102644223v3y
Please help test this and report if it works in the comments

Works for me!

Just tested and it works for me, and this is the first time I've just submitted a radar with this tool 🎉

One minor nit: the button in the dialog that takes the 2FA code should be labeled "OK", not "Ok".

Also, it appears that the 2FA code isn't being persisted. Each time I submit a Radar, I get the 2FA map and code.
This may be a general problem with RadarWeb right now, because I get the 2FA map and code each time I login to the web, too.

Force-pushed to fix the "Ok" bug. shame bell

I never managed to get the browser to be trusted for Radar. Filed rdar://29131649 a while back on that. Feel free to dupe - would be so great if this could persist for 30 days.

Personally I think the real issue is that you're prompted at all on the machine you're trying to log in with. I've always wondered, doesn't that defeat the entire purpose of 2FA?

@steipete Yep, I'll definitely dupe that (and it's Exhibit #15432 that Apple doesn't really get web services.)

@dlo You're prompted on up to 5 "trusted" devices, configurable.
@chockenberry digit1 digit2 digit3 digit4 digit5 digit6 BECAUSE 😂

@steipete Every time Apple releases a new web product, they have 2FA growing pains. Search Ads and RadarWeb are just the latest.
Compare that with Google that has ONE screen for doing 2FA for ALL their various products.
Which do you think is easier to keep secure and up-to-date?

Also relevant: The login-variant that @KrauseFx used in fastlane is quite different (but again, different part of Apple's backend)

@amyworrall Did you had a chance to look into that yet?

Thanks for merging! I think there's a new issue with the componentID missing, but that's unrelated to this one - will open a new ticket once I find out more. The fun never stops :)


Drop Folders Don't Overwrite Files

If I drop folder with full series and one with just a vol, then the vol items arent moved to output folder - probably because of same name/hash. Can we move those (overwrite) destiny or delete duplicates from source?

Drop folders don't overwrite files. If they are duplicated, then delete them. If they are just the same name, use the rename utility or something so they aren't. We don't rename files unless the user has it set, and we let the user handle multiple copies of the same episode.

It dont delete them.
Also when I put something in input folder the logical way would be: As JMM see what it is it recognize it, but instead it treat it as not recognized (same as it wouldn't find it in anidb because it leave it there)

That's how it treats multiple copies. It isn't supposed to delete, rename, or anything by itself. Use the utility for multiple files to resolve them. JMM does not support multiple files for the same episode at this time (and I don't think anyone has plans to).

sure is it the intended way ? As I have same file in collection it should delete recognized duplicate file if its inside drop folder - because it how it works now, it dont recognize it as duplicate if it is in not destination folder in this case - Im talking just about Source/Destination Folder case - I dont care about duplication in full collection as that is coverd by utility as you said

Ideally if it's a duplicate file, it should just add a "1" to the end of the filename and then the user can delete them in Desktop.

Both are logic imo, and yours is the simplest solution - as when jmm find series it move it to output folder which is the ideal thing.
Also adding number to filename before extension ;-)

I will try to add this functionalyty to make it the best logical way
If jmm know the series and its already in output folder add number (iterated) to end of file name (without extenstion) and move it to proper folder

I was looking in the code for something else and came across this in VideoLocal_Places.cs
FileSystemResult<IObject> dst = f.Resolve(newFullServerPath);                 if (dst.IsOk)                 {                     logger.Trace("Not moving file as it already exists at the new location, deleting source file instead: {0} --- {1}",                         this.FullServerPath, newFullServerPath);
Your file should be automatically deleted if it already exists in the DD.

But its not, or thisis new
On September 30, 2016 1:42:56 PM GMT+02:00, ElementalCrisis<EMAIL_ADDRESS>wrote:

I was looking in the code for something else and came across this in
VideoLocal_Places.cs
FileSystemResult<IObject> dst = f.Resolve(newFullServerPath);                if (dst.IsOk)                { logger.Trace("Not moving file as it already exists at the new location, deleting source file instead: {0} --- {1}",                        this.FullServerPath, newFullServerPath);
Your file should be automatically deleted if it already exists in the
DD.
--
You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub:
https://github.com/japanesemediamanager/jmmserver/issues/444#issuecomment-250724359

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

That's been there for awhile so we probably need to trace it and find out why it's not working.

I inspect code. It was moved to different place + it had little refresh by Max, and for testing in latest git version it does work.
Also there is trace like you mention - I only dislike the delete of file is made but probably someone want to stick with "custom class" for that - most important thing is it work ok.
It could be also the class problem as this function use
FileSystemResult fr = source_file.Delete(true);

After release 3.7 - we should test it and if that async task make problem we could allway put try {} catch{} with File.Delete and File.Exist closure.

Currently Im unable to reproduce it but Im unsure if this is thanks to fix for #445 or by not having right input.

The original JMM behavior is delete the file, the file is duplicated,
exactly the same file, since they have exactly the same hash. This only
happens off course if the Import Folders are in the same filesystem
(Local<->Local) (Amazon<->Amazon), etc.
On Wed, Oct 5, 2016 at 9:13 AM, BigRetroMike<EMAIL_ADDRESS>wrote:

Currently Im unable to reproduce it but Im unsure if this is thanks to fix
for #445 https://github.com/japanesemediamanager/jmmserver/issues/445
or by not having right input.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/japanesemediamanager/jmmserver/issues/444#issuecomment-251657149,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHDbSVqftYaiz8KftoKgqZoptBMoWzLks5qw5RkgaJpZM4KHkiW
.

The problem is that there are some fluctuation from that behavior.
It looks like that at random time it wont delete it.
Before - as me (<IP_ADDRESS>) and @da3dsoul (<IP_ADDRESS>) noticed.
It so random that I wasn't able to reproduce it while more than hour of testing - maybe its depend of async/task queue or time of querying db. dunno..

I've not had this issue in weeks now. I'll close it and we can reopen if it becomes a thing again


Improved yet an other time the nick promp.

When the name is invalid, it tells why.

I have a note about this.
In the prompt, if we choose our own user name, the function detects a conflict and blocks it.
Should we improved the userDuplicate function so that in this case no collisions are detected?

See this: https://github.com/Arkaeriit/devzat/pull/2

Thanks!


attack success rate seems different from paper

hi, when I try to reproduce your results in Table 1, results seems different from that in paper.
For example, using AMT-GAN/test.py, I try to calculate ASR of clean image in CelebA-HQ,  attacking ir152, the results are 0.02,0.019,0.017,0.049, while in paper it's 3.80. The corresponding test image IDs are: 008793, 047073, 055622, 166607.
I wonder if I miss something.
Thanks!

Hi,
In the current repository of AMT-GAN, we have added an additional loss in the cycle reconstruction path (See backbone/solver.py Line312-313, Line393-394). This will make the AMT-GAN generate more stable and natural face images (FID degrades from 34 (in our official paper) to 27). As a trade-off, it will slightly affect the attack strength. If you want to have a better ASR or just want to reproduce the results, delete self.LPIPS(fake_A, image_s), self.LPIPS(fake_B, image_r) in Line312-313, self.LPIPS(purified_A, image_s), self.LPIPS(purified_B, image_r) in Line393-394.

Hi, thanks for clearing this. There is LPIPS loss on page-6 (eq. 11) of the paper. Have you used it for visual results in the paper (in Fig. 4)? and remove it during calculation of ASR?


feat: don't mark policy as uniquely reachable until all terminating pods have disappeared.

Description
Don't skip pods with deletion timestamp in the isUniquelyReachable method
Fix https://github.com/kubewarden/kubewarden-controller/issues/242

Tested it here locally with kubewarden-controller:latest now that is released, and all fine!


[sailfish-secrets] Fix master lock key initialization. Contributes to JB#42034

This still currently requires that a crypto plugin is present which can perform key derivation (in order to implement the requirement from IZh regarding using PBKDF to generate a key from the input data, see his response to my email "Open question about the semantics of device-locked collections").
Perhaps we should allow the initialization to succeed even if no crypto plugin capable of performing key derivation is present, and simply store a dummy/null key in that case?

Perhaps we should allow the initialization to succeed even if no crypto plugin capable of performing key derivation is present, and simply store a dummy/null key in that case?

As far I see the default OpenSSL plugin should be always present. I would vote not to support installations where no crypto plugins are present.

I agree that making the default plugin (for each plugin type) configurable is a good solution.

Thanks, rebased, merging now.


Mount snapshots on Windows

This PR is just a rebase of #4419.
@TBBle is currently on sabbatical so I will try to move the two PRs (this one and the one in https://github.com/microsoft/hcsshim/pull/1637), forward.
All needed context for this PR is available in #4419 .
In addition to the great work done in #4419, this PR makes use of the Bind Filter in Windows, which gives us functionality similar to what we have on Linux via bind mounts. It allows us to avoid some Windows special cases.

Depends on: https://github.com/microsoft/hcsshim/pull/1637
Depends on: https://github.com/containerd/continuity/pull/212
Depends on: https://github.com/containerd/continuity/pull/219
Depends on: https://github.com/microsoft/go-winio/pull/274

Note: This PR will fail to build without the above mentioned dependency. Marking it as draft for now. Also, there is still some cleanup I need to do (ex: remove unused functions), which will be addressed shortly.

Dropped commit https://github.com/gabriel-samfira/containerd/commit/6dae7f9bd046fff48780e9c25e16486f84b3a569 as we're using the bind filter, which doesn't use junction points. Thus, this issue should not manifest.
Also, with the change to continuity (https://github.com/containerd/continuity/pull/212), we'll also get a proper diff between layers.

The snapshot tests require the SeBackupPrivilege and SeRestorePrivilege to have access to system files inside the container layer mount points.

This commit: https://github.com/containerd/containerd/pull/8043/commits/03ffa12b09807cd9321d2635089ebcbb3d6b5bd4
Adds two new files, one of which is generated code via mksyscall. I can add the headers to one of them, but the other one is generated. Any tips on how to handle this situation? Should this be moved in some other package?
@helsaawy Do you think something like this should be added to go-winio? Any other suggestions are welcome.

@gabriel-samfira Ping me when this is ready!

@gabriel-samfira Ping me when this is ready!

You bet! The more reviews and scrutiny this gets, the less stressed I'll be that I made a silly mistake somewhere which will blow up later :smile: .

Hi @dcantah !
If you have the time, feel free to review this branch. Sadly, I didn't get all the "metadata" files in the previous PR to continuity. I opened a new one here: https://github.com/containerd/continuity/pull/219.
In this branch, I have a temporary hack that points to my continuity branch, but other than that, this should be ready to review. Have a look when you get a chance!
Thanks!

Woo! I'll definitely carve out some time this week

Integration tests seem to have passed! :smile: . Well...everything aside from a couple of Vagrant BOX tests.
https://github.com/containerd/containerd/actions/runs/4297996002

Oh, we aren't seeing the test failures that lead to bd51841? Awesome!

If it was "File in use" it may have been an older bug. I remember fixing one like that here:
https://github.com/microsoft/hcsshim/pull/1249
Not sure if it is the same one you were seeing back in 2021 😄 .
Increasing the timeout sounds prudent (we had to do it before on Windows). Will probably do that in a separate PR.

Oh. A quick look at the test run suggests we might need to bump the Windows Integration test-run time-limit, it's currently 50m, and one of the four runs hit this in a very late stage (critest execution). The other three are also really close, so I don't think this was a failure or problem, it's just that with the new tests enabled from the snapshot suite, the expected runtime is longer. I'm guessing 60 minutes would be enough, but to avoid false-negatives, perhaps 90m?

@aznashwan was kind enough to open a PR for this here: https://github.com/containerd/containerd/pull/8183
Thanks @aznashwan !

Marking this as ready for review, as there is just one simple PR it depends on, and it would be useful to get more eyes on this sooner rather than later.

Oh, we aren't seeing the test failures that lead to bd51841? Awesome!

If it was "File in use" it may have been an older bug. I remember fixing one like that here:
microsoft/hcsshim#1249
Not sure if it is the same one you were seeing back in 2021 😄 .

That won't be it, as the one I was hitting was triggered by running the snapshotter test suite in parallel mode (basically the 128 layers test alongside some other test would trigger it about 60% of the time on Server 2019, passing just often enough to give me false hope), and so there were no containers/shims involved. I thought I'd fixed it when I found an unclosed handle in an old version of the "base layer manipulation" PR, and when I pulled that in, it reproduced on Windows 2022 as well. >_<
We also occasionally saw the same error happen during other test runs in containerd main, although the bug you fixed above might have been that as those tests would probably have involved containers, as outside this PR, the Windows snapshotter is not being run through the snapshotter testsuite, only in trivial "Import/Export" tests and the container-running test suite.

We also occasionally saw the same error happen during other test runs in containerd main, although the bug you fixed above might have been that as those tests would probably have involved containers, as outside this PR, the Windows snapshotter is not being run through the snapshotter testsuite, only in trivial "Import/Export" tests and the container-running test suite.

I've been running sh.exe -c "EXTRA_TESTFLAGS=-test.run=TestSnapshotterClient make integration" locally for a while now without issues. Most errors have been in regards to differences due to "metadata" files, and a few that were due to not having access to read system files. Both of which have been addressed. Whatever bug was triggering that was probably fixed :crossed_fingers:

Edit: Thinking about it, since the check128LayersLockstep test in that reliable repro link is self-contained, it might be worth adding it into this PR and making sure it passes on CI. Maybe not worth adding to containerd main though, since it's a trimmed version of a test that already exists.

The check128LayersLockstep should run as part of this PR. Test output is suppressed, but it should run, both as part of make integration and as part of make test.

Sorry, check128LayersLockstep wasn't ever in this PR series, it was on my "Hack until I can nail down this bug" branch derived from it, you can see it in all its glory in https://github.com/TBBle/containerd/commit/50052cbca4ff98ddbba5036cefcddd4a64080ea8#diff-0c729c2c9e5ed5e5402da537dceb59655a78b9f6ac17cb7a9a17a94232403b15R1146-R1191.
It's basically the minimised version of 128LayersMount that still reliably triggered the bug, and then rigged up to be run in 10 parallel instances with itself, which gave me basically a 100% repro rate if I ran just that suite. (You can see in that commit that I had disabled the rest of the snapshotter suite so I'm guessing I was using the same -test.run=TestSnapshotterClient parameter you mentioned above to trigger it.
Per https://github.com/TBBle/containerd/commit/46efff17508c81b49d931b960fc6ff7972d43287, commenting out the mount.All would stop reproduction, so whatever was going on was somewhere inside the mount.All (or paired unmount) call. Looking at the history of that branch, I don't appear to have ever nailed down what specifically inside that was actually reproducing the problem.
Thinking back, I don't think it occurred to me to try removing just the volume mount point manipulation, so this being fixed in-passing by switching to bind-mount is definitely feasible, but doesn't given any insight into why I couldn't reproduce this with hcsshim directly, unless I wasn't doing the mounting in my attempt to reproduce it there.

Should have some spare hours tomorrow, but there's a couple bits of feedback I left here to get started!

Should have some spare hours tomorrow, but there's a couple bits of feedback I left here to get started!

Thank you, @dcantah ! I think I addressed the current comments. Can't wait for the next round :smile:

CC: @helsaawy
If you could have a quick look over this PR, it would help a lot. Feel free to tag anyone else that may have input.

Updated continuity to latest commit and removed the hack that redirects to my branch. Tests seem to pass, except the Vagrant box ones that do not seem to be related.

Trying to find time for a second look, haven't forgotten about this! Also, seems there's a merge conflict

Also, seems there's a merge conflict

Ohh! That's new. Wasn't there this morning. Will rebase asap

Well, that didn't last long 😄 . I'll have to rebase again.

CC: @kevpar
If you could have a quick look over this PR, it would help a lot.

This seems like one of those types of changes where you put some extreme faith in the tests

That kind of happens with all code tbh :smile:. Luckily, the tests abuse this functionality quite a bit (bind filter included). Seems to not blow up, and appears to work as intended.

GitHub/Azure seems to be having an issue today. Failures due to timeouts.

/ok-to-test

Hi @dmcgowan @estesp @kevpar
Could you spare a few minutes to look over this PR?

Thank you @kzys !
Addressing the nits now.

/lgtm

Anyone able to check this in? We have 4 approvals from maintainers

Woo, and I cannot emphasise this enough, hoo!

Woo, and I cannot emphasise this enough, hoo!

There are [insert_favorite_beverage] I need to send your way :smile:.

@gabriel-samfira @TBBle thanks for making this and your patience.

Thrilled to see this land finally 🥳


Incorrect values for Sorensen-Dice coefficient

Hi,
I am looking at the output values for the Sorensen-Dice coefficient to compare with a new implementation for Java.
I just installed the library in an environment with Ubuntu LTS, Anaconda Py 3.6, via pip install textdistance. Then tried the example from the Wikipedia page, where f('night', 'nacth') = 0.25, with bigrams.
Haven't looked at the Python code yet, but is there any parameter that I must use to get the same value from the Wikipedia page? Here's what I tried in the console.
Python 3.7.2 (default, Dec 29 2018, 06:19:36)
[GCC 7.3.0] :: Anaconda, Inc. on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import textdistance
>>> textdistance.sorensen
<textdistance.algorithms.token_based.Sorensen object at 0x7f6c702d6f98>
>>> textdistance.sorensen("night", "nacht")
0.6
>>> textdistance.sorensen_dice("night", "nacht")
0.6
>>> textdistance.__version__
'3.0.2'

Cheers
Bruno

Thank you for your issue. On the wiki, the example uses comparing words as bigrams. You can set up the size of q-grams via qval argument:
textdistance.Sorensen(qval=2)("night", "nacht")
# 0.25

Some possible questions:

Why qval=1 by default?

One of the goals of TextDistance is to provide a universal interface for all algorithms. So, all algorithms have to have the same default value for the same parameter.

Why all parameters passed only in classes, not in the functions?

This is for compatibility with Python 2. Most of the functions can get more than 2 sequences as arguments, but Python 2 doesn't support any arguments (except **kwargs) after *args.
I hope, textdistance really works for you :)

Thanks for the quick and really detailed answer!


[Hold for payment 2024-10-06][$250] Android - expense-On opening 1st expense with 1:1 user, receipt placeholder flickers

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:

Launch app
Login to a new gmail account
Open 1: DM with a user
Create a expense
Open the expense
Note the receipt placeholder

Expected Result:
Receipt placeholder must not flicker.
Actual Result:
Only in gmail Android app,on opening 1st expense with 1:1 user, receipt placeholder flickers.
Workaround:
Unknown
Platforms:

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/13be6298-cdd0-4928-b05c-e8e5db6ed36d

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021837170951789576068
Upwork Job ID:<PHONE_NUMBER>789576068
Last Price Increase: 2024-09-20
Automatic offers:

rayane-djouah | Reviewer | 104094404
nkdengineer | Contributor | 104094406

Issue OwnerCurrent Issue Owner: @rayane-djouah

@isabelastisser  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
Only in gmail Android app,on opening 1st expense with 1:1 user, receipt placeholder flickers.
What is the root cause of that problem?
Here is the log when adding a useEffect in MoneyRequestView
useEffect(() => {
    console.log("LOGMOUNT");
    return () => {
        console.log("LOGUNMOUNT");
    }
}, [])

This component is mounted and unmounted several times.
This happens because the deprecated withOnyx HOC in ReportActionsView that cause the weird lifecycle of the component
https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/pages/home/report/ReportActionsView.tsx#L552
What changes do you think we should make in order to solve the problem?
Remove withOnyx in ReportActionsView and use useOnyx hook instead.
OPTIONAL: We can also do this for ReportActionsItem
https://github.com/Expensify/App/blob/bbc0919a780de49d4f9007976dfbefa275eef879/src/pages/home/report/ReportActionsView.tsx#L552
The test branch here.
What alternative solutions did you explore? (Optional)

@thienlnam, can you please review the test proposal? Thanks!

@rayane-djouah @nkdengineer I processed the payments in Upwork. Thanks!


IE 10 & iframe option

Hi,
the iframe option of jAlert doesn't seem to work in Internet Explorer 10.
I also tried the example at http://flwebsites.biz/jAlert/.

I'll test as soon as I can. Thank you for the heads up!
------ Original Message ------
From: "Jan"<EMAIL_ADDRESS>To: "VersatilityWerks/jAlert"<EMAIL_ADDRESS>Sent: 7/15/2015 10:09:09 AM
Subject: [jAlert] IE 10 & iframe option (#13)

Hi,
the iframe option of jAlert doesn't seem to work in IE 10.
I also tried the example at http://flwebsites.biz/jAlert/.
—
Reply to this email directly or view it on GitHub.

Note: In contrast, Internet Explorer 11 works ;)

Thank you for the additional details! :)
------ Original Message ------
From: "Jan"<EMAIL_ADDRESS>To: "VersatilityWerks/jAlert"<EMAIL_ADDRESS>Cc: "Shane Stebner"<EMAIL_ADDRESS>Sent: 7/15/2015 10:10:04 AM
Subject: Re: [jAlert] IE 10 & iframe option (#13)

Note: In contrast, Internet Explorer 11 works ;)
—
Reply to this email directly or view it on GitHub.

I'm at work and don't have access to IE10, I pushed a possible fix. Can you please test it?

Perfect! That fixed it. Thanks fort the quick fix ;)

Awesome!


GCP Pubsub broadcast message published to a topic to multiple INSTANCES

My usecase:
We have set of data which doesnt change too often where we want to have local cache. When the data changes we want to use event driven mechanism to send the message so that the message gets broadcasted to all the nodes of our application (across multiple regions).
Using GCP pubsub its 1-1 correlation between topic / subscription. i mean for an application we can only have one subscriber per topic.
How can we achieve broadcasting the message to multiple nodes across different regions of our applicaiton ?

@meltsufin @ChengyuanZhao

@vineela-gampa Why do you say that you can only have one subscription per topic, if I understood you correctly? A broadcast scenario is achieved where there is a single topic and each node has a separate subscription to that topic. If you are using Spring Cloud Stream, we will even automatically create an anonymous/ephemeral subscription for each of your node/consumers.

This doesn't sound like a bug report or feature request.
All your nodes must have unique subscriptions to the same topic. That's how you can broadcast the same message.
See Pub/Sub docs for more info: https://cloud.google.com/pubsub/docs/overview


images: Use cilium-builder image instead of golang to build hubble

The hubble image currently uses the golang docker image within the build stage. This commit modifies the build stage to use the cilium-builder image instead which contains the necessary tooling to allow for arm64 builds in CI workflows that run on amd64 machines.
See https://github.com/cilium/cilium/pull/35351 and https://github.com/cilium/cilium/issues/35324 for more context.

/test

/test

/test

/test

/test

hmmm eks test keeps failing. @learnitall do you wanna try rebasing and see if it helps? 💭

Just pushed a rebase @michi-covalent, let's see if that helps.

/test


Add render-prop version of withTranslations

With render-props we won't have naming collision, and they also play
nicer with typed languages.

Coverage remained the same at 100.0% when pulling 6aeabb1121383732588d7f3886ad013cecb2d33c on render-with-translations into 9cc0a7aa017c4dcf41f72a25faa01a46fb4590a0 on master.


Better Pull (Fix Crash + Version Bump)

Fix Crash

This was already fixed by #3. I'm sorry for the wasted time.


"If playback doesn't begin shortly, try restarting your device"

First of all, I love this extension.

Sometime in the last 24 hours, for some reason, YouTube suddenly stopped being able to play videos while this extension is active. Disabling/removing the extension fixes this issue. Assuming they patched something in the back end? I'm not sure. Hope this is able to be resolved. Thank you

Yeah, they seemed to have rolled out a "custom" setting to their speed controller. It lets you get more granular control but still maxxes out at 2x which is too slow for me.


handle recursion

recursion is very forbidden. the julia-side expression sanitizer catches direct recursion, i.e. functions calling themselves directly. more complicated cases are not yet handled, like
f(x) = g(1)
g(x) = f(100)

Because of our demutation parsing we require that variables are defined before they can be used. Thus code has to be properly ordered, and the above example is now forbidden.
This does not mean that the problem is solved, the following example still gives an infinite loop:
julia> typecheck_hs_from_string("
           g = 0
           f(x) = g(100)
           g(x) = f(1)
           ")

Since this issue was written we switched away from our delayed typechecking monad.
See d7a2b3d, #138, #140.

The case list above seems exhaustive. Tests added.


Logging services on not supported devices

Related to #226. This PR adds logging of services when DFU service or characteristics were not found. The log will list available services/characteristics and will suggest a solution.

@DevAndArtist any more comments?

I'll check it a little bit later more in detail.