refactor and organize code

@ayushkavad, you can directly contribute by creating a branch over here. It will help us collaborate better, by working on the same branch - which isn't master.

@ayushkavad, you can directly contribute by creating a branch over here. It will help us collaborate better, by working on the same branch - which isn't master.

I didn't check that you already use this repo as the main, thanks!

@ayushkavad, please merge these changes in the v2.0 branch.

@ayushkavad, please merge these changes in the v2.0 branch.


Missing required phony target "test"

Hello, thanks for this awesome plugin.
How do I remove the requirement for "test" from a makefile?
I have a makefile like this:
.PHONY: one two all
one:
    sudo some-cmd

two:
    sudo another-cmd

all: one two

I get an error E  Missing required phony target "test" checkmake (minphony) [1, 1]
If I add test it goes away.
.PHONY: one two all test

I'm just writing basic shell scripts, I'm not compiling code. I'm running neovim with none-ls and I'm getting errors indicating that I need test clean all. I did not write a custom plugin.

none-ls and checkmate are essentially the same plugin, both run linters and inject the results via LSP. So they should not be used together, either use checkmate or none-ls.
I'm also not sure where this error comes from, its definitely not from checkmate as we are not using any Makefile or errors of this type.


Transfer Failure

Last night 19.02.2021, around 22:10 EST I initiated a transfer of around $75 of ATOM from my Coinbase account to my Atomic Wallet and have yet to see it completed. Please help.

Same here

Any news on a solution?
On Fri, Feb 19, 2021, 1:26 PM pdubb12003<EMAIL_ADDRESS>wrote:

Same here
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/forbole/big-dipper/issues/460#issuecomment-782255416,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS5FCHOP6MNSOTRNZZPXYWLS72UOXANCNFSM4X4M6BOQ
.

Haven't heard anything here they must be still working on the problem someone said there was an update to the system yesterday so idk but it's frustrating

Thank you for the report. This is a duplicate of #456.

@pdubb12003 Yes there was an upgrade of Cosmos Hub yesterday which enable IBC. The Big Dipper now running is a newer version which may have issue targeting the latest build.


Highlight code snippets in Readme

Added highlighting for Java, XML, Gradle snippets

Hmm didn't think to do that, cool :) Thanks!


⚠ ClamAV has degraded performance

In c998d0e, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 464 ms

Resolved: ClamAV performance has improved in 58c3d79.


Fixed some typos and grammer in README.md

Fixed a few typos in README
Description
Added a missing comma, added a space in "overtime"

Thanks!


Add audit log to Nutanix control plane template (#7190)

Issue #, if available:
This is a manual cherry pick of https://github.com/aws/eks-anywhere/pull/7190 to release-0.18 branch.
Description of changes:
Add audit log to Nutanix control plane template

add extra args for audit logs
add required extra volumes
change test manifests

Fixed comments and missed unit test
# Conflicts:
#	pkg/providers/nutanix/config/cp-template.yaml
#	pkg/providers/nutanix/testdata/expected_cluster_api_server_cert_san_domain_name.yaml #	pkg/providers/nutanix/testdata/expected_cluster_api_server_cert_san_ip.yaml

Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/retest

/retest

/approve

/lgtm


Fix race condition in Packet.MarshalTo()

Description
This was already fixed by #168 but got lost in #227. in SFUs, in order to distribute a packet to all clients, MarshalTo() is called in parallel by multiple routines, causing a race condition because the padding flag is dynamically set inside MarshalTo(). This is particular annoying when running automated tests. This PR fixes the issue by removing this write operation as discussed in #168.

Hi @aler9 , Upgrade from 1.8.0 to 1.8.1, my h264 stream is broken. I have set rtpHeader.Padding = true before, and remove this made the stream ok again.
Is it required that we must not set the rtpHeader.Padding value?

Eventually we could add a consistency check in MarshalTo that returns an error when Header.Padding is true and PaddingSize is zero.

Here's my part of code about send rtp packet:
	pkt := rtp.Packet{Header: rtp.Header{
		Version: 2,
		Padding:        true,
		Extension:      false,
		Marker:         (subindex == subcount),
		PayloadType:    videoMedia.Formats[0].PayloadType(),
		SequenceNumber: seq,
		Timestamp:      rtpTimestamp + index*RTP_VIDEO_TICK,
		SSRC:           ssrc,
		CSRC:           []uint32{0},
	}, Payload: buf.Bytes()}
	rtspClient.WritePacketRTP(videoMedia, &pkt)

I didn't set PaddingSize. the code works in 1.8.0, but not in 1.8.1.


adding a fabform.io contact form

Hello
Is there anyway you can add a https://fabform.io contact form to your theme?
Geoff
https://fabform.io

Hello!
Ed theme is not strictly tied to any forms backend. You can easily use any backend like Formspark, Formspree, FabForm and so on just by changing the formAction parameter in the site configuration file:
https://github.com/sergeyklay/gohugo-theme-ed/blob/8c3b97e3307764821ca9aade0af6d8f5aa0907d7/exampleSite/config.toml#L152-L158
For a more subtle configuration of the contact form itself, you can also replace layouts/shortcodes/form-contact.html partial in project wide level.


without main function??

hello, why your code have not main function??

and where the Shape predictor file??


Block Expressions throw exception if Markdown syntax detected.

Describe the bug
Block Expressions throw an error if markdown syntax detected within block.
To Reproduce
Consider the following grammar...
{{#if rebateEntitled}}
The agent will be, or is likely to be, receiving a rebate or rebates.
{{else}}
The agent will not be, or is not likely to be, entitled to any rebate in respect of\
...any outgoings; or\
...any prepayments made by a person engaging or appointing the agent (the client) in respect of any intended expenditure by the agent on the client's behalf; or\
...any payments made by the client to another person in respect of the work.
{{/if}}

The above renders fine.
Now consider the following grammar...
This is a contract
{{#if rebateEntitled}}
The agent will be, or is likely to be, receiving a rebate or rebates.
{{else}}
The agent will not be, or is not likely to be, entitled to any rebate in respect of\
- any outgoings; or\
- any prepayments made by a person engaging or appointing the agent (the client) in respect of any intended expenditure by the agent on the client's behalf; or\
- any payments made by the client to another person in respect of the work.
{{/if}}
This is more text

The above fails with error: Cannot read property 'length' of undefined due to the - chars which are interpreted as unordered list syntax.
Now consider the following grammar...
{{#if rebateEntitled}}
The agent will be, or is likely to be, receiving a rebate or rebates.
{{else}}
The agent will not be, or is not likely to be, entitled to any rebate in respect of\

...any outgoings; or\
...any prepayments made by a person engaging or appointing the agent (the client) in respect of any intended expenditure by the agent on the client's behalf; or\
...any payments made by the client to another person in respect of the work.
{{/if}}

The above fails with error: Cannot read property 'length' of undefined due to the blank line within the {{else}} block.
Expected behavior
Expect the Conditional block to consider all chars, that are not part of the Block syntax, be treated as plain text and no error be thrown.
Similarly, expect the new / blank line to be treated as plain text and/or converted to a hardline break (e.g. \) and not throw an error.
Version
Cicero v0.21.5
Additional context
ifelse.zip

Thanks again for the detailed report, @martinhalford. Just a couple of clarifications for the purpose of issue triaging this:

some markdown is allowed inside conditionals (and join/optional/etc), but is limited to commonmark inlines (i.e., strong/emph/code/html inlines). If the text spans multiple commonmark blocks (i.e., multiple paragraphs, lists, block quotes) the template conditionals/optionals etc will not be detected by the parser.

For instance, this is fine:
This is a markdown {{#if foo}}(with some _conditional_ text, with some `code` and <html/> in it){{/if}} inside a **paragraph**.

but this isn't:
This is a markdown {{#if foo}}(with some _conditional_ text).

(also with some `code` and <html/> in it){{/if}} across two **paragraphs**.

This behaviour is consistent with other inline markup in commonmark. Here is an example with emphasis:

The behaviour is expected to be similar to the one for the inlines markup (like emphasis) i.e., it should gracefully fall back to text parsing (as with emphasis in the example above) rather than raise an error. This is meant to remain consistent with the very first line in the commonmark spec:

Any sequence of characters is a valid CommonMark document.

Note that the reason for the error, isn't quite due to wrongly parsing the block-level markdown, but likely due to faulty logic handling closing tags (or missing closing tag since {{/if}} isn't present, within a single block. Likely fixes should happen in the following part of the markdown-it-cicero and markdown-it-template plugins:

https://github.com/accordproject/markdown-transform/blob/master/packages/markdown-it-template/lib/template_inline.js
https://github.com/accordproject/markdown-transform/blob/master/packages/markdown-it-cicero/lib/cicero_inline.js

Thanks @jeromesimeon - I kinda expected that the new line would throw an error and, indeed, this can be mitigated by added a \ to the paragraph, and that then works fine.  If the - and other unsupported markdown syntax could revert to plain text then that would be great!

A few minimal tests for this issue, for convenience.
mini.zip

More tests for this based on the issuer's example
inlines.zip
With the fix in #341

closing inline blocks (e.g., {{/with}}) without a matching opening inline block (e.g., {{#with}} will not raise an error anymore but be treated as text
opening inline blocks (e.g., {{#with}) without a matching closing inline blocks (e.g., {{/with}}) will not raise an error anymore but are automatically closed at the end of a paragraph/heading etc.

This should result a proper / better documented semantics for the various templates grammars from the example.
For instance:
This is a contract
{{#if rebateEntitled}}
The agent will be, or is likely to be, receiving a rebate or rebates.
{{else}}
The agent will not be, or is not likely to be, entitled to any rebate in respect of\
- any outgoings; or\
- any prepayments made by a person engaging or appointing the agent (the client) in respect of any intended expenditure by the agent on the client's behalf; or\
- any payments made by the client to another person in respect of the work.
{{/if}}
This is more text

Is effectively treated as:
This is a contract
{{#if rebateEntitled}}
The agent will be, or is likely to be, receiving a rebate or rebates.
{{else}}
The agent will not be, or is not likely to be, entitled to any rebate in respect of\{{/if}}

- any outgoings; or\
- any prepayments made by a person engaging or appointing the agent (the client) in respect of any intended expenditure by the agent on the client's behalf; or\
- any payments made by the client to another person in respect of the work.
{{/if}}
This is more text

With the first {{#if}} closed automatically at the end of the paragraph before the beginning of the list, and the last {{/if}} being treated as text since it does not have a matching {{#if}}

Note: The rule for {{#if}} being only an inline (i.e., it cannot span multiple markdown container blocks) still applies.

Example of the draft command on the third template before #316:
bash-3.2$ markus transform --from data --to markdown_cicero --template grammar3.tem.md --model model.cto --input dataa.json
3:32:42 PM - error: Cannot read property 'length' of undefined

Example of the draft command on the third template after #316:
bash-3.2$ ~/git/markdown-transform/packages/markdown-cli/index.js transform --from data --to markdown_cicero --template grammar3.tem.md --model model.cto --input dataa.json
<data --to markdown_cicero --template grammar3.tem.md --model model.cto --input dataa.json
3:31:23 PM - info:
The agent will be, or is likely to be, receiving a rebate or rebates.
-  any outgoings; or\
-  any prepayments made by a person engaging or appointing the agent (the client) in respect of any intended expenditure by the agent on the client's behalf; or\
-  any payments made by the client to another person in respect of the work.{{/if}}
bash-3.2$ ~/git/markdown-transform/packages/markdown-cli/index.js transform --from data --to markdown_cicero --template grammar3.tem.md --model model.cto --input datab.json
<data --to markdown_cicero --template grammar3.tem.md --model model.cto --input datab.json
3:31:31 PM - info:
The agent will not be, or is not likely to be, entitled to any rebate in respect of\
-  any outgoings; or\
-  any prepayments made by a person engaging or appointing the agent (the client) in respect of any intended expenditure by the agent on the client's behalf; or\
-  any payments made by the client to another person in respect of the work.{{/if}}


Batch processing validation

User Story #103513830
As UR I would like the Digital Cash Book updated so that it is ready for user research
This PR adds some validation features around batch processing to closer match original prototype.

:bomb:…:boom:!


Use arena/bump allocator to avoid frequent allocation for SlowHashAggregationExecutor

Feature Request
In SlowHashAggregationExecutor, we allocates N + 2 vectors each time where N is the number of rows:
https://github.com/tikv/tikv/blob/c7f62e63d3e9b4388d7c131262f678cf6b02e10a/src/coprocessor/dag/batch/executors/slow_hash_aggr_executor.rs#L207
which have a very high impact on performance. By using some pre-allocate techniques like arena allocator / bump allocator, we will save the time.

I guess those allocations are unlikely to harm performance a lot. Modern allocators like jemalloc should do well in these small allocations. (However, I haven't benchmarked.)
With an arena, there still can be much trouble. Besides the problem of self-referential in the HashMap key, the Vec we use needs to support expansion. Expansion means freeing the previously allocated memory and allocating a bigger one. Then, we probably need a free-list to store freed memory. Does it look like we are reinventing the wheel? I doubt if we can do better than jemalloc.
What I think is the worst, we have all these problems because we are iterating by column. I know it is for cache friendliness but I think it is actually not cache-friendly instead. Because we don't know the length of each group key, we cannot store them consecutively. Typically, the L1 cache is 32KiB, meaning it has 512 cache lines, but we have 1024 rows. Then, for every column, each access to the group key means an L1 cache miss. Even if we store them consecutively, it is unlikely that we can put all of them in the L1 cache. (32 bytes each key can be the worst case. 32bytes * 1024 = 32KiB, and we usually need something more in L1...)
However, iterating by row is not that bad as people might think. Because the column number is usually small (far less than 512, L1 cache line number), we won't have a lot more unnecessary L1 cache misses comparing to iterating by column. But then, we can encode our keys consecutively. I think the total cache miss number is likely to decrease. Even if you still worry about too many allocations, it's far easier to solve this problem when iterating by row.

When I cut allocations from N * 2 to N, performance simply improved about 30% 🤣

@sticnarf
do you do some experiments?

@sticnarf
do you do some experiments?

I just tried concatenating keys by row and tested using existing benches. No obvious performance improvement or regression. Haven't perfed to see the cache miss count.

@sticnarf It concatenates keys by column due to the limit of a &mut eval interface at that time :)  I guess it should have similar cache miss compared to concatenates keys by row. However, concatenates keys by row is a required implementation if we want no allocation (i.e. what this issue for).

@breeswish The limit of &mut eval interface can be overcome by decoding column ahead of time (like in stream aggregation). But this introduces two (maybe one in HashAgg) allocations per batch.

@sticnarf Yes I know that there is no such limit now.
BTW in top N executor we have a similar demand as in this issue. I am going to use raw pointers everywhere I need to bypass the lifetime checker, for simplicity && performance.. Don't know whether or not it is a good idea.

@sticnarf Raw pointer is probably unavoidable. I've been trying to solve the problem using rental, but I find it more complex than using raw pointers...
Of course, the unsafe code should be reviewed a lot more carefully.

@sticnarf Good to hear that Rental is more complex. Using Rental is indeed another option I considered and is going to try with and now I can totally forget about it XD

@sticnarf
can you show us the benchmark code?

@siddontang This is the change commit: https://github.com/sticnarf/tikv/commit/32da5ad460bc9dbc789f39b7dfa835f273786e56, all other logic (including allocation number) are the same.
For hash_aggr_count_1_group_by_int_col_real_col_2_groups/batch/rows=100000, it shows a regression of 5% when iterating by row:
# iterating by column
$ target/release/coprocessor_executors-10eb385b9884b6a2 hash_aggr_count_1_group_by_int_col_real_col_2_groups/batch/rows=100000
hash_aggr_count_1_group_by_int_col_real_col_2_groups/batch/rows=100000
                        time:   [17.168 ms 17.305 ms 17.508 ms]
Found 2 outliers among 10 measurements (20.00%)

# iterating by row
$ target/release/coprocessor_executors-10eb385b9884b6a2 hash_aggr_count_1_group_by_int_col_real_col_2_groups/batch/rows=100000
hash_aggr_count_1_group_by_int_col_real_col_2_groups/batch/rows=100000
                        time:   [18.477 ms 18.612 ms 18.695 ms]

Iterating by row is slightly more cache friendly:
# iterating by column
 Performance counter stats for 'target/release/deps/coprocessor_executors-10eb385b9884b6a2 hash_aggr_count_1_group_by_int_col_real_col_2_groups/batch/rows=100000 --profile-time 10':

          9,823.07 msec task-clock:u              #    1.000 CPUs utilized
                 0      context-switches:u        #    0.000 K/sec
                 0      cpu-migrations:u          #    0.000 K/sec
            42,698      page-faults:u             #    0.004 M/sec
    38,129,573,616      cycles:u                  #    3.882 GHz                      (62.47%)
   105,967,223,815      instructions:u            #    2.78  insn per cycle           (74.99%)
    17,633,096,280      branches:u                # 1795.069 M/sec                    (75.02%)
         6,859,039      branch-misses:u           #    0.04% of all branches          (75.02%)
    27,566,130,698      L1-dcache-loads:u         # 2806.263 M/sec                    (75.02%)
     1,453,288,508      L1-dcache-load-misses:u   #    5.27% of all L1-dcache hits    (75.02%)
       354,750,828      LLC-loads:u               #   36.114 M/sec                    (49.96%)
        10,635,860      LLC-load-misses:u         #    3.00% of all LL-cache hits     (49.96%)

       9.824185259 seconds time elapsed

       9.756810000 seconds user
       0.066823000 seconds sys

# iterating by row
 Performance counter stats for 'target/release/coprocessor_executors-10eb385b9884b6a2 hash_aggr_count_1_group_by_int_col_real_col_2_groups/batch/rows=100000 --profile-time 10':

          9,792.46 msec task-clock:u              #    1.000 CPUs utilized
                 0      context-switches:u        #    0.000 K/sec
                 0      cpu-migrations:u          #    0.000 K/sec
            43,202      page-faults:u             #    0.004 M/sec
    38,276,377,417      cycles:u                  #    3.909 GHz                      (62.47%)
   107,332,374,847      instructions:u            #    2.80  insn per cycle           (74.98%)
    17,793,767,192      branches:u                # 1817.088 M/sec                    (75.00%)
         7,144,366      branch-misses:u           #    0.04% of all branches          (75.00%)
    28,280,451,211      L1-dcache-loads:u         # 2887.982 M/sec                    (75.00%)
     1,396,071,771      L1-dcache-load-misses:u   #    4.94% of all L1-dcache hits    (75.02%)
       357,387,704      LLC-loads:u               #   36.496 M/sec                    (49.99%)
         9,842,682      LLC-load-misses:u         #    2.75% of all LL-cache hits     (49.97%)

       9.793146287 seconds time elapsed

       9.732540000 seconds user
       0.060479000 seconds sys


Handle partial successful execution

We should be able to deal with executions that get partial success due several reasons (stressed server?) and present propers metrics and report.

Are not we doing this already? I recommended you to change the "processing time" so it also tracks failed connections, that will also be represented in the report rather than "0"... I think this should do the trick for now

Was this already covered by https://github.com/dachad/tcpgoon/pull/23 ?

yes, covered there


total system flight time update & fix

fix landed & takeoff logic
use a 64bit counter for total system flight time

The previous 32bit counter wrapped in ~1.19h, this switches to 2 32bit counters, wrapping in 584942 years.
Follow-up to #6466

Just out of curiosity, why microseconds? Wouldn't seconds be sufficient?

@dagar That also would wrap and we're trying to not have to come back to this later. Who knows what the regulatory requirements are.


fix: RatingQuestion.values validation when values out of range

Description
This PR fixes a bug identified by @dvsrepo, introduced at https://github.com/argilla-io/argilla/pull/3452, since we were just showing a warnings.warn message announcing the DeprecationWarning, but no version was scoped and the RatingQuestion was not valid on the Argilla Server side either, so the warnings.warn should have been a ValidationError instead.
So on, this PR fixes that and replaces the custom validator with Field to rely on pydantic's validation for it.
Closes #3624
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

[X] Add unit tests for RatingQuestion out of range values

Checklist

[X] I added relevant documentation
[X] follows the style guidelines of this project
[X] I did a self-review of my code
[ ] I made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[ ] I filled out the contributor form (see text above)
[X] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Great @alvarobartt !


Minify JSON inside script tags

@stevenvachon, thanks for the idea.

Done. Will be shipped in the next release (0.1.4).


add named export to sum of multiples

see issue #600
(I'm not 100% sure about the const name)

I think sumOfMultiples would itself be good enough name for this.


add test of Armadillo

[x] add C++ test
[x] add armadillo test

closed in https://github.com/jorgepz/myDevOpsTestbed/pull/25


Add a failing e2e test for multiple ports issue for a service in the mesh

Description:
Currently if you create a service in the mesh with multiple ports, it will cause unexpected and undesirable behavior due to how the proxy is configured. More information can be found on #3777.
This PR introduces a failing test to uncover this issue.
This PR is marked as a draft until a PR is opened to resolve the issue.
Testing done:
Added e2e test.
Affected area:

Functional Area

Tests
[x]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project?

No.

Is this a breaking change?

No.

Codecov Report

Merging #4026 (f296f7c) into main (4dcc321) will increase coverage by 0.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4026      +/-   ##
==========================================
+ Coverage   67.54%   68.31%   +0.76%
==========================================
  Files         204      205       +1
  Lines       11639    11631       -8
==========================================
+ Hits         7862     7946      +84
+ Misses       3726     3635      -91
+ Partials       51       50       -1

Flag
Coverage Δ

unittests
68.31% <ø> (+0.76%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/injector/envoy_config.go
83.13% <0.00%> (-3.50%)
:arrow_down:

pkg/certificate/rotor/rotor.go
84.37% <0.00%> (-3.13%)
:arrow_down:

pkg/cli/environment.go
75.51% <0.00%> (-2.76%)
:arrow_down:

cmd/cli/install.go
81.34% <0.00%> (-2.66%)
:arrow_down:

pkg/trafficpolicy/trafficpolicy.go
96.02% <0.00%> (-2.62%)
:arrow_down:

cmd/cli/osm.go
81.39% <0.00%> (-1.11%)
:arrow_down:

cmd/cli/policy_check_pods.go
73.95% <0.00%> (-0.05%)
:arrow_down:

pkg/envoy/bootstrap/config.go
93.91% <0.00%> (-0.05%)
:arrow_down:

pkg/envoy/rds/route/route_config.go
100.00% <0.00%> (ø)

pkg/cli/policy_check.go
0.00% <0.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dcc321...f296f7c. Read the comment docs.

I have mirrored this test to the PR that resolves this issue: https://github.com/openservicemesh/osm/pull/4074/commits

This test was cherry-picked to https://github.com/openservicemesh/osm/pull/4074/commits which was merged. Closing this since it's not required anymore.


LIQO home view - list of available peers

Description
This PR adds the list of available peers to the home view.
Each item of the list represents a peer (foreign cluster) that has been discovered and can be joined with the home cluster. It also shows the type of the connection (if the foreign cluster is in the same LAN as the home cluster or not). There's the possibility to connect to connect with a peer with a simple click. It also describes the status of the connecting process and, in case of connection error, in what phase of the connecting process the error has shown.

Ref. #19


fix libpng sdl error

when one of my testers with armv7 tried to launch the app, this happened

i searched a bit and found that neon thing in png applies only for arm64 and working only arm64, i changed to all arches and it worked, as i understand it, that error appears on all ndks.

There is only one reference to that function in all of Lime and libpng, and that only happens if PNG_ARM_NEON_IMPLEMENTATION == 1.
libpng explains PNG_ARM_NEON_IMPLEMENTATION starting here. I had assumed that line 176 was the deciding factor, but it's also possible that __ARM_NEON__ is defined, in which case it'll use implementation 1 by default. I don't think png-files.xml can test for __ARM_NEON__, so maybe we have to compile the files regardless.

The only other thing is we don't need to compile Arm-specific code for x86 devices. __ARM_NEON__ won't be set in that case.


Snap 1334 : Auto Refresh feature for Dashboard UI

What changes were proposed in this pull request?

Fixed the JQuery DataTable Sorting Icons problem in the Spark UI by adding missing sort icons and CSS.
Adding new snappy-commons.js JavaScript for common utility functions used by Snappy Web UI.
Updated Snappy Dashboard and Member Details JavaScripts for following

Creating and periodically updating JQuery Data Tables for Members, Tables and External Tables tabular lists.
Loading and creating Google Charts.
Creating and periodically updating the Google Line Charts for CPU and various Memory usages.
Preparing and making AJAX calls to snappy specific web services.
Updated/cleanup of Spark UIUtils class.

How was this patch tested?

Manually.

Please review http://spark.apache.org/contributing.html before opening a pull request.

Merging.


1.8.9 Ender IO / Core

There seems to be a problem. I cannot seem to get the Alpha/Beta for Ender IO / Ender Core to work with my 1.8.9

Why was this closed without a solution?

Because without any information on what you are doing, it would take me a couple of days to write down a solution. I'd have to start on how to power on a computer...


Fix ok-lock NameError

Before, if ok-lock raised an exception, we'd get
$ ok-lock
Traceback (most recent call last):
  File "/Users/knrafto/code/berkeley-cs61a/env/lib/python3.4/site-packages/client/cli/lock.py", line 31, in main
    assign = assignment.load_assignment(args.config, args)
  File "/Users/knrafto/code/berkeley-cs61a/env/lib/python3.4/site-packages/client/api/assignment.py", line 19, in load_assignment
    config = _get_config(filepath)
  File "/Users/knrafto/code/berkeley-cs61a/env/lib/python3.4/site-packages/client/api/assignment.py", line 37, in _get_config
    raise ex.LoadingException('No .ok configuration file found')
client.exceptions.LoadingException: No .ok configuration file found

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/knrafto/code/berkeley-cs61a/env/bin/ok-lock", line 11, in <module>
    sys.exit(main())
  File "/Users/knrafto/code/berkeley-cs61a/env/lib/python3.4/site-packages/client/cli/lock.py", line 37, in main
    log.warning('Assignment could not instantiate', exc_info=True)
NameError: name 'log' is not defined

LGTM.


drivers: modem: gsm_ppp: Fix ppp_dev

ppp_dev should be pointing to the net/ppp driver.
Signed-off-by: Yong Cong Sin<EMAIL_ADDRESS>

I have to apologize that this is caused by my #34548 PR. This is causing the gsm_ppp to stop working and result in hard fault as it's ppp handle isn't connected to the net/ppp and ppp_dev is null.
@cfriedt @nashif @carlescufi  can you guys mark this PR urgent?
@rlubos @jukkar @nandojve @mniestroj Anyone has time to review?


Error with Eureka Pen Spinning Demo

hello, I want to test the Eureka with given environment, when I test the traind Pen spinning in Eureka but there is some Error
`JointSpec type free not yet supported!
JointSpec type free not yet supported!
JointSpec type free not yet supported!
[Error] [carb.gym.plugin] *** Could not create contact graph to compute collision filters! Are contacts specified properly?
JointSpec type free not yet supported!
JointSpec type free not yet supported!
[Error] [carb.gym.plugin] *** Could not create contact graph to compute collision filters! Are contacts specified properly?
{'observation_space': Box(-inf, inf, (211,), float32), 'action_space': Box(-1.0, 1.0, (20,), float32), 'agents': 1, 'value_size': 1}
build mlp: 211
RunningMeanStd:  (1,)
RunningMeanStd:  (211,)
=> loading checkpoint '/home/tuna831/eureka/isaacgymenvs/isaacgymenvs/checkpoints/EurekaPenSpinning.pth'
세그멘테이션 오류 (코어 덤프됨)`
I tested other task environment like humanoid but that is good working.
how can I solve this error

same problem   there is no solution on internet.  Chatgpt cannot give answer either.

In isaacgymenvs/isaacgymenvs/cfg/task/ShadowHandSpin.yaml, modify the parameter numEnvs to resolve_ Default: 1
The reason may be that the original parameters are too large, resulting in a complex environment

Met similar issue, fixed with Yyin-Tta's suggestion.

Thank you!


AOT bugs

Hi, thanks for this plugin.
I am gettin some AOT bugs..
Error at node_modules/ng2-img-cropper/src/model/cropTouch.ts:1:9: 'DragMarker' is declared but never used.
Error at node_modules/ng2-img-cropper/src/model/cropTouch.ts:2:9: 'CornerMarker' is declared but never used.
Error at node_modules/ng2-img-cropper/src/imageCropperComponent.ts:1:82: 'Type' is declared but never used.

Hi there, I am running into a similar problem when I try to build my solution with the command: "ng build --prod --aot". I am using angular-cli version 1.0.0-beta.26 and the error message is the following:
ERROR in Type ImageCropperComponent in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperComponent.ts is part of the declarations of 2 modules: ImageCropperModule in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperModule.ts and ProfileModule in /Users/agustin/Documents/projects/surfercoder/arc10/src/app/login/leader/profile/profile.module.ts! Please consider moving ImageCropperComponent in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperComponent.ts to a higher module that imports ImageCropperModule in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperModule.ts and ProfileModule in /Users/agustin/Documents/projects/surfercoder/arc10/src/app/login/leader/profile/profile.module.ts. You can also create a new NgModule that exports and includes ImageCropperComponent in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperComponent.ts then import that NgModule in ImageCropperModule in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperModule.ts and ProfileModule in /Users/agustin/Documents/projects/surfercoder/arc10/src/app/login/leader/profile/profile.module.ts.
ERROR in ./src/main.ts
Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' in '/Users/agustin/Documents/projects/surfercoder/arc10/src'
@ ./src/main.ts 4:0-74
@ multi ./src/main.ts
ERROR in<EMAIL_ADDRESS>Module not found: Error: Can't resolve '/Users/agustin/Documents/projects/surfercoder/arc10/src/$$_gendir' in '/Users/agustin/Documents/projects/surfercoder/arc10/node_modules/@angular/core/src/linker'
<EMAIL_ADDRESS>71:15-36 87:15-102
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>@ ./src/main.ts
@ multi ./src/main.ts
I am just using the ImageCropperComponent and adding it to the declarations section. If I remove it, the solution does not build at all and using the ImageCropperModule the error is different but still not working AoT compilation.
By the way, it works with "ng build --prod" but the resulting bundled files are much more heavy about their sizes.
Thanks in advance for your help.
Best regards.

I am using the angular cli beta 26 also. what does the parameter --aot do ?

Hi @Mihai-B, here you have the information about it taken from the official Angular 2 website: https://angular.io/docs/ts/latest/cookbook/aot-compiler.html#!#compile
But basically, prepares the application for production giving you much more lighter bundled files since it removes all unnecessary dependencies. It start checking all the used modules and dependencies and based on that structure it prepares the final bundle so the third-party libraries/modules you use, should be built with this in mind.
Thanks a lot for your help.
Best regards.

@surfercoder: there really a declaration of ImageCropperComponent in ProfileModule? (imageCropperComponent.ts is part of the declarations of 2 modules: )
also: do you get the same errors as @doorman02 ?

managed to reproduce it - fixing it right now

Thanks @cstefanache! I never got the same errors described by @doorman02 but I got a different one just using the module. Let me know if you want me to only use the module and show you the given error.
Best regards.

I managed to make it working on my side with no change to the library by importing ImageCropperModule in the app module as such:
import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { HttpModule } from '@angular/http';
import { AppComponent } from './app.component';
import { LoginComponent } from './login/login.component';
import {ImageCropperModule} from "ng2-img-cropper/index";
@NgModule({
declarations: [
AppComponent,
LoginComponent
],
imports: [
BrowserModule,
FormsModule,
HttpModule,
ImageCropperModule
],
providers: [],
bootstrap: [AppComponent]
})
export class AppModule {
}
can you please give it a try?

Hey @cstefanache, let me try it on the Mail AppModule. Right now I am using it in a Feature Module as the following:
import { NgModule } from '@angular/core';
import { ImageCropperModule } from 'ng2-img-cropper';
import { ModalModule } from 'ng2-bootstrap';
import { ProfileComponent } from './profile.component';
import { ProfileRoutingModule } from './profile.routing.module';
import { ProfileService } from './profile.service';
import { SharedModule } from '../../../shared';
@NgModule({
declarations: [ProfileComponent],
exports: [ProfileComponent],
imports: [ImageCropperModule, ModalModule.forRoot(), ProfileRoutingModule, SharedModule],
providers: [ProfileService]
})
export class ProfileModule {
}
And the error is quite similar to previous one:
ERROR in Type ImageCropperComponent in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperComponent.ts is part of the declarations of 2 modules: ImageCropperModule in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperModule.ts and ProfileModule in /Users/agustin/Documents/projects/surfercoder/arc10/src/app/login/talent/profile/profile.module.ts! Please consider moving ImageCropperComponent in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperComponent.ts to a higher module that imports ImageCropperModule in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperModule.ts and ProfileModule in /Users/agustin/Documents/projects/surfercoder/arc10/src/app/login/talent/profile/profile.module.ts. You can also create a new NgModule that exports and includes ImageCropperComponent in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperComponent.ts then import that NgModule in ImageCropperModule in /Users/agustin/Documents/projects/surfercoder/arc10/node_modules/ng2-img-cropper/src/imageCropperModule.ts and ProfileModule in /Users/agustin/Documents/projects/surfercoder/arc10/src/app/login/talent/profile/profile.module.ts.
ERROR in ./src/main.ts
Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' in '/Users/agustin/Documents/projects/surfercoder/arc10/src'
@ ./src/main.ts 4:0-74
@ multi ./src/main.ts
ERROR in<EMAIL_ADDRESS>Module not found: Error: Can't resolve '/Users/agustin/Documents/projects/surfercoder/arc10/src/$$_gendir' in '/Users/agustin/Documents/projects/surfercoder/arc10/node_modules/@angular/core/src/linker'
<EMAIL_ADDRESS>71:15-36 87:15-102
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>@ ./src/main.ts
@ multi ./src/main.ts
I will give it a try on the AppModule but it should work with Feature Modules as ng2-bootstrap works based on given code example.
Thanks.

I think that your profile module is exporting the cropper as well

Hi there!
I had the same problem with "declarations of 2 modules"
Solved:
Just remove component from declarations in "imageCropperModule", like:
import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';
// import { ImageCropperComponent } from './imageCropperComponent';
@NgModule({
imports: [CommonModule],
declarations: [
// ImageCropperComponent
],
exports: [
// ImageCropperComponent
]
})
export class ImageCropperModule {
}

Closing issue - related to #95

I have read all  posts and try lot of stuff , but I still have the problem .
what I can read it should be fixed in the  latest version ?
what kind of info could should I supply to get a chance for help ?

after that it showing error can not find image croppersetting , can not find imagecropperComponent in my profile component.


WIP Rebase 4 10 okd 2022 04 23 131357

WIP
Related Issue: https://github.com/redhat-et/microshift/pull/674

CI is still using openshift/release:rhel-8-release-golang-1.16-openshift-4.10 into pipeline:root but golang-1.17 is required :shrug:

/retest

/test e2e-openshift-conformance-sig-node

/retest

/retest

I tagged this container with the new version, since it won't really change:
https://quay.io/repository/microshift/flannel-cni?tab=tags

/retest

@sallyom all tests passed :D :-D congrats

/lgtm sally, excellent work as Ricardo said, thanks a lot for the help here!!
I have also added this to build the community images, we can merge it after yours.


Does not work

It correctly identifies device and status, however when issuing on or off command, an hourglass (circle) goes on for ever...

Hi! thank you for providing feedback <3
I think It was fixed in some commit, check it again and let me know

Sorry for the delay.
In chrome I get clock error: NET::ERR_CERT_DATE_INVALID.
In Firefox I get the behavior I originally described.
No, it does not work.


CT 1477 enrich logging events with data similar to legacy logger

resolves #6222
Description
The legacy logger used logbook.Processor classes to enrich json logs with "extra" data, such as the unique_id. This pull request is to ensure that the structured logging events contain similar data.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[x] I have run changie new to create a changelog entry

Work still to be done: examine logs for sense. Ensure that context vars work correctly with threads. Search out additional logging events that might need enrichment.


Fix socket incompatibility between resty and luasocket

see https://github.com/Kong/kong/issues/4559#issuecomment-492755121

initial mitigation is on the resolver lib: https://github.com/openresty/lua-resty-dns/pull/46


pin boots to TINKERBELL_HOST_IP instead of <IP_ADDRESS>

Description
Reverts the docker-compose file back to pinning boots to TINKERBELL_HOST_IP rather than binding to <IP_ADDRESS>
Why is this needed
Without this it appears that hosts that may have multiple IPs (such as a bare metal host that tinkerbell has been deployed on) fail to properly tftp files to hosts if the traffic enters/leaves the host through separate IPs. For example my host has a static IP of <IP_ADDRESS> before deploying the sandbox on it. Afterwards it also has <IP_ADDRESS>. Without this change tftp requests from the host during pxe booting timeout and fail. With this change the tftp requests succeed.
How Has This Been Tested?
Tested manually on a physical host that is running Tinkerbell from sandbox
How are existing users impacted? What migration steps/scripts do we need?
This should not affect existing users since it reverts back to pre-existing behavior
Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

This is currently working, but I am planning on trying to see if only a partial reversion is sufficient rather than reverting all of the settings back (command line, env variables, and port configuration).

Looks like the port configuration is not needed, so I removed it. The other bits appear to still be needed.

Thanks a lot


Retry-Filter not working on Gateway_timeout status as well as on SERVER_ERROR series argument

Describe the bug
I am trying to use retry filter to retry on another instance of a micro-service if any of the instance fails due to any reason.I tired the spring-cloud-gateway-Retry-filter which takes "statuses" as argument , the retry filter works well when the port of an instance is down but not when I trigger manual timeouts by Hystrix.
I tried to put "series" as an argument but it also works only when port is down not when triggering manual timeouts.
I am not able to understand what is the problem with the my code.
Any help is appreciated, thank you in advance.
It is also fine if there is another method for retries such as ribbon retries which works perfectly in Zuul but not in spring-cloud-gateway.
Repository
Sample
spring:
  application:
    name: Gateway-service
  cloud:
    gateway:
      routes:
      - id : Microservice-1
        uri : lb://MICROSERVICE-1
        predicates:
        - Path=/Microservice-1/**
        filters:
        - name: Hystrix
          args:
           name: default
        - name: Retry
          args:
            retries: 3
            series: SERVER_ERROR,CLIENT_ERROR,REDIRECTION,SUCCESSFUL,INFORMATIONAL
            statuses: BAD_GATEWAY
            backoff:
              firstBackoff: 10ms
              maxBackoff: 50ms
#            exceptions: org.springframework.cloud.gateway.support.TimeoutException
hystrix:
  command:
    default:
      execution:
        isolation:
          thread:
            timeoutInMilliseconds: 3000

I tried ribbon retries same as in zuul but it doesn't work .

Can you retry with Hoxton.SR1


[FEATURE] Prevent double backslashes when replacing a snippet

Description of the Problem

Let's take {trigger: "sum", replacement: "\\sum", options: "mA"} as an example.
For me, it's difficult to be consistent enough to refrain from typing \sum instead of just sum.
Most of the time I type just sum, but sometimes I carelessly type \sum, which results in double backslashes, i.e. \\sum.
Description of the Solution

It would be great if this plugin had the option to disable replacement when there is already a backslash so that the result will be \sum regardless of whether I typed the backslash or not.
Additional

I could partially resolve this problem by replacing the snippet with {trigger: "[^\\\\]sum", replacement: "\\sum", options: "rmA"} but it inserts \sum at an unexpected position:
https://github.com/artisticat1/obsidian-latex-suite/assets/72342591/07f4f094-2049-44cd-9c45-4da6b685dedc

As for the last point, {trigger: "([^\\\\])sum", replacement: "[[0]]\\sum", options: "rmA"} solved the issue.
But doing this for all snippets will be a hard work, given the variety of the snippets (such as tabstops).

Hi! Glad you're enjoying the plugin. This can be considered for a future release.
How should the plugin handle a snippet like {trigger: "sum", replacement: "\\sum_{${0:i}=${1:1}}^{${2:N}}", options: "mA"} when \sum is typed?

Thank you for the quick response!
That's a good example... I said a snippet should be disabled for \sum, but now I've realized it's not perfect.
So let me correct myself: if double backslashes \\ are detected at the starting position of the result after trigger is replaced by replacement, then they should be replaced with a single backslash \.
In other words, sum and \sum should give the same result.


Deploy develop branch to staging environment in ECS

Impact: major
Type: feature
Issue
The CircleCI pipeline has been modified to use the latest version of the propel CLI in order to push the develop branch to the staging environment.
Breaking changes

URL for staging: https://storefront.staging.reactioncommerce.com/

Testing

Perform starter kit functional testing against https://storefront.staging.reactioncommerce.com/

I'm not sure if this comment is the right place to put it but it's related to https://storefront.staging.reactioncommerce.com/
Currently, the app shows that we are using SOME_KEY as the Segment API Key:

Can we get a Segment test key and include it in the staging URL? It will help the team test internally, and also make it easier to demo Segment integration.


Dusting

things were not working with express 4 so I fixed that but didn't made tests with connect or anything so it might break backward compatibility

Hi @MathisTLD  would you like to merge your change and publish it to npm? If so, give me your npm username.

here it is : mathistld
thanks

hey @olalonde could you merge and publish this or simply allow me to do so ?
Thanks


Fix RTMP_ConnectStream return check

Correct a return check that was a part of changes for #68

Looks good to me!


Add method to crud that checks for duplicates based on incoming data

Give it a list of criteria for duplicates and return which were duplicates

Add option to enable/disable duplicate on_conflict_do_nothing


automate "mailbox oracle" password game

instead of having human tell user their password
generate waiting period of 10 minutes to 3 days
wait length of waiting period
generate sound file to tell user their password, we can do this with premade sounds, can we just concatenate files?
leave sound file as voice mail for user
tell user to check their voice mail after waiting period

I like this idea, but I'm pretty sure this was part of the virtual toorcamp ctf and won't be revisited.  Reopen if I'm out of line.

this could be used for a game rotation in the future, but I agree that this should be closed.

we want to implement the challenges for the public phones someday


Add notes to improve performance

For rails applications with hundreds of models, the startup time can be affected if the gem loads by default.  Moreover, the page is sluggish on browsers like Safari and Firefox and requires frequently refreshing the page. Chromium based browsers load the page much faster on observation.

@shifakhan
Thank you for your PR!
I have to decline this as we want to focus on improving core performance rather than suggesting browser-specific workarounds in the README.
Thanks for your understanding 🙏🏿


Fixes issues in the Publisher and Devportal

Purpose
This PR fixes the following issues.

https://github.com/wso2/api-manager/issues/2759
https://github.com/wso2/api-manager/issues/2727
https://github.com/wso2/api-manager/issues/2736

Resolves https://github.com/wso2/api-manager/issues/2759, https://github.com/wso2/api-manager/issues/2727, https://github.com/wso2/api-manager/issues/2736

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


This isn't a Issue more like Questions

Does the current version use LORA. Also does this work with the automatic 111 webui to generate the images, an lastly is there any option to add negative prompts.

Currently there is no support for LoRa but i do have plans to implement it in the future.
To add base negative prompts that apply to every user and server you can edit the negative_prompts field in your config.json file, if you want to do per prompt negatives there is a optional parameter you can use in the slash command


YARN-11078. Set env vars in a cross platform compatible way

Description of PR
Prior to running a node.js command, a TMPDIR environment variable is set - https://github.com/apache/hadoop/blob/11d144d2284be29da1f49e163db0763636dcf058/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/package.json#L11-L13
This is bash syntax and thus fails on Windows. This PR sets the TMPDIR environment variable in a cross-platform compatible way.
How was this patch tested?
Hadoop Jenkins CI validation.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
jsonlint
0m  0s

jsonlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m  1s

trunk passed

+1 :green_heart:
compile
4m 22s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
4m 17s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
mvnsite
1m 15s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
shadedclient
68m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 27s

the patch passed

+1 :green_heart:
compile
3m 30s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
3m 30s

the patch passed

+1 :green_heart:
compile
4m  3s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
4m  3s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 54s

the patch passed

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
shadedclient
24m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
4m  6s

hadoop-yarn-ui in the patch passed.

+1 :green_heart:
asflicense
1m 20s

The patch does not generate ASF License warnings.

108m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4432/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4432

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint jsonlint

uname
Linux 6e7c4d8200c5 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9feba53be9fc785784ab59138c93dfc118574dfe

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4432/1/testReport/

Max. process+thread count
698 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4432/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
jsonlint
0m  0s

jsonlint was not available.

+0 :ok:
jshint
0m  0s

jshint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 57s

trunk passed

+1 :green_heart:
compile
4m 20s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
4m 18s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
mvnsite
1m 15s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
shadedclient
68m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 26s

the patch passed

+1 :green_heart:
compile
3m 27s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
3m 27s

the patch passed

+1 :green_heart:
compile
4m  0s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
4m  0s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
0m 54s

the patch passed

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
shadedclient
22m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m 38s

hadoop-yarn-ui in the patch passed.

+1 :green_heart:
asflicense
1m 23s

The patch does not generate ASF License warnings.

105m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4432/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4432

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint jsonlint jshint

uname
Linux af6050b16930 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c5e018e6ee142c43a051377c570eebe5935a2142

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4432/2/testReport/

Max. process+thread count
548 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4432/2/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Compare VLAN names instead of expanding to range

Regression was introduced in https://github.com/apache/cloudstack/commit/41fdb88970d1a33d57ff08a3ecc239ec898956dc#diff-6e2b61984e8fa2823bb47da3caafa4eeR3174
The check introduced would fail and cause incorrect checks within untagged vlan.
For untagged VLANs and overlapping VLAN URIs we need to check for ipranges and gateways which happens naturally after this change.
Description

Fixes: #3114
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

Cloudmonkey-
(local) 🐵 > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 vlan=untagged gateway=<IP_ADDRESS> netmask=<IP_ADDRESS> startip=<IP_ADDRESS> endip=<IP_ADDRESS> forsystemvms=false forVirtualNetwork=true
{
  "vlan": {
    "account": "system",
    "domain": "ROOT",
    "domainid": "96fb4917-97e5-11e9-8e69-34e12d5f623e",
    "endip": "<IP_ADDRESS>",
    "forsystemvms": false,
    "forvirtualnetwork": true,
    "gateway": "<IP_ADDRESS>",
    "id": "8f249bce-8210-4e79-bc02-7c9723970137",
    "netmask": "<IP_ADDRESS>",
    "networkid": "5a0679dc-1f52-4e40-a7aa-1253848e4886",
    "physicalnetworkid": "ac5912b6-6461-4d4a-b137-f730f29ef241",
    "startip": "<IP_ADDRESS>",
    "vlan": "vlan://untagged",
    "zoneid": "c3476f05-69ea-4b4a-a38c-c7436188a727"
  }
}
(local) 🐵 > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 vlan=untagged gateway=<IP_ADDRESS> netmask=<IP_ADDRESS> startip=<IP_ADDRESS> endip=<IP_ADDRESS> forsystemvms=false forVirtualNetwork=true
{
  "vlan": {
    "account": "system",
    "domain": "ROOT",
    "domainid": "96fb4917-97e5-11e9-8e69-34e12d5f623e",
    "endip": "<IP_ADDRESS>",
    "forsystemvms": false,
    "forvirtualnetwork": true,
    "gateway": "<IP_ADDRESS>",
    "id": "34d0b59b-4494-44cd-932e-c33f8f979b16",
    "netmask": "<IP_ADDRESS>",
    "networkid": "5a0679dc-1f52-4e40-a7aa-1253848e4886",
    "physicalnetworkid": "ac5912b6-6461-4d4a-b137-f730f29ef241",
    "startip": "<IP_ADDRESS>",
    "vlan": "vlan://untagged",
    "zoneid": "c3476f05-69ea-4b4a-a38c-c7436188a727"
  }
}
(local) 🐵 > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 vlan=untagged gateway=<IP_ADDRESS> netmask=<IP_ADDRESS> startip=<IP_ADDRESS> endip=<IP_ADDRESS> forsystemvms=false forVirtualNetwork=true
Error 431: The IP range already has IPs that overlap with the new range. Please specify a different start IP/end IP.
(local) 🐵 > create vlaniprange zoneid=c3476f05-69ea-4b4a-a38c-c7436188a727 vlan=untagged gateway=<IP_ADDRESS> netmask=<IP_ADDRESS> startip=<IP_ADDRESS> endip=<IP_ADDRESS> forsystemvms=false forVirtualNetwork=true
{
  "vlan": {
    "account": "system",
    "domain": "ROOT",
    "domainid": "96fb4917-97e5-11e9-8e69-34e12d5f623e",
    "endip": "<IP_ADDRESS>",
    "forsystemvms": false,
    "forvirtualnetwork": true,
    "gateway": "<IP_ADDRESS>",
    "id": "92abf2b6-44b3-416c-abd5-f331d718d8dc",
    "netmask": "<IP_ADDRESS>",
    "networkid": "5a0679dc-1f52-4e40-a7aa-1253848e4886",
    "physicalnetworkid": "ac5912b6-6461-4d4a-b137-f730f29ef241",
    "startip": "<IP_ADDRESS>",
    "vlan": "vlan://untagged",
    "zoneid": "c3476f05-69ea-4b4a-a38c-c7436188a727"
  }
}

@blueorangutan package

ping for review - @rhtyd , @shwstppr , @andrijapanic , @PaulAngus

cc @PaulAngus - do you think for public network overlapping vlan-trunking/range be allowed to be added by the admin?

Copy @rhtyd

You assessment was correct @rhtyd . I have verified the changes on untagged and VLANs with specific IDs and it seems accurate. For readability to avoid double negation I have avoid reverted if else order and added some comments.

@blueorangutan package

@anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-49

@blueorangutan test centos7 vmware-65u2

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

Trillian test result (tid-43)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36493 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3430-t43-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 67 look OK, 4 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_reboot_router
Error
318.02
test_network.py

test_08_start_router
Error
67.86
test_routers.py

test_09_reboot_router
Error
1.12
test_routers.py

test_02_list_snapshots_with_removed_data_store
Error
1.20
test_snapshots.py

test_01_volume_usage
Error
9.44
test_usage.py

Looks like the changes break router/network related smoke tests. Can you check @anuragaw

Will check later today @rhtyd

I've tried replicating to run tests locally but they succeed. Looks like runtime issue.
@rhtyd , @shwstppr - can one of you perhaps run locally as well?
@blueorangutan test

@blueorangutan test

@blueorangutan test centos7 vmware-65u2

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

Trillian test result (tid-114)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34743 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3430-t114-vmware-65u2.zip
Smoke tests completed. 65 look OK, 6 have error(s)
Only failed tests results shown below:

The tests having errors also have errors on master - https://github.com/apache/cloudstack/pull/3476#issuecomment-510770328
@rhtyd , @shwstppr , @borisstoyanov , @PaulAngus - please help review and merge this when you have some bandwidth.

Looks like router lifecycle tests fail. We'll have to fix the bug and revisit this to ensure we don't end up adding a regression.

@rhtyd - is it possible that the router lifecycle tests are also broken on master as per this comment from blueorangutan - https://github.com/apache/cloudstack/pull/3476#issuecomment-510419304
Also these tests pass locally for me which is weird.

You're testing against KVM and not vmware, it could be a vmware related issue @anuragaw

Ah that makes sense. So can we fix that as separate PR and move ahead on this merge @rhtyd since these also break on master?

@borisstoyanov @PaulAngus can you test and review?

cc @shwstppr can you help with a review?

Ping

Ping @borisstoyanov @PaulAngus @shwstppr

@blueorangutan test centos7 vmware-65u2

@shwstppr - looks like the tests you kicked off did not start.
@PaulAngus - I have updated the PR Description. Hopefully it is more clear now.

@blueoragutan package

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian.  I'll keep you posted as I make progress.

@rhtyd , @PaulAngus , @borisstoyanov , @nvazquez , @shwstppr - if it looks good can we merge this before 4.13 branch cut ?

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-150

Trillian test result (tid-176)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35150 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3430-t176-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_05_rvpc_multi_tiers
Failure
416.02
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Error
445.47
test_vpc_redundant.py

@blueorangutan test

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-178)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37790 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3430-t178-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan test centos7 vmware-65u2

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

We can merge this after vmware smoketests pass.

Trillian test result (tid-185)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44166 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3430-t185-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Smoke tests completed. 74 look OK, 3 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_08_start_router
Error
74.34
test_routers.py

test_09_reboot_router
Error
1.14
test_routers.py

test_02_list_snapshots_with_removed_data_store
Error
1.22
test_snapshots.py

test_01_volume_usage
Error
9.47
test_usage.py


Update to aas-core-meta 1ae5aa0

We simply mark that the update to aas-core-meta 1ae5aa0 did not cause
any change in the test data.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.404%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1393

Relevant Lines:
1524

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 91.41%

Totals

Change from base Build<PHONE_NUMBER>:
0.006%

Covered Lines:
1394

Relevant Lines:
1525

💛  - Coveralls


Feat/rework cli

Allows Initiation of project by adding methods to the python client for the API  and a user friendly CLI

I just need to figure out what is wrong with one of the tests  before submitting fo review ?

I just need to figure out what is wrong with one of the tests before submitting fo review ?

The return of codecarbon config --init is "1" (see here) so maybe try to add the texte output of the command to find out.
Does it works when you run tox locally ?

I just need to figure out what is wrong with one of the tests before submitting fo review ?

The return of codecarbon config --init is "1" (see here) so maybe try to add the texte output of the command to find out.
Does it works when you run tox locally ?

It's all good I just had a test that was creating a .codecarbon.config dile that was messing with the other tests. It's good for review now

I changed the base branch back and forth because the PR had not caught the rebase somehow. It's all good now

Here is a video made with asciinema of how the CLI works :
https://asciinema.org/a/648518
There is probably a way to integrate this video in the docs .
There is a special player that you can embed and you can actually copy and paste from the video


docs: update documentaion

Thank you for contributing to kube!
Please add a summary of your change
n/a
Does your change fix a particular issue?
Fixes #(issue)
n/a
Check list:

[ ] Mark if documentation changes are required.
[ ] Mark if tests were added or updated to cover the changes.

Codecov Report

Merging #31 (0c6d5fc) into main (9197cc5) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   53.06%   53.06%
=======================================
  Files          14       14
  Lines         880      880
=======================================
  Hits          467      467
  Misses        331      331
  Partials       82       82

Flag
Coverage Δ

unittests
53.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

cp.go
61.02% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.


[Frontend] Raise an error on illegal reshape.

I am impressed we didn't have a check for this anywhere in the frontend.

Thank you for the review!


[DO NOT USE]

Closes

What changed?

Why was this change made?

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

Not needed anymore


Generate JWS Message Signatures

~As a platform user, I want to be able to test that my message signatures are well-formed. Note that since the ITP is intercepting and modifying messages, it may be necessary to regenerate the FSPIOP header for the SUT and simulators.~

~During session creation, the user should be able to select whether or not to check message signatures.~
~When signature checking is enabled, an additional test should be conducted verifying the presence and correctness of a JWS signature in the FSPIOP-Signature message header.~
Keys/certificates for generating the signature can be found in the session environment.
When signature checking is enabled, all outgoing messages should additionally be sent with a valid FSPIOP-Signature header. ~Where possible, this should be the original header from the sender, but if necessary~ the header can be reconstructed using keys in the session environment.

Message signature documentation: https://docs.mojaloop.io/mojaloop-specification/documents/Signature.html

@agalaguz @KolyaSirik if it's possible, the most convenient implementation of this would allow setting headers inside the test case. Just like with mTLS, we have added mtls:true to the test_step, we would also add an optional field jws as follows:
      path: /quotes
      pattern: ^quotes/$,
      method: POST
      mTLS: true
      jws:
        alg: RS256 # which algorithm to use for signing
        key: # ... some reference to the DFSP key to use for encryption
        protectedHeaders: # which of the message headers to include in the signature
          [FSPIOP-Destination, FSPIOP-URI, FSPIOP-HTTP-Method, Date, FSPIOP-Source]
        header: FSPIOP-Signature # Where to add the final signature
        transform: mojaloop # Transformations to apply to calculate the header

The parameters of jws are defined as follows:
alg:
Fairly self-explanatory, just pass this value on to whatever JWS library we use. Normally we'll use RS256, I think.
key:
I'm not sure how this will work with the new certificate management, but effectively this should be a reference to the certificate uploaded by a DFSP. For example, maybe it will be something like "{{ env.CERTIFICATE_PATH }}".
protectedHeaders:
These headers should be plucked from the request/response value and included in the signature. The JWS signature might be derived something like this (using the php-jws library as an example):
$headers = array(
    'alg' => $step["jws"]["alg"],
    'FSPIOP-Destination': $step->headers["FSPIOP-Destination"],
    'FSPIOP-Source': $step->headers["FSPIOP-Source"],
    'FSPIOP-HTTP-Method': $step->headers["FSPIOP-HTTP-Method"],
    'FSPIOP-URI': $step->headers["FSPIOP-URI"],
    'Date': $step->headers["Date"],
);

$payload = $step->body;

$key = /* ... */;

$jws = new \Gamegos\JWS\JWS();
$signature =  $jws->encode($headers, $payload, $key);

header:
This is the field where we will add the signature after it's calculated. For Mojaloop, the value will always be FSPIOP-Signature.
transform:
In a normal environment, we would simply add the signature directly to the specified header. Mojaloop is a bit weird though - the value of the signature is supposed to be Base64Url(JSON.stringify({ protectedHeaders, signature }). To support both patterns, I have added this transform parameter. If the value === "mojaloop", then the signature should be wrapped as I just described. In all other cases, the signature should be transmitted untransformed.
For a full example of the Mojaloop signing process, see here.

@agalaguz @KolyaSirik if it's possible, the most convenient implementation of this would allow setting headers inside the test case. Just like with mTLS, we have added mtls:true to the test_step, we would also add an optional field jws as follows:
      path: /quotes
      pattern: ^quotes/$,
      method: POST
      mTLS: true
      jws:
        alg: RS256 # which algorithm to use for signing
        key: # ... some reference to the DFSP key to use for encryption
        protectedHeaders: # which of the message headers to include in the signature
          [FSPIOP-Destination, FSPIOP-URI, FSPIOP-HTTP-Method, Date, FSPIOP-Source]
        header: FSPIOP-Signature # Where to add the final signature
        transform: mojaloop # Transformations to apply to calculate the header

The parameters of jws are defined as follows:
alg:
Fairly self-explanatory, just pass this value on to whatever JWS library we use. Normally we'll use RS256, I think.
key:
I'm not sure how this will work with the new certificate management, but effectively this should be a reference to the certificate uploaded by a DFSP. For example, maybe it will be something like "{{ env.CERTIFICATE_PATH }}".
protectedHeaders:
These headers should be plucked from the request/response value and included in the signature. The JWS signature might be derived something like this (using the php-jws library as an example):
$headers = array(
    'alg' => $step["jws"]["alg"],
    'FSPIOP-Destination': $step->headers["FSPIOP-Destination"],
    'FSPIOP-Source': $step->headers["FSPIOP-Source"],
    'FSPIOP-HTTP-Method': $step->headers["FSPIOP-HTTP-Method"],
    'FSPIOP-URI': $step->headers["FSPIOP-URI"],
    'Date': $step->headers["Date"],
);

$payload = $step->body;

$key = /* ... */;

$jws = new \Gamegos\JWS\JWS();
$signature =  $jws->encode($headers, $payload, $key);

header:
This is the field where we will add the signature after it's calculated. For Mojaloop, the value will always be FSPIOP-Signature.
transform:
In a normal environment, we would simply add the signature directly to the specified header. Mojaloop is a bit weird though - the value of the signature is supposed to be Base64Url(JSON.stringify({ protectedHeaders, signature }). To support both patterns, I have added this transform parameter. If the value === "mojaloop", then the signature should be wrapped as I just described. In all other cases, the signature should be transmitted untransformed.
For a full example of the Mojaloop signing process, see here.

Hey Christopher, @cjol
We've got a couple of questions:

JWS signatures are to be working with mTLS connection only (i.e. steps where we set mtls: true) or with HTTP steps to be covered as well?
"Certificated that we are to use to generate a signature is a Root CA crt or Client crt?

Could you please advise?

Hey Christopher, @cjol
We've got a couple of questions:

JWS signatures are to be working with mTLS connection only (i.e. steps where we set mtls: true) or with HTTP steps to be covered as well?
"Certificated that we are to use to generate a signature is a Root CA crt or Client crt?

Could you please advise?

JWS and mTLS are separate - so we might have jws: true, mtls: false. The certificate also will be a separate certificate.
In fact, I have just now realised that we will need to be able to generate JWS signatures for any of the simulators, which means that we might need a separate JWS certificate for each simulated component.
Would it be complicated to allow the JWS certificates to be uploaded as environment variables? In this way, the test case can refer to any number of certificates and we don't need to make platform changes.

JWS and mTLS are separate - so we might have jws: true, mtls: false. The certificate also will be a separate certificate.
In fact, I have just now realised that we will need to be able to generate JWS signatures for any of the simulators, which means that we might need a separate JWS certificate for each simulated component.
Would it be complicated to allow the JWS certificates to be uploaded as environment variables? In this way, the test case can refer to any number of certificates and we don't need to make platform changes.


Add minip volume rendering

As discussed in #86 , this PR adds minimum intensity projection rendering.
https://github.com/pygfx/pygfx/assets/1120672/b289208c-035d-4f5d-b551-743613fd1d82
^ example script: /examples/feature_demo/volume_minip_render.py

I believe the basic functionality is working and I would appreciate feedback on the following :

what do we want to call this rendering mode? As a starting point I chose minip, but I am open to other suggestions.
there is some code duplicated between the minip a mip raycast() functions. do we want to refactor so there is less duplication (e.g., the coloring and picking code)? I think the functions are short enough that it is fine as is, but I am fine with refactoring if you prefer.

Thanks!

Thanks! 🙏


express example?

var app = express()
app.listen(80)

This is how express apps work.
Any idea where the createServer() comes in to the picture?
Would love to get this working for express..

Just use it like you would with http.createServer()/https.createServer(). For example:
httpolyglot.createServer({ ... }, app).listen(...);

thanks !

Thanks


[release-v1.3] Commit offsets on partition revoked (#2221)

Cherry-pick of https://github.com/knative-sandbox/eventing-kafka-broker/pull/2221

/retest

/retest

/retest


-actionScripts flag does not in fact run the pre-/post-actions

I am trying to run test with the following command:
`xctool -workspace <my_workspace>.xcworkspace -configuration Debug -sdk iphonesimulator -actionScripts -scheme <my_scheme> CODE_SIGN_IDENTITY="iPhone Distribution" BUILD_DIR=/path/to/output -destination 'platform=iOS Simulator,name=iPhone 6,OS=8.4' test
and the pre-/post-action scripts for test of that scheme are never run.

Are you using xctool master?
cc @jimix.

Yes, using master.

@erikackermann, do you have a test project I and @jimix can use to reproduce? It is hard to say what's the issue because we have test coverage for these use case that doesn't fail.

@ExtremeMan I'm sorry, I don't have a repo that I can share that demonstrates this issue.  I am using the version of xctool that Travis-CI currently uses (which I believe is xctool-HEAD, reported as 0.25.0)

...and now it appears to be working.  I'm going to close this issue.  Thanks!

Thanks for reporting back! I think Travis-CI by default uses latest release and not master.

@ExtremeMan sorry I missed this, glad it resolved itself :smiley:


camel-quarkus-management: Added tests for managed beans

Fixes #4661

Added MBeans tests for the built-in types (components, endpoints, services etc)
Added MBeans test for custom bean
Updated docs.

[x] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[x] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[x] Phrases like Fix # or Fixes # will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[x] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[x] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html

Please can someone merge this as I don't have permission. Thanks.

Please can someone merge this as I don't have permission. Thanks.

I left one final nitpick comment. We should be good to merge after fixing that up.


branch-2.0 test_partial_update_native_insert_stmt_complex is flaky (#28927)

Proposed changes
Issue Number: close #xxx
cherry-pick #28927
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


CMake must be installed to build OSQP

It seems this package needs CMake during a pip install.
RuntimeError: CMake must be installed to build OSQP
If I do pip install cmake  it works after.
Can't cmake be added to the setup_requires field in setup.py?
This would make the installation process smoother for many libraries that depend on this one.
I'll make a PR if this can be done?

It is a good idea.   Please make a PR.

From: Krishnan R<EMAIL_ADDRESS>Sent: Thursday, May 31, 2018 10:47:21 AM
To: oxfordcontrol/osqp-python
Cc: Subscribed
Subject: [oxfordcontrol/osqp-python] CMake must be installed to build OSQP (#4)
It seems this package needs CMake during a pip install.
RuntimeError: CMake must be installed to build OSQP
If I do pip install cmake it works after.
Can't cmake be added to the setup_requires field in setup.py?
This would make the installation process smoother from many libraries that depend on this one.
I'll make a PR if this can be done?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/oxfordcontrol/osqp-python/issues/4, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGhaqTnntQ8VG4VrShmLh5IMn_IBWGcPks5t37wpgaJpZM4UUvo2.

Thanks! Added it in 4078327

I'm sorry this doesn't work as expected. The setup_requires option does not install the package in a full fledged way, it only downloads it temporarily into a local folder, making packages importable. It works for cases like numpy, where it can be imported from within a custom command in setup.py. But cmake is called in setup.py as a subprocess (also before the setup function), which requires it to be in the sys path. Perhaps cmake needs to be called as a python module.
I tried installing the master branch, but doesn't work.

The best option is to install cmake separately independently from the language. That's what we suggest in the instructions.
The fact that OSQP is not directly installed using a binary is probably because you are using pip and linux (see #3). Note that cmake is also needed for code generation.

Yes you are right. I guess then CMake is best installed separately.

I have reverted the commit in 8336546. I will close the issue since it looks like it will not appear again when we release the manylinux binaries.

Hi. I was installing scikit-survival, which has OSQP as one of its requirements (?), and it kept throwing some errors. I stumbled across this thread and did python3 -m pip install --user cmake and afterwards python3 -m pip install --user scikit-survival finally worked.
I'm on a 2016 MacBook Pro macOS 11.0.1 with python 3.8. I don't know if this will inform your development any.


Is there a way to obtain chat room messages in positive order through tdlib, or through the message index ID?

Is there a way to obtain chat room messages in positive order through tdlib, or through the message index ID?
For example t.me/PublicTestGroup/1
or
t.me/PublicTestGroup/10000
How to get the message content based on this index ID?

You must not try to get all messages in a chat by their identifiers. You can use getChatHistory with negative offset to receive messages newer than the given.


svelte demo broke

Describe the bug
On page load, node says this a lot:
(node:14) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
1:55:24 AM [vite] Error when evaluating SSR module /src/lib/FFmpegDemo.svelte: failed to import "@ffmpeg/util"
|- /app/node_modules/@ffmpeg/util/dist/esm/index.js:1
import { ERROR_RESPONSE_BODY_READER, ERROR_INCOMPLETED_DOWNLOAD, } from "./errors.js";
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:77:18)
    at wrapSafe (node:internal/modules/cjs/loader:1288:20)
    at Module._compile (node:internal/modules/cjs/loader:1340:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at cjsLoader (node:internal/modules/esm/translators:345:17)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:294:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:218:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:329:24)

I do have type:module as it says.
Has this ever come up before?

Desktop (please complete the following information):

OS: debian 12 (stable)
Browser chromium
Version 122.0.6261.111

Additional context
I'm trying to build a thing with this that had this problem too. I feel like something in this commit fixed it? https://github.com/stylehouse/bitzliten/commit/a02faa80f77742fa1141b3da4a4d9bd357ce70c2
Sorry for not knowing more esm|umd|teenage-javascript-
While you're at it maybe you could look at that too... The next problem I have now is why the worker seems to say
"Error: failed to import ffmpeg-core.js" during await ffmpeg.load(...), but I have no idea how to debug that. Is there another devtools per worker?
Also this page has a broken link to the svelte demo: https://ffmpegwasm.netlify.app/docs/getting-started/examples
Also I would expect to be able to easily compile an ffmpeg.wasm myself and omit features I don't need. I see this down the end of https://ffmpegwasm.netlify.app/docs/faq but it looks pretty nuts.

Same here.
A solution is to comment out this line import { fetchFile, toBlobURL } from '@ffmpeg/util'; and write the functions by your own.
However, when you solve this one, there will be another error when you try to use ffmpeg.load().

Uncaught ReferenceError: document is not defined

Struggling for a moment, I found you had to downgrade the Vite version to 4 from 5. Look for some advanced solutions though.
I'm really frustrated, why does an example not work out of box...

facing the same issue

I can't get it to work either... i have tried many versions but sadly, nothing seems to work :-1:

Ah yes, if I use esm mode I can see that error:

I think vite has given @vite/client to the worker (to do HMR, error diags?), it uses the document object which doesn't exist in the worker.
Maybe I can avoid it (as long as we don't use this error diag?) in sveltekit-app/node_modules/vite/dist/client/client.mjs:
 // Error Template
+let template = () => h(...);
-const template = h(...);
 ...
 class ErrorOverlay extends HTMLElement {
         ...
+        if (typeof template == 'function') template = template()
         this.root.appendChild(template);
         codeframeRE.lastIndex = 0;
         const hasFrame = err.frame && codeframeRE.test(err.frame);

This is available in my fork of the demo: https://github.com/stylehouse/ffmpeg.wasm/commit/72bb1fba8759d32a62ef289bdf7c3fb44db2d727
Diff that against what you have to ensure I'm not hacking you.
Which gets you here:

We're in the worker receiving a FFMessageType.LOAD message.
Incidentally, to the right you can see I've got a non-breakpoint in Svelte's lifecycle.js from it throwing a Error: Function called outside component initialization on page load. I've fixed these before but I'm not sure why it happens to this demo.
So here's another permanent exception to ignore:

And then we get many exceptions from this call stack:
ffmpeg = await self.createFFmpegCore({
FS.staticInit();
FS.createDefaultDirectories();
FS.mkdir("/tmp");
return FS.mknod(path, mode, 0)
var errCode = FS.mayCreate(parent, name);        // this is in a try { ... }
var node = FS.lookupNode(dir, name);
return FS.lookup(parent, name)
return parent.node_ops.lookup(parent, name)
throw FS.genericErrors[44]

Error 44 is widely used, here it seems we may not mkdir /tmp, nor /home, /dev/urandom|shm, /proc, but it may not matter?
We seem to do this (fail to create 14 different /things) many times, I'm not sure how many... Perhaps 'a few dozen'
We get this is the console now:

There are two vite clients waking up first.
Incidentally, we're paused on an exception that occurs when the Worker's vite client tries to use document to reload code changes from me...
The 'FS error' at the end comes from this approximate call stack, starting in our transcode() code:
const data = await ffmpeg.readFile('test.mp4');
...
this.#worker && this.#worker.postMessage({ id, type, data }, trans);
data = readFile(_data);                  // now in the worker
const readFile = ({ path, encoding }) =>
ffmpeg.FS.readFile(path, { encoding });

So it seems you can follow messages into the worker with the debugger!
There is no test.mp4 output file in the ffmpeg.FS.readdir('/') listing.
Also can read the input file. Does this look right? Just a few dozen numbers?

Speaking of a few dozen, we seem to spawn a lot of workers:

Not sure how to get more info leading up to that Aborted().
With another input video I got this:

Also, in another attempt I've got a "ReferenceError: SharedArrayBuffer is not defined", even when I've gone into chrome://flags and enabled "Experimental JavaScript shared memory features"
I'll try downgrading vite next, in a while... It's all a bit mucking futch.
Can anyone else find their way as above? Thanks.

Hello everyone! I was the one happily contributing with the Svelte demo, but now very sorry for the frustration it may have caused...
@stylehouse (or anyone) could you please try the following steps:

clone repo & cd path/to/dir
npm install
cd apps/sveltekit-app
npm run dev

I have just removed my node_modules and followed from step 2 and it worked here:
Details

[!NOTE]
It's important to run npm install from repo's root. My assumption is that package-lock.json is used and correct set of dependencies is installed ?? or maybe something with tsconfig.json ??

fyi, I'm using: M1; installed node with nvm; node v18.19.1; npm 10.2.4;

Aha.
I tried node 18.19 on a fresh debian:latest container and code checkout and it all goes the same.
My Error: Invalid data was invalid data: I needed fetchFile() for the input video, not toBlobURL() like the wasm bits. No idea what is going on, but the latter produces only a Uint8Array(63) as pictured above, so I DIY to avoid including @ffmpeg/util.
https://github.com/stylehouse/ffmpeg.wasm/commit/7493e13e423d927e07dbeb8f8ccd171fb56983c1
My project can include fetchFile() from @ffmpeg/util no problem.
It is<EMAIL_ADDRESS>and<EMAIL_ADDRESS>The demo is<EMAIL_ADDRESS>and<EMAIL_ADDRESS>I can then get it to convert to mp4! From avi.
However I can't seem to get it to output an .opus, here's the Vue demo after I applied the vite client document avoidance hack https://github.com/stylehouse/ffmpeg.wasm/commit/72bb1fba8759d32a62ef289bdf7c3fb44db2d727

In Svelte demo, reading .mkv (h264+flac) writing mp4 (with "-c:v","copy" to not transcode the video track), a Could not allocate memory

So I can no longer do mp4s even? Actually this seems to just be chromium, brave can do mp4s!
But then I try to output an opus and it hangs after the first progress meter log. If I try to pause the worker it always stops on this line of wasm (after discompiling it?):

And is not burning cpu when not paused, so I suppose the job has crashed out and it's polling|waiting for more instructions. Without having a job space out like this, trying to pause the worker in devtools / Sources doesn't manage to pause anywhere.
Anyway...
Here it is working:

Not working:

Then I remember the oldest trick in the book: -strict -2 -c:a opus

So the experimental opus codec works 100% better than libopus in this case!

So maybe these are needed:
not @ffmpeg/util - https://github.com/stylehouse/bitzliten/commit/5ac73442ecd15687f926636f9eeab8618d896ff1
fix vite client - https://github.com/stylehouse/bitzliten/commit/292688043a1d97c08bf54d6339f482bf5f5f46cb
Not sure how to do the vite client one as it involves hacking node_modules/...
If I recreate node_modules (losing the vite client hack) it complains about document and doesn't go.
Do they work for anyone else?
So perhaps it could detect and warn about a variety of things,
eg https://github.com/stylehouse/ffmpeg.wasm/commit/6c0c45ec12b5851cdbfe062962ab1c6a576e7094
and "memory out of range" -> restart your browser
and about libopus (the default for output.opus) being a problem (spacing out after a single progress message like size=       0kB time=00:00:00.00 bitrate=N/A speed=N/A    )
which implies another layer of software common to all the demos...
A small UI library to do:

wasm init asap or when jobbed
job config schema (what is adjustable) and scrapheap (culture)
returning that typed blob (knowing job)
But not do:
drag and drop (is different per framework)

Anyway,
In my project I forgot to await the call to ffmpeg.readFile, but now I can suddenly produce .mkv or .opus and it plays and everything!
Great stuff!

if you get the document error in overlay.ts
downgrade to Vite 5.1.6. yes, i just spent a lovely evening!
the related Vite issue seems to be https://github.com/vitejs/vite/issues/16277

cheers, they fixed it in 5.1.8 https://github.com/stylehouse/bitzliten/commit/85dbf74858a66771e2212df80fa44410db6733ff


Revise the read actions for the memory mapped register devices so that they do not have read actions for fetch and page table walk requests

0f5a06c2


Subject data not always loaded from tmp files on exp workflow restart

Possible race condition when loading subject data after a crash - sometimes restarting the workflow successfully loads data from other tmp files, but not the saved active subjects

@jkbhagatio just to confirm, is this restricted to the active subjects list? Or have you ever noticed this with other parameters as well?

Also, is this related to https://github.com/SainsburyWellcomeCentre/aeon_experiments/issues/570?

Oh oops, yes this is essntially duplicate of #570, will close this and reply there


Google Calendar API V3 sample for Service Account

Google Calendar API V3

I need an example c# code to access the Google Calendar
using Service Account differential.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 29 May 2014 at 2:20

Closing out as stale.