Release new version, plz

The vertx-eventbus.js is a little newer. When are you planning to release a newer version?
Also, the sockjs-client is available in a newer version as well.

Hi @joh-klein we should have a release next week (it's an estimation, not a date written somewhere).

Since you have the "old" (vertx 2.~) version in the other repo as well, what are the chances of pushing both to npm? I am trying to get rid of bower.

The vert.x 3 version is on NPM already.

I know,  but I am wondering about the vert.x 2 eventbus js file.

@pmlopes WDYT ?

It would be great to get it from the official source. I know it is deprecated, but I will have to support some vert.x 2 backends for at least the next year.

Maybe you're not aware but the old version is already available on cdnjs is that an option? https://cdnjs.cloudflare.com/ajax/libs/vertx/2.0.0/vertxbus.min.js

But I can only use tarball URLs inside a package.json …

@joh-klein by using the CDN you don't need to use tar balls. Also if you're using tools such as gulp you can use a plugin like: https://www.npmjs.com/package/gulp-cdnizer that at release time will fetches the resource from the CDN to your local distribution directory.

@pmlopes I am not sure how to respond to this. Using npm is not the same as linking to a CDN. I put fixed versions of my modules in my package.json. I need the guarantee, that nothing has changed. Also, I need the possibility of letting my apps run offline. There are countless reasons for using npm (and of course for using a CDN). Sure, I can always take your version and put it on my private npm registry, but I like using the official repo. I would appreciate it, if you would reconsider.

I understand the reasons behind disconnected apps vs online, that is why I put the gulp plugin here as an option to solve this gap. https://www.npmjs.com/package/gulp-cdnizer
We're currently working on version 3.x and this is our main focus so we would like to stay away from making new 2.x releases. Having this said, we know that the version on npm 3.1.0 is very close to the script used in the 2.x series, you could try that one first, since it includes the vertxbus.js and now the current one.
They are not 100% the same though, for example the login function is not there since that was a 2.x specific feature.


chore: prepand apple to SIWA imput prompts to align with other providers

Description of changes
Appended Apple brand to SIWA input prompt to align with other providers.

Issue #, if available
Related Issue: #11222

Description of how you validated changes

Warning
Working through Tests currently

Checklist

[X] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] ~Relevant documentation is changed or added (and PR referenced)~ NA
[ ] ~New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies~ NA
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

We are not going with this approach, instead we going with the approach here in #11286

We are not going with this approach, instead we going with the approach here in #11286

Okay - thanks for the update 🙂


Fix bug: add normal information to polygon_to_desired_rpy()

I fixed bug (my mistake) by the following PR.
https://github.com/HiroIshida/yamaopt/pull/36

Test failed.
I will retry the test after a few hours.
Cannot retrieve the public link of the file. You may need to change
	the permission to 'Anyone with the link', or have had many accesses.

You may still be able to access the file from the browser:

	 [drive.google.com/uc?id=1zy4C665o6efPko7eMk4XBdHbvgFfdC-6](https://drive.google.com/uc?id=1zy4C665o6efPko7eMk4XBdHbvgFfdC-6)

https://github.com/HiroIshida/yamaopt/runs/5228244743?check_suite_focus=true


Ensure irodsinfo returns valid client env file for iRODS 4.3

Need to test this to ensure it's correct. Maybe write some automated tests for it too (if I haven't already?)
The most obvious change is returning irods_authentication_scheme as pam_password instead of PAM, but I'll need to double-check there isn't other critical stuff.

Confirmed to be working in dev. I'll still test this in staging before confirming and closing the issue.

Works fine in staging, closing the issue.


fix: update faker.image.imageUrl to faker.image.url

Looks like the faker image docs indicate the correct call is url() instead of imageUrl()?

Hmm I was not aware of that, thanks for fixing this.

@all-contributers add @hkang1 for code

@all-contributors please add @hkang1 for code

thanks for the speedy response and merging!


Windows should fetch IP address if possible

As brought up in device info repo - https://github.com/react-native-device-info/react-native-device-info/issues/1387
That repo has code to do so (linked in the issue I linked above)

:tada: This issue has been resolved in version 8.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Includes SMAPI 3.0 updates and integration with BFAV's API to allow for extended farm animals to be purchased.

BFAV: https://www.nexusmods.com/stardewvalley/mods/3296

Closing for BFAV 2.x support.


If I want use cloubdreak  deploy the cluster on  Azure in  china ,what should I do

I want use cloubdreak  deploy the cluster on  Azure in  china ,what should I do

China region on Azure is not yet supported, and it is not planned in the near future.


Add testing for tf2autobot

The point of this feature is to add a useful set of tests which can be expanded upon as new features arrive. The test framework is Jest.
Current goals:

Enable asserting the result of SteamUser.chatMessage() calls
Centralize Option loading and default settings
Add mock steam-user implementation

Updates:

goals reflect centralized options; necessary for sane loading of defaults in tests and in prod.

WIPs:

onMessage test
centralize option loading
mock steam-user implementation.


CI/CD: renv.lock

Investigate whether renv.lock needs to be included in .Rbuildignore.

Closing this as this is nowhere near a priority!


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/example.justlists.ts
Checklist

[x] I understand that this is not the place to request a token listing.
[x] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[x] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL:
JustList Name:
Link to the official homepage of the JustList manager:

Ghh

Sorry, your issue will be closed as you did not submit your information in the correct format.


feat: DER-encode public keys

Wrap Ed25519 keys in DER encoding.  Calculate principals based on the DER-encoding (note that this changes principal ids).
Implements https://github.com/dfinity/sdk/issues/1126
Prerequisites:

ic-ref #200 to be merged. (my guess is this explains the test failure here in ic-ref / test (linux-stable))
sdk updated to at least replica https://github.com/dfinity-lab/dfinity/commit/0e1f85863cf54ab2d501ef1c3e276dd26265aef9

See sdk #1127 for proof of e2e tests passing
This is marked blocked because we have decided not to merge it until shortly before the Mercury release.  This way we do not have to handle both raw Ed25519 keys and DER-wrapped keys (which will have a different principal).

See also https://github.com/dfinity/sdk/pull/1127

The fix would work (see #66), but it will not be picked up by pull_request_target, i.e. only when it reached next. This probably needs repo admin intervention.

The error from ic-ref is public key has wrong length 44, expected 32. Is DER accepted as spec 0.11?

@hansl this PR will need https://github.com/dfinity-lab/ic-ref/pull/200 in order to work

You should be able to run the ic-ref CI against a branch, right?

@nomeata Sure, I'll try replacing this with a SHA from the branch
          ref: ${{ matrix.spec }}


Small bug in Car AirControl pitch lock

The check in https://github.com/ZealanL/RocketSim/blob/b223d2d4d6895f7fbc5f859c84edb5ee710e6d7b/src/Sim/Car/Car.cpp#L606
should be updated to
if (_internalState.isFlipping && _internalState.flipTime < FLIP_PITCHLOCK_TIME)

Otherwise the pitchlock remains active for FLIP_PITCHLOCK_TIME even if isFlipping was set to false during SetState

Ah I see, this stems from when I added isFlipping.
Fixed in dev branch, thank you!


[@rancher/components] Missing export for DraggableZone

Setup

Rancher version: Latest
Browser type & version: Firefox

Describe the bug

DraggableZone isn't exported from @rancher/components, meaning that it can't be used when updating imports in rancher/dashboard#7425
Additional context

This needs to be addressed before completing rancher/dashboard#7425

This has already been shipped with Rancher Desktop and validated by @torchiaf. Closing.


use pub + export_name for EXCEPTIONS and INTERRUPTS

rather than link_section and no_mangle. This way we don't have to
necessarily use the EXCEPTIONS and INTERRUPTS symbol names.
This also let us change the symbol name behind the exception::EXCEPTIONS
and interrupt::INTERRUPTS static variables without breaking the API and
needing a major version bump.

@homunkulus r+

:pushpin: Commit cb376c8 has been approved by japaric

:hourglass: Testing commit cb376c8 with merge cb376c8...

:sunny: Test successful - status-travis
Approved by: japaric
Pushing cb376c85a49f84fb089a210604845b265c3e27ef to master...


rstore filtering

@bkg I think I tested this while we were meeting, but not now filtering in the rstore API doesn't seem to be working. Should this query filter to only rasters with the slug pr_yr_ens-avg_amon_rcp45?
https://ecoengine.berkeley.edu/api/rstore/?slug=pr_yr_ens-avg_amon_rcp45

Yeah, I don't see a slug filter for rstores. I think this can be achieved by accessing the rstores for a particular series, like https://ecoengine.berkeley.edu/api/series/pr_yr_ens-avg_amon_rcp45/rasters/.

That works!


Hi!, need help for implement ima plugin for clappr player

Hello!, I need help for implement this plugin with clappr video player.I tried many times.but not succeed.
player link: https://github.com/clappr/clappr
Test link:  http://xaphanentertainment.com/clappr-ads-final/
at this moment - ads are not loading with video player..can you help me for solved this issue...
is something i missed.
Best,
Anuj

Hi there,
This plugin is specifically for the video.js player, and it looks like you're not using that. For help with other players check out our support forum, where you can get help for the IMA SDK in general.
Thanks,
Shawn


update goscaleio to v1.9.0

Description
Update goscaleio to v1.9.0
GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

https://github.com/dell/csm/issues/491

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[x] I have maintained at least 90% code coverage
[ ] I have inspected the Grafana dashboards to verify the data is displayed properly
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have maintained backward compatibility

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[x] make check test

➜  karavi-metrics-powerflex git:(feature-preview-1.4) ✗ make check test
./scripts/check.sh ./cmd/... ./opentelemetry/... ./internal/...
=== Checking format...
=== Finished
=== Vetting...
=== Finished
=== Linting...
=== Finished
=== Running gosec...
=== Finished
go test -count=1 -cover -race -timeout 30s -short ./...
?       github.com/dell/karavi-metrics-powerflex/cmd/metrics-powerflex  [no test files]
ok      github.com/dell/karavi-metrics-powerflex/internal/entrypoint    2.896s coverage: 90.2% of statements
ok      github.com/dell/karavi-metrics-powerflex/internal/k8s   0.066s  coverage: 91.9% of statements
?       github.com/dell/karavi-metrics-powerflex/internal/k8s/mocks     [no test files]
ok      github.com/dell/karavi-metrics-powerflex/internal/service       0.730s coverage: 94.1% of statements
?       github.com/dell/karavi-metrics-powerflex/internal/service/mocks [no test files]
?       github.com/dell/karavi-metrics-powerflex/opentelemetry/exporters       [no test files]
?       github.com/dell/karavi-metrics-powerflex/opentelemetry/exporters/mocks [no test files]

Manual inspection of the GUI
I have verified that the dashboards show the data properly while generating I/O and storage resources

[ ] Yes
[x] No

e2e pass


Runtime error - Error: Cannot find module '@babel/runtime/helpers/builtin/classCallCheck'

Hi team,
Whenever I run the npm run development command, I get below error. I am new to Node.js as well as the MERN stack. Could you please guide me?
 (E:\Project\MERN_SKELETON\node_modules\react-event-listener\dist\react-event-listener.cjs.js:7:39)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object. (E:\Project\MERN_SKELETON\node_modules\material-ui\Input\Textarea.js:52:27)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
[nodemon] app crashed - waiting for file changes before starting...

This seems to be an issue with Material-UI. I am assuming you are using a newer version than the one used for this code (1.0.0-beta.43).
A possible simple fix to get the given code up and running for now: install this specific version of material-ui and then run the application.
npm install<EMAIL_ADDRESS>npm run development
Let me know if the issue still persists.

@shamahoque  - Thank you. I tried it. It didn't solve the issue. Since it was an issue related it to
I installed babel run time (@babel/runtime/helpers) with below command
npm install --save-dev babel-plugin-transform-runtime
npm run development
Doing this solved the problem.

I am closing this issue.


Syntax error on Ruby < 2.6

The code in question (match[1..]) uses Ruby 2.6's infinite range syntax.
I believe we intend to support Ruby 2.4, so this should be changed. We should also run our tests against all supported Ruby versions to ensure this cannot happen again.
SyntaxError: /app/vendor/bundle/ruby/2.4.0/gems/zoom_rb-1.1.1/lib/zoom/actions.rb:6: syntax error, unexpected ']'00:05
\w+/).map { |match| match[1..].to_sym }

If it turns out we do not intend to support Ruby < 2.6, let's at least specify a minimum ruby version so folks don't run into this unexpectedly.

can we have a solution for it @kyleboe because i am also trying to use the latest version of it with ruby 2.5 and getting the same error or please tell me the possible solution i could do it from my side. Thanks

Thanks for your fix for this @dil-bparihar! #447 has been merged and 1.1.7 is released!


Add sender HMAC to MessageV2

added shouldPush to ContentCodec type
added shouldPush method to TextCodec and CompositeCodec
added senderHmac to MessageV2
added encryption methods for calculating HMAC signature

Merging in @kele-leanes https://github.com/xmtp/xmtp-android/pull/184 to unblock RN looks to have broken a few places in the code. We can revert this PR if there is a better approach to how to support RN.


Karabiner-Elements 12.2.0 and sleep mode in MBP 15" 2018

After 12.2.0 update I got weird bug on my 15-inch MacBook Pro 2018 (MacOS Mojave 10.14.3)
When I wake up laptop after a sleep (with closed lid), keyboard is often not responsive until I log in with Touch ID (I cannot type a password). Also backlight is off and it is not working even after logging back into account. After full reboot everything is fine until next sleep.
It happens more often while laptop attached to the AC, and less often when works from battery. Don't know if it is correlated.

I am also affected by this issue. Because the backlight is important to me so I can code in the dark I sadly had to remove Karabiner-Elements

I am also currently on Karabiner v12.2 with the new Mojave updates on v10.14.3. The keyboard backlight doesnt work for me either. Device is a 2018 Macbook Pro 15 inch

Also see this issue: https://github.com/tekezo/Karabiner-Elements/issues/1676

Duplicate of https://github.com/tekezo/Karabiner-Elements/issues/1676

I have a similar issue. In my case, after upgrading to Karabiner-Elements v12.2.0, the trackpad was no longer found after sleep.  This happened consistently, and there seemed to be no fix for it other than reboot. I could't move the mouse pointer until I connected a bluetooth mouse. I downgraded to v12.1.56 and the problem seems to have gone away. I have an MBP Pro 13" running OS X 10.14.2 (Mojave).

It happened with 12.1.56. The MacBook no longer finds its internal trackpad OR its internal keyboard. Fortunately, I own a Bluetooth mouse, so I didn't need to switch it off.
Now I am down to 12.0.0. The keyboard is working after sleep, but the trackpad is only half-working (it lost its capacity to recognize three-finger swipe).

And it happenend with 11.6.0. Keyboard, trackpad, all gone. (I get an OS X error saying that it can't find any mouse or keyboard). I am fairly certain I was using 11.6.0 before the upgrade, so I am beginning to suspect that this problem is of a more general nature. But what? It is extremely annoying, as you can imagine.

I have quit Karabiner-Elements, and the problems have disappeared.  Then Karabiner-Elements must be the culprit, right?

Wrong. The problem persisted.  Eventually I realized that Virtualbox was hogging the USB controller upon wake-up. There isn't any problem with Karabiner. Cheers :-)

I have this problem, too. If I disable Karabiner-Elements from modifying events from the keyboard in my 2018 15" MacBook Pro and then restart, the backlight works as it should.  The last time I tested this it also entirely disabled the keyboard. So K-E is undeniably the culprit.

Do you guys had a related issue like the keyboard or mouse not working at all ?

Just in case -- I let me state again that my issue had nothing to do with Karabiner. Nothing at all.
It was some obscure issue with VirtualBox that occured after upgrading to a MacBook Pro 13" and OSX Mojave, which led to Virtualbox hogging an Apple USB controller (as if it were a pendrive USB controller). This results in keyboard and trackpad becoming totally unsresponsive.
It is not a Karabiner Elements issue, but a VirtualBox issue. Of course, I don't know if you guys are facing an issue of a different nature...

I have this problem too, unfortunately. Problem is present on 12.2.0, and I assume also on 12.3.0, as no fix for this is specified in changelog. Backlight doesn't work after sleep until full reboot is done. Had to downgrade to 12.1.0 to resolve this issue, but now unfortunately my capslock LED isn't working (known bug in 12.1.0)

12.3.0 fixed it for me. Has worked as it should without problems for several days.


pkg-static Authentication error on 13-CURRENT

pkg-static Authentication error on 13-CURRENT, why? This is not happening in 12-RELEASE.
+ cp /etc/resolv.conf /usr/local/furybsd/uzip/etc/resolv.conf
+ mount_nullfs /usr/local/furybsd/amd64/cache/packages /usr/local/furybsd/uzip/var/cache/pkg
+ mount -t devfs devfs /usr/local/furybsd/uzip/dev
+ IGNORE_OSVERSION=yes /usr/local/sbin/pkg-static -c /usr/local/furybsd/uzip add https://github.com/helloSystem/Menu/releases/download/helper/appmenu-gtk-module-<IP_ADDRESS>.txz
Certificate verification failed for /C=US/ST=Washington/L=Seattle/O=Amazon.com, Inc./CN=*.s3.amazonaws.com
34372427776:error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:/usr/local/poudriere/jails/head-amd64/usr/src/crypto/openssl/ssl/statem/statem_clnt.c:1915:
Certificate verification failed for /C=US/ST=Washington/L=Seattle/O=Amazon.com, Inc./CN=*.s3.amazonaws.com
34372427776:error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:/usr/local/poudriere/jails/head-amd64/usr/src/crypto/openssl/ssl/statem/statem_clnt.c:1915:
Certificate verification failed for /C=US/ST=Washington/L=Seattle/O=Amazon.com, Inc./CN=*.s3.amazonaws.com
34372427776:error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:/usr/local/poudriere/jails/head-amd64/usr/src/crypto/openssl/ssl/statem/statem_clnt.c:1915:
pkg-static: https://github.com/helloSystem/Menu/releases/download/helper/appmenu-gtk-module-<IP_ADDRESS>.txz: Authentication error

Similarly, on the booted system:
FreeBSD% sudo IGNORE_OSVERSION=yes /usr/local/sbin/pkg-static add https://github.com/helloSystem/Menu/releases/download/helper/appmenu-gtk-module-<IP_ADDRESS>.txz

Certificate verification failed for /C=US/ST=Washington/L=Seattle/O=Amazon.com, Inc./CN=*.s3.amazonaws.com
34372427776:error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:/usr/local/poudriere/jails/head-amd64/usr/src/crypto/openssl/ssl/statem/statem_clnt.c:1915:
Certificate verification failed for /C=US/ST=Washington/L=Seattle/O=Amazon.com, Inc./CN=*.s3.amazonaws.com
34372427776:error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:/usr/local/poudriere/jails/head-amd64/usr/src/crypto/openssl/ssl/statem/statem_clnt.c:1915:
Certificate verification failed for /C=US/ST=Washington/L=Seattle/O=Amazon.com, Inc./CN=*.s3.amazonaws.com
34372427776:error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:/usr/local/poudriere/jails/head-amd64/usr/src/crypto/openssl/ssl/statem/statem_clnt.c:1915:
pkg-static: https://github.com/helloSystem/Menu/releases/download/helper/appmenu-gtk-module-<IP_ADDRESS>.txz: Authentication error

On 12-RELEASE it works. Why?


Added first Necessary And Sufficient EraRule tests

Adds a new style of tests.
One writes a specification for a triple (Environment, State, Signal).
This specifucation specifies the minimal constraints to make the tests pass.
Tests can be run in 3 Modes 1) Apply, Invert, Remove
In Apply Mode, we test that the given tests are Sufficient to pass the STS rules.
in Invert Mode, we test that the given tests are Neccssary, as we invert them, and then Expect the test to Fail.
if the test doesn't fail, the test is Not necessary.
in Remove Mode, we remove the constraint. It may or may not pass, as one can get lucky. We use classify
to record which constraints can get lucky.

Checklist

[x] Commit sequence broadly makes sense and commits have useful messages
[x] New tests are added if needed and existing tests are updated
[ ] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[ ] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[x] Self-reviewed the diff

I haven't had time yet to look in deep detail. However, what I'm a little bit concerned about here is that assertWith takes only a Status. The problem with that as I see it is that it means we alter all calls to assertWith with the same status flag. I would suggest doing something like this:
data Status a = Status { alterations :: Map a Alteration }
data Alteration = Apply | Invert | Remove
assertWith :: Alteration -> Term fn Bool -> Pred fn
assertWith Apply = assert
assertWith Remove = const TruePred
assertWith Invert = assert . not_

assertWithTag :: (IsBaseUniverse fn, Ord a)=> a -> Status a -> Term fn Bool -> Pred fn
assertWithTag tag status = assertWith (Map.lookupWithDefault Apply tag $ alterations status)

This way it would be possible to control the behaviour of different assertions in a neat way given we write some convenient syntax for constructing Status. Then comes the question of what type to use for the tag, we could simply do Status String for most use cases, or one could introduce a little enum type for one's specs.

I completely agree with this. One thing missing is communicating, back to the test, what extra information is being used. That will be necessary to make good error messages if one of them fails.

Closing this as something that we no longer want to proceed.


Error running tests/test_gen_answers.py and tests/test_judge_answers.py with prometheus-8x7b-V2.0

vLLM emits the error:
ERROR 07-05 19:50:10 serving_chat.py:225] Error in applying chat template from request: Conversation roles must alternate user/assistant/user/assistant/... INFO:     ::1:39498 - "POST /v1/chat/completions HTTP/1.1" 400 Bad Request
I think that the major problem is that granite uses a system/user/assistant patter rather than /user/assistant only.

Yeah I looked at the tokenizer_config.json for granite-7b-lab and prometheus-8x7b-V1.0, and they're using different prompt formats. We need to handle this for gen_answers.

There's an environment variable switch that will merge the system message with the first user message:
https://github.com/instructlab/eval/blob/6c537c5e2f71f364366086d6eb10de5a74ede2da/src/instructlab/eval/mt_bench_common.py#L227
I'll try this. If this works, we should parameterize this in the evaluator object.

@alinaryan

Thanks for digging into this @JamesKunstle I'm going to add an option to have this passed from evaluate in the cli down to this level and remove the env var entirely.

@danmcp fantastic thank you. This is the fix btw, prometheus generated + judged successfully.


Bandwidth leak on background: true cards

I noticed with webrtc cards, that if i enable background: true, the peerConnections do not get disconnected (which is fine), but when i reopen the page which has the cameras, they get reestablished again (instead of using existing connections), causing incremental bandwidth consumption on my server. Once i disabled the background feature, everything went back to normal.
I'm running HomeAssistant 2023.3 with WebRTC-Camera 3.1.0, the issue was observed on Chrome 111.0.5563.147 (Official Build) (64-bit)
Reproduction:

add a camera card to a dashboard
set background: true
navigate to a different dashboard (without pageload)
go back
repeat steps 3-4 a few times
observe an increase in network traffic on the stream source server (or the number of peerConnections in chrome://webrtc-internals, if webrtc is used)

Same in my installation.

@AlexxIT i can reproduce this on MSE (webrtc no longer works for me because some config changed) by adding a few background: true panels on a dashboard, and navigating back and forth between that dashboard and some others. in case i only navigate between tabs on the same dashboard, i have not seen the rise of bandwidth usage.


Fails to go list on google-22

I got simple Go app.
Trying to run pack build simple-app --builder gcr.io/buildpacks/builder:google-22
Logs:
===> ANALYZING
[analyzer] Timer: Analyzer started at 2023-09-01T09:16:20Z
[analyzer] Image with name "simple-app" not found
[analyzer] Timer: Analyzer ran for 4.097118ms and ended at 2023-09-01T09:16:20Z
===> DETECTING
[detector] Timer: Detector started at 2023-09-01T09:16:21Z
[detector] 4 of 6 buildpacks participating
[detector] google.go.runtime        0.9.1
[detector] google.go.gomod          0.9.0
[detector] google.go.build          0.9.0
[detector] google.utils.label-image 0.0.2
[detector] Timer: Detector ran for 1.428297517s and ended at 2023-09-01T09:16:23Z
===> RESTORING
[restorer] Timer: Restorer started at 2023-09-01T09:16:23Z
[restorer] Timer: Restorer ran for 5.230135ms and ended at 2023-09-01T09:16:23Z
===> BUILDING
[builder] Timer: Builder started at 2023-09-01T09:16:24Z
[builder] === Go - Runtime<EMAIL_ADDRESS>===
[builder] Using latest stable Go version
[builder] 2023/09/01 09:16:24 [DEBUG] GET https://go.dev/dl/?mode=json
[builder] Installing Go v1.21.0.
[builder] 2023/09/01 09:16:25 [DEBUG] GET https://dl.google.com/go/go1.21.0.linux-amd64.tar.gz
[builder] Warning: BOM table is deprecated in this buildpack api version, though it remains supported for backwards compatibility. Buildpack authors should write BOM information to <layer>.sbom.<ext>, launch.sbom.<ext>, or build.sbom.<ext>.
[builder] Warning: BOM table is deprecated in this buildpack api version, though it remains supported for backwards compatibility. Buildpack authors should write BOM information to <layer>.sbom.<ext>, launch.sbom.<ext>, or build.sbom.<ext>.
[builder] Warning: BOM table is deprecated in this buildpack api version, though it remains supported for backwards compatibility. Buildpack authors should write BOM information to <layer>.sbom.<ext>, launch.sbom.<ext>, or build.sbom.<ext>.
[builder] === Go - Gomod<EMAIL_ADDRESS>===
[builder] --------------------------------------------------------------------------------
[builder] Running "go mod download (GOPATH=/layers/google.go.gomod/gopath GO111MODULE=on GOPROXY=https://proxy.golang.org|direct)"
[builder] Done "go mod download (GOPATH=/layers/google.go.gomod/gopath GO111..." (1.295595843s)
[builder] === Go - Build<EMAIL_ADDRESS>===
[builder] --------------------------------------------------------------------------------
[builder] Running "go list -f {{if eq .Name \"main\"}}{{.Dir}}{{end}} ./..."
[builder] error obtaining VCS status: exit status 128
[builder] 	Use -buildvcs=false to disable VCS stamping.
[builder] error obtaining VCS status: exit status 128
[builder] 	Use -buildvcs=false to disable VCS stamping.
[builder] Done "go list -f {{if eq .Name \"main\"}}{{.Dir}}{{end}} ./..." (1.067590301s)
[builder] --------------------------------------------------------------------------------
[builder] failed to build: unable to find a valid buildable: (error ID: b9af3a94):
[builder] error obtaining VCS status: exit status 128
[builder] 	Use -buildvcs=false to disable VCS stamping.
[builder] error obtaining VCS status: exit status 128
[builder] 	Use -buildvcs=false to disable VCS stamping.
[builder] --------------------------------------------------------------------------------
[builder] Sorry your project couldn't be built.
[builder] Our documentation explains ways to configure Buildpacks to better recognise your project:
[builder]  -> https://cloud.google.com/docs/buildpacks/overview
[builder] If you think you've found an issue, please report it:
[builder]  -> https://github.com/GoogleCloudPlatform/buildpacks/issues/new
[builder] --------------------------------------------------------------------------------
[builder] Timer: Builder ran for 17.459784934s and ended at 2023-09-01T09:16:42Z
[builder] ERROR: failed to build: exit status 1

If I run locally on my host machine go list -f {{if eq .Name \"main\"}}{{.Dir}}{{end}} ./... it fails on
template: main:1: unclosed action
If I quote -f arguments it works:
go list -f "{{if eq .Name \"main\"}}{{.Dir}}{{end}}" ./...
/path/simple-app

It works with v1 builder, but then fails on other step
Running "go build -o /layers/google.go.build/bin/main . (GOCACHE=/layers/google.go.build/gocache)"
# runtime/cgo
gcc: error: unrecognized command line option '-Qunused-arguments'; did you mean '-Wunused-parameter'?
Done "go build -o /layers/google.go.build/bin/main . (GOCACHE=/lay..." (2m11.596111749s)
--------------------------------------------------------------------------------
failed to build: (error ID: 721b15b4):
# runtime/cgo
gcc: error: unrecognized command line option '-Qunused-arguments'; did you mean '-Wunused-parameter'?

Not sure if it can be related that I'm using podman
Client:       Podman Engine
Version:      4.6.2
API Version:  4.6.2
Go Version:   go1.21.0
Git Commit:   5db42e86862ef42c59304c38aa583732fd80f178
Built:        Mon Aug 28 16:55:03 2023
OS/Arch:      darwin/arm64

Server:       Podman Engine
Version:      4.6.1
API Version:  4.6.1
Go Version:   go1.20.7
Built:        Fri Aug 11 00:06:52 2023
OS/Arch:      linux/arm64

pack --version
0.30.0+git-c38f7da.build-4952

After following these instructions https://buildpacks.io/docs/app-developer-guide/building-on-podman/, I'm getting an error immediately but a different one
ERROR: failed to build: failed to fetch builder image 'gcr.io/buildpacks/builder:google-22': error during connect: Post "http://dummy%2F/v1.38/images/create?fromImage=gcr.io%2Fbuildpacks%2Fbuilder&tag=google-22": http: invalid Host header

seems related to https://github.com/docker/cli/issues/4437 and go 1.20.6 release

I tried to run the same on an existing sample-go application to make sure things are okay. And no issues were found.
$ pack build simple-app --builder gcr.io/buildpacks/builder:google-22

...
[builder] === Go - Build<EMAIL_ADDRESS>===
[builder] --------------------------------------------------------------------------------
[builder] Running "go list -f {{if eq .Name \"main\"}}{{.Dir}}{{end}} ./..."
[builder] /workspace
[builder] Done "go list -f {{if eq .Name \"main\"}}{{.Dir}}{{end}} ./..." (146.927416ms)
[builder] --------------------------------------------------------------------------------
...
===> EXPORTING
...
[exporter] Timer: Saving simple-app... started at 2023-09-01T16:02:35Z
[exporter] *** Images (ec0af1026f26):
[exporter]       simple-app
...
Successfully built image simple-app

As mentioned in the above comment, could you please provide more details on the application and its directory structure? Thank you.

I couldn't reproduce it with cloned sample app. But it seems somehow related to Git and not Go project structure.
Minimum reproduce steps for me:
cd /tmp

mkdir pack

cd pack

go mod init pack
go: creating new go.mod: module pack

git init
Initialized empty Git repository in /private/tmp/pack/.git/

vim main.go
package main
func main() {
  println("pack")
}

pack build simple-app --builder gcr.io/buildpacks/builder:google-22

I have tried rm -rf .git and then it works (at least this step)

I'm getting an error os: /layers/google.go.runtime/go/pkg/tool/linux_amd64/compile: signal: segmentation fault (core dumped) but that the different issue, maybe related https://github.com/golang/go/issues/48439#issuecomment-1089421221?

Closing since its due to underlying tool


Update to 19.4 and fixed error in Debug mode

Configure Cmake in Debug mode

DLIB_ENALE_ASSERTS=ON

for fix error

error LNK2001: unresolved external symbol USER_ERROR__missing_dlib_all_source_cpp_file__OR__inconsistent_use_of_DEBUG_or_ENABLE_ASSERTS_preprocessor_directives

Sorry, I am weak in English.

@PakornV,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

Looks good! Please take a moment to sign the cla, then I can merge it right in.


Fixing sex field options

Related to https://github.com/neurobagel/project/issues/78 and https://github.com/neurobagel/encarta/issues/10


[FOR REVIEW ONLY] Binder simplification

The best place to start reviewing is the Binder interface itself. Several methods have been removed (and as a follow-up, we will likely reduce the unbind methods to 2 as well - one for producer and one for consumer). Most notably, there are no longer separate "pubSub" methods. Instead, we now use consumer group for every consumer bind (and there is a "default" group if null or an empty String is provided). Within a group, messages will be load-balanced if more than one consumer instance is bound for that group. On the producer side, it's essentially always pub/sub, and if there are multiple groups represented, each group will get each Message. This means that our notion of tap is now no different than any additional consumer group, and if a "tap" contains more than one module, load-balancing will occur across those module instances (this is the original fix that @garyrussell introduced for Rabbit pub/sub behavior that led to the idea of this convergence in the first place).
For Rabbit, this model maps directly to a producer-side TopicExchange with the consumer-side having a Queue bound per group (routing-keys are used when partitioning is enabled).
For Kafka, the consumer group model aligns directly with Kafka's own consumer model, and the producer always sends to a "topic".
For Redis, the model is not as closely aligned (and we may decide not to support Redis in the future, but at the very least will not be recommending it for production). The consumer groups are being tracked in Redis ZSET collections where the name of each ZSET is groups.<destination>, and the members are group names (with the "score" representing the count of bound consumer instances). The producer then consults this ZSET to find each explicit queue (Redis LIST) and sends to each. Obviously there are many opportunities for optimizing... could be a background thread to manage the set contents as a cache, or even a pub/sub topic in Redis for set update notifications, or simply parameters to configure how often the ZSET is checked (a refresh interval based on time and/or the number of messages having been sent since the last check). Before going down any of those paths, we need to decide if we are even going to continue with the Redis implementation. If we decide to keep it but clarify that it is for dev-time convenience only, then perhaps we do not need to pursue any optimizations. In any case, that's out of scope for this PR.
This resolves spring-cloud/spring-cloud-stream#263

Regarding Redis - not sure of the benefit in continuing to try to support it. The only reasonable argument is that it was supported before.
I would argue that setting up RabbitMQ locally is in the end as easy as using Redis (sans the ability of MONITORing, but I'm pretty sure we can solve this with a better tracing/debugging strategy).
I'd be much more keen to explore other lightweight (possibly in-memory) binders such as Chronicle Queue, Aeron, etc. instead.

@mbogoevici Agreed 100% - would be great to have one of those binders that would be even simpler in terms of setup

The question, then, is whether we should expend any significant time reviewing the Redis Binder?
My vote is to trust @markfisher :smile:

@markfisher @mbogoevici I wonder if this would help with the consul impl I started (and admittedly haven't tried super hard to finish). I already have an InboundChannelAdapter and an OutboundEndpoint.

@spencergibb I think that the simplifications definitely would help.

Notes: this requires a Spring Cloud Data Flow update, for populating the group info.

Added further binder simplifications from @markfisher and removed consumer group defaulting here: https://github.com/mbogoevici/spring-cloud-stream/tree/binder-simplification-with-unbind

Addressed branch comments here: https://github.com/mbogoevici/spring-cloud-stream/commit/813fdadec16352913b32e68631446305d1bf0e52

Rebased, squashed, closed via https://github.com/spring-cloud/spring-cloud-stream/commit/c3758b9dc0d0ccebbf162a7f75affb84a1b08ff0, additional enhancements in https://github.com/spring-cloud/spring-cloud-stream/commit/192aa79baa881e01f197ebf1a58651de4b4a0106 and https://github.com/spring-cloud/spring-cloud-stream/commit/e2485e3290b599582dbb11bddfc128a921ee6bef


[FEATURE] Extend the Apps.engine to make sure it support register an externalComponent

In this PR I created a new ExternalComponentsExtend accessor and then add this accessor to ConfigurationExtend's properties. To make this accessor works, I implemented the AppExternalComponentManager later.

This is really good @lolimay ! Awesome job!
One thing I'd add is that I think the AppExternalComponentManager could maintain the list of all registered components itself without relying on a bridge, since Rocket.Chat does not currently maintain such list. Then Rocket.Chat has to ask the AppManager instance for the externalComponents it has to show.

This is really good @lolimay ! Awesome job!
One thing I'd add is that I think the AppExternalComponentManager could maintain the list of all registered components itself without relying on a bridge, since Rocket.Chat does not currently maintain such list. Then Rocket.Chat has to ask the AppManager instance for the externalComponents it has to show.

@d-gubert Thanks for reviewing! I'll try to change it as you suggested.


Change initial value of publish_copies to False

When copying a live page, it is more likely that one would not like to publish on copy, therefore, this PR changes the initial value of publish_copies/"Publish copied page" to False. Opening PR for discussion and consideration.

I would agree that not wanting it to be immediately published seems likely to be the more common case, since there is no opportunity to change any of the existing content.

I would agree that not wanting it to be immediately published seems likely to be the more common case, since there is no opportunity to change any of the existing content.

Agreed. This change came from a request from our content management lead to not publish copied pages by default. He said that in the "vast majority of cases" they need to edit the copied page's content before publishing, and having to uncheck the "published copied page" box every time was an extraneous step.

I think this makes sense also, have put a question to the core team to get some additional feedback, we may need to consider the implications of this in terms of backwards compatibility (e.g. Wagtail users that expect this default).

@jslay-excella thanks for thinking of this and taking the time to put up a PR, and congrats on your first commit to Wagtail.
This PR has been merged in by a separate commit 85faf192112271e71bc7e2afee0060e3bc52cd0e (it contains release notes /changelog entries).
Please check your name as listed in the contributors and let me know if you want it changed to something else.
Really appreciate your time here, thanks again.


Error "Navigation failed because browser has disconnected!"

This error is happening. Puppeteer version 1.9 seems to be the reason.
Edit: I just wrote crappy code (forgot an await). Fix is on the way..

If you are here after searching for that error message. You likely forgot an await somewhere in your code.

I've been tinkering with an implementation to scrape ~1500 pages in one job, but still getting this error. await is used everywhere it needs to be. Have there been other reasons you've heard of that would cause this issue?

Seems to be a resource problem: #179


Pull in upstream changes

🗣 Description
Pull in upstream changes from cisagov/skeleton-tf-module.
💭 Motivation and Context
I want to create another pull request that fixes some Terraform warnings, so I thought I would start by pulling in the latest skeleton code.
🧪 Testing
I verified that all pre-commit hooks passed.
🚥 Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Once #9 is approved and merged I will change the branch protection settings to require GitHub Actions instead of TravisCI.  Then this PR will pass all tests.


Tabular Data Ingestion

Overview
First set of helper methods for data ingestion and sepcific to tabular data ingestion. This PR include the following helper functions:

convert_pdf_to_images() : the first step in the tabular ingestion pipeline which converts pdf pages to images, the reason for this conversion is to run OCR on the tables later on the pipeline.
tables_scanner(): scans for tables and returns the results and confidence score.
tables_marker(): uses the json output of the tables scanner to mark the tables for visualisation purposes.
tables_cropper(): crops the scanned tables and prepares the image to undergo the OCR process.
table_constructor(): constructs the table by drawing lines that determines the shape of the table before undergoing the extraction pipeline.
table_reader(): extracts table information by utilising OCR model.
json_to_markdown_convertor(): helper method that converts the json table to markdown.

Documentation:

Docs are available here.

@nmaswood Thank you! I really enjoyed going over your comments and found them really helpful!
I'm using vim and it seems that my formatter config (pyright) is not working well haha.


Index out of range on some layout configurations

Hi, this layout is really great!
I'm trying to use it in my project, right now I'm using random numbers to determine width and height factors and sometimes I have crashes here with Index out of range on the array:
localColumnHeightsPerSection[index + shortestNextIndex] = columnHeight + cellHeight + interItemSpacing

would it be that bad to wrap that line around an if statement checking if the index is still in bounds? I've forked and I'm about to try it out, If it seems to work I'll submit a PR.

I have already fixed this issue, yet to make a release. Will release sometime today or tomorrow.

ok, wonderful! Thanks!


Ability Check and Saving Throw D20 Minimum Settings

I'm not sure if the skill check min roll is needed. If it is then we need config for skill.minRoll. Ability scores should automatically apply their minRoll settings in the ModifierManager.

Furthermore, fast-forwarded rolls also need to support minRoll.


Security vulnerabilities in dependencies

Your badge system appears to be saying there is a vulnerability in the latest marked 0.3.3 (again after the 0.3.2 different notification which was updated on our end)... but the link currently points to a "Page not found"... what's up? TIA

Could you post the link for the page on david-dm.org where you're seeing that?

Looks like there's an advisory here that hasn't been published to the node security project website https://github.com/nodesecurity/nodesecurity-www/blob/master/advisories/marked_redos.md

Could you post the link for the page on david-dm.org where you're seeing that?

 and above I posted the link but there it is again. :)
I do think the badge could be a little more non-alarming on the wording like "security advisories" instead of saying our dependencies are "insecure" too... I'm contemplating doing the aggregate below the dispersed now just so it doesn't freak certain people out... but that's a different tangent.

Looks like there's an advisory here that hasn't been published to the node security project website https://github.com/nodesecurity/nodesecurity-www/blob/master/advisories/marked_redos.md

Great to know... will go do some reading. Thanks.

Patched for now until the advisory is made public on the website.

Thanks... I'll watch for it too.

@Martii the advisory has now been published https://nodesecurity.io/advisories/marked_redos


Traitor mode will continuously restart when there aren't enough players

Description

Currently traitor mode will continuously restart every 60 seconds if it's set as the default game mode.
Every time it restarts it loads another map.
Launch args:
--cvar game.defaultpreset="Traitor" --cvar game.fallbackenabled=false --cvar game.lobbyenabled="true"
Additional helpful launch args:
--cvar traitor.min_players=2 --cvar traitor.min_traitors=1 --cvar game.lobbyduration=30

Is this an issue? The gameticker specifically attempts to start a preset, and if fallback isn't enabled and the preset fails to start, it will restart the round again, delaying the start incrementally every time.

It doesn't need to initialize the map. It could just restart the timer.


How to add your own component inside perception pipeline in Apollo 5.0?

Hello, Apollo Team. I try to implement my own recognition algorithm that uses lidar data and after fuse it with obstacles segmented from velodyne output. I am publishing it's output with SensorFrameMessage into the /perception/inner/PrefusedObjects topic for fusing, but i can't see my messages in fusion component. What am i doing wrong? Is there any way to add messages from custom components inside perception pipeline?

make sure the component have received upstream message

@zhangchaoltt which message? and I need to check it in fusion component or in my own?

your own component.

@zhangchaoltt  Now my own component recieve point cloud and send SensorFrameMessage and i can view pointcloud messages in my component - or I need to receive specific messages?

Put your component and fusion component in the same process， then check again

I added .dag with my component into a perception.dag and now fusion component receives my messages. Thank you for the quick response! I am closing the issue now.


Error in Qwiklab while using this git repo

error: failed to discover supported resources: Get http://localhost:8080/apis/apps/v1beta1?timeout=32s: dial tcp <IP_ADDRESS>:8080: connect: connection refused

Lost 18 qwiklab credits because of this.

Not resolved yet

I have the same problem. Why does this happen?

same here.

Don't forget to create cluster first before creating an instance

You might just need to connect to the cluster if you set up the cluster via the web console and are trying to access it from your local machine... or viceversa:
gcloud container clusters get-credentials <cluster_name>

You might just need to connect to the cluster if you set up the cluster via the web console and are trying to access it from your local machine... or viceversa:
gcloud container clusters get-credentials <cluster_name>


Migrate to messaging layer

Create an issue to track the progress of migrating to messaging layer.
This contains 2 major parts:

Migrate device controller #4171
Migrate app-server & interactive data model #3602

[ExchangeManager] Pass SecureSession messages and events to old SecureSession delegates #4516 (temporary solution to maintain backward compatibility)
Enable ExchangeManager #5095 (Draft, blocked by #4516)

Both of them depends on the Channel API #4019. (Done)
The Channel implementation depends on #3728. (Done)

@woody-apple this is blocked on PR #4019. This PR is essential to solved the issue #3584, which is the major problem blocking message layer.

Closing this


feat: download artifacts from current workflow run, improve API usage

I've been playing around with this action, which currently seems to be the only sane option for using Turborepo caching on GH actions. Unfortunately because my workflow is split into separate phases, I ran into a few limitations which this PR is supposed to solve:
Artifacts from previous jobs of the same workflow are not found
This is a limitation of Github Actions - apparently list and delete only works when the workflow was completed. This resulted in caching not working at all in subsequent jobs. I worked around this by downloading all previously uploaded artifacts from the same workflow before starting the server. Then when handling a request, the cache files are checked before falling back to listing other artifacts.
Reduce API usage
In the middle of testing, I actually hit my Github Actions rate limit of 1000/h. I believe this can be avoided using the following tricks:

Check file system first, then the API
Cache list request for serving GET requests. The turbo server is usually short-lived, so it should be relatively unlikely that we miss an artifact this way. And if we do, it's not the end of the world
Re-upload "remote" artifacts as workflow artifacts. I'm not 100% sold on this, but in theory we should be able avoid the list request on subsequent job runs this way, since these are automatically downloaded in followup jobs.

Oh and I implemented a stub for the statistics endpoint that newer versions of turborepo are using. Otherwise you get a lot of unnecessary errors in the turborepo logs.

Hi @AlCalzone thank you for this PR,
Can you provide a small example of GH that uses something with your setup?
What do you mean by list & delete are not available?

Here's a PR that uses the updated workflow - not sure if you see logs:
https://github.com/zwave-js/node-zwave-js/pull/5050
Here's the corresponding workflow run: https://github.com/zwave-js/node-zwave-js/actions/runs/3036837290, the ones after this one are failing because I'm cleaning up other stuff.

What do you mean by list & delete are not available?

This comment explains it - essentially the artifacts generated by the current workflow never show up in the artifact list request this action is using.
https://github.com/actions/upload-artifact/issues/53#issuecomment-601114235
The @actions/artifact download method uses some different paths related to the current workflow, so it does find them.

I think that you are misusing turborepo for sharing assets between jobs.
As I understanding it, GH jobs are ment to parallel your tasks, meaning they must by definition not share anything, therefore, you may parallel them.
So how do you expect turbo to reuse artifacts of other jobs from the same workflow? Turborepo should reuse artifacts from previous workflows, this it's whole point.

Some of the jobs depend on my TS code being compiled. As the project grows, that takes more and more time, so to avoid compiling the same stuff 6 times, I factored it out to a separate job, so the compilation would only be done once. Before migrating to Turborepo over the weekend, I shared the build output with the following jobs by uploading and downloading a single artifact.
Now if I don't share the turbo cache between the build job and the following ones, a cache miss in the build job will automatically be a cache miss in the following jobs that depend on a built project too.
I guess one way to do it would be a mix of the two approaches: Go back to downloading workflow artifacts on demand, but manually share the cache dir with the following jobs in the same workflow.

You can use turborepo for caching between workflow on the TS artifacts, and in order to share the result of TS between jobs, you will need to upload & download like u did.
Hope this make sense for you.
Anyway, thank you for the PR, and sorry for not approving it, but I don't think that this is the responsibility of this action to share artifacts between jobs of the same workflow.

What about the part where the list request is cached and the local FS is checked for existence of the artifact first? Would you accept this?

Can you elaborate of both of the points?
Why a new workflow will contain a turborepo cache on the disk?

I've checked turbo-repo code, and looks like they added /v8/artifacts/events for analytics.
You can make a separate PR with this end point, thanks.
Funny that my workflows works without it... :|

Regarding the list request:
Let's say your workflow has 20 turborepo tasks. As it currently is, every GET request to the endpoint /v8/artifacts/:id will list the existing artifacts using the Github API. Unless another parallel workflow run finishes and adds another artifact, each of these 20 list requests will have the same result - i.e. there were 19 unnecessary API uses. And even if there are new artifacts between request 1 and 20, I think the chance of needing that exact artifact is relatively low.
By caching the result of the Github API request on the first GET, we can save some requests.
Regarding the local FS check:
It probably isn't terribly useful if there is only one job in a workflow, but it is useful if:

you repeat a task for some reason and need the same artifact as earlier for it
you have multiple jobs and persist the cache between jobs (so I'm going to need this).
In any case, a check if the file exists isn't expensive and can potentially prevent downloading unnecessarily.

As for the endpoint:
It doesn't cause failures, but if you run turbo with -vv, every request will log an error with a HTML page in it. I can't find a corresponding log, but it's a bit annoying when trying to debug stuff.

Make PR's for both of the points you've mentioned, (separately), I will review them, and we will see if it makes the code more complex or not.

Will do 👍


Have an explicitly cached docker image for running on CI

(Reopening of #674 due to #786.)

Codecov Report

Merging #788 into develop will decrease coverage by 0.7%.
The diff coverage is 86.3%.

@@            Coverage Diff            @@
##           develop    #788     +/-   ##
=========================================
- Coverage     82.9%   82.3%   -0.7%
=========================================
  Files           43      46      +3
  Lines         5055    4974     -81
=========================================
- Hits          4193    4093    -100
- Misses         862     881     +19

Impacted Files
Coverage Δ

stellargraph/data/edge_splitter.py
89.6% <ø> (ø)
:arrow_up:

stellargraph/utils/ensemble.py
85.5% <ø> (ø)
:arrow_up:

stellargraph/utils/loss.py
0% <0%> (ø)

stellargraph/data/converter.py
0% <0%> (ø)
:arrow_up:

stellargraph/data/unsupervised_sampler.py
91.8% <100%> (-0.2%)
:arrow_down:

stellargraph/mapper/sequences.py
92% <100%> (ø)
:arrow_up:

stellargraph/layer/misc.py
85.7% <100%> (+0.5%)
:arrow_up:

stellargraph/mapper/sampled_link_generators.py
92.4% <100%> (+0.1%)
:arrow_up:

stellargraph/core/schema.py
86.9% <100%> (-0.2%)
:arrow_down:

stellargraph/datasets/datasets.py
100% <100%> (ø)
:arrow_up:

... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5b425b...90581db. Read the comment docs.


Feature request(GitHub App): Specify label name to be reviewed in .env

Purpose
As per Github Actions version, it would be convenient if you can specify the label name to be reviewed in GitHub App version.
Suggestion
Here's my implementation suggestion.

add label name to .env
add label name such as TARGET_LABEL to .env.
https://github.com/anc95/ChatGPT-CodeReview/blob/main/.env.example

add a label check in bot.ts
If TARGET_LABEL is specified in .env, check if the label is attached.

      const target_label = process.env.TARGET_LABEL
      if (target_label && pull_request.labels.every(label => label.name !== target_label)) {
        return "no target label attached"
      }

https://github.com/anc95/ChatGPT-CodeReview/blob/8833ed9067356702bde83caaedee0627a5ca3de4/src/bot.ts#L61
I also tried to make a PR, but npm test doesn't work for my environment. (Windows / WSL2)

@HosakaKeigo sorry for the test is not workable yet. Could you help to create a pull request of beyond code, it looks fine to me.

@anc95
Thank you for your reply! I made a PR for this issue. Hope it helps.
https://github.com/anc95/ChatGPT-CodeReview/pull/77


feat: include esm

📑 Description
Added esm dependency.
✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[x] I have updated the documentation as required
[x] All the tests have passed

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Change command-line parser

This PR changes the command-line parser from yargs to command-line-args because it supports older versions of node (>=8.0.0).

Hi Pedro,
Why the need to support deprecated NodeJS versions?

Hi! The projects my team and I are working on use node 10 and apparently won't be updated anytime soon. We are currently using version 0.0.5 and plan to add new functionality to the library after this PR. So we needed it to be compatible with node 10 first for the new version to work.


feat: Remove MAX_DATA_LIMIT

We used to limit the maximum amount of data that can be transferred,
both the total size as well as single blob size.  There is no real
benefit to this, we pass through the reader and do not buffer all this
data at once.  And avoiding to fill up the user's disk space is not
our concern.

/cc @dignifiedquire


⚠ CenterDevice has degraded performance

In 376f160, CenterDevice (https://auth.centerdevice.de/login) experienced degraded performance:

HTTP code: 200
Response time: 2424 ms

Resolved: CenterDevice performance has improved in 02c511b.


fix: create owner field resolvers for all operations

Description of changes
Bug fix: when operations don't include read operation with the sub::username identity claim, the sub prefix does not get stripped out from the return value, so clients would see sub::username.

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

It's not clear to me how moving that declaration line addresses this bug. I don't see anywhere we're mutating the roles or acm in the intervening code, and the only code to take advantage of it was already behind a feature flag.


language_embedding of None language description

I have noted that some datasets are marked no language description in the spreadsheets. How to get language embedding for such datasets?
Some (e.g. cable routing dataset) directly used the same language like "cable routing".
How about others?

All datasets have some language instruction stored, so you can always extract that from the fields "language_instruction" and "language_embedding" (which is a continuous embedding vector from a pre-trained sentence embedder). For the datasets that are listed as "no langauge" on the spreadsheet, the language instruction is a constant dummy string like "cable routing" or "pick anything" or "do something".

The fields are called "natural_language_instruction" and "
natural_language_embedding" respectively in the "observation"
dictionary in each dataset that you can check it out. Specifically for the
cable routing, I believe the instruction is just "route cable".
On Thu, Nov 2, 2023 at 8:23 AM 'Karl Pertsch' via Open X-Embodiment
Collaboration @.***> wrote:

All datasets have some language instruction stored, so you can always
extract that from the fields "language_instruction" and
"language_embedding" (which is a continuous embedding vector from a
pre-trained sentence embedder). For the datasets that are listed as "no
langauge" on the spreadsheet, the language instruction is a constant dummy
string like "cable routing" or "pick anything" or "do something".
—
Reply to this email directly, view it on GitHub
https://github.com/google-deepmind/open_x_embodiment/issues/16#issuecomment-1790629556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDPTRVL3MOUYV7L6MU3BAFTYCOGDRAVCNFSM6AAAAAA62KHH76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGYZDSNJVGY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>
--
You received this message because you are subscribed to the Google Groups
"Open X-Embodiment Collaboration" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to @.***
To view this discussion on the web visit
https://groups.google.com/d/msgid/open-x-embodiment/google-deepmind/open_x_embodiment/issues/16/1790629556%40github.com
https://groups.google.com/d/msgid/open-x-embodiment/google-deepmind/open_x_embodiment/issues/16/1790629556%40github.com?utm_medium=email&utm_source=footer
.


gs1.1: feat: track ihave/iwant counts

Implements https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#spam-protection-measures IWANT and IHAVE limiting
Closely follows go-libp2p-pubsub impl

Codecov Report

Merging #104 into gsv1.1 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           gsv1.1     #104   +/-   ##
=======================================
  Coverage   91.66%   91.66%
=======================================
  Files           2        2
  Lines          24       24
=======================================
  Hits           22       22
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3f59a...8e04a11. Read the comment docs.

Yeah, would prefer to do as a followup. I'm planning on just copying the go-libp2p-pubsub tests entirely once we have all the functionality.

can you take a look at #102 too when you get a chance? small 2 line diff


Delete outdated CHANGELOG

Wondering if it's just an oversight that the latest Git tag is v0.18.1, while the CHANGELOG file still points to 0.17 as the latest version?
I am using that file to track changes and know where to look out for when upgrading the cluster. Any other way (besides a regular commit diff) to keep in the loop of all the changes between versions?

Answering myself: https://github.com/GoogleCloudPlatform/kubernetes/releases

Yes, we should just delete that file, rather than maintaining 2 locations.
@RichieEscarez


Further optimisation as per DRY principle

We already have "function_name" variable that was assigned with the result of "response_message["function_call"]["name"]". That's why using principle of DRY (Don't Repeat Yourself), it's more Pythonic to re-use "function_name" in row 137, especially because the same is variable is used later in row 144.

@mrbullwinkle
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

emailed author

Good catch @LazaUK! I ended up fixing this in a separate PR because there were some other changes made to the code sample that led to a merge conflict. I made sure to give you credit in the PR though. The updates should be live in the next day.

#please-close

Great, thank you for the update and clarification, @dereklegenzoff !


Task hatching in locust

Describe the bug

When we read the csv file in a task in locust, can we not predict the all rows of csv has been read from the csv.
For example, i have a csv of 10 rows and i want to pass in the locust for the performance and i am not seeing any way to see whether this all 10 rows has been hatched during the performance
Expected behavior

I want that the csv hatched once for all the rows.
Actual behavior

It hatched the csv randomly and some time it hatched the same row again and again.
Steps to reproduce

Environment

OS: Unix
Python version: 2.7
Locust version: 0.7.5
Locust command line that you ran:
Locust file contents (anonymized if necessary):

Hi! I'm afraid I dont really understand your question. Please share your locust plan. Also, you are on a very old version of locust, please update it.
You may want to have a look at https://github.com/SvenskaSpel/locust-plugins/blob/master/examples/csvreader.py


Gh-1156 - Parquet test unordering

Removed expectation of a specific order of the paths provided in the ParquetFileIteratorTest
Small checkstyle issue fixed to ensure project builds successfully.

Codecov Report

Merging #1158 into develop will increase coverage by 0.25%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##             develop    #1158      +/-   ##
=============================================
+ Coverage      65.25%   65.51%   +0.25%
  Complexity      1314     1314
=============================================
  Files            623      623
  Lines          19271    19271
  Branches        2390     2390
=============================================
+ Hits           12576    12626      +50
+ Misses          5713     5667      -46
+ Partials         982      978       -4

Impacted Files
Coverage Δ
Complexity Δ

...q/gaffer/store/schema/SchemaElementDefinition.java
70.06% <100%> (ø)
0 <0> (ø)
:arrow_down:

...gaffer/parquetstore/utils/ParquetFileIterator.java
89.47% <0%> (-10.53%)
0% <0%> (ø)

...ration/addelements/impl/AggregateAndSortGroup.java
93.61% <0%> (+2.12%)
0% <0%> (ø)
:arrow_down:

...tion/getelements/impl/ParquetElementRetriever.java
88.78% <0%> (+5.6%)
0% <0%> (ø)
:arrow_down:

...ration/addelements/handler/AddElementsHandler.java
81.96% <0%> (+6.55%)
0% <0%> (ø)
:arrow_down:

.../gaffer/parquetstore/utils/ParquetFilterUtils.java
68.24% <0%> (+6.75%)
0% <0%> (ø)
:arrow_down:

...ration/getelements/handler/GetElementsHandler.java
80.95% <0%> (+19.04%)
0% <0%> (ø)
:arrow_down:

...re/serialisation/impl/StringParquetSerialiser.java
61.53% <0%> (+23.07%)
0% <0%> (ø)
:arrow_down:

...e/serialisation/impl/IntegerParquetSerialiser.java
61.53% <0%> (+23.07%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce96588...dceca43. Read the comment docs.


necessary changes to allow users to use custom filesystem.

ISlangFileSystem is:
struct ISlangFileSystem : public ISlangCastable
    {
        virtual SLANG_NO_THROW SlangResult SLANG_MCALL loadFile(
            char const*     path,
            ISlangBlob** outBlob) = 0;
    };

To implement it, users need to create a Blob instance. However, we do not have interfaces like:
SLANG_API ISlangBlob* spCreateBlob(void* data, size_t size);

Exposing functions to create a blob can be useful. But it is still possible for the user to implement ISlangBlob themselves, the interface is also compatible with a ID3DBlob so they can use a d3d blob to serve as a ISlangBlob too.

Implementing ISlangBlob is actually what I try to do at the beginning, but I do not know how to implement ISlangUnknown. Finally I solved my problems via compiling slang by myself and adding this interface.

Great to know you find out a solution! We will welcome a pull request from you if you feel like sharing your changes.

Btw, ISlangUnknown is fully compatible with the COM IUnknown interface so the same convention used to implement a COM interface will apply here.

Thx, I am not familiar with Windows API and D3D API so I can not follow the context about COM. I will read more docs about COM.


[typescript] WithStyles makes theme required

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

type Props = WithStyles<typeof styles> or WithStyles<typeof styles, undefined> should not have theme as required.
Current Behavior

type Props = WithStyles<typeof styles> has theme as required;

Steps to Reproduce

Link: https://github.com/geirsagberg/material-bug
Context

The problem appeared after upgrading to 3.1.0. Cannot seem to reproduce in Codesandbox, only locally. Clone the mentioned repo to reproduce.
Your Environment

Tech
Version

Material-UI
v3.1.0

React
v16.5.1

Browser
-

TypeScript
3.0.3

etc.

@dotbear I'm very sorry that this caused so many issues for you. Aside from the issue with theme it should've been as simple as
- export const MyComponent = decorate<Props>(props => <Button />)
+ export const MyComponent = decorate((props: Props) => <Button />)

where Props extends WithStyles.
Type definitions and semver don't really mix very well. The definitions over at DefinitelyTyped don't follow semver at the moment and I  believe that this is ok. Mixing the definitions into the package can cause problems across minor versions. The overall problem is that the old withStyles did not support defaultProps and could've been considered a bug that required a breaking change. From my experience with type definitions this happens very often and would require a frequent bump in major versions which might leave non-ts users behind.
In retrospect we could've simply added a withStylesLibraryManaged that supported defaultProps. This would've allowed users to get typed defaultProps with the new method while we could still support legacy code bases with the inferior withStyles.
I would suggest using @ts-ignore if this is possible. The code will emit just fine. It's just much noise in the form of false positives.

@eps1lon try this one https://github.com/dotbear/material-ui-bug

After adding the following tsconfig and running tsc -p tsconfig.json --noEmit I got no errors.
I got the error however if I did not add es5 and es6 to the lib which caused ts to not compile the type definitions of mui.
Please provide a repro that includes the error on compilation. Otherwise this is either an issue with vscode or your tsconfig.

@eps1lon I have updated the repo now. I agree that this seems to be an issue with TypeScript. I will do some more testing to try to isolate the issue, seems related to what is in the tsconfig.

@eps1lon The issue occurs on compilation when "strict": false.

Repo updated, running tsc --noEmit fails.

@eps1lon good point.
I did some testing and I've isolated the problem. It occurs when you disable strict: true in your tsconfig. Which means this will only work with strict: true enabled.

More specifically strictNullChecks: false will cause errors. Setting this to true will get rid of the errors. Since DefinitelyTyped also requires strictNullChecks: true I think we can also require this.
The issue is described in https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-0.html

The type checker previously considered null and undefined assignable to anything

Which is the issue here.
Again I'm sorry for the inconvenience but this was always a potential error in codebases that did not set strictNullChecks and I understand that combining this with our judgement call can be very frustrating.

So the workaround is to set strictNullChecks: true, unfortunately that caused roughly 400 errors in our codebase, so I will have to downgrade to 3.0.3 for now, until we have time to strictify our codebase.
However, if I change the declaration to:
export type WithStyles<
  T extends string | StyleRules | StyleRulesCallback = string,
  IncludeTheme extends boolean = false
> = (IncludeTheme extends true ? { theme: Theme } : {}) & {
  classes: ClassNameMap<
    T extends string
      ? T
      : T extends StyleRulesCallback<infer K> ? K : T extends StyleRules<infer K> ? K : never
  >;
  innerRef?: React.Ref<any> | React.RefObject<any>;
};```

Everything seems to work as expected even with `strictNullChecks: false`. Haven't run the tests, but do you see any issues with this?

If that is not a valid solution, I think it would be good to note this as a breaking change, or at least add it to the TypeScript bit of the documentation. I understand that it is challenging to keep supporting all different kinds of configurations, I was just taken aback by this sudden problem, and I imagine there are others with the same problem.

Which leads us to a discussion what's a breaking change and a bug fix. With strictNullChecks: false and<EMAIL_ADDRESS>you could write:
const Child = withStyles(childStyles)<ChildProps>(({ classes, foo, theme }) => (

{foo}{theme.typography.display4}

));

which would pass at compile time but throw at runtime because theme is never injected and therefore undefined.
Setting strictNullChecks: false is not only potentially dangerous because it's intrinsic value but also because every type definition from DefinitelyTyped you have in your codebase is probably broken.

The problem here was that strictNullChecks: false worked perfectly fine in 3.0.3 and prior, and no longer worked in 3.1.0, without the release notes mentioning this at all.

It did not as my example pointed out. It only worked if you consider passing at compile time while throwing at runtime as "working". I will file a PR that includes your fix and a bit of documentation but saying that it was working with strictNullChecks disabled is wrong. DefinitelyTyped is not documenting this as well which is an issue but documenting a requirement is (in my opinion) not a breaking change.
It's very convenient that we can apply a fix that is compliant with both configurations but we never have supported strictNullChecks disabled and neither is DefinitelyTyped so I don't see a reason that we should.
I can already see the issues were people complain that accessing theme at compile time is fine while it throws at runtime and that we should fix this which we can't because some people were relying on a bug.

@eps1lon woah that's pretty interesting. I had to go check that myself and you're right, that does indeed compile. I was skeptical because I get correct errors for random props like bar, but it does indeed think theme is injected.

A fix was merged. It should be good in v3.1.1. Let us know :)

Can you mention the actual solution for this problem? At this date, I am getting the issue with everything to the latest version and these tsconfig options:
    "forceConsistentCasingInFileNames": true,
    "noImplicitReturns": true,
    "noImplicitThis": true,
    "noImplicitAny": true,
    "strictNullChecks": true,
    "suppressImplicitAnyIndexErrors": true,
    "noUnusedLocals": true,
    "experimentalDecorators": true,
    "esModuleInterop": true,
    "resolveJsonModule": true,
    "pretty": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "isolatedModules": true,
    "noEmit": true


simple example on how to download/pause/resume a chunked download

It would be great to see how to make a function that could be called like this
var ref = downloadFile({ url, file })

where, if the file has already started downloading it refreshes the url (to deal with time-limited links) and resumes downloading.
And it would also help to see how to pause the download using the API
pauseDownload(ref)

This would need to work for AWS Signed links (e.g. time limited) and chunked files that may not respond with filesize in the header.
Here is a URL to test with
http://s3.amazonaws.com/stukennedy.torchwood/close_credits.zip?AWSAccessKeyId=AKIAINMRPVWBZGXJIQUQ&Expires=1786921700&Signature=VyoYeKHrGMw26ZrP9EIIiuiNy70%3D

A whole year have passed since I last tried using this and couldn't... Still no simple example usage.. smh

I just found this and while I think that this might interesting I have no idea how to do anything with this module because there is no example whatsoever and it's quite complex to wrap my head around it.

Same here. There is a wrapper at https://github.com/leeroybrun/node-mt-files-downloader which simplifies things and has examples, but it also mentions that it needs refactoring to work with the latest mt-downloader versions.


Merge fast sync

This PR merges feat-fast-sync-v2 to dev.  The only code conflicts were in the global-state-update-gen tool.

bors merge


Start removing health

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #21

PR #22

PR #23   👈

This stack of pull requests is managed by Graphite.

Merge activity

Dec 20, 8:56 PM: @@kadhirvelm started a stack merge that includes this pull request via Graphite.


Supporting DaemonSet with AddOnTemplate

Supporting DaemonSet with AddOnTemplate
e.g. I want to use AddOnTemplate to deploy Kepler, but Kepler is based on deamonset

/assign @zhujian7

@skeeey I think this is finished, you can have a try with the latest ocm.

/close


Use 'big.js' for calculating values that are shown in sheets

Currently, the total weight and value values that are derived by multiplying an item's weight/value attributes by it's quantity can sometimes be calculated incorrectly:

(expected weight in this situation would be 1.5)
Implement math with big.js for calculating display values. eg; weight and value of items when multiplied by the quantity.
The code for these calculations are in the InventorySheetTable.tsx file:

As well as MemberCarryWeightTable.tsx:

When doing this, you should also refactor the weight * quantity and value * quantity calculations into external getItemTotalWeight and getItemTotalValue functions respectively, with both functions taking the item as their only parameter. These functions should be written in a file named deriveItemProperties.ts inside the utils folder.

Can you assign this issue to me, please?


Use Elasticsearch from new production infrastructure

Also rename the setting to be consistant with that of a general external service, as opposed to a piece of application-specific logic.

After merging this, a manual database sync will be needed.


Form hasValue check not good enough

Rignt now the check to see if the user has entered any text into a text field is
bool get hasServiceName => this.formValueMap.containsKey(ServiceNameValueKey);

This is not good enough as the value can still be empty and return true. This needs to be updated to something that also checks if the string is empty.

This issue can be closed, right?

Yes


Do not fail on touch() if OSError (to cache non existence of file)

Related to this thread on slack (private link).
When trying to download a file, if the file does not exist on the Hub, we cache this information by creating an empty file under the ./no-exists folder. This is used in transformers to avoid requesting a given file each time the pipeline is reloaded. The only purpose of this file is to save a HEAD call on initialization. @ydshieh and @glegendre01 have found out that Path.touch() raises a PermissionError when used on a S3-mounted drive if the file already exists. This PR adds a try/catch block to ignore such failures.
EDIT: I've checked and it's the only occurrence where we use .touch() on a potentially existing file.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

I think @ydshieh is currently testing it on a live S3 mounted drive in a CI to make sure we are solving their problem. Unit testing is not worth it IMO

Yes, let me check and give update here later.

Checked with CI and the previous failing test like

tests/models/auto/test_configuration_auto.py::AutoConfigTest::test_configuration_not_found

(on new cluster/cache system) now passes.

Thanks for confirming! I'll merge it then :)

Thanks for confirming! I'll merge it then :)


How to contact you personally?

How can I contact you? I want to provide you with a client that can crack any server. I want to ask you to fix the vulnerabilities of breakdowns.

SpigotMC: https://www.spigotmc.org/conversations/add Username is royalkingkb
Email<EMAIL_ADDRESS>

Sent by mail


Ceylon repo README lists some dated OSes

The Fedora releases are close to 3 years old (I use Fedora 23) and some of the others look similarly dated.

I'm using Fedora 22 myself, so @sadmac7000 if you can tell me your JDK version I add them to the list and I'll add my version too. Others will have to do the same for Ubuntu and MacOS

[sadmac@baudrillard ~]$ java -version
openjdk version "1.8.0_77"
OpenJDK Runtime Environment (build 1.8.0_77-b03)
OpenJDK 64-Bit Server VM (build 25.77-b03, mixed mode)

ok thanks @sadmac7000
@FroMage could you update the Ubuntu info?
@chochos you use MacOS right? Could you update the MacOS section?
https://github.com/ceylon/ceylon/blob/master/README.md

Work computer is Ubuntu 14.04 LTS
Looks like I might be on an off-the-grid JDK though.

Reminder for @FroMage and @chochos , could you guys update the information for your OSes, it's just a single line.

updated OSX

thx @chochos !

Done.

thx!


Modern look for rss-bridge

Updated the css to look more modern. Screenshot attached.

Ok, will fix that asap.

@LogMANOriginal Changed indentation from spaces to tabs in Sublime Text. Is it okay now?

Thanks for updating, I can see the differences now. In general I suggest splitting commits for new features and commits for indentation changes. It's still a bit mixed right now. Maybe there is a way to test this automatically in the future.

Looks like it broke view in mobile devices.

Main screen
Before:

After:

Bridge options
Before:

After:

Feed items in HTML format
Before:

After:

Also pay attention to excessive left and right margin.

Will fix asap.


How do i use it with Stable diffusion Horde?

How do i use this with stable diffusion horde? What do i set the API url to?

You have to install Stable Horde extension

So you have to install the model to use it? Doesn't this webUI come with the model as well?

@MahdeenSky don't know if Automatic1111 still requires you install at least one model.
but after you get the webui webpage running, you don't need to install any models to use the hordes.
you could also run auto1111 in cpu mode.

alright thanks


[WIP] Add error class prefix to error message

What changes were proposed in this pull request?
Adds the error class prefix to error messages and checks that error classes are encountered in tests.
Incidentally:

Cleans up existing error classes that overlap in functionality
Removes unused error classes
Adds tests for untested error classes

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Test build #144471 has started for PR 34342 at commit 6f764a9.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48944/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48944/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144471/

Test build #144478 has started for PR 34342 at commit aa8d3da.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144478/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48950/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48950/

Test build #144515 has started for PR 34342 at commit cb76b8f.

Test build #144515 has finished for PR 34342 at commit cb76b8f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.


Suggestion: Automated Testing

Hello @MiczFlor,
I follow and use your project for some time now and I'm a great fan. I do have the impression though it could be beneficial to implement some kind of automated testing to find obvious bugs early in the process and try to maintain a stable master (perhaps even develop) branch at all times.
There are various tools that may assist in such an endavour - starting from simple linting tools for various script languages to unit-testing php and bash scripts.
Setting this up would take some development time in the beginning, but the benefit in the long run would be easier code reviews as you do not need to take care about obvious errors anymore and can concentrate on the actual features and solutions that are queued up for merging.
What are your thoughts about this?

The following GitHub Actions exist:
https://github.com/MiczFlor/RPi-Jukebox-RFID/actions

Python linter flake8 and some unit tests
Test of installation script on a Docker image

In my repo I added a branch to add php unit tests, which needs some polishing:
https://github.com/s-martin/RPi-Jukebox-RFID/tree/add-php-action?files=1

Many Actions exist, so closing now.


Transform view

Useful component for scroll views/pan zoom areas and similar applications. Not sure if we want this in floem, but I'm opening this for discussion.

What is the use case for this view if you can set the translation and scale on a view using the styles?

It doesn't go beyond being a convenience component for scroll/pan zoom areas. I'm also leaning towards not adding it to floem. Perhaps I can change the example to set the style directly.

Or add the transform view as part of the example instead?

I mostly care about having a test case/example for this application.


python3Packages.gios: init at 1.0.1

Motivation for this change
Python client for getting air quality data from GIOS
https://github.com/bieniu/gios
This is a Home Assistant dependency.

Related Home Assistant change: https://github.com/home-assistant/core/pull/50145
Target Home Assistant release: 2021.6.0

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123171 at a1867802 run on aarch64-linux 1

1 package failed to build:

home-assistant

2 packages built successfully:

python38Packages.gios
python39Packages.gios

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

I have cherry-picked this change into my staging tree, thank you!


Auto page load

Can you make a button by which i can load all pages of a website in a single page automatically.

Of a website = a page on Threadless?
I'm hesitating about it, since it might cause their server to identify the user as hostile, since it will make multiple requests in a very short time.


upgrade react-select

I don't fully understand this PR yet... What about non-async React select usage? Is there going to be another component for that one? Also, I had understood we were making two generic searchable select components (one sync, one async) which used react-select under the covers so we could abstract it away.
Does this fully support object values?


709 examples update

Description:
This PR adds / fixes java examples to maintain consistency across repos
Added

ScheduledTransactionMultiSigThresholdExample
SignTransactionExample
MultiSigOfflineExample
ScheduleIdenticalTransactionExample

Fixed

CreateSimpleContractExample
CreateStatefulContractExample

Related issue(s):
Fixes #709 All SDK repos should maintain the same set of examples
Notes for reviewer:
Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

I think you might need to redo this PR because I think it was branched off #904 which is not merge-able at the moment.


"Finding files" check/waiter doesn't catch changes to file selection on Get Metadata Template tab

Describe the bug
The waiter is only triggered when changing a folder selection on the Select Dataset tab and moving the Get Metadata Template tab. It is not triggered when changing folders/projects using the "selection" button, up top (see screenshot).
To Reproduce
Steps to reproduce the behavior:

Go to curator app
pick a folder
go to get metadata template
change folder using selection tab at top

Expected behavior
Upon step 4, I'd expect this to trigger the same check & waiter that is triggered from the "select a dataset tab"
Priority (select one)

[x] Minor ⬇
[ ] Major 📢
[ ] Critical 🆘

Screenshots

@allaway Thanks for the reporting. If you click the "update" button (on the right of dropdown menu), will it trigger the waiter screen?

@rrchai, good point. that does trigger the waiter! I guess I wasn't actually updating the files when I tested this because I forgot to hit that. The window disappears for me when you make a new selection, so it seems like you're done (but you really have to open it back up to finish refreshing the data).
So maybe the bug is not that the waiter is not triggered, but that the UI makes you think you are done, but you actually have to hit a button to refresh the dataset :)

@allaway exactly! I think that confused me some times too.
I guess we could either keep this window open until you click the "update" button. Or we just deprecate the "update" button, in other words, changing the selection in the header dropdown will automatically sync/update the selection backend.

Hmm, yeah, I think both of those ideas are reasonable, but not 100% sure which is better.
I think I lean slightly towards the idea of keeping the window open until the refresh button is pressed, because it might be a frustrating experience with the waiter (which will presumably be triggered on every change) without a specific "Update" / refresh button.

Initially, we were thinking of having the project, dataset and data type/template selection be updated w/o having to press a button (same behavior as in the first screen of the app). As I recall @rrchai, it wasn't trivial to update selection on dropdown events, and you implemented the button click in the header selection update; the click is an easier event to catch.
If @rrchai thinks that "buttonless" selection update is now feasible, we can reconsider. It's true that we have the waiter screen now, which would be annoying to trigger on every dropdown selection.
I'd vote for a solution that's consistent and not annoying for the user and simplifies the codebase.
This could be sticking with the button and perhaps making it more visible, so that it's clear it needs to be hit.
Or, buttonless header selection and removing the file-gathering waiter altogether. The latter may require reducing file gathering latency. If we get down to less than a second for file gathering, we may not need a waiter screen.

Revisiting this as part of UX evaluation with design team.


Develop

Pull Request Test Coverage Report for Build 132

105 of 133 (78.95%)  changed or added relevant lines in 7 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+9.02%) to 54.603%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

aws_message/processor.py
7
8
87.5%

aws_message/sqs.py
0
1
0.0%

aws_message/crypto.py
0
3
0.0%

aws_message/gather.py
0
7
0.0%

aws_message/message.py
37
53
69.81%

Files with Coverage Reduction
New Missed Lines
%

aws_message/gather.py
1
0.0%

aws_message/processor.py
2
84.85%

Totals

Change from base Build 127:
9.02%

Covered Lines:
232

Relevant Lines:
392

💛  - Coveralls


my instance wont load

I need much more information to help you:

What operating system?
What modpack version?
Which Minecraft version?
Which launcher?
Have you made any modifications other than Additive itself?

I need much more information to help you:

What operating system? (linux distro, mac, or windows)
What modpack version?
Which Minecraft version?
Which launcher?
Have you made any modifications other than Additive itself?

The best thing would be to ask for logs first and foremost.

Yes, that aswell

Will be closing this as it was very vague and I haven't gotten a response


Establish the connection between the frond end back end for the SIGN-UP route.

Implemented field validation for the username, email, and password inputs.
Added an event listener to track changes in the input fields and enable the "Create Account" button only if all fields pass the validation. Otherwise, the button remains disabled.
Implemented a redirection to the home page upon successful sign-up.
Added user_id and logged_in status to the req.session for user authentication.

To-do:

Implement functionality on the client side to display error messages from the backend if the email or username already exists in the database.
Update the styling of the "Create Account" button to visually indicate whether it is enabled or disabled.
Consider adding an additional field to the sign-up form to accommodate any new columns added to the user model that need to be filled.
maybe something else i cannot think about right now.

p.s.
The functionality is operational, and new users have been successfully added to the database. However, it is possible that certain updates or modifications will be required in the future to enhance the app further.

The validation for the password, is there a certain amount of alphanumeric / special characters needed?  I have uppercase, lowercase, number, and special and it is giving me the error, preventing sign up.

Regarding the validation of passwords, it is required to have at least one numerical, one uppercase, and one special symbol character. I tested the functionality by pulling the main branch and loading my branch on top of it. The validation works well, and the user was saved to the database if at least one of the mentioned characters was included. The sign-up fields are validated when the user clicks out of the field and moves to another one. If the validation criteria are not met, an error message will appear. However, the error message does not mention the requirement for an uppercase character. Initially, I forgot to include the validation for an uppercase character. After I added the uppercase validation, I forgot to update the error message. Just Updated it and committed the changes. I am including a screenshot of the sign-up form that passed the validation and saved the user to the database.

Okay, it does seem to be the exclamation point then.  I tested it further and it works great with at least one of each, it just doesn't accept ! as a special character.  The first image fails, the second image passes.


feat: use OSTk Data as remote data source for IERS

Change the IERS frame data sources (BulletinA and Finals2000A) to use OSTk Data
Split remote URL into two for those (the github URLs for the two are different now)
Introduce a Manifest class to parse the OSTk Data manifest here

This let's us be more systematic about how old the data is and when we pull new data. (useful especially for big files)

Remove ISODate subdirectories for BulletinA and Finals 2000A. I think it was a form of versioning but the code did not really take advantage of it.

Adding @lucas-bremond as reviewer as he's most familiar with the Manager flow.

LGTM too!