ESO stopped working on OpenShift

Describe the solution you'd like
When I deploy ESO on OpenShift 4.11.20, external secrets are not synched. Running "kubectl describe extenalsecret app-secret", I get: "could not get secret data from provider"
Observations (Constraints, Context, etc):

When I install ESO using Helm, I get these warnings:
Release "external-secrets" does not exist. Installing it now.
W0113 02:38:44.819046   58684 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "external-secrets" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "external-secrets" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "external-secrets" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "external-secrets" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
W0113 02:38:44.839787   58684 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "cert-controller" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "cert-controller" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "cert-controller" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "cert-controller" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
W0113 02:38:44.841567   58684 warnings.go:70] would violate PodSecurity "restricted:v1.24": allowPrivilegeEscalation != false (container "webhook" must set securityContext.allowPrivilegeEscalation=false), unrestricted capabilities (container "webhook" must set securityContext.capabilities.drop=["ALL"]), runAsNonRoot != true (pod or container "webhook" must set securityContext.runAsNonRoot=true), seccompProfile (pod or container "webhook" must set securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")

After deployment, I get following error messages in PODS:

a) Pod: external-secrets-webhook-8fd54b58d-mlrpf. Message: http: TLS handshake error from <IP_ADDRESS>:54530: remote error: tls: bad certificate
b) Pod: external-secrets-7584fd846f-68rnq. Message:
{"level":"info","ts":1673596125.4246821,"logger":"provider.aws.secretsmanager","msg":"fetching secret value","key":"app-secret","version":"AWSCURRENT"}
{"level":"error","ts":1673596125.7640798,"logger":"controllers.ExternalSecret","msg":"could not get secret data from provider","ExternalSecret":"app/app-secret","error":"RequestError: send request failed\ncaused by: Post "https://secretsmanager.us-east-1.amazonaws.com/\": net/http: invalid header field value for "Authorization"","stacktrace":"github.com/external-secrets/external-secrets/pkg/controllers/externalsecret.(*Reconciler).Reconcile\n\t/home/runner/work/external-secrets/external-secrets/pkg/controllers/externalsecret/externalsecret_controller.go:190\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:122\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:323\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.14.1/pkg/internal/controller/controller.go:235"}

Hi @open-sudo ! This issue seems to be regarding some misconfiguration, most likely. Did you recently upgrade versions?  What version are you using?

I tried this many times on brand new clusters. The first thing I tried after initiating the cluster is set up ESO. I follow the procedure described here: https://ptuladhar3.medium.com/getting-started-with-external-secrets-operator-on-kubernetes-using-aws-secrets-manager-6dc403d9630c. So, I would like to think that it pulls the latest ESO.

It might be worth to check for new lines in your AWS secret (if thats how you are authenticating). We've seen similar errors to yours that were because the authentication info (AccessKeyId and SecretAccessKey) contained "\n" in it.

You are right. Some invisible characters in the credentials. Not sure if I can ask this question here. My credential includes line break. If I put them AS in AWS Secret manager, ESO complains about it:
unable to unmarshal secret aws-credentials4: invalid character '\n' in string literal
On the other hand, if I base64 the credential before putting it in AWS Secret Manager, they are re-encoded when store in a Secret. I added:
decodingStrategy: None
encodingStrategy: None
But this doesn't help.

You should set decodingStrategy: Base64. That will make eso automatically remove the double encoding for you (note that it is not eso that is double-encoding it, but rather kubernetes itself)

Awesome thanks. closing the ticket.


WFLY-15306 Clear cached timer info from in-memory timers when using D…

…atabaseTimerPersistence
https://issues.redhat.com/browse/WFLY-15306

org.jboss.as.test.multinode.ejb.timer.database.DatabaseTimerServiceRefreshTestCase#testTimerProgrammaticRefresh failed, because the test assumes the timer info is obtained from in-memory cache, but with the code change in this PR, timer info can be erased from in-memory and so info will be retrieved from the database, and hence it returns the up-to-date value (reflecting the fact that this timer has been cancelled by node2, and so getting timer info from node1 will also return null). We should modify the test logic.

@tadamski  please review.


Fix#10584: Update dashboard ES indexes for dataModels

Describe your changes:
Partial fixes #10584
Updated dashboard ES mapping to support searches by data models.

Type of change:

[x] Improvement

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
[ ] I have added tests around the new logic.
[ ] For connector/ingestion changes: I updated the documentation.

hi @nahuelverdugo would you mind merging this one after https://github.com/open-metadata/OpenMetadata/pull/10852? Noticed some missing pieces in the ES sink and did a full cleanup. I believe it might be easier to move the pieces in your branch than the other way around.  Thanks

hi @nahuelverdugo would you mind merging this one after #10852? Noticed some missing pieces in the ES sink and did a full cleanup. I believe it might be easier to move the pieces in your branch than the other way around.  Thanks

Sure, no problem.


Added data field to ContentState record.

Summary
This adds a data field to ContentState making it possible to keep metadata structures in sync with the content state.
Motivation
Since draft is built around static transformation functions that generate new ContentState objects, there isn't any easy way to record metadata for a given ContentState instance and ensure that it isn't lost in any of the transformation functions.
If the transformation methods were written to reuse the class of the provided ContentState, it would be possible to extend the ContentState record without any further changes to draft, but this isn't possible as it works now. Adding a data field will provide a generic and future proof way of keeping metadata that is in sync with the content state.
Test Plan
The editor should be working as before. I've added an automated test to verify that the data field is there.

Can you give some specific use cases that are enabled by this change?
My thought is that any 'metadata' related to the editor state can be kept in the state of the parent component, in a separate field from the 'editorState' or 'contentState'. I also have a general preference for small API and strict type definitions, would rather not add a new field that has no type restrictions or specific use.

We've already headed down this road by adding data fields in various other places and the stuff I am setting up is very tightly coupled to the editor state, so every place the content changes, I'll have to carry around two states that carefully have to be kept in sync. I have thought about the approach and there is a large number of places in my codebase I'll have to change if I do this.

The specific use case is that I am making it possible to edit XML documents where some elements are rendered as entities including nesting. The tree structure of the underlying XML document needs to be stored somewhere and kept in sync with the rest of the content, since edit operations to the content may also modify the tree. The sync operations goes in both directions, since the user has the option to add new elements to the XML document.
The XML format that I currently work on has elements that represents comments, additions, deletions, quotes, links and footnotes. Many of those elements can be combined, so it is possible to have a footnote inside an addition inside a quote as an example.

If there is another better way of customizing the contentState so I can add global data some other way, I'd be interested in adding that in stead.

@flarnie ?

Ping @flarnie...

@mzedeler it's quite unclear what this field would be for for beyond what you use it for, and I don't see why accommodating what you're doing requires changes in Draft.js. Is there anything preventing you from using the following state structure?
const myState = {
    // The Draft.js state.
    editorState: EditorState.createEmpty(),
    // Your own extension.
    data: { /* ... */ },
};

I might be misunderstanding your need but if you need this extra state anyway I don't see why you couldn't also write methods to manage it in sync with the editor state (potentially wrapping the Draft.js operations as well to make this easy).

While it is possible to use the approach, you describe, @thibaudcolas, it isn't very feasible because I am writing a very lange extension for Draft, making it possible to use Draft as an XML editor.
The state of the non-draft contents are kept in a data structure called treeState (think XML tree) and I have about 50 places in my code where I need to access the treeState for a given contentState.
Note that the treeState needs to be added to contentState, not editorState, which makes it even more cumbersome, because I need to keep the treeState aside both editorState and contentState in all the places where they are being passed.
I have 32 locations where I call getCurrentContent() that needs to be replaced.
Also, I have plenty of places where I do stuff like this:
return someEdits
  .reduce(
    (nextContentState, edit) => performEdit(nextContentState, edit),
    contentState
 )

At all those return sites, I need to return a tuple of some kind containing the treeState as well, including all the places where I do the same on the editorState. It makes the code extremely unwieldy.
A whole different point is that if we can implement this data attribute, it'll be much easier for me to split out the XML handling from my application and publish it as Open Source, since the API will be much easier for others to use.

I have been looking into using Slate and while it seems to have an API much more geared towards the use case I have, it also isn't as mature as Draft.js, so my team decided to stick to Draft.js and build what was missing on top of it.
I have also been looking into storing data on block level, but it'll require some implicit rules regarding the metadata that I have that are far from ideal.
The bottom line is: I have metadata that relates to the document as a whole - not any particular block - that I need to be part of the undo/redo state, just like Draft.js (should) let entities be part of the undo/redo state.

@mzedeler - echoing the comments by @flarnie & @thibaudcolas, I don't think this is a good fit for the current API.
If it might help down the road for your particular use case with a XML tree, we are currently exploring a tree-based data model for Draft.js (you can see some of my recent commits related to that). This is still in very early stages & experimental, so no promises on stability or continued support for that at the moment.

I have realized that you probably wouldn't accept this change, but do note that the approaches suggested by @thibaudcolas above aren't feasible since I'd have to implement a parallel undo/redo stack, so I've forked Draft using the change in this PR.

Ping @niveditc - how did it go with the XML editing feature? I've completed mine and it just works, albeit only on a soft fork of Draft where I have a data field on contentState (as the only required API change).


[SMALLFIX] Do not process persisted paths during updating absent paths.

For a path like /mnt/task/level/file where / is the only mount point,  if /mnt/task/level is persisted, but file is not persisted, then every time listStatus is called, the AsyncUfsAbsentPathCache#process will call ufs.exists on /, /mnt, /mnt/task, /mnt/task/level, and /mnt/task/level/file.
This PR changes this behavior by starting process from the first component that is not yet persisted.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17583/
Test PASSed.

@gpang Yes, this is off the client path, but if it consumes too much CPU on master, I think it will affect master's performance.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17595/
Test PASSed.


Null safety

Thanks for the PR @chaitanya-bhagavan. I don't know swift myself, so I'll try to find someone else to review this PR, since I don't have the necessary knowledge to judge this code. Could you please describe this PR a little better? What is this fixing/improving ?

Also, I see you're updating the flutter dependency to minimum 2.0. I think this is a breaking change, since people will be forced to update their flutter version to use the library. If this gets merged, we have to release version 2.0.0 and document the breaking change (note for future self)

Also, I see you're updating the flutter dependency to a minimum 2.0. I think this is a breaking change since people will be forced to update their flutter version to use the library. If this gets merged, we have to release version 2.0.0 and document the breaking change (note for future self)

Do we need to increase the minimum? I think that we can keep the same version. But if we decide to update it will be a breaking change

Reverted to 1.20


WebGL images bug

Visiting the fingerprint page multiple times with the same browser and configuration can yield slightly different images for the WebGL test.
The easiest way I've found to replicate this bug is as follows:

Start up Google Chrome in incognito mode.
Visit the fingerprint page and save the WebGL image.
Visit the fingerprint page a second time and save the WebGL image.
Compare the images, and they'll probably be different.
Incognito mode seems to be important because the image only seems to be different the first time you visit a page (it might have something to do with cookies or cached content).

Attached are the two differing images. The first is from my first page visit, the second from my second visit.

Thanks for your interest in AmIUnique!
We are very well aware of that problem because when we started analysing the data, we found out that our test was too sensitive. There are so many parameters that directly or indirectly impacts this test that it is very hard to draw any conclusions from it. We are in the process of changing its behaviour and we may deploy an update on that very soon. In the meantime, we will hide the WebGL test until we have something meaningful to show to the user.


Update: Update package-lock.json files

Resolves #

Description
Proposed Changes

Screenshots
License
I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

👍 I wasn't sure if this needed doing or not. thanks


Fix Adding attendance

Changed how we handle dates
Fixes #572

Check it out at https://staging.rcos.io !

Oops, fixed


Fix emoji

#580  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dongreenberg and the rest of your teammates on  Graphite


App renaming script

PR intending to add support for feature requested in #23

Thank you @chadrien! I won't be on my computer for a couple of days, but in the meantime @krivachy and @tinojunge could test and merge if everything seems to work.

Eh, that's @tino-junge

Is this the expected output?
FL761:pepperoni-app-kit akri$ ./support/rename.sh MonkeyApp
sed: 1: "./android/app/app.iml": invalid command code .
sed: 1: "./android/app/src/main/ ...": invalid command code .
sed: 1: "./android/app/src/main/ ...": invalid command code .
sed: 1: "./android/settings.gradle": invalid command code .
sed: 1: "./bitrise/bitrise.ios.yml": invalid command code .
sed: 1: "./index.android.js": invalid command code .
sed: 1: "./index.ios.js": invalid command code .
sed: 1: "./ios/PepperoniAppTempl ...": invalid command code .
sed: 1: "./ios/PepperoniAppTempl ...": invalid command code .
sed: 1: "./ios/PepperoniAppTempl ...": invalid command code .
sed: 1: "./ios/PepperoniAppTempl ...": invalid command code .
sed: 1: "./ios/PepperoniAppTempl ...": invalid command code .
sed: 1: "./ios/PepperoniAppTempl ...": invalid command code .
sed: 1: "./package.json": invalid command code .
sed: 1: "./src/utils/snapshot.js": invalid command code .
sed: 1: "./android/app/BUCK": invalid command code .
sed: 1: "./android/app/build.gradle": invalid command code .
sed: 1: "./android/app/src/main/ ...": invalid command code .
sed: 1: "./android/app/src/main/ ...": invalid command code .

It seemed to have moved the folders correctly, but misses the file contents.

@chadrien forgot the environment details:
OSX, using iTerm:
$ bash -version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin15)
Copyright (C) 2007 Free Software Foundation, Inc.

Absolutely not. I'll check that.

@krivachy Oh I just pushed a small fix, but actually reading your issue I'm pretty sure that's because your sed is the one provided by OSX and not GNU one (precisely the -i option is the one causing problem).
Could we declare say that (at least for now) the renaming script requires gnu-sed? And add a doc for installation on OSX: brew install gnu-sed --with-default-names

@chadrien I think we need a solution that works on a vanilla OSX box, because that is the majority environment for our users. Having a requirement for custom sed would likely cause too much confusion and unnecessary trouble.
We could perhaps write the rename script as an executable node.js file?

@jevakallio It's ok, I found a solution that works for both BSD (Mac) and GNU (linux) sed.
I'll commit it once I successfully ran the usual run-ios and run-android locally.

@jevakallio  We're good! 👍

@chadrien excellent! I'll try to get a couple of other PRs merged in first to avoid unnecessary rename conflicts, will be pulling this in shortly.

@chadrien I've merged your commits to master as part of https://github.com/futurice/pepperoni-app-kit/pull/38. Upgrading Pepperoni to React Native 0.26 and CocoaPods 1.0 caused quite a mess, so I had to rebase a lot of the changes manually.
I found and fixed one missing rename step https://github.com/futurice/pepperoni-app-kit/pull/38/commits/8cb03c402a8062e7bcbfa5a0a71f38d1377a54d3, and added some instructions to run a clean build after rename, as my app would not build without it after the rename.
Thanks for the contribution! 🍕

🎉


Change trace duration to milliseconds

just leaving this open for right now, should have time this week, just want to make sure I remember that it's a v2 thing if we consider it a breaking change (debatable I guess haha)


Release 1.0.0

Checked according to the guidelines:
https://nf-co.re/docs/contributing/pipeline_release_review_guidelines

PR checklist

[ ] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

I was expecting a 0.* release, not 1.0. Have you changed your plans ?


libcamera: 0.3.0 -> 0.3.1

Changes: https://git.libcamera.org/libcamera/libcamera.git/tag/?h=v0.3.1
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

It's failing on aarch64-linux, can this be merged?
I see that's not in Hydra anyway:
https://hydra.nixos.org/job/nixpkgs/trunk/libcamera.aarch64-linux

It's failing on aarch64-linux

Looking at ofborg failure https://github.com/NixOS/nixpkgs/pull/330270/checks?check_run_id=27988401525 it's a dependency failure, not libcamera itself:
error: 1 dependencies of derivation '/nix/store/65x5k834vifb27901h564hr0dnd6dj5c-libcamera-0.3.1.drv' failed to build

The real failure is a few lines above:
Summary of Failures:

14/14 test_opus_encode     TIMEOUT        240.12s   killed by signal 15 SIGTERM

Ok:                 13
Expected Fail:      0
Fail:               0
Unexpected Pass:    0
Skipped:            0
Timeout:            1

Full log written to /build/opus-1.5.2/build/meson-logs/testlog.txt
checking for link... yes
checking whether the gcc linker (ld) supports shared libraries... yes
checking for strcasecmp... yes
error: builder for '/nix/store/r41aqa4w86r2qd3ny8fix949p6f5bg5a-libopus-1.5.2.drv' failed with exit code 1;


Setting blinds to My position isn't recognized

Hardware
ESP32
Firmware version
v2.4.7
Application version
v2.4.7
What happened? What did you expect to happen?
If I have my blinds in any other position than "My position" and press My button on Telis 4 remote, they go down to that default position (completely down and 45° tilt). ESPSomfy doesn't pick this command and it thinks that the blinds are open. Am I missing any configuration? Thank you for your time and opinions.
How to reproduce it (step by step)
1. Set Somfy blinds to arbitrary position,
2. Press "My" button on a remote

Logs
No response

Are you sure your blind motors support the My position if the do not click the Simulate Favorite checkbox.

Simulate Favorite Position is unchecked on all of my blinds.

Do you have a my position that is set in ESPSomfy RTS and if so when you set it did the motor jog?

No, I don't have My position set in ESPSomfy yet.  Thank you.

Yes
https://github.com/rstrouse/ESPSomfy-RTS?tab=readme-ov-file#setting-a-favorite

Hi,
same issue with my pergola. I haven't state feedback. I would like to use up / My / down without any position restriction.

ESPSomfy RTS adds the position feedback to your motor by setting the motor timings.


Extract ReadOnlyFileTreeElement interface

To discourage copyTo method of FileTreeElement usage in filtering and have a read-only view of a file tree element
Context
This refactoring arose as a part of https://github.com/gradle/gradle/issues/3982.

@bot-gradle test this

I've triggered the following builds for you:

PullRequestFeedback build


[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

What problem did you encounter?
the file you have chosen does not appear to be a valid font file what do i do?
Bloxstrap Log
N/A

Could you give us more information? and possibly send the font file your trying to use?

What file are you trying to import?

Could you give us more information? and possibly send the font file your trying to use?

I was trying to use the BMW Type Next font and it said the file you have chosen does not appear to be a valid font file.

Could you give us more information? and possibly send the font file your trying to use?

I was trying to use the BMW Type Next font and it said the file you have chosen does not appear to be a valid font file.

you have to unzip the file and click the font and download then import.

Send the font file here please

Send the font file here please

i cant because it says something with the file is not supported or something

Upload it somewhere else and send a link here

I already solved it with Bloxstrap discord server

Relevant thread: https://discord.com/channels/1099468797410283540/1289834220931252257
Issue was that your font is actually a .otf font, but with a .ttf file extension. I'll address that.


Adds and documents a way to manually test a custom hive image

What this PR does / why we need it:
It is not the best way to test the changes, but for now it is jsut to close a gap.
Test plan for issue:
Manual test of the docs

@dem4gus updated. Please take another look.


Windows: Workspace placed on rootdir loses pathinformation

This is quite a strange bug, i created a workspace under D:\ and imported a existing directory into it (matplotlib). Now everytime i restart spider is lose the first char of the directory name, after three restarts it is now plotlib and doesnt work anymore.  Cause is properly forgetting to use raw string with windows paths.

This is a very strange bug indeed. We'll what we can do about it.

This Bug is quite old, i saw it already some year ago, but was working on networkdrives and blamed that. Now i am seeing the same on my local drives. What is quite irritating is that these wrong directorys are created too.

Additional to this, the new version of Spyder removed the concept of workspaces and introduced a new concept of projects.

@goanpeca, please don't forget to remove milestones when closing issues :-)


Safe area for the map view

This PR restructured TGCardVC slightly to have the map view in its own VC with, critically, its own safe area. The safe area is the visible part of the map when the card VC is in collapsed or peaking mode.
This fixes the positioning of the attribution and legal label when used with MKMapView, and it fixes setting the centre location of the map or taking the map into tracking mode when the card is in peaking mode.
Additional changes:

When the card is extended the map is made non-interactive to disable it from surfacing any VoiceOver from underneath the extended card.
Removes the need for manually handling edgePadding when using the MKMapView-based TGMapManager.

Known issues:

[ ] The maps attribution label jumps to its new position when tapping to expand

Looks okay to me.


Michael and Brett's Changes

I also added a LICENSE file and a README that we can begin editing. I suppose we can just add things to this pull request and merge it into master before midnight.

Be sure to resolve any merge conflicts before pushing up your changes I should note.

If you find anything go ahead and correct it. That way we have a better chance of hitting everything.

I'm prepared to merge if everyone else is


[BREAKING] Remove StandardMaterial.diffuseTint and simply always apply it

before: When the diffuseTint is true, the diffuse color is used. But only when diffuse texture nor vertex colors were used. This is too confusing, and generates shader variants to save on a uniform and a single multiply.
now: tint is always on, and applied even when diffuse texture or vertex colors are used

A separate PR will apply this to additional tints of the material.

This will definitely break a lot of materials for people, as they might have tweaked diffuse color, especially when it is set to weird greys from imported models most of the time.

Hi @Maksims - yes, we'll be adjusting the materials in the Editor when the project loads with engine 2, and handle it. If the tint switch is false, we'll set the color to white.


tosa.rescale calls roundevenf()

89a1af74@llvm-project introduces the use of math::RoundEvenOp which is lowered into a call to roundevenf() in libm, which causes an undefined symbol issue.
To work around the issue, the following tests in iree_tfl_tests are marked as XFAIL for now.

mobilenet_v3
person_detect
llvmcpu_mobilenet_v3-large_uint8
llvmcpu_posenet_i8
llvmcpu_resnet_50_int8

that's real bad - that means we aren't vectorizing these at all - we could add the libm function as a workaround but someone should look into ensuring this gets vectorized and properly lowered.

I can look into the lowering. Its a little tricky where it should live but I can probably find a home for it. Implementation is the bigger question.

@jpienaar P1 or no?

Oh, this is a duplicate of https://github.com/openxla/iree/issues/12836, with a more descriptive issue title. I did some digging on the other issue. Which should we keep and which should we close?

To work around the issue, the following tests in iree_tfl_tests are marked as XFAIL for now.
mobilenet_v3
person_detect
llvmcpu_mobilenet_v3-large_uint8
llvmcpu_posenet_i8
llvmcpu_resnet_50_int8

Oooh... that's why our CI was passing when downstream reported failures... yeah... that's really bad :/

Definitely at least P1. We can't be regressing compilation correctness on real programs. I'd have advocated for blocking the LLVM integrate on that and not disabling tests. This is not a good state to be in.

@rsuderman Let us know if you are looking into this? Marked as P1, can update the status as you see fit.

This should all be bucketed together with the work in https://github.com/openxla/iree/issues/12783
No one lowering there is that bad, we just need someone to dedicate a few weeks to implementing each lowering and doesn't mind learning floating point manipulations.

Is there an acceptable workaround in the meantime? It doesn't look practical to ask for an upstream revert, considering how the break is indirect (introduces libm calls which most LLVM/MLIR users are okay with but we are not). Taking O(1 month) to address a regression in compilation coverage with currently unprioritized feature work is not a great look :/
Could we (for example) add a pattern that switches back to the old behavior? Or one that lowers roundeven() to round()?

If we do move forward like this (no workaround, wait on the "right fix"), I'd at least want to see some notes show up in any affected stable releases that this is a known issue.

If you want the fastest "unbreak" approach your best approach is to add a lowering in iree that converts roundeven to round, then we would need to be certain we fix the issue properly. Reverting the upstream patch is not valid as this is an issue with IREE not having a lowering path for roundeven.

@ramiro050 is this in progress?

@ramiro050 is this in progress?

Yes, this is in progress.

The expand pattern for roundeven has landed: https://github.com/llvm/llvm-project/commit/8d2bae9abdc30e104bab00a4dd0f9d39f5bdda6e

Rollback upstream due to failure on M2, is it something you can reproduce or would need help finding place to run it?

Rollback upstream due to failure on M2, is it something you can reproduce or would need help finding place to run it?

I can try reproducing on my M1 Macbook. Although the issue seems to be that it is perfectly valid to print a negative nan value as nan without the sign.
For reference, rollback of rollback: https://reviews.llvm.org/D148941

Issues leading to rollback of roundeven patch have been fixed: https://github.com/llvm/llvm-project/commit/44baa65589683dd441594d74625bb0b3ac265dc8

This LLVM version has now been integrated, is next step adding that populate method in?

llvmcpu_posenet_i8.run fails with numerical difference.


ladle build gives filenotfound error for typings-for-build tsconfig file

Describe the bug
on running npx ladle build, an error is thrown:

><EMAIL_ADDRESS>build-ladle
> ladle build

FileNotFoundError: File not found<EMAIL_ADDRESS>    at RealFileSystemHost.getFileNotFoundErrorIfNecessary (F:\htmlcss\react-pewpew\node_modules\@ts-morph\common\dist\ts-morph-common.js:1970:50)
    at RealFileSystemHost.readFileSync (F:\htmlcss\react-pewpew\node_modules\@ts-morph\common\dist\ts-morph-common.js:1892:24)
    at TransactionalFileSystem.readFileSync (F:\htmlcss\react-pewpew\node_modules\@ts-morph\common\dist\ts-morph-common.js:2468:32)
    at TsConfigResolver.getTsConfigFileJson (F:\htmlcss\react-pewpew\node_modules\@ts-morph\common\dist\ts-morph-common.js:3048:38)
    at TsConfigResolver.decorator (F:\htmlcss\react-pewpew\node_modules\@ts-morph\common\dist\ts-morph-common.js:2874:46)
    at TsConfigResolver.parseJsonConfigFileContent (F:\htmlcss\react-pewpew\node_modules\@ts-morph\common\dist\ts-morph-common.js:3044:70)
    at TsConfigResolver.decorator (F:\htmlcss\react-pewpew\node_modules\@ts-morph\common\dist\ts-morph-common.js:2874:46)
    at TsConfigResolver.getCompilerOptions (F:\htmlcss\react-pewpew\node_modules\@ts-morph\common\dist\ts-morph-common.js:3013:21)
    at TsConfigResolver.decorator (F:\htmlcss\react-pewpew\node_modules\@ts-morph\common\dist\ts-morph-common.js:2874:46)
    at getTsConfigCompilerOptions (F:\htmlcss\react-pewpew\node_modules\ts-morph\dist\ts-morph.js:20124:111) {
  path<EMAIL_ADDRESS>  code: 'ENOENT'
}
node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[Error: ENOENT: no such file or directory, open 'F:\htmlcss\react-pewpew\build\meta.json'] {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'open',
  path: 'F:\\htmlcss\\react-pewpew\\build\\meta.json'
}

Node.js v18.15.0

Environment

OS: Windows
Browser : Chrome
Version : Latest

Happening on macOS as well with 2.11.1

Happening on macOS as well with 2.11.1

Can you reproduce this with https://ladle.dev/new?

Yes. Still same issue with 2.12.0 :(
Here's the repo I'm using it for
https://github.com/saisandeepvaddi/ant-table-extensions/blob/2.0/package.json#L70

I had the same issue and found that my Vite configuration caused the problem. I have custom Build Options configured and once I put those in comments it solved the issue.
What you could try is to create a second (empty) Vite configuration file:
import { defineConfig } from 'vite';

// https://vitejs.dev/config/
export default defineConfig({});

Then run your ladle build with the --viteConfig option set. ladle build --viteConfig ./vite-ladle.config.ts

Seems to be caused by vite-plugin-dts, but vite build works just fine.

not really tracking this as a bug since the root cause is vite-plugin-dts (or that's the repro we have so far)


feature : develop Endpoint to Fetch LLM Application Variant Parameters

Summary
This (Draft) PR addresses the API for fetching a specific app variant based on app_name and variant_name. The API parameters are passed as query parameters.
Related to Issue #571
Example Request
GET /api/app_variant/get_variant_by_name/?app_name=test&variant_name=v1
Issues to Address
Unit Testing: I still need to complete the def test_get_variant_by_name() function. Any suggestions on what parameters should be used for testing would be appreciated.
Exception Handling: Encountering an issue where the intended 404 error is not being triggered as expected. Despite the condition if app_variant is None being met, a 500 error is raised instead of a 404 error. This happens when I remove the block except HTTPException as e: raise. Refer to this line for more details.

Thank you for the review, @mmabrouk. I've temporarily removed the line that throws the 404 error. However, the issue persists: the code execution reaches the line 93  if app_variant is None: as indicated by the logs, but the actual error is caught outside the 'try' block.
I've also added a simple unit test for invalid parameters. Thanks for creating a separate issue for that!

Closes #571


Patch for endDate

fixes problem where duration is being read in as a string rather than a float

Codecov Report

Merging #54 (9d0675f) into main (672e578) will increase coverage by 0.01%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   90.03%   90.04%   +0.01%
==========================================
  Files           4        4
  Lines         632      633       +1
==========================================
+ Hits          569      570       +1
  Misses         63       63

Impacted Files
Coverage Δ

tests/test_parser.py
100.00% <ø> (ø)

adtl/__init__.py
84.98% <100.00%> (ø)

adtl/transformations.py
97.50% <100.00%> (+0.06%)
:arrow_up:


Add Multirun stop button

Added a stop button to toolbar to close the opened windows
Added tooltips for the buttons

renamed variable to meaningful names
error checking when starting additional windows

Hello @cyraid,
I believe this is the latest repo uploaded to the asset library, but are you the developer?

@handras I am a collaborator yup! I somehow don't get notifications for this repo, I'm not sure why! But I checked the commit, looks good! One small thing, could you bump the version from 2.0.3 to 2.0.4 and go ahead and add your name to the author in plugin.cfg (if you want)?

@xiezi5160 would you be able to push the update on godot asset website?

@xiezi5160 would you be able to push the update on godot asset website?

@cyraid Okay, I'll bring it up now, thank you ~

@cyraid I have completed the submission, thank you for your hard maintenance ~

@xiezi5160 you're welcome! I'd push it on the asset library too but the last time I checked they don't allow multiple collaborators.

@xiezi5160 you're welcome! I'd push it on the asset library too but the last time I checked they don't allow multiple collaborators.
Yes, the Godot Asset Library does not allow multiple people to collaborate.
It's okay, if you need it in the future, you can @ me, or you can resubmit a plugin in Godot Asset Library.

@xiezi5160 it's okay. I'd rather keep this repository if you're willing, because there's already another multirun repo, if there were 3 it'd start to seem confusing haha .. I'll ping you when we need to push if you're okay with it. ^_^

@xiezi5160 it's okay. I'd rather keep this repository if you're willing, because there's already another multirun repo, if there were 3 it'd start to seem confusing haha .. I'll ping you when we need to push if you're okay with it. ^_^

@cyraid Okay, as you wish, haha!


Make plugins oauth and oauth2 urls to be considered outside links

Summary
Make plugins oauth and oauth2 urls to be considered outside links. This is to permit plugins to authenticate on a browser, and avoid Google restrictions on log-in.
Issue link
https://mattermost.atlassian.net/browse/MM-22113

I reopened this PR due to the conversation here.

Not much to say on the code here. But I would like @DHaussermann to test this out with the JIRA plugin at least to see how it works.

@larkox I'm not seeing the authentication for Zoom and other plugins work consistently. I've tested this on 2 windows machines and in some cases, it opens a browser windows that shows Not authorized. I can see this for Zoom as well as GitHub and GitLab when I tested. It does not reproduce on 1 on my machines.

Jira is working but, Jira is opening a 2nd window for the desktop app and not a browser window.

0/5 - I think in cases where it is working there are pre-existing browser session that are authenticated or there are credentials saved in the browser (or possibly the desktop app its self).
Can you see if you can repo this? Maybe you have some thoughts on a way to isolate the issue?
Steps (windows):

Uninstall Mattermost desktop
Clear all application data for Mattermost desktop
Ensure no relevant credentials are stored in your browser and close all browser sessions
Launch .exe from the CircleCi zip package for this PR
Add a server name and address where Zoom is installed and working
Login as a user not mapped to any Zoom account
Click the connection link
Expected: Zoom login page
Observed: Not authorized

I just realised how naive this solution was.
You get the Not Authorized message because you are not logged in to Mattermost on the browser. You are logged in on the App. It was working on my system because I was also logged in on the browser.
Therefore, unless we can somehow send the session to the browser, it would not be possible to use this solution.
Right now I am out of ideas. Do you know any other possible solution for this?

@larkox It's been a busy week so I haven't been able to make time, but I'm still wanting to test with BrowserView and see if the restriction is solely for webview.
I don't have a paid Zoom account, so I may try Github plugin.
Just need a minimum setup for testing.

@hunterlester if it helps - I was able to to create a developer account on Zoom and create an oAuth2 application that way. The only issue is that my dev application only works with the one set of Google credentials that I registered with so, it's not shareable as no other users can be authorized.

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

@larkox @deanwhillier Looks like from the discussion here this is not going to work. Should we close this while we figure out an alternate solution? Not sure if there is already discussion ongoing about that.

I only kept this open to have a hub for discussing other solutions. Nevertheless I have no problem closing it.


add readme for how to connect cloudsql via cloudsql proxy

@wchamber Hi Will, sorry, I totally forgot this PR. Comments are addressed, PTAL, thanks!


Use affinity to proactively connect back to persistent connection

Description
When we have streaming (Websocket, directly speech) connections the proactive postback of activities needs to go to the node which has open connection.  Azure uses ARRAffinity tokens to route traffic for affinitity.  This delta captures the ARRAffinity token for when the persistent connection is opened, and passes that data through to the remote process which is continuing the conversation.  When the post back happens it includes the ARRAffinity token which should then be processed in the adapter with the live connection and routed out through the streaming interface.
Specific Changes

Add ARRAfinity property to StreamingHandler  and promote ARRAfinity into TurnState for activites that come through the streaming connection.
Capture the ARRAffinity in the BotFrameworkHttpAdatper, and set the StreamingHandler.ARRAfinity with it.
Change ContinueConversationLater to use the ARRAffinity from TurnState and annotate the activity.ARRAfinity with it.
Change BotFrameworkHttpClient to use the activity.ARRAfinity in the HttpClient request that the POST back has affinity to the streaming node.

Testing
TBD

@tomlm could you please resolve the conflicts? Thank you.

Discussed with @willportnoy, this does not a deterministic mechanism, it is more of an optimization. Will close for now. We can re-open it if the issues get resolved.


Composite/Aggregate tuples

This PR adds support for composite and aggregate algos and models.
The API changes are:

algos are now returned through 3 endpoints (/algo, /composite_algo and /aggregate_algo)
/model returns objects that have either a traintuple or a compositeTraintuple or an aggregatetuple

Algo page

added composite and aggregate tags for the list pane
added a  type metadata for the detail pane (with value either Standard, Composite or Aggregate)

Model page

added composite and aggregate tags for the list pane
actions in the list pane now offer to copy the traintuple key or the model key for standard models

@GuillaumeCisco I made changes following your first review, thanks a lot!


Made AsyncApiSchemaOptions inherit from JsonSchemaGeneratorSettings

Recent change to NewtonsoftJsonSchemaGeneratorSettings does not allow compatibility with System.Text.Json and forces users of the saunter library to introduce newtonsoft into their projects.
@m-wild

@m-wild @VisualBean @yurvon-screamo
Any chance of closing this PR?

First off, it doesn't seem to compile
Also looking at the commentary from the PR that introduced the change in the first place, it looks like it needs a bigger redesign than simply changing the basetype here.


[AutoPR peering/resource-manager] Adding Specifications for Peering

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5343

(message created by the CI based on PR content)


Ignore shadow tables (used in full text search) in SQLite

Problem
Some features of sqlite like FTS5 virtual tables create shadow tables.
The virtual table is ignored by prisma migrate dev commands, but the shadow tables are not.
Using full text search seems like could be possible (at least using raw queries), and easier, if prisma migrate dev also ignored shadow tables.
Suggested solution
Seems like you can detect shadow tables using the xShadowName method.
Alternatives
Adding some syntax to allow ignoring tables/entities in a schema.prisma file, like just:
model PleaseIgnore {
  @@ignore
}

Additional context
To reproduce, create a simple schema:
model Projects {
  id             String           @id @default(uuid())
  name           String
  description    String
}

Create the migration prisma migrate dev --create-only, and modify it with:
CREATE VIRTUAL TABLE projects_idx USING fts5(id, "name", "description", content='Projects');
-- Triggers to keep the FTS index up to date.
CREATE TRIGGER projects_idx_i AFTER INSERT ON "Projects" BEGIN
  INSERT INTO projects_idx(id, "name", "description") VALUES (new.id, new."name", new."description");
END;
CREATE TRIGGER projects_idx_d AFTER DELETE ON "Projects" BEGIN
  INSERT INTO projects_idx(projects_idx, id, "name", "description") VALUES('delete', old.id, old."name", old."description");
END;
CREATE TRIGGER projects_idx_u AFTER UPDATE ON "Projects" BEGIN
  INSERT INTO projects_idx(projects_idx, id, "name", "description") VALUES('delete', old.id, old."name", old."description");
  INSERT INTO projects_idx(id, "name", "description") VALUES (new.id, new."name", new."description");
END;

Run migrate dev again and it should ignore all shadow tables, but instead it asks to create a new migration.

Hi @jackbravo , thanks for the detailed issue. I hope we can look into this very soon.

I think this is related to #1684 . At least for SQLite.

PS: We already have @@ignore : https://www.prisma.io/docs/reference/api-reference/prisma-schema-reference#ignore-1

I think it wouldn't help here, because @@ignore is about ignoring the model in the generated client, migrate will still treat the model like any other.


Use ACL to ensure /etc/keys is readable by nginx

When mounting things into /etc/keys like foo.crt and foo.key, ensure
that the nginx user is able to read these files. We were getting
permissions issues when mounting certs into these locations and nginx
being unable to read them.

Gah, this isn't working as expected :( Closing.


Ensure registration is successful with or without the @ symbol

users may or may not include the @ symbol in their message. We want the registration to be successful regardless of whether it is included

Done in #32.
def validate_signature(pubkey: str, signed_message: str, twitter_handle: str):
    for msg in [twitter_handle, f"@{twitter_handle}"]:
        if is_sig_valid(sig=signed_message, msg=msg, pub_key=pubkey):
            return
    raise TweetInvalidSignatureError("Invalid signature")


Create contactform-Html.md

Created Html form successfully

/hold

@shreyanshjain806 ,
I plan on closing this pull request.
To move forward with this PR, please sign the CLA.
/close


♻ Very safe transfer

Description
♻
Checklist
Ensure you completed all of the steps below before submitting your pull request:

[x] Ran forge fmt?
[x] Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@Philogy Help me double check this if you are free. My brain is only 10% now.


Fix button

The change darkmode button is working but the image is not found.

I can create a image for changing. @xanonDev please review this issue

maybe something like his

@wojtas3422 @xanonDev what do you guys think about this?

fix it?

what do u mean? @wojtas3422

i fix that @Jvr2022 check Is it working

@xanonDev since the new commits google says on my phone that its a dangerous site

that cybercriminals try to steal my data

but i know that it is not true

I saw this and i write revocation


Project Setup - Installing Dependices & MVC Structure

Todo

[x] Install Express and Set Up Server

Let me try

Let me try

please go ahead


Supports on embedded linux

Hi, thanks for the amazing tool. I am not sure if this is any bug, but I am wondering if XBERT can be used on a mpsoc embedded Linux system with the FPGA manager. In detail,  I used the hosted_tool to generate *.mdd and *.ll files and am able to update the full bitstream manually. The embedded piece is based on xilfpga and the wiki said the xilfpga is designed to run on standalone BSPs, so I am curious if I can modify the XBERT and use it in a Linux environment instead? Thanks

On Aug 17, 2021, at 1:23 AM, raindroid @.***> wrote:
Hi, thanks for the amazing tool. I am not sure if this is any bug, but I am wondering if XBERT can be used on a mpsoc embedded Linux system with the FPGA manager. In detail, I used the hosted_tool to generate *.mdd and *.ll files and am able to update the full bitstream manually. The embedded piece is based on xilfpga and the wiki https://urldefense.com/v3/__https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18841910/Xilfpga__;!!IBzWLUs!EkUDGPJ9H6_BnrssxeD-ARSISAiN4KgbqbnSq_cux1gZcsyEVq4FK_QLpo0gerVJMg$ said the xilfpga is designed to run on standalone BSPs, so I am curious if I can modify the XBERT and use it in a Linux environment instead? Thanks

Thanks for your interest.
We have been working with Linux this past summer, and have used XRT and OpenCL/Vitis interface (and, I believe, FPGA Manager which is under those things) to load partial bitstreams.
We have not found a way to read partial bitstreams (which would be necessary to get all the BERT features) using the Linux interface.
I don’t think we’ve automated a version of bert.c that runs on top of XRT (FPGA Manager), yet.
We are currently working out some (orthogonal, we think) issues that we ran into while working with Linux and DFX.
So, I think the answer is: we believe this is possible, and have some work on it, but it isn’t trivial, so it will take a bit longer.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/icgrp/bert/issues/7__;!!IBzWLUs!EkUDGPJ9H6_BnrssxeD-ARSISAiN4KgbqbnSq_cux1gZcsyEVq4FK_QLpo102HyyOQ$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AATPQWSJ6KSCN5ZKSYETR6TT5HW5RANCNFSM5CJCPUTA__;!!IBzWLUs!EkUDGPJ9H6_BnrssxeD-ARSISAiN4KgbqbnSq_cux1gZcsyEVq4FK_QLpo3kSJFrJw$.
Triage notifications on the go with GitHub Mobile for iOS https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!IBzWLUs!EkUDGPJ9H6_BnrssxeD-ARSISAiN4KgbqbnSq_cux1gZcsyEVq4FK_QLpo1uferPHw$ or Android https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email__;!!IBzWLUs!EkUDGPJ9H6_BnrssxeD-ARSISAiN4KgbqbnSq_cux1gZcsyEVq4FK_QLpo1Now3NQQ$.

For embedded linux, you can generate bitstreams on a host machine (all you need is the .dcp, .mdd and .ll). Then sideload them onto the MPSOC.
Then run fpgautil -b bert_bitstream.bit -f Partial to write to the BRAM.
You can not do any readback, but you can at least set up BRAM configurations with the bitstream_gen tool.


[Story] Develop the ETL pipeline for the EDAM ontology

What product(s) is this story for?
OpenChallenges
As a user, I want
No response
Description
The goal of this story is to update the existing openchallenges-edam-etl to effectively load the EDAM ontology into the OC Challenge Service DB.
Acceptance criteria

The command nx serve-detach openchallenges-edam-etl loads the data into the challenge service DB.
The file edam_concept.csv is removed from the challenge service codebase.

Tasks

[x] #2547
[ ] #2548

Anything else?
No response
Have you linked this story to a GitHub Project?

[X] I have linked this story to a GitHub Project and set its metadata.

Added to Sprint 24.4

Added to Backlog


Create Perfect.md

📝 Description
Add a brief description.
💣 Is this a breaking change (Yes/No):

[ ] Yes
[x] No

🚧 How to migrate?
Don't need.
📝 Additional Information
lol

Dear @Coding-Aryan , we found some issues in your AI Agent. 1, Please update the Prompt, for example: improve the following code: {{input}}. 2. Define the input variable. Enter input  as the key of variable and enter the code as value.


Fix broken reference to public_master

High Level Description
#1508 and #1528 conflicted but this case silently slipped by because it was a new usage of the variable being removed. This was not caught during testing as the code was not exercised until a specific setting was enabled in CI
Related Issues

https://jira.mesosphere.com/browse/DCOS_OSS-1125

Checklist for all PR's

[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: N/A Test Fix
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

@mesosphere-mergebot bump-ee


Avoid redundant Openflow messages when syncing an updated group to OVS

Fix #4159
This PR fix the issue by appending buckets directly in Done() in
pkg/ovs/openflow/ofctrl_group.go instead of calling AddBuckets method
of Group defined in the ofnet which sends an Openflow message to install
the group.
Signed-off-by: Hongliang Liu<EMAIL_ADDRESS>

/test-all

Since the original code causes great unnecessary overhead when used in large scale, I would suggest to backport the fix.

Since the original code causes great unnecessary overhead when used in large scale, I would suggest to backport the fix.

Yes, do we need to backport this to earlier versions? like the versions before v1.0? @tnqn

@hongliangl please backport to release 1.5 and later.

@hongliangl please backport to release 1.5 and later.

Done.


Allow sending an unprepared request via session.

This can be considered a request in the form of a PR because it was easier to make the code change than explain it.
I have multiple places where i am passing around method, url, json etc before it makes it to the requests level. Now these can all be bundled up into a single request object which is much easier to pass around, but then i have to manually call
prep = session.prepare_request(req)
settings = session.merge_environment_settings(....)
settings['timeout'] = timeout
session.send(prep, **settings)
Now it's not super hard, but it's something that happens by default doing request() and it's certainly not intuitive. If we add a send_request() which does exactly the same as request() just on an existing request object it makes it much easier to correctly use Request objects.
Note: If you like the idea but not the implementation and have something equivalent - please just do it your way. I don't care if this particular PR gets accepted or not if the idea gets up. I proposed this against 3.0 thinking it was going to be a more breaking change, but it seems pretty easy if you'd prefer i propose against master.
Thanks

PreparedRequests should be suitable for accomplishing what you're trying to accomplish.
I see where you're coming from, and thank you for your contribution. However, in short, no. :)
@sigmavirus24 & @Lukasa are welcome to add additional thoughts, if desired.

I once thought about this too. Then I realized that you're introducing yet another way of doing things when there already exist more than one way to do it. You can do:
#: 1
requests.get(...)
#: 2
requests.request('GET', ...)
#: 3
my_session.get(...)
#: 4
my_session.request('GET', ...)
#: 5
request = requests.Request(method='GET', ...)
prepared = my_session.prepare_request(request)
settings = my_session.merge_environment_settings(....)
# modify settings
my_session.send(prepared, **settings)

We really don't need yet another way of doing roughly the same thing. That's too much API surface area for very little extra benefit. If you're using the PreparedRequest flow, your proposal is only saving a tiny fraction of that workflow and diverging the typical code-paths further. Frankly, I don't think it's worth the extra surface area. In my experience, people who think the PreparedRequest flow is too complicated or kludgy, don't actually need it.


chore: remove some debug statements

Huly®: UTRP-306

This change is

why not delete them instead of just commenting them out?

This will be addressed by #383

you madmen


Classic VM Deployments

I see that this does not cover the Classic Deployment Model.  However, there is no link or reference to go to for resizing the OS disk of a Classic VM.  And I am not able to find it other than documentation to resize the entire VM - not just the OS disk

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ccc58c74-7913-f1f6-8681-1823bbd8f050
Version Independent ID: c11bab28-a82a-29a1-84bf-fb3dfb9a5cb2
Content: Expand the OS drive of a Windows VM in an Azure
Content Source: articles/virtual-machines/windows/expand-os-disk.md
Service: virtual-machines-windows
GitHub Login: @kirpasingh
Microsoft Alias: kirpas

@eulkloss Thanks for the feedback! We are currently investigating and will update you shortly.

@eulkloss You can try following this blog to see if it helps you in the resize:
https://blogs.msdn.microsoft.com/madan/2015/11/02/resizing-azure-vm-os-or-data-disk/
I am not aware of any official documentation on this anymore. @kirpasingh are you aware or can you add any links to this doc for others who might need it?

@squillace is this something you can help with? I see the authors are not eligible to be assigned. Seems like we might need to add some information to this doc about classic VMs as well. Or find the correct link to other official docs we can reference.

There are very few Classic VM docs remaining. The focus of the docs have been on Resource Manager deployments for the last 2-3 years.
What Classic deployment model docs there are start here - https://docs.microsoft.com/en-us/azure/virtual-machines/linux/overview?toc=%2Fazure%2Fvirtual-machines%2Flinux%2Fclassic%2Ftoc.json . There is no Classic equivalent of the resize doc.

Thanks @iainfoulds!
@eulkloss Please try the follow docs we suggested. From a content perspective we do not plan on adding any additional content for classic.
I will close this for now but if you have further to discuss please reopen and we can continue.

I would like to request the information that say, the data/OS disk for Classic Environment, it's Max size is up to 1TB or something like that.


Wording change

Codecov Report
Patch and project coverage have no change.

Comparison is base (beb6ad1) 53.36% compared to head (7ce6b13) 53.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   53.36%   53.36%
=======================================
  Files          29       29
  Lines       18331    18331
=======================================
  Hits         9783     9783
  Misses       8548     8548

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Rewrite client with Typescript

Current Situation
Currently IDOM's client is implemented in Vanilla JS. This makes it easy to develop and contribute to, but the code-base is growing in complexity, and without unit tests, there's some risk that it will become difficult to maintain.
Proposed Actions
Rewrite the client using typescript. Type annotations seem to be coming to browser Javascript engines soon so, like with Python, typed Javascript is likely to grow in popularity. Type annotations are not a replacement for unit tests, but they will help. It will also be a form of documentation that can be referred to by new contributors and users.

Should we switch to TS, or simply wait for JavaScript to support type hints?

I'm not really sure how it's going to pan out, but from my understanding, they're not re-inventing the wheel - the syntax is identical to TS so if we wrote in TS it should work as-is in the future.


newError func is not being generated for Blob Storage

Fixed in https://github.com/Azure/autorest.go/pull/304


Spyder Start Up Error

Hello last time I use spyder and it really help me a lot, thanks for the great works. However I didn't know why, spyder can not start even I call from start or terminal in Ubuntu. I figuring out the error and I found that this is because the lock file. So simply I go to spyder file and change line in start_app.py file and change spyder.lock to spider2.lock then it works well. But new problem coming that the console whether in terminal or IPython producing error cannot import name hashtable. It always appear when doing print function or program output. After that back to the original I change spider2.lock to spyder.lock it works but the error is still.
Here is the eror:

Anybody can help?
-Thank you-

I'm sorry but I don't what's causing this. How did you install Spyder?

Sorry for the late reply. I think this happen when I try jupyter notebook, then have an error about pandas in there. Then I close the jupyter and running spyder and have the error. Simply I just reinstall the Pandas and its works.


Installing lime fails

Using haxe-3.2.0-rc.2 linux 64 bits and its bundled haxelib installing lime fails.
$ haxelib install lime
Downloading lime-2,1,3.zip...
Download complete : 87961405 bytes in 18.9s (4539.1KB/s)
  Created project/
  Created project/common/
  Install project/common/Extension.cpp
  Install project/common/ExternalInterface.cpp
  Created project/include/
  Install project/include/Utils.h
  Install project/Build.xml
  Install Extension.hx
  Install haxelib.json
  Created dependencies/
  Created dependencies/android/
  Install dependencies/android/project.properties
  Install dependencies/android/build.xml
  Created dependencies/android/src/
  Created dependencies/android/src/org/
  Created dependencies/android/src/org/haxe/
  Created dependencies/android/src/org/haxe/extension/
  Install dependencies/android/src/org/haxe/extension/Extension.java
  Install dependencies/android/AndroidManifest.xml
  Install include.xml
  Current version is now 1.0.0
Done

and ends up like this:
$ haxelib list
unknown: [1.0.0]

Downloading the zip from the website and using haxelib local fails too,
the zip is correct and manually extracting it works.
I installed actuate, box2d, HaxePunk, hxcpp, layout, openfl-samples, openfl and swf without any problems.

Same here! On Mac OS 10.10 (Yosemite) x64.

I had the same issue because my lime directory was locked by my anti virus,
no error spawned...

This just happened to me as well. Is it because Lime includes a ".gitignore" file? Does it stop extracting when it hits a "." file, rather than skipping and continuing?

Nevermind, this was fixed after I ran haxelib selfupdate
I wish haxelib were able to update during a "haxelib upgrade" like other libraries ;)

I ran a selfupdate but it didn't fixed it.
haxelib:
#!/bin/sh
OLDCWD=`pwd`
cd /usr/lib/haxe/lib/haxelib_client/3,2,0-rc,2/src/
exec haxe -D haxelib_client=3.2.0-rc.2 --run tools.haxelib.Main -cwd $OLDCWD

but
Haxe Library Manager 3.2.0-rc.1 - (c)2006-2015 Haxe Foundation
Was the string not updated or did my selfupdate didn't succeed?

Actually, haxelib install lime failed like above, downloading manually from http://www.openfl.org/builds/lime and running haxelib local <name of zip> also failed. I ran haxelib selfupdate, then I used haxelib local again. I didn't actually test haxelib install again after the update

We should check this before release.

Following @jgranick's idea I tried removing all files starting with a "." from the lime zip and then doing a haxelib local, it fixes the error.

Fixed here (sorry, flipped the issue number): https://github.com/HaxeFoundation/haxelib/commit/68f25d97dc991516c02a2665081ba5cc0d2ae23e

Remind me to sync haxelib as soon as I start behaving like I'm about to package a Haxe release.

Will do.
On Sun, Mar 22, 2015 at 1:24 PM, Simon Krajewski<EMAIL_ADDRESS>wrote:

Remind me to sync haxelib as soon as I start behaving like I'm about to
package a Haxe release.
—
Reply to this email directly or view it on GitHub
https://github.com/HaxeFoundation/haxelib/issues/187#issuecomment-84597970
.

same as first post, but for version 2,3,3

Solved it.
Problem was haxelib selfupdate couldn't update as in https://github.com/HaxeFoundation/haxelib/issues/189
$chmod 777 /usr/bin/haxelib
$cp /usr/bin/haxelib ~/
$cd ~
$./haxelib selfupdate

and lime installed fine.


chore(#252): update reach dialog and config due to cli errors

Type of change

[ ] Content addition
[ ] Bug fix
[ ] Behavior change

Summary of change
Cleared the "DialogContent" error from the CLI by updating @reach/dialog and updating snowpack.config.js. The innerHTML error is generated from build in Snowpack and should be resolved once we migrate to Vite.
Before:

After:

Checklist

[x] This fix resolves #252
[x] The changes follow the contributing guidelines
[x] I have verified the fix works and introduces no further errors

Tagging issue #191 and WIP PR #192 - error to be resolved upon Vite migration


Add title property/Remove hard coded title

Thank you for this contribution !
I just added struct for customisation ! See :
https://github.com/terflogag/OpenSourceController/blob/master/README.md#customisation
For the verbose mode it's disable by default.


Disable Auto Open Github Repo Everytime machine starts

I am using pomatez version 1.2.2 and as it gets an updates.it will automatically open the GitHub repo where I can get an update for download. but i want to keep my current version and don't want to update to the latest version.is there any way where i can stop auto opening my browser every time i start my machine(pc)

It was never meant to open your browser every time vs just alert you, I think there was an issue with the previous version. The latest from the tests I've done when its released should no longer have that issue.

I believe this should be fixed, we also have a tauri version now that you can ignore updates until the next update comes out too :)


Fix typings

Updated the typings with ways which knex's API seems to allow for given our existing code. These were previously not covered by DefinitelyTyped

I reviewed it and made a few changes. It should work properly now.

Thanks!

You're welcome.


[Feature Request] Kysely playground VS Code extension

Hey, a phenomenal addition to the Kysely ecosystem would be a Kysely VS code extension with a playground to be able to preview Kysely queries or convert SQL to Kysely expressions.

Definitely! But that should be a 3rd party project and not part of the core.


feat(agent/token): describe new agent options + k8s -> Kubernetes

New options are for 0.3.0 (unreleased).

Can be merged when Agent 0.3.0 is released. Changing to draft until then.


Add support for upper and lower bounds on datetimes

Specifically, so I can do things like
select avg(end_date-start_date) from table

This is possible.  For scenarios like the above, though, adding a column like "duration" can often have better utility, since you can bound the sensitivity more tightly.  For example, the view exposed to SmartNoise could have a column that is computed as end_date - start_date, and the bounds could be set by the data curator to be reasonably tight based on domain expertise or some previous analysis on similar data that can provide a reasonable (e.g.) 1.5X IQR to remove outliers.

Yep, was planning to first-pass it with duration -- just trying to allow for more complicated things with datetimes than I might think of in advance (overall product is a wrapper around arbitrary queries)


Implement Kernel Preemptive Multitasking

Resources:

Brendan's Multi-Tasking Tutorial
Kernel Multitasking
Context Switching

We need to have a task structure. We can begin by adding things to this struct:
typedef struct px_task
{

} px_task_t;

From the OSDev Wiki

a field for the task's kernel stack top
a field for the task's virtual address space (e.g. the value for CR3 on 80x86 systems)
a generic "next task" field that can be used for multiple different linked lists of tasks later on
a "state" field (also to be used later)
It might also contain other/optional fields, like:
the scheduling policy of the task
the scheduling priority of the task
the ID of the process the task/thread belongs to
a "task name" string
the amount of CPU time the task has consumed so far


Causes npm install to fail

With this module included as a dev dependency, I get these errors:
npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t https://github.com/mwittig/license-checker.git
npm ERR!
npm ERR! fatal: Kein Git-Repository: /home/dev/Downloads/awesome-emoji-picker-1.1-src/emoji-mart-embed/../../../../.git/modules/src/popup/lib/awesome-emoji-emoji-mart-embed
npm ERR!
npm ERR! exited with error code: 128

or
$ npm install
npm ERR! code ENOLOCAL
npm ERR! Could not install from "node_modules/npm-license-crawler/license-checker@git+https:/github.com/mwittig/license-checker.git#d546e3f738e14c62e732346fa355162d46700893" as it does not contain a package.json file.

For a full issue description, see https://github.com/rugk/emoji-mart-embed/issues/4, potential solution: https://github.com/mwittig/npm-license-crawler/issues/39

@rugk Which version of node.js are using?

v10.16.3

BTW "Kein Git-Repository:" means "No git repository:". And then there is this strange path with useless ..'s

Any news? @mwittig
Note this is the same issue as https://github.com/mwittig/npm-license-crawler/issues/39

ping?

Any news or updates? Is there a workaround? @rugk @mwittig

A workaround is to remove this module from your dev dependencies (in  packages.json) and install it manually, only if needed.

I just had a similar problem when git was not installed in a docker container.
The cause was that the dependency to the licence-checker is a git link:

The solution was to install git in the container

Solved! Installed git, opened GIT CMD and navigated to my project by cd command. Then run the command of installing it. Simple cmd was not able to install this git based library. My path wasn't set too. Maybe that's the reason I was getting this error.


Getting syncdbAfterWrite working

What is the change?
This PR modifies Database3.syncToSharedFolder so that it closes the h5py.File before trying to copy the h5 file to the working directory. The full process is:

Call h5py.File.close() and set the object to None.
Copy the h5py file to the working directory.
Garbage collect to avoid multiple database instances in memory.
Reload the h5 file in append mode

Tests were also added to ensure the syncDbAfterWrite setting behaves as expected.
Why is the change being made?
Partial resolution to #1794
Previously, setting syncDbAfterWrite caused a PermissionError due to the h5 file not being closed before trying to copy it.

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify any new/changed code.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[x] The release notes have been updated if necessary.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in pyproject.toml.

@zachmprince Remind me, did we run those downstream tests successfully?  Last I heard, you sounded convinced, but were worried about some unrelated errors?  How are you feeling now?

@zachmprince Remind me, did we run those downstream tests successfully? Last I heard, you sounded convinced, but were worried about some unrelated errors? How are you feeling now?

I am confident these changes are not affecting downstream applications. Test failure I ran into is unrelated. If you are okay merging it, please do! It's all okay on my side.


Package git-bubbles in a nix derivation

As suggested in private by @immae, I should instead use a wrapper instead of fixuping the script.

As suggested in private by @immae, I should instead use a wrapper instead of fixuping the script.

For notes: I have this following overlay working:
self: super:

let fetchPackage = owner: repo: path: rev: sha256:
      self.callPackage (self.fetchFromGitHub { inherit owner repo rev sha256; } + path) {};
in {
     personal = {
        git-bubbles = fetchPackage "ptitfred" "posix-toolbox" "/nix/default.nix"
         "3f0cbc19ec36a0bc51031bc7d085bc826a159639" "1cs902sasc7d91gsl2xn0xyjkkka9hqwiz0icnjbssgvgjw8kxp3";
     };
   }

(pointing at this PR obviously for now)

For notes: I have this following overlay working:
self: super:

let fetchPackage = owner: repo: path: rev: sha256:
      self.callPackage (self.fetchFromGitHub { inherit owner repo rev sha256; } + path) {};
in {
     personal = {
        git-bubbles = fetchPackage "ptitfred" "posix-toolbox" "/nix/default.nix"
         "3f0cbc19ec36a0bc51031bc7d085bc826a159639" "1cs902sasc7d91gsl2xn0xyjkkka9hqwiz0icnjbssgvgjw8kxp3";
     };
   }

(pointing at this PR obviously for now)

For notes: I have this following overlay working:
self: super:

let fetchPackage = owner: repo: path: rev: sha256:
      self.callPackage (self.fetchFromGitHub { inherit owner repo rev sha256; } + path) {};
in {
     personal = {
        git-bubbles = fetchPackage "ptitfred" "posix-toolbox" "/nix/default.nix"
         "3f0cbc19ec36a0bc51031bc7d085bc826a159639" "1cs902sasc7d91gsl2xn0xyjkkka9hqwiz0icnjbssgvgjw8kxp3";
     };
   }

(pointing at this PR obviously for now)
This is not very satisfying. I should rewrite this PR to produce a dict of the various scripts I would package at some point.

you probably want the release.nix rather than the default.nix. Or even better to follow usual conventions you should rename release.nix to default.nix and release.nix to default.nix

For notes: I have this following overlay working:
self: super:

let fetchPackage = owner: repo: path: rev: sha256:
      self.callPackage (self.fetchFromGitHub { inherit owner repo rev sha256; } + path) {};
in {
     personal = {
        git-bubbles = fetchPackage "ptitfred" "posix-toolbox" "/nix/default.nix"
         "3f0cbc19ec36a0bc51031bc7d085bc826a159639" "1cs902sasc7d91gsl2xn0xyjkkka9hqwiz0icnjbssgvgjw8kxp3";
     };
   }

(pointing at this PR obviously for now)
This is not very satisfying. I should rewrite this PR to produce a dict of the various scripts I would package at some point.

you probably want the release.nix rather than the default.nix. Or even better to follow usual conventions you should rename release.nix to default.nix and release.nix to default.nix

Or even better to follow usual conventions you should rename release.nix to default.nix and release.nix to default.nix

I've done that.

Or even better to follow usual conventions you should rename release.nix to default.nix and release.nix to default.nix

I've done that.

As suggested in private by @immae, I should instead use a wrapper instead of fixuping the script.

This is done as well. I'm quite happy with the result ^^ !

As suggested in private by @immae, I should instead use a wrapper instead of fixuping the script.

This is done as well. I'm quite happy with the result ^^ !

As suggested in private by @immae, I should instead use a wrapper instead of fixuping the script.

This is done as well. I'm quite happy with the result ^^ !

It looks good to me too :)

As suggested in private by @immae, I should instead use a wrapper instead of fixuping the script.

This is done as well. I'm quite happy with the result ^^ !

It looks good to me too :)


Question: tsdoc for function type declaration

export type OnEnter = (success: boolean) => void;
export interface OnLeave {
  (success: boolean): void
}

How should we reasonably add the type declaration of the above function type 'OnEnter' and 'OnLeave' ?
I tried as follows:

Good question!
I would document it like this:
/**
 * A callback that occurs after the control receives focus.
 * @param success - true if successful
 */
export type OnEnter = (success: boolean) => void;

/**
 * A callback that occurs after the control receives focus.
 */
export interface OnLeave {
  /**
   * The call signature for `OnLeave`.
   * @param success - true if successful
   */
  (success: boolean): void
}

The TSDoc design focuses mainly on how comments get parsed.  The spec will give better guidance about /where/ comments should go (but this is guidance for implementors; it doesn't affect the parser library at all).
You could consider API Extractor to be a functionally complete reference implementation of a TSDoc application.  API Extractor distinguishes specific syntax elements as being "API items" (see ApiItem.ts and AstDeclaration.ts).  These are the things that get their own entry on the documentation website.  For OnEnter it would be the ts.SyntaxKind.TypeAliasDeclaration declaration.  For OnLeave it would be the ts.SyntaxKind.CallSignature.
Some additional thoughts:

API Extractor doesn't implement the @param tag for a type.  Probably we should support it.
It could be ambiguous, though.  For example:   // here there are two different parameters called "success"
   export type OnEnter = ((success: boolean) => void)
     | ((success: ISuccessCode, details: string) => void);

How is the documentation website supposed to represent this?  I think we would ask to split it into two declarations, or else to rename the parameters to success and success2.
The interface-with-a-call-signature form is very rarely used, only in cases where the interface would have other members (e.g. due to a merged declaration that describes a legacy JavaScript API.)  The type representation is generally the best practice.

/**
 * A callback that occurs after the control receives focus.
 */
export type OnEnter =
  /**
   * The call signature for `OnEnter`.
   * @param success - true if successful
   */
  & ((success: boolean) => void)
  /**
   * The call signature for `OnEnter`.
   * @param message - success message
   */
  & ((message: string) => void)

/**
 * A callback that occurs after the control receives focus.
 */
export interface OnLeave {
  /**
   * The call signature for `OnLeave`.
   * @param success - true if successful
   */
  (success: boolean): void
  /**
   * The call signature for `OnLeave`.
   * @param message - success message
   */
  (message: string): void
}

I think this can better represent overloading.

It could be ambiguous, though.

// here there are two different parameters called "success"
   export type OnEnter = ((success: boolean) => void)
     | ((success: ISuccessCode, details: string) => void);

In typescript, we generally use the intersection type of the functions to represent overloading.
If tsdoc correctly parses the following notation, then it has the same ability to write doc as interface-with-a-call-signature.
/**
 * A callback that occurs after the control receives focus.
 */
export type OnEnter =
  /**
   *
   * @param success - true if successful
   */
  & ((success: boolean) => void)
  /**
   *
   * @param success - success code
   * @param details - the details
   */
  & ((success: ISuccessCode, details: string) => void);

This design has a problem:  it introduces the possibility that /** */ comment can appear anywhere in an expression.  For example, should this be valid?
/**
 * A callback that occurs after the control receives focus.
 */
export type OnEnter =
  &
  /**
   * the first overload
   */
  (
    (
      /**
       * @param success - true if successful
       */
      success: boolean
    ) => /** The return value */ void
  )
  & (
   /**
    * The second overload
    * @param success - success code
    * @param details - the details
    */
    (
      success: ISuccessCode,
      details: Set</** this value must not be empty */ string>
    ) => void
  );

If not, which parts of an expression are allowed to have doc comments?  We would need to make rules about where a comment can go, and I suspect those rules would be fairly complicated.  It might be difficult for a user to understand /why/ a comment is allowed in one place, but not in another place.  A goal of TSDoc is that the notation should be easy to learn from looking at examples, without having to consult a manual.  And its interpretation should be easy to predict, without needing to run it through a parser/renderer.
There's also a question of how a documentation engine is supposed to present these comments.  Documentation templates tend to be based on stereotypes ("functions", "interfaces", "classes", etc.)  Free-form type algebra expressions are challenging to document, at least if you want great documentation that looks professional.

Bump. JSDoc has @callback for this purpose.
Currently the best approach for TSDoc seems to be callable signature (the interface example above).
You can experience it in the playground example, click here (read comments at the bottom for instructions).

Bump. Still looking for a good solution, too. I currently use a workaround like below, but i'm not really happy with the type unawareness inside the handler function:
type SuccessCode = 200 | 201;

/**
 * A callback that occurs after the control receives focus.
 * @param success true if successful
 */
declare function OnEnterFn(success: boolean): void;

/**
 * A callback that occurs after the control receives focus, contains details.
 * @param success success code
 * @param details the details
 */
declare function OnEnterFn(success: SuccessCode, details: string): void;

/**
 * Type description when hovering over OnEnter.
 */
export type OnEnter = typeof OnEnterFn;

const handler: OnEnter = (success: boolean | SuccessCode, details?: string | undefined) => {
	if (typeof success === "boolean") {
		console.log("overload 1", success);
	} else {
		console.log("overload 2", success, details);
	}
};

const foo = (onEnter: OnEnter) => {
	onEnter(true);
};

const bar = (onEnter: OnEnter) => {
	onEnter(201, "more details");
};

foo(handler);
bar(handler);


Improve analysis performance by removing bubble sort

Hi! I'm looking into performance bottlenecks in Ghidra and decided to pick up some easy low-hanging fruit that I came across. This change removes the bubble sort base case from Algorithms#doMergeSort. It came up when I profiled Ghidra when analyzing a moderately-sized binary, since it's used to update the function list by keeping it sorted. This change speeds up the sort by about 30x on a list of about 500k functions.
I had originally thought that this would be a nice but minor benefit but in my tests this also speeds up certain phases of analysis by about 30-50%, apparently because the sort takes a lock on the database which the analysis would also contends on. So hopefully it's a win all around?
I'm new to this part of the codebase, so please do check that I didn't actually break something important with this change :P I'm always concerned when making changes like these for the first time because it's hard to know the context for why it was added. Hopefully the comment I've written is accurate. Also, I added a commit to remove the bubble sort entirely because I couldn't find any reason for it to stick around; feel free to request it be dropped if you're not comfortable with that change.

We'd like to verify the results you have presented.  Will you provide more details on the type of binary you used for testing, along with the particular analyzers you were running?

apparently because the sort takes a lock on the database which the analysis would also contends on.

This will be true for either of the sort algorithms used by the table.   Further, the tables will cache lookups while sorting in order to prevent excessive db access.

it's hard to know the context for why it was added.

In this case, I believe the purpose of the bubble sort was to provide faster sorting for small datasets, hence the check for a size of less than 7.

Took me way too long to figure out the unit test rig syntax.
gradle :Generic:test --tests AlgorithmsTest -x sleighCompile -x buildHelp

While we did not verify the performance changes, we do not see the need to use the bubble sort in this fashion.
This code is very old.   Perhaps there was a time in history, on certain architectures, where this was an improvement to the overall algorithm.  Or, perhaps this was just an Easter Egg left by a previous developer.

I feel like there would be a way to monitor sorting progress in the collections framework if it was really necessary. Maybe it's worth looking into whether or not it is necessary and just eliminating this all together if it's not. I would expect the algorithms provided by java to be far better than anything someone else could hope to implement unless you have some extremely specific use case.

. I would expect the algorithms provided by java to be far better than anything someone else could hope to implement unless you have some extremely specific use case.

We are currently looking into this.

@saagarjha Thank you for the work you put into this PR.  While we did not use this code directly, it helped us find a way to remove the custom algorithm entirely.

Looks good from my quick tests :)


Formatter should avoid line breaking after new

Source:
main() {
  throw new FormatException("This is a long exception message that puts this over 80 columns.");
}
Output:
main() {
  throw new
      FormatException("This is a long exception message that puts this over 80 columns.");
}
This has two problems:

Breaking after "new" is unsightly.
It didn't choose a breakpoint that actually fit the statement into 80 columns. It's still too long.

Expected:
main() {
  throw new FormatException(
      "This is a long exception message that puts this over 80 columns.");
}

This issue has been moved to dart-lang/dart_style#305.


Restore binops test, fix wallet fixtures across core projects

What current issue(s) from Github does this address?
n/a
What problem does this PR solve?
build failure
How did you solve this problem?
resolve wallet fixtures from neo-python source
How did you make sure your solution works?
created a duplicate setup under own organisation/account to validate it
Are there any special changes in the code that we should be aware of?
no
Is there anything else we should know?
no

🎉 Thanks!


Add forecast-type flag to readme

Codecov Report

Merging #15 (4399c81) into main (0beca6a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines          432       432
=========================================
  Hits           432       432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0beca6a...4399c81. Read the comment docs.


Priority is a UDA

As of TW 2.4.3, apparently Priority is a UDA, meaning it can be redefined.  So, we shouldn't be using an enum for it.

Fixed in https://github.com/taskchampion/taskchampion/pull/350


Godot randomly freezes when using triplanar UVs in material

Godot version
v4.0.beta14.official.28a24639c
System information
Windows10, Vulkan, RX5700XT, latest drivers(31.0.12029.10015)
Issue description
Whenver I use triplanar UVs in a material godot either freezes istantaneously or takes some time to freeze.
In either case it freezes after showing this message in the console:(sometimes it spams a bunch of them)
ERROR: Condition "err" is true. Returning: ERR_CANT_CREATE
at: swap_buffers (drivers/vulkan/vulkan_context.cpp:2299)
I tried my project on a macbook pro M1 and it never freezes.
I also tried it on my brother PC, which also has a RX5700xt and has the exact same issue. Sadly I could not try with a Nvidia graphics card.
Steps to reproduce
Open the MRP(better with console to eventually kill the window if it freezes) and stay in the godot 3D view in the main scene.
Godot might freeze istantaneously, usually resulting in a graphics drivers crash, requiring a reboot of the OS.
In the best case, Godot will simply hang forever and you have to kill it by closing the console.
I tried with no other windows open except for godot and the crash still happens
Minimal reproduction project
TriplanarUVCrash.zip

This is likely a driver bug caused by an infinite loop in the shader (or similar).

I tried on 3.5.1 but the crash never happens there

This sounds like it may be a duplicate of #69156 which will be fixed by #71581
Could you confirm whether #71581 fixes this issue as well?

Thanks clayjohn. I compiled godot on #71581 with your fix and tried working with triplanar materials but sadly it did not solve the issue.
I guess it might really be a driver issue like calinou pointed out since no one else reported similar crashes with triplanar materials.

Tested the example and no crash so far. Using AMD Radeon RX 480.

I also can't reproduce the crash on Windows 10 RX 6900 XT.
Is anything printed to the console when it freezes/crashes?

Nope. Other than what I wrote in the issue description there is nothing more.
Here is a capture of the screen and the console.

I'm using triplanar UV's in another project and it's freezing randomly too. I guess is the same problem.
This is the project: https://github.com/rbarongr/GodotFirstPersonController
Using:

v4.0.beta17.official [c40020513]
Vulkan API 1.3.217 - Using Vulkan Device #0: AMD - AMD Radeon RX 5600 XT

Can you reproduce this in any of the 4.0 betas to determine when the regression started?

beta15 - no crash
beta16 - starts crashing
Seems to me that this issue might be caused by https://github.com/godotengine/godot/pull/71581 since that is the only pull request that touched general texture/render pipeline handling in any generalized way.

I am skeptical that #71581 caused this issue as the original report was from beta 14 and the user says they have been facing the crash since the early alphas. Needless to say, the bug has been around  long before #71581 was merged

After extensive testing it turns out that beta 15 crashes completely unpredictably as well. Not sure about which version this problem started on, seems to be persistent for most of the betas...

It would be nice if someone who has the issue tried to go back to beta 1 to see if it happens on it. (I fully understand that the testing will take some time)

Alpha 5 - No Crash so far.
Alpha 10 - Crashed after 40 minutes.
Alpha 11 - Crashed twice, but seems like these older versions took longer for it to happen for some reason? Still the same error however. Could be a fluke.
These versions also Crashed multiple times:
Alpha 12, Beta 1, Beta 3, Beta 4, Beta 7, Beta 15
These versions crashed within the first 10 minutes, again, could just a fluke too.
The problem is that the error is random and inconsistent. Sometimes it crashes as soon as I press play, sometimes it takes several minutes. AFAIK Alpha 5 COULD have the issue too and it just didn't crashed because of its random nature?
It will be hard to pinpoint until we find a way to trigger the error consistently. But I'll keep testing it in the meantime.
Btw all of the crashes gave the same error mentioned by the op.

Update: After some testing, both Alpha 5, and Alpha 1 crashed too with the same error + driver timeout. Had to run the game for about an hour on each.

It may be worth using Shader Playground, reconstructing the triplanar sampling shader code from scene/resources/material.cpp then looking at the generated assembly using those options:

gfx1010, gfx1011 and gfx1012 are internal names for RDNA1 GPUs. For example, gfx1012 is a RX 5500 XT – I believe lower numbers are higher-end variants.

Problem seems to be gone in 4.1 dev 2

Problem seems to be gone in 4.1 dev 2

Tested for about 90 minutes here, no crashes yet.


Model verification with optional message fields

Model verification fails if a message defines optional fields that are referenced in a subsequent expression.
The following example yields:
test.rflx:28:67: model: error: undefined variable "Pad_Length"
test.rflx:28:67: model: info: on path Payload_Length -> Frame_Type -> Flag_Padded -> Data -> Padding
test.rflx:28:67: model: error: undefined variable "Pad_Length"
test.rflx:28:67: model: info: on path Payload_Length -> Frame_Type -> Data -> Padding

Pad_Length is optional, that means it only is part of the message if Frame_Type = DATA and Flag_Padded = True.
The Path Payload_Length -> Frame_Type -> Flag_Padded -> Data -> Padding cannot be a valid Path as Flag_Padded = True implies the occurrence of Pad_Length and Padded. A Path where Pad_Length is absent but Padding is present cannot exist.
package Test is

   type Frame_Type is (
      DATA => 0,
      HEADERS => 1
   ) with Size => 8;

   type Payload_Length is mod 2**8;
   type Pad_Length is mod 2**8;

   type Message is
      message
         Payload_Length : Payload_Length;
         Frame_Type : Frame_Type
            then Flag_Padded
               if Frame_Type = DATA
            then Data
               with Size => Payload_Length * 8
               if Frame_Type = HEADERS;
         Flag_Padded : Boolean
            then Pad_Length
               if Flag_Padded = True
            then Data
               with Size => Payload_Length * 8
               if Flag_Padded = False;
         Pad_Length : Pad_Length
            then Data with Size => (Payload_Length - Pad_Length) * 8;
         Data : Opaque
            then Padding with Size => Pad_Length * 8
               if Flag_Padded = True
            then null;
         Padding : Opaque;
   end message;

end Test;

There seems to be an error in your specification. Flag_Padded should be unconditionally present on every path. Otherwise it is not possible to check Flag_Padded = True at the outgoing edge of Data.
I guess the following specification shows the actual problem (please correct me if I'm wrong):
package Test is

   type T is mod 2**8;

   type M is
      message
         Flag : T
            then Opt1
               if Flag = 1
            then Data
               if Flag /= 1;
         Opt1 : T;
         Data : Opaque
            with Size => 8
            then Opt2
               if Flag = 1
            then null
               if Flag /= 1;
         Opt2 : Opaque
            with Size => Opt1 * 8;
      end message;

test.rflx:20:26: model: error: undefined variable "Opt1"
test.rflx:20:26: model: info: on path Flag -> Data -> Opt2

The type checking of expressions is done on every possible path without considering any condition, even if the path cannot occur in practice (e.g., Opt1 and Opt2 have the same condition and cannot exist separately). The issue can be solved by filtering out all impossible paths before type checking.


Configurable nodes bootstrap timeout

Add support for configure DevSettings.Timeouts.HeadNodeBootstrapTimeout and ComputeNodeBootstrapTimeout.
Signed-off-by: chenwany<EMAIL_ADDRESS>Description of changes

Describe what you're changing and why you're doing these changes.
Link to impacted open issues.

Tests

Describe the automated and/or manual tests executed to validate the patch.
Describe the added/modified tests.

References

Link to related PRs in other packages (i.e. cookbook, node).
Link to documentation useful to understand the changes.

Checklist

[ ] Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
[ ] Check all commits' messages are clear, describing what and why vs how.
[ ] Make sure to have added unit tests or integration tests to cover the new/modified code.
[ ] Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Can we add unit test for the new settings? What about an integration tests?

Added unit tests for headnode bootstrap timeout and integration test for compute node bootstrap timeout


JetBrains: Too Many Notifications Upon Startup After Install

After installing for the first time, Cody creates many notifications (see screenshot). I'm guessing it's 1 per project that I have open.
Cody: 6.0.3
IntelliJ IDEA 2024.1.4 (Ultimate Edition)
Build #IU-241.18034.62, built on June 20, 2024
Runtime version: 17.0.11+1-b1207.24 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 14.5
Memory: 2048M

Oops, didn't realize the JetBrains plugin is a different repo, moved issue to https://github.com/sourcegraph/jetbrains/issues/1833