connect() promise does not resolve sometimes

I'm trying to start implementing something akin to an SFU. In my setup, my nodeJS backend starts a simple-peer instance and announces itself as the only node to each client.
However, when I do this, I see that the client's connect() promises never resolve.
I tracked this down to the following line: https://github.com/t-mullen/simple-signal/blob/19f4226ed5d3dffdef99ba2dfc3c503bfe90d700/client/src/index.js#L70
For some reason, the problem seems to be that metadata is null when I have a wrtc peer which in turn never allows connect to resolve.
https://github.com/t-mullen/simple-signal/blob/19f4226ed5d3dffdef99ba2dfc3c503bfe90d700/client/src/index.js#L99-L101
I have also confirmed that the connection itself has been established successfully as I can call signalClient.peers()[0].send('hello') and have the nodeJS simple-peer instance receive it. In other words, the problem seems to be that connect() only resolves if there is metadata available even though this isn't a hard-requirement for actual connection establishment.

Are you explicitly passing null to the metadata arguments for accept or connect on either side?

Yup! It looks like that's what's causing this.
However, I still think this is a valid issue. The question being whether the connect() promise should resolve only if metadata is available.
Since I don't really know/care about what metadata is supposed to contain, I was passing null on both sides.
const { peer } = await signalClient.connect(peerID, null, {
  offerOptions: {
    offerToReceiveAudio: true,
    offerToReceiveVideo: true
  },
  answerOptions: {
    offerToReceiveAudio: true,
    offerToReceiveVideo: true
  },
  trickle: false,
  wrtc
})

I guess my issue is with the call signature. In cases where metadata is not important, I can call the function with either undefined or {}, but not null; which doesn't feel natural to me.

You're right, the check on line 70 should be metadata === undefined instead of a falsely check.

Passing null as metadata and discoveryData is fine in v2.1.0.


Fix intermediate commit for arangosearch links and inverted index (#1…

(cherry picked from commit 32e3bb12f35bc6e027b1a553b0d3b6a842eec962)
Scope & Purpose
(Please describe the changes in this PR for reviewers, motivation, rationale - mandatory)

[ ] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.10: (Please link PR)
[ ] Backport for 3.9: (Please link PR)
[ ] Backport for 3.8: (Please link PR)

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

https://jenkins01.arangodb.biz/job/arangodb-matrix-pr/26028/


[BUG]: Exact title search does not return results

Describe the bug
When I search for a specific paper by the title, it does not return any results; however, when I search for the same paper by the doi, it returns the exact paper.
To Reproduce
Search:
REAL-TIME MECHANISTIC BAYESIAN FORECASTS OF COVID-19 MORTALITY, no results are found.
Then search by the paper doi: 10.1101/2<IP_ADDRESS>48736, it finds the paper with the exact title that we initially searched
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Additional context
Add any other context about the problem here.

This issue appears to have been resolved at some point in the last week with another fix - closing off


trying to reduce cognitive complexity

What this PR does / why we need it:
trying to reduce the cognitive complexity of the code
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

/hold


Add support for --nodeport-addresses

https://kubernetes.io/docs/concepts/services-networking/service/#nodeport:

If you want to specify particular IP(s) to proxy the port, you can set the --nodeport-addresses flag in kube-proxy to particular IP block(s); this is supported since Kubernetes v1.10. This flag takes a comma-delimited list of IP blocks (e.g. <IP_ADDRESS>/8, <IP_ADDRESS>/25) to specify IP address ranges that kube-proxy should consider as local to this node.
For example, if you start kube-proxy with the --nodeport-addresses=<IP_ADDRESS>/8 flag, kube-proxy only selects the loopback interface for NodePort Services. The default for --nodeport-addresses is an empty list. This means that kube-proxy should consider all available network interfaces for NodePort. (That's also compatible with earlier Kubernetes releases).

Also, the flag could be used to extend the kube-proxy replacement device detection.

The flag is now part of the NodeAddress selection (pkg/datapath/tables/node_address.go). We're still missing the helm values.yaml for it and an e2e test, but once those are done this can be closed.


Error in global_average_pooling2d while finetuning facenet in keras

I am trying to finetune facenet_keras by following the link Fine-tune InceptionV3 on a new set of classes.
I am getting an error on the line where I get the last layer of a base model and add a global spatial average pooling layer. I am not sure but maybe the error seems to be with the input to the GlobalAveragePooling2D() layer.
How do I reshape the output layer to fit in GlobalAveragePooling2D() layer.
The last layers look like:
Dropout (Dropout)               (None, 1792)         0           AvgPool[0][0]
__________________________________________________________________________________________________
Bottleneck (Dense)              (None, 128)          229376      Dropout[0][0]
__________________________________________________________________________________________________
Bottleneck_BatchNorm (BatchNorm (None, 128)          384         Bottleneck[0][0]

The error is:
ValueError                                Traceback (most recent call last)
<ipython-input-24-4a1c01c5761e> in <module>()
      4
      5 x = base_model.output
----> 6 x = GlobalAveragePooling2D()(x)
      7 x = Dense(256, activation='relu')(x)
      8 predictions = Dense(12, activation='softmax')(x)

/usr/local/lib/python3.6/dist-packages/keras/engine/topology.py in __call__(self, inputs, **kwargs)
    573                 # Raise exceptions in case the input is not compatible
    574                 # with the input_spec specified in the layer constructor.
--> 575                 self.assert_input_compatibility(inputs)
    576
    577                 # Collect input shapes to build layer.

/usr/local/lib/python3.6/dist-packages/keras/engine/topology.py in assert_input_compatibility(self, inputs)
    472                                      self.name + ': expected ndim=' +
    473                                      str(spec.ndim) + ', found ndim=' +
--> 474                                      str(K.ndim(x)))
    475             if spec.max_ndim is not None:
    476                 ndim = K.ndim(x)

ValueError: Input 0 is incompatible with layer global_average_pooling2d_2: expected ndim=4, found ndim=2

Here is the code:
train_data_path = 'dataset_cfps/train'
validation_data_path = 'dataset_cfps/validation'
test_data_path = 'test'
#Parametres
img_width, img_height = 200, 200

# path to the model weights files.
weights_path = 'keras-facenet/weights/facenet_keras_weights.h5'
top_model_weights_path = 'keras-facenet/model/facenet_keras.h5'

base_model = load_model(top_model_weights_path)

base_model.summary()

x = base_model.output

x = GlobalAveragePooling2D()(x)

x = Dense(256, activation='relu')(x)

predictions = Dense(12, activation='softmax')(x)

model = Model(inputs=base_model.input, outputs=predictions)

for layer in base_model.layers:

    layer.trainable = False

There doesn't seem a 'mixed10' layer. I took  the 'Block17_8_ScaleSum' layer
__________________________________________________________________________________________________
Layer (type)                    Output Shape         Param #     Connected to
==================================================================================================
input_1 (InputLayer)            (None, 160, 160, 3)  0
__________________________________________________________________________________________________
Conv2d_1a_3x3 (Conv2D)          (None, 79, 79, 32)   864         input_1[0][0]
__________________________________________________________________________________________________
Conv2d_1a_3x3_BatchNorm (BatchN (None, 79, 79, 32)   96          Conv2d_1a_3x3[0][0]
__________________________________________________________________________________________________
Conv2d_1a_3x3_Activation (Activ (None, 79, 79, 32)   0           Conv2d_1a_3x3_BatchNorm[0][0]
__________________________________________________________________________________________________
Conv2d_2a_3x3 (Conv2D)          (None, 77, 77, 32)   9216        Conv2d_1a_3x3_Activation[0][0]
__________________________________________________________________________________________________
Conv2d_2a_3x3_BatchNorm (BatchN (None, 77, 77, 32)   96          Conv2d_2a_3x3[0][0]
__________________________________________________________________________________________________
Conv2d_2a_3x3_Activation (Activ (None, 77, 77, 32)   0           Conv2d_2a_3x3_BatchNorm[0][0]
__________________________________________________________________________________________________
Conv2d_2b_3x3 (Conv2D)          (None, 77, 77, 64)   18432       Conv2d_2a_3x3_Activation[0][0]
__________________________________________________________________________________________________
Conv2d_2b_3x3_BatchNorm (BatchN (None, 77, 77, 64)   192         Conv2d_2b_3x3[0][0]

.
.
.
.

Block8_6_Branch_1_Conv2d_0a_1x1 (None, 3, 3, 192)    344064      Block8_5_Activation[0][0]
__________________________________________________________________________________________________
Block8_6_Branch_1_Conv2d_0a_1x1 (None, 3, 3, 192)    576         Block8_6_Branch_1_Conv2d_0a_1x1[0
__________________________________________________________________________________________________
Block8_6_Branch_1_Conv2d_0a_1x1 (None, 3, 3, 192)    0           Block8_6_Branch_1_Conv2d_0a_1x1_B
__________________________________________________________________________________________________
Block8_6_Branch_1_Conv2d_0b_1x3 (None, 3, 3, 192)    110592      Block8_6_Branch_1_Conv2d_0a_1x1_A
__________________________________________________________________________________________________
Block8_6_Branch_1_Conv2d_0b_1x3 (None, 3, 3, 192)    576         Block8_6_Branch_1_Conv2d_0b_1x3[0
__________________________________________________________________________________________________
Block8_6_Branch_1_Conv2d_0b_1x3 (None, 3, 3, 192)    0           Block8_6_Branch_1_Conv2d_0b_1x3_B
__________________________________________________________________________________________________
Block8_6_Branch_0_Conv2d_1x1 (C (None, 3, 3, 192)    344064      Block8_5_Activation[0][0]
__________________________________________________________________________________________________
Block8_6_Branch_1_Conv2d_0c_3x1 (None, 3, 3, 192)    110592      Block8_6_Branch_1_Conv2d_0b_1x3_A
__________________________________________________________________________________________________
Block8_6_Branch_0_Conv2d_1x1_Ba (None, 3, 3, 192)    576         Block8_6_Branch_0_Conv2d_1x1[0][0
__________________________________________________________________________________________________
Block8_6_Branch_1_Conv2d_0c_3x1 (None, 3, 3, 192)    576         Block8_6_Branch_1_Conv2d_0c_3x1[0
__________________________________________________________________________________________________
Block8_6_Branch_0_Conv2d_1x1_Ac (None, 3, 3, 192)    0           Block8_6_Branch_0_Conv2d_1x1_Batc
__________________________________________________________________________________________________
Block8_6_Branch_1_Conv2d_0c_3x1 (None, 3, 3, 192)    0           Block8_6_Branch_1_Conv2d_0c_3x1_B
__________________________________________________________________________________________________
Block8_6_Concatenate (Concatena (None, 3, 3, 384)    0           Block8_6_Branch_0_Conv2d_1x1_Acti
                                                                 Block8_6_Branch_1_Conv2d_0c_3x1_A
__________________________________________________________________________________________________
Block8_6_Conv2d_1x1 (Conv2D)    (None, 3, 3, 1792)   689920      Block8_6_Concatenate[0][0]
__________________________________________________________________________________________________
Block8_6_ScaleSum (Lambda)      (None, 3, 3, 1792)   0           Block8_5_Activation[0][0]
                                                                 Block8_6_Conv2d_1x1[0][0]
__________________________________________________________________________________________________
AvgPool (GlobalAveragePooling2D (None, 1792)         0           Block8_6_ScaleSum[0][0]
__________________________________________________________________________________________________
Dropout (Dropout)               (None, 1792)         0           AvgPool[0][0]
__________________________________________________________________________________________________
Bottleneck (Dense)              (None, 128)          229376      Dropout[0][0]
__________________________________________________________________________________________________
Bottleneck_BatchNorm (BatchNorm (None, 128)          384         Bottleneck[0][0]
==================================================================================================

But the accuracy was pretty low (~15%) for first 50 epochs. Is it okay for the accuracy to be in such range? After that when I trained by making:
for layer in model.layers[:407]:
    layer.trainable = False
for layer in model.layers[407:]:
    layer.trainable = True

The val acc(constant around 15%) was greater than training accuracy(~10%). What am I doing wrong?


Design updates 2019 6

@javiercanossini can you resolve the merge conflicts, please? I'm happy to merge otherwise

Merged in #239


Fix Firebase database URL behaviour

I was struggling to get the Firebase database to work, and it turns out its due to the fact that the normalizeDbUrl() function does not conform to actual database URLs, and cannot generate them correctly simply from the Firebase project ID.
The issue is that database URLs that are not in the US region take the form
https://PROJECT_ID-default-rtdb{.SERVER_REGION}.firebasedatabase.app

While the US region database URLs take the form
https://PROJECT_ID-default-rtdb.firebaseio.com

In both cases the normalizeDbUrl() function does not generate a correct URL from just the project ID.
It seems the simplest solution is just add a databaseURL option to the config, and to just use that directly, which is what this pull request adds.
I kept the non-functional normalize function and the final 2 lines in init(), though they should not be used

closes #56

Thanks for discovering this! I decided to do a fix based on yours that doesn't change or add to the API surface: just pass the full Firebase databaseURL as appId, which keeps consistency with the other strategies. Released as 0.14.0.


Array.findLast and other missing functions

Some missing functions from the Array module. In particular the findLast variants.
indexOfFromOpt: add code and docs
lastIndexOf : docs, tests
lastIndexOfOpt : tests
lastIndexOfFrom : docs, tests
findLast : code, docs, tests
findLastIndex : code, docs, tests
findLastIndexOpt : code, docs, tests
findLastIndexWithIndex : code, docs, tests
findLastIndexWithIndexOpt : code, docs

I have no idea why the tests aren't working. It works for me.

It fails because the function does not exist in Node.js 16. Node.js 16 is included in the CI matrix because it's a Long Term Support release. It will stop being supported in September, at which point the matrix should be updated and the checks should pass.

Now that Node.js 16 has reached end-of-life, will this be merged for the next release? And thanks, Justin; I needed findLastIndex!


WIP: add support for Oberve Only resources

Description of your changes
This is a work in progress; I'm just opening this in draft mode to signal intent in case other folks were thinking of the same thing (and to get early feedback if anyone wants to 😄 ). Once I finish the implementation, I'll mark it ready for review.
This adds the new ManagementPolicy field to the Workflow resource by updating the crossplane/crossplane-runtime module to the latest master commit. It also resolves a dependency conflict when the API types or other packages from this module are imported simultaneously as ones from other providers, such as upbound/provider-aws since those use the newer crossplane-runtime versions already. Related dependencies have also been updated. I also updated the version of golangci-lint; the older version (1.50.0) has some known performance issues that this resolves (see the various comments on golangci/golangci-lint#3414).
I have:

[x] Run make reviewable to ensure this PR is ready for review.

How has this code been tested
I ran the existing unit tests which all passed. I may try and add some new ones as part of finishing the implementation. When running the end-to-end tests (make e2e) it fails with the error uptest-v0.5.0: error: No manifest to test provided.; I confirmed this is also true on the main head, so it seems to be an existing problem.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Good questions!

How do you envision Observe Only resources working in combination with provider-terraform Workspace?

I would imagine this (setting managementPolicy: Observe, or managementPolicy: [Observe] in the newly proposed model) would mean that the Provider would essentially only run terraform init and terraform plan, but not terraform apply. This would allow someone to, say, point Crossplane and the Provider at an existing state file and set of Terraform code, and leverage functionality like transposing Terraform outputs into secrets, without necessitating going all in on having Crossplane and the Provider reconcile the state of the resources itself. It might also allow us to detect drift in resources, while not automatically correcting them. (The latter is very similar to what's described with the Weaveworks Flux Terraform Controller [here](https://docs.gitops.weave.works/docs/terraform/Using Terraform CRD/drift-detection/).)

What is the desired result if we compare with the execution of standard terraform data source as in the following example?

In that case, at least if the intent is similar to how I've typically seen datasources used, we're trying to observe something created by something else, and use attributes of that thing in defining another resource that we are creating and managing. Sort of like a lookup, versus "I want you to watch this thing and report on its status and if it matches how we want it to, but don't actually change it."

Based on comments in the Crossplane Slack channel, I’m moving this back to draft mode until the new style (I.e., array vs single value) managementPolicy field is implemented upstream in the Crossplane runtime (supposedly next release).

@yardbirdsax https://github.com/upbound/provider-terraform/pull/195 should implement this. I will close this PR, feel free to reopen if needed 👍


Update ic50.py

Added plotting to show curve fit. Returning model parameters.

Unintentional return statement included.
Hill coeff directionality will depend on inhibition or promotion and will be adjusted once class conversion occurs.


Profile, filter by DB, more filter options, more of actual SQL Profiler that you could use from SSMS

Is your feature request related to a problem? Please describe.
I really want to use Azure Data Studio 100% all the time instead of SSMS primarily because the intelli-sense of queries is massively faster, Dark mode out the box that works, extensability and more responive UI. However at present I always have to have Azure Data Studio and SSMS open both times because there are lots of little bits and pieces which are just to rough to use on ADS - profiler is one of them.
The layout is nice but...
I can't filter by database therefore it's completely useless. There are no templates for what events I want recorded - therefore useless.
Describe the solution or feature you'd like
Add more filter options, but specifically be able to filter to a specific database.
Add templates of events to profile - the one I use 99.9% of the time when I'm using the SSMS SQL profiler is TSQL SPs template. I want to know when SPs start and finish and how they were called, i.e. what the params were. Without being able to do these 2 things the ADS profiler is useless to me.
Describe alternatives you've considered
At this point ADS profiler is completely unuseable for me. All I can do is use the older SSMS SQL Profiler, which of course works but the UI is not as nice.
Additional context
For this extension plus ADS in general - you need to look at what is done already in SSMS, figure out the most useful parts, improve the UI (cause normally it's pretty average) and translate that to ADS. There are so many little things missing from ADS that I use all the time that are not even power user things they are basic quality of life things that not having them really ruins the experience. The most common one double clicking on the dividing line of column headers in a grid does not cause the column to resize to fit the maximum content, it does on virtually every other app - SSMS, Excel etc.... The is no horizontal scroll bar on the connections pane, so when you  expand Server >> database >> table you can see the column names without resizing the pane in some cases taking up 1/3 of the screen space!

thanks @peterlukerow for the great feedback, I am adding the database name column to the profile templates, and you will be able to filter by database name starting from next release. and I will also create separate issues to track other issues/suggestions. and i am going to use this issue to track the database name filtering issue.
In the future, it would be nice if you can open one github issue per problem/suggestion that will make the tracking easier.

the issue about missing templates is tracked by: #6138
the issue about grid column resizing is tracked by: #2251
the issue about horizontal scrollbar for connections view is tracked by: #4106
@peterlukerow Please subscribe to these issues so that you can get notified when there are updates to them. this issue will be closed once I merge the database name filtering related PR.
Thanks
Alan

the changes for the database name filtering has been merged to master branch, it will be available in the July release.

Yay!


Switch to single port and MDNS broadcast per device for all projects

Currently our network discovery assumes a separate connection for each project (each listening on a different port). In addition we need to discover other Mapeo devices not on the same project for project invites.
Because all mdns packets are visible to anyone on the network, we can't actually trust that a connection on a given connection is actually on the same project. In Hyperswarm connections in server mode (which all Mapeo devices will be) do not have a list of topics anyway.
I suggest the following changes to our discovery:

A single listening port for local connections.
All devices advertise the open port on LAN under a common service type name e.g. _mapeo._tcp.
[maybe] Projects that a device is part of are advertised as a TXT record pj=

I'm not sure advertising projects is necessary? Other devices could still connect to it and discover through the protomux handshake whether it is actually part of project. If we are connecting to devices anyway (for being able to receive project invites, and perhaps updates) then there is no cost to this.
If we do advertise projects, we should use a shortened version of project discovery key, to keep within the limits of DNS-SD TXT records. If we use 8-bytes (64 bits) that allows up to 30 projects to be advertised, which seems like a more reasonable limit than 7 if using full 32-byte keys. There is no big negative consequence of a key collision here, since I device would try to connect and fail because they don't have the actual project key.
Also to consider, is whether we have two separate connections for local vs. internet connections? The advantage of having two is to easily identify local vs. internet traffic, however we can't guarantee that a connection on the port advertised on the LAN is actually local (we are just assuming that port is not known outside the LAN), so we probably want a separate check for incoming connections (e.g. check the IP).

Also to consider, is whether we have two separate connections for local vs. internet connections?

I think we should have two separate connections, and block non-local from the mdns socket, and local from the hyperswarm socket. Only connections on the mdns socket should have the RPC (invite) protocol muxed.

Frustratingly I spent 30 mins writing a detailed response and got stung by a github bug that lost my text. Will try again with the time I have:

switch to only one broadcast that advertises a device (this is a great change)

Yes, agreed

remove topics from the Discovery class and expect our protomux handshake will take care of connecting devices to the correct projects/invites

Yes I think this makes sense.

split out hyperswarm connections somehow to treat them differently? and how do the differences between an always-on server peer and a remote mobile device complicate things?

We want to achieve 3 things (damn I had 4 in the first draft but can't remember them now):

Control (via the Mapeo API) over any internet traffic, which means turning hyperswarm discovery on/off and not accepting any non-local connections on any open ports.
We only want the RPC protomux channel to be added to local connections
We want to avoid duplicate connections (via MDNS and Hyperswarm if the user is also doing Hyperswarm internet discovery).

I think the way to achieve this is by blocking connections to/from local devices in hyperswarm. We can block incoming connection via the firewall (requires this patch until merged). Not sure about outgoing connections?

is there a need to pass a custom server to hyperswarm? that means passing our own instance of hyperdht

Not sure if this is needed, but may be.

remove the PeerInfo class?

If this makes sense, I'm not currently familiar enough with the code.

We should confirm which of these we want to pursue, which we don't, and make a few separate issues that group related code problems listed above as this one is too broad.

Yes, definitely. Can you do this and create estimates for each task for Sprint 4?
Related issues and prs:

https://github.com/digidem/mapeo-core-next/issues/93
https://github.com/digidem/mapeo-core-next/issues/69
https://github.com/digidem/mapeo-core-next/issues/68
#113
#109

And if we're advertising each project over hyperswarm but each device over mdns that seems like it could get messy.

With hyperswarm you are advertising your device and a list of topics you are interested in. When you receive an incoming connection you don't know what topics the connecting peer is interested in, if any. Outgoing connections will only be made to peers that are advertising topics that you are interested in - although that is no guarantee they actually have they public key associated with the discovery id used for the topic.
So with hyperswarm you treat connections as "probably interested in the topics I'm advertising" then mux replication streams, and the capability check for each replication stream will validate shared knowledge of hypercore keys.
With the change to a single MDNS service we're essentially advertising a single topic of interest "Mapeo" and all clients interested in that will connect to each other.
In both cases we need to mux replication streams to actually check if a peer has the shared keys. The "topics" in hyperswarm are just a way of filtering devices in the DHT to only connect to those who probably have the stuff you are interested in. For local connections we actually want to connect to all Mapeo devices (so that invites work), and we can assume that the number of connections is small enough to connect to all local devices, so we don't need to filter with topics/ project keys.


Convert self.api() to property

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/approve

/verified

Would you be able to add a PR description please? 🙂

/verified

/verified

/approve

/verified

/approve

/verified


ASU-1515 | Add sold apartment status endpoint

Codecov Report

Merging #289 (d8ebc49) into develop (bb7357c) will decrease coverage by 0.21%.
The diff coverage is 76.36%.

@@             Coverage Diff             @@
##           develop     #289      +/-   ##
===========================================
- Coverage    93.42%   93.20%   -0.22%
===========================================
  Files          118      119       +1
  Lines         4305     4357      +52
  Branches       384      392       +8
===========================================
+ Hits          4022     4061      +39
- Misses         202      210       +8
- Partials        81       86       +5

Impacted Files
Coverage Δ

application_form/urls.py
100.00% <ø> (ø)

application_form/api/sales/views.py
91.53% <69.23%> (-5.64%)
:arrow_down:

application_form/permissions.py
81.48% <81.48%> (ø)

apartment_application_service/settings.py
87.71% <100.00%> (+0.21%)
:arrow_up:

application_form/pdf/haso.py
100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Index staged ledger hash

If this will help with the startup time of an Indexer that has already seen the staking-ledgers directory, then we should do it sooner rather than later because it will increase developer productivity. It will decrease the dev-loop time for larger data sets.

Closed by #1161


Way to update state from main process

Hi @morintd
Thank you for the package.
There is no way to update state from the main. Of course, you may update directly but renderers won't be notified as I understand from code
It will be great to have something like that in the main:
import { setupGlobalStateIPC } from 'electron-state-ipc';

const {state, setState} = setupGlobalStateIPC();
setState(key, value);

Or use Proxy if you do not want to make breaking changes


[API-8] Allow resolving of CatalogKeys with custom default namespaces.

Allowing API consumers to resolve CatalogKeys with custom default namespaces will make it easier to handle user input of custom CatalogTypes.
For example, my "Avatar the Last Airbender in Minecraft" plugin defines abilities as CatalogTypes (which allows other plugins to register their own custom abilities), and it would be handy to by default resolve non-namespaced keys to my plugin's namespace with a single CatalogKey.resolve call.
I've also taken the opportunity to add missing javadocs to the interface.

To end off, my final concern is whether we should be defaulting the namespace in CatalogKey.Builder. IMO, we should prefer for API consumers to specifically set the namespace, or use builtin factories like CatalogKey#minecraft or CatalogKey#sponge.
I wager that plugin devs will rarely want minecraft-namespaced keys, especially since most of the time they'll be calling CatalogKey builders/factories for their own custom CatalogTypes.

@ST-DDT Adjusted based on your feedback.

Closed in favor of https://github.com/SpongePowered/SpongeAPI/pull/2268


fix: add value to simulate contract

Relates to:

N/A

Background
This PR addresses an issue where the simulateContract function in the ViemEVMWalletClient was not passing the value parameter, leading to incorrect transaction simulations for contracts requiring a specific value.
What does this PR do?

Adds the value parameter to the simulateContract function call in the ViemEVMWalletClient.ts file.
Ensures proper handling of transactions with a specific value.

What kind of change is this?
Bug fix.
Documentation changes needed?

My changes do not require a change to the project documentation.
Testing
Detailed testing steps

Modify the simulateContract function call in the ViemEVMWalletClient file to include the value parameter.
Build the packages after making the change.
Test the updated function using a contract requiring a specific value to ensure the simulation works as expected.

Before

After

For plugins

[x] I have tested this change locally with key pair wallets
[ ] I have tested this change locally with hosted wallets (e.g. Crossmint Smart Wallets, etc.)

Discord username
@AKAwolfcito

Hello @0xaguspunk, I took your suggestion and included it in this PR


res.set(object) fails

The error is easy to fix:
https://github.com/kartikk221/hyper-express/blob/e5fd1211df4bc89fbb05b342e795fb30cd2d5eb6/src/components/compatibility/ExpressResponse.js#L95
should be
reference.header(name, value);

Good catch! Would you like to make a PR or should I push a commit to resolve this bug?

I would like to work on this 🙏


Add kubectl client certificate

This certificate will be served by Velum when downloading the kubeconfig
file, and is specific for that usage.
Fixes: bsc#1046963

After running an orchestration with https://github.com/kubic-project/velum/pull/242 in place, I can confirm:
~/Downloads KUBECONFIG=kubeconfig kubectl get nodes
NAME                                                 STATUS    AGE       VERSION
f697a851912e4bb8a615a26f3fd9f8ab.infra.caasp.local   Ready     7m        v1.5.3

Merging, push -f was done to retrigger CI with +A's from @flavio, @mssola, and @kiall


Losing Highlights

When highlighting my current study WT on my iPhone and then saving both it and my iPad data files, merging them and then restoring that new singular file, I'm keeping all my notes, and tabs but losing my highlights. Looking back, I see that I've lost a bit of my highlights in my Bible and study publications, but all the person study notes are there.
I'm not using the JW Library Windows app, just between my two devices.

I'm experiencing the same issue when merging data files from my iPad and Windows device.

@jszalma @benshemmeld Thanks for your feedback. Is it possible to send me your 2 original backup files so that I can investigate the issue please? If so, you can send to this email address where I am the only recipient<EMAIL_ADDRESS>Also indicate the publication / article where highlights are missing once merged.
Thanks
Antony

@jszalma Thanks for sending me sample backup files. I merged the two backup files and then imported the result and found no problem - both para 1 and para 2 highlights were present. However, the merged file that you supplied does not contain the highlighting so I suspect you may be using an older version of JWLMerge, Please advise which version you are using and also try teh latest pre-release "<IP_ADDRESS>"

@AntonyCorbett  thanks for looking into the issue.  I was about to send you my sample files when I saw your message above.  It looks like there may be an issue with the Installer for <IP_ADDRESS>.  I built JWLMerge from the latest source code and it worked successfully (preserving the highlighting).  However, when using the installer the resulting merged file is missing the highlighting.

@benshemmeld thanks - yes you're right. The source for the pre-releases was never pushed. Now fixed in <IP_ADDRESS>. Thanks for your help!

Thanks so much!
Sent from my iPhone

On Jun 15, 2019, at 7:31 AM, Antony Corbett<EMAIL_ADDRESS>wrote:
@benshemmeld thanks - yes you're right. The source for the pre-releases was never pushed. Now fixed in <IP_ADDRESS>. Thanks for your help!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


wire up new logo on console

#406  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jvmi7 and the rest of your teammates on  Graphite


Update to senzingdata-2.0.0

See https://github.com/Senzing/docker-compose-demo/issues/172

Pull requests

https://github.com/Senzing/docker-xterm/pull/21


Blaze integration

What would you like to see added?
Might be nice if we could create an integration with Blaze so we can kinda cross-promote that addon.
Is there a workaround you can use in the meantime?
Build my own, rely on the CP Nav Item search thingy?
Priority wise - where's this feature for you?
This is just a nice to have. I can deal without.

Closing in favour of issue in Blaze's repo instead - doublethreedigital/runway#15


Add migration_lock repo configuration

Added migration_lock repo configuration in order to override the lock that is being used by migrators to handle multiple concurrent migrators.
By default "FOR UPDATE" is being used.
Fixes #2233

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

Thanks @josevalim !


Build core image with github action

DOCKERHUB_USER kubebb

@Abirdcfly help with @Lanture1064

One of our previous examples:

github action file here https://github.com/bestchains/fabric-operator/blob/main/.github/workflows/image-build.yaml
Note that the above build multi-architecture image is push commit event triggered, that is, after the pr is merged, the normal test when the pr is created can be similar to the simple build amd64 image in this link. https://github.com/bestchains/fabric-operator/blob/7776e712f9ad0cd50847ed94c069fed9aea70e10/.github/workflows/endtoend-tests.yaml#L35-L39
The specific commands to build the image can be seen in the makefile https://github.com/bestchains/fabric-operator/blob/7776e712f9ad0cd50847ed94c069fed9aea70e10/Makefile#L44

I will pick up this task since we need this immediately

this can be closed as pr https://github.com/kubebb/core/pull/50 merged


CGX 2.12 problems with mirror copies of elements

Example 1
element faces turned inside out by copy with mirror transformation.
run.fbd
static.inp

Solution proposed by Klaus Wittig:
In cgx 2.12 elemChecker.c is disabled.
Commenting out line 17 solves the problem.


Migrate send.py into b module

Precursor to #7

Need to: Setup docker to have the public and private RSA keys
Ignore the known_hosts file http://linuxcommando.blogspot.com/2008/10/how-to-disable-ssh-host-key-checking.html

Fixed


Skip resolving files directly inside node_modules

Although the node module resolution algorithm looks for .js files there, they would never be there in correctly configured node_modules. So it should be safe to skip *.ts, *.js, *.tsx, etc.

Also skips looking for files directly in node_modules/@types.
Also skips looking for any module name containing a colon, since those look like absolute URIs.

Fixes #52695

It would also be good to add a test that uses tsconfig paths that includes a key with a : to show that those lookups doesn’t get skipped.

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this faster

@andrewbranch I moved the node:stuff skip to tryResolve, although you should take another look because I'm not sure I put it in the right place there.

they would never be there in correctly configured node_modules

You're absolutely right that npm will never install anything that puts loose files in the node_modules directory, and I'll even go so far as to say that node's esm lookup doesn't look for these loose files either (a subtle difference between esm and cjs our resolver probably doesn't currently respect, actually). But it's definitely a core requirement of the old bog standard commonjs resolution algorithm - a very stable algorithm, as evidenced by how much we use it as a shorthand in our very old tests. It's definitely not a good idea to diverge from it; we use it in our tests a ton because it's a nice shorthand, and older node projects have definitely made use of it, too. Can we not just replace the many-stat calls with some psuedo-stat-calls fuelled by a single readdir per directory? IIRC, the cost is in the syscall count, not the number of filesystem entries we inspect. Plus, we can disable it for esm-mode lookups entirely and still be algorithm compliant, and, in theory, those lookups will make up a greater percentage of lookups over time.

Like, it's not frequent, but you can definitely find projects that make use of this old cjs resolution pattern on github (usually on the older side, ofc).

It doesn’t feel outlandish for us to say that this pattern is not recommended, but if you rely on it, simply add an entry to paths.

I'm not opposed to that - but also

Can we not just replace the many-stat calls with some psuedo-stat-calls fuelled by a single readdir per directory?

I thought we already did this. https://github.com/microsoft/TypeScript/pull/35286

@DanielRosenwasser that just made our directory iterator much more efficient (so it didn't use any extra stat calls) - it didn't swap us to using that directory iterator to prefill file existence cache entries in the module name resolver.

In fact, our fileExists calls as used in moduleNameResolver are, as far as I can tell, wholly uncached - we'll repeatedly try lookups for the same file paths within the same compilation. The host in use (for the commandline at least) is just a barebones CompilerHost wrapping over our default node sys.

Approved!

@typescript-bot run DT


Multiple Binary Search Tree

🐛 Bug Report
There are currently multiple articles of BST. I would like to remove the duplicate ones from the sidebar.
Have you read the Contributing Guidelines on Pull Requests?
Yes

@HarshCasper this issue is important, so please look into this.

@ankitaggarwal23 @anushkrishnav @bhav09


[Bug] infinite PodInitializing state

Is this a BUG REPORT or FEATURE REQUEST?:
BUG REPORT
What happened:
Serverless: Packaging service...
Serverless: Excluding development dependencies...
Serverless: Pods status: {"waiting":{"reason":"PodInitializing"}}

What you expected to happen:
My service deployed successfully.
How to reproduce it (as minimally and precisely as possible):
Here I have a reproducible setup of Minikube with Kubeless: https://github.com/Industrial/platform/tree/develop
Here I have a service named api that is a Serverless project configured with serverless-kubeless: https://github.com/Industrial/platform/blob/develop/services/api
Here's the serverless.yml: https://github.com/Industrial/platform/blob/develop/services/api/serverless.yml
Problem: When I run serverless deploy my Kubernetes Dashboard shows a red / failing Pod, Deployment and Service. It never recovers / turns to green. Did I do something wrong?
Environment:

Kubernetes version (use kubectl version): v1.18.2
Kubeless version (use kubeless version): v1.0.6-dirty
Cloud provider or physical cluster: Kubeless in Minikube

Hello @Industrial, this usually means that the function failed to deploy, you would need to check what's the root cause of that failure. Maybe these docs can help: https://kubeless.io/docs/debug-functions/

This is the error I'm getting:
Failed to pull image "kubeless/unzip@sha256:4863100364496255de9bf8722a220dad7143ab277ac72435876eb8c93936e9d7": rpc error: code = Unknown desc = Error response from daemon: Get https://registry-1.docker.io/v2/: dial tcp: lookup registry-1.docker.io on <IP_ADDRESS>:53: read udp <IP_ADDRESS>:48632-><IP_ADDRESS>:53: i/o timeout

it seems that the daemon is unable to pull the image, does your k8s cluster have access to dockerhub (or the Internet in general)?


Add Windows Support

There are a few options how you can use this compiler on Windows:

Use WSL
Use VSCode compilers for Windows: https://code.visualstudio.com/docs/languages/cpp
Many other methods, just google it

This repo doesn't provide any binaries, so you have to compile it yourself

@Reloadman99 Thanks for your interest!
I'll not close this issue as there seems to be a demand for the compiler to work on Windows. I do not presently have capacity to be able to do this; my main focus, all be it rather slowly, is to make this compiler as good as possible on the platforms I have immediate access to.
As @botantony has pointed out there are alternative work arounds to be able to use the compiler. I hope in the mean time you can get one of those solutions working.
Or if you fancy taking it on please submit a PR.


Adding textComponent prop to allow own TextInput Component

Hey hey,
I really like your work - thanks for it!
As I'm using a logic-including, pre-styled text input Component for all my forms, I'm in need of a way to pass in the TextField to use. Done! 😄

Added the textComponent prop, if not set, the original TextField is used.

Thanks and cheers 🍻

@thegamenicorus If there's anything else to take care of, let me know ❤ khop khun mâak!

I appreciate it, Thank you :)


How can use Position Dll class method same as Azimuth , distance , etc in Dotspatial ?

Hello
I need to know how can i use Azimuth , Distance , Angle in Dotspatial.position ?
May you help me or share some documents about it ?
Thank you.

I would suggest downloading the CHM file here https://dotspatial.codeplex.com/wikipage?title=DotSpatial SDK Documentation  and then searching for Position. Looks like most of the classes are there.

Thank you @sindizzy
I Found Bearing and distance but i can not method for calculate azimuth between 2 lat and long how can i do it ?
And i need to know how can calculate angle between 2 line ?

Sry for new Replay New Issue
] try using Start.BearingTo(Dis point) but i just return Direction i need bearing in degree !
how can be do it ?

Dear @sindizzy
may u Help me ?

Position.BearingTo(Position destination) returns an Azimuth.
You can then use Azimuth.DecimalDegrees to get bearing in degree.

Thank you Dear @gojanpaolo
And how can i calculate Angle Between 2 line ?


CUDA running out of memory for a very small dataset (7 sample training data)

hello.
i had tried the vision fine-tuning script for glm-4v-9b model. The command i had used was python3 finetune_demo/finetune_vision.py ./data THUDM/glm-4v-9b ./finetune_demo/configs/lora.yaml
I had tried the fine-tuning for a sample dataset of 7 examples and running out of GPU (NVIDIA A100-SXM4-80GB * 8)
The data is configured properly and the model is able to parse the train.jsonl, test.jsonl, val.jsonl.
GPU config: NVIDIA A100-SXM4-80GB * 8
Errors

Unable to define the no of epocs
Despite having the hardware requirements mentioned here, I am still getting CUDA out of Memory for 7 data samples.

The last logs before CUDA err:
 ***** Running training *****   Num examples = 7   Num Epochs = 375   Instantaneous batch size per device = 2   Total train batch size (w. parallel, distributed & accumulation) = 2   Gradient Accumulation steps = 1   Total optimization steps = 1,500   Number of trainable parameters = 3,198,976   0%
Steps to recreate the error:

The dataset structure is this format : ``
Run python3 finetune_demo/finetune_vision.py ./data THUDM/glm-4v-9b ./finetune_demo/configs/lora.yaml
Models gets loaded from HF hub and the dataset is being fed.
When the training starts, in the first step, there is a sharp increase in GPU usage for an example of 7 samples.

Please provide a better guide and understanding towards vision finetuning.
PS;
In the GLM English docs,
We have this:
Execute single machine single card run through the following code.
python finetune.py  data/AdvertiseGen/  THUDM/glm-4-9b-chat  configs/lora.yaml # For Chat Fine-tune
python finetune.py  data/CogVLM-311K/  THUDM/glm-4v-9b configs/lora.yaml # For VQA Fine-tune
Are we sure about python finetune.py  data/CogVLM-311K/  THUDM/glm-4v-9b configs/lora.yaml # For VQA Fine-tune is the right command?

@zRzRzRzRzRzRzR

batch size per device = 2
1 batch size use 75GB memory

Okay will try it out

Can you please share the complete lora yaml config that might work with the given hardware requirements?

@zRzRzRzRzRzRzR In the lora.yaml file
the config we use is
per_device_train_batch_size: 1
and
per_device_eval_batch_size: 1
So you are suggesting we have 2 batches per device or how
Because this current yaml config always gives me cuda out of memory.

If you can't use the default configuration normally, then a larger batch size will definitely not work. This is already the minimum configuration.
But after my test, even if it is an A100 graphics card with 75GB video memory, are you sure that the maximum input length and output length are both 512?

We had used batch size per device: 1 and not 2. We did use 2 first but changed it in the lora.yaml.
Answering your question: Yes the input length is less than 512 tokens. (less than 256 tokens)
We tried with this lora.yaml
`data_config:
train_file: train.jsonl
val_file: val.jsonl
test_file: test.jsonl
num_proc: 1
max_input_length: 512
max_output_length: 512
training_args:
output_dir: ./output
max_steps: 128
learning_rate: 5e-4
per_device_train_batch_size: 1
per_device_eval_batch_size: 1
dataloader_num_workers: 7
remove_unused_columns: false
save_strategy: steps
save_steps: 10
log_level: info
logging_strategy: steps
logging_steps: 50
evaluation_strategy: steps
eval_steps: 50
predict_with_generate: true
fp16: true
gradient_accumulation_steps: 1
generation_config:
max_new_tokens: 256
peft_config:
peft_type: LORA
task_type: CAUSAL_LM
r: 1
lora_alpha: 32
lora_dropout: 0.1
target_modules: ["query_key_value"]`
Here is the logs before CUDA out of memory.
 ***** Running training *****   Num examples = 7   Num Epochs = 128   Instantaneous batch size per device = 1   Training with DataParallel so batch size has been adjusted to: 8   Total train batch size (w. parallel, distributed & accumulation) = 8   Gradient Accumulation steps = 1   Total optimization steps = 128   Number of trainable parameters = 799,744   0%|                                                                             | 0/128 [00:00<?, ?it/s]
Here is the GPU snap snot at that time-period.

We mostly suspect its a DP problem as only 7 nodes are getting used as we have 7 examples.
Love to get in touch w you bro. I am reachable at<EMAIL_ADDRESS>Help is much appreciated.

Update 1:
I had tried DeepSpeed with this command OMP_NUM_THREADS=1 torchrun --standalone --nnodes=1 --nproc_per_node=8  ./finetune_demo/finetune_vision.py ./data/  THUDM/glm-4v-9b finetune_demo/configs/lora.yaml
All the GPU cores were used. When we did DP and had 2-2-3 data examples in test.jsonl, train.jsonl, and val.jsonl, only 2 cores were getting used. So we assumed DP was a problem. When ran the Deepseed command, used all cores efficiently but still running out of memory. Cuda error still persists.
Logs before error:

Please check below for the GPU usage.

Help is much appriciated. Using the same GPU config - NVIDIA A100-SXM4-80GB * 8

@zRzRzRzRzRzRzR Hello. Your help would be much appreciated

emm, it is one gpu works?(set only one gpu and tune the model in lora) DS will not work in this demo in my test and I wrote in Readme
If one gpu work, the problem maybe in DP. I also have no idea to check now

Can you please provide us with a fine-tuning script and a lora yaml file
that tunes the model.
Can u share the one with that works with yourside? The one you guys have
tested and found it to be working.
On Sun, 7 Jul, 2024, 6:59 pm zR, @.***> wrote:

emm, it is one gpu works?(set only one gpu and tune the model in lora) DS
will not work in this demo in my test and I wrote in Readme
If one gpu work, the problem maybe in DP. I also have no idea to check now
—
Reply to this email directly, view it on GitHub
https://github.com/THUDM/GLM-4/issues/281#issuecomment-2212451253, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5V2IUF7F6VODOX6IHMS4YDZLE7E3AVCNFSM6AAAAABKH6ZZCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJSGQ2TCMRVGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

here is what I use
data_config:
  train_file: train.jsonl
  val_file: dev.jsonl
  test_file: dev.jsonl
  num_proc: 1
max_input_length: 512
max_output_length: 512
training_args:
  # see `transformers.Seq2SeqTrainingArguments`
  output_dir: ./output
  max_steps: 3000
  # needed to be fit for the dataset
  learning_rate: 5e-4
  # settings for data loading
  per_device_train_batch_size: 1
  dataloader_num_workers: 16
  remove_unused_columns: false
  # settings for saving checkpoints
  save_strategy: steps
  save_steps: 500
  # settings for logging
  log_level: info
  logging_strategy: steps
  logging_steps: 10
  # settings for evaluation
  per_device_eval_batch_size: 4
  evaluation_strategy: steps
  eval_steps: 500
  # settings for optimizer
  # adam_epsilon: 1e-6
  # uncomment the following line to detect nan or inf values
  # debug: underflow_overflow
  predict_with_generate: true
  # see `transformers.GenerationConfig`
  generation_config:
    max_new_tokens: 512
  # set your absolute deepspeed path here
  # deepspeed: configs/ds_zero_3.json
peft_config:
  peft_type: LORA
  task_type: CAUSAL_LM
  r: 8
  lora_alpha: 32
  lora_dropout: 0.1
  target_modules: ["query_key_value"]

and I only use 1 x A100

got it.
Last time when you had tried tuning this, did the training run successfully?
I'll implement the same to debug.
On Tue, 9 Jul, 2024, 12:00 pm zR, @.***> wrote:

here is what I use
data_config:
train_file: train.jsonl
val_file: dev.jsonl
test_file: dev.jsonl
num_proc: 1
max_input_length: 512
max_output_length: 512
training_args:
see transformers.Seq2SeqTrainingArguments
output_dir: ./output
max_steps: 3000
needed to be fit for the dataset
learning_rate: 5e-4
settings for data loading
per_device_train_batch_size: 1
dataloader_num_workers: 16
remove_unused_columns: false
settings for saving checkpoints
save_strategy: steps
save_steps: 500
settings for logging
log_level: info
logging_strategy: steps
logging_steps: 10
settings for evaluation
per_device_eval_batch_size: 4
evaluation_strategy: steps
eval_steps: 500
settings for optimizer
adam_epsilon: 1e-6
uncomment the following line to detect nan or inf values
debug: underflow_overflow
predict_with_generate: true
see transformers.GenerationConfig
generation_config:
max_new_tokens: 512
set your absolute deepspeed path here
deepspeed: configs/ds_zero_3.json
peft_config:
peft_type: LORA
task_type: CAUSAL_LM
r: 8
lora_alpha: 32
lora_dropout: 0.1
target_modules: ["query_key_value"]
and I only use 1 x A100
—
Reply to this email directly, view it on GitHub
https://github.com/THUDM/GLM-4/issues/281#issuecomment-2216692795, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5V2IUHBZZ36N2PNAI5N36DZLN7QRAVCNFSM6AAAAABKH6ZZCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWGY4TENZZGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

yes and I get the adapter weight, Last Time is today haha

haha thanks.
it's been fun talking to you mate.
hey im harshith btww
would love to know you.
this is my twitter : https://x.com/theharshithh
On Tue, 9 Jul, 2024, 12:03 pm zR, @.***> wrote:

yes and I get the adapter weight, Last Time is today haha
—
Reply to this email directly, view it on GitHub
https://github.com/THUDM/GLM-4/issues/281#issuecomment-2216696202, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5V2IUCNHVS4X6ZLBQFCZ4TZLN745AVCNFSM6AAAAABKH6ZZCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWGY4TMMRQGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

also, did you change any of the other things in the finetune_vision.py?
just to be on the safe side?
On Tue, 9 Jul, 2024, 12:17 pm Harshith K, @.***> wrote:

haha thanks.
it's been fun talking to you mate.
hey im harshith btww
would love to know you.
this is my twitter : https://x.com/theharshithh
On Tue, 9 Jul, 2024, 12:03 pm zR, @.***> wrote:

yes and I get the adapter weight, Last Time is today haha
—
Reply to this email directly, view it on GitHub
https://github.com/THUDM/GLM-4/issues/281#issuecomment-2216696202, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5V2IUCNHVS4X6ZLBQFCZ4TZLN745AVCNFSM6AAAAABKH6ZZCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWGY4TMMRQGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

change here may work

change it to 500(both)

noted. will try today.
On Tue, 9 Jul, 2024, 12:53 pm zR, @.***> wrote:

change here may work
image.png (view on web)
https://github.com/THUDM/GLM-4/assets/93239683/b2c607a0-18d2-4031-9079-2b0ac0d2db6c
change it to 500(both)
—
Reply to this email directly, view it on GitHub
https://github.com/THUDM/GLM-4/issues/281#issuecomment-2216800325, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5V2IUF3ZC2SZ6PEM5U27ATZLOFWBAVCNFSM6AAAAABKH6ZZCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWHAYDAMZSGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

@zRzRzRzRzRzRzR Heyy.
I am able save the adapter_config.json

## Note: We changed the Seq2Seq, so that we can set both max_steps: 30 & num_train_epochs: 3.
Its able to run 21/30 steps. Its failing under print('hitting test')     if test_dataset is not None:     trainer.predict(test_dataset)
Error Logs:

Can you please verify if you have tried the inference.py for the saved model adapter_configs?
Patience much appreciated!

Also, please share the branch of the finetune_vision.py which is working for you.

get this issue, please install transformers == 4.40.2 and using main branch(latest commit) and I have not met this issue before

noted, Can u please let me know if a compete finetune (vision)and inference
is happening successfully for you?
Just to confirm if there is any other error that might come.
On Wed, 10 Jul, 2024, 9:26 pm zR, @.***> wrote:

get this issue, please install transformers == 4.40.2 and using main
branch(latest commit) and I have not met this issue before
—
Reply to this email directly, view it on GitHub
https://github.com/THUDM/GLM-4/issues/281#issuecomment-2220902123, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5V2IUEXFLT56CSDZGSA5STZLVKSLAVCNFSM6AAAAABKH6ZZCGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQHEYDEMJSGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


The version command does not support JSON output

Output of restic version
restic 0.16.1 compiled with go1.21.3 on linux/amd64
What should restic do differently? Which functionality do you think we should add?
Something like
> restic version --json
[{"version":"0.16.1"},{"go_version":"1.21.3",{"target":"linux/amd64"}}]

What are you trying to do? What problem would this solve?
Automation
Did restic help you today? Did it make you happy in any way?
Great tool. Love it.

Sounds like a good idea. But the json output should be far less nested and rather look similar to the following: {"version":"0.16.1", "go_version":"1.21.3", "go_target":"linux/amd64"}

Implemented in #4553


Add support for request proxying via CRN host

If the SDK is called from a VM with the ALEPH_API_UNIX_SOCKET env variable set, all the request to the API will be proxied via the provided socket.
closes #35

Maybe @hoh has a better idea.
Point is: if you want to use this specific branch inside a VM, it is possible to install it using NPM.

@BjrInt well, a problem seems to be, that typescript cannot find types, when I get this directly from git

Can I circumvent this somehow?

Yup. The Github repository has no index.js so the module resolution will fail if you try to load the root directory of the module. The black magic is actually done here : https://github.com/aleph-im/aleph-sdk-ts/blob/main/package.json#L13  , where the publishing script transpiles everything into a dist directory which contains the actual package (the source file are not uploaded on NPM).
Long story short :

If you want to use the typescript just import from 'aleph-sdk-ts/src/index.ts`
If you want to use plain javascript, first run cd node_modules/aleph-sdk-ts then yarn build. You'll be able to import the js file from aleph-sdk-ts/dist

Was able to successfully test


Github workflows for testing

Create a Github workflow for testing so every time something gets pushed to main it is tested!

done ftw


Jest jasmine/ts migration

Summary
Migration to TS
Test plan

Heh, 295 errors 😅 Could you ping me when this is getting more ready for review (or if you have any questions)?

@SimenB Haha. It is not ready yet. I just wanted to try Draf PR 😄 . I will ping when it is ready

BTW, I wouldn't worry too much about typing src/jasmine - it's a fork from jasmine itself and at some point we'll remove it in favor of jest-circus anyways. If it's not too painful, of course go for it 🙂

@doniyor2109 since you commited TS migration part (final), is this ready for review? 🙂 I merged in master since I tweaked a few types here and there in #7998

@SimenB Yea, it took too long for this migration. I just finished types. However tests are failing because of wired error. Somehow babel does not transpile static fields and property fields correctly. 🤔

Here is the error

Yeah, that's blocked by #7846. You can assign to the class after.
Like this:
https://github.com/facebook/jest/blob/5f34db761340dbfc37656b2fe88f31b7ca350315/packages/jest-transform/src/ScriptTransformer.ts#L53
https://github.com/facebook/jest/blob/5f34db761340dbfc37656b2fe88f31b7ca350315/packages/jest-transform/src/ScriptTransformer.ts#L576-L577
(the first is only for types, the second is the actual assignment)

Codecov Report

Merging #7970 into master will decrease coverage by 0.16%.
The diff coverage is 3.84%.

@@            Coverage Diff             @@
##           master    #7970      +/-   ##
==========================================
- Coverage   63.31%   63.15%   -0.17%
==========================================
  Files         263      263
  Lines       10266    10258       -8
  Branches     2098     2287     +189
==========================================
- Hits         6500     6478      -22
- Misses       3273     3276       +3
- Partials      493      504      +11

Impacted Files
Coverage Δ

...ages/jest-jasmine2/src/expectationResultFactory.ts
88% <ø> (ø)

packages/jest-jasmine2/src/each.ts
0% <ø> (ø)

...ackages/jest-util/src/convertDescriptorToString.ts
0% <ø> (ø)
:arrow_up:

packages/jest-jasmine2/src/pTimeout.ts
100% <ø> (ø)

packages/jest-jasmine2/src/isError.ts
0% <ø> (ø)

packages/jest-snapshot/src/index.ts
32.09% <ø> (ø)
:arrow_up:

packages/jest-jasmine2/src/PCancelable.js
32.25% <ø> (ø)
:arrow_up:

packages/jest-jasmine2/src/treeProcessor.ts
0% <0%> (ø)

...ages/jest-jasmine2/src/jasmine/ReportDispatcher.ts
0% <0%> (ø)

packages/jest-jasmine2/src/jasmine/jasmineLight.ts
0% <0%> (ø)

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c25942...0625619. Read the comment docs.

This is huge and I just took a quick look. I'll trust @SimenB here. We can merge it, release an alpha and test it in FB code. If everything is good we can just release a new minor after the full TS migration.
Please take into account that jest-circus will be the default in the next major, so Jasmine won't be that critical at that point.

Thanks for the huge contribution @doniyor2109!!


Auto detect android platform settings

Sorry, wrong direction. I was trying to merge this PR into my branch.


Add null safety check for protobuf deserializer

Thanks - 👍  Would you mind adding a test for this case?

Thanks - 👍 Would you mind adding a test for this case?

Done!


For date parsing consider inheriting from apis_core.core.models.LegacyDateMixin and extend capabilities

The mixin does some parsing of the dates (written to ISO) but at least it provides the fields. Could be extended for the Hijri dates.

we could also finish up acdh-oeaw/apis-core-rdf#1119


Hybrid search fail due to Text_key is stored in a nested field

When performing the hybrid search the following code in libs/mongodb/langchain_mongodb/retrievers/hybrid_search.py cause a key value error if the text_key is a nested filed example title.text
# Formatting
        docs = []
        for res in cursor:
            text = res.pop(self.vectorstore._text_key)
            # score = res.pop("score")  # The score remains buried!
            make_serializable(res)
            docs.append(Document(page_content=text, metadata=res))
        return docs

Hi @abdelsalamhamdi, thanks for raising the issue.  We're tracking in https://jira.mongodb.org/browse/INTPYTHON-452.


Complete the migration to new triangle-shapes  and minor bugfixes

simplified bump.svg and renamed to bumps.svg
simplified speedbump.svg and renamed to bump.svg
Resized railway-xing-unsecured, circle-bg, circle-o, square-angular and square-rounded to 512×512px. In some cases this fixes display errors in many browsers, like:
 (screenshot from Firefox 36, left one is before, right one after)
Replaced all remaining occurences of tri-bg and tri-in by tri-rounded and tri-angular
Added yield-sign.

There is already PR #41 which deals with this, but I had a different approach: @saiarcot895 used a new yield-icon, whereas I used the content-attribute in us.cson. @knikel what do you think, which approach should be used there?

Thanks!


Add detailed feature list to README

Hey buildbuddy folks,
Looks like a neat new tool you're working on here! For those of us who already use, e.g., Tulsi (or XCHammer) and would consider switching, could I ask how it compares--in goals and status--to the previous Xcode<>Bazel efforts?
[Sorry if I've such a comparison already exists and I've missed it somewhere.]
I'm also going to tag @BalestraPatrick and @erikkerber -- since from the release notes it sounds like they've been switching over and playing around with it on their codebases!
Thanks so much!
Chris

It's on my TODO list to make a comparison to Tulsi, rules_ios, and XCHammer, along with a design/vision document
In the meantime, this Twitter thread, and the blog post I link to at the start, should be a good holdover: https://twitter.com/brentleyjones/status/1512137776782794753.

Sweet! Thanks for replying so fast. Good luck and thanks @brentleyjones. Have really enjoyed your 👍🏻s and interacting with you around the GitHub bazel verse, btw. Also, I love the logo :) Have showed several people just for that.
[Super helpful, btw. Can't use right now, I think, because I'm pretty sure I need the actual build to be in Bazel. But I remain very excited.]

@cpsauer FYI, we added a high level design goals document: https://github.com/buildbuddy-io/rules_xcodeproj/blob/main/doc/design/high-level.md.
Thinking more on this, I don't think it would be in good taste to create a document that does a direct comparison to any of the other generators. I think it would instead be best to celebrate all of the things that this generator does well. The README has a small section on this already, but because it's before 1.0, it's a little lite. If that was beefed up, would that be good enough in your eyes? If not, what could we do without directly comparing to other projects?

Thanks, Brentley! You're great :)
That linked doc especially helps my understanding of how things are evolving around build modes (building with Xcode vs Bazel vs proxy), and the goals behind each mode. Some of my main (implicit) questions were around better understanding those build modes and feeling reassured about being able to produce outputs consistent with Bazel even with custom rules (and select()s) up the dependency chain.
The hybrid build parts also really got me thinking about which parts of my build I really need/want to be in Bazel vs Xcode. An interesting question! I know I want to specify platform-independent build info in Bazel; I think we're mostly interested in using Bazel for sharing code across platforms. If the Apple-specific outer wrappings, build targets, and tests were done via Xcode, even as their source of truth, calling into Bazel to build their (configured) cross-platform dependencies, that'd be an interesting paradigm shift, and as you say, great for supporting new features Apple has just released that are hard to wrap in Bazel. I don't know how universal that attitude is--maybe lots of people want Bazel to build their Apple-specific code--and I certainly need to think more, but it strikes me that you've hit on something very interesting with hybrid building.
I totally get (and love!) the goodheartedness in not wanting to do direct comparisons and to value everyone's good efforts. I do think, though, that your users will probably be implicitly comparing in deciding which to use. It'd be easy to assume they know more about the differences than they do, and I think comparisons, even implicitly, would really help them make good decisions per unit of evaluation effort. I'd still encourage directly (but respectfully) explaining how this project is different and better--whenever you're ready for that 1.0 launch and feel ready for people to make that comparison. But as you say, maybe the best way to do that--maximally respectfully and without naming names--would be to specially celebrate the the important use cases this tool enables. That is, to highlight the special ways this tool supports you (and implicitly that the other tools do not). That'd really help people make decisions, I think! Even just saying that you'd recommend people use this tool for their Apple editing needs would go a long way, I bet--whenever you're ready to launch, of course. My 2c anyway :) And I totally agree that the README is a great place for that.
Cheers! And thanks for all you do.
Chris

Status update:

We are now on https://bazel.build/install/ide
The README extensively lists features. In particular:

Comprehensive Xcode feature support
Comprehensive rules coverage
BwX mode (though it's not what we recommend you use)

"Projects using" as a indirect way for them to endorse the project
BazelCon video showing off the features and ease of use

@cpsauer Could you give this all a fresh look to see what we might be missing. I still don't want to do direct comparisons, and I understand how I might be underselling how great the generator is by doing that. So far I've just asked people to try it, which is usually enough to get them to convert. Given all of that though, maybe there is more we can do?

Related: we should get https://github.com/bazelbuild/bazel/blob/master/site/en/migrate/xcode.md updated since it only mentions Tulsi.

Someone offline probably convinced me that I should still do a comparison, but not host it in this repo (so probably my personal blog instead). I might eventually do that.
Closing this for now, as I have it tracking the 1.0 release. I'll open it again if anyone has further changes they feel we should make.

Hey, Brently! I've been off in cross-platform VSCode land for a bit, and thus out of the loop, but seeing your 1.0 launch--and this--put a big smile on my face. Huge congratulations on all you've done here (and elsewhere).
+1 for the migrate doc, but I assume you're tracking that elsewhere.
I still really do think you could help save new users evaluation time--who might otherwise just start with the tool with the most stars--by making it super clear which "key differentiated features" this adds in the README. (Or something like that. Idea radiation: Key differentiated features could be bold with a legend at the bottom?) I know I've already probably pushed for comparison too much already, but that seems like a tasteful alternative and I know I'd have really valued that upon first finding this, and I bet others would, too.
Looking forward to diving in more the next time I'm in Xcode land! And reading that blog post if and when you post it.
Good luck! Cheering for you.
Chris

I like the "key differentiated features" idea. I'll probably run with that soon.

Heh, I'd say https://github.com/bazelbuild/tulsi/pull/400 pretty well resolves this need.

There are still a couple of other less known options, so I still plan to tweak the docs a bit more based on your most recent feedback. But yes, that should help a bit 😅.


Update performance improvements section

with a new graph comparing 6.8 and 7.0.
Fixes gradle/gradle-private#3317

Rendered version:

I don't read base64 encoded strings so I couldn't prove that the image is correct :)

That is why I included a screenshot above.

This was meant as a joke but I failed :)


Popup info on the main interface

The following items in the interface should have tooltips added to them:

Highly Relevant buttons: "This page contains the type of information required to answer questions for this domain.'
Relevant buttons: "This page contains domain-relevant information, but it won't help answer questions."
Not Relevant: "This page is irrelevant to the domain."

@wmburke please let me know if you want to extend the tooltips associated with the icons in the header. We could extend each tooltip as you described in this issue.

Yes - this is really important! Please do this!

Commit 2ac4eb1643bb8e8efc73e34fc8b3a94ffc7bde2b adds the tooltips associated with the icons in the frames. @wmburke please close this issue if it works for you.

Awesome! Thank you!


Security scan vulnerabilities in 1.2.2

@jorianvo

@030 is this better with 1.2.4 ?

According Trivy not:
osixia/openldap:1.2.4 (debian 9.6)
==================================
Total: 438 (UNKNOWN: 0, LOW: 63, MEDIUM: 265, HIGH: 93, CRITICAL: 17)


Adding "Hide the used Port"-Option in HomebridgeStatusWidget

This PR is a response to https://github.com/oznu/homebridge-config-ui-x/issues/558.
The used port is no longer displayed (on purpose) within the current version. The wrong spelling "running" was already fix'd. But I believe that it should be left open to the community whether they want to display the port or not. I mean, at least one person (also me) misses it. So i added an option "Hide the used Port" for the HomebridgeStatusWidget. You don't want the port? Check the box. You want the port? Uncheck it.

I have also prepared all language files. But one or two lines have to be translated again. Not a big deal.
P.S.: In this PR is also a corrected grammatical mistake in de.json.

Thanks; I'll check this out soon.
We can probably get the translations for "running on port" from an older commit: https://github.com/oznu/homebridge-config-ui-x/tree/140858974f48034ae64cb99aa3cc570fbef26d54/ui/src/i18n

Good idea.
I used the old commit for the translation and also considered the recent changes (PR https://github.com/oznu/homebridge-config-ui-x/pull/573, PR https://github.com/oznu/homebridge-config-ui-x/pull/571 and PR https://github.com/oznu/homebridge-config-ui-x/pull/568). But there seems to be a conflict with ru.json.

Hi, @Staubgeborener
Regarding ru.json.  All merges are correct.

Thanks @Staubgeborener and @Caribsky


Application doesn't work on Arch Linux

I was planning to package your commandline app for the aur but it seems like your application doesn't work on arch linux.
Steps to Reproduce
How did you install it
sudo pacman -S yt-dlp opencv clang mpv ffmpeg
cargo install tplay

How did you run
In the home directory:
./.cargo/bin/tplay "https://<some-youtube-video-url>"

What Happened
After running the application the program froze with blank terminal with no audio or video playing even waiting for several minutes didn't help.
Expected Result
To get a youtube video to be played in the terminal.
Terminal Used
Kitty 0.28.1
Operating System Used
Arch Linux with linux-zen kernel version 6.2.13

Have you tried to play a local media file or image?
YouTube videos are downloaded before playing them (so very long videos may take a very long time to open).
If that's the case I should put a progress bar (or just don't suppress yt-dlp output)
To make sure the crate can open videos just fine try:
tplay https://test-videos.co.uk/vids/bigbuckbunny/mp4/av1/360/Big_Buck_Bunny_360_10s_1MB.mp4
(The video is just 1MB, so it should take almost no time to load on a regular broadband connection)
And if that works, try a similarly short small video (on YouTube) to confirm that yt-dlp can download youtube videos:
tplay https://www.youtube.com/watch?v=WSgQIsOE2rE

Ok sure let me check and I will come back to you in a few moments.

Ok it works thanks!!! :smile: . So the issue seems to be the length of the video if you can add a progress bar it would provide a good user experience.
Also some suggestions I want to provide for the project. I know this is not the right place but it is very important:

Linux community has a lot toxic people so beware of them like they harress people, say mean things, etc like it also happended with big projects as well one example I can provide is of kitty project there was a recent issue over there where one guy was very mean he went so far as to say that the main developer is stupid he doesn't know anything. so my suggestion is don't talk with those people they will ruin your mood and your day.
Provide issue templates in your project they make handling issues much easier.
In your README add a part about like under Installation Debian its installations steps and at the end other distros with the sentence like with more contribution we can make our project available to more distros this will help you alot because you are not a super human :smile: so you can't  package it for all distros.
Don't over do your work this will burn you out very quickly and this is not. so I will suggest take plenty of rest.

Thanks for your comments, I'll make sure the yt-dlp output is not suppressed in future releases, maybe I'll release a 0.3.1 version as it's a genuine user experience issue that can cause some confusion.
Regarding your points:

I don't really want to worry about this, I doubt that trolls would/toxic people would find any benefit in messing with this arguably small project;
Makes sense
Yeah it would be a massive endeavour to try  and test installing it on most distros!
Truth!
That's something on my radar, I am looking into the various options for this, including makedoc, wiki on github and the likes, anything that requires the least effort to maintain
Main is meant to be stable, any feature/unstable work is meant to be done on separate branches. However, from now on I should now start to make use of tagged releases to match the crate's version.

MIT is a generally more relaxed license, and I don't like how GPLv3 "virally" affects any derived work.
If people like it, modify/repackage it it's fine (as long as they credit my original work).

Oops again it failed :smile: . I think this is an issue occurring on some urls I guess but also thanks for enabling debugging. I will post the screenshot of the issue.
Here's how I reproduced it:
tplay 'https://www.youtube.com/watch?v=Vz96b0gm9qo'

Here is the screenshots of the issue:

With RUST_BACKTRACE=full:

Yes, see #3
Unfortunately depending on which version of MPV you have (0.34 or 0.35) you need to use a different crate (see Cargo.toml).


Move UDF instance construction into UDFService

DocSchemaInfo is now only responsible for triggering an update event.
The UserDefinedFunctionService will take care of handling the scalar
instance creation and registering them in the Functions registry.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c6cdb24). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #5910   +/-   ##
=========================================
  Coverage          ?   82.99%
  Complexity        ?    12157
=========================================
  Files             ?     1428
  Lines             ?    46472
  Branches          ?     5733
=========================================
  Hits              ?    38569
  Misses            ?     5221
  Partials          ?     2682

Impacted Files
Coverage Δ
Complexity Δ

...rate/operation/udf/UserDefinedFunctionService.java
87.32% <100%> (ø)
17 <4> (?)

...main/java/io/crate/metadata/doc/DocSchemaInfo.java
86.66% <100%> (ø)
34 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6cdb24...5b988ed. Read the comment docs.


Turn Menu.items into list in API

I want to merge this change because...
closes #3010
Screenshots

Pull Request Checklist

[ ] Privileged views and APIs are guarded by proper permission checks.
[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] Database queries are optimized and the number of queries is constant.
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] GraphQL schema and type definitions are up to date.

I think that children on MenuItem are still an connection field

Thanks for a good point, I missed it


feat: add available models API

The available models API allows listing of all available models from all configured model providers in Otto8.
Requires: https://github.com/otto8-ai/tools/pull/248

Merging based on "offline" conversation with Taylor.


The node startup cannot identify the url of the remote btc node

expected
Hello, I have a problem running the node and cannot read the remote btc information. I hope to get help from the project side and run the node intact.
ordinals version
ord 0.18.2
Remote BTC status
The btc node is the correct mainnet node and has been verified to have no problems.
The --bitcoin-rpc-url parameter provided is verified and completely OK.
curl -s -X POST -u 'xxx:xxx' -d '{"jsonrpc": "1.0", "id":"83", "method": "getblockcount", "params": [] }' http://xxx:8332 | jq
{
"result": 839759,
"error": null,
"id": "83"
}
Problem re-steps
Start command
./ord --data-dir==./node --bitcoin-rpc-username=xxxx --bitcoin-rpc-password=xxxx  --bitcoin-rpc-url=http://xxx:8332  server --http
Error message
error: Failed to connect to Bitcoin Core RPC at http://xxx:8332/:  JSON-RPC error: transport error: unexpected HTTP code: 401

Hi COLUD4 - the xxx in format for the --bitcoin-rpc-url flag needs to be replaced with the actual url, like http://localhost:8332 or http://<IP_ADDRESS>:8332.  Please retry and reach out to the #tech-support channel on our official Discord server, The Ordicord if you need further assistance,


Support a per-org Dangerfile via an [org]/Danger repo

Problem: Want to run the same logic on CocoaPods, Xcodeproj, CocoaPods-Core, CocoaPods-App, [etc etc]
Current solution: Make a danger-cocoapods plugin, refactor logic into that, make each one have a Dangerfile that calls something to trigger shared logic.
Proposed solution: bundle exec danger && bundle exec danger local checks to see if there is an existing repo on the org called Danger e.g. CocoaPods/Danger - if this exists, it clones ( or uses the import features to pull in a shared Dangerfile and run it's logic at the same time. This means we can have org-level consistent checks without even needing to have a Dangerfile in the current repo. You just need to set the ENV vars and run bundle exec danger.

Might try this after WWDC if no one beats me to it.

And support for danger plugins - https://github.com/danger/danger/tree/master/danger_plugins

Working on this with https://github.com/danger/danger/pull/325 🚀

This is in!

Oh yeah :rocket:


New version: Warzone2100Project.Warzone2100 version 4.5.0

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978334972
2024-08-11 16:33:52.819 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!67E2535B: (caller: 67D21A80) LogHr(1) tid(cc4) 8A15005E     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!67E6B5DD: (caller: 67F012BF) Exception(1) tid(cc4) 8A15005E ]
2024-08-11 16:33:59.745 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!54FF535B: (caller: 54EF1A80) LogHr(1) tid(1a90) 8A15005E     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!5503B5DD: (caller: 550D12BF) Exception(1) tid(1a90) 8A15005E ]
2024-08-11 16:34:00.773 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.40.33810.0

Automated error analysis suggests -1978334972 may mean This package has a dependency missing from your system.
Automated error analysis suggests 8A15005E may mean APPINSTALLER_CLI_ERROR_PINNED_CERTIFICATE_MISMATCH - The server certificate did not match any of the expected values.
(Automated response - build 887.)


Updated deps.

please use as reference: https://github.com/senecajs/seneca-user/blob/master/package.json
https://github.com/senecajs/seneca-transport/blob/master/package.json

:+1:


FailedToRebalanceConsumerError: Exception: NODE_EXISTS[-110]

I have a process to consumer messages from Kafka 24/7 and use forever on top to ensure my process will never stop and 100% alive.
But once I let my process run a few hours, I found that it stopped to consumer message (my process is still running but somehow there is no message consuming). Then I found these errors in my log file
FailedToRebalanceConsumerError: Exception: NODE_EXISTS[-110]
FailedToRegisterConsumerError: Consumer not registered prerender-live-group_186636ca-3ccb-4660-9931-6f4160e71fdb
FailedToRegisterConsumerError: Path wasn't created
my code (if you want more detail to investigate please let me know)
this.client = new kafka.Client(this.zookeeperServer);         this.consumer = new kafka.HighLevelConsumer(this.client, [{ topic: this.topicName }], this.options);         this.consumer.on('message', this.onMessage.bind(this));         this.consumer.on('error', this.onError.bind(this));
I have tried to find the root cause since last 2 weeks. But I'm still not able to solve it, even I get the latest version (0.5.5).
Please help me, I need the process to survive all day all night.
my configuration
"options": {     "autoCommit": true,     "autoCommitMsgCount": 1,     "autoCommitIntervalMs": 300,     "fromOffset": false,     "groupId": "new-oad-group",     "fromBeginning": false,     "fetchMaxWaitMs": 100,     "fetchMaxBytes": 1048576,     "maxTickMessages": 100,    "encoding": "utf8"   }
Machine info
OS ==> 2.6.32-573.26.1.el6.centos.plus.x86_64
CPU(s) 8
MemTotal:       15300380 kB
Last test

Run the process on 4 machines (each machine use the same code, same configuration)
The process has 2 consumers to consume from 2 topics
-- first topic has 80 partitions
-- second topic has 6 partitions

Looks like it failed to register the consumer with zookeeper.
Run your process with env DEBUG=kafka-node:* it will output a lot of debug information that may help.

I had the same issue.  The doc says it is the problem of FailedToRebalanceConsumerError: Exception: NODE_EXISTS[-110]
@m2studio How did u start your program with forever? In my case, I started 20 instances of node threads with a shell script and random error occur within those 20 instances. But if I started those instances with a few time delayed for each threads would solve this problem.
I read about debug logs with kafka-node:* turned on. Seems kafka would rebalance partitions when ever a new thread joins into the party. So that if we started threads within a short amount of time. Rebalance could lead to an error.
The following are some debug logs:
1 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:zookeeper Node: /consumers/kafka-node-group/ids/kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 was created.
2 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer rebalance() kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 is rebalancing: false ready: false
3 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer Deregistered listeners kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30
4 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer Registered listeners kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30
5 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 is attempting to rebalance
6 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 stopping data read during rebalance
7 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 assembling data for rebalance
8 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:zookeeper Children are: ["kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30","kafka-node-group_9e9d3ed2-5066-48ec-888c-f1373672ceb3","kafka-node-group_f887c141-3221-47ca-9b3d-f5dfc8736a06","kafka-node-group_92146a20-8662-42>
9 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 releasing current partitions during rebalance
10 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 determining the partitions to own during rebalance
11 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer consumerPerTopicMap.consumerTopicMap {"kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30":["lbs.location"],"kafka-node-group_9e9d3ed2-5066-48ec-888c-f1373672ceb3":["lbs.location"],"kafka-node-group_f887c14>
12 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer newTopicPayloads [{"topic":"lbs.location","partition":"50","offset":0,"maxBytes":5242880,"metadata":"m"},{"topic":"lbs.location","partition":"51","offset":0,"maxBytes":5242880,"metadata":"m"},{"topic":"lbs.loc>
13 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 gaining ownership of partitions during rebalance
14 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 rebalance attempt failed
15 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 is attempting to rebalance
16 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 stopping data read during rebalance
17 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 assembling data for rebalance
18 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:zookeeper Children are: ["kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30","kafka-node-group_9e9d3ed2-5066-48ec-888c-f1373672ceb3","kafka-node-group_f887c141-3221-47ca-9b3d-f5dfc8736a06","kafka-node-group_92146a20-8662-42>
19 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 releasing current partitions during rebalance
20 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 determining the partitions to own during rebalance
21 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer consumerPerTopicMap.consumerTopicMap {"kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30":["lbs.location"],"kafka-node-group_9e9d3ed2-5066-48ec-888c-f1373672ceb3":["lbs.location"],"kafka-node-group_f887c14>
22 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer newTopicPayloads [{"topic":"lbs.location","partition":"50","offset":0,"maxBytes":5242880,"metadata":"m"},{"topic":"lbs.location","partition":"51","offset":0,"maxBytes":5242880,"metadata":"m"},{"topic":"lbs.loc>
23 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 gaining ownership of partitions during rebalance
24 Wed, 26 Oct 2016 11:18:13 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 rebalance attempt failed
25 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 is attempting to rebalance
26 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 stopping data read during rebalance
27 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 assembling data for rebalance
28 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Children are: ["kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30","kafka-node-group_9e9d3ed2-5066-48ec-888c-f1373672ceb3","kafka-node-group_f887c141-3221-47ca-9b3d-f5dfc8736a06","kafka-node-group_92146a20-8662-42>
29 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 releasing current partitions during rebalance
30 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 determining the partitions to own during rebalance
31 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:HighLevelConsumer consumerPerTopicMap.consumerTopicMap {"kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30":["lbs.location"],"kafka-node-group_9e9d3ed2-5066-48ec-888c-f1373672ceb3":["lbs.location"],"kafka-node-group_f887c14>
32 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:HighLevelConsumer newTopicPayloads [{"topic":"lbs.location","partition":"50","offset":0,"maxBytes":5242880,"metadata":"m"},{"topic":"lbs.location","partition":"51","offset":0,"maxBytes":5242880,"metadata":"m"},{"topic":"lbs.loc>
33 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:HighLevelConsumer HighLevelConsumer kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30 gaining ownership of partitions during rebalance
34 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/50 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
35 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/51 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
36 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/52 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
37 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/53 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
38 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/54 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
39 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/55 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
40 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/56 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
41 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/57 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
42 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/58 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
43 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/59 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
44 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/60 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
45 Wed, 26 Oct 2016 11:18:14 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/61 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
46 Wed, 26 Oct 2016 11:18:15 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/62 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
47 Wed, 26 Oct 2016 11:18:15 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/63 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
48 Wed, 26 Oct 2016 11:18:15 GMT kafka-node:zookeeper Gained ownership of /consumers/kafka-node-group/owners/lbs.location/64 by kafka-node-group_c3ae7253-b964-4d35-b5c5-d2eb90276d30.
Hope this could help you.

A stack trace of the NODE_EXISTS[-110] error may help isolate the issue.
Also have you tried using the new Consumer Group? It's very similar to HLC and should not suffer from these NODE_EXISTS issues.

@hyperlink My kafka version is 0.8.2 so that I can't use Consumer Group. Gonna have a deep look at this issue later.

Hi @m2studio @gogorush, have you found any solution regarding this issue?
We are currently facing the same problem in a prod environment, and we are struggling to find a way to solve it.
We have a topic with 15 partitions, and there are 30+ processes that can be selected as consumers. However, from time to time, partitions are left without owners.
Any hint towards where to look into would be appreciated

This is caused by the rebalance issue when more consumers added into the network. I upgraded my kafka to 0.9+ and use the new ConsumerGroup API to avoid this issue.
I checked this issue earlier, conflunt(the company behind kafka) posted an article about their new consumer in 0.9  said and I quote 'This new consumer also adds a set of protocols for managing fault-tolerant groups of consumer processes. Previously this functionality was implemented with a thick Java client (that interacted heavily with Zookeeper). The complexity of this logic made it hard to build fully featured consumers in other languages'. SO I guess Javascript is one of the languages. And for many other reasons, I strongly recommend you to upgrade your kafka to 0.9+ too.
Check our more on this link
Hope this could help you @s-rodriguez .

Wow, thanks a lot @gogorush! I'll definitely check out kafka 0.9+ with the new ConsumerGroup