Can't load track for now?

Code:
        console.log(track.url)
        const result = await this.player.manager.cluster.rest.loadTracks(
            track.url,
        );
        console.log(result.loadType)
        switch (result.loadType) {
            case "TRACK_LOADED":
            case "SEARCH_RESULT":
                const trackFromCluster = result.tracks[0];
                track.stream = trackFromCluster.track;
                break;
        }

Console output:
https://www.youtube.com/watch?v=Ryjh-YcO4ag
LOAD_FAILED

Seems that this is node server problem?
Loaded Failed also happened on Erela.js when using same node.
Maybe I'll change a lavalink server and have a try first.
If it still can't play song I'll open issue again


[Feature request] Repeating the header in console table widget

It would be nice if the column headers would be repeated every x data rows, so you don't loose track which column is which. x could be linked to the window height.
I think about something like this:
+---------------+----------+-----------+------------+------------+
| name          | can read | can write | can update | can delete |
+---------------+----------+-----------+------------+------------+
| john.doe      |    1     |     0     |    0       |    0       |
+---------------+----------+-----------+------------+------------+
<about x rows>
+---------------+----------+-----------+------------+------------+
| name          | can read | can write | can update | can delete |
+---------------+----------+-----------+------------+------------+
| jane.doe      |    1     |     1     |    1       |    1       |
+---------------+----------+-----------+------------+------------+

Sad to see this closed, care to elaborate why this got closed?

Because enhancements are no longer accepted into Yii 2.0: https://www.yiiframework.com/news/156/yii-2-1-and-yii-2-0-feature-freeze

Back then it was Yii 2.1, now it's Yii 3 that is in heavy development.

Alright, thank you for the explanation.
Is this feature already in Yii 3 or should I reopen the feature request there?

I think it's no there. https://github.com/yiisoft/yii-console

I'm not sure I can follow. The yii-core repo contained everything for yii3 but it was split and archived. I did not find a yii3-console repo, but this one is tagged yii3. Can you point me to the right repo or am I in the right repo here?

You are in the right repo.

So just to get this right (I don't want to be annoying, just want to understand it):

this is the repo for the console functionalities of yii3
a feature freeze was issued for yii2
I should move the issue to the repo for yii3 console functionalities
The issue is here, yet the issue is in the wrong repo?

It is in the right repo. Console is now based on different codebase where there's no such issue.


Permission to upload my puzzle game [ fidget spinner puzzle ] to the openfl's showcase

Hi, it will be a honor be part of the openfl showcase if my game fits your requirements. thanks for your time and awesome hard work.

Awesome! Thanks for helping get this added, and great job on the game :wink:


Fix Broken Link to Cubehelix Colormap in README

The link to the cubehelix colormap in the README is broken. It currently points to https://www.mrao.cam.ac.uk/~dag/CUBEHELIX/.

The server is not down: https://www.mrao.cam.ac.uk/surveys/snrs/
but D.A. Green page is broken: https://www.mrao.cam.ac.uk/~dag/

It has migrated here: https://people.phy.cam.ac.uk/dag9/CUBEHELIX/
I will update the README.


how to get assymetric matrix for containment index?

Dear Daniel,
(first thank you very much for new binaries which emit distances with --set /--countdict, it works perfectly.)
Could you please help me with another issue  - the containment index?
I cannot figure out the correct settings to emit the assymetric matrix for the containment index.
Running this:
./dashing2_s128 sketch -k31 -p8 --cmpout containment.txt -o card -F paths.txt --set --containment --asymmetric-all-pairs
I am getting full square matrix, but it is symmetric, the outputs are the same for the upper and the lower parts. They are indeed containment indexes, i.e. they fit to (A intersection B)/A but, the values for (A intersection B)/B are not reported.
The matrix is identical to the one produced by:
./dashing2_s128 sketch -k31 -p8 --cmpout containment.txt -o card -F paths.txt -Q paths.txt --set --containment
I tried also
./dashing2_s128 sketch -k31 -p8 --cmpout containment.txt -o card -F paths.txt -Q paths.txt --set --containment --asymmetric-all-pairs
This results in two full symmetric matrices (each one is the same as those mentioned above) stick toghether, i.e. each F-Q sample pair comparison is done twice, but still  in only "one direction".
Could you please help me with that?
Thank you, dasa

Hi Dasa,
Thanks for the report - it's very helpful.
I've confirmed that the --asymmetric-all-pairs with -F paths.txt is computing only one of the two containment scores, so I'm looking into why that's happening.
Best,
Daniel

Hi again,
I found the problem - Dashing2 was selecting symmetric containment instead of standard containment. This was responsible for the distance matrices being symmetric when they shouldn't have been.
I've fixed them in this pull request, and I'll include updated binaries soon.
Thanks,
Daniel


book detail page

refs #234
this PR adds a new ordering property to creator types to control the order in which they are displayed on the new book detail page. it also adds default ordering values for some common creator types, like author.
the book detail page has been updated to match new designs, including the list of creators, publication date, format indicator, link to view online, public notes, and list of issues/volumes. the uncertainty indicator has not yet been implemented.

Codecov Report

Merging #550 into develop will increase coverage by <.01%.
The diff coverage is 99.24%.

@@             Coverage Diff             @@
##           develop     #550      +/-   ##
===========================================
+ Coverage    98.17%   98.17%   +<.01%
===========================================
  Files          197      198       +1
  Lines        10111    10216     +105
  Branches        40       40
===========================================
+ Hits          9926    10030     +104
- Misses         185      186       +1


Update getCommands.js

Fixes issue with path for Windows.

By analyzing the blame information on this pull request, we identified @grabbou to be a potential reviewer.


Fix Xamarin.Android SDK locations to match the latest paths.

Now we have:
bin/
include/
lib/xamarin.android/lib/xbuild
lib/xamarin.android/lib/xbuild/Xamarin/Android (`mandroid` in the past)
lib/xamarin.android/lib/xbuild-frameworks/MonoAndroid/v*
Version*

@atsushieno I think you got things working on Linux without this PR?
I think reworking things to use the system Xamarin.Android should replace these change. Hopefully I can work on that soonish?

Not at all. Things are broken.

Why did you close it?

We are trying to cleanup old issues/prs. We can reopen if this PR is still valid and we can get the CI to pass.

You didn't actually work on it. Anyone who had the same problem will see my PR and can improve it based on the existing work.

We are just closing anything that didn't have activity for a few months, not hiding anything.
Sorry if I wasn't clear,

In case it's not clear, I had created so many PRs that fix various issues and that have been kept untouched. I know there is no one for a while so I just left them, but that also means no one can expect any further bugfix contributions from me.


[Hotfix][Wip] Fix storage usage throttling

Purpose
Too much throttle info in db.
Changes

default cache no longer db.

QA Notes
Should cause improved performance site wide.
Documentation
🐞 fix no docs.
Side Effects
None that I know of.
Ticket

reviewing @Johnetordoff, I know this is in progress, just want to get a head start

@pattisdr this should be the last commit, once this passed Travis it should be good.


(com.aws.greengrass.Nucleus): local deployments attempt to download artifacts from receipe

when attempting to deploy a component from the command line that contains a recipe with artifacts from s3 the core attempts to download them from s3,  the documentation https://docs.aws.amazon.com/greengrass/v2/developerguide/component-recipe-reference.html#recipe-format
states:
When you develop a component with an archive artifact on a local core device, you might not have a URI for that artifact. To test your component with an Unarchive option that extracts the artifact, specify a URI where the file name matches the name of your archive artifact file. You can specify the URI where you expect to upload the archive artifact, or you can specify a new placeholder URI. For example, to extract the my_archive.zip artifact during a local deployment, you can specify s3://DOC-EXAMPLE-BUCKET/my_archive.zip.
the problem is that the core actually tries to download the artifacts and fails, which leads one to change the recipe file and comment out the artifacts section when doing local development
this issue is also per https://forums.aws.amazon.com/thread.jspa?threadID=336887
To Reproduce
create a component with recipe that contains artifacts for example :
RecipeFormatVersion: 2020-01-25
ComponentName: org.example.ggv2comp
ComponentVersion: '1.0.6'
ComponentDescription: Component for ggz
ComponentPublisher: Me
ComponentConfiguration:
  DefaultConfiguration:
    Message: world
    accessControl:
      aws.greengrass.ipc.mqttproxy: #https://docs.aws.amazon.com/greengrass/v2/developerguide/ipc-iot-core-mqtt.html#ipc-operation-subscribetoiotcore
        "org.example.ggv2comp.ggv2comp:pubsub:1":
          policyDescription: Allows access to publish to mqtt
          operations:
            - "aws.greengrass#PublishToIoTCore"
            - "aws.greengrass#SubscribeToIoTCore"
          resources:
            - "*"
Manifests:
  - Platform:
      os: linux
    Lifecycle:
      Run: |
        java -cp '{artifacts:path}/*' -jar {artifacts:path}/ggv2comp-1.0.6.jar
    Artifacts:
      - URI: 's3://ggv2artifacts/artifacts/org.example.ggv2comp.ggv2comp.zip'
        Unarchive: ZIP

deploy component with sudo /greengrass/v2/bin/greengrass-cli deployment create -r ./ -a ./artifacts -m "$1=$2"
Expected behavior
component deploys to the core
Actual behavior
the core attempts to download the component
Environment

OS: Ubuntu 20.04
JDK version: 8
Nucleus version: 2.3.0

Additional context
this blocks the ability to properly do a pipeline

Hi,
The local artifact directory which you pass into the Greengrass CLI must be set up in a precise manner. The layout must be
<artifact directory root>/<component name>/<component version>/<artifacts go here>
If you do not have that exact layout then Greengrass will not be able to find the local file that you want it to find.

I also notice in your recipe that you are not using the decompressed artifact path like you ought to. Instead of {artifacts:path} you need to use {artifacts:decompressedPath}/org.example.ggv2comp.ggv2comp/ggv2comp-1.0.6.jar
Files are unarchived into this decompressed path inside a directory with the same name as the zip file without the .zip extension.

What do you mean that stdout is blocked? Greengrass reads your standard out and writes it into the log file, split by new lines.

i mean i was trying to simplify starting java so so instead or using
java -jar ... in run of the yaml i created a shell script
$!/bin/bash
cd dirname "$0" || exit
java -cp "./*" -jar  "${ComponenetArtifact}.jar"
and tried to run that instead, it seemed to have run, but i didn't see any output going out.

Where do you expect to see the output? Output will go into the component's log file in the Greengrass log directory. Is that where you're looking?

yea, i was looking on the log of the component where i used to see std out , but it just stopped

Check the Greengrass log file, it will tell you if your component was started and what the exit code was. Search the log for your component name to find the relevant lines.
Please provide the recipe you're using now.

that's why i've created a script that will remove the old one and install the updated one without increasing version number
sudo /greengrass/v2/bin/greengrass-cli deployment create --remove "$1"
sudo /greengrass/v2/bin/greengrass-cli deployment create -r ./ -a ./ -m "$1=$2"
i'm new to v2 (barely used v1) where we only had one lambda that listend to UDP, i work on windows so i'm still trying to find the fastest develop deploy flow
i need to use mqtt (btw i see i have 2 api's that use mqtt in device iot sdk not sure what's the diff) , so it's not like i can launch this thing on my windows, i have to compile, created a zip out of it, and then copy to a linux hyper-v machine i'm running .

Doing the two deployments immediately back to back will not work. Deployments are asynchronous and take time to execute. If you create two deployments immediately like that, only the second deployment will go through.

For MQTT, see: https://docs.aws.amazon.com/greengrass/v2/developerguide/ipc-iot-core-mqtt.html

really? it looked they are being queued, i could see from the logs that it always deleted the first deployment and deploys the first component, but something strange just happened , i tried doing a deployment and got this:
021-08-04T19:21:29.257Z [ERROR] (pool-2-thread-104) com.aws.greengrass.deployment.DeploymentService: Error occurred while processing deployment. {deploymentId=6cf3c7ba-fc99-41c5-86cd-728181bc1bbf, serviceName=DeploymentService, currentState=RUNNING}
java.util.concurrent.ExecutionException: com.aws.greengrass.componentmanager.exceptions.NoAvailableComponentVersionException: There is no version of component aws.greengrass.TokenExchangeService satisfying =2.0.3
at java.util.concurrent.FutureTask.report(FutureTask.java:122)
at java.util.concurrent.FutureTask.get(FutureTask.java:192)
at com.aws.greengrass.deployment.DefaultDeploymentTask.call(DefaultDeploymentTask.java:107)
at com.aws.greengrass.deployment.DefaultDeploymentTask.call(DefaultDeploymentTask.java:38)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: com.aws.greengrass.componentmanager.exceptions.NoAvailableComponentVersionException: There is no version of component aws.greengrass.TokenExchangeService satisfying =2.0.3
at com.aws.greengrass.componentmanager.ComponentManager.getActiveAndSatisfiedComponentMetadata(ComponentManager.java:612)
at com.aws.greengrass.componentmanager.ComponentManager.getActiveAndSatisfiedComponentMetadata(ComponentManager.java:603)
at com.aws.greengrass.componentmanager.DependencyResolver.lambda$resolveDependencies$0(DependencyResolver.java:104)
at com.aws.greengrass.componentmanager.DependencyResolver.resolveComponentDependencies(DependencyResolver.java:225)
at com.aws.greengrass.componentmanager.DependencyResolver.resolveDependencies(DependencyResolver.java:101)
at com.aws.greengrass.deployment.DefaultDeploymentTask.lambda$call$2(DefaultDeploymentTask.java:105)
... 4 more

Yes they are indeed queued, but if a deployment exists in the queue for the same group (including the local group) it will cancel any deployment and execute the next one instead.
To solve that error, you need to be connected to the AWS cloud, are you?

considering i've deployed this from the cloud console and it responded i would say yes, (btw i also tried the 2.4.0 nuclease and failed (i think with the same error

What components are you deploying? How is token exchange service getting included in the deployment (are you explicitly deploying it or as a dependency of some other component)?
Please provide the list of components and versions which you are deploying.

ok, resolved the issue the bash shell script, but leaving the nuclease aside for a moment i'm trying to create a yaml deployment for core, my problem is that i'm trying to replaces the json nuclease config
of this:
--- targetArn: arn:aws:iot:us-east-1:718195959442:thing/ggv2sample components:   aws.greengrass.Nucleus:     componentVersion: 2.3.0     configurationUpdate:       reset:         - ''       merge: |             {               "iotRoleAlias": "GreengrassCoreTokenExchangeRoleAlias",               "awsRegion": "us-east-1",               "componentStoreMaxSizeBytes": "10000000000",               "iotCredEndpoint": "cdn0nawodlbhw.credentials.iot.us-east-1.amazonaws.com",               "iotDataEndpoint": "a1puwupqpac1y5-ats.iot.us-east-1.amazonaws.com",               "greengrassDataPlanePort": "443",               "mqtt": {                 "port": "443"               },               "logging": {                 "level": "DEBUG",                 "outputDirectory": "/greengrass/v2/logs",                 "fileSizeKB": "10240"               },               "deploymentPollingFrequencySeconds": "15",               "jvmOptions": "-Dlog.store=FILE",               "runWithDefault": {                 "posixShell": "sh",                 "posixUser": "ggc_user:ggc_group"               }             }   aws.greengrass.Cli:     componentVersion: 2.3.0   aws.greengrass.LocalDebugConsole:     componentVersion: 2.2.1   aws.greengrass.TokenExchangeService:     componentVersion: 2.0.3
with this:
`
targetArn: arn:aws:iot:us-east-1:718195959442:thing/ggv2sample
components:
aws.greengrass.Nucleus:
componentVersion: 2.3.0
configurationUpdate:
reset:
- ''
merge: |
iotRoleAlias: GreengrassCoreTokenExchangeRoleAlias
awsRegion: us-east-1
componentStoreMaxSizeBytes: '10000000000'
iotCredEndpoint: cdn0nawodlbhw.credentials.iot.us-east-1.amazonaws.com
iotDataEndpoint: a1puwupqpac1y5-ats.iot.us-east-1.amazonaws.com
greengrassDataPlanePort: '443'
mqtt:
port: '443'
logging:
level: DEBUG
outputDirectory: "/greengrass/v2/logs"
fileSizeKB: '10240'
deploymentPollingFrequencySeconds: '15'
jvmOptions: "-Dlog.store=FILE"
runWithDefault:
posixShell: sh
posixUser: ggc_user:ggc_group
aws.greengrass.Cli:
componentVersion: 2.3.0
aws.greengrass.LocalDebugConsole:
componentVersion: 2.2.1
aws.greengrass.TokenExchangeService:
componentVersion: 2.0.3
`
but i get an error ocurred (ValidationException) when calling the CreateDeployment operation: Error at components/aws.greengrass.Nucleus

The createDeployment API does not accept YAML, you must use JSON. The configurationUpdate section must be a JSON-encoded string.

really? cause i was looking at the https://awscli.amazonaws.com/v2/documentation/api/latest/reference/greengrassv2/create-deployment.html and it has a --cli-input-yaml parameter so i figured at least the external config would be ok

Yes really. The cli-input-yaml will work for the top-level items in the API, but not for the JSON-encoded string. AWS CLI doesn't know that it is a JSON-encoded string, all it knows is that it is a string.

nuts, i'm not exactly fond of yaml, but my main issue is the escaped json in the merge section which makes it unreadable and error prone, i was hoping to avoid that.
if such a deployment would invoke multiple components with multiple merge with escaped json it would be come very error prone

{     "targetArn": "arn:aws:iot:us-east-1:718195959442:thing/ggv2sample",     "components": {         "aws.greengrass.Nucleus": {             "componentVersion": "2.4.0",             "configurationUpdate": {                 "reset": [""],                 "merge": "{\"iotRoleAlias\":\"GreengrassCoreTokenExchangeRoleAlias\",\"awsRegion\":\"us-east-1\",\"componentStoreMaxSizeBytes\":\"10000000000\",\"iotCredEndpoint\":\"cdn0nawodlbhw.credentials.iot.us-east-1.amazonaws.com\",\"iotDataEndpoint\":\"a1puwupqpac1y5-ats.iot.us-east-1.amazonaws.com\",\"greengrassDataPlanePort\":\"443\",\"mqtt\":{\"port\":\"443\"},\"logging\":{\"level\":\"DEBUG\",\"outputDirectory\":\"/greengrass/v2/logs\",\"fileSizeKB\":\"10240\"},\"deploymentPollingFrequencySeconds\":\"15\",\"jvmOptions\":\"-Dlog.store=FILE\",\"runWithDefault\":{\"posixShell\":\"sh\",\"posixUser\":\"ggc_user:ggc_group\"}}"             }         },         "aws.greengrass.Cli": {             "componentVersion": "2.3.0"         },         "aws.greengrass.LocalDebugConsole": {             "componentVersion": "2.2.1"         },         "aws.greengrass.TokenExchangeService": {             "componentVersion": "2.0.3"         }     } }
and i still get this bit, which i'm not sure what that means:
java.util.concurrent.ExecutionException: com.aws.greengrass.componentmanager.exceptions.NoAvailableComponentVersionException: Failed to negotiate component 'aws.greengrass.Nucleus' version with cloud and no local applicable version satisfying requirement '{aws.greengrass.Cli=>=2.1.0 <2.4.0, thing/ggv2sample==2.4.0}'.         at java.util.concurrent.FutureTask.report(FutureTask.java:122)         at java.util.concurrent.FutureTask.get(FutureTask.java:192)         at com.aws.greengrass.deployment.DefaultDeploymentTask.call(DefaultDeploymentTask.java:107)         at com.aws.greengrass.deployment.DefaultDeploymentTask.call(DefaultDeploymentTask.java:38)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)         at java.lang.Thread.run(Thread.java:748) Caused by: com.aws.greengrass.componentmanager.exceptions.NoAvailableComponentVersionException: Failed to negotiate component 'aws.greengrass.Nucleus' version with cloud and no local applicable version satisfying requirement '{aws.greengrass.Cli=>=2.1.0 <2.4.0, thing/ggv2sample==2.4.0}'.         at com.aws.greengrass.componentmanager.ComponentManager.negotiateVersionWithCloud(ComponentManager.java:210)         at com.aws.greengrass.componentmanager.ComponentManager.resolveComponentVersion(ComponentManager.java:154)         at com.aws.greengrass.componentmanager.DependencyResolver.lambda$resolveDependencies$2(DependencyResolver.java:127)         at com.aws.greengrass.componentmanager.DependencyResolver.resolveComponentDependencies(DependencyResolver.java:225)         at com.aws.greengrass.componentmanager.DependencyResolver.resolveDependencies(DependencyResolver.java:125)         at com.aws.greengrass.deployment.DefaultDeploymentTask.lambda$call$2(DefaultDeploymentTask.java:105)         ... 4 more Caused by: com.aws.greengrass.componentmanager.exceptions.NoAvailableComponentVersionException: No applicable version found in cloud registry for component: 'aws.greengrass.Nucleus' satisfying requirement: '{aws.greengrass.Cli=>=2.1.0 <2.4.0, thing/ggv2sample==2.4.0}'.         at com.aws.greengrass.componentmanager.ComponentServiceHelper.resolveComponentVersion(ComponentServiceHelper.java:72)         at com.aws.greengrass.componentmanager.ComponentManager.lambda$negotiateVersionWithCloud$0(ComponentManager.java:198)         at com.aws.greengrass.util.RetryUtils.runWithRetry(RetryUtils.java:49)         at com.aws.greengrass.componentmanager.ComponentManager.negotiateVersionWithCloud(ComponentManager.java:197)         ... 9 more Caused by: software.amazon.awssdk.services.greengrassv2data.model.ResourceNotFoundException: Component aws.greengrass.Nucleus has no usable version satisfying requirements {aws.greengrass.Cli=>=2.1.0 <2.4.0, thing/ggv2sample==2.4.0} (Service: GreengrassV2Data, Status Code: 404, Request ID: 67041985-8d89-d6ed-0c7d-fa3dd45e1edc, Extended Request ID: null)         at software.amazon.awssdk.core.internal.http.CombinedResponseHandler.handleErrorResponse(CombinedResponseHandler.java:123)         at software.amazon.awssdk.core.internal.http.CombinedResponseHandler.handleResponse(CombinedResponseHandler.java:79)

The error applicable version satisfying requirement '{aws.greengrass.Cli=>=2.1.0 <2.4.0, thing/ggv2sample==2.4.0}' tells you that the deployment for thing/ggv2sample requires Nucleus version 2.4.0, but the version of CLI that you're deploying requires Nucleus >=2.1.0 <2.4.0. That means that there is a conflict because we cannot deploy both 2.4.0 and <2.4.0.
Update your CLI dependency to v2.4.0

thanks, seems like a massive update, i don't supposed you have a matrix for version compatibility in the docs?

All version dependencies are listed in the AWS Console when you view the public component.

you mean for the dependent component such as cli and local debug when you view them, they tell what nuclease they need, i'm talking the other way around, let's say i allready have an existing core installed, with 10 components, i would need to go on each one and examine it's dependencies  to know if i can upgrade the nuclease ..or upgrade them first.

There is no list going the other way. Nucleus and CLI always have the same version number. Other components bump the patch version to increase compatibility with a newer Nucleus version; this is why local debug console needs to be 2.2.2 instead of 2.2.1.
You can upgrade everything in a single deployment, you do not need to upgrade anything before anything else.

oh so basically every time i need to upgrade the nuclease i need automatically increment by one all the other components

Not necessarily, no. You can look at the version of the component which you are deploying and see if it depends on the Nucleus and if so what version. If it is not compatible with the new Nucleus, then get a newer version of the component.

thanks, one thing that always bothered me, is what happens if you have 2 cores with the same certificates and same thing, try to connect to the cloud, this is can be achieved if they reside on a vm which is being duplicated
(this also bothered me on greengrass v1)

That is not a supported use case. Using the same cert and thing will cause confusion and if running at the same time they will conflict with each other.

i know, my problem was how to detect such a case, this is why for my design i plan on using
https://man7.org/linux/man-pages/man5/machine-id.5.html as the id for the thing, the mqtt message will also include the current mac address the machine has so if i get 2 identical machine-id with a different macs i'll be able to alert this

Closing this issue since it appears to have been resolved now.

thanks for the help was trying to put together a started project for peer (without doing the automatic provision


Impl blocking read

Running strace on Kiro reveals that it polls every 100ms for an input
returning 0 if nothing was read. This pull request implements a blocking
read for noncanonical mode as specified in the canonical and
noncanonical section in the termios man page:
https://man7.org/linux/man-pages/man3/termios.3.html
This provides a more efficient reading of the input, by blocking after
an empty read of 0 bytes without wasteful polling cycles.

Figured out issue with this PR, was on rust nightly which caused the errors to unnecessary_wraps error to show up. Will close and re-open PR.


#57: Храненение счетчика сообщений в БД

Job gh:dronmdf/telebot#75 is in scope.

Job gh:dronmdf/telebot#75 assigned to @michaelo0, please go ahead (policy).

@michaelo0 this job was assigned to you 5 days ago. It will be taken away from you soon, unless you close it, see par.8.

Payment to ARC for closed pull request.: +15 points just awarded to @dronmdf, total is +990.

Order was successfully finished: +30 points just awarded to @michaelo0, total is +60.

Job gh:dronmdf/telebot#75 assigned to @sminux, please go ahead (policy).


⬆ 3.4.0

Prepare for 3.4.0 release.
Comparison to 3.3.0: https://github.com/ignitionrobotics/ign-gui/compare/ignition-gui3_3.3.0...ign-gui3
Should unblock https://github.com/ignitionrobotics/ign-gazebo/pull/456.

We're holding on this for a bit longer and will get a couple more PRs in first.


Add support for language code on URL

Closes #536

Discuss resolving the clash between using the languageId from the URL vs recovering a languageId from localStorage.

I think this has the right behaviour: a past choice via the language dialog is respected over the value on the URL.
I think that behaviour is subtle enough to deserve a e2e test. Other than flags we don't have anything that faffs with the URL, I'll have a look at the best way to add this to app.ts.


Fart over BLE

Would be awesome if it can be added to the protocol =)

Like the whoopee cushion feature. Or perhaps better yet with the horn fart feature? :D


Add test coverage report integration

Maybe coveralls?

Coveralls is very well but I looked, doesn't have integration snap-ci.

No problem for me, I can change that If you want to change to continuous integration

It does not matter for me also, but it can be good to add coverage report. What ever you like if you can add, add it bro.

I will research. I will change it that  If doesn't have another way.


[Bug]: Exchange backup fails if we can't enumerate service folders

What happened?
The case I investigated we got a 404 when attempting to get the user's calendars. This eventually caused the backup in CI to fail when merging backup details with the following error
tester.go:39: TestBackupOpIntegrationSuite/TestBackup_Run_incrementalExchange/delete_a_folder run at 2023-06-28T23:04:14.19626645Z
      backup_integration_test.go:1273:
          	Error Trace:	/home/runner/work/corso/corso/src/internal/operations/backup_integration_test.go:1273
          	            				/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.8.4/suite/suite.go:112
          	Error:      	Received unexpected error:
          	            	empty location key
          	            		/home/runner/work/corso/corso/src/internal/kopia/merge_details.go:81
          	            	getting new paths
          	            		/home/runner/work/corso/corso/src/internal/operations/backup.go:637
          	            	getting updated info for entry
          	            		/home/runner/work/corso/corso/src/internal/operations/backup.go:747
          	            	merging details
          	            		/home/runner/work/corso/corso/src/internal/operations/backup.go:357
          	            	running backup
          	            		/home/runner/work/corso/corso/src/internal/operations/backup.go:226
          	Test:       	TestBackupOpIntegrationSuite/TestBackup_Run_incrementalExchange/delete_a_folder

Fix
Always attempt to parse the location info from the old entry prior to lookup. Even for older backups we should have the invariant that either the LocationRef is non-empty or the RepoRef contains enough information to generate the old LocationRef
Priority of this is a bit unclear. Technically the backup should still fail overall because we couldn't backup something (calendars in this case), but properly handling this case can lead to better error messages in the long run and better best-effort behavior
Analysis
Connecting to the repo and dumping the details for the backup immediately before the failing one shows that the details entry has all the expected information. However, we appear to be failing on getting the information when backing up info. Not being able to get the info causes us to fail to merge later because we don’t have enough to do the lookup
Inspecting the logs for the failing backup shows a 404 when getting calendars (info trimmed and formatted for legibility)
2023-06-28T23:04:24.537Z  ERROR graph/middleware.go:176 graph api error: 404 Not Found  {
	"service": "Exchange",
	"category": "events",
	"resp_status_code": "404",
	"resp_content_len": "-1",
	"resp_status": "404 Not Found",
	"method": "GET",
	"url": "https://graph.microsoft.com/v1.0/users/aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee/calendars?$select=id,name&$skip=10&$top=10",
	"request_content_len": "0",
	"response": "HTTP/1.1 404 Not Found
{
	\"error\":{
		\"code\":\"ErrorItemNotFound\",
		\"message\":\"The specified object was not found in the store.\",
		\"innerError\":{
			\"date\":\"2023-06-28T23:04:24\",
			\"request-id\":\"37278584-159f-4ce3-b91c-dc0db4b55ae6\",
			\"client-request-id\":\"04ab5101-d45e-4d7d-99a4-b3249058436c\"
		}
	}
}"
}

The rest of the backup appears to proceed normally from there, but the backup still fails overall during details merging. The root cause is the assumption that all exchange folders will generate collections even if they aren’t changed. Having a collection allows us to get the location of the folder even if it’s merged. The location is then passed to streamBaseEntries and added as part of the information that’s eventually propagated to the merge handler when FinishedFile is called.
When looking up items for merging, we don’t attempt to extract location from Exchange right now. This leads to us calling GetNewPathRef with an empty old location. Overall, it causes the if-block in the lookup code to return an error because the information that we found has no location and no location was passed in for the lookup.
The merge code is currently setup to not attempt parsing a LocationRef in all cases. I don’t believe there’s really a reason not to attempt it. It should be possible to define the set of backups for which there will exist a LocationRef or from which we can parse the location from the RepoRef, much like we’re doing for OneDrive and SharePoint. That alone should solve the issue.
I believe the parsing checks would go something like the following:

calendar

< backup version 2 -> parse from RepoRef

= backup version 2 -> source from LocationRef

email and contacts

attempt to parse from LocationRef
if LocationRef is empty attempt to parse from RepoRef

The above is based on the fact that for email and contacts the following changes were made:

support for populating LocationRef was added in #2829 (2023-04-03)
switch to folder IDs was added in #3373 (2023-05-11)

This means that at all times either the LocationRef or the RepoRef for email and contacts should contain what we want for the LocationRef for unchanged items. Furthermore, since what will be used as the LocationRef is properly formatted (i.e. proper directory structure) when found in the RepoRef we don’t have to worry about additional code there. Also, no contacts are stored directly in the contacts prefix folder of the kopia hierarchy, so we shouldn’t have to worry about the LocationRef ever being empty unexpectedly
We could probably just treat calendars the same as well as either LocationRef will be empty or populated and I don't believe there was a time in-between where we had IDs in the RepoRef but empty LocationRef. Nor will events ever appear outside a calendar in the folder hierarchy
Corso Version?
any after ~May
Where are you running Corso?
N/A
Relevant log output
No response

I'm having a similar problem at one customer.
Backups of most (not all) exchange mailboxes fail after a long time.
Can't figure out if it's related to throttling or this error.
2023-06-30T03:54:12.566+0200    ERROR   backup/backup.go:263    Backup 1 of 1 failed    {"error"<EMAIL_ADDRESS>running backup: partial success: 17866 errors occurred", "errorVerbose": "running backup: partial success: 17866 errors occurred\n\t/home/runner/work/corso/corso/src/internal/operations/helpers.go:40\nx@y.de\n\t/home/runner/work/corso/corso/src/cli/backup/backup.go:235", "error_labels": {}, "resource_owner_name"<EMAIL_ADDRESS>"resource_owner_id": "585459f9-a212-4976-a464-fbed112fd53d"}
2023-06-30T03:54:13.091+0200    ERROR   cli/cli.go:181  cli execution   {"error": "1 of 1 backups failed:\n·<EMAIL_ADDRESS>running backup: partial success: 17866 errors occurred\n", "errorVerbose": "1 of 1 backups failed:\n·<EMAIL_ADDRESS>running backup: partial success: 17866 errors occurred\n\n\t/home/runner/work/corso/corso/src/cli/backup/backup.go:267", "error_labels": {}}
(END)
Unfortunately, not even the partial backups are saved so i need to restart from the beginning everytime.

hi @sub205, sorry to hear you're having trouble getting backups to complete
Unfortunately the log output above doesn't give much insight on the cause of the error, but checking the Corso logs should have more helpful information. The location of the log for an individual run is printed by Corso when it runs. You can send the Corso log to a specific location by passing the --log-file <location> flag to Corso (where <location> is where you want the log to go). Log files are appended to if Corso is given the same file for multiple runs. The --mask-sensitive-data and --log-level <level> flags may also be useful to make posting log output for debugging easier and to get more info on what's going wrong
If you have more log output you'd like help interpreting you can contact us on GitHub or on the Corso discord server if you'd like more immediate responses

Unfortunately, not even the partial backups are saved so i need to restart from the beginning everytime

yes, this is an unfortunate consequence of how incremental backups are implemented. We have a ticket open for improving this behavior so that only items that weren't already backed up on a previous attempt are pulled on the next attempt. We haven't yet had a chance to get around to those though

hi @sub205,
Just checking in to see if there's anything else you need help with on the issue you reported. Sorry for the long delay in checking back in, this got lost in the stack

Hi @ashmrtn ,
have been very busy with other projects, too.
Thanks for looking into this!
The problem still persists and is relatively urgent.
I'll provide you with the required logs later that day.
What's the best way to send them to you?

Even with mask-sensitive-data i get the original mailaddress/account id, tenant-id and other stuff in the logs :(

alright, I've made a ticket to get better coverage when using the --mask-sensitive-data flag to make sure we don't lose track of it
Debug level logs would be the most useful as they contain a lot more info about what's going on. Logs can either be shared on github (gist/comment/etc), emailed (my email is ashmrtnz (at) alcion.ai, obscured slightly in the hopes of better avoiding scrapers), or DM'ed to one of the Corso devs on the Corso discord. On discord the corso team has the team corso role


Unable to use dockers --network option without errors

Support guidelines

[X] I've read the support guidelines

I've found a bug and checked that ...

[X] ... the documentation does not mention anything about my problem
[X] ... there are no open or closed issues that are related to my problem

Description
I want to use this docker container behind anothers containers network.
Therefore i use dockers --network=container:othercontainer when running crazymax/rtorrent-rutorrent.
Expected behaviour
Everything should still work fine even if no ports are exposed or the container itself runs inside another containers network.
Actual behaviour
I'm unable to access the webinterface since rtorrent seems to be unable to bind the needed ports (see logs).
Obviously, with --network option i do not expose any ports and i'm not running anthing on 8000 either (althouth that shoudn't matter on the host). If i remove the option, everything works fine.
Steps to reproduce
docker run --network=container:somecontainer crazymax/rtorrent-rutorrent
Docker info
Client:
 Context:    default
 Debug Mode: false

Server:
 Containers: 42
  Running: 31
  Paused: 0
  Stopped: 11
 Images: 58
 Server Version: 20.10.14
 Storage Driver: overlay2
  Backing Filesystem: xfs
  Supports d_type: true
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 1
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 3df54a852345ae127d1fa3092b95168e4a88e2f8
 runc version: v1.0.3-0-gf46b6ba2
 init version: de40ad0
 Security Options:
  seccomp
   Profile: default
 Kernel Version: 5.15.46-Unraid
 Operating System: Slackware 15.0 x86_64
 OSType: linux
 Architecture: x86_64
 CPUs: 24
 Total Memory: 31.4GiB
 Name: Winston
 ID: VGZM:MTOE:LAON:MNVZ:RW2T:WHQJ:D4UC:KJEL:RNU6:JXAX:JX6E:N4VL
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: false
 Insecure Registries:
  <IP_ADDRESS>/8
 Live Restore Enabled: false
 Product License: Community Engine

Version
No docker compose
Linux Winston 5.15.46-Unraid #1 SMP Fri Jun 10 11:08:41 PDT 2022 x86_64 Intel(R) Xeon(R) CPU           X5675  @ 3.07GHz GenuineIntel GNU/Linux
Docker compose
no docker compose

Container logs
2022/09/09 23:47:12 [notice] 584#584: try again to bind() after 500ms
2022/09/09 23:47:12 [emerg] 584#584: bind() to <IP_ADDRESS>:8000 failed (98: Address in use)
nginx: [emerg] bind() to <IP_ADDRESS>:8000 failed (98: Address in use)
Additional info
No response

Running into the same situation, wondering if we can expect some workaround for this?

@Kuchiru not for me, i switched to qbit

I thought this might be resolvable with a firewall container though i have yet to try.

Same issue here. Switching the XMLRPC_PORT from 8000 does not fix it either. Still trying to bind that port and failing.


Clarifications on the Build process

I'm trying to dockerize to this repo so that it's really easy to get a new Haxall instance up and running. There are 2 options:

Make a Dockerfile that downloads the pre-bundled zip from the GitHub release and sets it up
Make a Dockerfile in this repo that performs the build process

I have done option 1 here, and it works fine. The big downside is that I must manually run the docker build/publish process on any newly released versions.
Option 2 is ideal, as it could be integrated into this repo's CI, and published to this repo's container registry automatically. I have an attempt in this commit on this branch that tried to follow the Build documentation. However, I ran into the following issues:

Overlapping files are created by the fantom, haystack-defs, and haxall build processes (specifically, .props and .pod files). It wasn't always clear whether the Haxall release zip had combined these, and if so which ones took precedence.
The web UI tables aren't able to render correctly. The browser console gave the following error Uncaught: Object { "$err": Error, m_msg: "FontMetrics not supported: 700 9pt Helvetica", m_cause: undefined }.

Could you provide guidance on the process used to generate the release zips?

The web UI tables aren't able to render correctly. The browser console gave the following error `Uncaught: Object { "$err": Error, m_msg: "FontMetrics not supported: 700 9pt Helvetica", m_cause: undefined }

Figured this out - it was a consequence of using an incompatible SWT.

Taking a look at your Dockerfile now and trying to reproduce. Then I should be able to give some guidance...

Hey @mgiannini! Mostly I was a little concerned that the final haxall directory didn't look the same between my Docker image and the release zip, and was hoping to get more details on the process followed to create the zip.
For example:

Files the zip release includes, that the docker image doesn't:

lib/fan/arcbeam.pod
lib/fan/hxClone.pod
lib/fan/hxCluster.pod

Files the docker image includes but the zip release does not

bin/nstub.exe
etc/syntax/*
sys/tz.js
lib/fan/icons.pod
lib/fan/webfwt.pod
lib/fan/webmod.pod
lib/fan/doc*.pod
lib/fan/test*.pod
A bunch of flux artifacts

Note: Some of these may be due to changes since the 3.1.7 release

We have a pretty custom build process for generating the final haxall.zip.  The code for those 3 pods is not part of haxall, so we have to "inject" them into the final zip. So you will probably need something in your Dockerfile that downloads the zip and extracts those 3 pods and copies them into lib/fan/.
The other things you will need to custom remove as part of your dockerfile.  It's probably not strictly necessary to remove them, but if you want the Docker image to exactly match the haxall zip you'll need to do some custom pruning.

Oh gotcha. Ok, if Haxall alone isn't able to generate the zip release, then I think just downloading the zip directly and configuring it (option 1 in my first message) is best, as opposed to trying to build it. Thanks for the information @mgiannini!


Create "docs" folder

Create a folder with a "README.md" explaining how to use every script.
Include an alternative way to open it (HTML?) so the user can view it after downloading the script package.
Include small gifs showing every script GUI.

Add supported nodes to path editor.


Translucent geometry not rendering as well as it used to?

Somewhere between 1.50 and 1.51 translucent geometry started rendering differently
1.50
https://cesiumjs.org/releases/1.50/Apps/Sandcastle/?src=CZML Custom Properties.html

1.51 and 1.52
https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/?src=CZML Custom Properties.html&label=All

@hpinkos @bagnell @lilleyse any ideas here?  I haven't bisected yet...

This might be specific to this example.  For example: http://localhost:8080/Apps/Sandcastle/index.html?src=CZML Rectangle.html&label=All seems to work (look at PA)

Got it, one sec


add dep vendorer & dummy fix test

Hello, I want to fix broken test and I added dep vendorer

Ok, thank for acquaintance me with vgo, I removed dep.

Thanks for the PR :)


_rdclk Doesn't work if there is no text

Hi Norm
We tested the rdclk keyword and there is an issue that it doesn't work if there is no text in the cell.  We have cells that only show data once it's been added using the pop up.  Do you think this could be done? It would be great if it took on the .knViewLink__label class and the icon from the target link too.  I think the cursor should change to the pointer as well.
This will be a great keyword.
Craig

Oh yes, you're right, I forgot to mention this and I had the same issue while developing it for Morbern.  In some cases, there's no text to show and the user had to click on a precise and invisible pixel in the cell to get it working, which is a pain.  So, I added an icon as a dummy target, but though it does offer a larger region to click on, it doesn't change to a finger pointer when hovered.
I guess I'll have to manually insert a "Click" text to cover that use case.  Or add a parameter to override the default with you own text.
ND

We really notice the the click target as we make our whole cell clickable across the app but it doesn't work on your link. I am sure we can update the css to work with your link though.

I've just realised we do this but in reverse. We replace the link text with the text from the hidden column. Is there a reason you didn't do it that way? It means that everything still works on the link like icons.

This is the function we use :
function replaceTextInGrid(viewId, sourceField, targetField) {
        const targetIndex = $(`#${viewId} .kn-table thead th.${targetField}`).index();
        const rows = $(`#${viewId} .kn-table tbody tr`);

        rows.each(function() {
            const span = $(this).find(`td:eq(${targetIndex}) span.knViewLink__label`);
            const text = $(this).find(`td.${sourceField}`).find('span').html();
            span.html(text).find('span').css('text-decoration', 'none');
        });
    }

Craig

Hi Craig,
I've revisited this feature and considered what you've proposed.  It makes sense.  And it's a lot simpler too.
But it led me to consider a much broader feature that I had in mind for a while, that would be an variation of the existing _cpyfrom keyword.
_cpytxt to copy text from one place to another in the scene.  From any field/view to any other, including from a column to another one in the same grid.  Would support Detail, Grid, Search and Form views.
That would be super powerful and address a lot of use cases that have been requested to me in the past, including the one I currently have with Morbern.
Food for thoughts...
Norm

Hi Norm
I think that's a great idea.  We do this quite a lot in forms.
It would be really good if the target input is a connection field and the source field has a connection id or class that would be used.
Craig


PageModels from different assemblies?

Hi there,
I think it'd better to separate the models for re-usability.
Did I miss something here but I couldn't get it to work if putting the page models on another assembly?
Thanks,
H

You need to use a custom pagemodel mapper in this case.

@rid00z Thanks, but I am pretty new to FreshMvvm - just an hour into it. So is there any example? or just a few lines snippet here would help. Cheers.

Closing this now as I have managed to resolve this by looking at the FreshPageModelResolver code. Cheers


Sq.StackInfos(..) incomplete implementation.

Sq.StackInfos(...)  - "Misc.cpp" Line 44
No Implementation of associated structure ("tagSQStackInfos" squirrel.h - Line 286) for .NET binding.

Implemented.


highlight crashes upon trying to iterate over a list of tags, "undefined"

While using this great plugin for codemirror, I encountered a case where tags is being assigned "undefined".  This results in the plugin crashing our editor. I was hoping we could get this fix pushed in for the next release. Please let me know if you think I'm missing anything that may result in this error. However, it still might be wise to account for "undefined" before iterating through the expected list. Thanks for all your contributions and we get a lot of great use out of your tools!!

The types forbid this function from being called with undefined, so the problem is elsewhere. Do you have a (simple) example script that triggers this error?

After further evaluation and digging, we were able to locate the actual source. There was a themed plugin we were using, react-theming/storybook-addon, that was pretty old. Once we updated the dependency, the patch was no longer required. We can close this.


[AzureMonitorExporter] fixing nullables

I'm trying to make a dent into the nullables in our Exporter.
Starting in the Internals directory and focusing on some of the smaller classes.
Note: this PR can wait until after the beta7 release.
Changes

remove #nullable disable and resolve issues as discovered.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Monitor.OpenTelemetry.Exporter

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Monitor.OpenTelemetry.Exporter

Should be able to ignore this.
I removed the changes that required the API review and the CI is all passing.


use default value for the disk low watermark setting.

Accordingly to the Crate documentation the
cluster.routing.allocation.disk.watermark.low
setting defaults to 85%.

lgtm


Run datafixers

See original RS1 issue:
https://github.com/refinedmods/refinedstorage/issues/1572

As clarification does this ticket include an api for addons to register blocks for datafixers or should they handle it themselfs?

I had a look at it and the api changed in minecraft, also the forge api seems to not exist anymore. I was also unable to find information regarding the new api


Try to fix windows self-update

cc #1351
I think this will only fix portable Lapce because the install directory might be read-only, but we'll see.
This PR fixes the issue that an exe can't delete itself, which makes self-update on Windows fail on the extract step.

Codecov Report

Merging #1395 (f9e4dbe) into master (cdc6abb) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1395      +/-   ##
=========================================
- Coverage    5.31%   5.31%   -0.01%
=========================================
  Files         123     123
  Lines       48583   48585       +2
=========================================
  Hits         2580    2580
- Misses      46003   46005       +2

Impacted Files
Coverage Δ

lapce-data/src/hover.rs
0.00% <0.00%> (ø)

lapce-data/src/update.rs
0.00% <0.00%> (ø)

lapce-ui/src/app.rs
0.00% <ø> (ø)

lapce-ui/src/hover.rs
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Localization Result

Hi, I have question regarding the localization result. I have two cases:

Query images is same with the database image (just want to check the pipeline is works or not)
Query images is different (not that much) with the database.

The first case went well. The pipeline succeed to localize all query image. But somehow in 2nd case, from 393 query images only 320 images that succeed to localize. I checked the pair file and those missing query pair do not have pair in db images instead having the pair on query image itself. In this kind of case, how can we calculate the accuracy of our localization result? Do we just ignore the 73 images?
The figure below shows the pair list. Frame 333 and 243 is not written on the localization result

How do you generate the image pairs? are you using pairs_from_retrieval? If so, you need to explicitly generate pairs from queries to map:
pairs_from_retrieval.main(
    descriptors_path, pairs_path, num_pairs, query_prefix='query', db_prefix='frame')

Thanks! It solved now!


TNM-020 - Display uncited notes (LEAN-3377)

one of the TNM-020 requirements is to make sure the uncited footnotes in table-footnotes are at the end of the list

@hhusban I changed the process of sorting from jatsBodyTransformations to the decode. as when we decode modelMap again there is nothing to tell about order of elements


Temperature Forecast

Is it possible to add minimum temperature forecast? The plugin only shows maximum temperature forecast. I want to use the plugin for indicating frost forecast.

Sure, I will look into this in the upcoming week.

Here you go: Version 1.1.0
You can update the plugin with sudo npm update -g homebridge-weather-station-extended


Off-by-one error on listen and mute

When calling this.index = Store.listen(onUpdate), the return value is 1 if this is the first callback pushed since .push returns the new length of the array. So, when you call Store.mute(this.index), you're calling this.callbacks.splice(1,1), which will not remove the onUpdate callback since it's at index 0. Will submit a PR for this.

This should be closed now


odo catalog describe service broken

/kind bug
What versions of software are you using?
Operating System: Win10Pro
Output of odo version:
odo v2.2.4 (f12e036b5)

Server: https://api.crc.testing:6443
Kubernetes: v1.20.0+df9c838

How did you run odo exactly?
odo catalog service describe myoperator
Actual behavior
X  unable to search classes by name (clusterserviceclasses.servicecatalog.k8s.io is forbidden: User "developer" cannot list resource "clusterserviceclasses" in API group "servicecatalog.k8s.io" at the cluster scope)
Expected behavior
operator should be described
Any logs, error output, etc?

X unable to search classes by name (clusterserviceclasses.servicecatalog.k8s.io is forbidden: User "developer" cannot list resource "clusterserviceclasses" in API group "servicecatalog.k8s.io" at the cluster scope)

I can reproduce this on 2.2.4. However, I think #4906 would take care of it because it drops support for Service Catalog. Building odo from that PR works as below:
$ odo catalog list services
Services available through Operators
NAME                                CRDs
etcdoperator.v0.9.4-clusterwide     EtcdCluster, EtcdBackup, EtcdRestore
redis-operator.v0.6.0               RedisCluster, Redis

$ odo catalog describe service myoperator
 ✗  no deployable operators found

$ odo catalog describe service etcdoperator.v0.9.4-clusterwide
 ✗  no deployable operators found

$ odo catalog describe service etcdoperator.v0.9.4-clusterwide/EtcdCluster
Kind: EtcdCluster
Version: v1beta2
Description: Represents a cluster of etcd nodes.
Parameters:

 PATH           DISPLAYNAME            DESCRIPTION

 size           Size                   The desired number of member
                                       Pods for the etcd cluster.
 pod.resources  Resource Requirements  Limits describes the
                                       minimum/maximum amount
                                       of compute resources
                                       required/allowed

Do you think this works as you would expect?
For below, we are tracking it in https://github.com/openshift/odo/issues/4786:
$ odo catalog describe service etcdoperator.v0.9.4-clusterwide
 ✗  no deployable operators found

Yes I just wanted to report it in case odo team missed it. Feel free to close

Yes I just wanted to report it in case odo team missed it. Feel free to close

Thanks, Jeff! 👍🏾
I'll update #4906 so that when it gets merged, this issue gets closed.


Update stream-analytics-user-assigned-managed-identity-overview.md

added scenarios & limitations

Docs Build status updates of commit ffaea75:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/stream-analytics/stream-analytics-user-assigned-managed-identity-overview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[SPARK-32703][SQL] Replace deprecated API calls from SpecificParquetRecordReaderBase

What changes were proposed in this pull request?

Currently in SpecificParquetRecordReaderBase we use deprecated APIs in a few places from Parquet, such as readFooter, ParquetInputSplit, new ParquetFileReader, filterRowGroups, etc. This replaces these with the newer APIs. In specific this:

Replaces ParquetInputSplit with FileSplit. We never use specific things in the former such as rowGroupOffsets so the swap is pretty simple.
Removes readFooter calls by using ParquetFileReader.open
Replace deprecated ParquetFileReader ctor with the newer API which takes ParquetReadOptions.
Removes the unnecessary handling of case when rowGroupOffsets is not null. It seems this never happens.

Why are the changes needed?

The aforementioned APIs were deprecated and is going to be removed at some point in future. This is to ensure better supportability.
Does this PR introduce any user-facing change?

No
How was this patch tested?

This is a cleanup and relies on existing tests on the relevant code paths.

Test build #127896 has started for PR 29542 at commit 9794083.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32522/
Test PASSed.

Test build #127896 has finished for PR 29542 at commit 9794083.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127896/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32524/
Test PASSed.

Test build #127899 has started for PR 29542 at commit 853d968.

Test build #127899 has finished for PR 29542 at commit 853d968.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127899/
Test FAILed.

Test build #127900 has started for PR 29542 at commit d797ab1.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32526/
Test PASSed.

Test build #127900 has finished for PR 29542 at commit d797ab1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127900/
Test FAILed.

Test build #127970 has started for PR 29542 at commit b6f9355.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32596/
Test PASSed.

Test build #127970 has finished for PR 29542 at commit b6f9355.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127970/
Test PASSed.

@HyukjinKwon this PR is ready - can you please take another look? Thanks!

Parquet reader is performance-wise important component in Spark SQL. We better to make sure no performance regression due to this change. Should we run a benchmark to check it?

Sure let me do that. Should I just run DataSourceReadBenchmark?

Parquet reader is performance-wise important component in Spark SQL. We better to make sure no performance regression due to this change. Should we run a benchmark to check it?

@viirya So I used FilterPushdownBenchmark for this and I don't see much difference. Taking the first few:
Before:
[info] OpenJDK 64-Bit Server VM 11.0.8+10-LTS on Mac OS X 10.15.5
[info] Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
[info] Select 0 string row ('7864320' < value < '7864320'):  Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
[info] -----------------------------------------------------------------------------------------------------------------------------------
[info] Parquet Vectorized                                            5632           5752         120          2.8         358.1       1.0X
[info] Parquet Vectorized (Pushdown)                                  491            506          18         32.0          31.2      11.5X
[info] Native ORC Vectorized                                         4300           4335          25          3.7         273.4       1.3X
[info] Native ORC Vectorized (Pushdown)                               525            530           6         30.0          33.4      10.7X

[info] OpenJDK 64-Bit Server VM 11.0.8+10-LTS on Mac OS X 10.15.5
[info] Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
[info] Select 1 string row (value = '7864320'):  Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
[info] ------------------------------------------------------------------------------------------------------------------------
[info] Parquet Vectorized                                 5594           5757         101          2.8         355.7       1.0X
[info] Parquet Vectorized (Pushdown)                       472            491          14         33.3          30.0      11.9X
[info] Native ORC Vectorized                              4320           4387          42          3.6         274.7       1.3X
[info] Native ORC Vectorized (Pushdown)                    512            524           8         30.7          32.6      10.9X

After:
[info] OpenJDK 64-Bit Server VM 11.0.8+10-LTS on Mac OS X 10.15.5
[info] Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
[info] Select 0 string row ('7864320' < value < '7864320'):  Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
[info] -----------------------------------------------------------------------------------------------------------------------------------
[info] Parquet Vectorized                                            5539           5635          87          2.8         352.1       1.0X
[info] Parquet Vectorized (Pushdown)                                  456            461           6         34.5          29.0      12.1X
[info] Native ORC Vectorized                                         4243           4282          35          3.7         269.8       1.3X
[info] Native ORC Vectorized (Pushdown)                               511            523          13         30.8          32.5      10.8X

[info] OpenJDK 64-Bit Server VM 11.0.8+10-LTS on Mac OS X 10.15.5
[info] Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
[info] Select 1 string row (value = '7864320'):  Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
[info] ------------------------------------------------------------------------------------------------------------------------
[info] Parquet Vectorized                                 5509           5576          55          2.9         350.2       1.0X
[info] Parquet Vectorized (Pushdown)                       462            475           8         34.1          29.4      11.9X
[info] Native ORC Vectorized                              4230           4294          44          3.7         268.9       1.3X
[info] Native ORC Vectorized (Pushdown)                    501            510          11         31.4          31.8      11.0X

Thanks @HyukjinKwon - this is good to know. Since it seems Spark could take a while to get to 1.11, should I close this for now then?

@sunchao, I would just close for the time being, and bring it back when the upgrade is done. But I don't mind leaving it open if you prefer it for any reasons.

Thanks again @HyukjinKwon . Closing this for now.

Re-open this since Spark has upgraded to Parquet 1.11 :-)

Re-open this since Spark has upgraded to Parquet 1.11 :-)

Test build #134663 has started for PR 29542 at commit b6f9355.

Test build #134663 has started for PR 29542 at commit b6f9355.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39250/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39250/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39250/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39250/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39250/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39250/

Test build #134663 has finished for PR 29542 at commit b6f9355.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Test build #134663 has finished for PR 29542 at commit b6f9355.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134663/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134663/

Test build #134671 has started for PR 29542 at commit 00dbac4.

Test build #134671 has started for PR 29542 at commit 00dbac4.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39258/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39258/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39258/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39258/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39258/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39258/

Test build #134671 has finished for PR 29542 at commit 00dbac4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134671 has finished for PR 29542 at commit 00dbac4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134671/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134671/

This can go ahead because of the Parquet 1.11.1 update?

This can go ahead because of the Parquet 1.11.1 update?

Yeah, because there was a resource leak problem (https://github.com/apache/spark/pull/29542#pullrequestreview-478269264) that's fixed in Parquet 1.11.

Yeah, because there was a resource leak problem (https://github.com/apache/spark/pull/29542#pullrequestreview-478269264) that's fixed in Parquet 1.11.

cc @cloud-fan and @gatorsmile too

Jenkins retest this please

Test build #135115 has started for PR 29542 at commit 00dbac4.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39697/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39697/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39697/

Test build #135115 has finished for PR 29542 at commit 00dbac4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135115/

Merged to master

Thanks all for reviewing and merging!

Hi, all. Sorry for my late comment. It seems some TPCDS queries (e.g., q9, q54, q31, .... See this for more details) got slower after merging this commit. Are they expected performance changes? For example, I've checked the peformance of TPCDS q9 with/without the commit;
// The current master
OpenJDK 64-Bit Server VM 1.8.0_265-b01 on Linux 4.14.203-156.332.amzn2.x86_64
Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz
TPCDS Snappy:                             Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
q9                                                59071          59510         622          0.0<PHONE_NUMBER>.2       1.0X

// Revert this commit
OpenJDK 64-Bit Server VM 1.8.0_265-b01 on Linux 4.14.203-156.332.amzn2.x86_64
Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz
TPCDS Snappy:                             Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
------------------------------------------------------------------------------------------------------------------------
q9                                                28963          29057         132          0.0   804530503.1       1.0X

Let's revert this for now. I think this is related to what I have observed. Thanks for catching this @maropu

Reverted at https://github.com/apache/spark/commit/80bad086c806fd507b1fb197b171f87333f2fb08

Yea, thanks, @HyukjinKwon

Interesting. I'll take a look on the issue. Thanks for reporting.

That's fine, but the benchmarks here seemed to show it was an improvement at least for the tests that were run. I wonder what TPC-DS covers that is different.

Yeah, it's fine. Thanks for taking a look @sunchao. We should get rid of this deprecated usage eventually in any event.

Thank you for reporting and reverting, @maropu and @HyukjinKwon .

I tried @LuciferYang 's suggestion with TPC-DS benchmark and it fixed the perf regression. For instance, in the q9 above, here's what I got:

without the PR
with the PR
with the PR + requestSchema fix

5940
11260
5281

I've gathered all the results in this gist. The benchmark was run with scale factor 5.
@maropu @HyukjinKwon @srowen let me know what you think. I can update this with the fix.

Sounds good!

Thanks, @sunchao! After the fix applied, I'll check the performance on my env, again.

Opened #31667 with the fix. Comparing to the old PR there's only one line change:
reader.setRequestedSchema(requestedSchema);

Please take a look. Thanks!


Pull in https://github.com/fluxcd/flux2/blob/main/install/flux.sh

https://toolkit.fluxcd.io/install.sh is currently where folks get their flux binary from.
Let's make sure we provide this as well - https://github.com/fluxcd/flux2/blob/main/install/flux.sh is the source.

This would also require a change in the documentation to advertise the new URL.

Yes....

Provide script
Make sure redirects work
Update docs to new URLs

🙈


Y2K38 Epochalypse

Describe the enhancement requested
https://en.wikipedia.org/wiki/Year_2038_problem
Can we add support for date64[day]?? Right now we can only use date64 for milliseconds..
Component(s)
C++, Python

date32[day] is the number of days since 1970-01-01. This will overflow int32 at year ~ 5.5 million ... So there's no need for a date64[day].

Ok thanks..


In which file, modify the output layer of the migrated pre-trained model?

@hjl-2548951848 in graph.py.


Add tests for pull-request-list-item

100% coverage :tada:
Also added 1 more test to search behavior and fixed formatting.

Tests are looking good.


Add a new page for showcasing projects, projects.html

Create a new page where we can list the projects made by our members.
It will include a list of projects where each project will have details like

Name of the project
Name of the creator(s)
Relevant image/video of the project
Link to the source code/website/app (if live)

It will also include a section where students can request their project to be showcased. Add details like

Small text
Button which will redirect to a new form

You can either do it from the beginning to the end or a part of it. Let me know!

Hey,
Can you assign us this issue? It looks good for us.I along with damikdhar are planning to do the same!

Yes it would be great for me to work with @the-agarwal01 in this project!

Okay then both of you can collectively work on this and work on separate parts so that you both can contrbute


chore: CODEOWNERS

Closes #74

#75  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on  Graphite


Update de_DE.po (50%)

approx. 50% of all terms translated into german

I will resolve the merge conflicts in the am

Hi Simon, I reverted my last change, merged the file with the latest CT/beta version and commited it again. The conflicts are gone now.

I've still got conflicts sadly.

Actually couldn't see any conflicts when I merged....


Create and edit text files

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
It'd be interesting to be able to create text files and edit them! We already have the editor for the config. We just need to... reuse it 😄
Describe alternatives you've considered
Edit/update files via the command line?
Additional context
N/A

cc https://github.com/ipfs/ipfs-gui/issues/69 :^)


Dom0 add generation zephyr domu images and Unicraft sample image

Hence SD-card support is added the Zephyr guest domain images need to be
present on SD-card, so add generation of sync and blinky images.
Add unikernel monkey sample image binary to Dom0 storage for demo purposes.
Images stored in default for zephyr-dom0-xt folder "/dom0" on SD-card.

Overall I thinks this is fine from my stand point and I don't see how this can be done better. But I think that this requires more integration work, such as zephyr-dom0 configuration update to enable unikernel monkey configuration. And as I can see from the implementation - unikernel accessible only from usb mode.
Also please do rebase and resolve conflicts

Rebase done

LGTM Reviewed-by: Oleksii Moisieiev<EMAIL_ADDRESS>


RHUI: also pin CDS packages

We are pinning both rhui-installer and rhui-tools in #2009; but we must also pin these CDS packages because they are not version locked or depended on, and newer versions expect the content from the newer rhui-installer and rhui-tools packages.

/lgtm


Fix/snowflake privatelink external url

Change private link url to match proper format. Before view in snowflake results in Connection denied Snowflake cannot be accessed from your current network connection (<IP_ADDRESS>). Contact your security administrator.
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@matthew-coudert-cko have you gotten a chance to look at @mayurinehate's comments?

Closing due to inactivity


Mount different things over the same mapfile

Hi!
I'm using your puppet class with foreman, i'm having a problem. I can't set two mounts for the same mapfile, example:
/etc/auto.master content:
/- /etc/auto.example.com
/etc/auto.example.com content:
/example -fstype=cifs,rw ://example01.com/example
/example2 -fstype=cifs,rw ://example01.com/examplee
Now, i can't do that with foreman and neither from puppet in cli.
I think the options maybe is "mount_files", but you in the comments put " A hash of files to populate and include in auto.master", or could config_file, but thats other parameter.
Can you guide me and explain me, how i should do this that? Or is a feature that your class dosen't have?
Regards!
Leandro.

This is supported. You simply add another entry in the hashmap argument.
The Foreman uses hiera for supplying parameters, so the input is the same as before (hash value), but the syntax is slightly different. I've also updated the README.md to show multiple entries in the hashmap

Not working, I did the thing you told me, but is not working yet.
I put the config in type yaml, foreman accept syntax, but if I put in hash, not import the way I worte, they say thats wrong.
And when I wrote two entrys on foreman in mounts, he delete me one of they, for example, if I type within mounts:
'myexample.com':
remote: 'nfs:/example01.com/example'
mountpoint: '/remote/server01
options: 'soft, ro'
'myexample.com':
remote: 'nfs:/example01.com/example2'
mountpoint: '/remote/server/010'
options: 'hard, rw'
or even:
'myexample.com':
remote: 'nfs:/example01.com/example2'
mountpoint: '/remote/server/010'
options: 'hard, rw'
'examples.org':
remote: 'nfs:/server.example.com/test'
mountpoint: '/server/remote/examples'
options: 'hard, rw'
Always foreman delete one of the entrys, even if they are correct.
Do you have idea why this not work? If i did commit a mistake, can you correct me? Or give me a example that works for you in foreman?
Thanks a lot!
And if you can't understand something, please talk me, english isn't my native language.
Regards!
Leandro.


Town Hall Slides -  Wednesday, 02th March, 2022

Townhall slides -  Wednesday, 02th March, 2022

Previous Town Hall - https://github.com//Catalyst-Circle/Catalyst-Circle-Coordination/issues/
CC Admin meeting -

[ ] Prepare Town Hall slides for Wednesday

Next in series: #67


Summary by Sourcery
Add the initial commit for the software-properties-station application, providing a GUI and CLI for managing GhostBSD package repositories, along with detailed documentation on usage and architecture.
New Features:

Introduce a graphical and command-line application for managing package repositories on GhostBSD, featuring a GTK-based GUI and CLI options.
Add functionality for validating repository configurations and logging actions and errors for troubleshooting.

Documentation:

Add a comprehensive README.md detailing the features, requirements, installation, usage, configuration, and logging of the software-properties-station application.
Include an ARCHITECTURE.md file explaining the application's architecture, module responsibilities, flow, error handling, and future improvements.

Sourcery-ai is only to help. I just wanted to let you know that not all subjection will be helpful.


Draw polygon with mousemove

Would be great if user clicks on polygon-editor button on toolbar, and draw polygon without those points, (I can not explain)
He just draws a polygon and presses done button, not the way he would click on the first point of polygon, (if you try Zillow- Rents app from AppStore you will understand what i mean, they have that feature that user can simply draw area, not neccesarily to multiple clicks on map, and press ok)

Have a look at https://github.com/Wildhoney/Leaflet.FreeDraw for a free draw feature.


Roll Engine from d7c98913ed9c to cda505ca7abb (6 revisions)

https://github.com/flutter/engine/compare/d7c98913ed9c...cda505ca7abb
2020-08-08<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from jcM1jpYio... to ne1pZMKkO... (flutter/engine#20359)
2020-08-08<EMAIL_ADDRESS>Roll Dart SDK from 92315c4b2dc2 to 570a75be7ea5 (1 revision) (flutter/engine#20358)
2020-08-08<EMAIL_ADDRESS>Roll Dart SDK from 594434d5a0b5 to 92315c4b2dc2 (1 revision) (flutter/engine#20356)
2020-08-08<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from dYgZG38fw... to OdkmMFP06... (flutter/engine#20355)
2020-08-08<EMAIL_ADDRESS>Roll Dart SDK from 0aa5b0f019b9 to 594434d5a0b5 (2 revisions) (flutter/engine#20354)
2020-08-08<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from 0Pffy4ES2... to jcM1jpYio... (flutter/engine#20353)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from dYgZG38fwmvX to OdkmMFP06epK
fuchsia/sdk/core/mac-amd64 from 0Pffy4ES28fC to ne1pZMKkO_mX
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


PublishCodeCoverageResult is broken for JaCoCo after Autogenerate HTML reports for Code Coverage #9704

Publishing of JaCoCo coverage results is broken after #9704.
If you have a look at https://github.com/Microsoft/azure-pipelines-tasks/pull/9704/files#diff-3afbe858d80311a2afe7be02b22dedd4R87 it uses 'tempFolder' variable as report directory but the only place it's value is defined is inside of this 'if' https://github.com/Microsoft/azure-pipelines-tasks/pull/9704/files#diff-3afbe858d80311a2afe7be02b22dedd4R44. Note that autogenerateHtmlReport is
let autogenerateHtmlReport: boolean = codeCoverageTool === 'Cobertura';

so effectively this PR broke publishing of JaCoCo reports.
It's also strange that changing functionality in not backward compatible way(and removing the option to provide your own report directory and forcing to have dotnet installed is not in any way backward compatible change) resulted in change of a minor part of a semver version.

@in4margaret, We have a fix ready for this, for jacoco to work with autogenerated html reports, you have to specify path to source files as well. We've added this field in the publish code coverage task

Closing this thread, if you're still facing problems, please create a new issue referencing this thread.


Conflict with other VS Code extensions?

Hi Andy,
On my install of VSCode (Mac OS X, version 1.67.0), when, on a new line, I start typing hook_form I see the list of matching hooks appear, when I select one and hit "enter", I get the following:
hook_form_alter()

But, when I type function hook_form and then select the same hook, I get:
function /**
 * Implements hook_form_alter().
 */
function drupaleasy_repositories_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $form_state, $form_id) {

}

(including the initial function above the comment)
I believe this is being caused by some type of conflict with the PHP Intelephense extension (which I also have installed). When I disable PHP Intelephense, I get the correct behavior from Drupal Smart Snippets. Any idea if there's anything that can be done either on my end with a config change or in your extension to fix this?
thanks,
-mike

Hey @ultimike!
I think this is a VS Code specific setting, see the intellisense documentation

By default, VS Code pre-selects the previously used suggestion in the suggestion list. This is very useful as you can quickly insert the same completion multiple times. If you'd like different behavior, for example, always select the top item in the suggestion list, you can use the editor.suggestSelection setting.

Also, see the editor.snippetSuggestions setting - this is the one I use to always float snippets to the top of the list. This might be less helpful for someone that uses intelliphense heavily.

By default, VS Code shows snippets and completion proposals in one widget. You can control the behavior with the editor.snippetSuggestions setting. To remove snippets from the suggestions widget, set the value to "none". If you'd like to see snippets, you can specify the order relative to suggestions; at the top ("top"), at the bottom ("bottom"), or inline ordered alphabetically ("inline"). The default is "inline".

Ah - makes sense. Thanks so much. I just added the following to my settings.json:
    // Use this to prioritize Drupal Smart Snippets in the UI.
    "editor.snippetSuggestions": "top",

-mike

Re-opening as something has changed - the "editor.snippetSuggestions": "top", trick isn't working anymore. In fact, unless I completely disable PHP Intelephense extension, I don't see the Drupal Smart Snippets snippets.
Perhaps a recent PHP Intelephense update broke something?
thanks,
-mike

There appear to be a couple of other issues on the intelephense repo suggesting it's broken autocomplete, for example: https://github.com/bmewburn/vscode-intelephense/issues/2493

https://github.com/bmewburn/vscode-intelephense/issues/2495

This was an issue with VS Code 1.75.0, and should be fixed as part of 1.75.1
https://github.com/microsoft/vscode/issues/173244#issuecomment-1420986719


Refine/leverage

feat: leverage flash loan base token instead of collateral token
feat: add leverage integration test

LGTM

LGTM


Pick-2.0 fix match null for no index

Proposed changes
Issue Number: close #xxx
pick from #26983
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Fix router logic

If the class does not extend from CI_Controller, you can not access via Route

Controllers not extending CI_Controller won't work either way ... this is not necessary.

It is not necessary but it will be more rigorous.


Fix timeout bug and enable Datadog tracing

Description
The API is already using commit b25809e, so the only real change here is fixing Datadog tracing. However, I'm opening the PR so it's easy to CR and so we can merge all of it into master if we want.
Total changes:

Fix a bug which could make Dataloader crash when a request timed out
Allow a configurable Task module, so we can use Datadog.Tracer instead of the native Task within our repos.

Motivation and Context
We want to trace dataloaded queries. Right now there's no connection between the API call which uses dataloader and the underlying Rails or Ecto calls from within the load functions.
Testing
Test as part of the corresponding API PR, TheRealReal/api#1762
Type of Changes

[x] Bug fix (a non-breaking change which fixes an issue)
[x] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that changes existing functionality)
[ ] Bump dependencies
[ ] Automated Testing / Missing tests
[ ] Documentation

Checklist:

[ ] Yes, I have added tests to cover my changes.
[ ] No, We don't have a test suite in this project yet.
[ ] My change requires a change to the documentation.
[ ] My change requires release strategy (uncomment the Release strategy below)

cc/ @TheRealReal/buyer-purchase

The API's been using this successfully for a while now, so I'll merge this PR in.


Make C/C++ example filenames consistent

The build command previously had different names for the C/C++ examples as the example file had. This corrects the error.

Thankyou!


Change MKOB title bar and file extension

Changed MKOB 1.0.0 to MorseKOB 4.0.0 in title bar and setup.py.  Also added license to setup.py.
It seems like a bad idea to have the version number in two separate places (MKOB.py and setup.py) but I don't know how to avoid this. If anyone has a better way we can fix it now, or I can open an issue to be dealt with later.

Can this be closed?

Can this be closed?

Hopefully it's closed now. Let me know if there's still a problem.


centered heading

Bugreport:
Bug reported by Wandi
What is the title of your bugreport?: centered heading
Is it a bugreport for the website or for the bot?: Website
How can you reproduce the bug? (Explain in steps): go to www.lenoxbot.com and have a look at the header
Which result would normally have to be?: I think "LenoxBot" and different tasks should be on one line. Noe "LEnoxBot" and the tasks are on two different lines --> http://prntscr.com/kuh2ks
What happens if you do the action now?: same again
ReportID: 39

➤ LenoxBot commented:
Approve:
Could be reproduced
Nickkel#6515

➤ LenoxBot commented:
Approve:
could be reproduced
Dadi#7808

➤ LenoxBot commented:
Approve:
reproducible
Denarioyt#3352


Remove warning output from QEMU command.

The command to run QEMU produces an output, but the output and
its message is not needed to complete the tutorial.

Thanks! I agree that we don't need to include the warning there.


Vertical Performance Updates May 9th - Jun 24th

Vertical Performance Updates May 9th - Jun 24th
Encompassing Changes from #101
#98
#108
#109
#110
#111

Good Job!


Update plugins and documentation

Now with API docs!

Current coverage is 47.3%

Merging #4 into master will increase coverage by +3.20% as of 7099367

Powered by Codecov


Tests getting memory issues/seg faults

After adding the ignore hidden test we are getting more memory or seg fault issues on travis. May not be closing things correctly in that test.

Took out this test for now. Still could not figure out what I wasn't closing.


Mark some "common" stackframes as not "in_app".

I was wondering if it would be relevant to use the in_app parameter in the stacktrace interface in order to hide some of the most common stackframes.
The IDE I use for example automatically hides some parts of the stacktrace such as the java.* or com.sun.*.
Any thoughts?
Settings in IntelliJ (actually those are places where the debbuger won't try to step into, but the first elements of the list are relevant to that issue)

I would love it! :heart:

This is configurable by subclassing DefaultRavenFactory: https://github.com/getsentry/raven-java/blob/cd55661ac830e3590a9216bb965c38f67710a6d7/raven/src/main/java/com/getsentry/raven/DefaultRavenFactory.java#L335-L351
I think some more common namespaces should probably be added, though.

We're considering switching it from a blacklist to a whitelist. Default to nothing and urge users to tell us what namespace their app is in.

We did this in order to group stacktraces together and it resulted in better cohesiveness.  In fact, we're considering adding our 'in-app' stacktrace as a fingerprint.

@ehthayer when you say you did "this" do you mean switching it to a whitelist?

yes, we switched to a whitelist so that the stacktrace paths we used in our hashing became more focused and less prone to incidental splittling.

Great, thanks, it's good to hear that worked. I plan to switch the official SDK to do the same soon.

Some more discussion of using this in event fingerprinting: https://forum.sentry.io/t/fingerprinting-with-whitelisted-stacktrace-class-and-line-number-path/938

This was changed to a whitelist here: https://github.com/getsentry/raven-java/commit/27a66682410ff61c542c979bb31e5473758e027c
To be released in 8.0.0 in the next ~week I hope.


use Repository contract as type hint

Some user might extending the default laravel config by implementing the \Illuminate\Contracts\Config\Repository interface, like this package (https://github.com/illuminatech/config)
By updating to Repository contract, any users that extending the default laravel config are able to use this package.

Thanks!


Rename notebook from "Predicting_bike_sharing_data.ipynb" to "Your_first_neural_network.ipynb"

Please rename the file for Bike sharing prediction jupyter notebook from "Predicting_bike_sharing_data.ipynb" to "Your_first_neural_network.ipynb"
If not renamed , then when submitting project from terminal on windows using command Udacity Submit , it gives
"FileNotFoundERROR" : There is no Your_first_neural_network.ipynb file found.

I opened a PR for this issue.


Readme

English:
Submit a new demo!
Current Translation:
Envoyez une nouvelle démonstration !
Suggested Translation:
Envoyez une nouvelle démo.
Description:
As a general rule, please translate "demo" as "démo" and "demonstration" as "démonstration"

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Run the bugfix tool and waiting for result. ICMS QUERY


Add dependencies for text VS project

Thank you! Is this related to the failed VS build for #113 ?

Yes, that PR fails because master was failing.


Generate unique constraints instead of unique indexes for @unique

Bug description
Marking a column as @unique generates a CREATE UNIQUE INDEX statement.
However, per the PG docs, it's preferred to use unique constraints instead:

Note: The preferred way to add a unique constraint to a table is ALTER TABLE ... ADD CONSTRAINT. The use of indexes to enforce unique constraints could be considered an implementation detail that should not be accessed directly. One should, however, be aware that there's no need to manually create indexes on unique columns; doing so would just duplicate the automatically-created index.

AFAIK there's not really a behavioral difference, but seems best to match Postgres best practices.
How to reproduce

Mark a column as @unique
Generate a migration script
Notice that the script has CREATE UNIQUE INDEX

Expected behavior
The migration script should use ALTER TABLE ... ADD CONSTRAINT to enforce uniqueness instead. This will still generate a unique index.
Prisma information
N/A
Environment & setup

Database: Postgres

Prisma Version
3.15.2

We also need this to leverage deferrable constraints (indexes can never be deferrable).

Hi!
First of all, thanks for the amazing job you're doing with Prisma!
Another use case relying on the presence of the CONSTRAINT and not only the INDEX in Postgres is when upserting:
INSERT INTO my_table (my_unique_column) VALUES (...) ON CONFLICT ON CONSTRAINT my_constraint DO UPDATE SET ...
With the INDEX only, it errors with constraint "my_constraint" for table "my_table" does not exist.
Hope this helps somehow

(Deferrable indexes and constraints are tracked as a feature requests at https://github.com/prisma/prisma/issues/3502)

@thzubeli You can use ON CONFLICT (field1, field2) of your unique index instead if that's your primary use-case.

Thanks @Pruxis for the tip! :+1: I didn't know about that syntax.
It's not the subject of this issue, but for those interested in workarounds like this, I just found that they're documented here: https://www.prisma.io/dataguide/postgresql/inserting-and-modifying-data/insert-on-conflict

However, per the PG docs, it's preferred to use unique constraints instead:
Note: The preferred way to add a unique constraint to a table is ALTER TABLE ... ADD CONSTRAINT. The use of indexes to enforce unique constraints could be considered an implementation detail that should not be accessed directly. One should, however, be aware that there's no need to manually create indexes on unique columns; doing so would just duplicate the automatically-created index.

this is from version 9.4, and from version 9.5 its not there anymore.

Please be caution if you use Prisma with @unique to push/migrate schema for Postgraphile #510

This has been causing me headaches because of this:

Postgres's ON CONFLICT clause requires you to specify the name of the unique constraint, you cannot use the name of the unique index.

See:
https://github.com/hasura/graphql-engine/issues/3666#issuecomment-572419941
My assumption was that Prisma would create the constraint so I could use ON CONFLICT. Because it does not, I'm running into problems.
Overall very happy with Prisma, though. It's a very nice tool.

Any update on this?


Test PR submits

For #4297

Codecov Report

Merging #8557 (fed326d) into main (59e203a) will increase coverage by 0%.
The diff coverage is n/a.

:exclamation: Current head fed326d differs from pull request most recent head ee46768. Consider uploading reports for the commit ee46768 to get more accurate results

@@          Coverage Diff          @@
##            main   #8557   +/-   ##
=====================================
  Coverage     71%     72%
=====================================
  Files        378     378
  Lines      24074   24074
  Branches    3714    3714
=====================================
+ Hits       17297   17337   +40
+ Misses      5261    5233   -28
+ Partials    1516    1504   -12

Impacted Files
Coverage Δ

src/client/datascience/raw-kernel/rawSocket.ts
82% <0%> (-2%)
:arrow_down:

src/client/datascience/telemetry/telemetry.ts
85% <0%> (+<1%)
:arrow_up:

src/client/debugger/jupyter/kernelDebugAdapter.ts
77% <0%> (+<1%)
:arrow_up:

src/client/common/process/interpreterActivation.ts
73% <0%> (+<1%)
:arrow_up:

src/client/datascience/baseJupyterSession.ts
76% <0%> (+<1%)
:arrow_up:

src/client/datascience/jupyter/kernels/kernel.ts
77% <0%> (+1%)
:arrow_up:

...ent/datascience/jupyter/kernels/kernelExecution.ts
66% <0%> (+1%)
:arrow_up:

...lient/datascience/telemetry/interpreterPackages.ts
77% <0%> (+2%)
:arrow_up:

src/client/common/platform/fs-paths.ts
83% <0%> (+2%)
:arrow_up:

src/client/common/process/proc.ts
70% <0%> (+2%)
:arrow_up:

... and 4 more