MQTT Autodiscovery issues

Hi
Not sure if this belongs here or in the hassio-addon part, or if this is really an issue with the xcomfort MQTT gateway at all.
After a month of downtime of my home assistant server (disk failure), I have retsored and updated to the latest version of all addons (including this).  To my surprise the entire setup of xcomfort devices in Home Assistant was also deleted with accosiated added information with area links etc, and replaced with new dicovery data.  If you update the datapoint list to eprom the module calls:
2021/01/03 23:06:46 Read datapoint list from eprom in 1m19.614060518s
2021/01/03 23:06:46 DPL Changed
2021/01/03 23:06:52 Sent MQTT autodiscover remove for 53 devices and 62 datapoints
2021/01/03 23:06:52 Sent MQTT autodiscover add for 53 devices and 62 datapoints
This seems to scratch the entire device configuration in HA, and with 51 devices and 115 entities with updated information, this is a showstopper (I can't have to update the entire configuration every time the datapoint list is updated).  This did not seem to be an issue in previous versions, but I'm no 100% sure.  I don't see any updates to the MQTT integration, so I assumed this is something that is changed in this addon.
Have I overlooked an obvious setting?
Jan

I wonder if this is caused by the MQTT autodiscover remove part. Does this happen on a full restart of hassio as well?
I can make autodiscover remove optional, but I believe this would require you to manually remove old devices. I'm not 100% informed when it comes to the mechanics of MQTT autodiscovery.

I wonder if this is caused by the MQTT autodiscover remove part. Does this happen on a full restart of hassio as well?
I can make autodiscover remove optional, but I believe this would require you to manually remove old devices. I'm not 100% informed when it comes to the mechanics of MQTT autodiscovery.

Yeah, I think this is the issue.  The problem is that this seems to brute force remove all devices added, even if they have been updated with added information in Home Assistant.   I would be fine with removing old entries on my own.  How would MQTT autodiscover add behave if the devices already have been added?

Yeah, I think this is the issue.  The problem is that this seems to brute force remove all devices added, even if they have been updated with added information in Home Assistant.   I would be fine with removing old entries on my own.  How would MQTT autodiscover add behave if the devices already have been added?

Just tested with a HA restart:
This only calls:
2021/01/04 09:17:18 Read datapoint list from eprom in 1m19.550166461s
2021/01/04 09:17:18 Sent MQTT autodiscover add for 53 devices and 62 datapoints
This does not delete all the devices, nor make changes to updated devices.
I've not updated to you lates rev. 0.24.  This was tested on 0.23.  I'll update to the latest rev and  test this again.
Regards
Jan

Just tested with a HA restart:
This only calls:
2021/01/04 09:17:18 Read datapoint list from eprom in 1m19.550166461s
2021/01/04 09:17:18 Sent MQTT autodiscover add for 53 devices and 62 datapoints
This does not delete all the devices, nor make changes to updated devices.
I've not updated to you lates rev. 0.24.  This was tested on 0.23.  I'll update to the latest rev and  test this again.
Regards
Jan

Okay, I'll make autodiscover remove optional, and we'll see how that fares. I'll see if I can come up with a better solution.

Okay, I'll make autodiscover remove optional, and we'll see how that fares. I'll see if I can come up with a better solution.

I would like to see autodiscover remove optional in any case, please 🥇

I would like to see autodiscover remove optional in any case, please 🥇

Thanks for the quick implementation, but I can't get the new version (0.25) to accept the config (even when reset to defaults):
Configuration:
mqtt_client_id: xcomfort
datapoints_file: ''
eprom: True
ha_discovery: True
ha_discovery_prefix: homeassistant
ha_discovery_remove: False
verbose: False
use_hidapi: False
eci_hosts: []

Failed to save addon configuration, not a valid value for dictionary value @ data['options']. Got {'mqtt_client_id': 'xcomfort', 'datapoints_file': '', 'eprom': True, 'ha_discovery': True, 'ha_discovery_prefix': 'homeassistant', 'ha_discovery_remove': False, 'verbose': False, 'use_hidapi': False, 'eci_hosts': []}
Regards

Thanks for the quick implementation, but I can't get the new version (0.25) to accept the config (even when reset to defaults):
Configuration:
mqtt_client_id: xcomfort
datapoints_file: ''
eprom: True
ha_discovery: True
ha_discovery_prefix: homeassistant
ha_discovery_remove: False
verbose: False
use_hidapi: False
eci_hosts: []

Failed to save addon configuration, not a valid value for dictionary value @ data['options'].

I screwed up the configuration for a short while, install 0.26.

Let me know how if 0.26 fixes the issue, so I can close this.

Let me know how if 0.26 fixes the issue, so I can close this.

0.26 seems to works as intentended.  Autodicover remove is not called when set to false in config.
Thanks

0.26 seems to works as intentended.  Autodicover remove is not called when set to false in config.
Thanks

Cool, let me know if you see any other issues!

Cool, let me know if you see any other issues!


R3M Franka Kitchen Environments / Demonstration Data

Hey @vikashplus! This is an awesome effort, and I'd love to help out if I can! I'm looking for a clean way to integrate the R3M Franka Kitchen and Adroit HMS evaluations into the Voltron Evaluation repository (https://github.com/siddk/voltron-evaluation), and I think that using Robohive as a dependency instead of the R3M Evaluation branch (+ corresponding forked submodules) makes the most sense.
From the docs though, it's not clear which environments/dataset is the right one to use; for the evaluations we ran in the Voltron work (https://arxiv.org/abs/2302.12766) we followed the same setup as R3M, evaluating 3 camera angles at 5, 10, and 25 demonstrations for each of the 5 tasks (with 50 heldout environments for validation). Should I be using the v3 or v4 environments? And how should I specify the three camera angles (left_cap2, right_cap2, default)?
Thanks so much - and if there's anything I can help out with to incorporate the changes to setup this eval, please let me know!

Hey @vikashplus - thank you so much for this! Really appreciate the links, and I'm going to try replicating the "R3M evaluation" flow with the v3 environments for now, and PR to the voltron-evaluation repository in the next week (and maybe even get our newer/more powerful Voltron models + other baselines added to the page you linked above).
In general, would love to connect in-person or over Zoom and actually talk about coming up with a holistic evaluation suite, maybe even starting a collaboration to combine + extend both our efforts! Lots of cool work in this space, and I'd love to get critical mass!

Hi @siddk

If you are interested in perfect R3M evals as reported in the paper, I'd recommend using the R3M checkpoint/tag from here
My recommendation will be use the upgraded envs, datasets, and baselines for more rigorous evals and for being future safe.

Closing this issue. Please let us know if we can provide further details.


Add an option to prevent removal of unused CSS selectors/classes

Describe the problem
Hey, I am using UIkit (https://getuikit.com/docs/introduction) for my application and added it via scss:
app.scss:
$global-link-color: #ff4600;
$global-primary-background: #ff4600;
$button-primary-background: $global-primary-background !default;
$button-primary-hover-background: darken($button-primary-background, 15%) !default;
$text-lead-color: #646464;
$global-font-family: 'Poppins', sans-serif;

@import 'uikit/src/scss/variables-theme.scss';
@import 'uikit/src/scss/mixins-theme.scss';
@import 'uikit/src/scss/uikit-theme.scss';

In my +layout.svelte I added:
import '../app.scss';

Now SvelteKit removes all my css with many messages like this:
[vite-plugin-svelte] /src/lib/Components/Contact.svelte:11626:0 Unused CSS selector ".uk-light .uk-subnav-pill > * > :first-child"
I tried to import it via global, but this leads to another error message (:global(...) must contain a single selector) - this is not an option.
Describe the proposed solution
There should be an option to disable this feature for ppl who are working with external CSS frameworks.people
Alternatives considered
I could include the framework within the app.html, but I won't be able to set my scss-Variables. I would need to override everything via global CSS, which would be possible but could be better.
Importance
would make my life easier
Additional Information
No response

This has come up a lot of time before, for example in https://github.com/sveltejs/svelte/issues/1594 https://github.com/sveltejs/svelte/issues/3371 https://github.com/sveltejs/svelte/issues/5804 - This feature is working as intended. If you want to have styles that Svelte doesn't try to scope at all, you can import them from your <script> block instead of from a <style> block. Anything that ends up in a <style> block in a component gets run through Svelte's CSS processing.


Added scrollDuration option...

...to scroll smoothly to the first focused invalid field instead of jumping at it. Focus is set at the end of the scroll.
Hope it helps.

this is not working now

Wow, this one is old! Looks like the plugin has been entirely rewritten. You should take a look here:
https://github.com/guillaumepotier/Parsley.js/blob/master/src/parsley/ui.js#L63
And try to copy/paste/adjust my old code:
https://github.com/guillaumepotier/Parsley.js/pull/349/files


[Linux Make_Ded] Undefined Reference to CreatePlatformWindowManager

Hi,
Not sure what I am missing here but I'm getting these linker errors when building a dedicated server on Ubuntu 64 14.04. I'm using the latest 3.8 release source.
Full error message:
http://pastebin.com/VV4VdfxR
Similar thread reference:
http://www.garagegames.com/community/forums/viewthread/138607
Any ideas?

For reference, the first error that I have encountered is the missing SDL.h, so I made some changes with the 2 files mentioned here for the fix.
https://github.com/GarageGames/Torque3D/pull/1212
using SDL2/SDL.h since this was the default installation folder for SDL2 dev.


[INF] Consider moving project to pyopensci

With the launch of pyopensci, this may be a great place for the package to get more exposure.

This seems like an interesting idea. Looking at their meeting notes, it seems that their org & its structure is very much a work in progress. Probably good to evaluate later on down the road once the project begins to mature.


v3.0.0 can't provide in webpack

 new ProvidePlugin({Promise: 'zousan'})
should work?
~v2.3.3 worked

still working new ProvidePlugin({Promise: ['zousan', 'default']})

Good catch @gblok . Digging into the webpack docs (https://webpack.js.org/plugins/provide-plugin/) I did find this, which concurs with your solution:

For importing the default export of an ES2015 module, you have to specify the default property of module.

Thanks for reporting back that it worked!


Fix Swagger Def errors as they appear on https://editor.swagger.io/

Plugged exiting yaml into https://editor.swagger.io/ and fixed issues that I saw:

$ref values must be RFC3986-compliant percent-encoded URIs
Some body params had unnecessary type or were missing schema
Remove duplicate Accept param from /api/program/{programId}/environment/{environmentId}/logs/download

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My change follows the documentation style of this project.
[x] I have read the CONTRIBUTING document.

Even with those changes, client generators are having a hard time generating components/schemas part of the yaml because the schema names, such as Program List contain spaces. I guess I'll have to parse and update those...
OR! we could update each schema name to be PascalCase, and use the title property per the OpenAPI spec here: https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.3.md#properties

@ahmed-musallam apologies for missing this. As you surmised, the yaml is generated, so submitting a pull request against it is not really productive. So I've fixed these in the generation logic

The duplicate Accept header is fixed in 7362365baee8f53e4740895cf9f34992e6b4a823
The percent coding is fixed in 610b1eb4716aed853f6f94a22eecb9ceb3512187
The const and required issue is fixed in 7fd6933d5285d787e0dae84253c686eb4aded465

In the future, please use issues to track these types of problems.

@justinedelson no worries. Thank you and glad it was fixed!

FYI @ahmed-musallam - @bstopp and I identified some other issues with the precent encoding so in 15ba65645990b1aa80397e78b4da9a4cf4333ff3, I have removed all of the spaces from definition names.

@justinedelson sweet! thank you!


fail validation: make-to-cwl/dna.cwl

I was looking for an example where the CommandLineTool and Workflow are in one file, and in trying to run
https://github.com/common-workflow-language/workflows/blob/master/workflows/make-to-cwl/dna.cwl
I get:
$ cwltool ~/workflows/workflows/make-to-cwl/dna.cwl
/home/ubuntu/.virtualenvs/p2_cwl/bin/cwltool 1.0.20160523144113
No cwlVersion found, treating this file as draft-2.
Tool definition failed validation:
While checking object `file:///home/ubuntu/workflows/workflows/make-to-cwl/dna.cwl#rnaseq`
  Field `cwlVersion` contains undefined reference to `https://w3id.org/cwl/cwl#draft-3`
While checking object `file:///home/ubuntu/workflows/workflows/make-to-cwl/dna.cwl#cat`
  Field `cwlVersion` contains undefined reference to `https://w3id.org/cwl/cwl#draft-3`
While checking object `file:///home/ubuntu/workflows/workflows/make-to-cwl/dna.cwl#tr`
  Field `cwlVersion` contains undefined reference to `https://w3id.org/cwl/cwl#draft-3`
While checking object `file:///home/ubuntu/workflows/workflows/make-to-cwl/dna.cwl#main`
  Field `cwlVersion` contains undefined reference to `https://w3id.org/cwl/cwl#draft-3

I get the same.

@cnjr2, @jeremiahsavage Pull request #95 should fix this issue


Pristine is logging too many things at the INFO level

These logs should be downgraded to "debug":

The Request Interceptor doesn't implement the interceptRequest method.
Router - The Request Interceptor doesn't implement the interceptResponse method.

Duplicate of https://github.com/magieno/pristine-ts/issues/568


Question: handling browser vendor prefixed values

Is there a solution offered for this by radium or any other CSS in JS framework? e.g. the following css:
  .layout {
    display: -ms-flexbox;
    display: -webkit-flex;
    display: flex;
  }

How to represent this in JS?

Radium already does this for you automatically, including the old flex box syntax. Just write display: flex.
If you want value fallbacks, you can also provide an array, the values of which will be tested in order, with the first successful one applied. See the guides for more.
We should add more/better documentation on the prefixer.

Got it : https://github.com/FormidableLabs/radium/tree/master/docs/guides#fallback-values thanks :rose: :+1:


Great lib!  Trouble with width

I'm really liking this library!
One thing ... I seem to be having trouble with tables with widths greater than 80 chars.  Tried the various width options, but no luck.  Thoughts?
Thanks.

Any chance you can try with the latest version (v0.6.0)? Still haven't managed to reproduce this.

I am seeing the same issue on OSX when I run pytest. It creates a new line char after 78 chars. The total would match then 80 as well.
In my terminal I see a different output longer than 80 chars per line.

I had similar problem where the console intance created didn't have the size of my actual console.
it turned out because i was using cmder, and when running my script from a split console that was smaller, my script opens up in a new full screen console but with old one's dimensions. all in all it was not a fault on rich's end, just putting this out there

Don't know if still relevant, but I face the same problem as the OP when I use Pycharm's built-in terminal, but not when I use my standalone terminal emulator.


testing style

Pl style of matplotlib does not work in the repository.
Testing locally has shown that updating matplotlib does work.

can you re-run CI with the build-all-demos label? bumping matplotlib is a major change for qml, I just wanna make sure everything still works as expected

can you re-run CI with the build-all-demos label? bumping matplotlib is a major change for qml, I just wanna make sure everything still works as expected

Oh good point!!

awesome! would probably take too long to spot-check every demo, but the fact that they all built is pretty good imo

I have tested 15 random demos and everything seems to be fine


OnImportMaxHeight Plugin in the scope of simple policy

This would be the impact, @erikzhang.
Everyone would need to update their config file because of the parameters load.
What do you think, master?
Should we move it to that isolated plugin, such as that ILoadingPlugin/IOnImportPlugin?

Perfect, @erikzhang.
Great generalization you have done. Thanks.


Does not build on Linux

On Gentoo the build fails with:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.2.1/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lclangAST
/usr/lib/gcc/x86_64-pc-linux-gnu/11.2.1/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lclangFrontend

Both libraries do not exist in my system.

$ grep add_library /usr/lib/llvm/*/lib64/cmake/clang/ClangTargets.cmake
/usr/lib/llvm/13/lib64/cmake/clang/ClangTargets.cmake:add_library(clang-cpp SHARED IMPORTED)
/usr/lib/llvm/13/lib64/cmake/clang/ClangTargets.cmake:add_library(libclang SHARED IMPORTED)
/usr/lib/llvm/14/lib64/cmake/clang/ClangTargets.cmake:add_library(clang-cpp SHARED IMPORTED)
/usr/lib/llvm/14/lib64/cmake/clang/ClangTargets.cmake:add_library(libclang SHARED IMPORTED)

See #244.

You'll need to build https://github.com/llvm/llvm-project/tree/llvmorg-14.0.0 locally to get access to the required lib packages given they are not distributed by default in all distros or Operating Systems.
While linking against clang-cpp makes it easier for Gentoo to build "by default", it makes the experience worse on other platforms and causes the libClangSharp to no longer work by default on most platforms due to clang-cpp not being resolvable.

You'll need to build https://github.com/llvm/llvm-project/tree/llvmorg-14.0.0 locally

No, I don't. There was a test in #244, which prefers clang-cpp library, so linking was conditional thus making no problems for other platforms or clang builds with other options enabled. If you want to prefer the other library set, let's invert the test: if (TARGET clang-ast AND TARGET clang-frontend) (please check target names in your ClangTargets.cmake.

Dealing with n+ Linux distributions and the various quirks and oddities that each has in how they package and distribute binaries is out of scope of the project.
Referencing clang-cpp was causing many more problems than it was solving and was breaking the user experience for other "officially supported" platforms because the file wasn't resolvable by default.
The simpler thing is to simply require devs to compile libclang locally before compiling libClangSharp so that all platforms have a consistent experience and expectations. It reduces the overall risk, increases portability, and ensures that we're only relying on dynamic libraries that are available on every platform.

I'm afraid you are mistaken about the packaging process for Linux distributions: we strongly prefer dynamic libraries over static ones. I doubt you can find any distro without the  clang-cpp .so library. Neither can I understand the mentioned problems. Referencing the clang-cpp library was under conditional test (if (TARGET clang-cpp)), thus the library has to be available to the linker when the test passes. Could you elaborate on the problems, please?

…ensures that we're only relying on dynamic libraries that are available on every platform

clangAST and clangFrontend are static libs, clang-cpp is the dynamic one.

Ah, so that's what you want! Statically linked binaries! Thank you, now I understand. Then I figure we can replace the test for clang-cpp target with the opposite one for clangAST and clangFrontend and prefer them when they are available. I can submit a PR with the required changes to the CMake build script and I would appreciate if you share with me with the ClangTargets.cmake file from the Windows build of clang with the clangAST & clangFrontend static libraries, please.

if you share with me with theClangTargets.cmake file from the Windows build of clang with the clangAST & clangFrontend static libraries

Pardon, found one online.


Run write-verification-metadata

Fixes #?
Context

Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation
[ ] Recognize contributor in release notes

FWIW, these were my outgoing changes: https://github.com/gradle/gradle/pull/21891


How to use auth_ldap

The following setting was added to superset_config.py.
【 superset_config.py】
AUTH_TYPE = AUTH_LDAP
AUTH_LDAP_SERVER = "ldap://ms-ad-server"
AUTH_LDAP_SEARCH = "dc=domain,dc=local"
AUTH_LDAP_BIND_USER = "CN= management,DC=domain,DC=local"
AUTH_LDAP_BIND_PASSWORD = "Password"
AUTH_LDAP_UID = "sAMAccountName"
When superset is carried out in this state, it'll be the following error.
【error】
File "/etc/venv/lib/python2.7/site-packages/superset_config.py", line 20, in
AUTH_TYPE = AUTH_LDAP
NameError: name 'AUTH_LDAP' is not defined
How should this be settled?

Auth is handle by flask app builder, please refer to its documentation as it looks like you missed to import stuff :) http://flask-appbuilder.readthedocs.io/en/latest/security.html#authentication-methods

Try AUTH_TYPE = 2 and doN#t forget to also install python-ldap or pyldap, respectively.

thanks for your advice
I added the following setting to config.py.
【config.py】
from flask_appbuilder.security.manager import AUTH_OID,
AUTH_REMOTE_USER,
AUTH_DB, AUTH_LDAP,
AUTH_OAUTH,
AUTH_OAUTH

AUTH_LDAP_SERVER = "ldap://server-ip-address"
AUTH_LDAP_BIND_USER = "CN=DEV MGT,CN=Users,DC=hoge,DC=local"
AUTH_LDAP_SEARCH = "dc=hoge,dc=local"
AUTH_LDAP_BIND_PASSWORD = "Password"
AUTH_LDAP_UID_FIELD = "sAMAccountName"
The place I tried to do setting above-mentioned and make login superset where and following debug-log were checked.
【debug-log】
/home/ubuntu/venv/local/lib/python2.7/site-packages/flask_appbuilder/security/views.py:396: FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to "FlaskForm" and will be removed in 1.0.
form = LoginForm_db()
2017-02-08 12:16:25,765:DEBUG:flask_appbuilder.security.manager:LDAP indirect bind with: CN=DEV MGT,CN=Users,DC=hoge,DC=local
2017-02-08 12:16:25,847:DEBUG:flask_appbuilder.security.manager:LDAP BIND indirect OK
2017-02-08 12:16:25,888:DEBUG:flask_appbuilder.security.manager:LDAP got User [('CN=hogehoge,CN=Users,DC=hoge,DC=local', {'mail'<EMAIL_ADDRESS>'givenName': ['\xe3\x81\xa6\xe3\x81\xa4\xe3\x82\x84'], 'sn': ['\xe3\x81\x95\xe3\x81\x84\xe3\x81\xa8\xe3\x81\x86']}), (None, ['ldap://ForestDnsZones.nyle.local/DC=ForestDnsZones,DC=hoge,DC=local']), (None, ['ldap://DomainDnsZones.nyle.local/DC=DomainDnsZones,DC=hoge,DC=local']), (None, ['ldap://nyle.local/CN=Configuration,DC=hoge,DC=local'])]
2017-02-08 12:16:25,888:DEBUG:flask_appbuilder.security.manager:LDAP bind with: CN=hogehoge,CN=Users,DC=hoge,DC=local XXXXXX
2017-02-08 12:16:25,929:DEBUG:flask_appbuilder.security.manager:LDAP bind OK: CN=hogehoge,CN=Users,DC=hoge,DC=local
2017-02-08 12:16:25,931:INFO:werkzeug:<IP_ADDRESS> - - [08/Feb/2017 12:16:25] "POST /login/ HTTP/1.1" 302 -
/home/ubuntu/venv/local/lib/python2.7/site-packages/flask_appbuilder/security/views.py:396: FlaskWTFDeprecationWarning: "flask_wtf.Form" has been renamed to "FlaskForm" and will be removed in 1.0.
form = LoginForm_db()
2017-02-08 12:16:26,031:INFO:werkzeug:<IP_ADDRESS> - - [08/Feb/2017 12:16:26] "GET /login/ HTTP/1.1" 200 -
As far as debug above-mentioned- log is checked, authentication in LDAP (MS-AD) is made, it isn't possible to make login superset.
Advice for everyone, please.

from flask_appbuilder.security.manager import AUTH_LDAP

@tetuya0703 were you able to get this working? can you post your ldap specific configurations here please.

@deepak-goel can you able to successfully implemented the ldab or not


How would you do an SQL query?

Stumbled upon this project by chance, and fell instantly in love. So much easier than that cumbersome OData client.
Ran into an issue, which I need a bit of help with.
How would you do an SQL query with this project?
As far as I can tell, the only way I could do it, is:
 var result = await Client.Request("SQLQueries('ItemPrices')/List")
                                     .SetQueryParam("itemCode", itemCode)
                                     .GetAsync<QueryResult<ItemPrice>>();

Where ItemPrices is, of course, the name of the query.
Oh, QueryResult has been defined like this:
public class QueryResult<T>
{
    public string SqlText { get; set; }
    public T[] Values { get; set; }
}

And, of course, ItemPrice is a class that reflects the fields being queried.

Hi, I'd be glad to help. Unfortunately I'm not too familiar with the "SQLQueries" resource as it's a relatively new addition to Service Layer. However, if you could show me how you would perform such request in Postman, for instance, and what is returned JSON, maybe I can show you how to do it in B1SLayer.

Hey, I took a better look at the "SQLQueries" resource and I think I get it. The thing to keep in mind is that B1SLayer will automatically unwrap the response whenever the JSON result is a collection, this means you don't need a model class containing the "values" array. If you don't want this behaviour, you can simply pass false in the optional parameter called "unwrapCollection" in the Get methods. With that in mind, here's how I'd do it in B1SLayer:
Let's assume I have a SQL Query that looks like this:
{
    "odata.metadata": "https://localhost:50000/b1s/v1/$metadata#SQLQueries/@Element",
    "odata.etag": "W/\"356A192B7913B04C54574D18C28D46E6395428AB\"",
    "SqlCode": "sql05",
    "SqlName": "queryOnItem",
    "SqlText": "select \"ItemCode\", \"ItemName\", \"ItmsGrpCod\" from \"OITM\" where \"ItemCode\" = :itemCode",
    "ParamList": "itemCode",
    "CreateDate": "2022-02-02",
    "UpdateDate": "2022-02-02"
}

To perform the request using B1SLayer, it would be something like this:
var items = await serviceLayer.Request("SQLQueries('sql05')/List")
    .SetQueryParam("itemCode", "'IT0001'") // Note the single quotes needed whenever the parameter is a string
    .GetAsync<ItemModel[]>();

My ItemModel class looks like this:
public class ItemModel
{
    public string ItemCode { get; set; }
    public string ItemName { get; set; }
    public int ItmsGrpCod { get; set; }
}

This will result in a GET request that looks like this:
https://localhost:50000/b1s/v1/SQLQueries('sql05')/List?itemCode='IT0001'
So, back to your code, I believe this would work:
var result = await Client.Request("SQLQueries('ItemPrices')/List")
  .SetQueryParam("itemCode", $"'{itemCode}'")
  .GetAsync<ItemPrice[]>();

Let me know if you still need help.

Ok cool. That makes sense.
How would you create the query in the first place?
Just a PostAsync with an anonymous class with the query data as argument?
Like this:
await Client.Request("SQLQueries")
      .PostAsync<SqlQuery>(new
                 {
                     SqlCode = "ItemPrices",
                     SqlName = "A list of item prices",
                     SqlText =
                         "SELECT PriceList, Price, Currency, Factor, PriceType FROM ITM1 WHERE ItemCode=:itemCode",
                     ParamList = "itemCode"
                 });

Yes, pretty much. It's your choice whether to use an anonymous type object or a normal object. I generally use anonymous objects when it's some simple routine that's executed only in a single place so I don't need to create a model class just for that.
In your case you seem to already have a model class called SQLQuery, so it might make more sense to create an instance of it instead of an anonymous object. But again, your choice.
Also, when you perform a Post and specify a class, like in your case PostAsync<SqlQuery>, this means the created entity will be deserialized into an object of this type, because by default, Service Layer returns the entity you just created whenever you create one. If you don't have a use for this created entity, you can do something like this and have better performance on your request:
await sl.Request("SQLQueries")
    .WithReturnNoContent()
    .PostAsync(new
    {
        SqlCode = "ItemPrices",
        SqlName = "A list of item prices",
        SqlText = "SELECT PriceList, Price, Currency, Factor, PriceType FROM ITM1 WHERE ItemCode=:itemCode",
        ParamList = "itemCode"
    });

Awesome, thank you for your quick response and help. It turns out I am having trouble getting my test installation of service layer to play, but that is an entirely different issue and nothing to do with this.
Again, thank you for your library and time.


Extremely large size of dependencies

Since version 0.1.3 you seem to be using libraries from com.soywiz:korlibs... Is that realy necessary? The problem is that this makes the desktop release of my app more than 2 megabytes bigger than before with version 0.1.2. This is even after compression via ProGuard.

@mipastgt Hi, since version 0.1.3, the library depends on Korlibs instead of kotlinx-io and Ktor. However, I'm also working on another variant that uses kotlinx-io and Ktor, but it has some performance issues. I will release this version of the library after some time, and in the future, we will move to using only kotlinx-io and ktor.


iox-#454 Added testcases for RoudiProcess class

Signed-off-by: Chiranjeevi Maddi (RBEI/EBB1<EMAIL_ADDRESS>Pre-Review Checklist for the PR Author

[x] Branch follows the naming format (iox-#123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit messages are signed (git commit -s)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed
[x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

Post-review Checklist for the Eclipse Committer

[ ] All checkboxes in the PR checklist are checked or crossed out
[ ] Merge

References

Closes #454

One side note: When creating Pull-Request you find in the template at the end the following statement: Closes TBD
This can be used to automatically link the PR with the corresponding issue, you just need to add the issue number.
Example: Closes #454

Canyou please merge the lastest master into your branch?

Can you please merge the latest master into your branch?

Merging is done

Can you please merge the latest master into your branch?

Merging is done

@elfenpiff needs to revoke his review

@elfenpiff needs to revoke his review

Please go through the list of commits and do a sign-off

@dkroenke Do you mean the commits which occurred because of merge from master??

Please go through the list of commits and do a sign-off

@dkroenke Do you mean the commits which occurred because of merge from master??

Please go through the list of commits and do a sign-off

@dkroenke Do you mean the commits which occurred because of merge from master??

Ah the merge commits does not need to be signed, allright.

Please go through the list of commits and do a sign-off

@dkroenke Do you mean the commits which occurred because of merge from master??

Ah the merge commits does not need to be signed, allright.

Please go through the list of commits and do a sign-off

@dkroenke Do you mean the commits which occurred because of merge from master??

Ah the merge commits does not need to be signed, allright.

Please go through the list of commits and do a sign-off

@dkroenke Do you mean the commits which occurred because of merge from master??

Ah the merge commits does not need to be signed, allright.


python27Packages.pyroute2: 0.5.9 -> 0.5.10

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python2.7-pyroute2/versions.
meta.description for python27Packages.pyroute2 is: "Python Netlink library"
meta.homepage for python27Packages.pyroute2 is: "https://github.com/svinota/pyroute2"
Updates performed:

Version update
Quoted meta.homepage for RFC 45

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.5.10 with grep in /nix/store/hbikab8syv500qg4d1yly7gl50gvd544-python2.7-pyroute2-0.5.10

directory tree listing: https://gist.github.com/175f0052e96e3c667fb3b6c85262fb55

du listing: https://gist.github.com/4ac4730b25ef8a244865e3ba2482a9e6

Rebuild report (if merged into master) (click to expand)

15 total rebuild path(s)
4 package rebuild(s)
4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
pulseaudio-dlna
python27Packages.pyroute2
python37Packages.pyroute2
python38Packages.pyroute2

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hbikab8syv500qg4d1yly7gl50gvd544-python2.7-pyroute2-0.5.10 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python27Packages.pyroute2 https://github.com/r-ryantm/nixpkgs/archive/d9fe974579ac8c9f767f429d2ca0086894c84bf6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hbikab8syv500qg4d1yly7gl50gvd544-python2.7-pyroute2-0.5.10
ls -la /nix/store/hbikab8syv500qg4d1yly7gl50gvd544-python2.7-pyroute2-0.5.10/bin

cc @mic92 for testing.

Result of nixpkgs-review pr 83364 1

4 package built:

python27Packages.shodan
python37Packages.shodan
python38Packages.shodan
theharvester

This is 83363 no 83364

Result of `nixpkgs-review pr 83363` [1](https://github.com/Mic92/nixpkgs-review)
<details>
  <summary>4 package built:</summary>

  - pulseaudio-dlna
  - python27Packages.pyroute2
  - python37Packages.pyroute2
  - python38Packages.pyroute2
</details>


Not yet initialized (you may need to run sgadmin)

I use docker image: khezen/elasticsearch:5.3.1
but I found error log of elasticsearch
Description of log
2017-05-09T11:56:35.22964146Z [2017-05-09T11:56:35,229][INFO ][o.e.n.Node               ] [elasticsearch-logging-v1-0r56b] started
2017-05-09T11:56:36.828061781Z Stalling for Elasticsearch...
2017-05-09T11:56:38.328989174Z [2017-05-09T11:56:38,328][ERROR][c.f.s.a.BackendRegistry  ] Not yet initialized (you may need to run sgadmin)
2017-05-09T11:56:43.452094244Z   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
2017-05-09T11:56:43.452138248Z                                  Dload  Upload   Total   Spent    Left  Speed
2017-05-09T11:56:43.472471808Z [2017-05-09T11:56:43,472][WARN ][c.f.s.h.SearchGuardHttpServerTransport] [elasticsearch-logging-v1-0r56b] Someone (/0:0:0:0:0:0:0:1:36944) speaks http plaintext instead of ssl, will close the channel
2017-05-09T11:56:43.473286809Z
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100    46    0     0  100    46      0   2301 --:--:-- --:--:-- --:--:--  2300curl: (52) Empty reply from server

2017-05-09T11:56:56.287447766Z [2017-05-09T11:56:56,287][WARN ][c.f.s.h.SearchGuardHttpServerTransport] [elasticsearch-logging-v1-0r56b] Someone (/<IP_ADDRESS>:37386) speaks http plaintext instead of ssl, will close the channel
2017-05-09T11:56:56.701588059Z Contacting elasticsearch cluster 'kubernetes-logging' and wait for YELLOW clusterstate ...
2017-05-09T11:56:56.782818999Z Clustername: kubernetes-logging
2017-05-09T11:56:56.782857932Z Clusterstate: GREEN
2017-05-09T11:56:56.783265435Z Number of nodes: 1
2017-05-09T11:56:56.783325131Z Number of data nodes: 1
2017-05-09T11:56:58.212625742Z searchguard index does not exists, attempt to create it ... [2017-05-09T11:56:58,212][INFO ][o.e.c.m.MetaDataCreateIndexService] [elasticsearch-logging-v1-0r56b] [searchguard] creating index, cause [api], templates [], shards [1]/[1], mappings []
Do  you have solutions?
Thanks a lot!

I am very busy right now and I don't have much time to maintain the image. 5.3.1 is no longer supported but contributions are much appreciated if you are willing to help.


all: deploy apps with mysql

In a production deployment we'll use a database like mysql (which our apps support) so our example environment should be deployed in the same way.
For now we can deploy mysql containers in the Pod of each app with secrets for the credentials.

Done for a few apps that support storage and mysql:

ofac: https://github.com/moov-io/infra/commit/466297eecc5cd4f49d8d8f1b4c33cf955713e815
customers: https://github.com/moov-io/infra/commit/fa407f6f073437f9e1192ca38e306b00e64c9823
paygate: https://github.com/moov-io/infra/commit/925912da95e38b4ede52f3c9520de1299059949c

Our auth service is being replaced, see https://github.com/moov-io/infra/issues/42


Don't set the cookie if in the middle of a cron process.

This proposed change should fix an issue where we're seeing a Cannot modify header information - headers already sent warning during cron loopback requests.

Hey @MalcolmVonMoJ , thanks for reviewing!
I'm hoping to install this via composer, is there a process on your side to deploy to the composer repo?
Thanks in advance :)


ROX-10920: Fix ComplianceTest aggregation

Description
Let's do this again. Fix the groovy. This would fail on select orchestrators because most of the checks for docker are skipped and then if its passes for ssh, then there are no failed and no errored
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
CI

/test-openshift-4-qa-e2e-tests

/test openshift-4-qa-e2e-tests


Add the homepage

This will help centralize WebNN samples in Electron app
with a directable index.html, thus we don't have to build
multiple WebNN samples in WebNN-native Electron examples.

Preview: https://honry.github.io/webnn-samples/
@ibelem, @huningxin, PTAL, thanks!

Thanks @Honry !

Could you please change the font-family of the svg logo?
The beauty of the UI usually lies in the details. To put it bluntly, it is the feeling of pixels.

@ibelem, thanks for your comments, PTAL again!
For redirecting to homepage, currently I hide the link in logo icon, do we need a new button for home page?

No strong opinion. Thanks a lot @Honry !

Thanks @ibelem! I am going to merge it to unblock further development.


Earn protocol WIP #16

16 of N pull requests.
This pull request includes significant updates to the icon handling and build configuration, along with some minor code cleanups. The main changes involve removing proxyStyle properties, refactoring the Icon component, and updating dependencies and build configurations.
Icon Handling Updates:

packages/app-earn-ui/src/components/atoms/Icon/Icon.tsx: Refactored the Icon component to use useMemo for SVG icons and removed the proxyStyle property. [1] [2] [3] [4]
apps/rays-dashboard/components/molecules/CriteriaList/CriteriaList.tsx: Removed proxyStyle from the Icon component.
packages/app-earn-ui/src/components/layout/Navigation/NavigationMenu.tsx: Removed proxyStyle from the Icon component.

Build Configuration Updates:

packages/app-icons/package.json: Added new dependencies for SVG handling and updated peer dependencies.
packages/app-icons/vite.config.ts: Updated Vite configuration to include new plugins for React and SVG handling. [1] [2] [3]

Minor Code Cleanups:

apps/earn-protocol-landing-page/components/organisms/LandingPageStrategyPicker/LandingPageStrategyPicker.tsx: Removed unused 'use client' directive.
packages/app-earn-ui/src/components/molecules/StrategyCard/StrategyCard.tsx: Added 'use client' directive.
packages/app-earn-ui/src/components/layout/StrategyGridPreview/StrategyGridPreview.module.scss: Adjusted padding in the CSS module.
packages/app-earn-ui/src/index.ts: Exported IconNamesList type.
sdk/sdk-client-react/package.json: Updated React peer dependency version.

@coderabbitai pause

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (dev@1fbdf7d). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #550   +/-   ##
======================================
  Coverage       ?   70.16%
======================================
  Files          ?      129
  Lines          ?     1354
  Branches       ?       78
======================================
  Hits           ?      950
  Misses         ?      404
  Partials       ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Support R install

The R is a programming language and free software environment for statistical computing and graphics supported by the R Foundation for Statistical Computing.
https://cloud.r-project.org/

If you want version checking, and my version checking is approved for version 0.3, then add this line below downloadURL:
appNewVersion=$(curl -fsL https://formulae.brew.sh/api/cask/r.json | sed -n 's/^.*"version":"\([^"]*\)".*$/\1/p')


Register logging flags with operator main cmd

Signed-off-by: Vlad Ungureanu<EMAIL_ADDRESS>Fixes https://github.com/cilium/cilium/pull/11133.
In https://github.com/cilium/cilium/pull/11133 JSON logging was added in the operator but the flags were never exposed to the command.
If we pass --log-opt flag now to the operator we get:
Error: unknown flag: --log-opt
Flags:
....
unknown flag: --log-opt

Register "log-driver" and "log-opt" flags with the cilium-operator command.

test-me-please

@tgraf I think so given the purpose of PR I linked was to enable users to beneft from JSON based logging.

test-me-please

@aanm @tgraf fixed the travis failure (forgot to render the command ref).

Coverage increased (+0.05%) to 36.951% when pulling 2a7e12c4315a0affd793a77babe77977d5026cf4 on vladu/fix-operator-json-logging into f2e181e0b330c6e644f7905dfefc7232c93798c6 on master.


Add support for OpenAPI v3.1

changelog(Improvements): Added support for OpenAPI v3.1 specifications
Adds support for OpenAPI v3.1 specs. Closes #4732
Note: previews won't work - that's one argument in favour of #5457 - as they are dependant on swagger-ui which hasn't added support for it yet.
Basic stuff seems to work (e.g. importing a spec, generating requests from it, ...)
Can be merged after #5457 and #5458

Glad you folks managed to get this done! swagger-parser update took a lot of time as did the underlying json-schema-ref-parser maintainance to get it there. If you can chip in some 💰 to pay for ongoing support, or throw in some time, then that underlying dependency can continue to get more stable.
I'll update openapi.tools now for you too. 💃🏻


HAWQ-1538. Install internal profiles definition file in conf directory.

If the fix is working please feel free to merge. It is hard to review this kind of change.

@lavjain feel free to try it out by make install/tar/bundle DATABASE=gpdb


You can't create a Meteor project inside another Meteor project?

I must be misunderstanding how to use this plugin because the very first step in the documentation doesn't work?
You're supposed to cd into your project root directory then create a new meteor server inside of it. Except when you try to do that you get this error, 'You can't create a Meteor project inside another Meteor project.'
Am I missing something?
This plugin extracts the meteor packages from a real meteor project, which lives in a subfolder. Is that even possible? I could really use some help getting this thing working. Thanks!

ah, your top-level folder is not supposed to be a meteor project, only the subfolder inside of it should be a meteor project.  To be specific, the top-level folder should not contain a .meteor directory.
Try creating an new empty folder, copying your current meteor project into it as a subfolder, and then trying to follow the documentation.

Also, I just added the explanation about the top-level directory to the readme.

@jedwards1211 so it would look like this?
New Folder
---Main Project Folder
----- .meteor Folder
----- all project files/folders
---Meteor server
----- .meteor folder
That makes sense and was a configuration I tried but couldn't get working. But now that I know it's the correct setup I'll take another crack at it! Thanks!

@jedwards1211 might as well ask this here instead of opening a new issue.
I'm trying to get React Storybook/Styleguidist working with my project, and the issue I'm running into is that they use webpack and whenever it encounters a file with a meteor import (i.e. 'import Roles from meteor/alanning:roles') it can't find the module because it's not an npm module.
Do you think your plugin can help with this? If not, can you possibly point me in the proper direction?

@DylanLyon - the plugin should work. Do you experience any problems, and if so - what problems?


chore: update dependencies

Coverage: 67.69% (+0.01%) from 67.679% when pulling b29cbd4d502c0dc1fb58903a700cb791882fd722 on OEvgeny:chore/audit-fix-v1 into 196b347244f09ce090f23c7d2dab5fa1d8a17217 on microsoft:main.


Add support for FLAMEGPU_ROOT CMake var

This is the version I've tested in Primage repo.
I've tested that it works when enabled, not tested that somehow I've broken when it's disabled.
Closes #7

SQUASH ME ON MERGE

I presume it's failing silently, then falling back to old behaviour. The VISUALISATION_ROOT behaviour in fgpu repo probably the same.

I presume it's failing silently, then falling back to old behaviour. The VISUALISATION_ROOT behaviour in fgpu repo probably the same.

find_path(FLAMEGPU_ROOT_ABS ... is finding my local copy even though it is not within the hinted or path subdirectories. Might need to pass some other options to find_path so it doesn't find it when it shouldn't. I'll try and fix it.

Ah find_path caches the path when it finds one unless NO_CACHE is passed, so it was remembering the location I told it about earlier. Will push a fix when I've tidied it up.
Also, attempting to overide FLAMEGPU_VERSION from the command line (as suggested in the readme) doesn't work if it is set in the CMAkeLists.txt (as a non cache variable).
Setting it as a cache variable however, means that if the CMakeLists.txt is changed, it will not change the value used (I.e. recent ensemble benchmarking issue, which does set it as a cache variable not a local). I am not certain what the best setup for this is.


Don't error out on updating bundled helm repos

If we fail to update a repo or the system catalog is set to bundled we do
not record any error.

issue: https://github.com/rancher/rancher/issues/28879


do not suggest to add unnecessary duplicative seamark tags

seamark tagging scheme in general creates unneeded parallel tagging schema, there is no need to support it an bother user about it

For reference: these tags were added in https://github.com/openstreetmap/iD/pull/7622. See also #683
My first impression is that while potentially duplicating some information, the seamark tags don't generally hurt[^1] and could be potentially useful for some data consumers like specialized renderers of water facilities. //cc @Eric-Sparks @k-yle @jsavage maybe one of you could give us some input on how these tags are used in practice?
However, from what I can see, leisure=marina could also be used with the value seamark:harbour:category=marina_no_facilities, meaning that the tag might not always be the correct one. :thinking:
[^1]: Yes, it might be somewhat distracting to see the tag upgrade message on existing leisure=marina objects. But that could be prevented by replacing the addTags with a dedicated field for the seamark:type tag with an appropriate default value.

It would be a real shame to stop supporting seamark tags purely because the current design of iD's tag-upgrade warning is a bit intrusive :(
With this argument, should the warnings to add healthcare=* to amenity=* also be removed because they are two parallel tagging schemes?
There's a lot of things i don't like about seamark tags, but it's become well established and this is one of the very few cases where there is an equally popular tag in the normal tag system... There are very few marinas in the database, even in big coastal cities, so has anyone actually found this specific warning annoying?

To make it clear: this was not meant to stop supporting the seamark tags altogether. Only for specific cases (like for marinas), where their value could be implied by another tag might be "considered redundant".
But I think you have a very good point: Like in the healthcare case, we should consider the use-case specific tags (here: seamark:*) as the "main" tag of these presets, and the leisure/amenity tags should be considered as merely kept around for backwards compatibility. I wish the wiki could be more bold or explicit about this, though: Currently, the page for leisure=marina doesn't even mention the seamark:* tags at all.
You convinced me: I think, in general, keeping this as a proper tag upgrade does actually make sense to keep.
Any feedback on the marina_no_facilities value? A way to toggle between the two possible values (seamark:harbour:category=marina vs. seamark:harbour:category=marina_no_facilities) should probably be at least available as a field, doesn't it?

So, to be clear, leisure=marina doesn't have a 1:1 relationship with a seamark tag.  seamark:harbour:category=marina means that the facility has services that a captain might be looking for.  seamark:harbour:category=marina_no_facilities means that the marina basically has a place to tie up.  So, it is proper to have leisure=marina and the seamark at the same time since the seamark is more descriptive which is important to a maritime user.

In cases where it is not "always implies seamark:XYZ" then such "tag upgrade" (which BTW should be maybe renamed to make clear that it is automated and not very smart replacement) is damaging data.

the seamark tags don't generally hurt

Well, in cases where there specific tag always indicates some seamark tags then in such case they are pointless duplicates and pure waste of time to add them.
seamark: especially are irritating as they appear to basically have parallel tagging schema, with seamark:small_craft_facility:category=toilets being a good example of a problem.

the leisure/amenity tags should be considered as merely kept around for backwards compatibility

not really, amenity=toilets is in every way superior to seamark:small_craft_facility:category=toilets to take one example (and someone interested in only nearby toilets can just filter amenity=toilets rather having multiprefixed tags)

Any feedback on the marina_no_facilities value?

Is it still leisure=marina when you have no facilities whatsoever? In such cases I mapped anchorage/buoy moorings/moorings but no leisure=marina as there was no marina there (what makes me quite suspicious about also seamark:harbour:category=marina_no_facilities but my sailing experience is not extensive)

so has anyone actually found this specific warning annoying?

me, that is why I created this PR

Any feedback on the marina_no_facilities value?

Is it still leisure=marina when you have no facilities whatsoever? In such cases I mapped anchorage/buoy moorings/moorings but no leisure=marina as there was no marina there (what makes me quite suspicious about also seamark:harbour:category=marina_no_facilities but my sailing experience is not extensive)

Yes, it's still a marina.  A marina implies a place to dock that isn't an anchorage that is open for non-owners to use.  If there are facilities (and "facilities" has a wide meaning), then it is still a marina, it just has added amenities.

not really, amenity=toilets is in every way superior to seamark:small_craft_facility:category=toilets to take one example (and someone interested in only nearby toilets can just filter amenity=toilets rather having multiprefixed tags)

You have to take this in context.  seamark:small_craft_facility:category=toilets specifically calls out a toilet that is built/maintained for small craft users.  It doesn't stop people from using other toilets or for non-boaters from using the toilet, but when you are looking at a sea map, you can see the facilities that are specifically for you (as a boater).

marina_no_facilities

Yes!  I agree that the addition of "no_facilities" is meaningful - especially for sailors planning a route.   Certainly in the UK, it is common place for toilet facilities not be for exclusive use of the users of the marinas not the general public so appropriate that they only appear as such in OpenSeaMap.
What I do this is a bit odd is the use of the term 'seamark' (presumably as opposed to landmark) for anything that needs to be included in OpenSeaMap that is is not in OpenStreetMap.

Hm… The not a 1:1 match argument by @matkoniecz is actually a valid critique here. :thinking: On the other hand I would also like to support openseamap tagging in iD wherever reasonably possible.
It is a bit unfortunate is that the seamark tags are generally quite poorly defined/documented on the wiki, which makes it especially hard to evaluate this for people which are unfamiliar with the topic and/or domain specific terms. E.g., as a mapper, I wouldn't know what facilities to look out for when deciding which kind of marina it is.

What about the following solution: We keep the current tag upgrade of the leisure=marina preset (under the assumption that what mappers usually associate with leisure=marina does more commonly have "extra facilities" than not), and add a checkbox-field to de-select "has extra facilities"[^1]. At the same time we also add a preset for seamark:harbour:category=marina_no_facilities which is titled Yacht Berths (see wiki) and has marina as one of its search terms.
[^1]: again: a better description of which "extra facilities" are expected would be quite useful, though.

tyrasd commented that a better description of which "extra facilities" are expected would be quite useful.   I interpret this as a request to clarify what facilities should be mapped in OpenSeaMap using seamarks.
In thinking about this I do think that mappers should realise that sailors and other seafarers typically have cruising guides, pilot books, almanacs and other documents that they can refer to when planning passages.  These documents already provide details of the facilities that are available - albeit in different ways!    One popular publication is Reeds Nautical Almanac.
This describes facilities at 3 levels of detail:
A qualitative rating for each harbour - eg  facilities available:

Possibly some domestic facilities but little else.
Most domestic needs catered for but limited boatyard facilities
Good facilities for vessel and crew

For each harbour or marina a paragraph entitled Facilities:
This describes berthing options and facilities including berthing rates
Underneath this are relevant symbols for facilities available.
The symbols used for every harbour and marina covered within the 1000+ pages:

Other publications provide similar info.  Often in much less detail than Reeds.
It seems to me that in relation to facilities, seafarers need to know:

What facilities are available  <<<leave for the Almanacs to cover
Where these facilities are   <<< Concentrate on this - and in particular the facilities that are approached by from the water  Eg. Visitors berths.   Fuel jetty,  Refuse Barge, pump out facilities.  In small marinas if they are all within 10 metres of each other then there may be little benefit in mapping these but in larger harbours mapping these is much more likely to be useful.
When (opening times)   <<<leave for the Almanacs to cover
How (special instructions)   <<<leave for the Almanacs to cover

I hope the above is of some help in this discussion
NB. I will add some images later to illustrate

What about the following solution: We keep the current tag upgrade of the leisure=marina preset (under the assumption that what mappers usually associate with leisure=marina does more commonly have "extra facilities" than not), and add a checkbox-field to de-select "has extra facilities"1. At the same time we also add a preset for seamark:harbour:category=marina_no_facilities which is titled Yacht Berths (see wiki) and has marina as one of its search terms.

I think this would be a good solution.


Bot Proposal: "Blocked on..."

Background
We often have issues that are "blocked" on other underlying engineering work or features being implemented. Right now we can comment "blocked on #XXX" and leave it open or close it out, but we don't have much of a way to query for/against these blocked issues.
Proposal
On comment "/blocked #XXX", the bot will add a blocked label and a blocked#XXX label.
When issue #XXX is closed, the bot will automatically delete the blocked#XXX label from all issues, and remove the blocked label from all issues with no other issues blocking them.
Thus you will be able to filter out blocked issues from queries and find all issues blocked on a particular issue.

^ we'll likely not require 20 upvotes. Just general consensus that this is something that would be helpful

@JacksonKearl might be better using the under-discussion label rather than backlog candidates for these?

I have concerns that this would create too many spamy labels. Is there any other GH project that uses this approach?

@alexdima I don’t know of any. I see your concern, given nobody seems to actually want it I’ll likely just close this proposal out.


nexrender server | Want to install older version.

How can I install older version of nexrender server ? because in latest one there is an error.
I am trying this way:
npm install @nexrender/server^1.26.0 -g
but its unable to install older version

Fixed in #750


Optimize LayoutRendererWrappers to reduce string allocations

And skip usage of the StringBuilderPool:

FileSystemNormalizeLayoutRendererWrapper
LowercaseLayoutRendererWrapper
Rot13LayoutRendererWrapper
TrimWhiteSpaceLayoutRendererWrapper
UppercaseLayoutRendererWrapper
ReplaceNewLinesLayoutRendererWrapper (Minor change to recognize Unix-Newlines on Windows)
OnExceptionLayoutRendererWrapper

Followup to #2743 where new transform-method was introduced for JsonLayout.

Could you please run some performance tests? The downside of this PR is the new "obsoletes", so I hope the results are significant. Looks good further.
Thanks in advance!

The downside of this PR is the new "obsoletes"

I'm just trying to revert the mistake of creating WrapperLayoutRendererBuilderBase and guide NLog-users from not using it any longer. Obsolete-attributes should have minimal impact.

@304NotModified Have no issue with removing the obsolete-attributes if they are party killers. But just like to warn people.

Some performance tests of the different wrappers:

Logger Name
Messages
Size
Args
Threads
Loggers

NullLogger
10.000.000
128
0
1
1

Test Name
Time (ms)
Msgs/sec
GC2
GC1
GC0
CPU (ms)
Alloc (MB)

FSNormalize - Master
21.879
457.044
0
0
650
22.078
6.447,3

FSNormalize - This PR
19.908
502.302
0
0
389
19.937
3.853,1

Test Name
Time (ms)
Msgs/sec
GC2
GC1
GC0
CPU (ms)
Alloc (MB)

Lowercase - Master
26.482
377.606
0
0
648
26.671
6.447,3

Lowercase - This PR
25.685
389.330
0
0
389
25.828
3.853,1

Test Name
Time (ms)
Msgs/sec
GC2
GC1
GC0
CPU (ms)
Alloc (MB)

TrimWhiteSpace - Master
9.185
1.088.707
0
0
643
9.093
6.447,4

TrimWhiteSpace - This PR
7.594
1.316.744
0
0
387
7.578
3.853,1

Test Name
Time (ms)
Msgs/sec
GC2
GC1
GC0
CPU (ms)
Alloc (MB)

ReplaceNewLines - Master
14.117
708.321
0
0
649
14.218
6.447,4

ReplaceNewLines - This PR
10.588
944.434
0
0
389
10.640
3.853,1

@304NotModified The results are great! So no need.

Your comment in #2818 says that the obsolete-attributes must be removed, but now you say that I should leave them and adjust the text to them being removed in NLog 4.6 (and not NLog 5.0)

@304NotModified Have reverted the marking of obsolete methods. Then the changes can be applied right away with no one getting hurt.

thanks!

No problem. Will make new PR for Nlog 4.6 that marks them as obsolete
Sent from my Samsung device
-------- Original message --------
From: Julian Verdurmen<EMAIL_ADDRESS>Date: 02/08/2018 11:21 (GMT+01:00)
To: NLog/NLog<EMAIL_ADDRESS>Cc: Rolf Kristensen<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [NLog/NLog] Optimize LayoutRendererWrappers to reduce string   allocations (#2817)
I don't like revert commits. Is it OK if I squash this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/pull/2817#issuecomment-409863282, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AK-fnCX1Jdpad0HXKPVlceL84ONTMbCiks5uMsSegaJpZM4VlLIO.

thanks! merged then!

@304NotModified Would it be bad to update the wiki with advice about avoiding VariableLayoutRenderer, unless needing to modify a complex SimpleLayout at runtime?

It is not threadsafe (changing values while logging can be dangerous)
There is a performance hit compared to using the standard template-variable.
There can be surprises if logging configuration is reloaded / modified.

Instead it is much better to use https://github.com/NLog/NLog/wiki/Gdc-layout-renderer if needing to modify simple global values at runtime.

advice is never bad.
I think the GDC is indeed better, but more limited. It's good to know when to choose between GDC, ${var:x} and "consts" (e.g. ${myVar})

Updated the wiki: https://github.com/NLog/NLog/wiki/Var-Layout-Renderer


Listener: Filter chain manager refactor cont

Description:
This PR is a follow up of https://github.com/envoyproxy/envoy/pull/7152
The background is FilterChainDiscoveryService(does not exist yet) will update filterchain independently from LDS.
What this PR does:

Moving more factory logic from listener to filter chain manager.
Recover the exception message where binded address is lost in #7152
A scaffold of FilterChainManagerImplTest but not utilized fully.
As this PR is not that trivial, the tests are not moved test from ListenerTest. Will do in following PRs.

Risk Level: Mid
Testing: existing Listener test.

@dnoe Could you take a look? It's ready to be reviewed.
Also CC @htuch

@dnoe gentle ping

@mattklein123 I resolve all the change requests
PTAL when you are available

gentle ping @mattklein123

Thank you for allowing me leave some TODOs in this PR! I will post the follow up later today.


fix: expose GitHubChecksContext outside the package

Fixes #104

@XiongKezhi not sure why the build does not pass for windows-8, but it seems like the agent is offline/reclaimed
[2021-01-14T15:41:08.673Z] Cannot contact EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7): hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@469b9ac4:EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7)": Remote call on EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7) failed. The channel is closing down or has closed down

@XiongKezhi not sure why the build does not pass for windows-8, but it seems like the agent is offline/reclaimed
[2021-01-14T15:41:08.673Z] Cannot contact EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7): hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@469b9ac4:EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7)": Remote call on EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7) failed. The channel is closing down or has closed down

@XiongKezhi not sure why the build does not pass for windows-8, but it seems like the agent is offline/reclaimed
[2021-01-14T15:41:08.673Z] Cannot contact EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7): hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@469b9ac4:EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7)": Remote call on EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7) failed. The channel is closing down or has closed down

That's ok, the windows builds are not very stable

@XiongKezhi not sure why the build does not pass for windows-8, but it seems like the agent is offline/reclaimed
[2021-01-14T15:41:08.673Z] Cannot contact EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7): hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@469b9ac4:EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7)": Remote call on EC2 (aws) - Windows 2019 (i-0a368c1ac10e1fca7) failed. The channel is closing down or has closed down

That's ok, the windows builds are not very stable


Data formatting

Hi,
I would love to see some data formatting examples for the policy "Printers/PointAndPrintRestrictions".  As trying to translate the ADMX values into the required formatting is a real nightmare.
Thanks in advance.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db383394-fa70-dba2-1a62-00a246a74ca9
Version Independent ID: 7f25bcea-4578-5661-df33-e12176cde814
Content: Policy CSP - Printers
Content Source: windows/client-management/mdm/policy-csp-printers.md
Product: w10
GitHub Login: @MariciaAlforque
Microsoft Alias: maricia

@officedocsbot assign @mypil

@BigIve - Thank you for submitting feedback.
I will get this issue over to the Win10 ITPro writing team for investigation.
Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

Hello @BigIve Can you please share the current XML data for formatting you already have so that I can help you accordingly.
Thanks.

Hi Joinimran,
Since I first posted this question, I've started to use the Administrative Templates option for this item.  So far "touch wood" the Admin Templates are actually working for me.
Wish I could say the same for various other Custom Intune based policies though.  As the data formatting for restrcited groups and enterprisemodernappmanagement is a nightmare.

Thank you for sharing more details on this. Please note that this is in the evolution phase and things can be complex. I would suggest you please share your feedback using the feedback channel so that it can be addressed in the future.
Thanks.
@mypil Please guide the user how the user can share feedback with Microsoft for the same.

@BigIve - Thank you for engaging with the community here for the docs.
I know the product teams are always looking for user feedback on how to make Windows 10 better. They keep a close tab on user feedback and it would be awesome if you could add your voice in
User Voice https://support.microsoft.com/en-za/help/4021566/windows-10-send-feedback-to-microsoft-with-feedback-hub
You might find others have made a similar request that you can add to, or you can open a new one.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close

here is the exact string which worked for me.
Name: Point and Print Enable
Oma-URI: ./Device/Vendor/MSFT/Policy/Config/Printers/PointAndPrintRestrictions
Data type: String
Value:

For readability, repeating the string from previous comment, adding line breaks:
Name: Point and Print Enable Oma-URI: ./Device/Vendor/MSFT/Policy/Config/Printers/PointAndPrintRestrictions
Data type: String Value: <enabled/>
<data id="PointAndPrint_TrustedServers_Chk" value="true"/>
<data id="PointAndPrint_TrustedServers_Edit" value="Printserver1.Contoso.com"/>
<data id="PointAndPrint_TrustedForest_Chk" value="false"/>
<data id="PointAndPrint_NoWarningNoElevationOnInstall_Enum" value="1"/>
<data id="PointAndPrint_NoWarningNoElevationOnUpdate_Enum" value="2"/>

@officedocsbot reopen

@BigIve , Thank you so much for sharing feedback. As suggested, I have forwarded the request based on your shared content to be added in the doc to doc owner. As soon as it gets approved, the changes will be reflected in the doc.
We really appreciate your feedback and making Microsoft documents helpful for the rest of the community.
Thanks.

@BigIve @alokshan @illfated  - From our understanding, the issue has been resolved but it may take a few days for the merged content to appear in the article. If you feel it hasn't been resolved, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close


📝Update includes in docs/tutorial/fastapi/limit-and-offset.md

Update Syntax docs/tutorial/fastapi/limit-and-offset.md as a part of https://github.com/fastapi/sqlmodel/issues/1150

Thanks for the effort! This was covered in another PR, so I'll close this one now. :coffee: :cake:


PP-5851 Log when session variable deleted from cookie

It would be good to say why you're doing this in commit, so future us can reason about whether it's still needed.


Track progress of fetching models

When the fuel download client was running in the site editor, I felt somewhat out in the cold while the download was allegedly happening without any indication of what progress was being made.
This PR adds a hook for streaming out information about what models are being fetched. In the refactoring of the site editor UI, I'm using this to give live updates about what models have been received.
I also opened ticket #3 which I think would be the final piece in truly making this a top-notch fuel client.

Sounds good. I've bumped it to 100 here: 9d9a9d2
Subjectively it did feel faster, but I didn't take any measurements.


Compiler crash when declaring a block receiving an Int

I found this problem on an Arch Linux machine, running Crystal 0.5.8.
The function names indicate which methods fail and which ones work
class X
  def fail_1(&@b : Int -> _)
    yield 1
  end

  def fail_2(&b : Int -> _)
    @b = b
    yield 1
  end

  def work_1(&@b : Int32 -> _)
    yield 1
  end

  def work_2(&b : Int -> _)
    yield 1
  end
end

X.new.fail_1 { puts "this fails" }
X.new.fail_2 { puts "this fails as well" }
X.new.work_1 { puts "this one works" }
X.new.work_2 { puts "this works as well" }

In summary, not using instance variables, or using Int32 instead of Int makes this code work
For the failing ones, what I got was this:
; ModuleID = 'X'

%String = type { i32, i32, i32, i8 }
%X = type { i32, %"(Nil | (Int -> Nil) | (Int32 -> Nil))" }
%"(Nil | (Int -> Nil) | (Int32 -> Nil))" = type { i32, [2 x i64] }
%"->" = type { i8*, i8* }

@symbol_table = external global [1 x %String*]

define %X* @"*X::new:X"() {
alloca:
  %x = alloca %X*
  br label %entry

entry:                                            ; preds = %alloca
  %0 = call i8* @__crystal_malloc(i32 ptrtoint (%X* getelementptr (%X* null, i32 1) to i32))
  %1 = bitcast i8* %0 to %X*
  %2 = bitcast %X* %1 to i8*
  call void @llvm.memset.p0i8.i32(i8* %2, i8 0, i32 ptrtoint (%X* getelementptr (%X* null, i32 1) to i32), i32 4, i1 false)
  %3 = getelementptr inbounds %X* %1, i32 0, i32 0
  store i32 33, i32* %3
  store %X* %1, %X** %x
  %4 = load %X** %x
  %5 = call i1 @"*GC::add_finalizer<X>:Nil"(%X* %4)
  %6 = load %X** %x
  ret %X* %6
}

declare i8* @__crystal_malloc(i32)

; Function Attrs: nounwind
declare void @llvm.memset.p0i8.i32(i8* nocapture, i8, i32, i32, i1) #0

declare i1 @"*GC::add_finalizer<X>:Nil"(%X*)

define i1 @"*X#fail_1<X, &(Int -> Nil)>:Nil"(%X* %self, %"->" %b) {
alloca:

entry:                                            ; No predecessors!
  %0 = getelementptr inbounds %X* %self, i32 0, i32 1
  %1 = getelementptr inbounds %"(Nil | (Int -> Nil) | (Int32 -> Nil))"* %0, i32 0, i32 0
  store i32 157, i32* %1
  %2 = getelementptr inbounds %"(Nil | (Int -> Nil) | (Int32 -> Nil))"* %0, i32 0, i32 1
  %3 = bitcast [2 x i64]* %2 to %"->"*
  store %"->" %b, %"->"* %3
}

attributes #0 = { nounwind }

Thanks for reporting!
The main issue is that right now you can't create a function pointer where Int is an input. The same happens with Int as a generic type argument: it crashes the compiler. But only because we didn't implement it yet.
All of the comments of this issue apply to this issue as well, so I'll leave both issues open until we decide what to do with Int. @waj suggested that we could rename Int to Integer or something else so users would normally avoid using it (maybe?), but still allow to have Int as a generic type argument (although it will be just a bit less efficient).

By the way, in work_1 and work_2 no function pointer (or Proc) is created because you never capture the block (b), that is, you never refer it by name. In this case Crystal will inline the code and not create a Proc (leads to much more efficient code). That's why it doesn't crash. But in the other cases you are assigning b to @b, and that creates a Proc and then it crashes.

Fixed by 4b1e0742bdae8dabea12ce977ed324339705cd16


feat: add GitHub PR template

🔗 Linked issue
📚 Description
The number of repositories managed by Nuxt organizations is increasing day by day, and I think the cost of managing the repositories is on the rise.
I often see PRs that add GitHub PR templates to each repository for repository operation, but I think this can be solved by placing them in nuxt/.github.

https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/creating-a-default-community-health-file

The behavior that occurs in each repository is as follows.
.github/pull_request_template.md has been placed
The pull_request_template.md set in each repository will take priority.

If a repository has any files in its own .github/ISSUE_TEMPLATE folder, including issue templates or a config.yml file, none of the contents of the default .github/ISSUE_TEMPLATE folder will be used.

.github/pull_request_template.md has not been placed
The pull_request_template.md in this repository will be used when creating a PR.
✍ Note

Only the GitHub PR template is added in this PR. The GitHub Issue template will be added in a separate PR.
If there are no issues with this PR, we will take the same steps in the Nuxt modules organization.

My opinion...
I often use the previous ❓ Type of change item.
So I think it's fine for it to exist.

Hi @danielroe , I would appreciate it if you could leave a comment when you have time.
Thank you for always reviewing.

I would be happy to add back the 'type of change' section too.

Thank you for the initiative! 🙏


Payment Gateway Integration?

Currently it seems koalix only tracks invoices/payments.  I would love to generate an invoice, and send my client a link to pay it.  I can certainly facilitate this on my own in a custom app, but this is a pretty important part of any CRM in any case.
  This would be a very desirable feature.  I originally came to this project with this goal in mind.
Do you have any advice for people looking to actually take payments for invoices?

Hello derek
Thank you for the feature request.
The approach to which is currently supported by the software is the old fashion way.
you receive a payment from your customer via bank and you have to manually enter the received amount into the system.
5years ago when I developed the software it was not so easy to have this done but i think today it is a different topic. We would discuss a bit more what types of payments would be requested from you.
I guess payments via:
PayPal should be in focus
Bitcoins?
Credit cards
automatic Bank account data import
...
....

The best solution is to pick a payment gateway that handles the transactions for you.

  Braintree was actually purhcased by paypal... so you get some of the benefits from the paypal team.
One thing that NONE of these provide that would be absolutely brilliant is a way to handle direct deposits. The idea of paying 2.9% (minimum) for processesing invoices through my website is... troublesome.  However, I am not really knowledgable enough on the whole thing to know how difficult this would be, if at all possible.

I see and i agree that this is a required feature.
On the other hand i also see some conflicts with the current concept:

as the application should also be usable as local application (running without a dedicated web server).
the security level needs to be deeper analyzed.
we currently create PDFs that are meant to be delivered as physical letters to the customer.

However i think the next step must be to create a set of issues that can be done step by step:

Clarify the use case we would like to support
Elaborate security concept (we need to make sure the payment related sections are bullet proof)
Find an easy way to integrate or not integrate the payment gateway (it should work for web application mode and for standalone  mode)

created following issues #53 #54 #55
@derek-adair would you be able to support us in the definition of the use cases or writing some user stories?

I didn't realize this could be used in stand-alone mode.. Which makes sense and is pretty rad.
I will try and fill out some stories, i'm usually on the other side of the fence tho xD


dataFrom does not function with permitted-key-name annotation

Hi,
Version: 3.1.0
Install: by Helm Chart
Environment: GKE 1.14 cluster
this doesn't function when the namespace has the permitted-key-name annotation:
apiVersion: v1
kind: Namespace
metadata:
  name: ns-a
  annotations:
    externalsecrets.kubernetes-client.io/permitted-key-name: "/dev/poc/a/.*"

apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
  name: credentials
spec:
  backendType: secretsManager
  dataFrom:
    - /dev/poc/a/credentials

The error message is: "ERROR, Cannot read property 'forEach' of undefined"
When I remove the annotation or add a data spec to the external secret it is okay, eg.
apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
  name: credentials
spec:
  backendType: secretsManager
  data:
    - key: /dev/poc/a/credentials
      name: password
      property: password
  dataFrom:
    - /dev/poc/a/credentials

It gets worse:
When i use:
apiVersion: kubernetes-client.io/v1
kind: ExternalSecret
metadata:
name: credentials
spec:
backendType: secretsManager
data:

key: /dev/poc/a/credentials
name: password
property: password
dataFrom:
/dev/poc/b/credentials

then the dataFrom part is not checked against the naming convention and is merged.

Fixed in #292


Allow configuration of file headers via INI file

Includes docs and tests.
Closes #9.

Thanks so much for writing tests and docs! I really like the overall direction of this PR.

Thanks for this improvement, this is great.

Cheers!


"Jobs of Opportunity (While You're Up)" RT + Jobs of Opportunity <IP_ADDRESS> test. GUI completely disappears and Unity Crash upon Alt F4

Bug Description
GUI completely disappears, game is still running. Pressing space to try and pause game does nothing, neither does any other key input register. A group of visitors had just arrived, maybe that had something to do with it. Only option was AltF4, which crashed Unity.
To Reproduce
Steps to reproduce the behavior:
Was unable to reproduce on the last autosave before the crash. I have no idea on this one.
Player Log
Player.log
Crash Log
error.log
Save File: Last Autosave
Probably won't be of much help, but worth a shot.
https://drive.google.com/file/d/1aiy3AS8oG7VG4fsoDDf51SK8Z_2_MC9I/view?usp=sharing
Mod List
Harmony
Core
Royalty
HugsLib
Jobs of Opportunity
RimThreaded[<IP_ADDRESS>]
Screenshots
whoops may have forgotten to take screenshots before alt f4.. srry
Edit:
Supposedly fixed in <IP_ADDRESS>

Might be fixed now, re open if needed


Added more tests and fixes for entity reference counting

Hi, thanks. Please pull b306d8f612b87700da6862d3f6f54c3bc80e0947 from https://github.com/sschmid/Entitas-CSharp/tree/mzaks-develop, i marked lines of code in ReactiveSystem that are missing tests. Could you test for that too, please :)

Ops I see there is a bug. I will fix it today. Please don't merge.

Shall I merge now?

Haha :)


Sets support to route matching ignore query string from path by default

This can be achieved by enabling by default on metal-router this option from Senna:
https://github.com/liferay/senna.js/blob/master/src/app/App.js#L85
Any objections for the change?

/cc @bawachhe Ignoring query string from route urls by default here would affect your project?

I don't think we use querystrings anywhere, only friendlyURLs; and our json urls use POST data, so I think it'd be ok.  Can you sanity-check me, @ssmith353 ?

@bawachhe, yeah. we aren't using any query strings at the moment, but we might when we implement search?

As long as this doesn't clear the query string, it'd probably still be ok, since I don't think we're planning on changing the way things are routed based on the query string.

Exactly, good to know, then we can probably make this change, thanks!


[Service Bus] Treat maxMessageCount similarly between peek and receive messages calls

peekMessages() has maxMessageCount 1 as default and is part of the options bag
receiveMessages() has maxMessageCount as a mandatory argument and is a positional parameter
This issue is to ensure that we use the same pattern among the two calls.
Our options are

Update receiveMessages() to keep maxMessageCount and maxWaitTime as optional, but positional arguments
Update receiveMessages() to move both maxMessageCount and maxWaitTime into the options bag
Add overloads to both peek and receive methods such that one takes no maxMessageCount and the other takes it as positional mandatory argument

Current API Shape:
// @public
export interface Receiver<ReceivedMessageT> {
    close(): Promise<void>;
    entityPath: string;
    getMessageIterator(options?: GetMessageIteratorOptions): AsyncIterableIterator<ReceivedMessageT>;
    isClosed: boolean;
    isReceivingMessages(): boolean;
    peekMessages(options?: PeekMessagesOptions): Promise<ReceivedMessage[]>;
    receiveDeferredMessages(sequenceNumbers: Long | Long[], options?: OperationOptions): Promise<ReceivedMessageT[]>;
    receiveMessages(maxMessages: number, options?: ReceiveMessagesOptions): Promise<ReceivedMessageT[]>;
    receiveMode: "peekLock" | "receiveAndDelete";
    subscribe(handlers: MessageHandlers<ReceivedMessageT>, options?: SubscribeOptions): void;
}

export interface PeekMessagesOptions extends OperationOptions {
    fromSequenceNumber?: Long;
    maxMessageCount?: number;
}

export interface ReceiveMessagesOptions extends OperationOptions, WaitTimeOptions {
}

export interface WaitTimeOptions {
    maxWaitTimeInMs: number;
}

cc @richardpark-msft, @chradek, @xirzec, @bterlson

I see the argument about peek() and receive() being very similar. In fact, I've made an argument about that being a negative in the past ;)
With that said - it seems that "reading more than one message at a time" is one of receiveMessages primary use cases. For receiving a single message at a time customers have two good options - subscribe() or getMessageIterator().
So removing friction for changing maxMessages (the more likely parameter to be tweaked) would say "leave it positional" rather than forcing the customer to create an options bag. If I'm picking only from the options given I'm voting for:

Update receiveMessages() to keep maxMessageCount and maxWaitTime as optional, but positional arguments

So the signature would be:
receiveMessages(maxMessages = 1, maxWaitTimeInMs = 60000)?

receiveMessages(maxMessages = 1, maxWaitTimeInMs = 60000)?

Positional arguments seem better and this looks good.

Two positional arguments isn't bad, though my argument against positionals with defaults is "what if I want to customize wait time but not maxMessages? You're making me pass an extra argument!"
Obviously the overhead here isn't bad and I have no ill feelings, but if this started to grow in the future (5 args is my tipping point) then I'd want something like an options bag.

Another option is to make the message count mandatory & positional for both peekMessages() and receiveMessages() and everything else goes to options. For peek, its the sequence number, for receive, its the maxWaitTime.
The justification would be that message count is what would be most commonly used, where as sequence number & wait time are not.

@ramya-rao-a  - if we make messageCount mandatory we're back to two overloads, right? Because it passing in a single sequence number and also being forced to pass in a message count would be odd.
Are we trying to create commonality where perhaps it doesn't exist? I'm wondering if consolidating these makes sense - they do have two different use-cases (peek is a diagnostics API that you're probably calling adhoc vs receive which is your day-to-day call that lives in a loop in your app).

if we make messageCount mandatory we're back to two overloads, right? Because it passing in a single sequence number and also being forced to pass in a message count would be odd.

Not sure if we are talking about the same apis here...
receiveMessages() does not take any sequence number
And the sequenceNumber taken by peekMessages() is like the starting point for the peek operation.
Making messageCount mandatory does not mean we need overloads. It simply would be
peekMessages(maxMessageCount: number, options?: PeekMessagesOptions): Promise<ReceivedMessage[]>;
receiveMessages(maxMessageCount: number, options?: ReceiveMessagesOptions): Promise<ReceivedMessageT[]>;

That's looks like a great signature for peekMessages() :)

I like Ramya's latest proposal. I'm allergic to positional args with defaults (3 is my hard limit, but even fewer than that I'm skeptical of).

I also like Ramya's proposal

Done with #9798


[docs] Inconsistent doc with Pulumi Cloud UI

What happened?
When reading the ESC environment documentation for the version tagging, the @ sign is used to separate the env name and its tag. However, going in the Pulumi Console, when copy/paste'ing the actual tag reference, the : character is used instead.
Example
n/a
Output of pulumi about
n/a
Additional context
n/a
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@arunkumar611 I also noticed the CLI uses @ and supports : but it's not mentioned (doc).
esc env version tag menfin/github-access-keys@prod

esc env version tag menfin/github-access-keys:prod

@aureq are we good to close out this issue? We now consistently use @


Support for tags

bootprint-swagger does not yet group methods by their tag and display tag descritpion (like swagger-ui does). If anyone wants to implement this. I believe the following changes are needed:

lib/preprocessor.js must be changed to group methods by tag (see the documentation for details about the preprocessor
partials/base/body.hbs must call a new partial instead of {{> swagger/path}}

Whoever ends up working on this, it would also be very nice if the tags can act as interactive filters on the page, in a similar way to how swagger-editor allows narrowing down large API definitions based on tags.

My plan was actually more like in the swagger-ui to group operations by their tags. I haven't planned to add interactive components yet, because I always had the use-case of "generating a PDF and printing it" in the back of my head.
But maybe you are right. Even if this is a static offline documentation that you can send by mail, filters like that would be nice. There could even be an input field that filters resources by their name...

I have implemented a tag-based table-of-contents for now. I would like to collect and discuss interactive features #29 and I have added your proposal. There are currently no js-libraries like jquery included and there is currently no clean way to do so.
I already had thought about refactoring bootprint to use customize, which would allow a clean solution to integrate scripts and interactivity. This will take some time and I would put the priorities to supporting the whole Swagger-2.0 specification before adding such features.
@erikvanzijst: Could you check the output of the new version<EMAIL_ADDRESS>and that's good enough for the moment? We will get filters some time, I'm sure, but for now. Is my solution, ok?

Thanks, that was very quick! I gave 0.6.9 a go and tags are working.
I'm evaluating bootprint-swagger for potential use as Bitbucket's upcoming API documentation overhaul, so I appreciate the quick fix!

We will get filters some time. But for now, I would like to stick with the current implementation

Absolutely. I agree that full 2.0 support is more important. I also think the current lack of javascript is great for offline use and so interactive elements are not a requirement for me.

That's great. If there are any parts of the spec, that are missing as features or issues, please let me now.