csv import to postgresql miss lines while importing

System information:

MacOS Mojave 10.14.4
DBeaver version <IP_ADDRESS>907061627
java version "10.0.1" 2018-04-17
No additional extensions

Connection specification:

PostgreSQL 11.2 (Debian 11.2-1.pgdg90+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516, 64-bit
Driver PostgreSQL JDBC Driver
Do you use tunnels or proxies (SSH, SOCKS, etc)? no - running the postgress within docker.

Describe the problem you're observing:
I was trying import large amount of data (1gb - 1685587 lines / 96 columns) using dbeaver to a postgresql, the import process ends without any issues/errors but only<PHONE_NUMBER>00 lines are being imported and its not constant.
When using other tools such as TablePlus to do the import all the lines are being imported correctly.
I've create a smaller csv with 11 lines / 96 columns (first line is a header line) and only 9 lines imported with dbeaver
Steps to reproduce, if exist:
Create 96 columns (maybe less) csv file with 10+ lines
Create a table structure to hold the data (i've used pgfutter)
Right click the table and choose import data, choose csv and follow the wizard
By the end do select count(*) on the table and notice that the number of rows is differ from the number of rows by using wc -l on the csv file.
If needed i can supply the csv files that i was using as they contain public data.

Cannot reproduce an issue for now.
If it is still actual for you - feel free to reopen the ticket.
Best regards,


portfolio: 0.65.1 -> 0.65.3

Description of changes

https://github.com/portfolio-performance/portfolio/releases/tag/0.65.2
https://github.com/portfolio-performance/portfolio/releases/tag/0.65.3

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Can you Update the PR to 0.65.3? I'll try to test my scenario at the European evening today then

Result of nixpkgs-review pr 253173 run on x86_64-linux 1

1 package built:

portfolio


panic creating an enormous slice in hh/queue.go

We are on 0.9.0 on RHEL7. Box has 128G RAM and 16 cores. Cluster of 3, r=3, n=3.

Its worth noting that we had about 2 million goroutines at this point (according to the panic), so while this is far outside something i'm expert at I wonder if that check can be done before calling make, and return an error back before this value rather than relying on a runtime panic.

@daviesalex Can you provide a sample of the data being written?
Also, could you log a different issues regarding the 2 million goroutines and include the full stack trace in a gist? That should be investigated.

We were running tcollector on the client nodes, so its hitting the openTSDB endpoint and as it happens I have a tcpdump from about this time. There was about 40Mbit of this traffic on all 3 nodes:
put proc.interrupts<PHONE_NUMBER> 0 type=ERR cpu=0 host=host--capture07 firm_bu=infrastructure firm_dc=chl firm_ev=xx
put proc.interrupts<PHONE_NUMBER> 0 type=MIS cpu=0 host=host--capture07 firm_bu=infrastructure firm_dc=chl firm_ev=xx
put sys.numa.zoneallocs<PHONE_NUMBER> 227931 node=0 type=hit host=host--capture07 firm_bu=infrastructure firm_dc=chl firm_ev=xx
put sys.numa.zoneallocs<PHONE_NUMBER> 0 node=0 type=miss host=host--capture07 firm_bu=infrastructure firm_dc=chl firm_ev=xx
put sys.numa.foreign_allocs<PHONE_NUMBER> 0 node=0 host=host--capture07 firm_bu=infrastructure firm_dc=chl firm_ev=xx
put sys.numa.allocation<PHONE_NUMBER> 227893 node=0 type=local host=host--capture07 firm_bu=infrastructure firm_dc=chl firm_ev=xx
put sys.numa.allocation<PHONE_NUMBER> 38 node=0 type=remote host=host--capture07 firm_bu=infrastructure firm_dc=chl firm_ev=xx
put sys.numa.interleave<PHONE_NUMBER> 19780 node=0 type=hit host=host--capture07 firm_bu=infrastructure firm_dc=chl firm_ev=xx

I will see if we can replicate the 2 million goroutine situation; I suspect we can under high loads. Sadly, we did not at this point have decent logging due to systemd's inability to play nicely with the stderr method of logging; we are going to work around this by having systemd call a shell script which calls influx.

@daviesalex Can you try with 0.9.1? Clustering in 0.9.0 was pre-alpha (meaning no one tested anything)

Sure - feel free to close this. Our internal conclusion was that the OpenTSDB endpoint does not work with clustering at all (we find this with 0.9.2 after upgrading; the data simply does not get replicated between nodes). We moved to using the native protocol for other reasons, which appears to work.
We have yet to really stress test the native protocol endpoint, but it appears to work much better!

@daviesalex glad the native endpoint is working well!


ES-profile-branch

Perhaps the same < > issue as #25 ?

Yep, As @ccontrer mentioned, the values in the _index.md shouldn't have < and > around them, that wasn't clear enough in my notes. Please edit the _index.md file to remove to so e.g.
title: <Elham_Soufiani>

becomes
title: Elham_Soufiani

When you've done that for all of the lines, hit commit and the PR should automatically updated. Also you'll need to upload a profile photo. If you don't want to use a photo of yourself you can download a generic avatar image and upload that. When you upload it should be called
content/authors/Elham-Soufiani/avatar.jpg

With those changes I think this will be ready to merge.

@ccontrer @ianabc Would you please help me how should I change it? I wasn't able to find the exact place for correcting them.


added fortune teller app

issue number: #2244
added digital fortune teller

@iamrahulmahato pls check my pr


SSI-Streetcred: Creation of the Streetcred entities

Context: We will be using Streetcred as an easy way to get up and running with a Hyperledger Aries cloud controller and wallet. Streetcred has a number of different concepts which we will be required to implement:

Organisations: Act as the issuers of verifiable credentials (VCs).
Credential definitions: Define the format which VCs can take.
Verification templates: Define what data to request from a wallet when a verification is required.

Issue: Unsure on how these entities should be managed across the development efforts, and how their credentials, e.g. the access tokens for an organisation, should be shared.

Is it best practice that each developer will have a dummy organisation, and set of their own templates?
We will need to create a master account which represents the true Opus account for when users begin to sign up. Who owns this account? Can we add multiple developers to this account?
How flexible are credential definitions to modification further down the line?
Do you want a single master credential definition for each usage pattern or can you have duplicates? Does it make a difference?

Next steps: This is a discussion point more than anything and so thoughts and feedback would be greatly appreciated.

Couple of points from me.
For development purposes:

We should between us come to a decision of the (single?) schema that we will use at least for development purposes.
The ID for this schema should then be included in the repo .env-template file.
Each developer should create their own organisation on streetcred.
They then must write a credential definition against the schema identifier as defined in the Readme.
Verifications is a bit different as nothing is stored on the ledger, but I suggest we create a template and include in the repo so all devs can write the same template their cloud agent.

There is a syntax issue here too. We might want a single master credential schema, but every organisation must create a credential definition against this schema before they can issue them.
For production, it is possible to version credential schema however every time a schema is updated organisations that wish to issue that schema must write new definitions to the ledger.


Build with /guard:cf

Picotorrent seems to be already built with /DYNAMICBASE, /HIGHENTROPYVA and /NXCOMPAT:
Get-PESecurity -File 'C:\Program Files\PicoTorrent\PicoTorrent.exe'

ARCH             : AMD64
DotNET           : False
ASLR             : True
DEP              : True
Authenticode     : False
StrongNaming     : N/A
SafeSEH          : N/A
ControlFlowGuard : False
HighentropyVA    : True

Would it be possible to add /guard:cf for the full roster of mitigations?

Hi! Sounds reasonable. I'll add it as a feature request 😃

I've added this to the release builds for 0.19.

This was fixed in #843 and will be released soon.


Map zooming out

When zooming in, the map zooms automatically out again @12rambau Any idea?

I think I do let me have a look


[Bug] where，某些情况下多个条件无法被正确解释？

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
2.0
What's Wrong?
示例如下：
条件1

返回了正确结果；
条件2

返回了正确结果；
条件1 and 条件2

返回了错误结果；
What You Expected?
1
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Your question is not clear. I do not think if both 1 and 2 has result, then 3 has result....

 Your question is not clear. I do not think if both 1 and 2 has result, then 3 has result....

确实如此，但我并不是通过1,2有结果推导出3应当有结果，而是已经知道1,2,3都有结果，然后检验 doris 是否能返回正确结果，验证的结果是 1,2 返回了正确结果，3返回了错误结果。通过进一步测试，我发现在3场景下总是返回错误结果

是否可以先向表中插入一条满足3查询条件的数据然后再进行查询测试

是否可以先向表中插入一条满足3查询条件的数据然后再进行查询测试

表中有已经有数十万条满足3查询条件的数据，这也是我为什么说3返回了错误结果的原因

设置 set experimental_enable_nereids_planner = false; 可解决


Support more expressions in equality join

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently some equality joins which contain normal expressions will run as cross join.
For example:
❯ explain select * from test0 as t0 inner join test1 as t1 on t0.c0 + 1 = t1.c0;
+---------------+-----------------------------------------------------------------------------------------------------------+
| plan_type     | plan                                                                                |
+---------------+-----------------------------------------------------------------------------------------------------------+
| logical_plan  | Projection: t0.c0, t1.c0                                                                                |
|               |   Filter: CAST(t0.c0 AS Int64) + Int64(1) = CAST(t1.c0 AS Int64)                                          |
|               |     CrossJoin:                                                                                |
|               |       SubqueryAlias: t0                                                                                |
|               |         TableScan: test0 projection=[c0]                                                                  |
|               |       SubqueryAlias: t1                                                                                |
|               |         TableScan: test1 projection=[c0]                                                                  |
| physical_plan | ProjectionExec: expr=[c0@0 as c0, c0@1 as c0]                                                             |
|               |   CoalesceBatchesExec: target_batch_size=4096                                                             |
|               |     FilterExec: CAST(c0@0 AS Int64) + 1 = CAST(c0@1 AS Int64)                                             |
|               |       CrossJoinExec                                                                                |
|               |         RepartitionExec: partitioning=RoundRobinBatch(32)                                                 |
|               |           ParquetExec: limit=None, partitions=[test0.parquet], projection=[c0] |
|               |         RepartitionExec: partitioning=RoundRobinBatch(32)                                                 |
|               |           ParquetExec: limit=None, partitions=[test1.parquet], projection=[c0] |
|               |                                                                                |
+---------------+-----------------------------------------------------------------------------------------------------------+
2 rows in set. Query took 0.008 seconds.

We can move these to hash-join to improve performance.
Describe the solution you'd like
Move these equality joins from cross join to join in logical and physical plan.
In addition, it also helps to fix:

https://github.com/apache/arrow-datafusion/issues/2877

Describe alternatives you've considered
Additional context

maybe it related to the subquery and the type coercion.

Yes, it is relative to type coercion.
The issue is not very detailed, Let me add a little more.
Currently our LogicalPlan::Join(..) only supports column equality for join, so does physical plan.
https://github.com/apache/arrow-datafusion/blob/a32fb657d1caec634cb53979b2f7ef2fad224905/datafusion/expr/src/logical_plan/plan.rs#L1488
https://github.com/apache/arrow-datafusion/blob/a32fb657d1caec634cb53979b2f7ef2fad224905/datafusion/core/src/physical_plan/joins/hash_join.rs#L125
We can extend column to normal expression, then datafusion can support more equality joins.
That means:

If all columns of left side expression are in the left schema, and so does right side, parse as equality joins.
Other wise, parse as cross join.

For #2877, since the join unit is expression, we can wrap cast in type coercion phase when data types of two side is not same.

Sounds like a good plan. Any expression of the form e1=e2 should be supported in equality joins.

maybe it related to the subquery and the type coercion.

Yes, it is relative to type coercion.
The issue is not very detailed, Let me add a little more.
Currently our LogicalPlan::Join(..) only supports column equality for join, so does physical plan.
https://github.com/apache/arrow-datafusion/blob/a32fb657d1caec634cb53979b2f7ef2fad224905/datafusion/expr/src/logical_plan/plan.rs#L1488
https://github.com/apache/arrow-datafusion/blob/a32fb657d1caec634cb53979b2f7ef2fad224905/datafusion/core/src/physical_plan/joins/hash_join.rs#L125
We can extend column to normal expression, then datafusion can support more equality joins.
That means:

If all columns of left side expression are in the left schema, and so does right side, parse as equality joins.
Other wise, parse as cross join.

For #2877, since the join unit is expression, we can wrap cast in type coercion phase when data types of two side is not same.

cc @mingmwang

I can take a look at the issue.
My current preference is to keep the equal join condition as columns, but add another projection to project the expression to normal columns and push down the projection.
The major reason is

Complex equals join conditions will cause duplicate calculation:
A inner join B on (udf1(A.a) = udf2(B.b))

The first time calculation happens when during the Repartition, Repartition expr will take the exprs now and need to evaluate.
The second time calculation happens when building the hashtable or comparing.

Some guys might write wrong expressions as join conditions
A inner join B on (A.a = B.b = B.c)
This expression is actually a valid expression and can be evaluated, but could cause wrong join result, similar to cross join.

A.a = B.b -- result of evaluation is bool type
(A.a = B.b) = cast(B.c as bool)

Maybe we can also take a complex approach and check the expression's complexity

if the expressions are trival cast, support them as equal join conditions

logical plan
A inner join B on (Cast(A.a) = Cast(B.b))
   TableScanA
   TableScanB

physical plan
A inner join B on (Cast(A.a) = Cast(B.b))
   Repartition(Cast(A.a))
       TableScanA
   Repartition(Cast(B.b))
       TableScanB

if the expressions are complex, add projections

logical plan
A inner join B on (udf1(A.a) = udf2(B.b + xxxx))
   TableScanA
   TableScanB

physical plan
A inner join B on (col1 = col2)
   Repartition(col1)
   Projection(udf1(A.a) as col1, A.*)
       TableScanA
   Repartition(col2)
   Projection(udf2(B.b + xxxx) as col2, B.*)
       TableScanB

if the expressions are suspicious, return error in logical plan
return Error.
A inner join B on (A.a = B.b = B.c)

And I just added the EquivalenceProperties/EquivalentClass to the physical execution plan, if we plan to support expressions as equal join conditions, I need to enhance the EquivalenceProperties/EquivalentClass related logic as well.
@yahoNanJing @alamb

Thank you @mingmwang @alamb.
Agree with your suggestion to implement this with another projection. I will work on it.


[QMenu] Remove whitespace and add "checked" icon style

Please see related issue https://github.com/dracula/freecad/issues/4
All stylesheets other than ExtremeProDark have superfluous whitespace in dropdowns, but lack any highlighting for "checked" icons such as Orthographic vs Perspective view.
This PR adds solution proposed by MisterMakerNL in said issue.
I have chosen "Purple - #bd93f9" from the Dracula palette as the "checked" color here to fit the theme.
Before:

After:

Thanks @Chrismettal!


Use black to format files

Codecov Report

Merging #232 (f0194be) into main (c0e1680) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   96.42%   96.42%
=======================================
  Files          31       31
  Lines        1819     1819
=======================================
  Hits         1754     1754
  Misses         65       65

Impacted Files
Coverage Δ

robotidy/transformers/OrderSettings.py
98.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e1680...f0194be. Read the comment docs.


fix: adapt glci to Garden Linux builder

What this PR does / why we need it:
With the advent of the Garden Linux builder, the ways glci must interact with the Garden Linux repo and its build pipeline has changed yet again - those changes are addressed in this PR.
Release note:

The glci publishing gear is adapted and updated to work with the new Garden Linux builder.

/ready


firejail: 0.9.56 -> 0.9.58

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/firejail/versions.
meta.description for firejail is: '"Namespace-based sandboxing tool for Linux"'.

Checks done (click to expand)

built on NixOS
Warning: no invocation of /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58/bin/firejail had a zero exit code or showed the expected version
/nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58/bin/firemon passed the binary check.
/nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58/bin/firecfg passed the binary check.
2 of 3 passed binary check by having a zero exit code.
2 of 3 passed binary check by having the new version present in output.
found 0.9.58 with grep in /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58
directory tree listing: https://gist.github.com/adfd85a02c278175d39675af68a3182f
du listing: https://gist.github.com/fe5adf1ab391e332dfcb3257372e413f

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
firejail

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A firejail https://github.com/r-ryantm/nixpkgs/archive/0e28f3c31883bff7b4ea19cba77d66416418d10c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58
ls -la /nix/store/92n01l68asymyv48p7if4ck22wp06695-firejail-0.9.58/bin

cc @7c6f434c for testing.

Tested it using
nix-review pr 55322

Problem is that firejail needs a sticky bit. So I could only test it using sudo firejail. I tested that with some parameters, and it worked fine.
Don't know if this is enough, to merge this pull-request.

@GrahamcOfBorg build firejail

@mrVanDalo Thanks for the testing! firejail is a bit of magic in advance use anyway, and I don't think the way of giving it privileges has ever mattered.


Update code to stop crashing

Haven't really tested this, because I don't have a "crashy device" right now. The code seems to look good!


Django 1.7 compatibility

Add compatibility for Django 1.7 by checking for the presence of Model._meta.model_name to prevent deprecation warnings, and allowing newest version of django-jsonfield to be used.

I added Django 1.7 compatiblity in https://github.com/disqus/gargoyle/pull/93 . I'll open a separate issue for the deprecation

Added the deprecation change in https://github.com/disqus/gargoyle/pull/95
This PR can be closed


Document that nested tasks don’t work

Dagger does not support nesting tasks. This should be documented somewhere.

Related to #2303


React step 3 new

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Commiitted the code


Do not convert agent_id to int in JobType.node()

It is a UUID now, converting to int will fail.

Thanks, merging.  I didn't get a chance to test job types yet so I'm not surprised there's issues there still (especially since test coverage is lacking).


Bug: uploading files larger than 1GB

Description
When uploading a file larger than 1GB thread panics.
Error Message

[00:04:45] [=======================================>] 1020.00 MiB/1.00 GiB (3.68 MiB/s) Uploading                                                                   thread 'main' panicked at 'attempt to multiply with overflow', ../.cargo/registry/src/index.crates.io-6f17d22bba15001f/dco3-0.4.1/src/nodes/upload.rs:379:37

Link to code line
https://github.com/unbekanntes-pferd/dco3/blob/2ff39127306bd0b6a508d0b2dbacc289c68091de/src/nodes/upload.rs#L391C1-L391C83
PS:
Please add labels ;)

@semtisem thanks - issue should be fixed with https://github.com/unbekanntes-pferd/dco3/pull/13
I'm not sure what the issue with labels is though - they are available, but you cannot set them, not being a maintainer.


feat: bitvector constant folding simprocs

Description:
This simproc simplifies expressions by attempting to constant fold using omega to make sure we never see modulos, and moves all arithmetic constants to the left.
The goal is for this to be upstreamed sooner rather than later.
Testing:
What tests have been run? Did make all succeed for your changes? Was
conformance testing successful on an Aarch64 machine?
Conformance passes locally.
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.

@alexkeizer all comments addressed!

@bollu Could you please squash and merge if CI succeeds?


Minor fix

The value HyperText Markup Language is in PascalCase, the test has the name Camelcase. This just updates the test name to be PascalCase.

Good catch. Thanks! :tada:


Added Israeli flag

@hillai Hey! Thank you for contributing! :smile: This looks great! But we already have PR #32 for this.
I'll keep this open and if other maintainer stops responding, I'll merge this.

Oh :( Haven't noticed. I think mine looks closer to the original but sure. Cheers!

So... what's up with that other PR? Doesn't really seem active :sweat_smile:

@hillai Can you resolve merge conflicts so we can land this? :smile:


admin: increase source title widget length

Fixes #907 by updating the widget of the title field in the source admin form.

Note: I wasn't sure what Debra meant by "provenance note" field. I can't seem to find that anywhere.


Automated cherry pick of #59: use distribution pkg parse image

Cherry pick of #59 on release/3.1.
#59: use distribution pkg parse image

/lgtm
/approve


 onClick isn't trigged

No <a> children of SortableElement ever triggers onClick due this:
https://github.com/clauderic/react-sortable-hoc/commit/008d8789acc23230a0ef18ccd270819a79a5250d
Reproduceable example:
https://codesandbox.io/s/xoynwoo40o

You should define a value for the distance prop on the SortableContainer.
https://github.com/clauderic/react-sortable-hoc#click-events-being-swallowed

@cusxio, thanks for the help, but it doesn't solve the problem. Once mouseDown was prevented, click will never be fired. You can see it right here: https://codesandbox.io/s/91l82zxyjr

Were you able to solve this? I'm facing the same issue.

@riccardo92 just with workarounds. We are helpless due to https://github.com/clauderic/react-sortable-hoc/commit/008d8789acc23230a0ef18ccd270819a79a5250d

Any suggestion for workaround?

It depends too much on your application and specific details. In my case, I've used the SortableHandler to make only a image below the link draggable

In my case I have added the argument pressDelay={100} to the Sortable List props. So I have :
<SortableList pressDelay={100} items={this.state.items} onSortEnd={this.onSortEnd} />

In that way you can trigger the click on the a AND drag the a less than 1 s after the click.

I changed  to  and onClick starts working

Add distance={ 2 } to your <SortableList .....> then check
https://codesandbox.io/s/n9160x16n4

Refer to how this component updates the value of state, because I have a delete event, click to delete one


ENH: add reduction keyword to pwelch

This PR adds ability to specify reduction to apply to welch windows (#3336)
It's actually part of #3820 with some tests added.
@Eric89GXL I was looking for a branch/stash fixing #3621 and found this instead. But I'll push PR adressing n_fft issue today.
This adds reduction keyword argument for reduction across windows, where that can be either 'mean', 'median', callable or None:

'mean' and 'median' perform mean or median respectively
callable is called on the windows (may additionally ensure that window dimension was reduced)
None omit the reduction so psd_welch returns an array of shape windows x channels x freqs for raw and windows x epochs x channels x freqs for epochs.
@kingjr proposed using float values < 0.5 for trimmed mean - I've implemented it here too (using scipy.stats.trim_mean)

I've added it as get_reduction to mne.utils. It can also be private if you prefer.
I've also added a few tests to test_psd - they pass locally, but I'll see what CIs have to say.
❗ the windows are the last dimension if a reduction is applied (so if custom function is used it has to reduce across axis=-1), but when reduction is None they are moved to the -3 dimension. This means that raw output is of diemnsions windows x channels x freqs and epochs are of epochs x windows x channels x freqs ❗
TODOs:

[ ] I'll modify existing tutorial/example that shows how to use reduction
[ ] I'll add a whats new entry once all is cool (CIs green, comments adressed etc.)

Closes #3336

Sounds good.

I've added it as get_reduction to mne.utils. It can also be private if you prefer.

Yes, private please.

the windows are the last dimension if a reduction is applied (so if custom function is used it has to reduce across axis=-1

That's what I would expect

but then it might be even more confusing - with windows being first or second dim depending on input type...)

You can just say that the output dimensions will be shape (..., n_windows, n_freq, n_time), i.e. windows are the -3 dimension. I think this is better than always putting them first.

I can add an example that shows how to use reduction (but may be a separate PR, I guess)

I would say just change an existing example to use reduction='median' just to make people aware of it

Codecov Report

Merging #4000 into master will decrease coverage by -0.3%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master    #4000     +/-   ##
=========================================
- Coverage   86.06%   85.76%   -0.3%
=========================================
  Files         349      349
  Lines       62680    62709     +29
  Branches     9591     9602     +11
=========================================
- Hits        53945    53785    -160
- Misses       6040     6223    +183
- Partials     2695     2701      +6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1182668...cada718. Read the comment docs.

I've changed np.moveaxis to np.rollaxis - the former is not present in older numpy.
Can I save the lambda in the tests? flake doesn't like me for using lambda - but I like the one-liner better than creating a def...

Why not make all well with the universe and do:
windows_max, freqs = psd_welch(
    raw, proj=False, reduction=lambda x: x.max(-1), **kws_psd)

Otherwise we'd need to add # noqa: EXXX mmagnuski disapproves of this PEP8 and that's not a design pattern we want to embrase...

Scipy 0.12 problem: TypeError: trim_mean() got an unexpected keyword argument 'axis'
One option is to use scipy.stats.mstats.trimboth - it was present in scipy 0.12 and has an axis kwarg.

Did the old one operate on an axis or raveled array?

The old trim_mean was undocummented, but used stats.trimboth which does a[lowercut:uppercut] so along first dimension.

What do you suggest then? Backport to fixes?

Yes, I'd add this to fixes. I'll commit that later (tomorrow - European time)

@Eric89GXL sorry for the delay, I've added _trim_mean to fixes, now CIs should come back green - then I'll add whats new (and I'll have to rebase once #4003 gets merged).

One Test object size estimation. failure and one valid because I forgot to use fixes.get_trim_mean in tests.

object_size is fixd in master now

Ok, I'll rebase later today.

@mmagnuski please set to MRG if it's ready from your end

Which example should I modify? I started changing the tutorial on freq analyses in channel space but it uses psd_multitaper - so I started adding a comparison between welch and mutlitper and then I stopped being sure whether it should be added there (and whether it requires such changes). I didn't see any examples that use psd_welch (apart from real-time acquisition with fieldtrip buffer or plotting custom topographies).

Travis errors seem to be unrelated: one job threw lots of docstyle errors from viz/utils at me and the other timed out when downloading mne test data.

@mmagnuski yes I'll update plot_sensors_time_frequency.py with a section on the PSD of Raw data before going to Epochs.

Sorry for the delays here, I was busy lately, I'll try to finish it this week.

Will you use combine if my epochs.plot_image code is merged first? :)

Thanks for reminding, the only thing keeping me from finishing this was an example, but I hope to find the strength to finish it soon. :)
Yes, I am fine with combine, it is shorter and sounds better than reduction.

@mmagnuski you'll need to rebase

@agramfort - rebased and finally added the changes to the tutorial.
Things still on the todo list:

[ ] change reduction to combine
[ ] fix _get_reduction to use nanmean, nanmedian etc.

The tests WILL fail now - I'll have to use nanmean instead of mean for tests checking psd_welch to accept annotated data. Take a look at the example in the meantime (I'll post a link soon).

example:
https://4869-1301584-gh.circle-artifacts.com/0/tmp/circle-artifacts.kvljUX2/html/auto_tutorials/plot_sensors_time_frequency.html

New link to the docs:
https://4872-1301584-gh.circle-artifacts.com/0/tmp/circle-artifacts.8pJ2deA/html/auto_tutorials/plot_sensors_time_frequency.html
@Eric89GXL @agramfort
I am now awaiting your comments. (I may have some pep issues so don't worry if travis is angry) Especially with respect to the tutorial changes as all previous changes seemed to have been accepted before. One thing I could change in the tutorial is remove the njobs=1, which shows up in many places but is actually the default.

One more thing - currently using float in combine which gives trimmed mean is not super-safe against nan values. You will get nan if no trimming is performed (when the trim percentage is too low with respect to number of samples). I can leave it like this or try fixing/adding a warning.

(I'll add whatsnew once everything is accepted to avoid conficts)

Ok, all is good, only these flake errors remain (will fix them later today):
mne/time_frequency/tests/test_psd.py:6:1: F401 'scipy.stats.trim_mean' imported but unused
mne/time_frequency/tests/test_psd.py:11:1: F401 'mne.utils.requires_version' imported but unused
mne/time_frequency/tests/test_psd.py:101:5: F811 redefinition of unused 'trim_mean' from line 6
tutorials/plot_sensors_time_frequency.py:83:1: E402 module level import not at top of file

One thing I could change in the tutorial is remove the njobs=1, which shows up in many places but is actually the default.

Last I knew @agramfort liked having this to expose the parameter. But I'm fine with removing it.

One more thing - currently using float in combine which gives trimmed mean is not super-safe against nan values. You will get nan if no trimming is performed (when the trim percentage is too low with respect to number of samples). I can leave it like this or try fixing/adding a warning.

As long as trimming is not the default mode and people won't hit this by default I think it's okay to say in the docs about the NaN possibility (and emit a warning accordingly)

@Eric89GXL
actually I think it would be easier to use the trimmed mean we have in fixes and change mean to nanmean there.

Two Travis jobs exceeded the maximum time limit for jobs, and have been terminated.

is this WIP or MRG?

@agramfort It's actually MRG - I'm holding off whatsnew untill all is accepted. The Travis builds are green, red is because two of them keep timing out.

Travis passes other than timeouts

Rebased and adressed comments.

Oh green, haven't seen you in some time... 💚
I still have some comments from myself to resolve tomorrow, otherwise - waiting for anoter reviewer (@agramfort? :) )

@jaeilepp  can you look?

@jaeilepp raises concern as to confusing differences in psds shape between psd_welch and psd_array_welch when combine=None:

psd_welch returns windows at -3 dimension
psd_array_welch returns windows as the last dimension

I agree that it may be confusing, the reason for this is that psd_welch has only two options of input data shapes: Raw (ch x samples) or Epochs (epochs x ch x samples) while psd_array_welch has much more possibilities and putting windows at -3 dim would not always work.
In simpler case of psd_welch -3 dimension corresponds to windows x channels x freqs for Raw and epochs x windows x channels x freqs for Epochs, which makes sense to me: windows are treted as sub-epochs by their placement in the dim hierarchy.
However for psd_array_welch the input can be also 2d or even 1d and the output dimensions would be complicated (epochs x samples -> windows x epochs x samples) so windows are kept as the last dimension.
The other possibilities would be to:

(B) always have windows as the last dimension (I don't like it so much but can live with that)
(C) always have windows at -3 dimension unless input is 1d - then windows would be at -2 dim (it used to be this way but Eric suggested to simplify by moving the reshaping to psd_welch).

I am ok with A (current behavior) and C but can live with B - so I'll let you all decide. :)

Ok I'm convinced. A option is good for me. Could you add a comment in the Notes section of psd_array_welch that the results are not equivalent to psd_welch when combine=None.

After that MRG+1 from me.

@jaeilepp - sure, I'll add that.

@jaeilepp comments adressed :)

psd should convert time dim to freq dim and leave the other dims untouched.
Now if you have windows either we make it an axis at the end or at the
beginning. After this test:
In [1]: import numpy as np
In [2]: A = np.random.randn(200, 40, 60, 200)
In [3]: %timeit A.sum(-1)
10 loops, best of 3: 71.4 ms per loop
In [4]: %timeit A.sum(0)
10 loops, best of 3: 116 ms per loop
I think the windows should be at the end as we tend to average over it.

Yes, operations along last dim should be faster due to layout in memory, but I am not sure that one would use combine=None just to immediately average over windows - its better to pass something to combine in that case (np.mean for example, which is faster than current default - np.nanmean). Originally (in psd_array_welch) the windows are the last dimension to allow for raster reduction. But when someone does not want to reduce windows (combine=None) my assumption was that it might be better to reformat the data so that windows are treated similarily to epochs so that psd is of shape: windows x channels x frequencies or epochs x windows x channels x frequencies.
But having windows as last dimension is simpler for sure - is there consensus for windows to be -1?

all choices are ok if we are consistent and if a decision needs to be made
performance can play a role.
Now i also have the argument that axis=-1 should always be time or
frequency so ...
just make a choice, document it and make sure it's consistent.

I have to agree that psd_welch - psd_array_welch consistentsy as proposed in this PR is a little Trupesque. -3 would be consistent, but complicated (as discussed previously) so that leaves us with -2 or -1. windows are a measure of time and the module name is time_frequency so that would make windows -2 😃 Besides -2 looks like a sunset and a swan, but -1 is fine too, although it does not look comparably sweet. :)

can you please summarize the current plan?

Current proposed behavior is summarized in a previous post where I start with saying that "jaeilepp raises concern ...", the plan can be to make windows always -1 instead.

Usually time-freq data is freq x time (contrary to the name) which is another argument for -1, so let's go with that.

Oh, true, I didn't consider that: it makes sense altogether, now I am at peace with windows at -1. :)

BTW - this PR also fixes IndexError when integer is passed to picks in psd_welch. But maybe I'll add a test for that and whatsnew bugfix entry in a followup PR? This one is already pretty slow. :)

arfff my bad. Forget it

see how it looks like:
https://4927-1301584-gh.circle-artifacts.com/0/tmp/circle-artifacts.JGVLnXY/html/auto_tutorials/plot_sensors_time_frequency.html
why would you want to do trimmed mean on EEG in the first place?

why would you want to do trimmed mean on EEG in the first place

Well, I'm not sure if I would be doing that but in the original issue about adding reduction options to psd @kingjr proposed trimmed mean and your response was:

yes I think that trimmed mean would be nice.
😋

(BTW - I checked the example before - it looks ok for me, is something wrong with how it looks?)

the answer I was expecting is "I think it's a useful option to get robust
spectral estimates from potentially noisy data"
if you had said this, I would have asked that you illustrate this in an
example :)

(BTW - I checked the example before - it looks ok for me, is something
wrong with how it looks?)

it was just for others to see / comment

if you had said this, I would have asked that you illustrate this in an
example :)

Ah, ok - I though you are asking why would I use trimmed mean over median.
Actually my own interest in adding combine is the None option where I get all the windows and can fit gamma distribution to power distributions of the alpha peak for example. That's why my example went in this direction. But I agree that using median/trimmed mean to be more robust against artifacts may be the more poular scenario. I just think that people should be aware that they will always get reduced spectrum even if all their signal is super-artifact-free. I can try too look into mne sample data for some raw file segments with some artifacts and resketch the tutorial, but I will be able to do it only later this week.

it was just for others to see / comment
Ok, I wasn't sure because I posted the link previously and the example didn't change since then. :)

no rush :)

Hm, yes I agree that it is kind of weird. :) I can change it to median or
I'll change that example later so that psd_welch is presented on raw data
(as you suggested in other comments).

+1
just add a note here to crossref the two functions and mention that
psd_welch is available but is more natural to use on Raw cf
plot_visualize_raw.py
thanks a lot

@mmagnuski you need to rebase.
any hope to complete this soon?
I am thinking about pushing a release soon.

Yes, I can take a look during the weekend and finish the remaining issues here.

thanks great

@mmagnuski you need to rebase. Let's try to finish this before the release late august

Yes, I'll finish this within a couple of days, sorry.

Ping @mmagnuski it's getting close to release time, any time to polish this one?

Yes, I should finally have time for that soon. Another option is that I revert changes to tutorial, we merge this now and I add a follow-up PR for changes in the tutorial. Everything else is finished here.

revert changes in the tutorial you touched and just show the new option in:
https://martinos.org/mne/stable/auto_tutorials/plot_visualize_raw.html
we do raw.plot_psd there. Again let's show case this option for raw object

@mmagnuski any time for this one now?

Yes, I should finally have time for this in next few days! :)

@mmagnuski any time to come back to this one? You'll probably want to start fresh because of how many viz / PSD functions have changed :(

Ah, my forgotten baby! I got a bit stuck last time trying to find artifacts in test data that would demonstrate usefulness of these reductions. I didn't go very far with this as my main interest was originally in using better estimates of non-gaussian single-trial-power distributions, not necessarily artifact-robustness. But being able to get all the windows without reducing them would be enough gain for me from this PR actually.
I was promising to get back to this PR so many times already that I'm not going to do the same this time - but I'll try to surprise you with a new PR in not so distant future. ;)

Sounds good :)

@mmagnuski you might be interested in this
https://github.com/scipy/scipy/pull/8970/files


About the contra_hybrid_loss

the loss named bce_loss，but infact you used FOCAL_loss when calculating BCE_loss.Is this the result of negligence？

when gamma=0 and alpha=None, the Focal loss is equivalent to BCE loss. Note that the contra_hybrid_loss is still hybrid_loss, because "self.contra"  didn't used in the forward function.

Oh,yeah!Thank you!


Not working on Android, RN 0.29

Attempt to invoke virtual method 'void android.app.Activity.runOnUiThread(java.lang.runnable)' on a null object reference
SplashScreen.java: 35, show function.
I'll try to make a PR compatible with RN 0.29.

I just pushed a RN 0.29 compatible version last night. It's a huge hack and I haven't had time to document it. You need to store the package ref before the getPackages call and make sure to call setActivity on the onCreate in MainActivity.
If you have a better idea id love a PR.

Take a look on my fork:
https://github.com/avishayil/rn-splash-screen
It works fine, but the only caveat is when you resume an activity, the splash is not being shown on Android.
If you kill the activity form the recent apps, it shows fine.

@avishayil Why do you use postDelayed ?

For safety. sort of like making sure that the activity exists before removing the splashscreen.

The splash screen is removed from javascript where its guaranteed to exist. I can see adding a configurable delay if you don't want to finetune where exactly its hidden.

@avishayil Also it looks like your splash screen fork loads too late some times. There is a data race.
Looking into a solution now as my earlier hack is awful.

This should be resolved; check the revised documentation


AIRAM-CTR.U enhancement

I noticed after updating firmware on the stick to latest version and mqtt2zigbee software to 1.4.0 that I receive actions from AIRAM-CTR.U -remote now!
Power on/off presses:
No converter available for 'AIRAM-CTR.U' with cid 'genOnOff', type 'cmdOff' and data '{"cid":"genOnOff","data":{}}'
No converter available for 'AIRAM-CTR.U' with cid 'genOnOff', type 'cmdOn' and data '{"cid":"genOnOff","data":{}}'

Dim single press:
No converter available for 'AIRAM-CTR.U' with cid 'genLevelCtrl', type 'cmdStep' and data '{"cid":"genLevelCtrl","data":{"stepmode":1,"stepsize":20,"transtime":3}}'

Dim hold:
No converter available for 'AIRAM-CTR.U' with cid 'genLevelCtrl', type 'cmdMove' and data '{"cid":"genLevelCtrl","data":{"movemode":1,"rate":100}}'

Brighten single press:
No converter available for 'AIRAM-CTR.U' with cid 'genLevelCtrl', type 'cmdStep' and data '{"cid":"genLevelCtrl","data":{"stepmode":0,"stepsize":20,"transtime":3}}'

Brighten hold:
No converter available for 'AIRAM-CTR.U' with cid 'genLevelCtrl', type 'cmdMove' and data '{"cid":"genLevelCtrl","data":{"movemode":0,"rate":100}}'

And last button, which is for "restore scene" gave a lot of information:
First press:
No converter available for 'AIRAM-CTR.U' with cid 'genBasic', type 'devChange' and data '{"cid":"genBasic","data":{"manufacturerName":"C046","modelId":"ZBT-Remote-EU-DIMV1A2","powerSource":3}}'
No converter available for 'AIRAM-CTR.U' with cid 'genScenes', type 'cmdRecall' and data '{"cid":"genScenes","data":{"groupid":16387,"sceneid":1}}'
No converter available for 'AIRAM-CTR.U' with cid 'genBasic', type 'devChange' and data '{"cid":"genBasic","data":{"zclVersion":2,"appVersion":1,"stackVersion":1,"hwVersion":1,"dateCode":"20171211-367","swBuildId":"2.1"}}'
No converter available for 'AIRAM-CTR.U' with cid 'lightLink', type 'devChange' and data '{"cid":"lightLink","data":{"65533":1}}'

Afterwards only:
No converter available for 'AIRAM-CTR.U' with cid 'genScenes', type 'cmdRecall' and data '{"cid":"genScenes","data":{"groupid":16387,"sceneid":1}}'

Earlier there was no a trace of these messages on the log and remote just controlled bulb directly.  Now I can see those messages and controlling the bulb works just fine still.
I'm just leaving to cottage for the weekend so I didn't have time to get into this. But maybe on monday I have some time again. But if anyone has time to think how to get those button presses to work (and still control the bulb directly) meanwhile I'd greatly appreciate that.
Thank you @Koenkk and everyone else involved into this project yet again for all your hard work!

merged!


Space between function macro name and args

Using -E
Expected behavior
Function macro should be replaced when whitespace separates name and args. (this is true in clang at least)

Actual Behavior
Name is consumed but the macro is not replaced.

 (a)

Code
#define f(a)
f (a)

Didn't mean to add codegen label. Should be preprocessor, bug, and maybe good-first-issue.

Looks like a regression from #437, this is working on 0.9.0.


Internally contradictory doc

An exhausted parse may cause a failure, in which case marpa_r_earleme_complete() returns an error whose error code is MARPA_ERR_PARSE_EXHAUSTED. For a parse to fail at an earleme due to exhaustion, it must be the case that no alternatives were accepted at that earleme. In fact, in the standard input model, a failure due to parse exhaustion occurs if and only if no alternatives were accepted at the current earleme.
...
Return value: On success, the number of events generated. On failure, -2.

MARPA_ERR_PARSE_EXHAUSTED is 7 or something.

I don't see the contradiction.  Perhaps you're thinking it lies in the possibility of confusing the error code with the number of events?  But for most calls, the error code is usually not the value which is returned on failure.  In most cases, to find the error code, one detects failure, and then interrogates the error code with marpa_g_error().  I hope this is responsive.

An exhausted parse may cause a failure in which case it returns an error whose error code is MARPA_ERR_PARSE_EXHAUSTED (i.e. 53).  But then on failure, this function is specified to return -2.

My nomenclature for return values is set up in this section, and the conventions there are essential to understanding the return value descriptions in the body.
I'll revise the marpa_r_earleme_complete() description to be clearer to someone who is skimming the API doc.
What happens on parse exhaustion in marpa_r_earleme_complete() is

marpa_r_earleme_complete() returns -2, indicating failure.  It also sets the error code to MARPA_ERR_PARSE_EXHAUSTED.  At this point, the error code is internal to Marpa, and not visible to the user.
The user, if they care, calls marpa_g_error(), which returns MARPA_ERR_PARSE_EXHAUSTED, the error code.

So, yes, l describe two distinct return values, but they are the return values of two distinct calls.
I will leave this issue open until I make the doc revision.

Thanks.  Just FWIW, I read the section you referenced, thoroughly. I'm a specification nerd, and I'd hardly call what I'm doing with the doc “skimming.”
There's a lot you could do to make it clearer and much smaller at the same time, if you're interested.

Yes, I am interested in comments on improving the doc.  I just reread "17.4.2 Initializing locations in the stack" and the amount of over-explanation and obscurity in that section is just cringy, so I imagine the kind of stuff you are suggesting is out there is in fact out there.
I find things easiest to manage is the suggestions are broken into multiple issues, rather than made in one big issue.  That way I can use the open/close mechanisms to track my work more readily.

Certainly, I'll submit separate suggestion issues.
FYI, some of the suggestions I have will lead naturally to API changes because of the virtuous feedback loop between documentation and API design; to be clear, I don't have any expectation of API changes being made, but expect to find the awkwardness of some docs a bit glaring until they are.

Re my reference to skimmers, you were not specifically intended.  Indeed, it was evident at that point your reading is not just careful, but in fact an in-depth study and analysis, which is flattering,
Nor was the term "skimmer" intended as disparaging of those to whom it did refer.  It is not reasonable for me to expect all (or frankly, even most) of the API doc's readers will read it carefully from beginning to end, or necessarily remember every syllable of what they did read.  Only the other hand, however false that assumption may be, I have to make some such assumption or the doc expands forever and becomes unusable for everybody.
One of the people who counts as a "skimmer" at this point is me, to some extent.  Of course I did write the thing, and read the it from beginning to end many times at one point.  But as was obvious in our IRC discussion re earlemes two nights ago, my memory of its contents is vague, and at points just plain wrong.
So my strategy is by default to assume the reader is carefully going through the doc from beginning to end, but at points, when it's easy to do so, to make concessions to the skimmers.  The confusion that saves may be my own.

I believe commit cadf7f0 addresses this issue.  I will close it in a couple of days absent feedback to the contrary.

Closed as fixed by commit cadf7f0.


⚠ GLDDNS Server (ns2.glddns.com) has degraded performance

In a41760a, GLDDNS Server (ns2.glddns.com) (ns2.glddns.com) experienced degraded performance:

HTTP code: 200
Response time: 853 ms

Resolved: GLDDNS Server (ns2.glddns.com) performance has improved in 71d7158 after 9 minutes.


Make graph variables accesible with the window scope

Scope the variables graph, options and data_table to the window object, to make posible the update of a graph dynamically from external sources
Use cases:

Update third column of first series with value 10000 of expenses chart, received by socket or ajax request

window.data_table_chart_expenses.setValue(2,1,10000);
window.chart_expenses.draw(window.data_table_chart_expenses, window.options_chart_expenses);

Redraw the dynamically changed data on resize

$(window).on('debouncedresize', function(event) {
  window.chart_expenses.draw(window.data_table_chart_expenses, window.options_chart_expenses);
});

Hi! Would listeners work for you in this case? https://developers.google.com/chart/interactive/docs/events#overview.
I have already added for listeners support on https://github.com/winston/google_visualr/blob/master/lib/google_visualr/base_chart.rb#L55
Thanks!

Hello Winston,
Thank you very much for your feedback, I had read the links you provided me, unfortunately I'm unable to see how to implement the redraw of the graph with only listeners.
As I understand the draw() function needs the data_table and the options to redraw it with the same styles, that is the reason I exposed the data_table to update the data and options to preserve the styles to the window scope.
Without exposing those variables, how can I redraw the graph updating the data_table data (adding rows or columns) with the listeners implementation?
Thank you.


Import all changes from lucet-wasi

I've tried my best to import and merge all changes from lucet-wasi which landed with fastly/lucet#176. There is still some unsafe-ness left that could probably be taken care of (see here).
I'd be indebted if you could proofread it all! :-)

Ignoring the formatting issue that Travis chokes on, this looks good to me!

Looks great!


All test cases don't pass

All test cases don't pass.
To Replicate:
npm run npm run test or npm run test:integration and npm run test:unit results in the following:

This is because of env file is not being read to provide the the mnemonics.

Issue and suggested Solution:

To read the env variables from a .env file a dotenv dev dependency is required or an env variables file to be read via process.env.

Once this dev dependency is added it will need to configured in jest or in photon-lib/__tests__/setup.js

Once env file is configured and available, following variables will be needed in the .env file:

MNEMONICS_COBO
MNEMONICS_COLDCARD
HD_MNEMONIC_BIP84
HD_MNEMONIC
FAULTY_ZPUB
HD_MNEMONIC_BIP49
HD_MNEMONIC_BIP49_MANY_TX

Adding the above will ensure all env variables required for running test cases are available HOWEVER the test cases expect specific mnemonics, the test cases have been written to pass only with specific mnemonics for example  HD_MNEMONIC_BIP49_MANY_TX should be a mnemonic with a 107 transactions and a total balance of 51432

There could be some other instances where specific values are required.
Also the hardcoded peers might need to be updated as well in case this is an issue.
If all the test cases were passing before then It would be great if someone who has worked on the project before can share a env file which works with the test cases.

Step 1 and Step 2 done.
A lot more test cases now pass:

A lot of test cases fail because expected, address, xpub or specific info does not match the hardcoded data in test cases:

The test cases failing are because the test cases expect specific mnemonics in the .env file.
If the same info info is not provided in the .env file then test cases will need to be re written.

Hey. The tests that cover the wallet libraries were ported from BlueWallet. I don't have the env vars either. You will have to replace them with new seeds and addresses if you want the tests to pass.

@tanx if we use new seeds in .env then we will need to update all the test cases with new addresses and other derived data isn't it? Or am I missing something?


Almond 0.9.1 fails when trying to use com.lihaoy::os-lib:0.6.2

I am getting a jvm exception when trying to do basic operations with the os-lib library. The code runs fine in a local scala repl, but not in my online notebook or my own local  installation. I am at a loss of how to proceed.
import $ivy.`com.lihaoyi::os-lib:0.6.2`
os.Path("/abc") / "def"

Downloading https://repo1.maven.org/maven2/com/lihaoyi/os-lib_2.12/0.6.2/os-lib_2.12-0.6.2.pom
Downloaded https://repo1.maven.org/maven2/com/lihaoyi/os-lib_2.12/0.6.2/os-lib_2.12-0.6.2.pom
Downloading https://repo1.maven.org/maven2/com/lihaoyi/geny_2.12/0.4.2/geny_2.12-0.4.2.pom
Downloaded https://repo1.maven.org/maven2/com/lihaoyi/geny_2.12/0.4.2/geny_2.12-0.4.2.pom
Downloading https://repo1.maven.org/maven2/com/lihaoyi/os-lib_2.12/0.6.2/os-lib_2.12-0.6.2.jar
Downloading https://repo1.maven.org/maven2/com/lihaoyi/os-lib_2.12/0.6.2/os-lib_2.12-0.6.2-sources.jar
Downloading https://repo1.maven.org/maven2/com/lihaoyi/geny_2.12/0.4.2/geny_2.12-0.4.2.jar
Downloading https://repo1.maven.org/maven2/com/lihaoyi/geny_2.12/0.4.2/geny_2.12-0.4.2-sources.jar
Downloaded https://repo1.maven.org/maven2/com/lihaoyi/geny_2.12/0.4.2/geny_2.12-0.4.2-sources.jar
Downloaded https://repo1.maven.org/maven2/com/lihaoyi/geny_2.12/0.4.2/geny_2.12-0.4.2.jar
Downloaded https://repo1.maven.org/maven2/com/lihaoyi/os-lib_2.12/0.6.2/os-lib_2.12-0.6.2-sources.jar
Downloaded https://repo1.maven.org/maven2/com/lihaoyi/os-lib_2.12/0.6.2/os-lib_2.12-0.6.2.jar
java.lang.NoSuchMethodError: os.Path.$div(Los/PathChunk;)Los/Path;
  ammonite.$sess.cmd0$Helper.<init>(cmd0.sc:2)
  ammonite.$sess.cmd0$.<init>(cmd0.sc:7)
  ammonite.$sess.cmd0$.<clinit>(cmd0.sc:-1)

In a local REPL>
Welcome to Scala 2.12.10 (OpenJDK 64-Bit Server VM, Java 1.8.0_232).
Type in expressions for evaluation. Or try :help.
scala> val p = os.Path("/abc")

p: os.Path = /abc

scala> val p2 = p / "def"
p2: p.ThisType = /abc/def

scala>

I've narrowed this down to the following: I have a library that uses os-lib internally and when I import that library in a Jupyter notebook using almond, the ammonite.ops that is use by almond somehow interferes with my libraries internal use of os-lib.
My current work around is to clone os-lib and repackage as oslib (instead of os) and use that in my library internally and then everything is happy. Is there an alternative?

I'm hitting the same problem right now, here is a fragment of cs resolve -t sh.almond:scala-kernel_2.13.1:0.9.1:
  └─ sh.almond:scala-interpreter_2.13.1:0.9.1
      ├─ com.lihaoyi:ammonite-repl_2.13.1:1.7.4
      │  ├─ com.github.javaparser:javaparser-core:3.2.5
      │  ├─ com.github.scopt:scopt_2.13:3.7.1
      │  │  └─ org.scala-lang:scala-library:2.13.0 -> 2.13.1
      │  ├─ com.lihaoyi:ammonite-interp_2.13.1:1.7.4
      │  │  ├─ com.lihaoyi:ammonite-ops_2.13:1.7.4
      │  │  │  ├─ com.lihaoyi:os-lib_2.13:0.3.0

so compatible version of os-lib seems to be 0.3.0 and to use anything else we would need ammonite update.

@Krever I have an update of almond in the works, bumping to the latest Ammonite.
Almond doesn't expose the whole Ammonite class path, only the one of ammonite-repl-api (cs resolve com.lihaoyi:::ammonite-repl-api:latest.stable). Ammonite exposes only this one too when it is launched with --thin. Ideally, this issue could be solved by ensuring Ammonite doesn't expose os-lib with --thin. It's discussed a bit around https://github.com/lihaoyi/Ammonite/pull/941#issuecomment-507685825.


The latest obsidian(0.13.14) doesn't work and it turn into my browser

As the title, if I click "Ctrl + left mouse", and I will Jump to browser
However, if I choose "Setting-Editor-Use legacy editor" and it can work well, so please fix the bug.
Thanks for your consideration

Live preview is not yet support, which are tracked here


Align treatment of artworks with no titles on artwork page, artwork feeds, and GPP

Problem:
We're currently displaying artworks inconsistently across Force when the artwork has no title entered.
example of artwork concerned: https://cms.artsy.net/artworks/cecily-brown-14?current_partner_id=two-palms (we already fall back to "Untitled" across volt)
Solution:
We should display the artwork title as "Untitled" across the board if there is no title entered. Existing implementations to amend include:

[ ] On masonry grid views across artsy artworks with no title entered display as just a comma

[ ] On the artwork page currently no title displays:

[ ] On the Artwork item in an Artist's module of a GPP no title displays:

cc: @tayapage6 @alloy @briansw - Partner Success will take care of this one, but just putting it on your radar for future artwork modules to account for fallbacks when there isn't a title

 Align treatment of artworks with no titles on artwork page, artwork feeds, and GPP

@garrengotthardt would it make sense to make the change at the platform/metaphysics level so that we get the payoff across all apps without needing to update individually?

@briansw also thought we might want to not ever save the field as blank to gravity, but got this context from Joey - https://artsy.slack.com/archives/partner-s-help/p1480962325000100. May make sense to handle in metaphysics though

Yea, I also agree about handling it in Metaphysics. That way it'll be easier to update if/when we may want to change this behavior, which seems like it's much more UI-driven.

FYI There’s this existing issue in Gravity that’s related to this as well https://github.com/artsy/gravity/issues/9212.
But as @gnilekaw has noted in Slack, fixing this in MP would not fix those emails.

@garrengotthardt, I updated this on Metaphysics. It should be fixed across the board now.
https://staging.artsy.net/artwork/cecily-brown-14

awesome thanks @gnilekaw !


Version 3.5.1 fails to execute on Linux due to colorama

Running on Void Linux with colorama on version v0.4.5. Is this strictly dependent on v0.4.6? Version locks should be included in requirements.txt.
[Autodetect] tkinter available, using --manual-captcha
Traceback (most recent call last):
  File "/bin/ulozto-downloader", line 33, in <module>
    sys.exit(load_entry_point('ulozto-downloader==3.5.1', 'console_scripts', 'ulozto-downloader')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/uldlib/cmd.py", line 124, in run
    from colorama import just_fix_windows_console
ImportError: cannot import name 'just_fix_windows_console' from 'colorama' (/usr/lib/python3.11/site-packages/colorama/__init__.py)

Simply run pip install -U colorama which will update colorama to the latest version. See the following article for more details.

Yes, but requirements do not specify this constraint. This should be explicitly set as >=0.4.6 to avoid these sorts of problems. This goes for all dependencies.

Yeah, you are right. Open a merge request for that if you feel like it
On Sun, 18 Jun 2023, 17:18 Emil Miler, @.***> wrote:

Yes, but requirements do not specify this constraint. This should be
explicitly set as >=0.4.6 to avoid these sorts of problems. This goes for
all dependencies.
—
Reply to this email directly, view it on GitHub
https://github.com/setnicka/ulozto-downloader/issues/165#issuecomment-1596181896,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARJA5OF3SBPYHHGT3EX4UWTXL4L5VANCNFSM6AAAAAAXUUAKEU
.
You are receiving this because you commented.Message ID:
@.***>


model builder generated should be MLNETCLI generated

@JakeRadMSFT MLNETCLI was the name we decided on right?

Yes! Both projects say CLI


Free vehicles automatically controlled by a bot

Free vehicles in the vehicle queue should be assigned automatically to a bot if there is no human player.

start with initilization -> drive against both track boarders bevor make it available for players


Request for Assistance with Suno API Script Cookie Lifespan Issue

I came across your GitHub repository regarding an unofficial Suno API. In fact, I've developed a Python script that automatically downloads songs from Suno using a prompt file and seleniumbase chromewebdriver. My current issue lies with the lifespan of cookies as they expire exactly after 1 week. If you could kindly assist me with this, I would even buy you a coffee if necessary.

I came across your GitHub repository regarding an unofficial Suno API. In fact, I've developed a Python script that automatically downloads songs from Suno using a prompt file and seleniumbase chromewebdriver. My current issue lies with the lifespan of cookies as they expire exactly after 1 week. If you could kindly assist me with this, I would even buy you a coffee if necessary.

I encounter the situation you mentioned, it is unavoidable.  Now, I manually change cookies when prompted Unauthorized, because I have created an interface where cookies can be modified.  I'm sorry I can't help you right now.


Crash on Windows 11 Home: 22000.708

I'm running the latest version of  GlosSI (GlosSI-<IP_ADDRESS>) on my newly updated Windows 11 PC (Ver. 22000.708). Now the program starts and closes itself after a few seconds. It is the same version of GlosSI I used flawlessly a few days ago on Win 10.

Log files in %appdata%\GlosSI


Tickers don't always work

See the geof/examples branch:  em.core/em.examples.advanced test.
Test will hang if just left at rate 1.  There appears to be an issue with wakeups from tickers -- where they are off by more than a second sometimes.  And once that happens, tickers get lost.
Sometimes the printTicker gets lost, sometimes the appTicker.

Reverting ac4ee27f11664bd7ebc71ceaea3fcab764dbc1ac appears to help / fix the problem.  That indicates that there is some sort of enqueue / dequeue issue with alarms.

Further -- with three tickers (app, sys, print) with periods (2, 1.5, 5) s respectively:
one would think for example that within a 5s print period,there should be 2..3 app ticks and 3..4 sys ticks.  But that is not true.  Observe the printouts to see the actual results.

Fixed by #21


sc.pl.heatmap doesn't align boundaries well

I ran this:
ax=sc.pl.heatmap(Mouse10Xdata[NewIndex3,:], sorted_unique_marker_genes, groupby='ident',               use_raw=False, vmin=-3, vmax=3, cmap='bwr',show=True,swap_axes=True,figsize=(10,7),               var_group_rotation=0, dendrogram=True, save='ClusterMap.png')
But the image has something weird. Here are the snapshots:

The lines don't align well with the heatmap.
Additionally, the lines don't align well with the group ID colors, either

And the ID colors seem to be not aligned well with the heatmap either.
Any thoughts?

There was a similar report not so long ago but I have not been able to reproduce the issue.
Seems to be related with the matplotlib version used. Maybe you can try to update to the latest version.

On 10 May 2019, at 01:38, brianpenghe<EMAIL_ADDRESS>wrote:
I ran this:
ax=sc.pl.heatmap(Mouse10Xdata[NewIndex3,:], sorted_unique_marker_genes, groupby='ident', use_raw=False, vmin=-3, vmax=3, cmap='bwr',show=True,swap_axes=True,figsize=(10,7), var_group_rotation=0, dendrogram=True, save='ClusterMap.png')
But the image has something weird. Here are the snapshot:
The lines don't align well with the heatmap.
Additionally, the lines don't align well with the group ID colors, either
And the ID colors seem to be not aligned well with the heatmap either.
Any thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

There was a similar report not so long ago but I have not been able to reproduce the issue. Seems to be related with the matplotlib version used. Maybe you can try to update to the latest version.
…
On 10 May 2019, at 01:38, brianpenghe @.***> wrote: I ran this: ax=sc.pl.heatmap(Mouse10Xdata[NewIndex3,:], sorted_unique_marker_genes, groupby='ident', use_raw=False, vmin=-3, vmax=3, cmap='bwr',show=True,swap_axes=True,figsize=(10,7), var_group_rotation=0, dendrogram=True, save='ClusterMap.png') But the image has something weird. Here are the snapshot: The lines don't align well with the heatmap. Additionally, the lines don't align well with the group ID colors, either And the ID colors seem to be not aligned well with the heatmap either. Any thoughts? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

I have been using matplotlib 3.0.3 and I believe it's the latest version already. My Scanpy version was 1.4.1.
Can it be an issue about duplicated gene names/make unique?

In your heat map the lines are separating categorical groups right? In other words genes are rows.
In your command you are doing a selection over a larger dataset. Have you tried to make a copy of the adata object?
adata = Mouse10Xdata[NewIndex3,:].copy()
I ask in case the categories reported in the selection that you are doing create a mismatch, which may be solved by doing a copy.

On 15 May 2019, at 11:24, brianpenghe<EMAIL_ADDRESS>wrote:
There was a similar report not so long ago but I have not been able to reproduce the issue. Seems to be related with the matplotlib version used. Maybe you can try to update to the latest version.
…
On 10 May 2019, at 01:38, brianpenghe @.***> wrote: I ran this: ax=sc.pl.heatmap(Mouse10Xdata[NewIndex3,:], sorted_unique_marker_genes, groupby='ident', use_raw=False, vmin=-3, vmax=3, cmap='bwr',show=True,swap_axes=True,figsize=(10,7), var_group_rotation=0, dendrogram=True, save='ClusterMap.png') But the image has something weird. Here are the snapshot: The lines don't align well with the heatmap. Additionally, the lines don't align well with the group ID colors, either And the ID colors seem to be not aligned well with the heatmap either. Any thoughts? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
I have been using matplotlib 3.0.3 and I believe it's the latest version already. My Scanpy version was 1.4.1.
Can it be an issue about duplicated gene names/make unique?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Any update?

Any update?

I tried that but it's still giving me exactly the same tree : (

I met the same issue too. I have to adjust the lines manually with Adobe Illustrator.

I met the same issue too. I have to adjust the lines manually with Adobe Illustrator.

You can't do that, because the columns are messed up and don't align with the column labels. It's a three-body problem.

In the tests that I have the heatmap seems to be ok. See https://scanpy-tutorials.readthedocs.io/en/latest/visualizing-marker-genes.html#Visualize-marker-genes-using-heatmap
Do you think that the problem occurs when lot of cells/genes are plotted?

In the tests that I have the heatmap seems to be ok. See https://scanpy-tutorials.readthedocs.io/en/latest/visualizing-marker-genes.html#Visualize-marker-genes-using-heatmap
Do you think that the problem occurs when lot of cells/genes are plotted?

It's possible.

The test is not good neither. If you look carefully at the heatmap generated with sc.pl.rank_genes_groups_heatmap(pbmc, n_genes=3, standard_scale='var'), you would find it is not aligned perfectly, especially for the local magnified heatmap. @fidelram @brianpenghe

The lines should be aligned now. They were are centered now with respect to the boundary.


adding flake8 to monitor our builds, some initial pep8 adjustments

travis will report pep8 / style checks, it will not fail the build but we should monitor it to make sure we drive towards more compliance and then we can start enforcing pep8 for outside contributions.

rebased against the latest changes.

TY @MaxPresman!


EpicPrivacyBrowser.EpicPrivacyBrowserInstaller version <IP_ADDRESS>

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Unexpected Behaviour when I run /? or /Help.

Automatic Validation failed with:

I'm not exactly sure what occurred here.

Hi @sarvex,
The installation isn't unattended:

Is there an installer switch to bypass this and have it complete installing automatically?

@stephengillie @BrandonWanHuanSheng
The installer is an EXE file to download the Browser, and the error comes whenever any parameter is passed to the installer.
I kept the silent options as empty but it seems that winget is still passing empty strings to the installer.

@stephengillie @BrandonWanHuanSheng
The installer is an EXE file to download the Browser, and the error comes whenever any parameter is passed to the installer.
I kept the silent options as empty but it seems that winget is still passing empty strings to the installer.

Without any options, it installs normally, but requires clicking "Close" to complete. Is there a way to skip that "Close" button and have it close automatically?

@stephengillie unfortunately there is no documentation on the installer flags so there is not way to make it truely unattended

There seems to be no option for non-interactive installation. Let's discard the PR


Error

someone know how to solve this ?

Hello, you need to enable your hotspot on the status bar in your phone to solve this error or get your personal auth token with ngrok.

Hello, you need to enable your hotspot on the status bar in your phone to solve this error or get your personal auth token with ngrok.

Hi! I did it all. And I have a token, but it didn't working... Can you help me?

Hello, you need to enable your hotspot on the status bar in your phone to solve this error or get your personal auth token with ngrok.

How to get the personal auth token

Hello, you need to enable your hotspot on the status bar in your phone to solve this error or get your personal auth token with ngrok.

Hi! I did it all. And I have a token, but it didn't working... Can you help me?

Try executing ngrok directly from command line or open ngrok local page with <IP_ADDRESS> in your browser with port 3333, 8080 or 8000

Hello, you need to enable your hotspot on the status bar in your phone to solve this error or get your personal auth token with ngrok.

How to get the personal auth token

Enter in the official ngrok website, register and in your dashboard will appear your auth token, after that you just follow the instructions normaly.

renember: ngrok have different arch versions, for use with termux you may need a ngrok ARMv7 version binary.


Yazoo navbar in 404 page

must add navbar in the 404 page

:tada: This issue has been resolved in version 0.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


#33 Issue fix

Coverage increased (+0.0007%) to 99.865% when pulling<PHONE_NUMBER>c7d0e26ae48b7077abc12abe1810d9 on ksobolewski-netins:master into ae39b9348fb686c0c72b2f0bca53e39c14a08a09 on mprzodala:master.

Coverage decreased (-0.1%) to 99.871% when pulling fcc141399efe3ae7e0759f2a5330740380846e3a on ksobolewski-netins:master into eebcedb94454344a46f10d40f291d9d783605089 on mprzodala:master.


regarding broken html link for yaml example in riscv config validator documentation

I keep getting error  as hart_ids is not found while running riscv_config
Is there an example input ISA  which takes into account hart_id ?   for simplicity, lets assume single thread with hart id=0.
When I try to view https://github.com/riscv/riscv_config/blob/master/examples/template_isa.yaml
it does not work

I want to update that I am no longer getting hart_id error.
but the yaml link is still not working.  it is referenced in the risc-v config validator documentation

I want to update that I am no longer getting hart_id error.
but the yaml link is still not working.  it is referenced in the risc-v config validator documentation

i will close this issue and open just a separate one for the document link

i will close this issue and open just a separate one for the document link

Is this the one you aer talking about : https://riscv-config.readthedocs.io/en/latest/yaml-specs.html

Is this the one you aer talking about : https://riscv-config.readthedocs.io/en/latest/yaml-specs.html

yes, when I look at
"
An elaborate example of the full-fledge ISA-YAML file can be found here: ISA-YAML"
if I click on the ISA-YAML , it gives me 404. page not found.  same issue in the riscv config.pdf

yes, when I look at
"
An elaborate example of the full-fledge ISA-YAML file can be found here: ISA-YAML"
if I click on the ISA-YAML , it gives me 404. page not found.  same issue in the riscv config.pdf

The problem is that note 2 near the top of https://github.com/riscv/riscv-config/blob/master/docs/source/yaml-specs.rst has a dead link.

The problem is that note 2 near the top of https://github.com/riscv/riscv-config/blob/master/docs/source/yaml-specs.rst has a dead link.


Error with updatePresentingController(modal:

I am trying to update SPStorkController like this:
let modal = TourCodeStartTourViewController(nibName: "TourCodeStartTourViewController", bundle: nil)
let transitionDelegate = SPStorkTransitioningDelegate()
transitionDelegate.cornerRadius = 25
modal.transitioningDelegate = transitionDelegate
modal.modalPresentationStyle = .custom
modal.code = self.tourCodeTextField.text!.trimmingCharacters(in: .whitespaces)
SPStorkController.updatePresentingController(modal: modal)

And I'm getting an error Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value, that routes to SPStorkPresentationController.swift, 541 line.
Is that a problem with nibs or I've done smth wrong?

You try update controller before presenting. It incorrect.


Line duplication in kef_connector.py (0.6)

Lines 7 & 8 are duplicated:
7 class KefConnector:
8 class KefConnector:
Resulting in indentation error. Removing one solves it.

Really sorry about this typo !
version 0.6.1 is already pushed on Pypi, and it fixes the issue as well as adding new feature (I'm actually edditing the README).
Please feel free to reopen if version 0.6.1 does not correct the bug (but it should!)


Automated Package Upgrade

:tada: This PR is included in version 2.2.229 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Show comment score

Show Comment Score was failing when things that weren't comments appeared alongside comments in the list (e.g., revisions) because many of these did not have a "#" in their url, which led to an undefined error breaking things.
I made the selector check for "#comment" inside the url to fix this.

Thanks again! I will look into this as soon as I can, but again: if it's not too hard, can you make this pull request on develop? If not, that's fine - I'll edit the files on develop myself! :)

Yeah, no problem. I'll close this (and the other PR) and open new PRs on develop


FutureWarning for XKRX

The test TestXKRXCalendar.test_feb_29_2022_in_lunar_calendar results in 6 instances of the following deprecation warning:
...\exchange_calendars\exchange_calendars\pandas_extensions\korean_holiday.py:76: DeprecationWarning: The truth value of an empty array is ambiguous. Returning False, but in future this will result in an error. Use `array.size > 0` to check that an array is not empty.
    dt = pd.Timestamp(dt)

It seems to be due to a DatetimeIndex being passed to the dt parameter of the alternative_holiday function which is being called for the IndependenceMovementDay holiday, although it's not clear to me why it's receiving a DatetimeIndex.
It could be silenced with no change in behaviour, and the eventual bug when it is deprecated could be avoided, by changing this line from:
if dt >= since:

to:
if isinstance(dt, pd.Timestamp) and dt >= since:

Although this change would cause no change in behavior (as is, with a DatetimeIndex it evaluates to False as it's ambiguous), I haven't changed it because it would just hide the real issue which is that alternative_holiday is getting a DatetimeIndex when it seems to be expecting a Timestamp.

This issue is also mentioned in #128.


microcodeIntel: 20210216 -> 20210608

Motivation for this change
Fixes #105172
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Booted with my UX305CA and everything works.

Duplicate of #126291?


docs: Incorrect links to referenced command in sli.yaml and slo.yaml documentation

The links to the keptn add-resource command referenced in the sli.yaml and slo.yaml documentation incorrectly links to:

https://keptn.sh/docs/0.15.x/reference/reference/cli/commands/keptn_add-resource

I believe it's meant to link to:

https://keptn.sh/docs/0.15.x/reference/cli/commands/keptn_add-resource

[ ] Approval
[ ] Bridge
[ ] CLI
[ ] Datastore
[x] Docs
[ ] Distributor / Event Broker
[ ] Helm
[ ] Istio
[ ] Jmeter
[ ] Kubernetes Integration
[ ] Openshift Integration
[ ] REST API
[ ] Webhook

This has been fixed