1shot

@dcousens JFYI, this PR do not remove readable-stream package, because it package also required by create-hash -> cipher-base. If we want remove readable-stream from bitcoinjs-lib bundle (reduce 40kb) we also should create 1shot in createHash.
Thoughts?

Right now close, because without createHash/1shot doesn't make sense.

the hashing stuff is actually in sha.js which I don't believe has any streams stuff in it, so you might be better off making a hmac lib that goes directly to sha.js

yea, probably it will better, but bitcoinjs-lib also need ripemd160
and I even not sure that it all make sense for sake of 40kb

not sure that it all make sense for sake of 40kb

It might just be easier to find ways to reduce readable-streams foot print.
It really shouldn't be 40kb...

ping @calvinmetcalf ? :P

it's not readable-streams its browserify streams which I is based on readable-streams so I don't know what version of readable streams its on, some of that include other browserify libs like events and buffers which are likely also being included by other things.

@dcousens I can create package crypto1shot which will include ciphers/hashes/hmac if you agree add this to bitcoinjs-lib, also in this way we can save more than 40kb, because don't need all sha.js

@fanatid there is also the point that,  in production,  I often find myself using streams anyway so,  for me,  using crypto1shot would actually increase my bundle size...


Question: is swagger-node-express out of date?

I think this issue might answer this question:
https://github.com/swagger-api/swagger-node/issues/230

Oh, thanks for your info @tncbbthositg


Early Termination of training：Progress 19.42%

nv: 1032440, ne: 987454
Need 0.257797 Mb for storing second-order degrees
Generating a corpus for negative samples..
Using vectorized operations
lr 0.020144, Progress 19.42%
Calculations took 12.13 s to run

There is definetely a couple of weird things here: number of nodes is larger than the number of edges, and the graph seems almost disconnected. Are you sure you have the correct data preprocessing/data format?

There are thousands of subgraphs, and no connection between them. data preprocessing use https://github.com/xgfs/verse/tree/master/python ,and verse can train correctly.
My computer has 24cpu and 256G memory.
Thanks.

If most of the nodes lie in small disconnected subgraphs, node2vec will be much faster (with unknown quality). From the output I would assume that process is ran correctly, and it finishes - most likely, the printing of the progress is not called (it's only called from thread id=0).

I found different places：
If I use the parameter -nwalks 80, the training will be interrupted：
./node2vec  -input rela.bscr -output embedding.bin -dim 256 -nwalks 80
and use default nwalks ，training is correct ：
./node2vec  -input rela.bscr -output embedding.bin -dim 256

Interesting. Could you run the default couple of times and see if it crashes anytime?

if nwalks < 40 , the training will not be interrupted.

If you post the graph file, I will try to look at the issue some time in the future. If you find a bug yourself, please notify/submit a PR.


Automagically add clauses for Company ID (multi tenancy models)

In many structs I have a CompanyID field.
Example:
type Player struct {
  gorm.Model

  Name string

  CompanyID uint
  Company    Company
}

And I have a Company type like this:
type Company struct {
  Name string
}

I would like to know if there is a way to automagically add a Where clause to my queries.
Example
If I have this query
var player Player
db.Where("name like ?", "fakeName").Find(&player)

that generates this:
SELECT * from players where name like 'fakeName'

it would be amazing to have something to detect if Player has CompanyID field on it and add a Where clause automatically which generates this:
SELECT * from players where (name like 'fakeName' AND company_id = 1)

Doing this manually to each query is error prone as you can imagine.
Is there a way?
What do you think about?

Please answer to this, @jinzhu.

You can write a callback to do the job, it doesn't make sense for GORM to do this automatically.

you can use db.WithContext, pass CompanyID with context,  then write a callback work on before_query.
in BeforeQuery callback method, use db.Statement.Context get the CompanyID value.
model callback
func (m *BaseModel) BeforeQuery(db *gorm.DB) error {
	tx := db.Session(&gorm.Session{})
	ctx := tx.Statement.Context
	itd := ctx.Value("CompanyID").(string)
	query := "company_id=?"
	if conds := tx.Statement.BuildCondition(query, itd); len(conds) > 0 {
		tx.Statement.AddClause(clause.Where{Exprs: conds})
	}
	return nil
}

gorm callback
type IBeforeQuery interface {
	BeforeQuery(*gorm.DB) error
}

// BeforeQueryCallback
func BeforeQueryCallback(db *gorm.DB) {
	tx := db.Session(&gorm.Session{})
	if db.Error == nil && db.Statement.Schema != nil {

		ibq := reflect.TypeOf((*IBeforeQuery)(nil)).Elem()
		vm := reflect.New(db.Statement.Schema.ModelType)
		if ok := vm.Type().Implements(ibq); ok {
			q := vm.Interface().(IBeforeQuery)
			q.BeforeQuery(tx)
		}
	}
}

register callback
db.Callback().Query().Before("gorm:query").Register("td:before_query", callbacks.BeforeQueryCallback)

Thank you so much, @gatspy.
I am very sad to use reflect.

db.Callback().Query().Before("gorm:query").Register("td:before_query", beforeQuery)
func beforeQuery(db *gorm.DB) {
if field := db.Statement.Schema.LookUpField("CompanyId"); field != nil {
// db.Statement.Where("company_id", CurrentCompany)   // not work
if cds := db.Statement.BuildCondition("company_id", CurrentCompany); len(cds) > 0 {
db.Statement.AddClause(clause.Where{Exprs: cds})。// it‘s work
}
}
}


drivers: nrf: Fix nrf uarte fifo_fill function.

Calling fifo_fill function from uart_nrfx_uarte in the same
interrupt more than once, would break previous transmission.
Following fix adds checking if previous data was sent, and
if not, returns 0.

Codecov Report

Merging #11475 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11475   +/-   ##
=======================================
  Coverage   48.38%   48.38%
=======================================
  Files         265      265
  Lines       42193    42193
  Branches    10137    10137
=======================================
  Hits        20413    20413
  Misses      17703    17703
  Partials     4077     4077

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644b31d...356f734. Read the comment docs.

@anangl can you re-review?

@carlescufi could you merge?


[BUG] Astra Streaming "get" command [ERROR] You provided unknown or not well formatted argument.

Astra CLI command "astra streaming get " return errors.
Installed Astra CLI version 0.2 on Windows 11 WSL2 terminal (Ubuntu 20.04 LTS)  After setup and adding my token, "astra streaming list" works fine.  "astra streaming get " returns errors.
prompt@DESKTOP:~$ astra streaming get aws-useast1
[ERROR] You provided unknown or not well formatted argument.
[ERROR] Found unexpected parameters: [aws-useast1] (ParseArgumentsUnexpectedException)
[ERROR] Try 'astra help <your_command>' to get help
Desktop (please complete the following information):
Windows 11 WSL2 terminal (Ubuntu 20.04 LTS)

Diagnostic:
Class AbstractStreamingCmd was not included in reflect-congi.json used for native compilation. All commands astra streaming exist/delete/pulsar-token would trigger the same error.
Fix
 {
    "name":"com.dtsx.astra.cli.streaming.AbstractStreamingCmd",
    "allDeclaredFields":true
  }


About Scan2Map

The experimental results in your paper show that the performance of self-supervised LO+map has improved significantly. Now I have a question to combine the trained odometry with mapping. How did you embed this project in LOAM?

Hi @yuqJin!
We used this implementation of LOAM: https://github.com/laboshinl/loam_velodyne
and in LaserMapping.cpp we switched laser odometry topic "laser_odom_to_init" to our learned odometry topic. You have to take care of some frame transformations as LOAM uses a different frame convention than ROS (Z-forward, X-left and Y-up) and that's about it.

Hi @yuqJin! We used this implementation of LOAM: https://github.com/laboshinl/loam_velodyne and in LaserMapping.cpp we switched laser odometry topic "laser_odom_to_init" to our learned odometry topic. You have to take care of some frame transformations as LOAM uses a different frame convention than ROS (Z-forward, X-left and Y-up) and that's about it.

Can you be more detailed? Thank you very much!

Hi @hhongwei1009,
Thanks a lot for your message. In what sense are you missing the information? Instead of using the LOAM scan2scan, we were simply using the learned scan2scan.
Best,
Julian


Improve descriptions for Group and Grouping

Proposed Changes
Improve description comments for Group and Grouping models. Previous comment for Group is misleading and the comment for Grouping lacks detail.
Type of Change
(Write an X or a brief description next to the type or types that best describe your changes.)

Type
Applies?

🚨 Breaking change (fix or feature that would cause existing functionality to change)

✨ New feature (non-breaking change that adds functionality)

🐛 Bug fix (non-breaking change that fixes an issue)

🎨 User interface change (change to user interface; provide screenshots)

♻ Refactoring (internal change to codebase, without changing functionality)

🚦 Test update (change that only adds or modifies tests)

📦 Dependency update (change that updates a dependency)

🔧 Internal (change that only affects developers or continuous integration)
X

Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)
Before opening your pull request:

[x] I have performed a self-review of my changes.

Check that all changed files included in this pull request are intentional changes.
Check that all changes are relevant to the purpose of this pull request, as described above.

[x] I have added tests for my changes, if applicable.

This is required for all bug fixes and new features.

[x] I have updated the project documentation, if applicable.

This is required for new features.

[x] If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

[ ] I have updated the project Changelog (this is required for all changes).
[ ] I have verified that the pre-commit.ci checks have passed.
[ ] I have verified that the CI tests have passed.
[ ] I have reviewed the test coverage changes reported by Coveralls.
[ ] I have requested a review from a project maintainer.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.651%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
40656

Relevant Lines:
43687

💛  - Coveralls


Remove unnecessary (duplicate) semicolons

Codecov Report

Merging #856 into dev will decrease coverage by 0.02%.
The diff coverage is 60%.

@@             Coverage Diff             @@
##               dev     #856      +/-   ##
===========================================
- Coverage     48.6%   48.57%   -0.03%
+ Complexity    2796     2792       -4
===========================================
  Files          116      116
  Lines        27885    27885
  Branches      4651     4651
===========================================
- Hits         13553    13546       -7
- Misses       12124    12129       +5
- Partials      2208     2210       +2

Flag
Coverage Δ
Complexity Δ

#JDBC42
48.09% <60%> (-0.01%)
2747 <0> (-4)

#JDBC43
48.43% <60%> (-0.03%)
2787 <0> (-4)

Impacted Files
Coverage Δ
Complexity Δ

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
52.58% <ø> (+0.12%)
264 <0> (+1)
:arrow_up:

...oft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java
56.25% <ø> (ø)
5 <0> (ø)
:arrow_down:

...m/microsoft/sqlserver/jdbc/SQLServerStatement.java
59.51% <ø> (ø)
135 <0> (ø)
:arrow_down:

...rc/main/java/com/microsoft/sqlserver/jdbc/TVP.java
44.12% <ø> (ø)
27 <0> (ø)
:arrow_down:

...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java
79.48% <ø> (ø)
5 <0> (ø)
:arrow_down:

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
56.12% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../microsoft/sqlserver/jdbc/SQLServerConnection.java
48.09% <0%> (ø)
335 <0> (ø)
:arrow_down:

...oft/sqlserver/jdbc/SQLServerPreparedStatement.java
51.96% <100%> (ø)
212 <0> (ø)
:arrow_down:

...om/microsoft/sqlserver/jdbc/SimpleInputStream.java
54.41% <100%> (+1.47%)
12 <0> (+1)
:arrow_up:

...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
40.65% <0%> (-3.3%)
13% <0%> (-2%)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bebfa...d1a3aea. Read the comment docs.


Remove invalid 'sd-data-table' reference

What did you add to the README.md file?

Nothing, just removed an invalid link :)
I've inspected the repository owner to see if they change the name or something like that, and I was not able to find a replacement. If you want to check: https://github.com/stratodem/
Checklist:

[x] Not a duplicate.
[x] Only has awesome items. Awesome lists are curations of the best, not everything.
[x] Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Drop all the A / An prefixes in the descriptions.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

For first time contributors...
Do you want to be added to the contributors list on the README.md file?

[ ] Yes
[X] No need, is just an expired link :P

Thanks @Kludex 👍


Implement save to file feature.

Fixes #42

Looks good. Thanks!
The last test case failed in travis, but that seems caused because the path ... is valid in travis (or linux). It can be fixed if the path set to ., for example. (I checked locally)


Fix console script field in setup.py

Signed-off-by: Karol Gugala<EMAIL_ADDRESS>

py35 run-test: commands[0] | check-manifest --ignore 'tox.ini,tests*'
lists of files in version control and sdist do not match!
missing from sdist:
  tests/data/bigchip.sdf
  tests/data/celltype.sdf
  tests/data/clb.sdf
  tests/data/empty.sdf
  tests/data/golden/bigchip.sdf
  tests/data/golden/celltype.sdf
  tests/data/golden/clb.sdf
  tests/data/golden/empty.sdf
  tests/data/golden/modulo6.sdf
  tests/data/golden/real_triple.sdf
  tests/data/golden/spec-example1.sdf
  tests/data/golden/spec-example2.sdf
  tests/data/golden/spec-example3.sdf
  tests/data/golden/spec-example4.sdf
  tests/data/golden/test-device.sdf
  tests/data/golden/test1.sdf
  tests/data/golden/timings_hx1k.sdf
  tests/data/modulo6.sdf
  tests/data/real_triple.sdf
  tests/data/spec-example1.sdf
  tests/data/spec-example2.sdf
  tests/data/spec-example3.sdf
  tests/data/spec-example4.sdf
  tests/data/test-device.sdf
  tests/data/test1.sdf
  tests/data/timings_hx1k.sdf
  tests/parse_all_test.py
suggested MANIFEST.in rules:
  recursive-include tests *.py
  recursive-include tests *.sdf

???


🐛 Scrollbar, disappear when the mouse is not over

Describe the bug
I'm not that sure if it's a problem with Fluent_ui or Flutter.
The scrollbar tend to disappear when the mouse move (so almost everytime I scroll, it's hard to grab the bar and it disappear).
Also, maybe it's another bug, but if I go over the scrollbar, it appear, and after that if I scroll with the mouse wheel, it stay appeared.
But wait a couple of second, the bar disappear, scroll with mouse will, you'll not see the bar again.

I think it is an issue with Flutter's RawScrollbar, but it is resolvable using the callbacks they expose.
We hide the scrollbar as soon as the mouse leaves it, but we don't take into account if the user is still pressing it. https://github.com/bdlukaa/fluent_ui/blob/5d756dbb91d1b37b40bc1f795047e4adebefcdef/lib/src/controls/utils/scrollbar.dart#L140-L184


Streetcode tag

Added new API request for tags.
dev
JIRA

Main JIRA ticket

Code reviewers

[ ] @github_username

Second Level Review

[ ] @github_username

Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST

[ ]  СI passed
[ ]  Сode coverage >=95%
[ ]  PR is reviewed manually again (to make sure you have 100% ready code)
[ ]  All reviewers agreed to merge the PR
[ ]  I've checked new feature as logged in and logged out user if needed
[ ]  PR meets all conventions

This code was merged by in pull request #128

This code was merged by in pull request https://github.com/ita-social-projects/StreetCode/pull/128


Need C# code

[Enter feedback here]
Can you please share the complete C# code to export powerbi report
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7b2a51d-0025-3209-a1c1-db3362b909bb
Version Independent ID: a952e5a8-acf6-31cc-43ff-77cef73b2a9e
Content: Export Power BI reports API - Power BI
Content Source: powerbi-docs/developer/embedded/export-to.md
Service: powerbi
Sub-service: powerbi-developer
GitHub Login: @KesemSharabi
Microsoft Alias: kesharab

Hi, @phaniraj-t -- thanks for your question! Assigning to the author to help out.

Please let me know where can I  get the complete code. I would like to export report using console application.

Hi @phaniraj-t,
In the End-to-end example section we have a code sample that covers the general use of this feature. We don't have a detailed example as the code would change depending on each customer's solution.
For your specific problem, and in order to find additional examples, I suggest that you look for a solution in the Power BI Community. If that doesn't help, try our support page.
Thanks,
Kesem


type infer failed with a pathological case in 3.5.0, but in 3.4.0 it works

TypeScript Version:  3.5.0-dev.20190509

Search Terms:
generic, keyof
Code
type Foo<T> = {
  [key: string]: { [key_ in keyof T]: key_ }[keyof T]
}
type Bar<T> = {
  [key: string]: { [key_ in keyof T]: [key_] }[keyof T]
}

type Baz<T, Q extends Foo<T>> = {
  [key in keyof Q]: T[Q[key]]
}

type Qux<T, Q extends Bar<T>> = {
  [key in keyof Q]: T[Q[key]["0"]] // error!
}

Expected behavior:
Qux is also a valid generic definition.
Actual behavior:
Type 'Q[key]["0"]' cannot be used to index type 'T'.ts(2536)
Playground Link:
https://www.typescriptlang.org/play/#src=type Foo<T> %3D {
  [key%3A string]%3A { [key_ in keyof T]%3A key_ }[keyof T]
}
type Bar<T> %3D {
  [key%3A string]%3A { [key_ in keyof T]%3A [key_] }[keyof T]
}

type Baz<T%2C Q extends Foo<T>> %3D {
  [key in keyof Q]%3A T[Q[key]]
}

type Qux<T%2C Q extends Bar<T>> %3D {
  [key in keyof Q]%3A T[Q[key]["0"]] %2F%2F error!
}

Baz gives the same error here, Qux is ok. Typescript version matters?

Related Issues:

I think this may have changed under #30769, in particular: string indexers are ignored in type variable constraints.

@jack-williams
I think I need to take time to read that issue, but asking for the conclusion first,
are you saying that it is sound to say Qux is invalid while Baz is not? So that change was not a side-effect but an improvement?

So the PR I link is the source of the change, but my initial point about string indexers was likely wrong. Corrections:
I think the change of Baz no longer producing an error is incorrect, however the removal of the error may be attributable to this change:

Constraints of indexed access types are now more thoroughly explored. For example, given type variables T and K extends 'a' | 'b', the types { a: T, b: T }[K] and T are now considered related where previously they weren't.

A reason why there should be an error: In Baz we are saying that all values of Q are assignable to keys of T, but this assumption is not guaranteed by the constraint Foo<T> as evidence by:
declare const sym: unique symbol;
type T = { x: number, b: string };
type Q = { a: "x", [sym]: number };
type A =  Baz<T,Q> // Proof Q is assignable to Foo<T>
type ShouldBeKeyofT<X extends keyof T> = X
type Err = ShouldBeKeyofT<Q[keyof Q]> // err!

The new error in Qux is correct for the same reason that Baz should have been an error. Here is an extended error message that shows the reasoning (note the correct expansion of keyof Q to string | number | symbol)
Type 'Q[keyof Q]["0"]' is not assignable to type 'keyof T'.
  Type 'Q[string]["0"] | Q[number]["0"] | Q[symbol]["0"]' is not assignable to type 'keyof T'.
    Type 'Q[string]["0"]' is not assignable to type 'keyof T'.
      Type '{ [key_ in keyof T]: [key_]; }[keyof T]["0"]' is not assignable to type 'keyof T'.
        Type 'string | number | symbol' is not assignable to type 'keyof T'.
          Type 'string' is not assignable to type 'keyof T'. [2322]

So it seems like the new logic may be eagerly applying  { a: T, b: T }[K] relatedTo T when it should be grabbing the base constraint of K and expanding it, but I'm really not sure about that.

I can't represent that error in both 3.4.3 and 3.5.0-dev.20190509.
I found ts2344 occured than ts2322.
Type 'number | "x"' does not satisfy the constraint '"x" | "b"'.
  Type 'number' is not assignable to type '"x" | "b"'.ts(2344)

It can be simply fixed like this, and I think it's an old behavior and has nothing to do with the change.
type Err = ShouldBeKeyofT<Q[string & keyof Q]>

Could you please share me the playground link for your example?

I'm running off master (merged just now). I used this snippet to get the extended error message by assigning to keyof T. The function foo does not error in 3.4 (playground), but does error in master.
function foo<T, Q extends Bar<T>>() {
    const a: Q[keyof Q]["0"] = undefined as any;
    let b: keyof T;
    b = a;
}

type X<T> = { [key_ in keyof T]: [key_] }[keyof T];

function foo<T>() {
  const a: X<T>["0"] = undefined as any;
  let b:keyof T;
  b = a; // error
}

type Y<T> = { [key_ in keyof T]: key_ }[keyof T];

function bar<T>() {
  const a: Y<T> = undefined as any;
  let b:keyof T;
  b = a; // ok
}

I saw the same error in 3.5.0-dev.20190515. And there's no error in 3.4.3.
I don't fully understand the unsoundness in foo yet.
But it seems strange to me that only one of them gives error.
Also the expansion({ [key_ in keyof T]: [key_]; }[keyof T]["0"] to string | number | symbol) looks little naive.

Both look like they should be ok to me (so the first seems buggy: it's turning key_ into its constraint), though they are different to your original example. In your original example you are going through generic constraint with a string indexer, here you directly interact with a generic mapped type.
The issue in your first example is that only the string keys of Q are guaranteed to respect the constraint, but in the definitions of Baz and Qux you are assuming that all keys in Q respect the constraint.

type Baz<T, Q extends Foo<T>> = {
  [key in string & keyof Q]: T[Q[key]]
}

type Qux<T, Q extends Bar<T>> = {
  [key in string & keyof Q]: T[Q[key]["0"]]
}

Then does it solve the problem? I'm asking if both Baz and Qux should be valid in next version of typescript.

Is this going to be fixed before the release of 3.5.0 or later?

Baz and Qux in the original example should both be valid.
Since Q extends Foo<T> and Foo<T> has a string index signature constrained to keyof T, we reason that Q[keyof Q] is assignable to keyof T (i.e. that all properties in Q are constrained to keyof T). This is strictly not correct because Q might have symbol-named properties that aren't subject to the index signature constraint, but we chose to live with that when we extended keyof to include number and symbol named properties.
The only difference between Foo<T> and Bar<T> is the additional nesting in a tuple type and the corresponding fetching of the "0", so that should be valid too. It looks like we're not correctly analyzing the constraint of Q[key]["0"].


If the file type is not supported by the large archive scanner, and is less then the min-size, it should still scan it.

If the file type is not supported for unpacking, this tool skips it:
❯ docker exec --interactive --tty "clam_container_01" archive scan --ignore-size /target/README.md
Usage: archive scan [OPTIONS] PATH
Try 'archive scan --help' for help.

Error: Invalid value: Unhandled file type: FileType.UNKNOWN

File types not supported for archive extraction should still be scanned if they are less than the min-size.

This was resolved by #5 as well


[IMPAC-333] Added the toggle a hide/show effect on the whole KPIs bar

Merged into https://github.com/maestrano/impac-angular/pull/257


URI parsing decorator

Fixes #608
Supersedes #587
Changes proposed in this pull request:

array logic refactored into one place.
validation.py and parameter.py no longer try to join the array, and the split it again.
validation of defaults now works, because the validator is given the correct type.
some additional classes that change the behavior of deduplicating query parameters that are defined multiple times

AlwaysMultiURIParser that is backwards compatible, warts and all (used by default)
Swagger2URIParser that adheres to the spec's definition of collectionFormat: multi and uses the last-defined query parameter value (ex. query?a=1&a=2 => a = 2)
FirstValueURIParser that behaves like Swagger2URIParser, except that the first-defined value is used (ex. query?a=1&a=2 => a=1)

This cleanup is really helpful for OAS3 support as well (#420).

Coverage decreased (-0.3%) to 99.434% when pulling c2b849a710d145e7f57a1fd54381e487acf5d91c on dtkav:uri_parsing_decorator into 0b19ed489a8e701df94ec995c17c5abc931e1b63 on zalando:master.

hey @rafaelcaricio - any thoughts on backwards compatibility vs correctness? I've defaulted to a backwards compatible mode, but it would be great to switch to the Swagger2URIParser on a major version bump or something.

Thanks for the PR. How would I change the URI Parser for my application? This needs to be documented.
As for the default resolver the safest option will be to leave Swagger 2 as is and use do the "right thing" for OpenAPI 3.

@jmcs do you think users will want to override the URI Parser?
If so, how do you recommend adding the option? I can think of a couple ways:

Through ConnexionOptions
Allow the user to specify the Operation class to add_operation(...) in apis/abstract.py, so they can easily override methods, and specify their custom operation class.

If it won't be something that users will use, shall I just remove the other classes? Having the uri parser api is handy for having a swagger2 and openapi3 implementation, but I don't need to supply additional swagger2 classes if they aren't helpful. I'm happy to remove them - they were still a useful discussion aid for potentially changing the default behavior.

@dtkav I think that Swagger2URIParser might be of interest for new applications.
Since add_operations is usually not called by the user directly, it should be configurable in ConnexionOptions.

@jmcs ok, I've added uri_parser_class to the ConnexionOptions class, a test case, and some docs.
Along the lines of idea 2 above, I could expose the Operation class through options instead, which would allow a user to override more behaviors, and would be a more generic solution.

here's an example of changing the Operation class.
https://github.com/dtkav/connexion/compare/uri_parsing_decorator...dtkav:uri_parsing_decorator_operation_override

I think the build is broken for python 3.4 - I'm looking into that separately, but it's getting near the end of my working day. Thanks for your thoughts and comments.

:+1:

It's difficult for me to assess the impact of this change, but I'm OK with merging if @jmcs says :+1:.


Version number

It would help if you could add a version number and change log. This would make it easier for the Kali Linux dev team to track.

Hi Lee,
Of course it would. We do use version numbers in fact. Check out the releases and also the source code (here and there).
Do you need something else for the Kali team?


Python ESSA: Refactor and clarify.

This PR is formed of a series of self-contained commits.
Review by commit is recommended.

Closing in favour of https://github.com/Semmle/ql/pull/1784


Cannot unzip Godot 4 download

Godot version
4.0.2
System information
MacOS
Issue description
The objective is to download Godot 4 via Command Line for CI/CD. Below are the steps to reproduce the bug.
curl -o ./godot.zip https://github.com/godotengine/godot/releases/download/4.0.2-stable/Godot_v4.0.2-stable_macos.universal.zip # the download succeeded and I can see ./godot.zip with cd
unzip ./godot.zip

Archive:  ./godot.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of ./godot.zip or
        ./godot.zip.zip, and cannot find ./godot.zip.ZIP, period.

As you can see, I cannot unzip. The command jar xvf godot.zip returns java.util.zip.ZipException: zip file is empty.
Steps to reproduce
Run:
curl -o ./godot.zip https://github.com/godotengine/godot/releases/download/4.0.2-stable/Godot_v4.0.2-stable_macos.universal.zip
unzip ./godot.zip

Minimal reproduction project
Not needed.

Are you sure the file is not broken? I tried your curl and the resulting file is 0 B

Good catch, looks like I don't know how to use curl..
The following works fine (with -LO):
curl -LO https://github.com/godotengine/godot/releases/download/4.0.2-stable/Godot_v4.0.2-stable_macos.universal.zip
unzip Godot_v4.0.2-stable_macos.universal.zip

You must use -L to follow redirects.
Please don't ask support questions here, as this issue tracker is meant to be used for bug reports only. Use one of the other community channels instead.


docs: rewrite readme and add new features

This includes new TUI part as well as logo and more

Only thing missing is the TUI usage video on the readme and some proof reading of it


Added CssBaseline to the StoryBlokPage theme provider

This component allows the theme to provide a global background-color, layout changes, and typography properties. This will be needed to have a second (dark theme) to toggle between
Doc refernce
https://material-ui.com/components/css-baseline/#page

I dont know how I would test this or if it's necessary to test but let me know if I can do something here.

looks like the test are passing nice find I will pull it in we do need to increment the version for the npm to get this live


How to reference an example from another repo in bgs

I created an example for using bgs with bevy_mod_oxr

How should I add this example into this repo, since it would be useful to reference for the oxr support.

https://github.com/MiniMinerX/bevy_gaussian_oxr_simple

awesome oxr example!
seeing xr as a platform, similar to wasm, to port as an example here, any xr-specific dependencies would need to be available from crates.io and optional with an xr cargo feature.
minimal xr-specific systems (e.g. camera controls) can be added to the existing viewer, e.g. https://github.com/mosure/bevy_gaussian_splatting/blob/b8d7ed106b8c5049a93bbfd63fe593ce4f82c16f/viewer/viewer.rs#L138
this would allow running on an xr example directly, e.g. cargo run --bin viewer --features xr
also feel free to start a discussion linking your project.


Frequency Bands can be defined in terms of band edges

This should be done before either #47 or #67. It is the general use case and needs to be made to work with emtf band setup configuration (the current default)

Once that is running, want to allow user to simply request a number of bands per decade or bands per octave as a default, normally done in log-space, i.e. band edges form a geometric series.
e.g. band_edges: 1-2, 2-4, 4-8, 8-16, ...

The band edges would normally be created with some knowledge of:

Data sample rate (at each decimation) 1/dt
Time series window length (at each decimation) N

df = 1 / (N*dt)
At each decimation the frequency content is [0, f_Nyq], where f_Nyq = f_sps/2
Making band edges manually doesn't make a lot of sense.  This should be done via a UI that shows the user where the FCs are located on the frequency axis, and allows binning with a selection tool, or according to a standard (log-spaced) method of generating a frequency axis.  Note that such methods often yield some empty bands at lower frequencies due to the initial slow growth of the geometric series of band edges and the sparseness of the FCs.  How to handle this not 100% clear yet.
We will not allow the DC component into the analysis.  Setting the lower bound of the interval to 0 should be treated as setting it to be df/2.
In any case, assuming you had a set of reasonable band edges that you pass in, would we want to "tidy them up" to use df/2 edges?  I think the answer is yes, if we were not going to change decimation factor (which would change sample rates, which would change df), or window length, which would change df.
This suggests a flow:

First choose # of decimation levels and decimation factors
Then choose window length,
Then specify bands

Next step

[ ] print the band edges that are assigned from the EMTF band setup file and try putting those into the config

This is looking pretty good.  Bands can be set from either an emtf band_setup_file or via a dictionary of band edges.
In future we may want to address a few other points, such as

Add  band_edge_definition = ["exact", "canonical"] to config
Add a placeholder for the emtf band_setup file path, or at least it's contents when it is the band definintion
Add a placeholder in config to tell how bands were specified (emtf_file or band edges)

but I will put these into a review task to do later.


Change timeout dialog background and text color

The timeout dialog's border appears to be fixed to gray color. Having a gray colored border causes the dialog to blend into the check screen background color.
The dialog background is now changed to black and the text color changed to white. The timeout dialog is now more distinct.

/lgtm


[Galileo gen2] Analog pin defect?

With nothing attached to the analog pins:
Test:
var m = require("mraa");
for (var i = 0; i < 6; i++) {
  console.log(new m.Aio(i).read());
}

Result:
1016
224
1021
1022
993
882

Test:
import mraa

for x in range(0, 6):
  print mraa.Aio(x).read()

Result:
1020
218
1021
1022
993
883

Disregarding the line noise, A1 is obviously experiencing some issue and I'm not sure how to find it. This may not even be an mraa issue, but I don't know where else to report.
edit
If I put a jumper across 5V and A1, the value is a nice 1023.

@arfoll, have you ever heard back from HW team on this?

Closing as this is a hardware issue but I'm not getting a good answer.


scroll mode for testool

Description
[PR description]
Issue Link
[link issue here]
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Contents

[item]

Rationale
[design decisions and extended information]
How Has This Been Tested?
[explanation]

How to fill a PR description
Please give a concise description of your PR.
The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.
MUST: Reference the issue to resolve
Single responsability
Is RECOMMENDED to create single responsibility commits, but not mandatory.
Anyway, you MUST enumerate the changes in a unitary way, e.g.
This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices
RECOMMENDED to:

What types of design choices did you face?
What decisions you have made?
Any valuable information that could help reviewers to think critically

(low priority).  @noel2004   there seems to be something not thread safe in zktrie.  When i run this testool with scroll feature enabled using multi thread, the zktrie panics and has strange behavior.. Maybe there is something globally shared.. ?

(low priority). @noel2004 there seems to be something not thread safe in zktrie. When i run this testool with scroll feature enabled using multi thread, the zktrie panics and has strange behavior.. Maybe there is something globally shared.. ?

Concurrent access of ZktrieState or ZkTrie object is not thread safe. I would add !Sync trait on these two type so compiler could help us find where the issue is. Only if testtool do not include unsafe code.

@noel2004 after replay mpt updates, roots non consistent

\b run testool 1

another roots error
C="push0_d3(push0_upd_storage)_g0_v0"

#CHECK_RW_LOOKUP=true
FLAG=" --features=scroll"

RUST_BACKTRACE=1 RUST_LOG=trace cargo run --release $FLAG -- --circuits basic --inspect "${C}" 2>&1 | tee log
grep ERROR log


Previously selected imagery layer is selected even if it doesn't make sense for the initial viewport

Description
I was editing in The Netherlands previously where they have super nice 10cm aerials.
Just now I loaded Rapid again and it was zoomed out to the world but the NL imagery was still selected.

Version
2.0.1
What browser are you seeing the problem on? What version are you running?
Firefox v.latest
The OS you're using
Mac
Steps to reproduce
No response
The browser URL at the time you encountered the bug
https://rapideditor.org/edit#background=Actueel_orthoHR_WMTS&datasets=fbRoads,msBuildings&map=2.00/8.1/1.4
The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)
No response

Thanks for opening this @mvexel 👍
I remember finding this when we switched from using d3 to pixi for drawing the background imagery, left a comment, but forgot to open an issue about it.
https://github.com/facebook/Rapid/blob/206e72a2d98f38d9efd5b19dc894e7fe1c8a1b22/modules/renderer/RendererImagery.js#L46


Add dependabot to the repo

Dear developer! Please add dependabot to the repo. It's a free bot that regularly scans the repo for outdated dependencies and creates pull-requests to update the dependency. This is important in terms of security, because newer releases often fix bugs and security problems. Thanks in advance.
https://github.com/marketplace/dependabot

I will try it, Tks !

I prefer to manually maintain npm dependencies.


Update sizes.md - missing HBv3

HBv3 was missing from list of "High performance compute" sizes.

@cshalda : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver please merge these changes. Thank you!

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Resolved the merge conflict; merging now @ju-shim.


feat: add link to collection history

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[x] PR closes #2562
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[x] I've tested PR on mobile and everything seems works
[x] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

The graph works with scroll viewport to the right place, but history seems does not.
https://user-images.githubusercontent.com/5887929/158793390-f2b3f44a-6a95-4157-bf0c-e285ebce63b1.mov

The graph works with scroll viewport to the right place, but history seems does not.
Screen.Recording.2022-03-17.at.11.48.30.mov

Got. It may only happen in some collections. Let me fix it.

The graph works with scroll viewport to the right place, but history seems does not.
Screen.Recording.2022-03-17.at.11.48.30.mov

Got. It may only happen in some collections. Let me fix it.

@yangwao  hey, I think it works well on every collection now.

wfm me!
pay 100 usd

pay 100 usd

smh is wrong

oh @Jarsen136 can you check your address please? :)

@yangwao  Oh, I'm so sorry. My correct KSM address: Payout

pay 100 usd
wfm me ;)

😍 Perfect, I’ve sent the payout
💵 $100 @ 144.66 USD/KSM ~ 0.691 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x75d225e456299233b4ebd79cb77c8ca8eca8c3e61eaebd2cc1bedea8889c61c9
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Add test for throttling that checks no txs have been lost

Problem
No problem, just implemented this test while experimenting with throttling and thought that there is no harm in adding it.
Summary of Changes
Add a test that checks that transactions are delivered during the connection throttling events.
In theory it is also possible to check that the time to send is greater or equal to the unstaked connection rate per number of transactions, but this would require saturating the receive window on the server side (changing the server config settings to have small window size) but since it is not easy currently, will check only that all the packets have been delivered.

Looks like CI breaks with test "test_duplicate_with_pruned_ancestor" which has no relationship to this test


Could not add new connection to cp

After running about 3 hours, it could not add new connection to connection pool.
There's same question in issues, but developer comments said it has been fixed in v5.0.0, so I change into v5.0.0. But it still appears. Request for help!!!
SpringBoot Config
spring:
  datasource:
    hikari:
      minimum-idle: 5
      maximum-pool-size: 10
      idle-timeout: 180000
      auto-commit: true
      connection-test-query: SELECT 1
      max-lifetime: 180000
      leakDetectionThreshold: 2000

    driver-class-name: org.postgresql.Driver
    url: ${POSTGRES_DATABASE:jdbc:postgresql://xxxx:5432/test?ssl=true&connectTimeout=0&socketTimeout=0&tcpKeepAlive=true}
    username: ${POSTGRES_UESRNAME:xxx}
    password: ${POSTGRES_PASSWORD:xxx}

2021-08-13 11:39:11.727 DEBUG 14564 --- [nnection closer] com.zaxxer.hikari.pool.PoolBase          : HikariPool-1 - Closing connection org.postgresql.jdbc.PgConnection@4090677: (connection was evicted)
2021-08-13 11:39:12.139 DEBUG 14564 --- [onnection adder] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Added connection org.postgresql.jdbc.PgConnection@25bab4cd
2021-08-13 11:39:17.903 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=5, active=1, idle=4, waiting=0)
2021-08-13 11:39:23.262  INFO 14564 --- [pool-1-thread-2] c.m.t.s.c.core.handler.AlarmAnalyzer     : {increasedCount=441, increasedDevice=194, increasedCountAllVersion=856, increasedDeviceAllVersion=357} enforced to be true
2021-08-13 11:39:24.084 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Add connection elided, waiting=0, adders pending/running=2
2021-08-13 11:39:24.085 DEBUG 14564 --- [nnection closer] com.zaxxer.hikari.pool.PoolBase          : HikariPool-1 - Closing connection org.postgresql.jdbc.PgConnection@16b23077: (connection has passed maxLifetime)
2021-08-13 11:39:33.199 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Add connection elided, waiting=0, adders pending/running=3
2021-08-13 11:39:33.199 DEBUG 14564 --- [nnection closer] com.zaxxer.hikari.pool.PoolBase          : HikariPool-1 - Closing connection org.postgresql.jdbc.PgConnection@3c6d0d6e: (connection has passed maxLifetime)
2021-08-13 11:39:47.905 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=3, active=0, idle=3, waiting=0)
2021-08-13 11:40:17.914 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=3, active=0, idle=3, waiting=0)
2021-08-13 11:40:47.918 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=3, active=0, idle=3, waiting=0)
2021-08-13 11:40:48.293 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Add connection elided, waiting=0, adders pending/running=7
2021-08-13 11:40:48.294 DEBUG 14564 --- [nnection closer] com.zaxxer.hikari.pool.PoolBase          : HikariPool-1 - Closing connection org.postgresql.jdbc.PgConnection@4ef4d511: (connection has passed maxLifetime)
2021-08-13 11:41:17.920 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=2, active=0, idle=2, waiting=0)
2021-08-13 11:41:40.826 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Add connection elided, waiting=0, adders pending/running=9
2021-08-13 11:41:40.827 DEBUG 14564 --- [nnection closer] com.zaxxer.hikari.pool.PoolBase          : HikariPool-1 - Closing connection org.postgresql.jdbc.PgConnection@4cec8932: (connection has passed maxLifetime)
2021-08-13 11:41:47.925 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=1, active=0, idle=1, waiting=0)
2021-08-13 11:42:09.779 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Add connection elided, waiting=0, adders pending/running=11
2021-08-13 11:42:09.779 DEBUG 14564 --- [nnection closer] com.zaxxer.hikari.pool.PoolBase          : HikariPool-1 - Closing connection org.postgresql.jdbc.PgConnection@25bab4cd: (connection has passed maxLifetime)
2021-08-13 11:42:17.928 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=0, active=0, idle=0, waiting=0)
2021-08-13 11:42:47.944 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=0, active=0, idle=0, waiting=0)
2021-08-13 11:43:09.918  INFO 14564 --- [pool-1-thread-1] c.m.t.s.c.core.handler.Handler           : get 1 items form appcenter
2021-08-13 11:43:09.919 DEBUG 14564 --- [pool-1-thread-1] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Add connection elided, waiting=1, adders pending/running=14
2021-08-13 11:43:17.946 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=0, active=0, idle=0, waiting=1)
2021-08-13 11:43:39.930 DEBUG 14564 --- [pool-1-thread-1] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Timeout failure stats (total=0, active=0, idle=0, waiting=0)
2021-08-13 11:43:39.966 ERROR 14564 --- [pool-1-thread-1] c.m.t.s.c.core.handler.Handler           : an error occurred in handler: nested exception is org.apache.ibatis.exceptions.PersistenceException:
### Error querying database.  Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is java.sql.SQLTransientConnectionException: HikariPool-1 - Connection is not available, request timed out after 30012ms.
### The error may exist in com/microsoft/teams/search/crashmonitor/core/dao/CrashDao.java (best guess)
### The error may involve com.microsoft.teams.search.crashmonitor.core.dao.CrashDao.selectList
### The error occurred while executing a query
### Cause: org.springframework.jdbc.CannotGetJdbcConnectionException: Failed to obtain JDBC Connection; nested exception is java.sql.SQLTransientConnectionException: HikariPool-1 - Connection is not available, request timed out after 30012ms.
2021-08-13 11:43:47.953 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=0, active=0, idle=0, waiting=0)
2021-08-13 11:44:17.962 DEBUG 14564 --- [l-1 housekeeper] com.zaxxer.hikari.pool.HikariPool        : HikariPool-1 - Pool stats (total=0, active=0, idle=0, waiting=0)

try config socketTime, ref: https://github.com/brettwooldridge/HikariCP/wiki/Rapid-Recovery


great work!

long time php fan here.
have no direct use of this, but i love it!

why... would you do this

It has great potential use! See Blazor from MS - it provides a way to run a C# code in browser and use it instead of JS. It could be possible do the same thing with PHP.

It has great potential use! See Blazor from MS - it provides a way to run a C# code in browser and use it instead of JS. It could be possible do the same thing with PHP.

Indeed incredible

I like this too ;)


[Event Change Request] table 900 "Assembly Header"- OnBeforeCheckIsNotAsmToOrder

Could you please restructure the code that the event OnBeforeCheckIsNotAsmToOrder will include the CallingFieldNo, as you said that it would in an future release (see https://github.com/microsoft/ALAppExtensions/issues/14917)?
field(33; "Bin Code"; Code[20])
{
    trigger OnValidate()
    begin
        //+Change
        //-CheckIsNotAsmToOrder();
        CheckIsNotAsmToOrder(Rec.FieldNo("Bin Code"));
        //-Change
        ValidateBinCode("Bin Code");
    end;
}

procedure CheckIsNotAsmToOrder()
begin
    CheckIsNotAsmToOrder(0);
end;
procedure CheckIsNotAsmToOrder(CallingFieldNo: Integer)
var
    IsHandled: Boolean;
begin
    IsHandled := false;
    //+Change
    //-OnBeforeCheckIsNotAsmToOrder(Rec, IsHandled, xRec, CurrFieldNo);
    OnBeforeCheckIsNotAsmToOrder(Rec, IsHandled, xRec, CurrFieldNo, CallingFieldNo);
    //-Change
    if IsHandled then
        exit;

    CalcFields("Assemble to Order");
    TestField("Assemble to Order", false);
end;

[IntegrationEvent(false, false)]
//-local procedure OnBeforeCheckIsNotAsmToOrder(var AssemblyHeader: Record "Assembly Header"; var IsHandled: Boolean; xAssemblyHeader: Record "Assembly Header"; CurrentFieldNo: Integer) //OLD
local procedure OnBeforeCheckIsNotAsmToOrder(var AssemblyHeader: Record "Assembly Header"; var IsHandled: Boolean; xAssemblyHeader: Record "Assembly Header"; CurrentFieldNo: Integer; CallingFieldNo: Integer) //NEW
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Create namespace error

First: I want to create a namespace,but i find the created namespace is error

create namespace abv
Error: parse "x.x.x.x:9379/api/v1/namespaces": first path segment in URL cannot contain colon
create abv
Error: wrong arguments

second: I create the namespace by API,it ok,but I can not get namespace wiht /opt/kvrocks-controller/_build/kvctl-client -e x.x.x.x:9379
cd
Error:

cd test-ns
Error: parse "x.x.x.x:9379/api/v1/namespaces/test-ns": first path segment in URL cannot contain colon

config.yaml:
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements.  See the NOTICE file
distributed with this work for additional information
regarding copyright ownership.  The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License.  You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied.  See the License for the
specific language governing permissions and limitations
under the License.

addr: "x.x.x.x:9379"
Which storage engine should be used by controller
options: etcd, zookeeper
default: etcd
storage_type: zookeeper
etcd:
addrs:
- "<IP_ADDRESS>:2379"
username:
password:
elect_path:
tls:
enable: false
cert_file:
key_file:
ca_file:
zookeeper:
addrs:
- "x.x.x.x:2181"
scheme:
auth:
elect_path:
controller:
failover:
gc_interval_seconds: 3600
ping_interval_seconds: 5
min_alive_size: 10
max_failure_ratio: 0.6

Hi, you have set your storage_type with zookeeper,but you don't set zookeeper addrs
If you want to use etcd please set storage_type: etcd

yes.i use the zookeeper addrs  ,and I can create a namespace “test-ns” by calling the api via postman, but kvctl-client cannot cd into this namespace
config.yaml,egg:
addr: "10.69.187.x:9379"
Which storage engine should be used by controller
options: etcd, zookeeper
default: etcd
storage_type: zookeeper
etcd:
addrs:
- "<IP_ADDRESS>:2379"
username:
password:
elect_path:
tls:
enable: false
cert_file:
key_file:
ca_file:
zookeeper:
addrs:
- "10.69.188.x:2181"
scheme:
auth:
elect_path:
controller:
failover:
gc_interval_seconds: 3600
ping_interval_seconds: 5
min_alive_size: 10
max_failure_ratio: 0.6

问题解决了，kvctl-client需要这样子访问"/opt/kvrocks-controller/_build/kvctl-client -e http://x.x.x.x:9379",之前是这样"/opt/kvrocks-controller/_build/kvctl-client -e x.x.x.x:9379".thank you, but the website doesn't say

Problem solved. kvctl-client needs this access "/opt/kvrocks-controller/_build/kvctl-client -e http://x.x.x.x:9379""/opt/kvrocks-controller/_build/kvctl-client -e x.x.x.x:9379",, thank you, but the website doesn't say

Ok, thanks!


[Failing test] ColoredLogsTestCase.test_plain_text_output_format

[   60s] + py.test-3.7 coloredlogs/tests.py -v -k 'not (test_cli_conversion or test_auto_install)'
[   61s] ============================= test session starts ==============================
[   61s] platform linux -- Python 3.7.2, pytest-3.10.1, py-1.7.0, pluggy-0.8.0 -- /usr/bin/python3
[   61s] cachedir: .pytest_cache
[   61s] rootdir: /home/abuild/rpmbuild/BUILD/coloredlogs-10.0, inifile:
[   61s] plugins: cov-2.6.0
...
[   61s] =================================== FAILURES ===================================
[   61s] ______________ ColoredLogsTestCase.test_plain_text_output_format _______________
[   61s]
[   61s] self = <coloredlogs.tests.ColoredLogsTestCase testMethod=test_plain_text_output_format>
[   61s] test_method = <bound method ColoredLogsTestCase.test_plain_text_output_format of <coloredlogs.tests.ColoredLogsTestCase testMethod=test_plain_text_output_format>>
[   61s] args = (), kw = {}
[   61s]
[   61s]     def skipTestWrapper(self, test_method, *args, **kw):
[   61s]         """
[   61s]         Wrap test methods to translate exceptions into skipped tests.
[   61s]
[   61s]         :param test_method: The test method to wrap.
[   61s]         :param args: The positional arguments to the test method.
[   61s]         :param kw: The keyword arguments to the test method.
[   61s]         :returns: The return value of the test method.
[   61s]
[   61s]         When a :class:`TestCase` object is initialized, :func:`__init__()`
[   61s]         wraps all of the ``test_*`` methods with :func:`skipTestWrapper()`.
[   61s]
[   61s]         When a test method raises an exception, :func:`skipTestWrapper()` will
[   61s]         catch the exception and call :func:`shouldSkipTest()` to decide whether
[   61s]         to translate the exception into a skipped test.
[   61s]
[   61s]         When :func:`shouldSkipTest()` returns :data:`True` the exception is
[   61s]         swallowed and :exc:`unittest.SkipTest` is raised instead of the
[   61s]         original exception.
[   61s]         """
[   61s]         try:
[   61s] >           return test_method(*args, **kw)
[   61s]
[   61s] /usr/lib/python3.7/site-packages/humanfriendly/testing.py:678:
[   61s] _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
[   61s]
[   61s] self = <coloredlogs.tests.ColoredLogsTestCase testMethod=test_plain_text_output_format>
[   61s]
[   61s]     def test_plain_text_output_format(self):
[   61s]         """Inspect the plain text output of coloredlogs."""
[   61s]         logger = VerboseLogger(random_string(25))
[   61s]         stream = StringIO()
[   61s]         install(level=logging.NOTSET, logger=logger, stream=stream)
[   61s]         # Test that filtering on severity works.
[   61s]         logger.setLevel(logging.INFO)
[   61s]         logger.debug("No one should see this message.")
[   61s]         assert len(stream.getvalue().strip()) == 0
[   61s]         # Test that the default output format looks okay in plain text.
[   61s]         logger.setLevel(logging.NOTSET)
[   61s]         for method, severity in ((logger.debug, 'DEBUG'),
[   61s]                                  (logger.info, 'INFO'),
[   61s]                                  (logger.verbose, 'VERBOSE'),
[   61s]                                  (logger.warning, 'WARNING'),
[   61s]                                  (logger.error, 'ERROR'),
[   61s]                                  (logger.critical, 'CRITICAL')):
[   61s]             # Prepare the text.
[   61s]             text = "This is a message with severity %r." % severity.lower()
[   61s]             # Log the message with the given severity.
[   61s]             method(text)
[   61s]             # Get the line of output generated by the handler.
[   61s]             output = stream.getvalue()
[   61s]             lines = output.splitlines()
[   61s] >           last_line = lines[-1]
[   61s] E           IndexError: list index out of range
[   61s]
[   61s] coloredlogs/tests.py:396: IndexError
[   61s] ----------------------------- Captured stderr call -----------------------------
[   61s]

Official package for openSUSE/Tumbleweed.

I'm seeing this same error during official packaging for Fedora on Python 3.7 as well. It appears that once a logging event occurs, the level can't be changed.

I enabled Python 3.7 testing on Travis CI earlier today and was disappointed to run into the same test failure that is mentioned here. I then spent way too much of my time to get to the root cause (before I had read this issue).
This is definitely caused by a regression in behavior from Python 3.6 to 3.7, in fact I'm inclined to call it a bug, but I'm not sure if anyone cares (log levels don't usually change much). The issue is caused by isEnabledFor() using a stale (level, enabled) cache entry.
For now I've added a workaround to the test suite (cc41bf1e5e9ec4499c0db46c9c9a31d1438128e3) that clears the cache inside of the affected test, resolving the immediate issue. This was the only Python 3.7 incompatibility.
I'm going to close this issue now, given that the test suite now passes on Python 3.7.


Revert "test: Use xip.io domains"

This introduced intermittent failures in CI when trying to resolve xip.io domains, e.g:
dial tcp: lookup controller.<IP_ADDRESS>.xip.io: No address associated with hostname

This reverts commit 41b6357c4a5a9dfbcc95b390e47cc2da71f47632.

LGTM


shell_helpers: add tldr

TLDR is a useful man page addition so I strongly recommend installing it.
The commands are based on other shell helpers.

Could you please include tldr in tasks/shell_helpers/shell_helpers.yml that it takes effect.

Ups, I didn't read that file and thought the import was generic.


Datepicker in read-only mode

Bug type
Component
Component name
DatePicker
What happened?
When date picker is marked as ReadOnly, when a user clicks on the text, the Dialog/popover box to select a new date still shows.
Not sure if this is intended, but In my opinion, this should not display at all in this scenario.
Expected behavior
When clicking the ReadOnly datepicker, the popover to select the date should now show.
Reproduction link
https://try.mudblazor.com/snippet/cYmHEFufgjhJQHXB
Reproduction steps
Mark any MudDatePicker as ReadOnly
  <MudDatePicker                                            AnchorOrigin="Origin.BottomCenter"                                            DateFormat="MM/dd/yyyy"                                            Label="Date"                                            ReadOnly                                            Variant="Variant.Outlined"/>
Relevant log output
No response
Version (bug)
6.1.7
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Chrome
On what operating system are you experiencing the issue?
Linux
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I believe this is fixed in the latest versions - If it's still an issue please ping a team member so we can re-open the issue.


DAC6-916:add scala formatting plugin scalafmt

test this please

test this please

test this please

test this please

test this please


Add permission to prevent snitch alerts and logs

https://github.com/Civcraft/JukeAlert/issues/44

Looks good, nice work


not working on cemu anymore

after some windows updates this thing stopped connecting with cemu
server works, virtualhere works and i can plug in toypad without errors but emulator just wont recognize it, acting like nothing was connected

a vmware update apparently changed some settings. i changed network adapter back to bridged but there is still no connection. im not sure if the problem is on cemu or if toypad emulator just cant see the game

even after a fresh install it doesnt seem to work anymore. it just cant see the game

ok i found out what was wrong
CAREFUL WITH UPDATING WINDOWS 11 TO 23H3. apparently it replaced my drivers with winusb (for rpcs3)
steps to revert it (i use windows in spanish. expect inaccurate translations):

go to device manager (zadig wont install HID drivers)
go to USB devices > LEGO READER V2.10
right click > update driver
examine pc
pick from a list of available drivers
choose "USB INPUT DEVICE" (the only one that does not say LEGO READER)

this will change it to HID drivers. you wont be able to easily find the toypad in device manager anymore bc it changes to a generic name but zadig will display it as LEGO READER V2.10 whenever you want to change drivers for rpcs3

ok i found out what was wrong
CAREFUL WITH UPDATING WINDOWS 11 TO 23H2.
apparently it replaced my drivers with winusb (for rpcs3)
steps to revert it (i use windows in spanish. expect inaccurate translations):
1. go to device manager (zadig wont install HID drivers)

2. go to USB devices > LEGO READER V2.10

3. right click > update driver

4. examine pc

5. pick from a list of available drivers

6. choose "USB INPUT DEVICE" (the only one that does not say LEGO READER)

this will change it to HID drivers. you wont be able to easily find the toypad in device manager anymore bc it changes to a generic name but zadig will display it as LEGO READER V2.10 whenever you want to change drivers for rpcs3

I was also in the same spot after my test with RPCS3 then wanted to go back to Cemu, thanks for the fix!


No syntax::ast::MetaItem_ in latest nightly

When compiling under the latest nightly diesel_codegen fails to compile because of renaming of types in the syntax::ast module. The error is:
unresolved import 'syntax::ast::MetaItem_'. There is no 'MetaItem_' in 'syntax::ast'

This is being fixed by #217, stay tuned!

In case anyone else runs into this, a temporary fix is to clone the repository and copy the files in diesel_codegen to wherever cargo stores repositories. In my case, this was
~/.multirust/toolchains/nightly/cargo/registry/src/github.com-xxxxxxxxxxxx/diesel_codegen-0.5.0

Or just point your cargo file at git?

@sgrif I attempted to do that, but I was unsure what url to use for diesel_codegen. https://github.com/sgrif/diesel/diesel_codegen and https://github.com/sgrif/diesel/tree/master/diesel_codegen both failed to clone.

Just point it at this repo.
On Fri, Feb 19, 2016, 7:21 PM nokaa<EMAIL_ADDRESS>wrote:

@sgrif https://github.com/sgrif I attempted to do that, but I was
unsure what url to use for diesel_codegen.
https://github.com/sgrif/diesel/diesel_codegen and
https://github.com/sgrif/diesel/tree/master/diesel_codegen both failed to
clone.
—
Reply to this email directly or view it on GitHub
https://github.com/sgrif/diesel/issues/218#issuecomment-186497041.

I didn't realise that was possible. Thank you! That is much easier.

You can also "override" some crates globally. Create a file named ~/.cargo/config, and type this:
paths = [
    "/home/barosl/cloned-git-repos/diesel",
]

In this way you don't need to modify your Cargo.toml. But don't forget to remove the global path after the official version is released, otherwise you will use the outdated (cloned) version forever.


fix: Validate the asset to contain a url

Fixes #164

@sman591 not sure how to go about reducing the code complexity

@sman591 Change has been made and added a bit more


Raise a more appropriate exception when unable to parse a file

Depends on: slamdata/quasar#3776
The exception now includes a hint towards a misconfigured datasource when unable to parse a resource.
The quasar-version in this PR needs to bumped after slamdata/quasar#3776 is merged.

Breaking since this makes quasar-s3 incompatible with older versions of Quasar.

Now the message in the responses looks like:
{
  "detail": {
    "path": "/post-giraffe.ldjson",
    "message": "Unable to open resource: Could not parse the file as JSON. Ensure you've configured the correct jsonParsing option for this bucket"
  },
  "status": "Bad Request",
  "name": "malformed-resource"
}

I used 400 Bad Request for the status code, but not sure if that's appropriate. And of course the details in the error message are controlled by the datasource, not Quasar.
cc @beckyconning

@wemrysi

Not that it need be done in this PR, but we may want to perform a HEAD request on a resource and look at the Content-Type before attempting to parse. If it is a type that we know we can't support then we can just error with something more specific

We already do a version of this to determine if a resource exists or if it's merely a prefix. Might be easy enough to improve it to check the Content-Type too.

@jsantos17 ready to bump version - feel free to merge after that when it's green

@rintcius @wemrysi Bumped quasar-version and build should be green, but now there's some sort of binary incompatibility with the last version of quasar, scalaz and this repo. Investigating...

Also, this incompatibility is why we have https://app.clubhouse.io/data/story/565/verify-quasar-s3-loads-into-slamdata-backend-in-the-travis-build


WindowGo/runOrRaiseNext must cycle through all client workspaces

Problem Description
Not an issue, but a feature request. If some client has been copied to another workspace by using the CopyWindow plugin functionality, runOrRaiseNext will not focus any other workspace, except the first one where the client occurs. In my opinion, it will be good if runOrRaiseNext switches between all client workspaces instead. Anyone with the knowledge how to implement that? I am not that good with Haskell.
Checklist

[x] I've read CONTRIBUTING.md

[ ] I tested my configuration with xmonad-testing

I don't use the X.A.WindowGo so I'm not familiar with the source, but I took a look at a few functions and I think I think I know how you can accomplish what you want. Take this with a grain of salt:
The problem isn't really runOrRaiseNext so much as it is W.focusWindow. Luckily the module exports a more general version by the name of raiseNextMaybeCustomFocus which allows you to use a focusing function other than W.focusWindow. You could write such a function in your config that took the workspace traversal order as an extra parameter then used it to decide which workspace's copy of the window to focus on. Good use of existing functions could make this a lot easier; e.g. it might suffice to make the chosen workspace current with W.view or W.greedyView before using W.focusWindow as normal. The extra parameter can later be eliminated by writing another X () action that asks for the information (something like order <- asks (workspaces . config) before passing it on.

Thanks a lot for your advice, @LSLeary. I will take a closed look in W.focusWindow and W.view.

This seems solved; @alesandar feel free to re-open if it's not.


[FEATURE] Button Download

Description
Create a button called Download with an icon next to the text.
Acceptance Criteria (AC)

[ ] Create a component called DownloadButton.js and save it in a folder called components in the src directory
[ ] The icon has to be an svg
[ ] Create a folder in the public directory and call it "images"
[ ] Save the svg in the new folder called "images"
[ ] Button does not require functionality
[ ] No stylings but plain html
[ ] The new component is imported and displayed in the App.js component
[ ] Only the new component is displayed

Screenshots
No response
Additional information
Please do not hesitate to ask me about accessible forms in case you are unsure.
Accessibility and your inexperience with this topic should not be the reason you are not work on this issue, but to learn about it.

hi, I would like to contribute to this project. Could you please explain more about where his component should be included?

Hey @DugarRishab thanks for pointing this out. I added the information in every issue. 👍🏽

@YuriDevAT Please look into all the un-closed PRs. I believe all PRs are facing the same issue mine included. Could you please guide us to resolve it?

Thank you for your comment. I will look into it on Wednesday, since I have currently no access to a computer.


[SPARK-46009][SQL][FOLLOWUP] Remove unused golden file.

What changes were proposed in this pull request?
This PR propose to remove unused golden file.
Why are the changes needed?
https://github.com/apache/spark/pull/46272 removed unused PERCENTILE_CONT and PERCENTILE_DISC in g4.
But I made a mistake and submitted my local test code.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA
Was this patch authored or co-authored using generative AI tooling?
'No'.

@dongjoon-hyun Thank you!


tsserver does not include typename in response to "implemention"-requests

TypeScript Version:  2.2.1
Code
Given the following contrived example-code:
interface IDemo {
   Foo();
}

class Demo1 implements IDemo {
   Foo() {
   }
}

Now use tsserver to ask for implementations of IDemo.Foo() using the implementaion command
Expected behavior:
Response to contain location of Demo1.Foo() and name of type.
Actual behavior:
Response only contains location of Demo1.Foo(). This makes generating a informative GUI hard.
Clarification:
Note: This is what I expect as an API-consumer. This is not what the contract declares. My issue is not a bug in fulfilling the existing contract, but that the current, limited scope of the contract should be considered a bug.
The protocol-file suggests there is a richer API in the form of implementations-full, but this is marked internal, and the contract is not documented at all.
Can we rely on this command in external applications to get more meta-data? If not, what would the recommended approach to obtain this data be?
I'm asking this in the context of getting "full" TypeScript-support into Emacs. Currently this is one of the areas where I feel the contract does not provide rich enough information to implement a good/full user-experience on top of.
While I here represent Emacs only, I'm sure other editors implementing the same client-features would agree having a type-name here would assist presenting the alternatives in a more informative and useful manner.

Old issue is old. Not sure if it's still even valid. Abandoning.


[Relay][Interpreter] Build self referential closure only when letrec is defined

Self referential closure creates memory leaks. We can avoid this memory leak in cases where recursive functions are not used. As discussed in https://github.com/dmlc/tvm/issues/3423, garbage collection or weak pointer is needed to fix the memory leak in the recursive case.
Before:
==3058763== LEAK SUMMARY:
==3058763==    definitely lost: 48 bytes in 1 blocks
==3058763==    indirectly lost: 128 bytes in 3 blocks
==3058763==      possibly lost: 82,062 bytes in 1,667 blocks
==3058763==    still reachable: 261,640 bytes in 4,301 blocks
==3058763==                       of which reachable via heuristic:
==3058763==                         stdstring          : 50,132 bytes in 1,037 blocks
==3058763==         suppressed: 0 bytes in 0 blocks

After:
==2878348== LEAK SUMMARY:
==2878348==    definitely lost: 0 bytes in 0 blocks
==2878348==    indirectly lost: 0 bytes in 0 blocks
==2878348==      possibly lost: 82,062 bytes in 1,667 blocks
==2878348==    still reachable: 261,640 bytes in 4,301 blocks
==2878348==                       of which reachable via heuristic:
==2878348==                         stdstring          : 50,132 bytes in 1,037 blocks
==2878348==         suppressed: 0 bytes in 0 blocks

@jroesch, @MarisaKirisame please review.

This fix it for this case. I am just in general unfavor of case by case fix, as it will always be incomplete (by rice theorem). I think some cycle detection on top of ref counting will be best and I will talk with @jroesch .

I totally agree. This does unblock us from deployment while you guys work on a more proper fix.

thanks, @hlu1 @MarisaKirisame , this PR is now merged.


[#2929] improvement(pyClient): Optimize Python client code and add integration test

What changes were proposed in this pull request?

Add _ before Python class member variable name, let it to private access level.
Add Metalake, Schema E2E integration test.

Why are the changes needed?
Fix: #2929
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
CI Passed.

@diqiu50 @shaofengshi @SophieTech88 Please help me review this PR, Thanks.

@diqiu50 @shaofengshi @jerryshao
I updated this PR, Please help me review this PR again, Thanks.


change dependencies

Change dependencies for Laravel 5.7
Source: https://laravel.com/docs/5.7/upgrade

Fixed with https://github.com/rcrowe/TwigBridge/pull/353


vite2 + vue3 ReferenceError: __dirname is not defined

Running into this issue:
https://github.com/transitive-bullshit/chatgpt-api/issues/334
__dirname is not defined

at node_modules/gpt-3-encoder/Encoder.js (http://localhost:3000/_nuxt/node_modules/.vite/deps/@waylaidwanderer_chatgpt-api.js?v=eadc4690:315:56)
at __require2 (http://localhost:3000/_nuxt/node_modules/.vite/deps/chunk-CLC6CPQL.js?v=eadc4690:19:50)
at node_modules/gpt-3-encoder/index.js (http://localhost:3000/_nuxt/node_modules/.vite/deps/@waylaidwanderer_chatgpt-api.js?v=eadc4690:470:30)
at __require2 (http://localhost:3000/_nuxt/node_modules/.vite/deps/chunk-CLC6CPQL.js?v=eadc4690:19:50)
at http://localhost:3000/_nuxt/node_modules/.vite/deps/@waylaidwanderer_chatgpt-api.js?v=eadc4690:17066:36

Not sure what version you're using, but I don't use gpt-3-encoder in the project anymore. It seems like you need to update.
However, ChatGPTClient isn't meant to be used in the frontend. You should run an API server instead.


Multiptle problem markers are appeared/disappeared on every scroll event for the correct query

Description
https://github.com/user-attachments/assets/a02c5c57-7d4e-4eae-bb7c-5e90e13ed062
DBeaver Version
Enterprise Edition 24.2.4-202410262322
Operating System
Windows 10
Database and driver
PostgreSQL 16
PostgreSQL JDBC Driver 42.7.4
Steps to reproduce
Try to scroll the script similarly how I do it on the video:
Script-47.zip
Additional context
No response

thanks for the report


Add number of missing inception skills and improve descriptions

New Skills Created:
Subject: Projects
copy a project
share project
changer order of subjects
change order of badges
Subject: Skills
Search and Navigate directly to a skill
Create Aesthetically Pleasing Description
Copy Skill
create skill group
reuse in project
move skills
import skills form catalog
change order of skills
Add addition columns to the skills table
Subject: Dashboard
Learn about Project Access Options
send success story
teach someone else
export to catalog
suggest tool integration
suggest a feature

New Badges:

Community Super Hero
Admin Starter
Metrics Ninja
Catalog User
Skills Organizer
Promoter

https://github.com/NationalSecurityAgency/skills-service/pull/1881

:+1:


Add SequenceSameValueHandler

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (54dbbb4) 100.00% compared to head (32f59b8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #369   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           55        56    +1
  Lines         1995      2014   +19
  Branches       366       369    +3
=========================================
+ Hits          1995      2014   +19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


prisma-mapper map doesn't respect data type in fields while setting defaults

System information:

NodeJS 18.15.0
npm 9.5.0
prisma-mapper 1.3.3

Hi!
following is an image of a column in database

this is how the prisma-mapper map translated the default value
TableName { [...] column BigInt?   @default("-2") [...] }
and prisma generate can't validate the resulting schema.prisma

I don't see an issue in the table, BigInt is an alias for int8
@imdoxy

Found the issue, prisma internals was telling that negatives numbers were strings instead of ints, it will be fixed in 1.4.1 @imdoxy

Thanks!


cleanup and consolidate path finding and fee computation

We've decided to remove the fees for the last hop (#226, #227, #228), i.e. change the computation of fees.
There's some some old code left that uses dijksta_weighted.find_path together with the  Graph._get_fee function.
We should be able to get rid of that and only use the new CostAccumulators.
The code needed for the reduce-debt endpoint can also be removed, since it's not being used from the clientlib.

This is implemented as of 95c2484fd0cfab1b80b748cfd9b50a753dedd58e


Check blob sidecar commitment at gossip if possible

Generally, blocks are expected to arrive before blobs. A useful validation step is to ensure that the KZG commitments of the blob and block body match before importing the blob. This adds an additional layer of verification, complementing the existing check: "The sidecar must be the only sidecar with a valid signature received for the tuple (sidecar.block_root, sidecar.index)."

wait, don't you get this for free in #3531. the merkle proof to the block-header proves this consistency wrt to that block and this seems strictly extraneous

wait, don't you get this for free in #3531. the merkle proof to the block-header proves this consistency wrt to that block and this seems strictly extraneous

#3513 does indeed supersede this one. Before opening this, I was uncertain about the status of #3513. I would prefer that solution over dealing with this gossip condition. I've also put considerable thought into whether this may still be relevant. However, I was unable to identify a specific scenario where this would be a useful defense

closing in favor of #3531


Add Cancelling state for jobs

When a job is cancelled, it moves first to "Cancelling" before Machine fully cancels the job.  A few notes:

Cancelling Job state should be added after Canceled to preserve numbering
If a job start is requested when a job is Cancelling, wait for a few seconds (timeout seconds - 1?) before responding while all the while checking if the cancellation completed (polling every second or subscribe).

Or, say "A job is Cancelling - please try again in a few seconds." - ok we can do this one

It may also require adding a engine.proto message to check status:

Add some cleanup logic for hanging jobs
This may be best implemented in machine or Serval

Thoughts here @ddaspit ? My impression was you were architecting and I was implementing. I'm happy to take it on fully if you like, but wouldn't want to step on feet. (Just trying to finish up the MVP tasks).

We can do this once https://github.com/sillsdev/machine/pull/101 is merged.

This is to add the cancelling state in Serval once the cancelling state in Machine is added in https://github.com/sillsdev/machine/pull/101.

I've reviewed the cancellation code in Serval and Machine, and I'm not sure what's left to be done here.

So if I am correct, Serval will say that it is deleted (or cancelled) right away, while Machine will have the "cancelling" state until the work is actually done?  Can we possibly add one missing E2E test (or similar) that tries to build an engine 1ms after it was running and deleted (or similar).  If the test already exists (or can be done at a unit or integration test level) then great - we can close the issue.

I believe that the steps are:

Serval sends a CancelBuildRequest to Machine
Machine first internally cancels the build (which involves setting the BuildJobState to None if it's Pending and Canceling if it's active). Then, if it were set to None (i.e., was previously Pending), Machine un-sets the current build and sends a BuildCanceledRequest back to Serval at which point Serval goes ahead and sets the state to Canceled etc.
Meanwhile, when/if the ClearMLMonitorService catches wind that the state has become Canceling, it sends a BuildCanceledRequest back to Serval at which point Serval goes ahead and sets the state to Canceled etc. Then it 'finishes' the job: un-setting the current build and incrementing the BuildRevision.

So the odd behavior is that if you request a build while it's Canceling in Machine, it will still say it's Active briefly (~10 seconds at the moment, I believe). You could add the Canceling state to Serval and another request in platform.proto that marks the build as Canceling, but I'm not sure that this is necessary. As for starting a build while the previous build is still canceling, currently, it will throw an exception saying "The engine has already started a build". Maybe the best solution on this side is to update the message to be something like "The engine is already building or in the process of canceling.", and then add a test in NmtEngineServiceTests. Thoughts, @johnml1135?

The swagger documentation update is probably enough - we don't even need the test.

Do you mean the update to the exception message? Alright, I'll go ahead and take care of that.


The advice about upload

Uploading a file with the same name will directly overwrite the old file. It is recommended to add a reminder or rename the file automatically.
In addition, it is recommended to add a column showing the upload time.

add tip in new version


Problem permission denied EACCES in SQLite

Hi, everybody.
I've had a problem when I try build an Electron App to darwin platform. The process build is ok, the problem is on when I try open my App on MacOS.
When App started, the first step is create a database in SQLite. The problem is here.
In console log show the following error message:
EACCES: permission denied, open 'myDB.db'
In others platforms is ok, just in MacOS doesn't work my App.
Tks

macOS sandboxing is probably preventing you from creating/writing to a file within the app. You shoud put your SQLite database in the user config folder, see app.getPath().


ClientTelemetryTests flaky

The trace even shows the CPU as NaN: DocDBTrace Information: 0 : System Usage recorded by telemetry is : {"systemHistory":[{"dateUtc":"2021-09-13T15:25:24.0897374Z","cpu":NaN,"memory":11566524.000,"threadInfo":{"isThreadStarving":"False","threadWaitIntervalInMs":0.6365,"availableThreads":32764,"minThreads":8,"maxThreads":32767}}]}
This causes the following assert to fail.
Assert.AreEqual failed. Expected:<2>. Actual:<1>. System Information Count doesn't Match; [{"metricInfo":{"metricsName":"MemoryRemaining","unitName":"MB","mean":10821.59375,"count":1,"min":10822.0,"max":10822.0,"percentiles":{"50":10821.6240234375,"90":10821.6240234375,"95":10821.6240234375,"99":10821.6240234375,"99.9":10821.6240234375}}}]

It will return CPU usage as NaN only in following cases:

If Native Function (Windows : kernel32.dll, Linux: /proc/stat) is not returning any value.
If totalElapsedTime is zero means difference between 2 consecutive reading are zero.

Related PR is out to fix this isue

Fix will be available in the latest Direct package.

Please keep this issue open until the direct package is updated and the assert is re-enabled in the test. Without an issue to track it the assert will not get enabled again.


Add xlsxwriter to improve to_excel performance

Please confirm that this PR has done the following:

[ ] Tests Added (none needed except for possibly benchmarks)
[ ] Documentation Added
[x] Name of contributors Added to AUTHORS.rst
[x] Description in RELEASE_NOTES.md Added

Description of PR
Added xlsxwriter to the dependencies of pyam. pandas uses xlsxwriter over openpyxl if it's found. This means that if xlsxwriter is found on the system it is used without any changes required.
According to benchmarks (https://exchangetuts.com/python-fastest-way-to-write-pandas-dataframe-to-excel-on-multiple-sheets-1640154784194443), xlsxwriter is significantly faster than openpyxl.
Should I set up some benchmarks of our own to test it for pyam?

I just pip-installed pyam in a clean environment and xlsxwriter was installed automatically already. Not sure if it's necessary to add it as an explicit dependency?

Interesting, it's not a dependency of pandas (https://github.com/pandas-dev/pandas/blob/main/setup.cfg#L33).
Maybe it was installed as a dependency by some other library.
I just tried the same, install pyam from a clean virtual environment and it did not install it for me. Maybe it's platform dependent.

You're right, looks like I was confused between two environments. Running some profiling now.

There is another usage of pd.ExcelWriter where the engine is not explicitly specified. Please make the two usages consistent.
https://github.com/IAMconsortium/pyam/blob/759120f01453f2738df6d4126186bb0a21cab54b/pyam/core.py#L2377

Updated the usage of xlsxwriter in pd.ExcelWriter.
There's one more thing that I found:
https://github.com/IAMconsortium/pyam/blob/main/pyam/utils.py#L135
is there a test for utils.write_sheet?

is there a test for utils.write_sheet?

It's tested implicitly via https://github.com/IAMconsortium/pyam/blob/759120f01453f2738df6d4126186bb0a21cab54b/tests/test_io.py#L56
The line you found was a hacky attempt by me to make xlsx files look "nice" by having useful column widths.

Ok, should I check if using xlsxwriter triggered the error?

Let me give this a quick try, I think you have more urgent things on your to-do list...

True, just thought this might be a quick one to get off the list ...


Created definitions for 'date-utils'

https://github.com/JerrySievert/node-date-utils/
test is broken on 0.9.5 (it's from a 0.9.0 project)
not sure how to declare the Date / Date.prototype enhancements

close the PR because this is too old.


always the same tick data

Just tried to run the example "strategy.py".
In "on_tick", added "print(tick)" after "tick = instrument.get_ticks(lookback=1, as_dict=True)"
always get the same data except the datetime is changed.
Is this right place to get tick data? I just wanted to display the tick data.

Ok. It turns out "tick = instrument.get_ticks(lookback=1, as_dict=True)" in the example always got the earliest tick instead of the latest one. It seems the ticks was not sorted correctly.  one way to get around is to fetch all ticks and sort it again.


Add set of tutorials for Clarity

Early draft for our tutorials.
Actively working on adding more tests / documentation.

[x] Comments
[x] More tests

  RocketFactoryClient Test Suite
    ✓ should have a valid syntax
    Deploying an instance of the contract
      ✓ should initialize Alice's state so that she can buy a new rocket (101ms)
      ✓ should initialize Bob's state so that he can buy a new rocket (152ms)
      ✓ should initialize Alice's number of rockets to 0 (145ms)
      ✓ should initialize Bob's number of rockets to 0 (100ms)
      ✓ should initialize Alice's balance (20 RKT) (103ms)
      ✓ should initialize Bob's balance (10 RKT) (120ms)
      ✓ should initialize the total supply of RKT to 30 (112ms)
    Alice buying a rocket of size 1
      ✓ should return an invalid receipt
      ✓ should not make Alice unable to buy a new rocket (111ms)
      ✓ should not decrease Alice's balance (20 RKT remaining) (104ms)
    Alice buying a rocket of size 21
      ✓ should return an invalid receipt
      ✓ should not make Alice unable to buy a new rocket (114ms)
      ✓ should not decrease Alice's balance (20 RKT remaining) (100ms)
    Alice buying a rocket of size 2
      ✓ should make Alice unable to buy a new rocket (99ms)
      ✓ should decrease Alice's balance to 19 RKT (104ms)
      ✓ should not produce a claimable rocket (111ms)
      ✓ should not impact Bob's ability to buy a new rocket (118ms)
      ✓ should not impact Bob's balance (10 RKT) (100ms)
      1 block after the transaction, Alice's rocket
        ✓ should not be claimable (118ms)
      2 blocks after the transaction, Alice's rocket
        ✓ should be claimable (94ms)
        Alice claiming her rocket
          ✓ should return a valid receipt
          ✓ should make Alice able to buy a new rocket (95ms)
          ✓ should decrease Alice's balance of 1 RKT (18 RKT remaining) (108ms)
          ✓ should update Alice's number of rockets to 1 (112ms)
    Alice buying a rocket of size 11
      ✓ should make Alice unable to buy a new rocket (124ms)
      ✓ should decrease Alice's balance to 13 RKT (101ms)
      ✓ should not produce a claimable rocket (112ms)
      ✓ should not impact Bob's ability to buy a new rocket (106ms)
      ✓ should not impact Bob's balance (10 RKT) (109ms)
      1 block after the transaction, Alice's rocket
        ✓ should not be claimable (118ms)
      5 blocks after the transaction, Alice's rocket
        ✓ should not be claimable (96ms)
      11 blocks after the transaction, Alice's rocket
        ✓ should be claimable (114ms)
        Alice claiming her rocket
          ✓ should make Alice able to buy a new rocket (106ms)
          ✓ should decrease Alice's balance of 6 RKT (7 RKT remaining) (111ms)
          ✓ should update Alice's number of rockets to 1 (107ms)
    Alice buying a rocket of size 14
      ✓ should make Alice unable to buy a new rocket (105ms)
      ✓ should decrease Alice's balance to 0 RKT (113ms)
      ✓ should not produce a claimable rocket (100ms)
      14 blocks after the transaction, Alice's rocket
        ✓ should be claimable (102ms)
        Alice claiming her rocket (with a RKT balance of 0)
          ✓ should return an invalid receipt

  RocketTokenClient Test Suite
    ✓ should have a valid syntax (99ms)
    Deploying an instance of the contract
      ✓ should initialize Alice's balance (20 RKT) (113ms)
      ✓ should initialize Bob's balance (10 RKT) (114ms)
      ✓ should initialize the total supply of RKT to 30 (101ms)
      ✓ should initialize Zoe's balance (0 RKT) (123ms)
    Alice transfering 5 RKT to Bob
      ✓ should decrease Alice's balance (15 RKT) (116ms)
      ✓ should increase Bob's balance (15 RKT) (110ms)
    Alice transfering -5 RKT to Bob
      ✓ should return an invalid receipt
      ✓ should not increase Alice's balance (15 RKT) (110ms)
      ✓ should not decrease Bob's balance (15 RKT) (120ms)
    Alice transfering 5 RKT to herself
      ✓ should return an invalid receipt
      ✓ should not increase Alice's balance (15 RKT) (106ms)
      ✓ should not decrease Bob's balance (15 RKT) (114ms)
    Bob transfering 16 RKT to Alice
      ✓ should return an invalid receipt
      ✓ should not increase Alice's balance (15 RKT) (108ms)
      ✓ should not decrease Bob's balance (15 RKT) (114ms)

@moxiegirl the package is shipped under the scope @blockstack.
@blockstack/clarity-tutorials would probably be less confusing than @blockstack/tutorials.
Is this causing an issue on your end?

@lgalabru nope, was just curious. We have repos called blockstack/blockstack-core which I find a bit redundant not to mention a pain to type, so I wanted to check we weren't doing that again here.


Documentation link gives 404

Is this a BUG REPORT or FEATURE REQUEST?:
bug
What happened:
The full documentation link in README.md goes to the 404 github page.
What you expected to happen:
To show the full documentation.
How to reproduce it (as minimally and precisely as possible):
Click in the full documentation link in README.md.
Anything else we need to know?:
No.
Environment:

Resumic version:
OS:  All
CLI version:
Others:

Thanks for reporting. I went ahead and removed the section from the README.
Once we have the schema and the first cli iteration done, docs should follow.
We are always happy for contributions, reviews or general feedback in the interim.


xml to json transformation

xml to json transformation and xml parsing api in scripts

Use xmltodict python library and use test scripts to update response.


fix: bold effect not working

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)
New or updated content
Translated content
Changes to the docs site code
Something else!

Description

Closes #
What does this PR change? Give us a brief description.
Did you change something visual? A before/after screenshot can be helpful.

Thanks, @djdeo, this looks great! Thanks for making your very first contribution, and welcome to Team Docs 🥳 🚀


Revert "[release-1.17] Operator: Fix webhooks reconciled by operator are inconsistent with istioctl install's"

Reverts istio/istio#45121
https://github.com/istio/istio/issues/45204

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio_release-1.17
6654156bd969d92e9be493ac2ee44f1cbb2378a7
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Next version bump

Description

add Form Input rails component and docs #244
add Expandable Card rails component and docs #240
add Meter rails component and docs #250
add Textarea component and docs #248
add Form Select component and docs #245
add Input Helper component and docs #252
add Data Card component and docs #239
fix overflow issue with Card and Card Highlight #254
fix dropdown panel positioning for fixed react dropdown #253
add Nav and NavLinks components and docs #231
add react component for Alert #256
fix boostrap style conflict in Toast #247

added a commit to update the elements_helper file. Meter update is missing

added a commit to update the elements_helper file. Meter update is missing


add TSL cert verify switch to support network env behind private TSL …

…gateway

Allow user to ignore TSL cert check when using hanlp_restful API
Description
When user is working in a network behind a gateway, which blocks / modifies the TSL certification, user need to add a cert file or ignore TSL cert check in order to user hanlp_restful API.
Fixes # (issue)
Type of Change
Please check any relevant options and delete the rest.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?

It is used including this modification in the really world use case and works fine.
It failed to pass unittest python -m unittest discover ./tests due to API access limit (2 times/min allowed only ~~)

Checklist
Check all items that apply.

[x] ⚠Changes must be made on dev branch instead of master
[ ] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[x] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings

The patch has been released at: https://pypi.org/project/hanlp-restful/0.0.19/


closes #751

Issue number
Relevant 751

Resolves #751

Please check the following

[x] Do the tests still pass? (see Run the Tests)
[x] Is the code formatted properly? (see Linting (Formatting))
For New Features:

[ ] Have tests been added to cover any new features or fixes?
[ ] Has the documentation been updated accordingly?

Please describe additional details for testing this change
Added What is Cuttle and Rules of Cuttle with the cuttle_rules.pdf

Got it. I'll make the changes