gatus: 5.12.1 -> 5.13.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/TwiN/gatus/releases.
meta.description for gatus is: Automated developer-oriented status page
meta.homepage for gatus is: https://gatus.io
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 5.13.0 in filename of file in /nix/store/735khn99ymd77js67syi4rlh2xxslwma-gatus-5.13.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

gatus

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/735khn99ymd77js67syi4rlh2xxslwma-gatus-5.13.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gatus https://github.com/r-ryantm/nixpkgs/archive/fc2523c75311e2c2d1fd3e8ccb1f872bd088486b.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/fc2523c75311e2c2d1fd3e8ccb1f872bd088486b#gatus

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/735khn99ymd77js67syi4rlh2xxslwma-gatus-5.13.0
ls -la /nix/store/735khn99ymd77js67syi4rlh2xxslwma-gatus-5.13.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

gatus

Maintainer pings
cc @undefined-moe for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge

@ofborg eval

eval looks green to me :+1:


Add workaround for the git 2.35.2 CVE to bud rebuild

See https://github.com/NixOS/nixpkgs/issues/169193

@Pacman99 Could you take a look at this? bud seems completely broken as is, unless I'm missing something.

There's also nix 2.8.1, which seems to address this (https://github.com/NixOS/nixpkgs/issues/169193#issuecomment-1126983114).


The clickHandlerFunc event does not take effect on the mobile terminal

Hi Matthew
Hope all is well.
I have a question, on mobile terminal, the clickHandlerFunc not work
my code is:
`"clickHandlerFunc": this.HotSpotClickHandler
HotSpotClickHandler (){
setTimeout(() => {
this.Pannellum.setHfov(90, 1500)
}, 1)
}
`
I use Vue framework, which can work normally in the web environment of PC, but it doesn't work on mobile terminal

This is a duplicate of the bug reported in #861. It was fixed in<PHONE_NUMBER>a27e61c9e1f0f656f8cef532abaa77, but the fix has not yet made it into a release.

Matthew, thank you for your reply
I imported the local JS file according to your reply, but the function still can't be executed.
The touchend event of the source code can be executed, but the hs.clickHandlerFunc (e,  hs.clickHandlerArgs ）; it doesn't seem to be implemented.
Because on the mobile terminal, I want to setHfov, but it still has no effect

I solved this problem,
Add a setTimeout timer to the touchend event in the source code


doc: Update TTS Plans info

Summary
Closes #1116
Closes #1188
Checklist

[x] Scope: The referenced issue is addressed, there are no unrelated changes.
[x] Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
[ ] New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
[x] Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
[ ] Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

Hey @adriansmares sorry for bugging, can you also check the last commit? I needed to add some password and downgrading info after you approved


[locale] Update bo locale

The monthsShort and weekdaysMin of bo locale is aligned with Unicode CLDR v32, see http://www.unicode.org/repos/cldr/tags/release-32-0-1/common/main/bo.xml.
cc @vajradog

The test failure is fixed on #4371. Will rebase after #4371 is merged.

Why is this test failing? Did it just start failing @JLHwung  ?

@marwahaha I ve updated the reason of test failure on #4371 and we can focus on locale revision on this PR.

@vajradog do you have any thoughts here?


Notification display error

Open to feedback and better testing #301

Hey @KcPele really thanks for this !! But currently at main its parses error correctly :
https://github.com/scaffold-eth/scaffold-eth-2/assets/80153681/9d7d1e12-5ea2-445f-81f8-80bbae1d14ea
But yeah I agree #301 is real because sometimes it does not parse it well its kind of hard to determine. Saying that we are currently working on #352 which hopefully will internally solve this issue checkout -> https://github.com/scaffold-eth/scaffold-eth-2/issues/301#issuecomment-1506215490
So closing this for now but we surely gonna come back at this if we face the same issue even after #352 🙌


Define custom fields in YAML

Current Behavior
When #39 is merged, we have a very rudimentary way to perform certain actions when launching the container.
Expected Behavior
It would be cool though if, instead of writing python code to import custom fields, a more general script existed which would would parse a yaml; a file I imagine to look like this:
custom_field_name:
  on_objects:
  - dcim.models.Device
  - dcim.models.DeviceType
  type: CF_TYPE_TEXT
  label: The Label
  description: The Description
  required: true
  filterable: true
  default: nil
  weight: 100
  choices:
  - value: Choice 1
    weight: 100

Here's a draft script: https://gist.github.com/cimnine/f3591d26ecc41111563ff26741669c6c
You need to adjust the script slightly to make it work with netbox_docker:
# old
with open('custom_fields.yml', 'r') as stream:

# new
with open('startup_scripts/custom_fields.yml', 'r') as stream:


K8S Auth Demo Updates

With the Kubernetes support merged into main, our demo notebooks should also reflect these changes with updated authentication usage/demonstrations, as the old auth methods have been deprecated.

Actually, if old notebooks are using TokenAuthentication, then there may be no changes necessary, will confirm


Name collisions are possible in snapshot (.chunks, .component)

Blob with this name
const chunksBlobName = ".chunks";

is written in the root of container runtime tree, thus in the same namespace as data stores.
If data store with such name is created, it will cause corruption of the tile.
We need to isolate namespace of special blobs and data stores.
I believe (need to check) same goes with .component blob and DDs.
Within DDSs I believe things are correct (as .attributes is not colliding with DDS blobs as they are under "content" sub-tree), but need to check

Closing this issue with PR #4485, because that PR allows for clients to read in the new format.
Opened another issue #4706 to track the work for writing in the new format. This must go in a release 2 versions later than the first to ensure compatibility requirements.

Closing this issue with PR #4485, because that PR allows for clients to read in the new format.
Opened another issue #4706 to track the work for writing in the new format. This must go in a release 2 versions later than the first to ensure compatibility requirements.


Add just as an installable cli tool

Description
Add just to arkade get
Motivation and Context

[X] I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required) #721

How Has This Been Tested?
Covered with unit tests, ran make e2e and with the usual shell script, see comments for output.
Are you a GitHub Sponsor yet (Yes/No?)

[ ] Yes
[X] No

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Documentation

[X] I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
[ ] I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

[X] I have tested this on arm, or have added code to prevent deployment

Manual test script output:


Feature Request: Option to display file if an image

This is a great plugin as-is. Have you considered adding the ability to display an image if that is the type of file selected?

Hi @mrlife,
First of all, thanks for using my plugin 👍
No I didn't thought about that, so you thought about adding a child element which display the images selected ?

Maybe @mrlife was thinking about something like http://www.jasny.net/bootstrap/components/#fileinput?


Avoid codecov spam

Current configuration of codecov does SPAM not only github user interface but also our inboxes.
This disables the codecov comment, but not the tool itself. The tool still runs and reports using check API, being visible like any other github action.
See: https://docs.codecov.io/docs/pull-request-comments

I think I explained previously that I find the codecov comment useful.


"SĂCELE" is listed in the drop-down menu

Description:
"SĂCELE" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "SĂCELE" in the search bar.
Expected results
The location is listed in the drop-down menu as "Oraș SĂCELE, BRAȘOV (SĂCELE)".


New coding standard

Usage of the newly introduced zendframework/zend-coding-standard for CS checks.

@Koopzington
Can you rebase and re-push, please?

Done!

@Koopzington
Thanks! 👍


[WIP] Generate individual certificates for k8s hosts

Depends on PR #818
Each host gets a specific certificate instead of shared certificates.

ci check this

Do not merge please w/o @adidenko 's approve


Created Accounts Tutorial

The Gist of an Accounts Component:

List all accounts associated with Polkadot{js}
Be able to convert those addresses to another address (Kusama, Stafi, Polkadot, etc)
List all addresses converted in component

If you're still in the ecosystem, can you try with a new version and refresh? 🙈

Out of date


Error When running Script: ValueError: input_shapeorbatch_input_shape` argument.

Hey I was trying to run your script and ran into a problem.

:: Lookup of 1000 ELMo representations. This takes a while ::
100%[==================================================]  1000/ 1000 sentences
:: Lookup of 1000 ELMo representations. This takes a while ::
100%[==================================================]  1000/ 1000 sentencesShape Train X: (1000, 100, 256)
Shape Test Y: (1000, 100, 256)
Traceback (most recent call last):
File "/Users/banana/PycharmProjects/MasterArbeit/MasterArbeit/ELMo.py", line 178, in
model.add(Conv1D(filters=250, kernel_size=3, padding='same')) #input_shape=(1000, 100, 1024)))
File "/usr/local/lib/python3.7/site-packages/keras/models.py", line 451, in add
raise ValueError('The first layer in a '
ValueError: The first layer in a Sequential model must get an input_shape or batch_input_shape argument.

What I've tried
# Simple model for sentence / document classification using CNN + global max pooling
model = Sequential()
model.add(Conv1D(filters=250, kernel_size=3, padding='same', input_shape=(1000, 100, 1024)))
model.add(GlobalMaxPooling1D())
model.add(Dense(250, activation='relu'))
model.add(Dense(1, activation='sigmoid'))

model.compile(loss='binary_crossentropy', optimizer='adam', metrics=['accuracy'])
model.fit(train_x, train_y, validation_data=(test_x, test_y), epochs=1, batch_size=32)

But it than trows me a different error. What is the needed Input_shape?
Best Regards

Not sure why you get this error, your first layer Conv1D specified an input_shape.
However, your error log shows that model.add(Conv1D(filters=250, kernel_size=3, padding='same'))
you did not specify the input_shape there.


feat(all): add IndoorLevelActivated and IndoorBuildingFocused

Did

[x] Android integration
[x] iOS integration
[x] Update demo
[x] Update readme

Limitations
I'm working on the demo validation, i've some problem with the install of old android version but it will be a good opportunity to learn :)

External ressources
Android Model:

IndoorLevel
IndoorBuilding

Android Listener:

GoogleMap.OnIndoorStateChangeListener

IOS Model:

GMSIndoorLevel
GMSIndoorBuilding

IOS Listener:

GMSIndoorDisplayDelegate

Nice!!

@nickolanack Yes, just finished i think, my PR is updated! ;)
Do you have some input on how i can test the demo that i updated ? I've problem when i try to run it :/

@dapriett @nickolanack
If you have some input i've problem running the demo test in local with tns run android
It could be better if i can run the demo to validate and finish this PR ;p
ERROR in ./main-page.js
Module not found: Error: Can't resolve 'nativescript-google-maps-sdk' in '/home/fjnr/WebstormProjects/nativescript-google-maps-sdk/demo/app'
 @ ./main-page.js 3:17-56
 @ ./bundle-config.js
 @ ./app.js

ERROR in ./main-page.xml
Module not found: Error: Can't resolve 'nativescript-google-maps-sdk' in '/home/fjnr/WebstormProjects/nativescript-google-maps-sdk/demo/app'
 @ ./main-page.xml 1:74-113 1:200-239 1:318-357 1:444-483 1:562-601 1:707-746 1:825-864 1:970-1009 1:1088-1127 1:1234-1273 1:1352-1391 1:1498-1537
 @ . sync (?<!\bApp_Resources\b.*)\.(xml|css|js|(?<!\.d\.)ts|(?<!\b_[\w-]*\.)scss)$
 @ ./app.js

Webpack compilation complete. Watching for file changes.
Webpack build done!
Project successfully prepared (android)
File change detected. Starting incremental webpack compilation...
Successfully transferred runtime.js on device emulator-5554.
Restarting application on device emulator-5554...
Webpack compilation complete. Watching for file changes.
Webpack build done!
File change detected. Starting incremental webpack compilation...
JS: HMR: Hot Module Replacement Enabled. Waiting for signal.
Webpack compilation complete. Watching for file changes.
Webpack build done!
System.err: An uncaught Exception occurred on "main" thread.
System.err: Unable to start activity ComponentInfo{org.nativescript.demo/com.tns.NativeScriptActivity}: com.tns.NativeScriptException: Calling js method onCreate failed
System.err: Error: Cannot find module 'nativescript-google-maps-sdk'
System.err:
System.err: StackTrace:
System.err: java.lang.RuntimeException: Unable to start activity ComponentInfo{org.nativescript.demo/com.tns.NativeScriptActivity}: com.tns.NativeScriptException: Calling js method onCreate failed
System.err: Error: Cannot find module 'nativescript-google-maps-sdk'
System.err:     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2913)
System.err:     at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3048)
System.err:     at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:78)
System.err:     at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
System.err:     at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
System.err:     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1808)
System.err:     at android.os.Handler.dispatchMessage(Handler.java:106)
System.err:     at android.os.Looper.loop(Looper.java:193)
System.err:     at android.app.ActivityThread.main(ActivityThread.java:6669)
System.err:     at java.lang.reflect.Method.invoke(Native Method)
System.err:     at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
System.err:     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
System.err: Caused by: com.tns.NativeScriptException: Calling js method onCreate failed
System.err: Error: Cannot find module 'nativescript-google-maps-sdk'
System.err:     at com.tns.Runtime.callJSMethodNative(Native Method)
System.err:     at com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1242)
System.err:     at com.tns.Runtime.callJSMethodImpl(Runtime.java:1122)
System.err:     at com.tns.Runtime.callJSMethod(Runtime.java:1109)
System.err:     at com.tns.Runtime.callJSMethod(Runtime.java:1089)
System.err:     at com.tns.Runtime.callJSMethod(Runtime.java:1081)
System.err:     at com.tns.NativeScriptActivity.onCreate(NativeScriptActivity.java:19)
System.err:     at android.app.Activity.performCreate(Activity.java:7136)
System.err:     at android.app.Activity.performCreate(Activity.java:7127)
System.err:     at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1271)
System.err:     at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2893)
System.err:     ... 11 more
Successfully synced application org.nativescript.demo on device emulator-5554.

Here is the process i followed (My android studio emulator is already launched):
cd demo/
npm install
tns run android

If you could help me on this i will update the documentation to explain how to contribute on the project after.

cd ../src/
npm run build
npm run plugin.link
cd ../demo
tns debug android

Thanks a lot @nickolanack !
I've been able to test it and change a lot of things for compatibility between iOS and Android.
I've a first base that can return something like this:
JS: Building focus changed: {"defaultLevelIndex":2,"levels":[],"isUnderground":false}

Unfortunatly i have a problem with levels since i don't find a way to correctly work with the differente implementation of Array (nsArray, Java array and JS array). I've updated my PR with my current best solution, but i will try to continue tomorrow morning.
If you have some input on this type of problem feel free, it should be the last thing to finish this PR

for android (java.util.List) use:
...getLevels().size()
...getLevels().get(count)

oh, I think IOS needs to have this.nativeView.indoorDisplay.delegate set to a IndoorDisplayDelegateImpl.initWithOwner.... somewhere

oh, I think IOS needs to have this.nativeView.indoorDisplay.delegate set to a IndoorDisplayDelegateImpl.initWithOwner(new WeakRef(this)) somewhere
works perfectly for me after that.!+1

Yes, you right! I based my work on the existing MapViewDelegateImpl but in my case i've no IndoorDisplay or IndoorDisplayBase in the base code and i don't see exactly how it need to turn out for the moment.
I think that we need to create these classes, but i don't see how and i've no iOS for test it :/

@nickolanack It seems that we never get the final onIndoorLevelActivated. I tried it with multiple building in Montreal and i just for the onIndoorBuildingFocused.

@RignonNoel i PR'd (into feature-new_events of your fork ) the corrected ios delegate instantiation, and fixed level selection event. 🙀 I was wondering what would happen/(if it was possible) to pr into an already open pr...

@nickolanack Wow! You're the man! Thanks a lot for the iOS side.
And thanks a lot more again for the android quick fix, seems that i was not able to read my own stupid error :stuck_out_tongue_closed_eyes:

np👍

Tested on my side for Android, seems ready to merged @dapriett if you're ok


Meson build system support

Any chance to support meson build system as subproject or pull request with this is approve in master in future?

Having to support another build system doesn't feel me with joy, but Meson seems to be somewhat popular. How complex is the minimal setup that makes Luau usable? Does Meson allow to use file globs? (this would simplify maintenance of a build system we don't use for future changes)

Having to support another build system doesn't fill me with joy

CI/CD may check and start unittest in meson for ensure stable of Meson builds.

How complex is the minimal setup that makes Luau usable?

You may meet with example with classic Lua meson build system at
https://github.com/franko/lua/blob/master/src/meson.build
But this example is overloaded by using pkgconfig and separated an few parts and etc.
The main purpose of use Meson build (is providing library as a subproject) is not achieved in example.
I can make and check MVP with meson for Debian system (maybe in December).

Does Meson allow to use file globs?

This is violation of reliability and describe at https://mesonbuild.com/FAQ.html#but-i-really-want-to-use-wildcards
But Meson provide workaround for stubborn developers.
P.S. I think that the main goal using Meson is to provide the ability to embed Luau as easily as it is done with Lua, so that user would not even notice the changes from one to the other, but get significant advantages. For example with use:
//lua_dep = dependency('lua', method : 'pkg-config')
luau_dep = dependency('luau', method : 'pkg-config')

or as subproject with source code recompile:
luau_proj = subproject('libsimple')
luau_dep = luau_proj.get_variable('luau_dep')

For this last code in meson should be:
inc = include_directories('include')
libluau = static_library('luau', sources
  include_directories : inc,
  ....
)

luau_dep = declare_dependency(
   include_directories : inc,
  link_with : libluau)


Control flow utilities

I've added them in bau.js but currently not written any tests or modified the doc yet. Probably you can open a side branch to have this WIP feature

supersede by https://github.com/grucloud/bau/pull/46


Fixes for some Lua bugs

Here are the changes I could make without messing up a lot of stuff. Most of the bugs are fixed. The main one had to do with using relative lua stack indices in GetArgument_* functions. Almost all of the other ones were in Lua files.

Great! So fast! Many thanks for the update! :D


Include Jupyterbook documentation testing in the azure-doctest-awkward.yml

It's important to get a red flag when
jupyter-book build docs-src

fails. While we're at it, maybe find out why the sidebar now consists of expandable pull-down menus:

I'd rather see them fully expanded:

I know it's because I have an older version of Jupyterbook on my computer, but if the name of the option has changed, I'd like to update to that new name. It used to be
  expand_sections: true

in each item.

I think this was fixed (imperfectly). And anyway, the documentation system should be simplified in such a way that we don't have this issue.


feature: Implement stream mode as a new download and upload method

Ⅰ. Describe what this PR did
The main work is to implement the P2P stream mode in supernode side. To summarize, the streaming download process in supernode could be cateloged into two sections.

Maintain the sliding window in supernode.

Initialize: The size of window will be registered in the dfget task registration phrase. And then, the window state is recorded in the ProgressManager as the SyncMap indexed by ClientID. The size of window is staic once it is recorded by supernode.
Update: The dfget client will report to the supernode about the result of downloading for every piece. In the report API of supernode server, the window will be updated based on the received piece number and piece status. To be specific, the window keeps sliding until the unacknowledged piece. It should be noted that the supernode is using the sender window, which has the range of [una, una + wnd) .
Finish: Update the DeleteCID method of ProgressManager to delete the sliding window state if it is in stream mode.

Schedule the pieces according to the window state
The only modification that I made in this part lies at the GetPieceProgressByCID method of ProgressManager. The available pieces in regular mode means the success pieces which are not running; while for the stream mode, the available pieces means the cached pieces which are not running. After the modification, the ProgressManager would only return the available pieces inside the window when stream mode is on.
A new kind of piece status is created: UNCACHED. When the piece is downloaded successfully, I assume that it will sotred into the cache immediately. Afterwards, the piece maybe popped out of the cache. And in this case, the handler of supernode server deletePieceCache at supernode/server/router.go:101 would be called to change the state of the piece.
It should be noted that, the scheduler in stream mode currently uses the same scheduler as the regular mode, which may demands future optimization.

Besides the above modifications, I also add two APIs in supernode server, which are addPieceCache and deletePieceCache. The dfget client calls these APIs to notify the supernode about the state of cache.
Ⅱ. Does this pull request fix one issue?

This PR is related to #1436 #1164.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
The unit tests have been added.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1447 into master will decrease coverage by 0.34%.
The diff coverage is 43.30%.

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
- Coverage   52.29%   51.95%   -0.35%
==========================================
  Files         136      138       +2
  Lines        9134     9506     +372
==========================================
+ Hits         4777     4939     +162
- Misses       3972     4170     +198
- Partials      385      397      +12

Impacted Files
Coverage Δ

dfdaemon/seed/downloader.go
70.21% <0.00%> (ø)

dfget/config/config.go
89.28% <ø> (ø)

dfget/core/api/download_api.go
29.54% <0.00%> (-0.69%)
:arrow_down:

dfget/core/api/uploader_api.go
0.00% <0.00%> (ø)

dfget/core/core.go
39.44% <0.00%> (-4.89%)
:arrow_down:

dfget/core/uploader/uploader.go
88.03% <ø> (ø)

dfget/types/register_request.go
0.00% <ø> (ø)

supernode/daemon/mgr/progress/progress_delete.go
0.00% <0.00%> (ø)

supernode/daemon/mgr/task/manager.go
27.73% <0.00%> (-0.84%)
:arrow_down:

supernode/server/0.3_bridge.go
0.00% <0.00%> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4906cd1...b250fb6. Read the comment docs.

The stream mode is fullfilled with three more perpectives, which are DFGET downloader, DFGET uploader, and the IPC between user and DFGET.
DFGET Downloader
Since the client stream writer has been implemented under the p2p_downloader folder, which means that the pieces downloading process has been finished. My work here is to fullfill the task of handling the successfully downloaded pieces to uploader. Besides that, in the perparation phase at dfget/core/core.go:171, the registration of stream task is necessary for uploader. Here are all the modifications:

dfget/core/core.go:210: The  doDownload method is refactored. One new interface is defined as DownloadTimeoutTask. The interface has two implementations, which are regular downloader and the stream downloader.

dfget/core/downloader/downloader.go:79: The Start() method of the StreamDownloadTimeoutTask struct will call the RunStream method of the downloader, and then pass the stream reader to the startWriter method.

dfget/core/downloader/downloader_util.go:55: The startWriter method is used to fetch the pieces from the stream reader concurrently, and then upload the pieces to uploader in order. The logic of the startWriter is referenced from the stream downloading method in CDN manager at supernode/daemon/mgr/cdn/super_writer.go:59.
The unit test has been added.

DEGET Uploader
The previous uploader is solely used for the regular downloading method. For the stream uploader, I have added new APIs for it. Apart from that, the cache manager is added to manage the cache pieces.

dfget/core/api/supernode_api.go:359: A new kind of updating piece status API has been implemented. It is used to change the peice status from SUCCESSFUL to UNCACHED.

dfget/core/api/uploader_api.go:108: The uploader API RegisterStreamTask is added to register the stream task at cache manager. The initialization of the according entry at cache manager is finshed after the call.

dfget/core/api/uploader_api.go:127: The uploader API DeliverPieceToUploader is used to handle the piece from downloader to uploader.

dfget/core/uploader/cache.go:60: The FIFO cache manager is created to control the piece caches. It would store and pop the piece in the style of FIFO. It should be noted that the cache manager is using the sender window, which has the range of [start, una).
The unit test has been added.

IPC Between DFGET and User
This part demands further discussion. Currently, I propose that the DFGET can directly output the content of the pieces to stdout, and then the user who calls the DFGET command, can redirect the stdout of the DFGET command to the write side of the pipe by generally supported method popen.
After that, the user can directly read from the pipe, and get the successfully downloaded content. Since the method uses the unnamed pipe, the whole process is not related with the file system.

@garfield009 @ansinlee @Starnop PTAL

Not clear what problem the PR solves. Performance? Better rate limiting? or else ?


update .gitignore to ignore .toml

Prevent accidental .toml checkins for fly.io deploys!

Codecov Report

Merging #1404 (50976ac) into main (331c8e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1404   +/-   ##
=======================================
  Coverage   48.66%   48.66%
=======================================
  Files         294      294
  Lines       16576    16576
=======================================
  Hits         8066     8066
  Misses       8510     8510

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

i am not sure about this ignore, maybe only add the fly.toml only, because what about pyproject.toml you could probably exclude that also? imho this first is better.


Fix the issue of adding aerospace-logo

Description
This PR fixes # Added aerospace-logo
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

Duplicate of #449


Running balance not displaying for any account

Defective ToolKit Feature Name:
Expected Behavior
Running balance to show in individual accounts - not All Accounts
Actual Behavior
None of my accounts show a running balance
Steps to Reproduce the Behavior

Open any account

Export of Toolkit Settings (Bottom Left of Settings Page)
[{"key":"AutoCloseReconcile","value":false},{"key":"CustomFlagNames","value":false},{"key":"DisplayTargetGoalAmount","value":false},{"key":"HideReferralBanner","value":false},{"key":"RunningBalance","value":true},{"key":"ShowCategoryBalance","value":true},{"key":"StealingFromFuture","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"accountTransactionSearch","value":true},{"key":"accountsClearSelection","value":true},{"key":"accountsDisplayDensity","value":"0"},{"key":"accountsEmphasizedOutflows","value":true},{"key":"accountsRowHeight","value":"1"},{"key":"accountsSelectedTotal","value":true},{"key":"accountsStripedRows","value":true},{"key":"activityTransactionLink","value":true},{"key":"betterScrollbars","value":"1"},{"key":"budgetBalanceToZero","value":true},{"key":"budgetProgressBars","value":"0"},{"key":"budgetQuickSwitch","value":false},{"key":"budgetRowsHeight","value":"0"},{"key":"calendarFirstDay","value":"0"},{"key":"categoryActivityPopupWidth","value":"0"},{"key":"changeEnterBehavior","value":true},{"key":"checkCreditBalances","value":false},{"key":"checkNumbers","value":false},{"key":"closeReconcileWindow","value":false},{"key":"collapseExpandBudgetGroups","value":true},{"key":"collapseSideMenu","value":true},{"key":"colourBlindMode","value":false},{"key":"compactIncomeVsExpense","value":false},{"key":"currentMonthIndicator","value":true},{"key":"daysOfBuffering","value":false},{"key":"daysOfBufferingHistoryLookup","value":"0"},{"key":"editButtonPosition","value":"1"},{"key":"enableRetroCalculator","value":false},{"key":"enlargeCategoriesDropdown","value":true},{"key":"enterInRegisterNow","value":true},{"key":"exportTransactions","value":true},{"key":"goalIndicator","value":false},{"key":"goalIndicatorWarningColor","value":false},{"key":"googleFontsSelector","value":"0"},{"key":"hideAOM","value":true},{"key":"hideAccountBalancesType","value":"0"},{"key":"hideHelp","value":true},{"key":"highlightNegativesNegative","value":true},{"key":"importNotification","value":"1"},{"key":"incomeFromLastMonth","value":"0"},{"key":"l10n","value":"0"},{"key":"largerClickableIcons","value":false},{"key":"monthlyNotesPopupWidth","value":"0"},{"key":"navDisplayDensity","value":"0"},{"key":"pacing","value":"0"},{"key":"popupCalculator","value":true},{"key":"printingImprovements","value":true},{"key":"privacyMode","value":"0"},{"key":"reconciledTextColor","value":"0"},{"key":"removePositiveHighlight","value":true},{"key":"removeZeroCategories","value":true},{"key":"reports","value":true},{"key":"resizeInspector","value":true},{"key":"rightClickToEdit","value":true},{"key":"runningBalance","value":true},{"key":"seamlessBudgetHeader","value":true},{"key":"showIntercom","value":false},{"key":"spareChange","value":false},{"key":"splitKeyboardShortcut","value":true},{"key":"splitTransactionAutoAdjust","value":true},{"key":"squareNegativeMode","value":false},{"key":"stealingFromNextMonth","value":false},{"key":"swapClearedFlagged","value":true},{"key":"toBeBudgetedWarning","value":true},{"key":"toggleSplits","value":true},{"key":"toggleTransactionFilters","value":"1"},{"key":"warnOnQuickBudget","value":false}]

System Settings
ToolKit Version:1.0.2
Operating System (Mac/Windows/Etc): Chrome
Browser (Chrome/Firefox/Safari): Chrome
Browser Version:
Other Extensions:

having the same issue

are you on osx or windows?

on chrome os, but never had this issue before.
[{"key":"AutoCloseReconcile","value":false},{"key":"CustomFlagNames","value":false},{"key":"DisplayTargetGoalAmount","value":false},{"key":"HideReferralBanner","value":false},{"key":"RunningBalance","value":true},{"key":"ShowCategoryBalance","value":false},{"key":"StealingFromFuture","value":false},{"key":"TargetBalanceWarning","value":false},{"key":"accountsClearSelection","value":false},{"key":"accountsDisplayDensity","value":"0"},{"key":"accountsEmphasizedOutflows","value":false},{"key":"accountsRowHeight","value":"1"},{"key":"accountsStripedRows","value":true},{"key":"activityTransactionLink","value":true},{"key":"betterScrollbars","value":"0"},{"key":"budgetBalanceToZero","value":true},{"key":"budgetProgressBars","value":"0"},{"key":"budgetQuickSwitch","value":false},{"key":"budgetRowsHeight","value":"0"},{"key":"calendarFirstDay","value":"0"},{"key":"categoryActivityPopupWidth","value":"0"},{"key":"changeEnterBehavior","value":true},{"key":"checkCreditBalances","value":true},{"key":"checkNumbers","value":false},{"key":"closeReconcileWindow","value":false},{"key":"collapseExpandBudgetGroups","value":false},{"key":"collapseSideMenu","value":true},{"key":"colourBlindMode","value":false},{"key":"compactIncomeVsExpense","value":false},{"key":"currentMonthIndicator","value":false},{"key":"daysOfBuffering","value":false},{"key":"daysOfBufferingHistoryLookup","value":"0"},{"key":"editButtonPosition","value":"0"},{"key":"enableRetroCalculator","value":true},{"key":"enlargeCategoriesDropdown","value":true},{"key":"exportTransactions","value":false},{"key":"goalIndicator","value":false},{"key":"goalIndicatorWarningColor","value":false},{"key":"googleFontsSelector","value":"0"},{"key":"hideAOM","value":true},{"key":"hideAccountBalancesType","value":"0"},{"key":"hideHelp","value":true},{"key":"highlightNegativesNegative","value":false},{"key":"importNotification","value":"1"},{"key":"incomeFromLastMonth","value":"0"},{"key":"l10n","value":"0"},{"key":"largerClickableIcons","value":true},{"key":"monthlyNotesPopupWidth","value":"0"},{"key":"navDisplayDensity","value":"0"},{"key":"pacing","value":"0"},{"key":"popupCalculator","value":true},{"key":"printingImprovements","value":true},{"key":"privacyMode","value":"0"},{"key":"reconciledTextColor","value":"0"},{"key":"removePositiveHighlight","value":false},{"key":"removeZeroCategories","value":false},{"key":"reports","value":true},{"key":"resizeInspector","value":true},{"key":"rightClickToEdit","value":true},{"key":"runningBalance","value":true},{"key":"seamlessBudgetHeader","value":false},{"key":"showIntercom","value":true},{"key":"spareChange","value":false},{"key":"splitKeyboardShortcut","value":true},{"key":"splitTransactionAutoAdjust","value":true},{"key":"squareNegativeMode","value":false},{"key":"stealingFromNextMonth","value":false},{"key":"swapClearedFlagged","value":false},{"key":"toBeBudgetedWarning","value":false},{"key":"toggleSplits","value":true},{"key":"toggleTransactionFilters","value":"0"},{"key":"warnOnQuickBudget","value":false}]

Ah I think there is another ticket open about chrome os. Toolkit appears to be broken completely for that.
@marper2017 are you on chrome os too?

does that ticket have a thread? could you point me to it?

Yep #776

Yes I am also on Chrome i.e. chrome book. Thought I had out that on my ticket. Sorry if I missed that.
Sent from my iPhone

On Jul 2, 2017, at 10:28 PM, Josh Madewell<EMAIL_ADDRESS>wrote:
Ah I think there is another ticket open about chrome os. Toolkit appears to be broken completely for that.
@Marper2017 are you on chrome os too?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I am not getting any error message about corruption as referenced in the other ticket. All the other settings are working from what I can tell-the running balance is the only one that has stopped working as it has worked in the past.
Sent from my iPhone

On Jul 2, 2017, at 10:52 PM, Josh Madewell<EMAIL_ADDRESS>wrote:
Yep #776
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Confirming that it does appear to be a Chromebook issue - just pulled up on my work windows laptop and running balance is there with same settings..

Quick correction - there are other settings not working - but most are.. so
based on link to other issue that there are problems with Chrome OS feel
free to close the ticket although would be interested if the chrome os
issue will be looked into.
Thanks!
Kim
On Mon, Jul 3, 2017 at 6:01 AM, Kim Smith<EMAIL_ADDRESS>wrote:

I am not getting any error message about corruption as referenced in the
other ticket. All the other settings are working from what I can tell-the
running balance is the only one that has stopped working as it has worked
in the past.
Sent from my iPhone
On Jul 2, 2017, at 10:52 PM, Josh Madewell<EMAIL_ADDRESS>wrote:
Yep #776 https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/776
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/838#issuecomment-312544032,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcdUECpsmp3ACOONQ86efS8m5uVAsiVfks5sKGVygaJpZM4OLoWT
.

I'm not sure if any of the toolkit devs have a chrome os system but I might be able to spin up a virtual machine to take a look at this when I find time.
I will close this issue for now in favor of #776

Thanks Josh - no worries about chrome os - thanks for the follow-up!
Thanks!
Kim
On Mon, Jul 3, 2017 at 1:55 PM, Josh Madewell<EMAIL_ADDRESS>wrote:

Closed #838
https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/838.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/toolkit-for-ynab/toolkit-for-ynab/issues/838#event-1148586625,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcdUEEUx1v-RtjX92ki0w0BHgciDLICIks5sKTk5gaJpZM4OLoWT
.


Update unstructured document loaders

Description:

Updated unstructured file loader with latest API changes
Update unstructured folder loader with latest API changes
Updated S3File loader with latest unstructured API changes
Updated S3File loader to use new region lookup method
Update S3File loader to use updated credential function
Added support for ocrLanguages but should be updated to be just languages once langchain unstructured gets an updated

Note:
Unstructured folder loader currently doesn't work with different file types like .png and .heic due to problems with their API. This is in progress for future releases.
Also, I would like to add S3Folder loader but I'll do that in a separate PR since langchainjs doesn't support it yet and I'll have to go direct to the sdk.
Issues this addresses:

#1409
#780

Thanks @QuinnGT this is so good!
There's a few other parameters we can add in future:

multiPageSections
combineUnderNChars
newAfterNChars
maxCharacters

Thank you! I completely agree. Looking forward to the langchain upgrade so we can bring those additional params in.

Thank you! I completely agree. Looking forward to the langchain upgrade so we can bring those additional params in.

merged!

Busy today but plan on adding the rest of those params tonight (utc-7).
On Sat, Apr 20, 2024 at 1:25 PM Henry Heng @.***> wrote:

@.**** approved this pull request.
looks good! are you still planning to add more changes or is it good to
merge @QuinnGT https://github.com/QuinnGT ?
—
Reply to this email directly, view it on GitHub
https://github.com/FlowiseAI/Flowise/pull/2213#pullrequestreview-2013144168,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKSH3R3P3IRXI5QRKAN2IT3Y6LFKNAVCNFSM6AAAAABGOPYZIWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMJTGE2DIMJWHA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hey @HenryHengZJ take a look at the latest changes. Just tested on multiple docs, fixed some errors, and got it stable.

Hey @HenryHengZJ take a look at the latest changes. Just tested on multiple docs, fixed some errors, and got it stable.

awesome thank you so much!


change err name, add rankorder example, import @turbo

Hey,
I had a bit of fun with Isoplot (good work!), and made a few changes. Feel free to accept or not the pull request.
I had an error while testing the repo, and it was due to a conflict between LoopVectorization and VectorizedStatistics in the Yorkfit with vsum. So I am just importing @ turbo from LoopVectorization in the main module now, that solved the issue.
Also, I had a conflict with the name err with Base.Exception in Julia. I've renamed the function σ1 and propagated the changes. it shows that you expect σ1 as an input from the user so I think it is a good name, but tell me if you think otherwise.
Finally, I've added in demo.jl a very short example of rankorder plot because I struggled a bit to figure out how it works with variables like analyses (there is only an example in test.jl with fake data to my knowledge).

@ mentions in commits and issues ping users, consider escaping them

@ mentions in commits and issues ping users, consider escaping them

oops, sorry for that!

Thanks for the PR! How about maybe sigma instead of σ1?

(I originally chose val and err based on the field names in Measurements.jl that they access, but sigma would technically be more accurate so I'd be fine with that change, we'll just have to make it a breaking release)

The other other option would be to just not export val and err
I think I might be missing where the conflict with Base.Exception is though -- there's Base.error but that's different?

The other other option would be to just not export val and err
I think I might be missing where the conflict with Base.Exception is though -- there's Base.error but that's different?

I actually don't know. When I am importing Isoplot, I have this message:
using Isoplot
WARNING: using Isoplot.err in module Main conflicts with an existing identifier.

And when I use help for err, I only get this:
No documentation found.

  err is of type Base.ExceptionStack.

  Summary
  ≡≡≡≡≡≡≡≡≡

  struct Base.ExceptionStack

and @ which err only show Main.
I would still wish for exporting sigma (or whatever its name) because I found it quite useful to plot with rankorder_plot for example. The problem with sigma is that it is also the name you use for the Metropolis algorithm (and in the test)

Otherwise, yeah, maybe there is not need to export it. People can use uncertainty() and value() from Measurements. Maybe reexporting these methods?

Ah that warning could (?) just be that you’ve previously run code in that same REPL that happened to define a variable called err (like in a try-catch block perhaps?)
Unexporting seems good for now -- want to update the PR to do that and then I'll merge it?
I'm not sure what's causing the code coverage regression, but doesn't seem like anything you did

Mmh,

Ah that warning could (?) just be that you’ve previously run code in that same REPL that happened to define a variable called err (like in a try-catch block perhaps?)
Unexporting seems good for now -- want to update the PR to do that and then I'll merge it?
I'm not sure what's causing the code coverage regression, but doesn't seem like anything you did

Mmh, I don't know I just did it in a fresh REPL and I have the same thing. I don't see anything in my startup.jl file that could also be responsable for that.. But if you don't have the same problem, it definitely comes from me. Anyway, I've reverted the changes so I guess it is ready to merge! Thx for your time

Any time, thanks for PRing!


last version does not clearly states dependency to ordereddict in python 2.6

Can we put this in setup.py or avoid failing at least. This is a regression for python 2.6.

Some help on that:
https://wheel.readthedocs.io/en/latest/#defining-conditional-dependencies

For now, shyaml doesn't support 2.6, and I'm not sure anybody want that.


Updated deploy workflow for PR preview

Summary of Changes
Updated deploy workflow for PR preview.
Related Issue
Closes #91
Checklist

[x] I have read and followed the project's contribution guidelines, including code style and commit message conventions.
[x] My code is well-documented, and I've updated relevant documentation.
[x] I have added or updated test cases to ensure the code's functionality.
[x] I have tested these changes on my local environment.
[x] All tests pass, and there are no new linting errors.
[x] I have reviewed and proofread my code and the changes.
[x] The branch is up-to-date with the base branch.

Reviewer(s)
@Abhijay007

It looks like this might be causing an error...
Run if [ "pull_request" == "pull_request" ]; then
yarn run v1.22.21
$ docusaurus build --basepath /pr-150
error: unknown option '--basepath'
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

Hi @hexsecs I think no file change was pushed earlier. Now I have pushed the updated code. Can you check it now?

Hi @hexsecs, It seems that pull bot is forcibly changing my PR to delete all the changes.

I checked for the cause of my changes getting force deleted by a bot. It was due to an unconfigured pull bot installed from my side. I have rectified it. I will push the new changes soon.


Serialization error causing 400 Bad Request with GitHub API

What are you generating using Kiota, clients or plugins?
API Client/SDK
In what context or format are you using Kiota?
Nuget tool
Client library/SDK language
Go
Describe the bug
I am trying to call client.Repos().ByOwnerId("my-owner-id").ByRepoId("my-repo-id").Properties().Values().Patch(context.Background(), patchRequestBody, nil) with Kiota version 1.14.0+fc4b39c65d89f7bfc8c7f1813c197e95e206da09.
Alternately, this can be reproduced using<EMAIL_ADDRESS>The serialized payload going out looks like:
"{\"properties\":[{\"property_name\":\"environment\",\"value\":\"test-from-go-sdk\"}]}"

and returns a 400 Bad Request error.
Expected behavior
I expect a 200 to come back from the API. Using the equivalent curl request:
curl -L   -X PATCH   -H "Accept: application/vnd.github+json"   -H "Authorization: Bearer $GITHUB_TOKEN"   -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/$OWNER_ID/$REPO_ID/properties/values -d '{"properties":[{"property_name":"environment","value":"test-from-curl"}]}'

The request is successful, no output is returned, and repository custom properties are updated.
How to reproduce

Follow this guide to set a custom property for your organization.
Ensure that the above curl snippet works successfully to set it for your repository, and you can view the property changing in the UI in repository settings --> repository sidebar --> custom properties
Clone octokit/go-sdk and replace the contents of cmd/token-example/main.go with the following:

package main

import (
	"context"
	"log"
        "os"
	"time"

	"github.com/octokit/go-sdk/pkg"
	"github.com/octokit/go-sdk/pkg/github/models"
	"github.com/octokit/go-sdk/pkg/github/repos"
)

func main() {
	client, err := pkg.NewApiClient(
		pkg.WithUserAgent("my-user-agent"),
		pkg.WithRequestTimeout(5*time.Second),
		pkg.WithBaseUrl("https://api.github.com"),
		pkg.WithTokenAuthentication(os.Getenv("GITHUB_TOKEN")),
	)

	if err != nil {
		log.Fatalf("error creating client: %v", err)
	}

	customPropertyValue := models.NewCustomPropertyValue()
	propertyName := "environment"
	propertyValue := "test-from-go-sdk"

	customPropertyValue.SetPropertyName(&propertyName)
	value := models.NewCustomPropertyValue_CustomPropertyValue_value()
	value.SetString(&propertyValue)
	customPropertyValue.SetValue(value)

	patchRequestBody := repos.NewItemItemPropertiesValuesPatchRequestBody()
	patchRequestBody.SetProperties([]models.CustomPropertyValueable{customPropertyValue})

	err = client.Repos().ByOwnerId("kfcampbell-terraform-provider").ByRepoId("tf-acc-test-destroy-trfiz").
		Properties().Values().Patch(context.Background(), patchRequestBody, nil)
	if err != nil {
		log.Fatalf("error setting custom properties: %v", err)
	}
}

Replace the OwnerId and RepoId values with your organization and repository values. Export a GITHUB_TOKEN with appropriate permissions.
Run go run cmd/token-example/main.go and see the request return a 400 error. Debug for more information.

Open API description file
https://raw.githubusercontent.com/github/rest-api-description/main/descriptions/api.github.com/api.github.com.json
Kiota Version
1.14.0+fc4b39c65d89f7bfc8c7f1813c197e95e206da09
Latest Kiota version known to work for scenario above?(Not required)
No response
Known Workarounds
N/A
Configuration
N/A
Debug output
N/A
Other information
It might be a red herring, but the request that Kiota sends out is:
"{\"properties\":[{\"property_name\":\"environment\",\"value\":\"test-from-go-sdk\"}]}"

and a successful request in curl looks like:
'{"properties":[{"property_name":"environment","value":"test-from-curl"}]}'
I'm not sure if the quotes and/or backslashes make a difference when serializing/sending the information to the API, but it's worth thinking about.

Well, I'm not positive, but I think that may be the problem. I could be leading you on a bit of a wild goose chase here, but let's talk about it. Pasting the Kiota-given payload (with escapes) into the otherwise successful curl request, like:
 sh$ curl -L -v  -X PATCH   -H "Accept: application/vnd.github+json"   -H "Authorization: Bearer $GITHUB_TOKEN"   -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/$OWNER_ID/$REPO_ID/properties/values -d '"{\"properties\":[{\"property_name\":\"environment\",\"value\":\"test-from-go-sdk\"}]}'

gives a 422 instead of the 400 I'm seeing through the SDK:
{
  "message": "Invalid request.\n\nInvalid input: data cannot be null.",
  "documentation_url": "https://docs.github.com/rest/repos/custom-properties#create-or-update-custom-property-values-for-a-repository",
  "status": "422"
}

Which is not intuitive to me: I'd expect to see a 400 here like we're seeing in the SDK. However, simply removing all the backslashes from the curl command makes the request 204 as we'd expect.
I'm unable to do the reverse (remove the backslashes from the outgoing request while debugging the SDK) as the kiota-abstractions-go.RequestInformation type doesn't seem to allow editing in the debugger:

Do you have thoughts on how I might troubleshoot this further?

I'm not saying the presence of backslashes is impossible, but I'd be surprised for it to be the case since we have thousands of applications using the Microsoft Graph Go SDK in production for over a year now. I suspect if we had an issue along those lines, it'd have come up already.

Hmm...do you have any idea of what else might be the cause of the 400 Bad Request in that case?

Alright, so if I update your sample by replacing the call to the API by
        // and adding this import kjson "github.com/microsoft/kiota-abstractions-go/serialization"
        serializedValue, err := kjson.SerializeToJson(patchRequestBody)
	if err != nil {
		log.Fatalf("error serializing request body: %v", err)
	}
	strSerValue := string(serializedValue)
	log.Printf("serialized request body: %v", strSerValue)

I get {"properties":[{"property_name":"environment","value":"test-from-curl"}]} which is strictly identical in structure to the curl value AND does not contain any escaping of the double quotes as expected.

This one sent me down a rabbit hole...
It's caused because the target API does not support Content-Encoding: gzip for the request body AND does not return a 415 status code when it receives encoded payloads....
Hardcoding the client.go client initialization to this fixed the issue.
// GetDefaultClientOptions returns a new instance of ClientOptions with default values.
// This is used in the NewApiClient constructor before applying user-defined custom options.
func GetDefaultClientOptions() *ClientOptions {
	options, _ := kiotaHttp.GetDefaultMiddlewaresWithOptions(kiotaHttp.NewCompressionOptions(false))
	return &ClientOptions{
		UserAgent:  "octokit/go-sdk",
		APIVersion: "2022-11-28",
		Middleware: options,
	}
}

My recommendation here is to talk to the owning team so they implement support for content encoding. Not to disable it in the SDK.

Oh interesting, thank you for spelling it out! I somehow didn't catch that Kiota gzipped everything by default. Do you mind giving me a brief explanation of what the ramifications of disabling compression in the SDK might be? I imagine payloads would be larger and therefore slower by some factor (.25? 2?).
I'm pursuing API support, though that historically has been much slower and more difficult for us to change than spec and SDK issues (especially for changes that could be considered breaking, like this one).

Also, am I crazy or does this not seem to be an option in the .NET helpers the way it is in the Go helpers?
Is there a difference in the way this is handled by the underlying .NET libraries by default?

Also, am I crazy or does this not seem to be an option in the .NET helpers the way it is in the Go helpers?
Is there a difference in the way this is handled by the underlying .NET libraries by default?

The main reason why I though about looking into this one is because I was going through an inventory of where we were at for request body compression. And you're correct, at the moment only Go has it implemented, not dotnet. https://github.com/microsoft/kiota-dotnet/issues/304

Oh interesting, thank you for spelling it out! I somehow didn't catch that Kiota gzipped everything by default. Do you mind giving me a brief explanation of what the ramifications of disabling compression in the SDK might be? I imagine payloads would be larger and therefore slower by some factor (.25? 2?).
I'm pursuing API support, though that historically has been much slower and more difficult for us to change than spec and SDK issues (especially for changes that could be considered breaking, like this one).

We didn't run our own comparisons as it's widely documented on the web 1 2 3. It varies based on the payload between a 75% reduction at best, to ~30% at worst. So non-negligeable benefits. While the CPU takes a small hit for doing the extra work, it's largely compensated by the reduction of transfer time.


Unicode characters in key value

In preparation for the upcoming training, I was re-reading alternate key topic and one thing (that was inserted about 3 months ago) caught my attention:
Unicode characters in key value
If the data within a field that is used in an alternate key will contain one of the following characters <,>,*,%,&,:,\ then patch or upsert actions will not work. If you only need uniqueness then this approach will work, but if you need to use these keys as part of data integration then it is best to create the key on fields that won't have data with those characters.
I really don’t know what to make out of it.

Why is the section titled Unicode characters – all the characters mentioned are in the standard ASCII range. Does the title imply that all Unicode characters are going to cause the issue as well? (looks like anything that gets url-encoded will cause a drama)
Is put action going to work? I.e. can we create (but not update) records where alternate key contains those characters?
If it were my code, I would consider that behaviour a bug. If for nothing else but for the fact that most likely it’d be the end-user suffering the consequences. Is it tracked anywhere for resolution?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 852023a1-43d9-88ae-0c7d-2b7499ffdee1
Version Independent ID: 2e5d3808-9716-0541-1d6f-62f3de6ac5bd
Content: Define alternate keys for an entity (Developer Guide for Dynamics 365 Customer Engagement)
Content Source: ce/developer/define-alternate-keys-entity.md
Service: crm-online
GitHub Login: @JimDaly
Microsoft Alias: jdaly

@mayadumesh  and @DavidRMicrosoft Please take a look.

In some protocols, I believe these are special characters that would need to be escaped. I do not read it as a restriction on Unicode characters per se. Generally, the strings we store are Unicode (NVARCHAR datatype).
It appears to be a specific issue for patch and upsert operations, so nothing in the doc implies that other methods would fail or have unexpected results.
You could open a bug on it, but I wouldn't assign it a very high priority. Typically, strings that would be part of an alternate key would be names and autonumber-generated values. It's possible that these characters would occur in such strings, but not very likely.

Can we agree that 'Unicode characters in key value' should be changed to 'Special characters in key value'?

@DavidRMicrosoft  what causes this new limitation on keys? - NVARCHAR's don't have the limitation of not storing those characters.  Is the real reason someone forgot to encode properly? Your assumption that data won't get keyed into a name e.g. Dave @ Contoso etc is a poor assumption.  And even worse that it's ok because it would only be a patch  - best I can tell you are justifying documenting a bug as by design - which sets a terrible precedent.

The problem occurs when these characters are present in a string value of an attribute used in an alternate key (entity key), and only when the key is used for "upsert" logic in certain data integration scenarios.
It is not a restriction on the storage of these characters when they occur in a string attribute that's part of an alternate key.
It does not affect the unique constraint at all; uniqueness is honored regardless of whether these characters are present.
It is not specific to Unicode, although strings in CDS are generally stored in Unicode. The language @JimDaly proposed above will be included in the documentation to make this more clear.
The following is one way to work around the problem. If this still a problem that you're unable to work around, please open a support ticket.
Thanks!

Fetch in query string where the parameters are allowed (e.g.: /accounts?$filter=name eq ‘*bob’).
Get the primarykey attribute from the response (e.g.: accountid).
Use the attribute value from #2 as the key.


Callback constructor for FutureLink

Description
This is an initial implementation, just requesting comments at this stage. I still need to implement some examples.

Add a new method FutureLink::callback_future(), and implement it for ComponentLink and AgentLink.
Refactor the FutureLink::send_future() to take Into<Message> instead of Message to make it match ComponentLink::send_message() more closely, and more convenient to use.

Implements #1271
Checklist:

[ ] I have ran ./ci/run_stable_checks.sh
[ ] I have performed a self-review of my own code
[ ] I have added tests that prove my fix is effective or that my feature works

I'll also update the documentation for ComponentLink::callback to reference this feature (if the PR for the other methods gets approved).

@kellpossible these changes look solid to me!

@kellpossible cool if I merge this?

I never added an example, do you think it's okay?

Yeah, that's fine with me

All good to merge then I think :) I also ran the tests I believe but didn't check the box because I hadn't made the example.

Great, thanks @jstarry !


Let users link libraries an lists to a channel

Right now, the created list and library are not pinned to a specific channel but we want to give users a feature to do exactly that.  The required Graph API call is described here and will need to be executed in a Azure Logic App to match the solution:
Configuring the built-in tab types in Microsoft Teams

fixed in release 3.0.0


Push Departing Times to Timeline

https://developer.pebble.com/guides/pebble-timeline/pin-structure/

Would this be a reminder object?

This'll do it.
https://developer.pebble.com/guides/pebble-timeline/timeline-libraries/

Add dialog choice window for confimation.
https://github.com/pebble-examples/ui-patterns/blob/master/src/windows/dialog_choice_window.c

Oh no that's c!!!!

https://github.com/pebble/pebblejs#window-actiondef


Error on build

When I try to build the dockerfile i get error:
go.mod file not found

fixed by adding
go env -w GO111MODULE=auto   to Dockerfile


Update readme.md

Reflect changes to two sites in Related Work

perfect! thank you for the contribution! 🎉


Separate Factory for Server Instance

[x] Are you creating a new feature?

[x] Why is the new feature needed? What purpose does it serve?

At the moment, if you want to setup, say, an onTask event handler in the HTTP server, in order to get a server instance, you have to call ServerFactory::createSwooleServer() in a delegator or something, the problem with that is that you circumvent the options in the $appendOptions of that method when they are called from the request handler runner context. This would render CLI options useless. By creating a factory responsible solely for the instantiation of the server process, it allows further configuration by way of delegator factories, or by replacing the shipped factory completely.
Furthermore, it's not like you can peg a delegator factory onto the ServerFactory currently because you might end up in a situation where you want to add a callback to the server, but it's already running…
It might be a better strategy to drop ServerFactory completely (Or repurpose it as defined in the pull) and then inject the server instance into the request handler runner, ensuring that it is not already running (As that's the runner's job)
If you'll consider a pull of this nature, I'll put some work into the tests and docs.
Cheers

[ ] How will users use the new feature?
[ ] Base your feature on the develop branch, and submit against that branch.
[ ] Add only one feature per pull request; split multiple features over multiple pull requests
[ ] Add tests for the new feature.
[ ] Add documentation for the new feature.
[ ] Add a CHANGELOG.md entry for the new feature.

Thanks for starting this - I was planning on doing something similar, as I read about the task worker features after we did the stable release!
Take a look at the build failures, and please write tests for the new functionality. Once you have, I'll review!

@gsteel I updated the composer.json, and created the v2 docs tree. I then grabbed your branch, rebased it off of latest develop, and pushed the documentation changes to the correct tree. I've now pushed to your branch, so you can continue with the other changes.

@gsteel — I rebased, as I'd done a bugfix patch earlier to master that fixes the SSL support, based on this patch. I have also edited the documentation, and added CHANGELOG entries.
Thanks again for the stellar patch!

No worries! Thanks for all the help. There's one fly in the ointment I think which I'll take a look at as soon as possible, but with these changes, specifically the http server factory, the symfony cli commands for start/stop/reload operate in isolation - as soon as you call stop on a daemonized server, the container whips up another http server on the same port and host due to the dependency on the handler runner - AFAIK, this is a warning, i.e. 'Can’t bind to port'. The commands still operate correctly (Haven't yet had time to verify that properly), but the notice/warning feels kinda off. Thought I'd better let you know before 2.0 happens!

@gsteel I was kind of wondering about that as I edited the documentation. I'll give it a try, and if it's problematic, we can either remove the stop/reload commands, or figure out a way to re-work them.


Create Findpathsimproved.cpp

Improved with changess

Thank you Ohm, I'm sorry I didn't see this until now, I will check it out.


Fix typo

Hello
While looking through your docs found some errors.
Hope it helps.

PR-Codex overview
This PR updates text in various files for consistency and clarity.
Detailed summary

Updated text for consistency in queueTxRaw.ts
Clarified text in auth.ts
Improved text in getConfiguration.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

anyone with an review?


Sharepoint -- Markdown document alignment issues

🐛 Summary
What's wrong? Please be specific.
There are several alignment issues between the sharepoint markdown (i.e., secure baseline) and the software implementation (i.e., Rego).
Expected behavior
Expect a one-to-one mapping between secure baseline and Rego implementation.
MS.SHAREPOINT.1.1v1 -- Non-standard character, Double left quotation.
MS.SHAREPOINT.1.2v1 -- Not implemented in rego?  Non-standard character.Double left quotation.
MS.SHAREPOINT.4.1v1 -- Non-standard characters. Left/right single quotations.
MS.SHAREPOINT.4.2v1 -- No sperate rego implementation appears to be combined with MS.SHAREPOINT.4.1v1
MS.SHAREPOINT.5.1v1 -- Current Rego has variations for OneDrive and Self-Service sites.

Updated the following in the 212 branch and added note of change alignment to this issue:

MS.SHAREPOINT.1.1v1 -- Removed Double left quotation.
MS.SHAREPOINT.1.2v1 -- Removed Double left quotation
MS.SHAREPOINT.3.1v1 -- Removed Left/right single quotations.

Verified in emerald branch:
(ok) MS.SHAREPOINT.1.1v1 -- Non-standard character, Double left quotation.
(ok - added not implemented in automation of baseline) MS.SHAREPOINT.1.2v1 -- Not implemented in rego? Non-standard character.Double left quotation.
(ok) MS.SHAREPOINT.4.1v1 -- Non-standard characters. Left/right single quotations.
Still need to resolve the following:
MS.SHAREPOINT.4.2v1 -- No sperate rego implementation appears to be combined with MS.SHAREPOINT.4.1v1
MS.SHAREPOINT.5.1v1 -- Current Rego has variations for OneDrive and Self-Service sites.

Review of re-write of SharePoint/One Drive secure baseline will cover these concerns.


feat: avoid seeking in update

this is just a draft, as it seems to have relatively little effect - it avoids a DashMap lookup
in a few cases and seems to improve the performance of replace_subtrie by about 10%. However,
that in itself is a relatively small proportion of the runtime, so the extra complexity may not be
worth it.

#97
#96  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on  Graphite


feat: migrated to splunk-ui

BREAKING CHANGE: Migrate UI to SplunkUI framework

:tada: This PR is included in version 5.0.0-develop.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 5.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Unable to connect to SolarEdge Inverter and Battery

Describe the bug
I have followed the installation and configuration guidelines and have enabled Modbus in the inverter which set to be using port 1502 as per your example. I have now added the HACS repository and added the SolarEdge Integration. In the integration, I entered the fixed network address of <IP_ADDRESS> with Port of 1502. When I click Submit the integration is added but there is a warning <Failed Setup, will retry>.
I can see the integration is continuing to attempt a connection every few seconds but it is not connecting. I restarted HA after completing the HACS download and again after configuring the integration.
I have just read another recent post about the possibility the latest version of HA may have affected how this integration connects. I was running HA Core 2024.12.4 but while doing the configuration today an update to 2024.12.5 appeared so I updated to that hoping it may resolve this but unfortunately it didn't. I have also tried changing the default settings for the SolarEdge Integration but this didn't help either. I also tried uninstalling the HACS integration and downloaded an older version but that didn't work so I am currently back with 3.0.3 but not connecting.
I have enabled debug logging but currently I cannot see where to access the debug file to send to you.
Expected behavior
I was hoping that once the configuration was completed I would start to receive live data directly from my inverter and the available sensors.
Screenshots

Diagnostic File
I have enabled debugging but I cannot see where to download the debugging file

Debug logs
No response
Home Assistant Version
2024.12.4
solaredge-modbus-multi Version
3.0.3
Installation Type
HAOS
Read the Instructions

[X] My configuration follows https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Configuration
[X] I have read the Known Issues https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Known-Issues
[X] This issue is not about a template error (do not report template errors, read https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Template-Design-Notes)

Additional Context
No response

You can only have one connection to a SolarEdge inverter at a time. Other integrations will block the connection. You will need to uninstall the other solarege modbus integration (or disable/remove its devices) to use this one.


Analysis output should display a link to open the static report

https://issues.redhat.com/browse/MTA-1294

https://github.com/konveyor/kantra/pull/80

@eemcmullan adding Closes #74 should automatically close the issue after merge


Test

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
{ R200 / F200 / SR300 / ZR300 / D400 }

Firmware Version
(Open RealSense Viewer --> Click info)

Operating System & Version
{Win (8.1/10) / Linux (Ubuntu 14/16/17) / MacOS

Kernel Version (Linux Only)
(e.g. 4.14.13)

Platform
PC/Raspberry Pi/ NVIDIA Jetson / etc..

SDK Version
{ legacy / 2.. }

Issue Description
<Describe your issue / question / feature request / etc..>

ad

test

test

test

[Realsense Customer Engineering Team Comment]
3

test

[Realsense Customer Engineering Team Comment]
reply

conversation

[Realsense Customer Engineering Team Comment]
reply

[Realsense Customer Engineering Team Comment]
Reply

Label

label Test

.

test

test

[Realsense Customer Engineering Team Comment]
p


[BugFix] Fix TOPNFilter result error when order by multi-columns

when order by multi-columns we should build close-interval filter
close https://github.com/StarRocks/starrocks/issues/25835
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[x] 3.0
[ ] 2.5
[ ] 2.4

could you add some cases in sql-test?

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0


Clean up the icon cache

The idea is to release on our own Python object binding before Qt release itself C++ objects.
The  bug was occurring 1 time every 10 launchs.
This patch looks to fix the problem. No bugs through about 30 launchs.
Closes #1771

LGTM


Add support for Rack 2.

Require for folks trying out Rails 5. I can tweak the build matrix to run the tests against rack 2.0.0.alpha in the same way that the repository supports Rails 3.2 + 4.2 if we want to go that road.

I'd love a build matrix tweak to ensure that this is tested. Happy to merge ahead of rails 5 release if we at least have rails 5 matrix in here.

@jnunemaker updated :+1: there's also a new commit to fix a deprecation warning from Rails 5 but I can squash them together if you want.

Gem::InstallError: rack requires Ruby version >= 2.2.2.

Looks like rack 2 doesn't like < ruby 2.2. I can fix that up after the CI run is done.
matrix:
  # don't run rails 5 on ruby versions that can't install rack 2
  exclude:
    - rvm: 2.0.0
      env: RAILS_VERSION=5.0.0.beta3
    - rvm: 2.1.8
      env: RAILS_VERSION=5.0.0.beta3

I think I just need to add that. Noting it here so I don't forget.

@jnunemaker thanks :heart:

:heart: for the PR!


Query Formulation

Why is it called pillars? I feel like it's a 3D box.

Pillar is a specialized case of 3D box. We initialize the queries to the shape of pillars, thus calling them pillar query.


Add proj:code

Closes #26.
I imagine the old proj:epsg should stay in there for now since there doesn't seem to be any extension version information.

First, we need to merge and release the new projection extension.
Once that is done, stac-migrate needs an update and that would remove the requirement to have proj:epsg here (at least for the JS ecosystem). Once that is done, we can continue here.

Implemented. Closing in favor of ebd9c99a due to the additional code required to create links for the various authorities.


File picker broken

Description
The file picker in a PR has a tiny height and is effectively useless. Tested on 1.19.0 was not broken on 1.19.0-rc1
Example test PR
https://try.gitea.io/gempir/gempbot/pulls/1/files
Gitea Version
1.19.0
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots

Git Version
No response
Operating System
No response
How are you running Gitea?
systemd
Database
None

I did add screenshots, maybe they were not clear enough?
I don't really see how a PR with a scrollbar in the File Picker is an edge case to me that's a regular occurence, as we noticed this regression like 2 hours after upgrading.

"Edge case" is probably not the best term, but I mean the bug does not show in all cases.

I did add screenshots, maybe they were not clear enough?

Sorry for bothering, at first I just thought that "expanding" doesn't work well with some height, so I confirmed again that it seems only related to the height & scrolling ..... (correct me if I am wrong)

I guess it's still somewhat related to the LESS->CSS (the change itself is good and right, but maybe some old bugs are triggered?)
According to my test, before: 202803fc69d21763a06d8d0f5a4c46509c18f6f1 , the tree-list just works (I can't reproduce the height bug), after 202803fc69d21763a06d8d0f5a4c46509c18f6f1 , I can 100% reproduce it .... strange.
I just don't understand what causes the problem ..... I will spend some time on it to see if we can find the root problem, to avoid other potential bugs.

Yes, it is a regression from #23554 and  #23553 will fix it.

The fix for 1.19 (#23616) has been merged.
You can get 1.19 latest from https://dl.gitea.com/gitea/1.19/ , or docker gitea:1.19-dev
These contain the fix.

Will there be no 1.19.1 release ?

There will be. Using  1.19-dev is the most convenient way to get bug fixes quickly before 1.19.1 gets released.
All fixed in 1.19-dev will be included in 1.19.1
After 1.19.1 gets release, then 1.19-dev is for next 1.19.2


Security issue with Azure AD B2C Local Account - Sign in form

Hi
I just noticed that in Azure AD B2C, if a user tries to login with an incorrect username/ email with a local account, the system shows an error of
We can't seem to find your account
And if they enter a correct account ID, and wrong password the system says
Your password is incorrect
This is the most basic security consideration, I'm very surprised that it is not considered here.
For both cases it has to say something like
Your Username/Password is incorrect.
I would appreciate it if this could be fixed as a matter of urgency as it will put our application and user's privacy at risk.
Thanks
Farshad

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 370e4c33-91b6-eafb-1ced-0a079449d982
Version Independent ID: cefd38c9-5c1e-c381-0549-ded07f752f97
Content: Tutorial - Enable single-page app authentication with accounts using Azure Active Directory B2C
Content Source: articles/active-directory-b2c/active-directory-b2c-tutorials-spa.md
Service: active-directory
GitHub Login: @davidmu1
Microsoft Alias: davidmu

@fdashti Thanks for reporting this. I will check with the product team regarding this and will provide an update accordingly.


Live

Docs Build status updates of commit 8dc78c5:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


How to get started?

Say I wanted to build a concept using electrino. Just to see what I would bump into or find out some of the limitations. How do I get started?

@mdings Read The Fine Manual. Might it will helps you.

@indrakaw  And where is this Fine manual you are talking about? The readme surely isn't enough to get one started..

@indrakaw Yes, where is this manual? No info on how to use this project.. The only demo project provided, also doesn't work, having error cannot find module electrino. Such a nice project description, while project it self seems dead and unusable...

then it's WIP. Please @pojala.
I use npm references for testing stuff with electrino.


URL-authenticated - disabling relevant frontend elements

address : https://jira.movember.com/browse/TN-2645
Changes include:

frontend code change to check authentication method via which user is authenticated
disabling UI elements, i.e. profile menu links and links with css class, 'portal-weak-auth-disabled', if user encounter indicates a "url_authenticated" auth method

NOTE: This is dependent on changes in this PR: #3693

@achen2401 looks good.  i'll recommend you hold-up this PR till we add the css-class and front end needs as that's part of the same issue?


TASK: MessageMetadata must be immutable

That is still not yet truly immutable, since still one Metadata container can suddenly contain more properties than on construction. I rather thought about the common immutability pattern:
public withProperty($name, $value) {     return new MessageMetadata($this->aggregateIdentifier, $this->aggregateName, $this->timestamp, array_merge($this->propertyBag, [$name => $value])); }

I see, but in this case, the EventTransport should not contain the most recent version of the metadata but only the one that was create on construction, right ?
Not sure if it work, the idea of the metadata is to add related data to a specific event that are not business / domain related (like per example the commit version number in the event bus, the one returned by the event store after a succesful commit).
So fully immutable is not really needed here. Overriding existing meta should be disallowed, but I don't see good reasons to fully immutable.

Event Event handler can provide meta data, that can be use for logging / reporting, like performance informations, metrics, ...

I see, but in this case, the EventTransport should not contain the most recent version of the metadata but only the one that was create on construction, right ?

Yes, but likewise I would make the Transport immutable, providing wrappers to add new meta there:
   protected withMeta($name, $value)
   {
       return new EventTransport($this->event, $this->metadata->withProperty($name, $value));
   }

Not sure if it work, the idea of the metadata is to add related data to a specific event that are not business / domain related (like per example the commit version number in the event bus, the one returned by the event store after a succesful commit).

That is not constrained by the immutability, it's still possible to create new Transport wrappers with additional meta information before giving a final version to the eventstore.

So fully immutable is not really needed here.

That's true, it is not strictly required, but it's a good practice to keep things immutable that can easily be made immutable, as it prevents aliasing issues. And in fact, the stored event should be immutable latest at the point it got persisted, which is most of his lifetime.
But let's see what others think.

I don't habe strong feelings about this, but agree with @albe that truly immutable with a wrapper is more robust and kind of best practice. You don't want someone modify a MetaData object while it's passed around. And you know how developers are ... ;-)

Anyway, let's solve it in a later PR and get this one out of the way ...


Feature: min/max position

This is a feature I miss from the yaasa desk, and I believe could be solved with the custom controller: custom min/max position for the table. This is useful when the desk is in a crammy space with objects below and above, and you don't want to rely on the collision detection mechanism (which would easily let the table crush my chair before backing up).
There should be 2 configuration values, min_position and max_position, and the controller should break the movement of the table when either is reached.

I guess setting these positions should be possible using the controller keys, eg. press Save and then up/down button.

Hello!
Indeed this is a use case that would be really helpful to have with the provided remote. This feature can definitely be added by using a custom controller and defining a range within which the desk is allowed to move between.
Don't know if this is exactly what you are looking for, but currently, you can define a MIN/MAX height in centimeters in the logicdata.h header. The default range goes from 60cm to 120cm, although the absolute maximum supported by the desk is from 57cm to 123cm.
https://github.com/ma-lwa-re/dreamdesk/blob/31289d9a424f03e48afcb1b755a8dd8283dbfcae/main/logicdata.h#L26-L27
If you try to set a target value outside of this range, the controller will reject it and thus won't move.
https://github.com/ma-lwa-re/dreamdesk/blob/31289d9a424f03e48afcb1b755a8dd8283dbfcae/main/dreamdesk.c#L81-L84
Greetings 🙂

Oh wow, tbh I didn't dive into the code as I don't have the skills or equipment to build a controller anyway :D Impressive work btw, especially with that article.


Snippets and Autocomplete for Sublime Text

I know there used to be a package out there for Bourbon/Neat snippets and Autofill.  Does something like that exists for new versions of Bourbon or Neat in Sublime Text 3?

Sorry but this is not an issue with neat. Sublime text packages can be found at https://packagecontrol.io
Only post issues that pertain directly to the Neat library. If you have general inquiries like the one above, post them to https://stackoverflow.com. Github issues are not intended to be a discussion/support channel.

Thanks.  I will do that.


Undefined error message while using it with testcafe's chrome browser.

Component
Version

Operating system
Mac Os

Node.js
v14.15.5

chrome-remote-interface
0.30.0

Is Chrome running in a container? (I am using chrome with the help of TestCafe)
My main Aim:  My Aim is to cut the network so that I can see the error dialog in the website while automation testing.
[Important]: Testcafe is opening with this url: //http://<IP_ADDRESS>:1234/someRandomString/https://theWebsiteThatIAmTesting.com/
const CDP = require('chrome-remote-interface');
let config = {
        offline: true,
        latency: 100,
        downloadThroughput: 750 * 1024 / 8,
        uploadThroughput: 250 * 1024 / 8
    };
let client = await CDP({
        port:1234,
        host:"<IP_ADDRESS>"
    });

    const {Network} = client;
    await Network.enable();
    Network.emulateNetworkConditions(config);

I am getting error at this line 34:
         29 |        });
         30 |        response.on('end', () => {
         31 |            if (response.statusCode === 200) {
         32 |                callback(null, data);
         33 |            } else {
       > 34 |                callback(new Error(data));
         35 |            }
         36 |        });
         37 |    });
         38 |    request.setTimeout(REQUEST_TIMEOUT, () => {
         39 |        request.abort();

         at IncomingMessage.<anonymous> (/Volumes/workplace/workplacenew/src/GuruWebUITests/node_modules/chrome-remote-interface/lib/external-request.js:34:26)

The error message is not visible and this is the main reason why I am putting this question over here.

I request @cyrus-and to have a look at it.
This will be really helpful If you can spend some minutes of your at this issue.
Thanks in advance and kudos for this amazing module :)

What do you mean with "the error message is not visible"?
That code simply performs an HTTP request and return an error if the code is not 200, the body is returned so you can catch it, otherwise it will be printed on the terminal as part of the stack trace.
For example:
(async () => {
    const CDP = require('chrome-remote-interface');

    try {
        await CDP({
            host: 'example.com',
            port: 80
        });
    } catch (err) {
        console.error(err.toString());
    }
})();

Which yields:
Error: <?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
         "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

		<title>404 - Not Found</title>

404 - Not Found

Note though that there's little to debug here as the above request is equivalent to:
$ dig +short example.com
<IP_ADDRESS>

$ curl http://<IP_ADDRESS>/json/list -i
HTTP/1.1 404 Not Found
Content-Type: text/html
Date: Wed, 12 May 2021 07:06:10 GMT
Server: ECS (bsa/EB21)
Content-Length: 345

<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
         "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

		<title>404 - Not Found</title>

404 - Not Found

In your example, you are able to see the error like
Error: <?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
         "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

		<title>404 - Not Found</title>

404 - Not Found

In my case I am getting only
Error
that's it. This is what I mean by error not visible.

Most likely http://<IP_ADDRESS>:1234/json/list returns an empty body, try with curl as I shown you above if you want to see the status code. In any case, that endpoint is not returning the list of targets as chrome-remote-interface expects to.

Most likely http://<IP_ADDRESS>:1234/json/list returns an empty body, try with curl as I shown you above if you want to see the status code. In any case, that endpoint is not returning the list of targets as chrome-remote-interface expects to.

Got it.
Trying this.
Thanks for the explanation and help :)

Commenting here again to let you know that the issue is resolved.
It was not related to CDP but more related to ports and Testcafe.
For anyone who wants to use this awesome library in Testcafe: Please make sure you are not setting the parameter port1 and port2 as 9222, they are different from the cdpPort.
While running a test case you have to make sure you use the same cdpPort as CDP requires. By default it is 9222 but you can change using the parameter port while calling CDP.
Closing this issue :)

Thanks, for sharing your knowledge. :)


Crashing in VSCode - "The Vue Semantic Server server crashed 5 times in the last 3 minutes"

After updating to 1.8.2 Volar started crashing. Downgrading to 1.8.1 fixes it.
Some details:

VScode 1.79.2
I'm not using Typescript
Tried re-installing Volar, didn't help

Error Message:
The Vue Semantic Server server crashed 5 times in the last 3 minutes. The server will not be restarted. See the output for more information.
Output:
TypeError: Cannot read properties of undefined (reading 'package.json') at Object.h [as fileExists] (/Users/myusername/.vscode/extensions/vue.volar-1.8.2/dist/server.js:77:1416) at Proxy.x (/Users/myusername/.vscode/extensions/vue.volar-1.8.2/dist/server.js:76:37698) at Object.fileExists (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/typescript.js:139762:40) at host.fileExists (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/typescript.js:116036:43) at Object.fileExists (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/typescript.js:119567:30) at getPackageJsonInfo (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/typescript.js:40352:33) at loadNodeModuleFromDirectory (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/typescript.js:40184:47) at nodeLoadModuleByRelativeName (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/typescript.js:40058:14) at tryResolve (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/typescript.js:39991:27) at nodeModuleNameResolverWorker (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/typescript.js:39925:38)

坐等修复

The same problem
VS code 1.78.2
Volar 1.8.2

The same problem
VS code 1.78.2
Volar 1.8.2

Fixed by https://github.com/volarjs/volar.js/commit/b1344bf65c01f55872e0b0a17c767cfbae6893e0

restart


Component 'RCTVideo' re-registered bubbling event 'topVideoLoadStart' as a direct event

Component 'RCTVideo' re-registered bubbling event 'topVideoLoadStart' as a direct event
组件“RCTVideo”已注册冒泡事件“topVideoLoadStart”作为直接事件
Hello, there is no problem with Xcode compilation. What's the matter once it runs
您好，xcode编译没出问题，一运行就这样是怎么回事呀

已经解决了，我移除了 ‘react-native-video’和‘react-native-video-contros’
It has been solved. I removed "react native video" and "react native video contros"

不能够和react native video 一起使用吗？


GET[https://api.ipfs.temporal.cloud/api/v0/dns/ipfs.io] fails with http code 403 (forbidden)

Describe the bug
The Temporal gist announces api/v0/dns as supported. It seems to be blocked by some missing authorization as we get FORBIDDEN (403)
To Reproduce
GET[https://api.ipfs.temporal.cloud/api/v0/dns/ipfs.io] with proper JWT
Expected behavior
Obtain same response that is obtained on our local IPFS server:
{
"Path": "/ipfs/bafybeie5rfdrwsbg5iwrsmilgu4xvmkwnpvk7caih2vbupobjfajf5ketq"
}

Strange this call should be allowed. I will debug this

Looks like you sent the call incorrectly. Here's the log with sensitive information removed
{"level":"error","ts":1580674679.198572,"logger":"server","caller":"server/server.go:249","msg":"failed to get user from jwt","error":"no authentication provided","stacktrace":"github.com/RTradeLtd/warp/server.(*Server).handleProxyCall\n\t/BUILD/server/server.go:249\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2007\ngithub.com/go-chi/chi.(*Mux).routeHTTP\n\t/BUILD/vendor/github.com/go-chi/chi/mux.go:425\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2007\ngithub.com/go-chi/chi/middleware.Recoverer.func1\n\t/BUILD/vendor/github.com/go-chi/chi/middleware/recoverer.go:35\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2007\ngithub.com/RTradeLtd/warp/log.loggerMiddleware.Handler.func1\n\t/BUILD/log/middleware.go:26\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2007\ngithub.com/go-chi/chi/middleware.RealIP.func1\n\t/BUILD/vendor/github.com/go-chi/chi/middleware/realip.go:34\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2007\ngithub.com/go-chi/chi/middleware.RequestID.func1\n\t/BUILD/vendor/github.com/go-chi/chi/middleware/request_id.go:72\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2007\ngithub.com/go-chi/cors.(*Cors).Handler.func1\n\t/BUILD/vendor/github.com/go-chi/cors/cors.go:199\nnet/http.HandlerFunc.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2007\ngithub.com/go-chi/chi.(*Mux).ServeHTTP\n\t/BUILD/vendor/github.com/go-chi/chi/mux.go:82\nnet/http.serverHandler.ServeHTTP\n\t/usr/local/go/src/net/http/server.go:2802\nnet/http.(*conn).serve\n\t/usr/local/go/src/net/http/server.go:1890"}
{"level":"info","ts":1580674679.198821,"logger":"server.request.middleware","caller":"log/middleware.go:33","msg":"request completed","path":"/api/v0/dns/ipfs.io","query":"","method":"HEAD","took":0.00029734,"real-ip":"","request-id":"delta-node-2/Su82LGfqFg-001665"}

For whatever reason when you sent the request you didnt include the JWT in your authorizatino headers. One thing to keep in mind, in the past i've used clients like js-ipfs-http-client and go-ipfs-api and one certain calls they wouldn't inject the header information.

Based on my findings in the previous comment, there is no clear indication that this problem is on our end, and is most likely one of the following:

API request didnt include the authentication header
IPFS HTTP API library being used has a reoccurence of previous bugs I've experienced.

I'm going to close this issue as such, however if you continue to experience this issue please re-open and provide sample code that shows how you are constructing the client, and making the call.


chore: add '_sample' suffix to samples

Change-Id: If21d21ff97c30f45305b6365fa5ed10172557606
chore: Add sample suffix to surface code snippets in sample browser

DO NOT MERGE until doc page updates are ready.


Focal length of each scene.

Thanks for your great work.
Can you provide the focal length with a separate file?
Downloading the stereo dataset takes a long time, so downloading the RAW dataset will take the same long time, I just need the focus length to generate the corresponding depth.
This also will be helpful for others.
Thanks for your help!

Sorry, we don't plan to provide that separately.


Set Axis Limits for plotting manually

This PR adds configuration options for plotting axes minimum and maximum values.
This was primarily motivated by creating animations of pulse optimization and needing the plotting frame and scaling to remain constant throughout.

Merge here closes #52


[FLOC-1622] Manual cli test floc 1622

Fixes https://clusterhq.atlassian.net/browse/FLOC-1622

Has a merge conflict with master, can you resolve?

Has a merge conflict with master, can you resolve?

Done

Thanks.  Looks good.  Please merge.


Alter column type fails without USING required by PostgreSQL

STR

Create an entity Test with ListId which is string, run migrations and use it
Remove ListId from the entity Test
Create another entity, e.g. List and reference Test like ICollection to actually create ListId, but with another type -- int in such case
Generate migration

AR
The proper command for alter table generate on EF level, but PSQL fails with error:
ERROR:  column "ListId" cannot be cast automatically to type integer
HINT:  You might need to specify "USING "ListId"::integer".

ER
Migration should be passed without errors. Actually, in the SQL code there USING missing, so if will be set -- no error appear.

Duplicate of #144.
In cases where safe type conversion is possible, PostgreSQL doesn't require a USING clause and will silently convert - USING is only required for potentially destructive type changes, or those which require a user-defined function. For example, converting a string to an int may file (non-numeric characters), so PostgreSQL refuses to transparently convert and requires a USING clause.
As explained in #144, the idea is to maintain the same behavior in the EF Core provider - if the user wishes to specify a USING function, they must do so themselves by writing raw SQL in the migration.

@roji thanks for a quick response and idea summary.


Add "setup from scratch" doc

It looks like this work is included in #159. Should we treat them as separate or close this one?

@wyegelwel Yes, #160 incorporates this PR. I'll close this one.