Problem while integration flutter AAR in android app

Hello everyone!
I am working on a project where I'm integrating a flutter package I'm developing in an app built in another multi-platform development framework. To do so, I am going through the native layer, so it is as if I would be integrating my flutter package into iOS and Android native apps. Here is the guide to do so. For android, I am using the AAR approach.
While shifting to the latest stable flutter versions (3.3.7) I noticed that the output of the command flutter build aar has changed and is now different than the documentation. It has become :
  1. Open <host>/app/build.gradle
  2. Ensure you have the repositories configured, otherwise add them:

      String storageUrl = System.env.FLUTTER_STORAGE_BASE_URL ?: "https://storage.googleapis.com"
      repositories {
        maven {
            url 'path_to_my_package/build/host/outputs/repo'
        }
        maven {
            url "$storageUrl/download.flutter.io"
        }
      }

  3. Make the host app depend on the Flutter module:

    dependencies {
      debugImplementation 'my_package:flutter:1.0:debug'
      profileImplementation 'my_package:flutter:1.0:profile'
      releaseImplementation 'my_package:flutter:1.0:release'
    }

  4. Add the `profile` build type:

    android {
      buildTypes {
        profile {
          initWith debug
        }
      }
    }

And when building the app for android, I get the following error
Could not find flutter-1.0-release.jar

Note: I was using flutter 3.0.0 before that.
Did anything change in the way we should add Flutter to an android app through an AAR ?

Hi @charbel-elhajj, can you share the output of flutter build aar from the version you were on prior to 3.3.7?
Please also share the full logs of when you try to build the android app.
Thank you

Here is the output when using Flutter 3.0.0
💪 Building with sound null safety 💪

Running Gradle task 'assembleAarDebug'...                         125.5s
✓ Built build/host/outputs/repo.
Running Gradle task 'assembleAarProfile'...                       116.7s
✓ Built build/host/outputs/repo.
Running Gradle task 'assembleAarRelease'...                        99.5s
✓ Built build/host/outputs/repo.

Consuming the Module
  1. Open <host>/app/build.gradle
  2. Ensure you have the repositories configured, otherwise add them:

      String storageUrl = System.env.FLUTTER_STORAGE_BASE_URL ?: "https://storage.googleapis.com"
      repositories {
        maven {
            url 'path_to_my_package/build/host/outputs/repo'
        }
        maven {
            url "$storageUrl/download.flutter.io"
        }
      }

  3. Make the host app depend on the Flutter module:

    dependencies {
      **debugImplementation 'my_package:flutter_debug:1.0'
      profileImplementation 'my_package:flutter_profile:1.0'
      releaseImplementation 'my_package:flutter_release:1.0'**
    }

  4. Add the `profile` build type:

    android {
      buildTypes {
        profile {
          initWith debug
        }
      }
    }

App build output with flutter 3.3.7 built aar (it is a cordova application built on android) :
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileDebugKotlin'.
> Error while evaluating property 'filteredArgumentsMap' of task ':app:compileDebugKotlin'
   > Could not resolve all files for configuration ':app:debugCompileClasspath'.
      > Failed to transform flutter-1.0-release.jar (my_package:flutter:1.0) to match attributes {artifactType=android-classes-jar, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-runtime}.
         > Could not find flutter-1.0-release.jar (my_package:flutter:1.0).
           Searched in the following locations:
               file:path_to_app/cordova_host_application/platforms/android/app/src/main/kotlin/Flutter/repo/com/my_package/flutter/1.0/flutter-1.0-release.jar

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.1.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 42s
24 actionable tasks: 1 executed, 23 up-to-date
Command failed with exit code 1: path_to_app/cordova_host_application/platforms/android/gradlew cdvBuildDebug -b path_to_app/cordova_host_application/platforms/android/build.gradle

Note that there is a flutter-1.0-release.aar in the location where they are searching and there was never a jar file built by flutter (neither on 3.0.0 nor on 3.3.7), only AARs, but this problem appeared only after the version upgrade.

Hi @charbel-elhajj, thanks for the info. I believe this is a duplicate of https://github.com/flutter/flutter/issues/112380 albeit with different files throwing the error, as such I'll be closing this issue in favor of the said issue.
Kindly follow up there for updates.
If you disagree, kindly leave a comment below and I will reopen this.
Thank you


Log is not showing problem

fix for this issue
https://github.com/square/okhttp/issues/2384

I think that making newline separators visible introduces more problems than it fixes.

it just a logs

I don’t think this is a good fit for OkHttp’s log method.


Characters other than ASCII alpha-numerics replaced by underscores in file names when saving articles

Newsboat version (copy the output of newsboat -v or the first line of git show): newsboat 2.17.1 (but I also tested with 2e8c2aa58eacc669f50733d681bbf571be1f4ab5, which is the current master)
Config file (copy from ~/.newsboat/config or ~/.config/newsboat/config):
auto-reload yes
show-read-articles no
show-read-feeds no
prepopulate-query-feeds no
feed-sort-order unreadarticlecount
show-keymap-hint yes
swap-title-and-hints no
text-width 72
save-path "~/Documents/archived-articles/rss"
confirm-exit yes
display-article-progress yes
browser firefox
macro a set browser "vidl %u &> /dev/null &"; open-in-browser ; set browser "firefox %u"
macro w set browser "mpv %u &> /dev/null &"; open-in-browser ; set browser "firefox %u"
macro s save-all

Steps to reproduce the issue:

Include a feed that posts content with the Cyrillic characters in the title (like this (RSS feed))

Select one of the items and press s to save, say, this (image). Instead of getting the title in Cyrillic, all non-ASCII characters are ignored and instead you get this (image)

Save the feed. For the aforementioned article, this is the file name I got: ________Android__iOS.txt.

Other info you think is relevant:
From what I gather, this problem is caused by view.cpp#286 because isalnum seems to ignore non ASCII characters.

Reproduced with 2e8c2aa58eacc669f50733d681bbf571be1f4ab5 too. Thanks for the report, @crimsonskylark!
Unfortunately the commit that introduced isalnum, https://github.com/newsboat/newsboat/commit/f41adc224451a93688373ad4203882efb9c1b102, doesn't exactly say what problem it fixed; does macOS filesystem disallow anything other than NUL and slash? I'm inclined to just revert it, but then I'll have to find someone with macOS to verify that this didn't break anything. Alternatively, we can try isalnum_l, but I can't figure out if it's available on BSDs.

I also don't have access to a MacOS machine so I can't check it. Do you think this could be fixed by a macro to only build with this function in a MacOS environment?

That's a viable workaround, but before doing this, I'd like to research what might've caused the bug that isalnum is supposed to fix.

We have macOS workers in CI, so we can also perform experiments there, e.g. by adding a test.

https://github.com/newsboat/newsboat/issues/1417#issuecomment-758150644 argues that this behaviour is correct, so I can no longer treat it as a bug. Instead, let's consider this a feature to be added: there should be a setting which, when enabled, restricts the filenames to alpha-numeric ASCII characters (that's the current behaviour, so this would be the default). When disabled, the filenames would contain whatever the original article contained.
When naming the setting, it'd be wise to look at the name chosen for a similar setting in Podboat: https://github.com/newsboat/newsboat/issues/1261

https://github.com/newsboat/newsboat/issues/1417#issuecomment-758150644 argues that this behaviour is correct, so I can no longer treat it as a bug. Instead, let's consider this a feature to be added: there should be a setting which, when enabled, restricts the filenames to alpha-numeric ASCII characters (that's the current behaviour, so this would be the default). When disabled, the filenames would contain whatever the original article contained.
When naming the setting, it'd be wise to look at the name chosen for a similar setting in Podboat: https://github.com/newsboat/newsboat/issues/1261

I can speak only for my case: I have feeds in Portuguese, French, Russian and English and the saving feature properly for the latter. Nevertheless, considering that it seems I was the first one to find/report this specific incompatibility, it would seem that my case is a very niche one and not really worth making significant changes to the software in order to accomodate. Worst case scenario I can just remove isalnum from my local copy and re-compile it, which is what I've done.

I can speak only for my case: I have feeds in Portuguese, French, Russian and English and the saving feature properly for the latter. Nevertheless, considering that it seems I was the first one to find/report this specific incompatibility, it would seem that my case is a very niche one and not really worth making significant changes to the software in order to accomodate. Worst case scenario I can just remove isalnum from my local copy and re-compile it, which is what I've done.

considering that it seems I was the first one to find/report this specific incompatibility

I had this issue when I started using newsboat a year ago, but back then when I search the issue tracker with keyword like "CJK" (but not "UTF-8" or "ASCII", which help me discover this issue today), the only issue came up was #334 which is about Rust port and irrelevant to my problem. Then I just forgot to report this :cry: .

it would seem that my case is a very niche one

I do happen to know a few people having this issue including myself. For me, the issue is saving articles whose title contains CJK characters.

not really worth making significant changes to the software in order to accomodate

Does it mean the code needs to be changed in a way that's not backward-compatible? I think the setting to unset the restriction of filenames to alpha-numeric ASCII characters does no harm to compatibility🤔.

considering that it seems I was the first one to find/report this specific incompatibility

I had this issue when I started using newsboat a year ago, but back then when I search the issue tracker with keyword like "CJK" (but not "UTF-8" or "ASCII", which help me discover this issue today), the only issue came up was #334 which is about Rust port and irrelevant to my problem. Then I just forgot to report this :cry: .

it would seem that my case is a very niche one

I do happen to know a few people having this issue including myself. For me, the issue is saving articles whose title contains CJK characters.

not really worth making significant changes to the software in order to accomodate

Does it mean the code needs to be changed in a way that's not backward-compatible? I think the setting to unset the restriction of filenames to alpha-numeric ASCII characters does no harm to compatibility🤔.

Does it mean the code needs to be changed in a way that's not backward-compatible? I think the setting to unset the restriction of filenames to alpha-numeric ASCII characters does no harm to compatibilitythinking

I'm not sure. I'm not very familiar with this code base, I just played around with it enough to track down the issue in the OP.

Does it mean the code needs to be changed in a way that's not backward-compatible? I think the setting to unset the restriction of filenames to alpha-numeric ASCII characters does no harm to compatibilitythinking

I'm not sure. I'm not very familiar with this code base, I just played around with it enough to track down the issue in the OP.

The setting indeed won't harm compatibility: the current behaviour would be the default, and you folks would be able to change the setting to make Newsboat use all the original characters (in UTF-8).

The setting indeed won't harm compatibility: the current behaviour would be the default, and you folks would be able to change the setting to make Newsboat use all the original characters (in UTF-8).

If anyone wants to work on this, the changes required to implement this feature are:

add a new setting to an array in src/configcontainer.cpp;
document that setting in doc/configcommands.dsv;
skip this loop if the setting is disabled: https://github.com/newsboat/newsboat/blob/c282d28504f47d8b2c92009285f5db2481545fcf/src/view.cpp#L289-L296
if you can, create test/view.cpp and write a test for both states of the setting;
submit a PR ^_^

If anyone wants to work on this, the changes required to implement this feature are:

add a new setting to an array in src/configcontainer.cpp;
document that setting in doc/configcommands.dsv;
skip this loop if the setting is disabled: https://github.com/newsboat/newsboat/blob/c282d28504f47d8b2c92009285f5db2481545fcf/src/view.cpp#L289-L296
if you can, create test/view.cpp and write a test for both states of the setting;
submit a PR ^_^

Hi, some unfortunate things occupied my time but I hope to get around to this during the weekend and I'll PR the changes.


Add robots line

Due to a request from a department, we need to make sure these pages are hidden from Google search results.

Looks good to me


[WIP] Updates to User Login and Invites

Purpose:  Miscellaneous fixes and additions
 To do

[x] Custom email templates
[x] Password length restriction
[ ] Fix UI errors

[x] Login view cutoff
[x] Restrict home page by authenticated (fix "Logged in as Sign Out" bug)
[x] Add password change page for users
[x] Add forgot password link
[x] Display proper Django message class type (current 'patch' handles only success and error)
[ ] Handle warning/failure cases for send_email_invitation in Django-admin
[ ] Createsuperuser: make confirmed by default (?)

[x] Set up OSF email server for admin app
- Needs to be tested on staging

Is there a JIRA ticket associated with this?

@sloria Actually no, I hadn't created one yet, I will do that

@cwisecarver Give this a quick pass?
I have yet to test the emailing, but I asked Michael for the sendgrid password so hopefully I'll get that soon.
The other thing is handling unsuccessful email invites on admin; I wanted to ask you about this real quick in person if you get the chance.
Thanks!

Done with this pass @Ghalko, @zkraime. Whoever picks this up let me know if there are questions.

@zkraime What is the status of this?

@cwisecarver Please do a really quick pass over this to make sure I addressed your comments?
Also, not sure how to go about handling warning and failure cases for email invites so I will leave that be for now since it's lower priority than other work (it's the one unchecked box)

Looks good to me @zkraime. Make sure you get with @mattclark when this goes to this being ready-to-merge about the email settings that will need to be put in local.py.

As mentioned on the JIRA ticket: please update this branch with develop and resend the PR to develop. Thanks!


Change to position of Data Labels for Column and Bar charts

This is the first in a series of changes.
Test site - radzen.delaci.co.uk
While using negative and zero data, the labels were always positioned above (column) or to the right (bar) of the bar.
This change places the label above, level or below for column charts and left, level or right for bar charts.

Hi @akorchev
Not sure what's happened with the check failures. None of them seem relate to any changes I've made.
Regards
Paul

Hey @paulo-rico,
I've broke the tests however they are now fixed.


Must run capacity ratings not being applied

Checklist

[X] I am running on an up-to-date pypsa-usa environment. Update via conda env update -f envs/environment.yaml

Issue exisits on what branch
Develop
The Issue
Must run capacity ratings executes in add_electricity, but the result dataframe is empty. This example below is just for texas.

Steps To Reproduce
Run the workflow for just texas
Expected Behavior
No response
Error Message
No response
Anything else?
No response

This isn't a bug, we don't have must-run status designation data for non-wecc resources. I will close this with d350dc9 which also adds minimum loading for the entire US when unit commitment is enabled. Data for Minimum loading comes from pudl/eia860

Thanks for clarifying, @ktehranchi!


Dx 589/fix weth using rinkeby address

Fixes swapTokens for WETH
Related DX-586, DX-587

love that address title!!


Localization | Angular 4.3.x | .net Core 2

i tried different solutions to achieve localization, but none of them worked.
Solution1, component.ts:
import * as Flatpickr from 'flatpickr';
const Russian = require('../../lib/flatpickr/dist/l10n/ru.js');
Flatpickr.localize(Russian.ru);

No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:44353' is therefore not allowed access. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
10:01:36.777 day:42 Error: Failed to fetch
Instantiating http://localhost:44353/flatpickr
Loading http://localhost:44353/app/core/day.component.js
Loading app

Solution2, component.ts
import * as Flatpickr from 'flatpickr';
import { ru as Russian } from '../../lib/flatpickr/dist/l10n/ru.js';

didnt work, because --allowJs is not set.
i found out, that i have to set allowJs to true and specify outdir directory.
Now i cant build my project in VS2017, because nuget packages are not found.
My nugets are working fine when outdir/rootdir are set to "wwwroot", but then i get this "Cannot write file '...components.js' because it would overwrite input file"

Solution3, Layout.cshtml
  <script src="~/lib/flatpickr/dist/flatpickr.js"></script>
   <script src="~/lib/flatpickr/dist/l10n/ru.js"></script>

component.ts
Flatpickr.localize(Flatpickr.l10ns.ru);
            flatpickr("#startTime", {});

can't build my project.
ru does not exist on type {default: Locale}
Your Environment

flatpickr version used: v3.0.6
flatpickr type 3.0.2 from https://www.npmjs.com/package/@types/flatpickr
Browser name and version: Chrome Version 60.0.3112.113 (Offizieller Build) (64-Bit)
OS and version: Windows 10 x64

see also https://github.com/Microsoft/TypeScript/issues/15970

Hello,
Things should be much easier very soon because flatpickr has been ported to typescript.
Watch out for the next release.

v3.1.2 is out with typings included.


Different ptvsd version in Python interactive window

Visual Studio shows "ptvsd (4.1.3)" under Python Environments > Packages (PyPl). However, when I enter
import ptvsd
help(ptvsd)

in the Python 2.7 (32-bit) interactive window, Python says ptvsd has version "<IP_ADDRESS>".
Why is there a different ptvsd version in the interactive window? Which version is actually used when debugging via ptvsd?
My environment: Visual Studio 2017 15.8.2 (32-bit) + Python 2.7.14 (32-bit)

The REPL implementation is located within the old ptvsd, like this:

So the old ptvsd gets loaded as a side effect of loading the REPL code.
We'll have to move the REPL code out of there when we remove the old debugger code entirely. We'll do that when the new ptvsd has feature parity with the old ptvsd (it's close, but not there yet).
When debugging with F5, the debugger is selected based on the value of "use legacy debugger" in tools/options/python/debuging.
If you are trying to use the new ptvsd from the REPL, you can unload the old ptvsd first.
del sys.modules['ptvsd']

More on that here: https://github.com/Microsoft/PTVS/issues/4636


Included new default assets

Just added iPhone XR, Galaxy S7 and a browser mockups. :)

Awesome 😍


Bug: Empty Available Java Versions list of Raspberry Pi 4

Bug report
When I entered the command sdk list java, I got an empty list.
================================================================================
Available Java Versions
================================================================================
 Vendor        | Use | Version      | Dist    | Status     | Identifier
--------------------------------------------------------------------------------
================================================================================
Omit Identifier to install default version 17.0.1-tem:
    $ sdk install java
Use TAB completion to discover available versions
    $ sdk install java [TAB]
Or install a specific version by Identifier:
    $ sdk install java 17.0.1-tem
Hit Q to exit this list view
================================================================================

And then I tried all 3 SDK commands but I got this
Stop! java 17.0.1-tem is not available. Possible causes:
 * 17.0.1-tem is an invalid version
 * java binaries are incompatible with your platform
 * java has not been released yet

Tip: see all available versions for your platform:

  $ sdk list java

To reproduce
I installed sdkman according to the instructions.
System info

Raspbian OS and Version

PRETTY_NAME="Raspbian GNU/Linux 11 (bullseye)"
NAME="Raspbian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=raspbian
ID_LIKE=debian
HOME_URL="http://www.raspbian.org/"
SUPPORT_URL="http://www.raspbian.org/RaspbianForums"
BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

Shell and version (e.g. bash --version/zsh --version)
bash --version

GNU bash, version 5.1.4(1)-release (arm-unknown-linux-gnueabihf)
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

The output of sdk version: SDKMAN 5.13.1

Hi @AndrewLe124,
This isn't a bug but rather that we don't support your platform (yet). Note the second point in the output when you attempted to install Java:
 * java binaries are incompatible with your platform

We have an ongoing effort to support all the arm architectures on SDKMAN but it does require some work to be done on the backend.
Closing this issue for now.


Add config.ts to let the CLI know about components path

It's kind of painful to type the path on every component install. Sometimes the path is too long or there's a typo etc. A config file in the root directory could solve this issue. Something like this:
// shadcnui.config.ts

export default {
	components: "./src/components/ui/shadcn"
};

If the file exists the CLI shouldn't ask for a path.

@ahkhanjani Yep we're looking into it in #245

It should be a pretty straightforward change at the bottom of the cli index.ts:
async function promptForDestinationDir() {
  if (!fs.existsSync('./shadcnui.config.ts')) {
    const { dir } = await prompts([
      {
        type: "text",
        name: "dir",
        message: "Where would you like to install the component(s)?",
        initial: "./components/ui",
      },
    ])

    return dir
  }

  const config = require('./shadcnui.config.ts')

  return config.componentsPath
}

I don't really know how to parse a .config.ts file, this is just an idea.


platformio run command blocks platformio init completion in subprocess

Currently, if you run platformio init --ide=anything with a non-existent ~/.platformio it will not run to completion and simply hangs waiting for user response.   This prompt is never shown to the user due to subprocess execution here:  https://github.com/platformio/platformio/blob/develop/platformio/ide/projectgenerator.py#L55
Here is the prompt (after some debugging):
The platform 'nordicnrf51' has not been installed yet. Would you like to install it now? [y/N]:.
Is there any way we can avoid calling another command here and simply do whatever run does internally instead?

See "Troubleshooting" section from installation page http://docs.platformio.org/en/latest/installation.html#troubleshooting
You have to use --force flag before each comman when ru PlatformIO from subprocess. Like, platformio -f init --ide=anything

Don't forget upgrade (platformio upgrade) PlatformIO to 2.3.0, which was released yesterday. It has improved Project Generator for the multiple IDE.

this is in your code, so I don't see how you can close it. NOTE: I'm using what is in 2.3.0 by using the develop branch

Thanks! I'll fix it. Looks like critical bug, maybe I'll release 2.3.1 today.

Thanks a lot for this report!!! :+1:
PlatformIO 2.3.1 is released!


x/playground: dev-branch code doesn't maintain dev-branch attribute when shared

The new playground makes it possible to use the dev branch to try examples only possible on tip (type parameter code being the prime example). However, a "Share" link created on that code doesn't work when run unless the "Go release" selector is first changed to "Go dev branch".
For example, I created this link by "Share" on the "Generic min" example: https://go.dev/play/p/kg938K7hORf . If you open that, clicking Run won't work as it should.

Duplicate of #49885


Radix sort on CUDA 2.1 compilation error

Hi,
       I am running radix sort provided by CUDA SDK samples(http://developer.download.nvidia.com/compute/cuda/sdk/website/Data-Parallel_Algorithms.html) on a system with fedora 8 & CUDA version 2.1
      It has a main folder NVIDIA GPU Computing SDK & subfolders C and shared. C has all the code,makefile&common. while shared has header files.
    I go to the NVIDIA GPU Computing SDK/C folder and compile using make. then I get following error
-------------------------------------------------------------
make[1]: Entering directory `/home/su1015/project/radix/NVIDIA GPU Computing
SDK/shared'
make[1]: *** No targets specified and no makefile found.  Stop.
make[1]: Leaving directory `/home/su1015/project/radix/NVIDIA GPU Computing
SDK/shared'
make: *** [shared/libshrutil.so] Error 2
--------------------------------------------------------------
I dont understand why it needs to compile the code in shared folder.... when I
am going to C folder & using make... As the shared folder just holds .h files
it does not need makefile...

I am new to CUDA & Linux Please help me on this..

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 4 Aug 2010 at 4:29

This is not a problem with CUDPP, it is a problem with the NVIDIA CUDA SDK (and
an old one at that -- 2.1 is 3 versions behind the latest release).  We can't
support this issue here.  I suggest you raise the issue on the NVIDIA CUDA
Forums.

Marking invalid.

Original comment by<EMAIL_ADDRESS>on 4 Aug 2010 at 9:48

Changed state: Invalid


Need to move IEEE equipment out of Troxler and into the hallway cabinet.

Bobby Compton has just notified me that I've been given back Troxler access for the next week.
We need to move everything out of our own locker, as well as the equipment that's in the closet.
When is a good time for this?
I originally hoped to do this on the Saturday hackday, but I have to be out of town this weekend and can't make it.
I can leave my ID in the locker so everyone can get into troxler without me, just text or email me directly for the password.

Where is the hallway locker?

Hey so are Hack days on Saturday now? I just showed up for the Thursday one, but no ones here. I am about of town this weekend as well but I would be able to help out Sunday afternoon or evening when I get back.

The new locker is next to the soda machine.
On Jun 2, 2016 7:12 PM, "Thomas Alexander Barrett (prefers Alex)" <
<EMAIL_ADDRESS>wrote:

Hey so are Hack days on Saturday now? I just showed up for the Thursday
one, but no ones here. I am about of town this weekend as well but I would
be able to help out Sunday afternoon or evening when I get back.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/IEEERobotics/bot/issues/477#issuecomment-223449818,
or mute the thread
https://github.com/notifications/unsubscribe/ACSzx_m2vGpHKWtMN768s-EGOyNyPrX-ks5qH2N0gaJpZM4Ir6kG
.


Move this repository to the attic

As part of the move to the Apache Software Foundation this repository will transfer ownership to apache and name to incubator-zipkin-azure.
See https://issues.apache.org/jira/browse/INFRA-16989

I will move this to the attic tomorrow and click archive


clarify licensing

I see two licenses, one for the code, the other for the documentation.
However, after reading ThirdPartyNotices, what is considered as code, and what is considered part of the documentation is not clear.
For example it is my understanding that syntax definitions (as EBNF here) considered as documentation and CC licensed. But it is ambiguous.
Is there an attribute in markdown to separate MIT and CC content ?

@thda Hello Thomas, I do not understand what this Issue 1648 is about.
Where do you see "two licenses"? Link?
What documentation article is this Issue 1648 referring to (on docs.microsoft.com)? Link?
Can you please provide more information, and more clarity, for this Issue 1648.
EBNF = (extended Backus-Naur form)
CC = ??
MIT = ??
Thanks.

Hi, and thanks for taking the time to answer.
CC BY 4.0 is this license
MIT is this license
Which one does apply to what content ?
I think this tries to address the issue.
It says:

Microsoft and any contributors grant you a license to the Microsoft documentation and other content
in this repository under the Creative Commons Attribution 4.0 International Public License,
see the LICENSE file, and grant you a license to any code in the repository under the MIT License, see the
LICENSE-CODE file.

However it looks vague to me.
I would like to know the license of the syntax definitions here in EBNF.

@craigg-msft Hi Craig,
The point of Thomas's question is, for repository 'MicrosoftDocs/sql-docs', - Are the Transact-SQL BNF syntax diagrams under the CC license or under the MIT license?
Or put another way, are our T-SQL syntax diagrams considered to be "code" or not?
Craig, do you know whom we should ask for an answer?
Thanks.    GeneMi

Email sent, seeking legal opinion from Microsoft internal legal team.
From: Gene M
Sent: Thursday, March 7, 2019 11:28 PM
To: Ned ; Jennifer ; Greg
Cc: CraigG
Subject: Which license applies to BNF syntax diagrams that define Transact-SQL statement syntaxes ?

@thda Answer is:  The BNF syntax diagrams for Transact-SQL statements are governed under the Creative Commons license.

Creative Commons Attribution 4.0 International Public License https://creativecommons.org/licenses/by/4.0/legalcode

(JH, of LCA, 2019/03/12 10:02am)
Closing this Issue 1648 now, as successfully fixed. (The @ notification mechanism remains available, if necessary.)
Thanks for inquiring.


Implement participant import via backend

Closes #2670
Needs OpenSlides/openslides-backend#1980 to work

Please be more precise on where this is inappropriately shown, as there are some places (f.E. the title row of the actual csv file) where this wording is absolutely required by our technical system

Please change the string "saml_id" in the preview to "SAML ID"


[INLONG-620]Selector for Go SDK

@gosonzhang @charlely PTAL

Codecov Report

Merging #478 (d125573) into INLONG-25 (24b3c99) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             INLONG-25    #478   +/-   ##
===========================================
  Coverage         7.51%   7.51%
  Complexity         479     479
===========================================
  Files              267     267
  Lines            29500   29500
  Branches          4843    4843
===========================================
  Hits              2216    2216
  Misses           26810   26810
  Partials           474     474

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b3c99...d125573. Read the comment docs.

+1


Update documentation for namespace overview

Updates designs and documentation for the namespace overview based on feedback and requirements

Removes list view
Removes alternate representations
Updates card view to better reflect user needs

@cshinn I just added a summary issue https://github.com/kiali/kiali-design/issues/22 at the same time!

@pilhuhn that's the plan for the sorting.  Who will create that formula?
Should it be highest percentage of errors would be first, then highest percentage of warnings?
Or would we want those things weighted?

@serenamarie125 Great.
My thought is that anything with red (e) goes before everything that is not red.
Same for yellow (w) before anything green (g).
So 1e3w  would go before 5w1g before 3g
Within the the 'categories' I'd go for sorting by number of the state. So 2eX will go before 1e5w before 1e3w

@abonas now that the graph has switched to showing applications instead of services, are there changes that need to be made to this design? Should we show applications/workloads instead, or should both services and workloads be included?

@mwringe @lucasponce can you please address @cshinn question above?

I should say that the graph represents applications, workloads and also services.
If I am not wrong, this is an example of three ones:

As a preliminar step (version 0) we are introducing a new navigation entry called Application; but overall yes, I should say it should be taken into consideration for high level goals on the design.

@abonas @cshinn FYI I'm going to merge this PR.  If you need workspaces included as well, we can iterate on the design.


Disable CodeQL for pipeline-tasks

Task name:
Description:
Documentation changes required: (Y/N)
Added unit tests: (Y/N)
Attached related issue: (Y/N)
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

/azp run


Add order_sampler option to Iterators

Background
The current interface for iterators can not customize the order of indices.
This becomes problemetic when some kind of constraints need to be satisfied among indices of a batch.
For instance, there is no way to prevent a batch from containing more than two indices with the same value. In the current implementation, this can happen when a batch consists of indices from the end of a order and the beginning of the next order.
There needs to be an extra abstraction for sampling indices.
Initially, I looked into the way PyTorch does this. https://github.com/pytorch/pytorch/blob/master/torch/utils/data/dataloader.py
They seem to get indices returned by an object called batch_sampler.
It looked nice, but after working on this direction for a while (prototype), I found that the functionalities of Chainer's iterators and PyTorch's DataLoader are a bit different.
In Chainer, we need to support serialization of the iterator.
This difference is significant because it requires the serialized iterator to recover the state any time, and we need to impose an extra interface requirements for batch_sampler.
Namely, we need the batch_sampler to pass all information that is necessary to recover its state as well as indices to Iterator.
What this PR is
I found that it is much more simple to customize a function to generate an order of indices to iterate.
In this approach, we assume the function to satisfy the following interaface:
# current_order: An 1-D array of indices.
# current_position: An integer indicating where the iterator is.
# next_order: An 1-D array of indices.
def order_sampler(current_order, current_position):
     ...
    return next_order

I designed the interface so that all the state of an iterator is passed to the function.
Passing order back and forth is nice because it requires little change in codebase, and there is no backward-incompatibility.

@yuyu2172 Sorry for the delayed response. I and @delta2323 if he has time will continue with the review as we discussed this PR within the team today and concluded that this feature should be added. For the record.

Since it's been a while, do you mind rebasing?

For the record, talked offline with @yuyu2172 to continue working on this PR.
As suggested in https://github.com/chainer/chainer/issues/2860#issuecomment-380281965 , I think a good approach is to extend the interface as already suggested while also including a single or a minimum set of concrete samplers. Other samplers could be introduced in separate PRs.

@hvy
Can you check this PR?

Thanks, will take a look 👍

jenkins, test this please.

We don't have to provide a full fledge example but how about adding a test with a dummy sampler that makes use of both arguments?

Some comments after offline discussions with @beam2d :

It looks good in general!
One suggestion though (with respect to the default behavior and in terms of backward compatibility): How about changing the default value of shuffle to None. If it is None and no sampler is given, then it behaves as if shuffle=True. Then we may raise an error in case shuffle is given any non-None value along along with a sampler. This probably is more intuitive to the user since no argument it silenced.

One suggestion though (with respect to the default behavior and in terms of backward compatibility): How about changing the default value of shuffle to None. If it is None and no sampler is given, then it behaves as if shuffle=True. Then we may raise an error in case shuffle is given any non-None value along along with a sampler. This probably is more intuitive to the user since no argument it silenced.

Nice.

We don't have to provide a full fledge example but how about adding a test with a dummy sampler that makes use of both arguments?

Done.
I fixed everything suggested.

Thanks a lot for the quick fixes! Would you mind fixing the CI failures also?

Sorry. Fixed.

I just noticed this PR, and I basically vote it.
How about adding BaseOrderSampler class to define the interface/method that any OrderSampler class should have, so that it is more easier to implement/maintain other type of OrderSampler?
I guess def __call__(self, current_order, current_position): is the interface requirement.
--- I think below discussion can be done by other separated PR as well. ---
I also think OrderSampler class also should have serialize method so that it can be serialized/deserialized by iterator.
I implemented BalancedSerialIterator which is for imbalanced data, it have internal iterator which must be serialized.
https://github.com/pfnet-research/chainer-chemistry/blob/master/chainer_chemistry/iterators/balanced_serial_iterator.py
After this PR merged, I think it is nice to introduce BalancedOrderSampler rather than BalancedSerialIterator (used in Chainer Chemistry until now) so that the sampler can be reused among any kinds of Iterators.

I also think OrderSampler class also should have serialize method so that it can be serialized/deserialized by iterator.

Is serializing order and  current_position not enough for your purpose?

How about adding BaseOrderSampler class to define the interface/method that any OrderSampler class should have, so that it is more easier to implement/maintain other type of OrderSampler?

@hvy
What do you think? I think it is ok.

I also think OrderSampler class also should have serialize method so that it can be serialized/deserialized by iterator.

When considering other OrderSampler in the future, I think it is nice that Sampler itself can have internal state.
For concrete example, below BalancedSerialIterator have internal IndexIterator which needs to be serialized. I guess when considering to introduce "BalancedSampler", we need this kind of internal state to be serialized.
https://github.com/pfnet-research/chainer-chemistry/blob/master/chainer_chemistry/iterators/balanced_serial_iterator.py#L132-L134

--- I think below discussion can be done by other separated PR as well. ---

I think this discussion should be done in another PR.
There other PRs that depend on this PR, and I think this should be merged quickly.

I agree sorry.

jenkins, test this please.

I see you added the base class which is great I think. It also helps as documentation. The implementation  LGTM but I'll take a final look at the tests.

I agree that the serialization can be discussed in a separate issue when it becomes relevant, whether that's now or later. It should be possible to build it on top of this.

Jenkins, test this please.

jenkins, test this please.

jenkins, test this please.

@yuyu2172 It seems like the docs are failing. Could you please take a look when you have time 🙇

jenkins, test this please.

jenkins, test this please.

jenkins, test this please.

jenkins, test this please.

LGTM!


Deb sdl3

add sdl3 to debian package build as alternative to sdl2
add some operator delete

@freerdp-bot test again please


Add lookup_pack config option

Fixes #39
It allows to define a custom path for pack lookup

We got bitten by this when upgrading webpack-assets-manifest from v3 (the assets key was introduced in v4).

@nikushi Any chance of getting this merged?

@nikushi ping


AltGr shortcut behaves differently than Ctrl+Shift shortcut

ℹ Computer information

Windows build number: 18363.959
PowerToys version: 0.20.0
PowerToy module: Keyboard Manager

📝 Provide detailed reproduction steps (if any)
(on a german keyboard)

Map shortcut AltGr+L to Right (appears as Ctrl (Left) + Alt (Right) + L)
Map shortcut Ctrl+Shift+L to Right

✔ Expected result
Both shortcuts should behave equally, in particular move the cursor e.g. in notepad to the right when activated. Holding the modifiers while pushing L repeatedly should move the cursor multiple times to the right.
❌ Actual result
With the second shortcut, it works as expected. With the first shortcut, holding AltGr while pushing L repeatedly only moves the cursor to the right once and then writes "l" until AltGr has been released and pushed again.

I can repro this.

It seems like this happens when you remap any AltGr based shortcut to another key/shortcut. Ctrl(left)+Alt(right) remaps work fine in En-US (where AltGr doesn't exist). It seems that when we send a key up for Alt, the OS sends Alt down again, since Ctrl is not released and it tries to force AltGr to be pressed. I think the only way to fix this would be to handle detection and sending AltGr the correct way, i.e. using scan code rather than virtual key code.

Thanks for having a look at this! It would be great if this gets fixed!
If you have any further questions, I am ready to help, of course!

AltGr and Ctrl+Alt gives (more) issues. There's something fishy about it and I think we should investigate, and make people more aware.
Quote from Wikipedia:

On a typical, Windows-compatible PC keyboard, the AltGr key, when present, takes the place of the right-hand Alt key: if not engraved as such, that key may still be remapped to behave as though it is, (or emulated using a chord such as Ctrl+Alt).

Are you still experiencing this issue? /needinfo


Deleted articles reappearing after feed refresh

Describe the bug
Articles that have been deleted reappear in the feed's article list (still marked as read) when the feed is refreshed. The deleted but reappeared article shows up in both the feed and in the Trash. After quitting and restarting Vienna, the deleted articles no longer show up in the feed list.
To Reproduce
Relevant settings:
Mark current article read: After a short delay
Move articles to Trash: Manually
Erase deleted articles: When Vienna quits

From a feed's article list, hit Delete to delete the article and move it to the Trash. As expected, the article is now gone from the article list.
Refresh the feed. The previously deleted articles show up as read in the article listing again.

Screenshots
Just read the article, about to hit Delete

Immediately after hitting Delete, article is gone as expected

Refreshed the feed with Command-Shift-R and the deleted article is back

Please complete the following information:

Vienna version: Version 3.9.3 :fd467d52: (8375)
OS version: Sonoma 14.6.1 (23G93)

Additional information:
This issue is new in v3.9.3.

Same behavior. Feed refresh isn't even necessary to reproduce. Just moving to a different feed and back makes the deleted articles show again.

It's the same here. After reading each feed, I have to empty the recycle bin, otherwise the articles I've already deleted reappear. Quite exhausting.

same here, on mac Sonoma 14.7 App version 3.9.3. very annoying. how could this pass QA?

@akmail you are using a free application developed by volunteers in their free time. Please consider a different way of talking to us. Additionally, you can contribute to our quality by testing the beta versions and regularly giving (polite) feedback about your experience before we release a version to the broader public.

To all others: sorry for the inconvenience. I will take some time to look into this, probably today.

now I feel even more irritated. a friendly question how this bug made it into a release led you to blame me? 25 developers and automated tests and beta program. but ok. if you want to put it all on me and not apologise it to my person, I'm ok with that.

@akmail If we were a group of 25 active full-time paid developers in that project I would agree, that it is not understandable how this can "pass QA", but the reality is that we are 3 ½ active maintainers, the automated tests are not nearly covering all the functionality, nor do we have the capacity to test for any potential regression. So we rely on feedback from beta testers. Anyone in this thread can do this, it's not only on you!

apologies if I sounded bad. I work in the IT too and I can tell you that here in the "paid developers" life bad thing happen too. often enough - e.g. today. I do really appreciate your work and open source in general. So, looking forward for your fix.

I want to close and then delete this issue. Let's open a new one as a fresh start and we can all be happy and kind! 😀


Bugfix/yousong qcloud nic

这个 PR 实现什么功能/修复什么问题:
vendor: add tencentcloud-sdk-go vpc
feat(multicloud): qcloud: add getSdkClient
multicloud: qcloud: add getVpcClient
multicloud: qcloud: add apiDomainByRegion
multicloud: qcloud: add ptr deref func
multicloud: qcloud: fix instancenic

[x] 冒烟测试

是否需要 backport 到之前的 release 分支:

release/3.6

/area region
/cc @swordqiu @zexi @ioito @lvyangyang

Codecov Report

Merging #9100 (d7a11d1) into master (d0a2f43) will increase coverage by 11.79%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #9100       +/-   ##
===========================================
+ Coverage    5.85%   17.64%   +11.79%
===========================================
  Files         834       89      -745
  Lines      129939     8960   -120979
===========================================
- Hits         7602     1581     -6021
+ Misses     121656     7205   -114451
+ Partials      681      174      -507

Flag
Coverage Δ

aFlag
17.64% <ø> (+11.79%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/monitor/bus/bus.go

pkg/compute/models/snapshotpolicycache.go

pkg/compute/models/elasticcache_instances.go

pkg/appsrv/workers.go

pkg/baremetal/tasks/unmaintenance.go

pkg/mcclient/options/k8s/secret.go

pkg/mcclient/options/routetable_association.go

pkg/mcclient/options/k8s/fed_resource.go

pkg/compute/models/scaling_policy.go

pkg/keystone/models/servicecertificates.go

... and 736 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a2f43...d7a11d1. Read the comment docs.

/lgtm

/lgtm
/approve


OpenLens can't fetch prometheus metrics

Rancher Server Setup

Rancher version: 2.8.0
Installation option (Docker install/Helm Chart): Helm chart

Information about the Cluster

Kubernetes version: v1.27.8 -8cb36c9
Cluster Type (Local/Downstream): AWS EKS

User Information

What is the role of the user logged in? Cluster Owner.

Describe the bug
Installed rancher monitoring tool through rancher UI.
Monitoring version - v103.0.0+up45.31.1
After installation can not fetch prometheus metrics on OpenLens 6.5.12
Already tried to change metrics setting to prometheus namespace/service:port. Screenshot №2
Old version of rancher(2.6.13) with monitoring version - v100.2.0+up40.1.2 everything work properly. Screenshot below:
Screenshot №1

To Reproduce
Install monitoring tool be default on System Project through rancher web UI.
Result
Expected Result
Fetching prometheus metrics like in screen №1
Screenshots
Screenshot №2

Screenshot №3

Rancher does not actively support or test with lens. If you would like to raise a PR yourself, we'd be happy to review it though. I am leaving this ticket open for now. Since this does appear to be a regression, we may find time to do a quick investigation, but at a low priority.


esp32s3 can not accepts ble conn param as gattc (IDFGH-10431)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v4.4.5-98-ge33a1808d6
Operating System used.
Windows
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
Development Kit.
Custom Board
Power Supply used.
USB
What is the expected behavior?
esp32s3 accepts update conn param
What is the actual behavior?
a slave device update conn param,esp32s3 as master print update connection params status = 19 when min interval = 6 max interval = 6 latency = 5 timeout=500, but it works when slave update min interval = 32 max interval = 32 latency = 50 timeout=500
Steps to reproduce.

Step
Step
Step
...
.

Debug Logs.
No response
More Information.
No response

by the way,esp32 no above issues，esp32 can accepts both conn param

Hello, can you describe how to reproduce this issue? Did you use coded PHY or multiple connections? @fzboffice

@zhp0406  thanks! I'm waitting for update.


V-show isn't working on an element with a style attribute

Vue version
3.4.16
Link to minimal reproduction
https://github.com/mattelen/vue-show-issue
Steps to reproduce
Run the app with npm run dev. Click on the "Click me to toggle" Button. This will hide some content. Click on the button again to show the content
What is expected?
The content is shown
What is actually happening?
The Content is not shown
System Info
System:
    OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
    CPU: (16) x64 AMD Ryzen 7 PRO 4750U with Radeon Graphics
    Memory: 30.29 GB / 44.80 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 18.12.1 - ~/.nvm/versions/node/v18.12.1/bin/node
    Yarn: 1.13.0 - ~/.yarn/bin/yarn
    npm: 8.19.2 - ~/.nvm/versions/node/v18.12.1/bin/npm
    pnpm: 8.6.11 - ~/.nvm/versions/node/v18.12.1/bin/pnpm
  Browsers:
    Chrome: 121.0.6167.139
    Chromium: 121.0.6167.139
  npmPackages:
    vue: ^3.4.15 => 3.4.16

Any additional comments?
This issue appears to have started in 3.4.15. Is this affecting our vue-multiselect library (https://github.com/shentao/vue-multiselect/issues/1752)

Actually this is duplicate of #10294 (sorry thought I had checked!). Closing


Package Processing Queue

Instead of processing packages as they are added, they should be added to a queue and then processed in order (or not added to the queue if it is already on the queue)

This should be complete in e685aa00de580db514faeacc7a087e930c2e766e


Standalone client release NPM and JAVA

Please fill this out with the details of the release and tasks.

We are in the process of release NPM for https://github.com/opensearch-project/opensearch-js today.

We have release 1.0.0 version of NPM OpenSearch-JS client today.
https://www.npmjs.com/package/@opensearch-project/opensearch


Change schema validation to match actual requirement

The Chunker requires an auto incrementing integer column called id
to successfully chunk the table while migrating.

CI builds fail intermittently due to timing issues and losing connection to the database. Does anyone know how to alleviate those problems? Thanks. :bow:

@hannestyden I triggered a rebuild on Travis.  All good now

:+1:

@bjk-soundcloud Thanks a bunch! :bow:

For some reason all records are not being migrated when the id column is not PRIMARY KEY even if the Table#pk extracted by Parser#extract_primary_key seems to be ignored by Chunker. Have to investigate more to figure out why.

False alarm! My test was borked somehow.

Please review again. :bow:
/cc @bjk-soundcloud

Fantastic, thanks! :+1:

Add a changelog https://github.com/soundcloud/lhm/commit/771821caec22e3edd2e17e81427e0d1cd9040abf
thanks all.


authboss mailer removes newlines in text email bodies

Sending text down using a TextBody will have all newlines be removed whether the TextBody uses \n or \r\n in them when the user reads the email in their client.
(Having an HTMLBody that renders instead hides this problem, so you've got to do some work to get this to occur.)
There supposedly is code in smtpMailer to handle this but it does not seem to work correctly.
I think the mime and strings.Replace is confusing the process. If I delete all of the boundary stuff, and just plop the body in with
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

{{.TextBody}}

and do the strings.Replace on the template string (not the output from the template), everything seems to work correctly.

By "work correctly", I mean "shows up in an email client like Gmail properly rendered".

Hm. Interesting. More work to figure out. Again, will try to correct this in v2 and then backport (will also backport the other fix since that code is pretty much unchanged).

Where is this v2 code? I keep hearing about it but I'm not sure where to look for it.
Also, I think the fix is probably to use the mime libraries (ala mailyak's use) but I've not had a change to confirm.

https://github.com/volatiletech/authboss/tree/vcrazy
The awful branch name is because I tried something insane off the original dev branch, and I liked how that spike turned out I kept working on it and just failed to push it to a meaningful branch name. Let me know if you have any questions, I'd love to get another pair of eyes on it so I can address any potential problems without having to v3 immediately after v2 :)

Wasn't able to reproduce this unfortunately. Any other hints on how to do it? You could try out the tests yourself that I wrote:
https://github.com/volatiletech/authboss/blob/vcrazy/defaults/smtp_mailer_test.go#L19
Using my gmail creds in the JSON file, it sent me 3 e-mails that all looked normal (newlines where they were expected). One text only, one html only, and one had both text and html.


How do I determine which element is pressed?

onSingleTap gives a target, which is a node id of the pressed element and is difficult to make use of. Pressable inside the ReactNativeZoomableView does not do the trick either.

Alright, target is usable in Android with findViewById or requireViewById. Still a hacky solution, though.

Tapping on subelements (like pins) are tricky. Especially when they can overlap or are too close to each other. We recommend using https://github.com/mourner/rbush-knn to detect tap location and select the right component accordingly


ContextToGL event routing needs fixing

the current way the input events are routed through the render method produces infinite event reporting (this can easily be observed via profiling) -> needs to be split into the actual callbacks so that events go into the getcontext subtree as well

that was stale, I forgot


"%UPSTREAM_REMOTE_ADDRESS%" does not seem to work.

As far as I can tell "%UPSTREAM_REMOTE_ADDRESS%" is not working as presented in the manual pages.
%UPSTREAM_REMOTE_ADDRESS%
Remote address of the upstream host. If the address is an IP address it includes both address and port.

I tried envoy proxy in the following configuration modes:

TPROXY
Forward Proxy
Reverse Proxy
Original Destination

but the upstream IP:port is never added to the HTTP request:
The setup for the specific data below is very simple:
client ---> Envoy ----> Server

These are the HTTP headers the server sees. It has two X-Request-Downstream because while trying everything I added the custom headers in more than one hierarchy level.
http: 2019/09/03 08:27:49 Server is ready to handle requests at :5000

HTTP Headers Received:
======================
X-Request-Downstream                    : <IP_ADDRESS>:4999
X-Request-Downstream                    : <IP_ADDRESS>:4999
Accept                                  : */*
X-Forwarded-Proto                       : http
X-Envoy-Expected-Rq-Timeout-Ms          : 15000
Content-Length                          : 0
User-Agent                              : curl/7.54.0
X-Request-Id                            : ea938c03-72d5-4c32-a2c2-5a414f9e7928

Dockerfile for Envoy Proxy 1.11
FROM envoyproxy/envoy:v1.11.1

EXPOSE 4999
EXPOSE 19000
EXPOSE 8443

ENV DEBIAN_FRONTEND noninteractive

RUN apt-get -qq update && \
    apt-get -qq install  \
                apt-utils \
                iputils-ping \
                curl \
                < /dev/null > /dev/null

ADD ./service-envoy.yaml /etc/service-envoy.yaml
ADD ./start_envoy.sh /usr/local/bin/start_envoy.sh
WORKDIR /usr/local/bin
RUN chmod u+x start_envoy.sh
ENTRYPOINT ./start_envoy.sh

Envoy config file
node:
  id: "id_identity"
  cluster: "cluster_identity"
static_resources:
  listeners:
    - name: listener_0
      transparent: true
      address:
        socket_address:
          protocol: TCP
          address: <IP_ADDRESS>
          port_value: 4999
      filter_chains:
        - filters:
            - name: envoy.http_connection_manager
              config:
                idle_timeout: 1s
                codec_type: auto
                access_log:
                  - name: envoy.file_access_log
                    config:
                      path: "/tmp/envoy-access-4999.log"
                stat_prefix: ingress_http
                route_config:
                  name: local_route
                  request_headers_to_add:
                    - header:
                        key: "x-request-upstream"
                        value: "%UPSTREAM_REMOTE_ADDRESS%"
                      append: true
                    - header:
                        key: "x-request-downstream"
                        value: "%DOWNSTREAM_LOCAL_ADDRESS%"
                      append: true
                  virtual_hosts:
                    - name: local_service
                      domains:
                        - "*"
                      routes:
                        - match:
                            prefix: "/"
                          route:
                            cluster: cluster1
                      request_headers_to_add:
                        - header:
                            key: "x-request-upstream"
                            value: "%UPSTREAM_REMOTE_ADDRESS%"
                          append: true
                        - header:
                            key: "x-request-downstream"
                            value: "%DOWNSTREAM_LOCAL_ADDRESS%"
                          append: true
                http_filters:
                  - name: envoy.router
                    typed_config: {}
      listener_filters:
        - name: envoy.listener.original_dst
          typed_config: {}

  clusters:
    - name: cluster1
      connect_timeout: 0.25s
      type: STRICT_DNS
      lb_policy: round_robin
      hosts:
        - socket_address:
            address: "host.docker.internal"
            port_value: 5000
admin:
  access_log_path: "/dev/null"
  address:
    socket_address:
      address: <IP_ADDRESS>
      port_value: 19000

Raw Logs
[2019-09-03 15:55:56.091][19][debug][filter] [source/extensions/filters/listener/original_dst/original_dst.cc:18] original_dst: New connection accepted
[2019-09-03 15:55:56.091][19][debug][main] [source/server/connection_handler_impl.cc:280] [C2] new connection
[2019-09-03 15:55:56.092][19][debug][http] [source/common/http/conn_manager_impl.cc:246] [C2] new stream
[2019-09-03 15:55:56.092][19][debug][http] [source/common/http/conn_manager_impl.cc:619] [C2][S8324268355205076786] request headers complete (end_stream=true):
':authority', '<IP_ADDRESS>:4999'
':path', '/'
':method', 'GET'
'user-agent', 'curl/7.54.0'
'accept', '*/*'

[2019-09-03 15:55:56.092][19][debug][http] [source/common/http/conn_manager_impl.cc:1111] [C2][S8324268355205076786] request end stream
[2019-09-03 15:55:56.092][19][debug][router] [source/common/router/router.cc:401] [C2][S8324268355205076786] cluster 'cluster1' match for URL '/'
[2019-09-03 15:55:56.092][19][debug][router] [source/common/router/router.cc:514] [C2][S8324268355205076786] router decoding headers:
':authority', '<IP_ADDRESS>:4999'
':path', '/'
':method', 'GET'
':scheme', 'http'
'user-agent', 'curl/7.54.0'
'accept', '*/*'
'x-forwarded-proto', 'http'
'x-request-id', 'fea25370-3ef1-4139-9ffc-917b8a105f51'
'x-envoy-expected-rq-timeout-ms', '15000'
'x-request-downstream', '<IP_ADDRESS>:4999'
'x-request-downstream', '<IP_ADDRESS>:4999'

[2019-09-03 15:55:56.092][19][debug][pool] [source/common/http/http1/conn_pool.cc:88] creating a new connection
[2019-09-03 15:55:56.092][19][debug][client] [source/common/http/codec_client.cc:26] [C3] connecting
[2019-09-03 15:55:56.092][19][debug][connection] [source/common/network/connection_impl.cc:704] [C3] connecting to <IP_ADDRESS>:5000
[2019-09-03 15:55:56.092][19][debug][connection] [source/common/network/connection_impl.cc:713] [C3] connection in progress
[2019-09-03 15:55:56.092][19][debug][pool] [source/common/http/conn_pool_base.cc:20] queueing request due to no available connections
[2019-09-03 15:55:56.093][19][debug][connection] [source/common/network/connection_impl.cc:552] [C3] connected
[2019-09-03 15:55:56.093][19][debug][client] [source/common/http/codec_client.cc:64] [C3] connected
[2019-09-03 15:55:56.093][19][debug][pool] [source/common/http/http1/conn_pool.cc:241] [C3] attaching to next request
[2019-09-03 15:55:56.093][19][debug][router] [source/common/router/router.cc:1503] [C2][S8324268355205076786] pool ready
[2019-09-03 15:55:56.094][19][debug][router] [source/common/router/router.cc:994] [C2][S8324268355205076786] upstream headers complete: end_stream=false
[2019-09-03 15:55:56.094][19][debug][http] [source/common/http/conn_manager_impl.cc:1378] [C2][S8324268355205076786] encoding headers via codec (end_stream=false):
':status', '200'
'content-type', 'text/plain; charset=utf-8'
'x-content-type-options', 'nosniff'
'x-request-id', 'fea25370-3ef1-4139-9ffc-917b8a105f51'
'date', 'Tue, 03 Sep 2019 15:55:55 GMT'
'content-length', '14'
'x-envoy-upstream-service-time', '1'
'server', 'envoy'

[2019-09-03 15:55:56.094][19][debug][client] [source/common/http/codec_client.cc:95] [C3] response complete
[2019-09-03 15:55:56.094][19][debug][pool] [source/common/http/http1/conn_pool.cc:198] [C3] response complete
[2019-09-03 15:55:56.094][19][debug][pool] [source/common/http/http1/conn_pool.cc:236] [C3] moving to ready
[2019-09-03 15:55:56.096][19][debug][connection] [source/common/network/connection_impl.cc:520] [C2] remote close
[2019-09-03 15:55:56.096][19][debug][connection] [source/common/network/connection_impl.cc:190] [C2] closing socket: 0
[2019-09-03 15:55:56.096][19][debug][main] [source/server/connection_handler_impl.cc:80] [C2] adding to cleanup list
[2019-09-03 15:55:58.517][9][debug][main] [source/server/server.cc:170] flushing stats

I believe what's happening is that request_headers_to_add are processed before the upstream host is actually chosen, so %UPSTREAM_REMOTE_ADDRESS% is empty and the header is elided. I checked that it works correctly in response headers (which are processed after the upstream responds). I will update the docs to note this (and there are probably expressions that don't produce output for requests).
I think in the original destination case, the %DOWNSTREAM_LOCAL_ADDRESS% may be what you want?

thanks, is there any other way to add the original http client source IP:port to a header? I would like to pass that information to an external authz server. Adding as a response is too late.
Answering your question: I would like to pass both source/dest IP:port to an external authz server.

Your HTTP client is the downstream host. The upstream host is a member of a cluster to which Envoy forwards the request. The various request_headers_to_add configurations are all applied before an upstream host is selected, so the %UPSTREAM_REMOTE_ADDRESS% expression has no value.
Similarly, the ext_authz filter runs before the router filter and so any request_headers_to_add configurations will not have been applied when that filter generates its authorization request.
All that said, it looks like ext_authz sends an AttributeContext.Peer for the source and destination (this is the client's and Envoy server's connection information).

thanks, apologize to press this but I want to get this straight for our deployment.
Under %DOWNSTREAM_LOCAL_ADDRESS% is says
"If the original connection was redirected by iptables REDIRECT, this represents the original destination address restored by the..."
So, what you are saying is that both upstream_remote_address and downstream_local_adress will give me destination IPs and ports, only the point of view is different. The latter will be the destination IP:port in the original IP packet. The former will be the destination IP:port of the member of the cluster. Does it look right?
So, there is no custom header to add the source IP:port of the IP packet. Correct?

BTW, I changed our code and can verify (as you pointed out) that the source IP:port are in the GRPC message sent to the ext-authz server
func (a *AuthorizationServer) Check(ctx context.Context, req *auth.CheckRequest) (*auth.CheckResponse, error) {

	httpRequest := req.Attributes.Request.Http
	socketAddress := req.Attributes.Source.Address.GetSocketAddress()
	fmt.Printf("Source IP:port %s:%d\n", socketAddress.GetAddress(), socketAddress.GetPortValue())

	marshaler := jsonpb.Marshaler{}
	jsonString, _ := marshaler.MarshalToString(httpRequest)

...<snip>...

I think you've got it all correct. Not having %DOWNSTREAM_REMOTE_ADDRESS% seems like an oversight. It wouldn't be difficult to add.

thanks, this was extremely useful. My C++ days are way behind me or I would certainly pitch in to get %DOWNSTREAM_REMOTE_ADDRESS%. Nowadays everything I do seems to be in Golang.


Remove confusing list item and adjust text to match screenshot

Remove confusing list item and adjust text to match screenshot

@chcomley
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


download stop when enable progurd

when i enable progurd
the realize apk has many error in downloading
but when peogurd is disabled problem solved
i ahould enable progurd for security
help me please .

Sorry for the delay. I have fixed the release mode issue. Please try the updated library and confirm me.
compile 'com.mindorks.android:prdownloader:0.3.0'


Bug: paragraph-blank-lines adds spaces between frontmatter and paragraph

[x] I have verified that I am on the latest version of the Linter

Describe the Bug
I do not use H1 headings in my files, so my notes usually start with a paragraph like this:
---
aliases: []
tags: []
---
Hello, it's a note.

With paragraph-blank-lines, linter adds empty line between frontmatter and the text, which is not what I expect. The problem is this extra line is rendered by obsidian in the Live Preview mode, so it's a little bit annoying.
How to Reproduce
Steps to reproduce the behavior:

Enable Paragraph blank lines
Create a note like this:

---
aliases: []
tags: []
---
Hello, it's a note.

Format the note

Expected Behavior
The rule does not add a space between front matter and the body
---
aliases: []
tags: []
---
Hello, it's a note.

Device

[x] Desktop
[ ] Mobile

Additional Context
Add any other context about the problem here.

Hey @igrybkov . Thanks for putting in this issue.
I think to be consistent with other blank line rules, it would be necessary to add the blank line between the frontmatter and the paragraph content. However it should not add a blank line after a paragraph that ends a file. So the thing that would need to change here is the addition of a blank line between the frontmatter and the paragraph provided in steps to reproduce.
If you would like to remove it and do not use --- in your code, you can use a custom replace like:
search: ^(---)\n{2,}
replace: $1\n
flags: m
Please test this regex as I am creating it from memory.

Hey @pjkaufman,
There's a separate rule "Add Blank Line After YAML" and I think it should be responsible for adding empty line in this case, not the paragraph rule. For me current behavior looks like an unexpected side effect. Or maybe adding a new rule like "Remove Blank Line After YAML" will be a proper solution. I'll leave it to you to decide what needs to be done.
The regex worked thought, thanks! I didn't know Linter supports custom regex rules.

Gotcha. The custom regex is designed specifically for scenarios like this where the Linter has no options to change it and has been relatively consistent in what it means to do something (it is not always consistent) amd a different result is desired. Feel free to read the docs to see if there are other things like custom regex/replacement that would help out.

But to sum up my opinion on this, this sounds more like a feature request to change the logic of all blank line before logic to not add it right after the YAML frontmatter. Woukd that be a correct statement?

That's the thing. Most of other Spacing rules end with this sentence: "unless they start or end a document". Or "except where the heading is at the beginning or end of the document" for headings. Or "Math blocks that start a document do not get an empty line before them." is one of the examples for math blocks.
From what I see, the standard is to not add blank line at the beginning by any spacing rule except by "Add Blank Line After YAML".

And just to be specific, my testing shows that "beginning of the document" includes front matter. Just tested for both tables and code blocks and neither of them add a blank lane after front matter.

I just realized that I had your fix with regex in place when I tested. So I removed it and rechecked again.
And you're right: all spacing linters are adding the empty line after the frontmatter. Except for heading, and only because it has an option to configure this behavior called "Empty Line Between YAML and Header".
So yeah, I guess it could be considered a feature request then. Or closed since there's a fix with the regex available.
Thank you!

So there is also the following issue that does embody this feature request as well: https://github.com/platers/obsidian-linter/issues/926


General refactoring of the package

The package is badly conceived (no reason to store the inducing points).
These introduce these absolutely breaking changes

API consists of

inducingpoints(alg, X) for the offline setting returning a Vector of Vector
init(alg, X) and update!(Z, alg, X) for the online setting

RNG can be passed to all this methods
Improved the docs

Pull Request Test Coverage Report for Build 989642694

141 of 255 (55.29%)  changed or added relevant lines in 12 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+41.5%) to 55.294%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/offline/kmeans.jl
30
31
96.77%

src/online/oips.jl
57
58
98.28%

src/InducingPoints.jl
9
15
60.0%

src/offline/stddpp.jl
0
8
0.0%

src/offline/randomsubset.jl
0
11
0.0%

src/online/unigrid.jl
0
15
0.0%

src/online/webscale.jl
0
15
0.0%

src/utils.jl
4
20
20.0%

src/online/seqdpp.jl
0
17
0.0%

src/online/streamkmeans.jl
0
24
0.0%

Totals

Change from base Build 697435039:
41.5%

Covered Lines:
141

Relevant Lines:
255

💛  - Coveralls


#1-issue-create-delete-files

The only comment is you check errors like savage. Instead of string comparisons, you should check for return error codes from the operating system.


DataSet.to_array fails if included variables are added with label information

verify decorator is only able handling included list or str, not a dict

fixed and merged


Unable to use tritonclient.grpc

I'm trying to use tritonclient.grpc inside an mlserver model, but looks like they don't really go well with one another. python -c "import mlserver;import tritonclient.grpc" results in a Couldn't build proto file into descriptor pool: duplicate symbol 'inference.ServerLiveRequest' . I'm not a protobuf expert, but seems like both mlserver and tritonclient have protobuf-generated classes from identical (or maybe just similar?) OIP protos and they conflict with one another. Is there any way to work around this? For example, is it realistic for mlserver to use proto classes from tritonclient directly since it's a required dependency anyway?
I think another simpler solution might be changing package declaration in dataplane.proto from inference to something like inference_mlserver.

As far as I could tell, the one thing that package name change would affect is Prometheus metrics, package name is part of a key in metrics, I think.

Hey, thanks for the response. Unfortunately, I don't think it's that simple. The error happens even with top-level imports, I'm not trying to import anything message related specifically. For example running python -c "import tritonclient.grpc; import mlserver" leads to an error with the following stack trace:
File "<string>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/mlserver/__init__.py", line 2, in <module>
    from .server import MLServer
  File "/usr/local/lib/python3.9/site-packages/mlserver/server.py", line 17, in <module>
    from .grpc import GRPCServer
  File "/usr/local/lib/python3.9/site-packages/mlserver/grpc/__init__.py", line 1, in <module>
    from .server import GRPCServer
  File "/usr/local/lib/python3.9/site-packages/mlserver/grpc/server.py", line 9, in <module>
    from .servicers import InferenceServicer
  File "/usr/local/lib/python3.9/site-packages/mlserver/grpc/servicers.py", line 3, in <module>
    from . import dataplane_pb2 as pb
  File "/usr/local/lib/python3.9/site-packages/mlserver/grpc/dataplane_pb2.py", line 16, in <module>
    DESCRIPTOR = _descriptor_pool.Default().AddSerializedFile(
TypeError: Couldn't build proto file into descriptor pool: duplicate symbol 'inference.ServerLiveRequest'

I'm not exactly sure what this method (_descriptor_pool.Default().AddSerializedFile) does, but looks like it's registering symbols in some global namespace, which can't really be remedied with a simple import ... as ... statement, symbols are hardcoded in both libraries.

@lc525 hey, have you had an opportunity to look into this?


Sync keyboard navigation in SelectionList and PopoverMenu

Details
This PR fixes focusing on SelectionList and PopoverMenu items when navigating with tab button and arrows. Previously, these buttons worked independently, now only one item on the list is focused when navigating using them.
How it works without a fix:
https://github.com/Expensify/App/assets/47774969/2d8eb991-69fb-4833-b555-e1b0725efc79
Fixed Issues

$ https://github.com/Expensify/App/issues/36476#issuecomment-2020476802
PROPOSAL: N/A
Tests

[ ] Verify that no errors appear in the JS console

Verify that focusing on SelectionList items works properly:

Create a new workspace
Open Categories page
Navigate through the list of categories with tab and arrows and verify that only one element is focused.

Verify that focusing on PopoverMenu items works properly:

Open Workspaces section in Account Settings.
Click on the three dot menu on any workspace.
Navigate through the options of PopoverMenu with tab and arrows and verify that only one element is focused.

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/47774969/1f823b43-ebc2-476b-a7f2-dbf3aaf579eb

MacOS: Desktop

https://github.com/Expensify/App/assets/47774969/fc952122-990e-44be-ad25-73d282e6148e

I'm still investigating this bug that appears on mobile browsers, I'll let you know when it's ready to check :)

@fedirjh I believe that now it should work, but I'm not sure about bugs on Android:Native I can't reproduce that, for me Tab doesn't navigate on Native platforms. Issues that occur on mobile browsers have been resolved :)

We merged this to fix some bugs with the key arrow functionality, since this is a considerable refactor of similar logic, please make sure the bug doesn't show up here.

We merged this to fix some bugs with the key arrow functionality, since this is a considerable refactor of similar logic, please make sure the bug doesn't show up here.

In this PR I replaced ArrowKeyFocusManager wrapper with useArrowKeyFocusManager hook in BaseSelectionList, so to fix that issue I've added the isFocused prop to the hook and it seems to work fine :)
https://github.com/Expensify/App/assets/47774969/aebf393c-1fa0-4e15-a90c-1fd01ad6b7dc

conflicts

@WojtekBoman Could you please check the failing Reassure Performance Test?

Yes, I'll take a look at it. I'll let you know when it's ready :)

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Kicu has found a regression related to this PR. I've already prepared a fix for that: https://github.com/Expensify/App/pull/40234. You can find more details in the description of the attached PR

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.63-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Possible regression from here, can @WojtekBoman and @fedirjh , 👀 plz.
FAB – Blue frame appears when navigate via FAB menu using Up/Down keys

Another possible regression: https://github.com/Expensify/App/issues/40410


Endline Reqexp (#459)

Proposed changes
I raised this PR based on this issue, #459
I would like to add a new property endline to multiline log to support multiline_end_regexp in concat filter plugin.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I have read the CLA
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

would you also edit the values.yaml file for umbrella chart as well?

would you also edit the values.yaml file for umbrella chart as well?

I edited the umbrella chart also.

Thank you, looks good. Would you be also interested in adding test case for it? we have opened the pipeline for all

I would be happy to add a test case. I saw you are using rock1017/log-generator image to generate the logs. If we want to test it we need to generate logs that are bigger than 16k then the Docker will split up the logs entry. How can I contribute to this logs generator?

Is this one to be merged?


[AutoRelease] t2-servicebus-2023-02-02-72032(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/2985
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1031
BuildTargetingString
azure-mgmt-servicebus
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/2985


Tsj readme updates

On older versions of Ruby, the "Basic" example will not bootstrap as per the README instructions.  After local testing and debugging, this additional steps should get the project to build.  Additional testing was needed to resolve some transitive dependency issues.  Removing the explicit version requirements resolved everything and the example will run successfully.
The environment I tested on was:

macOS 12.6
RVM-based Ruby 2.6.6, 2.6.10, 2.7.5
Xcode 14.1, Build version 14B47b

For additional information on what I had experienced and tried, please see:

https://splunk.slack.com/archives/C01NC9JAC6L/p1667924064494629
https://splunk.slack.com/archives/C01NC9JAC6L/p1667994151268439

Codecov Report
Base: 97.67% // Head: 97.67% // No change to project coverage :thumbsup:

Coverage data is based on head (00ece66) compared to base (cdb14f5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   97.67%   97.67%
=======================================
  Files          27       27
  Lines         517      517
=======================================
  Hits          505      505
  Misses         12       12

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I can do this in a separate PR, but I think we really need to make clear this is an example for use of the agent which is not recommended.


SSL problem

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/urllib3/contrib/pyopenssl.py", line 488, in wrap_socket
    cnx.do_handshake()
  File "/usr/local/lib/python3.7/site-packages/OpenSSL/SSL.py", line 1828, in do_handshake
    self._raise_ssl_error(self._ssl, result)
  File "/usr/local/lib/python3.7/site-packages/OpenSSL/SSL.py", line 1566, in _raise_ssl_error
    _raise_current_error()
  File "/usr/local/lib/python3.7/site-packages/OpenSSL/_util.py", line 57, in exception_from_error_queue
    raise exception_type(errors)
OpenSSL.SSL.Error: [('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')]

I have a current openvpn pia connection too working correctly and the certificate seems to be the same so I don't know which certificate he's having problem to verify.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/urllib3/connectionpool.py", line 677, in urlopen
    chunked=chunked,
  File "/usr/local/lib/python3.7/site-packages/urllib3/connectionpool.py", line 381, in _make_request
    self._validate_conn(conn)
  File "/usr/local/lib/python3.7/site-packages/urllib3/connectionpool.py", line 978, in _validate_conn
    conn.connect()
  File "/usr/local/lib/python3.7/site-packages/urllib3/connection.py", line 371, in connect
    ssl_context=context,
  File "/usr/local/lib/python3.7/site-packages/urllib3/util/ssl_.py", line 386, in ssl_wrap_socket
    return context.wrap_socket(sock, server_hostname=server_hostname)
  File "/usr/local/lib/python3.7/site-packages/urllib3/contrib/pyopenssl.py", line 494, in wrap_socket
    raise ssl.SSLError("bad handshake: %r" % e)
ssl.SSLError: ("bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')])",)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/requests/adapters.py", line 449, in send
    timeout=timeout
  File "/usr/local/lib/python3.7/site-packages/urllib3/connectionpool.py", line 727, in urlopen
    method, url, error=e, _pool=self, _stacktrace=sys.exc_info()[2]
  File "/usr/local/lib/python3.7/site-packages/urllib3/util/retry.py", line 446, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='serverlist.piaservers.net', port=443): Max retries exceeded with url: /vpninfo/servers/v4 (Caused by SSLError(SSLError("bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')])")))

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "./PIAWireguard.py", line 337, in <module>
    r = requests.get(piaServerList)
  File "/usr/local/lib/python3.7/site-packages/requests/api.py", line 75, in get
    return request('get', url, params=params, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/requests/api.py", line 60, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/requests/sessions.py", line 533, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/lib/python3.7/site-packages/requests/sessions.py", line 646, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/requests/adapters.py", line 514, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='serverlist.piaservers.net', port=443): Max retries exceeded with url: /vpninfo/servers/v4 (Caused by SSLError(SSLError("bad handshake: Error([('SSL routines', 'tls_process_server_certificate', 'certificate verify failed')])")))

that's because your page serverlist is 404

Is your OPNsense up to date, might be the CA that PIA is using for that URL isn't in the cert store.
The server list url in the script is correct and I've just tested "https://serverlist.piaservers.net/vpninfo/servers/v4", loads fine and is signed by R3 Lets Encrypt

Yeah it's up to date to 21.1.3
And as I said an OpenVPN connection is already active to PIA. So I have been obligated to incorporate the certificate auth of PIA in the very store.
That s why I don't really understand why this error. And as I said also I ve compared the cert of your GitHub and the very I have in the instance and it's the same.
Any other ideas ?

"certificate auth of PIA in the very store" What do you mean, PIA doesn't use certificate authentication.
The HTTPS URL your having problems with isn't signed by PIA's internal CA, its signed by Lets Encrypt so that's not the issue.
Can you try curling the URL, see if that also has cert issues
curl https://serverlist.piaservers.net/vpninfo/servers/v4

very = cert obviously. Sorry I was on my phone at the time to write that message
an openvpn client wouldn't work without having the good certificate authority in the cert store, are we agreing on that? Because that's what I was telling you actually and that's what I thought the first part of the error message was about.
curl failed indeed:
curl: (60) SSL certificate problem: self signed certificate
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

Oh you also meant authority, usually authentication is short for auth. So it threw me off. Anyway that stuff you've done to get OpenVPN working with PIA isn't relevant for your issue at the moment.
Ok so you shouldn't be getting "SSL certificate problem: self signed certificate" when you try curl that, is something man in middling your traffic to that URL, the web server your getting the list from should be signed by Lets Encrypted as I stated in my last reply.
If you run the following command this time with -v so its verbose. curl -v https://serverlist.piaservers.net/vpninfo/servers/v4
What you should then see is the basic certificate information of the web server which should be the same as below verbose output from my opnsense.
I wonder what certificate your getting back, because clearly its not the right certificate.
* Server certificate:
*  subject: CN=serverlist.piaservers.net
*  start date: Dec 30 12:56:51 2020 GMT
*  expire date: Mar 30 12:56:51 2021 GMT
*  subjectAltName: host "serverlist.piaservers.net" matched cert's "serverlist.piaservers.net"
*  issuer: C=US; O=Let's Encrypt; CN=R3
*  SSL certificate verify ok.

Can you also ping serverlist.piaservers.net
So we can see what IP address resolves for you.

issue has gone stale, closing issue. Will re-open if response comes back.

Sorry for the delay I just had the time to actually act upon it.
So indeed you were right, there was a problem in my routing system, I forgot about a specific rule I had created in the beginning which was filtering this and put the firewall as the destination.
So my bad really.
Thanks again for pointing that to me.

No problem, I'm guessing you've got it up and running now?


Demo App Needs Better Missing-Camera Support

Galaxy Pocket Neo only has RFC. Demo app takes four pictures, duplicating the RFC pictures when asking for the missing FFC.
Probably need an extra indicating whether activity should fail if desired camera is not available, returning RESULT_CANCELED. Then have demo app use this and skip the FFC ones.

Addressed in v0.3.0.


Publish current version

npm wants current versions (lodash)

Hi,
this would be really great to eliminate deprecation warnings. Need help?
Cheers,
der leider

Thanks for the reminder. I just published the latest version. Hope that it is working as expected.

Thanks. BTW there are Even newer Deps available. Would be great if you do a clean "npm install", check the messages and then repeat with an npm outdated

Am 30.09.2016 um 23:22 schrieb Markus M. May<EMAIL_ADDRESS>Thanks for the reminder. I just published the latest version. Hope that it is working as expected.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Should be fine with version 0.5.1.
Please try and report back. I will close this issue in a couple of days, if I do not hear anything.


fs_watcher:给open系统调用添加提取路径参数信息还有文件描述符

Pull Request Template
Description/描述
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
此 pr 解决了什么问题
Fixes # (issue)
Type of change /PR 类型
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?/ 测试方式
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist/检查列表

[ ] My code follows the style guidelines of this project /代码规范检查
[ ] I have performed a self-review of my own code / 自己已经检查代码
[ ] I have commented my code, particularly in hard-to-understand areas / 有代码注释，尤其是关键代码
[ ] I have made corresponding changes to the documentation /变更内容同步到了文档中
[ ] My changes generate no new warnings / 变更没有新产生告警
[ ] I have added tests that prove my fix is effective or that my feature works /对修改代码添加了测试用例
[ ] New and existing unit tests pass locally with my changes / 对单元测试也同步更新了

增加进程ID，进程名等信息。

1、你的信息越提越少了，再增加一些用户需要了解的信息，例如pid、command以及文件打开饰演的分布情况等。
2、提交pr的时候按照规定的格式给pr起名，例如：fs_watcher：xxxxxx。

已经jian将师兄说的几个指标点加上了，新添加了comm、pid

下一步要将这些整合成为一个程序fs_watcher


[BUG] Issue with 'null' question and response API Response

Describe the bug
After clearing the context window, or opening vscode with the extension for the first time you'll see that clicking API Response will show null twice instead of not showing anything.
To Reproduce

Open vscode with extension loaded
Open the extension window
Click API Response

Expected behavior
Clicking API Response will not do anything if nothing is provided
Screenshots

Desktop (please complete the following information):

OS: Windows 11 Pro
VSCode version: 1.80.0-insider

in which file , those are there

can u assign me this?

File and code believed to be the issue
File: extension.js

Within lines 441-453
Description
The null is shown when using the ternary operator, instead of ignoring the operation. It prints null for the question and answer from the response.