[$500] [Not Implementing] Web - Chat - Clicking on unpin does not return cursor to conversation

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in with any account.
Open any conversation.
Click pin and unpin.

Expected Result:
Cursor in conversation should be appear when unpin is clicked.
Actual Result:
Clicking on unpin does not return cursor to conversation
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/236643857-5df847ad-f937-4fad-a9fe-4f8aa39789f0.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fb8588dfccface1a
Upwork Job ID:<PHONE_NUMBER>629089280
Last Price Increase: 2023-05-23

Proposal
Posting proposal early as per new guidelines
Please re-state the problem that we are trying to solve in this issue.
Web - Chat - Clicking on unpin does not return cursor to conversation
What is the root cause of that problem?
We are using Pressable for pin/unpin button as shown below:
https://github.com/Expensify/App/blob/d120f6a9aa13dc842e265202996f8fe32019faca/src/pages/home/HeaderView.js#L194-L199
So for onPress we are calling Report.togglePinnedState(props.report) at line 195 and there is not any code to set focus on composer, So upon button click it will toggle report state only and not do anything else. This is the root cause of the problem.
What changes do you think we should make in order to solve the problem?
When we press pin/unpin button, first we have to call Report.togglePinnedState() and then we have to set focus on composer as shown in updated code below.
 <Pressable
    onPress={() => {
        Report.togglePinnedState(props.report);
        ReportActionComposeFocusManager.focus();
    }}
    ....
>
   ...
</Pressable>

So this will solve the issue i.e. When pin/unpin button tap it will set focus to composer as shown in result video.
What alternative solutions did you explore? (Optional)
None

Results
https://user-images.githubusercontent.com/7823358/236664674-f59e5a44-ae98-4f62-9a6b-4395a442d502.mov

Proposal
Please re-state the problem that we are trying to solve in this issue.
The composer input field doesn't get refocused after the pin/unpin button has been clicked. Behaviour should be similar to when modals are closed.
What is the root cause of that problem?
The cause of this problem is that there's no case to handle this issue. To detect if modals are being closed across the app, we check for modal visibility before and after state updates here.
https://github.com/Expensify/App/blob/d120f6a9aa13dc842e265202996f8fe32019faca/src/pages/home/report/ReportActionCompose.js#L257-L263
What changes do you think we should make in order to solve the problem?

To fix this similar to the way it is done for modals, I suggest checking for the current and previous values of isPinned.
// We want to focus or refocus the input when the pin/unpin button has been clicked.
// We detect this click by checking if it was previously true/false
if (this.willBlurTextInputOnTapOutside && this.props.report.isPinned !== prevProps.report.isPinned) {
    this.focus();
}

Note: This takes care of preventing the keyboard from being opened unnecessarily on native platforms as well.

Screencast from 07-05-23 01:37:29 PM IST.webm
What alternative solutions did you explore? (Optional)

An alternative solution would be to use the focus() function in ReportActionComposeFocusManager as mentioned in a previous proposal.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Clicking on unpin does not return cursor to conversation
What is the root cause of that problem?
It is expected behavior of current code, since we don't have any code to handle focus when pin button is pressed.
What changes do you think we should make in order to solve the problem?
We should simply add
onMouseDown={e => e.preventDefault()}
``` to this pin button here
https://github.com/Expensify/App/blob/d120f6a9aa13dc842e265202996f8fe32019faca/src/pages/home/HeaderView.js#L194-L199
as we are doing all over the project to prevent losing focus.
One thing to note, if we rather add focus method inside onpress, composer will actual lose focus and refocus again, thus resulting in flickering effect.
### What alternative solutions did you explore? (Optional)

@PrashantMangukiya Thanks for the proposal. Since this is more a feature request than a bug there can be many valid RCA. Your RCA is valid. However the suggested fix is not what we are looking for since the focus will be lost already.

@therealsujitk Thanks for the proposal. Although you linked a good piece of code in your RCA, I think we follow that pattern only on modals where the focus would be actually shifted (forcely). This case is a little different.

@alitoshmatov Thanks for the proposal. Your RCA is correct. The suggested fix looks good to me. That's indeed how we prevent elements from loosing focus (as seen on send button, expand & collapse buttons, etc.).
:ribbon: :eyes: :ribbon: C+ reviewed
cc @Beamanator

Applied to the job, PR will be ready in couple of hours

Pr is ready - https://github.com/Expensify/App/pull/18643

Same issue was closed as not a bug after discussion.
There was already same solution if that issue wasn't closed.

Thanks @situchan!
@roryabraham We are proceeding with a solution here (calling preventDefault on mouseDown) since this is a pattern that we follow to prevent losing focus e.g. prevent losing focus on clicking the send button. Let us know if you think we should close this instead.

PR is ready. Will probably get merged on Monday.
Also @roryabraham for the above comment ^

@s77rt In my opinion, the issue @situchan linked (https://github.com/Expensify/App/issues/17538) is NOT the same as this issue. Here's why:

In this issue, we're talking about maintaining focus in the compose box when clicking a button that doesn't have any modal popup opening / closing
In the other issue, one problem was that device defaults were getting in the away, and we didn't want to introduce any "hacks" just to keep platforms consistent.

In this case, just "keeping focus on the compose box when clicking the Pin button" doesn't seem like it will have any unintended consequences, so I'm for moving forward with the PR (https://github.com/Expensify/App/pull/18643).
Thoughts before we move forward?

Discussing on Slack.

Closing after some discussion in Slack.

@tjferriss Even though we decided to close this issue, I think we should consider compensating @alitoshmatov and @s77rt since:

@alitoshmatov created the PR: https://github.com/Expensify/App/pull/18643
@s77rt did all the tests (https://github.com/Expensify/App/pull/18643#issuecomment-1540672721) and review

I'd propose we compensate $500 each since this was quite a small change & small PR, and we ended up not implementing the solution. Thoughts?

@tjferriss Applied!

@tjferriss Can we close this?

@s77rt I just sent you an offer. Once accepted, I can pay and close the issue.

@tjferriss Accepted!
We still need to pay @alitoshmatov

Yes, you've both been paid now.


Docs: Add needed permissions in case of an unpriviliged workflow/token

Hi,
if a repo uses a resticted access it is neccessary to explicitely add permissions to use this action. Reading the code I guess in your case it is:
jobs:
  update_changelog:
    permissions:
      contents: write # <-- This one

I'll try it out as soon as I can. But can you confirm that?

This is probably related to a recent change by GitHub where the GITHUB_TOKEN is read-only on new repositories.
https://github.blog/changelog/2023-02-02-github-actions-updating-the-default-github_token-permissions-to-read-only/
I'm gonna update the documentation very soon.

Yes, I forgot to mention that I experienced this one one a newly created repo. The defaults are now more restrictive.


packagecloud_repo sets up repository with wrong baseurl

packagecloud_repo sets repository with URL that is not longer valid
  packagecloud_repo "basho/riak-cs" do
    type "rpm"
  end

<IP_ADDRESS>] out:     ================================================================================
[<IP_ADDRESS>] out:     Error executing action `add` on resource 'packagecloud_repo[basho/riak-cs]'
[<IP_ADDRESS>] out:     ================================================================================
[<IP_ADDRESS>] out:
[<IP_ADDRESS>] out:     Mixlib::ShellOut::ShellCommandFailed
[<IP_ADDRESS>] out:     ------------------------------------
[<IP_ADDRESS>] out:     execute[yum-makecache-basho_riak-cs] (/root/.chef/local-mode-cache/cache/cookbooks/packagecloud/providers/repo.rb line 116) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1'
[<IP_ADDRESS>] out:     ---- Begin output of yum -q makecache -y --disablerepo=* --enablerepo=basho_riak-cs ----
[<IP_ADDRESS>] out:     STDOUT:
[<IP_ADDRESS>] out:     STDERR: https://packagecloud.io/basho/riak-cs?dist=6&os=el/el/6/x86_64/repodata/repomd.xml: [Errno 14] PYCURL ERROR 22 - "The requested URL returned error: 404 Not Found"
[<IP_ADDRESS>] out:     Trying other mirror.
[<IP_ADDRESS>] out:     https://packagecloud.io/basho/riak-cs?dist=6&os=el/el/6/x86_64/repodata/44e90c5b41198c3dd6bfbd30f99651d05a2eb128-filelists.xml.gz: [Errno 14] PYCURL ERROR 22 - "The requested URL returned error: 404 Not Found"
[<IP_ADDRESS>] out:     Trying other mirror.
[<IP_ADDRESS>] out:     Error: failure: repodata/44e90c5b41198c3dd6bfbd30f99651d05a2eb128-filelists.xml.gz from basho_riak-cs: [Errno 256] No more mirrors to try.
[<IP_ADDRESS>] out:     ---- End output of yum -q makecache -y --disablerepo=* --enablerepo=basho_riak-cs ----
[<IP_ADDRESS>] out:     Ran yum -q makecache -y --disablerepo=* --enablerepo=basho_riak-cs returned 1

Instead of baseurl=https://packagecloud.io/basho/riak-cs?dist=6&os=el/el/6/$basearch the baseurl should be https://packagecloud.io/basho/riak-cs/el/6/$basearch.
Also, to reduce the complexity, something like following could be used as well:
  yum_repository "basho_riak-cs" do
    description "Riak CS Package Repo"
    url "https://packagecloud.io/basho/riak-cs/el/6/$basearch"
    gpgkey "https://packagecloud.io/basho/riak-cs/gpgkey"
    metadata_expire "1"
  end

Not seeing this issue any more.


Performance lag with GestureDetector on Windows

Details

My App using GestureDetector to move widgets, but it lags & missing frames causing UX bad
I made two simple samples to check this issue:
a. widget only changes position, flutter performance has some peak but is acceptable with eyes' view

class _MyHomePageState extends State<MyHomePage> {

  Offset _TestOriOffset = Offset(500, 200);
  Offset _TestOffset = Offset.zero;
  Size _TestSize = Size(100, 100);
  num theta = 0;

  @override
  void initState() {
    // TODO: implement initState
    super.initState();

    Timer.periodic(Duration(milliseconds: 10), (timer) {
      setState(() {
        theta += pi / 50;
        if(theta >= 2 * pi) theta -= 2 * pi;

        _TestOffset = Offset(
            200 * cos(theta) + _TestOriOffset.dx,
            200 * sin(theta) + _TestOriOffset.dy);
      });
    });
  }

  @override
  Widget build(BuildContext context) {

    return Scaffold(
      body: Center(
        child: Stack(children: [
          Positioned(
            top: _TestOffset.dy,
            left: _TestOffset.dx,
            child:
            Container(
                  width: _TestSize.width,
                  height: _TestSize.height,
                  color: Colors.red,
                ),
          ),
        ]),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

b. change widget position by GestureDetector and keep moving widget manually, flutter performance has period peaks and causes missing frames to lead the widget distance jump.
class _MyHomePageState extends State<MyHomePage> {

  Offset _TestOffset = Offset.zero;
  Size _TestSize = Size(100, 100);
  num theta = 0;

  @override
  Widget build(BuildContext context) {

    return Scaffold(
      body: Center(
        child: Stack(children: [
          Positioned(
            top: _TestOffset.dy,
            left: _TestOffset.dx,
            child: GestureDetector(
              onPanStart: (details) {
                _TestOffset = Offset(
                    details.globalPosition.dx - _TestSize.width / 2,
                    details.globalPosition.dy - _TestSize.height / 2);
              },
              onPanUpdate: (details) {
                _TestOffset = Offset(
                    details.globalPosition.dx - _TestSize.width / 2,
                    details.globalPosition.dy - _TestSize.height / 2);
                setState(() {
                });
              },
              child: Container(
                width: _TestSize.width,
                height: _TestSize.height,
                color: Colors.red,
              ),
            ),
          ),
        ]),
      ),
    );
  }
}

record video: https://youtu.be/048j73xUvPQ

Target Platform: Windows
Target OS version/browser: Windows 10
Devices: Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz   2.81 GHz / 32.0 GB
Logs

Logs

flutter analyze with no error

[✓] Flutter (Channel stable, 3.3.4, on Microsoft Windows [版本 10.0.19045.2846], locale zh-TW)
    • Flutter version 3.3.4 on channel stable at D:\Sdks\flutter\fvm\3.3.4
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision eb6d86ee27 (7 months ago), 2022-10-04 22:31:45 -0700
    • Engine revision c08d7d5efc
    • Dart version 2.18.2
    • DevTools version 2.15.0

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.4)
    • Visual Studio at D:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30517.126
    • Windows 10 SDK version 10.0.19041.0

[!] Flutter IDE Support (No supported IDEs installed)
    • IntelliJ - https://www.jetbrains.com/idea/
    • Android Studio - https://developer.android.com/studio/
    • VS Code - https://code.visualstudio.com/

[✓] Connected device (1 available)
    • Windows (desktop) • windows • windows-x64 • Microsoft Windows [版本 10.0.19045.2846]

[✓] HTTP Host Availability
    • All required HTTP hosts are available

Hi @herehere
I check this issue on Windows but can't see jank frames as in your demo video. Can you retry on the latest master channel to see if the issue still persists or not?

flutter doctor -v (stable & master)
[√] Flutter (Channel stable, 3.10.0, on Microsoft Windows [Version 10.0.19045.2846], locale en-US)
    • Flutter version 3.10.0 on channel stable at C:\WIP\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 84a1e904f4 (3 days ago), 2023-05-09 07:41:44 -0700
    • Engine revision d44b5a94c9
    • Dart version 3.0.0
    • DevTools version 2.23.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\AndroidSDK
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = C:\AndroidSDK
    • Java binary at: C:\Program Files\Android\Android Studio Electric Eel 2022.1.1\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.4.4)
    • Visual Studio at D:\DOWNLOADWORK\VS2022
    • Visual Studio Community 2022 version 17.4.33213.308
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio Electric Eel 2022.1.1
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[√] VS Code (version 1.78.1)
    • VS Code at C:\Users\ADMIN\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.62.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.2846]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 112.0.5615.140
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 113.0.1774.35

[√] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.11.0-5.0.pre.48, on Microsoft Windows [Version 10.0.19045.2846], locale en-US)
    • Flutter version 3.11.0-5.0.pre.48 on channel master at C:\WIP\flutter_master
    ! Warning: `flutter` on your path resolves to C:\WIP\flutter\bin\flutter, which is not inside your current
      Flutter SDK checkout at C:\WIP\flutter_master. Consider adding C:\WIP\flutter_master\bin to the front of your
      path.
    ! Warning: `dart` on your path resolves to C:\WIP\flutter\bin\dart, which is not inside your current Flutter SDK
      checkout at C:\WIP\flutter_master. Consider adding C:\WIP\flutter_master\bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5e459380c1 (3 hours ago), 2023-05-11 22:53:01 -0400
    • Engine revision ef5c349f04
    • Dart version 3.1.0 (build 3.1.0-94.0.dev)
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git"
      directly to perform update checks and upgrades.

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\AndroidSDK
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = C:\AndroidSDK
    • Java binary at: C:\Program Files\Android\Android Studio Electric Eel 2022.1.1\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.4.4)
    • Visual Studio at D:\DOWNLOADWORK\VS2022
    • Visual Studio Community 2022 version 17.4.33213.308
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio Electric Eel 2022.1.1
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[√] VS Code (version 1.78.1)
    • VS Code at C:\Users\ADMIN\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.62.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.2846]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 112.0.5615.140
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 113.0.1774.35

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

I tested on stable 3.10.0 in this simple project, it looks acceptable with no missed frame. But in some complex cases, it still misses frames. I think there is something that can enhance both our project & framework. As this simple sample is no problem, I think this issue can be closed.

Thanks for your update. Mark the issue as fixed on the latest stable channel.
Once you see the issue again, please provide a minimal sample code along with timeline trace JSON file as well. You can find the instructions for it in this issue https://github.com/flutter/flutter/issues/74833.


Make Message.hashCode Consistent with Message.equals

Fixes https://github.com/google/guice/issues/940
This commit makes Message.hashCode and Message.equals computed off of the same fields.

Have you measured the performance effect of this?

@tavianator - yes, for the case I was describing above. Inserting single Message objects is no longer significant as the number of messages grows. I can post some repro code and results.
The actual implementation of Message.hashCode will be slower but I'm not sure that's a very helpful measure. Maybe I can provide the breakeven point in number of Messages when the slow insertion overtakes the time spent in individual hashCode calls?
Are there other specific benchmark cases you think it would make sense for me to measure? Happy to post results for those as well.
Will try to put something together by the weekend (I don't have much time for it during the work week).

I tested out two things related to performance. For the sake of being thorough I just timed the hashCode implementation and as expected the new one is slower. On my machine (1.3GHz Intel i5) 100 million calls of the current implementation is 237 millis. With the new implementation and a source list size of 10 (a bit arbitrary, but didn't seem unreasonable after logging in a real application) 100 million calls is 5320 millis. That's a large percentage increase but still, in nanosecond territory per call. So I'd argue that in any practical application it should not matter.
The second thing I did was time a simpler version of what was happening in the production codebase where I saw the original issue: each time a new Message was created with a unique Throwable it was merged with all prior Messages in an immutable set. I ran the test over a range (log scale) of set sizes. Somewhere between 128 and 256 Messages in the set is where it breaks even.
  MessageCount OldHashCodeMillis NewHashCodeMillis
1           32                 3                 5
2           64                 9                11
3          128                15                21
4          256                77                33
5          512               176               103
6         1024              1287               130
7         2048              7995               372

The red line below is the timings with the old implementation, the blue line with the new.

The timing code is pretty trivial: just a run to get rid of JIT overhead and then a loop to measure the hash code time or to build sets of a certain size..
These message counts are large for any normal use case, but going back to the original issue: when stuck in an infinite cycle of exceptions during dependency resolution in a production situation, this made understanding the current state of an application difficult since the application was spending the majority of its time inserting Message objects into a hash set.
Happy to look at specific cases where this change might be considered risky.


pre-commit: pylint pre-commit check for azure-ai-ml

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

Not sure why this PR was closed. @needuv, what do you think of this idea? I like it personally.


looks like %foo cannot be used as a path part

Test would be:
%foo.spt
And:
http://localhost:8080/%foo
Then:
assert request.path['foo'] == %foo` fails

I think you should instead use the URL http://localhost:8080/%25foo ; percent is the URL escape character.

...and if you do use /%25foo, you'll find it works fine.  Not a bug.


[Bug] VNI key error... when there should not be

I have another user with the same problem, but can' reproduce the issue.
Can you zip(!) and attach the file here?
I assume it is some encoding problem.

DmdDevice.zip

Fixed with 3.0.1


dist folder wasn't properly rebuilt for v1.2.1

i don't see any of the fallbackFunc stuff in there

Shame on me! :hand: Thanks!


There is no package to validate

My package seems to have hit a bug in the validator which is preventing it from being approved/listed.
Something went very wrong. There is no package to validate. Please contact the site admins for next steps.

This is the stuck version: https://chocolatey.org/packages/carina/1.5.0

It means there was an issue when you pushed the package. It basically doesn't exist on our servers and you should repush it again. HTH, and we probably need to update that message.

Added


[Bug] 2.5.4 Language option swiching does not work properly. Package creation fails

Describe the bug
The interface of Valkyrie does not switch to the language option selected in the language option menu. The translated scenarios in the editor do show their translated titles.

Scenario
n.a.

Steps to reproduce the behavior:

Start Valkyrie in English language option
change language option to Spanish
See error-->intferace does not change to Spanish, scenario list in the editor does show Spanish titles.

ADDITIONAL OBSERVATION: starting from Spanish seem to work properly ???

Start Valkyrie in English Spanish language option
change language option to English
interface changes properly
switching to any other language also seems to work properly.
this may mean that the problem is limited to the startup app in English, but this is not confrimed.

Expected behavior
interface language should ALWAYS follow selected language

Screenshots

Valkyrie Version
2.5.4

Desktop

OS: Windows
Browser chrome
Version 10

Additional context

This bug also prevented the creation of a package where I added Spanish to scenario Possessed, only the (default) English adjustments were taken into the package. All Spanish additions were ignored.
In a second attempt I managed to bypass this issue by restarting the app in Spanish, Create the new package. This way, without any other modification to scenario files, seemed to produce content WITH the new Spanish translation.

Tested on 2.5.2.a
Language switching in the editor seems to be in order.
Test steps executed:

English start-up then switch to another language -> interface updated properly
Exit App in the 'other' language, restart the app and it comes back up properly in the same 'other language'.
Create a package in  'other  language' -> output looks good
Switch back to English-> Interface updates nicely
create a package with English (my default) -> Outputlooks good.

Test successful, and the result looks OK. Well done!
This issue seems ready for release. Closing the issue.


examples: gather all simple "backend adapter" example into one

We should think on how we want to structure ezamples. Having the same vite app like 10 times hurts CI time a looot, especially from forks that cant use the remote cache.

I wonder if a single vite app "connecting" to localhost:3000 and then all the backend adapters can be like 2 files 🤔 food for thought.

Really it could even just be a single example with a single router, and then just a bunch of different `dev:hono`, `dev:fastify` scripts that starts a different server 🤔

Originally posted by @juliusmarminge in https://github.com/pingdotgg/uploadthing/pull/364#pullrequestreview-1630084630

I'm thinking something like:
examples/
  backend-adapters/
    client/ # a vite react app that proxies /api to localhost:3000
    server/
      src/
        router.ts # a single upload router
        express.ts # an express server
        fastify.ts # a fastify server
        elysia.ts
        ...

then have scripts like dev:elysia which starts the vite app and the elysia server.
this should greatly reduce the concurrency limit for turbo which is slowing down CI significantly right now


ꕥ10000ꕥFREE TIKTOK FOLLOWER GENERATOR GET FREE TIK-TOK LIKES

Unlock the secret to skyrocketing your TikTok presence with our exclusive guide on getting FREE TikTok Followers! In this enlightening video, we reveal proven strategies to boost your follower count by over 5000, ensuring your content reaches a wider audience and garners more engagement. Whether you're an aspiring creator looking to expand your reach or a seasoned TikTok star aiming for greater influence, our comprehensive guide covers essential tips for success on both iOS and Android platforms. Elevate your TikTok game, follow our step-by-step instructions, and witness your follower count soar to new heights in 2024. Don't miss out on this opportunity - like, share, and subscribe for more invaluable insights and updates!
🔴📺📱👉 Click here free gift cards
🔴📺📱👉 Click here free gift cards
followers on TikTok, tired of downloading countless apps, or completing the tasks – you’ve come to the right place. Tried, tested, and proven by thousands of users, PubTok has been long known for its best quality likes and views given away for free.
Free Tiktok Follower (100000 free tiktok followers) - Tik Tok Followers Free - Free Tiktok Likes app fast fans followers TIK-TOK can help Free Tiktok Fans FREE Tiktok Followers And Likes Generator ( 100000 free tiktok followers) - Tik Tok Followers Free - Free Tiktok Likes app fast fans followers Tik Tok Followers Free - Free Tiktok Likes app fast fans followers TIK-TOK can help you to get the very first fans for the TIK-TOK videos, you will get to the key page and attract more followers.
Important! You can place only one order per day, and will not be able to receive both likes and followers or views and followers for free, or place another free order until the 24 hours have passed. We suggest you explore our paid options or complete a couple of surveys as an alternative option to get an additional number of followers, likes, or views for TikTok.
TikTok has become one of the major social media platforms in the world. It has an audience from all age groups, but young users such as teens are the majority. What makes TikTok different than others is its type of content. Like Vine, TikTok is heavily focused on short videos. On TikTok, everyone has a personal profile, just like other social media platforms. Again like other platforms, users can like, comment, and share others' content. They can also follow accounts that they think are interesting. People with original content are more likely to be more visible and discovered by many people. Your videos can be of good quality as well. However, it is not always enough.
TikTok Followers Generator (2024) You'll reach 899 in much less time. Free Tiktok Followers Generator 2024 No Human Verification. Tiktok Free Followers Generator Unlimited Free Tiktok Followers.Free Tiktok Likes 2024.https://github.com/elementor/elementor/pull/1 TikTok Followers Generator! Grow your TikTok account with FREE and REAL followers NOW!Free TikTok Followers, Fans and Likes. Get up to 20k TikTok Followers for Free daily, all you need is your 899name.


ReferenceError: ClassyTestCase is not defined

Hello, after upgrading to latest Computed Field package I'm getting the following error:
ReferenceError: ClassyTestCase is not defined
Any advice?
Thanks,
Kris

That was some strange Meteor publish error. I republished it as 0.5.1 and it works now.
Thanks for the report.

Thanks for the quick fix! :)

@mitar Thanks, you're fast! :-)
Now I'm getting this though (Meteor.1.3):
/tmp/cf-error (master)*$ meteor add<EMAIL_ADDRESS> => Errors while adding packages:

While selecting package versions:
error: Conflict: Constraint<EMAIL_ADDRESS>is not satisfied by coffeescript 1.1.2_1.
Constraints on package "coffeescript":
*<EMAIL_ADDRESS><- top level
*<EMAIL_ADDRESS><- peerlibrary:computed-field 0.5.1

Yes, @realyze, this package requires Meteor 1.4. I do not know why, but it seems Meteor has issues releasing with old versions in the package, so I had to bump all constraints to 1.4. :-(


Concurrency support using model clone

Support for execution with multi concurrency

Adding clone operation to model objects which creates new execution context without duplicating compiled_model and memory usage. It enables multi-concurrency in multithreaded applications.
request attribute is now deprecated - new attributes compiled_model and infer_request are added instead - they match OpenVINO objects
improved performance for decoder models by eliminating creating new requests for each inference

Before submitting

[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

This PR is a replacement for https://github.com/huggingface/optimum-intel/pull/519

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


CTD after speaking to Hrothgar and walking away from house.

Burned house quest Morthal

Okay so these crashes are happening so often because there's was a windows 10 update lol. I will now close them


use NextAuth

Description
For a simple auth system we could use a SQLite database for the users. I'm not sure how having multiple users could work
we could make it so one user has one config but then we'd need to make it so :

public configs belongs to a user, need to login as them to make them editable.
private configs needs the password of the user they belong to to get unlocked

Please tick the boxes

[X] You've read the docs
[X] You've checked for duplicate issues

#557 I think next versions should have a password forced on them. We need to make the user choose an admin password on the first launch and enable password protection with it. Then public configs #259 would be accessible by anyone but not editable unless logged in as admin.
Not sure if we will implement a user system tho. It might be too much work

Please wait with such decisions until our survey is completed

Done in v0.14.0


Add cookie pop-up

The site uses now cookies from Google Analytics, and I think it will make the site more professional to have a little pop-up at the right corner of the site

✖

 This site uses two little cookies from Google.

Cookie pop-up maybe needs a little more JS, to make it appear on every pages and only the first time.


Create visual of CNN structure.

Figures generated using Net2Vis
Future iterations could be made later.

Figures in figures/net2vis


ERROR on Binding MT4 Server to Socket

I'm getting this error:
DWX_ZeroMQ_Server_v2.0.1_RC8 EURUSD,H4: [PUSH] ####ERROR#### Binding MT4 Server to Socket on Port 32769..  when starting the DWX expert.
Here is a screenshot of the log:

these are the inputs initialization:

Publish_MarketData was manually added to the input context adding extern keyword in the code

Hi,
Thank you for raising this point. When there is an error on exiting the EA, there might be issues with connecting to the sockets again. In most cases a restart of MT4 (or if that does not help a restart of the PC or VPS) helps.
We are currently working on an alternative to the ZeroMQ connector, which will not have dependencies on sockets and third party software anymore and hopefully reduce the number of issues.

Hi,
Thank you for raising this point. When there is an error on exiting the EA, there might be issues with connecting to the sockets again. In most cases a restart of MT4 (or if that does not help a restart of the PC or VPS) helps.
We are currently working on an alternative to the ZeroMQ connector, which will not have dependencies on sockets and third party software anymore and hopefully reduce the number of issues.


fix: add ExternalLink

This PR was deployed with mocked data in the following URLs for your appreciation:

Storybook: https://fabric8-launcher-frontend-pr-1329-storybook.surge.sh


Downloading the archive of the resource (files | folder) using resource path is not possible

Describe the bug
When downloading the archive of resource (files | folders) using the resource path (full path of the resource) , the response status is 404.
Steps to reproduce
Steps to reproduce the behavior:

create user user
create a file file.txt
download the archive of the file file with the command below

Curl Command to download the file.
curl -X GET -vk -u user:123456 https://host.docker.internal:9200/archiver?path=file.txt

Expected behavior
Should be able to download the archive of the text file. (with Response status code 200)
Actual behavior
TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* Mark bundle as not supporting multiuse
< HTTP/1.1 404 Not Found
< Content-Length: 27
< Content-Type: text/plain; charset=utf-8
< Date: Thu, 22 Sep 2022 10:09:53 GMT
< Vary: Origin
<
* Connection #0 to host host.docker.internal left intact
error: not found: file.txt%

Setup
OCIS : latest pulled docker image
NOTE:
If anyone could provided the correct URL to download or get the resource.
if its https://host.docker.internal:9200/archiver?path=file.txt like this or
https://host.docker.internal:9200/archiver?path=/home/file.txt or other?

@kobergj I think you have added the related tests to expected to fail file, could you clarify if this actually should work or not

@butonic Does path based archiver requests work at all?

looks like both path and id query params are allowed. But providing path=foldername returns 404
https://github.com/cs3org/reva/blob/774910f82ee098c8b5ceb3457d1678245d20b137/internal/http/services/archiver/handler.go#L224-L230
		v := r.URL.Query()

		paths, ok := v["path"]
		if !ok {
			paths = []string{}
		}
		ids, ok := v["id"]

https://github.com/cs3org/reva/blob/774910f82ee098c8b5ceb3457d1678245d20b137/internal/http/services/archiver/handler.go#L144-L151
	for _, p := range paths {
		// id is base64 encoded and after decoding has the form <storage_id>:<resource_id>

		resp, err := gatewayClient.Stat(ctx, &provider.StatRequest{
			Ref: &provider.Reference{
				Path: p,
			},
		})


Swift 4.2 and upper

Hi, thanks for the library, could you please update It for higher swift versions as well?

yes please update the library

Thank you for raising the issue. The library has been updated to Swift 5.0 in version 3.0.0.

thanks you soo much


unc0ver 8.0.2 ios 14.4 kernel panic doing anything

Describe the bug
Constant random reboots doing literally anything
To Reproduce
Steps to reproduce the behavior:

There is no way to reproduce the error as it happens doing anything! Switching through apps, browsing the web, taking a photo, watching a video, even on IDLE it will reboot itself!

Screenshots

These are crash logs all from the same day!!
Device (please complete the following information):

iOS Version: 14.4
iOS Device: iPhone XS
unc0ver Version:  8.0.2

Place an "x" between the brackets if true:

[ ] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

Logs
Note Sep 10 2022 at 11_30_28 AM.txt
Note Sep 10 2022 at 11_32_31 AM.txt
Note Sep 10 2022 at 11_33_45 AM.txt
Note Sep 10 2022 at 11_34_44 AM.txt
Note Sep 10 2022 at 11_35_59 AM.txt
here is also my tweak list that I’ve been using for months without error

Note 2022-09-09 22-14-11.txt

Note Sep 10 2022 at 12_03_29 PM.txt

Note Sep 16 2022 at 3_13_11 PM.txt
Note Sep 16 2022 at 4_32_19 PM.txt
Note Sep 16 2022 at 4_32_57 PM.txt

Were you able to fix this?


showing multiple entries where it says "5" deleting saying

Please describe the issue you are having here and answer the question below.
This same issue seems to come back.. This happens when:

entering a saying with an action already selected in display box. In this case, the "get order" action was pre selected.
entering the saying
hiting the trash icon.

Will then display 10 sayings showing "entires" is 5. Hiting the next button brings screen back to normal.
Reproduced with same results.

Did you download a release or pull from Master? Which release?
29.0
What operating system are you running?
10 pro
Are you running locally or in the cloud?
local
Which browser are you using?
FF

Closed by 752775c6fdf604f20cc1d0dae153573021646a74


Icons Not Displaying After Latest Update

Updated the extension to the latest version this morning and icons no longer show up. I'm running VS Code 1.3.1 (latest) on Windows 10 Pro 64-bit. Tried uninstalling the extension and reinstalling but still no luck. Icons showed up fine before applying the latest update.

Same here, VS Code 1.3.1 on OS X.  I also tried uninstalling and reinstalling but still no icons. My VS Code looks so boring now :(

+1 I tried running as administrator, but nothing has changed.
VS Code version: 1.3.1
OS: Windows 10 Pro 64bit

@futuremint This is not related.
As for your problem I had the same issue, the way to make them back is to make sure the plugin is enabled and then press F1 and do "Icons Enable", it will reboot vscode with the icons now on.

That did the trick for me. But first open VS Code as Administrator, then F1 "Icons Enable", restart VSC, fixed.

@MLefebvreICO Thanks, that worked.

Please, see #78, #79, #80, #81 and #82

should we add a FAQ Markdown File for questions like this?

@jens1o, that's right. I thought that the current docs are more or less ok but this issue leads me to think your way.

@jens1o I've just published another version with some basic faqs in the readme.

@michaelmaw not work for me :( ,
win 10
vsc 1.3
vsicon 1.4.3

Are there any errors in console?
Could you open a new issue?

@jens1o no error.
Is important to create new issue?

@mammad2c have you tried the FAQs? The usual procedure is to reinstall your VSCode from scratch, then F1 and "Icons Enable". If that's not working, then try "Icons Update". If still not working and no console errors present we'll have to dig into it. Usually, people is behind a proxy (see #21) but this case leaves some errors in the Dev Console. Please, let me know! :wink:

@robertohuertasm  i did the FAQs and i got theese error:

i fixed it with set :
"http.proxyStrictSSL": false,` from issue 21
and downloaded the project and extracted icons folder in appropriate folder.

@michaelmaw It is work for me ,thanks

File -> Preferences -> File Icon Theme -> VSCode Icons


Native subheader

A subheader or subtitle using native component.
A lot of apps have this functionality at the moment.

+1

+1


Inspector - Show offline dates against databases set offline.

When a database is set to offline it normally shows in the error log, but as the collection for the inspector runs daily it could be possible to add the collection date of the first occurrence of a database showing a state of OFFLINE, this date could then persist for the duration of the database being offline so that you have a record of when the database was recorded as being offline (by the collection).
If the state changes from offline then the date can be removed and report as normal.
e.g.
OFFLINE  SQLDB (Since 09 mar 2018)

Easy enough to add the date but will not fit i nicely with the existing logic as we would not want to be deleting this row when the next collection comes around, the row needs to be preserved if still offline so that the date is retained.
Closing this for now , may re open if I can find a neat way to implement it without having to add lots of new logic.


Separate GPU kernel for broadcast_axis

Description
Separate GPU kernel with cached stride calculations and shape data to improve performance.

passing mshadow::Shape slowed the kernel speed by approx 15% so passed it separately in a struct.
unroll gives boost of about 4%
major chunk of improvement by caching stride calculations and combining 2 redundant multiplications

This change is done in order to maintain BERT performance when large tensor is enabled by default.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
[x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Testing
ubuntu@ip-172-31-0-156 ~/workspace/incubator-mxnet (typedef) $ MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/python/gpu/test_operator_gpu.py:test_broadcast

[DEBUG] 1000 of 1000: Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1707871653 to reproduce.
ok

----------------------------------------------------------------------
Ran 1 test in 1772.105s

OK

Results
Profiling Code:
import mxnet as mx
import mxnet.ndarray as nd
from benchmark.opperf.utils.benchmark_utils import run_performance_test

#local_ctx = mx.cpu()
local_ctx = mx.gpu()

add_res = run_performance_test(nd.broadcast_axis, run_backward=True, dtype='float32', ctx=local_ctx,
                               inputs=[{'data': (10, 1, 10, 1), 'axis': (1, 3), 'size': (1000, 5000)}],
                               warmup=50, runs=500, profiler='python')
print(add_res)

add_res = run_performance_test(nd.broadcast_axis, run_backward=True, dtype='float32', ctx=local_ctx,
                               inputs=[{'data': (100, 1, 1, 10), 'axis': (1, 2), 'size': (1000, 500)}],
                               warmup=50, runs=500, profiler='python')
print(add_res)

add_res = run_performance_test(nd.broadcast_axis, run_backward=True, dtype='float32', ctx=local_ctx,
                               inputs=[{'data': (1, 1, 1, 1), 'axis': (0, 1, 2, 3), 'size': (10000, 10, 100, 50)}],
                               warmup=50, runs=500, profiler='python')
print(add_res)

add_res = run_performance_test(nd.broadcast_axis, run_backward=True, dtype='float32', ctx=local_ctx,
                               inputs=[{'data': (1, 10, 1, 10, 1), 'axis': (0, 2, 4), 'size': (200, 1000, 50)}],
                               warmup=50, runs=500, profiler='python')
print(add_res)

code version
cases
avg
p50
p90

master LT
(10, 1, 10, 1) -> (10, 1000, 10, 5000)
65.75
65.71
65.82

(100, 1, 1, 10)->(100, 1000, 500, 10)
64.65
64.57
64.68

(1, 1, 1, 1)->(10000, 10, 100, 50)
46.61
46.54
46.64

(1, 10, 1, 10, 1)->(200, 10, 1000, 10, 50)
128.52
128.49
128.71

master no-LT
(10, 1, 10, 1) -> (10, 1000, 10, 5000)
28.42
28.37
28.45

(100, 1, 1, 10)->(100, 1000, 500, 10)
27.38
27.30
27.37

(1, 1, 1, 1)->(10000, 10, 100, 50)
20.48
20.35
20.41

(1, 10, 1, 10, 1)->(200, 10, 1000, 10, 50)
53.68
53.57
53.74

new LT
(10, 1, 10, 1) -> (10, 1000, 10, 5000)
27.24
27.10
27.18

(100, 1, 1, 10)->(100, 1000, 500, 10)
25.42
25.34
25.40

(1, 1, 1, 1)->(10000, 10, 100, 50)
14.99
14.83
14.93

(1, 10, 1, 10, 1)->(200, 10, 1000, 10, 50)
51.66
51.80
51.90

new no-LT
(10, 1, 10, 1) -> (10, 1000, 10, 5000)
22.18
22.10
22.18

(100, 1, 1, 10)->(100, 1000, 500, 10)
20.28
20.27
20.32

(1, 1, 1, 1)->(10000, 10, 100, 50)
12.73
12.69
12.73

(1, 10, 1, 10, 1)->(200, 10, 1000, 10, 50)
40.21
40.11
40.28

@mxnet-label-bot add [pr-work-in-progress]

Based on your PR description, the only difference between CPU and GPU kernel is that GPU kernel uses int32_t for indexing and CPU kernel uses int64_t (when large tensor compiler flag is on) for indexing, duplicating the kernel implementation into two structs seems an overdo to me. Could we optimize the code such that they still share the same kernel template but with different index_t type? Also it will be nice to re-architect the code so that it applies to all operators that share the same template between CPU and GPU kernels.

@apeforest
We cannot use typedef based on xpu because typdef is compile time option. The blast radius is large if we make generic CPU/GPU kernel. Numpy ops that call broadcast_axis kernel for their internal operations need to be updated as well, so i created broadcast_axis_gpu for ops relying only on BroadcastComputeImpl internally which is evident from 43 GPU failing tests when temp workspace was used.
Hence, 2 structs are not overdo but necessary to reduce impact otherwise changes would required performing stride calculations in over aprrox 15 operators implementation increasing changes required manifold.
Again typedef is compile time and cannot be dynamically decided.

@mxnet-bot run ci [macosx-x86_64, edge, unix-cpu, unix-gpu, miscellaneous, clang]

@mxnet-label-bot update [pr-awaiting-review]

@ptrendx can you review this PR ?

Based on your PR description, the only difference between CPU and GPU kernel is that GPU kernel uses int32_t for indexing and CPU kernel uses int64_t (when large tensor compiler flag is on) for indexing, duplicating the kernel implementation into two structs seems an overdo to me. Could we optimize the code such that they still share the same kernel template but with different index_t type? Also it will be nice to re-architect the code so that it applies to all operators that share the same template between CPU and GPU kernels.

@apeforest

We cannot use typedef based on xpu because typdef is compile time option.
The blast radius is large if we make generic CPU/GPU kernel. Numpy ops that call broadcast_axis kernel for their internal operations need to be updated as well, so i created broadcast_axis_gpu for ops relying only on BroadcastComputeImpl internally which is evident from 43 GPU failing tests when temp workspace was used.

Hence, 2 structs are not overdo but necessary to reduce impact otherwise changes would require performing stride calculations inside implementation of approx 15 operators thereby significantly increasing changes required.
Again typedef is compile time and cannot be dynamically decided.
Updated the description now. It wasn't consistent as the PR was WIP. And now it is ready for review !

I did not mean typedef the only way to do so. Can we leverage the template feature. In fact, the Map function in GPU kernel is always using int instead of index_t

Based on your PR description, the only difference between CPU and GPU kernel is that GPU kernel uses int32_t for indexing and CPU kernel uses int64_t (when large tensor compiler flag is on) for indexing, duplicating the kernel implementation into two structs seems an overdo to me. Could we optimize the code such that they still share the same kernel template but with different index_t type? Also it will be nice to re-architect the code so that it applies to all operators that share the same template between CPU and GPU kernels.

@apeforest

We cannot use typedef based on xpu because typdef is compile time option.
The blast radius is large if we make generic CPU/GPU kernel. Numpy ops that call broadcast_axis kernel for their internal operations need to be updated as well, so i created broadcast_axis_gpu for ops relying only on BroadcastComputeImpl internally which is evident from 43 GPU failing tests when temp workspace was used.

Hence, 2 structs are not overdo but necessary to reduce impact otherwise changes would require performing stride calculations inside implementation of approx 15 operators thereby significantly increasing changes required.
Again typedef is compile time and cannot be dynamically decided.
Updated the description now. It wasn't consistent as the PR was WIP. And now it is ready for review !

I did not mean typedef the only way to do so. Can we leverage the template feature. In fact, the Map function in GPU kernel is always using int instead of index_t

@apeforest : kernels can be fused together using templates. But this approach hinders CPU performance but there is another PR that actually boosts it for CPU: https://github.com/apache/incubator-mxnet/pull/17882 . Since here I am leveraging vectorization.

@mxnet-bot run ci [all]

With the latest change, could you please re-run the opperf and paste the latest performance results?

@ptrendx Your review will be appreciated.

With the latest change, could you please re-run the opperf and paste the latest performance results?

@apeforest Actually there isn't any change in the result after re-running opperf I kept updating description if there were any differences in results. But currently they are consistent with the ones in description. I will paste BERT results in few mins.

@eric-haibin-lin @sxjscience @apeforest
BERT (Training Run Single GPU on p3.16xl)
Command:
python3 run_pretraining.py --data='./part-0000.train' --data_eval='./part-0000.train' --num_steps 1000 --lr 1e-4 --optimizer lamb --accumulate 1 --raw --gpus 0 --num_dataset_workers 2 --num_batch_workers 1 --circle_length 1 --total_batch_size 8 --total_batch_size_eval 8 --log_interval 10

new no-LT
INFO:root:[step 950]    mlm_loss=8.22240    mlm_acc=7.16    nsp_loss= 0.72  nsp_acc=48.75   throughput=26.4K tks/s  lr=0.0000051 time=1.06, latency=105.9 ms/step
INFO:root:[step 960]    mlm_loss=8.21638    mlm_acc=7.63    nsp_loss= 0.66  nsp_acc=56.25   throughput=25.3K tks/s  lr=0.0000040 time=1.06, latency=105.8 ms/step
INFO:root:[step 970]    mlm_loss=8.15530    mlm_acc=8.08    nsp_loss= 0.64  nsp_acc=53.75   throughput=26.5K tks/s  lr=0.0000030 time=1.07, latency=106.6 ms/step
INFO:root:[step 980]    mlm_loss=8.19152    mlm_acc=7.63    nsp_loss= 0.66  nsp_acc=68.75   throughput=21.2K tks/s  lr=0.0000020 time=1.06, latency=106.5 ms/step
INFO:root:[step 990]    mlm_loss=8.20629    mlm_acc=7.22    nsp_loss= 0.63  nsp_acc=65.00   throughput=27.7K tks/s  lr=0.0000010 time=1.08, latency=108.0 ms/step
INFO:root:[step 1000]   mlm_loss=8.22327    mlm_acc=7.58    nsp_loss= 0.62  nsp_acc=62.50   throughput=26.4K tks/s  lr=0.0000000 time=1.07, latency=107.3 ms/step
INFO:root:[step 1000] Saving trainer states to ./ckpt_dir/0001000.states.00.
INFO:root:[step 1000] Saving model params to ./ckpt_dir/0001000.params.
INFO:root:Train cost=131.5s

new LT
INFO:root:[step 950]    mlm_loss=8.21955    mlm_acc=7.49    nsp_loss= 0.68  nsp_acc=56.25   throughput=26.2K tks/s  lr=0.0000051 time=1.06, latency=106.3 ms/step
INFO:root:[step 960]    mlm_loss=8.19205    mlm_acc=7.28    nsp_loss= 0.68  nsp_acc=61.25   throughput=28.1K tks/s  lr=0.0000040 time=1.07, latency=106.9 ms/step
INFO:root:[step 970]    mlm_loss=8.13653    mlm_acc=8.54    nsp_loss= 0.67  nsp_acc=61.25   throughput=24.6K tks/s  lr=0.0000030 time=1.06, latency=106.0 ms/step
INFO:root:[step 980]    mlm_loss=8.12760    mlm_acc=8.43    nsp_loss= 0.64  nsp_acc=67.50   throughput=26.1K tks/s  lr=0.0000020 time=1.07, latency=106.9 ms/step
INFO:root:[step 990]    mlm_loss=8.10771    mlm_acc=8.24    nsp_loss= 0.68  nsp_acc=45.00   throughput=25.9K tks/s  lr=0.0000010 time=1.07, latency=107.0 ms/step
INFO:root:[step 1000]   mlm_loss=8.16389    mlm_acc=7.53    nsp_loss= 0.63  nsp_acc=58.75   throughput=28.0K tks/s  lr=0.0000000 time=1.07, latency=106.9 ms/step
INFO:root:[step 1000] Saving trainer states to ./ckpt_dir/0001000.states.00.
INFO:root:[step 1000] Saving model params to ./ckpt_dir/0001000.params.

INFO:root:[step 1000] Saving model params to ./ckpt_dir/0001000.params.

INFO:root:[step 1000] Saving model params to ./ckpt_dir/0001000.params.
INFO:root:Train cost=134.8s


Using DOCKER_HOST to detect running containers

Expected behavior
If you run linux containers in a remote server it should use the running containers instead localhost.
Actual behavior
Kitematic uses the localhost containers independently you run the app and you have DOCKER_HOST set. It should read DOCKER_HOST environment to use a remote location.
Steps to reproduce the behavior

Run Linux containers in a remote docker host.
Open Kitematic.
Check containers in the local system instead the remote host.

Kitematic doesn't read many ENV vars, simply because they aren't set globally but rather set on a per terminal basis.
Feel free to open a PR to make it work.

Curretly it is impossible to tell kitematic to connect to a remote host, which renders it pretty much useless for lots of use-cases, especially now that docker can use ssh transport.


fix(wip): token balance check

The goal of this PR is to improve code clarity by utilizing the appropriate token field and ensuring the correct balances are returned. Following by the comments.

@cawabunga-bytes Please don't merge this PR yet, I want to re-check Set Max value for Near + wNear

:tada: This PR is included in version 2.17.3 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


UPDATE README.

Small coder but but  unbelievable skills. nice sir have hope u like my pl .pls accept it  will help me for my guides.🤝🤝👍🙏🙏

love from India.......................


Schemas: Consider if Journal schema should be split per event

With the way the schema validation, performed on the Gateway, is specified it might start getting convoluted to disallow some fields only for some events and not others.
One proposal is to just split the Journal schema out into a schema per event that is allowed.
We don't allow that many events over EDDN so it's not like this will explode out into 10s more schemas, let alone 100s.

Obviously we will need to continue to support the current Journal schema during a transition period whilst senders switch over to using new per-event schemas.

Works for me, though I imagine most journal schemas are likely to still be quite similar to one another.

Works for me, though I imagine most journal schemas are likely to still be quite similar to one another.

All it takes is one key present/not present as a difference and it can be worthwhile the event having its own schema.  Then you can properly define the acceptable messages rather than technically leaving the door open for "that doesn't belong in this event" data in a message.
For example Docked should most definitely contain the name of the dockable asset you're now at, but that's never going to be on an FSDJump event.
Every time I look at the schemas in detail this sort of thing sticks out like a sore thumb.


Jr/flushing out testing harness

WIP fixing tests

@DieracDelta can I close this or is it still in progress? Trying to clean up old PRs

Yes, this is super stale! Closing.


”Nevățu”, ”Prejna”, ”Sfodea” are listed in the drop-down menu

Description:
When user writes ”Nevățu”, ”Prejna”, ”Sfodea” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Nevățu"

Expected results
The location appears in the drop-down menu as "Sat Nevățu, MEHEDINȚI (Balta)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Prejna"

Expected results
The location appears in the drop-down menu as "Sat Prejna, MEHEDINȚI (Balta)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Sfodea"

Expected results
The location appears in the drop-down menu as "Sat Sfodea, MEHEDINȚI (Balta)".


My build keeps failling

I'm submitting a ...
[X ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
I am trying to add my token to the token list. My token is almost the same as the others but my build keeps failing due to validation.

You can see here my build is failing:

You can see here how it looks almost the same as the one before (My TOKEN is the last one, WARI-WL):

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
Link to my PR: https://github.com/solana-labs/token-list/pull/23024

Thanks for any help!

fixed by https://github.com/solana-labs/token-list/commit/ce587dace90f41254395141cd1bb808db5f89df1


Bring GCP functionality to core functionality

We heavily use the Google Cloud extensions internally, and have encountered some pain points with it being in a contrib extension.
Like the AWS module at https://github.com/apache/incubator-druid/tree/druid-0.13.0-incubating/aws-common this ask is that there be a GCP common which supplies a default com.google.api.client.http.HttpRequestInitializer, com.google.api.client.http.HttpTransport, and com.google.api.client.json.JsonFactory. Any extensions which use the client api can then pull from the parent classpath's instance of these or supply their own. And modules are able to then override the default supplied ones if required.
The overall suggestion is to do the following (in no specific order):

Move aws-common into cloud/aws-common
Create gcp-common at cloud/gcp-common which contains a simple module for supplying com.google.api.client.http.HttpRequestInitializer, com.google.api.client.http.HttpTransport, and com.google.api.client.json.JsonFactory
Move the google-extension into extensions-core , we are willing to put effort into maintaining this extension as time goes on.
Modify google-extension to use the base gcp-common.

Actually, this happened in https://github.com/apache/incubator-druid/pull/6953.


Invalid value for msg.dest if IP PBX uses a proxy

Some IP PBX use proxy on their internal network. Which leads to the appearance of Record-Route headers in the responses.
When trying to make a call to such IP PBX, the call crashes with the error "IP addr resolving failed, doing via dns SRV resolver...".
This happens because if there are Record-Route headers, the first header is taken and set as msg.dest. This is incorrect behavior because the first header is the address of the last proxy server in the entire chain and often this address is located in a private IP PBX network.
Incorrect code section:
https://github.com/emiago/sipgo/blob/4552fe4bb49ae18fd609956b7ebd80d95f432a97/dialog_client.go#L353-L355
Example:
Via: SIP/2.0/TCP <IP_ADDRESS>:16486;rport=16486;branch=z9hG4bKPja63ddba066b94e20a745663dd5c9f80d;alias
Record-Route: <sip:c<IP_ADDRESS>.4677453.call.cgatepro;lr>
Record-Route: <sip:<IP_ADDRESS>:5060;transport=tcp;lr>
From: <sip:4542732210@sipnet.ru>;tag=eb2e2d121eb4429c823afb28d7e07fd8
To: <sip:79634568531@sipnet.ru>;tag=B53A61D1-161225-DDECDC4B_kdcmbtp-27BC
Call-ID: d29acea6e194f0d781acdc9663bebf97
CSeq: 32203 INVITE
Contact<EMAIL_ADDRESS>Supported: 100rel,timer,replaces,histinfo,precondition
Allow: INVITE,BYE,CANCEL,ACK,OPTIONS,INFO,MESSAGE,PRACK,UPDATE,REFER
User-Agent: CommuniGatePro-callLeg/6.3.19
Content-Type: application/sdp
Content-Length: 226

v=0
o=CGPLeg162512<PHONE_NUMBER> 644102260 IN IP4 <IP_ADDRESS>
s=SMG SIP session
c=IN IP4 <IP_ADDRESS>
t=0 0
m=audio 18160 RTP/AVP 8 101
a=rtpmap:8 PCMA/8000
a=rtpmap:101 telephone-event/8000
a=fmtp:101 0-16
a=sendrecv```

Correct. Will be fixed

Hi @Stilch
fixed on main branch.


Do not touch hash-designated files which already exist at the destination storage

It seems a little silly that, even though local file copies are used to avoid the need to fetch files from remote destinations, files still get replaced even when they already exist.
In example, a remote storage implementation like S3 gets queried for the file, the file gets removed, and then replaced. With the boto3 library, this means touching the file initially (HEAD), a second request to DELETE the file, and yet a third to PUT the new file. Since filenames for hashed files are computed based on the contents of the files, this seems like an unnecessary 3 requests for every time a single static file get processed.
Since a matching hash provides file integrity verification, I propose that the logic for copying hash-designated files be skipped all together.
Ticket available here - https://code.djangoproject.com/ticket/28200

(closing for now, needs better fix)


[BEAM-7267] Add python3*-dev to verify script

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @tvalentyn @aaltay


[Bug] New line between list items in resulting Markdown string

Describe the bug
When creating a new list (bullet, ordered, ...) and adding items to it, the resulting string has empty lines between them. This leads to unexpected results when rendered as HTML (tested with Laravel's Markdown helper and markdown-it)
To Reproduce
Steps to reproduce the behavior:

Add a markdown listener to the editor
Start a new list (e.g. typing - Hello World)
Hit return and add another item
Check resulting markdown code in listener
A new line is added after every line

What I type
# Unordered List with new lines
*   Hello
*   Hello again!
*   Hello World!

What I get
# Unordered List with new lines

*   Hello

*   Hello again!

*   Hello World!

What I get in HTML (
 tags ar unnecessary)

Hello

Hello again!

Hello World!

Expected behavior
Lists should not contain empty lines between the items. Otherwise a markdown to html parser adds a wrapping element (in my case a
) which leads to poor results
Screenshots
Rendered HTML

Edited rendered HTML without

Desktop (please complete the following information):

OS: Ubuntu 20.04 LTS
Browser: Firefox Beta
Version: 97

Additional context
Add any other context about the problem here.

That's related to the behavior of remark itself:
https://github.com/remarkjs/remark/issues/563

Thanks for the link! I somehow missed that while searching for a solution...
My current workaround is to add a class to the wrapper element around my converted html and display paragraphs inside lists as inline element
style {
    .from-milkdown li > p {
        display: inline !important;
    }
}

    {{ Str::markdown($markdownStr) }}

Seems this package can help, but we need to wrap it as a remark plugin.
https://www.npmjs.com/package/mdast-flatten-listitem-paragraphs

Seems this package can help, but we need to wrap it as a remark plugin.
https://www.npmjs.com/package/mdast-flatten-listitem-paragraphs

I'm trying to do this, but it needs time.
Also, it's a expected behavior in gfm standard but not commonmark standard. In that case, I should integrate this feature into preset-gfm package, right?

Seems this package can help, but we need to wrap it as a remark plugin.
https://www.npmjs.com/package/mdast-flatten-listitem-paragraphs

I'm trying to do this, but it needs time.
Also, it's a expected behavior in gfm standard but not commonmark standard. In that case, I should integrate this feature into preset-gfm package, right?

I think we can integrate it in commonmark because most people expect there's no newline break IMO.

I'm a bit of confused now. I tried render markdown in a simple remark instance like this. But I got no paragraphs in list item blocks. Is this really caused by remark?

I'm a bit of confused now. I tried render markdown in a simple remark instance like this. But I got no paragraphs in list item blocks. Is this really caused by remark?

That's not really a simple one. The html module will do the trick for remark. However, you need to look deep into the AST. Like this: https://codesandbox.io/s/jolly-galileo-d7lyjd
You can see there is a paragraph in the list item.

I'm a bit of confused now. I tried render markdown in a simple remark instance like this. But I got no paragraphs in list item blocks. Is this really caused by remark?

That's not really a simple one. The html module will do the trick for remark. However, you need to look deep into the AST. Like this: https://codesandbox.io/s/jolly-galileo-d7lyjd
You can see there is a paragraph in the list item.

I have tried to write a plugin since few days ago, but unfortunately I can't get visit working at all, most of the time the attrs which plugin get is undefined. I'm a little confused on this. But one thing is clear, I think that remark is working under unified standard, and unified & mdast & remark plugins should be working directly on remark. They all seems do a similar job but naming on there workspace.

I'm a bit of confused now. I tried render markdown in a simple remark instance like this. But I got no paragraphs in list item blocks. Is this really caused by remark?

That's not really a simple one. The html module will do the trick for remark. However, you need to look deep into the AST. Like this: https://codesandbox.io/s/jolly-galileo-d7lyjd

You can see there is a paragraph in the list item.

I have tried to write a plugin since few days ago, but unfortunately I can't get visit working at all, most of the time the attrs which plugin get is undefined. I'm a little confused on this. But one thing is clear, I think that remark is working under unified standard, and unified & mdast & remark plugins should be working directly on remark. They all seems do a similar job but naming on there workspace.

Yeah, a remark plugin can be just a wrapper of a mdast plugin

Add to planned since @quank123wip  is working on this.

Got stucked again but I would still keep on trying to solve it by myself. The last time I tried write a plugin but the plugin is not running inside that. Then I tried to use remark.process(), and luckily it runs. It seems like a different behavior between parse and process, and a remark plugin should run only when there calls process. What does milkdown actually requires now, a mdast or rendered HTML. I prefer to assume it's a mdast. I will read more milkdown codebase but it needs more time. Hope that won't cause you slow down or bothered by me.

Add to planned since @quank123wip is working on this.

Check this out ✨
I think we need a post processor for ast?

Since we're working on the v6 version. I think we can use unidied, but we should make sure the output of the entire parse process is still the AST tree.

Since we're working on the v6 version. I think we can use unidied, but we should make sure the output of the entire parse process is still the AST.

Yes, as remark's definition is simply unified().use(remarkParse).use(remarkStringify).freeze(), this won't be hard, and it will give us a chance to customize remark-parse and remark-stringnify's behavior. For example, I have made an example showing how to solve this issue by just one unified instance.

I'm working on a refactor now. My idea is replace the remark() in transformer with unified() instance, than use remarkParse and remarkStringify in preset-commonmark and preset-gfm. But here comes a conflict: If we configured remarkParse in commonmark, how can we configure them in gfm or other presets? Here I have two ideas: make mdast plugin can be managed explicitly by a separate way, or move these two plugins into a separate plugin list, any preset shoulde define them and merge them into their config themselves. What do you think? 🙏

Can we use remarkParser and remarkStringify in the transformer module? I'm not sure the reason that we need to define them for different presets.

Can we use remarkParser and remarkStringify in the transformer module? I'm not sure the reason that we need to define them for different presets. Can you help me to understand this?

IMO, it seems the simplest way to provide a method for applying changes on mdast, not only for mdast-flatten-listitem-paragraphs. In fact it seems like the preset in remark-rehype have
done much more then I expected. Commonmark standard and GFM standard are two different standards, contains differences like whether we should provide listitems without paragraph inside or not. Their differences may cause unknown issues in other applications. And we don't know if there is a new markdown standard in the future. My opinion is to keep their original flavor in preset packages, and extend them with our own milkdown-standard plugins, that may cause less conflicts. What do you think about this? 😋

Can we use remarkParser and remarkStringify in the transformer module? I'm not sure the reason that we need to define them for different presets. Can you help me to understand this?

IMO, it seems the simplest way to provide a method for applying changes on mdast, not only for mdast-flatten-listitem-paragraphs. In fact it seems like the preset in remark-rehype have done much more then I expected. Commonmark standard and GFM standard are two different standards, contains differences like whether we should provide listitems without paragraph inside or not. Their differences may cause unknown issues in other applications. And we don't know if there is a new markdown standard in the future. My opinion is to keep their original flavor in preset packages, and extend them with our own milkdown-standard plugins, that may cause less conflicts. What do you think about this? 😋

I'm still a little confused by this. For now, the milkdown editor pick up the AST generated by reamrk, and use them to create prosemirror state. But IMO remark-rehype generates HTML, how can we keep our workflow? Do you mean we need to create prosemirror state from html string?

Can we use remarkParser and remarkStringify in the transformer module? I'm not sure the reason that we need to define them for different presets. Can you help me to understand this?

IMO, it seems the simplest way to provide a method for applying changes on mdast, not only for mdast-flatten-listitem-paragraphs. In fact it seems like the preset in remark-rehype have done much more then I expected. Commonmark standard and GFM standard are two different standards, contains differences like whether we should provide listitems without paragraph inside or not. Their differences may cause unknown issues in other applications. And we don't know if there is a new markdown standard in the future. My opinion is to keep their original flavor in preset packages, and extend them with our own milkdown-standard plugins, that may cause less conflicts. What do you think about this? 😋

I'm still a little confused by this. For now, the milkdown editor pick up the AST generated by reamrk, and use them to create prosemirror state. But IMO remark-rehype generates HTML, how can we keep our workflow? Do you mean we need to create prosemirror state from html string?

Sorry for my misdirection😢, I means if we want to implement a similar output as remark-rehype, we may need more ast jobs.

I think it may not that complicated because we do can apply changes to AST now with remark plugins. In fact, IMO the remark plugin is just a wrapper of mdast plugin. I created a simple demo for this: https://codesandbox.io/s/milkdown-compact-list-item-2ifbmg?file=/src/index.ts
As for the standards difference you mentioned. I think it should always decided by nodes and marks. For example, if you find list item has many differences between gfm and commonmark, we can just create two differenct list item nodes.


Potentially add types field to root tsconfig

Right now we're by default importing all the types from @types hence the issues with duplicate identifiers, i.e. we're getting duplicates from @types/react-native and styled-components even though not even making a react native app...
So we can specify exactly which types we want. something like:
{
  "extends": "./node_modules/@polkadot/dev/config/tsconfig",
  "types": ["node", "jest", "styled-components"]
}

The only hesitation is that we need to be vigilant about the types field as more components get added throughout development. Especially as currently the only time the duplicate identifier issue comes up is with version 4.1.3 of styled-components and reverting to v4.1.0 solves the issue. If it comes up again somewhere else, this is defintiely a go. As of now, onice.

Yes, agreed, ice it (for now). I played with this in polkadot-js and it ends up being hairy and an additional maintenance nightmare.
@types/styled-components just needs to be fixed at source. (The changes there were made to cater for RN environments there, and then it broke it for the rest of humanity).


Added missing properties in doc-block

See (https://github.com/fzaninotto/Faker#fakerprovideren_uscompany)

Thanks for contributing


Matrix: quick updates to bech32 sending

Closes #504 .  This updates a few of the entries in the table based on evidence provided by @instagibbs in the linked issue.

@harding thanks for throwing these together.
Im supportive of the bitstamp and bitmex changes, with a couple fixup commits just pushed.
However, the mycelium changes, I just tested again and neither p2wsh nor p2wpkh addresses are accepted in the UI.
Jaxx changes reference materials before my testing. So I saw with my eyes on those days that bech32 was not supported. But unable to get the wallet working at the moment. Inclined to leave jaxx as is on the site now.

Mycelium works for me with bech32.
Abra App still doesn't support bech32.
Wirex App doesn't support bech32. Should it be added to the list?
I also heard complaints from multiple people that blockchain.com wallet doesn't support bech32. However, I don't have that wallet to verify.

Some more updates based on boots on the ground experience:
iOS blockchain.info wallet doesn't support it yet, but they claim Soon(TM)
ZebPay exchange doesn't support(and doesn't seem to want to)
UpBit supports it
ByBit does not.

Sergej Kotliar posted that he was able to send with his Blockchain app to a Bech32 address. Not clear whether that was Android or iOS.

It appears that Blockchain now also has updated their wallets to receive to P2WPKH addresses by default and produce P2WPKH change outputs.

@Xekyo can you check on p2wsh support for sending? sometimes wallets don't support both...

Sorry, I don't have a Blockchain wallet.

Updated based on the comments here and rebased on master.

Looks reasonable, just got an open follow-up on Mycelium.

Most recent comment on this thread was that it worked. https://github.com/bitcoinops/bitcoinops.github.io/pull/510#issuecomment-772978577

Ah okay. I thought it was surprising that the date was set to the past. In that case, the update looks good to me. What's would be the next step to ship it?

I added a commit to update the Mycelium segwit compatibility data after testing it with Android today.

I noticed some of the new images were not optimized, so I optimized those and squashed.

Thanks for optimizing the images. I'm a bit surprised at the squash. I had left a detailed description in the commit message for the Mycelium update. Squashing the commits dropped that information. Is there a general rule of thumb when I should expect things to be squashed and when we keep the commit history as with the newsletter?

Hey @Xekyo that’s a good point. Im happy to keep the commits separate to preserve that additional information in the commit message. Or could pull commit info into a squashed commit? Im open to suggestions on general rule for this sort of thing.

I squashed the image optimizations into the mycelium commit.

I like cleaning up my commit history by squashing tiny commits that belong together to one commit (i.e. a follow-up commit that fixes a single typo shouldn't be a separate commit), but beyond that I prefer keeping all commits as it makes it easier to assess changes in their distinct context later without throwing a bunch of unrelated changes together in one change-set.
For example here, I'd say the "clean way" would be:

The first commit makes updates to four different services while the following two commits just make corrections to the first commit. Those three commits I'd squash into one.
The commit with the blockchain.info update was made much later, and it also reverts the changes to the Jaxx wallet. I'd pick the changes to Jaxx into the first commit (reverting changes to Jaxx altogether rather than introducing them and rolling them back in the same PR in a later commit), while I would leave the blockchain.info update as a distinct commit.
I'd leave the Mycelium commit separate because Mycelium was already previously updated in the first commit, and the second update switches the assessment from iOS to Android, and was presumably gathered using a different methodology than the first updates.

In practice, investing that much time would be overkill on this series of commits, so I'd propose that we squash the first four commits and leave the Mycelium commit separate.

@Xekyo Good to get your perspective on this. Ive taken your recommendation and squashed the first 4 into one.

Quick skimmed the diff and LGTM.
IMO, if @bitschmidty is happy, that's enough to merge.  The fact that information on these pages can become outdated and so break reader expectations implies to me that us maybe accidentally misprinting some information isn't the end of the world.  So I think we don't need to be overcautious.


Improve "expression name" documentation -- describe supported syntax

Find a page describing the Linq-to-objects expression name syntax that our IHtmlHelper implementation supports.  Link to that page from the appropriate parameter descriptions in our XML documentation.
See https://github.com/aspnet/Mvc/pull/961#discussion-diff-16214115 for background on this ask.

This subject will be more accessible (i.e. easier for customers to find) in documentation and not doc comments. Suggest moving this issue to the aspnet/docs repo and marking that new issue as blocked on aspnet/Docs#131. aspnet/Docs#131 is about filling in https://docs.asp.net/en/latest/mvc/views/html-helpers.html but unfortunately it's on the backlog. A need to document supported expression name formats could also be part of aspnet/Docs#131 rather than a separate issue.
(Hmm, one shortcut to addressing aspnet/Docs#131 would be to rewrite MVC 4.x or 5.x documentation in latest markdown.)
Right now, the http://docs.asp.net site and aspnet/docs repo do not contain much information about string-based HTML helpers. The Working with Forms page does include an Expression names sub-section but that comes at expression names from the lambda expression -> generated HTML name attribute perspective. Good news is that angle is almost completely covered. All that's missing is that asp-for="CollectionProperty[23].Member" and asp-for="CollectionProperty[twentyThree].Member" generate the same name when there's a twentyThree variable with the value 23.

This issue was moved to aspnet/Docs#2008


Develop

Coverage increased (+0.2%) to 85.889% when pulling 706b2c6acaaad3c082a3824f4550bb63d02af65c on develop into 885f8cd9f02be3bd6791c49c81f06a13e3faa686 on qa.


Fix #49 (problem compiling due to version ranges in transitive deps)

See #49 for details

Closing this as it has been split for Stargate SDK and building successfully on the github action.


High memory consumption when loading a gif image

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[x] I have read the wiki page and cheat sheet, but there is no information I need.
[x] I have searched in existing issues, but did not find a same one.
[x] I want to report a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
I'm trying to show a gif image in an imageview that results in high memory consumption in the app - over 1GB for a 550KB gif file.
Reproduce
Code example:
import UIKit
import Kingfisher

class ViewController: UIViewController {
    override func viewDidLoad() {
        super.viewDidLoad()

        let imageView = UIImageView()
        imageView.frame = self.view.bounds
        imageView.kf.setImage(with: URL(string: "https://blog.elfster.com/wp-content/uploads/2024/09/Wish-of-the-Week-2024-Blog-Header-1.gif")!)

        self.view.addSubview(imageView)
    }
}

When using UIImageView to display a gif, by default the whole gif frames are loaded into the memory. If you have a gif with huge frames or large in size, it might cause issues.
To get a better memory performance, consider to use the AnimatedImageView.


rPackages.pkgdepends: fix compile error

Description of changes
Needed a bit of shebangs patching
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Tested on linux-aarch64, looking good!
> pkgdepends::current_config()
# pkg config
## build_vignettes
<default>
[1] FALSE

## sysreqs_verbose
<default>
[1] FALSE

## sysreqs_db_update
<default>
[1] TRUE

## metadata_cache_dir
<default>
[1] "/run/user/1000/RtmpUU5QPy/file5e2db1a24ef"

## platforms
<default>
[1] "aarch64-unknown-linux-gnu-ubuntu-23.10"
[2] "source"

## goal
<default>
[1] "unknown"

## r_versions
<default>
[1] "4.3.2"

## cache_dir
<default>
[1] "/run/user/1000/RtmpUU5QPy/file5e2d32bb2ffa"

## library
<default>
NULL

## metadata_update_after
<default>
Time difference of 24 hours

## include_linkingto
<default>
[1] FALSE

## sysreqs_rspm_repo_id
<default>
[1] "1"

## sysreqs_update
<default>
[1] FALSE

## package_cache_dir
<default>
NULL

## sysreqs_rspm_url
<default>
[1] "https://packagemanager.posit.co"

## sysreqs_sudo
<default>
[1] TRUE

## sysreqs_db_update_timeout
<default>
Time difference of 5 secs

## sysreqs_lookup_system
<default>
[1] TRUE

## sysreqs_platform
<default>
[1] "aarch64-unknown-linux-gnu-ubuntu-23.10"

## dependencies
<default>
[1] "Depends"   "Imports"   "LinkingTo"

## sysreqs
<default>
[1] FALSE

## sysreqs_dry_run
<default>
[1] FALSE

## windows_archs
<default>
[1] "prefer-x64"

## use_bioconductor
<default>
[1] TRUE

## cran_mirror
<default>
[1] "https://cran.rstudio.com"

Can you squash the commits?

@jbedo I addressed your comment, tried to resolve-unresolve-resolve comment, rebase and force push twice, but it still says merging is blocked. Is there a button somewhere I don't see? how can I resolve the issue to allow merging?


After upgrading to Node 18, yarn cli fails to run postinstall script when yarn cache is enabled

Description:
After updating to Node18 + serverless v3, my GHA builds fail consistency after first succeeding once (when there is a cache miss).
The issue appears to be related to the yarn cache, but only happens on GHA.
Disabling the yarn cache resolves the issue.
Action version:
actions/setup-node@v3
Platform:

[X] Ubuntu
[ ] macOS
[ ] Windows

Runner type:

[X] Hosted
[ ] Self-hosted

Tools version:

node 18.18.2
yarn 1.22.21
Repro steps:
Set up a repo with
"dependencies": {
    "serverless": "^3.37.0",
    "serverless-bundle": "^6.0.0"
}

Running yarn install on my local machine works fine.
The first build on GHA (in the pull request) worked fine
Consecutive builds on GHA fails 100%.
Removing cache: yarn from the action solves the issue (but obviously adds build time)

Error message seems slightly random, but in my case always related to a postinstall script in serverless:
[4/4] Building fresh packages...
info This package requires node-gyp, which is not currently installed. Yarn will attempt to automatically install it. If this fails, you can run "yarn global add node-gyp" to manually install it.
error TypeError: /home/runner/work/<mymodule>/node_modules/serverless: Cannot read properties of undefined (reading 'config')
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
    at /usr/local/lib/node_modules/yarn/lib/cli.js:[34](https://github.com/<mymodule>/actions/runs/6955033577/job/18925299805#step:5:35)1[35](https://github.com/<mymodule>/actions/runs/6955033577/job/18925299805#step:5:36):120
    at Generator.next (<anonymous>)
    at step (/usr/local/lib/node_modules/yarn/lib/cli.js:310:30)
    at /usr/local/lib/node_modules/yarn/lib/cli.js:321:13

Note that prior to upgrading to node 18 and serverless 3, it worked fine on GHA as well, using Node 16.20.2 and the following dependencies:
package.json:
"dependencies": {
    "serverless": "^2.72.3",
    "serverless-bundle": "^5.3.0"
}

I added --verbose to my yarn install --frozen-lockfile command, but nothing useful came out.
Expected behavior:
yarn install --frozen-lockfile should work also with yarn cache enabled
Actual behavior:
yarn install --frozen-lockfile fails on GHA with Node 18.x when yarn cache is enabled.

Thank you for creating the issue and providing us with details! We will make sure to look into it and come back with the answer!

Today I've experienced this bug also with cache disabled. :( Really strange, as I said, the first time GHA installed my project it worked fine. The second, third etc, failed. After disabling the cache, it worked a couple of times. Now it fails again.
The line in yarn that throws is typically
var keys = new (_set || _load_set()).default([].concat((0, (_keys || _load_keys()).default)(config.registries.yarn.config), (0, (_keys || _load_keys()).default)(config.registries.npm.config)));

due to config.registries.yarn being undefined.

Can also reproduce fwiw

I had no choice but to temporarily switch from yarn to npm as this resolves the problems. So it only happens with yarn on setup/node action. Not with yarn locally.

I haven't been able to find any other workaround. :(
Luckily it was not a super big deal for me to switch from yarn to npm, other than getting used to writing the correct command after using yarn for years :(
But since it seems to be reproducible I'm hoping the maintainers at least have a good chance of debugging this. I am not able to share my full configuration as the code in question is not public, so was a bit worried that it was due to some very specific quirk in my setup, but now it definitely seems like others are seeing a very similar error.

I could work around it by adding the  --ignore-scripts flag to my yarn install commands in GHA workflows.

Hello @henhal , Thank you for reporting the issue.
We tried to reproduce the issue in our local and the error message mentioned in description appears to come from the installation process of the serverless package.Could you please try reinstalling the packages and have node-gyp globally installed as suggested in the error message.
In case of any concerns please feel free to share them!!

Hello @henhal,
Just a gentle reminder, Could you please try reinstalling the packages and have node-gyp globally installed as suggested in the error message.

Stopped using yarn, not a great workaround but oh well

Anyone running into this, try installing Node 20+. In our case it solved this exact same issue with node-gyp.

Hello @henhal , Thank you for reporting the issue. We tried to reproduce the issue in our local and the error message mentioned in description appears to come from the installation process of the serverless package.Could you please try reinstalling the packages and have node-gyp globally installed as suggested in the error message. In case of any concerns please feel free to share them!!

It would be useful to know why this is happening in versions starting with Node v18.18, but got resolved in v20+.

@kddsultan I'm also facing the issue you're having wherein the node version is getting resolved to v20 even when i added version >=18.0.0 in the engines section in package.json


Fix ACDGen or improve diagnostics for ACDGen or provide source code for it

When trying to produce NSManagedObject subclasses with ACDGen it fails without generating anything with inscrutable error with no way to diagnose this.

Please provide source code for ACDGen (as I couldn't find it on GitHub anywhere) so that this error can be diagnosed.

The ACDGen tool will be open source. As soon as I publish it I'll post the GitHub link here.

Done!
You can grab it on: https://github.com/Alecrim/ACDGen.git
:-)

Thank you, keep up the good work!


Change syntax in README.md from json to jsonc

Change syntax highlighting in README.md from json to jsonc so that it renders the comments in the .json file in a nicer way 🙂

Much better. Thank you!


Currently the charts maxY is fixed. User setting or dynamic needed?

User setting for charts Y top/bottom values would be great!


Updated dependencies

chore: 🤖 Updated dependencies

:tada: This PR is included in version 6.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Is it possible to add both index.html and index.js to the application? Pros and cons?

Node version:
npm version:
Operating system:
Command line used:
Steps to reproduce:

Sorry, I don't understand the question. Both are part of the app by
default.
On Dec 14, 2016 1:14 AM, "Rajiv-Kulkarni"<EMAIL_ADDRESS>wrote:

Node version:
npm version:
Operating system:
Command line used:
Steps to reproduce:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/coryhouse/react-slingshot/issues/344, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABnFpRCPwRCoi3j4ywljzJRFRoXLof8Sks5rH5dygaJpZM4LMmr9
.

Closing since I addressed this on Pluralsight discussion thread.


Missing depmod command after modules sync - 4.8.3-fedora-1

When switching to 4.8.3-fedora-1 and right after a first boot, the kernel cannot load any modules and several features are missing.
The current initrd is probably missing a "depmod -a 4.8.3-fedora-1" call after the modules files are sync to the rootfs.
If the depmod command is not run , I cannot have any output of the "modinfo tun" command, whereas after the depmod, the modules are found.
I need a second reboot in order to have a clean boot because of this issue.

the ideal solution is to have a way to scaleway uses fedora standard kernel,


Triangle facts

Looks pretty good. Read the feedback and make sure you understand the reasoning, then go ahead and move on. Thanks!


Add ability for Animated views to be created with scale X or scale Y

Accidentally closed previous PR
Motivation
Sometimes it can be useful to have an animated view be created with either scale X or scale Y in cases where scaleXY might not be as visually appealing.
Test Plan
Tested on both ios and android in the sample project:
https://github.com/Liamandrew/ScaleAnimationSample

@hramos Should we add yarn.lock / package-lock.json to .gitignore since it won't be used in OSS for now?

@janicduplessis we should, for now. Ideally, we could allow them to be checked in, as long as they are removed prior to import by our tooling (this is because we use our own yarn.lock file from a parent directory in the monorepo, and having a second yarn.lock here would be problematic for us at FB).

https://github.com/facebook/react-native/pull/18281

@facebook-github-bot shipit


Cheat Aether not to use local m2 when stubs mode is set to REMOTE

After doing another digging into the problem, obvioulsy we're not the only ones with this issue (http://maven.40175.n5.nabble.com/Resolving-an-Artifact-from-Remote-Repository-instead-of-Local-td5875134.html). A potential workaround is to, when someone sets stubsMode: REMOTE, to provide a fake maven local repo location - https://stackoverflow.com/questions/9123004/maven-is-it-possible-to-override-location-of-local-repository-via-the-use-of-co .
related to https://github.com/spring-cloud/spring-cloud-contract/issues/639

It seems that the workaround is working great. That means that the skipSnapshotCheck property is completely redundant.


Fix mobile version

Mobile version is not playable, since we cannot connect the wallet:

It seems that Nickname and NodeURI are not dispatched correctly, and then, not available in the state. Which causes the error shown in the screenshot

Done with #64


ng add @ng-toolkit/universal not -  working

I'm submitting a...

[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request

In package

[ ] @ng-toolkit/init
[ ] @ng-toolkit/serverless
[ ] @ng-toolkit/universal
[ ] @ng-toolkit/pwa
[ ] @ng-toolkit/firebug

Current behavior

Expected behavior

Minimal reproduction of the problem with instructions

Example repository

What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z

- Node version: XX
- Platform:

Others:

Closing now as the author didn't fill the issue template.