more refactoring

Codecov Report

Merging #554 into master will decrease coverage by 77.91%.
The diff coverage is 4.12%.

@@             Coverage Diff             @@
##           master     #554       +/-   ##
===========================================
- Coverage   93.64%   15.72%   -77.92%
===========================================
  Files          40       40
  Lines        2912     2918        +6
===========================================
- Hits         2727      459     -2268
- Misses        185     2459     +2274

Impacted Files
Coverage Δ

vent/helpers/meta.py
15.1% <ø> (-78.87%)
:arrow_down:

vent/api/plugins.py
8.37% <0%> (-84.81%)
:arrow_down:

vent/menus/main.py
12.4% <0%> (-64.97%)
:arrow_down:

vent/api/actions.py
9.25% <0%> (-85.15%)
:arrow_down:

vent/api/plugin_helpers.py
8.83% <3.62%> (-87.57%)
:arrow_down:

vent/api/menu_helpers.py
8.18% <6.45%> (-84.84%)
:arrow_down:

vent/core/rq-dashboard/rq_dash_settings.py
0% <0%> (-100%)
:arrow_down:

vent/core/rq-worker/settings.py
0% <0%> (-100%)
:arrow_down:

tests/test_menu.py
9% <0%> (-91%)
:arrow_down:

vent/core/file-drop/test_file_drop.py
12.5% <0%> (-87.5%)
:arrow_down:

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad43c63...34ed10b. Read the comment docs.


[494] Refactor contact details

Context

https://trello.com/c/DZv3JPgV/494-refactor-contact-details-to-use-baseproviderform

Changes proposed in this pull request

Refactors the contact details in the about your organisation section to use new form/controller pattern
Removes references to contact fields from about your organisation form/controller
Tests the contact details in isolation in its own feature spec
Re-list contact details specific validations in its form object. These can be removed from the model once this is live

Guidance to review

Updating the contact details works the same as before

Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

 Refactor Contact details to use BaseProviderForm

@dankmitchell Do you want to give this a final pair of 👀


add function edge cases

BhimInteger n("-350");     BhimInteger n1("-35");     n = n + n1;     cout << n; // output => -085
If we try to add -350 and -35 it gives -085, which is not correct.
Before actual addition in add function, the edge cases should be checked like if both numbers are negative or if one is negative and one is not and perform our expression accordingly.

If you permit me then I can Resolve it.

Thank you for letting us know this bug. Please feel free to resolve this.

FIXED


Installation

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
You need python to install this right?
I went to https://www.python.org/downloads/ and clicked download, then I typed python in command line to get the version and it just opens the Microsoft store.
What did I do wrong? How do I install this so I can use it?
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

Locate to yt-dlp folder first. You can right-click on the folder of yt-dlp and select "open powershell from here", and enter CMD, then do those what you want to do.

I'm not sure, but this seems like an issue with how you installed python. From what you described, either python is not installed properly or you did not add python to your PATH variable on Windows. Please see this Stack Overflow question about python on windows which looks similar to what you experienced.
Also, if that didn't solve you problem with python --version taking you to ms store, try this python installation guide from A Byte of Python to install python on windows properly.

yt-dlp --version but it says "'yt-dlp' is not recognized as an internal or external command, operable program or batch file."
How do I get it to work?

You probably want to add the directory where you keep yt-dlp.exe to your PATH. Here's an example of how to do that: https://www.java.com/en/download/help/path.html
You'll also want to install ffmpeg if you don't have it already. Download this zip file, extract it, and copy the 3 exe files in the bin folder into the same directory as your yt-dlp.exe

Closing this. Join the discord server if you need further help with installation/basic usage; it's a better forum for this type of support


GCC > 7 is not allowed

Error i'm getting, trying to use GCC 8
In file included from /gpfs/software/cuda/10.0/include/cuda_runtime.h:83,
from :
/gpfs/software/cuda/10.0/include/crt/host_config.h:129:2: error: #error -- unsupported GNU version! gcc versions later than 7 are not supported!
#error -- unsupported GNU version! gcc versions later than 7 are not supported!
^~~~~
error: command '/gpfs/software/cuda/10.0/bin/nvcc' failed with exit status 1

Sorry, I used CUDA version 10.0.130, it seems to work with g++ 7.4.0 Could you please write you nvcc and g++ versions? Also, check this compatibility table: https://gist.github.com/ax3l/9489132

Update to nvcc version 10.1.105 should solve this problem.


InputGroup: update deprecated onkeypress + NodeRef forwarding

keypress is deprecated according to MDN, so I swapped them for keydown and keyup events instead.
I also added NodeRef forwarding to the input tag, so it is easier to use regular input APIs on it. I'd love to hear of a better way to achieve that however.

Thanks!!

I'd love to hear of a better way to achieve that however.

I will come back to you later on that


ciao-project: Cleanup all remaining references to 01org/ciao

This commit removes the last few references to 01org/ciao.
Signed-off-by: Mark Ryan<EMAIL_ADDRESS>

Coverage decreased (-0.004%) to 65.856% when pulling 31a79848ff135886b29a57cc6f8ad81cb7e0533f on markdryan:01org-cleanup into 79e53fb7ad033cabb72da2094c47e5a057405670 on ciao-project:master.


Pages 'Not Found'

Describe the bug
Just as in the title, I've tried 2 pages:

/ (aka index page)
/login
Both pages show the following screen:

To Reproduce
Here are a few things about the server I am running convos on:

I am using docker container 'nordaaker/convos:stable'
I have the environment variable set: 'CONVOS_REVERSE_PROXY: 1'
Container is called 'convos'
Volume: 'data:/data'
Convos is running behind Traefik reverse proxy, Traefik listens on the default https port and gets the certificate from Lets Encrypt, then it routes the request to the convos container on the following URL: http://convos:3000/
I use the same traefik configuration for other services like gitlab and wikijs, until now everything worked.
Convos is only accessible from behind VPN

Expected behavior
I should see the login page.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:

OS: Arch Linux (server and host work on the same OS but different machines)
Browser Chromium Version 83.0.4103.61 (Official Build) Arch Linux (64-bit)

Additional context
Request snapshot:
request.har.zip
Try inspecting it with a tool like this: http://www.softwareishard.com/har/viewer/

It looks like you forgot to set the X-Request-Base header. If you want, you can set CONVOS_REVERSE_PROXY instead of CONVOS_REVERSE_PROXY and X-Request-Base:
CONVOS_REQUEST_BASE: https://example.com/

See the resources below for more information:

https://convos.chat/doc/faq.html#can-convos-run-behind-behind-my-favorite-web-server
https://convos.chat/doc/config.html

I just pushed a new version of the documentation to make this a bit clearer. Please let me know if it could be improved further. a7d08f29


add example of custom embeddings

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

💯


poind_id typo

poind_id appears in some spreadsheets.
I did a replacement here (just search and replace and then manually replace in some spreadsheets):
https://github.com/declann/lifelib/commit/f5927b8f33ab37a2c56fc5e5bfa0dca0f04c15d0
(I didn't rebuild so, for example pickle files are inconsistent in that repo)
Can submit a PR if needed

Thanks! Yes, a PR would be very much appreciated!


Meta image error on Facebook

Facebook share debugger (https://developers.facebook.com/tools/debug/?q=refundcleveland.com) is giving the following error:

Provided og:image URL, https://refundcleveland.com/static/meta-img.jpg could not be processed as an image because it has an invalid content type.

Here is the URL for the image being used (for now): https://www.refundcleveland.com/static/images/meta-img.jpg

Fixed -- does Heroku modify the image filenames? I updated the image URL to https://www.refundcleveland.com/static/images/meta-img.25d184f01521.jpg and all is good.


Change the resourceuri attribute from guid to fullyqualifiedname in the payload

Change the resourceuri attribute from  to fullyqualifiedname in the payload

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d4318999-c1d5-319f-a90d-33d077702d2b
Version Independent ID: 35343ad4-d893-016b-c4e2-2732c8c241eb
Content: Metering service APIs - Microsoft commercial marketplace
Content Source: articles/marketplace/marketplace-metering-service-apis.md
Service: marketplace
Sub-service: partnercenter-marketplace-publisher
GitHub Login: @arifgani
Microsoft Alias: argani

@santhoshb-msft Thank you for your feedback. We will look into this and update as appropriate.
@emuench FYI

#reassign:v-jrushing

Updates completed #please-close.


support Scala 2.13

the 2.13 effort is only just underway, but there is already a 2.13
community build and this change is needed for minitest to work
there
it would also be possible to jimmy the build to use the 2.12 directory
in the 2.13 case, or to add a symlink. I chose the copy-and-paste route

Thanks @SethTisue, copy/paste is fine.


refactor(traffic_light_arbiter): add traffic_light_arbiter param file

Description
This PR adds traffic_light_arbiter.param.yaml to autoware launch.
autoware universe PR:

https://github.com/autowarefoundation/autoware.universe/pull/4454

Tests performed

please see https://github.com/autowarefoundation/autoware.universe/pull/4454
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Thanks!
I will merge after this PR has merged


[DO NOT MERGE YET] GH-67: Add JPA DSL support

JIRA: https://jira.spring.io/browse/INTEXT-205
Fixes GH-67 (https://github.com/spring-projects/spring-integration-java-dsl/issues/67)

Just an initial commit to demonstrate how Spring Boot is powerful :smile:

@englishman, any feedback are welcome, by the way!

Now this is full of functionality.
Ready for final review.

The fix for the issue in the Travis report is done in the commit https://github.com/spring-projects/spring-integration-java-dsl/pull/110/commits/df83d383e1830e5a9709fa14d0b6bdfc4001f6ef, which is the part of the #110 PR.
So, it is just waiting for the merge there :smile:

Merged as 95e28ab15130a51d30e27481a12412d032769710


Feature suggestion: expose sqlite3_column_database_name family of functions

Bit of a niche feature request this one: I'm really interested in these APIs: https://www.sqlite.org/c3ref/column_database_name.html
const char *sqlite3_column_database_name(sqlite3_stmt*,int);
const char *sqlite3_column_table_name(sqlite3_stmt*,int);
const char *sqlite3_column_origin_name(sqlite3_stmt*,int);

Given a prepared statement they let you figure out which database/table/column the return values come from. For example:
select
  roadside_attractions.name as name,
  attraction_characteristic.name as characteristic
from
  roadside_attraction_characteristics
  join roadside_attractions on roadside_attraction_characteristics.attraction_id = roadside_attractions.pk
  join attraction_characteristic on roadside_attraction_characteristics.characteristic_id = attraction_characteristic.pk

The sqlite3_column_database_name family of APIs could let me examine this SQL query and identify that the name column in the output came from the roadside_attractions.name column, but the characteristic column was from attraction_characteristic.name.
I have a couple of use-cases for this:

If a query returns a 5MB binary object in a BLOB column I'd like to display "5MB binary" and provide a download link, where the download link knows how to query just that data. Knowing which dataase/table/column it came from would help.
In Datasette I like displaying foreign key references as hyperlinks, as seen on https://latest.datasette.io/fixtures/roadside_attraction_characteristics - if I could tell the table/columns responsible for a value on my arbitrary SQL query page (this page) I could show the hyperlinks there as well.

I've not yet managed to come up with a proposed design for a Python API that exposes this stuff. Maybe something on the cursor after cursor.execute(sql) has been called?

These require that the underlying library be compiled with SQLITE_ENABLE_COLUMN_METADATA, which must be specifically enabled by the user. For what it's worth, apsw does not support this family of functions. Most of the information can already be obtained from the cursor description, but beyond that I agree with Roger that this seems to provide very little real-world utility. I'd suggest tackling this at the application layer instead.
If upstream does end up adding this functionality I will definitely merge it in, but at the moment I'll probably pass.


Building gnome failed

Describe the bug
A clear and concise description of what the bug is.
Steps To Reproduce
Steps to reproduce the behavior:

nix-env -iA nixos.gnome
...
...

Expected behavior
On trying to install gnome, it gets an error while installing gnome-documents
Notify maintainers

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/b6lg7x9x7ya3g3vfsnpw5wypw0sh7gin-gnome-documents-3.34.0.tar.xz
source root is gnome-documents-3.34.0
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file gnome-documents-3.34.0/subprojects/libgd/test-tagged-entry.c
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
applying patch /nix/store/jszq563rv6p07ajq5qgsdrq4jlw60x5r-0f55a18c40a61e6ae4ec4652604775f139892350.diff
patching file getting-started/meson.build
patching script interpreter paths in meson_post_install.py
meson_post_install.py: interpreter directive changed from "#!/usr/bin/env python3" to "/nix/store/wq6s8i407ic4qp1dvd5yhrnd0kflzh6x-python3-3.9.12/bin/python3"
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
meson flags: --buildtype=plain         --libdir=/nix/store/f13p6fd267f0qwpq65xajywbl3mnw0d4-gnome-documents-3.34.0/lib --libexecdir=/nix/store/f13p6fd267f0qwpq65xajywbl3mnw0d4-gnome-documents-3.34.0/libexec         --bindir=/nix/store/f13p6fd267f0qwpq65xajywbl3mnw0d4-gnome-documents-3.34.0/bin --sbindir=/nix/store/f13p6fd267f0qwpq65xajywbl3mnw0d4-gnome-documents-3.34.0/sbin         --includedir=/nix/store/f13p6fd267f0qwpq65xajywbl3mnw0d4-gnome-documents-3.34.0/include         --mandir=/nix/store/f13p6fd267f0qwpq65xajywbl3mnw0d4-gnome-documents-3.34.0/share/man --infodir=/nix/store/f13p6fd267f0qwpq65xajywbl3mnw0d4-gnome-documents-3.34.0/share/info         --localedir=/nix/store/f13p6fd267f0qwpq65xajywbl3mnw0d4-gnome-documents-3.34.0/share/locale         -Dauto_features=enabled         -Dwrap_mode=nodownload         --prefix=/nix/store/f13p6fd267f0qwpq65xajywbl3mnw0d4-gnome-documents-3.34.0 -Dgetting_started=true
The Meson build system
Version: 0.57.1
Source dir: /build/gnome-documents-3.34.0
Build dir: /build/gnome-documents-3.34.0/build
Build type: native build
Project name: gnome-documents
Project version: 3.34.0
C compiler for the host machine: gcc (gcc 10.3.0 "gcc (GCC) 10.3.0")
C linker for the host machine: gcc ld.bfd 2.35.2
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /nix/store/561d5sd2r3ih63v7n38k2pgx4bhibl0m-pkg-config-wrapper-0.29.2/bin/pkg-config (0.29.2)
Run-time dependency gjs-1.0 found: YES 1.70.0
Run-time dependency evince-document-3.0 found: YES 41.3
Run-time dependency evince-view-3.0 found: YES 41.3
Run-time dependency glib-2.0 found: YES 2.70.1
Run-time dependency gnome-desktop-3.0 found: YES 41.1
Run-time dependency gobject-introspection-1.0 found: YES 1.70.0
Run-time dependency gtk+-3.0 found: YES 3.24.30
Run-time dependency libsoup-2.4 found: YES 2.74.1
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency tracker-control-2.0 found: NO (tried pkgconfig)
meson.build:62:0: ERROR: Dependency "tracker-control-2.0" not found, tried pkgconfig
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
this path will be fetched (0.06 MiB download, 0.30 MiB unpacked):
  /nix/store/pbh7amf03i8fj84x5gh5dw2ir6g20w04-bash-interactive-5.1-p8-dev
copying path '/nix/store/pbh7amf03i8fj84x5gh5dw2ir6g20w04-bash-interactive-5.1-p8-dev' from 'https://cache.nixos.org'...
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.34, NixOS, 22.05 (Quokka)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.4`
 - channels(root): `"nixos-21.11.337241.a3917caedfe"`
 - channels(hikari): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Installing GNOME using nix-env is not supported, it requires various global changes that only NixOS module can do. If you want to install specific apps, you will need to list them individually.

meson.build:62:0: �[1;31mERROR:�[0m Dependency "tracker-control-2.0" not found, tried pkgconfig

For the build log you posted, gnome-documents has been archived on upstream and marked as broken in Nixpkgs because it does not support Tracker 3 so the build failure is expected.
https://github.com/NixOS/nixpkgs/blob/72cce37c479161163a436a9a2ee642532856790d/pkgs/desktops/gnome/apps/gnome-documents/default.nix#L120

The broken packages were removed in https://github.com/NixOS/nixpkgs/pull/197884


Fix the custom ApiDeploy commend docs

The docs showed using DeployApi, but the command is actually ApiDeploy.

Coverage remained the same at 100.0% when pulling 783b93ac9930075c2afed96e65a62f5d057e40a7 on jthomerson:patch-1 into af37d2d858814e4338b334ecd81aa0f6259abc8b on carlnordenfelt:master.

Thanks for spotting that :)


Not able to switch the activation of a token in the details page

User Story
The API Tokens details page is not allowing users to switch from deactivated to activated. Below is a video showing the problem.
Definition of Done
Admin can switch a token from deactivated to activated in the API Tokens details page.
Demo Script / Repro Steps

Navigate to Settings > API Tokens
Deactivate a token
Open the tokens details page by clicking on the tokens name
Select the Activate radio button
Try to select save.

Below is a short clip of the behavior:
https://drive.google.com/file/d/1EDMETrtw-woL1MaT4DU89uLURYlqmbJj/view?usp=sharing

@lancewf this one is a dup of #1169
could you add ur details to that one along with the video
and then close this?

@susanev I think this is a different problem than #1169, because when changing the state the save button does not enable. The user can not save the new state. Where #1169 is wanting a feature where if the state is changed back to the same state as before the save should be disabled.

oh i see! thanks for clarifying

this work has been deprioritized, so closing.


El proyecto es muy interesante y espero poder actualizarlo.

Hello, the program is very good, but Taiwan belongs to China, it should not be a country alone, it can only be a region.

@domainbf Hello, thanks reporting this! the data is coming directly from the API, so I’ll need to check things on that side. I’ll see what I can do from my end to address it .


Refactor - Shared logic for Transaction map to common class and ensuring mapping during broadcast

Features:

Added Tariff ID on session mapping
Added IdToken mapping during Transaction event emit to ensure necessary information on broadcast
Added mapping through LocationDTO for Location ID, EVSE ID, and Connector ID
Refactored common logic into BaseTransactionMapper (GET Tokens, GET Locations)

Core PR:
https://github.com/citrineos/citrineos-core/pull/173

@danielyoo227 @elliot-sabitov @yuvenus @langiole This PR introduces 'datasource' classes. I see here we have Sessions and Cdrs datasources. I don't feel good about making this refactor only for some modules. What is the LoE for incorporating this datasource pattern across the modules?

@thanaParis I see 7 other OCPI modules that would need to be refactored to support this. Assuming that they follow similar fetch patterns to Sessions and CDRs, I can estimate 1-2 hours for each module for refactor / testing. So I'd assume 1-2 days for the effort to incorporate the pattern across the modules. I can take this on and add it to this PR if we'd like to do this now.


NGA release

All the improvements made from milestone 6 to the pre-NGA sprint.

also rip conflict


libtiff: failed to install libtiff. nix cannot download tiff_4.0.7-6.debian.tar.xz from any mirror.

Issue description
failed to install libtiff. nix cannot download tiff_4.0.7-6.debian.tar.xz from any mirror.
Steps to reproduce
$ LC_ALL=C date; nix-env --version; nix-channel --list; nix-channel --update; nix-env -i libtiff
Tue Jun  6 10:37:00 JST 2017
nix-env (Nix) 1.11.9
nixpkgs https://nixos.org/channels/nixpkgs-unstable
downloading Nix expressions from ‘https://d3g5gsiof5omrk.cloudfront.net/nixpkgs/nixpkgs-17.09pre108299.ec9a23332f/nixexprs.tar.xz’...
downloading ‘https://d3g5gsiof5omrk.cloudfront.net/nixpkgs/nixpkgs-17.09pre108299.ec9a23332f/nixexprs.tar.xz’... [8243/8656 KiB, 3856.5 KiB/s]
unpacking channels...
installing ‘libtiff-4.0.7’
these derivations will be built:
  /home/saturday06/.local/nix/store/faz2l3gzp1d5bwk7wp7yz3shxrqw12z3-tiff_4.0.7-6.debian.tar.xz.drv
  /home/saturday06/.local/nix/store/37c4lbb7cc8s28qjgzf8sivpz1ha11hw-libtiff-4.0.7.drv
building path(s) ‘/home/saturday06/.local/nix/store/6v6d1yg5iy5gin8crfbqm9sjmhhfq5j9-tiff_4.0.7-6.debian.tar.xz’

trying http://http.debian.net/debian/pool/main/t/tiff/tiff_4.0.7-6.debian.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   332  100   332    0     0    783      0 --:--:-- --:--:-- --:--:--   784
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download tiff_4.0.7-6.debian.tar.xz from any mirror
builder for ‘/home/saturday06/.local/nix/store/faz2l3gzp1d5bwk7wp7yz3shxrqw12z3-tiff_4.0.7-6.debian.tar.xz.drv’ failed with exit code 1
cannot build derivation ‘/home/saturday06/.local/nix/store/37c4lbb7cc8s28qjgzf8sivpz1ha11hw-libtiff-4.0.7.drv’: 1 dependencies couldn't be built
error: build of ‘/home/saturday06/.local/nix/store/37c4lbb7cc8s28qjgzf8sivpz1ha11hw-libtiff-4.0.7.drv’ failed

Technical details

System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)

$ lsb_release -a
No LSB modules are available.
Distributor ID:	Debian
Description:	Debian GNU/Linux 7.9 (wheezy)
Release:	7.9
Codename:	wheezy

Nix version: (run nix-env --version)

$ nix-env --version
nix-env (Nix) 1.11.9

Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)

$ nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion
"17.09pre108299.ec9a23332f"

Sandboxing enabled: (run grep build-use-sandbox /etc/nix/nix.conf)

$ cd <nix installation prefix>
$ grep -r build-use-sandbox *
nix/store/bnhhal6k69yrkzk1yf6gi3nr44qdg22s-nixpkgs-17.09pre108299.ec9a23332f/nixpkgs/.github/ISSUE_TEMPLATE.md:* Sandboxing enabled: (run `grep build-use-sandbox /etc/nix/nix.conf`)
nix/store/bnhhal6k69yrkzk1yf6gi3nr44qdg22s-nixpkgs-17.09pre108299.ec9a23332f/nixpkgs/.github/PULL_REQUEST_TEMPLATE.md:    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)
nix/store/bnhhal6k69yrkzk1yf6gi3nr44qdg22s-nixpkgs-17.09pre108299.ec9a23332f/nixpkgs/nixos/modules/services/misc/nix-daemon.nix:        build-use-sandbox = ${if (builtins.isBool cfg.useSandbox) then boolToString cfg.useSandbox else cfg.useSandbox}
share/doc/nix/manual/manual.html:    multi-user settings with untrusted users.

build-use-sandbox

If set to true, builds will be

Can confirm, URL is dead. This won't affect most users because it's available through binary caches, but it would probably be sensible not to rely on debian's package repositories for packages that may just change or disappear beneath our feet. This is a similar issue in nature to #25702 and it would be nice to avoid these…

Addressed by #26452, but it will probably need picking to 17.03 as well.

http://http.debian.net/debian/pool/main/t/tiff/tiff_4.0.8-2.debian.tar.xz does not exist anymore either.

This seems to have been fixed by edf6176


添加安全组api文档

这个 PR 实现什么功能/修复什么问题:
添加安全组,EIP, keypair api文档
是否需要 backport 到之前的 release 分支:
None
/area docs
/cc @swordqiu @yousong

Codecov Report

Merging #1890 into master will increase coverage by <.01%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9e2bb...f8515e4. Read the comment docs.

/approve
/lgtm


Revert PR #96

Yeah, I had already noticed there is where the issue was coming from and reverted it myself. It's fixed in the latest CF release that I released earlier, but thanks anyway creeper!


better error handling

Work in progress.
TODO:

refactor consumer
fix tests

Moved to https://github.com/klarna/brod/pull/8.


Where can I find c++ example of token authentication?

I am looking for a C++ helloworld-like server/client example using token based authentication (preferably OAuth2 or JWT). So far my search does not return useful results yet. Thanks for the help.

We have some examples for auth with google APIs: https://grpc.io/docs/guides/auth.html
I am not sure whether this is what you asked for.

Preferably, I would like to have more concrete example with enough details that is ready to build and test, instead of just snippets although they are still very informative. For example, something like this one https://github.com/grpc/grpc/issues/9593, there is one complete code example that tells you everything you need to set up SSL/TLS channels from scratch: the server side, the client side, and even the cert part. I wonder if you have something similar but only with SSL/TLS authentication replaced with token authentication.

Perhaps something like this one? https://github.com/enricofoltran/hello-auth-grpc, only that it is written in Go not C++. Anyway, I think I've made my point clear. Thanks for the help.


[FLINK-9312] [security] Add mutual authentication for RPC and data plane

What is the purpose of the change
Currently, the Flink processes encrypted connections via SSL:

Data exchange TM - TM

RPC JM - TM

Blob Service JM - TM

(Optionally to ZooKeeper and connectors, this is connector specific and not in scope of this change)

However, the server side always accepts any client to build up the connection, meaning the connections are not strongly authenticated. Activating SSL mutual authentication strengthens this significantly - only TaskManagers and JobManagers that have access to the same certificate can connect to each other.
Brief change log

Activate mutual auth in akka (via akka config)
Activate mutual auth in Netty for data shuffles via SSLContext and SSLEngine parameters

Verifying this change

Adds a test to the NettyClientServerSslTest

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

I will take a look at this later today.

This is relevant http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Discuss-FLIP-26-SSL-Mutual-Authentication-td22188.html

This looks great but let's please separate the intra-cluster SSL configuration options from the external-cluster options.  In particular, the web/API endpoints should be governed by a different keystore and truststore than are the internal endpoints.  Likewise, the "hostname verification" option should pertain only to external connectivity.
My rationale is that:

the truststore to be used for internal connectivity must be highly restrictive; it should never be the system truststore.  Meanwhile, the truststore for external connectivity (e.g. from the Flink client) should typically be the system truststore.
The certificate to be used for internal connectivity may simply be a generated certificate.  Meanwhile, the certificate for external connectivity should be obtained from a cluster CA.  For example, in K8s one might expect a cert obtained from the cluster CA and with a CN corresponding to a Service resource (flink.default.svc.cluster.local).

The whole issue of using a restrictive truststore for internal connectivity has been discussed on various Akka forums, for example this PR.    Keep in mind that Akka has no authorization layer; any authenticated client is considered authorized.   Therefore, a liberal truststore (such as the system truststore) would present an extremely low barrier of entry since public SSL certs are easy to get.

I agree, we need different key/truststores for the internal/external connectivity. This PR was meant as a step in that direction, separating at least within the SSL Utils the internal and external context setup.
In your thinking, is there ever a case for a different internal authentication method than "single trusted certificate"? What if were not tied to akka? (Side note: I think for internal communication, 'authentication is authorization' is probably reasonable, because the are no different users/roles for internal communication).
Would you assume that internally, we never do hostname verification?

To be honest I don't see a great need to support anything other than a single trusted certificate for internal communication.    We could easily build some conveniences around that, like generating a certificate upon cluster startup with an truststore containing only that certificate.   I see no need to perform hostname verification because the truststore is constrained.
One drawback is that the queryable state interface is practically inaccessible because the cluster certificate is likely unknown to the client.
Regarding external connectivity, I don't think that mutual SSL is universally applicable, and I explore some options in FLIP-26.

@StephanEwen I would like to work on this issue, building on your PR, would that be OK?

@EronWright Just saw this - I have concurrently reworked this PR into #6326  which does things more cleanly. I would like to get that PR in for 1.6 (got many users asking for this).
I would be happy if you want to build on top of that for the next steps...

This PR is subsumed by #6326


ADR records for multiple queuing systems and bunny-mock

https://trello.com/c/bFnfSdqI/167-implement-message-requeuing-when-using-the-new-index

@MatMoore @brenetic I have now completed the above updates.
I have removed the second ADR (it was just a placeholder) and will look to add that in a separate PR


configurable_file_extension

Allow configuration of file extension in a case where the source file has none; ".log" is not so good assumption for more general use cases. ".log" was kept as a default.
Following this several variable names were renamed to reflect this change in the crate.
Fix issue where ".log" extension was hardcoded into filename even if original file had ".log" extension. This was also now extended with the configurable file extension functionality.
Restructure code a bit as DirEntry does not support .clone()

Looks good, thank you!


Switch to aioairctrl?

Hey there,
I'd like to point out aioairctrl (https://github.com/rgerganov/py-air-control/issues/93) which seems to solve the issues of unresponsive updates from py-air-ctrl as the latest Philips FW seems to have switched to a more passive observer model and doesn't reliable respond to status requests anymore (see the issue).
I've been hackishly rewriting homebridge-philips-air to use this library and the results have been pretty good. Both commands get sent a lot faster and without a big delay as well as the polling is much improved and reacts pretty quickly (as it's passively observing the purifiers vs. actively polling).
https://github.com/sieren/homebridge-philips-air/commit/aa2752afd49f85939b6f22d69ff52ae0ed405f16 this is extremely hacky as I ditched a bunch of code in favor of making it work wiht my own unit first, refactored accessories to their own class and added support for Eve Room 2 simulation to display pm2.5 values in the Eve Home app.

Hello
Thanks for you work )
I will Switch to aioairctrl later

Or you can change and pull request

@NikDevx any update on this?

https://github.com/seydx/homebridge-philipsair-platform


Support custom TopologyKey in Affinity Assistant

Feature Request
Currently AffinityAssistant hardcodes kubernetes.io/hostname as the Affinity TopologyKey:
https://github.com/tektoncd/pipeline/blob/08177fab0e2f2d2cc8e30e67f018a552338fca26/pkg/pod/pod.go#L335
This setting results in a "scheduler deadlock" when some of the Task's pods fit in one node but not all of them. To solve this, we'd like to use the availability zone as the topology key instead, but due to the setting being hardcoded we must implement our own Affinity Assistant. Is there a reason not to support a custom TopologyKey?

/kind feature
cc @jlpettersson

/kind feature
cc @jlpettersson

This setting results in a "scheduler deadlock" when some of the Task's pods fit in one node but not all of them.

My experience of this is that the pods that did not get "place" on the node, will be run when the first task-pods has completed, so they all eventually complete.

we'd like to use the availability zone as the topology key instead

The point with the AA was to provide "Node Affinity", since "Zone Affinity" doesn't solve the problem.
As described in https://github.com/tektoncd/pipeline/pull/2630
But the Affinity Assistant can be disabled

the setting being hardcoded

This is a bit unfortunate. My initial though was that we could provide a possibility to add a custom PodSpec for the Affinity Assistant - but this has not been implemented.
Now, the Affinity Assistant has some shortcomings, e.g. the one you describe, and its future is questioned e.g. see Design doc: Task parallelism when using workspace, so my opinion is that we should not add new API-things that is specific for the Affinity Assistant, but rather find a different solution to the problem, e.g. the one described in https://github.com/tektoncd/community/pull/318

This setting results in a "scheduler deadlock" when some of the Task's pods fit in one node but not all of them.

My experience of this is that the pods that did not get "place" on the node, will be run when the first task-pods has completed, so they all eventually complete.

we'd like to use the availability zone as the topology key instead

The point with the AA was to provide "Node Affinity", since "Zone Affinity" doesn't solve the problem.
As described in https://github.com/tektoncd/pipeline/pull/2630
But the Affinity Assistant can be disabled

the setting being hardcoded

This is a bit unfortunate. My initial though was that we could provide a possibility to add a custom PodSpec for the Affinity Assistant - but this has not been implemented.
Now, the Affinity Assistant has some shortcomings, e.g. the one you describe, and its future is questioned e.g. see Design doc: Task parallelism when using workspace, so my opinion is that we should not add new API-things that is specific for the Affinity Assistant, but rather find a different solution to the problem, e.g. the one described in https://github.com/tektoncd/community/pull/318

My experience of this is that the pods that did not get "place" on the node, will be run when the first task-pods has completed, so they all eventually complete.

That would generally be the case, but there are a few situations that result in a deadlock:

The node has reached its pod count limit, or there's a namespace pod quota in place and the Assistant takes that last pod spot.
A task requests more resources than others.

The point with the AA was to provide "Node Affinity", since "Zone Affinity" doesn't solve the problem.
As described in #2630

#2630 mentions issues with pods spread among different zones, but within an availability zone there shouldn't be any PVC visibility problem. We are currently running an almost exact copy of Tekton's Affinity Assistant with AZ affinity and everything works as intended.

Now, the Affinity Assistant has some shortcomings, e.g. the one you describe, and its future is questioned e.g. see Design doc: Task parallelism when using workspace, so my opinion is that we should not add new API-things that is specific for the Affinity Assistant, but rather find a different solution to the problem, e.g. the one described in tektoncd/community#318

Though I agree that including the full PipelineRun inside a single pod aligns better with Kubernetes scheduling and it's cleaner than an Assistant, it is also true that using an Assistant with an AZ TopologyKey solves all those problems. In addition, it would be harder to schedule very large Pipelines with that proposed solution.

My experience of this is that the pods that did not get "place" on the node, will be run when the first task-pods has completed, so they all eventually complete.

That would generally be the case, but there are a few situations that result in a deadlock:

The node has reached its pod count limit, or there's a namespace pod quota in place and the Assistant takes that last pod spot.
A task requests more resources than others.

The point with the AA was to provide "Node Affinity", since "Zone Affinity" doesn't solve the problem.
As described in #2630

#2630 mentions issues with pods spread among different zones, but within an availability zone there shouldn't be any PVC visibility problem. We are currently running an almost exact copy of Tekton's Affinity Assistant with AZ affinity and everything works as intended.

Now, the Affinity Assistant has some shortcomings, e.g. the one you describe, and its future is questioned e.g. see Design doc: Task parallelism when using workspace, so my opinion is that we should not add new API-things that is specific for the Affinity Assistant, but rather find a different solution to the problem, e.g. the one described in tektoncd/community#318

Though I agree that including the full PipelineRun inside a single pod aligns better with Kubernetes scheduling and it's cleaner than an Assistant, it is also true that using an Assistant with an AZ TopologyKey solves all those problems. In addition, it would be harder to schedule very large Pipelines with that proposed solution.

#2630 mentions issues with pods spread among different zones

Yes, #2630 address two problems in one. Both "Task parallelism" and "Regional Clusters". It was not described as two different problems in that issue, I apologize for that. This is more clearly described in https://github.com/tektoncd/pipeline/issues/3563
The property that solves "Task parallelism" (this is specific for PVCs with RWO access mode) is the "Node Affinity" property, "Zone Affinity" does not solve that. The "Node Affinity" also makes sequential Pipeline faster, since the PVC is only mounted once - this was a positive non-intended side-effect.
The property that solves "Regional clusters" (this is specific for PVC with non-regional storageClass) is the limitation to only use at most one PVC per Task. So effectively I don't think the AA is needed for this as long as that limitation is followed. I think I have stated different before, but yeah it was not clear when #2630 was written, but more clearly described in #3563
You may have a situation where you only have the latter problem, depending on what PVCs you are using.

that using an Assistant with an AZ TopologyKey solves all those problems

An AZ TopologyKey does not solve the "Task parallelism"-problem for PVCs with RWO access modes. But, yes, you are right, it might help "Regional Clusters" if you use PVCs with RWM access modes but only zonal storageClass, good point.

In addition, it might be harder to schedule very large Pipelines with that proposed solution.

This is a problem also with the Affinity Assistant solution, as your issue shows, especially regarding, as you said:

The node has reached its pod count limit and the Assistant takes that last pod spot. (this was new for me)
A task requests more resources than others.

The solution in tektoncd/community#318 solves both those problems, but as you say large Pipelines is not without scheduling problems with that solution either, in general using dedicated nodes for pipeline-workload should help for this problem both when using the single-pod solution and when using the affinity-assistant solution, but yes, there might be a gap when using PVCs with PWM access mode and regional clusters - using only one AZ using nodeSelectors or Toleration is probably the best workaround currently for this setup?

#2630 mentions issues with pods spread among different zones

Yes, #2630 address two problems in one. Both "Task parallelism" and "Regional Clusters". It was not described as two different problems in that issue, I apologize for that. This is more clearly described in https://github.com/tektoncd/pipeline/issues/3563
The property that solves "Task parallelism" (this is specific for PVCs with RWO access mode) is the "Node Affinity" property, "Zone Affinity" does not solve that. The "Node Affinity" also makes sequential Pipeline faster, since the PVC is only mounted once - this was a positive non-intended side-effect.
The property that solves "Regional clusters" (this is specific for PVC with non-regional storageClass) is the limitation to only use at most one PVC per Task. So effectively I don't think the AA is needed for this as long as that limitation is followed. I think I have stated different before, but yeah it was not clear when #2630 was written, but more clearly described in #3563
You may have a situation where you only have the latter problem, depending on what PVCs you are using.

that using an Assistant with an AZ TopologyKey solves all those problems

An AZ TopologyKey does not solve the "Task parallelism"-problem for PVCs with RWO access modes. But, yes, you are right, it might help "Regional Clusters" if you use PVCs with RWM access modes but only zonal storageClass, good point.

In addition, it might be harder to schedule very large Pipelines with that proposed solution.

This is a problem also with the Affinity Assistant solution, as your issue shows, especially regarding, as you said:

The node has reached its pod count limit and the Assistant takes that last pod spot. (this was new for me)
A task requests more resources than others.

The solution in tektoncd/community#318 solves both those problems, but as you say large Pipelines is not without scheduling problems with that solution either, in general using dedicated nodes for pipeline-workload should help for this problem both when using the single-pod solution and when using the affinity-assistant solution, but yes, there might be a gap when using PVCs with PWM access mode and regional clusters - using only one AZ using nodeSelectors or Toleration is probably the best workaround currently for this setup?

True, AZ affinity doesn't solve Task parallelism, but it's marginally better than current single-node affinity, it solves the scheduling issue if you don't need parallelism.
Using AZ nodeSelectors, correct me if I'm wrong, would entail setting the AZ in advance. With the Assistant we can just let it get scheduled anywhere and all other pods will follow, it has better AZ failure toleration.

True, AZ affinity doesn't solve Task parallelism, but it's marginally better than current single-node affinity, it solves the scheduling issue if you don't need parallelism.
Using AZ nodeSelectors, correct me if I'm wrong, would entail setting the AZ in advance. With the Assistant we can just let it get scheduled anywhere and all other pods will follow, it has better AZ failure toleration.

Using AZ nodeSelectors, correct me if I'm wrong, would entail setting the AZ in advance. With the Assistant we can just let it get scheduled anywhere and all other pods will follow, it has better AZ failure toleration.

Yes, this is correct.
The currently best workaround to that is to set nodeSelectors in the PipelineRun - using a custom "Mutating Webhook" to, perhaps randomly (or intelligently?) set the nodeSelector for the PipelineRun. I have not tested this setup, but it might be a way to address the problem you describe?

Using AZ nodeSelectors, correct me if I'm wrong, would entail setting the AZ in advance. With the Assistant we can just let it get scheduled anywhere and all other pods will follow, it has better AZ failure toleration.

Yes, this is correct.
The currently best workaround to that is to set nodeSelectors in the PipelineRun - using a custom "Mutating Webhook" to, perhaps randomly (or intelligently?) set the nodeSelector for the PipelineRun. I have not tested this setup, but it might be a way to address the problem you describe?

True, AZ affinity doesn't solve Task parallelism

Now, I don't understand what problems you are solving with a custom affinity assistant for AZ-affinity. Isn't this problem solved without any Affinity Assistant but just following the limit to use at most one PVC per TaskRun (Pod)? My experience is that should solve this problem alone.

True, AZ affinity doesn't solve Task parallelism

Now, I don't understand what problems you are solving with a custom affinity assistant for AZ-affinity. Isn't this problem solved without any Affinity Assistant but just following the limit to use at most one PVC per TaskRun (Pod)? My experience is that should solve this problem alone.

We'd need to somehow retrieve available AZs in the current cluster, it's kind of hackier than the Assistant solution, as we don't need to know or care about the available AZs, so I think we'll stick to our custom Assistant for now. We just wondered if it made sense to put together a PR to support that in Tekton itself instead of duplicating an Assistant that already exists, but as you pointed out, it doesn't solve every problem.
Thanks!

We'd need to somehow retrieve available AZs in the current cluster, it's kind of hackier than the Assistant solution, as we don't need to know or care about the available AZs, so I think we'll stick to our custom Assistant for now. We just wondered if it made sense to put together a PR to support that in Tekton itself instead of duplicating an Assistant that already exists, but as you pointed out, it doesn't solve every problem.
Thanks!

Now, I don't understand what problems you are solving with a custom affinity assistant for AZ-affinity. Isn't this problem solved without any Affinity Assistant but just following the limit to use at most one PVC per TaskRun (Pod)? My experience is that should solve this problem alone.

We have a PipelineRun which starts with a git-clone task that is later used by other tasks. We need to make sure all task pods get scheduled in the same AZ to keep the workspace PVC visible to all of them. WIth default Assistant we randomly hit the scheduler deadlock that I mentioned, with AZ affinity that problem gets solved.

Now, I don't understand what problems you are solving with a custom affinity assistant for AZ-affinity. Isn't this problem solved without any Affinity Assistant but just following the limit to use at most one PVC per TaskRun (Pod)? My experience is that should solve this problem alone.

We have a PipelineRun which starts with a git-clone task that is later used by other tasks. We need to make sure all task pods get scheduled in the same AZ to keep the workspace PVC visible to all of them. WIth default Assistant we randomly hit the scheduler deadlock that I mentioned, with AZ affinity that problem gets solved.

With default Assistant we randomly hit the scheduler deadlock that I mentioned, with AZ affinity that problem gets solved.

I can see that problem with the Affinity Assistant. But what problems do you get with this kind of Pipeline with the Affinity Assistant disabled?
My understanding is that should work equally good as your custom Affinity Assistant. But I am interesting to hear what issue you run into if not.

With default Assistant we randomly hit the scheduler deadlock that I mentioned, with AZ affinity that problem gets solved.

I can see that problem with the Affinity Assistant. But what problems do you get with this kind of Pipeline with the Affinity Assistant disabled?
My understanding is that should work equally good as your custom Affinity Assistant. But I am interesting to hear what issue you run into if not.

Sorry I just edited my previous answer. I was wondering how using one PVC per TaskRun would allow us to share the workspace between tasks.

Sorry I just edited my previous answer. I was wondering how using one PVC per TaskRun would allow us to share the workspace between tasks.

Would we be able to share a workspace between all tasks with your proposed solution?

Yes, to let multiple Tasks share data via a PVC Workspace did work before the Affinity Assistant was introduced in #2630
What did not work, is to use two or more PVC Workspaces in a single Task in a regional cluster, since the two PVCs might be located in different AZs.
So I am interested to hear if you run into issues with your Pipeline when disabling the Affinity Assistant. What does not work well is to have two parallel task to concurrently access the Workspace, but this does not work with only AZ-affinity as well.
There might be different behavior depending on the volumeBindingMode for your storageClass. But I don't think that should affect your use case, it is a behavior that is a bit difficult to grasp.

Would we be able to share a workspace between all tasks with your proposed solution?

Yes, to let multiple Tasks share data via a PVC Workspace did work before the Affinity Assistant was introduced in #2630
What did not work, is to use two or more PVC Workspaces in a single Task in a regional cluster, since the two PVCs might be located in different AZs.
So I am interested to hear if you run into issues with your Pipeline when disabling the Affinity Assistant. What does not work well is to have two parallel task to concurrently access the Workspace, but this does not work with only AZ-affinity as well.
There might be different behavior depending on the volumeBindingMode for your storageClass. But I don't think that should affect your use case, it is a behavior that is a bit difficult to grasp.

If we remove the Assistant, won't the task pods get scheduled anywhere, maybe into different zones? Does the PipelineRun ensure somehow that the workspace remains visible to all of them?

If we remove the Assistant, won't the task pods get scheduled anywhere, maybe into different zones? Does the PipelineRun ensure somehow that the workspace remains visible to all of them?

A Pod using a PVC is usually scheduled to the PVC - this is e.g. how it works when the PVC is a local disk - this is also how Tekton worked before #2630
But storage is a complicated field, so I can not promise, but it sounds like it should work that way for you too. But it might depend on how your storage system is working. I am interested to hear if you get issues without the Affinity Assistant.
The case I know that does not work is when a task use two PVCs, those two PVCs has been used by two different previous tasks that might have run in two different AZs. This was the case in https://github.com/tektoncd/pipeline/pull/2546

A Pod using a PVC is usually scheduled to the PVC - this is e.g. how it works when the PVC is a local disk - this is also how Tekton worked before #2630
But storage is a complicated field, so I can not promise, but it sounds like it should work that way for you too. But it might depend on how your storage system is working. I am interested to hear if you get issues without the Affinity Assistant.
The case I know that does not work is when a task use two PVCs, those two PVCs has been used by two different previous tasks that might have run in two different AZs. This was the case in https://github.com/tektoncd/pipeline/pull/2546

We will try, but my understanding is that the workspace PVC is created at the PipelineRun level. In our case, our storage backend is AWS EBS, so the PVC is visible through the AZ. If the different task pods are scheduled in different AZs, I fail to see how that workspace PVC can be shared between task pods. Maybe I'm missing something.

We will try, but my understanding is that the workspace PVC is created at the PipelineRun level. In our case, our storage backend is AWS EBS, so the PVC is visible through the AZ. If the different task pods are scheduled in different AZs, I fail to see how that workspace PVC can be shared between task pods. Maybe I'm missing something.

Closing this up, @jlpettersson thanks a lot for your help!

Closing this up, @jlpettersson thanks a lot for your help!


docs: Add v5 notice

v5 Notice in Readme

Looks like Calico updated their docs and moved things around


[Feature Request] Exclude episodes from schedule items

Would be nice to add the ability to exclude episodes from a schedule item based on certain criteria. For example, Episodes or seasons that do not contain english audio. I am not sure if .ass subtitles work or not, but I could not get them to, nor do I really want to burn subtitles. However, I have some shows where some episodes are not yet dubbed in english.
I could just manually go through every season to see what is dubbed and only add those certain seasons. But it would be nice if when those episodes meet the criteria (english audio) they automatically become available in the schedule.

If you use smart collections you can use language or language_tag to automatically filter. See https://ersatztv.org/docs/user-guide/search


Hide unnecessary files

Description
Migration of this https://github.com/sindresorhus/hide-files-on-github
That project is facing problems with manifest v2 removal
Even if it doesn't fit requirements for inclusion here, could we maybe fork/move it into the refined-github org for continued development by the community?
Example URLs
https://github.com/refined-github/refined-github

The repo was archived because there was no interest to maintain it on either side. Feel free to fork it and publish it. You can ask Sindre for the store names too


build(lib): do not run build script based on changes to kernel_v0.rs

https://github.com/0xPolygonMiden/miden-base/pull/887 added a build script that builds kernel_v0.rs, but the script runs on changes to the file itself. I suspect this was the reason for test times doubling after that PR as pointed out in https://github.com/0xPolygonMiden/miden-base/issues/903.
This PR simply removes this rerun check. I doubt this check is the correct behaviour either way, since if it reruns based on changes to the kernel_v0.rs, it means it reruns every time the file is generated - which means the build script is triggered between each invocation of cargo nextest as well.
I've tested this in my personal repo - the run is here: https://github.com/eightfilms/miden-base/actions/runs/12064550221/job/33641593187 and is based on this branch: https://github.com/eightfilms/miden-base/tree/refs/heads/kernel-build-once. There is no longer recompilation between the different test steps, which means we should expect to see CI times for the test step go back down to ~15 minutes from ~40 minutes (which is similar to the last commit prior to #887)

Thank you, I think your diagnosis is correct. I wonder if the kernel errors file should also be removed in a similar fashion.
More generally I think the issue is that we're generating code in the source directory which isn't correct.

Thanks!
We recently had problems with the docs.rs docs not building and the build was failing because of a "read-only" filesystem. This was also because we're writing to src rather than OUT_DIR, e.g.:

We actually should not write into the src directory directly. I think build.rs files should always write into OUT_DIR (which can be written to in docs.rs environment) and then simply be included with something like include!(concat!(env!("OUT_DIR"), "/build_file.rs"));. docs.rs is setup with a read-only src directory because, I guess, it assumes that these best practices are followed. Us having problems with rustfmt and generated files in the past was basically also a symptom of us writing directly into src.
https://github.com/0xPolygonMiden/miden-base/pull/970#pullrequestreview-2438383707

So not necessarily for this PR, but it seems to me that it would be better to just move to the include approach and not write kernel_v0.rs and tx_kernel_errors.rs directly into src.
I'm curious why the CI times already went down even though the same problem should exist for the println!("cargo:rerun-if-changed={KERNEL_ERRORS_FILE}"); line, which is also built in that build.rs file. Shouldn't that file change roughly whenever the kernel_v0 file changes?

I'm curious why the CI times already went down even though the same problem should exist for the println!("cargo:rerun-if-changed={KERNEL_ERRORS_FILE}"); line, which is also built in that build.rs file. Shouldn't that file change roughly whenever the kernel_v0 file changes? (Edit: Ah @Mirko-von-Leipzig pointed this out already :D)

The error file write is skipped most of the time:
    // Skip this build script in BUILD_KERNEL_ERRORS environment variable is not set to `1`.
    if env::var("BUILD_KERNEL_ERRORS").unwrap_or("0".to_string()) == "1" {
        // Generate kernel error constants.
        generate_kernel_error_constants(&source_dir)?;
    }

@eightfilms could you also remove this ^^ variable from the rerun-if pragmas? This would wrap this PR up nicely, and we can go bikeshed internally over the dangers of generating code in-tree.

I'm curious why the CI times already went down even though the same problem should exist for the println!("cargo:rerun-if-changed={KERNEL_ERRORS_FILE}"); line, which is also built in that build.rs file. Shouldn't that file change roughly whenever the kernel_v0 file changes? (Edit: Ah @Mirko-von-Leipzig pointed this out already :D)

Probably because generating that file is gated behind an environment variable: https://github.com/0xPolygonMiden/miden-base/blob/main/miden-lib/build.rs#L80C5-L83C6
Regardless, +1 on the sentiment that writing into src is definitely not the best practice. We should definitely have a follow up PR that fixes this.

I'm curious why the CI times already went down even though the same problem should exist for the println!("cargo:rerun-if-changed={KERNEL_ERRORS_FILE}"); line, which is also built in that build.rs file. Shouldn't that file change roughly whenever the kernel_v0 file changes? (Edit: Ah @Mirko-von-Leipzig pointed this out already :D)

The error file write is skipped most of the time:
    // Skip this build script in BUILD_KERNEL_ERRORS environment variable is not set to `1`.
    if env::var("BUILD_KERNEL_ERRORS").unwrap_or("0".to_string()) == "1" {
        // Generate kernel error constants.
        generate_kernel_error_constants(&source_dir)?;
    }

@eightfilms could you also remove this ^^ variable from the rerun-if pragmas? This would wrap this PR up nicely, and we can go bikeshed internally over the dangers of generating code in-tree.

done


Document --no-default-bind option

1.16 will come with a new --no-default-bind command line option that disables binding to loopback interfaces (unless explicitly specified in a separate --bind or through --bind all).
(lengthy discussion about it in https://github.com/rethinkdb/rethinkdb/issues/3154)

I'm rolling this into #613 since it's already part of the new cli-options document being added.


fix: yarn berry + fetch + docker opti

:tada: This PR is included in version 1.5.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Refactoring the test for NStepRNNs

Related to #3042. The current tests for NStepRNNs are very redundant and hard to fix. We first need to refactoring them.

#4047 is merged. Does it solve the problem or should we keep this issue opened?

Check #4049

resolved via #4049


how to use on nixos

how to use on nixos or what should i install. i cant start the titlebar etc.

show me the error logs.

and sorry for the late response


Wagtail Live Receiver classes

Made a working Slack receiver - except for saving images received from Slack. I consistently get an IntegrityError like this:
django.db.utils.IntegrityError: NOT NULL constraint failed: wagtailimages_image.width

Basic blocks i.e TextMessageBlock, EmbedMessageBlock, ImageMessageBlock do not longer subclass BaseMessageBlock (all removed) since a message now maps to a LivePostBlock.
I have not documented it yet nor have I tested it. I'd like to know what should I keep and what not and then build upon that.
I've also added temporary comments here and there to explain the code.
I'm waiting for your feedback to enhance the PR.
(This is the way I figure out to show what I'm working on.)

I tried to send many messages in a very short time frame (I typed a letter and hit send 10 times+ in a row).
It was for another purpose but I got this error:
Traceback (most recent call last):
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/slack_bolt/listener/thread_runner.py", line 112, in run_ack_function_asynchronously
    listener.run_ack_function(request=request, response=response)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/slack_bolt/listener/custom_listener.py", line 49, in run_ack_function
    return self.ack_function(
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/wagtail_live/slack/app.py", line 20, in handle_message_events
    slack_receiver.dispatch(body["event"])
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/wagtail_live/slack/receivers.py", line 93, in dispatch
    self.add_message(message)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/wagtail_live/slack/receivers.py", line 187, in add_message
    live_page.save()
  File "/usr/local/lib/python3.9/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/wagtail/core/models.py", line 1052, in save
    result = super().save(**kwargs)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/modelcluster/models.py", line 196, in save
    super(ClusterableModel, self).save(update_fields=real_update_fields, **kwargs)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/models/base.py", line 726, in save
    self.save_base(using=using, force_insert=force_insert,
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/models/base.py", line 762, in save_base
    parent_inserted = self._save_parents(cls, using, update_fields)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/models/base.py", line 791, in _save_parents
    updated = self._save_table(
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/models/base.py", line 845, in _save_table
    updated = self._do_update(base_qs, using, pk_val, values, update_fields,
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/models/base.py", line 899, in _do_update
    return filtered._update(values) > 0
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/models/query.py", line 802, in _update
    return query.get_compiler(self.db).execute_sql(CURSOR)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/models/sql/compiler.py", line 1559, in execute_sql
    cursor = super().execute_sql(result_type)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/models/sql/compiler.py", line 1175, in execute_sql
    cursor.execute(sql, params)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/backends/utils.py", line 98, in execute
    return super().execute(sql, params)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/backends/utils.py", line 66, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/backends/utils.py", line 75, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/utils.py", line 90, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/home/users/etudiant/.virtualenvs/wagtail-live/lib/python3.9/site-packages/django/db/backends/sqlite3/base.py", line 423, in execute
    return Database.Cursor.execute(self, query, params)
django.db.utils.OperationalError: database is locked

django.db.utils.IntegrityError: NOT NULL constraint failed: wagtailimages_image.width
Typically you would get this error when Pillow is unable to read your image and wagtail therefore unable to set the width and height of the image on the model.

What would you suggest to fix it then?

Thanks for the feedback @lucasmoeskops!


ValueError: Couldn't assign input_ids with shape torch.Size([7, 346]), engine supports [min, opt, max] = [(1, 1), (2, 1), (4, 1024)]

BUG
ValueError: Couldn't assign input_ids with shape torch.Size([7, 346]), engine supports [min, opt, max] = [(1, 1), (2, 1), (4, 1024)]
INFO
[[TRT] [E] 3: [executionContext.cpp::setInputShape::2288] Error Code 3: API Usage Error (Parameter check failed at: runtime/api/executionContext.cpp::setInputShape::2288, condition: satisfyProfile Runtime dimension does not satisfy any optimization profile.)
input_ids: torch.Size([7, 346])
tensor([[    0,     0,     0,  ..., 55120, 30930,    13],
        [    0,     0,     0,  ..., 55120, 30930,    13],
        [    0,     0,     0,  ..., 35502, 30987,    13],
        ...,
        [    0,     0,     0,  ..., 38217, 30930,    13],
        [    0,     0,     0,  ..., 33727, 30930,    13],
        [    0,     0,     0,  ..., 33727, 30930,    13]], device='cuda:0',
       dtype=torch.int32)
input_lengths: torch.Size([7])
tensor([346, 346, 346, 346, 346, 346, 346], device='cuda:0', dtype=torch.int32)
Traceback (most recent call last):
  File "/code/tensorrt_llm/examples/chatglm2-6b/run_batch.py", line 134, in <module>
    output_ids = decoder.decode(input_ids, input_lengths, sampling_config)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/runtime/generation.py", line 514, in wrapper
    ret = func(self, *args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/runtime/generation.py", line 1887, in decode
    return self.decode_regular(
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/runtime/generation.py", line 1659, in decode_regular
    should_stop, next_step_buffer, tasks, context_lengths, host_context_lengths, attention_mask, logits = self.handle_per_step(
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/runtime/generation.py", line 1430, in handle_per_step
    self.runtime._set_shape(context, ctx_shape)
  File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/runtime/generation.py", line 202, in _set_shape
    raise ValueError(
ValueError: Couldn't assign input_ids with shape torch.Size([7, 346]), engine supports [min, opt, max] = [(1, 1), (2, 1), (4, 1024)]

wanted for help,please!

Hi @lizhixi212 ,
Thanks for reporting the issue. We'd need more details on the command-lines to used to build the engine.
However based on the error, I would guess that you built the engine with a max batch size of 4 and you're trying to run with a batch size of 7.
Couldn't assign input_ids with shape torch.Size([7, 346]), engine supports [min, opt, max] = [(1, 1), (2, 1), (4, 1024)]

Indeed, your input_ids tensor has a first dimension of 7 (that's how I infer that you run with batch size 7) when the engine supports at max (4, 1024) for the input_ids (i.e. a max batch size of 4 and a max sequence length of 1024).
I hope it helps.
Thanks,
Julien

you are absolutely right,i check build args:
parser.add_argument('--max_batch_size', type=int, default=4)
Thank you very much for your prompt reply.


HW4 Discussion

@Mosaddeq107 we can discuss our homework-related concerns and topics in the discussion section. Those topics which do not need to be an issue can be discussed over there. You can share your ideas in there.

Okay, good idea.

sure

ok

We can close this issue. Since we are already done with this.


Implement Manual Trigger Endpoint for Executing Splits on Specific Wallets

This pull request introduces a new POST endpoint that allows for the manual triggering of split executions on specific wallets.
Automatic split execution occasionally fails to trigger under certain conditions. To ensure reliability and control in these scenarios, we have developed an endpoint that addresses the challenge.
Implementation Details:
Feature: A new POST endpoint is added.
Functionality: This endpoint accepts a request body containing a wallet_id and an amount, enabling users to manually initiate split executions for the specified wallet.
Feedback on this implementation is welcomed to refine its functionality. We hope for collaborative improvement for the benefit of the community.

thanks for the contributiuon!

Automatic split execution occasionally fails to trigger under certain conditions. To ensure reliability and control in these scenarios, we have developed an endpoint that addresses the challenge.

i don't see this as a real solution for this problem, but an additional feature, endpoint where you can just split to those users and specify a custom amount, without the need of having a payment there in the first place. this could be useful if you have an initial amount in the wallet but did not create the split yet.
there could be a button on the ui, like we have for topup wallet with distribute to splits + amount utilizing this endpoint.

to the problem, maybe we can add an additional safety mechanism, where we fetch all payments of this wallet and check if there is payment.extra.get("splitted") and if not we retry splitting that payment on the on_invoice_paid event.
what do you think?

thanks for the contributiuon!

Automatic split execution occasionally fails to trigger under certain conditions. To ensure reliability and control in these scenarios, we have developed an endpoint that addresses the challenge.

i don't see this as a real solution for this problem, but an additional feature, endpoint where you can just split to those users and specify a custom amount, without the need of having a payment there in the first place. this could be useful if you have an initial amount in the wallet but did not create the split yet.
there could be a button on the ui, like we have for topup wallet with distribute to splits + amount utilizing this endpoint.

Why not simply have an option to check after each split was triggered if there is more balance in the wallet than fee reserve and if yes, split that balance sub fee reserve?

to the problem, maybe we can add an additional safety mechanism, where we fetch the latest 5 payments of this wallet and check if there is payment.extra.get("splitted") missing on some of those and if we retry splitting that payment on the on_invoice_paid event.
what do you think?

Is the plugin flagging the incoming transactions as splitted? Upon checking it seems the extra data is only on the transactions generated by the plugin, but not the source transactions.
If not, the best implementation would simply be both an automatic check on new invoice to see if the last few were split and an endpoint to manually check the last x transactions.


Better receiver names.

Addressing the TODO item:
Better receiver names

  - change `func (l *Log)` to `func (log *Log)` everywhere
  - change `func (s *Sub)` to `func (sub *Sub)` everywhere
  - change `func (ll *LogLine)` to `func (line *Line)` everywhere
  - change `func (s *Span)` to `func (span *Span)` everywhere
  - change `func (s Seed)` to `func (seed Seed)` everywhere

I don't understand why Unit Tests / test (1.19.x, windows-latest) (push) are failing... Need to investigate.

Thanks!


Turkish Number specs localized

The test cases here are the translations from the English counterparts.
The requested will be added in the next PRs


views: multiple deposits per site

Enhances deposit views to allow different deposit types to use
different jsonchemas and schemaforms. (closes #108)

LGTM

LGTM


cmp.mapping.confirm() not working in nvim 0.7.0

FAQ

[X] I have checked the FAQ and it didn't resolve my problem.

Issues

[X] I have checked existing issues and there are no open or closed issues with the same problem.

Neovim Version
NVIM v0.7.0-dev
nvim-cmp config
local cmp = require "cmp"
cmp.setup {
    snippet = {
        expand = function(args)
            require("luasnip").lsp_expand(args.body)
        end,
    },
    mapping = {
        ["<C-Space>"] = cmp.mapping.complete(),
        ["<C-CR>"] = cmp.mapping.confirm { select = true },
        ["<C-j>"] = cmp.mapping.select_next_item { behavior = cmp.SelectBehavior.Select },
        ["<C-k>"] = cmp.mapping.select_prev_item { behavior = cmp.SelectBehavior.Select },
        ["<C-h>"] = cmp.mapping.scroll_docs(-4),
        ["<C-l>"] = cmp.mapping.scroll_docs(4),
    },
    sources = {
        { name = "nvim_lsp" },
    },
}

Description
Any cmp.mapping.confirm() binding does not work on Neovim 0.7.0. I've tested iTerm2 and Kitty on both macOS and Linux.
Steps to reproduce
Map any key to cmp.mapping.confirm() in cmp.setup
Expected behavior
The selected menu entry gets inserted
Actual behavior
Menu closes and the keybinding is ignored.
Additional context
No response

I think CUI vim does not support  <C-CR>

It most certainly does. I've used it in older versions of nvim.

Did you test with <CR>? I don't change key mapping related inplementation. If you think nvim-cmp is reason of this provlem, please bisect the commit.


How can I distinguish between inplace and copy operations?

Problem description:
It's difficult to determine how/when to use inplace or create a copy and the behavior is inconsistent. Does pandas_flavor always require a copy/modifying the original dataframe? Is there a way to avoid this in order to save memory?
import pandas_flavor

# Does not replace original dataframe
@pandas_flavor.register_dataframe_method
def drop_empty_rows(dataframe):
    return dataframe.dropna(axis=0, how='all')

# Should replace original dataframe
@pandas_flavor.register_dataframe_method
def drop_empty_rows(dataframe):
    dataframe = dataframe.dropna(axis=0, how='all')
    return dataframe

# Should replace original dataframe
@pandas_flavor.register_dataframe_method
def drop_empty_rows(dataframe):
    dataframe_processed = dataframe.copy()
    dataframe_processed = dataframe.dropna(axis=0, how='all')
    return dataframe_processed

If I call the first function on a dataframe, it returns the dataframe with dropped rows but does not change the original dataframe.
dict_rows = {}
dict_rows['A']  = [20,numpy.nan,40,10,50]
dict_rows['B'] = [50,numpy.nan,10,40,50]
dict_rows['C'] = [30,numpy.nan,50,40,50]

dataframe = pandas.DataFrame(dict_rows)

This function returns the reduced dataframe, but doesn't affect the original dataframe.
>>> dataframe.drop_empty_rows()
      A     B     C
0  20.0  50.0  30.0
2  40.0  10.0  50.0
3  10.0  40.0  40.0
4  50.0  50.0  50.0

@DOH-Manada pandas-flavor doesnt copy. It just provides a convenient interface. The real work is in pandas. So you can also enable pandas copy on write which should take care of copy or not copy decisions for better memory performance


pip installation error

Describe the bug
An error was observed while installing Fosslight source

ERROR: Could not find a version that satisfies the requirement typecode_libmagic (from fosslight-source) (from versions: none)
ERROR: No matching distribution found for typecode_libmagic

To Reproduce
Install Fosslight source with command following

pip install fosslight-source
or
pip3 install fosslight-source

System environment (please complete the following information):

OS: Mac OS Big Sur
Python : 3.9.5

@JustinWonjaePark ,
ScanCode cannot be installed on mac m1 yet. Therefore, it is impossible to install FOSSLight Source Scanner on mac m1 yet.
In order to use it on mac m1, it is recommended to install and run it using Docker.


Components which install from bower did not have one min file.

Components which install from bower did not have one min file.
I would like to include one min file to my project.
Thanks

bower install bootstrap-bower. But this doc for ui-bootstrap confused us.


Add Woods, Chris as RC

I am nominating or self-nominating a Recognized Contributor.
Name: Woods, Chris
GitHub Username: @woodsmc
Nomination
Chris has been proactively driving the WebAssembly development for industrial and embedded usages. He is part of the group setting up the SIG-Embedded and one of the co-chairs.
Optional: Endorsements
Xin Wang (@xwang98)
I have read and understood the qualifications for a Recognized Contributor

The TSC has discussed this and agree that the contributions are worthy of recognition in the Bytecode Alliance.
@woodsmc, to finalize the addition, please send an email to<EMAIL_ADDRESS>to let us know which address to use for communicating with you as a Recognized Contributor, and to confirm that you accept the nomination.
That address will be added to our RCs mailing list, which receives community and project updates every few weeks or so.
Once we've received that email, we'll add you to the mailing list and merge this PR.
Thank you!

Thank you all!


nordic nrf-timer: Expose max frequency as DT property and use it in nrf counter driver

The counter driver needs to know what is the maximum counting frequency of each timer peripheral.
Let's add it to its DT, and let's use it in the driver directly instead of relaying on the HAL working it out.

Can you add checks that validate values in DT against NRF_TIMER_BASE_FREQUENCY_GET(p_reg)?
Also, nit - missing : in the second commit.

Right, but can you do something similar to:
https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/nordic/validate_base_addresses.c#L127
that checks if both values are identical - we need to make sure that stuff in DT is identical to HW configuration.
It can be even disabled for simulation targets if that's a problem.

Right, but can you do something similar to..

@masz-nordic I don't think there is a direct way of doing that today.
Note that NRF_TIMER_BASE_FREQUENCY_GET(), unfortunately, does not rely on the MDK
https://github.com/nrfconnect/nrfx/blob/master/hal/nrf_timer.h#L178-L220
Instead the nrfx hal keeps in macros the knowledge of which timer runs at which frequency based on the timer name.
During a discussion with @nika-nordic it seemed that macro implementation would be better changed.
To be able to rely on the MDK provided info, effectively we would need to implement a new NRF_TIMER_BASE_FREQUENCY_GET which would use the MDK TIMER*_PCLK_MHZ macros. (also note those are only provided for nRF54 devices, so we'd need that macro to fallback to 16MHz when that is not provided).
If that is desired, it seems to me it should be done as a separate task in the nrfx.

Added an extra commit as per @masz-nordic request


Allow the  users to download  Video  demonstations  .mp4 format

I watched  that video , voice  in video is  excellent and  author explained only one test .
I am requesting all the authors , if  possible  add  the  all most  all videos in .mp4 format.
Thanks for the article . Good luck to all authors

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4847662f-f333-d230-2a3a-192400d7ee0a
Version Independent ID: a452721c-59aa-1cd9-98e3-afdbe4dbd4c6
Content: Testing a Driver - Windows drivers
Content Source: windows-driver-docs-pr/develop/testing-a-driver.md
Product: windows-hardware
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Thanks for the suggestion @RAJU2529 but we don't currently have resources to modify or transcode these videos.


ZEPPELIN-1423 - Allow users to specify pre/post-execute hooks for interpreters

What is this PR for?
See #1439. This is a second attempt based on prior feedback, particularly from @Leemoonsoo who advised that it would be better to contain all of the code inside of the Interpreter Process. Aside from this, the major changes since the previous PR are:

The terminology "hooks" is used instead of "callbacks". Since the information being passed to the interpreter isn't actually a "callback", strictly speaking, the more general term "hook" is probably a better choice. All variable / class names were updated correspondingly.
The registry is now keyed by class name rather than the replName specified by the magic on top of the paragraph. The interface provided by ZeppelinContext allows for a replName to be converted to className through an internal mapping.
Two new event codes, PRE_EXEC_DEV and POST_EXEC_DEV have been added. This is primarily intended to separate use cases for the interpreter maintainers (via subclasses of Interpreter) and the notebook users (via the ZeppelinContext class), as otherwise user attempts at registering a hook would overwrite that set by the interpreter maintainer.
Global scope for hook registration is supported for the developer use cases.

What type of PR is it?
New Feature
What is the Jira issue?
ZEPPELIN-1423
How should this be tested?
In a new note, add the following lines of code to a paragraph:
%pyspark
z.registerHook("post_exec", "print 'This code should be executed before the paragraph code!'")
z.registerHook("pre_exec", "print 'This code should be executed after the paragraph code!'")

Then run any other paragraph in the note containing some other code, eg
%pyspark
print "This code should be entered into the paragraph by the user!"

The output should be:
This code should be executed before the paragraph code!
This code should be entered into the paragraph by the user!
This code should be executed after the paragraph code!

You should also test out the other two methods (getCallback() and unregisterCallback()) specified in ZeppelinContext.java.
One final caveat that should be mentioned: If there are errors in the code you specify for a pre-execute event, it will render the interpreter useless since the current implementation prepends the the code specified in pre_exec directly to the paragraph entered code before calling interpret(). The current workaround for this would be to either restart the interpreter group or call unregisterHook() via a different REPL within the interpreter group (eg, z.unregisterHook("pre_exec", "pyspark") from the spark interpreter). I would appreciate if anyone here would be willing to share any better approaches here.
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? Yes

@Leemoonsoo please review, thanks.

@Leemoonsoo Thanks for the review, I have provided some responses.

@Leemoonsoo I have addressed your second comment, let me know if this looks good to merge into master.

Apologies for late response. Changes LGTM.
Last CI failure is irrelevant  to this change.
Merge if there're no more discussion.
Thanks @agoodm for making step forward to ZEPPELIN-1344!


Update some old links to Android Market

Good eye! Thanks for updating the request. We'll have a .1 release soon enough that this will go out with.


Cosmos DB is not compatible with Xamarin.Forms anymore

I tried to update the Microsoft.EntityFrameworkCore.Cosmos package from nuget today, and suddenly realized the library was moved to the NetStandard2.1, which is much more restrictive than 2.0, and breaks compatibility with most platforms, like Xamarin.Forms. Is it intended cosmos db to work only with NetCore?

I'm seeing cosmos is not the only package with this change. The whole EntityFrameworkCore is dropping support for NetStandard 2.0
https://www.nuget.org/packages/Microsoft.EntityFrameworkCore/3.0.0-preview8.19405.11
Why? Will all the platforms WPF, UWP, Xamarin updated to support NetStandard2.1?

@arivoir This is a strategic decision around .NET as a whole, rather than something specific to EF Core.  Xamarin will target .NET Standard 2.1 (although I don't know the timeframe) and will continue to be a target for EF Core. WPF and UWP I can't comment on.

I see, thanks for the info.

@ajcvickers According to Xamarin guys, Xamarin will eventually have support for NetStandard 2.1, but there are no plans in the short term. Apparently it would be ready for Net 5. On the other hand, EntityFrameworkCore is dropping support for NetStandard 2.0 (According to the released packages in nuget) for .NetCore 3. This would be a really serious breaking change, since all the Xamarin will lose EF support (Or they will have to stick to old packages).
I think the most reasonable would be the EFCore llibraries to continue having support for NetStandrad 2.0 until Net5. What do you think?

@arivoir  @ajcvickers  I have test it by changin mi share code to .net standard 2.1 and goes well, the Android team has complete implement it so we can now add netstandard2.1 reference to android project, the iOS have some issues but the are almost done.


Modal does not close due to an error

What is your Test Scenario?

I want to test an angular app with an ngbootstrap modal
What is the Current behavior?

when the modal pops up an error is thrown:
hammerhead.js:2 ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'true'. Current value: 'false'.
    at viewDebugError (core.js:9997)
    at expressionChangedAfterItHasBeenCheckedError (core.js:9975)
    at checkBindingNoChanges (core.js:10144)
    at checkNoChangesNodeInline (core.js:14171)
    at checkNoChangesNode (core.js:14145)
    at debugCheckNoChangesNode (core.js:14973)
    at debugCheckRenderNodeFn (core.js:14914)
    at Object.eval [as updateRenderer] (DynamicNGBootstrapFormControlComponent.ngfactory.js:834)
    at Object.debugUpdateRenderer [as updateRenderer] (core.js:14896)
    at checkNoChangesView (core.js:13985)

this error prevents that a button can be clicked in modal and so the modal never closes.
this error does not occur when i interact with the website direct.
this error does not occur when i proy the page with testcafe-hammerhead.
the error happens after:
await t.pressKey('tab')
What is the Expected behavior?

It would be best if the error didn't occur.
I could also live with it if the error occurred and the button was clickable in the modal.
What is your web application and your TestCafe test code?

Unfortunately I can't provide a link to a website. if the problem can't be solved otherwise, I'll add a StackBlitz.

Your complete test code (or attach your test files):

 import { Selector } from 'testcafe';
 import {logger} from 'codelyzer/util/logger';
 fixture `Person Test`
    .page('http://localhost:9000')
 const person = {
    email<EMAIL_ADDRESS>    vorname: 'Silja',
    nachname: 'Klein'
}

const personSelectors = {
    email: Selector('#email'),
    vorname: Selector('#vorname'),
    nachname: Selector('#nachname'),
    modalBestaetigt: Selector('#modal-bestaetigt')
};

async function bestaetigung(t) {
    await t.pressKey('tab')
    await waitForAngular();
    if ( personSelectors.modalBestaetigt.exists) {
        await t.click(personSelectors.modalBestaetigt)
    }
}

const replaceText = {replace: true};

test('person', async(t) => {
    await t.typeText(personSelectors.nachname, person.nachname, replaceText)
    await bestaetigung(t);

    await t.typeText(personSelectors.vorname, person.vorname, replaceText)
    await bestaetigung(t);

   await t.expect(personSelectors.vorname.value).eql(person.vorname)
   await t.expect(personSelectors.nachname.value).eql(person.nachname)
}

Your complete test report:
 Running tests in:
 - Chrome 70.0.3538 / Windows 10.0.0
Person Test
√ person
1 passed (1m 12s)

Steps to Reproduce:

Unfortunately I can't provide a link to a website. if the problem can't be solved otherwise, I'll add a StackBlitz.
Your Environment details:

testcafe version:                   0.23.2
node.js version:                    v9.4.0
command-line arguments:  testcafe chrome  person-test.ts
browser name and version: Chrome 70
platform and version:          windows 10
other:

The ExpressionChangedAfterItHasBeenCheckedError error occurs in Angular core. Could you please check if the error occurs without TestCafe? If the error occurs only with TestCafe, I need a detailed example to reproduce the issue. I'll appreciate it if you create a StackBlitz project demonstrating the issue.
Otherwise, you can use the skip-js-errors option to prevent TestCafe from failing on this error.

I will close the issue because no activity has been encountered for a long time.
Feel free to reopen the issue if the problem persists and you can provide an example to reproduce it.


Avoid importing everything when given an empty relation

Users can currently call import and import! directly on an index. If
these methods are called without arguments, the index imports all data
matching the type definition.
If these methods are called with an argument, ex.
UsersIndex.import(User.where('rating > 100')), only the given scope or
array will be imported into the index.
If these methods are called with an argument, but that argument is empty
(for example User.where('rating > 100') returns an empty relation),
the methods were behaving as if they had no args (importing all the data
for an index).
This is undesired behavior, as the expectation should be for an import
with an argument that is empty to import nothing.
The changes proposed here mirror the changes created in this
commit, so that the behavior of doing UsersIndex.import([]) is the same as doing UsersIndex::User.import([]).

Thank you for your PR, I rebased and merged it!


google-analytics.com Max retries exceeded with url: /collect

Expected Behavior
A working bot :+1:
Actual Behavior
UnicodeDecodeError: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128)
2016-08-15 11:49:56,322 [sentry.errors.uncaught] [ERROR] [u"ConnectionError: HTTPConnectionPool(host='www.google-analytics.com', port=80): Max retries exceeded with url: /collect (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7f1810e84dd0>: Failed to establish a new connection: [Errno -4] Non-recoverable failure in name resolution',))", u'  File "pokecli.py", line 514, in ', u'  File "pokecli.py", line 75, in main', u'  File "pokemongo_bot/health_record/bot_event.py", line 46, in login_success', u'  File "pokemongo_bot/health_record/bot_event.py", line 78, in track_url', u'  File "requests/api.py", line 111, in post', u'  File "requests/api.py", line 57, in request', u'  File "requests/sessions.py", line 475, in request', u'  File "requests/sessions.py", line 585, in send', u'  File "requests/adapters.py", line 467, in send']
Mon Aug 15 11:49:57 UTC 2016 Pokebot configs/config.json Stopped.
Your config.json (remove your credentials and any other private info)
Not necessary because the config worked before.

Steps to Reproduce
Starting the bot.
Other Information
OS: Ubuntu
Git Commit: 0292c2f426b2432be70b0ca867fa62d8436cb5bf
Python Version: Python 2.7.10

turn off health record in your config

Not necessary because the config worked before.

Then our help is not necessary because the bot worked before... right?
Also, it might help if you updated seeing as you are 4 days out of date

@simonsmh  as he said, set the health record in the json to : false.

It works now setting the health record on false. Something else broke, but I'll clone the dev branch again so everything is fresh :)
Thanks guys.


Source Generate the Attributes.

Fixes #1.
Fixes #7.
Checklist

[x] I have read the Code of Conduct and the Contributing files before opening this issue.
[x] I have verified the issue this pull request fixes or feature this pull request implements is to the current release.
[x] I am using the latest stable release with the above code fix or the current main branch if code changes are present (prerelease code changes).
[x] I have debugged and tested my changes before submitting this issue and that everything should just work.

The Coverage checker thing might be bugged and might think it's 0% in CI but it's not actually 😄.