SupervisorService times out waiting for services to stop

🙂 Expected behavior
When SupervisorService receives a SIGINT or a SIGTERM, it should stop all its services within the default time limit (currently 5 seconds).
🫠 Actual behavior
SupervisorService stops with the message: ERROR timed out waiting for services to stop
🧪 Minimal test case

Build all docker images by running make docker-build
Execute the node with make docker-run
Wait a few seconds for all services to start
Stop the execution by sending an interrupt signal: Ctrl+C

🌎 Environment
I've reproduced this issue using the Docker images and when running locally on my Mac.
✔ Possible solutions
The only service failing to notify its exit is server-manager

I confirmed this is happening here in the Docker environment as well.
node-1      | ERROR rollups-node: timed out waiting for services to stop
node-1      | ERROR timed out waiting for services to stop


Update to new Spack CachedCMakePackage

This uses the new CachedCMakePackage in Spack from @becker33.
Corresponding Spack PR here:
https://github.com/spack/spack/pull/19316

Still working out a couple kinks.

@white238 to the extent I understand this stuff, I approve. Thanks for all that you do to make the project super awesome!

It is basically moving as much common boiler plate Spack logic into one place and having a "blessed" spack workflow.  Things that were really difficult to flush out so we dont have to keep repeating them.  Hopefully Conduit as well as Serac will use this soon as well.  Axom was just first i converted because it is a larger set of compilers and features.

@white238 nevertheless, I still stand behind my kudos to you.

Sorry this PR creeped but here is kind of a list of what i did:

regenerating all host-configs w/ fundamental formatting changes
docker builds were broken so mimicked work from @joshessman-llnl  in the serac repo
Quartz wouldn't give me an allocation so I rage changed us over to Ruby

This is ready to review.  I made comments on some of the places to focus.


Add better logging handling, fix default attributes handling, WF 12 update

You, sir, are my hero!!
I guess you would like me to release this to Maven Central asap right?
I will see what I can do tonight.

Reviewed code and LGTM!
👍


Aggregate release branch rc2 migrations to 2.0.0-rc2

Description
The aggregation of the current migrations within the dev branch to a '2.0.0-rc2' migration is needed in preparation for https://github.com/eclipse-tractusx/portal/issues/253

after merging the PR the following script should be executed on the rc env
delete
from public.__efmigrations_history_portal
where migration_id in ('20240415133846_579-InvitationProcessStepTypes',
'20240417095305_564-AddNewChecklistEntries',
'20240417123059_572-AddProcessStep');

insert into public.__efmigrations_history_portal (migration_id, product_version)
values ('20240418093058_2.0.0-rc2', '8.0.2');


semantic highlight and hints for a TypedDict's get function.

Environment data

Language Server version: v2023.3.20
OS and version: ubuntu 20.04
Python version (& distribution if applicable, e.g. Anaconda): 3.9.5

Code Snippet
from typing_extensions import TypedDict

class Cls(TypedDict):
    a: int
    b: str

dct: Cls = {"a": 1, "b": "2"}
dct.get("a")

Repro Steps

Look at the semantic highlighting of the above code.
Put your curser on the get part to see the type hint.

Expected behavior

The get function should be colored as such.
The hint should show the various possible signatures like for a regular overloaded function (where it shows a single signature and you can move between the different signatures manually).

Actual behavior

The get function is uncolored.
The hint looks like get: Overload[(k: Literal['a']) -> int, (k: Literal['a'], default: Any) -> int, (k: Literal['b']) -> str, (k: Literal['b'], default: Any) -> str, (k: str) -> (Any | None), (k: str, default: __TDefault@Cls) -> (Any | __TDefault@Cls)]).

Any updates on this? It appears it's still not behaving as expected.

I believe it's still being discussed on what to do:
https://github.com/microsoft/pyright/issues/9252

This issue has been fixed in prerelease version 2024.11.100, which we've just released. You can find the changelog here: CHANGELOG.md


make test KUBECONFIG thread safe

Setting environment variables in the test process is not thread safe and can lead to unpredictable behavior. This updates the usage of kubeconfig in the tests to pass the environment variable into the subprocess rather than setting the env var in the test process.

Thanks for the enhancement!
/lgtm


controller: ignores errors when deleting volumes

Found in https://cloudnative-k8sci.southcentralus.cloudapp.azure.com/blue/rest/organizations/jenkins/pipelines/pmem-csi/branches/PR-327/runs/1/nodes/59/log/?start=0 (part of issue #319):
pmem-csi-controller-0/pmem-driver: W0704 08:18:22.409906       1 glog.go:99] Failed to delete volume 3bdf2d3e-9e34-11e9-88d0-ce52ad0608ec on pmem-csi-clear-1-14-direct-worker1: rpc error: code = DeadlineExceeded desc = context deadline exceeded
pmem-csi-controller-0/pmem-driver: I0704 08:18:22.409958       1 glog.go:58] DeleteVolume: volume 3bdf2d3e-9e34-11e9-88d0-ce52ad0608ec deleted

Does that mean that the gRCP errors was ignored and the controller continues by assuming that the volume was deleted?

Yes, the code merely logs errors as warnings:
https://github.com/intel/pmem-csi/blob/2e59826b538e3358e8bd132881298ed53b68e328/pkg/pmem-csi-driver/controllerserver-master.go#L287-L302
That's not how Kubernetes works. When there is an error, some retry loop must repeat the same operation until eventually it succeeds or a human admin intervenes. An automated system cannot fail and then expect an admin to clean up manually, that simply doesn't scale.
The retry loop in this case is in the external-provisioner. The code must be changed to return an error to the provisioner.

Do we have other cases where errors are merely logged as warnings?

Yes, the code merely logs errors as warnings:

If I remember correctly, this was because of Cache volumes, How to deal if the volume is deleted on some nodes, but other nodes reported error.
But we can fix this, by reporting the first error and make sure that Nodes handle repeated delete calls without reporting an error. Expecting that external-provisioner maintains the retry loop.

make sure that Nodes handle repeated delete calls without reporting an error

They should already do that. Idempotent calls are an important part of a distributed system because a response to a request might get lost and callers simply have to retry the same operation.


Fix JSON serialization for DC evaluate.explore

There was a metric coming in as np.float32, which is not JSON
serializable for some reason. Converting it to a regular float fixes it.
Fixes #1975

For some reason, the issue only repros in drawing classifier and not image classifier. In image classifier, the metric is already in float form.

Verified this fix works.


Switched CodepageEncoder parameters

This commit is not needed, as the reason for this issue was that version 2.0 of EscPosEncoder that is in development depends on a version of CodepageEncoder that was not yet released. Now that CodepageEncoder 2.0 is released the APIs align again.


AABB broken on imported meshes with skeletons, making it difficult if not impossible to select stuff in the editor.

Godot version
4.2 RC1
System information
Windows 11 - Vulkan - Nvidia RTX 4070 - intel i5 13600KF
Issue description
As you can see in the images the AABB godot calculates are just broken for various mashes which include a skeleton. This makes it near impossible to work with meshes in the editor since selecting a mesh is based on the AABB (I assume?), for example in the image with the soldier the AABB is so outside the mesh that if you place the soldier on the ground you always select the ground instead and so on.
(the only way is too go through the Scene tab which when working with multiple models is a horrendous workflow)
The test scene includes a blend, gltf (glb), and fbx files. All result in the same issue.
Images from my project:

Image from the MRP:

I've downloaded the windows editor artifact from this PR: https://github.com/godotengine/godot/pull/84451 but the issues where the same as in 4.2 RC1 - I don't know if it's even related to 3D since most of it seems to be 2D but someone suggested it to me.
This is not an issue with only Blender made files, the files in my project were made in Maya.
Testing the same files in Unreal Engine works perfectly fine.
Steps to reproduce

Open the MRP
Open the test_aabb.tscn file
Select any of the nodes (TestCube Blend, TestCube2 GLB, Root Scene FBX)
(4. for details the nodes are set as editable children so you can go through everything in detail if needed)

Minimal reproduction project
AABBImportTests.zip
EDIT: Also the AABB doesn't seem to be updated correctly during animations, I can provide a short video if anyone wants to see it so let me know :).

Related to https://github.com/godotengine/godot/issues/80306. I wonder if the issue is not just FBX files, but rather, files exported from Maya.

@clayjohn I don't think Maya is the issue. The MRP was made in Blender it did not touch Maya at all, same for fbx and gltf both exported straight from Blender so it's not just FBX issue either. At least I assume so, I don't have maya on my side only blender but I have purchased models from artists who made them in Maya. So it seems more like both Maya and Blender exports, since these two tools are unrelated I'd guess more likely something on Godot's side?
Also I tried dropping the models into Unreal and they work just fine so it again seems more something in Godot?
I can test more but I can't share original models due to its license but the MRP seems to work in this case just fine but feel free to ask me to try anything, I can even build the engine if there's something in particular to test or change in code (if you tell me what :D).
I hope I made my repot clearer this way in case there was some misunderstanding?

Did you happen to find a workaround for this? I'm experiencing the same issue for .glb files exported from blender.

No, as far as I can tell there isn't one. It's an issue in godot's internals the transforms are just wrongly applied/calculated when you have skeletons in some situations. Until someone fixes this there's not much you can do.
The only thing you can do for your game is that you can specify a custom AABB so give your characters a rough box shape on your own to at least have semi-decent culling to work, with animations you either just ignore the the parts going out or recalculate it but I'd just ignore it unless you have some animations which push your model far out of that box.
Again this helps in game (not entirely but it's better than nothing ;)) but it doesn't help in the editor at all.
The only reliable solution is to delete the skeleton and not use it :D which I wouldn't really call a solution hehe.
If you come up with something let me know as far as I know as long as you have a model with skeleton no matter which program it is exported from or in which format it can happen and it will at some point happen.
(I think there was similar issue in 2d and there was some PR reworking how the box is generated for 2d with skeletons but nothing for 3D as far as I know - well I haven't checked for a while so maybe there's some PR I'm not aware of at this point)

I found a solution for this. In blender you go in object mode > select the armature > CTRL+A and apply all transforms. Export and re-import in godot and AABB is now properly calculated.

That's not going to work for all models unfortunately. Especially models in FBX format which Blender and many other programs have troubels with so this still needs a solution on the Godot's end.

The skeleton pose doesn't seem to update the AABB of skinned meshes at all (just non-skinned ones), which can be reproduced with the default TubeTrailMesh.

This issue desperately needs to be fixed!
And since the issue I raised was closed I'm posting a makeshift solution here
The code below manually calculates the AABB of a given mesh instance no matter how it's transformed and/or deformed by bones of a Skeleton3D
(Although it feels that there should have been an inbuilt feature for this)
func get_precise_aabb(mesh_instance : MeshInstance3D):

	var skeleton:Skeleton3D = mesh_instance.get_node_or_null(mesh_instance.skeleton)
	var low : Vector3 = Vector3.INF
	var high : Vector3 = -Vector3.INF

	for surface in mesh_instance.mesh.get_surface_count():
		var data := mesh_instance.mesh.surface_get_arrays(surface)
		var vertices:Array = data[Mesh.ARRAY_VERTEX]
		var vert_map := {} # to avoid recalculating

		for vert_idx in len(vertices):
			var vert = vertices[vert_idx]

			if(vert in vert_map):
				continue
			else:
				vert_map[vert]=null

			if(skeleton and mesh_instance.skin):
				var bones:Array = data[Mesh.ARRAY_BONES]
				var weights:Array = data[Mesh.ARRAY_WEIGHTS]
				var bone_count:int = len(weights)/len(vertices)
				var transformed_vert = Vector3.ZERO
				for i in bone_count:
					var weight = weights[vert_idx * bone_count + i]

					if(!weight):
						continue

					var bone_idx = bones[vert_idx * bone_count + i]
					var bind_pose = mesh_instance.skin.get_bind_pose(bone_idx)
					var bone_global_pose = skeleton.get_bone_global_pose(bone_idx)
					transformed_vert += (bone_global_pose * bind_pose * vert) * weight

				vert = transformed_vert

			vert=mesh_instance.global_transform * vert

			low.x = vert.x if low.x > vert.x else low.x
			high.x = vert.x if vert.x > high.x else high.x

			low.y = vert.y if low.y > vert.y else low.y
			high.y = vert.y if vert.y > high.y else high.y

			low.z = vert.z if low.z > vert.z else low.z
			high.z = vert.z if vert.z > high.z else high.z

	return AABB(low, high - low)

https://github.com/godotengine/godot/assets/73928607/9e53535b-9749-49e5-992c-0fcc0319aa31
The mesh was imported from blender as a .blend file

Perhaps this can allow a cleaner fix, or at least a more elegant workaround: https://github.com/godotengine/godot/pull/85018

In general to set an appropriated custom AABB for more dynamic objects is an expected step in a game project when new 3d assets are setup. This is also such an ancient discussion since skeleton animations exists and it resurfaces for every single game engine because new people show up that don't know better (yet).
Other engines either don't care or do it like e.g. Unity only at the asset import stage for the available animations or perma update an asset as if the AABB is inf. Both options are just tradeoffs as they try to solve one issues while adding plenty of others.
You can already do that always-update part in Godot when you set the custom aabb to a giant value so it is unlikely to ever be culled.
What imo could be done for skeleton meshes is similar to particles to have a generate AABB function on the MeshInstance3D when it has a skeleton with animation player. That function could run all the available animations on the mesh model as an editor function and sets a custom AABB on this geometry instance.
While this fixes parts of the worst created models and animations it does not fix a lot of other issues as there are just too many permutations possible how vertices can end up outside the AABB and the calculation can not foresee them all. E.g. it falls apart entirely for runtime procedural stuff or animation blending or vertex shaders to just name a few and those are all very common in use.
No, recalcuation dynamic AABBs for your bones and meshes and blendshapes and animations at runtime while animating is not a solution. Again, there are just too many permutations possible, some stuff is purely visual and has not even data on the cpu to calculate, and it would waste a hell lot of performance, more than what can be reasonably gained by having a tight AABB.
Just set an appropriated custom AABB that covers the mesh needed stage space and design your animations with culling in mind (if they are not just for cutscenes) is the right way to do this.

Setting a custom AABB makes sense, but I don't see an option for that import settings, making the process awkward.
I'd argue the advanced import settings dialog should compute an AABB using the default pose automatically, and then go ahead and use it to position the camera correctly.
And no, I don't want Godot to recompute the AABB all the time.


Clarity on best practices

Related issues: https://github.com/Instagram/IGListKit/issues/799

it'd be helpful to use a real world example and share some of the concerns raised in 799, and get feedback regarding best practices to fix it.
Example
Suppose you have an instagram post, when you view the post you'll receive a JSON response from the server, and map it to a Post object, the Post class looks like this:
 images: [PostImage] // an array of post images
status: Status // a post status object (not that important)
 comments: [Comment] //an array of comment objects
Based on:  https://github.com/Instagram/IGListKit/issues/799 , we should do the following

Within the post's view controller, create a flat array var objects: [ListDiffable], which may look like this: [PostImage, PostImage, Status, Comment, Comment, Comment]
In our view controller, implement the necessary function func listAdapter(_ listAdapter: ListAdapter, sectionControllerFor object: Any) -> ListSectionController and create section controllers for each image, each comment, and the status.
These section controllers should have numberOfItems always return 1 and will have the appropriate object available within them (e.g. Comment, PostImage ...)

Here's been my problem with this since approach day one:

It seems unintuitive that we need to build the ViewController's objects: [ListDiffable] array like follows:
objects.append(contentsOf: post_resp.images)
object.append(post_resp.status)
objects.append(contentsOf: post_resp)
ending up with objects equaling
[PostImage, PostImage, status, Comment, Comment, Comment]

Because

what is the purpose of numberOfItems in the section controller? When wouldn't it be 1 if this is the pattern to follow (i.e. 1 master list with section controllers for each ListDiffable object)? If there is a use case for numberOfItems, it seems that it can't be dynamic... (see below)
what if the comment section needed a header like "5 comments". With this approach wouldn't you have to create a whole new section controller like "CommentHeaderListSectionController"? Because creating a supplementary header view inside the comment's section controller would present a header for each comment.

Now, a more sensible approach might be this (but ends up breaking down) :
object.append(post_resp) //in our view controller, append just the post

Then in func listAdapter(_ listAdapter: ListAdapter, sectionControllerFor object: Any) -> ListSectionController we would create a stacked section controller containing: PostImagesListSectionController, StatusListSectionController and CommentsListSectionController. and yield the entire post object to each section (which is also helpful if one of these sections needs to know a little more about the post, like it's id or something)

in a section controller with multiple items e.g. (CommentsListSectionController), you'd have numberOfItems return post.comments.count. and create collectionviewcells for each comment.

I could then put a supplementary view for the comments section header, and not have to create a whole new section controller for the header

Problem
This seems like a cleaner approach, but what if you need to append a comment to the array of comments? Well, since you're presumably yielding a Post object to the comments section controller, wouldn't you do post_obj.comments.append(comment) in the post's ViewController, and call performUpdates? Right now this returns the error in #799 and apparently isn't the right way to do things.

I'll try to summarize some thoughts before I get back from my trip, but this is actually an anti pattern we need to do a better job explaining.
Each section controller should contain logic for a single, too-level model (Post in your example). Within that section controller, you can decompose the Post into an array that drives numberOfItems. Do this however you want. We have an example at the bottom of the FAQ.
Take a deeper look at our examples. We have one with exactly this setup (posts, images, comments) with an architecture like I just described.
Would a tutorial or guide linked from the root readme help here? cc @jessesquires since we've gotten this question a lot.
Lastly take a look at my GitHub app. It's totally powered by IGListKit and has some very advanced stuff in there. It should give you an idea to just how powerful this framework is.

just a follow up for anyone reading this. List binding section controller has solved all of the issues I've been having. Specifically for cases where I have something like a post object with a lot of nested objects (i.e. comments, tags, etc...) This example helped me out a lot too. https://github.com/Instagram/IGListKit/blob/master/Guides/Modeling and Binding.md


ResultSet.close() if zoom has it

When working with large resultsets and calling getRecords() on the whole at once the node process is leaking memory and growing biger and bigger. Might not be directly related to retrieving results (I can send you my code privately) but maybe you can look into to. Not too important as this is a one off thing. Works great with usual resultsets.

To match the rest of the API there is now a ResultSet.destroy() function which should have the desired functionality

Closing issue for now, please use 0.7.2 or higher


User to request VM console access - Add 'Az' command section

Section 'User to request VM console access' only reflects the AzureRM module. Please consider including the Az module which is already reflected earlier in the document under 'Operator enables a user subscription for EVA'

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 221ace5c-e2df-f784-d570-a39563c13a8d
Version Independent ID: 38a14acb-21f5-5378-6ece-50e89e437025
Content: Emergency VM access in Azure Stack Hub - Azure Stack Hub
Content Source: azure-stack/user/emergency-vm-access.md
Service: azure-stack
Sub-service: azure-stack-hub
GitHub Login: @sethmanheim
Microsoft Alias: sethm

Hello @CHDAFNI-MSFT,
Thank you for bringing this to our attention. Your feedback is under review, we shall update the document shortly.

Hello @CHDAFNI-MSFT,
I have updated the document with az cmdlet "Invoke-AzResourceAction" at https://review.docs.microsoft.com/en-us/azure-stack/user/emergency-vm-access?view=azs-1802&branch=pr-en-us-9370&tabs=azurerm1#user-to-request-vm-console-access


test: Disable TestImage.testOSTree{Commit,Container}

These two tests have constantly failed for several months. They cause
blocked VM image refreshes, test timeouts (so that the other tests
often don't run), and block the infra.

This is a desperate measure, but these two tests currently don't help anyone. We know that either OSTree builds or the tests are broken, and it needs some maintainer effort to look at them.
See e.g. #1411 for a recent example.

meh at the failing openstack test, but I remember that this also happens quite often, and depends on external infra. I already retried this morning, let's try another round.

OK, testOpenstack doesn't like me today. But unlike testOSTree that at least still has some chance of getting green (I think), so let's not axe it just yet.


Add TS build config, convert src/math/ and src/utils/ to TS

Tested with the most recent version of use-cannon

nice! merge whenever you think it's ready

This should be stable. I'm merging now so that we can use in the next version of use-cannon and make sure there are no bugs. There should be no functional changes, only type updates.

are you "codynova" on npm? if yes you have npm publish right now. if no please tell me, or else i've given it to a complete stranger :-P

Hahaha yes, that's me. 😄 I'll go ahead and release a new version 0.7.0 so we can update use-cannon and get people testing the TypeScript version

Just waiting on npm cache to clear so my permissions are valid 👍

Released<EMAIL_ADDRESS>


All lambdas CW logs show error importing the logger module

I've tried deploying into us-east-1/2 but no luck.
What i see in the CW logs for say  /aws/lambda/serverless-saas-LambdaFun-UpdateTenantStackMapTabl-IvNpHXeVlav7 is
[ERROR] Runtime.ImportModuleError: Unable to import module 'update_tenantstackmap_table': No module named 'logger'
Traceback (most recent call last):

Tracing back it seems like something might be wrong with the lambda insight because in the lambda itself i see the 2 layers

but i don't see the layer in the dashboard - shouldn't that appear ?

Sadly i don't see any other error ...

maybe the lambdainsights layer has nothing to do here  ... very confused

and because the 2 custom resources  - UpdateSettingsTable & UpdateTenantStackMap part of the tenant stack serverless-saas-CustomResources  it goes into a fail loop of 3x, after that it won't retry and as such the CFN  will timeout ... eventually.
This is vv odd issue as the layer is present and the above CFN has a dependency condition in the root / parent cfn stack ...i'm losing the battle

One instance where you will encounter this below is issue when you have a sam cli version < 1.20.0, we are using nested templates and they are supported only from sam cli version 1.20.0.
Please check if you have latest version of sam cli version.
[ERROR] Runtime.ImportModuleError: Unable to import module 'update_tenantstackmap_table': No module named 'logger'
Traceback (most recent call last):

oh i see, i'll go and have a go at this in a min. The below version is present in Cloud9 and so i thought that is good enough to get me starting (i should have listen and follow your notes)
 sam --info
{
  "version": "1.19.0"
}

Closing the issue as it was indeed caused by the old version of sam cli ....how annoying this was but lesson learn to read carefully the pre-req and not rely on already installed version


Switch SARIF report off jackson

We probably still want to leverage JSON encoding/decoding library. The Android Lint https://cs.android.com/android-studio/platform/tools/base/+/mirror-goog-studio-master-dev:lint/cli/src/main/java/com/android/tools/lint/SarifReporter.kt does not feel that good to emit handcrafted JSON.
We also need to keep our bundle size down, and from https://medium.com/@dannydamsky99/heres-why-you-probably-shouldn-t-be-using-the-gson-library-in-2018-4bed5698b78b we know that Jackson is probably the largest among all other well-known options with a high method count.

I imagine that you read #3045 and the reason to use Jackson. I think like you, jackson is far too heavy and it doesn't have sense that we need to sort the JSON entries. That doesn't follow the JSON standard. I'd vote to use moshi or kotlinx.serialization (I prefer the first one but I don't know any good reason to not use the second).

Specifically about
https://github.com/detekt/detekt/issues/3045#issuecomment-688960454
https://github.com/detekt/detekt/issues/3045#issuecomment-689039863
Yes, I am just stating that Jackson is the worst, I agree that we should try other libraries.

I'd vote to use moshi or kotlinx.serialization (I prefer the first one but I don't know any good reason to not use the second).

I'm in for both. Potentially would pick kotlinx.serialization given that we already use kotlinx.html but nothing prevents us from picking moshi

Potentially would pick kotlinx.serialization given that we already use kotlinx.html

Agree +1

We need first to convert the SARIF json schema into the specific POJO that is compatible with the serialization framework (moshi or kotlinx).

For moshi, there is a popular tool jsonschema2pojo to convert JSON schema to moshi-compatible pojo. However, even with these POJOs, we still have Kotlin specific wrappers like https://github.com/detekt/detekt/blob/master/detekt-report-sarif/src/main/kotlin/io/github/detekt/report/sarif/SarifDsl.kt
For kotlinx, there is no popular tool to convert JSON schema to POJO. The one I can find is https://github.com/Ricky12Awesome/json-schema-serialization which does not seem mature enough.  Meanwhile, there are still applications like https://github.com/quicktype/quicktype to generate the POJO manually.

Assuming SARIF schema is not updated often (last update was March 2020), I am inclined to and will begin with generating the POJO manually using https://github.com/quicktype/quicktype.


Misc doc changes

Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the source of truth for this Elixir
library and leverage on latest features of ExDoc.

@kianmeng thank you! :purple_heart:


.bootstrap.py crash on Windows 8.1 and Python 2.7.9

I am still getting an error if i want to build Atom Shell on Windows 8.1 32-bit and Python 2.7.9.
Here is the log:
$ python script/bootstrap.py
Traceback (most recent call last):
  File "script\update-external-binaries.py", line 66, in <module>
    sys.exit(main())
  File "script\update-external-binaries.py", line 31, in main
    download_and_unzip('directxsdk')
  File "script\update-external-binaries.py", line 50, in download_and_unzip
    zip_path = download_framework(framework)
  File "script\update-external-binaries.py", line 61, in download_framework
    download('Download ' + framework, url, path)
  File "C:\Users\IEUser\Desktop\atom-shell\script\lib\util.py", line 48, in download
    web_file = urllib2.urlopen(url)
  File "c:\Python27\lib\urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "c:\Python27\lib\urllib2.py", line 437, in open
    response = meth(req, response)
  File "c:\Python27\lib\urllib2.py", line 550, in http_response
    'http', request, response, code, msg, hdrs)
  File "c:\Python27\lib\urllib2.py", line 469, in error
    result = self._call_chain(*args)
  File "c:\Python27\lib\urllib2.py", line 409, in _call_chain
    result = func(*args)
  File "c:\Python27\lib\urllib2.py", line 656, in http_error_302
    return self.parent.open(new, timeout=req.timeout)
  File "c:\Python27\lib\urllib2.py", line 437, in open
    response = meth(req, response)
  File "c:\Python27\lib\urllib2.py", line 550, in http_response
    'http', request, response, code, msg, hdrs)
  File "c:\Python27\lib\urllib2.py", line 469, in error
    result = self._call_chain(*args)
  File "c:\Python27\lib\urllib2.py", line 409, in _call_chain
    result = func(*args)
  File "c:\Python27\lib\urllib2.py", line 656, in http_error_302
    return self.parent.open(new, timeout=req.timeout)
  File "c:\Python27\lib\urllib2.py", line 431, in open
    response = self._open(req, data)
  File "c:\Python27\lib\urllib2.py", line 449, in _open
    '_open', req)
  File "c:\Python27\lib\urllib2.py", line 409, in _call_chain
    result = func(*args)
  File "c:\Python27\lib\urllib2.py", line 1240, in https_open
    context=self._context)
  File "c:\Python27\lib\urllib2.py", line 1197, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:581)>
Traceback (most recent call last):
  File "C:\Users\IEUser\Desktop\atom-shell\script\update.py", line 50, in <module>
    sys.exit(main())
  File "C:\Users\IEUser\Desktop\atom-shell\script\update.py", line 16, in main
    update_external_binaries()
  File "C:\Users\IEUser\Desktop\atom-shell\script\update.py", line 22, in update_external_binaries
    subprocess.check_call([sys.executable, uf])
  File "c:\Python27\lib\subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['c:\\Python27\\python.exe', 'script\\update-external-binaries.py']' returned non-zero exit status 1

Traceback (most recent call last):
  File "script/bootstrap.py", line 127, in <module>
    sys.exit(main())
  File "script/bootstrap.py", line 34, in main
    update_atom_shell()
  File "script/bootstrap.py", line 123, in update_atom_shell
    execute_stdout([sys.executable, update])
  File "C:\Users\IEUser\Desktop\atom-shell\script\lib\util.py", line 150, in execute_stdout
    execute(argv)
  File "C:\Users\IEUser\Desktop\atom-shell\script\lib\util.py", line 138, in execute
    raise e
subprocess.CalledProcessError: Command '['c:\\Python27\\python.exe', 'C:\\Users\\IEUser\\Desktop\\atom-shell\\script\\update.py']' returned non-zero exit status 1

It seems that GitHub Release always redirect the download url to S3 with https protocol, I'll turn off SSL verification to work around it.

It seems that GitHub Release always redirect the download url to S3 with https protocol, I'll turn off SSL verification to work around it.

Doesn't sound like good practice?


Allow support to run standalone without homebridge

For people who don't run homebridge but still want easy access to this as a service. I hope to create this as a new repository in the future or someone else could potentially even fork this repo.

I hope to work on this at some point, but in the meantime, I will be closing this issue, and may reconsider this in a new repo, but the idea is not directly related to this repo.


⚠ Quirk Club Argentina (API endpoint) has degraded performance

In c385b43, Quirk Club Argentina (API endpoint) (https://us-central1-quirkclub-dev.cloudfunctions.net/api/check/api) experienced degraded performance:

HTTP code: 200
Response time: 5254 ms

Resolved: Quirk Club Argentina (API endpoint) performance has improved in db18fc1.


nuxt config returning 404

Going on this Page: https://nuxt.com/docs/getting-started/configuration and clicking on "nuxt.config.ts" results in a 404
also going to https://nuxt.com/docs/guide and going to nuxt.config.ts via the directory structure also returns into 404.

It's returning a 404 for me as well. Could this be due to the fact that there's a . in the url ?

The link should be https://nuxt.com/docs/api/nuxt-config

Yeah the Algolia Search also direct to a 404, maybe a reindexation is needed ?

Should be fixed now


The result summaries  of TAXONS and SUBSTRATES in the new context of FRAME interpretation.

The result summaries should take into account the newly introduced separation of TAXONS and SUBSTRATES in the context of FRAME interpretation.

Enhanced in v2.0.0


MQN12 (heavy atom count) seems to be always 0.

MQN12 according to the original publication is number of heavy atoms and footnote says heavy atoms = All non-H atoms. If I run below code, I get an MQN12 of 0 instead of 4.
from rdkit import Chem
m = Chem.MolFromSmiles('CCCC')
from rdkit.Chem import rdMolDescriptors
mqn = rdMolDescriptors.MQNs_(m)
mqn[11] # MQN12 = hac = heavy atom count, all non-H Atoms
0

Index 11 is used because the returned list is 0 based. hence this means MQN12. I tried it for different simple structures and it seems to always return 0 as heavy atom count
RDKit_2015_03_1 on Windows and Python 32-bit.

Confirmed. The code is currently accumulating a count of the atoms that don't match any of the other atom types that are counted, so it's not always zero:
In [22]: AllChem.MQNs_(Chem.MolFromSmiles('CCCCB'))[11]
Out[22]: 1

But this is still wrong.

Should be fixed now. Thanks for the report!


Added clarity on how the BytesReceived field can change

@PeterSmithRedmond : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Show Info when in inventory

I can see why this would be a debatable feature, but since the Debug screen is also visible when in inventory i think that it makes sense to show the info as well

The debug screen is what the name implies, filled with debug information. IGI on the other hand is supposed to be an HUD mod.
I'll see if this can be done in a simple way without tearing up too much stuff.


Error while using custom code

Hi!
I'm trying to use your library to show the temp raspi2 and I made my custom code to do it... and it doesn't work.
It throws a traceback:
Traceback (most recent call last):   File "cpuTemp_oled.py", line 35, in <module>     draw.text((margin,margin),cpuTemp,font=fontName,fill=255)   File "/usr/lib/python2.7/dist-packages/PIL/ImageDraw.py", line 271, in text     mask = font.getmask(text, self.fontmode) SystemError: error return without exception set
I've tried the examples in the library and it works like a charm (Except for sys info, that as far as I know, needs to have another dependences installed.
What can I do?

Hi Luis,
A couple of things spring to mind:

At line 35 https://github.com/LuisDiazUgena/raspberry-pi-2/blob/master/oled/cpuTemp_oled.py#L35 I would wrap cpuTemp to cast it as a string, something like:

draw.text((margin,margin),str(cpuTemp),font=fontName,fill=255)

In the try/except block here https://github.com/LuisDiazUgena/raspberry-pi-2/blob/master/oled/cpuTemp_oled.py#L22-L26, it is implicitly returning a None, so you probably want to guard against that with as follows:

cpuTemp = getTempCPU()
if cpuTemp:
    draw.text((margin,margin),str(cpuTemp),font=fontName,fill=255)

The draw context only flushes when the with-block exits, so you need to invert the with and the while statements ... your code should probably look like:

margin = 2
sleep_time = 2.5 #seconds

while True:
    with canvas(device) as draw:
        cpuTemp = getTempCPU()
        if cpuTemp:
            draw.text((margin,margin),cpuTemp,font=fontName,fill=255)

    sleep(sleep_time)

p.s. To get the sysutil example running, there are some dependencies you need to install - see https://github.com/rm-hull/ssd1306/blob/master/examples/sys_info.py#L3-L7

Thanks rm-hull, I've implemented the bug fixes that you suggested. Will try it when I get home and let you know. Thanks!

Hi! It works!
Thanks for your help!


Why add 1e-4 in softmax

Hi! I found that 1e-4 is added in the softmax function. Are there any reasons?
https://github.com/jayleicn/singularity/blob/bf4a86ec7506565d1f6805ee1612aa6029592776/models/model_retrieval_base.py#L303-L304
If it is used for smoothing, why not add it after softmax, like F.softmax(sim_i2t, dim=1)+1e-4.

The softmax uses `exp`. It seems that it will not cause zero-division error.

 I was looking at it too quickly. Please see this issue https://github.com/salesforce/ALBEF/issues/93

Thanks!


Access registered systems.

What problem does this solve or what need does it fill?
Systems part of Schedule can be accessed and "inspected". That is you can get some info of the system from System trait.
But registered systems are opaque because their storage is private. They exist as entities and are stored inside RegisteredSystem component.
What solution would you like?
Make the RegisteredSystem component pub (and export it ?) and add method to borrow stored system pub fn system_ref(&self) -> &BoxedSystem<I, O>; or pub fn system_ref(&self) -> &dyn System<In = I, Out = O>;
What alternative(s) have you considered?
None.
Additional context
None.

If this gets approved and it will be easy to impl as I offered in What solution would you like? then I would like to take it :)

I'm a bit nervous about this, because it's very implementation focused, rather than motivation focused
[6:40 PM]Alice 🌹: There are a lot of reasonable things that you might want to do with this access!
[6:41 PM]Alice 🌹: But unless that's actually written up in the issue and PR, it's going to be hard to find the right design
[6:41 PM]Alice 🌹: And liable to getting reverted by mistake


DA-1 & 6 adds support for ingesting Preservica Access-Only copies

This updates the mass digi EAD and generic jobs to allow Access-Only copies to be ingested.
See https://ourweb.nla.gov.au/apps/jira/browse/DA-1 and https://ourweb.nla.gov.au/apps/jira/browse/DA-6 for details.
See also:

https://github.com/nla/banjo-job/pull/21
https://github.com/nla/banjo/pull/2959
https://github.com/nla/banjo-common/pull/26

@adityaburra @ninhnguyen @scoen @sjacob @nlahuwgeddes

Build finished.


Pydantic 2.0 support

Please Describe The Problem To Be Solved
Pydantic v2 was recently released
But flet still requires Pydantic v1, which breaks other dependencies that have already moved to v2.
At the moment I need pydantic v2 with the pydantic-settings add-on.
And Poetry won't let me install the flet:
Because no versions of flet match >0.8.2,<0.9.0
 and flet (0.8.2) depends on pydantic (<2), flet (>=0.8.2,<0.9.0) requires pydantic (<2).
And because pydantic-settings (2.0.2) depends on pydantic (>=2.0.1)
 and no versions of pydantic-settings match >2.0.2,<3.0.0, flet (>=0.8.2,<0.9.0) is incompatible with pydantic-settings (>=2.0.2,<3.0.0).
So, because book-converter depends on both pydantic-settings (^2.0.2) and flet (^0.8.2), version solving failed.

(Optional): Suggest A Solution
Change the Pydantic version to >=2.0.0

It's copier - another Flet dependency is not yet compatible with Pydantic 2.0: https://github.com/copier-org/copier/issues/1225
We can't solve it without them releasing an update, can we?

The issue was closed and copier is now using pydantic 2.3.0, can you change the required version in flet as well?


Removing cdn.tabnak.ir

This completely breaks their site , they use same cdn for their news images and website stylesheets , more reasonable approach is adding this http://cdn.tabnak.ir/files/adv/* pattern to ad-blockers

Hi @drupalshift, thank you for these pull requests.
As you may now know, the hosts file is generated, so changing the final hosts file doesn't work because a new generated hosts file will come along and replace it.
If you want to add or remove domains, you have a couple of options:

see Generate your own unified hosts file and, therein, the How do I include my own custom domain mappings? and How do I prevent domains from being included? sections in the docs.

The cdn.tabnak.ir domain is aggregated fromsomeonewhocares.org.  You could contact them and explain why you feel this domain is OK.

Closing.


Tracking Code Label Disappears After Shipping Label Generation of Transfer Order Item

Current behavior
The tracking code is displayed in the tracking code field.
The label or text indicating that the field is for the tracking code disappears, causing confusion.
Expected behavior
The tracking code should be displayed in the tracking code field.
The label or text indicating that the field is for the tracking code should remain visible to clearly identify the purpose of the field.
Steps to reproduce the issue
Open the transfer order and create shipment for any item card.
On the next screen, generate a shipping label for a purchase order item.
Observe the tracking code field where the tracking code is displayed.
Note that the label or text indicating the field is for the tracking code has disappeared.
Environment details
App version : v2.7.0
App environment : UAT
Additional information

Issue verified and working fine in release v2.7.2. Hence, closing it.
https://jam.dev/c/33ed9780-a41e-4464-8503-12154e4c8d8e


Stop filtering duplicate messages

Previous versions of BDS would send an event both when a player sent a message, and when that message was received, causing duplicate events for the same message. This no longer appears to be the case (v1.12.1) See #1.

Looks good this way, thanks for the PR!


Fail to create a storage account with basic creation for Azure China and Azure Germany accounts

Build Version: 20200318.1

Does this occur consistently?  Yes
Repro steps:

Sign in with Azure China or Azure Germany account.
Click + button to create a storage account with basic creation.

Action: azureStorage.createGpv2Account
Error type: TypeError
Error Message: Cannot read property 'name' of undefined
Version: 0.9.1-alpha
OS: win32
OS Release: 10.0.17763
Product: Visual Studio Code - Insiders
Product Version: 1.44.0-insider
Language: en

Call Stack
ResourceGroupCreateStep.<anonymous> extension.bundle.js:157:105795
extension.bundle.js:157:105456extension.bundle.js:157:105456
i extension.bundle.js:157:105142
ResourceGroupCreateStep.execute extension.bundle.js:157:105717
AzureWizard.<anonymous> extension.bundle.js:307:302852
extension.bundle.js:307:300767extension.bundle.js:307:300767
i extension.bundle.js:307:300453
extension.bundle.js:307:302464extension.bundle.js:307:302464
t.ExtHostProgress._withProgress extensionHostProcess.js:531:963
t.ExtHostProgress.withProgress extensionHostProcess.js:531:717
Object.withProgress extensionHostProcess.js:839:259
AzureWizard.<anonymous> extension.bundle.js:307:302405
extension.bundle.js:307:300767extension.bundle.js:307:300767
i extension.bundle.js:307:300453
AzureWizard.execute extension.bundle.js:307:302356
SubscriptionTreeItem.<anonymous> extension.bundle.js:37:143097
extension.bundle.js:37:141142extension.bundle.js:37:141142
i extension.bundle.js:37:140828
extension.bundle.js:37:142920extension.bundle.js:37:142920
t.ExtHostProgress._withProgress extensionHostProcess.js:531:963
t.ExtHostProgress.withProgress extensionHostProcess.js:531:717
Object.withProgress extensionHostProcess.js:839:259
SubscriptionTreeItem.<anonymous> extension.bundle.js:37:142867
fulfilled extension.bundle.js:37:140896
processTicksAndRejections task_queues.js:85:5

More Info:

Succeed to create a new storage account with basic creation for Azure accounts.
Succeed to create a new storage account with advanced creation for Azure China and Azure Germany accounts.

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!


Propose arguments when they are missing

Which components does the task require to be changed? (think hard pls)
sncast
Description
Sometimes you can forget to write the calldata in CLI, to deploy, call or invoke
In this case we should display what arguments (and what type) you should provide, with which flag etc.
If not - at least suggest on error that calldata is the problem if we detect it in the error message (that the calldata is too long, too short). The case applies to errors of type "failed to parse argument 3", "input too long for arguments" etc..
Related to #276

First let's tackle #2241 and #2201 because these will probably come in handy to implement this

Addressed by data transformer


It will wake up the app if it's suspended or killed ?

In my app i need to get location continuously, even if the app is killed or suspended. is that possible ?
If yes can you provide me how i can set up this please ?

@youss-cs you can run in background fairly easily, head to the README.md and search in page for background and you'll find what you need fairly quickly. 😊

Apologies I just realised you meant when the app is closed from the background.

Yes, is that possible ?

@youss-cs are you referring to activating background modes in order to continue receiving the location even if the app is closed?

The only supported way to have background even if the app is terminated is to register for significant location updates or by registering monitored regions.
What accuracy do you need?

I need new location every 1min, significant location give new location only if user move 500m so it's not what i need.

There is not an official way to do continuous location monitoring in background for an unlimited time.
You could create a background task and register a region; once the device exit from the region the app is resumed/restarted and in your AppDelegate's didFinishLaunching func you can register another region...and so on.
This is one of the trick you may use but energy consuption may be huge and Apple may not be happy to see it.


Add 'component' annotation to traces

The 'component' annotation is a standard across
tracing implementations that designates the software
package, framework, or library that generates a given span.
Adding this annotation to Baseplate will make it easier
to see Baseplate-generated spans in a trace.

LGTM modulo the style nit :nail_care:

fixed formatting! :haircut:


fix($dirty): check if editor is dirty before updating view

Related Issue: #238
thats my first PR, I hope I haven't messed it up :boom:

Thanks for putting this up. Will take a look over it tonight.
Something that helps us is putting up a plunker with the fix so it is easy for us to test.
Also if you could add a test which verifies your fix that would be great.

Here is a plunker version of the fix.
http://plnkr.co/edit/As6nkFJPr5bVAd884dRl
I will try to set up a few tests, but it will take some time.

this fix solves the problem for me, thx for sharing!


Error page rendering twice

We are using the custom _error.js page, and we're seeing an issue where anything other than a 404 from a server error is rendering the error page twice.
It looks like it's rendering once on the server (the render HTML only has 1 error page), but also rendering an additional error page on the client.
I'm not sure if this is a bug, or if there is something wrong with the way we're handling the error (we're letting next handle the uncaught error). Any guidance would be appreciated.
I've created an example that replicates the issue here:
https://github.com/kochis/next.js/tree/duplicate-error-example/examples/duplicate-error-pages
Screenshot

Duplicate of https://github.com/zeit/next.js/issues/2573, lets track it there


Use active_tag_uuid in URLs everywhere

Once active_tag was the UUID of the tag, but now it is a dict with the various properties of the tag. For building the different URLs we need to use the UUID.
This was broken since af747e6e3f66a0512317c0c6ea22e19bf622f192.

amazing, thanks! i'll add a test

This PR looks like a combo of just a small refactor and fixing some other bugs, but it would be nice if you can say which parts are fixing bugs and which part is just refactoring
maybe you can close this PR and make 2 separate PR's? its impossible to tell what is "fixed" and what is refactor here


Add bank holidays for 2018

Add the generated JSON data for 2018 bank holidays, following the instructions in the README.
See https://github.com/alphagov/calendars/issues/131

Can we do the clock change dates too?

@fofr I've added the clock change too

Looks ok to me, but leaving for someone in Content Tools to review.

Should the 2015 clock change dates be deleted now?
https://www.gov.uk/when-do-the-clocks-change
These tasks feel like they should be automated.

Agreed, I've removed clock changes for 2015.
With regards to automating, I also agree.

For generating the bank holiday data, it should be possible to insert it into the JSON files straight away rather than relying on copying and pasting
For generating the clock change data there is currently no rake task and relies on someone manually looking for the data, so that could definitely be improved

@davidbasalla thanks for the PR and @fofr for spotting this. This LGTM to me but I'm waiting for someone from Content Team to confirm who can take oversight of this before I hit merge.

All checked https://trello.com/c/g2WpPkTb/473-add-bank-holiday-dates-for-2018. Merging 🚀


Fix assertion for route-rule

Coverage decreased (-0.09%) to 63.165% when pulling 27993456ba82b46409c379a01772f0ebe98ee803 on savitaashture:routeRule into 0905dc69585f339467ed06482727cb1dbbc56f64 on ServiceComb:master.


How to load external svg file in SvgIcon component

All the demos in the doc shows loading svg as something like:
<path d="M10 20v-6h4v6h5v-8h3L12 3 2 12h3v8z" />

I don't know what this format is. But I wonder how I can load a svg from external file in SvgIcon component.

@zhaoyi0113 SvgIcon provides a few helpers on top of the <svg> element. If you have external icons. You have different options. One is to use https://www.smooth-code.com/open-source/svgr/playground/.

That means material-ui SvgIcon doesn't support load svg from external files?

What do you mean by loading an SVG from an external file?

for example, I have many svg files located on my disk at ../public/svg/..., I usually load them from local path. Just like <img src='../public/svg/...'>.  But with SvgIcon, I have to copy the file content and paste them inside SvgIcon, is my understanding correct?

@zhaoyi0113 Correct, you can't swap an img component for an svg one.

Can I swap SvgIcon on an svg file?

No, you can't use it.

So how do you load an SVG icon from a file in MUI? Do we just use <img /> ?

Yes.

If you are using create-react-app, you can use ReactComponent to load a svg file as an SVG component, instead of using SvgIcon
https://create-react-app.dev/docs/adding-images-fonts-and-files/#adding-svgs

Head to https://github.com/mui-org/material-ui/issues/18782#issuecomment-569233631 if you are curious about the why someone would want to use the SvgIcon component in such a case.


Define prototype goals

Roughly make https://github.com/kcp-dev/kcp#what-does-it-do-for-me real
Demo

CRD Tenancy - A user can try out "logical clusters" and CRD tenancy
Kube-above-Kube - A user can "import a cluster's objects", see workload end up on one or more clusters
Extending KCP with controllers - A user can write or adapt a simple controller with CRD against KCP that doesn't

Meta-goals:

Lots of flexibility added to Kube in a way that benefits different teams
The lifecycle of app infra APIs can be managed, composed, and reused
KCP enables higher security by separating out teams / roles / users / problems

User goals:

95% workload relevance for multi-cluster apps - We demonstrate that "95%" of kube apps could be deployed to KCP, end up on an underlying cluster, and then move/replicate between clusters with a combination of code and design drafts (services, deployments, volumes, etc) (reschedule app across clusters, active-passive, active-active)
Logical clusters allow isolation AND integration - We demonstrate how a controller could work across tens or thousands of logical clusters with list/watch and mutation, allowing teams AND integrations to scale with security
Within a logical cluster, a developer can have a PaaS like promotion flow with dev/stage/prod
Within a physical cluster, resources from multiple logical clusters are isolated

Described use cases guiding transparent multi-cluster a bit more in #75 but will move that to a doc

This has been superseded by new milestones and issues. If anything fell through the cracks, please let me know and we'll make sure to create new issues.


Need some clarifications in regard to the toIndexableString method

Warning! This will not work for CouchDB _ids, due to a bug in how Chrome parses URLs. Basically what you will need to do is remove all the \u0000 characters and use some other separator. Assuming you're storing text data and not binary data, \u0001 should be fine:

So does it mean that we cannot use this method to generate the _id if we want to do remote syncing to a CouchDB server? Or it will work fine with remote CouchDB if we simply replace \u0000 with \u0001` as you suggested?
Cheers

Yes, that's what it means. You cannot use it if you are syncing with CouchDB, because Chrome misinterprets the u0000.

I'll update the README.

Out of curiosity, why not just make pouch collate use \u0001 by default instead of \u0000? Especially for default interoperability with CouchDB...

Legacy reasons. We used the u0000 when we didn't realize it would cause so many problems. :P

Hello can you give an example? if i serialze all properties of a doc, and i want to request only one property? how do i do?

Closing because this has been moved into the main PouchDB repo: https://github.com/pouchdb/pouchdb/pull/5476


Use the name of the property as base for the accessors

The original name may have been changed to prevent conflicts. The name of the getter and setter must match the name of the property, otherwise these will create new conflicts.

I'm closing this PR. The code is moved to #2870, because it is only relevant with that change.


Why not add footer into NavigationPane?

Is your feature request related to a problem? Please describe.
In my case i want to use pane only in NavigationView, if there is no app bar i should add WindowCaption in to pane's right side, but there is no widget can fit.
Describe the solution you'd like
add footer not only footer item in to NavigationPane.

Sorry, i think customPane can help me.

You can use a custom pane item:
https://github.com/bdlukaa/fluent_ui/blob/master/example/lib/main.dart#L483-L522

@bdlukaa thx


Shopify graphQL proxy

Thanks so much for keeping the library going! Looks like it works but failing to get the graphqlProxy working with it.
  router.post(
    "/graphql",
    verifyRequest({ returnHeader: true }),
    async (ctx, next) => {
      await Shopify.Utils.graphqlProxy(ctx.req, ctx.res);
    }
  );

But get 404 with this method.
Have tried the latest version of https://www.npmjs.com/package/@shopify/koa-shopify-graphql-proxy
Error forwarding web request: Error: connect ECONNREFUSED ::1:53462

Any ideas?

Firstly, if you are getting graphqlProxy from Shopify.Utils.graphqlProxy, then I don't think there's any reason to use @shopify/koa-shopify-graphql-proxy.
But I think the issue is you are not responding to the request.
You need to do something like:
router.post("/graphql", verifyRequest({ returnHeader: true }), async (ctx) => {
   try {
      const response = await Shopify.Utils.graphqlProxy(ctx.req, ctx.res);
      ctx.response.status = 200;
      ctx.response.body = response.body;
   } catch (err) {
      ctx.response.status = 500;
      ctx.response.body = "GraphQL proxy error";
   }
});

Was working before adding changing the auth library to simple-koa-shopify-auth, but might be unrelated. Thanks for looking into it I'll update here or close soon.

https://github.com/Shopify/shopify-api-js/blob/v5/src/utils/graphql_proxy.ts#L9

https://github.com/Shopify/shopify-api-js/pull/324/files thanks didn't notice the breaking changes in the API!


fix: Replace "syntax" with "xml" code fences

Used find/replace regex in VS Code
Find: syntax(\s\n*)<\?xml Replace:xml$1<?xml

@levinec - PR is ready for final review. Thanks.

@ManikaDhiman @nickbrower - can you take a look. Since this is generated by automation, I want to make sure we're not breaking anything.


Incorrect outer key returned for get_bgp_neighbors_detail()

Verbatim copy from https://github.com/napalm-automation/napalm-base/issues/227
According to the documentation both get_bgp_neighbors() and get_bgp_neighbors_detail() should: "Returns a dictionary of dictionaries. The keys for the first dictionary will be the vrf (global if no vrf)." However different values seem to be returned for the outer keys of each calls. (i.e. one is the vrf the other the routing instance?)
get_bgp_neighbors_detail() appears to return a dictionary of routing instances and not a dictionary containing the VRF as returned in get_bgp_neighbors(); it would seem that the get_bgp_neighbors_detail method should also return 'global' vrf as outer key. (only default/global VRF configured)
neighbor_facts = device.get_bgp_neighbors()
print("get_bgp_neighbors():")
for vrf in neighbor_facts:
print("Outer key values: " + vrf)
detail_facts = device.get_bgp_neighbors_detail()
print("get_bgp_neighbors_detail():")
for vrf in detail_facts:
print("Outer key values: " + vrf)
Results -
Cisco (ASR9010 - 5.3.3):
get_bgp_neighbors():
Outer key values: global
get_bgp_neighbors_detail():
Outer key values: default
JunOS (15.1F5-S4.6)
get_bgp_neighbors():
Outer key values: global
get_bgp_neighbors_detail():
Outer key values: inet6.0
Outer key values: inet.0
Outer key values: inetflow.0
JunOS (12.3R9.4)
get_bgp_neighbors():
Outer key values: global
get_bgp_neighbors_detail():
Outer key values: inet6.0
Outer key values: inet.0
Outer key values: inetflow.0
In examples above outer dict isn't returning the same value for both calls.

@mirceaulinic  - in #139 you mentioned rolling the routing instances into 'default' - for clarity would that be better labeled with an outer key of 'global' such that the outer key will match the output  of get_bgp_neighbors()?  To be fair - that might also require a change to the IOSXR code as well since it returns 'global' for the get_bgp_neighbors but 'default' for get_neighbors_detail.

You are correct @jeffgallagher - this should be fixed also in XR. Thanks for pointing it.

rolling the routing instances into 'default'

I think that's very dangerous and might break a lot of code. It will certainly break code, I know several DC network using routing instances as they don't need VRFs (no MPLS so no need of the extra overhead) to isolate L3 networks so this method will all of a sudden work completely different. I think this require more thinking and adding without changing anything.

I remember discussing the above with @dbarrosop and the cause of this misunderstanding was my wording. For the record, I referred to grouping inet.0, inet6.0 etc into default, leaving unchanged the behaviour for the rest of the VRFs.

Yes, +1 to your last comment and the solution proposed here.

Closed via https://github.com/napalm-automation/napalm-junos/commit/a995d5ebce084b126a59d8c88ba93fd0b8f4e2ad


Add tests for query, wrong active type

Additions to reach 100% coverage on models and routes.

Codecov Report

Merging #103 (814ed92) into master (5a24106) will increase coverage by 1.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
+ Coverage   94.76%   95.84%   +1.08%
==========================================
  Files           7        7
  Lines         439      433       -6
==========================================
- Hits          416      415       -1
+ Misses         23       18       -5

Impacted Files
Coverage Δ

service/routes.py
99.39% <100.00%> (+2.42%)
:arrow_up:

service/models.py
100.00% <0.00%> (+0.67%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fixes try_execute_command message parsing bug

We were double reading the length of the message, this was masked when we had longer queries where we could read those extra bytes without causing an issue.  A ruby health check change uncovered that when sending something like ; as a query we were running into panics because the buffer did not have the expected number of bytes.

Really nice, thank you.


replace tests for _array == NULL with _size tests

Would make the lib more portable to a template version.
Test size==0 would be more explicit about the problem?

Deconstructor might be 'difficult'

Does not add enough imho.


Package names should be kebab-case

The generated package name in composer.json should be a kebab-case'd version of the plugin name. Right now it's just all-lowercase without any spaces:
"name": "craftcms/elementapi",

should be:
"name": "craftcms/element-api",

(This is a matter of preference, but the convention among other Composer packages seems to be kebab-case.)

hmmmm. Does this apply to the namespacing globally as well?  e.g.:
namespace craftcms/element-api;

vs.
namespace craftcms/elementapi;

Right now, it does the latter everywhere.

Nope namespace should be lowercase w/out any spaces/hyphens/etc. This issue only affects package names.

All set:
1.2.11 - 2017.02.14
Changed

Composer package names and github-related names are now in kebab-case


New test FlutterDeviceScreenshotTest is failing on monorepo CI

A new Android integration test fails on monorepo build and test CI.
The new test integration_test.FlutterDeviceScreenshotTest
is failing on monorepo with the error that no version of gradle 8.0.0 compatible with Java 8 is found.
I see that the PR adding this test upgraded gradle and java dependencies in this package, perhaps something needs to be configured on the CI builders? PR: https://github.com/flutter/flutter/pull/132406
The failing builder is at
https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-linux-framework-tests
The monorepo console is at https://ci.chromium.org/p/dart/g/monorepo/console
The monorepo repository is at https://dart.googlesource.com/monorepo/+/refs/heads/main
Monorepo is a build of tip-of-tree Flutter framework, tip-of-tree Flutter engine, and tip-of-tree Dart SDK all together, that
allows local testing, CI, and tryjobs/commit queue testing.
The error log for this test failure is:
ELAPSED TIME: 37.283s for ../../bin/flutter test --test-randomize-ordering-seed=20230910 --fatal-warnings --enable-vmservice --exclude-tags=web in packages/integration_test
RUNNING: cd packages/integration_test/example/android; gradlew :integration_test:testDebugUnitTest --tests dev.flutter.plugins.integration_test.FlutterDeviceScreenshotTest
Downloading https://services.gradle.org/distributions/gradle-8.0-all.zip
.......................................................................................................................................................................................
Unzipping /b/s/w/ir/cache/gradle/wrapper/dists/gradle-8.0-all/a2o1xoguejy6msdh0lk99lxza/gradle-8.0-all.zip to /b/s/w/ir/cache/gradle/wrapper/dists/gradle-8.0-all/a2o1xoguejy6msdh0lk99lxza
Set executable permissions for: /b/s/w/ir/cache/gradle/wrapper/dists/gradle-8.0-all/a2o1xoguejy6msdh0lk99lxza/gradle-8.0/bin/gradle

Welcome to Gradle 8.0!

For more details see https://docs.gradle.org/8.0/release-notes.html

To honour the JVM settings for this build a single-use Daemon process will be forked. See https://docs.gradle.org/8.0/userguide/gradle_daemon.html#sec:disabling_the_daemon.
Daemon will be stopped at the end of the build

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'android'.
> Could not resolve all files for configuration ':classpath'.
...
> Did not resolve 'org.ow2.asm:asm:9.2' which is part of the dependency lock state
> Did not resolve 'org.jetbrains.kotlin:kotlin-stdlib-common:1.7.10' which is part of the dependency lock state
   > Could not resolve com.android.tools.build:gradle:8.0.0.
     Required by:
         project :
      > No matching variant of com.android.tools.build:gradle:8.0.0 was found. The consumer was configured to find a library for use during runtime, compatible with Java 8, packaged as a jar, and its dependencies declared externally, as well as attribute 'org.gradle.plugin.api-version' with value '8.0' but:
          - Variant 'apiElements' capability com.android.tools.build:gradle:8.0.0 declares a library, packaged as a jar, and its dependencies declared externally:
              - Incompatible because this component declares a component for use during compile-time, compatible with Java 11 and the consumer needed a component for use during runtime, compatible with Java 8
              - Other compatible attribute:
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0')
          - Variant 'javadocElements' capability com.android.tools.build:gradle:8.0.0 declares a component for use during runtime, and its dependencies declared externally:
              - Incompatible because this component declares documentation and the consumer needed a library
              - Other compatible attributes:
                  - Doesn't say anything about its target Java version (required compatibility with Java 8)
                  - Doesn't say anything about its elements (required them packaged as a jar)
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0')
          - Variant 'runtimeElements' capability com.android.tools.build:gradle:8.0.0 declares a library for use during runtime, packaged as a jar, and its dependencies declared externally:
              - Incompatible because this component declares a component, compatible with Java 11 and the consumer needed a component, compatible with Java 8
              - Other compatible attribute:
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0')
          - Variant 'sourcesElements' capability com.android.tools.build:gradle:8.0.0 declares a component for use during runtime, and its dependencies declared externally:
              - Incompatible because this component declares documentation and the consumer needed a library
              - Other compatible attributes:
                  - Doesn't say anything about its target Java version (required compatibility with Java 8)
                  - Doesn't say anything about its elements (required them packaged as a jar)
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0')
   > Could not resolve com.android.tools.build:gradle:8.0.0.
     Required by:
         project :
      > No matching variant of com.android.tools.build:gradle:8.0.0 was found. The consumer was configured to find a library for use during runtime, compatible with Java 8, packaged as a jar, and its dependencies declared externally, as well as attribute 'org.gradle.plugin.api-version' with value '8.0' but:
          - Variant 'apiElements' capability com.android.tools.build:gradle:8.0.0 declares a library, packaged as a jar, and its dependencies declared externally:
              - Incompatible because this component declares a component for use during compile-time, compatible with Java 11 and the consumer needed a component for use during runtime, compatible with Java 8
              - Other compatible attribute:
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0')
          - Variant 'javadocElements' capability com.android.tools.build:gradle:8.0.0 declares a component for use during runtime, and its dependencies declared externally:
              - Incompatible because this component declares documentation and the consumer needed a library
              - Other compatible attributes:
                  - Doesn't say anything about its target Java version (required compatibility with Java 8)
                  - Doesn't say anything about its elements (required them packaged as a jar)
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0')
          - Variant 'runtimeElements' capability com.android.tools.build:gradle:8.0.0 declares a library for use during runtime, packaged as a jar, and its dependencies declared externally:
              - Incompatible because this component declares a component, compatible with Java 11 and the consumer needed a component, compatible with Java 8
              - Other compatible attribute:
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0')
          - Variant 'sourcesElements' capability com.android.tools.build:gradle:8.0.0 declares a component for use during runtime, and its dependencies declared externally:
              - Incompatible because this component declares documentation and the consumer needed a library
              - Other compatible attributes:
                  - Doesn't say anything about its target Java version (required compatibility with Java 8)
                  - Doesn't say anything about its elements (required them packaged as a jar)
                  - Doesn't say anything about org.gradle.plugin.api-version (required '8.0')

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org/

BUILD FAILED in 15s
╔═╡ERROR╞═══════════════════════════════════════════════════════════════════════
║ Command: gradlew :integration_test:testDebugUnitTest --tests dev.flutter.plugins.integration_test.FlutterDeviceScreenshotTest
║ Command exited with exit code 1 but expected zero exit code.
║ Working directory: /b/s/w/ir/cache/builder/flutter/packages/integration_test/example/android
║ stdout and stderr output:
║ (stdout/stderr output was more than 10 lines)
╚═══════════════════════════════════════════════════════════════════════════════

Taking a look, looks to be related to the current lockfile configuration

The recipe link seems to be broken on this page (the link in the "infra" category): https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-linux-framework-tests/891/overview

I don't have a version of Java 8 installed locally, but since https://github.com/flutter/flutter/pull/125323 the example app will require Java 17 to run (and these tests get run from the example app).
It looks like the ci bot isn't configured to use Java 17 (though I can't confirm before I find the recipe), which could cause problems (though the error message for doing the same with Java 11 instead of 8 does not look like this). But even if this is a different error I believe we would need to configure the bot to use 17 as a next step.

The recipe is at flutter.googlesource.com/recipes, recipes/engine_v2/builder, the same as the engine builders.
Could it be the java versions that are installed? They are installed by the.dependencies module in those recipes, controlled by the Json configuration of engine-v2.

OK, I think we may need to add a dependency like
{
   "dependency": "open_jdk",
  "version": "version:11"
 },

https://dart.googlesource.com/monorepo/+/refs/heads/main/ci/builders/host_linux.json#545
Should this be 11, 12, or 17?

Yep, I think a {"dependency": "open_jdk", "version": "version:17"}, should solve it. It needs to be 17 as that is what AGP 8 requires

I added the dependency on Java 17 to the runner, and now the integration_test/example/android test passes, but another test fails instead.  Could it be that some tests are incompatible with Java 17, and the new test requires it?  If so, than the test suite will always fail.
I checked, and the shard framework_tests subshard misc requires Java 17, and runs on the Flutter CI with an OpenJDK step that installs it:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux framework_tests_misc
The shard framework_tests subshard slow which runs tracing_tests is incompatible with Java 17, and runs on the Flutter CI with no JAVA_HOME set.
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux framework_tests_slow
So there is now no way of running SHARD=framework_tests bots/test.dart that will pass, since one subshard test requires java and a different subshard test fails with java. This seems like an undesired unintended consequence of the new test.  Perhaps the old test can be fixed so it doesn't fail?
On the monorepo CI, the solution would seem to be that all the shards now need to run on separate runners. There is no way to run multiple shards on one runner, so now all the shards need to be separated, adding 3 more runners to our CI.
I am running dart [flutter]/dev/bots/test.dart with the shard equal to framework_tests.  Here is the new test that is failing when I install the Java 17 dependency.
BUILD FAILED in 1m 30s
Running Gradle task 'bundleProfile'...                             91.1s
Gradle task bundleProfile failed with exit code 1
╔═╡ERROR╞═══════════════════════════════════════════════════════════════════════
║ Command: ../../bin/flutter build appbundle --profile lib/control.dart
║ Command exited with exit code 1 but expected zero exit code.
║ Working directory: /b/s/w/ir/cache/builder/flutter/dev/tracing_tests
║ stdout and stderr output:
║ (stdout/stderr output was more than 10 lines)
╚═══════════════════════════════════════════════════════════════════════════════
RUNNING: cd dev/tracing_tests; ../../bin/flutter build appbundle --profile lib/test.dart
Flutter assets will be downloaded from https://storage.googleapis.com/flutter_archives_v2/monorepo. Make sure you trust this source!

Running Gradle task 'bundleProfile'...
Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01
Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/03 to old ns http://schemas.android.com/sdk/android/repo/addon2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/03 to old ns http://schemas.android.com/sdk/android/repo/repository2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/03 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01
Warning: unexpected element (uri:"", local:"extension-level"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Warning: unexpected element (uri:"", local:"base-extension"). Expected elements are <{}codename>,<{}layoutlib>,<{}api-level>
Flutter assets will be downloaded from https://storage.googleapis.com/flutter_archives_v2/monorepo. Make sure you trust this source!

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processProfileMainManifest'.
> Unable to make field private final java.lang.String java.io.File.path accessible: module java.base does not "opens java.io" to unnamed module @4650a4e3

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org/

BUILD FAILED in 32s
Running Gradle task 'bundleProfile'...                             32.6s
Gradle task bundleProfile failed with exit code 1
╔═╡ERROR╞═══════════════════════════════════════════════════════════════════════
║ Command: ../../bin/flutter build appbundle --profile lib/test.dart
║ Command exited with exit code 1 but expected zero exit code.
║ Working directory: /b/s/w/ir/cache/builder/flutter/dev/tracing_tests
║ stdout and stderr output:
║ (stdout/stderr output was more than 10 lines)
╚═══════════════════════════════════════════════════════════════════════════════
RUNNING: cd dev/tracing_tests; ../../bin/flutter

I believe I've seen this error when the AGP version the test is using is very old. It looks like these tests are using 4.1.0 which is indeed very old.
I put up a draft pr to see if tests still pass when upgrading the version, will get it merged if so

Looks like builds are green now from what I can tell: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-linux-framework-tests/
Closing for now, please re-open if you run in to more issues!


IP address and subnet range missing to connect to Canada Central database server

I had to add <IP_ADDRESS>/29 IP range to my firewall in order to connect to my database because it's not listed in the Gateway IP addresses list nor in the Gateway IP addresses subnets for Canada Central. Please confirm/revalidate required ranges.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e1a62365-4312-8aad-d2f1-bb5c4184adf1
Version Independent ID: 2ba5b809-8025-d7ee-c756-d6d1bab033fb
Content: Azure SQL Database Connectivity Architecture - Azure SQL Database and Azure Synapse Analytics
Content Source: articles/azure-sql/database/connectivity-architecture.md
Service: sql-database
Sub-service: connect
GitHub Login: @rohitnayakmsft
Microsoft Alias: rohitna

@jpmaciasg Thank you for the feedback. We are reviewing this with the author and will get back to you.

@rohitnayakmsft could you please assist on the above enquiry.

Following up with Rohit

Thanks again @jpmaciasg for taking the time to provide this feedback to Microsoft Docs. Following up here because it is relevant to a Doc update in flight. Your issue may be because of the Redirect vs Proxy connection policy.

When using Redirect, refer to the full list of Azure IP Ranges and Service Tags – Public Cloud in your region for the IP addresses to allow.
When using the Proxy connection policy, refer to the Gateway IP addresses list for your region's IP addresses to allow.

A doc update is in flight to make this more clear and obvious. Thanks again for this feedback, your suggestions help improve our documentation.


small fix to dev setup docs

'clone root' for consistency

View a preview at https://prompt.ws/r/Azure/azure-cli/4845
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.


Find a way to run test after taipy installation from pypi

After pushing the taipy package on pypi we should test it to ensure the package works well and all components are correctly installed.
Moving structure to having src, make sure test succeed on both local and github with no import issue
Be able to run tests:

[ ] Taipy-rest
[ ] Taipy-airflow
[ ] Taipy-entreprise
[ ] Taipy

Expose the pb on a Friday meeting.

OBSOLETE


Support for producing an RTree from a DisplayList

Note that this is a subset of https://github.com/flutter/flutter/issues/92740 in that it doesn't require using the RTree for active culling during rendering, but is merely a support task for enabling PlatformView embedders to embrace the DisplayListBuilder as their primary layer separation mechanism in lieu of their existing use of SkPictureRecorder. This will help Impeller produce more accurate rendering in the presence of these embedded views.

fixed by linked PR


Make DFU rename optional

Copy of this issue: https://github.com/NordicSemiconductor/IOS-nRF-Connect/issues/16
Option to disable setting alternative advertising name is required.

#160 contains a fix


Build secondary long run model

Down sample runs with time shift so all timestamps match and build a q_multi_model for runs that meet that criteria.  Need to also retrain model for short runs to accomadate difference.
*** Don't forget to filter out bad runs that are longer than 1800 and/or have partial fill characteristics.

Using a long model may not be the best idea, potentially look at post processing or using the long models guess as a secondary predictor to factor into a post process.

Idea explored, manual adjustment proves more promising without introducing additional complexity.


Error emitted during rendering of image

Reported by Bob Bogan of Baker & Taylor
This issue is a Bug
Related issue(s) and/or pull request(s)
Not known
Expected Behaviour
Image should be rendered without error
Observed behaviour
From Bob:
"Getting an error while trying to open an ePub using ReadiumJS.  Warning - Viewport: using img dimensions!  Error - Invalid document OEBPS/9780763654658_epub_c19_r1.htm: viewport is not specified!  Book works find in ADE and pages will open in Chrome and IE but not ReadiumJS.  Not sure if issue is in the JS code or the source."
Steps to reproduce

Load the file (not available yet)
Error is emitted (see above)

Test file(s)
Propietary file.  Bob looking into being able to share it.
Product

Readium Chrome extension

latest official version available from the Chrome Web Store?

Additional information
None at this time

It sounds like the meta viewport information is missing (assuming a fixed layout publication).


Use regions also deny block break and block place events

Here's an XML example:
<regions>
	<apply use="deny-all">
		<rectangle min="oo,oo" max="-oo,-oo"/>
	</apply>
</regions>

merged


Helper around ReadBytesExt to manage dynamic endianness

[ ] I agree to follow the project's code of conduct.
[ ] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.
[ ] I ran cargo fmt

For https://github.com/kylebarron/wkb/issues/20


attributed text

how can I write one message with different colors ? I have tried to form it as HTML but no luck
please advise
regards

is there any way to do that ?

No way unfortunately 😔


Replacing Locks with synchronized in ReconnectingChannel.

synchronized is microseconds faster than Locks under load.  It also produces clearer code.

LGTM


Local Bot issues

Bot doesn't play music when when opened... instead it queues the song but doesn't play it... it's not connectivity issues and ffmpeg was installed correctly same with api's... need help please!

Try doing !!s then !!d then queue again, check discord permissions, if it doesn't work, join our discord server and ask for help, someone will help you out eventually.


Bump continuity to fix copy files > 2^32 bytes

Full diff: https://github.com/containerd/continuity/compare/3e8f2ea4b190484acb976a5b378d373429639a1a...2d3749b4da569ac97ca63dccba5eee4f5ee2beab

/ok-to-test

/lgtm
We do need this PR in cri HEAD.
But we we don't need to cherry-pick this to release/1.0. Because after cri is vendored into containerd, the actual continuity package will be the one vendored by containerd. We need to update continuity and cherrypick into containerd/release/1.1 instead.

/test pull-cri-containerd-verify

containerd 1.1 - https://github.com/containerd/containerd/pull/2356/
containerd 1.0 - https://github.com/containerd/containerd/pull/2355
containerd master - https://github.com/containerd/containerd/pull/2354

@cpuguy83 Need rebase.


Add warnings if specified modules are not added to the model

Modifies the StandardModelConstructor to raise warnings if covariance or mean modules are specified, but not added to the model (e.g. because of incorrect output names). Fixes #197.

Needs a test to verify the warnings are raised

Ok, I'll add that when I find the time.


GitHub API Integration Research and Outcome

Task

Research GitHub API
Attempt to pull key features from repo (including issues, PR requests, etc)
Benchmark the API call limit

Deliverables

Code for minimal integration (including functions related to pulling key data as mentioned above)
Unit testing for functions
Follow procedure for CI/CD pipeline

Developed the baseline code for github integration and verified the status of the calls made


Make mat-dialog-content size adjustable

Bug, feature request, or proposal:
Make .mat-dialog-content size adjustable by javascript
What is the expected behavior?
.mat-dialog-container width and height is adjustable by the open method's second parameter.
Make .mat-dialog-content size adjustable like so.
What is the current behavior?
What are the steps to reproduce?
Providing a StackBlitz/Plunker (or similar) is the best way to get the team to see your issue.
Plunker starter (using on @master): https://goo.gl/DlHd6U
StackBlitz starter (using latest npm release): https://goo.gl/wwnhMV
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

mat-dialog-content is just a scrollable container for organizing dialog content. You can control its size via css like any other element

@jelbourn when material used md-dialog-container, the size of the container increases according to md-dialog-content (beta-8) but I've updated material to beta-12 and the mat-dialog-container does not increases it sizes anymore. Now I'm trying to figure out how to increase sizes dynamically as Idon't have access dynamically to mat-dialog-container (at least I can't find on docs)


replacing nv-prod phenolyzer with new backend

Pointing phenolyzer server to use new back end

quarantest build successful. Demo link at
http://43949859.quarantest.iobio.io

Phenolyzer appears to be working and using the new backend: https://services.backend.iobio.io/phenolyzer/?term=dejerine sottas disease autosomal recessive

Looks good to me. You may fire when ready.


changed plot color scheme, added gene ontology analysis results and plots, capitalized cell types, added license

Looks like a lot but it's small changes.
Addressing comments from paper draft. needed to capitalize the cell types in the notebooks, and change the coloring of some plots. Added analysis of gene ontology and the spreadsheets from gene onotology analysis to results folder. Added license file too.

LICENSE: just added the typical license file.
results/EXP4/* : just added the spreadsheets from gene ontology analysis.
evaluation_experiments/EXP1_eval.ipynb: small changes for plots coloring, cell types capitalized.
evaluation_experiments/EXP3_bayesprism_eval.ipynb: small changes for plots coloring, cell types capitalized.
evaluation_experiments/EXP3_cibersort_eval.ipynb: small changes for plots coloring, cell types capitalized.
evaluation_experiments/EXP3_eval.ipynb: small changes for plots coloring, cell types capitalized.
evaluation_experiments/EXP4_eval.ipynb: changed colors and order of samples so they’re according to origin site. Also added the plotting for the GO analysis of PCA and NMF components.
functions/validation_processing.py: added function for NNLS of HGSOC samples that used to be within the notebook its intended for.

looks good -- some plots changed, I flagged them just in case you didn't intend them to change.
Also -- for GOrilla did you use the entire ranked gene list? just double checking

yeah the filtering is done before in the preprocessing now, makes things easier to keep up with. those cell types are just the ones with like 2 or 3 cells.

View entire conversation on ReviewNB

the parameters  used to be set as "random proportioned pseudobulk with noise", now showing the realistic proportions with no noise, so things changed. it's tricky with these notebooks since they're parametrized elsewhere, so the results would vary you know.

View entire conversation on ReviewNB

yeah, this is  as expected though (random vs. realistic props)

View entire conversation on ReviewNB

yeah diff parameters (diff proportion types and noise vs. no noise). i ran it with the other parameters but i am not exporting the resulting notebooks into github. this just happened to be the last set of parameters i ran so its saved as such.

View entire conversation on ReviewNB

yeah, realistic proportions have a lot more preadipocytes so it chanegs the most. as expected.

View entire conversation on ReviewNB

yeah, it's interesting that visually they look similar.

View entire conversation on ReviewNB

yeah, i redid the statistical tests a bunch of times and got the same. and i guess they're deceiving visually

View entire conversation on ReviewNB

yes for ROrilla, i did the entire ranked gene list, then exporting the entire list of statistically significant paths. for the plots i picked the top 30 most significant paths only (just to show, otherwise it gets crazy big)

most comments where due to differences in parameters (random vs. realistic pseudobulks with noise vs. no noise).


Align XML version between RDF.to_file and RDF.from_file

to_file produces XML 1.1, but from_file expects XML 1.0.

As a more concrete suggestion, RDF.to_file could have an option to export with XML version 1.0, which from_file can then read.

I noticed this because our tests utilize round tripping RDF. The previous version (1.2.10) didn't have this issue. to_file produced version 1.0. I worked around this for our tests.


How to use image

How to use image in universal app?

Check
https://github.com/atulmy/crate/blob/master/code/web/src/modules/product/Detail.js#L76
and
https://github.com/atulmy/crate/blob/master/code/web/src/modules/pages/Home.js#L26


Fixed more typos in javadocs

Also fixed a typo in ChatLib.getChatBreak with seperator parameter, seperator ->
separator :))))))

merge 😡 😃

Codacy still hasn't passed bud

yes shutup :)


Enable use of other hash functions for checksums

Connects to resin-io/etcher#643
This enables the use of other hash functions for checksum calculation other than CRC32.
It also adds the ability to employ several different checksums on the same image:
Changes:

Add lib/checksum-stream
Add checksumAlgorithms option to specify wanted checksums
Remove dev-null-stream dependency, as streams can be put into flowing mode by calling .resume() on them
Update tests to check against multiple checksum algorithms
Replace tests/images/*/checksum with tests/images/*/checksum.json

Example:
checksum.calculateDeviceChecksum( fd, {
  checksumAlgorithms: [ 'crc32', 'md5', 'sha1' ]
}).then((result) => {
  console.log(result);
});

Output:
{
  crc32: 'e81722f0',
  md5: '7cb29a4db8f87a764aef96c7cef0787d',
  sha1: 'e4036699988a7e36513adfd86b9ab68190de1e08'
}

Writer Example:
const writer = imageWrite.write({
  fd: outputFileDescriptor,
  device: data.output,
  size: imageSize * 1.2
}, {
  stream: stream,
  size: imageSize
}, {
  check: true,
  checksumAlgorithms: [ 'crc32' ]
});

Can we add tests for different algorithms?

Can we add JSDoc @examples to the functions/classes?

We should also update the JSDoc annotations from the entry point functions to reflect the new API, and regenerate the README from that.

I think the CLI example (bin/cli.js) should be updated to match this as well.

I think the CLI example (bin/cli.js) should be updated to match this as well.

Why does this module have a CLI? Is there demand / requirement for it somehow somewhere, or could it theoretically be culled?

I dunno if it's quite what you're asking, but there's https://github.com/resin-os/resin-device-toolbox/blob/master/package.json#L53

Nah, dependents are not what I meant – I'm wondering where the CLI is used (if at all?);
as in "where would someone or something install this globally and run $ etcher-image-write <image> <device>?"

@jhermsmeier I built it for testing purposes. When I'm testing among machines, it makes my life much easier to have a pre-made CLI that I can run with an image and a real device, just to ensure everything is fine. Feel free to remove it if its not helpful for you, or if you have a better way to test stuff in mind.

@jviotti Ah, okay, I see – I was just thinking about what exactly to do with it, since you mentioned updating it. And now I'm thinking it might be better to update the CLI in another PR, to not blow the scope of this. Then we could add some fancier things to it as well (I was thinking about options for verification and piping images from stdin, and such). What do you think?

Sounds great to me! At some point I mentioned what we want to run real test scenarios on computers with real drives plugged in, and this CLI might be a good way to run those.

At some point I mentioned what we want to run real test scenarios on computers with real drives plugged in

Like a crossover with https://github.com/resin-io/autohat ? :-)

We had a chat about joining forces with AutoHat for this purpose on the summit, however we concluded that AutoHat wouldn't help much a cross-platform setup like this, and we were better off attaching a couple of NUCs with different OSes to Travis as custom nodes and use the Travis machinery for it.

Cool, didn't even know you could do that with Travis :-)

Closing this in favor of https://github.com/resin-io/etcher/pull/1671


Support progress reporting in default stdenv builder

As of Nix 1.12, we have preliminary progress reporting support. It would be great to experiment with sandwiching that into our default stdenv builder (the one that calls configure/make/make install). This would cause a mass rebuild but would be a good step towards reducing build noise and improving user friendliness.
We'll obviously want to do this for all sorts of language-specific builders too, but for now I'd start with the basic one.
cc @edolstra

i think this would still be good

...

0061fae2


Route [filament.users.index] not defined

I am getting an exception when I try to login to dashboard as an admin:
Symfony\Component\Routing\Exception\RouteNotFoundException Route [filament.users.index] not defined. (View: \www\projet\vendor\filament\filament\resources\views\components\layouts\app.blade.php)
This happens only to admin user. I am using laravel 8 and Jetstream, I tried to look for this route and I did not find it on vendor folder.
Let me know if you need any more details.

Not able to reproduce this on a fresh, non-Jetstream installation. Will retry with a Jetstream installation.

Still not able to reproduce in a fresh Jetstream application. @drhoussem Did you install into a brand new application?

Have you tried running php artisan route:clear? The route is (I guess) registered here with a dynamic name: https://github.com/laravel-filament/filament/blob/main/routes/web.php#L43-L46

Hi,
In case of someone encounters the issue, here is what happend for me.
I encountered the issue because I was registering resources manually the boot method of a ServiceProvider.
class FilamentServiceProvider extends PluginServiceProvider
{
    public function boot(): void
    {
        $resources = [
            UserResource::class,
        ];
        foreach ($resources as $resource) {
            Filament::registerResource($resource);
        }
        $pages = [
            CreateUser::class,
            EditUser::class,
            ListUsers::class,
        ];
        foreach ($pages as $page) {
            Filament::registerPage($page);
        }
    }
}

As the resource was registered to early in the request lifecycle, routes weren't created by Filament.
I ended up extending a \Filament\PluginServiceProvider and I used the $resources property.
<?php

namespace App\Providers;

use App\Domain\User\Filament\Pages\CreateUser;
use App\Domain\User\Filament\Pages\EditUser;
use App\Domain\User\Filament\Pages\ListUsers;
use App\Domain\User\Filament\UserResource;
use Filament\PluginServiceProvider;

class FilamentServiceProvider extends PluginServiceProvider
{
    protected $pages = [
        CreateUser::class,
        EditUser::class,
        ListUsers::class,
    ];
    protected $resources = [
        UserResource::class,
    ];
}

If I create a namespace base auto discovery mechanism, I'll register the resources as follow:
public function register(): void
{
    $this->app->booting(function () {
        // Register resources
    });
}

@shaffe-fr, I tried your solution. Stil the same problem for me.
Also I think we should use Filament::serving(function() {....}); , so it's only registering resources when accessing Filament right?

did u try filament.admin.resources.users.index   ?

Have you tried running php artisan route:clear? The route is (I guess) registered here with a dynamic name: https://github.com/laravel-filament/filament/blob/main/routes/web.php#L43-L46

It Worked. Thank you

i run "php artisan route:cache" or "php artisan route:clear" then it works again


Pay Button - Cannot close modal when selecting a wallet to connect to

There should be an x or back button on this page

Fixed in https://github.com/getAlby/bitcoin-connect/pull/217