Konga dashboard will not load if konga installed on seperate machine other than kong machine

Konga dashboard will not load if konga installed on separate machine other than kong machine... if i install it on same kong api machine it works fine. I am getting below error
debug: KongProxyController:req.url /status
error: KongProxyController request error { message: 'Not found' }
debug: KongProxyController:req.url /status
debug: KongProxyController:req.url
error: KongProxyController request error { message: 'Not found' }
Am i missing any configuration ?

I noticed that you can't end the kong api url with an ending / for example http://konga.herokuapps.com/kong-api instead of http://konga.herokuapps.com/kong-api/ - can you re-check if this is the issue...
If not, you can always add console.log statements to the KongProxyController.js in the Proxy method, for example:
sails.log.debug("KongProxyController:req.url 1", KongService.headers(req.connection, true))
sails.log.debug("KongProxyController:req.url 2", req.connection.kong_admin_url + req.url)

so you know the exact host and url call being made

@jayeshkulkarni ,
any update on this?
Everything seems to work fine here.

Works fine now
On 03-Mar-2018 3:09 AM, "Panagis Tselentis"<EMAIL_ADDRESS>wrote:
@jayeshkulkarni https://github.com/jayeshkulkarni ,
any update on this?
Everything seems to work fine here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pantsel/konga/issues/167#issuecomment-370060175, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AdOx7Q6hGRSVYhI2TM9HYdWyBYx2E6sJks5tabv2gaJpZM4R1CiP
.


vscode stop

Type: Performance Issue
Why are there 12 processes running with vscode running? If you connect remotely and use vscode, then exit the remote and connect again, vscode stops and no key is entered.
VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:15:18.074Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz (8 x 2803)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
63.63GB (44.15GB free)

Process Argv
--crash-reporter-id a979b64b-a21a-4eea-9f12-4f387fe48392

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    0	    90	 40544	code main
    0	    27	 28988	   crashpad-handler
    0	    90	 29700	   issue-reporter
    0	    39	 37076	   utility-network-service
    0	   120	 39804	   extensionHost
    0	    79	 30484	     "C:\Program Files\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node "c:\Program Files\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\node\jsonServerMain" --node-ipc --clientProcessId=39804
    0	   125	 35648	     "C:\Program Files\Microsoft VS Code\Code.exe" --ms-enable-electron-run-as-node "c:\Program Files\Microsoft VS Code\resources\app\extensions\html-language-features\server\dist\node\htmlServerMain" --node-ipc --clientProcessId=39804
    0	   229	 41020	   window (설정 - JS-2022 - Visual Studio Code)
    0	   105	 41520	   shared-process
    0	    77	 12348	     fileWatcher
    0	    80	 35632	     ptyHost
    0	     8	 39820	       console-window-host (Windows internal process)
    0	     5	 45004	       C:\WINDOWS\System32\cmd.exe
    0	   199	 43684	   gpu-process

Workspace Info
|  Window (설정 - JS-2022 - Visual Studio Code)
|    Folder (JS-2022): 32 files
|      File types: html(17) js(8) gitignore(1) json(1) md(1)
|      Conf files: settings.json(1);

Extensions (5)

Extension
Author (truncated)
Version

prettier-vscode
esb
9.9.0

vscode-language-pack-ko
MS-
1.72.10121003

material-icon-theme
PKi
4.21.0

LiveServer
rit
5.7.9

JavaScriptSnippets
xab
1.8.0

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
2144e591:30553903
vscccc:30566498
pyindex848cf:30577861
nodejswelcome1cf:30587006
fc301958:30573243

Can you give more details? What is the problem?

Connect to win pc with remote desktop and use vscode
Quit remote desktop while running vscode
Access the remote desktop again
Check the vscode window
Keyboard not responding at all.
If you restart the process after ending the process in the task manager, it works normally.
Same symptoms as tested on two remote desktops

Can you give more details? What is the problem?

Connect to win pc with remote desktop and use vscode
Quit remote desktop while running vscode
Access the remote desktop again
Check the vscode window
Keyboard not responding at all.
If you restart the process after ending the process in the task manager, it works normally.
Same symptoms as tested on two remote desktops

Can you give more details? What is the problem?

Thank you !!!

Connect to win pc with remote desktop and use vscode
Quit remote desktop while running vscode
Access the remote desktop again
Check the vscode window
Keyboard not responding at all.
If you restart the process after ending the process in the task manager, it works normally.
Same symptoms as tested on two remote desktops

Not related to dev containers it seems.

Merging to https://github.com/microsoft/vscode/issues/167556


adding default cluster description

related https://github.com/giantswarm/giantswarm/issues/17263#issuecomment-880510294

Yeah I agree it's not the most helpful description but it's the same one we currently use as default for our clusters and it prevents the front end from being confused if the field is empty.


Space API

Create a space API that provides object storage and potentially CDN URLs for data
Basically blob storage.

Tag line "infinite cloud storage"

Done by @domwong

Cool! I really like this api :O :)


Enhance openemu zap

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[ ] The commit message includes the cask’s name and version.

Enhancement to zap stanza for openemu.

Mind doing it to openemu-experimental as well?

https://github.com/caskroom/homebrew-versions/pull/4710


你限制字数了，比如你写9173就少一个I

你限制字数了，比如你写9173就少一个I

Thanks. It is possible to scroll inside the result field. I dont have a satisfying solution for this, but I could imagine to provide a better visible support, decreasing the font-size or similar...


[Bug] Damage: totems don't work

Describe the bug
Custom damage bypasses totems.
To Reproduce
Steps to reproduce the behavior:

Player with totem
2./scoreboard players set @a smithed.damage 20
function #smithed.damage:entity/apply
Player died

Expected behavior
Totem should pop.
Additional context

what i recommend doing instead of an instant kill make it do a high amount of instant damage/instant health that way totems can work

From LimeSplatus

Closing since /damage is a command. smithed.damage will not make it to 1.20.


can't get boost asio working

Hi,
I'm trying to get boost asio working. I tried setting it up with the examples you gave. I tried with boost and with the asio standalone, none of which work.
It seems like cmake is downloading and putting things in my build folder, I can see folders related to boost or asio.
However when I compile a simple project that requires
#include <boost/asio.hpp>
// #include "asio.hpp"

I cannot compile it because it can't find boost asio.
this is my cmake
set (THREADS_PREFER_PTHREAD_FLAG ON)
find_package(Threads REQUIRED)

<EMAIL_ADDRESS>if(asio_ADDED)
  add_library(asio INTERFACE)
  target_include_directories(asio SYSTEM INTERFACE ${asio_SOURCE_DIR}/asio/include)
  target_compile_definitions(asio INTERFACE ASIO_STANDALONE ASIO_NO_DEPRECATED)
  target_link_libraries(asio INTERFACE Threads::Threads)
endif()

add_library(FrameworkLibrary
        src/framework/event_manager/EventManager.cpp
        src/framework/event_manager/ControllerInterface.cpp
        src/framework/timer/TimerInterface.cpp
        src/framework/event_manager/SensorsActuatorsAndControllers.cpp
        src/framework/event_manager/EventDataStore.cpp
        src/framework/state_machine/State.cpp
        src/framework/logging/Logger.cpp
        src/framework/timer/Timer.cpp
        src/framework/event_manager/DelayTimer.cpp
        )
target_link_libraries(FrameworkLibrary
    PUBLIC
        Threads::Threads
        # Boost::asio
        asio
    )

I've maybe this to use standalone asio: asio.cmake
set(ASIO_REPOSITORY
    "https://github.com/chriskohlhoff/asio"
    CACHE STRING "Repository of asio"
)
set(ASIO_TAG
    "asio-1-18-2"
    CACHE STRING "Git tag of asio"
)

set(ASIOCMAKE_REPOSITORY
    "https://github.com/OlivierLDff/asio.cmake"
    CACHE STRING "Repository of asio.cmake"
)
set(ASIOCMAKE_TAG
    "v1.1.1"
    CACHE STRING "Git tag of asio.cmake"
)

include(cmake/CPM.cmake)

CPMAddPackage(
  NAME asiocmake
  GIT_REPOSITORY ${ASIOCMAKE_REPOSITORY}
  GIT_TAG ${ASIOCMAKE_TAG}
  OPTIONS "ASIO_USE_CPM ON"
)

https://github.com/cpm-cmake/CPM.cmake/issues/501 here's working example with boost

@cambp4 Is this still an issue? Do examples in the latest release correct the problem for you?


Add convenience functions for loading in whole samples of sources

For instance, loading in a sample of GalaxyClusters is actually a lot better if you set up BaseSource's first, then generate images etc in parallel before you define a GalaxyCluster where it needs them to find peaks etc.
It could actually be class based, make a ClusterSample class etc, but I don't think I'll do that right now.

I've decided that if I'm going to do this, I'm going to do it properly.
I'll add another part of XGA, samples, where I will write a BaseSample class, then more specific classes for samples of objects - the first of which will be ClusterSample.
That way I can include common sample analyses in those classes, so making an Lx-Tx relation for a cluster sample (for instance).


colour change

Processing https://commons.wikimedia.org/wiki/File:POL_COA_Trzaska.svg
POLCpCpSOSC.svg.txt

lib
pic

rsvg

resvg

resvg renders the green at the top a bit more bright, don't know which one is correct (save both in the same folder and change forward/backward with your png-viewer)
Copyright
soucre: https://commons.wikimedia.org/wiki/File:POL_COA_Trzaska.svg
author:  All except interior of shield and peacock faethers Bastianow based on works of Mr. Tadeusz Gajl interior of shield and peacock feathers made by WarX
license: https://creativecommons.org/licenses/by-sa/2.5

same for https://commons.wikimedia.org/wiki/File:Renal_corpuscle.svg for the green part numbered with 6

rsvg
resvg

Copyright
source: https://commons.wikimedia.org/wiki/File:Renal_corpuscle.svg
author: M.Komorniczak (polish Wikipedist)
license: https://creativecommons.org/licenses/by-sa/3.0

save both in the same folder and change forward/backward with your png-viewer

I'v using vdiff instead.

What resvg backend do you use? It looks like it boils down to backend's anti-aliasing implementation. All those thin lines are nightmare to smooth down.

I use the binary in resvg/target/release/rendersvg
I think the last backend I build resvg was cargo build --release --features "qt-backend"
(Sorry I do not understand anything about what the different backends mean or which I am acutually using.)
I thought it is a different color, but is only a different line-thickness? I think we can close this issue

Yes, and I don't really have any control over it.
You can find the current backend in the help output. Next to the --backend option.

What resvg backend do you use?

Till now with "qt".

cairo, qt, raqote ans skia may produce vastly different results. There are no such thing as a "correct rasterization". And I can't control the behavior from the resvg.
So shapes outlining, gradients. anti-aliasing, text hinting will always be different. So they can be ignored. The real problem is when something is hugely different or missing completely.


Uploading using Remote Desktop Protocol (RDP)?

Is there a way, or does anyone know of an extension beyond SFTP/FTP that will allow me to upload a file to an RDP? I cannot connect to our virtual machine via ftp to upload files, so I have to resort to manually dragging and dropping. This is due to us using bitbucket.

If I remember correctly, RDP is not meant as a standalone file transfer protocol. It's for streaming desktops. Although a mapping to the remote machine's file system does get created during those sessions, I haven't heard of anyone using that feature by itself programmatically.

Believe there is no solution to this - certainly nothing Atom specific.


Move to WildFly Core 1.0.0.CR1

Linux Build 6385 is now running using a merge of bef890471119ae02058950cf8f07c5cd3179a092

Windows Build 1464 is now running using a merge of bef890471119ae02058950cf8f07c5cd3179a092

Linux with security manager Build 1312 is now running using a merge of bef890471119ae02058950cf8f07c5cd3179a092

Linux with security manager Build 1312 outcome was SUCCESS using a merge of bef890471119ae02058950cf8f07c5cd3179a092
Summary: Tests passed: 825, ignored: 317 Build time: 0:06:30

Windows Build 1464 outcome was SUCCESS using a merge of bef890471119ae02058950cf8f07c5cd3179a092
Summary: Tests passed: 2857, ignored: 373 Build time: 0:47:08

Linux Build 6385 outcome was SUCCESS using a merge of bef890471119ae02058950cf8f07c5cd3179a092
Summary: Tests passed: 2856, ignored: 373, muted: 1 Build time: 0:49:02


[8.x] Fixes TypeError when $this->request is null when calling dispatchConnectionFailedEvent

Possible fix for issue #43743.

8.x is closed for bug fixes


Validation will not run with ImageNet

Hi and thanks again for this great work! I've been able to match your reported results after training STL10 for a while, but I can't get things running with the config you've provided for ImageNet in the README - there's an error during validation that prevents things from running.
RuntimeError: invalid argument 0: Sizes of tensors must match except in dimension 0. Got 368 and 335 in dimension 2 at /pytorch/aten/src/TH/generic/THTensor.cpp:612

This can be seen before training starts if num_sanity_val_steps is allowed to be positive.
P.S.
There are a few imports that appear to be missing:

in moco.py, from typing import List
in lars.py:

import torch
from torch.optim.optimizer import Optimizer

but these are minor fixes.

Thanks a lot for the report! I've fixed the issue in the latest commit. We had not been actually running the validation during training of ImageNet to save time, but it is nice to get some indication of progress -- we recommend you use val_percent_check=0.1 when calling pl.Trainer for a good balance.


Windows 11 dev preview broken WSLg

Environment
Windows 11 build 22000.51, dev preview broken WSLg
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Your Distribution version: [On Debian or Ubuntu run `lsb_release -r` in WSL]
Your WSLg version: [Open 'Apps and Features' and check the version of 'Windows Subsystem for Linux GUI app support', e.g: <IP_ADDRESS>]

Steps to reproduce
click Ubuntu 20.04 icon, wait many mins, then it exit

WSL logs:

Attach WSLg logs from  /mnt/wslg

You can access the wslg logs using explorer at: \\wsl$\<Distro-Name>\mnt\wslg (e.g.: \\wsl$\Ubuntu-20.04\mnt\wslg)

puseaudio.log
weston.log
versions.txt

Expected behavior

Actual behavior

Hi, I install first windows 10 Pro, install wsl, join to insider, update to windows 11, install nvidia recommended drivers, install wslg and all work fine (nautilus, gedit and all workfloow), for now.
Now a install IntellIdea in linux and and I'm going to test that.
Exuseme for mi English, spanish is my native language

I confirm that after update to Windows11 developers preview wslg stops working.
You need to update wsl and then it works again.
But all wsl entries are missing from the start menu.

fixed it by follow steps
1, open a terminal as admin right
2, run
wsl --update
update to 5.10.16
3, wsl --shutdown
4, wsl

Sounds like everyone in this thread got their WSLg working again, closing the thread. Let us know if you are still experiencing issues.


nav bar missing

Hey, Could I please add nav bar to your website.
Thank You

Hello! Can I please solve this issue


how to handle information protection

Can someone please explain how to handle information protection to preform permissions on documents ?

@MazenSiraj so you want each user to have specific access to specific file ?

Yes. I need let's say for me as Mazen, when I search on some data related to me, like my employment contract info, my salary, or related projects, it appears for me only. At the same time, I need when you, as another user, ask on some private data related to me, it says "I don't know."
I tried to implement permissions on the resource group on Azure Portal, but it showed an Unauthorized error at the response even if just said Hi.

I'm looking for something similar. I just want to lock it down so only employees can access. I'm very new to Azure Apps.

This is not supported by this accelerator at the moment. Have a look at the following documentation of Azure Cognitive Search (the underlying solution to ground the prompt with the relevant documents).
https://learn.microsoft.com/en-us/azure/search/search-security-trimming-for-azure-search
https://learn.microsoft.com/en-us/azure/search/search-security-trimming-for-azure-search-with-aad

@itmilos Yes. I need let's say for me as Mazen, when I search on some data related to me, like my employment contract info, my salary, or related projects, it appears for me only. At the same time, I need when you, as another user, ask on some private data related to me, it says "I don't know."
I tried to implement permissions on the resource group on Azure Portal, but it showed an Unauthorized error at the response even if just said Hi.

I think you could do this with https://github.com/microsoft/semantic-kernel I would suggest to propose this as feature there.

Closing this issue since Matt linked to the doc about the access control feature, and there have been no follow-up questions.


Show book's notebook TOC title in pinned notebooks view

This PR fixes #15576

Pull Request Test Coverage Report for Build 880119605

12 of 15 (80.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 43.413%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/notebook/src/book/bookTreeView.ts
2
5
40.0%

Totals

Change from base Build 879891341:
0.006%

Covered Lines:
26556

Relevant Lines:
55585

💛  - Coveralls


Move all information to /data

All user configured information should live in /data for two reasons:

If the user decides to attach an external USB hard drive for more space, its easier to just copy the /data directory than to try to find all of the user data stored all over the hard drive.
For backup purposes, simply doing a .tar.gz of the /data directory is easier than backing up all of the configurations and data from across the hard drive.

So, we need to go through and identify all of the config files, change the directories they live in, those they point to, and the systemd startup scripts to feed the new location to the executeable on startup.

Changing the systemd scripts will be tedious but not hard. pi-gen can already execute patches, see the stage-2/01-sys-tweaks/00-patches directory for examples. I also just pushed a new file example for dovecot.


Offline/Online toggle data fetch for workspace settings page

Details
Re-fetch WorkspaceSettings data when we toggle from offline -> online
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/208203
Tests
All Platforms:

Sign-in to NewDot
Create a Workspace for your user (if you don't have one)
Click on your profile pic and then click on your Workspace
Click on General Settings

Web:

Open the developer console (F12 on chrome) and go to the Network Tab
In the Network tab, turn off the internet connection and then turn it back on
Still in the Network Tab, but on the requests list, make sure there is a api?command=Mobile_GetConstants request with the payload formData containing data: ["currencyList"]
Verify that no errors appear in the JS console

Other platforms:

Go offline and back online
Make sure the page does not refresh the WorkspaceSettings is usable

PR Review Checklist

Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[x] Android / native
[ ] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps
All Platforms:

Sign-in to NewDot
Create a Workspace for your user (if you don't have one)
Click on your profile pic and then click on your Workspace
Click on General Settings

Web:

Open the developer console (F12 on chrome) and go to the Network Tab
In the Network tab, turn off the internet connection and then turn it back on
Still in the Network Tab, but on the requests list, make sure there is a api?command=Mobile_GetConstants request with the payload formData containing data: ["currencyList"]
Verify that no errors appear in the JS console

Other platforms:

Go offline and back online
Make sure the page does not refresh the WorkspaceSettings is usable

Screenshots

Web

https://user-images.githubusercontent.com/6564265/167681045-86962085-338c-4f9e-93aa-f35420aeba8f.mov
Mobile Web

https://user-images.githubusercontent.com/6564265/167722208-87870e9f-824c-420d-a5c7-b185cc1ebeea.mov
Desktop

https://user-images.githubusercontent.com/6564265/167681062-dc77f3ff-434c-4557-858f-09242f14ee61.mov
Android

https://user-images.githubusercontent.com/6564265/167720918-7d8e3b3d-ffdc-427b-9e02-7ca5978bbab9.mov

I have read the CLA Document and I hereby sign the CLA

recheck

Asked for new puller bear reviewer because I think @MariaHCD may be out until tomorrow : )

🚀 Deployed to staging by @AndrewGable in version: 1.1.58-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @AndrewGable in version: 1.1.60-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Map username to azure user id for plugin msgraph

Hey, I just made a Pull Request!

Original, plugin msgraph will import azure user data by using mail as key, but azure/microsoft sso login will use user id as key, thus the login user can not link to imported user correctly. By changing to using user id as key, azure sso will work smoothly with azure org data import.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Hi @wangzheng422, there's several unrelated changes, can you please take a look?
This code has been like this for more than a year, it would be great to better understand why it isn't working for you before we make changes? Given that, we should probably add some tests as well (they are currently failing so you'll be updating them anyway).
@afscrome would be good to get your eye on this when you have the chance, please.

HI @wangzheng422 could you elaborate a bit more on why you're making this change and what you're trying to achieve?
Changing how the default entity name is generated is a significant breaking change I'd be loathed to do without a very strong reason.
1.Changing the entity name may break any relationships with other or other custom code other users have.
2. This will change usernames from being friendly names.  So anytime anyone needs to provide a relationship of an entity to a user (e.g. spec: { owner: 22b8a5f3-617a-4f10-a890-439d197776e8 } will become spec: { owner: john.smith }.  Having to look up these guids is not particularly user friendly.

What I try to fix, is when user login through azure sso, in the setting view, the 'user entity' will point to a link using guid. When user click the link, it will report 'entity not found', which is normal because azure org import user entity using email as username.
I agree this is breaking change, but to resolve this, some part of the system needs to be change, maybe the azure sso part, needs to use azure email as username.
Comparing to change the core auth login logic, I think changing the msgraph is related a small change.

Hi @wangzheng422, in the example you provide, you are using a custom sign in resolver, not the built in one
https://github.com/janus-idp/backstage-showcase/blob/f9d19266f294b69149d75206a72e1ea366e78086/packages/backend/src/modules/authProvidersModule.ts#L227-L233
Sign in resolvers can look up users by any property on the entity, you do not have to change the entity name to match your chosen authentication scheme.  For example to look up a user by the Microsoft Graph object id, you can do so by providing some custom providers - https://backstage.io/docs/integrations/azure/org/#customizing-transformation
  return ctx.signInWithCatalogUser({
    annotations: {
      'graph.microsoft.com/user-id': id,
    },
  });

The "entity not found" behavior is an expected design of the custom sign in resolver you linked to - when it doesn't find a match in the catalogue, it falls back to a fake entity (for which not found is totally correct)
https://github.com/janus-idp/backstage-showcase/blob/f9d19266f294b69149d75206a72e1ea366e78086/packages/backend/src/modules/authProvidersModule.ts#L227-L233
If you still want to change the entity name for your specific backstage instance to be an id rather than a friendly name, you may be able to do so with a custom user transformer on the Microsoft Graph Module - https://backstage.io/docs/integrations/azure/org/#customizing-transformation .  Although I would strongly advise against this as the entity name often gets shown in the UI, so it's far preferable to have something human readable, than a meaningless guid.


Add customer group pricing RM

fixes #1614

This doesn't appear to work for Product Variants. Also, I think the tab name should be "Price Breaks" not "Pricing".

whoops


[Feature Request] MULTIPLE OWNER ID'S

Is your feature request related to a problem? Please describe.
Being able to specify multiple owners in settings file
What is your ideal solution to the problem?
Being able to specify multiple owners in settings file
How would this feature be used?
makes it so multiple people can manage the bot
Additional Info
No response
Checklist

[X] I have checked the documentation to make sure this feature doesn't already exist
[X] I have searched for similar feature requests
[X] I have confirmed that my requests is not on the list of things that will not be added
[X] I am running the latest version of the bot:

i saw there was already an issue


Error parsing a meta element's content: ';' is not a valid key-value pair separator.

Hello, I want to work with your plugin but I have some problems. So, I did all about you write in manual and start to build test apk, after that I launch my app and open a browser and go to https(or http)://instant.apps/com.product.name and nothing happens. I start to see logs via adb and find that string:
08-01 10:51:57.391: I/chromium(12647): [INFO:CONSOLE(1)] "Error parsing a meta element's content: ';' is not a valid key-value pair separator. Please use ',' instead.", source: http://instant.apps/com.product.name(1)
Can you help me please?
For tests I create some libraby with empty activity:
<activity android:name="com.product.TestActivity">
    <intent-filter android:autoVerify="true">
        <action android:name="android.intent.action.VIEW" />
        <category android:name="android.intent.category.BROWSABLE" />
        <category android:name="android.intent.category.DEFAULT" />
        <data android:scheme="http" />
        <data android:scheme="https" />
        <data android:host="instant.apps" />
        <data android:path="/${applicationId}" />
    </intent-filter>
</activity>

And also I tried it with/without this:
<meta-data android:name="default-url" android:value="https://instant.apps/${applicationId}" />

Hi, thanks for trying the plugin and for reaching out.
There are two options for configuring the URL that will launch your instant app:

Developer specified URL: provide your own URL in the AndroidManifest and prove that you own the website
Automatic URL: do not specify a URL in the AndroidManifest

It sounds like you're trying to use the second approach. In this case you should remove the VIEW intent filter and "default-url" meta-data related to "https://instant.apps" from your AndroidManifest.
After you publish your app in Play Console, the URL https://instant.apps/your.package.name will automatically open your instant app. However, before you publish and while you're testing locally, the https://instant.apps URL will not open your instant app.
If you want to test your app prior to publishing, you can use the "Build and Run" feature of the plugin or you can directly run the command that it calls:
android-sdk/extras/google/instantapps/ia run instant-app.apk

Thank you for your help! I have another question "Build and Run" feature doesn't help me and I run
android-sdk/extras/google/instantapps/ia run instant-app.apk
So, instant-app.apk is a full release apk with instant app inside or just instant app module?

I'm sorry to hear that the "Build and Run" feature isn't working for you. Do you mind sharing the error message that it is printed to the Unity console log as well as the version of Unity that you're using?
Regarding instant app APKs/modules:

An instant app and a full release app are both packaged in APKs.
There is not much that is special/different about an instant app except some additional requirements for the manifest and for signing (the Unity plugin takes care of these requirements when building an instant app).
A typical Unity instant app is only a single APK (you could think of it as a single module).
In the example "instant-app.apk" is not a full release apk with instant app inside, it's just an Android app that was built with a couple minor changes to support instant. This APK can be run as an instant app using "ia run", or since it's just an APK, it can be installed and run as a regular app, i.e. "adb install instant-app.apk". Note: I mention this to hopefully clarify that it's just like a regular APK, not because this is typically done.

Closing this issue. If there is still a problem, please resubmit here: https://github.com/google/play-unity-plugins/issues


Introduce model GlobalAgentSettings

Ability to deactivate a global agent.
Todo:

[x] Introduce model GlobalAgentSettings.
[ ] Create lib function and api routes to create/update settings.
[ ] Handle click on toggle to deactivate / reactivate a global agents on the builder page.
[ ] Handle status when there's no ds
[ ] Update getGlobalAgents to take into account GlobalAgentSettings

Let's split this in slam-ish PRs :+1:


python3Packages.cryptography: 2.9.2 -> 3.0

Backwards incompatible changes:

Removed support for passing an Extension instance to
from_issuer_subject_key_identifier(), as per our deprecation policy.
Support for LibreSSL 2.7.x, 2.8.x, and 2.9.0 has been removed (2.9.1+
is still supported).
Dropped support for macOS 10.9, macOS users must upgrade to 10.10 or
newer.
RSA generate_private_key() no longer accepts public_exponent values
except 65537 and 3 (the latter for legacy purposes).
X.509 certificate parsing now enforces that the version field contains
a valid value, rather than deferring this check until version is
accessed.

Deprecations:

Deprecated support for Python 2. At the time there is no time table
for actually dropping support, however we strongly encourage all users
to upgrade their Python, as Python 2 no longer receives support from
the Python core team.

Status
Currently running nixpkgs-review.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Preliminary results look ok: 2/1633/3741 built (109 failed)
Only one build is failing due to cryptography and was already failing before:
cannot build derivation '/nix/store/hqzk7jcb1lw0m3rwa7lczcidrcr516pv-python3.7-altair-4.1.0.drv': 1 dependencies couldn't be built
builder for '/nix/store/y2sxsx0d523z746yi9ralxc6s238n38y-python3.7-hass-nabucasa-0.34.6.drv' failed with exit code 1; last 10 log lines:
  /build/source/dist /build/source
  Processing ./hass_nabucasa-0.34.6-py3-none-any.whl
  Requirement already satisfied: snitun==0.20 in /nix/store/isigg4afay72dhdpb09nvkskg0adr9s4-python3.7-snitun-0.20/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (0.20)
  Requirement already satisfied: pytz>=2019.3 in /nix/store/6rn7hm563c069iz42jbal280yxm6p90i-python3.7-pytz-2020.1/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (2020.1)
  Requirement already satisfied: acme in /nix/store/vf82vnbhlvch27mkvbpq9jwbch300r1v-python3.7-acme-1.6.0/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (1.6.0)
  Requirement already satisfied: atomicwrites==1.4.0 in /nix/store/78jqz31f89r4rj4lc5qz66wrg84zdj2d-python3.7-atomicwrites-1.4.0/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (1.4.0)
  Requirement already satisfied: aiohttp~=3.6.1 in /nix/store/ncm6hz810zgayphnmajh83f74p65y4vk-python3.7-aiohttp-3.6.2/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (3.6.2)
  Requirement already satisfied: attrs~=19.3.0 in /nix/store/4hw563pg77nq7lfysqyk124y5a7ld4sf-python3.7-attrs-19.3.0/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (19.3.0)
  ERROR: Could not find a version that satisfies the requirement cryptography~=2.8 (from hass-nabucasa==0.34.6) (from versions: none)
  ERROR: No matching distribution found for cryptography~=2.8 (from hass-nabucasa==0.34.6)

Bumping the major version should most likely be fine then.

@GrahamcOfBorg build python2.pkgs.cryptography


[BXMSPROD-1880] add bamoe-properties-generator job

JIRA: https://issues.redhat.com/browse/BXMSPROD-1880

How to retest a PR or trigger a specific build:

* a pull request please add comment: Jenkins retest this

there are still used rhpam prefixed file names?

there are still used rhpam prefixed file names?

Yes. this is expected as we are keeping the same pattern we have been using since BAMOE 8.0.0


Virus Scanner Check

Background
The virus scanner has been checked and is running well. It is running in what we might call a 'light touch' mode: in that files can be downloaded unless the scanner has marked them as having a virus. We should consider moving to a stricter configuration where files can only be downloaded if they have been marked as not having a virus. Perhaps also we enforce a re-scan policy where a file is re-scanned for viruses if someone is trying to download and it hasn't been scanned for X amount of time.
The problem right now is if our virus scanner stops working, for some reason, all files are still downloadable. If we take a stronger approach then if the scanner stops working our files will stop being available to download. So this helps ensure we keep the scanner up and running.
User Story
As the digital team, I want files to be downloaded only if they are verified as virus-free, ensuring the security of the system.
As the digital team, I want a re-scan policy implemented for files not scanned within a defined time frame to ensure ongoing security.
As the digital team, I want the system to enforce strict download restrictions to ensure that if the virus scanner stops working, files become unavailable for download.
Feature(s) Description

[x] Implement strict file download verification: files must be downloadable only if marked as virus-free
[x] Document the updated configurations and policies for future reference
[x] Prepare and put in place user guidelines explaining the file download process and re-scan policy

Acceptance Criteria

[x] Files must not be downloadable if they have been marked as containing a virus by the scanner.
[x] Files should be available for download only if they are marked as virus-free by the scanner.
[x] Implement a configuration where files are only downloadable if marked as virus-free by the scanner.
[ ] If the virus scanner ceases to function, prevent all file downloads as a fail-safe measure.
[x] If a file hasn't been scanned for viruses within the specified time frame (X amount of time), trigger a re-scan before allowing download.
[x] Define the time interval (X amount of time) for triggering re-scans.

Definition of Done

[x] Files downloadable only if virus-free - logic implemented to allow downloads only for virus-free files.
[x] Re-Scan policy enabled - policy set up to trigger re-scans for files not scanned within a defined time.
[ ] Fail-Safe for Virus Scanner - files become unavailable if scanner fails.
[x] Documentation and guidelines - updated configurations and user guidelines documented

Ticket Champion
Frances
Happy Story
The system's integrity will be strengthened, reducing the risk of potential malware threats.
Sad story
Malicious files can accidentally be downloaded if strict policies are not in place

Hey team! Please add your planning poker estimate with Zenhub @warrensearle @tomlovesgithub @drieJAC @HalcyonJAC

Currently:

Files are scanned upon upload -> marked as either 'clean' or 'infected'
Every hour a scheduled action scans all files which have not been scanned
Files are only downloadable if a file is marked as 'clean'. 'infected'' or unscanned files are not downloadable

Changes in new PR:

Every hour a scheduled action scans all files which have not been scanned OR have not been scanned in 6 months
Groundwork for checking scanner status

Proposed future changes:

Every hour a scheduled action scans all files which have not been scanned
Check scanner is online using a https request, use result to mark a flag in the database, use this flag in storage rules to enable or disable downloads. Schedule the running of this script.

Alternatively check if a EICAR file can be scheduled to test full functionality of the scanner, as well as online status.

There is another concern with the current system which cannot currently be discussed in github/zenhub, but needs to be addressed.

User Guidance
All files uploaded to the database are scanned for viruses. Should the scanner find a malicious file, it will be quarantined by our system and will not be able to be downloaded. When this is the case, users will see the message 'file not available', this message can also be shown under other circumstances.
If your team or a candidate have encountered an unavailable download such as above, please alert the digital team and we will investigate. If you are concerned about potentially malicious files, do not download or share them, please alert the digital team.

@tomlovesgithub I noticed that the estimate had gone from 8 to 13. Was 13 your amended estimate on completion?

@tomlovesgithub I'm closing this ticket in anticipation of a new ticket covering the next steps we discussed today.


Orientation not allowing authentication

Can't seem to get into Orientation. I tried both Chrome and Firefox and still get a 500 error.

I just tried deploying to Heroku and I'm seeing this screen as well. What was the fix?

@jasonbahl Not sure, check your server output with heroku logs.

it's telling me ERROR: relation "users" does not exist
Possibly something went wrong with the deploy?

@olivierlacan don't worry about troubleshooting if I'm the only one reporting issues.  Thanks for the quick reply though.

@jasonbahl That's fine, you likely forgot to run heroku run rake db:migrate. Did you use the Heroku button or set it up on your own on Heroku?

@jasonbahl Can you open a new issue, this one is wholly unrelated. Name it "Heroku Setup" if you want.


Implement Hilbert Transform Trendline, closes issue #411

I implemented the Hilbert Transform Instantaneous Trendline in pandas-ta by studying the mathematical principles of the Z-transform and reverse-engineering TALIB's C implementation. Through rigorous testing, I ensured that the results produced by ht_trendline match those generated by TALIB's implementation, thus enhancing the technical analysis capabilities of the pandas-ta library and closing issue #411 .
In addition, I further enhanced its performance by leveraging the Numba library, thereby significantly boosting the execution speed. This experience allowed me to deepen my understanding of Numba's capabilities and its integration within the project structure. Furthermore, I refined my Git proficiency by creating a new branch locally and generating the pull request towards the development branch. By following best practices and maintaining clean commit histories, I ensured seamless integration with minimal conflicts, streamlining the merge process for @twopirllc .
The code for test is inspired by @rafalsza provided in #411 :
from talib import HT_TRENDLINE

# Define the ticker symbol and time period
ticker = "BTC-USD"
start = "2020-01-01"
end_date = "2022-01-01"
interval = "1d"

# Retrieve the stock data using yfinance
data = yf.download(ticker, start, interval=interval)

# Extract the OHLC data
ohlc_data = data.loc[:, ["Open", "High", "Low", "Close"]]

# Calculate TALIB ht_trendline
talib_itrend = HT_TRENDLINE(ohlc_data['Close'].values)

# Calculate ht_trendline with pandas-ta
pandas_ta_itrend = ht_trendline(ohlc_data['Close'], talib=False)

# Create the figure and add Candlestick and Line traces
fig = go.Figure()

fig.add_trace(
    go.Candlestick(
        x=data.index,
        open=ohlc_data["Open"],
        high=ohlc_data["High"],
        low=ohlc_data["Low"],
        close=ohlc_data["Close"],
        name="OHLC",
    )
)
fig.add_trace(go.Scatter(x=data.index, y=talib_itrend, mode="lines", name="TALIB-ITrend"))

fig.add_trace(go.Scatter(x=data.index, y=pandas_ta_itrend['ht_trendline'].values, mode="lines", name="pandas-ta-ITrend"))

# Set the layout
fig.update_layout(
    title="ht_trendline, TALib vs Pandas-ta implementations",
    xaxis_rangeslider_visible=False,
    xaxis_title="Date",
    yaxis_title="Price",
    legend=dict(x=0.9, y=1, bgcolor="rgba(255, 255, 255, 0.5)", bordercolor="rgba(0, 0, 0, 0.5)"),
    showlegend=True,
#     yaxis=dict(type="log"),  # Set the y-axis scale to logarithmic
)

# Show the plot
fig.show()

Here you can see the results of the the two which are very much the same:

I also found this piece of code very useful for testing pandas-ta functions under development without the necessity of local installation or modification of the current library version.
import sys
import importlib
module_name = "pandas-ta"

sys.path.insert(1, '/path/to/pandas-ta')
from pandas_ta import ht_trendline

Hello @aligheshlaghi97,
On first glance it looks good. I'll take a look this week. Also all the other Hilbert Transform indicators need to be converted as well, so this is a great starting point. Thanks for helping with this. 😎
KJ

Hi @twopirllc
Thank you for taking the time to review the PR. I'm glad to hear that the initial feedback is positive. Could you please elaborate more on what you mean by converting all HT indicators? And also how much should I consider the failed workflows as they may not belong to HT indicator?
Bests,
Ali

@aligheshlaghi97

Could you please elaborate more on what you mean by converting all HT indicators?

Sure. There are a handful left to complete that begin with HT_. I want to get those completed as well as rewrite td_seq before making a new Pandas TA release.

And also how much should I consider the failed workflows as they may not belong to HT indicator?

I can write the tests for it. No worries. 😎

Thank you for the additional information, @twopirllc . I'm eager to assist with completing the remaining HT indicators and rewriting td_seq for the upcoming Pandas TA release.
Could you please let me know if there are any specific notes, resources, or guidelines available for implementing the HT indicators and completing the td_seq rewrite?
Additionally, I wanted to mention that during the implementation of ht_trendline, I found myself delving into calculations related to ht_dcperiod (dominant cycle calculations). As such, I believe I can contribute to other aspects such as phase or sine calculations if needed. Please let me know how I can best support the completion of these indicators.

Hi @twopirllc,
Thank you for your explanations and clarifications. Based on the indicators in TALib prefixed with 'HT_', I believe it's entirely feasible to consolidate all the HT indicators into one. They share many common elements, particularly in the calculation of dcperiod. For instance, the variable period is calculated consistently across nearly all the other indicators, as evident in the source code here.
I wanted to inquire about the level of expectation regarding the similarity between our results and TALib's. Is it anticipated that our results match TALib's precisely, or is there room for minor discrepancies?

@aligheshlaghi97

I wanted to inquire about the level of expectation regarding the similarity between our results and TALib's. Is it anticipated that our results match TALib's precisely, or is there room for minor discrepancies?

Yes. It has been acheiveable with most Pandas TA indicators to match those of TA Lib. Just get a close as you can and I will try and fix the differences. 😎

@aligheshlaghi97
Apologies for taking a bit to get to this.
Updated Development Environment
I am now using Python 3.11.7 versus 3.9.18 as well as required Python packages for Pandas TA:
numba==0.59.0
numpy==1.26.4
pandas==2.2.0
pandas-datareader==0.10.0
pyarrow==15.0.0
scipy==1.12.0
TA-Lib==0.4.28
yfinance==0.2.36

I have also cleaned up most Depreciation and Future Warnings messages due to the environment update.
HT_TRENDLINE
While in the process of incorporating your version of ht_trendline, I have that ht_trendline and TA Libs HT_TRENDLINE are not identical (not counting the prenans) like you have shown above. I am curious, are there any actual differences between your numpy version and TA Lib's starting from row/bar 63? Though they eventually converge to the same values. Can you tell me more about which version of Python and packages you are using?
My results for Python 3.9 and 3.11:

Thanks
KJ

Thank you for the update, @twopirllc
I appreciate your efforts in updating the development environment and addressing the Deprecation and Future Warnings messages.
In regards to the versions, I'd like to confirm that both Python 3.9 and 3.11, along with their respective packages, yield identical results for ht_trendline. I've been working with Python version 3.10.12 and the following package versions:
numba==0.58.0
pandas==1.4.1
scipy==1.9.0
TA-Lib==0.4.28
yfinance==0.2.18

Regarding the differences observed between my code and TALib's, it's possible that the variance stems from the initial point for calculating ht_trendline, resulting in non-identical outputs at the beginning of the array. However, as you rightly mentioned, they converge and maintain good coverage thereafter.
I'll delve deeper into the code and if I find a solution to make them identical, I will provide an update accordingly.
Best regards,
Ali Gheshlaghi

@aligheshlaghi97
No worries. I just wanted to make sure that we were both getting similar results for bars between bars 63 and 167 followed by convergence starting from bar 168 on.

I'll delve deeper into the code and if I find a solution to make them identical, I will provide an update accordingly.

No rush. I'll be diving into it as well while also tackling some other issues.
Appreciate the help. 😎

@twopirllc
I've also found something else worth sharing. If you decrease the index at which the calculations start from 50 to 5, the convergence point will occur earlier. Please make this change in my implementation, on line 30:

While this adjustment seems logical, we can't set it to zero, as Elher indicates in his article, and we can also find some clues to this in TALib's implementation. However, by making this minor change, the convergence point decreases from the 116th candle to the 95th for BTCUSDT-1D data, spanning from 2020 to the present. Moreover, MSE of the result decreases a lot.

Hey @aligheshlaghi97
It's up and ready to go on the development version. Let me know how it works for you. Thanks again for the submission. 😎

Hi @twopirllc,
Thank you for merging the pull request and implementing the changes. It's great to see progress in resolving the differences between our implementation and TALib's.
Upon reviewing the new code, I noticed a longer time taken to converge between our implementation and TALib's, as depicted in the provided screenshots:

However, I also noticed that the mean difference between our implementation and TALib's is very low:

This suggests that while our implementation is more accurate in terms of mean error, it may take longer to converge compared to TALib's.
I was also curious about your thoughts on the idea of mixing all ht_ indicators together. Do you think it's feasible now, or do you have any concerns about this approach?
Bests

@aligheshlaghi97
Yes, that is true it does take a little longer to converge and has generally a smaller mean error. The truth is neither of us were able to exactly replicate TA Libs calculation and that is ok. Sometimes there will be differences in calculation no matter what. A 99% correlation is not bad considering the differences in execution and the original intent from Ehler's EasyLanguage code from which I ultimately chose to default to. However I believe it may be possible to get them exact with more time. The core groundwork has been laid and anyone is welcome to improve it. If you would like your version included as well, let me know, we can do that. No biggie.

I was also curious about your thoughts on the idea of mixing all ht_ indicators together. Do you think it's feasible now, or do you have any concerns about this approach?

In nearly all ta_HT_*.c files they have similar code up to: https://github.com/twopirllc/pandas-ta/blob/947cbde68d1b4660b52670c9d2540405f1820bb6/pandas_ta/trend/ht_trendline.py#L67
So yeah, one or two can be combined easily. The others may need some juggling to do so.
Cheers

Hi @twopirllc
Thank you for your insights.
I appreciate the clarification. I'm glad to hear that some ht_ indicators can be combined easily. Could you please suggest which indicator would be most aligned with your opinion to work on next?
Bests

@aligheshlaghi97

Could you please suggest which indicator would be most aligned with your opinion to work on next?

DC Period and that one is trivial as returning with trendline in the numba function. I'll dig in again after I finish this other task.
Apologies for the delayed response

Hi @twopirllc
Hope you're doing well. I'm still excited about the potential to integrate other APIs for the ht_ indicators.
Did you have any time to work on it? And if so, I'm curious to know would it be better to implement shared sections (e.g. calculation of dcperiod) in a separate module or to implement all of them first and then separate the shared sections of code in the future?
I'd also like to know what I need to do to be listed as a contributor of pandas-ta. Please let me know if there are any specific requirements.
Best regards,
Ali Gheshlaghi

Hi @twopirllc
Sorry for my delayed response; I was working on improving the performance of the ht_trendline indicator.

As we discussed earlier, I think we should try to roll as much as possible into ht_trendline's core loop to minimize overall loop calculations when processing a bunch of indicators. If not, we can try coupling the most similar ht_ indicators together.

In my trials, it seems it's not possible to further optimize our current ht_trendline. I also experimented with some code modifications, but they resulted in incorrect outputs. On the other hand, we are closely following the c code implementation of TA_Lib. As a conclusion, I agree with coupling the shared part of ht_ indicators together (maybe by abstracting).

I will try to rectify it if you make a trivial PR so Github recognizes you as a contributor

I believe this issue arises because we haven't had any releases for a while (or any merges with main branch), so the contribution list isn't updated. However I'll definitely make new PRs.

Irregardless, I remember all the main contributors, like you, to the project. 😎

This is an honor for me🎉

Hey @aligheshlaghi97,

Sorry for my delayed response; I was working on improving the performance of the ht_trendline indicator.

No worries. Even I have long response delays as well, especially since this repo is nowhere close for me to support it full time. 😑

In my trials, it seems it's not possible to further optimize our current ht_trendline. I also experimented with some code modifications, but they resulted in incorrect outputs. On the other hand, we are closely following the c code implementation of TA_Lib.

Thanks for the optimization confirmation.

As a conclusion, I agree with coupling the shared part of ht_ indicators together (maybe by abstracting).

I agree. Which abstraction technique did you have in mind? I do not want to use classes due to their potential execution overhead.

This is an honor for me🎉

Your contributions and collaboration has been most gracious. You don't happen to have a Stripe (or similar) account by chance?
KJ

Hi @twopirllc
Thanks for your response,

especially since this repo is nowhere close for me to support it full time. 😑

I understand, and I am very curious to know whether you're working on your public projects e.g. AlphaVantageAPI (which sounds interesting to me) or mainly on private ones.

I agree. Which abstraction technique did you have in mind?

I think abstract class could be useful for us. We can also use python protocols to remain decoupled and only use type checks.

I do not want to use classes due to their potential execution overhead.

This sounds cool, but there is debates about the performance impact, and we might need to conduct our own survey. Please look at this link about class overhead vs function
Btw, if you don't want to use class's methods, there will be absolutely no difference and we can define one function to calculate the shared parts. And then use that function inside our new APIs.
Shared Parts of ht_ Indicators
Our desired ht_ indicators from TA_Lib are: ht_dcperiod, ht_dcphase, ht_phasor, ht_sine, ht_trendline, ht_trendmode. The shared section of code for these six indicators is calculation of period (in my opinion) which happens in all of these indicators c implementation. Please take a look at this link which shows how period is calculated in those six indicators. Or you can simply search for this line of code in TA_Lib: period = (0.2*period) + (0.8 * tempReal);

You don't happen to have a Stripe (or similar) account by chance?

Unfortunately I don't have and cannot open one due to restrictions of my country, so I use cryptocurrency for my daily payments.

Hey @aligheshlaghi97

I understand, and I am very curious to know whether you're working on your public projects e.g. AlphaVantageAPI (which sounds interesting to me) or mainly on private ones.

Mainly private ones. I haven't touched AlphaVantageAPI in a long time, too busy with Pandas TA. 😑

I think abstract class could be useful for us. We can also use python protocols to remain decoupled and only use type checks.

Yeah an ABC could be useful. Haven't heard of protocols, they seem like they can help. 🤷🏼♂ If you want to try that approach, that would be cool.

This sounds cool, but there is debates about the performance impact, and we might need to conduct our own survey. Please look at this link about class overhead vs function

Yeah I remember reading something like that. That the performance difference is negligible.

Btw, if you don't want to use class's methods, there will be absolutely no difference and we can define one function to calculate the shared parts. And then use that function inside our new APIs.

We will find a path, time willingly.

Our desired ht_ indicators from TA_Lib are: ht_dcperiod, ht_dcphase, ht_phasor, ht_sine, ht_trendline, ht_trendmode. The shared section of code for these six indicators is calculation of period (in my opinion) which happens in all of these indicators c implementation. Please take a look at this link which shows how period is calculated in those six indicators. Or you can simply search for this line of code in TA_Lib: period = (0.2*period) + (0.8 * tempReal);

I will try and expand nb_ht_trendline to include the remaining ht_ indicators.
Yeah, period = (0.2*period) + (0.8 * tempReal) and re, im are also calculated similarily. They are basically ema's of length 9.

Unfortunately I don't have and cannot open one due to restrictions of my country, so I use cryptocurrency for my daily payments.

Damn! I checked stripe and they don't support crypto there either. 😑 And I almost never use crypto.  I'll look more into it when I can.

Hi @twopirllc
Thanks for your response.

Mainly private ones. I haven't touched AlphaVantageAPI in a long time, too busy with Pandas TA. 😑

Totally understandable and hopefully I'd be able to help you with some Pandas-TA's loads.

Yeah an ABC could be useful. Haven't heard of protocols, they seem like they can help. 🤷🏼♂ If you want to try that approach, that would be cool.

Sure, but I think our coding signature in Pandas-TA is to keep everything in function level as you said before, and using protocol requires class anyways. So I'm wondering function is better than class in our case.

I will try and expand nb_ht_trendline to include the remaining ht_ indicators.

Thank you so much for this, as I'm really eager to learn how you'll do it.
My Suggestion
I think you should make another nb_ function named nb_ht_phasor, because the shared section between all ht_ indicators is inside ht_phasor functionality. The period calculation section we talked about it earlier, period = (0.2*period) + (0.8 * tempReal), is the last thing done inside ht_phasor.
Inside of nb_ht_phasor function, you should include line 34 to line 67 of our nb_ht_trendline implementation.
This way we can simply use nb_ht_phasor inside all other ht_ indicator implementations and be DRY.
And if you want to implement sth like my suggestion, please let me do that, so you might have more free time for your other tasks.

Damn! I checked stripe and they don't support crypto there either. 😑 And I almost never use crypto. I'll look more into it when I can.

Don't worry about it, your attention and your trial is so much valuable for me.
Best Regards,
Ali Gheshlaghi


Remove Hyper-V as a hard dependency

Remove Hyper-V as a hard dependency
This patch includes an updated version of the OVS installer on Windows.
This patch also provides updates to the ansible playbooks to accommodate
for a non Hyper-V enabled host.
This patch also includes fixes and updates to the ansible playbooks.
Signed-off-by: Alin Gabriel Serdean<EMAIL_ADDRESS>Signed-off-by: Alin-Gheorghe Balutoiu<EMAIL_ADDRESS>Co-authored-by: Alin-Gheorghe Balutoiu<EMAIL_ADDRESS>

Added some comments to the PR.
I tested on Windows Server 1803 (buildnumber 17134 and all the updates installed) and encountered the following issues:

it looks like HNS doesn't report that the extension is enabled even though it is actually enabled and running

@{Id=583cc151-73ec-4a6a-8b47-578297ad7623; IsEnabled=False; Name=Cloudbase Open vSwitch Extension},

this makes the call to Get-OVSEnabledHNSNetworks to fail since it won't find any HNS network that has the extension enabled. Changed the definition of Get-OVSEnabledHNSNetworks to return the HNS network without checking if extension is enabled allowed it to work. Note: it seems that not even restart fixes the issue and it still shows extension is disabled after restart.

can you also change this check? https://github.com/openvswitch/ovn-kubernetes/blob/master/contrib/roles/windows/kubernetes/tasks/main.yml#L41
otherwise it will always run setup_ovs_docker on every playbook run. You should check if the bridge is created and skip the task, or even when: transparent_inspect.rc != 0 should work fine as well

@rajatchopra , @alinbalutoiu I updated the PR and tested on 1709 and also 1803. Can you please test it out?

After a marathon session, Alin helped me get a cluster up and running with this PR. Thanks @aserdean .
This PR lgtm. Ready for merge, pending the branch name change.
The other issue of finding the default interface for docker network setup will dealt with separately.

@alinbalutoiu, @rajatchopra thanks a lot for trying and testing this PR.
I addressed all of the comments and updated the commit message, can you please take a final look?
Also thanks a lot @ionutbalutoiu for hosting the new installer until we get a signed version.

/lgtm
tested ok.


Focus-mode-docs-bash

Remained issues:

Overview of DevTools
devtools-intro-menu-bar.msft.png needs to be updated
Console features reference
Some pics cannot be found and already marked in Excel sheet
Network issues guide
Pics cannot be found and already marked in Excel sheet

Docs Build status updates of commit 85cefe2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/about-tools.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/all-default-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/all-optional-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/command-menu-panel-vs-drawer-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-command-menu-show-console.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-dom-level-multiple.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-dom-level-top.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-elements-console-drawer-hello-world.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-filter-regex.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-filter-text.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-filter-text-autofilter-history.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-filter-text-specified.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-hello-console.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-autocomplete.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-automatic-lineindent.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-console-history.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-eager-evaluation.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-filtered-with-table.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-multiline.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-several-expressions.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-top-level-await.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-log-level-default-levels.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-negative-filter-text.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-settings-group-similar-empty.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-sidebar-drawer-empty.msft.png
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 85cefe2:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit 85cefe29ab0a68fcfc8675429c4f585e26184fac in branch user/ms_yancheng/focus-mode of repository https://github.com/MicrosoftDocs/edge-developer into branch focus-mode-docs-bash (commit bd57897895f0e1f4e237046a07dbab7e4b343706). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Thanks @imicy. I noticed your PR was targeting main, so I changed it to target focus-mode-docs-bash, since that is the branch we are using to collect all of the new screenshots.
This led to some conflicts though, so we'll have to resolve those before we can merge.

Docs Build status updates of commit afc985e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: CannotMergeCommit] Cannot merge commit afc985ef2e1c5a7dabe0e2dfb750d07c980c5cef in branch user/ms_yancheng/focus-mode of repository https://github.com/MicrosoftDocs/edge-developer into branch focus-mode-docs-bash (commit bd57897895f0e1f4e237046a07dbab7e4b343706). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5679c56:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/console/index.md
:warning:Warning
View
Details

microsoft-edge/devtools-guide-chromium/about-tools.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/console/reference.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/all-default-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/all-optional-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/command-menu-panel-vs-drawer-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-command-menu-show-console.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-dom-level-multiple.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-dom-level-top.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-elements-console-drawer-hello-world.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-filter-regex.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-filter-text.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-filter-text-autofilter-history.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-filter-text-specified.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-hello-console.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-intro-eager-evaluation.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-intro-several-expressions.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-intrro-autocomplete.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-autocomplete.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-automatic-lineindent.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-console-history.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-eager-evaluation.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-filtered-with-table.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-multiline.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-several-expressions.msft.png
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.

microsoft-edge/devtools-guide-chromium/console/index.md

Line 172, Column 1: [Warning: file-not-found - See documentation] Invalid file link: '../media/console-intro-autocomplete.msft.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

I resolved the conflicts by duplicating the images that were used in 2 different articles. We don't want to share images among articles, as it makes maintaining the articles harder and sometimes leads to inconsistencies in the docs.

Docs Build status updates of commit df3979f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/console/index.md
:warning:Warning
View
Details

microsoft-edge/devtools-guide-chromium/about-tools.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/console/reference.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/all-default-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/all-optional-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/command-menu-panel-vs-drawer-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-command-menu-show-console.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-dom-level-multiple.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-dom-level-top.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-elements-console-drawer-hello-world.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-filter-text-autofilter-history.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-filter-text-specified.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-hello-console.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-intro-eager-evaluation.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-intro-several-expressions.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-intrro-autocomplete.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-autocomplete.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-automatic-lineindent.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-console-history.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-eager-evaluation.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-filtered-with-table.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-multiline.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-several-expressions.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-top-level-await.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-log-level-default-levels.msft.png
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.

microsoft-edge/devtools-guide-chromium/console/index.md

Line 172, Column 1: [Warning: file-not-found - See documentation] Invalid file link: '../media/console-intro-autocomplete.msft.png'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 088cb4e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/devtools-guide-chromium/about-tools.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/console/index.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/console/reference.md
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/all-default-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/all-optional-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/command-menu-panel-vs-drawer-tools.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-command-menu-show-console.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-dom-level-multiple.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-dom-level-top.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-elements-console-drawer-hello-world.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-filter-text-autofilter-history.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-filter-text-specified.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-hello-console.msft.png
:white_check_mark:Succeeded

microsoft-edge/devtools-guide-chromium/media/console-intro-autocomplete.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-intro-eager-evaluation.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-intro-several-expressions.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-autocomplete.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-automatic-lineindent.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-console-history.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-eager-evaluation.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-filtered-with-table.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-multiline.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-several-expressions.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-javascript-top-level-await.msft.png
:white_check_mark:Succeeded
View

microsoft-edge/devtools-guide-chromium/media/console-log-level-default-levels.msft.png
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Ability to disable event sources

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
NONE
What this PR does / why we need it:
This PR introduces a flag for the Falco CLI, --disable-source=(syscall|k8s_audit).
It modifies the Falco behaviour accordingly (ie., the way it open the inspector).
Which issue(s) this PR fixes:
Fixes #730
Refs #725
Special notes for your reviewer:
The --disable-source flag accepts only the following values: syscall, k8s_audit. Other values are detected and discarded.
This flag can be specified multiple times (for future need).
Nevertheless the user can not disable syscall and k8s_audit event sources at the same time.
Does this PR introduce a user-facing change?:
add flags to disable `syscall` event source or `k8s_audit` event source

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: leodido
If they are not already assigned, you can assign the PR to them by writing /assign @leodido in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @fntlnz

LGTM label has been added.  Git tree hash: 4a4da1b91eaf36838874ba958dd6b8a80b6d7b83

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fntlnz
If they are not already assigned, you can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: d86b7774b04dca3506a598cbf0002a086172e32e

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fntlnz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [fntlnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add dnspython to requirements.txt

Hi,
I had to install the dnspython package in addition to the dependencies listed in requirements.txt.
You might want to add it to the requirements.txt.
Regards,
gehaxelt

Hey! Thanks for letting me know. Updating the requirements.txt file now.


Investigate LSC dataset

Investigate the format and content of metadata as well as sample visual data.

This is urgent in order to derive a concept on how the LSC data are modelled


mime type error

hekto uses plain text for every file type except html

added correct mime type for css


feat(default_ad_api): add vehicle info api

Description
Add vehicle dimension API.
Related links

Tests performed
ros2 service call /api/vehicle/info/dimensions autoware_adapi_v1_msgs/srv/GetVehicleDimensions
Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi Is the usecase for this API shared somewhere?
I feel uncomfortable adding new APIs without knowing how it is going to be used.

@isamu-takagi Is the usecase for this API shared somewhere?
I feel uncomfortable adding new APIs without knowing how it is going to be used.

The use cases are added in https://github.com/autowarefoundation/autoware-documentation/pull/381.


[alternative] device: rework how we do struct device extern's

This is an alternative to https://github.com/zephyrproject-rtos/zephyr/pull/47798.
Instead of introducing a new magic "DEVICE_ORD_MACRO" that callers have to override, we here add some new devicetree.h machinery for iterating over all the nodes in the tree.
That lets us replace device_extern.h with a foreach call in device.h in a way that should generalize anogously to emulators, without any tricky redefinitions.

Twister errors look unrelated, but I found a typo in a comment, so I rebased and fixed it to see if this goes green now.

Rebased again and addressed comments. Networking related CI failures continue to appear unrelated.

@stephanosio @rlubos any idea what's going on with the failing TCP tests here? I can't reproduce the failures locally and they all seem timing related, so I doubt they are caused by this PR.

@stephanosio @rlubos any idea what's going on with the failing TCP tests here? I can't reproduce the failures locally and they all seem timing related, so I doubt they are caused by this PR.

The socket failures indeed seems to be timing related, I recall that mps2_an385 already had timing problems in the past (the select suite) and the timeouts were loosened already. I suggest to rerun the tests, and if the problem persists to loosen the timings even further.

Added DNM while I'm poking around with various fudge factors

The last CI run with adjusted fudge factors passed, so I've cleaned up the patches touching the unrelated tests and removed DNM.
@andyross can you please check tests: kernel: common: adjust fudge factors is not doing anything egregious?
@rlubos similarly can you give me an ACK on tests: net: socket: adjust fudge factors? I followed your advice to loosen the timings.


build snowplow for neon

oops! sorry, meant to make this in my fork, not back upstream!

No worries!