[STORM-1007] Added tuple arrival rate and tuple sojourn time to QueueMetrics

I added two important metrics, namely arrival time and sojourn time, to QueueMetrics.
Modification Summary:

Created a new RateTracker utility, which could report instantaneous rate upon certain event;
Added test cases for RateTracker;
Added arrival rate and sojourn time metrics to QueueMetrics;
Use sampling in QueueMetrics to reduce the metric maintenance cost.

Such metrics are very useful to performance tuning, especially for application with strong constraint on processing latency such as threat detection and smart traffic. A high sojourn time, for example, indicates that a higher degree of parallelism should be applied to the current bolt in order to reduce processing delay.
Any comment or suggestion regarding to this pull request is welcomed.
Thanks.

Great work. Since it can affect performance I recommend you to include benchmark test result.
You can refer https://github.com/apache/storm/pull/521#issuecomment-106038982 to how to do it.

Hi @HeartSaVioR,
Thank you for your comment. I understand your concern, as DisruptorQueue plays an important role in Storm.
Following your suggestion, I have done performance test using [https://github.com/yahoo/storm-perf-test]. As expected, the results show that the new metrics do not introduce noticeable overhead.
Environment:

Factors
Configurations

CPU
Intel(R) Xeon(R) CPU E5-1620 v3 @ 3.50GHz

RAM
16GB

DISK
2TB

OS
Ubuntu 14.02

Parameters:
--bolt 3 --name test -l 1 -n 1 --workers 4 --spout 3 --testTimeSec 900 -c topology.max.spout.pending=1092 --messageSize 10

Result summary:
master at 154e9ec55deb4eea8fca8554e4d3b224bf337834:
Throughput in MB/s
AVG: 7.974807415
MIN : 7.878930664
MAX: 8.095523041
PR at f15ac94d259a96ac891f5243af29b0d953ea863d:
Throughput in MB/s
AVG: 7.977237486
MIN : 7.844562531
MAX: 8.251005809
=======================================================
The details of runs at master(154e9ec55deb4eea8fca8554e4d3b224bf337834)
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24470400	7.878930664
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24962680	7.935422262
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24765960	7.972886658
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24576620	7.982697093
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24901860	7.916088104
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25191040	8.008015951
RUNNING	1	4	4	6	6<PHONE_NUMBER>501 	30001	24791180	7.880641192
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	29999	25126800	7.987860867
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25071180	7.969913483
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25098540	7.978610992
RUNNING	1	4	4	6	6<PHONE_NUMBER>501 	30001	24966120	7.996251266
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	29999	24836340	8.095523041
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25004480	7.968710124
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25371360	8.065338135
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24972160	7.938435872
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25382020	8.068726858
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25021280	7.9540507
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25011120	7.950820923
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24690680	7.94895579
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24954060	7.972682037
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24899040	7.98519165
RUNNING	1	4	4	6	6<PHONE_NUMBER>501 	30001	24737460	7.963564633
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	29999	24996060	7.946298354
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24986100	7.942867279
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	24906920	7.997696635
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25041520	7.960484823
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25121880	7.986030579
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25126380	7.98746109
RUNNING	1	4	4	6	6<PHONE_NUMBER>500 	30000	25043860	7.981228689
RUNNING	1	4	4	6	6<PHONE_NUMBER>501 	30001	24923920	8.022836695
RUNNING	1	4	4	6	6<PHONE_NUMBER>080 	30000	24357580	7.974807415
RUNNING	1	4	4	6	6<PHONE_NUMBER>080 	30000	24497360	7.878930664

The details of runs at this PR(f15ac94d259a96ac891f5243af29b0d953ea863d)
RUNNING	1	4	4	6	6<PHONE_NUMBER>792 	30001	25703700	8.170713818
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	29999	25916500	8.238908104
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	25955420	8.251005809
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	25774120	8.193372091
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	25701440	8.170267741
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	25872800	8.224741618
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	25357260	8.060855865
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24899640	7.915382385
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	25170260	8.001410166
RUNNING	1	4	4	6	6<PHONE_NUMBER>792 	30001	25220280	8.017043861
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	29999	24963440	7.93592839
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24913380	7.919750214
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24676860	7.844562531
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	25074360	7.970924377
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24991800	7.94467926
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24966800	7.936731974
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24789820	7.880471547
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24931320	7.925453186
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24845840	7.898279826
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24802200	7.884407043
RUNNING	1	4	4	6	6<PHONE_NUMBER>792 	30001	24923140	7.922588748
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	29999	24936560	7.927383183
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24810660	7.887096405
RUNNING	1	4	4	6	6<PHONE_NUMBER>792 	30001	25181340	8.004665581
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	29999	24692140	7.849681568
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24900600	7.915687561
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24762280	7.871716817
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24952080	7.932052612
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24917080	7.920926412
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	25054500	7.964611053
RUNNING	1	4	4	6	6<PHONE_NUMBER>791 	30000	24871820	7.906538645

Please let me know, if you have any question regarding to this tests or this PR.
Thanks
Li Wang

@wangli1426
Great.
One thing which blocks me voting +1 is that I can't understand how RateTracker works.
Could you explain how it works?

Hi @HeartSaVioR,
I am glad to explain the mechanism of RateTracker as follows.
In general, RateTracker provides a way to monitor the rate of certain event. We notify RateTracker upon the occurrence of the event by calling notify() method, and call reportRate to retrieve the instantaneous rate of the event.
The rate is calculated as counts of occurrence /  time. As RateTracker reports instantaneous rate, it only maintains the counts of occurrences within a given period of time as specified by validTimeWindowInMils. This is implemented by dividing the  validTimeWindowInMils into numOfSlides time slides and employing a timer to periodically (every validTimeWindowInMils/ numOfSlides milliseconds) clean the count in the oldest time slide.
Finally, RateTracker is very efficient. First, notify() only does addition on a count and thus can be finished within few CPU cycles. Second, the update of the counts is also light-weight and only happens periodically, e.g., every 1 or 2 seconds. Third, all the instances of RateTracker share the same timer, avoiding using too many threads.
If you have further question, please let me know.
Thanks.

+1
Thanks for providing great feature and benchmark result.

@HeartSaVioR
Thanks for voting +1.
By the way, in my original design, I didn't use timer to update the histograms. Instant, the histograms were updated in notify(). However, such a design requires to call System.currentTimeMills() every time when notify() is called, to determine whether an update to the histograms is needed. System.currentTimeMills() is fairly expensive to be called so frequently. So, in current implementation, I use a timer to periodically update the histograms.

@HeartSaVioR
Sorry to interrupt, but may I ask when this PR could be merged? I am planing to display the new metrics on the web UI, if this PR gets merged. Thanks.

@wangli1426 Sorry for the delay. I intended to wait for other committers to review, but since no one is reviewing I'll merge right now.


[AMBARI-25227] Unable to move Hive metastore from one node to another

What changes were proposed in this pull request?
While moving Hive Metastore from one node to another, it is failing at test DB connection step in configure Component page.Seeing following error in ambari-agent logs:
19-03-22 11:15:38,527 - DB connection check started.
2019-03-22 11:15:38,527 - There was an unknown error while checking database connectivity: Configuration parameter 'db_name' was not found in configurations dictionary!
Traceback (most recent call last):
  File "/var/lib/ambari-agent/cache/custom_actions/scripts/check_host.py", line 145, in actionexecute
    db_connection_check_structured_output = self.execute_db_connection_check(config, tmp_dir)
  File "/var/lib/ambari-agent/cache/custom_actions/scripts/check_host.py", line 281, in execute_db_connection_check
    if db_name == DB_MYSQL:
  File "/usr/lib/ambari-agent/lib/resource_management/libraries/script/config_dictionary.py", line 73, in __getattr__
    raise Fail("Configuration parameter '" + self.name + "' was not found in configurations dictionary!")
Fail: Configuration parameter 'db_name' was not found in configurations dictionary!
2019-03-22 11:15:38,528 - Host checks completed.
2019-03-22 11:15:38,529 - Check db_connection_check was unsuccessful. Exit code: 1. Message: Configuration parameter 'db_name' was not found in configurations dictionary!

Command failed after 1 tries

How was this patch tested?
Tested manually

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5083/
Test PASSed.


set verifier_type of rats_tls_conf_t to nullverifier

When AA works in eaa_kbc mode, it is an attester but not a verifier.  While the current implementation uses the default config, that is the highest priority settings "sgx_ecdsa_qve". The verifier_type of rats_tls_conf_t should be set to nullverifier explicitly, otherwise the remote attestation with verdictd fails.

@xhuan28 Could you please make the commit log clearer and more concise? They look a little messy now :)

@fitzthum This parameter does not mean that verdictd will no longer verify the evidence, but specifies that AA will not verify the dummy "evidence" sent by verdictd. It is because the working mode of the component rats-tls that AA depends on. Rats-TLS will enable two-way authentication by default. In our scenario, only verdictd is required to verify AA, and AA is not required to verify verdictd.
@xhuan28 n my test, AA does not need to explicitly specify the nullverifier parameter. You only need to start the verdictd in the following way to establish the link normally:
verdictd  --listen <IP_ADDRESS>:30000 --mutual

@xhuan28 This problem can be solved through rational configuration of rats-tls, so this PR can be closed.

@xhuan28 This problem can be solved through rational configuration of rats-tls, so this PR can be closed.


How to generate t2_ft.txt file?

I'm trying to use my custom dataset. I only found the .py files that generate t*_train and t*_test, but I don’t know how to get the t*_ft.txt files. Could you help me with it, @JosephKJ ?
Thanks a lot!

I found it! But what does all_task_val.txt include?
Thanks!

兄弟加个微信，一块研究～


update declaration file to use intrinsic object type

Follow #12501, update declaration files to use intrinsic object type.
Only methods unconditionally throwing runtime TypeError are patched. For example, Object.keys invoked with primitive type will only throw TypeError in ES5. If we patch such methods, we will break partially ES6 compatible client.

@RyanCavanaugh can you take a look.

@HerringtonDarkholme Can you also update declarations in the lib directory?

Looks right to me

@falsandtru I think the lib directory will be automatically updated in next release. So no need to update in this pull request.

Oh, I don't know that automation, thanks.

I just want to note that this breaks the @types/lodash package. It seems like a bad move on the part of the lodash typings to include standard node library definitions... but they probably have good reasons.


OHAI-325

See ticket for details.

So I'm using @ctennis's ohai-325 branch and it works perfect for me.
Otherwise any arch user who is fully up to date can't use ohai right now.
This is a frustrating one, thanks ctennis.

Merged to master, thanks!


inproc vs. inshell: rsync: Failed to exec ssh -i: No such file or directory

Is it possible to use inproc instead of inshell in this case?
>>> import qualified Turtle as Tt

fails:
>>> Tt.view $ Tt.inproc  "rsync" ["--archive", "-e", "'ssh -i /home/xxx/.ssh/key'", "srcfile", "server:"] mempty
rsync: Failed to exec ssh -i /home/damien/.ssh/perso-backups: No such file or directory (2)
rsync error: error in IPC code (code 14) at pipe.c(85) [sender=3.1.2]
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: error in IPC code (code 14) at io.c(235) [sender=3.1.2]
*** Exception: ExitFailure 14

success:
Tt.view $ Tt.inshell  "rsync --archive -e 'ssh -i /home/xxx/.ssh/key' srcfile server: " mempty

Great!
Thank you for the detailed answer!

 :)
I'll go ahead and close this, then


Opaque pointers in LLVM backend

The LLVM backend should be updated to use opaque pointers.
However, an implementation would depend on LLVM 15 which is fairly recent and not yet updated on most linux distributions, so we might want to wait with this for now.

We do not have many users :) If it works for all of our contributors -- mostly @phischu, @marzipankaiser, @jiribenes, @JonathanStarup, you and me (and the CI) it is fine to go ahead. All other contributors could disable the LLVM tests locally, I guess.

Brew only goes up to version 14, if I am not mistaken. So maybe you can prepare it and we wait for brew and the linux distributions?

Oh wait, no...
https://formulae.brew.sh/formula/llvm

Also known as: llvm@15

https://github.com/effekt-lang/effekt/blob/3aaa33b74f8b39085d46ee8c0bb5b59d65224461/effekt/jvm/src/main/scala/effekt/EffektConfig.scala#L51
I've noticed that the "default" LLVM version in EffektConfig hasn't been updated to 15.
(This broke my build 😅)


Revert "Add support for kueue component whihc got added in 2.7"

Reverts red-hat-data-services/ods-ci#1183 ..reverting the patch beacue kueue will be removed in 2.7
https://issues.redhat.com/browse/RHOAIENG-3234

Thank you, Tarun. I merged this now so we're aligned on all places :slightly_smiling_face:


Get instance of Storybook running locally with RS website

Problem statement
In essence, Storybook is a showcase of all the coded-version of of our design components. For Design (note the capital D) to work well with engineering, they require "building blocks" so they don't have to redesign the wheel every time they create a new feature, do a bug bash or polish something. Currently we have no established component library or styleguide from an Engineering perspective that Design can work with which means they have to shoot-in-the-dark as to what is already coded and what is not. This greatly affects how well we can estimate things going forwards.
Context
Here is a link to our Figma "Master Components" page (which is incomplete) but a good reference point of what we'd want to mirror in our Storybook instance.
We'd also want to implement full page mocks of some of our main pages, like the homepage, unauthenticated and authenticated, different states of components like banners and modals.
Some excellent examples of living Storybooks for inspiration:

The Guardian's Storybook Instance
The BBC's Storybook Instance

Acceptance criteria

[ ] All Styleguide items included in Storybook local instance
[ ] All Components items included in Storybook local instance

Caveat: all of the below very intentionally MUST include not just our customized resources, but anything we use from USWDS and beyond. Design, and anyone else looking at our Storbook, need to know EVERYTHING we're potentially working with.
Styleguide
This would be an overview of the fundamental building blocks of our site that would include:

Colors
Typography
Spacing and Formatting
Icons

Components
This would be an extensive overview of all the components in use across our site, from base USWDS modals and how we implement them, to customized table components:

Table
Modal
Link
Checkbox
Label
Textinput
Dropdown
Accordion
Button
DateRangePicker
Tooltip
Alert
Form
Banner
Title

This list is not-exhaustive
Add Ons
We may want to explore a few add-ons to our Storybook that would be extremely useful including:
Accessibility: evaluates the ally accessibility of our Storybook components and what levels of compliance they are in.
Figma Designs: a plugin that allows us to easily embed Figma designs within Storybook.

@etanb We chatted about this before, but what do you think about making this ticket just about getting an instance of Storybook running locally with an example story or two?  I think the notes you added here are excellent, but they touch on longer-term items whereas I intended this ticket to just be the initial configuration for getting Storybook included in ReportStream.

@etanb Heads up: I moved the description you added here to the Storybook epic since it outlines more of an overarching approach rather than an individual ticket.  Also for transparency, I'm going to assign myself to this ticket since I pushed up a quick local configuration pull request last week.

Not deployable. Done and can be closed.


Fix dropdown button toggle misalignment on chrome

Fixes #182
change-type: patch

@thgreasi What browser / OS were you using?

@LucianBuzzo I should have written "didn't work on Chrome 62 on ubuntu 16.04" sorry

@thgreasi good call on vertical-align: top it works a treat!


plhashmap tests

changelist: #21 add unit tests

@maxinteger I created PR #24 with a clean history.


Fixed spelling and wording

Just a bunch of spelling and wording fixes to make it a bit easier to read.

Many thanks!
I really appreciate your help, it's not so easy for me as non native speaker to write correct documentation.

Happy to help. If I find any other wording issues as I read through the other documentation, I'll submit fixes for those as well. It's really nice to see such extensive documentation!


JBPM-5666: fix misleading warning when registering queries on kie-sever

good catch @jhrcek, thanks


[maven] Automatically use settings.xml

Currently, cdxgen prompts the user to set the MVN_ARGS when a settings.xml is found. Instead, it could automatically pass the -s argument to the mvn command.
https://github.com/CycloneDX/cdxgen/blob/c9ac5c3255ba2d00fbb138bc6c0d7521e736f7e0/index.js#L1237

how can we fix this issue?

@scchaitha There are couple of options.
Option 1. Use the new native maven strategy - Set the environment variable PREFER_MAVEN_DEPS_TREE=true. This will automatically use the settings.xml correctly.
Option 2. Manually set the environment variable `MVN_ARGS="-s full path to settings.xml"
Option 1 is recommended since it will work correctly for even multi-module projects.
Note: The last argument to cdxgen is the directory name.
export PREFER_MAVEN_DEPS_TREE=true
cdxgen -t java -o bom.json .


Request: hotkey for Hide Game

I think this software is terrific! I am using it to play FF14 while learning Japanese and it's transformed my learning :)
One small feature request: Can we get a hotkey for Hide Game? This would make things much more convenient for my setup.

Okay. I will keep in mind for the next update.


Add support for 'branchingLogic' on 'sub_settings'

The 'branchingLogic' setting option currently only works on top level settings.  It has no affect on 'sub_settings'.

Created a PR to fix it - #98.

@mmcev106 here is a PR to update docs - https://github.com/vanderbilt/redcap-external-modules/pull/101.


CHANGING THE FOOTER

I WILL CHANGE THE FOOTER IN ORGANISED WAY. CAN U ASSIGN ME

I also want to add some features.Can u assign me this

Closed via #173


Messages not being sent to IRC

Discord and minecraft messages are no longer sent to IRC

Implemented in commit aab9eac6d9612f21cfdcef6b06630b1c2fa23631


Setup package exports for API consumers and docs

Running yarn typedoc src/index.ts gives some warnings, mostly due to exports for the package not being properly setup.
[warning] Inst, defined in ./src/evm/expr.ts, is referenced by Stmt but not included in the documentation.
[warning] EVM, defined in ./src/evm/index.ts, is referenced by Contract.evm but not included in the documentation.
[warning] Expr, defined in ./src/evm/expr.ts, is referenced by If.condition but not included in the documentation.
[warning] Revert, defined in ./src/evm/system.ts, is referenced by isRevertBlock.isRevertBlock but not included in the documentation.
[warning] Metadata, defined in ./src/metadata.ts, is referenced by Contract.metadata.metadata but not included in the documentation.
[warning] State, defined in ./src/state.ts, is referenced by build.build.state but not included in the documentation.
[warning] Type, defined in ./src/evm/expr.ts, is referenced by PublicFunction.patchCallDataLoad.patchCallDataLoad.paramTypes but not included in the documentation.
[warning] Return, defined in ./src/evm/system.ts, is referenced by PublicFunction.isGetter.isGetter.__type.stmts but not included in the documentation.
[warning] SLoad, defined in ./src/evm/storage.ts, is referenced by PublicFunction.isGetter.isGetter.__type.stmts.__type.args but not included in the documentation.
[warning] MappingLoad, defined in ./src/evm/storage.ts, is referenced by PublicFunction.isMappingGetter.isMappingGetter.__type.stmts.__type.args but not included in the documentation.
[warning] Val, defined in ./src/evm/expr.ts, is referenced by PublicFunction.isGetter.isGetter.__type.stmts.__type.args.__type.location but not included in the documentation.
[info] Documentation generated at ./docs

Done.


Return zero if no datapoints

Hello!
Is there any options to return zero or null to grafana if there is no datapoints in timerange?

Hi!
The feature suggested above is the one I need too. Is there any way to enable this behaviour? I can't see explanation why this issue is closed.


cmd/compile: unnecessary error reports

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.9.2 linux/amd64
Does this issue reproduce with the latest release?
yes
What did you do?
package main

func main() {
	var c chan bool

	select {
	default:
		goto A // label A not defined
		A:     // syntax error: missing statement after label
	case <-c:
		goto B // ok
		B:     // ok
	}

	select {
	default:
	{
		goto C // ok
		C:     // ok
	}
	case <-c:
		goto D // ok
		D:     // ok
	}

	select {
	case <-c:
		goto X // label X not defined
		X:     // syntax error: missing statement after label
	default:
		goto Y // ok
		Y:     // ok
	}

	select {
	case <-c:
	{
		goto W // ok
		W:     // ok
	}
	default:
		goto Z // ok
		Z:     // ok
	}
}

same for cases in switch.

What did you expect to see?
No errors are reported.
What did you see instead?
vet: main.go: main.go:10:2: expected statement, found 'case' (and 1 more errors)
vet: no files checked
exit status 1

CC @griesemer @mdempsky

Is this a compiler or vet issue? It's not clear from your description. Please describe exactly what you did. (Your "What did you do"? report just shows some code).
FWIW, I get
./x.go:9:4: syntax error: missing statement after label
./x.go:29:4: syntax error: missing statement after label

as the only errors with cmd/compile or go vet.
Please clarify.

I can recreate the problem with the Go 1.9 cmd/vet.  But it's fixed on tip.
Thanks for the report, but since it's been fixed I'm going to close this.  I don't think this is important enough to backport to 1.9.

@griesemer
yes, I forgot to attach the compiler errors too. It is both a bug of the compiler and vet.
@ianlancetaylor
glad to know it is fixed.

@ianlancetaylor
I just update the tip and rebuilt it.
But I found the errors are still reported.
The go version shows
go version devel +79f6c280b8 Tue Nov 7 22:06:35 2017 +0000 linux/amd64

@dotaheor Please describe your exact steps (compiler, go vet invocation) and errors you see.

main.go:
package main

func main() {
	var c chan bool

	select {
	case <-c:
	{
		goto A
		A: // ok
	}
	case <-c:
		goto B
		B: // syntax error: missing statement after label
	case <-c:
		goto C
		C: // ok
	}
}

'~/go/src/github.com/golang/go/bin/go build main.go`:
./main.go:14:4: syntax error: missing statement after label

"~/go/src/github.com/golang/go/bin/go build vet" is ok.

The error is correct according to the language spec, though the reason is a little complicated.  A label must always appear before a statement.  However, a statement may be a single semicolon, representing the empty statement.  And that semicolon may be omitted before a } character.  So that is what is happening for your labels A and C: a semicolon is omitted before the '}', and that omitted semicolon is the empty labeled statement.  For B no semicolon is omitted, there is no statement, and so you get a compiler error.

But why must there be at least one statement following a label?
I think there are really some reasonable uses like the second case.
Surely the second goto can be replaced with a break.
But in doing programming, for debug purpose, we may temperately
comment  off the statements following the the label B.
Forcing programmers to change the goto into a break back and forth is inconvenient.
From the implementation view, inserting a ; after label B is quite easy.

@dotaheor Well, now you are talking about a language change.  Perhaps it would be a straightforward change, I don't now.  Someone would have to work through all the possible issues and make a language change proposal.
For your purposes, you could simply write B:;.

OK, a quite good workaround.

@ianlancetaylor
but I can't find the rule in spec.

@dotaheor A labeled statement is simply a statement. A labeled statement may have an empty statement following the ":", and an empty statement is literally nothing.
But, all statements must be followed by a semicolon (*) because statements appear in statement lists.
It would be extremely irregular in the grammar to have some statements be followed by semicolons and not others. (*) Finally, independently, semicolons may be elided before a closing "}".
Altogether, this is what leads to the current behavior. You can be assured that this is not coincidental and has been carefully thought through. The rules are like they are to make a) the syntax regular (all statements must be followed by semicolons), and b) the case where a statement is immediately followed by a closing "}" of a block not overly onerous .
These rules are in the syntax of the spec, and in the prose.

PS: Most of the time a semicolon does not need to be written because of the semicolon insertion rule ( https://tip.golang.org/ref/spec#Semicolons ). This works out for pretty much all statements, but because empty statements have no tokens (they are empty), the token immediately before determines if a semicolon is inserted or not at the end of a line. In a labelled empty statement, that last token is ":", and ":" does not automatically cause a semicolon to be inserted at the end of a line.
If there was any change to be made, one could perhaps propose that a semicolon can be omitted before a "case" or "default" keyword as well, and then this would work out without error. But I am not recommending such a change; it doesn't seem worthwhile the additional complexity for a corner case that is rare.


Ispn 7865 Distributed Iterator Reactive Streams

https://issues.jboss.org/browse/ISPN-7865
The big new change is in ClusterStreamManager which now exposes a Publisher that will go through all available node targets one by one.
I also refactored a lot of code to utilize IntSet instead of Set to avoid boxing if possible (this still needs work after this PR).

There are still 2 things that need to be done

Need to add close iterator method for when an iterator is closed early: https://github.com/infinispan/infinispan/pull/5283/files#diff-6b3e6f1e0c88b946f09bf6b426491873R669
Need to update tests to use new ClusterStreamManagerImpl: https://github.com/infinispan/infinispan/pull/5283/files#diff-417ff1e82ad1429d18f0630a94a34751R74

This should be pretty much completed, barring rework comments. I hope someone can help complete this while I am gone :)

Unfortunately CI pukes later on [1], it passes core fine for me. My guess is because I am missing dependencies on the server parts, sorry! I am hoping just adding those in should fix these.
http://ci.infinispan.org/job/Infinispan/job/PR-5283/10/

Closed in favor of #5314


fix: broken imports of npm/github publish

Merging this PR will publish the following release:

2.0.5 (2017-12-07)
Bug Fixes

broken imports of npm/github publish (003d309)


Refactor GridRooms

Cache goal_pos for efficiency (see #93 )
Randomize agent starting position, agent starting direction, and goal position upon reset! (see #93 )
Remove grid_size and room_size as env fields.

Codecov Report

Merging #95 (668aacc) into master (22c949a) will decrease coverage by 1.60%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   80.16%   78.56%   -1.61%
==========================================
  Files          16       16
  Lines         706      667      -39
==========================================
- Hits          566      524      -42
- Misses        140      143       +3

Impacted Files
Coverage Δ

src/envs/gridrooms.jl
100.00% <100.00%> (ø)

src/abstract_grid_world.jl
62.12% <0.00%> (-1.65%)
:arrow_down:

src/objects.jl
35.00% <0.00%> (-1.59%)
:arrow_down:

src/envs/doorkey.jl
98.43% <0.00%> (-1.57%)
:arrow_down:

src/envs/dynamicobstacles.jl
97.29% <0.00%> (-1.46%)
:arrow_down:

src/envs/sequentialrooms.jl
97.93% <0.00%> (-1.17%)
:arrow_down:

src/grid_world_base.jl
87.75% <0.00%> (-0.71%)
:arrow_down:

src/GridWorlds.jl
100.00% <0.00%> (ø)

src/envs/utils.jl
100.00% <0.00%> (ø)

src/envs/gotodoor.jl
100.00% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22c949a...668aacc. Read the comment docs.


Pod asterisk & kamailio CrashLoopBackOff

Good afternoon!
Tell me what is my mistake.
POD kamailio CrashLoopBackOff: ERROR: bad config file (3 errors):
parse error in config file /data/kamailio/local.k, line 4, column 36: ip address, interface name or hostname expected
POD asterisk CrashLoopBackOff container config: ERROR failed to render defaults: template: t: 14: 25: executing "t" at <.Network>: error calling Network: invalid response
Tell me what is the problem?
Thank.

This sounds like the network detection is failing.  Under what environment (cloud provider or baremetal) are you running this kubernetes cluster?  What have you set for your CLOUD variable?

Thanks for the help.
The problem is caused by the creation of a private cluster.
Tell me how to fix it:
service exited: failed to reload asterisk modules: module res_pjsip.so failed to reload due bad authentication

Hi,
I'm facing the same issue. Kamalio container is failing with
0(1) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /data/kamailio/local.k, line 4, column 1-6: syntax error
0(1) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /data/kamailio/local.k, line 4, column 1-6: hostname expected
0(1) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /data/kamailio/local.k, line 4, column 11-16: syntax error
0(1) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /data/kamailio/local.k, line 4, column 11-16: ip address, interface name or hostname expected
0(1) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /data/kamailio/local.k, line 4, column 18-26:

I'm running kubernetes on premise with Rancher Kubernetes Engine (RKE).
@Ulexus Could you help me about the CLOUD variable you're speaking of ? I saw it is set to gcp by default but I have no idea what are the possible values neither I can find any documentation about it.
@atsip76 Could you explain to me what did you mean by

The problem is caused by the creation of a private cluster.

And what was the solution you came up with ?
Thanks.

You can find all the possible values of the CLOUD variable here: https://github.com/CyCoreSystems/netdiscover#supported-providers

Thank you. And what are the options in case I'm not using one of the cloud providers ? My Kubernetes cluster is setup on-premise (nodes are VM hosted on OVH).

Just set CLOUD=""  It will use a public service (jsonip.io, run by CyCore Systems) to determine the public IP information.

If you have more esoteric needs, you can also write your own generator for local.k, and I'd be happy to add support for OVH if I could make any sense of their documentation.

Thanks for your help ! Setting CLOUD="" solved this issue.
But I'm still having some problems to get my Asterisk instance running. To not polluate this closed  thread I've created another post at : https://github.com/CyCoreSystems/asterisk-k8s-demo/issues/15


Issue with CDD creation of multiple domains within a single deployment plan

Issue and tracking information
Our applications frequently require the ability to deploy the same components/code to various domains. We have a solution in CX where in the deployment plan, we can drag in a domain multiple times and assign multiple different sets of ip addresses and ports to create various CDDs that are equivalent in structure (same number of nodes and names of nodes) and differ only in the hostname:port specifications per node.
It doesn't look like this is working anymore. When I take our BPS example and copy in the domain again, the CDD that is created is using the new node names specified in the configure pane (probably to avoid name clashes), which mean that the deployment system cannot deploy components to the new nodes. In other words, if our CDP says that we deploy to "node1", we cannot deploy to a CDD that has "node1_2"
I am attaching a slightly modified BPS example model with the two domains in the deployment plan along with the CDDs that are created.
ExamplesDomain.cdd is the original CDD which is still generated correctly.
ExamplesxDomain_2.cdd has the incorrect node names in the file.
Developer's time Estimated effort to fix (hours):
BPS.zip
CDDs.zip
Developer's Actual time spent on fix (hours)
Issue reporter to provide a detailed description of the issue in the space below

After the investigation, I found out that this problem is introduced after fixing https://github.com/ZeligsoftDev/CX4CBDDS/issues/228. We allowed users to modify node names within the deployment plan rather than changing the node instance name from the domain. So I will set the default names of nodes to their node instance names when they are dragged onto the deployment.

Hmm, I see the problem. I think the end goal is this. We want the names of the nodes in the CDP and all CDDs generated to be that of the first domain in the deployment plan (i.e. the one that is set in the deploy side of the deployment plan). However, we still need the ability to have multiple domains in the configure pane, and the CDDs that generate from the extra domains must work with the single CDP generated from the deployment plan.

I think you just need to make sure that the node names are the same under all domains. For example, if you modified one of the node names from the deployment plan, then you also need to change the node names from other duplicated domains as well. Do you think this solution works??
The other solution is to go back to the code base before issue #228 so we use the node instance name to generate CDD but do not allow users to modify the node name within the deployment plan. In this case, all generated CDD will have exactly the same node names. You need to change the node instance name if you want to change the node name though.
How often do you need to change the node name within the deployment plan to generate a node name that is different than the actual node instance name?

Fix merged onto "papyrus" branch. I turned off the warning for duplicate names and set the default node name as its model element. If you change the node name from the deployment plan, you need to make sure to change the node names from other duplicate domains in the deployment. Please let me know if the solution is satisfactory.

This solution sounds good to me. I will build and verify it on my end, but first...
I agree with the onus being on the user to keep their node names in sync across other duplicate domains in the deployment plan. I do wonder if there is something CX could do to warn the user when this isn't the case. Basically, if the first domain has 4 nodes and some duplicate domain has different nodes, that duplicate domain will not work with the generated CDP file, so I would think it is at the very least a warning condition. Any thoughts?

No problem. I will throw a warning during validation if node names do not match among multiple domains in a deployment.

I guess we could close this ticket without adding a validation since issue #400 will solve this issue?

If #400 does solve this issue such that no user could create a CDD/CDP combo and have different node names between them, then I agree. Additionally, we would need #400  to be implemented relatively soon. If we think it may take a while, that is okay, but then we would want the validation.

Okay, I think we can ignore the validation warning at the moment since it would be a new feature, more-or-less.  I still want to verify this on my end before we close it out.

Sounds good. thanks.

This fix looks good to me, but we need the fix on the streams/v2.1.x-maintenance branch too


fix broken link in docs/README

@jiata,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Attempt to fix flaky gRPC test

may fix #1372

:broken_heart: Build Failed

Expand to view the summary

Build stats

Build Cause: [Pull request #1373 opened]

Start Time: 2020-09-01T06:56:45.609+0000

Duration: 6 min 10 sec

Steps errors
Expand to view the steps failures

Name: Shell Script

Description:  java.nio.ByteBuffer.position(int)
[2020-09-01T07:01:58.989Z] [INFO]
[2020-09-01T07:01:58.989Z] [

Duration: 3 min 54 sec

Start Time: 2020-09-01T06:59:57.196+0000

log

Log output
Expand to view the last 100 lines of log output

[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-redis-common .................... SUCCESS [  0.667 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-jedis-plugin .................... SUCCESS [  0.707 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-lettuce-plugin .................. SUCCESS [  5.051 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-redisson-plugin ................. SUCCESS [  1.631 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-jms-plugin ...................... SUCCESS [  3.373 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-jmx-plugin ...................... SUCCESS [  0.769 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-jsf-plugin ...................... SUCCESS [  0.703 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin ......... SUCCESS [  0.378 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin-common .. SUCCESS [  0.610 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin-5_x ..... SUCCESS [  2.603 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-hibernate-search-plugin-6_x ..... SUCCESS [  2.073 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-es-restclient-plugin ............ SUCCESS [  0.369 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-common ..... SUCCESS [  1.040 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-5_6 ........ SUCCESS [  2.025 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-6_4 ........ SUCCESS [  2.226 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-grpc ............................ SUCCESS [  1.508 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-grpc-plugin ..................... SUCCESS [  1.840 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-kafka-plugin .................... SUCCESS [  0.756 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-kafka-base-plugin ............... SUCCESS [  0.994 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-kafka-headers-plugin ............ SUCCESS [  1.342 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-mongoclient-plugin .............. SUCCESS [  7.021 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-okhttp-plugin ................... SUCCESS [  0.821 s]
[2020-09-01T07:02:51.368Z] [INFO] co.elastic.apm:apm-opentracing-plugin .............. SUCCESS [  0.674 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-profiling-plugin ................ SUCCESS [  1.570 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-servlet-plugin .................. SUCCESS [  1.251 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-log-correlation-plugin .......... SUCCESS [  0.829 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-micrometer-plugin ............... SUCCESS [  0.919 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-log-shipper-plugin .............. SUCCESS [  0.801 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-spring-resttemplate-plugin ...... SUCCESS [  1.061 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-spring-webmvc-plugin ............ SUCCESS [  4.420 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-urlconnection-plugin ............ SUCCESS [  0.674 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-scheduled-annotation-plugin ..... SUCCESS [  0.626 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-quartz-job-plugin ............... SUCCESS [  1.026 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-process-plugin .................. SUCCESS [  0.706 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-dubbo-plugin .................... SUCCESS [  2.589 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-scala-concurrent-plugin ......... SUCCESS [ 20.757 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:elastic-apm-agent ................... SUCCESS [ 12.193 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-agent-benchmarks ................ FAILURE [  4.306 s]
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-es-restclient-plugin-7_1 ........ SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-jedis-2-tests ................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-jedis-3-tests ................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-lettuce-3-tests ................. SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-grpc-test-1.6.1 ................. SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-opentracing ..................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:integration-tests ................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:simple-webapp ....................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:jsf-app ............................. SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:jsf-app-dependent ................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:jsf-app-standalone .................. SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:cdi-app ............................. SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:cdi-app-dependent ................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:cdi-app-standalone .................. SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:soap-test ........................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:apm-agent-attach .................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:application-server-integration-tests  SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:spring-boot-1-5 ..................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:spring-boot-2 ....................... SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:spring-boot-2-base .................. SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:spring-boot-2-jetty ................. SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:spring-boot-2-tomcat ................ SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:spring-boot-2-undertow .............. SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] co.elastic.apm:external-plugin-test ................ SKIPPED
[2020-09-01T07:02:51.369Z] [INFO] ------------------------------------------------------------------------
[2020-09-01T07:02:51.369Z] [INFO] BUILD FAILURE
[2020-09-01T07:02:51.369Z] [INFO] ------------------------------------------------------------------------
[2020-09-01T07:02:51.369Z] [INFO] Total time:  02:51 min
[2020-09-01T07:02:51.369Z] [INFO] Finished at: 2020-09-01T07:02:51Z
[2020-09-01T07:02:51.369Z] [INFO] ------------------------------------------------------------------------
[2020-09-01T07:02:51.369Z] [ERROR] Failed to execute goal on project apm-agent-benchmarks: Could not resolve dependencies for project co.elastic.apm:apm-agent-benchmarks:jar:1.18.1.RC1-SNAPSHOT: Could not transfer artifact net.sf.jopt-simple:jopt-simple:jar:4.6 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/net/sf/jopt-simple/jopt-simple/4.6/jopt-simple-4.6.jar: Connection reset -> [Help 1]
[2020-09-01T07:02:51.369Z] [ERROR]
[2020-09-01T07:02:51.369Z] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[2020-09-01T07:02:51.369Z] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[2020-09-01T07:02:51.369Z] [ERROR]
[2020-09-01T07:02:51.369Z] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[2020-09-01T07:02:51.369Z] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[2020-09-01T07:02:51.369Z] [ERROR]
[2020-09-01T07:02:51.369Z] [ERROR] After correcting the problems, you can resume the build with the command
[2020-09-01T07:02:51.369Z] [ERROR]   mvn <args> -rf :apm-agent-benchmarks
[2020-09-01T07:02:52.611Z] Stage "Tests" skipped due to earlier failure(s)
[2020-09-01T07:02:52.818Z] Stage "Unit Tests" skipped due to earlier failure(s)
[2020-09-01T07:02:52.832Z] Stage "Smoke Tests 01" skipped due to earlier failure(s)
[2020-09-01T07:02:52.845Z] Stage "Smoke Tests 02" skipped due to earlier failure(s)
[2020-09-01T07:02:52.856Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-09-01T07:02:52.868Z] Stage "Javadoc" skipped due to earlier failure(s)
[2020-09-01T07:02:53.065Z] Failed in branch Unit Tests
[2020-09-01T07:02:53.076Z] Failed in branch Smoke Tests 01
[2020-09-01T07:02:53.086Z] Failed in branch Smoke Tests 02
[2020-09-01T07:02:53.094Z] Failed in branch Benchmarks
[2020-09-01T07:02:53.104Z] Failed in branch Javadoc
[2020-09-01T07:02:53.388Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-09-01T07:02:53.481Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-09-01T07:02:53.524Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-09-01T07:02:54.555Z] Running on worker-1095690 in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1373
[2020-09-01T07:02:54.674Z] [INFO] getVaultSecret: Getting secrets
[2020-09-01T07:02:54.758Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-09-01T07:02:56.894Z] + chmod 755 generate-build-data.sh
[2020-09-01T07:02:56.894Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1373/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1373/runs/1 FAILURE 369853
[2020-09-01T07:02:56.894Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1373/runs/1/steps/?limit=10000 -o steps-info.json
[2020-09-01T07:02:59.181Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1373/runs/1/tests/?status=FAILED -o tests-errors.json
[2020-09-01T07:02:59.890Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1373/runs/1/log/ -o pipeline-log.txt

:green_heart: Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Started by user sylvainjuge]

Start Time: 2020-09-01T08:22:00.116+0000

Duration: 48 min 37 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
1484

Skipped
11

Total
1495


🐞 - TuiEditor: the value in the component is incorrectly updated when it is passed as an empty string using formControl

Reproduction url
https://taiga-family.github.io/editor/starter-kit?ngModel=&placeholder=Test
Description
An empty string is incorrectly processed by the TuiEditor component. Playback Steps:

Open the showcase at the specified link;
In the ngModel: Example pass HTML code input, delete the value through the cross;
Enter something into the Editor component;
Repeat step 2;
Look at the result.

Expected behavior:
The component has cleared, there is no value in it and the placeholder is visible.
Current result:
The text in the input is not cleared, the placeholder is layered on the text

Taiga UI version
4.15.0
Browser Used
Chrome
OS Used
macOS

I'll take this issue on Monday


Extract image from graph

How can we get the exact image on which inference has been performed ?
In the android app, i think it can be accessed using "AndroidPacketGetter.java" file, but the usage documentation could be more elaborate.
Could someone please help ?
Also, i tried the opencv image encode calculator but it is crashing the android app when included in the graph
i included         "//mediapipe/calculators/image:opencv_image_encoder_calculator", in the Graph build file.
The error being thrown is
"cannot locate symbol "_ZN2cv8imencodeERKNS_6StringERKNS_11_InputArray"
which i think means cannot find the shared object which contains the cv::imencode to string from Input array method

I believe the getBitmapFromRgba(Packet packet) in AndroidPacketGetter.java will help.
But you need to revise the calculator itself to output an ImageFrame Packet first.
Note: Also remember to add processor.getGraph ().addPacketCallback("stream name", new PacketCallback(){}) before your graph's start/preheat process.

Thank you so much

Can you share the code that solves this problem, thank you very much


Added Doxygen support

Install doxygen here or with brew install doxygen
Create doxygen documention in docs/ with this command from the root project directory
doxygen Doxyfile

Wow, for some reason I thought it was @jo3w4rd who enabled Doxygen.  Actually, you made the first commits to autowiring.io and even registered the domain.


[FHIRcast] Add FHIRcast scopes for SMART launch

https://medplum.slack.com/archives/C05GD70FF55/p1699308082728279
https://fhircast.org/specification/STU2/#session-discovery


Missing examples?

It would be nice if there were an example or two in the intro (or elsewhere) that showed how a user might use this:
Something like the //# eagerCompilation=all comment in the explainer (presumably all is the only currently supported value today?)

I added an example here: https://github.com/WICG/explicit-javascript-compile-hints-file-based/blob/main/README.md#introduction ; does that answer your question?

That's helpful! If you put that in the draft spec that would also be cool. 😸


"Unabridged API: unexpected kind 'page' (IGNORED)" when using @todo

It looks like using @todo in Doxygen causes this warning to pop up during build:
(!) Unabridged API: unexpected kind 'page' (IGNORED)

The todo entry is then not visible anywhere in the final documentation.
How to reproduce
    /**
     * @todo This TODO directive causes <tt>(!) Unabridged API: unexpected kind 'page' (IGNORED)</tt>
     */
    class incomplete_class {
    };

I have a separate project where I collected this and other issues (still looking to dispatch them to the right repository); you can also check that out to reproduce.
Doxygen HTML output

Exhale HTML output

Well, that's certainly unexpected!  Hmmmm.  I will have to look into this page business, thanks for creating a repro example!  I don't know how easy this one will be to fix, in the meantime I wonder if you can get away with just using the sphinx todo directive?

in conf.py's extensions list add "sphinx.ext.todo" (same list where "breathe" and "exhale" are

in docs, you have to do that in an \rst block:
/**
 * \rst
 * .. todo:: implement me!
 * \endrst
 */

somewhere in your docs, e.g. docs/todo.rst include the .. todolist:: directive to dump them all out

Doesn't fix the actual problem here, but I think it could be a usable workaround?

Thanks! The todo list is more of "nice to have" for my project, but it definitely can be useful.
The workaround works perfectly, but I had to

add todo_include_todos = True to conf.py

Now that's what I'm getting:

Hey, is there any update on this issue?

as far as i know this can be closed, doxygen page support was added in #114 so i think it will work with regular old \todo in doxygen as well as the rst solution and .. todolist:: is another viable contendor
please speak up if it's not fully solved

this also seems to happen with the @deprecated doxygen command.


Update MD file on new branch 2017-19-15_08-11-36

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Retarget ament_acceleration repos to rolling branch

Retargeting repo branch in rolling/distribution.yaml for the ament_acceleration package from main to rolling. (Done in advance since we'll be doing a release for humble as well.)
upstream repository: https://github.com/ros-acceleration/ament_acceleration.git
release repository: https://github.com/ros2-gbp/ament_acceleration-release.git
distro file: rolling/distribution.yaml

This looks fine, and I'm going to merge it.  But I'll also highly suggest you update https://github.com/ros2-gbp/ament_acceleration-release/blob/master/tracks.yaml#L17 to also point to rolling (rather than null), which will make blooming easier later on.


Build fails with non-informative traceback from subprocess

I think this is the same issue as #627 from January.
It happened to the PDF build for me today after I wiped my project earlier today:
https://readthedocs.org/builds/gammapy/1615772/
The only error message displayed is this which doesn't give me any clue what the problem is or what I have to do to fix it:
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/readthedocs/projects/utils.py", line 85, in run
    stderr=subprocess.PIPE, env=environment)
  File "/usr/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/usr/lib/python2.7/subprocess.py", line 1327, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory

Closing this, but in general we're working to fix the build system so these issues won't happen anymore


Status Updates – Navigator 2.0 Usability Research

We'll use this issue to share status updates of the Navigator 2.0 API usability research project.
Status Reports

2021-03-25 (Week 12)
2021-04-02 (Week 13)
2021-04-09 (Week 14)
2021-04-16 (Week 15)
2021-04-23 (Week 16)
2021-04-30 (Week 17)
2021-05-06 (Week 18)
2021-05-14 (Week 19)
2021-05-21 (Week 20)
2021-05-28 (Week 21)
2021-06-04 (Week 22)
2021-06-11 (Week 23)
2021-06-18 (Week 24)
2021-06-25(Week 25)
2021-07-02(Week 26)
2021-07-09(Week 27)
2021-07-16(Week28)

TODO List
Target completion dates are included in the parenthesis after each item, but they are subject to adjustments as we go.

[x] Gather scenario code snippets for vrouter, beamer and auto_route (#9, 4/30)
[x] Complete heuristic evaluations

[x] Conduct heuristic evaluation for vrouter (5/7)
[x] Conduct heuristic evaluation for beamer (5/7)
[x] Conduct heuristic evaluation for auto_route (5/7)
[x] Summarize heuristic evaluation findings (5/14)

[x] Complete API walkthrough study

[x] Adapt walkthrough study plans for the 3 packages based on heuristic evaluation results (5/14)
[x] Conduct walkthrough studies for 3 packages (6/5)
[ ] Report findings (6/11)

[ ] Write a final report synthesizing all the usability and technical evaluation results (6/25)

2021-03-25 (Week 12)
DONE

Added code snippets for some routing scenarios

Router (Navigator 2.0):

Merged: deeplink-pathparam, deeplink-queryparam, dynamic-linking
In review: login, skipping stacks

VRouter

In review: deeplink-pathparam, deeplink-queryparam, dynamic-linking

Exercised the API usability evaluation guide on Navigator 2.0 using the “deep linking by path parameter” scenario. This allowed us to better operationalize the evaluation process. We’ll post the evaluation results to the Github and make minor revisions to the evaluation guide next week.

NEXT STEPS

Conducting an end-to-end research pilot: Our immediate next step is to prove out our research methodology by exercising it end-to-end on a single package, vrouter, and using just a couple of scenarios as soon as possible. This pilot will include a heuristic evaluation based on the API usability evaluation guide and a couple of user study sessions. We will make improvements to the study protocol through this pilot and get a better sense of what we might learn from this exercise before applying the same process to more packages and scenarios. We aim to complete this pilot and share what we learned by mid-April.

Selecting packages for the full study: this project has surfaced many routing packages from the community. However, our bandwidth won’t allow us to properly study all of them in detail. Our tentative plan is to select 3 packages in the full package comparison study (#7). We outlined a tentative selection criteria in #10. Feel free to advocate for a package and explain why the package meets most, if not all of the criteria. We aim to design the study in a way that a motivated community member can contribute to the analysis for additional packages in the future. We aim to complete the full study by mid-May.

@InMatrix
Just throwing this out there - happy to provide code snippets and such for auto_route, especially since I'm in contact with Milad-sama as well

2021-04-02 (Week 13)
DONE

Added additional code snippets (#9)

Router (Navigator 2.0): Merged snippet for the sign-in routing and skipping stacks scenarios. The snippet for nested routing is in review.
VRouter: Merged snippets for the deep linking and dynamic linking scenarios. Snippets for the sign-in routing and skipping stacks scenarios are in review.
Beamer: Snippets for the deep linking and dynamic linking scenarios are in review.

Added flow_builder and navi to the comparison table
Made progress on the research pilot

Completed the first user study session on vrouter using its implementation of the deeplinking by path parameter scenario
Conducted a heuristic evaluation of vrouter

Opened a discussion about additional requirements for Nested Routing

NEXT STEPS

Complete the research pilot

Run another user study session
Review pilot results and revise the study design

Select packages for the full study (described in last week’s status report)

NEXT STEPS

Complete the research pilot

Run another user study session
Review pilot results and revise the study design

Select packages for the full study (described in last week’s status report)

@InMatrix I need 1 or 2 days to release Navi 0.1.0 with completed code snippets for all scenarios. Is this not too late for NEXT STEPS you mentioned?

@theweiweiway Feel free to add code snippets for auto_route to the scenario-code folder. We've also been in touch with @Milad-Akarie.
@nguyenxndaidev It's definitely not too late. However, submitting code snippets doesn't guarantee that we will be able to use them in the full evaluation. We still haven't yet go through the selection process outlined in #10. I hope the snippet writing exercise is worthwhile in itself for the purpose of reflecting on your API design. :-)

We still haven't yet go through the selection process outlined in #10.

@InMatrix Thanks for the info! Could you please update your plan, when will you start #10?

@InMatrix I released Navi 0.1.0. Refactoring the given code in scenario-code folder and will create a PR with the new files.

@InMatrix PR https://github.com/flutter/uxr/pull/38 is created.

2021-04-09 (Week 14)
###DONE

Updated API Usability Evaluation Guide based on experience applying it on the Router API

Changed rating scales from 3 points to 5 points
Added examples for carrying out specific steps

Pilot study - completed 2 additional user study sessions using snippets from vrouter

###IN-PROGRESS

Started a process to select 3 packages we want to focus on in the next stage of research. More information will be available in issue #10
Finishing up the evaluation of vrouter as part of the research pilot

###NEXT STEPS

Implement a version with transitions for nested routing scenario using Router based on discussion
Review code snippet pull requests
Revise the user study design based on pilot study results
Share pilot study results
Align on project schedule/timeline with the goal to complete study by EOQ2

2021-04-16 (Week 15)
###DONE

Posted a tentative decision about packages we plan to focus on in the next round of evaluation.
Posted a public update about API Walkthrough study pilot interviews.
Added beamer snippets for 3 scenarios (pull request)
Added vrouter snippets for 2 scenarios (pull request)
Reached a resolution about the nested routing scenario

The initial version of the snippet written with Router (https://github.com/flutter/uxr/pull/34) will preserve the tab selection state but will not support transition animations between tabs.
There are a few advanced features of the nested routing scenario we’d encourage package authors to consider separately from the “base version” as implemented with the Router API. They include: custom transition animations between tabs, preserving scrolling positions, and preserving text input state. More discussions about those additional requirements are being held in issue #35.

###IN-PROGRESS

Finalize the study plan for the API Walkthrough study.
Nested routing sample snippet - exploring adding transition animations between tabs

###NEXT STEPS

Get initial version of nested routing sample snippet merged
Conduct heuristic-based usability evaluations of 3 packages (currently blocked on nested routing snippets)

DONE

Merged the Router snippet for the nested routing scenario (#34)
Discussed preliminary heuristic usability evaluation results for vrouter.

IN-PROGRESS

Preparing heuristic evaluations for vrouter, beamer, and auto_router. This is currently blocked by #9.
Working on specifying how to evaluate API viscosity. Please add your thoughts to #41.

NEXT STEPS

Please see the TODO list posted in the top comment.

2021-04-30 (Week 17)
DONE

Updated the instructions about assessing API Viscosity based on this discussion.
Merged beamer snippets to be used for heuristic evaluations
AutoRoute snippets also added
Opened Discussions feature for the repo for open-ended topics

IN-PROGRESS

Working on walkthrough study plan
Reviewing the PR from Navi

NEXT STEPS

Complete heuristic evaluations by 5/7 for VRouter, Beamer, AutoRoute

2021-05-06 (Week 18)
DONE
*Completed heuristic evaluations of VRouter, Beamer, and AutoRoute following the API Usability Evaluation Guide.
IN-PROGRESS

Synthesize heuristic evaluation results and generate package-specific research questions for the walkthrough study.
Recruiting participants for the API Walkthrough study.

NEXT STEPS

API Walkthrough user study - starting with VRouter

2021-05-21 (Week 20)
DONE

Conducted 3 sessions for VRouter API walkthrough study
Consolidated heuristic evaluation results

IN-PROGRESS

Preparing for Beamer and AutoRoute study sessions

NEXT STEPS

Complete VRouter API walkthrough study (2 more sessions to go)
Finalize an outline for the final study report

Hi, is there any timeline for the following goal stated in the wiki?

Design or endorse an easy-to-use package for implementing common navigation patterns, especially for use cases on the web.

I am having trouble connecting the status updates to that.

@creativecreatorormaybenot Hi, thank you for your question. This project has been taking longer than we initially anticipated. Our current projection is to complete usability studies of the 3 packages on our shortlist by the end of this quarter. We aim to publish a report with our findings and recommendations for choosing routing packages in July. Thank you for your patience.

2021-05-28 (Week 21)
DONE

Completed VRouter Walkthrough study with 4 external participants

IN-PROGRESS

Preparing Auto-Route Walkthrough study - starting next week

NEXT STEPS

Beamer Walkthrough study -  reviewing quiz questions and recruiting participants

Thanks a lot for the answer @InMatrix 🙏 I do not want to escalate the comments in this update thread, so one last clarification on the final status update / end goal:

We aim to publish a report with our findings and recommendations for choosing routing packages in July.

Am I right to assume that this means that the navigation in the Flutter framework will not be changed anymore, i.e. there will not be a Navigator 3.0 or a flutter/packages but rather the final step of the work tracked here is endorsing a community package?

@creativecreatorormaybenot As far as I know, there is no active discussion nor work about changing the built-in Navigation API in any significant way right now. It is our intent to provide guidance to Flutter users on choosing from existing navigation and routing APIs. Whether the Flutter team will endorse a single community package for navigation in the manner of endorsing Provider or make a more nuanced, conditional recommendation depends on the results of the ongoing evaluation.
Will there ever be a Navigator 3.0 at some point in the future? I simply don't know, since the timeframe is unspecified.

2021-06-04 (Week 22)
DONE

Completed 3 API walkthrough sessions for AutoRoute
Summarized a few VRouter sessions

IN-PROGRESS

Scheduling additional sessions for AutoRoute and Beamer
Working on a fix of Browser state: https://github.com/flutter/flutter/issues/80546

NEXT STEPS

Summarize API walkthrough study results
Write final research report

2021-06-11 (Week 23)
DONE

Completed 4 sessions for VRouter, 2 for AutoRoute and 3 for Beamer
Fixed, not yet merged Browser state: https://github.com/flutter/flutter/issues/80546

IN-PROGRESS

Additional sessions for AutoRoute and Beamer next wekk

NEXT STEPS

Summarize API walkthrough study results
Write final research report

2021-06-18 (Week 24)
DONE

Completed all 15 API walkthrough study sessions (5 for each of the three packages evaluated). Yay!

IN-PROGRESS

Summarize API walkthrough study results

NEXT STEPS

Write final research report
Plan reviewing results with the Flutter team and package authors

Not sure if this is the right forum but seems like there is bug on the Beamer snippet.

Repro
flutter run -d Chrome -t lib/deeplink-queryparam/deeplink-queryparam_beamer.dart --web-port=51513
Paste in browser bar and hit enter (TWICE - two times):
http://localhost:51513/#/?filter=land
http://localhost:51513/#/?filter=land (again)
Filters disappears

@idkq Would you mind opening a new issue in this repo and tag Beamer's author?

@idkq it has been solved - #69 (@InMatrix I don't have a permission to close the issue, feel free to close it)

2021-06-25 (Week 25)
DONE

Summarized all 15 API walkthrough study sessions (5 for each of the three packages evaluated). Yay!

IN-PROGRESS

Write final research report

NEXT STEPS

Plan reviewing results with the Flutter team and package authors

2021-07-02 (Week 26)
DONE

n/a

IN-PROGRESS

Writing final research report, targeting to complete in 2 weeks.
Preparing an update for a regular sync with Flutter GDEs next week

NEXT STEPS

Plan reviewing results with the Flutter team and package authors

Hi @InMatrix will the community & non-pkg-authors be able to review and contribute to the final report by any means? I assume that the report, when completed, will be published somewhere in the flutter website? I feel that despite the great job, some questions can remain open and shall be addressed in the future, so the community could help ensuring and capturing that in the report - if a draft is provided.

@idkq I believe anyone can contribute the the Flutter website by submitting PRs to https://github.com/flutter/website

2021-07-09 (Week 27)
DONE

Presented updates on research to Flutter GDEs

IN-PROGRESS

Writing final research report, targeting to complete in 1 week.
Preparing to share draft report with package authors to get feedback

NEXT STEPS

Finalizing report to share with community

@idkq The current plan is to share a mostly complete draft of the research report with the authors of the three packages we evaluated in detail for their comments and corrections first. And then we'll socialize the report internally with stakeholders on the Flutter team to discuss next steps. The final version will be shared with everyone, but we might not amend the report based on public discussions except obvious factual or writing errors. This report will be an artifact reflecting our understanding about the issue of designing high-level routing APIs at a specific point in time. Nonetheless, responses, counter-arguments, follow-up research will be welcomed, and they can be posted in the discussion section of this repo or somewhere else.

Late to the party
I have some WIP about a different approach on navigation. Is it too late to hop in the discussion and share some snippets?

Welcome @rrousselGit
I think the best place to leave your thoughts is #6

2021-07-16 (Week 28)
DONE
n/a
IN-PROGRESS

Writing final research report, draft almost complete and will soon be ready to share with package authors

NEXT STEPS

Finalizing report to share with community

2021-07-16 (Week 28)
DONE
n/a
IN-PROGRESS

Writing final research report, draft almost complete and will soon be ready to share with package authors

NEXT STEPS

Finalizing report to share with community

Can you at least give us which package is strongly recommended so we can start using it while waiting for the details

@ajnaf We're not ready to make a recommendation yet. Sorry, this has taken a long time. If you need to decide which package to use now, I'd suggest you take a look at the example code in this folder. You will be able to get a sense of how well the scenarios you care about can be implemented by different packages.

when will this work be finished?

@bogdanmarinescu We're getting close. Last week, we shared a draft of the research report with authors of VRouter, AutoRoute, and Beamer. We're in the process of addressing their comments. We're looking to release the report within a couple of weeks. Thanks for your patience!

@InMatrix Short of the full report, it'd be great to take a look at the draft report with the understanding that it may differ from the final report.

The research report is available to download. Please use this discussion thread to post any questions or comments you might have. Thank you for your support and patience!


dd: parse operands manually via positional args

Okay, so this is a super big PR basically all in one commit. I couldn't really split it up because everything I changed is interconnected. Sorry in advance :)
Before this PR, dd used clap to handle arguments. Essentially, it would rewrite this:
dd if=some_file.txt skip=4 iflag=skip_bytes

into this:
dd --if=some_file.txt --skip=4 --iflag=skip_bytes

and then passed it to clap for parsing. This is clever, but not quite correct.
First, since clap parses everything after -- as a positional argument, dd fails to parse the arguments (hence this PR closes https://github.com/uutils/coreutils/issues/3010).
Second, clap now reports weird errors, which don't match what the user wrote:
❯ cargo run --features unix -- dd ofsdf=outfile
error: Found argument '--ofsdf' which wasn't expected, or isn't valid in this context

        Did you mean '--of'?

        If you tried to supply `--ofsdf` as a value rather than a flag, use `-- --ofsdf`

USAGE:
    --dd --of=<FILE>

For more information try --help

Third, the --help message is also weird:
dd 0.0.15
copy, and optionally convert, a file system resource

USAGE:
    --dd [OPTIONS]

OPTIONS:
        --bs=<N>             (alternatively bs=N) specifies ibs=N and obs=N (default: 512). If ibs or obs are also specified, bs=N takes precedence. Multiplier strings permitted.
        --cbs=<N>            (alternatively cbs=BYTES) specifies the 'conversion block size' in bytes. Applies to the conv=block, and conv=unblock operations. Multiplier strings permitted.
        --conv=<CONV>...     (alternatively conv=CONV[,CONV]) specifies a comma-separated list of conversion options or (for legacy reasons) file flags. Conversion options and file flags may be intermixed.
...

Finally, we get very little control over the error messages, which sometimes differ:
❯ cargo run -- dd conv=block,unblock conv=ascii,ebcdic cbs=5
dd: Only one of conv=block or conv=unblock may be specified
❯ dd conv=block,unblock conv=ascii,ebcdic cbs=5
dd: cannot combine any two of {ascii,ebcdic,ibm}

I'm not claiming to fix all of these, but this refactor opens the doors for more. The new code is also smaller than before.

sorry but could you please fix the conflicts? thanks

Oof those were some nasty conflicts :) I hope I got them fixed correctly.


7.2.1: $PSStyle.OutputRendering

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
I think this is not a good idea to set $PSStyle.OutputRendering = 'Ansi' by default since esc-sequences can spoil the output to the console or file.
dir | out-file file.txt

Expected behavior
$PSStyle.OutputRendering = 'Host'

Actual behavior
$PSStyle.OutputRendering = 'Ansi'

Error details
No response
Environment data
This is one more example: `$PSVersionTable | Out-String | Set-Clipboard`

Name                           Value
----                           -----
PSVersion                      7.2.1
PSEdition                      Core
GitCommitId                    7.2.1
OS                             Linux 5.15.7-arch1-1 #1 SMP PREEMPT Wed, 08 Dec 2021 14:33:16 +0000
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

This is a by design change because using Host by default exposes a spoofing issue. See https://github.com/PowerShell/Announcements/issues/28 for details.

Seems like a bad "fix" for a security issue.  The announcement says it is temporary, but doesn't give an estimate on a fix and has comments disabled.  Any idea on when this will be resolved?

What if the update breaks my script or module?
You can uninstall the newer version of PowerShell 7 and install the previous version of PowerShell 7.
This should be treated as a temporary measure.
Therefore, the script or module should be updated to work with the patched version of PowerShell 7.

Above is quoted from the announcement. It means using an older version of pwsh should be a temporary measure, not that this fix is temporary.


Broken links in dialog windows

When I get a suggestion from Sourcery, there's a link in the modal to a page that describes the refactor.  For example:

Clicking that link (raise-from-previous-error) goes to https://docs.sourcery.ai/suggestions/raise-from-previous-error/ which is a 404.  The correct link is https://docs.sourcery.ai/Reference/Built-in-Rules/suggestions/raise-from-previous-error/
I've noticed this with all tooltips (it's not specific to the raise from previous error dialog).

In case it matters, I'm running 0.12.8 of the vscode Sourcery extention

Thanks for raising! Definite error on our part since we restructured our docs - will be fixed in the next release coming this week.

Fixed with 0.12.9


Verify: Updates Affecting TLS 1.2

https://tools.ietf.org/html/rfc8446#section-1.3

All affected TLS1.2 items were verified.


use builder in SetMonoid

Our benchmark shows that var of an immutable Set is ~50% faster than mutable.Set and .toSet later.
https://github.com/spotify/scio/issues/1183#issuecomment-410022235

Thanks for the PR.
What's the motivation? Is this faster? What about actually using a Set.newBuilder? I would assume that should be the fastest way to build.

We actually tried Set.newBuilder too but the loop looks clunkier, i.e.
items.foreach(_.foreach(x => builder += x))

Since almost no one looks at the code, but it is used as a library in some perf critical roles, I'd rather use the fastest implementation in almost all cases as long as it is tested well and the API is clean.

like items.foreach(builder ++= _) might look clean and use the builder, right?

thank you!

Also just checking if you guys can release this and maybe chill anytime soon? It's been a while for both projects.


VS Code telemetry needs to be more granular

The telemetry is mostly put in when registering the commands.
Today, the ms-graph.kiota/kiota.openApiExplorer.generateClient command encompasses all the generation events (client, manifest, plugin).
Having a more granular telemetry for each generation event would helps us understand better the extension use.
So we need to have separate events for:

client
api plugin (copilot plugin)
api manifest
openai plugin (other)

@thewahome Could you please check whether we could also add an attribute about the mode ("ttk", empty or other future value)?


update to run on never backstage version and with new backend system

Added plugin updates and the new backend system for Backstage.
As for the update done for the frontend plugin, we still reference the old NPM package, so installation still does not work.

Summary by CodeRabbit

New Features

Added a new section in the README for backend configuration of the Harbor plugin, including updated commands and connection details.
Introduced the Harbor backend plugin, enhancing backend capabilities for service integration.

Bug Fixes

Corrected commands and improved clarity in the README instructions for adding the Harbor plugin.
Enhanced the precision of equality checks in the getArtifacts function for better reliability.

Documentation

Updated the README with detailed instructions and structured configuration for the Harbor plugin setup.

Chores

Updated various dependencies in the package.json to improve functionality and compatibility.
Added an exclude property in tsconfig.json to optimize TypeScript compilation.

it seems that failed the branch due to the readme file having more than 80 chars.
https://app.codacy.com/gh/container-registry/backstage-plugin-harbor-backend/pull-requests/117/issues#issue-40a13fcad6f0ff815ce162ef068318bd
@mikkeschiren can you disable this rule?


Extend Adyen's and Stripe's webhooks to create an order when total_paid covers a checkout.total

I want to merge this change because...
This PR addresses the SALEOR-3751 and SALEOR-3752 issues, and brings these changes:
1. A new field called create_order has been added to the Payment model
2. If a payment (along with previous payments) covers the checkout's total amount the field's value is set to True.
3. When a notification arrives we now check if an order should be created with this payment.
Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[x] Documentation needs to be updated

Pull Request Checklist

[x] Privileged queries and mutations are guarded by proper permission checks
[x] Database queries are optimized and the number of queries is constant
[x] Database migration files are up to date
[x] The changes are tested
[x] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-3751 Extend Adyen's webhooks to create an order when total_paid covers a checkout.total

Task linked: SALEOR-3752 Extend Stripe's webhook to create an order when total_paid covers a checkout.total

Codecov Report

Merging #8217 (418a330) into feature/partial-payments (c21944b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@                     Coverage Diff                      @@
##           feature/partial-payments    #8217      +/-   ##
============================================================
+ Coverage                     93.19%   93.21%   +0.01%
============================================================
  Files                           482      482
  Lines                         36969    37018      +49
  Branches                       3955     3968      +13
============================================================
+ Hits                          34452    34505      +53
+ Misses                         1729     1728       -1
+ Partials                        788      785       -3

Impacted Files
Coverage Δ

saleor/payment/gateway.py
91.60% <ø> (ø)

saleor/graphql/order/mutations/fulfillments.py
97.95% <100.00%> (+0.30%)
:arrow_up:

saleor/order/__init__.py
100.00% <100.00%> (ø)

saleor/order/actions.py
92.35% <100.00%> (+0.09%)
:arrow_up:

saleor/order/error_codes.py
100.00% <100.00%> (ø)

saleor/order/models.py
94.20% <100.00%> (-0.07%)
:arrow_down:

saleor/payment/gateways/adyen/webhooks.py
86.61% <100.00%> (+0.50%)
:arrow_up:

saleor/payment/gateways/stripe/webhooks.py
74.41% <100.00%> (+0.77%)
:arrow_up:

saleor/payment/model_helpers.py
100.00% <100.00%> (+7.14%)
:arrow_up:

saleor/payment/models.py
97.14% <100.00%> (-0.21%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0729e3d...418a330. Read the comment docs.


How to use with flutter?

I know less about native Android or IOS and keep using flutter.
Is there any docs to use with flutter or any plan to create a flutter plugin?

Support for flutter is temporarily not considered, and hope you participate in contributing code.


Enable QNN primitives for DNNL runtime

Support of QNN primitives and their fused versions for DNNL
DNNL has support of int8 convolution/dense/matmul primitives with some list of post operations. Which usually looks like next:
%0 = conv(src<int8>, wgh<int8>)       -> <int32>
%1 = %0 + bias                        -> <int32>
%2 = %1 * o_scl                       -> <float>
%3 = act(%2) * act_scl                -> <float> // some activate like clip/relu/gelu and others
%4 = %3 + src2 * sum_scl              -> <float>
%5 = cast<int32>(%4) + dst_zp         -> <int32>
%6 = cast<int8>(%5)                   -> <int8>

Equivalent graph on relay level will looks like:
op = qnn.conv2d(data, weight, src_scl, src_zp, wgh_scl, wgh_zp)
op = add(op, bias)
op = qnn.requantize(op, rq_in_scl, rq_in_zp, rq_out_scl, rq_out_zp)
op = act(op, "clip")   // also ident, qelu, relu
op = cast(op, "int8")
op = qnn.add(op, sum_data, add_lhs_scl, add_lhs_zp, add_rhs_scl, add_rhs_zp, add_out_scl, add_out_zp)
op = clip(op)

To reach this mapping I have to introduce one more legalisation pass legalize_qnn_for_dnnl which reformulate qnn relay pattern to DNNL compatible form. Subsequent DNNL primitive handling is regular (pattern matching, transform to json, dnnl runtime support of new qnn nodes).
Additional things

There is issue with analysis of complex pattern after partitioning. Some engineers use linear search like GetRootCall(fn->body.as<CallNode>(), 2, {"conv", "add"}),  which is not fully correct and inconvenient. In this PR I use DFPatternMatcher for this purpose.
There is potential issue with constant naming and ordering. Because current mechanic of handling JSONRuntimeBase suppose  that you visit original graph as is without dropping of some paths or recalculation of constants. To avoid this issue this PR introduces DNNLConstantUpdater  utility which guarantee correctness of constant handling.
Positional arguments is not convenient approach is you have a lot of arguments and some of then optional. To simplify handling of optional arguments I use node attributes with index of corresponding input. Like "bias_idx=2", "o_scl"=5 and so on.
Added support of "quasi in-place" primitives. Currently that is stub and in-place behaviour is simulated via src->dst copy. After update of "MemoryPlan" with inlace support this simulation in runtime will be switched off.

Hi apeskov,
I'm working on zero-copy in DNNL which may relate to the in-place primitives you mentioned:

Added support of "quasi in-place" primitives. Currently that is stub and in-place behavior is simulated via src->dst copy. After update of "MemoryPlan" with in-place support this simulation in runtime will be switched off.

I tried to enable zero-copy when the tensors are read or write by DNNL primitives by assigning the handle of the DNNL memory to TVM buffer before the execution of the primitives. It works for most of the CV models I have tested, while produce wrong results in cases when:

TVM add is converted to post-op sum in DNNL, and
one of the inputs has a non in-place layout transform ahead of add.

With my understanding, the post-op sum is more like accumulation which requires the two inputs and the outputs to be the same buffer, and the non in-place OP before add breaks this requirement. I tried to replace post-op sum with post-op binary add, then the results are correct but DNNL may run into ref:any with terrible performance.
I couldn't find a solution to ensure both the correctness and optimal performance now. Do you have any idea about this? Is memory copy inevitable in this scenario?

Hi @yangulei,
As I remember zero-copy input/output of tensors should already works in TVM main. If you define relay layouts match with DNNL expectations it will use external buffer as is without any copying or processing. It was one of the goal of PR  https://github.com/apache/tvm/pull/11345. Could you please be more specific about scenarios you would like to optimise?
Regarding post-op sum. You are absolutely right, non in-place op before add break correctness. Mem copy is inevitable. In case of post op sum input data should be put into DST tensor of DNNL primitive and execution of primitive will rewrite this data. In contrast of post-op binary add read data from separate input tensor. Currently binary add has a limited support by primitives which lead to ref:any. Also it has slightly worse performance because it lead to one more memory access pass.
In case of missing layouts DNNL BOC runtime automatically inject required reorder primitives. And it will looks like next:
                    bias --
                           \
in1 -> RORDER_1 -> tmp_1 -> CONV -> tmp3 -> RORDER_3 -> out
                                  /
               in2 -> RORDER_2 --

Problem in tensor tmp_3. There is 2 primate which produce data of tmp_3. That's break concept of data flow graph. REORDER_2 should be executed strongly before CONV primitive. If you take a look in this patch in code relate with in-place simulation (link to it) you will see exactly I said. Essentially it's just copy input data to dst tensor exactly before convolution primitive.
Post op sum is very tricky and has a lot of requirements. It works only if proper layouts for conv and add was selected. It requires validation of ability to rewrite input tensor memory (for Resnet50  this is correct but in arbitrary case it should be checked).

Could you please be more specific about scenarios you would like to optimize?

I tried zero-copy before the merging of #11345, it's not necessary now since it's already covered in your work.
Thanks for your explanation about post-op sum. As residual structure is widely used in CV models, the performance gain from post-op sum is very important, so we want to use post-op sum if possible. I'll try to add a reorder to copy SRC to DST in DNNL, it will be nice if DNNL do nothing if SRC and DST are identical.
Regarding to the automatic injection of required reorder primitives, I think it's useful to ensure optimal DNNL layout in runtime. But I think it's better to do the layout transform in AlterOpLayout before the graph is consumed by DNNL, thus we can do the layout transform in compile/build time instead of runtime.

But I think it's better to do the layout transform in AlterOpLayout.

Absolutely agree with you! Automatic reordering is just a fallback mechanics which prevent DNNL from using "ref:any" implementations. "TensorRequisite" mechanic was designed specially to do nothing in case of matched layouts, and smooth out performance degradation if layout was not specified properly.
Current mechanic with "get_optimal_layout_for_XXX" has a lot pot limitations and may works incorrect for some cases. So auto reordering is still needed.
In context of enabling sum post op. Absolutely agree with you again! This is important feature, specially in case of latency optimisation on system with big cores count. As you see I'm working on that. This patch contain "stub" inlace support, because a lot of changes required on level of TVM GraphExecutor/VM memory plan manager. In-place memory modification support should be added to TVM as common feature. Otherwise it will looks like hack/workaround only for DNNL runtime.

Hi @yangulei , Thanks for the comments. I am aware of the problem in https://github.com/apache/tvm/pull/11513
Perhaps I can propose a new pr soon to recover my previous change about altering dense layout.


fix/rust: fix rust ci bug

What do these changes do?

Related issue number

Closes #xxxx
Check code requirements

[ ] tests added / passed (if needed)
[ ] Ensure all linting tests pass, see here for how to run them

https://github.com/alipay/fury/pull/1138

Locally tested
cc @wangweipeng2 @chaokunyang

 Locally tested
cc @wangweipeng2 @chaokunyang
@caicancai
As the report says, it seems like the workspace cannot include dirty files. Maybe you should create a shell script out of the workspace and run it?

 Locally tested
cc @wangweipeng2 @chaokunyang
@caicancai
As the report says, it seems like the workspace cannot include dirty files. Maybe you should create a shell script out of the workspace and run it?

 Maybe you should create a shell script out of the workspace and run it?

Maybe now allowing dirty files is a good choice, I see a lot of projects don't actually require it

Maybe now allowing dirty files is a good choice, I see a lot of projects don't actually require it

Both options are fine. as long as they are tested correctly

Maybe now allowing dirty files is a good choice, I see a lot of projects don't actually require it

Both options are fine. as long as they are tested correctly

Thank you for your review and reply. At present, ci will not pass if the test fails

cc @chaokunyang


Preciser Status on each Website (Inactive/active)

Currently, the popup page and extension icon seem too primitive (another related complaint: https://github.com/Exafunction/codeium-chrome/issues/48). I feel a little painful when

I want to temporarily turn on/off the completion on the current web page manually by one-click, instead of going to the option page to edit the whitelist.
I desire to add the regex of current page to the whitelist by one-click
The icon on the extension bar show if this extension is active in current page

My desired feature looks like wakatime, which also tracks the activities of the user and includes white/black list feature.
I'd like to work on this enhancement by this weekend, make the popup page more fancy as well (such as showing how many completions are accepted today, or the graph). Please let me know if the idea is acceptable or conflict with others.

I think items 1. 2. and 3. would be appreciated! I think stuff like adding the number of completions accepted we might want our own design team to first make a spec.

Thanks @fortenforge @pqn
I finished 3 on my side. Considering how to implement 2, if the popup page is immutable, I can add the option on the contextMenu like this:

But I'm blocked by how to disable the functionality of Codeium completion after injection (as the page is already loaded). Two approaches:

Write clean-up functions for every possible editor to unregister the completion provider. It's a little complicated and time-consuming, I may need help from you.
Ignore the message (completion request) from specific tabs, it sounds like a hack, I don't like it and neither do I know how to do that...

What do you think about it? Do you need me create the draft PR with current progress and have a discuss?

Can we write the same code twice, once in each implementations (CodeMirror and Monaco), to be able to read some state change caused by the context menu? Then if Codeium is disabled behave as a noop.

By the way, I found Colab supports their built-in completion now. It might not be a good way to overwrite the Monaco completion for it.

If this is true for everyone then we can disable it.

For Colab let's leave it on for now in that case. Not sure how Monaco will choose between them but as long as the user gets some completions it's probably okay either way.

Hi @pqn @fortenforge, Thanks for your help.
I tried to implement 1 and 2 in this draft https://github.com/Exafunction/codeium-chrome/pull/51 I'm not certain whether I understand your idea correctly so I created that PR early for tests and discussion. The code is dirty now, I will clean it up further if needed. Please let me know if I misunderstand anything.
And also, should I also push the implementation of 3 in the same PR, or is it more comfortable to review and handle the code so far? Either is fine to me.

Thanks! I think it's fine to keep 3 in the same PR, it's not unmanageably sized right now.


Role, warehouse and database mentioned before creation

In the Configure Credentials step, it is suggested that you specify the connection with a default role, warehouse and database. The creation of these objects, however, is not until the next step.

Facing the same issue, Could not connect to Snowflake backend after 2 attempt(s)


CLDC-3483: Prevent/fix missing letting allocation values

I have expected us to do this somewhere in derived variables for all checkbox fields already, which should have applied to BU. If we're not doing that, is it an issue for single log submission as well?

I can't replicate it for single log submission - as far as I can tell we're setting both the 1s and 0s when saving an answer to the question but it's not an inference that happens whenever we set any of them on a log object directly.
That said, I found a small number of imported logs with creation method single log that did have this problem, so I can't filter them out for the fix task.


Add quoted fix suggestion string.

Fix for https://github.com/ocurrent/opam-dune-lint/issues/19.
Having the syntactically correct suggestion will be helpful when integrating with ocurrentand GH checks @talex5

Good idea - thanks!


Feature request: deletion of multiple backup notes

This may be controversial or at least require an "Are you sure" confirmation:
At present seeing backup copies of notes involves showing those notes in the Backup Copy of the Configuration window. Notes can then be viewed or deleted one by one.
In my case there are a combination of notes that I knowingly deleted, empty notes I mistakenly created, or notes I simply created for testing. However, even if I am sure which is which, there is no way to select and delete more than one at a time.

Yes, agree. "At some point in time".

I have done this, now can select multiple lines and press delete button, but only single lines for recover and view.  Does not make sense to view multiple notes. No multiple recover because recover is a serious step and I believe needs a bit of considering.
Davo

Sounds good. Agree that multiple recovers likely not good.

Fixed in v0.29
Thanks for the report.
Davo


Support L3 dependent L4 policy

[x] Extend BPF with the ability

Option 1: map in map lookup
Option 2: embed a fixed array in L3 policy map
Option 3: tail call to source specific section (memory hungry)

[ ] Represent this in the policy model

Related issue: https://github.com/cilium/cilium/issues/1496

Duplicate of #1496


How can RemoteCacheManager be closed?

RemoteCacheManager is used in Cache.java such that the cache is automatically started.  However, the cache is never "stopped" i.e. the stop() method is never called.  This results in the following warning:
Resource leak: '' is never closed
Is there a good place to call the stop() method?

We would need to add a stop method in the verticle that trigger close on the remote cache.


improve Support qt_target_sql for query ccr downstream

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall