[SPARK-13921] Store serialized blocks as multiple chunks in MemoryStore

This patch modifies the BlockManager, MemoryStore, and several other storage components so that serialized cached blocks are stored as multiple small chunks rather than as a single contiguous ByteBuffer.
This change will help to improve the efficiency of memory allocation and the accuracy of memory accounting when serializing blocks. Our current serialization code uses a ByteBufferOutputStream, which doubles and re-allocates its backing byte array; this increases the peak memory requirements during serialization (since we need to hold extra memory while expanding the array). In addition, we currently don't account for the extra wasted space at the end of the ByteBuffer's backing array, so a 129 megabyte serialized block may actually consume 256 megabytes of memory. After switching to storing blocks in multiple chunks, we'll be able to efficiently trim the backing buffers so that no space is wasted.
This change is also a prerequisite to being able to cache blocks which are larger than 2GB (although full support for that depends on several other changes which have not bee implemented yet).

Test build #53251 has started for PR 11748 at commit e5e663f.

Test build #53251 has finished for PR 11748 at commit e5e663f.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53251/
Test FAILed.

Test build #53290 has started for PR 11748 at commit 0a347fd.

Test build #53290 has finished for PR 11748 at commit 0a347fd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53290/
Test PASSed.

Test build #53351 has started for PR 11748 at commit 4f5074e.

Test build #53352 has started for PR 11748 at commit b6ddf3e.

Test build #53355 has started for PR 11748 at commit 719ad3c.

@rxin, I believe that I've addressed all of your review comments (plus the outstanding TODOs that I left).

Test build #53363 has started for PR 11748 at commit 3fc0b66.

Test build #53355 has finished for PR 11748 at commit 719ad3c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53355/
Test FAILed.

Looks good from my side. Would be good for somebody else to take a look at this too. E.g. @andrewor14 ?

Test build #53352 has finished for PR 11748 at commit b6ddf3e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53352/
Test PASSed.

Test build #53351 has finished for PR 11748 at commit 4f5074e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53351/
Test PASSed.

Test build #53363 has finished for PR 11748 at commit 3fc0b66.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53363/
Test PASSed.

Merged build finished. Test PASSed.

Jenkins, retest this please.

Test build #53442 has started for PR 11748 at commit 3fc0b66.

Test build #53442 has finished for PR 11748 at commit 3fc0b66.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53442/
Test FAILed.

Test build #53445 has started for PR 11748 at commit cb9311b.

Test build #53445 has finished for PR 11748 at commit cb9311b.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53445/
Test FAILed.

Jenkins, retest this please.

Test build #53452 has started for PR 11748 at commit cb9311b.

Test build #53452 has finished for PR 11748 at commit cb9311b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53452/
Test PASSed.

Test build #53489 has started for PR 11748 at commit 2970932.

Test build #53489 has finished for PR 11748 at commit 2970932.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53489/
Test PASSed.

Merging to master.

Hi @JoshRosen ,
I am trying spark 2.0, and I believe I am hitting a bug that was introduced in this commit. In summary, the problem is that when kryo serialization is enabled and you have an RDD with less elements than the default parallelism being serialized with kryo, spark will attempt to create an empty ChunkedByteBuffer and this code will throw "chunks must be non-empty". If you believe there is a better forum for me to discuss this, let me know. Happy to contribute pull requests if appropriate.
The problem is easy to reproduce. First, open a spark shell.
spark-shell --conf spark.serializer=org.apache.spark.serializer.KryoSerializer --conf spark.default.parallelism=2

Then just try to serialize a RDD with a single element (two elements or above works fine, non kryo serialization works fine):
sc.makeRDD("element"  :: Nil).persist(org.apache.spark.storage.StorageLevel.DISK_ONLY).count

And you get back:
[Stage 0:>                                                          (0 + 0) / 2]ERROR  [12:35:15.701] [Executor task launch worker-0] org.apache.spark.executor.Executor -  Exception in task 0.0 in stage 0.0 (TID 0)
java.lang.IllegalArgumentException: requirement failed: chunks must be non-empty
        at scala.Predef$.require(Predef.scala:224) ~[scala-library-2.11.8.jar:na]
        at org.apache.spark.util.io.ChunkedByteBuffer.<init>(ChunkedByteBuffer.scala:41) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.util.io.ChunkedByteBuffer.<init>(ChunkedByteBuffer.scala:52) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.storage.DiskStore$$anonfun$getBytes$2.apply(DiskStore.scala:101) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.storage.DiskStore$$anonfun$getBytes$2.apply(DiskStore.scala:91) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1286) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.storage.DiskStore.getBytes(DiskStore.scala:105) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.storage.BlockManager.getLocalValues(BlockManager.scala:439) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.storage.BlockManager.getOrElseUpdate(BlockManager.scala:672) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.rdd.RDD.getOrCompute(RDD.scala:330) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.rdd.RDD.iterator(RDD.scala:281) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:70) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.scheduler.Task.run(Task.scala:85) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:274) ~[spark-core_2.11-2.0.0.jar:2.0.0]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_91]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_91]
        at java.lang.Thread.run(Thread.java:745) [na:1.8.0_91]
ERROR  [12:35:15.743] [task-result-getter-1] org.apache.spark.scheduler.TaskSetManager -  Task 0 in stage 0.0 failed 1 times; aborting job
org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 0.0 failed 1 times, most recent failure: Lost task 0.0 in stage 0.0 (TID 0, localhost): java.lang.IllegalArgumentException: requirement failed: chunks must be non-empty
        at scala.Predef$.require(Predef.scala:224)
        at org.apache.spark.util.io.ChunkedByteBuffer.<init>(ChunkedByteBuffer.scala:41)
        at org.apache.spark.util.io.ChunkedByteBuffer.<init>(ChunkedByteBuffer.scala:52)
        at org.apache.spark.storage.DiskStore$$anonfun$getBytes$2.apply(DiskStore.scala:101)
        at org.apache.spark.storage.DiskStore$$anonfun$getBytes$2.apply(DiskStore.scala:91)
        at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1286)
        at org.apache.spark.storage.DiskStore.getBytes(DiskStore.scala:105)
        at org.apache.spark.storage.BlockManager.getLocalValues(BlockManager.scala:439)
        at org.apache.spark.storage.BlockManager.getOrElseUpdate(BlockManager.scala:672)
        at org.apache.spark.rdd.RDD.getOrCompute(RDD.scala:330)
        at org.apache.spark.rdd.RDD.iterator(RDD.scala:281)
        at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:70)
        at org.apache.spark.scheduler.Task.run(Task.scala:85)
        at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:274)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

Driver stacktrace:
  at org.apache.spark.scheduler.DAGScheduler.org$apache$spark$scheduler$DAGScheduler$$failJobAndIndependentStages(DAGScheduler.scala:1450)
  at org.apache.spark.scheduler.DAGScheduler$$anonfun$abortStage$1.apply(DAGScheduler.scala:1438)
  at org.apache.spark.scheduler.DAGScheduler$$anonfun$abortStage$1.apply(DAGScheduler.scala:1437)
  at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
  at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
  at org.apache.spark.scheduler.DAGScheduler.abortStage(DAGScheduler.scala:1437)
  at org.apache.spark.scheduler.DAGScheduler$$anonfun$handleTaskSetFailed$1.apply(DAGScheduler.scala:811)
  at org.apache.spark.scheduler.DAGScheduler$$anonfun$handleTaskSetFailed$1.apply(DAGScheduler.scala:811)
  at scala.Option.foreach(Option.scala:257)
  at org.apache.spark.scheduler.DAGScheduler.handleTaskSetFailed(DAGScheduler.scala:811)
  at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.doOnReceive(DAGScheduler.scala:1659)
  at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:1618)
  at org.apache.spark.scheduler.DAGSchedulerEventProcessLoop.onReceive(DAGScheduler.scala:1607)
  at org.apache.spark.util.EventLoop$$anon$1.run(EventLoop.scala:48)
  at org.apache.spark.scheduler.DAGScheduler.runJob(DAGScheduler.scala:632)
  at org.apache.spark.SparkContext.runJob(SparkContext.scala:1872)
  at org.apache.spark.SparkContext.runJob(SparkContext.scala:1885)
  at org.apache.spark.SparkContext.runJob(SparkContext.scala:1898)
  at org.apache.spark.SparkContext.runJob(SparkContext.scala:1912)
  at org.apache.spark.rdd.RDD.count(RDD.scala:1111)
  ... 48 elided
Caused by: java.lang.IllegalArgumentException: requirement failed: chunks must be non-empty
  at scala.Predef$.require(Predef.scala:224)
  at org.apache.spark.util.io.ChunkedByteBuffer.<init>(ChunkedByteBuffer.scala:41)
  at org.apache.spark.util.io.ChunkedByteBuffer.<init>(ChunkedByteBuffer.scala:52)
  at org.apache.spark.storage.DiskStore$$anonfun$getBytes$2.apply(DiskStore.scala:101)
  at org.apache.spark.storage.DiskStore$$anonfun$getBytes$2.apply(DiskStore.scala:91)
  at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1286)
  at org.apache.spark.storage.DiskStore.getBytes(DiskStore.scala:105)
  at org.apache.spark.storage.BlockManager.getLocalValues(BlockManager.scala:439)
  at org.apache.spark.storage.BlockManager.getOrElseUpdate(BlockManager.scala:672)
  at org.apache.spark.rdd.RDD.getOrCompute(RDD.scala:330)
  at org.apache.spark.rdd.RDD.iterator(RDD.scala:281)
  at org.apache.spark.scheduler.ResultTask.runTask(ResultTask.scala:70)
  at org.apache.spark.scheduler.Task.run(Task.scala:85)
  at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:274)
  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
  at java.lang.Thread.run(Thread.java:745)

I am in mac, and I used the stock preview binary from http://d3kbcqa49mib13.cloudfront.net/spark-2.0.0-preview-bin-hadoop2.7.tgz. A custom built v2.0.0-rc1 behaved the same in a linux box. The 1.6.x series has no problems.

@bonitao here's a patch that fixes it https://github.com/apache/spark/pull/14099

Amazing. Thanks a lot @JoshRosen .


configurable eth_call accepted errors

Description:
make accepted error codes from mirror node for eth_call configurable and added initial default ones
Related issue(s):
Fixes #
Notes for reviewer:
Whenever we get an accepted Error code from the mirror node, the request handler will return null and the end result will be: 0x

Checklist

[ ] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

Codecov Report
Patch coverage has no change and project coverage change: -0.12 :warning:

Comparison is base (a429072) 74.43% compared to head (d0a67d1) 74.32%.

:exclamation: Current head d0a67d1 differs from pull request most recent head e5450a5. Consider uploading reports for the commit e5450a5 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.23    #1264      +/-   ##
================================================
- Coverage         74.43%   74.32%   -0.12%
================================================
  Files                31       31
  Lines              2241     2243       +2
  Branches            446      447       +1
================================================
- Hits               1668     1667       -1
- Misses              443      445       +2
- Partials            130      131       +1

Impacted Files
Coverage Δ

packages/relay/src/lib/clients/mirrorNodeClient.ts
88.56% <0.00%> (-1.25%)
:arrow_down:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


/en-US/docs/Web/API/Node/replaceChild has identical descriptions for two different parameters

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details
In the parameter definitions for replaceChild, both newChild and oldChild have the exact same description. I'm assuming this is a copy-paste error and they should have different descriptions.

I'd be happy to help fix it but haven't contributed to mdn before so would appreciate guidance with it please.

Fixed; thanks for reporting!


Publish-Module Violates Single Responsibility Principle

Summary of the new feature / enhancement
As a user, I expect Publish-Module to publish a module, not package AND publish a module. As a user, I also expect that I can issue Package-Module to create a new module package that can then be published to one or more places, such as the PowerShellGallery and/or private package feeds.
Proposed technical implementation details (optional)
For example, the following workflows are what I desire:
PS C:\MyProject> Package-Module -Path ./out/MyModule

 ModuleName      Version    Path
 ----------      -------    -------------------------
 MyModule        1.0.0      C:\MyProject\artifacts\MyModule-1.0.0.nupkg

and then, combined with Publish-Module, perhaps something like:
PS C:\MyProject> Package-Module -Path ./out/MyModule -PassThru | Publish-Module ...

I also have had the same concern for a while. I would have wanted a New-PSResource or Build-PSResource and publish only pushes the resource to the repository.

@SydneyhSmith I know this is close to release but the existing functionality is already there just splitting it into two cmdlets.

We have been wanting to support publishing already built packages (nupkgs), and may need to in order to support certain repositories in the future...this won't block RC but I agree that it would be nice to have a Build-PSResource type command and support either unpacked modules or nupkgs as input for Publish-PSResource, probably as different parameter sets

Today you can sort of accomplish this by using the -DestinationPath parameter on Publish

The problem with the -DestinationPath is that the command still try to upload the package to remote repository and if you don't provide an API key the command fail (after blocking the command line for a while) with a 401 error


Is there an option to exclude a resource to propogate?

If I have used a secret resource to propagate to all child namespaces, can I control any specific resources to not propagate?
In my use case, there is a secret that I don't want to have in my child namespace.

Yes, we introduced this feature in HNC v0.7.0:
https://github.com/kubernetes-sigs/multi-tenancy/blob/master/incubator/hnc/docs/user-guide/concepts.md#basic-exceptions
Please try it out and let us know if you have any questions.
/close
On Sun, Feb 21, 2021 at 1:08 AM Vikas Kumar<EMAIL_ADDRESS>wrote:

If I have used a secret resource to propagate to all child namespaces, can
I control any specific resources to not propagate?
In my use case, there is a secret that I don't want to have in my child
namespace.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-sigs/multi-tenancy/issues/1405, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE43PZHTNWILJDC54V44BNTTACPNRANCNFSM4X6UX7QQ
.


Keycloak custom realm Frontend URL is not accessible

I tried setting up a different subdomain for a realm i created. But seems the mappings are not proper. Maybe will raise this issue under keycloak as well. Someone might need to check this

I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.
Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.
Thanks for your understanding.


Return nil when calling referral on postback when referral is not set

Hi, so I ran into to an issue with postbacks and referrals. When there's no referral set from Facebook in the postback, the referral in the postback object returned another Referral object.
This makes it hard to distinguish normal postbacks from m.me-referrals. Let me know, if i'm missing something.

Looks good to me, @gurschitz! Thanks! :sparkles: :cake: :sparkles:


Install/Deploy SocketPlane using Docker Compose

We can simplify SocketPlane by deploying 3 containers:

SocketPlane
Open vSwitch
Powerstrip

The only requirements we have of the host system are then:

Docker
Docker Compose
iptables (which is also a Docker dependency)
Linux Kernel > 3.7 with Open vSwitch and VXLAN kernel modules loaded (modprobe openvswitch)

SocketPlane can be driven through the REST API and we can write a command line client in Golang that could be installed by deb/rpm etc... (this would replace the shell script)

:+1: @mrjana and I were discussing the same. Thanks for opening the enhancement.
Though we are pulling the powerstrip container with our socketplane install, the other workflow
recommended by Powerstrip project is to have a fully functioning socketplane plugin that is easily composable with other powerstrip plugins.
In such a workflow, we have to think how the docker compose will help.
@mrjana was suggesting to launch the docker-ovs container and modprobe openvswitch from within the socketplane container.

@mavenugo @mrjana modprobe within the OVS container would require CAP_SYS_MODULE to be granted. We'd also have no visibility in to whether this was successful or not (the OVS container should run with both the userspace or kernel datapath). As a precaution, we could lsmod | grep openvswitch as part of the installer I suppose but there are no guarantees that the load is successful.
Therefore I'm in favour of loading the kernel module outside of the container as there is no userspace tunneling support in OVS AFAIK... which means our solution breaks if the kernel module is not present.
I'm going to open a ticket re:splitting out the powerstrip support in to a plugin.
If we only need to start two containers we still benefit from docker-compose
The installer only needs to docker-compose up -d and it's much easier to maintain a docker-compose.yml than long docker run commands inside a bash script.

@dave-tucker regardless of how we decide to get the modprobe done or make a more composable powerstrip adapter, am in support of using docker-compose to launch socketplane, docker-ovs and powerstrip containers.
I can personally go either way on the topic of needing a powerstrip-socketplane project when there is no actual need for that, given the fact that the current socketplane container can act both as a wrapper and as a powerstrip adapter already.
Also on the modprobe openvswitch, yes, we require CAP_SYS_MODULE. But, IMHO that is better than a need for a script or a host application to do just that. Also, if am not wrong, for future supports like conntracker, there would be more kernel modules to be loaded. Having these requirements self contained in the docker-ovs would be prefered compared to upgrading an extrernal application.

@dave-tucker I don't understand why we won't know if modprobe was successful or not if we do it from within the container. We will still get the feedback from modprobe right?

@mrjana only if you do it via docker exec - which locks us in at Docker 1.3 or later - but that will require baking in lsmod and modprobe in to our rootfs. We could add a optional script in supervisord to load the kernel module and we'd need to query success through the XML-RPC API. So long as docker-ovs "just works" I don't mind either way.

@dave-tucker Got it. Thanks for the clarification


Bump kubevirt.io/containerized-data-importer-api to v1.47.0

What this PR does / why we need it:
Latest CDI api has much less dependencies. Update to get it into our api package.
The critical change is from 	kubevirt.io/controller-lifecycle-operator-sdk to kubevirt.io/controller-lifecycle-operator-sdk/api.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Pull in cdi dependencies with minimized transitive dependencies to ease API adoption

/lgtm


Update Remove-Duplicates-from-Sorted-Array.cpp

Previous program was very lengthy and uses some high concept but my program uses simple language and basic concept which can be understand by even begginers and at same time my program is efficient its time complexity and space complexity is best.

Okk
On Sat, 10 Oct 2020, 11:27 Priyanshu Tiwari<EMAIL_ADDRESS>wrote:

@ahampriyanshu requested changes on this pull request.
Hi @Krishna3102 https://github.com/Krishna3102 👋,
Please take the input dynamically.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ahampriyanshu/algo_ds_101/pull/1198#pullrequestreview-506069659,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANZMQZBJADNFQQYYBV533LLSJ7ZVPANCNFSM4SKXILWQ
.


[Feature Request] Maintenance mode

What is the idea?
I think this one is a needed feature. Also doesn't seem so hard to code.
Why would this be beneficial
No response

Done and merged.


WIP - [MAPREDUCE-6659] - Mapreduce App master waits long to kill containers on lost nodes.

Linked to this internal issue: HDP-7099
The idea of this patch is to directly failed the task running on a lost NM as cleaning it is not possible (the node is not accessible)

+1


Add Flowbite icons set

This PR add the flowbite icons set. See this PR in Blade icons

Nice, thanks!


added batch content + thumbnails

noisy batch tutorial
batch optimization concept doc
SOBO vs. MOBO concept thmbnail
Bayes vs. Freq concept thmbnail
batch op concept thmbnail
noisy batch tutorial thmbnail

put in \static

Thanks @AndrewFalkowski 😊


Run interpretability notebooks on CI

The switch to Github Actions seems to allow us to run the interpretability notebooks on CI, which we couldn't do with Buildkite easily.
This relates to #819.

This is a nice bonus of actions! Do the containers used supply more ram?

Not entirely sure: we were running on t2.large EC2 instances before (2 CPUs, 8GB RAM):
https://github.com/stellargraph/stellargraph/blob/d4f100591dadc83b1c093fd53a84e21714eff694/.buildkite/pipeline.yml#L126
while Github Actions apparently offers 2 CPUs and only 7GB RAM: https://help.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners#supported-runners-and-hardware-resources


Docker installation method?

Thanks for releasing this. It looks great. Can't wait to get in and start playing with it! :D
How can this plugin be installed in a Docker Caldera installation? Attempting to follow the instructions fails once I get to the pip install requirements portion because there are dependency conflicts on my system. This is why I am running the docker version of Caldera. So, how can I install and configure the bountyhunter plugin within a docker deployment of Caldera?

Thanks for checking out the project!
I added a short docker installation guide to the README. Let me know if this works out for you or if you run into any problems.
In the past, I have found that the docker version of Caldera is not easy to use and configure, e.g., I find editing the server's or a planner's config file very tedious compared to a non-docker installation. Have you tried installing and running the Caldera server in a python venv? This should fix any dependency conflicts unless they are directly related to Caldera.

Thanks for this! I will follow your instructions and report back with my results. Will also look into doing this in a venv as an alternative to docker (which i would prefer as I do not much care for docker unless it is absolutely necessary).

Is it ok to just add the following lines at the very bottom of the Dockerfile under the entry point?
WORKDIR /usr/src/app/plugins/bountyhunter
RUN pip3 install -r requirements.txt

Sorry, the guide was not detailed enough. Try adding the two lines at line 77, this should fix the issue. Let me know if this works.

No trouble at all. I appreciate your efforts and assistance! To make sure I'm on the correct line, should I add it right before the following?
WORKDIR /usr/src/app
Install Node.js, npm, and other build VueJS front-end

Yes, that should work. I will check my test installation shortly to confirm.

That did solve the build fail issue. Will test out the plugin to verify functionality and report back.

Issue resolved with https://github.com/fkie-cad/bountyhunter/pull/7.
Thanks for your input and help improving the project for others @ll3N1GmAll!
If you run into further problems, please open a new issue!


Inline Template

It would be very helpful if one could define an inline template instead of having to rely on the router to load the external template.
Obviously this would suit the case when using stringify in an ES6 setup without having to fallback to
$templateCache or similar approaches.
import helloWorldTemplate from './../views/hello-world.html';

function AppController ($router) {
  $router.config([
    {path: '/', component: 'home', template: helloWorldTemplate }
  ]);
}

:+1: We use inline templates in our Angular 1 application with webpack.
Webpack just bundles all the templates and we don't need any templateCache.
        .when('/my-work/:action?', {
            template: require('app/create/my-projects/my-projects-controller.html'),
            controller: 'MyProjectsController'
        })

This really would simplify the use of templates IMHO! Instead of having to configure ng-html2js in the build process and making sure it is configured to use the correct source folder, module, etc., this would let you just directly import the HTML file in JavaScript. :)
Actually if the router were to support directives (see #161) this feature would be automatically supported via the directive. :) .. another nice possibility.
The only downside is that if you wanted to re-use templates across components the HTML strings would be duplicated in your JavaScript... but that's bad practice anyway so not really an issue IMHO.


Unknown token error in the return statement

Jerry revision:
08c618e
Test case:
function f(){return}

It returns with 'ERROR: Ln 1, Col 20: Unknown token }' however it is a valid JavaScript code.
Expected behaviour:
The functions should be parsed correctly that does nothing.

And I found more examples that have similar problem:
switch (1) {
  case 1:
    break}

while (true) {continue}


mlpipeline-minio-artifact secret out of sync with actual minio credentials

As discussed in #53, the mlpipeline-minio-artifact secret which is managed by a compositecontroller metacontroller + the sync.py script deployed by the kfp-profile-controller charm as the kfp-profile-controller pod.  If the sync.py/kfp-profile-controller workload is updated to have a new value for this secret, the mlpipeline-minio-artifact secret is not automatically updated.  This results in pipeline steps failing as they use this secret for their minio credentials.

Looks like we can make a small change to the composite controller (setting the secret to modify InPlace instead of OnDelete) and then the secrets will always be updated if they change.  tested manually, but hit problems rebuilding the charm so haven't pushed to github as a PR yet till done testing


Split: Check if AIBrains are exhausted even if remainingSplits is 0

If the only remaining splits are Boss splits, they don't work, because AIBrains are tracked outside of remainingSplits

Added this PR with fixes in 8fa0097


Partial refresh from outside the pagelet?

Is it possible to refresh a pagelet with javascript from somewhere outside of it?
My case: I'm trying to refresh a pagelet when I receive a websocket event.

At the moment, this is what I came up with:
Post an ajax request to somewhere, respond with a .js.erb and do:
$('.pagelet-notifications_table-show').replaceWith('<%= j pagelet :pagelets_notifications_table, remote: false %>');
Would be cool if there was a JS API exposed, like $('.pagelet-notifications_table-show').data('api').refresh() :D

You can use PageletRails.loadPagelets(jQuery_selector). There has been internal refactoring in master branch to make pagelets easier to reload, so you might need to pull those changes.
The master branch also has new pagelet reload feature. There are no docs yet as the interface needs a bit of thinking. The example code is already in the demo project. Have a look here: https://github.com/antulik/pagelet_rails_demo_app/blob/master/app/pagelets/comments/comments_controller.rb#L6 and demo http://polar-river-18908.herokuapp.com/tabs/comments
The idea that you assign tag to the pagelet and later you can trigger its refresh. Externally you can also do that with PageletRails.tagsChanged(html_id, tags) (html_id is the id of pagelet which triggered the change).

Oh nice, that looks so awesome! :) Even better than I imagined. The ability to update multiple different pagelets with tags is very clever! :P

module Notifications

  class NotificationsController < PageletController

    include PageletRails::Concerns::Controller

    pagelet_resources only: [:index, :update]

    def index
      identified_by :notifications
      @unread_notifications = Notification.for(current_employee).unread_by(current_employee).decorate
    end

    def update
      notification = current_employee.notifications.find(params[:id])
      notification.mark_as_read!(for: current_employee)
      trigger_change :notifications
      render_response
    end

    private

    def render_response
      respond_to do |format|
        format.html { redirect_to notifications_path }
        format.js
      end
    end

  end

end

Link
link_to 'Mark as read', pagelets_notification_path(notification), method: :put, remote: true)
The trigger change doesn't seem to do anything. What am I missing? :)

Not sure yet, try
    def update
      notification = current_employee.notifications.find(params[:id])
      notification.mark_as_read!(for: current_employee)
      trigger_change :notifications

      redirect_to notifications_path
    end

Since the link is remote: true, we can't redirect there.
ArgumentError (wrong number of arguments (given 2, expected 0..1)):
app/pagelets/notifications/notifications_controller.rb:25:in `update'

and responding to format.js doesn't work either.

@Frexuz the provided information is not enough to debug the issue, so far everything looks good.
I've just tested similar example with remote: true for deleting comments in the demo project. Everything works as expected. E.g.
  # app/pagelets/comments/comments_controller.rb
  def destroy
    comment = Comment.find params[:id]

    if comment.destroy
      trigger_change :comments
    end

    redirect_to action: :index
  end

= link_to 'Delete', pagelets_comment_path(comment), method: :delete, remote: true

If you can provide sample project so the issue could be reproduced, I could give you more accurate reply.

Hi. Found out a few things. (I'll try to explain my scenario where this becomes a little less-ideal)

Redirecting must use action:, that wasn't clear :) It kinda works now, however..

My two pagelets share some functionality:

Normally, the mark as read links would link to the same controller#action, but now I can't do that. Instead I have to duplicate the update method in each pagelet.
    def update
      notification = current_employee.notifications.find(params[:id])
      notification.mark_as_read!(for: current_employee)
      trigger_change :notifications
      redirect_to action: :index
    end

this also means I can't use my decorator to re-use my link
class NotificationDecorator < Draper::Decorator
  # this can't no longer be reused because it has to link to different pagelets
  def mark_read_link
    link_to(t('notifications.notification.mark_as_read'), pagelets_notification_path(model), method: :put, remote: true) if notification_unread?
  end
end

<% cache notification do %>

    <%= notification.text %>
    <%= notification.mark_read_link # no :( %>

<% end %>

Would you recommend another approach? Or have any other ideas? :)

I went with linking the mark as read link to a separate (normal) controller via remote: true, then responding with js and using PageletRails.tagsChanged. Works very nicely :)

Redirecting must use action:, that wasn't clear :) It kinda works now, however..

Redirecting could use any standard syntax, not just action: ...

I went with linking the mark as read link to a separate (normal) controller via remote: true, then responding with js and using PageletRails.tagsChanged. Works very nicely :)

I think that's a good solution. As an idea you can move that extra controller inside one of the pagelets folder so the code is grouped.
I can't think of anything else what you haven't mentioned yet. I had the similar problem with client side frameworks for web components. The solution was very similar and one of

duplicate action (or use concerns in ruby)
move to the parent component (or parent controller in ruby)
handle separately (like you've done with separate controller, or extract logic to service object with duplicated action)

What does the html_id do? I'm using undefined at this moment, and it works :)

when we want to refresh pagelets we want to exclude the pagelet which triggered the refresh to avoid double render, because it will be rendered as a part of the request. That html_id is identifier of the first pagelet. undefined is perfectly fine as long as you don't have html element with id='undefined' :)

Thanks for the explanations :)
I think this is fine to close.


Documentation | Link not proper

Link to Route management goes to Dependency Management.

I've looked for this error, but i could not find it. In none of the three languages. Could you point specificly where is the typo?

its not a typo, Under topics -> The Three pillars -> Route Management -> In depth Explanation. THIS takes to Dependency Management i/o Route Management.

On 14-Jul-2020, at 11:13 PM, Nipodemos<EMAIL_ADDRESS>wrote:
I've looked for this error, but i could not find it. In none of the three languages. Could you point specificly where is the typo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/jonataslaw/getx/issues/378#issuecomment-658318200, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHCLQS6LUH2PX2UJ4OQLT3R3SKNVANCNFSM4OZWKXIA.

i just made that gif, it does lead to the correct page

Oh, sorry, as the line you are clicking is in the end of the Route Management paragraph, the confusion raised.
After in depth explanation and next visible topic is Dependency Management.

On 14-Jul-2020, at 11:34 PM, Nipodemos<EMAIL_ADDRESS>wrote:
https://user-images.githubusercontent.com/11494727/87460367-278cac00-c5e3-11ea-826c-851bda293287.gif
i just made that gif, it does lead to the correct page
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/jonataslaw/getx/issues/378#issuecomment-658328529, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHCLQS5RLMYEUWZAEIHZULR3SM33ANCNFSM4OZWKXIA.

no problem man, i understand. I'll see if anything can be done to be more intuitive, docs still has a lot to improve

since it is solved, closing


enhancement: validate jsonld is properly flattened

This addresses #27 by introducing a new test for a flattened jsonld structure.
I first tried to solve it with pyld by flattening the input jsonld and comparing the flattened and original one but ran into the issue that pyld does not preserve key order in python dicts. Also, pyld was rather slow.
Right now, the check instead goes through all entities in the graph and fails if a nested dict has more properties than an id.

@dnlbauer Thank you for your contribution


Add kubeadm support for test/e2e/local

Add kubeadm support for test/e2e/local. Currently, this PR only covers debian/ubuntu platform.
Fixes: #8167
NOTE: This PR only works for debian platform and will support MacOS and CentOS in follow-ups.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebastienvas
If they are not already assigned, you can assign the PR to them by writing /assign @sebastienvas in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @m1093782566. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kimikowang
If they are not already assigned, you can assign the PR to them by writing /assign @kimikowang in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m1093782566: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
8f835e4c3cb1b4e09391bd652c4ec436fdc8b139
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This PR is ready for review now!
/assign @hklai @sdake @nmittler @rshriram

@m1093782566: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
6b1d9e33a84b6a379d1e7807974e0cd6cc1e5556
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram
Definitely make sense! I will send another PR soon.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai
If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

is this PR still valid? if so, could you fix the lint?

@rshriram
Yes, I pushed an update. Please take a look when you have time. THANKS!

@m1093782566 looks pretty good.  As followup work I'd highly suggest changing the port from 5000 for the registry to some other port (such as 4500).  Many individuals run a registry using defaults (which default to port 5000) and are sure to be surprised when their images disappear in the xargs docker rmi operation.
Cheers
/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sdake
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai
If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @hklai

@sdake

As followup work I'd highly suggest changing the port from 5000 for the registry to some other port (such as 4500).

I will look into that.
@hklai

Any plan to add Mac support too?

Sure!

This PR broke shellcheck test, which now is Required test.

Will this be reverted due to breaking shellcheck?


typesql_parser maintainer

Hi.
wanted to ask some question about this package from pub.dev: https://pub.dev/packages/typesql_parser

Hi thanks for the issue.
Yes, you can send the question through this repo. I may be able to help you.

First thing first - Where is the repo for this package? I cant find it.
The second question is that I understand this is a wrapper on other rust package.
So I wanted to understand how it works. I wanted to see the src code(in github) - so this is connected to the first question.
Anyway I checked my local files of the package and saw that you using wasm module(super cool).
So the third question is that the reason(using wasm module) that the createTypesqlParser is async?

All the directories for each package in the repo are presented in the readme. The typesql_parser source code can be found in the /packages/wasm_packages/typesql_parser directory and the Rust implementation is within the typesql_parser_wasm directory.
That's right, since the compilation of the wasm module may take some time it's better to make it async.

Thanks for your great questions, and sorry there aren't many docs about the package.
The visitor implementation is exposed within the /lib/visitor.dart file and an usage example is the DependenciesVisitor class in the typesql package.

Cool. Could you provide me with a simple example of how to use it?

I see you started to implement typesql_generator
I see its not finished. Am I right?
I am trying to build a generator too. Like sqlc package in golang(But maybe better :))

You can try it out and let me know what you think, it's on pub.dev. I believe it supports most primitives and even JSON. If there is something missing you may create an issue or open a PR.

Hmm...
Right now its generating me code with errors. For example:
-- name: complexQuery :many
select employee_id, name, department_id, salary
from employees
where
    (department_id = ? or ? is null)
    and (salary >= ? or ? is null)
    and (hire_date between ? and ? or (? is null and ? is null))
    and (skills->>? = ? OR ? IS NULL)
ORDER BY
    CASE WHEN ? = 'salary' THEN salary END DESC,
    CASE WHEN ? = 'hire_date' THEN hire_date END DESC
LIMIT ? OFFSET ?;

-- name: getUsersByStatus :many
select * from users
where status = ?;

-- name: insertNewUser :exec
insert into users (name, email, status)
values (?, ?, ?);

-- name: getUsersByIds :many
select * from users
where id in (?, ?, ?);

-- name: getUsersByAgeRange :many
select * from users
where age between ? and ?;

-- name: getLimitedUsers :many
select * from users
LIMIT ? offset ?;

-- name: getGroupsByCount :many
select status, count(*)
from users
group by status
having count(*) > ?;

-- name: orderUsersByColumn :many
select * from users
order by ? asc;

Maybe I am using it the wrong way? Tried to delete the comments in this file too with same result.

I believe the error could be due to the name property. You have to configure it as a JSON like the example.
Is there an error? Or perhaps you could provide the generated dart code?

You will also need to provide the CREATE TABLE SQL statements within the .sql file, otherwise the generator will not know which tables and views are available, and their types.


Re-order of the panels button.

Hi,. I use this grapesjs-present-newsletter preset. Is there a possible to organize its panels button possition?
Just like i want to merge the undo and redo button on the other buttons on the right side.?

Hi Mark,
you can make use of Panels API or yet simpler, being flex children, you can use CSS order property

the link Panels api is no longer exists? Can you update its?


Think about making the AutoBindable an Attribute for the class, so you do not need a placeholder field

This :
    [AutoBindable("Header", typeof(string))] // c#10
    [AutoBindable<string>("Header")] // with C#11 generic attributes feature
    public partial class CustomEntry : ContentView
    {
    }

Instead of this:
    public partial class CustomEntry : ContentView
    {
        [AutoBindable]
        private readonly string _placeholder;
    }

Advantage:

no unnecessary field is needed; in this sense it is more clean

Downside:

it is a breaking change, which forces devs to adjust their code

How do you think if the generator will base on the handler methods?
e.g.
// ControlX.properties.cs
partial class ControlX {
    [AutoBindable<bool>]
     private static void HandlePropertyXChanged(BindableObject obj, object oldValue, object newValue) {}

     private static void HandlePropertyXChanging(BindableObject obj, object oldValue, object newValue) {}

    [AutoBindable<string>()]
     private static void HandlePropertyYChanging(BindableObject obj, object oldValue, object newValue) {}
}

The generator will generate
// ControlX.g.cs
partial class ControlX {
    public static BindableProperty PropertyXProperty = BindableProperty.Create(
        nameof(PropertyX),
        typeof(ControlX),
        typeof(bool),
        true,
        propertyChanged: HandlePropertyXChanged,
        propertyChanging: HandlePropertyXChanging
    );
    public bool PropertyX {
        get => (bool)GetValue(PropertyXProperty);
        get => SetValue(PropertyXProperty, value);
    }

    public static BindableProperty PropertyYProperty = BindableProperty.Create(
        nameof(PropertyY),
        typeof(ControlX),
        typeof(bool),
        default,
        propertyChanging: HandlePropertyYChanging
    );
    public bool PropertyY {
        get => (bool)GetValue(PropertyYProperty);
        get => SetValue(PropertyYProperty, value);
    }
}

And we should remove MAUI dependency because with .NET6, we can use global usings for namespaces in generated code

The best place for these would be on a partial property, once C# 13 adoption is high enough.


Error 404 On Deployment of NodeJS app

I have deployed a 'Hello World' Windows NodeJS app through the Azure App Service in VSCode. The output of Azure App Service suggests that the deployment was successfull. However, when you go on the website, a 404 error is returnedd by the browser. Here is the output of Azure App Service in VSCode:
13:08:09 JA-6MP-Portfolio2: Creating zip package...
13:08:17 JA-6MP-Portfolio2: Starting deployment...
13:08:22 JA-6MP-Portfolio2: Fetching changes.
13:08:22 JA-6MP-Portfolio2: Cleaning up temp folders from previous zip deployments and extracting pushed zip file D:\local\Temp\zipdeploy\meyykuaq.zip (4.39 MB) to D:\local\Temp\zipdeploy\extracted
13:08:35 JA-6MP-Portfolio2: Waiting for long running command to finish...
13:08:36 JA-6MP-Portfolio2: Updating submodules.
13:08:36 JA-6MP-Portfolio2: Preparing deployment for commit id '5825a2c9d7'.
13:08:36 JA-6MP-Portfolio2: Generating deployment script.
13:08:36 JA-6MP-Portfolio2: Using cached version of deployment script (command: 'azure -y --no-dot-deployment -r "D:\local\Temp\zipdeploy\extracted" -o "D:\home\site\deployments\tools" --basic --sitePath "D:\local\Temp\zipdeploy\extracted"').
13:08:36 JA-6MP-Portfolio2: Running deployment command...
13:08:36 JA-6MP-Portfolio2: Command: "D:\home\site\deployments\tools\deploy.cmd"
13:08:38 JA-6MP-Portfolio2: Handling Basic Web Site deployment.
13:08:40 JA-6MP-Portfolio2: Creating app_offline.htm
13:08:40 JA-6MP-Portfolio2: KuduSync.NET from: 'D:\local\Temp\zipdeploy\extracted' to: 'D:\home\site\wwwroot'
13:08:40 JA-6MP-Portfolio2: Copying file: '.vscode\settings.json'
13:08:40 JA-6MP-Portfolio2: Deleting app_offline.htm
13:08:40 JA-6MP-Portfolio2: Finished successfully.
13:08:40 JA-6MP-Portfolio2: Running post deployment command(s)...
13:08:40 JA-6MP-Portfolio2: Triggering recycle (preview mode disabled).
13:08:40 JA-6MP-Portfolio2: Deployment successful.
13:08:43: Deployment to "JA-6MP-Portfolio2" completed.

Below is the image of the workspace

The simple app works as expected when trialing on localhost, so I'm struggling to see immediately what has caused this error to occur.

Hi @JoshAnderson123
Sorry you're running into so many issues 😦 Hopefully we can resolve this.
Could you verify that you are creating a Linux Node app?  If you click the blue deploy arrow, there should be a + Create new Web App... (Advanced) option.  From there, you can manually select the OS and the runtime.
Could you also send me a screenshot of your workspace?

Hi @nturinski
Thanks for getting back to me. This app, unlike the deployment to Linux in #1267 is a Windows Node app. I have updated #1270 to clarify this. Would you suggest changing the OS to Linux? I have also added a screenshot of the workspace to #1270

Yeah, I think for Node.js development, we tend to recommend running Linux OS. I'd recommend giving that a shot!


Edit border radius on control bar

Is is possible to set the border radius to be zero on the top/bottom edge of the controls? I'm using this inside a scaffold with an app bar and the rounded edge looks bad underneath the app bar.


Missing Native Module files in Published package

Since package.json has
 "files": [
    "lib"
  ],

it only takes the files from lib folder for the package published on the npm. So when someone tries to install via npm/yarn, the native modules are missing in the node_modules and if they call the exposed apis, they fail due to lack native modules.
Please address this issue asap.

@Ananthakr Thanks for reporting this issue. A new version 2.0.1 is released with the fix.
Closing issue.

@Ananthakr Thanks for reporting this issue. A new version 2.0.1 is released with the fix.
Closing issue.


Move global settings out of GaLatexPrinter

The sympy way is to store these in a per-instance _settings dict.
This patch makes the assumption that the attributes of GaLatexPrinter were not public API, and that user code should only be accessing them through Format.
This means that the galgebra printer now respects the inv_trig_style argument to sympy.init_printing.

Coverage isn't great, but that's because this module is full of unused code.
The inv_trig_style stuff, while not covered, is now a little closer to sympy than it was before.


CB-17554 Postgres upgrade implementation for GCP provider

CB-17554 Postgres upgrade implementation for GCP provider

Thanks, @schfeca75 , I have one pending ask for you.


[GLUTEN-6920][CORE] Move trait GlutenPlan to gluten-core

Part of #6920
TBD

Run Gluten Clickhouse CI on x86


Improved content for Tutorial 1 (QAMP fall'22)

Summary
Enhancing the documentation of Tutorial "01_neural_networks" as a mentee for QAMP 2022.
Mentor: @ElePT
Mentee: @SanyaNanda
Details and comments

Restructured the notebook (Objective, Introduction, Tutorial and what was learned)
Imports placed where required
Added Detailed Explanations for OpflowQNN, TwoLayerQNN and CircuitQNN like steps to follow when constructing the neural network etc using the API reference
Inline comments for better understanding of the code and arguments used in function
Hyperlinks to API references wherever required

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @SanyaNanda , thank you for the tutorial.
Before commiting code/tutorials, we run make black that reformats the code/tutorials against some standard rules. I ran it against your tutorial.
Also, we don't use custom kernels in tutorials as they will be run automatically by the CI and by other people that won't have them.  I removed the custom kernel and used the Python3.

Hi @manoelmarques
Thankyou for the guidance, will keep these points in mind for future commits

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.616%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3028

Relevant Lines:
3456

💛  - Coveralls

Thanks for taking care of this. The 01 tutorial was significantly changed. Could you please merge your work with the latest version of the tutorial? I can help if you have issues.

Thank you! I will do this and get in touch in case of queries


NIFI-4210: Add support for OpenId Connect

NIFI-4210:

Introducing support for OpenId Connect.
Updating REST API and UI to support the authorization code flow.

Reviewing...

I'm still reviewing. I have this working very well with Google being the IdP. One thing I have noticed in the nifi-user.log is that the token is logged at INFO level on every request. I believe this is from NiFiAuthenticationFilter:174 (line 53 also prints the token). I think these lines should be fixed -- I understand wanting to print the incoming information to help with debugging, but I don't think the raw token should be printed here, so there should be some control logic or the #toString() method should be overridden.
2017-08-08 19:21:18,784 INFO [NiFi Web Server-18] o.a.n.w.s.NiFiAuthenticationFilter Attempting request for (eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJhbG9wcmVzdG8uYXBhY2hlQGdtYWlsLmNvbSIsImlzcyI6Imh0dHBzOi8vYWNjb3VudHMuZ29vZ2xlLmNvbSIsImF1ZCI6Imh0dHBzOi8vYWNjb3VudHMuZ29vZ2xlLmNvbSIsInByZWZlcnJlZF91c2VybmFtZSI6ImFsb3ByZXN0by5hcGFjaGVAZ21haWwuY29tIiwia2lkIjoxLCJleHAiOjE1MDIyNDg4NzcsImlhdCI6MTUwMjI0NTI3OH0.hHb4zJljXgv9ja_x46nFjxkYAXgGmuPXtJEm44Mrxj4) GET https://localhost:9443/nifi-api/flow/current-user (source ip: <IP_ADDRESS>)
2017-08-08 19:21:18,839 INFO [NiFi Web Server-18] o.a.n.w.s.NiFiAuthenticationFilter Authentication success for<EMAIL_ADDRESS>2017-08-08 19:21:18,918 INFO [NiFi Web Server-84] o.a.n.w.s.NiFiAuthenticationFilter Attempting request for (eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJhbG9wcmVzdG8uYXBhY2hlQGdtYWlsLmNvbSIsImlzcyI6Imh0dHBzOi8vYWNjb3VudHMuZ29vZ2xlLmNvbSIsImF1ZCI6Imh0dHBzOi8vYWNjb3VudHMuZ29vZ2xlLmNvbSIsInByZWZlcnJlZF91c2VybmFtZSI6ImFsb3ByZXN0by5hcGFjaGVAZ21haWwuY29tIiwia2lkIjoxLCJleHAiOjE1MDIyNDg4NzcsImlhdCI6MTUwMjI0NTI3OH0.hHb4zJljXgv9ja_x46nFjxkYAXgGmuPXtJEm44Mrxj4) GET https://localhost:9443/nifi-api/flow/client-id (source ip: <IP_ADDRESS>)
2017-08-08 19:21:18,920 INFO [NiFi Web Server-84] o.a.n.w.s.NiFiAuthenticationFilter Authentication success for<EMAIL_ADDRESS>

@alopresto This is not something that was introduced in this PR though I am happy to address it here. Will push a new commit shortly. Thanks!

I continued reviewing with a custom IdP from Auth0. This provider can integrate with other providers, including Google, Facebook, etc. and also have its own custom users stored locally. @mcgilman and I were able to receive a success response from Auth0 for a custom user, but the token signature could not be validated. We traced this to determine that on startup, when the TokenValidator is initialized, if no nifi.security.user.oidc.preferred.jwsalgorithm is present in nifi.properties, the first value of id_token_signing_alg_values_supported in the response from the OpenID Connect Discovery Document URI is used. In Auth0's case, this was HS256 as opposed to RS256, but the tokens returned were signed with RS256, resulting in NiFi returning an error "Unable to exchange authorization for ID token: Unable to parse the response from the Token request: Signed JWT rejected: Another algorithm expected, or no matching key(s) found".
The Auth0 OIDC Discovery Document response:
{"issuer":"https://apachenifi.auth0.com/","authorization_endpoint":"https://apachenifi.auth0.com/authorize","token_endpoint":"https://apachenifi.auth0.com/oauth/token","userinfo_endpoint":"https://apachenifi.auth0.com/userinfo","mfa_challenge_endpoint":"https://apachenifi.auth0.com/mfa/challenge","jwks_uri":"https://apachenifi.auth0.com/.well-known/jwks.json","registration_endpoint":"https://apachenifi.auth0.com/oidc/register","scopes_supported":["openid","profile","offline_access","name","given_name","family_name","nickname","email","email_verified","picture","created_at","identities","phone","address"],"response_types_supported":["code","token","id_token","code token","code id_token","token id_token","code token id_token"],"response_modes_supported":["query","fragment","form_post"],"subject_types_supported":["public"],"id_token_signing_alg_values_supported":["HS256","RS256"],"token_endpoint_auth_methods_supported":["client_secret_basic","client_secret_post"],"claims_supported":["aud","auth_time","created_at","email","email_verified","exp","family_name","given_name","iat","identities","iss","name","nickname","phone_number","picture","sub"]}

We decided to change the initialization logic to default to RS256 as it is required by the OpenID Connect Specification to always be present in this response.

id_token_signing_alg_values_supported
REQUIRED. JSON array containing a list of the JWS signing algorithms (alg values) supported by the OP for the ID Token to encode the Claims in a JWT [JWT]. The algorithm RS256 MUST be included. The value none MAY be supported, but MUST NOT be used unless the Response Type used returns no ID Token from the Authorization Endpoint (such as when using the Authorization Code Flow).

I manually provided RS256 as a configuration value for nifi.security.user.oidc.preferred.jwsalgorithm in nifi.properties and was able to successfully sign in as the user.

Ran contrib-check and all tests pass. +1, merging.

Hi,
According to [this merged PR] (https://github.com/apache/nifi-registry/pull/296), Nifi Registry has support for open id connect. I had check the documentation but I don't see nothing about this. I have download the latest version and I see the properties in nifi-registry.properties file. I fill the oidc properties but nothing works.
Nifi Registry supports OIDC auth?
Regards


Crash on location permission

From the readme:

You must set these Info.plist keys for location to work

Use NSLocationAlwaysUsageDescription or NSLocationWhenInUseUsageDescription where appropriate for your app usage. You can specify which of these location permissions you wish to request with .LocationAlways or .LocationInUse while configuring PermissionScope.

As the assert message says, you need to set up the proper keys.


Mark spotify song as favorite

What version of Music Assistant has the issue?
2.0.0b106
What version of the Home Assistant Integration have you got installed?
2024.2.0
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
When I am showing the infos of a song in Music Assistant and press the heart button on the UI to mark it as favorite it is not marked as favorite in spotify.
How to reproduce
Go to the infos of a song.
Klick on the heart button.
Check spotify in Android App or web UI of spotify.
It is still not marked as favorite
Music Providers
Spotify
Player Providers
Spotify
Relevant log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.2.5
What type of installation are you running?
Home Assistant Supervised
On what type of hardware are you running?
Raspberry Pi

Go to the infos of a song.

What do you mean by this? Where are you finding this song? Is it in your library, is it on the global search page? Is the track actually on Spotify?

We will close this soon due to no followup


How do I use different port for console?

Is there a way to provide a different port to use for console communication then for flashing the binary?
I am using an Adruino Leonarado and have a CP2102 USB to UART Bridge connected to pins d0 and d1.
I am able to get either loading/running the target or viewing the console output, but I wasn't able to tell if there was away to specify a different port for each as ideally i'd like it to run with console output when running 'cargo run'

Hi,
I assume you are referencing ravedude here?  If so, then unfortunately this is not really supported right now... I usually get by with opening a second instance of ravedude or any other terminal emulator on the USB-UART tty and having the ravedude command in the cargo config only performing the firmware flashing.
Now we could add support for "split serial for comms & flashing" to ravedude but in the long run I don't think this is a very common usecase.  The real solution here is to implement USB CDC-ACM in avr-hal so we get serial comms over USB, just like the Arduino C core is doing it.  At that point, the second UART-USB converter becomes unnecessary.


New version: Scilab.Scilab version 2024.0.0

Description

Resolve https://github.com/microsoft/winget-pkgs/issues/129130

Checks

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @Dragon1573,
This manifest adds Apps and Featues entries that aren't present in previous PR versions. Should these entries be added to the previous versions also?

Hi @Dragon1573,
Should these entries be added to the previous versions also?

Maybe we should? I'll take this task today night. :smile:


Event Ordering for Passage link handler

Currently, attaching an event to the 'click' event for links works in a non intuitive way-
(Specifically, what I'm doing is rendering the next passage differently based on if the link is clicked while shift is down or not)
Unfortunately, when I attach my click event, it only fires after the new passage is already rendered, preventing the new passage from using said information.
This is because events fire in the order that they were attached, and snowman attaches it's events first(before loading the story javascript). If this click event could be moved till after the story javascrit is evaled, then things would work as intuitively expected.
Currently I've gotten it to work for my code by the following(less than optimal) hack:
 //Disable Snowman's default click event // This is needed so that if you add a click event they happen first // (instead of firing after the new passage has already been loaded) $("tw-story").off( 'click', 'a[data-passage]');
my click handling code
//Restore Snowman's default click event // So that your event fires, then the default one // This code is copied directly from snowman's source $("tw-story").on('click', 'a[data-passage]', function (e) { 			window.story.show(_.unescape( 				$(e.target).closest('[data-passage]').data('passage') 			)); 		});

This fix has currently been added. It is part of 2.0.3 now.

Merged into main branch.


Suggestion: Stays at draft page after "Save and Exit" on Composer

Suggestion from our client about post-behavior after you Save and Exit on composer.
Current Behavior

Login to the c5 site
Browse whatever pages.
You create a new page as a draft in composer
Click "Save and Exit" button
The editor gets redirected to the previous page on c5 site before clicking to create a new page

Why troublesome?

Sometime, you want to preview on a actual page after editing on the composer.

Some blocks are not visible while edit mode.
Such as Image Slider, Google Map.
You want to preview.

Right now, if you want to preview the page after "Save and Exit" the editor has to go back to the page again. It's troublesome.

** We are wondering why it's behaving like this at the moment.
Suggestion to change the post Save and Exit behavior to stays at the exact draft page

Click "Save and Exit" button

c5 exist edit mode and stays on the draft page. The edit mode is off, and the pop-up window says this is draft page preview.

What do you guys think?
Thanks.

Sounds fine to me. What you're describing is basically the same as clicking "Edit Mode" – but it checks you out of editing the page, which makes sense.


vscode Extension with edge Problem

####OS Version:win10 x64
Hello Guys,
In vscode extension ,when I require npm package edge , I got some error ,So any help would be appreciated
In the beginning , I got a error as followed:
Activating extension `test` failed: %1 is not a valid Win32 application.
c:\Git\test\node_modules\edge\lib\native\win32\ia32\4.1.1\edge_nativeclr.node.
Activating extension `test` failed:  %1 is not a valid Win32 application.
c:\Git\test\node_modules\edge\lib\native\win32\ia32\4.1.1\edge_nativeclr.node
Here is the error stack:  Error: %1 is not a valid Win32 application.
c:\Git\test\node_modules\edge\lib\native\win32\ia32\4.1.1\edge_nativeclr.node
    at Error (native)
    at Object.module.(anonymous function) (ATOM_SHELL_ASAR.js:140:20)
    at Object.module.(anonymous function) [as .node] (ATOM_SHELL_ASAR.js:140:20)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.n._load (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\pluginHostProcess.js:20:23186)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (c:\Git\test\node_modules\edge\lib\edge.js:48:8)
    at Module._compile (module.js:434:26)

Then I drop the package and run  the command "npm install edge --arch=ia32" ,and then I got a error :
The specified module could not be found.
\\?\e:\Docfx\test\extensionTest\jscallTest\node_modules\edge\lib\native\win32\ia32\5.1.0\edge_nativeclr.node

and there are a error happen we I reinstall the package
Activating extension `jipe.jscall2` failed: Module did not self-register..
Activating extension `jipe.jscall2` failed:  Module did not self-register.
Here is the error stack:  Error: Module did not self-register.

Any guidance would be appreciated!

Please provide source code of minimal extension showing the issue, the version of VS Code, the way how you activated the extension (launching out of VS Code, side install, etc.).

I'm sorry I did not express clearly , the version of VS code is 0.11.0 , and I use the command "yo code" to generate a demo extension .Here is the package.json file
{
    "name": "jscall2",
    "displayName": "jscall2",
    "description": "call c# in js",
    "version": "0.0.1",
    "publisher": "jipe",
    "engines": {
        "vscode": "^1.0.0"
    },
    "categories": [
        "Other"
    ],
    "activationEvents": [
        "onCommand:extension.sayHello"
    ],
    "main": "./extension",
    "contributes": {
        "commands": [{
            "command": "extension.sayHello",
            "title": "Hello World"
        }]
    },
    "scripts": {
        "postinstall": "node ./node_modules/vscode/bin/install"
    },
    "dependencies": {
        "edge" : "^5.9.2"
    },
    "devDependencies": {
        "vscode": "^0.11.0"
    }
}

this is same as the vscode extension demo except the dependencies. and when I require the 'edge' and debug the process,I got a error

and it jump to to the Exception catch in the file module.js

Finally, I got a error as followed
Loading development extension at e:/Docfx/test/extensionTest/jscall2
Activating extension `jipe.jscall2` failed: Module did not self-register..
Activating extension `jipe.jscall2` failed:  Module did not self-register.
Here is the error stack:  Error: Module did not self-register.
    at Error (native)
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:158:20)
    at Object.Module._extensions..node (module.js:440:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:158:20)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.n._load (c:\Program Files (x86)\Microsoft VS Code\resources\app\out\vs\workbench\node\extensionHostProcess.js:11:29921)
    at Module.require (module.js:367:17)
    at require (internal/module.js:16:19)
    at Object.<anonymous> (e:\Docfx\test\extensionTest\jscall2\node_modules\edge\lib\edge.js:53:8)

Thanks!

And I use the module 'edge' because I want to call a C# dll in the extension write in JavaScript or Typescript ,so any help would be appreciated!!

Thanks @928PJY.  Having a simple project that does nothing else rather than loading edge everything works fine but loading the module in the extension host fails.
@jrieken  any opinions?

Yes  ,but I think it is maybe the problem of the module 'edge'  ,It has some C++ code in this module. I have change it to the 'electron-edge'  , and it works!
Thanks!

Yes - 'edge' is a native extension that is compiled against nodejs, not electron. To make it work with the latter you need a recompiled version


Added a mint check to the Withdraw function (#2061)

Fixed Issue #2061

Could probably be merged instantly, but wanted a quick glance


Add Memory Collection to Testing Harness

@malin1993ml says that the DBMS's RSS blows up in size when you load a small amount of data. AFAIK, we are not checking for memory usage in any of our experiments or testing right now.
We can start simple with this. We should implement a simple test scenario that loads in a bunch of data and measures the size of the process. It should get reported as part of the output in the nightly microbenchmark runs:
https://github.com/cmu-db/terrier/blob/master/script/micro_bench/run_micro_bench.py
This should then automatically get picked up by the dashboard in the lab. One potential problem is the current benchmark throws an error if these measurements decrease since they are measuring throughput. If we reduce memory consumption (which is a good thing), then it will throw an error.

Duplicate of #973


Investigate: Improving active layers state object & layer setup

In the last PR we added separate map layers for weekly and daily events, and a way to toggle their visibility.
An atom was created to provide some boolean state to toggle:
export const activeLayersAtom = atom<any>({
  daily: true,
  weekly: false,
});

This structure won't scale well, and it's already clunky to reference with activeLayers.[weekly/daily]
[ ] Do some investigation into other common patterns for this use-case
[ ] Update just the atom and its usage

While not too much different than the current, I think a nested dictionary structure could work for expanding the current layers and not be too bad in terms of scaling:
export const activeLayersAtom = atom<Record<string, Record<string, boolean>>>({
  daily: {
    'min': true,
    'med': true,
    'max': true,
  },
  weekly: {
    'min': true,
    'med': true,
    'max': true,
  },
});

Right now the nested layer options are the same between the two, providing an opportunity to use an enum, or an as const type so we can make sure each layer provides the same support:
const LAYER_TYPES = ['min', 'med', 'max'] as const;

Right now we're changing the active layers state in a hacky way - a helper function in the utils will make this safer:
const toggleLayerVisibility = (type: string, range: string) => {
  setActiveLayers((prevLayers) => ({
    ...prevLayers,
    [type]: {
      ...prevLayers[type],
      [range]: !prevLayers[type][range],
    },
  }));
};

This was addressed in the last merge - https://github.com/ash-bergs/earthquake-tracker/pull/29


Ci framework will be lost under the php7.1 session.

Ci framework will be lost under the php7.1 session.
Different controllers, session_id will be different.
$config['sess_driver'] = 'files';
In the php7.0. * Environment, there is no such problem.

No it won't.

Yes, I just finished testing

@narfbg Yes, I just finished testing

Well, if you believe you've found a problem - share the details with us.
Spooky-sounding titles like "CI framework will be lost" helps nobody.

I did some Xdebugging and found that session variables get forgotten between calls.
Windows 10 .This was between Apache 2.4.25 php 7.1.4 and 'CI_VERSION', '3.0.5'. I don' t know who is to blaim.
Two CI sites had same behaviour.
Settings ? PHP?CI? even XDebug??Apache?! I have no clue but then when I roll back to these:
php-5.6.30-Win32-VC11-x64
php_xdebug-2.5.1-5.6-vc11-x86_64.dll
everything seems to be back on the track.


Add asynquence to the Control flow section

Thanks for the suggestion, but I'm going to pass on this.


Firefox fails to parse site.css due to '*'

Hi,
I'm using zola v0.6.0 and just ran into an issue with after-dark. Caused by sass being minified:
https://github.com/getzola/after-dark/blob/master/sass/_vendor.scss#L5
which renders into:
html{font-size:12px}*{box-sizing:border-box;text-rendering:geometricPrecision} ...
Which can't be parsed by either Firefox or Chrome, unless space is inseted before '*'.
Note: This only affects zola build not serve since serve preserves line breaks.

Was cased by a wrong mime type configured in nginx


[Feature] Multiple safes support

Is your feature request related to a problem? Please describe.
When you want to import, let's say, a document in a safe full of photos, things quickly turn a bit messy. Not only the document you are looking for is buried amongst a pile of unrelated media, you also have to take your time to find it. It's incredibly annoying.
Describe the solution you'd like

When a safe is unlocked, make an option to create another safe in the settings tab.
Guide the user through the setup.
When the safes are locked and the user is shown the password screen, the password entered will open the said safe.

For example, if the user types the password for the document safe, the said safe opens. Same goes for any over safes created.
Also, when a user tries to reset a safe, only the unlocked one will be deleted, but not all of the others.
Describe alternatives you've considered
Using the work profile feature is a pain to navigate and  to utilise, so that's a no-go.
Additional context
Letting the user choose what safe to unlock not only will require the naming of every safe, but it's name might hint a malicious actor of what's inside.

This was already requested in #197
Feel free to add your thoughts there. I will close this as duplicate


Uncaught Error: Module did not self-register.

[Enter steps to reproduce:]

while downloading files from ftp using remote-ftp plugin
every type on the keyboard rasise error

Atom: 1.46.0 x64
Electron: 4.2.7
OS: Mac OS X 10.15.4
Thrown From: Atom Core
Stack Trace
Uncaught Error: Module did not self-register.
At ELECTRON_ASAR.js:160

Error: Module did not self-register.
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:160:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:722:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:169:18)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
    at Function.Module._load (internal/modules/cjs/loader.js:533:3)
    at Module.require (/app.asar/static/index.js:72:46)
    at require (internal/modules/cjs/helpers.js:20:18)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:1:695134)
    at get_KeyboardLayoutManager (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2778162)
    at get_manager (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2778264)
    at Object.getCurrentKeyboardLayout (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:2778390)
    at e.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:14:1081110)
    at KeymapManager.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:1253631)
    at KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:1251616)
    at WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:284744)

Commands
     -3:25.3.0 remote-ftp:download-selected (li.directory.entry.list-nested-item.collapsed.selected)
     -0:46 find-and-replace:show (input.hidden-input)
     -0:45.2.0 editor:consolidate-selections (input.hidden-input)
     -0:42.7.0 core:copy (input.hidden-input)
     -0:39.7.0 find-and-replace:show (input.hidden-input)
     -0:29.4.0 editor:consolidate-selections (input.hidden-input)
     -0:11.5.0 core:paste (button.btn)

Non-Core Packages
atom-beautify 0.33.4
atom-debug-ui 1.0.4
atom-ide-ui 0.13.0
autoclose-html 0.23.0
autoclose-html-plus 0.27.2
autocomplete-html-entities 0.2.0
busy-signal 2.0.1
docksend 1.3.0
git-plus 8.7.1
html-tag-auto-complete 0.1.1
hyperclick-php 0.3.0
ide-html 0.6.0
ide-php 0.7.18
intentions 1.1.5
linter 2.3.1
linter-php 1.6.1
linter-ui-default 1.8.1
php-cs-fixer 4.1.1
php-debug 0.3.5
remote-ftp 2.2.4
transmit 1.5.0

Seeing the same error while attempting to edit a Markdown doc.
Using Latest Atom:

This was working fine yesterday. Today it's unusable. 😞

Thanks for taking the time to contribute!
We noticed that this is a duplicate of https://github.com/atom/atom/issues/20222. You may want to subscribe there for updates.
Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Extend examples with transfer using the library

What would you like to be added:
Why is this needed:

Issue is about providing documentation to trigger transfers from Go code.
Starting point could be https://github.com/open-component-model/replication-controller/blob/main/pkg/ocm/ocm.go#L256
Related #186

This should have been fixed with #385 and #386. Please reopen if this does not satisfy your needs.


How to use UpdateAsync when CreateAsync not needed (so no "id" to use?)

Sorry if this is obvious to others but all the examples I can find for UpdateAsync() have it called after a CreateAsync() returns an "id" from the SuccessResponse. My question is ... how can we call UpdateAsync() if we don't have an "id" to feed the "string recordId" parameter?
To clarify via code:
--> CreateAsync() always returns a SuccessResponse with an "id" value:
Task<SuccessResponse> CreateAsync(string objectName, object record)
--> UpdateAsync() requires a recordId parameter but what do we use if we don't need to call CreateAsync() first? For example if we're updating a record in Salesforce that already exists so we don't need to create it. Where do we get the "id" for this call?
Task<SuccessResponse> UpdateAsync(string objectName, string recordId, object record)

Closing my own issue. I was confusing my custom object's Autonumber "Id" field with Salesforce's global object "Id". So I now know which "recordId" to use in UpdateAsync (the Salesforce global object id).


CreateAtomicRMW error C2660 during Windows 10 build.

When trying to build TVM on Windows (with VS 15 2017 and from-source-built LLVM 11.0.0), I encountered some errors in TVM\tvm\src\target\llvm\codegen_amdgpu.cc and ...\codegen_nvptx.cc.
Namely, I got error C2660: 'llvm::IRBuilderBase::CreateAtomicRMW': function does not take 4 arguments (twice in each file). When examing CreateAtomicRMW(), I notice that it's supposed to be passed a MaybeAlign parameter as well, which isn't in place here. When I add llvm::MaybeAlign::MaybeAlign() as a parameter to the in total 4 CreateAtomicRMW() calls, it compiles and seems to work.
My question now is, is this a TVM bug, or is it an issue on my side (perhaps a mismatch between TVM and LLVM version, or perhaps using a wrong compiler or not having support for the newest C++ version)?
If it's a bug, I propose to add llvm::MaybeAlign::MaybeAlign() (which defaults to undefined) to these 4 calls.

Yes please send a pr to fix build with llvm 11.


New manifest format results in Error: author is not a string

We updated our manifest to match the type being enforced here:
https://developer.chrome.com/docs/extensions/reference/manifest/author
We had to do this to upgrade to the new "@types/chrome": "^0.0.260" npm package (not sure if it was introduced in exactly this version, but somewhere between 254 and 260)
But this action seems to break with that new format:
Run cardinalby/webext-buildtools-chrome-webstore-upload-action@8db7a005529498d95d3e2e0166f6f4050d2b96a5
  with:
    zipFilePath: yomitan-chrome-dev.zip
    extensionId: ***
    apiAccessToken: ***
    waitForUploadCheckCount: 10
    waitForUploadCheckIntervalMs: 180000
info:    Manifest input is not set, reading from zip...
Error: Error: author is not a string

(I'm not sure where exactly that error is coming from, I wasn't able to find it via some GitHub searching...)

Hi! Try again from master or v1, I removed the unnecessary validations

It worked!! Thank you so much as always :pray:


Fix url to deployment script

fixing url to deploy.json:

from httpss to https
base uri to raw file is now different too

The change has been tested by executing a one-click automated deployment from this change: the resources has been deployed successfully along with all azure functions from this repository, functions and policies operate as expected


AttributeError: 'Requirement' object has no attribute 'project_name' for VCS requirements

safety version: 1.5.0
Python version: 2.7.6
Operating System: Ubuntu Trusty

Description
$SUBJ when there's a git requirement, like for example this:
-e git+https://github.com/jdunck/python-unicodecsv#egg=unicodecsv

Here's the traceback:
$  safety check -r requirements.txt
Traceback (most recent call last):
  File "/home/vagrant/build/venv/bin/safety", line 11, in <module>
    sys.exit(cli())
  File "/home/vagrant/build/venv/local/lib/python2.7/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/vagrant/build/venv/local/lib/python2.7/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/vagrant/build/venv/local/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/vagrant/build/venv/local/lib/python2.7/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/vagrant/build/venv/local/lib/python2.7/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/vagrant/build/venv/local/lib/python2.7/site-packages/safety/cli.py", line 55, in check
    vulns = safety.check(packages=packages, key=key, db_mirror=db, cached=cache, ignore_ids=ignore)
  File "/home/vagrant/build/venv/local/lib/python2.7/site-packages/safety/safety.py", line 132, in check
    for pkg in packages:
  File "/home/vagrant/build/venv/local/lib/python2.7/site-packages/safety/util.py", line 81, in read_requirements
    req=req.project_name),
AttributeError: 'Requirement' object has no attribute 'project_name'

Thanks for reporting. Fixed in https://github.com/pyupio/safety/commit/bf7cbd448d05a338d596c4eeb50ff0e324d74003
I've issued a new bugfix release: 1.5.1 should be available in a couple of minutes on PyPi. In the meantime, 1.4.1 should work.


AWS Recommends to extend CognitoAWSCredentials to cache IdentityID, but this is broken when using the CognitoExtensions library

Hello,
In this article AWS Recommends for .NET users to extend the CognitoAWSCredentials library in order to actually be able to cache the IdentityID properly, however, if you use the CognitoExtension library (or any Cognito function that returns CognitoAWSCredentials) to get your actual authenticated credentials, you're required to do a downcast that does not work with OOP.
Due to the natural structure of how Object Oriented Programming works, you are unable to downcast the CognitoAWSCredentials received into an extended class. And since some of the values within CognitoAWSCredentials are read-only, you cannot create a conversion function.
Are there any workarounds for this for the time being? It seems that the only way for this to actually get fixed is for the AWS .NET SDK to handle it's own caching, and not rely upon the user to do so.
-- Edit --
The only guidance I've found in AWS documentation to perform Cognito Identity Pool authentication using Cognito User Pools is on this page, however this only covers anonymous/unauthenticated credentials. Additionally, AWS's CognitoExtensions library is the only place I've found that gives an example of retrieving the CognitoAWSCredentials for authenticated users (completely different IAM Roles associated with authenticated users)

Hi @17kisern,
Good morning.
Thanks for posting the guidance question. Could you please share your use case? I would need to do some research on caching the IdentityID and would let you know if I find something.
Thanks,
Ashish

Hey @ashishdhingra,
My use case is utilizing AWS' .NET SDK within Unity (that has it's own peculiarities, despite conforming to the .NET standard, this other ticket has more info regarding that, but I don't believe that would affect this OOP issue).
I use Cognito User Pools to facilitate user accounts (users), with Cognito Identity Pools (identities) to handle distribution/connection of the appropriate IAM roles to Unauthenticated(anonymous) and Authenticated(logged in) users accordingly.
To perform the actual Authentication, I am using the AWS provided library CognitoExtensions. In order to get authenticated credentials, I follow the use case outlined in the "Authenticating with Different Levels of Authentication" subsection of the ReadMe tied to that CognitoExtensions Git Repo, in which a call is made to GetCognitoAWSCredentials() and returns a CognitoAWSCredentials object.
From what I can tell, .NET is one of the only AWS SDKs that requires the developer (me) to override this class in order to support caching of the IdentityID, while other SDKs handle this natively within that class (CognitoAWSCredentials). The reason caching of this IdentityID is necessary, is because if it is not cached, the number of "Total Identities" created within a Cognito Identity Pool skyrockets, making an entirely new identity every single time anonymous credentials are created, regardless of if it's the same machine. This problem because readily apparent in Unity, as a new anonymous Identity was created every single time my code re-compiled.

Hi @17kisern,
Upon further investigating, the article Caching Amazon Cognito Identity IDs talks about using Amazon Cognito Credentials Provider for caching IDs. There is an article Amazon Cognito Credentials Provider which shows on how to use credentials provider. I don't think you would be able to use the extended credentials class with Amazon Cognito Authentication Extension Library which just simplifies the Cognito authentication process. Once you get the access token from the extensions library, you can construct the extended CognitoAWSCredentials object to add access token via AddLogin method.
I'm not sure if this helps, but as of now, I don't have complete example which I could share and didn't test if it really works.
Thanks,
Ashish

Hey @ashishdhingra,
I was able to get it working using the links you provided (thank you! :D), for anybody else who runs into the same problem,
if you want to include caching with the .NET SDK, you must extend the CognitoAWSCredentials class! Doing so will make it so you can't call functions that return CognitoAWSCredentials, however, you can still get federated identities (using Cognito Identity Pools) (and in extension, IAM Roles determined by Identity Pool's RBAC; In my case, Unauth, Auth, and then a User Pool Admin group that gets picked up by a rule in the Identity Pool configuration) by manually plugging in a login provider and associated ID TOKEN (Access Token is the wrong token for this)
Here is sample code that I am currently using, hopefully it'll save someone a few weeks.
`        public static async void LoginUserPass(string username, string password)
{
        Debug.Log("Logging in using User/Pass");

        #region Configure Authentication Parameters

        CognitoUserPool userPool = new CognitoUserPool(
            CognitoConfig.userPoolId,
            CognitoConfig.appClientId,
            cognitoIdentityProviderClient
            );

        CognitoUser user = new CognitoUser(
            username,
            CognitoConfig.appClientId,
            userPool,
            cognitoIdentityProviderClient
            );

        InitiateSrpAuthRequest authRequest = new InitiateSrpAuthRequest()
        {
            Password = password
        };

        #endregion

        #region Actually perform the authentication

        try
        {
            AuthFlowResponse authResponse = await user.StartWithSrpAuthAsync(authRequest).ConfigureAwait(false);

            // Loading our User's Info - Irrelevant to the authentication process. This is a function I created to get User Attributes and translate them to a custom class I have
            activeUser = await GetUser(authResponse.AuthenticationResult.AccessToken, authResponse.AuthenticationResult.RefreshToken);
            Debug.Log("Loaded User: " + activeUser.username + " [" + activeUser.userID + "]");

            // // Got rid of this, because it doesn't work with extended class CognitoAWSCredentials
            // cognitoCredentials = user.GetCognitoAWSCredentials(CognitoConfig.identityPool, region);

            // Configuring CognitoAWSCredentials to know that it can pull credentials using the Access Token given by our Cognito IdentityPool
            string provider = "cognito-idp." + region.SystemName + ".amazonaws.com/" + CognitoConfig.userPoolId;
            cognitoCredentials.AddLogin(provider, authResponse.AuthenticationResult.IdToken);`

Hi @17kisern,
Thanks for your response and documenting your findings in this issue. This would be helpful for other users in the community. Closing this issue.
Regards,
Ashish


Importing work items with direct link via .csv/ .xlsx file

How to import work items with direct link? E.g. import a bug with linked test case ( by id/ name)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4296d1cc-f211-9d17-d97f-2b0858fdea7d
Version Independent ID: cc66dfee-adde-cdfb-b3f5-5d58d89d3c81
Content: Import or update work items from a CSV file - Azure Boards
Content Source: docs/boards/queries/import-work-items-from-csv.md
Product: devops
Technology: devops-agile
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

The microsoft docs (https://docs.microsoft.com/en-us/azure/devops/boards/queries/import-work-items-from-csv?view=azure-devops) mention about importing work itmes with parent - child relationship. I need to import bug and associate it with test case id/ name (direct link relationship). E.g. In .csv file I can mention bug title in one column and associated test case id/ name in other. Then I should be able to upload csv file, and test case should be automatically linked to bug after upload.

Also would be great if we can import screenshots from CSV to bug

@SandeepDhamale19 - Similar to importing work items with Excel, only parent-child relationships are supported. No direct link relationships are supported for import or update.  Please see this Q&A for info on import or update of work and test items: https://docs.microsoft.com/en-us/azure/devops/boards/backlogs/office/faqs?view=azure-devops#work-with-test-work-items.
Also, you might consider suggesting this feature or upvoting a feature for import of direct link relationships. See https://developercommunity.visualstudio.com/content/idea/post.html?space=21.


Create README.md

@Julexar I went ahead and merged your script PR's, but just so you're aware there were a few issues with them that I fixed which you'll have to look out for going forward:

A version of the main .js file for your script must be available in a sub-folder that corresponds to the version key specified in your script.json. So since you said the version was "0.8c", I created a "0.8c" subfolder and added your down.js file to it. Going forward, you can also create a new subfolder for each version of your previousversions key - that will correspond to the version dropdown users can select in their game.
Your script.json was invalid json as it contained an extra comma at the end. It needs to be valid json or it can screw things up with our system. I would run your json through a validator if you can - here's an example of one: https://jsonlint.com/.

Thanks - excited to see your next script!