Docker Method: Client Setup Instructions. API key required?

Sorry I'm very lost.  I'm here because I want to use Wakatime and keep everything local (at least for now... I'd consider a remote if I were given Proton-reputation-level privacy assurances).
I followed the Docker instructions, but the setup instructions broke down for me at the required Client Setup when being instructed to create ~/.wakatime.cfg.  I'm prompted for an API key which doesn't seem related to the Docker setup (if it is, I never received/generated one).
Next and finally, even with an api key I'm not sure what I should be doing because after Client Setup phase the instructions either seem to end or digress into the long config readout, something about generating docs, or pointers to outside packages for rendering the stats... That's what I thought I the instructions were leading to: "Fancy statistics and plots" and "Self Hosted".  What steps would I take to accomplish this? picking up where I left off from Docker Installed, touch ~/.wakatime.cfg
I hope I can get this off the ground, I'm really excited to track my stats

You'll need to visit the web interface of Wakapi, which if you follow Option 3: Use Docker will be at http://localhost:3000.
Then, you'll need to register a user, and view the API key (at top right, profile icon), before placing it into .wakatime.cfg.
Finally, install the corresponding Wakatime plugin for your editor and it should start tracking time.

Thank you.  I was late and I wasn't thinking it through. I might submit a PR to make everything explicit though


replace azure-chaos-fn with platform-chaos in readme and extensions #29

Description

Checklist for success

[ ] This change isn't already implemented by a pending pull request
[ ] This change is a child commit of a reasonably recent commit in the master branch

Requests need not be a single commit, but should be a linear sequence of commits (i.e. no merge commits in your PR)

[ ] All tests pass locally (see the testing section for more info)
[ ] All New behaviors or major functional changes have tests

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kraftman sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Load forward rules from appsettings.json

To forward emails the server needs to load forward rules from somewhere. To start with use appsettings.json.

Done and also added support for loading them from docker.


Added the ability to create custom mailer argument serializers

Updated the README to document the usage a bit.

@zapnap What do you think about this now? Would you merge it if I resolved conflicts and opened a new PR?


Use trait 🪄🪄 to allow different result types in ibc_packet_receive

With this, ibc_packet_receive users can decide to either reuurn a Result or IbcResult

As discussed, we use a different path documented in https://github.com/CosmWasm/cosmwasm/pull/1646


More metrics

Adding some more metrics to Prometheus.
Total Number of requests
Total Number of input tokens
Total Number of output tokens
Avg time per output token
Max time per output token
Avg time per input token
Max time per input token
It is useful to have avg time per output token, in order to make sure server is generating at reasonable speed and the batch size is not too large

@WoosukKwon can you take a look

@simon-mo Can you take a look?

Closing this as stale because some of these were added in #2316 and we no longer use aioprometheus as of #2730


pull request for e2e test at 01/23/2017 12:56:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update connection-twitter.md

Fix typo

Thank you for finding the doc error, it's fixed through an internal PR with rest of the miscellaneous changes; and the topic will reflect the changes soon. Closing this PR without merging.


mapview android phone crashes after adding library kivy.garden.mapview

I'm developing an application, which uses kivy garden map view. After importing library "kivy.garden.mapview" to my "main.py" file, I deploy my application on my Samsung Galaxy S5 with 4.2.2 android installed. When I try to run the app, after deployment - my phone crashes, and it reboots automaticly. Unfortunetely I'm unable to post a logcat from that crash. After reboot it is possible for me run the app (the loadscreen appears), after few seconds it also crashes.
Bellow I post my logcat which is saying that my urllib3 is missing. But the fun thing is, I've imported requests to my buildozer.spec (I`ve even tried to import urllib3 also).
http://pastebin.com/rcy31LeU

I was having the issue (not reboot) about urllib3. It appear that requests is actually messing up with the import system. The real issue is urllib3 cannot import _ssl, so it fail.
Ie: you need to add openssl into the requirements in your buildozer.spec


7.1 Certificate issue

I have the following section in applicationmanifest.xml
  <Certificates>
    <EndpointCertificate X509StoreName="MY" X509FindValue="[X509Thumbprint]" Name="my_api_cert" />
  </Certificates>

When debugging locally on a machine with SF 7.0, the above did not cause a problem. When that machine got upgraded to SF 7.1 my app hangs on startup. None of the services even make it to Main(). Furthermore, no errors get logged anywhere. When I remove the section, everything starts up normally. So my question is, has something changed in regards to certificate loading / handling in the 7.1 release? Thanks.

Exactly the same problem here.
The error message in Service Fabric Explorer is:
'System.Hosting' reported Error for property 'Activation:1.0'.
There was an error during activation.Failed to configure certificate permissions. Error FABRIC_E_INVALID_X509_THUMBPRINT.
Is there any way to get around this issue?

Same issue. It worked before, now I updated to SF 7.1 and it doesn't start. @operationslazlo326  did you find a fix?

Hi, I've upgraded my Local Cluster to v7.1.416.9590 and the problem is gone.


fix Lua5.2 compatible for lcurses.

I had build only lcurses with pdcurses on Windows, and found that something broken Lua 5.2, some as lua_strlen (changed to lua_rawlen), and luaL_register (changed to luaL_newlib), and I modified curses.lua to compatible with 5.2's module system.

I'm sorry, you've already done what I requested!

Closed, as pushed by me with slight mod.


Replace deprecated self.assertEquals with self.assertEqual

If you run test-backend, with Django 1.10, we now get tons of these warnings.
/home/tabbott/zulip/zerver/tests/test_upload.py:582: DeprecationWarning: Please use assertEqual instead.
self.assertEquals(sanitize_name(u'tarball.tar.gz'), u'tarball.tar.gz')
We should be able to clean them up pretty quickly with git grep and sed -i.

This one is sufficiently spammy I'm just going to fix it right now.


Don't modify EncodedString::REPLACE in place.

I discovered this when looking into #163, though it doesn't fix the problem described in said issue just yet.

Good catch...I forgot force_encoding modifies the string in place.  It's too bad there's not force_encoding and force_encoding! to force you to explicitly opt-in to mutation :(.


[SMP-2311] SMP 0.11.0 release notes

SMP 0.11.0 release notes
For reviewers, a preview is available.
What Type of PR is This?

[ ] Issue
[x] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://65650fb26caa010076c265ac--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://656515392f9f9b0583b1c2d5--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6566449d4f59510e64827cd9--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6566502c37cdae169b14b1ef--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6567a129e9938411673dfd65--harness-developer.netlify.app

@SudheendraKatte is checking on the following SRM items that are included in the SMP 0.11.0 filter, but are not published in SRM release notes:
SRM-15992
SRM-15812
SRM-15712
SRM-15711
SRM-15710
SRM-15007

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6567c41dc883372cd5de462b--harness-developer.netlify.app


Update Swagger for New PolicyAssignments API

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Please fix Swagger Avocado failures too

I don't have enough context about the Swagger Avocado error, and the error does not suggest a straightforward fix. Given that the error was not introduced by this PR and that the check is not required, I will not be fixing it in this PR

I don't have enough context about the Swagger Avocado error, and the error does not suggest a straightforward fix. Given that the error was not introduced by this PR and that the check is not required, I will not be fixing it in this PR

Please check https://github.com/Azure/avocado/blob/main/README.md#multiple_default_tags. Readme file was updated with Tags.
Please check and fix them.

This PR has been signed off couple of weeks ago - what happened? A new commit has been pushed since sign off has been received.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Microsoft.CodeTransparency

This swagger update was previously reviewed and approved. However, before I merged it, this PR https://github.com/Azure/azure-rest-api-specs/pull/31507 made updates to the swagger of the base API version to include some properties that were missing in the swagger. My recent iteration is just to include the changes that were made in that PR in this current one


output: misc. wlr_output_test fixes

output: check for buffer size compatibility in common code
Instead of checking for buffer size compatibility in each backend,
centralize the check in wlr_output itself.
backend/wayland: check scan-out buffer is compatible in output_test
If the buffer doesn't have a supported format/modifier, make the test
fail.

Thanks!


Documentation

Added doc for cache, steps, json and new diagnostic message.

Two things to fix :

for messages, the structure with "data" has to receive an object, not a string.
nextStep doesn't necessary forces you to split caches, the cache API supports some options that you have to explain


bug: fix csv parsing options to allow ragged line lengths.

also fix the name of this other option that i guess is now or always
was (or maybe it likes both?) underscores and not camels.

Thinking more about it, I'm thinking that it probably makes sense to also update the submission attachment worker, since the worker will call parseClientAudits() on the content of any attachment marked isClientAudit. If a client audit log is encrypted, it can't be parsed, so it seems best not to call parseClientAudits() at all in that case. That seems especially true now that parseClientAudits() is more relaxed about input: is it possible that parseClientAudits() would now not throw when given an encrypted client audit log and would manage to create a ClientAudit?
As background, we saw a Sentry error related to parseClientAudits(): https://sentry.io/organizations/getodk/issues/2683905482/?project=5724763. There are a few things that make it seem like the error's coming from the worker, not from downloading submissions:

I used the server audit log to see which submissions were downloaded around the time of the error. I did the download myself and saw that there was no new Sentry error.
The Sentry error is missing a lot of context, for example, there's no URL.
There are exactly 5 Sentry errors, each separated by about 10 minutes. That matches the behavior of a Backend worker.

The submission attachment worker will be updated as part of #416, so I'm going to go ahead and merge this PR.
And just to note for posterity, we had a different Sentry error that also seemed to be from a worker: https://sentry.io/organizations/getodk/issues/2703129106/?project=5724763. The stack trace is cut off before we can see which worker threw the error (and to address that, we've increased the stack trace limit in #413). However, I think it's possible that the error is the submission attachment worker attempting to save the contents of an encrypted client audit log. A quick search indicates that \u0000 is a common culprit behind the error, and if an encrypted client audit log got through parseClientAudits() and then was attempted to be saved, its remainder jsonb column could contain \u0000. But again, that case should be addressed in #416.


Add TIC-80 Icons

Logo

Content

I'll get to work on adding them to the themes I maintain.  I can probably handle Monochrome as well.
I know it's OCD of me, but since the TIC-80 logo looks like an all-in-one PC, would you be opposed to me trying to make the content icon look more like a Disk or Cartridge to keep the System/Media metaphor?
Lastly, should the file names be TIC-80 and TIC-80-content or do they need to be named something else?

Thanks! A cartridge is a great idea, since they're considered carts.
The playlist name is "TIC-80"

OK here's what I've whipped up.

The original design.
A cartridge version of the original.
Left hand.  I switched it so the Computer and cartridge could give each other a high-five!
Removed feet. Also switched out hearts and big smile to match main computer design.
Reinstated hearts and big smile but kept removed feet.
Switched to gray cartridge and added PCB contacts in lieu of feet.

Keep in mind that I still need to adapt it to Monochrome white as well as the Systematic Color palette.  But I did these concepts using the TIC-80 palette in case that team wants to use it as part of their project.

LOL! The mini cart is hilarious. I love this.

I'm going with version 5 unless there's a groundswell of opposition.  I also prefer the outlined version for monochrome, even though I had to break the outline into "quarter pixels" in order to make it work right.

5 is my fav too... it's way too adorbs.

Nicely done Baxysquare! These are merged now :+1: .... I'll close this for now, there may be some updates in these down the line, but these look fantastic.


Add files via upload

I have read the CLA Document and I hereby sign the CLA

Next time, please add your Manager as a reviewer


event: move middleware to the producer side in Stream

The new design replaces the application of middleware at the consumer,
which can be easily wrapped by the client side, with its application
at the producer.
The main implication of this change is that we can now guarantee that
the middleware will run against the caller context, not the async
derived context, which we need, e.g., to record events in
OpenTelemetry.

#113  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jespert and the rest of your teammates on  Graphite


torch.nn.MultiheadAttention with thunder.jit error

I'm trying to trace torch.nn.MultiheadAttention with thunder and I'm hitting a AttributeError: The torch language context has no method or attribute is_nested error. Taking a closer look, it's coming from https://github.com/pytorch/pytorch/blob/main/torch/nn/modules/activation.py#L1236-L1238, in which mha needs to check that the input tensors are not nested. If I comment out these lines, the rest of mha actually works fine, and thunder is able to trace and run both fwd_only and with bwd.
Minimal repro:
import torch
import thunder

model = torch.nn.MultiheadAttention(128, 16, device='cuda')
q = torch.randn(100, 128, device='cuda')
k = torch.randn(100, 128, device='cuda')
v = torch.randn(100, 128, device='cuda')
jfunc = thunder.jit(model)
jfunc(q, k, v)

triage review –
following https://github.com/Lightning-AI/lightning-thunder/issues/93#issuecomment-2030416883, we should just set this to False


[Feature request] Enable Plugins on Inso CLI

I have been trying to figure out how to make plugins work with Inso CLI. I have found that the related request  was closed as completed 2 years ago - https://github.com/Kong/insomnia/issues/3261 - but I can't seem find any documentation or example.
So what's the current state of plugins support for Inso CLI ?

Can I work on this ?


clinicadl train   --visualization       Save results in visualization folder

Where can I view this result? And how to draw ROC curve and calculate AUC?

Hello，
How to set up dropout during training？

Hi,

Where can I view this result? And how to draw ROC curve and calculate AUC?

The visualization folder stores images for one subject in NIfTI format after multiples epochs. Visualizers for NIfTI format can be easily grabbed on the web.  To draw the ROC and calculate AUC we suggest you to activate the TensorBoardX module while running the training and follow in a web interface the evolution of the curves.

Hello，
How to set up dropout during training？

Hello @921974496,
@14thibea created PR #11 to address your question (currently, this is not possible). Once reviewed, this will be available for AD-DL.
Best,
Alex

Hi,
PR #11 was merged to master. Now, it's possible to to set dropout parameter during the training for the concerned layers.

Hi,
PR #11 was merged to master. Now, it's possible to to set dropout parameter during the training for the concerned layers.

Thanks

When I run clinicidl classify I encounter some problems：
File "/home/geng/AD-DL/clinicadl/clinicadl/tools/deep_learning/iotools.py", line 164, in commandline_to_json
if commandline_arg_dic['split'] is None:
KeyError: 'split'
Is my network_dir parameter wrong?  My network_dir parameter is the best_model_dir folder in train output_dir

The command I used is       clinicadl classify patch / home / geng / ADNI2 / test / caps / home / geng / ADNI2 / test / tsv / home / geng / ADNI2 / test / output / home / geng / ADNI2 / resault / best_model_dir

Hi,
PR #11 was merged to master. Now, it's possible to to set dropout parameter during the training for the concerned layers.

The “class Parameters” should also be modified in the “clinicadl / clinicadl / tools / deep_learning / iotools.py file”

When I run clinicidl classify I encounter some problems：

Hi,
the classify task is currently WIP (The brand new issue #15 clarifies this).
However, you can try to use one of the scripts available to evaluate your trained model (see  clinicadl/clinicadl/subject_level/evaluation.py for example).


Create product spec / roadmap document for dapp dev environment

Ticket to document understand stakeholders, problem statement, and what we plan (and not) plan on solving.

do stakeholders like hardhat because of hardhat-network specifically? this has broad implications across our dev offerings

what work is necessary to achieve ganache + precompiles + tx support in hardhat-network?


Camera Image is not showing.

When i click on show button and choose camera option to get the image .After taking the picture the image is not shown in the  Image View  (preview).But when i choose picture from Gallery it shows the Image in the Image View.
Device :- Motorola XT1022(Android 4.4.4 ,API 19).

FIXED
camera image bug is fixed by adding grantUriPermission(..)
 activity.grantUriPermission(packageName, photoURI,
                        Intent.FLAG_GRANT_WRITE_URI_PERMISSION | Intent.FLAG_GRANT_READ_URI_PERMISSION);


Allow the usage of iso variables in with condition

The "old" implementation of with as sugar over try/else didn't allow for the usage of iso variables in a condition as the implementation creates a hygenic variable name for each condition variable and then assigns that to the name given in the with.
The same pattern is followed in the new implementation.
This setup means that all iso condition variables are seen as iso! in the with block, making them unusable.
We should remove this aliasing so that iso variables can be used. This is however kind of tricky and I haven't figured out all the details yet so I decided to open a PR with the almost fully fixed with in #4024 and then open this issue to address iso issue later.

Anyone interested in working on this can contact @SeanTAllen  to get additional information re problems that need to be addressed to make this happen. It's a bit more involved then what @jemc and I first imagined.

This was discussed a bit on the sync call, where Sean explained more about the options for fixing this.

During sync, @jasoncarr0 brought up the point that maybe there's no point to allowing an iso here as you can't do any "iso things" with it. There's nothing "valuable you can do with an iso that you can't do with a ref" in the context of a with.
It's possible that we might want to not support iso but instead would want to improve the error message.


OnUnityThread data can't convert to list.

Hello, I am trying to convert the object from the server into a list element, but I have not been successful. Here is my code.
`
socket.OnUnityThread("friendsStatus", (data) =>
{
//var friends = JsonConvert.DeserializeObject<List>(data.GetValue().GetRawText(), new JsonSerializerSettings
//{
//    TypeNameHandling = TypeNameHandling.Auto
//});
        Debug.Log(data.GetValue()); //  Output of the log : [{"indexnumber":2,"status":0},{"indexnumber":3,"status":0}]
    });`

How to reach like friends[0].status. Thanks a lot.

Hello, I am trying to convert the object from the server into a list element, but I have not been successful. Here is my code. ` socket.OnUnityThread("friendsStatus", (data) => { //var friends = JsonConvert.DeserializeObject(data.GetValue().GetRawText(), new JsonSerializerSettings //{ // TypeNameHandling = TypeNameHandling.Auto //});
        Debug.Log(data.GetValue()); //  Output of the log : [{"indexnumber":2,"status":0},{"indexnumber":3,"status":0}]
    });`

How to reach like friends[0].status. Thanks a lot.

I figure out :D My bad. This is how i should have done when deserializing data.GetValue().ToString().

Hi,
you can get the first object(with the index 0) within the list like this:
data.GetValue(0);
see: https://github.com/doghappy/socket.io-client-csharp#quick-start
have a good day;


Can't do bit-wise operations on Booleans.

Take the following code:
bool val1 = true;
bool val2 = false;
bool result = val1 ^ val2;

The above quite logical code would throw:

Unhandled exception:
Class 'bool' has no instance method '^'.

As a result to be able to xor booleans together I have to do the following:
main() {
  bool val1 = true;
  bool val2 = false;
  bool result = xorBool(val1,val2);
}

bool xorBool(bool item1, bool item2) {
  var xorValue = (item1?1:0) ^ (item2?1:0);
  return (xorValue==1?true:false);
}

This seems seriously in error considering in JavaScript, Java, C# etc I can directly do bit-wise operations against a Boolean value.
Or as someone else pointed out (val1 != val2)

The recommended solution is to use != for xor on booleans.
It is possible to add ^ (and & and | as non-shortcircuiting versions of && and ||) as operators on the bool class, but we have so far decided not to do that.
(I'm not sure I will include JavaScript in the list of languages that define ^ on booleans because the result is not a boolean value - it's just doing numeric conversion on the operators and then integer bitwise xor on that result. That said, it does work because the result can be converted back to a boolean automatically too).

Its not a blocking problem, but coming from many languages that do directly allow bitwise operators on booleans seemed like an odd decision.
What is the reasoning behind this?

The original request was #1080. The reasoning was that it could be confusing to have & do one thing on integers and another on bools.


Fix edge directionality in graph layout

Fixes #2267.

The problem was that we were not making a difference between source and target nodes when constructing edges for the layout engine (for the purpose of not rendering the same edge twice).
Note: The bidirectional edges are now represented as two directed edges, both in the layout engine and when rendering. So they are actually rendered as two overlapping edges, although that's currently not visible. I intentionally left it like that so that we could make them non-overlapping if we want or have an easier time drawing the arrows later on.

The bidirectional edges are now represented as two directed edges, both in the layout engine and when rendering. So they are actually rendered as two overlapping edges, although that's currently not visible. I intentionally left it like that so that we could make them non-overlapping if we want or have an easier time drawing the arrows later on.

Hmm. Not sure about that. I would expect bidirectional edges to be rendered as one edge with two arrowheads.
If it's relatively easy to have one edge for bidirectional edges, let's do that. If not, then what you have is ok.

btw, was this always broken, or is it a regression?

@rade Alright, I modified the code so that it doesn't render both edges, but I'm still sending them both to the layout engine so that the rank assignment would be more accurate. I cleaned up that code and added some comments and unit tests.
I think I broke edge directions in one of my optimizations stories, so I don't think it was there for too long. However, I think we were always ignoring one direction in case of bidirectional edges, which is something this story also fixes. There is a chance this fix will improve stability and accuracy of some rendered graphs slightly.

I think I broke edge directions in one of my optimizations stories,

Did that breakage make it 1.2? If so, we may want to release a 1.2.1 with a fix. cc @2opremio

@rade Fortunately the breakage didn't make it into any of the releases as it was introduced on master only 2 days ago when merging #2221 (line 19 in nodes-chart-layout.js).

LGTM. Nice to have tests for this!


Download go_e2e_deps artifacts in the e2e tests for the test washer

What does this PR do?

Add a missing dependency for the e2e tests in the test washer to download the Go dependencies
Motivation

In https://github.com/DataDog/datadog-agent/pull/27963 I forgot to update the dependencies part which was overriden to [], which means "do not download any artifacts" https://docs.gitlab.com/ee/ci/jobs/job_artifacts.html#prevent-a-job-from-fetching-artifacts
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


[Feature] Legal Database Footer isn't consistent with the current Vocabulary design system

Problem
The footer does not follow the current Vocabulary design system, it contains the Instagram link instead of the Mastodon link as the current vocabulary does. Also some other discrepancies, like the difference in the 'Donate' button
Description
The current Footer Vocabulary

The Footer for the Legal Database Page

Alternatives

Additional context

The link to the Mastodon should be included instead of the Instagram link, to improve general UX
creativecommons/vocabulary: A cohesive system of design for Creative Commons

Implementation

[x] I would be interested in implementing this feature.

@TimidRobot this issue has been resolved!


Extract base sub-project. Stage 1 of 3.

This PR is the first step of extracting Spine Base subproject. The Base subproject would provide:

options for annotating proto types with validation attributes
code generation from annotated proto definitions
utilities and types for working with the generated code.

This PR separates just modules. The following step would be to rename io.spine.base into core.

@armiol, PTAL.


Applying automatic alias based on baseUrl in tsconfig.json stopped to work in version 3.7.0

Let me show how I use fuse-box as short as possible.
In fuse.js:
...
const fuse = FuseBox.init({
    homeDir: "src",
...
const bundle = fuse.bundle("app").instructions(" > index.tsx");
...

In src/tsconig.json:
{
    "compilerOptions": {
        ...
        "baseUrl": "."
    }
}

In src/index.tsx I'm importing src/app/app.tsx like this:
...
import App from "app/app";
...

In version 3.6.0 this worked and during the build following was printed:
...
  → Applying automatic alias based on baseUrl in tsconfig.json
  →
        app => "~/app"
...

In version 3.7.0 there is no such note, but following is printed:
...
→ WARNING Statement "App.js" has failed to resolve in module "app"
...

P.S. In version 3.7.0 there is a bug fix:

tsconfig baseURL and automatic alias 3d7e228

I don't know what was the purpose of that fix but maybe it could be the reason why above scenario stopped to work in version 3.7.0.

Hi, I personally made sure that automatic aliases are working before the release. Do you think you can reproduce it?

@mvladic<EMAIL_ADDRESS>it should be patched here. Could you verify it? As soon as it's verified I will release 3.7.1
Sorry for breaking you build.

@nchanged Yes, I'm running on Windows.
I tried 3.7.0-patch.1. It now includes all the code, but now I have some other problem. I'm using styled-components which imports stream. I noticed, on version 3.6.0, stream looks like this:
FuseBox.pkg("stream", {}, function(___scope___){
___scope___.file("index.js", function(exports, require, module, __filename, __dirname){
if (FuseBox.isServer) {
	module.exports = global.require("stream");
} else {
	module.exports = function() {};
}
});

and on version 3.7.0[-patch.1] it look like this:
    FuseBox.pkg("stream", {}, function(___scope___) {
        ___scope___.file("index.js", function(exports, require, module, __filename, __dirname) {
            if (FuseBox.isServer) {
                module.exports = global.require("stream");
            } else {
                module.exports = {
                    Stream: require("stream-browserify")
                };
            }
        });
        return ___scope___.entry = "index.js";
    });

So, stream-browserify is now used in the browser. But, importing "stream-browserify" fails with package util not found:
require("stream-browserify") ->
require('readable-stream/readable.js') ->
require('./lib/_stream_readable.js') ->
require('util') -> not found!

I also tried on the Mac, both 3.7.0 and 3.7.0-patch.1, and both versions work exactly like 3.7.0-patch.1 on Windows.

Ok so the automatic alias is solved, the problem is with stream now. Can it be reproduced by just using the Stream?

Yes, if I just import stream in index.ts I will also get Uncaught Package not found util error in browser.
index.tsx:
import { Readable } from "stream";
console.log(new Readable());

@mvladic could you possibly share your tsconfig.json file? and FuseBox options passed to init? (more interested in tsconfig option, if array and has over-writes, then which options)

Here is the complete repository:
https://github.com/mvladic/test-fuse-box-1

@mvladic https://github.com/fuse-box/fuse-box/releases/tag/v3.7.1


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit cc7432e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-02-04-15-27-03 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-02-04-15-27-03

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[WIP] ENH: Ignore subreports with no elements

The goal of this PR is to remove the empty fieldmaps section from reports on datasets that don't have fieldmap data.

Didn't fix the issue. I'll have another look in a bit.

Including in #584.


Allow different osg-test branches in a single test run

I think this should work. Kicked off some tests using this update.

Seems reasonable. Looking forward to it!

This would have worked if the script was Python 3 :(

https://osg-sw-submit.chtc.wisc.edu/tests/20211203-1028/results.html nice!


Monitor whether Dependabot properly bumps actions in dependabot/.github/workflows

These files technically have a broken python-version field since they're meant to be suffixed by .jinja.

Okay, a number of things were implemented to fix this. It was not done in a Pull Request because I had to trigger Dependabot multiple times and try different behaviors to get it to work. Here is a summary of what fixed it:

Put quotes around {% raw %}${{ secrets.PYPI_TOKEN }}{% endraw %} so it can be parsed at the YAML stage but is also valid Jinja.
Put quotes around Jinja flags such as {{ python_version }} so it can be parsed at the YAML stage.
A user with push access must manually merge the Pull Request made by Dependabot, instead of commanding @dependabot merge. This is so that the auto-commit action in bump will have a sufficiently-privileged co-author.

In conclusion, we cannot use @dependabot merge when we want bump to run after the merge, due to authentication issues. A workaround would be creating a personal user account intended as a bot, and giving it push access to this repo. But I think that simpler is better, and explicitly elevating the privileges by manually merging seems the better option.


reword runImage

fix for https://github.com/pivotal/kpack/issues/792#issuecomment-895519159
rewording taken from: https://buildpacks.io/docs/concepts/components/stack/

Codecov Report

Merging #794 (cbd9a91) into main (00ea813) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #794   +/-   ##
=======================================
  Coverage   71.35%   71.35%
=======================================
  Files         117      117
  Lines        5412     5412
=======================================
  Hits         3862     3862
  Misses       1183     1183
  Partials      367      367

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ea813...cbd9a91. Read the comment docs.


python310Packages.pypdf2: 2.10.4 -> 2.10.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pypdf2 is: "A Pure-Python library built as a PDF toolkit"
meta.homepage for python310Packages.pypdf2 is: "http://mstamy2.github.com/PyPDF2/"
meta.changelog for python310Packages.pypdf2 is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.10.5 with grep in /nix/store/vg88v56chpixa5k824bq8kva561jpixm-python3.10-PyPDF2-2.10.5
found 2.10.5 in filename of file in /nix/store/vg88v56chpixa5k824bq8kva561jpixm-python3.10-PyPDF2-2.10.5

Rebuild report (if merged into master) (click to expand)

14 total rebuild path(s)

14 package rebuild(s)

First fifty rebuilds by attrpath
bookletimposer
diffoscope
diffoscopeMinimal
krop
maigret
odoo
pdf-quench
python310Packages.pdfposter
python310Packages.pypdf2
python310Packages.xml2rfc
python39Packages.pdfposter
python39Packages.pypdf2
python39Packages.xml2rfc
xml2rfc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vg88v56chpixa5k824bq8kva561jpixm-python3.10-PyPDF2-2.10.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pypdf2 https://github.com/r-ryantm/nixpkgs/archive/54736a60550f62b098a55d0c85a2d27bdfbfb600.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vg88v56chpixa5k824bq8kva561jpixm-python3.10-PyPDF2-2.10.5
ls -la /nix/store/vg88v56chpixa5k824bq8kva561jpixm-python3.10-PyPDF2-2.10.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

odoo

12 packages built:

bookletimposer
diffoscope
diffoscopeMinimal
krop
maigret
pdf-quench
python310Packages.pdfposter
python310Packages.pypdf2
xml2rfc (python310Packages.xml2rfc)
python39Packages.pdfposter
python39Packages.pypdf2
python39Packages.xml2rfc

Maintainer pings
cc @desiderius @vrthra for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.pypdf2 is: "A Pure-Python library built as a PDF toolkit"
meta.homepage for python310Packages.pypdf2 is: "http://mstamy2.github.com/PyPDF2/"
meta.changelog for python310Packages.pypdf2 is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.10.6 with grep in /nix/store/7zc74kasyqagyicchb99hb7gp48h79bn-python3.10-PyPDF2-2.10.6
found 2.10.6 in filename of file in /nix/store/7zc74kasyqagyicchb99hb7gp48h79bn-python3.10-PyPDF2-2.10.6

Rebuild report (if merged into master) (click to expand)

14 total rebuild path(s)

14 package rebuild(s)

First fifty rebuilds by attrpath
bookletimposer
diffoscope
diffoscopeMinimal
krop
maigret
odoo
pdf-quench
python310Packages.pdfposter
python310Packages.pypdf2
python310Packages.xml2rfc
python39Packages.pdfposter
python39Packages.pypdf2
python39Packages.xml2rfc
xml2rfc

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7zc74kasyqagyicchb99hb7gp48h79bn-python3.10-PyPDF2-2.10.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.pypdf2 https://github.com/r-ryantm/nixpkgs/archive/79526e9b3c90e7756bb6bd3a15ced4c97ff917ec.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7zc74kasyqagyicchb99hb7gp48h79bn-python3.10-PyPDF2-2.10.6
ls -la /nix/store/7zc74kasyqagyicchb99hb7gp48h79bn-python3.10-PyPDF2-2.10.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:

odoo

12 packages built:

bookletimposer
diffoscope
diffoscopeMinimal
krop
maigret
pdf-quench
python310Packages.pdfposter
python310Packages.pypdf2
xml2rfc (python310Packages.xml2rfc)
python39Packages.pdfposter
python39Packages.pypdf2
python39Packages.xml2rfc

Maintainer pings
cc @desiderius @vrthra for testing.


Update config.go

Note about EnvAppName

I have never run into the need of including a "_" prefix for environment variables? When have you run into this?

Coverage remained the same at 44.91% when pulling 099252361d74bb13e3760663c74de19aecea8352 on chuhlomin:master into 46437ab910c2bb66af7d6dd1d2b34d37d1bfd4f3 on NYTimes:master.

You can give this example a try if you want to double check: https://github.com/NYTimes/gizmo/tree/master/examples/servers/simple
Do a source .env before running the server and everything should work fine.

Coming from this line: https://github.com/kelseyhightower/envconfig/blob/master/envconfig.go#L70
I tried to run Gizmo with variable like RPC_PORT and found that it dosn't see it unless there is a "_" prefix.
Alright, let me try an example.

You right, example works locally. And envcofing does 2 Getenv calls, first with prefix, second – without it (https://github.com/kelseyhightower/envconfig/blob/master/envconfig.go#L76).
Nevermind this pull request then.


Update 5_guardianNetwork.md

Changed Upgradeability to Upgradability

This repo is being archived in favor of docs.wormhole.com


Add Support for WH729S Heater

Model: WH729S (This is the same heater as WH719S except is has a safety plug)
Speeds: Not sure. Amazon listing says 3, but I'm not able to change the speed anywhere in the app. The 3 might refer to the 3 heat modes.
Oscillation: Yes
Preset Modes: H1 (Heat level 1), H2, H3, Eco, and Fan only
Temperature: Yes, in eco mode you can set the temp.
I'm happy to help if you have any questions. I really appreciate your work on this!

FYI, Temperate ranges from 41 degrees to 95.

@reynolds-adam That right there is a DR-HSH009S. Its already supported. Just make sure your downloading the main branch.

I've pushed 0.6.3 which should have this in it.  Should be able to update from HACS.


How to resume code which was stopped (401) after getting refreshToken.

http://stackoverflow.com/questions/38717913/how-refresh-token-works-and-how-last-failed-http-request-called-again-which-gave

You can create your own interceptor which adds the failed requests to a queue and resolve them after a successfully refresh token. See the pseudo code below:
responseError(rejection) {
  if (rejection.status === 401) {
    if (!this.isFetching) {
      this.isFetching = true;

      OAuth.getRefreshToken()
        .then(QueueService.resolveAll, QueueService.rejectAll)
        .then(() => {
          this.isFetching = false;
        });
    }

    return QueueService.add(rejection);
  }

  return this.$q.reject(rejection);
}

@Talhamansoor Just saw the answer on stack overflow. It's 100% correct.
My snippet above is to handle multiple failed requests - the logic below the QueueService is the same explained on stack overflow.
BTW, the access_token will be automatically added when you retry the failed request - you'll probably need to remove the previous header, i.e.,
OAuth.refreshToken()
  .then(() => {
    delete rejection.config.headers.Authorization;

    return deferred.resolve($http(rejection.config));
});


nx behaviors different with npx

npx will try to load local package bins from ./node_modules/.bin, if not match, then download (to tmp dir?) and execute.
nx seems skipped the search on local package bins, it will always download (to tmp dir?) and execute. For some packages, the results is different as well.
# install
ni -D jest ts-jest

# run
nx ts-jest config:init

I am using pnpm, the echo is like this:
Progress: resolved 11, reused 7, downloaded 2, added 0
......

But if run npx ts-jest config:init, it just run, without an extra installation.

in pnpm, nx is for pnpm dlx. What we do is simple redirect. I guess you might keep using npx if you want it's behaviour.

I think this worth rethinking.
In my opinion, ni package should try to have behavior in same command. So may be pnpm exec is better for nx, The name of nx in README.md is also execute.
Further more, maybe ni also needs a RFC to explain its behavior, since the deeper it goes, the more differences will show.
Take nx as example, which behavior is intend by you?

run local package bin.
run global package bin.
download and run package bin.
try 1->2->3

No matter what command ni redirects to, the behavior between package managers are different. But ni has chance to take over and offer the same behavior (with many workarounds.)

In my opinion, ni package should try to have same behavior in same command

That really deps on how you define "same behavior" - as you mentioned, behaviors between package managers are different. like I run npm i and yarn install, they are just doing similar but essentially, different things. It is not, and can not be the responsibility of ni to ease out the differences (it will always be a thin redirection layer). In the readme, it's already very clear what commands will be mapped to and I don't think RFCs are needed in this case.
I think it's valid to bring up the possible option for pnpm exec - but since we already pick up the dlx path for nx and it still has the clear and defined behavior, I don't think there is any problem with the choice. Meanwhile, as a side note, if you aim to run local packages, I think npx will already work fine no matter you are in yarn or pnpm project.

Kind of ran into a similar confusion here... I just started using pnpm and not familiar with dlx.
In my case, I first installed parcel locally and then ran nx parcel index.html. Since 'x' is for 'execute' (same statement in the README), so I took it for granted that it should execute the locally installed command parcel . Instead it took a lot of time downloading every time I ran this. Maybe dlx stands for download and execute?
FYI.


Command Line --query param is not work on Mac

$  clickhouse-client  --query="show tables"
Code: 62. DB::Exception: Syntax error: failed at position 5 (end of query): . Expected one of: CREATE, PROCESSLIST, TABLES

It works on Linux but fails on Mac. Looks like the param parser stop receiving contents after it find white space.

That's very strange - I couldn't reproduce it. Can you tell which version of ClickHouse and macOS are you using?

Commit: fc409f61e53646d2e88a57287496b67de546bca2 on master.
macOS: 10.12.5.
Using the default Terminal.

It turns out is my problem on clickhouse-client alias script. Sorry about that.

Relates #235


Does not work with the "Minimal" theme

The slider has no effect when I'm using the popular "Minimal" theme. I suspect its a problem with the theme, but if there is a way to supersede the setting with this plugin it would be awesome.

I encountered the same problem

Same here!

Hey, sorry for the late reply. I havent had the time to look into it but ill see what i can do this weekend. I haven't used the minimal theme before so Ill try that out and see if I can find whatever is causing for problems. Thank you for your patience.

FYI: Minimal theme has its own settings for width and it has multiple width values as attached

@narze Hey man, just curious what font is that in your image? It reminds me of Iosevka, I'm just curious because I feel like it's on the tip of my tongue lool.

I think I found a solution (working on my local Obsidian instance). It looks like while the plugin currently adjusts the --file-line-width SASS variable, the Minimal theme uses the --line-width SASS variable.
I've opened a PR (#15) to support the Minimal theme.


Broken In Bog Witch Update

With this mod enabled, the game shows the Ragnar character and if you switch to any other character, they are naked.

I'm kind of assuming that this isn't going to be updated.
These two mods have most of the same features:
AdvancedTerrainModifiers
Extra Snap Points Made Easy
This is more of an admin / cheat mod, but it also has some of the terrain tools:
Infinity Hammer


Export TypeScript types for colors and modifiers

Closes #336

Should I open up a separate PR for https://github.com/chalk/chalk/tree/v2-release?

Should I open up a separate PR for v2-release ?

Nah, I intend to get Chalk 3 out in the next few weeks.

Thanks :)


[d3d9] Book of Demons: Various UI Errors

Some of the UI elements don't appear to respect boundaries. In popups that scroll, the scrolling contents overlap other parts of the popup and sometimes go outside. Also, some effect such as the 'shiny' effect when hovering over the options button at the bottom-right of the main menu, plays outside of the button boundaries.
DXVK

WineD3D

During loading screens, the skull in the center is suppose to be grey, and then full up from bottom to top in a reddish-amber color (to indicate loading progress). Using DXVK, the skull is always reddish-amber. You should be able to see it in the apitrace.

Software information
Book of Demons
Arch Linux
System information

GPU: AMD RX 560
Driver: 19.3.3
Wine version: Proton 5.0-1
DXVK version: 1.5.4-8-g07fee4a0

Apitrace file(s)
https://mega.nz/#!ylIAHAjT!DwD1uvuoxI3HbSI5CTVyLlfBs9RiF16G3NX_3Y_P8cE
Log files
steam-449960.log

Everything looks good with a freshly compiled build just now. Thanks!


iOS 9.3.2 on iPod touch not recognized

Looks like user-agent-parser does not extract the iOS version here.
$ curl -A "Mozilla/5.0 (iPod touch; CPU iPhone OS 9_3_2 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Mobile/13F69" "https://cdn.polyfill.io/v2/polyfill.js?features=Intl.~locale.de,Intl.~locale.en&unknown=polyfill"
/* Polyfill service v3.7.1
 * For detailed credits and licence information see http://github.com/financial-times/polyfill-service.
 *
 * UA detected: ios_saf/0.0.0 (unknown/unsupported; using policy `unknown=polyfill`)
 * Features requested: Intl.~locale.de,Intl.~locale.en
 *
 * Version range for polyfill support in this family is: >=4
 *  */

I updated us to the latest version of the useragent library and it is still parsing this UA as ios_saf 0.0.0.  If you replace the iPod touch token with iPhone it parses correctly, so I think this requires a PR to the ua-parser project.  This is the file that needs to be updated:
https://github.com/ua-parser/uap-core/blob/master/regexes.yaml
It looks like ipod touch is not a recognised token.  Could you push a PR there and to the useragent module?  I'm happy to pull a new useragent release as soon as it's updated.


Upgrade to go 1.16 for the left over packages

Upgraded the go to 1.16 for the rest of the packages.

Looks good, thanks.
Can you also bump the version of each of those submodules in the main go.mod file? That way we can push new tags after merging this PR and don't need another bump PR.

I can do that. Do you want that as a separate commit? Or can I amend the previous commit?

I think amending the current commit is fine, thanks.

I think amending the current commit is fine, thanks.

Thanks, I have updated them.

Pushed new tags: cert/v1.1.0 clock/v1.1.0 healthcheck/v1.1.0 kvdb/v1.2.0 queue/v1.1.0 ticker/v1.1.0


libyami compile error when static enabled.

this also mentioned in https://github.com/01org/libyami/pull/368
reproduce steps:
configure option:
./autogen.sh --prefix=$LIBYAMI_PREFIX --enable-tests --enable-vp9dec --enable-docs --enable-dmabuf --disable-debug --enable-v4l2 --enable-static && make -j8
errors:
ts/yami/release/libyami/decoder/vaapidecoder_h265.cpp:520: undefined reference to h265_quant_matrix_8x8_get_raster_from_uprightdiagonal' ../decoder/.libs/libyami_decoder.a(libyami_decoder_la-vaapidecoder_h265.o): In functionYamiMediaCodec::fillScalingList32x32(_VAIQMatrixBufferHEVC, _H265ScalingList const)':
/home/thomas/projects/yami/release/libyami/decoder/vaapidecoder_h265.cpp:521: undefined reference to h265_quant_matrix_8x8_get_raster_from_uprightdiagonal' ../decoder/.libs/libyami_decoder.a(libyami_decoder_la-vaapidecoder_h265.o): In functionfillScalingList4x4':
/home/thomas/projects/yami/release/libyami/decoder/vaapidecoder_h265.cpp:518: undefined reference to h265_quant_matrix_4x4_get_raster_from_uprightdiagonal' ../decoder/.libs/libyami_decoder.a(libyami_decoder_la-vaapidecoder_h265.o): In functionfillScalingList8x8':
/home/thomas/projects/yami/release/libyami/decoder/vaapidecoder_h265.cpp:519: undefined reference to h265_quant_matrix_8x8_get_raster_from_uprightdiagonal' ../decoder/.libs/libyami_decoder.a(libyami_decoder_la-vaapidecoder_h265.o): In functionfillScalingList16x16':
/home/thomas/projects/yami/release/libyami/decoder/vaapidecoder_h265.cpp:520: undefined reference to h265_quant_matrix_8x8_get_raster_from_uprightdiagonal' ../decoder/.libs/libyami_decoder.a(libyami_decoder_la-vaapidecoder_h265.o): In functionfillScalingList32x32':
/home/thomas/projects/yami/release/libyami/decoder/vaapidecoder_h265.cpp:521: undefined reference to h265_quant_matrix_8x8_get_raster_from_uprightdiagonal' /home/thomas/projects/yami/release/libyami/decoder/vaapidecoder_h265.cpp:521: undefined reference toh265_quant_matrix_8x8_get_raster_from_uprightdiagonal'
../decoder/.libs/libyami_decoder.a(libyami_decoder_la-vaapidecoder_h265.o): In function YamiMediaCodec::VaapiDecoderH265::VaapiDecoderH265()': /home/thomas/projects/yami/release/libyami/decoder/vaapidecoder_h265.cpp:464: undefined reference toh265_parser_new'
../decoder/.libs/libyami_decoder.a(libyami_decoder_la-vaapidecoder_h265.o): In function YamiMediaCodec::VaapiDecoderH265::~VaapiDecoderH265()': /home/thomas/projects/yami/release/libyami/decoder/vaapidecoder_h265.cpp:471: undefined reference toh265_parser_free'
../decoder/.libs/libyami_decoder.a(libyami_decoder_la-vaapidecoder_h265.o): In function YamiMediaCodec::VaapiDecoderH265::decodeSlice(_H265NalUnit*)': /home/thomas/projects/yami/release/libyami/decoder/vaapidecoder_h265.cpp:1025: undefined reference toh265_parser_parse_slice_hdr'
../decoder/.libs/libyami_decoder.a(libyami_decoder_la-vaapidecoder_h265.o): In function `YamiMediaCodec::VaapiDecoderH265::decodeParamSet(_H265NalUnit*)':

Specifying --disable-shared when using --disable-static is the recommended workaround for now.

This issue is OS platform specific.  For Ubuntu, the recommendation is as above mentioned by @uartie
Alternative suggestion, let's disable mixed configuration of static and shared or just don't do it.
I vote for just don't do it.

But --enable-static is standard configure option. It's should not depends on OS platform. I think @uartie can repeat this on centos(correct me if i am wrong). Since we find a workaround, we can flag it as low priority. But i tend to treat it as an issue in our configuration script.

I only tried this on Fedora and Ubuntu.  It works fine on Fedora but not on Ubuntu.  I'm not sure why Ubuntu can't handle it but Fedora can.  Possibly something different with the compiler/linker tools and their settings and/or versions.
During the link phase on Fedora, the dependency_libs in all of the .la dependencies are expanded for the link command.  On Ubuntu, this expansion is not done for some reason.
In this case here, simpleplayer directly depends on libyami_decoder.la which has libyami_codecparser.la listed in it's dependency_libs.  The simpleplayer should not directly depend on libyami_codecparser.la, but it needs it for proper linking.  IMO, this is a shortcoming/problem caused by the distro tools.
Is there actually a use-case where we want both shared and static libraries compiled at the same time?

We can't choose this for customer... It will give them negative feedback

I found that this is a common problem on Debian (thus, Ubuntu):
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702737
The problem is that these distros patched libtool to set link_all_deplibs=no.  Apparently this goes against what the libtool documentation states/recommends.
The only reasonable hack to fix this, based on my research, is to do a sed replacement from configure.ac on the generated libtool wrapper.
Others have said to recompile libtool from gnu.org or painstakingly declare all dependencies explicitly in the makefiles.  I think we can all agree that these last two are not feasible solutions and just plain nonsense.

ok, maybe i can file this in FAQ. thanks U.Artie and Sean

Oops, I didn't see your last comment before submitting the pull request to workaround the problem.  If you'd still rather explain this in a FAQ then I can retract the pull request on your command.

seems it's to ugly. File a FQA maybe better. Thanks for good finding

ok it added to https://github.com/01org/libyami/wiki/FAQ


Should we invent a Rickshaw calendar? If so, what would it be?

Here's a good foundation to base it on:
https://en.wikipedia.org/wiki/International_Fixed_Calendar
The basic gist is that there are 13 months that are 28 days each (so a given date is always the same day of the week). There's one extra day at the end of the year that is "outside" the months (called "year day") and an extra day for that shows up for leap day as well, which also exists outside the months and days of weeks. So, we'd just need 13 month names, and names for those 3 things, and we'd have a Rickshaw calendar.
Here's a color wheel with 24 colors.

If we pick 12 from here (evens or odds) and add iridescent as the 13th month, we'd get something like:

Red
Orange
Yellow
Chartreuse
Green
Clover
Emerald
Cyan
Azure
Blue
Lavender
Magenta
Beet
Iridescent

Open to alternative naming schemes and substitutions.

Leap day and year day can be Infrared and Ultraviolet, to account for them being out-of-spectrum of the month system.

One consideration is the use of wavelength/ frequency to label the months so as to be cultural/linguistically adaptable, and to account for iridescent, infrared, ultraviolet (which might fall outside of RGB/CMYK?)

Can the spare day be a Rickshaw holiday? Perhaps the day we meet for pizza? And given this possibility, must it be situated at the end of the 13-month year, or can it be situated more optimally for pizza meeting opportunities?

Can the spare day be a Rickshaw holiday? Perhaps the day we meet for pizza? And given this possibility, must it be situated at the end of the 13-month year, or can it be situated more optimally for pizza meeting opportunities?

Maybe one day for mourning/lamentation as well, the yin and the yang?


Fixes for 3DCursorLibrary and org.gearvrf.io

org.gearvrf.io:
SensorManager.java

Changed sensors map to a ConcurrentHashMap. This is needed when sensors are added/removed to the scene while iterating/handling a sensor event.

GVRCursorController.java

Expose getNear/FarDepth() calls for use in enabling and disabling settings cursor in CursorManager.

GVRGazeCursorController.java

Reduced the TAP_TIMEOUT to make clicking more responsive and enable double clicking on objects.
Added a HandlerThread to process events on the GazeCursorController. Previously events were being processed on the Main thread(when receiving
touch events) as well as the GlThread(onDrawFrame)

3DCursorLibrary:
CursorManager.java

Added enable/disableSettingsCursor calls to enable applications to use
a settings cursor to interract with a GVRViewSceneObject.
In cursorEventListener Traverse SceneGraph to find Selectable/MovableBehavior components instead of just checking the parent of the object with CursorEvent.
Added a convinience method getGVRContext() to avoid having to pass GVRContext as well as CursorManager.

CursorSceneObject.java

Added a lock arround methods accessing meshSceneObject

MovableBehavior.java

Added locks arround selected variable as it can be accessed from multiple threads

ObjectCursor.java

Added destroyIoDevice call to set active to false for a cursor which is removed from the scene when active=true

SelectableBehavior.java

Added behavior and cursor arguments to StateChangeListener
Setting state before calling handleClickEvent and handleClickReleased

@rahul27 What do you think?

Will review this today.

Looks good. Tested it with the 3D Cursor app and it worked fine.
Just need to address the comments and this PL is good to go.

Addressed comments on the patch.

If there are no further comments, will merge after lunch.

Noticed a few things while working on the scene editor. Can we hold off on merging this.

Sure

Tested this patch at it worked fine. GTG.
Must have noticed an issue with the scaling patch then.


Update README.md for packages/react-static-plugin-source-filesystem

Per notes from the issue log.

Description

Changes/Tasks

[ ] Changed code

Motivation and Context

Screenshots (if appropriate):

Types of changes

[ ] Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] I have updated the documentation accordingly
[ ] I have updated the CHANGELOG with a summary of my changes
[ ] My changes have tests around them

Instead of the extra comment I think just putting the import in the example code would be better.


Add support for displaying pandas DataFrame as an interactive table

This is an attempt to address issue #1350, and it may serve as a basis for future improvements and better implementations.
To use this functionality, follow these steps:

Convert the DataFrame to JSON: Use the to_json() method with the "split" orientation to convert the DataFrame into a JSON string, formatting the data for display.
Create a DataFrame Element: Pass the JSON string as the content parameter when creating the DataFrame element.
Append and Send: Append the DataFrame element to a message and send it for display.

import chainlit as cl
import pandas as pd

@cl.on_chat_start
async def start():
    iris = pd.read_csv(
        "https://raw.githubusercontent.com/mwaskom/seaborn-data/master/iris.csv"
    )

    json_dataframe = iris.to_json(orient="split")

    elements = [
        cl.Dataframe(content=json_dataframe, display="inline", name="Dataframe")
    ]

    await cl.Message(content="This message has a Dataframe", elements=elements).send()

@desertproject Nice one :)
One question though: Instead of expecting (forcing) the user to serialize the dataframe to JSON in a specific orientation, why don't we just accept the DataFrame element and call to_json with orient="split" ourselves behind the scenes, for example in the __post_init__ method?
This way people wouldn't have to serialize/deserialize their dataframes throughout and could just pass a DataFrame at any point without having to worry about the underlying implementation.

@desertproject Cool feature! Could you please create an E2E test for it, so we can support it towards the future? I'd also love some screenshots/screengrab of how it works is supposed to work and/or a cookbook entry. 🙏🏼 🥺

Instead of expecting (forcing) the user to serialize the dataframe to JSON in a specific orientation, why don't we just accept the DataFrame element and call to_json with orient="split" ourselves behind the scenes, for example in the __post_init__ method?

@hadarsharon That's a great idea! I had thought of something similar but wasn’t sure exactly where it would fit. Using the __post_init__ method for this makes perfect sense. Thank you for the suggestion!

Could you please create an E2E test for it, so we can support it towards the future? I'd also love a cookbook entry. 🙏🏼 🥺

@dokterbob I don’t have any experience with E2E testing or Cypress, but I’d be happy to give it a try! Could you provide some guidance on the specific tests you’d like to see? I can also take care of the cookbook entry without any problem.

Could you please create an E2E test for it, so we can support it towards the future? I'd also love a cookbook entry. 🙏🏼 🥺

@dokterbob I don’t have any experience with E2E testing or Cypress, but I’d be happy to give it a try! Could you provide some guidance on the specific tests you’d like to see? I can also take care of the cookbook entry without any problem.

Basically, you'd create a test suite similar to the ones already there: https://github.com/Chainlit/chainlit/tree/main/cypress/e2e
Create a test project setup to use your feature, then test everything you'd normally test for it. E.g. return a dataframe, ensure it's properly rendered. If there's interaction possible, simulate it.
I highly recommend to use something like Claude if you haven't written tests before (but of course, check the work for common slipups!).
Similarly unit tests for Python code would be great as well. Note how the unit tests are laid out to match the Python modules.

When will a new tag for this change be released? Eager to try it out:)

@sundar-sarvam Should be in today's 2.0.dev1 pre-release.
@desertproject We'd love a PR also for the docs https://github.com/Chainlit/docs!

I'll take care of it!


Update whats-new-in-defender-for-office-365.md

Update on BCL now being available in advanced hunting

Docs Build status updates of commit 4a893e3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/office-365-security/whats-new-in-defender-for-office-365.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@JohanFreelancer9

Docs Build status updates of commit b6780a9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/office-365-security/whats-new-in-defender-for-office-365.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7450a25:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/security/office-365-security/whats-new-in-defender-for-office-365.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@MSFTTracyP Please merge this PR. Thanks

Topic file was renamed, and the proposed change is already present in the September 2022 section, so closing this PR.


[T2K 4E] Updated twilight-2k-4e.css

Fixed URL errors in CSS. There is a previous pull about fixing the same errors. But noticed they were not pointing to the correct URL. There was also another URL that needed to be changed in line 3. All this This should fix issue #9291
Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

Thank you!


Changed spelling mistake.

[x] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @Abhishek233
It seems that similar changes have already been accepted earlier for this article you're editing, sorry about that. 😓
If you feel you have more to add, please feel free to open up a new PR.
Thanks again! 😊

If you have any questions, feel free to reach out through Gitter or by commenting below. 💬


twig variables in form fields 'label'

To comply with GDPR rules, my contact form has a checkbox that indicates that a user complies with the privacy regulations.
The label has an anchor link to the 'privacy' page. The href i want to set with twig.
{{ page.find('/privacy').url(true) }}
The fields for this form are defined in frontmatter:

name: gdpr
type: checkbox
markdown: true
helper: "I accept the privacy regulations."
validate:
required: true

The issue is that twig in frontmatter is not being processed.
This are my setting in 'system.yaml'
frontmatter:
process_twig: true
ignore_fields:
- form
- forms

I think you are making this more complex than it needs to be... you really don't need markdown there, just use a regular html link:
helper: i accept the privacy regulations

or if you want the full URL just use it:
helper: i accept the privacy regulations

@rhukster A twig variable would be of better use to me since:

"https://mysite.com/" changes to: https://dev.mysite.com/, https://stag.mysite.com/
"/privacy" won't work in sub pages, then you get https://mysite.com/grandparent/parent/child/privacy

actually /privacy should work in your case as it will be based from the root because it starts with /

Another option is to create a new custom field that extends checkbox, and simply process the markdown of the helper: text with the twig |markdown filter.

I did, like this:
{% if field.helper %} {% if field.markdown %}{{ field.helper|t|markdown(false) }}{% else %}{{ field.helper }}{% endif %} {% endif %}


generate output for resource type zia_url_filtering_rules creates invalid stanzas for override_groups and override_users

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the library and it is still present.

zscaler-terraformer version
zscaler-terraformer v1.1.0
Expected outcome
Output stanzas for these types should generate lists, but instead generate repeated override clauses (which is invalid), ie:
override_groups {
  id = [ 1000, 1005 ]
}

Actual outcome
resource "zia_url_filtering_rules" "resource_zia_url_filtering_rules_1034340" {
  # output trimmed...
  override_groups {
    id = 100000
  }
  override_groups {
    id = 100001
  }
  override_users {
    id = 200002
  }
  override_users {
    id = 200000
  }
}

Steps to reproduce
With the latest release build for any platform, zscaler-terraformer generate --resources="zia_url_filtering_rules" on any rule with more than one override user or override group set. User and group elements generate normally as a list, however override users and override groups display this behavior.
References
No response

@cl-rob The issue has been addressed on the latest version v1.1.1.


Class request: vehicle identification number

There is a wide range of use cases where vehicles are described with respect to their vehicle identification number (VIN), and this assists with entity resolution. This seems useful for manufacturing, commerce, government, university, and other contexts. I think this makes a good case for it being included in the common core rather than a lower-level ontology.
VIN’s follow a standard, and there are competing standards. Here’s from Wikipedia:

There are at least four competing standards used to calculate the VIN.

FMVSS 115, Part 565: Used in United States and Canada
ISO 3779: Used in Europe and many other parts of the world
SAE J853: Very similar to the ISO standard
ADR 61/2 used in Australia, referring to ISO 3779 and 3780

For government, here’s the US https://www.ecfr.gov/current/title-49/subtitle-B/chapter-V/part-565
I think at minimum, “Vehicle Identification Number” should be in CCO, and whether to include the classification standards in the model that may require more debate.
I am not opposed to including “World Manufacturer Identifier” as well, since every VIN has a WMI as a proper part.
Recommended assertions:
rdfs:subClassOf cco:CodeIdentifier ;
rdfs:label “Vehicle Identification Number”@en ;
cco:alternative_label “vehicle chassis number”@en ,
	“vehicle frame number”@en ;
cco:acronym “VIN”@en ;
cco:curated_in_ontology Artifact Ontology

Caveat:
From what I see in CCO’s modeling of UPC, EAN, ISBN, and ISSN, the recommendation may be that what we want a “Vehicle identification Bar Code”, which is ultimately under the class “Information bearing artifact.”
I’m willing to go that route. But I’d want to see some documentation recommending the design pattern.
rdfs:subClassOf cco:OneDimensionalBarcode ;
rdfs:label “Vehicle Identification barcode”@en ;
cco:alternative_label “vehicle chassis barcode”@en ,
	“vehicle frame barcode”@en ;
cco:curated_in_ontology Artifact Ontology

In my work on P3195.1.2 Person Ontology, I created an Orphan Ontology of classes a person would want to store in their Personal Data Store (PDS), but don't below in the Person Ontology.  It includes VIN and these other classes (which Mark Jensen drafted for prior to my retirement).  So I'd like them to find a home in CCO or some new domain.
VehicleIdentificationNumber
https://opensource.ieee.org/person-ontology-group/person-ontology-project/-/blob/master/dev/Orphan-Ontology-Dev.ttl?ref_type=heads#L449
AutomobileModel
https://opensource.ieee.org/person-ontology-group/person-ontology-project/-/blob/master/dev/Orphan-Ontology-Dev.ttl?ref_type=heads#L112
AutomobileTrimLevel
https://opensource.ieee.org/person-ontology-group/person-ontology-project/-/blob/master/dev/Orphan-Ontology-Dev.ttl?ref_type=heads#L119
AutomotiveModelGeneration
https://opensource.ieee.org/person-ontology-group/person-ontology-project/-/blob/master/dev/Orphan-Ontology-Dev.ttl?ref_type=heads#L126

@jonathanvajda @jimschoening1 As the discussions regarding ICEs have implications for this thread, I'm moving them into discussion. However, if there are targeted full term requests (including definitions, source, parent class), consider re-opening them as issues that we can target for a release.


Provide option to prevent emails for scale events

This updates the scaleRequest object to include another optional boolean skipEmailNotification. By default, we'll send emails for scale events, but users can toggle their request to prevent email notifications.

🚢

🚢


Recently touched branches bar leaves white rectangle

When running a custom theme with refined-github, a white rectangle is visible above the watch/star/fork buttons:

When a recently touched branch is active, it renders like this:

This box's white background is used to overlay the watch/star/fork buttons and this effect is not compatible with non-white backgrounds.
Suggestion would be to instead hide the three buttons via CSS (triggered from JS) which would allow to remove the background.

Since you're using a custom theme, isn't that a change that the theme should enable? Either change the white to the correct color or go with your solution to hide the buttons.

We also support textured background (the default is one), so single colors won't do unfortunately.

Here's how it looks with the background removed.
Another suggestion might be to horizontally center the box. There's usually empty space there, especially on big screens.

We need a way to pick up the background color and reuse it. Suggestions?

We need a way to pick up the background color and reuse it. Suggestions?

Not possible as the background can be of non-uniform color when textured.
I think one solution could be a MutationObserver that hides .pagehead-actions via opacity: 0 when the recently touched branches has non-empty content.

Why does the container have to overlap the buttons?

In the screenshot on the main repo page, it is shown underneath.

The width doesn't always match the width of the button group

Also, please remove the extra whitespace when it's empty so we can use an `:empty` selector

In the screenshot on the main repo page, it is shown underneath.

See https://github.com/sindresorhus/refined-github/issues/906#issuecomment-354484055

The width doesn't always match the width of the button group

A few more pixels can be added

Also, please remove the extra whitespace when it's empty so we can use an :empty selector

That element is added by GitHub, not Refined GitHub. To remove that space we'd have to listen for DOM changes and that's just unnecessary

Not possible as the background can be of non-uniform color when textured.

Therefore this probably can't be fixed any better than how it's been fixed:

I'm opening an issue to discuss moving the feature somewhere else.

What if we display: none;/opacity: 0; pointer-events: none; GitHub's buttons instead?

Possible, we'd have to watch include-fragment, then watch the new recently_touched_branches_list div for branches inside. The current re-positioning is CSS-only

What if we display: none;...

Wouldn't it be better to set visibility: hidden on the GitHub buttons?

Wouldn't it be better to set visibility: hidden on the GitHub buttons?

Yes, display: none is bad as it affects the page layout. opacity or visibility are both better in that regard.

I'd rather just move it somewhere else than use two MutationObservers though

Heads-up: Color and position was updated https://github.com/sindresorhus/refined-github/pull/1909


Mock X-Amzn-Trace-Id on requests and forward to *-web containers

Purpose
Provide X-Amzn-Trace-Id header from *-ssl containers to
*-web containers.
At this point, we should be able to trace requests from the load
balancer to the *-web containers (or from the mock *-ssl load
balancers in dev to the *-web containers).
Part of LPAL-9
Fixes LPAL-30 (https://opgtransform.atlassian.net/browse/LPAL-30)
Approach

Use a tweaked docker-ssl-proxy image, with config modified
to include an X-Amzn-Trace-Id header on proxied requests.
Modify *-web nginx config to forward the X-Amzn-Trace-Id
to the FastCGI handler.
Turn on custom logging in *-web nginx containers to include
the trace ID.

Learning
Logging in LPA Live is inconsistent, which I'll attempt to address in future PRs.
Checklist

[X] I have performed a self-review of my own code
[ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
[ ] I have added tests to prove my work
[ ] The product team have tested these changes

@williamfalconeruk Thinking about whether I should revisit this and move to JSON logging as in Sirius, while we have the chance. Just need to confirm that this won't scupper any other systems we're using for analysing logs. Any thoughts?

@williamfalconeruk I updated this PR with some additional commits; this now produces JSON logs and removes logging of static assets. I'm not sure if we would prefer to log static assets, just not as JSON.

Discussing with @williamfalconeruk whether we should retain some logging for static assets, and whether those assets should be logged in NCSA format rather than JSON. This would mean a log with entries in two formats, though.


Logger is disposed too soon

The logger is shutdown before KestrelServer is disposed causing exceptions during logging. It seems to be related to https://github.com/aspnet/Logging/issues/563, but @pakrym suggested the issue might be in WebHost.Dispose().
Unhandled Exception: System.AggregateException: An error occurred while writing to logger(s). (The collection has been marked as complete with regards to additions.) ---> System.InvalidOperationException: The collection has been marked as complete with regards to additions.

   at System.Collections.Concurrent.BlockingCollection`1.TryAddWithNoTimeValidation(T item, Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Microsoft.Extensions.Logging.Console.Internal.ConsoleLoggerProcessor.EnqueueMessage(LogMessageEntry message)
   at Microsoft.Extensions.Logging.Console.ConsoleLogger.WriteMessage(LogLevel logLevel, String logName, Int32 eventId, String message, Exception exception)
   at Microsoft.Extensions.Logging.Console.ConsoleLogger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
   at Microsoft.Extensions.Logging.Logger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
   --- End of inner exception stack trace ---
   at Microsoft.Extensions.Logging.Logger.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.KestrelTrace.Log[TState](LogLevel logLevel, EventId eventId, TState state, Exception exception, Func`3 formatter) in C:\Users\shalter\dev\Universe\KestrelHttpServer\src\Microsoft.AspNetCore.Server.Kestrel\Internal\Infrastructure\KestrelTrace.cs:line 192
   at Microsoft.Extensions.Logging.LoggerExtensions.LogCritical(ILogger logger, String message, Object[] args)
   at Microsoft.AspNetCore.Server.Kestrel.Internal.KestrelEngine.Dispose() in C:\Users\shalter\dev\Universe\KestrelHttpServer\src\Microsoft.AspNetCore.Server.Kestrel\Internal\KestrelEngine.cs:line 65
   at Microsoft.AspNetCore.Server.Kestrel.KestrelServer.Dispose() in C:\Users\shalter\dev\Universe\KestrelHttpServer\src\Microsoft.AspNetCore.Server.Kestrel\KestrelServer.cs:line 236
   at Microsoft.Extensions.DependencyInjection.ServiceProvider.Dispose()
   at Microsoft.AspNetCore.Hosting.Internal.WebHost.Dispose()
   at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run(IWebHost host, CancellationToken token, String shutdownMessage)
   at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run(IWebHost host)
   at SampleApp.Startup.Main(String[] args) in C:\Users\shalter\dev\Universe\KestrelHttpServer\samples\SampleApp\Startup.cs:line 74

https://github.com/aspnet/Hosting/issues/947 should handle this.

Will verify and close if not reproed.

Done in #947


provide polyfill as UMD

covers #12. Provides all the polyfill files as one UMD file (dist/domtokenlist-polyfill-umd.js) that has dist/domtokenlist-umd.js as a dependency. This way you can either load the default dist/domtokenlist.js and get everything patched up right away, or conveniently load/access the polyfills and the DOMTokenList implementation as separate bundles.

I have an idea for a different bundling. Do not merge yet. I want to try that.

yeah, this PR may improve loading things, but it doesn't help if you need to apply the shim to nested documents (e.g. <iframe>). dist/domtokenlist-polyfill-umd.js should export a function that takes root as it's argument, so that you can pass in window (and other window references).

@TrySound are you still working on this?


Error 305003: failure message read when trying to read stats table from non contract account

Hi, I've created a token contract that allows for staking and unstaking. I was hoping to also add a property on to the stats table "total_staked" and increment or decrement that count when accounts would stake and unstake. I keep running into a read assertion when trying to even read from the stats table since the account calling the action is NOT the contract scope. (I am assuming this is the problem).
Here is my staking function
void token::addstake(name owner, asset quantity)
{
    require_auth(owner);
    auto sym = quantity.symbol;
    eosio_assert(sym.is_valid(), "invalid symbol name");
    eosio_assert(quantity.amount > 0, "must specify a positive quantity");

    staked stakedtable(_self, owner.value);
    sub_balance(owner, quantity);

    auto to = stakedtable.find(sym.code().raw());
    if (to == stakedtable.end())
    {
        stakedtable.emplace(owner, [&](auto &a) {
            a.balance = quantity;
        });
    }
    else
    {
        stakedtable.modify(to, owner, [&](auto &a) {
            a.balance += quantity;
        });
    }

    stats statstable(_self, sym.code().raw());
    auto tostats = statstable.find(sym.code().raw()); // fails here with Error 305003: failure message read
    if (tostats == statstable.end())
    {
        statstable.emplace(_self, [&](auto &a) {
            a.total_staked = quantity;
        });
    }
    else
    {
        statstable.modify(tostats, _self, [&](auto &a) {
            a.total_staked += quantity;
        });
    }

}

The problem was I changed the table struct... :(


fix: incorrect PURL derived for RubyGems when platform was present #28

Fix for #28

:tada: This PR is included in version 2.2.1 :tada:
The release is available on:

Chrome Web Store
GitHub release

Your semantic-release bot :package::rocket:


Add docs site

Hey! I'd love to make documentation/examples for react-primitives. Is there any place that you think would be a good place to start?

Hey there is this still use and how can one contribute :) Thanks

Might be worth discussing with @brodybits who was planning on writing more docs soon

@mathieudutour is there other way I could contribute? Thanks and cheers
Another question, could I use this in conjunction with react-styleguidist?

Hi @dantesolis, my apologies for the delay. I think you should feel free to contribute a proposal as you see to be the best fit.
One thing that I think is really missing is clear documentation of the two types of extensions I recently learned about, as I reported in #136. I would be happy to contribute this but do not want to make any promises due to some other priorities.
I would also like to say that there seems to be a number of excellent JavaScript documentation frameworks available and I have not taken much time to evaluate or even properly track all of them. RNW (react-native-web) seems to link to a few nice ones. I think it would be ideal if the doc site would be static and could be hosted from GitHub.
I would favor adding storybook, like RNW did, and maybe adding expobook, react-styleguidist looks nice as well.

Hey @brodybits ok I think the first thing to do, would just to create a "Contribute" section on the project explaining the details. I'll be more than happy to tackle that as well as the react-styleguidist and/or the storybook example. I'll take a look during the weekend.

Hey just fyi, still working on this, should be sending a PR by the end of the week.


AppConfiguration: Missing example of referencing secret from KeyVault

Hi.
Do You have any example of adding reference to KeyVault using CLI ?
M.
Based on: https://github.com/Azure/azure-cli-extensions/issues/1225

@bim-msft do you have any context about this issue ?

@yonzhan Sorry I'm not familiar with this, seems this issue is related to az appconfig

It seems that az appconfig has been merged to main CLI, it's no longer extension I guess.

@djsowa  you may need to get help from appconfig service team since CLI team does not own appconfig related commands.

Hi @djsowa we are not shipping extension anymore as we have merged to main CLI. Regarding to your question about adding keyvault reference, please download the latest CLI and do
az appconfig kv set-keyvault -h and you will see explanations and examples. We will update the official CLI doc shortly.

I see this documentation is already available. So this issue can be closed since documentation was all I want to solve ;)
Thanks.