docs: Add more information about terminate and stop process

Checklist:

[ ] My organization is added to USERS.md.

Adding more information on Cobra short helper and cli docs.
Ref https://github.com/argoproj/argo/issues/4454

cc @simster7


Create Blog “2023-05-18-hello-world”

Automatically generated by Netlify CMS

👷 Deploy Preview for spectacular-sopapillas-3c0fe8 processing.

Name
Link

🔨 Latest commit
35a28a390389549d0b1fe605d1b4c1edd50ba079

🔍 Latest deploy log
https://app.netlify.com/sites/spectacular-sopapillas-3c0fe8/deploys/6465f5da3c649b00089b32fd


Update Cart value in Tracker page

In Contact Us page Cart in navbar is not showing the cart value .

Assign it to me! I can fix it :)


Forces oauther library version that deals with OTP 24

Context
The newest versions of OTP do not have :crypto.hmac/3 anymore and this has broken TIL integration with Twitter since the last big app bump to use OTP 24. extwitter library uses oauther which does not have changed the :crypto.mac/4 yet, so we're going to use this hot fix branch for now.
For reference:
https://github.com/lexmag/oauther/pull/22
https://github.com/parroty/extwitter/issues/140

Coverage remained the same at 84.504% when pulling 5f1da87a94b35e429c1552d453af654a6b5e3e47 on fix-twitter-integration into aaa44e82a77febcca12cbecaed192e850f2d1cf1 on master.


about refresh page and the query data is losed

web app framework7 refresh the page but query is invalid,
i refresh  the page  but the query now is invalid?

Issue is closed because of outdated/irrelevant/not actual
If this issue is still actual and reproducible for latest version of Framework7, please create new issue and fill the issue template correctly:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with issue


Data Model Design

• Translation of the application’s requirements into a comprehensive data model.
• Identification of entities such as Users, Projects, Teams, Submissions, and Evaluations, and their respective
attributes and relationships.

Excellent work on initiating the data model. To align with our project's milestone M4, let's ensure we address the following:
Clarify entity relationships and their implications for database scalability.
Ensure that the model adheres to security protocols as per our SQAP.
Update the issue with a progress timeline to keep track as per our project plan.

We have designed the database and created the models according to the design.


Update to fo-dicom 5

Description
Update to fo-dicom 5 and remove dependency on Newtonsoft.Json.

[x] Update fo-dicom to 5.0.1

[x] Dicom Server

[x] Integrate dependency injection

[x] Dicom Cast
[x] Scale Testing

[x] Migrate to fo-dicom.codecs over efferent
[ ] Fix unit tests

Related issues
AB#85800
Testing
Locally and via pipeline

i am working on same if you wants to connect

Unfortunately, we cannot check this change in yet as there is no version of the fo-dicom 5+ library without issues.

5.0.0 cannot serialize and deserialize datasets properly

https://github.com/fo-dicom/fo-dicom/issues/1251

5.0.1 has issues with the new loading/saving logic

https://github.com/fo-dicom/fo-dicom/issues/1264

Once a new version of fo-dicom is published, we can integrate it safely.

Thanks for the reply, but on the current version we are facing an issue with partially image load, any suggestion and help is appreciated


multiple ino-snackbar instances appear upon changing the value of a story knob

Describe the bug
Storybook generates multiple instances of the ino-snackbar component upon changing the value of a single knob.
To Reproduce
Steps to reproduce the behavior:

Go to https://elements.inovex.de/dist/latest/storybook/?path=/story/notification-ino-snackbar--default-usage
Open the footer containing the knobs by pressing D
Change the value of any knob
Click on the corresponding ino-button to open the snackbar
Multiple instances should appear on the screen even though the button has been pressed only once

Expected behavior
Only a single instance of the ino-snackbar should appear if the button is pressed once.
Screenshots

Your Environment

Software
Version

@inovex.de/elements
1.0.2

Browser
Safari

Operating System
Mac OS

This type of bug also occurs in the ino-fab-set if you change one of the ...-location attributes, the events on this element trigger 1 + number of knob changes times.

Apparently, storybook calls the subscribeToComponentEvents function every time the value of a knob has changed, which causes the number of event listeners to increase over time.

What is more, storybook does not unsubscribe from the event after switching to another story. Hence, the error even occurs after switching back and forth between different stories.


undefined IO:Verbose

Fatal error: Undefined class constant 'VERBOSE' in /root/composer/vendor/hirak/prestissimo/src/Prefetcher.php on line 36

I got this error on Bitbucket Pipelines, what am i missing?.
edit: for now i'll use 0.3.4

@Zabanya Which version of composer do you use?
Try composer self-update. Prestissimo only supports stable version composer (>= 1.0.0) .
Composer\IO\IOInterface::VERBOSE is now available from composer version 1.0.0-beta1.
https://github.com/composer/composer/commit/49d7d65933c78e163354c2c580883926f1c8daee

Composer version 1.0-dev (ecd490b24942590429da64a1ff47c0f14eafc6ac) 2015-12-07 14:30:26
Completed at 2016-11-29T14:23:35Z
too old?, it comes with Bitbucket docker called pipelines. maybe i'll add self-update before installing prestissimo


cla covered project details & activity log missing at  TEST PROJECT IT cla page

Summary
cla covered project details & activity log missing at  TEST PROJECT IT cla page
Steps

Login admin portal at prod
Go to my project list & click on "TEST PROJECT IT" project
Navigate to easycla page
Select CLA group

Actual results
cla covered project details & activity log missing
Expected behavior
User should see cla covered project details & activity log
Screenshots

Environment
Please complete the following information:

Environment:

[ ] ALL
[ ] DEV
[ ] STAGING
[x] PROD

@thakurveerendras EasyCLA is now available for Test Project Group IT, can you please validate this ticket? Thanks!

@mlehotskylf
The issue is still reproducible as reported on prod, Note that the issue is specific to the user

@nickmango, I'm moving this back to In Progress

@thakurveerendras did you perform an activity and there was no update on the activity logs ?

Is this regression issue? If not we can move it to "Soon".


Pull passport-cas from npm

The SAML validation PR has been merged and published to npm so we can just pull it from there. As we don't really test CAS much in QA prior to releases, we should probably just bind to the fixed version?

ready for review


mvnw.cmd fails if not run in directory command

First example shows expected results.  Second example shows failure.
Example 1: run in directory containing mvnw.cmd
C:\Users\ccheetham\src\spring-cloud\spring-cloud-config>.\mvnw.cmd -version
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T11:41:47-05:00)
Maven home: C:\Users\ccheetham\.m2\wrapper\dists\apache-maven-3.3.9-bin\2609u9g41na2l7ogackmif6fj2\apache-maven-3.3.9
Java version: 1.8.0_144, vendor: Oracle Corporation
Java home: C:\opt\oracle\jdk-8\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "dos"

Example 2: run in directory not containing mvnw.cmd
C:\Users\ccheetham\src\spring-cloud\spring-cloud-config\spring-cloud-config-server>..\mvnw.cmd -version
Error: Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain

That's an issue with the wrapper. Nothing we can do about it. You can run with ../

The example was run on Windows.  You cannot run with ../.  The probable may well be with the wrapper but the instructions as written will fail.

2019 and i have the same problem
mvnw is not recognized
how can i fix this ?

@jhonyourangel what are you trying?

"mvnw spring-boot:run"
I am doing this for using spring framework then I gon an error said "'mvnw' is not recognized as an internal or external command," when I tried to run it in CMD

In windows it would be mvnw.cmd

In windows it would be mvnw.cmd

I see thank you


Method to get exact solution?

Is there a built in way to get the actual/exact/true solution to a given problem? Obviously it doesn't scale, but I would like to evaluate how well the QAOA is performing.

Update: One can now convert a docplex qubo into an equivalent Ising Hamiltonian supported by OQ

@vishal-ph I think this now is included in the latest release, right?


better support golang

see here https://github.com/golang/go/issues/57351#issuecomment-1354558729 and discussion

related item maybe:
https://github.com/nvinuesa/go-jpeg-xl

This would be a huge win for (static) site generators written in Go. Proponents of JPEG XL that rely on Go site generators must use external tools to convert their images instead of the built-in image processing pipeline. I faced this issue with Hugo. The lack of Go libraries for JPEG XL hinders the adoption of JPEG XL in the Go ecosystem.

related item maybe: https://github.com/nvinuesa/go-jpeg-xl

I think this library doesn't exist yet. No code. No documentation. Nothing.

see here golang/go#57351 (comment) and discussion

But this issue mentions go-jpegxl, which is supposed to support encoding and decoding. I only found functions to decode images, though.


Adding GitHub template files & dev requirements file

GitHub templates mostly taken from fastats with some minor adaptations for the lack of required doctests. requirements-dev taken from the travis setup, with some reqs that weren't being used removed.
The attrs requirement is annoying but seemingly necessary to avoid a few issues with pytest<->attrs interaction.

@dwillmer you OK to review this? (I can't tag fastats/core)


Add support for exporting LLaMA to ONNX format

This PR adds support for a LLaMA model to be exported to ONNX format.

Fixes # (issue)
#918
Before submitting

[] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[X] Did you make sure to update the documentation with your changes?
[X] Did you write any new necessary tests?

First time contribution. Need help to run a CI.
Was unable to run tests myself because don't have enough powerful GPUs.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Okay, so hf-internal-security model doesn't have any pytorch_model*.bin
Would it be okay to use this one?
https://huggingface.co/decapoda-research/llama-7b-hf

Okay, I managed to get a powerful machine with lots of RAM and confirm it works fine.
Though it produces some warnings during a load, but a model produces normal outputs.

   The argument `from_transformers` is deprecated, and will be removed in optimum 2.0.  Use `export` instead
Framework not specified. Using pt to export to ONNX.
Loading checkpoint shards:   0%|          | 0/3 [00:00 True
/home/user/miniconda3/envs/jupyter/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py:475: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  if input_shape[-1] > 1:
/home/user/miniconda3/envs/jupyter/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py:46: TracerWarning: torch.tensor results are registered as constants in the trace. You can safely ignore this warning if you use this function to create tensors out of constant variables that would be the same every time you call this function. In any other case, this might cause the trace to be incorrect.
  mask = torch.full((tgt_len, tgt_len), torch.tensor(torch.finfo(dtype).min))
/home/user/miniconda3/envs/jupyter/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py:108: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  if seq_len > self.max_seq_len_cached:
/home/user/miniconda3/envs/jupyter/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py:231: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  if attn_weights.size() != (bsz, self.num_heads, q_len, kv_seq_len):
/home/user/miniconda3/envs/jupyter/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py:238: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  if attention_mask.size() != (bsz, 1, q_len, kv_seq_len):
/home/user/miniconda3/envs/jupyter/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py:243: TracerWarning: torch.tensor results are registered as constants in the trace. You can safely ignore this warning if you use this function to create tensors out of constant variables that would be the same every time you call this function. In any other case, this might cause the trace to be incorrect.
  attn_weights = torch.max(attn_weights, torch.tensor(torch.finfo(attn_weights.dtype).min))
/home/user/miniconda3/envs/jupyter/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py:249: TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  if attn_output.size() != (bsz, self.num_heads, q_len, self.head_dim):
============= Diagnostic Run torch.onnx.export version 2.0.0+cu117 =============
verbose: False, log level: Level.ERROR
======================= 0 NONE 0 NOTE 0 WARNING 0 ERROR ========================
Saving external data to one file...
Using framework PyTorch: 2.0.0+cu117
Overriding 1 configuration item(s)
- use_cache -> True
Asked a sequence length of 16, but a sequence length of 1 will be used with use_past == True for input_ids.
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
In-place op on output of tensor.shape. See https://pytorch.org/docs/master/onnx.html#avoid-inplace-operations-when-using-tensor-shape-in-tracing-mode
IOStream.flush timed out
============= Diagnostic Run torch.onnx.export version 2.0.0+cu117 =============
verbose: False, log level: Level.ERROR
======================= 0 NONE 0 NOTE 0 WARNING 0 ERROR ========================
Saving external data to one file...
Generation config file not found, using a generation config created from the model config.

Small update:
After a lot of digging I understood that if the model is larger than a pytorch model - this is not an expected behaviour.
There could be a lot of things behind a scene that I have no background in ML to understand. However, with a common sense I came across of this issue which suggests to try to remove shared weights. Which I don't exactly know if this model has.
As well as that, just running exported model without it's ...with_past.onnx counterpart doesn't really go that well. Even if to add a use_cache=False into an initializer of ...CausalLM - it loads, but on inference it fails with an exception(which I would provide in an upcoming edit of this comment). So with that in mind I would try merging decoders together and trying to make one model file with both past and basic model in place.

Hi @nenkoru , would that work https://huggingface.co/HuggingFaceM4/tiny-random-LlamaForCausalLM/tree/main?

Hi @nenkoru , would that work https://huggingface.co/HuggingFaceM4/tiny-random-LlamaForCausalLM/tree/main?

I guess it won't work because for some reason ORTCausalForLM fails to work with use_cache=False option. I mean the instance of a class initializes, but inference won't work(provided a tb in a previous comment under a spoiler).
After a small monkey patching it turned out that model still tries to use past_key_values after a few iteations over a forward method.
UPD: tried this tiny-random llama(converted to onnx using optimum-cli) and the same stuff happens(tb in the comment above).
optimum-cli cmd: optimum-cli export onnx --model HuggingFaceM4/tiny-random-LlamaForCausalLM --task causal-lm --for-ort --fp16 --device cuda tiny-llama-onnx/
Code used for inference:
from transformers import LlamaTokenizer, LlamaForCausalLM, GenerationConfig

from optimum.onnxruntime import ORTModelForCausalLM
import torch
# Create a PATH to save the model
# Load the model converted to ORT (ONNX)
model_onnx = ORTModelForCausalLM.from_pretrained(
    "/root/tiny-llama-onnx",
    #from_transformers=True,
    provider="CUDAExecutionProvider",
    torch_dtype=torch.float16,
    use_cache=False
    #low_cpu_mem_usage=True
)

tokenizer = LlamaTokenizer.from_pretrained("decapoda-research/llama-7b-hf")

inputs = tokenizer(prompt, return_tensors="pt").to("cuda")
input_ids = inputs["input_ids"].to("cuda")
print(inputs)
generation_config = GenerationConfig(
  temperature=temperature,
  top_p=top_p,
  top_k=top_k,
  num_beams=num_beams,
  **kwargs,
)
with torch.no_grad():
  generation_output = model_onnx.generate(
      input_ids=input_ids,
      generation_config=generation_config,
      max_new_tokens=max_new_tokens,
      return_dict_in_generate=True,
      #use_cache=False
  )

Small observation:
use_io_binding=False fixes the problem, but the performance dips

@nenkoru You openened this PR on the main branch of your fork so it appears I can not push there. Using trl-internal-testing/tiny-random-LlamaForCausalLM, all ONNX and ORT tests pass (including gpu ones pytest tests/onnxruntime/test_*.py -k "llama" -s --exitfirst -m "gpu_test")

@nenkoru You opened this PR on the main branch of your fork so it appears I can not push there. Using trl-internal-testing/tiny-random-LlamaForCausalLM, all ONNX and ORT tests pass (including gpu ones pytest tests/onnxruntime/test_*.py -k "llama" -s --exitfirst -m "gpu_test")

I will change the link. But what you think about the issue I reported above?

About this issue:

The process takes more than 100gb of space and peak RAM usage was at 77-80gb to do the whole thing, from loading the model into ORT and then exporting it

It could be that the large memory requirement during the export has been fixed in https://github.com/huggingface/optimum/pull/932. Although it could be that even before, as we export the model in two parts, (decoder_model.onnx and decoder_with_past_model.onnx), we have at some point memory duplication during the export. I will check that but it is a separate issue.

The exported model takes 51gb of hard-drive space.

To me the exported model size are decent for trl-internal-testing/tiny-random-LlamaForCausalLM compared to the pytorch .bin:

https://huggingface.co/trl-internal-testing/tiny-random-LlamaForCausalLM/tree/main

About the issue with the code snippet you gave: CUDA EP + IO Binding + use_cache=False is not tested (see https://github.com/huggingface/optimum/blob/2b5d9502ab961ebad0d7b1f50f2c8004abc4ed85/tests/onnxruntime/test_modeling.py#L2326-L2331). I'll do a PR to raise an error if an user tries this setting.

About the issue with the code snippet you gave: CUDA EP + use_io_binding=True (the default) + use_cache=False is not tested (see
https://github.com/huggingface/optimum/blob/2b5d9502ab961ebad0d7b1f50f2c8004abc4ed85/tests/onnxruntime/test_modeling.py#L2326-L2331
). I'll do a PR to raise an error if an user tries this setting.

But what about my way of fixing that?  Ideally we would want to fix the foward/IO Binding code itself and add the test for IO Binding + use_cache=False, but there's I think no strong reason for not reusing past key values.

@nenkoru Yes I guess it works! Ideally we would want to fix the foward/IO Binding code itself and add the test for IO Binding + use_cache=False, but there's I think no strong reason for not reusing past key values.

For me it was neccesary. Either way, as long as the exporter generates two files. One for the base model and the other one for the model with past keys - it was loading 2x more VRAM. Which is not an expected behaviour. And yep, was unable to merge even on 256gb RAM. I guess it was fixed now by #932 as you mentioned above. Still, I think that should be working as expected - no past keys. Just my two cents

I've exported a Llama-based model; however, when I run inference on it, the memory usage is greater (~67GB for 13B parameter model) AND the runtime is significantly slower compared to the original model:
NUM TOKENS:  50
ORT TIMES:  [4.2505810260772705, 3.958254814147949, 3.9548168182373047, 3.8123669624328613, 3.7423346042633057]
NORMAL TIMES:  [1.8341279029846191, 1.831620693206787, 1.8367419242858887, 1.827073097229004, 1.8272616863250732]
NUM TOKENS:  100
ORT TIMES:  [12.765657663345337, 11.290537118911743, 11.22416877746582, 11.383142709732056, 11.26672911643982]
NORMAL TIMES:  [3.7361843585968018, 3.7319560050964355, 3.737166166305542, 3.7369601726531982, 3.735769748687744]
NUM TOKENS:  200
ORT TIMES:  [40.04459619522095, 35.00810360908508, 33.88215517997742, 33.990755558013916, 36.0823016166687]
NORMAL TIMES:  [7.595353603363037, 7.5860066413879395, 7.58692479133606, 7.597402095794678, 7.584235429763794]

And when I try to convert it with the fp16 flag, I get a: failed:type error: type parameter (t) of optype (max) bound to different types (tensor(float16) and tensor(float) in node (max_1670)
Any suggestions?

Hi @gilljon is this with CPU execution provider or CUDA EP? Hopefully transformers release comes soon so that we can merge the PR and test it!

Hi @gilljon is this with CPU execution provider or CUDA EP? Hopefully transformers release comes soon so that we can merge the PR and test it!

It seems like the issue was running an outdated torch. Upgrading torch to torch==2.1.0 fixed the conversion issue. That being said, when performance testing the model, I am still noticing a decrease in generation speed:
NUM TOKENS:  20
ORT TIMES:  [0.5817182064056396, 0.5831649303436279, 0.5821049213409424, 0.5825436115264893, 0.5824661254882812]
NORMAL TIMES:  [0.4072282314300537, 0.4071035385131836, 0.4074513912200928, 0.40746521949768066, 0.407412052154541]
NUM TOKENS:  50
ORT TIMES:  [1.5875389575958252, 1.565403938293457, 1.5717802047729492, 1.5658864974975586, 1.5674340724945068]
NORMAL TIMES:  [1.0803217887878418, 1.0725362300872803, 1.0720314979553223, 1.0732998847961426, 1.0723967552185059]
NUM TOKENS:  100
ORT TIMES:  [3.256457805633545, 3.2374284267425537, 3.2630958557128906, 3.241764545440674, 3.2146661281585693]
NORMAL TIMES:  [2.1945881843566895, 2.1934919357299805, 2.2603249549865723, 2.1941864490509033, 2.19608736038208]
NUM TOKENS:  200
ORT TIMES:  [6.571287631988525, 7.072286605834961, 6.634500503540039, 6.614758729934692, 6.610734224319458]
NORMAL TIMES:  [4.461749792098999, 4.541143417358398, 4.538911581039429, 4.538933992385864, 4.537773847579956]

The model has the following ort_config.json:
{
  "one_external_file": true,
  "opset": null,
  "optimization": {
    "disable_attention": null,
    "disable_attention_fusion": false,
    "disable_bias_gelu": null,
    "disable_bias_gelu_fusion": false,
    "disable_bias_skip_layer_norm": null,
    "disable_bias_skip_layer_norm_fusion": false,
    "disable_embed_layer_norm": true,
    "disable_embed_layer_norm_fusion": true,
    "disable_gelu": null,
    "disable_gelu_fusion": false,
    "disable_layer_norm": null,
    "disable_layer_norm_fusion": false,
    "disable_shape_inference": true,
    "disable_skip_layer_norm": null,
    "disable_skip_layer_norm_fusion": false,
    "enable_gelu_approximation": false,
    "enable_transformers_specific_optimizations": true,
    "fp16": false,
    "no_attention_mask": false,
    "optimization_level": 2,
    "optimize_for_gpu": false,
    "optimize_with_onnxruntime_only": null,
    "use_mask_index": false
  },
  "optimum_version": "1.7.4.dev0",
  "quantization": {},
  "transformers_version": "4.28.0.dev0",
  "use_external_data_format": true
}

and was created using the standard optimum export command with the flags: --fp16 --device cuda --optimize O2.
Any ideas? This is with CUDAExecutionProvider. Also worth noting is the memory usage: 67GB for the 7B model.

What is the status on this one @fxmarty / @gilljon? I'd love to try hosting this model on triton in onnx

onnx

You can definitely host it on triton in onnx, although the memory footprint is still buggy.

@sam-h-bean You can definitely host it on triton in onnx, although the memory footprint is still > than raw Python. Alternatively, you can deploy it on Triton using Python Backend.

@gilljon do you think it will get to the point where the memory in onnx is smaller? At 67GB that wouldn't even fit on an A100.

Using https://github.com/huggingface/optimum/pull/974 instead of this branch as I could not push here. Llama onnx export will be included in todays release!
Not sure if this will work well with TRT, and I always have issues with ORT CUDA EP memory usage.


[Feature request] Ability to export a list of names of installed applications

BCU already has a comprehensive and highly-customizable list of installed applications, so it would be nice to have a feature that outputs a list of the applications that BCU is currently showing, to a .txt or .csv or something.

Select all applications you want to export and either right click and use the copy to clipboard menu and only pick display name, or use File > Export and later process the data in Excel or similar.


Add webtest marker

Could be a simple webtest marker added to skip test in case internet connection is not available?

This decorator actually already existed, I simply forgot to use it in test_wipe
will fix it now


chore: weekly maintenance PR should always run on latest 'main' commit

Normally this doesn't matter, but I wanted to be able to "re-run" failed lockfile maintenance jobs, in which case it matters that you're running on the latest commit.

@wmhilton I have a dumb question and that is: what is a weekly maintenance PR?

@paulatulis We've made a simple script that refreshes yarn.lock. It creates PR like this once a week https://github.com/stoplightio/elements/pull/1691
It was needed, because when users install elements as a library, our lock gets ignored. Hence we need to make sure that elements works with the newest available dependencies.


Fix Red Hat detection

It is spelled as 2 words in the files we inspect to determine the distribution we're running on.
Fixing the search pattern changes the value assigned to DISTRIBUTION so all existing checks have been updated.
OS value was also update for consistency, so we don't have to wonder if we need to spell Red Hat as one or two words
Before this change, DISTRIBUTION is set to Linux on Red Hat, which circumvents the check to ensure we pin the version to 7.51.x on RHEL 6

I forgot to mention that this is linked to https://datadoghq.atlassian.net/browse/AGENT-12202


added validation

I have added input validation to login and signup page
Pls check

Great Work @Gauravtb2253 .

do you have any specific issue for me to solve

do you have any specific issue for me to solve

you may try to add chat feature #142.

do you have any other issue
I am not much aware of socket programming


Non-unique names for graphs in collections tree

I have some source groups for which I need to show the same metrics. I can create suitable graphs for every source group, which differs only by source (maybe it will be possible to use templates for this in future?), but now I need to have at least the same names for graphs, so it must looks like:
NS servers
   CPU
   Memory
HTTP servers
   CPU
   Memory

Graphs names names must be unique, so I can do only this now:
NS servers
   NS CPU
   NS Memory
HTTP servers
   HTTP CPU
   HTTP Memory

Is it possible to fix it? Maybe another graph parameter for collections tree only?

Hi @enp
If I understand your need correctly, you can reference a source group as a template entry with the group: prefix, e.g. if your source group is named NS servers then instanciate a graph template and fill the template attribute such as group:NS servers.
Let us know if this solves your problem.

No, I need two collections (NS servers and HTTP servers) with the same graphs for every collection (CPU and Memory). I can create two source groups (ns and http with servers ns0 and ns1 in first group and http0 and http1 in second group). Next I can create two graphs for every source group, so it will be four graphs. But I need to give them a unique names, I can't have two graphs with name CPU for example (even if them will be in different collections). It will be good to have another name to show it in collection graph list on left panel - which will not unique.
Templates is another question, because it is not documented well now - see https://github.com/facette/facette/issues/280. So, I do not understand how to create template and what is it. I can use source group or metric group to show more than one lines/areas on one graph, but the result is one graph, not graph template.

Sorry, graph title solves my main problem. So, only templates needs additional explanation.

Hey @enpm, could you have a look at the 0.4.x version released recently? Looks like the collection templates introduced in this version can solve your problem: you can create graph templates that can use a source group as template attribute – for example in the graph title –, then create a collection template referencing the graph templates created previously. Finally, instantiate 2 different collections using the collection template, providing for each one the source group ID corresponding to your "NS servers" and your "HTTP servers" as template attribute.


Litmos API default course limit on import

By default, the Litmos API will only return the first 100 courses from a plain call to /courses. We ran into a similar issue with our WooCommerce integration, and found it necessary to set a higher limit param when retrieving courses, which could be done [here] (https://github.com/Litmos/Wordpress/blob/master/litmos.php#L65) to avoid confusion for folks who have > 100 courses to import.

Hi Chase,
I am running into this same problem. How did you set a higher limit?


A suggestion, not an issue

I'm very impressed by all this work ! Thanks ! 30 years ago I would have played non-stop with your program !
Would it be hard to implement a XHPLOT feature ? HPLOT using XOR ...
Something else that would have been a killer back then is the ability to define sprites ...
Thanks for keeping all this and all the Apple II memories alive !

The XOR line draw mode is already there; see &EXP 1 or SetLineMode.  This is used in the hrfan demo.

Sorry ! I completely overlooked that option ! Wonderful !


test

Document Details
Service: service
Sub-service: subservice
Product: product
Technology: technology

#assign:lamebrain

#assign @adunndevster


Keep crashing

It keeps on saying unfortunately blocklauncher has stopped. It needs to be updated. Minecraft Pocket Edition update is 0.15.0 please update blocklauncher.

Thx!

I can offer that if you have updated Minecraft to 0.15, that is why.  BlockLauncher does not support 0.15 yet.  Please close this so we do not have to sort this later.  The issue is being worked on.
Check twitter and you'll see that he is having issues with OpenGL and closing the app as well as a few more things.  What should have been a week has gotten much longer.  Please close this issue so the author does not have to sort this out later.

I'm so sorry I didn't know how to remove that comment.
On Jun 29, 2016 8:30 AM, "Daniel Rozwood"<EMAIL_ADDRESS>wrote:

I can offer that if you have updated Minecraft to 0.15, that is why.
BlockLauncher does not support 0.15 yet. Please close this so we do not
have to sort this later. The issue is being worked on.
Check twitter and you'll see that he is having issues with OpenGL and
closing the app as well as a few more things. What should have been a week
has gotten much longer. Please close this issue so the author does not have
to sort this out later.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/zhuowei/MCPELauncher/issues/1172#issuecomment-229355951,
or mute the thread
https://github.com/notifications/unsubscribe/ATF1HHJDNKxsRWLgNFs-ZoUWtIgd3qtGks5qQnOMgaJpZM4I-mD4
.

@joshuaSTE you can just close this issue.  You do not have to remove any comments.  Thanks!


Combined HTML5Shiv and RespondJS libraries via CDN

JSdeliver.net supports combining libraries so for IE8 we could replace:
https://oss.maxcdn.com/html5shiv/3.7.3/html5shiv.min.js
https://oss.maxcdn.com/respond/1.4.2/respond.min.js

with just:
https://cdn.jsdelivr.net/g/html5shiv<EMAIL_ADDRESS>Will save a HTTP request and make the code slimmer. :-)

Dear Coliff,
Since the arise of HTTP/2, it is no more recommended to "save" HTTP requests on same domain. Here is an in-depth article explaining why and how : https://rmurphey.com/blog/2015/11/25/building-for-http2
So my advice here is to continue having two separated calls and allow the developpers to merge them if they don't want to support HTTP/2

Thanks, but we'll pass on this.


Sending times out TypeError: Cannot read property 'wad' of null

Describe the bug
Sending times out, see console log below
To Reproduce
Sending DAI from a new wallet which recently successfully made a send link. Tab was closed, then reopened later. Attempted to send 1 DAI to xpub address xpub6Eu9mJqug8K5aHvomcu2g5ad8C9o2KPqk41Vn2vMq57Vwt3o1U5u9rmp53A6vQuj1xSZZbkqiuywrgT7KwRHRcosueLYAbixo1CDoVeosTz
Expected behavior
Transaction should send.
Your Environment

Client version used: https://staging.mosendo.com
Node version used:
Chain used: {"name":"rinkeby","chainId":4,"ensAddress":"0xe7410170f87102DF0055eB195163A03B7F2Bff4A"}
Browser Name and version: Chrome Version 76.0.3809.100
Operating System and version (desktop or mobile): macOS 10.14.5 (18F132)
Link to your project:

Additional context
Add any other context about the problem here.
Uncaught (in promise) TypeError: Cannot read property 'wad' of null
    at t.<anonymous> (SendContainer.js:116)
    at c (runtime.js:45)
    at Generator._invoke (runtime.js:264)
    at Generator.e.<computed> [as next] (runtime.js:98)
    at r (asyncToGenerator.js:3)
    at s (asyncToGenerator.js:25)
    at asyncToGenerator.js:32
    at new Promise (<anonymous>)
    at t.<anonymous> (asyncToGenerator.js:21)
    at t.<anonymous> (main.aed2d017.chunk.js:1)
SendContainer.js:122 Sending<PHONE_NUMBER>000000000 to xpub6Eu9mJqug8K5aHvomcu2g5ad8C9o2KPqk41Vn2vMq57Vwt3o1U5u9rmp53A6vQuj1xSZZbkqiuywrgT7KwRHRcosueLYAbixo1CDoVeosTz
logger.js:53 info: [TransferController] Transfer called with parameters: {
  "assetId": "0xFab46E002BbF0b4509813474841E0716E6730136",
  "amount": "1000001000000000000",
  "recipient": "xpub6Eu9mJqug8K5aHvomcu2g5ad8C9o2KPqk41Vn2vMq57Vwt3o1U5u9rmp53A6vQuj1xSZZbkqiuywrgT7KwRHRcosueLYAbixo1CDoVeosTz"
}
logger.js:53 info: [ConnextInternal] Proposing install with params: {
  "abiEncodings": {
    "actionEncoding": "\n          tuple(\n            uint8 actionType,\n            uint256 amount\n          )",
    "stateEncoding": "\n          tuple(\n            uint8 stage,\n            \n  tuple(address to, uint256 amount)[2]\n transfers,\n            uint256 turnNum,\n            bool finalized\n          )"
  },
  "appDefinition": "0x314f6f42BA4917c3dBC5aaBBd009a33a42C5e221",
  "initialState": {
    "finalized": false,
    "stage": 0,
    "transfers": [
      {
        "amount": {
          "_hex": "0x0de0b79c7c091000"
        },
        "to": "0x8d03c7af8C64Aa547cA1e7A70649e9847F511099"
      },
      {
        "amount": {
          "_hex": "0x00"
        },
        "to": "0xc704446D98CD69398fe89934668D351172356f0f"
      }
    ],
    "turnNum": {
      "_hex": "0x00"
    }
  },
  "initiatorDeposit": {
    "_hex": "0x0de0b79c7c091000"
  },
  "initiatorDepositTokenAddress": "0xFab46E002BbF0b4509813474841E0716E6730136",
  "intermediaryIdentifier": "xpub6EUSTe4tBM9vQFvYf3jNHfHAVasAVndhVdn1jFv5vv3dBwjxtiDbQoPZiCUYhNH3EFeiYVeKSckn4YqVqG9NhBe9K8XFF3xa1m9Z3h7kyBW",
  "outcomeType": "SINGLE_ASSET_TWO_PARTY_COIN_TRANSFER",
  "proposedToIdentifier": "xpub6Eu9mJqug8K5aHvomcu2g5ad8C9o2KPqk41Vn2vMq57Vwt3o1U5u9rmp53A6vQuj1xSZZbkqiuywrgT7KwRHRcosueLYAbixo1CDoVeosTz",
  "responderDeposit": {
    "_hex": "0x00"
  },
  "responderDepositTokenAddress": "0xFab46E002BbF0b4509813474841E0716E6730136",
  "timeout": {
    "_hex": "0x00"
  }
}
Uncaught (in promise) Error: IO_SEND_AND_WAIT timed out after 30s waiting for counterparty reply in install-virtual-app
    at index.js:14098
    at c (runtime.js:45)
    at Generator._invoke (runtime.js:264)
    at Generator.e.<computed> [as next] (runtime.js:98)
    at n (asyncToGenerator.js:3)
    at s (asyncToGenerator.js:25)
...```

@rhlsthrm @LayneHaber have you seen this with the bot farm?

I haven't seen this particular issue with the bot farm. @thowar2 how often does this happen? Is it easily reproducible?

wad comes from our Currency helper class so it's an app-layer problem in the daicard. Maybe some of the props are being passed incorrectly, not something the bot farm would detect but I'll try to repro in the ui tests tomorrow

Closing, can reopen if it pops up again


PP 3812 replicate transactions search by dates.java in cypress

WHAT

moves cypress inside test/ directory, and moves config
adds single .json configuration to create unit/contract test fixtures, and then as basis for browser tests
replicates the spirit of the e2e test for date filtering of the transactions page, while adhering to our new principles for contract/browser tests with respect to not writing contracts/pacts/browser tests for complex combinations of search terms, interactivity and the like
adds 3 pact interactions and unit tests for transactions, for situations with no filtering, and to/from dates specified
adds a pact interaction and unit test for card types

For context, discussion of this work is here https://github.com/alphagov/pay-selfservice/pull/806


Api in js?

What do you think about rewriting whole instagram api to JavaScript?
i think it will reduce crashes and request can be easier to debug and manage. what do you thing about it?

i use this API on some desktop projects...

i mean add it only in prostogram and create new repo for example named JSInstagramAPI


Revert "Update to rbac policy struct and end2end authz test."

Reverts grpc/grpc#27074
Looks like it broke the grpc/core/master/macos/grpc_bazel_cpp_ios_tests kokoro job on master:
https://source.cloud.google.com/results/invocations/6dec90a4-7bce-4d99-86a3-e98ea7fafc06/log
FAIL: //test/cpp/end2end:sdk_authz_end2end_test_on_ios (see /Volumes/BuildData/tmpfs/tmp/bazel/execroot/com_github_grpc_grpc/bazel-out/darwin-fastbuild/testlogs/test/cpp/end2end/sdk_authz_end2end_test_on_ios/test.log)
INFO: From Testing //test/cpp/end2end:sdk_authz_end2end_test_on_ios:
==================== Test output for //test/cpp/end2end:sdk_authz_end2end_test_on_ios:
2022-01-12 23:32:50,093 Will consider the test as test type logic_test to run.
2022-01-12 23:32:50,563 Creating a new simulator:
Name: New-iPhone 11 Pro Max-13.3
OS: iOS 13.3
Type: iPhone 11 Pro Max
2022-01-12 23:32:50,763 Created new simulator CBDF3AF5-38B1-4082-85B4-B9F338FC6CDD.
Test Suite 'All tests' started at 2022-01-12 15:32:51.034
Test Suite 'sdk_authz_end2end_test_on_ios.xctest' started at 2022-01-12 15:32:51.034
Test Suite 'GTMGoogleTestRunner' started at 2022-01-12 15:32:51.034
Test Suite 'SdkAuthzEnd2EndTest' started at 2022-01-12 15:32:51.034
Test Case '-[GTMGoogleTestRunner SdkAuthzEnd2EndTest::StaticInitAllowsRpcRequestNoMatchInDenyMatchInAllow]' started.
E0112 15:32:51.068633000<PHONE_NUMBER> sdk_authz_end2end_test.cc:50]      load_file: {"created":"@1642030371.068608000","description":"Failed to load file","file":"src/core/lib/iomgr/load_file.cc","file_line":72,"filename":"src/core/tsi/test_creds/ca.pem","referenced_errors":[{"created":"@1642030371.068606000","description":"No such file or directory","errno":2,"file":"src/core/lib/iomgr/load_file.cc","file_line":45,"os_error":"No such file or directory","syscall":"fopen"}]}
E0112 15:32:51.068732000<PHONE_NUMBER> sdk_authz_end2end_test.cc:50]      assertion failed: GRPC_LOG_IF_ERROR("load_file", grpc_load_file(file_path, 0, &slice))
Child process terminated with signal 6: Abort trap
2022-01-12 23:32:51,070 Deleting simulator CBDF3AF5-38B1-4082-85B4-B9F338FC6CDD asynchronously.
2022-01-12 23:32:51,074 Done.
================================================================================
Target //test/cpp/end2end:sdk_authz_end2end_test_on_ios up-to-date:
  bazel-bin/test/cpp/end2end/sdk_authz_end2end_test_on_ios
  bazel-out/applebin_ios-ios_x86_64-fastbuild-ST-e637a0adc749/bin/test/cpp/end2end/sdk_authz_end2end_test_on_ios.zip
INFO: Elapsed time: 12.650s, Critical Path: 10.90s
INFO: 60 processes: 18 internal, 41 darwin-sandbox, 1 local.
INFO: Build completed, 1 test FAILED, 60 total actions
//test/cpp/end2end:sdk_authz_end2end_test_on_ios                         FAILED in 1.7s
    ERROR   .test/cpp/end2end/sdk_authz_end2end_test_on_ios (0.0s)

@ashithasantosh, please work on fixing this and re-landing this PR. Thanks!

Sure, will look into the error.

pinging the thread to give EasyCLA a nudge.

EasyCLA check seems stuck, the PR needs to be force-merged by someone with admin rights.


assetsmanager - description doesn't save correctly

Steps to reproduce:

upload an asset
change title (value update works instantly)
change description
click save button and don't click anywhere else while the cursor is in the textarea

asset.value.description is only updated when I click somewhere else on the page before saving.
I'll send a PR soon.

fixed via 2f94a46d68ee45d9fc62918a6e468af68c158804
Thanks.


Support Env Variables As Template Inputs

Currently only user provided variables can be used as inputs to a module in yard.yaml
...

outputs:
  Containerfile:
    - base:
        version: "24.04"

Environment variables should be acceptable as well
...

outputs:
  Containerfile:
    - base:
        version: $VERSION

Completed


Using in another website

Whenever our team attempts to use this on our website, it does not work.  It works when it is outside of the webpage like in a single html file, but when it has other elements, it does not work.

@zandermar18 Oh really? Let me check it, sorry.


Optimize HTML, CSS and JS

Is this really a bug? sounds like a feature to me. What did you have in mind here, just running an optimizer/minifier on the output?

Yeah, agree, this is a feature

Notes to myself. Try purgecss. It is npm package so can use nodeenv to keep it in a sandbox.

It could be done using Python only. I use those tools: https://github.com/BoboTiG/luma/blob/30a6a570847a93bca371a329f4928a7e05d45a8b/minify.py#L13-L17 and https://github.com/BoboTiG/luma/blob/30a6a570847a93bca371a329f4928a7e05d45a8b/minify.py#L115-L120
In a nutshell, we "just" do rcssmin.cssmin(FILE.read_text()) for CSS files. Same kind of process for JS and HTML if we wanted to.

Thanks a lot for your suggestion @BoboTiG


System.LimitException: Too many query rows: 50001 while using custom iterator

Summary
I have more than 50k records and using an iterable class as a source, When I am executing the mass action job it's throwing the error. As per the documentation, it should handle 50 million records.
How can I query out more than 50k records in Iterator?
Version of Mass Action Scheduler
2.4
Source Type

[ ] Apex - Iterator Class

global with sharing class DeletionIterator implements Iterable<Map<String, Object>> {

    /**
     * The iterable interface requires one method, iterator(),
     * that returns a class that implements the Iterator interface.
     */
    public Iterator<Map<String, Object>> iterator() {
        return (Iterator<Map<String, Object>>) new IterableSODelete();
    }

    public class IterableSODelete implements Iterator<Map<String, Object>> {

        private List<Map<String, Object>> data = new List<Map<String, Object>>();

        private Integer currentIndex = 0;

        //Constructor with no Parameters
        public IterableSODelete() {
            Set<Id> ContactIdSet = new Set<Id>();
            Set<Id> businessGrpSet = new  Set<Id>();
            Set<Id> AccountIDSet = new  Set<Id>();

            //Get Account records
             List<Account> lstAccount = [Select id,Name from Account where ContactCount__c>1  ]; //Getting limit error here

            for(Account eachAcc: lstAccount) {
				Map<String, Object> m = new Map<String, Object>();
				m.put('id', each.id);
				data.add(m);

            }

        }

        //Mandatory Functions to implement for Iteratable Interface
        public Boolean hasNext() {
            return ( this.data != null && this.currentIndex <= this.data.size() - 1 );
        }

        //Mandatory Functions to implement for Iteratable Interface
        public Map<String, Object> next() {
            return this.data[this.currentIndex++];
        }

    }

}

Exception
EXCEPTION_THROWN|[24]|System.LimitException: Too many query rows: 50001

@yashwanth did you resolved the issue ? Is limit class solve the issue ?


ui changes

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Invalid Issue .
Please  make a valid Issue


NTR: prepare release

Coverage remained the same at 42.295% when pulling 1d1e93dca136f8ef0d0bcb53c063042f04e76178 on NTR-prepare-Release into e764e575697db3325227c7c74ce8253444db6fff on master.


Result of recipe function is a string in test environment - jest

result of recipe function is a string in unit tests(jest) - it works fine(is a function) in the app. I have added babel plugin according to the documentation https://vanilla-extract.style/documentation/setup/#test-environments.
const button = recipe({   base,   variants: {     variant: variants,     size: sizes,   }, });
className={button({ variant, size })} <= I am getting error here: Error: Uncaught [TypeError: (0 , _Button.button) is not a function]

I'm also facing the same issue when trying to import .css.ts files within jest environment. What I found is that they are getting correctly processed by babel plugin when I change the import from:
import { recipe } from 'styles.css'

to
import { recipe } from 'styles.css.ts'

Any ideas why this might be happening? @mattcompiles

This issue often occurs when your test environment is configured to return an identity-obj-proxy when it is sees a .css extension. This was a common pattern in projects using CSS modules, often seen in jest setups. The issue is that jest doesn't resolve the final file path of the file, it only looks at the request in the consuming file, so it's impossible to tell the difference between a .css.ts file and a CSS module.
Ideally remove the config doing this, however if you need to support both in the same project then I'd move to using the .module.css extension. This will allow you handle those files differently in your jest transform rules.
If this isn't the issue let me know.

This was exactly the issue :) Turns out NX is by default returning identity-obj-proxy as you have mentioned:
https://github.com/nrwl/nx/blob/0c8eade82e4c3a4d555f7407c0a324d982bcbd59/packages/jest/plugins/resolver.ts#L43-L51
Thanks a lot :)


Breaks under latest rollup version due to change in configuration structure

Seems this is not compatible with the latest rollup version released a few days ago.
Running<EMAIL_ADDRESS>alongside<EMAIL_ADDRESS>I get the following error:
[!] Error: ENOENT: no such file or directory, scandir ''
Error: ENOENT: no such file or directory, scandir ''
    at Object.fs.readdirSync (fs.js:910:18)
    at traverse (/Users/lirsacc/projects/sample-project/node_modules/rollup-plugin-fill-html/dist/index.cjs.js:102:20)
    at Object.onwrite (/Users/lirsacc/projects/sample-project/node_modules/rollup-plugin-fill-html/dist/index.cjs.js:162:4)
    at /Users/lirsacc/projects/sample-project/node_modules/rollup/dist/rollup.js:10609:40
    at next (/Users/lirsacc/projects/sample-project/node_modules/rollup/dist/rollup.js:148:27)
    at /Users/lirsacc/projects/sample-project/node_modules/rollup/dist/rollup.js:152:48
    at <anonymous>

I've tracked it down to https://github.com/alwaysonlinetxm/rollup-plugin-fill-html/blob/master/src/index.js#L32 where config.dest is now undefined and the file path is now available under config.file. I guess this applies to the multi-targets case a couple lines down as well.
Some details on the config changes can be found in this gist according to rollup's changelog.
Sorry for the noise in case you're already working on that; if not I could also make a PR with a fix if I find some time over the weekend.

@lirsacc Thank you for your reminding！I have just found the problem from the newest release of rollup yestoday, but have not got time to fix this, as I am a little busy recently. So,it will be very kind of you if you cold make a PR to fix this!

Done, see #5.

@lirsacc Have merged.


Exponential distribution as prior

In-house version of #304, updated for GPflow 1.0.

Codecov Report

Merging #717 into master will decrease coverage by 0.01%.
The diff coverage is 81.81%.

@@            Coverage Diff            @@
##           master    #717      +/-   ##
=========================================
- Coverage   98.11%   98.1%   -0.02%
=========================================
  Files          48      48
  Lines        4134    4162      +28
=========================================
+ Hits         4056    4083      +27
- Misses         78      79       +1

Impacted Files
Coverage Δ

gpflow/priors.py
89.18% <81.81%> (-1.29%)
:arrow_down:

gpflow/training/tensorflow_optimizer.py
98.96% <0%> (+1.46%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a412f6...293d8bc. Read the comment docs.

The patch codecov fails because of the sample() method - which isn't tested for any of the other priors, either. Should we add pragma no covers or how do we test a sampling method ?

Hello Ti,

Should we add pragma no covers,

https://github.com/GPflow/GPflow/blob/master/contributing.md#code-quality-requirements

how do we test a sampling method?

Testing moments?
PS: Please, do not ignore PR templates.

Commented-out code will be incorporated in #721


[RFC] Use Moya as the main Network Layer

Why
Benefit

We can stop maintaining our network layer.
Every projects have the same network layer.
Knowledge transfer between projects.
Ease of onboarding because Moya is easier to read than Alamofire.

Acceptance Criteria

Add Moya to the project.
Remove redundant network layer code.

Resources
https://github.com/Moya/Moya/tree/master/docs

Should we adopt Moya?
/polls Yes, let's go 🚀 'No, I love current network layer'

Please vote in the discussion


Expose groupby agg configs to drop_duplicates (distinct) egg

Extends the use groupby config params of split_out and split_every to the drop_duplicates operation.

Codecov Report

:exclamation: No coverage uploaded for pull request base (datafusion-sql-planner@89837d8). Click here to learn what that means.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             datafusion-sql-planner     #575   +/-   ##
=========================================================
  Coverage                          ?   57.87%
=========================================================
  Files                             ?       72
  Lines                             ?     3568
  Branches                          ?      723
=========================================================
  Hits                              ?     2065
  Misses                            ?     1370
  Partials                          ?      133

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


cursor jumping issue

Type: Bug
whenever im typing a code the text cursor is always jumping  other lines ,  even  if iam not changing its position .  Although  in  when i type in any thing except vs code the cursor works fine   .   iam getting frustrated  by this issue  ,  it always  disrupt my code . plz  resolve this issue ASAP.
VS Code version: Code 1.80.1 (74f6148eb9ea00507ec113ec51c489d6ffb4b771, 2023-07-12T17:22:07.651Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
12th Gen Intel(R) Core(TM) i5-1240P (16 x 2112)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.69GB (7.45GB free)

Process Argv
--crash-reporter-id e9717b8a-4738-41ed-af4f-eb6eb5a396b5

Screen Reader
no

VM
0%

Extensions (10)

Extension
Author (truncated)
Version

vsc-material-theme
Equ
33.8.0

prettier-vscode
esb
9.19.0

auto-close-tag
for
0.5.14

code-runner
for
0.12.0

rest-client
hum
0.25.1

cmake-tools
ms-
1.14.34

cpptools
ms-
1.16.3

cpptools-extension-pack
ms-
1.3.0

material-icon-theme
PKi
4.29.0

cmake
twx
0.0.17

(5 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdf:30486550
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
3biah626:30602489
f6dab269:30613381
vscrpc:30673769
2i9eh265:30646982
showlangstatbar:30737416
vsctsb:30748421
03d35959:30757346
pythonfmttext:30731395
pythoncmvfstrcf:30756944
fixshowwlkth:30771522
showindicator:30785052
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30779714
pythonidxpt:30784022
pythonnoceb:30776495
h7j2d465:30786200
dsvsc013:30795093

/confirmPlease

Please perform the following three tasks to diagnose the root cause of the issue:

[ ] 1.) Disable Extensions

Select View and pick Command Palette...
Run Developer: Reload With Extensions Disabled
👉 See if the issue reproduces

[ ] 2.) Disable Configuration

Select View and pick Command Palette...
Run Profiles: Create a Temporary Profile
👉 See if the issue reproduces

[ ] 3.) Try VS Code Insiders

Download VS Code Insiders
Install and Run it
👉 See if the issue reproduces

Then pick one of the three resolutions depending on which step has helped:

Disabling my Extensions helped
Please run the command Start Extension Bisect and follow the instructions to find the extension that is causing this issue.

Please report the issue to the extension causing this.

Disabling my configuration helped
Please report back more details about your configuration, including settings.

Using VS Code Insiders has helped
✅ This likely means that the issue has been addressed already and will be available in an upcoming release. You can safely use VS Code Insiders until the new stable version is available.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Release 3.8

Add

require option to TextField
--mdc-required-input scss variable to TextField
--mdc-drawer-height scss var to Drawer
$$props.class to Page

Fix

Drawer/Page height: 100% not allowing Page to fill and forcing Footers from their intended place

Do you need to update package.json?

nope, it's all automated. Its probably a good idea to include this type of info in the README though, like a link to the commit message format and that the CHANGELOG and package.json version get updated automatically.

:tada: This PR is included in version 3.8.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add date validator

Provide a narrative description of what you are trying to accomplish:

[ ] Are you fixing a bug?

[ ] Detail how the bug is invoked currently.
[ ] Detail the original, incorrect behavior.
[ ] Detail the new, expected behavior.
[ ] Base your feature on the master branch, and submit against that branch.
[ ] Add a regression test that demonstrates the bug, and proves the fix.
[ ] Add a CHANGELOG.md entry for the fix.

[x] Are you creating a new feature?

[x] Why is the new feature needed? What purpose does it serve?
[x] How will users use the new feature?
[x] Base your feature on the develop branch, and submit against that branch.
[x] Add only one feature per pull request; split multiple features over multiple pull requests
[x] Add tests for the new feature.
[x] Add documentation for the new feature.
[ ] Add a CHANGELOG.md entry for the new feature.

[ ] Is this related to quality assurance?

[ ] Detail why the changes are necessary.

[ ] Is this related to documentation?

[ ] Is it a typographical and/or grammatical fix?
[ ] Is it new documentation?

Thanks, @harikt ! I've pushed a few minor refactors to clean up the logic a bit, and will merge momentarily!


selection.adjoin?

It might be nice to have an adjoin operator (or some other name), similar to insertAdjacentHTML. See this thread:
http://groups.google.com/group/d3-js/browse_thread/thread/9848de9bb20fb216

Sounds useful.  We could consider calling it "after", like jQuery.

Yeah, I thought about that, but insertAdjacent has four modes: afterend is just one variant. beforebefin etc.

I thought some more about this (while biking, hooray) and there's another interesting consideration: symmetry with select. As with append and insert, select can only descend into elements, and cannot be used to select siblings. Therefore, if we introduce a new syntax for inserting siblings:
dom.append("parent")
  .append("brother")
    .attr("name", "bob")
  .adjoin("sister", "afterend")
    .attr("name", "alice");

you probably need a similar syntax for re-selecting the siblings. Otherwise, you'll be back to using local variables on update:
var parent = dom.select("parent");
parent.select("brother").attr("name", "bob");
parent.select("sister").attr("name", "alice");

I suppose select and selectAll could take a second argument, similar to adjoin. Though, this might suggest extending append rather than introducing a new adjoin operator. For the same reason, I think it's nice to use a different name to make it more obvious that the selection is not descending.
dom.select("parent")
  .select("brother")
    .attr("name", "bob")
  .select("sister", "afterend")
    .attr("name", "alice");

All of this may be subsumed by Selectors Level 4, which allow you to specify the contextual reference element using the :scope psuedo-class, along with the $ operator that lets you specify the subject of the selector. I think this would work like so:
dom.select("parent")
  .select("brother")
    .attr("name", "bob")
  .select("$sister + :scope")
    .attr("name", "alice");

That's a bit fancy, but I think it means: select the sister element that immediately precedes the currently-selected brother element. You could also specify a general preceding sibling using "~" rather than "+".
This could be extended to insert as follows:
dom.append("parent")
  .append("brother")
    .attr("name", "bob")
  .insert("sister", ":scope")
    .attr("name", "alice");

This means: insert a new sister element before the currently selected element. We'd have to change the implementation of insert slightly so that the selected node's parent is used for the insertBefore rather than the current node.

I guess all of this is possible using XPath, which is already supported in a variety of browsers, but not IE9, frustratingly! The implementation would be something like this:
document.evaluate(selector, element, null, XPathResult.FIRST_ORDERED_NODE_TYPE).singleNodeValue

Select usage:
dom.select("parent")
  .select("brother")
    .attr("name", "bob")
  .select("preceding-sibling::sister")
    .attr("name", "alice");

Insert usage:
dom.append("parent")
  .append("brother")
    .attr("name", "bob")
  .insert("sister", ".")
    .attr("name", "alice");

That's all pretty elegant, but alas you'd need some way of disambiguating whether the selector was a W3C selector or an XPath expression. Since select can take a function as an argument, you can pass in a function to select, say d3.xpath(expression). But that still leaves the problem of IE9, and this is a bad solution because it introduces a wholly different syntax for people to learn.


Python: ignore_unknown_formats=True does not seem to work

Taking the example from pypi and the latest jsonschema_rs version 0.26.1. This example should raise but it does not.
>>> import jsonschema_rs
>>> invalid_schema = {"type": "string", "format": "unknown"}
>>> jsonschema_rs.Draft202012Validator(invalid_schema, ignore_unknown_formats=False)  # Raises an error
<Draft202012Validator>

I think the issue title should read ignore_unknown_formats=False.
In any case, I can replicate the behavior (no error raised, where an error is expected).

Oh, this is actually not a bug. You need to also set validate_formats=True to raise the error.
From the 2020-12 draft release notes (emphasis added):

The format vocabulary was broken into two separate vocabularies. The "format-annotation" vocabulary treats the format keyword as an annotation and the "format-assertion" vocabulary treats the format keyword as an assertion. The "format-annotation" vocabulary is used in the default meta-schema and is required. In Draft 2019-09, format should be evaluated as an annotation by default and implementations could provide configuration to change the behavior to evaluate format as an assertion. The separate vocabularies allow for removing the special configuration requirements and just use the vocabulary system to express which behavior should be used.

Thank you @jpmckinney for the investigation !


My preferred working procedure

Hi trendschau,
since latest_translations encounters conflicts while i18n_on_version137 can be joined without conflict on version137, not being a genius about github, it is more convenient for me:

make a clone of your latest versionXXX
make my changes
create a new branch i18n_on_versionXXX

In this way I am more confident of the changes made that I can test simply.
Tell me if it's okay with you?

Hi iusvar,
yes, I am not a genius in git workflows, too, and I am still looking for a good strategy (last time I merged some old code somehow, don't know how it happened).
Your workflow sounds nice, cloning latest version and I will merge your latest i18n back into the version-branch.
Let us try it that way!

BTW i will update the version with the new frensh translation in the next hour...

Workflow has been described in #167 , I will create a separate ticket that describes the workflow and pin it


[KOGITO-839] Adding Istio annotation to KogitoApp generated pods

See:
https://issues.redhat.com/browse/KOGITO-839
In this PR we added the possibility to have istio annotations. Needs more testing, specially with the full Istio infrastructure.
Here's the image:
https://quay.io/repository/ricardozanini/kogito-cloud-operator?tab=tags (0.8.0)
@kmacedovarela
To test it, the operator must be installed via YAML files and the kogitoApp CRD applied. I'll be on PTO next week. Could you please try to test it? If you run into problems, please ask @radtriste that he will help you :)
Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Your feature/bug fix has a unit test that verifies it
[ ] You've tested the new feature/bug fix in an actual OpenShift cluster

+100
Thanks @ricardozanini for this one.

+100
Thanks @ricardozanini for this one.

Have you seen the docs/code comments? Could you please review?

@ricardozanini It is good my standpoint. if you want, you can me assign as review for another green mark. :)

@ricardozanini It is good my standpoint. if you want, you can me assign as review for another green mark. :)

Just try to test it please, I'm curious about running this on an Istio cluster. I'll give it a try when I come back as well.

I’ll rebase and merge this night. @spolti could you please resolve your comments if you are happy with the replies and approve? Many thanks!!
@gbaufake have you tested with the given image? :-)

Done, thanks.


Changed file dialog to native via rfd

egui_file_dialog was pretty unstable on my system, so i thought it would be good idea to use native file dialogs instead. They provide bookmarks, latest accessed locations, which is better for user anyway.
Also egui_file_dialog was ignoring doubleclicks sometimes, and is not updated regularly.
Yes, bgkillas, it is not sleek looking on windows compared to eguis' UI, i agree, but at least it would always work on any system.
Tested on Manjaro Gnome Wayland built with Ubuntu 20.04 docker container, Windows 10 in VM built via github-actions artifact.

Clearing actions cache fixed the build issue for me


style: Confirmation Modal should include a label for the PIN input

I think I prefer this w/ buttons that aren't stacked, but I'll defer to the existing designs or @caleboller


Easier way to understand something in _config.yml[Question]: Please add a title

Summary
First, I run bundle exec jekyll serve and it work.
Now i want to change something.
Example, I change titile in _config.yml file, tittle="something"

but my website have no change, even thought, I pressed F5

I found a way to do it, re-run application, I think it 's not good
ple, help me

I'm afraid this is how Jekyll works, changing the config file in any Jekyll project means stopping the serve command and restarting it to see the change in the localhost site. This shouldn't be a problem if you're deploying it to some sort of deployment based hosting platform


Remove custom routes

follow up to https://github.com/probot/probot/issues/1498
Feature Request
Is your feature request related to a problem? Please describe.
When we created Probot, it was built as a custom express server that would be deployed as a long-living node process. As we already had the express server, it was easy to add an API to register custom routes.
Today's reality is that people want to use serverless functions instead. With servereless functions probot is no longer in control of routing. In order to help people transition from one to the other, we removed all server/routing functionality from the Probot core class and moved it into a helper function that is passed to a probot app function. It looks like this
module.exports = (app, { getRouter }) => {
  // Get an express router to expose new HTTP endpoints
  const router = getRouter("/my-app");

  // Use any middleware
  router.use(require("express").static("public"));

  // Add a new route
  router.get("/hello-world", (req, res) => {
    res.send("Hello World");
  });
};

But we also made the probot framework de-composable. We expose a Server class now which is a slightly customized express server, and that server instance can register custom routes:
const { Server, Probot } = require("probot");
const app = require("./index.js");

async function startServer() {
  const server = new Server({
    Probot: Probot.defaults({
      appId: 123,
      privateKey: "content of your *.pem file here",
      secret: "webhooksecret123",
    }),
  });

  await server.load(app);

  server.expressApp.get('/hello-world', (request, response) => {
    response.send('Hello World!')
  })

  server.start();
}

Describe the solution you'd like
I want to remove the functionality for custom routes out of Probot core entirely, and instead improve the documentation on how to use Probot as express middleware. We could also add more examples for all common node server frameworks
Describe alternatives you've considered
We already implemented the 2nd { getRouter } option passed to Probot app functions. But { getRouter } is simply not set when run in a serverless environment, it's confusing.
Teachability, Documentation, Adoption, Migration Strategy
We should add documentation about how to use Probot as part of an existing server, or how to build your own custom server using Probot.

When will this issue be resolved and merged to milestone 13?

pull requests welcome

I say, we should target this for probot 14

I agree, probot 13 is complex enough.


put jobs in queues to ensure order

create in memory queue for each worker

[ ] one lucky reviewer

LGTM, though it's weird you kept with the cb


Repo sync for protected CLA branch

The pull request is created from main637868665375157935 to main to fix git push error for protected CLA branch

@PRMerger10 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add multiple agent server used in roud robin to help debug worker that are not sending requests to the rigth agent

An idea would be to rewrite the IAgentHandler such as
public async Task ReleaseServer(WebApplication, ...);
public async Task<WebApplication> GetServer(...);


convert_from_indices

Greetings!
https://github.com/MannLabs/alphatims/blob/f6e55e899b5a92e831852d7b9d96a2cc00a685eb/alphatims/bruker.py#L1262
I'd like to access the first X frames of the data.  I don't want to go with standard indexing because I only need a couple of fields.  I'm attempting to use .convert_from_indices and it produces strange results.
# accessing the first two frames
data[[1,2]].shape
# returns (6879, 14)

data.convert_from_indices(
    raw_indices=None,
    frame_indices=[1,2],
    return_tof_indices=True,
)

_['tof_indices'].shape

# returns (1, 8838754)
# an array of arrays!
# the length of inner array is the length of whole run

I've read the function 5 times but don't understand how this happens... :)

I can get around it by asking
data.convert_from_indices(
    raw_indices=data[[1,2], "raw"],
    return_tof_indices=True,
)

Not a big deal - was just wondering if that's expected behaviour.

Dear @liquidcarbon, thanks for checking in again. Your second approach with "raw" slicing is the route I always take myself as well.
That said, I do understand the confusion with the first approach. From a technical perspective, it boils down to lines https://github.com/MannLabs/alphatims/blob/f6e55e899b5a92e831852d7b9d96a2cc00a685eb/alphatims/bruker.py#L1412-L1413
Since return_tof_indices is True, AlphaTims will slice the tof_indices as requested. However, providing a None slice is the same as a full : or Ellipsis ... slice, hence all elements are returned.
The confusion probably lies more in the conceptual idea of the function. It is intended to convert raw_indices to their actual coordinates. The additional frame_indices and other index options are only intended for performance reasons and to avoid additional computation.
This is somewhat hinted at by the fact that raw_indices are the only accepted non-keyword argument. Probably it is a good idea to remove the default None option to show this is an essential keyword and to update some of the documentation. If you have any suggestions, feel free to make PR into the dev branch. If not, I'll probably get to this myself in the future at some point...


UI cleanups and fixes by @vallmoy

Bit late to the party but this all looked fine to me.

Bit late to the party but this all looked fine to me.

Appreciated nevertheless!


added corresponding CBOR tags as comments for better orientiation

in gluecose-schema.cddl

Oops, looks like the PR for tests of singing weren't signed. Please see the details for the DCO failure.

Oops, looks like the PR for tests of singing weren't signed. Please see the details for the DCO failure.

So I am signing off now you say. Sure. Why not :-) Let's see how often I'll forget to do that.


feat(console): add some well known links in app detail, add refresh token grant type in dev mode creation

Closes #4827

Should the API- and well known URLs go to the organization overview? Because they aren't application specific, and you can also authenticate using a PAT for example, right?

I guess the main point is to have the most used links at one place (#3573).. At a later point, our dynamic API docs should provide this information (#4839)


WIP: Add storage pool resource

This patch adds a resource type for libvirt storage pool.
Known issue:
The tests TestAccLibvirtPool_ManuallyDestroyed and 'TestAccLibvirtPool_UniqueName' currently fail. I failed to figure out why yet.
Fixes #435.
As obvious from the title, this is still WIP. I just wanted to publish it already to get possible early feedback and maybe help with figuring out why exact the tests are not passing. Next steps:

Add update implementation.
Add docs.
Fix the failing tests.

Actually, after implementing Update, I found out that libvirt currently does not support even renaming storage pools so Update would fail with an error. So I'm wondering if we want Update at all? If we do, it shouldn't be a lot of work to implement it in libvirt but I'm wondering if it's worth it, given that nobody every asked for this feature from libvirt before.

if libvirt doesn't support update we should document it in the doc as limitation imho. thx @zeenix for working on this

@MalloZup Thanks. Will add to docs, which is next.

So I added the docs and I fixed the testcase for unique names. From my side the only thing left is the failing TestAccLibvirtPool_ManuallyDestroyed test. After spending a lot of hours on this, I at least figured out why it's failing. The reason is simple: This implementation is not able to cope with pool deletion behind Terrform's back, as it should and that's what the testcase is supposed to test.
What is a big mystery to me still is that terroform destroy runs successfully for volumes even if you delete the volume before that but the same is not true for the pool implementation despite the fact that I'm doing exactly the same as Volume implementation is doing (since I copied and updated that code): error out if resource being deleted can not be found.
So I'd really like a second pair of eyes to see what I'm missing here.

thx @zeenix for your time. we will have look

I have looked little on the pr code and found out only difference is in the exists volume implementation, there is a try hard look-up function this is spread on all resources. Otherwise you are right. I might to check next week better on it

What is a big mystery to me still is that terroform destroy runs successfully for volumes even if you delete the volume before that but the same is not true for the pool implementation despite the fact that I'm doing exactly the same as Volume implementation is doing (since I copied and updated that code): error out if resource being deleted can not be found.

Best way to triage this is to create a test-case.

I have looked little on the pr code and found out only difference is in the exists volume implementation, there is a try hard look-up function this is spread on all resources.(not in pool) Otherwise you are right. I might to check next week better on it. AFAIK the exist function, should prevent error out, if an user remove a volume manually , and we do terraform apply we shouldn't error out but only update the resources files data in tf state

Those "hard lookups" were, IIRC added very early to workaround race issues in libvirt.

Thanks @MalloZup and @dmacvicar for reviewing.

* This is not a _pool resource_, but a _dir pool resource_. There is no way to create something different, and this will not be immediately obvious to the users.

I understood that we can later add support for other types of pools by adding more attributes (e.g type) when there is a demand for it, without breaking anything. Is this understanding not correct?

* This limitation is hardcoded in the design. _type_ is hardcoded in the XML created. The _dir_ specific setting _path_ leaks to the schema.

If you are talking about xml attribute in resource schema, I actually didn't touch that when i copied volume resource code over as the starting point. I can have a look at what that really does/is and fix it. :) If you're not talking about that, I would need more context/pointers. :)

* The first issue we will get after merging this, is somebody asking for a different pool type

As long as new attributes/types can be added later, that's not an issue. Otherwise, I can add attributes already for type so other types of pools can later be added.

Those "hard lookups" were, IIRC added very early to workaround race issues in libvirt.

Hm.. do you have any idea why manual deletion doesn't break destroy operation for volume but only for pool?

@zeenix @dmacvicar :
Imho what we need here is to create a generic interface with 2 layers abstraction, so we can enable plug-gable pools.
As i understand also libvirt upstream, some attributes varies depending on the type of the pool
the 1st layer would be :
mandatory
	"name": {
				Type:     schema.TypeString,
				Required: true,
				ForceNew: true,
			},
         "type": {
				Type:     schema.Map,
				Required: true,
				ForceNew: true,
                             ... ( see 2nd layer)
			},

name is the name of pool.
the type would be the type of pool  which will contain other maps, which will be the implementations e.g directory, disk pools etc , which they will be other maps.
2nd layer
			"type": {
				Type:     schema.TypeMap,
				Required: true,
				ForceNew: true,
				Elem: &schema.Resource{
					Schema: map[string]*schema.Schema{
						"dir": {
							Type:     schema.TypeMap,
                                                            // implementation here  which will be the fields for the map
							},
						"disk": {
							Type:     schema.TypeString,
                                                           // implementation here
						},
						"scsi": {...

https://www.terraform.io/docs/extend/schemas/schema-types.html#typemap

Imho what we need here is to create a generic interface with 2 layers abstraction, so we can enable plug-gable pools.

@MalloZup Thanks. Sounds good to me but I could easily be missing something important here. :) So if this sounds good to @dmacvicar as well, I can change my PR accordingly.

@MalloZup I tried with
            "type": {
                Type:     schema.TypeMap,
                Required: true,
                ForceNew: true,
                Elem: &schema.Resource{
                    map[string]*schema.Schema{
                        "dir": {
                            Type: schema.TypeMap,
                            Required: true,
                            Elem: &schema.Resource{
                                Schema: map[string]*schema.Schema{
                                    "path": {
                                        Type: schema.TypeString,
                                        Required: true,
                                        ForceNew: true,
                                    },
                                },
                            },
                        },
                    },
                },
            },

as schema and test case:
                resource "libvirt_pool" "%s" {
                    name = "%s"
                    type = {
                        dir = {
                            path = "%s"
                        }
                    }
                }

but i get error: type (dir): '' expected type 'string', got unconvertible type '[]map[string]interface {}'. Which part is wrong? The spec or the testcase?

https://github.com/dmacvicar/terraform-provider-libvirt/blob/6536f78a60151315f3e281d88de8fc127bfbbaa2/libvirt/resource_libvirt_domain_test.go#L684

afaik you don't need the =

Yeah i tried without as well. Still the same.

take this examples:

I did, since it's the only example of Map in the resource implementations I could find. However, that's more basic since it's a map rather than map of a map.

@zeenix  Take inspiration from this https://github.com/terraform-providers/terraform-provider-nutanix/blob/03625014f48382e934bda2e4648ff097262e6161/future/volume_group/data_source_nutanix_volume_groups.go.future#L131.
We could use a TypeList/.TypeSet of TypeMaps ( which should be not mandatory or should exclude themselfs).
It might be a terraform limitation/design to don't allow nested maps in this way

@MalloZup I actually thought of List+Map but didn't want to go for that because then we can't mandate one of the types in the schema, i-e people could provide multiple types or even worse, no types under 'types' and it'll be valid spec as per the schema.
Other solutions that come to mind:

Separate resource types for each of the pool type. This would be easiest as I just need to rename basically but there will be a bit of code duplication.
Separate backend-specific resources corresponding to pool's target node (libvirt_pool_dir_target in this case) and a target field under pool resource to connect them both. This will be a bit of a work, also more complicated for users.

Unless we're ok with the problem with using of List+Map I mentioned above, I'd say we should just bite the bullet and go for idea 1.

I think that 1 is valid option allthough we should more investigate the maps of maps approach, e. G find out if it is a terraform bug limitation and at least open an issue if it that the case (I did not researched lot on that)

I think that 1 is valid option

Cool, I'll go for that one then.

allthough we should more investigate the maps of maps approach, e. G find out if it is a terraform bug limitation and at least open an issue if it that the case (I did not researched lot on that)

Actually I did quite a bit of searching yesterday and the only thing that I found that came close was this (and similar articles/posts) but it's about nested maps in variables and not about how custom resource providers can do this.

Solution 1 implemented. PTALA

thx @zeenix i have also opened an issue upstream ( hashicorp/terraform#20927).
So recapitulating,  ManuallyDestroyed still fail.  Besides the schema pb.
To me , i agree it is a trade-off but could be ok. Let's wait for @dmacvicar  opinion on the schema. Meanwhile i will try to help you once i have some time on the failing tests.

https://github.com/hashicorp/terraform/issues/6215
https://github.com/hashicorp/terraform/issues/20927#issuecomment-479953877
:(  I think the only way for us is to have a libvirt_poo_dir and libvirt_pool_type as we already implemented.

:( I think the only way for us is to have a libvirt_poo_dir and libvirt_pool_type as we already implemented.

Oh well, I think it's not too bad actually. When we add another pool resource, much of the code can be reused and moved to a separate file but I don't see the point of doing that right now.
So that brings us to the failing testcase. So nobody has any clue why the manual pool deletion works for volume and not for pool?
Also the CI here doesn't run the added test, since it's passing?

@zeenix  for the test i actually didn't have the time  for diving it.
about the ci on PRs the problems is that we need libvirt, which in travis/circleci is really problematic to setup. We had in the past anhack in travis but it was not easy to maintain. If you have any idea/improvents in that direction feel free to experiment :grimacing:

@zeenix for the test i actually didn't have the time for diving it.

Oh ok. I was hoping @dmacvicar might have some insight. I'll ask some other folks around if they could take a look as well.

about the ci on PRs the problems is that we need libvirt, which in travis/circleci is really problematic to setup.

I'll add to my TODO to look into that. :) Any specific reason it was problematic? If it was using system libvirt, I can imagine how that can be problematic to sandbox. We should use session libvirt.

All test pass now. :)
About the CI, I had a brief look and yes, it does make use of system libvirt, which is problematic to setup on CI env. AFAIK, most tests should work fine on session libvirt connection except for the network creation bits so next week i'll look into reviving the CI, using session libvirt this time around.

@zeenix  regarding the CI can you open an issue and share your insight about this? tia :+1:

@zeenix regarding the CI can you open an issue and share your insight about this? tia +1

Done: https://github.com/dmacvicar/terraform-provider-libvirt/issues/579

@zeenix I will need some time to review this. Please stay tuned.

@dmacvicar Sure thing but I hope it's going to be soon. :)

Thanks for reviews, tests and very encouraging words in general @MalloZup. :)

@dmacvicar I understand you're very busy but just wanted to remind about this issue since it's been waiting for more than 2 weeks now.

/retest

@dmacvicar Thanks for the review. I'll make the changes. :)

@dmacvicar PTALA.

Otherwise, apart of that, and trivial stuff like make test failing on me while testing the code because of trivial stuff like vet, I think this can be merged.

Strange. Test succeed here:
$ make testacc TEST_ARGS="-run TestAccLibvirtPool"
./travis/run-tests-acceptance -run TestAccLibvirtPool
+ go test -v -covermode=count -coverprofile=profile.cov -timeout=1200s -run TestAccLibvirtPool ./libvirt
=== RUN   TestAccLibvirtPool_Basic
--- PASS: TestAccLibvirtPool_Basic (13.97s)
=== RUN   TestAccLibvirtPool_ManuallyDestroyed
--- PASS: TestAccLibvirtPool_ManuallyDestroyed (10.10s)
=== RUN   TestAccLibvirtPool_UniqueName
--- PASS: TestAccLibvirtPool_UniqueName (10.04s)
=== RUN   TestAccLibvirtPool_NoDirPath
--- PASS: TestAccLibvirtPool_NoDirPath (0.01s)
PASS
coverage: 6.3% of statements
ok  	github.com/dmacvicar/terraform-provider-libvirt/libvirt	34.140s	coverage: 6.3% of statements

I will re-review this PR this week and I think we can merge it if nobody is against it. Thx @zeenix . I will check if I have some issues locally with go vet

so I didn't have any problem with go-vet. However golint is failing and that is why also travis is faling.
make lint-check
go run golang.org/x/lint/golint -set_exit_status ./libvirt .
libvirt/pool.go:49:21: error strings should not be capitalized or end with punctuation or a newline
libvirt/pool.go:68:21: error strings should not be capitalized or end with punctuation or a newline
Found 2 lint suggestions; failing.

@MalloZup Getting closer to end of the week btw. :)

Thanks @MalloZup and @dmacvicar for your reviews and patience with me. :) I'm looking into #579 now. Fingers crossed if i succeed. :)

@zeenix thank you for this. :+1: welcome


version resolved to use data in Marker for flutter_map

@sandeshgyw it is safe to close/cancel this PR as it has been resolved another way - thanks.


New control script should include APITest project

A lot of the time, when the new control script is used, later, an API test project will be added. However, this often leads to issues as they might not be added properly or referenced in both solution files. In addition to this, anything that can be verified through an API test should be verified through that as they are faster and more reliable than interaction tests. Not having the API test project available when creating a new control makes it more difficult though to write API tests.

I would like to look into this.


Fix regexp match on right brackets

Related issue: #257
Related test262 tests:

ch15/15.10/15.10.2/S15.10.2_A1_T1
ch15/15.10/15.10.2/<IP_ADDRESS>/S<IP_ADDRESS>_A4_T7

Good to me

Looks good to me

Landed: 7a3636b5ce63d1fa017bbd9b1f8fbcabe3fcb186 & 57336909cbcaeca18687d6e8d2d8bd4a1e97d09e


Fix Auto Focus mode with with AfTrigger

Currently when you set AfMode to Auto Focus nothing really happens. Whats missing is the AfTrigger button to start the auto focus process

if you keep hitting AfMode it will attempt to refocus so thats kinda like the AfTrigger... shelving this ticket for now and will look at it again later if there is a use case)


[Question] Is it possible to flip actress first and last name?

Yua Mikami or Mikami Yua?
Just found this github, and I'm going through all the kinks to figure it out. Thank you so much for this.

Not currently.  I've got a task (#93) which suggests this as a new feature.  No promises if or when I can get to this, but maybe someday.