add built-in colormaps with transparency

@cgohlke
🚀 Feature

Napari offers a "translucent" volume rendering mode but there are no longer any built-in colormaps with transparency. Some built-in colormaps with transparency will be very helpful for work with that rendering mode.
Alternatives
Adding an interactive transfer function editor so users can adjust transparency settings will be even more useful.

Love the idea - do you have any experience with what these colormaps tend to look like in other softwares? I've thought about this before, particularly when rendering volumes with dark backgrounds on our white canvas in the light theme but wasn't immediately sure how to tackle it

@alisterburt
The current behavior of having 2 or more image layers with transparency settings resulted in the mix of color.
Red image layer + blue image layer of binary blobs, each with alpha = 0.5 for blobs and alpha = 0 for background:

The overlap shows up as the mixed color (purple).
The more desired behavior - at least for fluorescent microscopy images - is to keep the same color scheme and displays the color of the pixel that is closest to the view that has alpha value > 0:

This behavior has the advantage of conveying signals' relative positions and maintaining the ability to distinguish each channel when many colors may be involved.

Thanks for making this issue, @chili-chiu and for the examples! From my understanding, the behavior you would like to add is:

the ability to make "background" values (i.e., values below some intensity threshold) completely transparent.
render the scene such that each pixel only shows the value most "in front" image

Did I understand correctly?
For the transparent background, one option is to add a shader filter that "discards" (i.e., does not render) pixels that are below the threshold value. In this way, the "transparent background" behavior can be added for any colormap without having to create new colormaps. I made a prototype in this plugin. I am sorry, but it might be broken, as I made it as an experiment some time ago and haven't really revisited it. If you are interested, I could try to fix it and show it at the next Americas/Euro/Africa community meeting.
As a related aside, I think it would be nice to expose a way to easily attach/detach vispy visual filters. See the discussion in this twitter thread: https://twitter.com/martweig/status/1460643240588238849
For the rendering, this is a bit trickier, as we need to be able to figure out what is "in front". For isosurface rendering, I think this is clear, as we know the position of the surface being rendered. I could imagine taking a similar approach for max/min intensity projections (use the position max/min was found at. I am less certain what to do for average. Adding "depth" to our 3D image rendering is something @alisterburt and I have been wanting to add and we would be happy to discuss if you have some ideas or comments!

@kevinyamauchi this issue came about after @chili-chiu showed me the 'blending' mode in imaris. In this mode, the user plays with a widget which defines a mapping between intensity value and alpha value. This is similar to your plugin, but rather than one threshold you define a lower limit (below which a=0), a maximum alpha value (e.g. 0.8) and an upper limit (above which a=a_max).
We ran a quick experiment to replicate this functionality and @chili-chiu noted that when we set the alpha value to 0.5 in red and blue channels of the same intensity we end up with the purple you see in the overlaps here.
I think the question is: if we have two channels with different alpha values and different z heights at the same pixel, can we choose to render only that which is closest to the canvas and have it appear with the correct RGBA for the channel which is closest? i.e. maintain the colour and alpha, rather than blend with the colour and alpha from the other layer
I think this might be what happens with our opaque blending mode? really not sure though, would need to run some tests

Thanks for the clarification, @alisterburt .

I think the question is: if we have two channels with different alpha values and different z heights at the same pixel, can we choose to render only that which is closest to the canvas and have it appear with the correct RGBA for the channel which is closest? i.e. maintain the colour and alpha, rather than blend with the colour and alpha from the other layer

This is what would happen if we properly set the depth buffer for each image (I think for both transluscent and opaque blending modes). For each pixel, only the image closest to the screen would get rendered. However, the depth buffer is set by all of the visuals that have depth turned on, so they would potentially be other visuals "fighting". In #3398 , I introduced a translucent blending mode that doesn't depth check, so the user could set the layer they didn't want to have depth to that blending mode.
In case it is helpful, here are the gl settings that the different blending modes correspond with:
https://github.com/vispy/vispy/blob/99d04d20902aed96aeea13aec8e44979668112d4/vispy/gloo/wrappers.py#L37-L52

Any update on this issue? I would also benefit from this feature. Did someone find a workaround?

I found a workaround by defining custom colormaps, modifying this code.
Create a linspace cmap from white (1, 1, 1, 1]) to blue (0, 0, 1, 1):
colors = np.linspace(
    start=[1, 1, 1, 1],
    stop=[0, 0, 1, 1],
    num=10,
    endpoint=True
)

Select first value and change alpha value:
colors[0] = np.array([1., 1., 1., 0])

Define new colormap:
new_colormap = {
  'colors': colors,
  'name': 'white_to_blue',
  'interpolation': 'linear'
}

Add an image into napari with custom colormap:
viewer = napari.Viewer()
viewer.add_image(img, colormap = cmap)

The ideal result (in my particular application) is that only pixel values equal to 0 are transparent, but I'm not sure if this workaround makes other non-0 pixels transparent... I will play with this solution for a while, if I make it work as intended I'll update on this issue.

Thank you for sharing @Jose-Verdu-Diaz ! That's really nice and I'm glad it works for your application
Kevin has added depth buffer support to the vispy VolumeVisual so we really aren't far away from 'composable' raycasting through multiple volumes
I don't need this myself so will likely not get to it soon but if anyone would like to work on pushing this forward I would be keen to help/pair on the problem, don't hesitate to reach out

I started pushing on the depth side of this a bit in vispy/vispy#2305 - colormap side should be easy in a small napari plugin :)


Allow update_env/2 function as the option for Tesla.Middleware.Retry

The function takes the result and env from the previous attempt and
returns a new env for the retry request. It allows supporting "retry
with new authorization token" cases.

@yordis, no options were renamed. I've just sorted the list alphabetically for better readability.

🤦🏻♂ .... nevermind ... 🤦🏻♂

What’s the use case for updating the env on retry?
If feels a bit weird to add it as an option.
In case of authentication I’d probably write a custom middleware with something like:
case Tesla.run(env, next) do
  {:ok, %{status: 401}} ->
    env
    |> Tesla.put_header(…)
    |> Tesla.run(next)
  other ->
    other
end

@teamon beside that use case, I am trying to find who created an issue or comment or something where the person wanted to log the retries because it was important to him to know how many retries for a given endpoint were happening type of thing ...
For the use 401 use case, I would propose adding a middleware before the retry.

Also this, https://hexdocs.pm/opentelemetry_semantic_conventions/OpenTelemetry.SemanticConventions.Trace.html#http_retry_count/0
I intended to use this PR to try to change the http_retry_count in https://github.com/open-telemetry/opentelemetry-erlang-contrib/blob/main/instrumentation/opentelemetry_tesla/lib/middleware/opentelemetry_tesla_middleware.ex, and teach people how to connect them.
If you expose the OTEL context, you may also want such information.

So from my end, two use cases thus far,

Somebody asked to be able to log retries so they can collect metrics about it
Be able to add http_retry_count to a request.

Maybe Retry middleware should just add retry_attempt counter to env.opts?

Found the issue https://github.com/elixir-tesla/tesla/issues/578 @egeersoz; maybe you want to participate over here!

Hey there, thank you so much for taking the time to contribute, as @teamon said https://github.com/elixir-tesla/tesla/pull/537#issuecomment-1548363180 I recommend you write a custom middleware related to your authentication needs that reinject the new token.


OutOfMemoryError when uploading binary files in quick succession

We are using spring-cloud-starter-netflix-zuul Edgware.SR2 to build our gateway for our application, and ran in to a problem with Zuul between our Extract/Transform/Load (ETL) tool and our blob storage service.
The problem is that we are loading ~9000 files that are around 10-35 MB in size as quickly as our infrastructure will allow.  When we test direct against the blob storage service, we are able to handle a much larger volume.
The critical part of the stack trace is here (the actual service is on a disconnected network, so the line numbers might be off):
at java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:140)
at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1793)
at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1769)
at org.apache.commons.io.IOUtils.copy(IOUtils.java:1744)
at com.netflix.zuul.http.HttpServletRequestWrapper.parseRequest(HttpServletRequestWrapper.java:151)

The disconcerting thing is that it appears that Zuul is reading in the full content of the request in memory before sending the request on to it's final destination.  Our work around for now is to communicate directly with our blob storage service, bypassing Zuul for the moment.  However, that should not be necessary, and is a short term solution.
Further compounding this, it appears the request is closed out before reaching the blob storage service, which has to deal with a slow file system as a temporary workaround until our client is cloud enabled.  Those requests take time to process, so the old request hasn't cleared from memory before we send our next request.
We have a system coming up that we have to support that will need to handle hundreds of files that are up to 500 MB in size.  That means we need the requests to be streamed from one end to the other.  Even a couple files can easily blow the memory ceiling for Zuul.  These are not multipart/form uploads, but straight binary uploads to a rest endpoint.
We need to have at least some of our requests to be forwarded in-line with all the slowness that's in the microservice behind the Zuul proxy, and simply stream those requests without reading them all the way in memory at once.

Are you following the suggestions here? http://cloud.spring.io/spring-cloud-static/Edgware.SR5/single/spring-cloud.html#_uploading_files_through_zuul

We will try that and respond hopefully by tomorrow.

OK, that did work.  It saved a lot of memory and it was about 12% faster to upload all the files we had.
My question back is why is Zuul still going through the Spring RequestDispatcher at all?  Zuul is a critical piece of infrastructure that proxies all kinds of requests.  If there's a known path that causes memory problems and is slower, then that's a good argument to not use that code.

There may be other controllers and actuator that might be swallowed depending on the zuul configuration. It's likely more about buffering than request dispatcher as the servlet one is not buffered and the other one is.


Cloudflare Radar

Your website is blocked by Cloudflare services with Pornography tag.
I am using Warp zero trust by Cloudflare and the site is blocked by them.
You can see on Cloudflare Radar
https://radar.cloudflare.com/domains/domain/xuri.me

Thanks for your feedback. I have reported miscategorization to the Cloudflare team, now waiting for the review.

@xuri yeah ..I also submitted a report to remove that tag.
Just checked the webiste and cloudflare radare.
All good now
Closing issue


Design a logo for NodeCloud

A logo should be designed for NodeCloud library. It should reflect the functionality of NodeCloud at a glance.
Logo should be delivered in .png and .svg formats.

HI @rajikaimal ,
I have created a logo to NodeCloud. Hope this will meet the requirements

Hi !,
This looks good, any thoughts @rehrumesh ?

This is good. I'd like if we can change 'js' part into something else..

What if we add node logo in the middle? any other suggestions?
@rehrumesh @rajikaimal

surprise us with different options 👍

Yeah, maybe adding the logo will make a difference. Either way we'll see few mock ups and select the best one. 😄

Any suggestions guys?

![untitled-1](https://user-images.githubu

sercontent.com/19621902/32181727-186b2d60-bdbb-11e7-99ab-83116a9523b9.png)


GHA docker publish pipeline

Thanks for the suggestions, I appreciate it.
Keep in mind it's just a draft, it's not ready for review yet :)

Just took a GHA example and made some minor changes.
I think the real pipeline should be implemented after the discussion about versioning and all of this stuff.

Now it works on my side:
https://github.com/hiddenmarten/etcd-operator/pkgs/container/etcd-operator


refactor tests - rename method improve logging

Note that if the application fails to deploy test will fail no matter if you go via url or clicking through menu. Clicking through menu is imho just slower.
I understand that actions approach, on the other hand such a steps are bit more complicated to use since you need to keep context in test. I have found idempotent steps be more convinient.

When I check the current run: https://github.com/scalyr/dataset-addon-for-splunk/actions/runs/5975394444/job/16211261116?pr=74
  Slow test file: [chromium] › alert_action.spec.ts (3.0m)
  Slow test file: [chromium] › inputs.spec.ts (43.1s)
  Slow test file: [chromium] › examples.spec.ts (27.0s)
  Slow test file: [chromium] › search.spec.ts (20.6s)

With some previous run: https://github.com/scalyr/dataset-addon-for-splunk/actions/runs/5964013188/job/16178341279
  Slow test file: [chromium] › inputs.spec.ts (1.1m)
  Slow test file: [chromium] › search.spec.ts (42.1s)
  Slow test file: [chromium] › alert_action.spec.ts (31.3s)
  Slow test file: [chromium] › examples.spec.ts (23.6s)
  Slow test file: [setup] › global.setup.ts (15.4s)

The only speed up is as expected on the inputs/search since there are multiple tests. I agree, that it's fine to use url to get somewhere, but there should be at least one test for the navigation, to make sure, that it works.

I have added new test verifying that add on is deployed properly (asserting link and menu items)


handles MinPurchaseRequired Error

Description
Handles the MinPurchaseRequired error from the api.
If retirement amount is below the minimum purchase required, the modal informs the user and only gives the option to go back. It also clears the quantity in the retire inputs so that they are forced to enter in another number, as the Retire Carbon button will be disabled until they do.
NOTE: until the fix on the fiat repo is merged there will still be quote error on the one ton. This error is due to slippage being rounded off inexpensive tons.
Related Ticket

Resolves #1536
Changes

Before
After

Checklist

[X] I have run npm run build-carbonmark without errors
[X] I have formatted JS and TS files with npm run format-all

@psparacino confused on why we are doing this check on submit of the form vs on the form itself?
We have other validations already on the forms - can we not so the same with this check?

This error comes from the api on submission, thus this was the most straightforward method of initially handling. Yes, that makes sense for consistency though; I  edited this now so the min price is now available on the api before submission to enable an error before submission (not pushed yet). So the flow will be:

If the price is too low it will show an error, although they will still be able to click retire and continue (same flow as if the amount is exceeded)
If they click continue in the modal, the modal will display the error with only the option to go back and clear the quantity from the form.


Check your answers page

Story: https://trello.com/c/eLQkrUGd/203-dc-work-on-check-your-answers-page
This is a close implementation of this page in the prototype
Except it will have the buttons to add another sentence or another conviction until this story is completed
After

 [DC] Work on Check Your Answers Page

Will update the code according to the decision of todays meeting, I've commented on the card to reflect this https://trello.com/c/eLQkrUGd/203-dc-work-on-check-your-answers-page#comment-605876c00b3b3c0328f298f0
We don't want to break the results page for single convictions

Closing this PR to avoid confusion. Version 2 is the agreed version for this.


Remove dependency on msvcrt so we can run on non-Windows environments

https://github.com/kcsaff/getkey & https://github.com/moses-palmer/pynput look like two different portable options that might help

Resolved in version 0.3.
msvcrt removed. Now uses pynput module to monitor keyboard.

In addition to my previous comment, when running from the command line, with the git checkout installed via "pip install -e "path to setup.py", the error that is seen when running in PyCharm is not seen, however, the keypresses are not recognised with the exception of the enter key. Enter will advance the test, when numbers are pressed to enter the serial number nothing shows up.
The Pypi installed fixate has no issues.
Although it isn't clear from the image alone, I have attempted to enter a serial number in the terminal window on the right.


Update to Netty 5.0.0.Alpha3-SNAPSHOT changes

Motivation:
The build of the project is broken. This change is adapting the code to the changes in Netty 5 snapshot.
Modifications:

Remove the usage of syncUninterruptibly. https://github.com/netty/netty/pull/12481
Adapt to the changes in ChannelHandler:

userEventTriggered(...) is renamed to inboundEventTriggered(...). https://github.com/netty/netty/pull/12497
triggerOutboundEvent(...) is added. https://github.com/netty/netty/pull/12497
shutdown(...) and channelShutdown(...) are added. https://github.com/netty/netty/pull/12468

Result:
The build of the project is green again

@chrisvest thanks


fix: graceful error handling for macros/lists reference loops

What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
/area tests
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2310
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
fix: graceful error handling for macros/lists reference loops

/milestone 0.34.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: ad03deeac3c3d45f639489d3c4cf2d7c217da501

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


CP-6232: KeyNotFoundException

From unknown CodePlex user on Sunday, 09 September 2007 01:45:09
Some of my graphs cause a KeyNotFoundEception when trying to transform it into a gleegraph. Here is the code:

I start constructing an {{AdjacencyGraph}} followed by some lines to add vertices and edges:
{{
AdjacencyGraph<string, Edge> graph = new AdjacencyGraph<string, Edge>();
graph.AddVertex("someString1");
graph.AddVertex("someString2");
graph.AddEdge("someString1","someString2"));
}}

This code is highly simplyfied because my graphs are construced out of an XML tree and have about 20-30 vertices depending on the XML.
In the next step i generate the glee graph:
{{
GleeGraphPopulator<string, Edge> populator = GleeGraphUtility.Create<string, Edge>(graph);
populator.Compute();
Graph gleeGraph = populator.GleeGraph;
}}

But as said with some graphs already in the line {{populator.Compute();}} i get the following exception:
{{
System.Collections.Generic.KeyNotFoundException was unhandled
Message="Der angegebene Schlüssel war nicht im Wörterbuch angegeben."
Source="mscorlib"
StackTrace:
bei System.ThrowHelper.ThrowKeyNotFoundException()
bei System.Collections.Generic.Dictionary2.get_Item(TKey key)        bei QuickGraph.Glee.GleeDefaultGraphPopulator2.AddEdge(Edge e)
bei QuickGraph.Glee.GleeGraphPopulator2.InternalCompute()        bei QuickGraph.Algorithms.AlgorithmBase1.Compute()
....
}}

If it wuld be helpful i could try to output my vertices and edges to a textfile.

Form unknown CodePlex user on Tuesday, 26 August 2008 01:46:57
GLEE is not supported anymore.

Form unknown CodePlex user on Tuesday, 26 August 2008 01:47:19

Form unknown CodePlex user on Tuesday, 26 August 2008 08:57:15

Form unknown CodePlex user on Wednesday, 31 December 2008 07:17:05

Form unknown CodePlex user on Thursday, 21 February 2013 17:44:58

Form unknown CodePlex user on Thursday, 16 May 2013 04:59:30


Fix impossibility to use stateful ArrayFieldTeplate comp.

Specifically addresses https://github.com/mozilla-services/react-jsonschema-form/pull/304#issuecomment-287879581

Released in v0.44.0.


[Snap, Flatpak] Switch to GtkFileChooserNative

Would it be possible to add networking rights (on Ubuntu) to be able to access a mounted server.
I mounted my server on Ubuntu as a drive and it would be amazing to allow colleagues to interact with the ToDo-File there in order to allow several people to manipulate a single ToDo.txt - as in several people can use a joint TodoList.
It would be quite easy, since all sleek needs to do is being able to 'see' mounted servers in 'Files' and communicate with them via the built-in ftp client of Ubuntu. Quite easily sleek could communicate with different people via Google Drive, Dropbox, FTP, etc...

Hi @hideosnes. Do you download sleek from Snap Store?

Wow, that was a prompt answer :D - thanks for that. I used the Ubuntu Software App.

Hi @hideosnes. Can you tell how your network shares get mounted, my guess is you mount them in /mnt/? When sleek opens your file explorer, what exactly can you see and select?

Also I'm trying to figure out what the source of sleek in the Ubuntu Software App is (I'm on Arch Linux and have no Ubuntu at hand) is. sleek is published in the new Ubuntu (Canonical to be more precise) Store which is called Snap Store. Right now I am assuming the Ubuntu Software App uses Snap Stores apps (Snaps) as sources.
Anyhow, I added a new interface "removeable-media" (https://snapcraft.io/docs/supported-interfaces) to sleek's Snap beta-version. It is suppose to show mounts under /mnt/ and "media". In case your network shares are mounted there, this could provide you with access to those.
To install the beta version of sleek, you need to have Snap Store installed, which you can do using the Ubuntu Software App I guess. And then you just open up your terminal and type sudo snap install --edge sleek. If this works, feel free to give me a short feedback if it works.

Alright, I think I figured a few things out:
The Ubuntu Software App is the 'original' Version of the Snap Store - both are developed and maintained by Canonical. I'm using Ubuntu 18 and I think they developed the Snap Store for a more recent version of Ubuntu, however it is still possible to use the it on U18.
I was able to use sudo snap install --edge sleek ( though I had to remove my installed version of sleek :D beforehand ) and installed version 0.9.6 (snap store lists 0.9.5 as the latest) so I'm pretty sure I'm using the correct version.
Upon opening sleek I was able to add my old todo.txt (Just to mention, should the question arise: I had to rename the text file I created with sleek and add ".txt" manually because otherwise it wouldn't show up in the file-selector) and still, neither the mounted Google Drive (via Online Accounts) nor the server show up; only my local files stored on my HD (See attached screenshots)
However, I don't think the "removeable-media" is the right interface as it deals with USB devices and physical or virtual HDs (which might be quite useful in any case). From here on I can only speculate that its maybe the "network-manager" interface. It would make sense according to Ubuntu-Reference, though in the snapcraft-docs it doesn't say anything more specific.
I got curious, so I added a question in the snapcraft-forum. I'll keep you updated if that's alright with you.

@hideosnes, cool thanks, keep me posted! This might be nice little improvement for many users.
Reading your last comment, I am also considering to enhance sleek on the file creation process. If user don't add a file extension like .txt or .md, sleek can add a .txt per default.

As discussed here https://forum.snapcraft.io/t/question-supported-interface-for-online-accounts-or-mounted-servers/23470/9, until Electron is able to provide the GtkFileChooserNative API (https://github.com/electron/electron/pull/19159), we can't do anything on our side.
Once they finish the enhancement, I will adapt it.

Thanks a lot! I'll be looking forward to it.

@hideosnes I updated the Snap build process and since the rewrite of sleek updates all dependencies, we might want to check if there is a change here. Can you take a quick look if the latest pre-release change anything on your side? You can install it with this: sudo snap install --edge sleek

Should be also available in 2.0.2 in stable channel.


fixfix PolicyTest testMergeFilterNereidsPlanner failed

Proposed changes
Issue Number: close #xxx
The results of explain may have some order that is not fixed
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

run external

run performance


owid-catalog can't read a table outside of ETL

When reading a table within ETL using owid-catalog there are no problems. But when trying to read a table from an external repos (like co2-data), owid-catalog fails.
To replicate, create a brand new virtual environment, install the latest owid-catalog, and in a python console, run:
from owid import catalog
catalog.find("global_carbon_budget").sort_values("version", ascending=False).iloc[0].load()

The load is what causes the following error:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/owid/catalog/catalogs.py", line 363, in load
    return Table.read(uri)
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/owid/catalog/tables.py", line 169, in read
    table = cls.read_feather(path)
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/owid/catalog/tables.py", line 352, in read_feather
    cls._add_metadata(df, path)
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/owid/catalog/tables.py", line 331, in _add_metadata
    df._set_fields_from_dict(fields)
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/owid/catalog/tables.py", line 377, in _set_fields_from_dict
    self._fields = defaultdict(VariableMeta, {k: VariableMeta.from_dict(v) for k, v in fields.items()})
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/owid/catalog/tables.py", line 377, in <dictcomp>
    self._fields = defaultdict(VariableMeta, {k: VariableMeta.from_dict(v) for k, v in fields.items()})
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/dataclasses_json/api.py", line 70, in from_dict
    return _decode_dataclass(cls, kvs, infer_missing)
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/dataclasses_json/core.py", line 219, in _decode_dataclass
    init_kwargs[field.name] = _decode_generic(field_type,
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/dataclasses_json/core.py", line 290, in _decode_generic
    xs = _decode_items(_get_type_arg_param(type_, 0), value, infer_missing)
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/dataclasses_json/core.py", line 378, in _decode_items
    return list(_decode_item(type_args, x) for x in xs)
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/dataclasses_json/core.py", line 378, in <genexpr>
    return list(_decode_item(type_args, x) for x in xs)
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/dataclasses_json/core.py", line 371, in _decode_item
    return _decode_dataclass(type_arg, x, infer_missing)
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/dataclasses_json/core.py", line 219, in _decode_dataclass
    init_kwargs[field.name] = _decode_generic(field_type,
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/dataclasses_json/core.py", line 312, in _decode_generic
    res = _support_extended_types(type_arg, value)
  File "/Users/prosado/Documents/owid/repos/tmp/venv/lib/python3.9/site-packages/dataclasses_json/core.py", line 249, in _support_extended_types
    if isinstance(field_value, field_type)
TypeError: isinstance() arg 2 must be a type or tuple of types

I can't replicate it with a fresh new virtualenv and python 3.10. What's your python version and dataclass-json version (get it with pip freeze | grep dataclass)?

In the co2-data repos I'm using Python 3.9.4 (which should in theory be supported by owid-catalog), and dataclasses-json==0.6.1.


Add nodemon troubleshooting

I added troubleshooting about problems that occur when used with nodemon.
It's related to the #92 .

Hi @deunlee, thank you for the PR.
The PR can't be merged because that doesn't troubleshoot.
Also, that is unrelated to the issue directly.
Thank you for your time. :smile:


Negative power generation

Any idea why the power production in Hassio shows negative values, while this is not the case in the Myenergi app?

FYI in the Energy tab the negative values are not visible

Where is the data coming from? I get negative values (transients) from the GivEnergy server API, I presume ME filter all negative values, but on mine I see the night time power draw of the inverter when it’s in standby about 20W.
Do you have anyway of seeing the raw data from the inverter?

The power generation value plot I show above is coming directly from ME, which is clamped via a Zappi to the solar AC power cables.
Good point that this may actually be power draw from the inverter. I looked around in the app and web portal of my PV system, but couldn't find a measure for this. Also, as opposed to a 20 W continuous standby draw you talk about, mine seem to be isolated draws of about 100 W. You could still be right, but the profile seems a bit odd to me.

My Solaredge inverter takes a varying amount of power, 20W is more like an average, it moves around the values of 5 to 10 to 20 then 10, it will depend on your inverter design, but a sudden in-rush of power at reasonably regular intervals would not be unusual. You could try running the Python at the command prompt and see if the API is returning the negative values, I’m sure it will do if the readings exist and it’s not some other artefact.

Okay thanks for the feedback.
I'm not sure to which code you are referring, but I suppose it is a piece that gets the current values from ME? I can have a look, but to see the negative current, I suppose I would need to run the script exactly timed with a spike, which seems difficult to achieve.

Johan provides some Python scripts that can be run from the HA command line, it would be interesting to see if there was a negative current being reported. Yes difficult to capture an event that is not synchronous.
On the basis that most users are not reporting negative current spikes and ME probably suppresses them then it looks they are real and due to the inverter taking grid power when in sleep mode.

Ok, thanks for the feedback. That solves for me the 'issue'.


Linux instructions

Started to add instructions for how to get audiorecorder working in linux! Ultimately changes should probably be made to the brew formula to streamline this process. Also, this does not yet make the bwfmetaedit option functional.

Thank you @kieranjol and @retokromer!!


[Cypress][Draft] Fix failed test on v1.4.0 for the dashboard string changes

Which issue(s) this PR fixes:

Harvester issue: https://github.com/harvester/harvester/issues/6407
Test sssue: https://github.com/harvester/tests/issues/1535
What this PR does / why we need it:

Starting with v1.4.0, we have made some dashboard string changes in issue https://github.com/harvester/harvester/issues/6407

This change would cause cypress test to have around 46 failure result job #110

The corresponding test result:

Special notes for your reviewer:

Tested on the latest v1.4.0-rc1 cypress test result on Jenkins Harvester cypress test job # 114

According to the corresponding cypress test report

After the fix, the failed test reduced from 46 to 9

I just S3 backup target in the settings/setting.spec.ts and squash the commit.
Please check if it's ready to be merged. Thanks.


Error starting wterm in velox

Latest Wayland slackbuilds under Slackware.
Getting this error:
xdg_shell@8: error 0: use_unstable_version must be called first

I've verified the earlier call to xdg_shell_use_unstable_version is being called. So, I don't know why this error occurs? It seems to occur somewhere in the "draw" function based on quick debugging.
Any pointers on where to look to fix this? Im assuming xdg shell has updated , is there any way to use/lock to an older version? I'm unfamiliar with Wayland otherwise I would have those answers.

I think the wayland protocols I am using are dated, that's also something to check.
On Sun, Mar 11, 2018 at 02:03:37AM +0000, MichaelMackus wrote:

Latest Wayland slackbuilds under Slackware.
Getting this error:
xdg_shell@8: error 0: use_unstable_version must be called first

I've verified the earlier call to xdg_shell_use_unstable_version is being called. So, I don't know why this error occurs? It seems to occur somewhere in the "draw" function based on quick debugging.
Any pointers on where to look to fix this? Im assuming xdg shell has updated , is there any way to use/lock to an older version? I'm unfamiliar with Wayland otherwise I would have those answers.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/majestrate/wterm/issues/3

try latest commit.

Thanks! On gentoo now, I'll try to build for this platform & try again.


🚧 Add basic qtpy layer

I think this PR could help https://github.com/pyvista/pyvistaqt/issues/8 by using a thin qt abstraction layer.
The goal would be to have one code and change the QT_API accordingly or possibly auto-detect it.
Basic testing with PySide2 would be nice to have too.

What is missing now is synchronizing qtpy and vtk with the same implementation I think

When I use PySide2 as Qt backend, something wrong happens during the transfer of the parameters from QVTKRenderWindowAdapter to BasePlotter, the parameters dedicated to BasePlotter are evaluated as Qt signal or property (example with shape):
AttributeError: 'shape()' is not a Qt property or a signal

I evaluated the mro of each of the backends:
with PySide2:
[
	<class 'pyvistaqt.plotting.BackgroundPlotter'>,
	<class 'pyvistaqt.plotting.QtInteractor'>,
	<class 'pyvistaqt.plotting.QVTKRenderWindowInteractorAdapter'>,
	<class 'PySide2.QtCore.QObject'>,
	<class 'Shiboken.Object'>,
	<class 'pyvista.plotting.plotting.BasePlotter'>,
	<class 'pyvista.plotting.picking.PickingHelper'>,
	<class 'pyvista.plotting.widgets.WidgetHelper'>,
	<class 'object'>
]

with PyQt5:
[
	<class 'pyvistaqt.plotting.BackgroundPlotter'>,
	<class 'pyvistaqt.plotting.QtInteractor'>,
	<class 'pyvistaqt.plotting.QVTKRenderWindowInteractorAdapter'>,
	<class 'PyQt5.QtCore.QObject'>,
	<class 'sip.wrapper'>,
	<class 'sip.simplewrapper'>,
	<class 'pyvista.plotting.plotting.BasePlotter'>,
	<class 'pyvista.plotting.picking.PickingHelper'>,
	<class 'pyvista.plotting.widgets.WidgetHelper'>,
	<class 'object'>
]

So I can only assume that there is something different in the way the parameters are handled somewhere in PySide2 compared to PyQt5 (or maybe PyQt5 does something actually):
	<class 'PySide2.QtCore.QObject'>,
	<class 'Shiboken.Object'>,

At this step, I don't really want to mess with the inheritance sequence considering all the constraints:

inherit QObject
inherit QtInteractor
avoid duplicated call to BasePlotter.__init__()
allow multiple inheritance (QVTKRenderWindowInteractor, BasePlotter)

Maybe someone else can have a look at the mro and notice something strange that I missed?
Meanwhile, I'll keep thinking about the architecture.

I don't see any solution here without changing the architecture.

The architecture has been changed very recently in https://github.com/pyvista/pyvistaqt/pull/25.
Let's give it a try again.

It works for me locally with PySide2 but my ipython hangs after closing the MainWindow.

And I downgraded PySide2 to 5.14.2, I don't have this issue at all.

Code coverage is working!

Code coverage is working!

The coverage diff yes :), but the badge on the project is not updated:

@GuillaumeFavelier is this good to go? Maybe a rebase now that master has coverage working?

is this good to go?

This basic version should work but I would like to improve it further. For example in the case where both PySide and PyQt5 are installed, I need to make sure that QtPy and VTK use the same python Qt binding. Plus I want to rework the testing for it.

Maybe a rebase now

I'll rebase asap 👍

Hey. Just wondering what's holding this issue up? I actually ran the code locally on my machine and it seems to be working. My use case is that I really want to use pyvistaqt, but the pyqt5 licence is stopping me. Using qtpy instead of pyqt5 is a genius move that would allow users more freedom. I want to use pyside2, and it seems to be working.
Do you need help to get this done? Maybe update the documentation? The code examples would definitely need to be updated. I can help.

@larsoner , I see that @GuillaumeFavelier has not been active on this pull request for quite some time. I hope I'm not stepping on any toes, but if it would be helpful I can help with this issue.
I fetched Guillaume's branch and updated it with the pyvista master branch, and made some other small changes to get things working. I also updated the test files. I have submitted a pull request GuillaumeFavelier/pyvistaqt#1 to Guillaume's branch in the hopes that, if he accepts the changes, they will be automatically incorporated into this issue. If it's easier I can create a new pull request. Just let me know.
Anyway, I hope I'm not offending anyone. I just want to be helpful. Plus, I have some time now to work on this issue. Being able to use pyvistaqt with qtpy instead of pyqt5 would be a really wonderful thing, and would make pyvistaqt more usable to people who are afraid of pyqt5's license.

but if it would be helpful I can help with this issue.

Agreed we should move forward with this, I doubt @GuillaumeFavelier will mind. Feel free to start your own PR with his commits cherry-picked, then yours on top (with a merge or rebase with latest master to deal with the merge conflict). Or just start fresh without his commits if it's easier. @GuillaumeFavelier is a maintainer so as long as you check the "allow edits by maintainers" box @GuillaumeFavelier can automatically push commits to your branch, too, to continue working on it.

Thank you. My work was a continuation of his. I fetched his branch and just added commits to it. I'll create a new PR really soon.

@nicobako you're right, I didn't work on this for a while, thanks for the push! :)

Closing as duplicate of #61

I know I am coming to the party late, but I wanted to comment that the approach used here is proper on several levels. Not only does matplotlib also do this FigureCanvasQT, but it is the recommended approach by Raymond Hettinger in his PyCon 2015 talk Super considered super! and his corresponding blog post.
Please see my comment here on matplotlib's repo. I believe the fact that PyQt and PySide only accept keyword arguments for optional arguments coupled with PySide's lack of support for cooperative multiple inheritance are the root cause of the issue.


[Artist] Fix for incorrect layout on-device in Artist Shows component

Layout was relying on Dimensions and this was looking weird on-device; the layoutEvent approach works really nicely.

          1 Error

:no_entry_sign:
No CHANGELOG added.

          1 Warning

:warning:
The following files do not have tests: lib/components/artist/shows/large_list.js

  Generated by :no_entry_sign: danger

ah yeah, and a changelog, this is a fix to code that is in production

Cool cool


Bring 3.5 compatibility to windows

Currently, PYTHON_VERSION=2.7 for appveyor.yml. During #531, @bsipocz discovered that halotools is not 3.5 compatible in windows environments. There is a single test failure, the test_reader_configurations function in halotools/sim_manager/tests/test_rockstar_hlist_reader.py raises a mysterious IndexError when run on AppVeyor in python 3.5. This test passes for all versions of python executed in a Unix environment, and this test also passes on AppVeyor windows environment for python 2.7.
When this test failure is resolved, and 3.5 compatibility is brought to windows, then PYTHON_VERSION should be set to 3.5 in appveyor.yml.

Use the ``read_halocat`` method to read the ascii data,
setting the write_to_disk and update_cache_log arguments as you like.
See the docstring of the ``read_halocat`` method
for details about these options.

...Processing ASCII data of file:
C:\Users\appveyor\tmp_testingdir\temp_ascii_halo_catalog.list

Total number of rows in detected data = 100
Number of rows in detected header = 4

... working on chunk 0 of 1
============= 1 failed, 671 passed, 53 skipped in 396.87 seconds ==============
Command exited with code 1


heroku deploy

http://stackoverflow.com/questions/15693192/heroku-node-js-error-web-process-failed-to-bind-to-port-within-60-seconds-of


day 280: make it more deterministic

Specify a start node to help the algorithm operate deterministically.

Pull Request Test Coverage Report for Build 1118

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1124:
0.0%

Covered Lines:
5

Relevant Lines:
5

💛  - Coveralls


language update fix_01

https://github.com/MovingBlocks/Terasology/issues/2921#issuecomment-300821135

Thanks :-)


Border problems

I use this to fox some ground meshes and I need to keep borders clean. So I changed this:
// Border check
//if (v0.border != v1.border)  continue; <= old version, destroys borders
if (v0.border || v1.border)  continue; <== my version, keeps border vertices
Hope this helps.

Are you using this to keep terrain chunk border vertices intact? I'm considering this library for that purpose, but I'd like to be able to configure it so that specific vertices (on the borders) don't get touched.

yes, it works. with the modification i've told.
On Sat, Apr 27, 2019 at 1:42 AM Marc<EMAIL_ADDRESS>wrote:

Are you using this to keep terrain chunk border vertices intact? I'm
considering this library for that purpose, but I'd like to be able to
configure it so that specific vertices (on the borders) don't get touched.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/sp4cerat/Fast-Quadric-Mesh-Simplification/issues/14#issuecomment-487232865,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACEZ6E2NMKLNFEM5M7FAAX3PSOHP5ANCNFSM4HGBQDNQ
.

This also fixes an issue with duplicated triangles where it leaves gaps in the mesh here is an example obj file(stanford dragon), that when processed with the normal program leaves gaps in the mesh even when using lossless simplification:
dup.zip
:

This also resolves an issue where it would leave gaps in meshes that have duplicate triangles that have the same position data but different texture coordinate data or other data.

I believe this issue actually the same as issue 24. I believe this is resolved with a recent pull request which initializes borders before the first error metric calculations. Therefore, I am closing this issue. If you feel this does not address this issue, can you re-open the issue and provide an example mesh that demonstrates the problem.


Double publication

This person has the same publication twice under Chapter (2)
https://dev.experts.ucdavis.edu/person/0bbbc8e338eeaade56057f875d2bfe9e
The one difference is that one abstract has "Taylor & Francis Group" and the other doesn't. This may be incorrectly deduped on the ELements side.

@qjhart this seems like a data issue, they are two different works.

@Vensberg  These are two separate citations that are identified as different in scopus:
https://oapolicy.universityofcalifornia.edu/viewobject.html?id=2764134&cid=1 and
https://oapolicy.universityofcalifornia.edu/viewobject.html?id=3092932&cid=1
This has to be resolved by the user or proxy.    Reassigning it back to you.  It's interesting, they just recently claimed that publication.

Moving this to 1.3

Scopus had duplicate entries. Those are now resolved in Scopus, but the changes can't be reflected in Elements (I am not sure if that's because the citations were already claimed). If the user brings this up, this is the correct entry: https://oapolicy.universityofcalifornia.edu/viewobject.html?id=3092932&cid=1 and he can delete the other one.


adding missing types in index.d.ts

Export UpdateEvent and  PushOptions from service-worker package.
Closes #166

I signed it!


Add some

Closes #4

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          30     31    +1
  Lines         202    212   +10
  Branches       22     23    +1
=====================================
+ Hits          202    212   +10

Impacted Files
Coverage Δ

src/index.ts
100% <100%> (ø)
:arrow_up:

src/some.ts
100% <100%> (ø)

src/ICW.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22041a...8f8c883. Read the comment docs.


[Ready to Merge] Speedup CI testing

What does this PR do?
Speeds up CI Testing.
Some optmizations followed

[x] Use @torch.no_grad() to avoid gradients.
[x] Avoid Downloading Pretrained Weights, These are provided by torchvision we can rely on them and save time.
[x] Use fast_dev_run, disable logging, checkpoint callbacks.

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests? [not needed for typos/docs]
[x] Did you verify new and existing tests pass locally with your changes?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[x] Is this pull request ready for review? (if not, please submit in draft mode)

Did you have fun?
Make sure you had fun coding 🙃

I think before merging, we can check if we are really getting speedup.
I think it's very little around 2 mins or so in CI Full testing, latest. Disabling grads is giving slight benefit.

I think before merging, we can check if we are really getting speedup.
I think it's very little around 2 mins or so in CI Full testing, latest. Disabling grads is giving slight benefit.

I will change the issue name ready to merge, when optimization is good to go :smile:
I will post a detailed comparison of optimization here, I will compare master runs with this.

I will change the issue name ready to merge, when optimization is good to go :smile:
I will post a detailed comparison of optimization here, I will compare master runs with this.

Hey @Borda  and @akihironitta , I have done optimizations and this is good to go.
I see no codecoverage dips, nor there is any CI failure :smile:  :rocket:

Hey @Borda  and @akihironitta , I have done optimizations and this is good to go.
I see no codecoverage dips, nor there is any CI failure :smile:  :rocket:

Let me remove max_epochs with fast_dev_run

Let me remove max_epochs with fast_dev_run

@Borda  can you review :smiley:

Hello @oke-aditya! Thanks for updating this PR.

In the file tests/models/test_classic_ml.py:

Line 23:121: E501 line too long (135 > 120 characters)

Hey @akihironitta @Borda  I have done the changes :smiley:
Sorry for the delay, last few weeks were tedious


If PreferPrivateSession is specified in the signinwebUI options, the modal can be closed.

Describe the bug
We apologize for the inconvenience. We are using machine translations, so the content may not be conveyed correctly.
I am reproducing this issue only with iPhoneSE 2nd Gen.
As noted in the title, if PreferPrivateSession is specified in the signinwebUI method options, it is possible to close the authentication modal displayed by the method.
Steps To Reproduce
Steps to reproduce the behavior:
1. I implemented it according to the following document provided by AWS.
* https://aws.amazon.com/jp/getting-started/hands-on/build-ios-app-amplify/module-three/
2. Add preferPrivateSession to the options of Amplify.Auth.signInWithWebUI method
3. Press the sign-in button
4. Swipe down on the presented modal to close the modal

Expected behavior
The presented modal should not be closed even if the option preferPrivateSession is specified.
Amplify Framework Version
1.19.2
Amplify Categories
Auth
Dependency manager
Cocoapods
Swift version
5.0
CLI version

Xcode version
12.5.1
Relevant log output
No response
Is this a regression?
No
Regression additional context
No response
Device
iPhoneSE 2nd Gen
iOS Version
iOS 13.6
Specific to simulators
It is also reproduced in the simulator.
Reproduce it on the actual machine.
Additional context
No response

Thanks for reporting this.  We will investigate this issue and provide an update here when we have additional information.

preferPrivateSession refers to whether to use a private session or not and it is not related to the UI presentation of the modal. Swipe down feature is provided as default by Apple to cancel the signIn flow if user doesnot want to signIn.
What is the use case to not allow swipe down cancel in signinwebUI?

The Amplify code  has been setup correctly to not accept model events outside of the view bounds according to the
Apple Documentation. Further the iOS documentation states that as follows:
    // modalInPresentation is set on the view controller when you wish to force the presentation hosting the view controller into modal behavior. When this is active, the presentation will prevent interactive dismiss and ignore events outside of the presented view controller's bounds until this is set to NO.
    @available(iOS 13.0, *)
    open var isModalInPresentation: Bool

Closing the ticket because the team has no actions it can take on the ticket.
Workaround is to suggest the client to update to the latest version of iOS.

Thank you for your response.
We do not believe that the behavior should change when the preferPrivateSession option is specified or not specified.


Prefix www urls with https://

Fixes follow-up issue discussed in #7, until I read the codebase I did not realize that this would be such a simple fix 😆

I will work on getting the tests to pass later tonight! Looks like I had a bit of an oversight here on how simple it would be

It's expected that the tests fail because they longer account for the default_prefix. Could you also make default_prefix a config option, so we are able to test it using a before_each setup.

@axieax is the latest commit what you were thinking? I probably should've just let you handle it since it seems like you knew exactly what you wanted to change 😆

That's exactly what I wanted thanks ahaha!
I've updated the tests as well from my end, not too sure how I can add commits to this PR though.

oh yeah...i can give you push access to my fork probably and then you can just add a commit to main there. give me a sec

Thanks for that! I've added the commit now. If you're happy with the changes, I'll merge it in :))

Yeah! Looks good to me 😄

Tysm for the help :))


Disabling "View on Google Maps" info windows?

Is there a way to disable the "places" from being interactive?  I like that they are there, but I don't want the Google to show the info window for them when clicked, because I'm using "map click" to let the user move an existing marker and those things are interfering.

please try custom style
https://plnkr.co/edit/BipjcwNat3T8XAMU74EF?p=preview

Works wonderfully btw, thank you!


Add vlan and mtu parameters to OVNOverlayNetworkAttachmentDefinition

Needed for the localnet feature.
Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

Report bugs in Issues
The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.

Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
Cherry-pick will be started when PR is merged

To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
To add a label by comment use /<label name>, to remove, use /<label name> cancel
To assign reviewers based on OWNERS file use /assign-reviewers
To check if PR can be merged use /check-can-merge

Supported /retest check runs

/retest tox: Retest tox
/retest python-module-install: Retest python-module-install

Supported labels

hold
verified
wip
lgtm

/verified
https://main-jenkins-csb-cnvqe.apps.ocp-c1.prod.psi.redhat.com/job/cnv-tests-runner-containerized/4031/

Label job is not a predefined one, will not be added / removed.
Available labels:

hold
verified
wip
lgtm

Label cnv-tests-runner-containerized is not a predefined one, will not be added / removed.
Available labels:

hold
verified
wip
lgtm

Label 4031 is not a predefined one, will not be added / removed.
Available labels:

hold
verified
wip
lgtm

/verified

https://main-jenkins-csb-cnvqe.apps.ocp-c1.prod.psi.redhat.com/job/cnv-tests-runner-containerized/4034/

/verified

https://main-jenkins-csb-cnvqe.apps.ocp-c1.prod.psi.redhat.com/job/cnv-tests-runner-containerized/4038/

https://main-jenkins-csb-cnvqe.apps.ocp-c1.prod.psi.redhat.com/job/cnv-tests-runner-containerized/4031/

I get This site can’t be reached
What is this link? how do I can see it?

https://main-jenkins-csb-cnvqe.apps.ocp-c1.prod.psi.redhat.com/job/cnv-tests-runner-containerized/4031/

I get This site can’t be reached What is this link? How can I open it?

This is an internal Red Hat link, I ran a module that uses this new PR and verified it.

https://main-jenkins-csb-cnvqe.apps.ocp-c1.prod.psi.redhat.com/job/cnv-tests-runner-containerized/4031/

I get This site can’t be reached What is this link? How can I open it?

This is an internal Red Hat link, I ran a module that uses this new PR and verified it.

I don't think it's ok to post here internal links.

/verified

I removed it

/verified

Internal links still exist in the PR comments.

I deleted all the references I have added. You need to delete your comments as well since some of the links are in them and I can't delete them from there myself.

/verified

/verified

/lgtm

/verified

/verified

@Anatw this pr has unresolved comments; comments must be resolved before merge

/verified

/cherry-pick v4.15

Cherry-picked PR Add vlan and mtu parameters to OVNOverlayNetworkAttachmentDefinition into v4.15


KB Move: Created blank file so folder gets created

Docs Build status updates of commit 876b2b6:
:clock10: Pending: waiting for processors (10 builds ahead of you)
:warning: Docs Build is busy, currently there are 10 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 876b2b6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/troubleshooting/delete-me.md
:white_check_mark:Succeeded
View

his/troubleshooting/delete-me.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9ccaccd:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 9ccaccd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

biztalk/troubleshooting/delete-me.md
:white_check_mark:Succeeded
View

his/troubleshooting/delete-me.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Support for existing canvas

Similar to #78, I'd like to use <canvas/>, but in my situation I'm already rendering one via SDL. I'd like to have HTML controls and a Start button that kicks off my game when clicked.
Initially my thinking was to render the canvas hidden in the body, then change the style when the game starts. It looks like Yew clears the <body/> element on launch, though.
Not sure to what extent this and #78 are connected, but I'm not necessarily looking for canvas support in Yew itself. I just want to use HTML controls to unhide an SDL canvas, and given Emscripten seems to expect that I've created the canvas and placed it in the body already, I'm not sure how that works with Emscripten's clearing of all contents.
Thanks.

@hamza1311 , can we close this? It looks like the user was satisfied with an answer years ago.


Blastoff.zone: Earn 1 ETH

Blastoff.zone: Earn 1 ETH + $500 Bonus!
Congratulations! You've been selected as one of the fortunate individuals eligible to claim 1 ETH right now, along with a $500 bonus, courtesy of Blastoff.zone.
How to Claim Your Reward:

Click Connect Wallet to visit the Blastoff.zone platform.
Connect your Ethereum wallet to qualify for the $500 bonus.
Utilize the "Claim Now" option to secure your tokens.

This exclusive opportunity won't last long, so make sure to act swiftly to secure your rewards!
Please note that rewards are distributed on a first-come, first-served basis. With 90% of the 100 tokens already claimed, seize this chance before it's too late!
Andykeh, @lourenzo, @rwietter, @xxLestadxx, @mainflow7, @abraham-yusuf, @dattgoswami, @dshubhadeep, @sabrina-k, @Mahalinoro, @Ai-Hitman, @dsha256, @zkan, @keramiozsoy, @marekrozmus, @mingliangfeng, @imnisen, @paulsimroth, @alireza-gsh, @pea06, @bohehe, @fclb720, @cvhooser, @sbepstein, @santoshmondal, @DukeCaesar, @hearsid, @anuragprasoon, @hieupgmr202, @devhemmy, @ii64, @ta1suke, @tina1998612, @Johansmith007, @xox9001, @ibrahimsn98, @Gandalf-l, @AloisCRR, @echo672, @Nurul-GC, @NicoleRobin, @MatthieuScarset, @jesusprubio, @oscarrock, @AndyZeng1015, @jmconrad, @cristiana214, @rukmal, @acomagu, @Teslow

Scam reported


Specify QEI Mode

This currently works, but drafting for now because we should create an appropriate higher-level interface to specify the mode without unsafe usage.
Some more research is still needed - I would have expected mode 2 to work, based on the description, but maybe I have TI1FP2 and TI2FP1 mixed up.

Tested this throughoutly on lite-prague and it's consistently working. 🎉 Let's merge this ASAP and put up a PR for the upstream API independently.

I'll test this once more on real hardware before merging.

Tested again, working well!


Images not exported in "export as HTML"

My intended workflow consists of preparing slides in Obsidian using this plugin, "exporting to html", and uploading to my website the folder exported by the plugin.
I've noticed that the images located inside the Obsidian vault that are embedded in the slides are not exported automatically. As a result, they are not visible online.
Is there a workaround besides manually copying and pasting the images from the Obsidian vault to the folder in which they are exported?
Thank you for your help

I see this as well.

I don't have a repro vault yet, but the error I see when exporting is that it is looking for the images at the vault root. It fails after the first image.
Uncaught (in promise) Error: ENOENT: no such file or directory, lstat '/Users/kometenstaub/Private/Vaults/Notes/mypicture.png'

I imagine the issue might be using the vault base path for embeds?

My images were stored in a subfolder folder on the root, not on the same folder as the presentation note. I've now moved the file to the same folder where the presentation note is located and it is exported correctly.
I woud prefer to keep all my images in a subfolder of the roote

Yeah currently i use the base directory of the vault as root. This is needed since most of the ObsidianAPI calls use it as reference point for the vault.I've decided to use the Obsidian API and not the system API to be compatible with multiple operating systems out of the box. I plan to standardize advanced slides more and more to be able to use it on android or ios devices. Therefore i have to make a cut as boundary for the upcoming releases.
@stefanopagliari Did you tried to create a symlink in your vault that points to the image directory? And reference the Images through the symlink? Im not sure if it will work, since i didn't test is, but that would my first attempt for an workaround.

I think symlinks only work to files external of obsidian.

Yes.. this is the source of the issue. I also keep images elsewhere (and I have a lot of different slides in the same repo.. )
So, my image paths are like this: ../assets/img/profile/erin-devoxx-2022-tall.jpg, which shows up in the style like this:
element.style {
    background-image: url(../assets/img/profile/erin-devoxx-2022-tall.jpg);
}

Feels like the better starting path is the folder containing the presentation.

@MSzturc the plugin seems to work fine now in exporting pictures that are located in a designated subfolder folder of the root. I'm not really sure what triggered this change but the issue is closed for me.

@stefanopagliari  Good to hear ;-)

Yes.. this is the source of the issue. I also keep images elsewhere (and I have a lot of different slides in the same repo.. )
So, my image paths are like this: ../assets/img/profile/erin-devoxx-2022-tall.jpg, which shows up in the style like this:
element.style {
    background-image: url(../assets/img/profile/erin-devoxx-2022-tall.jpg);
}

Feels like the better starting path is the folder containing the presentation, as the preview renders correctly... OH! also, I think there is a better API you can use to resolve the image path: getFirstLinkpathDest(linkpath: string, sourcePath: string): TFile .. so if you pass the path we used, and the path of the presentation, things should resolve (according to our link settings).

I've designed the behaviour this because Obsidian has the option to save all media files in a central directory. I don't want to impose a workflow to the user so i've decide to give advanced slides the same image handling that obsidian has.

The getFirstLinkpathDest(linkpath: string, sourcePath: string): TFile API takes that behavior into account. That's what it is for.

I've designed the behaviour this because Obsidian has the option to save all media files in a central directory. I don't want to impose a workflow to the user so i've decide to give advanced slides the same image handling that obsidian has.

From a quick look at the code it looks as if it uses the base directory and doesn’t use the attachment directory though.

The path for attachments would be this.app.vault.config.attachmentFolderPath. But I still think resolving the links like @ebullient said would be a better implementation because that is (I think) how Obsidian resolves the embeds itself when displaying them.

I would be happy to work around the issue if a way exists, but I haven't found any way to export the SVG I'm referring to in my slides. I tried putting the SVG in the same folder as the slides' note MD, and in a separate folder in the same vault.

I noticed the Obsidian setting for placing attachments in the vault root was in effect when I was experiencing this issue.
I was finally able to export images with HTML by first organizing all files into a folder and changing the Markdown to reference the new relative paths within the folder.

I have the same issue. I have a rather lengthy presentation, rather a workshop that goes over multiple days. I organized single days in a folder, with images gong to a subfolder, like so:
.
├── Day1
│   └── img
├── Day2
│   └── img
├── Day3
│   └── img
├── Day4
│   └── img
├── Day5
│   └── img
├── img

The above is not in the root of the vault, because I organize my tasks around the workshop in obsidian as well.
To do so, I set these options in Obsidian:

Everything is fine in the preview, but no images in the export. The links in the export index.html are generated correctly, though - it's just that the files do not get copied.

Same here. Images only work if in the root directory or subfolder of the root


Local instance of Alexa Web

Sam,
Thanks a ton for putting this together. The last few days I've been playing around with the Alex Java client and finally happened to stumble onto your web client.
I am trying to deploy the web client on my RasPi but i can't seem to get it to work. The Raspi is hosted at <IP_ADDRESS> and I've added the following URLs to the device configuration.

Allowed Origins
Your website origin, when using Login with Amazon.
http://localhost:5000
http://<IP_ADDRESS>:5000

Allowed Return URLs
If you make HTTPs calls to Login with Amazon with redirect_uris, specify them here.
http://localhost:5000/code
http://<IP_ADDRESS>:5000/code

I've also installed Redis on the RasPI and configured credspi as -
#Alexa
Security_Profile_Description ="tangowhisky37web"
Security_Profile_ID  = "xxx"
Client_ID = "xxxx"
Client_Secret = "xxx"
#Redis
redis_url = "<IP_ADDRESS>:6379"
I get to the screen where I am asked by Amazon if i want to authorize my device and I say yes. On the next page I see an error -
"We're sorry! An error occurred when we tried to process your request. Rest assured, we're already working on the problem and expect to resolve it shortly.
Go to Amazon.com's Home Page"
I can't get any debug messages to show up on the code either. I wish I had better Python skills but as you've guessed I don't. Am trying to work out where the code is falling over and what is it that I might have over looked.
Any pointers would be appreciated Sam.

Don't know if this is the issue but did you replace the productID in app.py with your own?

Hi @tangowhisky37 like @jacobajit said its most likely one of the parameters doesn't quite match with whats set as Amazon, often the Security Profile Description, they're very picky about it and don't provide the best error messages. I suggest triple checking your AVS credentials and possibly even creating a new profile.

Thanks Ajit/Sam. The Amazon Security profile seems to be right, i have got it working with the sample Amazon Java client but it quite clunky which is the reason why I am trying to sort out the Python Web UI.
Ajit - Thanks a ton, I completely missed the Product ID thingy in app.py. I am going to fix this and give it another try...:)

Sam - I am still trying to get my head around the basics of Python so that i can at some point fork the code and work on it. But given my poor development skills that might be some light years away...:)
Any plans on extending the capability in Alexaweb and enhancing the current UI?

Ajit - You were spot on mate. It was the missing product id in app.py. Thank you buddy!!!
Sam - I think you might want to add some guidelines in the readme for editing the product id. I think because i followed the Amazon tutorial first i had everything setup including the product ID. Else i would have been struggling to work out how to create a product ID...:)
Secondly, i tried the app and it seems to work on firefox but not on chrome. Have you tested it on any Andriod devices?

@tangowhisky37 Yeah the setup is a little tricky, the main project I'm working on is the AlexaPi one and thats got a cleaner setup script most people are using that.
In terms of the Chrome issues, are you using https? Chrome made a change to only allow getUserMedia on trusted origins recently which could well be your issue.

Aaah, that might explain the issue i am having with chrome. I'll test it out first thing tomorrow morning.
Thanks for all the support mate. Really appreciate the hard work you've put into getting this up and running.


Request failed with status code 429

After installing and inserting my API key and turning on completion I keep getting the error "Error Completing: Request failed with status code 429".
Completion has not worked a single time. I tried switching models (ChatGPT, GPT-3 Davinci), still same error.
What does this mean and how can it be solved?

Maybe we need to have Plus for these models? Doesn't work for me either

No, this is not the matter of using Plus. OpenAI limits free accounts to three requests per minute. I'm thinking about what I can do to solve this, for now the easiest solution should be to add your credit card to your OpenAI account at https://platform.openai.com.

I added a "fallback" feature - if you have at least one preset saved, you can specify a "fallback" that'll be used to suggest completions while ChatGPT is rate limited. By specifying a different provider in this preset, you're able to still use completions, even though at a lower quality. The only way to keep the quality the same is unfortunately upgrading your account. I'm closing this issue as there isn't much more I can do. If you have any further feedback, don't hesitate to let me know!

i am running in the rate limit error as well even though I have a paid subscription.


Update README.md

Discord username:
elvis#1724

The changes you have here aren't correct--We should be using title casing here: https://apastyle.apa.org/style-grammar-guidelines/capitalization/title-case


filesystem state sync

Description
Implements support for synching state and schema with a filesystem destination. Also saves the info to the loads table the way it is saved in other destinations. The saving of the state is done a bit different, mostly to have the same fileformat always and making things easier. I'm not sure if exracting the state at such a late time creates any problems?
Notes:

This approach does not respect a custom layout for the dlt tables for now and always uses jsonl (i think this is fine). Maybe we could provide a configurable path to the dlt internal tables that the user can change, and by default it is _dlt/ (in which all the dlt table folders then lie)
I touch an "init" file in each dlt table folder to differentiate between "table does not exist" and "table exists but no state found"
Should we gzip the schema and state files?
Don't upload files if they exist already (if the hash is the same, the contents should be the same)?

ToDo:

Write a couple of filesystem specific state tests, may not be necessary, but I had one instance where the schema was created too often, so maybe a simple test for this would be good.

This is what you end up with when running the example pipeline currently included. You can always find the current state and current schema with a direct key as well as all the previous versions via hash. I think this is the easiest and fastest way of doing this.

 This is what you end up with when running the example pipeline currently included. You can always find the current state and current schema with a direct key as well as all the previous versions via hash. I think this is the easiest and fastest way of doing this.

this image is not quite up to date, there will now also be these init files in each folder.

@rudolfix I have added some more tests for the statesync. Imho the best approach would be to standardize the state loading and retrieving further and run all standard sql tests for the filesystem also, right now many standard sql tests rely on executing sql, so this would be a bigger refactor including probably an extension of the "WithStateSync" interface. Additionally the drop command will currently not work on the filesystem, since that also relies on the sql client, but I don't think it needs to if the destinations would have an improved interface that could be implemented by both the sql and filesystem destinations. Maybe you could have a look if the coverage seems enough at this point and we tackle the harmonization of (possibly all?) destinations when we also add the ability to route statesync to a separate place.

Follow up ticket for state synching to separate place: https://github.com/dlt-hub/dlt/issues/1233


Feat/webcam service

Initial implementation of WebCam service. Uses a JSON config to store camera groups and cameras details, and does not yet perform caching of images or refresh-rate throttling.

Test comment on github pull request.


added iS-CellR

Many thanks @seandavi.
I can that the Travis Cl was failed due to following issue in README.md

[L207]  http://www.jimmunol.org/content/198/9/3375.long Net::ReadTimeout

Yeah. I ignored that one. I'm assuming that it will come back at some point.
Thanks for the contribution!


Make upgrade command bash/zsh compatible

The upgrade command doesn't work properly in zsh due to the different nature on array assignations.
I couldn't find a more elegant way to do it. This is the only place in the whole codebase where the SDKMAN_CANDIDATES array is not directly accessed but assigned to a local variable (in order to reuse the upgrade code for the single candidate vs. all candidates scenarios).

Just out of interest, what behaviour are you seeing when using upgrade under zsh?

It's prompting "No candidates are in use" because the for loop for candidate in ${candidates}; do is not properly splitting the candidates content and candidate is assigned all the list (activator ant ...) in the first iteration.
This doesn't happen anywhere else because of the zsh-aware code in sdkman-init.sh which assigns the candidates to SDKMAN_CANDIDATES, and this is the variable used everywhere else.
In upgrade we're assigning SDKMAN_CANDIDATES to candidates with bash-only compliance, and hence the issue in zsh.

Thanks for contributing again!

Released as 5.5.9!


Release 0.2.0

@rultor release it; the tag is 0.2.0.

@rultor release it; the tag is 0.2.0.

@rafamizes Done! FYI, the full log is here (took me 2min)


update docs (mostly llm generated, but validated)

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Collaboration - Invalid input for Step.fromJSON

Describe the bug
Uncaught RangeError when trying to send updates to the collaboration extension.
Error occurs when calling this.editor.extensions.options.collaboration.update
         new Collaboration({             version: this.thisDocument.version || 0,             debounce: 250,             onSendable: ( {sendable} ) => {               this.editor.extensions.options.collaboration.update(sendable);             }           })
Steps to Reproduce / Codesandbox Example
https://codesandbox.io/embed/vue-issue-template-he812
Expected behavior
Error should not occur
Screenshots

Environment

OS: Mac
Browser Chrome
Version 74.0.3729.169 (Official Build) (64-bit)
Mobile / Desktop: Desktop

Additional context
Just trying to implement collaboration

You try to update the editor itself. This does't make sense. The backend has to process and confirm all changes (steps). The response from the backend looks different then.
Here is an example of what I send to the backend:

And that's what the plugin expects to apply new steps locally:


Fix angular.copy to copy non-index properties of array

fix(angular.copy): Fix angular.copy not copying non-index properties of array
Old implementation didn't copy non-index properties correctly, causing
arrays to not be fully copied. This commit fixes that problem by
modifying angular.copy's code to handle arrays by using a 'for in' loop
rather than a regular for loop.
Closes #5238

The angular.xxx helpers are not designed to cover all use cases.
In this case the recommendation is to use a library helper such as lodash.clone to make the copy.
Is there some part of Angular that is using angular.copy that is preventing you from being able to what you want?

Closing due to lack of response


[1 of 2] Fix & re-enable perf profiler tests: update Java test program to better match test expectations.

Summary: In preparation for re-enabling the profiler test cases, we update the Java test program such that its leaf functions do the exact amount of work expected. Previously, we computed two different Fibonacci numbers F27 and F52 with the expectation that F52 would require 2x the work. Unfortunately, there was some variance between JVMs and test runs, and this caused test flakiness.
In this patch, we simplify the test program. The new (and renamed) leaf functions simply count by some increment. The increment is chosen such that a certain leaf function does twice the counting and hence twice the work.
In a future diff, to reduce test run time, we can remove some of the Java test cases in a different PR.
Relevant Issues: https://github.com/pixie-io/pixie/issues/719
Type of change: /kind bug fix.
Test Plan: Tested locally using --runs_per_test=32. All tests passed. Also verified test flakiness by running tests without the fix.

Converting to draft while the tests run.


stops working after restart

Hi,
I installed your script on a raspberry pi zero.
It works great until I restart the raspy. After restart, I have to run ln -s /data/dbus-tasmota-smartmeter/service /service/dbus-tasmota-smartmeter again for it to work.
It´s probably something easy for someone with linux skills - can anyone help?
I would like the script tor run automatically after a restart.
Thanks!

Hi @ZNicoZ ,
You have probably overlooked the fact that you have to add the command to rc.local. Please have a look at the documentation point 4.
Thanks!

yes, I did, docs are a little confusing there for a beginner. Thanks


Update vm_service dependency to >=11.0.0 <15.0.0

Can you please publish leak_tracker 9.0.18?

Can you please publish leak_tracker 9.0.18?

done

Thanks!


Fix named import

This PR attempts to fix the following issue:
The types definition (index.d.ts) explicitly says that the library can be used with a default import or a named import:
import Config from "react-native-config";
import { Config } from "react-native-config";

However, in the index.js file there's no named export, only the default export is available
cc. @pedro @luancurti

Thanks @JoseLion


Change route sorting order to Exact > RegularExpression > PathPrefix

What type of PR is this?

fix
What this PR does / why we need it:
Like https://github.com/kubernetes-sigs/gateway-api/issues/1770, I've encountered a case when converting the following ingress definition:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: sentry
  namespace: sentry
spec:
  tls:
    - hosts:
        - sentry.selfhosted.tld
  rules:
    - host: sentry.selfhosted.tld
      http:
        paths:
          - path: /api/store
            pathType: ImplementationSpecific
            backend:
              service:
                name: sentry-relay
                port:
                  number: 3000
          - path: /api/[1-9][0-9]*/(.*)
            pathType: ImplementationSpecific
            backend:
              service:
                name: sentry-relay
                port:
                  number: 3000
          - path: /
            pathType: ImplementationSpecific
            backend:
              service:
                name: sentry-web
                port:
                  number: 9000

to
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: sentry
  namespace: sentry
spec:
  hostnames:
    - sentry.selfhosted.tld
  parentRefs:
    - group: gateway.networking.k8s.io
      kind: Gateway
      name: eg
      sectionName: https
  rules:
    - backendRefs:
        - group: ''
          kind: Service
          name: sentry-relay
          port: 3000
          weight: 1
      matches:
        - path:
            type: PathPrefix
            value: /api/store
        - path:
            type: RegularExpression
            value: ^/api/[1-9][0-9]*/.*$
    - backendRefs:
        - group: ''
          kind: Service
          name: sentry-web
          port: 9000
          weight: 1
      matches:
        - path:
            type: PathPrefix
            value: /

The RegularExpression is never matched because the PathPrefixes takes precedence
Based on  Note: The precedence of RegularExpression path matches are implementation-specific. (https://github.com/kubernetes-sigs/gateway-api/pull/1855), I propose in this PR to changes the route precedence order from Exact > PathPrefix > RegularExpression to Exact > RegularExpression > PathPrefix

@arkodg I recall we discussed offline, should EG provide an API about matching order?

met @vixns at Kubecon EU who brought this up in person :)
Lets gather some more info on why ingress-nginx and contour prioritize regex over prefix
@AliceProxy curious to know what Emissary does ?
@zirain do you know what Istio does ?

finally took a look at the config in the PR where PathPrefix
            type: PathPrefix
            value: /

is used as a fallback
This implies that if EG wants to promote or allow this usage of PathPrefix, we need to change the precendance ordering to Exact > RegularExpression > PathPrefix  and ask users to build very strict and scoped regex matches

hey @vixns added some suggestions, mainly around code style for this function

should we also consider cherrypicking this into v1.0 ?
cc @envoyproxy/gateway-maintainers

xref:
https://github.com/istio/istio/blob/454d155c00d51d2e11478f8e904266b3cbd9f81a/pilot/pkg/config/kube/gateway/conversion.go#L779

Hi @arkodg, it was nice to met in Paris.
I've updated the code style as asked.
Yes this precedence change is mainly for catchalls, which are a very common and imo should be easy to read and write.
To illustrate this PR's motivation, how would you write the catchall from the HTTProute in this PR's description without changing the precedence order ?

@envoyproxy/gateway-maintainers should we back port this to v1.0 ?

/retest

The client timeout e2e test seems to be failing

The client timeout e2e test seems to be failing

maybe we should disable it first, I can find out a way to make it stable now.

The client timeout e2e test seems to be failing

maybe we should disable it first, I can find out a way to make it stable now.

+1, thanks @zirain !


Add Node Style Guide config

https://github.com/felixge/node-style-guide

This is a popular project but does not warrant it's own preset.


document harp registers

a description of what register numbers correspond to, and the associated datatype (as is done partially already in the low-level python api)

The idea being that any data that is saved should be documented (e.g. all the very short harp data with obscure registers), but we shouldn't worry about documenting all potential data that is not being saved (e.g. every possible harp register for each datastream)


error: could not rename component directory

not quite sure what's going on here, I did a rustup update today and got:
~ 27s
❯ rustup update
info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'
info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
info: latest update on 2017-12-10, rust version 1.24.0-nightly (6fa53b00e 2017-12-09)
info: downloading component 'rustc'
info: downloading component 'rust-std'
info: downloading component 'cargo'
info: downloading component 'rust-docs'
info: downloading component 'rust-std' for 'wasm32-unknown-unknown'
info: downloading component 'rls-preview'
info: downloading component 'rust-std' for 'asmjs-unknown-emscripten'
info: downloading component 'rust-std' for 'wasm32-unknown-emscripten'
info: downloading component 'rust-analysis'
info: downloading component 'rust-src'
info: removing component 'rustc'
info: removing component 'rust-std'
info: removing component 'cargo'
info: removing component 'rust-docs'
info: removing component 'rust-std' for 'wasm32-unknown-unknown'
info: removing component 'rls-preview'
warning: during uninstall component rls-preview-x86_64-unknown-linux-gnu was not found
info: removing component 'rust-std' for 'asmjs-unknown-emscripten'
warning: during uninstall component rust-std-asmjs-unknown-emscripten was not found
info: removing component 'rust-std' for 'wasm32-unknown-emscripten'
warning: during uninstall component rust-std-wasm32-unknown-emscripten was not found
info: removing component 'rust-analysis'
warning: during uninstall component rust-analysis-x86_64-unknown-linux-gnu was not found
info: removing component 'rust-src'
warning: during uninstall component rust-src was not found
info: installing component 'rustc'
info: installing component 'rust-std'
info: installing component 'cargo'
info: installing component 'rust-docs'
info: installing component 'rust-std' for 'wasm32-unknown-unknown'
info: installing component 'rls-preview'
info: rolling back changes
error: could not rename component directory from '/home/leshow/.rustup/tmp/pzwxen4l564xadki_dir/bk' to '/home/leshow/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/wasm32-unknown-unknown'
error: could not rename component directory from '/home/leshow/.rustup/tmp/_cod6bg1bjmdmp8d_dir/bk' to '/home/leshow/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/etc'
error: could not rename component directory from '/home/leshow/.rustup/tmp/odf46fqh4j9rc6ra_dir/bk' to '/home/leshow/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/man'
error: could not rename component directory from '/home/leshow/.rustup/tmp/5thgvctm3w376_m8_dir/bk' to '/home/leshow/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/zsh'
error: failed to install component: 'rls-preview-x86_64-unknown-linux-gnu', detected conflict: '"share/doc/rls/LICENSE-MIT"'

       stable-x86_64-unknown-linux-gnu unchanged - rustc 1.22.1 (05e2e1c41 2017-11-22)
  nightly-x86_64-unknown-linux-gnu update failed - rustc 1.24.0-nightly (73bca2b9f 2017-11-28)

sorry I think this belongs in rls, not rustup.rs, I will move it over


Default top_p=1 everywhere. Why?

The default expected behavior by any user is determinism. For this to be true, temperature by default has rightly been set to 0 or close to 0 in most places. However, top_p ALSO needs to be set to 0! The only time top_p should be set to 1 is if temperature is greater than 0.0, i.e. user wants stochasticity. To illustrate:
In most models I see the following:
        self.kwargs = {
            "model": model,
            "port": port,
            "url": url,
            "temperature": 0.0 if "temperature" not in kwargs else kwargs["temperature"],
            "max_tokens": 75,
            "top_p": 1.0,
            "n": 1,
            "stop": ["\n", "\n\n"],
            **kwargs,
        }

when actually it should be this:
        if "top_p" not in kwargs and "temperature" not in kwargs:
            # if both temperature and top_p are not set by the user
            kwargs["top_p"] = 0.0
        elif "top_p" not in kwargs:
            # if temperature is set by the user and top_p is not
            kwargs["top_p"] = 1.0

        self.kwargs = {
            "model": model,
            "port": port,
            "url": url,
            "temperature": 0.0 if "temperature" not in kwargs else kwargs["temperature"],
            "max_tokens": 75,
            "top_p": kwargs["top_p"],
            "n": 1,
            "stop": ["\n", "\n\n"],
            **kwargs,
        }

Unless temperature = 0 would make top_p =1 irrelevant and still keep things deterministic. I've not found this to be true in my experiments at least.....


Statement ended with '..'

Pull-Request:
https://github.com/SAP/code-pal-for-abap/pull/262/files
Both checks raised because of double . at the end of the file.
False-positives? New check for it?

should probably change max_one_statement so that it does not report anything for empty statements

@lucasborin try again, latest version
note that I'm not always updating abaplint.app with every release, but I update it often, and always when there are big bugs

https://github.com/SAP/code-pal-for-abap/pull/284/files

so its working, right? we can close the issue?


Example listener missing _dw1000_cir_complex

For the listener example the definition of _dw1000_cir_complex is missing
Error: apps/listener/src/main.c: In function 'process_rx_data_queue': apps/listener/src/main.c:193:17: error: invalid use of undefined type 'struct _dw1000_cir_complex'                  printf("%c%d", (i==0)? '[':',', cirp[i].real);

Hi Michist,
This issue has been resolved in the bottleneck branch and will be merged into the master shortly.


Like is not updated after coming back from event details

Describe the bug
If user like/unlike the event on event details page and come back to list, event is not updaed in the list.
To Reproduce

Open event details
Like/unlike event
event is not updated

Expected behavior
Like should be updated
Screenshots

Would you like to work on the issue?

Yes

@iamareebjamal @liveHarshit @anhanh11001 please help me in fixing this?

@aman210697 Are you working on it?

This can be closed now. PR #1707


sq.pl.extract doesn't work with ArrayView objects

Description

Sometimes I have AnnData objects with ArrayView objects in the .obsm field, but if I use sq.pl.extract on those objects, this results in NaN columns in the .obs field of the resulting object.
Minimal reproducible example

It is difficult to reproduce because I am not sure why there are ArrayView objects in my AnnData, but I find that if they are there, then sq.pl.extract will fail in this way.
Traceback

Version

'1.2.3'

hi @alam-shahul ,
the array view happens if you have a "view" of an anndata, e.g.
adata_view = adata[:,0:10] # this is a view
adata_copy = adata[:,0:10].copy() # this is not a view

I'm not sure we'll be able to support extract on views I'm afraid


Please create a plugin similar to google-sign-in but for Facebook authentication

It would nice to have an official supported plugin to authenticate with FaceBook. This should be similar to the "google-signin" plugin.
Currently , there is an open source "flutter_facebook_login" plugin but  has sparse support and it seem to break it every time a new flutter release is pushed.
This facebook plugin is necessary for apps that let user authenticate with various social framework.
I believe it will allow greater adoptability if it was an official 1st party plugin from the flutter team
Thanks

Anybody else does have this necessity?
I really need to add facebook login to my app but I am not able to do that.
Somebody does have any advice?

Closing as out of scope; we don't general wrap third-party, non-system SDKs. This request should be directed to the SDK developer, and failing that could be implemented by the community.


Optionally allow Problems, Debug Console,  Terminal, or Output to be shown as Sidebar Icons

Use Cases:
While editing I would like to be able to have two editors split left/right, terminal at the bottom, and problems showing on the left.
OR
While editing I would like to quickly be able to open/close Output/Problems with CTRL + B
OR
While debugging I would like to be able to have output and debug console open at the same time
Description:
Right clicking on Problems, Debug Console,  Terminal, or Output would show an option to 'Move to Sidebar' whereupon a new icon appears in the sidebar which grants access to the aforementioned.
AND/OR
In settings provide 'Problems/Debug/Console/Terminal/Output: Default Location' with Sidebar/Panel options.

This is currently on the plan and @sbatten has it on the horizon, thus assigning this issue to him
Also @misolori since we would need probably more icon design when views are moved to the sidebar (to show the icons in the activity bar)

icons are in, all panels can be dragged to the activity bar.
terminal, output, and debug have outstanding issues to resolve before this item is closed


Style: Dark theme button

What's the suggested design idea?
a dark theme button can be added to website to look more better
Add screenshots
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

Please Refer #15 @akshad36