[FEATURE] Close Other Tabs | Close Tabs to the Left/Right (Right Click on Tab)

The title is self-explanatory :)

@haxzie Once I get time, I'll start pushing out PRs here too :)

I also thought it will be good to have this feature.
@DivyanshBatham
Do you have any update about this feature ?

@urangurang I'm running super busy, unable to work on this. Would you like to take this up?

Sure, I will get to it this week.
If you are okay, please assign this issue to me.

@urangurang Unfortunately, I don't have the permissions to do that.
@haxzie was hospitalized, and is just coming back to work. I'll ask him to assign you the issue.

Thanks for willing to work on this @urangurang! I have assigned the issue to you, drop a comment here anytime if you need any help :)

Implemented in #64


Use classes in the program

Fortran has very nice class support. Switch to classes.

The final step in this PR is to create a SalaryCalculator. This will encapsulate everything that's currently sitting in the calculations module and can also take utils get_monthly_gross and utils get_annual_gross in.

Nice.


Can't sign transaction on the simplestdapp

There are 4 issues in this workflow I can spot so far.

When I am trying to create a cell, after entered the password, the Synpase extension says "Your Tx failed to send".
The popup firstly displays this page and then redirect to the password form. It should directly go to the password form.

When I resize the popup, the UI is not responsive to the size of the popup window.

The underline of the network dropdown doesn't seem to be well aligned.

Responsive popup will be like this and will be release soon:

When I am trying to create a cell, after entered the password, the Synpase extension says "Your Tx failed to send".

Fixed.
This is due to the rpc node did not work, I replaced it with another rpc node.

The popup firstly displays this page and then redirect to the password form. It should directly go to the password form.

Fixed.

The underline of the network dropdown doesn't seem to be well aligned.

Fixed

@katat These fixes are included in the new release: https://github.com/rebase-network/synapse-extension/releases/tag/v0.1.3


Move NA gateset out to target_gatesets

Thinking a little bit more on https://github.com/quantumlib/Cirq/issues/2793 I'm wondering if we can't just move the NeutralAtomGateset into compilation_targets (plan is still to outright get rid of the neutral_atom device). It would save us an extra deprecation and still accomplish the goal of emptying out the neutral_atom directory. What do people think ?

Closing after offline discussion with @tanujkhattar


Tooltip offset?

Is there any way to set the offset of a tooltip? something like the one in the official bootstrap tooltip.
Thanks in advance 💃

You can set the offset of a tooltip by passing offset  as the property of modifier, which in turn can be passed as a prop to Tooltip.  For example
<Tooltip placement="right" isOpen={this.state.tooltipOpen} target="TooltipExample" toggle={this.toggle} modifiers={{offset:{offset: '-200px', enabled: true}}}>
  Hello world!
</Tooltip>

@illiteratewriter
Yes. That's the way to do it right now! (Demo)
But we should add offset prop to Tooltip and Popover components for ease of use.

Can I give it a shot?

@illiteratewriter go for it.
@TheSharpieOne Any thoughts?

What should be done if someone passes the offset prop and also his/her modifiers also contain offset?

offset object should be passed or just the value of offset inside the offset object needs to be passed as prop?

We should pass just the value of offset.
offset prop should be like:
PropTypes.oneOfType([
  PropTypes.number,
  PropTypes.string
]),

Valid examples are:
10
'10%'
'10, 10'
'10%, 10'
'10 + 10%'
'10 - 5vh + 3%'
'-10px + 5vh, 5px - 6%'

Completed via 3561e3c.


bannable

Just to say that its bannable asf. I got banned bcs of it

you need to make it a non community server click for me and my friends only and stay low. if you get reported even once even if its not related to the bot your done.

and dont make it a public server.

make a alt for this 100% and use a vpn if u want ig

and utilize the backup tokens feature

Did you enable the keylogger? I think that got me banned, when I didn't have the keylogger feature I didn't get banned, but not 100% sure

I did use keylogger

Did you enable the keylogger? I think that got me banned, when I didn't have the keylogger feature I didn't get banned, but not 100% sure

I  think it works because i didnt get banned almost entire day i was using it.

bro i cant find a good vm

and utilize the backup tokens feature

What back up tokens feature?

and utilize the backup tokens feature

What back up tokens feature?

in the builder there is 2 emergency token boxes. just incase one of your bots get deleted theres another way to get it back.
kinda self explanitory


Gather UX insights regarding Tabs

### Tasks
- [ ] Gather tabs components of all products within Figma
- [ ] Wireframing Tabs
- [ ] Create acceptance criteria for Tabs together with the Team

Duplicate story


Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL

describe('H2ome Title Bar Text description',function(){

  it('Test2',function(){
 browser.get('https://localhost/viewer');

   expect(browser.getTitle()).toBe('Test Screen');
 });

});

I have a non-angular login screen before this page, I am able to login with browser.driver. After logging in, the page is redirected to angular 2 app.
conf.js
spec:['loginTest.js','homeTitleBar.js']

After executing loginTest.js, I am getting the error  Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL  in spite of setting the timeout to 120sec.

Protractor will by default wait until Angular is loaded. Did you set:
beforeEach(() => {
        browser.ignoreSynchronization = true;
});

to not wait for Angular to load?

Hi there!
Your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)

Thanks!
PS.  The problem is probably that you need ignoreSynchronization for the non-angular page, as @rolandoldengarm  said


Implements contains() for Ranges

Description of changes:
This PR works on changes for implementation of contains() in Range.
Changes:

adds contains() for Range struct
Note: TODO - implement contains for Timestamp ranges.

Tests:

adds unit tests for contains()

As I was reviewing this and suggesting more test cases, it occurred to me that these test cases should be covered by the ion-schema-tests. Is it possible to integrate with ion-schema-tests even if we can't run all of them right now? (Maybe the test runner can unwind any panics that are caused by a todo! and mark the test as "skipped" somehow.)
There might be a lot of effort saved if you could develop directly against ion-schema-tests instead of having to replicate every possible edge case with unit tests.

Yes, I can integrate with ion-schema-tests in a separate PR. As for Range#contains we would need separate unit test cases from ion-schema-tests as it doesn't include Range#contains specific tests.

As I was reviewing this and suggesting more test cases, it occurred to me that these test cases should be covered by the ion-schema-tests. Is it possible to integrate with ion-schema-tests even if we can't run all of them right now? (Maybe the test runner can unwind any panics that are caused by a todo! and mark the test as "skipped" somehow.)
There might be a lot of effort saved if you could develop directly against ion-schema-tests instead of having to replicate every possible edge case with unit tests.

Yes, I can integrate with ion-schema-tests in a separate PR for all ISL constraints. As for Range#contains we would need separate unit test cases from ion-schema-tests as it doesn't include Range#contains specific tests.

You're right that it wouldn't contain tests specifically for Range#contains, but it does contain test cases that could have caught the some things here (via the valid_values tests). I'm certainly not suggesting that we do away with unit testing. Anyway, this is not something that needs to be resolved for this PR—it was just an observation that I had. Sorry to distract from the main point of the PR.


insetrt link

How i can insert link with my text.
i saw your example link.js.

The example code should help illustrate how this can be done. I'm afraid I can't do much to help without more specific questions.


Helm verification seems to choke with gpg2 or yubikeys

A similar issue seems to be here: https://github.com/keybase/keybase-issues/issues/1885
$ helm verify --keyring ${HOME}/.gnupg/pubring.kbx mysql-0.2.1.tgz
Error: failed to load keyring: openpgp: invalid data: tag byte does not have MSB set

$ helm package --sign<EMAIL_ADDRESS>--keyring /home/ahowden/.gnupg/pubring.kbx mysqlError: openpgp: invalid data: tag byte does not have MSB set

As a heads up also, the keyring for gpg2 also seems to have been moved.
This issue is a little hard to track down, as I don't have a private key that isn't on the yubikey.
Possibly related: #1475

I spent a lot of time with @vdice tracking this down a while back. We didn't find a good solution. I think we ended up doing some export/import cycle a few times or something like that.
With the plugin stuff, I am starting to think that maybe stand-alone sign/verify plugins may be better. I wrote one for Keybase yesterday, and it was much nicer to just take advantage of the native tooling instead of working with Go's PGP implementation.
I'll post a link to the plugin (which can be used stand-alone) when I create a repo for it.
If I can figure out the keyring support, at least some of these issues should be resolved. But I'm not sure it will be a cure-all.

That seems reasonable. The only issue I can foresee is that one person signs with one plugin, and another verifies with another plugin we might end up with the same issue, but with the additional complexity of multiple plugins.
That being said, if there's one "defacto" plugin maintained by someone else (such as keybase) that works consistently, that's awesome.
I appreciate your work though! Helm is now my preferred method of constructing k8s projects.

My intent was to preserve the OpenPGP style signing. So you can use any implementation of PGP to sign and to verify. My test case was to sign with Keybase and verify with GPG and Helm.
Mainly, the issue is that if we want to support the more sophisticated aspects of tools like GnuPG or Keybase, we either have to write a ton of Go code (and probably fork Go's OpenPGP library), or figure out a clever way to expose those tools. Plugins might be the way to expose those tools.
That said, I will probably try to finish the gpg-agent PR simply because that gets us several wins for the default implementation.

Over the weekend, I wrote a helm gpg plugin just to test out some of the ideas here. https://github.com/technosophos/helm-plugins
It's not great, but it does allow you to use a lot more of the native GnuPG features. I'm going to keep working on this idea as we move toward the Helm 2.1.0 release.

Awesome! I love the plugin structure also. The plugin doesn't work for me at the minute (a missing function and changed signatures); if I get time today I'll find a reasonable common ground and get a pull request in.

Did you have any luck with the plugin? I updated once (I think) after you filed this issue.

I'm marking this as closed, since I think the plugin is the intended destination for this feature.

Sorry man! I haven't had a chance to look at this. I'm dropping a bunch of my obligations at the minute, as some higher prio stuff has taken all my time. FWIW, no, it doesn't work:
$ helm gpg sign prometheus-0.1.4.tgz
+ [[ 2 < 1 ]]
+ type gpg
+ case "${1:-"help"}" in
+ :
+ [[ 2 < 2 ]]
+ shift
+ keyname=
+ '[' prometheus-0.1.4.tgz '!=' '' ']'
+ case $1 in
+ break
+ sign prometheus-0.1.4.tgz
+ is_help prometheus-0.1.4.tgz
+ case "$1" in
+ return 1
+ chart=prometheus-0.1.4.tgz
+ echo 'Signing prometheus-0.1.4.tgz'
Signing prometheus-0.1.4.tgz
++ openssl sha -sha256 prometheus-0.1.4.tgz
++ awk '{ print $2 }'
Invalid command 'sha'; type "help" for a list.
+ shasum=
++ tar -zxf prometheus-0.1.4.tgz --exclude charts/ -O '*/Chart.yaml'
tar: Pattern matching characters used in file names
tar: Use --wildcards to enable pattern matching, or --no-wildcards to suppress this warning
tar: */Chart.yaml: Not found in archive
tar: Exiting with failure status due to previous errors
+ chartyaml=
Error: plugin "gpg" exited with error

$ gpg --version
gpg (GnuPG) 2.1.17
libgcrypt 1.7.5-beta
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Home: /home/${PLACEHOLDER}/.gnupg
Supported algorithms:
Pubkey: RSA, ELG, DSA, ECDH, ECDSA, EDDSA
Cipher: IDEA, 3DES, CAST5, BLOWFISH, AES, AES192, AES256, TWOFISH,
        CAMELLIA128, CAMELLIA192, CAMELLIA256
Hash: SHA1, RIPEMD160, SHA256, SHA384, SHA512,

$ openssl version
OpenSSL 1.1.0c  10 Nov 2016

$ tar --version
tar (GNU tar) 1.29
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by John Gilmore and Jay Fenlason.

$ sudo hostnamectl
   Static hostname: ${PLACEHOLDER}
         Icon name: computer-laptop
           Chassis: laptop
        Machine ID: ${PLACEHOLDER}
           Boot ID: ${PLACEHOLDER}
  Operating System: Debian GNU/Linux stretch/sid
            Kernel: Linux 4.8.0-2-amd64
      Architecture: x86-64

"Managing Expectations" -- I'm not going to be able to look at this much further. If I get to use this in prod, I'll modify the script so it works for me and submit a pull.

For visitors landing here via search, the Helm GnuPG plugin @technosophos commented about did work for me 👍


extend subnet cidr block

per https://github.com/Senzing/aws-cloudformation-database-cluster/issues/27

PR merged, release published, CFTs updated in S3


[AMQ-8169] Do not unwrap in two threads concurrently

According to the SSLEngine docs "two threads must not attempt to call the same method (either wrap() or unwrap()) concurrently, because there is no way to guarantee the eventual packet ordering".
serviceRead(), the loop that calls unwrap(), was called in doInit() as well in initializeStreams() which intermittently leads to errors such as javax.crypto.AEADBadTagException: Input too short - need tag as described in the associated Jira as the two threads compete to unwrap network traffic.

Looks like there is a reason for serviceRead() to be in the doInit(). Looks like it was specifically added for the auto+nio+ssl use case and when used for bridges.  Start/Stop
ref: https://github.com/apache/activemq/commit/ed0e786b6002633411037923fb28a075489e442b

There might be a better way than what I did but if I recall auto+nio+ssl was having issues without this change. It's been a long time since i looked at it though


Provide a walkthrough for how to install the Azure SDK packages in a VS MSBuild project via vcpkg.

Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/5457

/check-enforcer override

Please take a look folks, so I can merge it.


Set up your Kanban board

We are a two-member team

Setted up Kanban
Assigned to the issues

https://github.com/Ntare22/spacex/projects/1

Hi @eapenzacharias and @Ntare22,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Revamp the footer

issue: #43

Make following changes

Bring "Open Code Era" and "improve this page on GitHub" to same level
Center align the copyright section

OPTIONAL

Try to style "Open Code Era"

How about resizing the 'Open Code Era' and positioning it as it is in the left corner and the GitHub link to the right corner and copywrite to be at the center? Like the picture

How about resizing the 'Open Code Era' and positioning it as it is in the left corner and the GitHub link to the right corner and copywrite to be at the center? Like the picture

looks good! Just reduce the height of the footer.
We'll increase the height after adding the social icons.

great. Working on it.

Works?

Works?

Nice work!

Then we can merge it.

@AdarshRawat1 The branch is ready to merge. Feel free to contact me if anything crashes. Happy to contribute and learn.

@Ritik-Bhasarkar thanks for the PR


Rewrite exception references in PT027 fix

from unittest import TestCase, main

class TestFoo(TestCase):

    def test_foo(self):
        with self.assertRaises(Exception) as exc:
            raise Exception('foo')
        assert str(exc.exception) == 'foo'

main()

gets converted by ruff --fix --select PT027 --unsafe-fixes foo.py into:
from unittest import TestCase, main
import pytest

class TestFoo(TestCase):

    def test_foo(self):
        with pytest.raises(Exception) as exc:
            raise Exception('foo')
        assert str(exc.exception) == 'foo'

main()

causing:
E
======================================================================
ERROR: test_foo (__main__.TestFoo)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "foo.py", line 10, in test_foo
    assert str(exc.exception) == 'foo'
AttributeError: 'ExceptionInfo' object has no attribute 'exception'

----------------------------------------------------------------------
Ran 1 test in 0.000s

FAILED (errors=1)

correct would be:
from unittest import TestCase, main
import pytest

class TestFoo(TestCase):

    def test_foo(self):
        with pytest.raises(Exception) as exc:
            raise Exception('foo')
        assert str(exc.value) == 'foo'

main()

I'm working on a PR for the issue, just a quick question would it be helpful to include in the lint error message, the new change that's been added? So something like this,
test.py:6:14: PT027 [*] Use `pytest.raises` instead of unittest-style `assertRaises` and replace `exc.exception` with `exc.value`

Or is that too verbose? I'm guessing if we change the error message we also need to update the docs for it.

I don't need that addition. Probably many lint rules do a little bit more than that, e.g. adding new imports.


The compatibility about 1.7.36 & 2.x

Are there any compatibility issues when we need to upgrade slf4j from 1.7.36 to 2.x？

Biggest issue is if you are using spring boot 2.  Its possible to turn off spring boots logging and use 2 though but its not straight forward and spring hasn't exactly helped there.  You can find that info in their issues if you dig deep enough.
What I dislike in general was fact that slf4j went major to 2.x while logback was left minor on 1.3 (javax namespace) and 1.4 (jakarta namespace).  That part is the most problematic because the bots (renovate, synk, dependabot, others) treat 1.3 and 1.4 the same by default and suggest premature upgrades to 1.4.x.  The only saving grace if any was the level of CVEs on logback this week that caused the bots to send targeted releases but those were already deemed buggy and not complete.  So a lot of manual work :(
Should you upgrade?  Yes, it took years if I recall to get here.  So long as you don't have spring boot consideration, there is no question just upgrade.  As long as your configuration was not outrageous on requirements, its basically drop in place.  In fact, for the some 2k repos I support, I don't recall any considerations outside of spring boot.  And even there we upgraded some of those to latest on 2.7.x with various solutions found within spring boot issues.

In addition to the link @KengoTODA  mentioned, there is also Are SLF4J versions backward compatible?  FAQ entry which you might want to read.


Discogs Artwork Import: Failed to fetch or enqueue images: HTTP error 500

Hi all, im tryin to import Artwork from Discogs and everytime i try it i get the following message:
Failed to fetch or enqueue images: HTTP error 500
Amazon, Bandcamp etc. works. Is there a know problem? Thanks

Which version are you using? I am on 2024.5.1 and importing from Discogs works fine for me.
Can you please give us an example URL where it is failing?

Which version are you using? I am on 2024.5.1 and importing from Discogs works fine for me.
Can you please give us an example URL where it is failing?

Hi, and thanks for your reply.
Im also using Version 2024.5.1
The problem is not a specific release, its on every release.
Dont know if i should get a popup window for the first time using it like the allow bandcamp, apple etc. But on Discogs i never got that popup, and i get the error "Failed to fetch or enqueue images: HTTP error 500" on every Release. Using latest Chrome, Tampermonkey & Mb scripts.
Just for trying, here is one release:
https://musicbrainz.org/release/c3178f51-72ff-4537-9549-ff3dbce27e4d/cover-art
In the options there is also nothing on Exclued

Hmm, I don't have tried it with Chrome but in Firefox it works with Tampermonkey 5.1.1.
There was a big behind the scenes change in Tampermonkey to use MV3 recently (Chrome version 5.2), so it might be related to that.

Ok, i tried it with firefox, fresh install of everything... it works. Thank you for your help, will just wait for an update :)

I managed to reproduce this on the latest Chrome version with Tampermonkey 5.2.0 and 5.2.1, but only when logged in to a Discogs account. Starting from Tampermonkey 5.2.2, the issue seems to be fixed, so this was likely caused by the GM_xmlHttpRequest cookie issue that is said to have been fixed in their changelog.
In short: This appears to be fixed in the latest Tampermonkey versions.


Fixed typo: not -> no

Thanks a lot for this library BTW, have been playing with it for a couple of days now.

Thanks for the PR


Game don't start after the August 29th app update

Unless I remove umamusume-localify

It seems that this is caused by the addition of the "全国興行" function to push notifications. It will be fixed soon.


HelloXR Vulkan version enables USE_MIRROR_WINDOW default, and it is annoying when testing it on Windows

See https://github.com/KhronosGroup/OpenXR-SDK-Source/blob/main/src/tests/hello_xr/graphicsplugin_vulkan.cpp#L21.
From the comment, USE_MIRROR_WINDOW shows a dummy window when running Vulkan version of HelloXR on Windows platform, and this window is used for RenderDoc. As a normal tester, I don't use RenderDoc, and I just want the Runtime to display a native window to show the rendered content. What about disabling it default? If other folks want to run it with RenderDoc, they can build it with patch to enable USE_MIRROR_WINDOW macro.

hmm, I don't think I had actually seen this, though I guess I run CTS more often than hello XR. Seems reasonable to have it off by default, and/or make it switchable.

@rpavlik I sent a new PR to disable it default. If developers want to debug it with RenderDoc, they can modify the code and build and run it manually.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Updated. Thank you.


Translation

Unfortunately, I did not code Slide with support for Translations as of now, but this is something I wish to refractor soon and (possibly) use crowdsourcing like I do on Slide on Android with Crowdin!
Closes #159

Is it possible to use the same strings file or whatever resource you use on android, so you don't need two of the almost same translations ?

@Kazbin Great suggestion, but it would almost completely have to be manual because of the very different way Apple and Android handle translations. I might try to throw together a script and see if I can do something about it, but there are also specific iOS strings that must be converted to each language


(selenium-edge-chromium-driver) Migrate package to repository

Discussed in https://github.com/chocolatey-community/chocolatey-packages/discussions/1870

Originally posted by AdmiringWorm April 30, 2022
I was recently made a maintainer of this package, and with that I request it being added to this repository for continued maintenance and to be kept up to date by multiple people.
This ties in to the request of moving the gecko and chrome driver, and makes sense to move this driver as well since it is an important package for us and the community.

This was completed in https://github.com/chocolatey-community/chocolatey-packages/pull/2018


Progress indicator (new component)

Review 2019-02-27
At the review, Design working group decided to WAIT with publishing this component so we can evaluate the use (read further down on this thread). We will keep it in Design library, under Components/Upcoming for a while.
You are still welcome to use it, but please give us feedback on how it worked.
Need
A step indicator that shows progress in a flow. Today we have wizards which take-over the complete focus for the user. This indicator is a way to gently guide the user forward without loosing context.
Specification

Used for mobile and desktop
Height 8 px
Filled step: Dark Green 1
Unvisited step: Grey 8
Gap between steps: White 2 px

Description
See details on Design library: http://designlibrary.sebgroup.com/components/upcoming/progress-indicator/#usage
Ulrika,
Design management

:tada: This issue has been resolved in version 4.7.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Docs]: Add OpenLIT to Observability documentation

Hi Team, Maintainer of OpenLIT here.
This PR adds OpenLIT as an Observability integration in the Doc like the other ones.

Hi @patcher9, could you help add a more detailed example to our cookbook and we can link the cookbook in the docs? Thank you!


Added travis.yml and kitchen-docker.yml

Having the ability to have travis.yml in the cookbook and
kitchen-docker will allow for integration testing via travis.
Signed-off-by: JJ Asghar<EMAIL_ADDRESS>

can we mass-move templates/default/* into templates/* as well?  the 'default' directory hasn't been necessary since Chef 12.0.0

can we mass-move templates/default/* into templates/* as well? the 'default' directory hasn't been necessary since Chef 12.0.0

Shouldn't that be a different commit? I can open that PR too if you want.

To be clear, this is not using kitchen-docker. Please fix the filenames to reflect that :) I do have example kitchen-docker configs up at https://github.com/poise/yolover-example/ if you want them, but dokken is probably fine for most users.

Good point @coderanger making that change.

Shouldn't that be a different commit? I can open that PR too if you want.

I don't super care, I just don't want to see process get in the way of useful cleanup and not see the cleanup get done.

Until we can get a sane experience for kitchen-dokken where users don't have to understand the various packages they need in order to get a working generic OS out of a docker container and I think we should hold off on this. Some day it'll be super cool, but the ecosystem isn't ready. We'd just cause a ton of pain for customers.


Bluetooth activation button lost since windows update

Hello. Since last version of windows 10 (2019).the bluetooth button for activation is not here in parameters.  Am i alone with this problem?

Windows or driver issue, which is unrelated to the repo. Closing the issue...


Memory usage

The model seems to require a GPU with at least 24GB of VRAM. It doesn't seem like it needs to be that big (but maybe).
Should it be possible to run it in 16GB, for example?

16GB seems not enough, typically we use 32GB GPU for model training, or else there is oom issue.


CPUFriend

I see that you have removed both CPUFriend.kext and CPUFriendDataProvider.kext. My understanding is that you either use the CPUFriendDataProvider.kext or the SSDT-CPU.aml as generated by CPUFriendFriend but you always need CPUFriend.kext.
Are you suggesting that OpenCore does natively what CPUFriend.kext does and therefore not needed?

Yes, you’re right, CPUfriend kext is needed.

This confirms that OpenCore handles perfectly power management, cause I don't really noticed differences between using CPUFriend.kext w/ CPUDataProvider.kext and not using any.


Why is Response awaitable?

Prerequisites

[x] I have written a descriptive issue title
[x] I have verified that I am running the latest version of Nancy
[x] I have verified if the problem exist in both DEBUG and RELEASE mode
[x] I have searched open and closed issues to ensure it has not already been reported

Description
Why is Response awaitable?
Steps to Reproduce
There was some noob confusion when having a method to return a response. Get("/logout", async _ => await this.Logout(_));
I determined that the method should return Task<dynamic> not Task but I think this was due to some confusion with intellisense saying that Response was awaitable eg await Response.AsRedirect("/") where in fact I should return Response.AsRedirect("/")
I assume Response is awaitable for rendering Views but what would that look like return await View["Home"] ??
Anyway just thought I'd log the issue for other noobs like me
System Configuration

Nancy version:
Nancy host

[ ] ASP.NET
[ ] OWIN
[ ] Self-Hosted
[x] Other: Kestrel

Other Nancy packages and versions: 2.0.0-barneyrubble
Environment (Operating system, version and so on): Windows/OSX
.NET Framework version: netcore
Additional information:

To be honest I think this is a left over from when we were exploring various implementations of the new route syntax. I think it can be removed without any implications. It has nothing to do with View since that does not return a Response. I just commented it out and ran all out tests and they all came back green.


Allow to provide a custom deserializer (or at least a function for that) for the tag field.

I love the ability of serde to deserialize into an enum by reading an enum tag. However, the format of such tag is a bit limited, and only works with strings. There is an issue about allowing numbers, but I would like to go beyond that and ask for a feature to provide a custom, deserializarion mechanism for such field.

Is the serde_repr the thing you are looking for?

No, that seems to be what #2479 wants/needs.
What I want is being able to provide a deserializer/deserialization function for the specific tag field.
Something like:
#[serde(tag=theTag tag-deserializer="some_fn")]

So data like this can be properly deserialized into enums
{ tag: ["Tag1"], age: 55, some_data: "bla"},
{ tag: ["Tag2"], age: 15, some_data: "miau"},


Properties are documented and instantiated as array, turn out to be objects of type stdClass

There are several properties that are documented and initialized as an array, but turn out to be objects of type stdClass (as indicated by the error Error : Cannot use object of type stdClass as array when trying isset($message->typeDetails['udh'])).
Where I found this so far:

\MessageBird\Model\Message::typeDetails
\MessageBird\Model\Hlr::details

Another instance is the details property of the MessageBird\Objects\Hlr class.

#182 should partially solve the issue. We still need to improve the typings.

Closing this due to inactivity.


Store app async API

This patch completes pull request #9, such that it makes the store app control follow the async/await pattern. Breaking API changes:

RelayoutGraph -> RelayoutGraphAsync
GenerateGraph -> GenerateGraphAsync
New method: CancelRelayoutAsync (brings control in par with WPF control)

All methods (except CancelRelayoutAsync) may be passed an optional CancellationToken that may be used to cancel the operation. This token is linked to an internal cancellation token source, making it possible to cancel an operation by means of the passed in token, or a call to CancelRelayoutAsync.
I also fixed two bugs: DispatcherHelper grabbed a reference to the UI thread dispatcher in a way that is not safe. It attempted to get a reference when the source was not yet populated. The safe way to get hold of the reference is through the rather long name Windows.ApplicationModel.Core.CoreApplication.MainView.CoreWindow.Dispatcher.
The second bug was one I introduced in #9: The cancellation token source was not disposed.

Thanks! Merged. Looks good to me :) I didn't knew about the long dispatcher reference name, thanks for information :D Store apps are new thing for me too, i've found it interesting to learn and implement GraphX for it :)


Weave tool print-sig command

-- Added a command to the weave tool for printing the contents of a Weave signature object.  Similar to print-cert, the print-sig command takes a file containing an encoded Weave signature in either raw TLV or base-64 format, and prints the fields within the signature in a human readable format.
-- Added utility functions for decoding Weave certificates and certificate-related structures without needing to load them into a WeaveCertificateSet object.
-- Added utility functions for printing various security-related constructs such as Weave signatures, distinguished names, TLV arrays of certificates, ECDSA signatures, and certificate references.
-- Simplified the implementation of the weave tool’s print-cert command by using the new utility functions described above.
-- Modified the ASN1Writer class to support a ‘null-writer’ mode.  When initialized in this mode, the user is not required to supply an output buffer, and all calls to encode ASN1 constructs are silently ignored.  This is useful in cases in cases where one must call a function that requires an ASN1Writer but the output of the writer is unneeded.
-- Enhanced the TestWeaveTool unit test script to test the print-cert command.
-- Enhanced the TestASN1 unit test to test the new null-writer functionality.

Happy pairing test is failing, presumably for unrelated reasons.

Codecov Report

Merging #178 into master will increase coverage by 0.11%.
The diff coverage is 83.61%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   54.22%   54.34%   +0.11%
==========================================
  Files         326      327       +1
  Lines       55972    56193     +221
==========================================
+ Hits        30352    30538     +186
- Misses      25620    25655      +35

Impacted Files
Coverage Δ

src/lib/profiles/security/WeaveCert.h
100% <ø> (ø)
:arrow_up:

src/tools/weave/GeneralUtils.cpp
73.98% <100%> (+1.1%)
:arrow_up:

src/tools/weave/weave-tool.cpp
64.44% <100%> (+1.65%)
:arrow_up:

src/lib/profiles/security/WeaveCert.cpp
83.76% <100%> (ø)
:arrow_up:

src/tools/weave/Cmd_PrintSig.cpp
66.66% <66.66%> (ø)

src/tools/weave/Cmd_PrintCert.cpp
64.7% <75%> (-5%)
:arrow_down:

src/test-apps/TestASN1.cpp
91.54% <81.81%> (-1.9%)
:arrow_down:

src/lib/profiles/security/WeaveSecurityDebug.cpp
69.74% <83.82%> (+15.78%)
:arrow_up:

src/lib/profiles/security/WeaveToX509.cpp
88.14% <85.71%> (-0.66%)
:arrow_down:

src/lib/support/ASN1Writer.cpp
87.33% <91.83%> (+1.82%)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb41a31...b3b919e. Read the comment docs.


Update documentation to make it clearer CocoaPods is not mandatory

Problem Statement
Currently, the docs on https://docs.sentry.io/platforms/kotlin-multiplatform suggest CocoaPods is mandatory when integrating the library. There's even a section on SPM at the bottom that says we can use SPM for other things, but we still need CocoaPods for Sentry.
Is this really true, though? We tried adding Sentry directly on iOS with SPM (https://docs.sentry.io/platforms/apple/install/swift-package-manager) and it seems to have worked fine. Looking at https://github.com/getsentry/sentry-kotlin-multiplatform/issues/118 and https://github.com/getsentry/sentry-kotlin-multiplatform/issues/108 it also seems to confirm this strategy would be fine.
It would be great to get clarity on this and get the docs updated if they're indeed misleading.
Solution Brainstorm
No response

I assume your is Static = true is set in the framework? in that case it should work but not for tests because the linker is not configured there, that's the main issue. When you look at the cocoapods plugin source code they set up the linking automatically that's why it's suggested to set up both. If you don't setup linking you will get this error
Regardless we actually have new docs merged in today (not sure when they will be live) that suggests to use our gradle plugin that does all the linking so you're not tied to using only cocoapods. Please try it out
plugins { id("io.sentry.kotlin.multiplatform.gradle") version "0.10.0" }

Yes, we do set isStatic = true! And thanks, we'll try out the plugin and report back.


Crash when bounds of prange() are Python objects

The following construct crashes:
cdef unsigned long i
cdef double[:] data = ...
for i in prange(len(data), nogil=True):
    ...

The generated C code is as follows:
      #ifdef WITH_THREAD
      PyThreadState *_save;
      Py_UNBLOCK_THREADS
      __Pyx_FastGIL_Remember();
      #endif
      /*try:*/ {
        if (unlikely(!__pyx_v_data.memview)) { __Pyx_RaiseUnboundMemoryviewSliceNogil("data"); __PYX_ERR(0, 24, __pyx_L4_error) }
        __pyx_t_1 = __pyx_memoryview_fromslice(__pyx_v_data, 1, (PyObject *(*)(char *)) __pyx_memview_get_double, (int (*)(char *, PyObject *)) __pyx_memview_set_double, 0);; if (unlikely(!__pyx_t_1)) __PYX_ERR(0, 24, __pyx_L4_error)
        __Pyx_GOTREF(__pyx_t_1);
        __pyx_t_2 = PyObject_Length(__pyx_t_1); if (unlikely(__pyx_t_2 == ((Py_ssize_t)-1))) __PYX_ERR(0, 24, __pyx_L4_error)
        __Pyx_DECREF(__pyx_t_1); __pyx_t_1 = 0;

len() is evaluated after releasing the GIL. The loop bounds should be evaluated before, and the GIL check applied to all parts of the loop.
 Might also be part of the problem here.

Hi @scoder
I would like to work on this issue. I am trying to reproduce this, could you please help me with this
Thanks

@pshashank8, sorry, I think I missed your comment somehow. If you're still interested, see the HackerGuide on how to write a test, then look at the existing prange tests in tests/memoryview/memslice.pyx.
Regarding the implementation, I think it might be enough to call .coerce_to_simple() on the non-trivial prange() arguments during type analysis. That should trigger their ahead-of-time evaluation into a temporary variable, if necessary.


AssertionError: Unexpected event: <AlternativeServiceAvailable origin:https://kaspersky.com:443, field_value:h3=":443">

Problem Description
Mitmproxy crashes for certain responses, probably related to HTTP3.
Steps to reproduce the behavior:

Run mitmproxy
Run curl --proxy http://localhost:8080 -k https://kaspersky.com
Observe error in mitmproxy

error: <IP_ADDRESS>:62672: mitmproxy has crashed!
Traceback (most recent call last):
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/server.py", line 331, in server_event
    for command in layer_commands:
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 167, in handle_event
    command = next(command_generator)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 256, in handle_event
    yield from self._handle(event)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 167, in handle_event
    command = next(command_generator)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/http/__init__.py", line 846, in _handle_event
    yield from self.event_to_child(stream, event)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/http/__init__.py", line 899, in event_to_child
    for command in child.handle_event(event):
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 167, in handle_event
    command = next(command_generator)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/http/__init__.py", line 743, in passthrough
    for command in self.child_layer.handle_event(event):
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 167, in handle_event
    command = next(command_generator)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/tunnel.py", line 94, in _handle_event
    yield from self.event_to_child(event)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/tls.py", line 408, in event_to_child
    yield from super().event_to_child(event)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/tunnel.py", line 118, in event_to_child
    for command in self.child_layer.handle_event(event):
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 167, in handle_event
    command = next(command_generator)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/tunnel.py", line 94, in _handle_event
    yield from self.event_to_child(event)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/tunnel.py", line 118, in event_to_child
    for command in self.child_layer.handle_event(event):
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 258, in handle_event
    yield from super().handle_event(event)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 128, in handle_event
    yield from self.__continue(event)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 219, in __continue
    yield from self.__process(command_generator, event.reply)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 206, in __process
    command = next(command_generator)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 275, in _handle_event
    yield from self._ask()
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 289, in _ask
    yield from self.layer.handle_event(e)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 143, in handle_event
    command = command_generator.send(send)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/http/__init__.py", line 890, in _handle_event
    yield from self.event_to_child(handler, event)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/http/__init__.py", line 899, in event_to_child
    for command in child.handle_event(event):
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layer.py", line 143, in handle_event
    command = command_generator.send(send)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/http/_http2.py", line 440, in _handle_event
    for cmd in self._handle_event2(event):
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/http/_http2.py", line 513, in _handle_event2
    yield from super()._handle_event(event)
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/http/_http2.py", line 175, in _handle_event
    if (yield from self.handle_h2_event(h2_event)):
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/http/_http2.py", line 572, in handle_h2_event
    return (yield from super().handle_h2_event(event))
  File "/opt/homebrew/Cellar/mitmproxy/8.1.1/libexec/lib/python3.10/site-packages/mitmproxy/proxy/layers/http/_http2.py", line 265, in handle_h2_event
    raise AssertionError(f"Unexpected event: {event!r}")
AssertionError: Unexpected event: <AlternativeServiceAvailable origin:https://kaspersky.com:443, field_value:h3=":443">

System Information
Paste the output of "mitmproxy --version" here.
Mitmproxy: 8.1.1
Python:    3.10.6
OpenSSL:   OpenSSL 1.1.1q  5 Jul 2022
Platform:  macOS-13.1-arm64-arm-64bit

probably related to HTTP3.

Not sure but I think this is an issue with HTTP2, probably because kaspersky.com sets an alt-svc header in the response and there is no handling for that yet. I'll work on this.

Thanks! As the first fix we probably just want to swallow that so that it doesn't crash + add a test.


Fix mzml agilent ims import

This fixes the agilent ims import from csv files (missing scans due to no data)

index all mobility values in mzml -> get maximum number of mobility scans
create a custom scan number for every mobility (starting from 0)
get scan number by mobility value during import
create empty scans in case there are scans missing

Thanks Steffen


Wtmp

Use the exact IP in the hostname field
Preliminary support for freebsd
Update pam configuration to set the loginuid in procfs (As we are starting a session for a user)

I'll look at this on Tuesday. I also try it on FreeBSD next week.

Let's merge into wtmp branch.


reading cmake file syntax

Greeting,
CMakeLists.txt uses syntax commands which are extra to standard ROS commands e.g. google_library().
Where I can read about this syntax ?
Rgds

cmake/ directory. You can answer these questions for yourself by using the
search bar at the top of github.
On Mon, Dec 5, 2016 at 6:26 PM, nitin5<EMAIL_ADDRESS>wrote:

Greeting,
CMakeLists.txt uses syntax commands which are extra to standard ROS
commands e.g. google_library().
Where I can read about this syntax ?
Rgds
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/googlecartographer/cartographer/issues/150, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEi_UJSTBNAgHjhFyFtBtOz4CLihkG2pks5rFMe-gaJpZM4LE868
.

--
Daniel Galvez

The Cartographer CMake files are updated using scripts/update_cmakelists.py. Simple call the script and point it toward the source directory. For example:
$ cd github/googlecartographer/cartographer
$ scripts/update_cmakelists.py cartographer

See #151


creating sounds for MicroCode

We have the ability to play sounds over the micro:bit V2's speaker. There are various possibilities:

have a fixed set of sounds to play
play a tone (from C1-C2)
have a sound creation editor
sample and playback

Easiest is to play a tone (existing service and simple with sequencing capability)

Would be great to have a melody editor.
Sound expressions (built in microbit) would be exposed via the. "Sound player" service.


release.nix: don't block on aarch64-darwin boostrap tools

They haven't worked for several months, so let's not start blocking now: https://hydra.nixos.org/job/nixpkgs/nixpkgs-unstable-aarch64-darwin/stdenvBootstrapTools.aarch64-darwin.dist

relevant: #208888
should be really fixed by: #202347


Added support for overriding config location via environment variable…

… GOOGLE_API_CERTIFICATE_CONFIG

@lcforges thanks! Please sign the Google CLA


APLIC level-sensitive interrupts in direct delivery mode

APLIC has following description to level-sensitive interrupts in direct delivery mode.
If the source mode is Level1 or Level0 and the interrupt domain is configured in direct delivery
mode (domaincfg.DM = 0):
• The pending bit is set to one whenever the rectified input value is high. The pending bit
cannot be set by a write to a setip or setipnum register.
• The pending bit is cleared whenever the rectified input value is low. The pending bit is
not cleared by a claim of the interrupt at the PLIC, nor can it be cleared by a write to an
in clrip register or to clripnum.

Assume the rectified input of a level-sensitive interrupt is high and enabled, the interrupt will be sent to all hart with idelivery is high in the domain. The interrupt then be taken multiple times because the pending of claimed interrupt remains high. In original PLIC spec, this won't happen because the pending is cleared after interrupt claim. Next interrupt request will be forwarded after interrupt completion.
To fix the issue, we could use the same mechanism of  level-sensitive interrupts in MSI delivery mode. The term forwarded by MSI is changed to claimed. After the first responder who claimed the interrupt, others can't claim it until positive edge of rectified input or a relevant write to setip or setipnum register (the same purpose of interrupt completion in original PLIC spec). The changed description is written below:
If the source mode is Level1 or Level0 and the interrupt domain is configured in direct delivery
mode (domaincfg.DM = 0):
• The pending bit is set to one by a low-to-high transition in the rectified input value. The
pending bit may also be set by a relevant write to a setip or setipnum register when the
rectified input value is high, but not when the rectified input value is low.
• The pending bit is cleared whenever the rectified input value is low, or when the interrupt is
claimed. The pending bit cannot be cleared by a write to an in clrip register or
to clripnum.

An interrupt will only be sent to one hart based on target[i].HartIndex setting. This issue won't happen anyway.


Implement own search city dialog using bottom sheet

Current implementaion
We are using this library: https://github.com/mirrajabi/search-dialog
What to do?
Remove the use of the above library, and implement our own search city dialog in a bottom sheet

@Swati4star I would like to work on this issue but would need a bit of clarification on how this needs to done.

@Rimjhim28 What clarification do you need?
The issue is, we are currently using a library to select the city. Instead of that, when the option to select city is clicked, show the city names in a list in bottomsheet.

Okay @Swati4star! I will work on the issue and send a PR soon! :)

@Rimjhim28 Updates?

hey @Swati4star , shall I take this up??

Sure @nitinnatural

@Swati4star i can pick this up also??

As @nitinnatural hasn't started working on it, you can start @msecilmis

Ok, great. Can you assign the issue to me?

Sure, you can start working on it @msecilmis 👍

any updates @msecilmis ??

Yeah, im almost done. Right now i’m on vacation. Next week i’ll wrap it up


Pagination problem: undefined local variable or method 'total_count'

Pagination does not work after having more than 30 elements. The root cause is in the line 114 of  paginated_collection.rb.  The pull request is in progress

Put this into an initializer (I'm using config/initializers/will_paginate.rb):
  module ActiveRecord
    class Relation
      alias_method :total_count, :count
    end
  end

Commenting so anyone using the same google search I did will find this.
This isn't technically a bug in active_admin, but an incompatibility between the paginator active_admin depends on, kaminari, and will_paginate. #330 says this is fixed in active_admin but I'm still seeing the issue with the latest release. I also found this open issue: amatsuda/kaminari#162.

Looks like this issue has resurfaced with rails 5.1.4:
Processing by Admin::UsersController#show as HTML
  Parameters: {"id"=>"zgjimdida-zgjim-dida"}
  AdminUser Load (0.5ms)  SELECT  "admin_users".* FROM "admin_users" WHERE "admin_users"."id" = $1 ORDER BY "admin_users"."id" ASC LIMIT $2  [["id", 1], ["LIMIT", 1]]
  User Load (24.7ms)  SELECT  "users".* FROM "users" WHERE "users"."slug" = $1 LIMIT $2  [["slug", "zgjimdida-zgjim-dida"], ["LIMIT", 1]]
  Rendering vendor/bundle/ruby/2.4.0/gems/activeadmin-1.1.0/app/views/active_admin/resource/show.html.arb
  ActiveAdmin::Comment Load (30.0ms)  SELECT  "active_admin_comments".* FROM "active_admin_comments" WHERE "active_admin_comments"."resource_type" = $1 AND "active_admin_comments"."resource_id" = '650' AND "active_admin_comments"."namespace" = $2 ORDER BY created_at ASC LIMIT $3 OFFSET $4  [["resource_type", "User"], ["namespace", "admin"], ["LIMIT", 11], ["OFFSET", 0]]
  Rendered vendor/bundle/ruby/2.4.0/gems/activeadmin-1.1.0/app/views/active_admin/resource/show.html.arb (257.9ms)
exception
undefined method `total_count' for #<ActiveRecord::Relation []>
Did you mean?  total_entries
  Rendering public/500.html
  Rendered public/500.html (0.7ms)
Completed 500 Internal Server Error in 391ms (Views: 59.5ms | ActiveRecord: 60.3ms)

facing same issue :(
is there any way to fix it
Rails 5.0.x

Yes, I am getting the same error with 5.1.4.
AdminImagesControllerTest#test_should_get_show_view:
ActionView::Template::Error: undefined method total_count' for #<ActiveRecord::Relation []> Did you mean?  total_entries     activerecord (5.1.4) lib/active_record/relation/delegation.rb:125:in method_missing'
randumb (0.5.2) lib/randumb/relation.rb:197:in method_missing'     activerecord (5.1.4) lib/active_record/relation/delegation.rb:95:in method_missing'
activeadmin (1.1.0) lib/active_admin/orm/active_record/comments/views/active_
Anyone with fix?

This seems to be related to active admin comments.
When I disabled comments by setting config.comments = false in the initializer, the error was gone.

Still getting the same error. :(

@nikhilgupte thanks!

I'm also getting this error and would like to preserve the commenting feature.

I thought I'm the only one. I think we should use config.comments = false at the moment.

@nikhilgupte thanks man !

For anybody still coming to this issue and doesn't want to disable comments, you'll have to add some configuration in your initializer.


Make resources requirements in resource details page clickable

In a number of views we list the requires (both in the resource manager and the desired state). Each resource name should link to the corresponding details.

Hey team! Please add your planning poker estimate with ZenHub @andraskvr @Stijnkool


Check resource filtering with AS

Check if using AS for changing the name of a resource will allow you to pass the authorization on the resource although you shouldn't be able to access the resource.

it doesn't in the following query:
SELECT b.supplycost, b.availqty, b.partkey as bli FROM tpch.sf1.partsupp as b;


[Feature] Show commit changes when amending

In the "Changes" view, when clicking on the "Amend" checkbox, changes of the last commit should appear in the "Staged" panel.
This way, it's easy to see chunks we are going to commit. It's also an easy way to remove change from the last commit.
If there are staged changes in the working tree before clicking the button, then the staged panel should merge the changes. In this case, when unchecking, previously staged chunks should remain here (i.e. check+uncheck must be a no-op)
What I'm describing is how Fork works, and I find it very natural.

See #206

As mentioned in #206, it is true that we can use soft reset to the previous commit, but it's not as handy as Fork-style amend.  Moreover, we lose the last commit subject.

it is true that we can use soft reset to the previous commit, but it's not as handy as Fork-style amend.

I don't think it's more convenient to process changes by adding changes from the last commit

It's hard to tell which ones are previous and which ones are current.
More changes need to be checked.

Moreover, we lose the last commit subject.

If current commit message input box is empty, after you enable the Amend option, the message of last commit will be filled.

I've pushed a commit f55a5760135c1bd12749b4db5d8a18c7dc7d428a that implements this feature. But it causes two problems.

Because git stash is used for local uncommitted changes, it may not works as expected with staged changes in amend mode. This issue also exists in Fork app.
Since discard is not compatible with staged changes from HEAD commit, after commit f55a5760135c1bd12749b4db5d8a18c7dc7d428a, user can only discard unstaged changes.

You can try it from this build https://github.com/sourcegit-scm/sourcegit/actions/runs/10173863877

You can try it from this build https://github.com/sourcegit-scm/sourcegit/actions/runs/10173863877

Seems to work perfectly!

@love-linger just a small request on this. When amending, if I only modify the commit message, then sourcegit will complain because "No files added to commit!"
I understand the logic but I think this should be allowed. This is not exactly the same use case as an "empty" commit.

You should use Reword in context menu of selected commit.


fix: Fix inconsistent persitence of cron workflow objects

Maybe fixes: https://github.com/argoproj/argo/issues/4558
What I think the issue is
There are two places in the code where we read a cron workflow from the informer:

When building a context when processing a cron workflow CRD. The cron workflow is then stored and used by Run at the next scheduled runtime:
https://github.com/argoproj/argo/blob/1212df4d19dd18045fd0aded7fd1dc5726f7d5c5/workflow/cron/controller.go#L124
When running syncAll:
https://github.com/argoproj/argo/blob/1212df4d19dd18045fd0aded7fd1dc5726f7d5c5/workflow/cron/controller.go#L216

I believe that there is a chacne a cron workflow will be scheduled at the same time syncAll is called. When this happens syncAll will pick up a cron workflow from the informer that is identical to the one about to be use to schedule a workflow in Run. Run processes the cron workflow, schedules a new workflow, updates LastScheduledTime to the current time, and patches the cron workflow in the cluster. At the same time, syncAll runs and since it never modifies LastScheduledTime, it patches the cron workflow in the cluster to the previous (and now incorrect) LastScheduledTime. As soon as this happens, the cron workflow controller picks up the most recent cron workflow (patched by SyncAll) and process it. Since it sees that the (incorrect) LastScheduledTime implies an execution was missed, it schedules a new workflow.
The main issue here is that we use patch to update the cron workflow (as changed in https://github.com/argoproj/argo/pull/4294). Since we use patch, there is no code that checks if we are trying to update an object with stale and outdated information.
Why I think this solution may work
Using update instead of patch guarantees that we won't update the cron workflow in the cluster with information that is now stale. Moreover, this approach allows us to run reapplyUpdate to attempt to reconcile the differences if the scenario above does indeed happen.
Moreover, I believe the reservation from #4294 does not apply:

The ResourceVersion checks made the assumption that the corn operation context is used only once. It is wrong, it is used many times - each time Run is invoked.

I believe this is not true. It is true that Run would use the same origCronWf every time Run is called (i.e. every time the cron workflow is scheduled). However, since we create an entirely new context every time the cron workflow object in the cluster is modified (which includes new executions), we can guarantee that origCronWf will always be the most recent version that is present in the cluster.
The only exception to this is when the cron workflow in the cluster was modified while Run was being executed. In which case there is even a stronger argument to using update instead of patch, in order to recognize this has happened.
Why I believe #4294 introduced this bug
From #4294:

This change instead uses Patch to update the cron workflow status. I believe that, unlike for a workflow, this is safe because all the status fields can be patched safely.

For the reasons above, I don't believe this is true.
Would using deterministic workflow names fix this issue?
Maybe in most cases. However, there is an edge case: After the patch is made with stale information and the controller tries to scheduled the "missed" workflow, it will fail because a workflow with that (deterministic) name will already exist. However, it is possible that the original workflow was completed and delete from the cluster in that time, in which case the "missed" workflow will still be scheduled.
Although I believe that using deterministic names is a hacky solution to this problem, I now do believe that we should use them as a whole regardless. To that end I have opened: https://github.com/argoproj/argo/pull/4638
What is holding me back from fully endorsing this solution
I would like to know why #4294 was done originally. I seem to recall a problem with cron workflows and mismatched resourceVersions. If that is the case, I think we should explore fixing that issue with a different approach. I would like @alexec to comment on this

What I don't like about this solution (and to be fair - a complaint about using deterministic names, like CronJob does) is that neither address the underlying issue - we have two code paths that can schedule a workflow.
In fact, using update rather than patch is taking advantage of a side-effect of using update.

@simster7  I would think we should check cronworkflow is already scheduled or not before code is scheduling which will avoid   scheduling same cronworkflow multiple time in any scenario or usecase.
jobCtx, _ :=cc.cron.Load(key.(string))

	if jobCtx == nil {
		err = cc.cron.AddJob(key.(string), cronSchedule, cronWorkflowOperationCtx)
		if err != nil {
			logCtx.WithError(err).Error("could not schedule CronWorkflow")
			return true
		}
	}

I would suggest that before the cronworkflow gets scheduled, it's better to check whether it has already scheduled or not. This will avoid scheduling same cronworkflow multiple times in any scenario or usecase.

This approach does not work, the contexts are ephemeral and the fact that a context exists doesn't mean a job has been scheduled and vice versa

I would suggest that before the cronworkflow gets scheduled, it's better to check whether it has already scheduled or not. This will avoid scheduling same cronworkflow multiple times in any scenario or usecase.

This approach does not work, the contexts are ephemeral and the fact that a context exists doesn't mean a job has been scheduled and vice versa

FYI...
The load function is looking at Entries from cron and if entry is nil or not a context. it will return error
func (f *cronFacade) Load(key string) (*cronWfOperationCtx, error) {
	f.mu.Lock()
	defer f.mu.Unlock()
	entryID, ok := f.entryIDs[key]
	if !ok {
		return nil, fmt.Errorf("entry ID for %s not found", key)
	}
	entry := f.cron.Entry(entryID).Job
	cwoc, ok := entry.(*cronWfOperationCtx)
	if !ok {
		return nil, fmt.Errorf("job entry ID for %s was not a *cronWfOperationCtx, was %v", key, reflect.TypeOf(entry))
	}
	return cwoc, nil
}

Closing in favor of #4659


Wrong filter formatting

Filters are wrongly formatted as they are inconsistent with Twigcs Linter:

Filters are formatted like this:
 {% if (order.getOrderItems | default('') | length > 0) and (productBonusPrice | default('') | length > 0) %}

But should be formatted like this without whitespaces around:
 {% if (order.getOrderItems|default('')|length > 0) and (productBonusPrice|default('')|length > 0) %}

Please, is it possible to fix it?

@jezikk Yeah this is a really annoying limitation with PrettyDiff, the Twig formatter I am using. Technically you are developing the way they specify in the Twig docs but PrettyDiff reformats it with spaces. I can raise the issue with the developer of PrettyDiff and hopefully they can solve your issue.

Thank you for answer. It would be great to have this update. :) Because this is an issue in the PrettyDiff dependency, feel free to close the issue if you want.


Provide sources and non windows instructions for building ApiPort.Core

I was trying to build ApiPort.Core from sources on Linux x64 and I could not find the ApiPort.Core project.
It would also be nice to have some sort of instructions that don't require the use of powershell.
Thank you in advance.

@tioduke Hi, I opened a PR that hopefully addresses your issues. Let me know if you have any more issues.
Cheers,
Connie

Thank you


[V1] Fix EngineArgs refactor on V1

SUMMARY:

propagate EngineConfig refactor to GPUExecutor

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

 PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

[Bugfix] for bug fixes.
[CI/Build] for build or continuous integration improvements.
[Doc] for documentation fixes and improvements.
[Model] for adding a new model or improving an existing model. Model name should appear in the title.
[Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
[Kernel] for changes affecting CUDA kernels or other compute kernels.
[Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
[Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
[Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:

We adhere to Google Python style guide and Google C++ style guide.
Pass all linter checks. Please use format.sh to format your code.
The code need to be well-documented to ensure future contributors can easily understand the code.
Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Adding or changing kernels
Each custom kernel needs a schema and one or more implementations to be registered with PyTorch.

Make sure custom ops are registered following PyTorch guidelines: Custom C++ and CUDA Operators and The Custom Operators Manual
Custom operations that return Tensors require meta-functions. Meta-functions should be implemented and registered in python so that dynamic dims can be handled automatically. See above documents for a description of meta-functions.
Use torch.libary.opcheck() to test the function registration and meta-function for any registered ops.  See tests/kernels for examples.
When changing the C++ signature of an existing op, the schema must be updated to reflect the changes.
If a new custom type is needed, see the following document: Custom Class Support in PT2.

Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

 After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
 After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
 After the review, the reviewer will put an  action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
 Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You
 Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Seems like the engine is broken after this PR?
VLLM_USE_V1=1 vllm serve neuralmagic/Meta-Llama-3-8B-Instruct-FP8

Error message:
Traceback (most recent call last):
  File "/home/ray/anaconda3/bin/vllm", line 5, in <module>
    from vllm.scripts import main
  File "/home/ray/anaconda3/lib/python3.11/site-packages/vllm/__init__.py", line 6, in <module>
    from vllm.entrypoints.llm import LLM
  File "/home/ray/anaconda3/lib/python3.11/site-packages/vllm/entrypoints/llm.py", line 35, in <module>
    from vllm.v1.engine.llm_engine import LLMEngine  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ray/anaconda3/lib/python3.11/site-packages/vllm/v1/engine/llm_engine.py", line 24, in <module>
    from vllm.v1.executor.gpu_executor import GPUExecutor
  File "/home/ray/anaconda3/lib/python3.11/site-packages/vllm/v1/executor/gpu_executor.py", line 4, in <module>
    from vllm.config import EngineConfig
ImportError: cannot import name 'EngineConfig' from 'vllm.config' (/home/ray/anaconda3/lib/python3.11/site-packages/vllm/config.py)

I think its

Seems like the engine is broken after this PR?
VLLM_USE_V1=1 vllm serve neuralmagic/Meta-Llama-3-8B-Instruct-FP8

Error message:
Traceback (most recent call last):
  File "/home/ray/anaconda3/bin/vllm", line 5, in <module>
    from vllm.scripts import main
  File "/home/ray/anaconda3/lib/python3.11/site-packages/vllm/__init__.py", line 6, in <module>
    from vllm.entrypoints.llm import LLM
  File "/home/ray/anaconda3/lib/python3.11/site-packages/vllm/entrypoints/llm.py", line 35, in <module>
    from vllm.v1.engine.llm_engine import LLMEngine  # type: ignore
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ray/anaconda3/lib/python3.11/site-packages/vllm/v1/engine/llm_engine.py", line 24, in <module>
    from vllm.v1.executor.gpu_executor import GPUExecutor
  File "/home/ray/anaconda3/lib/python3.11/site-packages/vllm/v1/executor/gpu_executor.py", line 4, in <module>
    from vllm.config import EngineConfig
ImportError: cannot import name 'EngineConfig' from 'vllm.config' (/home/ray/anaconda3/lib/python3.11/site-packages/vllm/config.py)

I think https://github.com/vllm-project/vllm/pull/9938 is the culpit. I can post something up in a few minutes. Should be trivial fix

@comaniac - https://github.com/vllm-project/vllm/pull/9971


Fixed to handle end of last playbook when no end event (bsc#1083243)

tried it out locally and works fine... won't know about a full QA/QE environment until its in the build


Expose LocalTxSubmissionClient data constructor

Any user of the LocalNodeClientProtocols IPC interface will need to construct this type. Hence it needs to be exported.

Also can you tell me more about your use case that you should need to use LocalTxSubmissionClient directly?

Also can you tell me more about your use case that you should need to use LocalTxSubmissionClient directly?

Of course. In https://github.com/input-output-hk/hydra we are connecting to a local cardano-node to submit transactions using the ouroboros node-to-client protocol. Lately I tried to use the IPCmodule from cardano-api, instead of ouroboros-network-framework and protocols directly.

I pushed a commit to fix the compile error.


Trouble in saving map when i follow Tutorial for Visual SLAM with Isaac Sim

I ran the command that 'ros2 action send_goal /visual_slam/save_map isaac_ros_visual_slam_interfaces/action/SaveMap “{map_url: /home/gaozhao/map}” '.In the terminal,it showed’success: true.However,i could not see the expected map in the target directory ‘home/gaozhao’ or in ‘home/gaozhao/map’.Except for this,anything else seems to go well!
HELP!!!What is the problem?

Looks like you are trying to find the saved map on your host machine instead you should search for the saved map inside the docker container.


add option to pre-load to entire map

add option to pre-load & compress the entire map on load rather than 100% lazily

I don't think this is needed. we are doing it pretty efficiently right now.


Random uncaught exception from mouse event

I start receiving uncaught exceptions after plotting more series on the chart (attached). This happens when I click on the chart to plot something but doesn't always happen. It's hard to reproduce and from the call stack it's not from my code.
Anyone has experienced this before? thanks.

It's strange. It'd be really useful to have reproducing of the problem somehow.

It's strange. It'd be really useful to have reproducing of the problem somehow.

I suspect it's related with overlapping lines. However, I can't seem to reproduce it. Anyway, it doesn't seem to have any impact other than appearing in console log.

@RichieZFX do you have any updates here?

@RichieZFX I'm going to close the issue. If you'll have any question or updates - feel free to re-open it.


mobile: Remove intermediate C wrapper types in the iOS callback implementation

This PR updates the iOS stream callback implementation to remove the need for going through intermediate C wrapper types. This should help to reduce the unnecessary copies.
Risk Level: low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

/assign @abeyad


Feature Request: Add support for patch stashing

I would love to be able to do this so link without having to open up a console window.
Note that it is possible to name the stash if you use this command: git stash save --patch "stash name"

Have you seen inline diff?
https://github.com/divmain/GitSavvy#highlights
https://github.com/divmain/GitSavvy/blob/master/docs/staging.md#git-diff-current-file-inline
It does the same job with a different interface.

I have, and use it all the time. But can you create a stash with it?

No. I have read it wrong. This is a difficult to implement with our current code since out code it make to handle prompts from commands.
Since everything we do in GitSavvy calls git it is hard to replace who git command should work.  There are other command which would have benefit of this change.

Not saying it is impossible but I won't work on it. For now atleast.

Hey @Drllap, this is a feature I've been wanting myself, for awhile now.  I just pushed a commit that may not be exactly what you ask for, but close enough.  There's a new command in the status dashboard: [t][g] create stash of staged changes only.
Go through your normal workflow to stage files - inline diff views should work for this.  When you're ready, press [t][g] in the status dashboard and only the changes you have staged will be added to a stash and removed from your working directory.
It will not work in 100% of cases.  One example where it would fail, is if you stage lines in the middle of a hunk and Git is unable to reverse-apply the patch because necessary context is missing.  In this case, the stash will be present, but the changes will not be removed from the working directory.
I might be able to improve this if I can figure a way to diff two stashed-diffs and generate a diff-diff :) . But this is good enough for me right now.  Let me know how it works for you.

Haven't tested it yet but sounds like it's exactly what I was looking for.
Those corner cases you talk about here it doesn't work sound very minor, especially when one know about them.
Thx a lot for your effort.

Nice one @divmain and thanks for the request @Drllap ! This will improve my workflow significantly since I've just recently started using stashes frequently


config: enable table split by default.

We should wait #2502.

@BusyJay @disksing
If the adjacent empty regions are for different two tables and we ensure the tables are empty, can we merge these regions?

@siddontang We can merge them only if table-split is off.
@BusyJay Why? I don't think it depends on merge.

LGTM
I think we can support table split by default, but we should also need to consider the empty table region problem later.

Do we still need to do this? @disksing

ping @disksing

Of cause need it. PTAL @overvenus

/run-all-tests

LGTM


Update claims value in claims challenge

Claims value provided currently decodes to: {"access_token":{"acrs":{"essential":true,"value":"c1"}}} instead of the expected "value" of cp1.
Base64 encoded claims value should decode to: {"access_token":{"acrs":{"essential":true,"value":"cp1"}}} from the description in the docs further down outlining the contents of the response headers.

@davidmu1
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Possible issue with variant clean up

I had made an error when creating a combo, using one feature as required ("Pay life to deal equal damage") when it should have been another ("Pay life to draw equal cards"). A number of variants were generated from that combo. I corrected the combo and ran the generate variants job. Variants that were created from the erroneous combo now display the new version of the combo in their "of"/"includes" fields. However, these variants are not valid because they do not actually have the feature it now lists as required.
Example - variant 8750

Maybe not a bug. The job failed but I didn't notice.


re-enable ISCSI shared PVC migration tests for k8s provider 1.13.3

/kind bug
When introducing the k8s v1.13.3 provider CI test lane #2266 , it was discovered that our method for performing ISCSI shared PVC migrations fails. In order to get the CI lane integrated, we have temporarily skipped these tests just for the 1.13.3 provider.
We need to investigate why the 1.13.3 lane's ISCSI related tests aren't passing and re-enable these tests.

/cc @vladikr fyi

It's a bit weird.
I see that the pod has a timeout waiting for the volume to be attached.
  Warning  FailedMapVolume         103s (x12 over 9m57s)  kubelet, node02          MapVolume.WaitForAttach failed for volume "test-iscsi-luntxpvzjw2s4qn6h8vrm8l8s8p2sl54ls827n7ftkb4dkbq8v9" : open /sys/class/iscsi_host: no such file or directory
  Warning  FailedMount             81s (x4 over 8m10s)    kubelet, node02          Unable to mount volumes for pod "virt-launcher-testvmidlwslw2n9r2t4qp44p9zv9mkbf26g825xzzz5z5lft_kubevirt-test-default(d056caff-7590-11e9-9a76-525500d15501)": timeout expired waiting for volumes to attach or mount for pod "kubevirt-test-default"/"virt-launcher-testvmidlwslw2n9r2t4qp44p9zv9mkbf26g825xzzz5z5lft". list of unmounted volumes=[disk0]. list of unattached volumes=[disk0 infra-ready-mount virt-share-dir libvirt-runtime ephemeral-disks]

but kube-controller shows that the volume has been attached:

I0513 15:07:25.371899       1 reconciler.go:289] attacherDetacher.AttachVolume started for volume "test-iscsi-luntxpvzjw2s4qn6h8vrm8l8s8p2sl54ls827n7ftkb4dkbq8v9" (UniqueName: "kubernetes.io/iscsi/<IP_ADDRESS>:iq
n.2018-01.io.kubevirt:wrapper:1") from node "node02"
I0513 15:07:25.372040       1 operation_generator.go:339] AttachVolume.Attach succeeded for volume "test-iscsi-luntxpvzjw2s4qn6h8vrm8l8s8p2sl54ls827n7ftkb4dkbq8v9" (UniqueName: "kubernetes.io/iscsi/<IP_ADDRESS>:i
qn.2018-01.io.kubevirt:wrapper:1") from node "node02"
I0513 15:07:25.372096       1 event.go:221] Event(v1.ObjectReference{Kind:"Pod", Namespace:"kubevirt-test-default", Name:"virt-launcher-testvmidlwslw2n9r2t4qp44p9zv9mkbf26g825xzzz5z5lft", UID:"d056caff-7590-11e9
-9a76-525500d15501", APIVersion:"v1", ResourceVersion:"4825", FieldPath:""}): type: 'Normal' reason: 'SuccessfulAttachVolume' AttachVolume.Attach succeeded for volume "test-iscsi-luntxpvzjw2s4qn6h8vrm8l8s8p2sl54
ls827n7ftkb4dkbq8v9"

@j-griffith  John, could you please help me understand what should I look for when debugging this?

looks like it's related to https://github.com/kubernetes/kubernetes/pull/74787

@vladikr @davidvossel I think this is fixed and we can enable https://github.com/kubevirt/kubevirt/blob/master/tests/migration_test.go#L728, right?


Fetching data on the server, or SSR in other words

I get why SRR is low on the prioritization list seing you guys have other features to bake first, but I'm wondering where it is in your pipeline and what your initial thoughts are for implementing it.
And how can we help?

Its #1 on the todo https://github.com/FormidableLabs/urql#todo
Right now I'm trying to stabilize the API and shake out some introductory bugs. Past that, I would assume there will be a two pass render, where we walk the tree, identify queries, execute and cache them, and then serialize the cache. Then add a hydration helper on the client side. Does that sound about right?

Sounds about right! Would be cool if we could also control how and which queries should be executed on the server vs client, and option to resolve the queries using your schema directly if the SSR is served from the same server has your GraphQL endpoint. Would be rad 🥇.

Did this ever get implemented? I don't see any references to SSR anymore.

@chrischen Not yet unfortunately! We haven't found a way yet to traverse a React element tree and extract pending requests with hooks.

Here's an implementation from graphql-react.
https://github.com/jaydenseric/graphql-react/blob/master/src/server/ssr.mjs https://github.com/jaydenseric/graphql-react/blob/master/src/server/ssr.mjs

On Feb 26, 2019, at 7:40 PM, Phil Plückthun<EMAIL_ADDRESS>wrote:
@chrischen https://github.com/chrischen Not yet unfortunately! We haven't found a way yet to traverse a React element tree and extract pending requests with hooks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/FormidableLabs/urql/issues/36#issuecomment-467406080, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGsPlH2ZuPZI8L9zR-jldhUEc82RDBwks5vRR0ogaJpZM4R4_g0.

@chrischen yea, I've dabbled with getDataFromTree implementations before, but I'm put off by the newer approaches of repeatedly rendering to static markup and waiting for a promises / operations array to come back empty