Libs(all): bump openapi generator from 5.2.0 to 7.9.0

With the existing generator versions, we've had issues during codegen for certain cases in the svix spec including:

serialization of nullable fields
enum (oneOf, anyOf) representations

Bumping the generators all the way up to the latest version (at time of writing, 7.9.0) seems to resolve both of these, at least partially.
Some refactoring of extant template overrides has been required to "re-seat" our local patches on top of the newer templates.
There have also been cases of the generated symbol names using slightly different schemes than in earlier generator versions. The high-level API had to be updated to use the new names.
Approach
Customization to the codegen comes in 2 flavors:

edits to templates.
manual edits where the codegen is checked-in to git and the paths are recorded in an .openapi-generator-ignore file.

Templates are better because they don't hide the customization as readily, but we've got a mix of these approaches throughout.
At a high-level, this change followed the following steps:

replace templates entirely with the version tagged for 7.9.0.
recreate our local patches on top as a single rev.
leave behind any customization made moot by upstream refactors.
try to remove as many manual edits/ignores by migrating into templates where needed or just omitting the change entirely.
add a light/gentle test to check specific behaviors things we had hacks in place for:

nullable containers (ie. Endpoint channels and filter types).
responses with empty bodies.

In addition to doing the "upstream merge" on template sources, I also had to sometimes look at the dependencies a lib depends on, upgrading or changing the package manifest, or build tooling.
When refering/comparing to the upstream templates:

https://github.com/OpenAPITools/openapi-generator/blob/v7.9.0/modules/openapi-generator/src/main/resources/ (the new generator version tag)
https://github.com/OpenAPITools/openapi-generator/blob/v5.2.0/modules/openapi-generator/src/main/resources/ (the older one)

Status
Each lib came with its own challenges. Some I have higher or lower confidence in.
I'll call out the ones that are weaker so reviewers can give more scrutiny.
Ruby: I wasn't able to get my local ruby setup in a healthy enough state to follow along with the readme instructions for building/testing.
This one needs a so-called "kitchen sink" test like I added to the other libs, and may need some dependencies bumped. Normally the dep updates required become known during testing.
Edit: setting BUNDLE_PATH=$HOME/.gems unblocked me. Apparently bundle install tries to put stuff on the "system" level by default (i.e. requiring sudo, and not really what I wanted anyway). With this, I was able to learn enough Ruby to get a test written, and also verify that the deps are lined up as needed. Ruby seems to be in good shape!
Python: This was the last lib I worked on, and I ran out of time. The "kitchen sink" test looks good, and we also have a decent set of tests that give me okay confidence but here's where I cut corners. I left the templates, manual edits, dependencies and the rest all as-is in the hopes that the boon of the tests will surface problems that stem from all the surrounding code being updated around this stuff that stays where it is.
The tests are passing, so maybe we're good, but we should loop back and try to do proper updates to this one.
C#: manual edits for nullability were left in place for now. A "kitchen sink" test was written, but has also been reverted because however I wrote it ended up using language features not supported by dotnet 5.0 (which our CI process is targeting).
The tests pass locally when I update the solution to target 8.0, so I feel good about the lib generally. I was not able to figure out how to install dotnet 5.0 on my system since it's beyond End of Life. We should look to update our target to a currently supported dotnet like 8.0, at which point we can un-revert the test!
Kotlin: had to update the version of kotlin we build with, but other than that I think things look good. There's a fixme in the ApiClient template about updating the retry loop to work for 2 flavors of request sending; I'd like to look at that in a follow-up, later.
The rest all seemed okay and not very concerning to me.
Notes for Reviewers
I can offer 2 bits of advice when reviewing this chungus of a diff.

I split this into many commits and it may be helpful to review one by one.
Many files such as the templates themselves may be easier to read if you "ignore whitespace" (at your discretion).

It would be good if someone knowledgeable in Ruby could actually build the package and add a similar "kitchen sink" test before this merges, but I don't know if @svix-gabriel is willing to dive into this rabbit hole with me. Please and thank you, Gabriel!
Good luck!

Superlinter seems like it sprung some new lints on me today, which had to be addressed by updating our prettier version to match.
Re-requested review now that the whitespace stuff has been resolved and also I got the ruby lib verified. I think this is good to go, unless more whitespace/formatting things pop out.


Window groups is stacked on top of each other if you move a window into it

create 3 windows
make the left/right two windows a group
move the right window left(or opposite)
enjoy your confusion
the right window is stacked on top of the two left windows while not being in the group

yeah groups need to be redone

check with c319a2aba9cf993d26af7af66a8632aad6a83d1b
redone groups

it's sorta fixed, the specific way that I described in this issue is in fact fixed.
Managed to reproduce it like this.

make the left top two groups, drag the bottom one into the top group, close the right window, and there you go

fixado in 214c2c7b1c0182594a07a2c5ac7d99e9d7b5fcb3 he he ha ha


[Bug]: Created AUTOCUT issues does not honor windows failure

Describe the bug
Notice the following screenshots, even though the build failed for windows with error
Error building OpenSearch-Dashboards, retry with: ./build.sh manifests/3.0.0/opensearch-dashboards-3.0.0.yml --component OpenSearch-Dashboards
subprocess.CalledProcessError: Command 'bash C:\Users\Administrator\jenkins\workspace\distribution-build-opensearch-dashboards\scripts\components\OpenSearch-Dashboards\build.sh -v 3.0.0 -p windows -a x64 -d zip -s false -o builds' returned non-zero exit status 1.

It still says Component OpenSearch-Dashboards passed, closing github issue

To reproduce
Here is the build failure log.
https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch-dashboards/detail/distribution-build-opensearch-dashboards/7008/pipeline/76/
Expected behavior
No response
Screenshots
If applicable, add screenshots to help explain your problem.
Host / Environment
No response
Additional context
No response
Relevant log output
No response

[Triage] Need to check logic for windows issue creation for OpenSearch-Dashboards

@prudhvigodithi @gaiksaya Is this happening for each run?

The issue is coming from here.
In the example mentioned above only windows stage failed due to permission issues, the rest passed successfully. Since the post stage process logs from all the stages it was able to find Successfully built string for OSD from other stages and closed the issue.
Till we stabilize windows env better we exclude windows platform from all the post process scripts.
@gaiksaya @prudhvigodithi


Save method and trim stack doesn't replace top of stack

Saving a method in a debugger works and appears to correctly trim the stack. However, press step afterwards and it's obvious things aren't working. Pretty sure the problem is that the new method isn't put on the top of the stack so the debugger sets the single step breakpoint in the wrong method.
Not sure what the solution is yet.

Disabled feature for now


ToSchema doesn't support slices

This fails with a compiler error:
#[derive(Serialize, ToSchema)]
#[serde(rename_all = "camelCase")]
pub struct Foo<'a> {
    pub arr: &'a [i64],
}

Unfortunately, value_type doesn't help
#[derive(Serialize, ToSchema)]
#[serde(rename_all = "camelCase")]
pub struct Foo<'a> {
    #[schema(value_type = Vec<i64>)]
    pub arr: &'a [i64],
}

Apparently because the default TypeTree is always evaluated, and only then replaced by the TypeTree from value_type.
I added Type::Slice(array) => Self::get_type_paths(&array.elem), to the match and it seems to work fine.

As for the value_type not helping, this fixes it: https://github.com/nkovacs/utoipa/commit/c4280adebfcb92eb0ad079c9d3aff8c627f51356
Although I'm not sure why the generic stuff only runs on the default type tree? Maybe that's also a bug and it should work on the value_type as well.

That might be a bug, I need to check this out too, after I finnish one thing I am in middle of. It might well be that the slice's are not taken in account as the should.

Although I'm not sure why the generic stuff only runs on the default type tree? Maybe that's also a bug and it should work on the value_type as well.

True, good point. :thinking:  Most probably the generic and aliaces check should also happen from the override type as well.
The value_type with Vec<i64> works because it will choose the Group or Array type from the match statements if I am not mistaken. I belive it is legit to add the support for Type::Slice(...) as well to the match statement.

This is indeed bug, I'll try to fix this asap. Normally there should be no need to add #[schema(value_type = ...)] for slice or array fields a they should be recoginized by default as array types in OpenAPI.

Thanks!


Fixed an issue with static allocation of Tasks

When declaring cstring pointer arrays, the string length should be specified to
prevent memory issues or hard fault errors.
Added a nullptr check to Delete() and RemoveTask() to allow tasks to be removed
even if the scheduler has not been started.

Codecov Report

Merging #212 into master will decrease coverage by 0.1%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
- Coverage   87.36%   87.26%   -0.11%
==========================================
  Files          42       42
  Lines        1844     1845       +1
==========================================
- Hits         1611     1610       -1
- Misses        233      235       +2

Impacted Files
Coverage Δ

...are/library/L4_Application/task_scheduler_test.cpp
100% <ø> (ø)
:arrow_up:

firmware/library/L4_Application/task_scheduler.cpp
64.58% <66.66%> (-0.64%)
:arrow_down:

firmware/library/L2_Utilities/rtos.cpp
36.36% <0%> (-9.1%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd84ea...4f98424. Read the comment docs.

Coverage remained the same at 90.579% when pulling fb7e0062ef4b1294f25c239f4806f3495756b638 on HuangDave:task_scheduler into fa2ab1f805603cf5f17f12d5a2f6d0ccb59a63ee on kammce:master.


Characteristic.TargetHeaterCoolerState has incorrect constants values

At the moment constants are
Characteristic.TargetHeaterCoolerState.AUTO = 0;
Characteristic.TargetHeaterCoolerState.HEAT = 1;
Characteristic.TargetHeaterCoolerState.COOL = 2;

But iOS10 send 3 when AUTO mode is on and 0 when DISABLED.

Are you sure you are looking at the right characteristic? For thermostat it's "TargetHeatingCoolingState"
Characteristic.TargetHeatingCoolingState.OFF = 0;
Characteristic.TargetHeatingCoolingState.HEAT = 1;
Characteristic.TargetHeatingCoolingState.COOL = 2;
Characteristic.TargetHeatingCoolingState.AUTO = 3;

Well, looks you are right. Thanks for your hint.


Fix buffer capacity off by one error

I was looking to implement a UART input buffer as a RingBuffer, and I ran into a surprising panic while stress testing the driver.
Here's a minimal reproduction of the panic:
use heapless::RingBuffer;

let mut test: RingBuffer<u8, [u8; 2]> = RingBuffer::new();

println!("Capacity = {}", test.capacity());

test.enqueue(1);
test.enqueue(2);

test.dequeue().expect("Expected data");
test.dequeue().expect("Expected data");
test.dequeue().expect("This is expected to panic");

The problem is that the capacity() method returns one less than it should.  The fix is pretty simple.
-        buffer.len() - 1
+        buffer.len()

Error
Capacity = 1

PANIC in [snip]
    Expected data

Here's the output with fix
Capacity = 2

PANIC in [snip]
    This is expected to panic

Ring buffer should always have one empty slot to function properly. So there is no error here.

I'll close the PR since there's no error.
Is this behavior an implementation detail?  It'd be more intuitive if the API abstracted away the implementation details.
From a user perspective, it was a surprise when I tried to create a RingBuffer<u8> of size n and the buffer only supported n-1 elements.
I see that the documentation for new() says the following

Creates an empty ring buffer with capacity equals to the length of the array A minus one.

But it doesn't really explain why the buffer is created with lower capacity.  It'd also be helpful to have more documentation regarding the usage of the RingBuffer.
I can create a separate tracking issue if these are valid requirements.

Yes, it is implementation detail, but I don't know a good way to abstract it, unless Rust gets const generics.
It is easy to explain why the buffer needs one empty slot, just consider the following sequence of events:

First we start with an empty buffer:

0  1  2  3
+--+--+--+--+    head = 2
|__|__|__|__|    tail = 2
+--+--+--+--+
      ^
      H
      T

head is index where we have a first cell with data, tail is index where we have first empty slot. On enqueue() we increment tail, on dequeue() we increment head.

Then we start pushing some data into the buffer:

+--+--+--+--+    head = 2
|__|__|XX|__|    tail = 3
+--+--+--+--+
      ^  ^
      H  T

+--+--+--+--+    head = 2
|__|__|XX|XX|    tail = 0
+--+--+--+--+
^     ^
T     H

+--+--+--+--+    head = 2
|XX|__|XX|XX|    tail = 1
+--+--+--+--+
   ^  ^
   T  H

Now we have only one empty cell and we continue pushing data:

+--+--+--+--+    head = 2
|XX|XX|XX|XX|    tail = 2
+--+--+--+--+
      ^
      H
      T

As you can see we arrived at the same spot where we started (head = 2, tail = 2). So there is no way to distinguish an empty buffer from a completely full buffer. To solve this ambiguity we forbid filling the buffer completely, and decide that if head == tail the buffer is empty.
It is possible to solve this problem by introducing a third variable, but such design would not be concurrent, since both enqueue() and dequeue() would need to write to this common variable, causing data races, unless you introduce locks (which is expensive).

Thanks for the explanation!  The problem is now more clear.

It is possible to solve this problem by introducing a third variable, but such design would not be concurrent, because both enqueue() and dequeue() would need to write to this common variable, causing data races, unless you introduce locks (which is expensive).

This was the piece I was missing.  I wondered why there wasn't a third counting variable used. It sounds like a tradeoff between usability and performance, and this library prioritizes performance due to its use cases.  Until const generics are implemented, this problem will remain.
A note in the documentation describing what you posted above would be helpful for newbies like me 😃


Modeler: Input/Output versus Output Only models

Input/Output types use constructors and have public setters for properties
Output Only types have internal/private constructor, use an internal factory method for construction, and have internal/private setters on properties

Done.


Goreleaser setup for kpt

This sets up cloudbuild to use goreleaser to create relases. Just like before, it will only run whenever a new tag is pushed with a semver format.
It will create proper github releases and attach release notes. It will upload the binaries as part of the release, but will no longer upload the binaries to GCS. The images are still being generated in the same way as before.
@seans3 @phanimarupaka @jijiew

@mortent How did you test this ?

I did the full setup with Cloud Build on my branch of kpt and created releases there. An example release: https://github.com/mortent/kpt/releases/tag/v0.0.24

/lgtm


Feature Request: vegeta should be able to take multiple payloads to attack on same url.

For Example: vegeta attack -targets=targets.txt -body=payload.json -rate=2 -duration=2s
targets.txt:
POST http://localhost:3000/user/profile
Content-Type: application.json

payload.json:
{
   “id": 12,
   "name": “john"
},
{
   “id”:13,
   “name”: “doe"
},
{
   “id”:14,
   “name”: “alice"
},
{
   “id”:15,
   “name”: “bob"
}

So for every attack it should take new payload specified in the payload.json file
(payload.json file contains multiple payloads(comma separated))

this wont be of much help.
what if I need each request to pickup different payloads. ?

what if I need each request to pickup different payloads. ?

The you generate a different body for each target you produce as input.

I think i got it. sorry for the confusion.. i was thinking one attack means one api and one payload ran for n number of times


ReactiveHttpRequestInterceptors missing update/remove headers feature for updating AUTHORIZATION access token value

I have added an Interceptor which appends access token for every request.
@Bean   public ReactiveHttpRequestInterceptor apiKeyInterceptor() {     return ReactiveHttpRequestInterceptors.addHeader(         HttpHeaders.AUTHORIZATION, String.format("%s %s", BEARER.getValue(), getAccessToken()));   }
If a request fails due to any error, the circuit breaker tries to retry the request. While retrying, it reinitialises the bean which calls ReactiveHttpRequestInterceptors.addHeader. Since this method is static, the header values keep on duplicating for every retry.
I also need to update the interceptor AUTHORIZATION header for new token.
As ReactiveHttpRequestInterceptors class does not provide any method to remove/update headers, I am stuck with this problem
Any thoughts ?
Thanks :)

@guravamey how did you resolve this issue? I am also having similar scenario


Badge added

I added badges: ^1.1.0 to communicate informations to the user from an item.
One can now also edit badge color, badge selected color and badge text color.

Hey @Te-Z , sorry for the delay on this one ... before diving in to review, is this available as capability for all flutter mobile platforms (i.e. iOS and Android) and any version limitations?


[kobo] porting progress

i'm trying to port this to kobo libra (hurrah!), but i'm only seeing a black box where the game usually is. do you have any debugging tips?
https://imgur.com/a/VmHYQOI is what i'm seeing.
what i've done:

i'm using the kobo branch of rmkit (under development)
i added -static and -static-libstdc++ flags to the Makefile (kobo has incompatible versions of libstdc++ and libm)
i updated all references in fb->width and fb->height to refer to fb->stride, fb->display_width and fb->display_height
i compiled with -DKOBO (instead of -DREMARKABLE).
i copied over config/ and icons/ to /opt/etc/puzzles/ config, i made /opt/etc/puzzles/save. ~~i can see all of the UI elements, just not the actual game play area. ~~
if i click in the game play area, the UI does update (for example, i would see "balls marked 1/5" in black box) but i only see a black area where the ST puzzles output should be

i have a feeling i may have messed up something in rmkit.h in the kobo branch, so i will explore that possibility, too

it seems to work now - not sure what i changed in rmkit.h to fix but i'm excited!

some screenshots from kobo libra h20:

Makefile adjustments to get it working: (using kobo branch of rmkit-dev/rmkit). No changes necessary to remarkable_puzzles code, although I haven't been able to generate the icons myself yet (likely due to me breaking rmkit.h's FileFB or VirtualFB somehow for the icon generating use case)
diff --git a/Makefile b/Makefile
index b0367e4..d207df4 100644
--- a/Makefile
+++ b/Makefile
@@ -29,7 +29,7 @@ resim: default

 #### rmkit
-RMKIT_FLAGS = -D"REMARKABLE=1" \
+RMKIT_FLAGS = -D"KOBO=1" -D"RMKIT_IMPLEMENTATION" \
 	-pthread -lpthread

 $(BUILD_DIR)/rmkit.h:
@@ -55,6 +55,7 @@ INCLUDES  = -I./ -Isrc/ -Ivendor/inih -Ivendor/puzzles
 INCLUDES += -isystem $(BUILD_DIR)/

 CXXFLAGS  = -Wall $(INCLUDES) $(RMKIT_FLAGS) $(BUILD_FLAGS)
+CXXFLAGS += -static -static-libstdc++ -static-libgcc
 CXXFLAGS += -fdata-sections -ffunction-sections -Wl,--gc-sections
 CXXFLAGS += -D'RMP_COMPILE_DATE="$(RMP_COMPILE_DATE)"'
 ifneq ($(strip $(RMP_VERSION)),)

Cool!! Happy to take a patch to add those flags only for kobo (or well, I assume -D"RMKIT_IMPLEMENTATION" is the new way to do things across the board?)

yeah, -DRMKIT_IMPLEMENTATION is required for builds now (i'm slowly trying to make it possible to include rmkit.h from multiple .h files like a normal cpp project). -DREMARKABLE and -DKOBO are for (rm1, rm2) and (kobo libra) respectively. i haven't merged kobo branch into master yet, still auditing and improving things before i squash it in. i'll ping when i merge into master
i figured out why the icons weren't building: i had to scp save/* over to /opt/etc/puzzle-icons/ and now i can run the icon building binary successfully. so all's well :-D i did notice that unruly doesn't have a save file, though (and causes a crash, it seems)


BB-73 Tailscale: Pull in roles

Description

[ ] Bug fix

[ ] New feature

Cleaning up ci tests

I'm guessing the PR title isn't correct, as this is bigquery, not tailscale. :)


[Docenhancement][Update what's new][1843610]

Updated file. Please review.

Docs Build status updates of commit c1f85e5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


elastic fails to start after stopping and starting a minikube cluster: AccessDeniedException[/usr/share/elasticsearch/data/nodes]

Chart version:
7.7.0
Kubernetes version:
1.18.0
Kubernetes provider: E.g. GKE (Google Kubernetes Engine)
Minikube
Helm Version:
3.2.0
helm get release output
e.g. helm get elasticsearch (replace elasticsearch with the name of your helm release)

Output of helm get release
NAME: elasticsearch
LAST DEPLOYED: Thu May 28 09:34:00 2020
NAMESPACE: elastic
STATUS: deployed
REVISION: 1
USER-SUPPLIED VALUES:
antiAffinity: soft
discovery:
  type: single-node
esJavaOpts: -Xmx256m -Xms256m
replicas: 1
resources:
  limits:
    cpu: 500m
    memory: 2Gi
  requests:
    cpu: 200m
    memory: 1Gi
volumeClaimTemplate:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
  storageClassName: standard

COMPUTED VALUES:
antiAffinity: soft
antiAffinityTopologyKey: kubernetes.io/hostname
clusterHealthCheckParams: wait_for_status=green&timeout=1s
clusterName: elasticsearch
discovery:
  type: single-node
envFrom: []
esConfig: {}
esJavaOpts: -Xmx256m -Xms256m
esMajorVersion: ""
extraContainers: []
extraEnvs: []
extraInitContainers: []
extraVolumeMounts: []
extraVolumes: []
fsGroup: ""
fullnameOverride: ""
httpPort: 9200
image: docker.elastic.co/elasticsearch/elasticsearch
imagePullPolicy: IfNotPresent
imagePullSecrets: []
imageTag: 7.7.0
ingress:
  annotations: {}
  enabled: false
  hosts:
  - chart-example.local
  path: /
  tls: []
initResources: {}
keystore: []
labels: {}
lifecycle: {}
masterService: ""
masterTerminationFix: false
maxUnavailable: 1
minimumMasterNodes: 2
nameOverride: ""
networkHost: <IP_ADDRESS>
nodeAffinity: {}
nodeGroup: master
nodeSelector: {}
persistence:
  annotations: {}
  enabled: true
podAnnotations: {}
podManagementPolicy: Parallel
podSecurityContext:
  fsGroup: 1000
  runAsUser: 1000
podSecurityPolicy:
  create: false
  name: ""
  spec:
    fsGroup:
      rule: RunAsAny
    privileged: true
    runAsUser:
      rule: RunAsAny
    seLinux:
      rule: RunAsAny
    supplementalGroups:
      rule: RunAsAny
    volumes:
    - secret
    - configMap
    - persistentVolumeClaim
priorityClassName: ""
protocol: http
rbac:
  create: false
  serviceAccountName: ""
readinessProbe:
  failureThreshold: 3
  initialDelaySeconds: 10
  periodSeconds: 10
  successThreshold: 3
  timeoutSeconds: 5
replicas: 1
resources:
  limits:
    cpu: 500m
    memory: 2Gi
  requests:
    cpu: 200m
    memory: 1Gi
roles:
  data: "true"
  ingest: "true"
  master: "true"
schedulerName: ""
secretMounts: []
securityContext:
  capabilities:
    drop:
    - ALL
  runAsNonRoot: true
  runAsUser: 1000
service:
  annotations: {}
  httpPortName: http
  labels: {}
  labelsHeadless: {}
  loadBalancerIP: ""
  loadBalancerSourceRanges: []
  nodePort: ""
  transportPortName: transport
  type: ClusterIP
sidecarResources: {}
sysctlInitContainer:
  enabled: true
sysctlVmMaxMapCount: 262144
terminationGracePeriod: 120
tolerations: []
transportPort: 9300
updateStrategy: RollingUpdate
volumeClaimTemplate:
  accessModes:
  - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
  storageClassName: standard

HOOKS:
---
# Source: elasticsearch/templates/test/test-elasticsearch-health.yaml
apiVersion: v1
kind: Pod
metadata:
  name: "elasticsearch-keujh-test"
  annotations:
    "helm.sh/hook": test-success
spec:
  securityContext:
    fsGroup: 1000
    runAsUser: 1000
  containers:
  - name: "elasticsearch-qtwlw-test"
    image: "docker.elastic.co/elasticsearch/elasticsearch:7.7.0"
    command:
      - "sh"
      - "-c"
      - |
        #!/usr/bin/env bash -e
        curl -XGET --fail 'elasticsearch-master:9200/_cluster/health?wait_for_status=green&timeout=1s'
  restartPolicy: Never
MANIFEST:
---
# Source: elasticsearch/templates/poddisruptionbudget.yaml
apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
  name: "elasticsearch-master-pdb"
spec:
  maxUnavailable: 1
  selector:
    matchLabels:
      app: "elasticsearch-master"
---
# Source: elasticsearch/templates/service.yaml
kind: Service
apiVersion: v1
metadata:
  name: elasticsearch-master
  labels:
    heritage: "Helm"
    release: "elasticsearch"
    chart: "elasticsearch"
    app: "elasticsearch-master"
  annotations:
    {}
spec:
  type: ClusterIP
  selector:
    heritage: "Helm"
    release: "elasticsearch"
    chart: "elasticsearch"
    app: "elasticsearch-master"
  ports:
  - name: http
    protocol: TCP
    port: 9200
  - name: transport
    protocol: TCP
    port: 9300
---
# Source: elasticsearch/templates/service.yaml
kind: Service
apiVersion: v1
metadata:
  name: elasticsearch-master-headless
  labels:
    heritage: "Helm"
    release: "elasticsearch"
    chart: "elasticsearch"
    app: "elasticsearch-master"
  annotations:
    service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"
spec:
  clusterIP: None # This is needed for statefulset hostnames like elasticsearch-0 to resolve
  # Create endpoints also if the related pod isn't ready
  publishNotReadyAddresses: true
  selector:
    app: "elasticsearch-master"
  ports:
  - name: http
    port: 9200
  - name: transport
    port: 9300
---
# Source: elasticsearch/templates/statefulset.yaml
apiVersion: apps/v1
kind: StatefulSet
metadata:
  name: elasticsearch-master
  labels:
    heritage: "Helm"
    release: "elasticsearch"
    chart: "elasticsearch"
    app: "elasticsearch-master"
  annotations:
    esMajorVersion: "7"
spec:
  serviceName: elasticsearch-master-headless
  selector:
    matchLabels:
      app: "elasticsearch-master"
  replicas: 1
  podManagementPolicy: Parallel
  updateStrategy:
    type: RollingUpdate
  volumeClaimTemplates:
  - metadata:
      name: elasticsearch-master
    spec:
      accessModes:
      - ReadWriteOnce
      resources:
        requests:
          storage: 1Gi
      storageClassName: standard
  template:
    metadata:
      name: "elasticsearch-master"
      labels:
        heritage: "Helm"
        release: "elasticsearch"
        chart: "elasticsearch"
        app: "elasticsearch-master"
      annotations:

    spec:
      securityContext:
        fsGroup: 1000
        runAsUser: 1000
      affinity:
        podAntiAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
          - weight: 1
            podAffinityTerm:
              topologyKey: kubernetes.io/hostname
              labelSelector:
                matchExpressions:
                - key: app
                  operator: In
                  values:
                  - "elasticsearch-master"
      terminationGracePeriodSeconds: 120
      volumes:
      initContainers:
      - name: configure-sysctl
        securityContext:
          runAsUser: 0
          privileged: true
        image: "docker.elastic.co/elasticsearch/elasticsearch:7.7.0"
        imagePullPolicy: "IfNotPresent"
        command: ["sysctl", "-w", "vm.max_map_count=262144"]
        resources:
          {}

      containers:
      - name: "elasticsearch"
        securityContext:
          capabilities:
            drop:
            - ALL
          runAsNonRoot: true
          runAsUser: 1000
        image: "docker.elastic.co/elasticsearch/elasticsearch:7.7.0"
        imagePullPolicy: "IfNotPresent"
        readinessProbe:
          exec:
            command:
              - sh
              - -c
              - |
                #!/usr/bin/env bash -e
                # If the node is starting up wait for the cluster to be ready (request params: 'wait_for_status=green&timeout=1s' )
                # Once it has started only check that the node itself is responding
                START_FILE=/tmp/.es_start_file

                if [ -n "${ELASTIC_USERNAME}" ] && [ -n "${ELASTIC_PASSWORD}" ]; then
                  BASIC_AUTH="-u ${ELASTIC_USERNAME}:${ELASTIC_PASSWORD}"
                else
                  BASIC_AUTH=''
                fi

                if [ -f "${START_FILE}" ]; then
                  echo 'Elasticsearch is already running, lets check the node is healthy'
                  HTTP_CODE=$(curl -XGET -s -k ${BASIC_AUTH} -o /dev/null -w '%{http_code}' http://<IP_ADDRESS>:9200/)
                  RC=$?
                  if [[ ${RC} -ne 0 ]]; then
                    echo "curl -XGET -s -k \${BASIC_AUTH} -o /dev/null -w '%{http_code}' http://<IP_ADDRESS>:9200/ failed with RC ${RC}"
                    exit ${RC}
                  fi
                  # ready if HTTP code 200, 503 is tolerable if ES version is 6.x
                  if [[ ${HTTP_CODE} == "200" ]]; then
                    exit 0
                  elif [[ ${HTTP_CODE} == "503" && "7" == "6" ]]; then
                    exit 0
                  else
                    echo "curl -XGET -s -k \${BASIC_AUTH} -o /dev/null -w '%{http_code}' http://<IP_ADDRESS>:9200/ failed with HTTP code ${HTTP_CODE}"
                    exit 1
                  fi

                else
                  echo 'Waiting for elasticsearch cluster to become ready (request params: "wait_for_status=green&timeout=1s" )'
                  if curl -XGET -s -k --fail ${BASIC_AUTH} http://<IP_ADDRESS>:9200/_cluster/health?wait_for_status=green&timeout=1s ; then
                    touch ${START_FILE}
                    exit 0
                  else
                    echo 'Cluster is not yet ready (request params: "wait_for_status=green&timeout=1s" )'
                    exit 1
                  fi
                fi
          failureThreshold: 3
          initialDelaySeconds: 10
          periodSeconds: 10
          successThreshold: 3
          timeoutSeconds: 5
        ports:
        - name: http
          containerPort: 9200
        - name: transport
          containerPort: 9300
        resources:
          limits:
            cpu: 500m
            memory: 2Gi
          requests:
            cpu: 200m
            memory: 1Gi
        env:
          - name: node.name
            valueFrom:
              fieldRef:
                fieldPath: metadata.name
          - name: cluster.initial_master_nodes
            value: "elasticsearch-master-0,"
          - name: discovery.seed_hosts
            value: "elasticsearch-master-headless"
          - name: cluster.name
            value: "elasticsearch"
          - name: network.host
            value: "<IP_ADDRESS>"
          - name: ES_JAVA_OPTS
            value: "-Xmx256m -Xms256m"
          - name: node.data
            value: "true"
          - name: node.ingest
            value: "true"
          - name: node.master
            value: "true"
        volumeMounts:
          - name: "elasticsearch-master"
            mountPath: /usr/share/elasticsearch/data

Describe the bug:
When a minikube cluster is shut down due to minikube stop, elastic fails to load upon restarting the cluster with minikube start. Deleting and redeploying the helm chart does not fix the issue, the volume must be deleted and entirely recreated, losing all data. The following error is displayed:
{"type": "server", "timestamp": "2020-05-28T13:41:49,351Z", "level": "ERROR", "component": "o.e.b.ElasticsearchUncaughtExceptionHandler", "cluster.name": "elasticsearch", "node.name": "elasticsearch-master-0", "message": "uncaught exception in thread [main]",
"stacktrace": ["org.elasticsearch.bootstrap.StartupException: ElasticsearchException[failed to bind service]; nested: AccessDeniedException[/usr/share/elasticsearch/data/nodes];",
"at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:174) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:161) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:86) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:127) ~[elasticsearch-cli-7.7.0.jar:7.7.0]",
"at org.elasticsearch.cli.Command.main(Command.java:90) ~[elasticsearch-cli-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:126) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:92) ~[elasticsearch-7.7.0.jar:7.7.0]",
"Caused by: org.elasticsearch.ElasticsearchException: failed to bind service",
"at org.elasticsearch.node.Node.<init>(Node.java:638) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.node.Node.<init>(Node.java:264) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:227) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:227) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:393) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:170) ~[elasticsearch-7.7.0.jar:7.7.0]",
"... 6 more",
"Caused by: java.nio.file.AccessDeniedException: /usr/share/elasticsearch/data/nodes",
"at sun.nio.fs.UnixException.translateToIOException(UnixException.java:90) ~[?:?]",
"at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) ~[?:?]",
"at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116) ~[?:?]",
"at sun.nio.fs.UnixFileSystemProvider.createDirectory(UnixFileSystemProvider.java:389) ~[?:?]",
"at java.nio.file.Files.createDirectory(Files.java:694) ~[?:?]",
"at java.nio.file.Files.createAndCheckIsDirectory(Files.java:801) ~[?:?]",
"at java.nio.file.Files.createDirectories(Files.java:787) ~[?:?]",
"at org.elasticsearch.env.NodeEnvironment.lambda$new$0(NodeEnvironment.java:274) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.env.NodeEnvironment$NodeLock.<init>(NodeEnvironment.java:211) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.env.NodeEnvironment.<init>(NodeEnvironment.java:271) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.node.Node.<init>(Node.java:284) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.node.Node.<init>(Node.java:264) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:227) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:227) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:393) ~[elasticsearch-7.7.0.jar:7.7.0]",
"at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:170) ~[elasticsearch-7.7.0.jar:7.7.0]",
"... 6 more"] }
uncaught exception in thread [main]
ElasticsearchException[failed to bind service]; nested: AccessDeniedException[/usr/share/elasticsearch/data/nodes];
Likely root cause: java.nio.file.AccessDeniedException: /usr/share/elasticsearch/data/nodes
	at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:90)
	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116)
	at java.base/sun.nio.fs.UnixFileSystemProvider.createDirectory(UnixFileSystemProvider.java:389)
	at java.base/java.nio.file.Files.createDirectory(Files.java:694)
	at java.base/java.nio.file.Files.createAndCheckIsDirectory(Files.java:801)
	at java.base/java.nio.file.Files.createDirectories(Files.java:787)
	at org.elasticsearch.env.NodeEnvironment.lambda$new$0(NodeEnvironment.java:274)
	at org.elasticsearch.env.NodeEnvironment$NodeLock.<init>(NodeEnvironment.java:211)
	at org.elasticsearch.env.NodeEnvironment.<init>(NodeEnvironment.java:271)
	at org.elasticsearch.node.Node.<init>(Node.java:284)
	at org.elasticsearch.node.Node.<init>(Node.java:264)
	at org.elasticsearch.bootstrap.Bootstrap$5.<init>(Bootstrap.java:227)
	at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:227)
	at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:393)
	at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:170)
	at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:161)
	at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:86)
	at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:127)
	at org.elasticsearch.cli.Command.main(Command.java:90)
	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:126)
	at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:92)
For complete error details, refer to the log at /usr/share/elasticsearch/logs/elasticsearch.log

Steps to reproduce:

Install the helm chart and see elastic is running successfully
minikube stop
minikube start

Expected behavior:
elastic should successfully start up.
Provide logs and/or server output (if relevant):
Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting

Any additional context:

@brandoncollins7 have you tried the work-around suggested in https://github.com/elastic/helm-charts/issues/429#issuecomment-571969666?

Looks like this did help, thank you! But the question is, why is this happening?

@brandoncollins7 as per the linked issue, there is a bug in kind that is causing issues with volume permissions.
As the workaround has solved your problem I'm going to close this issue out.
Feel free to open a new issue or post on https://discuss.elastic.co if you have any more questions.

I'm a bit newer to kube, what is "kind"? The post says the fix was merged last December and I am on the latest version of minikube and kubernetes, what do I need to update to get the fix?

Hi @brandoncollins7, FYI https://kind.sigs.k8s.io/ is alight  alternative to minikube to run a local K8S inside a Docker container.
Do you still have the same error?
It seems this issue was closed by mistake as you are using minikube and not kind.
I'll reopen it.

Thanks, yes the error is very easily reproducible and basically made using this on minikube impossible as it constantly needs to be reset every time I reboot my machine or have it in sleep for a while. Luckily I set up my staging environment on aws and have been using it there instead.

Hi @brandoncollins7, it seems this is the standard behavior of Minikube.
I could reproduce is with Elasticsearch chart but also using a simple Nginx StatefulSet:
$ cat << EOF > nginx.yaml
apiVersion: v1
kind: Service
metadata:
  name: nginx
  labels:
    app: nginx
spec:
  ports:
  - port: 80
    name: web
  clusterIP: None
  selector:
    app: nginx
---
apiVersion: apps/v1
kind: StatefulSet
metadata:
  name: web
spec:
  selector:
    matchLabels:
      app: nginx
  serviceName: "nginx"
  replicas: 1
  template:
    metadata:
      labels:
        app: nginx
    spec:
      terminationGracePeriodSeconds: 10
      containers:
      - name: nginx
        image: k8s.gcr.io/nginx-slim:0.8
        ports:
        - containerPort: 80
          name: web
        volumeMounts:
        - name: www
          mountPath: /usr/share/nginx/html
  volumeClaimTemplates:
  - metadata:
      name: www
    spec:
      accessModes: [ "ReadWriteOnce" ]
      storageClassName: standard
      resources:
        requests:
          storage: 1Gi
EOF
$ kubectl apply -f nginx.yaml
service/nginx created
statefulset.apps/web created

# Create a file in the persistent storage
$ kubectl exec web-0 -- bash -c "hostname > /usr/share/nginx/html/index.html"

# Check that file is present in the persistent storage
$ kubectl exec web-0 -- ls /usr/share/nginx/html
index.html
$ kubectl exec web-0 -- cat /usr/share/nginx/html/index.html
web-0

# Check that the file is still present after pod recreation
$ kubectl delete pod web-0
pod "web-0" deleted
$ kubectl get pod
NAME    READY   STATUS    RESTARTS   AGE
web-0   1/1     Running   0          10s
$ kubectl exec web-0 -- ls /usr/share/nginx/html
index.html
$ kubectl exec web-0 -- cat /usr/share/nginx/html/index.html
web-0

# Restart Minikube
$ minikube stop && minikube start
✋  Stopping "minikube" in docker ...
🛑  Powering off "minikube" via SSH ...
🛑  Node "minikube" stopped.
😄  minikube v1.12.0 on Darwin 10.15.5
✨  Using the docker driver based on existing profile
👍  Starting control plane node minikube in cluster minikube
🔄  Restarting existing docker container for "minikube" ...
🐳  Preparing Kubernetes v1.18.3 on Docker 19.03.2 ...
🔎  Verifying Kubernetes components...
🌟  Enabled addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

# Check if file is still present in persistent storage after Minikube restart
$ kubectl exec web-0 -- ls /usr/share/nginx/html
$ kubectl exec web-0 -- cat /usr/share/nginx/html/index.html
cat: /usr/share/nginx/html/index.html: No such file or directory
command terminated with exit code 1

Regarding Minikube Persistent Volumes doc, it seems that Minikube VM only persist storage for hostPath and some specific directories which don't seem compatible with StatefulSet VolumeClaimTemplates.

One workaround with single node Elasticsearch (replicas: 1) could be to disable VolumeClaimTemplates and add an extraVolume:
persistence:
  enabled: false
extraVolumes:
- name: data
  hostPath:
    path: /data/pv0001/
extraVolumeMounts:
- name: data
  mountPath: /usr/share/elasticsearch/data
extraInitContainers: |
   - name: create
     image: busybox:1.28
     command: ['mkdir', '-p', '/usr/share/elasticsearch/data/nodes/']
     securityContext:
       runAsUser: 0
     volumeMounts:
      - mountPath: /usr/share/elasticsearch/data
        name: data
   - name: file-permissions
     image: busybox:1.28
     command: ['chown', '-R', '1000:1000', '/usr/share/elasticsearch/']
     securityContext:
        runAsUser: 0
     volumeMounts:
      - mountPath: /usr/share/elasticsearch/data
        name: data

Similar to https://github.com/elastic/helm-charts/issues/644#issuecomment-659375988
apiVersion: apps/v1
kind: Deployment
...
spec:
  ...
  template:
    ...
    spec:
      initContainers:
        - name: permissions-fix
          image: busybox
          volumeMounts:
            - name: data
              mountPath: /usr/share/elasticsearch/data
          command: [ 'chown' ]
          args: [ '1000:1000', '/usr/share/elasticsearch/data' ]
      containers:
        - name: elastic
          image: docker.elastic.co/elasticsearch/elasticsearch:7.10.2
          ...
          volumeMounts:
            - name: data
              mountPath: /usr/share/elasticsearch/data
      volumes:
        - name: data
          persistentVolumeClaim:
            claimName: my-app-elastic-pv-claim


Added jump on click, fixed setting expmode (hopefully), reorganised g…

seems we're almost there, but when  log is set in properties, you can't set it to any other non log value, either linear or exp... it stays locked in 'log' mode.
I can try and check it myself tomorrow or later

Thanks to your comments on the tcltk code I was able to change a few things including the order of colors, really appreciate it :) thanks!

fixed the issue where it was locked on log mode, it was on the C side, thanks again for all your help! Looks like we're finally done!

not really done because we still need to fix the non jump on click behaviour in circular mode :( last thing on the list...

In circular mode the knob jumps to your mouse position but it should not, unless in jump on click mode

Do you think you can take care of this? I'm pretty busy for the rest of this week, and I'm not good at mouse behaviour and gui_vmess stuff in Pd.

the main issue is the trigonometry math, I did not do the original thing and dont think I could do it... I have tried a few things to see if it would do it and it didnt... the mouse and vmess stuff is not the issue. I made it not jump but the mouse motion was kinda crazy and not really as I expected

I can keep trying though but I'm also done for the week

I think I fixed it, but please check :)


Update README.md

Azure Cosmos DB is not included in readme for supported semantic kernel vector stores (under extensions), but it is supported: https://learn.microsoft.com/en-us/semantic-kernel/concepts/vector-store-connectors/out-of-the-box-connectors/azure-cosmosdb-nosql-connector?pivots=programming-language-csharp

Hi @TheovanKraay - Kernel Memory doesn’t use Semantic Kernel's memory/vector connectors because they lack advanced features like filtering. The connectors here are based on SK but add that functionality.
While SK supports various storage engines (SQLite, Chroma, Pinecone, Weaviate, etc.), without advanced filtering they can’t be used for Kernel Memory.
We could consider adding Cosmos DB support, but my recommendation is to extend SK's vector store filtering capabilities so we can avoid duplicate code and support more storage types right away.


hide show comments

sometimes hide/show-comments help reading the code, visual studio has extensions for this, failed to find similar ones in vscode, hope we will get one some day.

Was just looking for this myself.  Need to do a complex formula (for me) in google sheets but they don't allow comments inside formulas so was looking for a way to temporarily hide them so I could copy the bare code and paste it vs manually deleting things.

I also found myself looking for a way to hide all comments to help read the code.
Sublime has this
[https://forum.sublimetext.com/t/how-to-hide-comments/3836/10]
Visual Studio had this
[(https://marketplace.visualstudio.com/items?itemName=3dGrabber.HideShowComments)]
Would be great for someone to create an extension or build this functionality into vs code.

I'm looking for this feature as well, any extension?

Me too!

Count me in.

me too... I am looking for a tool for that, especially when you deal with backend codes where is tons of comments lines and will wast a lot of time to see all of the real code you searching for!

+1

Me too!

+1

+1

For block comments see: https://github.com/Microsoft/vscode/issues/11524.
vscode: CTRL + SHIFT + P and type Fold All Block Comments

This command doesn't work on js comments

But it does work with block comments, and the 'shortcut' is CTRL + K CTRL + /. I do agree we need something for regular comments as well.

2019 any good news??

Looking for this too

I'm willing to code this is someone can help me bootstrap a solution or offer an idea on how to do this.  I'm sure I can do it I just don't even know where to start.  I hate comments but I see their inherent value, thus why I want to show/hide them on demand.

I'm willing to code this is someone can help me bootstrap a solution or offer an idea on how to do this. I'm sure I can do it I just don't even know where to start. I hate comments but I see their inherent value, thus why I want to show/hide them on demand.

I think you can have a look at ths api : https://code.visualstudio.com/updates/v1_23#_folding-provider-api
There's an old extension here : https://marketplace.visualstudio.com/items?itemName=marvinhagemeister.foldallcomments
I've checked it and it's not working. Maybe fixing it can be a start for you.

There's an old extension here : https://marketplace.visualstudio.com/items?itemName=marvinhagemeister.foldallcomments
I've checked it and it's not working. Maybe fixing it can be a start for you.

Interestingly the github repo for this is non existent. Not sure how I would go about finding the old source code for this, but that's probably why it isn't working haha

There's an old extension here : https://marketplace.visualstudio.com/items?itemName=marvinhagemeister.foldallcomments
I've checked it and it's not working. Maybe fixing it can be a start for you.

Interestingly the github repo for this is non existent. Not sure how I would go about finding the old source code for this, but that's probably why it isn't working haha

Try installing it. Maybe you could find those files in the vsix file.

I'm willing to code this is someone can help me bootstrap a solution or offer an idea on how to do this. I'm sure I can do it I just don't even know where to start. I hate comments but I see their inherent value, thus why I want to show/hide them on demand.

In some other thread someone mentions just making the comment theme opacity zero.
Another hacking way would be trying to do something with Regex, storing comments (and locations) in a different location (and thus deleting them from the OG file)...., but that sounds like a really crude solution

So that extension works. It's a command you have to run through vscode. ctrl + shift + p and search fold all comments.   I really like how he did it and I'm going to attempt to refactor some of the code a release a repo seeing as how he removed the code from github.

So that extension works kind of. It's a command you have to run through vscode. ctrl + shift + p and search fold all comments.  I really like how he did it and I'm going to attempt to refactor some of the code to make it work a little better. It seems like it only works half of the time and not in any large files with a lot of code.

It wasn't working for me (maybe it's due to vscode version or something). command error was popping up. Let me know when you have a working development version of it.

It seems to only be folding the last comment in a document.  Trying to rewrite the code to fold all the comments now.  I've been sick for like a week so this should help pass some time.

is it must be a regular expression, no?

I can create a repo and share it here if anyone wants to help.  I'm not entirely sure how to develop extensions and test them in VSCode so that has been an impediment for me.
@mylastnameisboyko Yes there are some regular expressions in the code that help identify comments.

@forrestblade please create a repo. Maybe i could help. I have done a getting started section of vscode extension, so I'm too a newbie here..

I work from a PixelBook and I recently powerwashed without thinking.  So this is the repo with the code as is.  None of my changes are here.  If you wish to contribute to the extension please adhere to https://seesparkbox.com/foundry/semantic_commit_messages as best as possible!
https://github.com/forrestblade/fold-comments

Ok will check and let you know about the progress.

I am just here for the updates because I need this functionality badly. I'm surprised it's not baked into all editors by default.

option to hide comments by default would be extremely helpful, especially these extremely long on top of the file with copyright,license notices...

Looking for the same. need a tool to hide the multiple-single line comments.

+1

+1

+1

Will 2020 be the year we get show/hide comments feature in VS Code?!

+1

UP

+1

+1

+1


Fix overflow in c2i_ASN1_BIT_STRING.

c2i_ASN1_BIT_STRING takes length as a long but uses it as an int.  Check
bounds before doing so. Previously, excessively large inputs to the
function could write a single byte outside the target buffer. (This is
unreachable as asn1_ex_c2i already uses int for the length.)
Thanks to NCC for finding this issue. Fix written by Martin Kreichgauer.

Approval goes for backporting to 1.1.0 and 1.0.2 if that's appropriate

Merged to master, 1.1.0 and 1.0.2. Thanks!


Is there a way to add custom blade directives for autocompletion?

Is there a way to add custom blade directives for autocompletion?
Many Laravel packages come with their own directives, is there a setting to add these directives to autocomplete?
Thanks in advance

It's not yet implemented, but I think it can be developed like a project option where paths to php files with custom directives are added.

that would be great 👍

custom directive file configuration - here you can add a php file where you define the new directive. So far just the name autocomplete is available. No declaration link feature or parameter hint is available.

Where is that??

Hi sorry for the late answer. I didn't have time to work on the plugin for some while and I noticed the custom directiveautocomplete flow was buggy
The Option for custom directive file path is in Project Properties

After adding the file to the list, on the blade template autocomplete process you should have the hint for custom directives names.
The method directive from such a service file can be static or direct.

@haidubogdan amazing, thank you, works great
Maybe it is not possible, but what about this idea
Files with custom directives always are inside project root path, so, we can use relative paths instead of absolute paths
Now, what if instead of saving in private.properties it save it in project.properties, so it could be on the repository tree,
everyone with the plugin could use custom directives autocompletion automatically


Xcode gives me errors, parse issue, "expected a type", "unknown type name 'UICollectionView Layout'"...

Project was created using Xcode 6, Deployment Target 8.0.

I tried create a new project using xcode 4.6.3, I worked fine. But when I imported those files to my xcode 6  project, it gives me errors. Does anybody know why?

cause xcode6 don't create pch file ,so you need to import <UIKit/UIkit.h>


Add Setting color interaction states (Filled, Hover, Active), wire for ExternalLink and ValueInput Settings

Introduces the Filled, Hover and Active states for Settings. Will introduce the rest of the states in follow-ups.
light

Filled
Hover
Active

dark

Filled
Hover
Active

Based on #240

It has been just merged. Rebase?

updated from bb997ec to 970c66f, compare
changes: rebased over master

cc @johnny9


Unable to identify any set of controllers that can actuate the specified joints. And moveit_simple_controller_manager error

Thanks for your work on this repo! It took a bit of work to get it working but it definitely deserves more stars. Now my last problems are to do with interfacing with moveit and making the robot execute a plan.
I have two separate problems when I run the
roslaunch dorna_moveit_config dorna_real_planning_execution.launch
with dorna_ros.launch running in another terminal
on startup:
Exception while loading controller manager 'moveit_simple_controller_manager/MoveItSimpleControllerManager': According to the loaded plugin descriptions the class moveit_simple_controller_manager/MoveItSimpleControllerManager with base class type moveit_controller_manager::MoveItControllerManager does not exist. Declared types are  moveit_fake_controller_manager/MoveItFakeControllerManager

and when I try to execute a moveit plan I get:
[ERROR] [1599421076.426918178]: Known controllers and their joints:

[ERROR] [1599421076.426958169]: Apparently trajectory initialization failed```

Should I be running a separate file?

Hello,
Thanks for your kind words. I am just seeing this issue now.
The moveit interface never directly connected to Dorna so I built a very hacky bridge to do the message passing between them. Sometimes there are warnings/errors that will show up, but will still work.
But based on the message it seems you may be running the wrong launch file or more likely there is a bug in the launch file.
I will try to take a look at this soon and fix this repository that has not got enough attention :-(


Fix disk full error during flashing

Tracked-On: OAM-105154
Signed-off-by: blackdobb<EMAIL_ADDRESS>

Close this since it has been merged within:
https://github.com/projectceladon/vm_manager/pull/270/commits/7013260975903c3b35e2856fdfc77ad31a07d71e


feat(gha): add codeql

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


dusting the project off and checking dependencies

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8086f3a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master     #5   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      3
  Lines             ?     51
  Branches          ?      0
=======================================
  Hits              ?     51
  Misses            ?      0
  Partials          ?      0

Impacted Files
Coverage Δ

src/lib/topmark.js
100% <ø> (ø)

src/lib/exists-sync.js
100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8086f3a...d0a809e. Read the comment docs.


Fix documentation links in aws-smithy-http-server

The links to dependencies in aws-smithy-http-server are broken in docs.rs.
Shorthand links seems to work in some areas (HeaderMap) but not others (tower::Layer).
Investigate why, fix this, and ensure that CI detects it in the future.

Could you please clarify this issue in more detailed?

Could you please clarify this issue in more detailed?

Somewhere between smithy-rs 0.49 and 0.50 some of the documentation links stopped being generated correctly. You can see this change here to here. The issue asks why did this happen? How can we fix it? How can we prevent it happening again?


Build task GetJavaPlatformJar occasionally fails to set JavaPlatformJarPath, causing later tasks to fail

Android framework version
net9.0-android
Affected platform version
9.0.100-preview.7.24407.12
Description
Occasionally when I have my MAUI project open in Visual Studio, I see this error in the error list:
MSB4044: The "GenerateRtxt" task was not given a value for the required parameter "JavaPlatformJarPath"
I took a look at the .binlog file, and I see that the problem is that the GetJavaPlatformJar task that runs earlier is failing to set the JavaPlatformJarPath property.

Steps to Reproduce

File -> New Project -> MAUI Application
Open error list
Build, or just wait, occasionally you'll see this error:

MSB4044: The "GenerateRtxt" task was not given a value for the required parameter "JavaPlatformJarPath"
Did you find any workaround?
Rebuilding or reopening the project sometimes works
Relevant log output
No response

@MSLukeWest do you have the binlog file which contains the error?

MauiApp7_Debug_AnyCPU_net9.0-android_DesignTimeBuild_2024-09-04T13_54_37.3636355-07_00.binlog.txt
@dellis1972 - I've attached the binlog.  I had to rename it to a .txt file because .binlog can't be attached.

A guess to what's happening is:

API 35 is not installed
<GetJavaPlatformJar/> does not appear to log errors or abort the build during a $(DesignTimeBuild); it can't find android.jar for API 35
<GenerateRtxt/> has [Required] and so we get an error

@MSLukeWest can you confirm, you don't have this installed?

A guess to what's happening is:

API 35 is not installed
<GetJavaPlatformJar/> does not appear to log errors or abort the build during a $(DesignTimeBuild); it can't find android.jar for API 35
<GenerateRtxt/> has [Required] public string JavaPlatformJarPath, and so we get an error

@MSLukeWest can you confirm, you don't have this installed?

@jonathanpeppers - I checked, and I do have this installed now.  However, I can tell by the timestamps of the folders in "Program Files (x86)\Android\android-sdk\platforms\android-35" that it wasn't installed until 1 minute after I got this error.

I was able to reproduce in an integration test.
And we can fix the error message above:

https://github.com/dotnet/android/pull/9288

But it still fails later during <Csc/> with:
UnnamedProject\MainActivity.cs(15,29): error CS0117: 'Resource' does not contain a definition for 'Layout'
UnnamedProject\MainActivity.cs(17,48): error CS0117: 'Resource' does not contain a definition for 'Id'

It wasn't able to generate Resource.designer.cs without the android.jar platform jar, and so the build would still fail.


Document de-duping pull/push combo workflow triggers

Tell end users how to use both push and pull_request triggers without firing both events at the same time.
jobs:
  job_name:
    if: (github.event_name != 'pull_request' && ! github.event.pull_request.head.repo.fork) || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork)

https://github.com/IHaskell/IHaskell/blob/60a750f5b038a17717609d8a40be0fafd69e1c35/.github/workflows/stack.yml#L37

Also maybe do this to ALKiln. It could make a good example. Is there a reason to test the event happening at the same time?


The project does not build with VS2015, and has a lifetime issue

solved in pull request 78

Closed per changes in #78


[9.x] Add validation for object

This pull request adds support for validating objects using the validator.

Could be if the input is JSON with no associative array and you receive the following:
{
	"myStringField": "string",
	"myIntegerField": 1234,
	"myFloatField": 1.234,
	"myArrayField": [],
	"myObjectField": {},
}

I had this problem once, when receiving such data and I had to explicitly check on being an (empty) object. Maybe this validator isn't used by many, but it seems reasonable to me to have this function available for the ones that need it.


New Release?

Any chance a new release can be cut with the recent 3.12 bugs fixed?

Yep sorry! Going out now but I promise I will do it tomorrow :)

No worries :D take your time! Just wanted to track it 😄

Released!
So I did not keep my promise, but as consolation there are a few new features as well as some new sections in the docs :grin:


Remove _NIOBeta

Motivation:
Having deprecated the NIOBeta entrypoints in #2300, we can now safely remove it.
Modifications:
Remove all source files in _NIOBeta
Remove the _NIOBeta product and target
Result:
We're ready for 5.8 work!

Don't forget<EMAIL_ADDRESS>

Beat you to it :wink:


HSEARCH-1886 Master indexing nodes fail to lookup lazily initialized IndexManager instances

This PR is based on #1357 (HSEARCH-2662 & others), which will have to be merged first.
https://hibernate.atlassian.net/browse/HSEARCH-1886
So, let's be honest: that one was hard. Really. And it's only the beginning.
I didn't follow the suggestion in the ticket (initialize all the indexes at boot time), because this is dynamic sharding, so even if we initialize something at boot time, ultimately there will be a new shard and we'll end up with the exact same issue.
There is a good deal of changes, but each of them was necessary for one reason or another. The comments in the commits should be self-explanatory; if not, please ask.
To sum up:

The first three commits solve one issue: the fact that index managers were not lazily created/updated when a shard appeared on a slave first (only the sharding strategy on the slave was aware of the change, so the master never created the index manager). I suspect that we'll still have issues with other slaves not being aware of the shard addition, but hey, maybe that's worth another ticket :)
The following commits solve the other issues: the fact that message consumers on the master node are not started until an index manager (shard) is actually created. So if a slave happened to create a shard first, its messages were simply ignored...

Note: I just rebased this on #1357, since one commit was already present on that other PR (the fix about queries on dynamically sharded indexes that don't have any shard yet).

 I'll send a PR to fix that first.

I sent a PR to fix the random test failures (#1369) and rebased this PR on the other. The build should be a bit more stable now.

Rebased on master following the merging of #1369.

Why do you say that the validation on consistent Similarity is useless?
It can be configured in many ways - some are legacy - and we had several cases in which people would get themselves into trouble (before introducing this check).
Commits like 5dd7f80 should best be handled in separate PRs, so that it doesn't slow down / distract from the issue we're supposed to solve.

Why do you say that the validation on consistent Similarity is useless?
It can be configured in many ways - some are legacy - and we had several cases in which people would get themselves into trouble (before introducing this check).

I only see two ways to configure it (see createSimilarity): the index-level configuration, and the default configuration. Since entities are not taken into account when retrieving the Similarity (only the index and the more global SearchConfiguration), I don't see how we could have two entities in the same index with a different Similarity... ?
Maybe there was a legacy way to configure similarity, and it got removed?

Commits like 5dd7f80 should best be handled in separate PRs, so that it doesn't slow down / distract from the issue we're supposed to solve.

Hey, this PR depended on two other fixes, which I did address in separate PRs, so I don't always put irrelevant commits in my PRs :) I'll try to be more careful though.

Jenkins, retest this please

Jenkins, retest this please

About the similarity: you're right, sorry I got confused. There were several other options with a focus on the entity, but like you suggested they have been removed already. I remembered deprecating them but forgot we got rid of them.

It's taking me a long time to wrap my head around the changes, but I like it so far. Reminiscent of various things that I wished to do in the past but it never was a good time in terms of branch maintenance.
On the kind of Dispatchers: I'm not seeing any specific problem, but remember that there's more going on than simple "streams of changes" and "transactional changes".
We need to keep in mind also that in different circumstances there are strong expectations about ordering of fired events: order needs to be strictly maintained even in "async mode", which means we can't just delegate to a parallel executor at any stage.
To the contrary when doing batch rebuilding (MassIndexer) the strict ordering is a burden which prevents fast index rebuilds. However even in that case, there are some operations which need to be kept in order:

the purgeAll before the MassIndexer runs need to happen strictly before the subsequent tasks
any final optimisation needs to happen after the last (less critical but still desirable)

Finally we need to allow for the "transactional operations" and MassIndexer operations to happen concurrently: say the MassIndexer is processing, and in parallel some database changes are performed. Our listeners will have to stack up the events fired from the transactional changes making sure that their relative order is maintained, and also that they overwrite any in-flight work from the mass-indexer.
In the past it seems I had a clear picture in mind of the backend design, as it was simple enough to reason about this and see that it was correct. I can no longer load the whole picture in mind by simply reading the source code, so I think we should eventually add some tests at least to ensure the ordering properties.
Adding such tests is unrelated with this PR but I felt like sharing the concern already as this new design is making some subtle changes in the area.

About the dispatchers, to be honest I just moved some code around so I could reuse it someplace else :) I didn't intend to make any change to work orchestration.> To the contrary when doing batch rebuilding (MassIndexer) the strict ordering is a burden which prevents fast index rebuilds. However even in that case, there are some operations which need to be kept in order:
But I agree work orchestration is quite complex, and thus might need some (more?) tests.

To the contrary when doing batch rebuilding (MassIndexer) the strict ordering is a burden which prevents fast index rebuilds. However even in that case, there are some operations which need to be kept in order:

It seems to me that such "synchronisations" in the work stream are what @gustavonalle added recently, with org.hibernate.search.backend.impl.batch.DefaultBatchBackend.awaitAsyncProcessingCompletion(). After sending a purgeAll command, we would call this method, and so would we before final optimizations.

great work, I've merged it. I applied two additional trivial commits.


containerlab: 0.57.1 -> 0.57.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/srl-labs/containerlab/releases.
meta.description for containerlab is: Container-based networking lab
meta.homepage for containerlab is: https://containerlab.dev/
meta.changelog for containerlab is: https://github.com/srl-labs/containerlab/releases/tag/v0.57.3
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.57.3 with grep in /nix/store/wkisialf1s6bk10ycp5c1rhvjsaqh88z-containerlab-0.57.3
found 0.57.3 in filename of file in /nix/store/wkisialf1s6bk10ycp5c1rhvjsaqh88z-containerlab-0.57.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

containerlab

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wkisialf1s6bk10ycp5c1rhvjsaqh88z-containerlab-0.57.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A containerlab https://github.com/r-ryantm/nixpkgs/archive/8637cb0249201b3071971c973d44ce2fea380efa.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8637cb0249201b3071971c973d44ce2fea380efa#containerlab

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wkisialf1s6bk10ycp5c1rhvjsaqh88z-containerlab-0.57.3
ls -la /nix/store/wkisialf1s6bk10ycp5c1rhvjsaqh88z-containerlab-0.57.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

containerlab

Maintainer pings
cc @aaronjheng for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


Suggestion: Android 10 Easter egg match with device theme

In The official Android 10 Easter egg. If you have a dark mode then the Easter egg will be in dark mode and if your theme is light the Android Easter egg will be in light mode. But in this app it will always be in light mode no matter if your phone is dark or not
It's not a bug, it's just a suggestion

Thank you for your suggestions. The next version will be repaired

Cool! Thank you for taking my suggestion


Change == operator to .equals()

This provides optional future functionality allowing the .equals() to be overridden.

Interesting change. Could you please give a practical example on a use case for this? I am really curious

Though the equality operator '==' compares equality of two expressions i.e. EqualityExpression == RelationalExpression. The '==' operator cannot be overridden. The .equals() function provides Object equality and can be overridden. This allows for optional future functionality with less code change without compromising the current behavior.
Granted this is an optional change rather than a necessary change.

But you can't override equals for a primitive value, which is the case, right? long timesAnimationViewed, long currentDuration


Auto linter

We have a "linter" task set up which checks for some minor code style things in the javascript and markdown files. Both of those tools have an "auto-fix" mode, which attempts to automatically fix as many things as possible (some require human intervention).
This PR lets you easily run them both in that mode by running:
npm run lint:fix

In addition, for any Pull Requests opened on GitHub, GitHub will run the linters in that mode, and then will push any fixes. It will still alert you if there are any remaining issues which couldn’t be fixed automatically.

:heart: this! Not sure we’ve got linting on the main GOV.UK Design History, repo, otherwise I’d suggest adding this to that project too. Maybe we can add to the Apply and Find prototypes?

Not sure we’ve got linting on the main GOV.UK Design History, repo, otherwise I’d suggest adding this to that project too.
Don't think I even know about that project. Where is it?

Maybe we can add to the Apply and Find prototypes?
👍

The one downside is that if your git habit is to continually rebase your local branch and force push, you might get conflicts. (Personally I consider force-pushing bad practice, but everyone has a different view on this).


[Enhancment] A better completion box formatter

I suggest you use the "onsails/lspkind.nvim". It allows you to see the source of each completion which would have allowed you to avoid #1.
Get the plugin here
Here's my config of it for reference

Yup, i mean that's up to preference I am just a huge fan of square brackets as special text

okay i did that then!


Fatal Exception: java.util.concurrent.RejectedExecutionException

I am using okhttp 3.8.0 and getting a lot crashes in crashlytics with this stacktrace

Fatal Exception: java.util.concurrent.RejectedExecutionException: Task d.bh@33f4a51 rejected from java.util.concurrent.ThreadPoolExecutor@63d82b6[Shutting down, pool size = 5, active threads = 5, queued tasks = 0, completed tasks = 22]
       at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2049)
       at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:814)
       at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1360)
       at okhttp3.Dispatcher.promoteCalls(Dispatcher.java:164)
       at okhttp3.Dispatcher.finished(Dispatcher.java:200)
       at okhttp3.Dispatcher.finished(Dispatcher.java:187)
       at okhttp3.RealCall$AsyncCall.execute(RealCall.java:151)
       at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
       at java.lang.Thread.run(Thread.java:762)

What colud be the reason of this ?

You called shutdown on the dispatcher’s ExecutorService while it still had calls outstanding.

Maybe we should handle this error and call Callback.onFailure() with a cancelation? That would be pretty reasonable.

Fixed with https://github.com/square/okhttp/pull/4365


[Suggestion] Take Photo not working in Android 11

Hi, although, you've mentioned in the related issues and closed them that this issue has already been fixed, it's incomplete as you've not provided instructions or even mentioned in the ReadMe or Pub.dev package page that the Provider will need to be set-up in the Android manifest file.
Hence, I had to find the solution when I saw this error in a toast returned by the WebView.

So, this is the solution just in case anybody else faces the same issue:
First, Copy the following code in AndroidManifest.xml in android/Main under the <application> tag
<provider
   android:name="androidx.core.content.FileProvider"
   android:authorities="${applicationId}.fileprovider"
   android:exported="false"
   android:grantUriPermissions="true">
   <meta-data
       android:name="android.support.FILE_PROVIDER_PATHS"
       android:resource="@xml/provider_paths" />
</provider>

(You can replace ${applicationId} above to your package id ex: com.app.name in case it doesn't work)
Then, create the xml folder in res and create a file named: provider_paths.xml and then copy paste the code:
<?xml version="1.0" encoding="utf-8"?>
<paths xmlns:android="http://schemas.android.com/apk/res/android">
    <external-path
        name="external_files"
        path="." />
</paths>

After setting this up, Take photo will start working.

Thank you for your suggestion, which has been added to the document FAQ.md and RADEME#Gateway#FAQ


suggest: offline private key signature capability

Provide offline private key signature capability,
Avoid the uncertainty of hosting private keys in the cloud servers.

edwardt said: The intention is to have session signing keys on the validator, while the derivation of those session keys will be done elsewhere.
My preference would be for the session keys to be derived from child signing keys (which are online) rather than the parent signing key (which I think could be offline). I think that would work, at least.

Yeah - this is likely to be middleware and addressed at a later stage. For now, there is simply a facility to alter the keys once per session to something else by signing a transaction with the validator key.


WIP: grid connection set inheritance in derived model fault throw scaling functions

This change is needed to allow later processing steps to work with the grid connection set(s) after scaling of fault throws.

Codecov Report

Merging #57 (d97e565) into master (03c8a39) will increase coverage by 0.07%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   34.75%   34.82%   +0.07%
==========================================
  Files          48       48
  Lines       21617    21644      +27
==========================================
+ Hits         7512     7538      +26
- Misses      14105    14106       +1

Impacted Files
Coverage Δ

resqpy/derived_model.py
19.34% <96.42%> (+1.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c8a39...d97e565. Read the comment docs.


404 for cover image in post 4 of the tutorial

Post 4 of the tutorial series contains an image of the earth seen from the space.
The image url is https://astro.build/assets/hero_NkT0b.avif, but that will lead to 404.
I suppose the intended image is available here?

Fixed in #2382


Trying to fix init at root wp level

Ticket: #991 and #979
Reviewer: @jarednova
Issue

If you include Timber at root level it will throw a fatal error as wordpress is not available at that point and we make use of wordpress functions.
Solution

Defer setup until WP is available, we defer by calling the init function on each compile method, if the new constant TIMBER_LOADED is not defined.
Impact

We will see, early days on this one.
Usage

No change
Considerations

I tried to make this as small of a change as possible to achieve the desired result and we should keep that in mind if we need to develop it further.
Testing

No tests included

Coverage decreased (-6.3%) to 81.718% when pulling ae91c17962137a82dc003504964696dcbf0afa78 on cjb-autoload-root into db73813aced7b9a8480459529cc53122c4128ebb on master.

Coverage increased (+0.004%) to 88.033% when pulling ae91c17962137a82dc003504964696dcbf0afa78 on cjb-autoload-root into db73813aced7b9a8480459529cc53122c4128ebb on master.

Coverage increased (+0.004%) to 87.749% when pulling b9f31a1fee458c8cb2431e6047f3d81dbb1f61b8 on cjb-autoload-root into<PHONE_NUMBER>64418fb8f812972e913aadf856f819 on master.

Just fixed the Travis bug in master — with that clear I'll take a look at this guy today!

Coverage increased (+0.004%) to 88.033% when pulling ef883a21089f432594eac8ef9cadf5fea526b69c on cjb-autoload-root into 85018117c95bf84c33118addb58a90d8751c863f on master.

Coverage decreased (-0.05%) to 87.977% when pulling 3ebb41aabb6d6842e83bc91304fdcc1e431378c3 on cjb-autoload-root into 85018117c95bf84c33118addb58a90d8751c863f on master.

We're looking good! I made some stylistic tweaks, but otherwise I like the approach of "touch as little as possible". As picked-up by the Coveralls warning, there's no test coverage yet. Given that this is an active bug, I'm still going to merge but something we should circle-back on at some point


Update NixOS Python guidance

Following clarifying comments in https://github.com/ros/rosdistro/pull/38539#issuecomment-1718489729

@lopsided98 @hacker1024 @kjeremy for awareness/review

Looks good to me.


use same xds types every where

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
3cd9e441e3885e8e52a703c99dd0c29d21e86225
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


This video shows selecting  a program

Yet I couldn't find any page under the access review docs that explained what the "Access Review Programs" are and their significance.  Other than the video on this page in passing selects this option without much elaboration. https://youtu.be/X1SL2uubx9M?t=158 (video is queued to the point).
The following page (seems newer) that walks you through creating and access review never mentions it at all.
https://docs.microsoft.com/en-us/azure/active-directory/privileged-identity-management/pim-how-to-start-security-review
Yet AZ-500 (Azure Security exam) seems to have a question on this.  So obviously it is important for admins to know about it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3a8a3416-ca49-e148-89ec-aa004914eaa5
Version Independent ID: 6e6831f4-40ed-4058-5a6f-56cd3900460a
Content: What are access reviews? - Azure Active Directory
Content Source: articles/active-directory/governance/access-reviews-overview.md
Service: active-directory
Sub-service: compliance
GitHub Login: @msaburnley
Microsoft Alias: ajburnle

@D-Moonesinghe Thank you for your feedback . We will have this reviewed and update this thread.

@D-Moonesinghe
Thanks for your feedback. The article you have submitting this issue for is the overview. It's not meant to have the full instructions to create an access review and that is why it doesn't mention programs.
This doc: https://docs.microsoft.com/en-us/azure/active-directory/governance/create-access-review has the full steps of creating an access review and mentions programs.
I will be closing this github issue. If you have any other questions let me know. Thanks!

#please-close


so many powershell.exe has been launch but never exit

Issue Type: Bug
After runing vscode.exe , powershell.exe is created every five or ten minutes. Even in idle state ,powershell.exe created all the time . If exit vscode.exe ,all powershell processes are ended.
VS Code version: Code 1.28.1 (3368db6750222d319c851f6d90eb619d886e08f5, 2018-10-11T18:13:53.910Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3591)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.92GB (9.33GB free)

Process Argv

Screen Reader
no

VM
50%

Extensions: none

Same problem here. Had to kill them with taskkill /F /IM powershell.exe and recovered over 1GB of memory!
They of course come back gradually after a while.
At first impression, it seems a new process is spawned each time the "Settings Sync" extension is running, at least in my case. (Don't know if it's limited to this extension, or if it's a general issue, though.)

Just wanted to add a "me too" here.
This capture is 8 minutes after launching VScode. Previous launch had more than 50 powershells opened (maybe even 100).

Thanks for reporting, this issue is being tracked in #60585
We have a fix which we will be releasing soon, but we would greatly appreciate if any of you can help use verify the fix as well. To do so, close all instances of VS Code, and download VS Code from one of the below links to see if the problem is now fixed.

64 bit user setup
64 bit system setup
32 bit user setup
32 bit system setup

An quick test after installing shows the problem is fixed (no more powershell processes spawned by code.exe), although VScode detects that it is not the "stable" version and downloads 1.28.1 to reinstall it after it is restarted. I am just guessing that this is the normal behaviour, but reporting it just in case.
I will run a longer test tomorrow.

Thanks for verifying @JosepMaJAZ!

although VScode detects that it is not the "stable" version and downloads 1.28.1 to reinstall it after it is restarted.

That is just because we havent yet released 1.28.2 yet.
Closing this issue as /duplicate of #60585

In my case , problem solved after updating vscode to 1.28.2 just now.Thanks @ramya-rao-a


Could not load DLL 'lib_lightgbm'

Hi,
I am reading your tutorial for the first time. I loaded it into the Visual Studio project. Project compiles, but gets an error on startup:
{"Could not load DLL 'lib_lightgbm': The specified module could not be found. (Exception from HRESULT: 0x8007007E)"}
in private static void Evaluate(MLContext mlContext, IDataView trainingDataView, IEstimator trainingPipeline) method.
Can you help somehow?
Visual Studio 2019 Community, x64

I haven't experienced that error myself. Check out the following issues and let me know if they solved your problem

https://github.com/dotnet/machinelearning/issues/1945
https://github.com/dotnet/machinelearning/issues/2533


Misformatted SYNTH_STRATEGY

Description
Hello,
I've setup a config.json file for my flow :
{
    "DESIGN_NAME": "core",
    "VERILOG_FILES": "dir::src/*.v",
    "PDK": "sky130A",
    "RUN_LINTER":0,

    "CLOCK_PERIOD": 10,
    "CLOCK_PORT": "clk",
    "CLOCK_NET": "ref::$CLOCK_PORT",

    "SYNTH_AUTONAME":1,
    "SYNTH_BIN":"yosys",
    "SYNTH_STRATEGY":"DELAY",
    "SYNTH_BUFFERING":1,

    "STD_CELL_LIBRARY":"sky130_fd_sc_hd",
    "FP_PDN_SKIPTRIM": true,
    "pdk::sky130*": {
        "FP_CORE_UTIL": 45,
        "scl::sky130_fd_sc_hd": {
            "CLOCK_PERIOD": 10
        },
        "scl::sky130_fd_sc_hdll": {
            "CLOCK_PERIOD": 10
        },
        "scl::sky130_fd_sc_hs": {
            "CLOCK_PERIOD": 8
        },
        "scl::sky130_fd_sc_ls": {
            "CLOCK_PERIOD": 10,
            "MAX_FANOUT_CONSTRAINT": 5
        },
        "scl::sky130_fd_sc_ms": {
            "CLOCK_PERIOD": 10
        }
    },
    "pdk::gf180mcu*": {
        "CLOCK_PERIOD": 24.0,
        "FP_CORE_UTIL": 40,
        "MAX_FANOUT_CONSTRAINT": 4,
        "PL_TARGET_DENSITY": 0.5
    }
}

When I try to enter something like "DELAY 1" in the SYNTH_STRATEGY variable, or any other numbers btw 0-4. It doesn't work, I got the following error :
[ERROR]: during executing yosys script /openlane/scripts/yosys/synth.tcl
[ERROR]: Log: designs/core/runs/run_10ns_v2/logs/synthesis/1-synthesis.log
[ERROR]: Last 10 lines:
 Yosys 0.34 (git sha1 4a1b5599258, gcc 8.3.1 -fPIC -Os)

[TCL: yosys -import] Command name collision: found pre-existing command `cd' -> skip.
[TCL: yosys -import] Command name collision: found pre-existing command `eval' -> skip.
[TCL: yosys -import] Command name collision: found pre-existing command `exec' -> skip.
[TCL: yosys -import] Command name collision: found pre-existing command `read' -> skip.
[TCL: yosys -import] Command name collision: found pre-existing command `trace' -> skip.
[ERROR] Misformatted SYNTH_STRATEGY ("DELAY").
[ERROR] Correct format is "DELAY|AREA 0-4|0-3".
child process exited abnormally

[ERROR]: Creating issue reproducible...

Did I miss any stepped ?
Expected Behavior
I would expect it to not fail since in the documentation it is written we can chosse between DELAY/AREA 0-4/0-3
Environment report
{
    "DESIGN_NAME": "core",
    "VERILOG_FILES": "dir::src/*.v",
    "PDK": "sky130A",
    "RUN_LINTER":0,

    "CLOCK_PERIOD": 10,
    "CLOCK_PORT": "clk",
    "CLOCK_NET": "ref::$CLOCK_PORT",

    "SYNTH_AUTONAME":1,
    "SYNTH_BIN":"yosys",
    "SYNTH_STRATEGY":"DELAY",
    "SYNTH_BUFFERING":1,

    "STD_CELL_LIBRARY":"sky130_fd_sc_hd",
    "FP_PDN_SKIPTRIM": true,
    "pdk::sky130*": {
        "FP_CORE_UTIL": 45,
        "scl::sky130_fd_sc_hd": {
            "CLOCK_PERIOD": 10
        },
        "scl::sky130_fd_sc_hdll": {
            "CLOCK_PERIOD": 10
        },
        "scl::sky130_fd_sc_hs": {
            "CLOCK_PERIOD": 8
        },
        "scl::sky130_fd_sc_ls": {
            "CLOCK_PERIOD": 10,
            "MAX_FANOUT_CONSTRAINT": 5
        },
        "scl::sky130_fd_sc_ms": {
            "CLOCK_PERIOD": 10
        }
    },
    "pdk::gf180mcu*": {
        "CLOCK_PERIOD": 24.0,
        "FP_CORE_UTIL": 40,
        "MAX_FANOUT_CONSTRAINT": 4,
        "PL_TARGET_DENSITY": 0.5
    }
}

Reproduction material
.
Relevant log output
[ERROR]: during executing yosys script /openlane/scripts/yosys/synth.tcl
[ERROR]: Log: designs/core/runs/run_10ns_v2/logs/synthesis/1-synthesis.log
[ERROR]: Last 10 lines:
 Yosys 0.34 (git sha1 4a1b5599258, gcc 8.3.1 -fPIC -Os)

[TCL: yosys -import] Command name collision: found pre-existing command `cd' -> skip.
[TCL: yosys -import] Command name collision: found pre-existing command `eval' -> skip.
[TCL: yosys -import] Command name collision: found pre-existing command `exec' -> skip.
[TCL: yosys -import] Command name collision: found pre-existing command `read' -> skip.
[TCL: yosys -import] Command name collision: found pre-existing command `trace' -> skip.
[ERROR] Misformatted SYNTH_STRATEGY ("DELAY").
[ERROR] Correct format is "DELAY|AREA 0-4|0-3".
child process exited abnormally

[ERROR]: Creating issue reproducible...

@lovisXII In your example, your are setting it to DELAY. It should be values similar to DELAY 0, DELAY 1, AREA 0, etc.

Well wrong copy paste my mistaek, it doesnt work with DELAY 0 but it does with just DELAY

@lovisXII The error message and the config file don't match. Maybe you haven't saved the config file (there's an M:modified after the filename.)
The  Correct format message may be a little misleading. The correct values are
DELAY 0-4 or AREA 0-3.
You can check the code here.

Indeed you're correct my script to copy the config file in the correct directory had a mistake and the file was not copied, thanks !


Change default icon?

Hi, is there a way that I can change the default icon to this https://github.com/fv0/native-ui/raw/master/Atom.ico on Windows 10?

Sorry, but we are trying to manage the deluge of issues and this is not the appropriate place for a general question such as this.
Try asking on Discuss or on Atom Slack.


Docs section: Security, Governance and Compliance - Microsoft Endpoint Manager (MEM)

Microsoft endpoint manager is now supports AVD session hosts, but this is not referenced on the docs, we should include it.
Fix:

Include MEM recommendations
Update doc

Page updated. https://github.com/MicrosoftDocs/cloud-adoption-framework-pr/pull/3207

Page updated. https://github.com/MicrosoftDocs/cloud-adoption-framework-pr/pull/3207


Does nerdctl restart have unstable issues

Description
After my machine unexpectedly restarted, the containers were all in a Created status, and containerd reported an error log: "no running task found: task 6ad08d6d5f8907df1fd555cc", after that nerdctl restart 6ad08d6d5f89 it shows
FATA[0000] 1 errors: no running task found: task 6ad08d6d5f8907df1fd555cc7ebd015291f1964e4c8b493fecd0fab9aa3d9541 not found: not found,
but when I continue to nerdctl start 6ad08d6d5f89, it works, and then the container becomes in an Up status
Steps to reproduce the issue

Describe the results you received and expected
nerdctl restart can work
What version of nerdctl are you using?
1.7.2
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response

@fahedouch @shilaidun shall we close this?

@AkihiroSuda should this be closed?