qemu_leon3: tests/posix/common/portability.posix.common fails

Describe the bug
The tests/posix/common/portability.posix.common test fails on the qemu_leon3 target:
ASSERTION FAIL [0] @ WEST_TOPDIR/zephyr/kernel/sched.c:1764
	aborted _current back from dead

This assertion failure occurs after the test successfully completes and the test thread is aborted (fails to swap):
https://github.com/zephyrproject-rtos/zephyr/blob/6cfb18686e1c494d0011aec87bbf24ab530d3a34/kernel/sched.c#L1761-L1765
To Reproduce
Build tests/posix/common/portability.posix.common for qemu_leon3 and run inside QEMU.
Expected behavior
Test passes.
Impact
CI reports a failure.
Logs and console output
Running TESTSUITE posix_apis
===================================================================
START - test_nanosleep_0_1
 PASS - test_nanosleep_0_1 in 0.020 seconds
===================================================================
START - test_nanosleep_0_1000000000
 PASS - test_nanosleep_0_1000000000 in 0.001 seconds
===================================================================
START - test_nanosleep_0_1001
 PASS - test_nanosleep_0_1001 in 0.019 seconds
===================================================================
START - test_nanosleep_0_500000000
 PASS - test_nanosleep_0_500000000 in 0.510 seconds
===================================================================
START - test_nanosleep_0_n1
 PASS - test_nanosleep_0_n1 in 0.001 seconds
===================================================================
START - test_nanosleep_1_0
 PASS - test_nanosleep_1_0 in 1.010 seconds
===================================================================
START - test_nanosleep_1_1
 PASS - test_nanosleep_1_1 in 1.020 seconds
===================================================================
START - test_nanosleep_1_1001
 PASS - test_nanosleep_1_1001 in 1.020 seconds
===================================================================
START - test_nanosleep_NULL_NULL
 PASS - test_nanosleep_NULL_NULL in 0.001 seconds
===================================================================
START - test_nanosleep_NULL_notNULL
 PASS - test_nanosleep_NULL_notNULL in 0.001 seconds
===================================================================
START - test_nanosleep_n1_0
 PASS - test_nanosleep_n1_0 in 0.001 seconds
===================================================================
START - test_nanosleep_n1_n1
 PASS - test_nanosleep_n1_n1 in 0.001 seconds
===================================================================
START - test_nanosleep_notNULL_NULL
 PASS - test_nanosleep_notNULL_NULL in 0.001 seconds
===================================================================
START - test_nanosleep_notNULL_notNULL
 PASS - test_nanosleep_notNULL_notNULL in 0.001 seconds
===================================================================
START - test_nanosleep_req_is_rem
 PASS - test_nanosleep_req_is_rem in 0.016 seconds
===================================================================
START - test_posix_clock
POSIX clock APIs
POSIX clock APIs test done
 PASS - test_posix_clock in 2.021 seconds
===================================================================
START - test_posix_mqueue
 PASS - test_posix_mqueue in 0.020 seconds
===================================================================
START - test_posix_multiple_threads_single_key

Different threads set different values to same key:
thread 0: set value =<PHONE_NUMBER> and retrieved value =<PHONE_NUMBER>
thread 1: set value =<PHONE_NUMBER> and retrieved value =<PHONE_NUMBER>

 PASS - test_posix_multiple_threads_single_key in 0.003 seconds
===================================================================
START - test_posix_normal_mutex
mutex lock is taken
 PASS - test_posix_normal_mutex in 0.217 seconds
===================================================================
START - test_posix_pthread_create_negative
 PASS - test_posix_pthread_create_negative in 0.001 seconds
===================================================================
START - test_posix_pthread_error_condition
 PASS - test_posix_pthread_error_condition in 0.001 seconds
===================================================================
START - test_posix_pthread_execution
Thread 0 starting with scheduling policy 0 & priority 15
Thread 1 starting with scheduling policy 0 & priority 15
Thread 2 starting with scheduling policy 0 & priority 15
Bounce test OK
Barrier test OK
 PASS - test_posix_pthread_execution in 2.795 seconds
===================================================================
START - test_posix_pthread_termination
Thread 0 starting with a priority of 4
Cancelling thread 0
Thread 1 starting with a priority of 3
Cancelling thread 1
Thread 1 could not be cancelled
Thread 2 starting with a priority of 2
Cancelling thread 2
Thread 3 starting with a priority of 1
Cancelling thread 3
Thread 3 could not be cancelled
 PASS - test_posix_pthread_termination in 1.006 seconds
===================================================================
START - test_posix_realtime
 PASS - test_posix_realtime in 2.000 seconds
===================================================================
START - test_posix_recursive_mutex
recursive mutex lock is taken
 PASS - test_posix_recursive_mutex in 0.001 seconds
===================================================================
START - test_posix_rw_lock

main acquire WR lock and 3 threads acquire RD lock
Thread 2 scheduling policy = 1 & priority 3 started
Not able to get RD lock on trying, try again
Thread 1 scheduling policy = 1 & priority 2 started
Not able to get RD lock on trying, try again
Thread 0 scheduling policy = 1 & priority 1 started
Not able to get RD lock on trying, try again
Parent thread releasing WR lock
Thread 2 got RD lock
Thread 1 got RD lock
Thread 0 got RD lock
Parent thread acquiring WR lock again
Thread 2 releasing RD lock
Thread 2 acquiring WR lock
Thread 1 releasing RD lock
Thread 1 acquiring WR lock
Thread 0 releasing RD lock
Parent thread acquired WR lock again
Thread 0 acquiring WR lock
Parent thread releasing WR lock again

3 threads acquire WR lock
Main thread acquiring RD lock
Thread 2 acquired WR lock
Thread 2 releasing WR lock
Main thread acquired RD lock
Main thread releasing RD lock
Thread 1 acquired WR lock
Thread 1 releasing WR lock
Thread 0 acquired WR lock
Thread 0 releasing WR lock
 PASS - test_posix_rw_lock in 0.139 seconds
===================================================================
START - test_posix_semaphore
 PASS - test_posix_semaphore in 5.012 seconds
===================================================================
START - test_posix_single_thread_multiple_keys

Single thread associates its value with different keys:
key 0: set value =<PHONE_NUMBER> and retrieved value =<PHONE_NUMBER>
key 1: set value =<PHONE_NUMBER> and retrieved value =<PHONE_NUMBER>

 PASS - test_posix_single_thread_multiple_keys in 0.002 seconds
===================================================================
START - test_posix_thread_attr_stacksize
 PASS - test_posix_thread_attr_stacksize in 0.001 seconds
===================================================================
START - test_posix_timer
POSIX timer test
Timer fires every 0 secs and  100000000 nsecs
Time remaining to fire 0 secs and  890000000 nsecs
Handler Signal value :20 for 1 times
Handler Signal value :20 for 2 times
Handler Signal value :20 for 3 times
Handler Signal value :20 for 4 times
Handler Signal value :20 for 5 times
Handler Signal value :20 for 6 times
Handler Signal value :20 for 7 times
Handler Signal value :20 for 8 times
Handler Signal value :20 for 9 times
Handler Signal value :20 for 10 times
Handler Signal value :20 for 11 times
Handler Signal value :20 for 12 times
 PASS - test_posix_timer in 2.117 seconds
===================================================================
START - test_pthread_descriptor_leak
 PASS - test_pthread_descriptor_leak in 0.011 seconds
===================================================================
TESTSUITE posix_apis succeeded

------ TESTSUITE SUMMARY START ------

SUITE PASS - 100.00% [posix_apis]: pass = 31, fail = 0, skip = 0, total = 31 duration = 18.970 seconds
 - PASS - [posix_apis.test_nanosleep_0_1] duration = 0.020 seconds
 - PASS - [posix_apis.test_nanosleep_0_1000000000] duration = 0.001 seconds
 - PASS - [posix_apis.test_nanosleep_0_1001] duration = 0.019 seconds
 - PASS - [posix_apis.test_nanosleep_0_500000000] duration = 0.510 seconds
 - PASS - [posix_apis.test_nanosleep_0_n1] duration = 0.001 seconds
 - PASS - [posix_apis.test_nanosleep_1_0] duration = 1.010 seconds
 - PASS - [posix_apis.test_nanosleep_1_1] duration = 1.020 seconds
 - PASS - [posix_apis.test_nanosleep_1_1001] duration = 1.020 seconds
 - PASS - [posix_apis.test_nanosleep_NULL_NULL] duration = 0.001 seconds
 - PASS - [posix_apis.test_nanosleep_NULL_notNULL] duration = 0.001 seconds
 - PASS - [posix_apis.test_nanosleep_n1_0] duration = 0.001 seconds
 - PASS - [posix_apis.test_nanosleep_n1_n1] duration = 0.001 seconds
 - PASS - [posix_apis.test_nanosleep_notNULL_NULL] duration = 0.001 seconds
 - PASS - [posix_apis.test_nanosleep_notNULL_notNULL] duration = 0.001 seconds
 - PASS - [posix_apis.test_nanosleep_req_is_rem] duration = 0.016 seconds
 - PASS - [posix_apis.test_posix_clock] duration = 2.021 seconds
 - PASS - [posix_apis.test_posix_mqueue] duration = 0.020 seconds
 - PASS - [posix_apis.test_posix_multiple_threads_single_key] duration = 0.003 seconds
 - PASS - [posix_apis.test_posix_normal_mutex] duration = 0.217 seconds
 - PASS - [posix_apis.test_posix_pthread_create_negative] duration = 0.001 seconds
 - PASS - [posix_apis.test_posix_pthread_error_condition] duration = 0.001 seconds
 - PASS - [posix_apis.test_posix_pthread_execution] duration = 2.795 seconds
 - PASS - [posix_apis.test_posix_pthread_termination] duration = 1.006 seconds
 - PASS - [posix_apis.test_posix_realtime] duration = 2.000 seconds
 - PASS - [posix_apis.test_posix_recursive_mutex] duration = 0.001 seconds
 - PASS - [posix_apis.test_posix_rw_lock] duration = 0.139 seconds
 - PASS - [posix_apis.test_posix_semaphore] duration = 5.012 seconds
 - PASS - [posix_apis.test_posix_single_thread_multiple_keys] duration = 0.002 seconds
 - PASS - [posix_apis.test_posix_thread_attr_stacksize] duration = 0.001 seconds
 - PASS - [posix_apis.test_posix_timer] duration = 2.117 seconds
 - PASS - [posix_apis.test_pthread_descriptor_leak] duration = 0.011 seconds

------ TESTSUITE SUMMARY END ------

===================================================================
RunID: 9e2ff8b97f3a7da845c3d3a0c6ccdb19
PROJECT EXECUTION SUCCESSFUL
ASSERTION FAIL [0] @ WEST_TOPDIR/zephyr/kernel/sched.c:1764
	aborted _current back from dead
E:
E: tt = 0x8F, trap_instruction
E:
E:       INS        LOCALS     OUTS       GLOBALS
E:   0:  400166a0   f3000fc2   40015fa0   00000000
E:   1:  00000000   4000ebf0   000006e4   00000004
E:   2:  40016724   4000ebf4   40015fa0   00000006
E:   3:  40018000   00000004   000006e4   00000020
E:   4:  40016724   40008400   40018114   00000000
E:   5:  40015c00   f30000c0   40018000   00000100
E:   6:  400204d8   40000050   40020470   00000000
E:   7:  40006618   00000008   4000fb44   00000000
E:
E: psr: f39000c5   wim: 00000080   tbr: 400008f0   y: 00000000
E:  pc: 40007ef4   npc: 40007ef8
E:
E:       pc         sp
E:  #0   40007ef4   40020470
E:  #1   40006618   400204d8
E:  #2   400083d8   40020538
E:  #3   4000fcb0   00000000
E:
E: >>> ZEPHYR FATAL ERROR 4: Kernel panic on CPU 0
E: Current thread: 0x400166a0 (unknown)
E: Halting system

Environment (please complete the following information):

OS: Ubuntu 20.04
Toolchain: Zephyr SDK 0.14.2
Commit SHA: 0226e53e239f8562b0636a2a4e42e99b0894f784

Additional context
Bisected to 9a4b5e1d908575a552f15204a51c92c9732f3d84; however this commit, in itself, does not seem to be doing anything wrong and the failure is likely due to a more serious underlying issue.
This failure is likely due to an alignment-related issue:
https://github.com/zephyrproject-rtos/zephyr/blob/9a4b5e1d908575a552f15204a51c92c9732f3d84/subsys/testsuite/include/zephyr/tc_util.h#L56-L59
Changing the number of =s by -7 or +7 makes the assertion failure go away.
Related discussion on Discord: https://discord.com/channels/720317445772017664/733037890514321419/1007518292732289034
p.s. That this test also fails when compiled using the Zephyr SDK 0.15.0, so the issue is not toolchain or QEMU version specific.

For now, the quickest workaround is to specify -mfaster-structs, which forces all structs to have 8-byte alignment.
The root cause still needs to be investigated and fixed.

Took a quick look.  Agree that the alignment guess seems close.  After checking to be sure this wasn't a stack overflow (seriously: always check the stacks on weird stuff like this) I got it localized to a particular test case that isn't doing anything but creating a thread and joining it synchronously.  See notes in this patch: https://gist.github.com/andyross/d2edbd77463000e57b4c7a39cac31ed7
I thought it was a race at first, so I added a delay between the steps and that "fixed" it, as did a yield.  But so did a busywait, which is more suspicious (that shouldn't generally cause a context switch), and so did a busy wait of 1us, which was weird.  And so did a hand-written delay.  And so did the same hand written delay with a loop count of 1 that adds only four instructions and a stack word!  (And indeed, AFAICT the spawned thread never runs before the join in that final "working" case, it's not a race between them at all).
But hand-adding four NOPs did not fix the problem, nor did my attempts to expand the stack frame by a word via other means.  So no root cause yet.
But this definitely looks like a glitch in the platform context switch code.  That pthread_join() is just going to call arch_switch() synchronously.  My guess is that there's an edge case in there that gets something wrong based on some oddity about the stack frame + instruction pointer state.
But it could totally be a bug in the pthread code too that just happens to fail here, or in the kernel for that matter.  But my intuition points at the arch code.


is it possible to lazyload thumbnails ?

I'm using LazyLoad plugin and I would like if it possible to lazy load the data-thumb image
For information I have this code in my slider:

[li] data-thumb="http://exemple.tld/medias/imgs/slider/thumb/20-thumb.jpg" ]
[img class="lazy" data-original="http://exemple.tld/medias/imgs/slider/20.jpg" width="800" height="356" ]
[/li]

The large image is lazyloaded very well, but it doesn't want to lazyload the thumbnails
I tried to add the lazy class to the LightSlider js script where the img tag is generated and it doesn't work too
[ img class="lazy"  src="'+r+'" /]
I would like to do it because I have 40 thumbnails who load when the page is loaded
Any advice or solution will be appreciated
Thanks in advance

@sachinchoolur any updates on this?

Solution #1 is ridiculously simplet and I use it in all my sites now. http://blog.dynamicdrive.com/5-brilliant-ways-to-lazy-load-images-for-faster-page-loads/ Why didn't I think of this?

Solution#1 is ridiculously simple and I use it in all my sites now. http://blog.dynamicdrive.com/5-brilliant-ways-to-lazy-load-images-for-faster-page-loads/ Why didn't I think of this?

It seems to me you have never used lightslider (this project) because if you did you would realize your answer doesnt help at all.  The problem isn't about generically lazy loading an image (we all know how to do that), the question is how to lazy load within the lightslider gallery.
But it seems clear the author has abandoned this project.

I am probably late to the party, and it seems the author has abandoned this project; but it still is a great plugin, considering there are very recent pull requests.
There is an easy solution for lazy loading the thumbnails based on browser-level lazy-loading.
I would like to share it here as I was looking for a solution, and was unable to find one.
Change the line 358 from:
pagers += '

';

to:
pagers += '

';

Then add the line
loading: 'auto',

to the defaults(about line 39).
Now you will be able to configure your thumbnail behaviour using the loading attribute with one of 3 settings:
auto: Default lazy-loading behavior of the browser, which is the same as not including the attribute.
lazy: Defer loading of the resource until it reaches a calculated distance from the viewport.
eager: Load the resource immediately, regardless of where it's located on the page.
All you have to do is add the loading attribute to the slide too:

$(document).ready(function() {
  $('#imageGallery').lightSlider({
      gallery:true,
      item:1,
      loop:true,
      thumbItem:9,
      slideMargin:0,
      enableDrag: false,
      currentPagerPosition:'left',
      loading:'lazy',
      onSliderLoad: function(el) {
          el.lightGallery({
              selector: '#imageGallery .lslide'
          });
      }
  });
});

I hope it helps someone.

Thanks @IncubuzzCC. That worked! Appreciate it.


bulk.merge_relationships to allow MERGE on nodes

I propose to add functionality a flag to bulk.merge_relationships which would allow to use MERGE instead of MATCH on nodes, thus creating missing nodes if they do not exist.
As far as I understand, currently the function uses MATCH on nodes, and if one of the nodes are missing from the graph, relationship will not be created.

+1 to this


The running result

Hello, thank you for your code. I trained the model on Webqsp and CWQ datasets in the way you described. All the parameters are consistent with the parameters you provided. Finally, the results on Websp are F1: 0.7028, H1: 0.7498, and the results on CWQ are H1: 0.5251, which does not reach the results you provided in the paper. I still can't get results after modifying the batchsize and epoch，What is the reason for this？ THX

Hi, thank you for your interest in our work!

Indeed, the results for Webqsp that you report seem a bit lower. I am uploading the log file for Webqsp (ReaRev_webqsp_v2.ckpt model), so you can see whether some hyperparameter is different.
For the SOTA results for Webqsp and CWQ, we have performed extensive seed parameter search (unfortunately, I have only kept the models). However, you should be able to reach H@1 scores above 75.8 and 52.5 without extensive tuning. I can try to repeat the process when I find time.

Thank you for your reply. I compared the log you provided and found that all the parameters I used were identical, but my running results were worse， I will try to adjust the parameters again. In addition, I found that the SOTA F1 score in your log reached 71.66, but 70.9 were reported in your paper, What is the reason? THX

We reported the other results when we submitted the paper. We might update the scores in a later version.

Hi, thank you very much for this wonderful work. Extending the above issue, I have a question regarding which score you reported.
After running the code, we get six values: best h1 F1 & H1, best f1 F1 & H1, and final epoch F1 & H1.
Which two of the six values did you report for (76.4 & 70.9) in the paper?
My guess is (best h1 H1 & best f1 F1). Am I right?
Thanks in advance :)

Hi, thank you for your interest in our work!
Right, this (best h1 for H1 & best f1 for F1) is the straightforward thing to do.

However, Webqsp contains only 500 dev questions, which may not provide helpful validation scores. For example, in the log file upload here https://github.com/cmavro/ReaRev_KGQA/issues/1#issuecomment-1328084571 , the model of the final epoch performs the best.
For CWQ, we observed that validation scores are much more helpful.

I see, thank you for your response :)

Hi, one last question.
May I ask you which score of the two you reported in the paper?
Was it the best H1/F1 val score's test score? Or the final H1/F1 test score?
I've been trying out with the former, but I'm having a hard time reaching over 76.0 H1 test score for WebQSP.
I was curious if maybe you didn't apply early stopping for reporting, as I did see some previous works doing this.
Thank you :)

This is also possible (e.g., start early stopping after some warmup epochs>=100) . Unfortunately, I have not kept the corresponding log files to verify it.
Please feel free to report the best scores you obtain if you retrain ReaRev.

I see, thanks once again for your response :)


Corrupted log4j jars in APIM <IP_ADDRESS>

Description:
In U2 level 124, the log4j jar files inside <APIM_HOME>/lib directory is corrupted. Due to this a ClassNotFoundException will be thrown if AppDynamics is configured with APIM.
Steps to reproduce:
Navigate to <APIM_HOME>/lib directory and check the sizes of log4j-api-2.17.1.jar, log4j-core-2.17.1.jar and log4j-jcl-2.17.1.jar files. It is only 459 bytes in size and cannot be extracted.
Affected Product Version:
APIM 3.2.0

Seems this issue is resolved in the latest u2 update. I checked in <IP_ADDRESS>4 and no issue found


Caching fails due to syntax errors

(how this slipped through I do not know)

I know that test-kitchen is hard with windows (starting with "where to get the baseboxes" up to "it won't run on travis or circleci"), but we could have caught that with chefspec for sure. The windev cookbook has several conditionals and loops and edge cases that would be a perfect fit for chefspec. And we could run it on travis :-)
Here is some practical instructions on how to get (kick-)started:
https://github.com/tknerr/zdays2015-demo-repo/tree/master/chef-tdd-environment
https://github.com/tknerr/zdays2015-demo-repo/tree/master/chef-tdd-chefspec


Document use of Korrel8r.Spec.Config field.

Need to explain

configuration file format and meaning

source: https://github.com/korrel8r/korrel8r/blob/main/pkg/config/types.go#L9
API doc: https://pkg.go.dev/github.com/korrel8r/korrel8r@latest/pkg/config#Config

running directly as an executable:

specify alternate config files via --config flag
note that config file can "include" other config files

running as a k8s resource via Korrel8r resource

Primary configuration is part of the resource: field .spec.config
additional config files can be added via a ConfigMap (details & example)
standard config files are built-into the image (/etc/korrelr8/..., need to list available fragments and paths)

API doc link says "latest is not a valid version" but this one works: https://pkg.go.dev/github.com/korrel8r/korrel8r/pkg/config#Config

@abrennan89 the pkg.go.doc doc site only generates docs for "released" versions, i.e. ones having a vx.y.z tag or branch.
You can read the latest directly from Go source  - the same text, just not as pretty. Look for // comments directly before each func, type or package declaration with no intervening newlines.
You can install pkgsite yourself - that's the tool used by pkg.go.doc to format the docs. Then you can view any Go source code including your own private edits.
If/when you decide to contribute back improvements for the API doc, you'll can edit the source comments  & preview using pkgsite. The formatting rules are minimal and simple, markdown-ish but a very restrictred subset.

Some of this is now documented per https://github.com/korrel8r/korrel8r/pull/79


Add stdout logging option to SC docs

Description
SauceConnect has an undocumented option to log to stdout.
Motivation and Context
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation fix (typos, incorrect content, missing content, etc.)

Checklist

[ ] I have read the contributing document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Maybe
:::note
Use --logfile - to print your log to the console window (stdout) instead of the physical log file.
:::

Maybe
:::note Use --logfile - to print your log to the console window (stdout) instead of the physical log file. :::

@waggledans thank you! Just applied this change here: https://github.com/saucelabs/sauce-docs/pull/1019


Added merge method.

Thanks for the PR. Would you mind adding some test? I'll plan a release in a few hours and it will probably fail if there is no test.

hey @ericmorand. Added the tests too, checked them myself, they are passing.

Thanks for the work, @tibi2303, much appreciated. On my way to publish 1.1.0.


create .readthedocs.yaml

Describe your changes
add a config file to create documentation on readthedocs.
Describe any testing you have performed
Please add any demo scripts to CIL-Demos/misc/
Link relevant issues
#1329
Checklist when you are ready to request a review

[ ] I have performed a self-review of my code
[ ] I have added docstrings in line with the guidance in the developer guide
[ ] I have implemented unit tests that cover any new or modified functionality
[ ] CHANGELOG.md has been updated with any functionality change
[ ] Request review from all relevant developers
[ ] Change pull request label to 'Waiting for review'

Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.

[x] The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
[x] I confirm that the contribution does not violate any intellectual property rights of third parties

I'm getting errors while building on readthedocs

could you change the depth when you clone?

also what is the reason for --no-single-branch?

This was an experiment to see if we could simply publish the documentation on readthedocs. Given that the resolution of the environment fails, this PR requires much more work.


Update Composer dependencies (2022-07-04-00-07)

Visual regression test passed!
View the visual regression test report


[SPARK-50445][PYTHON][DOCS] Refine docString of generator Functions

What changes were proposed in this pull request?
Refine docString of generator Functions
Why are the changes needed?
to improve docs and test coverage
Does this PR introduce any user-facing change?
doc-only changes
How was this patch tested?
new doctests
Was this patch authored or co-authored using generative AI tooling?
no

thanks, merged to master


:args: do not add trailing newline(s)

Since v8.0.1738 (5d69da462) :args with only a single argument would
cause a hit-enter message:
[/etc/fstab]

Press ENTER or type command to continue

This patch changes it to not add a trailing newline.
It adds crow for "current row", which could be calculated as
last_row instead similar to last_col maybe, but I found this easier,
and the patch is only meant as a suggestion and will be edited anyway.
Likely also needs a test adjustment then (or should have a test).

Since v8.0.1738 (5d69da462) :args with only a single argument would
cause a hit-enter message:
[/etc/fstab]

Press ENTER or type command to continue

This patch changes it to only add a trailing newline if necessary.
It adds crow for "current row", which could be calculated as
last_row instead similar to last_col maybe, but I found this easier,
and the patch is only meant as a suggestion and will be edited anyway.
Likely also needs a test adjustment then (or should have a test).

Yes, this looks like a bug fix.  A test would be helpful.
--
A M00se once bit my sister ...
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

A test would be helpful.

Caught this with one of Neovim's tests.. ;)
Arguably not enough for Vim itself, but from taking a quick look it looks like it's not really possible without a screen dump test, and I do not know my way around those.

A test would be helpful.

Caught this with one of Neovim's tests.. ;)
Arguably not enough for Vim itself, but from taking a quick look it
looks like it's not really possible without a screen dump test, and I
do not know my way around those.

It might work without a screenshot test, but I found it's easier to just
make one.  You can use Test_popup_and_previewwindow_dump() as an
example.
--
It might look like I'm doing nothing, but at the cellular level
I'm really quite busy.
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


ai-digital-twin use gaia

@lianshus please update the README.md with your project information only and then create a new PR.
Thank you.


DLL are missing in win32 binary build

In win32 binary build, Qt5Gui.dll / Qt5Network.dll / Qt5Core.dll / Qt5Widgets.dll are missing in zip file.
You should add a text in the README about 'qt-box-editor-dependecies-1.11.zip' files.

I do not use 32bit anymore and I will not even try it.


Various corrections (removed unused variables, formatted script, security and code readability changes)

Thank you for your repository, it's very interesting.
I have done a few changes that I would like to push, mainly about bash code sustainability.
Most of the changes are small and insignificant (e.g., unused variables, code readability changes), but overall it'll be a good addition.
The commit messages should be self-explanatory, but if you have any question or would like to do any changes, please ask!
I tested the program on my machine with the changes, everything works fine for me.
Thanks.
P.S., I see you have a hard bash dependency, are you willing to make your program POSIX-compliant (usable for bash, zsh, dash, ...) or do you plan on keeping that hard dependency?

This is awesome, thank you so much!
I personally use zsh as my shell, but use bash to run all my scripts, so I'm not really familiar with using it to run scripts. Is there any benefit if you're not using anything specific to that shell?
I'd definitely be willing to make it POSIX-compliant, though.


Library not loaded: @rpath/libcudart.8.0.dylib but I have libcudart.7.5.dylib

I have the following error when importing tensor flow (GPU OSX version);
ImportError: dlopen(/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/tensorflow/python/_pywrap_tensorflow.so, 10): Library not loaded: @rpath/libcudart.8.0.dylib
  Referenced from: /Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/tensorflow/python/_pywrap_tensorflow.so
  Reason: image not found

It looks to me like it is looking for @rpath/libcudart.8.0.dylib but in my /usr/local/cuda/lib I have libcudart.7.5.dylib and no 8.0. How do I redirect it?

You should install from source code. The default CUDA of binary package is 8.0 and CUDNN 5.1.

Version 0.11 and comes compiled for 7.5
On Sat, Dec 17, 2016 at 6:15 PM, 史业民<EMAIL_ADDRESS>wrote:

You should install from source code. The default CUDA of binary package is
8.0 and CUDNN 5.1.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/6370#issuecomment-267799096,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABaHDYWT752XLZhKoYO0zWfohXymgIZks5rJJcpgaJpZM4LPtPN
.

According to https://github.com/tensorflow/tensorflow/blob/r0.11/tensorflow/g3doc/get_started/os_setup.md, r0.11 also need CUDA 8.0 and CUDNN v5.

Sorry, I meant version 10.
CUDA filename is baked into the final executable, in order to change the
CUDA version you have to recompile
On Sun, Dec 18, 2016 at 5:53 PM, 史业民<EMAIL_ADDRESS>wrote:

According to https://github.com/tensorflow/tensorflow/blob/r0.11/
tensorflow/g3doc/get_started/os_setup.md, r0.11 also need CUDA 8.0 and
CUDNN v5.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/6370#issuecomment-267865257,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABaHOcDNkH53jW1zaPIfVux05q1GWsgks5rJeOogaJpZM4LPtPN
.

You may also update CUDA and CuDNN, (if you are the administrator of the device) to use the later versions of tensorflow.
Closing this issue as @yaroslavvb has identified and explained the problem.

Thanks


Added "upsert" endpoint

/v1/contacts/create does not check "Email" anymore for updating an existing contact.
/v1/contacts/upsert is used to do a create or update action.

See http://api.whise.eu/WebsiteDesigner.html#operation/Contacts_UpsertContact

Thanks for your commit 🙂


GPL-261 - As Craig I would like to change fragment size to be insert size to ensure consistency within traction

Wherever fragment size appears in traction currently it will forthwith referred to as insert size

acceptance criteria:

wherever you see fragment size now you should see insert size
when you create a library you should fill in insert size


feat: enable odos scroll

https://lifi.atlassian.net/browse/LF-8779

why the test failed? Did I miss some setting?

@myz1237 can you get rid of the yarn.lock change in this PR?

@ezynda3 thanks, ed. I did not notice that change

I'm going to approve this as it's not the main cause of the error. This started after merging another PR and we still need to debug it. DEX has been approved on Scroll.

@ezynda3 It works now, thanks!


Question: Can the generated index.ts export the other types?

Is there a way to have our custom types exported from the index.ts file somehow?
Just a QoL question I'm wondering if I can minimize imports like `import type { RpcError } from "./bindings/RpcError.ts";

For instance, if I wanted that RpcError exported from that index file for whatever reason.
I tried:

Curious if this is possible!

I agree that this would be useful to have built in. As a workaround, I created a top-level index.ts that re-exports QubitServer plus other things I want, like this:
export * from "./src";

export type { JsonValue } from "./src/serde_json/JsonValue";
export type { RpcResult } from "./src/RpcResult";

I've had a bit of a play around with this, and managed to get something simple enough working.
I'm foreseeing the a potential issue if the same type name is used in multiple places, as the current type exporting setup looses the 'namespaced' nature of Rust modules. For example, src/file_a.rs could export MyStruct, available at crate::file_a::MyStruct, whilst src/file_b.rs could export a different MyString, available at crate::file_b::MyStruct. This setup would cause a conflict with them both being imported and exported from the TS file as type MyStruct.
This can be solved with the #[ts(rename = "..")] option however, but it's something worth being aware of.

Give<EMAIL_ADDRESS>a try, this should be solved in there.

This worked thanks so much!

Works for me too. Thank you!


ENH: update package version

Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #38.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!
Fixes #38

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender


Fix light mode carousel in dark mode

[!CAUTION]
Before merging, carousel.md modifications must be reverted

Description
This work has been done in collaboration with @louismaximepiton, please don't remove the "Co-authored-by" from the commit message if merged
This PR tackles specifically #40493. This work is based on https://github.com/twbs/bootstrap/pull/39295 spirit.
The idea is to rely on custom properties so that there's never a specificity issue when nesting color modes (light mode in dark mode, and dark mode in light mode).
In order for it to be non-breaking, _variables-dark.scss uses the newly deprecated $carousel-dark-* Sass variables.
Please note that in the future, we'll be able to replace :root, [data-bs-theme="light"] { with @include color-mode(light, true) as suggested in https://github.com/twbs/bootstrap/pull/39295.
This part generates the following CSS:
.carousel-dark {
  --bs-carousel-indicator-active-bg: #000;
  --bs-carousel-caption-color: #000;
  --bs-carousel-control-icon-filter: invert(1) grayscale(100);
}

:root,
[data-bs-theme=light] {
  --bs-carousel-indicator-active-bg: #fff;
  --bs-carousel-caption-color: #fff;
  --bs-carousel-control-icon-filter: ;
}

[data-bs-theme=dark] {
  --bs-carousel-indicator-active-bg: #000;
  --bs-carousel-caption-color: #000;
  --bs-carousel-control-icon-filter: invert(1) grayscale(100);
}

After this PR
After this PR, we might do exactly the same thing for the problematic rendering of the accordions, close buttons, etc. and use the same technique.
@mdo and @twbs/css-review what do you think about this PR? Do you agree that it can be used, it doesn't bring regressions, and can be replicated for other issues (accordions, etc.)?
Type of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
(N/A) My change introduces changes to the documentation
(N/A) I have updated the documentation accordingly
(N/A) I have added tests to cover my changes
[x] All new and existing tests passed

Live previews

https://deploy-preview-40695--twbs-bootstrap.netlify.app/docs/5.3/components/carousel/

Related issues
Closes #40493

I'm fine with that, to be honest I still don't know if I'd prefer to have it in the _root.scss or in each component but the mechanism is great to me regarding the color mode approach.

For now, I prefer to have it in each component, as if one doesn't want to embed the accordion in your custom build, we wouldn't have extra useless rules.

Reverted the carousel.md change used to review the PR. Let's merge it.


Allow custom decoder function

Hi,
I find myself often parsing a json string into a clj datastructure, then do a deep walk to coerce values into a custom type based on their key.
I would love to be able to do pass an (fn [k v] ...) function which does the coercion of values during the decoding.
Wdyt?

I might agree with @dakrone , except that Chesire converts Clojure keywords to strings when creating JSON and then leaves them as strings when converting back to Clojure data structures. This is problematic as the encode and decode are not reverse operations of each other. Most users will assume they are. The problem, of course, is that JSON doesn't have an equivalent of Clojure's keyword type, so data is lost when converting to JSON. Providing the user with a way to handle this as part of the encode/decode fns would allow the user to make them the reverse operations for the user's data. Write the data to a web app backend... read it later... and something else comes out because of this.
So basically, Chesire makes a decision about type conversion that limits what data can be conveniently used and provides no mechanism for choosing otherwise. Yet, the key-fn is provided for the keys. I don't know... I think it's worth doing this.


Cannot find RepairJukebox.asi

Hello, I have a broken save file and wanted to fix it but your latest release does not contain the "RepairJukebox.asi" like you mentioned in the readme. Do I have to compile it myself, and if yes, what tool do I have to use?

very super late but repairjukebox.asi exist in previous old version, version 1.7. I think xan forgot to compile the repairjukebox.asi starting version 1.8-present. You can test it to see if it works, if not, i have no idea what to do.


Android GraphQL API Multi Auth: amplifyconfiguration.json does not update to include apiname

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
10.0.0
What operating system are you using?
Windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Amplify Categories
auth, api
Amplify Commands
Not applicable
Describe the bug
When using Amplify CLI to configure a graphql API with multiple authorization modes, amplifyconfiguration.json does not get updated completely. The required configuration under awsAPIPlugin is not done for the additional authorization mode.
The documentation clearly mentions -

The friendly_name illustrated here is created from Amplify CLI prompt.

Expected behavior
In amplifyconfiguration.json, the required configuration under awsAPIPlugin should automatically be done for the additional authorization mode, as mentioned in the documentation.
Reproduction steps

Add a GraphQL API to an Android project using the Amplify CLI
In authorization modes, choose Cognito User Pools as the primary one and IAM as the additional authorization modes.
After completing the configuration, run Amplify Push.
Check if amplifyconfiguration.json is updated correctly. Check if configuration for additional auth is done automatically under "awsAPIPlugin" as mentioned in the documentation.

GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

Hey @sang2412 :wave: thanks for raising this! I was able to reproduce this issue and noticed the following awsAPIPlugin block:
"awsAPIPlugin": {
  "814": {
      "endpointType": "GraphQL",
      "endpoint": "https://pe7uiod2xnhajlqvwpn7ernexa.appsync-api.us-east-1.amazonaws.com/graphql",
      "region": "us-east-1",
      "authorizationType": "AMAZON_COGNITO_USER_POOLS",
      "apiKey": "da2-6qocwp27ungjbefd76n3vbboha"
  }
}

Marking as a bug 🙂

Hey @sang2412 apologies for the delay here, but you should be able to add additional configs manually to the Amplify client in your app code as this file is prone to be overwritten


cleanup: docstrings for dispatcher header

Description: docstrings for dispatcher header
Risk Level: low
Signed-off-by: Jose Nino<EMAIL_ADDRESS>

@goaway @rebello95 I addressed your comments


TST: Add tests for internal EOF in read_csv

Title is self-explanatory.  Closes #5500.

Current coverage is 85.27% (diff: 100%)

Merging #14069 into master will decrease coverage by <.01%

@@             master     #14069   diff @@
==========================================
  Files           139        139
  Lines         50455      50455
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          43026      43025     -1
- Misses         7429       7430     +1
  Partials          0          0

Powered by Codecov. Last update 6645b2b...8c4cf85

thanks!


Settings: Dataflux folder can not be changed

There is an error, when the dataflux folder has to be changed.

The problem is that the showDialog is not calling the callback function


AttributeError: 'SDP' object has no attribute 'variables'

using SDP constraint I get the following error:
Traceback (most recent call last):
File "C:/Users/hadas/PycharmProjects/projAlg/SDPup.py", line 102, in
main(numpy.array([0.2,0,0,0,0.3,0,0]),numpy.array([1,0.7,0,0,0.7,0,0]),[[[1],[0],[5]]])
File "C:/Users/hadas/PycharmProjects/projAlg/SDPup.py", line 62, in main
prob = Problem(objective,consts)
File "C:\Users\hadas\Anaconda2\lib\site-packages\cvxpy\problems\problem.py", line 78, in init
self.size_metrics = SizeMetrics(self)
File "C:\Users\hadas\Anaconda2\lib\site-packages\cvxpy\problems\problem.py", line 672, in init
for var in problem.variables():
File "C:\Users\hadas\Anaconda2\lib\site-packages\cvxpy\problems\problem.py", line 145, in variables
vars += constr.variables()
AttributeError: 'SDP' object has no attribute 'variables'

Sorry I need a minimal working example to look into this further. What do you mean by using SDP constraint exactly? You're not using the SDP class explicitly right? That's not permitted.


Resource is broken (with error page) after zipping, bagging, and unzipping operations

Description of the bug
After testing of zipping, bagging, and unzipping operations, a resource became unusual.  These operations weren't automated or otherwise executed in a non-human way.
Steps to reproduce the bug:

Upload a zip
Create a zip in the content browser
Unzip both files
Create a BagIt
Unzip the BagIt
Unzip the BagIt again, with overwrites

https://beta.hydroshare.org/resource/e007cf2132364c5990ba3246001a403d/
Expected behavior
Resource remains in-tact.
Additional information
Chrome 104.0.5112.101

@ndebuhr Can you explain what Step 2 "Create a zip in the content browser" means? How can I create a zip in the content browser? Do you mean using "Download zipped" from the content browser to download a zip file, then adding the downloaded zip file to the same resource?

@hyi update for you on this issue: @pkdash created a fix and I have approved it (PR #4756)


Enabling FTP for comt?

@jlehrter reports that EPA is blocking sftp on his end, so is wondering whether regular ftp could be allowed.
I tried ftp to comt.sura.org, but it looked like only anonymous ftp was allowed.
@hortenvaldes, would it be possible to enable regular ftp for user sura_ftp with the same password as sftp for user sura_ftp?
Thanks,
Rich

@hotenvaldes, this never got done, right?
Should I close this as a wont fix?


Use a stub to ensure we always test file-not-readable behavior

In Ci the file is still readable after setting 000 permissions, so we're
not testing with the proper context.
@tyler-ball

:+1: thanks for the quick response!


Badgy no longer booting

Hey,
I just received my Badgy Rev 2C a few days ago. I tried to modify the "Hello" sketch but had issues uploading it onto the device. The connection was somewhat unreliable so I had to restart the process a few times until it worked. I noticed that the Badgy sometimes rapidly restarted itself (the display turned white and then the content appeared again) while the Arduino IDE tried to start flashing.
However after one failed attempt to flash a new program it seems like the Badgy is no longer booting at all. The screen doesn't change any more and I am unable to get into the web flash mode, which is still part of the sketch.
When turning the device on I see this:
ets Jan  8 2013,rst cause:2, boot mode:(3,7)

ets_main.c

in the serial monitor. No further output occurs.
Flashing a new sketch seems impossible, as the process stops with esptool.FatalError: Failed to connect to ESP8266: Timed out waiting for packet header.
I also tried using a different cable and a different computer but that did not solve the issue. Any idea what could be wrong here?

Hi @bauerj , are you able to see the serial port show up in the Arduino IDE?

Yes, and when booting up the device I see the output posted earlier in the serial monitor.

It appears to be crashing and stuck in a restart loop, and you are unable to upload a new sketch. Can you confirm if you are using a stable power source? Also, could you check and see if there are any loose connections or components (a picture of the back of Badgy would be really helpful if possible).
Thanks!

Not sure, how to check that. I used a different computer and the issue stayed the same. Measuring the voltage at the ESP-12F shows a stable 3.3V:

At the USB port I measure 5.03V but the pins are too tiny to take a photo while measuring.
Here is what the board looks like:

I can't see any loose connections with my naked eye.

Any idea how I could repair this?

Hi @bauerj , try using the esptool to completely erase the flash and re-uploading the sketch, and make sure you are using the right compile settings. If all else fails, reach out to us on Tindie and we'll send you a new board.

@bauerj You could just pull down RST to low (means connecting a cable between RST and ground) and flash it again. It should work.
When you flash it make sure to do it with the hello example (and don't forget to use the right GxEPD before doing so).


Check if a Validation Error still Exists

How do I check if a validation error still exists?
Is there a property or method that I can use to check for existing validation errors?
It would be very convenient if there is a HasError property (or something similar) that will indicate that there are still validation errors. We can then bind this property to the IsEnabled property of a button and use a converter to invert the value so that the button will only be clickable if there are no validation errors left. Or just return !HasError in the CanButtonName method. :smile:

Just added.
But it is not good idea to use a converter when using MVVM - just add another property to your VM;)

Thank you very much.


Suggestion: Option to record HTTP Header data without downloading

I want to record this data, but I can't do so for titles that are restricted because I can't use wget for those. Could you add support for recording HTTP header data, specifying specific CDN files or tell me how I can use genuine tickets to download with wget?

To see if I understood, you want it to print headers used?
They are base64 encoded and encrypted, the data result is always different because it uses randomly generated keys on tickets

Sorry, I meant the response headers. I'd like to record the response headers for restricted titles.

yeah that's what I'm looking for. I can do it for unrestricted titles by using wget, but not with restricted titles.

i can make them print yea
only want response headers? of all content entries i assume

I'm interested in the Last-Modified dates.

I'll address this once i'm doing with making other code, I'm in the progress of clearing main.cpp, since i'll have to change main.cpp for this, i'll get to it once stuff is done

Thanks

Does referenced commit (957d4d6) do what you need?
If you need a build, ping.

I'll assume so, closing this until said otherwise

It looks like it, thanks. Could you make a build?

Heres this, won't call it a release, i'll consider for testing
ctrcdnfetch.zip
-r for response headers, -n for them too if you don't want to download the title

Thanks, I'll hopefully try this out soon.


Allow users to stop training (instead of cancelling) if there's any model found

Is your feature request related to a problem? Please describe.
Currently, clicking the cancel button will prevent MB from generating a model based on the training so far. This is fine if there isn't a model found yet, but if AutoML has found a model the user may want to use that training result and continue to code generation.
Describe the solution you'd like

"Cancel training" should change to "Stop training"
When "Stop training" is pressed, AutoMLEngine should cancel the training task and use the best iteration so far to generate the model. The status should change to "Finalizing model" (since AutoML needs to save the model to disk)

@LittleLittleCloud Is this possible with AutoML right now? I know we pass the cancellation token on to AutoML. If we cancel, is there still some way to get results back from AutoML?

@briacht
We shall be able to implement "Cancel training"|"Stop training"|"Resume training" under the current AutoML/TrainingConfig architecure, any ideas on how these features should look like?

@briacht
We shall be able to implement "Cancel training"|"Suspend training"|"Resume training" under the current AutoML/TrainingConfig architecure, any ideas on how these features should look like?

@LittleLittleCloud  @beccamc could you help to answer below question?
Validate this issue on https://privategallery.blob.core.windows.net/gallery/refs/heads/main/atom.xml

Windows 10 Enterprise, Version 20H2
ML.Net Model Builder (Preview): <IP_ADDRESS>2301
Microsoft Visual Studio Enterprise 2019: 16.9.4
.Net: 5.0.202

Clicked "Stop training" after noticed the training results, see:

the message changed to "Cancelling";
changed to "x seconds remaining...";
after ran the time, the message changed to "Finalizing model...";
changed to "Training complete";
The question is: the message doesn't change to "Finalizing model" directly after click "Stop training", is that expected?

@LittleLittleCloud Can you help here?

Verified this issue on main branch:
If have training results, then click click "Stop training":
The status changes to "Cancelling...">"Finalizing model...">"Training complete".  @LittleLittleCloud could you help to confirm whether this is the expected experience?

Looking at this more closely, yes I believe this is the correct experience. After training we do a few things to finish training, like generate the code files. That should be what's happening while "Finalizing model" is showing. This is fixed as expected. Thanks Qin!

Thanks confirmation @beccamc


No local .env file

Currently, all .env files are committed to the repo. This isn't a big deal as the URLs and public Pusher client key aren't very sensitive information, but it does make it more difficult to use the project and replace the values with your own configuration.
The catch is that I host this front-end on Netlify, and am not interested in switching hosts. If a new file (such as a netlify.toml) needs to be added to accomodate the new local .env files, it should be a part of this PR and will be greatly appreciated. Any steps on the configuration necessary within the Netlify dashboard would also be extremely helpful, and will get included in the future README as part of a deploy section.

Commit 8d66bd130c655bd8bf81b19b0dc2b8a60a790e52 resolved this issue.


information about extras/export device

How can I create *.csv file template?
How can I get custom Fields vlaue?

Plesae give me more  templates example.

Thank you for your interest in NetBox. GitHub issues are intended for reporting bugs and requesting features, and must be submitted using the template provided here. For general discussion, questions, or assistance with installation issues, please post to our mailing list.


bump update-notifier to fix vulnerability

Hi,
I'm using this package and yarn audit shows one moderate vulnerability due to one dependency:

yarn audit
yarn audit v1.22.21
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ moderate      │ Got allows a redirect to a UNIX socket                       │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ got                                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=11.8.5                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @dotenvx/dotenvx                                             │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @dotenvx/dotenvx > update-notifier > latest-version >        │
│               │ package-json > got                                           │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://www.npmjs.com/advisories/1088948                     │
└───────────────┴──────────────────────────────────────────────────────────────┘
1 vulnerabilities found - Packages audited: 1094
Severity: 1 Moderate

This is because of<EMAIL_ADDRESS>in the dependency, it should be upgraded.
I checked the commit history, and saw this commit from dependabot: https://github.com/dotenvx/dotenvx/commit/dc1454f7c8ee8f8b8a69c1c642f73b2d4c73ac29
But it has been erased some time later by this commit: https://github.com/dotenvx/dotenvx/commit/29dc7a04ac657250826e0330c539785ea12baccb
Could you upgrade update-notifier to clear that vulnerability?
Thanks

we're caught between a rock and a hard place on this one currently. we're not using ESM and we've run into edge cases packaging esm modules up into our binary distributions.
so for now, we have to stay on the common js supported update-notifier 5.1.0. (sindre doesn't support common on any of his modules going forward). we are in the company of many others doing this as you can see from the downloads count here:

we're hopeful to switch all this when node's single executable matures: https://nodejs.org/api/single-executable-applications.html (or we are also considering using deno for packaging)


Testing stochastic

Testing of stochastic simulation for both backends from top to bottom.

@KevinMTO just pushed a couple fixes here. Note that I force pushed to override the proclaimed wrong pre-commit changes. While the ruff corrections were not 100% correct in this case, the general code for creating all the gate matrices that got corrected was highly overcomplicated and inefficient. I fixed that up for the files that ruff touched and now these parts are working and much simpler. I recommend that you carefully check all the other gate implementations that I haven't touched here and also refactor those in the future (need not be in this PR).
There is one more failing test in  test/python/compiler/twodit/entangled_qr/test_entangled_qr.p, which is unrelated to the above changes. I'll leave debugging of that to you.


Use relative path property hint for windows export icon

Closes #25513

I remember seeing the res:// prefix causing issues with rcedit (which is used to change the application icon on Windows). Here in one of my projects, I wrote just icon.ico by hand in the export preset instead

Thanks for the info, I added the path globalization before executing rcedit and it seems to be working.

Thanks!

Now that Godot 3.1 has been released, we don't plan to cherry-pick new features and enhancements to the 3.0 branch, unless there is very strong support in favor of it. Removing cherrypick label for 3.0.


[WIP] Angular 2 Migration Preparation(Draft)

Purpose
The purpose of this issue is to identify the tasks need for Angular 2 migration. So we can identify task dependencies and blockers and also split up the work on these individual tasks.
At this time, this is a living document so feel free to add items or elaborate or question tasks.
This is an open task for anyone to contribute, so we can just start to get our hands around all the migration issues and create a plan.
Tasks

[x] 1. NPM packaging (replacing bower)
[x]     * Yarn (via 5.1+ --yarn option) is probably a better replacement (and it is already based on npm packages) since Rails 5.1+ uses it by default as dependency management (and it handles both bower and  npm) possible replacement with yarn since it handles both bower and npm?
[x] 3. Webpack packaging (for production build)

[x] * Phase 1: custom webpack solution for fine release
[ ] * Phase 2: solved by webpacker  and Rails 5.1+

[ ] 4. Configure dev server strategy for web app auto-reload for quick development (webpack dev-server perhaps?) -- solved by webpacker ?
[ ] 5. NgModules structure (what ngModules will we have? (common/feature/provider)
[ ] 6. Directory structure (do we wish to change the organization of things)
[ ] 7. Assets (do we handle assets differently with webpack (because we can))
[ ] 8. Do we use Rails Sprockets (asset pipeline) or not (with webpack)?
[x] 9. Do Websockets via cable still work in ng2?
[ ] 10. Can we use ng-cli?
[x] 11. Rx.js version moves from 4 to 5 with ng2 and the syntax changes quite a bit

Does our limited existing ngrx stuff still work?

[ ] 12. Angular Routing (we use routing minimally)

UI Router 1.0.0+ to bridge to New Angular 2 router

[ ] 14. I18n (gettext_i18n_rails_js for ng2?)
[ ] 15. Is there issues with some of the javascript 3rd party libraries (which there are many)

Recommendation
Use Rails 5.1+ for both webpack and Yarn (via webpacker) to make their way into Rails as a standard. This should not stop prototypes(using the above solutions), just that we don’t want to create a non-standard solution for the future.
Starting with ngUpgrade for an interim period should provide a less painful path forward as both Angular 1 and Angular 2 can coexist (albeit at a cost of both runtimes); until everything can be fully converted to Angular 2.
Angular 1.x Best Practices (TBD)
This is probably best off in its own issue as it could be lengthy and have many of its own conversations.
Next
Surely, there are things missing here, as the migration is large and complex, however, this should serve as a starting place. Please edit as needed so we can divide these up and conquer.

@martinpovolny here is the starter Angular 2 migration issue; feel free to edit...
CC: @himdel @skateman @dclarizio

@mtho11 actioncable already works well in SSUI and I don't think there will be any compatibility issues with ng2

@mtho11 great list.. just adding some random thoughts.. :)
For point one, we already have https://github.com/ManageIQ/manageiq/pull/12581
And, maybe you mean it that way, but.. I'd rather do the webpack transition in this release, separate from any Angular 2 efforts. So that we don't move to webpack & angular 2 at the same time :).
And agreed we definitely need to look into webpacker since it will be the default in rails 5.1.
Another thing, ngUpgrade should probably never get into a production build. Meaning we should ideally start right after fine gets its own branch, and finish before an RC.
Probably agreed on the UI router, although since we're still not using any frontend routing, if at that point we still don't, it may make sense to go with the new default router.. Especially since 1.6 should have a router closer to ng2..
And i18n may be a toughie.. but some gettext version will exist :).

@himdel sounds like a smart thing to do webpack in this release so like you said to "isolate the Angular 2 efforts".

Rx.js version moves from 4 to 5 with ng2 and the syntax changes quite a bit
Does our limited existing ngrx stuff still work?

Created https://github.com/ManageIQ/manageiq/pull/13255 to address the rx update (but depends on npm)

@mtho11 can you please close this and reopen on the ui-classic repo?  Thx, Dan

@dclarizio sure. I don't suppose there is any way to preserve the comments though?

@mtho11 Maybe just copy them into an initial comment?

This issue was moved to ManageIQ/manageiq-ui-classic#148

FYI: this issue was moved from repo to repo with:
https://github-issue-mover.appspot.com/


Can't connect to a published port from the outside world.

First, Thank all of you for this project, I really like it.
I play  with the live version:  http://play-with-docker.com. But  I can't connect to a published port from the outside world ,  although I  follow the FAQ in  the README.md.

How  can I do this?
Thanks.

@bingohuang try this:
docker run -p 8080:80 nginx
You'll see that a small badge icon (image below) will appear next to the instance IP

If you click that link, you'll be able to access the instance published services.


sc-5245 GDS User UI: implement  unit tests for review page

Type of change

[ ] bug fix
[ ] new feature
[ ] documentation
[x] unit tests

Scope of changes
GDS User UI: implement  unit tests for review page
Acceptance criteria
All written tests are in the CertificateReview folder
Author checklist

[x] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[x]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[x]  I have moved the associated ShortCut or Jira ticket to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #543 (44f25ba) into main (d23f17b) will decrease coverage by 1.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   46.84%   44.97%   -1.88%
==========================================
  Files         234      470     +236
  Lines       11737    13755    +2018
  Branches      610     1080     +470
==========================================
+ Hits         5498     6186     +688
- Misses       5270     6594    +1324
- Partials      969      975       +6

Impacted Files
Coverage Δ

...ules/dashboard/certificate/lib/validationSchema.ts
64.86% <ø> (ø)

...c/components/Section/PasswordResetConfirmation.tsx
0.00% <0.00%> (ø)

...-user-ui/src/components/BasicDetailsForm/index.tsx
80.00% <0.00%> (ø)

web/gds-user-ui/src/hoc/withRHF.tsx
0.00% <0.00%> (ø)

...user-ui/src/components/ui/DeleteButton.stories.tsx
0.00% <0.00%> (ø)

web/gds-user-ui/src/utils/address-utils.tsx
48.00% <0.00%> (ø)

...s-user-ui/src/components/Section/Login.stories.tsx
0.00% <0.00%> (ø)

...r-ui/src/layouts/SimpleDashboardLayout.stories.tsx
0.00% <0.00%> (ø)

web/gds-user-ui/src/constants/countries.ts
100.00% <0.00%> (ø)

...ds-user-ui/src/components/MissingRequire/index.tsx
0.00% <0.00%> (ø)

... and 227 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23f17b...44f25ba. Read the comment docs.


chown group to save file

@orta-sanz I'm not sure what you mean, exactly... could you please elaborate?

I think this can be considered as a genuine error. This should not be here , I'm sorry @Alhadis

Erm... okay...


Fix typo in RaknetError and set motd methods

Typo in RaknetError:
I renamed BindAdressError to BindAddressError
Set motd methods:
Fix of #19 issue
I created motd_receiver and motd_sender. Every iteration in RaknetListener::listen() it will check if there is message in motd_receiver. If there is, server will use updated motd and if not will use last recived.
Also set_motd() and set_full_motd() methods now will also send message to the motd_sender and if it wasn't successful return RaknetError::SetMotdError

LGTM!


Save As - Save a file as a different name

Split out from #108

@PropGit when Save As is triggered, what would you like to show in the filename box?  Currently it will show the active file name (see image below for file "a test"). Does that work?  Or would you like it to show "activeFilename copy"? Or "activeFilename1"? Or continue on with the "untitled#" scheme? Something else?

@drquinn Thanks for asking.  Since the common workflow is for someone to want to save as to a similar (but different) name, I'd like to to show the active name (as you now have it) with the field focused and with the cursor to the right of the name.
Also, this reminds me of a needed feature... When the user clicks the Save As button from this overlay, the Save As feature should always prompt with a confirmation if the user uses a filename that already exists (ie: "File '' already exists.  Overwrite anyway?" with Overwrite and a Cancel button options).
I can make that a separate linked issue if you want.

@jeffam70 ok great, I'll set that up for filename.
I think another issue would be good for the overwrite prompt and dialog that would go along with it.

Tested, but the cursor doesn't end up to the right of the filename.  Will make another issue for this.


Add content from the Stolen Fate Player's Guide

The source should probably be "Pathfinder: Stolen Fate Player's Guide" to match the others.


NglParseError appears when using "$PWD/src", but not "$PWD"

For some reason, I am getting slightly inconsistent messages when I am running the linter within my 'src' directory vs running it in my project's directory.

Frankly, the output from running in 'src' directory is a bit more complete. I'd love to see the NglParseError always, but only see it when running in 'PWD/src', which is a bit more clunky.

Running from 'PWD' (less output)
$ docker run --rm -u "$(id -u):$(id -g)" -w=/tmp -v "$PWD":/tmp nvuillam/npm-groovy-lint --failon warning --verbose src
/tmp/src/edu/uoregon/nts/DockerImage.groovy
  9     info     Class should be marked with one of @GrailsCompileStatic, @CompileStatic or @CompileDynamic  CompileStatic
  9     warning  The class edu.uoregon.nts.DockerImage implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  33    warning  Violation in class DockerImage. The method 'buildAndPush' matches the regular expression /(build.*|create.*)/ and does not appear in a class matching /*.Builder/  FactoryMethodName
  33    info     Method "buildAndPush" has a dynamic return type  MethodReturnTypeRequired
  38    info     Method "getDockerTags" has a dynamic return type  MethodReturnTypeRequired
  42    warning  Violation in class DockerImage. The method 'build' matches the regular expression /(build.*|create.*)/ and does not appear in a class matching /*.Builder/  FactoryMethodName
  42    info     Method "build" has a dynamic return type  MethodReturnTypeRequired
  60    warning  The line exceeds 120 characters. The line is 133 characters.  LineLength
  63    warning  The line exceeds 120 characters. The line is 146 characters.  LineLength
  68    info     Method "push" has a dynamic return type  MethodReturnTypeRequired
  77    info     Method "dockerImageName" has a dynamic return type  MethodReturnTypeRequired
  100   info     Method "getDockerTagsCLI" has a dynamic return type  MethodReturnTypeRequired
  104   info     Method "pushGitTag" has a dynamic return type  MethodReturnTypeRequired
  109   info     Method "pushDockerImage" has a dynamic return type  MethodReturnTypeRequired
  123   info     Method "properties" has a dynamic return type  MethodReturnTypeRequired

/tmp/src/edu/uoregon/nts/PythonPackage.groovy
  10    info     Class should be marked with one of @GrailsCompileStatic, @CompileStatic or @CompileDynamic  CompileStatic
  10    warning  The class edu.uoregon.nts.PythonPackage implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  21    warning  The line exceeds 120 characters. The line is 121 characters.  LineLength
  43    info     When an if statement block ends with a return statement the else is unnecessary  UnnecessaryElseStatement
  58    info     Method "runTests" has a dynamic return type  MethodReturnTypeRequired
  83    info     Method "publishToPyPI" has a dynamic return type  MethodReturnTypeRequired
  98    info     Method "publishToUOPackageIndex" has a dynamic return type  MethodReturnTypeRequired
  138   info     Method "publish" has a dynamic return type  MethodReturnTypeRequired

/tmp/src/edu/uoregon/nts/Defaults.groovy
  11    info     Class should be marked with one of @GrailsCompileStatic, @CompileStatic or @CompileDynamic  CompileStatic
  11    warning  The class edu.uoregon.nts.Defaults implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  19    info     Method "bitbucketBuildParameters" has a dynamic return type  MethodReturnTypeRequired
  26    warning  The line exceeds 120 characters. The line is 126 characters.  LineLength
  35    warning  The line exceeds 120 characters. The line is 125 characters.  LineLength
  41    warning  The line exceeds 120 characters. The line is 164 characters.  LineLength
  51    warning  Violation in class Defaults. The method 'buildDiscarder' matches the regular expression /(build.*|create.*)/ and does not appear in a class matching /*.Builder/  FactoryMethodName
  51    info     Method "buildDiscarder" has a dynamic return type  MethodReturnTypeRequired
  60    info     Method "cronNightly" has a dynamic return type  MethodReturnTypeRequired
  64    info     Method "cronWeeknights" has a dynamic return type  MethodReturnTypeRequired

/tmp/src/edu/uoregon/nts/Utilities.groovy
  6     info     Class should be marked with one of @GrailsCompileStatic, @CompileStatic or @CompileDynamic  CompileStatic
  6     warning  The class edu.uoregon.nts.Utilities implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  14    info     Method "convertGitOriginSSH" has a dynamic return type  MethodReturnTypeRequired
  26    info     Method "pushGitTag" has a dynamic return type  MethodReturnTypeRequired
  46    warning  Method parameter [gitCommitMessage] is never referenced in the method releaseCandidateFromLatestGitCommit of class edu.uoregon.nts.Utilities  UnusedMethodParameter
  51    info     Line ends with whitespace characters  TrailingWhitespace
  54    info     The public static method releaseCandidateFromGitCommit in class edu.uoregon.nts.Utilities is declared after a public instance method  StaticMethodsBeforeInstanceMethods
  71    info     Method "replaceInFile" has a dynamic return type  MethodReturnTypeRequired
  96    info     When an if statement block ends with a return statement the else is unnecessary  UnnecessaryElseStatement

/tmp/src/edu/uoregon/nts/LintTinker.groovy
  9     info     Line ends with whitespace characters  TrailingWhitespace
  13    info     Line ends with whitespace characters  TrailingWhitespace

npm-groovy-lint results in 5 linted files:
┌─────────┬───────────┬─────────────┐
│ (index) │ Severity  │ Total found │
├─────────┼───────────┼─────────────┤
│    0    │  'Error'  │      0      │
│    1    │ 'Warning' │     14      │
│    2    │  'Info'   │     30      │
└─────────┴───────────┴─────────────┘
Failure: 0 error(s) have been found
 14 warning(s) have been found

Running from 'PWD/src' (more output)
 docker run --rm -u "$(id -u):$(id -g)" -w=/tmp -v "$PWD/src":/tmp nvuillam/npm-groovy-lint --failon warning --verbose
/tmp/edu/uoregon/nts/Defaults.groovy
  11    info     Class should be marked with one of @GrailsCompileStatic, @CompileStatic or @CompileDynamic  CompileStatic
  11    warning  The class edu.uoregon.nts.Defaults implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  19    info     Method "bitbucketBuildParameters" has a dynamic return type  MethodReturnTypeRequired
  26    warning  The line exceeds 120 characters. The line is 126 characters.  LineLength
  35    warning  The line exceeds 120 characters. The line is 125 characters.  LineLength
  41    warning  The line exceeds 120 characters. The line is 164 characters.  LineLength
  51    warning  Violation in class Defaults. The method 'buildDiscarder' matches the regular expression /(build.*|create.*)/ and does not appear in a class matching /*.Builder/  FactoryMethodName
  51    info     Method "buildDiscarder" has a dynamic return type  MethodReturnTypeRequired
  60    info     Method "cronNightly" has a dynamic return type  MethodReturnTypeRequired
  64    info     Method "cronWeeknights" has a dynamic return type  MethodReturnTypeRequired

/tmp/edu/uoregon/nts/DockerImage.groovy
  9     info     Class should be marked with one of @GrailsCompileStatic, @CompileStatic or @CompileDynamic  CompileStatic
  9     warning  The class edu.uoregon.nts.DockerImage implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  33    warning  Violation in class DockerImage. The method 'buildAndPush' matches the regular expression /(build.*|create.*)/ and does not appear in a class matching /*.Builder/  FactoryMethodName
  33    info     Method "buildAndPush" has a dynamic return type  MethodReturnTypeRequired
  38    info     Method "getDockerTags" has a dynamic return type  MethodReturnTypeRequired
  42    warning  Violation in class DockerImage. The method 'build' matches the regular expression /(build.*|create.*)/ and does not appear in a class matching /*.Builder/  FactoryMethodName
  42    info     Method "build" has a dynamic return type  MethodReturnTypeRequired
  60    warning  The line exceeds 120 characters. The line is 133 characters.  LineLength
  63    warning  The line exceeds 120 characters. The line is 146 characters.  LineLength
  68    info     Method "push" has a dynamic return type  MethodReturnTypeRequired
  77    info     Method "dockerImageName" has a dynamic return type  MethodReturnTypeRequired
  100   info     Method "getDockerTagsCLI" has a dynamic return type  MethodReturnTypeRequired
  104   info     Method "pushGitTag" has a dynamic return type  MethodReturnTypeRequired
  109   info     Method "pushDockerImage" has a dynamic return type  MethodReturnTypeRequired
  123   info     Method "properties" has a dynamic return type  MethodReturnTypeRequired

/tmp/edu/uoregon/nts/LintTinker.groovy
  8     error    Invalid method declaration: LintTest @ line 8, column 5.  NglParseError
  9     info     Line ends with whitespace characters  TrailingWhitespace
  13    info     Line ends with whitespace characters  TrailingWhitespace

/tmp/edu/uoregon/nts/PythonPackage.groovy
  10    info     Class should be marked with one of @GrailsCompileStatic, @CompileStatic or @CompileDynamic  CompileStatic
  10    warning  The class edu.uoregon.nts.PythonPackage implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  21    warning  The line exceeds 120 characters. The line is 121 characters.  LineLength
  43    info     When an if statement block ends with a return statement the else is unnecessary  UnnecessaryElseStatement
  58    info     Method "runTests" has a dynamic return type  MethodReturnTypeRequired
  83    info     Method "publishToPyPI" has a dynamic return type  MethodReturnTypeRequired
  98    info     Method "publishToUOPackageIndex" has a dynamic return type  MethodReturnTypeRequired
  138   info     Method "publish" has a dynamic return type  MethodReturnTypeRequired

/tmp/edu/uoregon/nts/Utilities.groovy
  6     info     Class should be marked with one of @GrailsCompileStatic, @CompileStatic or @CompileDynamic  CompileStatic
  6     warning  The class edu.uoregon.nts.Utilities implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  14    info     Method "convertGitOriginSSH" has a dynamic return type  MethodReturnTypeRequired
  26    info     Method "pushGitTag" has a dynamic return type  MethodReturnTypeRequired
  46    warning  Method parameter [gitCommitMessage] is never referenced in the method releaseCandidateFromLatestGitCommit of class edu.uoregon.nts.Utilities  UnusedMethodParameter
  51    info     Line ends with whitespace characters  TrailingWhitespace
  54    info     The public static method releaseCandidateFromGitCommit in class edu.uoregon.nts.Utilities is declared after a public instance method  StaticMethodsBeforeInstanceMethods
  71    info     Method "replaceInFile" has a dynamic return type  MethodReturnTypeRequired
  96    info     When an if statement block ends with a return statement the else is unnecessary  UnnecessaryElseStatement

npm-groovy-lint results in 5 linted files:
┌─────────┬───────────┬─────────────┐
│ (index) │ Severity  │ Total found │
├─────────┼───────────┼─────────────┤
│    0    │  'Error'  │      1      │
│    1    │ 'Warning' │     14      │
│    2    │  'Info'   │     30      │
└─────────┴───────────┴─────────────┘
Failure: 1 error(s) have been found
 14 warning(s) have been found

a new version solving many issues is coming soon :)

As of Dec 7th, I can confirm this seems fixed! I can now run docker using only my 'src' directory, instead of my whole 'current working directory.'

Please pardon all the 'warning' and 'info' messages in the output below 😅

The "LintTest.groovy" source code file, with an error (missing return type)

class MyClass {
    Foo() {  // Foo is missing "return type!"

    }
}

The output definitely indicates the "Invalid method declaration: Foo" parse error:
$ docker run --rm -u "$(id -u):$(id -g)" -w=/tmp -v "$PWD":/tmp nvuillam/npm-groovy-lint --failon warning --verbose src
/tmp/src/edu/uoregon/nts/Defaults.groovy
  11    warning  The class edu.uoregon.nts.Defaults implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  15    info     "script" parameter of "<init>" method is dynamically typed  MethodParameterTypeRequired

/tmp/src/edu/uoregon/nts/DockerImage.groovy
  9     warning  The class edu.uoregon.nts.DockerImage implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  100   info     "gitBranch" parameter of "getDockerTagsCLI" method is dynamically typed  MethodParameterTypeRequired
  104   info     "scmVars" parameter of "pushGitTag" method is dynamically typed  MethodParameterTypeRequired
  156   info     "dockerImage" parameter of "prepareDockerTags" method is dynamically typed  MethodParameterTypeRequired
  156   info     "gitBranch" parameter of "prepareDockerTags" method is dynamically typed  MethodParameterTypeRequired

/tmp/src/edu/uoregon/nts/LintTest.groovy
  3     error    Invalid method declaration: Foo @ line 3, column 5.  NglParseError

/tmp/src/edu/uoregon/nts/PythonPackage.groovy
  4     info     The [java.nio.file.Files] import is never referenced  UnusedImport
  5     info       UnnecessaryGroovyImport
  5     info     The [java.io.File] import is never referenced  UnusedImport
  6     info     The [java.nio.file.Path] import is never referenced  UnusedImport
  7     info     The [java.util.stream.Stream] import is never referenced  UnusedImport
  8     info     The [java.util.stream.Collectors] import is never referenced  UnusedImport
  14    warning  The class edu.uoregon.nts.PythonPackage implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  27    info     "sourceDir" parameter of "<init>" method is dynamically typed  MethodParameterTypeRequired
  27    info     "versionFile" parameter of "<init>" method is dynamically typed  MethodParameterTypeRequired
  27    warning  Number of parameters in constructor of class edu.uoregon.nts.PythonPackage exceeds maximum allowed (5).  ParameterCount
  41    info     The statement on line 41 in class edu.uoregon.nts.PythonPackage is at the incorrect indent level: Expected column 9 but was 11  Indentation
  46    warning  Violation in class PythonPackage. The method 'buildPackage' is named like a builder method but has a void return type  BuilderMethodWithSideEffects
  46    info     "packageType" parameter of "buildPackage" method is dynamically typed  MethodParameterTypeRequired
  55    info     Line ends with whitespace characters  TrailingWhitespace
  55    info     The String 'dist/*,dist-hyphenated/*' can be wrapped in single quotes instead of double quotes  UnnecessaryGString
  72    info     Line ends with whitespace characters  TrailingWhitespace
  132   info     Line ends with whitespace characters  TrailingWhitespace
  154   info     setPackageVersion("${this.getPackageVersion()}${releaseCandidateSuffix}") can probably be rewritten as packageVersion = "${this.getPackageVersion()}${releaseCandidateSuffix}"  UnnecessarySetter

/tmp/src/edu/uoregon/nts/Utilities.groovy
  6     warning  The class edu.uoregon.nts.Utilities implements Serializable but does not define a serialVersionUID  SerializableClassMustDefineSerialVersionUID
  46    warning  Method parameter [gitCommitMessage] is never referenced in the method releaseCandidateFromLatestGitCommit of class edu.uoregon.nts.Utilities  UnusedMethodParameter
  51    info     Line ends with whitespace characters  TrailingWhitespace
  54    info     The public static method releaseCandidateFromGitCommit in class edu.uoregon.nts.Utilities is declared after a public instance method  StaticMethodsBeforeInstanceMethods

npm-groovy-lint results in 5 linted files:
┌─────────┬───────────┬─────────────┐
│ (index) │ Severity  │ Total found │
├─────────┼───────────┼─────────────┤
│    0    │  'Error'  │      1      │
│    1    │ 'Warning' │      7      │
│    2    │  'Info'   │     22      │
└─────────┴───────────┴─────────────┘
Failure: 1 error(s) have been found
 7 warning(s) have been found

TIL that DockerHub doesn't really support 'digests' as of today... but I am using the docker image that was deployed '14 hours ago.'
$ date
Thu 07 Dec 2023 01:29:00 PM PST

$ docker image ls | grep groovy
nvuillam/npm-groovy-lint                    latest               9cedc4a8018d   14 hours ago    406MB
codenarc/codenarc                           2.0.0-groovy2.5.12   d5a9c8f796ed   3 years ago     212MB

Thanks for your feedback:)


Function facebook_posts in page

I novice in Grav.
I install Facebook plugin, next insert function in page (default) - {{ facebook_posts() }},
get "raw" html text in browser.
"

Some text
   14.08.2017 klo 08:44
....
"

have you enabled twig processing in the settings ?

yes
after add " |raw " begin better, but leave html artefacts
"
..
br />
...

"
http://test.slava-yoga.com.ua/ru
function {{ facebook_events()|raw }}  - work
http://test.slava-yoga.com.ua/ru
function {{ facebook_album() }} - not
http://test.slava-yoga.com.ua/ru/foto

I can't check this until next week - I am without computer until Monday

When the gantry plug-in is turned on, the Facebook plug-in does not work :(

I have exactly the same issue. Pretty frustrating when you see all the content in HTML but not interpreted.

@snzhuravlev I see that on your website you've succeed to resolve the issue. How have you resolved it for your events please?

@loopion I remove Gantry template and plugin

I don't have knowledge about using this plugin with Gantry (no Gantry knowledge). Maybe ask this from maker of Gantry plugin ?

@mikahanninen You need to use |raw filter for any output with HTML in it. Grav does not use auto-escaping by default, but Gantry forces it to turn on for improved security. This is something that will likely be forced in Grav 2.0 as well.

Okay I will debug this issue with auto-escaping on.

Once I've added the |raw it correctly displayed the feeds except for the

Is there a way to have this part too correctly interpreted?
Thanks @mahagr and @mikahanninen for your quick replies.

@loopion do you have page that I view ? or can you share the page contents ?

Just sent you an email with it.
The album works perfectly fine, so thank you for this great plugin!

Please tell me if release 1.6.2 fixes your problems ? I tested all functions with |raw filter and they worked.
{{ facebook_album()|raw }}
{{ facebook_posts()|raw }}
{{ facebook_events()|raw }}

Everything works now like a charm! Thanks a lot for this update and making it compatible with upcoming version of Grav.


TransactionRollbackError with BetterSQLite3

When performing a rollback inside a transaction I get an error:
- error TransactionRollbackError [DrizzleError]: Rollback
    at BetterSQLiteTransaction.rollback (webpack-internal:///(rsc)/./node_modules/.pnpm/drizzle-orm@0.28.5_@types+better-sqlite3@7.6.4_better-sqlite3@8.5.2/node_modules/drizzle-orm/session-001d24ad.mjs:1622:15)
    at Function.eval (webpack-internal:///(rsc)/./src/lib/db/createWorkout.ts:21:18)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async createWorkout (webpack-internal:///(rsc)/./src/lib/db/createWorkout.ts:15:17)
    at async handler (webpack-internal:///(rsc)/./src/app/api/workouts/create/route.ts:32:17)
    at async eval (webpack-internal:///(rsc)/./node_modules/.pnpm/next@13.4.19_@babel+core@7.22.10_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/server/future/route-modules/app-route/module.js:254:37)

Packages:
"drizzle-kit": "^0.19.13",
"drizzle-orm": "^0.28.5",
"better-sqlite3": "^8.5.2",
"next": "13.4.19",

Code snippet:
// Start transaction
  const res = await db.transaction(async (tx) => {

    // Insert workout
    const [{ id: workoutId }] = await tx
      .insert(workouts)
      .values({
        date: workout.date,
        userId,
      }).returning()

    await tx.rollback()
    return
}

Expected results:

a new workout should not be inserted

Actual results:

a new workout is inserted

Originally posted by @liquiFruit in https://github.com/drizzle-team/drizzle-orm/discussions/1170

I'm facing the same issue
packages.json
"drizzle-orm": "^0.28.6",
"pg": "^8.11.2",
"drizzle-kit": "^0.19.12"

same here, using
  "drizzle-kit": "^0.19.13",
  "drizzle-orm": "^0.28.6",
  "postgres": "^3.3.5"

Same issue here using libsql; I am trying to roll the transaction back after running some custom embedded business logic (as per the docs)
DrizzleError: Rollback
[0]       at new DrizzleError (/home/adicco/Code/dana-list-bun-htmx/node_modules/drizzle-orm/alias-cf8e03cd.mjs:379:8)
[0]       at new TransactionRollbackError (/home/adicco/Code/dana-list-bun-htmx/node_modules/drizzle-orm/alias-cf8e03cd.mjs:391:8)
[0]       at rollback (/home/adicco/Code/dana-list-bun-htmx/node_modules/drizzle-orm/session-afae3551.mjs:1579:14)

"drizzle-orm": "^0.28.6",
"drizzle-kit": "^0.19.13",
"@libsql/client": "^0.3.5",


Out of memory with phi3:3.8b-mini-128k-instruct

OS: Debian 12
Running only on CPU, 128GB RAM
When starting Web-LLM.py i'm getting error: Ollama API request failed with status 500: {"error":"model requires more system memory (98.8 GiB) than is available (96.8 GiB)"
The model is "phi3:3.8b-mini-128k-instruct-q4_K_M" and is created as described:
FROM phi3:3.8b-mini-128k-instruct-q4_K_M
PARAMETER num_ctx 38000
When using ollama run phi3:3.8b-mini-128k-instruct-q4_K_M it takes only 5GB RAM
When using ollama run research-phi3 (just created from modelfile) it takes 50GB RAM
Anyone has idea why it need 50GB when started aside and even 100GB when using Web-LLM?

Try restarting in all my testing this happened to me once, also when you made it from the model file try to decrease the context size a little bit if it's a problem that isn't solved by restart. In my experience my restart fixed it, but my computers weird, but based on the error message you only need like a couple gigs more so if you decrease the context in the model file slightly it'll probably fix it!


Update quickstart guide

It appears that lambda as well as a few of the other late added features have not yet made the quickstart guide.   This should be updated.

Additionally, i see from the change log that there its faster to pass arrays to-and-from python/java. I did not find any documentation about this. Can we get some code samples for this?
In my usecase, I am trying to pass a byte array from java to python and back (as a byte array). Any pointers would help.
Blurb from documentation:

Improved speed on transfer of lists, tuples, buffers to arrays of Java primitives by a factor of 4 to 100 depending on the data type. The conversion uses optimized path for memory buffers, rather than the Sequence API. When a Python buffer is encountered only the first element is checked for conversion as Python buffers are homogeneous.
Corrected symbol problem with Python 3.5.3. PySlice_Unpack was introduced in a later patch release and should not have been used.


Exit at first failed command

Today, when a command is executed across multiple stacks the status of each stack isn't checked. This means if one returns an error, the command continues processing across the other stacks.
This PR updates execute_stacks_command  exit at the first error.
This allows CI processes to run validate (or other commands) across a range of stacks and be confident that an errors result in a failed build.

Hi @craigforster
Thanks for the PR.
It seems our behaviour is a bit inconsistent. I don't think we want to fail immediately if there's an invalid stack, however I do expect that we return with an exit code of something other than 0 which doesn't seem to always be the case. However it seems as though in other scenarios we do fail fast when I would expect us not to.
Scenario 1: Unable to resolve parameter
Outcome: Fail fast, exit code 1
Scenario 2: Empty/blank parameter
Outcome: No failure, exit code 0
This puts us in an unfortunate position of choosing to keep existing inconsistent behaviour or include a breaking change and have to bump the major version. I'm inclined to keep inconsistent behaviour for now, but at least fix the exit code so it's what we expect.
It'd be good to have a failing test to replicate this behaviour as well as the behaviour for the first scenario, so we ensure we avoid potentially breaking changes.

Hi @patrobinson
I'll do my best to get up to speed enough on the code to add some tests -- fair warning, I'm not particularly experienced with Ruby.  Is there a particular spec you'd like me to add the test or tests to?

Another thought I had was to preserve the default behavior by default, and add a global option to enable fail-fast or the like.  This would preserve backwards compatibility and avoid a major version bump.

I'm going to close this PR, iterate locally, and then open a fresh one when I have a solution I'm happy with.  Any pointers to existing tests would be definitely appreciated.

@craigforster having a fail fast option would help retain the same behaviour but give you what you want so I'm in favour of it.
I've written some failing tests on this branch https://github.com/envato/stack_master/tree/validate-exit-code. Feel free to cherry-pick them into your branch

Amazing, thanks!


kube2iam resources improvement

After 2y running this we faced some issues with the default kube2iam resources values.
CPU limits cause applications to run up to 100% slower, in this case can end in race conditions while touching the ip tables and also in timeouts.
Default CPU requests and memory are not enough for +50 nodes.
You can run the next query in prometheus to see if your kube2iam instances are throttling:
 100
  * sum by(container, pod, namespace) (increase(container_cpu_cfs_throttled_periods_total{container!=""}[5m]))
  / sum by(container, pod, namespace) (increase(container_cpu_cfs_periods_total[5m]))
  > 25

/assign @davidmccormick

/lgtm

/approved


Listing - Select expiry date

I have to click the arrow (within the red square); all the space around the icon isn't selectable. It would be a great UX improvement if I could click anywhere in that square to toggle the calendar.

Difficult to do exactly what you're asking for since the arrow is a part of the input, however I did manage to make the click area larger, which should help.


Simplify MNI coordinates input option

It is difficult to insert own MNI coordinates. Sometimes I need two attempts to enter the coordinates. Is it possible to make this easier by maybe making 3 boxes to click in?
Addition: Afterwards you get the associated area. Is it possible that the information box on the left opens directly to the area? Without clicking on it again? I can imagine that this will be more self-explaining.
Alternatively: When entering the coordinates, the side bar opens and the same happens as with the "right click" - the areas to the coordinate are show up with their probability, since the maps overlap.

It is difficult to insert own MNI coordinates. Sometimes I need two attempts to enter the coordinates. Is it possible to make this easier by maybe making 3 boxes to click in?

we will see what can be done

Addition: Afterwards you get the associated area. Is it possible that the information box on the left opens directly to the area? Without clicking on it again? I can imagine that this will be more self-explaining.

Do you mean the following:
current:
1/ user enters MNI 152 coord in text box
2/ viewer navigates to the coordinate
3/ user left click the center of the view port to select the ROI
desired/expected:
1/ user enters the MNI 152 coord in text box
2/ viewer navigates to the coordinate AND if overlaps with a region, selects the region
?

Alternatively: When entering the coordinates, the side bar opens and the same happens as with the "right click" - the areas to the coordinate are show up with their probability, since the maps overlap.

This is an interesting suggestion and usecase. Since we developed the two features separately, they do not interact in any way at the moment. But, IMO, it's only natural to see some interactions between these two components.

I made you an example, to show you what could help

since v2.14.0, the proposed change has been implemented (see screenshot)