Move service definition from Knots to Adapters configuration

The goal of this task is to move services section from Knot configuration to Adapter configuration.
Example:
current
    "com.cognifide.knotx.knot.service.ServiceKnotVerticle": {
     "config": {
        "address": "knotx.knot.service",
        ...
        "services": [
          {
            "name" : "first-service",
            "address" : "knotx.adapter.service.http",
            "params": {
              "path": "/service/mock/first.json"
            },
            "cacheKey": "first"
          },
          {
            "name" : "second-service",
            "address" : "knotx.adapter.service.http",
            "params": {
              "path": "/service/mock/second.json"
            }
          }
        ]
      }
    },

...

"com.cognifide.knotx.adapter.service.http.HttpServiceAdapterVerticle" :{
      "config": {
        "address": "knotx.adapter.service.http",
         ...
        "services": [
          {
            "path": "/service/mock/.*",
            "domain": "localhost",
            "port": 3000,
            "allowed.request.headers": [
              "Content-Type",
              "Cookie",
              "X-*"
            ]
          },
          {
            "path": "/service/.*",
            "domain": "localhost",
            "port": 8080,
            "allowed.request.headers": [
              "Content-Type",
              "X-*"
            ]
          }
        ]
      }
    },

Should be configured after the change like:
knots.json
    "com.cognifide.knotx.knot.service.ServiceKnotVerticle": {
     "config": {
        "address": "knotx.knot.service",
         ...
      }
    },

adapters.json
"com.cognifide.knotx.adapter.service.http.HttpServiceAdapterVerticle" :{
      "config": {
        "address": "knotx.adapter.service.http",
        ...
        "endpoints": [
          {
            "path": "/service/mock/.*",
            "domain": "localhost",
            "port": 3000,
            "allowed.request.headers": [
              "Content-Type",
              "Cookie",
              "X-*"
            ]
          },
          {
            "path": "/service/.*",
            "domain": "localhost",
            "port": 8080,
            "allowed.request.headers": [
              "Content-Type",
              "X-*"
            ]
          }
        ],
        "variants": [
          {
            "name" : "first-service",
            "params": {
              "path": "/service/mock/first.json"
            },
            "cacheKey": "first"
          },
          {
            "name" : "second-service",
            "params": {
              "path": "/service/mock/second.json"
            }
          }
        ]
      }
    },

This task depends on #194 .
In order to Knot can see Adapters variants, AdaptersRegistry mechanism should be implemented.
The idea is, that every Knot registers to AdapterRegistry as an Observer and every Adapter registers as an Observable. When new a Adapter is created it simply notifies all Knots that it can support defined variants and can be requested under defined address on the Event Bus.

Please see ServiceDiscovery mechanism provided in Vertx (http://vertx.io/docs/vertx-service-discovery/java/).

Configuration concept is going to be re-written in the milestone: backpressure-and-configs. Follow the updated wiki docks for more details.


Yolo v8 on OAK-D camera

I'm trying to run yolo model on OAK-D camera, so i created a "YoloSpatialNetworkDetection" node, to detect objects  and calculate theirs coordinates in the space, the issue is when i execute the code, it runs for just one second and then it crash.
you gonna find a copy of the code attached with the poste
thank you
![Capture d’écran du 2024-05-09 23-27-01](https://github.com/luxonis/depthai-experiments/assets/169404051/ea7e8772-8edc-404e-bdca-9b3291a9bad7
Projet_OAK.zip

Solved https://discuss.luxonis.com/d/4704-yolospatialdetectionnetwork


Fix data type passed in Global WorkQueue for getDatasetLocations()

Fixes #11861 (complement to https://github.com/dmwm/WMCore/pull/11810)
Status
ready
Description
When resolving dataset location for a data with likely no location, pass in a list object instead of a string.
Is it backward compatible (if not, which system it affects?)
YES
Related PRs
Fixes a mistake from https://github.com/dmwm/WMCore/pull/11810
External dependencies / deployment changes
None

@vkuznet Valentin, that approach is fine with me as well. I have updated this PR to accept either a string or a list of strings in getDatasetLocations(). Please have another look.


Image Exception -- can't save assets from front-end entry form

I'm using Craft 3.2 RC1 with Guest Entries 2.2.3. I have a guest entry form set up and works just fine unless I try to upload an image. My abbreviated form looks like this:
<form method="post" action="" enctype="multipart/form-data" accept-charset="UTF-8">
    {{ csrfInput() }}

    <input type="hidden" name="action" value="guest-entries/save">
    <input type="hidden" name="sectionUid" value="25e26550-2b9f-418a-84cc-4e08ca46913a">

    Title
    <input id="title" type="text" name="title"/>

    Thumbnail Image
    <input type="file" id="thumbnailImage" name="fields[thumbnailImage]" value="Upload">

    <input type="submit" value="Submit">
</form>

When I try to upload an image, I get an Image Exception error:
Image Exception – craft\errors\ImageException
The file “assets5d239a84ae0f09.86917575.jpg” does not appear to be an image.

Ae file with that name is written to the temp directory, but is empty (zero bytes).
The odd thing is that the correct and working image file is also copied to the asset directory, but not visible from the Assets panel in Craft.
Any thoughts?

Updating Craft and Plugin fixed the problem for me
`Fetching available updates ... done
Performing 3 updates:
- craft 3.2.0 => 3.2.1
- guest-entries 2.2.3 => 2.2.4

`


Upgrade to Polkadot v0.9.22

https://github.com/paritytech/substrate/compare/polkadot-v0.9.20...polkadot-v0.9.22
There's no Substrate runtime migration need todo, according to https://github.com/paritytech/polkadot/releases/tag/v0.9.22
Notable changes:

https://github.com/paritytech/substrate/pull/11148

Updated forked utility pallet to the Substrate version, but made an alias for batch_try for compatibility, events are migrated to Substrate version
PRB will switch to force_batch when new runtime upgraded

https://github.com/paritytech/substrate/pull/8783

Some node arguments changed may affect solo-mining or how khala-node running

https://github.com/paritytech/substrate/pull/11025

PhalaWorld need this
Khala hasn't integrated unique pallet yet

@h4x3rotab I'm going to merge this, remember to revew when you convenient


Traverse undocumented functions when generating dependency lists

Once #10 and #11 are done, undocumented (excluded) functions should be traversed, and their dependencies should be added to their callers.
e.g. A -> B -> C, but B is undocumented and excluded from the wiki.  The wiki should report A -> C.

See comment in #10, internal functions should be documented.  Wiki was fixed when #10 was closed.


Change to property summary to make descriptions easier to read

Pull request #65 allowed property descriptions to be viewed in a property's XML summary. This pull request tweaks the layout of the XML summary for each property so that when using Visual Studio's IntelliSense, the property name and property description are clearly defined.

Nice, thanks!


Add Logger accessor to Span

Reference implementations should be idiomatic in that language. I think the LoggerInterface is so popular we could add support for it in the core of the reference implementation.
I also thought about making the Span object itself implement those methods but we have a conflict between definition of OpenTracing's and LoggerInterface's log method.
I'd be happy to hear your opinion.
/cc @beberlei @bensigelman @yurishkuro

@wladekb see https://github.com/opentracing/opentracing.github.io/issues/30 ... I would also like to support a straightforward debug logging interface and feel confident that something to that effect will happen soon (across all platforms). That said, I would vote for doing something simple on each platform and avoid a kitchen-sink logging interface. I'm not familiar with LoggerInterface (since I'm not familiar with PHP) so can't speak to its kitchen-sink-ness.

@wladekb I think this is not needed, because its implementation specific and this PR adds no benefit, just more public code. Essentially $span->getLogger()->... would just be $span->log(...); so why not just keep $span->log().
Every tracer has to decide how to implement logging internally, there could be a PSR based tracer that uses a logging framework such as Monolog, but thats entirely tracer specific.

@beberlei the log() method from opentracing is missing a $severity argument which is part of the definition in LoggerInterface so they are not compatible. I did a direct translation from Go/Python reference implementation for the log() method and severity is not part of the opentracing standard, thus the ->getLogger() version extended that log() method and put severity into $payload
any thoughts?


react-router-native + nativebase Tabs initialPage sets initial tab, but tab content is not rendered!!!!

react-native, react and native-base version
the latest for each
Expected behaviour
tab is selected and tab content is rendered
Actual behaviour
tab is selected, but tab content is not rendered!
Steps to reproduce (code snippet or screenshot)
The tabs:
<Tabs initialPage={~~(this.props.match.params.tab||0)} >
    ...
</Tabs>

The route:
<Route ="/tabs/:tab?" component={TabsTest} />

Screenshot of emulator/device
unable to provide screenshot
Is the bug present in both ios and android or in any one of them?
i'll be receiving an ipad from my boss later this week, i'll see if happens in ios as well.
Any other additional info which would help us debug the issue quicker.
if you know of a place for react native fiddles, please link it and i'll give a code sample.

@r3wt Its difficult to trace your issue
Please provide your example on https://snack.expo.io/

@isaaclem @SupriyaKalghatgi i will create the code sample tonight, when i am working on that side project again. thank you for your patience

@r3wt Any update on this?
Will be closing this today, in case of no activity

@SupriyaKalghatgi don't be a douche, you got to give me enough time. understand that i am very busy!!! i have to make time for open source, look at my projects i haven't even committed in months.

hi @SupriyaKalghatgi is there any update? I have provided a code sample.

i have the same problem
versions:
-native-base: 2.4.3
-react-native: 0.53.3
-Node: 8.9.0
-Yarn: 1.5.1
-npm: 5.6.0
code:
`
            <Header hasTabs >
                <Body>
                    <Title>Title</Title>
                </Body>
            </Header>

            <Tabs locked initialPage={1}>
                <Tab style={{width:10}} heading={<TabHeading ><Icon name="map" /></TabHeading>}>
                    <Map />
                </Tab>
                <Tab heading={'First Tab'}>
                    <FirstTab />
                </Tab>
                <Tab heading={'Second Tab'}>
                    <SecondTab />
                </Tab>
                <Tab heading={'Third Tab'}>
                    <ThirdTab />
                </Tab>
            </Tabs>

        </Container>`

before click 'First Tab'

after click 'First Tab'

@r3wt
I found a temporary solution to this problem
first set some variable on the state in 0
state = { activePage:0 }
after, update this in componentDidMount method
`
setTimeout(()=>{

    this.setState({activePage:1})

},0)`

and use it in page property of tabs
`
        <Tabs locked page={this.state.activePage}>

            <Tab  heading={'tab1'}>
                ...
            </Tab>
            <Tab heading={'tab2'}>
               ...
            </Tab>

        </Tabs>

`


[DEVHAS-53] Add Go module for gitops resource generation

Signed-off-by: John Collier<EMAIL_ADDRESS>What does this PR do?:
Adds a separate Go module and CLI for generating GitOps resources (base, tekton, and overlay manifests). Once this is merged in, a separate PR that will run this "generator CLI" as part of a Kubernetes job will be added to HAS.
Which issue(s)/story(ies) does this PR fixes:
https://issues.redhat.com/projects/DEVHAS/issues/DEVHAS-53?
PR acceptance criteria:

[x] Unit/Functional tests

[ ] Documentation

[ ] Client Impact

How to test changes / Special notes to the reviewer:

Log in to an OpenShift / Kubernetes cluster and make install the HAS CRDs (Note: You do not need HAS running)
Clone my changes and cd into gitops-generator folder.
Create a dummy gitops repository somewhere
go build main.go
export GITHUB_TOKEN=<some-token>
Create the necessary resources on your cluster:
a. If testing base resource generation, just create a sample component
b. If testing overlays resource generation, you'll need to create an Application, Component, Environment, Snapshot, and SEB
./main --operation generate-base --component <component-cr-name> --namespace <namespace> --repoURL <repo-url> to generate the base and tekton resources
./main --operation generate-overlays --seb <seb-name> --namespace <namespace> --repoURL <repo-url> to generate the overlay resources

/retest


glfwCreateWindow freezes when called in DllMain

When glfwCreateWindow is called in DllMain, the application freezes with CPU usage dropping to 0%, and a window is not created.
Here is an example:
BOOL WINAPI DllMain(
    HINSTANCE hinstDLL,
    DWORD fdwReason,
    LPVOID lpReserved)
{
    GLFWwindow* window;
    /* Initialize the library */
    if (!glfwInit())
    {
        std::cout << "glfw init failed" << std::endl;
        return;
    }

    std::cout << "1" << std::endl;

    /* Create a windowed mode window and its OpenGL context */
    window = glfwCreateWindow(640, 480, "Hello World", NULL, NULL);
    if (!window)
    {
        std::cout << "window creation failed" << std::endl;
        glfwTerminate();
        return;
    }

    std::cout << "2" << std::endl;

    /* Make the window's context current */
    glfwMakeContextCurrent(window);

    return TRUE;
}

In this example, 1 is printed to the console, however 2 is never printed as the application freezes when glfwCreateWindow is called.

For anyone reading this issue: you are very limited in what you can do from inside DllMain.

Thank you for your response! I realised that soon after I posted the problem.
However, it is possible to use CreateThread and FreeLibraryAndExitThread to bypass this problem, even though it is heavily unadvisable to do so. For information can be found here.


server: Prettier Formatting

Description
Run pnpm run format in Gitrest, Historian, and Routerlicious codebases
Prompted by auto-formatting headache in #14401

@znewton Thanks for doing this! Based on the lint failure, you may need to adjust the eslint config to extend prettier, or update to the 2.0.0 version of the fluid shared lint config.

@tylerbutler thanks for the hint! There was 1 (of 50+) package in R11s with a missing "prettier" extension 😆

You need to update the root package.json for each release group and add the prettier/prettier:fix scripts to the lint scripts. otherwise there's no CI protection.

@tylerbutler I added the prettier, prettier:fix, prettier:root, and prettier:root:fix scripts to gitrest/package.json, historian/package.json, and r11s/package.json. I also added gitrest/.prettierignore, historian/.prettierignore, and r11s/.prettierignore so that internal package ignore paths were pointing at an actual file. I couldn't reuse the FF/.prettierignore because I wanted to make sure each Docker build pulled in the appropriate prettierignore


accurate filtering

Hi,
As I understood, the current behavior on scpecifying multiple filter options is to filter if a one of them is true for a response, but is there any way to filter only if all the specifed filters are true?
For example, if I specify both -fc 200 and -fs 0, I would not see in results responses with the 200 status code and any content-length and responses with 0 content-length and any status code.
But what if I need to filter only responses where status code is 200 AND content-length is 0? I cannot find such option.

Hi!
That's a good and valid question. One of the original design targets actually was to enable users to do exactly that.
However it's way more flexible to handle all this in the post processing phase using JSON output. My suggestion here would be to do a run with more lax filtering, and handle the results filtering using the -of results.json file.


Where should I drop this in Jmeter?

The plugin JAR file shall be placed in /lib/ext/, all dependencies (here, Gson and Jersey libraries) - in /lib/.

I placed it. Yet I dont see the listener showing up in the Jmeter GUI. is there anything specific that I should try doing?

If you placed JAR file with listener plugin after you started JMeter, please restart it - libraries are checked at JMeter startup.
Add listener component "Backend Listener" to your test plan, then in configuration for this component, check entries in dropdown list for "Backend Listener implementation". Can you see listener's class name there (vadim.jmeter.listeners.ElasticsearchListener)?

2016/04/22 19:53:57 ERROR - jmeter.JMeter: Uncaught exception:  java.lang.NoClassDefFoundError: com/sun/jersey/api/client/filter/ClientFilter
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Unknown Source)
at org.apache.jmeter.visualizers.backend.BackendListenerGui.actionPerformed(BackendListenerGui.java:166)
at javax.swing.JComboBox.fireActionEvent(Unknown Source)
at javax.swing.JComboBox.setSelectedItem(Unknown Source)
at javax.swing.JComboBox.setSelectedIndex(Unknown Source)
at javax.swing.plaf.basic.BasicComboPopup$Handler.mouseReleased(Unknown Source)
at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at javax.swing.plaf.basic.BasicComboPopup$1.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$500(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
Caused by: java.lang.ClassNotFoundException: com.sun.jersey.api.client.filter.ClientFilter
at java.net.URLClassLoader.findClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
... 40 more
This error after I select the elastic search listener in the dropdown.
Have placed the Listener4ElasticSearch.jar in the lib/ext and the Gson-2.2.2.jar and jersey.jar in the lib folders and then restarted the JMeter.

As I wrote earlier, the plugin implementation depends on Gson and Jersey 1.x libraries, so they shall be downloaded and placed in JMeter home/lib/ before the plugin can be used.

Do I need to build the JMeter from source again? Because just by placing the plugin jar does not download any gson or jersey jars in the lib folder.
Even if I place the jars into the lib folder, I am still getting the same error.
java.lang.NoClassDefFoundError: com/sun/jersey/api/client/UniformInterfaceException

No, no need to rebuild the plugin, you can use the compiled and built version.
From an exception, I see it failed a class from Jersey library - which Jersey binaries did you use? I used Jersey 1.19 - precisely, a bundle jersey-bundle-1.19.jar.

Finally. Awesome. Thanks so much for your help.


Some default styles are missing from mash.css

In one of the newer iterations we introduced reset.css which strips a lot of default styles. This might've been a bit too much, as headers now look like any other text.
I suggest we either:

Remove the use of reset.css altogether, or a subset of the styles we do not want to use, or
Apply some styles we want to have as a common baseline, at least for headers

We might also postpone this until we have a proper solution for how we want to handle styles in the data browser in general.

I'd postpone this to be part of the UX work we should incorporate in our planning process later; the current data browser doesn't have a clear information hierarchy anyway.

Btw, quick fix might be: https://necolas.github.io/normalize.css/

Fixed by #68.


Authentication on DB storage

implementation of  authentication on sql database  see #177 for details

build failed ?? "On my machine it works" syndrome ??

Mmm I suscpect, I'll checkout the changes in your PR and check on my
own...sometimes happens with deletion of MapDB files :-(
Andrea
On Fri, May 13, 2016 at 5:30 PM, mackristof<EMAIL_ADDRESS>wrote:

build failed ?? "On my machine it works" syndrome ??
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/andsel/moquette/pull/178#issuecomment-219077472

I've tried on my own and also it works, seeing the error on Travis it's due to some Integration test, it happens that sometimes a test of that king (no unit) break the build, I'm working to fix it :-(


arm2pulumi: Support pre-selection of tabs with querystrings

Problem description
It would be very useful to be able to bookmark the https://www.pulumi.com/arm2pulumi/ website with pre-selected tabs
Example: https://www.pulumi.com/arm2pulumi?armTemplate=custom&language=csharp
Affected product version(s)
Current version

Closing as wont-fix since this is a non-trivial engineering effort that would have minimal value, and we haven't tried to work on it in ~4yrs.


Catch exceptions in _check_module

_check_module.main() now catchs IndexError and FileNotFoundError
errors: raise ArgcompleteMarkerNotFound exception instead.
Replace open() with tokenize.open() to handle "# coding: xxx"
encoding cookie: support source code using an encoding different
than UTF-8 on Python 3.

On Fedora, a default exception hook is installed on the whole system. Uncatched exceptions are reported to Fedora using ABRT. Type "python3 -m http.ser[TAB]" on Fedora detects a bug and invites the user to report the bug to Fedora. Example of such report:
https://bugzilla.redhat.com/show_bug.cgi?id=1737212
Bonus: this change also adds support for encoding different than UTF-8 on Python 3. Tell me if you prefer a separated PR for that.
Note: I tested my change on Python 3.7 using my other PR #268.

Codecov Report

Merging #269 into master will decrease coverage by 4.1%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
- Coverage   83.85%   79.74%   -4.11%
==========================================
  Files           7        7
  Lines         706      716      +10
==========================================
- Hits          592      571      -21
- Misses        114      145      +31

Impacted Files
Coverage Δ

argcomplete/_check_module.py
41.66% <8.33%> (-30.34%)
:arrow_down:

argcomplete/compat.py
68.75% <0%> (-31.25%)
:arrow_down:

argcomplete/shellintegration.py
91.3% <0%> (-8.7%)
:arrow_down:

argcomplete/__init__.py
90.05% <0%> (-0.88%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31972ee...fa727ef. Read the comment docs.

I rebased this PR on top on my tox change.
Oops, argcomplete supports Python 2: I didn't notce that. I adapted my PR for Python 2.

Thanks for the PR @vstinner! I'm happy to merge this for you, however I won't be able to push a release.

I forgot this PR that I wrote 2 months ago. Feel free to modify it if you want :-)

@evanunderscore your discretion with this PR, please merge as you see fit and I will cut a release when ready.

Thanks for your work @vstinner!


support string message type in @TypedException

support string type at error body.

as-is
export declare function TypedException<T extends object>(status: number | "2XX" | "3XX" | "4XX" | "5XX", description?: string | undefined): MethodDecorator;

to-be
export declare function TypedException<T extends object>(status: number | "2XX" | "3XX" | "4XX" | "5XX", description?: string | undefined): MethodDecorator;
export declare function TypedException<T extends string>(status: number | "2XX" | "3XX" | "4XX" | "5XX", description?: string | undefined): MethodDecorator;

in nestia 1.6.5v, TypedException is deprecated. Are there any other decorators planned to be developed?

Not deprecated, but just tagged on a function when not specify generic argument.
Also, nestjs does not support string typed schema in their exception class. How do you think about that?

Not deprecated, but just tagged on a function when not specify generic argument.
Also, nestjs does not support string typed schema in their exception class. How do you think about that?

swagger schema support string type.
nestjs support all type of error body.(because httpAdapter.reply parameter type in filter is any)

Will support at v2 udpate.


Adds AB testing code.

Has a 50/50 percentage of showing either 'Blog' or 'News'. Records two 'News/Blog link naming test' events in GA with either the value 'News' or 'Blog':

loaded
clicked

You can calculate the conversion based of the amount of times an option was loaded compared to how many times it was clicked. 👍


Fixed an issue with 'typeString' under Windows.

The fix is for Windows only, other platforms should be unaffected.
The return value for toggleKeyCode (which uses VkKeyScan) contains the encoded modifiers (eg SHIFT in my case).
The modifiers are now extracted into the format expected by Robotjs.
This fixes issue #108

Sorry for the delay! Finally tested this and everything looks good.

I had to make one change, d99f3bb8264f6925ac0da2356c55f33f84388e79.
Apparently in C89 all block-local variables need to be declared at the beginning of your functions. This was needed to compile on XP.
Not sure if we still want to support XP, but it's the build environment I'm currently using. See #134.

Oh dang, C89 :cry: I guess that's the price of XP support, haha!


Footer menu "needs" vertical scroll when many version/translation shown

Accessing a project with so many versions and clicking on the versions menu, you will see so many versions that it impossible to click on Read the Docs links (project, build, github, etc) and also it's hard to select the translation.

Edit: I'm showing this example with a local version of requests with many versions active. This is not happening in the production version of requests.

@humitos
I tried some css adjustments locally. Here's the results

When there are too many versions and translations

When there are limited versions and translations

If these are okay, I can make a PR for this.


Changed formatting on markdown

Some of the titles did not have a space after the '##' resulting in the header not properly utilizing markdown.

Thanks for the update!


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/OPS-E2E-PPE/docs-archive-test-source

Docs Build status updates of commit 00c951a:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Release_Archive_master_2020-01-13-07-49-03 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Release_Archive_master_2020-01-13-07-49-03

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update _run.py

pipe:

Could you please rename the commit to something more meaningful, such as "Fix typo in _run.py docstring"? Thanks

@Depau Thanks! Done.


Website gives wrong directions for installing additional extension.

At https://canasta.wiki/extensions-and-skins/#installing-additional-extensions the following is incorrect:

To install a non-Canasta extension, simply place it in the ./extensions directory and add a wfLoadExtension call to ./config/LocalSettings.php, e.g.:

wfLoadExtension( 'MyCustomExtension' );

The wfLoadExtension call should read:
wfLoadExtension( 'MyCustomExtension', "$IP/user-extensions/MyCustomExtension/extension.json" );

Well, the directions are "correct" - though whether or not they actually work is a different story. Adding an extension directory to the user-extensions/ directory is meant to cause a symlink to it in the extensions/ directory to automatically be created - so that you can then call wfLoadExtension() directly on that. If it didn't happen in your case, that's a bug.

With the symlink dependency that may not happen sometimes, it would be good to add a troubleshooting section.


1.12: multicluster: add allowlist for kubeconfig auth methods

Cherrypick https://github.com/istio/istio/pull/36307
Custom 1.12-only parts are in a split commit.

/cherrypick release-1.11

@howardjohn: #36316 failed to apply on top of branch "release-1.11":
Applying: multicluster: add allowlist for kubeconfig auth methods (#36307)
Using index info to reconstruct a base tree...
M	pilot/pkg/features/pilot.go
A	pkg/kube/multicluster/secretcontroller.go
A	pkg/kube/multicluster/secretcontroller_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/kube/secretcontroller/secretcontroller_test.go
Auto-merging pkg/kube/secretcontroller/secretcontroller.go
Auto-merging pilot/pkg/features/pilot.go
CONFLICT (content): Merge conflict in pilot/pkg/features/pilot.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 multicluster: add allowlist for kubeconfig auth methods (#36307)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn: new issue created for failed cherrypick: #36421

In response to this:

/cherrypick release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Update brackets (1.6)

Whoops, I didn't read the docs thoroughly enough! I'm going to close this and I have submitted a PR using cask-repair. #17384


fix(stm32h7/flash): enhance resilience to program sequence errors (pgserr)

PR #1014 introduced memory barriers to H7 flash driver to mitigate PGSERR errors.
Despite initial implementations, there was a noticeable frequency of these errors during write operations.
The changes in this PR results in a significant enhancement to the resilience against Program Sequence Errors (PGSERR) in the H7 flash module in my experience.
I believe this is related to this note from rm0399 §4.3.9:

Any write access requested while the PG1/2 bit is cleared to 0 is rejected. In this case, no  error is generated on the bus, but the PGSERR1/2 flag is raised.

Although I didn't experience any issues during erase operations, this PR also adds memory barriers during erase operations to be on the safe side.
Zephyr's STM32H7 flash driver has a similar implementation.

I haven't seen any since this change and I've been stressing the flash with write/erase sequences while implementing the bootloader.


[Research question] Index implementation details

Hello,
I am interested in the implementation details of ArangoDB indexes for a thesis I am writing. I have some questions and I hope somebody can answer them. I am only interested in the current stable version that uses RocksDB as its storage engine.

With the RocksDB storage engine, are there really any actual hash indexes involved anymore or is the only trace left the name "hash", that was left there for compatibility reasons? I see conflicting statements in the docs, I find "The primary index can be used for range queries and sorting as persistent indexes are sorted." (https://www.arangodb.com/docs/stable/indexing-index-basics.html) and then "For each collection there is always the primary index which is a hash index for the document key (_key attribute)."(https://www.arangodb.com/docs/stable/http/indexes.html). Further, this blog post: https://www.arangodb.com/2018/02/indexes-types-arangodb-part-1/ states that the "hash" type is only an alias now.

What is the data structure used for the "persistent" index type? Is it an LSM-tree provided by RocksDB or are there any other datastructures involved?

Thank you for your time.

Hi,
Hash / skiplist / persistent indices are a remaint from the mmfiles storage engine which has been decommissioned a while back.
Hence these are mere leftovers easing users their DDL-Operations.
https://github.com/arangodb/arangodb/blob/devel/arangod/RocksDBEngine/RocksDBVPackIndex.cpp
is the base implementation for these indices.

Hi,
Thanks for your quick response and answer. How would you characterize the RocksDBVPackIndex in terms of datastructure, i.e. is it a B-tree, a LSM-tree or something else?

All index values are internally stored in RocksDB. RocksDB uses an LSM tree as its underlying storage model.

Sorry, I have one follow-up question: what is the cardinality of the relationship between ArangoDB indexes and RocksDB databases? I.e., is there one RocksDB database (i.e., one LSM tree) per ArangoDB database that holds all data and indexes or is there one RocksDB database per ArangoDB collection or is there one RocksDB index per ArangoDB index, etc.

An arangodb instance maps to one rocksdb database.
Different rocksdb column families are used to separate different types of entries, like documents, index entries, ...


install extension in build nev

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@xhochy, could you please review this. Also, would it be okay to add you as a maintainer?

https://github.com/conda-forge/code-server-feedstock/pull/40


large [~id] number conversion in Branch.initSession(data =>..)

Hi,
The ~id property of the data object returned by Branch.initSession( data => ... ) gives me a wrong number.
~id:<PHONE_NUMBER>97783300 but should be<PHONE_NUMBER>97783321
I guess the number is too large and is automatically converted to the number type.
How can I prevent this conversion and be given a string instead?
I am using branch-cordova-sdk 2.6.21 with Ionic 3
Thanks in advance

Yikes! JavaScript is truncating the integers (you can test this in the Chrome console as well)

I will work on converting all Integers from our server response to Strings as soon as possible. In the meantime, I would recommend on using the values within the dashboard as the true values. https://dashboard.branch.io/liveview/opens
I apologize for this inconvenience.

The bug still exists. I am experiencing different behaviour when I open links differently.
When I open/click a branch link directly (i.e. a shared link on WhatsApp) the app receives ~id as number.

When I open the link by pasting it into a browser (i.e. chrome) the app receives ~id as string.

As we currently depend on ~id our workaround is to make a separate HTTP request retreiving the data via the link url.


Record patterns

Running hlint on
data A = A Int Int Int

foo :: A -> Bool
foo (A _ _ _) = True

it suggests
Warning: Use record patterns
Found:
  A _ _ _
Why not:
  A{}

but running hlint on
data B = B Int Int

bar :: B -> Bool
bar (B _ _) = True

there are not suggestion. Is this behaviour on purpose?

It does. You just need to have three or more wildcards for it to trigger the hint.
For example,
data B = B Int Int

bar :: B -> Bool
bar (B _ _ _) = True

But your example doesn't compile.

I meant,
data B = B Int Int Int

bar :: B -> Bool
bar (B _ _ _) = True

The hint is valid on any number of fields, but A usually looks cleaner than A{}, while (A _ _ _ _ _ _) is clearly worse. I picked 3 fields as being the first point it seems unambiguously better, but I do usually use this approach even at one field, as it gives better extensibility if I change the constructor.

Thanks for the explanation.


fix: add additional ui tweaks

SUMMARY
This PR is to finish extra UI tweaks based on the discussion on #10257 (which was merged without review approval accidentally)

smaller and lighter x

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TEST PLAN
CI
ADDITIONAL INFORMATION

[x] Has associated issue: #10257
[x] Changes UI

@kenchendesign @rusackas

I think we're starting to move towards using svg icons instead of unicode icons; if we want a thin close icon here, maybe use this one that i'm adding in my error message PR? https://github.com/apache/incubator-superset/pull/10274/files#diff-804196da1c94e898bdc1c988354ed2d0

there are so many places in the existed code based re-use css .close.
Could you make another PR, just commit this svg, and convert all existed use-cases?

If that's the case, then can you attach screenshots of all the other places this icon changed?

it seems i used css class shipped with bootstrap?

I didn't know it's from bootstrap... just want to overwrite some default behavior :)
all other places used fa fa-close. maybe i should change to that? and later when you do convert it's easier to find all uses?

this is how it looks if use fa fa-close class. way too black...i need to tweak with lighter color...

Hmm, interesting. Let's see what @kenchendesign prefers, and then we can go with that design. In the future I can help clean up some of the icons and replace with SVGs if we don't do it here

Codecov Report

Merging #10275 into master will decrease coverage by 4.73%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #10275      +/-   ##
==========================================
- Coverage   70.20%   65.46%   -4.74%
==========================================
  Files         598      598
  Lines       32017    32001      -16
  Branches     3240     3234       -6
==========================================
- Hits        22477    20949    -1528
- Misses       9435    10871    +1436
- Partials      105      181      +76

Flag
Coverage Δ

#cypress
?

#javascript
59.40% <0.00%> (+0.06%)
:arrow_up:

#python
69.68% <ø> (ø)

Impacted Files
Coverage Δ

...rontend/src/SqlLab/components/TabbedSqlEditors.jsx
74.02% <0.00%> (-8.45%)
:arrow_down:

superset-frontend/src/SqlLab/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/explore/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/SqlLab/index.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/dashboard/App.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/explore/index.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/dashboard/index.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/setup/setupColors.js
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/chart/ChartContainer.jsx
0.00% <0.00%> (-100.00%)
:arrow_down:

superset-frontend/src/setup/setupFormatters.js
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c67b1ab...7a030d3. Read the comment docs.

@etr2460 Yeah I prefer the skinny close icon.

Updated cancel icon with new svg icon:


run/events: Use Unmarshal Types Rather Than dynamic. Fixes #1156

Note that I only made PubSub sample to use the strong event type. The Storage sample only reads CloudEvent headers and I think we want to keep it that way, so it can be used both in Managed and Anthos versions of eventing.

Let me know if I need to rebase or something to get the PR merged?

Yes, it's ready from my side


Add a Continuous Integration Tool for Build Status + PR Checks

Intend to use TravisCI for this. This involves adding a .travis.yml and setting up Travis through the website.

Closed by #117


JanDeDobbeleer.OhMyPosh version 15.5.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@russellbanks I updated the manifest in this commit. I only adjusted the switch as I assumed it would be able to identify the switches based on the scope and inno InstallerType, but I guess that's incorrect.

Automatic Validation ended with:


YAPF formatting issue

I'm using nvim 0.1.7, the latest vim-autoformat, and yapf 0.13.2. a minimal VIM file:
call plug#begin()
Plug 'Chiel92/vim-autoformat'
call plug#end()

noremap <F3> :Autoformat<CR>

I run :Autoformat on my test.py file which looks like:
x = {  'a':37,'b':42,

'c':927}

y = 'hello ''world'
z = 'hello '+'world'
a = 'hello {}'.format('world')
class foo  (     object  ):
  def f    (self   ):
    return       37*-+2
  def g(self, x,y=42):
      return y
def f  (   a ) :
  return      37+-+a[42-x :  y**3]

and get:
x = {'a': 37, 'b': 42,

     'c': 927}

y = 'hello ''world'
z = 'hello ' + 'world'
a = 'hello {}'.format('world')

class foo  (object):

    def f(self):
        return 37 * -+2

    def g(self, x, y=42):
        return y

def f(a):
    return 37 + -+a[42 - x:  y**3]

But, I expect to get (and do get when I run yapf directly on the file from the command line):
x = {'a': 37, 'b': 42, 'c': 927}

y = 'hello ' 'world'
z = 'hello ' + 'world'
a = 'hello {}'.format('world')

class foo(object):
    def f(self):
        return 37 * -+2

    def g(self, x, y=42):
        return y

def f(a):
    return 37 + -+a[42 - x:y**3]

A few other points:

despite having a .style.yapf file in my project directory, those settings are not picked up by yapf-autoformatter (they are picked up by yapf test.py).
The only message after running :Autoformat is: Definition in 'g:formatdef_autopep8' was successful.

I noticed another issue recently posted that might be related (though that user had a problem with autopep8 being run). https://github.com/Chiel92/vim-autoformat/issues/168

The only message after running :Autoformat is: Definition in 'g:formatdef_autopep8' was successful.

That is a major hint. Apparently you have autopep8 installed as well as yapf, so vim-autoformat has to choose. Arbitrarily it uses the first formatter that works, which appears to be autopep8. To tell vim-autoformat that yapf has a higher priority, redefine the list of python formatters in your vimrc like
let g:formatters_python = ['yapf', 'autopep8']

or else make vim-autoformat consider just yapf (and disregard autopep8 completely)
let g:formatters_python = ['yapf']

Wow. That's like looking at 2 + 2 = 5 and not seeing the problem. I appreciate your quick insight. Case closed :)

I spoke too soon. This is now formatting the code as expected, but it's still not taking account options in my .style.yapf (whereas running yapf from the command line does).

I'm not a yapf user myself, but fortunately figuring this out isn't hard.
After running the formatter, you can view the formatter command used by typing :echo b:formatprg.
Does this match the command you use on the command line?

If not, than that maybe the source of the difference in behavior.
You could propose a modification on the default definition, which would take the style file into account.
If it matches, maybe the working directory can be a source of the behavioral difference?

Any updates on this?

Sorry, I must not have seen the previous notification. Yep, all good. Thanks @Chiel92


Cannot Find Child In Container

No matter now many things I try I just cannot find the LoginContainer and I know it's there, I drilled down via WebStorm and see it buried inside HeaderContainer
 it.only('only shows logout button when user is authenticated', async () => {
    const store = initStore(),
      headerContainer = mount(<HeaderContainer store={store} />),
      loginContainer = shallow(<LoginContainer store={store} />)

    await mockPost('/users/sessions', { data: [{session: fakeSession, token: fakeToken }]})
    await loginContainer.find('LoginContainer').props().authenticate(fakeEmail, fakePassword)
    let logoutButton = headerContainer.dive().find('LogoutContainer')
    expect(logoutButton).to.exist
  })

HeaderContainer
import { connect } from 'react-redux'
import React, { Component } from 'react'
import LogoutContainer from '../containers/LogoutContainer'

class HeaderContainer extends Component {
  constructor(props) {
    super(props)

  }

  render(){
    console.log(`this.props.isAuthenticated: ${this.props.isAuthenticated}`)
    return(
      { this.props.isAuthenticated && <LogoutContainer className='ft-logout-button' /> }
    )
  }
}

const mapStateToProps = state => ({
  isAuthenticated: state.auth.isAuthenticated,
})

export default connect(mapStateToProps)(HeaderContainer)

of course the expect fails. When I look at this with the WebStorm debugger here's what I'm seeing

Do a console.log(headerContainer.debug) and see what the output is. We recently discovered an issue with ES modules where using default exports was causing Enzyme to not render a component imported as a default for a module with the correct name. I do not know if this issue is caused by Enzyme or something else in the transpilation pipeline.
You might see something like <Component ... /> in the debug output where you would expect the <LogoutContainer /> to be. This will cause your .find('LogoutContainer') call to not actually find any components matching your selector.
One way to fix this is to declare the LogoutContainer component variable first and then export it.
const LogoutContainer =
....
;
export default LogoutContainer;

Enzyme will then render it as a <LogoutContainer /> component rather than a generic <Component ... /> component. Again, I did not investigate it further as to why the name of the component gets passed correctly using this method; just a workaround we came across.

@CalMlynarczyk avoiding using arrow functions for SFCs, and always using named functions, ensures that component names are always exactly and explicitly what you expect them to be.

I'm going to close this; happy to reopen if needed.


Unable to read/open a problematic dog image in Dog Breed Classifier project

One of the dog images in the train directory ("dogImages/train/098.Leonberger/Leonberger_06571.jpg") is causing issues when attempting to load via PIL. Specifically, the following error occurs: OSError: image file is truncated (150 bytes not processed).
Since I've downloaded the project locally I could address this locally by moving out the offending file, but perhaps this should be fixed in the main repository here so that other students/users can benefit.

I'd be happy to send a pull request to remove the dog image, but perhaps the Udacity team can suggest a different fix.

@cvanderw either remote the image as you suggested or add this:
from PIL import ImageFile
ImageFile.LOAD_TRUNCATED_IMAGES = True

helped me

@soswow Thanks for the suggestion. That sounds like a great option. In that case the code should probably be updated to account for truncated images.


[Question] File uploads

In the demo app for Bootsy at http://bootsy-demo.herokuapp.com/, images are inserted into the post via urls while in the app it mentions that it supports file uploads for posts.
Does the gem provide an image upload for users locally through carrierwave but it is just not included in the demo?

Yes, I'm aware of that issue. I still need to configure a file storage for the demo app. Meanwhile it only allows images via URLs.


HADOOP-18591. Fix a typo in Trash

Description of PR
HADOOP-18591 Fix a typo in Trash, change 'trasg' to 'trash'
How was this patch tested?
no need test
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id ('HADOOP-18591')?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 36s

trunk passed

+1 :green_heart:
compile
29m 38s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
27m  1s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 49s

trunk passed

-1 :x:
javadoc
1m 14s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m  9s

trunk passed

+1 :green_heart:
shadedclient
29m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  7s

the patch passed

+1 :green_heart:
compile
29m 33s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
29m 33s

the patch passed

+1 :green_heart:
compile
26m  4s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
26m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  4s

the patch passed

+1 :green_heart:
mvnsite
1m 47s

the patch passed

-1 :x:
javadoc
1m  2s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 59s

the patch passed

+1 :green_heart:
shadedclient
28m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 50s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

254m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5287/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5287

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle

uname
Linux 8992c447c659 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3ab1817dece9e96be84067675ef3d0368c624706

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5287/1/testReport/

Max. process+thread count
1587 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5287/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 26s

trunk passed

+1 :green_heart:
compile
29m 59s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
24m 25s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 43s

trunk passed

-1 :x:
javadoc
1m  9s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 49s

trunk passed

+1 :green_heart:
shadedclient
29m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
29m 36s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
29m 36s

the patch passed

+1 :green_heart:
compile
24m 18s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
24m 18s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 44s

the patch passed

-1 :x:
javadoc
1m  0s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
2m 47s

the patch passed

+1 :green_heart:
shadedclient
28m 53s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 42s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

251m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5287/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5287

Optional Tests
dupname asflicense codespell detsecrets xmllint compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle

uname
Linux 4e208731fe71 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8656083c651776970e58b1bd0f5c86793444d601

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5287/2/testReport/

Max. process+thread count
3098 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5287/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

It's strange that I just merge the PRhttps://github.com/apache/hadoop/pull/5280. But the current PR display was also merged by me (which I didn't actually do).
Also Files changed is 0, so I can't revert(and don't need to revert actually).

Hi @huangxiaopingRD , could you submit a new PR again? And update the code to follow @cnauroth's advice . I'm sorry for the trouble.

@tomscut That's ok, I've resubmitted the PR


chore: remove nolints

After https://github.com/leanprover/lean4/issues/1730 was closed, we can remove some nolints.

bors merge


"index out of range" error while logging to Predix with CLI

I am developing HellowWorld app for Predix as per link
https://www.predix.io/resources/tutorials/tutorial-details.html?tutorial_id=1569&tag=1719&journey=Hello World&resources=1475,1569,1523
The command prompt in/out on my Windows 7 Professional SP1 64-bit laptop as below.
Please check.
Thx,
Anand
E:\GE-Predix\HelloWorld\predix-nodejs-starter>set CF_TRACE=true
E:\GE-Predix\HelloWorld\predix-nodejs-starter>cf login -a API Endpoint
API endpoint: API
REQUEST: [2016-06-19T20:47:11+05:30]
GET /v2/info HTTP/1.1
Host: API
Accept: application/json
Content-Type: application/json
User-Agent: go-cli 6.19.0+b29b4e0 / windows
REQUEST: [2016-06-19T20:47:17+05:30]
GET /v2/info HTTP/1.1
Host: API
Accept: application/json
Content-Type: application/json
User-Agent: go-cli 6.19.0+b29b4e0 / windows
    Something unexpected happened. This is a bug in cf.

    Please re-run the command that caused this exception with the environment
    variable CF_TRACE set to true.

    Also, please update to the latest cli and try the command again:
    https://github.com/cloudfoundry/cli/releases

    Please create an issue at: https://github.com/cloudfoundry/cli/issues

    Include the below information when creating the issue:

            Command
            cf login -a API Endpoint

            CLI Version
            6.19.0+b29b4e0

            Error
            runtime error: index out of range

            Stack Trace
                    goroutine 1 [running]:
    main.generateBacktrace(0x0, 0x0)
   /tmp/build/80754af9/gopath/src/github.com/cloudfoundry/cli/main/main.go:189 +0xa0
    main.handlePanics(0x3342aa20, 0x11d39180, 0x3342a9f8, 0x11d17260)
            /tmp/build/80754af9/gopath/src/github.com/cloudfoundry/cli/main/main.go:173 +0x198
    panic(0xb15440, 0x1195c008)
            /usr/local/go/src/runtime/panic.go:443 +0x3fd
    github.com/cloudfoundry/cli/cf/net.getBaseDomain(0x11d15160, 0x12, 0x0, 0x0)
            /tmp/build/80754af9/gopath/src/github.com/cloudfoundry/cli/cf/net/http_client.go:106 +0x101
    github.com/cloudfoundry/cli/cf/net.(*client).checkRedirect(0x119836b0, 0x11cfa0e0, 0x11c9a028, 0x1, 0x2, 0x0, 0x0)
            /tmp/build/80754af9/gopath/src/github.com/cloudfoundry/cli/cf/net/http_client.go:53 +0x196
    github.com/cloudfoundry/cli/cf/net.(*client).(github.com/cloudfoundry/cli/cf/net.checkRedirect)-fm(0x11cfa0e0, 0x11c9a028, 0x1, 0x2, 0x0, 0x0)
            /tmp/build/80754af9/gopath/src/github.com/cloudfoundry/cli/cf/net/http_client.go:38 +0x4c
    net/http.(*Client).doFollowingRedirects(0x11d316c

Platform Details
Windows 7 Professional SP1 64-bit
Shell
Windows Command Prompt

Hi Dies,
Thanks much for quick revert and apologies for my ignorance.
I used "API Endpoint" as VERBATIM command line input.
Please suggest if following default URL can be used for all Beta apps:
https://api.system.aws-usw02-pr.ice.predix.io
Also please see if the user message for incorrect API endpoint can be more
intuitive instead of cryptic "index out of range".
Hoping not to trouble you with more  beginner issues..
Regards,
Anand
On 20 Jun 2016 08:04, "Dies Koper"<EMAIL_ADDRESS>wrote:

Hi @AnandChapekar https://github.com/AnandChapekar,
Did you actually type cf login -a API Endpoint or did you type a proper
url for "API Endpoint"?
If you did type a proper url, can you show what it looks like? (okay to
obfuscate if you don't want it in public, but I'd like to know whether it
start with api. and how many levels deep the domain is).
Cheers,
Dies Koper
CF CLI PM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cloudfoundry/cli/issues/865#issuecomment-227038841,
or mute the thread
https://github.com/notifications/unsubscribe/ATArIavTMq0U7hKo1dEyqwgdvJeLpHFXks5qNfw2gaJpZM4I5MPj
.

Hi @AnandChapekar
Yes, I'd like to use this oppportunity to add some validation to that field. Thanks for bringing it up!

@AnandChapekar
We could not reproduce this panic on windows using v6.19.0 of the CLI. Could you please provide the following additional information:

what is in your config.json file (this should be located in your .cf\config.json
any environment variables set for the CLI
what version of golang you have installed
also list any CLI commands that you ran prior to this panic (if any)
please include all lines of the stack trace (if not already there)

Also anything else you can think of related to this panic.
Thanks
Difan and Nick

Closing, as I believe the current output is good enough:
D:\Users\koperd\Downloads\bin>cf login -a API Endpoint
API endpoint: API

REQUEST: [2016-10-22T11:12:57+11:00]
GET /v2/info HTTP/1.1
Host: API
Accept: application/json
Connection: close
Content-Type: application/json
User-Agent: go-cli 6.22.1+b80ba27 / windows

FAILED
Error performing request: Get https://API/v2/info: Service Unavailable


Working with http_request Task type to hit microservice

I want to hit a service running on mine local host. So followed the documentation to write a chunk of code.
Yet, API is not called by task definition when i am polling for execution of that task.
Doubts:
a) How does polling system executes the task in Worker system.
b) how to hit a micro-service using client application. Any working example link will be a great help.

The http task is a system task which will run within the conductor and will not run on a Worker.
Workers are defined for custom tasks.( tasks of type 'Simple' )
A sample workflow (from kitchen sink example) which invokes an HTTP API. This will run within the conductor.
{
"name": "worflow_http",
"description": "invokes an API",
"version": 1,
"tasks": [
{
"name": "search_elasticsearch",
"taskReferenceName": "get_es_1",
"inputParameters": {
"http_request": {
"uri": "http://localhost:9200/conductor/_search?size=10",
"method": "GET"
}
},
"type": "HTTP"
}
],
"schemaVersion": 2
}

Thanks prateek


fix restful_routes.py

The request should accept GET instead of POST.

I just encountered this issue🤣

Thanks! It seems a miss in precent change.


Pod install fails - SWIFT_VERSION missing

Pod install fails with the following message in and Obj-C based React Native project:
Installing react-native-leanplum (1.0.13)
[!] Unable to determine Swift version for the following pods:

- `react-native-leanplum` does not specify a Swift version and none of the targets (`xxx`) integrating it have the `SWIFT_VERSION` attribute set. Please contact the author or set the `SWIFT_VERSION` attribute in at least one of the targets that integrate this pod.

Steps to reproduce:
yarn add @leanplum/react-native-sdk
npx react-native link @leanplum/react-native-sdk
cd ios
pod install

Side note:
Why isn't the library set up for autolinking? Autolinking is the new standard now: https://reactnative.dev/blog/2019/07/03/version-60#native-modules-are-now-autolinked

Thanks for the feedback,
The error you are seeing occurs if you are trying to import library into a target that doesn't actually use Swift. Try setting Swift version in your target in XCode
As for autolinking, it is supported out of the box, if you are using ReactNative version 0.60+ you don't have to link manually, you can find more details here

Thanks @milos1290 . I had to update my project from 0.62 to 0.63 and fix the Swift setup to get this working properly.


Newsboat's mouse scrolling does not work within tmux

Newsboat 2.36.0
System: Linux 4.9.186-22990479 (aarch64)
Compiler: g++ Android (10552028, +pgo, +bolt, +lto, -mlgo, based on r487747d) Clang 17.0.2 (https://android.googlesource.com/toolchain/llvm-project d9f89f4d16663d5012e5c09495f3b30ece3d2362)
ncurses: ncurses 6.4.20231001 (compiled with 6.4)
libcurl: libcurl/8.8.0 OpenSSL/3.2.1 zlib/1.3.1 libssh2/1.11.0 nghttp2/1.62.1 nghttp3/1.4.0 (compiled with 8.8.0)
SQLite: 3.46.0 (compiled with 3.46.0)
libxml2: compiled with 2.13.1:
Description
When mouse mode is enabled in tmux, using the mouse to scroll does not scroll through the feeds in Newsboat. Instead, it scrolls up and down tmux's history.
Is there a workaround, or is this a limitation with the libraries used?
For comparison, in Vim, mouse scrolling does not go up tmux's history. Mouse movements are captured by Vim itself.
Steps to Reproduce

Install newsboat & tmux on a aarch64 linux system.
Open a tmux session.
Enable mouse mode in tmux set -g mouse on.
Launch Newsboat within the tmux session.
Scroll through feeds using the mouse wheel.
Instead of scrolling through Newsboat's feeds, the mouse wheel scrolls through tmux's history.

Expected Behavior
Mouse scrolling should scroll through Newsboat's feeds, similar to how Vim captures mouse movements within tmux.
Actual Behavior
Mouse scrolling moves through tmux's history instead of Newsboat's content.

I can reproduce this.
At the moment, Newsboat doesn't implement any mouse handling.
Instead, it listens for the arrow UP/DOWN keys.
It looks like the terminal emulator converts the mouse scrolling into (a few) UP or DOWN presses.
That behavior is apparently disabled when mouse mode is enabled in tmux.
We currently use ncurses (via STFL) for terminal interactions.
Ncurses has a way to enable listening for mouse events.
However, STFL does not expose that functionality in an integrated way.
We can work around it, I did a bit of local experimentation, but it needs some trickery to make it work in all contexts.
I prefer adding this support after we switch away from STFL (as tracked in https://github.com/newsboat/newsboat/issues/232)


Jax documentation

We should write a snippet about the motivation, and API behavior surrounding the JAX implementation of multidms.

This is now done here


Feature request: support for numeric literal underscore (number formatting)

Please consider adding support for numeric literal underscores, for increased long number legibility e.g.
a :u32 = 1_000_000;
b :f32 = 1_234.0_123;

Allllrighty! Good stuff @brendanfh Brendan! 💯 👍


Mention @RosiaDaSerenata #37

I hope this time, I had made this correctly.

Many thanks @arioston ; )


[UI] Character and Light Cone Level Editing Remnants Present

Description
Based on Update 03-26-2024 changelog, it seems like character and light cone levels other than 80 are no longer supported. The "Edit character" window gives the impression that they still are. Should these edit options be removed? Changes made to character and light cone levels seem to save, as the updated levels will show on the characters showcase page, but changes do not affect base stats and are not reflected in the "Edit character" window when reopened.
Steps to Reproduce

Open in the "Characters > Character actions > Edit character" window.
Make a change to the character and or light cone level.
Click the save button.
Character showcase levels have changed.
Reopen the "Characters > Character actions > Edit character" window.
"Edit character" window levels have reverted to 80.

Expected Behavior
Assuming level other than 80 are no longer supported then should these edit options be removed?
Actual Behavior
Options to change character and light cone levels exist in "Edit character" window but do almost nothing.
Screenshots

Additional Information
None.

Yeah this is a fair change, I don't see any use in keeping these anymore. Thanks for the reminder!

Depending on your future plans the character edit window and option from the characters tab may not be needed. The settings are available in the character optimization page.

Released in https://github.com/fribbels/hsr-optimizer/pull/298


Crash and Error when chosing Tiefling from SRD as race

Fixed in release https://github.com/geoidesic/foundryvtt-actor-studio/releases/tag/1.0.5


So... where is the config?

I've re-downloaded, reloaded configs in game, checked and double and triple checked the folders. Still no config file, even though it says there is one in the readme. Am I just totally oblivious? I'm on the 1.18.2 version. Latest as of 7/26/22

Check the game folder used with your minecraft instance and you should have a config folder into, the mod config file is created here.
the default minecraft instance is located at ~/appdata/roaming/.minecraft/ on Windows
If you're using a modpack check where the minecraft instance was created and you should have a config folder with backpackmod.json

Curseforge create another ".minecraft" directory, check your modpack settings on curseforge launcher, you will be able to open this directory with file explorer, and you will find a config folder.

Yeah, that's the one I'm looking at. Doesn't seem to be there. I'm not at
home right now, but when I get back I'll screenshot.
On Wed, Jul 27, 2022, 11:12 AM SpyMan10 @.***> wrote:

Curseforge create another ".minecraft" directory, check your modpack
settings on curseforge launcher, you will be able to open this directory
with file explorer, and you will find a config folder.
—
Reply to this email directly, view it on GitHub
https://github.com/SpyMan10/backpackmod/issues/26#issuecomment-1197061029,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWKLC3YJF4HVZAV2BS3P74LVWFUXRANCNFSM54YB5CGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I don't see it. Is it in a backpackmod folder? Or is it a loose file called backpackmod.json?

Config directory should contains a file backpackmos.json
Check log to ensure the file is correctly created or loaded during mod initialization at startup

Thanks, I'll check it out.
On Thu, Jul 28, 2022, 2:09 AM SpyMan10 @.***> wrote:

Config directory should contains a file backpackmos.json
Check log to ensure the file is correctly created or loaded during mod
initialization at startup
—
Reply to this email directly, view it on GitHub
https://github.com/SpyMan10/backpackmod/issues/26#issuecomment-1197810205,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWKLC34DDMZI775NZ373PHDVWI55FANCNFSM54YB5CGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

I'll go ahead and close this, but just FYI it never actually generated, not sure why.


write tests for every optimization pass of the assignment

check first-assignment/tests dir, and write good .ll code to test our optimization passes.

test added with 12a500d62ea08389db4eaf29b3440d7f4f146be7, feedback on optimized versions needed

Proposals:

[ ] Bash/Python script for unit testing to avoid regression errors
[ ] Needed from prev. point: an expected result for each test

Proposals:

[x]  Bash/Python script for unit testing to avoid regression errors
[x]  Needed from prev. point: an expected result for each test

@ch-fano can you help?

added automated test script with 27457ad7163786953c437519888b7489bee8c4d4


missing files: skater/south_inf_q20.ary

When installing via
pip install https://github.com/pysal/region/archive/master.zip

into a  prebuilt and activated conda environment for osnap
I  hit
FileNotFoundError: [Errno 2] No such file or directory: '/home/serge/anaconda3/envs/osnap-region/lib/python3.6/site-packages/region/skater/south_inf_q20.ary'

looks like the file doesn't come along for the installation ride?

sorry, probably needs to be added to MANIFEST.in.

that should only be required for testing, though... not sure why you're hitting it in installation?

I think because: https://github.com/pysal/region/blob/master/region/skater/init.py#L2

fwiw, i also get a AttributeError: 'Series' object has no attribute 'reshape' when trying to use skater, but i can raise that elsewhere

Yes, @knaaptime replication code would help me address that.
On this, I can submit a PR removing the read statement in test_skater. that's not supposed to be there.

fwiw, i also get a AttributeError: 'Series' object has no attribute 'reshape' when trying to use skater, but i can raise that elsewhere

Thinking about this error, I bet it's because I'm not using asarray on the input, and something in scipy/sklearn is mad that the input is a Pandas series, not an array.
I can PR that.,


Show stamp info for CircuitMaintenances

Environment

Nautobot version:
nautobot-circuit-maintenance version:

Proposed Functionality
Like the end_date or start_date the stamp_date could give information about the reception date of the notification.
Use Case

Stamp (or better Date) is an attribute of the RawNotification, not from the CircuitMaintenance as it changes every notification, for the same maintenance


HLD: Blazor .NET 8 support

Pull Request
🤨 Rationale
HLD for #1667

I'm declining to review this PR, so don't wait for a review from me.


Hardknott branch

Hey,
Would be great if there would be a hardknott branch.
Thanks

The syntax is completely different. They aren't compatible!

I assume you're referring to the _ -> : syntax change, if so the change has been backported to hardknot in the hardknott bitbake branch so you need to update your bitbake.


Avoid 1.7.X runit release that breaks djbdns installs

See https://github.com/hw-cookbooks/runit/issues/144 for details.  This should really get released ASAP to prevent breaking installs.

Good call :8ball:. Will get a release out as soon as possible.


chore: Script to generate root versions.txt

This script generates versions.txt at the root. This is required for single-component setup.
File generated by the script: versions.txt

This is the file generated by the script: versions.txt

Do you think we will run this script periodically?
If this is one-time change, I don't think you need to commit it to the repository.

jar-parent is there. Good.

Do you think we will run this script periodically?

If this is one-time change, I don't think you need to commit it to the repository. (no harm adding it; just remember to remove it few months later)

We might be adding more split repos to this repository. So, it might be a good idea to keep scripts like this one for the future.

Do you think we will run this script periodically?
If this is one-time change, I don't think you need to commit it to the repository. (no harm adding it; just remember to remove it few months later)

We will need to run this everytime a new library/module is added to the monorepo.


[SPARK-31164][SQL][2.4] Inconsistent rdd and output partitioning for bucket table when output doesn't contain all bucket columns

What changes were proposed in this pull request?

This is a backport for pr#27924. For a bucketed table, when deciding output partitioning, if the output doesn't contain all bucket columns, the result is UnknownPartitioning. But when generating rdd, current Spark uses createBucketedReadRDD because it doesn't check if the output contains all bucket columns. So the rdd and its output partitioning are inconsistent.
Why are the changes needed?

To fix a bug.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Modified existing tests.

Test build #119919 has started for PR 27934 at commit 1a1d8e4.

cc @dbtsai

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24644/
Test PASSed.

cc @cloud-fan and @gatorsmile

Test build #119919 has finished for PR 27934 at commit 1a1d8e4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119919/
Test PASSed.

thanks, merging to 2.4!

Thank you, @wzhfy and @cloud-fan !


Fix TypeError when handling messages

Saw this error when testing my bot:
bot_1              | TypeError: Cannot read property 'Symbol(Symbol.iterator)' of undefined
bot_1              |     at WebsocketClient.handle_message (/usr/src/bot/src/lib/EthService.js:152:30)
bot_1              |     at emitOne (events.js:115:13)
bot_1              |     at WebSocket.emit (events.js:210:7)
bot_1              |     at Receiver._receiver.onmessage (/usr/src/bot/node_modules/ws/lib/WebSocket.js:146:47)
bot_1              |     at Receiver.dataMessage (/usr/src/bot/node_modules/ws/lib/Receiver.js:389:14)
bot_1              |     at Receiver.getData (/usr/src/bot/node_modules/ws/lib/Receiver.js:330:12)
bot_1              |     at Receiver.startLoop (/usr/src/bot/node_modules/ws/lib/Receiver.js:165:16)
bot_1              |     at Receiver.add (/usr/src/bot/node_modules/ws/lib/Receiver.js:139:10)
bot_1              |     at TLSSocket._ultron.on (/usr/src/bot/node_modules/ws/lib/WebSocket.js:142:22)
bot_1              |     at emitOne (events.js:115:13)

Not sure exactly what the root cause is but handling the error stops the bot from crashing.

👍 thanks


Colorization does not handle @$

Issue Description
$@ strings are correctly recognized as multi-line interpolated string literals, but @$ strings are not.
Steps to Reproduce
Make a string with @$, put some escaped braces in it ({{ and }}), and type between them. They will be recognized and colorized as if they were in a regular block.
Logs
OmniSharp log
Post the output from Output-->OmniSharp log here
C# log
Post the output from Output-->C# here
Environment information
VSCode version: 1.43.0
C# Extension: 1.21.13
Mono Information
        OmniSharp using built-in mono
Dotnet Information
.NET Core SDK (reflecting any global.json):
 Version:   3.1.102
 Commit:    573d158fea
Runtime Environment:
OS Name:     arch
OS Version:
OS Platform: Linux
RID:         linux-x64
Base Path:   /usr/share/dotnet/sdk/3.1.102/
Host (useful for support):
Version: 3.1.2
Commit:  916b5cba26
.NET Core SDKs installed:
3.1.102 [/usr/share/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.NETCore.App 3.1.2 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

auto-close-tag
formulahendry
0.5.6

auto-rename-tag
formulahendry
0.1.1

azure-account
ms-vscode
0.8.8

azure-pipelines
ms-azure-devops
1.165.1

code-settings-sync
Shan
3.4.3

cpptools
ms-vscode
0.26.3

csharp
ms-dotnettools
1.21.13

EditorConfig
EditorConfig
0.14.4

gitignore
codezombiech
0.6.0

gitlens
eamodio
10.2.1

language-haskell
justusadam
2.7.0

ocean-dark-extended
kleber-swf
1.5.0

path-intellisense
christian-kohler
1.4.2

powershell
ms-vscode
2020.3.0

remote-ssh
ms-vscode-remote
0.50.0

remote-ssh-edit
ms-vscode-remote
0.50.0

vim
vscodevim
1.13.0

vscode-hexdump
slevesque
1.7.2

vscode-icons
vscode-icons-team
10.0.0

vscode-il
soltys
0.0.1

vscode-pull-request-github
GitHub
0.14.0

vsonline
ms-vsonline
1.0.1736

xml
DotJoshJohnson
2.5.0

Closing as this was fixed in the textmate grammar.


Not for Review

Codecov Report

Merging #14419 into main will increase coverage by 0.06%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##             main   #14419      +/-   ##
==========================================
+ Coverage   59.40%   59.47%   +0.06%
==========================================
  Files         716      715       -1
  Lines       39999    40082      +83
  Branches     5793     5809      +16
==========================================
+ Hits        23763    23837      +74
- Misses      14975    14980       +5
- Partials     1261     1265       +4

Impacted Files
Coverage Δ

.../locators/services/virtualEnvironmentIdentifier.ts
94.11% <94.11%> (ø)

...ocators/services/globalVirtualEnvronmentLocator.ts
97.05% <97.05%> (ø)

...rc/client/pythonEnvironments/common/commonUtils.ts
100.00% <100.00%> (ø)

...pythonEnvironments/common/environmentIdentifier.ts
96.77% <100.00%> (-0.20%)
:arrow_down:

src/client/common/utils/platform.ts
60.00% <0.00%> (-12.00%)
:arrow_down:

.../pythonEnvironments/common/externalDependencies.ts
64.10% <0.00%> (-2.57%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f66dc0...012a6c2. Read the comment docs.


mrbc how including compiling program to C?

I upgrade mruby and have trouble.
Before upgrade  I create file.c  mrbc -Bdane -o file.c test.rb
and including it: #include <mruby/irep.h>
including #include "file.c"
and load:  mrb_load_irep(mrb, dane);
How i can to do this now? How compiling my script and embeded it in compiled form not in text form.

The process hasn't been changed. Do you see any problem?

my code:
======== t.c ====================
#include <stdio.h>
#include <mruby.h>
#include <mruby/irep.h>
#include "test.c"
int main()
{
mrb_int    i;
mrb_value  c;
mrb_state *mrb = mrb_open();
if (!mrb) { printf("Problemy z programem"); }
mrb_load_irep(mrb, dane);
for(i=1;i<=8;i++)
{
c = mrb_funcall(mrb, mrb_top_self(mrb), "suma",
2,mrb_fixnum_value(i),mrb_fixnum_value(i));
printf("%lld %lld\n",i,mrb_int(mrb, c));
}
mrb_close(mrb);
return 0;
}
======== test.rb ===========
#!/usr/bin/env ruby
encoding: utf-8
def suma(a,b)
(a+b).to_i
end
puts "Początek suma(2,3)=#{suma(2,3)}"
====similar Makefile====
$mrbc -Bdane -o test.c test.rb
gcc -W -Wall -pedantic -O0 -I ~/mruby/include/ -I ~/mruby/include/mruby
t.c ~/mruby/build/host/lib/libmruby.a -o t -lm
=====result: x86Linux|mac os X====
./t
TypeError: can't convert NoMethodError into Integer
Aborted (zrzut pamięci)

The output of your program was following on my machine.
Początek suma(2,3)=5
1 2
2 4
3 6
4 8
5 10
6 12
7 14
8 16

Can you show me your build configuration?

I send configuration for 2 days. I check this code and working on linux x86 (fedora), on mac not.
in normal build_config.rb (/host/) all working on x86
I check it on other arch.
in
MRuby::Build.new('mini') do |conf|
 toolchain :gcc
 conf.cc.flags << '-Os'
 conf.cc.defines = %w(MRB_DISABLE_STDIO)
end

I get on linux
Aborted (zrzut pamięci)
or in macosx
Aborted 6
please wait a moment, I search and check everithing

This is my problem,  I can not reproduce (repeat) this problem.
Sorry

printf("%lld %lld\n",i,mrb_int(mrb, c));

mrb_int is not guaranteed to match %lld. Consider:
printf("%lld %lld\n",(long long)i,(long long)mrb_int(mrb, c));

@dabroz no this is not a problem. I change version of mruby.


custom domain gives error: DNS_PROBE_FINISHED_NXDOMAIN

Before opening, please confirm:

[X] I have checked the custom domains troubleshooting guide.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
arn:aws:amplify:ap-south-1:073532590105:apps/daq7xv6udp9ox
Region
ap-south-1
Step
custom domain redirect issue
Status
DNS_PROBE_FINISHED_NXDOMAIN
Issue or question
I have custom domain which is added in route53 and all domain verification done and on AWS amplify dashboard also display that it is available but when I click on domain the page does not open but gives error while with random subdomain of aws.amplifyapp.com ( which is default when build done ) was working fine
can you please tell me what is missing here
This site can’t be reachedCheck

DNS_PROBE_FINISHED_NXDOMAIN

I have added one redirect rule below 2 rules ( which comes by default )
[
    {
        "source": "https://recursivezero.com",
        "target": "https://www.recursivezero.com",
        "status": "301",
        "condition": null
    },
    {
        "source": "https://recursivezero.com",
        "target": "https://www.recursivezero.com",
        "status": "301",
        "condition": null
    },
    {
        "source": "/<*>",
        "target": "/index.html",
        "status": "200",
        "condition": null
    }
]

Error message
custom domain doesnt' load
Additional information
this app using Astro v 4 which require node 18 so custom image amplify:al2023 is used

I have fixed this after changing rewrite rule

Source address
Target Address
Type

/<*>
/index.html
404 (Rewrite)


Farewell hamcrest, Hello assertj

Let's get rid of hamcrest in favor of assertj in our tests.

@theotherian - Can I pick this one?

Sorry for the late response @rsarawgi. What @sappenin said :)

Sure will do @sappenin - any recommendations for which package I should start with?

@rsarawgi AccountRelationshipTest in connector-accounts or EncryptedSecretTest and GcpEncryptionServiceTest in connector-crypto wouldn't be a bad place to start.
If you need an example of using assertj, SettlementQuantityTest in connector-core uses it.

Awesome -- thank you @theotherian. Will take a look.


Fail fast on variable conflicts with subscription config

We've run into this a couple times as teams migrate away from hardcoded keyvault secrets but have duplicates in the yaml, causing hard to find issues when updating values in the wrong place. The identity team, for example, has some of their core variables in our base config (which should be moved).
I'm going to update the language test pipelines to pass down EnvVars from the tests/ci.yml files just to fail fast on any conflicts.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


CODEBOX_API_KEY=local generate a Codebox error expecting an OPENAI_API_KEY? in jupyter_runtime and /sample currency fails

Is local not supported it says this works in the documentation to use codebox, but not clear on why. If I don't set it ipython works fine. What is needed to run Codebox, the OPENAI_API_KEY is set? Looking at the code in the jupyter runtime function it looks like this is in codebox.start I see in line 46 is doesn't set the key if it is set to local, but then I think line 70, it callset codbox.start and the key isn't set if it is local.
Also /sample currency no longer seems to work, complaining about token output buffer now

You need to have OPENAI_API_KEY regardless. CODEBOX_API_KEY changes the behavior of code execution (as the result of function call), not LLM.

Yes it’s strange the openai key works for regular calls. Looks like it’s deep in the code box call. Didn’t have time to read it. The key is in the environment but isn’t in a python variable. Switched to Ipython and except for the currency call it works.
I’m in the middle of adding some switch logic for fun (build an llm branching system and a scheduler :-) do tomorrow is understanding chat histories. Finding the manifest.Md and call architecture helped a lot. I linked to it in my private readme…
Sent via Superhuman iOS ( @.*** )
On Fri, Mar 22 2024 at 18:49, Satoshi Nakajima < @.*** > wrote:

You need to have OPENAI_API_KEY regardless. CODEBOX_API_KEY changes the
behavior of code execution (as the result of function call), not LLM.
—
Reply to this email directly, view it on GitHub (
https://github.com/snakajima/SlashGPT/issues/286#issuecomment-2016298227 )
, or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AANTCR5XC7IFYT4W45EVU3DYZTNRNAVCNFSM6AAAAABFD5TELKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGI4TQMRSG4
).
You are receiving this because you authored the thread. Message ID: <snakajima/SlashGPT/issues/286/2016298227
@ github. com>


refactor(loading): simplify how singleton services are provided

Description
Since v6 angular provides a new way of registering singleton services by means of the provide in root module pattern. The changes aim to make use of this feature.
Test Steps

[ ] npm run serve
[ ] then this
[ ] finally this

General Tests for Every PR

[ ] npm run serve:prod still works.
[ ] npm run tslint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build:lib still works.

@emoralesb05 error seems to be some random failure on travis

This one i think we might have to provide it at the module level.. it doesnt work without the entryComponents.

@emoralesb05 any hints on the errors that you are seeing? how can I reproduce them?

@jotatoledo Conflicts

This will become OBE with:
https://github.com/Teradata/covalent/issues/1401

closing this will be covered in #1401


AV-1549 accessibility fixes on advanced search

https://jira.dvv.fi/browse/AV-1549

Implemented in different PR.


Valid Parentheses

Given a string input containing just the characters '(', ')', '{', '}', '[' and ']'.
Check if the input string is valid or not.
The string is valid only if

Open brackets must be closed by the same type of brackets.
Open brackets must be closed in the correct order.
Every close bracket has a corresponding open bracket of the same type.

I would like to take this issue up.

@Yukino2002 Read the contributing guidelines before proceeding further

Hey, sorry for the error. Could you reassign me the issue?


VBScript win32_PingStatus with ResolveAddressNames = 'true' under Windows 10 doesn't work

Sample:
function Alive(sHost, ByRef IP, ByRef FQDN)
dim objPing, obj
Alive = false
FQDN = sHost
IP = sHost
on error goto 0
set objPing = GetObject("winmgmts:{impersonationLevel=impersonate}")._
ExecQuery("select * from Win32_PingStatus where address = '" & sHost & "' and ResolveAddressNames = 'true'")
for each obj in objPing
Alive = Not ((IsNull(obj.StatusCode) or obj.StatusCode <> 0))
IP = obj.ProtocolAddress
if obj.PrimaryAddressResolutionStatus = 0 then FQDN = obj.ProtocolAddressResolved
exit for
next
set objPing = nothing
end function
dim sHost:sHost = "<IP_ADDRESS>"
dim sDNSName
dim sIP
if Alive(sHost, sIP, sDNSName) then
wscript.echo "host = " & sHost & ", ip = " & sIP & ", DNS name = " & sDNSName
else
wscript.echo " host " & sHost & " is not alive"
end if
worked on windows 7-, but doesn't worked on windows 10
Why?

@Vadimpa Where's the doc?


feat: Update controller logic to handle stale SriovNetworkNodeState CRs with delay

Update controller logic to handle stale SriovNetworkNodeState CRs with delay

Changed the logic in the sriov-network-operator controller to handle stale SriovNetworkNodeState CRs (those with no matching Nodes with daemon).
Introduced a delay (30 minutes by default) before removing stale state CRs to manage scenarios where the user temporarily removes the daemon from the node but does not want to lose the state stored in the SriovNetworkNodeState.
Added the STALE_NODE_STATE_CLEANUP_DELAY environment variable to configure the required delay in minutes (default is 30 minutes).

This functionality especially useful when the OFED container is in use. As the OFED driver loads on the host, the sriov-config-daemon is removed from this node (achieved using configDaemon nodeselector). Since loading the driver can take a considerable amount of time, we want to ensure that the SriovNetworkNodeState is not lost during this process.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

36 of 59 (61.02%)  changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.08%) to 45.085%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

api/v1/helper.go
14
23
60.87%

controllers/sriovnetworknodepolicy_controller.go
22
36
61.11%

Files with Coverage Reduction
New Missed Lines
%

controllers/drain_controller.go
1
68.06%

Totals

Change from base Build<PHONE_NUMBER>1:
0.08%

Covered Lines:
6696

Relevant Lines:
14852

💛  - Coveralls

CI failure is not related to the change. The same failure occurs on the PR with dummy changes https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/800

@e0ne @adrianchiris  I addressed your comments. I also changed behavior a bit to completely avoid any delay in case if STALE_NODE_STATE_CLEANUP_DELAY_MINUTES env is explicitly set to 0

@SchSeba PTAL on this one


[Logging V2] App Readme

Add app readme to logging v2 chart.

https://github.com/rancher/charts/pull/608

PR ^ unrelated, needs new PR

added


Not responsive

When you resize the browser, the component is not fired again

i add some code for your problem, maybe you can try again by installing the version 1.1.7 @inviolablegenesis

i add some code for your problem, maybe you can try again by installing the version 1.2.0 @inviolablegenesis


Future proof the endpoint url params

@hemidactylus this should be fully compatible with the existing structure BUT also refactors out components enough to let us make modifications easier in the future (and eliminates the parsing issue you saw before!)

@hemidactylus when you get a chance, one more quick set of eyes on this would be fantastic :) appreciate it.


[terra-abstract-modal] Add theme-context

Summary
This pr updates terra-abstract-modal to use the new theme-context to apply themes.
Thank you for contributing to Terra.
@cerner/terra

Theme files must be in this structure.

Theme files should have this structure.

Fixed 9d07757

Missing --terra-abstract-modal-vertical-inset and --terra-abstract-modal-horizontal-inset in clinical-lowlight theme.

The variables are not there in the master also, might have been excluded on purpose.


kiln style tweaks

removed old add-component styles
fixed tiny bug in panes with buttons that aren't wide enough
fixed bugs in component lists which exist inside of flexed containers

👍

Actually, setting it to display: flex was dumb, and caused other issues. A simple display: inherit fixes everything everywhere for all time.

Coverage increased (+0.02%) to 86.196% when pulling 9c9966168275fd82b4bf1677ef597d506a0e580d on style-tweaks into ea9b1dc4963fca66bde68302ab6735ab032136d5 on master.

👍


release pipeline: add quality

@aeschli, that is correct. That environment variable is set in the template itself so you can just use it.


Add unit tests for core/modules/newsletter

Related issues
Closes #3464
Short description and why it's useful
Added additional unit tests for Vuex store: actions, mutations and getters.
Which environment this relates to
Check your case. In case of any doubts please read about Release Cycle

[x] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing VS sites with this new feature

Contribution and currently important rules acceptance

[x] I read and followed contribution rules

@psmyrek could you please change base to the release/v1.11 in both of your PR's (https://github.com/DivanteLtd/vue-storefront/pull/3749)

@andrzejewsky sure, already done.