Feature/fixsetup

Fixes a few high priority UX bugs in the installer.

Uninstall now attempts to delete its folder 10 times (with a 1 second sleep between each). This fixes our "not everything is uninstalled upon uninstall" issue. Update.exe unfortunately remains.
Updating now waits 10 seconds instead of 2 seconds to acquire the global squirrel lock. This fixes the issue where upon the first launch updating would immediately fail, because the installer was still running and had the squirrel lock.
Checking no longer attempts to return release notes, since they are guaranteed to not be present. ReleaseNotes come from the nuget, which we are not downloading in Check.
Just some extra logging too.

:+1: Looks legit to me. "Wait longer / try harder" gives me a bit of that good old "ugh" feeling, but these seem pretty harmless.
We are showing the loading / launcher while waiting for that (potential) 10 seconds, right?

Yeah I agree. It is very "ugh." But the process exits successfully and it seems windows just doesn't let it get delete for a bit.
During the update time that it's retrying, our updater says "Checking for updates". In the uninstall process, there is no UI except a spinner on the mouse cursor.


[CLI] Add basic CLI

Description

This CLI has only two arguments - help and browser. Waiting for #15 to be merged before adding the 'all' option for browser choice.
CLI is added to path in setup.py, allowing it to be called using browser-history.
Usage: browser-history -h
No documentation yet.

Fixes #5
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Checklist:

[x] I have read the contribution guidelines and followed it as far as possible.
[x] I have performed a self-review of my own code (if applicable)
[ ] I have commented my code, particularly in hard-to-understand areas (if applicable)
[ ] I have made corresponding changes to the documentation (if applicable)
[ ] My changes generate no new warnings
[ ] Any dependent and pending changes have been merged and published

Codecov Report

Merging #16 into master will decrease coverage by 16.34%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master      #16       +/-   ##
===========================================
- Coverage   84.25%   67.91%   -16.35%
===========================================
  Files           2        3        +1
  Lines         108      134       +26
  Branches       15       19        +4
===========================================
  Hits           91       91
- Misses         10       36       +26
  Partials        7        7

Flag
Coverage Δ

#unittests
67.91% <0.00%> (-16.35%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

browser_history/cli.py
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fd2ee...8834381. Read the comment docs.

@sujanchegu that was because pylint complained that I was redefining the outer parser. It could probably use a better name, something like parser_?


[Question] Multipart + Swagger

Informations

Type
Version

Question
4.x

Description
I am trying to create a multipart endpoint (file upload).
I used the example in the docs and it seems to work fine, but I can't make the swagger doc show the file field of the request. I am also using a path param.
Here is an example
import { Controller, PathParams, Post } from '@tsed/common';
import { MultipartFile } from '@tsed/multipartfiles';

type MulterFile = Express.Multer.File;

@Controller('/api')
export default class FileCtrl {

	@Post('/:username')
	test(@MultipartFile() myFile: MulterFile, @Required() @PathParams('username') username: string) {
		// Logic ...
	}
}

swagger result:
paths:
  '/api/{username}':
    post:
      parameters:
        - in: path
          name: username
          type: string
          required: true
      consumes: []

Expected Result:
paths:
  '/api/{username}':
    post:
      consumes:
         - multipart/form-data
      parameters:
        - in: path
          name: username
          type: string
          required: true
        - in: formData
          name: myFile
          type: file
          description: The file to upload.
      responses:
        '200':
          description: Success

Am I doing something wrong? or is this missing functionality?
Thanks!
Acceptance criterias

[ ] Example (log, usecase, etc...)
[ ] Ts.ED version (bug/question)

Multipart decorators didn't add information for the swagger spec.

this issue can help you : #378

Thanks for the fast response!
this helps:
@Operation({consumes: ["application/x-www-form-urlencoded"]})

But I can't seem to set the type to file

ha ok... Hum we need to improve the multipartfile module for that.

@Romakita do you have an estimate when it will be added? 😄

Work in progress :)

Thanks!
Tested and it's looking good! waiting for #311 will be resolved and I'll upgrade 😄

Hi @Romakita!
Found two small issues,
The new code adds a creates the following swagger:
paths:
  '/api/{username}':
    post:
      consumes:
         - multipart/form-data
      parameters:
        - in: path
          name: username
          type: string
          required: true
        - in: formData
          required: false # This fails validation and it's missing the "name" field
          type: file

There are two issues are:

It is missing the name field
It has a required: false field which fails swagger validation

Thanks for all your help!

Hi @Romakita!
Did you verify the issue? 😄

Hi @TomerAmirV,
This problem is fixed with the latest release. It support only a single file right now. Multiple file isn't support by swagger ui with the swagger 2.0 spec

@Romakita, the second but I reported is in version 4.23.1, after the first fix

Hi @Romakita, any news on the second bug?

ok. I didn't seen your second issue. Currently, the name doesn't exists with the Multipartfile decorator. Multipartfile use anonymous field name.

I think this was fixed, and it's working in version 4.25.0 🎉


Chore: Hide code box when there is no code in the error

Chore: Remove code to set status to error to all pending rules when the status is error

Pull request checklist
Make sure you:

[x] Signed the Contributor License Agreement
[x] Followed the commit message guidelines

Short description of the change(s)

@molant @qzhou1607 before merge this PR, https://github.com/sonarwhal/online-service/pull/31 needs to be merged and deployed.

@sarvaje Just realized that these lines may not be necessary any more with the new changes in online-service. It was used to render the scan failed rules in the server-rendered pages. https://github.com/sonarwhal/sonarwhal.com/blob/21c55feb8931a56ae40fa924e1f799193c427c70/src/server/routes/scanner.js#L116-L122
https://github.com/sonarwhal/sonarwhal.com/blob/21c55feb8931a56ae40fa924e1f799193c427c70/src/hexo/themes/sonarwhal/layout/partials/scan-result-item.hbs#L50-L59

@qzhou1607 Good catch!

@qzhou1607 done!


fix a segfault when processing truncate in cached plans

Hello,
CStoreProcessUtility() removes its relations from the list of relations of
truncate statements before passing it to standard_ProcessUtility(). When
the truncate is run from a pl/pgsql function, its plan can be cached.
Since the filtered list of relations created by CStoreProcessUtility() is
freed after the execution of the truncate, it corrupts the cached plan.
To avoid this, just restore the list of relations of the node when done.
The testcase from #132 created by @emiel (https://gist.github.com/emiel/4d4fd8c5c5ba9173e3175a08bb055be4) reproduces the problem. The problem disappears with this fix, but I don't know if it is enough to close the whole issue.
Best regards,

Thanks for the PR.

Could you provide a test case that reproduces this issue so that we can verify that this fix solves it ?
Could you target it to develop branch instead of master branch ? We are merging it to master only when releasing a new version.
You have restored original table list only if there is a regular table in the truncate list. Table list is not restored if it only consist of cstore tables. Is this intentional ?

thanks again.

Hi,
Just had this bug happen to me as well. Here are results of the test case by @emiel that reproduces mentioned issue on my side.

Testcase results
postgres=# CREATE DATABASE cstore_issue;
CREATE DATABASE
postgres=# \c cstore_issue
You are now connected to database "cstore_issue" as user "postgres".
cstore_issue=# CREATE EXTENSION cstore_fdw VERSION "1.6" ;
CREATE EXTENSION
cstore_issue=# create table queue
cstore_issue-# (
cstore_issue(#     id integer,
cstore_issue(#     diff integer
cstore_issue(# );
CREATE TABLE
cstore_issue=# create table cache
cstore_issue-# (
cstore_issue(#     id integer primary key,
cstore_issue(#     count integer not null,
cstore_issue(#     last_update_at timestamptz
cstore_issue(# );
CREATE TABLE
cstore_issue=# create or replace function process_queue()
cstore_issue-# returns bool language plpgsql
cstore_issue-# as $body$
cstore_issue$# begin
cstore_issue$#
cstore_issue$#     insert into cache (id, count, last_update_at)
cstore_issue$#         select id, sum(diff), now()
cstore_issue$#         from queue
cstore_issue$#         group by id
cstore_issue$#     on conflict (id) do update set
cstore_issue$#         count = cache.count + EXCLUDED.count,
cstore_issue$#         last_update_at = EXCLUDED.last_update_at
cstore_issue$#         ;
cstore_issue$#
cstore_issue$#      -- removing the truncate line resolves the issue
cstore_issue$#      truncate queue;
cstore_issue$#
cstore_issue$#     return true;
cstore_issue$# end;
cstore_issue$# $body$;
CREATE FUNCTION
cstore_issue=# select process_queue(); select process_queue(); select process_queue();
 process_queue
---------------
 t
(1 row)

server closed the connection unexpectedly
        This probably means the server terminated abnormally
        before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.

Can confirm that the segmentation fault doesn't occur anymore after applying the suggested fix by @orgrim

Hello,

A simplified testcase, that works on all supported versions of PostgreSQL:

CREATE TABLE IF NOT EXISTS public.testcase (
	i int
);

CREATE OR REPLACE FUNCTION public.testcase_truncate()
RETURNS void
AS $$
BEGIN
	INSERT INTO public.testcase (i) VALUES (1);
	TRUNCATE public.testcase;
END;$$
LANGUAGE plpgsql;

SELECT public.testcase_truncate();
-- at this point the plan of the truncate in the function should be cached
-- and the next call should trigger the segfault
SELECT public.testcase_truncate();
-- repeat until it crashes, but it should die on the second call
SELECT public.testcase_truncate();
SELECT public.testcase_truncate();

Concerning the branches, I see a develop and a develop_v1x, I guess develop_v1x will become the release branch for v1 when v2 is out?

I can rebase on develop and update the PR, but would there be à 1.6.1 version soon? or before v2?

the list of relation is modified only if there are non-cstore relations just before passing it to the previous utility hook function, so we only have to restore when the other utilities have done their work:

if (otherTablesList != NIL)
{
        truncateStatement->relations = otherTablesList;

        CALL_PREVIOUS_UTILITY(parseTree, queryString, context, paramListInfo,
                                                                  destReceiver, completionTag);
                        /* restore the former relation list. Our
                         * replacement could be freed but still needed
                         * in a cached plan. A truncate can be cached
                      * if run from a pl/pgSQL function */
        truncateStatement->relations = allTablesList;
}

After discussion with @marcocitus  we had a different fix. But I do not want to hijack this pr.
Could you change the line
TruncateStmt *truncateStatement = (TruncateStmt *) parseTree;

to
/* we are modifying the parseTree, therefore we will work on a copy */
TruncateStmt *truncateStatement = (TruncateStmt *) copyObject(parseTree);

Also if you could add a test case to truncate.sql.
Since this is important enough, we will have a patch release containing this.
Thanks

@orgrim  clarification: don't bother rebasing to develop, this will directly go into master.

Hello,
I've just added the regressions test.
Making a with copyObject() would feel better than modifying/restoring the variable, but it would make the patch more complicated. We would have to copy the plannedStatement object for PG >= 10, this adds more preprocess tests.

@mtuncer please review the last commit that uses a copy instead of restoring the input variable
Thanks

@mtuncer please review PR #184 that revert to copy of the input to CALL_PREVIOUS_UTILITY
Regards,

just merged #184, closing this in favor of that one.
Thanks a lot for your efforts on investigating and fixing the issue.


Reject attachment files that are of an unrecognized format

See #427
Helpy should reject Post attachments that have no extension, or that are of an unsupported file type.  A meaningful error message should be displayed to the user.

@scott I want to work on it

@luisalduucin are you working on this?


Refactor faq to hackathon specific repo...

Regarding pull request
Please refactor out faq specific material to easier to update location like hackathon specific repo to prevent need for republishing static site throughout the day.

Event is over, so don't actually need this. Slack worked out pretty well.


how to return to the specified route

just like the title,4.0 version above, how to roll back to the specified one route,and how to back to the first route,thanks

This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out. Thanks!

I'm so sorry,i use a lot of time to find it but nothing get, can you give me a link or address?


Typescript Error

I am getting this error
error TS2320: Interface 'ArrayResourceResult<T>' cannot simultaneously extend types 'ResourceResult' and 'T[]'.
  Named property '$resolved' of types 'ResourceResult' and 'T[]' are not identical.

Reasoning
index.ts -pointing to this line
export interface ArrayResourceResult<T> extends ResourceResult, Array<T> {}

My setup
 tsc -v
Version 1.8.10

Hello @georgebatalinski
Sorry for long answer.
I have released new version 1.0.1 with broken changes.
Try to use it.
Thanks a lot.


Segmentation fault during flake evaluation using overlayAttrs

I'm trying to leverage overlayAttrs and easyOverlay to split out some of my overlays into submodules, but I've hit a weird issue. In this commit specifically, when I added these 4 imported submodules to add stuff to my default overlay, I start getting segfaults in my shell when I do any kind of flake evaluation. Loading the flake into nix repl, nix flake show, anything that results in a full flake eval segfaults.
Oddly enough, when I remove these 4 imports, everything works fine. Is there some kind of memory limit I'm hitting trying to use too many nested submodules?
Currently it segfaults when evaluating the pre-commit checks, but if you disable the checks that their module creates, it then segfaults trying to evaluate the default devshell.

Well, a segfault should never happen. Nix should report the exact issue, whether that's OOM, or a stack overflow, or whatever else, so this behavior is at least a Nix bug, but quite possibly triggered by something in your code.
As far as I know, the most likely causes for a segfault are

Running on macOS; should be fixed in 2.15.0, which is very recent; try with nix run nix -- repl for example? (runs nix master).
Broken stack overflow detection. This currently relies exclusively on a segfault handler for getting reported.
Some other problem; can't exclude that, sadly.

So if you could try with nix master and/or post more details to reproduce this, we may be able to narrow this down.
Note to self: rename easyOverlay.

Related? https://github.com/srid/nixos-config/issues/31
(I'm not using overlayAttrs)

So it was both. On a linux machine:
nix-repl> debug.flake.darwinConfigurations.M1
error: stack overflow (possible infinite recursion)

It's probably because you're both importing easyOverlay and defining pkgs yourself. That's probably conflicting.
I'm surprised that it's not an infinite recursion. Nix can't give a stack trace for stack overflows yet, so I can only speculate about the cause for now.
I'll demote and clarify easyOverlay right now and I think the best solution for you is either to avoid overlays, as more often than not they're not needed, or you could define it as usual in flake.overlays.default; basically like you did before.

That makes sense. I thought from the docs that easyOverlay just added the final arg for modules, but it makes sense that it would provide pkgs itself to facilitate that. Out of curiosity, what solution would you recommend for providing multiple package sets like I'm doing with overlays? If I wanted to avoid overlays, that is?
Side-note, I'll test on a Linux machine from now on when I hit these.

providing multiple package sets

Are you providing them to some other flake or is it for internal organization?
In the latter case you get the same effect by defining packages in packages. Things that depend on your custom packages (including other custom packages) could get them from config.packages.
pkgs.callPackage won't be aware of those, but you can pass them like so pkgs.callPackage ./some-file.nix { inherit (config.packages) my-dep; }.
If that gets annoying, you could define myCallPackage = pkgs.newScope config.packages; in a let binding, option, or module argument. That way the package arguments are selected from config.packages first and pkgs second.

Mostly just for internal organization, for when I need to pull unstable/master versions of packages specifically and use stable by default for example. Since importing package sets aren't a package type, I can't put them in config.packages or perSystem.packages, but I ended up just adding options for perSystem.lib to hold them, and it works a treat.
This is a much cleaner method of doing this than putting everything into overlays. Thank you!


Fix a typo in 01-prisma-and-typeorm.mdx

Describe this PR
This pull request fixes a typo in the documentation.
Changes

Fix a typo.

Thanks so much @Belkacem-Bouzerzour , good catch. Also, kinda fun sentence. So I am glad you fixed it. ;-)


Remove version constraint on package:analyzer

Currently the constraint is preventing https://github.com/flutter/devtools from updating to the latest version of mockito:
Resolving dependencies... (1.1s)
Because stager >=0.2.2 depends on analyzer >=5.1.0 <5.6.0 and mockito >=5.4.1 depends on analyzer ^5.11.0, stager >=0.2.2 is incompatible with mockito >=5.4.1.
So, because devtools_app depends on both mockito ^5.4.1 and stager ^1.0.0, version solving failed.

Closing because this was fixed with:

https://github.com/bryanoltman/stager/pull/46
https://github.com/bryanoltman/stager/pull/47


Set Up Codespace dev environment

Done, next version to include dockerized version from our own github docker registry


Fix CLI options

Add missing options to minimist. This removes "Ignored unknown
option:" warnings for options that actually exists.
Put more interesting options closer to the top.
Consistenly use full sentences.

Thanks!


Flattened PDF is low resolution

The flattened PDF file produced by flatten_pdf() is in an unfortunately low resolution. Can this be adjusted?

I had the same issue, though I didn't try to find a solution. I just left the PDF un-flattened. You can probably use another tool or more standard Python library to flatten it properly if you need to.
Following in case the issue is resolved.

I ended up using a different tool for this (PyPDF) but had to add extra code in order to make the fields read-only by changing the bit position of the editable form fields.


AMA-961: Added template pages and corresponding _assets.

Updated test templates and added helper pages to navigate site.
Incorporates https://github.com/cilt-uct/Brightspace-HTML-Templates/pull/4

Added 2 new banners.

updated footer style.

Replaced line.png to amathuba_logo.png in footer

Deleted video template page.

Hmm: Files changed 1,825
Why is this such a massive PR? Do we need the whole of fontawesome checked in here?

Hmm: Files changed 1,825
Why is this such a massive PR? Do we need the whole of fontawesome checked in here?

It is to stay consistent with the version of the template - essentially each version contains the third party styles and scripts that it uses. This means that a lesson page created with V3/V2/V1 will still work later on when it is copied.

Please discuss with me before updating anything on production.

My issue with this is that where have a versioned set of assets for a 3rd-party lib, e.g. fontawesome-free-5.9.0-web we shouldn't also version that under a template version. It's not like it's going to change and it's a massive duplication of files that makes template updates very large when they should be very small.


for ... of support data

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of
Even if it exists, I could not find it by either searching for "for" and "of" individually as well as "for ... of". It it does exist on the site, it's search visibility should be improved.

Is for of not accomplished with symbol-iterator? Wouldn't it make more sense if caniuse would add ES6 Symbols? There's already an issue #3475 which would cover it!?

it is also not found by "for of loop" which is not nice

Available at https://caniuse.com/#feat=mdn-javascript_statements_for_of
though it would be nice if it was found searching for "for of" so will leave this open

This appears to be working now:
https://caniuse.com/?search=for of

Ah yes, I did fix that.


 While I'm trying to figure out why that is and how to improve it, it would be great if submissions that were suspected to be spam by reCAPTCHA were still saved in the database (not necessarily sent by email) but accessible in a different view or something, like a "Junk" folder. Perhaps it could be a setting?
Thank you!

Closing due to age.

Ah.


How to modify MB1 & MB2 BCTs and how to sign and store with keys

Hi,
I'm trying to figure out how to modify the BCTs or any other modifiable parts of the Jetson Orin Nano boot process when using meta-tegra.
Is there a guide I'm missing that explain how to do it and also explain how to use keys to sign these parts?

Hi @kunoh
You shouldn't modify MB1 and MB2.
Could you please elaborate about the changes that you need ?
Are you referring to secure boot ?  if so, following our wiki page below
https://github.com/OE4T/meta-tegra/wiki/Secure-Boot-Support-in-L4T-R35.2.1-and-later


PRi_Cam_Web_Interface not cloning

Hi,
I'm having an issue installing the PRi_Cam_Web_Interface.
I did all the updates etc.
When i use the command on my Raspbian Jessie its not really doing anything:

Any idea what my problem can be?
Thanks in advance!
Nick

Looks like the raspberry  is not reaching the internet for some reason.
Try ping github.com
To see if that can see the github site. CTRL-C will stop the pinging

Internet works fine and github is accessible:

I haven't seen a problem with the cloning part before. This is what the normal ouptut and I just rechecked it.
git clone https://github.com/silvanmelchior/RPi_Cam_Web_Interface.git
Cloning into 'RPi_Cam_Web_Interface'...
remote: Counting objects: 2330, done.
remote: Compressing objects: 100% (11/11), done.
remote: Total 2330 (delta 2), reused 0 (delta 0), pack-reused 2316
Receiving objects: 100% (2330/2330), 3.88 MiB | 292.00 KiB/s, done.
Resolving deltas: 100% (1382/1382), done.
Checking connectivity... done.
Does it create a PRi_Cam_Web_Interface folder?
I'll check to see if it is possible to get any logging on the git clone process

Couple of other thoughts. I suspect this is not specific to this github repository but with any git clone process. It might be worth checking trying a different clone like wiringPi to see if that is the case.
Are you using a wifi connection or direct lan? There have been some reports of the routing getting confused if both are active and stopping the clone from proceeding. If you can try with just a wired connection.
Other users traced this down to a router problem which was resolved by rebooting their router.

I did a complete re-install of Raspbian and now it works.
Thanks!


Option to highlight movable pieces

It would be nice to be able to highlight the pieces that are movable.

The feature, for highlighting the movable pieces, was added in this PR https://github.com/2rhop/checkers/pull/4 However I will keep this issue open because we need to set it as optional, something like a checkbox in the popup at start


add hubble-ui to multi-arch-images repo

Signed-off-by: Nick M<EMAIL_ADDRESS>Description
This PR adds Cilium hubble-ui to the multi-arch-images repo
Type Of Change
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Docs
[x] Installation
[ ] Performance and Scalability
[ ] Security
[x] Test and/or Release
[ ] User Experience

Notes
images have been built and tested in my cluster, can try them out here;
https://hub.docker.com/r/mcfio/hubble-ui-dev
https://hub.docker.com/r/mcfio/hubble-ui-backend-dev

Great work, if you could also please update the schedule workflow which will help with the image being kept in sync with new.changes upstream that would be awesome!

Great work, if you could also please update the schedule workflow which will help with the image being kept in sync with new.changes upstream that would be awesome!

Done!


Initializing model with date string fails to display viewValue

Bug description:
if ngModel value is initiated with date string (say, from a DB), input viewValue fails to display default value when using ng-model-options="{ timezone: 'UTC' }" this is because the convertTimezoneToLocal method in dateparser does not make sure the first parameter (date) is a valid date string. This could easily be solved by setting parameter value to new Date(), such as
function convertTimezoneToLocal(date, timezone, reverse) {
    date = new Date(date); // this is the code addition
    reverse = reverse ? -1 : 1;
    var dateTimezoneOffset = date.getTimezoneOffset();
    var timezoneOffset = timezoneToOffset(timezone, dateTimezoneOffset);
    return addDateMinutes(date, reverse * (timezoneOffset - dateTimezoneOffset));
  }

Link to minimally-working plunker that reproduces the issue:
http://plnkr.co/edit/g2Pjtvq0Z531SHDwXI6l?p=preview
Version of Angular, UIBS, and Bootstrap
Angular:
1.5.6
UIBS:
1.3.3
Bootstrap:
3.1.1

here is the same plunkr with the ng-model-options removed: http://plnkr.co/edit/wSVVpNpFeQ0F5LdZtUsF?p=preview

We officially do not support using the string as the model - I highly recommend it be converted to a date object beforehand.

@neilsoult, this is documented and has been discussed previously in an insanely large number of issues.  Per the issue template and our project documentation, please be respectful of our time by adhering to said information.  Thanks.

Yea, maybe you failed to see me closing the issue. Sorry to be an insane waste of your time and energy.


Adding Glassmorphism-loader

Is your feature request related to a problem? Please describe.
When we open the website we a good-looking loader.
Describe the solution you'd like
I am going to add a loading effect using glassmorphism.
Additional context
https://user-images.githubusercontent.com/98695632/179336845-f7d6ae75-e36e-4a68-bcc2-9d35aa3fbd7c.mp4

Hey, this is available on YouTube too. Can you work more on it and make something different? Then share the video again ! I will assign this issue to you once you make something different

https://user-images.githubusercontent.com/98695632/179339156-e0ed8cda-f27a-4840-ac82-695659c0210d.mp4
Can I add this??

Cool go on

Next time please link the issue with the pr!

Next time please link the issue with the pr!

OK mam,
Thank You!!


2075: some dialogs email settings unenroll not keyboard navigable

What are the relevant tickets?
https://github.com/mitodl/mitxonline/issues/2075
Description (What does it do?)
Resolves in issue with using the keyboard to navigate and control the browser when the either the unenroll modal or email settings modal is open for a course enrollment.
How can this be tested?
You should have a course created and be enrolled.

Visit http://mitxonline.odl.local:8013/dashboard/.
Using only your keyboard, open the unenroll modal or email settings modal from the course enrollment card.
Verify that you can move focus to one of the buttons on the modal.  When you press enter, the focused button should perform it's expected action (close the modal, or submit).

@collinpreston Actually, looking at the code, I suspect that renderProgramUnenrollmentModal has the same issue. Might be good to change that here, too.


Re-factor the idFactory functionality, used in the core/-code, and move the fontID generation into it

Note how the getFontID-method in src/core/fonts.js is completely global, rather than properly tied to the current document. This means that if you repeatedly open and parse/render, and then close, even the same PDF document the fontIDs will still be incremented continuously.
For comparison the createObjId method, on idFactory, will always create a consistent id, assuming of course that the document and its pages are parsed/rendered in the same order.
In order to address this inconsistency, it thus seems reasonable to add a new createFontId method on the idFactory and use that when obtaining fontIDs. (When the current getFontID method was added the idFactory didn't actually exist yet, which explains why the code looks the way it does.)
Please note: Since the document id is (still) part of the loadedName, it's thus not possible for different documents to have identical font names.
Implements the idea from https://github.com/mozilla/pdf.js/issues/11610#issuecomment-587099759

/botio test

/botio-linux preview

Thank you for improving this!


Wrong secret found

Have a look at this token
eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJlbWFpbCI6IjlhbnZ4QGhpdGJ0cy5jb20iLCJpc3N1ZWQiOjE1MTE4NzUyNDg5NDYsImZyb21JUCI6IjEwMy4yNTIuMjAyLjEzNSJ9.7IWrW_E7raEajHOHCB44YYgX_9RbfUALTwQehFeGcs4
The cracker give me Zzfu as a secret, which is invalid.

Oops, I just read the end of your readme, shame on me!
Sorry for the trouble.


"Approve and Merge" button on Comments and/or Files changed page

I frequently write "LGTM!" comment and push Approve button on Files changed page of PR, then redirected to Comments page and then push Merge button.
Because that redirection is quite slow, it'd be better if we have Approve and Merge button on Files changed page.
Also, Sometimes I write additional review comments on Comments page before approving. So it's nice to have that button on Comments page too.

Duplicate of #2700

Thank for opening the issue, will look into it

This request sounds like the opposite of https://github.com/sindresorhus/refined-github/issues/883
That request was about "Approving from the Conversation tab" and this one is about "Merge from the Files tab"
Neither one is particularly easy to implement, but this is harder: merging a PR means also writing the commit title and message, so to "Approve and merge" we have to ALSO show those two fields inside the review box.
Can't do. It would be too much.

Is your repo set up to require approvals before merging? Because if not, you don't need to Approve and merge: just leave a regular comment and merge from the Conversation tab.


You need go 1.8 to build this.

In regards to the first go get issue, use lowercase:
$ go get github.com/robustperception/pushprox/client

I'm presuming you figured this out, if not please let us know.


API changes - separate calls etc. Replaces #276.

REPLACES: https://github.com/mattermost/mattermost-plugin-apps/pull/276
Summary
Add separate calls for each function on Apps (submit, form source, form submit and lookup). Also updated the filtering with the new logic.
This PR also piggybacks the renaming of markdown and error to text, and filtering out "white space labels" (to avoid no text labels on post options and channel header).
Notes for testing: This is a breaking change. All Apps will need to be updated to work properly. The test app will be updated to fit the new approach.
Ticket Link
https://mattermost.atlassian.net/browse/MM-39092
https://mattermost.atlassian.net/browse/MM-39096
https://mattermost.atlassian.net/browse/MM-31121
https://mattermost.atlassian.net/browse/MM-33532
Related Pull Requests
Webapp: https://github.com/mattermost/mattermost-webapp/pull/9263
Mobile: https://github.com/mattermost/mattermost-mobile/pull/5877
Test App: TBD
Breaking Changes

@larkox: TODO

The following apps need to get updated:

[ ] Examples
[ ] Test app
[ ] ServiceNow
[ ] Zendesk
[x] gCal

Codecov Report

Merging #296 (07c3087) into master (5be5669) will increase coverage by 1.29%.
The diff coverage is 57.34%.

@@            Coverage Diff             @@
##           master     #296      +/-   ##
==========================================
+ Coverage   25.96%   27.26%   +1.29%
==========================================
  Files          73       75       +2
  Lines        4156     4266     +110
==========================================
+ Hits         1079     1163      +84
- Misses       2970     2992      +22
- Partials      107      111       +4

Impacted Files
Coverage Δ

apps/call_response.go
0.00% <0.00%> (ø)

apps/field.go
0.00% <ø> (ø)

apps/locations.go
0.00% <0.00%> (ø)

server/httpin/restapi/call.go
84.21% <ø> (-1.95%)
:arrow_down:

server/proxy/enable.go
4.54% <0.00%> (ø)

server/proxy/install.go
0.00% <0.00%> (ø)

server/proxy/service.go
6.74% <ø> (ø)

server/proxy/uninstall.go
0.00% <0.00%> (ø)

utils/httputils/utils.go
28.57% <0.00%> (+1.90%)
:arrow_up:

server/proxy/form.go
90.16% <25.00%> (-9.84%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be5669...07c3087. Read the comment docs.

@levb CI is complaining about 'server/httpin/restapi/restapitestlib.go:114:41: undefined: httputils.HandleStaticJSON`

@DHaussermann this should be testable with https://github.com/mattermost/mattermost-app-test/pull/14


Fix bug where FAN and DISKSTATE could return OK despite errors

The FAN and DISKSTATE methods only checked the very last state of $state
when deciding which overall status to return which could result in an
overall OK status even if any but the last sub-device returned a non-OK status
(all other methods check(ed) which states got pushed to $out instead).

thanks @bonki looks good


Add order-routing-location-rule template

Creates an Order Routing Location Rule which gives all possible locations rank 0
Co-Authored-By: Steven Slade<EMAIL_ADDRESS>

/shipit


Container component

#596
Command tab

Resources tab

Healthcheck tab - no probes

Healthcheck tab - HTTPS, TCP, command probes as readiness, liveness, and startup checks respectively

Security tab

Multiple containers

Tabs inside of tabs on top of other containers with more tabs is super-weird.

I wish this would have been discussed before implementing; we specifically chose not to do this in 2.x because having multiple simultaneous UI-defined containers is not a hugely demanded task.
But we also have other patterns from 1.x and ideas in consideration for Fleet that could work better for this.
Rio Service has the same pattern and should be consistent, but hasn't been updated.
Sub-tabs having a different background makes all the inputs have no contrast and look disabled.
Sub-tab components don't know to not update the window hash, so whatever the last tab you touch is what's winning right now.

This is missing initContainers, and design consideration for them.

The order of initContainers is also significant, so they need to be arrangeable.

Add/remove

If you accidentally add, the remove button is a mile away in the top-right.
Unclear why REMOVE buttons are the only ones that are yelling (but it is consistent...)
The page scrolls to a random place on add, so I'm immediately lost with more than 1 container. (likely because there's temporarily no tab contents and the page height becomes small, then position isn't restored when the contents comes back).

Health checks have vertical dividers even when dividing nothing.  HTTP(S) checks are unbalanced and waste half the row for cramped headers next to empty divided white space.

Ports are missing name (which are sometimes used) and hostIP (which probably shouldn't be).

Ports was pulled out from the tab section before because to give it more prominence when they were also defining the service; if you're going to have many of them on top of each other it would look less confusing if they were just another tab.

The replica count(or cron schedule, etc) is floating out in space in the middle third of a second row.

Security context has totally different headers and controls style than every other tab.

Node scheduling

Has a default empty require all row
Uses "-" and "x" instead of "REMOVE" like everywhere else.
"Run all pods on specific node" doesn't work/know about any nodes.

Environment variables from resources

Source options aren't limited to things that are in the selected namespace.
At less than ~1500px wide the remove button on env from resources is floating out of the tab.

(i) info bubbles everywhere are unreadably tiny and look superscript/like copyright symbols

We reviewed a couple of other design options to avoid tabs in tabs, but the amount of content that needs to be displayed in workloads with containers, this was the best design option. @vincent99 If you have a suggestion, please let us know what could be used as a design instead. We tried combinations of putting the container component outside the tab so it was 2 sets of tabs and a mix of accordion vs. tab, but this was the most appealing of these other options given the set of requirements.
@mantis-toboggan-md I forgot to ping you earlier today, but I had adjusted the ports requirements in the ticket and got @lvuch to update the mocks in the containers component ticket, but didn't directly message you. I didn't realize you were about to submit something. The mocks already have updated on what a port rule should look like.
InitContainers is on the known issue list, but wanted to first get workloads into a place where container/pod template/workload spec were not all mixed together and try to make it closer to the API itself, before digging into initContainers.
@vincent99 I'm not sure what this was referring to. Is it the containers component or something else?

The replica count(or cron schedule, etc) is floating out in space in the middle third of a second row.

Node Scheduling shouldn't have been touched in this issue and should be fixed as part of https://github.com/rancher/dashboard/issues/637. We are still finalizing the mocks of all the tabs, but @lvuch should be adding them into the issue as we go along.
Issues from the mocks based on the containers issue requirements/feedback from Vince:
Updates for @lvuch

[ ] Review how to handle contrast of tab within tabs
[ ] Review how the info bubbles look. Note: I found them really hard to hover over whenever I've tried to look at one.
[ ] Review how/where could we put the REMOVE for the container.
[ ] Review how to add/drop capabilities, ensure there is bottom padding from the capability:

Updates for @mantis-toboggan-md

[ ] Container name and image show "null" if you focus and blur it. Both should be marked required.

Ports

[ ] Move it into it's own tab
[ ] There isn't enough spacing between the inputs
[ ] Update based on the changes in mocks for adding Name and making Host Port less prominent

Command tab

[ ] The space between working dir textbox and env variables is too much. Is there a way to reduce it?
[ ] Update for Environment variables from resources

[ ] Source options aren't limited to things that are in the selected namespace.
[ ]  At less than ~1500px wide the remove button on env from resources is floating out of the tab.

Resources tab

[ ] The padding under the last set of inputs seems much bigger than compared to the one from command tab. Can we have them match the amount of space between the bottom of the last field and the edge of the tab between all the tabs?

Healthcheck Tab

[ ] The padding under the last set of inputs seems much bigger than compared to the one from command tab. Can we have them match the amount of space between the bottom of the last field and the edge of the tab between all the tabs?
[ ] Hide the vertical dividing bar until a type is selected
[ ] For HTTPs types, move the request headers to the right side so that it's aligned with Path

Security Context

[ ] Update Headers to match other input types
[ ] The padding under the last set of inputs seems different than compared to the one from command tab. Can we have them match the amount of space between the bottom of the last field and the edge of the tab between all the tabs?

@vincent99 I'm not sure what this was referring to. Is it the containers component or something else?

The replica count(or cron schedule, etc) is floating out in space in the middle third of a second row.

We reviewed a couple of other design options to avoid tabs in tabs, but the amount of content that needs to be displayed in workloads with containers, this was the best design option. @vincent99 If you have a suggestion, please let us know what could be used as a design instead. We tried combinations of putting the container component outside the tab so it was 2 sets of tabs and a mix of accordion vs. tab, but this was the most appealing of these other options given the set of requirements.

Tabs in tabs is.. just.. bad.  And beyond that, the outer level of tab isn't even being used to switch between the containers, so there's a really a third invisible level deep of tab with an array of components which each have their sub-tabs repeated.  This is cramming far too much into one screen.
The contents of one container is so long that if you have more than one you can't see which one you're editing anymore and it's very easy to get lost and accidentally edit the wrong container (current scrolling bugs in this PR guarantee this will happen to you, but even without that).
You already know this and don't like it, but I continue to think a good option is not having this in the normal flow at all and using a "Add Sidekick/Container" action and edit interstitial to allow managing multiple containers for the people that need it.  (And again if you're not going to do that, Rio needs to be updated to match as well.)
Otherwise the pattern we established is:
Identity: Name/Description/Type
---
Primary config: Inline fields for the most important part of the resource
---
Tabs: for the rest of the stuff you can do with the resource

So for a workload the definition of the containers would be the middle inline section, and then the rest of the options for the deployment below that, which removes one layer of tabbing.
Then trying to show all the containers in that section is problematic, so.. don't do that.

There's also 2-3 different kinds of containers to handle (regular, init and ephemeral), and you need to be able to set the order of init containers because it matters.
All of this should be unobtrusive to the 90%+ use-case of one deployment = one container.
On edit, auto-injected things like istio sidecars can probably be ignored/hidden by default since the user didn't really ask for them and probably doesn't want to touch them.

Multicluster Apps have a similar situation (multiple sets of answers for different clusters * multiple tabs of questions to answer) so we're planning to do this:

This would give you one container without having to name it by default, and an option to manage multiple and see one of them at a time if you need it (like 1.x, but with a better control); you'd need Add to be a dropdown to choose what kind of container.  Segment the container list by type; Init containers always go first and can be dragged within their section and/ or Λv buttons to arrange.
The workload tabs are still going to be a long way down the page so they'd probably need a header or divider above them to clarify you're leaving the container management zone.
But this is all still a LOT on one page so it would probably make more sense to convert this whole thing into the wizard style of (also somewhat pictured):

Name, description, pick a controller type (this could then also be a bigger control that explains what the heck the difference between the 7 choices is), type-specific options
Container definition (as above)
The rest of the option tabs for the controller (as current, minus Containers)
Review, optionally view and make arbitrary edits as YAML, deploy.

pr feedback changes:

#330  Ports Tab

[ ] The ports component doesn't seem to be aligned with the Add port button

Health Check Tab

[ ] Startup Check needs tooltip text Containers will wait until this check succeeds before attempting other health checks.

@vincent99 Let's plan on merging in the Containers component as is and not be used yet while we work separately on how/where we're going to use this component. Regardless of how the workloads creation/flow is, we would still want this component to be available for at least the initial set of how containers should be used.
I'd say most of your feedback regarding workloads can be tracked in the actual workloads ticket (https://github.com/rancher/dashboard/issues/637), where as we are trying to isolate the containers component for now. We're currently working on new mocks for it.

pr feedback changes:


[Feature Request] safety-rules address should support DNS names

🚀 Feature Request
Passing a DNS name for --safety-rules-addr currently fails:
+ /opt/libra/bin/config-builder validator -t validator.config.toml -n 4 -g 4 -i 1 -s<PHONE_NUMBER>371337133713371337133713371337133713371337133713371337 -o built/ -a /ip4/<IP_ADDRESS>/tcp/6180 -l /ip4/<IP_ADDRESS>/tcp/6180 -b /dns4/ac97282d4970340469b3eee848a225a6-dec481529364f17
5.elb.us-west-2.amazonaws.com/tcp/6180 --safety-rules-addr default1-libra-validator.libra-default-tcb.svc.cluster.local:6185 -d /opt/libra/data
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: AddrParseError(())', config/config-builder/src/main.rs:161:5

Motivation
In order to run safety-rules in a separate Kubernetes namespace (to provide isolation) I need to be able to reference it with a DNS name.

For this specific usage it would be fine to resolve the DNS at startup and use an IP from then on, but ideally it would resolve DNS when connecting.

How would you rate the priority here? We would probably have to reuse the network address multiaddr format to get this without too much engineering.

Within the next month or so would be fine, this is a security improvement so it's not essential right now.


coreuniverse: init at 4.2.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@dan4ik605743 please resolve the merge conflict

ok

@SuperSandro2000 I will say honestly. I do not understand how to solve the conflict. I easier to re-create PR and Branch. You can tell please. I will blogger

nice

@SuperSandro2000 I want to make SCOOP from these packages. It will be easier for me now closed all PR and remove measured packages. And make PR immediately with SCOOP.

@SuperSandro2000 I want to make SCOOP from these packages. It will be easier for me now closed all PR and remove measured packages. And make PR immediately with SCOOP.

I think so, too.

I think so, too.

Only I need your help

@SuperSandro2000 I want to make SCOOP from these packages. It will be easier for me now closed all PR and remove measured packages. And make PR immediately with SCOOP.

I think so, too.

@SuperSandro2000 I'm just the first time dealing with SCOOP. Let me write to Gmail?

@SuperSandro2000 I'm just the first time dealing with SCOOP. Let me write to Gmail?

@SuperSandro2000 check gmail

@SuperSandro2000  Now I woined everything. When I do SCOOP. Delete packages that are already in the branches. I sent you to Gmail what I want to do. I just need to patch holes and that's it. What I am and ask you to help me.


Feature/weekly tasks

Added tables, routers, tests, templates, and internal functions
The fitter gives the option to set weekly tasks.
Comes with a page for managing weekly tasks and another page for editing the task.
Gives the ability to edit, add and delete a weekly task.
Along with this in the feature is included a function for creating the tasks - which aims to create tasks every week for the user (according to the definition of his weekly tasks)

Codecov Report

Merging #146 (ecdd5fa) into develop (bb388ce) will decrease coverage by 0.20%.
The diff coverage is 97.90%.

@@             Coverage Diff             @@
##           develop     #146      +/-   ##
===========================================
- Coverage    99.49%   99.29%   -0.21%
===========================================
  Files           30       32       +2
  Lines          989     1132     +143
===========================================
+ Hits           984     1124     +140
- Misses           5        8       +3

Impacted Files
Coverage Δ

app/internal/weekly_tasks.py
95.58% <95.58%> (ø)

app/database/models.py
95.50% <100.00%> (+1.47%)
:arrow_up:

app/main.py
97.43% <100.00%> (+0.06%)
:arrow_up:

app/routers/weekly_tasks.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb388ce...f7bd688. Read the comment docs.

Codecov Report

Merging #146 (ecdd5fa) into develop (bb388ce) will decrease coverage by 0.20%.
The diff coverage is 97.90%.

@@             Coverage Diff             @@
##           develop     #146      +/-   ##
===========================================
- Coverage    99.49%   99.29%   -0.21%
===========================================
  Files           30       32       +2
  Lines          989     1132     +143
===========================================
+ Hits           984     1124     +140
- Misses           5        8       +3

Impacted Files
Coverage Δ

app/internal/weekly_tasks.py
95.58% <95.58%> (ø)

app/database/models.py
95.50% <100.00%> (+1.47%)
:arrow_up:

app/main.py
97.43% <100.00%> (+0.06%)
:arrow_up:

app/routers/weekly_tasks.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb388ce...f7bd688. Read the comment docs.

Great work! I've added few of my insights :)

Great work! I've added few of my insights :)

Great work, but we still have a little way to go :)


Permanent and preview video filter is different.

Hi,
I have applied contrast filter on video.For example If I set the contrast value 2 and apply this config on video for preview and generate the video using this function generateVideoWithFilter(); with same config string, but the output video is little bit different.Please help me.
Thanks

Hi Wysaid,
How to apply brightness, contrast, saturation and sharpen effects along with lut filters to videos?
I used @adjust brightness 0 @adjust contrast 1 @adjust saturation 1 @adjust sharpen 0 @adjust lut aquaholic.jpg  to add multiple filters to images. How to do the same for videos?

Hi @usmankhan495
How did you resolve this issue? I also applied these filters using @adjust brightness +value @adjust contrast +value @adjust saturation +value @adjust sharpen +value @adjust lut aquaholic.jpg, but I am also seeing preview video and generated video bit different.
Can you please help me with this issue?

You can use different sliders to take different ranges of each filter.
I have used below mentioned ranges based on my requirement, but you can try out with some modifications:
(-1.0f, 1.0f) //brightness
(0.1f, 3.0f) //contrast
(0.0f, 3.0f) //saturation

Thanks @anu30 for your reply
I took three slider for each brightness , contrast , saturation and set value accordingly , now the diffrent issue i am getting is when saving video , the video quality loss
How to save video with high quality ?

Hello @usmankhan495  @wysaid  @anu30  i want to implement the functionality of adjusting brightness contrast saturation of a video and resetting back the video to its original state when sliders are brought back at center. In the git hub source code this functionality is present in a class named as "BasicImageDemoActivity" but for image and not for video.
Anyone, having worked on this or have any idea about this, please help me.
Your help will be really appreciated.


Multimedia decoding is crashing FreeRDP when gfx is used

Hi,
For the last few months I've been experiencing a problem where FreeRDP crashes when I use both multimedia redirection and gfx.
When I run this command
xfreerdp /cert-ignore /v:windows2012r2server /multimedia:decoder:gstreamer /u:user
I can play the Big Buck Bunny videos just fine.
However, if I add gfx into the mix FreeRDP crashes whenever I try playing the videos
xfreerdp /cert-ignore /v:windows2012r2server /multimedia:decoder:gstreamer /gfx /u:user
This is from the latest pull, but I've had this issue for months.
Below is console output:
No gfx (logged in, played video, logged out):
[12:50:03:997] [9358:9359] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpdr
[12:50:03:997] [9358:9359] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpsnd
[12:50:03:997] [9358:9359] [INFO][com.freerdp.client.common.cmdline] - loading channel drdynvc
Password:
[12:50:10:688] [9358:9359] [INFO][com.freerdp.channels.drdynvc.client] - Loading Dynamic Virtual Channel tsmf
[12:50:17:202] [9358:9420] [ERROR][com.freerdp.channels.tsmf.client] - VIDEO: (PLAYING) GST_STATE_CHANGE_ASYNC.
[12:50:17:262] [9358:9420] [ERROR][com.freerdp.channels.tsmf.client] - unknown format:(0).
[12:50:17:262] [9358:9420] [WARN][com.freerdp.channels.tsmf.client] - Format not supported by decoder gstreamer
[12:50:17:279] [9358:9420] [ERROR][com.freerdp.channels.tsmf.client] - VIDEO: (PLAYING) GST_STATE_CHANGE_ASYNC.
[12:50:17:339] [9358:9420] [ERROR][com.freerdp.channels.tsmf.client] - unknown format:(0).
[12:50:17:340] [9358:9420] [WARN][com.freerdp.channels.tsmf.client] - Format not supported by decoder gstreamer
[12:50:25:214] [9358:9359] [ERROR][com.freerdp.core] - ERRINFO_LOGOFF_BY_USER (0x0000000C):The disconnection was initiated by the user logging off his or her session on the server.
[12:50:25:324] [9358:9359] [ERROR][com.freerdp.core.rdp] - DisconnectProviderUltimatum: reason: 3

With gfx (logged in, tried playing video, crash)
[12:49:12:959] [9290:9291] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpdr
[12:49:12:960] [9290:9291] [INFO][com.freerdp.client.common.cmdline] - loading channel rdpsnd
[12:49:12:960] [9290:9291] [INFO][com.freerdp.client.common.cmdline] - loading channel drdynvc
Password:
[12:49:18:406] [9290:9291] [INFO][com.freerdp.channels.drdynvc.client] - Loading Dynamic Virtual Channel tsmf
[12:49:18:406] [9290:9291] [INFO][com.freerdp.channels.drdynvc.client] - Loading Dynamic Virtual Channel rdpgfx
[12:49:23:782] [9290:9294] [ERROR][com.freerdp.channels.tsmf.client] - VIDEO: (PLAYING) GST_STATE_CHANGE_ASYNC.
[12:49:23:859] [9290:9294] [ERROR][com.freerdp.channels.tsmf.client] - unknown format:(0).
[12:49:23:859] [9290:9294] [WARN][com.freerdp.channels.tsmf.client] - Format not supported by decoder gstreamer
[12:49:23:874] [9290:9294] [ERROR][com.freerdp.channels.tsmf.client] - VIDEO: (PLAYING) GST_STATE_CHANGE_ASYNC.
[12:49:23:935] [9290:9294] [ERROR][com.freerdp.channels.tsmf.client] - unknown format:(0).
[12:49:23:935] [9290:9294] [WARN][com.freerdp.channels.tsmf.client] - Format not supported by decoder gstreamer
[12:49:24:440] [9290:9294] [ERROR][com.freerdp.channels.drdynvc.client] - ChannelId 10 not found!
[12:49:24:440] [9290:9294] [ERROR][com.freerdp.channels.drdynvc.client] - drdynvc_order_recv failed with error 1359!
[12:49:24:440] [9290:9291] [ERROR][com.freerdp.core] - drdynvc_virtual_channel_client_thread reported an error. Error was 1359
[12:49:24:440] [9290:9291] [INFO][com.freerdp.client.x11] - Network disconnect!
[12:49:24:440] [9290:9291] [ERROR][com.freerdp.client.x11] - Failed to check FreeRDP file descriptor

Strange it looks like the tsmf channel is not registered when using egfx. Giving a look at that.

@sebastianuw I have tried the same command line options connecting on a Seven host, and multimedia redirection works like a charm with both egfx and without. Any chance, you would retry with an updated master and if it crashes that you would post us a run of xfreerdp with valgrind ?

I tried it yesterday with a pull from master. no dice, Below is the valgrind output of the crash.
http://staff.washington.edu/lisic/freerdp_gfx_crash.txt

@sebastianuw sorry to ask, but would you recompile your freerdp with valgrind helpers activated. Without we have a lot of garbage in the valgrind output.
sidenote: I may be wrong but I have read that on last version of RDP the multimedia channel is disabled when egfx is used, because using codecs is already very efficient. In your case that seems to be the case as we get a lot of uninitialized values in remoteFx. That would suggest that the ocntent is encoded using the RFX codec...

@hardening - are you talking from a server or client standpoint? From Server, MMR and EGFX can coexist.  MMR is just unlikely in cases where EGFX is actually in use - in win 8.1 you have to use Windows Media Player (which is no longer the default video player), and in win 10 MMR will not be used, even with explicitly playback in WMP.  The references in the recent RDS blog appear to be talking about EVOR.

@hardening, sorry about that. Below is a crash log from a debug build.
http://staff.washington.edu/lisic/freerdp_gfx_crash_with_sym.log
I forgot to add, using an older build (e45edb8) I am able to have both work on my 2012r2 server.

@sebastianuw your last valgrind, does not seem to have valgrind helpers activated (requires valgrind to installed on the compiling host and the cmake option activated, ccmake is your friend).
Would you try to git bissect to try to find the faulty commit ? My guess is that it's something that happened in the hardening of MMR or egfx, but having the commit that introduced the bug would be very nice !

@hardening is this what you are looking for in regards to valgrind output?
I used ccmake and set:
CMAKE_BUILD_TYPE                 Debug
WITH_VALGRIND_MEMCHECK           ON
then ran the following:
http://staff.washington.edu/lisic/freerdp_gfx_valgrind.txt


[storage] clientName in listHandles, getRangeListDiff with rename

Added ability to call ShareFileClient.getRangeListDiff() on a file that has been renamed.
Added support OAuth for interface ShareFileClient.uploadRangeFromURL(). Added support to return clientName property in file/directory handle properties in ShareFileClient.listHandles() and ShareDirectoryClient.listHandles().
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
APIView has identified API level changes in this PR and created following API reviews.
@azure/storage-file-share


Wrong number of closing curly brackets in Pydantic Format Instructions

https://github.com/hwchase17/langchain/blob/0fce8ef178eed2a5f898f65c17179c0a01275745/langchain/output_parsers/format_instructions.py#L13
There are too many closing curly braces here: "required": ["foo"]}}}}.
It should only be the following: "required": ["foo"]}}
Happy to open a PR if agreed to fix.

Already fixed by 7f0e847.


Uncertainty around enum memory layout

Currently, enums and structs lay out memory in a suboptimal way. If an enum contains a struct, we actually put pointers inside of those data structures. For example, the enum Result::Ok(some_struct) -- you might expect the memory layout to look like this:
[enum tag][       some_struct       ]
[ 1 word ][sizeof(some_struct) words]

What it actually looks like is this:
[enum tag][   ptr to some_struct    ]
[ 1 word ][sizeof(some_struct) words]

This is not incorrect per se, but it is not ideal. Although, we do actually reserve sizeof(some_struct) space in many cases and just put the pointer in that large space.
This only happens with nested things. I think we can either think of something clever in the old codegen to solve this, or, let it be for now since there are no correctness issues and wait for IR to fix this. cc @otrho what does the IR do here?

I'm 99% sure the IR does the former and embeds structs in each other.  An enum is always lowered to a tagged union struct, as above.  The IR itself definitely embeds, and the sway-core code measures the size of structs as if they're embedded, but I'd have to double check the actual ASM output before being 100% sure.


Adding the iconContainerStyle prop to types

This prop was missing from the type definitions file.

Thanks, @mestevens :+1:


Incorrect pollInterval documentation

Hi, the pollInterval documentation says that it has to be specificed in milliseconds, but it should actually be seconds.
What do you think about changing it from int to Duration?
https://github.com/zino-app/graphql-flutter/blob/eec7d2c5e8d753f7d2d62b2964cb61730caeae42/packages/graphql/lib/src/core/query_options.dart#L129

@philipgiuliani it should really be a Duration

I also think so, especially because it gets converted to a duration anyways: https://github.com/zino-app/graphql-flutter/blob/1ef311a89acc9339da205af409934cd6b66dc1ad/packages/graphql/lib/src/scheduler/scheduler.dart#L44

closed by fe02bb8daed67ae635b97a8d4fe34fa015bbcdd8 on beta


Invalid syntax on Exporter.py

I keep getting an "invalid syntax" on line 30 i.e. def receiveBuffer(tweets):
The only change I made was replace "got" with "got3". Everything else remains the same. Please help.

Hi @profomb, keep using got, the Python 3 (got3) is not stable.

Jeff,
Thanks for getting back to me. Unfortunately the syntax error persists
despite changing to 'got'.
I'll appreciate any further help.
Edward
On Wed, May 10, 2017 at 9:47 PM, Jefferson Henrique <
<EMAIL_ADDRESS>wrote:

Hi @profomb https://github.com/profomb, keep using got, the Python 3
(got3) is not stable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jefferson-Henrique/GetOldTweets-python/issues/75#issuecomment-300577621,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbRJMzjXHn7FeE05d_bE-lgCOARHFAhDks5r4gZOgaJpZM4NWYof
.

--
Website: http://www.anu.ac.ke
Follow us on Twitter: https://twitter.com/africanazarene
Like us on Facebook: https://www.facebook.com/anu.ac.ke?ref=hl
Connect with us on LinkedIn:
https://www.linkedin.com/edu/school?id=14422&trk=NUS-body-school-name
--

Jeff,
It's now working!
I uninstalled python 3 and installed python 2.7.13
Gratefully,
Edward
On Thu, May 11, 2017 at 10:05 AM, Edward Ombui<EMAIL_ADDRESS>wrote:

Jeff,
Thanks for getting back to me. Unfortunately the syntax error persists
despite changing to 'got'.
I'll appreciate any further help.
Edward
On Wed, May 10, 2017 at 9:47 PM, Jefferson Henrique <
<EMAIL_ADDRESS>wrote:

Hi @profomb https://github.com/profomb, keep using got, the Python 3
(got3) is not stable.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jefferson-Henrique/GetOldTweets-python/issues/75#issuecomment-300577621,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbRJMzjXHn7FeE05d_bE-lgCOARHFAhDks5r4gZOgaJpZM4NWYof
.

--
Website: http://www.anu.ac.ke
Follow us on Twitter: https://twitter.com/africanazarene
Like us on Facebook: https://www.facebook.com/anu.ac.ke?ref=hl
Connect with us on LinkedIn:
https://www.linkedin.com/edu/school?id=14422&trk=NUS-body-school-name
--


Need help with group_vars path

Issue Type
this is rather a question than bug / feature request
Molecule and Ansible details
ansible --version
<IP_ADDRESS>
molecule --version
2.0.4

Molecule installation method: pip
Ansible installation method: One of source, pip, OS package

Desired Behaviour
i want molecule to take group_vars path provided in molecule.yml , lets say
provisioner:
name: ansible
options:
vvv: True
inventory:
links:
group_vars: ../../../group_vars/
Actual Behaviour (Bug report only)
currently its showing me error as below
molecule/testrepo/molecule/default/.molecule/../../../group_vars/' does not exist.
while the groups_vars exists at molecule/testrepo/group_vars
Please advise me if am missing anything as am new to ansible.  apologies if this question doesnt make sense
Thank you

while checking for help i found this https://werner-dijkerman.nl/category/ansible/
i tried doing it but not able to
`

123456
provisioner:  name: ansible  inventory:    links:      group_vars: ../../../inventory/group_vars/      host_vars: ../../../inventory/host_vars/

`

If your repo contains molecule/testrepo/group_vars/ or molecule/testrepo/host_vars/, you don't need to configure anything at all.  The only time you need to do the symlinking, is when the group vars live elsewhere.
Ansible by default will load the directory group_vars and host_vars from current directory.
As you see I have a scenario for this very case.  As you see Ansible loaded the vars.

Thank you @retr0h


Better CONLLCorpusReader

Alexis has an improved version of the CONLL corpus reader on https://stackoverflow.com/a/46875652/610569
It'll be good if we incorporate these changes by either:

retaining the name BetterConllCorpusReader and inherit from ConllCorpusReader
refactoring the ConllCorpusReader and remove the hard-coded columns and a more flexible self._get_iob_words

Hi, can I take this one?

@jaehoonhwang sure! Create a pull-request once it's ready and there'll be some review and it'll be merge once the test pass and it's good to go =)

I have implemented the first route: creating another class named BetterConllCCorpusReader.
Is there a way that I can get this tested?

@alvations Just waiting for suggestions.

@jaehoonhwang Sorry been a little busy for a while. I've tried to ask alexis from SO to help look at the PR, lets wait a little =)


player list not added new media

when i added new media list:
actions.add(id, media, true)
it is worked.
BUT
actions.add(id, media, false):
not worked!!!

TypeError: playlist[current] is undefined

Thanks for the issue. I'll look into it soon.


fix: prefer /api/1/production over /production(.json) when available

like fixes https://github.com/home-assistant/core/issues/100112 but I'm not sure this data source is better or worse

Looks like we need to use wNow instead
https://github.com/home-assistant/core/issues/100112#issuecomment-1716821079


Cell runs forever when using interactive.csharp.getVariable in conjunction with console.log in a javascript cell

Describe the bug
Creating the following .dib file and executing the cells (usually) causes the second cell to run indefinitely:
#!csharp

int i = 1234;

#!javascript

let x = 0
interactive.csharp.getVariable('i').then(v => console.log(v))
console.log(x)

.NET Interactive Version
Neither #!about or dotnet interactive --version seemed to work for me, but the vscode extension says it's the following version: v1.0.2309030

OS

[x] Windows 11
[ ] Windows 10
[ ] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[x] Edge
[ ] Firefox
[ ] Safari

Frontend

[ ] Jupyter Notebook
[ ] Jupyter Lab
[ ] nteract
[x] Visual Studio Code
[ ] Visual Studio Code Insiders
[ ] Other (please specify)

Screenshots

You need to await or the promise can complete after the submission is done

That doesn't explain why the cell would run forever.

per my read of it, output should be 0.

maybe more after that promise is fulfilled.

The example code has a race condition. If the cell execution completes before the promise is fulfilled, you'll only get the 0 output, which is by design. This is what I see most of the time. Occasionally though (and presumably more often on some hardware) it does either print both outputs and complete or run forever.
If I await the promise, I see both outputs 100% of the time, and can't reproduce the endlessly-running cell. This suggests to me that the race condition is the reason the cell execution doesn't complete, which would be a bug in our JavaScript evaluation code in the VS Code extension. @RandomFractals  or @Treit, do you see the same when running this:
let x = 0
console.log(await interactive.csharp.getVariable('i'))
console.log(x)

@brettfo?

@RandomFractals or @Treit, do you see the same when running this:
let x = 0
console.log(await interactive.csharp.getVariable('i'))
console.log(x)

No, I do not see the cell get stuck running when using the above code.

Closing this as interactive.csharp.getVariable has been removed as #!share is now supported in JavaScript kernels.


fix: don't depend on std features from lightning-invoice

Fixes #3837. Would be awesome if you could test this today @TonyGiorgio so we can get it into 0.2.0.

No, not working. Still uses is_expired() which is also being a std flag. We'll probably just edit our fork of LDK to allow some of the std flags in wasm32 that don't explicitly use SystemTime::now().

Ahhh, damn it. I removed all the added calls to non-std functions, is_expired existed before, but I didn't consider that I moved it from the gateway to the client crate. So you should be able to just add that function as unimplemented! to your fork, let's figure out a way to test that we don't use std there longer term (#3838).

Thanks for your help. Added a comment there. I'll try a few things out in our patch and get it working again. Thank you!

Actually, you may want to pull out is_expired(), it calls SystemTime::now(). I can add unimplemented or false on our end but you'll run into this as well running the fedimint client in any wasm32 environment
	#[cfg(all(feature = "std", not(target_arch = "wasm32")))]
	pub fn is_expired(&self) -> bool {
		Self::is_expired_from_epoch(&self.timestamp(), self.expiry_time())
	}

	/// Returns whether the expiry time from the given epoch has passed.
	#[cfg(all(feature = "std", not(target_arch = "wasm32")))]
	pub(crate) fn is_expired_from_epoch(epoch: &SystemTime, expiry_time: Duration) -> bool {
		match epoch.elapsed() {
			Ok(elapsed) => elapsed > expiry_time,
			Err(_) => false,
		}
	}

    #[stable(feature = "time2", since = "1.8.0")]
    pub fn elapsed(&self) -> Result<Duration, SystemTimeError> {
        SystemTime::now().duration_since(*self)
    }

Currently this is_expired fn is only called on the gateway and not the user client. But I'll fix, just not sure if worth backporting.


Multilingual documentation for frontmatter params

Fixes #2990

Hello
thank you for submitting this clarification. I've merged your contribution as  7241253c.
Cheers,
Digitalcraftsman


[HOLD] remove unused component; properly check for duped keywords for validation

Why was this change made? 🤔
See #2755 as an alternative - which does de-duplication on the server instead of validation
Fixes #2734 - were were not properly clearing the invalid state when users were removing duplicate keywords, and thus the entire form was incorrectly being marked as invalid and thus unable to submit.
Fixed by ensuring we call the JS method responsible for validating keywords and marking the form as valid when there are no dupes.
Also removed a related keyword component that I don't think is used anywhere (I cannot find any references to it in the code).
HOLD For testing by PO on a server
Note: build is passing, just not updated in github due to an issue with circeci on 9/21: https://app.circleci.com/pipelines/github/sul-dlss/happy-heron/4987/workflows/bde3bd03-1cd9-40d7-a858-e5914551f3bd
How was this change tested? 🤨
Localhost browser and CI
Maybe useful to have a cypress test for this since it's all javascript client side validation at this level, the server side validation is already tested elsewhere)?

Closed in favor of #2755


How Can I Apply environment changes to different environment or switch without apply the changes

** Which Category is your question related to? **
multiple environments
** What AWS Services are you utilizing? **
Cognito, Appysnc, API Gateway, Lambda
** Provide additional details e.g. code snippets **
Let's say

Master environment starts with simple API Gateway
Create a Dev environment from Master and add more categories in Dev environment
Now want to apply the same changes that done in Dev to the Master

What is the best/recommended approach to do this?

Yes
Using your example, just run amplify env checkout Master from the Dev env, and your Master env will have the newly added categories locally, then run amplify push to create them in the AWS.
Just remember each env has its own set of backend resources.

@UnleashedMind
I was able to merge the changes to Master from Dev.
I actually saw some mentioning about checkout but I always had in mind that checkout is more like switching and didn't think that it will merge. looking at the document also wasn't clear.
Anywhere, thank you for your help.

@UnleashedMind
How can I switch to different env without applying the changes in current env?

I guess this will do the trick 😉
https://github.com/aws-amplify/amplify-cli/issues/1862#issuecomment-513025583


Correct set_train_test_split and first test on Silvretta

Correction:
Before, in set_train_test_split, a random split was done for training and testing data, but this also split months of a stake belonging to the same measurement ID into test and training. We want the measurement IDs to belong fully to a fold; otherwise, the loss function doesn't work. Now it uses GroupShuffleSplit from sklearn and also launches an error if a measurement ID is split amongst folds.
Aggregated Predictions: added a function aggrPredict to the xgb regressor that allows to give prediction in the format of measurements (i.e., annual, winter or whatever is used as ID).
First test on Silvretta: Code for CH region, first tests using XGB on Silvretta, correction of pre-processing of winter MB data and pulling from OGGM.

@JulianBiesheuvel, I've made an edit so that the metadata columns are optional in case someone has more metadata than the WGMS format. Now, your ML notebooks work by default (there is no need to specify the columns), and mine works with specified columns as well. Can you have a look and see if it's ok now?


Cache buster hash

Allows for any general cache buster parameter passed within options object from the caller, preferably a hash of content of the blessed file. Fallbacks to a timestamp if no parameter is passed.

Hi @michalkleiner, thanks for contributing.
In the little time I have to work on this project I've been focusing on v4, so am reluctant to make changes to v3 at this time.
The current plan is also to drop cache-busting and leave that up to the consumer. Some discussion around that here: https://github.com/paulyoung/bless.js/pull/32#issuecomment-62604442.
That said, I'm going to close this out.

Ok, fair enough. Thanks for your response.


doc: Create nmstatectl man page

Add the initial manual page for nmstatectl.
Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

IMHO since we have two files with similar content, they should be generated from each other or use a common source. We could write the cli_guide in asciidoc (AFAIK it is also supported by GitHub) and generate the manpage from it: https://github.com/asciidoctor/asciidoctor.org/blob/master/docs/_includes/manpage.adoc

I am going to write the cli_guide to asciidoc and generate the manpage from it. After that, I am going to apply the changes requested.
Thanks!

Looking at other python projects manual page, they are not using the date and version field as the best way to do that is adding a Makefile for the documentation. What do you think? @cathay4t have you any suggestion on how to accomplish that?

Coverage remained the same at ?% when pulling b666139c7792ef6c845e1d9f31e8e2d07d85d7c2 on ffmancera:master into bb9b06287d1e5f04c74c892a1aea14afcc484ab3 on nmstate:master.

All changes requested applied, thanks for reviewing!


Public functions should have /// comments.

The render functions now have /// comments.  Still considering whether the DU cases should.


Cleaned up use of IMAGE_PULL_POLICY

Signed-off-by: Vanessa<EMAIL_ADDRESS>

@vbusch can you review please?

LGTM


Automatically generate the API client based on the public Eduframe documentation

Problem
It's a lot of work to maintain the Eduframe PHP API Client.
Solution
Other projects have shown that an automated generated client works well. We should do the same for this client. Possibly making a PR weekly with the new changes based on the public API documentation.
AC's

[ ] API client is automatically generated
[ ] Major version (breaking changes)
[ ] Documentation on the breaking change and how to update

Out of scope:

Solution for the currently undocumented includes (#16119)
Updating the WP plugin (#613)

Refinement:

The first time the client is generated from the docs it will introduce breaking changes

Upgrade path: major release with breaking changes. We will not update the previous version.

The includes are not documented. Currently the API client does contain some includes.
Split in the following issues:

V2 API client
Issue for the includes (address for the teacher, some other small ones)
Update WP plugin (will not contain breaking changes)

Will need changes to the WP plugin to adopt the API client there as well
Used by:

Startel
PIVO
...

Hey team! Please add your planning poker estimate with Zenhub @adamsosterics @hbarrientosg @Louttche @LuukvH @maikdijkstra @MauriceSchekkerman @Melanie-RK @nikosgiannios @StijnKing @TheAksinator @TimmyyH

Technical Refinement
Use OpenAPI tools to generate this client for PHP.
Similar to how EduframeAPI generates its ruby client

see: https://github.com/Eduframe/eduframe-api-php-client


Added find the missing letter game

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #5103

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in GameZone's README.md
[x] I have added README.md in my Game folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.
[x] I have added my Game to gamesData.json file and it is loading properly on main website as intended.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @AmruthaPariprolu ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit kindly merge this pr

Resolve conflicts

done
kindly verify ..

done kindly verify ..

Your pr will soon now be merged by the admin

@kunjgit
kindly merge this pr

Thank you  @AmruthaPariprolu , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


new syslog back-end

Just thought you might like to know: http://hackage.haskell.org/package/logging-facade-syslog

Hey, nice!
Please feel free to open a PR that adds a reference to logging-facade-syslog to the README.
And just to make sure that you are aware of it, there is logsink which also supports syslog (using your hsyslog library).


Fix bug filtering by status with running build

If we query for builds with a running job in Jenkins, the result field
is set to None, which would crash the filtering code. This change
provides a simple fix to filter out such builds.

@adrianfusco do you have the zuul source in a jenkins system? It looks like it's expecting something other than Tenant, which AFAIK should not be the case for a Zuul system

@adrianfusco do you have the zuul source in a jenkins system? It looks like it's expecting something other than Tenant, which AFAIK should not be the case for a Zuul system

It seems to be true. I'm using the same configuration that we have been updating internally. We should check it.
I'll merge this PR.


rule updates

👍 thanks, awesome to commit these changes directly back from the files tab!

👍 thanks, awesome to commit these changes directly back from the files tab!


Drag and drop between trees

This PR addresses issues #132 and #118, and implements dragging and dropping between more than one tree. Docs and storybook examples have been updated to illustrate how to use. The only requirement to enable this feature is to supply all drag and droppable trees with the same dndType and the same dropCancelled container component method. This dropCancelled method is still optional for single-tree container components and this feature supports the recent external node handling feature. The dropCancelled method is essentially the same onChange prop method supplied to individual trees, but instead it handles all treeData objects of all interactable trees, for all trees that could be impacted by an invalid node drop event. Feedback is welcome.

Looks like the latest commit includes this feature

I think the fact that since some of our ideas seemed to have mirrored each other while being developed in parallel, is probably a good sign it was the right direction for react-sortable-tree to enable this feature. The ideas I'm talking about in particular are:

using tree id's to allow separate tree instances to distinguish between themselves
using the drop method of the React dnd DropTarget spec object of the dropTarget tree itself to update its own treeData object in response to the drop

I like the fact that with your approach, you've simplified the API without the additional complexity introduced by requiring addNewItem and dropCancelled external node dragSource methods in PR #113 . Good job on this feature.


Port to Scala 2.11 - part b

May we expect a port of 0.7.1 to Scala 2.11? Maven currently claims it doesn't exist.
[error] sbt.librarymanagement.ResolveException: Error downloading com.lihaoyi:utest_2.11:0.7.1
[error]   Not found
[error]   Not found
[error]   not found: /vm/home/jenkins/sharedspace/chisel3-full/ivy2/local/com.lihaoyi/utest_2.11/0.7.1/ivys/ivy.xml
[error]   not found: https://repo1.maven.org/maven2/com/lihaoyi/utest_2.11/0.7.1/utest_2.11-0.7.1.pom
[error]   not found: https://oss.sonatype.org/content/repositories/snapshots/com/lihaoyi/utest_2.11/0.7.1/utest_2.11-0.7.1.pom
[error]   not found: https://oss.sonatype.org/content/repositories/releases/com/lihaoyi/utest_2.11/0.7.1/utest_2.11-0.7.1.pom

(I'd re-open #3 for this, but I can't.)

nope


Understanding the paper

Thanks for the great job. I have some difficulty in finding if tau_sr, tau_dr, J(tau_sr), and J(tau_dr) are four outputs from one or multiple networks that are gonna be used later in some loss constraints?
All of them are being predicted by a neural network or some are calculated like the one in "deformable GAN"?
Any help?

All predicted T_sr(pk), J_sr= kp_detector(s), same for d. It is called value and jacobian.

Hi @AliaksandrSiarohin
I am reading your paper and trying to understand bits in the code. I am unable to understand how jacobian and is being calculated and used.
Can you please describe it in brief in a layman's term?
Thank you..


Do notifications on Kindle Fire FireOS work? (in my case, no)

Expected Behaviour
Notifications should fire on Kindle Fire OS. (I do not know if the FireOS platform is supported or not - the documentation isn't entirely clear on this point). I use the Firebase Cloud Messaging SenderID on Android. It's not clear from the documentation whether any additional steps are required for FireOS, or whether it will even work.
Actual Behaviour
I have an app that does notifications quite well on iOS and Android devices. When I try it on a Kindle Fire device, when the register function is called, it never returns, e.g. in the following code block, no console statement in any branch below is printed.
$cordovaPushV5.register()
    .catch(function(response){
	console.log('push register - failed!');
    })
	.then(function(registrationId) {   // register to get registrationId
	    console.log('register returned');
	}, function (err) {
	    console.log("Register error " + err);
	});

Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Amazon Kindle Fire HDX 8.9 (4th Generation), FIreOS <IP_ADDRESS>
Cordova CLI version and cordova platform version
cordova --version
7.0.1
cordova platform version android
Installed platforms:
android 6.2.3
ios 4.4.0
Available platforms:
blackberry10 ~3.8.0 (deprecated)
browser ~4.1.0
osx ~4.0.1
webos ~3.7.0
cordova --version                                    # e.g. 6.0.0
cordova platform version android                     # e.g. 4.1.1

Plugin version
cordova plugin version | grep phonegap-plugin-push
phonegap-plugin-push 1.10.4 "PushPlugin"
cordova plugin version | grep phonegap-plugin-push   # e.g. 1.5.3

Sample Push Data Payload
Sample Code that illustrates the problem
Logs taken while reproducing problem
Attached is an android log file. Two things that caught my eye:

I/com.amazon.identity.auth.device.appid.AbstractAppIdentifier(11053): Finding API Key for com.ionicframework.<myapp>
D/VendorDisplayManagerGlobalCallback(11335): callGetInstance: nil
I/com.amazon.identity.auth.device.utils.ThirdPartyResourceParser(11053): Unable to get api key asset document: api_key.txt
W/com.amazon.identity.auth.device.utils.ThirdPartyResourceParser(11053): Unable to get API Key from Assests
I/com.amazon.identity.auth.device.utils.ThirdPartyResourceParser(11053): Attempting to parse API Key from meta data in Android manifest
I/com.amazon.identity.auth.device.utils.ThirdPartyResourceParser(11053): Attempting to parse API Key from meta data in Android manifest
I/com.amazon.identity.auth.device.appid.APIKeyDecoder(11053): Begin decoding API Key for packageName=com.ionicframework.bookship
D/com.amazon.identity.auth.device.appid.APIKeyDecoder.PII(11053): ApiKey/PackageName is null. pkg=com.ionicframework.<myapp>:<obscured>
W/com.amazon.identity.auth.device.appid.APIKeyDecoder(11053): Unable to decode APIKEy for pkg=com.ionicframework.<myapp>

and
V/Push_Plugin(10934): execute: action=init
V/Push_Plugin(10934): execute: data=[{"android":{"senderID":"440123924572"},"ios":{"alert":"true","badge":"true","sound":"true"},"windows":{}}]
V/Push_Plugin(10934): execute: jo={"senderID":"440123924572"}
V/Push_Plugin(10934): execute: senderID=440123924572
D/SystemWebChromeClient(10934): http://<IP_ADDRESS>:8101/: Line 28 : push initialization done
I/chromium(10934): [INFO:CONSOLE(28)] "push initialization done"
W/InstanceID/Rpc(10934): Failed to resolve IID implementation package, falling back
W/PackageManager( 1619): com.google.android.gms is not installed for user 0
W/InstanceID/Rpc(10934): Google Play services is missing, unable to get tokens
E/Push_Plugin(10934): execute: Got JSON Exception MISSING_INSTANCEID_SERVICE
D/Push_Plugin(10934): no icon option
D/Push_Plugin(10934): no iconColor option

Suggests that perhaps this Plugin won't work on FireOS, as potential Google libraries are missing? But I am not quite sure....
FireFail.log

@viking2917 your FireOS doesn't have Google Play Services installed and that's the root of the problem.
W/InstanceID/Rpc(10934): Google Play services is missing, unable to get tokens

@macdonst Thank you Simon! Is it your understanding that is normal for FireOS? I see that there is a  cordova plugin that installs the services, suggesting it's normal they are not installed and some other means are necessary. Is there a particular reason not to just use the plugin, if you have experience in this area?

Actually @macdonst thanks for your help again, but never mind my question for now. I will go do my homework about the best way to install the services.

so, @macdonst, for clarity - is FireOS supported in this plugin as a matter of policy, or no? (i.e if I manage to get Google Play Services installed on a FireOS device will it work?) I'm having trouble figuring out how to get the services onto the device via my app, and if it's simply not going to work in general, it might be worth a note in the platforms section that while Android is Supported, FireOS is not).
Thanks for your help!


newrelic segments of RedisCluster in redis-py didn't be captured by agent

Description
NOTE: # ( Describe the problem you're encountering. )
[TIP]:  # ( Do NOT share sensitive information, whether personal, proprietary, or otherwise! )
I know that newrelic-python-agent officially supports redis-py library.
However, when using RedisCluster of redis-py (for cluster mode), it does not work. Not only redis-related segments are not visible in the "transaction" tab, but also redis are not visible in the "Database" tab.
Expected Behavior
NOTE: # ( Tell us what you expected to happen. )
Even if using RedisCluster in redis-py, metrics are shown in Database tab. (like below image which is using Redis, not cluster)

Troubleshooting or NR Diag results
NOTE: # ( Provide any other relevant log data. )
[TIP]:  # ( Scrub logs and diagnostic information for sensitive information )
Steps to Reproduce
NOTE: # ( Please be as specific as possible. )
[TIP]:  # ( Link a sample application that demonstrates the issue. )
in web application's request handler,
from gevent import monkey
monkey.patch_all()
from redis.cluster import RedisCluster

client = RedisCluster(
    host="localhost",
)

client.set("a", "b")
a = client.get("a")

Your Environment
[TIP]:  # ( Include as many relevant details about your environment as possible including the running version of New Relic software and any relevant configurations. )
gevent = "21.12.0"
redis = {version = "^4.5.5", extras = ["hiredis"]}
newrelic = "8.8.0"

This issue occurs with or without hiredis. And I tested w/ several newrelic versions <IP_ADDRESS>, <IP_ADDRESS>, and 8.8.0 (latest).
Additional context
[TIP]:  # ( Add any other context about the problem here. For example, relevant community posts or support tickets. )
I guess that agent needs a hook for Redis Cluster (module : redis.cluster)
_process_module_definition("redis.client", "newrelic.hooks.datastore_redis", "instrument_redis_client")

Hello--We recently released v8.9.0 that has support for RedisCluster.  I will close this ticket, but if something is not working for you with RedisCluster, we can reopen the ticket.


Set up cmake to allow makefile with build targets for debug, release, etc.

This works now if you pass the appropriate flags to cmake.


installing latest version breaks pip and all other packages

yt-dlp 2022.7.18 requires brotli; platform_python_implementation == "CPython", which is not installed.
yt-dlp 2022.7.18 requires mutagen, which is not installed.
yt-dlp 2022.7.18 requires pycryptodomex, which is not installed.
lingua-franca 0.4.3 requires python-dateutil~=2.6.0, but you have python-dateutil 2.8.2 which is incompatible.
ovos-backend-client 0.0.6a4 requires ovos-utils>=0.0.25a7, but you have ovos-utils 0.0.24 which is incompatible.
ovos-core 0.0.5a28 requires ovos-config>=0.0.5a5,~=0.0, but you have ovos-config 0.0.4 which is incompatible.
ovos-core 0.0.5a28 requires ovos-plugin-manager>=0.0.19a4,~=0.0, but you have ovos-plugin-manager 0.0.18 which is incompatible.
ovos-core 0.0.5a28 requires ovos-utils>=0.0.25a8,~=0.0, but you have ovos-utils 0.0.24 which is incompatible.
selene-api 0.0.3 requires ovos-utils>=0.0.25a4, but you have ovos-utils 0.0.24 which is incompatible.
ovos-phal-plugin-system 0.0.2a5 requires ovos-config>=0.0.5a4, but you have ovos-config 0.0.4 which is incompatible.
ovos-phal-plugin-system 0.0.2a5 requires ovos-utils>=0.0.25a2, but you have ovos-utils 0.0.24 which is incompatible.

What is latest version, can you pip list your env? Sounds like you reverted tonolder version not updated, are you not ignoring the alphas?

closing has errors above dont seem to have anything to do with vosk, this does not pin ovos-utils 0.0.24 which is the source of your error


Ring Target has no effect

This one's easy; just set up a scenario where one of the attacker's moves is blocked by an immunity. Then change the defender's item to Ring Target. It should override the immunity and allow it to show some actual damage, but doesn't.

You should be more specific, the defenders immunities that are from its typing are negated

It's not just type-based immunities: Pikachu Thunderbolt vs. Ring Target Lightning Rod Seaking: 0-0 (0 - 0%) -- aim for the horn next time

But yes will do

Ring target doesn’t change that, The ps dex states “The holder's type immunities granted solely by its typing are negated” @Marty-D please confirm

Just tested in game: tricked Ring Target onto a wild Haunter, used EQ, no damage and still got the Levitate popup.

Soo should we close this issue then ?

.. no there still is a issue with it not negating typing immunities

@AustinXII you still up for it ? I feel i can handle this one pretty easily

Done. Now awaiting merging.

Yeah it’s an easy one just haven’t had time to be on a computer, but yes feel free to tackle anything that isn’t done


Support multiple versions of Fast DDS in CI

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.17%. Comparing base (db40e71) to head (2784340).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   22.59%   22.17%   -0.42%
==========================================
  Files          46       46
  Lines        3895     3891       -4
  Branches     2048     2048
==========================================
- Hits          880      863      -17
- Misses       2336     2364      +28
+ Partials      679      664      -15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[feature] Vanilla JS implementation (for Django)

What problem does this new feature solve?
Be able to integrate Wallet Connect anywhere
Describe the solution you'd like
An example on how to integrate Web3modal with just javascript, like this example which is outdated:
https://github.com/WalletConnect/web3modal-vanilla-js-example

we don't support CDN at the moment, you can keep track of the following issue for updates https://github.com/WalletConnect/web3modal/issues/1354


MIT license?

I noticed that there is no license attached to this library. May i suggest licensing it under the MIT license and dropping a LICENSE.md file in the repo with a copy?
https://opensource.org/licenses/MIT has a good copy.
This could have been a pull request but it is more appropriate for the original author to explicitly state the license under which the code is released.

@BlakeGardner I have added LICENCE file in master repository today with latest version.
Thank you for your help.