rename command line options and update doc

fix typo in development.md

Type of change:

[x] Bugfix

What this PR does / why we need it:

fix typo in development.md
Pre-submission checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Sorry for delay. Thanks for your contribution.
In fact, after https://github.com/apache/apisix-ingress-controller/pull/826, this configuration item has been removed.
Can you help replace --apisix-base-url with --default-apisix-cluster-base-url  and --apisix-admin-key with --default-apisix-cluster-admin-key?

Can you help replace --apisix-base-url with --default-apisix-cluster-base-url and --apisix-admin-key with --default-apisix-cluster-admin-key?

PTAL. @tao12345666333

Codecov Report

Merging #848 (154d263) into master (de52243) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   32.12%   32.12%
=======================================
  Files          70       70
  Lines        7724     7724
=======================================
  Hits         2481     2481
  Misses       4968     4968
  Partials      275      275

Impacted Files
Coverage Δ

cmd/ingress/ingress.go
78.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de52243...154d263. Read the comment docs.

After the CI is complete, we can merge it.

Hi @cmssczy, thank you for your contribution!
Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :)
[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt


First time access to the dashboard is very slow

Description
The phenomenon is that the first access to the dashboard is very slow, it takes tens of seconds, the second access is faster, I turned on the sql debug mode and found the longest took thirty seconds. Here is what I found by \d+\.\d{4,}s regular to get the SQL slow log statement.
The slow response seems to be caused by a slow sql, let me know if you need any other more detailed info!
2024/12/19 11:15:13 .../webhook/hooktask.go:185:FindUndeliveredHookTaskIDs() [I] [SQL] SELECT id FROM hook_task WHERE (is_delivered=?) AND (id > ?)  AND visibility IN (?,?)) OR id=? OR (type=? AND user.id IN (SELECT org_id FROM team_user WHERE uid=?))) AND repo_id IN (SELECT id FROM repository WHERE (repository.is_private=? AND repository.owner_id NOT IN (SELECT id FROM user WHERE type=? AND visibility IN (?))) OR repository.id IN (SELECT repo_id FROM access WHERE access.user_id=? AND access.mode>?) OR repository.id IN (SELECT team_repo.repo_id FROM team_repo INNER JOIN team_user ON team_user.team_id = team_repo.team_id WHERE team_user.uid=?) OR repository.owner_id=? OR (repository.is_private=? AND repository.owner_id IN (SELECT org_user.org_id FROM org_user WHERE org_user.uid=?))) AND user_id=? AND act_user_id=? AND (created_unix > ?) GROUP BY timestamp ORDER BY timestamp [false public limited 98 1 98 false 1 private 98 0 98 98 false 98 98 98<PHONE_NUMBER>] - 31.661594759s
2024/12/19 11:16:20 ...activities/action.go:465:GetFeeds() [W] [Slow SQL Query] SELECT id, user_id, op_type, act_user_id, repo_id, comment_id, is_deleted, ref_name, is_private, content, created_unix FROM action WHERE act_user_id IN (SELECT user.id FROM user WHERE (keep_activity_private=? AND visibility IN (?,?)) OR id=? OR (type=? AND user.id IN (SELECT org_id FROM team_user WHERE uid=?))) AND repo_id IN (SELECT id FROM repository WHERE (repository.is_private=? AND repository.owner_id NOT IN (SELECT id FROM user WHERE type=? AND visibility IN (?))) OR repository.id IN (SELECT repo_id FROM access WHERE access.user_id=? AND access.mode>?) OR repository.id IN (SELECT team_repo.repo_id FROM team_repo INNER JOIN team_user ON team_user.team_id = team_repo.team_id WHERE team_user.uid=?) OR repository.owner_id=? OR (repository.is_private=? AND repository.owner_id IN (SELECT org_user.org_id FROM org_user WHERE org_user.uid=?))) AND user_id=? AND is_deleted=? ORDER BY action.created_unix DESC LIMIT 20 [false public limited 98 1 98 false 1 private 98 0 98 98 false 98 98 false] - 3.460767331s
Gitea Version
1.22.6
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
2.38.1
Operating System
centos7
How are you running Gitea?
systemd
Database
MySQL/MariaDB

Hi, I think the problem has been resolved in v1.23.0-rc0.

Hi, I think the problem has been resolved in v1.23.0-rc0.

I'll try to upgrade when the official 1.23.0 version is released


Authentication support

@pires , @wallyqs - Although not explicitly tested, this issue is resolved by https://github.com/nats-io/nats-operator/pull/26, right?


Word: Examples shown with Times New Roman font

While everything else is Arial (including Notes). This is an RSD to Word issue.

Updated Word stylesheet


Texture Atlas Adobe Animate 2021/2022 support

What feature do you want to get added on the base engine?
So pretty much I would like to have a support for texture atlases from newer versions of Adobe Animate. A documentation for them would also be useful to add then.
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.


Basic module implementation

Modules are parts of a story

[x] Video
[x] Image
[x] Quiz
[x] Image quiz
[x] Map

Ready to be pulled #16


Todo Item exceeds container when large description

Thanks for the feedback @defiresearchers,
when i have a free time i will fix it

Hello thanks for waiting
I fixed the issue


Feature-Request: Display Myth Rank Level from Myth Rank XP

Display current Myth Rank Level using Myth Rank XP as an input using one of these formulas (either should do the trick):
((((60*((40+1)^2.3)+12.33)+XP)-12.33)/60)^(1/2.3)-40
or
((((60*((40+1)^2.3)-60)+XP)+60)/60)^(1/2.3)-40
could potentially be a bit off due to precision issues, but should at least be close enough.

Ah, forgot this was in here -- was taken care of a little while ago.  Thanks for the formulas, much appreciated!


Inherit zIndex from Group layer if present

Addresses Issue-6654

I think this now functions as expected and should be ready for review

@gberaudo How is this looking?  If if there are any more changes that are needed I'd be more than happy to make them

@ahocevar I took a look at that build failure and while all of the tests passed, it still failed with this message:
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

Any ideas on what could be causing this?

@Patchez I restarted the build. The error you saw was probably because of a timeout of a service that was not available. However, your most recent commit does not address my review comments. Let me know if you have any questions.

@ahocevar Sorry about that, could you clarify what you'd like to see?  I didn't fully understand what you were asking for.

@Patchez I'd prefer to see the zIndex always initialised with undefined instead of 0. To make that work consistently, you can more or less go back to your original version of this pull request where it accepted undefined. You'll only need to modify ol.renderer.Map.sortByZIndex so it returns 0 when one or both compared zIndexs are undefined.

Okay, thank you.  I'll get on that.

Sorry about the delay, I've been very busy recently and haven't had time to work on this.  I'll hopefully be able work on this again soon.

@Patchez Are you planning to finish this?

Sorry, @ahocevar I've been under some crazy deadlines extraneous to this.  I think I'll have a spare moment this week to take a look at wrapping this up but if someone wants to help out with this it would definitely be appreciated.

@ahocevar I'm having trouble understanding what you mean by

To make that work consistently, you can more or less go back to your original version of this pull request where it accepted undefined

Do you mean the first commit (0ab0d659a8de613af8ac3609a5f6917d9e4eff55)?  Because I don't think that one really changed how z-index is initialized.
Sorry again for the delays, I honestly got a little burned out there for a while but I am really trying to get back into this.


[Optimize]Optimize flink application mode status refresh

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

close #3852


feature request

Would be great to have something to creating migration files and run them be able to rollback, something like artisan.
I like how minimalist is the setup and I have in place a simple command to run files for creating tables so would be great to have something from default to handle the database.
Loving the framework btw

Glad you're liking the framework! Tell your friends about it :)
As for your request, I don't think it's a bad idea, it would just need to be done outside the runway project. Runway is just meant to be the "engine" and then whatever packages you install would have the necessary commands that you want. So for what you're asking for, it would make more sense in a database package, which doesn't really exist for Flight. Flight core would probably be the best candidate I suppose but it would have to done by hand so as to not introduce new dependencies.
I'll put this on the todo list, but if you're wanting it sooner than later, you could easily code it up (especially with AI now). I have done this in the past and I think it ended up being less than 500 LOC for the entire migration project.
FWIW I do have a sample database command as part of the flightphp/skeleton project to create a few sample tables in a SQLite database. https://github.com/flightphp/skeleton/blob/master/app/commands/SampleDatabaseCommand.php

Superb, I'll take a look at the boilerplate also I've been looking at phoenix which looks slim and has all the features as phinx, so until there is a core solution, a good idea would be to hint about phinx or phoenix to fill the gap to this particular feature in the docs to save some time for newcomers

This is just personal preference, but all the plugins I suggest in the Awesome Plugins part of the docs site I pick for specific reasons.

Decent documentation.
Relatively simple to learn and implement (reflects Flight's core principles).
Very low and easy config requirements.
Very few dependencies if any.

I didn't feel like Phoenix did that for me. I poked around and found a few others that I did like. This is just a first pass and I haven't dug too deeply into it so take it for what it's worth.

https://github.com/turanct/migraine
https://github.com/Astylodon/Migrations
https://github.com/ruckus/ruckusing-migrations
https://github.com/byjg/php-migration


Add APIs to get used bytes and capacity bytes in a Tachyon cluster

Add APIs to get used bytes and capacity bytes in a Tachyon cluster.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/2827/
Test PASSed.

Would it make sense to expose the Tier granularity info as well?

the main purpose of this is for the client to check whether it is going to run out of cache space soon.  Tier granularity would help as well, but if you really need that detailed info, you get always get it from getWorkersInfo.  In this pull request, we added a convenient way to get top level usage info.

By cache space do you mean all types of storage managed by the worker? Is there a specific use case you are targeting, such as minimizing worker evictions?

Yes, I mean all types of storage managed by the worker.  We have a caching mechanism on top of Tachyon such that we decide what blocks to delete when storage space is running low.

Got it, thanks.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/2828/
Test PASSed.

@ShaoshanLiu I've updated the code to use the necessary API, let me know if you think it makes sense.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/2829/
Test PASSed.


How to get access to PS4 and Switch platforms?

I see HC_PLATFORM_SONY_PLAYSTATION_4 and HC_PLATFORM_NINTENDO_SWITCH mentioned in the source code, but understandably implementation are not in the public repository. Is there a way to get access to them?

Not at this time.  We only to support internal projects on those platforms


ARROW-13076: [Java] Allow ExtensionTypeVector with Struct or Union vector storage

This relaxes the type bounds for an ExtensionTypeVector to the ValueVector interface so that UnionVector and StructVector can be used as the underlying storage. Test was added for an extension type based on StructVector.

Thanks @lidavidm !


{syncthing,syncthing-discovery,syncthing-relay}: unpin go1.19

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg build syncthing syncthing-discovery syncthing-relay

Result of nixpkgs-review pr 249500 run on x86_64-linux 1

4 packages built:

qsyncthingtray
syncthing
syncthing-discovery
syncthing-relay


EditorConfig support

Tried to add EditorConfig support. Please check if I've done it right.

Closes #2462

Thank you for contributing @osipxd!


df: types: DataFlow: Implement syntax for flow where we can specify multiple definitions an Input can be

flow:
  edit_feature:
    inputs:
      feature:
      - seed:
        - Years
        - Trust
        - Expertise
        - Salary

Related: #604
Places that will need updating:

https://github.com/intel/dffml/blob/master/dffml/df/types.py#L517
Somewhere in https://github.com/intel/dffml/blob/master/dffml/df/memory.py dealing with dataflow.by_origin

Closed via https://github.com/intel/dffml/commit/2ed6e172669f9f9c15c96409ea5ed5673c5b6c8b


DISTMYSQL-140: Create dev Jenkins pipeline for Orchestrator

https://jira.percona.com/browse/DISTMYSQL-140

Parametrize MySql tarball used for tests
Use new semi-sync replication plugin when testing against 8.0.26
or higher

This is related to
https://github.com/percona/orchestrator/pull/1 and https://github.com/Percona-Lab/jenkins-pipelines/pull/1333


Access Denied on generated video

Thanks for continuing to develop the library! I've just tested the latest version.
The multienv deployment seem to work perfectly but I'm not able to access the generated video so there might be something off with the permissions 🤔

Bellow if the screenshot of the permissions tab for the generated video, looks like its missing the public read permission.

I'm using latest version(4.0.141) of remotion in case the permissions are on their side 🤔

Ok, please ignore it. I had privacy: "no-acl", set on renderMediaOnLambda 🙈

For some reason this was working just fine before. Commenting out that line fixes the issue 🙂

Glad it works for you! Yeah in the previous version the bucket had ACLs disabled and had all the files public, but since the remotion default deployment method uses ACLs, I changed this package to also use them and this way it's possible to make specific files public/private easily.


WIP: pipeline overhaul

Description
Refactored DefaultPipeline to be more streamlined. Added class and methods documentation. Added basic tests.
Needs modified version of mglib to work (see my PR).
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Added pipeline tests.
Test Configuration:

Python version: 3.8
OS version: Ubuntu 20.04

Checklist:

[x] I have read the Contributing file available here
[x] I have formatted this PR according to PEP8 rules
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

On my computer ocr_page.apply_async doesn't work (normal apply without async works fine). This means that pdf uploaded from the web page are never OCR'ed, while the ones ingested by imap/local are fine.
This problem is not caused by pipelines, since I reverted views/documents.py to a pre-pipeline version and this behaviour is still there.
Could you please try it as well @ciur? Maybe you know what is causing this.

@ciur tests pass fine on my machine. Maybe the worker does not run on travis?
By the way, the bug you noticed with the REST API is solved in this PR. The file that is imported by Django in DocumentUploadView when you use FileUploadParser is actually not a PDF, that's why it shows up as application/octet-stream. If you save file_obj locally you will see that it begins and ends with part boundary strings and you will not be able to open it. You need to use MultiPartParser.


test: dependency convergence check on gRPC and GAX

This PR adds a check to confirm gRPC version in the BOM and GAX's gRPC version converge.
Excluding the opencensus artifact and grpc-grp
This is a compromise to implement the check without waiting for perfect convergence.
The test case ignores opencensus and grpc-grp artifacts because they depend on old gRPC version.
java.lang.AssertionError: The version for io.grpc:grpc-netty-shaded should be one but there are multiple of them:
com.google.cloud:grpc-gcp:jar:1.1.0 / io.grpc:grpc-netty-shaded:1.36.0 (runtime),
io.opencensus:opencensus-exporter-trace-stackdriver:jar:0.31.0 / io.grpc:grpc-netty-shaded:1.27.2 (compile),
com.google.api:gax-grpc:jar:2.11.0 / io.grpc:grpc-netty-shaded:1.44.0 (runtime),
io.opencensus:opencensus-exporter-stats-stackdriver:jar:0.31.0 / io.grpc:grpc-netty-shaded:1.27.2 (compile),
io.grpc:grpc-interop-testing:jar:1.44.0 / io.grpc:grpc-alts:1.44.0 (runtime) / io.grpc:grpc-netty-shaded:1.44.0 (compile),
io.grpc:grpc-xds:jar:1.44.0 / io.grpc:grpc-netty-shaded:1.44.0 (compile),
io.grpc:grpc-alts:jar:1.44.0 / io.grpc:grpc-netty-shaded:1.44.0 (compile),
com.google.cloud:native-image-support:jar:0.11.0 / io.grpc:grpc-netty-shaded:1.44.0 (provided),
io.grpc:grpc-all:jar:1.44.0 / io.grpc:grpc-xds:1.44.0 (compile) / io.grpc:grpc-netty-shaded:1.44.0 (compile),
com.google.cloud:google-cloud-core-grpc:jar:2.4.0 / com.google.api:gax-grpc:2.11.0 (compile) / io.grpc:grpc-netty-shaded:1.44.0 (runtime),
io.grpc:grpc-netty-shaded:jar:1.44.0

There are io.grpc:grpc-netty-shaded:1.27.2, io.grpc:grpc-netty-shaded:1.36.0 and io.grpc:grpc-netty-shaded:1.44.0 in the dependency graph... In order to pass this test, we need to upgrade io.opencensus:opencensus-exporter-trace-stackdriver and com.google.cloud:grpc-gcp:jar to use the latest gRPC version.
Fixes #532  ☕

36b9816 gives an example failure:
Failed tests:   testGrpcConvergence(com.google.cloud.DependencyConvergenceTest): The version for io.grpc:grpc-netty-shaded should be one but there are multiple of them: com.google.api:gax-grpc:jar:2.11.0 / io.grpc:grpc-netty-shaded:1.44.0 (runtime), io.grpc:grpc-xds:jar:1.43.2 / io.grpc:grpc-netty-shaded:1.43.2 (compile), io.grpc:grpc-all:jar:1.43.2 / io.grpc:grpc-xds:1.43.2 (compile) / io.grpc:grpc-netty-shaded:1.43.2 (compile), com.google.cloud:google-cloud-core-grpc:jar:2.4.0 / com.google.api:gax-grpc:2.11.0 (compile) / io.grpc:grpc-netty-shaded:1.44.0 (runtime), io.grpc:grpc-alts:jar:1.43.2 / io.grpc:grpc-netty-shaded:1.43.2 (compile), io.grpc:grpc-interop-testing:jar:1.43.2 / io.grpc:grpc-alts:1.43.2 (runtime) / io.grpc:grpc-netty-shaded:1.43.2 (compile), io.grpc:grpc-netty-shaded:jar:1.43.2, com.google.cloud:native-image-support:jar:0.11.0 / io.grpc:grpc-netty-shaded:1.44.0 (provided)


#869 - Support for @EntityListeners

@phejl Thanks for this PR, does it take in account/solve the point raised in https://github.com/spring-projects-experimental/spring-native/issues/869#issuecomment-879664759 ?

Merged via 5a8d9d423248822052db170b1aa0b7dd1259a8cd thanks.


Error Messages shouldn't have error code

Chaise generated error messages should not include error codes.

duplicated with #722.


Only home page has sidebar and title

When I build your site locally, the home page has a sidebar and a title - but all the other pages don't. Any idea why?

@honzik20 Which version of Hugo are you using?  It'll need to be at least 0.77.0 for it to work correctly

Working for me now with
cascade:
type: "docs"
Thank you

Great, thanks for the update @honzik20 - Is there something i should improve/fix in the documentation?


Your model ir_version is higher than the checker's.

I am a pt model trained by yolov5, and the training environment is torch1.6. When I use the toolkit's onnx conversion, it prompts an error Your model ir_version is higher than the checker's. It should be that the onnx version is too low, I try to increase the onnx version to 1.7. 0, but it is not compatible with the toolkit, it only supports the highest version to 1.4.1. What should I do, can someone help me?
这是翻译：我是yolov5训练的pt模型，训练环境是torch1.6.在我使用toolkit的onnx转换时候，提示报错Your model ir_version is higher than the checker's.应该是onnx版本太低，我尝试提高onnx版本到1.7.0，但是与toolkit工具不兼容，它只支持最高版本到1.4.1.我应该怎么做，有人可以帮助我吗？

I am experiencing a similar problem:
E Catch exception when loading onnx model: socket_v4.0.onnx!
E Traceback (most recent call last):
E   File "rknn/api/rknn_base.py", line 510, in rknn.api.rknn_base.RKNNBase.load_onnx
E   File "rknn/base/RKNNlib/converter/convert_onnx.py", line 494, in rknn.base.RKNNlib.converter.convert_onnx.convert_onnx.__init__
E   File "rknn/base/RKNNlib/converter/convert_onnx.py", line 497, in rknn.base.RKNNlib.converter.convert_onnx.convert_onnx.__init__
E   File "/usr/local/lib/python3.6/dist-packages/onnx/checker.py", line 86, in check_model
E     C.check_model(model.SerializeToString())
E onnx.onnx_cpp2py_export.checker.ValidationError: Your model ir_version is higher than the checker's.

onnx 1.8.0 support would be great

你好，请问你转rknn 转成功了吗

I'm afraid not


[BS] Fetch Pokemon Information

Description

Fetch pokemon information from PokeAPI
Extract PokeAPI response to types that we will actually use
Initially load in 10 pokemon and allow for a "Load More" button to fetch more pokemon

Related Ticket: 1-fetch-pokemon-information

LGTM. Just curious if there's a reason for using Zustand over just a context though?

Less boilerplate. Also, not entirely sure which components need access to the state and wrapping everything in the context provider is inefficient since updating the context will update everything wrapped within it (even components that don't use it at all).


Add option to export google docs

Since the googlecl tool is no longer working and nothing sensible seems to be around I have added the option to export google docs documents. They can be exported with the ExportLink download url.
The extra options are:
-e
--force to overwrite existing files
Hope you find this useful and others as well. Please let me know if you have any questions.

Thanks for doing the initial work on this, I know people have been asking for it. I will do some changes to the logic before releasing a new version.


overwriting output with the prompt

it appears that nushell is working with the latest rustyline almost. when we do things like echo 1 it spits out 1 and then rustyline immediately overwrites it with the prompt. any ideas whether this is problem is withing rustyline or nushell? Is this a known issue?

I think the problem is that nushell doesn't print a newline afterwards. It could be handled better by rustyline though. Zsh uses a trick to end the line with a % and go to the next line if there is no trailing newline. It was something like printing a %, then termwidth-2 spaces and then \r to go back to the start of the line. If the line was not empty, it will overflow to the next line, leaving the % behind. If not, the % will be overwrittem by the prompt.

@bjorn3 - this wasn't an issue with previous versions of rustyline. It seems that more recent versions have this effect.

@gwenn  any ideas? I have validated that nushell is adding a \n, as it did before with prior versions of rustlyine, but with the latest version, on single string outputs rustyline is eating it.
        let mut initial_command = Some(String::new());
        let mut readline = Err(ReadlineError::Eof);
        while let Some(ref cmd) = initial_command {
            readline = rl.readline_with_initial(&prompt, (&cmd, ""));
            initial_command = None;
        }

        if let Ok(line) = &readline {
            line_start = session_text.len();
            session_text.push_str(line);
            session_text.push('\n');
        }

i've also validate with this code that there is 1 \n in the output for multiline output and single string output.
        let crs = session_text[line_start..].matches('\n').count();
        print!("{}", crs);

Isn't that code for the input from readline rather than the output of the echo command?

@bjorn3 - We're asking if there's a way to get the previous rustyline behavior in the recent (8.0) rustyline.

I looked into this.
The problem that nushell is facing probably stems from the introduction of this
    /// Check if cursor position is at leftmost before displaying prompt.
    ///
    /// By default, we don't check.
    pub fn check_cursor_position(&self) -> bool {
        self.check_cursor_position
    }

if I haven't messed to much with the files during my investigation and created some intermediate state
nushell should be able to get their old behaviour back by
// crates/nu-cli/src/line_editor.rs +46
    let config = Config::builder()
        .check_cursor_position(true) // <--- introducing this line
        .color_mode(ColorMode::Forced)
        .build();

introducing this line into their setup of the rustyline config and then migrate to rustyline_8

Sorry, it should have been considered as a breaking change:
https://github.com/kkawakam/rustyline/releases/tag/v7.0.0
https://github.com/kkawakam/rustyline/pull/448#issuecomment-703218098
https://github.com/kkawakam/rustyline/issues/445

Thanks for the info.


Missing Resource.Designer.cs fix

PR Details
The Resource.Designer.cs file is required to compile Android apps with Xamarin. By default the file is not included in either Stride/Xenko 3.x or 4.x and is instead generated when the Android project is first compiled. A change in 4.x makes this file a requirement for Stride's Project Generator to create a new Android project, when the file isn't found an error is thrown and the project fails to create.
Description
An empty Resource.Designer.cs.t4 file has been added to the Android template. This file is regenerated in a project specific context when the user first compiles their Android app via Stride or Visual Studio.
Related Issue
#827
Motivation and Context
While workarounds are possible (documented in the above issue), this bug prevents the Android platform from working "out of the box" on impacted versions of Stride.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

If the fix is accepted I'll create a separate PR for master-4.0

great, thank you! this was a really annoying bug and the fix looks surprisingly easy.


Testing Azure MSI Integration

Develop test cases and perform testing for the Azure Managed Identity feature to ensure compatibility and reliability.

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx


2 fixes for usvg Tree writer

Firstly, I fixed an issue where a call to .unwrap would cause a panic with the following svg file (from the test suite):
 <svg id="svg1" viewBox="0 0 200 200" xmlns="http://www.w3.org/2000/svg"
     xmlns:xlink="http://www.w3.org/1999/xlink">
    <title>With invalid child via `use`</title>

    <defs id="defs1">
        <g id="g1">
            <path id="path1" d="M 100 15 l 50 160 l -130 -100 l 160 0 l -130 100 z"/>
        </g>
        <clipPath id="clip1">
            <use id="use1" xlink:href="#g1"/>
        </clipPath>
    </defs>
    <rect id="rect1" x="0" y="0" width="200" height="200" fill="red" clip-path="url(#clip1)"/>

    <!-- image frame -->
    <rect id="frame" x="1" y="1" width="198" height="198" fill="none" stroke="black"/>
</svg>

I guess it's not really relevant since it's invalid, but I would say it's still better to just ignore it than let it crash in that case.
Secondly, the writer failed to write the xmlns:xlink attribute for images inside of masks because they weren't checked properly.

I realized another issue, the following SVG will also not be rendered properly:
<svg id="svg1" viewBox="0 0 200 200" xmlns="http://www.w3.org/2000/svg"
     font-family="Noto Sans" font-size="80">
    <title>Linear gradient on text</title>

    <linearGradient id="lg1">
        <stop id="stop1" offset="0" stop-color="white"/>
        <stop id="stop2" offset="1" stop-color="black"/>
    </linearGradient>
    <text id="text1" x="100" y="120" text-anchor="middle" fill="url(#lg1)">Text</text>

    <!-- image frame -->
    <rect id="frame" x="1" y="1" width="198" height="198" fill="none" stroke="black"/>
</svg>

The reason being that since the paint is on a text element, the fill/stroke will be cloned as part of the paint_server_to_user_space_on_use but the ID will be left empty. I think one approach to fixing this would be that when writing the usvg tree, we simply iterate over all nodes and generate a new unique id for all elements where this is missing. I guess we could also override the IDs for existing ones to make sure they really are unique and to also make them more consistent (e.g. paths would get the IDs "path1", "path2", "path3", patterns would get the IDs "patt1", "patt2", "patt3", etc.). Would this be an acceptable change to you or is there a good reason to preserve the IDs of the original SVG file?

So, turns out that there was another bug, because the assumption that a group element in a clip path only contains one element seems to be wrong when the clip path contains more than 2 (converted) text elements. This is why I just went for a for loop now.

I guess it's not really relevant since it's invalid, but I would say it's still better to just ignore it than let it crash in that case.

No, it is... Just to clarify, usvg CLI tool is used mainly for debugging. It's alpha quality at best. You should not use it. I simply have no time to work on it. Only resvg is considered stable and well tested.

because the assumption that a group element in a clip path only contains one element seems to be wrong if the clip path contains more than 2 (converted) text elements

How is this possible? A clip path with a group is always manually generated and therefore can only have 1 element.

No, it is... Just to clarify, usvg CLI tool is used mainly for debugging. It's alpha quality at best. You should not use it. I simply have no time to work on it. Only resvg is considered stable and well tested.

Well, it doesn't seem to bad from what I've seen. And I would need this, so if you're okay with accepting PRs I'd like to work on improving it!

How is this possible? A clip path with a group is always manually generated and therefore can only have 1 element.
I'll look into it.

And I would need this for my use case, so if you're okay with accepting PRs I'd like to work on improving it!

Sure. I just wanted to clarify that only usvg the library is heavily tested. usvg CLI is not.

How is this possible? A clip path with a group is always manually generated and therefore can only have 1 element.

So, if I understood it right, in the normal case a clip path should have a root element (which is a group) and then a number of children consisting of paths/texts (except for this one edge case mentioned in the comments).
https://github.com/RazrFalcon/resvg/blob/7cb1ec4d2801a2d86791c3afb91d933939df83fa/crates/usvg/src/writer.rs#L594-L596
However, when converting the texts to paths, we create a new group node which contains all of the text nodes, and thus if the text elements were part of a clip path, they are not the direct children of the clip path root anymore. Instead, the clip path root will have the group as a child that contains all text nodes.
https://github.com/RazrFalcon/resvg/blob/7cb1ec4d2801a2d86791c3afb91d933939df83fa/crates/usvg-text-layout/src/lib.rs#L62-L66
What's the best course of action here? Should I leave the for loop or should we change how text nodes are appended to the parent? I guess the second one would be better so that we can keep the edge case of a clip path root having another group as a child really be an edge case?

I changed the code with a possible fix. Let me know what you think.
Regarding the gradient problem, I will probably leave that one for a different PR since it requires a bit more thinking from my side.

Hm... I genuinely do not remember why we have a group in a clip path. For one, clipPath doesn't allow groups to begin with. So the comment is correct, it's a usvg hack. And it affects rendering as well.
I think we should update usvg writer and not usvg-text-layout here. Ideally, we should flatten text in clip paths, aka remove groups and styles, but it would be a more complicated task. And even better, ClipPath should have a list of paths, instead of a having a tree of nodes. It would make it a bit special, compared to other containers, but it logically more correct.
And we should definitely start adding tests to usvg...

Okay, I'll see what I can do.

Updating usvg writer would be enough. I will look into other stuff later.

Updating usvg writer would be enough. I will look into other stuff later.
So basically just using a for loop, like I did originally?

And even better, ClipPath should have a list of paths, instead of a having a tree of nodes.

Actually, isn't the problem here that text/path elements can have other clip paths as well? In this case, we need to wrap the text/path inside of another group, because only groups can have other clip paths as well.

I reverted the change to usvg-text-layout.

So basically just using a for loop, like I did originally?

Yep.

Should be done, I also added a comment so that we don't forget about it.

Thanks!


Travis fixes after inClientConfig() changes

Noticed that my docs PR was failing, so I went and looked into it, looks like the number of params / order of params in the GetK8sNetwork() method was changed -- so I went ahead and changed it up in the test suite.
This should go in with version 3.0
originally failing build for reference: https://travis-ci.org/intel/multus-cni/builds/408897159

/LGTM

@dougbtv let's merge the  #87 now.. it is easy to merge it now..

Can you rebase, and merge it.. LGTM ..

@dougbtv we need this patch ?

Kural -- this is now OK because of changes that happened otherwise. We can close this PR, thanks @rkamudhan


Fix heading in "Discard Tabs in Chrome" update article

@kaycebasques this will need to be done against the material-branch

@kaycebasques - as @PaulKinlan mentioned, we've moved to the material-branch full time now. Can you make the change there please?


Update gems versions

Bumping versions of nokogiri and action view due to some security
vulnerabilities reported by dependabot.

We decided to use dependabot to bump the gem versions.


Fix all golangci-lint errors

Issues reported by golangci-lint
Command: golangci-lint run  --out-format=tab  ./...
Before

Issues reported

File
REPORTER
DESCRIPTION

providers/aws/autoscaling.go:65:42
gocritic
commentFormatting: put a space between // and comment text

providers/aws/iam.go:186:19
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(resourceName, "@", "", -1)

providers/gmailfilter/label.go:37:4
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(l.Name, "/", "_", -1)

cmd/import.go:226:41
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(path, serviceName, k, -1)

cmd/import.go:237:66
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(path, serviceName, k, -1)

cmd/provider_cmd_github.go:37:27
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(options.PathPattern, "{provider}", "{provider}/"+organization, -1)

cmd/provider_cmd_google.go:36:28
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(options.PathPattern, "{provider}/{service}", "{provider}/"+project+"/{service}/"+region, -1)

cmd/provider_cmd_keycloak.go:71:28
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(options.PathPattern, "{provider}", "{provider}/"+target, -1)

cmd/provider_cmd_yandex.go:39:27
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(options.PathPattern, "{provider}/{service}", "{provider}/"+folderID+"/{service}", -1)

providers/github/repositories.go:44:2
gocritic
commentFormatting: put a space between // and comment text

providers/gcp/clouddns.go:121:12
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(name, resourceZone.Item["dns_name"].(string), "", -1)

providers/gcp/dataproc.go:103:2
gocritic
commentFormatting: put a space between // and comment text

providers/gcp/gcs.go:180:2
gocritic
commentFormatting: put a space between // and comment text

providers/gcp/gke.go:63:70
gocritic
commentFormatting: put a space between // and comment text

providers/gcp/instances.go:40:7
gocritic
argOrder: probably meant strings.HasPrefix(obj.Name, "gke-")

terraformutils/hcl.go:89:19
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(t.Token.Text, \n, "\n", -1)

terraformutils/hcl.go:90:19
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(t.Token.Text, \t, "", -1)

terraformutils/hcl.go:97:15
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(jsonTest, "\\\"", "\"", -1)

terraformutils/hcl.go:157:6
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(s, "}\nresource", "}\n\nresource", -1)

terraformutils/hcl.go:154:6
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(s, "\n\n", "\n", -1)

terraformutils/json.go:23:6
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(s, "\\u003e", ">", -1)

terraformutils/json.go:21:7
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(string(dataJSONBytes), "\\u003c", "<", -1)

terraformutils/terraformoutput/bucket.go:55:10
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(b.Name, "gs://", "", -1)

terraformutils/terraformoutput/bucket.go:29:10
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(b.Name, "gs://", "", -1)

build/main.go:80:2
gocritic
commentFormatting: put a space between // and comment text

terraformutils/terraformoutput/hcl.go:104:16
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(k, strings.Split(k, "_")[0]+"_", "", -1)

build/main.go:29:20
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(providerName, fileSuffix, "", -1)

build/main.go:28:21
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(f.Name(), filePrefix, "", -1)

providers/gcp/gcp_compute_code_generator/resources.go:53:2
gocritic
commentFormatting: put a space between // and comment text

providers/gcp/gcp_compute_code_generator/main.go:155:121
gocritic
commentFormatting: put a space between // and comment text

providers/keycloak/openid_client.go:116:4
gocritic
commentFormatting: put a space between // and comment text

providers/datadog/user.go:19
goimports
File is not goimports-ed

providers/keycloak/openid_client.go:124:4
gocritic
commentFormatting: put a space between // and comment text

providers/keycloak/openid_client.go:120:4
gocritic
commentFormatting: put a space between // and comment text

providers/keycloak/openid_client.go:132:4
gocritic
commentFormatting: put a space between // and comment text

providers/keycloak/openid_client.go:128:4
gocritic
commentFormatting: put a space between // and comment text

providers/alicloud/connectivity/endpoint.go:53:1
gocritic
commentFormatting: put a space between // and comment text

providers/openstack/compute.go:80:24
gocritic
wrapperFunc: use strings.ReplaceAll method in strings.Replace(v.Attachments[0].Device, "/dev/", "", -1)

After
No more issues left
golangci-lint run  --out-format=tab  ./... | wc -l
       0

@googlebot I fixed it.

Thanks!
Can you add same lint test in https://github.com/GoogleCloudPlatform/terraformer/blob/master/.golangci.yml for all next PRs?

As per https://github.com/reviewdog/action-golangci-lint#filter_mode, reviewdog/action-golangci-lint was only looking at the code that were Added , hence all these errors were not reported.
I think it makes sense to have it that way.


Onelogin - Parse logout response: parserType

Hi there, first of al tnx for the great lib and examples.
Now, I am having an issue trying to do logout, the problem seems to be this line:
https://github.com/tngan/express-saml2/blob/master/lib/Entity.js#L329
that value for parser type is causing this error to be thrown:
https://github.com/tngan/express-saml2/blob/master/lib/Entity.js#L164
because, the only key in requestQuery object is 'SAMLResponse', there is not 'LogoutResponse' key in the object. I don't know if this lib should be updated to handle that situation or if I am doing something wrong and that is why I am not getting 'LogoutResponse' key in the requestQuery object.
What do you think?

@CatBakun What is the requestQuery ? Also, you can checkout and try the Onelogin demo repository here.

@CatBakun Since it is not updated for at least one month, I will close this issue. Please re-open if it is needed later on.

Hi! I have this issue too. I changed parserType value from 'LogoutResponse' to 'SAMLResponse' ('LogoutRequest' to 'SAMLRequest') and everything started to work. Perhaps, OneLogin changed the response template.
My requestQuery is:

/sso/slo/callback?SAMLRequest=nZE9b4MwEIb%2FCpsnwGCgiQWolbIgpR3aqmt1OCZBAh%2F1HVJ%2Ffp2PIerQoeNJ%0Az73Pe7qaYJ4Wvccjrvxqv1ZLHH1YTyO6RuSJFNH3PDnSF64Rq3cagUbSDmZL%0Amo1%2Be3re60DqxSOjwUlE3a4RnzIroagqGZtSDrHMVBGb7QCxzHuVD6YHBSqg%0ARKvtHDE4DkKZPQQ0zst3udUq00Uu2vrs1hfQ37X5uwwQWc%2FhCtGemBfSaQrL%0AkqCzEx5Hlxic03NKOluGAzCkVbbZKFmnd7ab%2BiWkd7v%2FqA%2Bjt4bRP7INa9An%0AI94E18z2Ov16QPsD%0A

Tests on the latest 'SAML Test Connector (IdP w/ attr w/ sign response) ' app templete.
Thanks for your work!

@AlexeySafronov I also find out there is problem in the account management in OneLogin, so the link for OneLogin in sp1 example doesn't work, and it should work properly now.

@AlexeySafronov How do you handle sso/slo endpoint ? Are you using SP-initiated Logout or IdP-initiated Logout ?

@tngan, according to the description on the wiki page,  requestQuery must have only SAMLRequest or SAMLResponse string parameter. It is a kind of standard, although I could not find confirmation of this in the RFC. I think that OneLogin just switched to this standard. I hope you can do it.

I changed parserType value from 'LogoutResponse' to 'SAMLResponse' ('LogoutRequest' to 'SAMLRequest') and everything started to work.

That i fixed IdP-initiated Logout. I could not find how to do SP-initiated Logout -> method sendLogoutRequest is available only for IdentityProvider.js. How can i tell to IDP that SP is logged out?
Thanks!

@CatBakun @AlexeySafronov Yes, the string parameter should be only SAMLRequest /SAMLResponse instead of LogoutRequest/LogoutResponse, which are the message body but not the query parameter, thank you for pointing out, will update it soon.


Fiona behaving differently inside docker (transform_geom)

running the following code
import fiona.transform
src_crs = 'epsg:4326'
dest_crs = 'epsg:3857'
r = {'type': 'Polygon','coordinates': [[(8.28342, 49.99571), (8.28339, 49.99564), (8.28342, 49.99571)]]}
dest = fiona.transform.transform_geom(src_crs, dest_crs, r)
print(dest)

inside docker and without causes different results
without docker I get
{'type': 'Polygon', 'coordinates': [[(922106.0964268183, 6445532.921733793),<PHONE_NUMBER>420947, 6445520.800057326),<PHONE_NUMBER>268183, 6445532.921733793)]]}
with the following dockerfile
FROM python:2.7.15-alpine3.7

RUN apk update && \
    apk upgrade && \
    apk add make automake gcc g++ && \
    apk add --no-cache  \
     --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing \
     --repository http://dl-cdn.alpinelinux.org/alpine/edge/main \
     gdal \
     gdal-dev \
     geos \
     geos-dev \
     py-virtualenv

RUN pip install fiona

{'type': 'Polygon', 'coordinates': [[(8.28342, 49.99571), (8.28339, 49.99564), (8.28342, 49.99571)]]}
It's as if transform_geom doesn't do anything.
both have version  1.7.13
Do I have a missing dependency, or something in the environment that is causing fiona to work differently?

I see
WARNING:Fiona:GDAL data files not located, GDAL_DATA not set
WARNING:Fiona:PROJ data files not located, PROJ_LIB not set
is pip install fiona not the correct way to install it?

I'm not sure where apk puts the GDAL and PROJ data files, but if they are not in /usr/local/share/gdal and /usr/local/share/proj, you will need to find the directory containing gcs.csv and pcs.csv and set GDAL_DATA to that directory's path and then find the directory containing proj_def.dat and set PROJ_LIB to that directory's path.


Deployment issue related to package.json

I was doing some deployment using Netlify and stuck more than 4 hours. I keep scratching my head the build failed issue keep looking this file: ./bin/hello.js but I can't find it I already run cleanup-repository to remove all the setup files.
And then while checking the package.json I find this, "postinstall": "node ./bin/hello.js",.
It would be better after running the cleanup-repository it should delete the postinstall and cleanup-repository in package.json
Also how I can create PR for this? Thank you.

@thecodingwhale That is very valid and I agree that the cleanup should also adjust the package.json to remove the post-install and cleanup-repository script.
I'm happy to take a PR that adjusts the package.json. If you need help with "how to make a PR" I'm happy to guide you to the right resources. :)

hi @stefanjudis I would happily create a PR for this one :) Can you help me how? Thank you.

Because you don't have write access to this repo you'd have to create a fork to your user account. :) gatsby-contentful-starter will then be available in your own github account.
Then you can add the changes you want to perform. In this case, you could add another script, that reads the package.json and removes the unneeded scripts. (there are other ways to do that but this is how I would approach it 🙈) This script would then need to be deleted in the clean up too. :)
After you committed and pushed your changes to your fork, you can follow the GitHub instructions to open a pull request to the original userland repository. :)
Does that help?

hi @stefanjudis I've created a PR for the fix for this one:
https://github.com/contentful-userland/gatsby-contentful-starter/pull/73
thank you.

Looking at it already. :) I'll have some tiny notes for improvement, but looks good. :)
Thank you!

@stefanjudis if you have new ideas to improve this project. Just ask me and I'm willing to help you out :)

There are some open issues, that could be tackled. And just FYI, we one merged PR you get write access to the repo/org. :)
As long as you follow PRs (feel free to tag me too) you can move forward with things you consider to be valuable to the community. :)
THanks again!


Client_credentials grant - client secrets validation

Hello, @jasonraimondi !
Firstly, I wanted to say a big thank you for the work you've put into this package. I really like how flexible it is and very well documented.
What I wanted to ask is why there is a second check comparing the provided and saved client secret when presumably we should have already made that check through the custom check in the ClientRepository.
To be more specific, I'm looking at lines 83 - 91 in abstract.grant.js. My understanding is that this.clientRepository.isClientValid(grantType, client, clientSecret); should contain our implementation where we compare the client secrets and allowed grant types. If we do the check there, I'm not sure why there is a need for a second validation... Can we remove it altogether?
The reason why I'm raising this as an issue is because I want to store hashes of the client secrets instead of the raw values, in which case the extra check (lines 87-91) results in an error.
Thank you for the time and consideration.

You are absolutely correct, this is a redundant check and implementation of clientRepository.isClientValid should be left to the consumers, as it is documented in the examples. Thank you very much for your help!
This is fixed and published in v2.2.5

Thank you 🙏🏻


ci: Add functionality to create defaults in docker compose

Changes
As discussed with @khvn26, this PR adds functionality to initialise a default user, org and project via a django management command. This PR also adds the template to the root docker-compose.yml for self hosting users.
How did you test this code?
Ran docker-compose locally.
TODO

[x] add unit tests.
[ ] update https://github.com/Flagsmith/self-hosted

Im coming here from https://github.com/Flagsmith/flagsmith/issues/2601#issuecomment-1670893352.
Is this now available in self hosted docker image?
Any idea when this will be available for deployment?
Thanks.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1d006fb) 95.54% compared to head (7bf032d) 95.46%.

:exclamation: Current head 7bf032d differs from pull request most recent head 55394e6. Consider uploading reports for the commit 55394e6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2205      +/-   ##
==========================================
- Coverage   95.54%   95.46%   -0.09%
==========================================
  Files        1013      980      -33
  Lines       29331    27444    -1887
==========================================
- Hits        28025    26199    -1826
+ Misses       1306     1245      -61

Files
Coverage Δ

api/app/settings/common.py
87.91% <100.00%> (+4.53%)
:arrow_up:

api/core/management/commands/initdefaults.py
100.00% <100.00%> (ø)

...nit/core/test_unit_core_management_initdefaults.py
100.00% <100.00%> (ø)

... and 145 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(chat): added emoji picker

Fixes Issue
My PR closes #423
👨💻 Changes proposed(What did you do ?)
I have added an emoji picker for chat using the emoji-picker-react library.
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title and description of the PR are clear and explain the approach.

Note to reviewers
This PR has a dependency added on the client side.
📷 Screenshots
https://github.com/Dun-sin/Whisper/assets/90052329/8a3395e4-ef45-4c00-ae13-cd5b8925c401

best PR so far🥇
just a change, when the user has picked an emoji, the message box isn't focused back, which is a very annoying inconvenience

Made requested changes


improve deploy item abort timeout handling

How to categorize this PR?

/area TODO
/kind robustness
/priority 3
What this PR does / why we need it:
Improves the abort timeout handling that can cause a infinite reconcile loop between the deployer and the landscaper deployitem controller if a aborted deployitem is reconciled.
The issue is that the deployitem controller does not remove the abort timeout annotation which causes the deploy item controller to read the abort failed state whereas the deployer in parallel tries to reconcile the item.
This PR removes that behavior so that the abort annotations are removed as soon as the deploy item controller sets the deploy item into a failed state.
@Diaphteiros do we have other annotation that are also not cleaned up correctly? Or should the deployers also clean up these other annotations.
Special notes for your reviewer:
Release note:

Improved the abort handling of the deploy item controller to not cause an infinite reconcile while competing with a deployer

/invite @Diaphteiros

/ok-to-test

/test


Sort has_many items

Is there a way to sort the items in a has-many-association?
I have one model A that has many of B (fields: a, b, sort) and in B there is a variable to sort the items (sort). Is there a way to associate A.ID and B.a and get a list of B.b sorted by B.sort?

The document you expected this should be explained
https://gorm.io/docs/has_many.html

Expected answer
I currently solved this with an AfterFind.Hook but I hope there is a better (performing) solution

You may try https://gorm.io/docs/preload.html#Custom-Preloading-SQL.


Modal add to cart error:  Quantity must be greater than zero

When using the Product List block adding to cart from the Quick View modal fails with the error the error 'Quantity must be greater than zero' when the Add to Cart button is not set to be shown.

I always forget that the Quick view option exists - I was tempted at one point to remove it.
Will look for a fix at some point, shouldn't take long.

I've had a look into why this is happening. The reason is that modal view of a product is quite detached from the Product List block - in fact at the moment it doesn't know anything about the block it is called for and therefore it doesn't know about the settings it may have.
How would you (or others) feel if we removed this feature from Community Store?
Personally I've never felt the need to use it and I've never really thought it matches with the Elemental styling. I've also thought it's not obvious how to trigger it, with more details better served via an actual button and product page itself.

I have a simple modal working on a project that's about to go live.  The products don't really need a full product page and I fnd for this the modal gives just enough detail.
To make it work I just moved the hidden field pQuantity outside of the current if else statement.  I've not tested this with product options etc. but it seems to work.
To answer the question I'd like to see the modals retained if possible.

No worries, I'm pretty sure I have a way to pass through the product list block settings to the modal.
It just requires a bit of a clean up so that it reflects the settings consistently.

Fixed by https://github.com/concrete5-community-store/community_store/commit/51e9660f4098dafd458c8affbf3ff3e30e8fb925


add mermaid support

mermaid  allows us to render graphs like #396

@MarcoWorms  I would like to work on this issue

do it!

@MarcoWorms @InfiniteCoder100 I'm exploring adding the mermaid charts and having some issues with the older versions of docusaurus. I'll keep trying to get it to work with a 2.x version of docusaurus, but I wanted to see if there has been discussion of biting the bullet and just migrating to v3. Might be worth the effort and will future proof things a bit.

This issue is ready to be resolved once https://github.com/yearn/yearn-devdocs/pull/426 goes through.

completed with #436!


Added FormCollectionModelBinder with tests

Issue - #979 @yishaigalatzer @rynowak

Updated.

:shipit:

Updated.

:shipit:  from me after minor cleanup

:shipit: when comments are addressed.


Exoplayer youtube pkg

Youtube package update
Underline display update
Some lint errors cleanup

@StimpyDad: I'm closing this one since you're working on the exoplayer and this break YT functionality anyways.
I'll do simpler and smaller changes instead so they're not overwhelming. Cheers.


Save treasures until late game

Gold multiplies by level now, so it must be beneficial to keep them until late on.

Yes, the script still uses them immediately, that's a waste of gold.

If the gold multiplies by level then it shouldn't matter when you use it. Yes, you'll get more gold on later levels, but upgrades will be proportionally more expensive (canceling out any benefit of waiting).

@milkfat Agreed. You will need their use in any level.

It doesn't matter anymore.


Fixing all remaining usersnap tickets

Tugboat has finished building the preview for this pull request!
Link:

https://pr55-4piyx1u2tlb7pg8btxmxyiuxdhpbxtbv.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/5f6e38894c9af66ac59d103d


Karpenter provisioned nodes instantly get deleted with "Because it does not exist in the cloud provider"

Is an existing page relevant?
https://karpenter.sh/v0.7.3/getting-started/getting-started-with-terraform/

What karpenter features are relevant?
Karpenter provisioner and controller IAM policy.  I have been using the IAM Role/Policy setup from the documentation
module "iam_assumable_role_karpenter" {
  source                        = "terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc"
  version                       = "4.7.0"
  create_role                   = true
  role_name                     = "karpenter-controller-${var.cluster_name}"
  provider_url                  = module.eks.cluster_oidc_issuer_url
  oidc_fully_qualified_subjects = ["system:serviceaccount:karpenter:karpenter"]
}

resource "aws_iam_role_policy" "karpenter_controller" {
  name = "karpenter-policy-${var.cluster_name}"
  role = module.iam_assumable_role_karpenter.iam_role_name

  policy = jsonencode({
    Version = "2012-10-17"
    Statement = [
      {
        Action = [
          "ec2:CreateLaunchTemplate",
          "ec2:CreateFleet",
          "ec2:RunInstances",
          "ec2:CreateTags",
          "iam:PassRole",
          "ec2:TerminateInstances",
          "ec2:DescribeLaunchTemplates",
          "ec2:DeleteLaunchTemplate",
          "ec2:DescribeInstances",
          "ec2:DescribeSecurityGroups",
          "ec2:DescribeSubnets",
          "ec2:DescribeInstanceTypes",
          "ec2:DescribeInstanceTypeOfferings",
          "ec2:DescribeAvailabilityZones",
          "ssm:GetParameter"
        ]
        Effect   = "Allow"
        Resource = "*"
      },
    ]
  })
}

I have deployed roughly 5 AWS EKS Cluster and set up Karpenter on them for node provisioning (We have Terraform common modules we built in-house to replicas these among different AWS Accounts meaning they're all configured the same way). Karpenter appears to be running fine on all of them except the last one I set up. Although, the last one I set up was working then suddenly stopped working.  I noticed that nodes were getting provisioned and registered to the Cluster but instantly were deleted with this message:
DeletingNode	a few seconds	cloud-node-lifecycle-controller	Deleting node ip-10-1-0-60.us-west-2.compute.internal because it does not exist in the cloud provider

I debugged for hours with no good findings (no solid feedback from Karpenter or Cluster logs). I started messing around and out of curiosity with the Karpenter IAM role controller policy, I gave it super admin access (full access) and tested it. After my testing, everything was working as expected. Of course, I can't leave the policy at full access so was curious if anyone could help with this especially since it's only one Cluster having this issue that mimics all the other Clusters and configurations as the others.
I've tried updating Karpenter to the latest and even consuming the modules that the latter documentation recommends for the IAM Roles/Policies. None of it made a difference and the behavior still persisted. One last thing as a side note (I don't believe it's causing the issue but might not allow us to be getting the best pricing if new products become available). I am seeing an error in the logs for getting pricing on AWS products:
kubectl logs -f -n karpenter -l app.kubernetes.io/name=karpenter -c controller
deployment.apps/inflate created
deployment.apps/inflate scaled
2022-07-15T18:35:06.876Z	ERROR	controller.aws.pricing	updating on-demand pricing, AccessDeniedException: User: arn:aws:sts::647426478431:assumed-role/karpenter-controller-jenkins-nonprod-sb-us-west-2/1657910106233217886 is not authorized to perform: pricing:GetProducts because no identity-based policy allows the pricing:GetProducts action
	status code: 400, request id: e854ef07-b64c-4799-9c84-b12d20eb955f; AccessDeniedException: User: arn:aws:sts::647426478431:assumed-role/karpenter-controller-jenkins-nonprod-sb-us-west-2/1657910106233217886 is not authorized to perform: pricing:GetProducts because no identity-based policy allows the pricing:GetProducts action
	status code: 400, request id: 5ecb0203-fc22-47e8-9ab6-9a94c93a8faa, using existing pricing data from 07 Jul 22 10:58 -0500	{"commit": "062a029"}
2022-07-15T18:35:06.941Z	INFO	controller.controller.provisionermetrics	Starting workers	{"commit": "062a029", "reconciler group": "karpenter.sh", "reconciler kind": "Provisioner", "worker count": 1}
2022-07-15T18:35:06.942Z	INFO	controller.controller.counter	Starting workers	{"commit": "062a029", "reconciler group": "karpenter.sh", "reconciler kind": "Provisioner", "worker count": 10}
2022-07-15T18:35:06.942Z	INFO	controller.controller.node	Starting workers	{"commit": "062a029", "reconciler group": "", "reconciler kind": "Node", "worker count": 10}
2022-07-15T18:35:06.942Z	INFO	controller.controller.nodemetrics	Starting workers	{"commit": "062a029", "reconciler group": "", "reconciler kind": "Node", "worker count": 1}
2022-07-15T18:36:21.008Z	DEBUG	controller.provisioning	Discovered 539 EC2 instance types	{"commit": "062a029"}
2022-07-15T18:36:21.134Z	DEBUG	controller.provisioning	Discovered subnets: [subnet-0150eed37450e769d (us-west-2a) subnet-01665d187e865d964 (us-west-2c) subnet-0c9c66a8ca90883bf (us-west-2b)]	{"commit": "062a029"}
2022-07-15T18:36:21.304Z	DEBUG	controller.provisioning	Discovered EC2 instance types zonal offerings	{"commit": "062a029"}
2022-07-15T18:36:21.548Z	INFO	controller.provisioning	Found 1 provisionable pod(s)	{"commit": "062a029"}
2022-07-15T18:36:21.549Z	INFO	controller.provisioning	Computed 1 new node(s) will fit 1 pod(s)	{"commit": "062a029"}
2022-07-15T18:36:21.757Z	DEBUG	controller.provisioning.cloudprovider	Discovered security groups: [sg-032bd1b0ec3d4c7b0]	{"commit": "062a029", "provisioner": "default"}
2022-07-15T18:36:21.761Z	DEBUG	controller.provisioning.cloudprovider	Discovered kubernetes version 1.21	{"commit": "062a029", "provisioner": "default"}
2022-07-15T18:36:21.863Z	DEBUG	controller.provisioning.cloudprovider	Discovered ami-00cf63b12c53803a5 for query "/aws/service/eks/optimized-ami/1.21/amazon-linux-2/recommended/image_id"	{"commit": "062a029", "provisioner": "default"}
2022-07-15T18:36:22.038Z	DEBUG	controller.provisioning.cloudprovider	Created launch template, Karpenter-jenkins-nonprod-sb-6196939222338079096	{"commit": "062a029", "provisioner": "default"}
2022-07-15T18:36:24.942Z	INFO	controller.provisioning.cloudprovider	Launched instance: i-087964bd0d8d667f4, hostname: ip-10-1-1-136.us-west-2.compute.internal, type: t3a.small, zone: us-west-2b, capacityType: on-demand	{"commit": "062a029", "provisioner": "default"}
2022-07-15T18:36:24.956Z	INFO	controller.provisioning	Created node with 1 pods requesting {"cpu":"1125m","pods":"5"} from types t3a.small, t3.small, t3a.medium, t3.medium, t2.medium and 386 other(s)	{"commit": "062a029", "provisioner": "default"}
2022-07-15T18:36:24.956Z	INFO	controller.provisioning	Waiting for unschedulable pods	{"commit": "062a029"}
2022-07-15T18:36:24.956Z	DEBUG	controller.events	Normal	{"commit": "062a029", "object": {"kind":"Pod","namespace":"default","name":"inflate-88f9bbfc7-kpwpz","uid":"d0a8aa32-8166-40d9-8b29-a8c4f89a558f","apiVersion":"v1","resourceVersion":"3260"}, "reason": "NominatePod", "message": "Pod should schedule on ip-10-1-1-136.us-west-2.compute.internal"}

Should we be allowing access to anything else in our policy? I didn't see anything in the documentation.

How should the docs be improved?
N/A

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

It looks like you are using a newer version of Karpenter, but you liked to the old v0.7.3 installation instructions.  Did you happen to mix the old instructions with the newer verison?

If it helps this is a code snippet of how we setup Karpenter:
module "iam_assumable_role_karpenter" {
  source                        = "terraform-aws-modules/iam/aws//modules/iam-assumable-role-with-oidc"
  version                       = "4.7.0"
  create_role                   = true
  role_name                     = "karpenter-controller-${var.cluster_name}-${data.aws_region.current.name}"
  provider_url                  = aws_eks_cluster.cluster.identity[0].oidc[0].issuer
  oidc_fully_qualified_subjects = ["system:serviceaccount:karpenter:karpenter"]
}

resource "aws_iam_role_policy" "karpenter_controller" {
  name = "karpenter-policy-${var.cluster_name}-${data.aws_region.current.name}"
  role = module.iam_assumable_role_karpenter.iam_role_name

  policy = jsonencode({
    Version = "2012-10-17"
    Statement = [
      {
        Action = [
          "ec2:CreateLaunchTemplate",
          "ec2:CreateFleet",
          "ec2:RunInstances",
          "ec2:CreateTags",
          "iam:PassRole",
          "ec2:TerminateInstances",
          "ec2:DescribeLaunchTemplates",
          "ec2:DeleteLaunchTemplate",
          "ec2:DescribeInstances",
          "ec2:DescribeSecurityGroups",
          "ec2:DescribeSubnets",
          "ec2:DescribeInstanceTypes",
          "ec2:DescribeInstanceTypeOfferings",
          "ec2:DescribeAvailabilityZones",
          "ssm:GetParameter",
          "ec2:DescribeSpotPriceHistory",
          "pricing:GetProducts"
        ]
        Effect   = "Allow"
        Resource = "*"
      },
    ]
  })
}

data "aws_iam_policy" "ssm_managed_instance" {
  arn = "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore"
}

resource "aws_iam_role_policy_attachment" "karpenter_ssm_policy" {
  role       = aws_iam_role.cluster_node_instance_role.name
  policy_arn = data.aws_iam_policy.ssm_managed_instance.arn
}

resource "aws_iam_instance_profile" "karpenter" {
  name = "KarpenterNodeInstanceProfile-${var.cluster_name}-${data.aws_region.current.name}"
  role = aws_iam_role.cluster_node_instance_role.name
}

resource "helm_release" "karpenter" {
  namespace        = "karpenter"
  create_namespace = true

  name       = "karpenter"
  repository = "https://charts.karpenter.sh"
  chart      = "karpenter"
  version    = var.karpenter_version

  set {
    name  = "serviceAccount.annotations.eks\\.amazonaws\\.com/role-arn"
    value = module.iam_assumable_role_karpenter.iam_role_arn
  }

  set {
    name  = "clusterName"
    value = var.cluster_name
  }

  set {
    name  = "clusterEndpoint"
    value = aws_eks_cluster.cluster.endpoint
  }

  set {
    name  = "aws.defaultInstanceProfile"
    value = aws_iam_instance_profile.karpenter.name
  }

  depends_on = [
    aws_eks_node_group.cluster_node_group,
  ]
}

resource "kubectl_manifest" "karpenter_default_provisioner" {
  yaml_body = <<-YAML
  apiVersion: karpenter.sh/v1alpha5
  kind: Provisioner
  metadata:
    name: default
  spec:
    requirements:
      - key: "kubernetes.io/arch"
        operator: In
        values: ["amd64"]
    limits:
      resources:
        cpu: "1000"
        memory: 1000Gi
    provider:
      amiFamily: AL2
      instanceProfile: "${aws_iam_instance_profile.karpenter.name}"
      subnetSelector:
        Name: "${var.cluster_name}-private*"
      securityGroupSelector:
        Name: "eks-cluster-sg-${var.cluster_name}*"
    ttlSecondsAfterEmpty: 30
  YAML

  depends_on = [
    helm_release.karpenter
  ]
}


Low volume on Vita

Every time I export a game with this program, the game's volume is much lower than other apps on my Vita. About half as loud if I had to guess. It sounds fine when I run it on my pc.
Is there anything I can do about this? Is this a known issue with gaymaker?

I've been looking for an answer to this - I take it that there's no update on this?

Just in case, the 1.7.6 update does not affect this :(

im pretty sure this is just an issue with the GameMaker 1.4.9999 runner,
does the same thing occur on 1.4.1804? or lower?

I haven't tried it with any other version... I've only been using 1.4.99 as it was the last version, assuming this would be the best one? I can try installing 1804 and see if it makes any difference?

I installed the 1.4.1804 version of Gamemaker Studio, compiled & ran the game - then used GayMaker (set to 1.4.1804) to compile the VPK - seems to have exactly the same result; sound effects seem to be fine but music is practically muted unless I try and max out the volume?

i dont think its something i can fix from within GayMaker, though, unless offical PSVita GM games dont have the problem or something

Fair enough, I just wish I knew how/why it happened... some sound effects are fine, while others just seem to disappear or drop so low!


Added typescript sample app to keploy docs repo

Updated the keploy docs repo by adding typescript sample app in the sample app lists

@nehagup I have added the sample typescript app, please check and see if its okay.


Native runtime implementation of delayed and physical connections

This PR provides a new Connection class which extends Action and provides PhysicalConnection and DelayedConnection as concrete implementations. Connections may be bound to ports and get notified on upstream events via callbacks. For this, the Port class is also extended so that callbacks can be registered that are invoked on clan or set. This also posed the opportunity for cleaning up the current Multiport implementation.

I took a full tour of our changes and they look very good to me. Especially generalizing the callback mechanisms.

Here is a performance measurement. In the figure, "string view" refers to https://github.com/lf-lang/reactor-cpp/pull/41 which serves as the baseline for our comparison. The introduction of the generalized callback mechanism comes with a clear overhead. This is particularly evident in the Big benchmark. However, if we compare with the results from before https://github.com/lf-lang/reactor-cpp/pull/41 (labeled "master", the overall difference is not as bad). Overall, the callback mechanism buys us a lot of flexibility at a modest performance penalty and I think it is worth the costs.


Accessibility - add button label for the flash button

Hello,
The iOS VoiceOver native screen reader doesn't say anything about the button that turns on the flash light.
Can you add a label.accessibility to this button with the value "Flash"?
Thank you

up


Google Sitemap Missing Return Links ("Incorrect hreflang implementation")

I've just received an e-mail from Google saying there is an "Incorrect hreflang implementation" on a site using Fluent I launched a few weeks ago.
Specifically, it seems to be reporting: "Sitemap provided URLs and alternative URLs in 'fr-FR' that do not have return tags."
Looking into this a bit further it seems that currently Fluent generates a sitemap that lists all the pages for the default locale, and for each of them provides links to that page in the other locales.
However, it seems that it should also be listing all the pages in the other locales with links back to the default locale (and the other locales).
From Google's Guidelines:

If page A links to page B, page B must link back to page A. If this is not the case for all pages that use hreflang annotations, those annotations may be ignored or not interpreted correctly.

Are you using the google sitemaps module? Or is the error coming from the meta tags in each page head?
Can you please dump the  of each of your pages for me, and I can investigate in the mean time. :)

In my test site, all of my header tags are the same (regardless of locale).
<link rel="alternate" hreflang="en-US" href="http://fluenttest.loc/" />
	<link rel="alternate" hreflang="en-NZ" href="http://fluenttest.loc/nz/" />
	<link rel="alternate" hreflang="en-AU" href="http://fluenttest.loc/au/" />
	<link rel="alternate" hreflang="en-PH" href="http://fluenttest.loc/ph/" />
	<link rel="alternate" hreflang="en-SG" href="http://fluenttest.loc/sg/" />
	<link rel="alternate" hreflang="en-GB" href="http://fluenttest.loc/uk/" />

Is it possible that you've configured your domain name slightly incorrectly, so that the urls don't match the href exactly?
Can you look at the last answer in http://webmasters.stackexchange.com/questions/67058/international-targeting-no-return-tags and tell me which of these might apply to your site?

Sorry for the delay after your fast response! It's about time I sorted this.
I'm using the Google Sitemaps module, which I believe is then extended by Fluent.
The sitemap in question is here: http://www.campingquinquis.com/sitemap.xml/sitemap/SiteTree/1
You can see in the XML that each page is listed once as a url->loc (using the main locale), and each then has 3 links (one for each locale, including the main one).
I believe that this should all be repeated a further 2 times, for the other 2 locales, so that there are also url->loc items for the other locales.
From that StackExchange answer, the 3rd point may be the same issue I'm having.

We've done further work to make the sitemap template compliant in the SilverStripe 4 version of Fluent. Please reopen if you feel this is still an issue, otherwise let's consider this resolved in Fluent for SilverStripe 4.

Sorry, but this issue still seems to existing with the latest version on SilverStripe 4.
Take this correct sitemap example from Google's own docs:
<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"
  xmlns:xhtml="http://www.w3.org/1999/xhtml">
  <url>
    <loc>http://www.example.com/english/page.html</loc>
    <xhtml:link
               rel="alternate"
               hreflang="de"
               href="http://www.example.com/deutsch/page.html"/>
    <xhtml:link
               rel="alternate"
               hreflang="de-ch"
               href="http://www.example.com/schweiz-deutsch/page.html"/>
    <xhtml:link
               rel="alternate"
               hreflang="en"
               href="http://www.example.com/english/page.html"/>
  </url>
  <url>
    <loc>http://www.example.com/deutsch/page.html</loc>
    <xhtml:link
               rel="alternate"
               hreflang="de"
               href="http://www.example.com/deutsch/page.html"/>
    <xhtml:link
               rel="alternate"
               hreflang="de-ch"
               href="http://www.example.com/schweiz-deutsch/page.html"/>
    <xhtml:link
               rel="alternate"
               hreflang="en"
               href="http://www.example.com/english/page.html"/>
  </url>
  <url>
    <loc>http://www.example.com/schweiz-deutsch/page.html</loc>
    <xhtml:link
               rel="alternate"
               hreflang="de"
               href="http://www.example.com/deutsch/page.html"/>
    <xhtml:link
               rel="alternate"
               hreflang="de-ch"
               href="http://www.example.com/schweiz-deutsch/page.html"/>
    <xhtml:link
               rel="alternate"
               hreflang="en"
               href="http://www.example.com/english/page.html"/>
  </url>
</urlset>

Fluent is not currently doing this, it is currently doing the following:
<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9"
  xmlns:xhtml="http://www.w3.org/1999/xhtml">
  <url>
    <loc>http://www.example.com/english/page.html</loc>
    <xhtml:link
               rel="alternate"
               hreflang="de"
               href="http://www.example.com/deutsch/page.html"/>
    <xhtml:link
               rel="alternate"
               hreflang="de-ch"
               href="http://www.example.com/schweiz-deutsch/page.html"/>
    <xhtml:link
               rel="alternate"
               hreflang="en"
               href="http://www.example.com/english/page.html"/>
  </url>
</urlset>

i.e. it's not creating <url>s for each locale, only the main one.


None under subtitles doesn't work.

Just.Player.v0.114-legacy was the last version that would let you select none under subtitles and turn them off. I just tried Just.Player.v0.125-legacy and it doesn't work. I like subtitles on but there are some shows that have hard coded titles in them,  mostly shows when someone is speaking in a different language so subtitles needed to be turned off because they are on top of the hard coded ones. I have tried every new version since v.114 and none will not stay selected. They will change to other languages but not none. Could you please fix this. Thank you.

Your described issue matches the changes in ExoPlayer 2.18.0 (and Just Player releases you mention). However I modified that in my fork and it is working with my test media files. So please share at least media info output of such file or ideally video sample to duplicate that issue.

I use Syncler app on my 2019 NVIDIA Shield Pro and have shows streaming from my Premiumize and Real-Debrid accounts.  I just tried the show The-Morning-Show S01E01 and it works correctly in Just.Player.v0.114-legacy but soon as I upgrade to Just.Player.v0.125-legacy and select None under subtitles it does nothing and subtitles keep playing. https://kickasstorrent.cr/the-morning-show-2019-season-1-s01-1080p-atvp-web-dl-x265-hevc-10bit-eac3-atmos-5-1-t3nzin-qxr-t4560421.html

When I download and play the linked video locally, it works fine and I can disable any subtitles. I tried few free sources in Syncler and it also seems to be working fine. So I'm not really sure how to replicate that issue.

moneytoo,
So I downloaded the video right to my shield and bypassed Syncler app to see if that was causing the issue. Uninstalled Just player and ran a cleaner. Installed Just.Player.v0.126-legacy and played video off of shield. Same problem it will not let me select none subtitles and stay none. Pic 1 is Just.Player.v0.126-legacy showing None selected and not staying and pic 2  is back using Just.Player.v0.114-legacy and it working correctly. https://imgur.com/a/VKmFt2R

Does it work in Just.Player.v0.127-legacy.apk?

moneytoo,
Thank you for all your hard work, Just.Player.v0.127-legacy fixed the issue. I really appreciate what you do.
Moose


Installation error

Followed installation instructions and once I run python3 Research/run_experiment.py I am getting the following error:
Traceback (most recent call last):
File "./Research/run_experiment.py", line 10, in
from utils import save_exp_to_file, extend_gan_train, extend_from_original
File "/Tabular-data-generation/Research/utils.py", line 8, in
from ctgan import _CTGANSynthesizer
ImportError: cannot import name '_CTGANSynthesizer' from 'ctgan' (/Tabular-data-generation/Research/ctgan/init.py)

Hey, I  got the same error !

I'm afraid it deprecated


Allow Drpdown texts being formated by ft.Text

Please Describe The Problem To Be Solved
(Replace This Text: Please present a concise description of the problem to be addressed by this feature request. Please be clear what parts of the problem are considered to be in-scope and out-of-scope.)
(Optional): Suggest A Solution
(Replace This Text: A concise description of your preferred solution. Things to address include:

Details of the technical implementation, e.g. Flutter widget solving the problem.
Tradeoffs made in design decisions
Caveats and considerations for the future

If there are multiple solutions, please present each one separately. Save comparisons for the very end.)

Could you be more specific please?

@jvalle63
The option name text can be styled using the text_style parameter.
    dd = ft.Dropdown(
        width=100,
        options=[
            ft.dropdown.Option("Red"),
            ft.dropdown.Option("Green"),
            ft.dropdown.Option("Blue"),
        ],
        text_style=ft.TextStyle(
            weight=ft.FontWeight.W_500,
            color=ft.colors.RED_500
        )
    )

The bg of the option box can be modified by wrapping the dropdown in the container.
dd = ft.Container(
        content=dd,
        bgcolor=ft.colors.BLUE_100,
        border_radius=5
    )

Complete code
import flet as ft

def main(page: ft.Page):
    def button_clicked(e):
        t.value = f"Dropdown value is:  {dd.content.value}"
        page.update()

    t = ft.Text()
    b = ft.ElevatedButton(text="Submit", on_click=button_clicked)
    dd = ft.Dropdown(
        width=100,
        options=[
            ft.dropdown.Option("Red"),
            ft.dropdown.Option("Green"),
            ft.dropdown.Option("Blue"),
        ],
        text_style=ft.TextStyle(
            weight=ft.FontWeight.W_500,
            color=ft.colors.RED_500
        )
    )

    dd = ft.Container(
        content=dd,
        bgcolor=ft.colors.BLUE_100,
        border_radius=5
    )

    page.add(dd, b, t)

ft.app(target=main)

Ref: https://flet.dev/docs/controls/dropdown/#examples

thank you!


Get personal info failed

[ERROR][2023-06-09 17:47:53][wechat.py:200] - Get personal info failed!
[ERROR][2023-06-09 17:47:53][wechat.py:201] - 'wx_name'
Traceback (most recent call last):
File "C:\Users\Administrator\Desktop\GPT\wechat-gptbot\channel\wechat.py", line 192, in get_personal_info
nickName: {content['wx_name']}
KeyError: 'wx_name'

Thanks.


Switch from booleans enclosed in strings to standard booleans

There is some inconsistency when looking at the variables used in this project:

on one hand you have *_enabled: bool variables for enabling applications
on the other hand you have *_available_externally: "bool" for allowing applications to be routed through traefik

From my testing switching from "bool" to bool shouldn't be an issue, as the only change needed is in the traefik label: going from : {{ *_available_externally }} to : {{ *_available_externally | string }}

I can make a PR for it and I made sure it's not a breaking change:
having {{ variable | string }} for traefik would result in true if variable: "true" and True if variable: true, both accepted

Agree that this is a weird one - I'm scraping the memory banks a bit but I think at the time (a couple of years ago) I didn't know about the | string thing. Happy to accept a PR replacing it with best practice!


python312Packages.msticpy: 2.14.0 -> 2.15.0

Diff: https://github.com/microsoft/msticpy/compare/refs/tags/v2.14.0...v2.15.0
Changelog: https://github.com/microsoft/msticpy/releases/tag/v2.15.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 363889

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.msticpy
python311Packages.msticpy.dist
python312Packages.msticpy
python312Packages.msticpy.dist


bug: gql.operation.name needs to identify operation name properly

Let's look at a simple graphql query
query simpleschemacheck{
  __schema {
    types {
      name
    }
  }
}

Summarizing these 2 websites
Web1: https://graphql.org/learn/queries/#operation-name
Web2: https://graphql.org/learn/serving-over-http/#post-request

operationName key within the HTTP POST query is optional for single queries and mandatory for multiple queries.
in the above example, simpleschemacheck can be deemed as the operation name as it is a single query. We need not state this in the operationName POST Query.

Expected behavior
gql.operation.name metric is anoynomous
Actual behavior
gql.operation.name metric should be simplequerycheck as there is only 1 query.
Steps to reproduce

Just use my query and send it via postman.
graphiql sends operationName even though it has 1 query. It follows the simpleschemacheck operation name. However, if there is no simplequerycheck, it will not send a operationName within the POST request. In this case, anonynomous is definetly correct. (Use chrome debugger and view the network requests)
Other libraries may not send this operationName within the POST as it is an optional field even though simpleschemacheck is the operation name.

What should be done

gql.operation.name should do the following check.

Check if operationName is present.
If operationName is present - gql.operation.name will be operationName
If operationName is not present, this has to be a 1 query post request.
   Check the single query's operation name
      If query's operation name is nonempty, `gql.operation.name` is this operation name
      ElseIf the query operation name is empty, `gql.operation.name` will be anonynomous.

In other words, there has to be a proper mapping with operationName and query <operation_name>
Why do we need this?

Libraries are sending healthchecks without operationName while having a query operationname.
DGS metrics is marking gql.operation.name as anoynomous. It makes metrics very hard to read as we do not know the actual operation name that is in the query and thus, we can't filter out healthchecks and normal requests.

Thanks for the detailed explanation.

Sorry for the delay, PR #491 open.

Hi @berngp ,
We have tested it and I'm glad to say its working very nicely now. We are able to see the operationname within the metrics for those that are not 'anonynomous'
Really appreciate the effort and fixing this up 💪  Thanks!


Search support for language specific query

Hi,
Thank you for this api, it is really great.
One question I have, for instance, I want to download all epub files of a specific language.
Can we add a flag for this purpose?
libgen-cli search * -l english

Hello @eonurk! Working on adding this flag now.

This feature has been added as of v1.0.9. Let me know if you have any issues!


fix requests with compression (replay)

Ah, I was wondering why I got errors like invalid utf-8 sequence of 1 bytes from index 1172 with session replay. I'll disable compression for the time being.


[WIP] Piper/track metadata abount peers on connection

What was wrong?
How was it fixed?
Cute Animal Picture

Some sub-tasks I'm discovering that need to be pulled out.

It's difficult to cause trinity shutdown from within an isolated scope plugin when the shutdown condition can only be detected within do_start.
It's difficult to properly run more than one service in an isolated scope plugin since the utils in trinity._utils.shutdown only support singular services.

Anyone who wants to re-connect to the network almost instantly can try this branch out.  It works well and my node comes online and starts syncing pretty much immediately

I think I need help deciding the right way forward for this PR.  I think it's too much to do all in one go.  I'm thinking I'm going to drop the parts that source peer candidates from this API and have this PR only record the information, and do the sourcing of candidates in another PR.
Reasoning:
I'm concerned with not getting the sourcing right.  Here are some scenarios:

Re-using the same ones too often
Database full of mediocre peers
Database full of peers that were once available but no longer reachable
Malicious/Incompetent peers in database that get blacklisted but are always eventually a valid connection candidate.

So probably inclined to release this behind two feature flags, one to turn it on at all, and another to enable sourcing of peer candidates from the recorded data.  Both of these would be off by default.

I just skimmed over this but responding to

So probably inclined to release this behind two feature flags, one to turn it on at all, and another to enable sourcing of peer candidates from the recorded data. Both of these would be off by default.

I think that is the right way forward. In fact, I think we should leverage feature flags more in the future. Especially the more we stabilize, the more we probably need to get into the habit of letting some features  brew and fine tune behind feature flags for a while.
We could even try to come up with ways to promote such experimental features better, encouraging the adventurous to try them out (e.g. print out available feature flags for experimental features when Trinity boots).

But-but-but the CAP!..

Source: Yuri Smityuk / TASS via Getty Images via Vice


F-Droid can't build

ref: https://monitor.f-droid.org/builds/log/com.futsch1.medtimer/56#site-footer
something changed in the tooling you (and others use to build the apps), we've gathered the ever increasing list of apps that are otherwise reproducible yet their APKs are not here: https://gitlab.com/fdroid/fdroiddata/-/issues/3299
/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/15d177e807fc64a3bf8835b1f7c9f623643ad7bc

I see that this is a tooling issue related to the update of the Android SDK to version 35 in the Github Ubuntu image. So it's obviously not related to a change I made.
Is there anything I can do to support? Try an older Ubuntu image?

Does the Ubuntu image hold older build-tools versions?
eg. in https://github.com/Futsch1/medTimer/blob/v1.8.10/.github/workflows/android.yml#L79
instead of ${{ env.BUILD_TOOLS_PATH }}/apksigner maybe use /usr/local/lib/android/sdk/build-tools/34.0.0/apksigner ? :shrug:

That's actually working, so 34.0.0 is installed:
Run /usr/local/lib/android/sdk/build-tools/34.0.0/zipalign -v 4 $APK_RELEASE_DIRECTORY/MedTimer-release-unsigned.apk \
I will create a new tag/version to check if this resolves the build issue

Downgrading should work, but isn't ideal. I listed the 3 possible ways to fix this issue here: https://github.com/obfusk/apksigcopier/issues/105#issuecomment-2206799316

I see, thanks for the hint. I will look into your other two proposals and choose one of them for a more sustainable solution.

You're welcome. And good luck. The 2nd option would be a fix on your end, the 3rd one on F-Droid's.
I worry that there isn't really a sustainable solution for F-Droid running a Reproducible Builds project when they no longer have an expert to fix things when they break or anyone having a proper understanding of all the tooling they depend on.
But I resigned from F-Droid last year so it's not my problem any more 🤷♀

Also, FYI your unsigned and unsigned-aligned APKs are completely identical. Android Gradle Plugin has been producing aligned unsigned APKs for years so running zipalign doesn't really do anything.

I've seen the zipalign command in many Github CIs, I guess that's a template added there years ago that keeps getting copied without reasoning. :))

I've seen the zipalign command in many Github CIs, I guess that's a template added there years ago that keeps getting copied without reasoning. :))

Yeah, I'm sure it used to be needed with older AGP versions. Luckily it's just redundant now, not doing any harm :)
You on the other hand seem to have been calling zipalign with completely nonsensical options. I guess you didn't realise the difference between the regular byte-alignment parameter (which -- as both the Debian man page and Android docs state -- is always set to 4, never anything else -- which does make it quite odd that it's a mandatory argument (except in my zipalign.py Python implementation) :woman_shrugging:) and the recently added -P option (which Debian's zipalign is too old to support) to set the page alignment for .so files (which used to be hardcoded as 4k but now defaults to 16k in e.g. AGP, with 4k and 64k also being valid)?

I guess you didn't realise the difference between the regular byte-alignment parameter

that got lost on the way, for these cases, as I went in and out of used tools

as both the Debian man page and Android docs state -- is always set to 4, never anything else

what's more funny is that feeding it 16 or 64 yields different files, but more so confusingly, yields consistent files for these values

what's more funny is that feeding it 16 or 64 yields different files, but more so confusingly, yields consistent files for these values

Yes? That would be neither odd, not confusing, but entirely expected. It's doing exactly what you told it to do: add padding for alignment to 16/64 bytes instead of 4. It's not in any way useful to align to anything but 4 bytes though.

As I pointed out, if you don't understand what changes tooling like zipalign, apksigner, repro-apk, etc. make to the APK, you will not be able to fix anything if it breaks because something changed in the toolchain like here. Except by downgrading or getting lucky with trial and error of various options you happen to know about. Hoping someone else fixes it for you seems like a bad strategy :woman_shrugging:

I've seen the zipalign command in many Github CIs, I guess that's a template added there years ago that keeps getting copied without reasoning. :))

Yeah, I'm sure it used to be needed with older AGP versions. Luckily it's just redundant now, not doing any harm :)
You on the other hand seem to have been calling zipalign with completely nonsensical options. I guess you didn't realise the difference between the regular byte-alignment parameter (which -- as both the Debian man page and Android docs state -- is always set to 4, never anything else -- which does make it quite odd that it's a mandatory argument (except in my zipalign.py Python implementation) :woman_shrugging:) and the recently added -P option (which Debian's zipalign is too old to support) to set the page alignment for .so files (which used to be hardcoded as 4k but now defaults to 16k in e.g. AGP, with 4k and 64k also being valid)?

Then the guy where I copied it from obviously had no clue about it ;-)
Jokes aside, I will remove the call to zipalign anyway.

I added a FAQ entry with more details: https://github.com/obfusk/apksigcopier#what-about-signatures-made-by-apksigner-from-build-tools--3500-rc1