landing

@ibgreen @philogb
Simple landing page. We can nix the carousel if it's too much or we want to wait on better screenshots.

@wwwtyro,
I don't mind the carousel however I tend to update the README relatively frequently.  This makes it look like I will need to update in two places, README and index.html. I know that it is possible to put an image link directly in the markdown, that would probably be simpler long term for me rather than introducing an HTML file.
In the open issue regarding landing page #11, I was not referring to the README.md. I was mostly concerned about what happens when the user does an "npm run start" and opens the browser - he sees an ugly directory listing and has to find examples or lessons directory and click in there, instead of just starting one of the examples and being able to use the controls to go to the next one.
While we need to support npm run start for development purposes, I think the ultimate design for showcasing our demos would be to use something like github pages where we could serve the examples without asking the user to run a server. And then we could just put a link to the demo pages in our README.md. Then anyone could see the demos without even cloning the repo.

Okay, perhaps I misunderstood. With this PR, if someone runs npm run start and goes to localhost:3000, they'll be presented with the webpage above. Would you like something else?
Agree re: gh-pages, we'll just need to make sure the gh-pages repo has a built version of the code and that we keep it updated. Once this PR reaches a state you're happy with, set up a gh-pages branch and I'll make a pull request against it to get that started.

Rereading your comment, it sounds like you just want a redirect to a lesson?

Okay, perhaps I misunderstood. With this PR, if someone runs npm run start and goes to localhost:3000, they'll be presented with the webpage above. Would you like something else?

Sorry, the misunderstanding was mine. Just goes to show that I should always test run your changes before commenting.
Yes this is a good start, I did want a nice landing page for the npm run start. One that looks good and makes it super easy to start the examples. My first impressions:

Most importantly, how do I start the examples from this page? That should be a big "click me" button.
Also, I don't think we need to duplicate all the contents in the README file. We could include the overview section/design goals for now, just to have some contents.

Agree re: gh-pages, we'll just need to make sure the gh-pages repo has a built version of the code and that we keep it updated.

Should we create a prepublish npm script that places built versions in dist/lumagl.js and dist/lumagl.min.js. And remove those from .gitignore? Then the built version could be picked up directly from the main repo, and it would be easier to use lumagl in simple web pages.

Yes, all that sounds good. I'll patch it up and ping you when I'm done. Thanks Ib!

Is that more what you had in mind, @ibgreen? I'm out of time this week, so I'll pick up the gh-pages stuff on Monday.

@wwwtyro Yes, this looks awesome. Thanks for sorting it so quickly and enjoy your weekend!

Closes #11

No problem! You too! :)


feat(iroh-net): More Quinn re-exports

Description
These are some more public types that we need to re-export.  I needed these while getting h3 to work.
Breaking Changes

Notes & open questions
I'll take this PR to try and go through all of the types.  But it's painful error-prone work.  It should give us a good baseline for the future newtyping of all this though.
What do to about:

quinn::udp
quinn:rustls

I have found these very useful, but they could be problematic.
Change checklist

[ ] Self-review.
[ ] Documentation updates following the style guide, if relevant.
[ ] Tests if relevant.
[ ] All breaking changes documented.

quinn:rustls

I would try to avoid this, given users of iroh-net should not touch rustls directly


Update README.md

Updating the README to list all of the new (published) packages.

Hey @pauldemarco - that one's a work-in-progress. README has been updated with published packages.


Getting error when I run Grunt

Hi, which version do you use and could you please post the code that is mentioned in the error log? Because, by default we don’t have livereload enabled so it might be an issue with your custom options?

It does not look like our configuration. Please post your config here. Looks like you forgot a , or something.

Will close this for now. Thanks for reporting though.


Default sort for videos on video page should be by date

Not sure how they are sorted now but it's certainly not by date as it should be (reverse chronological so newest videos are first):

Easy way to fix. In the 'Date' class in the isotope grid, replace this:
{{video.date.year}}{{video.date.month}}{{video.date.day}}
with this:
{{ video.date|date:"U" }}

This doesn't work perfectly because the videos still come in unsorted and then you get this disorienting isotope re-ordering visualization to sort them by date... they should be defaulted to being sorted reverse chronologically.

OK, fixed this in https://github.com/jonfroehlich/makeabilitylabwebsite/commit/d348d6f12609eba428811ad9ee736730b6c8079a by adding order_by to the query Video.objects.filter(date__range=["2012-01-01", date.today()]).order_by('-date'),

Still has a weird disorienting layout animation on load, however.


add pending state for submitting a report

https://github.com/AugurProject/augur/issues/5796

need to show processing... button on market trading page as well.


dynamic page size for fetching events

Implements https://github.com/worldcoin/signup-sequencer/issues/240

Motivation

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Updated the changelog

Codecov Report

Merging #283 (751be55) into main (a2dc598) will increase coverage by 0.41%.
The diff coverage is 91.80%.

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   39.42%   39.84%   +0.41%
==========================================
  Files          19       19
  Lines        5458     5502      +44
==========================================
+ Hits         2152     2192      +40
- Misses       3306     3310       +4

Flag
Coverage Δ

test
39.84% <91.80%> (+0.41%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/contracts/caching_log_query.rs
77.08% <91.66%> (+5.94%)
:arrow_up:

src/contracts/mod.rs
63.26% <100.00%> (-2.12%)
:arrow_down:

src/database.rs
31.09% <0.00%> (+0.84%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2dc598...751be55. Read the comment docs.


[Impeller] Image.toByteData Could not convert raster image to PNG

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

This snippet was adapted from flutter_cache_manager
Look at snippet below
The particular image url I'm using is link

Expected results
Both calls to toByteData should work without errors
Actual results
After upgrading to 3.13, on a physical device (Tested on iphone 14 pro)
.toByteData(format: ui.ImageByteFormat.png)

throws error
[VERBOSE-2:image_encoding.cc(123)] Could not convert raster image to PNG.
_TypeError: Null check operator used on a null value
  File "painting.dart", line 1959, in _Image.toByteData.<fn>.<fn>

However running with --no-enable-impeller seems to run without error.
FYI the image is a jpeg. I'm not sure if JPEG images are supposed to work with ImageByteFormat.png however it does work when not using impeller, so definitely seems like a regression
Code sample
Code sample
  void test() async {
    final img = NetworkImage(_imageUrl);

    final im = await _decodeImage(img);

   await im.toByteData();
   await im.toByteData(format: ui.ImageByteFormat.png);
  }

  Future<ui.Image> _decodeImage(
    ImageProvider imageProvider,
  ) {
    final image = imageProvider;
    final completer = Completer<ui.Image>();
    image.resolve(ImageConfiguration.empty).addListener(
      ImageStreamListener((info, _) {
        completer.complete(info.image);
        image.evict();
      }),
    );
    return completer.future;
  }

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
hari@<name>-MacBook-Pro <app> % flutter doctor -v
[✓] Flutter (Channel stable, 3.13.1, on macOS 13.5.1 22G90 darwin-arm64, locale en-IN)
    • Flutter version 3.13.1 on channel stable at /Users/<name>/Softwares/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e1e47221e8 (12 days ago), 2023-08-22 21:43:18 -0700
    • Engine revision b20183e040
    • Dart version 3.1.0
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/<name>/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Ultimate Edition (version 2022.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.3345.108

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (4 available)
    • iPhone (mobile) • 00008120-001444280A00C01E            • ios            • iOS 16.6 20G75
    • iPhone 14 Pro (mobile)       • BCD80EB9-B8A8-43F9-9D7F-D96DF7A457CD • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)              • macos                                • darwin-arm64   • macOS 13.5.1 22G90 darwin-arm64
    • Chrome (web)                 • chrome                               • web-javascript • Google Chrome 116.0.5845.140
    ! Error: iPhone is busy: Fetching debug symbols for Harinandan’s iPhone. Xcode will continue when Harinandan’s iPhone is finished. (code -10)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

We moved to wide-gamut rendering in 3.13 and ran into separate issues with image decoding. Perhaps the same issue happens with image encoding as well? cc @gaaclarke

Happy to look at this, @Hari-07 can you please supply full reproduction code so I can reproduce this locally?

In this sample, the 2nd call to .toByteData throws the error
[VERBOSE-2:image_encoding.cc(123)] Could not convert raster image to PNG.
[VERBOSE-2:dart_vm_initializer.cc(41)] Unhandled Exception: Null check operator used on a null value
#0      _Image.toByteData.<anonymous closure>.<anonymous closure> (dart:ui/painting.dart:1959:25)

Code sample
Code sample
import 'dart:async';
import 'dart:ui' as ui;

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  static const _imageUrl =
      'https://images.unsplash.com/photo-1685016925614-d41b39fb66b5?ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHx0b3BpYy1mZWVkfDI2fHRvd0paRnNrcEdnfHxlbnwwfHx8fHw%3D&auto=format&fit=crop&w=800&q=60';

  @override
  void initState() {
    test();
    super.initState();
  }

  void test() async {
    const img = NetworkImage(_imageUrl);

    final im = await _decodeImage(img);

    await im.toByteData();
    await im.toByteData(format: ui.ImageByteFormat.png);
  }

  Future<ui.Image> _decodeImage(
    ImageProvider imageProvider,
  ) {
    final image = imageProvider;
    final completer = Completer<ui.Image>();
    image.resolve(ImageConfiguration.empty).addListener(
      ImageStreamListener((info, _) {
        completer.complete(info.image);
        image.evict();
      }),
    );
    return completer.future;
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.primary,
        title: Text(widget.title),
      ),
      body: Center(
        child: Container(
          height: 300,
          width: 300,
          color: Colors.red,
        ),
      ),
    );
  }
}

Also there was no stacktrace on this error, is there anything we can do that would enable stacktrace for errors that originate from non dart code as well? Atleast the dart call stack that led to the external function call

When I investigate this I'll run your code with a locally built debug engine, launching the xcodeproj from xcode.  That launches it with lldb attached.  Then I'll start adding breakpoints around the code that prints that error.  It should be obvious what is wrong (hopefully) now that you supplied reproduction code.  There's no need to investigate further unless you want.

So, this is related to wide gamut.  In skia, when we try to encode the PNG, when setting the header there is a switch over the pixel format that is missing support for BGR101010x_XR (link).
#0	0x000000010c0fb670 in SkPngEncoderMgr::setHeader(SkImageInfo const&, SkPngEncoder::Options const&) at /Users/aaclarke/dev/engine/src/third_party/skia/src/encode/SkPngEncoderImpl.cpp:126
#1	0x000000010c0fcea0 in SkPngEncoder::Make(SkWStream*, SkPixmap const&, SkPngEncoder::Options const&) at /Users/aaclarke/dev/engine/src/third_party/skia/src/encode/SkPngEncoderImpl.cpp:474
#2	0x000000010c0fd19c in SkPngEncoder::Encode(SkWStream*, SkPixmap const&, SkPngEncoder::Options const&) at /Users/aaclarke/dev/engine/src/third_party/skia/src/encode/SkPngEncoderImpl.cpp:492
#3	0x000000010c0fd2bc in SkPngEncoder::Encode(GrDirectContext*, SkImage const*, SkPngEncoder::Options const&) at /Users/aaclarke/dev/engine/src/third_party/skia/src/encode/SkPngEncoderImpl.cpp:505
#4	0x000000010d24a164 in flutter::(anonymous namespace)::EncodeImage(sk_sp<SkImage> const&, flutter::(anonymous namespace)::ImageByteFormat) at /Users/aaclarke/dev/engine/src/flutter/lib/ui/painting/image_encoding.cc:120
#5	0x000000010d249fa4 in flutter::(anonymous namespace)::EncodeImageAndInvokeDataCallback(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::unique_ptr<tonic::DartPersistentValue, std::_LIBCPP_ABI_NAMESPACE::default_delete<tonic::DartPersistentValue> >, flutter::(anonymous namespace)::ImageByteFormat, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::WeakPtr<GrDirectContext> const&, fml::TaskRunnerAffineWeakPtr<flutter::SnapshotDelegate> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&, bool)::$_1::operator()(sk_sp<SkImage> const&) const at /Users/aaclarke/dev/engine/src/flutter/lib/ui/painting/image_encoding.cc:169
#6	0x000000010d249f58 in decltype(std::declval<flutter::(anonymous namespace)::EncodeImageAndInvokeDataCallback(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::unique_ptr<tonic::DartPersistentValue, std::_LIBCPP_ABI_NAMESPACE::default_delete<tonic::DartPersistentValue> >, flutter::(anonymous namespace)::ImageByteFormat, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::WeakPtr<GrDirectContext> const&, fml::TaskRunnerAffineWeakPtr<flutter::SnapshotDelegate> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&, bool)::$_1&>()(std::declval<sk_sp<SkImage> >())) std::_LIBCPP_ABI_NAMESPACE::__invoke[abi:v15000]<flutter::(anonymous namespace)::EncodeImageAndInvokeDataCallback(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::unique_ptr<tonic::DartPersistentValue, std::_LIBCPP_ABI_NAMESPACE::default_delete<tonic::DartPersistentValue> >, flutter::(anonymous namespace)::ImageByteFormat, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::WeakPtr<GrDirectContext> const&, fml::TaskRunnerAffineWeakPtr<flutter::SnapshotDelegate> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&, bool)::$_1&, sk_sp<SkImage> >(flutter::(anonymous namespace)::EncodeImageAndInvokeDataCallback(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::unique_ptr<tonic::DartPersistentValue, std::_LIBCPP_ABI_NAMESPACE::default_delete<tonic::DartPersistentValue> >, flutter::(anonymous namespace)::ImageByteFormat, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::WeakPtr<GrDirectContext> const&, fml::TaskRunnerAffineWeakPtr<flutter::SnapshotDelegate> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&, bool)::$_1&, sk_sp<SkImage>&&) at /Users/aaclarke/dev/engine/src/third_party/libcxx/include/__functional/invoke.h:403
#7	0x000000010d249f08 in void std::_LIBCPP_ABI_NAMESPACE::__invoke_void_return_wrapper<void, true>::__call<flutter::(anonymous namespace)::EncodeImageAndInvokeDataCallback(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::unique_ptr<tonic::DartPersistentValue, std::_LIBCPP_ABI_NAMESPACE::default_delete<tonic::DartPersistentValue> >, flutter::(anonymous namespace)::ImageByteFormat, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::WeakPtr<GrDirectContext> const&, fml::TaskRunnerAffineWeakPtr<flutter::SnapshotDelegate> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&, bool)::$_1&, sk_sp<SkImage> >(flutter::(anonymous namespace)::EncodeImageAndInvokeDataCallback(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::unique_ptr<tonic::DartPersistentValue, std::_LIBCPP_ABI_NAMESPACE::default_delete<tonic::DartPersistentValue> >, flutter::(anonymous namespace)::ImageByteFormat, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::WeakPtr<GrDirectContext> const&, fml::TaskRunnerAffineWeakPtr<flutter::SnapshotDelegate> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&, bool)::$_1&, sk_sp<SkImage>&&) at /Users/aaclarke/dev/engine/src/third_party/libcxx/include/__functional/invoke.h:488
#8	0x000000010d249edc in std::_LIBCPP_ABI_NAMESPACE::__function::__alloc_func<flutter::(anonymous namespace)::EncodeImageAndInvokeDataCallback(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::unique_ptr<tonic::DartPersistentValue, std::_LIBCPP_ABI_NAMESPACE::default_delete<tonic::DartPersistentValue> >, flutter::(anonymous namespace)::ImageByteFormat, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::WeakPtr<GrDirectContext> const&, fml::TaskRunnerAffineWeakPtr<flutter::SnapshotDelegate> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&, bool)::$_1, std::_LIBCPP_ABI_NAMESPACE::allocator<flutter::(anonymous namespace)::EncodeImageAndInvokeDataCallback(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::unique_ptr<tonic::DartPersistentValue, std::_LIBCPP_ABI_NAMESPACE::default_delete<tonic::DartPersistentValue> >, flutter::(anonymous namespace)::ImageByteFormat, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::WeakPtr<GrDirectContext> const&, fml::TaskRunnerAffineWeakPtr<flutter::SnapshotDelegate> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&, bool)::$_1>, void (sk_sp<SkImage>)>::operator()[abi:v15000](sk_sp<SkImage>&&) at /Users/aaclarke/dev/engine/src/third_party/libcxx/include/__functional/function.h:185
#9	0x000000010d248e00 in std::_LIBCPP_ABI_NAMESPACE::__function::__func<flutter::(anonymous namespace)::EncodeImageAndInvokeDataCallback(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::unique_ptr<tonic::DartPersistentValue, std::_LIBCPP_ABI_NAMESPACE::default_delete<tonic::DartPersistentValue> >, flutter::(anonymous namespace)::ImageByteFormat, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::WeakPtr<GrDirectContext> const&, fml::TaskRunnerAffineWeakPtr<flutter::SnapshotDelegate> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&, bool)::$_1, std::_LIBCPP_ABI_NAMESPACE::allocator<flutter::(anonymous namespace)::EncodeImageAndInvokeDataCallback(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::unique_ptr<tonic::DartPersistentValue, std::_LIBCPP_ABI_NAMESPACE::default_delete<tonic::DartPersistentValue> >, flutter::(anonymous namespace)::ImageByteFormat, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, fml::WeakPtr<GrDirectContext> const&, fml::TaskRunnerAffineWeakPtr<flutter::SnapshotDelegate> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&, bool)::$_1>, void (sk_sp<SkImage>)>::operator()(sk_sp<SkImage>&&) at /Users/aaclarke/dev/engine/src/third_party/libcxx/include/__functional/function.h:359
#10	0x000000010d24d5f8 in std::_LIBCPP_ABI_NAMESPACE::__function::__value_func<void (sk_sp<SkImage>)>::operator()[abi:v15000](sk_sp<SkImage>&&) const at /Users/aaclarke/dev/engine/src/third_party/libcxx/include/__functional/function.h:512
#11	0x000000010d24d3e0 in std::_LIBCPP_ABI_NAMESPACE::function<void (sk_sp<SkImage>)>::operator()(sk_sp<SkImage>) const at /Users/aaclarke/dev/engine/src/third_party/libcxx/include/__functional/function.h:1187
#12	0x000000010d2f1f74 in flutter::ImageEncodingImpeller::ConvertImageToRaster(sk_sp<flutter::DlImage> const&, std::_LIBCPP_ABI_NAMESPACE::function<void (sk_sp<SkImage>)>, fml::RefPtr<fml::TaskRunner> const&, fml::RefPtr<fml::TaskRunner> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<fml::SyncSwitch const> const&, std::_LIBCPP_ABI_NAMESPACE::shared_ptr<impeller::Context> const&)::$_0::operator()(sk_sp<SkImage>)::'lambda'()::operator()() const at /Users/aaclarke/dev/engine/src/flutter/lib/ui/painting/image_encoding_impeller.cc:149

The point-of-contact for this code is out of office.  I'm not sure if we want to change Skia to support this pixel format, or if we should just manually convert the image to kRGBA_F16_SkColorType before passing it down to Skia.  I'm not sure how often this code path is used by Skia so we should make sure that the resulting PNG file is wide gamut too.

Thanks for the sleuthing! The workaround is to disable wide gamut rendering in the app in the meantime right (FLTEnableWideGamut)?

Also, would it be useful to dedupe it with the wide-gamut decoding bug?

Thanks for the sleuthing! The workaround is to disable wide gamut rendering in the app in the meantime right (FLTEnableWideGamut)?

Yep, that will avoid the issue, but of course encoded images will not be wide gamut.

Also, would it be useful to dedupe it with the wide-gamut decoding bug?

Nope, these are 2 different bugs that require 2 different patches to Skia to fix.

xref decompression issue: https://github.com/flutter/flutter/issues/133013

Here is a better workaround than turning wide gamut off.  Convert the image to non-wide gamut data before encoding it to PNG.  That way you can still render your app in full color:
From reproduction code:
  void test() async {
    const img = NetworkImage(_imageUrl);

    final im = await _decodeImage(img);
    final bytes = await im.toByteData(format: ui.ImageByteFormat.rawRgba);
    if (bytes != null) {
      ui.decodeImageFromPixels(
          Uint8List.view(bytes.buffer),
          im.width,
          im.height,
          ui.PixelFormat.rgba8888, (result) async {
        await result.toByteData(format: ui.ImageByteFormat.png);
      });
    }
  }

The fix in skia seems straight forward.  I'll implement a test in Flutter to verify that it is working: https://skia-review.googlesource.com/c/skia/+/752596

When I investigate this I'll run your code with a locally built debug engine, launching the xcodeproj from xcode. That launches it with lldb attached. Then I'll start adding breakpoints around the code that prints that error. It should be obvious what is wrong (hopefully) now that you supplied reproduction code. There's no need to investigate further unless you want.

Not to investigate further but in the future also, from an observability pov, it's quite concerning to me if we see errors that don't have stacktraces as that makes it much harder to figure out what went wrong, if it's on us or if not on whom. So I just asked to see if there's anything that would help in that aspect

switch over the pixel format that is missing support for BGR101010x_XR (link).

I've seen that in flutter in some places, it's mentioned if this error occurs open an issue. I think in the default case for this switch too something like that could be included , which also prints out the pixel format. Would save users and you guys time in the future if there's other formats that are missing support

https://skia-review.googlesource.com/c/skia/+/752596 fixed this issue, it has landed and rolled.  It doesn't have a test inside of flutter though.

Is this something that can be considered to cherry pick and get it out?

Is this something that can be considered to cherry pick and get it out?

This would require a test to be cherry-picked.  I can look into it.  I remember thinking it may be hard to add a test for some reason.

I've attempted to write a unit test against this fix and it seems to crash with memory corruption.  I'm less confident in our skia fix now.  Filed an issue is skia: https://g-issues.skia.org/issues/300986800

While that's a little unfortunate seems like the test did its job. Awesome! 🚀


OCM component section should have examples of a complete ocm spec

What would you like to be added:
https://github.com/open-component-model/ocm-spec/blob/main/doc/specification/elements/README.md#components
This is missing a complete spec of how multiple components would look like in a single file.
Why is this needed:

How is this requirement related to https://github.com/open-component-model/ocm-website/issues/26 ? What is the difference ? Do you suggest to also introduce an example which shows usage of multiple components, like an aggregated component ?

Oh cool. Thanks. I missed that one. :) Yeah that looks good to me.


changed sponsorship page title to 2020

huge PR

📝Changed routes:

/sponsorship

(view full size)

Commit bbc4f081996628052ead5494bb7e2ece94b88de1 (https://unihack-website-git-update-sponsorship-page-title.unihack.now.sh).


Uncaught Error: Cannot find module '../node_modules/keyboard-layout/build/Release/keyboard-layout...

[Enter steps to reproduce:]

...
...

Atom: 1.17.0 x64
Electron: 1.3.15
OS: Microsoft Windows 7 Professional
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot find module '../node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node'
At module.js:457

Error: Cannot find module '../node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node'
    at Module._resolveFilename (module.js:455:15)
    at Module._resolveFilename (~/AppData/Local/atom/app-1.17.0/resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.get_Module._resolveFilename (~/AppData/Local/atom/app-1.17.0/resources/app/src/module-cache.js:354:1)
    at Module.require (~/AppData/Local/atom/app-1.17.0/resources/app/static/index.js:40:43)
    at require (internal/module.js:20:19)
    at customRequire (~/AppData/Local/atom/app-1.17.0/resources/app/static/<embedded>:73:1)
    at get_KeyboardLayoutManager (~/AppData/Local/atom/app-1.17.0/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:7:1)
    at get_manager (~/AppData/Local/atom/app-1.17.0/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:16:1)
    at getCurrentKeyboardLayout (~/AppData/Local/atom/app-1.17.0/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:32:1)
    at Object.getCurrentKeymap (~/AppData/Local/atom/app-1.17.0/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:22:1)
    at exports.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.17.0/resources/app/node_modules/atom-keymap/lib/helpers.js:244:1)
    at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (~/AppData/Local/atom/app-1.17.0/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:456:1)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (~/AppData/Local/atom/app-1.17.0/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:336:1)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (~/AppData/Local/atom/app-1.17.0/resources/app/src/window-event-handler.js:100:1)
    at HTMLDocument.<anonymous> (~/AppData/Local/atom/app-1.17.0/resources/app/src/window-event-handler.js:3:1)

Commands
     -3:14.8.0 core:delete (span.syntax--text.syntax--plain.syntax--null-grammar)
  2x -1:18.1.0 core:save (input.hidden-input)

Non-Core Packages

Thanks for the report!  Can you confirm a few things for us?

what were you doing at the time of the error?
is the error is reproducible?

Open new file (2nd time using after install) pressed key and then error
messages began.
Repeatable? Yes, I have gotten the error every time I have touched a key on
the keyboard to type in line.
On May 17, 2017 5:50 PM, "Robert Sese"<EMAIL_ADDRESS>wrote:
Thanks for the report! Can you confirm a few things for us?

what were you doing at the time of the error?
is the error is reproducible?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/14461#issuecomment-302252966, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Aafp_4LYd9JbT30CzyeOFuHZpLVef_X3ks5r63m2gaJpZM4Neeob
.

Thanks for confirming - not sure why that module wouldn't get installed.  Can you confirm whether this directory exists or not?
~/AppData/Local/atom/app-1.17.0/resources/app/node_modules/keyboard-layout/

At this point I've already moved to uninstall it.
If I push it in again I'll check for it.
On May 22, 2017 4:11 PM, "Robert Sese"<EMAIL_ADDRESS>wrote:

Thanks for confirming - not sure why that module wouldn't get installed.
Can you confirm whether this directory exists or not?
~/AppData/Local/atom/app-1.17.0/resources/app/node_modules/
keyboard-layout/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/14461#issuecomment-303221118, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Aafp_0qHvmpoMkuBWaBWtzvqmv6Mcy7-ks5r8fnqgaJpZM4Neeob
.

Thanks @ragiemouse :v:
@Xsinh - can you try re-installing?  It looks like some files didn't get installed so hopefully re-installing will resolve it for you.

Good night ( we have a night:) ).It's happened when i tried changed some
files in ftp server (open with atom). After save application is crashed
because before i changed some inaccessible files. After that application is
crashed with exception(I do not remember, but if this
important, i'll see this exception on work tomorrow and send you). I was
restart my mashine but this not helped,
error was otavalas.
I did not try to reinstall the application, since I had to operatively use
notpad ++ at that time. I hope I helped you)
P.S
Sorry for my English if i wrote with exception)
2017-05-24 0:39 GMT+03:00 Robert Sese<EMAIL_ADDRESS>
Thanks @ragiemouse https://github.com/ragiemouse ✌
@Xsinh https://github.com/xsinh - can you try re-installing? It looks
like some files didn't get installed so hopefully re-installing will
resolve it for you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/14461#issuecomment-303539940, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQr9f9jaUYBdBGq4aMeLDm7qkfIZHvhWks5r81H9gaJpZM4Neeob
.

I just hit this, fresh installed Atom, no plugins, no themes. On a fresh MBP.
I was trying to create a new file.

@alexandernst - curious if you tried re-installing?  There's been sporadic reports of this type of error but we haven't been able to reproduce.

Not yet.
On Jul 19, 2017 2:54 PM, "Robert Sese"<EMAIL_ADDRESS>wrote:

@alexandernst https://github.com/alexandernst - curious if you tried
re-installing? There's been sporadic reports of this type of error but we
haven't been able to reproduce.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/14461#issuecomment-316498032, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Aafp__3VQPca26I4PBCIii6YQ781SH71ks5sPl8DgaJpZM4Neeob
.

@rsese I successfully figured out what exactly happened, but I forgot to report it. I'm sorry.
The thing is that Atom for Mac will download as an .app file (it downloads a .zip, but Safari automatically extracts it). I then double-clicked the file (thinking that Atom will be smart enough to copy itself to the Applications folder) and then removed it.
Turns out Atom doesn't copy itself to anywhere. Running Atom and then deleting the .app file will trigger those errors, as Atom is trying to access files that don't exist anymore. Hence the Cannot find module... errors.
I hope this helps.

Well that could explain the error on macOS but not on Windows.  The original report is coming from the typical Atom installation directory on Windows.

I am getting this error on ArchLinux with Gnome as well.
process.versions:
ares:"1.10.1-DEV" atom-shell:"1.6.9" chrome:"56.0.2924.87" electron:"1.6.9" http_parser:"2.7.0" modules:"53" node:"7.4.0" openssl:"1.0.2j" uv:"1.10.1" v8:"5.6.326.50" zlib:"1.2.8"
Full stack trace here:
Error: Could not connect to X display.     at get_manager (/usr/share/atom/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:16:37)     at getCurrentKeyboardLayout (/usr/share/atom/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:32:17)     at Object.getCurrentKeymap (/usr/share/atom/resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:22:31)     at exports.keystrokeForKeyboardEvent (/usr/share/atom/resources/app/node_modules/atom-keymap/lib/helpers.js:244:66)     at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (/usr/share/atom/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:456:20)     at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/usr/share/atom/resources/app/node_modules/atom-keymap/lib/keymap-manager.js:336:30)     at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/usr/share/atom/resources/app/src/window-event-handler.js:100:42)     at HTMLDocument.<anonymous> (/usr/share/atom/resources/app/src/window-event-handler.js:3:65)
Happens when I open a file in Atom from Gnome, anything I type crashes immediately.  Oddly enough, if I start atom from gnome-terminal, no issues at all.

I may have found some information that may lead to the solution of this issue.
I use anti-malware software which found a Trojan.RansomKD Infection from two locations:

the location of "keytar.node"
the location of "keyboard-layout-manager.node"

After detecting these Trojans, the anti-malware did quarantine these files which then resulted in atom editor breaking in a similar fashion as described above.
Hope this info is of some use.

Yesterday 20 September, Atom was working fine. I may have done an Atom update at the end of my work, I'm not sure.
Today, any keystroke causes a red error box. The message varies depending on what I do. Here's what I get when I enter a comma to add to an array.
module.js:472
Hide Stack Trace
Error: Cannot find module '../node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node'
at Module._resolveFilename (module.js:470:15)
at Module._resolveFilename (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\electron.asar\common\reset-search-paths.js:35:12)
at Function.get_Module._resolveFilename (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\src\module-cache.js:354:58)
at Module.require (file:///C:/Users/Robyn/AppData/Local/atom/app-1.20.1/resources/app/static/index.js:40:43)
at require (internal/module.js:20:19)
at customRequire (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\static<embedded>:96:26)
at get_KeyboardLayoutManager (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\node_modules\keyboard-layout\lib\keyboard-layout.js:7:65)
at get_manager (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\node_modules\keyboard-layout\lib\keyboard-layout.js:16:42)
at getCurrentKeyboardLayout (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\node_modules\keyboard-layout\lib\keyboard-layout.js:32:17)
at Object.getCurrentKeymap (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\node_modules\keyboard-layout\lib\keyboard-layout.js:22:31)
at exports.keystrokeForKeyboardEvent (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\node_modules\atom-keymap\lib\helpers.js:244:66)
at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\node_modules\atom-keymap\lib\keymap-manager.js:467:20)
at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\node_modules\atom-keymap\lib\keymap-manager.js:347:30)
at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\src\window-event-handler.js:100:42)

Both keyboard-layout-manager.node and keytar.node were removed automatically by F-Secure safe as "Trojan.RansomKD.6011707" and "Trojan.RansomKD.6011829" today about 30 minutes ago on my win7 machine, resulting this issue. Not sure if it is f-secure heuristics gone wrong or actually .malware leaked into Atom.

I can confirm that the same reason caused my atom to break as for vltrr (win10 machine + F-Secure). Uninstalling and downloading a new atom from website did resolve this error. However, I have yet to do a virus scan for possible malware. The two Trojans are quarantined and so far no new malware have been automatically found by antivirus from these two .node-files.

I uninstalled Atom from my Windows10 and attempted twice to re-install.
Both times the install package failed.  What's going on here?
A large message described the fail.  It starts as follows:
Program: Starting Squirrel Updater: --install .
Program: Starting install, writing to
C:\Users\Robyn\AppData\Local\SquirrelTemp
CheckForUpdateImpl: Failed to load local releases, starting from scratch:
System.IO.DirectoryNotFoundException: Could not find a part of the path
'C:\Users\Robyn\AppData\Local\atom\packages\RELEASES'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess
access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize,
FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean
bFromProxy, Boolean useLongPath, Boolean checkHost)
and ends with:
at
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task
task)
at
Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClass7_0.<b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task
task)
On Thu, Sep 21, 2017 at 4:08 PM, Juho Jokela<EMAIL_ADDRESS>wrote:

I can confirm that the same reason caused my atom to break as for vltrr
(win10 machine + F-Secure). Uninstalling and downloading a new atom from
website did resolve this error. However, I have yet to do a virus scan for
possible malware. The two Trojans are quarantined and so far no new malware
have been automatically found by antivirus from these two .node-files.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/14461#issuecomment-331266848, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADDSb16ohwIu-wWXFVB_InCWHsX5smbsks5sksJHgaJpZM4Neeob
.

--
Mike Laird
12 Arbor Creek Drive, Pittsford, New York 14534
<EMAIL_ADDRESS>". . . remembering on both sides that civility is not a sign of weakness,
and sincerity is always subject to proof. Let us never negotiate out of
fear, but let us never fear to negotiate."  - John F. Kennedy

I'm having this problem since yesterday in Windows 10 Pro. Any key raise red alert :
'../node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node'
module.js:472
And when I check my Bitdefender Total Security 2018, the culprit was in Atom's User App Data, it registered as :

Trojan.RansomKD.6011707 = c:\users\indra\appdata\local\atom\app-1.20.1\resources\app\node_modules\keyboard-layout\build\release\keyboard-layout-manager.node
Trojan.RansomKD.6011829 = c:\users\indra\appdata\local\atom\app-1.20.1\resources\app\apm\node_modules\keytar\build\release\keytar.node

Can confirm exactly the same situation as @IndraBuana, running Bitdefender Free.
Trojan.RansomKD.6011829:
...\atom\app-1.20.1\resources\app\apm\node_modules\keytar\build\release\keytar.node
Trojan.RansomKD.6011707:
...\atom\app-1.20.1\resources\app\node_modules\keyboard-layout\build\release\keyboard-layout-manager.node

About these false positives, please report them to your anti-virus vendor, e.g. see this recent issue in keytar's repository:
https://github.com/atom/node-keytar/issues/75

I am using BitDefender and can confirm the same issue.

This issue also exists when using Heat EMSS anti-virus (Atom version 1.20.1).  Judging from the range of comments, it seems probable that the issue lies with Atom as opposed to every anti-virus vendor in the world.

Getting this issue as well. Atom editor is slow, error messages pop up everywhere, and it frequently crashes with freeze but also occasionally a sudden shutdown of the application.
Anti-virus: F-Secure PSB Workstation Security 12.01 build 283
Issues with:

keytar (atom/node-keytar#75)
keyboard-layout-manager.node

F-Secure categorizes them as Trojan and Ransomware.

I am also getting this issue with Atom + Bitdefender. In the bitdefender log On-Access scanning has detected a threat. The file has been deleted.C:\Users\Steven\AppData\Local\atom\app-1.20.1\resources\app\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node is malware of type Trojan.RansomKD.6011707

My Bitdefender says the same thing as Kasper Sofren reported above. I tried
a third new install this morning and it failed, again. It seems Bitdefender
is denying installation of the keytar and keyboard-layout-manager files.
The problem is in the current Atom code. This is a mess.  Atom doesn't
work, and new installs will not install because they include a Trojan.
Here's a small section of the failure log:
2017-09-21 16:54:30> CheckForUpdateImpl: Failed to load local releases,
starting from scratch: System.IO.DirectoryNotFoundException: Could not find
a part of the path 'C:\Users\Robyn\AppData\Local\atom\packages\RELEASES'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess
access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize,
FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean
bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess
access, FileShare share)
at Squirrel.Utility.LoadLocalReleases(String localReleaseFile)
at
Squirrel.UpdateManager.CheckForUpdateImpl.d__2.MoveNext()
2017-09-21 16:54:30> CheckForUpdateImpl: Reading RELEASES file from
C:\Users\Robyn\AppData\Local\SquirrelTemp
2017-09-21 16:54:30> CheckForUpdateImpl: First run or local directory is
corrupt, starting from scratch
2017-09-21 16:54:30> ApplyReleasesImpl: Writing files to app directory:
C:\Users\Robyn\AppData\Local\atom\app-1.20.1
2017-09-21 16:54:31> LogHost: Rigging execution stub for
atom_ExecutionStub.exe to C:\Users\Robyn\AppData\Local\atom\atom.exe
2017-09-21 16:54:38> IEnableLogger: Failed to install package to app dir:
System.UnauthorizedAccessException: Access to the path
'C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\apm\node_modules\keytar\build\Release\keytar.node'
is denied.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
On Fri, Sep 22, 2017 at 5:49 AM, Steven Mason<EMAIL_ADDRESS>wrote:

I am also getting this issue with Atom + Bitdefender. In the bitdefender
log On-Access scanning has detected a threat. The file has been
deleted.C:\Users\Steven\AppData\Local\atom\app-1.20.1
resources\app\node_modules\keyboard-layout\build\Release\keyboard-layout-manager.node
is malware of type Trojan.RansomKD.6011707
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/14461#issuecomment-331402890, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADDSb4gg790ULhx8yjU7oWqq7Z8qnJR1ks5sk4KlgaJpZM4Neeob
.

--
Mike Laird
12 Arbor Creek Drive, Pittsford, New York 14534
<EMAIL_ADDRESS>". . . remembering on both sides that civility is not a sign of weakness,
and sincerity is always subject to proof. Let us never negotiate out of
fear, but let us never fear to negotiate."  - John F. Kennedy

@duckboy1981 @rsese seems like this might not be just a false alarm. I reinstalled atom, and compared the quarantined files, and they differ, while both were atom 1.20.1. F-Secure doesnt complain on the new install, not even with a manual scan.
SHA256 hashes
keytar
# atom/app-1.20.1/resources/app/apm/node_modules/keytar/build/Release/keytar.node

# possibly infected, 91136 bytes:
5cebb88cfea9a603ff1e69bfed199744975a571ea2895d5490136d2ec1089ef3

# new install, 113664 bytes
b66b224c2252b0e469f7c299044d179d1983f9b247051de833a946a5bd30b8e5

keyboard-layout-manager
# atom/app-1.20.1/resources/app/node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node

# possibly infected, 129536 bytes
1ce5677f9d6fba5b8141ac75c9f2a0de82f0925cac91ce25efc48d051703e545

# new install, 157184 bytes
9effac8bc80e49584dca64259553fbb00e2851f70de28de826cd7376bc8673a7

I attempted a new download and install at about 1:00PM, 22 September, and
it again failed. Its not clear whether the new files are infected, or
quarantined old files are disrupting the install.  Here is most of the
failure log:
2017-09-22 13:00:56> CheckForUpdateImpl: Failed to load local releases,
starting from scratch: System.IO.DirectoryNotFoundException: Could not find
a part of the path 'C:\Users\Robyn\AppData\Local\atom\packages\RELEASES'.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess
access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize,
FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean
bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess
access, FileShare share)
at Squirrel.Utility.LoadLocalReleases(String localReleaseFile)
at
Squirrel.UpdateManager.CheckForUpdateImpl.d__2.MoveNext()
2017-09-22 13:00:56> CheckForUpdateImpl: Reading RELEASES file from
C:\Users\Robyn\AppData\Local\SquirrelTemp
2017-09-22 13:00:56> CheckForUpdateImpl: First run or local directory is
corrupt, starting from scratch
2017-09-22 13:00:56> ApplyReleasesImpl: Writing files to app directory:
C:\Users\Robyn\AppData\Local\atom\app-1.20.1
2017-09-22 13:00:57> LogHost: Rigging execution stub for
atom_ExecutionStub.exe to C:\Users\Robyn\AppData\Local\atom\atom.exe
2017-09-22 13:01:04> IEnableLogger: Failed to install package to app dir:
System.UnauthorizedAccessException: Access to the path
'C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\apm\node_modules\keytar\build\Release\keytar.node'
is denied.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess
access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize,
FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean
bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess
access, FileShare share)
at SharpCompress.Readers.IReaderExtensions.WriteEntryToFile(IReader
reader, String destinationFileName, ExtractionOptions options)
at
Squirrel.ReleasePackage.<>c__DisplayClass15_2.b__1()
at Squirrel.Utility.<>c__DisplayClass8_0.b__0()
at Squirrel.Utility.Retry[T](Func1 block, Int32 retries)    at Squirrel.Utility.Retry(Action block, Int32 retries)    at Squirrel.ReleasePackage.<>c__DisplayClass15_0.<ExtractZipForInstall>b__0()    at System.Threading.Tasks.Task.InnerInvoke()    at System.Threading.Tasks.Task.Execute() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClass7_0.<<installPackageToAppDir>b__0>d.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.Utility.<LogIfThrows>d__431.MoveNext()
2017-09-22 13:01:04> Unhandled exception: System.AggregateException: One or
more errors occurred. ---> System.UnauthorizedAccessException: Access to
the path
'C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\apm\node_modules\keytar\build\Release\keytar.node'
is denied.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess
access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize,
FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean
bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess
access, FileShare share)
at SharpCompress.Readers.IReaderExtensions.WriteEntryToFile(IReader
reader, String destinationFileName, ExtractionOptions options)
at
Squirrel.ReleasePackage.<>c__DisplayClass15_2.b__1()
at Squirrel.Utility.<>c__DisplayClass8_0.b__0()
at Squirrel.Utility.Retry[T](Func1 block, Int32 retries)    at Squirrel.Utility.Retry(Action block, Int32 retries)    at Squirrel.ReleasePackage.<>c__DisplayClass15_0.<ExtractZipForInstall>b__0()    at System.Threading.Tasks.Task.InnerInvoke()    at System.Threading.Tasks.Task.Execute() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClass7_0.<<installPackageToAppDir>b__0>d.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.Utility.<LogIfThrows>d__431.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task
task)
at
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task
task)
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
at
Squirrel.UpdateManager.ApplyReleasesImpl.d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task
task)
at
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task
task)
at Squirrel.UpdateManager.d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task
task)
at
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task
task)
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
at Squirrel.Update.Program.d__4.MoveNext()
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean
includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout,
CancellationToken cancellationToken)
at System.Threading.Tasks.Task.Wait()
at Squirrel.Update.Program.executeCommandLine(String[] args)
at Squirrel.Update.Program.main(String[] args)
---> (Inner Exception #0) System.UnauthorizedAccessException: Access to the
path
'C:\Users\Robyn\AppData\Local\atom\app-1.20.1\resources\app\apm\node_modules\keytar\build\Release\keytar.node'
is denied.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess
access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize,
FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean
bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess
access, FileShare share)
at SharpCompress.Readers.IReaderExtensions.WriteEntryToFile(IReader
reader, String destinationFileName, ExtractionOptions options)
at
Squirrel.ReleasePackage.<>c__DisplayClass15_2.b__1()
at Squirrel.Utility.<>c__DisplayClass8_0.b__0()
at Squirrel.Utility.Retry[T](Func1 block, Int32 retries)    at Squirrel.Utility.Retry(Action block, Int32 retries)    at Squirrel.ReleasePackage.<>c__DisplayClass15_0.<ExtractZipForInstall>b__0()    at System.Threading.Tasks.Task.InnerInvoke()    at System.Threading.Tasks.Task.Execute() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.UpdateManager.ApplyReleasesImpl.<>c__DisplayClass7_0.<<installPackageToAppDir>b__0>d.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Squirrel.Utility.<LogIfThrows>d__431.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task
task)
at
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task
task)
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
at
Squirrel.UpdateManager.ApplyReleasesImpl.d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task
task)
at
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task
task)
at Squirrel.UpdateManager.d__10.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task
task)
at
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task
task)
at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)
at Squirrel.Update.Program.d__4.MoveNext()<---
On Fri, Sep 22, 2017 at 10:26 AM, vltrrr<EMAIL_ADDRESS>wrote:

@duckboy1981 https://github.com/duckboy1981 @rsese
https://github.com/rsese seems like this might not be just a false
alarm. I reinstalled atom, and compared the quarantined files, and they
differ, while both were atom 1.20.1. F-Secure doesnt complain on the new
install, not even with a manual scan.
SHA256 hashes
keytar
atom/app-1.20.1/resources/app/apm/node_modules/keytar/build/Release/keytar.node
possibly infected, 91136 bytes:
5cebb88cfea9a603ff1e69bfed199744975a571ea2895d5490136d2ec1089ef3
new install, 113664 bytes
b66b224c2252b0e469f7c299044d179d1983f9b247051de833a946a5bd30b8e5
keyboard-layout-manager
atom/app-1.20.1/resources/app/node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node
possibly infected, 129536 bytes
1ce5677f9d6fba5b8141ac75c9f2a0de82f0925cac91ce25efc48d051703e545
new install, 157184 bytes
9effac8bc80e49584dca64259553fbb00e2851f70de28de826cd7376bc8673a7
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/14461#issuecomment-331461865, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADDSb1a1qrSnI1LNh-NI1KRkg7uoX_UCks5sk8OMgaJpZM4Neeob
.

--
Mike Laird
12 Arbor Creek Drive, Pittsford, New York 14534
<EMAIL_ADDRESS>". . . remembering on both sides that civility is not a sign of weakness,
and sincerity is always subject to proof. Let us never negotiate out of
fear, but let us never fear to negotiate."  - John F. Kennedy

Hey all I'm sorry for the frustrating experience here. It does often feel like when it comes to anti-virus, the cure is worse than the disease. I just want to reiterate that these are false-positives that need to be reported to your AV software vendors.

@iolsen I have also supplied F-Secure with the quarantined files, no reply so far (and I don't know how much hope there is for one :). Changed to sublime for now to avoid issues.

@Ian Olsen, for the moment I'll take your word that false positives are an
issue because I did finally get a new Atom install to work. However, Atom
has some issues to deal with from this mess also.  Your install program
does not clean out old versions. In Safe Mode looking at hidden files (ie
my time was wasted getting there) I found my 3 prior Atom installs from the
past 2 days all concatenated together in one directory. This glob of files
certainly didn't help to get a clean install.  After I removed them, I
finally got my 4th install to work.  Nothing changed with Bitdefender, to
my knowledge.
On Fri, Sep 22, 2017 at 2:27 PM, vltrrr<EMAIL_ADDRESS>wrote:

@iolsen https://github.com/iolsen I have also supplied F-Secure with
the quarantined files, no reply so far (and I don't know how much hope
there is for one :). Changed to sublime for now to avoid issues.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/14461#issuecomment-331524792, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADDSbxir2f_xWR0oZVSdViO4mMFyiSS0ks5sk_v6gaJpZM4Neeob
.

--
Mike Laird
12 Arbor Creek Drive, Pittsford, New York 14534
<EMAIL_ADDRESS>". . . remembering on both sides that civility is not a sign of weakness,
and sincerity is always subject to proof. Let us never negotiate out of
fear, but let us never fear to negotiate."  - John F. Kennedy

our install program
does not clean out old versions. In Safe Mode looking at hidden files (ie
my time was wasted getting there) I found my 3 prior Atom installs from the
past 2 days all concatenated together in one directory. This glob of files
certainly didn't help to get a clean install.  After I removed them, I
finally got my 4th install to work

Sorry about that one @mLaird, there's a known bug where old installs on Windows weren't getting cleaned up and that will be fixed in an upcoming release /cc https://github.com/atom/atom/issues/15320#issuecomment-331391592.

If it helps anyone, I had to reboot before I could re-install. It appears the file location was locked for some reason even after deleting the whole atom directory.

I am now having this problem as well.  Bitdefender found  the two modules
keyboard-layout-manager.node'
keytar.node
Looking at the web access logs, I note that Atom is connecting to <IP_ADDRESS>.  Not sure whether that normal or it's evidence that Atom is really infected.

@Neil Shapiro According to Whois.com,  that link is registered to Github.
You are probably sharing Atom usage info with Github - it is part of your
settings options.
https://www.whois.com/whois/<IP_ADDRESS>
With all due respect to Bitdefender (I am a happy customer), you can fix
the problem faster with the process I described above. Uninstall Atom, go
into Safe Mode, show hidden files, delete the AppData files that Atom does
not uninstall, reinstall Atom.
On Mon, Sep 25, 2017 at 9:40 AM, Neil Shapiro<EMAIL_ADDRESS>wrote:

I am now having this problem as well. Bitdefender found the two modules
keyboard-layout-manager.node'
keytar.node
Looking at the web access logs, I note that Atom is connecting to
<IP_ADDRESS>. Not sure whether that normal or it's evidence that Atom is
really infected.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/14461#issuecomment-331883876, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADDSb6q4QUZbQJq57A5LZz6SwbHyPqiNks5sl61cgaJpZM4Neeob
.

--
Mike Laird
12 Arbor Creek Drive, Pittsford, New York 14534
<EMAIL_ADDRESS>". . . remembering on both sides that civility is not a sign of weakness,
and sincerity is always subject to proof. Let us never negotiate out of
fear, but let us never fear to negotiate."  - John F. Kennedy

@mLaird Thanks!
I've removed it but it seems there are two scenarios impacting reinstalling the same version again:

Assuming it's a false positive, Bitdefender would just flag it again, unless they have already changed/fixed their virus detection profile affecting it.   Does anyone know if that's the case?
Assuming somehow the ATOM distribution is fine, it's a bit worrying that perhaps those modules were somehow targeted and changed after they were installed (and BD didn't notice).

After the CCleaner fiasco, I feel it's better to error on the side of caution when something like this happens--at least to let the dust settle.    I'm going to sit it out and use a different code editor at least until the next release or until the true nature of this is clearly elaborated.  (Though #2 above still could be a problem and worries me!)

@ Neil Shapiro Somehow Case #1 does not happen. But you have to do whatever
you have to do.
On Mon, Sep 25, 2017 at 12:55 PM, Neil Shapiro<EMAIL_ADDRESS>wrote:

@mLaird https://github.com/mlaird Thanks!
I've removed it but it seems there are two scenarios impacting
reinstalling the same version again:

Assuming it's a false positive, Bitdefender would just flag it
again, unless they have already changed/fixed their virus detection profile
affecting it. Does anyone know if that's the case?
Assuming somehow the ATOM distribution is fine, it's a bit worrying
that perhaps those modules were somehow targeted and changed after they
were installed (and BD didn't notice).

After the CCleaner fiasco, I feel it's better to error on the side of
caution when something like this happens--at least to let the dust settle.
I'm going to sit it out and use a different code editor at least until the
next release or until the true nature of this is clearly elaborated.
(Though #2 https://github.com/atom/atom/issues/2 above still could be a
problem and worries me!)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/atom/atom/issues/14461#issuecomment-331943849, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADDSb6emoJFxPpcNZNei1Gn-Jg-RMYyzks5sl9r5gaJpZM4Neeob
.

--
Mike Laird
12 Arbor Creek Drive, Pittsford, New York 14534
<EMAIL_ADDRESS>". . . remembering on both sides that civility is not a sign of weakness,
and sincerity is always subject to proof. Let us never negotiate out of
fear, but let us never fear to negotiate."  - John F. Kennedy

Seems for me to be down to AVG Anti virus quarantining a file. Restored the file and now back to normal. If it happens again I shall drop and email to AVG to notify them.

F-secure answered and confirmed false alarm. Issue should be now resolved.

Just hit this problem on macOS Sierra, following a crash trying to close a file. No anti-virus implicated in it, as far as I know:
Error: Cannot find module '../node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node'
    at Module._resolveFilename (module.js:455:15)
    at Module._resolveFilename (/Applications/Atom.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.get_Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app/src/module-cache.js:354:58)
    at Module.require (file:///Applications/Atom.app/Contents/Resources/app/static/index.js:40:43)
    at require (internal/module.js:20:19)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:96:26)
    at get_KeyboardLayoutManager (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:7:65)
    at get_manager (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:16:42)
    at getCurrentKeyboardLayout (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:32:17)
    at Object.getCurrentKeymap (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:22:31)
    at exports.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/helpers.js:244:66)
    at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:456:20)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:336:30)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:100:42)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:3:65)

OSX High Sierra I've got the same error after added a keybinding in keymap.cson
'.platform-darwin atom-text-editor':
    'ctrl-cmd-a':	'aligner:align'

After I removed the .platform-darwin it worked just fine
This is the error stack
Error: Cannot find module '../node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node'
    at Module._resolveFilename (module.js:470:15)
    at Module._resolveFilename (/Applications/Atom.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.get_Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app/src/module-cache.js:354:58)
    at Module.require (file:///Applications/Atom.app/Contents/Resources/app/static/index.js:40:43)
    at require (internal/module.js:20:19)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:96:26)
    at get_KeyboardLayoutManager (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:7:65)
    at get_manager (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:16:42)
    at Object.getCurrentKeyboardLayout (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:32:17)
    at exports.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/helpers.js:244:117)
    at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:467:20)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:347:30)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:100:42)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:3:65)

This just started happening to me on OSX sierra. I've been coding most of the morning without an issue. I played around with my eslintrc file to enable some react related settings and when I re-launched atom, the error is popping every keystroke :(
Error stack is:
Error: Cannot find module '../node_modules/keyboard-layout/build/Release/keyboard-layout-manager.node'     at Module._resolveFilename (module.js:470:15)     at Module._resolveFilename (/Applications/Atom.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)     at Function.get_Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app/src/module-cache.js:354:58)     at Module.require (file:///Applications/Atom.app/Contents/Resources/app/static/index.js:40:43)     at require (internal/module.js:20:19)     at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:96:26)     at get_KeyboardLayoutManager (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:7:65)     at get_manager (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:16:42)     at getCurrentKeyboardLayout (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:32:17)     at Object.getCurrentKeymap (/Applications/Atom.app/Contents/Resources/app/node_modules/keyboard-layout/lib/keyboard-layout.js:22:31)     at exports.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/helpers.js:244:66)     at KeymapManager.module.exports.KeymapManager.keystrokeForKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:456:20)     at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app/node_modules/atom-keymap/lib/keymap-manager.js:336:30)     at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:100:42)     at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app/src/window-event-handler.js:3:65)

I've restarted and upgraded all add ins, and it hasn't reoccurred yet ...

Thanks for the details @slimdave - if you come across steps to reproduce, definitely let us know.

OSX High Sierra I've got the same error after added a keybinding in keymap.cson

Thanks @elisei-timofte - it sounds like you have reproducible steps but it seems pretty different from the rest of the reports in this thread.  Can you open a separate issue and fill out the issue template so we can track it and try to reproduce (I don't have High Sierra to test with at the moment)?

Also having this issue on OSX

As a temporary solution for my OSX Sierra, I just downloaded atom/keyboard-layout repo and copied it into /Applications/Atom.app/Contents/Resources/app/apm/node_modules

@hyakuhei have you tried reinstalling?

i have a fix for this.

go into C:\Users[USER]\AppData\Local\atom\
find a previous release folder, in my case "app-1.21.2"
go in the file directory to \app-1.21.1\resources\app.asar.unpacked\node_modules\
copy keyboard-layout folder with CTLR-C
go back into C:\Users[USER]\AppData\Local\atom\app-1.22.1 and in the file directory to \resources\app.asar.unpacked\node_modules\
paste copied folder with the dependant .node file

Still happening after deleting 1.26.0 and updating again. Error appears when modifying any file.

I reinstalled my atom compiler without uninstalling it.
It started working.
Thanks rsese .

Will there be a fix for this in the future? reinstalling Atom has worked so far, but it becomes irritating and I wished there was some kind of fix for this bug that somehow got around this.

I was able to resolve it by copying keyboard__layout from a different version (app-1.28)

Ran into this issue today, along side other bugs in Atom, this was just the one that threw an error and stopped me from using the application. I have been using Atom daily for several months and I haven't seen any app updates so I am not sure what would have happened.
Other Bugs:

Couldn't fetch data from Install
Git would open but no fetch
Could not scan for updates

I followed this thread a little bit and noticed I couldn't find the modules that were throwing errors in any of the app directories. After I was about to give up I deleted the app-1.31.1 and app-1.31.2 directories from the folder and everything was working like a charm again.
The update directories did not re-install themselves however and atom does not appear to think it has an update waiting so I am not sure what features I am now lacking but at least my application works again.

Hello, i encounter a really annoying issues with Atom. Every time after few days, or after many compiles when i want to run a code it simply ignore all the inputs and the code and show the message "press any key to continue". This happened three times in a week, i must unistall it and install again. Please fix this problem. I followed thr tutorial step by step

emanuel can you send a screenshot?


Update akka-stream-alpakka-influxdb to 3.0.0

Updates com.lightbend.akka:akka-stream-alpakka-influxdb from 1.1.2 to 3.0.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lightbend.akka", artifactId = "akka-stream-alpakka-influxdb" } ]

labels: library-update, semver-major

Superseded by #242.


Scheduled Connect email does not send HTML output

When using the Connect scheduled email feature, the email from Connect does not produce the HTML output as expected. However, when manually emailing within Connect (using the Email Icon to send email), an HTML email generates and sends as expected.
Very much looking forward to using quarto with scheduled emails. It's already much easier to use and implement when compared to Blastula, which has also been great!

Using Quarto 1.3.361, with Workbench 2023.06.1
Ran quarto add rich-iannone/quarto-email at October 11, 10am PT
Generated manifest for quarto document (see below; modified version of what Rich has on github so it renders correctly without issue)
Deployed to Connect (2023.09.0 on Ubuntu 20.04) via git-backed publishing option
I can click the email icon in Connect and it sends the correct email

But then I schedule it to run at 11:08am local time and I get this instead

Quarto document used for testing.

---
format:
  html: default
filters:
  - rich-iannone/quarto-email
email-preview: true
---

\```{r}
#| echo: false

profit <- -100

if (profit < 0) {

  # Send email since we have a reason for it

  subject <- "We have a problem here"
  send_email <- TRUE

} else {

  # Don't send email; everything is fine

  subject <- "No email. This won't be sent"
  send_email <- FALSE
}
\```

The email body follows.`r profit`

::: email
Our profit was `r profit` this quarter and we felt you should know.

::: subject
`r subject`
:::

::: email-scheduled
`r send_email`
:::
:::

The email received is also missing the HTML report attachment and note about mail clients not properly viewing HTML attachments. These are ordinarily present when Connect sends the standard, non-customized email.

@aronatkins Me and @kmasiello  confirmed this when recently pairing. We are thinking it is an issue on the Connect side of things (only affecting scheduled renders as far as we can tell).

The intent was for Quarto content to not be directly attached to email. We do not render Quarto documents as standalone and they are generally not appropriate for download-and-view. I'll get Connect to avoid adding the note for Quarto content.

Looks like the Quarto email attachments are also missing. That's also an oversight. I'll get that resolved on the Connect side.


Properly handle AsyncGeneratorUnwrapYieldResumption

This updates the __asyncGenerator helper to more correctly observe AsyncGeneratorUnwrapYieldResumption with regards to the return method of an async generator.
Fixes #54768

An update to tslib will follow shortly.


Ensure that SOME sort of locomotion is selected

Prevents bugs where players cant move if this value is bad

Thank you!


Don't freeze directory dependencies during Poetry update

Fixes #1771
Have added what I think is one-line code fix and a sample pyproject.toml for testing with a path dependency on ../toml, but don't know how to write the rspec tests, so can't verify the fix.
For reference, the generated poetry.lock file for that test is attached (not in required format, which looks like JSON for the tests). As you can see, the toml dependency is versioned in the Lockfile, but we shouldn't carry across that version in the frozen dependencies. It has a [package.source] subsection that can be used to detect the type of dependency that it is. The code already handles git dependencies in a special way.
[[package]]
category = "main"
description = "Atomic file writes."
marker = "sys_platform == \"win32\""
name = "atomicwrites"
optional = false
python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*"
version = "1.3.0"

[[package]]
category = "main"
description = "Classes Without Boilerplate"
name = "attrs"
optional = false
python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*"
version = "19.3.0"

[package.extras]
azure-pipelines = ["coverage", "hypothesis", "pympler", "pytest (>=4.3.0)", "six", "zope.interface", "pytest-azurepipelines"]
dev = ["coverage", "hypothesis", "pympler", "pytest (>=4.3.0)", "six", "zope.interface", "sphinx", "pre-commit"]
docs = ["sphinx", "zope.interface"]
tests = ["coverage", "hypothesis", "pympler", "pytest (>=4.3.0)", "six", "zope.interface"]

[[package]]
category = "main"
description = "Cross-platform colored terminal text."
marker = "sys_platform == \"win32\""
name = "colorama"
optional = false
python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*"
version = "0.4.3"

[[package]]
category = "main"
description = "Read metadata from Python packages"
marker = "python_version < \"3.8\""
name = "importlib-metadata"
optional = false
python-versions = "!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*,>=2.7"
version = "1.6.0"

[package.dependencies]
zipp = ">=0.5"

[package.extras]
docs = ["sphinx", "rst.linker"]
testing = ["packaging", "importlib-resources"]

[[package]]
category = "main"
description = "More routines for operating on iterables, beyond itertools"
name = "more-itertools"
optional = false
python-versions = ">=3.5"
version = "8.2.0"

[[package]]
category = "main"
description = "Core utilities for Python packages"
name = "packaging"
optional = false
python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*"
version = "20.3"

[package.dependencies]
pyparsing = ">=2.0.2"
six = "*"

[[package]]
category = "main"
description = "plugin and hook calling mechanisms for python"
name = "pluggy"
optional = false
python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*"
version = "0.13.1"

[package.dependencies]
[package.dependencies.importlib-metadata]
python = "<3.8"
version = ">=0.12"

[package.extras]
dev = ["pre-commit", "tox"]

[[package]]
category = "main"
description = "library with cross-python path, ini-parsing, io, code, log facilities"
name = "py"
optional = false
python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*"
version = "1.8.1"

[[package]]
category = "main"
description = "Python parsing module"
name = "pyparsing"
optional = false
python-versions = ">=2.6, !=3.0.*, !=3.1.*, !=3.2.*"
version = "2.4.7"

[[package]]
category = "main"
description = "pytest: simple powerful testing with Python"
name = "pytest"
optional = false
python-versions = ">=3.5"
version = "5.4.1"

[package.dependencies]
atomicwrites = ">=1.0"
attrs = ">=17.4.0"
colorama = "*"
more-itertools = ">=4.0.0"
packaging = "*"
pluggy = ">=0.12,<1.0"
py = ">=1.5.0"
wcwidth = "*"

[package.dependencies.importlib-metadata]
python = "<3.8"
version = ">=0.12"

[package.extras]
checkqa-mypy = ["mypy (v0.761)"]
testing = ["argcomplete", "hypothesis (>=3.56)", "mock", "nose", "requests", "xmlschema"]

[[package]]
category = "main"
description = "Python 2 and 3 compatibility utilities"
name = "six"
optional = false
python-versions = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*"
version = "1.14.0"

[[package]]
category = "main"
description = "Python Library for Tom's Obvious, Minimal Language"
develop = true
name = "toml"
optional = false
python-versions = ">=2.6, !=3.0.*, !=3.1.*, !=3.2.*"
version = "0.10.1"

[package.source]
reference = ""
type = "directory"
url = "../toml"

[[package]]
category = "main"
description = "Measures number of Terminal column cells of wide-character codes"
name = "wcwidth"
optional = false
python-versions = "*"
version = "0.1.9"

[[package]]
category = "main"
description = "Backport of pathlib-compatible object wrapper for zip files"
marker = "python_version < \"3.8\""
name = "zipp"
optional = false
python-versions = ">=3.6"
version = "3.1.0"

[package.extras]
docs = ["sphinx", "jaraco.packaging (>=3.2)", "rst.linker (>=1.9)"]
testing = ["jaraco.itertools", "func-timeout"]

[metadata]
content-hash = "25d64158a9a3895c840d0f902918635539bae5cebbaca1e831419a146b100349"
python-versions = "^3.7"

[metadata.files]
atomicwrites = [
    {file = "atomicwrites-1.3.0-py2.py3-none-any.whl", hash = "sha256:03472c30eb2c5d1ba9227e4c2ca66ab8287fbfbbda3888aa93dc2e28fc6811b4"},
    {file = "atomicwrites-1.3.0.tar.gz", hash = "sha256:75a9445bac02d8d058d5e1fe689654ba5a6556a1dfd8ce6ec55a0ed79866cfa6"},
]
attrs = [
    {file = "attrs-19.3.0-py2.py3-none-any.whl", hash = "sha256:08a96c641c3a74e44eb59afb61a24f2cb9f4d7188748e76ba4bb5edfa3cb7d1c"},
    {file = "attrs-19.3.0.tar.gz", hash = "sha256:f7b7ce16570fe9965acd6d30101a28f62fb4a7f9e926b3bbc9b61f8b04247e72"},
]
colorama = [
    {file = "colorama-0.4.3-py2.py3-none-any.whl", hash = "sha256:7d73d2a99753107a36ac6b455ee49046802e59d9d076ef8e47b61499fa29afff"},
    {file = "colorama-0.4.3.tar.gz", hash = "sha256:e96da0d330793e2cb9485e9ddfd918d456036c7149416295932478192f4436a1"},
]
importlib-metadata = [
    {file = "importlib_metadata-1.6.0-py2.py3-none-any.whl", hash = "sha256:2a688cbaa90e0cc587f1df48bdc97a6eadccdcd9c35fb3f976a09e3b5016d90f"},
    {file = "importlib_metadata-1.6.0.tar.gz", hash = "sha256:34513a8a0c4962bc66d35b359558fd8a5e10cd472d37aec5f66858addef32c1e"},
]
more-itertools = [
    {file = "more-itertools-8.2.0.tar.gz", hash = "sha256:b1ddb932186d8a6ac451e1d95844b382f55e12686d51ca0c68b6f61f2ab7a507"},
    {file = "more_itertools-8.2.0-py3-none-any.whl", hash = "sha256:5dd8bcf33e5f9513ffa06d5ad33d78f31e1931ac9a18f33d37e77a180d393a7c"},
]
packaging = [
    {file = "packaging-20.3-py2.py3-none-any.whl", hash = "sha256:82f77b9bee21c1bafbf35a84905d604d5d1223801d639cf3ed140bd651c08752"},
    {file = "packaging-20.3.tar.gz", hash = "sha256:3c292b474fda1671ec57d46d739d072bfd495a4f51ad01a055121d81e952b7a3"},
]
pluggy = [
    {file = "pluggy-0.13.1-py2.py3-none-any.whl", hash = "sha256:966c145cd83c96502c3c3868f50408687b38434af77734af1e9ca461a4081d2d"},
    {file = "pluggy-0.13.1.tar.gz", hash = "sha256:15b2acde666561e1298d71b523007ed7364de07029219b604cf808bfa1c765b0"},
]
py = [
    {file = "py-1.8.1-py2.py3-none-any.whl", hash = "sha256:c20fdd83a5dbc0af9efd622bee9a5564e278f6380fffcacc43ba6f43db2813b0"},
    {file = "py-1.8.1.tar.gz", hash = "sha256:5e27081401262157467ad6e7f851b7aa402c5852dbcb3dae06768434de5752aa"},
]
pyparsing = [
    {file = "pyparsing-2.4.7-py2.py3-none-any.whl", hash = "sha256:ef9d7589ef3c200abe66653d3f1ab1033c3c419ae9b9bdb1240a85b024efc88b"},
    {file = "pyparsing-2.4.7.tar.gz", hash = "sha256:c203ec8783bf771a155b207279b9bccb8dea02d8f0c9e5f8ead507bc3246ecc1"},
]
pytest = [
    {file = "pytest-5.4.1-py3-none-any.whl", hash = "sha256:0e5b30f5cb04e887b91b1ee519fa3d89049595f428c1db76e73bd7f17b09b172"},
    {file = "pytest-5.4.1.tar.gz", hash = "sha256:84dde37075b8805f3d1f392cc47e38a0e59518fb46a431cfdaf7cf1ce805f970"},
]
six = [
    {file = "six-1.14.0-py2.py3-none-any.whl", hash = "sha256:8f3cd2e254d8f793e7f3d6d9df77b92252b52637291d0f0da013c76ea2724b6c"},
    {file = "six-1.14.0.tar.gz", hash = "sha256:236bdbdce46e6e6a3d61a337c0f8b763ca1e8717c03b369e87a7ec7ce1319c0a"},
]
toml = []
wcwidth = [
    {file = "wcwidth-0.1.9-py2.py3-none-any.whl", hash = "sha256:cafe2186b3c009a04067022ce1dcd79cb38d8d65ee4f4791b8888d6599d1bbe1"},
    {file = "wcwidth-0.1.9.tar.gz", hash = "sha256:ee73862862a156bf77ff92b09034fc4825dd3af9cf81bc5b360668d425f3c5f1"},
]
zipp = [
    {file = "zipp-3.1.0-py3-none-any.whl", hash = "sha256:aa36550ff0c0b7ef7fa639055d797116ee891440eac1a56f378e2d3179e0320b"},
    {file = "zipp-3.1.0.tar.gz", hash = "sha256:c599e4d75c98f6798c509911d08a22e6c021d074469042177c8c86fb92eefd96"},
]

Final fix merged in #2361


Refactor Emformer RNNT recipes

Consolidates LibriSpeech and TED-LIUM Release 3 Emformer RNN-T training recipes in a single directory.

Do we want to keep the train_sentencepiece.py script in each sub directory? Otherwise they may ignore the important details that may impact the model performance.

Do we want to keep the train_sentencepiece.py script in each sub directory? Otherwise they may ignore the important details that may impact the model performance.

@nateanl The difference between librispeech model and tedluim model should be clearly outlined in the top level README. It can be as simple as the Sentence Piece model also needs to be different, for the detail please refer to the READMe in respective directory and delegate the detail to the sub directory READMEs.


Add backwards compatible DCS support for linux manufacturing packages

Also:

Bump package minor versions
Remove NewtonSoft from the DeviceAPITest package.

IP Regex fixed - good catch!


RESTEasy support

Hard to port in its current state as it dependends on Servlet API. @jamesnetherton mentioned that a rewrite of the Camel component would make porting easier.

RESTEasy was removed in Camel 4.x.


Error: Expecting a token named "token" but instead got: (...)

I am checking some things in the DB to allow or reject an oauth request (server side). Based on those, I return either the token to the client or an error message.
function s(response)
{
    $auth.setToken(response.data.token);

    // We got the token, rest of the code here
}

function f(errmsg)
{
    // No token, show error message to the user
}

$auth.authenticate(provider).then(s).catch(f);

Satellizer is ok with the token, but throws an error when any other thing is received, even if it's dealed with in the catch block.
How should the absence of a token in the server response be handled?

Ok, I wasn't setting the correct response headers. Returning a 403 with a {"error": "Detailed error message"} works as intended and Satellizer handles the error as expected.
Thank you for this useful library!


2.0.0

Coverage decreased (-38.73%) when pulling 3648d0c287bf26ab9f09e45e5f397bf856bbe83c on 2_0 into a75bc374faf2060794757ad460d3604d86bbf2e9 on master.

Coverage decreased (-24.94%) when pulling b492cef982738fcceadbcfc3e7db8208cb3d50c9 on 2_0 into a75bc374faf2060794757ad460d3604d86bbf2e9 on master.

Coverage decreased (-24.62%) when pulling 2074edd93b675e35f903bcc25ee879b0bcbb083a on 2_0 into a75bc374faf2060794757ad460d3604d86bbf2e9 on master.

Coverage decreased (-24.62%) when pulling 1016076d8aee5c089e0510025381ca5f1434c8de on 2_0 into a75bc374faf2060794757ad460d3604d86bbf2e9 on master.

Coverage decreased (-24.89%) when pulling d21ec4defd5423d88b602a83fb31894da9541e99 on 2_0 into a75bc374faf2060794757ad460d3604d86bbf2e9 on master.


Downgrade cartopy to 0.18.0 to fix CI errors

After cartopy's version 0.19.0 release, shape file errors occurred in two scripts, which are not occurring in local:

NCL_polyg_2: KeyError: "There is no item named 'ne_110m_admin_1_states_provinces_lakes_shp.cpg' in the archive"
NCL_WRF_zoom_1_2: KeyError: "There is no item named 'ne_50m_admin_1_states_provinces_shp.cpg' in the archive"

Above errors can be found in scheduled CI actions, e.g. see this one.
This PR downgrades cartopy to 0.18.0, and it seems to have worked.
It also fixes CI link in Badge, which was accidentally linking to geocat-comp's badge before.

While I don't like pinning versions, and we will want to investigate unpinning after about 6 months, I approve this for now.

Sounds good! I also opened an issue in cartopy repo, so if we can get a solution there, we could unpin this sooner.

@pilotchute You can see from the files changed that I now figured out the actual issue. So, I reverted cartopy version pinning. We are good with the newest 0.19.0 version. I will merge this version


Open With VSCODE prompt

Hi there
Whenever I click the ray link to open it in VSCODE, it always shows me this prompt.
I know it's vscode related, but is there a way to ALWAYS accept ?

Unfortunately we can't do anything about that, there seems to be an issue open at VSCode that addresses this: https://github.com/microsoft/vscode/issues/95670

Unfortunately we can't do anything about that, there seems to be an issue open at VSCode that addresses this: https://github.com/microsoft/vscode/issues/95670


Fix type check in ol/source/Tile

Remove extent because the parent Source class does not contain extent on its Options type or use options.extent in the constructor.

Can you also remove the extent in the typedef above? thanks

Done.


Yo tokens get encrypted now

the token grabbers wont work.  Because it works very well for me

It's only in the web app. When it gets encrypted the start of the token is a rickroll lmao


Scope changes unexpectedly when added to DOM before parser

http://plnkr.co/edit/i24uDLodMNI9CSwwN5BO?p=preview
Adding a .run(function(myFactory){}); causes factory-created scopes to be ignored on items added to the DOM.
I presume it's because the HTML parser reparents it.
Use Case: display library errors, which could occur before or after the parser. (Though in this case it's explicitly before, for simplicity).

I agree with @caitp


move from Kurtosis modules to Kurtosis packages

Kurtosis now creates Starlark packages that modify enclaves, this is the one for NEAR https://github.com/kurtosis-tech/near-package
This replaces https://github.com/kurtosis-tech/near-kurtosis-module

@bucanero At Kurtosis we've migrated towards packages over the older modules, can we get these docs in please?


Publish a new release with a less-wide range of rand versions?

Hi there --
We've been using rand_seeder for one of our projects at work, and it's been great, so thank you for maintaining it!
A problem we keep running into though is that we have both rand_core 0.5 and 0.6 in our dependency graph, but we want rand_seeder to only ever depend on 0.6. But often, cargo update (even if on completely unrelated dependencies) causes rand_seeder to "snap back" to rand_core 0.5.
This isn't really a rand_seeder issue -- it's a deficiency in Cargo. But I'm wondering if y'all would be open to publishing a new rand_seeder release (0.3.0 probably?) that only depends on rand_core 0.6.
Thanks!

Hi,
I'm glad to hear that you've found use of it.
Yes, we can do that. We should:

Bump the version to 0.3 and fix the rand_core version
Update the changelog (check history since last release; probably very little)

If you make a PR them I'm happy to push a new release. Alternatively, wait until we release the next rand_core (hopefully not long now).

@dhardy thanks! Just put up #10 for this.


Getting error

here is my yaml
- name: Build test report
uses<EMAIL_ADDRESS>id: allure
if: always()
with:
list_dirs: true
report_id: 'self-test'
gh_pages: 'gh-pages-dir'
report_dir: 'target/allure-results'
Error: no such file or directory: gh-pages-dir/allure-action/master/self-test/10172744184_1722393460519/history

@vladburian1 you may temporary delete file in your gh-pages branch allure-action/master/self-test/lastRun.json.
This issue happened because lastRun.json contains reference to a run that doesn't. I'll fix it later.


jenkinsx-test-1 to 0.0.1

Promote jenkinsx-test-1 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


bug: SingleLineThrowFixer - Handle throw expression inside block

closes https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/6648

Coverage remained the same at 92.913% when pulling<PHONE_NUMBER>46dc11add2fe6e2951344447c8fe66 on SpacePossum:bug/6648 into 531eaeb519104506ddb5f7ff8805a556569ff648 on FriendsOfPHP:master.


Add continuous variables to differential abundance

Requires microbiomeComputations feature-41-diff-abund-cont-vars
Requires veupathUtils add-bin-helpers
Updates the differential abundance api to accept the comparator as an object with a variable and two bin lists.
Notes:

I duplicated BinRange from the data service. There was LabeledRange in EdaCommon but that felt like more a data range. We should consolidate these in a future PR
I duplicated getRBinListAsString from the data service in OverlaySpecification.java. My duplicated code is again duplicated so my addition is utterly atrocious. I considered extending the BinRange class so i could add this as a method, but the best fix would add something to EdaCommon and then update the data service and this diff abund file. Anyways, given the timing and that this PR is at least functional and has api we desire, i think it's worth a review and then a discussion about if implementing an extended BinRange class is worth the effort now if we know we need to do some edacommon work within the next build or so.

Example post request
{
	"config": {
		"collectionVariable": {
			"variableId": "EUPATH_0009254",
			"entityId": "OBI_0002623"
		},
		"differentialAbundanceMethod": "DESeq",
		"comparator": {
			"variable": {
				"entityId": "EUPATH_0000096",
				"variableId": "EUPATH_0000639"
			},
			"groupA": [
				{"binLabel": "Antibiotics cohort"}
			],
			"groupB": [
				{"binLabel": "Three country cohort (Karelia)"},
				{"binLabel": "Type I Diabetes (T1D) cohort"}
			]
		}
	},
	"derivedVariables": [],
	"filters": [],
	"studyId": "DiabImmune-1"
}

I duplicated BinRange from the data service. There was LabeledRange in EdaCommon but that felt like more a data range. We should consolidate these in a future PR

LabeledRange is the future. you should use that.
We should also add to EdaCommon a util getRBinListAsString that takes List and returns the string R needs. we can also override that to take List, List and List etc..

From slack: the LabeledRange in eda common won't be out until the release most likely, so we need to add a local version.
i'll do that first thing tomorrow!


upgrade Some Thing :

Upgrade Target JVM version to 1.8
Upgrade SDK Compile and Target to 29
Upgrade Kotlin Version to 1.3.41
Upgrade Dependencies

@googlebot I signed it!


edited the ATOM section of the editor_plugins.md file

Done

Done

Did you push your changes? I don't see them here.