Include screenshots

I don't follow where to click.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 46d0432d-8bdf-ae6a-000c-4da12913b759
Version Independent ID: e14583a3-c977-106e-0211-a516734e3965
Content: Deploy templates using the portal in Azure Stack
Content Source: articles/azure-stack/user/azure-stack-deploy-template-portal.md
Service: azure-stack
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@atpalmer Hi and thanks for reaching out. Can you tell us which part of the procedure you're having an issue with? If you go to the portal you should see the specified options on the left side of the screen. It's a short procedure so we decided not to clutter it with screen shots.

@sethmanheim It would be even less cluttered if you left off the text description of the steps. Are you trying to make your documentation uncluttered, or are you trying to make it helpful?

@atpalmer Thank you for your very polite feedback -- we will consider adding more screenshots to make this topic more helpful.

@sethmanheim I wasn't being polite, obviously, but I am pretty annoyed with how you answered. This is UI documentation, and there are a million places to click in the Azure UI. Adding screenshots seems like a very small and very appropriate ask.

I have added screen shots for each of the steps, and this should be published live by 10 AM tomorrow (May 7), US Pacific Time. Thank you again for the contribution. #please-close

@sethmanheim Thanks. This does look a lot better, and it is enlightening. Nobody I work with actually has the "Custom" option appear.
We all see essentially this:

(The "See all" option also does not take me to a page with a "Custom" option, and searching for "Custom" on the following page also does not return a relevant result.)
Please always take into consideration differences different users encounter, and consider making further improvements with that in mind.
The reason I was annoyed earlier is that I don't think you should be resisting making your documentation better. In my case, this page was essentially useless. I believe it is in your interest to take feedback and improve rather than push back and suggest there is something wrong with me for not figuring something out.
I actually still don't know why my UI looks different, but I did learn that the UI can display different options for different users, so your updates were helpful in the sense that I now know why I can't follow these instructions.
Thank you again for the updates.

@atpalmer My last comment on this subject: I don't see any place in my earlier comment where I suggested there was something wrong with you. I thought I was expressing my professional opinion. I actually do not agree that this makes the topic better -- there are far too many screen shots for such a short procedure (with many opportunities for those shots to go outdated as the portal UI changes/updates). If this short procedure is too hard to follow without screen shots, then we need to improve the portal UI (and I have passed this feedback to the engineering team).
That said, it's good to hear this kind of feedback and to know that more screenshots are helpful. It helps in future doc planning. However, due to frequent updates, it is completely expected that what you see in the screen shots may not be exactly what you see in your portal UI.
Thank you again for reaching out and I hope you continue to do so.

@sethmanheim But, as you can see, a screenshot you posted today, and a screenshot I posted today look different. So, that's not an out-of-date issue. It's an issue with the documentation incompletely accounting for users who see my UI. (I am not alone.)
Moreover, it's actually for this same reason that the screenshots continue to be valuable if they go out of date: it's possible to see that the instructions are referring to an outdated UI, and the user can comfortably disregard them rather than being confused. It clearly does not help anyone to try to follow directions for an outdated UI. I do hope that you reconsider your opinion and the implications of your opinion on confused, frustrated, annoyed users.
Thank you again for today's updates.

Ha! I too found this page because I'm trying to figure out how to deploy from a template. I too don't see the 'Custom' choice in the portal, but only see what's in atpalmer's screenshot from 7 May above. Not very helpful..


Check out macro_reading_session

Macro_reading_session attempts to convert all user_reading_sessions for the same article-user relation to a list of sessions. We should use this to get a better representation of user_reading_sessions, since duplicate versions of the same session are retrieved now.
TODO:

Import to playground
Replace query for duration-graph with output from macro_reading_session
Does it make a difference?

The only thing that macro_reading_session does is accumulate sessions for the same user-article pair. We already do this in our function for retrieving the user_reading_sessions. We could use macro_reading_session so we do not have the same logic in multiple places, but that would require to rewrite the logic, and therefore we are not going to do it now. We can do this later if needed.


3 ➡ 4

Forward-port ign-gazebo3 to ign-gazebo4. See comparison:
https://github.com/ignitionrobotics/ign-gazebo/compare/ign-gazebo4...ign-gazebo3
Needs this PR to be merged and released first: https://github.com/ignitionrobotics/ign-physics/pull/129

ign-physics 3.1.0 is out, this should be unblocked.

@osrf-jenkins run tests please

Reverting the changes in test/integration/diff_drive_system.cc from #314 fixes the test for me locally.

Thanks for figuring this out, @azeey. The test was failing locally for me and I was thinking I had the wrong DART version.
Reverted in 0ab6d35 and confirmed that the test is fixed for me locally :+1:


no support for xmlns namespace attributes

There is no support for xmlns namespace attrs, only xlink. Both should be supported.
Current xlink implementation could give issues as well.
React supports both.
Is this supported at all in the JSX plugin? I couldn't see the code for it.

With latest jsx plugin you can type: xlink:href   and you get xlink:href no need for xlinkHref thing anymore.

Sounds great. Except I still have some issues...
e.g. xlink:acturate is not supported by the current jsx plugin because of
this :. This was fixed before.
I can't find support for xml attributes aka xml:lang, xml:space, xml:show
It was an issue ticket regardign this for Inferno 5.x where this was not
supported for JSX. And React has it's own workaround for this that is not
supported in current Master.
So there are a lot of issues still here.
On Sun, Mar 27, 2016 at 2:52 PM, Sampo Kivistö<EMAIL_ADDRESS>wrote:

With latest jsx plugin you can type: xlink:href and you get xlink:href no
need for xlinkHref thing anymore.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/trueadm/inferno/issues/156#issuecomment-202002275

Out of topic I should also mention xmlns attribute. A common attribute for
setting SVG namespaces. It existed on Inferno 5.x, but not in Inferno 6.x.
Same with the 'is' attribugte for type extensions.
On Sun, Mar 27, 2016 at 3:37 PM, Kenny Flashlight<EMAIL_ADDRESS>wrote:

Sounds great. Except I still have some issues...
e.g. xlink:acturate is not supported by the current jsx plugin because of
this :. This was fixed before.
I can't find support for xml attributes aka xml:lang, xml:space, xml:show
It was an issue ticket regardign this for Inferno 5.x where this was not
supported for JSX. And React has it's own workaround for this that is not
supported in current Master.
So there are a lot of issues still here.
On Sun, Mar 27, 2016 at 2:52 PM, Sampo Kivistö<EMAIL_ADDRESS>wrote:

With latest jsx plugin you can type: xlink:href and you get xlink:href no
need for xlinkHref thing anymore.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/trueadm/inferno/issues/156#issuecomment-202002275

@Kflash xml:lang, xml:space, xml:show are all supported by the Babel plugin. These should be easy enough to add to Inferno.
@Havunen we could look at add XLink support to Babel and Inferno. https://www.w3.org/TR/xlink11/

xml:lang, xml:space, xml:show are now supported in latest dev.

@trueadm @havunen is xmlns and is attribute supported now? If not. When will it be implemented?

What about removing the "auto adding" namespace for example:
<svg>
   <use xlink:href="#tag"></use>
</svg>

should output exactly same instead putting namespace there. It works perfectly without namespace so why add it?


Corrupted Pytorch model?

hI,
The Pytorch model on dropbox: https://www.dropbox.com/s/p457h2ifi6v1qdz/twostream_rgb.pth.tar?dl=1, seems being corrupted:
I have tried to unzip the file on ubuntu with: tar xvf twostream_rgb.pth.tar:
tar: This does not look like a tar archive
tar: Skipping to next header
tar: Exiting with failure status due to previous errors
Could you help to fix this problem?

The .pth.tar was actually generated by pytorch directly. Does torch.load('filename.pth.tar') work?

Yes, it works. Thank you for your assistance.


Bug: Mentions of main branch need to be changed to beta

Describe the bug
Project is now using beta branch as default. There are various mentions in the docs to use the now outdated main branch. Some main mentions may be out of scope and need verification from maintainers
Steps to reproduce
Go to Line 45 in introduction-to-contribution.md you will see main referenced.
There are a number of references to the main branch by searching the repo, want to be clear what needs to be changed and what needs to be kept.
Mentions:

resolve-merge-conflicts.md: Changing main involves changing shell commands.

Verify with maintainer

setting-up-a-new-repository.md: Changing from main would include changing screenshots as well. This page is targeted to maintainers for new Open Sauced related changes, may be out of scope of current issue.

Verification needed

semantic-release.md: Documentation on npm package, may be out of scope.

Verification needed.

Affected services
docs.opensauced.pizza
Platforms
Desktop, Mobile, Tablet
Browsers
Chrome, Firefox
Environment
Production
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

.take


There should be an admin validation before a user is effectively registered

We basically added authentication to prevent unknown people to access users' information. But at this point you can just register and have access to the full application. À suggest that we implement an admin validation of newly registered users.

[x] database
[x] authentication + access (based on validity of user)
[x] admin endpoints
[ ] admin page

We can make it easy (just display list of pending registration requests with accept reject button). For the delay, there might be one indeed but I don't think it is a problem as most people will already be registered in our case.
I don't think protecting events is enough, as we have potentially sensitive data (like "ludothèque") outside of events.

and 857b793f.
Add two new admin endpoints:

for listing users and their status: GET /admin/users
for changing the status of a user: PUT /admin/user

@waliens How to make a user admin? Should we set that manually? Then how can UI know when it's an admin? Can we maybe get it from the login response?

Yes, it is mostly manual for now. I have deliberatedly hidden the information when returning user description, but I can return it with the login and get current user requests

Depends. When I said "manually", I meant in the DB.
If we need an admin page, we should (currently) display it in the User's page, in an "Admin" tab, only if User is admin. Correct? In which case, UI needs to know if the user is admin :)
What do you think?

That is what I meant too. 'admin' status has to be set directly in the DB (or with the sql script, which defines 3 admins).
For the admin page, what you propose would be the cleanest option. But I guess we could be dirtier to avoid losing time here. We could just have a page at an url like http://hostname/admin that you could access whatever your status (if you are not an admin, all the requests would fail anyway) that would fetch the list of users and associate "accept" and "reject" buttons with people that have not been accepted yet.

I said above: "I don't think protecting events is enough, as we have potentially sensitive data (like 'ludothèque') outside of events."
So I went for an app-wide mechanism.

Oops, didn't remember that!

Gotta say I didn't put so much effort in the design, but it does the trick :)

Great ! Already calling the api ? Not that if 'validated' is null, then it means that the user is neither accepted nor refused. Otherwise it is either true or false (with obvious meaning.

Oh, I just realised why there's both null and false ;) Let me change that

Better? :)


Entrypoints for pandas >=0.25

Doesn't yet return proper help or work with df.plot.scatter() style calls
EDIT: it does work with df.plot.scatter() style calls, they just have the same requirements as the df.plot versions (aka plot.scatter requires x and y to be set explicitly whereas hvplot does not).
Closes #277

I consider this done. There are some outstanding issues to be resolved on the pandas side. But this chunk of work should probably get in sooner rather than later.

Note that in this PR, by, groupby, and hover_cols will only work if the columns that they reference are in x or y. See https://github.com/pandas-dev/pandas/pull/28647 for the full description.

To Do:

[ ] make sure that there are no references to patch in the docs

I am fairly confident that the remaining error is unrelated.

I think this is ready to merge


Installation via apt issue: public key not available

Description
I am trying to install CouchDB via APT on a new hosted Debian 10 installation.
When I run sudo apt update, I get the following error:
$ sudo apt update
Hit:1 http://mirrors.linode.com/debian buster InRelease
Hit:2 http://mirrors.linode.com/debian-security buster/updates InRelease
Hit:3 http://mirrors.linode.com/debian buster-updates InRelease
Get:4 https://apache.jfrog.io/artifactory/couchdb-deb buster InRelease [5,151 B]
Err:4 https://apache.jfrog.io/artifactory/couchdb-deb buster InRelease
The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 0EE62FB37A00258D
Reading package lists... Done
W: GPG error: https://apache.jfrog.io/artifactory/couchdb-deb buster InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 0EE62FB37A00258D
E: The repository 'https://apache.jfrog.io/artifactory/couchdb-deb buster InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
Steps to Reproduce
I run the following commands as shown on the CouchDB Installation page .
sudo apt update && sudo apt install -y curl apt-transport-https gnupg
curl https://couchdb.apache.org/repo/keys.asc | gpg --dearmor | sudo tee /usr/share/keyrings/couchdb-archive-keyring.gpg >/dev/null 2>&1
source /etc/os-release
echo "deb [signed-by=/usr/share/keyrings/couchdb-archive-keyring.gpg] https://apache.jfrog.io/artifactory/couchdb-deb/ ${VERSION_CODENAME} main" \     | sudo tee /etc/apt/sources.list.d/couchdb.list >/dev/null
Expected Behaviour
I expect sudo apt update to work.
Your Environment
I am running Debian 10 on a fresh install

Please try re-running curl https://couchdb.apache.org/repo/keys.asc | gpg --dearmor | sudo tee /usr/share/keyrings/couchdb-archive-keyring.gpg (without the >/dev/null 2>&1) and look for any error.
After that, try again a apt update.

I just took a brand new Debian Buster install and can confirm the instructions work, from scratch. There must be something wrong with your install.
Converting to a peer-support topic as the installation system does seem to work correctly.


Write Computed Identifier manuscript

The sha512t24u digest convention and statistics have been written up with Andreas Prlić in a paper on SeqRepo. Submission seems possible this week.


WIP: testing action with ref to app image

FYI. I will merge this because of the kyverno config in the Platform points to main branch, if any issue occurs I will revert this


Texture.cpp: use COLOR_BGR2BGRA instead of CV_BGR2BGRA

I was compiling 4dface and figured out that while compiling if you change to COLOR_BGR2BGRA, we can compile using latest version of opencv.
best

Thank you for the report!
Indeed I think you're right - I will include this the next time I'm going to push changes.
Thanks again :)

Lets close the issue then?

Let's leave this open to track it, since there is no PR yet.

Hi,
My opencv version is the 4.0.0 and I had the same issue when I run "make" after cmake of source.
So I replaced CV_BGR2BGRA by 0 but I've got 3 others errors :
CMakeFiles/4dface.dir/apps/4dface.cpp.o  : In function « cv::Mat::Mat(int, int, int, void*, unsigned long) [clone .constprop.5619] » : 4dface.cpp:(.text+0x6318) : undefined reference to « cv::Mat::updateContinuityFlag() »
CMakeFiles/4dface.dir/apps/4dface.cpp.o : In function « rcr::HogTransform::operator()(cv::Mat, unsigned long, int) » : 4dface.cpp (.text._ZN3rcr12HogTransformclEN2cv3MatEmi[ZN3rcr12HogTransformclEN2cv3MatEmi]+0xf9e) : undefined reference to « cv::Mat::updateContinuityFlag() »
CMakeFiles/4dface.dir/apps/4dface.cpp.o : Dans la fonction « main » :
4dface.cpp:(.text.startup+0x14bb) : undefined reference to « cv::rectangle(cv::InputOutputArray const&, cv::Rect, cv::Scalar const&, int, int, int) »
However, cv::Mat::updateContinuityFlag() is still in the current version of opencv  https://docs.opencv.org/master/d3/d63/classcv_1_1Mat.html and idem for rectangle  https://docs.opencv.org/master/d6/d6e/group__imgproc__draw.html#gac865734d137287c0afb7682ff7b3db23

Perhaps you need to compile opencv again! This only means that the function is not found in the library you compiled. Do you have two version of opencv installed?

@valbi I don't think this source code is using cv::Mat::updateContinuityFlag() anywhere, I haven't seen that function before. I think you're just not linking OpenCV correctly or have some problem locally. Shouldn't have anything to do with the 4dface code.

Ok, 4dface works.
After re-compile opencv4, i've got the error about OpenCV_haarcascades_DIR, like in the Build & run readme of 4dface. I never have this error at the first cmake, so opencv was not well compiled
I think when i follow build directions, i execute sudo apt-get install gcc-7 g++-7 libboost-all-dev libeigen3-dev libopencv-dev opencv-data with opencv already build and install from git source code. I should have removed libopencv-dev and opencv-data.
Thank you @waqarsqureshi  and @patrikhuber.


[BEAM-11207] Adding PipelineResult to session runner.

Unit tests were failing because Execute could no longer be used with RegisterRunner. This should fix that.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @kamilwu
CC: @lostluck

OK, that's concerning since precommits and so forth were passing, which means tests weren't running. Thanks for fixing.


[UI?][i18n] Enable horizontal scroll for code blocks on PyPI

Describe the bug

I noticed that the monotype text in a .pypirc example overflows the right border.
I suppose it's because the translation string is longer than the original English one.
The problem of text not fitting in the UI is common
Expected behavior

I think that a horizontal scroll bar appearing in such code blocks would handle this case very well. The translators aren't immediately exposed to where and how the translation strings will be rendered. So it is unlikely for this to be fixed during the translation-time, only post-merge/build/deploy.
To Reproduce

It's on https://pypi.org/manage/account/token/.
My Platform

N/A
Additional context

The problem manifests in English as well:

The content is located in this template:
https://github.com/pypi/warehouse/blob/1387d3a1212cb56feb114611cf44739f63707eb2/warehouse/templates/manage/account/token.html#L98-L111
The width of the overall content column is set in SCSS:
https://github.com/pypi/warehouse/blob/1387d3a1212cb56feb114611cf44739f63707eb2/warehouse/static/sass/layout-helpers/_containers.scss#L28-L29
https://github.com/pypi/warehouse/blob/1387d3a1212cb56feb114611cf44739f63707eb2/warehouse/static/sass/settings/_grid.scss#L17
I don't think it's likely to change the global width setting to accommodate this. Rather, it's more likely to explore adding the horizontal scroll to the specific code block SCSS https://github.com/pypi/warehouse/blob/1387d3a1212cb56feb114611cf44739f63707eb2/warehouse/static/sass/blocks/_code-block.scss


[ENHANCEMENT] Search Functionality

Hello,
When we writing something in input field ,it will automatic trigger filter so, there is no use of  Search button  & Along with this, I'll also like to improve the design of the search input field.
Thanks

Assigned

Bhaiya, This issue is already fixed. please, closed this issue.


No HIL_ACTUATOR_CONTROLS with PixRacer

I am developing a custom simulator with HITL. Everything is working well when I use PX4 with Pixhawck (2.4.8) hardware. I can send sensor and command messages to the controller and I can receive HIL_ACTUATOR_CONTROLS, but when I put the same PX4 firmware (1.7.0 and above) on PixRacer I do not receive the HIL_ACTUATOR_CONTROLS message. I am receiving all other messages (HEARTBEAT, EXTENDED_SYS_STATE, etc.) and the controller is responding to my Arming commands but there is no HIL_ACTUATOR_CONTROLS.
HIL_MODE is enabled. I am using the HIL Quadcopter X config. COM_RC_IN_MODE is set to "Joystick/No RC Checks". NAV_DLL_ACT is set to "Disabled".
Any Help ? Thank you.

May I ask you how did you get it running on pixhawk 2.4.8 ? I also develop custom simulator with HITL, but I am not able to get any output actuators. I already read code of HIL_ACTUATOR_CONTROLS, but I didn't found any bug which would cause this kind of problem. Interesting is, that you have problem with different hardware even when data comes from actuator_outputs topic.

Maybe I found problem. Look at nuttx_px4fmu-v4_default.cmake and uncomment pwm_out_sim driver. I had this problem and this was that problem

Thank for your reply. If you mean the line in this file (https://github.com/PX4/Firmware/blob/master/cmake/configs/nuttx_px4fmu-v4_default.cmake ), it is already uncommented.
I have commented sensors reset as well following the recommandations here (https://github.com/PX4/Firmware/issues/5651) but still have the same problem.
For Pixhawk 2.4.8 (FMU V2) you need to choose a HIl config (e.i. HIL Quadcopter X). Make sure HIL is enabled. Start sending "Hearbeat" and "Arm" command. You will start receiving HIL_ACTUATOR_CONTROLS as soon as the controller is armed.
Hope it will help.

I have it already working. I found out, that there was commented pwm_out_sim in nuttx cmake file for FMU V2.

Glad to hear that. I confirm it is commented for FMU-V2 but it is working for me. However it is uncommmented for FMU-V4 (Pixracer) and it is not working !


Update Cloudformation Template, replace EC2 Launch Config with Launch Template

Issue #, if available:
AWS::AutoScaling::LaunchConfiguration is deprecated in favor of AWS::EC2::LaunchTemplate
See also: https://docs.aws.amazon.com/autoscaling/ec2/userguide/migrate-to-launch-templates.html
Description of changes:
Replace AWS::AutoScaling::LaunchConfiguration with AWS::EC2::LaunchTemplate
Testing:

Created all resources in new Cloudformation stack
https://docs.aws.amazon.com/xray/latest/devguide/scorekeep-tutorial.html#xray-gettingstarted-deploy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I was able to create the stack and use the application.
Stack deletion failed after trying to delete the AWS::ECS::Service resource which timed out after 30 minutes.
Have you been able to delete?

Stack deletion failed after trying to delete the AWS::ECS::Service resource which timed out after 30 minutes.
Have you been able to delete?

To fix this:

In ECS console, go to Amazon Elastic Container Service > Clusters > scorekeep-cluster > Infrastructure
Select the instance, and select the deregister button.
Retry delete Cloudformation Stack

This is an existing issue (before sample app broke) where Cloudformation (or CDK) cannot delete an ECS service due to the instance not being drained.

See https://github.com/aws-samples/aws-scalable-big-blue-button-example/issues/79
https://github.com/aws/aws-cdk/issues/14732
https://github.com/aws/aws-cdk/issues/18179

We need to update AWS docs to ask customers to manually drain or deregister their ECS ec2 instance first before deleting the stack.

OK not a great experience for your customers trying to figure that out. Suggest following this example and using a Lambda function to clean up the compute resources.
https://github.com/aws/aws-cdk/issues/14732#issuecomment-1874273556


Fixed line color and pie chart tooltip

Jittering of Tooltip in Pie Chart in Chrome caused by use of mouse event methods needs to be addressed.


RYA-534 Upgrade to RDF4J 3.2 and RYA-496 Upgrading to Accumulo 1.9.3

Description
I've upgrade the RDF4J dependencies to the latest. I've upgraded other dependencies including Accumulo.
This PR needs to be merged before https://github.com/apache/rya/pull/316
Tests
Yes, tests have been updates where required by dependency changes.
Links
RYA-534
RYA-496
Checklist

[ ] Code Review
[ ] Squash Commits

People To Reivew
@adinancr
@jdasch
@amihalik

This PR has been open for a while already - is there any possibility that this could be merged soon (once the conflicts are resolved)? This is needed for making Rya compatible with Java 11 (see https://github.com/apache/accumulo/pull/942 and https://issues.apache.org/jira/browse/RYA-471)

Changes made

It looks like org.locationtech.spatial4j  has been refactored.  I renamed from com.spatial4j  to  org.locationtech.spatial4j  but it seems there is more changes.  Can you take a look?
 `package org.locationtech.spatial4j.core.context does not exist`

Here is more:
[ERROR] /home/vagrant/rya/extras/rya.pcj.fluo/rya.pcj.functions.geo/src/main/java/org/eclipse/rdf4j/query/algebra/evaluation/function/geosp
arql/SpatialSupportInitializer.java:[23,47] package org.locationtech.spatial4j.core.context does not exist
[ERROR] /home/vagrant/rya/extras/rya.pcj.fluo/rya.pcj.functions.geo/src/main/java/org/eclipse/rdf4j/query/algebra/evaluation/function/geosp
arql/SpatialSupportInitializer.java:[24,51] package org.locationtech.spatial4j.core.context.jts does not exist
[ERROR] /home/vagrant/rya/extras/rya.pcj.fluo/rya.pcj.functions.geo/src/main/java/org/eclipse/rdf4j/query/algebra/evaluation/function/geosp
arql/SpatialSupportInitializer.java:[25,45] package org.locationtech.spatial4j.core.shape does not exist
[ERROR] /home/vagrant/rya/extras/rya.pcj.fluo/rya.pcj.functions.geo/src/main/java/org/eclipse/rdf4j/query/algebra/evaluation/function/geosparql/SpatialSupportInitializer.java:[35,15] cannot find symbol
  symbol:   class SpatialContext
  location: class org.eclipse.rdf4j.query.algebra.evaluation.function.geosparql.SpatialSupportInitializer

I'll see what I can do. I appears I didn't build the project with the optional components.

It looks like org.locationtech.spatial4j has been refactored. I renamed from com.spatial4j to org.locationtech.spatial4j but it seems there is more changes. Can you take a look?
This should all be fixed now.

It looks like org.locationtech.spatial4j has been refactored. I renamed from com.spatial4j to org.locationtech.spatial4j but it seems there is more changes. Can you take a look?
This should all be fixed now.


Can't accept code changes in new three-way merge view without using mouse, and mouse is not obvious

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.70.1
OS Version: Darwin x64 21.6.0

The new three-way-merge editor is cool when you know how to use it, but It took me a LOOONG time to figure out how to use it, and in the end I had to go watch the release notes from June to figure it out.  There's yellow boxes on the left, and yellow boxes on the right, and a preview of the merged code below:

How do we accept one side or the other?  Here's things I tried:

Right clicking on a yellow box does not offer an "Accept this" or "Accept theirs" or "Accept yours".
Double clicking on a yellow box does nothing.
Copy-pasting text out of a yellow box at the top into the box in the preview pane at the bottom will make it identical to one side or the other, but then clicking "Accept Merge" will tell you there are unresolved merge conflicts, so that doesn't appear to work.
There are some controls in the upper right corner to go to the next conflict or the previous conflict, but nothing to accept one conflict or the other.  (Also, if you click on a flie that needs a merge in the  "Source Control" tab on the left, and then try to click on "Go to next conflict", it won't work - you need to click somewhere inside the three-way-merge window to give it focus before they will work.)

In the command pallet, there are "Merge Conflict: Accept Current", or "Merge Conflict: Accept Incoming", and some other variations on this theme.  I'm not sure which is the "incoming" and which is the "current", since they are labeled "Theirs" and "Yours", but evidently it doesn't matter, because if I try any of these I get the error "Editor cursor is not within a merge conflict".  I've tried with my cursor in the yellow box in all three panes, and none of them work.  Since these don't work, there appear to be no keyboard shortcuts for the new merge view, and no way to assign any.

It seems the only way to accept code changes appears to be to click on the black-on-black checkbox to the left of the yellow box, in the margin, which (perhaps because of my color scheme) I didn't even realize was there.
To sum up:

Copy/pasting text from "Theirs" or "Yours" should probably mark an item resolved.
"Merge Conflict: Accept ..." commands in command pallete should work and they don't.
"Merge Conflict: Accept Theirs" and "Merge Conflict: Accept Yours" should be added to the command pallete.
"Go to next/previous conflict" buttons should always work, and they don't.
Perhaps some kind of tutorial popup the first time you open the three-way-merge tool?  Or some way of highlighting the invisible checkboxes?

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Issues still exist in 1.70.2.

It's a pain for me too, I loved this previous menu. Actually, it was the main reason why I used VS Code.

I also had trouble finding the accept yours and accept theirs buttons, and came by googling here before finally finding them. I agree that the colours are not the best ones. The two accept buttons are the two main actions of a merging process, but now they are just part of the background. I'd say the action buttons to accept should be at least as prominent as the boxes that highlight the differing sections.

I also had this issue: the checkboxes are invisible with some color themes (Monokai variants, in my case).
However, I'm also finding the "Go to next/previous conflict" buttons only ever go to one specific conflict and skip all the others, even after the conflict is resolved, and when I open a file in the normal editor to try and see what's left unresolved, the areas where unresolved conflicts should be are just blank.

@jwalton Thank you very much for your detailed feedback! And sorry for only replying now, this issue didn't make it to me immediately.

Or some way of highlighting the invisible checkboxes?

I can see how hard it is to discover the checkboxes. We only tested a couple of themes and because I added the checkboxes there I didn't realize how hard it is to find them when you don't know that they are there.
We made the highlighting much stronger now:

Perhaps some kind of tutorial popup the first time you open the three-way-merge tool?

That's a good idea! I created #159159 for this.

"Go to next/previous conflict" buttons should always work, and they don't.

We improved that, there was a focus bug.

Copy/pasting text from "Theirs" or "Yours" should probably mark an item resolved.

That's a good idea! I created #159155 for this.

"Merge Conflict: Accept ..." commands in command pallete should work and they don't.

Unfortunately the "Merge Conflict: Accept ..." commands only work for conflict markers...
There are specific commands for the merge editor that should work:

I created #159156 to improve this situation.

"Merge Conflict: Accept Theirs" and "Merge Conflict: Accept Yours" should be added to the command pallete.

Aren't they already included in the command pallete?

The above changes will definitely help. Just as an idea, could the button made to include a check mark icon, so that it would hint about the functionality even further?

Just as an idea, could the button be made to include a check mark icon

Which button? You mean the command title in the command palette?

Just as an idea, could the button be made to include a check mark icon

Which button? You mean the command title in the command palette?

I meant the button in the middle of the bracket on the left margin of the yours and theirs view.

Very hard to see on dark theme (vscode v1.70.2)!
Thanks for the improvement efforts.
Had a merge which for the same line master had a new func and me another (named differently).
Both changes started deselected so the lower merge pane was showing none of the changes. And the upper panes were showing their own particular changes, but the checkmark and lines had so little contrast (Dark+ theme) I didn't even registered them visually.
Agree with Ariandr, I really like the simplicity from the previous menu on top of the change, I understood it right away after switching to vscode without any previous experience with the IDE, and you have the whole context right there.
Having to move my eyes constantly between panes to validate things are happening felt annoying, I much rather prefer the old way, or use the toggle-code buttons but like Meld or P4Merge do (same pane).
Luckily I googled and ended up here!

Absolutely needs the ability to maintain the old right-click on the region and Accept/Reject etc.
Merging conflicts is stressful enough without suddenly facing a change to everything about the process.
The checkbox in the middle of the region that I had to end up here even to realise it existed? In one file, I am staring at a conflict in that is 14k lines long.
I cannot for the life of me scroll down to the "middle".
This has turned a merge that should have taken me at most an hour into something that could take half a day to complete and be confident about.
Facing that, I'm closing vscode and reaching for another tool.

Guys, I found a solution!
You can just disable the new merge conflicts editor and use the old UI, if you prefer it.
The name of the setting is git.mergeEditor. Just open Preferences and search for it, and then untick the checkbox.

Hi @hediet
I would recommend adding the hint that users can disable the new editor and use the old UI.
I don't remember the last time when the old process didn't help me. So, I think many users would actually prefer it and they should know they can turn off the new editor.

Just adding my voice to the 'check boxes are invisible' is a real issue.
And that right clicking on a line to accept a version should also be re-added.

Well, it seems my pain comes from Microsoft itself.. It should be re-added for sure.

Hey @hediet, this issue might need further attention.
@jwalton, you can help us out by closing this issue if the problem no longer exists, or adding more information.

We changed the UI of the merge editor significantly. I don't think this issue is still relevant, this closing it.


19c pluggable db import/export appears broken by data_pump_dir

As you can see from the below the presence of the data_pump_dir made in the default install appears to stop any export/import of pluggable databases even when i make and specify a different directory from the default.
docker run --name oracle19 container-registry.oracle.com/database/enterprise:<IP_ADDRESS>

wait for DATABASE IS READY TO USE!
docker exec -ti oracle19 bash
./setPassword.sh oracle
bash-4.2$ expdp system/oracle@orclpdb1

Export: Release <IP_ADDRESS>.0 - Production on Fri Aug 26 10:17:54 2022
Version <IP_ADDRESS>.0

Copyright (c) 1982, 2019, Oracle and/or its affiliates.  All rights reserved.

Connected to: Oracle Database 19c Enterprise Edition Release <IP_ADDRESS>.0 - Production
ORA-39006: internal error
ORA-39065: unexpected master process exception in DISPATCH
ORA-12801: error signaled in parallel query server P002
ORA-06512: at "SYS.KUPF$FILE", line 4809
ORA-06512: at "SYS.KUPF$FILE", line 4783
ORA-65100: missing or invalid path prefix - /opt/oracle/admin/ORCLCDB/dpdump/E6FC41838DEA1227E053020011AC3834
ORA-06512: at "SYS.KUPF$FILE", line 4771
ORA-06512: at "SYS.KUPM$MCP", line 4422

ORA-39097: Data Pump job encountered unexpected error -12801

bash-4.2$ sqlplus / as sysdba
SQL> ALTER SESSION SET CONTAINER=orclpdb1;
SQL> CREATE DIRECTORY DUMP_DIR AS '/opt/oracle/admin/ORCLCDB/dpdump/';
SQL> GRANT READ, WRITE ON DIRECTORY DUMP_DIR TO SYSTEM;
SQL> exit;

bash-4.2$ expdp system/oracle@orclpdb1 directory=dump_dir

Export: Release <IP_ADDRESS>.0 - Production on Fri Aug 26 11:04:38 2022
Version <IP_ADDRESS>.0

Copyright (c) 1982, 2019, Oracle and/or its affiliates.  All rights reserved.

Connected to: Oracle Database 19c Enterprise Edition Release <IP_ADDRESS>.0 - Production
ORA-39006: internal error
ORA-39065: unexpected master process exception in DISPATCH
ORA-12801: error signaled in parallel query server P002
ORA-06512: at "SYS.KUPF$FILE", line 4809
ORA-06512: at "SYS.KUPF$FILE", line 4783
ORA-65100: missing or invalid path prefix - /opt/oracle/admin/ORCLCDB/dpdump/E6FC41838DEA1227E053020011AC3834
ORA-06512: at "SYS.KUPF$FILE", line 4771
ORA-06512: at "SYS.KUPM$MCP", line 4422

ORA-39097: Data Pump job encountered unexpected error -12801

bash-4.2$ sqlplus / as sysdba
SQL> drop directory data_pump_dir;
SQL> exit;

bash-4.2$ expdp system/oracle@orclpdb1 directory=dump_dir

Export: Release <IP_ADDRESS>.0 - Production on Fri Aug 26 11:08:01 2022
Version <IP_ADDRESS>.0

Copyright (c) 1982, 2019, Oracle and/or its affiliates.  All rights reserved.

Connected to: Oracle Database 19c Enterprise Edition Release <IP_ADDRESS>.0 - Production
Starting "SYSTEM"."SYS_EXPORT_SCHEMA_01":  system/********@orclpdb1 directory=dump_dir
Processing object type SCHEMA_EXPORT/TABLE/TABLE_DATA
Processing object type SCHEMA_EXPORT/TABLE/INDEX/STATISTICS/INDEX_STATISTICS
Processing object type SCHEMA_EXPORT/TABLE/STATISTICS/TABLE_STATISTICS
Processing object type SCHEMA_EXPORT/DEFAULT_ROLE
Processing object type SCHEMA_EXPORT/PRE_SCHEMA/PROCACT_SCHEMA
Processing object type SCHEMA_EXPORT/TABLE/TABLE
Processing object type SCHEMA_EXPORT/TABLE/COMMENT
Processing object type SCHEMA_EXPORT/TABLE/INDEX/INDEX
Master table "SYSTEM"."SYS_EXPORT_SCHEMA_01" successfully loaded/unloaded
******************************************************************************
Dump file set for SYSTEM.SYS_EXPORT_SCHEMA_01 is:
  /opt/oracle/admin/ORCLCDB/dpdump/expdat.dmp
Job "SYSTEM"."SYS_EXPORT_SCHEMA_01" successfully completed at Fri Aug 26 11:09:03 2022 elapsed 0 00:00:59

# now it works

🚨🚨🚨Caveat: I don't have a clue about anything oracle 🚨🚨🚨
so its more likely that I'm doing this entirely wrong, but I don't imagine I'll be the first to come across this

@chrisns I am unable to reproduce this.
bash-4.2$ expdp system/oracle@ORCLPDB1

Export: Release <IP_ADDRESS>.0 - Production on Mon Sep 5 11:14:47 2022
Version <IP_ADDRESS>.0

Copyright (c) 1982, 2019, Oracle and/or its affiliates.  All rights reserved.

 Can you please retry it ? If the problem is reproducible, please share more about your environment etc.

https://support.oracle.com/knowledge/Oracle Database Products/2672864_1.html

My issue with:
ORA-39097: Data Pump job encountered unexpected error -12801

problem was in btrfs with overlay2 storage driver. It seems as unsupported configuration. I have also tried to remove all from /var/lib/docker directory and apply btrfs storage driver, but problem persisted.
Workaround for me:
Creating new ext4 partition for /var/lib/docker mountpoint with default storage driver (removed line "storage-driver": "btrfs", from /etc/docker/daemon.json file; beware, just changing key to something else, does not work) solved issue.
NOTE: I have download all my images and lost all my containers three times through process, so be warned.

I have the exact same issue ORA-65100: missing or invalid path prefix, using btrfs driver in podman


Does the "don't show again" action on the loose file notification need to be followed by another notification?

Testing https://github.com/microsoft/vscode/issues/125855
I opened a non-workspace file and started a preview. I got the loose file notification ✅
Then I got this notification:

Is this a pattern we follow elsewhere? @isidorn you might know this.

Please no multiple notifications :)
There should be another way to achieve this.

I can just omit the second notification if that's better UX

@andreamah I am not 100% sure what is the scenario here, but in general in VS Code we try not to notify users that something got saved, or there has been a modification in settings. Most of the time this just works automatic and users should not be notified. So removing the notification seems like the way to go here.


[Feature] Add a Critical Confirm bonus

I was attempting to set up the Samurai class feature Weapon Expertise which grants a bonus to confirm critical attacks to the chosen weapon type and I noticed there appears to be no option for this. Unless I missed a way to achieve this.
For now I am adding that manually in the attack entry for the character.

This should be doable. I'll add it to my list


amplify mock function causes undefined error

How did you install the Amplify CLI?
npm install -g @aws-amplify/cli@latest
If applicable, what version of Node.js are you using?
v16.11.1
Amplify CLI Version
10.6.1
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
Deleting backend environments in order to recreate them for testing purposes.
Describe the bug
When running amplify mock function, I get this response:

Cannot read property 'providerController' of undefined

Expected behavior
Expected a list of lambda functions to be provided, to select which lambda function to mock.
Reproduction steps
Unable to reproduce in an empty directory, however, in my current project it occurs simply by:

amplify mock function

The error occurs directly after the command, no lambda functions are listed as would be expected.
Project Identifier
No response
Log output

2023-01-12T01:46:26.232Z|info : amplify function mock
2023-01-12T01:46:26.296Z|info : amplify-cli-core.banner-message/index.ts.fetch banner messages from https://aws-amplify.github.io/amplify-cli/banner-message.json({}

Additional information

Every newly created environment gets this error.
Old environments do not seem to get this error.
Cloning old and working environments does not seem to resolve the error.

Before submitting, please confirm:

[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

Hey @benharvie :wave: thanks for raising this! I was not able to reproduce this using the provided steps using Amplify CLI 10.6.1, nor when using 10.0.0. Can you try running the same command using the --debug flag? Additionally, can you post the project ID output from amplify diagnose --send-report?

Hey @josefaidt:) running the same command with --debug throws the same error with no additional information. I also attempted to send a report but the report seems to fail to send, the output is below:

amplify diagnose --send-report
Learn more at https://docs.amplify.aws/cli/reference/diagnose/
✅ Report saved: /var/folders/91/xq122gcs2tn6rtjyc2nn9qw40000gn/T/huntr/report-1673542751449.zip
⠏ Sending zip
✖ Sending zip

Hey @benharvie thanks for clarifying despite the rough experience! Can you walk me through how the function was added and how the project is set up? Was this project recently cloned from git?

Deleting backend environments in order to recreate them for testing purposes.

Can you elaborate on this note? Were backend environments deleted from the AWS Amplify console or via the CLI?
As a parting question, would you mind sending a zip archive of your amplify/ directory to<EMAIL_ADDRESS>If so, please be sure to omit any sensitive information

That's ok, thanks for the help, it's much appreciated! The function was added via. amplify add function, we have been using amplify for some time and this is the first time this has occurred, we haven't done anything out of the ordinary as far as I am aware.
Backend environments were removed via. the AWS Amplify console.
I will send over the .zip created from the amplify diagnose --send-report command manually to the email provided.
Thanks again

Hi, I just wanted to check in and ensure the email was received successfully.
Thanks

Hey @benharvie apologies for the delay here!! Yes, we received your zip archive, thank you for sending that over. Looking into this a bit further it appears to be erroring here https://github.com/aws-amplify/amplify-cli/blob/dev/packages/amplify-category-function/src/index.ts#L295
Where it is looking to get the Lambda service configuration when iterating over your functions key in amplify/backend/amplify-meta.json. For example, I'm able to reproduce this if I manually change the service value in this file:
"a117541ef2c4d5": {
  "build": true,
  "providerPlugin": "awscloudformation",
- "service": "Lambda"
+ "service": "Lambdafake"
}

➜  amplify mock function
Cannot read property 'providerController' of undefined

Despite this, I do not see the discrepancy in your amplify-meta.json file. Do you still experience this issue after running amplify env checkout <current-env-name> (which will trigger a refresh on this meta file)? Did this start occurring after deleting the Amplify envs in the AWS Console or after merging a new Function from another env/branch?

Hey @benharvie are you still experiencing this?

This issue has fixed itself over time, I no longer experience this error:)

Hey @benharvie thanks for clarifying and glad to hear this is resolved for you! I'll close this issue for now but if something comes up please don't hesitate to reach out!


feat: add browsers list, linting plugin and Docs section with supported browsers

Relates to #83

Checklist

[x] The added / edited code has been documented with JSDoc
[x] A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

Preview of browser section on Onyx Docs:

With the current approach, only JavaScript features are linted, right? So if we use CSS features that are e.g. not supported in firefox, we will not know

we could try out https://stylelint.io/ to lint our CSS, will create a follow up ticket for that


Update OmniSharp and Mono

This PR probably doesn't need a review. I read through the changelog a second time to see if there were any glaring errors but didn't spot anything.


Typo fix

@ngiroux : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ngiroux - thank you for catching this!


Address-based comments

comments right now are tied to functions which is fine for instructions that are in a function (and important for binaries that might have multiple architectures or functions overlapping), but not fine for either instructions not associated with a function (when they exist), or for data which should also allow comments.
Implement a generic comment API off of the binaryview that allows setting comments on the default architecture which is the most common use case (but the set_comment on the function class will remain for instances where a file has multiple architectures that potentially overlap)

This was added to dev and is exposed by the python api as bv.set_comment_at, bv.get_comment_at, and bv.comments. Keep in mind these aren't the same as function-level comments, which are still the preferred way of annotating code.


[tmxparser] Build error

Host Environment

OS: [e.g. Windows/Linux etc...]
Compiler: revision

To Reproduce
Steps to reproduce the behavior:
./vcpkg install xxxx
Failure logs
Error: Building package tmxparser:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with git pull and .\vcpkg update.
Then check for known issues at:
https://github.com/microsoft/vcpkg/issues?q=is%3Aissue+is%3Aopen+in%3Atitle+tmxparser
You can submit a new issue at:
https://github.com/microsoft/vcpkg/issues/new?template=report-package-build-failure.md&title=[tmxparser]+Build+error
including:
package: tmxparser[core]:x64-windows -> 2.1.0#6
vcpkg-tool version: 2021-12-09-724cea8b33cbf06c645f5095fa29773697da9761
vcpkg-scripts version: 77967a622 2021-12-09 (11 hours ago)
Additionally, attach any relevant sections from the log files above.
Additional context
I already tried to use 'git pull' and '.\vcpkg update'

Please provide the failure log mentioned in the output message first.
Thanks.


Extend symmetrizer

I extended symmetrize_tensor to make it possible to symmetrize literally any tensor.

Summary by CodeRabbit

New Features

Enhanced tensor symmetrization with new and improved operations.

Tests

Updated test cases for symmetry operations to ensure accuracy and reliability.

This new version is a lot faster thanks to the help from folks from StackOverflow.

? It’s all covered

? It’s all covered

The Github action coverage/coveralls for the commit Format black reports the coverage decreased, most likely because you deleted the _SymmetrizeTensor and the corresponding tests.


Regions cache (sqlite3) is not thread-safe

When accessing regions cache from multiple threads (dwave.cloud.regions.get_regions), the following errors have been reported:
  ...
  File "/.../lib/python3.10/site-packages/dwave/cloud/regions.py", line 37, in <module>
    @cached.ondisk(maxage=REGIONS_CACHE_MAXAGE, key='cache_key', bucket='regions')
  File "/.../lib/python3.10/site-packages/dwave/cloud/utils.py", line 642, in ondisk
    cache = diskcache.Cache(disk=diskcache.JSONDisk, directory=directory,
  File "/.../lib/python3.10/site-packages/diskcache/core.py", line 500, in _init
    self.reset(key, value)
  File "/.../lib/python3.10/site-packages/diskcache/core.py", line 2409, in reset
    sql_retry(statement, (value, key))
  File "/.../lib/python3.10/site-packages/diskcache/core.py", line 666, in _execute_with_retry
    return sql(statement, args, *kwargs)
sqlite3.DatabaseError: database disk image is malformed

or
  ...
  File "/.../lib/python3.10/site-packages/dwave/cloud/regions.py", line 37, in <module>
    @cached.ondisk(maxage=_REGIONS_CACHE_MAXAGE, key='cache_key', bucket='regions')
  File "/.../lib/python3.10/site-packages/dwave/cloud/utils.py", line 642, in ondisk
    cache = diskcache.Cache(disk=diskcache.JSONDisk, directory=directory,
  File "/.../lib/python3.10/site-packages/diskcache/core.py", line 499, in __init__
    sql(query, (key, value))
  File "/.../lib/python3.10/site-packages/diskcache/core.py", line 666, in _execute_with_retry
    return sql(statement, *args, **kwargs)
sqlite3.OperationalError: database is locked

sqlite3.threadsafety in Python:

“Threads may share the module, but not connections.”

diskcache claims to be thread-safe and process-safe, but there's this.

Starting with Python 3.11, sqlite3.threadsafety attribute has been fixed to dynamically (correctly) reflect tread-safety of the underlying sqlite3 C module (a compile-time setting).
By default sqlite3 module is compiled in "serialized mode", meaning that "SQLite can be safely used by multiple threads with no restriction," and in particular:

Threads may share the module, connections and cursors

Given the above, I'll close this issue, and refer users to:

Upgrade to Python 3.11+
Check that their SQLite distribution has sqlite3.threadsafety set to 3 / serialized mode.

We can re-open upon reproduction in SQLite serialized mode. (Or open issues on sqlite/diskcache repos).


Added support for SameSite Cookie option

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no

Tests pass?
yes

Fixed issues
-

Although this is a new feature (and requires PHP >= 7.3) I think it's important to include it on the Yii 2.0 branch since it's a big security enhancement.
For more info please see https://www.owasp.org/index.php/SameSite, https://www.php.net/manual/en/function.setcookie.php and https://www.php.net/manual/en/function.session-set-cookie-params.php

@samdark Feedback committed (extra description for SAME_SITE_* constants added, they might need some review to check if the description is clear enough).
@Thoulah Yes exclusively was indeed the correct word.

@rhertogh seems code does not work with PHP 5.6.

@samdark Found the problem. I expected php 5.6 never to reach the ?? operator since it's inside the version check. But it fails at parse time. Rewrote the line (locally tested on php 7.3). Tests are running, let's see if 5.6 accepts it now.

Merged. Thank you!

Tested master branch on PHP 7.3 both Lax and Strict policies working in Google Chrome, Firefox, Microsoft Internet Explorer and Edge.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/215 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 2241708:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/sql-database-engine.png
:white_check_mark:Succeeded

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Remove parens around AwaitExpression in ternary

Fixes #313

Thanks :)

Why not remove the old option now? It is still early, and people were warned about breakage...

I'm not sure I follow your comment. This is not a breaking change.
The stance on prettier on parenthesis is that we should only output the ones that are necessary for your code to parse the same way as inputted.
In this case, we did not need this parenthesis to disambiguate so we shouldn't output it.
Is there something I missed?

Maybe you are talking about another issue with --flow-parser. If that's the case, there are currently a bunch of editor integrations that exist, it's annoying to have to track them down and ask them to update the option right now.
The cost of supporting the previous option is very low and if we stop documenting the old option, no new plugin is going to use it and the old ones are going to update at some point and we can just drop that option later which only involves removing a few lines of code.
I feel like it's a better way of handling out breaking changes. It's a small amount of work for the maintainer but no user gets frustrated by having something that breaks under them. Even if it's alpha, it's still a really shitty experience.


Thor LUKS encryption key stored on disk?

Hey, this is not really an issue, more of a discussion, but since they are not enabled I post it here.
In the Thor config host/thor/disks.nix the 4TB data drive is configured with a LUKS encryption and the password to decrypt is stored in /tmp
content = {
  type = "luks";
  name = "data";

  settings = {
  # Make sure there is no trailing newline in keyfile if used for interactive unlock.
  #  Use `echo -n "password" > /tmp/secret.key`
  keyFile = "/tmp/data.keyfile";
  allowDiscards = true;
  };

  [...]
};

As I understand it the /tmp folder is stored on disk by default and only gets wiped on boot (I didn't see any changes to that in your configuration).
So if a malicious actor could get access to your device, cut the power and then read the disk from a different system without booting Thor, they would have access to your decrypt key and therefore the data on the 4TB data drive.
I think the alternative would be to store the key in RAM so it gets wiped when the power is cut rather than on boot (and maybe disable the swap file?).
So either putting in the password manually on every reboot with a ssh connection.
Or configure /tmp to be stored in RAM rather than on disk.
What do you think? Did I miss something?
Besides that, awesome config :star2:  I love to copy-paste from it :heart_hands:

Ah nice. More stuff to look into, Thanks!


Using a Specified .crt File and --ssl-insecure Appears to Result in Cipher Failures

Problem Description
Hello! I am fairly new to using this tool so I apologize if I am just missing something.
When using the following command:
mitmdump --listen-host <IP_ADDRESS> --listen-port 8888 --certs FiddlerRoot.crt -vvv --flow-detail 3 --ssl-insecure --set ssl_version_server=TLSv1 --set ssl_version_client=TLSv1
I consistently get TLS exceptions with "no shared cipher" or "no cipher match" like the following:

The service I am trying to connect to is blanked out on purpose. However, normal services that I try to connect to also show the same error message. I am using a certificate generated from the "Fiddler" program because that's what the services I'm interacting with are expecting. I will explain how to generate the fiddler certificate in steps to reproduce.
I am passing the --ssl-insecure parameter because I get a TLS error related to SNI otherwise, which has already been covered in this issue
Here is a screen capture from Fiddler which shows the TLS handshake being successful for hopefully extra context:

I have also tried using the "ciphers_client" and "ciphers_server" options to explicitly set various ciphers. Here is a list of the ciphers that I tried setting and their open_ssl equivalents, given the handshake information from Fiddler. I used the open_ssl syntax when passing to mitmdump.
[C02F]	TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256      ECDHE-RSA-AES128-GCM-SHA256

[C027]	TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256       ECDHE-RSA-AES128-SHA256

[009C]	TLS_RSA_WITH_AES_128_GCM_SHA256                  AES128-GCM-SHA256

[003C]	TLS_RSA_WITH_AES_128_CBC_SHA256                   AES128-SHA256

[002F]	TLS_RSA_WITH_AES_128_CBC_SHA                        AES128-SHA

The following ciphers in fiddler do not appear to have a corresponding SSL definition, so I did not try these.
[000A]	SSL_RSA_WITH_3DES_EDE_SHA     ????
[C013]	TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA   ?????

I am using a Windows 10 machine with the Linux subsystem and I have replicated this with the Windows executables, the latest release of the virtual environment, and the binaries on the linux subsystem. I will give more detailed info in the last section.
Steps to reproduce the behavior:

Download and install Fiddler Classic https://www.telerik.com/download/fiddler and enable HTTPS decryption.

For more information see here: https://docs.telerik.com/fiddler/Configure-Fiddler/Tasks/DecryptHTTPS

In the HTTPS tab click on Actions -> Export Root Certificate to Desktop

Convert the resulting ".cer" file into a ".crt" file using openssl. openssl x509 -inform DER -in certificate.cer -out certificate.crt

Use that new certificate to run the following command: mitmdump --listen-host <IP_ADDRESS> --listen-port 8888 --certs FiddlerRoot.crt -vvv --flow-detail 3 --ssl-insecure --set ssl_version_server=TLSv1 --set ssl_version_client=TLSv1`

Generate some traffic and observe the TLS handshake errors due to missing or no cipher.

System Information
This was one Windows 10 system, but multiple implementations of MITMProxy were tried:
Linux Subsystem on Windows:
Mitmproxy: 4.0.4
Python:    3.7.3
OpenSSL:   OpenSSL 1.1.1d  10 Sep 2019
Platform:  Linux-4.4.0-18362-Microsoft-x86_64-with-debian-10.4
Binary Install on Windows:
Mitmproxy: 5.1.1 binary
Python:    3.7.6
OpenSSL:   OpenSSL 1.1.1f  31 Mar 2020
Platform:  Windows-10-10.0.18362-SP0
Local Python Virtual Environment on Windows:
Mitmproxy: 6.0.0.dev (+4, commit 46fbba6)
Python:    3.7.4
OpenSSL:   OpenSSL 1.1.1g  21 Apr 2020
Platform:  Windows-10-10.0.18362-SP0
Thank you for taking the time to read this! I'm sorry it is so much but I just do not know where to turn. I hope that this can be turned into a win for open source. If we find this solution I can replace Fiddler for this use case. I am happy and able to contribute to the code if I can have some aid in where / how to debug and fix this issue.

I have found an alternative solution for this. It does not involve something with mitmproxy but an in-house solution. I apologize if I wasted anyone's time.


Add v3 to v4 plugin migration page

Why are you removing the updating to 3.x guide? I think it can still be helpful and we are keeping the older upgrade guides for capacitor, so I think we should keep the old upgrade guides for plugins too.

That's true, definitely should keep those around. The PR makes it look like I deleted it entirely but I only removed from the current v4 Capacitor docs root level. Essentially it's replaced with the new v4 page (docs/updating/plugins/4-0). The 3.x guide still lives under /docs/v3/updating/plugins/3-0.

You have missed the podspec change, which is the most important one related to the iOS deployment target as the podspec is what's used when users install the plugin in their project ionic-team/create-capacitor-plugin@03027bf#diff-dc8721a872ae0dcc9e412a0a0b13bc684f6b8de82abee362ce965cf6d216f2d4L14

OK, updated the PR. see if it's correct now.

OK, added v3 back in. Here's the root (v4) docs now:


Transaction Confirm needs cancel (it hangs forever if the witness node is not running)

Duplicate of #218


fix for loop

fix #66

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   51.24%   51.24%
=======================================
  Files          61       61
  Lines        6007     6007
=======================================
  Hits         3078     3078
  Misses       2590     2590
  Partials      339      339

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3074bf...e87061b. Read the comment docs.


Fix compile error on Linux

error: format not a string literal and no format arguments
[-Werror=format-security]

Hi Gordon, Thanks for the pull request.  apache:master is locked for release, we've switched to apache:develop as the main branch for development.  That gets regularly merged into master.


Flattr counter is broken

This relates to the website rather than to the app.
The counter for Flattr, and perhaps some other services, is broken, stuck at 0: https://hovancik.net/stretchly/ .

Hi, maybe it takes some processing on the flattr side? When I login to flattr I do not see any flattrs as well.
Many thanks if you contributed!

I guess the counter increases at the end of the month, when payments are made out. ¯_(ツ)_/¯
We'll see.

My balance was increases ;]
I guess counter is broken on flattr side.


ComfyScript: Invalid config

Is this a warning or an important error I need to handle? For a simple workflow it didn't cause any problem. Is there a way to debug it origin, any help please? Thank you!

It's the node Scribble_PiDiNet_Preprocessor has some unusual config and can't be parsed by ComfyScript. It will not be avaliable in ComfyScript but other nodes should work fine.

So the node's config is wrong, even ComfyUI can't recognize it correctly. I've made a PR to fix it: https://github.com/Fannovel16/comfyui_controlnet_aux/pull/477

Now my fix PR has been merged. You can update comfyui_controlnet_aux to solve this issue.


DPL-870 Research DPL-812 (Transfer PBMC bank data to BioResource team)

Description
Time-box to 2 days.
Research some of the unknowns around the following story:

https://github.com/sanger/sequencescape/issues/3850

Some unknowns are:

Where should this functionality sit? (Sequencescape, Limber, query against MLWH or SS db?)
What will the UX be?

See the Outstanding questions and Additional Information sections on the linked story for a bit more information.
Who the primary contacts are for this work
Katy

Discussed in a developer meeting on 18th Sep 2023.
There will be a single source plate in PBMC plate to Tube Rack (LRC Bank Seq and LRC Bank Spare) transfer. The PBMC plate will be used as a reference to collect and report info about the tubes.
If there is another plate after the PBMC plate, it will be used as a reference instead.
If we make additional Spare tubes later, data about them will be reported separately on the PBMC plate.
The preferred option to store tube rack barcodes is using custom metadata rather than the tube rack model in SS for MVP. If it is necessary to use the model, we can do data migrations later.
Tube racks have etched barcodes; we cannot stick a new barcode every time they are used.
A CSV file download will be added to LRC PBMC Bank for MVP. See Download LCR Bank Data CSV file link on the mock-up image. The download will include all Seq and Spare children of the plate.
It is likely that users will have the barcode of the plate recorded and the page can be found easily.
It is possible to access the data using the physical tube barcode, by creating a parent link in the tube page to the PBMC plate page later.
If user wants to do a search by tube rack barcode, Sequencescape Custom Metadata Search can be used. However, it will return tubes for that tube rack only. See Custom Metadata Search Example image.
Download LCR Bank Data CSV Mock-up:

Custom Metadata Search Example:


enhancement: compatibility with Fedora 32 Beta

terminus seems to depend on gnome-python2-gnomekeyring, which seems not to be there in Fedora 32 beta (yet?)
I open this issue as a reminder .. maybe this has to be solved in Fedora, I don't know yet.

Isnt the problem that it depends on python2 and fedora is pretty much python3 now. I dont see why this should be fixed in fedora?

Same on openSUSE where Python 2 is not supported anymore on modern distribution,
Terminus should find alternative that don't need some old python2 lib as gnome-python2-gnomekeyring


Date Picker don't mark form as dirty

Select one ...  (check one with "x")
[x ] bug
[ ] feature request
[ ] enhancement

Expected behavior
When you select a date in the date picker, the form is marked as dirty.
Actual behavior
When you select a date in the date picker, the form is not marked as dirty.
Reproduction of behavior
Click the date picker icon to open the component and select a date.
The form is marked as dirty only when typing the date with the keyboard
https://stackblitz.com/edit/clarity-light-theme-v11-6quune
Environment details

Angular version: 5.2.1

Clarity version: 0.11.16

OS and version:

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

@williangd: Thanks for reporting this issue. We will take a look and get back to you.

Yup, that should do it. Same with markAsTouched()


Store secret keys in environment variables

Use this package for local development: https://pub.dev/packages/dotenv

PR was accepted


New shortcut ad

Why would you want to merge personal settings into the master branch of this repo?

This is a good question!


threatStatus rare

Information for threatStatus can be found in european_red_list_species.
This contains the value rare. This is not a IUCN Threat Status Vocabulary.
Suggestions? I guess we could just not map rare?

Even if not an official term, I would map to rare, cf.: https://github.com/inbo/eurobutt-checklist/blob/6c199e56902574d18ed765a836d62fdfd7ab6da5/src/dwc_mapping.Rmd#L390

Agree, this is an expression of the abundance, not the degree of threat.
Some rare things are not threatened.
Quentin
On Fri, 8 Feb 2019 at 16:30, Peter Desmet<EMAIL_ADDRESS>wrote:

Even if not an official term, I would map to rare, cf.:
https://github.com/inbo/eurobutt-checklist/blob/6c199e56902574d18ed765a836d62fdfd7ab6da5/src/dwc_mapping.Rmd#L390
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/trias-project/bryophytes-belgium-checklist/issues/4#issuecomment-461840340,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFRj0LGZv6-TAFkwSbAkvzTanwCx_Ortks5vLZgBgaJpZM4av5xi
.

great, let's do that!


Slack notifications does not work with MicroG

Slack notification doesn't work on my device, I have la test GMS core and set up config as explain in this issue : https://github.com/microg/android_packages_apps_GmsCore/issues/1027

Some more information :
ROM : https://lineage.microg.org/ (build : 27/03/2020)
Device : One Plus 3
I have missed a thing ?
Thanks

This is fixed due to merging #1069 in 5146559f89cdaaa05e7e6a5f2bb41988a4e4677b

While we wait for an update, you can manually roll back to Slack version 30010363 using AuroraStore, register with GCM (using notification troubleshooting), and then update Slack to latest.


add autocorrelated process error back in

removing autocorrelated process (pc) error stan models as of 10/14/16 == #264 == 1f2a4d9c39ea0ddfcfa881fb17cf1f1a76a08e7f to simplify and because we may not need pc for the first paper. someday i'd like to add it back in.

i think this is done/successful. won't be the fastest-running models, but they should work just as well as they did before. still not planning to use these models in the first few papers, though - too slow to converge.


Authentication is required

I updated my app on Google Play with latest OpenIAB version (<IP_ADDRESS>, native jar).
Since then, the customers cannot buy my in-app product.
The error is: "Authentication is required. You need to sign into your Google Account."
There is also this error in the logs:
BasicNetwork.performRequest: Unexpected response code 403 for https://android.clients.google.com/fdfe/preparePurchase
Any help is very welcome!

Hello @Z6P0
can't reproduce with our example
could you please share a link to your app?
Thank you,
AK

Hello,
The problem solved itself after 2-3 days, I don't know why. There was probably a glitch on the Play Store servers, I reported it to Google but never get any answer...

Ok, thank you


Added apiserver_terminated_watchers_total metric to grafana

What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds apiserver_terminated_watchers_total metric to grafana.
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:
NONE

/approve

/lgtm


replace SimpleX  C++ MPI bindings with C calls

this is a bit tedious, and causes divergence from mainline simplex; an alternative would be to include a 1 header file implementation, but afaik this doesn't exist

There is no mainline simplex version anymore except this one and the one in Arepo (I asked Jan Pieter about that a little while ago), so we can do as we see fit.

#542 fixes this

fixed by #542


add browser support back in

This is a much more simple implementation than the previous one.
Just 1 file authored in TS, so updates are simple and we get type checking.
The only downside is it dosen't support deep imports, but the 1.0 release broke those and I wouldn't consider it part of the public api anyway.
Closes https://github.com/RobinBuschmann/sequelize-typescript/issues/668

@Toxicable released under<EMAIL_ADDRESS>Can you confirm that it works as intended?

@RobinBuschmann Yup, looks like it's working to me!


dukpt AES not working

In dukpt.lib.js there is a check for KSN being 20 bytes regardless of encryption mode. If this check is updated to 24 to allow for the larger AES KSN then the the code gets further but the generated IPEK is incorrect. What testing was done for dukpt AES?

I have the same issue trying to get AES256 DUKPT working. At first glance it looks like the _createIPEK function is still using DES to generate the IPEK. So it looks like the implementation is incomplete.
Did you end up finding a solution @hominator ?

Same issue here, trying to use DUKPT 2017 which allows for a 24 byte KSN but I get an exception.

Thank you for reporting the issue. Unfortunately, I won't be able to look at this issue anytime soon. I'm looking for maintainers for the repository, and happy to review any PRs.