Attachment view shows image as left aligned. It should be horizontally centered - Reported by: @Prashant Mangukiya

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Run web or desktop version
View already uploaded landscape image from chat list.
OR upload any landscape image (i.e. Choose image whose width larger than height)
Attachment view shows image as left aligned (if landscape image)  it should be horizontally centre.
Expected Result:
Attachment view should be centered, same as vertical or square image
Actual Result:
Attachment view shows image as left aligned. This issue happen with landscape image only (i.e. width larger than height). For vertical or square image it shows as expected i.e. image shows horizontally centred.
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
Desktop App

**Version Number:1.1.19-0
**Reproducible in staging?:Y
**Reproducible in production?:Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/145664495-7a371179-dbf1-4f5a-a26c-608ce0b6b23c.mp4
Expensify/Expensify Issue URL:
**Issue reported by:@Prashant Mangukiya
**Slack conversation:https://expensify.slack.com/archives/C01GTK53T8Q/p1639119563497100
View all open jobs on GitHub

Triggered auto assignment to @CortneyOfstad (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mvtglobally thanks, please correct my Github user name as  @PrashantMangukiya for reported by. (remove space between first and last name)

I've had this happen to me, agree it's a bug and looks like it's an external one too.

Triggered auto assignment to @SofiedeVreese (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Posted on Upwork: https://www.upwork.com/jobs/~01ed008999babd5b97

Triggered auto assignment to @parasharrajat (Exported)

Triggered auto assignment to @iwiznia (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

I was able to reproduce this issue in v1.1.20-2, Web
Proposal
src/styles/StyleUtils.js
    // If image is bigger than container size, display full image in the screen with scaled size (fit by container size) and position absolute.
    // top, left offset should be different when displaying long or wide image.
-    const scaledTop = imgHeight > imgWidth ? 0 : `${Math.max((containerHeight - (imgHeight * zoomScale)) / 2, 0)}px`;
-    const scaledLeft = imgWidth > imgHeight ? 0 : `${Math.max((containerWidth - (imgWidth * zoomScale)) / 2, 0)}px`;
+    const scaledTop = `${Math.max((containerHeight - (imgHeight * zoomScale)) / 2, 0)}px`;
+    const scaledLeft = `${Math.max((containerWidth - (imgWidth * zoomScale)) / 2, 0)}px`;

hmmmm, would that break what was fixed in this PR? Also, is this bug a regression from that PR?

No, it will break the fixes in the mentioned PR.

ok cool, I think the proposal looks good, do you agree @parasharrajat ?

Ok. It seems like a regression. Analyzing the regression root before looking into proposals.

Ok, @iwiznia This issue is a regression caused by https://github.com/Expensify/App/pull/6535 and as the original issue linked with that PR is still active this should be solved by the author of that PR.
@railway17 could you please take a look?
Thanks for the proposal @wenge8n .

In my testing video and previous staging testings, it was passed.
But, why such issue was displayed accidently?
Is it not a merging issue?
Anyway, let me take a look.

I just reverted your PR and it was fixed.

Hi @parasharrajat If this issue is a regression, in this case, I will not be paid for my proposal ?

Hi @wenge8n, Usually regression is solved by the PR author who caused it and he won't be paid for that. And if the issue is solved by an internal team member using your proposal then you are paid for that. But here it is not the case.
Let me know if you have any more concerns. But I would suggest you to look into other open jobs, There are quite a few.

@parasharrajat considering this is a regression, should we close this GH or do you prefer waiting until the regression is fixed via the PR? Either way I'll remove the Upwork posting!

Best would be to take down the Upwork job and let it close via PR.

Too easy- I've removed the Upwork listing and the help wanted label now 👍

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.22-0 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/6774

If no regressions arise, payment will be issued on 2021-12-28. :confetti_ball:

This was a regression so no payment needed, apart from the contributor who kindly reported the regression (@PrashantMangukiya ).

Actually, considering this was a regression, I don't think we have to wait to pay Prashant for reporting the regression. Do you agree @parasharrajat ?

I don't have much knowledge of this topic but I think all reports are paid.

Oh yep we'll pay for reporting, that's without a doubt, but I'm more wondering about the timing. Typically we'd pay out reporters together with the payment of contributors fixing the issue. But in this case it's a regression so there's no payment of the latter. So I don't think there's a reason to wait with this particular payment until the regression fix is deployed, the reporting payment shouldn't hinge on the fixing of the regression.

But how would you make sure that regression is fixed so we wait for 7 days after PROD deploy.

But how would you make sure that regression is fixed so we wait for 7 days after PROD deploy.
I know we tested it before merge and QA passed it but it doesn't hurt to wait for last 7 days regression test.
It is good to pass all three checks.
Test before merge.
QA passed.
7 days hold. This is important to capture any unwanted side-effects.

But the above process is applicable when we pay a contributor fixing a bug or regression, we wait for it to pass all tests before paying out.
But in this specific case, we're paying for the reporting of the bug, not the fixing. And the reporting of the bug should be compensated regardless of the outcome of the regression.. right?

Hmm. I don't have a strong argument to hold the payment. Either way is fine. As per my understanding reporting bonus is released when issue is resolved and we consider a issue to be completed when it pass all of above mentioned three stages. And if issue is resolved internally then we can pay them without hold but this issue is resolved externally. I think you can release the payment, this going to be eventually closed.

Created an Upwork post to pay out the reporting bonus and invited @PrashantMangukiya to this Upwork post.
Once that's done, we can just let this GH auto-close via the regression fix' PR.

@SofiedeVreese accepted Upwork invitation. Thank you.

Perfect thank you @PrashantMangukiya I've just completed the payment for the reporting bonus. Thanks again!

I think this has been deployed already, closing out


Not able to find modules/types for tsx files after recent updates.

VSCode Version: 1.7.1
OS Version: Windows
Typescript version: 2.0.6
Steps to Reproduce:

We have a project for which VS code was working perfectly fine ( before some updates). Here is the tsconfig.json ( this is there just to support vscode, we a separate build system)

{
    "compilerOptions": {
        "module": "amd",
        "target": "es5",
        "jsx": "react"

    },
    "exclude": [
        "node_modules"
    ]

}

The project structure looks something like this
Foo/**
VSS/
        @types/**
         .....
tsconfig.json

VSS folder here is a hard link.

I have two files in Foo i.e Temp.ts and Temp1.tsx .

Any hints on resolving this ? I can help you with more info if required. I cannot share the code since this is Microsoft Internal (VSTS), but we can have a skype session if you want.
Also any hints on debugging this on my own ?

Related issue in Typescript https://github.com/Microsoft/TypeScript/issues/10346

@harshil93 thanks for opening this issue. Sorry this seems to have fallen through the cracks on my end. I know you can't share the code but can you share a simplified repo where the problem exists? This will help us in diagnosing and debugging.
Can you also try using the latest bits with the insiders build here?

@waderyan Hi Wade, since you are in DEVDIV, you will have access to the source code at mseng.visualstudio.com I will mail you the details regarding project on mail and would probably have a machine for you to repro.
I will first try the insider bits and will then proceed with this.

@waderyan Mailed you the details for the repro

@harshil93 thanks. Can you confirm you tried with Insider bits and the problem exists?
Also does the problem only exist with your current project setup? It would be most helpful (especially when handing off to TypeScript team) if we can narrow down the bug to a simpler scenario.

@waderyan Yes, it is happening with insiders bits also on a fresh machine. I will try to narrow down to a simple scenario. I already have vscode source code and dev build setup. Any hints in debugging this on my own.

ReleasePipeline.zip
This project is the repro. The same code is there in temp.tsx and temp/ts
The error comes in tsx but not in ts.
P.S. - Open the folder which has tsconfig.json at its root.

The solution was to include tsx in include files.


Rotate automatically at the start

Hi There,
Is there anyway to let it rotate automatically instead of using hand swipe gesture? how can I implement it?

You can schedule a timer to call setCurrentRotation:animated:, which will eventually set the transform of the wheel

Hi,
Is there anyway to rotate wheel only when swiped? So that the user cannot force stop at particular position on the wheel?


BSoD When a huawei phone plugged in.

A BSoD occurred when I plugged in a huawei phone. It's about an 80 percent probability that happened.
Log attached below.
UsbDkTrace.zip
I traced the code and it seemed that phone was recognized as a hub due to an error when requesting the phone's Device descriptor.
Any help will be greatly appreciated!

Hi @xuyongjian ,
Thanks for reporting this issue, can you please provide me with the UsbDk version used so I can pasre the logs that are attached?
Thanks!

1.0.19

I have just noticed that the device that you are trying to redirect is actually composite device. UsbDk currently doesn't support composite devices and there are no plans to support composite devices for the near future. However the BSOD shouldn't occur, so let's try to understand why is it happening. Can you please send me the dump file that was generated by Windows, it usually resides under c:\windows\memory.dmp
Here are the parsed logs from UsbDkTrace_bluescreen.etl:
[1]0004.0038::05/04/2018-05:29:50.281 [UsbDk]<lambda_8ddb1b76a116ff81493b815282556e6a>::operator() Starting relations array processing:
[1]0004.0038::05/04/2018-05:29:50.281 [UsbDk]CDeviceRelations::Dump Array size: 1 (ptr: 882EAFD8)
[1]0004.0038::05/04/2018-05:29:50.281 [UsbDk]<lambda_a7dcb4ec5de294fa1a90aeeee6ee90d1>::operator() #0: 8859D7A8
[0]0004.0038::05/04/2018-05:29:50.282 [UsbDk]CUsbDkHubFilterStrategy::RegisterNewChild Registering new child (PDO: 8859D7A8):
[0]0004.0038::05/04/2018-05:29:50.282 [UsbDk]CRegText::Dump ID: USB\VID_12D1&PID_107E
[0]0004.0038::05/04/2018-05:29:50.282 [UsbDk]CRegText::Dump ID: FFKGK17720000107
[0]0004.0038::05/04/2018-05:29:50.284 [UsbDk]CUsbDkHubFilterStrategy::ApplyRedirectionPolicy Not attaching to device stack for 0x8859D7A8
[0]0004.0038::05/04/2018-05:29:50.284 [UsbDk]<lambda_8ddb1b76a116ff81493b815282556e6a>::operator() Finished relations array processing
[0]0004.0038::05/04/2018-05:29:50.287 [UsbDk]UsbDkEvtDeviceAdd Entry
[0]0004.0038::05/04/2018-05:29:50.287 [UsbDk]CUsbDkFilterDevice::Create Entry
[0]0004.0038::05/04/2018-05:29:50.287 [UsbDk]CWdfDevice::CacheDeviceName Newly created device name is \Device\UsbDkFilter6
[0]0004.0038::05/04/2018-05:29:50.287 [UsbDk]CRegText::Dump ID: USB\VID_12D1&PID_107E
[0]0004.0038::05/04/2018-05:29:50.287 [UsbDk]CUsbDkFilterDevice::CStrategist::SelectStrategy Do not redirect or already redirected device, no strategy assigned
[0]0004.0038::05/04/2018-05:29:50.287 [UsbDk]CUsbDkFilterDevice::DefineStrategy Not attached
[0]0004.0038::05/04/2018-05:29:50.287 [UsbDk]UsbDkEvtDeviceAdd Exit 0xc00000bb(STATUS_NOT_SUPPORTED)
[0]0004.0038::05/04/2018-05:29:50.287 [UsbDk]CUsbDkFilterDevice::ContextCleanup Entry
[0]0004.0038::05/04/2018-05:29:50.287 [UsbDk]CWdfDevice::~CWdfDevice Deleting device \Device\UsbDkFilter6
[3]0004.0038::05/04/2018-05:29:50.339 [UsbDk]UsbDkEvtDeviceAdd Entry
[3]0004.0038::05/04/2018-05:29:50.339 [UsbDk]CUsbDkFilterDevice::Create Entry
[3]0004.0038::05/04/2018-05:29:50.339 [UsbDk]CWdfDevice::CacheDeviceName Newly created device name is \Device\UsbDkFilter7
[3]0004.0038::05/04/2018-05:29:50.339 [UsbDk]CRegText::Dump ID: USB\VID_12D1&PID_107E&MI_01
[3]0004.0038::05/04/2018-05:29:50.339 [UsbDk]CUsbDkFilterDevice::CStrategist::SelectStrategy No cached device descriptor, assigning hub strategy
[3]0004.0038::05/04/2018-05:29:50.339 [UsbDk]CUsbDkFilterDevice::AttachToStack Attached
[3]0004.0038::05/04/2018-05:29:50.339 [UsbDk]UsbDkEvtDeviceAdd Exit STATUS_SUCCESS
[2]0004.0038::05/04/2018-05:29:50.405 [UsbDk]<lambda_8ddb1b76a116ff81493b815282556e6a>::operator() Starting relations array processing:
[2]0004.0038::05/04/2018-05:29:50.405 [UsbDk]CDeviceRelations::Dump Array size: 1 (ptr: 871A59D0)
[2]0004.0038::05/04/2018-05:29:50.405 [UsbDk]<lambda_a7dcb4ec5de294fa1a90aeeee6ee90d1>::operator() #0: 8865DCA8
[2]0004.0038::05/04/2018-05:29:50.405 [UsbDk]UsbDkSendUrbSynchronously Send URB IRP Error 0xc00000bb(STATUS_NOT_SUPPORTED)
[2]0004.0038::05/04/2018-05:29:50.405 [UsbDk]CUsbDkHubFilterStrategy::RegisterNewChild Cannot query device descriptor
[2]0004.0038::05/04/2018-05:29:50.405 [UsbDk]<lambda_8ddb1b76a116ff81493b815282556e6a>::operator() Finished relations array processing
[3]0004.0038::05/04/2018-05:29:50.417 [UsbDk]<lambda_8ddb1b76a116ff81493b815282556e6a>::operator() Starting relations array processing:
[3]0004.0038::05/04/2018-05:29:50.417 [UsbDk]CDeviceRelations::Dump Array size: 1 (ptr: 88548C38)
[3]0004.0038::05/04/2018-05:29:50.417 [UsbDk]<lambda_a7dcb4ec5de294fa1a90aeeee6ee90d1>::operator() #0: 8865DCA8
[3]0004.0038::05/04/2018-05:29:50.417 [UsbDk]UsbDkSendUrbSynchronously Send URB IRP Error 0xc00000bb(STATUS_NOT_SUPPORTED)
[3]0004.0038::05/04/2018-05:29:50.417 [UsbDk]CUsbDkHubFilterStrategy::RegisterNewChild Cannot query device descriptor

Hi, xuyongjian
Can you please try providing the kernel dump file (configure the system to keep kernel dumps and collect %windir%\memory.dmp file after the crash.
Thanks

Minidump is not enough to locate the root cause. Is it possible to share zipped dump over dropbox?

@xuyongjian Thanks for the minidump, in general it is better to share the kernel dump. You can do so easily using any hosting service such as google drive, Microsoft one or any other file sharing website.
we'll take a look at the minidump and get back to you soon

kernel dump attached
https://1drv.ms/f/s!AqQtNrW8d-CwaxK1VRtNjQcpqzQ

I've reviewed the dump files. I see the crash actually happens in system driver 'mountmgr', probably when it tries to mount some "linux cd". Usbdk at this time also work with attached USB devices but does not show any sign of the problem.
I see the crash in both dumps happens on virtual machine so USB device(s) are redirected to it from somewhere (where from?).
Can you please describe exactly what you do to reproduce the problem, what is your setup  and how you use the usbdk on virtual machine.
I see also some set of additional kernel drivers "rj*' and "qq*" in the stack.
So, the questions:

Does the same problem happen on clean machine with/without usbdk? (usbdk can be easily uninstalled/reinstalled just by 'usbdkcontroller -u' or '-i'.
Does the problem happen on bare metal platform (non-VM)?

Thanks

https://github.com/daynix/UsbDk/commit/960f44ed2c697178235caa088a04ac38bd8e675c


How to have inputs with array value

Hi,
I'm not sure if I'm clear so let me show an example. In HTML I can do this:
First user:
<input type="text" name="users[0][name]" />
<input type="text" name="users[0][age]" />

Second user:
<input type="text" name="users[1][name]" />
<input type="text" name="users[1][age]" />

Once submitted that form will send data as an array.
How can I reproduce that with Form Builder?
I have a form right now that creates a new input group when a button is clicked. But I don't know what name to give these inputs. Is there a trick already available?
Thanks for any help.

Any updates on this one? I have the same requirement where my form has an array of objects. Is there an option for saving the data with index?

Maybe related with this feature https://github.com/flutter-form-builder-ecosystem/flutter_form_builder/pull/1156


How to use multiple GPUs to train and test the network?

I used two GPUs to train the network, and was an error： ValueError: Error initializing torch.distributed using env:// rendezvous: environment variable RANK expected, but not set

CUDA_VISIBLE_DEVICES=0,1,2,3 python -m torch.distributed.launch --nproc_per_node=4 --master_port 66666 train.py --config_file configs/VehicleID/vit_transreid_stride.yml MODEL.DIST_TRAIN True
Sometimes you may encounter some errors because of the cuda driver. Please run the shell again after killing CUDA pids (if necessary).

Two gpus:
CUDA_VISIBLE_DEVICES=0,1
--nproc_per_node=2
Batch size * 2

Thanks,I will have a try


Add skeleton for Hugo rendered project handbook

This pull request adds a skeleton for a project handbook, which can be rendered as a website with Hugo. It integrates the current content and outlines the structure how it could be shown. Most files are stubs for now and have to be filled with content. Some of this content already is available in the technical-committee at other places.
The purpose of this pull request is to show the concept, so we can decide if we want to go with it and what we would need to modify. The rendered version can be seen at https://cornelius.github.io/technical-committee/.

I have made some tests to improve the directory layout in a separate PR against your branch: https://github.com/cornelius/technical-committee/pull/1


Improve masking

Depends on #8.

Codecov Report

Merging #9 into master will increase coverage by 0.63%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   88.91%   89.55%   +0.63%
==========================================
  Files          76       76
  Lines        2445     2585     +140
==========================================
+ Hits         2174     2315     +141
+ Misses        271      270       -1

Flag
Coverage Δ

#unittests
89.55% <94.44%> (+0.63%)
:arrow_up:

Impacted Files
Coverage Δ

xfuse/convert/utility.py
92.98% <ø> (+5.68%)
:arrow_up:

xfuse/convert/st.py
63.04% <50.00%> (+0.82%)
:arrow_up:

xfuse/__main__.py
87.70% <89.47%> (-0.53%)
:arrow_down:

xfuse/convert/visium.py
97.74% <98.27%> (+13.12%)
:arrow_up:

xfuse/utility/utility.py
93.23% <100.00%> (+0.67%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b20286...67eef53. Read the comment docs.

Codecov Report

Merging #9 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   89.24%   89.35%   +0.10%
==========================================
  Files          80       80
  Lines        2530     2554      +24
==========================================
+ Hits         2258     2282      +24
  Misses        272      272

Flag
Coverage Δ

unittests
89.35% <100.00%> (+0.10%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

xfuse/convert/image.py
89.47% <100.00%> (+0.58%)
:arrow_up:

xfuse/convert/st.py
60.46% <100.00%> (+0.94%)
:arrow_up:

xfuse/convert/visium.py
83.33% <100.00%> (+0.72%)
:arrow_up:

xfuse/utility/core.py
89.47% <100.00%> (+4.85%)
:arrow_up:

xfuse/utility/mask.py
100.00% <100.00%> (ø)

xfuse/utility/visualization.py
88.02% <100.00%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d33b7b...1f7e559. Read the comment docs.


[EN-764] Update kafkautils for stream server

Update utils for stream server changes
Tests

I think there were some changes in this kafkautils module that might've been overwritten inadvertently

I thought it was the same as in blep repo so I just copy-pasted from there 😄 I reverted the changes

Looking at the diffs between this and kafkautils in monorepo, why is context removed from Listen?

Looking at the diffs between this and kafkautils in monorepo, why is context removed from Listen?

It was added with protoregistry changes but it doesn't hurt to leave it there I guess 😅 I put it back

Closed due to being outdated and replaced with #4


Simply doesnt work

Simply doesn't work.
https://codesandbox.io/s/brokenfitty-6rmuh?file=/src/App.js

Thanks for the report with an example, I think I already found the problem
The wrapper div in ReactFitty component don't inherit the correct width when the parent is using display: flex, I will fix that and I will also add more test cases with other "display" properties

Thanks for the report with an example, I think I already found the problem
The wrapper div in ReactFitty component don't inherit the correct width when the parent is using display: flex, I will fix that and I will also add more test cases with other "display" properties

can you please test this release: 1.0.1?
https://codesandbox.io/s/brokenfitty-forked-o5qe6 - with the release fix

can you please test this release: 1.0.1?
https://codesandbox.io/s/brokenfitty-forked-o5qe6 - with the release fix

Fixed! Thank you @morhogg 😄

Fixed! Thank you @morhogg 😄


Google sheets on edge

### Tasks
- [ ] Test google Sheets feature on edge
- [ ] Update documents for edge browser

Currently deployed on DEV and BETA which is only for Chrome. will be avilable with Feb Release to edge


Fix monthSelect's .today/.selected styling

This commit corrects a mismatch in the CSS/styling
of the default date select mode
and the monthSelect plugin.
Specifically, when default flatpickr is newly instantiated:

.selected is applied to nothing, and
.today is applied to the current date.

When flatpickr is newly instantiated with the monthSelect plugin:

.selected is applied to the current date, and
.today is applied to nothing.

(Importantly, the current date is not actually selected by default,
meaning that the UI does not reflect the underlying calendar state.)
To fix this, monthSelect's DOM management had to be expanded:
before, it simply drew the calendar grid once,
and paging through previous/future years had no influence
on which cell was marked .selected;
now, it clears and redraws the calendar grid with each page change
so that the .today and .selected cells come and go as needed.

Demo Fiddles
Before / After


[UPDATE] Update OpenSearch driver (fixes minor CVEs and drop code)

Weird the CI didn't build that one...


template design improvements

use bootstrap icons instead of loading own images. This will give more flexibility
template now has a header, main and footer
use recommended github action by zola https://www.getzola.org/documentation/deployment/github-pages/ and structure it into build for every PR and build and deploy if it is on main branch
refine image rendering, add icons to nav links to make them easier to find
attempt to refine text
Render Schedule as table - this is something I tried but not sure about it.
Closes #35
changes also for #30

ok, fine with me

I moved the workflow changes to stafan/github-action.


HIVE-21790 Bump Java to 1.8

https://jira.apache.org/jira/browse/HIVE-21790
We're using Hive for reading Parquet files, but we would like to move from gzip to zstandard compression.
Currently, the Parquet support of Hive is old because we can't upgrade since Parquet is Java 1.8+. Therefore it is a good idea to upgrade Hive as well.
GA support of Java 1.7 is also almost over: https://www.oracle.com/technetwork/java/java-se-support-roadmap.html

@Fokko Are you still interested in doing this?  Hive 3.x support Java 8 and we plan on supporting Java 11 on Hive 4.x

Thanks @belugabehr Currently I don't really have the time to move this forward. So I'm fine if someone else wants to pick this up.

Closing this PR.  Take a look at my PR #1076.
As part of this work, I also added the bits required for ptests to run in GitHub.  Quite a few are failing and will need to be addressed at a later date if someone wants to release a 2.4.


BKR-408 Supporting solaris as a beakernode

Some fixes so beaker also works on solaris ( startup a solaris vagrant box)
for now only some host_prebuilt_steps.rb fixes

copy certs to solaris root home folder /
gsed of CSW to update sshd_config to allow ssh root login
restart sshd daemon

Tested on this solaris 10 vagrant box made by packer https://github.com/biemond/packer-vagrant-builder

Can one of the admins verify this patch?

Also added some solaris 11 ssh fixes

root home in solaris 11 is /root and not /
PermitRootLogin in sshd_config in solaris 11 is not in comment
change security of the user root for solaris else no ssh login without password

Please update commit message with ticket number, eg (BKR-xxx)

Needs a rebase.

Still needs a rebase.  Will close next week due to inactivity.

fixing it now

Hi @biemond,
Thanks for adding these changes!  For the commit message, we mean the message that comes with the commit itself, not with the pull request.  You can do this with git commit --amend, and then a force push.
This will also need some simple spec testing in order to be merged.  Hopefully this'll let us know early if we break anything around these changes in the future. Let me know if you have any questions about this, and I hope to be merging your changes soon!

Last review comment current.

ok to test

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/1344/
Test PASSed.

Still requires updated commit message.

done,
thanks

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/1349/
Test PASSed.


Interpolate fails when connected only to holes with NaN values

the interpolate method fails when it's connected to points that are also being interpolated. Should this process be iterative such that they all eventually get valid values?
https://github.com/emerald-geomodelling/EmeraldTriangles/blob/cd8cc6b69b17baf413b95762b541db7bdf1de0a3/emeraldtriangles/refine_mesh.py#L124

This figure was generated in this notebook:
https://github.com/emerald-geomodelling/project-21003_NO_BaneNOR_Fre16_ReInterp/blob/master/21003_Jupyter010_Bedrock_triangulated_boreholes.ipynb
These are the lines you need to reactivate to reproduce the error that I had:
# #compute interpolated Z are non-confirmatory points
# tri_int = emeraldtriangles.refine_mesh.interpolate_vertices(tri, mask_stop.index[~mask_stop])
# tri['vertices'].loc[~mask_stop, 'Z_interp'] = tri_int['vertices'].loc[~mask_stop, 'Z']

Yes :S


Running bot.py and it says no module named 'requests'

I run python bot.py and I get this:
Traceback (most recent call last):
File "bot.py", line 7, in
import requests
ModuleNotFoundError: No module named 'requests'
What's the problem? I'm using Win10.
Can someone please tell me how to solve this?

even i am getting the same error how to solve this issue


Make end to end example using colab

Since colab support query bigquery and provide free gpu/tpu.
Add a notebook to do the following steps

Query big query to get a dataset
Use tensorflow hub to reuse pre-trained word embedding
Train a keras model end to end with a string input and probability output.

Preview on colab https://colab.research.google.com/drive/1KXUqoNLX9-2vEs1FB30jhj-ofjunz-Je

@yupbank Is there anything about this notebook that makes it specific to colab as opposed to jupyter?
How is this notebook different from the existing notebooks?
https://github.com/machine-learning-apps/Issue-Label-Bot/tree/master/notebooks
/assign @hamelsmu

mostly colab offers free gpu/tpu, and have a bunch of python libs pre-installed.
to perform an end to end workflow, using big query requires authentication.

@yupbank I think this notebook will confuse matters in this project.  I would rather add the colab badge to the existing notebooks already in place.

I'm going to go ahead and close this notebook in favor of https://github.com/machine-learning-apps/Issue-Label-Bot/pull/51/files.  🙇

@yupbank I'm happy to reopen this PR if you want to make the case and write more documentation on how this notebook is different than the other notebook(s) and what the purpose of this notebook is vs. the other notebook, including creating a README in the /notebooks folder.
Before you do that work, might be worthwhile to discuss your goals with the PR further.  Thank you for getting involved with the project!


Issue when choosing not to solder

If you are choosing to not do any addition soldering and choosing the convenience option you must edit /config/rgb_options.ini and change "adafruit-hat-pwm" to "adafruit-hat"

This is a known issue and I will keep this open until I fix it

it's been 2 years lol. Might be worth pinning a comment on your video so people who aren't inclined to check the issues tab are aware as well. If you're busy I can add one more question to setup.sh that will update the value if necessary and create a PR. Up to you though let me know.


Question:  Segmentation fault

What is your question?
Hi, when I run localcolabfold, there is an error.
Computational environment

OS: CentOS 7
CUDA version if Linux:
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2020 NVIDIA Corporation
Built on Mon_Nov_30_19:08:53_PST_2020
Cuda compilation tools, release 11.2, V11.2.67
Build cuda_11.2.r11.2/compiler.29373293_0

To Reproduce
Steps to reproduce the behavior:

run:

colabfold_batch  --model-type alphafold2_multimer_v3 ifitm3_ps1_notch.fasta out

error:

2023-04-07 02:28:13,869 Running colabfold 1.5.2

WARNING: You are welcome to use the default MSA server, however keep in mind that it's a
limited shared resource only capable of processing a few thousand MSAs per day. Please
submit jobs only from a single IP address. We reserve the right to limit access to the
server case-by-case when usage exceeds fair use. If you require more MSAs: You can
precompute all MSAs with `colabfold_search` or host your own API and pass it to `--host-url`

2023-04-07 02:28:23,012 Running on GPU
2023-04-07 02:28:24,282 Found 4 citations for tools or databases
2023-04-07 02:28:24,283 Query 1/1: ps1 (length 729)
Segmentation fault

Expected behavior
I want to predict a complex (three sequence of my fasta) using localcolabfold.
Thanks!

Which GPU model do you use? (RTX 3090, RTX3060, etc...)
What is your gcc version? gcc --version


Fixing test and typeo

Fixing Livetest
Fixing typo

API change check
API changes are not detected in this pull request.


MSID: 89719 Version: 2 DOI: 10.1101/2<IP_ADDRESS>2533

MSID: 89719
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>2533
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=89719
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>2533

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/89719v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>2533
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/89719/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Hi @acollings, are both evidence terms OK here?

Hi @rkcook312 this seems to have gone astray, leave it with me

Hi @rkcook312 I've just edited the Assessment on hypothes.is

Great, thanks @acollings!


net/rpmsg: set conn->backlog=-1 only when socket listening

Summary
net/rpmsg: set conn->backlog=-1 only when socket listening
Impact
Testing

Please rebased to fix CI


Upgraded jenkins-pipeline-unit to 1.12.

Signed-off-by: dblock<EMAIL_ADDRESS>Description
This was released yesterday and contains a fix for https://github.com/jenkinsci/JenkinsPipelineUnit/issues/419 PRed as https://github.com/jenkinsci/JenkinsPipelineUnit/pull/421, that was preventing us from upgrading.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1098 (37cad3d) into main (8cc3852) will decrease coverage by 15.25%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1098       +/-   ##
=============================================
- Coverage     93.02%   77.77%   -15.26%
  Complexity        9        9
=============================================
  Files            97        8       -89
  Lines          2424       54     -2370
  Branches          4        3        -1
=============================================
- Hits           2255       42     -2213
+ Misses          164        8      -156
+ Partials          5        4        -1

Impacted Files
Coverage Δ

src/jenkins/Messages.groovy
68.75% <0.00%> (-13.07%)
:arrow_down:

src/test_workflow/integ_test/integ_test_suite.py

...ts_workflow/component_opensearch_dashboards_min.py

src/system/execute.py

src/system/console.py

src/build_workflow/builders.py

...est_workflow/test_result/test_component_results.py

src/test_workflow/bwc_test/bwc_test_suite.py

src/test_workflow/perf_test/perf_test_suite.py

src/manifests/build/build_manifest_1_1.py

... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc3852...37cad3d. Read the comment docs.


Update copyright year for files changed since last alpha release

Merged
4333b89f504e7a8de9c42a0d27f68530b5301848 Update copyright year

Merged
4333b89f504e7a8de9c42a0d27f68530b5301848 Update copyright year


Not possible to set empty environment values

Expected Behavior
aio cloudmanager:pipeline:set-variables <id> FOO "" results in creating an environment variable named FOO with empty value.
Actual Behavior
The variable FOO is deleted from the list of pipeline variables.
As long as you use Bash exclusively, this behavior is ok-ish, because most tests are done with -n, -z or -eq operators. But also in Bash v4.2+ there is a difference:
$ [[ -v FOO ]] && echo true || echo false
false

$ FOO=
$ [[ -v FOO ]] && echo true || echo false
true

This behavior becomes a problem for languages that distinguish between not existing and empty, e.g. Java. If you want to use (secret) variables to replace values in config files via Maven resources plugin during the Build you will end up with ${env.FOO} in the processed config file. This creates problems for the software that is using the software because "${env.FOO}" is obviously something different than "".
Therefore, the set-variables command should support something like an allow-empty parameter.
Reproduction Scenario, Platform, and Version
$ aio -v
@adobe/aio-cli/6.0.0 linux-x64 node-v12.20.1

$ aio plugins
@adobe/aio-cli-plugin-cloudmanager 1.5.0

Steps to Reproduce
Invoke aio cloudmanager:pipeline:set-variables with an arbitrary variable name and an empty value.

There is no way to have a variable with an empty value. An empty value causes a variable to be deleted.
I can see how the current behavior is not intuitive though -- passing an empty variable should be an error condition.


Improvements to Image/Raster ETL and NITF support

General improvements to the core Image and Raster ETL routines. This adopts large_image over rasterio where possible to give us better support for NITF files (ref #429)
I am currently experiencing an issue where NITF files get hung when opening with large_image so we will need to figure out the cause of this - this only happens within the ETL routines and not if I open the same files in the debug shell. It is very, very odd and difficult to track down.

It looks to me like large_image is hung when trying to fetch the band statistics:
(after an interrupt signal):
/opt/django-project/django-rgd-imagery/rgd_imagery/tasks/etl.py in _populate_image_meta_models(image, image_meta)
     34 def _populate_image_meta_models(image, image_meta):
     35
---> 36     with yeild_tilesource_from_image(image) as tile_source:
     37         meta = tile_source.getMetadata()
     38         imeta = tile_source.getInternalMetadata()

/usr/local/lib/python3.8/contextlib.py in __enter__(self)
    111         del self.args, self.kwds, self.func
    112         try:
--> 113             return next(self.gen)
    114         except StopIteration:
    115             raise RuntimeError("generator didn't yield") from None

/opt/django-project/django-rgd-imagery/rgd_imagery/large_image_utilities.py in yeild_tilesource_from_image(image, projection)
     20 @contextmanager
     21 def yeild_tilesource_from_image(image: Image, projection: str = None) -> FileTileSource:
---> 22     yield get_tilesource_from_image(image, projection)
     23
     24

/opt/django-project/django-rgd-imagery/rgd_imagery/large_image_utilities.py in get_tilesource_from_image(image, projection)
     12     try:
     13         file_path = image.file.get_vsi_path(internal=True)
---> 14         return GDALFileTileSource(file_path, projection=projection, encoding='PNG')
     15     except TileSourceException:
     16         with image.file.yield_local_path() as file_path:

/usr/local/lib/python3.8/site-packages/large_image/cache_util/cache.py in __call__(cls, *args, **kwargs)
    189                 # will not be reported in the cache exception context.
    190                 pass
--> 191             instance = super().__call__(*args, **kwargs)
    192             cache[key] = instance
    193             instance._classkey = key

/usr/local/lib/python3.8/site-packages/large_image_source_gdal/__init__.py in __init__(self, path, projection, unitsPerPixel, **kwargs)
    147             self._initWithProjection(unitsPerPixel)
    148         self._getTileLock = threading.Lock()
--> 149         self._setDefaultStyle()
    150
    151     def _checkNetCDF(self):

/usr/local/lib/python3.8/site-packages/large_image_source_gdal/__init__.py in _setDefaultStyle(self)
    205                     styleBands[0].get('band', 1), int) and styleBands[0].get('band', 1) <= 0):
    206                 del self.style
--> 207         style = self._styleBands()
    208         if len(style):
    209             hasAlpha = False

/usr/local/lib/python3.8/site-packages/large_image_source_gdal/__init__.py in _styleBands(self)
    172         if not len(style):
    173             for interp in ('red', 'green', 'blue', 'gray', 'palette', 'alpha'):
--> 174                 band = self._bandNumber(interp, False)
    175                 # If we don't have the requested band, or we only have alpha,
    176                 # or this is gray or palette and we already added another band,

/usr/local/lib/python3.8/site-packages/large_image_source_gdal/__init__.py in _bandNumber(self, band, exc)
    658             if key in self._netcdf['datasets']:
    659                 return (key, band)
--> 660         bands = self.getBandInformation()
    661         if not isinstance(band, int):
    662             try:

/usr/local/lib/python3.8/site-packages/large_image_source_gdal/__init__.py in getBandInformation(self, dataset)
    494                     info = {}
    495                     try:
--> 496                         stats = band.GetStatistics(True, True)
    497                         # The statistics provide a min and max, so we don't
    498                         # fetch those separately

/usr/local/lib/python3.8/site-packages/osgeo/gdal.py in GetStatistics(self, *args)
   3767     def GetStatistics(self, *args):
   3768         """GetStatistics(Band self, int approx_ok, int force) -> CPLErr"""
-> 3769         return _gdal.Band_GetStatistics(self, *args)
   3770
   3771

While this info is useful, we don't want to wait for it to compute every time we try to serve tiles.
@manthey, is there a way to have large_image not fetch this info when initializing GDALFileTileSource?

Note that using NITF_OPEN_UNDERLYING_DS=NO mitigates the issue

Using NITF_OPEN_UNDERLYING_DS=NO with the recent changes to the ETL routines enables proper metadata extraction for the NITF images. However, on the web app when using NITF_OPEN_UNDERLYING_DS=NO and attempting to serve tiles, we get an error:
django_1    |   File "/opt/django-project/django-rgd-imagery/rgd_imagery/rest/tiles.py", line 44, in get
django_1    |     tile_binary = tile_source.getTile(x, y, z)
django_1    |   File "/usr/local/lib/python3.8/site-packages/large_image/cache_util/cache.py", line 102, in wrapper
django_1    |     v = func(self, *args, **kwargs)
django_1    |   File "/usr/local/lib/python3.8/site-packages/large_image_source_gdal/__init__.py", line 724, in getTile
django_1    |     if len(tile.shape) == 3:
django_1    | AttributeError: 'NoneType' object has no attribute 'shape'

If I remove the NITF_OPEN_UNDERLYING_DS=NO option, then the tile server does not error but still gets hung (likely on computing band stats)

So. I'm seeing a few scenarios:

Use VSICURL to access file and GDALFileTileSource() init gets hung (likely computing band stats) and never seems to resolve
Use NITF_OPEN_UNDERLYING_DS=NO, VSICURL for file path, and GDALFileTileSource.getTile() throws an error (see above)
Download the entire file to local storage and pass a path to GDALFileTileSource() and then see an error TileSourceException('File cannot be opened via GDAL')
Use NITF_OPEN_UNDERLYING_DS=NO and download entire path to local storage with GDALFileTileSource() and same error as 3


Segfault after connecting monitor before resuming from sleep

Hyprland Version
Branch main at commit 1ec0b7b59a84a07f97c3ebee9f6694bc4a1b1dcd
Bug or Regression?
Bug
Description
I have the ThinkPad Basic Dock (40AG0090US) (and a ThinkPad P14s Gen 1) which provides DisplayPort (Passive) over USB-C and/or a proprietary connector.
This does not happen if the laptop is connected to HDMI directly.
When the laptop is asleep, I sometimes connect it to the dock and then wake it up from sleep. Every time I do this, Hyprland crashes.
How to reproduce

Run systemctl hibernate.
Connect monitor (details above).
Wake up laptop.
Observe getting kicked to TTY.

Crash reports, logs, images, videos
--------------------------------------------
   Hyprland Crash Report
--------------------------------------------
Who tried dividing by zero?!

Hyprland received signal 11 (Segmentation fault)

Version: 1ec0b7b59a84a07f97c3ebee9f6694bc4a1b1dcd
Tag: ?

System info:
	System name: Linux
	Node name: intrepid
	Release: 6.4.3
	Version: #1-NixOS SMP PREEMPT_DYNAMIC Tue Jul 11 04:31:05 UTC 2023

GPU:
	08:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Renoir [1002:1636] (rev d1) (prog-if 00 [VGA controller])

os-release:
	BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
	BUILD_ID="23.11.20230720.5df4d78"
	DOCUMENTATION_URL="https://nixos.org/learn.html"
	HOME_URL="https://nixos.org/"
	ID=nixos
	LOGO="nix-snowflake"
	NAME=NixOS
	PRETTY_NAME="NixOS 23.11 (Tapir)"
	SUPPORT_URL="https://nixos.org/community.html"
	VERSION="23.11 (Tapir)"
	VERSION_CODENAME=tapir
	VERSION_ID="23.11"

Backtrace:
	#0 | /nix/store/r158p2yxg2ir0agis3ffi9khr2hmcv2z-hyprland-0.27.2+date=2023-07-20_1ec0b7b/bin/Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0x839) [0x5696c9]
		_ZN13CrashReporter18createAndSaveCrashEi
		??:?
	#1 | /nix/store/r158p2yxg2ir0agis3ffi9khr2hmcv2z-hyprland-0.27.2+date=2023-07-20_1ec0b7b/bin/Hyprland(_Z25handleUnrecoverableSignali+0x3f) [0x47636f]
		_Z25handleUnrecoverableSignali
		??:?
	#2 | /nix/store/ayg065nw0xi1zsyi8glfh5pn4sfqd8xg-glibc-2.37-8/lib/libc.so.6(+0x38d30) [0x7f504cda4d30]
		??
		??:0
	#3 | /nix/store/3y9pj04f7xfwfs6h9rvgd70cqi105g54-wayland-1.22.0/lib/libwayland-server.so.0(wl_event_loop_dispatch+0xa0) [0x7f504d9bb8f0]
		??
		??:0
	#4 | /nix/store/3y9pj04f7xfwfs6h9rvgd70cqi105g54-wayland-1.22.0/lib/libwayland-server.so.0(wl_display_run+0x25) [0x7f504d9b9455]
		??
		??:0
	#5 | /nix/store/r158p2yxg2ir0agis3ffi9khr2hmcv2z-hyprland-0.27.2+date=2023-07-20_1ec0b7b/bin/Hyprland(main+0x9ac) [0x469cec]
		main
		??:?
	#6 | /nix/store/ayg065nw0xi1zsyi8glfh5pn4sfqd8xg-glibc-2.37-8/lib/libc.so.6(+0x23ace) [0x7f504cd8face]
		??
		??:0
	#7 | /nix/store/ayg065nw0xi1zsyi8glfh5pn4sfqd8xg-glibc-2.37-8/lib/libc.so.6(__libc_start_main+0x89) [0x7f504cd8fb89]
		??
		??:0
	#8 | /nix/store/r158p2yxg2ir0agis3ffi9khr2hmcv2z-hyprland-0.27.2+date=2023-07-20_1ec0b7b/bin/Hyprland(_start+0x25) [0x476225]
		_start
		??:?

Log tail:
[LOG] Callback 3d23270 -> 3d23268, XWayland Window removed.
[LOG] Callback 3d232d8 -> 3d232d0, XWayland Window removed.
[LOG] Callback 3d23340 -> 3d23338, XWayland Window removed.
[ERR] onWindowRemovedTiling node null?
[LOG] Unmapped window 3d22b60 removed instantly
[LOG] Window 3bb4700 destroyed, queueing. (class )
[LOG] XWayland class raw: (null)
[LOG] Callback 3bb4860 -> 3bb4858, XWayland Window removed.
[LOG] Callback 3bb4c70 -> 3bb4c68, XWayland Window removed.
[LOG] Callback 3bb4e10 -> 3bb4e08, XWayland Window removed.
[LOG] Callback 3bb4e78 -> 3bb4e70, XWayland Window removed.
[LOG] Callback 3bb4ee0 -> 3bb4ed8, XWayland Window removed.
[ERR] onWindowRemovedTiling node null?
[LOG] Unmapped window 3bb4700 removed instantly
[LOG] Window 3cfcd50 destroyed, queueing. (class )
[LOG] XWayland class raw: Tidal-hifi
[LOG] Callback 3cfceb0 -> 3cfcea8, XWayland Window removed.
[LOG] Callback 3cfd2c0 -> 3cfd2b8, XWayland Window removed.
[LOG] Callback 3cfd460 -> 3cfd458, XWayland Window removed.
[LOG] Callback 3cfd4c8 -> 3cfd4c0, XWayland Window removed.
[LOG] Callback 3cfd530 -> 3cfd528, XWayland Window removed.
[ERR] onWindowRemovedTiling node null?
[LOG] Unmapped window 3cfcd50 removed instantly
[LOG] Window 3cb0f60 destroyed, queueing. (class )
[LOG] XWayland class raw: (null)
[LOG] Callback 3cb10c0 -> 3cb10b8, XWayland Window removed.
[LOG] Callback 3cb14d0 -> 3cb14c8, XWayland Window removed.
[LOG] Callback 3cb1670 -> 3cb1668, XWayland Window removed.
[LOG] Callback 3cb16d8 -> 3cb16d0, XWayland Window removed.
[LOG] Callback 3cb1740 -> 3cb1738, XWayland Window removed.
[ERR] onWindowRemovedTiling node null?
[LOG] Unmapped window 3cb0f60 removed instantly
[LOG] Window 37c59e0 destroyed, queueing. (class )
[LOG] XWayland class raw: (null)
[LOG] Callback 37c5b40 -> 37c5b38, XWayland Window removed.
[LOG] Callback 37c5f50 -> 37c5f48, XWayland Window removed.
[LOG] Callback 37c60f0 -> 37c60e8, XWayland Window removed.
[LOG] Callback 37c6158 -> 37c6150, XWayland Window removed.
[LOG] Callback 37c61c0 -> 37c61b8, XWayland Window removed.
[ERR] onWindowRemovedTiling node null?
[LOG] Unmapped window 37c59e0 removed instantly
[LOG] Window 37c4540 destroyed, queueing. (class )
[LOG] XWayland class raw: Dunst
[LOG] Callback 37c46a0 -> 37c4698, XWayland Window removed.
[LOG] Callback 37c4ab0 -> 37c4aa8, XWayland Window removed.
[LOG] Callback 37c4c50 -> 37c4c48, XWayland Window removed.
[LOG] Callback 37c4cb8 -> 37c4cb0, XWayland Window removed.
[LOG] Callback 37c4d20 -> 37c4d18, XWayland Window removed.
[LOG] Cleanup: destroyed a window
[LOG] Cleanup: destroyed a window

Different--but similar--circumstances: https://github.com/hyprwm/Hyprland/issues/2825

Same circumstances: https://github.com/hyprwm/Hyprland/issues/804#issuecomment-1271785610
Leaving this issue open because monitor is not mentioned in that issue description


:sparkles: Combined Status API

Summary
This PR addresses #2017 in a new proposal that is based on @MikeSpreitzer's in #2055, with the flexibility intended to be achieved in my previous outline here.
This proposal mainly inherits the essence Mike outlined, while making one significant change:

StatusReturn, now named StatusCollector, is a separate API resource that can be defined and reused.

The motivation behind this change, as well as letting go of the first proposal documented is going for convenient simplicity. After conducting an analysis research on competitors, I'm convinced that KS wins in multi-cluster K8s if convenience and simplicity remain within top priorities.
Through separating the StatusCollector from being simply inlined in BindingPolicies, KubeStellar can allow the reuse of combined status templates. Users would be able to define them once, per resource of interest, and use them across BindingPolicies. In addition to this benefit, KubeStellar would provide a set of StatusCollectors for the built-in K8s resources, and later host a library of common use collectors. This way, a user can have full multi-cluster experience by simply adding one resource to their general workflow - a BindingPolicy.

Enabling the use of default collectors is not in the API proposal yet - it will be PR'd along with the default collectors in the future.

Notes:

This PR removes parts of the API proposed in #2055 and leaves them in TODOs, such as augmented data that is injected in workload objects
An extension to this proposal is to allow for inlined StatusCollectors, as can be seen in the API (types.go) - which would allow users to stack their own unique-case collectors that do not benefit from re-use, along with ones from KS common library
The majority of the files/code that appear in the PR are generated

Related issue(s)

#2017

Fixes
Closes #2138

CC @ezrasilvera @pdettori @MikeSpreitzer @nirrozenbaum

I am OK with making the status combination prescriptions be independent API objects.
I see no value in rebasing this onto #2055.
I do think that some very likely use cases will need the agumentation proposed in #2055. For example, producing a list of WECs where a given Deployment object does not have the prescribed number of available replicas. Producing a list of WECs that have not checked in recently enough. I am OK with adding that in follow-on work. I have been intending to write up some examples. I think that is very much needed.

@MikeSpreitzer thanks, addressed comments. I intended to rebase on your draft since a lot of the code is copied from there. Since you do not mind, I also prefer not rebasing.
The steps that follow this PR are:

A PR that implements modifying the Binding API to reflect which collectors should be applied to which resources

An alternative to this would be an additional system resource that contains the decision - although at the moment this seems unlikely

A PR that implements creating CombinedStatus objects based on (1)
Extending the combined-status API to include what you originally proposed in Augmentations

Yes, I think that the StatusCollector references should go in the BindingSpec.

@vMaroon Can you share here an example on how I define the policy in case I want the receive the full status from all WECs?   Can you also explain how the result will look like ?
Personally I think that for this specific case users will expect to 1) no need to define any selection for fileds/keys , as they want the whole status 2) Get a vector or another collection of original object Status structure

@ezrasilvera:

A useful return of individual status includes the name of the WEC. That is one of the things that  "augmentation" is for.
The approach to getting a list would be to SELECT augmentation.name, status.
This is not designed for large lists. For full access to all the reported state, I think that we should have a separate procedural interface rather than inventing some scalable way to make another copy.

I think we are all agreed that the plan is that user-facing documentation, CI testing, and contributor testing are included by the end of step 2.

/lgtm

/hold

@MikeSpreitzer to clarify - I wasn't asking for docs.  I wanted to understand if this PR and approach will support users that are looking for the use case I mentioned, if the answer is "no - we would need another mechanism"  I'm OK with that, but I'll have to open a new issue to track that and we would need to see if indeed there are users waiting for that.
So I just wanted to understand from @vMaroon if the feature I'm describing is included or not.

To clarify my question - I'm looking on users that develop automation through informers on the returned status/objects when working on a single cluster, and want to do similar thing when working with KS across (small number) of clusters

@ezrasilvera the return of a status copy or sub-status copy per WEC as separate objects is not a part of this API. Users can select status to fetch per WEC into a single CombinedStatus object instead. I understand the need for separate copies - but I agree with mike on that optimally we'd want a solution that doesn't just duplicate resources from the ITS to the WDS.
If until a clean pipeline for that case we do bear with duplication - it would be a simple extension to this API.

@vMaroon: the design for augmentation allows for return of an object's status section from each WEC.

@MikeSpreitzer to be sure we are talking about the same thing - Ezra is referring to fetching the status of objects per wec, into a separate containing object each.
As far as I saw on Augmentations, I thought the intention there was to conveniently add information that is not normally a part of the workload object, but one that is artificially added and can be utilized by the user, such as WEC name.

// Augmentation defines what is implicitly added to every workload object from a WEC,
// for purposes of status collection.

The only actual status containing object in the proposal is CombinedStatus, which is per (workload-object, binding-policy) and not WEC.

@vMaroonThanks for the answer. I agree with this. Let's revisit in case we see concrete request for this requirement (I'm not aware of one, I was just speculating :-) )

/unhold

/approve


 It is only available in 3 button navigation. But if u use A11 gesture than there is no button to switch keyboard.
That is why a inbuilt keyboard switcher button is needed

I've 3 button navigation activated but my ROM doesn't show a keyboard switch button...

I've 3 button navigation activated but my ROM doesn't show a keyboard switch button...

Hm interesting. I've reopened the original issue then-- can you take a look at the image I added there and post what you see? Environment would also be helpful (which android version, any custom things, etc.).


refactor: Common static analysis issues

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.CommonStaticAnalysis

Accidentally created PR. Sorry about that!


Standardize snapshot indices parsing so that combinations of included and excluded indices are treated the same regardless of the order they are listed in

Description
Adds a custom comparator-based sort call before parsing indices using the SnapshotUtils class. Previously, the lack of sort meant that mixing negated and normal indices in the "indices" field of the REST calls would create different behavior based on the ordering of the indices. The added sorting logic corrects this by always parsing negated indices after all normal indices (during these situations, the indices parsing had been acting as expected).
In addition, the sorting logic includes a removal of empty strings from the index list since these strings would break the comparator's sort.
Three new tests were added to the SnapshotUtilsTests class in order to make sure that the ordering of the negative and normal indices did not change the behavior (and that it was the expected behavior).
The new behavior is as follows:

(Querying a single negated snapshot): If the body of the request reads indices: "-bar", the query will return all indices which are not "bar".
(Querying a single negated snapshot wildcard): If the body of the request reads indices: "-bar*", the query will return all indices which are not a subset of "bar*".
(Querying multiple negated snapshots): If the body of the request reads indices: "-bar, -baz", the query will return all indices which are not "bar" or `"baz".
(Querying multiple negated snapshot wildcards): If the body of the request reads indices: "-bar*, -baz*", the query will return all indices which are not a subset of "bar*" or a subset of `"baz*".
(Querying a single snapshot): If the body of the request reads indices: "bar", the query will return "bar".
(Querying multiple snapshot wildcards): If the body of the request reads indices: "bar*, baz*", the query will return all indices which are a subset of "bar*" or a subset of `"baz*".
(Querying multiple mixed snapshot wildcards): If the body of the request reads indices: "-bar*, ba*", the query will return all indices which are a subset of "ba*" but not a subset of "bar*". This was not the case previously.
(Querying multiple mixed snapshot wildcards): If the body of the request reads indices: "ba*, -bar*", the query will return all indices which are a subset of "ba*" but not a subset of "bar*".

Now behavior is persevered irregardless of the order of positive and negated wildcards queries.
Issues Resolved
Resolves issue
https://github.com/opensearch-project/security/issues/1652
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[ ] ~New functionality has javadoc added~

[x] Commits are signed per the DCO using --signoff
[x] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thank you for the PR @scrawfor99, I created an issue for this PR in the core repo here: https://github.com/opensearch-project/OpenSearch/issues/5627

Codecov Report

Merging #5626 (2a43f9d) into main (4fe8097) will decrease coverage by 0.03%.
The diff coverage is 90.00%.

:exclamation: Current head 2a43f9d differs from pull request most recent head 9a2ee3f. Consider uploading reports for the commit 9a2ee3f to get more accurate results

@@             Coverage Diff              @@
##               main    #5626      +/-   ##
============================================
- Coverage     70.95%   70.92%   -0.04%
- Complexity    58433    58436       +3
============================================
  Files          4748     4748
  Lines        278919   278928       +9
  Branches      40296    40298       +2
============================================
- Hits         197912   197818      -94
- Misses        64835    64999     +164
+ Partials      16172    16111      -61

Impacted Files
Coverage Δ

...n/java/org/opensearch/snapshots/SnapshotUtils.java
84.72% <90.00%> (-2.58%)
:arrow_down:

.../org/opensearch/client/indices/AnalyzeRequest.java
31.00% <0.00%> (-42.00%)
:arrow_down:

...cluster/coordination/PublishClusterStateStats.java
33.33% <0.00%> (-37.51%)
:arrow_down:

...java/org/opensearch/threadpool/ThreadPoolInfo.java
56.25% <0.00%> (-37.50%)
:arrow_down:

...n/decider/SnapshotInProgressAllocationDecider.java
34.78% <0.00%> (-34.79%)
:arrow_down:

...a/org/opensearch/index/mapper/MapperException.java
75.00% <0.00%> (-25.00%)
:arrow_down:

.../java/org/opensearch/index/reindex/RemoteInfo.java
50.45% <0.00%> (-23.86%)
:arrow_down:

...nsearch/index/shard/IndexingOperationListener.java
63.93% <0.00%> (-22.96%)
:arrow_down:

...ava/org/opensearch/threadpool/ThreadPoolStats.java
58.66% <0.00%> (-22.67%)
:arrow_down:

...pensearch/index/mapper/MapperParsingException.java
77.77% <0.00%> (-22.23%)
:arrow_down:

... and 455 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Do we have clear documentation on what the "correct" behavior here is? Like, do users expect -*,bar and bar,-* to behave the same? A behavior change here will likely be impactful to users, even if it makes the API behave in what seems to be a more sane manner.

Hi @andrross, thank you for reviewing. To the best of my knowledge the only discussion of the query syntax is found here. It says "You can use , to create a list of indices, * to specify an index pattern, and - to exclude certain indices. Don’t put spaces between items. Default is all indices."
I have not read any other documentation that mentions the use of the special characters. I cannot speak for everyone using OpenSearch but given this issue, it seems like at least a fair number of users expect the behavior to be as this issue would make it. I also think that in general, unless we added documentation and an explanation for why this behavior exists, a change is necessary for user experience etc.

@scrawfor99 We're going to have to be super clear about the behavior change here, and then make a judgement call as to whether this is a bug fix versus a breaking change that must be deferred to the next major version. Can you clearly enumerate how this changes the behavior of the API in the commit message and PR description? Something similar to this comment is what I'm thinking.

Hi @andrross, thank you for your suggestion. I went ahead and added documentation into the body like you requested. Let me know if you need anything else.
Happy Holidays!

@reta @dblock
Just want to raise this issue as I believe we should backport this as a bug fix, though it does change the behavior of the snapshot restore (and clone) APIs.
The upshot here is that, given indexes "foo", "bar", "baz" in a snapshot, and the user provides the pattern "-bar*, ba*" in the restore API, the current behavior results in restoring "foo" and "baz". This is a bug. The correct behavior is to restore only "baz" (select indexes that match "ba*" and exclude those that match "bar*").
There is definitely a chance that some users are (intentionally or not) relying on this buggy behavior and the fix will break them. I think we should backport this as it is clearly wrong. What do you think?

Looks like a bug fix to me, so yes to backport. When users accidentally or purposely use behavior that is a side effect of a bug, it's still a bug, and not a breaking change.

Thanks @scrawfor99, nice work!

Great work @scrawfor99 and thank you for following this through! 🎸


[bug] wrong discord link

The discord link in the body is different from the discord link in the header.
And the Discord link in the body is an invalid invitation.

step 컴포넌트에서 사용한 아래 링크로 통일하면 될 것 같습니다.
https://discord.com/invite/6TwzdnW6ze


Cache the metrics

Instead of querying metrics from the database every time someone sends a request to /metrics endpoint, try to cache them. Basically have a cache that is updated at some (likely configurable) interval and then serve the contents of the cache on each request for metrics.

Fixed by https://github.com/kinvolk/nebraska/pull/320


Switching between the last executed commands in the VSCode zsh

Type: Feature Request
Assume you run below scripts on VSCode terminal:
-script1
-script2
-script3
-script3
-script3
-script3
When i try to reach previously executed scripts by arrow up/down buttons, It doesn't keep script3 once. I have to press arrowup button 4 times to reach script2. Of course there is a workaround like search in history but traversing by arrow buttons can be optimized to improve user experience
VS Code version: Code 1.88.0 (Universal) (5c3e652f63e798a5ac2f31ffd0d863669328dc4c, 2024-04-03T13:28:18.899Z)
OS version: Darwin arm64 23.4.0
Modes:

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.88.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Version 1.88.1 also has same behaviour.

does not reproduce for me
https://github.com/microsoft/vscode/assets/29464607/c573d692-158d-4935-9003-74c658b04e87


gadget pod fails to start in OpenShift's playground due to missing kernel headers

I was trying to follow the OpenShift tutorial for inspektor gadget and couldn't do much because the gadget pod fails to start.
The last lines in the pod log are:
Fetching kernel-devel from CentOS 8
curl: (22) The requested URL returned error: 404 Not Found

This happens because IG tries to download the kernel headers for the running kernel. In this case, the playground has version 4.18.0-147.0.3.el8_1.x86_64. But that version is not available in the CentOS URL that IG queries (http://mirror.centos.org/centos/8/BaseOS/x86_64/os/Packages/)
This is the line that causes the failure:
https://github.com/kinvolk/inspektor-gadget/blob/master/gadget-container/entrypoint.sh#L68
Downloading the source wouldn't be needed if the kernel had CONFIG_IKHEADERS, but I guess they'd need to upgrade to 5.4 before that.

Fixed by https://github.com/kinvolk/inspektor-gadget/pull/486


Force Error Prone Version to 2.0.15

Current coverage is 95.11% (diff: 100%)

Merging #85 into master will not change coverage

@@             master        #85   diff @@
==========================================
  Files            15         15
  Lines           676        676
  Methods           0          0
  Messages          0          0
  Branches        151        151
==========================================
  Hits            643        643
  Misses           14         14
  Partials         19         19

Powered by Codecov. Last update 0cc2e52...7d528cc


feat(rzSliderOptions): Change rzSliderOptions to use expression binding

Switch from using two-way binding for rzSliderOptions to using expression binding. Using expression
binding enables more complex use cases such as using the return value of a function as an options
object.
Closes #265.

If more detailed tests are needed, I can add them. I wasn't quite sure what I should test. I added the optionsExpression option for the test helper for setting the expression that is used for directive (defaults to slider.options).

Example JSfiddle for why this is useful: http://jsfiddle.net/fvb1uw23/

Current coverage is 100.00%

Merging #266 into master will not affect coverage as of bee5b80

@@            master    #266   diff @@
======================================
  Files            1       1
  Stmts          641     645     +4
  Branches         0       0
  Methods          0       0
======================================
+ Hit            641     645     +4
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of bee5b80

Powered by Codecov. Updated on successful CI builds.

I have to admit that at first I didn't really like it and it feels weird to me, but it works without creating breaking changes (as far as I have tested for now).
I'm just curious of where have you seen such a way to pass parameters to a directive? I was thinking that expression bindings where only good for calling callbacks from a directive...

I personally use expression binding when there is no need for the directive to make modifications to a value (and where attribute binding wouldn't make sense). Expression binding allows the greatest freedom for the consuming developer. One common example for when AngularJS itself uses expression binding over two-way binding is the ngShow, ngHide and ngIf directives. By using expression binding there, I can use something such as ng-if="!shouldHide". It also allows filters to be in the parameter.
For rzslider, I use the return value of a function that dynamically generates the slider's configuration based on various parameters that it pulls from various locations. Even though the $watch uses angular.equals comparison to check for updates, the two way binding only checks for identity. If the function returns a new object on every call, a infinite digest loop is created.

Well, looks good to me! Thanks :)


Setup the Gitpod ready-to-code system

Things added/changed:

Setup the Gitpod ready-to-code system.

Things added/changed:
* Setup the Gitpod ready-to-code system.

Please provide rationale.


When changing the state, the background music of the previous scene does not turn off.Mozilla

A bug in the API:

Phaser version(s): Phaser v2.6.2/
Live example: https://picom.ru/19years/
What steps produce the bug:  changing the state
What should happen:  background music change
What happens instead: layering of music from different scenes
If there's an error: Firefox Quantum 64.0.2

What's the error message?
sometimes displays -  InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable

https://picom.ru/19years/
https://github.com/likezninjaz/phaser-rick-and-morty

Test this with the latest version of Phaser CE, because 2.6.2 is really old now.

Solved the problem by removing the .loopFull () method.


[bug] V2 pnpm tauri android dev just hands and does nothing - Ubuntu 24.4.0

Describe the bug
pnpm Tauri android dev just hangs with no output or action. --verbose doesn't assist.
Reproduction
pnpm create tauri-app --rc
cd tauri-app
pnpm i
pnpm tauri android init
pnpm tauri dev -- builds and launches
pnpm tauri android dev: hangs
pnpm tauri android dev --open: opens android studio and will run the app after I open the emulator
Expected behavior
I would expect something to start compiling and then for the emulator to launch
Full tauri info output
[✔] Environment
    - OS: Ubuntu 24.4.0 x86_64 (X64)
    ✔ webkit2gtk-4.1: 2.44.3
    ✔ rsvg2: 2.58.0
    ✔ rustc: 1.81.0 (eeb90cda1 2024-09-04)
    ✔ cargo: 1.81.0 (2dbb1af80 2024-08-20)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-x86_64-unknown-linux-gnu (default)
    - node: 22.8.0
    - pnpm: 9.11.0
    - npm: 10.8.2

[-] Packages
    - tauri 🦀: 2.0.0-rc.15
    - tauri-build 🦀: 2.0.0-rc.12
    - wry 🦀: 0.43.1
    - tao 🦀: 0.30.2
    - @tauri-apps/api : 2.0.0-rc.5
    - @tauri-apps/cli : 2.0.0-rc.16

[-] Plugins
    - tauri-plugin-shell 🦀: 2.0.0-rc.3
    - @tauri-apps/plugin-shell : 2.0.0-rc.1

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: Vue.js
    - bundler: Vite

Stack trace
No response
Additional context
.zshrc exports
export JAVA_HOME=/snap/android-studio/current/jbr
export ANDROID_HOME="$HOME/Android/Sdk"
export NDK_HOME="$ANDROID_HOME/ndk/$(ls -1 $ANDROID_HOME/ndk)"
Android studio:
CompileCommand: exclude com/intellij/openapi/vfs/impl/FilePartNodeRoot.trieDescend bool exclude = true
Android Studio Koala | 2024.1.1
Build #AI-241.15989.150.2411.11948838
Note that 'pnpm tauri android dev --open' starts compiling and then opens android studio.

Confirm for both bun run tauri android dev and npm run tauri android dev. It only works with cargo tauri android dev. My hinge would be that PackageManager::from_project in npm.rs file was not called in tauri-cli/src/mobile/android/dev.rs file.
But I just cloned down the repo so not really surprise if this call is extracted out somewhere else.

Just an update. I tried to install the tauri-cli in cargo and it failed to compile with the below errors. This might help you understand further what is going on.
Compiling java-properties v2.0.0
Compiling which v6.0.3
Compiling jsonrpsee-server v0.24.4
error[E0432]: unresolved import tower::util
--> /home/xenoha/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jsonrpsee-server-0.24.4/src/utils.rs:37:12
|
37  | use tower::util::Oneshot;
|            ^^^^ could not find util in tower
|
note: found an item that was configured out
--> /home/xenoha/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tower-0.4.13/src/lib.rs:215:9
|
215 | pub mod util;
|         ^^^^
note: the item is gated behind the util feature
--> /home/xenoha/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tower-0.4.13/src/lib.rs:213:7
|
213 | #[cfg(feature = "util")]
|       ^^^^^^^^^^^^^^^^
error[E0432]: unresolved import tower::ServiceExt
--> /home/xenoha/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jsonrpsee-server-0.24.4/src/utils.rs:38:5
|
38  | use tower::ServiceExt;
|     ^^^^^^^----------
|     |      |
|     |      help: a similar name exists in the module: Service
|     no ServiceExt in the root
|
note: found an item that was configured out
--> /home/xenoha/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tower-0.4.13/src/lib.rs:223:34
|
223 | pub use self::util::{service_fn, ServiceExt};
|                                  ^^^^^^^^^^
note: the item is gated behind the util feature
--> /home/xenoha/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tower-0.4.13/src/lib.rs:220:7
|
220 | #[cfg(feature = "util")]
|       ^^^^^^^^^^^^^^^^
Compiling notify v6.1.1
error[E0599]: the method graceful_shutdown exists for struct Pin<&mut UpgradeableConnection<'_, ..., ..., ...>>, but its trait bounds were not satisfied
--> /home/xenoha/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jsonrpsee-server-0.24.4/src/server.rs:1233:19
|
1233 |                 conn.as_mut().graceful_shutdown();
|                               ^^^^^^^^^^^^^^^^^ method cannot be called on Pin<&mut UpgradeableConnection<'_, ..., ..., ...>> due to unsatisfied trait bounds
|
::: /home/xenoha/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-util-0.1.9/src/rt/tokio.rs:16:1
|
16   | pub struct TokioExecutor {}
| ------------------------ doesn't satisfy _: HttpServerConnExec<TowerToHyperServiceFuture<<HttpMiddleware as Layer<TowerServiceNoHttp<RpcMiddleware>>>::Service, Request<Body>>, Body>
|
= note: the full type name has been written to '/tmp/cargo-installlrudBG/release/deps/jsonrpsee_server-d2a922bd19a60316.long-type-8540593724089480555.txt'
= note: consider using --verbose to print the full type name to the console
= note: the following trait bounds were not satisfied:
{type error}: Sized
which is required by TokioExecutor: HttpServerConnExec<utils::TowerToHyperServiceFuture<<HttpMiddleware as Layer<TowerServiceNoHttp<RpcMiddleware>>>::Service, hyper::Request<jsonrpsee_core::http_helpers::Body>>, Body>
error[E0599]: no method named oneshot found for type parameter S in the current scope
--> /home/xenoha/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jsonrpsee-server-0.24.4/src/utils.rs:61:60
|
51 | impl hyper::service::Service<HttpRequesthyper::body::Incoming> for TowerToH...
|      - method oneshot not found for this type parameter
...
61 |         TowerToHyperServiceFuture { future: self.service.clone().oneshot(req) }
|                                                                  ^^^^^^^ method not found in S
Some errors have detailed explanations: E0432, E0599.
For more information about an error, try rustc --explain E0432.
error: could not compile jsonrpsee-server (lib) due to 4 previous errors
warning: build failed, waiting for other jobs to finish...
error: failed to compile tauri-cli v2.0.0-rc.16, intermediate artifacts can be found at /tmp/cargo-installlrudBG.
To reuse those artifacts with a future compilation, set the environment variable CARGO_TARGET_DIR to that path.

Just to confirm, did you use this cmd cargo install<EMAIL_ADDRESS>to install the CLI?

To install the cli you currently need to use the --locked flag
cargo install tauri-cli --version "^2.0.0-rc" --locked

On first glance I don't see why this started to happen ~yesterday - got one or two reports on discord as well. I don't think it's that important to figure out though as the --locked flag is always recommended for cargo install commands (if you saw commands without the flag in our docs, please tell me, i've been searching for it earlier today after seeing that nobody uses it)

https://v2.tauri.app/start/create-project/
Is the link that describes the create project for V2. The only place it documents installing the tauri-cli is when you are doing manual install where it doesn't have the --locked flag. Does the cargo command for create-tauri-app install the cli? Will it need the locked flag?

v2.tauri.app/start/create-project

yeah i pushed an update shortly after i wrote the above comment but the build pipeline failed :/

Does the cargo command for create-tauri-app install the cli?

Only if you selected a npm/js frontend framework. It does not install the cargo cli. The npm cli does not need the locked flag

I had the same issue yesterday. After installing a fresh new project with npm create tauri-app@latest, the command npm run tauri android dev didn't do anything. After installing cargo install tauri-cli --version "^2.0.0" --locked (tauri-cli was already present in package.json, so I ran the cargo command) it's now working with npm run tauri android dev

I'm having the same issue on my Debian 12 desktop.  tauri andriod dev and tauri android dev --verbose  both hang with zero output.

I can confirm the same issue: npm run tauri android dev hangs and produces no output.
> npm run tauri info

I can confirm with @xdewx.
It would seem the solution to the problem is to have some Android device (hardware or emulated) detected by Android Studio. Once that's setup, the command npm run tauri android dev runs as intended and even works with multiple devices connected (a selection menu appears).
Here's my recommendations:

Update the documentation, specifically the "Quick Start" > "Prerequisites" > "Android" section. (https://tauri.app/start/prerequisites/#android)
There should be description of how to setup an Android device, both physical hardware and emulated. At very least, the documentation could link to the respective pages on the Android Developer documentation (https://developer.android.com/studio/run/device) and (https://developer.android.com/studio/run/managing-avds).
It is worth noting that the above works (see below), as well as opening up the Virtual Device Manager directly in Android Studio and running an AVD.

> ${ANDROID_HOME}/emulator/emulator -list-avds
> ${ANDROID_HOME}/emulator/emulator -avd ${AVD_NAME}

The script behind the npm run tauri android dev command should be updated. As of now, the command only works if the Android device is already setup prior to running the command. Running the command and then starting an Android device does not stop the hanging. Either the command should periodically poll the status of Android devices, or it should fail immediately if none are detected (could be an option to better support CI/CD pipelines). If a periodic polling strategy is implemented, it should give some indicator that it is waiting for a device. Something along the lines of:

> npm run tauri android dev

><EMAIL_ADDRESS>tauri
> tauri android dev

[INFO] Waiting for Android device to be connected... (see https://tauri.app/start/prerequisites/#android)

I can probably get both of these resolved if I find some time in the next couple of weeks, but someone else is certainly welcome to go right ahead!

I would like to cast my vote that, if polling is implemented, there should please be a way to disable it and just let it fail fast with a sensible error message.


update spec to 1.9.4, fix emoji matching, empty name

~Empty name handling still needs to be updated.~

Updates to readme

normalized name - a name that is in normalized form according to the ENS Normalization Standard. This means name == ens_normalize(name). A normalized name contains 0 or more labels. All labels in a normalized name always contain a sequence of at least 1 character. An empty string contains 0 labels and is a normalized name.

empty name - a name that is the empty string. An empty string is a name with 0 labels. It is a normalized name.

# note: might remove all characters from the input, which would result in an empty name
ens_cure('?')
# '' (empty string)
# reason: '?' is disallowed and no replacement can be suggested

List of all DisallowedSequence types
Disallowed name errors are not considered curable because it may be challenging to suggest a specific normalization suggestion that might resolve the problem.

DisallowedSequenceType
General info
Explanation

NSM_REPEATED
Contains a repeated non-spacing mark
Non-spacing marks can be encoded as one codepoint with the preceding character, which makes it difficult to suggest a normalization suggestion

NSM_TOO_MANY
Contains too many consecutive non-spacing marks
Non-spacing marks can be encoded as one codepoint with the preceding character, which makes it difficult to suggest a normalization suggestion

CONF_WHOLE
Contains visually confusing characters from {script1} and {script2} scripts
Both characters are equally likely to be the correct character to use and a normalization suggestion cannot be provided

Empty names are now allowed. However, non-empty fully-ignorable names are disallowed.
This is why the EMPTY_NAME error has to stay. If the input consists only of ignorable characters it cannot be normalized or cured. So the meaning of the EMPTY_NAME error has somewhat changed.

@lightwalker-eth I updated the readme according to your feedback.
I decided to avoid adding the "hollow label" definition because I think it is no longer needed thanks to the removal of EMPTY_NAME.
I also don't think that defining a "normalized label" separately is the right choice because that is already described in ENSIP-15. I think operating on "name" definitions is safer, as it relies directly on ENSIP-15. We make the jump from label to name once and then focus on just names.
Let me know if you have more ideas.

EMPTY_NAME is removed and the old curable EMPTY_LABEL error takes over that functionality.
nick.<optional ignorable characters>.eth throws EMPTY_LABEL with a cure .<optional ignorable characters>. -> . and a fully ignorable name also throws this error with a cure to replace the ignored characters with the empty string.
The empty string as input is no-error.


Shadow theme components and styles missing in production build

Bug Report
Seems like the issue in https://github.com/doczjs/docz/issues/1056 may not have been fully resolved. Still some things are not being set up properly in a production build.
It's ok if you run yarn dev before you build and serve, but if you don't then some things are missing from the production build, such as shadowed theme components and styles.
To Reproduce
Compare:
git clone https://github.com/LN-Zap/zap-tutorials
cd zap-tutorials
yarn develop

with:
git clone https://github.com/LN-Zap/zap-tutorials
cd zap-tutorials
yarn build
yarn serve

Notice that the header looks completely different - this is because the shadow components and styles are missing if you don't dev before you build.

I am also facing this issue and I won't be able to build a production version until this is fixed. My shadow components are based on my company's style guide and it won't look correct without it.

Hey,
As @brandonarbini said in #967 the issue is that docz is not copying the base directory (defaults to src) to the .docz directory before building and relying on dev being called before build.
If someone would like to submit a PR to fix it I'd be happy to help/review/merge.
If you can't, no problem. I'll get to it later this week !

Hey this was fixed in [2.0.0-rc.42]
(https://github.com/doczjs/docz/releases/tag/v2.0.0-rc.42)
Could you give the latest rc a try ?

Hi,
No this still doesn't work correctly.
Compare a build of https://github.com/LN-Zap/zap-tutorials with/without doing yarn dev first.

Should be fixed in 2.0.0-rc.51 tried zap-tutorials locally with it and it worked. Could you confirm ?

Hmmm I think the update didn't go right, here's what it looks like after running yarn add docz@next on my installation :

Could you try removing your yarn.lock file .docz folder and node_modules and trying again ?
rm -rf .docz node_modules yarn.lock && yarn add docz@next && yarn docz build && yarn docz serve

Ok, my bad. I guess I had a stale lock file and some old deps. Looks good now. Thanks for working on this 👍

Hello,
It looks like the issue is still here when the themesDir option in doczrc.js is set to a value other than 'src'. After investigation I think it is caused by this line in which gatsby-theme-docz is copied to docz's folder but themesDir is preserved in the destination path instead of coping it to .docz/src/.
For example:
// doczrc.js
export default {
  // ...
  themesDir: 'theme',
  // ...
}

Will give the following structure:
.
├─┬ .docz/
│ ├── src/
│ └─┬ theme/
│   └── gatsby-theme-docz/
├── src/
└─┬ theme/
  └── gatsby-theme-docz/

theme/gatsby-theme-docz/ is copied to .docz/theme/gatsby-theme-docz/ instead of .docz/src/gatsby-theme-docz/.
I can submit a PR to fix it if it helps.

Hey @simonrelet
Thanks for reporting this, a PR would be great !

It looks like the issue is still here when the themesDir option in doczrc.js is > set to a value other than 'src'. After investigation I think it is caused by this line  in which gatsby-theme-docz is copied to docz's folder but themesDir is > preserved in the destination path instead of coping it to .docz/src/.

I agree 👍
Feel free to join the project's slack if you have any questions or face an issue while submitting : slack link.

This should be fixed by @simonrelet's PR released in 2.0.0-rc.64.
Versions >= 2.0.0-rc.64 should work as expected. Going to close this, please feel free to re-open if it occurs again.


ScrollView + LazyVGrid jumps around when scrolling backward

I have a LazyVGrid inside a Scrollview.. scrolling from start to finish works great , as I scroll backward the scrollview jumps around.. I think the issue is the scrollview content size for each grid item is changing.  If I hard code the frame of the image it no longer hitches. I think I should be able to do that as all my images are the same size.. but I didn't run into this issue when trying other image caching frameworks like SDWebImageSwiftUI for example.  Just thought you might want to know if it's something that can be looked at.

ScrollView {

    LazyVGrid(columns: columnLayout) {

        ForEach(settings.wallpaperDataFiltered, id: \.guid) { wallpaper in

            ZStack {
                NavigationLink(destination: WallpaperUI()) {

                    KFImage.url(URL(string: wallpaper.thumbUrl))
                              .fade(duration: 0.25)
                              .resizable()
                              .aspectRatio(contentMode: .fit)

                }

            }

        }

    }

}

I had similar issue, you might need to check below

is URL is http/https? otherwise URLCache doesn't cache it. https://developer.apple.com/documentation/foundation/url_loading_system/accessing_cached_data. "Currently, only HTTP and HTTPS responses are cached. For FTP and file URLs, the only effect of a policy is to determine whether the request is allowed to access the originating source."
is url URLCache has enough memory / diskspace? you can check it by printing .imageCache.currentDiskUsage, .imageCache.currentMemoryUsage

Maybe a little bit late... but from my experience using the .aspectRatio(..) modifier with aspectRatio: CGSize parameter helps SwiftUI to calculate the layout and dramatically improves scrolling performance and may fix your described behaviour. But it would require to know the dimensions of the resource before requesting.


fixed typo that prevented build from succeeding

Error: "themes\hugo-whisper-theme\layouts_default\baseof.html:30:1": parse master failed: template: index.html:30: function "site" not defined

looks like it builds on Netlify now, thanks mate!


GitHub Enterprise/Cloud support

Add support for GitHub Enterprise and Cloud.

Checkmarx One – Scan Summary & Details – f2c948eb-7b61-492e-a2a8-8ccc639c9788
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Log_Forging
/wsgi.py: 57
Attack Vector

Log_Forging
/wsgi.py: 57
Attack Vector


Deleting a volume will not delete its PV/PVC.

Using UI:

Create a volume.
Create PV/PVC
Delete the volume.

Using kubectl get pv

PV/PVC not deleted.

We need to think more about deleting a volume.
Currently deleting a volume won't be blocked by any operations.

PV can be deleted while deleting the volume. But PVC is the declaration of a workload. User can manually create it for its workload. I don't think we can just delete it.
If there is workload current using the volume, should we allow deleting the volume? Or, should we even allow detach the volume?

keep it open

@joshimoo and I had a discussion regarding handling of Volume deletion in various cases in which a PersistentVolume and PersistentVolumeClaim are involved. This is what we eventually decided on:

It's possible that there are other inactive workloads such as a Deployment scaled to zero Pods that depend on the Volume. While we'd be able to successfully delete the PersistentVolume and PersistentVolumeClaim, it would cause problems once the Deployment scales back up and discovers that the PersistentVolumeClaim and other resources that it depends on no longer exists. We determined that it might be best to warn the user before deletion that there is a PersistentVolume and possibly PersistentVolumeClaim related to the Volume and  to be aware in case that it affects their workloads. Afterwards, they can delete the Volume with the option to have Longhorn handle the PersistentVolume and PersistentVolumeClaim deletion for them.
Deleting a Volume with running workloads would cause obvious problems for the end user, and we should at the very least, block a user from deleting a Volume that has a workload attached.

I think it's safe to go ahead with working on the second case and preventing deletion of Volumes with associated workloads. As for the first case, @yasker do you have any additional thoughts on how this should be handled? Or does this look good and can we proceed with implementing it?

@ttpcodes
I've thought about this a bit more.

We should know if the volume is referred by a PV and PVC, since any reference to the PVC will be written in the claimRef in the PV. We also know if the workload using the volume exists or not. We can provide information to the user, and make sure user checks the confirmation checkbox before deleting the volume.
Preventing the user from deleting an arbitrary volume is kind of preventing him from shooting himself in the foot. But if he insists on doing so, we shouldn't stand in the way. Just make sure we give a big enough warning for it.

Another thing I have a bit concern is, deleting a PV/PVC created from Longhorn UI should be straightforward, but how about PV/PVC created using StorageClass? There might be some complications there. We need that in the test plan.
Also, how are we going to implement this on the API level? We need some designs.
Can you prepare a Longhorn Enhancement Proposal for this? Thanks.

Pre-merged Checklist

[X] Does the PR include the explanation for the fix or the feature?

[X] Is the backend code merged (Manager, Engine, Instance Manager, BackupStore etc)?
The PR is at longhorn/longhorn-manager#1528.

[X] Is the reproduce steps/test steps documented?

[ ] Which areas/issues this PR might have potential impacts on?
Area: kubernetes, manager
Issues: #520

[X] If the fix introduces the code for backward compatibility Has an separate issue been filed with the label release/obsolete-compatibility?

[ ] If labeled: area/ui Has the UI issue filed or ready to be merged?
The UI issue/PR is at longhorn/longhorn-ui#301.

[ ] if labeled: require/doc Has the necessary document PR submitted or merged?
The Doc issue/PR is at

[ ] If labeled: require/automation-e2e Has the end-to-end test plan been merged? Have QAs agreed on the automation test case?
The automation skeleton PR is at
The automation test case PR is at

[X] if labeled: require/automation-engine Has the engine integration test been merged?

[ ] if labeled: require/manual-test-plan Has the manual test plan been documented?
The updated manual test plan is at

A number of cases need to be manually tested in the longhorn-ui. To test these cases, create the Volume with the specified conditions in each case, and then try to delete it. What is observed should match what is described in the test case:

A regular Volume. Only the default deletion prompt should show up asking to confirm deletion.
A Volume with a Persistent Volume. The deletion prompt should tell the user that there is a Persistent Volume that will be deleted along with the Volume.
A Volume with a Persistent Volume and Persistent Volume Claim. The deletion prompt should tell the user that there is a Persistent Volume and Persistent Volume Claim that will be deleted along with the Volume.
A Volume that is Attached. The deletion prompt should indicate what Node the Volume is attached to and warn the user about errors that may occur as a result of deleting an attached Volume.
A Volume that is Attached and has a Persistent Volume. The deletion prompt should contain the information from both test cases 2 and 4.

Additionally, here are bulk deletion test cases that need testing:

1+ regular Volumes. Only the default deletion prompt should show up asking to confirm deletion.
1+ Volumes with a Persistent Volume.  The deletion prompt should list the Persistent Volumes associated with the Volumes and tell the user that these will also be deleted.
0+ regular Volumes and 1+ Volumes that are Attached. The deletion prompt should list only Volumes that are Attached and tell the user that applications using them may encounter errors once the Volumes are deleted.
0+ regular Volumes, 1+ Volumes with a Persistent Volume, and 1+ Volumes that are Attached. The information described in test cases 2 and 3 should be displayed.

Finally, there are some other test cases to check here:

Create a Volume and create a Persistent Volume and Persistent Volume Claim through the longhorn-ui. Delete the Persistent Volume Claim manually. Delete the Volume. The deletion prompt should not list the Persistent Volume Claim that was deleted in the list of resources to be deleted.
Create a Disaster Recovery Volume. Delete the Disaster Recovery Volume. The deletion prompt should not give a warning about errors that may occur from deleting an attached Volume.
Create a Volume from a Backup. While the Volume is still being restored, delete the Volume. The deletion prompt should not give a warning about errors that may occur from deleting an attached Volume.

Note that not all of these tests will pass yet (since some points like bulk deletion case #3 are not addressed yet).

Validation: PASSED
Steps (1/2):

Create a volume, create a PV.
Delete the volume, UI will warn about PV deletion, PV will get deleted.

Steps (2/2):

Create a volume, create a PV/PVC
Delete the volume, UI will warn about PV/PVC deletion, PV & PVC will get deleted.


Wrong Unit

Wrong unit of consumption

solved 0.5.4 https://github.com/iobroker-community-adapters/ioBroker.discovergy/commit/ae439861b1c8691ab0cc921837843b78b56cf027


Added mechanism to override device attestation failure based on client/user

Fixes #16681
Change overview
Added delegates that can be optionally set by the client of the SDK.
When the device attestation delegate is set and when a DA failure is
encountered during commissioning, the delegate is invoked letting the
client decide on the behavior to either ignore the error and continue
commissioning or fail the commissioning. The arm failsafe timer can also
be adjusted by the client to handle any delays due to user input.
Testing
Flashed an M5 with the changes. Used the iOS CHIPTool with the changes
and verified no regression in current commissioning process when the
delegate is either setup or not.
Modified the kTestPaaRoots array in DefaultDeviceAttestationVerifier.cpp
to be empty causing DA failure. Verified the dialog is presented to the
user and that commissioning succeeds with error is ignored and fails
when the user declines to proceed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/rebase