Failed to publish inline comments

Some suggestions failed to publish via pr_agent.algo.ai_handlers.litellm_ai_handler
Bellow is the output:
And here is a list of corresponding 5 code suggestions to improve this Pull Request code:
======
suggestion 1: {'relevant_file': 'bin/aws-efs-creator.ts\n', 'language': 'TypeScript\n', 'suggestion_content': 'To improve readability and maintainability, consider combining the environment variable names into a single array and passing it to the `checkEnvVariables` function.\n', 'existing_code': "checkEnvVariables('APP_NAME',\n'OWNER',\n'VPC_ID',\n'CDK_DEPLOY_REGION',\n'ENVIRONMENT',\n'PERFORMANCE_MODE',\n'THROUGHPUT_MODE',\n);\n", 'improved_code': "const requiredEnvVars = [\n  'APP_NAME',\n  'OWNER',\n  'VPC_ID',\n  'CDK_DEPLOY_REGION',\n  'ENVIRONMENT',\n  'PERFORMANCE_MODE',\n  'THROUGHPUT_MODE',\n];\ncheckEnvVariables(...requiredEnvVars);\n", 'one_sentence_summary': 'Combine environment variable names into a single array for improved readability and maintainability.\n', 'relevant_lines_start': 18, 'relevant_lines_end': 25, 'label': 'enhancement\n'}

suggestion 2: {'relevant_file': 'lib/aws-efs-creator-stack.ts\n', 'language': 'TypeScript\n', 'suggestion_content': 'Add a default case to the `parsePerformanceMode` and `parseThroughputMode` functions to handle undefined or empty strings, providing a more user-friendly error message.\n', 'existing_code': "switch (performanceMode) {\n  case 'GENERAL_PURPOSE':\n    return efs.PerformanceMode.GENERAL_PURPOSE;\n  case 'MAX_IO':\n    return efs.PerformanceMode.MAX_IO;\n  default:\n    throw new Error(`Invalid performance mode: ${performanceMode}`);\n}\n", 'improved_code': "switch (performanceMode) {\n  case 'GENERAL_PURPOSE':\n    return efs.PerformanceMode.GENERAL_PURPOSE;\n  case 'MAX_IO':\n    return efs.PerformanceMode.MAX_IO;\n  default:\n    if (!performanceMode) {\n      throw new Error('Performance mode is not defined.');\n    }\n    throw new Error(`Invalid performance mode: ${performanceMode}`);\n}\n", 'one_sentence_summary': 'Add a default case to handle undefined or empty performance mode strings.\n', 'relevant_lines_start': 9, 'relevant_lines_end': 15, 'label': 'error handling\n'}

suggestion 3: {'relevant_file': 'lib/aws-efs-creator-stack.ts\n', 'language': 'TypeScript\n', 'suggestion_content': 'Add a default case to the `parseThroughputMode` function to handle undefined or empty strings, providing a more user-friendly error message.\n', 'existing_code': "switch (throughputMode) {\n  case 'BURSTING':\n    return efs.ThroughputMode.BURSTING;\n  case 'PROVISIONED':\n    return efs.ThroughputMode.PROVISIONED;\n  case 'ELASTIC':\n    return efs.ThroughputMode.ELASTIC;\n  default:\n    throw new Error(`Invalid throughput mode: ${throughputMode}`);\n}\n", 'improved_code': "switch (throughputMode) {\n  case 'BURSTING':\n    return efs.ThroughputMode.BURSTING;\n  case 'PROVISIONED':\n    return efs.ThroughputMode.PROVISIONED;\n  case 'ELASTIC':\n    return efs.ThroughputMode.ELASTIC;\n  default:\n    if (!throughputMode) {\n      throw new Error('Throughput mode is not defined.');\n    }\n    throw new Error(`Invalid throughput mode: ${throughputMode}`);\n}\n", 'one_sentence_summary': 'Add a default case to handle undefined or empty throughput mode strings.\n', 'relevant_lines_start': 25, 'relevant_lines_end': 33, 'label': 'error handling\n'}

suggestion 4: {'relevant_file': 'lib/aws-efs-creator-stack.ts\n', 'language': 'TypeScript\n', 'suggestion_content': 'Add validation to ensure `performanceMode` and `throughputMode` are not undefined before parsing, to prevent runtime errors.\n', 'existing_code': 'const performanceMode = parsePerformanceMode(props.performanceMode);\nconst throughputMode = parseThroughputMode(props.throughputMode);\n', 'improved_code': "if (!props.performanceMode) {\n  throw new Error('Performance mode is not defined.');\n}\nif (!props.throughputMode) {\n  throw new Error('Throughput mode is not defined.');\n}\nconst performanceMode = parsePerformanceMode(props.performanceMode);\nconst throughputMode = parseThroughputMode(props.throughputMode);\n", 'one_sentence_summary': 'Add validation to ensure `performanceMode` and `throughputMode` are defined before parsing.\n', 'relevant_lines_start': 38, 'relevant_lines_end': 39, 'label': 'error handling\n'}

suggestion 5: {'relevant_file': 'lib/aws-efs-creator-stack.ts\n', 'language': 'TypeScript\n', 'suggestion_content': 'Consider making the `performanceMode` and `throughputMode` properties optional in `AwsEfsCreatorStackProps` and provide default values if they are not set.\n', 'existing_code': 'readonly performanceMode: string;\nreadonly throughputMode: string;\n', 'improved_code': 'readonly performanceMode?: string;\nreadonly throughputMode?: string;\n', 'one_sentence_summary': 'Make `performanceMode` and `throughputMode` optional and provide default values if not set.\n', 'relevant_lines_start': 27, 'relevant_lines_end': 31, 'label': 'enhancement\n'}
======

Response (should be a valid YAML and nothing else):
```yaml
2024-06-22 22:19:03.942 | INFO     | pr_agent.algo.ai_handlers.litellm_ai_handler:chat_completion:168 -
AI response:
code_suggestions:
- suggestion_summary: |
    Combine environment variable names into a single array for improved readability and maintainability.
  relevant_file: "bin/aws-efs-creator.ts"
  suggestion_score: 8
  why: |
    This suggestion correctly identifies an improvement in code maintainability and readability by consolidating multiple parameters into a single array, which simplifies the function call.

- suggestion_summary: |
    Add a default case to handle undefined or empty performance mode strings.
  relevant_file: "lib/aws-efs-creator-stack.ts"
  suggestion_score: 7
  why: |
    Adding a default case for undefined or empty strings in the `parsePerformanceMode` function is a valid error handling improvement, enhancing the robustness of the code.

- suggestion_summary: |
    Add a default case to handle undefined or empty throughput mode strings.
  relevant_file: "lib/aws-efs-creator-stack.ts"
  suggestion_score: 7
  why: |
    Similar to the previous suggestion, adding a default case for undefined or empty strings in the `parseThroughputMode` function is a good practice for error handling, improving code reliability.

- suggestion_summary: |
    Add validation to ensure `performanceMode` and `throughputMode` are defined before parsing.
  relevant_file: "lib/aws-efs-creator-stack.ts"
  suggestion_score: 7
  why: |
    This suggestion enhances error handling by ensuring necessary properties are defined before they are used, which prevents potential runtime errors.

- suggestion_summary: |
    Make `performanceMode` and `throughputMode` optional and provide default values if not set.
  relevant_file: "lib/aws-efs-creator-stack.ts"
  suggestion_score: 6
  why: |
    Making properties optional and providing default values can increase the flexibility of the code. However, the impact of this change depends on whether default values are appropriate for the application context.
2024-06-22 22:19:06.143 | ERROR    | pr_agent.git_providers.github_provider:publish_inline_comments:292 - Failed to publish inline comments
2024-06-22 22:19:25.027 | INFO     | pr_agent.git_providers.github_provider:_publish_inline_comments_fallback_with_verification:330 - Published invalid comment as a single line comment: {'body': '**Suggestion:** Add a default case to the `parsePerformanceMode` and `parseThroughputMode` functions to handle undefined or empty strings, providing a more user-friendly error message.\n> 🏡  **Medium Priority** \n > [category: error handling, importance: 7]\n', 'path': 'lib/aws-efs-creator-stack.ts', 'line': 9, 'side': 'RIGHT'}
2024-06-22 22:19:26.347 | ERROR    | pr_agent.git_providers.github_provider:publish_inline_comments:292 - Failed to publish inline comments
2024-06-22 22:19:26.348 | ERROR    | pr_agent.git_providers.github_provider:_publish_inline_comments_fallback_with_verification:333 - Failed to publish invalid comment as a single line comment: {'body': '**Suggestion:** Add a default case to the `parseThroughputMode` function to handle undefined or empty strings, providing a more user-friendly error message.\n> 🏔  **Medium Priority** \n > [category: error handling, importance: 7]\n', 'path': 'lib/aws-efs-creator-stack.ts', 'line': 25, 'side': 'RIGHT'}
2024-06-22 22:19:27.264 | ERROR    | pr_agent.git_providers.github_provider:publish_inline_comments:292 - Failed to publish inline comments
2024-06-22 22:19:27.265 | ERROR    | pr_agent.git_providers.github_provider:_publish_inline_comments_fallback_with_verification:333 - Failed to publish invalid comment as a single line comment: {'body': '**Suggestion:** Consider making the `performanceMode` and `throughputMode` properties optional in `AwsEfsCreatorStackProps` and provide default values if they are not set.\n> ⛴  **Medium Priority** \n > [category: enhancement, importance: 6]\n', 'path': 'lib/aws-efs-creator-stack.ts', 'line': 27, 'side': 'RIGHT'}

Checkout the real result on GitHub via: https://github.com/SofarDatas/aws-efs-creator/pull/13

i could not reproduce
https://github.com/SofarDatas/aws-efs-creator/pull/13#discussion_r1649934362

maybe some temporal problem with openai\internet_connection...
If you have a recipe that can reproduce, share

i could not reproduce
https://github.com/SofarDatas/aws-efs-creator/pull/13#discussion_r1649934362

maybe some temporal problem with openai\internet connection\ ...
If you have a recipe that can reproduce, share

I will do that, thanks for your quick response.


Breaks build when used with CKEditor5 styles

We're trying to update CKEditor5 to v34 in our Nuxt apps. One of the major changes was a switch to PostCSS 8. Following the instructions for this package breaks our build in a peculiar way.
We had it working working with CKEditor5 v33 and PostCSS 7. Our current version of Nuxt is 2.15.8.
The only difference between our previous and current config is the addition of @nuxt/postcss8 in buildModules. Here is the relevant part in our current nuxt.config.ts:
const CKEditorWebpackPlugin = require("@ckeditor/ckeditor5-dev-webpack-plugin");
const { styles } = require("@ckeditor/ckeditor5-dev-utils");

export default {
  // ...
  build: {
    // ...
    transpile: [
      /ckeditor5-[^/\\]+[/\\]src[/\\].+\.js$/
    ],
    plugins: [
      new CKEditorWebpackPlugin({
        language: "en",
        additionalLanguages: ['fr'],
        buildAllTranslationsToSeparateFiles: true
      })
    ],
    postcss: styles.getPostCssConfig({
      themeImporter: {
        themePath: require.resolve("@ckeditor/ckeditor5-theme-lark")
      },
      minify: true
    }),
    extend(config) {
      config.module.rules.push({
        test: /ckeditor5-[^/\\]+[/\\]theme[/\\]icons[/\\][^/\\]+\.svg$/,
        use: ["raw-loader"]
      });
    }
  },
  buildModules: [
    ["@nuxt/typescript-build", {
      ignoreNotFoundWarnings: true,
      typescript: {
        typeCheck: {
          memoryLimit: 150,
          workers: 1
        }
      }
    }],
    "@nuxtjs/moment",
    '@nuxtjs/gtm',
    "@nuxt/postcss8",
    'vue-browser-detect-plugin/nuxt'
  ],
  // ...
}

The error output when we run nuxt build:
FATAL  Cannot find module '0'
Require stack:
-<EMAIL_ADDRESS>
  Require stack:
  -<EMAIL_ADDRESS>  at Function.Module._resolveFilename (internal/modules/cjs/loader.js:902:15)
  at Function.resolve (internal/modules/cjs/helpers.js:107:19)
  at _resolve (node_modules/jiti/dist/jiti.js:1:192841)
  at Resolver.jiti [as _require] (node_modules/jiti/dist/jiti.js:1:195025)
  at Resolver.requireModule (node_modules/@nuxt/core/dist/core.js:381:29)
  at node_modules/@nuxt/webpack/dist/webpack.js:792:58
  at Array.map (<anonymous>)
  at PostcssConfig.loadPlugins (node_modules/@nuxt/webpack/dist/webpack.js:791:10)
  at PostcssConfig.config (node_modules/@nuxt/webpack/dist/webpack.js:830:14)
  at StyleLoader.postcss (node_modules/@nuxt/webpack/dist/webpack.js:909:39)
  at StyleLoader.apply (node_modules/@nuxt/webpack/dist/webpack.js:969:12)
  at WebpackClientConfig.rules (node_modules/@nuxt/webpack/dist/webpack.js:1357:28)
  at WebpackClientConfig.config (node_modules/@nuxt/webpack/dist/webpack.js:1537:21)
  at WebpackClientConfig.config (node_modules/@nuxt/webpack/dist/webpack.js:1708:26)
  at WebpackBundler.getWebpackConfig (node_modules/@nuxt/webpack/dist/webpack.js:2016:19)
  at WebpackBundler.build (node_modules/@nuxt/webpack/dist/webpack.js:2023:12)

If "@nuxt/postcss8" or the postcss configuration postcss: styles.getPostCssConfig({ are removed the error disappears.
The only changes to the dependancies are @nuxt/postcss8 and the various CKEditor5 packages updated to latest. May be worth noting that the exact same error occurs with CKEditor5 v33 as soon as @nuxt/postcss8 is added.

After digging a bit, I can see that part of the issue is caused by styles.getPostCssConfig() provided by "@ckeditor/ckeditor5-dev-utils" returning an array of plugins. I set up a reducer to to convert to an object using the postcssPlugin as keys, however issues persist.
"@ckeditor/ckeditor5-dev-utils" is returning an array of objects that look like this example:
{
  postcssPlugin: 'postcss-ckeditor5-theme-importer',
  Once( root, { result } ) {
    // Clone the options, don't alter the original options object.
    const options = Object.assign( {}, pluginOptions, {
      debug: pluginOptions.debug || false,
      postCssOptions: {
        plugins: [
          require( 'postcss-import' )(),
          require( './themelogger' )()
        ]
      },
      root, result
    } );

    return importThemeFile( options );
  }
}

From what I can make out the plugins themselves are provided and should not be imported via require as they do not exist in node_modules.
This approach was functioning until @nuxt/postcss8 was added. I feel as though I'm approaching the limits of my understanding of the config generation. Any insight will be greatly appreciated.


Change icon in map for caches with offline log

Imagine there are several similar caches located in a small area. All are saved in a list, but the names are long with a appending number. So they are hard to distinguish. On the map started from the list all look also the same because they are of the same type. Now during the cache tour every cache is logged offline as found (or DNF) and in the list they are marked. But on the map they look still similar.
It would be an improvement to "mark" them also on the map. Maybe an overlay or a slightly changed color could do it.

Sounds good to me. The same icon as 'found' but with a more reddish tone perhaps?

I put a suggestion in my repo: 07188afbe7c8ddb660366831dc46c2df6efe6f89

Looks good. The color is similar to the orange used in the list.

I don't think so. And if should a refresh do the trick as well. I am currently working on #1042 and experience the same problems with the internal flags I introduced for this. In continuing working on this I'll investigate additionally the associated live-map issues.

Another remark for my example:

The offline marker in list is not shown when I initially open the list with my caches with offline-log
Access a cache from list
Open log-page, the offline-log text is shown.
Go back to the list
The offline marker is now shown
Leave c:geo, Open c:geo again and access the list
The offline-marker is still shown
Leave lists and open live map
Scroll to the position of this cache
Caches is shown without orange smiley
Go back to lists
The offline-marker is gone also from the list

So it seems the live map overwrites the flag ?!
Tested with NB1102

Not only the live map seems to override the flag:

Open list: The offline marker is not shown
Open Cache
Go back to list: the offline marker is shown
Go to map view from list: The orange smiley isn't present
Go back to list: the offline marker is not shown

So the offline marker isn't shown on initial opening the list and after returning from (any?) map. Also in the map the orange smiley isn't shown.

This bug is handled in #1059 as well. So it is not a problem with the implementation as such but with the handling in teh CachesCache

I experimented with offline logging for the first time while caching and experienced problems as related above. In summary:

Offline log marker is never shown on the map view (only in lists)
Some caches showed with green bar in the lists and some with an orange bar after marking them found. I couldn't figure out a difference as to why for each one. Closing c:geo (through Manage Applications / Force Stop) and then reopening made all the bars become orange (as they should be, I think)
Prior to completely closing c:geo if I exited to the phone's home screen and then went back into c:geo (it stayed in memory) and went back to my list, none of the caches showed as logged at all. The marker only appeared after viewing each cache.
Sometimes (can't always reproduce, but I think one way was to log found and then DNF), the list would show a green marker fading into an orange one (green at top, orange at bottom). Is this programmed in or a bug from something?

Overall, many bugs still to be worked out with this.

@campbeb Here I just brought the marker to the map. The orange marker signifies the existence of an offline log regardless of type and so does currently the smiley on the map. As the online status only reflects the 'found' log (with smiley and green marker) this is somewhat inconsistent but the offline marker signals a 'visited' status which is probably what most people want to see. As we do not have markers for the other log types (note, DNF, etc) I am not sure if and how we should differentiate here.
Regarding the double-colored marker, this is partly bug partly as intended. A cache can be both online found and offline logged, so green-orange is possible. In your case it is probably due to a glitch in my current implementation which I tried to remedy with my last commit.


Fixed bug in pm2-deploy with wrong branch clones

Github issue: https://github.com/Unitech/pm2/issues/3636

:+1: !


AzureBlob File Copy does not upload/timeout

Environment

Server - Azure Pipelines or TFS on-premises?
Azure DevOps

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:
AccountName: scan2lead
TeamName: Scan2Lead
Release Definition: 2

Agent - Hosted or Private:
- If using private agent, provide the OS of the machine running the agent and the agent version:
Private:
Windows10 x64, 10.0.17134
Agent Version: 2.141.1
AzurePS: 5.7.0
Agent is executed in the user context as console application (not service).

Issue Description
We're uploading build artifacts to azure and for some time now it's not possible to finish the task anymore.
The task comes to the point where it starts the upload and then suddenly stops and a timeout happen after 20+ minutes.
The earlier release definition contained the file copy task v1 and I changed it to v2 with the same error result.
Task logs
I've sent the logs to<EMAIL_ADDRESS>as they contain sensitive informations.
One log is with normal output, the second is with debug on.
Error logs
Upload to container: '<name>' in storage account: '<name>' with blob prefix: '<name>' failed with error: 'AzCopy.exe exited with non-zero exit code while uploading files to blob storage.' For more info please refer to https://aka.ms/azurefilecopyreadme

@SeriousM Since this is a timeout issue, lowering the number of concurrent threads used by AzCopy might help resolve it. The /NC parameter is used to control the number of concurrent operations. Please try passing /NC:2 in the Additional Arguments of the Azure File Copy task and redploy the release.

Well, ok, that worked once, the next attempt died again: https://scan2lead.visualstudio.com/Scan2Lead/_releaseProgress?_a=release-environment-logs&releaseId=507&view=mine&environmentId=1689
But how is that possible? it's just about 100mb on 4 files (3x big, 1x 1kb). This is just not good...

We are investigating this further with the AzCopy team. Meanwhile, can you try running the AzCopy.exe command (mentioned in the logs) directly from your agent machine to see if there is any timeout.

the upload problem has stabilized but it's still very slow

Client timeout typically happens when the network condition is not good enough for transfer, and can be commonly mitigated by using lower number of transfer concurrency(NC).
I am suspecting the problem to be related to the network connectivity between agent and the Azure storage service and should get automatically resolved once the connectivity is good.

@SeriousM , Is the issue still persisting?

No, it's resolved now.


Fixed usage of non-Twig paths in profiler panel

Using SolariumBundle v2.3.0 with the latest versions of Symfony (3.3.2), Twig (2.4.3) and WebProfileBundle (3.3.2) the SOLR template in the profiler can not be loaded.
This PR fixes it :)
see: https://github.com/symfony/web-profiler-bundle/commit/50d6db262e70d0e1be39ed914db19d8b3f7a645e
and https://github.com/snc/SncRedisBundle/pull/337/files

Thanks


Versification API + UI

Using the versification components now in Storybook, re-implement versification in the crowd.Bible /versification page. You will need to use the new local graph API.
Versification Schema:

Designs on Figma:

@levpolshkov Svetlana is now done with the versification v1 wireframes. https://www.figma.com/file/md8nAIVfMUNxGhkofGhP6c/Wireframes?node-id=0%3A1&t=z6JvYVQGUvsgmUv4-1

I've learned that verses can be out of order and verse identifiers can be non numeric.
Updated schema:

this is an additive-only change.

closing as we are pausing this work until more features are finished/refactored?


Switched a feeds entry type setting. Getting error on import

Hey, thanks again for all your help with my other requests–much appreciated. I have been doing a little bit of refactoring and moved data from being stored in matrix blocks to entry types. This will improve searching entries, etc., in the application.
Currently, FeedMe is failing on import. I believe it has to do with the exisiting entry's entry type  being already set to a different type that what now the feed is set to. Any ideas on how I can get FeedMe to update the entry type when the feed's strategy is set to 'Add & Update Existing'

You currently can't set the entry type in your feed. This is because entries are essentially compartmentalised by section and entry type. It should only match against existing entries in the same section and entry type that you've specified for you feed. No logging information on the error as to why its failing?

That's correct. In the feed settings under 'Entry Type' the feed was originally set to a different type. I switched the 'Entry Type' over to a new type and it's failing. Does that make sense? Meaning:

Data imported in as 'Type 1' originally
On re-import, the data is set to 'Type 2' and the entry data and type of entry is not updated. FeedMe is failing.

Btw, I deleted the entries and started over just to keep working on things.

Do your two different entry types have different fields? Did you go through and re-map (and save) your fields after switching the entry type?

The entry types how their own set of fields. Re: re-mapping–I believe so but I can't confirm as it was a couple days ago. It may have been a user error (me). I'll run a test again to see if I can reproduce it in the next couple days.

Closing for the moment due to inactivity. Re-open if you have more issues.


change ndef payload to same as other app's payload data like nxp writer app

how can i change payload data get from this library to other apps payload data

=>payload from nfc tool app

=>payload from this library

@whitedogg13 please help!


Adding telemetry to network monitor

What this PR does / why we need it:
This PR adds telemetry capabilities to network monitoring of Eb rules.
It reports discrepancies to telemetry pipeline which can be viewed in jarvis.
Testing
To see the test logs go to this jarvis link
Which issue this PR fixes
Adaptation of this branch

/azp run

/azp run

/azp run

/azp run

/azp run


Style Utilities : Space for TOC

There should be more space between the utility section and TOC

Missing Header

Extra space above the TOC and some part of the red division line is missing

Duplicate issue exsit in #16
Current status of the issue : Transfered to issue no. #16
App Info :

Key
Value

Fronend URL
http://wrappid.framework.s3-website.ap-south-1.amazonaws.com/

Fronend Version
0.0.5

Desktop :

Key
Value

OS
Windows 11

Browser
Google Chrome

Version
120.0.6099.225 (Official Build) (64-bit)


[Vue] [Menu]: weird menu behavior on mobile (touch)

Description
While using the Menu component in an array of card items, I noticed a weird behavior.
 In particular they stay activated when using @click.stop on the menu trigger. (but only in chrome). When not using @click.stop they still stay open briefly, but then all close without any further action. This only seems to happen when working in "responsive design mode" however. So, I'm guessing it is related to some different handling of touch events vs click events maybe?
Link to Reproduction
https://stackblitz.com/edit/nuxt-starter-p9zbud?file=app.vue,components%2FCustomMenu.vue
Steps to reproduce

In the top right of stackblitz, click "Open in New Tab".
Open developer tools and enable "responsive design mode" or some mobile dev mode.
Click on a trigger.
Click on another trigger.
Witness odd behavior

Ark UI Version
0.4
Framework

[ ] React
[ ] Solid
[X] Vue

Browser
Latest Chrome and Firefox
Additional Information
No response

Hey @jiblett1000
Thanks for reporting this. This doesn't seem like a Vue only issue, i was able to reproduce that in other frameworks as well.
This is probably coming from Zag so i'm moving the issue elsewhere.

Closed in favor of this : https://github.com/chakra-ui/zag/issues/659


Add handler to AnyRequest

Is your feature request related to a problem? Please describe.
I tend to create services that serve multiple RPC services. The endpoints within the service are mixed public/private. For example
service UserService {
  Login(LoginRequest) returns (LoginResponse); // Public
  GetAccount(GetAccountRequest) returns (GetAccountResponse); // Private
}

As a consequence, I historically use grpc ecosystem's auth middleware, and my service handlers satisfy the ServiceAuthFuncOverride interface.
When setting out to port this interceptor to connect, I hit a dead end because I can not perform the ServiceAuthFuncOverride interface assertions on the handler. This is because AnyRequest does not have a reference to the matched handler.
Describe the solution you'd like
A mechanism to access the handler from AnyRequest, or (probably breaks the API) pass the handler to UnaryFunc.
Describe alternatives you've considered
I suppose an alternate lookup method is possible, but seems sub-optimal.
Additional context
I intend to do access control in this way within the service itself. This is also an ideal place for me to add policy information to context.Context that is later utilized in my database access layer.

We discussed this in Slack, but for posterity:
Luckily, connect-go doesn't need this degree of indirection. Something similar to the following should work:
type AuthFunc func(context.Context, connect.AnyRequest) (context.Context, error)

func WithAuthentication(f AuthFunc) connect.HandlerOption {
  return connect.WithInterceptors(&myAuthInterceptor{f})
}

// You'll have to implement connect.Interceptor.
type myAuthInterceptor {
  f AuthFunc
}

Then, you can construct your handlers like this:
impl := &myFooImplementation{}
// If *myFooImplementation has an Authenticate method that matches AuthFunc
h := foov1connect.NewFooHandler(impl, WithAuthentication(impl.Authenticate))
// Or you can use a global AuthFunc
h = foov1connect.NewFooHandler(impl, WithAuthentication(globalAuthFunc))

Ping us here or in Slack if you feel like open-sourcing your implementation :)


Delete stale branches

Is there any objection to delete stale branches, that were temporarily used, with prefix backport, fix names or just numbers ?
Of course not counting the release-<version>.x branches.

+1

@oscerd wdyt ?

+1 thx

Done, thanks.


PostgreSQL: new extension

Make fully-functional database extension for PostgreSQL

First version of the new extension completed.


Post preview length is affected by link

So I've been working on this website, and found out that the post preview length does not match the number of words I've set it to be.
Currently, just for example purposes this is what I have in my gutenberg editor. This paragraph, with a "more" block just under.
"This is an example post that it should be all displayed in the post preview because it has only 21 words."
With this line outputing the preview, I should be able to see this whole sentence
{{ post.preview.length(25).read_more(false).force }}
Which I can! But the problem starts when I had a link to the paragraph with the option - "open in new tab"

This is what the preview looks like with the link.

Now, I've discovered that when I check the HTML preview of this paragraph, it has all sorts of extra values (see image):

These extra values (target, rel, aria-label) are what is causing the preview to not match the words that I've set.
I've tried the strip setting also, but made no effect, as it is enabled by default anyways. Not sure what more I can do to solve this, so that's why I made this bug report. Looking forward for some answers regarding this issue. Thanks in advance.

Kind of strange because preview should strip those extra HTML tags first. I'll look into this. Probably there is wrong of operations somewhere

I've checked the code and I was right with the operation order.
As you use <!--more--> first we use
if ( !strlen($text) && preg_match('/<!--\s?more(.*?)?-->/', $this->post->post_content, $readmore_matches) ) {
			$pieces = explode($readmore_matches[0], $this->post->post_content);
			$text = $pieces[0];
			if ( $force ) {
				if ( $allowable_tags ) {
					$text = TextHelper::trim_words($text, $len, false, strtr($allowable_tags, '<>', '  '));
				} else {
					$text = TextHelper::trim_words($text, $len, false);
				}
				if ( $chars !== false ) {
					$text = TextHelper::trim_characters($text, $chars, false);
				}
				$trimmed = true;
			}
			$text = do_shortcode($text);
		}

$allowable_tags is false so we trim_words first. Later, as $strip is true we launch:
if ( $strip ) {
	$text = trim(strip_tags($text, $allowable_tags));
}

In short we have to fix some stuff here:

the order of operations (first strip, than trim_words or trim_characters)
I'm not sure about do_shortcode - shouldn't we launch it before trimming?

@jarednova I rembember that there were some plans about rewritting this - did something was done or not yet?

Actually, these tags are allowed by default
p a span b i br blockquote
so to override this you can do {{ post.preview.strip("i").length(25).read_more(false).force }} or you can add a filter to add_filter('timber/trim_words/allowed_tags', function() { return "i"})

@marciojc Thanks, your solution works well! Sorry for taking so long to respond.


MSID: 87335 Version: 2 DOI: 10.1101/2<IP_ADDRESS>0449

MSID: 87335
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>0449
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=87335
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>0449

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/87335v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>0449
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/87335/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c15) has a publication-type='other'. Is that correct?
warn: [mixed-citation-other-publication-flag] mixed-citation in reference (id=c35) has a publication-type='other'. Is that correct?


PLSS Point Popup

Miro reference here

Click existing PLSS point on map
Highlight or otherwise identifies selected point on map
Popup contents on existing app still suits the requirement
suggestion: 'x' in corner of existing popup can be difficult to see - make more apparent
idea: popup as a pane with transparency that can be moved around on top of map?
new feature: In Tie Sheet Document section of the popup, show a list of links to every tie sheet approved for that point

there is a new requirement to store multiple submitted tie sheets for a point, as improved data/sheets are collected over time

Click tie sheet link(s) to view/print/download
~new feature: (eventually) view Rec User's submitted data related to the PLSS point~

Any new tasks related to the PLSS point information panel will be defined in a new github issue.


Updated model diagram

-Broke down the model diagram into smaller diagrams
-Updated the description for Model component

Codecov Report

Merging #280 (ca456b3) into master (f7cbdd1) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #280      +/-   ##
============================================
- Coverage     78.20%   78.10%   -0.11%
- Complexity      990      991       +1
============================================
  Files           119      119
  Lines          3019     3028       +9
  Branches        412      415       +3
============================================
+ Hits           2361     2365       +4
- Misses          535      539       +4
- Partials        123      124       +1

Impacted Files
Coverage Δ

.../address/logic/candidate/EditCandidateCommand.java
86.95% <0.00%> (-3.61%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a89078...ca456b3. Read the comment docs.


Remove source target ellipsoid ids from transform

Modified model to remove sourceEllipsoidId and targetEllipsoidId. These could be specified in the sourceEllipsoid and targetEllipsoid definitions provided. The previous model was copied from the previous Geodetic Datum model which made an indirect reference to an ellipsoid. In the case of a geodetic transform such indirection was unrequired an the sourceEllipsoid and targetEllipsoid contained the definition data required (polar and equatorial radiuses).
Note that since JSON def of transforms are not stored anywhere(yet) these changes do not not break any backward compatibility.

Abandonning to split into three distinct pull requests. Changes were too intermingled to be easily reviewed.


Title: Add Tetris Game

Is your feature request related to a problem? Please describe.
Tetris is a beloved classic game that is missing from our website. Furthermore, integrating Tetris is relatively straightforward with JavaScript and HTML5
Describe the solution you'd like.
I propose adding a classic Tetris game to the website, developed using JavaScript and HTML5. This would provide a fun, nostalgic experience for users, enhancing their engagement and encouraging them to spend more time on the site.
Describe alternatives you've considered.
No response
Add any other context or screenshots about the feature request here.
No response

@Tanishka023 This project is already exist in the repo


Mention that ParsedInstruction owns its components.

Also close a parenthesis in ParsedInstruction printout.

+2.
Just remember to remove the change-id.

Merged 7a3a459.


Gracabr KCV 3.5

It was released an hour ago, any plan to follow up?

I'm unsure if I should just drop everything I'm doing and rush to merge changes in.
Please do not create pointless issues like this one. If you are dissatisfied with the speed of updates, you can always fork a repository.


ListBox: System.ArgumentOutOfRangeException: 'Index was out of range.

Describe the bug
I have a ListBox with an ItemSource bound to a collection ReadOnlyObservableCollection that is bound to a SourceList where filtering, sorting and throttling have been applied.
To Reproduce
Steps to reproduce the behavior:

Go to to the last element in the list
Toggle a filter that reduce the number of element in the list
The application then crash with the following exception:

   at System.ThrowHelper.ThrowArgumentOutOfRange_IndexMustBeLessException()
   at System.Collections.Generic.List`1.get_Item(Int32 index)
   at System.Collections.ObjectModel.ReadOnlyCollection`1.System.Collections.IList.get_Item(Int32 index)
   at Avalonia.Controls.ItemsSourceView`1.GetAt(Int32 index)
   at Avalonia.Controls.Selection.SelectedItems`1.<GetEnumerator>d__13.MoveNext()
   at System.Collections.Generic.LargeArrayBuilder`1.AddRange(IEnumerable`1 items)
   at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable`1 source)
   at Avalonia.Controls.Selection.InternalSelectionModel.OnSelectionChanged(Object sender, SelectionModelSelectionChangedEventArgs e)
   at Avalonia.Controls.Selection.SelectionModel`1.CommitOperation(Operation operation, Boolean raisePropertyChanged)
   at Avalonia.Controls.Selection.InternalSelectionModel.OnSourceCollectionChangeFinished()
   at Avalonia.Controls.Utils.CollectionChangedEventManager.Entry.<Avalonia.Utilities.IWeakEventSubscriber<System.Collections.Specialized.NotifyCollectionChangedEventArgs>.OnEvent>g__Notify|6_0(INotifyCollectionChanged incc, NotifyCollectionChangedEventArgs args, WeakReference`1[] listeners)
   at Avalonia.Threading.DispatcherOperation.InvokeCore()
   at Avalonia.Threading.DispatcherOperation.Execute()
   at Avalonia.Threading.Dispatcher.ExecuteJob(DispatcherOperation job)
   at Avalonia.Threading.Dispatcher.ExecuteJobsCore(Boolean fromExplicitBackgroundProcessingCallback)
   at Avalonia.Threading.Dispatcher.Signaled()
   at Avalonia.Win32.Win32Platform.WndProc(IntPtr hWnd, UInt32 msg, IntPtr wParam, IntPtr lParam)
   at Avalonia.Win32.Interop.UnmanagedMethods.DispatchMessage(MSG& lpmsg)
   at Avalonia.Win32.Win32DispatcherImpl.RunLoop(CancellationToken cancellationToken)
   at Avalonia.Threading.DispatcherFrame.Run(IControlledDispatcherImpl impl)
   at Avalonia.Threading.Dispatcher.PushFrame(DispatcherFrame frame)
   at Avalonia.Threading.Dispatcher.MainLoop(CancellationToken cancellationToken)
   at Avalonia.Controls.ApplicationLifetimes.ClassicDesktopStyleApplicationLifetime.Start(String[] args)
   at Avalonia.ClassicDesktopStyleApplicationLifetimeExtensions.StartWithClassicDesktopLifetime(AppBuilder builder, String[] args, ShutdownMode shutdownMode)
   at ImgTagFanOut.Program.Main(String[] args) in C:\Users\Emmanuel\source\ImgTagFanOut\ImgTagFanOut\Program.cs:line 19

Expected behavior
Application does not crash
Screenshots

Environment

OS: Windows
Avalonia-Version: 11.0.4

Additional context
Add any other context about the problem here.

SourceList

Do you update your collection/source list from the non-UI threads? It might be a reason.

@manuc66 please show us your filter code

Thanks, and sorry, indeed the issue was the lack of
   .ObserveOn(RxApp.MainThreadScheduler)


Update chisel3 to 3.3-20191218-SNAPSHOT

Updates edu.berkeley.cs:chisel3 from 3.3-SNAPSHOT to 3.3-20191218-SNAPSHOT.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "edu.berkeley.cs", artifactId = "chisel3" } ]

labels: library-update

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

We do NOT want this. Where is the .scala-steward.conf

Nope. We don't want robots updating our managed versions.


Create a validation set for US Privacy String detection

As in the title, I am going to create a validation set for US Privacy String detection. I am intending to look through the Tranco 100 to create this set.

I believe I have added a sufficient amount of sites with the US Privacy string to our validation set, so I will close this.


Setting Toggle does not support loading spinner

The Setting Toggle does not have support for displaying loading spinner when action is taking place.

@nguyenanh91 You can do it manually. Because we are following the Shopify components structure, so we can not add this to our library.

Hi @saurabh-sali-hulkapps
I have checked the component on Shopify Polaris:
https://polaris.shopify.com/components/actions/setting-toggle/action
They have the "loading" attribute on Setting toggle: https://monosnap.com/file/DLdFggB4ACybFG241Y55bPJ2Jx1fJS
It would be greate if you guys can bring it to the library.
Thanks

@nguyenanh91 Okay we will add it in our next release. Thank you for pointing out this issue.

Released new version


Pause/Resume GLSurfaceView

The parameters to initialize MapController changed slightly to create and set glSurfaceView in onMapInitOnUIThread so that onPause/Resume cannot fail due to GLSurfaceView Renderer not being set.

@tallytalwar @matteblair I've changed configureGLSurfaceView to createGLSurfaceView with the last push. Feel free to merge when you are OK with it

Yeah.. pushed a change that should properly follow the getMapAsync description. I would prefer to have a createMapAsync which throws when called a second time + getMap returning MapController (which blocks until the async task is done)


Adjust patch version on cheatsheet

The current cheatsheet contains the old version of patch:

this PR fixes that to the current version.

Thanks for the contribution!


A 724/kademlia discovery

This is the first basic implementation of a PeerGroup backed by a kademlia discovery process.

Merged via command line git merge --squash


Euler_totient.cpp

Please star this repository to show your support, in the meantime I am reviewing your code.

@amritansh22 done.

All these commits will be counted as a single PR in hactoberfest. Are you sure to merge them

I didn't understand. I mean as I have been assigned 4 issues. So all the 4 together will be counted as a single pr in hacktoberfest?

Please don't merge my pr. I will make 4 different PR from different branches. @amritansh22

closed


[HRTi] new urls are wihout #

New URL don't have #
Not sure if they kept the old ones, as a safe bet making the part of the regex just optional.

Carefully read new issue template and provide all requested information.

Updated with the requested changes.

The extractor not working anymore. HRTi has changed web site. Can anyone help with writing a new extractor?
I have added play.rtl.hr in 6play extractor.


Issue 271 node to edge

Description
compute_diffusivity  and boundary_value are now matmuls in finite_volume
Fixes #271
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Key checklist:

[x] No style issues: $ flake8
[x] All tests pass: $ python run-tests.py --unit
[x] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works
[x] Any dependent changes have been merged and published in downstream modules

Codecov Report

Merging #316 into master will decrease coverage by 0.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
- Coverage   96.75%   96.57%   -0.18%
==========================================
  Files          53       53
  Lines        3264     3269       +5
==========================================
- Hits         3158     3157       -1
- Misses        106      112       +6

Impacted Files
Coverage Δ

pybamm/spatial_methods/finite_volume.py
97% <100%> (+0.02%)
:arrow_up:

pybamm/expression_tree/binary_operators.py
95.61% <100%> (-1.53%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578fed0...f71f9c6. Read the comment docs.


Prev Next Suggestions Should Be Tech Non Tech Segregated

fixed in https://github.com/arihantverma/arihantverma.com/pull/10


MacOS Support

Hi, Could MacOS support get added to this since Sensu also has a Mac client now?

Are you sure there is no support for this? I am pretty sure https://github.com/sensu-plugins/sensu-plugins-memory-checks/blob/3.0.1/bin/check-ram.rb will work on osx as I believe I wrote that on osx.


Home-Assistant Integration

Hi Fella. I saw your Youtube-Vdeo and I am amazed and curious if it's possible to add this in Home-Assistant. I thought I did see a screen with Home-Assistant right?
My Idea is to place those Thermostats in each room to control my AC.
My AC are controlled by Xiaomi IR extenders and a custom Component. Now I'd like to somehow fiddle this together. Means. Homeassistant will create the Climate conponent and then i somehow have to bridge those received and sent mqtt topics to control my xiaomi ac custom component. Do you think it's makeable?

I don't have Home Assistant, and the screen you have seen is Node-Red. The UI is very similar to HA. But I think it could be done. HA also works with any device over MQTT. So you should be able to integrated it. I am not sure about the xiaomi part though.

Ok..sounds good .. I'll give it a shot and you're right ..I'm also running
some stuff on nodered for home-assistant. Which model is it exactly for the
thermostat?
Thanks a lot for your answer and I'll revert to you asap
nygma2004<EMAIL_ADDRESS>schrieb am Do., 7. Nov. 2019, 08:58:

I don't have Home Assistant, and the screen you have seen is Node-Red. The
UI is very similar to HA. But I think it could be done. HA also works with
any device over MQTT. So you should be able to integrated it. I am not sure
about the xiaomi part though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nygma2004/beca_mqtt/issues/2?email_source=notifications&email_token=ADFUA77GLXSCGWEUP7AWE7LQSPDDDA5CNFSM4JJYERC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDLRMBY#issuecomment-550966791,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADFUA75GPEGRGNLLP3T5FN3QSPDDDANCNFSM4JJYERCQ
.

Mine was the 2 pipe version with modbus. But they sell all possible combination. So decide which version you need and just look for the modbus version. I don't think they are selling all combination on Amazon, but you will find all models on http://becaenergy.com/.


Make Gitleaks works with bare repositories

Is your feature request related to a problem? Please describe.
I cannot execute Gitleaks as pre-commit because I'm working from a bare repository.
Describe the solution you'd like
I need to pass the following parameters to git diff:
--git-dir="/home/crazybyte/.config/dotfiles/public" --work-tree="/home/crazybyte"

maybe something like the --log-opts Gitleaks parameter, but to pass options to git may do the trick.
Additional context
The git commit command from which Gitleaks is then called, already has the two mentioned parameters. It would be nice if Gitleaks can automatically retrieve them.

Which is due to the fact that /usr/bin/git -C /path diff -U0 --staged . is missing --git-dir="/home/crazybyte/.config/dotfiles/public" --work-tree="/home/crazybyte".
cc @zricethezav

FYI: Maybe you want to adjust the docker example in the README as well. To make it works with bare-repositories for everybody.


NickServ/ChanServ/etc do not respond to CTCP VERSION

11:42 -- CTCP query to nickserv: VERSION
11:42 -- NickServ (NickServ@localhost): Unknown command. To see available commands, run: /NS HELP

no big deal, i just sometimes use the ctcp response in hacky scripts to know when nickserv is done processing something i asked it to do

Hmm, yeah it makes sense to do this. We can just respond with something like NickServ (Oragono vblah)


Update docs about how users can filter ADTs

Related to #112, we should also update these docs to explain how to use the filtering information to filter out more cells as needed.

closed with #112


[CLOUD-1600] chore: snyk code scanning

:tada: This PR is included in version 0.20.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Error running visualization.py

I have downloaded everything in the tutorial but get "python3: can't open file 'visualization.py': [Errno 2] No such file or directory" when I try to run "sudo python3 visualization.py scroll"

Are you in the Python directory? If not, go in there first and then try the visualization command again. e.g:
cd python
sudo python3 visualization.py scroll

I was not in the python directory, but when I try "cd python" it says it is not a directory. After reading your comment I realized I did not have the latest version of python installed (I was still on 2 something) so I installed python 3.9 and replaced the old version in /usr/bin, but it still says python is not a directory. I see the folder for python and such, do I need to manually make python a directory and assign the files there or was that something that should have happened in the install?

I realized that I needed to be in the python directory for the project. Now I am getting an error saying "No module named numpy", but when I check it is installed, does it need to be in a certain folder?


Fixes #8

Avoid deduplicating targets. Make sure we copy correct frameworks if we've created a fat file.

Thanks!


error running dotnet

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/install
Operating System: windows
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
I get this message:
Thrown:
ReferenceError: dotnet is not defined

did you open the NEW command prompt to test dotnet command?

Seems like new command prompt with env var set ws not opened. Closing.


fix Doris returns empty sets when select  count(*) from a inline view

Proposed changes
Issue Number: close #xxx
Problem summary
Doris always delays the execution of expressions as possible as it can, so as the expansion of constant expression. Given below SQL:
select count(*) from (select 'abc' as i, sum(birth) as j from  subquerytest2) as tmp

The aggregation would be eliminated, since its output is not required by the outer block, but the expasion for constant expression would be done in the final result expr, and since aggreagete output has been eliminate, the expasion would actually do nothing, and finally cause a empty results.
To fix this, we materialize the results expr in the inner block for such SQL, it may affect performance, but better than let system produce a mistaken result.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

we need a rewrite rule to eliminate such agg in nereids


GoogleMaps [deprecated] Please use GoogleMaps.create()

I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request
Important Info
There is a new way of instantiating a map
this.map = GoogleMaps.create(element.nativeElement, mapOptions);
References
https://github.com/mapsplugin/cordova-plugin-googlemaps-doc/blob/master/v2.0.0/ReleaseNotes/ionic-googlemaps-4.4.0/README.md

It looks like @yannbf updated the native-google-maps.ts file on Jan 18th to fix this issue.
Commit 812c9f0

Got the same issue


[WIP] Multi metric support

Will reopen if something clean comes out

Let's just merge as is since it's already functional. We can probably refactor it later. Thanks for the PR!


V101

Refactor all examples

@agnat The formula was correct but there was another big. I've fixed it and factored the queue to work better:
https://github.com/vinniefalco/beast/blob/v103/example/advanced/server/advanced_server.cpp#L390


CoreML model input type is MultiArray instead of Image

I was able to successfully save the MobileNet NIMA model as a coreML model however the input is not what I was expecting. It shows the input as MultiArray instead of an Image
base_model = MobileNet((None, None, 3), alpha=1, include_top=False, pooling='avg', weights=None)
x = Dropout(0.75)(base_model.output)
x = Dense(10, activation='softmax')(x)

model = Model(base_model.input, x)
model.load_weights('weights/mobilenet_weights.h5')
coreml_model = coremltools.converters.keras.convert(model)
coreml_model.save("mobilenet_nima2.mlmodel")

CoreML metaData

Ideally what the input and output should resemble:

I also tried converting the model by passing in an image_input_names parameter
coreml_model = coremltools.converters.keras.convert(model, image_input_names='img', input_names='img')

but I received an unpack error from the coreML builder tools
/coremltools/models/neural_network/builder.py", line 2547, in set_pre_processing_parameters
    channels, height, width = array_shape
ValueError: need more than 1 value to unpack

Code where the error originates
https://github.com/apple/coremltools/blob/master/coremltools/models/neural_network.py
        # Add image inputs
        for input_ in spec.description.input:
            if input_.name in image_input_names:
                if input_.type.WhichOneof('Type') == 'multiArrayType':
                    array_shape = tuple(input_.type.multiArrayType.shape)
                    channels, height, width = array_shape

Any idea why the keras model is converting to a CoreML model with input MultiArray type instead of an image?
There have been MobileNet models that have been successfully converted to a CoreML model with image as an input e.g. https://github.com/hollance/MobileNet-CoreML

Instead of using None, None, 3 as the input shape, use a static size such as 224.

Worked! Thanks @titu1994


Stocktake value gets set to snapshot/lost

Build Number: 2.1.0-rc8
Description:
If a existing Actual Quantity value is tapped and highlighted, it'll be set to the snapshot quantity if you press next without changing the value to something different
Reproducible: yes
Reproduction Steps:

Have a stock take with a few items
Enter some values
If you select a value you have entered and press next, it'll be lost/set to what ever the snapshot value is.
You must enter a different value if you don't want it be set to snapshot quantity.

Comments:
We should test better. This was introduced in Dec and we only now picked it up. https://github.com/sussol/mobile/pull/580/files

Fixed in #627


 I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.
[X] 3. Please note that if the bug-related issue you submitted lacks corresponding environment info and a minimal reproducible demo, it will be challenging for us to reproduce and resolve the issue, reducing the likelihood of receiving feedback.
[X] 4. If the issue you raised is not a bug but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[X] 5. Please use English, otherwise it will be closed.

Describe the bug
Gemma-2-9b-it: "..."
Reproduction
I just pulled the latest Docker image and deployed Gemma-2-9b-it AWQ version.  Your objectives are as follows:

1. **Extract Supported Evidence**: For each file name provided, identify and extract short, concise phrases that serve as strong evidence supporting the question. The evidence must be:
   - Relevant: Directly related to the question.
   - Strongly Related: Clearly substantiates or informs the question.

2. **Evaluate Relevance**: Gather all extracted evidence and evaluate how well it supports the question. Provide your thoughts on the relevance and strength of the evidence as it relates to the question.

3. **Formulate the Final Answer**:
   - If the collected evidence collectively provides a clear and accurate answer to the question, present the answer in a well-informed and concise manner.
   - If the evidence is insufficient or inconclusive, explicitly state that a definitive answer could not be determined. Avoid making unsupported assumptions.

4. **Output Format**: Return your findings as a JSON object adhering to the following schema:

```json
{{
  "supported_evidence": [{{"filename": "<filename>", "text": ["<evidence>", "<evidence>"]}}, ...],
  "thought": "<your evaluation of relevance>",
  "final_answer": "<your final answer or statement of inconclusiveness>"
}}```

### Here is your input
Question: {question}
Reports: {contexts}"""

My Pydantic model
class Evidence(BaseModel):
    filename: str
    text: list[str]

class Output(BaseModel):
    supported_evidence: list[Evidence]
    thought: str
    final_answer: str

How I called the server
content = await self.client(
            messages=Messages(
                messages=[
                    {"role": "user", "content": prompt}]
            ),
            extra_body={
                "regex": build_regex_from_object(Output),
                "repetition_penalty": 1.2,
            **self.params
        )

Llama-3.1-8B-Instruct worked with this prompt while Gemma-2 produced garbage outputs (Note: with repetition_penalty = 1.0, Llama-3.1 produced duplicated content)
Environment
Python: 3.10.14 (main, Apr  6 2024, 18:45:05) [GCC 9.4.0]
CUDA available: True
GPU 0,1: NVIDIA A10G
GPU 0,1 Compute Capability: 8.6
CUDA_HOME: /usr/local/cuda
NVCC: Cuda compilation tools, release 12.1, V12.1.105
CUDA Driver Version: 550.90.07
PyTorch: 2.4.0+cu121
flashinfer: 0.1.5+cu121torch2.4
triton: 3.0.0
transformers: 4.44.0
requests: 2.32.3
tqdm: 4.66.5
numpy: 1.26.4
aiohttp: 3.10.3
fastapi: 0.112.1
hf_transfer: 0.1.8
huggingface_hub: 0.24.5
interegular: 0.3.3
packaging: 24.1
PIL: 10.4.0
psutil: 6.0.0
pydantic: 2.8.2
uvicorn: 0.30.6
uvloop: 0.20.0
zmq: 26.1.0
vllm: 0.5.4
multipart: 0.0.9
openai: 1.40.8
anthropic: 0.34.0
NVIDIA Topology:
GPU0    GPU1    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      PHB     0-47    0               N/A
GPU1    PHB      X      0-47    0               N/A
Legend:
X    = Self
SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
PIX  = Connection traversing at most a single PCIe bridge
NV#  = Connection traversing a bonded set of # NVLinks
ulimit soft: 1048576

What are the inference results of this AWQ version model using transformers, under the same parameters?

@zhyncs It didn't generate anything. I think the awq version is broken.

@zhyncs It seems like gemma-2 hasn't been supported yet issue, but somehome there is a checkpoint on HF.

ok. You can use fp16 version for now.


fix(#883): ahbap description handled

Description
Ahbap description data type checked added to prevent crash.
discord username: İlker Sarıca#7138
closes #issue #883
Please describe your changes. Also describe your aim and content. Do not forget to list the dependencies required caused by those changes.
## Things to check before creating a PR

[ ] I have inspected my topic, checked.
[ ] If it is a core feature, executed detailed tests.

Creating PR rules

[ ] PR must be created for an issue with approved tag. Otherwise PR will be rejected.
[ ] Relevant issue number: The issue number related to PR must be attached to head of PR header, after prefix after prefix # must be attached in parenthesis. A header like this could be used "prefix(#issue_number): PR header" .
[ ] A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules. For example, a title like "docs(#issueId): Add README.md" can be used.
[ ] Related file selection: Only relevant files should be touched and no other files should be affected.
[ ] Format and Lint Suitability : The code should be made in accordance with a certain format standard and examined according to the lint rules.
[ ] Clean commit history: The commits where the changes are made should be clear and organized.
[ ] Opening PR when job is completed: PR should be opened when job is completed and sent for review by other team members.

Changes

[ ] A new feature (a change that adds a new feature, not a breaking change)
[ ] A new refactor (a change that is not a breaking change, that improves the readability or performance of the code)
[ ] A breaking change
[ ] Documentation change

How were these changes tested?
Please describe the tests you did to test the changes you made. Please also specify your test configuration.
Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

not a fix actually as i see

not a fix actually as i see

If backend will fix the issue, yes. If they won't, this causes a complete crash, fyi.


Restructure repository

What
Restructure repository so that it would support both rust and go projects.
Why
The Soroban-cli and the soroban-rpc are logically dependent of each other, and would ideally live at the same place.
That would allow us to move the entire soroban testing that we have scattered across the Soroban-cli and go into a single location.
Known limitations
N/A

Also need to update README.md with updated bin name.

This change is addressing a few issues together. One of those issues is particularly interesting to me: the pain of our existing use of [patch.*] with managing transitive dependencies that are also in development. I'm investigating that independently in https://github.com/stellar/rs-soroban-env/issues/567.

Also need to update README.md with updated bin name.

yes, you're correct. I'll fix that later on today.

One quick question: now that the rust crate is a workspace member, why is the top level not just a virtual manifest? That is not contain anything other than the workspace deps and members? It seems that a lot of things are repeated in the two Cargo.toml's.
I just tested it locally and if I remove everything above the workspace info in the root Cargo.toml everything works the same.

One quick question: now that the rust crate is a workspace member, why is the top level not just a virtual manifest? That is not contain anything other than the workspace deps and members? It seems that a lot of things are repeated in the two Cargo.toml's.
I just tested it locally and if I remove everything above the workspace info in the root Cargo.toml everything works the same. Also could move the build.rs to the inner crate's directory.

Not opposing to doing that - but previous attempts I've made ended up with some of the tests failed to compile.
How do you feel about applying your changes on top of mine ?

Sure PR incoming!

Some thoughts:

Agreed, a lot of the CLI files should be moved into the CLI directory rather than sit in the top-level.

The top-level tests directory contains Rust tests. Should it?  Maybe that tests directory should be moved inside the soroban-cli directory, or it should be split in half so tests taht use both live in that directoryh while tests that are only CLI live inside that directory.

There's an assumption being made that changes will always be applied to the CLI and RPC at the same time. If we continue to work on a model where the RPC and RPC Simulator are duplicates of each other, that makes sense. If the RPC Simulator lives inside the RPC and is just embedded in the CLI, then the two efforts can be disconnected.

What's the update process for the RPC + CLI? Living in the same repo I assume CI will require them to be compatible with each other at the same time. But the update process for both are extremely different, with different dependencies.
It will take longer to get the RPC up to date if it is dependent on data from stellar-core. Where-as the CLI can otherwise likely move much faster.
For example:

That would allow us to move the entire soroban testing that we have scattered across the Soroban-cli and go into a single location.

How does this align with the system tests that @sreuland has been talking about?

In terms of how we manage multiple languages within the one repo: We could explore using language agnostic monorepo build systems. It feels like that is what deptool is, more lightweight than most. Some that come to mind are:

Bazel – https://bazel.build
Buck – https://buck.build
Pants – https://www.pantsbuild.org

I only have experience with Bazel, and it's quite a beast. I remember having more problems with it, than I thought it was solving, but I know a lot of people have success with it. Buck and Pants I have no experience with, but just know of.

In terms of how we manage multiple languages within the one repo: We could explore using language agnostic monorepo build systems. It feels like that is what deptool is, more lightweight than most. Some that come to mind are:

Bazel – https://bazel.build
Buck – https://buck.build
Pants – https://www.pantsbuild.org

I only have experience with Bazel, and it's quite a beast. I remember having more problems with it, than I thought it was solving, but I know a lot of people have success with it. Buck and Pants I have no experience with, but just know of.

Lots of good points, let me go through in my own arbitrary order:

Versioning and releases: As you've suggested, releases off this repository would be more frequent and would be triggered as result of either core or soroban specific changes. That means that the end user might be getting an "upgraded" soroban-cli without any meaningful changes to the cli itself. That is unfortunate, but not harmful in any way.
In term of dependency tools - I haven't explored the ones that you've mentioned yet. I'd like to make the minimal changes here, without completing the development of the deptool. I'll defer that to a subsequent task and/or use of the tools you've suggested. In your response, you've identified that our needs here are quite minimal - which I completely agree with.
Moving some of the tests that are under /tests into /cmd/soroban-cli/tests is something I'm perfectly fine with. I think that we still do want to have /tests that would exercise some soroban-cli and soroban-rpc related testing.
Once this PR is merged, I'll be working on making the required changes to the quickstart, so that it would work seamlessly from there as well. Ideally, I would be able to extend the cross-repo dependency model to there as well.
@sreuland was working on creating a repo that would focus on running functional tests across multiple targets ( sandbox, quickstart ); that isn't directly conflicting with this change.
I expect some changes to the release process would be required.

@tsachiherman something I am missing here is the soroban-rpc github workflow ( https://github.com/stellar/go/blob/46b0e5c507899980f2a7ae96727ddcd90f5fce73/.github/workflows/soroban-rpc.yml ) . What's the plan in that respect?

@tsachiherman also, all the soroban-rpc method handlers are missing, why is that?


Proposal/Discussion(ISD-1274): Reduce image size

Overview
Currently the ROCK results in a Docker image size of 1.49GB.  This might bring many disadvantages such as:

Resource consumption
Scaling
Increased vulnerability
Image version control

This PR intends to show an option to reduce the image size from 1.49GB to 853MB by moving the installation to the charm and by creating a storage to /var/lib/gems
TODO:

Discuss how handle events to avoid re-installation.
If it's worth it considering the time to install (local test ~2min)

Rationale
Reduce resource consumption/cost and improve scalability.
Juju Events Changes

on_install - where the discourse will be installed
on_pebble_ready/config_changed - to check if the gems are installed

Module Changes
N/A
Library Changes
N/A
Checklist

[x] The charm style guide was applied
[x] The contributing guide was applied
[x] The changes are compliant with ISD054 - Manging Charm Complexity
[x] The documentation is generated using src-docs
[x] The documentation for charmhub is updated.
[x] The PR is tagged with appropriate label (urgent, trivial, complex)

Thanks for all the reviews. I'm closing this PR to no conflict with current work and to discuss the workload/charm responsibilities in a different context.


Implement new UUID versions (V6, V7, V8)

Feature Request
I propose to add support for the new UUID versions (V6, V7, V8, Nil UUID, Max UUID) according to draft-ietf-uuidrev-rfc4122bis-14.
Also see:

Kyle Carter: Analyzing New Unique Identifier Formats (UUIDv6, UUIDv7, and UUIDv8)
ramsey/uuid
martinthenth/uuidv7
Buildkite Blog: Goodbye integers. Hello UUIDv7!

UUID v7 in particular seems to be gaining traction for primary keys in database applications.

zoonect-oss/ash_uuid

This document type for this RFC is Active Internet-Draft instead of RFC like from the SPEC that I am use to.  Is this spec accepted yet?

It's not an official RFC yet, but implementations are already out there, and changes are probably unlikely. The RFC seems to be in its final stages.


pkgs/top-level/release.nix: expose .build as a direct jobset for hydra

This matches jobsets for cross-jobs. This way it' will be a bit easier to automatically extract bootstrapTools for mass updates in https://github.com/NixOS/nixpkgs/issues/253713
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

What is inconsistent today:

good: https://hydra.nixos.org/jobset/nixpkgs/cross-trunk#tabs-jobs search for "bootstrapTools":

You can see jobs like "bootstrapTools.aarch64-unknown-linux-gnu.build"

bad: https://hydra.nixos.org/jobset/nixpkgs/trunk#tabs-jobs search for "bootstrapTools":

You can see only "stdenvBootstrapTools.aarch64-unknown-linux-gnu.dist" (no build)

This PR fixes it.

Is there any point still having dist?

Good question! 45c7dd7d98f1466b3d631444f71b441a48ccd54c in 2015 added dist that explicitly lists all the files expected to land on tarballs.nixos.org to mirror what ${.build}/on-server/* build should contain. I think removing .dist makes sense.

Proposed dist removal as:

https://github.com/NixOS/nixpkgs/pull/301639


System.InvalidOperationException:“No such configuration property: "client.software.name"”

Description
`
_servers = servers;
_timeout = timeout;
        var config = new ProducerConfig()
        {
            BootstrapServers = _servers,
            LogConnectionClose = false,
            CompressionType = (CompressionType)compressionType,
            CompressionLevel = compressionLevel
        };

        _producer = new ProducerBuilder<string, string>(config).Build();

`
Environmental Science:
1..net framework4.5.1
2.nuget Confluent.Kafka 1.5.1
Error:
System.InvalidOperationException:“No such configuration property: "client.software.name"”

it's loading an old version of librdkafka somehow (client.software.name is a relatively new property). make sure you're not referencing an old librdkafka.redist nuget package (no need to explicitly reference at all), and remove any installed versions of librdkafka you may have on your machine.

it's loading an old version of librdkafka somehow (client.software.name is a relatively new property). make sure you're not referencing an old librdkafka.redist nuget package (no need to explicitly reference at all), and remove any installed versions of librdkafka you may have on your machine.

CompressionType = (CompressionType)compressionType,             CompressionLevel = compressionLevel
I'm using the latest version, which works without the above two items


Component docs contain references to excluded files

Describe the bug
In terminal example at https://tutorialkit.dev/reference/react-components/ there is import for useTheme.ts file that is not visible in the page, or in the linked Stackblitz project. There's no way for users to know what it contains.
import { useTheme } from './hooks/useTheme';

Link to a StackBlitz project which shows the error
No response
Steps to reproduce
https://tutorialkit.dev/reference/react-components/
Expected behavior
Documentation should contain all code that is required to reproduce the example. Ideally users should not even open the linked Stackblitz project to see what the referenced files contain.
Screenshots
No response
Platform

TutorialKit version: 0.2.0

Additional context
No response

We could introduce that file as a code snippet somewhere at the start of the page. In particular, it's not been shown because the actual implementation used in the docs is specific to our docs and not relevant for end users.


Dependency Review

Pull Request

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#23
#22
#21  👈
#20
#19
#18
#17
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Oct 31, 12:51 PM EDT: A user merged this pull request with Graphite.


Fractal "No apps available" when opening links.

Hey!
Describe the bug
When opening the links in Fractal, it always just says "No apps available"
Steps To Reproduce
Steps to reproduce the behavior:

Click on a link
Get popup

Expected behavior
Should just open the link in the web browser
Screenshots

Additional context
xdg-open example.com works and all the mime apps should be set.
This is on Hyprland with xdg-desktop-portal-gtk and xdg-desktop-portal-hyprland.
Hyprland is from their flake.
You can find my system flake here!
Respective modules:
- github.com/jh-devv/luminara/modules/nixos/desktop/hyprland/default.nix
- github.com/jh-devv/luminara/modules/home/desktop/xdg.nix
Notify maintainers
@schuelermine @dtzWill
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[jh-devv@luminara:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.77, NixOS, 24.05 (Uakari), 24.05.20240216.5863c27`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/store/bg5fbkfa5x53clcjf4p5p92k1l3w8x38-source`

Sincerely: jh-devv<EMAIL_ADDRESS>

Maybe related: https://github.com/NixOS/nixpkgs/issues/189851#issuecomment-1238907955

in addition to what's mentioned in 189851, you also need to make sure that xdg-desktop-portal is fully mime aware. in particular, make sure that share/applications/mimeinfo.cache exists (with entries for x-scheme-handler/http(s)) on one of the $XDG_DATA_DIRS paths. and make sure xdg-desktop-portal has in its environment XDG_DATA_DIRS which would let it find such a file (because if you haven't imported it to the systemd/dbus environment, it probably won't. and if you import it after it's already been started, it won't).
you can try systemd --user status xdg-desktop-portal to find the PID, and then cat /proc/$THAT_PID/environ to query its XDG_DATA_DIRS.

in addition to what's mentioned in 189851, you also need to make sure that xdg-desktop-portal is fully mime aware. in particular, make sure that share/applications/mimeinfo.cache exists (with entries for x-scheme-handler/http(s)) on one of the $XDG_DATA_DIRS paths. and make sure xdg-desktop-portal has in its environment XDG_DATA_DIRS which would let it find such a file (because if you haven't imported it to the systemd/dbus environment, it probably won't. and if you import it after it's already been started, it won't).
you can try systemd --user status xdg-desktop-portal to find the PID, and then cat /proc/$THAT_PID/environ to query its XDG_DATA_DIRS.

Thanks! I will be sure to try these!

Oh, this was an issue with xdg-desktop-portal-gtk

Oh, this was an issue with xdg-desktop-portal-gtk

@jh-devv if you have a moment, mind summarizing what the fix was? might help the next person who encounters this, especially given how murky the situation still is over at 189851


geo-layers: refactor tile-3d-layer

Background

loaders.gl v2.1 refactors change the tile loaders api

Change List

Tile3DLayer API change

This PR depends on loaders.gl v2.1

Coverage decreased (-2.5%) to 80.653% when pulling 8af7ce08c9507614b1bf06661a4f18b414e8ab6d on xx/tile-3d-layer into eb6f16321ced8e19aef926cf83f59ef899382620 on master.


IGAPP-872: Add a hint about missing cities

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.
Icons are just placeholders until the correct ones are finished.

Found this issues mobile on iphone 6/7/8 Plus

Really nice work! Nice design and implementation :)

Release Notes? :)

There already is a release note.

There are three hidden comments not yet addressed :)


Search results updates

Update Crunchbase API Module handler model
Update seeds.rb to reflect API module changes
Added specifc tech companies
Fixed the autocomplete double-enter issue
Autocomplete now works when clicking on item
Updated search method in company model. Still want to make it case insensitive

successfully merged


Show how to generate C# data models with serializer functionality

What to solve
Sometimes you want to use the models for data transfers, and while most cases would work out of the box, custom serializer functionality is needed for the advanced cases.
If you generated the data models based on JSON Schema document and you want the serialized data to validate against the schema, this functionality is REQUIRED.
This can be done including the preset CSHARP_JSON_SERIALIZER_PRESET.
Use the following code in the example:
generator = new CSharpGenerator({
  presets: [
    CSHARP_JSON_SERIALIZER_PRESET
  ]
});

Duplicate the folder https://github.com/asyncapi/modelina/tree/master/examples/TEMPLATE and rename it to csharp-generate-serializer. Update any relevant documentation.

Some folks want more specific tasks to complete, or use this if you get stuck - CLICK ME

This issue is specially designed for first-time contributors, that want to contribute their very first code. If you are accustomed to how to solve issues in AsyncAPI, you can skip some of the steps.
What to know before getting started
Before actually getting started with solving the issue, there are a few things that need to be set up:

Make sure you familiarize yourself with our code-of-conduct and contributor guidelines
We work on forks of repositories and branches in forks, if you are unsure how to set this up you can follow the guide on our git-workflow setup.

Feel free to reach out either here in the issue, or on slack under #tooling if you have any questions or are stuck, we will gladly help.
Getting started
This is a task list, that you copy into your PR description to ensure everything is included, this list walks you through each step as to how to solve this issue. It assumes that you have already set up your fork and branch and are ready to commit code.

[ ] Duplicate the folder https://github.com/asyncapi/modelina/tree/master/examples/TEMPLATE and rename it to csharp-generate-serializer. This will give you a good base to start out with.
[ ] Adapt the documentation about the feature and ensure the example are linked correctly.

The docs that need to change are the following: docs/languages/Csharp.md#generate-serializer-and-deserializer-functionality
The documentation must reference an actual example that is tested and contain no code itself. It is because the docs will inevitably become desynchronized and display incorrect code.

[ ] Adapt the examples overview to include your new example.
[ ] Now it is time to adapt the test code (in examples/csharp-generate-serializer/index.spec.ts) and the implementation (in examples/csharp-generate-serializer/index.ts).
[ ] Make sure that the test succeeds, by standing in the new example folder and execute npm run test.
[ ] Make sure that there are no linting errors, by standing in the root folder and execute npm run lint.
[ ] Create your PR, by selecting your branch that should be merged with the master branch - https://github.com/asyncapi/modelina/compare
[ ] It is good practice to double-check your PR before requesting a review from someone else, the same way you read an assignment before handing it in.

Do you have any examples I can check for reference?
We have currently 4 example documentations that you can look for guidance on how to achieve the desired output:

How to add logging to the library
Generate models from AsyncAPI documents
Generate models from JSON Schema draft 7 documents
Generate an interface instead of class

Happy Hacktoberfest, everyone! ✨✨ Feel free to reach out to me for any questions you may have about adding documentation on these open issues. 🙂
Tag me in your AsyncAPI Doc PRs 📄, my GitHub handle is /alequetzalli 🐙.

Hey @jonaslagoni , I'm gonna try to solve this issue.


NUnitTestAdapter.WithFramework 2.0.0

Type: Missing
Summary:
NUnitTestAdapter.WithFramework 2.0.0
Details:
Nuget site indicates license is MIT and Zlib
Resolution:
License link on Visual Studio Marketplace also indicates license is MIT and Zlib
Affected definitions:

NUnitTestAdapter.WithFramework 2.0.0

License archive: https://web.archive.org/web/20151228193741/https://visualstudiogallery.msdn.microsoft.com/site/6ab922d0-21c0-4f06-ab5f-4ecd1fe7175d/eula?licenseType=None

Per this discussion, zlib-acknowledgement is the correct expression to use for NUnit.
https://github.com/spdx/license-list-XML/issues/405
https://spdx.org/licenses/zlib-acknowledgement.html


batch.add_filter() needs to cross-check filter name dupes in other Batches.

Because filter names that reference different logics can mix up the aggregation process. We should prohibit  this and raise.

done in #1016


Fix shard instability

What changed?

Why?

How did you test it?

Potential risks

Coverage increased (+0.4%) to 67.362% when pulling 32223fa9efd1f4785b12815caa0cfe1c11b5af50 on yycptt:0.12.x-fix-shard into 37e429e01cf1e0aa7bbb519e02ec3d344d6e0951 on uber:0.12.x.


Modify the destination for the response!

Hi! I launch two entities of the Emulator for the following scenario: I want to receive the message from the first Emulator entity but to send it to the second Emulator entity. How can I do this?

The Microsoft Bot Framework team prefers that how to questions be submitted on Stack Overflow. The official Bot Framework Github repo  is the preferred platform for submitting bug fixes and feature requests.


[Enhancement] Import starcache submodule to support DLA block cache.

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Import starcache submodule as a new block cache engine which support KV interfaces, and provides memory and disk cache. Currently, we support both cachelib and starcache engines, and we set the starcache as the default engine.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 3.0
[ ] 2.5
[ ] 2.4
[ ] 2.3

left comments, rest LGTM.


[IOTDB-1794] Client Node.js

6431

 Quality gate: Failed
449 Issues

 442 Code issues
 7 Anti-patterns

Details

 Quality gate: Failed
449 Issues

 442 Code issues
 7 Anti-patterns

Details


Unable to open anything after running part8

I'm able to successfully run part 8 and everything appears to be working fine until I go to open any application for example firefox never successfully runs and throws an error while the hypervisor is active and the same goes with pretty much everything else but occasionally I'm able to open something simple like the snipping tool so I'm not sure where to go with this?
I tested it on VMWare 17 and on bare metal resulting in the same behavior, and the OS I was testing it on is Windows 11 Pro 23H2 build 22631.2506 (VBS disabled)
Here is the error message that occurs:

EDIT: If my hardware has any relevance here you go:
CPU: i9-10900k (Comet Lake)
MB: ASUS ROG Z490-E (BIOS/UEFI version 2701)

//HiddenHooksTest();   When it is turned on, the screen will be blue.    but //SyscallHookTest();  it is turned on,it not.   I tested it on Win11.

Hi @1442818223 ,
Hypervisor From Scratch remained untouched for educational purposes. If you want to use a version that is actively maintained, you need to use HyperDbg's VMM module which is similar to Hypervisor From Scratch.

你好@1442818223出于教学目的， Hypervisor From Scratch 保持不变。如果要使用积极维护的版本，则需要使用与 Hypervisor From Scratch 类似的 HyperDbg 的 VMM 模块。

Thank you. HiddenHooksTest won't appear blue screen after compiling in DBG mode. What part should I refer to when I want to run HiddenHooksTest in RELEASE mode?

There are different EPT hooks, like:
https://docs.hyperdbg.org/commands/extension-commands/epthook
https://docs.hyperdbg.org/commands/extension-commands/epthook2
https://docs.hyperdbg.org/commands/extension-commands/monitor
https://docs.hyperdbg.org/commands/extension-commands/mode


MetalDelegate.swift : Unexpected version number in 'available' attribute for non-specific platform '*'

Warning in line
@available(*, deprecated: 2.4, renamed: "isPrecisionLossAllowed")

@KonradMokiejewski
Can you refer this source code  and see if it helps you.
If the problem still persists please share more information and exact sequence of commands / steps that you executed before running into the problem.It helps us in localiizng the issue faster.
Please, fill issue template.Thanks!

@KonradMokiejewski
Can you refer this source code  and see if it helps you.
If the problem still persists please share more information and exact sequence of commands / steps that you executed before running into the problem.It helps us in localiizng the issue faster.
Please, fill issue template.Thanks!


update prompt wording to specify use of present tense

closes #2

Thanks for the contribution @m1yon!


Support WAVE_FORMAT_EXTENSIBLE

This PR will add support for WAVE_FORMAT_EXTENSIBLE as suggested here.

@aliciusschroeder
The Software should now support the formats WAVE_FORMAT_PCM, WAVE_FORMAT_IEEE_FLOAT, WAVE_FORMAT_ALAW, WAVE_FORMAT_MULAW and WAVE_FORMAT_EXTENSIBLE. Please have a look at it and check if I missed something.
I also added tests (see Readme). Fell free to add more test cases as the currently existing ones do not cover all of the functionality.
In addition I used the opportunity to fix #7

@aliciusschroeder
Thank you for your side channel feedback :)


Add Neo Train

@dwayne Hay Dwayne, I added neo train to the project JSON. Did I do it correctly?

@dwayne Hay Dwayne, please merge this pull request

@janekx21 Oops, I accidentally closed this PR. However, thanks for your contribution.

... I added neo train to the project JSON and a screenshot. Did I do it correctly?

I had to make a few changes, typos and size of the screenshot (1000x800).


Setup editor3 frontend entry point

Resolves #6444
See issue :point_up: for scope, but also noteworthy:

underscore-cdb-v3 changes; Since current/old entry points still relies on cartodb.js v3 which provides an older version of underscore, the browserify-shim had to be renamed to not clash with the new one required for the new entry-point.
all new code, that needs to be compatible with v4 of cartodb.js and the new DI lib, are expected to be added to the new root dir, cartodb3 dir
renamed carto1b bundles to cartod1b (previously deepInsights), to not confuse it with the now introduced deep-insights dependency
removed shelljs from devPackages, no longer used it seems and it was causing the CI to go haywire
#6456 Semistandard linting for all new code (like in cartodb.js/deep-insights), resolved in 6dae524
deprecating grunt jasmine-server, the connect server is run together with grunt dev which makes things easier (opens a browser win with links to where the tests can be found.

Things that was pushed out-of-scope, since they're not must-have and could be better done in isolation (bonus: smaller PRs):

#6455 setting up markup+view for widgets interactions etc. (since that's the next in the backlog)
#6459 Replace temporary solution for the CSS with new https://github.com/CartoDB/CartoAssets
https://github.com/CartoDB/deep-insights.js/issues/85 Replace hacks for vizJSON "v3" to work, since cartodb.js v4 has some new props and requirements. Also, the "diJSON" as a concept do not exist yet and should be defined, there will be a v3 of vizJSON #6472 which replaces these (TBD in #6471), cc @juanignaciosl @alonsogarciapablo

createDashboard works, but needs a clear and well-defined public API (related to the previous point)

@xavijam can you review?
cc FYI @CartoDB/frontend

I think we should add whatever we need to a v3 VizJSON, not adding a new diJSON.

Reviewed and code looks :+1:. Comments:

Markup + view for widgets interactions => :+1:
Semistandard linting for all new code => the sooner the better
Replace temporary solution for the CSS with new CartoAssets => as soon as we merge this PR, we will discuss when add it to the loop, @javierarce.
Deep-insights viz.json => when should we take a decision?

Take into account @juanignaciosl comment please :).

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

Check last commit @viddo.


Enable clang code coverage

Current coverage is 0.00%

Merging #12 into master will not affect coverage as of bc695c7

@@            master   #12   diff @@
====================================
  Files            9     9
  Stmts          510   510
  Branches         0     0
  Methods          0     0
====================================
  Hit              0     0
  Partial          0     0
  Missed         510   510

Review entire Coverage Diff as of bc695c7

Powered by Codecov. Updated on successful CI builds.


Ilustrations slides and code section is not working in Editorial section

Describe the bug
Ilustrations slides and code section is not working in Editorial section
To Reproduce
when I go to editorial section previous section it is not showing slides illustration and code section playgraound
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Browser [e.g. chrome, safari]

Additional context
Add any other context about the problem here.

Can you send a screenshot of it? And which problem?

@31b4  Same I am also facing unable to open the editor.when i click the question after refreshing it does not open the code editor

@mukuljha302 use split UI: #14


Tests for Rfc2616 parser

This PR starts from a change I want to do removing Registry from MediaRange. To do so I needed to generate MediaRange instances for scalacheck, which led me to create generators for various parts of the http spec previously untested.
This PR contains a test and the generators but there is one that is contentious and I'd like to get your comments

I added a comment and a small fix for scala 2.11. It's probably a good idea to review the generators anyway

Which standard? I could rename them

This is how cats names them.  I've been using http4s instead of catsPackageName as a unique-enough prefix.

I see, I will switch the convention. Looking at the arbitraries you can see there have been many hands involved

Maybe it's better to do another PR with all arbitraries names fixed in on go. Shall I merge this one to get my another change as a PR?

Yes. :)