Thanos-Compact halting with error 'err="compaction: group 0@17832940732465865817: overlapping sources detected'

Thanos, Prometheus and Golang version used:
Thanos: 0.31.0
Prometheus: 2.44.0
Object Storage Provider:
Google (GCS)
What happened:
Thanos-compact pod halted shortly after starting with error:
│ level=error ts=2023-05-23T13:07:54.219139563Z caller=compact.go:487 msg="critical error detected; halting" err="compaction: group 0@17832940732465865817: overlapping sources detected for plan [01GZ0CAKEYN0BVTRW570T69QKM (min time:<PHONE_NUMBER>388, max time:<PHONE_NUMBER>000) 01H0FY8AR60GEVX3J3Q7Y7GSYG (min time:<PHONE_NUMBER>388, max time:<PHONE_NUMBER>000) 01GZ0K651WJG1M9W2DMC050NHF (min time:<PHONE_NUMBER>388, max time:<PHONE_NUMBER>000) 01GZ0R6020JTZ21GETCZCY5Y57 (min time:<PHONE_NUMBER>388, max time:<PHONE_NUMBER>000) 01GZ0Z1QA4HWJ4SX0RXJFZTM5X (min time:<PHONE_NUMBER>388, max time:<PHONE_NUMBER>000) 01GZ15XEJ2M6M0QH50XRQC3M65 (min time:<PHONE_NUMBER>388, max time:<PHONE_NUMBER>000) 01GZ1CS5T1VQ52EWBAWBSX7Z3W (min time:<PHONE_NUMBER>388, max time:<PHONE_NUMBER>000)]"

What you expected to happen:
I believe the thanos compact should be able to deduplicate or merge blocks if that is the case? Not really sure
Full logs to relevant components:
I inspected the bucket and the blocks ID in the error message are the following:
|            ULID            |         FROM         |        UNTIL         |     RANGE      |   UNTIL-DOWN    |  #SERIES   |    #SAMPLES    |   #CHUNKS   | COMP-LEVEL | COMP-FAILED |                                                           LABELS                                                            | RESOLUTION |  SOURCE   |
|----------------------------|----------------------|----------------------|----------------|-----------------|------------|----------------|-------------|------------|-------------|-----------------------------------------------------------------------------------------------------------------------------|------------|-----------|
| 01H0FY8AR60GEVX3J3Q7Y7GSYG | 2023-04-27T00:00:00Z | 2023-04-27T12:00:00Z | 11h59m59.612s  | 28h0m0.388s     | 3,219      | 6,655,129      | 59,010      | 3          | false       | cluster=operations-staging,thanos_ruler_replica=thanos-ruler-evaluator-1                                                    | 0s         | compactor |
| 01GZ0CAKEYN0BVTRW570T69QKM | 2023-04-27T00:00:00Z | 2023-04-27T02:00:00Z | 1h59m59.612s   | 38h0m0.388s     | 3,117      | 1,107,200      | 9,811       | 2          | false       | cluster=operations-staging                                                                                | 0s         | compactor |
| 01GZ0K651WJG1M9W2DMC050NHF | 2023-04-27T02:00:00Z | 2023-04-27T04:00:00Z | 1h59m59.612s   | 38h0m0.388s     | 3,117      | 1,107,198      | 9,812       | 2          | false       | cluster=operations-staging                                                                                | 0s         | compactor |
| 01GZ0R6020JTZ21GETCZCY5Y57 | 2023-04-27T04:00:00Z | 2023-04-27T06:00:00Z | 1h59m59.612s   | 38h0m0.388s     | 3,123      | 1,107,288      | 9,817       | 1          | false       | cluster=operations-staging,thanos_ruler_replica=thanos-ruler-evaluator-0                                                    | 0s         | ruler     |
| 01GZ0Z1QA4HWJ4SX0RXJFZTM5X | 2023-04-27T06:00:00Z | 2023-04-27T08:00:00Z | 1h59m59.612s   | 38h0m0.388s     | 3,134      | 1,107,689      | 9,827       | 1          | false       | cluster=operations-staging,thanos_ruler_replica=thanos-ruler-evaluator-0                                                    | 0s         | ruler     |
| 01GZ15XEJ2M6M0QH50XRQC3M65 | 2023-04-27T08:00:00Z | 2023-04-27T10:00:00Z | 1h59m59.612s   | 38h0m0.388s     | 3,134      | 1,108,467      | 9,831       | 1          | false       | cluster=operations-staging,thanos_ruler_replica=thanos-ruler-evaluator-0                                                    | 0s         | ruler     |
| 01GZ1CS5T1VQ52EWBAWBSX7Z3W | 2023-04-27T10:00:00Z | 2023-04-27T12:00:00Z | 1h59m59.612s   | 38h0m0.388s     | 3,203      | 1,117,342      | 9,908       | 1          | false       | cluster=operations-staging,thanos_ruler_replica=thanos-ruler-evaluator-0                                                    | 0s         | ruler     |

How is compactor configured? It looks like a historical compactor had different configuration than new one because the first block still has the replica label

I have 5 sharded compactors running with this config:
        - compact
        - --wait
        - --log.level=info
        - --log.format=logfmt
        - --objstore.config=$(OBJSTORE_CONFIG)
        - --data-dir=/var/thanos/compact
        - --debug.accept-malformed-index
        - --retention.resolution-raw=2y
        - --retention.resolution-5m=2y
        - --retention.resolution-1h=2y
        - --delete-delay=48h
        - --compact.concurrency=1
        - --downsample.concurrency=1
        - --deduplication.replica-label=prometheus_replica
        - --deduplication.replica-label=receive_replica
        - --deduplication.replica-label=thanos_ruler_replica
        - --compact.enable-vertical-compaction
        - |-
          --selector.relabel-config=
            - action: hashmod
              source_labels: ["cluster"]
              target_label: shard
              modulus: 5
            - action: keep
              source_labels: ["shard"]
              regex: 0

With regex: 0 going from 0 to 4.
Btw this is the exact same config I deploy on my other clusters (different clusters environments for different buckets) and only this one is giving these errors.

It's possible, It's been a while so I don't remember to be honest.
Either way, since then what I did is remove the chunks directly from my bucket (this is staging env so I don't care that much about the data itself, I just wanted to understand how I can solve this in case it comes up in prod)
However, eventually, thanos-compact halts again on a new set of chunks. Then I delete them, thanos-compact starts running until it halts again, etc
It's been like this for the past 2 weeks, and I have deleted a bunch of chunks, I thought there were a bunch of corrupted chunks or something like that but I'm starting to think it will be forever like this and I can't understand why

Facing the same issue due to which compaction is getting halted
ts=2023-11-28T08:24:05.350841732Z caller=compact.go:491 level=error msg="critical error detected; halting" err="compaction: group 300000@5350783008949816695: failed to run pre compaction callback for plan: [01HG7EDJNBXVZ2J0PQS2HT87Q8 (min time:<PHONE_NUMBER>002, max time:<PHONE_NUMBER>000) 01HGAG0TKWJ09CS7SBAXGXTBME (min time:<PHONE_NUMBER>000, max time:<PHONE_NUMBER>000)]: overlapping sources detected for plan [01HG7EDJNBXVZ2J0PQS2HT87Q8 (min time:<PHONE_NUMBER>002, max time:<PHONE_NUMBER>000) 01HGAG0TKWJ09CS7SBAXGXTBME (min time:<PHONE_NUMBER>000, max time:<PHONE_NUMBER>000)]"
Our current thanos compact config
    Args:
      compact
      --wait
      --log.level=info
      --log.format=logfmt
      --objstore.config=$(OBJSTORE_CONFIG)
      --data-dir=/var/thanos/compact
      --debug.accept-malformed-index
      --retention.resolution-raw=7d
      --retention.resolution-5m=30d
      --retention.resolution-1h=545d
      --delete-delay=48h
      --deduplication.replica-label=prometheus_replica
      --compact.enable-vertical-compaction
      --deduplication.func=penalty

We have 6 shards and 2 replicas for prometheus

Hi there, faced this issue too
thanos-compactor[2635699]: {"caller":"compact.go:527","err":"compaction: group 300000@7488097868448971783: failed to run pre compaction callback for plan: [01HZN4SYGV9HE0ZJC6ZMY31JVK (min time:<PHONE_NUMBER>000, max time:<PHONE_NUMBER>000) 01J06BGV9K11S7TV8JB35HAQRK (min time:<PHONE_NUMBER>000, max time:<PHONE_NUMBER>000)]: overlapping sources detected for plan [01HZN4SYGV9HE0ZJC6ZMY31JVK (min time:<PHONE_NUMBER>000, max time:<PHONE_NUMBER>000) 01J06BGV9K11S7TV8JB35HAQRK (min time:<PHONE_NUMBER>000, max time:<PHONE_NUMBER>000)]","level":"error","msg":"critical error detected; halting","ts":"2024-06-13T07:41:53.210408962Z"}

prometheus has 3 replicas
| 01HZN4SYGV9HE0ZJC6ZMY31JVK | 2024-03-14T03:00:00+03:00 | 2024-03-26T03:00:00+03:00 | 288h0m0s       | -48h0m0s        | 66,629,361  | 54,953,985,276  | 511,345,472   | 5          | false       | cluster=k8s.prod,environment=prod,manage_by=flux,prometheus=monitoring/prom-operator-prometheus                                                                         | 5m0s       | compactor |
root@monitoring-thanos-01:/opt/thanos/current# cat bucket_inspect | grep 01J06BGV9K11S7TV8JB35HAQRK
| 01J06BGV9K11S7TV8JB35HAQRK | 2024-03-22T03:00:00+03:00 | 2024-03-28T03:00:00+03:00 | 144h0m0s       | 96h0m0s         | 40,684,997  | 27,949,523,210  | 232,661,558   | 5          | false       | cluster=k8s.prod,environment=prod,manage_by=flux,prometheus=monitoring/prom-operator-prometheus

tried to add no compact, also found this issue about compact marks being ignored https://github.com/thanos-io/thanos/issues/5603


Abstracted the student data processing functionality into seperate fu…

…nctions to make logic more readable
Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #386

Hi @utsab and @GuillermoFloresV could either of you provide some more insight on the failing test?

Hi @utsab closing this PR due to odd behavior in sessions (I needed to created a new fork to revive my session) please see PR #402 for applied changes.


Make swagger available for the user facing apis

Briefly describe the feature

Make swagger ui available for below
Partner
Organization
Project
User
Group
Role
Role Permission
Kubectl Setting
OIDC Provider
Audit Log

What problem does this feature solve? Please link any relevant documentation or Issues

Makes it easy for developers wanting to interface with core component

swagger is now available at - https://paralus.github.io/paralus/
few pending items -
want to remove try out as this just serves as api documentation reference and is not backed by api server to fulfil the requests

this will be taken care of by https://github.com/paralus/website/issues/54
Closing this issue.


Follow Node importing semantics

Btw, this importing a json file will likely be useful for configuration files. It's pretty neat.

Some minor nits, but I'm happy with this.  Needs to be rebased, but it's ready

Addressed comments.


Create sample

make a new file for the pull command

Hello! Just a quick file addition to try out the pull request command for the library carpentry workshop.

Jen Stevens

okay, try number two on pull requests1

Jen Stevens


feat: add merge queue helpers

:pencil: Description
Adds a manage-merge-queue helper which can be used to implement a merge queue system on a repo's PRs.

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix(Mobile): Fix context menu on storage with long press

What this PR does 📖
This pull request includes several changes to improve the functionality and user experience of the context menu and file upload components. The most important changes include adding touch support for the context menu, refining the position calculation logic, and simplifying the file upload process.
Enhancements to context menu:

src/lib/components/ui/ContextMenu.svelte: Added touch support by implementing handleTouchStart and handleTouchEnd functions, and updated the openContext and calculatePos functions to handle both mouse and touch events. [1] [2] [3]
src/lib/components/ui/ContextMenu.svelte: Added event listeners for touch events in onMount and removed them in onDestroy.

Which issue(s) this PR fixes 🔨

Resolve #

Special notes for reviewers 🗒
Additional comments 🎤

this PR has the same content as this one
#894
which one do you want merged first?

#894 first.


:apple: [New Product] "Apple iMac"

Full and short name of product
Let us know the long, full name and, if it has one, the short name (for example, PowerShell and pwsh).

Full name : Apple iMac
Short name : Apple iMac

Does this product have LTS versions? What are the intervals between each LTS version?
At this stage I don't know.
For example, a current release is a release that occurs between LTS releases. Current releases can contain critical fixes.

What is the website for the product and for its version information?

Officiel site
Wikipedia

@adriens, for new products, could you :

use the New product suggestion template,
provide the required information (such as the versions information).

Thanks !

Sure :+1:

WIP 🚀

✔ Done.


Reimplement as a Go binary

An idea that @rgbkrk and I have been tossing around.
Pros

Single-binary, zero-dependency binary that's easy to install.

No need to worry about preserving cross-shell compatibility.

Cons

dvm use can't be done directly because we aren't sourced into the shell; we'll need to do eval hacks like docker-machine env uses.
Can't leverage nvm source as a reference.
It means rewriting all of our existing work.

What do you think about calling it goblin (go bin manager).
There's always the hybrid approach of dvm + goblin, where we package up the binary on the side. Then I imagine we can write dvm.ps1 or whatever (ping @carolynvs, @DonSchenck), relying on goblin for cross platform functionality.

On Windows using wrapper scripts is pretty normal. I think it would have a better user experience for the lowest common denominator too (cmd), because with just the binary (a la docker-machine env) they have to copy/paste the output and run it manually which is awkward.

What do you think about calling it goblin (go bin manager).

Like as a generic thing? The problem with that is getting it to handle install and ls-remote generically. It seems like every binary we'd want to support would have a different versioning and release strategy. We could bake in GitHub releases support, but our very first use case, Docker, doesn't follow that, so...
I like the name, I'm just not sure how the details work out there.

There's always the hybrid approach of dvm + goblin, where we package up the binary on the side.

:+1: I do like this idea. Of course, we have the problem of packaging the binary. I'd rather not check it in to git if we have a different way to ship it with dvm...

On Windows using wrapper scripts is pretty normal. I think it would have a better user experience for the lowest common denominator too (cmd), because with just the binary (a la docker-machine env) they have to copy/paste the output and run it manually which is awkward.

:sparkles: Cool. Sounds reasonable on the Windows end, then.

As I'm working on dvm.ps1 I'm really wishing we had a go binary. :smile: I'm going to take a day and take a stab at it.

Feel free to cargo cult from, e.g. https://github.com/aktau/github-release.

Any suggestions for how the go binary should indicate to the shell wrapper that it should set some environment variables?

Magic output. Shell wrapper will look at the output for commented out environment variable commands and run them
# Lots of output that the wrapper ignores
# export DOCKER_HOST=tcp://<IP_ADDRESS>:2376  (okay run this line)

Dump to a file in the .dvm directory and run what's in there

?

Assume we can eval things that are on stdout?

(Yes I'm bad)

I don't think eval will work. Docker machine currently can't tell if it's running on cmd or powershell, just the os which is why they make you pass in --shell to the docker-machine env command.
So it will be up to the wrapper script to grab the key/values and set them.

Well also we can build specific things on windows vs Linux vs OS X, see carina for that. As for detecting powershell vs cmd, well yeah you're right there and dvm can say what shell it was invoked from.

Unless you are set on eval'ing the output, I'm going to try first to place a file in .tmp and have the wrapper just look for that after commands and run it. I notice that dvm use has a silent flag which suppresses all output which that would break.


fix(InlineContent): check if item is text or text object before adding margin and adjust whitespace parsing

Description

Previously, the spacing around the "with some red" in the InlineContent story looked larger than the other spacing. This was because the actual whitespace characters were being stripped out in this object and the flexItem's marginRight was being used instead. This ensures the whitespace characters are retained and the spacing matches the rest of the text in the component. Additionally, this ensures that text and text objects found next to each other in a string do not add the extra marginRight. Previously this was only being applied to text that was the string type.
References

Testing

Observe the normalized spacing amount within text in the story and that text and text objects adhere to the actual whitespace characters, not extra marginRight's.
Automation

Checklist

[ ] all commented code has been removed
[ ] any new console issues have been resolved
[ ] code linter and formatter has been run
[ ] test coverage meets repo requirements
[ ] PR name matches the expected semantic-commit syntax

Test Execution Failed.

Test Execution Failed.

:tada: This PR is included in version @lightningjs/ui-components-v2.18.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


x/crypto: x509: invalid certificate policies

certBlock, _ := pem.Decode([]byte(publicKey))
certificate, err = x509.ParseCertificate(certBlock.Bytes)
if err != nil {
    fmt.Println("Unable to parse certificate ", err)
    return
}

I am getting below error while trying to Parse a pem file
"x509: invalid certificate policies"

I am able to Parse the same certificate in Python using OpenSSL package.

What version of Go are you using (go version)?

$ go version
go1.17.10 darwin/arm64

Does this issue reproduce with the latest release?
No
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/F1815/Library/Caches/go-build"
GOENV="/Users/F1815/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/F1815/Go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/F1815/Go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
<EMAIL_ADDRESS>GOSUMDB="sum.golang.org"
GOTMPDIR=""
<EMAIL_ADDRESS>GOVCS=""
GOVERSION="go1.17.10"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/F1815/bitbucket/panverification-nsdl/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/2m/hnqlmbbn65304zdfqp3gvrt80000gp/T/go-build1656833850=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

What did you expect to see?
I am expecting successful parsing of certificate
What did you see instead?
Getting error: x509: invalid certificate policies

Without a reproducer (certificate that triggers the problem), this issue is inactionable.


Fund your own project

One possible use case is for a company to set aside a budget to compensate contributors to its open source projects. In this case the money would be coming from the company rather than from payments received on Gratipay.

Folding #4324 into this ...

Reticketed from https://github.com/gratipay/inside.gratipay.com/issues/432#issuecomment-163738482:

The flip side would be an organization that wanted to use us for payroll but not for payments. @timothyfcook has asked for this before. He wants to use Gratipay to distribute payroll for projects that are grant funded outside of Gratipay.

Also cropped up in slack (cc: @simonmichael).

+1 in private email (from someone at a top-25 Internet company) :

One of the things that I've always been interested in is not just "<Company> gives $x to project", but also the flip side of that too. I would like a way for "<Company> to give $x developer, for their contributions to <Company> project".
Not just giving back to the projects that we use, but to the developers that donate their time to our open source projects.

+1 from @bcomnes in slack.

Seems like this is related to adding funds at any time (#113).

Or possibly drawing funds from a project as a member at any time.  Maybe I'm still stuck in thinking in terms of bank accounts though.


Supermemory x Friend integration

Can you explain a little bit @Dhravya ?

Didnt see any changes, closing for now


Add Magefiles as port of Makefile functionality

Disclaimer: I've never written any Go before and this is my first attempt ever to write some.  Please, don't spare me your criticism.
This is first multi-platform stab at the idea of the true Windows support in #203

This Mage port of the current Makefile which is supposed to offer equivalent functionality as the existing Makefile. The Magefiles implementation is also inspired by the make.ps1 recently proposed in #254.
The initial reaction to the #254 suggested the Magefiles are preferred as a single multi-platform solution.
So, if the Magefiles are accepted, then this PR should completely replace the make.ps1 proposal in #254.

The Magefiles currently deploy Kubernetes from downloaded binaries, because on Windows building from sources is not yet solved, see #255. On Linux host, Kubernetes can be built from sources and this option will be added to these Magefiles in near future.
First, let's get this solution working solid from the pre-built binaries.

I've converted this PR to draft. Let's get the Vagrant box working solid first as per @jayunit100 suggestion at last SIG-Windows meeting.


Update Kotlin

Let's use Kotlin 1.2.51, which is included into IJ 2018.2

Hi! Any reason for this? Btw, in the example 2016.3.1 is used.

Good point. Anyways, all users will likely to upgrade it at first. Will it
fail?
On Mon, Jul 30, 2018 at 3:11 PM Alexander Zolotov<EMAIL_ADDRESS>wrote:

Hi! Any reason for this? Btw, in the example 2016.3.1 is used.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JetBrains/gradle-intellij-plugin/pull/306#issuecomment-408857804,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPpr-7K1mJTmLL5Yioysn2Zz4Y0rfiuks5uLwX7gaJpZM4Vih-s
.

Upgraded manually


Mount controller sets the password to the same value as the username

Hi,
Sorry if this is not maintained anymore, but I was testing the controller for a project I'm working in and came across this bug.
When installing the controller, and setting a correct user name and password, I would get the message:
manager 2024-08-22T15:07:08.984Z DEBUG controller-runtime.manager.events Warning {"object": {"kind":"MountPoint","namespace":"netconf-operator","name":"netconf-server","uid":"41f83a04-4cb5-4c6f-95ca-36488edbdd60","api Version":"netconf.openshift-telco.io/v1","resourceVersion":"338240900"}, "reason": "ProcessingError", "message": "ssh: handshake failed: ssh: unable to authenticate, attempted methods [none password], no supported methods remain"} manager 2024-08-22T15:07:08.996Z ERROR controller-runtime.manager.controller.mountpoint Reconciler error {"name": "netconf-server", "namespace": "netconf-operator", "error": "ssh: handshake failed: ssh: unable to auth enticate, attempted methods [none password], no supported methods remain"}
Checking the code, I realized there's a typo and I submitted a pull request to fix it:
https://github.com/openshift-telco/netconf-operator/pull/2

fixed https://github.com/openshift-telco/netconf-operator/pull/2

Thanks @nrledo


[WIP] Update vpp-agent to v2.2.0

Signed-off-by: Artem Belov<EMAIL_ADDRESS>Description
vpp-agent v2.2.0
Motivation and Context
Added SRv6 support into vpp-agent Configurator Client.
How Has This Been Tested?

[x] Covered by existing integration testing
[ ] Added integration testing to cover
[x] Tested locally
[ ] Have not tested

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

This one is obsolete now.


feature/#6766 JSON and Startree index information in API

This PR exposes information about JSON index and star tree index in the segment metadata API.
Sample response:
"columns": [],
"indexes": {
    "studentID": {
        "bloom-filter": "NO",
        "dictionary": "YES",
        "forward-index": "YES",
        "inverted-index": "YES",
        "null-value-vector-reader": "NO",
        "range-index": "NO",
        "json-index": "NO"
    },
    "firstName": {
        "bloom-filter": "NO",
        "dictionary": "YES",
        "forward-index": "YES",
        "inverted-index": "NO",
        "null-value-vector-reader": "NO",
        "range-index": "NO",
        "json-index": "NO"
    }
},
"startree-index": [
    {
        "dimension-columns": [
            "studentID",
            "firstName"
        ],
        "metric-aggregations": [
            {
                "column": "col1",
                "aggregation": "SUM"
            },
            {
                "column": "col2",
                "aggregation": "DISTINCT"
            },
            {
                "column": "*",
                "aggregation": "COUNT"
            }
        ],
        "max-leaf-records": 1,
        "dimension-columns-skipped": [
            "col3"
        ]
    }
]

Codecov Report

Merging #6873 (1ab6007) into master (d5e7106) will decrease coverage by 30.94%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #6873       +/-   ##
=============================================
- Coverage     74.05%   43.11%   -30.95%
+ Complexity       12        7        -5
=============================================
  Files          1421     1430        +9
  Lines         69141    70568     +1427
  Branches       9986    10202      +216
=============================================
- Hits          51204    30426    -20778
- Misses        14590    37514    +22924
+ Partials       3347     2628      -719

Flag
Coverage Δ
Complexity Δ

integration
43.11% <0.00%> (-0.53%)
7.00 <0.00> (ø)

unittests
?
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5e7106...1ab6007. Read the comment docs.

Hey @kriti-sc please resolve the merge conflict and fix the test, then i'll merge this

@Jackie-Jiang the tests are passing, this PR is ready to be merged.


[Bug]: Cant drag and drop into canvas

Bug Description
After opening a page in the plugin, drag and dropping links, text, pictures or anything into a canvas or note do not copy the text. Hovering the canvas/note with mouse button pressed shows the "plus" icon, but after releasing the mouse button nothing happens.
Copy-Paste works as expected.
Relevant Screenshot
No response
To Reproduce

Enable the Surfing plugin
Open a web page
Highlight something, drag and drop it into a canvas/note
Nothing happens

Obsidian Version
1.5.3
web-browser-only

[X] Did you install only one web browser plugin?

Checklist

[X] I updated to the latest version of the plugin.

+1，This bug is very serious and affects me a lot

Got fixed already.

There still seems to be in trouble
If I open a web page, drag and drop still doesn't work
If I close all web pages, drag and drop is available


WebNotification of Crosswalk Linux

The WebNotification of Crosswalk Linux is implemented based on 'libnotify'.
Refering to https://wiki.archlinux.org/index.php/Desktop_notifications,
the 'libnotify' is a desktop independent lib to invoke 'notification server'
through DBus named 'org.freedesktop.Notifications' (on Ubuntu it's 'notify-osd' behind).
There 3 reasons to use 'libnotify'
(1) The Chrome Linux creates 'desktop notification' by self and it's hard to port since most of
code is for 'Rich notification' proveded by extension.
refer to https://developer.chrome.com/apps/richNotifications.
(2) Firefox and WebKit using 'libnotify' to implement WebNotification.
(3) The desktop of Deepin supports 'libnotify' by default.
Add a new class 'XWalkNotificationManagerLinux' to implement logic to invoke 'libnotify':
(1) Init and uninit 'libnotify' in constructor and destructor.
(2) In 'ShowDesktopNotification', call 'notify_notification_new' and 'notify_notification_show'
to create new notifaication record and show it.
If just need to relace old notification, call 'notify_notification_update' to update the
record.
(3) Listen signal 'closed' with callback 'NotificationClosedCallback' to trigger the JS callbacks,
such as 'Notification.onclose'.
(4) The memeber 'notifications_map_' is for saving the map between 'notification' and its
'delegate' (used to trigger JS callbacks).
The 'notifications_replace_map_' is used to record the notification created with relace tag,
like this:
new Notification("", {tag: ''});
BUG=https://crosswalk-project.org/jira/browse/XWALK-286

Seems, trybot need to install 'libnotify-dev' to compile my patch. My patch has been compiled and tested with newest version on my local PC.
@pozdnyakov @kenchris @takethathe @seanlong , please help to review, thank you very much.

@rakuco @halton
My patch should be compiled with  'libnotify-dev', but I don't find a place to declare this new dependency.
Am I misunderstanding some something? Please give some tips, thank you very much.

@PeterWangIntel
For the linux, you need ask @rakuco to add libnotify-dev on the buildbot/trybot slaves.
For the Tizen, you need modify src/xwalk/packaging/crosswalk.spec add that Requires/BuildRequires part.

@pozdnyakov @halton
Patch has been updated according to the comments, please have a look, thank you for your time.

@pozdnyakov @rakuco @halton , patch has been updated, please have a look, thank you very much.

One thing I didn't get is why this is disabled on Tizen -- libnotify is available there, so is there any other reason why the code wouldn't work there too?

@rakuco

One thing I didn't get is why this is disabled on Tizen -- libnotify is available there, so is there any other reason why the code wouldn't work there too?

The reasons are:
(1) There is another way (better way, maybe) to implement WebNotification for Tizen depending on the desktop of it.
(2) Now, we're mainly trying to implement WebNotification for Linux, if we implement it for Tizen 'by the way', we have to ask QA to do extra test and explain to all why we need WebNotification for Tizen :(

Was the PR closed on purpose?

@rakuco @halton @pozdnyakov
It's weird, I didn't close this pull request on purpose.
The pull request is time out? Or some misoperation?
I still need this patch to be reviewed.

@rakuco @halton @pozdnyakov
Pull request #2872 is the new update

@PeterWangIntel are you deleting your remote branch?

@halton
No, just did a 'git push -f' to update this branch.

this branch is updated already.


make new page pane use filterable list

this changes the new page pane to use the filterable list, rather than a list of buttons. it's the first step towards making the new page cloning more dynamic.

Coverage remained the same at 79.985% when pulling 8ec669a0ca85fd22a8328579bbe078a60efb47f1 on new-page-list into a47f291e8b3c7ccabe7d4984b764455216debe04 on master.

👍


Updated start script help text and custom commands. Fixed #1987.

I tested it:

short help summary text for createsettings --help still missing.
openslides --help contains only start and createsettings in the list of available subcommands. The list contains all (for OpenSlides relevant) subcommands. Move these subommand from epilog to the list and add a short help text. Here my suggestion:

$ openslides --help
usage: openslides [-h] [--version] {start,createsettings} ...

Start script for OpenSlides. If it is called without any argument, this will
be treated as if it is called with the 'start' subcommand. That means
OpenSlides will setup default settings and database, start the tornado
webserver, launch the default web browser and open the webinterface.

optional arguments:
  -h, --help            show this help message and exit
  --version             Show version number and exit.

Available subcommands:
  Type 'openslides <subcommand> --help' for help on a specific subcommand.

    start               Setup settings and database, start tornado webserver,
                        launch the default web browser and open the
                        webinterface. The environment variable
                        DJANGO_SETTINGS_MODULE is ignored.
    createsettings      Create the settings file.
    createsuperuser     Creates or resets the admin user.
    backupdb            Backups the SQLite3 database.
    migrate             Updates database schema.
    runserver           Starts the Tornado webserver.

There are some more subcommands available which belong to Django's
command-line utility for administrative tasks. Type 'openslides help' (without
the two hyphen-minus characters) to list them all.
Type 'openslides <subcommand> help' for help on a specific subcommand.

Question: Is the subcommand syncdb still required? Or is this command already included in migrate? So, what's required to enter if an user want's to start OpenSlides without start command? createsettings -> migrate -> runserver? Anything else?

I think about if the option --development (of openslides start --development) has the right wording... It's not really a development feature to keep all settings/database etc. in the same directory and not in .config and .local. So my suggestion: rename this option and improve the help text (command for development purpose) which is not really helpful to understand what this option make.

python manage.py createsettings --help prints out some help text. What is missing here?

Syncdb is deprecated. Use only migrate. The workflow is: createsettings, migrate, runserver.

Ready for next review. Renaming --development option is another issue you have to open.

python manage.py createsettings --help shows only "usage" and "optional arguments" but no summary help text which describe what the subcommand do (the other subcommands have a summary help)

Please remove the string {start, createsettings} You can choose only one subcommand at once. This is not really helpful and django doesn't do this in it's help.

For renaming --development option see #2001.

So, two remarks still open.

Removing the string {start, createsettings} ... is possible but there remains an empty line which is build deep inside the argparse lib. So I propose to remove only the first part of the string. The other thing is fixed.

Ok. One last question: Is it possible to prevent the unattractive linebreaks after the long subcommands createsettings and createsuperuser? See:
Available subcommands:
  Type 'manage.py <subcommand> --help' for help on a specific subcommand.

                   You can choose only one subcommand at once.
    start          Setup settings and database, start tornado webserver,
                   launch the default web browser and open the webinterface.
                   The environment variable DJANGO_SETTINGS_MODULE is ignored.
    createsettings
                   Creates the settings file.
    backupdb       Backups the SQLite3 database.
    createsuperuser
                   Creates or resets the admin user.
    migrate        Updates database schema.
    runserver      Starts the Tornado webserver.

If not, please rebase and merge.

I don't know how to change the linebreaks. These things are deeply inside the argparse lib.


Work Email Registration

Regarding:
"You must register with your work email, which should be independent from any personal account you may have on Github."
From @benbalter:
"We actually suggest the opposite in the best-practices peer group.  (https://government-community.githubapp.com/government/best-practices/blob/master/docs/account-management.md#requiring-users-to-establish-purpose-specific-accounts)  Beyond making things harder for developers in terms of Git configuration and SSH keys, unlike say, Twitter, where it’s normal to have multiple accounts, GitHub allows you to have multiple email addresses, and be associated with multiple organizations, automatically disambiguating your use, depending on what context your in.
You may also want to clarify the difference between an organization account and an individual account. Humans should have one user account, bureaus should have an organization account (which you will need a user account to create), of which that user is a member.

Agreed. This is how I set my account up.

Also, the former is technically against the GitHub Terms of Service:

One person or legal entity may maintain no more than one free Account

https://help.github.com/articles/github-terms-of-service/#3-account-requirements
(Also, 👋 from a new developer under Census!)


Pod connect externel mysql error

Hello ,I want to use service in pod to connect   Externel Mysql but  not use
in kubernetes  i want to use service and endpoint  to connect a externel mysql like this
kind: Endpoints
apiVersion: v1
metadata:
  name: mysql-endpoint
  namespace: default
subsets:
  - addresses:
      - ip: <IP_ADDRESS> # this is externel mysql ip address
    ports:
      - port: 3306
---------
apiVersion: v1
kind: Service
metadata:
  name: mysql-endpoint
  namespace: default
spec:
  ports:
    - port: 3306

now i have a Service like this
Name:              mysql-endpoint
Namespace:         default
Labels:            <none>
Annotations:       kubectl.kubernetes.io/last-applied-configuration:
                     {"apiVersion":"v1","kind":"Service","metadata":{"annotations":{},"name":"mysql-endpoint","namespace":"default","selfLink":"/api/v1/namespa...
Selector:          <none>
Type:              ClusterIP
IP:                <IP_ADDRESS>
Port:              <unset>  3306/TCP
TargetPort:        3306/TCP
Endpoints:         <IP_ADDRESS>:3306
Session Affinity:  None

Expected Behavior
In hope that i can use clusterIp + port to connect Externel mysql  in pod
Current Behavior
in  cluster  node  i can telnet  clusterIp port  this Service ,
# telnet <IP_ADDRESS> 3306
Trying <IP_ADDRESS>...
Connected to <IP_ADDRESS>.
Escape character is '^]'.

but in pod i can't  ,
# nc -vzw 10 <IP_ADDRESS> 3306
nc: <IP_ADDRESS> (<IP_ADDRESS>:3306): Operation timed out

Possible Solution
i try to modify NetworkPolicy  allow-all
kubectl apply -f - <<EOF
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: allow-all
spec:
  podSelector: {}
  egress:
  - {}
  policyTypes:
  - Egress
EOF
------------------
kubectl create -f - <<EOF
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: allow-all-1
spec:
  podSelector: {}
  ingress:
  - {}
EOF

but not use
then
i use tcpdump  in mysql node  i got this
15:59:33.043557 IP <IP_ADDRESS>.36009 > nsxjapptst01.cs1cloud.internal.mysql: Flags [S], seq<PHONE_NUMBER>, win 28000, options [mss 1400,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0
15:59:33.043614 IP nsxjapptst01.cs1cloud.internal.mysql > <IP_ADDRESS>.36009: Flags [S.], seq 195091831, ack<PHONE_NUMBER>, win 28960, options [mss 1460,sackOK,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>,nop,wscale 7], length 0

and tcpdump in pod node
16:35:13.452727 IP <IP_ADDRESS>.42053 > nsxjapptst01.cs1cloud.internal.mysql: Flags [S], seq<PHONE_NUMBER>, win 28000, options [mss 1400,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0
16:35:14.455413 IP <IP_ADDRESS>.42053 > nsxjapptst01.cs1cloud.internal.mysql: Flags [S], seq<PHONE_NUMBER>, win 28000, options [mss 1400,sackOK,TS val<PHONE_NUMBER> ecr 0,nop,wscale 7], length 0

Package has Already arrived to mysql node ,but   NO Package Return
<IP_ADDRESS>  this is my pod IP but mysql node has no route to <IP_ADDRESS>/16  so package can't return
so i configed calico ip pool
like this
https://docs.projectcalico.org/master/usage/external-connectivity
cat << EOF | calicoctl apply -f -
- apiVersion: projectcalico.org/v3
  kind: IPPool
  metadata:
    name: default-ipv4-ippool
  spec:
    cidr: <IP_ADDRESS>/16
    ipipMode: Always
    natOutgoing: true
EOF

but it still not work
in mysql node tcpdump not change
How can i Connect mysql in pod?

@Rogary I'd expect the traffic to go through an SNAT, because you set natOutgoing: true. You're still seeing the traffic reach the SQL node with a source address of the pod?
Could you show the output of this command? calicoctl get ippool -o yaml


Add data builder

Add a data builder to support data transformation from one stage to another.
DataBuilder is used to manipulate and store data. The data from the previous filter can be transformed and stored in the context so that the data can be used in subsequent filters.
Configuration

Name
Type
Description
Required

template
string
template to create data, please refer the template for more information
Yes

dataKey
string
key to store data
Yes

leftDelim
string
left action delimiter of the template, default is {{
No

rightDelim
string
right action delimiter of the template, default is }}
No

Results

Value
Description

buildErr
Error happens when build the result.

I've updated the template filed to be required.


Can't disable response times in footer

Gogs version (or commit ref): <IP_ADDRESS>1
Git version: <IP_ADDRESS>
Operating system: CentOS 7 (7.2)
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[x] No
[ ] Not relevant

Description
I can't get rid of the response times in the footer. This is set in my custom app.ini file:
[other]
SHOW_FOOTER_VERSION            = false
SHOW_FOOTER_TEMPLATE_LOAD_TIME = false

Has some experienced a similar issue?

This was added in bc902b8f745efe91e9dce5e4c5f5f2d5d760fbfb which isn't released yet unfortunately.

Duplicated to https://github.com/gogits/gogs/issues/3492.


Consider deprecating system-tools

This issue is to discuss to deprecate system-tools (https://github.com/rancher/system-tools)
The remove/cleanup functionality was moved into https://github.com/rancherlabs/support-tools/tree/master/cleanup-rancher-k8s-resources
The log functionality was moved into https://github.com/rancherlabs/support-tools/tree/master/collection/rancher/v2.x
And the stats functionality was never really used.

[X] Moved functionality somewhere else
[X] Documented in docs and GitHub repository
[X] Archived system-tools GitHub repository


AeronPublisher renamed into AeronFlux

AeronPublisher renamed into AeronFlux
package structure changed
other multiple improvements

lol :) :+1:

Alex, why are you laughing :) ?

Perfekt name AeronFlux


Enum Information

Show enum information in data dictionary description column.

Rejected because enum is in the same level as description.


Missed case for listing cStor volumes

When a PVC is provisioned and the CStorVolume might not be created the current logic is not sufficient to list the instances.

This can be expanded into a few more test cases like:

Checking what is the minimum OpenEBS version required for openebsctl to work. And in case user tries with older openebs version, does it gracefully error out?
Test the commands by breaking the components - for example if listing cstor volume:

create a PV (with reclaim policy as retain), delete the PVC
create a PV - delete manually some of the sub CRs and check if openebsctl can gracefully validate and display missing information

We have tried the above mentioned cases and these are the observations:

If CstorVolume is not created, the get command will not the list the volume.
If PVC is deleted and the volume has a reclaim policy of Retain, then the flow works as expected, the CstorVolume is listed and the describe also works without any error.
If subCR like CVC is deleted then theCstorVolume and the CVR also gets deleted and thus it is will not list the CstorVolume. Although if we do a kubectl get pv we will be able to see the PV and if we pass the PV name in the kubectl openebs volume describe command it will show a error i.e. failed to execute volume info command, getting cStor volumes: error while while getting volume <volume name>: cstorvolumes.cstor.openebs.io "<volume name>" not found.
If subCR like CVR is deleted then the flow works as expected i.e the CstorVolume will be listed and on describe in the replica section it shows None of the replicas are running


Cross browser fixes

This PR adds fixes to layout and functionality to a variety of browsers.
This includes IE7+

checking tests on local

passes on local, good to merge ? @hammerfunk


fix: search on vessel class is case insensitive

Hello @Natday! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tests/endpoints/test_vessels_real.py:

Line 81:9: E303 too many blank lines (2)


Another place where we need to be more robust to beaker timeouts

🐛 Describe the bug
https://beaker.org/ex/01GCDCM42CFMK9YENG3Y21VZER/tasks/01GCDCM43MY13H6PAPA82F8RPT/job/01GCDCMAJB0A7SMH69DMWW03YZ
2022-09-08T09:07:22.783694830Z                              Traceback (most recent call last):
2022-09-08T09:07:22.783701183Z                                File "/opt/conda/lib/python3.9/site-packages/urllib3/connectionpool.py", line 449, in _make_request
2022-09-08T09:07:22.783706363Z                                  six.raise_from(e, None)
2022-09-08T09:07:22.783710932Z                                File "<string>", line 3, in raise_from
2022-09-08T09:07:22.783715832Z                                File "/opt/conda/lib/python3.9/site-packages/urllib3/connectionpool.py", line 444, in _make_request
2022-09-08T09:07:22.783720492Z                                  httplib_response = conn.getresponse()
2022-09-08T09:07:22.783724830Z                                File "/opt/conda/lib/python3.9/http/client.py", line 1377, in getresponse
2022-09-08T09:07:22.783729700Z                                  response.begin()
2022-09-08T09:07:22.783733758Z                                File "/opt/conda/lib/python3.9/http/client.py", line 320, in begin
2022-09-08T09:07:22.783738347Z                                  version, status, reason = self._read_status()
2022-09-08T09:07:22.783742345Z                                File "/opt/conda/lib/python3.9/http/client.py", line 281, in _read_status
2022-09-08T09:07:22.783748017Z                                  line = str(self.fp.readline(_MAXLINE + 1), "iso-8859-1")
2022-09-08T09:07:22.783773608Z                                File "/opt/conda/lib/python3.9/socket.py", line 704, in readinto
2022-09-08T09:07:22.783777716Z                                  return self._sock.recv_into(b)
2022-09-08T09:07:22.783781273Z                                File "/opt/conda/lib/python3.9/ssl.py", line 1241, in recv_into
2022-09-08T09:07:22.783785141Z                                  return self.read(nbytes, buffer)
2022-09-08T09:07:22.783788668Z                                File "/opt/conda/lib/python3.9/ssl.py", line 1099, in read
2022-09-08T09:07:22.783792556Z                                  return self._sslobj.read(len, buffer)
2022-09-08T09:07:22.783796193Z                              socket.timeout: The read operation timed out
2022-09-08T09:07:22.783799910Z
2022-09-08T09:07:22.783803477Z                              During handling of the above exception, another exception occurred:
2022-09-08T09:07:22.783807405Z
2022-09-08T09:07:22.783811033Z                              Traceback (most recent call last):
2022-09-08T09:07:22.783814830Z                                File "/opt/conda/lib/python3.9/site-packages/requests/adapters.py", line 440, in send
2022-09-08T09:07:22.783818848Z                                  resp = conn.urlopen(
2022-09-08T09:07:22.783822666Z                                File "/opt/conda/lib/python3.9/site-packages/urllib3/connectionpool.py", line 787, in urlopen
2022-09-08T09:07:22.783826293Z                                  retries = retries.increment(
2022-09-08T09:07:22.783830020Z                                File "/opt/conda/lib/python3.9/site-packages/urllib3/util/retry.py", line 550, in increment
2022-09-08T09:07:22.783833618Z                                  raise six.reraise(type(error), error, _stacktrace)
2022-09-08T09:07:22.783837445Z                                File "/opt/conda/lib/python3.9/site-packages/urllib3/packages/six.py", line 770, in reraise
2022-09-08T09:07:22.783845201Z                                  raise value
2022-09-08T09:07:22.783849089Z                                File "/opt/conda/lib/python3.9/site-packages/urllib3/connectionpool.py", line 703, in urlopen
2022-09-08T09:07:22.783852736Z                                  httplib_response = self._make_request(
2022-09-08T09:07:22.783856503Z                                File "/opt/conda/lib/python3.9/site-packages/urllib3/connectionpool.py", line 451, in _make_request
2022-09-08T09:07:22.783860111Z                                  self._raise_timeout(err=e, url=url, timeout_value=read_timeout)
2022-09-08T09:07:22.783863968Z                                File "/opt/conda/lib/python3.9/site-packages/urllib3/connectionpool.py", line 340, in _raise_timeout
2022-09-08T09:07:22.783867606Z                                  raise ReadTimeoutError(
2022-09-08T09:07:22.783872105Z                              urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='data.beaker.org', port=443): Read timed out. (read
2022-09-08T09:07:22.783875732Z                              timeout=5.0)
2022-09-08T09:07:22.783879279Z
2022-09-08T09:07:22.783882826Z                              During handling of the above exception, another exception occurred:
2022-09-08T09:07:22.783886423Z
2022-09-08T09:07:22.783889930Z                              Traceback (most recent call last):
2022-09-08T09:07:22.783893447Z                                File "/opt/conda/bin/tango", line 8, in <module>
2022-09-08T09:07:22.783897335Z                                  sys.exit(main())
2022-09-08T09:07:22.783901143Z                                File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1130, in __call__
2022-09-08T09:07:22.783904750Z                                  return self.main(*args, **kwargs)
2022-09-08T09:07:22.783911533Z                                File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1055, in main
2022-09-08T09:07:22.783915521Z                                  rv = self.invoke(ctx)
2022-09-08T09:07:22.783919449Z                                File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1657, in invoke
2022-09-08T09:07:22.783923147Z                                  return _process_result(sub_ctx.command.invoke(sub_ctx))
2022-09-08T09:07:22.783926674Z                                File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
2022-09-08T09:07:22.783930341Z                                  return ctx.invoke(self.callback, **ctx.params)
2022-09-08T09:07:22.783934179Z                                File "/opt/conda/lib/python3.9/site-packages/click/core.py", line 760, in invoke
2022-09-08T09:07:22.783937826Z                                  return __callback(*args, **kwargs)
2022-09-08T09:07:22.783941423Z                                File "/opt/conda/lib/python3.9/site-packages/tango/__main__.py", line 391, in beaker_executor_run
2022-09-08T09:07:22.783945331Z                                  executor.execute_step(step)
2022-09-08T09:07:22.783948898Z                                File "/opt/conda/lib/python3.9/site-packages/tango/executor.py", line 81, in execute_step
2022-09-08T09:07:22.783952475Z                                  step.ensure_result(self.workspace)
2022-09-08T09:07:22.783956243Z                                File "/opt/conda/lib/python3.9/site-packages/tango/step.py", line 619, in ensure_result
2022-09-08T09:07:22.783959820Z                                  self.result(workspace)
2022-09-08T09:07:22.783963437Z                                File "/opt/conda/lib/python3.9/site-packages/tango/step.py", line 590, in result
2022-09-08T09:07:22.783967285Z                                  return self._run_with_work_dir(workspace, needed_by=needed_by)
2022-09-08T09:07:22.783970812Z                                File "/opt/conda/lib/python3.9/site-packages/tango/step.py", line 428, in _run_with_work_dir
2022-09-08T09:07:22.783974439Z                                  result = workspace.step_finished(self, result)
2022-09-08T09:07:22.783981173Z                                File "/opt/conda/lib/python3.9/site-packages/tango/integrations/beaker/workspace.py", line 163, in step_finished
2022-09-08T09:07:22.783984900Z                                  self.cache[step] = result
2022-09-08T09:07:22.783988487Z                                File "/opt/conda/lib/python3.9/site-packages/tango/integrations/beaker/step_cache.py", line 144, in __setitem__
2022-09-08T09:07:22.783992185Z                                  self._sync_step_dataset(step, temp_dir)
2022-09-08T09:07:22.783995742Z                                File "/opt/conda/lib/python3.9/site-packages/tango/integrations/beaker/step_cache.py", line 72, in
2022-09-08T09:07:22.783999399Z                              _sync_step_dataset
2022-09-08T09:07:22.784002946Z                                  self.beaker.dataset.sync(dataset, objects_dir, quiet=True)
2022-09-08T09:07:22.784006513Z                                File "/opt/conda/lib/python3.9/site-packages/beaker/services/dataset.py", line 472, in sync
2022-09-08T09:07:22.784010211Z                                  actual_size = future.result()
2022-09-08T09:07:22.784013768Z                                File "/opt/conda/lib/python3.9/concurrent/futures/_base.py", line 439, in result
2022-09-08T09:07:22.784018016Z                                  return self.__get_result()
2022-09-08T09:07:22.784021603Z                                File "/opt/conda/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result
2022-09-08T09:07:22.784025221Z                                  raise self._exception
2022-09-08T09:07:22.784028808Z                                File "/opt/conda/lib/python3.9/concurrent/futures/thread.py", line 58, in run
2022-09-08T09:07:22.784032746Z                                  result = self.fn(*self.args, **self.kwargs)
2022-09-08T09:07:22.784036253Z                                File "/opt/conda/lib/python3.9/site-packages/beaker/services/dataset.py", line 595, in _upload_file
2022-09-08T09:07:22.784039900Z                                  response = self.request(
2022-09-08T09:07:22.784044249Z                                File "/opt/conda/lib/python3.9/site-packages/beaker/services/service_client.py", line 98, in request
2022-09-08T09:07:22.784050932Z                                  return make_request(self.beaker._session)
2022-09-08T09:07:22.784054710Z                                File "/opt/conda/lib/python3.9/site-packages/beaker/services/service_client.py", line 73, in make_request
2022-09-08T09:07:22.784058647Z                                  response = getattr(session, method.lower())(
2022-09-08T09:07:22.784062395Z                                File "/opt/conda/lib/python3.9/site-packages/requests/sessions.py", line 601, in patch
2022-09-08T09:07:22.784066273Z                                  return self.request('PATCH', url, data=data, **kwargs)
2022-09-08T09:07:22.784070461Z                                File "/opt/conda/lib/python3.9/site-packages/requests/sessions.py", line 529, in request
2022-09-08T09:07:22.784073908Z                                  resp = self.send(prep, **send_kwargs)
2022-09-08T09:07:22.784076954Z                                File "/opt/conda/lib/python3.9/site-packages/requests/sessions.py", line 645, in send
2022-09-08T09:07:22.784080070Z                                  r = adapter.send(request, **kwargs)
2022-09-08T09:07:22.784083126Z                                File "/opt/conda/lib/python3.9/site-packages/requests/adapters.py", line 532, in send
2022-09-08T09:07:22.784086203Z                                  raise ReadTimeout(e, request=request)
2022-09-08T09:07:22.784089229Z                              requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='data.beaker.org', port=443): Read timed out. (read
2022-09-08T09:07:22.784092515Z                              timeout=5.0)

Versions
asd

Also https://beaker.org/ex/01GCD7GF1HWSQQAM4FEXKQW1V7/tasks/01GCD7GF3D6ZATTN3S45NM9GSR/job/01GCD7GSGHTBZ7SEYAECF4T2G5


Make the field timezone aware

Unix timestamp is UTC by definition.
This make it timezone aware and Django outputs correct time by default when using timezones.
I'm not sure about string parsing - what is the actual use case there, shouldn't the timestamp always be integer?

Took the datetime string parsing from Django. This also takes care of the timezone information. The same utility is used for Django's DateTimeField.

Thanks for fixing timezone support Edgar.
Do you mind fixing the broken build from the last commit in your PR, and add some unit tests?
I can help out with this, but if so I need another 1-2 weeks to get it done.

Thanks @edgarsj, I'll add unit tests and have a new version out shortly (1.2.0)

FYI @edgarsj -- this is now released with the latest version 1.2.0


The CVU does not need to look up bundle specific negation codes

Why doesn't the CVU need to look up bundle specific negation codes?


Yahoo: Remove yahoo partnership from fact pages

Just making this issue to remind us to pull out all of the yahoo related code from fact pages when the partnership is over.

This issue should fix this notice, currently filling up the logs in production:
Notice: Undefined variable: yahoo_partnership in include() (line 72 of [/path/to]/lib/themes/dosomething/paraneue_dosomething/templates/fact/node--fact_page.tpl.php).

@sbsmith86 looks like we are good to remove this code now!


brew doctor reports missing formulae that aren't missing

brew doctor output
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed kegs have no formulae!
This means they were either deleted or installed manually.
You should find replacements for the following formulae:
  pycparser
  erdtree
  trurl
  szip

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  tcl-tk
<EMAIL_ADDRESS>
Verification

[X] My "brew doctor output" above says Your system is ready to brew. and am still able to reproduce my issue.
[X] I ran brew update twice and am still able to reproduce my issue.
[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

brew config output
$ brew config
HOMEBREW_VERSION: 4.0.11-68-g79edc3b-dirty
ORIGIN: https://github.com/Homebrew/brew
HEAD: 79edc3b5da2dde70bc3a1eae745902d8f481e100
Last commit: 3 hours ago
Core tap origin: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 6150d43818deed257e0121e1fa6bbbeb1a7e5c14
Core tap last commit: 2 months ago
Core tap branch: master
Core tap JSON: 05 Apr 13:00 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: /opt/homebrew/bin/nvim
HOMEBREW_MAKE_JOBS: 10
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 10-core 64-bit arm_firestorm_icestorm
Clang: 14.0.3 build 1403
Git: 2.39.0 => /opt/homebrew/bin/git
Curl: 7.87.0 => /usr/bin/curl
macOS: 13.3-arm64
CLT: <IP_ADDRESS>.1.1679647830
Xcode: 14.3
Rosetta 2: false

What were you trying to do (and why)?
I found this issue while submitting https://github.com/Homebrew/brew/issues/15153, which asks you to run brew doctor
What happened (include all command output)?
See brew doctor output above; the four packages listed as having no formulae are actually the four packages I've installed via the API that aren't present in my tap (which is no longer being updated).
I dropped a debugger into the diagnostic function, you can see that CoreTap.instance.installed? is true, so we don't ever reach line 831 which seems like the bit that's supposed to catch formulae installed via the API?
[822, 831] in /opt/homebrew/Library/Homebrew/diagnostic.rb
   822:
   823:         deleted_formulae = kegs.map do |keg|
   824:           next if Formulary.tap_paths(keg.name).any?
   825:           require 'byebug'; byebug
   826:
=> 827:           if !CoreTap.instance.installed? && !EnvConfig.no_install_from_api?
   828:             # Formulae installed with HOMEBREW_INSTALL_FROM_API should not count as deleted formulae
   829:             # but may not have a tap listed in their tab
   830:             tap = Tab.for_keg(keg).tap
   831:             next if (tap.blank? || tap.core_tap?) && Homebrew::API::Formula.all_formulae.key?(keg.name)
(byebug) EnvConfig.no_install_from_api?
false
(byebug) CoreTap.instance.installed?
true
(byebug) p keg.name
"pycparser"
"pycparser"
(byebug) Homebrew::API::Formula.all_formulae['pycparser']
{"full_name"=>"pycparser", "tap"=>"homebrew/core", "oldname"=>nil, "aliases"=>[], "versioned_formulae"=>[], "desc"=>"C parser in Python", "license"=>"BSD-3-Clause", "homepage"=>"https://github.com/eliben/pycparser", "versions"=>{"stable"=>"2.21", "head"=>nil, "bottle"=>true}, "urls"=>{"stable"=>{"url"=>"https://files.pythonhosted.org/packages/5e/0b/95d387f5f4433cb0f53ff7ad859bd2c6051051cebbb564f139a999ab46de/pycparser-2.21.tar.gz", "tag"=>nil, "revision"=>nil, "checksum"=>"e644fdec12f7872f86c58ff790da456218b10f863970249516d60a5eaca77206"}}, "revision"=>0, "version_scheme"=>0, "bottle"=>{"stable"=>{"rebuild"=>0, "root_url"=>"https://ghcr.io/v2/homebrew/core", "files"=>{"all"=>{"cellar"=>":any_skip_relocation", "url"=>"https://ghcr.io/v2/homebrew/core/pycparser/blobs/sha256:882d005d9bcc429f3eee0d5cdb3c5065302ec25c96ea1ae3d5a32fb1f6f08cb8", "sha256"=>"882d005d9bcc429f3eee0d5cdb3c5065302ec25c96ea1ae3d5a32fb1f6f08cb8"}}}}, "keg_only"=>false, "keg_only_reason"=>nil, "options"=>[], "build_dependencies"=>[]<EMAIL_ADDRESS>"test_dependencies"=>[], "recommended_dependencies"=>[], "optional_dependencies"=>[], "uses_from_macos"=>[], "requirements"=>[], "conflicts_with"=>[], "conflicts_with_reasons"=>[], "link_overwrite"=>[], "caveats"=>nil, "installed"=>[], "linked_keg"=>nil, "pinned"=>false, "outdated"=>false, "deprecated"=>false, "deprecation_date"=>nil, "deprecation_reason"=>nil, "disabled"=>false, "disable_date"=>nil, "disable_reason"=>nil, "service"=>nil, "tap_git_head"=>"e6ad87be9a83dee1f8467b74936528c411e95bef", "ruby_source_checksum"=>{"sha256"=>"3478b77201f1c824b291381ba8927428e3b0b6fc26bbd8e6fe0073fb81e9c434"}, "variations"=>{}}

What did you expect to happen?
brew doctor not to list formulae that are installed via the API as having no formula
Step-by-step reproduction instructions (by running brew commands)
1. reset your core tap to `6150d438`
2. Install a package such as `pycparser` or `erdtree` that's been added since that release
3. note that `brew doctor` reports that those packages lack formulae

i'm getting it w/ cffi and pycparser coming in as deps for awscli


example yaml playbooks do not pass ansible lint in vscode.

the extra "-" in splunk_install_or_upgrade.yml  for example.   Also ansible supports include_role and task_from.  Not sure I understand why the convoluted way to call a task from a role.
---
# Example playbook to perform either a splunk installation or upgrade
- hosts:
    - all
  roles:
    - ../roles/splunk
  serial: 50
  vars:
    - deployment_task: check_splunk.yml

tasks_from will run a specified task from a role instead of main.yml. That would be undesirable since we are using main.yml to automatically discover a few variables, as well as to check whether init.d, systemd, or neither have been configured for splunk. By loading this logic into main.yml it allows us to keep things simple downstream (e.g. how splunk should be restarted, what splunk's home path is, etc). The boot-start checking also helps to ensure that customers both have boot-start enabled, and ensure that it's enabled using their desired method (init.d vs systemd).
As far for linting, we use ansible-lint and do our best to fix any linting issues. I'll see if it complains about anything in the example playbooks and correct any issues in the next release.


Link is broken on the website

this is a possible fix
Corrent link is leading to:
https://facebook.github.io/docs/deployment#building-for-relative-paths [broken]
And not to:
https://facebook.github.io/create-react-app/docs/deployment#building-for-relative-paths [good]
Not how to make it work also inside GH, as the .md file ext is missing and not added by default (?)

I've opened a larger PR around this here: https://github.com/facebook/create-react-app/pull/5552


Import text is not generated for interfaces that extend interfaces in other namespaces

If two interfaces are in two different namespaces, and one extend the other one, the import text will not be generated for the extended interface:
The following example:
namespace m;
interface X{}
namespace n;
interface Y{isA X;}

generates the following code for interface Y:
package n;

public interface Y extends X
{

}

which is lacking the import line for package m:
import m.*;

The problem only occurs when we have an interface that extends another interface. If a class implements an interface or extends another class, the import line is correctly generated.
PR #1482 (issue #1315) can be improved after this issue is solved (warning 42)

The workaround for users is to add depend m.*


cmake Error when building per README

Trying to build per the README on macOS. I have the pico SDK and build tools set up correctly (I think) but am getting a Make error
CMake Error at examples/snake/CMakeLists.txt:10 (find_package):
By not providing "FindPICOSYSTEM.cmake" in CMAKE_MODULE_PATH this project
has asked CMake to find a package configuration file provided by
"PICOSYSTEM", but CMake did not find one.

Could not find a package configuration file provided by "PICOSYSTEM" with
any of the following names:

PICOSYSTEMConfig.cmake
picosystem-config.cmake

Add the installation prefix of "PICOSYSTEM" to CMAKE_PREFIX_PATH or set
"PICOSYSTEM_DIR" to a directory containing one of the above files.  If
"PICOSYSTEM" provides a separate development package or SDK, be sure it has
 been installed.

I can fix this manually by running cmake build flag -DPICOSYSTEM_DIR:PATH=/Users/NAME/picosystem (path set to root of where I cloned the repo) . This solves the issue and I can build the examples and run on the system. I am not sure whether or how to make changes to the CMakeLists.txt file to solve this at the root.
Happy to close if this is user error on my end :) .

Have you got an updated copy of the repo - I think this was fixed by https://github.com/pimoroni/picosystem/pull/3 ?
(or at least, I got exactly the same on Linux until that PR)

so I added set(PICOSYSTEM_DIR "/Users/matt/Projects/picosystem") into the root level CMakeLists.txt file at line 9 and that works for me as a more streamlined solution. Unfortunately, I'm not familiar enough with CMake syntax to define the path to PICOSYSTEM_DIR programmatically that works for any file path rather than hard coding it in for my specific case.


Dashboard not opening

Describe the bug

Please describe more detail.

Open the issue again if you provide details.


IVONA TTS voices

Hey,
It would require an internet connection but the IVONA voices available at http://www.ivona.com/ are also available via an API at https://www.ivona.com/us/for-business/speech-cloud/
Someone has even written a wrapper library (although it could do with a cleanup and getting rid of pygame) at http://zacharybears.com/pyvona/
I've been playing around with Google STT + Google Translate + IVONA multi-lingual voices and it's great. The Russian 'Maxim' voice is particularly good (so I'm told), much better than the Google voices.
It might be worth looking at.

Just had a look, but I need to wait until zbears/pyvona#9 has been merged to use this properly.


Portuguese language

:portugal:  language for issue #69

Awesome, thanks @david-dasilva , do you know someone that could do a review ?


feat(bindgen): add AccountInterface to function

Description
This PR adds AccountInterface as another type to the typescript function bindgen.
Related issue
In dojo.js the DojoProvider.execute accepts the account input with type Account | AccountInterface:
    public async execute(
        account: Account | AccountInterface,
        call: AllowArray<DojoCall | Call>,
        nameSpace: string,
        details: UniversalDetails = {}
    ): Promise<InvokeFunctionResponse> {

This is specifically relevant with starknet-react that defines accounts as the AccountInterface type, however the bindgen is only generating account inputs as type Account. Therefore, currently the starknet-react accounts need to be mapped to the Account type before being passed to the bindings.
Tests

[ ] Yes
[ ] No, because they aren't needed
[ ] No, because I need help

Added to documentation?

[ ] README.md
[ ] Dojo Book
[ ] No documentation needed

Checklist

[ ] I've formatted my code (scripts/prettier.sh, scripts/rust_fmt.sh, scripts/cairo_fmt.sh)
[ ] I've linted my code (scripts/clippy.sh, scripts/docs.sh)
[ ] I've commented my code
[ ] I've requested a review after addressing the comments

Summary by CodeRabbit

New Features

Enhanced function signature flexibility by allowing both Account and AccountInterface types as inputs.
Updated function generation to accommodate the broader range of account types.

Bug Fixes

Adjusted test cases to validate new input types and expected outputs correctly.

Perfect !


We now only log "Failed to signal external workflow execution" on unexpected errors

What changed?
We now only log "Failed to signal external workflow execution" for unexpected errors. Expected errors are defined as transient errors, not exists errors and "workflow execution already completed" errors.

Why?
We have a lot of "Failed to signal extermal workflow execution" error
logs in server with the error being "workflow execution already
completed".
This is an expected state so we should not log errors for this.
Additionally we add transient errors and not exists errors to the things we
should not log errors for, as they are expected in the normal operation
of the system.

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 018fe297-243a-428e-aaa9-0bec8e4c63b4
Details

15 of 15 (100.0%)  changed or added relevant lines in 2 files are covered.
1932 unchanged lines in 36 files lost coverage.
Overall coverage decreased (-0.4%) to 69.639%

Files with Coverage Reduction
New Missed Lines
%

common/task/weighted_round_robin_task_scheduler.go
2
88.56%

common/task/fifo_task_scheduler.go
2
83.51%

common/persistence/taskManager.go
2
74.49%

service/history/task/transfer_active_task_executor.go
2
72.77%

common/persistence/visibility_single_manager.go
2
99.33%

common/membership/hashring.go
2
84.69%

service/matching/poller/history.go
3
74.0%

service/history/queue/timer_queue_processor_base.go
3
77.87%

common/persistence/wrappers/errorinjectors/utils.go
3
93.7%

service/matching/tasklist/task_gc.go
3
92.11%

Totals

Change from base Build 018fe0d5-41bf-4bbb-a373-d503fd5baf3b:
-0.4%

Covered Lines:
102858

Relevant Lines:
147702

💛  - Coveralls


Support getMaxScore of ConjunctionScorer for non top level scoring clause

Description
After introducing topLevelScoringClause, ConjunctionScorer with multiple scorers can be used for non top level scoring clause conjunctions instead of BlockMaxConjunctionScorer even requiredScorers is empty. In such case, ConjunctionScorer returns Infinity as maxScore and it ruins some optimizations like parent WANDScorer.
https://github.com/apache/lucene/blob/7d35ae485807147460f63ea58ae495124e972e13/lucene/core/src/java/org/apache/lucene/search/Boolean2ScorerSupplier.java#L218C77-L218C98

Thanks for looking into this, can you explain what kind of queries perform better with this change?

For this case. Suppose ScorerA, B, and C can return valid maxScore. If the ScorerD is dominant, larger minCompetitiveScore is set to WANDScorer. But ConjunctionScorer returns Infinity as maxScore and scaledMaxScore becomes 0. Then WANDScorer cannot skip docs well. Is my understanding correct?
DisjunctionMaxScorer(scorers=[
  WANDScorer(scorers=[ConjunctionScorer(ScorerA, ScorerB), ScorerC]),
  ScorerD
], tieBreakerMultiplier=0.0)

OK, I see, it's about conjunctions within disjunctions. Thanks for explaining.

Thanks. 9.10 as well?

Yes please.


Add pre-existing-subnetwork module

The purpose of this PR is to add better support for Shared VPCs and subnet level permissions for the subnets.
https://cloud.google.com/vpc/docs/shared-vpc
The initial use-case is together with front-end/OFE - but can freely be used without.
In most cases, this can be used as a 1:1 replacement of pre-existing-vpc.
Cluster level service accounts comes with caveat, that they cannot create vms using the subnet from the shared VPC,
hence an example cloud-function is provided, for running in the host project, to assign permissions to the subnet for all service accounts created in the HPC project. (The function is not intended to be deployed by the HPC Toolkit).

This PR is needed for [#2598 2598] to work.

@mr0re1 I believe i have addressed all your comments in the latest commit.
Thanks
Lasse

@LasseHjorth , thank you for contributing and sorry for slow review.
I've left some minor comments about modules/network/pre-existing-subnetwork/*, as for the rest of PR (docs/shared-vpcs.md and community/other/cloud-function-for-shared-vpcs) that would require more consideration.
To facilitate the intake, lets limit this PR to modules/network/pre-existing-subnetwork/* only, the rest can be send as a separate PR.
After PR is pruned and comments are addressed (unless something new will be discovered) it will be "good to land"
Thank you again!

@mr0re1 Adjusted as requested, and left a single comment in one of your questions.

/gcbrun

PR. looks good, please address comment about modules/network/pre-existing-subnetwork/README.md and we can land it. Thank you.

PR. looks good, please address comment about modules/network/pre-existing-subnetwork/README.md and we can land it. Thank you.

@mr0re1, I committed the last changes yesterday.

/gcbrun


Fastlane (sigh) not able to find certificate.

Hi All
Im having an issue with my lane that creates provisioning profiles, it seems that it cannot find the certificates, even though they are on the local machine. Fastlane reports them installed and verified, and i can see them in the keychain.

but  i stil get an error when trying to create a provisioning profile:

My lane looks like this, it creates dev, and dist certs and sets them in the relevant targets. Im not using match as im part of many teams and i need more control, and to nuke everything on customers teams is not something that can happen.

My env files are structured like this:

Certificates in keychain:

I hope somebody can point me in the right direction, i think i have tried it all and i believe the current setup should work, so im leaning towards it being a big.
thanks you best regards
Morten

I figured something out. This only happens if i run sigh right after i have ran get_certificates to produce the cert. If i after i have created the certs removes the get_certificates then the profies produce correctly. any idear why this is happening, and how i can prevent the error. I create ALOT of new apps, so i really want this flow to work correctly :)


GetDockerContext() should no longer be running docker context

In trying to debug recent perpetual Colima failures -

https://github.com/ddev/ddev/issues/5861

I stumbled on GetDockerContext() still calling out to docker client for context information. I'm sorry I missed this in the review of the Docker rework @stasadev , but GetDockerContext() should now be able to use native techniques rather than running docker context inspect
https://github.com/ddev/ddev/blob/49bf2a402f547776207896bf0b19d8ee580411aa/pkg/dockerutil/dockerutils.go#L207-L219

Nothing about docker contexts should require calling out to the docker client I don't think.
We shouldn't be setting or using DOCKER_HOST any more (it should be allowed as explicitly set as an override, but we shouldn't be using it internally):

https://github.com/ddev/ddev/blob/b3f7cf6df550f6b6d2cedaca9d64c98521ec2fcd/pkg/dockerutil/dockerutils.go#L192-L195

About context and host:
What I found from docker/client/client - there are no methods to get the context name.

https://github.com/moby/moby/discussions/44166

We already use all available env variables with dockerClient.FromEnv:
https://github.com/ddev/ddev/blob/08d94f74f25c5617791a71f2be15e403cf79510f/pkg/dockerutil/dockerutils.go#L163
https://github.com/ddev/ddev/blob/08d94f74f25c5617791a71f2be15e403cf79510f/vendor/github.com/docker/docker/client/options.go#L24-L33
And the host can be retrieved with client.DaemonHost().
I plan to replace all DOCKER_HOST calls with a native function and possibly remove:
https://github.com/ddev/ddev/blob/08d94f74f25c5617791a71f2be15e403cf79510f/pkg/dockerutil/dockerutils.go#L141

We still need $DOCKER_HOST, because the endpoint is selected from the default context in docker.com/docker/library/library, and docker context use doesn't work by itself.
The only way to get rid of docker context inspect is to use another go library https://github.com/docker/cli/cli, which may or may not be appropriate.

Just thinking out loud without knowing all the context. There are two uses for DOCKER_HOST:

Just communicating the endpoint to our own code
Communicating the endpoint to docker itself.

They don't have to be the same thing. For the first one we could use another technique.
And really $DOCKER_HOST should only matter when we're using the docker client, and most of the time we shouldn't need it there? Or does the docker/docker API use $DOCKER_HOST?

I'm sure you've already been there, but here's a link to the docker CLI context central stuff. https://github.com/docker/cli/blob/70216b662dc440faaebab531deb35f0f0c633d17/cli/command/cli.go#L364-L419

And really $DOCKER_HOST should only matter when we're using the docker client, and most of the time we shouldn't need it there? Or does the docker/docker API use $DOCKER_HOST?

We need $DOCKER_HOST to be set all the time from our own code, because docker/docker/client knows nothing about the context, but it accepts $DOCKER_HOST as the correct endpoint.

here's a link to the docker CLI context central stuff

Yes, I saw it, I will try to adapt this code for our needs.

If we have no hope on this @stasadev go ahead and close it.

Closed because I didn't succeed with it.


About README error

📚 Documentation

There is
from geovista.pantry.data import ww3_global_tri

in the README file,
but it can not take effect.
It should be
from geovista.pantry import ww3_global_tri

Hey @ChristmasZCY!
Thanks for taking the time to raise this issue. Very much appreciated 😃
We're in a bit of a weird position, in that there will be a breaking change introduced in the next release 0.5.0, as we reorganised some of the modules within geovista.
The examples in the README.md are currently in agreement with the main branch, but not the latest available release 0.4.1, which is a little bit confusing. Apologies.
What I'm going to do is revert the README.md so the examples quoted there are in alignment with 0.4.x, as most users will be installing the latest release of geovista from conda-forge or PyPI.
I'll also create a draft pull-request to be merged prior to the forthcoming 0.5.0 release to revert the README.md to synchronise the examples with the codebase again.
Thanks for pointing this out 👍
Also, checkout the other examples in the GeoVista Gallery ... note that, these examples are based on the main branch.

Thank you, I'll follow it continuously!

@all-contributors please add @ChristmasZCY for bug


css snippets dont work

the css shortcuts here dont work
https://docs.emmet.io/cheat-sheet/

Hey @siduck ! can you show me how are you setting up this language server, the version of the package and maybe some LspInfo output?

hi @olrtg
require("lspconfig").emmet_language_server.setup()
and i installed the lsp from mason

oh nvm i'm dumb, almost css work
i first tried bg+

seems like its bg#fff then it'll autocomplete
Sorry for wasting your time

Although the "m" snippet ( margin )  isnt shown in cmp window

i'm assuming its pushed at the end!  Ik this issue is cmp related, but do you know if i could prioritize emmet lsp's completion?

@siduck no problem!
Hmm isn't margin: ; the snippet for m?


"Fixed" position size splitting

Changed the multiple TP function to have the last portion of the trade accommodate for the "deltas" of the others
e.g.
initial position size is 0.11 and 4 TPs are set 25% each
with the "original" script, this would be 4 trades each of 0.02 for a total of 0.08 lots and not 0.11
this change will make the last order 0.05 instead of 0.02 thus the total still 0.11 lots

Hi!
It's a good idea, but it looks like currently, it assigns the remained to the last TP. It seems more logical for it to assign the remainder to the main TP (#0). What do you think?

yes it does make sense...
I changed the file to reverse the loop to start with n-1 and finish at j=0
i will create another Pull Request for you to check

Let me know what you think

This looks better, but opening trades in a reverse order has its disadvantage - the trader may run out of margin before the main TP trade is opened. Perhaps, it's worth calculating the remainder first, without taking any trades and then take trades in normal order but using the volume+remainder for the main trade?

In that case I would personally prefer to round up and put the last  portion of the trade the rest
e.g.: 0.11 / 4 would be 3 * 0.03 + 1 * 0.02 instead of 0.05 * 1 + 0.02 * 4
no?

Thanks!


Add composer-require-checker

Add Composer Require Checker into Dependency Management Extras-Section.
A good scanner which analyzes your code if there are symbols used, which are not required in your root composer.json.
URL: https://github.com/maglnet/ComposerRequireChecker

Can you please re-order alphabetically?

Will do 👍

Closed, merged with #1086


fixed two clippy warnings

The code is already squeaky clean, so clippy found only two very minor style nits. :+1:

Just running clippy on a bunch of random crates?


Refactoring

Corrected the warnings that were indicated by pylint.

@rliskunov I'm ready to merge, but CI complains. Can you please check it?

@yegor256 locally I have excluded warnings that pylint shows. However, the launch of the make command occurs relative to current codebase and does not take into changes in the pull request. Maybe it is worth taking out the checks separately in github actions?

@rliskunov OK, I merged


verify-attached-bugs: text improvements

Codecov Report

Merging #266 (c461eee) into master (3de2c50) will not change coverage.
The diff coverage is 11.11%.

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   30.56%   30.56%
=======================================
  Files          54       54
  Lines        5257     5257
  Branches     1160     1160
=======================================
  Hits         1607     1607
  Misses       3556     3556
  Partials       94       94

Impacted Files
Coverage Δ

elliottlib/cli/verify_attached_bugs_cli.py
0.00% <0.00%> (ø)

elliottlib/attach_cve_flaws.py
85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de2c50...c461eee. Read the comment docs.

/lgtm

/assign vfreex