Can not reproduce and Results mismatch

Hello,
Thanks for the great work on this benchmark. I have a couple of questions:
It seems that we update the engine versions frequently, but I don't see any corresponding updates on the front page graph. Are there plans to address this? If not, it could be misleading.
I've reviewed a forked repo of this project, and they presented entirely different conclusions without any code changes. Additionally, I've had trouble reproducing the results shown in your front page graph. Could this be due to not updating the results in accordance with code changes?
Thank you.

Hi @Ryanai1120,

I've had trouble reproducing the results shown in your front page graph. Could this be due to not updating the results in accordance with code changes?

I think it's because of version changes. I've re-run benchmarks across similar but different machines and can confirm that they are reproducible (excluding small random fluctuations because of uncontrollable environmental reasons).
Regarding, https://myscale.github.io/benchmark, I'd say that

Comparing cloud offerings is never a reliable way to run benchmarks.
Even if you exclude network latency and keep the client and server in the same network, you'll encounter huge differences across different cloud providers because cloud instances are often very different despite looking very similar on the surface.

Feel free to run our benchmarks and report anything that you find hard to reproduce despite having the environment mentioned in our benchmarks. We are more than happy to help with that :)


Remove trailing comma in bower.json

I was having issues installing smartquotes with bower install on node 5. Removing the trailing comma in bower.json seems to have fixed it.

Good catch, thanks!


Cilium operator --version does not print anything

I am able to get the correct version information about cilium-operator using --version flag.

@fristonio you are right, now I'm confused :thinking:
@joestringer do you remember where we saw this?

Maybe it works on master but breaks in the release?

ah! found it!

Maybe it works on master but breaks in the release?

$ docker run -ti quay.io/cilium/operator:v1.7 cilium-operator --version
Cilium 1.7.0 05f83d08f 2020-02-21T13:00:21+01:00 go version go1.13.8 linux/amd64

$ docker run -ti docker.io/cilium/operator:v1.6.6 cilium-operator --version
Cilium


feature: Verdaccio example

What's this PR do?
Summary of changes in this PR or what it accomplishes.
@ulises-jeremias @rpmolina
This pull request introduces a comprehensive example demonstrating the usage of Verdaccio with Docker containers. Verdaccio is a lightweight, private npm registry that allows developers to set up a local registry for testing and managing packages before pushing changes to a remote registry (among other use cases).
This addition is particularly useful for developers working on component libraries or npm packages. This is instrumental in ensuring the stability and integrity of packages before they are shared with the broader development team or the public.

Summary by CodeRabbit

Documentation

Enhanced the Verdaccio README with a comprehensive guide on using Verdaccio with Docker, including setup, configuration, package management, and monitoring instructions.

I close this PR because this example must live in https://github.com/nanlabs/devops-reference


Speed up get_tensors_subset from O(n^2) to O(n)

This is a change to replace the changes in my thesis branch to return 0-based indices in the select_points() method in downsamplers.
I realize that returning 0-based indices is not generalizable to all downsamplers because there are downsamplers which work class by class even in the batch-then-sample mode, e.g. craig. Therefore there is no built-in concept of 0-based indices for such downsamplers (because they pick points of the same class and select from them).
Therefore I decided to tweak the implementation of get_tensors_subset() which is simpler.
A time complexity of O(n) is acceptable because in any selection strategy we have to look at every sample, so an extra O(n) part can be well mixed in the time complexity of a selection strategy.

Thank you, Xianzhe. Have you compared this implementation with your other 0-indexed based / tensor based one in some microbenchmark? It would be great to understand the implications here before merging this

Thank you, Xianzhe. Have you compared this implementation with your other 0-indexed based / tensor based one in some microbenchmark? It would be great to understand the implications here before merging this

I can't execute a full pipeline now because I already cleared the datasets on the servers, but I measured them with the following scripts
import torch

def get_tensors_subset_new(
        selected_indexes: list[int], data: torch.Tensor | dict, target: torch.Tensor, sample_ids: list
) -> tuple[torch.Tensor | dict, torch.Tensor]:
    sample_id2index = {sample_id: index for index, sample_id in enumerate(sample_ids)}
    # first of all we compute the position of each selected index within the batch
    in_batch_index = [sample_id2index[selected_index] for selected_index in selected_indexes]

    # then we extract the data
    if isinstance(data, torch.Tensor):
        sub_data = data[in_batch_index]
    else:
        sub_data = {key: tensor[in_batch_index] for key, tensor in data.items()}

    # and the targets
    sub_target = target[in_batch_index]

    return sub_data, sub_target

def get_tensors_subset_old(
        selected_indexes: list[int], data: torch.Tensor | dict, target: torch.Tensor, sample_ids: list
) -> tuple[torch.Tensor | dict, torch.Tensor]:
    sample_id2index = {sample_id: index for index, sample_id in enumerate(sample_ids)}
    # first of all we compute the position of each selected index within the batch
    in_batch_index = [sample_ids.index(selected_index) for selected_index in selected_indexes]

    # then we extract the data
    if isinstance(data, torch.Tensor):
        sub_data = data[in_batch_index]
    else:
        sub_data = {key: tensor[in_batch_index] for key, tensor in data.items()}

    # and the targets
    sub_target = target[in_batch_index]

    return sub_data, sub_target

def get_tensors_subset_0_based(
        in_batch_index: list[int], data: torch.Tensor | dict, target: torch.Tensor, sample_ids: list
) -> tuple[torch.Tensor | dict, torch.Tensor]:

    # then we extract the data
    if isinstance(data, torch.Tensor):
        sub_data = data[in_batch_index]
    else:
        sub_data = {key: tensor[in_batch_index] for key, tensor in data.items()}

    # and the targets
    sub_target = target[in_batch_index]

    return sub_data, sub_target

if __name__ == "__main__":
    import time
    cuda_device = torch.device("cuda:2")
    data = torch.randn(65536, 10, device=cuda_device)
    target = torch.randn(65536, device=cuda_device)
    # 65536 random integers
    sample_ids = torch.randint(0, 1000000, (65536,)).tolist()

    # suppose we have a selection ratio of 50%. We select 32768 samples
    # generate 32768 random indexes in range 0-65536
    in_batch_idx = torch.randint(0, 65536, (32768,)).tolist()

    selected_sample_ids = [sample_ids[idx] for idx in in_batch_idx]
    print("start experiment")
    times = 10
    warmup = 3
    for i in range(times + warmup):
        if i == warmup:
            start = time.time()
        get_tensors_subset_old(selected_sample_ids, data, target, sample_ids)
    print("Old:", time.time() - start)

    for i in range(times + warmup):
        if i == warmup:
            start = time.time()
        get_tensors_subset_new(selected_sample_ids, data, target, sample_ids)
    print("New:", time.time() - start)

    for i in range(times + warmup):
        if i == warmup:
            start = time.time()
        get_tensors_subset_0_based(in_batch_idx, data, target, sample_ids)
    print("0-based:", time.time() - start)

The result is
start experiment
Old: 66.20023608207703
New: 0.12652850151062012
0-based: 0.058889150619506836

Though the way proposed in this PR ("New") is still longer than 0-based indices, compared to how long a selection strategy would take (at least O(n) ), the difference between the two is ignorable.

merged this for you because i want to use it in some experiment :)


SignedOutModel in Razor Pages project template is missing a namespace

@jbagga, I assume this wasn't intentional, was it?

Not aware of when this happened. Maybe before porting to the new templating repo. I can take a look!


Added WordPress Hosting Plans #1

PR: Thank you!
Reason
Add: New Item
Type
New Category: WordPress Hosting
Name

EasyWP
Flywheel
Zabhost
WP Engine
Kinsta

Link

https://www.easywp.com/
https://getflywheel.com/
https://zabhost.com/
https://wpengine.com/
https://kinsta.com/

Thank you for improving the project
This helps others find VPS or hosting of their choice

@zeruhdotcom Thank you for PR, please format markdown file properly and move Wordpress above VPS and Database section

@dalisoft Done :) Will add some more providers to keep the list updated after it's merged.

@zeruhdotcom Thank you


first attempt at tracking ETH2xFLI vs WETH, part of #18

tracking WETH already for the dollar price, but could also add a separate ETH price feed?
dropping first 48 hours due to some weird price spike. good or include it anyway?
saw there is quite a big pool on uniswap v3 already, expecting that to only get bigger. take avg of v2+v3 pools?

I would say let's track ETH
good to remove the first 48 hours
Ya, let's do the avg of v2 + v3

Also, could you put this file, and others related to this project in a new directory: product/eth2x-dash

@josephd8 please review. There's quite a delta in movement in the last 7 days, is this right?

@jorijnsmit I am going to close the PR - I just merged PR #59, which included this query (forked from your account) and it is now added to the ETH2x-FLI dashboard here: https://duneanalytics.com/jdcook/ETH2x-FLI


Improve version selector in sidebar

Questions
Answers

Description?
Improve version to allow switching between versions and stay on same page (if exists)

Type?
new feature

BC breaks?
no

Deprecations?
no

Fixed ticket?
Related to https://github.com/PrestaShop/docs/issues/1635, thanks @micka-fdz

@kpodemski ✋


Add synapse user ID to the rest client

Added integration tests (also added synapseUserId to the AccountSummary object, which was missing).


Overwriting a container drops its contents even with spawnDrops=false

Overwriting a container block (e.g. a chest) with a different block will cause its contents to be dropped, even when spawnDrops is set to the default value false. Based on the documentation of spawnDrops, this seems like unintended behavior.
Example request that produces this effect (sending two requests works too):
PUT localhost:9000/blocks

[
    {
        "x": 0,
        "y": 100,
        "z": 0,
        "id": "minecraft:chest",
        "data": "{Items: [{Slot: 13b, id: 'apple', Count: 1b}]}"
    },
    {
        "x": 0,
        "y": 100,
        "z": 0,
        "id": "minecraft:stone"
    }
]

Tested with:

GDMC-HTTP 1.4.4
Forge 48.1.0
Minecraft 1.20.2

This behavior was not there in GDMC-HTTP 1.1.1, but I don't know which version introduced it (and I didn't feel like doing a binary search :P). I would guess it's 1.2.3 (which touched overwriting blocks with NBT data) or 1.4.0 (which optimized everything).

It seems likely this bug was introduced with the 1.4.0 update. Probably due to an order of operations issue.


Fix macro namespacing and serialization bugs

Though polar_core macros are exposed publicly, they are not usable without importing polar_core::* since they expect other polar_core macros to be in scope.  Using $crate references as appropriate fixes this.  Also, fix Value::String injection bug and Operator::Dot special-casing for Value::Call.
PR checklist:

[ ] Added changelog entry.

I have read the CLA Document and I hereby sign the CLA

My apologies about the delayed CLA signing (Cf. https://github.com/osohq/oso/pull/1596). I only just got approval to do so.

Closing due to lack of bandwidth.


SOC für VW ID.7 nicht auslesbar

Describe the bug
In der Oberfläche wird kein Ladezustand für den konfigurierten VW ID.7 angezeigt.
Steps to reproduce

Start des Ladenvorgangs an der Wallbox.
Wechsel des Autos über die Oberfläche (da die automatische Erkennung nicht fiunktioniert)

Configuration details
vehicles:
- name: id7
  type: template
  template: vw
  title: ID.7
  user: ***
  password: ***
  vin: WVWZZZ***
  capacity: 77
  phases: 3
  cache: 10m
  mode: minpv

Log details
[lp-1 ] DEBUG 2024/09/20 10:23:03 detected active phases: 3p
[lp-1 ] DEBUG 2024/09/20 10:23:03 charger status: C
[lp-1 ] ERROR 2024/09/20 10:23:03 vehicle soc: unknown engine type: electric, got [, ]
[lp-1 ] DEBUG 2024/09/20 10:23:03 pv charge current: 8.88A = 9.05A + -0.174A (120W @ 3p)

What type of operating system are you running?
Linux
Nightly build

[X] I have verified that the issue is reproducible with the latest nightly build

Version
v0.130.11

Needs trace log for vw

Ich sehe da nur
[id    ] TRACE 2024/09/20 12:08:58 {"charging":{"batteryStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}},"chargingStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}},"chargingSettings":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}},"plugStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}},"chargeMode":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}}},"climatisation":{"climatisationSettings":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}},"climatisationStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}},"climatisationTemperatureOutside":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:58Z","info":"Something went wrong. Please try to re-login. If the problem persists, please contact our support.","code":4004,"group":3,"retry":true}},"windowHeatingStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}}},"fuelStatus":{"rangeStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}}},"measurements":{"rangeStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}},"odometerStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}},"temperatureBatteryStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}},"fuelLevelStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}},"temperatureOutsideStatus":{"error":{"message":"Bad Gateway","errorTimeStamp":"2024-09-20T10:08:57Z","info":"Upstream service responded with an unexpected status. If the problem persists, please contact our support.","code":4007,"group":2,"retry":true}}}}

VW api mal wieder kaputt...


Links to Dataset Resources not working

The links to dataset resources (look at the dataset detail page) is not clickable, not working

I may have solved it, please look at this Pull request:
https://github.com/italia/daf-dataportal-public/pull/40


Provide instructions to build on Mac

I tried installing this tool on mac but on every step a new error or dependency has popped up. Could you provide instructions on how to use install and build this library in mac?
I'm currently at go get but it says that leveldb and geos can not be found even though I already installed them via homebrew.

Can you be more specific? I'm developing on Mac OS and I installed the dependencies with homebrew as well...
Does your PATH contain /usr/local/bin?

After I installed the C++ dependencies with homebrew, I tried to run the go get command, but an error popped saying that it could not find the dependencies. When I print PATH I get this output:
$ echo $PATH
# /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin

Can you paste the actual error?  (That's what I meant with 'more specific').

I reinstalled everything and go get seems to create pkg and src directories. go install on the other hand is not creating the bin folder. It just exists, even with verbose flag it doesn't output to console.
My macOS version is 10.12.1
Go version is go1.7.4 darwin/amd64

If I run go install in the same directory as the main.go file, which is the only way to get some output, I get the following:
# github.com/omniscale/imposm3/vendor/github.com/jmhodges/levigo
../../../github.com/omniscale/imposm3/vendor/github.com/jmhodges/levigo/batch.go:4:11: fatal error: 'leveldb/c.h' file not found
 #include "leveldb/c.h"
          ^
1 error generated.
# github.com/omniscale/imposm3/geom/geos
../../../github.com/omniscale/imposm3/geom/geos/coords.go:5:10: fatal error: 'geos_c.h' file not found
#include "geos_c.h"
         ^
1 error generated.

Are these files in /usr/local/include? Did brew returned errors during installation? brew link geos, brew link leveldb, brew doctor...

Yes, they are. Homebrew returned warning due to python:
Python modules have been installed and Homebrew's site-packages is not
in your Python sys.path, so you will not be able to import the modules
this formula installed. If you plan to develop with these modules,
please run:
  mkdir -p /Users/AJ/Library/Python/2.7/lib/python/site-packages
  echo 'import site; site.addsitedir("/usr/local/lib/python2.7/site-packages")'

I ran those lines and try reinstalling it, and the warning was no more. But yeah, they are all installed.

I use macos 10.13.6, and followed the instructions and managed to successfully build the binary.
the brew commands for dependencies are brew install golang leveldb geos

@petervojtek I used the same instructions but came up short. I got a compile error using the command
go/src/github.com/omniscale/imposm3/geom/geos/coords.go:5:10: fatal error: 'geos_c.h' file not found    #include "geos_c.h"             ^~~~~~~~~~    1 error generated.
But after using your brew install golang leveldb geos I got a clean compile. Thanks for leaving this behind.

Any update on this? I am having the same issue as @adamakhtar described

I did a PR on Homebrew/homebrew-core that includes a imposm3 Formula. Now it's just a matter of brew install imposm3 to get it on macOS


fix: temporary fix to not use native dialogs in Safari

I needed to redo this since when I backported some of the colour stuff I messed up and the existing 1.242.x branch wasn't pointing at the right place. I've fixed that and we should be good now.

Background on what actually happened with that backport was:

In the 1.x branch, I did a fix: update package-lock just to get things updated and not pollute the visual diff. But then when that merged it tagged & released as 1.242.4.
Then the actual colour changes went into 1.243.0.
Then today when I went back to 1.242.x and did a fix: it tried to release 1.242.4 again since 1.242.3 was the last tag on that branch and the release blew up.

The "fix" here to blow away the 1.242.x branch and repoint it at the 1.242.4 tag isn't technically correct since it does pick up those unwanted package-lock changes. But going through them... they're all dev tooling changes and I don't think will have any impact on how BSI is going to build core, so we should be good.


Various misbehaviors in Mojave

I'm seeing a number of strange behaviors since I upgraded to Mojave, more or less. (I've turned on Full Disk Access for nvALT already.) Is anybody else seeing any of these?

At startup, neither the main window nor the preview is visible even though the app is foregrounded. I have to open it from the Window menu.
When the main window appears, it's empty. I have to press a key to start a search before the notes are shown.
The assigned hotkey is not working. (EDIT: it started working after I set it again, using the same key combination.)
The Bookmarks menu is broken: it just shows the placeholder grayed-out "Item".
When I delete a note, in the confirmation prompt, neither the Delete nor Cancel button dismisses the prompt, and I have to quit the app to continue. (It does do the deletion if I click Delete, though.)

I've scanned the list of issues and haven't seen anything similar — apologies if I missed something though.

Closing this issue. It turned out to be caused by some kind of corruption in the preferences file; when I located the right file and deleted it, nvALT went back to normal.

Same exact things happened to me. I noticed that in the bad preferences file, the Bookmarks section had an extra empty dict at the end:
	<key>Bookmarks</key>
	<array>
		<dict>
			<key>NoteUUIDString</key>
			<string>A7ACD798-8899-40BD-9A9B-64F94DE0BC18</string>
			<key>SearchString</key>
			<string></string>
		</dict>
		<dict>
			<key>NoteUUIDString</key>
			<string>63E5AF7D-AB95-4756-831D-5A6C8B45DC85</string>
			<key>SearchString</key>
			<string></string>
		</dict>
		<dict>
			<key>NoteUUIDString</key>
			<string>0762DA2D-9114-41B4-BE91-58DDF1171FDB</string>
			<key>SearchString</key>
			<string></string>
		</dict>
		<dict/>
	</array>

Removing the empty dict fixed it.

@Matthias-Ferber-Cantina @jacobweber do you know where the preference file you mention is located? I'm having the same issue but can't find an nvalt preference file for it with that syntax. Thanks!

@volt4ire I'm away from home without my laptop today, but I'm making a note to get back to you when I get home tomorrow, if@jacobweber hasn't come through yet. I think it was inside the ~/Library/Containers hierarchy (or whatever the correct path is to  the Containers directory).

@volt4ire @Matthias-Ferber-Cantina Looks like it's ~/Library/Preferences/net.elasticthreads.nv.plist.


fix some typos in the comments in banking client

This PR just fixes some typos in the comments in banking-client.go

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[WIP] Merge flownetC to main

Codecov Report

Merging #146 (3b9c9eb) into main (91016b6) will increase coverage by 0.32%.
The diff coverage is 98.68%.

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   84.34%   84.67%   +0.32%
==========================================
  Files          62       63       +1
  Lines        2300     2362      +62
==========================================
+ Hits         1940     2000      +60
- Misses        360      362       +2

Impacted Files
Coverage Δ

ezflow/model_zoo/model_zoo.py
100.00% <ø> (ø)

ezflow/models/flownet_c.py
98.03% <98.03%> (ø)

ezflow/encoder/__init__.py
100.00% <100.00%> (ø)

ezflow/encoder/conv_encoder.py
94.44% <100.00%> (-1.02%)
:arrow_down:

ezflow/models/__init__.py
100.00% <100.00%> (ø)


pmb2_navigation: 3.0.0-1 in 'foxy/distribution.yaml' [bloom]

Increasing version of package(s) in repository pmb2_navigation to 3.0.0-1:

upstream repository: https://github.com/pal-robotics/pmb2_navigation.git
release repository: https://github.com/pal-gbp/pmb2_navigation-gbp.git
distro file: foxy/distribution.yaml
bloom version: 0.9.8
previous version for package: null

pmb2_2dnav
* Remove ROS1 launch files
* Comment dependencies pending to be migrated to ROS2
* Fix costmaps and increase max velocity
* Revert "Fix usage of map argument"
  This reverts commit 22d9e4a02b93fa5e9016738312538740a8c7e376.
  Specifying full path is more work but more flexible
* Fix usage of map argument
* Reduce max speeds to avoid crashing into walls
  A similara issue seems to be reported in:
  https://github.com/ros-planning/navigation2/issues/938
  Probably we need more tunning for our robot and/or a different
  controller
* Fixes for slam
* More linter fixes
* Remove hard coded map
* First working pmb2_nav_bringup launch file
* Contributors: Victor Lopez

pmb2_maps
* Create pal_office map with nav2
* Remove hard coded map
* Contributors: Victor Lopez

pmb2_navigation
* Comment dependencies pending to be migrated to ROS2
* Migrate pmb2_navigation to ros2
* Contributors: Victor Lopez

Done!


New release?

@rm-hull can you make a new luma.oled release? (and also for the other projects that have their py27 support removed)

will try and do it tonight

3.5.0 was released, closing.


Removed misleading DEBUG variable from examples

Describe what this patch does to fix the issue.
The configuragion documentation states that "While it is possible to set :data:ENV and :data:DEBUG in your config or code, this is strongly discouraged.So, I believe using theDEBUGsetting in the examples is misleading, as people are led to believe that that is needed to activate the debug mode. Indeed, basically every tutorial on Flask that you find around has theDEBUG` variable in the configuration. I propose we get rid of all of them.

Yeah, it’s better to demo Flask inferring DEBUG based on FLASK_ENV, as these docs mention earlier. Thanks for the PR.
While you’re in here: The DATABASE_URI settings in this example is also SQLALCHEMY_DB example

(Sorry for accidentally hitting the “comment and close” while still editing my comment - never meant to close this. Please see my updated comment.)

Hey @jab don't worry for the temporary close :joy_cat: Yeah it makes sense. Let me mull it over a bit and I will update that part as well. Thanks!

@jab can you have a look at this new version of the PR? Thanks!

Thank you @jab!


Add link rel canonical to the rendered HTML

When checking the Search Console for seeing how y'all are doing, I see about 9,000 duplicated pages and when I look at the results it's because there are heaps of query strings being used to launch squoosh.  If they don't generate different output it might be worthwhile putting <link rel="canonical" href="https://squoosh.app"> in the head element.

cc @mikedelgaudio do you fancy adding this to your PR?

@surma sounds good


StartAt option

Would it be possible to add a startAt option? E.g.
google.startAt = 100
to start from the 100th result?

This feature is added in my pull request:
https://github.com/jprichardson/node-google/pull/29

https://github.com/jprichardson/node-google/releases/tag/1.3.0


re Added curse region + fallout + curse stacking (#36)

Try 2

Waiting on https://github.com/MineInAbyss/DeeperWorld/pull/17 to be pulled in.


Rename FractionallySizedBox box size factor parameters

I also updated Align's doc for the size factor parameters.


Refactor User logic to UserService and alter tests

Summary: Refactor most of User class logic into a UserService class
In this PR, I moved the zipCodeToMapLocation and User constructors into a UserService class to remove some of the load from the User object. In addition, anywhere that there was a user instantiation, I changed it to a userService object. I also converted the UserTest class into a UserService test class since the logic being tested was also moved. The getBusinessesfromPlacesAPI function now takes a mapLocation as input as opposed to a User instance to remove unnecessary information from being passed into the function.
Thanks!

I removed the double constructor in the UserService class and created functions that have the proper parameter. Let me know if this is a sound way to implement this.


Restore advisories and releases redirects

Navigating directly to https://www.cockroachlabs.com/docs/advisories/ and https://www.cockroachlabs.com/docs/releases/ doesn't expand the sidebar properly. This should resolve that.

This change is

@andf-crl Turns out I forgot the exclamation point. Check again?


fix: remove anyhow feature flag from OptionExt location test

1. Clarify trait usage in location test
8522f02
Both WrapErr and ContextCompat expose anyhow compatibility methods.

ContextCompat is completely feature gated behind the anyhow flag.

WrapErr, on the other hand, feature-gates individual functions behind the anyhow flag.

This has led to confusion in the past.
This change moves the use eyre::WrapErr statement from the top of the module into each individual test, as identically named functions (wrap_err.*) are exposed both by WrapErr and ContextCompat.
With use eyre::WrapErr moved directly into the tests, it becomes clear which trait-provided fn is being called.
2. Remove anyhow feature flag from OptionExt location test
68744f1
This bug was introduced (by me) in https://github.com/eyre-rs/eyre/commit/34bd1d98937d775dc8916a638d7ac0eece9e6e97#diff-1ff47dac6cf55e34ff587968c5b1f1ec6b6ae39d2668a66ecba3633163a21fc5R86 - partly due to the confusion fixed with the above commit.
Fixes https://github.com/eyre-rs/eyre/issues/147

I see, good catch.
I recently learnt that conditional trait methods are a backwards compatability nightmare (though WrapErr is sealed thankfully), as there was a recent wasmtime discussion regarding failure to compile because a trait implemented new methods another crate didn't implement under a certain feature flag combiniation.
A better option would be to move these to a supertrait or ContextCompat, and make trait implement for all errors to expose the same behavior as present, without footguns.

That would be an entirely different changeset, though, right?

Yes, just a proposition, as it would alleviate the confusion with two identically named methods from two different traits.
From what I see in the current source code ContextCompat is only implemented for Option, while WrapErr has the context method for errors.
If you are willing to do this, or want me to do this, just let me know.
It is a larger change, but would alleviate some of the confusion and import confusion for downstream users

My intention was to work on https://github.com/eyre-rs/eyre/issues/136 - I only discovered https://github.com/eyre-rs/eyre/issues/147 when starting to look into #136.
If you have time, I'd be glad if you could implement your proposition. I am not entirely sure if I fully see your vision in my mind.

Got my idea here: https://github.com/eyre-rs/eyre/pull/150
I feel I need to clarify that this discussion is more about 8522f02 than the removal of the feature gate of the OptionExt trait.
Just doing what I can to clear out any confusion and make eyre as consistent as possible while we can.
In short, we move the context* methods to ContextCompat and implement it for Options and Results, to make all anyhow compatibility methods reside in one trait rather than two. This has the downside currently of wrap_err not being exposed for Options, but this just leans into the semantics of wrap an error with another higher level error, which does not make much sense for an Option.
When the anyhow feature drops from default features, errors and anyhow+options will be more self-contained and not lead to the same wrap_err in ContextCompat and WrapErr, and context from ContextCompat and WrapErr traits anymore.
Let me know what you think of this.

Thank you for your work Leonie.
Sorry for leaving this hanging, had a rough time lately, but I am back now :tada:

Please do not worry at all! Your wellbeing is always more important. <3


Bug: OCHRE asks for a cooling setpoint schedule when a ResStock building has no cooling

I hit the exception error below when running ResStock models in OCHRE. This building has no cooling system so the hpxml file doesn't come with a weekday/weekend cooling setpoint schedule, but OCHRE is requiring it somehow.

Are you specifying HVAC Cooling (or an ASHP or MSHP) in the dwelling_args? That's the only thing I can think of why this would happen.

Right, we added the following in dwelling_args to force realistic behavior of HVAC and WH. If this has caused this issue, is there an easy fix for it?

Yeah, I would remove the 'HVAC Cooling' line. That should solve it. I guess it's a little tricky since you have to know in advance whether there's cooling or not. There's probably not a great way to know that unless you read the HPXML file first.

I can read the HPXML file and determine if the building has cooling or not, or I can read the buildstock.csv. @jmaguire1 , thoughts?

@JingWang-CUB: Do you still need to parse in those arguments in the first place now that we decided on 2 minute timestep? We were doing that specifically to support 5 minute timesteps not defaulting to realistic controls, weren't we?
IF you do have to parse in whether cooling is present or not, I'd just do whatever's easier. Using HPXML is more flexible, but if you're already loading the buildstock.csv file then go with that.

Removing the following arguments solved this issue.


Collision; upgrade surface dependency.

Because surface_bulma >= 0.4.0 depends on surface ~> 0.7.0 and your app depends on surface ~> 0.11, surface_bulma >= 0.4.0 is forbidden.
So, because your app depends on surface_bulma ~> 0.4, version solving failed.

Sources:

(0.4.0) https://hex.pm/packages/surface_bulma
(0.11.0) https://hex.pm/packages/surface

I will release a new version as soon as possible. Thanks for taking the time to report this.

Should be fixed with the new release of 0.5.0

Looks good! I can add this as a dependency again.
There may be more issues to open as I explore the library, hope to help in any place I can.


Translation sheet

As previously discussed offline, a translation sheet needs to be made for field names - logon_impersonation_level, SIDS, and more.

Can you provide more details on this one @jsecurity101 ?

Absolutely @Cyb3rWard0g,
You, @neu5ron, and I talked in private about creating a translation sheet for things like %%2500 to logon_impersonation_level. Standardizing the translations across the board for all events. Merge HELK and OSSEM a little easier that way.

decided to just do it in a few mins from HELK pipeline configs. Document can grow as HELK parses more.
HELK pipe config: https://github.com/Cyb3rWard0g/HELK/blob/master/docker/helk-logstash/pipeline/1545-winevent-security-conversions.conf
Doc: https://docs.google.com/spreadsheets/d/18hQ0f1Qr4zfK3alDjIMgoLMpX3XJZEbdMKIV7X8YHxI/edit?usp=sharing


Invalid prop value of type string supplied to DatePicker, expected object

I keep getting this error, on my date picker and timePicker. here is my code:
      <Field className = {`${flexItem} ${dayField}`} name= 'eventStartDay' component={DatePicker}
      defaultValue={null}
      hintText='Day' minDate = {tomorrow}/>

Default value on fields of reduxform is empty string

You need to pass format={null}. https://github.com/erikras/redux-form-material-ui/issues/37
http://stackoverflow.com/questions/40492077/setting-a-defaultvalue-for-timepicker-using-redux-form-and-materialui

Thanks @erikras! I should have Googled this problem sooner as I wasted lots of time debugging something that's already been solved 😄 .
To prevent other people from tripping up on the same issue, might it be sensible for this to be the default value, or does that not really make sense?
Thanks for the awesome library!


Model data when no station nearby

Hi!
Congratulations for this amazing repository. I think meteostat could be greatly improved if model data is provided by default if no nearby station is found for a given data point. This happens to me trying to find data in southern Spain as stations are really scarce in some  areas there. As this scenario may appear frequently in certain areas, this new feature could be really cool to add.

That would certainly be nice.
However, we'd need to change the way Meteostat works to achieve that. Currently, model data is specifically stored and retrieved only for the locations where a weather station is installed.
Maybe we can set up a grid (e.g. 5 * 5 km) and provide model-based time series for each grid cell. Then, if there are no stations nearby or gaps in the series, we fall back to the closest grid cell.
This would certainly be a milestone that will take some time to implement. But I agree it would improve data availability in remote areas (or those with few stations). Any thoughts?

Just curious, what is/are the source/s for model data?


Tagging: Existing tag not selected when typing in the search box

I faced an issue when using this great component as a tagging input as follows:
Assume the tags data source is [{id: 1, tagName: "Tag 1"}, {id: 2, tagName: "Tag 2"}, {id: 3, tagName: "Tag 3"}]
when i type "Tag 2" in the search box then press enter, the existing tag is not selected, it always considers it as a new tag.
how can i solve that ?

Can you post a reproduction in Plunker?


[url_launcher] Add note that canLaunch only works for some schemes

And that some configuration is necessary to support custom schemes.
Description
Document that iOS apps need to be configured to allow querying for non-standard URL schemes.
Related Issues

https://github.com/flutter/flutter/issues/42311 (hopefully would have been clearer to the OP)

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the [Flutter Style Guide].
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
[ ] I updated CHANGELOG.md to add a description of the change.
[x] I signed the [CLA].
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Please let me know if this is a good place to document this behavior, or if you would rather prefer a note on the README.

Thanks for the contribution! We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.
Since https://github.com/flutter/plugins/pull/3252 addresses this same concern (via the README, which is where we generally document permissions), and has already been reviewed, I'm going to go ahead and close this. Apologies for the unfortunate duplication due to this PR not having been triaged.


the website is too slow for China user！

i cant open the website in China
it is too slow

Sorry the site is slow for you. Unfortunately there's not much I can do about this. We don't maintain our own infrastructure, and the site itself is just a static set of html/js/css assets. The site is hosted by Github and relies on Github's API. I would check why Github is responding slowly to you.


Missing "?" in constructor property example

The explanation for the "A constructor property" section is missing the ? at the end of the WTF? string.

😱 fixed!


added support for FreeBSD/PCBSD 'pkg' to sudo rule

As stated above.


Number of additional rows is not determined correctly

We seem to be missing a case when a file is generated that is not present in the "ground truth". I.e. we do not count those rows as additional rows. PRC_VINT in e.g. Demo 4 is a good example...

Ah nice catch. I can fix this next week

While fixing this, I noticed that we are generating a lot of output tables with no rows in them (e.g. COM_AGG in Demo 4-all), and the corresponding files (e.g.  COM_AGG_output.csv).
WARNING: 43 additional tables: CAP_BND (0), COM_AGG (0), COM_BNDNET (0), COM_CSTNET (0), COM_ELAST (0), COM_GMAP (0), COM_LIM (0), COM_PKTS (0), COM_STEP (0), COM_TAXNET (0), COM_VOC (0), D (5), FLO_COST (0), FLO_DELIV (0), FLO_FR (0), FLO_FUNC (0), FLO_FUNCX (0), FLO_MARK (0), FLO_SHAR (0), FLO_SUB (0), FLO_TAX (0), G_CUREX (0), M (5), NCAP_AF (0), NCAP_AFC (0), NCAP_AFCS (0), NCAP_CHPR (0), NCAP_CPX (0), NCAP_DISC (0), NCAP_DRATE (0), NCAP_ELIFE (0), NCAP_ILED (0), NCAP_PASTI (0), PASTYEAR (1), PRC_ACTFLO (0), PRC_NOFF (0), PRC_VINT (41), SHAPE (0), STGIN_BND (0), STG_EFF (0), STG_LOSS (0), VDA_CEH (0), VDA_FLOP (0)

Should we filter out empty tables when we dump tables to files?

Let's keep (some of) the empty tables for now. Those output tables that are generated should not be empty, should they? I.e. if they are empty then something is wrong, is it not? On the other hand, if we are generating empty _additional and _missing output tables, those should be filtered out, I think...

Which empty tables do you want to keep?
Perhaps I wasn't clear: we are generating a lot of empty additional tables, like CAP_BND in Demo 4-all. We're also generating the corresponding files CAP_BND_output.csv (these files have just one line, a header). Note that the ground truth files do not have CAP_BND. I propose we add a check to write_csv_tables to only create files for the non-empty DataFrames.
We aren't generating _additional or _missing files for things like CAP_BND above because CAP_BND does not exist in the ground truth.

I see. The empty tables are generated because the tool attempts to generate CSVs for all the attributes in the mapping file, right? Maybe we should consider running it only for the attributes that are actually present in FI_T? I guess, this way neither the warning nor the empty files will be generated? I don't think we should change the behaviour for the other tags in the mapping.
Regarding _additional  and _missing, currently both files are generated even if there are either only missing or only additional records. E.g. in Demo 12:

ACT_CUM only has additional records, so ACT_CUM_missing is empty
COM only has missing records, so COM_additional is empty

Sounds good, thanks, I can make both these changes.


chore: playground wip

Pull request for cloudinary/frontend-frameworks
For which package is this PR?
all
What does this PR solve?
Adding the playground to Lerna so the libraries will be symlinked into them
Final checklist

[ ] Implementation is aligned to Spec.
[ ] Tests - Add proper tests to the added code.
[ ] Relates to a github issue (link to issue).

It is not the final solution, because in order to use playground you will still need to build the package before.
This is due to how the packages are structured and their build process.
But this will allows you to run playground without install the package from npm


Fix error thrown when index configuration has no number_of_replicas specified

Description
Fix error thrown when index configuration has no number_of_replicas specified
Issues Resolved
#83 #108
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi I have tested this PR with default values.

Thanks @rblcoder so I assume it dint complain with the default values when executing tf apply?

Also @rblcoder please try to add some unit tests to this change. Thanks

@prudhvigodithi Yes, it didn't complain with default values on re-apply. Added tests.

Great, thanks @rblcoder, the PR LGTM.


Simulation bus driver issue with cocotb-bus 0.2.0

Since the release of cocotb-bus 0.2.0 the BasilSBusDriver can not read BUS_DATA anymore or reads wrong data and throws errors like
Exception: FPGA module basil.HL.bram_fifo does not satisfy version requirements (read: 0, require: ==2)
Simulation (with verilator v4.106 and cocotb) works with the previous version of cocotb-bus, 0.1.1.

Some parts have been fixed in #167, but the fix (adding the case_insensitive=False argument to BusDriver.__init__() should be added to all other BusDrivers as well or the signal names should be changed to lowercase.

This should be more or less fixed with #232. Closing


moved the branch to a different line, to give it more room

the previous solution was a no go.
After working with lots of other methods, I thought about having the branch move to the main view's .not-editor, when no file was opened, but due to lots of deprecated stuff that the main team is adding, it will break very soon. No point on wasting so much time on this.
I just moved the control below the original project folder.

No configuration is needed, it's just a fast fix for the overlapping project and branch controls.

Looks good, merged, thanks.

@joseporto Much nicer! thank you!


CSS only checkbox/radio styling issues

Checkbox has a pressed state when disabled and should not.  This occurs both for a checkbox that is checked and unchecked

Can we remove the outline so it is consistent with the js versions

Radio hover style is not very crisp

Radio unchecked disabled state has a hover style and should not.

Radio/Checkbox text does not indent properly when wrapped

@mbeard : What is "properly' for number 5?  The text should align with each other and not the input?

I don't see any way to have both of the following without requiring a span around the text:
(a) a label that styles based on checked state
(b) wrapping like we wish.
The reason the custom control can wrap like that is that the input is inside the label and the text is in a custom span.
We have to put the label next to the input or we can't style it based on the :checked state, and we can't wrap only the label and not the input since the "input" is actually a pseudo-element attached to the label.
Make sense?
I believe that I can have the wrapping be like we want if I introduce a span around the text in the label, but I'll need to poke at it, and I must admit that I find doing so distasteful.
I don't like to require markup like that.  :/

(a) I don't think we need label styles based on checked state.
(b) Indentation should ensure that the text is aligned under itself, not under the checkbox - like this.  We should be able to do this through a combination of padding on the container and negative margin on the nested element.

(a) I don't think we need label styles based on checked state.

We do though -- that's how highlight, hover, and checked works: remember, we're not styling the input element itself: we are styling a pseudo-element :before that is on the label.
Without styling the label, there is no custom-styled checkbox, no highlight effect, and no hover effect.
Basically, everything we are doing, iow.

I think I've found a fix using box-shadow.

Fixed by #1209


PIM Audit Logs

Hello, i'd like to automatically send these PIM audit logs to a storage account. Basically the same way you can send AAD logs to a storage account. Thank you

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 80e649ea-1dc1-5fbc-2de5-41ac1424bcfc
Version Independent ID: b8207854-8285-4685-d1e8-33152bfe44ca
Content: View audit history for Azure AD directory roles in PIM
Content Source: articles/active-directory/privileged-identity-management/pim-how-to-use-audit-log.md
Service: active-directory
GitHub Login: @rolyon
Microsoft Alias: rolyon

@KehindeOwens Thanks for your feedback! We will investigate and update as appropriate.

@KehindeOwens We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Add timeouts so the websocket test wont hang for long times

Motivation
Fixes https://github.com/diem/diem/pull/8927/checks?check_run_id=3316801869#step:6:4634
Have you read the Contributing Guidelines on pull requests?
yas
Test Plan
this is a test

This PR may have modified JSON-RPC server code.
Breaking changes policy:

Changing JSON-RPC method signatures or removing/modifying fields
in the response in /V1 will not be accepted.
Adding fields is ok.
Adding a new JSON-RPC method is ok.

Please ensure you have also done the following to update the docs:

Update json-rpc/API-CHANGELOG.md.
Add/update type/method documentation under json-rpc/docs.

This PR contains dependency updates. However, Depdive update review report exceeds max. characters allowed in a GitHub comment. Please, run depdive locally or check actions.


Fix rounding inequalities and allow Makefile to choose between python and python3

Some machines including mine were having float rounding issues when translating some gates (the state phase was equal to 1 + 1e-18j which was not equal to 1)
This PR replaces the array_equal function by allclose, using the default thresholds to ensure this comparison will work even with float issues. It also improves the Makefile to detect if python3 is an available command on the users machine to use it instead.
Safe to revert.

Did further test IRL. I ensured python was referring to version 3 and replaced our check of python3 by some gibberish (to be sure it wouldn't return anything).
The Makefile hence used python in its further calls, looks good to me!


Declaration files generated by tsc output any for all fields for nested yup schemas

Posted in Yup's repo as well here since I'm unsure of the root cause.
Hi Typescript,
I am attempting to use yup to define schemas and associated typescript types. When I try to generate typescript declaration files for the schemas that I've written, I've noticed that the type information for any nested schemas is being lost and converted to any.
I've included a small example to illustrate the problem:
example.ts:
import * as yup from 'yup';

const NestedSchema = yup.object().shape({
  nested: yup.string()
});

export const TestSchema = yup.object().shape({
  working: yup.string(),
  broken: NestedSchema
});

export type Test = yup.InferType<typeof TestSchema>;

Run: tsc -d example.ts:
Actual generated example.d.ts:
import * as yup from 'yup';
export declare const TestSchema: yup.ObjectSchema<yup.Shape<object, {
    working: string;
    broken: yup.Shape<object, {
        nested: any;  // <---- TYPE INFORMATION LOST!
    }>;
}>>;
export declare type Test = yup.InferType<typeof TestSchema>;

Expected output:
import * as yup from 'yup';
export declare const TestSchema: yup.ObjectSchema<yup.Shape<object, {
    working: string;
    broken: yup.Shape<object, {
        nested: string;
    }>;
}>>;
export declare type Test = yup.InferType<typeof TestSchema>;

Another interesting bit of information is that my VSCode IDE is showing the correct types. My coworker and I did some digging around and figured out that the IDE is calling out to tsserver, which implies that tsserver is behaving differently than tsc and that tsserver is showing the intended result.

Is this a known issue? Is there any workaround? Any help would be much appreciated!
Platform:
macOS Mojave 10.14.6
node: v10.17.0
yup: 0.27.0
@types/yup: 0.26.26
tsc: 3.7.3
To repro the issue locally, check out: https://github.com/kingsmendv/issue-yup-infer-type-any/blob/master/package.json

I think it's a bug in the emit declaration part of the compiler. In a project that I help with, the same problem occurs. While inside the project (both vscode and type checking), the types are correctly preserverd, when emitting the types that information is lost.
In the other project I managed to do a workaround by changing the mapped type, but the types are more ugly now :(
https://github.com/dggluz/parmenides/pull/10

Hi @RyanCavanaugh , the Parmenides project that I shared on the 24th doesn't have any dependencies (only devDependencies). https://github.com/dggluz/parmenides/blob/master/package.json
And the Pull Request that I submitted shows how to fix the problem by inverting the inference.
If you like I could try to isolate the problem in a new repo, but it will take me some time.
Let me know :)


Chant Detail: un-proofread volpiano: we need to hide the "melody with text" preview when we're hiding the volpiano

see #1100 - currently, when you visit http://<IP_ADDRESS>/chant/296770 logged-out, you can't see the volpiano, but you can see the melody with text preview.

assigning a priority of High because this blocks the merging of https://github.com/DDMAL/CantusDB/pull/1146.


Guidelines for merging

Opening an issue so we can discuss guidelines for merging PRs (not to be confused with "what belongs to crossbeam crate or not").

A fell like a two maintainers (other than the author) approval is the way to go. Since we are a big group we might even push this number to three.

I think making master a protected branch is a good idea, since it enforces these guidelines comes with all sorts of 'oops' protections

I went ahead and protected master as it seems to be a no-brainer.

I agree with the two reviewers approach, and think that people should feel free to request additional reviews in particularly subtle cases.
For broader design/direction questions, I'd suggest following a basic consensus-based approach: file an issue on the repo laying out your proposal and rationale, tag in the other maintainers, and ensure no-one has a "blocking objection" before going forward. (Basically similar to how the Rust subteams work, but lighter weight).

@aturon @alexcrichton  Since you have a lot of experience with project leadership, I'd love to get some thoughts from you. We have a strong Crossbeam team now, but it really needs help with logistics.
Recently we've had multiple discussions on a new GC and new scalable data structures.
I did a lot of prototyping during the last several months, have laid out my ideas for a new GC design, and got valuable feedback from the crossbeam project members (especially @jeehoonkang, @schets, and @arthurprs). The feedback was usually positive, but there were plenty of objections as well. Even @aturon said he agreed with "at least some" of the ideas. :) But we've yet to write some actual code.
I believe at this point we should write up a roadmap and build a strong epoch-based foundation for the future. Because this is a complex topic with a lot of tradeoffs to be made, I'd like us to reach consensus ASAP and come up with a written design everyone is happy with.
Personally, I'm very fond of Rust's RFC process and would like to see one for the Crossbeam team. Shall we create a crossbeam-rs/rfcs repo, submit several PR's with detailed designs and reach consensus among the members (or at least the most active ones)? Or maybe just create a a PR for a DESIGN.md within this repository?
I'd like to kick off with two RFCs:

Sound and flexible Atomic API design. The current API is too permissive, and relaxed orderings can cause data races (i.e. memory unsafety) in safe code.
Faster, more eager, destructor-supporting, incremental epoch-based GC. The current one performs pinning suboptimally, which is prohibitive in some use cases.

The item (2) is currently blocked on some benchmarking with weaker memory models.
As soon as we come up with a design for (1) and (2), we're golden. We'll already have implementation ready (mostly from the coco crate), so there won't be much waiting. This will give us a solid core for crossbeam, and then we can more easily split the work and branch off in various directions.
Here are some things I'd like to talk about after that:

Deque improvements (see the coco crate).
Concurrent skiplist API. (by then I'll already have a working implementation)
New queues and channels. (I'm implementing this ATM)
Concurrent B-trees. (I have some ideas)

Here are some topics I haven't researched thoroughly, but are fit for Crossbeam:

Lock-free hash maps.
Concurrent radix trees.
Flat combining.
Elimination back-off.

Alternative GCs (maybe useless, but maybe not):

Hazard pointers.
Lock-free RC-based GC (like ArcCell, but better).

I'm sure some of you have even more ideas!
I'm fully ready to write detailed RFCs for items (1) to (6).
Here are some time estimates for design and implementation:

(1) and (2) need 2-4 weeks
(3) needs 1 week
(4) needs 1 month
(5) needs 1 month
(6) needs 3 months

The other two pillars of concurrency in Rust, namely Rayon and Tokio, are seeing great progress. They may also benefit from Crossbeam, so let's not fall behind. ;)
I'm sitting in #crossbeam on irc.mozilla.org. Let's hang out! Perhaps this could be our official channel?

(1) to (2) sound like a no-brainer to me and it's necessary to unblock the other things. Anything me/others can do to speedup that?
I'd :+1: a simplified RFC style process. No need to go full blown here.
I won't really go into the other points because it might deviate the discussion from the important stuff.

I have a test version of an incremental GC that works with the existing epoch system, and at least one of the commits for (1) is pretty easy.
For (9), I'm working on a Rust translation of this library.
What did you have in mind for (5)?
Also, should we break crossbeam into different crates (epoch, data structures, scoped threads) instead of having this one mega-repo?

@stjepang Wow, thank you so much for stepping up to lead! What you've outlined sounds fantastic. Let me leave a few thoughts based on my experience.
First, the most vital thing about the RFC process is that there's a clear space for stakeholders to discuss proposals before they land, and that consensus among the decision-makers is reached before the proposal lands. Everything else (like the venue) is secondary. Like @arthurprs, I think we should start as simple as possible, but it is important that we have room for distinct threads on distinct topics (so something involving a PR is good). Honestly, it probably makes sense to follow Rust's lead here and make a dedicated RFC repo with a (simplified) template, but just keep the process around it lightweight.
I think right now we're in a space where momentum is essential, so we need to avoid striving for perfection up front, and feel free to experiment. Consensus processes can work well for that: consenting doesn't mean "I believe this is perfect and my ideal proposal", but rather "My objections aren't strong enough to block going in this direction".
To make this work well, it's best to have a relatively small number of very involved decision-makers who must reach consensus (and of course everyone is welcome to comment). I wonder if, of the people who stepped up to help with maintenance, we can find a subset of folks who want to push hard on finding a shared vision. It can also help to have a designated "leader", a role I think you may be very well cut out for.
Now, regarding the vision you've laid out: I really couldn't agree more. The steps you've outlined are exactly what I've always hoped crossbeam would turn into. I know the devil is in the details, and we need to get on the same page there, but it'd be good for something like this "roadmap" to serve as the first RFC.

I'd basically just echo @aturon's thoughts, although he's far more eloquent than I :)

Thank you so much for the advice, this is really helpful! :)
I'll create a new repo for a simplified RFC process and write up several proposals over the next few days. Let's get started.

I'm excited! I'd love to have more toys to play with in Rayon. =)
(Flat combining is one area I've been wanting to explore in particular; my experiments in Rayon showed significant wins, and it can make things a lot easier when building complex combinators. I'm still unsure whether it makes sense to build flat-combining in Rayon (as I've been toying with in https://github.com/nikomatsakis/rayon/pull/141) or to do it in a library like crossbeam.)

@nikomatsakis There's an old standing issue in crossbeam for flat combining #63 and I've restarted work on it as well. I think the use case for Rayon is fairly different (extremely high contention for the lifetime of the combiner, lots of available work from a consistent subset of threads) so I'm not sure if it should use the same approach as a general purpose flat combining library would.

@schets indeed, that is the question. Another advantage that Rayon has right now is knowing that there is a fixed pool of threads (more or less) that are active. But it seems plausible to me that one could design a general purpose flat-combiner that performs "good enough".

I think now we can close this, as we have the RFC repo.


Add Surface component

https://material.io/design/environment/surfaces.html#material-environment

[ ] Model
[ ] Desktop app
[ ] Android
[ ] Jvm
[ ] Js


Fix compiler error on wasm with deault features.

getrandom also supported on wasm32: https://github.com/rust-random/getrandom/commit/d3aa089bbdefa95da9130b7c633e1f49687f04ce

Hi! wasm32-unknown-unknown isn't always running inside a browser, and 0.8.1 silently breaks for all other runtimes that do not provide the JS interfaces. Would you consider putting this behind a feature flag (js) just like getrandom does it?

@ar37-rs Based on this, and:
https://github.com/tkaitchuck/aHash/issues/143
https://github.com/tkaitchuck/aHash/issues/141
https://github.com/tkaitchuck/aHash/issues/140
And the recomended practices here:
https://docs.rs/getrandom/latest/getrandom/#webassembly-support
I am reverting these changes to the toml file.


Cant source .bash file

Cant source .bash file
When I put the following instruction in the .zshrc
% source /opt/ros/melodic/setup.bash

It appears
% /opt/ros/melodic/setup.bash:.:8: No such file or directory: /home/techinao/setup.sh

It looks like zsh change all the path to $HOME

Just a heads up, the error is coming from inside the file at line 8.

hey, was this issue resolved? facing the same thing. are there any workarounds?
i just have this in my .zshrc for now but its not a long term solution when it comes to sourcing new workspaces etc
# ros source_ros() {   exec bash -c 'source /opt/ros/jazzy/setup.bash && exec zsh' && export ROS_DOMAIN_ID=27 }

lol, turns out the fix is literally just running the same script with .zsh instead of .bash


Has the Sort By: Install Count for extensions had its behaviour altered?

Didn't the Sort By: features for extensions enable you to sort a list of search-term filtered results? As far as I can tell selecting any sort function now ignores any search terms.

Can you give us an example?


xhrform bugfixes & refinements

bugfix for not removing loading class on form after receiving response
xhrform stores last result&status in form’s dataset to allow more flexible CSSing
cleaned up generic page initialisation in ui-site

lgtm


[CO-424] Add integration tests for Cardano Hardware Wallets

Description

Add the module HardwareWalletSpecs.
This module exports HSpec tests for the following endpoints :
postUnsignedTransaction  -- retrieve an unsigned transaction from the wallet
postSignedTransaction    -- post an externally signed transaction
The tests take a seed::Integer as argument.
This seed is used to create new unique wallets as needed.

Add the module MainHardwareWalletSpecs.
Convenience functions for stand-alone running the tests from a REPL
(outside of Main).

Add unsafeProtocolMagic as a new top level declaration to Main.
Hard-coding ProtocolMagic in Main is a hack that should be fixed !
ProtocolMagic is needed in the tests to compute crypto function
(simulating an external ledger device).
The ProtocolMagic should be passed in from the CLI or read from the defining config file.

Linked issue
[CO-424]

Type of change

[ ] 🐞 Bug fix (non-breaking change which fixes an issue)
[X] 🛠 New feature (non-breaking change which adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
[X] 🔨 New or improved tests for existing code
[ ] ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

[X] I have read the style guide document, and my code follows the code style of this project.
[X] If my code deals with exceptions, it follows the guidelines.
[X] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
[ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

QA Steps

Screenshots (if available)

Side-note: Thanks for the extensive commit message :+1:


set dirty flag when using xform field setters

As per topic - I noticed that the setters on LvEdEngine::Transform weren't setting the dirty flag, so whenever you'd ask for the matrix later you'd get the identity matrix set at init time.

Thanks for reporting the bug.
I fixed it locally and will push the changes on next update.
Please leave the pull open until the changes are pushed.
Alan

Thanks Alan! Sorry about closing the other one, wasn't sure what the guidelines were there. :sweat_smile:

No problem, and thanks for finding and fixing bugs.
I keep the pulls open until I update master branch.
Alan


Table selection changes aren't announced by TalkBack if the checkbox is being toggled

🐛 Bug Report
Discovered in May/June 3.11.0 release testing session. When a row is selected/deselected in Chrome Android with Talkback enabled via double tapping on the checkbox, the announcement regarding the selection change is instantly interrupted by the checkbox's "check"/"unchecked" announcement
🌍 Your Environment

Software
Version(s)

react-spectrum
3.11.0

Browser
Chrome

Operating System
Android (10)

🧢 Your Company/Team
RSP
🕷 Tracking Issue (optional)

@majornista Do you know of any existing Talkback issues around this?

@majornista Do you know of any existing Talkback issues around this?

I don't know of particular issues, but these sorts of race conditions are not uncommon for screen readers. One solution may be to use aria-live= "polite" rather than "assertive", so that the selection announcement might come after the checkbox state change.


Create Basic Website Template

@sanjay-kv
I have created basic template for the website using HTML CSS

@MastanSayyad instead of putting it in the root folder of the repo maybe make a directory with the name Website and do all the website related work in that directory?

Yeah, I almost forgot thanks for reminding me @shreyash3087

Also the github api is working i can fetch all the directories using my token,although i wanted to clear out a couple of things, should i use my token for the authorisation, if yes can i obuscate the token so that its not human readable but still works? or do you have any other ideas?

Yeah you can obfuscate the token but I think we can replace your token with @sanjay-kv's one

@MastanSayyad

I made some small adjustment to the basic template
Removed the machine learning text  in the navbar as it was not looking good before also instead of adding the link as a button i have added it in the navbar as the github icon
Also one thing i noticed in your template was that it was missing a favicon which i have added

@MastanSayyad if you like this changes can you please make me collabrator in your fork i will add this changes to the pull request

Hi @aditya-bhaumik, Thanks for making the changes. However, it is just a template to help us initialize the tasks for the team. That's why I kept it quite basic on purpose. The modifications you made were part of the screening's planned tasks. we can do it once the tasks get started.

@aditya-bhaumik the frontend part can be adjusted later for the whole page,a proper good design can be implemented since this is just a template,although your changes look good,so i guess it can be added for now.

Awesome collaboration.


Changing the resolution of the input image

Very good work, thanks. The image is resized by
img1 = cv2.resize(img1, (img_w, img_h)) is scaled down to img_h = 360, img_w = 480. I tried to modify the resize size to fit a higher resolution of the original image but the inference process failed, do you have a solution? thank you

Actually, this (https://github.com/nie-lang/StabStitch2/blob/main/Full_model_inference/Codes/test_online_tra.py) can deal with higher resolutions. If you tried our traditional datasets, you will find the resolutions of all videos are higher than 360x480.
In our implementation, we estimate the warping fields in the resolution of 360x480. Then the warping fields are resized and we directly warp the original images to get high-resolution results.


[Event Request] Codeunit 99000845: OnAfterInitFilter

We need to apply additional filter on CalcItemLedgEntry.“Expiration Date” for specific CalcReservEntry.
Codeunit 99000845 – Function InitFilter:
OnAfterInitFilter(CalcItemLedgEntry, CalcReservEntry, EntryID) (event at the end of the function)
Thank you!

Is this event specific for CalcItemLedgEntry? If so, should it be placed after block of code for CalcItemLedgEntry in CASE statement for 1:?

No reply for 10+ days, have to close this ask.


Update README URLs based on HTTP redirects

Created with https://github.com/dkhamsing/frankenstein
GitHub Corrected URLs

Was
Now

https://github.com/tannernelson/fluent-example
https://github.com/qutheory/fluent-example

https://github.com/tannernelson/vapor
https://github.com/qutheory/vapor

Thank you!


Origin recreation caused by adding origin shield enabled = false.

Description
Copied from complete example then just added few bits and remove s3 integration
## Reproduction Code

module "cloudfront-xx-xx" {
  # Used by ixxx (Images for Websites)
  source = "./../../../modules/terraform-aws-cloudfront-master"

  providers = {
        aws = aws.aws-global
  }

  aliases = ["xxx"]

  comment             = "xxx"
  enabled             = true
  staging             = false # If you want to create a staging distribution, set this to true
  http_version        = "http2and3"
  is_ipv6_enabled     = true
  price_class         = "PriceClass_All"
  retain_on_delete    = false
  wait_for_deployment = false

  # If you want to create a primary distribution with a continuous deployment policy, set this to the ID of the policy.
  # This argument should only be set on a production distribution.
  # ref. `aws_cloudfront_continuous_deployment_policy` resource: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudfront_continuous_deployment_policy
  continuous_deployment_policy_id = null

  # When you enable additional metrics for a distribution, CloudFront sends up to 8 metrics to CloudWatch in the US East (N. Virginia) Region.
  # This rate is charged only once per month, per metric (up to 8 metrics per distribution).
  create_monitoring_subscription = true
  create_origin_access_identity = false
  create_origin_access_control = false

  origin = {
    xx-xx-co-uk = {
      origin_path = ""
      connection_attempts = 3
      connection_timeout = 10
      domain_name = "xx"
      custom_origin_config = {
        http_port                 = 80
        https_port                = 443
        origin_keepalive_timeout  = 5
        origin_read_timeout       = 30
        origin_protocol_policy = "match-viewer"
        origin_ssl_protocols   = ["TLSv1", "TLSv1.1", "TLSv1.2"]
      }

      #if this is here then it cause constant recreation need to comment this out
      origin_shield = {
        enabled              = false
        origin_shield_region = "us-east-1"
      }
    }

  }

  default_cache_behavior = {
    path_pattern = ""
    target_origin_id       = "xx-xx-xx-xx"
    viewer_protocol_policy = "allow-all"
    allowed_methods        = ["GET", "HEAD", "OPTIONS"]
    cached_methods         = ["GET", "HEAD"]

    use_forwarded_values = false

    cache_policy_id            = "658327ea-f89d-4fab-a63d-7e88639e58f6" # Managed-CachingOptimized
    origin_request_policy_id = "33f36d7e-f396-46d9-90e0-52428a34d9dc" # Policy to forward all parameters in viewer requests

  }

  viewer_certificate = {
    acm_certificate_arn = "xxx"
    ssl_support_method  = "sni-only"
  }

}

Steps to reproduce the behavior:
 resource "aws_cloudfront_distribution" "this" {
        id                             = "xx"
        tags                           = {}
        # (20 unchanged attributes hidden)

      - origin {
          - connection_attempts = 3 -> null
          - connection_timeout  = 10 -> null
          - domain_name         = "xxx" -> null
          - origin_id           = "xxx" -> null

          - custom_origin_config {
              - http_port                = 80 -> null
              - https_port               = 443 -> null
              - origin_keepalive_timeout = 5 -> null
              - origin_protocol_policy   = "match-viewer" -> null
              - origin_read_timeout      = 30 -> null
              - origin_ssl_protocols     = [
                  - "TLSv1",
                  - "TLSv1.1",
                  - "TLSv1.2",
                ] -> null
            }
        }
      + origin {
          + connection_attempts = 3
          + connection_timeout  = 10
          + domain_name         = "xxx"
          + origin_id           = "xx"

          + custom_origin_config {
              + http_port                = 80
              + https_port               = 443
              + origin_keepalive_timeout = 5
              + origin_protocol_policy   = "match-viewer"
              + origin_read_timeout      = 30
              + origin_ssl_protocols     = [
                  + "TLSv1",
                  + "TLSv1.1",
                  + "TLSv1.2",
                ]
            }

          **+ origin_shield {
              + enabled              = false
              + origin_shield_region = "us-east-1"
            }**
        }

        # (3 unchanged blocks hidden)
    }

Expected behavior
Do nothing
Actual behavior
Recreated origin

It is already a known issue in the Terraform AWS provider - https://github.com/hashicorp/terraform-provider-aws/issues/20659
We can't do anything about it in the module.

Hi Anton,Probably just comments in complete example would do. :)Many thanks Rafal ZdziechOn 3 May 2024, at 11:22, Anton Babenko @.***> wrote:
It is already a known issue in the Terraform AWS provider - hashicorp/terraform-provider-aws#20659
We can't do anything about it in the module.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

There is no need to keep track of Terraform AWS provider issues in the modules. Also, things change in the provider on its own schedule.

Thanks AntonI am referring to line 82 in this example. Copying example and setting shield to false cause the issue. Removing block instead of setting to false fixed the problem. So some small comment block would save you answering people like me:)Anyway do what is best for you. Thanks for your repositories. terraform-aws-cloudfront/examples/complete/main.tf at master · terraform-aws-modules/terraform-aws-cloudfrontgithub.comMany thanks Rafal ZdziechOn 3 May 2024, at 13:23, Anton Babenko @.***> wrote:
There is no need to keep track of Terraform AWS provider issues in the modules. Also, things change in the provider on its own schedule.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

I see what you mean now. You are right. We should comment out that block in the example so that the example looks good and works. Could you do it and open a PR?


Handle go_package options in Generator

This changes the generator to handle the go_package option, and if found use that over the proto files's package.

:heart:


Garage simulation for DUALR3 (motor mode)

What issue do you have? Please be as thorough and explicit as possible.
I'm using a DUALR3 in Motor Mode to control a roller shutter (which is my garage door).
The only values it has for showAsMotor option are: blind, door, and window. Changing the device model in Multi Channel Devices section, and selecting a different Show As (simulation) doesn't affect it anyhow.
Is it possible to simulate a Garage Door with a DUALR3 in Motor Mode?
Details of your setup.
I'm using Homebridge 1.3.4 with homebridge-ewelink 7.1.0

Hi @clemencov
You’re right, at the moment a DUALR3 in motor mode can only be shown as a door, window or blind.
These HomeKit accessory types offer %-based positioning, whereas a garage door type HomeKit accessory only offers “open” and “closed”. This is why I haven’t added the garage door open… yet.
It would be possible to show as a garage door, and when open is pressed, it sets the dualr3 to fully open, and when close is pressed then fully close the dualr3.
My query would be how to show the status of the garage if for example the position is 1% (ie almost closed… would this be considered “open”’ or “closed” in homekit. Would it be best to show this as open or closed?

Thank you for your quick answer!
As for my needs, not having precise control and showing it in opened state when it isn't 100% closed will work just fine for me.

Can you update to beta version 7.1.1-beta.2 - you should then see garage door in the list in the config.
Then restart the plugin and see if it works - it's untested code as I don't have a dualr3 setup at the moment!

@bwp91, Just tested the beta version. Works like a charm. Thank you!

In the current state, i’m not sure if you'll get a home app notification if the garage is opened/closed externally, i mean if the device is controlled via the ewelink app or any button you may have setup.
Is this something you could try and let me know whether you get a notification?

When closed and opening it from eWeLink it says "Closing...".
When open and closing it from eWeLink it says "Opening...".
After clicking on it in Home App it changes back to the right state.

When the garage gets opened from eWeLink I get a Homekit notification as well.

I've added a couple of fixes in new beta v7.1.1-beta.4
Could you install this and just verify it's still working okay?
Thanks!

Sorry for not responding, one of the channels of my DUAL R3 got broken, and I've just received a new one. Everything works as expected now. Thank you!


Spurious interrupts on GPIO 36 when using WiFi (IDFGH-2473)

Environment

Development Kit:  none
Module or chip used: ESP32-WROVER-B
IDF version: v3.1.1
Build System: Make
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a) 5.2.0
Operating System: Mac
Power Supply: USB

Problem Description
I'm getting 5 unexpected interrupts per second on GPIO 36 once WiFi connects. This does not happen before WiFi is connected.
I have seen https://github.com/espressif/esp-idf/issues/1096 and other posts but these seem to indicate that as long as I'm not using "the power switch which controls the temperature sensor, SARADC1 sensor, SARADC2 sensor, AMP sensor, or HALL sensor" this should not happen, but I am not using those and it still happens.
Example code below. It counts interrupts on GPIO 36 and 39 printing them every 500ms. After 5 counts it initializes WiFi and continues. In my testing, I get 0 interrupts before initializing WiFi and then get 5 per second once WiFi is connected.
#include "sdkconfig.h"
#include "esp_system.h"
#include "esp_log.h"
#include "esp_err.h"
#include "esp_wifi.h"
#include "esp_event_loop.h"
#include "nvs_flash.h"

#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "freertos/event_groups.h"
#include "freertos/semphr.h"

#include "driver/gpio.h"

static unsigned gpio_36_ints = 0;
static unsigned gpio_39_ints = 0;

static EventGroupHandle_t s_wifi_event_group;

static void IRAM_ATTR gpio_36_handler(void* arg) {
	gpio_36_ints++;
}

static void IRAM_ATTR gpio_39_handler(void* arg) {
	gpio_39_ints++;
}

static esp_err_t event_handler(void *ctx, system_event_t *event)
{
    switch(event->event_id) {
    case SYSTEM_EVENT_STA_START:
        esp_wifi_connect();
        break;
    case SYSTEM_EVENT_STA_GOT_IP:
        ESP_LOGI("", "got ip:%s", ip4addr_ntoa(&event->event_info.got_ip.ip_info.ip));
        break;
    case SYSTEM_EVENT_STA_DISCONNECTED:
		esp_wifi_connect();
		break;
    default:
        break;
    }
    return ESP_OK;
}

void init_wifi() {
	esp_err_t ret = nvs_flash_init();
	if (ret == ESP_ERR_NVS_NO_FREE_PAGES) {
		ret = nvs_flash_erase();
		if (ret == ESP_OK) {
			ret = nvs_flash_init();
		}
	}

	s_wifi_event_group = xEventGroupCreate();

	tcpip_adapter_init();
	ESP_ERROR_CHECK(esp_event_loop_init(event_handler, NULL) );

	wifi_init_config_t cfg = WIFI_INIT_CONFIG_DEFAULT();
	ESP_ERROR_CHECK(esp_wifi_init(&cfg));
    ESP_ERROR_CHECK(esp_wifi_set_storage(WIFI_STORAGE_RAM));
	ESP_ERROR_CHECK(esp_wifi_set_mode(WIFI_MODE_STA));
	ESP_ERROR_CHECK(esp_wifi_start());
    ESP_ERROR_CHECK(esp_wifi_set_ps(WIFI_PS_MIN_MODEM));

	wifi_config_t wifi_config = {
		.sta = {
			.ssid = "AccessPoint",
			.password = "Password"
		},
	};
	ESP_ERROR_CHECK(esp_wifi_set_config(ESP_IF_WIFI_STA, &wifi_config));
	ESP_ERROR_CHECK(esp_wifi_connect());
}

void app_main()
{
	gpio_install_isr_service(0);

	gpio_config_t gpio_36_config = {
			.pin_bit_mask = (1ULL << GPIO_NUM_36),
			.mode = GPIO_MODE_INPUT,
			.pull_up_en = GPIO_PULLUP_DISABLE,
			.pull_down_en = GPIO_PULLDOWN_DISABLE,
			.intr_type = GPIO_INTR_POSEDGE,
	};
	gpio_config(&gpio_36_config);
	gpio_isr_handler_add(GPIO_NUM_36, gpio_36_handler, NULL);

	gpio_config_t gpio_39_config = {
			.pin_bit_mask = (1ULL << GPIO_NUM_39),
			.mode = GPIO_MODE_INPUT,
			.pull_up_en = GPIO_PULLUP_DISABLE,
			.pull_down_en = GPIO_PULLDOWN_DISABLE,
			.intr_type = GPIO_INTR_POSEDGE,
	};
	gpio_config(&gpio_39_config);
	gpio_isr_handler_add(GPIO_NUM_39, gpio_39_handler, NULL);

	init_wifi();

	int counter = 0;

	while (true) {
		printf("%u %u\n", gpio_36_ints, gpio_39_ints);
		vTaskDelay(pdMS_TO_TICKS(500));
		if (counter++ == 5) {
			init_wifi();
		}
	}
    return;
}

https://github.com/espressif/esp-idf/issues/3714

Hi, @vonnieda
This is a known hardware issue. Because WIFI will use ADC.

thanks !!

Hi, @vonnieda
This is a known hardware issue. Because WIFI will use ADC.

thanks !!

我用BLE蓝牙时出现了GPIO39不断中断触发的情况，难道BLE内部也用了ADC？

Thank you @koobest.
Perhaps the documentation could be updated to explicitly state that the GPIO 36 and 39 issue is also caused by WiFi? It could have saved me a lot of time, and a board spin.

So is this only with power save or even without?  If adc is always on there will be no glitch right?

@negativekelvin Just tested: If I explicitly set WIFI_PS_NONE it works fine. No spurious interrupts.

Ok good, I don't know why https://github.com/espressif/esp-idf/issues/3714 is closed, I don't think adc power lock has been implemented

I'd like to close this as duplicate in favour of #4117 (IDFGH-1917). Although issue #3714 has the same cause and will be closed by the same fix, the described behavior is different. Will keep both open #4117 and #3714 open to make them both show in search.


In survey need to assign coordinates and orientation at an arbitrary element in the line

Done (xtrack v0.22.0)


Fix/snap version

Hello,
I realized that the version and grade of the foxy snap was not set properly.
Version and grade are set programmatically from the uros-agent part, hence were conflicting with the ones hard coded in the YAML.
Also, we need the full git history in the action, so we can get the last tagged version when releasing a non-tagged version (So the name can be tag+git-COMMITHASH)

@Guillaumebeuzeboc thanks for that, I'm working on repairing the build of this snap package. One question: shall this be backported to main?

@pablogs9 , it should be, yes. But first the snapcraft.yaml  as well as the build should be ported to humble. I will open a PR for that.

Thanks!


Match styles to Figma mocks

Version 1 matched the styles to the existing form on the public website. In version 2, we want to match them to the design.

Covered in #2045


Design updates for hotels component

Changing 'stay' to 'sleep'
Disabling outline on focus state
Updating datepicker font sizes

:+1:


HAP Warning: Characteristic 00000093-0000-1000-8000-0026BB765291 not in required or optional ...

I get this warning when starting up:
HAP Warning: Characteristic 00000093-0000-1000-8000-0026BB765291 not in required or optional characteristics for service 0000008D-0000-1000-8000-0026BB765291. Adding anyway.
which I think is essentially saying the CO2 level isn't set up as a characteristic of the Air Quality service.
I'm new at this, and not sure how to test this w/ your index.ts, but I think adding CarbonDioxideLevel to airQualityService.setCharacteristic might fix it, based on another plugin I was playing with?
		this.airQualityService.setCharacteristic(Characteristic.Name, 'Air Quality');
		this.initServiceEvents(
			'carbondioxide',
			this.airQualityService.getCharacteristic(Characteristic.AirQuality),
			this.airQualityService.getCharacteristic(Characteristic.CarbonDioxideLevel),
			() => this.updateAirQuality(),
		);

And perhaps the same for StatusLowBattery?

Hi, it appears the CarbonDioxideLevel characteristic is indeed not set to be used with an AirQuality service (https://developers.homebridge.io/#/service/AirQualitySensor), thus displaying this warning, but it should not prevent the plugin from working anyway. I'll silence the warning in a future version.


pre-commit hook for pip-sync

What's the problem this feature will solve?
With the pre-commit hook for pip-compile (https://github.com/jazzband/pip-tools/issues/974), I am confident that any changes that I do in my development environment will be pinned. I would like to have the same for pip-sync so that nobody's development environment gets outdated.
In a project, it might be that one of the collaborators have modified the dependencies and pushed their new pip-compiled requirements.txt. As I get their changes via a git pull, I want to be sure that we (everyone) keep sharing the same dependencies. As far as I see with the current pip-tools workflow, pip-sync has to be run manually. That means, I have to be informed by the collaborator or check the pulled/merged commits to see if I need to run pip-sync. This could lead to some issues, could we automate pip-sync so that we avoid those?
If it gets implemented, the new hook combined with the existing pip-compile hook would allow a mostly automated dependency management.
Describe the solution you'd like
I am no expert at pre-commit, but I think it can be used for developing a new hook similar to that of pip-compile(https://github.com/jazzband/pip-tools/pull/976). I believe one can use the post-merge stage for this hook.
.pre-commit-hooks.yaml for the new hook would something like the following:
- id: pip-sync
  name: pip-sync
  description: Automatically sync requirements.
  entry: pip-sync
  language: python
  files: ^requirements\.(in|txt)$
  args: [--ask]

Alternative Solutions
Simply printing a message that the environment needs to modified could be a better default option as it is not intrusive (https://github.com/jazzband/pip-tools/issues/1076). The default hook configuration can use --dry-run for the args. Users who want automation can change in their .pre-commit-config.yaml by modifying the args from --dry-run to --ask instead.
For the dependencies which are using semantic versioning, it would ideally automatically sync changes in the minor and patch version and ask only for major version changes.
I am new to pip-tools and perhaps I am missing a point. If so, please share your existing solutions/workflows.
Additional context
https://git-scm.com/docs/githooks#_post_merge
Thank you for pip-tools.

Thank you for the proposal!
Would you like to do some performance tests with your hook and open a pull request?

Just testing that the introduced hook is fast enough (running pre-commit locally), by including it in the .pre-commit-config.yaml file. I think that should work.

to be fir, the ask here is not an actual pre-commit hook, but a post update hook (so every time someone updates the git checkouts of the pins, the updates propagate

@RonnyPfannschmidt Thank you, I missed that! Then I think the propsed config should be modified like this:
- id: pip-sync
  name: pip-sync
  description: Automatically sync requirements.
  entry: pip-sync
  language: python
  files: ^requirements\.(in|txt)$
  args: [--ask]
  stages: [post-merge]

@hofrob The 7.0.0 release has a bug that causes pip-sync to do extra work, which is fixed in a release coming soon.


Added  section to VideoRecorder data collector

Added  tag with "sendRecordedMediaForPassedTestCase" setting for reference (as it's hard to figure out without any docs
This page here seems to be a good fit to describe all possible tags of a .runsettings file.

@PBoraMSFT Can you take a look at this PR and approve as you see fit?

@nenoloje Thank you!


add OMF

i know it's a competitor with fisherman but it's an active project and community and should be included.

Absolutely.

ace! :)


Fix typo

should be 'bordered' not 'bordeblack'
probably an issue with find and replacing the term 'red'

Thanks!


postgres password

ideally host/port/user/database/password (or at bare minimum password) should be supplied via environment variables (or whatever other way), but it should not be left out to defaults without any option to change it

The upcoming 0.9 release will have support for overriding any property with environment variables, thus should be able to solve this use-case.

@CzechJiri I've made a fork here https://github.com/LittleBayDigital/docker-kong-service which supports env vars for postgres and cassandra. I'm currently using this image at 2 different companies via a custom Rancher catalog. Feel free to try out the fork until 0.9 comes out.
@thibaultCha good to hear env var override will be available in 0.9. I'll gladly point back my Rancher catalog back to the official image once it's out

thank you @thibaultCha really nice improvement! Would it be worth porting features @yunspace added to the fork to official docker in 0.8?
@yunspace you are reading my mind and actually talking about identical use case I was going for!

Haha thanks @CzechJiri, this feature was originally asked here:   https://groups.google.com/forum/#!topic/konglayer/mfjBUwQHHHk and what I did in the fork was actually exactly what @thibaultCha suggested in that forum.
The reason why I didn't create a PR was because I felt:

the sed approach was very hacky, catering for only a handful of hardcoded environment variables and not all possible env vars.
the fork I made was very Rancher specific. I.e. it contains code which calls the Rancher meta service, which has nothing to do with docker-kong.

If the devs are working on a nicer solution in Kong 0.9, I think it's best to do away with the messy sed calls and retrofit my rancher logic on top of 0.9.

HA, agreed. Probably not worth making the docker messy. Happy to wait for 0.9 and meanwhile use your fork ;-)


Disable Mobile Simulator

Fixes #784
Describe the changes you have made in this pr -
When user open simulator on a mobile device she or he is redirected to new page /simulator/mobile_disabled
This function to work require history management in a browser which is widely supported but checking for that is also in place
Screenshots of the changes (If any) -

Coverage decreased (-0.06%) to 83.223% when pulling caeb294603b4608588fb03285daf4f2a17d9f691 on MrBartusek:disable-mobile-simulator#784 into 5053bffa360af3f895cefef50ea0dc3c3da6d6eb on CircuitVerse:master.

Extended in #810


Dark mode for Gradio demos is hard to read

The text in the demo below from chapter91/mdx is quite hard to read:

Is it possible to tweak this easily @dawoodkhan82 ?

@lewtun I'll take a look


raftstore: add an error-tolerant IoBytesTracker to calculate delta I/O consumption

What is changed and how it works?

Issue Number: Ref #15990

What's Changed:
This PR fixes improper error handling in calls to
get_thread_io_bytes_total and refactors related code for clarity.

get_thread_io_bytes_total can fail in two scenarios:
1. LOCAL_IO_STATS is not initialized.
2. Errors occur during ThreadId::fetch_io_bytes(), such as failing to
open files.

Previously:
• In io.rs, calls to get_thread_io_bytes_total did not handle the
  second type of error.
• In future.rs, error handling was implemented but not abstracted into
  a reusable utility.

This PR introduces IoBytesTracker, an error-tolerant utility. It starts
calculating incremental I/O bytes only after the first successful
initialization of fetch_io_bytes. Any I/O bytes consumed before
initialization are intentionally ignored.

This approach avoids larger inaccuracies by discarding potentially
unreliable data. Since io_bytes_total is a thread-local cumulative
metric, failures before the start of the statistical logic can result
in a falsely underestimated initial value, which may lead to
inaccurate delta calculations.

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

none

/cc @glorv @LykxSassinator  PTAL, thx~

/ok-to-test

/retest

/retest

/retest


DPSL: integrate diagnostics manager

In this PR, the supported diagnostics methods are integrated.
No integration tests, as we plan to have a E-2-E test.
Integration test issue: #41.

Codecov Report

Merging #42 (eac5dd6) into main (b347895) will increase coverage by 20.34%.
The diff coverage is 97.82%.

@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
+ Coverage   64.56%   84.90%   +20.34%
===========================================
  Files          17        9        -8
  Lines         206      212        +6
  Branches       21       26        +5
===========================================
+ Hits          133      180       +47
+ Misses         73       32       -41

Impacted Files
Coverage Δ

diagnostics-extension/src/services/diagnostics.ts
96.36% <96.77%> (ø)

diagnostics-extension/src/services/fake_dpsl.ts
100.00% <100.00%> (ø)

diagnostics-app/src/app/app.component.ts

.../layout/content-layout/content-layout.component.ts

...src/app/dashboard/dashboard/dashboard.component.ts

diagnostics-app/src/app/shared/shared.module.ts

...ics-app/src/app/core/services/telemetry.service.ts

...tics-app/src/app/layout/header/header.component.ts

...s-app/src/app/core/services/diagnostics.service.ts

diagnostics-app/src/test.ts

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b347895...eac5dd6. Read the comment docs.


Added Indexing for Tag Filter commands

if user calls
filter tag/cs2103
he/she is able to see the index of the item.
so she can easily access it now

Nice job!


VirtIO-WDF: Dma: fix CodeAnalysis warnings

Fix warning C6387: ctx->buffer could be 0: this does not adhere to the specification for the function WdfDmaTransactionInitialize.
Fix warning C6386: Buffer overrun while writing to p: the writable size is allocSize bytes, but 72 bytes might be written

@YanVugenfirer vioinput-Win2022x64 Pending — Running tests (23/23): 1 tests failed (Failed: Static Tools Logo Test)
This is very strange, because error is CodeQL results missing but it present in DVL

@YanVugenfirer vioinput-Win2022x64 Pending — Running tests (23/23): 1 tests failed (Failed: Static Tools Logo Test)
This is very strange, because error is CodeQL results missing but it present in DVL

@kostyanf14 we have two drivers in the package and recently changed they are they are build, no? For which driver is the complaint?

@kostyanf14  why HCK-CI/viofs-Win2022x64 test failed?

@YanVugenfirer vioinput-Win2022x64 Pending — Running tests (23/23): 1 tests failed (Failed: Static Tools Logo Test)
This is very strange, because error is CodeQL results missing but it present in DVL

@kostyanf14 we have two drivers in the package and recently changed they are they are build, no? For which driver is the complaint?

Error about vioinput, not viohidkmdf

@kostyanf14 why HCK-CI/viofs-Win2022x64 test failed?

This PR (https://github.com/HCK-CI/AutoHCK/pull/157)  is needed to fix viofs. Will review it.


254 fix flake8 issue

Fixes #254 .
Description
This PR is used to fix the flake8 related issue..
Status
Ready
Please ensure all the checkboxes:

[x] Codeformat tests passed locally by running ./runtests.sh --codeformat.
[ ] In-line docstrings updated.
[ ] Update version and changelog in metadata.json if changing an existing bundle.
[ ] Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
[ ] Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
[ ] Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
[ ] Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
[ ] Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

/build