Fix to #15264 - QueryRewrite: incorporate query filters into nav rewrite

When nav rewrite constructs new EntityQueryable it now looks into EntityType for any query filter annotations and applies them on top. Those predicates are parameterized and the parameters created are injected into the context as part of query execution expression.
Generated predicate expression is re-visited by nav expansion to recursively handle filters (expand potential navigation expansions that were introduced in them).
This adds some complexity to the way navigations are expanded - before the newly constructed join always was guaranteed to be an entity. Now it can be a complex structure with multiple navigations already expanded.

new version up, still a couple outstanding issues/nitpicks left.

            case ExpressionType.AndAlso:

You can do in separate PR. Change this switch case to do pattern match on type rather than node type. It will simplify it a lot.

Refers to: src/EFCore/Query/ExpressionPrinter.cs:193 in bb5a176. [](commit_id = bb5a176f3293b1da986a537942d6de3ce4cbac1b, deletion_comment = False)


MWPW-157005 Marketo thank you fixes

Remove min-height after form load
Hide form, title, and description after form success

Resolves: MWPW-157005
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/bmarshal/one-page/one-page-video?martech=off
After: https://bmarshal-thank-you--milo--adobecom.hlx.page/drafts/bmarshal/one-page/one-page-video?martech=off

Bacom URLs:

Before: https://main--bacom--adobecom.hlx.live/resources/adobe-analytics-sandbox?martech=off
After: https://main--bacom--adobecom.hlx.live/resources/adobe-analytics-sandbox?martech=off&milolibs=bmarshal-thank-you

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

PSI check failing due to above the fold form with third party dependency.


Sorting by date when plotting a series of "daily metrics"

Thank for your creating a great plugin!
I've been trying to follow the "OKR Tracker" example; but just cannot for the life of me figure out how to write a query so the results are returned in date order.
My setup is as follows.
On each daily journal page I have an "exersize" TODO with a pace-best-mile::  block property:

I want to plot a chart to show the trend of how the pace-best-mile::  metric is changing day by day. (I'm trying to get fitter :) )
This is what I have sofar - it almost works except that the days on the X axis aren't in date order :(

This makes sense because the results of the query I'm using aren't in date order either.
Here is the query I'm using:
#+BEGIN_QUERY
{
  :query [:find ?date ?result
          :in $ ?start ?today
          :where
		; blocks from Journal pages between ?start and ?today
		[?b :block/page ?journal]
		[?journal :block/name ?date]
		[?journal :block/journal-day ?d]
			[(>= ?d ?start)]
			[(< ?d :today)]
		; value of pace-best-mile:: properties
		[?b :block/properties ?block_props]
		[(get ?block_props :pace-best-mile nil) ?result]
  ]
  :inputs [:30d-before :today]
}
#+END_QUERY

How can I order the X axis values in date order?
Thanks!

Hi, please try the new version v0.5.5. The result of advanced query is sorted by default.

Awesome!  That works for me.
🙇🏼


Add solutions to Basic JS, OOP, and Automated Test

Tested locally. Passes npm run test-challenges. References #4111.

Added solutions to Basic Javascript, Object Oriented and Functional
Programming, and Automated Testing and Debugging
Linted when I could (e.g. fix errors COM1000 was throwing, remove unnecessary
white space and comments)

@erictleung Thanks!


how can i get the system calls of an sdn application?

Mininet uses GitHub issues for bug reports and feature requests only.
These issues can be viewed at bugs.mininet.org
If you have a question that is not a bug report or a feature request,
please use the documentation at docs.mininet.org, the FAQ
at faq.mininet.org, and the mininet-discuss mailing list.
For bug reports, please fill in the following information in detail,
and also feel free to include additional information such as debug
output from mn -v debug, etc.
--- Cut Here ---
Expected/Desired Behavior:
Actual Behavior:
Detailed Steps to Reproduce the Behavior:
Additional Information:

@kinza51214 Did you read the github issue template which you conveniently included above?


Error when trying to sync with new version 5.5

Hello Team,
I'm having some issues when trying to sync application for the version 5.5. I have updated recently with the 5.5 migration guide but the sync fails with the next error code:
HotFix for app service authentication issue (1}#1226)

Attached is the error.
_**Creating an optimized production build...
Browserslist: caniuse-lite is outdated. Please run:
npx update-browserslist-db@latest
Why you should do it regularly: https://github.com/browserslist/update-db#readme
Browserslist: caniuse-lite is outdated. Please run:
npx update-browserslist-db@latest
Why you should do it regularly: https://github.com/browserslist/update-db#readme
Failed to compile.
TS7006: Parameter 'c' implicitly has an 'any' type.
207 |     setAllUsersState(false);
208 |     if (teams && teams.length > 0) {

209 |       const teamsSelected = teams.filter((c) => messageState.teams.some((s) => s === c.id));
|                                           ^
210 |       setTeamsSelectedOptions(teamsSelected || []);
211 |       const roastersSelected = teams.filter((c) => messageState.rosters.some((s) => s === c.id));
212 |       setRostersSelectedOptions(roastersSelected || []);

Failed exitCode=1, command=npm run build
An error has occurred during web site deployment.
npm WARN old lockfile \r\nnpm WARN old lockfile The package-lock**_

Hi @Axael85 ,
Thanks for raising the query. Could you please confirm on the below points.

What is the version of the app before SYNC?
What is the existing app service plan? Here is the reference.

Hello @gsv022 ,
Thanks for contacting me, the version were the app was on 5.0 and followed the migration guide for the 5.5.
HEre is screenshot for the plan

HEllo @gsv022 ,
I have checked the function apps and are pointing to runtime version ~4 and app service to .Net 6

As well tried another sync and same result :

Hi @Axael85 ,

If your previous version is v5.4.1 or lower, please add the parameters as per this step in the app service configuration.

Save it

Disconnect the repository. Give some time to delete.

Then connect to the same repository again.

Keep us posted

Hello @gsv022 ,
As mention befeore, the previous version was 5.0 and then updated to 5.5 following the migration documentation provided. I have double checked the parameters and they were created on the migration documentation steps.
As well tried to disconect the repository and connect again and now received next error :
Failed to set up deployment: Repository 'UpdateSiteSourceControl' operation failed with System.Net.WebException: Could not find a part of the path 'C:\home\site\deployments\settings.xml'.     at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, FileOptions options, String msgPath, Boolean bFromProxy)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean useAsync)
at System.Xml.XmlWriterSettings.CreateWriter(String outputFileName)
at System.Xml.XmlWriter.Create(String outputFileName, XmlWriterSettings settings)
at System.Xml.Linq.XDocument.Save(String fileName, SaveOptions options)
at XmlSettings.XmlUtility.CreateDocument(XName rootName, String path)
at XmlSettings.XmlUtility.GetDocument(XName rootName, String path, Boolean createIfNotExists)
at XmlSettings.Settings.GetDocument(Boolean createIfNotExists)
at XmlSettings.Settings.SetValueInternal(String section, String key, String value)
at XmlSettings.Settings.SetValue(String section, String key, String value)
at Kudu.Core.Settings.DeploymentSettingsManager.SetValue(String key, String value) in C:\Kudu Files\Private\src\master\Kudu.Core\Settings\DeploymentSettingsManager.cs:line 93
at Kudu.Services.Settings.SettingsController.<>c__DisplayClass4_0.b__0() in C:\Kudu Files\Private\src\master\Kudu.Services\Settings\SettingsController.cs:line 62
at Kudu.Contracts.Infrastructure.LockExtensions.<>c__DisplayClass3_01.<LockOperation>b__0() in C:\Kudu Files\Private\src\master\Kudu.Contracts\Infrastructure\LockExtensions.cs:line 59    at Kudu.Contracts.Infrastructure.LockExtensions.TryLockOperation(IOperationLock lockObj, Action operation, String operationName, TimeSpan timeout) in C:\Kudu Files\Private\src\master\Kudu.Contracts\Infrastructure\LockExtensions.cs:line 34    at Kudu.Contracts.Infrastructure.LockExtensions.LockOperation[T](IOperationLock lockObj, Func1 operation, String operationName, TimeSpan timeout) in C:\Kudu Files\Private\src\master\Kudu.Contracts\Infrastructure\LockExtensions.cs:line 59
at Kudu.Services.Settings.SettingsController.Set(JObject newSettings) in C:\Kudu Files\Private\src\master\Kudu.Services\Settings\SettingsController.cs:line 0
at lambda_method(Closure , Object , Object[] )
at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.<>c__DisplayClass10.b__9(Object instance, Object[] methodParameters)
at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ActionExecutor.Execute(Object instance, Object[] arguments)
at System.Web.Http.Controllers.ReflectedHttpActionDescriptor.ExecuteAsync(HttpControllerContext controllerContext, IDictionary2 arguments, CancellationToken cancellationToken) --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Web.Http.Controllers.ApiControllerActionInvoker.<InvokeActionAsyncCore>d__0.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Web.Http.Filters.ActionFilterAttribute.<ExecuteActionFilterAsyncCore>d__0.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Web.Http.Filters.ActionFilterAttribute.<CallOnActionExecutedAsync>d__5.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Web.Http.Filters.ActionFilterAttribute.<ExecuteActionFilterAsyncCore>d__0.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Web.Http.Controllers.ActionFilterResult.<ExecuteAsync>d__2.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Web.Http.Controllers.ExceptionFilterResult.<ExecuteAsync>d__0.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Web.Http.Controllers.ExceptionFilterResult.<ExecuteAsync>d__0.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__1.MoveNext() ---> System.Net.WebException: The remote server returned an error: (500) Internal Server Error.    at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)    at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization) --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Web.Hosting.Administration.Utilities.WebRequestHelper.<GetResponseAsyncWithTimeout>d__10.MoveNext() in C:\__w\1\s\src\Hosting\AdministrationService\Microsoft.Web.Hosting.Administration\Utilities\WebRequestHelper.cs:line 81 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Web.Hosting.Administration.SiteRepositoryProvider.TrackerContext.<GetResponseAsync>d__41.MoveNext() in C:\__w\1\s\src\Hosting\AdministrationService\Microsoft.Web.Hosting.Administration\Providers\SiteRepositoryProvider.cs:line 741    --- End of inner exception stack trace ---    at Microsoft.Web.Hosting.Administration.SiteRepositoryProvider.TrackerContext.<GetResponseAsync>d__41.MoveNext() in C:\__w\1\s\src\Hosting\AdministrationService\Microsoft.Web.Hosting.Administration\Providers\SiteRepositoryProvider.cs:line 755 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Web.Hosting.Administration.SiteRepositoryProvider.<SetSettingsAsync>d__31.MoveNext() in C:\__w\1\s\src\Hosting\AdministrationService\Microsoft.Web.Hosting.Administration\Providers\SiteRepositoryProvider.cs:line 349 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Web.Hosting.Administration.ExternalSiteRepositoryProvider.<UpdateSiteSourceControl>d__5.MoveNext() in C:\__w\1\s\src\Hosting\AdministrationService\Microsoft.Web.Hosting.Administration\Providers\ExternalSiteRepositoryProvider.cs:line 78 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Web.Hosting.Administration.WebCloudController.<>c__DisplayClass370_1.<<UpdateSiteSourceControl>b__1>d.MoveNext() in C:\__w\1\s\src\Hosting\AdministrationService\Microsoft.Web.Hosting.Administration\Controllers\WebCloudController.cs:line 11079 --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at Microsoft.Web.Hosting.AsyncHelper.RunSync[TResult](Func1 func)
at Microsoft.Web.Hosting.Administration.WebCloudController.UpdateSiteSourceControl(String subscriptionName, String webspaceName, String name, SiteSourceControl siteSourceControl) in C:__w\1\s\src\Hosting\AdministrationService\Microsoft.Web.Hosting.Administration\Controllers\WebCloudController.cs:line 11074

Hello @gsv022 ,
Now we are able to sync succesfully, working now!
Thanks a lot for your support, we can close this case:)

Hi @Axael85 ,
Thank you for the confirmation.


IPv6 RA messages specific routes

Is it possible to have dhcpcd handling IPv6 more specific routes received in IPv6 Router Advertisement messages, as described in RFC4191?

A motivating use case:

You have a router which provides internet access (GUA prefix) and offers a default route.
You add a separate VPN router (ULA prefix) onto the same link which is supposed to handle all traffic on your corporate extranet.  This router advertises a non-default route for a /48 version of the ULA prefix, but no default route.

At the moment dhcpcd will not pick up the non-default route from the VPN router and will just push everything down the default route.

I am taking a swing at this now.

Basic functionality is working, but I need to test more and read RFC4191 more thoroughly to see if there is stuff I should add.
https://github.com/goertzenator/dhcpcd/tree/rfc4191route


DO NOT MERGE: BAU: Use later version of hub-saml and verify-saml-libs with fixes

The newer version of verify-saml-libs have fixes to give metadata resolver unique names when adding them to the metric.

There are issues with this set of changes.


P256 ciphersuite issue

To be investigated, right now we get the following error in the group tests:
thread 'group_operations' panicked at 'called Result::unwrap() on an Err value: InvalidPoint', /Users/raph/.cargo/git/checkouts/hpke-rs-b1873fcfc2d2292e/fb79bbd/src/dh_kem.rs:32:50

Can you create a minimal example for this and put it an issue in https://github.com/franziskuskiefer/hpke-rs/issues?

Example:
let hpke = Hpke::new(
        Mode::Base,
        KemMode::DhKemP256,
        HpkeKdfMode::HkdfSha256,
        HpkeAeadMode::AesGcm128,
    );
    let kp = hpke.generate_key_pair();
    hpke.seal(
        kp.get_public_key_ref(),
        &[],
        &[],
        &[1, 2, 3],
        None,
        None,
        None,
    )
    .unwrap();

While the error occurs in hpke-rs, I'm not sure what causes it. It could also be in the ciphersuite module.

Ah, I know what's going on. Not an issue in here. Strictly speaking a bug in the evercrypt bindings. It should be fixed on the 0.0.3 branch branch (0.0.2 for hpke). To pull these versions in a little more work is needed though. I filed #167 for this.


How would I go about refetching a query if another query comes back changed?

Basically, I have a query that I want to go and check a timestamp, and if that timestamp has changed, I want to refetch or fetch the actual data I need.
Is this possible? If so, how would I go about doing this? Thanks.

Hello and thanks :)
Since query keys uniquely describe the data they are fetching, they should include any variables you use in your query function that change.
I think that the timestamp should be included in your queryKeys.
Please see this https://sveltequery.vercel.app/guides/query-keys

Hi there, I figured it out, thanks!


Fix incorrect src access mask in GLTF image upload

Description
Fix #38
General Checklist:
Please ensure the following points are checked:

[X] My code follows the coding style
[X] I have reviewed file licenses
[X] I have commented any added functions (in line with Doxygen)
[X] I have commented any code that could be hard to understand
[X] My changes do not add any new compiler warnings
[X] My changes do not add any new validation layer errors or warnings
[X] I have used existing framework/helper functions where possible
[X] My changes build and run on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

Adding this flag causes validation errors on an S8 Adreno.
2019-05-27 12:06:40.851 12234-13129/com.khronos.vulkan_samples E/VulkanSamples: [error] [s available, enabling it:33] Validation:  [ VUID-vkCmdPipelineBarrier-pMemoryBarriers-01184 ] Object: 0x7bb51fe010 (Type = 6) | vkCmdPipelineBarrier(): pImageMemBarriers[0].srcAccessMask (0x1000) is not supported by srcStageMask (0x4000). The spec valid usage text states 'Each element of pMemoryBarriers, pBufferMemoryBarriers and pImageMemoryBarriers must not have any access flag included in its srcAccessMask member if that bit is not supported by any of the pipeline stages in srcStageMask, as specified in the table of supported access types.' (https://www.khronos.org/registry/vulkan/specs/1.0/html/vkspec.html#VUID-vkCmdPipelineBarrier-pMemoryBarriers-01184)
2019-05-27 12:06:40.882 12234-13129/com.khronos.vulkan_samples E/VulkanSamples: [error] [s available, enabling it:33] Validation:  [ VUID-vkCmdPipelineBarrier-pMemoryBarriers-01184 ] Object: 0x7bb51fe010 (Type = 6) | vkCmdPipelineBarrier(): pImageMemBarriers[0].srcAccessMask (0x1000) is not supported by srcStageMask (0x4000). The spec valid usage text states 'Each element of pMemoryBarriers, pBufferMemoryBarriers and pImageMemoryBarriers must not have any access flag included in its srcAccessMask member if that bit is not supported by any of the pipeline stages in srcStageMask, as specified in the table of supported access types.' (https://www.khronos.org/registry/vulkan/specs/1.0/html/vkspec.html#VUID-vkCmdPipelineBarrier-pMemoryBarriers-01184)

That's confusing, because there's no place in the code where I see a combination of VK_ACCESS_TRANSFER_WRITE_BIT and VK_PIPELINE_STAGE_HOST_BIT in the same barrier.  Also I get no validation error on my desktop, which suggests to me that the adreno validation failure is a false positive from an older version of the validation layers.

I can't find any previous bug in the validation layers that would explain this behavior, but I also can't explain the combination of srcAccessMask 0x1000 VK_ACCESS_TRANSFER_WRITE_BIT and srcStageMask 0x4000 VK_PIPELINE_STAGE_HOST_BIT.  I'm attempting to do an android build now but I only have the following devices to test:  Pixel, Pixel 3a, S9 and S6
Can you provide more detail as to what example was being run when you encountered this warning?  I know the performance examples that load the Sponza scene exercise this code path, but I'm not sure if anything else does.

I've tested on my Pixel 3a, and run the render_passes performance example, which I know exercises the changed code.  The logcat of initialization and starting to render is located here.  You can see from the logging that validation is enabled (I had to manually modify the cmake arguments in the gradle file to trigger this).
I can't reproduce the validation message.
I'll try testing on the S6 as well (once it gains sufficient charge), but the behavior suggests a bug in either the validation layers or the driver on the S8 Adreno.  The validation layers are not device specific, so given the same client code I should generate the same errors you're getting.

That's weird, I can't seem to reproduce these validation messages anymore, everything looks clean to me now.


Remove advanced flag from SSH add-on

https://www.home-assistant.io/hassio/installation/
During step # 7, we ask that the user install this addon.
But it is now hidden.
I think it's better to remove the flag here, instead of telling every user that they have to enable advanced mode in HA for it to show.

We could also adjust the documentation instead.
SSH/Web terminals should not be used for users running Home Assistant as a non-advanced mode.

True


Material 2 branch doesn't work when running npm start

When I do a fresh checkout, then checkout the material2 branch, then run npm install, then npm start I get this:
Joshs-MBP:angular2-webpack-starter joshterrill$ npm start

><EMAIL_ADDRESS>start /Users/joshterrill/Projects/angular2-webpack-starter
> npm run server:dev

><EMAIL_ADDRESS>server:dev /Users/joshterrill/Projects/angular2-webpack-starter
> webpack-dev-server --config config/webpack.dev.js --progress --profile --watch --content-base src/

/Users/joshterrill/Projects/angular2-webpack-starter/node_modules/webpack/lib/webpack.js:16
                throw new WebpackOptionsValidationError(webpackOptionsValidationErrors);
        ^
WebpackOptionsValidationError: Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration has an unknown property 'tslint'. These properties are valid:
   object { amd?, bail?, cache?, context?, dependencies?, devServer?, devtool?, entry, externals?, loader?, module?, name?, node?, output?, plugins?, profile?, recordsInputPath?, recordsOut
putPath?, recordsPath?, resolve?, resolveLoader?, stats?, target?, watch?, watchOptions? }
   For typos: please correct them.
   For loader options: webpack 2 no longer allows custom properties in configuration.
     Loaders should be updated to allow passing options via loader options in module.rules.
     Until loaders are updated one can use the LoaderOptionsPlugin to pass these options to the loader:
     plugins: {
       new webpack.LoaderOptionsPlugin({
         // test: /\.xxx$/, // may apply this only for some modules
         options: {
           tslint: ...
         }
       })
     }
 - configuration.module has an unknown property 'preLoaders'. These properties are valid:
   object { exprContextCritical?, exprContextRecursive?, exprContextRegExp?, exprContextRequest?, loaders?, noParse?, rules?, unknownContextCritical?, unknownContextRecursive?, unknownConte
xtRegExp?, unknownContextRequest?, wrappedContextCritical?, wrappedContextRecursive?, wrappedContextRegExp? }
   Options affecting the normal modules (`NormalModuleFactory`).
 - configuration.node.global should be a boolean.
 - configuration.resolve has an unknown property 'modulesDirectories'. These properties are valid:
   object { alias?, aliasFields?, cachePredicate?, descriptionFiles?, enforceExtension?, enforceModuleExtension?, extensions?, fileSystem?, mainFields?, mainFiles?, moduleExtensions?, modul
es?, plugins?, resolver?, symlinks?, unsafeCache? }
 - configuration.resolve.extensions[0] should not be empty.
    at webpack (/Users/joshterrill/Projects/angular2-webpack-starter/node_modules/webpack/lib/webpack.js:16:9)
    at processOptions (/Users/joshterrill/Projects/angular2-webpack-starter/node_modules/webpack-dev-server/bin/webpack-dev-server.js:269:17)
    at Object.<anonymous> (/Users/joshterrill/Projects/angular2-webpack-starter/node_modules/webpack-dev-server/bin/webpack-dev-server.js:297:1)
    at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:139:18)
    at node.js:968:3

npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "server:dev"
npm ERR! node v4.4.7

npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>server:dev: `webpack-dev-server --config config/webpack.dev.js --progress --profile --watch --content-base src/`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>server:dev script 'webpack-dev-server --config config/webpack.dev.js --progress --profile --watch --content-base src/'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2-webpack-starter package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     webpack-dev-server --config config/webpack.dev.js --progress --profile --watch --content-base src/
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular2-webpack-starter
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular2-webpack-starter
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/joshterrill/Projects/angular2-webpack-starter/npm-debug.log

npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
npm ERR! node v4.4.7
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `npm run server:dev`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'npm run server:dev'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular2-webpack-starter package,
npm ERR! not with npm itself.

Here's the actual log file it produced:
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 silly lifecycle<EMAIL_ADDRESS>no script for prestart, continuing
7 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>8 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
9 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/Users/joshterrill/Projects/angular2-webpack-starter/node_modules/.bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/MacGPG2/bin
10 verbose lifecycle<EMAIL_ADDRESS>CWD: /Users/joshterrill/Projects/angular2-webpack-starter
11 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'npm run server:dev' ]
12 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
13 info lifecycle<EMAIL_ADDRESS>Failed to exec start script
14 verbose stack Error<EMAIL_ADDRESS>start: `npm run server:dev`
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
14 verbose stack     at emitTwo (events.js:87:13)
14 verbose stack     at EventEmitter.emit (events.js:172:7)
14 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:87:13)
14 verbose stack     at ChildProcess.emit (events.js:172:7)
14 verbose stack     at maybeClose (internal/child_process.js:827:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
15 verbose pkgid<EMAIL_ADDRESS>16 verbose cwd /Users/joshterrill/Projects/angular2-webpack-starter
17 error Darwin 15.6.0
18 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
19 error node v4.4.7
20 error npm  v3.10.8
21 error code ELIFECYCLE
22 error<EMAIL_ADDRESS>start: `npm run server:dev`
22 error Exit status 1
23 error Failed at the<EMAIL_ADDRESS>start script 'npm run server:dev'.
23 error Make sure you have the latest version of node.js and npm installed.
23 error If you do, this is most likely a problem with the angular2-webpack-starter package,
23 error not with npm itself.
23 error Tell the author that this fails on your system:
23 error     npm run server:dev
23 error You can get information on how to open an issue for this project with:
23 error     npm bugs angular2-webpack-starter
23 error Or if that isn't available, you can get their info via:
23 error     npm owner ls angular2-webpack-starter
23 error There is likely additional logging output above.
24 verbose exit [ 1, true ]

Is this something on my end or is this something that needs to be fixed in the code? It seems like from the error message that the version of webpack it's using doesn't allow custom to be defined in the configuration.

There is a pr to update that branch #1041

Got it.


Refactoring autoinstrumentation webhook in prep for auto-instrumentation-v2

What does this PR do?
https://datadoghq.atlassian.net/browse/APMON-1267
This change moves around the webhook configuration so that it is easier to change later on.

Language data belongs with the language_versions.go file instead of in a function -- the functions are now methods on the language type.
env vars are all in env_vars.go

Introducing the concepts:

annotationExtractors: declarative annotation extractors for pods we use these for extracting libInfo from the annotations, libConfig, etc.

mutators: podMutators and containerMutators... these are interfaces that are composable and reusable that we can leverage with implementations: volumeMount, volume, initContainer, etc.

libRequirements: each language can produce the requirements for each language to be injected.

Additional Notes
There are some things in this PR that are not actual changes, but moved over from auto_instrumentation.go into their respective files.
Motivation
This decouples the refactor of the webhook to make #27811 possible from the changes to implement auto-instrumentation-v2 itself. This gives us test coverage for the new package-internal types and components and we can see that all tests pass for autoinstrumentation -- functionally this is a no-op.
Describe how to test/QA your changes
The mutators and extractors have high-level test coverage from the autoinstrumentation tests. Also adding tests for the mutator types and the annotationExtractors specifically.

/merge


HAML comments cleanup

In general, I do not see the point of keeping commented code in the repo.  If you remove it, it will stay in git history should we ever need it.
Also, not following the whitespace changes on valid comments.

@chessbyte sorry, my regexp was too effective. Check it out now!

I still see a number of instances that look like we're killing deliberate indentation, including one that's severely damaging readability, and one that's destroying the structure of commented code.
The not-terribly-numerous occasions where someone has apparently typed #<sp><sp>foo when they meant #<sp>foo really don't worry me very much... but it seems fine to clean them up. That said, I'd rather spend some time being alarmed at the amount of code duplication they're highlighting.

@chessbyte I was removing the spaces according to haml-lint, but if the indentation is important, I can put back some of them

@romanblanco review please

looks good

ready to merge!


zodios-react key from useXXX is differ from getKeyByXXX

The Bug
Here is a reproduction CodeSandbox.
The bug is caused by explicitly passing undefined as config to a useXXX. But not on getKeyByXXX
Workaround
Explicitly pass {} to getKeyByXXX as config.
The workaround would NOT work if I try to getKeyByXXX on a immutable query. It's because useImmutableQuery additionally append body to its queryKey.
The Root Cause
For useXXX

useQuery picks params, queries and use it to produce the queryKey.
The pick function would at least return an empty object even if the obj is undefined
The explicit undefined config of useXXX produce a {} in its queryKey

For getKeyByXXX
It essentially do the same as useXXX. But it checks if config is passed and then make it part of queryKey.
Possible Solution
At first, I believe there is a bug on pick implementation. If the obj is undefined, it should return undefined, too.
Fix the Mismatch Behavior between useXXX and getKeyByXXX.
Both these two function needs to derive queryKey from config. So either copy paste the code one another . Or an helper method might be cleaner.

Hope the context is enough for you to fix this. I'm sorry that currently I don't have time to do the PR.

Thank you for taking the time to report this issue and also to create a reproductible example.
This will be fixed today as it should be an easy fix.
to evoid issues in the future, i'll share the code between the two.

Sorry for delay, not as easy as i thought.

Is there any update on this? Really liking the library so far but this "breaks" my hydration setup.
I investigated it a bit and it seems like in the getKeyByX methods there is a check whether config is undefined or not. But useQuery does not have that check. Could this be the issue?


DomainKeys Identified Mail still pending

Hi my region US East (N. Virginia) us-east-1... I made an identity of domain with this name mail.escuela-ray-bolivar-sosa.com..but my status is still pending how i change it to the "approved"

i read documentation but i didnot understand it. kindly help
Thanks

Hi @umerghori786 👋🏽 , thanks for reaching out. Please review this troubleshooting guide for DKIM issues: https://docs.aws.amazon.com/ses/latest/dg/troubleshoot-dkim.html. If you need further assistance please create a Support Case so that you can receive better assistance since this GitHub repository is for addressing questions regarding the AWS Amplify Console.


fix the bug

when Head is wrong, the return value shouldn't be nil
Signed-off-by: shenwenjie<EMAIL_ADDRESS>

Hi, it confused about the data. Found and copied values is the same. And the data isn't copied into dstination, which caused the data loss?


TypefaceHelper

added method that returns Typeface by name from the TypefaceCache

@cioraneanu Thank you for the contribution! A colleague will put this up on jcenter soon, but in the meanwhile you can get the package through jitpack.io: compile 'com.github.Drivemode:TypefaceHelper:5667c6a326'

Sweet! Thank you for the library! :D


income >= 100,000

Replicate:

Go to predictions
enter income >= 100,000
click on stacked income tab
bathe in the warm glow of an error message

Result I'd Expect:

a nice graph

Actual Result:

an error

Environment:
Operating system and version: ubuntu 18.something
Browser type and version: chrome Version 70.0.3538.110 (Official Build) (64-bit)

As discussed, this may not be a pressing problem, but it'll be on the backlog. Thanks for writing this up!

Also, this is just logic, though it's a bit buried. Feel free to assign this issue to yourself if you want to go spelunking! Btw, both the last two charts should have this problem.

This may have been resolved on the dev branch. when i ran that on my computer, i did not have this issue.  hmmm.  i'll get around to this, just not sure when.

Intriguing!


T265 Upgrade Firmware to <IP_ADDRESS>1

Make initial yaw consistent when starting forward, backward, up and down
Fix intermittent descriptor/imu corruption

@dorodnic, please wait for feedback on these.

@radfordi Anything special to test?

Hi @radfordi, I'm having some questions regarding this firmware. What problem is supposed to be solved by this?

Make initial yaw consistent when starting forward, backward, up and down

Today I was trying (for the first time to be honest) to start the camera pointing up, down and backward. While the up and down results are completely inaccurate, the backward result is similar to the forward.
The initial yaw values for an up and downward start seem to be wrong as before.
I suppose it is still necessary to apply a different transformation to the values as stated  here https://github.com/IntelRealSense/librealsense/issues/4080#issuecomment-515498130

Wait, maybe it is not that bad at all and I just have some hidden bug in my app. I created a little test script from the old t265_rpy.py example and merged that with parts of the cool project here https://github.com/thien94/vision_to_mavros/blob/master/scripts/t265_to_mavlink.py
I made some quick preliminary tests and the forward and downward results are pretty OK. There was also no need to tilt the cam a bit at start in order to stabilise the yaw.
Maybe you check the math? It was hacked in a rush, maybe there are issues. I could not get good results with the forwarddown setup.
The world reference frame is NED.
#!/usr/bin/python
# -*- coding: utf-8 -*-
## License: Apache 2.0. See LICENSE file in root directory.
## Copyright(c) 2019 Intel Corporation. All Rights Reserved.

#####################################################
##           librealsense T265 rpy example         ##
#####################################################

# First import the library
import pyrealsense2 as rs
import numpy as np
import transformations as tf
import math as m
import argparse
import textwrap

parser = argparse.ArgumentParser(prog='t256_rpy_test',
    formatter_class=argparse.RawDescriptionHelpFormatter,
    description=textwrap.dedent('''
description:
   Pose test
'''),
    epilog=textwrap.dedent('''
'''))
parser.add_argument("-o", "--orientation", type=str, choices=("forward", "down", "forwarddown"), default="forward", help="set start orientation")

args = parser.parse_args()

# From https://github.com/thien94/vision_to_mavros/blob/master/scripts/t265_to_mavlink.py
if args.orientation == 'forward':
    H_aeroRef_T265Ref = np.array([[0,0,-1,0],[1,0,0,0],[0,-1,0,0],[0,0,0,1]])
    H_T265body_aeroBody = np.linalg.inv(H_aeroRef_T265Ref)
else:
    if args.orientation == 'down':
        H_aeroRef_T265Ref = np.array([[0,0,-1,0],[1,0,0,0],[0,-1,0,0],[0,0,0,1]])
        H_T265body_aeroBody = np.array([[0,1,0,0],[1,0,0,0],[0,0,-1,0],[0,0,0,1]])
    else:
        if args.orientation == "forwarddown":
            H_aeroRef_T265Ref = np.array([[0,0,-1,0],[1,0,0,0],[0,-1,0,0],[0,0,0,1]])
            H_T265body_aeroBody = np.array(
                [[ 0.       ,  1.        ,  0.        ,  0.        ],
                [-0.70710676, -0.        , -0.70710676, -0.        ],
                [-0.70710676,  0.        ,  0.70710676,  0.        ],
                [ 0.        ,  0.        ,  0.        ,  1.        ]])

# Declare RealSense pipeline, encapsulating the actual device and sensors
pipe = rs.pipeline()

# Build config object and request pose data
cfg = rs.config()
cfg.enable_stream(rs.stream.pose)

# Start streaming with requested config
pipe.start(cfg)

try:
    while (True):
        # Wait for the next set of frames from the camera
        frames = pipe.wait_for_frames()

        # Fetch pose frame
        pose = frames.get_pose_frame()
        if pose:
            # Print some of the pose data to the terminal
            data = pose.get_pose_data()

            H_T265Ref_T265body = tf.quaternion_matrix([data.rotation.w, data.rotation.x,data.rotation.y,data.rotation.z]) # in transformations, Quaternions w+ix+jy+kz are represented as [w, x, y, z]!
            H_T265Ref_T265body[0][3] = data.translation.x
            H_T265Ref_T265body[1][3] = data.translation.y
            H_T265Ref_T265body[2][3] = data.translation.z

            # transform to aeronautic coordinates (body AND reference frame!)
            H_aeroRef_aeroBody = H_aeroRef_T265Ref.dot( H_T265Ref_T265body.dot( H_T265body_aeroBody ))

            rotation = np.array(tf.euler_from_matrix(H_aeroRef_aeroBody, 'sxyz'))
            translation = tf.translation_from_matrix(H_aeroRef_aeroBody)

            roll = rotation[0] * 180/m.pi
            pitch = rotation[1] * 180/m.pi
            yaw = rotation[2] * 180/m.pi
            x = translation[0]
            y = translation[1]
            z = translation[2]

            print("pitch: {0:5.2f}, roll: {1:5.2f}, yaw: {2:5.2f}       x: {3:5.2f}, y: {4:5.2f}, z: {5:5.2f}".format(roll, pitch, yaw, x, y, z))

finally:
    pipe.stop()

@dorodnic, please wait for feedback on these.

@radfordi, @dorodnic Sorry guys. You seem to wait for feedback but ignoring it the same time. Do I have to understand that? But maybe you mean "internal feedback", then of course I'm out here...

how to update to <IP_ADDRESS>1? I download the sdk2.34.0

You need to download the SDK, compile it, run Realsense Viewer or your application. Power cycle the cam. Somewhen you'll have it on the device.

程序

您需要下载，编译，运行Realsense Viewer或您的应用程序。重启凸轮。当您将其安装在设备上时。

yep,I did it all but not any shows could update my t265. tried 20times at last , have the same result.

向前，向后，向上和向下启动时，使初始偏航保持一致
修复间歇性描述符/ IMU损坏

@dorodnic，请等待这些反馈。

hi,how can I update t265 to <IP_ADDRESS>1 ??

Is there any way to update my t265。I already do what exactly you said，But it doesn't work.
------------------ Original ------------------
From: neilyoung<EMAIL_ADDRESS>Date: Sat,Apr 4,2020 8:07 PM
To: IntelRealSense/librealsense<EMAIL_ADDRESS>Cc: toolagu<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [IntelRealSense/librealsense] T265 Upgrade Firmware to <IP_ADDRESS>1 (#6176)
You need to download the SDK, compile it, run Realsense Viewer or your application. Power cycle the cam. Somewhen you'll have it on the device.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I had this also sometimes. This is if a previous installation has not been removed completely. You need to make sudo make uninstall from your build directory. Then start realsenseviewer If there is something, then you need to find it and remove it, since it has not been removed last time. Then make && sudo make install again. Once you have the proper realsenseviewer running, you will get the latest fw. BTW: Did you apply this PR? This needs to be done before compilation:
`git pull origin pull/6176/head``

有时我也有这个。这是以前的安装尚未完全删除的情况。您需要sudo make uninstall从构建目录中进行构建。然后开始realsenseviewer如果有东西，那么您需要找到它并删除它，因为上次它还没有被删除。然后make && sudo make install再说一次。一旦realsenseviewer运行正常，您将获得最新的固件。顺便说一句：您是否应用了此PR？这需要在编译之前完成：
git pull origin pull/6176/head

I use it on windows10, seems what you said is on linux

:) No git is git :)

:)没有git是git :)

I still can't understand how can I update my t265，I already do what exactly you say several times。And on the windows 10。It's nothing happen！Could you tell me have you update the lastest？And also you really on windows 10？What's step you have do?

@toolagu are you building from original repo or pulling code from @radfordi ‘s fork created for this PR? If you building off the official repo you will need to replicate updates to your copy

@toolagu are you building from original repo or pulling code from @radfordi ‘s fork created for this PR? If you building off the official repo you will need to replicate updates to your copy

no，I just download from
https://github.com/IntelRealSense/librealsense/releases/tag/v2.34.0
win10 64bit and install the .exe.
is this wrong?

This PR is not merged yet. You will need to download and make all utilities from below repo
https://github.com/radfordi/librealsense/tree/t265-release-951
Alternatively (if you are cloning master) you can update CMake and fw versions in your local copy, but then you still will need to rebuild all tools

This PR is not merged yet. You will need to download and make all utilities from below repo
https://github.com/radfordi/librealsense/tree/t265-release-951
Alternatively (if you are cloning master) you can update CMake and fw versions in your local copy, but then you still will need to rebuild all tools

I will try bro. Thank you for your patient！You are really gentleman！then，I'll let you know.

This PR is not merged yet. You will need to download and make all utilities from below repo
https://github.com/radfordi/librealsense/tree/t265-release-951
Alternatively (if you are cloning master) you can update CMake and fw versions in your local copy, but then you still will need to rebuild all tools

I downloaded the source code of the branch, but in win10 and tx2 （linux）can not compile, too many errors.Do you have such a problem?

You MUST NOT download the source code of the branch.
These are the general steps to be performed. A short look at the Windows instructions let me strongly recommend to not try to compile IR on Windows.
But if you have a Linux, then checkout the Linux instructions first. That should work fine.
One major step of the preparations is to clone the IR repository to your machine.
This is done via git:
git clone https://github.com/IntelRealSense/librealsense.git
The next step is usually to create a build directory in the cloned directory and call cmake with some parameters (check instructions). Before you are issuing make you need to apply this PR to the master branch.
git pull origin pull/6176/head
After that call `make && sudo make install``

You should not download the source code of the branch, however you did that and whatever you downloaded.
These are the general steps to be performed. A short look at the Windows instructions let me strongly recommend to not try to compile IR on Windows.
But if you have a Linux, then checkout the Linux instructions first. That should work fine.
One major step of the preparations is to clone the IR repository to your machine.
This is done via git:
git clone https://github.com/IntelRealSense/librealsense.git
The next step is usually to create a build directory in the cloned directory and call cmake with some parameters (check instructions) from there. Before you are issuing make you need to apply this PR to the master branch.
git pull origin pull/6176/head
After that call make && sudo make install and you'll have it.

Sorry I didn't make it clear that I was cloning the source code from the link you gave me, but I couldn't execute “git pull origin pull/6176/head”
A error is “fatal:Couldn't find remote ref pull/6176/head”
what happened？

I don't know, I don't know your setup. This is what happens here:
~/Documents/librealsense $ git pull origin pull/6176/head
From https://github.com/IntelRealSense/librealsense
 * branch                refs/pull/6176/head -> FETCH_HEAD
Already up to date.
~/Documents/librealsense $

This is OK, since the PR has already been applied.


Stop iterating over the globals when not checking leaks

Prerequisites

[x] Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
[x] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[x] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[x] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description
https://github.com/mochajs/mocha/blob/4860738af9de9493fade35aea3df65dc7461e100/browser-entry.js#L219
is causing chrome to show a 'window.webkitStorageInfo' is deprecated. warning.
To my understanding, iterating over the window properties is only for the check-leaks feature. Then with this feature disabled, there is no need to iterate that.
Thank you.
Steps to Reproduce
Run any mocha test in a recent Chrome.
Expected behavior: No access to every global variables.
Actual behavior: At least one access to each global variable.
Reproduces how often: Every time you run mocha.
Versions

The output of mocha --version and node node_modules/.bin/mocha --version: 9.1.0
The output of node --version: 14.17.0
Your browser and version (if running browser tests): Chrome Dev 94.0.4595.0 with Playwright

Additional Information

Yes, I have seen this warning window.webkitStorageInfo' is deprecated.
Blaming mocha/browser-entry.js and studying the listed PRs, I don't find any reasons for your check-leaks pretention.
Any help would be appreciated.
Are you bundling yourself, or do you use our browser bundle mocha.js or mocha-es2018.js?

I'm using playwright-test, you can consider it as bundling by myself. Sorry for the expressions, for check-leaks I mean the --check-leaks option. The reason I guess why Mocha iterates all the global vars is for this option.
Is it necessary to iterate the window props when there's no need to check their leaks?

If the --check-leaks option option is implemented in a totally unrelated way, then ignore my words on it. The file should directly export mocha without the Object.assign.

A quick dirty fix:
https://github.com/mochajs/mocha/blob/4860738af9de9493fade35aea3df65dc7461e100/browser-entry.js#L219
to
[
  'Mocha',
  'after',
  'afterEach',
  'before',
  'beforeEach',
  'context',
  'describe',
  'it',
  'mocha',
  'run',
  'setup',
  'specify',
  'suite',
  'suiteSetup',
  'suiteTeardown',
  'teardown',
  'test',
  'xcontext',
  'xdescribe',
  'xit',
  'xspecify'
].forEach(function(key) {
  mocha[key] = global[key];
});
module.exports = mocha;

probably related issue #4740


Add test for Map: mouseEventToLayerPoint

Fix #8380
added tests for mouseEventToLayerPoint:

for throwing error if Map is not set
for getting required co-ordinates when a mouseEvent occurs

Conflicts have been resolved! @jonkoops Please let me know if there's anything to add/resolve.

@jonkoops @kreloaded is this branch ready to merge?


performance.now() starts off with some large offset

Description
We ran into this issue over at Sentry when users of our React Native SDK reported varying offsets were being applied to their event timestamps: https://github.com/getsentry/sentry-react-native/issues/1004
We use the initial Date.now() at the start of the app, with the result from performance.now() added to it to get the current precise timestamp. We have since added a patch on our end to counter this offset by measuring the initial offset by performance.now() at the start of the app, and subtracting it from any subsequent calls to performance.now(): https://github.com/getsentry/sentry-javascript/pull/2915
So far from what we've seen, performance.now() otherwise is relatively accurate with the original offset factored out.
This issue occurs, from what we've tested, on both Android and iOS.
React Native version:
System:
    OS: macOS 11.0
    CPU: (8) x64 Intel(R) Xeon(R) CPU E5-1620 v2 @ 3.70GHz
    Memory: 1.25 GB / 12.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.18.4 - ~/.nvm/versions/node/v12.18.4/bin/node
    Yarn: 1.22.5 - ~/.nvm/versions/node/v12.18.4/bin/yarn
    npm: 6.14.6 - ~/.nvm/versions/node/v12.18.4/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: Not Found
  SDKs:
    iOS SDK:
      Platforms: iOS 14.0, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
    Android SDK:
      API Levels: 29, 30
      Build Tools: 28.0.3, 29.0.3, 30.0.2
      System Images: android-29 | Google Play Intel x86 Atom, android-30 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
    Xcode: 12.0/12A7209 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_265 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: 0.63.1 => 0.63.1
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Call performance.now() at a very early stage of the app, notice how there is some offset present.

Expected Results
Expect performance.now() to return the elapsed time from the start of the app.

It looks like performance.now(), for some reason, returns the time since boot
I had a device where I'll get a value like 534 444 000 on a device that was running for 5-6 days
I've rebooted it and now the values I get are around 600 000 10min.

performance.now() is a monotonic timestamp and should only be used for performance measurement (to measure timespans, not to be used as absolute units of time as Date.now()). This is also how this API works on Web, although the time origin is different (in RN, it's the device boot time, on Web it's the start of the navigation).
Sorry for the late reply. I came across with this issue looking for something else and realized it hadn't been answered.


[IA-4667] isLoadingCloudEnvironments flag passed with workspace wrapper

Consumers in the Analyses context know to wait to enable user action until load completes. Prevents bug where slow runtime load allowed users to create multiple runtimes.
Jira Ticket: https://broadworkbench.atlassian.net/browse/IA-4667

Summary of changes:

This is a quick fix; I added a flag isLoadingCloudEnvironments to the values supplied by useCloudEnvironmentPolling; if the flag is true the list requests are in progress. Consumers of wrapWorkspace can check the flag before allowing actions or displaying content associated with the loaded state: runtimes and disks.
I also moved initialization code for the Azure cloud environment modal into a useEffect, so that a slow load of runtimes would be picked up and the modal's state correctly shifted from Create (no runtimes) to Update (runtime exists already).
Affected components include GCP and Azure cloud env modals, the AnalysisLauncher, and the Analysis modal.
Next steps
A better approach would be to use the loadedState pattern which bakes knowledge of loading/errored/done into fetched data.
Testing strategy

[ ]

@mlilynolting can you look at the integration test failure?

@cahrens yep, it's failed on run-rstudio in a way we've seen before. I don't consider it a blocker, since I've seen this specific flake a lot. But I'll rerun as well!

This seems to either overlap or dovetail with the addition of a lastRefresh field to AnalysesData here. The purpose of that was to show a different type of screen for still-loading analyses data vs "loaded and empty".
Does this feel distinct in purpose, or can we combine the two fields into a single generic way of checking "did we load yet or is it just empty"? (I'm not too opinionated on which, but if they're implemented for the same reason we probably want to standardize on one or the other).

I see - I had only been looking for the loadedState pattern, and missed this. I think that there might be a way to use loadedState for this purpose, as is standard elsewhere in terra-ui, but I do think I could switch my implementation to rely on lastRefresh since it's already here. I will investigate!

I do think I could switch my implementation to rely on lastRefresh since it's already here. I will investigate!

I think we could also consider switching the lastRefresh over to loaded state if that is a more standard pattern in the UI. I just think we should probably pick either one or the other! I think the only time the lastRefresh is ever checked is for a loaded state check

@cjllanwarne I think this polling - for runtimes, disks, and apps - could be modeled with loadedState. But the design is more complex than I want to undertake in this bugfix. We need to handle:

Not loaded vs loaded once (initialized)
Error handling vs ignoring
Polling interval: fast or slow?
Loading state while polling after initialized: should we disable UI elements?
Triggering refresh: when "maybeStale," should we unset initialized to reflect the reduced confidence in the accuracy of our current state?
Triggering refresh: when not stale, should we load without altering loadedState, allowing consumers to access the previous state until the load completes and we can update it?

I'd love to put a small design doc together and run it by you, @msilva-broad , @cahrens , and the rest of the terra-ui team before going down the loadedState path here.
In the meantime, it seems as though the behavior of lastRefresh and isLoadingCloudEnvironments differs: my flag is true while the load is happening, whether it is the first call or not. lastRefresh seems to be used to determine whether the value has been loaded once. This behavior might be preferred (seems like it corresponds to design point 6 above).

@cjllanwarne I think this polling - for runtimes, disks, and apps - could be modeled with loadedState. But the design is more complex than I want to undertake in this bugfix. We need to handle:

Not loaded vs loaded once (initialized)
Error handling vs ignoring
Polling interval: fast or slow?
Loading state while polling after initialized: should we disable UI elements?
Triggering refresh: when "maybeStale," should we unset initialized to reflect the reduced confidence in the accuracy of our current state?
Triggering refresh: when not stale, should we load without altering loadedState, allowing consumers to access the previous state until the load completes and we can update it?

I'd love to put a small design doc together and run it by you, @msilva-broad , @cahrens , and the rest of the terra-ui team before going down the loadedState path here.
In the meantime, it seems as though the behavior of lastRefresh and isLoadingCloudEnvironments differs: my flag is true while the load is happening, whether it is the first call or not. lastRefresh seems to be used to determine whether the value has been loaded once. This behavior might be preferred (seems like it corresponds to design point 6 above).

LoadedState can handle the difference between initial 'Loading' and repeat 'Loading' states in that the initial 'Loading' true case will have state = null, and repeat 'Loading' cases will have state = lastGoodStateValue.  I am not weighing in on when this refactor may/should happen, just adding clarity on the design question.

In the meantime, it seems as though the behavior of lastRefresh and isLoadingCloudEnvironments differs: my flag is true while the load is happening, whether it is the first call or not. lastRefresh seems to be used to determine whether the value has been loaded once. This behavior might be preferred (seems like it corresponds to design point 6 above).

I like loadedState as the long term answer. Personally I'd be happy to live with some variation in these two pieces of state in the short term if it gets a bug fix over the line (and can remove my request for changes if you need me to)


:four_leaf_clover: Proposal: support SonarQube plugin

What Would You Like to Add? Why Is This Needed?

Static program analysis is an integral part of CICD to ensure code quality, SonarQube is one of the best and is heavily used by SMEs

We support GitHub Actions/GitLab CI/Jenkins for CI now; maybe we can integrate SonarQube for all of them. Care to create a PR for this one? @imxw

We support GitHub Actions/GitLab CI/Jenkins for CI now; maybe we can integrate SonarQube for all of them. Care to create a PR for this one? @imxw

Agree. I'll work on it later.


k8s: Routing via Express Route

I have a k8s cluster set up in Azure environment that has Express Route in place. I need to be able to communicate with the internal system via Express Route.
Kubernetes is deployed by using a default VNet template.
My POD can't reach the IP <IP_ADDRESS>.
If I try to reach just from normal VM, it works of course.
Is there some configuration required on the route table to facilitate the communication between PODs and "on-prem" resources?

@colemickens Have we got this working with express route. I know we have done things with VNET peering, but I don't know about express route.

Yes, per numerous other issues, the route table needs to be mirror, the non-masquerade-cidr flag needs to be updated, or there needs to be an iptable rule added. There are other issues about this.

We should document this.

Indeed would be good to have this documented.
Meanwhile, do you have any pointers on where this an iptable rule added should be done?
Do I need to configure kube-proxy on each node? Or there is a more straightforward way to do this on the running cluster?

Any Update on this. with what steps are needed. I have been looking at the same thing.

@colemickens would you advise us on the particular steps?


Add tests

Codecov Report

Merging #250 (1af42e3) into master (5ff7f23) will increase coverage by 2.70%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
+ Coverage     68.82%   71.53%   +2.70%
- Complexity      705      745      +40
============================================
  Files           114      114
  Lines          2377     2378       +1
  Branches        295      295
============================================
+ Hits           1636     1701      +65
+ Misses          595      534      -61
+ Partials        146      143       -3

Impacted Files
Coverage Δ
Complexity Δ

...in/java/seedu/address/logic/parser/ParserUtil.java
85.04% <ø> (+13.08%)
33.00 <0.00> (+4.00)

...ss/model/person/NameContainsKeywordsPredicate.java
100.00% <100.00%> (ø)
7.00 <0.00> (ø)

src/main/java/seedu/address/model/person/Room.java
71.87% <0.00%> (+9.37%)
19.00% <0.00%> (+4.00%)

.../seedu/address/logic/parser/FindCommandParser.java
91.66% <0.00%> (+27.77%)
14.00% <0.00%> (+4.00%)

...edu/address/model/person/RoomInBlockPredicate.java
100.00% <0.00%> (+28.57%)
6.00% <0.00%> (+3.00%)

...dress/model/person/RoomMatchesNumberPredicate.java
87.50% <0.00%> (+87.50%)
9.00% <0.00%> (+9.00%)

...edu/address/model/person/GenderMatchPredicate.java
100.00% <0.00%> (+100.00%)
6.00% <0.00%> (+6.00%)

...edu/address/model/person/RoomInFloorPredicate.java
100.00% <0.00%> (+100.00%)
9.00% <0.00%> (+9.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ff7f23...1af42e3. Read the comment docs.


invalid json response when running xpn-linux channels

When running the initial xpn-lunix channels command an error occurs:
invalid json response body at https://web-api-prod-obo.horizon.tv/oesp/v3/NL/nld/web/channels?sort=channelNumber reasoninvalid json response body at https://web-api-prod-obo.horizon.tv/oesp/v3/NL/nld/web/channels?sort=channelNumber reasoninvalid json response body at https://web-api-prod-obo.horizon.tv/oesp/v3/NL/nld/web/channels?sort=channelNumber reason
invalid: command not found
I think the problem is that when opening the URL i'll receive a warning:
You don't have permission to access "http://web-api-prod-obo.horizon.tv/oesp/v3/NL/nld/web/channels?" on this server.
Is i possible to fix this?

Hey @wiljanp82, I had not used my tool for a while and can confirm it is indeed permanently broken. I tried to fix this but it seems Ziggo changed the API in such a way that it is impossible to get the data out of it now. But I have some good news, the reason I build this in the first place was when plex removed support for The Netherlands. But it seems plex has restored this and you should be able to use the built-in epg data again.
Sorry for the inconvenience but I will archive this repo.


Move parts of AuthenticationHandler to Endpoint

Addresses #17615
The idea of this PR is to move part of the authentication handlers like callbacks and remote sign out to Endpoint.
The first draft is just adding a way which RemoteAuthenticationHandlers could provide their Endpoints.
cc @Tratcher

This needs an accepted design and architecture in the issue before a PR is offered.

@Kahbazi any progress on addressing feedback here? This is starting to go a little stale (though I realize the holidays may interfere somewhat ;)).

@anurse I'm waiting for the final decision on whether we need endpoints or just routing for authentication handlers. https://github.com/aspnet/AspNetCore/issues/17615#issuecomment-566688246
@Tratcher any update on the design for authentication handlers?

No update on the design, this isn't high on our priority list at the moment. We're still working out what we need to deliver on in the next release. After that we can see if this fits in or not.
Regardless, I recommend closing this PR for now. It will need significant changes based on the feedback and design discussion so far.

I think we're going to close this for now. Thanks for the first pass @Kahbazi , it really helped us in exploring the design. We need to do a little more design work on this though.


Add crate: rust-bert

Please add crate to category: NLP (Natural Language Processing)
This category doesn't exist yet

This has been filled in PR #78. If you would like to add a description to that category, I'd be happy to accept it!


Merge canary branch to master

This canary branch is where we've been syncing with the MDC 4.0.0 pre-release branch. See https://github.com/material-components/material-components-web-components/pull/481 for more background.
Part of https://github.com/material-components/material-components-web-components/issues/480
Note that we'll need to fix the following issues before we can do our next NPM release, or else we'll have some regressions:

https://github.com/material-components/material-components-web-components/issues/484
https://github.com/material-components/material-components-web-components/issues/485
https://github.com/material-components/material-components-web-components/issues/486

passes internally cl/271486436


[assistant] feature request : Use free groq API instead of openai

Is your feature request related to a problem? Please describe.
Groq API is free and it is a nice that way, you can choose a lot of model too
Describe the solution you'd like
Add the possibility to use another model, it can be groq, mistral, claude
Describe alternatives you've considered
Groq will be simple because it use the openai way

I have no desire to add support for alternative endpoints or models  with Assistant. It is also not as simple as you think it is to add support for that.


build: install tailwind

Describe your changes
Install Tailwind CSS for use in the IBF dashboard.
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added tests wherever relevant
[x] I have made sure that all automated checks pass before requesting a review

> test:api:all
> node --expose-gc node_modules/.bin/jest --config=jest.api.config.js --runInBand --detectOpenHandles --logHeapUsage

ts-jest[versions] (WARN) Version 4.9.5 of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=2.7.0 <4.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
 PASS  test/email/drought/email-uga-drought.test.ts (17.443s, 214 MB heap size)
  Should send an email for uga drought
    ✓ triggered in january (7291ms)
    ✓ non triggered any month (8319ms)

 PASS  test/email/floods/email-uga-floods.test.ts (33.934s, 215 MB heap size)
  Should send an email for uga floods
    ✓ default (8635ms)
    ✓ warning (8363ms)
    ✓ warning-to-trigger (8203ms)
    ✓ no-trigger (8111ms)

 PASS  test/email/floods/email-ssd-floods.test.ts (15.544s, 225 MB heap size)
  Should send an email for ssd floods
    ✓ default (7992ms)
    ✓ no-trigger (7274ms)

 PASS  test/email/flash-flood/email-mwi-flash-flood.test.ts (32.519s, 216 MB heap size)
  Should send an email for mwi flash flood
    ✓ default (8660ms)
    ✓ no-trigger (23583ms)

 PASS  test/email/malaria/email-eth-malaria.test.ts (16.868s, 226 MB heap size)
  Should send an email for eth malaria
    ✓ default (7592ms)
    ✓ no-trigger (9025ms)

 PASS  test/email/dengue/email-phl-dengue.test.ts (16.092s, 217 MB heap size)
  Should send an email for phl dengue
    ✓ default (8127ms)
    ✓ no-trigger (7666ms)

 PASS  test/email/typhoon/email-phl-typhoon.test.ts (13.082s, 225 MB heap size)
  Should send an email for phl typhoon
    ✓ default (12791ms)

Test Suites: 7 passed, 7 total
Tests:       15 passed, 15 total
Snapshots:   0 total
Time:        146.196s
Ran all test suites.


Change branch references to HEAD where possible or main otherwise

This updates CI, documentation, and similar to work with a main
branch. It also renames references to other repositories to work, as
well, which additionally makes it easier to search for remaining
references.
I verified that all modified links still work.

@bors r+

:pushpin: Commit 07f7c83349a5af80dcbb80ac6f2a8a12dbfdb97b has been approved by Amanieu
It is now in the queue for this repository.

:hourglass: Testing commit 07f7c83349a5af80dcbb80ac6f2a8a12dbfdb97b with merge 586541b97e047cfec540fad752bc1eaca4acac36...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: Amanieu
Pushing 586541b97e047cfec540fad752bc1eaca4acac36 to main...


[BUG] etcd restore after replacing node in single node cluster fails: states that replaced node does not have the snapshot stored locally

Rancher Server Setup

Rancher version: v2.7.9-rc2
Installation option (Docker install/Helm Chart):

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): rke2, 1.26.8+rke2r1, hardened

Proxy/Cert Details: valid certs

Information about the Cluster

Kubernetes version: tested with 1.26.9, 1.25.14
Cluster Type (Local/Downstream): downstream

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): tested with linode node driver

User Information

What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom)

If custom, define the set of permissions: standard user, cluster owner (also tested as admin user)

Describe the bug

if a user replaces a node in a single node setup, then restores using etcd snapshot restore (from before the node was replaced), the snapshot fails and the cluster stays in an updating state with an error message.
To Reproduce

deploy a single node cluster (tested with rke1)
wait for the cluster to get to active state -- observe snapshot is taken at time of creation
scale up the node pool so that the cluster doesn't break when the 1st node is removed

for rke1, scaling up to 2 nodes did not cause issues. But for rke2/k3s the scale must be to quarum, 3 nodes

wait for the scaled node(s) to become active
delete the original node
scale back down to 1 node
restore to the etcd snapshot created when the cluster first went to an active state

Result
snapshot restore fails with an error message like:
Failed to start backup server on all etcd nodes: [Failed to run backup server container, container logs: time="<time>" level=fatal msg="stat /backup/<snapshot_name>: no such file or directory" ]

note: checking files on the node do show that no such file exists.

On Rancher v2.7.9-rc2, deploy downstream RKE2 w/ 3 etcd, 2 cp, 3 wkr nodes => take snapshot => rotate etcd nodes => restore to snapshot taken before etcd node rotation:

fresh install of rancher v2.7.9-rc2
provision a downstream RKE2 AWS Node driver cluster w/ k8s v1.26.8+rke2r1 - [ 3 etcd, 2 cp, 3 wkr nodes]
Once active deploy a workload (i.e. jkeslar-stay)
Once workload is successfully deployed, take a local snapshot of the cluster
Once snapshot is active, deploy another workload (i.e. jkeslar-to-be-deleted)
Once workload is up and active, rotate all etcd nodes on the cluster, by scaling up the etcd nodes, then deleting the old nodes and ultimately scaling back down to 3 nodes
❗CONCERN❗- as the old etcd nodes are deleted from the cluster, the associated etcd snapshot for that node is also removed.  Unable to restore to a local etcd snapshot post-rotation, as no local snapshots are available anymore

After further analysis and discussion offline:

this is only an issue for rke1. It seems that there is significant delay in the removed (local) snapshots being removed from rancher UI when a etcd node is deleted / replaced
this would appear to be a distro team ticket

a workaround to get the cluster out of this state would be nice to add to this ticket at time of triage.
Suggested fix would be to:

add some event-based triggers (or update them to include deleting a node, if there is already some logic for this) to update the config map


Fix/tracking

Added option to correctly fetch stats for tracking of players which were lacking before, it was only available for speed.

Hey everyone, I created this Pull request, I'm wondering if anyone took a look at this, because I don't know what's the problem with this PR.
I hope that it could get merged, since I believe it could be of a good use in current package, as Tracking stats are quite valuable.


Fix typo in android-sdk caveats

"contol" -> "control"
After making all changes to the cask:

[ ] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Thank you.


bump chainlink env to fix nodes < tests bug for concurrent envs run

Codecov Report

Merging #369 (35787e6) into main (08f4f95) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   28.86%   28.86%
=======================================
  Files          14       14
  Lines        1618     1618
=======================================
  Hits          467      467
  Misses       1113     1113
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f4f95...35787e6. Read the comment docs.


[Feature] can apm-trace-ignore-plugin support non http url ?

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
use apm-trace-ignore-plugin and config trace.ignore_path=GET:/sw/xxx/,*/close,/close
curl http://<IP_ADDRESS>:8090/sw/xxx/ff ,sw did not trace it , ignore_path take effect,
but if service access mysql, the endpoint "Druid/Connection/close" still traced,
is apm-trace-ignore-plugin only support path for http url ?
Use case
apm-trace-ignore-plugin support non http url,
for example , endpoint like package/classname/method which has no useful can be ignore by agent
Related issues
no
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Tests are there, if you want to submit discussion, go ahead.
The issue panel is not about this.


basic_debuginfo.c started to fail

Started to fail from 75e33f71c2da (upstream)
******************** TEST 'LLVM regression suite :: basic_debuginfo.c' FAILED ********************
Script:
--
: 'RUN: at line 4';   /usr/bin/clang-14 -g3 /check/tests/basic_debuginfo.c -o /check/build/tests/Output/basic_debuginfo.c.tmp && objdump -g --dwarf-check /check/build/tests/Output/basic_debuginfo.c.tmp | grep -E 'DWARF Version:\s*4'
--
Exit Code: 1

Command Output (stderr):
--
objdump: Warning: Unrecognized form: 37
objdump: Warning: Unrecognized form: 37
objdump: Warning: Unrecognized form: 37
objdump: Warning: Unrecognized form: 27
objdump: Warning: DIE at offset 0x1f refers to abbreviation number 8 which does not exist
objdump: Warning: Unrecognized form: 37
objdump: Warning: Unrecognized form: 37
objdump: Warning: Unrecognized form: 37
objdump: Warning: Unsupported form (DW_FORM_strx1) for attribute DW_AT_comp_dir
objdump: Warning: Unrecognized form: 27
objdump: Warning: DIE at offset 0x1f refers to abbreviation number 8 which does not exist
objdump: Warning: Unable to load/parse the .debug_info section, so cannot interpret the .debug_addr section.

we can see it here:
https://github.com/opencollab/llvm-toolchain-integration-test-suite/runs/4931278110?check_suite_focus=true


[stable/spark] -deployment file add resource limits

Is this a request for help?:
NO
Is this a BUG REPORT or FEATURE REQUEST? (choose one):

Version of Helm and Kubernetes:
Which chart:
spark
What happened:
There is no resource limits
What you expected to happen:
Add resource limits to CPU and Memory
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know:

@lachie83


rename "uuid" field to "id"

Implemented in https://github.com/zakodium/nmrium-cli/pull/8/commits/271b2eca8d3276fc01f4a6457dabda1eec18c5bc#diff-4a60fd3f25918fd409ef49402ba2ebf5c7e1a506ed29031f5340f38fd457cd34R25-R30


Usbmaster

Merge attempt two

Merged the usb branch back into master. Will leave the PS2 code there for now, but it is essentially history.


Introduce hardware DB querying with udev::hwdb

First of all, thanks for these bindings!

This adds support for udev's "hwdb" (hardware database) APIs. It
introduces the hwdb module and Hwdb structure for querying the
hardware database using modaliases.
Additionally, the list module is introduced. list contains a
generic wrapper for udev's udev_list_entry and is used by
hwdb::Hwdbto return query results.
Other APIs that currently use their own specialized wrappers for
udev_list_entry can be rewritten to use list::List, although this
changeset doesn't do so to minimize churn.

Gentle ping -- let me know if there's anything I can do 🙂

Gentle ping -- let me know if there's anything I can do slightly_smiling_face

Thanks for the ping, totally forgot over the holidays!
Just one minor change, the rest looks fine. Thanks for the PR!

Gentle ping -- let me know if there's anything I can do slightly_smiling_face

Thanks for the ping, totally forgot over the holidays!
Just one minor change, the rest looks fine. Thanks for the PR!

No problem, and thank you for the review! Apologies for the holiday disturbance.

No problem, and thank you for the review! Apologies for the holiday disturbance.

Apologies for the holiday disturbance.
No worries!

Merged and published as 0.5.1.
If you want to update the other apis to use list::List as well for a future v0.6.0, I would be happy to review them.

Apologies for the holiday disturbance.
No worries!

Merged and published as 0.5.1.
If you want to update the other apis to use list::List as well for a future v0.6.0, I would be happy to review them.

Thanks!
And yeah, I'll issue a follow-up PR for moving the other APIs to list::List.

Thanks!
And yeah, I'll issue a follow-up PR for moving the other APIs to list::List.


Element class creator tagging method.

I think this PR is best explained by an example.  I do not think the code is good enough to actually accept the PR at this time, but I want feedback on whether this kind of modification is reasonable or could be accepted if polished.
SERVICE = "service-name"

@rpc()
def setup(root, log, **kwargs):
    rootcfg = root.get_root()
    rootcfg.set_creator(f"{SERVICE}[service-name='{kwargs['instance']}']")
    rootcfg = functionA(rootcfg)
    return root

# Main only gets called when debugging from shell
def main():
    clx = Clixon(source="running",target="candidate")
    rootcfg = clx.get_root()
    rootcfg.set_creator(f"{SERVICE}[service-name='mesh1']")
    functionA(rootcfg)

def functionA(config):
	config_branch = get_path(config,"config_branch")
	functionB(config_branch)

def functionB(config_branch):
	new_key = config_branch.create('new-key')

	# At this point multiple-function calls in, we don't have the context of the instance anymore,
	# so it either requres passing it through every function call, defining global vars,
	# or just using a class variable to store that context so it can be retrieved by a new method.
	new_key.tag_creator()

if __name__ == "__main__":
    main()

Yesterday when I fixed the PR the first thing I realized was it would probably be better to have the set_creator method do the string formatting to make it cleaner.  However, when I wrote it, I didn't fully understand what kinds of other attributes a person might want to apply when making this call.  I figured this was a way to not box anyone out, they can feed any data in they want in case I overlooked something. I originally didn't expect to commit it, I thought I could find a way to augment the class at runtime later, but turns out that is harder than I thought.
I didn't check if it works for editing the service config, I've been using it for editing remote system configs.  However, since it is a global variable in the Element class, as long as the tag is valid, it will work anywhere you are editing XML.
I will look at the docs again with regards to attributes and then look at the formatting again, it may be a more proper solution to write something that can understand all of the XML properties required by the service API and allows a user to selectively apply them, possibly allow setting the default tag for the method if no arguments are passed or something similar to keep the simple approach.

Please add unit tests covering the added functionality.

I think the approach to make it a function to apply all the attributes could be good. At present, these are the attributes used in my service code:

"cl:creator": As the ticket already discusses,
"nc:operation": replace/merge strategy for config application,
"xmlns:cl": clixon xmlns - I think this is mostly static,
"xmlns": Vendor xmlns - this one is tricky and will introduce complications once we have multivendor.


Invalidate client side cookie with token service

Just wanted to clarify my knowledge and ensure there wasn't a configuration piece I was missing.
Upon successful sign-in the browser is issued idsrv.session and .AspNetCore.Cookies cookies which allowed repeated access to the /connect/authorize endpoint to be handled without having to login again (unless prompt=login param is found)
When the end user browses to /connect/endsession these 2 cookies are cleared up, however it appears as if these cookies are entirely self-contained with no server side representation of them to allow server side invalidation. Result is that if they were to be compromised that they could be used in a replay attack to reissue tokens.
Is there any kind of configuration that I am missing or risk mitigation I can implement to reduce this problem?

You can configure the cookie handler in ASP.NET Core to store a server-side representation of them (via ITicketStore SessionStore on the cookie options). That's an ASP.NET Core feature, so check the Microsoft docs.

Cheers for the direction.


Implementing testExistsRelationshipWhereClauseParsing test

Hi, @hanneskaeufler, can you verify if my implementation is correct?

Coverage increased (+1.4%) to 100.0% when pulling c35193bc74bb587661dfab2a4c79a2effe10bb36 on brunorsantos:testExistsRelationshipWhereClauseParsing into 2b3f63ac5fed1e5611db482feae59b2c5e793d34 on GeneaLabs:master.

@brunorsantos No worries, I'll take a look and see if anything needs to be changed. Thanks for contributing!


Broken link to method overload

This page represents both overloads of the CreateCopyFromSurfaceAsync method. In the section for the first overload there's a link to the second that doesn't work: CreateCopyFromSurfaceAsync(IDirect3DSurface, BitmapAlphaMode).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a9e2556b-7368-562c-db41-9392788dfaec
Version Independent ID: 78c5bdb4-19d0-e93a-9a6d-f728209e29ad
Content: SoftwareBitmap.CreateCopyFromSurfaceAsync Method (Windows.Graphics.Imaging) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.graphics.imaging.softwarebitmap.yml&version=GBlive&_a=contents
Product: uwp
Technology: winrt-reference
Git Login: drewbatgit
Microsoft Alias: drewbat

Thank you for the feedback. This link has been fixed.


Fix curl creating download dir in 750 mode

This suggests to fix the download directory being created with 750 mode on unix like systems.
Currently, the downloads directory is not readable by other users. This is inconvenient, e.g., for debugging CI systems, when the build directory is not fully readable. Further, this is an inconsistency to all other directories created by vcpkg (buildtrees, packages, installed, ...). All other directories are created with the default mkdir mode.
I traced the problem down to curl being used with the --create-dirs option to create all download directories. Curl always uses mode 750 to create directories as written in the docs.
This PR fixes the problem by creating the download directory in advance. I found an other usage of --create-dirs in the bulk download code: https://github.com/microsoft/vcpkg-tool/blob/2024-06-10/src/vcpkg/base/downloads.cpp#L481
But it seems file system access is not already available there, so maybe waiting for feedback if that solution is valid at all before trying to fix this there.

directory being created with 750 mode on unix like systems.

This seems surprising given that there is umask. That curl code is at least 13 years old. I wonder if it is intentional.

This seems surprising given that there is umask. That curl code is at least 13 years old. I wonder if it is intentional.

It seems intentional as it was documented resulting from this discussion: https://github.com/curl/curl/issues/4766
In that discussion it was also mentioned that umask is respected. Only 750 is used as default before applying umask.

Hm, this discussion isn't entirely neutral...
The point isn't that umask isn't applied. The point is that curl starts with a more restrictive mode than expected (from common practice), and this is surprising. The world part of umask is rendered useless. Users must explicit call chmod to relax  world restrictions.
(One might see this is as a security feature... but calling chmod is a security trap: No umask applied. Easy to make things world writable.)

a more restrictive mode than expected (from common practice), and this is surprising.

That is exactly the point for this PR. We probably have the same opinion on this.
I think its strange that the download folder has not default folder permission applied compared to a mkdir call on that system. The curl discussion likely was not optimal especially from the request side. However, it was made clear from curl that 750 is the intended behaviour. Therefore, it may be fixed in vcpkg.
I also do not like to play around with file permissions after the curl call, especially as you may need to track what part of the path existed before and which folders are newly created. Thats why I'm suggesting to just create the folders in advance here.


Availability of the OpenAI /v1/completions API Endpoint ?

Hello,
I noticed in the code examples that the OpenAI completions endpoint is implemented. Could you inform me when it will be available via the API ?
As of today, the Swagger documentation shows "v1/chat/completions" but not "v1/completions," and attempts to access the latter result in a 404 error page.
Thank you for your efforts, and keep up the good work!
Valere

Ye I can port the implementation over.

+1 for v1/completions support

supported by openllm v0.6.


Unclear usage description

I struggled following the usage instruction. As soon I create a github.md file it tells me
404 - Template "modular/github.html.twig" is not defined.

Can you please provide an example directory structure and content how to use the example you've provided?
Thank you in advance.

The plugin activates only if github: true is found in the page header.
It does not provide a modular, but a partial that you can include in another Twig template: https://github.com/getgrav/grav-plugin-github/tree/develop/templates/partials
For example, add a github.html.twig into your theme templates folder, and call {% include 'partials/github.html.twig' %}.

@flaviocopes I got it to work, thank you for your additional explanation, helped me. Sorry for the noob questions :) 🍺


auto-hide nav_bar when table view search is focused

Needs discussion about possible unintended consequences before merge.

https://github.com/clearsightstudio/ProMotion/issues/624#issuecomment-76418327
Tapping on a cell does not dismiss the search, and as such does not animate the nav_bar back into place. We'll either need to call will_end_search for the user or document the suggested way for them to do it manually.

Holding off on merging this one for now. Sounds like there are some edge cases. Ref #624.


SUSE sysvinit support

What does this PR do?
Add SysVInit scripts for the SUSE Agent package.
[Hack] On SUSE 12+, these scripts are removed right after the package is installed, as on later systems (and in particular SUSE 15), the presence of these scripts make the systemctl enable step fail.
Motivation
Support SysVInit on SUSE 11.
Additional Notes
Not ready yet. Kitchen tests pass, but we don't have tests for SUSE 11.

Missing changelog.

I reverted the addition of kitchen tests, because they'll require rewriting the tests to use service instead of systemctl, which will be a big change I'd rather do in a separate PR. If this looks good to you @albertvaka, we can merge.


Adds regex to retry errors when backend initialization fails

Adds regex to retry errors when backend initialization fails
Fixes #2305
TODOs
Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added regex to retry errors when backend initialization fails.

Thanks for submitting a PR! I'm not sure why this case should be in the default retries, though. Specially since, as you mentioned in your issue, you could resolve it by using a custom config. Have you tested what will happen when there's an actual credential error instead of the occasional rate-limiting problem?

Hey @lorengordon ,
I'm closing this PR out as it has gone stale. It's not desirable to delay the error that a user would get when their credentials are in-fact valid by default. Terragrunt should try to exit as quickly as possible in those cases unless a user decides to opt-in to a workaround like this.

It's unfortunate that the error message is so wildly incorrect. 😢