provide way to disable crds and rename centralIstiod flag

rename flag centralIstiod as externalIstiod to align with our doc
add a new flag 'base.enableCRDsto make crds and istiod sa disabled for remote cluster when we are underexternalIstiod` mode.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
8f39204223ed077ad877ec17d96c8d1c22998757
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
47f54c3cfff9cf1ec48e9bc41239efa30b7a4a18
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
47f54c3cfff9cf1ec48e9bc41239efa30b7a4a18
link
/test gencheck_istio

integ-operator-controller-tests_istio
47f54c3cfff9cf1ec48e9bc41239efa30b7a4a18
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj Love the externalIstiod name. Can you please link to the issue in this PR? Also, I think changing the name centralIstiod to externalIstiod is user facing. Can you please add a release note?

@irisdingbj Love the externalIstiod name. Can you please link to the issue in this PR? Also, I think changing the name centralIstiod to externalIstiod is user facing. Can you please add a release note?

Sure @brian-avery

/test integ-operator-controller-tests_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

we already have a remote chart, would it be simpler to just copy the roles we need over there? seems consistent at least

I'm in favor of adding the new flag for CRDs.  Not entirely sure how the roles relates to the CRDs tho.

I am not that against a flag for CRDs but why did we make a new chart just for this case and then decide to do something different for the roles? If we are inconsistent we should have a good reason

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

gencheck_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

gencheck_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test gencheck_istio

unit-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

gencheck_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test gencheck_istio

unit-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

gencheck_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test gencheck_istio

unit-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

gencheck_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test gencheck_istio

unit-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The reason we do not want  to copy things into a new componet is it is easy to just use flags to enable/disable  in base. and will make the sync work less.
One thing is the flag will control sa, and also crds. So we can make minimum things install in remote cluster.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

gencheck_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test gencheck_istio

unit-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

gencheck_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test gencheck_istio

unit-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-pilot-k8s-tests_istio

integ-multicluster-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
80755749c698384df925154dd195d67cbd0e818c
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-operator-controller-tests_istio
b0ea77ed97478c44fc8b28ce0eb044912fca33ea
link
/test integ-operator-controller-tests_istio

integ-distroless-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
b489e7952e0975d80929dba484d7e4d538c63fa4
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
80755749c698384df925154dd195d67cbd0e818c
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
80755749c698384df925154dd195d67cbd0e818c
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The reason we do not want to copy things into a new componet is it is easy to just use flags to enable/disable in base. and will make the sync work less.

Then we shouldn't have the istio-remote chart?
I don't really care what we chose, as long as we don't chose to do half copying and half enable/disable flags...

/test release-notes_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
f5f73c7fc210e985d15907951a0bcb891308d4ac
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
f9fc559d6792092363805e7b4c37adae3c574d29
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @irisdingbj even if the CRDs are copied into the istiod-remote component, I think we still need a flag to enable it...   Config cluster/Remote cluster will need it while remote cluster doesn't.

Also, some background on istiod-remote component.  It was created to host istiod remote component, not the base remote component.  We could certainly expand it to cover base but it was not the initial intention.

@irisdingbj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn a Ping on this..

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
11d73ddb5a6b89bcbb8453990adbdbc50b481950
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
11d73ddb5a6b89bcbb8453990adbdbc50b481950
link
/test lint_istio

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-test_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-test_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-test_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-test_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-test_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-test_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-test_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-security-k8s-tests_istio

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-test_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

release-test_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-test_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test gencheck_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-distroless-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-distroless-k8s-tests_istio

integ-telemetry-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test gencheck_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-multicluster-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test gencheck_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

unit-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test unit-tests_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test gencheck_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

analyze-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test gencheck_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-pilot-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test gencheck_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test unit-tests_istio

analyze-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test gencheck_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test unit-tests_istio

analyze-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

gencheck_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test gencheck_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test unit-tests_istio

analyze-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test unit-tests_istio

analyze-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-operator-controller-tests_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test integ-operator-controller-tests_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test unit-tests_istio

analyze-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test lint_istio

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test unit-tests_istio

analyze-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
aaa11064a75c41c6d1a313cb6ebfcaf031da9a0e
link
/test release-notes_istio

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test unit-tests_istio

analyze-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-operator-controller-tests_istio

lint_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-security-k8s-tests_istio

release-test_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-test_istio

integ-distroless-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-distroless-k8s-tests_istio

integ-multicluster-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test unit-tests_istio

analyze-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test analyze-tests_istio

integ-pilot-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-telemetry-k8s-tests_istio

gencheck_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test gencheck_istio

integ-ipv6-k8s-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-ipv6-k8s-tests_istio

integ-operator-controller-tests_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test integ-operator-controller-tests_istio

lint_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test lint_istio

release-notes_istio
1f9805b596cb4246b3183c9b7faca4ce4ca0cf4e
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
d75ab92d031ebe43f1962181a21e1467cd0c8038
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn  now we are allowing centralIstiod and externalIstiod to support backward compatibility. Meanwhile make crd-all-gen.yaml under templates to allow flag in it.  PTAL, thanks.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
bbb2e1b7e7993cd4f6c6bd840da20dd63bd0fac5
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn looking through the changes for base/templates/crds.yaml and found out it is used to support helm2 https://github.com/istio/istio/pull/23413.
Now since we have moved it into templates, we can now remove it from base/templates/crds.yaml this will make original helm2 support still valid.

The crd must be in the crd folded to support helm 3.
On Thu, Sep 24, 2020, 9:40 PM Iris<EMAIL_ADDRESS>wrote:

@howardjohn https://github.com/howardjohn looking through the changes
for base/templates/crds.yaml and found out it is used to support helm2
#23413 https://github.com/istio/istio/pull/23413.
Now since we have moved it into templates, we can now remove it from
base/templates/crds.yaml this will make original helm2 support still valid.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/27115#issuecomment-698715932, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXLRMAYK7PDEBVQEZN3SHQNLTANCNFSM4Q7ITAAQ
.

The crd must be in the crd folded to support helm 3.
reading through helm3 docs

files under crd/ do not allow template
put files under crd/ is to make sure crd is ready before other resources in the chart start to use it.

In our base charts, we have no reference to these crds so this makes #2 useless. Also due to #1,  there is no way to use flag  to control whether we will install crd or not unless we make changes into helm.go like previous solution in this PR.
Base on above, I think we are safe with current fix in the PR( move crd-all.gen.yaml under templates).
@howardjohn WDTY?

See https://github.com/istio/istio/pull/23192 and the linked issue. The
CRDs MUST be in crds/ or helm3 install and helm3 upgrade will not
behave as expected. It is not just to ensure they are ready prior to use.
On Sat, Sep 26, 2020 at 6:45 PM Iris<EMAIL_ADDRESS>wrote:

The crd must be in the crd folded to support helm 3.
reading through helm3 docs

files under crd/ do not allow template
put files under crd/ is to make sure crd is ready before other
resources in the chart start to use it.

In our base charts, we have no reference to these crds so this makes #2
https://github.com/istio/istio/issues/2 useless. Also due to #1
https://github.com/istio/istio/pull/1, there is no way to use flag to
control whether we will install crd or not unless we make changes into
helm.go like previous solution in this PR.
Base on above, I think we are safe with current fix in the PR( move
crd-all.gen.yaml under templates).
@howardjohn https://github.com/howardjohn WDTY?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/27115#issuecomment-699571575, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEYGXJZDS7QP52ZABURZE3SH2KMDANCNFSM4Q7ITAAQ
.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
4d035b10df2d8d93d994e9182f9075247c1a0a01
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn I remove disalbe crds from this PR. So now this only includes changes for externalIstiod and we have kept backward compatibility.
Let's use https://github.com/istio/istio/issues/27609 to discuss the possible solutions for disable crds  in base.

/test lint_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
d08f2a22eef9367878a550edf52123b236e04fbb
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
d08f2a22eef9367878a550edf52123b236e04fbb
link
/test lint_istio

gencheck_istio
d08f2a22eef9367878a550edf52123b236e04fbb
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn added deprecated message, PTAL. thanks!

@irisdingbj this LG!  Just had a few minor comments.
@howardjohn PTAL - think your concern is addressed now!

@irisdingbj can you open an issue to remove centralIstiod flag in 1.9?

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
2294ac32b85f655a870c173f6c79b2f332c2e56f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@linsun @howardjohn PTAL, thanks.

add a new flag 'base.enableCRDsto make crds and istiod sa disabled for remote cluster when we are underexternalIstiod` mode.

It seems this is outdated, can you remove it?

add a new flag 'base.enableCRDsto make crds and istiod sa disabled for remote cluster when we are underexternalIstiod` mode.

It seems this is outdated, can you remove it?

done

@howardjohn could you kindly remove your reject?  Thanks.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
2294ac32b85f655a870c173f6c79b2f332c2e56f
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

good catch @howardjohn, i agree with that.  Sorry i didn't see that comment earlier, I had thought you main objection was renaming centralIstiod to externalIstiod which @irisdingbj did address.

/hold
@irisdingbj please feel free to remove the hold when you have addressed @howardjohn's https://github.com/istio/istio/pull/27115#pullrequestreview-506692773. Thanks!

I did not remove my hold because my comment was not addressed. There should be a deprecation warning added to
https://github.com/istio/istio/blob/e4e3ffea4b1fb6b6ae0ececf242dd389dd2d7f5d/operator/pkg/apis/istio/v1alpha1/validation/validation.go#L116
.
Can you add this in a followup?

thanks for this pointer, I updated this PR to address this

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
2294ac32b85f655a870c173f6c79b2f332c2e56f
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
918e28ae6807b6bba1c729d894732e446036e6cd
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
918e28ae6807b6bba1c729d894732e446036e6cd
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio

@howardjohn I have updated in this PR to add a deprecation warning into validation.go to address your comments. I will remove the on hold to let this PR in. Please let me know if any other things need to address and I will work on in follow up PRs. Thanks!


screen cropped at any given resolution

as the title, it doesnt matter what resolution i use on Genshin, every screen taken will be cropped like this

Please check out issue #40 if you have ultrawide capabilities.


On publish failures, log error and count them as sys exceptions

Motivation
When a user explicit publish fails, we fail in silence currently. This pr fixes that by logging it as well as treating it as a system failure. In python, we already do the same, so this brings both languages to the same behaviour.
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?


feat: minor design fixes in nutrition_page_loaded.dart

What

feat: minor design fixes in nutrition_page_loaded.dart
feat: use appbar button actions in nutrition_page_loaded.dart

Codecov Report

Merging #1475 (ed60aa7) into develop (721a49b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #1475      +/-   ##
==========================================
- Coverage     9.15%   9.14%   -0.02%
==========================================
  Files          158     158
  Lines         6354    6367      +13
==========================================
  Hits           582     582
- Misses        5772    5785      +13

Impacted Files
Coverage Δ

...h_app/lib/pages/product/nutrition_page_loaded.dart
0.00% <0.00%> (ø)

.../smooth_app/lib/pages/onboarding/welcome_page.dart
3.44% <0.00%> (ø)

...s/knowledge_panels/knowledge_panel_title_card.dart
0.00% <0.00%> (ø)

...knowledge_panels/knowledge_panel_element_card.dart
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 721a49b...ed60aa7. Read the comment docs.

Fixed some conflicts @VaiTon


Added advanced mode

/claim #282

adds a checkbox to the main_panel title bar
adds is_advanced boolean to the block_definition (default value is false)
hides advanced blocks when the checkbox is not ticked.

Thanks for the review @manuq, I setup pre-commit which fixed the linter errors and also fixed the bug where adding a new Variable removed the advanced blocks.

Thanks for the help @manuq, I squashed the commits and provided a more detailed commit message so it should be ready to merge now.

Thanks for the help @manuq, I squashed the commits and provided a more detailed commit message so it should be ready to merge now.

Thanks for your contribution! The commit message is very good now.


[Jenkins] Add build stages

Description

Added a new kind stage
Added a new blueprint jenkinsStage

Implementation
Utilized the Jenkins API provided by the pipeline-stage-view-plugin to retrieve pipeline stage information.
The API returns details such as stage IDs, names, statuses, start times, durations, and links to each stage, as shown in the example JSON response below:
{
    "_links": {
        "self": {
            "href": "/job/Phalbert/job/airframe-react/job/master/29/wfapi/describe"
        }
    },
    "id": "29",
    "name": "#29",
    "status": "FAILED",
    "startTimeMillis":<PHONE_NUMBER>870,
    "endTimeMillis":<PHONE_NUMBER>780,
    "durationMillis": 1202910,
    "queueDurationMillis": 5,
    "pauseDurationMillis": 0,
    "stages": [
        {
            "_links": {
                "self": {
                    "href": "/job/Phalbert/job/airframe-react/job/master/29/execution/node/6/wfapi/describe"
                }
            },
            "id": "6",
            "name": "Declarative: Checkout SCM",
            "execNode": "",
            "status": "SUCCESS",
            "startTimeMillis":<PHONE_NUMBER>791,
            "durationMillis": 892,
            "pauseDurationMillis": 0
        },
        {
            "_links": {
                "self": {
                    "href": "/job/Phalbert/job/airframe-react/job/master/29/execution/node/17/wfapi/describe"
                }
            },
            "id": "17",
            "name": "Declarative: Post Actions",
            "execNode": "",
            "status": "SUCCESS",
            "startTimeMillis":<PHONE_NUMBER>739,
            "durationMillis": 24,
            "pauseDurationMillis": 0
        }
    ]
}

Additional Context: For more details and ongoing discussion, please refer to the linked Slack thread: Jira Task Discussion.
Type of change
Please leave one option from the following and delete the rest:

[x] New feature (non-breaking change which adds functionality)

 All tests should be run against the port production environment(using a testing org).
Core testing checklist

[ ] Integration able to create all default resources from scratch
[ ] Resync finishes successfully
[ ] Resync able to create entities
[ ] Resync able to update entities
[ ] Resync able to detect and delete entities
[ ] Scheduled resync able to abort existing resync and start a new one
[ ] Tested with at least 2 integrations from scratch
[ ] Tested with Kafka and Polling event listeners

Integration testing checklist

[x] Integration able to create all default resources from scratch
[x] Resync able to create entities
[x] Resync able to update entities
[x] Resync able to detect and delete entities
[x] Resync finishes successfully
[x] If new resource kind is added or updated in the integration, add example raw data, mapping and expected result to the examples folder in the integration directory.
[x] If resource kind is updated, run the integration with the example data and check if the expected result is achieved
[x] If new resource kind is added or updated, validate that live-events for that resource are working as expected
[x] Docs PR link here

Preflight checklist

[x] Handled rate limiting
[x] Handled pagination
[x] Implemented the code in async
[ ] Support Multi account

Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.

@Tankilevitch this is now ready


Lquery aggregate functions doesn't have proper types in luna

What is "proper" type? What behavior do you expect here?

AggregateFunction type since nothing else will work

I don't think this is something specific to the rolling function (or Dataframes in general). Nor something we are able to fix. Luna would need to allow explicit type annotations first.


Maximum call stack size exceeded when i pass the children node

import { isEqualReactSimple } from '@react-hookz/deep-equal';
import { memo } from 'react';

const AppLink = memo(
  (props) => {
    return (
      <a
        {...props}
    );
  },
  isEqualReactSimple,
);

export default AppLink;

it will
Uncaught RangeError: Maximum call stack size exceeded
    at Function.isView (<anonymous>)
    at isEqual (index.js:25:1)
    at compareObjects (comparators.js:59:1)
    at isEqual (index.js:32:1)
    at compareObjects (comparators.js:59:1)
    at isEqual (index.js:32:1)
    at compareObjects (comparators.js:59:1)
    at isEqual (index.js:32:1)
    at compareObjects (comparators.js:59:1)
    at isEqual (index.js:32:1)

when change to isEqualReact/isEqual same errors
when i remove isEqualReactSimple , it works
when i change to react-fast-compare/fast-deep-equal, it works

As far as I can understand you're having react component passed via props?

As far as I can understand you're having react component passed via props?

Yes, I have pass some ReactNode through props, or use children to include them.

:tada: This issue has been resolved in version 2.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support for Installing Multiple Infrastructures in Helm Chart (GCP and AWS) with Tutorial

User Story
As a developer, I would like to install multiple infrastructures using Helm charts for better management and deployment consistency across GCP and AWS.
Detailed Description
I would like to request the feature to support installing multiple infrastructures (e.g., GCP and AWS) using Helm charts. This could be implemented either by enhancing a single Helm chart to handle multiple providers or by providing separate Helm charts for each provider. Additionally, a comprehensive tutorial on how to configure and deploy these Helm charts for multi-cloud environments would be highly beneficial. This tutorial should cover the necessary steps, configurations, and best practices for managing infrastructure components across GCP and AWS.
Anything else you would like to add:
This feature and accompanying tutorial would greatly benefit users who manage multi-cloud environments, ensuring a unified and streamlined process for infrastructure deployment. It would also reduce the complexity of maintaining separate Helm charts for each provider, providing clear guidance on how to achieve this setup.
/kind feature

/remove-lifecycle stale

/remove-lifecycle stale


Implementing country_cases function

The function country_cases contained in the file main.py should be able to receive a list of countries, and not only a single country.

Implemented this functionality here https://github.com/scalabrindario/Covid-19/commit/4a85c1ed8d4f069e0afea9cfee67cebeac6af5d7


Invalid credentials

When first configuring the component through the UI, I get the error "Invalid credentials."
Whilst I can login to https://my.renault.nl/ with the same credentials without any issue.
In the log there is this:
2020-10-30 15:11:33 ERROR (MainThread) [custom_components.renault.pyzeproxy] Login to Gigya failed: Gigya returned error 403042: invalid loginID or password
Im using version 3.0.0. Home Assistant version 0.117.0 (also checked 0.117.1). My locale is nl_NL. I used HACS to install the component.

Did you install the Renault application on your phone?
I believe the password for the Renault application is different to the one for the generic Renault website.

Damn. You're absolutely right. The My Renault app is the correct account.


Clean namings and update readme

This PR contains 3 things:

Change the update.sh script so that it update the current distro to origin/master and install it.
Move admin scripts to admin/ (so that end-users are not tempted to use them)
Update the main README.md accordingly.

WARNING: @soumith this can lead to breaking change for some of your scripts:

Your update.sh to update all submodules commit has been moved to admin/updateSubmodules.sh
The travis_cuda_install.sh script has been moved to admin/travis_cuda_install.sh. I guess this is used by one of the CI tools  for cutorch that will need to be updated if this PR is merged (cc @hughperkins).

Ok, just realized that the travis_cuda_install.sh move will impact all travis builds :/
@soumith I guess I should revert this move? Or do you think it is worth the time of updating all travis builds?

could you leave the travis_cuda_install.sh here for now. the rest of the PR looks pretty good :)

Will do that first thing tomorrow morning (don't have my computer here)

Corrected and rebased !

Thank you!

Also thanks @Atcold for proposing this change !


chore: use hereby instead of internal job

Hereby is a simple task runner. It allows us to move the complex build commands into a file.

@OrKoN Hereby is a very minimal framework that does precisely that. Otherwise, we have to create scripts everywhere and maintain them all separately.


RFC: Set add-on options as Docker environment variables

Current behavior
At the moment an add-on is started with the following environment and volume:
# Environment
{'TZ': 'UTC', 'HASSIO_TOKEN': 'ab6720fc028...'}
# Volume
/mnt/data/supervisor/addons/data/core_hello_world': {'bind': '/data', 'mode': 'rw'}

Within the attached volume you can find the options.json including your add-on options like:
{
  "SECRET": "abc"
}

Desired behavior
Along with the current behavior, which should be kept for backward compatibility, an add-on should also be started with its options available as environment args.
# Environment
{'TZ': 'UTC', 'HASSIO_TOKEN': 'ab6720fc028...',  'SECRET': 'abc'}

Motivation
A lot of Docker images requires you to make certain configurations. With the options.json approach there is no way to plug&play a Docker image. You'll either have to write an wrapper to parse that options.json and start the Docker container accordingly or even worse your Docker images has to be aware that there is an option.json with some kind of configuration.

First, we could use the option legacy, and if they is available, we parse the first layer of options as Environment to container.
Why legacy, that is for docker images they are not builded for Hass.io and not have any labels for our supervisor. I think the Environment approach is a nice try to allow simply modification without need a Orchestra but it now allow more complex structure they we have. But I see the need, if you have a simple container they don't need anything from Home Assistant / Hass.io world.

For me it is not clear why non-legacy Docker containers should not get those options passed in as environment args. It just introduces another layer of complexity. Eventually it comes down to one line of code
# docker/addon.py
@property
def environment(self):
     """Return environment for Docker add-on."""
    #  {...}

    return {
        **addon_env,
        # pass add-on optoions as Docker environment args
        **self.addon.options
        ENV_TIME: self.sys_timezone,
        ENV_TOKEN: self.addon.hassio_token,
    }

Because non-legacy docker images are specially created for Hass.io, and they should use the modern json options and not old school flat environment they can be reading from anyone. Docker use also json options for his swarm operations but this feature is not available for dummy single container management :( In that case we adapt this form for Hass.io Add-ons.

Ok that makes sense. It just a little bit confusing to know that the flaglegacy means: _something which is not explicitly build for Hass.IO

yeah, docker legacy container


Apply isildurs-bane template to repo

This issue is similar to https://github.com/18F/development-guide/issues/184 which was resolved by the set of changes in https://github.com/18F/development-guide/pull/194
Some related discussion in #agile is at https://gsa-tts.slack.com/archives/C03JN1M6S/p1601056732006400

Closing as stale, on the assumption that the need will resurface if it still exists.


an option to download free series for non registered users?

The download button in the website does not work without a valid subscription.

Got it
Thanks.

You can use youtube-dl.

@gbdematos can you elaborate? These videos are on youtube?

Oops. Sorry.
No, the videos are stored on vimeo, and YouTube-DL has a generic extractor that works on most websites besides youtube, including Laracasts.  I used to use it before (to download free videos ofc).

Ah okay 😄


Add ability to define and run a subset health checks

This PR Introduces an ability to define and run a SUBSET of health checks.
It will be useful during certain period where it is only required to run specific health checks during a scenario.
It supports both via url /ht/<subset-name>/ and via Django command python manage.py health_check --subset <subset-name>

Hi @codingjoe
Just a polite ping!.
Could I have some feedback on this PR.
Really love to see this feature in the official release of django-health-check.

@frankwiles Just a friendly reminder: Don't forget to create a new release :)

@frankwiles FYI: this is a breaking change, if you've got custom checks, as the signature of BaseHealthCheckBackend.check_status has changed.
TypeError: CeleryBeatCheckBackend.check_status() got an unexpected keyword argument 'subset'

I'll send a PR to fix the docs. Maybe it's possible to add some hint to the current release notes?

It's not clear to me what the point of the subset parameter even is. None of the builtin health check backends actually use it. Can't it be removed to restore compatibility?

@frankwiles FYI: this is a breaking change, if you've got custom checks, as the signature of BaseHealthCheckBackend.check_status has changed.
TypeError: CeleryBeatCheckBackend.check_status() got an unexpected keyword argument 'subset'

I'll send a PR to fix the docs. Maybe it's possible to add some hint to the current release notes?

I agree with you, this merge request should be merged into 4.0.0 only.

@SpecLad There's an example usage in the README (not within the docs).

@SpecLad There's an example usage in the README (not within the docs).

Where? The README hasn't even been updated to include the subset parameter.

Can't link to the proper section, but as said, it's only in the README, not the documentation.

This doesn't show the subset parameter.

Ah, sorry, misunderstanding on my side. It looks like as if the subset parameter on check_status isn't used anywhere.
@panteparak Can you shed some light on this?

I would like to +1 that this is a breaking change and should not have been released as a minor version update. This caused all of our custom health checks to fail with a TypeError

...check_status() got an unexpected keyword argument 'subset'

The minor version upgrade from 3.17 to 3.18was pulled automatically because we had specified our dependencydjango-health-check = "^3.16"`, and unexpectedly caused the health checks to stop working.

I made a PR to unbreak this: #414.


LGTM: Fix wrong type of arguments to formatting function

https://lgtm.com/projects/g/apache/trafficserver/?ruleFocus=2160310550

Cherry-picked to v9.0.x branch.


make a watermark on the bottom

I want to make a watermark on the bottom, the text should be coverd by candles. As shown in Figure.

There is a simple demo as follws:
http://plnkr.co/edit/TznDOr9YaVPJ8JRkXZxA?p=preview
but it on the top of candles.
How to make my watermark(It is just a text).  Thanks.

This is my main code.

Thanks.


This Month in Rust OSDev (November 2020)

This is a draft for the upcomping "This Month in Rust OSDev (November 2020)" post. Please add your content to this draft by creating pull requests against the next branch.
We're a bit late this month, so please add your content as soon as possible. Also, please let me know directly if you're planning to add some content to this issue, so that I can wait with the release.
cc @rust-osdev/all
TODO
The following rust-osdev crates were updated in November:

[x] https://github.com/rust-osdev/acpi
[ ] https://github.com/rust-osdev/x86_64
[ ] https://github.com/rust-osdev/multiboot2-elf64
[ ] https://github.com/rust-osdev/vga

The following private projects should be mentioned in this issue:

[ ] https://github.com/phil-opp/blog_os (assigned to @phil-opp)
[x] Pebble

@phil-opp I'm happy to cover acpi and add a little about Pebble this month, if that works - I can get it to you sometimes this evening

I'll pass this time. Thanks!

Thanks for the quick replies!

I don't have anything to add either for uefi-rs, no new commits. We might have some new features for the December post.

I published a new crate, ps2, that might be useful. I'll add an entry by the end of today.

Published at https://rust-osdev.com/this-month/2020-11/

Thanks for all your work @phil-opp!


Lorem Ipsum

Contrary to popular belief, Lorem Ipsum is not simply random text.  Richard McClintock, a Latin professor at Hampden-Sydney College in Virginia, looked up one of the more obscure Latin words, consectetur, from a Lorem Ipsum passage, and going through the cites of the word in classical literature, discovered the undoubtable source. Lorem Ipsum comes from sections 1.10.32 and 1.10.33 of "de Finibus Bonorum et Malorum" (The Extremes of Good and Evil) by Cicero, written in 45 BC. This book is a treatise on the theory of ethics, very popular during the Renaissance. The first line of Lorem Ipsum, "Lorem ipsum dolor sit amet..", comes from a line in section 1.10.32.

Issue comment through popup

Close issue comment

comment

issue comment

comment 1

vghgfh

ghjhgjhg

vfbfdbfd

fdgjhsbnm,f

fgbgfb

gfhgfhfg

nhfnhgnghnhg

gbfgbgf

fvfd

fngfngfnf

vdfvdfvdf

dscdsc

bgfnhgmngh


encounter_facility_location partial had a name change to facility_loc…

…ation
Pull requests into cqm-parsers require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:

[ ] This pull request describes why these changes were made.
[ ] Internal ticket for this PR:
[ ] Internal ticket links to this PR
[ ] Code diff has been done and been reviewed
[ ] Tests are included and test edge cases
[ ] Tests have been run locally and pass

Reviewer 1:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Reviewer 2:
Name:

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   88.33%   88.33%
=======================================
  Files          68       68
  Lines        1698     1698
=======================================
  Hits         1500     1500
  Misses        198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6607418...a08d1c8. Read the comment docs.


Blank Values

It seems in iOS9 the picker is having some issue presenting the values.  They show up blank.
You can reproduce this in the demo as well.  Open demo, click Choose Color, select any color other than Green, hit Done, Select Choose Color, Values are then blank.
Any thoughts?

I'm having the same issue. It works fine on my iPhone 6 with 10.3.1 but is blank on my iPod with 9.3.5.


[BFFE] Launch new process from UnitedSets and Add the tab in automatically

Launch new process from UnitedSets and Add the tab in automatically (internally, not accessible by User Interface)

This will be useful for many upcoming issues and opens up more features in the future.

This is implemented in #47


authdemo.py, logout not working.

when I click the logout link in the authdemo version I continue to stay logged in.  If I go to gmail.com and logout through google and go back to the demo i am logged out and required to authenticate.  Then, again, am not able to use the logout link to log out.

Hrmm...  well maybe I am doing something wrong, or misunderstanding the demo.  I made a 30 second screen cap of me

launching authdemo.py
logging in
trying to log out
going to gmail and logging out
going back to demo page and hitting log out and finally being actually logged out

http://www.flickr.com/photos/lateplate/6224855207/

Ah, I see.  I'm signed in to two accounts at once (one gmail and one apps domain), so after I logout I'm prompted to switch between them, but if I try it with a different account that doesn't have multi-sign-in enabled I see the same behavior you do.  You're getting logged out (the cookie gets deleted), but then it immediately tries to log you in and succeeds.  I'm not sure whether there's anything that we need to do to revoke access (the user can always revoke access from google.com/accounts) or if the demo should just be changed to require a click to login instead of redirecting to login every time.

The required click would be a great solution.  Is there possibly a parameter that could be passed/set when logging the user in so people understand that even if the cookie has been deleted the credentials to auto login are still there and the user will not be asked to log in again?


Disable autoconfiguration tests are not written correctly.

Currently in all modules there is a test to check if autoconfiguration was not applied if enabled flag for given module is set to false (Disable...Test). Unfortunatelly ListableBeanFactory::getBeanNamesForType does not take into considerations the parent bootstrap context so you can even change the flag to true and the test will pass anyway. This behaviour is documented in javadocs. Instead BeanFactoryUtils::beanNamesForTypeIncludingAncestors should be used to also query the bootstrap context. See javadoc.

Tried to change embedded.oracle.enabled=true and DisableOracleTest failed. Could you provide an example?

This test will fail because BeanPostProcessors are registered for application context and not bootstrap context so it will fail because of second assertion. But it should even fail for the first assertion. You can have a look at vault module. This one does not have BeanPostProcessors and changing flag for Disable tests will not make it fail. Check DisableVaultTest::contextLoads test.

Thank you, I'll check it.

Indeed there is an issue in tests, thank you for noticing. Created corresponding PR.


Add ALIGNN as optional MLIP

Adds optional integration with ALIGNN, to be used as worked developer example for how to add a new MLIP to janus-core.
One other thing to consider, which could affect this implementation/the example slightly (although it would be a separate PR), is if we want to standardise the input model.
Currently only device is standardised, but if we wanted to do the same for the path to the model (which may be useful/essential for aiida-mlip, @federicazanca?), it would be sensible to do it now, before adding further MLIPs.
To do:

[x] Add notes to docs explaining steps taken

Depends on #195, so may need a minor rebase.

(Rebased)


[UI] Cluster Name being ignored during Add Cluster when switched to "Edit as YAML"

What kind of request is this (question/bug/enhancement/feature request):
BUG
Steps to reproduce (least amount of steps as possible):

Add Cluster from Rancher UI (Custom)
Click "Edit as YAML"
Enter Cluster Name in the UI(Above "Member Roles")
Click "Next"
An error message appeared on the UI "Validation failed in API: Cluster name is required"

Result:
An error message appeared on the UI "Validation failed in API: Cluster name is required"
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.3.3
Installation option (single install/HA): HA

The bug is still seen with Rancher server rancher\rancher:master-head version ca01ddff2
Steps:
Add Cluster
Click "Edit as YAML"
Enter Cluster Name in the UI

Set nodes and click Next
UI error shows Validation failed in API: Cluster name is required

The bug is reproduced with Rancher server rancher\rancher:v2.3.3
Steps:
Add Cluster (DO cluster was used in this example)
Click Edit as YAML
Enter Cluster Name in the UI
Set nodes and click Next
UI error shows Validation failed in API: Cluster name is required
The bug fix is verified with Rancher server rancher\rancher:master-head version 1a03ecea3