Keyboard processing in SadConsole doesn't look for CAPSLOCK or NUMLOCK

Because of this, code slipped in to use the . numpad key as delete incorrectly:
https://github.com/SadConsole/SadConsole/blob/develop-7.3/src/SadConsole.Shared/Controls/TextBox.cs#L360
AsciiKey should process the correct character based on NUMLOCK and CAPSLOCK states.

I am sorry I left this in.  Put it in for debugging purposes because the keycode for "Delete" is not coming down correctly.  Ditto for "Home" and "End".  This should be changed in AsciiKey.Fill(), correct?  Again, my apologies.

Nah, it's OK. If you had not done that, I don't think I would have noticed that the keyboard implementation doesn't respect NUMLOCK problem in the first place 😄

I've been looking into how to fix this.  That keyboard input is a bit of a rabbit hole.  Figured out how to get numlock/capslock key state and mostly fixed it in my version but I kinda don't trust myself in what I feel like is very fragile code.

BTW – one of the responses here has XNA error handling which catches the “lock” states using Win32 calls:
https://www.gamedev.net/forums/topic/457783-xna-getting-text-from-keyboard/
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: SadConsole<EMAIL_ADDRESS>Sent: Thursday, December 20, 2018 1:34:35 PM
To: SadConsole/SadConsole
Cc: Darrell Plank; Comment
Subject: Re: [SadConsole/SadConsole] Keyboard processing in SadConsole doesn't look for CAPSLOCK or NUMLOCK (#185)
Nah, it's OK. If you had not done that, I don't think I would have noticed that the keyboard implementation doesn't respect NUMLOCK problem in the first place 😄
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSadConsole%2FSadConsole%2Fissues%2F185%23issuecomment-449142698&data=02|01||1845c5b5dc8443a8c1fc08d666c2f0ac|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636809384772165332&sdata=IjqOjFmP8D3I6PquK%2Bw68nQ56Cep6OH8M4c0dMO99JQ%3D&reserved=0, or mute the threadhttps://nam05.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAmSxc9vBPCrnyB9EwmccXte874Jdq-fks5u7AJrgaJpZM4ZZY4g&data=02|01||1845c5b5dc8443a8c1fc08d666c2f0ac|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636809384772165332&sdata=EU6MBTrMqr6t4y9N7mCTbahcH7t3Om80k2neHl9VlW4%3D&reserved=0.

The way I figured to fix it was to append to the loop logic here: https://github.com/SadConsole/SadConsole/blob/develop-7.3/src/SadConsole.Shared/Input/Keyboard.cs#L122
This should detect those CAPS/NUMLOCK states and

AsciiKey.Fill should have a change that accepts NUMLOCK bool along with the shift status.
if CAPS is pushed, set the shift flag sent to AsciiKey.Fill
if NUMLOCK is pushed, set the numlock flag sent to AsciiKey.Fill
AsciiKey.Fill should check if the combination of numlock is true and one of the keypad keys is set and change the current Key enum that is being sent to the appropriate value

Something like that.

My first response was to change the entries in AsciiKey.FillKey() which was mostly working but the repeated key stuff failed.  As a consequence I think it’s probably better to prefilter the keys = state.GetPressedKeys() just before the loop you refer to.  Pretty amazing how little XNA/MonoGame gives you.  I assumed that the repeating keys would be automatic, but found out differently.  Did you do all that keyboard stuff from scratch or base it off something else?  Must have been a slog to get through.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: SadConsole<EMAIL_ADDRESS>Sent: Friday, December 21, 2018 9:07:08 AM
To: SadConsole/SadConsole
Cc: Darrell Plank; Comment
Subject: Re: [SadConsole/SadConsole] Keyboard processing in SadConsole doesn't look for CAPSLOCK or NUMLOCK (#185)
The way I figured to fix it was to append to the loop logic here: https://github.com/SadConsole/SadConsole/blob/develop-7.3/src/SadConsole.Shared/Input/Keyboard.cs#L122https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSadConsole%2FSadConsole%2Fblob%2Fdevelop-7.3%2Fsrc%2FSadConsole.Shared%2FInput%2FKeyboard.cs%23L122&data=02|01||b0ff6728fa434a9e8e4308d66766bd86|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636810088287613247&sdata=EMc%2BnoxUm2IPtC41PUDd4QMpBAiUXkWMbJvsuCR6HGc%3D&reserved=0
This should detect those CAPS/NUMLOCK states and

AsciiKey.Fill should have a change that accepts NUMLOCK bool along with the shift status.
if CAPS is pushed, set the shift flag sent to AsciiKey.Fill
if NUMLOCK is pushed, set the numlock flag sent to AsciiKey.Fill
AsciiKey.Fill should check if the combination of numlock is true and one of the keypad keys is set and change the current Key enum that is being sent to the appropriate value

Something like that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSadConsole%2FSadConsole%2Fissues%2F185%23issuecomment-449443687&data=02|01||b0ff6728fa434a9e8e4308d66766bd86|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636810088287613247&sdata=AZtWsKbcdGrlZebIIA5nZvZ%2FELK%2BudMI%2F1ceZ4HZ29g%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAmSxe3C1Cpti3ZagdVvk2KXhsMw0RPdks5u7RU8gaJpZM4ZZY4g&data=02|01||b0ff6728fa434a9e8e4308d66766bd86|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636810088287613247&sdata=BdfBtQ%2BXM8XOqzfhhtmAEUEq8QMNA5h7RLcyXhwOLEQ%3D&reserved=0.

Oh – one other thing.  It’s mostly aesthetic, but it kind of drives me batty to see all those cases for all the alphabetic chars in FillKey which could all be replaced by an:
If (key >= Keys.A && key <= Keys.Z)…
I’m loathe to make (or perhaps even suggest) the change because it’s unnecessary, but it would clear a lot of code away and in the interests of the “do everything only once” principle makes some sense.  Do you have objections?  All you’ve gotta say is “Shut up Darrell!  I like it that way!” and I will happily do exactly that.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: SadConsole<EMAIL_ADDRESS>Sent: Friday, December 21, 2018 9:07:08 AM
To: SadConsole/SadConsole
Cc: Darrell Plank; Comment
Subject: Re: [SadConsole/SadConsole] Keyboard processing in SadConsole doesn't look for CAPSLOCK or NUMLOCK (#185)
The way I figured to fix it was to append to the loop logic here: https://github.com/SadConsole/SadConsole/blob/develop-7.3/src/SadConsole.Shared/Input/Keyboard.cs#L122https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSadConsole%2FSadConsole%2Fblob%2Fdevelop-7.3%2Fsrc%2FSadConsole.Shared%2FInput%2FKeyboard.cs%23L122&data=02|01||b0ff6728fa434a9e8e4308d66766bd86|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636810088287613247&sdata=EMc%2BnoxUm2IPtC41PUDd4QMpBAiUXkWMbJvsuCR6HGc%3D&reserved=0
This should detect those CAPS/NUMLOCK states and

AsciiKey.Fill should have a change that accepts NUMLOCK bool along with the shift status.
if CAPS is pushed, set the shift flag sent to AsciiKey.Fill
if NUMLOCK is pushed, set the numlock flag sent to AsciiKey.Fill
AsciiKey.Fill should check if the combination of numlock is true and one of the keypad keys is set and change the current Key enum that is being sent to the appropriate value

Something like that.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FSadConsole%2FSadConsole%2Fissues%2F185%23issuecomment-449443687&data=02|01||b0ff6728fa434a9e8e4308d66766bd86|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636810088287613247&sdata=AZtWsKbcdGrlZebIIA5nZvZ%2FELK%2BudMI%2F1ceZ4HZ29g%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAmSxe3C1Cpti3ZagdVvk2KXhsMw0RPdks5u7RU8gaJpZM4ZZY4g&data=02|01||b0ff6728fa434a9e8e4308d66766bd86|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636810088287613247&sdata=BdfBtQ%2BXM8XOqzfhhtmAEUEq8QMNA5h7RLcyXhwOLEQ%3D&reserved=0.

Yeah, I did all that by scratch. Crazy huh!? Sure! Make anything more efficient. When I'm going at something from scratch I just think it through. Oh I need a... b... c.. and don't think "Is that the best way?" Well I do more so now, but a lot of this code is 10 years old. While this project has been on github for the last 5 it was all private code prior 😄
You can even use the new pattern matching of C# 7
            switch (key)
            {
                case var key2 when key2 >= Keys.A && key2 <= Keys.Z:
                    if (shiftPressed)
                        Character = (char)key2;
                    else
                        Character = (char)(key2 + 32);
                    break;


Interfaces removal

This is an intermediary step to ease the next refactoring steps. Right now, it's difficult to reason about the current system as there are just too many (useless) interfaces/classes.

Is it okay if i make a pr for psr-4?

@prisis That won't work with the current architecture.

@fabpot Was hoping that the architecture get a refactoring too :)


bug fix: concat along the batch dimension

concat the img_list along the batch dimension for better visualization when the number of images is more than 4.

Thank you for your interest in our project.
In the current version, MMGenVisualizationHook or VisualizationHook is only used in translation models, SinGAN and DDPM, and both these models visualize less than or equal to 4 images.
You may use VisualizeUnconditionalSamples if you want to modify the output shape of visualization results.
You may open an issue and explain your usage scenarios if VisualizeUnconditionalSamples can't meet your usage needs.

Hi @LeoXing1996 , this hook is used in cyclegan with an option res_name_list specifying the order of the images to be collected. Besides changing the concat dimension to 0 is more flexible for the downstream make_grid IMHO.

Can you provide some visualization comparison results?

E.g., given 8 images with shape HxW, the current implementation will generate a long Hx(8W) image, and the nrow is not used.
If concat along dim=0 and setting nrow=4, this will generate a (2H x 4*W) image.


5.1 support?

I don't know. I'm in the process of setting up a Laravel 5 project to test. But, balancing a few time sinks at the moment.

backup-manager/backup-manager requires aws/aws-sdk-php v2
https://github.com/backup-manager/backup-manager/blob/master/composer.json#L19
while laravel 5.1 requires aws/aws-sdk-php v3
https://github.com/thephpleague/flysystem-aws-s3-v3/blob/master/composer.json#L14

@bberlijn awesome, could you possibly submit a pull request with that change?

I'm closing this, recent merges have theoretically fixed 5.1 problems. I'm gongi to update the aws sdk dependency as mentioned by @bberlijn. Thanks everyone.

Awesome :)

Is there currently a way to install flysystem-aws-s3-v3 with backup-manager?  Adding both "league/flysystem-aws-s3-v3": "~1.0" and "backup-manager/laravel": "~1.0" to my composer.json results in composer hanging indefinitely.


rename logging to logging_utils trying to fix win-py37 issue on CI

This PR tries to fix an issue on Appveyor (ie Windows) only occurring with Python 3.7.
> pyam\utils.py:21: in <module>
>     logger = logging.getLogger(__name__)
> E   AttributeError: 'module' object has no attribute 'getLogger'

seems that the logging wasn't actually the issue, fixed (for now) by cherry-picking commits into #310


The analyzer keeps crashing in VSCode when using extension type

Unhandled exception:
[16:07:14] [Analyzer] [Error] Unhandled exception:
Bad state: Empty path: [Object?, JsonValue]
#0      InterfaceLeastUpperBoundHelper._computeTypeAtMaxUniqueDepth (package:analyzer/src/dart/element/least_upper_bound.dart:315:5)
#1      InterfaceLeastUpperBoundHelper._computeLeastUpperBound (package:analyzer/src/dart/element/least_upper_bound.dart:182:12)
#2      InterfaceLeastUpperBoundHelper.compute (package:analyzer/sr

Minimal example：
DartPad
extension_type_example

dart info
If providing this information as part of reporting a bug, please review the information
below to ensure it only contains things you're comfortable posting publicly.

#### General info

- Dart 3.3.0-174.3.beta (beta) (Tue Dec 12 14:49:22 2023 +0000) on "macos_arm64"
- on macos / Version 14.1 (Build 23B74)
- locale is zh-Hans-CN

#### Project info

- sdk constraint: '>=3.3.0-0 <4.0.0'
- dependencies: async, collection, meta
- dev_dependencies: checks, logging, test

#### Process info

No Dart processes found.

VSCode log
[15:50:51] [General] [Info]         /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin
[15:50:51] [General] [Info]         /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin
[15:50:51] [General] [Info]         /Library/Apple/usr/bin
[15:50:51] [General] [Info]         /opt/puppetlabs/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/
[15:50:51] [General] [Info]         /opt/homebrew/bin
[15:50:51] [General] [Info]         /opt/homebrew/sbin
[15:50:51] [General] [Info]         /Users/anya/.local/share/fig/plugins/git-open
[15:50:51] [General] [Info]         /Users/anya/.local/share/fig/plugins/git-open -> /Users/anya/.local/share/fig/plugins/git-open/bin
[15:50:51] [General] [Info]         /usr/local/sbin
[15:50:51] [General] [Info]         /Users/anya/ysy/scala-2.11.8/bin
[15:50:51] [General] [Info]         /home/linuxbrew/.linuxbrew/Cellar/gcc/13.1.0/bin
[15:50:51] [General] [Info]         /usr/local/opt/mysql-client/bin
[15:50:51] [General] [Info]         /Users/anya/go/bin
[15:50:51] [General] [Info]         /Users/anya/.cargo/bin
[15:50:51] [General] [Info]         /usr/local/opt/inetutils/libexec/gnubin
[15:50:51] [General] [Info]         /usr/local/opt/inetutils/libexec/gnubin -> /usr/local/opt/inetutils/libexec/gnubin/bin
[15:50:51] [General] [Info]         /usr/local/opt/sqlite/bin
[15:50:51] [General] [Info]         /Users/anya/.npm-global/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin
[15:50:51] [General] [Info]         /Users/anya/.pub-cache/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin/cache/dart-sdk/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/tools/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/platform-tools
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/platform-tools -> /Users/anya/Library/Android/sdk/platform-tools/bin
[15:50:51] [General] [Info]         /Users/anya/.fig/bin
[15:50:51] [General] [Info]         /Users/anya/.local/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts
[15:50:51] [General] [Info]         /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts -> /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts
[15:50:51] [General] [Info]         /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts -> /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts/bin
[15:50:51] [General] [Info]     Found at:
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin
[15:50:51] [General] [Info] Following symlink: /Users/anya/fvm/default/bin/flutter -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/flutter
[15:50:51] [General] [Info] Following symlink: /Users/anya/fvm/default/bin/flutter -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/flutter
[15:50:51] [General] [Info] Following symlink: /Users/anya/fvm/default/bin/flutter -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/flutter
[15:50:51] [General] [Info]     Candidate paths to be post-filtered:
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre
[15:50:51] [General] [Info]         /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/ -> /Users/anya/fvm/versions/3.18.0-0.2.pre
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre
[15:50:51] [General] [Info]     Found at /Users/anya/fvm/default/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre
[15:50:51] [General] [Info]     Returning SDK path /Users/anya/fvm/versions/3.18.0-0.2.pre for flutter
[15:50:51] [General] [Info] Searching for dart
[15:50:51] [General] [Info]     Looking for dart in:
[15:50:51] [General] [Info]         /opt/homebrew/bin
[15:50:51] [General] [Info]         /opt/homebrew/sbin
[15:50:51] [General] [Info]         /opt/homebrew/bin
[15:50:51] [General] [Info]         /usr/local/sbin
[15:50:51] [General] [Info]         /Users/anya/ysy/scala-2.11.8/bin
[15:50:51] [General] [Info]         /home/linuxbrew/.linuxbrew/Cellar/gcc/13.1.0/bin
[15:50:51] [General] [Info]         /usr/local/opt/mysql-client/bin
[15:50:51] [General] [Info]         /Users/anya/go/bin
[15:50:51] [General] [Info]         /Users/anya/.cargo/bin
[15:50:51] [General] [Info]         /usr/local/opt/inetutils/libexec/gnubin
[15:50:51] [General] [Info]         /usr/local/opt/inetutils/libexec/gnubin -> /usr/local/opt/inetutils/libexec/gnubin/bin
[15:50:51] [General] [Info]         /usr/local/opt/sqlite/bin
[15:50:51] [General] [Info]         /Users/anya/.npm-global/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin
[15:50:51] [General] [Info]         /Users/anya/.pub-cache/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin/cache/dart-sdk/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/tools/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/platform-tools
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/platform-tools -> /Users/anya/Library/Android/sdk/platform-tools/bin
[15:50:51] [General] [Info]         /Users/anya/.local/share/fig/plugins/git-open
[15:50:51] [General] [Info]         /Users/anya/.local/share/fig/plugins/git-open -> /Users/anya/.local/share/fig/plugins/git-open/bin
[15:50:51] [General] [Info]         /opt/homebrew/bin
[15:50:51] [General] [Info]         /usr/local/sbin
[15:50:51] [General] [Info]         /Users/anya/ysy/scala-2.11.8/bin
[15:50:51] [General] [Info]         /home/linuxbrew/.linuxbrew/Cellar/gcc/13.1.0/bin
[15:50:51] [General] [Info]         /usr/local/opt/mysql-client/bin
[15:50:51] [General] [Info]         /Users/anya/go/bin
[15:50:51] [General] [Info]         /Users/anya/.cargo/bin
[15:50:51] [General] [Info]         /usr/local/opt/inetutils/libexec/gnubin
[15:50:51] [General] [Info]         /usr/local/opt/inetutils/libexec/gnubin -> /usr/local/opt/inetutils/libexec/gnubin/bin
[15:50:51] [General] [Info]         /usr/local/opt/sqlite/bin
[15:50:51] [General] [Info]         /Users/anya/.npm-global/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin
[15:50:51] [General] [Info]         /Users/anya/.pub-cache/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin/cache/dart-sdk/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/tools/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/platform-tools
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/platform-tools -> /Users/anya/Library/Android/sdk/platform-tools/bin
[15:50:51] [General] [Info]         /usr/local/bin
[15:50:51] [General] [Info]         /System/Cryptexes/App/usr/bin
[15:50:51] [General] [Info]         /usr/bin
[15:50:51] [General] [Info]         /bin
[15:50:51] [General] [Info]         /usr/sbin
[15:50:51] [General] [Info]         /sbin
[15:50:51] [General] [Info]         /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin
[15:50:51] [General] [Info]         /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin
[15:50:51] [General] [Info]         /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin
[15:50:51] [General] [Info]         /Library/Apple/usr/bin
[15:50:51] [General] [Info]         /opt/puppetlabs/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/
[15:50:51] [General] [Info]         /opt/homebrew/bin
[15:50:51] [General] [Info]         /opt/homebrew/sbin
[15:50:51] [General] [Info]         /Users/anya/.local/share/fig/plugins/git-open
[15:50:51] [General] [Info]         /Users/anya/.local/share/fig/plugins/git-open -> /Users/anya/.local/share/fig/plugins/git-open/bin
[15:50:51] [General] [Info]         /usr/local/sbin
[15:50:51] [General] [Info]         /Users/anya/ysy/scala-2.11.8/bin
[15:50:51] [General] [Info]         /home/linuxbrew/.linuxbrew/Cellar/gcc/13.1.0/bin
[15:50:51] [General] [Info]         /usr/local/opt/mysql-client/bin
[15:50:51] [General] [Info]         /Users/anya/go/bin
[15:50:51] [General] [Info]         /Users/anya/.cargo/bin
[15:50:51] [General] [Info]         /usr/local/opt/inetutils/libexec/gnubin
[15:50:51] [General] [Info]         /usr/local/opt/inetutils/libexec/gnubin -> /usr/local/opt/inetutils/libexec/gnubin/bin
[15:50:51] [General] [Info]         /usr/local/opt/sqlite/bin
[15:50:51] [General] [Info]         /Users/anya/.npm-global/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin
[15:50:51] [General] [Info]         /Users/anya/.pub-cache/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin/cache/dart-sdk/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/tools/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/platform-tools
[15:50:51] [General] [Info]         /Users/anya/Library/Android/sdk/platform-tools -> /Users/anya/Library/Android/sdk/platform-tools/bin
[15:50:51] [General] [Info]         /Users/anya/.fig/bin
[15:50:51] [General] [Info]         /Users/anya/.local/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts
[15:50:51] [General] [Info]         /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts -> /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts/bin
[15:50:51] [General] [Info]         /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts
[15:50:51] [General] [Info]         /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts -> /Users/anya/Library/Application Support/JetBrains/Toolbox/scripts/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk
[15:50:51] [General] [Info]         /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk/bin
[15:50:51] [General] [Info]     Found at:
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin/cache/dart-sdk/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin/cache/dart-sdk/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin/cache/dart-sdk/bin
[15:50:51] [General] [Info]         /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk/bin
[15:50:51] [General] [Info] Following symlink: /Users/anya/fvm/default/bin/dart -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/dart
[15:50:51] [General] [Info] Following symlink: /Users/anya/fvm/default/bin/cache/dart-sdk/bin/dart -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk/bin/dart
[15:50:51] [General] [Info] Following symlink: /Users/anya/fvm/default/bin/dart -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/dart
[15:50:51] [General] [Info] Following symlink: /Users/anya/fvm/default/bin/cache/dart-sdk/bin/dart -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk/bin/dart
[15:50:51] [General] [Info] Following symlink: /Users/anya/fvm/default/bin/dart -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/dart
[15:50:51] [General] [Info] Following symlink: /Users/anya/fvm/default/bin/cache/dart-sdk/bin/dart -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk/bin/dart
[15:50:51] [General] [Info]     Candidate paths to be post-filtered:
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin/cache/dart-sdk/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin/cache/dart-sdk/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk
[15:50:51] [General] [Info]         /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/ -> /Users/anya/fvm/versions/3.18.0-0.2.pre
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre
[15:50:51] [General] [Info]         /Users/anya/fvm/default/bin/cache/dart-sdk/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk
[15:50:51] [General] [Info]         /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk
[15:50:51] [General] [Info]     Found at /Users/anya/fvm/default/bin/cache/dart-sdk/bin -> /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk
[15:50:51] [General] [Info]     Returning SDK path /Users/anya/fvm/versions/3.18.0-0.2.pre/bin/cache/dart-sdk for dart
[15:50:51] [General] [Info] Experiment random number is 89 for experiment 'sdkDaps'. Experiment is enabled for <= 100
[15:50:51] [General] [Info] Experiment 'sdkDaps' is activating (not first time)
[15:50:51] [General] [Info] Experiment random number is 89 for experiment 'sdkDaps'. Experiment is enabled for <= 100
[15:50:51] [General] [Info] Experiment 'sdkDaps' is activating (not first time)
[15:50:51] [General] [Info] Experiment random number is 89 for experiment 'sdkDaps'. Experiment is enabled for <= 10
[15:50:51] [General] [Info] Experiment 'sdkDaps' does not apply and will not be activated
[15:50:51] [General] [Info] !! ⚠ PLEASE REVIEW THIS LOG FOR SENSITIVE INFORMATION BEFORE SHARING ⚠ !!

Thanks for reporting the issue and for providing the reproduction on DartPad!
\cc @scheglov

Even more reduced example
extension type const E1(Object? value) {}

extension type const E2(Object? value) implements E1 {}

extension type const E3(Object? value) implements E1 {}

E1 f(bool b, Object? value) {
  return b ? E2(value) : E3(value);
}


Review page - slight text change for Images section

Since the preview of the uploaded extra pages also show up in this section, change the text,
From: Images
To: Images and Extra Pages

validated


Some unit tests fail if they are run via bazel

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
Follow of #1884. If I run the golang unit tests via bazel test $(bazel query 'kind("go_test rule", //pkg/...)'), the imageupload tests are failing.
What you expected to happen:
That I can run all unit tests via bazel.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

Hm problem that under the test we use
imagePath    = "../../../vendor/kubevirt.io/containerized-data-importer/tests/images/cirros-qcow2.img"
that does not exist under the bazel sandbox, I will need to check the way to pass additional data to the test.


document how to create and upload the javascript sourcemap

@SudoPlz is working on this with a Bugsnag open source rep right now actually.

We're currently trying to find a way to make this work with @kattrali on https://gitter.im/SudoPlz/react-native-bugsnag

Ok all you need to do to to get a readable js stacktrace is create sourcemaps for your app, then upload them to bugsnag and then make your project of type Javascript in the bugsnag dashboard, (you do that from their Settings screen). I did that and now I get a translated stacktrace I can read.
For now this works well but its not yet fancy, their team is working on it from what I know.


Java script error on opening

I also encountered the same issue today. However, I managed to resolve it by uninstalling Better-ChatGPT and manually deleting the relevant folders (using Everything or other tools to find all the relevant folds). Finally, I restarted my computer.

ok ill try that

ok ill try that

I also encountered the same issue today. However, I managed to resolve it by uninstalling Better-ChatGPT and manually deleting the relevant folders (using Everything or other tools to find all the relevant folds). Finally, I restarted my computer.

ok ill try that

I also encountered the same issue today. However, I managed to resolve it by uninstalling Better-ChatGPT and manually deleting the relevant folders (using Everything or other tools to find all the relevant folds). Finally, I restarted my computer.

ok ill try that

I also encountered the same issue today. However, I managed to resolve it by uninstalling Better-ChatGPT and manually deleting the relevant folders (using Everything or other tools to find all the relevant folds). Finally, I restarted my computer.


Fix command descriptions

We have these descriptions today. Shouldn't all the charts occurrences be replaced with releases?
For example, helmfile delete deletes releases, not charts.
COMMANDS:
     repos   sync repositories from state file (helm repo add && helm repo update)
     charts  sync charts from state file (helm upgrade --install)
     diff    diff charts from state file against env (helm diff)
     sync    sync all resources from state file (repos, charts and local chart deps)
     status  retrieve status of releases in state file
     delete  delete charts from state file (helm delete)
     test    tets releases from state file (helm test)

I think that makes sense for clarity


Injected text accessibility

Testing #129383
Here's how I think the injected text accessibility should work.
Reading the injected text every time it shows up would be very aggressive and spammy. So I suggest to have an explicit command which the users could trigger that would help them here. Here's how the command would behave:

once the user triggers the command the injected text is read out
focus is moved to the injected text hover so the user can navigate / accept a suggestion
once the user accepted or closed the hover, focus is back in the editor
command would have some keybinding. Something with a key chord should be empty

I see that Cmd + K, Cmd + I already triggers the hover. However the problem here is:

focus is not moved into the hover
the suggested insertion is not being read out

More feedback can be found here https://github.com/microsoft/vscode/issues/125294

focus is not moved into the hover

Hmm, are you sure?
Ctrl K, Ctrl seems to move the focus to the hover for me on windows (focus is indicated by the blue border):

@hediet I mean for your copilot hover, not in general. Previous and next buttons are disabled in my case, maybe that is the cause of why the focus is not moved?

@hediet just to clarify my idea, since you mentioned in slack
"by showing the inline suggestion in the inline suggestion hover when the screen reader mode is enabled"
I think a nicer implementation would be to always have the aria-label set, even if the screen reader is not there. Since the aria label will only be visible to screen reader users. So I would not change the actual content of the widget.
Though what you mentioned will also work, and feel free to try that approach out first.

This is my idea:
When this.accessibilityService.isScreenReaderOptimized() returns true, the inline suggestion is added to the hover:

Screen reader users are informed that an inline suggestion follows when the hover is triggered
When clicking on next, the hover is updated & the screenreader automatically reads the inline suggestions
This does not affect non-screenreader users

What do you think?

I think this is a lovely solution. I really like it. Though I would still have to try it out.
The only remaining piece of the puzzle is: how to improve that the screen reader users are informed that there is a hover at all. But we can tackle that afterwards.
However I checked your PR and there are a lot of code changes for last day of endgame, and since we never supported this I suggest that we simply do this first week of debt. That way you can merge it in insiders and I can test it out.
Due to that I am moving this to August. Hope that makes sense, thanks!

Thanks! Makes a lot of sense!

Reopening, as it is unclear if the PR fully addresses this issue.

@hediet I can give this a test spin. Are you happy with the current state of things so I try it out?

Yes, you can try it!

Oh the insiders is not yet out with your changes since we freeze insiders this week.
I will give this a spin once we release in a couple of days.

This is the outcome:
When screenreader mode is enabled and the cursor is before an inline suggestion, hitting Ctrl + K, Ctrl + I will open a hover and the screenreader will read the suggestion.
If "Tab moves focus" is set, "Tab" will then cycle through various commands regarding inline suggestions (next/previous/accept/...).
I think this addresses all points mentioned in this issue.

All, but one, which was already brought up by @isidorn . We are going to have to come up with a way to indicate the hover is there to begin with. It's great that the hover is accessible, but it's not going to do much good if people don't know it should be invoked, given this  is a manual process.
@isidorn  was any thought given yet to other line-based suggestions like lightbulbs, error indicators etc. yet in other issues? It feels to me like the best solution here would be to tackle all these at once and give CoPilot that framework to just hook into?

I opened #130565 to track how to notify screenreader users when there are inline suggestions available.


The HandlerInterceptor did not properly intercept all configured restful interfaces

Expected behavior
I use "HandlerInterceptor" in its includes method internal configuration "/v1/stat/, /v1/get/,/v1/list/**" these parameters, I hope restlight can help us intercept similar "/ v1/get/xxxxx/hello, /v1/stat/12234435" such interface
Actual behavior
It can only intercept interfaces such as "/v1/stat/12234435"
Reason for analysis
There is a problem with the implementation of "neverIntersect(includes, patterns)" in the method of judging affinity in the HandlerInterceptorWrap class parseAffinity；
for (String include : includes) {
if (Arrays.stream(patterns)
.noneMatch(pattern -> PathMatcher.isPotentialIntersect(include, pattern))) {
return true;
}
}
The above piece of code will cause the logic to exit due to the disjointness of “/v1/stat/” before judging whether the interface “/v1/get/123456” will not intersect with “/v1/get/”.  I'll fix it later.


Excel.decodeBytes(bytes) is blocking the UI thread

I read a big Excel file about 10k rows and I use async for the function that read the file, but when it reaches Excel.decodeBytes(bytes) the UI thread is blocked, and the progress indicator is freezed until the method is finished its work.

Duplicate of #96


Disconnect CosmosDB unit tests from external services

Description
Currently, the CosmosDB tests are disabled because Travis does not have a CosmosDB emulator. This pull-request adds nock package to mock the service's calls and allows to enable the tests related to the service.
The same approach can be used to decouple the blobStorage tests and the azureBlobTranscriptStore tests.
Specific Changes

Add nock to mock service's requests.
Add mockHelper.js to enable record/playback tests.
Modify cosmosDbStorage.test.js to use mocks.

Testing
This pull-request enables all CosmosDB tests.

Pull Request Test Coverage Report for Build 1937

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.9%) to 75.839%

Totals

Change from base Build 1931:
1.9%

Covered Lines:
2395

Relevant Lines:
3055

💛  - Coveralls


Fixed path for Postgres in dashboard docker image

Motivation
The Postgres version from the Debian base image was updated from 9.4 to 9.6 and the scripts in our docker image were now incorrect.

retest this please

retest this please


Method invocation parenthesis issue

https://github.com/kiegroup/jbpm/commit/83cfa21578e63956bca0715eefee2860c3b6d39a

[ ] Fix issue related to method invocation ()
[ ] Update test-cases


The Repo's README has a broken link.

Describe the bug
If you go to the README.md file in this repo and click on the Contributing Guide link, it goes to the past canary branch. A 404 appears because the branch is deleted.  Ex:  Please read the [Contributing Guide](https://github.com/module-federation/universe/blob/canary/CONTRIBUTING.md).
Reproduction
If you go to the ReadMe.md file and click on the Contributing Guide, it goes to the past canary branch and 404 appears because the branch is deleted. Ex:  Please read the Contributing Guide.
Used Package Manager
npm
System Info
No system information needed.

Validations

[X] Read the docs.
[X] Read the common issues list.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Module federation issue and not a framework-specific issue.
[X] The provided reproduction is a minimal reproducible example of the bug.

I'll fix it


[WIP] Upgrade Marathon version to latest.

This is a prototype PR for nightly DC/OS images with latest Marathon.

can we get an update on progress?

Abandon in favour of #1739.


Disable topic scanning ?!

How to disable topic scanning ?
Using MQTTfx this will can scan active connections...

How is this related to Moquette if it's a functionality offered by MQTT.fx?
Andrea
Il mar 31 lug 2018, 05:44 Ricardo JL Rufino<EMAIL_ADDRESS>ha
scritto:

[image: image]
https://user-images.githubusercontent.com/515675/43436446-ed4436d2-945a-11e8-88d2-b1225238334b.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/andsel/moquette/issues/426#issuecomment-409084878,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_Y0VwuKGlaPvhPUTRbjytI5i7WRXzGks5uL9KzgaJpZM4VnjJh
.

I would like to know if I can block

On the sever side is not possible, because the broker hasn't any mechanism
to understand this scanning, but what scanning means? The client subscribe
to # topic, or try to subscribe in brute forcing?
Il gio 2 ago 2018, 02:51 Ricardo JL Rufino<EMAIL_ADDRESS>ha
scritto:

I would like to know if I can block
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/andsel/moquette/issues/426#issuecomment-409770315,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_Y0RC5SvmxZtFo4B5FYjKwljx85LmJks5uMk0DgaJpZM4VnjJh
.

I think that the client subscribe to # topic .

Oks, this could be a configuration variable to prohibit clients can
subscribe to # topic
Andrea
On Fri, Aug 3, 2018 at 3:36 PM Ricardo JL Rufino<EMAIL_ADDRESS>wrote:

I think that the client subscribe to # topic .
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/andsel/moquette/issues/426#issuecomment-410249203,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA_Y0UAiwQGfhScL5G1rd5auHLNOdDeoks5uNFHUgaJpZM4VnjJh
.

For now I have implemented using: IAuthorizator


Breadcrumbs font is incorrect

The wrong font in breadcrumbs. Right one is the Roboto

can i get assigned to this?


Close feature gap between LSIF and SCIP for Scala

Previously, scip-java had custom support for Scala that was only supported by the LSIF writer. This meant that Scala users were recommended to use LSIF instead of SCIP.
Now that Sourcegraph supports native SCIP uploads (and stores SCIP in the database) it's time to close this feature gap so that Scala users can use SCIP instead of LSIF.
Test plan
See updated snapshot tests.

Assuming this can be closed @olafurpg ?


[vcpkg] Fix default x86 platform of msbuild in vcpkg_install_msbuild

Describe the pull request

What does your PR fix?
Fixes https://github.com/microsoft/vcpkg/issues/28076
The c++ project automatically created by Visual Studio includes the following default Configuration and Platform:

  	GlobalSection(SolutionConfigurationPlatforms) = preSolution
		Debug|x64 = Debug|x64
		Debug|x86 = Debug|x86
		Release|x64 = Release|x64
		Release|x86 = Release|x86
	EndGlobalSection

This means that during msbuild, the /p: Platform parameter only accepts x86 or x64.
However, according to our current settings in vcpkg_install_msbuild.cmake, /p:Platform will be set to Win32 when install port with x86 triplet, which will cause the following errors:
   error MSB4126: The specified solution configuration "Release|Win32" is invalid.
   error MSB4126: The specified solution configuration "Debug|Win32" is invalid.

For fixing this issue, I modify the value from Win32 to x86.
VS project supports setting the platform to Win32, but this is not the default and needs to be set manually.
Although Debug|Win32 and Debug|x86 actually point to the same setting, however, the value of /p: Platform corresponding to them in the msbuild command is different.
GlobalSection(SolutionConfigurationPlatforms) = preSolution
    Debug|Win32 = Debug|Win32
    Debug|x86 = Debug|x86
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
    {B760FBDE-F771-4EFA-8FE4-ABB9C80F9A24}.Debug|Win32.ActiveCfg = Debug|Win32
    {B760FBDE-F771-4EFA-8FE4-ABB9C80F9A24}.Debug|Win32.Build.0 = Debug|Win32
    {B760FBDE-F771-4EFA-8FE4-ABB9C80F9A24}.Debug|x86.ActiveCfg = Debug|Win32
    {B760FBDE-F771-4EFA-8FE4-ABB9C80F9A24}.Debug|x86.Build.0 = Debug|Win32
EndGlobalSection

You need open the .sln file instead of the .vcxproj file.

You need to open the .sln file instead of the .vcxproj file.

vcpkg_install_msbuild is usually expected to be given .vcxproj rather than .sln -- that's why the value is "Win32" rather than "x86": that's the default for C++ projects.
This is why there is an argument for PLATFORM at all.
Let's look at current callers of vcpkg_install_msbuild.
Callers that affirmatively set Win32:

3fd: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/3fd/portfile.cmake#L3
ace: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/ace/portfile.cmake#L69
activemq-cpp: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/activemq-cpp/portfile.cmake#L69
easyhook: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/easyhook/portfile.cmake#L13
hunspell: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/hunspell/portfile.cmake#L22
mp3lame: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/mp3lame/portfile.cmake#L27

Callers that affirmatively set x86:

ecsutil: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/ecsutil/portfile.cmake#L2
ngspice: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/ngspice/portfile.cmake#L38-L39
ocilib: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/ocilib/portfile.cmake#L12
rsasynccpp: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/rsasynccpp/portfile.cmake#L30
shiftmedia-libgcrypt: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/shiftmedia-libgcrypt/portfile.cmake#L72
shiftmedia-libgnutls: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/shiftmedia-libgnutls/portfile.cmake#L142
shiftmedia-libgpg-error: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/shiftmedia-libgpg-error/portfile.cmake#L44

Callers where the correct value is Win32 because that is currently the default. These are likely to be broken by this PR:

ideviceinstaller: https://github.com/microsoft/vcpkg/blob/master/ports/ideviceinstaller/portfile.cmake
idevicerestore: https://github.com/microsoft/vcpkg/blob/master/ports/idevicerestore/portfile.cmake
libirecovery: https://github.com/microsoft/vcpkg/blob/master/ports/libirecovery/portfile.cmake
libmicrohttpd: https://github.com/microsoft/vcpkg/blob/master/ports/libmicrohttpd/portfile.cmake
libosip2: https://github.com/microsoft/vcpkg/blob/master/ports/libosip2/portfile.cmake
libusb: https://github.com/microsoft/vcpkg/blob/master/ports/libusb/portfile.cmake
monkeys-audio: https://github.com/microsoft/vcpkg/blob/master/ports/monkeys-audio/portfile.cmake
pbc: https://github.com/microsoft/vcpkg/blob/master/ports/pbc/portfile.cmake
python3: https://github.com/microsoft/vcpkg/blob/master/ports/python3/portfile.cmake
scintilla: https://github.com/microsoft/vcpkg/blob/master/ports/scintilla/portfile.cmake
sdl1: https://github.com/microsoft/vcpkg/blob/master/ports/sdl1/portfile.cmake
tracy: https://github.com/microsoft/vcpkg/blob/master/ports/tracy/portfile.cmake
libusbmuxd: https://github.com/microsoft/vcpkg/blob/master/ports/libusbmuxd/portfile.cmake
zeroc-ice: https://github.com/microsoft/vcpkg/blob/master/ports/zeroc-ice/portfile.cmake

Callers that don't care:

libfabric is x64 only: https://github.com/microsoft/vcpkg/blob/163fe7bd3d67c41200617caaa245b5ba2ba854e6/ports/libfabric/portfile.cmake#L21

So 20 ports want Win32, and only 7 want x86, so I think leaving this default as Win32 is correct.

It's also notable that undoing the Win32 selection with 1 line is possible but the reverse is not.

@BillyONeal Thank you for your detailed reply.

vcpkg_install_msbuild is usually expected to be given .vcxproj rather than .sln

This is just what we expect. But in fact, many ports pass .sln instead of .vcxproj to the PROJECT_SUBPATH parameter. In addition, our document also said that both are OK, and there is no tendency.

So 20 ports want Win32, and only 7 want x86, so I think leaving this default as Win32 is correct.

Your reason is very good. I agree with your decision.
Also, we do not need to consider the port which uses the PLATFORM ${xxx} parameter in vcpkg_install_msbuild(), because the part we modify is for the port that does not use this parameter.
The last question is about this part of the document: [PLATFORM <${TRIPLET_SYSTEM_ARCH}>].
The description here is not accurate and cannot explain why win32 is used as a parameter on x86 triplet. This is also the concern of the user who report the https://github.com/microsoft/vcpkg/issues/28076. If we maintain the status quo of vcpkg_install_msbuild, the document part will have to be modified.
What do you suggest about documentation?

What do you suggest about documentation?

I made a PR fixing the documentation https://github.com/microsoft/vcpkg/pull/28189
Thanks!

Close this PR because https://github.com/microsoft/vcpkg/pull/28189 is more reasonable and effective.


User Defined Smart Contracts

🚀 Feature Request
User defined smart contracts will be extremely useful for users of the Libra platform, similarly to how they have found great use in extending Ethereum from just a cryto currency to a distributed computer which has many uses.
In the white paper it says user defined smart contracts will be "eventually" implemented - does this mean they will be implemented in the coming months before launch?
If someone were to do a pull request for the code for user defined smart contracts in the next few months would it be considered/accepted?

I believe the smart contract is already there. Just you have to use move mvir language instead of
move source language.  I agree it is better to have the high level language be available as soon as possible even if it is just alpha version. mvir is kind of low to develop bigger application.

@aihuawu thanks for your response. Is it possible to deploy a mvir contract on the testnet currently? On the documentation it says "Custom Move programs are not supported in the initial testnet release, but these features are available for you to try out locally."
Is there any way to use mvir to deploy a custom smart contract to the main testnet?

Is there any way to use mvir to deploy a custom smart contract to the main testate?

no, only to your local node. src here : https://community.libra.org/t/publishing-modules/118/2?u=lucas

thanks for the feedback, I got confused by the documentation


Could pyenv install Anaconda2-4.1.0 without internet?

I tried to download Anaconda2-4.1.0-Linux-x86_64.sh, move it into ~/.pyenv/cache and change it chmod to 755. When I run pyenv install anaconda2-4.1.0, it still can't load the file, but try to connect the internet.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/36254418-could-pyenv-install-anaconda2-4-1-0-without-internet?utm_campaign=plugin&utm_content=tracker%2F335155&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F335155&utm_medium=issues&utm_source=github).

I got it at #445...
just add -v, like,
pyenv install -v anaconda2-4.1.0


reward foundation, loading withdraw

Pull Request Test Coverage Report for Build 150

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.836%

Totals

Change from base Build 149:
0.0%

Covered Lines:
86

Relevant Lines:
94

💛  - Coveralls


support latest protoc.

Armeria gRPC componet is not compatible with stub that generated by latest protoc.
I know to upgrade gRPC library Armeria uses, JDK 8 support has to be dropped.
But keep using old protoc is not good at all.
Isn't time to drop JDK 8 support?
Quarkus had the same problem and they decided to drop JDK 8 support.

Hi, I didn't know there was a minimum java requirement for protoc 😅   Do you have any references that announces this behavior?
And I wasn't able to find any notes that where protobuf is dropping support for java 8.
https://github.com/protocolbuffers/protobuf/releases
jfyi. I think we're using 3.21.1 at the moment.
https://github.com/line/armeria/blob/92e70170b560470a68ae18895d60b3689c8d98bb/dependencies.toml#L789
https://github.com/line/armeria/blob/92e70170b560470a68ae18895d60b3689c8d98bb/dependencies.toml#L789-L791
https://github.com/line/armeria/blob/92e70170b560470a68ae18895d60b3689c8d98bb/gradle/scripts/lib/java-rpc-proto.gradle#L37

Armeria gRPC componet is not compatible with stub that generated by latest protoc.

If you can share the error message you encountered, it would also help 🙇

Isn't time to drop JDK 8 support?

We don't a specific plan to drop JDK 8. As far as I know, many of our community users and LINE internally use Java 8.

the error message

More specifically, the full stack trace. Meanwhile, we might want to add a test module under :it to ensure the forward compatibility.

I've got this build error.
C:\work\grpctest\build\generated\source\proto\main\java\com\example\grpc\hello\Helloworld.java:386: error: cannot find symbol
                if (!super.parseUnknownField(input, extensionRegistry, tag)) {
                          ^
  symbol: method parseUnknownField(CodedInputStream,ExtensionRegistryLite,int)

protoc setting in build.gradle is this.
protobuf {
    protoc {
        artifact = "com.google.protobuf:protoc:3.23.0"
    }
    plugins {
        grpc {
            artifact = 'io.grpc:protoc-gen-grpc-java:1.55.1'
        }
    }
    generateProtoTasks {
        all()*.plugins {
            grpc {}
        }
    }
}

Please see this issue.
https://github.com/protocolbuffers/protobuf/issues/10695#issuecomment-1267493171

We might need two versions for armeria-grpc to keep JDK 8 compatiblity and have security issue fix.

Note that the upgrade PR from our side will be included in the next release.
https://github.com/line/armeria/pull/4820
This version includes a fix for the following issue which was a blocker for upgrading protobuf (which may be why you are mentioning jdk8 compatibility)
https://github.com/protocolbuffers/protobuf/issues/11393

Thanks!. That should solve the issue we see.
And keep having JDK 8 compatibility is also good.


Add search functionality

⏱ Before you start

[x] Have you checked if a similar PR has already been requested?
[x] Have you built and ran the app?

↗ Related/Fixed issues

https://github.com/FluentHub/FluentHub/labels/feature request Fixed #264

📄 Motivation and Context

[x] Add repositories searching request/response
[x] Add code searching request/response
[ ] Add commits searching request/response
[x] Add issue searching request/response
[ ] Add discussions searching request/response
[ ] Add packages searching request/response
[ ] Add marketplace searching request/response
[ ] Add topics searching request/response
[ ] Add wiki searching request/response
[x] Add users searching request/response

Add search functionality
📸 Assets (if appropriate):

Looks like everything got ported over

When I finish this PR, I will close and you could re-open this branch's PR. By doing so, you can be the author of this branch (this called signing off). Actually I tried to do so but you broke my change.

Octokitv3 API is always Incompetent. I had to implement getting more information from gained data by Octokit with Octokit.GraphQL. and I have to do as well. when retrieving searched issues, they doesn't contain their own repository  information.

@arihant2math Done first step. Can you open a PR with this branch?

@DeveloperWOW64 Review.

@DeveloperWOW64 Thank you full review!


Error in RubyMine 2017.1 RC

This is from the upcoming RubyMine version, but whatever's going on here might impact other products as the update...  Error at startup with plugin active (version 1.2)
tried to access method com.intellij.openapi.fileEditor.impl.EditorWindow.findEditorIndex(Lcom/intellij/openapi/fileEditor/impl/EditorComposite;)I from class com.tobszarn.intellij.plugin.activetabhighlighter.TabHighlighterFileEditorListener

RubyMine 2017.1
Build #RM-171.3780.26, built on March 9, 2017
JRE: 1.8.0_112-release-736-b11 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.4.0-53-generic
NB: I also have 'Material Theme UI Fork' plugin from the JetBrains plugin repo installed.  Version <IP_ADDRESS>.
ActiveTabHighlighter stack trace.txt

Getting myself EAP version to see what's going on.

API changed methods visibility.  Outlining a fix.

:+1: Thanks !!   I've got pinky RubyMine editor tabs...  FWIW, it works fine alongside the "Material Theme UI Fork" plugin.


Feature request: support notifcations in general / across all configured accounts simultaneously

Notifications are the one thing keeping me from using this instead of the browser.

Notifications are sent from a page in browser window based on current logging-in user. So, if we implement notifications across all accounts, two ways to implement came in mind:

Make webviews for each accounts and open their page in the webviews. But this would consume much memory
Connect to each accounts streams via stream API. This would be more feasible than 1. but it needs some implementation to connect streams.

The 1. is not acceptable. I think 2. would be feasible, but I'm not sure I can spare the time to implement. But your suggestion is reasonable. So I want to remain this issue open and when I have a  time to try, I'll be able to look this issue again.


Docker Hub image won't start

When the Docker Hub image (andybavier/xos) is run, it fails with the following:
could not access private key file "/etc/ssl/private/ssl-cert-snakeoil.key": Permission denied
I thought the Dockerfile accounted for this already, but clearly something is still amiss.  Here's a link to a potential fix:
https://github.com/kartoza/docker-postgis/pull/10/files

There is a new system for building XOS containers.  See https://hub.docker.com/r/xosproject/


Initial merge of Rust Repl and associated changes upstream

I have a number of additional repl-related changes to drop in, but I was thinking it makes sense to do them as another PR, since I think we worked through the issues in this one.
What do you think?


AAD 2.14 bugs (in implementation instructions and tool)

🐛 Summary
In an agency environment using AAD PIM, we encountered several bugs with the implementation of AAD 2.14.
To reproduce
Steps to reproduce the behavior:

Run ScubaGear on Agency environment
Review results of AAD 2.14

Expected behavior
The agency is using Privileged Access Groups to manage AAD PIM.  This means that PIM is done wirth respect to whether the user joins the group or not, but the group has a permanent assignment to the role.  The tool flags this as being managed outside of PIM.
Additionally, the tool and implementaton guide requires that assignments are active for max 15 days.  This is likely too short as it would require renewing break glass membership and Privileged Access Group membership biweekly, which is not realistic.  This should be relaxed to a more realistic value.
Any helpful log output or screenshots
Please contact me offline for detailed logs.

We are changing policy 2.14 in Emerald. See #254 and #256 (which contains the text of the new policy) for details.
I think that might impact this issue.

Yes I think those issues address several of these points.  The privileged access groups appears to still need a tool fix.  We can rescope this based upon the work done in those two issues.

After reviewing the issues above, below is a summary of findings:

Policy 2.14 fails for permanent assignments of "Global Administrator" in all cases (breakglass accounts, allowable exclusions) #256 bullet one addresses this bug.
Believe one question remaining is the use of Groups for PIM.  Section 1.2 (Assumptions") suggests using a group named "emergency users", however, the CIS does not suggest using a group, but creating generic "emergency accounts". Question for this issue: Should the baselines be modified to describe PIM for groups? Currently, the use of groups to access privileged roles is not well defined in the policy and doesn't address the just-in-time aspect of group membership. There is a new feature in preview for assigning JIT membership or ownership of groups. See https://learn.microsoft.com/en-us/azure/active-directory/privileged-identity-management/groups-assign-member-owner. As this is still in Preview, should this issue be in Emerald or later?

On the groups for PIM feature:

Not suggesting we recommend using the feature as a baseline since its in preview, but I do think it would be helpful to update the rego to not flag it as a policy violation if being used
CISA OCIO is using it, I believe per a recommendation from Microsoft.  I'm not exactly sure why--I am trying to find out.
On timeline, if it can't be had in emerald I think its ok--I would just request we document that there can be false positive violations for this control when using PIM for Groups.

I'm currently testing the PIM for Groups feature to determine how it specifically impacts each of the Azure AD policies related to PIM and will follow-up with a separate comment for that. This comment is to provide a reference for how the PIM for Groups feature works and its relationship to role assignments within the context of the highly privileges roles we include in the security baseline. In the example below I demonstrate how to bring a group into management by PIM, how to assign a user to a PIM group as eligible and how to assign the PIM group to privileged roles as eligible. Then I show how when the test users logs in, once he activates his group membership, he then sees two new privileges roles which he can then activate.
In Azure AD, I created Ted's PIM Test Group
In PIM Manage > Groups, I clicked Discover Groups and brought Ted's PIM Test Group into management under PIM

In PIM Manage > Groups, I clicked Ted's PIM Test Group and then Manage > Assignments > Eligible Assignments, I assigned test user Alex.

In PIM Manage > Azure AD Roles > Manage > Assignments > Eligible Assignments, I assigned Ted's PIM Test Group to the Exchange Administrator and Sharepoint Administrator highly privileges roles.

I logged in as Alex and took a look at his available role assignments.

I then activated Alex's membership in Ted's PIM Test Group
Once I activated his group membership, when I clicked on his My Roles page, I could see the Exchange Administrator and Sharepoint Administrator as eligible assignments (they were not there before I activated his group membership)

Thanks.  There is also a use case where the the group has a permanent active assignment to the role, but no permanent membership, using PIM to transiently join the group.  You may want to note that use case as well (versus this you note case which is almost like a double-level PIM)

Please see #376 for a detailed impact analysis on five Azure AD policies (and ScubaGear code) that I believe may be impacted by the PIM for Groups feature. This includes the case mentioned by @gdasher where " the group has a permanent active assignment to the role, but no permanent membership, using PIM to transiently join the group."

This is a response to the two comments left when this issue was originally opened. I want to be sure we adjudicate them.

The agency is using Privileged Access Groups to manage AAD PIM. This means that PIM is done with respect to whether the user joins the group or not, but the group has a permanent assignment to the role. The tool flags this as being managed outside of PIM.

@gdasher Can you clarify what you mean by "the tool flags this as being managed outside of PIM"? Currently the tool will only flag entries in the PIM "Active" assignments API as "SHALL NOT occur outside of a PAM system" when the active assignment entry has a Start Time of null and and End Time of Permanent. This occurs for example if an admin uses the Microsoft 365 Admin Center to directly assign a user or a group to a role instead of using the PIM assignment portal. Maybe we can update the instructions so that if an agency is using PIM for Groups, they make the permanent active assignment of the group to a role using the PIM for Roles portal instead of making the assignment externally (via the M365 Admin Center or cmdlet)? I think this will ensure that the active assignment entry will have a defined Start Time (will not be null) and thus the agency won't fail this specific policy check.

Additionally, the tool and implementation guide requires that assignments are active for max 15 days. This is likely too short as it would require renewing break glass membership and Privileged Access Group membership biweekly, which is not realistic. This should be relaxed to a more realistic value.

We are getting rid of the 15 days check because the policy is no longer going to be checking for the PIM configuration setting "Allow permanent active assignment", therefore the check of # of days is OBE.

Per parking lot discussion, adjust this issue as appropriate (scope, split, etc) to at least address as a note in current ScubaGear implementation of the issue with PIM for Groups.

@ssatyapal123 I'm thinking that we might want to put a note in the policy items impacted by PIM for Groups and say something like "This policy will be augmented in the next release to include functionality provided by the PIM for Groups feature." See #376 for a list of the impacted policies.
It might be good to put a warning in the README file as well? Open to ideas.


Load Reporting Filter

July 2016 implementation of the load reporting filter. Featuring

An grpc_arg to enable load reporting, provided by grpc_arg grpc_load_reporting_enable_arg() in src/core/ext/load_reporting/load_reporting.h.
Much simplified mechanics: The user-provided function is now simply part of the filter translation unit. Its signature is void load_reporting_fn(const grpc_load_reporting_call_data *call_data), where its input argument corresponds to:

/** Call information to be passed to the provided LR callback. */
typedef struct grpc_load_reporting_call_data {
  const grpc_load_reporting_source source; /**< point of last data update. */

  /** Unique identifier for the channel associated with the data */
  intptr_t channel_id;

  /** Unique identifier for the call associated with the data. If the call
   * hasn't been created yet, it'll have a value of zero. */
  intptr_t call_id;

  /** Only valid when \a source is \a GRPC_LR_POINT_CALL_DESTRUCTION, that is,
   * once the call has completed */
  const grpc_call_final_info *final_info;

  const char *initial_md_string;  /**< value string for LR's initial md key */

  const char *trailing_md_string; /**< value string for LR's trailing md key */

  const char *method_name;        /**< Corresponds to :path header */
} grpc_load_reporting_call_data;

Bahavior
There are four events of interest in the lifetime of the filter. The source field indicates which one last updated the grpc_load_reporting_call_data instance.
Channel creation
The load_reporting_fn is invoked with a grpc_load_reporting_data_call instance with only channel_id set. All the other fields are zero/null.
Call creation
Same as previous point but now call_id also has a value.
Call destruction
The big one. In this case all fields are filled in. The initial_md_string and trailing_md_string correspond to the load-reporting-initial and load-reporting-trailing metadata keys, respectively.
Channel destruction
Once again, only the channel id is set. All other fields are zero/null.

@summerxyt FYI

no objections to this

@sreecha Requesting a quick review so that this can go in to make @bogdandrutu happy. Note @ctiller 's previous comment, which to me sounds similar to an LGTM :)
I've made some minor changes since to remove code that we now know won't be used (due to LR filter's redesign in progress).


Can't deploy

Describe the bug
I apologize for not providing a clear explanation earlier. Let me summarize the error concisely:
The build process is failing due to an import error in the main application file. Specifically:
Error location: src/main.tsx, line 3
Error message: "default" is not exported by "src/App.jsx", imported by "src/main.tsx"
This error indicates that the App component in src/App.jsx doesn't have a default export, but src/main.tsx is trying to import it as if it does.
To fix this, we need to ensure that App.jsx exports its component as a default. Let's make that change:
Fix App.jsx export
src/App.jsx
Now that we've added the default export to App.jsx, let's try deploying the application again:
Retry Deployment to Netlify
npx vite build
netlify
Let's wait for the deployment process to complete and see if this resolves the issue.
There was an error processing your request
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-ofupjk
Steps to reproduce
Click deploy
Expected behavior
Deploy
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 334336595,
  "usedJSHeapSize": 307648963,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = LittleNuggets
Chat ID = 8ef38fd22ab4

Additional context
Error:
There was an error processing your request

we're aware of this issue it's due to netlify rate limiting us we're trying to resolve the issue. Closing this issue in favour of tracking at https://github.com/stackblitz/bolt.new/issues/365 instead.


[Backport TC-349] update 2.0.x build scripts

updates build scripts to work more cleanly with Jenkins

merged, please close


Minecraft 1.20.4 support.

Hi,
WallMountLocation was renamed to BlockFace.
This will fix the /geodesy analyze command issue with 1.20.4 versions.

Thank you ❤ I will merge this soon, I need to take a good look at the version support situation.

Hi, any chance this is going to get published soon? Github actions seems to not have any build available to download regarding this change.
Thanks!

Hi, any chance this is going to get published soon? Github actions seems to not have any build available to download regarding this change.
Thanks!

Hi @ruben2s,
I think you could clone this repo and build it yourself until @kosma has done all required version support checks, etc.

Fixed in 61b9264. Couple of notes:

The offending change wasn't the rename of WallMountLocation to BlockFace (that's a Yarn named rename, those are harmless), it was a hard to explain intermediary rename of Blocks.PUMPKIN from field_10261 to field_46282. Go figure.
The change was done in 1.20.3 but the mod works on both .3 and .4 now.


Recent RunPod Axolotl error

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
I ran Axolotl around two days ago and it worked fine. 8xH100 SXM using RunPod's Axolotl Jupyter template.
Current behaviour
When I ran the same config today, it gave me this error:
RuntimeErrorRuntimeErrorRuntimeError: : : CUDA error: CUBLAS_STATUS_ALLOC_FAILED when calling cublasCreate(handle)CUDA error: CUBLAS_STATUS_ALLOC_FAILED when calling cublasCreate(handle)CUDA error: CUBLAS_STATUS_ALLOC_FAILED when calling cublasCreate(handle)

Steps to reproduce

Use RunPod's Axolotl Jupyter template
Use 8xH100 SXM in Secure or Community
Run training
Wait for it to load the model
It doesn't

Config yaml
base_model: ChaoticNeutrals/Poppy_Porpoise-0.72-L3-8B
model_type: LlamaForCausalLM
tokenizer_type: AutoTokenizer

load_in_8bit: false
load_in_4bit: true
strict: false
sequence_len: 8192
bf16: auto
fp16:
tf32: false
flash_attention: true
special_tokens:
  bos_token: <|begin_of_text|>
  pad_token: <|end_of_text|>
  eos_token: <|end_of_text|>

# Data
datasets:
  - path: TheDrummer/siayn-v6
    type: customllama3 # src/axolotl/prompt_strategies
warmup_steps: 30

# save_safetensors: true

# WandB
wandb_project: llama-3some
wandb_entity:

# Iterations
num_epochs: 2

# Evaluation
val_set_size: 0.0125
evals_per_epoch: 4
eval_table_size:
eval_max_new_tokens: 128
eval_sample_packing: false
eval_batch_size: 1

# LoRA
output_dir: ./Llama-3some-8B-v2-Workspace
adapter: lora
lora_model_dir:
lora_r: 64
lora_alpha: 16
lora_dropout: 0.05
lora_target_linear: true
lora_fan_in_fan_out:
lora_target_modules:

# Sampling
sample_packing: true
pad_to_sequence_len: true

# Batching
gradient_accumulation_steps: 1
micro_batch_size: 4
gradient_checkpointing: true
gradient_checkpointing_kwargs:
   use_reentrant: true

# Optimizer
optimizer: paged_adamw_8bit
lr_scheduler: cosine
learning_rate: 0.0002

# Misc
train_on_inputs: false
group_by_length: false
early_stopping_patience:
local_rank:
logging_steps: 1
xformers_attention:
debug:
weight_decay: 0
fsdp:
fsdp_config:

# Checkpoints
resume_from_checkpoint:
saves_per_epoch: 2

Possible solution
Does the runpod / docker template use the latest commit? We can narrow it down to the last 1 to 2 days.
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
main-latest
axolotl branch-commit
main-latest
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Tried it again today on a 8x H100 SXM
Traceback (most recent call last):
  File "/root/miniconda3/envs/py3.10/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/root/miniconda3/envs/py3.10/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/workspace/axolotl/src/axolotl/cli/train.py", line 59, in <module>
    fire.Fire(do_cli)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/fire/core.py", line 143, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/fire/core.py", line 477, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/fire/core.py", line 693, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/workspace/axolotl/src/axolotl/cli/train.py", line 35, in do_cli
    return do_train(parsed_cfg, parsed_cli_args)
  File "/workspace/axolotl/src/axolotl/cli/train.py", line 53, in do_train
    dataset_meta = load_datasets(cfg=cfg, cli_args=cli_args)
  File "/workspace/axolotl/src/axolotl/cli/__init__.py", line 403, in load_datasets
    train_dataset, eval_dataset, total_num_steps, prompters = prepare_dataset(
  File "/workspace/axolotl/src/axolotl/utils/data/sft.py", line 57, in prepare_dataset
    with zero_first(is_main_process()):
  File "/root/miniconda3/envs/py3.10/lib/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/workspace/axolotl/src/axolotl/utils/distributed.py", line 68, in zero_first
    barrier()
  File "/workspace/axolotl/src/axolotl/utils/distributed.py", line 34, in barrier
    dist.barrier()
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/distributed/c10d_logger.py", line 47, in wrapper
    return func(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/distributed/distributed_c10d.py", line 3696, in barrier
    work = default_pg.barrier(opts=opts)
RuntimeError: CUDA error: uncorrectable ECC error encountered
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.

Tried it on 8x H100 PCIE

Found it unusual that it got stuck on this part:
[2024-05-08 14:11:28,264] [INFO] [axolotl.load_tokenized_prepared_datasets:410] [PID:3641] [RANK:0] merging datasets

Been waiting for 10 minutes. I'm killing it.

A different error for 1xH100 SXM
  warnings.warn(
/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/bitsandbytes/autograd/_functions.py:322: UserWarning: MatMul8bitLt: inputs will be cast from torch.bfloat16 to float16 during quantization
  warnings.warn(f"MatMul8bitLt: inputs will be cast from {A.dtype} to float16 during quantization")
cuBLAS API failed with status 15
A: torch.Size([49152, 4096]), B: torch.Size([4096, 4096]), C: (49152, 4096); (lda, ldb, ldc): (c_int(1572864), c_int(131072), c_int(1572864)); (m, n, k): (c_int(49152), c_int(4096), c_int(4096))
Traceback (most recent call last):
  File "/root/miniconda3/envs/py3.10/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/root/miniconda3/envs/py3.10/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/workspace/axolotl/src/axolotl/cli/train.py", line 59, in <module>
    fire.Fire(do_cli)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/fire/core.py", line 143, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/fire/core.py", line 477, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/fire/core.py", line 693, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
  File "/workspace/axolotl/src/axolotl/cli/train.py", line 35, in do_cli
    return do_train(parsed_cfg, parsed_cli_args)
  File "/workspace/axolotl/src/axolotl/cli/train.py", line 55, in do_train
    return train(cfg=cfg, cli_args=cli_args, dataset_meta=dataset_meta)
  File "/workspace/axolotl/src/axolotl/train.py", line 170, in train
    trainer.train(resume_from_checkpoint=resume_from_checkpoint)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/transformers/trainer.py", line 1780, in train
    return inner_training_loop(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/transformers/trainer.py", line 2118, in _inner_training_loop
    tr_loss_step = self.training_step(model, inputs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/transformers/trainer.py", line 3036, in training_step
    loss = self.compute_loss(model, inputs)
  File "/workspace/axolotl/src/axolotl/core/trainer_builder.py", line 493, in compute_loss
    return super().compute_loss(model, inputs, return_outputs=return_outputs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/transformers/trainer.py", line 3059, in compute_loss
    outputs = model(**inputs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/accelerate/utils/operations.py", line 822, in forward
    return model_forward(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/accelerate/utils/operations.py", line 810, in __call__
    return convert_to_fp32(self.model_forward(*args, **kwargs))
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/amp/autocast_mode.py", line 16, in decorate_autocast
    return func(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/peft/peft_model.py", line 1395, in forward
    return self.base_model(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/peft/tuners/tuners_utils.py", line 179, in forward
    return self.model.forward(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/transformers/models/llama/modeling_llama.py", line 1196, in forward
    outputs = self.model(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/workspace/axolotl/src/axolotl/monkeypatch/llama_attn_hijack_flash.py", line 809, in llama_model_forward
    layer_outputs = torch.utils.checkpoint.checkpoint(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/_compile.py", line 24, in inner
    return torch._dynamo.disable(fn, recursive)(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/_dynamo/eval_frame.py", line 328, in _fn
    return fn(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/_dynamo/external_utils.py", line 17, in inner
    return fn(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 451, in checkpoint
    return CheckpointFunction.apply(function, preserve, *args)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/autograd/function.py", line 539, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/utils/checkpoint.py", line 230, in forward
    outputs = run_function(*args)
  File "/workspace/axolotl/src/axolotl/monkeypatch/llama_attn_hijack_flash.py", line 803, in custom_forward
    return module(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/workspace/axolotl/src/axolotl/monkeypatch/llama_attn_hijack_flash.py", line 902, in forward
    hidden_states, self_attn_weights, present_key_value = self.self_attn(
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/workspace/axolotl/src/axolotl/monkeypatch/llama_attn_hijack_flash.py", line 417, in flashattn_forward
    query_states = self.q_proj(hidden_states)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/peft/tuners/lora/bnb.py", line 217, in forward
    result = self.base_layer(x, *args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/accelerate/hooks.py", line 166, in new_forward
    output = module._old_forward(*args, **kwargs)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/bitsandbytes/nn/modules.py", line 687, in forward
    out = bnb.matmul(x, self.weight, bias=self.bias, state=self.state)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/bitsandbytes/autograd/_functions.py", line 562, in matmul
    return MatMul8bitLt.apply(A, B, out, bias, state)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/torch/autograd/function.py", line 539, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/bitsandbytes/autograd/_functions.py", line 401, in forward
    out32, Sout32 = F.igemmlt(C32A, state.CxB, SA, state.SB)
  File "/root/miniconda3/envs/py3.10/lib/python3.10/site-packages/bitsandbytes/functional.py", line 1967, in igemmlt
    raise Exception('cublasLt ran into an error!')
Exception: cublasLt ran into an error!

@drummerv I don't know that the " RunPod's Axolotl Jupyter template" is the "official" correct template. This direct link should get you the correct image (https://runpod.io/gsc?template=v2ickqhz9s&ref=6i7fkpdz), although there is a bug w runpod using that link, so for now you can use this link: https://www.runpod.io/console/explore/v2ickqhz9s?ref=6i7fkpdz

@winglian Fixed it. I just had to rollback to an older commit:
git checkout 132eb740f036eff0fa8b239ddaf0b7a359ed1732

thanks, there are quite a few changes since then! Just going to drop this here so I can remember to look through the changeset later: https://github.com/OpenAccess-AI-Collective/axolotl/compare/132eb740f036eff0fa8b239ddaf0b7a359ed1732...main

@drummerv If it helps, I also just ran into this cuBLAS API failed with status 15 on a h100, and while going back to an old commit did not fix this (I tried probably 15 containers from around that time period), loading in 16 bit instead of 4 or 8 bit solved this issue (on main@HEAD).
This issue on alpaca-lora seems related: https://github.com/tloen/alpaca-lora/issues/174

Closing this issue as we've run tests on latest runpod axolotl template using author's configuration file on 1x, 4x, and 8xH100 SXM respectively and found no error. Looks like the aforementioned issue is solved.


[Feature Request] better chat formatting colors

So it seems like the vane-admin chat formatting forces all chat messages to have an aqua sender name and gray text. Gray is harder to read so it would be better if white was the default. Also, the chat should support team colors (from /team) on the sender name instead of just aqua. It would be great if these colors could be customized.

On Java I personally find it a lot more readable (which is why it exists I guess), but of course it's a matter of taste. I really didn't want to introduce a lot of complexity here since then users want all kind of stuff (permissions levels, colored prefixes, special overrides, database queried names), and I think this is not something that should be part of vane.
If you want a specific format, just disable vane's internal formatter vane-admin/config.yml -> chat_message_formatter and use a more sophisticated plugin.


No way to determine conversation address for media

With the export only supplying the datetime in the filename, there is no way to determine which conversation the media was a part of.

Operating system: Ubuntu
Build version (signal-back --version): signal-back v0.1.6-dirty, proto commit: d6610f0

Detailed description
Pretty straight forward, files are named as:
1522082357628.gif

When it would be better if they used <address>_<date>.<ext> such as:
+15555555555_1522082357628.gif

Full relevant output
n/a

This is doable and I can have it working, but after playing with it a bit I'd like a more solid foundation for it. Definitely coming.


Add ClusterAutoscaler versions that support ProvisiongRequest to the site

There is no mention of what versions of ClusterAutoscaler supports the Provisioning Admission Check Controller feature.
There is no mention of what versions of ClusterAutoscaler supports the Provisioning Admission Check Controller feature.
What would you like to be added::
The site should specify what versions of ClusterAutoscaler supports the Provisioning Admission Check Controller feature.
Why is this needed:
There is no mention of what versions of ClusterAutoscaler supports the Provisioning Admission Check Controller feature. Users who try this feature with earlier versions of ClusterAutoscaler who find that the feature does not work.

Duplicate of #1665


How to update in angular-base-apps from foundation-apps

Hi,
It would be really appreciated if you guide me how to update my current app project created with foundation-apps to angular-base-apps. I have Foundation CLI version 2.1.0.
Thanks

@GSolari79 check out the migration guide: http://base-apps.github.io/angular-base-apps/latest/#!/migration


Scenario Results: Long-Term Risk

My results are all 1. Is that correct?

This is the call i am using to get that value.

it is possible. is this based on the default data?
I have tests of AEP, LTEP, and assurance, but they're at a lower level. And by the way, you can get the result out of ScenarioResults. The following is the ScenarioREsults method to get this.
    public double LongTermExceedanceProbability(int impactAreaID, int thresholdID, int years)
    {
        return GetResults(impactAreaID).LongTermExceedanceProbability(thresholdID, years);
    }

Also would you please change long-term risk to long-term exceedance probability?

I updated the menu item and the column header:

I am using the default frequency and rating curves.

I updated the menu item and the column header:

thank you!!

adding the default regulated-unregulated to the scenario makes the results more interesting