Extract bitshift helper code, Frame cleanup

#2773
Extracted all non-trivial bitwise operations from the Http2Frame classes. I also fixed several issues where it was reading 31 bits but writing 32 bits and stomping on adjacent (rarely used) fields.
There was an error in Data and Headers where reading the padding length or priority weight fields could read off the end of an invalid frame. I normalized everything to read from the restricted Payload Span so everything stays in bounds.
BinaryPrimitives are modestly faster and more consistent than the old code. Not to mention a lot cleaner.
             Method |     Mean |     Error |   StdDev |     Op/s | Scaled | ScaledSD | Allocated |
------------------- |---------:|----------:|---------:|---------:|-------:|---------:|----------:|
 GetUInt32AsBitwise | 21.80 us | 1.1883 us | 3.466 us | 45,861.5 |   1.00 |     0.00 |       0 B |
  GetUInt32AsBinary | 19.98 us | 0.6416 us | 1.656 us | 50,061.2 |   0.94 |     0.17 |       0 B |

Updated. Test failures are covered by #2831


Can't update from Windows Terminal 1.7 to 1.12 - "Windows Terminal is already installed"

Windows Terminal version
1.7.1033.0
Windows build number
10.0.19041.0
Other Software
I'm trying to update to Windows Terminal 1.12.10733.0 (Win10 version: Microsoft.WindowsTerminal_Win10_1.12.10733.0_8wekyb3d8bbwe.msixbundle, from this release)
Steps to reproduce

Install Windows Terminal 1.7.1033.0
Try to install Windows Terminal 1.12.10733.0

Expected Behavior
I should be able to update Windows Terminal
Actual Behavior
Windows won't let me update Windows Terminal:

It says "A newer version of Windows Terminal is already installed." (which is false).
Notes
In this case I'm not sure how this could be solved other than uninstalling the current version of Windows Terminal and installing the newer version fresh. I'm not sure how to keep my configuration intact if I uninstall the app though which is why I haven't tried it yet.

Hmm. This is a crazy theory, so hear me out. I think there's an even newer version of terminal than 1.12.10733 in the Store. I'm wondering if secretly, the Store downloaded that version, has got it all staged, but is patiently waiting for you to stop using the Terminal before it installs it.
I know this is annoying, but does restarting your machine help? That might close out any running Terminal instances, make room for the store to do it's thing, and maybe when you boot back up you'll have the new one? It's a crazy theory, for sure.

secretly, the Store downloaded that version, has got it all staged, but is patiently waiting for you to stop using the Terminal before it installs it.

That would be funny considering my Store can't connect to the Internet. Also Windows Terminal isn't running.

does restarting your machine help?

I'll try anyway, since Windows routinely gets all sorts of insane issues that only restarting can fix.

FWIW, the only state the Terminal keeps around (on version 1.7) is the settings.json file. If you want to go the manual uninstall route, just copy that file out somewhere before you uninstall 😉

Thanks, I'll keep that in mind!

Looks like my version of Windows is not supported after all (#11371): Ask the developer for a new app package. This package may conflict with a package already installed, or it depends on things not installed here (package dependencies), or is made for a different architecture (0x80073CF3)
Oh well, I'll just go back a release. Installing 1.11 worked!

This is pretty surprising, though! 1.12 should continue to work on your version of windows (as should 1.13! You're on 10.0.19041+, which is the latest public version of Windows 10).
I'm gonna reopen this to track it, since it might be a more widespread issue. :)

Before installing Terminal 1.12, can you try installing the Microsoft.VCLibs package for your architecture?

Looks like that was the problem!

Isn't 20H2 / 22H2 or something the latest version

Something like that! 20H1 is "The version of Windows released in the first half of 2020". It's been "updated" (via service packs) a couple times to 20H2, 21H1, ... but that part doesn't truly matter. I always get my marketing names mixed up, so all we usually care about is build numbers. You're on build number 10.0.19041 or higher, which is the "baseline" build number[1] of the most recent actual version of Windows 10 that we care about.
[1]: The service packs update it to 19042, 19043 and beyond but those are actually a trick. The binaries on-disk are still numbered 19041. It's all sorts of strange!
I'll close this out as I think we've understood/addressed the main issue. Thanks!

I think we've understood/addressed the main issue.

Just to verify, the installer thinking that the older version was newer was caused by the dependency issue, right? That seems totally weird, but I guess on Windows anything can happen.

I believe so! That thing isn't really great at error messages... :D


chore(main): release 0.4.0

:robot: I have created a release beep boop
0.4.0 (2022-08-19)
Features

configurable network and subnet for PSC NEG (9e75b21)

Bug Fixes

remove issue reference from PSC NEG readme (027277d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/apigee/terraform-modules/releases/tag/v0.4.0 :sunflower:


Feature/crete common repo

@femust - if you've tested this with a clean install (just a clean catkin workspace), then I am good to merge


Define q0 as neutral if the robot doesn't have a SRDF

Without this rule, I triggered an error in some hector-based examples defined in Crocoddyl.

Hi ! This project doesn't usually accept pull requests on master. If this wasn't intentionnal, you can change the base branch of this pull request to devel (No need to close it for that). Best, a bot.


More than one tab doesnt work properly

Type: Bug

Create New Query Tab: CONNECTIONS -> SERVERS -> (Right Click Existing Connection) -> New Query
Create Second New Query Tab: Command + N

Logs from renderer.log:
2023-11-14 08:36:09.886 [info] Creating new connection untitled:SQLQuery_3
2023-11-14 08:36:09.887 [info] Adding connection untitled:SQLQuery_3
2023-11-14 08:36:09.887 [info] Successfully added connection untitled:SQLQuery_3
2023-11-14 08:36:09.933 [info] GitHub Copilot extension is not installed, so contextualization is not needed.
2023-11-14 08:36:09.933 [info] GitHub Copilot contextualization is disabled, so contextualization is not needed.
2023-11-14 08:36:09.933 [info] Contextualization is not needed because the GitHub Copilot extension is not installed and/or contextualization is disabled.
2023-11-14 08:36:21.143 [error] h.defaultValue?.toLocaleLowerCase is not a function: TypeError: h.defaultValue?.toLocaleLowerCase is not a function
at vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:219:9414
at Array.forEach ()
at m.getConnectionOptionsList (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:219:8919)
at m.getNonDefaultOptionsString (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:219:9523)
at ie.getNonDefaultOptions (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2403:76999)
at i.getTitle (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1531:93688)
at X.computeTabLabels (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3350:58668)
at X.handleOpenedEditors (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3350:48344)
at X.openEditor (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3350:48000)
at ie.doShowEditor (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3453:17375)
at ie.doOpenEditor (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3453:16781)
at ie.openEditor (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3453:15477)
at ne (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3350:53383)
at HTMLDivElement. (vscode-file://vscode-app/Applications/Azure%20Data%20Studio.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3350:53626)
at _ZoneDelegate.invokeTask (/Applications/Azure Data Studio.app/Contents/Resources/app/node_modules.asar/zone.js/dist/zone.js:443:35)
at Zone.runTask (/Applications/Azure Data Studio.app/Contents/Resources/app/node_modules.asar/zone.js/dist/zone.js:214:51)
at ZoneTask.invokeTask [as invoke] (/Applications/Azure Data Studio.app/Contents/Resources/app/node_modules.asar/zone.js/dist/zone.js:525:38)
at invokeTask (/Applications/Azure Data Studio.app/Contents/Resources/app/node_modules.asar/zone.js/dist/zone.js:1727:22)
at globalCallback (/Applications/Azure Data Studio.app/Contents/Resources/app/node_modules.asar/zone.js/dist/zone.js:1758:31)
at HTMLDivElement.globalZoneAwareCallback (/Applications/Azure Data Studio.app/Contents/Resources/app/node_modules.asar/zone.js/dist/zone.js:1794:20)
Extension version: 1.0.0
Azure Data Studio version: azuredatastudio 1.47.0 (c7c2b2f21505562d21972d4c135119d00806db4f, 2023-11-07T17:19:19.203Z)
OS version: Darwin arm64 23.0.0
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (10 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
5, 4, 3

Memory (System)
32.00GB (0.15GB free)

Process Argv

Screen Reader
no

VM
0%

I'm seeing the same issue as @stevenhaymanbamboohr since installing the most recent MySQL extension update.
For 8 of my 9 MySQL connections, I get this exception and the tab fails to operate.
For those 8 problem connections, the tab label continues to report Disconnected, even though the database is connected and it appears to function.

Opening an additional tab only partially works.  Ie. the tab is not seen in the Exporer sidebar; and, the tab is not visible

When I try to change tab, I get this error popup (same as the console message from Developer Tools, I think)

it seems the error comes from the defaultValue for port being a number...

this is the same but for a working MySQL connection.
The difference here is:

the working connection uses the default port 3306
the broken connections all use an alternate port (eg 44444 for ssh tunnelling)


URA-872 - raise FileNotFoundError on provided directory to upload not existing

This change is

Summary by CodeRabbit

New Features

Enhanced error handling for directory access in the file listing function, providing clearer feedback when a directory is not found.

Bug Fixes

Introduced a test to ensure that a FileNotFoundError is raised when an invalid directory is specified, improving reliability.

Documentation

Updated docstring for the file listing function to include details about the new exception handling.

⚠ Reminder to manually run end to end tests in https://github.com/eastgenomics/s3_upload/tree/main/tests/e2e

end to end tests passing locally:
jethro@jethro-T490:~/Projects/s3_upload$ python3 -m pytest tests/e2e/
=========================================================== test session starts ============================================================
platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.0.0
Test order randomisation NOT enabled. Enable with --random-order or --random-order-bucket=<bucket_type>
rootdir: /home/jethro/Projects/s3_upload
plugins: Faker-14.0.0, repeat-0.9.3, subtests-0.11.0, html-4.1.0, metadata-3.0.0, mock-3.11.1, cov-4.0.0, random-order-1.1.1
collected 23 items

tests/e2e/test_one_complete_run_upload_to_one_remote_path.py ......                                                                  [ 26%]
tests/e2e/test_regex_filtering_against_sample_names.py ......                                                                        [ 52%]
tests/e2e/test_resuming_partially_uploaded_runs.py ....                                                                              [ 69%]
tests/e2e/test_two_complete_runs_upload_to_two_remote_paths.py .......                                                               [100%]

============================================================ 23 passed in 8.18s ============================================================


[Feature Request] Add an option to not block all the comments

It is basically an option to have a blacklist of websites and allowing the rest. Also Adding an option to ignore/pause the rule temporarily for current tab (not changing the whitelist and blacklist for it).

The first request would mean redesigning the addon, since I wrote it assuming people would want to block most comments, and just let a few through.
The second request can be achieved just by clicking the speech bubble in the popup. That'll toggle comments for the current website.

If you want it to only be temporary, and then hide comments again when you refresh the tab, there's a setting for that. Just uncheck the "remember your setting for the site" option.

You are right, but there is a use case for wanting occasional turning off comment section too, like wanting to "save the page" but not the comments or just a sudden need to navigate the page faster and focusing on the main text.
I think a bit of it is just because I am new to it and not used to it, like yesterday I was wondering for couple of minutes why there is no comments on reddit pages I am viewing until remembering that I installed this plugin.
Thanks you anyway

It'd be kinda cool to add a setting you could enable, that indicates the page has hidden comments... to avoid the issue like you had on Reddit. Maybe when I have more time I'll tackle that.
In the meantime, I guess give it a little while to get used to it, and then if you think of anything that would make it more intuitive let me know.


release 4.0.0

next dev version: 4.0.1-SNAPSHOT

Update to mockito 2.20.1, adoption of api changes and deprecations

Done.
See https://oss.sonatype.org/content/repositories/releases/org/camunda/bpm/extension/mockito/camunda-bpm-mockito/4.0.0/
I am really sorry that I missed this Jan!

No worries


Centralize Pagerfanta on its own service

As I use Pagefanta on different parts of the application, it would be nice to centralize its generic logic into its own service that I can call when a pager is needed.

Solved by 0c34ca54905de8322339cdf70422b528138bb8b3


Initial GA work for digital twins

Regenerating the protocol layer, fixing our customized code to account for new method signatures in protocol layer, and adding the generated options classes to our convenience layer APIs
Also removing the local copy of the swagger that we had, now that the digital twins GA swagger is in the rest specs repo

/azp run net - digitaltwins - ci

/azp run net - digitaltwins - tests

/azp run net - digitaltwins - tests

@azabbasi for all the comments about matching the options names to the method that uses it (add vs create, for instance), we'll take that as a separate discussion with the rest of the team since it is a broader discussion worth having


Error when using with vite

I tried to import the the baloise DS using vue3 and vite without typescript following https://baloise-ui-library.vercel.app/components/essentials/vue.html#install
I did use the Vue.use(BaloiseDesignSystem, { useVite: false }) to load the plugin as indicated in the doc.
me@computer ~/project/ (git:main) $ npm run dev

> dev
> vite

Pre-bundling dependencies:
  vue
  @baloise/design-system-components-vue
(this will be run only when your dependencies or config have changed)

  vite v2.3.8 dev server running at:

  > Local: http://localhost:3000/
  > Network: use `--host` to expose

  ready in 277ms.

[@vue/compiler-sfc] <script setup> is still an experimental proposal.
Follow its status at https://github.com/vuejs/rfcs/pull/227.

[@vue/compiler-sfc] When using experimental features,
it is recommended to pin your vue dependencies to exact versions to avoid breakage.

12:32:50 AM [vite] warning:
<EMAIL_ADDRESS>7221|      return module[exportName];
7222|    }
7223|    return import(
   |                  ^
7224|      /* webpackInclude: /\.entry\.js$/ */
7225|      /* webpackExclude: /\.system\.entry\.js$/ */
The above dynamic import cannot be analyzed by vite.
See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning.

  Plugin: vite:import-analysis
  File: Users/me/project/node_modules/.vite/@baloise_design-system-components-vue.js?v=8639cb5e

Hi @gagarine
I just updated the docu, of course you need to set useVite: true :-)
However, for the warning I created a pull request for the stencil team.
See https://github.com/ionic-team/stencil/pull/2861
I hope this answers your question
Cheers, Gery


prefer-stateless-function good or bad?

Hey, I've been writing ui components based on prefer-stateless-function. Unfortunately, i just recalled that stateless function does not support ref. I ended up refactoring all of my components to use classes since they probably need to support ref used by parent components. I understand that stateless function are more efficient and simpler but I feel like it should only be used when devs know the pitfalls of using them. Thoughts?

refs are generally a code smell - used minimally and by necessity. It would be far better to prevent ref usage than to allow it.

Hmm, I'm using it for stuff like Popovers that require a target, which works typically based on refs. Any advice on how to deal with those w/o refs?

I did more research and feels like there isnt any elegant solution:

Use a wrapper

class Ref extends Component {
  render() {
    return this.props.children
  }
}
// usage
<Ref ref={......}><Button /></Ref>

Cons: Dev has to import and use extra component to wrap.

Use a different prop name

const Button = ({ ref2, ...props }) => {
  return <button {...props} ref={ref2} />
}
// Usage
<Button ref2={.....} />

Cons: Non-conventional prop can be confusing.

Write a decorator based on 1.
Cons: Dev tools will look messy with extra layer above all components.

Things that require refs absolutely should expose a prop, like refCallback, that you can explicitly link to an internal ref - as opposed to just having consumers set their own ref prop.

Hmm, wouldn't that be unconventional to have libraries having their alternative versions of ref?

@khankuan it's far better to have an explicit API, rather than to have ref be an implicit one - ie, if that's a feature of your library, then refactoring from a class to an SFC becomes a breaking change.
ref is an escape hatch from React's control of the DOM - it's not a good thing, nor a "convention" that library authors should be worried about.

@khankuan We use ref callacks for onRequestFocus parameters in our UI library for accessibility if the app wants to prevent focus from jumping and then also for portal mounts (separate subtrees) to name to.
My suggestion is implement something like this:
this.props.onCalendarFocus(event, { direction, isCalendarFocused: false, ref: this.previousMonthRef });

@interactivellama my use case is on portals that need a ref to the target component.

Portals are now supported first-class in React itself.


Removed one screenshot

Per feedback from Shivas.

@jasonjoh,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/actionable-messages/images/yammer_configuration card.jpg
:white_check_mark:Succeeded

docs/actionable-messages/images/yammer_connected group.jpg
:white_check_mark:Succeeded

docs/actionable-messages/images/yammer_connected_group.jpg
:white_check_mark:Succeeded

docs/actionable-messages/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Keeping middle pane independent?

Hi,
I've got a couple of questions rather than issues. Hope you don't mind but just couldn't find a place where to ask these:

Resize

Is there a way to have 3 panes and allow to resize the left pane and the right pane independently without resizing the middle or left/right pane depending on which one is being resized.
This is what I have:

but the above resize the right pane and middle pane when I resize the left pane for example. When resizing the right pane, it is behaving as I'd like it. It resizes the right and content pane without changing the left pane. I can see why based on the above definition but ideally, I'd like to be something like this:

Where the "resizable-center-fix" only gets resized when either the left or right pane get resized. Hope this makes sense?

Are there events available? The reason I'm asking is that every time, a pane is resized, I'd like to save its size immediately to local storage so that I can restore it when my page is reloaded the next time the user opens my web app?

Hiding pane? Can a pane be hidden at run-time and if it is, will the other pane be adjusted accordingly? For example, imagine if I have a vertical split embedded in the left pane and I want to hide the bottom pane. Will the top pane stretch all the way to the bottom?

Thanks.
Thierry

Hi,
Sorry for the late reply. The 3 pane setup you described and hiding a pane to allow the other to fill the space isn't currently possible I'm afraid. Let me know if you still really need this and maybe I'll finally be able to get around to updating this haha
As for events, I've just added some in. I've added Resizable.resizingStarted and Resizable.resizingEnded which you can assign a function to that you want to run. Resizer.resizingStarted triggers whenever a resizer bar is clicked and Resizer.resizingEnded triggers on the next mouseup or touchend event. There's also Resizable.windowResized but this gets triggered continuously whenever the mouse is moved during resizing so it's not very helpful.
Here's how you could go about getting the sizes of all the windows after resizing.
Resizable.resizingEnded = () => {
  Resizable.activeContentWindows.forEach( window => {
    console.group(`${window.divId}`);
    console.log(`width = ${window.width}`);
    console.log(`height = ${window.height}`);
    console.groupEnd();
  })
}

Hope this at least helps a little.
Tom

Hi,
Sorry for the late reply. The 3 pane setup you described and hiding a pane to allow the other to fill the space isn't currently possible I'm afraid. Let me know if you still really need this and maybe I'll finally be able to get around to updating this haha
As for events, I've just added some in. I've added Resizable.resizingStarted and Resizable.resizingEnded which you can assign a function to that you want to run. Resizer.resizingStarted triggers whenever a resizer bar is clicked and Resizer.resizingEnded triggers on the next mouseup or touchend event. There's also Resizable.windowResized but this gets triggered continuously whenever the mouse is moved during resizing so it's not very helpful.
Here's how you could go about getting the sizes of all the windows after resizing.
Resizable.resizingEnded = () => {
  Resizable.activeContentWindows.forEach( window => {
    console.group(`${window.divId}`);
    console.log(`width = ${window.width}`);
    console.log(`height = ${window.height}`);
    console.groupEnd();
  })
}

Hope this at least helps a little.
Tom


optchange load_to_single_tablet tablet search algorithm fro…

…m random to round-robin
Proposed changes
pick #25256

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Want to improve loading time of images. And design of cards as this is not acc to page theme

Issue Type:

[x] Bug Report
[ ] Feature Request
[ ] Documentaion

Describe the bug

A clear and concise description of what the bug is.
Images are taking a lot more time to load than expected plus the card design is also not
according to the theme.

Possible solution

Describe the solution you thought of.
Want to improve the card design ACC to the theme. and also want to improve the load time.

Screenshots

If applicable, add screenshots to help explain your problem.

@sahilsaini110 Make the PR by tomorrow otherwise we will close this issue.


Make source-able in bash 3.2

This will allow the script to be sourced by the default bash distro on
macOS, which is necessary for homebrew

Interesting. Didn't know hyphens weren't valid in function names in bash 3.
Thanks!


unify FITC and varDTC in Shogun

These two methods are closely related. It will be great if we unify these two methods. I will post my Matlab code soon.
Reference:
http://www.shogun-toolbox.org/api/latest/classshogun_1_1CVarDTCInferenceMethod.html
http://www.shogun-toolbox.org/api/latest/classshogun_1_1CFITCInferenceMethod.html

See also this https://arxiv.org/abs/1606.04820


feat(Arbitrum): CW-17268 add new USDC for arbitrum

Checklist:

README.md includes:

[ ] The details of signing data and transaction data, this includes parameters.
[ ] Official docs or white paper.
[ ] Website or api can query assets and broadcast transaction.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Task linked: CW-17268 [SDK] 新增 USDC 簽章


metadata: avoid unwrapping when parsing a playlist

Fixes #845

Thanks for your first contribution! ❤
Looks good to me -- those CI errors aren't due to your work.
Can you also update the changelog?

Sure, pushed the updated changelog. Let me know if it's fine like that.

I touched the changelog up a bit to clarify the actual behaviour of the fix, then merged this one. Thanks!


Add ssh server functionality

This adds a -server flag which will spin up an ssh server that executes the slides bubbletea application upon each ssh session.
👋 hey apologies for the delay in this PR but here's what I have so far just as a first step in getting ssh functionality! It's very bare bones but intentional because I'm not sure how y'all wanted this functionality to look like.

I saw this recent wish commit https://github.com/charmbracelet/wish/commit/3a1ac79fc002f0b5976cf0fa160fad9098c810a2 and figured we probably want this middleware style so we can eventually send messages to the bubbletea program.
Uses -server flag since I wasn't sure how you wanted the cli to look like. Should we do something similar to https://github.com/maaslalani/gambit/pull/3 where it uses coral to split the cli into subcommands? (ex. slides serve file.md -port 2222 ...)
I added a server struct similar to the PR for gambit as I imagine we'll extend this later on.
I didn't attempt to code up how you can have "viewers" - I think there are so many options/ideas and I'm not sure I can handle that part of the coding with my current golang skills 😆

One idea for the ssh functionality is to either require a password (slides serve file.md -password [...] -port 2222 ...)  or if it's not given, print out a random password. Then when an ssh session connects with the right password, that session will get presenter rights. Other ssh sessions will automatically be viewers. Thoughts?

Hey! This looks super awesome! I'll test it out soon, but thank you so much for this PR, can't wait to have ssh functionality in slides 🎉

Hey, so I think that -server shouldn't be a flag but rather we should have slides serve as the entry point and also be able to pass in the slides through stdin like
# this
slides serve file.md

# or
cat file.md | slides serve

# or
curl https://raw.githubusercontent.com/maaslalani/slides/main/examples/slides.md | slides serve

so that people don't need to have the slides available on the machine they are hosting the server on.

thanks for taking a look and I totally agree! I followed the gambit PR and added a serve subcommand


Code fragment in registration form

Hello, thank you very much for improving the registration form recently! It looks nice!
But I found a bug on the students registration form, right after „Erklärung über Vorstrafen“.
I marked the code snippet showing in the screenshot below.

Thanks for the kind words and great catch! Should be fixed in a minute!


Conditional Merges [REQUEST]

Is your feature request related to a problem? Please describe.
When we ingest datatypes from different sources, we may run into the issue where we ingest data from an old source and one from a recent source with different properties. The current implementation builds a merge query which simply overwrites the properties on matched nodes based on which record was ingested first. I would like for there to be a way to conditionally change properties on a node.
Describe the solution you'd like
When I create an interpretation within my pipeline, I would like to declare the following:
merge_condition: latest # Where we could have different options latest being greater value wins. default=None
condition_key: date_created # key of the value we are comparing with.
condition_value: !!python/jmespath date_created #The value from the record we are pulling from

This would then modify the merge query which currently performs the following for source nodes:
MERGE(node:$node_type) WHERE node.key = $key
ON CREATE
    SET node.param = param.value
ON MATCH
    SET node.param = param.value

I would like it to create the following:
MERGE(node:$node_type) WHERE node.key = $key
ON CREATE
    SET node.param = param.value
ON MATCH
    SET node.condition = CASE WHEN $condition THEN true ELSE false END // We need a variable for the condition in some way
    SET node.param = CASE WHEN node.condition THEN param.value ELSE node.param END
    // Find a way to unset node.condition

Where condition in our case would be (date_created > node.date_created)
Describe alternatives you've considered
The alternative I can perform to ensure the recency of my data is I can schedule my pipelines such that the recent data comes in after the old data.
In my pipeline, I can create an interpreter that makes a call to the database to get the value, then conditionally write to the database (this takes too long.)
Additional context

I agree that this could be handy. Question marks around whether this is required in an ETL framework.  Definitely willing to take PRs on this.
One major challenge is going to be around retaining the abstraction behind graph databases.


Add PointerValueWalker for walking pointer values

This adds the PointerValueWalker interface, which supplies the Pointer
function for introspection into pointer values.
Pointer is called for all pointer values immediately before
PointerEnter. This allows the value to be handled more like a primitive
value, in addition to allowing SkipEntry to be returned to prevent the
pointer from being "entered".

Looks good to me. You ready for me to merge this?

@mitchellh good to go on this end! Thanks 🙂


Fix wrapping of long text content when showing indexes

For wrapping of long text when showing indexes names included in snapshot(s) in snapshot module.
When there are a lot of indexes included in snapshot and/or there are an index(es) with log name(s) - table content breaks page design. Example: ["index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name","index_name"]
Possible solutions:

Use some word wrap CSS tricks
Display content with fixed width and show full index list on hover (mouseIn, mounseOut events)
Split index list elements by space (or other wrapping symbol)

I do not see the problem, check my screenshot, maybe you see something else?


Enabling Proximity Fade/Distance Fade in shader will make the light went through

Godot version
4.0 beta 6
System information
Windows 11
Issue description
is this supposed to happen or is this a bug?
i set the tunnel to cull_disabled.
also, spotlight not working at all
check this videos for better explanation :
https://streamable.com/4ygq1c
https://streamable.com/ou6w8p
https://streamable.com/4ur3i2
Steps to reproduce
check the videos
Minimal reproduction project
none

This is expected, as enabling Proximity Fade or Distance Fade will make the object go through the transparent pipeline, which disables shadow casting for the object.

@Calinou hello my friend, sorry for not including the project. here is my project. im using the new physical light units not the vanilla ones.
https://www.dropbox.com/scl/fo/4i2vmoywoqas264z2pn27/h?dl=0&rlkey=itabgvtkti5v5oc0s5gihqyd1


fix(spanner): display LRO progress

Covers issue #1050.

Kokoro is failing, but should be fixed in https://github.com/GoogleCloudPlatform/php-docs-samples/pull/1091
Will merge after I can merge that change in and get these tests passing


[BUG] App Crash with Media Management permission

Hi. App Crashes on moving photos to Trash when it has Media Management Permission; but anyway it does the job. After revoking permission, the confirmation dialog appears and after approval, app won't crash.
To Reproduce

Give app all Permissions including All files access and Media Management permission.
Try to delete batch of media

Expected behavior
To don't crash.

Device: Poco X5 Pro 5G
OS: crDroid Android 10.9
Version: 14.0

Can't reproduce

I'm also having this issue on a Pixel 9 Pro running GrapheneOS version<PHONE_NUMBER>. Any logs or anything I could find somewhere to upload?

Also having this issue on a Pixel 9 Pro XL running Android 15 stock.


[BUG] 'model_size' or 'running_time' metrics not plotted in EvaluatePrequential()

Hi team. I noticed when trying to plot model_size or running_time metrics as part of EvaluatePrequential(), the code either crashes or doesn't plot the performance related metrics.
Scenario 1: Code Crashes
(model_size is the first item in the metrics list)
evaluator = EvaluatePrequential(show_plot=True,
                                pretrain_size=1,
                                max_samples=10000,
                                metrics=['model_size', 'accuracy'])

Scenario 2: Code Runs Incomplete
(model_size is the last item in the metrics list. The code runs, but only accuracy is shown and not the model_size)
evaluator = EvaluatePrequential(show_plot=True,
                                pretrain_size=1,
                                max_samples=10000,
                                metrics=['accuracy', 'model_size])

To Reproduce
A full example code:
from skmultiflow.evaluation.evaluate_prequential import EvaluatePrequential
from skmultiflow.data.hyper_plane_generator import HyperplaneGenerator
from skmultiflow.trees.hoeffding_adaptive_tree import HAT
"""1. Create stream"""
stream = HyperplaneGenerator(mag_change=0.001, noise_percentage=0.1, random_state=2)
stream.prepare_for_use()

"""2. Create classifier"""
hat = HAT()

"""3. Setup evaluator"""
evaluator = EvaluatePrequential(show_plot=True,
                                pretrain_size=1,
                                max_samples=10000,
                                metrics=['model_size', 'accuracy'])

"""4. Run evaluator"""
evaluator.evaluate(stream=stream, model=[hat], model_names=['HAT'])

Error Message
When crashes, this is the error message I see:
ValueError                                Traceback (most recent call last)
<ipython-input-8-872157f9c928> in <module>
     16
     17 """4. Run evaluator"""
---> 18 evaluator.evaluate(stream=stream, model=[hat], model_names=['HAT'])

~/PythonVenv/p3.7/lib/python3.7/site-packages/skmultiflow/evaluation/evaluate_prequential.py in evaluate(self, stream, model, model_names)
    244             # Initialize metrics and outputs (plots, log files, ...)
    245             self._init_metrics()
--> 246             self._init_plot()
    247             self._init_file()
    248

~/PythonVenv/p3.7/lib/python3.7/site-packages/skmultiflow/evaluation/base_evaluator.py in _init_plot(self)
    587                                                    n_models=self.n_models,
    588                                                    model_names=self.model_names,
--> 589                                                    data_dict=self._data_dict)
    590
    591     def _reset_globals(self):

~/PythonVenv/p3.7/lib/python3.7/site-packages/skmultiflow/visualization/evaluation_visualizer.py in __init__(self, task_type, n_wait, dataset_name, metrics, n_models, model_names, data_dict)
    103
    104         # Proceed with configuration
--> 105         self.__configure()
    106
    107     def on_new_train_step(self, sample_id, data_buffer):

~/PythonVenv/p3.7/lib/python3.7/site-packages/skmultiflow/visualization/evaluation_visualizer.py in __configure(self)
    191             plot_tracker = self._plot_trackers[metric_id]
    192             if metric_id not in [constants.RUNNING_TIME, constants.MODEL_SIZE]:
--> 193                 plot_tracker.sub_plot_obj = self.fig.add_subplot(base)
    194             base += 1
    195             if metric_id == constants.TRUE_VS_PREDICTED:

~/PythonVenv/p3.7/lib/python3.7/site-packages/matplotlib/figure.py in add_subplot(self, *args, **kwargs)
   1412                     self._axstack.remove(ax)
   1413
-> 1414             a = subplot_class_factory(projection_class)(self, *args, **kwargs)
   1415
   1416         return self._add_axes_internal(key, a)

~/PythonVenv/p3.7/lib/python3.7/site-packages/matplotlib/axes/_subplots.py in __init__(self, fig, *args, **kwargs)
     57                 if num < 1 or num > rows*cols:
     58                     raise ValueError(
---> 59                         f"num must be 1 <= num <= {rows*cols}, not {num}")
     60                 self._subplotspec = GridSpec(
     61                         rows, cols, figure=self.figure)[int(num) - 1]

ValueError: num must be 1 <= num <= 1, not 2

Additional context
I am using python 3.7.5 and the latest dev. version of skmultiflow.

Thanks for reporting this @mmnasr
Scenario 1 is indeed unexpected. We will look into it.
Scenario 2, on the other hand, is the expected behavior. model_size nor running_time are plotted by design since they are merely informative. We are missing this detail in the documentation.
A workaround is to save the results to a file, both model_size and running_time should be included in the resulting csv file (if they are set in the metrics option).

@jacobmontiel  Thank you for clarification.


Selecting Text in shadowroot does not work with button elements

Summary
When making a custom web component with tram-lite, if there is a button visible near text. The text is no longer selectable.
If the button has style='display:none' the text is selectable.
Tram-lite example where selecting text is broken:
https://codepen.io/JRJurman/pen/BaMJoVY
Vanilla Web-Component, showing expected text-selection:
https://codepen.io/JRJurman/pen/yLZpYZr

Testing this locally, it doesn't appear to be an issue on Firefox and Safari, only in Chrome and Edge 🤔

Okay, this appears to be a side-effect of having added delegatesFocus when creating the shadowRoot: https://codepen.io/JRJurman/pen/bGzamqd
From the documentation, this could be interpreted as correct, although certainly is unexpected.

If true, when a non-focusable part of the shadow DOM is clicked, or .focus() is called on the host element, the first focusable part is given focus, and the shadow host is given any available :focus styling.

I'll ask if this is expected behavior, and we can determine where to go from there.
Potentially we could expose an API to set whether delegatesFocus should be true or not, but I'd really like to avoid complicating the API for making elements.
Alternatively, it is possible to fix the selection behavior by making text elements focusable (specifically by giving them a tabindex) - see https://codepen.io/JRJurman/pen/MWLrPom

Okay, this is a potentially unknown issue with the implementation of delegatesFocus in chrome. I've created a test for this behavior, and we'll see what the follow-up is: https://github.com/web-platform-tests/wpt/pull/43244

Turns out this is a documented bug: https://crbug.com/950357
Since this is not an issue in Tram-Lite, I'll be closing this as a won't fix. Based on the discussion in the above PR for wpt, it sounds like this is on their radar.


Updating DRC rules decks to pass all linting rules, Merging with google update

Updating DRC rules decks to pass all linting rules, Merging with google update
Fixes #115

@atorkmabrains Could you please merge this?


Sorting freeze issue with DataTable

After updating to 0.0.15 my app will lock up (browser freezes) when calling setSort() on Md2DataTable. Previous versions worked fine. I am accessing the table via ViewChild @ViewChild(Md2DataTable) table: Md2DataTable; and calling the setSort() method like so this.table.setSort('uploadedOn', 'desc');. Is it acceptable to call these methods manually?

We have fixed the issue with release<EMAIL_ADDRESS>comment here if you have an issue


Trying to use global event object ?

Hi,
in https://github.com/ceolter/ag-grid/blob/ec08a09ff499d95506f6184815d21eb34e0f378a/src/ts/rendering/renderedCell.ts#L487,
looks like you are trying to use the global event object, or maybe something with should be given in parameter.
Anyway, in Firefox and others browsers, there is no global event object and it lead to a JS error.
Prior to https://github.com/ceolter/ag-grid/commit/507325860ac0df3a945521d4de11c7f6d6db2e7f ,
there was always a provided event object given in arguments before calling this.createEvent(event, this);

thanks. will be releasing later today all going to plan. this bug slipped in during my refactoring.


EXPERIMENTAL FOR DISPLAY ONLY: combine 'Native C types for OSSL_PARAM' with test/params_test.c

This combines #8377 with #8396

https://github.com/openssl/openssl/pull/8399#issuecomment-469451888 applies here as well

#8396 is now completed, so closing this


Modify: Apache.OpenOffice version 4.111.9808

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-Installation-Error Validation-Unattended-Failed

@denelon @stephengillie Another waiver needed

@wingetbot waivers Add Validation-Unapproved-URL

@wingetbot waivers Add Validation-Unattended-Failed


Explicitly list additional types supported as table search key fields

and action parameters.

I did check the formatting locally on my machine, visually inspecting the PDF file at least.  Sorry, I keep forgetting about the other way to submit PRs to this repo.


Fix pep8 H306 warnings

This fixes alphabetical import ordering issues and starts enforcing it.

Don't merge this, I missed some things Ed pointed out because I didn't remove the pylintrc disable line.

lgtm, thanks brian!


in-place bind variables only accept identifiers

This template isn't a strict requirement to open issues, but please try to provide as much information as possible.
Version: 0.5.1-SNAPSHOT
Module: quill-core
Expected behavior
From @gustavoamigo's comment:
Should compile:
  def update(user: User) =
    db.run(users.filter(_.id == user.id).update(_.name -> user.name, _.isActive -> user.isActive))

Actual behavior
It throws the following error:
[error] /Users/gustavoamigo/Projects/play-quill-jdbc/app/services/UserServices.scala:26: Source doesn't know how do encode 'user: services.User'
[error]     db.run(users.filter(_.id == user.id).update(_.name -> user.name, _.isActive -> user.isActive))

Here is the complete code:
https://github.com/getquill/play-quill-jdbc/blob/free-binding/app/services/UserServices.scala
@getquill/maintainers

I've done more tests, it doesn't matter if it is in-place or not, it will not compile.
Both examples won't compile.
    "with in-place case class binding" in {
      val t = TestEntity("s", 1, 2L, Some(4))
      val r = mirrorSource.run(qr1.insert(_.i -> t.i, _.s -> t.s))
    }
    "with quoted case class binding" in {
      val t = TestEntity("s", 1, 2L, Some(4))
      val q = quote { (t: TestEntity) => qr1.insert(_.i -> t.i, _.s -> t.s)  }
      val r = mirrorSource.run(q)(List(t))
    }

Working on this


Search Bar Font Black on Grey in Dark Theme

Search bar font remains black on grey when the Dark theme is used on V1.0.
(Amazing work on the app, super slick and the library/download along with the rest of the API integration is super well done).

Can't seem to reproduce it. What device and iOS version are you on? Is the text still gray when you close and reopen the app?

Hi - I’m on an iPad Pro 11” running, uh, iOS13 Developer beta 1. Running the app theme in Light, Dark, and Darker, and on the iOS light and dark themes produce the same black on grey result.
I’m happy to test further if needed.

Hmm so the text is always gray regardless of the theme (Light, Dark, Darker, iOS Light, iOS Dark) you use? Does it affect all the in-app search bars? Please check News and See All too.
It could be a specific bug in SwiftTheme library related to search bars in iOS 13. Sadly I don't have any iOS 13 devices to test this myself.

Yep, it's always grey regardless of what theme I use, and it's across all
the search bars, both in the Search tab and the 'See all' popup. It
probably is an ios13 specific bug in the theming library.
Thanks for checking into it and for creating the app.
On Wed, Jun 5, 2019 at 4:05 AM ned<EMAIL_ADDRESS>wrote:

Hmm so the text is always gray regardless of the theme (Light, Dark,
Darker, iOS Light, iOS Dark) you use? Does it affect all the in-app search
bars? Please check News and See All too.
It could be a specific bug in SwiftTheme library
https://github.com/wxxsw/SwiftTheme related to search bars in iOS 13.
Sadly I don't have any iOS 13 devices to test this myself.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/n3d1117/appdb/issues/34?email_source=notifications&email_token=ABK3WG3AFD32ZSM2Q7X6KVDPY6MXDA5CNFSM4HTTC5KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW7LXXY#issuecomment-499039199,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABK3WGZFO2KV4PJ22F7VS7LPY6MXDANCNFSM4HTTC5KA
.

@dtimekeeper  I found the issue! It was my fault. Will be fixed in the next update!

@n3d1117 on an iPad Pro 11", iOS 13 dev beta 4, appdb 1.0.1 (latest release) the search text is still black in the appdb dark mode. Only the "Search iOS Apps" text is light grey.

Hello @greybaron, thanks for reporting. This might be fixed in 847a823 (don't have an iOS 13 device so I can't test). Could you try to install this test build and see if it's fixed? Thanks
I'll reopen the issue for now.

Sorry for the late reply. The issue is still present in the test build, tested on dev beta 5. "Search iOS Apps" looks good but the search text is black

Ok @greybaron, thanks for reporting, seems like things changed a bit with iOS 13. Since I can't afford to update to a macOS beta, you'll have to wait until Xcode 11 and iOS 13 are publicly released for this to be fixed. I'll keep this issue open until then.

Hi @greybaron @dtimekeeper, please test release 1.0.2! I was not able to reproduce this issue using latest version. Let me know! I will keep this open for now

@n3d1117 confirmed fixed for me on iOS 13.2 dev beta 2 and release 1.0.2. :)


Support for Minecraft 1.16

Depends on: https://github.com/GameModsBR/PowerNukkit/issues/290 's registration tasks

Is there like an ETA for the 1.16 support?


Nest the row-wrapper so that we can have a row-detail tied to each ro…

…w of a group
What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#1196 #1108
What is the new behavior?
Each row of a group gets its own datatable-row-wrapper. What this effectively means is that for groups specifically, you have the following HTML:
<datatable-row-wrapper>
   <datatable-row-wrapper>
       <datatable-body-row></datatable-body-row>
   </datatable-row-wrapper>
</datatable-row-wrapper

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
To the best of my ability to check, this should not break any existing functionality outside of someone's table styles that use child selectors rather than descendant selectors to style the datatable-body-row. I have run the demo page with this change and they don't render any differently.
Other information:
I have also backported this to 11.x as my project is still on Angular 5 and we had (currently undiagnosed) issues running the latest in production.

Any news here?


Understanding on Identifier

Hi,
I'm spending some time trying out Vapor2 a bit and I have to say that, imo, the code is now much better than the version 1.0. Thank you all guys :)
Going to the question, I'm a bit confused with the Identifier concept.
By implementing a Model using Fluent, the idea is to hide any database-related logic from our code, to make it more maintainable and easy to change to other engines. But the Identifier class is still a bit unclear to me.
I'm now using a postgres database, so a normal table id value is an Int. In mongo it will probably be an object or a String. So far everything is ok.
My Todo object as an Identifier and the router should handle a GET /todos/:id. Here is the problem: how I'm supposed to handle the id type?
What I ended up is this
todos.get("", ":id") { request in
  guard let todoId = request.parameters["id"]?.string else {
    throw Abort.badRequest
  }

  let identifier = Identifier(.string(todoId), in: nil)
  return try _todoController.todoWith(identifier, for: try request.getUserId())
}

In my case, an Int is convertible to a String type, so I hope that, when Fluent will be comparing Identifiers, the equality will be verified correctly. Am I correct?
Is there a more elegant way to handle this without passing by a String object? I would have expected something similar to
guard let todoId = request.parameters["id"]?.identifier else {
    throw Abort.badRequest
}

which will abstract the Identifier type at all.
What do you think? Also because the subscript value is already a StructuredDataWrapper object.

@dalu93 any particular reason why you're manually pulling out the Identifier and then passing it to the controller as oppose to just using Parameterizable and then getting the Todo object?

The reason is that I need the userId which is encoded in the access_token parameter. Then access  the database by looking for the specific todo for the specific user. @0xTim

@dalu93 Just use String if you want to support all identifier types. That's what we would do with a .identifier property anyway. (The equality operator should work find between ex: 42, "42", and 42.0). Also it's possible to add the .identifier property as an extension in your code if you want it. We're working on moving away from the StructuredDataWrapper type in the next version of Node so hopefully that will make things more clear.

Closing as Fluent 3 has no more Identifier!


[Question]: How to import a Knowledge Graph to query and join with LLM?

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I cannot find clear resources on how to find an existing kg, either in .ttl/rdf or through an api, to be queried in conjunction with an LLM. Where can I look? Thank you

@dosu-bot and how to query from the example you wrote? If I try with this snippet it won't work
llm = OpenAI(temperature=0, model="text-davinci-002")
service_context = ServiceContext.from_defaults(llm=llm, chunk_size_limit=512)
index = KnowledgeGraphIndex([], service_context=service_context)
tuples = [
    ("foo", "is", "bar"),
    ("hello", "is not", "world"),
    ("Jane", "is mother of", "Bob"),
]
nodes = [TextNode(text=str(tup)) for tup in tuples]
for tup, node in zip(tuples, nodes):
    # add node
    index.add_node([tup[0], tup[2]], node)
    # add triplet
    index.upsert_triplet(tup)

@dosu-bot how to add StorageContext and GraphStore in order to query the knowledge graph?

@dosu-bot
from llama_index import KnowledgeGraphIndex, TextNode, ServiceContext
from llama_index.llms import OpenAI

llm = OpenAI(temperature=0, model="text-davinci-002")
service_context = ServiceContext.from_defaults(llm=llm, chunk_size=512)
index = KnowledgeGraphIndex([], service_context=service_context)

tuples = [
    ("foo", "is", "bar"),
    ("hello", "is not", "world"),
    ("Jane", "is mother of", "Bob"),
]

for tup in tuples:
    # add node
    node = TextNode(text=str(tup))
    index.add_node([tup[0], tup[2]], node)
    # add triplet
    index.upsert_triplet(tup)

I get the error
Traceback (most recent call last):
  File "C:/Users/annas/PycharmProjects/work-met-identification-with-llms/trial-with-rag.py", line 19, in <module>
    from llama_index import KnowledgeGraphIndex, TextNode, ServiceContext
ImportError: cannot import name 'TextNode' from 'llama_index'

How to import an existing knowledge graph on Neo4J and query it? More specifically how to load it. Code:
llm = OpenAI(temperature=0, model="gpt-3.5-turbo")
service_context = ServiceContext.from_defaults(llm=llm, chunk_size=512)
Define Neo4j
graph_store = Neo4jGraphStore(
username=username,
password=password,
url=url,
#database=database,
)
storage_context = StorageContext.from_defaults(graph_store=graph_store)

@dosu-bot How to import an existing knowledge graph on Neo4J and query it? More specifically how to load it. Code:
llm = OpenAI(temperature=0, model="gpt-3.5-turbo")
service_context = ServiceContext.from_defaults(llm=llm, chunk_size=512)
Define Neo4j
graph_store = Neo4jGraphStore(
username=username,
password=password,
url=url,
#database=database,
)
storage_context = StorageContext.from_defaults(graph_store=graph_store)


feat: extract unique id generation to a composite action

Types of actions https://docs.github.com/en/actions/creating-actions/about-custom-actions#types-of-actions
Creating a composite action https://docs.github.com/en/actions/creating-actions/creating-a-composite-action

So a local composite action must has its metadata file called action.yml located in ./path/to/dir/action.yml (or with the .yaml extension) and then used by uses: ./path/to/dir.
https://docs.github.com/en/actions/creating-actions/about-custom-actions#types-of-actions

In Windows Server 2020 runner,

shell: bash uses Git Bash from Git for Windows
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell
There're also msys2bash and wslbash
https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md#shells

I can find the doc for POSIX devices for Cygwin Bash (https://cygwin.com/cygwin-ug-net/using-specialnames.html#pathnames-posixdevices), but can't find that for Git Bash yet.

Git for Windows is essentially a subset of MSYS2 with a defined set of installed packages of which a subset is included in the installer.
https://github.com/git-for-windows/git/wiki/Technical-overview

The unixy tools in MSYS2 are directly based on Cygwin, so there is some overlap there.
https://www.msys2.org/docs/what-is-msys2/#msys2-vs-cygwin

So it seems the previously mentioned Cygwin user manual section "POSIX devices" is what I'm looking for.

Rebased to include changes from

#15

#15 is working, now only workflow "Test LaTeX" is triggered.


[WIP] Fantasy land applicatives

For #209
Just trying to collect some code around these implementations:

applyTo
Tests
Law tests

Async
:white_check_mark:
:white_check_mark:
:white_check_mark:

Const
:white_check_mark:
:white_check_mark:
:heavy_minus_sign:

Either
:white_check_mark:
:white_check_mark:
:white_check_mark:

IO
:white_check_mark:
:white_check_mark:
:white_check_mark:

Identity
:white_check_mark:
:white_check_mark:
:white_check_mark:

List
:white_check_mark:
:white_check_mark:
:white_check_mark:

Maybe
:white_check_mark:
:white_check_mark:
:white_check_mark:

Pair
:white_check_mark:
:white_check_mark:
:heavy_minus_sign:

Reader
:white_check_mark:
:white_check_mark:
:white_check_mark:

Result
:white_check_mark:
:white_check_mark:
:white_check_mark:

State
:white_check_mark:
:white_check_mark:
:white_check_mark:

Unit
:white_check_mark:
:white_check_mark:
:white_check_mark:

Writer
:white_check_mark:
:white_check_mark:
:white_check_mark:

@pfgray when you get a chance you will wanna rebase against current master.
We have a fix in there for the spec runner on node:6

@evilsoft , it looks like there are 5 tests failing:
  Failed Tests: There were 5 failures
    isApplicative fantasy-land
      ✖ returns false when Applicative is passed

    isApply fantasy-land
      ✖ returns false when Apply is passed

    isChain fantasy-land
      ✖ returns false when Chain is passed

    isMonad fantasy-land
      ✖ returns false when Monad is passed

    isAlternative fantasy-land
      ✖ returns false when Alternative is passed

if I remove the addition of ap from flNames.js, then they pass.
I'm not quite sure what they're testing, or how these should behave now that we have fantasy-land/ap defined on these.

@pfgray will look into that, In the end, all of the pointfree functions should call the fantasy land function first, then dispatch to the non-prefixed. will pull down the branch and see what is going on with dem specs.

@pfgray I am not seeing those same failures locally.
What environment are you seeing them in?

@evilsoft, ah yes, sorry... I pushed some changes to the tests in this commit since without these changes those tests fail.
Are the isApplicative methods supposed to return false if a constructor or instance of a "fantasy-land applicative" is passed? Or is it just used to determine what is an "applicative" wrt the crocks library?
Also, would this then be considered a "breaking" change?

And do not sweat the breaking change, we have a couple of them coming down the pipe (Fix to Const and Writer. @bennypowers esm changes as a big change on the List ADT).

Also another thing I forgot to mention, each ADT has a VERSION variable at the top and an associated spec. This marks an API version for integration with sanctuary-js, so as the API is being updated, those versions will also need to be incremented.

@evilsoft @pfgray What do we need to get this merged in? I'm happy to pickup the final touches if you guys just let me know


typeof should create a new scope

Variables declared and assigned inside a typeof expression have no effect on code outside, so they shouldn't be accessible from outside at all. The following error:
x = typeof(y = 1)
y # Error: read before assignment to local variable 'y'

should have been undefined local variable or method 'y' for top-level. In particular, the variables shouldn't be accessible from other typeof expressions, like:
module A; end
module B; end

typeof(begin
  x = uninitialized A
  x.is_a?(B) ? x : raise "" # #2404
end)
typeof(begin
  x = uninitialized B # Error: variable 'x' already declared with type A
  x.is_a?(A) ? x : raise ""
end)

Should every argument of the same typeof start a new scope?
x = 1
typeof(x = "", x = [x])

Should the above be (String | Array(String)) or (String | Array(Int32))?

The most local (to the definition) would be (String | Array(String))

I think I'd prefer the current behaviour ((String | Array(String))).
If you want (String | Array(Int32)), you can use typeof(x = "") | typeof(x = [x]). There should be no other implications, right?


refactor(transformer): split up logical assignment operator transform into functions

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#5902  👈
#5898
#5897
#5896
#5895
#5894
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Deactivate the triggers in field mapping

@esavary is this needed before the data collection?

That would be the ideal scenario, but if we can't find a solution, I can work around the issue.

Changing the label, otherwise we will not have this under the radar tomorrow.

Closing as it is not possible to disable.


Print warning if a module not present for a product, error out if zer…

…o modules in a product
Fixes https://bugs.swift.org/browse/SR-1064

@swift-ci Please test

Needs a regression test at least.

Needs a regression test at least.
Will add

@mxcl Rebased and added tests

@swift-ci Please test

OSX failed for some reason, @mxcl CI again?

@swift-ci please test

@mxcl @ddunbar tests passed, review please

Seems reasonable to me but @mxcl's area...

@mxcl please review before this gets conflicted :joy:


Magnolia fails to dispatch through some recursive ADTs

Originally reported by @scalway on gitter.
Magnolia fails to dispatch on the following recursive ADT (tested using circe-magnolia):
sealed trait Msg {}

case class Hello(text:String) extends Msg
case class ByeBye(text:String) extends Msg
case class Multi(msgs:Seq[Msg]) extends Msg

import io.circe.magnolia.derivation.encoder.semiauto._

// fails with
// magnolia: could not find Encoder.Typeclass for type Seq[Playground.this.Msg]
// in parameter 'msgs' of product type Playground.this.Multi
// in coproduct type Playground.this.Msg
val encoder = deriveMagnoliaEncoder[Msg]

This happens when magnolia macro is not implicit. In case of implicit macro (auto mode) everything is fine.
See deriver implementation [here] (https://github.com/circe/circe-magnolia/blob/master/derivation/src/main/scala/io/circe/magnolia/MagnoliaEncoder.scala).

Scastie worksheet: https://scastie.scala-lang.org/vpavkin/lTr16ttTRsygkSNGLPYK3A

This works for me (it's also what I would expect if the macro is not implicit):
implicit lazy val encoder: Encoder[Msg] = deriveMagnoliaEncoder[Msg]
implicit lazy val decoder: Decoder[Msg] = deriveMagnoliaDecoder[Msg]

Confirm, worked for me. Thanks @joroKr21 !


Update contact.rs.html

--Discord:: not accepting new friends
--IRC:: user does not exist

These are accurate contact info for me. Discord requires you to join a mutual server to friend me.


[Provider Audit] provider.de.kloudmos.com

Name : Chiroxo
Discord : Chiroxo
Contact email<EMAIL_ADDRESS>

~duplicate of #693~ Upd: figured this one is .de. and the other one is .us.

Yep, ready to be audited and reviewed

Hi @nathandiruggiero , Welcome to Akash!!
provider-services query provider get akash167hmrx0x2guklnnqrqedgdstj0usfzhgxkn5pj -o text
attributes:
- key: host
  value: akash
- key: tier
  value: community
- key: organization
  value: kloudmos
- key: cpu
  value: amd
- key: country
  value: DE
- key: city
  value: Dusseldorf
- key: region
  value: North Rhine-Westphalia
- key: timezone
  value: utc+2
- key: arch
  value: x86_64
- key: network-speed-up
  value: "500"
- key: network-speed-down
  value: "1000"
- key: status-page
  value: https://stats.uptimerobot.com/jKppMSYv2R
host_uri: https://provider.de.kloudmos.com:8443
info:
  email<EMAIL_ADDRESS>  website: under_construction
owner: akash167hmrx0x2guklnnqrqedgdstj0usfzhgxkn5pj

Provider is signed
provider-services query audit get akash167hmrx0x2guklnnqrqedgdstj0usfzhgxkn5pj
pagination: null
providers:
- attributes:
  - key: arch
    value: x86_64
  - key: city
    value: Dusseldorf
  - key: country
    value: DE
  - key: cpu
    value: amd
  - key: host
    value: akash
  - key: network-speed-down
    value: "1000"
  - key: network-speed-up
    value: "500"
  - key: organization
    value: kloudmos
  - key: region
    value: North Rhine-Westphalia
  - key: status-page
    value: https://stats.uptimerobot.com/jKppMSYv2R
  - key: tier
    value: community
  - key: timezone
    value: utc+2
  auditor: akash1365yvmc4s7awdyj3n2sav7xfx76adc6dnmlx63
  owner: akash167hmrx0x2guklnnqrqedgdstj0usfzhgxkn5p

you can find it here as well 👇


Made the flow file size configurable

Context: Currently, we limit the size of the flow file to 10 MB, and changing this is possible only through a code change. This PR is to make this property configurable so that we can change the limit in certain clusters. This is needed by ML customers whose flows can be quite huge. Only if we supply the config value, we use that limit. Otherwise, we default to the current limit. ie. No behaviour change if this config is not supplied.
Testing: Tested by setting the size to 15MB. I was able to upload the flows of size ~15MB.
Additional notes:
We store the flow object in two places project_flows, and project_flow_files table as JSON object and as flow file respectively. These two tables have their column type as medium blob and long blob. Because medium blob can store only up to 16MB, we would have to change it to a long blob if we decide to set it beyond 16MB.

Pull Request Test Coverage Report for Build 7524

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 44.842%

Totals

Change from base Build 7520:
0.005%

Covered Lines:
19155

Relevant Lines:
42717

💛  - Coveralls


Missing step?

Part 3 (EmuNAND), after step 10:
When [A] is pressed to ignore starter.bin, another prompt appears:
"You may now switch the SD card
The inserted SD card will be formatted
All data on it will be lost!
If you wish to proceed, enter:
[Down], [Up], [Left], [Right], [A]
(B to cancel)"
I just entered the combination, it seems it was the correct choice. Others may be confused on this part because it is telling to switch SD cards and the thought of formatting might be scary...

Fixed


Flutter installing freezes on "Updating Flutter tools.." with master branch cloned.

Followed the procedure from Flutter.

System Requirements:
OS: Windows 8.1
Powershell V5
Git installed
2.When i completed the SDK complete setup through "Flutter Doctor" command, setup freezes at this point without any error  or warning messages.

In my case it was the company's ntlm proxy. I have cntlm installed on the local machine and set via environment variables. For a unknown reason updates from https://www.dartlang.org/ could not be downloaded. I fixed the problem by downloading by tethering via mobile phone.

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


:sparkles: Talya notifications close all together bug

making the delete notifications distinguishable to fix the MTE-3095 bug that closes all the notifications together when one close button is pressed

@TalyaNaima -- Do you intend to move this PR out of draft?


owncast: 0.0.13 -> 0.1.0

Description of changes
This simplified the derivation a bit - no need to bundle the webapp files any more, as they are included in the binary at build time.
Tested with a stream!
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 243867 run on x86_64-linux 1

1 package built:

owncast

Tested and working on my server

I need to take a closer look at this after my exam on Wednesday!
The changes seem to make sense, since the resources are now bundles in the app 👍🏻
Thank you for the PR - I haven't found time to work on it!

@MayNiklas no rush. good luck in your exam!

Yeah, the patch is a bit gross - the reason for it is that a newer version of gopsutil is needed to fix the build on newer versions of mac os aarch64. This is actually due to go-m1cp which is updated in newer versions of gopsutil.
The large number of changes in go.sum are a result of running go mod tidy which seems to have removed a lot of unused old versions of packages (my guess is noone has run this upstream in a while). This isn't necessary and probably doesn't actually save any time so I can remove it to make the patch cleaner if you like?
I ran:

go get -u github.com/shirou/gopsutil/v3
go mod tidy

@wlcx I will try to create the same mod mod.sum file this evening!
In case that works, I'm fine with it (since everyone would be able to reproduce the same file).
Thank you for your explanation!

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2475

@wlcx 0.1.1 just got release.
We could directly update to that - that would remove the need for the patch file.

@MayNiklas done!

And could you please rename the PR?

Thanks all @SuperSandro2000 @drupol @MayNiklas . Should be ready for approval now!

LGTM now, let's see the tests !

@GrahamcOfBorg build owncast

FYI the NixOS test broke with Unable to locate ffmpeg.  That got also backported to 23.05: https://hydra.nixos.org/job/nixos/release-23.05/nixos.tests.owncast.x86_64-linux

OMW to work, fix incoming asap.

I can't reproduce the issue on my end...
~/C/N/nixpkgs ✘ ./result/bin/owncast -webserverport 8080 -rtmpport 1935 -webserverip <IP_ADDRESS> -enableDebugFeatures
INFO[2023-08-02T09:37:30+02:00]github.com/owncast/owncast/main.go:72 main.main() Owncast v0.1.1-dev (20230802)
INFO[2023-08-02T09:37:30+02:00]github.com/owncast/owncast/main.go:136 main.handleCommandLineFlags() Saving new web server port number to 8080
INFO[2023-08-02T09:37:30+02:00]github.com/owncast/owncast/main.go:145 main.handleCommandLineFlags() Saving new web server listen IP address to <IP_ADDRESS>
INFO[2023-08-02T09:37:30+02:00]github.com/owncast/owncast/main.go:154 main.handleCommandLineFlags() Saving new RTMP server port number to 1935
INFO[2023-08-02T09:37:30+02:00]github.com/owncast/owncast/core/transcoder/transcoder.go:124 github.com/owncast/owncast/core/transcoder.(*Transcoder).Start() FFREPORT=file="data/logs/transcoder.log":level=32 /nix/store/bwy7pjdrj637nyw1x8g9c6zr9wl85g21-ffmpeg-5.1.3-bin/bin/ffmpeg -hide_banner -loglevel warning  -fflags +genpts -flags +cgop -i  ./data/tmp/offline.ts2952639702  -map v:0 -c:v:0 libx264 -b:v:0 1008k -maxrate:v:0 1088k -g:v:0 120 -keyint_min:v:0 120 -r:v:0 24 -x264-params:v:0 "scenecut=0:open_gop=0" -bufsize:v:0 1088k -profile:v:0 high -map a:0? -c:a:0 copy -preset veryfast  -var_stream_map "v:0,a:0 " -f hls -hls_time 5 -hls_list_size 5 -hls_flags program_date_time+independent_segments -hls_playlist_type event -segment_format_options mpegts_flags=mpegts_copyts=1 -tune zerolatency -pix_fmt yuv420p -sc_threshold 0 -master_pl_name stream.m3u8 -hls_segment_filename http://<IP_ADDRESS>:37229/%v/stream-offline-%d.ts -max_muxing_queue_size 400 -method PUT http://<IP_ADDRESS>:37229/%v/stream.m3u8
INFO[2023-08-02T09:37:30+02:00]github.com/owncast/owncast/router/router.go:439 github.com/owncast/owncast/router.Start() Web server is listening on port 8080.
INFO[2023-08-02T09:37:30+02:00]github.com/owncast/owncast/router/router.go:441 github.com/owncast/owncast/router.Start() Configure this server by visiting /admin.

It looks like ffmpeg is correctly found.

Pretty sure the only thing this can be is the switch from makeWrapper to makeBinaryWrapper, probably something to do with how owncast tries to find ffmpeg (by running which....) Will revert back to makeWrapper and see if that resolves it.

Yep, tested on nixos. https://github.com/NixOS/nixpkgs/pull/246751


Contents of CPU registers aren't what they ought to be upon switching frames in case of post-mortem debug

Does this issue occur when all extensions are disabled?: Yes (other than the Microsoft C/C++ extension)

VS Code Version: 1.74.0
OS Version: Ubuntu 18.04.6 LTS

Steps to Reproduce:

Have Visual Studio Code load the specified core dump in gdb via gdb-mi by employing a launch configuration akin to the following –

{
    "version": "0.2.0",
    "configurations": [
        {
            "name": "(gdb) Post-mortem Debug (x86-64)",
            "type": "cppdbg",
            "request": "launch",
            "args": [],
            "stopAtEntry": false,
            "cwd": "${workspaceFolder}",
            "environment": [],
            "externalConsole": false,
            "MIMode": "gdb",
            "setupCommands": [
                {
                    "description": "Enable pretty-printing for gdb",
                    "text": "-enable-pretty-printing",
                    "ignoreFailures": true
                }
            ],
            "program": "${workspaceFolder}/linux-x86_64.out",
            "coreDumpPath": "${workspaceFolder}/linux-x86_64.core",
            "targetArchitecture": "x64",
            "sourceFileMap":{
                "/home/labath/test": "${workspaceFolder}"
            },
            "logging": {
                "trace": true,
                "traceResponse": true
            },
        }
    ]
}

Once the core dump has been loaded, expand Registers -> CPU in the Variables pane while still at the zeroth frame ( bar(char * boom) ), and note the contents of the CPU registers

Stop the debug session

Have Visual Studio Code load the specified core dump in gdb via gdb-mi again

Once the core dump has been loaded, switch from the zeroth frame to the first frame ( foo(char * boom, void (*)(char *) boomer) ) in the Call Stack pane without expanding Registers -> CPU in the Variables pane

Expand Registers -> CPU in the Variables pane while at the first frame, and note the contents of the CPU registers

Leave Registers -> CPU in the Variables pane expanded, switch from the first frame to the zeroth frame in the Call Stack pane, and note the contents of the CPU registers

What I expect to see, versus what I actually see:
The contents of the CPU registers in the zeroth frame as noted in (2) are –

The contents of the CPU registers in the first frame as noted in (7) are –

Now, I'd expect the contents of the CPU registers in the zeroth frame as noted in (8) to be identical to those noted in (2). Instead, they're identical to the contents of the CPU registers in the first frame as noted in (7) –

What's curious, though, is that, apparently, Visual Studio Code doesn't issue a scopes request upon switching from the first frame to the zeroth frame –
...
<--   C (scopes-14): {
    "command": "scopes",
    "arguments": {
        "frameId": 1001
    },
    ...
}
--> R (scopes-14): {
    ...
    "command": "scopes",
    "body": {
        "scopes": [
            ...
            {
                "presentationHint": "registers",
                "name": "Registers",
                "variablesReference": 1004,
                "expensive": true
            }
        ]
    },
    "seq": 52
}
...
<--   C (variables-16): {
    "command": "variables",
    "arguments": {
        "variablesReference": 1004
    },
    ...
}
--> R (variables-16): {
    ...
    "body": {
        "variables": [
            {
                "name": "CPU",
                "value": "",
                "presentationHint": {
                    "attributes": [
                        "readOnly"
                    ]
                },
                "variablesReference": 1006
            },
            ...
        ]
    },
    "seq": 58
}
<--   C (variables-17): {
    "command": "variables",
    "arguments": {
        "variablesReference": 1006
    },
    "type": "request",
    "seq": 17
}
--> R (variables-17): {
    ...
}
<--   C (variables-18): {
    "command": "variables",
    "arguments": {
        "variablesReference": 1001
    },
    ...
}
--> R (variables-18): {
    ...
    "command": "variables",
    "body": {
        "variables": [
            {
                "name": "CPU",
                "value": "",
                "presentationHint": {
                    "attributes": [
                        "readOnly"
                    ]
                },
                "variablesReference": 1012
            },
            ...
        ]
    },
    "seq": 64
}
<--   C (variables-19): {
    "command": "variables",
    "arguments": {
        "variablesReference": 1012
    },
    "type": "request",
    "seq": 19
}
--> R (variables-19): {
    ...
}

If this is indeed the case, then we're in fact requesting the contents of the CPU registers in the first frame instead of those in the zeroth frame despite having switched from the first frame to the zeroth frame.
Kindly let me know in case any additional information is required.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.76.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks for the detailed report. But could you first file this on the cpp extension repo to verify that it isn't an issue with the debug extension?
To summarize, it sounds like you are saying that you click to switch the focused frame, and the Registers don't update?
If you see the other variables update, then that proves that what you are seeing came from the extension.

@roblourens, yes, that's correct. I reckon that the contents of the CPU registers are indeed supplied by the debug adapter/extension but I suspect that we're erroneously requesting the contents of the CPU registers in the first frame instead of those in the zeroth frame despite having switched from the first frame to the zeroth frame.
Filed https://github.com/microsoft/vscode-cpptools/issues/10750.


[WIP] Added HTTP BREAD for integrations resource

:wave: refs #9865 :wave:
:warning: :construction_worker_man: :rescue_worker_helmet: Work In Progress :rescue_worker_helmet: :construction_worker_man: :warning:
This adds the controller, and wires up the endpoint for adding a new integration!

[x] Create admin api key when creating integration
[x] Create content api key when creating integration
[ ] Create all resources in a single transaction

I have a feeling I should be able to do this using bookshelf-relations - however I tried a few ways and couldn't work it out.

@allouis will you be adding the ?include=api_keys,webhooks support in this PR or a separate one? On the admin side we're currently relying on that - the only API request it will make for fetching data is /integrations/?include=api_keys,webhooks. I guess we'll need the ?limit=all param too 🤔

Hey :wave: I'll be adding ?include=api_keys in this PR - my current branch only supports it for "read". the webhook support will come via rish tomorrow :+1:
I have a few questions about what we do/don't accept re query params - so i might bug you tomorrow, or leave it for next week :relaxed:

Create PUT /integrations/:id endpoint

commit needs fixing before requesting review


Fix deprecated calls syntax to Triplestore.triples()

The triples() method has been changed from taking a (s,p,o) tuple as argument to taking optional subject, predicate, object arguments.
This PR updates calls to triples() accordingly.

Codecov Report
Base: 67.07% // Head: 67.16% // Increases project coverage by +0.09% :tada:

Coverage data is based on head (000c2c1) compared to base (13c64ee).
Patch coverage: 57.14% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   67.07%   67.16%   +0.09%
==========================================
  Files          14       14
  Lines        1063     1063
==========================================
+ Hits          713      714       +1
+ Misses        350      349       -1

Impacted Files
Coverage Δ

tripper/triplestore.py
78.62% <57.14%> (+0.36%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add misclassified C sample

This sample is misclassified as Objective-C.

@tbodt are you happy to accept the GitHub Contributor License Agreement?  If so, please do so so we can progress this PR.  If you're prefer not to, I think it's best to close this PR.

@lildude done.


Fix issues with test

Fixed issues where certain files were causing the test to fail

Hey @leedoughty,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.
View build log
TravisBuddy Request Identifier: ddc07b60-f578-11e8-82c8-e5a529755eac


[Bugfix] remove device change event handler

Solved #319
Handling camera/microphone connect/disconnect is out of scope, we could do it in next version.

@vincentsong
Publisher page is refreshed when the external camera is connected to system and it keeps on loading different cameras and at some point, it is not able to load the build-in camera too.

@vincentsong Publisher page is refreshed when the external camera is connected to system and it keeps on loading different cameras and at some point, it is not able to load the build-in camera too.

Please verify again, I just re-deployed the PR.  I found a strange behaviour, if I disconnect the USB camera, I will get ended event for the connected camera's video track. That's unexpected.

@vincentsong @jackshen
When the publisher connects the external camera to the system on the preview page or during streaming, publisher app does not start the streaming of external camera automatically.


Database

created a Database folder and added the .sql file for the signup and login features.

LGTM!


KNOX-2149 - JWTTokenProvider - JWT verification with OIDC provider by invoking JWKS verification url

What changes were proposed in this pull request?
change the code to pass the JWKS verification url and if a key is changed - no knox config change is required. Change done to support using JWKS verification url to validate the token :
Class JWTFederationFilter was modified to get an additional parameter (JWKS verification url) and code to use this url to get the public key and then use this to validate the token. This approach will make it easy to manage for key rotation.
Library used is - https://connect2id.com/products/nimbus-jose-jwt/examples/validating-jwt-access-tokens
As part of this patch , we also extracting custom claim from JWT instead of default subject
How was this patch tested?
Patch was tested fully manual test cases.
We deployed modified code version of Knox (That build on top of Knox 1.3.0)
Test 1: Able to Invoke Livy endpoint to submit spark job via Knox JWT-Okta authentication
Test Request:
curl -kvvvvvv --request POST --url https://localhost:8443/gateway/tokenbased/livy/v1/batches --header 'content-type: application/json' --header 'accept: application/json' --header 'authorization: Bearer eyJra...dfg' --data '
{"file": "s3://aws-bigdata-blog/artifacts/aws-blog-emr-knox/spark-examples.jar", "className": "org.apache.spark.examples.SparkPi", "args": ["100"]}

Test 2: Able to Invoke Knox admin rest endpoint to create knox topology and alias with JWT-Okta verification
Test Request:
curl -ivk -H "Authorization: Bearer eyJra...dffd" https://localhost:8443/gateway/tokenbased/api/v1/topologies/jwtadmin -X PUT -H 'Content-type: application/xml;charset=UTF-8' --data @payload-knox.xml

Sample Knox Topology :
<?xml version="1.0" encoding="UTF-8"?>
<topology>
   <uri>https://localhost:443/gateway/tokenbased</uri>
   <name>tokenbased</name>
   <generated>false</generated>
   <gateway>
      <provider>
         <role>federation</role>
         <name>JWTProvider</name>
         <enabled>true</enabled>
         <param>
            <name>knox.token.jwks.url</name>
            <value>https://test.okta.com/oauth2/aussdfgsg/v1/keys</value>
         </param>
         <param>
            <name>knox.token.principal.claim</name>
            <value>empId</value>
         </param>
         <param>
            <name>jwt.expected.issuer</name>
            <value>https://test.okta.com/oauth2/aussdfgsg</value>
         </param>
         <param>
            <name>jwt.expected.sigalg</name>
            <value>RS256</value>
         </param>
      </provider>
      <provider>
         <role>hostmap</role>
         <name>static</name>
         <enabled>false</enabled>
         <param>
            <name>localhost</name>
            <value>localhost</value>
         </param>
      </provider>
      <provider>
         <role>identity-assertion</role>
         <name>Default</name>
         <enabled>true</enabled>
      </provider>
   </gateway>
   <service>
      <role>LIVYSERVER</role>
      <url>https://localhost:8998</url>
   </service>
   <service>
      <role>HIVE</role>
      <url>http://localhost:10001/cliservice</url>
   </service>
  <service>
      <role>KNOX</role>
   </service>
</topology>

I agree with @risdenk: way too much of formatting changes were added with this change.
@nxverma, Could you please first format your newly added and/or modified code so that it'd be easier to review?

@risdenk @smolnar82 please review ... done all refactor of code

@risdenk  raised bug for Hive JWT https://issues.apache.org/jira/browse/KNOX-2150

@pzampino @lmccay Please review

Pulling this locally to cleanup a few formatting things before merging.


Ambiguous docs / usage for Component -> Store listeners

I'm testing out Reflux as a way to simplify my React flow and I'm finding that the docs are somewhat ambiguous about how to best listen to store updates in react components.
In the Store example you provide, its a fairly clear and explicit one-to-one which maps to the common addEventListener(event, method) pattern:
var Store = Reflux.createStore({
    init: function() {
        this.listenTo(actions.fireBall,this.onFireBall);
        this.listenTo(actions.magicMissile,this.onMagicMissile);
    },
    onFireBall: function(){
        // whoooosh!
    },
    onMagicMissile: function(){
        // bzzzzapp!
    }
});

But within the Component it is not so clear, and the docs provide no further clarification of the conventions that you're using:
// Fairly simple view component that outputs to console
function ConsoleComponent() {

    // Registers a console logging callback to the statusStore updates
    statusStore.listen(function(status) {
        console.log('status: ', status);
    });
};

and
var Status = React.createClass({
    mixins: [Reflux.ListenerMixin],
    onStatusChange: function(status) {
        this.setState({
            currentStatus: status
        });
    },
    componentDidMount: function() {
        this.listenTo(statusStore, this.onStatusChange);
    },
    render: function() {
        // render specifics
    }
});

What happens if the store that the component is listening to has multiple methods?  Did you design Reflux to only support one store method per component?   From the above it looks like the mixin is magically connecting events to methods created without explicit intent where the normal pattern (say, with Backbone) is this.listenTo(model, event, method).  The above examples could be written like so, which would be much clearer in terms of intent.
Lastly, here's a better illustration of the problem:
var CommentComponent = React.createClass({
  mixins: [Reflux.ListenerMixin],

  componentDidMount: function () {

    // Problem 1:
    // How do you discern the difference between onFetchComments
    // and onPostComments? Right now our component is just listening
    // to the CommentStore and lots of stuff might be going on.  When
    // onFetchComments is called, so is onPostComment because it gets
    // confused.  How did you envision we should listen to multiple events?

    this.listenTo(CommentStore, this.onFetchComments);
    this.listenTo(CommentStore, this.onPostComment);

    // Problem 2:
    // This is a better implementation, but it breaks if the user is making
    // any sort of async ajax request in the store as it appears to bypass the store completely.
    //  I cant figure out if there's something going on in
    // my code or if there is a bug in the codebase, or if I'm just misunderstanding completely.

    this.listenTo(CommentAction.fetchComments, this.onFetchComments);
    this.listenTo(CommentAction.onPostComment, this.onFetchComments);
  },

})

Another thing that would be nice is if you had actual API docs as opposed to just usage examples.  Like... when you include the Reflux.ListenerMixin, what methods does it supply to the Component?  What is the method signature for this.listenTo?.

But what happens say on the store you send an ajax request to save the comment, when something goes wrong how do you notify the component with error message?

There are several approaches to tackle that. One way would be to have the store call a "commentsavefailed" action which the component is listening to. If it is a more complex app I sometimes have an "errorStore" which listens to error actions called by other stores, and then my component(s) listen to the errorStore.

Thanks @krawaller, yeah ended up with response specific actions which indicates if its success or not.


Add ApplyHelmChart function

Signed-off-by: Utkarsh Srivastava<EMAIL_ADDRESS>Description
This PR adds ApplyHelmChart function. The intent is to have a utility function to help apply custom helm charts.
Supports:

Installation and uninstallation of charts
All storage drivers
chart location as a url as well as in form of repository (url) and chart name.
Override values (equivalent to --set in helm)

Usage:
// Install traefik service mesh using URL
err = client.ApplyHelmChart(k8s.ApplyHelmChartConfig{
		Namespace:       "traefik-mesh",
		CreateNamespace: true,
		URL:             "https://helm.traefik.io/mesh/traefik-mesh-3.0.6.tgz",
})

// Install traefik service mesh using repository
err = cl.ApplyHelmChart(k8s.ApplyHelmChartConfig{
		ChartLocation: k8s.HelmChartLocation{
			Repository: "https://helm.traefik.io/mesh",
			Chart:      "traefik-mesh",
		},
		Namespace:       "traefik-mesh",
		CreateNamespace: true,
})

Tests Done:
Install/Uninstall Traefik Service Mesh using:

[x] Repository and chart name
[x] URL
[x] SQL Driver (postgresql db)
[x] ConfigMap
[x] Secret

Notes for Reviewers
This is the first step towards traefik service mesh :slightly_smiling_face:
Signed commits

[x] Yes, I signed my commits.

You do an excellent job of documenting your work, @utkarsh-pro. It is most helpful. It makes the work higher quality and it easier to review.

LGTM. I can use and test this in the Consul adapter quite soon :+1:


througput_perf failes on RGBA caes on Linux

My original tests were against officially built binaries, so that should have used NASM. I think my failures might be related to #325.

@Brent-A can you add the issue number this is a duplicate of?

Duplicate of #325


BUILD FAILED

Hi, I am facing this issue here. The old sample app used to build without any issues and I can see now the voicehat directory and gRPC directories are added. Please advice.
Error:Execution failed for task ':grpc:generateReleaseProto'.

protoc: stdout: . stderr: /Users/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS PROJECTS/Google Assistant/sample-googleassistant/grpc/build/extracted-protos/main: warning: directory does not exist.
/Users/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS PROJECTS/Google Assistant/sample-googleassistant/grpc/build/extracted-include-protos/main: warning: directory does not exist.
/Users/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS PROJECTS/Google Assistant/sample-googleassistant/grpc/src/release/proto: warning: directory does not exist.
/Users/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS PROJECTS/Google Assistant/sample-googleassistant/grpc/build/extracted-protos/release: warning: directory does not exist.
/Users/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS PROJECTS/Google Assistant/sample-googleassistant/grpc/build/extracted-include-protos/release: warning: directory does not exist.
/Users/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS PROJECTS/Google Assistant/sample-googleassistant/grpc/src/release/proto: warning: directory does not exist.
/Users/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS PROJECTS/Google Assistant/sample-googleassistant/grpc/build/extracted-protos/release: warning: directory does not exist.
/Users/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS PROJECTS/Google Assistant/sample-googleassistant/grpc/build/extracted-include-protos/release: warning: directory does not exist.
google/api/http.proto: File not found.
google/protobuf/descriptor.proto: File not found.
api/annotations.proto: Import "google/api/http.proto" was not found or had errors.
api/annotations.proto: Import "google/protobuf/descriptor.proto" was not found or had errors.
api/annotations.proto:28:8: "google.protobuf.MethodOptions" is not defined.

There was a small bug that popped up in a recent change. It will be fixed
soon.
You'll need to move the protos from sample-googleassistant
https://github.com/androidthings/sample-googleassistant?files=1
/grpc
https://github.com/androidthings/sample-googleassistant/tree/master/grpc/
src
https://github.com/androidthings/sample-googleassistant/tree/master/grpc/src
/main
https://github.com/androidthings/sample-googleassistant/tree/master/grpc/src/main
/proto to sample-googleassistant
https://github.com/androidthings/sample-googleassistant?files=1/grpc
https://github.com/androidthings/sample-googleassistant/tree/master/grpc/
src
https://github.com/androidthings/sample-googleassistant/tree/master/grpc/src
/main
https://github.com/androidthings/sample-googleassistant/tree/master/grpc/src/main
/proto/google
On Aug 8, 2017 5:29 AM, "Sachin"<EMAIL_ADDRESS>wrote:

Hi, I am facing this issue here. The old sample app used to build without
any issues and I can see now the voicehat directory and gRPC directories
are added. Please advice.
Error:Execution failed for task ':grpc:generateReleaseProto'.
protoc: stdout: . stderr: /Users/sachinkumar/Documents/DEVWorskspace/ANDROID
THINGS/ANDROID THINGS PROJECTS/Google Assistant/sample-
googleassistant/grpc/build/extracted-protos/main: warning: directory does
not exist.
/Users/sachinkumar/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS
PROJECTS/Google Assistant/sample-googleassistant/grpc/build/extracted-include-protos/main:
warning: directory does not exist.
/Users/sachinkumar/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS
PROJECTS/Google Assistant/sample-googleassistant/grpc/src/release/proto:
warning: directory does not exist.
/Users/sachinkumar/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS
PROJECTS/Google Assistant/sample-googleassistant/grpc/build/extracted-protos/release:
warning: directory does not exist.
/Users/sachinkumar/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS
PROJECTS/Google Assistant/sample-googleassistant/grpc/build/
extracted-include-protos/release: warning: directory does not exist.
/Users/sachinkumar/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS
PROJECTS/Google Assistant/sample-googleassistant/grpc/src/release/proto:
warning: directory does not exist.
/Users/sachinkumar/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS
PROJECTS/Google Assistant/sample-googleassistant/grpc/build/extracted-protos/release:
warning: directory does not exist.
/Users/sachinkumar/Documents/DEVWorskspace/ANDROID THINGS/ANDROID THINGS
PROJECTS/Google Assistant/sample-googleassistant/grpc/build/
extracted-include-protos/release: warning: directory does not exist.
google/api/http.proto: File not found.
google/protobuf/descriptor.proto: File not found.
api/annotations.proto: Import "google/api/http.proto" was not found or had
errors.
api/annotations.proto: Import "google/protobuf/descriptor.proto" was not
found or had errors.
api/annotations.proto:28:8: "google.protobuf.MethodOptions" is not
defined.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/androidthings/sample-googleassistant/issues/37, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADI588B6wgAX3AtE9IjOd_kSbBODlL9xks5sWFSfgaJpZM4OwqYP
.

This is fixed in commit 66a72976ae5c60894e39a75d56a8a6888cb7a3f5