[FLINK-1417] Automatically register types with Kryo

This pull request also contains code from old pull requests for FLINK-1391, FLINK-1392, FLINK-1395.

Looks good except for the one remark I had.
Did you run any performance tests on this? What is the overhead of using an Avro POJO vs. a plain POJO vs. using the Kryo Serializer?

Thank you for reviewing the pull request.
I've addressed your remark, added a fix for another issue (FLINK-1567) and now I'll run the performance tests.

The pull request now also contains changes to fix two classloading issues with the newly added ExecutionConfig.
Also, it fixes the Web interface for YARN.
I would like to merge this change soon. I've tested the code on extensively on a cluster and it seems to be stable.
I'm still working on the performance numbers.
The results I've got so far are the following:
Scale Factor 1 (lineitem only)
Pojo: 20
Kryo (with key selectors):  13
Avro (with key selectors): 10, 15, 13
Scale factor 100:
Pojo: 1634,
I'll update the comment to complete it.

What exactly are you running? TPC-H Query 3? Maybe we should test how fast Kryo would be with the PojoComparator.

No, its basically CoGrouping two "big" files (~50 and ~75 GB)
https://github.com/project-flink/flink-perf/blob/master/flink-jobs/src/main/java/com/github/projectflink/avro/AvroPerf.java

I would like to merge this pull request soon.
@aljoscha, do you agree that we can investigate the performance for the PojoComparator also when the change is merged?

 But if our Pojo stuff is really that slow we should think about how to improve that or remove it alltogether.

Yes.  First we need to understand why exactly the performance is so poor. Maybe its an issue we can "easily" fix.

Merging it now....


Move mouse automatically to focused windows when using multiple screens

Description of the new feature / enhancement
Hi, I use multiple screens daily and would like to get a way to move automatically to the windows opened recently, it is in the task bar minimized and when you clicked to focused on it you need to move the mouse to the screen where is the window recentrly focused, this feature would improve efficiency with multiple monitors.
Scenario when this would be used?
Every time you clicked in a minimized app, and every time you open a new one and are using multiple monitors, It would be less mouse movements.
Supporting information
No response

For sure!


Using output of nested stacks in other nested stacks?

I'm building my own stacks for my API and was going along great building 1 stack per dynamodb table, essentially -- 1 stack per data source since all of my basic resolvers operated on only a single data source.
However now I'm trying to include my pipeline resolvers - which include functions that reference various data sources.  I thought I would be able to get the function ids out of their stacks as Output properties -- but the problem is the nested stacks get created in an unpredictable order so it's a race condition if the output exists by the time I try to reference it.
I don't see a way to determine this order or tell a stack that it depends on another stack.  My solution for now is to just put all of these things into 1 big stack which isn't great for maintainability.
I also tried adding a custom stack as explained in the docs and make it depend on my api stack but my problem there is I think the service still needs to be AppSync -- which seemed to basically just not work.  Any advice or am I stuck for now with 1 big stack?

@chadkouse It is not clear to me which parts of your solution are you leveraging the CLI and what is being done manually. Please explain it in more details and a look at your directory structure could also help, but we need more clarification.
That is true that currently custom stacks/resources are supported only in the API category, it is not something that we support today at project level and I assume that is something that you'd need?

Thanks for responding! To clear things up here is how I am doing things:

DynamoDB tables are being created and maintained manually (I just found things too easy to mess up using the schema to generate the tables)
Lambda functions (used in pipeline resolvers) are being created and maintained manually
The AppSync portion as far as defining the schema and all of it's resolvers is all being done using CFN templates and the amplify cli

Directory structure is as follows:
- amplify/
   + #current-cloud-backend/
   - backend/
     - api/
       - myapiname/
         + build/
         - resolvers/
              ... many vtl files ...
         + src/
         - stacks/
              SomeTable.json
              SomeOtherTable.json
              AnotherTable.json
              ...etc...
           parameters.json
           schema.graphql
           transform.conf.json

I'm finding that slowly I'm having to merge all of the files under stacks into one big stack because they reference each others data sources (and functions) for resolvers (and pipeline resolvers) -- and I can't seem to get information about those things to be shared across the sibling stacks.  Also since I can't determine the order of the sibling stacks being created I can't ensure that their outputs will be available when needed.  Hope I'm kinda making sense here :dizzy_face:

@chadkouse it turns out that I was wrong about not supporting custom cloudformation resources, there is a way to include them in your project and they don't have to be connected to an AppSync API. Take a look at the documentation here if it would help your case: https://aws-amplify.github.io/docs/cli-toolchain/quickstart#custom-cloudformation-stacks
I'd suggest to generate a GraphQL API with the CLI with some types and check out how we structure/reference the related resources, arranging the stacks. Perhaps with proper (multiple) nesting - instead of 1 big monolith - you can achieve the same for your purposes.
Regarding parameter passing, there are some samples in the comments of this issue: https://github.com/aws-amplify/amplify-cli/issues/1002
Get back to us if this helps, so we can close the issue then.

@chadkouse: most straightforward way to go is using Fn::ImportValue. For short, your nested stack outputs have extra property: Export that define export name. Those exported values are available globally within a aws region (you can see all exported values in CloudFormation console). They can latter be thrown in any other stack with Fn::ImportValue, hope this helps

I'll be trying these suggestions soon thanks for the info.  One question, you mention multiple nesting?  Is this something that can be done within my amplify project or do you mean outside of the project?

@chadkouse under multiple nesting I meant root-nested-nested structure, like a wrapper stack over others. I'm closing the issue as the other part of the question was answered by @ambientlight

Note that export and import are only useful in unrelated stacks. Amplify generates a single CloudFormation stack. Particularly custom stacks in the api category are generated concurrently.
If you use custom stacks as per the documentation use the dependsOn feature. That works well.

@chadkouse under multiple nesting I meant root-nested-nested structure, like a wrapper stack over others. I'm closing the issue as the other part of the question was answered by @ambientlight

How do I go about solving this problem using multiple nesting? I expect that I would configure a resource of type AWS::CloudFormation::Stack. Do I put the nested stack within the /stacks directory or elsewhere?


Link in docs is dead

This page links to:
https://docs.rs/cortex-m-quickstart/~0.3
which redirects to:
https://docs.rs/cortex-m-quickstart/0.3.3/cortex_m_quickstart/
which is a dead link:
The requested resource does not exist

This is a known problem and is waiting for updates of docs.rs, see: https://github.com/rust-embedded/cortex-m-quickstart/issues/36 or your own issue: https://github.com/onur/docs.rs/issues/226
Last documentation that was build is: https://docs.rs/cortex-m-quickstart/0.3.1/cortex_m_quickstart/

It seems this issue was resolved, ready to be closed.


Troubles getting this to run on macOS Sierra 10.0.3

Struggling to get the latest commit to work on macOS Sierra 10.0.3; spent some time troubleshooting, and eventually found this fork: https://github.com/butuh/usergrid-vagrant which seems to work. Might be worth having it merged back into master?
Here's the error that was throwing — seems none of the services installed successfully.
curl: (7) Failed to connect to localhost port 8080: Connection refused
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what
went wrong.

I've had the same issue and noticed that the bootstrap script didn't install the JDK 8 at all. On the VM only  the JDK 6 was available. I've installed the JDK 8 manually on the VM using the commands from the bootstrap script:
add-apt-repository -y ppa:openjdk-r/ppa
apt-get update
apt-get -y install vim curl openjdk-8-jdk
After the JDK 8 has been installed successfully I ran "vagrant provision" on command line and everything worked fine.


v8: mark vulnerable, move dependents to nodejs.libv8

Description of changes
nixpkgs v8 package is basically unmaintained (no upgrade in 3 years) and it appears we can move all the dependents to nodejs.liblv8.

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 315851 run on aarch64-linux 1

10 packages marked as broken and skipped:

postgresql12JitPackages.plv8
postgresql13JitPackages.plv8
postgresql14JitPackages.plv8
postgresql15JitPackages.plv8
postgresql16JitPackages.plv8
postgresqlJitPackages.plv8
rubyPackages.libv8
rubyPackages_3_1.libv8
rubyPackages_3_2.libv8
rubyPackages_3_3.libv8

31 packages built:

discourse
discourseAllPlugins
gitlab
gitlab-ee
gollum
jasp-desktop
mailcatcher
postgresql12Packages.plv8
postgresql13Packages.plv8
postgresql14Packages.plv8
postgresqlPackages.plv8 (postgresql15Packages.plv8)
postgresql16Packages.plv8
rubyPackages.coffee-script (rubyPackages_3_1.coffee-script)
rubyPackages.execjs (rubyPackages_3_1.execjs)
rubyPackages.github-pages (rubyPackages_3_1.github-pages)
rubyPackages.jekyll-coffeescript (rubyPackages_3_1.jekyll-coffeescript)
rubyPackages.jekyll-webmention_io (rubyPackages_3_1.jekyll-webmention_io)
rubyPackages.uglifier (rubyPackages_3_1.uglifier)
rubyPackages_3_2.coffee-script
rubyPackages_3_2.execjs
rubyPackages_3_2.github-pages
rubyPackages_3_2.jekyll-coffeescript
rubyPackages_3_2.jekyll-webmention_io
rubyPackages_3_2.uglifier
rubyPackages_3_3.coffee-script
rubyPackages_3_3.execjs
rubyPackages_3_3.github-pages
rubyPackages_3_3.jekyll-coffeescript
rubyPackages_3_3.jekyll-webmention_io
rubyPackages_3_3.uglifier
zammad

<!--
To help with the large amounts of pull requests, we would appreciate your
reviews of other pull requests, especially simple package updates. Just leave a
comment describing what you have tested in the relevant package/service.
Reviewing helps to reduce the average time-to-merge for everyone.
Thanks a lot if you do!
<p>List of open PRs: https://github.com/NixOS/nixpkgs/pulls
Reviewing guidelines: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#reviewing-contributions
-->

Add a :+1: reaction to pull requests you find important.

Seems good! Actually I'm thinking whether we should just remove the v8 package altogether?

It's likely what's going to happen in the long run but we can probably have a "grace period" before the definitive removal.
It leaves the door open if someone wants to step up and start maintaining the package if they have a specific use case not covered with nodejs/nodejs.libv8 (yes I'm optimistic :smile: ).

I also added a backport label to at least 24.05, feel free to remove in case you think that's wrong.

I think it's good, we don't have many other options for 24.05.

Technically and theoretically we could tie v8 and chromium bumps together.
Especially because v8's release cycle is more or less "the latest stable v8 version is whatever chromium stable uses and ships with".
We, the current chromium.meta.maintainers (@networkException and I), however, are already at capacity.
So I would heavily prefer the solution with nodejs.libv8 and simply marking v8 and insecure and dropping it eventually :)

Thanks for the feedback! I also believe that it is a better call to move to nodejs.libv8 overall.
I'm going to update this PR to add myself as a maintainer v8 so I can be notified if thing changes. To be honest my goal is either to get people involved or to drop the package before 24.11.
Maintaining Chromium and NodeJs  is already hard enough, I believe we should try to make it as simple as possible.
This includes, in my personal opinion,  not maintaining stuff requiring 1h+ build (on a quite modern build machine) with no active maintainers.
Personal note: maintainer of Chromium and NodeJS stuff you are awesome, thanks a lot for your work ♥


Question about self-positioning points

How should I understand zs in formula 3 for calculating self positioning points in the paper? zs is described in the paper as lantent vector? What does latent vecor refer to?

Yes, zs is a latent vector, which means learnable parameters.


unmarshalling JSON error in DeploymentOperationsClient.ListNextResults

Failure responding to next results request:
StatusCode=200 -- Original Error: Error occurred unmarshalling JSON - Error = 'json: cannot unmarshal string into Go struct field DeploymentOperationProperties.statusMessage of type map[string]interface {}' JSON = '{"value":[{"id":"/subscriptions/3014546b-7d1c-4f80-8523-f24a9976fe6a/resourceGroups/ds-acse-tst40/providers/Microsoft.Resources/deployments/agent-18-01-03T10.39.23-1324017081/operations/08586866021206228739","operationId":"08586866021206228739","properties":{"provisioningOperation":"EvaluateDeploymentOutput","provisioningState":"Failed","timestamp":"2018-01-03T18:41:51.0473602Z","duration":"PT0.5431112S","trackingId":"98f19b12-ae95-49db-953b-6c983868f5e4","statusCode":"Conflict","statusMessage":"Template output evaluation skipped: at least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details."}}]}'

By comparing JSON data with DeploymentOperationProperties, the latter

doesn't have duration field
has StatusMessage is a map, not a string

This should be fixed in v14.0.0.  The statusMessage field is now defined as interface{} so you will need to perform type assertion to determine if it's a string or JSON object.


Windows, WASI targets support

Following-up the idea in https://github.com/turbolent/w2c2/issues/1#issuecomment-1019954628

Allow disabling pthreads
Initial Windows target support (no parallel mode + getopt impl)
Initial WASI target support
Skip creating empty files in parallel mode

@turbolent please review

You can build WASI-powered w2c2.wasm now, using wasienv:
wasimake make

@turbolent should be ready for merge

Great, thank you again!


Feature/universal navigation link fix

Re: https://github.com/mplusmuseum/mplusmuseum-stories/issues/254#issue-438998533

Tested and seems to work with the current data exposed by the CMS.


fix: env table config can't trigger rebuild with rerun-if-env-changed.

What does this PR try to resolve?
As #10358 said, When a build.rs script emits cargo:rerun-if-env-changed, it is not re-run when the value of the specified variable is changed via the env configuration.
Fixes #10358
How should we test and review this PR?
Add test bofore fixing to reflect the issue, the next commit fixed it.
Additional information
The PR is a sucessor of https://github.com/rust-lang/cargo/pull/14058, so the previous dicussion can be refer to it.

I removed the code that makes env_config case insensitivity in Windows.  Resolving env_config's case sensitivity due to operating system platform differences is far more complicated than fixing this issue, so I left it to a possible future PR and made this PR easier to merge.


Not able to run the sample app

Hello
command npm run start:servers says :
Error   |basic-viewport-app| Bad Request: Node.js version v14.15.1 is not within the range acceptable to imodeljs-backend: (>=10.16.0 <13.0)
Thanks for you help
Remy weill

⚠ Do not edit this section. It is required for imodeljs.github.io ➟ GitHub issue linking

LINK: Getting-started-(online-quick-start)---iTwin.js-link-to-docs
TAG: imodeljs-docs-question
SOURCE: https://www.itwinjs.org/getting-started/online-quickstart/

@RWeill iModel.js does not currently support Node 14.x. We are working on the support and will hopefully have it available soon.  #175 is the PR we're working to add that support.

I have noticed that imodeljs support solar and ambient, do we have plans to support more light source? like Point light source ,thanks!

We don't have any immediate plans to add new light types, primarily because we haven't received any requests to do so.


Discrepancy between full indexing vs incremental indexing

Consider full index to be an index of all documents (say A + B) and incremental index which started with A and then added B using IndexUpdater. I'm getting different results for the same query.
Here's the minimal reproducible example.
import os
from pathlib import Path
import shutil

from colbert import Indexer, Searcher, IndexUpdater
from colbert.infra import ColBERTConfig, Run, RunConfig

# Pid: 1-11
modern_books = [
    "The song of ice and fire"*10,
    "Harry Potter and the Sorcerer's Stone"*10,
    "The Hunger Games"*10,
    "The Fellowship of the Ring"*10,
    "The Two Towers",
    "The Return of the King",
    "The Hobbit",
    "The Lord of the Rings",
    "The Hitchhiker's Guide to the Galaxy",
    "Seventy-Seven Clocks",
    "I, Robot",
    "Life, the Universe and Everything",
]

# Pid: 12-14
old_books_1 = [
    "The Adventures of Sherlock Holmes",
    "The Adventures of Tom Sawyer",
    "The Adventures of Huckleberry Finn",
]

full_index = "full_index"
incremental_index = "incremental_index"

# Path to colbert v2 checkpoint
colbert_checkpoint = "colbertv2.0/"

if __name__ == "__main__":
    try:
        with Run().context(
            RunConfig(
                nranks=1,
                root=full_index,
                experiment="",
            )
        ):
            config = ColBERTConfig(nbits=2, root=full_index, doc_maxlen=100)
            indexer = Indexer(checkpoint=colbert_checkpoint, config=config)

            indexer.index(
                name="msmarco.nbits=2",
                collection=modern_books + old_books_1
            )

            searcher = Searcher(index="msmarco.nbits=2", config=config)
            config = ColBERTConfig(nbits=2, root=full_index, doc_maxlen=100)

            results = searcher.search("Sherlock", 3)
            print(results)
    finally:
        shutil.rmtree(full_index)

    try:
        with Run().context(
            RunConfig(
                nranks=1,
                root=incremental_index,
                experiment="",
            )
        ):
            config = ColBERTConfig(nbits=2, root=incremental_index, doc_maxlen=100)
            indexer = Indexer(checkpoint=colbert_checkpoint, config=config)

            indexer.index(
                name="msmarco.nbits=2",
                collection=modern_books
            )

        with Run().context(
            RunConfig(
                nranks=1,
                root=incremental_index,
                experiment="",
            )
        ):
            searcher = Searcher(index="msmarco.nbits=2", config=config)
            config = ColBERTConfig(nbits=2, root=incremental_index, doc_maxlen=100)
            index_updater = IndexUpdater(
                config=config, searcher=searcher, checkpoint=colbert_checkpoint
            )

            index_updater.add(old_books_1)
            index_updater.persist_to_disk()
            results = searcher.search("Sherlock", 3)
            print(results)

    finally:
        shutil.rmtree(incremental_index)

Output:
([12, 12, 12], [1, 2, 3], [25.370983123779297, 25.370983123779297, 25.370983123779297])
([10, 6, 13], [1, 2, 3], [9.62167739868164, 8.728744506835938, 8.65077018737793])

The two outputs should be the same and should be document 12. The two search queries should give identical results
Let me know if there's anything wrong in the way I'm calling the functions. I'll post an update if I find a fix.

Are the results correct if you search before persisting to disk? You may need to reload the Searcher after persisting to disk.

The results are incorrect. I tried searching before persisting to disk and also reloading the Searcher after persisting to disk. I still get the incorrect result for all cases.
([10, 6, 13], [1, 2, 3], [9.62167739868164, 8.728744506835938, 8.65077018737793])

reference code
if __name__ == "__main__":
    try:
        with Run().context(
            RunConfig(
                nranks=1,
                root=full_index,
                experiment="",
            )
        ):
            config = ColBERTConfig(nbits=2, root=full_index, doc_maxlen=100)
            indexer = Indexer(checkpoint=colbert_checkpoint, config=config)

            indexer.index(
                name="msmarco.nbits=2",
                collection=modern_books + old_books_1
            )

            searcher = Searcher(index="msmarco.nbits=2", config=config)
            config = ColBERTConfig(nbits=2, root=full_index, doc_maxlen=100)

            results = searcher.search("Sherlock", 3)
            print(results)
    finally:
        shutil.rmtree(full_index)

    try:
        with Run().context(
            RunConfig(
                nranks=1,
                root=incremental_index,
                experiment="",
            )
        ):
            config = ColBERTConfig(nbits=2, root=incremental_index, doc_maxlen=100)
            indexer = Indexer(checkpoint=colbert_checkpoint, config=config)

            indexer.index(
                name="msmarco.nbits=2",
                collection=modern_books
            )

            searcher = Searcher(index="msmarco.nbits=2", config=config)
            config = ColBERTConfig(nbits=2, root=incremental_index, doc_maxlen=100)
            index_updater = IndexUpdater(
                config=config, searcher=searcher, checkpoint=colbert_checkpoint
            )

            index_updater.add(old_books_1)
            results = searcher.search("Sherlock", 3)
            print(results)

            index_updater.persist_to_disk()
            results = searcher.search("Sherlock", 3)
            print(results)

        with Run().context(
            RunConfig(
                nranks=1,
                root=incremental_index,
                experiment="",
            )
        ):
            config = ColBERTConfig(nbits=2, root=incremental_index, doc_maxlen=100)
            searcher = Searcher(index="msmarco.nbits=2", config=config)
            results = searcher.search("Sherlock", 3)
            print(results)

    finally:
        shutil.rmtree(incremental_index)

Can you check the actual passage text in case the passage ids are different between the indexes?

Hi @sarisel . I am able to replicate this issue. Wondering if anyone has taken a look..

We played with this more w/ @jessiejuachon. Seems like it's just an artifact of clustering at tiny scales. If you have only a handful of documents, the clusters generated for colbertv2 compression aren't gonna generalize well to unseen embeddings (that are inserted after clustering is done).
Doing this at >5k scale (before insertion) and/or increasing nbits to {say, 4 or 8} helps tremendously. Scores will never be identical (except maybe in the limit!) but they'll get very close.

In general, though, we should probably add a setting to colbert that avoids any quantization/compression/clustering if the index is below 2,000 passages or something. OR uses a predefined set of clusters, if the index is so small.


fixes to include vpc security group in rds response

@spulec or @bblommers : can either of you take a look at this PR? This addresses https://github.com/getmoto/moto/issues/6467 issue.

@bblommers : Addressed the linting issues that were flagged by the linter.

This is now fixed in #6567


V18 hangs on main thread when unresolved promise

Description
We have a Promise that waits for confirmation result from a dialog. This use to work fine with v17, but on v18 synchronization is waiting for all promises to complete, causing a deadlock.
I tried to disable synchronization but it seems that it isn't supported with v18
Reproduction
Provide the steps necessary to reproduce the issue. If you are seeing a regression, try to provide the last known version where the issue did not reproduce.

Create a promise that only resolves once onClick of button or view has been tapped

Expected behavior
promises on main thread should not wait for synchronization (as with v17) or we need to have a way to disable synchronization for main thread.
Environment (please complete the following information):

Detox: 10.1.0
React Native: 0.63.3
Node: v15.4.0
Device: iPhone 8 Plus
Xcode: 12.3
iOS: 14.2
macOS: 11.1

Logs
detox[11736] INFO:  [actions.js] The system is busy with the following tasks:

Dispatch Queue
⏱ Queue: “Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)” with 1 work blocks

Run Loop
⏱ “Main Run Loop”

UI Elements
⏱ 0 layer animations pending
detox[11736] INFO:  [actions.js] The system is busy with the following tasks:

Dispatch Queue
⏱ Queue: “Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)” with 1 work blocks

Run Loop
⏱ “Main Run Loop”

UI Elements
⏱ 0 layer animations pending
detox[11736] INFO:  [actions.js] The system is busy with the following tasks:

Dispatch Queue
⏱ Queue: “Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)” with 1 work blocks

Run Loop
⏱ “Main Run Loop”

UI Elements
⏱ 0 layer animations pending
detox[11736] INFO:  [actions.js] The system is busy with the following tasks:

Dispatch Queue
⏱ Queue: “Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)” with 1 work blocks

Run Loop
⏱ “Main Run Loop”

UI Elements
⏱ 0 layer animations pending
detox[11736] DEBUG: [exec.js/EXEC_SUCCESS, #16] Matched Finger!
detox[11736] INFO:  [actions.js] The system is busy with the following tasks:

Dispatch Queue
⏱ Queue: “Main Queue (<OS_dispatch_queue_main: com.apple.main-thread>)” with 1 work blocks

Run Loop
⏱ “JS Run Loop”
⏱ “Main Run Loop”

One Time Events
⏱ “Runloop Perform Block” with object: “JS Run Loop”
⏱ “Runloop Perform Block” with object: “JS Run Loop”
⏱ “Runloop Perform Block” with object: “JS Run Loop”
⏱ “Runloop Perform Block” with object: “JS Run Loop”
⏱ “Runloop Perform Block” with object: “JS Run Loop”
⏱ “Runloop Perform Block” with object: “JS Run Loop”

If you are experiencing a timeout in your test

[x] I have followed the instructions under Lower-level Idling Resources Debug and am providing the log below:

Device and verbose Detox logs

[x] I have run my tests using the --loglevel trace argument and am providing the verbose log below:

“ ⏱ 0 layer animations pending”
While the “0” is incorrectly reported, and has already been fixed in master, it looks like you have an infinite animation, likely from a spinning activity indicator view.
You should either mock or disable infinite animations for tests.

“ ⏱ 0 layer animations pending”
While the “0” is incorrectly reported, and has already been fixed in master, it looks like you have an infinite animation, likely from a spinning activity indicator view.
You should either mock or disable infinite animations for tests.

@LeoNatan Not the case, this was my first thought too but i've confirmed that it's caused by a promise, like I said, this works just fine on v17, and continues to work fine on android. Once i switched from promise to callback, things started to work again.
The issue seems to be that the promise is awaiting to continue, but the resolve() function from the promise is triggered by the confirm/cancel buttons from the dialog buttons. This seems to create a deadlock where detox can never click the button to resolve the promise, because it's waiting for the promise to be resolved first.

@LeoNatan Not the case, this was my first thought too but i've confirmed that it's caused by a promise, like I said, this works just fine on v17, and continues to work fine on android. Once i switched from promise to callback, things started to work again.
The issue seems to be that the promise is awaiting to continue, but the resolve() function from the promise is triggered by the confirm/cancel buttons from the dialog buttons. This seems to create a deadlock where detox can never click the button to resolve the promise, because it's waiting for the promise to be resolved first.

Promise is a JS concept and has nothing to do with Detox, which operates at the native layer.

Promise is a JS concept and has nothing to do with Detox, which operates at the native layer.

On the other hand, the idle status you provided in the log doesn’t lie. There is an infinite animation somewhere.

On the other hand, the idle status you provided in the log doesn’t lie. There is an infinite animation somewhere.

@LeoNatan Ok thanks, i will continue to investigate. In the meantime, is there some way to disableSynchronization with v18?

@LeoNatan Ok thanks, i will continue to investigate. In the meantime, is there some way to disableSynchronization with v18?

Yes, same API as before.

Yes, same API as before.

@LeoNatan Hmm... Interesting, it doesn't seem to work for me. Let me try again. Thanks for the feedback

@LeoNatan Hmm... Interesting, it doesn't seem to work for me. Let me try again. Thanks for the feedback

You may need to launch the app with sync disabled, if this is on launch.

You may need to launch the app with sync disabled, if this is on launch.

@LeoNatan This issue doesn't occur on launch, only happens at the very end of the test. Just for reference, 99% of our tests are working just fine, we even use the same modal in all of them, the only difference is this promise that we're using in this specific scenario that causes a deadlock, like i said we've been using v17 for many months now without any issues, issue popped up on iOS only as soon as we switched to v18. Let me investigate further, worst case scenario we'll have to replace the promise with callback, which is janky as hell, but can be done

@LeoNatan This issue doesn't occur on launch, only happens at the very end of the test. Just for reference, 99% of our tests are working just fine, we even use the same modal in all of them, the only difference is this promise that we're using in this specific scenario that causes a deadlock, like i said we've been using v17 for many months now without any issues, issue popped up on iOS only as soon as we switched to v18. Let me investigate further, worst case scenario we'll have to replace the promise with callback, which is janky as hell, but can be done

As I said, Detox has no awareness of your JS code, such as promises. If the log says later animation, that's what it is.

As I said, Detox has no awareness of your JS code, such as promises. If the log says later animation, that's what it is.

@LeoNatan Thanks for pushing me in the right direction, after investigating deep i realized that we show a spinner on the button when submitting, I couldn't see it because it was rendered underneath the modal. Switching this animation off for Detox builds have resolved the issue. Thanks for the help!

@LeoNatan Thanks for pushing me in the right direction, after investigating deep i realized that we show a spinner on the button when submitting, I couldn't see it because it was rendered underneath the modal. Switching this animation off for Detox builds have resolved the issue. Thanks for the help!

Just documenting here - my problem causing "The system is busy with the following tasks" was not awaiting device.launchApp() in the tests file.  Fixed like this:
 beforeAll(async() => {
  await device.launchApp()
 })

Also, for anyone that could not find animations, make sure things like API calls are not in an infinite loop.

@jkhusanov FYI when running with Detox's debug-synchronization feature enabled (on by default), you should be able to get specific logs telling you what's holding the app back from going idle - so as to save your time on inspecting whether these are animations or network calls that are behind it.

@lukewlms I am already using
beforeAll(async() => {
await device.launchApp()
})
but still facing the issue defined by you on iOS, the scripts very well on android, any suggestions how can I rectify it ?

@martintreurnicht could you please advise how you did "after investigating deeper i realized that we show a spinner on the button when submitting", as I am also suspecting the same in the AUT

@martintreurnicht could you please advise how you did "after investigating deeper i realized that we show a spinner on the button when submitting", as I am also suspecting the same in the AUT

@annuneetu Nothing special. I just started removing components from the screen until it started working. In this case i actually just made the code do everything other than opening the dialog, and that is when i saw the spinner and put 2 and 2 together, just be systematic and try and narrow the scope of the issue. If this is a new implementation i would also not rule out the possibility that the promise isn't being resolved correctly


PULL_REQUEST_TEMPLATE.md: made instructions shorter and simpler

Many people still fill the “adding a new cask” part even when not adding a new cask, or do not delete parts of the instructions.
Apart from those who do those things by mistake, it must also be a bore for regular contributors to constantly be deleting parts of the template.
This new template aims to not make users delete any part of it (if they don’t want to), and instead just fill what’s relevant to their case. Instructions are also shorter, so they can be left without taking too much space.
If agreed upon, we’ll need to run the script to sync this to other repos.

I feel like the “{{cask_file}} is a placeholder” text could be omitted, or at least shortened, because if you can't figure that out, you are likely to need further help with a PR anyways. (I know that this was probably added for a reason, so I may be wrong about that.)
I don't have any specific comments for the rest, so instead I made a counter proposal. The main changes:

order of check points (vaguely sorted by importance)
link references so that all check points fit on one line

*If there’s a checkbox you can’t complete for any reason, that's okay,
just explain in detail why you weren’t able to do so.*

After making all changes to the cask:

- [ ] `brew cask audit --download {{cask_file}}` is error-free.
- [ ] `brew cask style --fix {{cask_file}}` reports no offenses.
- [ ] The commit message includes the cask’s name and version.

Aditionally, **if adding a new cask**:

- [ ] Named the cask according to the [token reference].
- [ ] `brew cask install {{cask_file}}` worked successfully.
- [ ] `brew cask uninstall {{cask_file}}` worked successfully.
- [ ] Checked there are no [open pull requests] for the same cask.
- [ ] Checked that the cask was not already refused in [closed issues].

[token reference]: https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/token_reference.md
[open pull requests]: https://github.com/caskroom/homebrew-cask/pulls
[closed issues]: https://github.com/caskroom/homebrew-cask/issues?q=is%3Aissue+is%3Aclosed

I like your revision and changed the commit to it.

LGTM


feat: read environment specific configuration

It would be great if babel-plugin-styled-components could read environment specific option when using via babel-plugin-macros instead of directly using this plugin.
As far as i know, babel-plugin-macros supports configuration via cosmiconfig from package.json or various .rc or .config files, but it doesn't allow environment specifics.
I'd love to use styled-components via macros without configuring this plugin manually, but still be able to do things like { displayName: true } in development and { displayName: false } in production.
This PR enables that usecase.

No comment from reviewers, alternate solution possible via babel-config-macro javascript configuration file. Guess this isn't wanted, so i closed it.


Sync master with develop

@homu r+

:pushpin: Commit 7372d32 has been approved by poteto

:hourglass: Testing commit 7372d32 with merge d357fb5...

:broken_heart: Test failed - status

@homu retry

@homu r+

:pushpin: Commit dc70509 has been approved by poteto

:zap: Test exempted - status


New select component broken on mobile screens

First of all: the new select component is great.
However, it does have a bug. When opened, the select options float out of view in the top right corner of the screen instead of, what I assume is the intention, in the middle of the screen like dropdowns, which work as intended.
I really love your work on Buefy :)

Thanks, looks like the page layout is overflowing because of the Addons, taking a closer look.


Storyshot doesn't load addons

Work summary
My previous PRs (https://github.com/storybooks/storybook/pull/4081, https://github.com/storybooks/storybook/pull/4176) had the goal to set a different background for storyshot tests. But I just noticed that the addons aren't loaded in storyshot tests, because they open the iframe.html directly. We would need to modify storyshot so it loads the "normal" storybook example, but without the "chrome" (e.g. without the navigation on the left side and the addon tabs in the bottom). Maybe this behavior could be triggered with a new config parameter (e.g. withAddons: true).
Where to start

const { imageSnapshot } = require('@storybook/addon-storyshots-puppeteer'); needs to accept a new config parameter withAddons?: boolean (in case we don't want to enforce this new behavior by default).
We still have a storybookUrl like http://localhost:9001?background=transparent, but now we don't add /iframe to the URL (see here), but maybe something like ?chromeless and load the real storybook instance.
The storybook would need to accept ?chromeless as a param to hide the navigation and addons panel (may this would be a good place to do it?).
Update docs to inclue withAddons?: boolean and ?chromeless in the right places.

Acceptance criteria
I can create a storyshot tests which uses a storybookUrl like http://localhost:9001?background=transparent which actually switches a real background named transparent in a storybook instance which uses @storybook/addon-backgrounds.
Who to contact
Add yourself and/or people who are familiar with the code changes and requirements. These people should be able to review the completed code.
End work issue - please tag this issue with the correct status and type labels

(Some general feedback: I feel like the initial GitHub issue template is a little bit complicated. It always takes a minute for me to figure out what I actually need to write. 😕)

+1 this would be handy


Los2119/hw2

Dear professor,
I experienced a few challenges that made this part 2 especially challenging and I had to make some quick decisions:
The biggest issue was the fact that another student had a matplotlib.md file which raised additional merge conflicts. I wasn't sure about what to do ultimately so I just added my changes below theirs due to certain discrepancies. I'm not sure if that approach was the best but that left me with multiple attempts at part2 which ultimately rendered my pick and squash commands unexecuted, leaving multiple commits in this pr. I still have screenshots of all the work I did in my local repo before the deadline to show.

New pr with all resolved issues in a single commit here


Revert "Add missing space for the last comment"

Reverts github/gitignore#2278

@sepatus why does this need to be reverted?

Closing this out due to inactivity


Refine business requirements

Let's discuss & refine requirements: https://github.com/stereohorse/stream-search/wiki/Initial-business-requirements

Sketch for UI
https://excalidraw.com/#json=QmcIkGkio40psBH9N5Rbx,KWi9YMw9gbdsmbOfGlHhPw

Shared whiteboard for our design:
https://link.excalidraw.com/l/fYaWEqEwRa/8ysxXUhr3Wd


Libp2p - weird behaviors

We now have a comparative baseline simulation using libp2p where each peer connects to a few other peers (designated as a parameter "Count" in a config file), subscribe to the "handel" topic, broadcast their signature and wait to receive enough signatures.
Unfortunately, this simulation exhibits weird behaviors (~failures) of the libp2p pubsub library. We can tests these failures in two different ways, in the fail_libp2p branch:

Running the test TestGossipMeshy in simul/p2p/libp2p which is directly inspired from the tests found in the libp2p/pubsub repo.
Running the simulation in simul/ with go run main.go -config config_gossip.toml -platform localhost - It's the generalization of the tests. Even with a large number of connected peers, the simulation fails most often.

Please note that sometime theses tests pass, but most often they don't - repeat the experience !
For the test, using a Neighbor connector that makes each peer connects only to some "neighbors" in the ID space (modulo), so all peer's connections form a circle - it's a completely connected graph. On the contrary, using Random connector that randomly connects peers (as in the libp2p pubsub's tests) fails most of the time.

Thanks for the link @nikkolasg.
@vyzo mind taking a look here and seeing whats up?

sure

Is the network generated by RandomConnector actually connected? That would explain the failures.

I also noticed another thing: you only wait for 1s, with the heartbeat at 700ms. You should wait at least 4-5 heartbeats as message will propagate via gossip in the of a not fully connected mesh.


CI failing with 'service did not take the steps required by its unit configuration'

TASK [geerlingguy.jenkins : Modify variables in init file.] ********************
(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:216)
  changed: [instance] => (item={'option': 'JENKINS_OPTS', 'value': ''})
(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:217)
  changed: [instance] => (item={'option': 'JAVA_OPTS', 'value': '-Djenkins.install.runSetupWizard=false'})
(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:218)
  changed: [instance] => (item={'option': 'JENKINS_HOME', 'value': '/var/lib/jenkins'})
(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:219)
  changed: [instance] => (item={'option': 'JENKINS_PREFIX', 'value': ''})
(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:220)
  changed: [instance] => (item={'option': 'JENKINS_PORT', 'value': 8080})
(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:221)

(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:222)
  TASK [geerlingguy.jenkins : Ensure jenkins_home /var/lib/jenkins exists.] ******
(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:223)
  ok: [instance]
(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:224)

(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:225)
  TASK [geerlingguy.jenkins : Immediately restart Jenkins on init config changes.] ***
(https://github.com/geerlingguy/ansible-role-jenkins/runs/8094535048?check_suite_focus=true#step:5:226)
  fatal: [instance]: FAILED! => {"changed": false, "msg": "Unable to start service jenkins: Job for jenkins.service failed because the service did not take the steps required by its unit configuration.\nSee \"systemctl status jenkins.service\" and \"journalctl -xe\" for details.\n"}

Ah... at least on Rocky Linux it's a Java minimum version issue:
Aug 30 14:44:28 instance systemd[1]: Starting Jenkins Continuous Integration Server...
░░ Subject: A start job for unit jenkins.service has begun execution
░░ Defined-By: systemd
░░ Support: http://www.ubuntu.com/support
░░
░░ A start job for unit jenkins.service has begun execution.
░░
░░ The job identifier is 385.
Aug 30 14:44:28 instance jenkins[5832]: Aug 30, 2022 2:44:28 PM executable.Main verifyJavaVersion
Aug 30 14:44:28 instance jenkins[5832]: SEVERE: Running with Java class version 52, which is older than the Minimum required version 55. See https://jenkins.io/redirect/java-support/
Aug 30 14:44:28 instance jenkins[5832]: java.lang.UnsupportedClassVersionError: 52.0
Aug 30 14:44:28 instance jenkins[5832]:         at executable.Main.verifyJavaVersion(Main.java:145)
Aug 30 14:44:28 instance jenkins[5832]:         at executable.Main.main(Main.java:109)
Aug 30 14:44:28 instance jenkins[5832]: Jenkins requires Java versions [17, 11] but you are running with Java 1.8 from /usr/lib/jvm/java-8-openjdk-arm64/jre
Aug 30 14:44:28 instance jenkins[5832]: java.lang.UnsupportedClassVersionError: 52.0
Aug 30 14:44:28 instance jenkins[5832]:         at executable.Main.verifyJavaVersion(Main.java:145)
Aug 30 14:44:28 instance jenkins[5832]:         at executable.Main.main(Main.java:109)
Aug 30 14:44:28 instance systemd[1]: jenkins.service: Failed with result 'protocol'.
░░ Subject: Unit failed

Looks like I shouldn't be using OpenJDK 8 anymore, going to drop the testing defaults so it uses the java role defaults (Java 11 or Java 17 on the latest releases).

Fixed!


Bug in assertFileContent function

Brief Description
assertFileContent(), a function critical in the assertUmpleTemplateFor() testing function, fails to detect a mismatch between actual and expected files when the files differ in number of lines.
Minimum Steps to Reproduce
Go step-by-step through the Generated() test in JavaClassTemplateTest.java.  You'll notice that the actual output is this. However, the expected output, from ClassTemplateTest_Generated.java.txt is the following:
/*PLEASE DO NOT EDIT THIS CODE*/
/*This code was generated using the UMPLE @UMPLE_VERSION@ modeling language!*/

package example;

public class Mentor
{

  //------------------------
  // MEMBER VARIABLES
  //------------------------

  //------------------------
  // CONSTRUCTOR
  //------------------------

  public Mentor()
  {}

  //------------------------
  // INTERFACE
  //------------------------

  public void delete()
  {}

   public static   main(){

  }

}

Expected Result
An error should be reported, since the expect file and actual file don't match.
Actual Result
An error is not being reported. The problem is this snippet (taken from line 198-204 of SampleFileWriter_Code.ump):
// HACK: To deal with umple version issues
      if (expectedLine != null && actualLine != null && expectedLine.indexOf("This code was generated using the UMPLE") == -1)
      {
        Assert.assertEquals("Failed at:" + line,expectedLine,actualLine);
      }
    }
    while (expectedLine != null && actualLine != null);

The main issue is we don't take into account the possibility that the actual output and the expected output might differ in length (as could be the case if we introduced a bug into the system). If we take the example discussed int the Minimum Steps to Reproduce section, the expected output is actually much shorter than the actual output. This means that eventually expectedLine == null && actualLine != null. In this case we should generate an error, however, what actually happens is we just exit the while loop and then the function without reporting an error.

Here's one fix for the problem snippet:
 // HACK: To deal with umple version issues
        if (expectedLine != null && actualLine != null && expectedLine.indexOf("This code was generated using the UMPLE") == -1)
        {
          Assert.assertEquals("Failed at:" + line,expectedLine,actualLine);
        }
      }
      while (expectedLine != null && actualLine != null);

      if ((expectedLine == null && actualLine != null) || expectedLine != null && actualLine == null)
      {
    	  // Length mismatch between expected and actual
    	  Assert.fail("Length mismatch between expected and actual at line " + line);
      }

@vahdat-ab  @TimLethbridge When I introduce this fix into my local repo it causes 20 test cases to fail with the "Length mismatch..." error. I've had a look at a couple of the failures -- some of them involve tests with empty expected output files, and at least one has an incomplete expected output file (the one I mentioned above). Let me know if you have any comments, otherwise I'll get a PR ready.

Many of the expected results files are empty, and there aren't any comments describing what the tests are testing for in many cases. Because of that, it's hard to know if the output is correct or not. I've changed the difficulty tag because of this -- if it's going to be necessary to figure out what each test is looking for and verifying that in the output (as opposed to just regenerating the expected results), it's going to be a lot more work. My current plan is to regenerate the test sets and create another issue to look into each of the 20 regenerated test cases to ensure that the test results are what we expect.

can you let me have the name of some of those failed test cases?

@vahdat-ab Here's a screenshot showing which tests failed. I haven't looked into all of them, but I think they're due to empty files.

Yes, you are right. When a class implements the interface ISecondChild, there is no method for that. There is a bug in the system. Looks like the code doesn't pay attention to the hierarchy of interfaces.

It also looks like at least one of the interfaces in the .ump file associated with that test contain attributes, which I believe is invalid syntax
Do you mean having attributes in interfaces is an invalid syntax? In Java 8, we can have attributes for interfaces, and it is considered final and static.
However, Umple doesn't still generate attributes for interfaces.

This issue seems to have been left unresolved. Maybe it can be closed? I will mark it as needsTesting


{Freeway-Bug}[Adaptive Cards: Schema Explorer]: Ensures the contrast between foreground and background colors meets WCAG 2 AA contrast ratio thresholds

Target Platforms
Other
SDK Version
1.5
Application Name
Adaptive Cards
Problem Description
Test Environment:
URL: https://adaptivecards.io/explorer
OS Version: 22H2(OS Build 25247.1000)
Browser Version: Version 110.0.1543.0 (Official build) dev (64-bit)
Tool: Accessibility Insight For Web
Repro Steps:

Open the above URL in the browser.
Run the accessibility insight for web tool and observe the issue.

Actual Result:
Color contrast between foreground and background of 'Comment and View' button text is 4.2:1 which is less than 4.5:1.
Expected Result:
Color contrast ration between foreground and background of 'Comment and View' button text should be equal to greater than 4 .5:1.
Note:
Same issue is repro under 'Activity Update' screen as well.
User Impact:
It will impact the low vision user if the contrast ratio of text is less than 4.5:1 as they will face difficulties to see the elements properly.
Element path:
button[aria-label="View"] > div
How to fix:
Fix any of the following:
Element has insufficient color contrast of 4.41 (foreground color: #0079db, background color: #ffffff, font size: 10.5pt (14px), font weight: normal). Expected contrast ratio of 4.5:1.
MAS Reference link:
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc={9CAF3A19-5244-4FB1-8329-91DCE08BC85E}&file=MAS 1.4.3 – Contrast (Minimum).docx&action=default&mobileredirect=true
“Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com) “
Screenshots

Card JSON
NA

Sample Code Language
No response
Sample Code
No response

Closing this issue as of now this issue is being tracked using below URL.
https://github.com/microsoft/AdaptiveCards/issues/8574


WIP: Gang-scheduling doc.

Signed-off-by: Da K. Ma<EMAIL_ADDRESS>

See my comment in https://github.com/kubernetes/features/issues/583. This feature should be renamed.

I'm going to close this placeholder, as we're going to support it in 1.13.


Packages that wrap libraries should not dynamically wrap on init

I would like to see packages that wrap existing libraries (e.g. vtk, !JobSubmission) to not dynamically create wrappers on startup.  Rather, I believe they should adopt a strategy more like the new matplotlib package where the wrappers are created dynamically by a script, but the wrapper itself is static.  This way, a version number can actually mean something and interfaces can be assumed cross-platform.  It also makes debugging individual packages a bit easier.  Finally, UV-CDAT users have commented on the long startup time for the VTK package which is partially caused by this wrapping running each time on startup.  Note that the wrapper script could be run in a single step to update !VisTrails bindings so this shouldn't be a big deal for developers or users wishing to extend both the underlying library and !VisTrails wrapping.

Superseded by #991.


Config to specify table, column options

Similar to how it works in the Redshift connector, I'd expect there to be configurable table or column options:

sort key / clustered columnstore key
primary key
unique
index
shard key
encoding and collation

Much of the functionality of these Redshift analogs is written in the include/redshift/macros/adapters.sql file, which doesn't seem to exist for Singlestore.

Hi, thanks for opening the issue. I think a model level config called storage_type (rowstore or columnstore) would be useful in this. Below is a quick shim I did for this in my project.
{% macro singlestore__create_table_as(temporary, relation, sql) -%}     {%- set sql_header = config.get('sql_header', none) -%} 	{%- set storage_type = config.get('storage_type', 'columnstore') -%}     {{ sql_header if sql_header is not none }}     create {% if storage_type == 'rowstore': -%} rowstore {%- endif %} {% if temporary: -%} temporary{%- endif %} table         {{ relation.include(database=True) }}     as         {{ sql }} {% endmacro %}


Cart functionality

Add a cart functionality to order instead of a direct order button in the orders.php page.

Hi @arnav-deep I'm on it.. :)
Happy Hacktoberfest

Hi @sptutusukanta
Assigning it to you. Thank you. If you have any doubts in the source code, feel free to ask here. Will be active here.

Hi @arnav-deep, I check the app on my local, but before proceeding further, I want to know if this is a college project or just for fun & learn kind of project. Or are you into making into something real?
Because at the current level I see a lot of issues, if it's for learning, then it's okay. If not, then this won't work in real.
Based on this we may go forward, so, please let me know.

Hey @sptutusukanta
So yeah, this was made just for learning, nothing real. You can add functionalities as you want. I do have seen some issues but they didn't affect the normal flow as of yet. Adding the cart function will change a lot of things in orders.php, including the way the food is ordered now.
If you do notice any issues or functionality worth changing or adding, do get in touch with me or comment here. I will either work on it on my own or add them as issues. For now, you can just add the basic add to cart and checkout functionality considering it as a small project, not for deployment.

Okay, cool, just for fun try this as the login email, with any password (doesn't matter)
email: ' or '1'='1
pass: anything
Just make sure to use developer tools and change input type to text from email and see what happens.

Tried.
Can you explain why it was accepted?

The first step would be to add some kind of cart functionality session.
The next step, as the orders and items are taken directly in the orders table, it is required to be split:

orders: having the order related info (who ordered, when, to which restaurant etc. but not the ordered items)
order_items: this will be a table referencing with a foreign key to point orders.

Tried.
Can you explain why it was accepted?

Its a pure & simple SQL injection attack. You may learn more here: https://www.guru99.com/learn-sql-injection-with-practical-example.html

Thanks for sharing that.
Although this attack would fail if the input is only taken as email, right?

Nopes, if you validate in HTML side, anyone can just open devtools and change that.. But if you validate in PHP/server-side, yes then it can be protected, but again, the password is not protected, so another kind of attack might be possible.

The first step would be to add some kind of cart functionality session.
The next step, as the orders and items are taken directly in the orders table, it is required to be split:

orders: having the order related info (who ordered, when, to which restaurant etc. but not the ordered items)
order_items: this will be a table referencing with a foreign key to point orders.

Yeah, the database will require altering. You can make the alterations as you want.

There would a lot of attacks possible, as done in your app, not only in login but in other places too.. So, try to learn & implement mysqli / PDO prepared statements.

The first step would be to add some kind of cart functionality session.
The next step, as the orders and items are taken directly in the orders table, it is required to be split:

orders: having the order related info (who ordered, when, to which restaurant etc. but not the ordered items)
order_items: this will be a table referencing with a foreign key to point orders.

Yeah, the database will require altering. You can make the alterations as you want.

Yeah will do.

Nopes, if you validate in HTML side, anyone can just open devtools and change that.. But if you validate in PHP/server-side, yes then it can be protected, but again, the password is not protected, so another kind of attack might be possible.

Ok. Will look it and add it. I did not put protection as I was just building it for learning.

Nopes, if you validate in HTML side, anyone can just open devtools and change that.. But if you validate in PHP/server-side, yes then it can be protected, but again, the password is not protected, so another kind of attack might be possible.

Ok. Will look it and add it. I did not put protection as I was just building it for learning.

Yes, I understand but also learn to protect.

Nopes, if you validate in HTML side, anyone can just open devtools and change that.. But if you validate in PHP/server-side, yes then it can be protected, but again, the password is not protected, so another kind of attack might be possible.

Ok. Will look it and add it. I did not put protection as I was just building it for learning.

Yes, I understand but also learn to protect.

Yeah. I will update the security. Leave that part to me.

By the way what you actually do?
Do you have friends working/learning on the same trade?
I mean, why not make something in real? See, I'm a freelance developer & designer and work for me & for my family. I am in this trade for around 7 years. If you are interested (apart from this project) you may send your contact info to<EMAIL_ADDRESS>
Anyway, my next update would be to build the cart using Session, possibly tonight or tomorrow. See you then.

Hi.. please check the PR, if you plan to merge it later, please add "hacktoberfest-accepted" label to the requested PR.

Hey @sptutusukanta !
Will check and merge within 12 hours. Will also add the label. Thank you for your work.


Add FillMap(s interface{}, out map[string]interface{})

I want use structs like this:
dest := make(map[string]interface{})
structs.FillMap(topic, dest)
structs.FillMap(topicEx, dest)

@polaris1119 can you rebase to a single commit please, so we can merge it? Thanks!


Add JSCS for contributors to this project

https://github.com/jscs-dev/node-jscs
To make @swalkinshaw happy.
Note: do NOT add JSCS to the Sage theme for end-users.  Add JSCS as an npm script to run against contributions to this repo. That way javascript contributions to this project are consistent. After someone clones down the project they can go hogwild. This will solve the problem of me forgetting to put spaces after my if statements :P

:+1:

Also a :+1: from me even though I haven't gotten PHPCS working 100% yet...

closed by #1278


Deployment artifacts for WOETH CCIP Zapper

If you made a contract change, make sure to complete the checklist below before merging it in master.
Refer to our documentation for more details about contract security best practices.
Contract change checklist:

[ ] Code reviewed by 2 reviewers.
[ ] Copy & paste code review security checklist below this checklist.
[ ] Unit tests pass
[ ] Slither tests pass with no warning
[ ] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Closing this, since we are doing a redeploy


fix: remove hardcoded eks role

Changes

#587
#586  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on  Graphite


Firefox add-on non-functional in class settings page.

Is this still happening? @RyanHir

It appears to be working now!


toBeCloseTo for expects from Jasmine missing

Added with https://github.com/daluu/Extendables/commit/6a0112af9aae430e3dca9566e670d3b6a3ab212f
though should consider case of toNotBeCloseTo, although that's likely a less used use case to defer.


Allow chats, document uploads, etc. to all be asynchronously run locally.

#23 Multichat is safely asynchronous. Using GUIDs to represent chats and messages inside an instance of chat.

still need docs to do this


#3559 fix initial route after relogin

Details

Makes sure there is a reportID before rendering the navigator with initial route that depends on reportID.
Fixed Issues

Fixes #3559
Tests / QA Steps

Sign into an account
Sign out of the account
Sign into a different account

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

https://user-images.githubusercontent.com/64093836/122400174-26e35f00-cf84-11eb-87b1-14f8f9c37cc1.mp4
Mobile Web

https://user-images.githubusercontent.com/64093836/122400496-72960880-cf84-11eb-9312-86b38be7bdea.mp4
Desktop

https://user-images.githubusercontent.com/64093836/122400318-48444b00-cf84-11eb-943e-e0fad763e142.mov
iOS

https://user-images.githubusercontent.com/64093836/122400461-68740a00-cf84-11eb-8422-75633de86b2b.mp4
Android

https://user-images.githubusercontent.com/64093836/122400476-6d38be00-cf84-11eb-8b33-e26bf37e194b.mp4

Will wait for @luacmartins to final approve/merge

🚀 Deployed to staging in version: 1.0.70-6🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production in version: 1.0.73-3🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Project Params Hotfix

Hotfix for project/params endpoint not receiving experiment_names. This will be changed in the future to experiment_ids instead: https://github.com/G-Research/fasttrackml/issues/1098
Backend PRs: https://github.com/G-Research/fasttrackml/pull/1096, https://github.com/G-Research/fasttrackml/pull/1097

When the experiment selection changes we need to make the params/metrics selector reload, right now I need to reload the page to see the metrics/marams filtered by the experiment


Update Set-OwaMailboxPolicy.md

Added ExternalImageProxyEnabled parameter per email request.

Docs Build status updates of commit 698fb51:
:clock10: Full build: the average full build time is 14 min(s) 10 sec(s), this is based on the last 146 build(s) for this repository.
:warning: This is a FULL build due to the incremental build being disabled in configuration file (.openpublishing.publish.config.json in 'live' branch). For more detailed info, please click here.

Docs Build status updates of commit 698fb51:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/client-access/Set-OwaMailboxPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


OAuth - sign in with Gihub, Google etc + Autosave Sketches

Hi there!
I really love tldraw and use it often.
The only thing I'm missing in it is the option to sign in and know that all my sketches are always safe.
Seems like the data here is not really heavy so I guess allocating getting a bit of user storage won't be a problem especially now with corporate sponsors and first class integrations.
And even if you don't want to deal with the storage directly I bet you can pull something like this off with Google driving integrations where everything is auto saved to the drive and when loading it will find all of the tldr files
This whole project is about minimalism but I guess I still need a personal page where I can see my list or board previews of my sketches, edit their visibility settings and copy private/public links to each one.
In my opinion this is the most crucial feature needed in tldraw, the ux is already pretty amazing, but this is must have.
Let me know what you think. Hope it's straight forward enough to make soon.
Awaiting diligently 💛
Thanks a lot and all the best !
Tami

Hi, closing this as we won't be adding new features to this version of tldraw. Check https://github.com/tldraw/tldraw for the latest!


Synonyms above family level still present in XRelease

After @mdoering updated the merge sync to also filter synonyms by rank, the last XRelease still included 37 synonym names above the family level.
The results show that the merge condition didn't work in all cases. A previous XRelease included 957 synonym names above family rank.

This is not happening anymore


Update sbt to 1.4.7

Updates org.scala-sbt:sbt from 1.4.1 to 1.4.7.
Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-patch

Codecov Report

Merging #15 (0e72adc) into master (5910444) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   73.13%   73.13%
=======================================
  Files          22       22
  Lines         268      268
  Branches        2        2
=======================================
  Hits          196      196
  Misses         72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5910444...0e72adc. Read the comment docs.

Codecov Report

Merging #15 (0e72adc) into master (5910444) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   73.13%   73.13%
=======================================
  Files          22       22
  Lines         268      268
  Branches        2        2
=======================================
  Hits          196      196
  Misses         72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5910444...0e72adc. Read the comment docs.


PWA-218: Add portals to prices on category page

filter price range portal
portal for price in grid item

Pull Request Test Coverage Report for Build 566

0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 40.286%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pages/Filter/index.jsx
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

pages/Filter/index.jsx
1
0.0%

Totals

Change from base Build 563:
-0.01%

Covered Lines:
1812

Relevant Lines:
4402

💛  - Coveralls


Navigation Bar: Add manage button

add dropdown menu to 'Manage', including track, reschedule and service management.

Replace track with manage
inside manage:
track
reschedule
cancel

Also service management should be replaced with "Cancel"


[bug]: Not able to load seek art mega v2 could not be loaded: LatentDiffusion.init() missing 1 required positional argument: 'personalization_config'

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
24GB
What version did you experience this issue on?
2.3.3
What happened?
when trying to run civitai  seek art mega 2 model i am getting this error.
Loading seekArtMEGA_mega20 from E:/invokeai/models/seek/seekArtMEGA_mega20.ckpt
| Forcing garbage collection prior to loading new model
** model seekArtMEGA_mega20 could not be loaded: LatentDiffusion.init() missing 1 required positional argument: 'personalization_config'
Traceback (most recent call last):
File "E:\invokeai.venv\lib\site-packages\ldm\generate.py", line 958, in set_model
model_data = cache.get_model(model_name)
File "E:\invokeai.venv\lib\site-packages\ldm\invoke\model_manager.py", line 121, in get_model
requested_model, width, height, hash = self._load_model(model_name)
File "E:\invokeai.venv\lib\site-packages\ldm\invoke\model_manager.py", line 351, in _load_model
model, width, height, model_hash = self._load_ckpt_model(
File "E:\invokeai.venv\lib\site-packages\ldm\invoke\model_manager.py", line 452, in _load_ckpt_model
model = instantiate_from_config(omega_config.model)
File "E:\invokeai.venv\lib\site-packages\ldm\util.py", line 93, in instantiate_from_config
return get_obj_from_str(config["target"])(**config.get("params", dict()), **kwargs)
TypeError: LatentDiffusion.init() missing 1 required positional argument: 'personalization_config'
Screenshots
No response
Additional context
No response
Contact Details
No response

This error usually results when you provide the wrong config file for a legacy checkpoint model. I've made various improvements to model loading in version 2.3.3, including more intelligent scanning and config file selection. If you can, please check out the release candidate at: https://github.com/invoke-ai/InvokeAI/releases/tag/v2.3.3-rc3
If suggest that you use the standalone model installer to import the checkpoint file. You can get this by selecting option [5] from the launcher menu and then dragging the .ckpt file into the box labeled "IMPORT LOCAL AND REMOTE MODELS".


Skip setting internal dns if user sets DNS and

label io.rancher.container.dns=false.
@ibuildthecloud

@alena1108 Thanks, testing now w/ my host-api changes


correct spells

@tarotene thanks for the fix.  Can you please fix the commit message as per the projects Contribution Guidelines.  (Need a signed-off-by and commit message needs a header).

Thank you for reviewing.
I've noticed that I haven't read the guideline enough and haven't given a topic-branch-like name to my local branch, so I will close this PR and make another PR.


1.3.0 release

[x] Create 1.3 branch for the release if it does not exist
[x] Change the branch of the build status in README.md if the branch is newly created (1.3)
[x] Change README.md on the release branch. (1.3)
[x] Tag to the release on git with the command git tag -s v1.3.0 HEAD (1.3)
[x] Push changes to GitHub with the command git push upstream 1.3 and git push upstream --tags (1.3)
[x] Create a new draft release as Workflower 1.3.0 (stable) (GitHub)
[x] Publish the release
[x] Update wiki pages (Home)
[x] Update the version in README.md and composer.json from 1.2 to 1.3 if 1.3 branch is newly created (master)
[x] Push changes to GitHub with the command git push upstream master (master)
[x] Remove unnecessary releases in Packagist
[x] Remove unnecessary branches in GitHub
[x] Tweet the release

@SirWaddles v1.3.0 released! Thank you!! :smile:


fix(Login): Enter will not go to sign in page if account exists

What this PR does 📖
1.  Enter will not go to sign in page if account exists
https://github.com/Satellite-im/Uplink/assets/63157656/3b2e2e06-29ea-4cf0-8409-7cc2b93ef5f8
2. Button will change to loading, to give a better feedback to user
https://github.com/Satellite-im/Uplink/assets/63157656/09d8a33c-58de-4a00-a85f-df82f93d50fd
Which issue(s) this PR fixes 🔨

Resolve #

Special notes for reviewers 🗒
Additional comments 🎤

Noticed minor issue when testing -
If the user types in the incorrect PIN the button will still say "Logging in..." but will still show as clickable. The user is also unable to backspace any of what they typed.
If they click the button still it will then show the error for incorrect PIN and reset the text area, but user will be unable to click into it or type anything
Screen.Recording.2023-12-01.at.1.50.34.PM.mov

This is the reason why automated tests are failing on "Enter a pin with more than 32 characters" test


Fix Fragment getContext NPE

#780
@samtstern Sigh, classic Fragment getContext() NPE. We've done this before so it should work just fine.

Nice!  LGTM.


Error Code 279

It keeps saying error code 279 but works fine when I use the roblox app to join games. Other devices runs roblox just fine aswell but they don't have bloxstrap installed

For some reason, I can't use the old textures before 2022

For some reason, I can't use the old textures before 2022

You were told to read this before using Bloxstrap: https://github.com/pizzaboxer/bloxstrap/wiki/Addressing-usability-problems-with-Bloxstrap-v2.5.4

It keeps saying error code 279 but works fine when I use the roblox app to join games. Other devices runs roblox just fine aswell but they don't have bloxstrap installed

Show a screenshot of the error message please

I'm sorry
On Sun, Apr 14, 2024 at 9:04 AM pizzaboxer @.***> wrote:

For some reason, I can't use the old textures before 2022
You were told to read this before using Bloxstrap:
https://github.com/pizzaboxer/bloxstrap/wiki/Addressing-usability-problems-with-Bloxstrap-v2.5.4
It keeps saying error code 279 but works fine when I use the roblox app to
join games. Other devices runs roblox just fine aswell but they don't have
bloxstrap installed
Show a screenshot of the error message please
—
Reply to this email directly, view it on GitHub
https://github.com/pizzaboxer/bloxstrap/issues/1617#issuecomment-2054055525,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BH2ECVL3P37PTQMOO4FNNA3Y5J5F3AVCNFSM6AAAAABGGAFL2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJUGA2TKNJSGU
.
You are receiving this because you commented.Message ID:
@.***>

Upload your configuration please: https://github.com/pizzaboxer/bloxstrap/wiki/Uploading-your-Bloxstrap-configuration

Issue has been awaiting clarification for over a month, closing as stale. If you have anything further to add, just respond and I'll reopen.

It keeps saying error code 279 but works fine when I use the roblox app to join games. Other devices runs roblox just fine aswell but they don't have bloxstrap installed

A common issue, not just with Blockstrap is a network issue. Make sure you are on a secure network and not using a VPN.


Move detail screens to full screen

@nmirasch @bsremac I think we should move to full details page sooner, that way we can present and review its content with the UX team.

@cristianonicolai Yes, it makes sense.
If we know that the new table will be ready for GA, there's no reason to postpone this.

@cristianonicolai @nmirasch One thing which now stands out is forcing the full screen process instance details after starting a new process instance in Process Definitions view.
While the details of the newly started process instance were in the side panel, they could be ignored and the interaction with the process definitions list could be seamlessly continued. Whatever requirement was behind this old approach, seems to be now overridden with the master details idea.

@cristianonicolai @nmirasch There is one issue when interacting with process instance master detail in Process Instances view.
Basically you navigate to Process Instances (advanced filter is set to show only Active ones at that moment) and you click on one of the process instances in the list.
The full screen master detail opens up and so far so good.
But then when you close the view, no matter in which way (go back via breadcrumbs or using the close button), the process instances list is empty.
In order to get the active process instances back, which were listed before navigating to details view, you have to use the Refresh button.


[RivieraBridge] Add new bridge

RSS bridge for concerts in Sala La Riviera, in Madrid

Closing as bridge better fits for ICS format, which you have already implemented. Anyway good job @Danoloan10 !


Support for link tracking in EVPN environments.

Issue Type

[X] New Feature

Summary
In most environments that run EVPN-MH or sometimes EVPN-MLAG we need the capability that if upstream spine links will go down that the MLAG port-channel to downstream interfaces (servers) also goes down and does not forward traffic where it would then be black holed.
A common CLI would look like the following.
link tracking group FOO
recovery delay 300
!
! upstream interface
interface Ethernet3
link tracking group FOO upstream
!
! downstream interface
interface Port-Channel1
switchport access vlan 30
!
evpn ethernet-segment
identifier 0000:0000:0000:0000:3030
route-target import 30:30:30:30:30:30
lacp system-id 3030.3030.3030
link tracking group FOO downstream
!
Where the Ethernet 3 interface would be the spine uplink and the port-channel1 would be the downstream connection to the server.
I would imagine this would have a dictionary containing the following..
Component Name
eos_cli_config_gen/templates/eos/port-channel-interfaces.j2
eos_cli_config_gen/templates/eos/ethernet-interfaces.j2

eos_cli_config_gen/templates/eos/link-tracking.j2
eos_cli_config_gen/templates/documentation/port-channel-interfaces.j2
eos_cli_config_gen/templates/documentation/ethernet-interfaces.j2
eos_cli_config_gen/templates/documentation/link-tracking.j2

I would imagine the model would look like the following.
link-tracking
link-tracking:
    - group_name: string
      delay: int32

ethernet-interfaces
ethernet_interfaces:
  <Ethernet_interface_1 >:
    link_tracking: <true | false>
      - name: string
        direction: upstream | downstream

portchannel-interfaces
port_channel_interfaces:
  < Port-Channel_interface_1 >:
    link_tracking: <true | false>
      - name: string
        direction: upstream | downstream

This is very common within EVPN-MH environments if agreed upon please suggest this model or we can put in a PR to add to the ethernet/port-channel interfaces and potentially add a new j2 template for link-tracking.

Alternative proposal. We try to use dicts instead of lists where we can.
link-tracking
link_tracking_groups:
  < group_name >:
    links_minimum: < number >
    recovery_delay: < 0-3600 >

ethernet-interfaces
ethernet_interfaces:
  <Ethernet_interface_1 >:
    link_tracking_groups:
      < group_name >: < upstream | downstream >

portchannel-interfaces
port_channel_interfaces:
  < Port-Channel_interface_1 >:
    link_tracking_groups:
      < group_name >: < upstream | downstream >

LGTM!

@burnyd Will you work on this, or do you want me to take a stab at it?


DollarSkip

Might wanna take a look at my dollarskip repo, not a software however feel free to add it if you want, just let me check the files and give me credit for the software
Up to you

Why not? Just make a zip with an “install” file, an “uninstall” file, an icon png file and a description text file.

Actually after looking whats currently hear again, dollarskip doesn't fit

Also I thought about it a little more and would rather a user view my repo rather than here.

Also I thought about it a little more and would rather a user view my repo rather than here.

Alright then, if you would like any features/apps to be added just open an issue.

Im not a Linux Pi user, so I don't really want the features, but perfectly happy to suggest them if I think of any.
I personally stick to X86 Ubuntu based or Arch

Im not a Linux Pi user, so I don't really want the features, but perfectly happy to suggest them if I think of any.
I personally stick to X86 Ubuntu based or Arch

Then you can suggest an app if you want. Maybe aptcleaner? I heard you helped make it.

How about bleachbit auto?

How about bleachbit auto?

Make a new issue.


restore image build on tag (i.e. release)

removing 'tests needed' check that skips container builds for tag runs

fixes https://github.com/hyperledger/indy-node-container/issues/129

Do we need to remove/update the Ubuntu 18 build, it fails at the moment: https://github.com/hyperledger/indy-node-container/actions/runs/6156786779/job/16706179940?pr=128

Oh damn... it seems that there are repositories missing. This means that likely NONE of our containers will build oO

I am now investigating the issue. Debian images are building. The problem seems to be with (one of the) ubuntu keyservers

After some reading: This is a temporary key-server-busy error that we are getting for an EOSS ubuntu version... https://askubuntu.com/questions/1481617/randomly-get-gpg-keyserver-receive-failed-cannot-assign-requested-address#comment2594458_1481617

Ok, now we have trouble building the controller


losing 50k Sia coins balance

I use mobile app for Sia and generate the new wallet, got a seed and saved them. Then I send 120k Sia coins in 3 different section, both from poloniex.com and one more from bittrex. All of the adress is belong to one seed ,I use a mobile app before. Then when I tried to open via desktop it's only show my two transactions which in total of 69k. And the rest, gone. No transaction, tried to track down, no my adress is not even belong to the same seed. How could it even possible when we only have one seed and we click receive, then the adress is belong to the same seed? I told Sia tech and they said this is not their fault cz the Sia mobile is not supported by Sia tech or belong to Sia tech. What's that? I asked developer and he said it should belong to same seed but in fact no my adress is not belong to my seed. So how about my Sia coin? Lose 50k I feel so bad :(

It's possible that your wallets are desynchronized. Try using the tool I created here: https://github.com/NebulousLabs/Sia-UI/issues/581#issuecomment-299747969

100% sync and still can't see any transaction from the first one. Only 69k appear.

Have you tried using the tool that was linked in lukechampine's comment?

I tried to scan all and no transaction for my first transaction only the
last two. And I found out that the sia mobile wallet is really not safe to
use as there is no tutorial and I think I was generating new address . I
have the back up in my mobile and when I tried to recover the seed it's not
appear as the pixels is broken.
On Friday, November 3, 2017, Thomas Bennett<EMAIL_ADDRESS>wrote:

Have you tried using the tool that was linked in lukechampine's comment?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.<
https://ci6.googleusercontent.com/proxy/MTWjySQz-_UZANKhN_ZvJP266cccrSlD1bGvpEsxtqpCwj7NivXYH081k2BLolHgxVKA0bFCUn_19gh4gEJnyvTXTpQ8adjLWatISZdX-SkQq849ria-HwH8bsEuCmCs3vnxWcGf0zaMUmQLUrxoN8RdhbapdA=s0-d-e1-ft#https://github.com/notifications/beacon/AdcNchBoEDJ3zOCD2tu71AfxOvvnbVfmks5syz58gaJpZM4OyPi5.gif>


free keyword config

Currently the config files lack the one for free keywords (i.e., keywords that are not associated with a particular Entrez search field), but search_term_tissue.config can be used as is, so why don't we rename it as search_term_keyword.config?

makes sense, esp. since a user might look for whole organs, conditions mutants etc. rather than tissue.
Renaming everything, the entrez search command now looks like this:
Entrez search term: "Aquilegia coerulea"[Organism] AND (root OR flower OR leaf OR drought stress) AND [...]
I also renamed all relevant instances for "tissue" to "keyword".

Thank you. Sounds good!

It would be nice if you could tag the commit when it's done. https://github.com/kfuku52/amalgkit/commit/73ce56fd3aa28536774b86e6453122c1564e56de

search_term_keyword.config is missing.
https://github.com/kfuku52/amalgkit/tree/master/config/test
https://github.com/kfuku52/amalgkit/tree/master/config/viridiplantae_test

Ah, they slipped past the commit as unversioned files. Updated in:
https://github.com/kfuku52/amalgkit/commit/a5783a4f4e9824be6f2e16bb8268d0d979d0bcc1


Update offline tutorial to use a player config for offline storage

When configuring offline storage in initStorage in initialising storage, an OfflineConfig was used instead of a player config, which worked in v2.5 but not in ~v3.5~ v3.0. Because of this when the final code was run the progress bar wouldn't work properly as progressCallback was not set.
Description

Screenshots (optional)

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)
[x] This change requires a documentation update

Checklist:

[x] I have signed the Google CLA https://cla.developers.google.com
[ ] My code follows the style guidelines of this project
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have verified my change on multiple browsers on different platforms
[ ] I have run ./build/all.py and the build passes
[ ] I have run ./build/test.py and all tests pass

Thank you for your contribution!


Feature/70 create api docs

Modified jsdoc.json config file

resolves issue #70

@cmcWebCode40 I've run this locally, but it appears lots of the classes are still not available.
For example:

https://github.com/verida/verida-js/blob/main/packages/client-ts/src/context/engines/verida/messaging/engine.ts
https://github.com/verida/verida-js/blob/main/packages/client-ts/src/context/engines/verida/messaging/inbox.ts
https://github.com/verida/verida-js/blob/main/packages/client-ts/src/context/engines/verida/messaging/outbox.ts
https://github.com/verida/verida-js/blob/main/packages/client-ts/src/context/engines/verida/database/db-encrypted.ts

Modified jsdoc.json config file

resolves issue #70

@tahpot, I'm currently having issues displaying all the classes, it does not display more than 7 classes, I have also exported all default class names correctly. have you experienced issues like this working with  better-docs  ?.

@cmcWebCode40 I have never used better-docs sorry. I chose it very quickly as it looked like the nicest looking solution that supported typescript.
@nick-verida Is it worth us looking at a different library?

@cmcWebCode40 do you know where this is at? Is it waiting for @tahpot to take another look at it?

@nick-verida @cmcWebCode40
I have merged this in as the core requirement of getting the API docs is working.
It still needs more complete API docs added to the code. I have created a task here https://github.com/verida/verida-js/issues/114


Map with dynamic address error

Hi, thanks for creating this. I prefer this over the other angular-google-maps library. However I'm getting an error when creating a map with dynamic address and need help.
I'm following your example that you provided:
https://github.com/allenhwkim/angularjs-google-maps/blob/master/build/map_with_dynamic_address.html
In my HTML, I've created the same elements
input type="text" ng-model="address"
map center="{{address}}"
However, for each character I type in the input field, I'm getting an error in the console:
Error: setCenter: not a LatLng or LatLngLiteral: not an Object
I've also tried removing the input field, and defining $scope.address = "San Francisco, CA" in the controller, but receive the same error.
When I hardcode an address in the map directive, e.g. map center="San Francisco, CA", it works fine.
Can you help me? Thanks

Thanks for this awesome tool. But this problem is real tricky one
Here is the plunker http://plnkr.co/edit/qofAE1CkzFCSFdOw1aLR?p=preview


Create 023.json

Added 20 more quotes for issue #3

I believe there's a conflict because at the time when I made this file, a file name i.e. "023.json" had not been merged yet.

Change file name to avoid conflict


Bumped default node version for Meteor 1.1

0.10.33 -> 0.10.36
There has to be a better way to auto-grab the latest node for Meteor, investigating...

Thanks! Yes, there must be a better way of working this out ad hoc.


testTrigger retrieves 405 for devices done by m2x node.js client

Hi @grilix / @fsaravia ,
I am testing the triggers part  for the device,
The problem is as follows:
This method doesn't suppose to get params,
However, by the link it does required payload
however, with and without payload the result is the same 405
@fsaravia, what is the use case ?
// Test the specified trigger by firing it with a fake value.
//
// This method can be used by developers of client applications
// to test the way their apps receive and handle M2X notifications.
//
// https://m2x.att.com/developer/documentation/v2/device#Test-Trigger
Devices.prototype.testTrigger = function(id, triggerName, callback) {
return this.client.post(
helpers.url("/devices/%s/triggers/%s", id, triggerName),
callback
);
};
msg.topic_id is the distribution id
msg.sub_topic_id is the trigger id
msg.payload is params
there for it tranlates into
msg.topic = "devices";
msg.action = "testTrigger";
msg.topic_id = "1d72bf0c5beaea24dfa10fd99f6e5da0";
msg.sub_topic_id = "AUtPzS7wk02lwGPcARSU";
msg .payload = {
"device_id": "1d72bf0c5beaea24dfa10fd99f6e5da0",
"stream": "Date",
"trigger_name": "High Date",
"trigger_description": "temperature > 30",
"condition": ">",
"threshold": 30.0,
"value": 31.5,
"timestamp": "2014-06-27T22:22:58.104Z",
"location": {
"name": "Machines room",
"latitude": 40.77177,
"longitude": -73.97352,
"elevation": 0,
"timestamp": "2014-06-27T22:22:57.040Z"
}
}
I got 405, method not allowed.

Seems like the library is not calling the correct test endpoint which should be POST /devices/{device_id}/triggers/{id}/test. @grilix do you care to check when you get a moment please?

@fsaravia you are right, the endpoint path was wrong. Fixed on version 2.1.4.

@grilix thank you!

@fsaravia, Can you please check if it necessary to pass the payload ? according to the documentation https://m2x.att.com/developer/documentation/v2/device#Test-Trigger it does.
the m2x nodejs client need to support passing location and other parameters, does this ability was removed on the m2x nodejs client ?
It is somehow confusing to the end users, since I redirect the users to the m2x help pages on the node red client.
Notice that on distribution.testTrigger the ability to pass payload exists.
Your help is appreciated.

@chenfli it was my bad, sorry! I'll add the params.

@chenfli, version 2.1.5 released with this fix.

Thanks @grilix,
@fergonzalez,  if you need another way to test the API you can use the m2x-node-red I made.
https://github.com/chenfli/M2X-Node-Red
https://www.npmjs.com/package/node-red-m2x
just install the node-red (http://nodered.org/) and npm install node-red-m2x from the main directory.
create the 4 nodes basic flow, and set the function nodes with the json I attached in this thread.
If you need any help with set this up, mail me I'll be more than happy to assist.
Cheers,
@chenfli

@grilix, @chenfli: Actually, there has been a confusion here, the test endpoint doesn't receive parameters on the API.
What the documentation states is that the test endpoint will send a callback to the url specified in the trigger definition and the server attending in that url is the one that will receive the payload that includes the trigger data and the device location. There's no need to send parameters to the POST /devices/{device_id}/triggers/{id}/test.
I hope this adds more clarification to the issue

@fsaravia I am a bit confused.
Let's see if I got it right,  please confirm:
The payload that the callback url will recieve eventually cannot be defined by what you send as a json in the testTrigger API, but is a data that self generated by m2x mechanism.
Did I got it right ?
If that is so, than I will disregard the payload for on testTrigger both on device and distribution.

@chenfli yes, that is correct. At the moment the payload for the callback is generated by M2X and cannot be customised.

Ok, @grilix I think I'll  just rollback to your previous version.

I've reverted the change and published as 2.1.6.
Now we have to remove the params from Distributions.testTrigger. Since it will break backwards compatibility, we'll have to release that as 2.2.0.
Does that sound good?

We've decided to keep 2.1 going, and release the fix as 2.1.7. The params on Distributions were never required by the API and has been removed from the client.
I'm sorry for the confusion on this issue, and I hope it's clear now. Your patience is very appreciated.


Create and list projects

Overview
Create and list projects.
Demo

Notes
I added listing projects to this PR to make it demoable without realizing there was a separate issue for it (#70 )
This PR includes a couple of very small unrelated changes (0317b2e and be25bed)
Testing Instructions
As per the demo above:

Ensure you have at least one region config (there's no UI for this yet but there are examples of how to do this in https://github.com/PublicMapping/district-builder-2/pull/87)
Go to the main page and click 'Create project'
Fill out the form and should be able to create a project successfully
Should be redirected to home page and see your new project listed

Closes #69
Closes #70

@maurizi Sorry to do this but hold off on reviewing this for now. I realized I need to make some more changes to ensure that the FKs are saved correctly and are used for filtering the projects.

@maurizi Okay, this should be good for review now :sweat_smile:
I'm not super happy with how it turned out but I did succeed in 1) making user id and region config id required to create a project, 2) making those be set correctly when creating a project, and 3) filtering by the currently logged in user when listing projects without having the frontend pass any extra user info to the backend.
It seems to me that there should be an easier way to access the authenticated user's data that could be applied globally and wouldn't require overriding any methods as in ProjectsController.createOne. For regular non-CrudController controllers, it seems that having a route requiring JWT auth which uses the JWT strategy as described in the authentication docs -- exactly what we're doing -- should make it so that the user is on the request (should be accessible via req.user). Indeed, when doing filtering in the @CrudAuth decorator in users.controller.ts, it seems that telling it what property to use for the user and then setting filter appropriately is sufficient and this is working fine for us. In terms of adding the user to the request, answers like this one and the Controller docs lead me to believe that it should be a simple matter of setting property to have the user data be merged into the request object after successful authentication. However, that doesn't seem to work for CrudControllers and due to the vagaries of NestJS and the magic-ness of how all this works I'm unsure of why it's not added to the request. Another wonky piece to this is that the types don't quite line up properly... the ProjectController gets a ProjectDto passed into its createOne but the service seems to want a Project so I had to do some finagling to get the types to type check. I'm also not even really sure where the createOne function I'm overriding is even coming from since I don't see it in the Controller or CrudController types.
In any case, I did find a way to access the user data I needed after successful authentication via @CrudAuth's persist which allows you add user data to the DTO (this is covered in the Controller docs linked to above). Unfortunately, it doesn't seem like you can configure this globally as you can with property (I tried configuring that locally and globally and it didn't seem to work in either case).
Anyway, that's my story. Hope it makes sense!


Make code more test-friendly

Singletons are evil that complicate testing.
There already are problems with tests related to RuntimeEnv:
https://github.com/protostuff/protostuff/blob/master/protostuff-runtime/src/test/java/io/protostuff/runtime/RuntimeSchemaEnumTagTest.java#L50

Moved to https://github.com/protostuff/protostuff/wiki/Protostuff-2


Always offline

Hi! Our modmail is always offline so none of our members can use it. Is there a way to fix it?

Hello,
Are you sure that the bot is running?