removed subshelling from veth between containers

Added MTU capability
Had to remove concurrency -> further investigation required
This is still work in progress, fixing #68

@steiler when I was researching the topic, I found out that the CNI repo is the best one to draw inspiration from on how to create p2p links. https://github.com/containernetworking/plugins
They have a good explanation how dangerous is it to use netns switching with goroutines -  https://github.com/containernetworking/plugins/tree/master/pkg/ns
For our cause of p2p links creation we should browse this repo and see how they create veth pairs, instead of using vishavanda/netns package directly

@steiler here is a blog post about locking goroutines to a thread and thus to a network namespace,
https://www.weave.works/blog/linux-namespaces-golang-followup
this is probably there reason you had to  disable concurrency

I've tested this now and it works fine for me.
This should implicitly also resolve #197 and lays foundation for #196 which is already available as a field in the internal struct LinkAttributes  which just needs to be filled. hence just the front-end needs implementation.

@steiler it seems this PR doesn't address #197? In that issue the prime focus is on the single-interfaces linux containers (eth0) which we do not explicitly create
They are created by docker

@hellt you're right. It wasn't clear to me that the default docker bridge was meant.
Any additional feedback on this pull request?

I think I will get to it starting next year
I still want to see if reusing the koko code will make it cleaner

Changes are made in #209

Changes are made in #209


Decide on 0-based versus 1-based indexes

So far I've been mimicking ODBC/JDBC in using 1-based indexes in ResultSet and ResultSetMetaData.
I did this to ease the translation of existing ODBC/JDBC code but it feels dirty.
Realistically we will want idiomatic Rust ways of accessing this API using iterators so maybe this low-level API can remain ugly ... I am interested to hear what others think.

I think is better to stick to the idioms of each lang. In rust 0-based is the norm. Also, in rust is ok to do imperative style, not only depending in functional idioms like iterators.

In JDBC indexes for prepare statements started from 1. And it case me a lot of pain. But probably there was some reasoning about it - in SQL you can address columns by indexes, for example select name, status from info order by 1 would order by id column.
I think that 0 based index is right choice, because you want to address array index from prepared statement and there should be no confusions.

Thanks. I agree. Fixed in https://github.com/andygrove/rdbc/pull/30


Breadcrumb not sync with browser

When i click 3 time on Derniere mise en ligne before the url is loaded :

whereas there is only one Derniere mise en ligne

@Scarsniik it seems to me that this is more for you, no?

How do you click multiple times ? When I click, the page changes instantly

you're right, really sorry.
👍
I went too fast. It's not a problem on develop


Left navigation refinements

This pull request explores some design refinements in our left navigation. It adds section names and addresses some hierarchy issues. This PR also serves as a prototype to evaluate against static mockups.

Pop around on the Vercel build to check it out :v:

love this. ty so much aaron! couple thoughts:

in light mode, contrast between nav section header and nav section items is challenging (for my eyes at least). this is especially true in the endpoints section where the small caps treatment isn't a differentiator. the contrast is improved in dark mode.
thoughts on a different treatment for an active 'section'? ("Network Edge" in your screenshot) the bolded but still de-emphasized font weight feels a little odd to my eyes
if it doesn't look weird, it would be nice to pull FAQ out into its own unlabeled section at the bottom


"No URL was specified" using iframe

Hi, I did a build and I have the dist folder.
I created a iframe as:
<iframe
      src="http://localhost:3001/viewer/"
      width="1200"
      height="800"
    ></iframe>

But I get an error as:
Error: "No URL was specified. Use ?url=$yourURL"
Go back to the Study List

How Could I fix it?

It looks like you may need to configure your viewer to expect being loaded at a non-root URL. What does your OHIF Viewer configuration look like?


Accessing Composer variables

Hello,
I have nothing found in documentation, but it seems, PVA can access Composer Properties?  I did nothing intentionally, but PVA access the Composer variable "buergerbuero". In my example it contains already a value, so the PVA flow question around the location is skipped.
Does this mean, any composer property with scope "user.", can be access via the scope "bot.property" in PVA?

Hello @tamasschmolcz ,
As far as I know, variables set within Composer memory scopes (user, dialog, turn) are not accessible within the PVA authoring canvas.
Composer should only be able to access and modify global variables stored in PVA via the virtualagent memory scope, but the other scopes will not be exposed.
Maybe @babrekel or @abharath27 can confirm.

@tonyanziano yes thats my understanding as well, so I am wondering about my current experience .

Sounds good.
If you do happen to succeed in reproducing the issue again, can you please list the minimum number of steps you followed in order to reproduce the issue?


Implemented TraceAnalyzer for raw traces

This is needed in order to avoid copy-pasting of trace items processing code (in BPF tracing plugins).
Also refactored disassemble_instruction in order to get rid of generic (because Rust doesn't support generics in trait objects, but we need to be able to disassemble instructions in BPF tracing plugins).

@Lichtso could you please look into it?

@Lichtso I've fixed all issues found and added some new functionality. Please take a look.

Codecov Report

Merging #412 (f58c53c) into main (c5a2b55) will decrease coverage by 0.51%.
The diff coverage is 37.70%.

@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   90.11%   89.59%   -0.52%
==========================================
  Files          23       23
  Lines        9326     9389      +63
==========================================
+ Hits         8404     8412       +8
- Misses        922      977      +55

Impacted Files
Coverage Δ

src/elf.rs
91.98% <ø> (ø)

src/vm.rs
58.85% <1.44%> (-9.81%)
:arrow_down:

src/static_analysis.rs
68.20% <46.66%> (-0.19%)
:arrow_down:

src/disassembler.rs
92.71% <100.00%> (+0.07%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Lichtso could you please rerun CI? The last run failed because of issues in CI itself.

@Lichtso thank you, now it was my fault. I've fixed, please rerun the CI!

Seems to pass CI now, can you split the disassembler changes into a separate PR?

Seems to pass CI now, can you split the disassembler changes into a separate PR?

I'm not sure that I've understood you correctly, since CI had already passed, but okay, I will remain only disassembler changes in this PR and create another one.

@Lichtso done, please take a look and run the CI. :)


Feature Support sql cache for hms catalog

Proposed changes
Issue Number: close #xxx
Support sql cache for hms catalog. Legacy planner and Nereids planner are all supported.
Not support partition cache now, not support federated query now.
Test case 1:
Set Config.cache_last_version_interval_second=1.

Execute select * from test_wxy.call_center limit 10, wait a second and submit the query again, the cache will hit at the second time.

Execute refresh table hive_safelycc.test_wxy.call_center, then cache will be missed.

Test case 2:
Set Config.cache_last_version_interval_second=1, enable hms event listener.

Execute select count(0) from test_wxy.call_center, wait a second and submit the query again, the cache will hit at the second time.

Alter this hive table at hive side , wait some seconds (need some time to process the hms event), then submit the query again and the cache will be missed.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.69 seconds
stream load tsv:          540 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size:<PHONE_NUMBER>8 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.27 seconds
stream load tsv:          535 seconds loaded<PHONE_NUMBER>9 Bytes, about 133 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size:<PHONE_NUMBER>1 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.8 seconds
stream load tsv:          538 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>8 Bytes

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.42 seconds
stream load tsv:          530 seconds loaded<PHONE_NUMBER>9 Bytes, about 134 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          64 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size:<PHONE_NUMBER>1 Bytes

run buildall

I will add test case later


How to calculate the GPU memory used in Fig1 (C)?

Hi
Thanks so much for your excellent work.
I have some questions about calculating the GPU memory used by inputting different-resolution images (Fig1 C).
Thanks so much for your help
Best regards

Hi! I apply the API of pytorch torch.cuda.max_memory_allocated().


bump level-js

bumping level-js ended up fixing a bunch of weird errors i was getting when using level-browserify and Buffers

Travis fails on 0.8 and I'm guessing lack of support for ^. Should we remove support for 0.8? /cc @mcollina @rvagg

Yes, remove it. I've been removing it from my projects because of this.

Travis fails on 0.8 and I'm guessing lack of support for ^. Should we remove support for 0.8?

Just FYI you can update the npm on travis and the ^ issue goes away on 0.8, though this just provides people more reasons to stay on 0.8.
language: node_js
before_install: npm install npm -g
node_js:
  - "iojs"
  - "0.12"
  - "0.11"
  - "0.10"
  - "0.8"

@ralphtheninja @rvagg should i update the pr to remove 0.8 support on .travis?

I think we should remove 0.8 support when LevelUp goes 1.0, and we move the dependency of LevelDown to 1.x. For now, I would keep that in.

@mcollina Agree.
@mafintosh So perhaps just add the npm i npm -g to .travis.yml for now as @timoxley suggested

:+1: for me.

travis fixed. @mcollina @ralphtheninja LGTM?

LGTM. Should we bump it to 0.18.2 or 0.19?
Also, why don't we have a level-packager 0.19, given that levelup is at 0.19? How about we make that happen and we tag this 0.19?

@mcollina There is a PR for updated level-packager here https://github.com/Level/level-packager/pull/6 , just need merge and release

I have the publish bit on this one (but not on level-packager). Once we get that out, I think we should get this out too with this change.

bump

@rvagg Mind adding me or someone else to level-packager (or someone else)? Would be sweet to get 0.19 out so we can get this out the door as well.

@mafintosh @ralphtheninja if you need it, I would be super happy to give you the publish permission on this one too :D.

@mcollina Go for it! :)

done :)

@ralphtheninja done

@rvagg :+1:

Updated to<EMAIL_ADDRESS>$ npm publish
+<EMAIL_ADDRESS>

@ralphtheninja thanks!


chore: Remove /restart API

This PR removes the /restart API. Currently, the client decides whether a restart is needed after saving some settings. Depending on that decision, a call is made to /restart and the server then restarts. This PR flips this by having the server take the decision, and merely informing the client of the decision.
This way, we don't need a /restart API. Fewer things there are, fewer things we have to protect.
Automation
/test sanity settings
:mag: Cypress test results

[!WARNING]
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11819840608
Commit: 4195fdf1d1dbd234bdcfde462b1036e4fd8fee25
Cypress dashboard.
Tags: @tag.Sanity, @tag.Settings
Spec:
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.
Thu, 14 Nov 2024 08:57:56 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

/build-deploy-preview skip-tests=true

Super user signup fails because it sets the APPSMITH_ADMIN_EMAILS env variable, which is triggering a restart. It shouldn't do a restart in that case.


Firewall / Diagnostics add 'rules' to Statistics

Hi!
new statistics page looks cool!
Is it possible to add Rules there too?
Imho it would be convenient when debugging the rules (to see the order of the rules after optimization, look at the actual syntax, and look at the statistics, of course etc.)
thanks!

@kulikov-a sorry for breaking this PR... script without suffix made me nervous ;)


Modify position to use SVD sometimes

The way we have this now, you can't truncate when you call position and so the bond dimension can grow pretty badly in sum, applyMPO, and friends.

Codecov Report

Merging #72 into master will decrease coverage by 0.11%.
The diff coverage is 87.87%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   93.29%   93.18%   -0.12%
==========================================
  Files          26       26
  Lines        2416     2435      +19
==========================================
+ Hits         2254     2269      +15
- Misses        162      166       +4

Impacted Files
Coverage Δ

src/mps/mpo.jl
98.8% <85%> (-1.2%)
:arrow_down:

src/mps/mps.jl
99.15% <92.3%> (-0.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 790a6e3...3af1fe2. Read the comment docs.


remove GKE leftovers

We no longer download COS headers files.
GKE directory no longer hosted on KubeArmor repository causing ci to fail during artifact building.
Signed-off-by: Achref ben saad<EMAIL_ADDRESS>

Example of a failed CI: https://github.com/kubearmor/KubeArmor/actions/runs/3295182493/jobs/5433779765

There's already a PR raised for this, closing this in favour of that
#943


Performance improvement: Character.isWhitespace replaced with naive ==.

Motivation:
Right now netty uses Character.isWhitespace check for whitespaces in some places of HttpObjectDecoder and few others http classes. However, this method is not intrinsic and slower than naive comparing with equal operator == (as it uses table lookup).
Modification:
Character.isWhitespace repalced with ==. !Character.isWhitespace replaced with !=.
Result:
Tests show that splitHeader method of HttpRequestDecoder is 30% faster.
Benchmark for Character.isWhitespace vs == :
@BenchmarkMode(Mode.Throughput)
@Fork(1)
@State(Scope.Thread)
@Warmup(iterations = 10, time = 1, batchSize = 1000)
@Measurement(iterations = 20, time = 1, batchSize = 1000)
public class CharacterCompare {

    private char c = 'c';

    @Benchmark
    public boolean characterIsWhitespaceChar() {
        return Character.isWhitespace(c);
    }

    @Benchmark
    public boolean naiveCheckChar() {
        return c == ' ';
    }
}

Result:
Benchmark                                    Mode  Cnt       Score       Error  Units
CharacterCompare.characterIsWhitespaceChar  thrpt   20  287834.304 ± 16050.006  ops/s
CharacterCompare.naiveCheckChar             thrpt   20  355577.043 ± 39929.517  ops/s

Benchmark for splitHeader of HttpRequestDecoder (you need to make fields and method public to make it work) :
@State(Scope.Benchmark)
@Warmup(iterations = 10)
@Measurement(iterations = 20)
public class HttpObjectDecoderSplitHeadersBenchmark extends AbstractMicrobenchmark {

    private HttpRequestDecoder httpRequestDecoder = new HttpRequestDecoder();
    private AppendableCharSequence header = new AppendableCharSequence(23).append("Content-Type: text/html");

    @Benchmark
    public CharSequence oldDecoder() throws Exception {
        httpRequestDecoder.splitHeader(header);
        return httpRequestDecoder.name;
    }

    @Benchmark
    public CharSequence newDecoder() throws Exception {
        httpRequestDecoder.splitHeaderNew(header);
        return httpRequestDecoder.name;
    }

}

Result:
Benchmark                                           Mode  Cnt         Score         Error  Units
HttpObjectDecoderSplitHeadersBenchmark.newDecoder  thrpt   40  21289487.337 ±  986998.323  ops/s
HttpObjectDecoderSplitHeadersBenchmark.oldDecoder  thrpt   40  14586426.110 ± 1328832.579  ops/s

This is change in behaviour.
https://tools.ietf.org/html/rfc7230#section-3.5
   Although the request-line and status-line grammar rules require that
   each of the component elements be separated by a single SP octet,
   recipients MAY instead parse on whitespace-delimited word boundaries
   and, aside from the CRLF terminator, treat any form of whitespace as
   the SP separator while ignoring preceding or trailing whitespace;
   such whitespace includes one or more of the following octets: SP,
   HTAB, VT (%x0B), FF (%x0C), or bare CR.

@fenik17 you are right. Somehow I missed javadocs explanation.


OneDrive File Picker JavaScript SDK v7.0 - IE issue

Hi
I'm using OneDrive File Picker JavaScript SDK v7.0 in may Outlook 365 app (add-in). Everything works fin in chrome but in IE some security settings (on some computers) cause issues and as a result:

file picker is shown but in browsing mode (no p=2 at the end of the URL = no OK / Cancel buttons)
after authentication application picker does not redirect to OneDrive

It looks like:

there is problem with accessing popup window
window.name which is used to pass data is cleared during redirect

Changing some security settings like 'Protected mode' or trusted sites seems to solve this - but it's hard to find correct configuration.
Thanks

Hi @Draggon thanks for updating that, right now we do rely on window.name to pass config and for your case in IE, because the browser behavior regard redirect from untrusted site to trusted site is cross boundary so it clears the window.name. Hope this answer your question.

I've found that my issues are also related with using picker in in IFrame with sandbox attribute. Despite of all required parameters IE does not allow to redirect to 'login.microsoftonline.com' in our picker in this scenario.
Finally I've managed to make it working by enabling "Protected mode' for internet / intranet / safe sites and adding 'https://login.microsoftonline.com' and my app url to safe sites.
Honestly I do not understand why 'Protected mode' helps but now everything works fine.


remove inventory from repository?

or create a new design-toolkit repo? too many files that take up too much space and this is mostly for mockups

yes. fork off the toolkit.

created the https://github.com/NYPL/design-toolkit/ repo


Make shear operation area preserving

This PR handles issue #1185.
PR #1371 attempted to fix this, but noticed the issue that the formula did not give the same shear direction - the reason for this is that the formulas in #1185 used a different sign for the shear.
So, to fix the problem, we just have to replace the signs of shear_x and shear_y in the matrix formula from #1185.
I verified the formula by hand, and by the following sympy code:
from sympy import Matrix, cos, sin, tan, simplify
from sympy.abc import x, y, phi

Xs = Matrix(
        [[1, -tan(x)],
         [0, 1]]
        )

Ys = Matrix(
        [[1, 0],
         [-tan(y), 1]]
        )

R = Matrix(
        [[cos(phi), -sin(phi)],
         [sin(phi), cos(phi)]]
        )

RSS = Matrix(
        [[cos(phi - y)/cos(y), -cos(phi - y)*tan(x)/cos(y) - sin(phi)],
         [sin(phi - y)/cos(y), -sin(phi - y)*tan(x)/cos(y) + cos(phi)]])

print(simplify(R * Ys * Xs - RSS))
# Matrix([[0, 0], [0, 0]])

(One thing I'm uncertain is whether there is really a gain of performance by avoiding to calculate the explicit matrices and inverses, since the matrices are small and numpy can be quite efficient - I might run some time comparisons to check.)

Codecov Report

Merging #1529 into master will decrease coverage by 0.33%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #1529      +/-   ##
==========================================
- Coverage    64.4%   64.07%   -0.34%
==========================================
  Files          87       87
  Lines        6746     6750       +4
  Branches     1038     1038
==========================================
- Hits         4345     4325      -20
- Misses       2099     2110      +11
- Partials      302      315      +13

Impacted Files
Coverage Δ

torchvision/transforms/functional.py
70.53% <88.88%> (-0.53%)
:arrow_down:

torchvision/datasets/cifar.py
71.26% <0%> (-6.9%)
:arrow_down:

torchvision/datasets/lsun.py
20.4% <0%> (-4.09%)
:arrow_down:

torchvision/datasets/folder.py
78.2% <0%> (-3.85%)
:arrow_down:

torchvision/datasets/voc.py
19.58% <0%> (-2.07%)
:arrow_down:

torchvision/transforms/transforms.py
79.88% <0%> (-1.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f612182...1bba842. Read the comment docs.


SIL: Print+parse the clang node owner of SILFunctions.

What's in this pull request?

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

Adds a "[clang <value_decl>]" attribute to a SIL function declaration for clang imported functions.
SIL serialization already handled this attribute, but not the SIL parser.
Fixes rdar://problem/27378249, SR-2089

@swift-ci Please test and merge

@swift-ci Please test and merge

@swift-ci Please smoke test and merge


Use ledmatrix field editor

Move ledmatrix from grove-zero into pxt-core. Updated it with better touch support.
Converted imageLiterals to use the field editor instead of the checkbox grid hack.

Would be great to support other image sizes... eventually.


Kanban Board Project

Kanban Board project link https://github.com/Ayokunnumi1/Mini-Netflix-Website/projects/1
Number of coding partners: 2

Hi @Team
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔  Good Setup
Required Changes ♻

[ ] Based on the requirements: each of the team members should assign themselves to the correct cards. Decide who will be the assignee for the cards marked as group tasks. All cards on your Kanban board should have assignees, please assign the cards on the board appropriately.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:

N/A

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

I and my coding partner have made the necessary adjustments in the project. We have assigned ourselves to each task including the group task. Here is a link to our kanban board https://github.com/Ayokunnumi1/Mini-Netflix-Website/projects/1

Hi   @Ayokunnumi1 @hydaline-code
Your project is complete  👍 💯   There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights 👏🏻
✔ Good Job for Provide the link to their GitHub project and setup the Kanban Project booard correctly.
✔ Good Job for Provide the information about the number of people in their group.
✔ Correctly all cards are assigned to team members
✔ Good job for Implemented Suggested changes.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.


Add ToSql/FromSql for [u8; N]

Fixes #536

https://caniuse.rs/features/min_const_generics => MSRV = 1.51, should be ok !

Check if i128_blob and uuid can reuse this.
https://doc.rust-lang.org/std/primitive.i128.html#method.from_be_bytes
https://doc.rust-lang.org/std/primitive.i128.html#method.to_be_bytes

Just for reference, rust-postgres implementations:
https://github.com/sfackler/rust-postgres/blob/master/postgres-types/src/lib.rs#L885-L896
https://github.com/sfackler/rust-postgres/blob/master/postgres-types/src/lib.rs#L535-L566

Check if i128_blob and uuid can reuse this.

Yep, it cleans up nicely:
#[cfg(feature = "i128_blob")]
#[cfg_attr(docsrs, doc(cfg(feature = "i128_blob")))]
impl FromSql for i128 {
    #[inline]
    fn column_result(value: ValueRef<'_>) -> FromSqlResult<Self> {
        let bytes = <[u8; 16]>::column_result(value)?;
        Ok(i128::from_be_bytes(bytes) ^ (1i128 << 127))
    }
}

#[cfg(feature = "uuid")]
#[cfg_attr(docsrs, doc(cfg(feature = "uuid")))]
impl FromSql for uuid::Uuid {
    #[inline]
    fn column_result(value: ValueRef<'_>) -> FromSqlResult<Self> {
        let bytes = <[u8; 16]>::column_result(value)?;
        Ok(uuid::Uuid::from_u128(u128::from_be_bytes(bytes)))
    }
}

This would technically be a breaking change if they now all collapse into the same error type though, let me know if that's OK.

This would technically be a breaking change if they now all collapse into the same error type though, let me know if that's OK.

I am OK with a breaking change but @thomcc may not.

This would technically be a breaking change if they now all collapse into the same error type though, let me know if that's OK.

I'd be thrilled for us to replace InvalidI128Size and InvalidUuidSize with the more general InvalidSize. Only nit is a minor bikeshed, perhaps we should name it InvalidBlobSize?

Oh, also, can you squash some of your commits? I'd rather not have the reverted stuff and such that mucks with the CI.

Cool, will do all of this!

Done!


NuitkaOptimizationError since 0.6.18rc4

Nuitka 0.6.18rc7 (from source)
CPython 3.7.6 on Windows 7 SP1 64bit
Works with Nuitka 0.6.18rc3, fails starting from Nuitka 0.6.18rc4.
Running Nuitka with ..\path\to\python\python -m nuitka --plugin-enable=pylint-warnings --standalone --prefer-source-code --follow-stdlib --lto=yes --include-plugin-files=..\path\to\Pmw.py --python-flag=no_site,no_randomization,no_warnings,no_asserts,no_docstrings --disable-dll-dependency-cache --windows-disable-console ..\path\to\myproject.py
Nuitka prints out the following message and aborts the build process:
Nuitka:INFO: Starting Python compilation with Nuitka '0.6.18rc7' on Python '3.7'
 commercial None.

Nuitka-Plugins:INFO: implicit-imports: Implicit dependencies of module 'tkinter'
 added '_tkinter'.
Nuitka-Plugins:INFO: implicit-imports: Implicit dependencies of module 'socket'
added '_socket'.
PASS 1:  93%|██████████████████████████████?  | 346/372, direct.showbase.LoaderP
roblem with statement at D:\p3d\build-hd\panda3d-editor-win64\direct\showbase\Lo
ader.py:139:
->         try:

Problem with statement at D:\p3d\build-hd\panda3d-editor-win64\direct\showbase\L
oader.py:130:
->     @classmethod

Problem with statement at D:\p3d\build-hd\panda3d-editor-win64\direct\showbase\L
oader.py:130:
->     @classmethod

Problem with statement at D:\p3d\build-hd\panda3d-editor-win64\direct\showbase\L
oader.py:19:
-> class Loader(DirectObject):

Problem with statement at D:\p3d\build-hd\panda3d-editor-win64\direct\showbase\L
oader.py:19:
-> class Loader(DirectObject):

Problem with statement at D:\p3d\build-hd\panda3d-editor-win64\direct\showbase\L
oader.py:19:
-> class Loader(DirectObject):

Problem with statement at D:\p3d\build-hd\panda3d-editor-win64\direct\showbase\L
oader.py:19:
-> class Loader(DirectObject):

Nuitka:INFO: Interrupted while working on '<Node 'COMPILED_PYTHON_MODULE' with {
'filename': 'D:\\p3d\\build-hd\\panda3d-editor-win64\\direct\\showbase\\Loader.p
y', 'module_name': <ModuleName direct.showbase.Loader>, 'code_flags': ''}>'.
                                                                               T
raceback (most recent call last):█████████████████████████████████    | 346/372
  File "D:\p3d\build-hd\Nuitka\nuitka\__main__.py", line 187, in <module>
    main()
  File "D:\p3d\build-hd\Nuitka\nuitka\__main__.py", line 173, in main
    MainControl.main()
  File "D:\p3d\build-hd\Nuitka\nuitka\MainControl.py", line 757, in main
    main_module = _createNodeTree(filename=filename)
  File "D:\p3d\build-hd\Nuitka\nuitka\MainControl.py", line 174, in _createNodeT
ree
    Optimization.optimize(main_module.getOutputFilename())
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\Optimization.py", line 349,
in optimize
    finished = makeOptimizationPass()
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\Optimization.py", line 312,
in makeOptimizationPass
    changed = optimizeModule(current_module)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\Optimization.py", line 207,
in optimizeModule
    changed = optimizeCompiledPythonModule(module)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\Optimization.py", line 103,
in optimizeCompiledPythonModule
    scopes_were_incomplete = module.computeModule()
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\ModuleNodes.py", line 524, in comput
eModule
    trace_collection=self.trace_collection
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\StatementNodes.py", line 163, in com
puteStatementsSequence
    new_statement = statement.computeStatementsSequence(trace_collection)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\FrameNodes.py", line 182, in compute
StatementsSequence
    new_statement = trace_collection.onStatement(statement=statement)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 6
11, in onStatement
    new_statement, change_tags, change_desc = statement.computeStatement(self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\TryNodes.py", line 98, in computeSta
tement
    result = tried.computeStatementsSequence(trace_collection=trace_collection)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\StatementNodes.py", line 165, in com
puteStatementsSequence
    new_statement = trace_collection.onStatement(statement=statement)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 6
11, in onStatement
    new_statement, change_tags, change_desc = statement.computeStatement(self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\AssignNodes.py", line 275, in comput
eStatement
    source = trace_collection.onExpression(self.subnode_source)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 5
92, in onExpression
    r = expression.computeExpressionRaw(trace_collection=self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\OutlineNodes.py", line 240, in compu
teExpressionRaw
    result = body.computeStatementsSequence(trace_collection=trace_collection)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\StatementNodes.py", line 165, in com
puteStatementsSequence
    new_statement = trace_collection.onStatement(statement=statement)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 6
11, in onStatement
    new_statement, change_tags, change_desc = statement.computeStatement(self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\TryNodes.py", line 98, in computeSta
tement
    result = tried.computeStatementsSequence(trace_collection=trace_collection)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\StatementNodes.py", line 165, in com
puteStatementsSequence
    new_statement = trace_collection.onStatement(statement=statement)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 6
11, in onStatement
    new_statement, change_tags, change_desc = statement.computeStatement(self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\TryNodes.py", line 98, in computeSta
tement
    result = tried.computeStatementsSequence(trace_collection=trace_collection)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\StatementNodes.py", line 163, in com
puteStatementsSequence
    new_statement = statement.computeStatementsSequence(trace_collection)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\FrameNodes.py", line 182, in compute
StatementsSequence
    new_statement = trace_collection.onStatement(statement=statement)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 6
11, in onStatement
    new_statement, change_tags, change_desc = statement.computeStatement(self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\LocalsDictNodes.py", line 404, in co
mputeStatement
    trace_collection=trace_collection
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\NodeBases.py", line 897, in computeS
tatementSubExpressions
    expression = trace_collection.onExpression(expression=expression)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 5
92, in onExpression
    r = expression.computeExpressionRaw(trace_collection=self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\ExpressionBases.py", line 1165, in c
omputeExpressionRaw
    expression = trace_collection.onExpression(sub_expression)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 5
92, in onExpression
    r = expression.computeExpressionRaw(trace_collection=self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\ExpressionBases.py", line 1373, in c
omputeExpressionRaw
    expression = trace_collection.onExpression(expression=sub_expression)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 5
92, in onExpression
    r = expression.computeExpressionRaw(trace_collection=self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\ExpressionBases.py", line 1165, in c
omputeExpressionRaw
    expression = trace_collection.onExpression(sub_expression)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 5
92, in onExpression
    r = expression.computeExpressionRaw(trace_collection=self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\FunctionNodes.py", line 1089, in com
puteExpressionRaw
    trace_collection.onUsedFunction(self.getFunctionBody())
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 4
75, in onUsedFunction
    function_body.computeFunctionRaw(self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\FunctionNodes.py", line 495, in comp
uteFunctionRaw
    self.computeFunction(trace_collection)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\FunctionNodes.py", line 511, in comp
uteFunction
    trace_collection=trace_collection
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\StatementNodes.py", line 165, in com
puteStatementsSequence
    new_statement = trace_collection.onStatement(statement=statement)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 6
11, in onStatement
    new_statement, change_tags, change_desc = statement.computeStatement(self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\TryNodes.py", line 98, in computeSta
tement
    result = tried.computeStatementsSequence(trace_collection=trace_collection)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\StatementNodes.py", line 163, in com
puteStatementsSequence
    new_statement = statement.computeStatementsSequence(trace_collection)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\FrameNodes.py", line 182, in compute
StatementsSequence
    new_statement = trace_collection.onStatement(statement=statement)
  File "D:\p3d\build-hd\Nuitka\nuitka\optimizations\TraceCollections.py", line 6
11, in onStatement
    new_statement, change_tags, change_desc = statement.computeStatement(self)
  File "D:\p3d\build-hd\Nuitka\nuitka\nodes\TryNodes.py", line 143, in computeSt
atement
    statement,
nuitka.Errors.NuitkaOptimizationError:
This statement does raise but didn't annotate an exception exit.

    <node is_temp="False" kind="StatementAssignmentVariable" line="140" owner="d
irect$showbase$Loader$$$function__12__loadPythonFileTypes" var_type="object" var
iable_name="pkg_resources">
      <role name="source">
        <node kind="ExpressionImportModuleFixed" line="140" module_name="pkg_res
ources" />
      </role>
    </node>

The above information should be included in a bug report.

The module pkg_resources is present in the environment.
Please let me know if you need a project example.

This report is very incoherent, 0.6.17rc never contained this node. You might mean 0.6.18rc,, but these would be old and I believe it has been fixed since.

Just saw that the title names the 18, OK. I think rc5 or higher should work.

I meant to write 0.6.18rc3/4/7, it's corrected now in the initial report.

I think rc5 or higher should work.

It doesn't, the message above was copied from 0.6.18rc7:
Nuitka:INFO: Starting Python compilation with Nuitka '0.6.18rc7' on Python '3.7'
 commercial None.

Then I indeed need a reproducer, I havent' see that, and it seems impossible to me, very strange.

As an aside, Pmw should work with just the pmw plugin, you are doing it wrong I think there. Not saying it doesn' work, just too complicated.

Likely this Loader.py would be enough.

Example reproducer:
from direct.showbase.ShowBase import ShowBase

class MyApp(ShowBase):

    def __init__(self):
        ShowBase.__init__(self)

app = MyApp()
app.run()

You will need panda3d, e. g. through pip install panda3d.
You can see Loader.py here: https://github.com/panda3d/panda3d/blob/master/direct/src/showbase/Loader.py

As an aside, Pmw should work with just the pmw plugin, you are doing it wrong I think there. Not saying it doesn' work, just too complicated.

Thanks, I'm very well aware of the Pmw plugin, one of the first, if not the first, plugins for Nuitka. I'm "bundling" it manually. I think I set it up this way back when it did not exist yet and didn't touch my scripts, yet.
I don't see a button to re-"open" this issue.

Ok, I managed to reproduce it just now with this import, it's hard to related filenames to PyPI packages.

Due to the severity of the bug, I have rebased develop rc4 with the fixup to the commit, so bisection remains unaffected by this kind of thing.

I forgot to re-open, sorry, probably limited to contributors, because you know, some people like to spam click buttons unfortunately. But I would close now. :)


Redesign dev doesn't yet follow abseil philosophy well enough

This pull request can not be accepted until it complies with abseil philosophy

#2 replaces this merge request in most actively applicable regards


【kafka-index-service  Druid-0.12.3】Nothing to publish, skipping publish step

Hi， team. I am a druid new user, when ingesting data from kafka to druid by kafka-indexing-service,I met a confused question:
after task executed successfully, task log shows:
"io.druid.segment.realtime.appenderator.BaseAppenderatorDriver - Nothing to publish, skipping publish step."
I cannot recognize what's wrong with it.....

Does someone had the same problem？

either there is no events to be ingested in the topic or all the events are unparseable.

"org.apache.kafka.common.network.Selector - Connection with localhost/<IP_ADDRESS> disconnected"
@helianthuslulu Where did u see this error?
and what did u modify in "$KAFKA_HOME/config/server.proerties" to resolve this?


feat(rbac): role overview

Resolves:
https://github.com/janus-idp/backstage-plugins/issues/854
GIF:
https://github.com/janus-idp/backstage-plugins/assets/22490998/8583257f-eaae-4503-a781-0fa57c915499
TODO:
Add tests

@debsmita1 the changes needed are:

Members table name to 'Users and groups'.
The number of 'Permission policies' we should show is the number of policies- Eg: if there is a single row and there are 'Read,Update,Delete' those are 3 policies.

Hey @debsmita1, thanks! Noticed a few things:

The "role: default/guests" header looks a bit off – thinking it should have a background like the other catalog pages, also the tabs here seem to be floating
The about card needs to be wider, keeping it to a single row of content. "Modified by" and "Last modified" should share the row with the "Description" text (see design)
The edit button is missing in all cards
There's this empty space above each table, right before the column titles. Is that the table header? Can we remove it?

@parvathyvr FYI

Another small nit:
Cards should be aligned left to the header text (for example at the beginning of the video we can see that the cards are aligned to the left side of the "Administration" header, while at 00:03 we can see that they jumped to the right and are not aligned with the header.

Hey @debsmita1, thanks! Noticed a few things:

The "role: default/guests" header looks a bit off – thinking it should have a background like the other catalog pages, also the tabs here seem to be floating
The about card needs to be wider, keeping it to a single row of content. "Modified by" and "Last modified" should share the row with the "Description" text (see design)
The edit button is missing in all cards
There's this empty space above each table, right before the column titles. Is that the table header? Can we remove it?

@parvathyvr FYI

Updated

cc @nirfarkas

@debsmita1 Thanks for the updated screen. Few things missing:

For the Permission policies table-the number shown should be the number of policies selected.
For the Users and groups table, for type user we could keep it blank as in the design. Because i don’t see a members card in the User overview page.

@debsmita1 Thanks for the updated screen. Few things missing:

For the Permission policies table-the number shown should be the number of policies selected.
For the Users and groups table, for type user we could keep it blank as in the design. Because i don’t see a members card in the User overview page.

@parvathyvr I was wondering if we should have a search bar in the members and permissions tables? Wdyt?

The edit button is missing in all cards
I think this is still missing

Details

@ShiranHi We haven't implemented Edit yet. There's a separate story to handle it

The edit button is missing in all cards

I think this is still missing

@ShiranHi We haven't implemented Edit yet. There's a separate story to handle it

@parvathyvr I was wondering if we should have a search bar in the members and permissions tables? Wdyt?

@divyanshiGupta it's a good idea! I didn't add it since i haven't noticed search in the cards of Overview page! But if we can incorporate search into the table,it's a good addition. CC @debsmita1

@parvathyvr I was wondering if we should have a search bar in the members and permissions tables? Wdyt?

@divyanshiGupta it's a good idea! I didn't add it since i haven't noticed search in the cards of Overview page! But if we can incorporate search into the table,it's a good addition. CC @debsmita1

Done

@debsmita1 I see a mismatch in the number of users/groups and the policies in list page vs overview page

the reason for the user is, that the user is not registered however if we get the user in API we should show it irrespective of whether it's registered or not.
and the reason for policies in in list we are showing count of all the policies irrespective of effect allow or deny but in overview we only list allow once hence the mismatch @parvathyvr Let us know your thoughts here

Addressed this, now listing all users received in reponse, if a user doesn't exist simply showing "Entity not found" when the user is clicked.
Also, not listing a role if it has no users/ policies associated with it


Update to 1.18

Removed RapidRegister from testmod for now
Seems to work from my testing

LGTM, Thanks!


implemented option to not have the accept key select besides confirming

Hey @IngoMeyer441 yeah, I'm pretty noob... I don't know how to reopen the pr I closed by accident (a.k.a. stupidity). As mentioned I'll go brush my git, but still wanted to leave the changes available somewhere in case you didn't have them already. Again, sorry for the annoyance 😅  and thanks for the package, prompt response and help, really appreciated. Cheers, enjoy the weekend

Hey @raulparada,
that is really no problem. I am happy about everyone who contributes to this project and keeps it alive. I didn't apply your changes myself because it didn't want to steel your contribution statistics on GitHub. By merging your PR, you are listed as contributor to this project.
Thanks for your contribution!


⚠ Bofrost.at has degraded performance

In 46cb54a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1317 ms

Resolved: Bofrost.at performance has improved in 0b130ef after 6 minutes.


Add issue template files

Bug Report
Feature Request
Ask a Question

Preview of this PR.

Thanks, I've fixed to unify them.


issue #19

wrote one of possible problem solutions - added calls to ::Plotrb::Base.classify method to Mark and Scale classes (to camelcase field names), fixed tests. Another solution would be to remove classify methods from base.rb completely (it turned out that this method also downcases first letter, so after removing camelcase problem remains until this is also removed, thus making classify method useless).

@zuhao Please take a look.


GH-35838: [C++] Backpressure broken in asof join node

What changes are included in this PR?
Passing the correct nodes to the backpressure controller, along with better parameter naming/doc.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix".

Closes: #35838

@westonpace Are you OK with me merging this to unblock internal issue? @rtpsw Is working on adding tests now but it might take a while.

I do have a little bit of concern that this test may become flaky on CI machines

Indeed it is flaky - this and this and this CI jobs have failed on the new check. I'll make a quick attempt to fix this.
I agree relying on timing is not good, though that can be said about the pre-PR backpressure test code too, and this PR won't be worse in this respect.

Thinking about loud here:
What we want to test is that if the through put of asof join node is slower than the source, then we would pause the source. Two potential ways that I think we can reliably do this:
(1) Add some sort of "debug options" to manipulate the behavior of asof join to make it run slower. (i.e. Sleep a few seconds before actually starting the work in the processing thread)
(2) Add a downstream node to asof join that processes data slowly (similar to a slow data sink), i.e., process one batch per second. This way, the backpressure would be pushed from the slow sink to asof join then to the data sources.
I think I prefer (2) a bit more because this affects represents a real life case of slow sink.
@westonpace I am not sure if the idea of GatedSourceNode is similar or different, but happy to hear

Thinking about loud here:
What we want to test is that if the through put of asof join node is slower than the source, then we would pause the source. Two potential ways that I think we can reliably do this: (1) Add some sort of "debug options" to manipulate the behavior of asof join to make it run slower. (i.e. Sleep a few seconds before actually starting the work in the processing thread) (2) Add a downstream node to asof join that processes data slowly (similar to a slow data sink), i.e., process one batch per second. This way, the backpressure would be pushed from the slow sink to asof join then to the data sources.
I think I prefer (2) a bit more because this affects represents a real life case of slow sink.
@westonpace I am not sure if the idea of GatedSourceNode is similar or different, but happy to hear

While I'm not sure exactly what Weston has in mind, my understanding is that the GatedSourceNode's goal is to avoid flakiness due to non-deterministic timing. IMO, both (1) and (2) above could be flaky due to non-deterministic timing.
Between (1) and (2) I also wouldn't prefer (1) because the debug-options would change the behavior of the as-of-join node being tested, and I prefer to change the code driving it instead.

IMO, both (1) and (2) above could be flaky due to non-deterministic timing
I think this can be avoided if we make sure the slow sink is blocking. i.e.

slow_sink.pause_processing() # make sure slow_sink stop processing so what we can trigger backpresure
# validate backpresure is triggered
slow_sink.resume_processing()
# validate plan exists normally and resume counter is expected

I added a delaying node after the as-of-join-node and used different backpressure detection checks. I observed that the as-of-join-node calls to Pause and Resume are independent, because the former/latter occurs when crossing the high/low threshold up/down.

Prior to the recent commit, I noticed that some (macOS, I think) CI jobs were timing out. I figured this happened because gate() never returned true, which means the queue never crossed a threshold, likely due to an extreme timing of threaded operations. Since the low and high queue thresholds are 4 and 8, respectively, my guess was the number of batches in the backpressure tests (previously 10) was too small. Doubling the number of batches should therefore help, and indeed this seems to work.

@github-actions crossbow submit ubuntu-cpp-thread-sanitizer

In the recent commit, I included the changes in this PR, which are necessary to avoid TSAN errors.

Let me take a look at this later

Per discussion @rtpsw let's use the gated node because it doesn't rely on timing, update this PR and then we should be able to merge.

Per discussion @rtpsw let's use the gated node because it doesn't rely on timing, update this PR and then we should be able to merge.

This approach ran into a problem. See this post.

To clarify status of this PR - we should update the test to use GatedNode instead

Done.

(2) Please update the original iGH ssue to better reflect the change in this PR

It's authored by Weston - I don't have permission to edit. I edited the description of this PR instead,

This CI job failure suggests that the tightening condition (in this commit) isn't always true.

(2) Please update the original iGH ssue to better reflect the change in this PR

It's authored by Weston - I don't have permission to edit. I edited the description of this PR instead,

Ok we can leave it as is then.


Reduce duplication of DA code in nearly identical code in the three compute kernels

The #385 PR implements three sections of nearly identical code in the three compute kernels:
lines 229-252 and lines 445-469
lines 831-855 and lines 1015-1040
lines 1235-1262 and lines 1377-1430 in mc_reach.pyx.
I'm thinking that we can remove some of the code duplication and hopefully streamline things (both generally desirable goals) for all the inputs if we create a function to handle those calculations.
The challenge would be that there are slight differences in the handling of timesteps and in the declaration of the flowveldepth arrays. Can anyone think of a way to make a cython function to treat a cdef float[:,::1] and a cdef np.ndarray[float, ndim=3] as synonymous? We have those two constructions in our different compute functions representing the same variables (flowveldepth) and I would like to prepare a single function to initialize them both. In other words, I would like to create a function into which I can pass either the memoryview with 2 dimensions or the nd array with 3 dimensions and, given the congruency of their data storage, populate them equivalently.
One option would be to modify the caching-based version of our function to use the 3-dimensional declaration (so they would all be synchronous.) But that loses the advantages of the typed memoryview, which are more general and more efficiently used with cython. See the following:

"Typed memoryviews allow efficient access to memory buffers, such as those underlying NumPy arrays, without incurring any Python overhead. Memoryviews are similar to the current NumPy array buffer support (np.ndarray[np.float64_t, ndim=2]), but they have more features and cleaner syntax."
https://cython.readthedocs.io/en/latest/src/userguide/memoryviews.html

With that in mind, I'd prefer to leave the memoryview in place and find a way to convert the array declaration, at least for purposes of handling inside this function.
Originally posted by @jameshalgren in https://github.com/NOAA-OWP/t-route/issues/385#issuecomment-902110983

closed with #385


Add ability to grab scss files

I generally use bootstrap or foundation scss files. I keep these on a network share, so I can load them with this extension using the filesystem provider but not very well. For example:
{
      "provider": "filesystem",
      "id": "[network location]\\Bootstrap\\bootstrap-4.1.0\\scss\\",
      "path": "wwwroot/lib/bootstrap/scss/",
      "files": [
        "bootstrap-grid.scss",
        "bootstrap-reboot.scss",
        ...

First, there are 38 files in this folder, and it would be much nicer to just type *.
Second, there are two subfolders, mixins and utilities. Those each need there own entry because currently this extension won't grab items in subfolders.
What would be nice is something like this:
{
      "provider": "filesystem",
      "id": "[network location]\\Bootstrap\\bootstrap-4.1.0\\scss\\",
      "path": "wwwroot/lib/bootstrap/scss/",
      "files": [
           **/*
      ]

This would work fine for me, but others may prefer an online provider. Maybe a provider such as unpkg would work for that.

I believe if you leave the files part out entirely, and just use the source and destination paths, you get the equivalent of pulling in all files?

Ah sure enough, you do get all the files in that directory, but not sub directories. Still that is much cleaner than listing all 83 or so files individually. A step in the right direction.

Support for globbing patterns would improve capabilities of the "files" collection considerably for when you want a subset of files but it would be a pain to list them all out.
@justcla I think we talked about this once before.  Can you put this on the backlog?

Thanks for raising the issue @mattfraley1
As @nickalbrecht mentioned, you can leave out the files to get all the files in the library. And when you do this with the CDNJS provider, it pulls down all files in all directories.
As you pointed out, the filesystem provider only brings down files from the current directory - and not any of the subdirectories. Personally, I see this behavior as weird and inconsistent with the other provider. Perhaps we should change the filesystem provider behavior so that all files and folders are fetched if no files are specified.
Separately, supporting file globbing would be very cool! I'll add it to the backlog.

Update: I am raising a bug for the filesystem provider to return all files and folders in the prescribed location.

Closing this as a 1/2 dupe of #42 and 1/2 dupe of #350.  You'll be able to use * to match all files in the directory per #42, but the filesystem provider still doesn't handle recursive cases.


ci(perf-measures): support KB

We can check kb

hmm?
https://github.com/honojs/hono/actions/runs/11945102648/job/33297187610?pr=3696#step:7:95
@k2tzumi What do you know?

JS Bundle Analysis - Avoid shipping oversized bundles

Interesting 👀

It seems to work well

Hi @EdamAme-x
Good PR! One thing I noticed.
When displaying Bundle Size, I think it would be easier to compare "K" with "B":

In the above, the "B" and "KB" digits appear to be aligned. ls -lh command also uses the method I suggest, so it's okay.

thanks for suggestions

@EdamAme-x
Thank! Merging.


Pending on connection to aws elasti cache if tls property is not set

I am using library to connect to the AWS ElastiCache and I figured out that when I forget to set tls to true on call await redis.get() library just stuck on this call without any exception that wrong connection or something like this. Ok I forget to set TLS but why need to be in a loop in that line. It is very unpredicted behavior I would expect the exception or null as return. Instead of be in infinity loop.

Root for this, I think it's not just "AWS" but TLS dependent connections. It should probably be noted at the README


Diploview extended tooltips

Extends relationship tooltips for the vertical diplo ribbon inside diplo view.

The commit history is incorrect for this PR, still containing the history from your last PR. Please base all future PRs on fresh branches instead, you can read more about why/how here. From the looks of it, you did try using a separate branch for this PR, so that indicates to me that the branch you based this new one on (master, perhaps?) doesn't have a correct history. To fix this, use git reset --hard upstream/master while you've checked out your master branch (be cautious, however, doing this will lose any unique changes you've made to the master branch that cause it to diverge from the main repo). If you haven't already, you'll need to first add the main repo as a remote using
git remote add upstream https://github.com/chaorace/cqui.git
Since this is a relatively minor history issue, I'll just correct it myself using my temporary PR access rights, but please use git log in the future to check your commit history before pushing to ensure that it's correct

Impossible, this was made in a completely fresh branch from a completely new repository fork. How would what you say be possible????

Here's a screengrab of the history from the commits tab if you don't believe me. It's entirely possible that something was overlooked and the history issue slipped through the cracks. Like I said, in the future just double-check with git log before pushing, this kind of thing happens to the best of us

Anyways, I've rewritten the branch history to be correct. I'll test the change now and merge in just a minute

Oh nonono, that is not an OLD commit history, I changed the modinfo file again to include the new file, and then again to correct the issue with the tab/spacing... that is not OLD, is part of this commit/branch.

facepalm woops, let me restore that then

"happens to the best of us"
hehe

I am creating new repos every time I want to contribute, to avoid any type of issues...

Hey it looked identical to the last PR commit history almost word-for-word, thanks for bearing with my temporary bout of incompetence

still good for a late night laugh, isn't it? No worries, I am no master of the hub at all, not yet anyways...

Late night laugh indeed! Anyways, I've fixed the commit to actually include the committed changes. Apologies about the unnecessary mutation in history, the PR credit should still go solely to you on merging

Where are you btw? East coast?

Yes, though this isn't a natural time for me to be awake. I just finished a project rollout at work yesterday and passed out as soon as I got home. I figured I would take advantage of the unusual opening in my time now that I've woken up.  Apologies if I've woken you!

nah, PNW here, 2300 hours


Default tab width doesn't match Prettier

The docs mention that it follows Prettier default, but it doesn't (it's set to 4, not 2).

I could have been more clear in the documentation: the option for tabWidth is the same (that is, the same identifier for the configuration option is used). However, the default for that option in this project is 4 spaces, as this matches the style used in NGINX's own documentation.


Possibility to set your own -m, -z, -q arguments for cwebp

I've implemented possibility to set your own -m, -z, -q arguments for cwebp instead of hardcoded -m 6

@mstraczkowski Great stuff thanks!


Increment version for cognitiveservices releases

Increment package version after release of Azure.ResourceManager.CognitiveServices

Close this one as the ApiCompatVersion will be updated by another PR.


error with login

when I put my number it appear the following:
file:///usr/local/lib/node_modules/truecallerjs/node_modules/axios/lib/core/AxiosError.js:89
AxiosError.call(axiosError, error.message, code, config, request, response);
^
AxiosError: read ECONNRESET
at AxiosError.from (file:///usr/local/lib/node_modules/truecallerjs/node_modules/axios/lib/core/AxiosError.js:89:14)
at RedirectableRequest.handleRequestError (file:///usr/local/lib/node_modules/truecallerjs/node_modules/axios/lib/adapters/http.js:591:25)
at RedirectableRequest.emit (node:events:513:28)
at eventHandlers. (/usr/local/lib/node_modules/truecallerjs/node_modules/follow-redirects/index.js:14:24)
at ClientRequest.emit (node:events:513:28)
at TLSSocket.socketErrorListener (node:_http_client:496:9)
at TLSSocket.emit (node:events:513:28)
at emitErrorNT (node:internal/streams/destroy:151:8)
at emitErrorCloseNT (node:internal/streams/destroy:116:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
Node.js v18.13.0

The error message you provided suggests that there is an issue with the connection. The specific error "read ECONNRESET" typically indicates that the connection was terminated unexpectedly by the server or the network.
Here are a few things you can try to resolve the issue:

Check your internet connection: Make sure you have a stable internet connection and there are no network issues that might be causing the connection reset.

Update TruecallerJS and its dependencies: Ensure that you are using the latest version of TruecallerJS and any related dependencies. You can try updating them by running the following command in your project directory:
npm update truecallerjs

Retry the request: Sometimes the connection reset error can occur due to temporary server issues. You can retry the request after a short delay to see if it resolves the problem.

Verify your input: Double-check that you are providing valid input, such as a valid phone number, in the correct format expected by the TruecallerJS library.

If none of the above steps resolve the issue, try updating nodejs version.

Not fixx


Can we access javaMethods object from index.html?

Can we access javaMethods object from index.html? If not how do we access java methods from index.html?
lets say I have a Hello class and there is a public "Hey" method. Can I access the method "Hey"?

 <!DOCTYPE html> <html>  <head>    <title>Main page</title>    <meta http-equiv="Content-Type" content="text/html;charset=utf-8">    <script type="text/javascript" charset="utf-8" src="teavm/runtime.js"></script>    <script type="text/javascript" charset="utf-8" src="teavm/classes.js"></script>    <script  type="text/javascript">        alert(javaMethods.get('org.myproject.Hello.hey(II)Ljava/lang/String;').invoke(0, 2));   </script>   </head>   <body onload="main()">    <!-- TODO: add HTML content -->   </body> </html>

No. javaMethods is not really an object. JSO implementation just capable of parsing script you specify in @JSBody and recognize syntactical construct involving javaMethods identifier. Then it just replaces corresponding expression with the direct invocation of a method. You can try to write a simple example and find what JS code is generated by TeaVM.
Why do you need such thing? In your case just put corresponding call in the beginning of main method, i.e.:
Window.alert(Hello.hey(0, 2));

Our external script lives in another script library and we must interact with the teavm generated script.
lets say we have "setNative" method defined to Window object in our outer script.
Will this work? Can I access the processService method this way from our outer script?
@JSBody(params={}, script = "setNative(javaMethods.get('org.myproject.processService(Ljava/lang/String;Ljava/lang/String;IZ'));")
static native void setProcessService();

public void processService(String listenerId,String data, int responseCode,boolean binary) {
}

How about this one? will window.processService call the processService method successfully?
public static void main(String[] args) {
setProcessService();
}
@JSBody(params={}, script = "window.processService=function(listenerId,data,responseCode,binary){javaMethods.get('org.myproject.processService(Ljava/lang/String;Ljava/lang/String;IZ')).invoke(listenerId,data,responseCode,binary);}")
static native void setProcessService();
public void processService(String listenerId,String data, int responseCode,boolean binary) {
}

Again, this won't work. The only thing you can do with javaMethods.get is to call it immediately. Consider another approach:
public interface ProcessServiceExport extends JSObject {
    void process(String listenerId, String data, int responseCode, boolean binary);
}
public class ProcessService implements ProcessService {
    // some code here
}

public static void main(String[] args) {
    export("ProcessService", new ProcessService());
}

@JSBody(params = { "name", "service" }, script = "window[name] = service;")
private static void export(String name, JSObject service);

and call it this way:
ProcessService.process("foo", "bar", 23, true);

This is a kind of hack, since TeaVM is not intended to be invoked from JavaScript directly.

Your second solution seems working. Why suggesting? Just try it!

I design first then implement :). Thanks.


[PT-PiT 24.4] Whitelabel error page - Hilla runner fails

Describe the bug
Application fails to run > It seems the Hilla runner fails to find mvn in the project
Artur attempted to debug it, but we couldn't fix it
hilla project failed log.txt
hilla project failed log & Artur debug attempt.txt
Please let me know if I'm doing something wrong :)
Expected-behavior
No response
Reproduction
I downloaded a project from start.vaadin.com containing a Hilla + React view > changed version to 24.4.0.alpha22 > tried to run the application using VS Code.
System Info
Windows 11, Vaadin 24.4.0.alpha22, Chrome Version 123.0.6312.123 (Official Build) (64-bit)

Thanks.
Do you have Maven installed in your system? You can try by typing mvn on the command line.
Also, could try if it reproduces with the latest stable Hilla 2.5?

i tried to download an app
open start.vaadin.com
click `start a project`
click `Add the first view to your application`
click `Hilla(React)` -> ‘Hello World’ -> 'Add view'
click `download Project`

unzip the folder
run `mvn`

the version here is alpha24, there is no issue.
downgrade to alpha22, issue with could not navigate to ''
windows machine.

The original project was in a folder named something with space and (parenthesis) like my-app (2), if it matters

my folder is my-app (13) , so i guess that is not the issue.

I happened to run into the same while recording a video, so here are my steps to reproduce.
Not shown in the video: updating vaadin.version to 24.4.0.beta1 and adding pre-release repo to pom.xml.
https://github.com/vaadin/hilla/assets/883698/99f09247-0553-4278-a2c0-d9c27d6ba278

oh, you downloaded the app from start.spring.io, i guess that is probably the reason.
as upgrading from Vaadin 24.3 to 24.4 needs some steps.

@ZheSun88 probably not related, but I got an error with Hilla internal Maven call with a reproducer project you attached to a GH issue; basically the mvnw had windows EOL, and it was unable to run, until I converted them.

aww, i downloaded the app locally and upgraded things based on the video.
using ./mvnw  i got  error in the image..
then i tried to mvn spring-boot:run , app is working..

@marcushellberg can you please set logging.level.com.vaadin.hilla.engine.commandrunner=DEBUG in the application properties and check in the server logs if there is additional information printed by the Hilla command runners?

I tried the same steps and cannot reproduce in my mac, I'm using java 21 but didnt change the java.version in the pom file, and also used the JavaAppliction.java play button for start the application in vscode. Seems some specific local setup

@marcushellberg does it happens always? I mean each time you stop and start the application, or only once at the beginning?

@marcushellberg did you add to the pom the Vaadin pre-releases both as <repository> and <pluginRepository>?

The only way I have managed to reproduce it is by removing the following block from the pom.xml file
   <pluginRepositories>
       <pluginRepository>
           <id>vaadin-prereleases</id>
           <url>https://maven.vaadin.com/vaadin-prereleases</url>
       </pluginRepository>
   </pluginRepositories>

Then the app works, and at some point endpoint generator tries to run mvn -q com.vaadin:vaadin-maven-plugin:generate displaying the following error in console.
com.vaadin.flow.server.ExecutionFailedException: Failed to configure Hilla engine: no runner succeeded. Set log level to debug to see more details.
	at com.vaadin.hilla.internal.AbstractTaskEndpointGenerator.prepareEngineConfiguration(AbstractTaskEndpointGenerator.java:122) ~[hilla-engine-runtime-24.4.0.beta1.jar:na]

Code executing this action is here
So the problem is that hilla cannot run correctly the tasks for generating frontend stuff if the plugin cannot be downloaded.
Note that it only happens with pre-releases, because in the case of releases deployed in maven central, the plugin artifact would be downloaded.
Not sure if there is a way for fixing this, maybe a better message in console, or stoping the servlet container.

So in summary, in both cases the mvn vaadin:configure was not executed correctly @gtzluis logs happen in the same code line, perhaps some problem with mvn in local, and in the case of @marcushellberg perhaps he forgot to add the plugin repository.

It would probably help to have a more descriptive error message when mvn vaadin:configure fails. Let's address the error message in the scope of this ticket.


Global: Make sure all cms driven content matches product doc.

This includes timers, coin amounts, and the civic deck content. We need to double check this is correct and any CMS content is effectively represented 1:1 in the game.

finished this myself


Provide more info for an invalid doc link

Make it more obvious why a documentation reference link is invalid when the URL path incorrectly includes a trailing slash. This would have saved me an hour of debugging when I was working on a change that included a reference like this one:
[`edit:histlist:start`](../ref/edit.html/#edit:histlist:start)

Fixes #1749

This check should be generalized to check for all bogus slashes as well as missing slashes. I have posted a bit more explanation in https://github.com/elves/elvish/issues/1749#issuecomment-1904223636.


Proj4 and custom projections

This PR adds support for Proj4js projections and user-defined projections in 2D and Columbus View.
Since some projections really don't work outside of local areas, this also adds the ability to limit rendered terrain to a rectangle area - different from clipping planes in that using the limiter shouldn't break clipping planes 😉.
This still needs a lot of testing - opening a PR for early feedback on the general approach before going much futher.

Thanks for the pull request @likangning93!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

@likangning93 would it be cleaner to split this into 2 PRs, the first would be just to limit rendering to a specific area, and the second would be the actual projection stuff.

That assumes that everyone else agrees the new limiter is the right way to approach this problem.

proj4.js is pretty huge:

6327 lines (5673 sloc)  169 KB

Is it only loaded when it is used?  Or does get loaded on demand?
Or does it gzip and minify to something so small that we shouldn't care?

@likangning93 I didn't run this and only glanced at the code, but I will go out on a limb and say this is directionally correct and less scary than anticipated.

For Columbus view, are we reprojecting height values at all?  Not all projections are in meters and last time I checked proj4j did not support reprojecting height.  We can probably get away with caveating it, but we need to be very clear/careful here because people will be looking at an incorrect picture.

Currently just leaving height in meters. Maybe in addition to very clear messaging we could add a heightScale parameter? Throw a couple common values into CesiumMath like metersToFeet?

That could work if conversion is always a constant scaling factor.  We could also make it a callback function as part of the projection.  We probably need to do some research and find out how they work.  I know there's a whole world of "veritcal datums" out there that are separate from normals projections.

Interesting tweet that proj may have a JS version soon, superseding proj4js and most likely allowing additional features like vertical datums: https://twitter.com/howardbutler/status/1032622503263444992

Realized that having "projected heights" for terrain could actually be quite complicated, terrain heights on the GPU are actually shared by 3D and 2D/CV mode. Hmmm...

Superseded by #6986 and #6987.

I'm leaving the branch for now so people can play with projections + limiter though.


Make language_version in flutter_tool null safe

Migrate language_version.dart to null safety.

Merging on failing Cirrus tests, see #78678.


Enforce ruff/flake8-implicit-str-concat rules (ISC)

Summary of changes
ISC001 Implicitly concatenated string literals on one line
ISC003 Explicitly concatenated string should be implicitly concatenated
Pull Request Checklist

[ ] Changes have tests
[ ] News fragment added in newsfragments/.
(See documentation for details)

ISC001 definitively as there's no valid reason to ISC on a single line. It just makes the line longer and is likely to accidentally create bugs (which you did catch!)
ISC002 vs ISC003 is more opinionated, so up to the maintainers. Personally I prefer disallowing multiline implicit string concatenation as it helps from a quick read understanding that two lines are not two parameters.
Also here's a feature request to control ISC003 with [lint.flake8-implicit-str-concat] allow-multiline (would be nice if we can just select ISC https://github.com/astral-sh/ruff/issues/11582 )

About ISC003, I tend to agree with the Linux kernel coding style:

2) Breaking long lines and strings
[...]
The preferred limit on the length of a single line is 80 columns.
[...]
However, never break user-visible strings such as printk messages because that breaks the ability to grep for them.

I think it  make sense to unfold user-visible strings, I seem to recall ruff does allow literal strings longer than the admissible line length, up to a larger limit at least.

I've changed this PR to only fix actual bugs uncovered by ISC001.

About ISC003, I tend to agree with the Linux kernel coding style:

We should probably favour ISC002 in setuptools to align with skeleton.

Thank you very much @DimitriPapadopoulos.

About ISC003, I tend to agree with the Linux kernel coding style:

We should probably align with skeleton.

It clearly a bad idea to ignore ISC001. I'll raise an issue over there.

My bad, I am actually the one who (temporarily) ignored ISC001 and ISC002 in skeleton. However, this is only a temporary counter-measure to work around potential Conflicting lint rules. At least the ISC001 rule should be reinstated, when https://github.com/astral-sh/ruff/issues/8272 is addressed.
In the meantime, I think it makes sense to apply ISC001 and ISC002, even if the rules are not yet enabled in the linter configuration.


[move-prover][paper] Adding missing source

Motivation
Add missing source
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
NA

/land

/land

@wrwg :bulb: This PR is already queued for landing

:broken_heart: Test Failed - ci-test

/land


Env file not loading

Description
After running DotNetEnv.Env.Load(); no environment variables are added.
Specifications
I am running EndeavourOS Linux.
My code is running on .NET Core 6.
Code
DotNetEnv.Env.Load();
Console.WriteLine("token: " + Environment.GetEnvironmentVariable("TOKEN"));

...with the output of token:
My .env
Located at root/MyProject/.env, where root is where the solution file is located and MyProject is where the project file is located.
TOKEN=token

You must use the method DotNetEnv.Env.TraversePath().Load();.

The real thing that matters is where the binary (exe) is located relative to the .env file. What Dave said is probably going to help though.

Thank you! This worked perfectly.


Solver documentation is sparse

Describe the Issue
Solver model is too convoluted for ease of understanding, and the documentation doesn't help.
Feature Area
It is hard to leverage the Solver script, and its implementations.

Some of the solvers exhibit too many settings. The tooltips on those are not very helpful and can be more descriptive.
It would be great if the Solver implementations that come with MRTK have separate documentation pages. The number of settings exposed in them can be a little overwhelming and not all settings inherited from SolverBase.cs are applicable to all types it seems.

A little more focus on usage of the scripts rather than intent would be helpful.
Existing Doc Link
https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/README_Solver.html
Additional context
Add any other context about the problem here.

@gejohnst  - I believe you are addressing some of these issues?

Related - https://github.com/microsoft/MixedRealityToolkit-Unity/issues/4675

Assigning to @gejohnst because he's working on some runtime-programmability of solvers and solver documentation.


Depreciate: Remove Python2.7 installation support

Issue #, if available:
#1273
Description of changes:
Removes the ability to install SAM CLI into a Py2 environment.
I want to take this time to also upgrade some of our dev dependencies that were stuck in the stone age and get rid of six. We will need to do similar things in aws_lambda_builders but that will be completely separate than this. If some of the dev dependency upgrades become to much, I will move that to a different PR but for now keeping this as a Draft PR.
Checklist:

[ ] Write Design Document (Do I need to write a design document?)
[ ] Write unit tests
[ ] Write/update functional tests
[ ] Write/update integration tests
[ ] make pr passes
[ ] Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Nice 🔥🔥, next up all of the six stuff, six.moves etc.

Also could you remove: https://github.com/awslabs/aws-sam-cli/blob/develop/samcli/cli/command.py#L27 as well :)

Also could you remove: https://github.com/awslabs/aws-sam-cli/blob/develop/samcli/cli/command.py#L27 as well :)

Good call.


Plex/Tautulli Now Playing doesn't update as new items are played

It appears that the current item metadata doesn't get passed to Plex/Tautulli, the now playing screens only show the first item played. Not sure if there's a good way to correct that!

this is fixed in the latest dev verison. But you have to enable "send play status to plex" in the settings. Some people like it when it doesn't send the status, because this will fill up your plex home with pending videos to finish. But I use a separate user for pseudotv and it is really useful to monitor when it is playing.


archive pages not showing up in sitemap.xml generated by jekyll-sitemap plugin

I'm using archives to generate year, month, day files. This works fine but I noticed that the sitemap.xml that is generated by the jekyll-sitemap plugin doesn't include the generate files.
My _config.yml is as:
gems:
  - jekyll-archives
  - jekyll-sitemap

Can you explain a bit more about why you want the archive pages included in the sitemap?
As long as all of the posts are included, why would you need/want to include pages that only contain links to those posts?

From my understanding of sitemaps you should list all pages on it so crawlers can optimize what to index. I would think having archive pages indexed would be useful as it might provide more content via the titles for searches to hit on your site.

From my understanding of sitemaps you should list all pages on it so crawlers can optimize what to index.

All of my archive pages are noindex, so search engines can just avoid them. Ultimate optimization.

I'm a .Net dev just starting to learn ruby, I'm working on understanding how Jekyll internally works but it looks like the archives plugin would need to be modified to insert entries into site.pages as that's what the sitemap plugin loops through.

it looks like the archives plugin would need to be modified to insert entries into site.pages as that's what the sitemap plugin loops through.

It would not be difficult to include archive pages in the sitemap; I’m just not convinced it would be a Good Idea.
It seems that most users would not want archive pages included in a sitemap, so the feature would probably need to be disabled by default. So we rework two plugins and add a new configuration option for what? What is the use case?
Archive pages have little to no content on their own. As long as the pages they link to are included in the sitemap, we do not need or want archive pages to be included.

Let's ignore the sitemap issue at the moment since this is the archive plugin project after all.
On the Jekyll Variables page it lists that the site.pages is "A list of all Pages". I would think that anyone reading that would understand that to mean that if they look at the contents of the site.pages list they are getting an authoritative list of all pages that Jekyll has created for a site.
As a plugin generating new pages, the correct thing to do it notify the Jekyll engine of the pages it has created. There are other processes, perhaps something Jekyll does or a 3rd party plugins that may want to perform actions on the entirety of pages that have been created.
As a side note the sitemap plugin does not need any changes, and if anyone doesn't want archive pages to be shown in the sitemap then they should just need to add sitemap: false to the archive layout front matter to disable them.

On the Jekyll Variables page it lists that the site.pages is "A list of all Pages".

Yes, but site.pages does not contain all HTML files. A Jekyll Page is a specific type of thing, it does not include static HTML files or documents in a collections.
Some Jekyll sites will list all site.pages in a navigation somewhere on the site, it would be a Very Bad Idea to start including all archive pages in site.pages

if anyone doesn't want archive pages to be shown in the sitemap then they should just need to add sitemap: false to the archive layout front matter to disable them.

Our job is to set defaults that are reasonable for most users, and most users would not want archive pages included in a sitemap. Therefore, jekyll-sitemap would need to be modified to specifically exclude archive pages.

Ok, I did my due diligence but looks like I won't be convincing you. Thanks for the discussion, it was fun.

Thank you :smile:


Realtime event broadcasting through REST calls does not work

Describe the bug
When attempting to send a Realtime broadcast without establishing a Web Socket connection from a backend Node application, using the documented channel.send() method, it returns the string  error without any explanation.
To Reproduce
Steps to reproduce the behavior:

Have a supabase project running locally
Attempt to send a broadcast with the following code

import { createClient } from '@supabase/supabase-js';
import { Env } from '../../config/env';

const supabaseClient = createClient(Env.SUPABASE_URL, Env.SUPABASE_SERVICE_KEY)

supabaseClient.channel('channel1').send({
   event: 'event1',
   type: 'broadcast',
   payload: {
      some: 'data'
   }
}).then(res => { console.log(res)})

You should see the string "error" as a result, and any connected clients listening to that event won't be notified

Expected behavior
I would expect it to work or at least give an informative reason as to why it is not working.
Desktop (please complete the following information):

OS: PopOS (linux) and Windows
Version of CLI 1.127.4
Version of supabase-js 2.39.2
Version of Node.js (if applicable) 20.9.0

Same thing is happening to me. I think it's because the realtime tables are not being created on supabase start
I haven't figured out a solution yet. Just posting here for visibility and support of the issue.
Here are the service versions I'm using locally:


App settings

Manual installation section states that only APPINSIGHTS_INSTRUMENTATIONKEY app setting is needed to setup profiler.
Then later Troubleshooting on-demand profiler section states to check if three app settings are set APPINSIGHTS_INSTRUMENTATIONKEY, APPINSIGHTS_PORTALINFO and APPINSIGHTS_PROFILERFEATURE_VERSION.
This is inconsistent, is APPINSIGHTS_INSTRUMENTATIONKEY setting enough or do we need additional two app settings?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c30bf4fa-902a-c12d-179f-1829c0b967be
Version Independent ID: 6b3c7ae8-f3bb-dc4b-ed5b-a6e2190dacfd
Content: Profile live web apps on Azure with Application Insights Profiler
Content Source: articles/application-insights/app-insights-profiler.md
Service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

@JozoSlejko Thanks for your feedback! We will investigate and update soon on it.

@mrbullwinkle It does appear that we could use a bit more clarification in this section.  In particular, I had difficulty tracking down APPINSIGHTS_PORTALINFO and APPINSIGHTS_PROFILERFEATURE_VERSION with the steps that were provided.

The engineering team that owns profiler did some extensive updates the profiler docs over the past few months with multiple docs covering the various aspects of profiler. The troubleshooting doc is now consistent regarding the manual configuration steps: https://docs.microsoft.com/en-us/azure/application-insights/app-insights-profiler-troubleshooting

@MicrosoftDocs/azure-cxp-triage #please-close

Thanks Michael


Gift entry: Open in batch table throwing component error when allocation widget is present and no allocation is added.

Details and Steps to Reproduce:-

Create a template with Allocation bundle.
Create/open a batch with the same template.
Add a gift in the batch without any allocation. A new row should be added to the table.
Click "Open" in the same row to open the gift from the row in batch gift form.

Expected result:
Form loads with data from row
Actual result:
Component error

**lurch: attach W-039797

Tracking W-039797

Fixed by: https://github.com/SalesforceFoundation/NPSP/pull/5151/commits/a0edf6b93d35a34d592dff2965e23442561574fd


Change Website Theme

Update the website's theme to use a green color contrast as the primary color scheme. This will involve adjusting the color palette of the website to focus on shades of green for backgrounds, text, buttons, and other UI components.
Acceptance Criteria:

Replace the current primary color scheme with shades of green.
Ensure all buttons, links, and interactive elements reflect the new green theme.
Backgrounds and text colors should contrast well with the green theme to maintain readability and accessibility (follow WCAG guidelines).
Update hover states, focus states, and active states of buttons and links to match the new theme.

i have done all the task please review it


Binary for Mac

Hello, thanks for this lovely utility!
I have been using it for some time on my linux machine, however I'm not being forced to use a Macbook for certain work that I need to do and I would love to continue using tshm. Would it be difficult to add an extra step in the CI to build another binary suited for Mac (M1 chip)?

As a first step, does the binary here work for you?: https://github.com/samhh/tshm/releases/tag/0.4.1

@samhh I just did a couple of basic tests with it and it seems to work!


Web version produces different results than Python

For the web version, when I use the following two sequences:
Reference: TTCACTGTTCGGGGCCACTAGCAACAAAGCTTCTGTAAACACTCATGTGCAGGTATTTGTGGACCTGTGTTTTCATTTCCCTTGAGTAAATACCAAGGAATGGAAAAGATGGGTCATATGGTAAGTGTATGTTTAACTTTGTAAGAAACTGCCAAACTGTGTTCCAAAGTGGTGACTGAATTTTCCATTCCCGCCAGGAATGTACGAGAACCACAGTCCTTGCCAACACTTGATGGTCACTCTTTTATC
Sample:
TTCACTGTTCGGGGCCACTAGCAACAAAGCTTCTGTAAACACTCATGTGCAGGTATTTGTGGACCTGTGTTTTCATTTCCCTTGAGTAAATACCAAGGAATGGAAAAGATGGGTCATATGGTAAGTGTATGTTTAACTTTGTAAGAAACTG------TGT-T-CCAAAGTGGTGACTGAATTTTCCATTCCCGCCAGGAATGTACGAGAACCACAGTCCTTGCCAACACTTGATGGTCACTCTTTTATC
The following is received as output:
152_159del, with a deletion of CCAAACTG.
However, when I run the following code in Python:
from extractor import describe_dna
ref = "TTCACTGTTCGGGGCCACTAGCAACAAAGCTTCTGTAAACACTCATGTGCAGGTATTTGTGGACCTGTGTTTTCATTTCCCTTGAGTAAATACCAAGGAATGGAAAAGATGGGTCATATGGTAAGTGTATGTTTAACTTTGTAAGAAACTGCCAAACTGTGTTCCAAAGTGGTGACTGAATTTTCCATTCCCGCCAGGAATGTACGAGAACCACAGTCCTTGCCAACACTTGATGGTCACTCTTTTATC"
sample = "TTCACTGTTCGGGGCCACTAGCAACAAAGCTTCTGTAAACACTCATGTGCAGGTATTTGTGGACCTGTGTTTTCATTTCCCTTGAGTAAATACCAAGGAATGGAAAAGATGGGTCATATGGTAAGTGTATGTTTAACTTTGTAAGAAACTG------TGT-T-CCAAAGTGGTGACTGAATTTTCCATTCCCGCCAGGAATGTACGAGAACCACAGTCCTTGCCAACACTTGATGGTCACTCTTTTATC"
print describe_dna(ref, sample)

I get the following results:
>>> 152_163delins------TGT-T-
which is different from the web version. The web version and the Python version should return the same results, however.

I don't think that the dash character (-) is supported by the description extractor. Possibly these (and other) characters are filtered out by the web server before submitting them to the description extractor. This is supported by the observation that giving the same example as input without the dash characters yields the same answer. Obviously, the filtering does not happens when using the description extractor directly. Here, the dash character is accepted as just another symbol (without any special meaning) resulting in the reported insertion/deletion.
I think that the dash character typically means a "[g]ap of indeterminate length" (IUPAC). As stated before, this is not implemented in the description extractor. Furthermore, one could debate the semantics of consequent dashes in that context.
The filtering of input in a web environment is necessary to guard the integrity of the server; meaning that it will be difficult to guarantee the same behavior within and outside of a web environment.


Fix vuels missing handlers and capabilities

Fixes crash on vls

I have several PRs against core which obviate the need for this fix #13640 #13641 and #13642

Closing in favor of https://github.com/neovim/neovim/pull/13641
Once that is merged, update your nightly and vue will work fine.


Update package to work with current version of NGINX

Agree with @Josephmilla,
Please @PiotrSikora  update this package to work with current version of NGINX.
Thank you!


Binary Ninja (demo) does not detect PE32 file

It seems that binary ninja (current demo version) is unable to detect a (pretty old) 32 bit PE as such.
machines.exe.gz

Fixed in dev: Bit of an odd binary.  The VirtualSegment size is 0 for all segments, so we have to use the "size on disk" instead.  Thanks for the report.

Glad to hear this, thank you


Upstream changes to newline handling in sed/awk/etc.

A recent change in the upstream packages sed, awk etc change the behaviour of how the tools handle newline characters by switching from text mode to binary mode for input.
This is disastrous for Windows as it means $ no longer matches end of line. So all scripts are potentially broken. See https://ghc.haskell.org/trac/ghc/ticket/13315
The proposed solution on the cygwin mailing list of using dos2unix everywhere is non-trivial and requires massive amount of code changes to deal with this.
using text mounts partially solves the problem for files read from disk, but does not fix the issue when piping data. As such, can these patches be reverted for MSYS2? It seems like it's not the desired behaviour we want or expect on Windows.
Testcase:
older MSYS2:
Core@CI-01 MINGW64 ~
$ printf "hello world\r\n234" | sed -e 's/world$/irc/g'
hello irc
234
Core@CI-01 MINGW64 ~
$ printf "hello world\n234" | sed -e 's/world$/irc/g'
hello irc
234

new MSYS2:
Core@CI-02 MINGW64 ~
$ printf "hello world\r\n234" | sed -e 's/world$/irc/g'
hello world
234
Core@CI-02 MINGW64 ~
$ printf "hello world\n234" | sed -e 's/world$/irc/g'
hello irc
234

We had success patching sed back to reading in text mode. It'll be uploaded soon, I hope.

Thanks, I can confirm that this now works again!