Dev Tools

Hi all,
What do you think about adding some dev tools to the repo?

[ ] requirements.txt
[ ] makefile

[ ] test target - to run pytest (and linter too)
[ ] create_environment target - to install development dependencies into virtual env / conda
[ ] build target - to create the python package
[ ]  could call the makefile wrapper from ci

Here is style of Makefile I was thinking about: https://github.com/drivendata/cookiecutter-data-science/blob/master/{{ cookiecutter.repo_name }}/Makefile
Are these ideas too heavy weight?

I think setuptools can do all of this. I don't think a makefile is necessary. But cleaning the setup.py to do all of the above would probably be useful.

I support adding to setuptools, submit a PR if you'd like.

I support adding to setuptools, submit a PR if you'd like.


Routes defaulting to static files

Given a project with the following structure
.
├── pom.xml
├── src
│   ├── main
│   │   ├── java
│   │   │   └── com
│   │   │       └── test
│   │   │           └── demo
│   │   │               ├── App.java
│   │   │               └── service
│   │   │                   └── person
│   │   │                       ├── PersonApi.java
│   │   │                       └── Person.java
│   │   └── resources
│   │       └── public
│   │           ├── index.html
│   │           └── person
│   │               ├── index.html
│   │               └── foo.js

And the following routing:
public static void main(String[] args) {
    var server = Javalin.create(config -> {
        config.addStaticFiles("/public", Location.CLASSPATH);
    }).start(7070);
    server.routes(() -> {
        path("person", () -> {
            // get(???); <- would it be possible to add something here to default to static files?
            post(PersonApi::post);
            get("/{id}", PersonApi::get);
        });
    });
}

I would like accessing https://localhost:7070/person to render the contents of resources/public/person/index.html same that references ./foo.js by <script type="text/javascript" src="./foo.js"></script> which is also expected to work; this given none of those URLs resources matches the declared pathParam. Similarly, accessing https://localhost:7070/person/index.html or https://localhost:7070/person/foo.js should provide those public files.
I was able to (sort of) achieve this by implementing the following try-catch on my PersonApi#get method:
} catch (IllegalArgumentException | ValidationException e) {
    // a bit hacky I know
    var idx = ctx.fullUrl().indexOf("/person");
    ctx.render("public" + ctx.fullUrl().substring(idx)); // ctx is a javalin Context
}

Which works ok for the index.html, yet throws java.lang.IllegalArgumentException: No Renderer registered for extension '.js'. for foo.js, causing frontend functionality not to be available. This without mentioning that in this case the performance concerns me a bit.
I did my homework
The [static-files documentation]](https://javalin.io/documentation#static-files) clearly states:

your own GET endpoints have higher priority

Which is good, yet in this case I want this particular get (when invoked with no pathParams) to default to whatever is found as static content on that path
Can I get some tips on how to achieve this behavior?
Thanks in advance

// get(???); <- would it be possible to add something here to default to static files?
...
this given none of those URLs resources matches the declared pathParam. Similarly, accessing https://localhost:7070/person/index.html or https://localhost:7070/person/foo.js should provide those public files.

No, there is no built in functionality for this. You are asking Javalin to match /person/{id}, which /person/foo.js does. Building an API that either serves a resource or a static file is not recommended.

Can I get some tips on how to achieve this behavior?

I think the simplest way is probably to split out your API and put it on /api. Is that an option?

Yup, thats what I ended up doing, I am guessing this ended up being more a design question then. Closing. Thanks a lot!

Glad you worked it out!


Create difference image if requested

It can sometimes be hard to tell the difference on two images. A simple diff would already help.

Merged on main


preparing server: https://<IP_ADDRESS>:6443/v1-k3s/server-bootstrap: 400 Bad Request

Environmental Info:
K3s Version:

k3s version v1.24.4+k3s1 (c3f830e9)
go version go1.18.1
Node(s) CPU architecture, OS, and Version:

Linux node3 5.4.0-126-generic #142-Ubuntu SMP Fri Aug 26 12:12:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:

1 servers, 1 agents
Describe the bug:

ubuntu@node3:~$ journalctl -xe
-- Support: http://www.ubuntu.com/support
--
-- Automatic restarting of the unit k3s.service has been scheduled, as the result for
-- the configured Restart= setting for the unit.
Sep 21 22:24:10 node3 systemd[1]: Stopped Lightweight Kubernetes.
-- Subject: A stop job for unit k3s.service has finished
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- A stop job for unit k3s.service has finished.
--
-- The job identifier is 9164 and the job result is done.
Sep 21 22:24:10 node3 systemd[1]: Starting Lightweight Kubernetes...
-- Subject: A start job for unit k3s.service has begun execution
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- A start job for unit k3s.service has begun execution.
--
-- The job identifier is 9164.
Sep 21 22:24:10 node3 sh[7077]: + /usr/bin/systemctl is-enabled --quiet nm-cloud-setup.service
Sep 21 22:24:10 node3 sh[7083]: Failed to get unit file state for nm-cloud-setup.service: No such file or directory
Sep 21 22:24:10 node3 k3s[7086]: time="2022-09-21T22:24:10+08:00" level=info msg="Starting k3s v1.24.4+k3s1 (c3f830e9)"
Sep 21 22:24:10 node3 k3s[7086]: time="2022-09-21T22:24:10+08:00" level=info msg="Managed etcd cluster not yet initialized"
Sep 21 22:24:10 node3 k3s[7086]: time="2022-09-21T22:24:10+08:00" level=fatal msg="starting kubernetes: preparing server: https://<IP_ADDRESS>:6443/v1-k3s/server-bootstrap: 400 Bad Request"
Sep 21 22:24:10 node3 systemd[1]: k3s.service: Main process exited, code=exited, status=1/FAILURE
-- Subject: Unit process exited
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- An ExecStart= process belonging to unit k3s.service has exited.
--
-- The process' exit code is 'exited' and its exit status is 1.
Sep 21 22:24:10 node3 systemd[1]: k3s.service: Failed with result 'exit-code'.
-- Subject: Unit failed
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- The unit k3s.service has entered the 'failed' state with result 'exit-code'.
Sep 21 22:24:10 node3 systemd[1]: Failed to start Lightweight Kubernetes.
-- Subject: A start job for unit k3s.service has failed
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- A start job for unit k3s.service has finished with a failure.
--
-- The job identifier is 9164 and the job result is failed.

ubuntu@node3:~$ systemctl status k3s.service
● k3s.service - Lightweight Kubernetes
     Loaded: loaded (/etc/systemd/system/k3s.service; enabled; vendor preset: enabled)
     Active: activating (auto-restart) (Result: exit-code) since Wed 2022-09-21 22:20:31 CST; 2s ago
       Docs: https://k3s.io
    Process: 5882 ExecStartPre=/bin/sh -xc ! /usr/bin/systemctl is-enabled --quiet nm-cloud-setup.service (code=exited, status=0/SUCCESS)
    Process: 5884 ExecStartPre=/sbin/modprobe br_netfilter (code=exited, status=0/SUCCESS)
    Process: 5885 ExecStartPre=/sbin/modprobe overlay (code=exited, status=0/SUCCESS)
    Process: 5886 ExecStart=/usr/local/bin/k3s server --docker --write-kubeconfig-mode 644 --server https://<IP_ADDRESS>:6443 --token K1084ed8b167fcf3692bd68a77f4bae76c183abcdf8a988e485fb3eff25557>
   Main PID: 5886 (code=exited, status=1/FAILURE)

Sep 21 22:20:31 node3 systemd[1]: k3s.service: Main process exited, code=exited, status=1/FAILURE
Sep 21 22:20:31 node3 systemd[1]: k3s.service: Failed with result 'exit-code'.
Sep 21 22:20:31 node3 systemd[1]: Failed to start Lightweight Kubernetes.

Steps To Reproduce:

Installed K3s:
server

curl -sfL https://get.k3s.io | sh -s - --docker --write-kubeconfig-mode 644 --tls-san <IP_ADDRESS>

agent

curl -sfL https://get.k3s.io | sh -s - --docker --write-kubeconfig-mode 644 --server https://<IP_ADDRESS>:6443 --token K1084ed8b167fcf3692bd68a77f4bae76c183abcdf8a988e485fb3eff25557747fc::server:3c12d2f91211fd816914841df6a8ceeb

how can i do with the error
Expected behavior:

Actual behavior:

Additional context / logs:

What are you trying to do here? Do you currently have one server and one agent, and are trying to add another server? It's unclear what is going on. It looks like node3 has never been a member of the cluster, and you're trying to add it? What do the logs on the existing server say? Are you sure that you started the first server with embedded etcd, and not sqlite, which does not support adding additional servers?

e..,i success with environment variable
i exec bash in agent,it is success
curl -sfL https://get.k3s.io | K3S_URL=https://<IP_ADDRESS>:6443 K3S_TOKEN=K10e56d7119146b9eaefdfaad96d05dfef146622c606ff6f9a564a3906816b3b34d::server:98e6a2ce32dc3a9c06eb12ce8e4b9fd7 sh -

but i exec this code it is fail preparing server: https://<IP_ADDRESS>:6443/v1-k3s/server-bootstrap: 400 Bad Request
curl -sfL https://get.k3s.io | sh -s - --write-kubeconfig-mode 644 --server https://<IP_ADDRESS>:6443 --token K10e56d7119146b9eaefdfaad96d05dfef146622c606ff6f9a564a3906816b3b34d::server:98e6a2ce32dc3a9c06eb12ce8e4b9fd7


XML parsing crash

I noticed lots of recent updates to the XML parsing, so I re-tried my config, and it still crashes the parser.
Downloaded config file attached.
<IP_ADDRESS>_config.txt

Just saw another XML parsing update, still crashes:
Exception has occurred: AttributeError
'NoneType' object has no attribute 'text'
  File "C:\Users\piete\source\repos\gjbadros\pyvantage\pyvantage\__init__.py", line 836, in _parse_load_group
    out_name = output_xml.find('DName').text
  File "C:\Users\piete\source\repos\gjbadros\pyvantage\pyvantage\__init__.py", line 501, in parse
    lgroup = self._parse_load_group(lg_xml)
  File "C:\Users\piete\source\repos\gjbadros\pyvantage\pyvantage\__init__.py", line 1402, in do_parse
    parser.parse()
  File "C:\Users\piete\source\repos\gjbadros\pyvantage\pyvantage\__init__.py", line 1397, in load_xml_db
    self.do_parse(xml_db)
  File "C:\Users\piete\source\repos\gjbadros\pyvantage\test.py", line 156, in main
    v.load_xml_db(not args.use_cache)
  File "C:\Users\piete\source\repos\gjbadros\pyvantage\test.py", line 186, in <module>
    main()
AttributeError: 'NoneType' object has no attribute 'text'

I've not tried the diff, but maybe have a look at this?

I'm looking at this today, too -- and incorporating some of that @benj-j-h fix into the master of this repo --thanks!

Tested with the changes, XML load no crashes, thank you.
New verifying correct parsing, based on logs it seems that the group logic is unhappy:
        for v in load_vids:
            load = self._vantage._vid_to_load.get(v)
            if not load:
                _LOGGER.warning("LoadGroup %s has unknown load vid %d", self, v)
            if load and load._is_dimmable:
                self._is_dimmable = True
                break

WARNING:pyvantage:LoadGroup Output name: 'Downstairs-Kitchen-Kitchen Lights' area: 67 type: 'GROUP' load: 'GROUP' id: 501 (ctemp)  ([96, 100, 103, 98, 102]) (c:[]) (b:None) [['1426 3rd Street', 'Downstairs', 'Kitchen', 'Downstairs-Kitchen-Kitchen Lights']] has unknown load vid 96
WARNING:pyvantage:LoadGroup Output name: 'Downstairs-Kitchen-Kitchen Lights' area: 67 type: 'GROUP' load: 'GROUP' id: 501 (ctemp)  ([96, 100, 103, 98, 102]) (c:[]) (b:None) [['1426 3rd Street', 'Downstairs', 'Kitchen', 'Downstairs-Kitchen-Kitchen Lights']] has unknown load vid 100
WARNING:pyvantage:LoadGroup Output name: 'Downstairs-Kitchen-Kitchen Lights' area: 67 type: 'GROUP' load: 'GROUP' id: 501 (ctemp)  ([96, 100, 103, 98, 102]) (c:[]) (b:None) [['1426 3rd Street', 'Downstairs', 'Kitchen', 'Downstairs-Kitchen-Kitchen Lights']] has unknown load vid 103
WARNING:pyvantage:LoadGroup Output name: 'Downstairs-Kitchen-Kitchen Lights' area: 67 type: 'GROUP' load: 'GROUP' id: 501 (ctemp)  ([96, 100, 103, 98, 102]) (c:[]) (b:None) [['1426 3rd Street', 'Downstairs', 'Kitchen', 'Downstairs-Kitchen-Kitchen Lights']] has unknown load vid 98
WARNING:pyvantage:LoadGroup Output name: 'Downstairs-Kitchen-Kitchen Lights' area: 67 type: 'GROUP' load: 'GROUP' id: 501 (ctemp)  ([96, 100, 103, 98, 102]) (c:[]) (b:None) [['1426 3rd Street', 'Downstairs', 'Kitchen', 'Downstairs-Kitchen-Kitchen Lights']] has unknown load vid 102
DEBUG:pyvantage:load group = Output name: 'Downstairs-Kitchen-Kitchen Lights' area: 67 type: 'GROUP' load: 'GROUP' id: 501 (ctemp)  ([96, 100, 103, 98, 102]) (c:[]) (b:None) [['1426 3rd Street', 'Downstairs', 'Kitchen', 'Downstairs-Kitchen-Kitchen Lights']]

Investigating the unknown load;
vid 96: DEBUG:pyvantage:Output = Output name: 'Downstairs-Kitchen-Kitchen Around Island Cans' area: 67 type: 'LIGHT' load: 'Fluor. Electronic non-Dim' vid: 96 @ 0.0  [['1426 3rd Street', 'Downstairs', 'Kitchen', 'Downstairs-Kitchen-Kitchen Around Island Cans']]
vid 100: DEBUG:pyvantage:Output = Output name: 'Downstairs-Kitchen-Kitchen Cabinet Strips' area: 67 type: 'LIGHT' load: 'Magnetic Low Voltage' vid: 100 @ 0.0 (dim)  [['1426 3rd Street', 'Downstairs', 'Kitchen', 'Downstairs-Kitchen-Kitchen Cabinet Strips']]
So the unknown load vid's do exist?

For a quick test I changed all Oblect/ to Object//`, same behavior.
I did some debugging, and load = self._vantage._vid_to_load.get(v) and _vid_to_load is always empty.
If you have time use the config file I uploaded in the first comment.

It's actually a new warning that shouldn't really matter, but I do think I
see the problem.  Will fix this week, but I don't think it should impact
using the module significantly (it just means loadgroups won't be dimmable
even if one of the loads in the loadgroup is dimmable).
Is it causing problems?
On Mon, Apr 24, 2023 at 8:06 AM Pieter Viljoen @.***>
wrote:

For a quick test I changed all Oblect/ to Object//`, same behavior.
I did some debugging, and load = self._vantage._vid_to_load.get(v) and
_vid_to_load is always empty.
If you have time use the config file I uploaded in the first comment.
—
Reply to this email directly, view it on GitHub
https://github.com/gjbadros/pyvantage/issues/16#issuecomment-1520356553,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALOHTL7URH2PG5UO532MNLXC2JJBANCNFSM6AAAAAAXIUYRRY
.
You are receiving this because you commented.Message ID:
@.***>

Is it causing problems?

Not at the point where I'm testing with HA yet, XML load crashing had always been a blocker :)
The error just did not make sense as the VID does exist but the logic fails to find it.

Tested ok, no more not found.
Now looking at repeated name warnings:
        if obj.name in self._names:
            oldname = obj.name
            obj.name += f" ({obj.vid})"
            if ('0-10V RELAYS' in oldname or
                'NOT USED' in oldname or cmd_type == 'BTN'):
                pass
            else:
                _LOGGER.debug(f"Repeated name `{oldname}' - adding vid to get {obj.name}")
        self._names[obj.name] = obj.vid

E.g. for all my SDM12's the sensors have the same name, does the logic rely on names being unique?
Maybe I should just ignore this given the comments in the code # TODO: this may be a little too hacky and # TODO: cleanup this awful logic :)

The code automatically adds the vid to differentiate the name if it finds
overlapping names -- this is just a UX issue which you can fix by renaming
the objects with the same name.
On Mon, Apr 24, 2023 at 11:51 AM Pieter Viljoen @.***>
wrote:

Tested ok, no more not found.
Now looking at repeated name warnings:
    if obj.name in self._names:
        oldname = obj.name
        obj.name += f" ({obj.vid})"
        if ('0-10V RELAYS' in oldname or
            'NOT USED' in oldname or cmd_type == 'BTN'):
            pass
        else:
            _LOGGER.debug(f"Repeated name `{oldname}' - adding vid to get {obj.name}")
    self._names[obj.name] = obj.vid

E.g. for all my SDM12's the sensors have the same name, does the logic
rely on names being unique?
Maybe I should just ignore this given the comments in the code # TODO:
this may be a little too hacky and # TODO: cleanup this awful logic :)
—
Reply to this email directly, view it on GitHub
https://github.com/gjbadros/pyvantage/issues/16#issuecomment-1520661666,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALOHTO73QDONZ6IRUN76H3XC3DSPANCNFSM6AAAAAAXIUYRRY
.
You are receiving this because you commented.Message ID:
@.***>

Got it, closing as no more crash, thank you, I'll move on to trying HA integration again.

Make sure you get the latest hass-vantage version that has the stated
dependency on the new release of pyvantage I put up on PyPi
On Mon, Apr 24, 2023 at 11:57 AM Pieter Viljoen @.***>
wrote:

Closed #16 https://github.com/gjbadros/pyvantage/issues/16 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/gjbadros/pyvantage/issues/16#event-9084808518, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AALOHTLC4U5IEKNDEKXRPDLXC3EH3ANCNFSM6AAAAAAXIUYRRY
.
You are receiving this because you commented.Message ID:
@.***>


Transition to Font Awesome social icons

Replace mono social icons with font awesome social icons for better icons and IE/Edge compatibility.

Or Iconic


Publish algorithm

Didn't test the publish flow for algorithms. This needs to be validated/fixed
This is dependent on this pr ; https://github.com/oceanprotocol/market/pull/967
Done:

you can properly publish an algorithm and is accurately indexed by Aquarius

Please add your planning poker estimate with ZenHub @bogdanfazakas

Everything regarding publish testing we should hold off until we stop deploying new contracts. Every time we deploy, the old published assets become useless, and we would have to test all possibilities again. All the changes of the last days are not yet deployed I think https://github.com/oceanprotocol/contracts/commits/v4main_postaudit


Recipes Issues

Pack version: 2.0.0 beta 2
I noticed that a lot of items have "double recipes" (the default recipe and the craftweaker one), some of them are: IE engineering blocks, generator and radiator blocks, IE blast bricks (i thought they were not implemented), and improved blast bricks, modularium, machine frames from various mods, blood altar and ME controller.
Other blocks from Tinker i/o like the ore crusher, have been implemented and I thought they were not.
And lastly, the translocators have only the normal recipe.
I know it's a beta, so it may have a few missing pieces, but I think that feedback could be appreciated.

Yep, that's caused by an unfortunately simple oversight.
You can fix it yourself by opening Non Mod Scripts\add-recipes-temp.zs and search for addMirrored, then change it to addShapedMirrored.


chansrv: avoid chansrv SEGV when xinode is NULL

When xfuse_create_file_in_xrdp_fs is failed, it returns NULL.
Without this fix, xinode->size causes SEGV, so implementation is changed
to return -1 and check the return value in caller.

+1

+1
From: jsorg71<EMAIL_ADDRESS>Sent: Thursday, July 21, 2016 7:51 PM
To: neutrinolabs/xrdp<EMAIL_ADDRESS>Subject: Re: [neutrinolabs/xrdp] chansrv: avoid chansrv SEGV when xinode is NULL (#403)
+1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/neutrinolabs/xrdp/pull/403#issuecomment-234314478 , or mute the thread https://github.com/notifications/unsubscribe-auth/ADTH1LySmo3NNiCiePV8DfedyZh4ry-lks5qX6OQgaJpZM4JRhQx .  https://github.com/notifications/beacon/ADTH1IIeM0ZC9Zj14Iv6v_3cksYvflLJks5qX6OQgaJpZM4JRhQx.gif


Use ARG for optional services during docker build

Since docker 1.9, it's possible to use ARG Dockerfile instrunction to define build time variables.
This could be used as the solution implemented in PR-#182
I can work on a PR it's the maintainer interest.

Sorry for the late response, I haven't had time until now to look after Baseimage-docker. Yes your proposed change would be welcome.

The PR has been merged years ago.
BTW, we should go back to simply using 0 and 1 as it doesn't actually work.


Support array columns types

Hello,
First, thanks for your really useful package !
I would like to add a field with the type integer[] (array of integer) but the type doesn't seems to exist in the columns types supported, I'm missing something ?
Thanks in advance,
Max

Yeah, that's the problem. I need to build doctrine types for everything. For now, you can do the domain(...) trick but you may got problems with some stuff.
I may be able to work on it sometime in the next 2 weeks. I'll need that by myself currently.

It's a doctrine issue, I will try to create an issue on doctrine repo.
vendor/doctrine/dbal/src/Platforms/PostgreSQLPlatform.php
    protected function initializeDoctrineTypeMappings()
    {
        $this->doctrineTypeMapping = [
            'bigint'           => 'bigint',
            'bigserial'        => 'bigint',
            'bool'             => 'boolean',
            'boolean'          => 'boolean',
            'bpchar'           => 'string',
            'bytea'            => 'blob',
            'char'             => 'string',
            'date'             => 'date',
            'datetime'         => 'datetime',
            'decimal'          => 'decimal',
            'double'           => 'float',
            'double precision' => 'float',
            'float'            => 'float',
            'float4'           => 'float',
            'float8'           => 'float',
            'inet'             => 'string',
            'int'              => 'integer',
            'int2'             => 'smallint',
            'int4'             => 'integer',
            'int8'             => 'bigint',
            'integer'          => 'integer',
            'interval'         => 'string',
            'json'             => 'json',
            'jsonb'            => 'json',
            'money'            => 'decimal',
            'numeric'          => 'decimal',
            'serial'           => 'integer',
            'serial4'          => 'integer',
            'serial8'          => 'bigint',
            'real'             => 'float',
            'smallint'         => 'smallint',
            'text'             => 'text',
            'time'             => 'time',
            'timestamp'        => 'datetime',
            'timestamptz'      => 'datetimetz',
            'timetz'           => 'time',
            'tsvector'         => 'text',
            'uuid'             => 'guid',
            'varchar'          => 'string',
            'year'             => 'date',
            '_varchar'         => 'string',
            // new line =>
            '_int4'            => 'string',
        ];
    }

With that patch integer[] are working fine. It's seem that they already fix it for varchar array apparently.

For the encode/decode we can inspire from Yii implementation for example :

https://github.com/yiisoft/yii2/blob/master/framework/db/pgsql/ArrayParser.php
https://github.com/yiisoft/yii2/blob/master/framework/db/pgsql/ArrayExpressionBuilder.php)

The integer array type is now supported with 0.31.0. There is additionally a cast for easier usage and a whereIntegerArrayMatches query builder function to use all of the potentials of this marvelous data type.


Replaces usage of reimburserEmail with achAccount.reimburser

~HOLD on https://github.com/Expensify/App/pull/38395~
~HOLD on https://github.com/Expensify/Auth/pull/10349~
Details

cc: @luacmartins if you have the time to check this changes
Fixed Issues

https://github.com/Expensify/Expensify/issues/374749
PROPOSAL:
Tests

Preconditions: Having a policy with VBA and some admins
Happy path:

Open Settings > Workspaces >  > Workflows
See that you have an authorized payer
Click on the authorized payer and change it to a different one
Now, change it to one that has a display name set and check that the display name is shown under authorized payer

Error

Open Settings > Workspaces >  > Workflows
See that you have an authorized payer
Go offline and change the authorized payer
In a different tab/browser demote the authorized payer from step 3 to a member
Go back to the offline tab and get back online, the authorized payer should get reverted to the previous one and there should be a red dot next to it indicating that it could not update

[x] Verify that no errors appear in the JS console

Offline tests

Open Settings > Workspaces >  > Workflows
See that you have an authorized payer
Go offline
Click on the authorized payer and change it to a different one
Go back online and see that it got updated

QA Steps

Preconditions: Having a policy with VBA and some admins
Happy path:

Open Settings > Workspaces >  > Workflows
See that you have an authorized payer
Click on the authorized payer and change it to a different one
Now, change it to one that has a display name set and check that the display name is shown under authorized payer

Error

Open Settings > Workspaces >  > Workflows
See that you have an authorized payer
Go offline and change the authorized payer
In a different tab/browser demote the authorized payer from step 3 to a member
Go back to the offline tab and get back online, the authorized payer should get reverted to the previous one and there should be a red dot next to it indicating that it could not update

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Error
https://github.com/Expensify/App/assets/5201282/f853484f-6a49-46f6-b211-e43dadac6011
Online
https://github.com/Expensify/App/assets/5201282/aa8fe240-bb0b-4b0e-abde-d1dfc696265d
Offline
https://github.com/Expensify/App/assets/5201282/18dbd53d-b48e-4104-a486-2ff6623d723c

MacOS: Desktop

Are we already sending the new reimburser key to App? If not, can we put a hold on this PR?

We are, we started doing that here

Cool, seems like that Auth PR is merged so we should be good to merge this one too.

Created this external issue to get C+ assigned for review

Can you please merge main? I'm stuck at the update prompt

@s77rt merged main and applied the requested changes

The other admin account appears as Hidden (don't have their email) thus I can't set them as the authorized payer
https://github.com/Expensify/App/assets/16493223/b1a554dd-cb96-4096-a3ee-1f6ded4e4ae1

This is weird, does the same happen if you open the members page?

I had to send a message to other admin to get their info correctly

This is weird, does the same happen if you open the members page?

I didn't. get a chance to test that as now I already got the info

On demoting the other admin I got another behaviour but I think it's okay
https://github.com/Expensify/App/assets/16493223/343c5264-e1e7-44c7-a270-a7be3b33c4ad

Did you demote the admin that was making the changes? If so yeah, I think that is expected

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Basic networking support for service endpoints

According to our tests it is possible to use service endpoints with a cluster that is using basic networking. Is this scenario not supported - even though it works? If not can we update the docs to say that service endpoints work with basic networking?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9615c579-305d-2482-7eaf-2d120c75e8d5
Version Independent ID: 064f4a10-bd74-f554-9550-781dd3e838cb
Content: Concepts - Networking in Azure Kubernetes Services (AKS)
Content Source: articles/aks/concepts-network.md
Service: container-service
GitHub Login: @iainfoulds
Microsoft Alias: iainfou

Thanks for the feedback! We are currently investigating and will update you shortly.

@denniszielke I have assigned the issue to the content author to investigate further and update the document as appropriate.

@aanandr Can you address the supportability of this, please?
@MicahMcKittrick-MSFT Please reassign to @aanandr. This is not a docs question.

is there any clarity here? The fact that the docs say service endpoints work with Azure CNI implies that it doesn't with kubenet,
i have any environment where connections to SQL db were not successful with kubenet and service endpoints. it would be great for someone to clarify the exact support here

If you create your own virtual network and subnet and use kubenet, you can use service endpoints in a supported manner.
If you use the default kubenet behavior where the virtual network and subnet are created for you as part of the AKS cluster create process, it is not supported to use service endpoints. As the virtual network subnet is part of the MC_ resource group managed by the AKS cluster, manually configuring the additional subnet parameters for service endpoints puts you out of support - https://docs.microsoft.com/en-us/azure/aks/faq#can-i-modify-tags-and-other-properties-of-the-aks-resources-in-the-mc_-resource-group
There's a doc update already lined up to clarify that service endpoints can only be used with kubenet when you specify and manage the virtual network resource.
#please-close


Dockerfile: build with the RADOS driver

As mentioned here. Please merge this PR only after #578.

LGTM

LGTM!


Sharing is Caring Power App Sample - D365 Goddess

Category

[x] New Sample

What's in this Pull Request?
Power Apps Calendar Component

Thank you @d365goddess  ! Living up to your username!!!


[Bug]: update ansi-regex for CVE-2021-3807

Version
27.2.1
Steps to reproduce
Check open source vulnerabilities...
Expected behavior
No CVEs :-)
Actual behavior
CVE-2021-3807 is listed for ansi-regex@^5, which is linked by jest pretty-format: ansi-regex is vulnerable to Inefficient Regular Expression Complexity.
Additional context
Upgrading to<EMAIL_ADDRESS>would clear the alert.
Forcing the upgrade via resolutions is not a work-around; jest won't load.
However, it's unclear to me why we get CVEs for "regular expression complexity".
Environment
System:
    OS: macOS 11.5.2
    CPU: (8) x64 Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz
  Binaries:
    Node: 12.22.5 - ~/n/bin/node
    Yarn: 1.22.5 - ~/.yarn/bin/yarn
    npm: 6.14.14 - ~/n/bin/npm
  npmPackages:
    jest: ^27.2.1 => 27.2.1

CVE-2021-3807 is outdated. You can use<EMAIL_ADDRESS>which will work with the current version of Jest.
https://github.com/chalk/ansi-regex/releases/tag/v5.0.1

Thank you! I didn't know that v5.0.1 back-ports the fix.


Feature request: Export / Save options png & svg

Hi all,
I love this library, not just the functionalities but also the standard look & feel. For me, this means that I'd love to be able to export react-flow visuals (preferably as SVG's) for use in presentations and documents. And I also see a big use-case here for the computer science world where they currently use a lot of Graphviz, it'd be great if this could be a lib that we can use both for interactive demos as well as for reports and papers.

Would love to see this as well!

Hey @Luttik
this is a great idea but React Flow contains DOM and SVG nodes. This makes it relatively hard to render it as a SVG (we have inputs and selects in our nodes for examples). In order to render a flow as a png we would need to have a server side puppeteer instance or something like that or try to use html2canvas. However this is not a feature I would like to add to React Flow. A separate package for exporting flows would be nice!

@moklick is there any other lib for exporting the flow as a png as you said ?

I've created a "Download Image" example that uses html-to-image.


[bug] Fix codgen bug where port number was ignored

*Issue #196 *
Description of changes:
This change passes through the port from the parsed endpoint uri when creating a URI object. Prior to this change the port field of the URI was always None which in turn uses the default port for the protocol which is an issue as pointed out in #196.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fe759d9) 94.64% compared to head (6b1eec2) 94.64%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #197   +/-   ##
========================================
  Coverage    94.64%   94.64%
========================================
  Files           35       35
  Lines         1682     1682
========================================
  Hits          1592     1592
  Misses          90       90

Flag
Coverage Δ

unittests
94.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(web-spring): Add PercentileTimer

@brharrington

Is there any easy way I can identify a PercentileTimer?
For example in Spinnaker I am seeing things like this:
A DefaultCounter named "redis.command.latency.del"
with among other tags "statistic" with the values {"count", "totalTime", "percentile"}
and when statistic="percentile" then there is a "percentile" tag with values like T004F.
I assume this is supposed to be a PercentileTimer, but PercentileTimer is a final class, not an interface so I'm not sure what's going on. Maybe this isnt a literal PercentileTimer, but I think it is behaving like one so would like to identify the series as such.

PercentileTimer is an extension pattern, the registry doesn't know anything about it specifically. The pattern creates a basic timer and a set of counters that are used to model the data distribution and then compute percentile estimates at query time. I'll take a closer look at this tomorrow.

I dont necessarily need anything changed. I'm just looking to explain why I dont get what I expected to. On my consumption end I look for and interpret the statistic tag pattern to identify Counters that are really PercentileTimers. It seems the meter itself would know this so could do so efficiently. Otherwise I dont want to add unnecessary overhead in the runtime since the consumption is essentially offline so efficiency isnt important (but would like to simplify and reduce complexity).
Also, can I rely on the interfaces to determine the types? Or maybe even the classes themselves since they are final (assuming the default registry)? It used to be that I was seeing some internal implementation classes in practice (using the default registry) but that no longer appears to be the case. I dont know if that's something I can rely on or not so I'm keeping the extra code around for future safety. If it is unnecessary, I'll cut it while I'm here.

I'm just looking to explain why I dont get what I expected to. On my consumption end I look for and interpret the statistic tag pattern to identify Counters that are really PercentileTimers. It seems the meter itself would know this so could do so efficiently.

PercentileTimer/PercentileDistributionSummary are not core types in the registry. They are patterns built on top of the registry that generate a set of core meters. In the case of PercentileTimer, it will create a Timer and a set of Counters that are used to model the data distribution. So you will not see the PercentileTimer type when querying the registry.

Also, can I rely on the interfaces to determine the types?

For core types, yes you should be able to rely on the interface. Specific implementations of those cannot be relied on as those can change depending on the registry being used.


[Microsoft Generator CSharp] Remove SourceInputModel._existingCompilation property

Remove SourceInputModel._existingCompilation property as it is a duplicate of the Customization and PreviousContract properties in this class.
Please refer this for more details.

The goal here is to have one object representing the previous contract and one object representing the cusotmizations.  We want to use those to not emit things that would have been removed by the current prost processing thereby getting a perf boost.


Downgrade error to warning when retrying because of message too large

Summary of the Pull Request
What is this about?
PR Checklist

[ ] Applies to work item: #xxx
[ ] CLA signed. If not, go over here and sign the CLI.
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?

Codecov Report

Merging #3224 (c4ca645) into main (db1e489) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #3224   +/-   ##
=======================================
  Coverage   29.54%   29.55%
=======================================
  Files         332      332
  Lines       39197    39199    +2
=======================================
+ Hits        11581    11584    +3
+ Misses      27616    27615    -1

Impacted Files
Coverage Δ

src/ApiService/ApiService/onefuzzlib/Queue.cs
40.33% <66.66%> (+1.01%)
:arrow_up:

... and 1 file with indirect coverage changes


Smaller Backbone Models

Hi Tim Meinhardt thanks for the great work!
I'm trying to adapt trackformer in my own research, however I don't have enough GPU memory. Do you have private mode models with smaller backbones(resnet18/34) pretrained on coco/crowdedhuman detection task or scripts for coco detection pretraining? Thanks!

I am sorry but we never trained smaller models than the provided ResNet50.

Af downloading and unpacking the COCO dataset into the data directory you should be able to train a model on COCO detection by running something like this:
python src/train.py with \
    deformable \
    backbone=resnet18 \
    output_dir=models/coco_resnet18

But this is not tested so make yourself familiar with the codebase to understand the configuration parameters in cfgs/train.yaml.

Great! Thanks a lot!


Replace tinyfiledialogs with a native rust crate

The main motivation for this is to make cross-compilation for ARM Macs much easier. A candidate for this would be the rfd crate.

I don't know if it helps, but in tinyfiledialogs v3.13.3 I have added the AppleSilicon dylib file (previously it was only Intel)

I don't know if it helps, but in tinyfiledialogs v3.13.3 I have added the AppleSilicon dylib file (previously it was only Intel)

I don't know if it helps, but in tinyfiledialogs v3.13.3 I have added the AppleSilicon dylib file (previously it was only Intel)

Thanks for letting me know. I think I will check what the "official" recommendation for file dialogs in iced is, as soon as there is some info about it.


lib/blob/cluster: fix dropped test errors in RCPSuite.SetUpTest()

This picks up two dropped test errors in lib/blob/cluster.

@alrs Good catch 👍 Thank you for your contribution!


Consider making legal/repoOwner mandatory

As of now, it/riuso/codiceIPA is specified to be mandatory only if legal/repoOwner is a Public Administration. However legal/repoOwner is an optional key, so this creates ambiguity.
We should consider either making legal/repoOwner mandatory or changing the specification for it/riuso/codiceIPA so that it does not mention legal/repoOwner.

I completely agree on this.
Question: which is the case where the repoOwner is unknown? I find it difficult to clearly see it.
If we find no objections, I would try to merge this in 0.3. @alranel
Furthermore, this simplifies the rendering of the catalog, avoid misunderstandings.

As highlighted by @libremente, what about cases when this is unknown or spread out over a community?


updated contributing.md

As this is the doc that is showed while creating a pull request, updated it with information from release principles wiki.

LGTM

LGTM


Access to $db property from Mapper

Is there some way (method) to access the protected $db property from Mapper class? Sometimes I need to build and execute "handmade" queries ( using Db::query('...') ).

You can extend.
<?php

use Respect\Relational\Mapper;

class MyMapper extends Mapper {
    public function getDb() {
        return $this->db;
    }
}

Or you can send a pull request with getDb() method.


Add stance detection model

Add stance detection model to the resources list

Please, check if it is structured as expected, @FelSiq


lolicon in fortran

I realized I haven't ported this to any other languages in a while so...

@sr229 plz merge aaaa


Docs/redux logger

@SethDavenport are you making any other changes that you plan for me to review?

not right now, no


Can't add face/use test command

I've downloaded and installed howdy today and everything seems to have gone well except the fact that I can't add my face. Every time I try to do this (in a well-lit environment or in a dark environment) it tells me that it couldn't detect a face. (No face detected, aborting). When I use the sudo howdy test command I get this:
sudo howdy test
Opening a window with a test feed
Press ctrl+C in this terminal to quit
Click on the image to enable or disable slow mode
QObject::moveToThread: Current thread (0x8f84cc0) is not the object's thread (0x9115b90).
Cannot move to target thread (0x8f84cc0)
Segmentation fault
I am running Kubuntu (together with Windows 10) on my Lenovo Thinkpad P52.
The howdy version I have is 2.3.1.

Looks like a duplicate of #54


build: upgrade development dependencies

Upgrade following development dependencies:

serverless-offline v8.x.x
strip-ansi v7.x.x

This is failing CI because serverless v2 internals relied on by the test suite have changed (affects the tests, but not should affect typical usage of lalalambda).  If you're interested to dig into it, feel free!  Otherwise I will try to fix it up when some times allows.  Thanks for the contribution!


Log what node environment the bot is in in the ready event

https://github.com/acollierr17/discord.js-template/commit/556a3a241c0826fb9fb2a554130e9b9c768d8639


Incorrect Title on Third Level Page after changing name in menu and video gallery

Steps to Reproduce
(List or Description)
Expected Behavior
An author wanted to change the name of video gallery from "lecture notes" to "lecture videos". They made changes to the left nav menu, the title of the video gallery, and the learning resource types history. But, the title "lecture notes" still appears at the top of each individual video page, e.g., here.
Actual Behavior
The titles on each video page should be what a user sees in the left nav menu. @pdpinch Fact check me here. For complicated courses, i.e., scholar, or third level pages, are we expecting the left nav menu to be the title at the top of each video page?
Screenshot or Screencast

This course has been unpublished. No one else has reported this issue, so I'm assuming it was fixed in the last round of theme updates.


Allow running on windows

Relates to #491. This is a very simple PR that allows this projecto run on Windows. Let's keep it as draft until I am able to test it on my project. One thing to notice is that this completely ignores signals so we should probably document that somewhere.

Successful PR Checklist:

[ ] Tests

[x] Not needed

[ ] Documentation

[ ] Where should we document this?

PR label(s):

[ ] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A breaking 💥
[ ] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A feature ⭐
[ ] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A bugfix 🕵
[x] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A miscellaneous 👾
[ ] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A dependencies 🤖
[ ] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A documentation 📚

Where should we document this?

I'd suggest a "how-to" page for "how to run procrastinate under Windows" ?

Hello @ewjoachim thank you for your kind words! I'm gonna keep it as a draft for a little more to make some more tests on my project and then I'll convert it to normal PR.
I don't have anything more for this PR but If you think that we can change/add anything please tell me.

Hello friends, I'm happy to report that I wasn't able to find any other problems with Windows and everything seems to be working great on my project so I'll change the to a normal PR.

It's entirely my fault, but the doc is now missing a newline to separate the bullet list from the last paragraph, see here: https://procrastinate--1236.org.readthedocs.build/en/1236/howto/basics/windows.html
Can you fix this ?

Perfect (yeah, sorry I forgot to follow-up too, otherwise I'd have done it)
Congratz with your PR !


May I get the trained LoRA lib to reproduce the paper:Modular LLM?

Hi Team！
I came across your excellent work on Modular LLM and would like to build upon it. Could you please provide the trained LoRA library used in your research to help me reproduce the results?
Thank you!

Hi Team,
Thank you so much for you help!
I truly appreciate your support!
Best regards,
Wei_fan

@shuishen112 thanks! closing the issue :)


Add Coralogix to OpenSearchCon NA 24 Exhibitors Page

Please add our partner, Coralogix, to the OpenSearchCon NA 24 exhibitors page here: https://opensearch.org/events/opensearchcon/2024/north-america/exhibitors/index.html
@kaimmej


Changed symfony/debug version from v2.3.0-BETA2 to v2.3.0 since BETA2 is...

... no longer available.
When I tried doing composer install, it failed until I made this change.

Thanks!


Add externs for DOM4's remove

This issue was imported from Closure Compiler's previous home at http://closure-compiler.googlecode.com
The original discussion is archived at:
http://blickly.github.io/closure-compiler-issues/#896

Duplicate of https://github.com/google/closure-compiler/issues/914


Footer revisited

New footer that stay on bottom of page, not covering body content of block.
Edited mechanic viewport to determine height, because contains only elements with absolute position.

this change makes footer stick to the top of the content. It should be adjusted to the page size (initial page size auto position) or stay as a sticked to the bottom of the screen.


Update gradle to 8.9

I have been trying to work with ANTLR4 grammars in a relatively recent release of openjdk, and have found that the gradle version pinned in this repo forces me into a very old JDK.
With this change I see some deprecation warnings about some project-specific configuration that will no longer be valid once gradle 9 is release... but the project compiles.

Thank you for updating the Gradle version.  I have not had a chance to update this grammar for a while

This repo has been super helpful, so thank you! I've been working with someone to try to generate a parser for some very very old PowerBuilder.
We weren't able to use the grammar as-is, mostly because of issues with inline SQL statements. We're going to try to just use an updated grammar that parses SQL statements as strings, but I've also seen that in ANTLR4 it's possible for a lexer to switch modes upon encountering a token... we probably won't spend more time on it now, but it seems like an interesting possibility.
Again, thank you for all the work you did on this!

From my personal experience, it is best to employ the
'divide-and-conquer' approach.  Extract the SQL string and pass it to the
SQL parser. In the same manner, handle the PB Data Window using a different
parser.
That is what I did when parsing different versions of PB and it worked
Cheers,
Paul
On Mon, Jul 22, 2024 at 3:44 PM Eric Saxby @.***> wrote:

This repo has been super helpful, so thank you! I've been working with
someone to try to generate a parser for some very very old PowerBuilder.
We weren't able to use the grammar as-is, mostly because of issues with
inline SQL statements. We're going to try to just use an updated grammar
that parses SQL statements as strings, but I've also seen that in ANTLR4
it's possible for a lexer to switch modes upon encountering a token... we
probably won't spend more time on it now, but it seems like an interesting
possibility.
Again, thank you for all the work you did on this!
—
Reply to this email directly, view it on GitHub
https://github.com/gmai2006/grammar/pull/4#issuecomment-2243936391, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFQQMZLL3GQOXGIXDITUU3ZNWDNVAVCNFSM6AAAAABLI7WQTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBTHEZTMMZZGE
.
You are receiving this because you commented.Message ID:
@.***>


MultipartStreamReader has suboptimal boundary search in stream

Method SubMatch in class MultipartStreamReader has a naïve implementation of a substring search that make this method a hotpath in multpart upload scenarios.
In an ad-hoc test uploading a number of files ranging from 10 MB to 1 GB, method SubMatch consumed 53.4% exclusive samples during a profiling session.

Its current implementation has an O(NM) complexity that can be improved by using a faster algorithm such as Boyer–Moore–Horspool.
Method SubMatch looks for two things:

Whether the byte array segment fully contains the boundary, or
Whether the byte array ends with the start of the boundary.

Case 1 can implement a faster algorithm. Case 2 can be more natural and check character by character as typically the boundary string is very short compared to the length of the byte array segment.

Implemented a modified Boyer–Moore–Horspool algorithm with an average-case complexity of O(N) on random text. Worst case, it behaves similarly to the previous implementation O(MN), where M is the length of the boundary and N is the length of the buffer to operate on.
This took the cost down to 16.1%. I think I know how to bring it a bit lower, will try that. My skip table is currently a Dictionary<byte, int> when it could simply be a byte[256].

Indeed, changing the skip table type from Dictionary<byte, int> to int[256] brought times down as expected. SubMatch now costs 7.6%. I'll run some more tests and then submit a PR.

/cc @davidfowl

W00t

Fixed 15649b7.


Update base ubuntu image to ubuntu 20 (focal fossa)

The eoan ubuntu image is no longer available, so running vagrant up in master branch errors out as follows:
The box 'ubuntu/eoan64' could not be found or
could not be accessed in the remote catalog. If this is a private
box on HashiCorp's Vagrant Cloud, please verify you're logged in via
`vagrant login`. Also, please double-check the name. The expanded
URL and error message are shown below:

URL: ["https://vagrantcloud.com/ubuntu/eoan64"]
Error: The requested URL returned error: 404 Not Found

For the fix, I pointed to ubuntu/focal64 and verified that vagrant up runs without error with the newer ubuntu image.

thank you!


missing a few updates on the requirements.txt  Flask-Login among others

There were a number of dependencies where the update didn't propagate to the requirements.txt.  Once i upgraded Flask-login, things behaved more appropriately.  Urllib3 also didn't get updated- this may be a source of issues.

Looks fine ... I'm going to go ahead and merge and then test locally to make sure things still work with the changes I've made to session management.


⚠ Bofrost.at has degraded performance

In 5eb3fde, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 887 ms

Resolved: Bofrost.at performance has improved in baa5980 after 6 minutes.


Wasm server: Cache code from github gists

Right now we fetch source code from GitHub Gists on every request. They should be cached and refreshed in the background.

Done.


[Classified] fixed ammo notes section for squad

Changes / Comments
The textarea notes/ammo for each squad member had the same  Roll20 attribute name.  Changed them to be unique.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

@Lockbox313 This appears to modify two completely different sheets: Classified and All For One.


ENH: Adapt the split and cross strategies to quantile regression class

Description
At the moment, conformalized quantile regression has only been implemented with the split-conformal strategy. It would be worth extending it to cross-CQR with the cv argument. This PR proposes to adapt the quantile regression class for split and cross conformal strategies by adding to the init method the cv parameter so that it is comparable to the regression class.
Fixes #200
Type of change
Please remove options that are irrelevant.

Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

[x] Uniformisation of regression tests (for cross settings).
[x] Adaptation of quantile regression tests to changes.

Checklist

[x] I have read the contributing guidelines
[x] I have updated the HISTORY.rst and AUTHORS.rst files
[x] Linting passes successfully : make lint
[x] Typing passes successfully : make type-check
[x] Unit tests pass successfully : make tests
[x] Coverage is 100% : make coverage
[x] Documentation builds successfully : make doc

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (963bb6e) 100.00% compared to head (3f6500b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #304   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           27        27
  Lines         3474      3399   -75
  Branches       360       367    +7
=========================================
- Hits          3474      3399   -75

Impacted Files
Coverage Δ

mapie/tests/test_utils.py
100.00% <ø> (ø)

mapie/utils.py
100.00% <ø> (ø)

mapie/quantile_regression.py
100.00% <100.00%> (ø)

mapie/regression.py
100.00% <100.00%> (ø)

mapie/tests/test_quantile_regression.py
100.00% <100.00%> (ø)

mapie/tests/test_regression.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


yuzu-{ea,mainline}: {2725,1088} -> {2841,1092}

Upstream added the cast, so the EA version now successfully builds.
This also changes the update script, because pineapple changed their releases which no longer have a name set explicitly.
I did not manage to get archive.org to archive the most recent version of the compatibility database, so I used the most recent one archived there.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

I did not manage to get archive.org to archive the most recent version of the compatibility database, so I used the most recent one archived there.

Ah, that looks to be the one I made a few days ago when attempting to update these packages. Noticed it did take a very long time to create a snapshot, I had to wait about 45 minutes to an hour before it showed up. Because of that I sadly don't think its feasible to include it in the update script.

Hi, I just want to point out that the https://github.com/flathub/org.yuzu_emu.yuzu repository has a copy of the compatibility list checked into it. I'm not sure if that is useful or not.

Thanks for letting us know! This is very useful, we could change the update script to update the compatibility list automatically based on that.

From what I've been able to derive, the compatibility list hasn't changed since 2022-02-07 aka Feb 7th. From what I can gather the system that takes compatibility reports and outputs the ratings needs to be redesigned, and somebody IS working on it.

That's a shame. Seeing how upstream does still include it i think we should as well, it's better than nothing i suppose. Hope they'll finish the redesign soon :)


Generates non-parsable xcodeproj when a file name contains '@'

Using XcodeGen 0.3.0 and Xcode 8.3.3.
If one of files name contains "@", xcodegen generates non-parsable project by Xcode, somehow.
So it cannot deal with retina filenames such as<EMAIL_ADDRESS><EMAIL_ADDRESS>Adding those kind of assets to *.xcassets wouldn't really solve this problem as I intend not to use it, since using xcassets forces UIImage to be cached.
example:
name: FooBar
targets:
  - name: FooBar
    type: application
    platform: iOS
    sources:
      - Assets

If "Assets" directory or its subdirectory contains a file that has "@" in its name, Xcode cannot parse generated project.
The other tool, struct, can correctly generates a project in the same situation, just fwiw.

Fixed by https://github.com/carambalabs/xcodeproj/pull/48
Will be in next release

Amazing! 🤝

On build script feature, inline script parsing seems to be broken in HEAD, might be related to this merge?

Oh, yes please file a new issue with your inline script

Thx, have a look at #41 when you have a time


Add the capability for the drawing of the node to the data from the calling web component

If the data for the node of the tree has an entry for draw, then the node is drawn by calling that function.

This has been added.


(PUP-10446) Remove application orchestration

Remove the environment catalog rest API
Remove application, site, produces and consumes from the grammar. Any use of those keywords will produce a syntax error.
/cc @Magisus @justinstoller this may affect puppetserver due to the removed environment catalog API

Prior to making any changes, I found that running bundle exec rake gen_eparser produced a different eparser.rb than was checked in. I'm not sure why that is? Presumably the grammar was updated but the parser wasn't? Or there's some non-deterministic behavior. So there are two "Generate eparser..." commits. One to update the eparser to bring it up to date. And another after I made the grammar changes.

CLA signed by all contributors.

PR https://github.com/puppetlabs/puppetserver/pull/2411 should be merged first so that we don't break puppetserver.

Jenkins, please test this

jenkins please test this

Do we know if the auto-Jenkins trigger works with puppetserver on this branch?

jenkins please test this with servertests

This looks good, though I don't think I'm super qualified to say it doesn't have farther reaching implications. A couple things I did note:

It looks like add_mapping is now orphaned.
We should remove the relevant routes in puppetserver.

add_mapping

I'll look into this/amend this PR

remove relevant routes

I missed those in my earlier puppetserver PR. I have a new PR for that https://github.com/puppetlabs/puppetserver/pull/2414

jenkins please test this with servertests

jenkins please test this with servertests


OAuth redirect happening more often than expected

It seems like the fetchUserToken is often failing, causing the user to have to re-auth. Why?

I wonder if we should increase this to 15 seconds:
if currentToken.Expiry.After(time.Now().Add(time.Duration(1) * time.Second)) {
	logger.Logger.Info("Using existing Alby OAuth token")
	return currentToken, nil
}


GitBook to Slab URL mapping

We need to update the Schematron so that the links point to Slab instead of GitBook.
The easiest way to do so is to 'map' the page URLs from Gitbook to Slab. The URLs for any tests covered on a gitbook page can then easily be updated with the correct Slab links.
This spreadsheet contains all current GitBook pages linked to from the Schematron:
https://docs.google.com/spreadsheets/d/11CIQVcvZCWMuTEROt2i-Lb2xVaWq7_y2hXcOLYR-HgE/edit?pli=1#gid=0

[ ] James approved mapping
[ ] Naushin approved mapping
[ ] Claudia approved mapping

@naushinthomson please can you add this ticket to the current sprint?
Feel free to edit the description if needed.


Event groups

Codecov Report

Merging #146 (a4ad2a9) into main (597ddcc) will decrease coverage by 16.30%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #146       +/-   ##
===========================================
- Coverage   41.08%   24.77%   -16.31%
===========================================
  Files          65       48       -17
  Lines        2456     1659      -797
  Branches      666      504      -162
===========================================
- Hits         1009      411      -598
+ Misses       1251     1076      -175
+ Partials      196      172       -24

Flag
Coverage Δ

backend
?

frontend
24.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

backend/models/extra.js

backend/services/mailer.js

backend/tests/testData.js

backend/models/forms.js

backend/tests/testHelpers.js

backend/models/visit.js

backend/models/event.js

backend/utils/helpers.js

backend/models/email.js

backend/utils/timeCalculation.js

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 597ddcc...a4ad2a9. Read the comment docs.


[inih] Build with Meson + update to r57

Follows on from #17388
Fixes #17385
Done in preparation to continue #31722 and properly address this review comment
If this PR updates an existing port, please uncomment and fill out this checklist:

[X] Changes comply with the maintainer guide
[X] SHA512s are updated for each updated download
[X] The "supports" clause reflects platforms that may be fixed by this new version
[X] Any fixed CI baseline entries are removed from that file.
[X] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Repo I've used to verify proper usage: https://github.com/DownerCase/vcpkg_verifier/tree/inih
Writing a CMake package for this by hand was an interesting experience. There must be a better way to do this because it won't work for anything more complex.

@microsoft-github-policy-service agree

Yay! That actually worked 😄

Writing a CMake package for this by hand was an interesting experience. There must be a better way to do this because it won't work for anything more complex.

Well meson does have a CMake module that can write a version file, but beyond that it's not super useful

@DownerCase, Thanks for your PR, please restore the newline type for portfile.cmake and CMakeLists.txt.

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

Please run command ./vcpkg x-add-version inih --overwrite-version and commit agagin.

IMO the port should get rid of vcpkg_cmake_... and just directly configure and install the desired (maybe simplified ) cmake config file. (I would also drop the corresponding version file. This is vcpkg, there are manifests.)

I mean sure, I considered that at one point but it felt wrong somehow to do all that in the portfile so I used the CMakeList instead.
If that’s actually preferable, and I can see how it would be, I can change it no problem.
The version file was thrown in just to “complete” the package and because it was easy. I’m not attached to it.
If you have particular suggestions on how to simplify the cmake.in file I’m all ears. The annoying bit for me was that the meson build generates two library files, as opposed to the current port build which bundles them into one, requiring two CMake imported targets and all the duplication thereof.

Tesed usage successfully by inih:x64-windows:
    find_package(unofficial-inih CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::inih::libinih )

I'll address the review comments later today.

feature cpp tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

Tested usage successfully by inih:x64-windows:
The package inih can be imported via CMake FindPkgConfig module:

    find_package(PkgConfig)
    pkg_check_modules(INIH REQUIRED IMPORTED_TARGET inih INIReader)

    target_link_libraries(main PRIVATE PkgConfig::INIH)

Alternatively, the package inih provides unofficial CMake targets:

    find_package(unofficial-inih CONFIG REQUIRED)

    target_link_libraries(main PRIVATE unofficial::inih::libinih unofficial::inih::inireader)

@dg0yt Your understanding is correct. I'll make the change but this usage is becoming rather long. Is it ok for the C++ API usage to still be present even if the feature has been turned off and it is not present?

I'll make the change but this usage is becoming rather long.

I'm aware of the length. That's why I'm against promoting unofficial usage when there is an official pattern.
(But I do understand the limitations of pkg-config for multi-config builds.)

Is it ok for the C++ API usage to still be present even if the feature has been turned off and it is not present?

I think I made the point before: Remove the optional feature and always install the C++ API. I see no benefit from making it optional in this package.

Is it ok for the C++ API usage to still be present even if the feature has been turned off and it is not present?

I think I made the point before: Remove the optional feature and always install the C++ API. I see no benefit from making it optional in this package.

You did. I think I misunderstood and made it a default-option. IMO what we have now is good enough; inih is a C library first and they build INIReader as an optional feature, makes sense to me to reflect that. Something to revisit next update perhaps.

Great ci flaked out, 503 when downloading vcpkg tool. Rerunning x64_windows_static_md is needed.

Tested usage successfully by inih:x64-windows:
The package inih can be imported via CMake FindPkgConfig module:

    find_package(PkgConfig)

    # C API
    pkg_check_modules(INIH REQUIRED IMPORTED_TARGET inih)
    target_link_libraries(main PRIVATE PkgConfig::INIH)

    # C++ API (Requires "cpp" feature)
    pkg_check_modules(INIReader REQUIRED IMPORTED_TARGET INIReader)
    target_link_libraries(main PRIVATE PkgConfig::INIReader)

Alternatively, the package inih provides unofficial CMake targets:

    find_package(unofficial-inih CONFIG REQUIRED)

    # C API
    target_link_libraries(main PRIVATE unofficial::inih::libinih)

    # C++ API (Requires "cpp" feature)
    target_link_libraries(main PRIVATE unofficial::inih::inireader)

Alright new state of play.

No unofficial CMake target because upstream provides a pkg config output.

I nominate myself as responsible if downstream/users have issues. Only aware of minio-cpp currently.

Usage:

Is consistent with other pkgconf only packages.
Lists both available packages and their use-case
Notes that INIReader requires the "cpp" feature which is enabled by default.

Now supports dynamic linkage! 🥳

I tested the usage and although upstream has the soversion hard-coded as '0' (inih-0.dll) it did work.

My respect for all the vcpkg maintainers has grown hugely after getting a taste of the madness you have to deal with. Thank you for all the hard work to make this all usable.
For some reason I still feel compelled to want to continue contributing though; hmm.
Anyway, hopefully this PR is almost done now...


Slowness when creating LineString

Problem Description:

As the center of the map changes, I set the coordinate of the new center to the LineString component. But LineString changes very slowly.

This is video url for problem :
https://vimeo.com/724430478

My Code:
import React, { useRef, useState } from 'react';
import { Pressable, View } from 'react-native';

//Third Party
import MapboxGL from '@rnmapbox/maps';

//Styles
import styles from './style';
import Icon from '@components/Icon';

MapboxGL.setAccessToken('NOT_REQUIRED');

const Maps = () => {
	const [points, setPoints] = useState([]);
	const [mapCenter, setMapCenter] = useState([]);

	const camRef = useRef(null);
	const mapRef = useRef(null);

	const RouteLine = () => {
		return (
			<MapboxGL.ShapeSource
				id="routeLine"
				shape={{
					type: 'FeatureCollection',
					features: [
						{
							type: 'Feature',
							properties: {},
							geometry: {
								type: 'LineString',
								coordinates: points,
							},
						},
					],
				}}>
				<MapboxGL.LineLayer
					id="lines"
					style={{
						lineColor: 'blue',
					}}
				/>
			</MapboxGL.ShapeSource>
		);
	};
	const LastLine = () => {
		return (
			<MapboxGL.ShapeSource
				id="LastLineShape"
				shape={{
					type: 'FeatureCollection',
					features: [
						{
							type: 'Feature',
							properties: {},
							geometry: {
								type: 'LineString',
								coordinates: [points?.[points?.length - 1] || [], mapCenter],
							},
						},
					],
				}}>
				<MapboxGL.LineLayer
					id="preLines"
					style={{
						lineColor: 'blue',
						lineDasharray: [10, 5],
					}}
				/>
			</MapboxGL.ShapeSource>
		);
	};

	const setNewPoint = async () => {
		const point = await mapRef?.current?.getCenter();
		setPoints(x => [...x, point]);
	};
	const changeMapRagion = val => {
		setMapCenter(val?.geometry?.coordinates);
	};

	return (
		<View style={styles.container}>
			<MapboxGL.MapView
				ref={mapRef}
				style={styles.map}
				logoEnabled={false}
				attributionEnabled={false}
				onRegionIsChanging={changeMapRagion}
				// onRegionDidChange={changeMapRagion}
				styleURL={'https://***.json'}>
				<MapboxGL.Camera ref={camRef} centerCoordinate={[35, 39]} zoomLevel={3.5} animationDuration={1200} />
				<RouteLine />
				{points?.length > 0 && <LastLine />}
			</MapboxGL.MapView>
			<View style={styles.target}>
				<Icon name="target : materialcomm" size={40} />
			</View>
			<Pressable style={styles.plusPointPress} onPress={setNewPoint} hitSlop={8}>
				<Icon name="plus : feather" size={40} color="#fff" />
			</Pressable>
		</View>
	);
};

export default Maps;

not sure if you had any luck with this? but I had a similar issue that I messed with for weeks that ultimately led me switching to a different mapping library. I was trying to build a linestring from a recorded route, and FPS would drop to <5 in only a few minutes. I can do the same in this new library for hours without any issues.

import styles from './style';
import Icon from '@components/Icon';

with those I cannot just run this example without modifying

not sure if you had any luck with this? but I had a similar issue that I messed with for weeks that ultimately led me switching to a different mapping library. I was trying to build a linestring from a recorded route, and FPS would drop to <5 in only a few minutes. I can do the same in this new library for hours without any issues.

What lib did you switch to?

react-native-maps. Would prefer this library and mapbox in general, but had some road blocks that held things up.


Build failed for iOS: Undefined symbols for architecture arm64: "OBJC_CLASS$_SentryId"

Platform
Apple, Android
Installed
Swift Package Manager
Version
0.5.0
Steps to Reproduce

Add io.sentry:sentry-kotlin-multiplatform:0.5.0 to sourceSets.commonMain.dependencies in build.gradle.kts

kotlin {
    // snip

    listOf(
        iosX64(),
        iosArm64(),
        iosSimulatorArm64()
    ).forEach { iosTarget ->
        iosTarget.binaries.framework {
            baseName = "ComposeApp"
            isStatic = true
        }
    }

    sourceSets {
        commonMain.dependencies {
            implementation("io.sentry:sentry-kotlin-multiplatform:0.5.0")
        }
    }
}

Add sentry-cocoa using sentry-wizard -i ios

Move initialize code using Shared initializer

// commonMain/SentryInit.kt

fun initializeSentry() {
    Sentry.init { /* setting */ }
}

// androidMain/MainApplication.kt
class MainApplication : Application() {
    override fun onCreate() {
        super.onCreate()
        initializeSentry()
    }
}

// iosMain/iOSApp.swift
import ComposeApp

@main
struct iOSApp: App {
    init() {
        SentryInitKt.intializeSentry()
    }
}

Build both Android (on Android Studio) and iOS (on XCode)

Expected Result
Build success.
Actual Result

Android: Build success and Sentry got works well.
iOS: Link app failed with the message below.

Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_SentryId", referenced from:
       in ComposeApp[arm64][2727](libio.sentry:sentry-kotlin-multiplatform-cache.a.o)
ld: symbol(s) not found for architecture arm64

Hi which version of cocoa sdk are you using?

Not sure which version is added through the wizard

Assuming you are using only SPM then you'll need to add extra c flags within xcode:

Otherwise we recommend installing the KMP SDK as per our guide: https://docs.sentry.io/platforms/kotlin-multiplatform/

This problem should be fixed with the next release 0.6.0

which version of cocoa sdk are you using?
Using 8.25.0.

I'll try using cocoapods.

fyi currently our KMP SDK only works with versions up to 8.21.0, please look at this table to check what works

Our next release will support versions starting from 8.22

@buenaflor It works now, thank you!


Use of deprecated setOutput functionality causes warnings when action is used

Use of deprecated setOutput functionality causes warnings when action is used
Ref: GitHub Actions: Deprecating save-state and set-output commands

New version v1.1.0 (or the updated v1 tag) resolves this. Closing.


Potential list of readers

Here is a list of some potential io packages people might want to use with napari - note this list is not exhaustive and in some places is overlapping.
For image layer:

[ ] imageio - reads many image file formats
[ ] PIMS - note PIMS contains many image readers inside it
[ ] python-bioformats - note python-bioformats uses a python-javabridge to start and interact with a Java virtual machine contains many image readers
[ ] npy, npz - simple numpy formats
[ ] mat - load matlab files
[ ] zarr or via xarray or via dask
[ ] tiledb or via dask
[ ] netCDF or via xarray
[ ] hdf5 or via dask
[ ] dask_image for lazy loading based on PIMS
[ ] aicspylibczi
[ ] nd2reader
[ ] openslide

For surface layer:

[ ] meshio

For shapes layer:

[ ] geoJSON
[ ] shapely formats - note shapely it's doesn't write or read files

For points layer:

[ ] csv or with pandas

this is great!  inasmuch as this would be a "curated" io plugin, I'd love to see a big list of format support overlap laid out.  If we could identify a few key aims here, it might help us to narrow down the package dependencies without limited the number of formats that are supported.  Of course, there will likely still be some overlap, but that could be addressed with reader priority in the napari_get_reader logic...
Things to consider:

pure python vs java
read speed & other performance metrics
metadata support
dependency trees

I don't want to stop anyone trying to give python-bioformats a try, but previously I've found bioformats in python much easier using pims (with jpype) than it was using python-bioformats (with python-javabridge).
Some notes:

I did most of my experimenting comparing libraries for mixing python & bioformats in 2018, so it's relatively current.
I was originally expecting to want to use python-bioformats for my project since that's what CellProfiler uses, and was surprised to run into issues caused by different Java installations on different computers.
You can see the pims implementation of bioformats support here: https://github.com/soft-matter/pims/blob/master/pims/bioformats.py (and the license terms are here)
If you use jpype (which is not installed by default) you'll need to pip install jpype1 (presumably there was a namespace conflict on PyPI). Not really a big deal, this is the package: https://pypi.org/project/JPype1/
Bioformats and loci_tools are updated frequently, much faster than pims updates. This is a pain point for users but you could vendor something like the pims bioformats.py yourself and eliminate this problem.

This thread may be useful reading https://github.com/soft-matter/pims/issues/318
This webpage has the list of bioformats releases https://downloads.openmicroscopy.org/bio-formats/
The bioformats version used in pims is three years out of sync. There is an open pull request from a while ago here https://github.com/soft-matter/pims/pull/301 but I imagine this could be a recurring problem.
Most users will want the latest version of loci_tools as the default, and there should be an easily accessible mechanism for users to specify a different version if they want (eg: for older microscope files).

I wholeheartedly agree.  I also prefer the pims bioformats implementation (or even just direct usage of loci tools using pyjnius or jpype to python-bioformats & javabridge)

Hi, this is a very nice list. I'm the owner of ND2Reader and a maintainer of PIMS, and would just like to say they're not mutually exclusive! Actually, the ND2Reader is based on the PIMS API. In PIMS, there is also an imageio reader. And the bioformats API in PIMS was just updated to the latest 6.5 version. Hope this helps.

I also prefer the pims bioformats implementation (or even just direct usage of loci tools using pyjnius or jpype)

Just to be clear, the pims bioformats implementation is direct usage of loci_tools.jar with jpype, those are equivalent.

Thanks for jumping in @rbnvrw
With the most recent release of pims v0.5, I can withdraw my suggestion to vendor pims functionality (yay!). Now users can update to newer versions of bioformats themselves (with pims.bioformats.download_jar(version="$NEW.$VERSION.$NUMBER"), that takes a lot of the pressure off.

I also prefer the pims bioformats implementation (or even just direct usage of loci tools using pyjnius or jpype)

Just to be clear, the pims bioformats implementation is direct usage of loci_tools.jar with jpype, those are equivalent.

by direct, I meant "directly doing it yourself"... I know that's what they're doing, and I like it!

I also prefer the pims bioformats implementation (or even just direct usage of loci tools using pyjnius or jpype)

Just to be clear, the pims bioformats implementation is direct usage of loci_tools.jar with jpype, those are equivalent.

by direct, I meant "directly doing it yourself"... I know that's what they're doing, and I like it!

Ah, I understand you now. Yeah, I like it too!


[Storage] Fixed cspell typos in storage-blob

Description
Part of #22674
fixing incorrectly written words at source codes:

transfered -> transferred
snapthots -> snapshots
speficied -> specified
conifgure -> configure

All SDK Contribution checklist:

[X] The pull request does not introduce [breaking changes]
[X] CHANGELOG is updated for new features, bug fixes or other significant changes.
[X] I have read the contribution guidelines.

General Guidelines and Best Practices

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

Thanks @bnbong for your contribution! I will go ahead and merge this.


fix the the missed 'host' property

The host is missed, while invoking GetSwagger  in the middleware. (the original parameter just replaced by null value.)
One needs the host property while making swagger.json working well with the third-party tools, such as Postman.

if 'host' property missed, the imported entry in postman would generate the url like http://foo/bar, while urls like http://foo.com:8888/foo/bar with host was the correct one indeed.

My fault,  for a month I hav''nt use it.
I should have know that it's configurable now.


uuid-ossp extension must be dropped LAST not FIRST

Down migration includes this in the first line:
migrationBuilder.DropPostgresExtension("uuid-ossp");
Causes the following error:

cannot drop extension uuid-ossp because other objects depend on it

Should be dropping the extension as the last step.

I've already reordered the migration operations as part of #76. However, for 1.0.2 I intend to remove extension dropping altogether, see #84. For now you can simply edit your migrations and remove the drop operation.


Rectified one

Really sorry sir,
I tried to rectify my mistake this time.
Thank you

it's okay thank you for you contribution :)


gcov: Add config checks for IP handling

Need to validate the configuration parms to setup the IP's.
Signed-off-by: Deb McLemore<EMAIL_ADDRESS>

Closing, PR #441 incorporates complete fix.


Next method

Hello there !
Just to know what does the next method ?
Thanks for the answer ! ;)

What do you mean next method? There is no such method on socket.io.

eg.
io.of('/test').use(function(socket, next){
  console.log("Authenticating...")
  next();
});

I'm afraid, untill the docs are improved you'll need to read the source to figure that out. Here's the function that you receive as next.
https://github.com/Automattic/socket.io/blob/master/lib/index.js#L121

The next method is a function provided to you as an argument so you can indicate to socket.io when your function call is complete. This is done because your function maybe choose to do async things which will require a callback.


Task Registry Now Uses Opportunistic Intern

Significantly improves #4155
Opening a solution of 810 projects yields reduced string duplication.
Example string that went from 9152 duplicates to 680:

FYI @drewnoakes and @davkean

Nice!


Make SelectionContents less strict

Make pvlSelectionContents not fail as a whole when a member fails. This makes sense for getting attrs because you might select a bunch of elements only some of which have data-foo, and that should work.
Also fix pvlJSONStringSimple.
r? @maxtaco @oconnor663

Simplified, got rid of errors.

👍


Write transaction data on commit

This replaces the journal table along with the ZooKeeper transaction blacklist.

https://ocd.appscale.com:8080/job/Daily Build/1684/

Build: https://ocd.appscale.com:8080/job/Daily Build/1687/
Upgrade: https://ocd.appscale.com:8080/view/All/job/Upgrade/78/


[ISSUE] - After converting an image to base64, it rotates 90 degrees.

     const base64 = await ImgToBase64.getBase64String(Platform.OS === 'android' ? uri :file://${uri});
After converting an image to base64, it rotates 90 degrees to left.
There is no prop in the documentation for leaving the image orientation fixed.
React Native: 0.63.3
React: 16.13.1
Lib: 0.1.4

any solution?


[#169643312] Add InfluxDB to Aiven broker

Story
What

[x] Adds a plan for InfluxDB
[ ] Targets the influxdb branch 🐝 please change this before merging
[x] Adds a custom broker acceptance test for InfluxDB
[x] Uses Go 1.13 and go mod for the healthcheck app

How to review
Review the accompanying PR https://github.com/alphagov/paas-aiven-broker/pull/21
Code review
Run it down your pipeline
You may wish to manually have a play using cf create-service
Who can review
Not @tlwr

@jonathanglassman and I wrote some docs: https://github.com/alphagov/paas-tech-docs/pull/277


Fix workflow

So it works with virtualenv. That narrows it down to a conda issue which confirms what is seen in logs

It's all a bit broken. I'm not sure why 😢
The workflows have been not working for the past week (or maybe 2 by now). https://github.com/django/django-asv/actions
It seems conda isn't working which we were using to test against multiple pythons. Conda is giving an error message with something like
SpecNotFound: /tmp/tmpamp_6v0p.yml is not a valid yaml file.

I've managed to cat that file in the runner and I get
runner@fv-az280-798:~/work/django-asv/django-asv$ cat /tmp/tmp0oboqqg_.yml
name: conda-py3.10
channels:
dependencies:
   - python=3.10
   - wheel
   - pip

Anyone spot anything wrong with this? 🤷

So by editing the .yml file to:
name: conda-py3.10
dependencies:
  - python=3.10
  - wheel
  - pip

Conda was able to successfully create the environment.


fix: parse plugin artifactItem dependencies

Fixes https://github.com/dependabot/dependabot-core/issues/5826

@abdulapopoola This is ready for a review 🙏

Thank you @abdulapopoola
@jurre One more review would be appreciated. Thanks!

@jeffwidman Can you help move this one forward?


Misc fixes

Cleaned up the code
Added automatic download of needed file
Fixed requirements
Improved README

The example still doesn't work for me though. The mouse cursor is moved in big chunks seemingly at random directions, and it prints "wink wink" also seemingly at random.
You should also fix the comments that are not in English to be in English.

Thanks for your changes and taking time to review my code! I really
appreciate it.
Regarding the performance of the example, it is vastly associated with the
quality of your webcam, the lighting and the speed at which your computer
refreshes.
You can try:
Shining a light at your face.
Decreasing the variable called CoefSens.
Thank you!
El lun., 14 de septiembre de 2020 04:52, Anders Hovmöller <
<EMAIL_ADDRESS>escribió:

Cleaned up the code
Added automatic download of needed file
Fixed requirements
Improved README

The example still doesn't work for me though. The mouse cursor is moved in
big chunks seemingly at random directions, and it prints "wink wink" also
seemingly at random.
You should also fix the comments that are not in English to be in English.
You can view, comment on, or merge this pull request online at:
https://github.com/rfontalva/Headmouse/pull/1
Commit Summary

Cleaned up the code

File Changes

A .gitignore
https://github.com/rfontalva/Headmouse/pull/1/files#diff-a084b794bc0759e7a6b77810e01874f2
(4)
M HeadMouseCaseOfUse.py
https://github.com/rfontalva/Headmouse/pull/1/files#diff-289eb2756c31e8156d165f13828ae1cb
(6)
M HeadMouseObj.py
https://github.com/rfontalva/Headmouse/pull/1/files#diff-af168a02c95af5e4d139e1ab0ed25da6
(128)
M README.md
https://github.com/rfontalva/Headmouse/pull/1/files#diff-04c6e90faac2675aa89e2176d2eec7d8
(19)
A requirements.txt
https://github.com/rfontalva/Headmouse/pull/1/files#diff-b4ef698db8ca845e5845c4618278f29a
(5)

Patch Links:

https://github.com/rfontalva/Headmouse/pull/1.patch
https://github.com/rfontalva/Headmouse/pull/1.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rfontalva/Headmouse/pull/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL7D7CRBVC5JM4FBIGBJKADSFXDUVANCNFSM4RLIUS7Q
.

What is it supposed to do? Move the cursor to where I'm looking or move it if I look at a certain direction?

It should move as your head moves, if you tilt a little to the right it
will move little by little to the right, if you tilt a lot to the left it
will move faster in that direction and so on.
El lun., 14 de septiembre de 2020 10:16, Anders Hovmöller <
<EMAIL_ADDRESS>escribió:

What is it supposed to do? Move the cursor to where I'm looking or move it
if I look at a certain direction?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rfontalva/Headmouse/pull/1#issuecomment-692045025,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL7D7CXAVW6QW2Y7KP4ZU6LSFYJS7ANCNFSM4RLIUS7Q
.

Aha! Well that works actually quite well when you know what it's supposed to do! You should write this in the documentation.
It should have some minimum threshold though. I can't get the cursor to stay still.
If you like these changes, please press the merge button.

I haven't been able to check them yet, but I sure will! Thank you again for
your interest and suggestions
El mar., 15 de septiembre de 2020 05:40, Anders Hovmöller <
<EMAIL_ADDRESS>escribió:

Aha! Well that works actually quite well when you know what it's supposed
to do! You should write this in the documentation.
It should have some minimum threshold though. I can't get the cursor to
stay still.
If you like these changes, please press the merge button.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rfontalva/Headmouse/pull/1#issuecomment-692562602,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AL7D7CW6ALBMVOVKHL56ME3SF4R6RANCNFSM4RLIUS7Q
.


Rows with empty "tag' is being inserted into database

Ideally, we should not insert empty rows

Are those blank node2 cells completely empty? Or, do they contain space characters?

completely empty, I think its coming from here https://github.com/usc-isi-i2/t2wml-annotation/blob/master/annotation/generation/annotation_to_template.py#L161

That code is for creating the Excel template with the tag column.
The code that generates the tag edges based on the Excel template is here: https://github.com/usc-isi-i2/t2wml-annotation/blob/master/annotation/generation/wikify_datamart_units_and_attributes.py#L341
It should have skipped generating the tag edge if the cell is empty. Let me try a few test cases.

Fix in 2wml-annotation dfe1744