Update has_len_all_ranks to use Strategy.root_device

What does this PR do?

Same motivation as #11734
Part of #11922
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda @justusschock @awaelchli @rohitgr7 @ninginthecloud @otaj

The CPU test failures are real:
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs0-10]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs1-5]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs2-4]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs3-3]
FAILED trainer/properties/test_estimated_stepping_batches.py::test_num_stepping_batches_gpu[trainer_kwargs4-64]

cc @rohitgr7


More graceful error message when port is in use

Currently, when you start fava while the port is already in use, you get the following exception:
Traceback (most recent call last):
  File "/home/daniel/.pyenv/versions/3.5.1/bin/beancount-web", line 9, in <module>
    load_entry_point('beancount-fava==0.2.3', 'console_scripts', 'beancount-web')()
  File "/home/daniel/.pyenv/versions/3.5.1/lib/python3.5/site-packages/beancount_fava-0.2.3-py3.5.egg/fava/cli.py", line 109, in main
    run(sys.argv[1:])
  File "/home/daniel/.pyenv/versions/3.5.1/lib/python3.5/site-packages/beancount_fava-0.2.3-py3.5.egg/fava/cli.py", line 93, in run
    server.serve(port=args.port, host=args.host, debug=args.debug)
  File "/home/daniel/.pyenv/versions/3.5.1/lib/python3.5/site-packages/livereload-2.4.1-py3.5.egg/livereload/server.py", line 283, in serve
  File "/home/daniel/.pyenv/versions/3.5.1/lib/python3.5/site-packages/livereload-2.4.1-py3.5.egg/livereload/server.py", line 241, in application
  File "/home/daniel/.pyenv/versions/3.5.1/lib/python3.5/site-packages/tornado/web.py", line 1825, in listen
    server.listen(port, address)
  File "/home/daniel/.pyenv/versions/3.5.1/lib/python3.5/site-packages/tornado/tcpserver.py", line 126, in listen
    sockets = bind_sockets(port, address=address)
  File "/home/daniel/.pyenv/versions/3.5.1/lib/python3.5/site-packages/tornado/netutil.py", line 196, in bind_sockets
    sock.bind(sockaddr)
OSError: [Errno 98] Address already in use

This should be replaced with a more graceful error message.

Now looks like this:
$ fava example.ledger
[I 160227 17:36:32 server:281] Serving on http://localhost:5000
Error: Can not start webserver because the port/address is already in use.
Please choose another port with the '-p' option. ([Errno 48] Address already in use)


1.12.2: test suite is failing

+ cd argcomplete-1.12.2
+ /usr/bin/python3 setup.py test
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
running egg_info
writing argcomplete.egg-info/PKG-INFO
writing dependency_links to argcomplete.egg-info/dependency_links.txt
writing requirements to argcomplete.egg-info/requires.txt
writing top-level names to argcomplete.egg-info/top_level.txt
reading manifest file 'argcomplete.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'argcomplete.egg-info/SOURCES.txt'
running build_ext
Traceback (most recent call last):
  File "setup.py", line 10, in <module>
    setup(
  File "/usr/lib/python3.8/site-packages/setuptools/__init__.py", line 144, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib64/python3.8/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/lib64/python3.8/distutils/dist.py", line 966, in run_commands
    self.run_command(cmd)
  File "/usr/lib64/python3.8/distutils/dist.py", line 985, in run_command
    cmd_obj.run()
  File "/usr/lib/python3.8/site-packages/setuptools/command/test.py", line 238, in run
    self.run_tests()
  File "/usr/lib/python3.8/site-packages/setuptools/command/test.py", line 256, in run_tests
    test = unittest.main(
  File "/usr/lib64/python3.8/unittest/main.py", line 100, in __init__
    self.parseArgs(argv)
  File "/usr/lib64/python3.8/unittest/main.py", line 147, in parseArgs
    self.createTests()
  File "/usr/lib64/python3.8/unittest/main.py", line 158, in createTests
    self.test = self.testLoader.loadTestsFromNames(self.testNames,
  File "/usr/lib64/python3.8/unittest/loader.py", line 220, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib64/python3.8/unittest/loader.py", line 220, in <listcomp>
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib64/python3.8/unittest/loader.py", line 191, in loadTestsFromName
    return self.loadTestsFromModule(obj)
  File "/usr/lib/python3.8/site-packages/setuptools/command/test.py", line 55, in loadTestsFromModule
    tests.append(self.loadTestsFromName(submodule))
  File "/usr/lib64/python3.8/unittest/loader.py", line 154, in loadTestsFromName
    module = __import__(module_name)
  File "/home/tkloczko/rpmbuild/BUILD/argcomplete-1.12.2/test/test.py", line 32, in <module>
    FISH_VERSION_TUPLE = tuple(int(x) for x in FISH_VERSION_STR.split('.'))
  File "/home/tkloczko/rpmbuild/BUILD/argcomplete-1.12.2/test/test.py", line 32, in <genexpr>
    FISH_VERSION_TUPLE = tuple(int(x) for x in FISH_VERSION_STR.split('.'))
ValueError: invalid literal for int() with base 10: 'unknown'

Could potentially be due to fish changing the name of their version string (see https://github.com/fish-shell/fish-shell/issues/4351). Can you try changing it to echo $version instead of $FISH_VERSION?


AMBARI-23319: Part 2: Provide for mpack definition tarballs crc32 or …

…md5 checksums, to validate downloaded files
What changes were proposed in this pull request?
Downloaded mpack.json will contain md5 checksum for mpack tarball, this PR adds new code to verify the mpack tarball integrity with md5 checksum comparison.
How was this patch tested?
Manually tested:
Within live debugging session, set checksum value in mpack checksum field, then the new code should calculate the md5 for the downloaded mpack tarball, then these two md5 checksums value should be identical.

@jayush @jonathan-hurley @mradha25 @swapanshridhar @adoroszlai Please review it when you have time. Thanks.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1362/
Test FAILed.
Test FAILured.

Closing PR as it is over 6 months old.


Latest version of the toolchain causes forc build process to get killed

Related Component
compiler
Problem
Using the previous toolchain, all the projects in my workspace compiled as usual.
Currently, during the forc build process, it gets stuck and after a while gets killed
[1]    64024 killed     forc build

Some smaller contracts compile but a large amount of them do not.
Steps

Run forc build either in the root of the workspace or in the forc project dir
Wait until it gets stuck
[1]    64024 killed     forc build

Possible Solution(s)
No response
Notes
Worked previously on
forc - Update available : 0.60.0 -> 0.61.2
fuel-core - Update available : 0.26.0 -> 0.28.0
fuel-core-keygen - Update available : 0.26.0 -> 0.28.0
fuelup - Up to date : 0.25.1
Device
Macbook M3 Pro
macOS 14.5 (23F79)
Installed components
latest-aarch64-apple-darwin
  forc - Up to date : 0.61.2
  fuel-core - Up to date : 0.28.0
  fuel-core-keygen - Up to date : 0.28.0
fuelup - Up to date : 0.25.1

Hey @Mantas-M  thanks for the issue. Can you provide a reproducible so that i can debug this. I cannot reproduce this on a fresh project. Also looks like you bumped from 0.60.0 to 0.61.2, it would be really helpful to see if this also happens with 0.61.0, 0.61.1.

I have a minimal repro here: https://github.com/IGI-111/forc-bug-repro It looks to be a forc bug since it happens with basically empty source.

I did some digging. It turns out that this is due to the memory usage of the compiler not about forc-pkg, we have two bumps:
~1.6gb to ~5.5 gb -> https://github.com/FuelLabs/sway/commit/0e567287b4e0abe5394fb5f5f4e9d4a8528a6e13
~5.5 gb to ~20gb -> https://github.com/FuelLabs/sway/commit/76595ed3f3279a1b495bdee2de38f092a3cdb043
For the following project: https://github.com/IGI-111/forc-bug-repro

Root cause seems to be https://github.com/FuelLabs/sway/commit/76595ed3f3279a1b495bdee2de38f092a3cdb043 more specifically there is a comment there about possible reason:

Step 1 unfortunately adds an extra cloning step in the namespace
module, but I don't think it's avoidable at the moment. To avoid this
extra cloning step we would need to have a better way of building the
external module structure than we currently have. https://github.com/FuelLabs/sway/issues/5498 tracks this and
other issues.

After #6249, this is resolved. Closing as completed.


Windows Mill: control characters being outputted in PowerShell & Command Prompt - cannot read easily.

Hi, I am running Mill on Windows and this is what I get when running it:

Expectation: either display colors without control characters, or display no colors, so that the output is readable.
Running in Linux it works just fine (WSL).
Thanks!

@ScalaWilliam Does it work when running mill via coursier? Like
$ cs resolve mill:0.9.5 --scala 2.13.3 -- ..mill-args..
$ cs resolve mill-interactive:0.9.5 --scala 2.13.3 -- ..mill-args..

coursier enables ANSI output in the terminal, via this library. If that fixes it, it could be interesting for mill to do the same.

@ScalaWilliam As a workaround, you can disable colored output with --color false.

@ScalaWilliam Does it work when running mill via coursier? Like
$ cs resolve mill:0.9.5 --scala 2.13.3 -- ..mill-args..
$ cs resolve mill-interactive:0.9.5 --scala 2.13.3 -- ..mill-args..

coursier enables ANSI output in the terminal, via this library. If that fixes it, it could be interesting for mill to do the same.

That didn't work - did you mean the below for example?
> cs.exe launch mill-interactive:0.9.5 -- bsp.test

In which case the colour bug was not there.
However, it would hang (I tried 0.9.6 as well) on this stage: [5/59] mill.scalalib.ZincWorkerModule.classpath. I tried it both on mill and on my own mini test project.

@ScalaWilliam As a workaround, you can disable colored output with --color false.

@lefou this seems to not have worked.
> mill --color false foo.test
[4/59] foo.test.resources
←[1A←[2K←[9999D[8/59] foo.sources
←[1A←[2K←[9999D[13/59] foo.resources
←[1A←[2K←[9999D[32/59] foo.test.sources
...

@lefou this seems to not have worked.
> mill --color false foo.test
[4/59] foo.test.resources
←[1A←[2K←[9999D[8/59] foo.sources
←[1A←[2K←[9999D[13/59] foo.resources
←[1A←[2K←[9999D[32/59] foo.test.sources
...

Looks like these are the control sequences used to overwrite the same line with the updated progress, but not the colors.

In which case the colour/special character bug was not there.

That means windows-ansi worked.
@lefou This call of a windows-ansi method allows to print ANSI escape codes in the terminal under Windows. (This calls a system call via JNI, using a DLL from jline, see the windows-ansi README.)

@ScalaWilliam I just merged #1308 which should fix the issue. Please give it a go (after it got published) and report back, if you still have issues.


Updated README example

Hi,
I updated the README example so it works after simple copy/paste. I think the easier it is to test the package and get a first sample working the better.

LGTM :+1:


Support for Ruby >= 2.7

Great gem! I love how easy it is to use a PORO with this gem.
I was able to get this running on Ruby 2.7 so I updated the spec and added the major versions between 2.7 - 3.2 to the CI matrix.

Nice, looks like the test suites all passed — and fast! This makes me feel a lot more confident about shipping future versions.
Since this is a relatively new gem, I'd like us to drop Ruby 2.7 since it's being EOL'ed soon, if I recall correctly.

Ruby 2.7 EOL is in about 35 days, so probably not worth supporting this old version. I’d definitely be in favour of 3.0+


how to map from customSelectQuery join statement

Hello @simolus3  please provide an example of mapping results of a customSelectQuery  to object.
My current implementation
Stream<List<TaskJoinClass>> getTask(int assignedId) {
  String qry1 = 'SELECT'
        ' tasks.*,'
        ' kpis.*,'
        ' onlineusers.*,'
        ' teams.*,'
        ' sites.*'
        ' FROM tasks'
        ' LEFT JOIN kpis kpis ON kpis.id=tasks.kpi'
        ' LEFT JOIN onlineusers onlineusers ON onlineusers.id=tasks.assign'
        ' LEFT JOIN teams teams ON teams.id=tasks.team'
        ' LEFT JOIN sites sites ON sites.id=tasks.site WHERE onlineusers.onlineId=${assignedId}';

return customSelectQuery(
      qry1,
      readsFrom: {
        tasks,
      },
    ).watch().map((rows) {
      return rows.map((row) {
        return TaskJoinClass(
          task: Task.fromData(row.data, db),
          kpi: Kpi.fromData(row.data, db),
          assign: Onlineuser.fromData(row.data, db),
          team: Team.fromData(row.data, db),
          site: Site.fromData(row.data, db),
        );
      }).toList();
    });
}

I am not getting any result

@simolus3

Can you please be more specific with "I am not getting any result"? Are you getting an empty list? Is the stream not updating as you'd expected? Do you get an error?
One potential issue is that you're not including all tables in readsFrom: The set should contain all tables your query reads from, including the joins.
Also, be aware that moor uses snake_case column names in sqlite for camelCase column getters in Dart. For instance, if you had an IntColumn get onlineId => ..., the column name in sqlite would be online_id. If you want to write raw sql queries, I recommend to get them checked at compile time.
In the snippet you posted, I'm wondering why you wouldn't just use the Dart query builder? It should support the query you're trying to run and takes care of all of this automatically.


foot: 1.15.1 -> 1.15.2

https://codeberg.org/dnkl/foot/releases/tag/1.15.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 246561 run on x86_64-linux 1

3 packages failed to build:

foot
foot.terminfo
foot.themes

Result of nixpkgs-review pr 246561 run on x86_64-linux 1

3 packages built:

foot
foot.terminfo
foot.themes


Document fingerprint under usage

https://docs.getsentry.com/hosted/clients/javascript/usage/

This is here? You added it last year: 38ef00eb86dfd9d9ad35313b567fe6a579ebf062


feat(amplify-app): group amplify files in xcode integration

Notes:

change amplifyxc.config to amplifytools.xcconfig to match standard
xcode config files extension
create an Xcode group called AmplifyConfig and add all
config-related files

amplifytools.xcconfig
amplifyconfiguration.json
awsconfiguration.json
schema.graphql

create an Xcode group called AmplifyModels and add the generated
models to it and also as project source files
files are added as references and not copied, so updates to the
original files are automatically reflected

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

These changes make sure that the Xcode project will have the generated files added and grouped correctly.
There's a PR on the iOS repo to leverage this changes: https://github.com/aws-amplify/amplify-ios/pull/445

@nikhname should we move the config file for push under this new AmplifyConfig directory? That way it keeps project root clean.

@nikhname should we move the config file for push under this new AmplifyConfig directory? That way it keeps project root clean.

no need, the AmplifyConfig and AmplifyModels are not actual folders. They are just logical Xcode views to group things.


Web push book

Still needs reviewing but here's the initial commit.
cc @petele @PaulKinlan @addyosmani

@gauntface - can you add redirects in _redirects.yaml that redirects the deleted files to an appropriate new place?

@petele done :)

@petele I'll get around to this when I can.
Sadly a lot of this is auto - generation issue with WF has 100 character line limit and a code can't be set with <Code Here>.
Will jiggle with output when / if I can.

What is <Code Here>?

Lol Github converted the syntax  - Three Backticks  Three Backticks

@petele this is everything clean from Web Push Book to Web Fundamentals (I.e. it's a complete copy and paste from the output of web-push-book to web fundamentals).
The changing of Service Worker to devsite link and the changing of '> ' to 'Note: ' I'll do manually - but will be a manual task if anyone updates this in the future.

@petele just a gentle nudge ;)

FYI. GitHub is showing some of my requested changes 'outdated'. Be sure to click 'Show outdated' when you see it.

I've now edited all the new content. The ball is now squarely in Matt's court.

@petele @jpmedley anything else you want from me on this?

If @jpmedley is happy, then I'm happy.


Kafka topic UI: System vs non-system topics

Not sure if there's a more technical meaning, but I see:

non-system: _schemas, connect-status-01
system: connect-configs-01, connect-offsets-01 (and __consumer_offsets, which is clearly system)

I think all connect should stay together, and possibly _schemas could go into system?

Hi @ecesena,
Thanks for pointing this out. I think the initial intention was that we have custom views for these 2 topics, but this has been removed now, so I will discuss with the team whether we need to bring them back to system topics.
Could you open the ticket in kafka-topics instead so that I can close it from here?
(https://github.com/Landoop/kafka-topics-ui/)
Thanks

Thank you @chdask. Done. Closing this now.


Support for HiDPI displays

On a 3840x2160 laptop display the application does not honour window scaling resulting in the application text being too small to be readable.

I have tested this on Ubuntu Gnome 15.10 with the following HiDPI settings:
Tweak Tool : Windows->HiDPI->Window scaling = 2
dconf editor: org.gnome.desktop.interface.scaling-factor = 2

Hi.
I found this discussion on stack overflow: http://stackoverflow.com/questions/15659044/how-to-set-the-dpi-of-java-swing-apps-on-windows-linux
It suggest to use system look and feel. Unfortunately there is no option to configure layout. You can configure system layout in OLV configuration file or just remove  looks-2.2.0.jar.
pinny73, can you remove  looks-2.2.0.jar  and try to run application?

Hi,
I tried removing the looks-2.2.0.jar and it didn't make any difference to the scaling.
Cheers
Chris

Chris, can you post screenshot?
śr., 9 mar 2016, 03:16 użytkownik pinny73<EMAIL_ADDRESS>napisał:

Hi,
I tried removing the looks-2.2.0.jar and it didn't make any difference to
the scaling.
Cheers
Chris
—
Reply to this email directly or view it on GitHub
https://github.com/otros-systems/otroslogviewer/issues/367#issuecomment-194073378
.

On Linux, going to Preferences > Appearance and switching the "Look and feel" option to "GTK+" did the trick. I'm far from saying it's looking good, but it's "readable" now.


Flash image size exceeding flash physical size, writing canceled..

im having a problem writing the hex file to a CC2531 the file im writing via a CC Debugger tool isCC1352P2_CC2652P_launchpad_router_20220125.hex and the CC1352P2_CC2652P_other_router_20220125.hex files.
CC debugger is green (was red before I plugged in the CC2531)
CC2531 is also in the USB port
OS is Mac (installed CCTool via Brew)
Undated Brew this morning as I had a file issue.
ive refreshed the default firmware and that works.
I want to make the CC2531 into a Router to help the range of an installation.
ive attached the log files for helping in this.
please understand this is my first ever issue raised, so if ive made a silly error please excuse me
cc-tool.log

You're trying to flash CC262/CC1352 firmware on a CC2531 which doesn't work.
You need to flash CC2531 router firmware from https://github.com/Koenkk/Z-Stack-firmware/tree/master/router/Z-Stack_Home_1.2


Question for Implementation of Main Equation

First of all, thanks for your great work, I'm very impressed with your work.
However, I wonder for the difference between the main equation and source code for the guidance
In Equation 10 of the main paper,
guidance \eps = \eps + guidance scale * (\eps - \bar eps)
\eps is normal output , which can be conditional or unconditional output
\bar eps is pertubed output by mask or identity matrix.
However, In your code you reproduce this equation
guidance \eps = \bar eps + guidance scale * (\eps - \bar eps)
from gaussian_diffusion.py line 1004~1005
Could you give me a answer why it is different?
When I replace the current code with the same code with paper, it cannot reproduce the original results.

Hi, thanks for your interest in our work.
You are right. The implementation is a bit different from the equation (10) in the paper.
But as you know, it is linear combination between \eps and \bar eps so you can the original results when using guidance_scale = s + 1.
I'm sorry for the confusion from mismatch between the implementation and the eq in the paper. We just followed the original codebase but It would have been better to keep the notation consistent with the paper.


[FLINK-4277] Fix TaskManagerConfigurationTest#testDefaultFsParameterLoading

This PR fixes the TaskManagerConfigurationTest#testDefaultFsParameterLoading by creating a proper flink-conf.yaml file and passing the correct --configDir parameter.
Previously, the generated yaml had a random name (<random UUID>.yaml) even though it should be called flink-conf.yaml. In addition, the --configDir parameter was set to the file name, and not directory it resides in.
I don't know why this test did not fail earlier; maybe @mxm has an idea as he recently did some work on the GlobalConfiguration.

Thanks for the PR @zentol.
The test didn't fail because the exception is swallowed in a catch block:
		} catch (Exception e) {
			e.printStackTrace();
		}

It has to be changed in this PR to not swallow exceptions.

@mxm addressed your comments

good catch, thanks!
+1 to merge this

merging


Cmake support + Fix errors on windows

Hi,
First of all, thanks for the great library.
I wanted to try your project on Windows + MSVC2019. I thought that having a minimum CMake configuration file would help to other people try quickly your project. Since I had to do it to test it myself, I decided to contribute with this tiny patch.
I also experienced 2 errors during the compilation that I had to fix.

Hi @piponazo , thanks a lot for your support!!


[BEAM-12595] Add a dep in maven archetype example for Flink runner

This word count example generated by mvn archetype currently fails to run on a Flink runner without this dep.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@kennknowles

@ibzib Thanks for the comment. I'm not sure what EMR is. I came across this while trying the example on Google Cloud Platform Dataproc with Flink.
https://cloud.google.com/dataproc/docs/concepts/components/flink#running_apache_beam_jobs
A broader fix will be nice. Anything I can do to help get that one unblocked?

Coincidentally, I see Spark runner listed a couple Jackson deps in the same file, which makes me think that this fix is probably okay to be accepted.
https://github.com/apache/beam/blob/7f1993468e61122c48e4087d2f36a3cf56c6d54e/sdks/java/maven-archetypes/examples/src/main/resources/archetype-resources/pom.xml#L256-L261

Thanks for the feedback Tianzi.

@ibzib Thanks for the comment. I'm not sure what EMR is. I came across this while trying the example on Google Cloud Platform Dataproc with Flink.
https://cloud.google.com/dataproc/docs/concepts/components/flink#running_apache_beam_jobs
A broader fix will be nice. Anything I can do to help get that one unblocked?

EMR is Amazon's cluster manager, similar to Dataproc on GCP. If the problem is happening to you on Dataproc, it shows the problem is obviously not with EMR.

Coincidentally, I see the Spark runner also lists a Jackson dep in the pom file, which makes me think that this fix is probably okay to be accepted.

If we define the dependency in the runner itself, we shouldn't need to define it in the example POM as well. So I'm guessing that dependency is redundant and can be removed. https://github.com/apache/beam/blob/7724cfe900dd99ba651a62c976b51b486eb69885/runners/spark/spark_runner.gradle#L169-L173

What is the next step on this PR?

What is the next step on this PR?

I'm fine with merging this, but it only solves the issue for the wordcount example, so we will need to keep investigating a more general solution.

What is the next step on this PR?

I'm fine with merging this to fix the word count example, but we should continue looking for a more general solution.

But on second thought, we may want to root cause where the conflict is coming from first, otherwise it's possible this could introduce problems in other environments.


No descriptions for audio files

Description

We are not currently collecting descriptions for audio files in the Catalog DB, nor exposing this field in the API. We should!
Resolution

[ ] 🙋 I would be interested in resolving this bug.

@zackkrida should we bump this down to medium priority given the blocking issue in the catalog is medium?


SOLR-16260: Add support for Instant, LocalDate and ZonedDateTime to JavaBinCodec

https://issues.apache.org/jira/browse/SOLR-16260
Description
Adds support for Instant, LocalDate and ZonedDateTime to JavaBinCodec.
Solution
Instant, LocalDate and ZonedDateTime are converted to epoch millis and stored as type DATE in the serialized bytes.
Tests
I've added a test to TestJavaBinCodec, which tests that all three classes can be serialized and deserialized and return a Date with the same time as the input.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

@sgift this looks clean and simple! Thanks for the contribution 🙂

@sgift We have started auto closing stale PRs. This one looks very useful and is very targeted and small too. Is there energy to re-open and finalize the last review comments and get it merged before Solr 9.8?


cfo: vopr no longer hangs

Currently vopr hangs in the CFO. This due to the classical bug of systems programming: VOPR logs to the stderr, but no one reads the stderr, so it fills up and then the process deadlocks.
Good news is that we have a fix for these classes of programs: shell.zig intends to wrap raw child process spawning API in a set of well-defined high-level operations, which are protected from these kinds of footguns.
The bad news is that the actual API there is buggy, and defaults to piping by default. Fix this and make each caller that wants to interract with the streams explicitly request that.

This is super funny! I literately had two bugs in mind when creating shell.zig:

failing to check process status after try wait
failing to concurrently drain both stdout and stderr when spawning an interactive program.

One does not simply not step on a rake!


macos platform attributes regression

fixed !decorations case and refactored logic to be a little easier to
read

I tested this with all the permutations of .with_decorations and platform attributes that make sense.
@edwin0cheng can you take a look?

Do we need to handle pl_attrs.titlebar_transparent = true here ? Or do i miss something ?

@edwin0cheng nice catch, I missed that the close button was broken. I had accidentally duplicated NSMinitiaturizableMask instead of including NSClosableMask. This should now be fixed. I've tested with all the combinations.
titlebar_transparent is handled later on L704. It's a little weird, because generally you would want to use that with fullsize_content_view, but since we offer those separately, I figured it's up to the consumer to use those together.

@edwin0cheng to be clear, I believe it is now the case that the final else arm of the conditional represents the default case.

to be clear, I believe it is now the case that the final else arm of the conditional represents the default case.
Maybe we could add a comment to describe that.

Anyway, Look good for me, I tested other weird cases, couldn't find any bugs too.

@edwin0cheng added that comment, thanks for testing!

@francesca64 sorry about the churn on this issue, but I think this is good to merge now.

@edwin0cheng thanks for reviewing this!
@sodiumjoe you have nothing to apologize for. The logic is a lot easier to follow now, so I'm happy.
Thinking more about releases, I've noticed that the changelog is already getting pretty long. I think it would make sense to cut another release around the end of the week.

@francesca64 sounds great, thanks!


Add text in Our Services

I want to add text in the 'Our Services' section like a real website.

@codervivek5 Please assign this issue to me under GSSoC'23.


update codes and add gtest

Add WFT_STATE_POLARIS_SERVER_ERROR	= 1006 which refers to the same ReturnCode in defs.h .


"Unrecognised argument(s): force" for comms/pt/comms_utils.py

https://github.com/facebookresearch/param/blame/main/train/comms/pt/comms_utils.py#L1734
Traceback (most recent call last):
  File "./comms.py", line 1405, in <module>
    main()
  File "./comms.py", line 1362, in main
    collBenchObj.checkArgs(args)
  File "./comms.py", line 239, in checkArgs
    super().checkArgs(args)
  File "/myworkspace/param/train/comms/pt/comms_utils.py", line 1734, in checkArgs
    force=True,
  File "/opt/conda/lib/python3.7/logging/__init__.py", line 1919, in basicConfig
    raise ValueError('Unrecognised argument(s): %s' % keys)
ValueError: Unrecognised argument(s): force

@amathews-amd - thanks for reporting this issue, this argument  option is only supported for python3.8+. If possible, please use python 3.8 or later to unblock your work for now, we will fix it soon.


Newbie question

Thank you very much for this great application. I have it running now for half a year and it is my only profitable bot :)
Could I please ask a few questions:

What is the reason behind a MINIMUM and a MAXIMUM purchase amount? Why not a single purchase amount? What does the difference between minimum and maximum do? Is it sensible to set it to just 20 and 20 BUSD or does 20 and 50 make a difference or does it just choose closest to 50 then?
Does the "Force sell at the market price when recommendation is Neutral/Sell/Strong Sell and the profit is between 0 to trigger price" still work when you are using multiple grids for sell and it has already gone through the first grid of sell? I seem to get a message then that it needs to wait for a grid sell that already occurred?
Am I correct to assume that the TRAILING of buy/sell does not work when then stop/limit percentage is higher than the trigger percentage?

Thank you so much!

Sorry for the late reply.

What is the reason behind a MINIMUM and a MAXIMUM purchase amount? Why not a single purchase amount? What does the difference between minimum and maximum do? Is it sensible to set it to just 20 and 20 BUSD or does 20 and 50 make a difference or does it just choose closest to 50 then?

If you set the minimum/maximum purchase amount, then the bot will place an order with an amount between 20 and 50.
For example, if your quote asset balance is less than 20, then it won't place an order.
Or if your quote asset balance is more than 50, then it will only place 50.

Does the "Force sell at the market price when recommendation is Neutral/Sell/Strong Sell and the profit is between 0 to trigger price" still work when you are using multiple grids for sell and it has already gone through the first grid of sell? I seem to get a message then that it needs to wait for a grid sell that already occurred?

If your grid sell is executed, then your balance will be close to 0, if your sell grid is configured to sell 100%. Then the bot will try to remove the last buy price.
What do you mean by I seem to get a message then that it needs to wait for a grid sell that already occurred?

Am I correct to assume that the TRAILING of buy/sell does not work when then stop/limit percentage is higher than the trigger percentage?

Sorry, hard to understand your question. What exact scenario are you talking about?


AV False Positives (Malware, Riskware, Adware, Virus, Trojan and other BS)

After reinstalling Windows and configuring Bluetooth, MS Defender removed it after identifying it as malware (I didn't have time to add it to a whitelist)
Please figure out why it's happening and get it signed now. Even if it's free, some people might not like using it because it might scare them or be taken off their computers.

I am unable to download it unless, of course, if I disable MS Defender

I can't afford a signing certificate so it's bit going to happen. You are free to validate it's not dangerous as source code and build pipelines are completely open and transparent.

I can't afford a signing certificate so it's not going to happen. You are free to validate it's not dangerous as source code and build pipelines are completely open and transparent.

What is the cost of a signing certificate?

It's about $1.5k for 3 years. Could be less if you shop around. But that won't solve false AV issues, you can still be banned and certificate revoked for no reason. I think realistically one needs a legal team to deal with AV false claims which I apparently don't have. I'd recommend having a read:

https://weblog.west-wind.com/posts/2016/Oct/05/Dealing-with-AntiVirus-False-Positives
https://www.autohotkey.com/boards/viewtopic.php?t=87322
https://steamcommunity.com/app/779590/discussions/0/2572002906839928114/
https://help.steampowered.com/en/faqs/view/5F3D-1477-AFF9-C4F3
https://www.linkedin.com/pulse/kaspersky-reasons-false-positives-amirabbas-mahdavi
https://www.gdatasoftware.com/blog/2022/06/37445-malware-detection-is-hard
<EMAIL_ADDRESS>
And by the way, the last BT version (3.5.0) has only a single AV's claim out of 90, unlike 29 out of 90 for version 3.4.0, so it's totally random trash. I've myself became very pessimistic about usefulness of AV software in general after dealing with this.

Kaspersky and Sophos both left BT undetected for me, seems it might be a Microsoft specific issue.

it's totally random and changes daily ;)

Same thing here, BT 3.5.2 was flagged by Microsoft Defender as PUA. It's possible to send files to Microsoft for further analysis: https://www.microsoft.com/en-us/wdsi/filesubmission/ – I urge you to do it if you are affected.

Same thing here, BT 3.5.2 was flagged by Microsoft Defender as PUA. It's possible to send files to Microsoft for further analysis: https://www.microsoft.com/en-us/wdsi/filesubmission/ – I urge you to do it if you are affected.

I have used this before, and just submitting for latest version as "incorrectly identified as malware". Will let you know on progress:

Analysis on above is still pending but some detections have already cleared out.

It keeps getting deleted even when excluded from scans... I have to reinstall it every few days.

There are 2 different .zip files.  A pdb version which downloads fine and non-pdb version that doesn't.  What's the difference between the 2?

There are 2 different .zip files. A pdb version which downloads fine and non-pdb version that doesn't. What's the difference between the 2?

.pdb version is debug symbols to investigate crashes, you don't need that.

It keeps getting deleted even when excluded from scans... I have to reinstall it every few days.

You can permanently allow the "threat" until MS investigates. There are instructions available here.

Windows Defender should now be fine, just got analysis results from Microsoft:

Also VirusTotal before and after (Microsoft AV is OK now). Hopefully others will follow the suit.

It keeps getting deleted even when excluded from scans... I have to reinstall it every few days.

You can permanently allow the "threat" until MS investigates. There are instructions available here.

I have been doing that since the start, but it doesn't stick. That's why I notified you that currently it is allowed and working properly, but it crashes when trying to find updates... I am simply informing you of this, but it is alright if you are unable to resolve these.

@neoOpus thanks. Update checks are already fixed and will be out in v3.6. Defender does not block it anymore.

@jnv thanks for that, I also raised request with ESET which has reclassified as clean.

@jnv I have raised Avast issue separately yesterday, and classification is cleared completely.

Also submitted a dispute to McAfee now.

And just for fun to Malwarebytes.

So far, it worked and I didn't have any issue :)

Unfortunately we're back to 24 false positives for the v3.6.2 installer. Today even Microsoft Defender took down my locally compiled version.

Microsoft seems to be happy, but others are not. It will help in long term to vote on VirusTotal community webpage: https://www.virustotal.com/gui/file/7273f03b70a07ab0e1cf96aa4702587ea850b72efbdeef4690bf44bb3edd295b/community

AVG and Avast were great help in whitelistimg 3.6.2, we are -2 now.

14/61 today!

18 on the .zip version

Down to 11 today:

10 today.

https://www.virustotal.com/gui/file/9a6a86a90c1c68423465a4b800f4f2941a92e1f82ed9ea0f4dfb58a641932cef/details

It seems Microsoft doesn't like the latest version as it has been automatically removed from my PC by Windows Defender.

Same here, looks like Microsoft needs a ticket for every new version to allowlist it again.

Also this is odd, because VirusTotal only reports 4 hits from "bad" AVs

Yeah, but it would be also super slow and at least x100 bigger in size of downloads and ram.

It seems Microsoft doesn't like the latest version as it has been automatically removed from my PC by Windows Defender.

Not only the latest, also 1 or 2 previous - it broke, I installed newer one (deactivated the antivir) but at some point it reactivated... It actually breaks opening links if BT is set as default handle for hyperlinks. Typical Microsoft -.-
Can we whitelist it manually? Or do we need to do that for every version as well?

From what I understand from this talk about Windows - BlueHat IL 2023 - David Weston - Default Security
https://www.youtube.com/watch?v=8T6ClX-y2AE : maybe turning in UWP and converting msi to MSIX can make help against AV 🤓. One of the issues was mentioned is "over privileged apps".

I downloaded version 4.0.2 today
Viirus total shows a result of 21/73
https://www.virustotal.com/gui/file/68d876a6afb7d9bef7b1b1e1ebe32eea68ce7bd83f4c56c216cc25c0a90e3d4a
It's starting to make you think
:(

Please finish your thought ;)

I downloaded version 4.0.2 today Viirus total shows a result of 21/73 https://www.virustotal.com/gui/file/68d876a6afb7d9bef7b1b1e1ebe32eea68ce7bd83f4c56c216cc25c0a90e3d4a It's starting to make you think :(

Browser Tamer by design needs to intercept links to work, this sometimes sets off the real time behavioral analysis of AV engines, when triggered most AVs will decided if it's malware based on reputation and manual review, obviously Browser Tamer is a small project with not a lot of users in the grand scheme of things, so the reputation is going to be low. Microsoft has already whitelisted versions of Browser Tamer after being submitted for manual review.
Browser Tamer releases are built using GitHub Actions, and of course you can build it yourself too.

Please finish your thought ;)

I choose consciously and accept the possible risks, but others, seeing the scale, may give up at the very beginning

Latest build has 2 warnings instead of 21, so it's totally random

If anyone knows how to contact "Sangfor" (chinese company) to submit false positive report please let me know.

Have you tried using the website: https://www.sangfor.com/about-us/contact-us
?
I'll add right away that I just looked it up on the Internet, I haven't used it myself

Thanks @dmocha, trying this one.

Unfortunately that didn't work - no response for a week or so. However, after a lot of comms with various AV providers I have managed to reduct VT to only 1 (Sangfor):

Unfortunately that didn't work - no response for a week or so. However, after a lot of comms with various AV providers I have managed to reduct VT to only 1 (Sangfor):

Maybe they will be more responsive if you contact them via their social media (https://x.com/SANGFOR)

@neoOpus seems like you have to be a premium user to contact them in the eX-twitter.

I tried but maybe it is just like you said... I will keep you updated if they reply

this is THE FIRST TIME we have ZERO virus detections! I'm not sure what you did @neoOpus but it seems to have worked!

👍
Indeed, the bt-4.1.2.zip archive is "clean".
I just checked this archive
Now it would be useful to do the same with the bt.exe file
Because the file sent to VT indicates two threats:

Link:
https://www.virustotal.com/gui/file/7908c83bdbf21dc49c9f8f8b644cec36f806d65b57792eb54faeb97c3d3c7cb4?nocache=1

@dmocha only Chinese AV companies seems to complain ;)

4.2.0


Update Slurm Controller documentation to point to version 5.7.2.

Slurm Controller documentation points to 5.6.3, but it should now point to 5.7.2.
Submission Checklist
Please take the following actions before submitting this pull request.

Fork your PR branch from the Toolkit "develop" branch (not main)
Test all changes with pre-commit in a local branch #
Confirm that "make tests" passes all tests
Add or modify unit tests to cover code changes
Ensure that unit test coverage remains above 80%
Update all applicable documentation
Follow Cloud HPC Toolkit Contribution guidelines #

/gcbrun


[ADDON] - Grafana Tempo

Add support for Grafana Tempo as an add-on.
Ref: https://github.com/grafana/helm-charts/tree/main/charts/tempo
Other implementations:
https://github.com/grafana/helm-charts/tree/main/charts/tempo-distributed
https://github.com/grafana/helm-charts/tree/main/charts/tempo-vulture

thank you for the issue - at this time we will not be adding this implementation to the project. if you wish to use Grafana Tempo you can utilize the helm_release resource to add support in your environment


Container can't be dragged

Sorry for bothering you again.
I edited your first demo example so that the right container is inside the left one. The drag and drop function works perfectly but the container won't be dragged. The container moves up if I'm dropping items below it but it won't come down again since I can't drag it. Do I have to edit something or maybe this will be in the future release?
I don't have any advance experience in Javascript so I don't really know how your code works.
Thanks for the answer.

I'll need a demo

I Edited some your demo codes. The right1 is inside the left1

If you try to drop me somewhere.

Move me, but you can only drop me.

Item 6.

Item 5.

You can drop me in the left container, otherwise I'll stay here.

Item 4.

Item 3.

You can only move immediate children of a container by design

@decaller Having nested containers with dragula is possible, you just have to make sure that there is:

a part of the nested container that you can drag (using padding in my example)
a bit of code in accepts that prevents dragula from trying to use the dragged container as drop target (it works by default, but throws exceptions).

Here's a quick demo:  http://jsfiddle.net/cfenzo/7chaomnz/

@cfenzo Thank you for the hint dragula can deal with nested containers! And for your fiddle about the accept handler and node.contains() DOM method!

To prevent the "Uncaught HierarchyRequestError: Failed to execute 'insertBefore' on 'Node': The new child element contains the parent." error, just make the selected element's shadow reject all mouse events:
.gu-transit {
pointer-events: none;
}

@Syforce  THANK YOU! THANK YOU! AND!!! THANK YOU!!!


use fairseq with lora

is there an easy way to use this together with lora? I didn't find anything in the docs

fr!


Modeling Confidence in XDM Data

Based on a conversation with @nangia: a key aspect of digital marketing is that the identity of the consumer is largely probabilistic. Whether products make it explicit or not, the data that we have about a consumer is messy, and largely untrusted. A profile is typically constructed from multiple data sources, including:

direct user input (although users regularly enter false information in online forms)
inferred from user behavior (with implicit inaccuracy)
acquired from third-party data sources (with implicit inaccuracy)
through rule-based or probabilistic merging of profiles (with explicit inaccuracy)

Therefore, a system that represents consumer profiles in a digital marketing world needs to be able to express the inaccuracies, eventual contradictions, and missing data that occurs in the real world. This is a key differentiator from the way how collaboration systems or CRM systems look at the world (they have an inherent assumption of clean data).
We need a way to express these scenarios in JSON.
What are the schemas that are affected by the issue

Profile

What are examples of products that are impacted by the issue

Adobe Target
Adobe Analytics
Adobe Audience Manager
Adobe Media Optimizer
Adobe Social

We need to have a more specific driving use case rooted in practical terms before we invest in designing this. Many aspects of non-deterministic identity resolution are at the implementation and usage context level. So may not appear in XDM, but is data usage patterns.


Integrate with a CI solution

Let's see about bringing in a free Continuous Integration solution for automating our unit tests, such as:

Circle-CI
Travis-CI

Documentation for integrating pytest and tox in with these tools:

Circle-CI
Travis-CI

We have successfully integrated with Circle CI! We will discuss if we want to also add a Travis-CI integration or if we want to close out this issue as completed.


Overlay optimization: draw only when relevant

Issue Type

[x] Improvement
[x] Performance

Description and/or steps/code to reproduce the problem
In DefaultOverlayManager.onDrawHelper, in a loop we draw all the Overlays.
Sometimes, drawing an Overlay is expensive (e.g. Polylines).
Sometimes, it's not that expensive but still, we don't waste time when we avoid the actual drawing if it's not relevant, especially if we've got tons of Overlays (e.g. Marker).
It would be nice to just compare the bounding boxes of the map and of the Overlay, but it doesn't take into account:

the map orientation
the Overlay size (for a Marker, the icon size modulo the anchor) or the strike width (for Polyline)

A solution would be to consider that both the map and the Overlay are like disks, and that it's relevant to display the Overlay only if the disks overlap / the distance between the centers is lower than the sum of the radiuses.
This solution would display only relevant Overlays, and sometimes Overlays that shouldn't be there (but that's not a big deal in first approach).
There could be a special cases for orientation == 0, with faster implementation.
Anyway, the actual check must be very fast to execute.
I guess the implementation of the relevancy check depends on each Overlay class.
The most important classes to focus on are Polyline and Polygon, with their heavy drawing.
Environment
Version of osmdroid the issue relates to:
6.1.5

I've just found an elegant way to handle the case for Polylines and Polygons.
I'll PR soon.

Done for PolyOverlayWithIW in #1465. I guess this can be done for each Overlay, if relevant.


Improve JavaScript examples and add chapter for npm and ESM

Fixed variable access to the emscripten module (verovio.module instead of Module). Also see https://github.com/rism-digital/verovio/pull/2937.
Removed unnecessary async function
Added chapter for npm and ESM examples

I'm not sure if the new chapter belongs into the "first steps" section. English is not my native language, so I would be grateful if someone would briefly proofread.

I am going to merge it and make the changes myself


Neighborhood Maps Seem to be broken

Hey there!
So my real estate agent recommended that we use Durham Hoods to scope out the area, but it looks like the neighborhood data is broken - "A map will appear here."

Anyways, not sure if it's still maintained at all or if you'll get this, or if this is the right place, but just wanted to let you know.  Also if you need a hand with maintenance, let me know.
Thanks!

Hi Hunter, thanks for this note!
I'm actually shocked to see durhamhoods.com still live considering I sold the domain many years ago and have not kept the project going. Whoever bought the domain (I can't even remember now) must've valued the idea of the map having a home even if they didn't plan to keep it updated. Considering the fact that the map still exists here on github and (in my opinion) a much more superior resource that I contributed to minorly called the Durham Neighborhood Compass, I had no issues walking away from the domain when I did.
Hopefully you'll find the following resource more helpful. The map can be segmented into blockgroups or neighborhoods (as I drew them about a decade ago). Here is the Omah St neighborhood as a starting point:
https://compass.durhamnc.gov/en/compass/LUDIV/blockgroup?selectGroupName=Omah Street&selectGroupType=Neighborhood


Initial attempt at adding terraform infrastructure

This was copied and adapted from the dandi/dandi-infrastructure repository.

@AlmightyYakob, can we merge this PR?

@AlmightyYakob, can we merge this PR?

Yes


Correlation log for precise message tracing on Join/Split node

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Proposed changes
For precise tracing for nodes which splitting or joining the messages, these nodes should emit a correlation log to provide information of which message is depend on another message.
This PR add a new correlate metric event to Join/Split node.
For detailed information, see design note (not yet merged).
Checklist

[x] I have read the contribution guidelines
[x] For non-bugfix PRs, I have discussed this change on the forum/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Thanks for this @k-toumura
It would be helpful to have some unit tests for this new logic as it is quite complicated and could get broken if we are not careful in the future.


Add fetch_server_status/1

This adds WebDriverClient.fetch_server_status/1 as a high-level API and the following low-level APIs:

WebDriverClient.JSONWireProtocolClient.fetch_server_status/1
WebDriverClient.JW3CWireProtocolClient.fetch_server_status/1

This function is will provide a helpful way to check to see if a webdriver server is online yet.

This is cool, I didn't even know this endpoint existed. One of the reasons right now I'm using selenium instead of chromedriver / geckodriver directly is that selenium takes care of this kind of stuff.

@michallepicki I'd like to have wallaby call this endpoint when starting up phantom or chromedriver so we can be sure the server is ready to go be for we start sending requests to it.


[HOLD for payment 2023-06-28] [$1000] Web - Chat - Inconsistent parsing upon wrapping mentioning message with link

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open staging.new.expensify.com
Send this message to a chat<EMAIL_ADDRESS>Send this message to a chat<EMAIL_ADDRESS>
Expected Result:
Both message should consistently either changed into link or mention
Actual Result:
While mentioning message without styling turned onto URL, mentioning message with styling turned onto mention-like message, but when clicked turned to be URL as well, and could cause confusion for the user
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/971470bc-86ed-47f8-9615-945ff3bee0cf
https://github.com/Expensify/App/assets/93399543/2409628e-85e7-4497-aabb-5e5a37dde9c4
Expensify/Expensify Issue URL:
Issue reported by: @kerupuksambel
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685404731770449
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01934ef45479ce0794
Upwork Job ID:<PHONE_NUMBER>110015488
Last Price Increase: 2023-06-12

Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistent parsing upon wrapping mentioning message with link. For example
[@test@gmail.com](google.com)

is rendered as user mention but input
[*@test@gmail.com*](google.com)

is rendered as user mention. Both cases shouldn't render user mention.
What is the root cause of that problem?
First, we apply markdown-link-to-html rule to the input
[*@test@gmail.com*](google.com)

and output following html converting bold syntax of the link text at the same time inside method modifyTextForUrlLinks
<EMAIL_ADDRESS>
Second, the userMentioins-to-html rule is unexpectedly applied to the output anchor tag above.
So the root cause is that the regex of user mention
new RegExp(`[\`.a-zA-Z]?@+${CONST.REG_EXP.EMAIL_PART}(?![^<]*(<\\/pre>|<\\/code>|<\\/a>))`, 'gm'),

matches<EMAIL_ADDRESS>inside the text of anchor tag
<EMAIL_ADDRESS>
We have a negative lookahead group, the ending group (?![^<]*(<\\/pre>|<\\/code>|<\\/a>)), that possibly skip to match the user mention<EMAIL_ADDRESS>inside the anchor tag.
The ending negative lookahead group (?![^<]*(<\\/pre>|<\\/code>|<\\/a>))  doesn't match string
<EMAIL_ADDRESS>

So, the ending negative lookahead group can't skip to match the user mention<EMAIL_ADDRESS>wrapped by strong tag inside the anchor tag.
What changes do you think we should make in order to solve the problem?
To fix this issue, we can improve the ending negative lookahead group (?![^<]*(<\\/pre>|<\\/code>|<\\/a>)) of the regex of user mention to skip  , ,  and code tags inside the  tag.
We can use a new ending negative lookahead group
(?!((?:(?!<a).)+)?<\\/a>|[^<]*(<\\/pre>|<\\/code>))

where includes two alternative subgroups inside it, ((?:(?!<a).)+)?<\\/a> and [^<]*(<\\/pre>|<\\/code>).
The first alternative group ((?:(?!<a).)+)?<\\/a> is responsible to fix this issue. It works as follows

If we find substring <a before substring , then we assume that the matched user mention is not inside  tag
If we find substring  before substring <a, then we assume that the matched user mention is inside  tag and skip this match

See regex test screenshot

So the new regex of user mention will be
new RegExp(`[\`.a-zA-Z]?@+${CONST.REG_EXP.EMAIL_PART}(?!((?:(?!<a).)+)?<\\/a>|[^<]*(<\\/pre>|<\\/code>))`, 'gm'),

By doing so, input
[*@test@gmail.com*](google.com)

is translated into html not rendering user mention syntax
<EMAIL_ADDRESS>
and won't break existing unit test cases of Expensify-common lib.
The regex of @here rule have similar issue, so we can apply same fix to it as well.
What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
User mention inside a link is parsed inconsistently.
For example:
<EMAIL_ADDRESS><EMAIL_ADDRESS>What is the root cause of that problem?
As you can see below, user mention cannot be parsed when it's inside any html tag.
    regex: new RegExp(`[\`.a-zA-Z]?@+${CONST.REG_EXP.EMAIL_PART}(?![^<]*(<\\/pre>|<\\/code>|<\\/a>))`, 'gm'),

The main reason of this issue is that we parse link before parsing user mentions
What changes do you think we should make in order to solve the problem?
We can solve the issue by simply changing the rule order.
Put the user mention rule and here mention rule before the email rule

Result
https://github.com/Expensify/App/assets/126839717/5c91bce5-c47d-43cb-96fb-e6ff4ab29932

What alternative solutions did you explore? (Optional)

I wasn't able to reproduce

I even tried copy/paste for<EMAIL_ADDRESS>and _<EMAIL_ADDRESS>And did not have the same outcome as the issue states

I even tried copy/paste for<EMAIL_ADDRESS>and _<EMAIL_ADDRESS>And did not have the same outcome as the issue states

You need to try with
[@concierge@expensify.com](https://google.com/)
[_@concierge@expensify.com_](https://google.com/)

Hi @abekkala , I think the reproduction steps is not clear enough. We should use underscore _ to wrap the text part of the link to reproduce it. For example we can use below input
[@concierge@expensify.com](https://google.com/)

Only wrap the text part of link
[_@concierge@expensify.com_](https://google.com/)

to duplicate it, see demo video
https://github.com/Expensify/App/assets/117511920/db9225d8-4a7f-4016-9d4f-135ed9e020cd

@abekkala I can still reproduce it. I think we should reopen this issue.
I would also cc @puneetlath as you're most familiar with the mention feature.

Hm, yes if it's still a bug then let's fix.

Proposal
Updated

@s-alves10 Thanks for the proposal. You RCA is not really correct, if it was this issue wouldn't even exist but I see you updated your proposal recently so I assume the RCA is outdated. As for the fix I guess it would work but it's better not to match the regex at all rather matching and rejecting, or even better avoid any regex changes by altering the order of rules if possible (same note given above).

@s77rt
Yes, I suggested as follows at first
We can solve the issue by simply changing the rule order.
Put the user mention rule and here mention rule before the email rule

But I thought mention-user parsing has some problems and needs to be fixed. In addition, changing rule order may have other issues. That's why I changed the solution.

@s-alves10 Thanks for the update. I have checked the order of rules. The correct order should be:

Link
Mentions
Bold/Italic/Strikethrough

This is actually the current order already, except that the link rule calls modifyTextForUrlLinks which applies bold/italic/strikethrough rules and cause the mentions rule to mismatch.

@eh2077 Thanks for the follow up. I have provided some info regarding the order of rules above. I think it's indeed safer and easier to follow the same approach we did with autolink and that is to alter mentions regex as you suggested. Let's go with that.
:ribbon: :eyes: :ribbon: C+ reviewed
cc @johnmlee101

@s77rt @johnmlee101 The PR https://github.com/Expensify/expensify-common/pull/549 for expensify-common repo is ready. Please help to review it when you get time, thanks.

Not overdue. PR is merged and waiting for deployment.

Not overdue. PR is merged and waiting for deployment.

@s77rt The PR has been deployed to the production because it occasionally shared the same commit with the other PR https://github.com/Expensify/App/pull/20769. @johnmlee101 pointed it out here https://github.com/Expensify/App/pull/20767#issuecomment-1593404453.
So, actually, the payment date of this issue should be same as issue https://github.com/Expensify/App/issues/20111.
Sorry for the confusion caused!
cc @abekkala @johnmlee101

Oh right, so we have to track this one manually

PAYMENTS TO BE MADE JUNE 28

Issue reported by: @kerupuksambel [$250]
Selected Proposal for fix: @eh2077 [$1000] + [$500 PR bonus]
C+ Review: @s77rt  [$1000] + [$500 PR bonus]

@kerupuksambel @eh2077 @s77rt - contract payment offers have been sent!

@abekkala  Accepted. Thank you!

@eh2077 payment sent and contract ended - thank you! 🎉

@abekkala Accepted!

@s77rt payment sent and contract ended - thank you! 🎉

@kerupuksambel @eh2077 @s77rt - contract payment offers have been sent!

Accepted! @abekkala

@kerupuksambel payment sent and contract ended - thank you! 🎉
Closing


As a project coordinator, I want to expand and collapse reporting requirements, so that I can focus on the upcoming reports

Description:
Add a Collapse/Expand button for quarterly and annual reports
Acceptance Criteria:
Given I am editing reporting requirements (quarterly or annual reports)
When I click on the header of a closed requirement
Then the requirement expands open
Given I am editing reporting requirements (quarterly or annual reports)
When I click on the header of an open requirement
Then the requirements slides closed
Given I am editing reporting requirements
When I load the page
Then the first non-completed requirement is expanded
And all the others are collapsed
Development Checklist:

[ ] Each requirement/report should be its own react component, managing its internal open/closed state
[ ] e2e with snapshots for open and close state
[ ] Meets the DOD

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[x] User story is included
[ ] User role and type are identified
[x] Acceptance criteria are included
[x] Wireframes are included (if required)
[x] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:

@suhafa @nanyangpro do you mind making sure we have the right wireframe here?

the wireframe you've attached here is correct Pierre!

Hey team! Please add your planning poker estimate with ZenHub @matthieu-foucault @mikevespi @Sepehr-Sobhani @pbastia

Can we also apply this to milestone reports or would you like me to recreate this for milestone reports?

@matthieu-foucault: what are your thoughts - can this feature wait until after our first launch?

Looks good @pbastia and @BCerki ! I tested in dev by:

Creating a new project and adding multiple milestones, annual and quarterly reports and ensuring reports were collapsible.
Editing an existing project and adding/updating milestone, annual and quarterly reports and ensuring reports were collapsible.

Meets acceptance criteria.


GnuPG 2 dependencie

Readme says that GnuPG version 2 is a dependencie. I'm running parcimonie.sh with GnuPG 1.4.16 without facing any issues.

Just recognized that gpg version 1.x is used as default on debian (including derivatives). There are different debian packages for GnuPG version 1 and 2 (gnupg and gnupg2). gnupg installs latest GnuPG 1.x version as /usr/sbin/gpg while gnupg2 uses /usr/sbin/gpg2 for GnuPG 2.x. update-alternatives isn't used. Since parcimonie.sh defines gpg as default alias for GnuPG binary it uses GnuPG 1 as default on debian.

Are you suggesting that parcimonie.sh should try to use /usr/sbin/gpg2 first if it exists? Should be doable.

I'm not sure. Could also be done as configuration in a debian package, if one will be provided in future.

/usr/bin/gpg pas sbin !


Do not use WGS84BoundingBox for TileGrid calculation

ol.source.WMTS.optionsFromCapabilities uses WGS84BoundingBox for calculation of the tile grid if available in the WMTS capabilities (added with 6ee0d9f92702e86e97513975ba2f12a01217eeee)
There are two issues with that:

From the OGC WMTS spec: "This WGS84BoundingBox can be approximate, but SHOULD be as precise as practical."
Transforming WGS84BoundingBox back to the projection of the TileMatrixSet does not need to return  the input BBOX.

The following GeoJSON shows that the correct transformation of a BBOX is not reversible: https://gist.github.com/anonymous/2445ea91a8ac7b15bf39

So this means: use the bbox in matrix set projection if advertised, and fall back to wgs84bbox if not advertised? Can you create a pull request for that?

Ok, I dug a bit deeper into the code. The tile grid calculation seems to be right. But it fails with the assert in https://github.com/openlayers/ol3/blob/v3.10.1/src/ol/tilegrid/tilegrid.js#L131
Maybe it makes sense to build the union of both tileRanges? Not sure if this would interfere with something else...
Using the native projection first and WGS84 box as a fallback should work. Not sure how common this is though (will have to add it to MapProxy), but I'm also not sure how common correctly projected WGS84 bounding boxes are ;-)


Codiad and Git files ownership

I am trying to use codiad and git in my project, but everytime I perform the git command, everytime I commit or pull something the files get ownership changed to my current user (who used git)... then Codiad cant write that files anymore until I change the ownetships back to www-data...
Any suggestion for this??

This is not codiad related.
Chosse one of these:

Use git as user www-data
Use codiads git plugin, which runs as www-data
Change folder permissions and sticky bit on filesystem in your workspace: http://www.computernetworkingnotes.com/managing-file-system-security/sticky-bit.html


Changing Primary Key Constraint Name Causes Table Rebuild

SqlPackage or DacFx Version: sqlpackage <IP_ADDRESS>
.NET Framework (Windows-only) or .NET Core: .Net Core
Environment (local platform and source/target platforms): Microsoft SQL Server 2019 (RTM-CU12) (KB5004524) - 15.0.4153.1 (X64)  	Jul 19 2021 15:37:34  	Copyright (C) 2019 Microsoft Corporation 	Express Edition (64-bit) on Windows 10 Home 10.0 <X64> (Build 19045: )

Steps to Reproduce:

Create a new SSDT (sqlproj) project in visual studio.
Add a single table sql file like so:

CREATE TABLE [dbo].MyTable(
    Id [BIGINT] IDENTITY(1,1) NOT NULL
)
GO
ALTER TABLE dbo.MyTable ADD CONSTRAINT PK1 PRIMARY KEY CLUSTERED (Id)
--ALTER TABLE dbo.MyTable ADD CONSTRAINT PK2 PRIMARY KEY CLUSTERED (Id)

Build and deploy the dacpac to a server using sqlpackage or vs.
Uncomment the PK2 constraint and comment out the PK1 constraint. You effectively changed the name of the primary key constraint.
Build and deploy the dacpac to a server using sqlpackage or vs.
Expected: the constraint PK1 is dropped and the constraint PK2 is created.
Actual: The table is rebuilt with the message Starting rebuilding table [dbo].[MyTable]...

Table rebuilds are expensive and unwanted, especially on large tables with millions of rows. For a small change such as changing table constraints without changing any column info a table rebuild is unnecessary. It took me a while on a large table to figure out what was causing the table to be rebuilt when this was the culprit.
Attached is the project file to help reproduce.
Demo.zip
(DacFx/SqlPackage/SSMS/Azure Data Studio)

Why is this issue labeled as a bug?
Improvement?
Using rename ({Project}.refactorlog file) does not create this overhead.
Of course, it would be better if even at the final stage there were optimization heuristics, but the whole DacFx setting algorithm is already very simple and predictable.
Neither Git nor Visual Studio (Code) can track renames, but is it worth asking DacFx to do that?
There are dozens of similar optimizations, such as changing columns, when DacFx, for any inconsistency, makes the creation of a new table with data copying.

I'm not expecting sqlpackage to rename. I agree that sqlpackage should not be able to understand renames/refactors without the refactor log. What I am expecting is that sqlpackage can drop a constraint that doesn't exist in the dacpac and create a new constraint that exists only on the dacpac. The following example demonstrates this working already for unique constraints. I don't know why it's not working with primary key constraints (which is my main issue).

This produces the proper result of dropping the old constraint and creating the new one.
Dropping Unique Constraint [dbo].[unique1]...
Creating Unique Constraint [dbo].[unique2]...
Update complete.

Hi, this is happening by design, and there are multiple cases in which table recreation may happens. Though we cannot stop the table from rebuilding in such cases, we have created a new publish property “/p:AllowTableRecreation”, where

A user can set /p:AllowTableRecreation to false when publishing which will stop the deployment before starting if a table recreation is detected in the deployment plan.
An error message is provided to the user that includes the name of the table
The default behavior is that when using sqlpackage, user will be able to set property /p:AllowTableRecreation to true (or not setting it at all) while publishing to allow the table recreation.

closing the issue now, Thanks

(reopening the issue because while we have added the property that enables users to protect their operations from table recreation, it is a reasonable request that we opt for lighterweight operations when they're available)

[like]  Naman Gupta reacted to your message:

From: Drew Skwiers-Koballa @.>
Sent: Wednesday, October 25, 2023 7:30:12 PM
To: microsoft/DacFx @.>
Cc: Comment @.>; Assign @.>; State change @.***>
Subject: Re: [microsoft/DacFx] Changing Primary Key Constraint Name Causes Table Rebuild (Issue #295)
(reopening the issue because while we have added the property that enables users to protect their operations from table recreation, it is a reasonable request that we opt for lighterweight operations when they're available)
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/DacFx/issues/295#issuecomment-1779921992 or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2XYWH5OGKXIUOV6VYFTBHDYBFSEJBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZDCOBVGMYDOMZUGWSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRTGQ2DONJWGUYTSOFENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTENZXGYYDSOJTGGBKI5DZOBS2K2LTON2WLJLWMFWHKZNKGE3TQNBYGQ4TANZRQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSGE4DKMZQG4ZTINMCUR2HS4DFUVWGCYTFNSSXMYLMOVS2UMZUGQ3TKNRVGE4TRJ3UOJUWOZ3FOKTGG4TFMF2GK.
You are receiving this email because you commented on the thread.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Expected: the constraint PK1 is dropped and the constraint PK2 is created.

I'd say that sp_rename would be enough if no other options in constraint definition were changed.
We face the same issue, and we have many renames in a huge old project where we are trying to apply coding standards and naming patterns. As a workaround we use RefactorLog feature which is greate but in an actively developed project leads to terrible amount of Git conflicts. If renaming could be done with less effort it would be great.

we use RefactorLog feature which is greate but in an actively developed project leads to terrible amount of Git conflicts
It’s not very clear what exactly the problem is, looking through the prism of the original question?

Git merge problem? - This is a purely Git issue (hg 😎). Or do you suggest changing the .refactorlog file format?
The problem with refactoring itself? What does the sp_rename have to do with it?

@dzsquared Judging by the responses from the topicstarter, this is beyond the scope of the current topic:

@asrichesson asked to replace rebuid with drop / create, which is even worse.
This is not a bug, it's an improvement.

OK. Let's say we need to create a new issue as an improvement. But who should we ask? DacFx or VisualStudio?
DacFx
Should we completely abandon the external refactorlog and have an internal very complex mechanism for comparing schemas not by name, but by structure?
Because there will be conflicts. I can’t come up with something really completely incomprehensible right away, because... For me, refactorlog itself is a treasure trove of surprises.
This is no longer optimization, but a complete change of concept.
The problem is that changing the structure is a very common task. It is not limited to changing the set of indexes. You can join or split tables, but there are no universal solutions for this. And to change the name of the key/index, refactorlog is the most correct way.
This is a coding culture problem.
VisualStudio
It is not clear how it will track changes in the structure? It essentially defines only the current structure, and the previous one is a vague concept.
I added the K1 key, removed the key, and added K2 with a different name. Should this be considered as changing the old one or immediately adding a new K2?
Save only if you have done build ? What if these builds didn’t go anywhere?
The change search mechanism must be flexible, even know something like naming product version tags in git, so that you can compare versions and find all renamings.


Cant use with eslint-import-resolver-webpack

I use webpack for my project and have aliases for directories in my webpack config. So, when I add
  "settings": {
    "import/resolver": "webpack"
  }

to my .eslintrc Atom hightlights all imports and says "Resolve error: unable to load resolver webpack". However cli version of eslint works as expected

Hi @stalniy, thanks for your report.
I've submitted a fix, could you try it and let me know ?

Thanks!


Remove the stat/expr distinction from Transformers.Transformer.

Recent changes have all but removed the distinction between statements and expressions in the IR. Notably:

bb4f6da3628913639a82ad371c22731d9b2347f5 Allow Return arg to be a void if the target Labeled is a void.
cdcff9973579ed77e87343f3edd9429661b4a786 Rename NoType to VoidType and print it as "void".

Therefore, it made no sense anymore that Transformer.transform had an isStat argument. In fact, the first of the two commits mentionned above semi-broke the semantics of that argument anyway. Moreover, isStat was never used in our codebase (only forwarded everywhere for no reason).
The only exception was a deserialization hack for IR <= 1.5. This one was already hacking around the fact the IR produced back then was not well-typed. See #4442 for context.
We now remove that parameter everywhere. It makes the deserialization hack a bit more verbose, but everything else becomes simpler.

QQ: Did you verify that our basic IR backwards compatibility check catches issues with the deserialization hack? If no, how did you test the changes to it?

No, our basic IR backward compat tests don't catch that. They can catch things that appear in our standard library, but not corner cases that only appear in the wild.
 I tried several things, including:

Taking the report of https://github.com/scala-js/scala-js/issues/4601 with the library published with Scala.js 1.3.1 (but I think it did not cause an issue in the Scala 2-emitted IR, only the Scala 3-emitted one).
Undo the compiler fixes of https://github.com/scala-js/scala-js/pull/4439/commits/e440de9b54fa0dda58cd274217800114546990dc to try and reproduce ill-typed IR today.

So yeah ... that's basically untested. 🤷♂

Ah, scratch that. I did manage to reproduce it! The following worked:

Undo the compiler fixes of e440de9 to try and reproduce ill-typed IR today.

but I had to do it from a completely clean build. I had previously only re-compiled the test suite with those changes.
It turns out we have a "problematic" If here in our javalib:
https://github.com/scala-js/scala-js/blob/d3a5b0aed7434c6e9ac4e71ab01b8ea56e2a55a3/javalib/src/main/scala/java/util/regex/IndicesBuilder.scala#L500
So with the compiler fix undone, I get the IR checking error on this line. If I then unconditionally enable the hack (not just for IR <= 1.5), the IR checking error disappears and the tests pass (validating the hack on at least one input). I even tested on Wasm, which is much less forgiving of ill-typed IR even when it manages to go through our checkers.


feat: add tag implementation

Changes description
Add the Tag component implementation
Context
This PR resolves https://github.com/Decathlon/vitamin-ios/issues/36
Checklist

[x] Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
[x] Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
[x] Check your code additions will fail neither code linting checks.
[ ] I have reviewed the submitted code.
[x] I have tested on an iPhone device/simulator.
[x] I have tested on an iPad device/simulator.
[ ] If it includes design changes, please ask for a review with a core team designer.

Does this introduce a breaking change?

No
the backgroundDiscount color has been replaced by the backgroundAlert color.
But the backgroundDiscount has been kept, with a deprecation message

Screenshots
iPhone

iPad

I pushed some fixes :

vertical alignment (which indeed was not the same with and without icon)
typos in comments (I should really re-read myself before commiting ;) )
extraction of variant in its own type (not a inner type of VitaminTag anymore) for further usage with SwiftUI
handling of color change when switching dark and light mode
adding of deprecated backgroundDiscount color to avoird breaking change


pip install pybeagle command error

When I tried to run the command pip install pybeagle to install pybeagle as a library, I got the following error:
Could not find a version that satisfies the requirement pybeagle (from versions: ) No matching distribution found for pybeagle
I'm currently trying to install pybeagle on a MacOS Mojave, with Python 3.7.1. I also tried to run the command on another Mac OS Mojave machine with Python 2.7.15 and with Ubuntu WSL on Windows 10 with Python 2.7.15 and encountered the same issue.
Any idea why that might be the case? - Thanks!

Try and use Python3.6, Python3.7 doesn't work because of issues with rekall (https://github.com/google/rekall/issues/488) once they unpin the version of acora to the version which has the ability to compile CPython code for 3.7, i'll add the ability to install on 3.7

Was still running into issues with Python 3.6, but I see you have a PR with a fix open! Thank you :)

You should be able to install now if you are using windows, i've set up testing and fixed all issues preventing it from being installed: https://travis-ci.com/yampelo/beagle/builds/107562330


[MBL-1227] Add post campaign messaging for project page

📲 What
Add the new messaging for when a project is collecting post campaign pledges to the project page
🤔 Why
The people need to know
🛠 How
Added a new string (translations needed) and populated based on project flags
👀 See

📋 QA

Go to successful projects to see if the correct messaging shows up (not post campaign collecting message)
On staging go to the Baconbaconbacon project and confirm this is showing up correctly

Story 📖
MBL-1227

I also had to add the builder fields for these to be properly populated on the project page

Codecov Report
Attention: Patch coverage is 25.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 73.83%. Comparing base (78f81ff) to head (041a07d).

Files
Patch %
Lines

...arter/services/transformers/GraphQLTransformers.kt
0.00%
4 Missing :warning:

...viewmodels/projectpage/ProjectOverviewViewModel.kt
50.00%
2 Missing and 1 partial :warning:

...pp/src/main/java/com/kickstarter/models/Project.kt
0.00%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1967      +/-   ##
============================================
- Coverage     73.85%   73.83%   -0.03%
- Complexity     1979     1981       +2
============================================
  Files           348      348
  Lines         19903    19915      +12
  Branches       2755     2760       +5
============================================
+ Hits          14700    14704       +4
- Misses         3589     3596       +7
- Partials       1614     1615       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Document that we're moving on from this project

@swang Before making this official, I wanted to run it past you.
The comment markers are something I saw eslint does. Even if you leave that text it won't show up in the issue or PR.

Sorry caught a fever over the weekend. Still bit sick now.
It looks like CoffeeScript is prepping for a new release soon (a year+ since the last version), and it seems like Jeremy is back from his vacation? I'm guessing as soon as that gets released there will probably be some bugs to fix. I'd be interested in working on this if they ever get back to releasing regularly to get on par with es2015 features.
I think additionally we should provide a list/accept PRs for the third party rules that want to get added. That way it's less of a blackhole for users.
I've been pretty busy with work but (assuming a new version gets released soon), I'd like to delve in and see if any of the problems we've had before (indentation, difference in blank lines, undef/unused vars) can be fixed up.

There's no rush. I'm just trying to publicly document what's already been happening here for probably a year.
Do you want to abandon this PR and you become sole maintainer? If you're going to continue, that's fine, but I think I'll unsubscribe from the repo so I'm only notified of mentions. Whether CoffeeScript makes a new release or not, I don't intend to continue this project. CoffeeScript is fundamentally broken and provides very few benefits over just using standard JavaScript https://gist.github.com/AsaAyers/d09e4de118b8d6b5e2d8fa3e38e496e0
Do you want to update the branch for this PR to better reflect your plans?

It looks like CoffeeScript is prepping for a new release soon

See #580.

I'm now unsubscribed from this repo because I don't want to know about new issues being opened. 👋


Vim9: Enter keypress not discarded by popup filter when error raised from popup callback

Describe the bug
In Vim9 script, an Enter keypress is not discarded by the popup filter when an error is raised from a try/catch inside a popup callback.
To Reproduce
Run this shell command:
vim -Nu NONE -S <(cat <<'EOF'
    vim9script

    def Filter(id: number, key: string): bool
        popup_filter_menu(id, key)
        return true
    enddef

    def Callback(id: number, result: number)
        h 01.1
        try
            eval [][0]
        catch /wont_match/
        endtry
    enddef

    popup_menu('', #{ filter: Filter, callback: Callback })
    feedkeys("\r", 't')
EOF
)

The cursor is below the help tag 01.1, on line 21, in $VIMRUNTIME/doc/usr_01.txt.
Expected behavior
The cursor is on the help tag 01.1, on line 20, in $VIMRUNTIME/doc/usr_01.txt.
Environment

Vim version: 8.2 Included patches: 1-1855
OS: Ubuntu 16.04.7 LTS
Terminal: xterm(360)

Additional context
It seems that the Enter key was not discarded, and was executed as a normal command which moves the cursor 1 line downward, on the first non-blank character.  This is unexpected, because the filter function returns true, which – according to :h popup-filter – means that the key should be discarded.
https://github.com/vim/vim/blob/e13bdec6b90b3a0fce4f021e3ee986e731cea3b5/runtime/doc/popup.txt#L870-L871

If eval [][0] is removed from the try conditional, the issue disappears.
vim9script
def Filter(id: number, key: string): bool
    popup_filter_menu(id, key)
    return true
enddef

def Callback(id: number, result: number)
    h 01.1
    try
    catch /wont_match/
    endtry
enddef

popup_menu('', #{ filter: Filter, callback: Callback })
feedkeys("\r", 't')

I think this is working as intended:
https://github.com/vim/vim/blob/3da855c8e28140d9f02b1572e445f8d4f977cf64/runtime/doc/popup.txt#L923-L927
Although, I would prefer if the key was discarded when an error was raised.
Anyway, sorry for the noise.


Counter for number of "regular" attacks on vorkath

Regular attacks being range, melee, fireball, and his multiple types of dragon fire
Reason so you can tell when his zombie/rapid fire specials are coming

I'll look into this and see if this is something we want to add to the client

imo its no different than demonics plugin as all that really does is "count" the attacks for you before it switches styles in addition to what its switching to @SirGirion


Ability to limit output current or power

I'm planning on building a battery system with daly bms and thus i don't know yet what can be done on bms side.
however what would be great is the ability to set the max output current or power.
that is to be able to slow start (gradually increase current on a slow ramp) the output, e.g. when connected to a grid tie inverter to not fry the caps.

I don't believe the DALY BMS's have the ability to actively limit current, I think they can only sense current and disable themselves if the current exceeds the setpoint.

 I just took some time to watch a youtube video about the app and i couldn't find a functionality like i described.
Neither could i find docs on their homepage.
i'll close the issue then.


Add starship, topgrade & emplace

Checklist for submitting a pull request to Terminals Are Sexy:

[x] I have carefully read and comply with the Contributing Guidelines of this repo.
[x] I have searched the PRs of this repo and believe that this is not a duplicate.

Title: Topgrade

Link: https://github.com/r-darwish/topgrade

Category: Tools and plugins

Description: Keeping your system up to date mostly involves invoking more than a single package manager. This usually results in big shell one-liners saved in your shell history. Topgrade tries to solve this problem by detecting which tools you use and run their appropriate package managers.

Title: Emplace

Link: https://github.com/tversteeg/emplace

Category: Tools and plugins

Description: Command-line tool to mirror installed software on multiple machines.

Title: Starship

Link: hhttps://github.com/starship/starship

Category: Tools and plugins

Description: Starship is the minimal, blazing fast, and extremely customizable prompt for any shell!
The prompt shows information you need while you're working, while staying sleek and out of the way.

Hi there @tversteeg. Please create a separate pull request for each suggestion. Thanks in advance.


Missing LICENSE file for good packaging

Papyrus is stated OSI Approved :: BSD License on pypi.org website.
There's no LICENSE file in the trunk.
Having this file with a clear content would help us who package it for distribution. (License file being mandatory).

Excellent. thx

I can create a new release on pypi if it makes things easier for you.

Don't worry, do it when we can remove the dev in the release number ;-)

Just a remark, shouldn't LICENSE.txt be put also in MANIFEST.in ?

Done in https://github.com/elemoine/papyrus/pull/42. Thanks!


Fix flashbundle error in infineon. Ensure CI will catch this in the future

Problem
The flashbundle name in #12189 has a typo in it, resulting in errors:
...
Step #1 - "CompileAll":   File "/workspace/scripts/build/build/__init__.py", line 75, in CreateArtifactArchives
Step #1 - "CompileAll":     builder.CompressArtifacts(os.path.join(
Step #1 - "CompileAll":   File "/workspace/scripts/build/builders/builder.py", line 98, in CompressArtifacts
Step #1 - "CompileAll":     for target_name, source_name in self.outputs().items():
Step #1 - "CompileAll":   File "/workspace/scripts/build/builders/builder.py", line 85, in outputs
Step #1 - "CompileAll":     artifacts.update(self.flashbundle())
Step #1 - "CompileAll":   File "/workspace/scripts/build/builders/infineon.py", line 95, in flashbundle
Step #1 - "CompileAll":     with open(os.path.join(self.output_dir, self.app.FlashBundleName()), 'r') as fp:
Step #1 - "CompileAll": FileNotFoundError: [Errno 2] No such file or directory: '/workspace/out/infineon-p6-light/light_app.flashbundle.txt'

Change overview
Fix the name, ensure CI runs the full 'copy artifacts with flashbundle' build step to catch this in the future.
Testing
CI will validate this. Manually using build_examples.py compilation in my vscode instance.

/rebase


Righthand-nav doesn't stretch all the way to right viewport edge

What happened?
On https://datatracker.ietf.org/wg/photos/; probably because the headings are too short.
What browser(s) are you seeing the problem on?
No response
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

Probably related- the width of the time zone indicator varies depending on the length of the time zone name. This causes a jarring effect as the buttons jump when the time zone is changed.


Popup Menu example doesn't work

Following the example from http://semantic-ui.com/collections/menu.html#popup-menu doesn't work - the popup menu appears then vanishes.
Please see https://jsfiddle.net/Morrolan/ofrm6n7k/ for details.

You need javascript, please read popup usage guide.
https://jsfiddle.net/zgjpyu7e/

Hi @jlukic - I am afraid that the JSFiddle example you provided me with also doesn't appear to work?

+1, the example on "Menu" page on Semantic UI website works but the one on "Popup" page and on JSFiddle doesn't work. And when I try to use it me it doesn't work.


[Bug]: During import of snowflake_warehouse, terraform plan output indicates, that property query_acceleration_max_scale_factor will be setted (updated)

Terraform CLI Version
1.8.2
Terraform Provider Version
0.89
Terraform Configuration
resource "snowflake_warehouse" "warehouse" {

  name                                = "TEST_WAREHOUSE"
  warehouse_size                      = "SMALL"
  comment                             = ""
  auto_resume                         = true
  min_cluster_count                   = 1
  max_cluster_count                   = 1
  max_concurrency_level               = 8
  query_acceleration_max_scale_factor = 8
  statement_queued_timeout_in_seconds = 0
  statement_timeout_in_seconds        = 172800
  scaling_policy                      = "STANDARD"
  enable_query_acceleration           = false
}

Category
category:resource
Object type(s)
resource:warehouse
Expected Behavior
...
  # snowflake_warehouse.warehouse["TEST_WAREHOUSE"] will be imported
    resource "snowflake_warehouse" "warehouse" {
        auto_resume = true
        comment = ""
        enable_query_acceleration = false
        id = "TEST_WAREHOUSE"
        max_cluster_count = 1
        max_concurrency_level = 8
        min_cluster_count = 1
        name = "TEST_WAREHOUSE"
        query_acceleration_max_scale_factor = 8
        resource_monitor = "null"
        scaling_policy = "STANDARD"
        statement_queued_timeout_in_seconds = 0
        statement_timeout_in_seconds = 172800
        warehouse_size = "SMALL"
        warehouse_type = "STANDARD"
    }
...

Actual Behavior
...

 # snowflake_warehouse.warehouse["TEST_WAREHOUSE"] will be updated in-place
  # (imported from "TEST_WAREHOUSE")
  ~ resource "snowflake_warehouse" "warehouse" {
        auto_resume = true
        comment = ""
        enable_query_acceleration = false
        id = "TEST_WAREHOUSE"
        max_cluster_count = 1
        max_concurrency_level = 8
        min_cluster_count = 1
        name = "TEST_WAREHOUSE"
      + query_acceleration_max_scale_factor = 8
        resource_monitor = "null"
        scaling_policy = "STANDARD"
        statement_queued_timeout_in_seconds = 0
        statement_timeout_in_seconds = 172800
        warehouse_size = "SMALL"
        warehouse_type = "STANDARD"
    }

...

Steps to Reproduce

Create resourse snowflake_warehouse:

resource "snowflake_warehouse" "warehouse" {
        auto_resume = true
        comment = ""
        enable_query_acceleration = false
        id = "TEST_WAREHOUSE"
        max_cluster_count = 1
        max_concurrency_level = 8
        min_cluster_count = 1
        name = "TEST_WAREHOUSE"
        query_acceleration_max_scale_factor = 8
        resource_monitor = "null"
        scaling_policy = "STANDARD"
        statement_queued_timeout_in_seconds = 0
        statement_timeout_in_seconds = 172800
        warehouse_size = "SMALL"
        warehouse_type = "STANDARD"
    }

Run terraform plan

How much impact is this issue causing?
Medium
Logs
No response
Additional Information
This issue (bug) happend, only when enable_query_acceleration param for warehouse is false (but query_acceleration_max_scale_factor equals, for example 8).
See the following part of ReadWarehouse func:
https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/d0d504868b0dda15e3a779e94969d7742253160c/pkg/resources/warehouse.go#L273-L279
In this code, when terraform checks warehouse, and see, that enable_query_acceleration = false, then terraform will think, that query_acceleration_max_scale_factor is null.
But, in UpdateWarehouse function it will be set query_acceleration_max_scale_factor (8 by default), even though enable_query_acceleration = false
https://github.com/Snowflake-Labs/terraform-provider-snowflake/blob/d0d504868b0dda15e3a779e94969d7742253160c/pkg/resources/warehouse.go#L424-L427
Thus, I think, we need to read query_acceleration_max_scale_factor property in ReadWarehouse, regardless of the enable_query_acceleration value
Would you like to implement a fix?

[ ] Yeah, I'll take it 😎

Hey @Hunter-99. Thanks for reaching out to us.
I will try to reproduce this today. I will also find out why the attached logic was written this way.

@sfc-gh-jcieslak, @sfc-gh-asawicki thanks! Now it works as I expected.

Hey @Hunter-99. Just letting you know that warehouse resource was redesigned and the behavior for enable_query_acceleration will change starting from v0.93.0. You can check the migration guide. The release should happen this week.