Discovery service Response to include full URL of CDS service

Hi,
In the discovery service response, the {id} specifies portion of the URL.
{baseUrl}/cds-services/{id}
Is there a reason why I cant return a "Full URL".  The discovery service may return a list of available CDS-Hooks services in the market, not necessarily with in the same domain ({baseurl}). If {id} cant be used for that purpose can we introduce a optional parameter {url} for this purpose?

By design, the Discovery endpoint and the CDS Service endpoint are to be deployed to the same base URL. This aids in our security/trust model as the Discovery endpoint is only able to advertise services hosted on the same domain. If the domain used for Discovery differs from that of the CDS Services advertised in /discovery, now CDS Clients must verify the domain of those endpoints again.
Keeping everything on the same base URL aids in both simplicity of our security model as well as making the understanding of the URL paths predictable for all.
Out of curiosity, can you clarify your question with a concrete example of the Discovery and CDS Service URLs you want?

In a large organization, there might be multiple products offering CDS services. Few services may be internally Hosted on Private cloud and some service on Azure/ AWS. EHR's need one Discover service which provides the list of available CDS services. Now how would I solve this problem.
Also, We have a scenario where we have few internal cds-services and few we partnered with third party vendors. We want to maintain the list of CDS-services and a single discovery service.
{
"services": [
{
"hook": "patient-view",
"title": "Static CDS Service Example",
"description": "An example of a CDS Service that returns a static set of cards",
"id": "static-patient-greeter",
"prefetch": {
"patientToGreet": "Patient/{{context.patientId}}"
}
},
{
"hook": "medication-prescribe",
"title": "Medication Echo CDS Service",
"description": "An example of a CDS Service that simply echos the medication being prescribed",
"id": "https://vm1.azure.com/cds-services/medication-echo",
"prefetch": {
"patient": "Patient/{{context.patientId}}",
"medications": "MedicationRequest?patient={{context.patientId}}"
}	  ,
{
"hook": "medication-prescribe",
"title": "Medication Echo CDS Service",
"description": "An example of a CDS Service that simply echos the medication being prescribed",
"id": "https://thirdpartyvendor/cds-services/medication-echo",
"prefetch": {
"patient": "Patient/{{context.patientId}}",
"medications": "MedicationRequest?patient={{context.patientId}}"
}
}
]
}

Can’t one just create a Web page or equivalent that points to all the endpoints and shows the info?
Ken
==================
Kensaku Kawamoto, M.D., Ph.D., M.H.S.
Associate Chief Medical Information Officer
Vice Chair for Clinical Informatics, Department of Biomedical Informatics
On Feb 13, 2019, at 9:25 AM, Gokulm84 <notifications<EMAIL_ADDRESS>wrote:
In a large organization, there might be multiple products offering CDS services. Few services may be internally Hosted on Private cloud and some service on Azure/ AWS. EHR's need one Discover service which provides the list of available CDS services. Now how would I solve this problem.
Also, We have a scenario where we have few internal cds-services and few we partnered with third party vendors. We want to maintain the list of CDS-services and a single discovery service.
{
"services": [
{
"hook": "patient-view",
"title": "Static CDS Service Example",
"description": "An example of a CDS Service that returns a static set of cards",
"id": "static-patient-greeter",
"prefetch": {
"patientToGreet": "Patient/{{context.patientId}}"
}
},
{
"hook": "medication-prescribe",
"title": "Medication Echo CDS Service",
"description": "An example of a CDS Service that simply echos the medication being prescribed",
"id": "https://vm1.azure.com/cds-services/medication-echo",
"prefetch": {
"patient": "Patient/{{context.patientId}}",
"medications": "MedicationRequest?patient={{context.patientId}}"
} ,
{
"hook": "medication-prescribe",
"title": "Medication Echo CDS Service",
"description": "An example of a CDS Service that simply echos the medication being prescribed",
"id": "https://thirdpartyvendor/cds-services/medication-echo",
"prefetch": {
"patient": "Patient/{{context.patientId}}",
"medications": "MedicationRequest?patient={{context.patientId}}"
}
}
]
}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/cds-hooks/docs/issues/463#issuecomment-463265678, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFrPEMwpQqWot6v-oW652giKsD6zNUcjks5vNDyCgaJpZM4a4RRy.

Our intention is not to display all the available services rather provide the configuration for EHR.
Below is the workflow we are trying to achieve

EHR calls Discovery service
Based on the trigger points, lets say the action is "order-review", EHR's gets the list of available services for "order-review" hooks from the discovery service response.
EHR fire the requests in parallel for each CDS services.
Cards returned by each service is displayed.

My issue is very simple, Why cant I use the full urls in case of my example? I understand the security concerns around it. Other than that is there a reason no to use full urls?

There's a subtle difference here in the purpose of what is meant by _discovery _. The discovery service's primary purpose is allowing an EHR to discover all CDS services that exist at a particular endpoint, not for an EHR to discover all CDS services it supports.
It sounds like what's missing in your implementation is a directory or other means to catalog the whitelist of CDS service endpoints supported by your EHR.  You may look at using the discovery endpoints out-of-band at registration time and then have your implementation keep track of the whitelisted services it should call for a given hook.

There's a subtle difference here in the purpose of what is meant by discovery. The discovery service's primary purpose is allowing an EHR to discover all CDS services that exist at a particular endpoint, not for an EHR to discover all CDS services it supports.
It sounds like what's missing in your implementation is a directory or other means to catalog the whitelist of CDS service endpoints supported by your EHR. You may look at using the discovery endpoints out-of-band at registration time and then have your implementation keep track of the whitelisted services it should call for a given hook.

Just to be clear we are not EHR. we are CDS service provider with multiple CDS services ( both internal and partnered with 3 rd party services)
AS you mentioned, I want our discovery service to provide a list of all available cds-services(not just on one end point, but multiple endpoints) to the caller.

EHR or not, this seems to be conflating a directory of multiple endpoints with the discovery of services at a single endpoint.  I still recognize that you have a problem you're trying to solve...just not sure the discovery endpoint is the right mechanism.
What are your thoughts on addressing the implied security/trust model challenges that would result with your proposal?

EHR or not, this seems to be conflating a directory of multiple endpoints with the discovery of services at a single endpoint. I still recognize that you have a problem you're trying to solve...just not sure the discovery endpoint is the right mechanism.
What are your thoughts on addressing the implied security/trust model challenges that would result with your proposal?

Thanks, are you thinking risk that discovery service get compromise and may return malicious endpoints?

A CDS Client is establishing trust with a Service provider at a particular domain.  The discovery endpoint lists what services are offered at that domain.  If the discovery endpoint is instead a directory pointing to different domains, the client isn't going to feel comfortable calling arbitrary domains that are knowingly or unknowingly listed.  The client has to work to establish trust with each of those other domains.
I'd encourage you to either (a) register each of these separate domains (and their own discovery endpoints) with the CDS Client or (b) stand up an API Gateway-style solution that presents the CDS Services under one domain and abstracts away the underlying hosting model.

@Gokulm84 - I'm closing this issue, because it sounds like the issue was meaningfully discussed and alternatives were identified.
Re-open if you disagree.
Isaac


docs: adjust position of "on this page" again

Overview

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests / types / typos

Checklist:

[x] My code follows the developer guidelines of this project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

thx


Removes program_commitment and local_data_root from Transaction, moves transaction signatures to offline phase

Motivation

Removes program_commitment and local_data_root from Transaction
Removes ledger_digest, program_commitment, and local_data_root from transaction signatures

Approach
This PR preserves program_commitment and local_data_root in the InnerCircuitVerifierInput, however it removes it from OuterCircuitVerifierInput. Instead, these two items are allocated as witness in the outer circuit only.
This change then allows us to remove program_commitment and local_data_root from Transaction, and transaction signatures.
In addition, ledger_digest is removed from transaction signatures, to allow for offline signing of the transaction.
Notes
This PR will require resampling parameters.

Isn't ledger_digest required to create the transaction SNARKs in the first place? So it's required in the offline phase anyway, no?

That's right. So the offline phase (which requires a private key) is purely for signing. The online phase (the delegable DPC model) executes the inner and outer SNARKs with a ledger digest. This approach makes transaction generation a handoff procedure from caller to prover to chain.

For delegable DPC don't we have to sign the transaction? Or am I missing something?

That was the original construction. I think it was around a year ago, we discussed making the outer proof generation a handoff procedure, by forgoing signing the final proof. Then we discussed removing the ledger digest from the signed message to allow for offline signing.

I see, so now the signature is only over the commitments and serial numbers? (and maybe memo and some other non-proof stuff)

No worries :) Yes, here's the signature message now:
(Network ID, Serial Numbers, Commitments, Memorandum, Value Balance)

Resampling parameters now.


Fix FFT functions for benchs

TITLE
Description
Description of the pull request changes and motivation.
Type of change
Please delete options that are not relevant.

[ ] New feature
[ ] Bug fix
[ ] Optimization

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

[ ] This change is an Optimization

[ ] Benchmarks added/run

Codecov Report

Merging #288 (eb2d5c0) into main (9632649) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   96.28%   96.28%
=======================================
  Files          91       91
  Lines       10819    10819
=======================================
  Hits        10417    10417
  Misses        402      402

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Duplicate of https://github.com/lambdaclass/lambdaworks/pull/276


LLama prompt

Still untested 😄
https://www.llama.com/docs/model-cards-and-prompt-formats/llama3_1/#-supported-roles-

Can test later 👍

Added some unit tests

works :sunglasses: :+1:

Thanks @OskarStark!


Object.Object.defineProperty.get is deprecated.

Requiring $ from atom is no longer supported.
If you are using space-pen, please require $ from atom-space-pen-views. Otherwise require jquery instead:
{$} = require 'atom-space-pen-views'
or
$ = require 'jquery'
Add "atom-space-pen-views": "^2.0.3" to your package dependencies.
Or add "jquery": "^2" to your package dependencies.
Object.Object.defineProperty.get (/usr/share/atom/resources/app.asar/exports/atom.js:48:11)
Object.<anonymous> (/home/ryan/.atom/packages/python-isort/lib/python-isort.coffee:2:20)
Object.<anonymous> (/home/ryan/.atom/packages/python-isort/lib/python-isort.coffee:105:4)
Module._compile (module.js:452:26)
Object.requireCoffeeScript (/usr/share/atom/resources/app.asar/node_modules/coffee-cash/lib/coffee-cash.js:85:19)
Module.load (module.js:347:32)

+1


[Bug]:  AttributeError: 'str' object has no attribute 'name'

Bug Description
./llama_index/legacy/readers/file/docs_reader.py
metadata = {"file_name": file.name}
AttributeError: 'str' object has no attribute 'name'
Version
lastest
Steps to Reproduce
The file is a string file path, not a file object. When the file is passed to the DocxReader and file.name is called, it throws an error.
Relevant Logs/Tracbacks
No response

Did you pass in a path object to the reader?
from pathlib import Path

docx_reader.load_data(Path(filepath))


Using cached NVD Data feed results in NullPointerException

Describe the bug
I cached the NVD data feed using vulnz API and uploaded all downloaded *json.gz files into a RAW Nexus repository. When executing OWAP dependency check I reference the cached NVD data using --nvdDatafeed command line option. Result is a NPE
Exception in thread "main" java.lang.NullPointerException
at java.base/java.time.ZoneId.from(Unknown Source)
at java.base/java.time.ZonedDateTime.from(Unknown Source)
at java.base/java.time.ZonedDateTime.until(Unknown Source)
at java.base/java.time.Duration.between(Unknown Source)
at org.owasp.dependencycheck.data.update.NvdApiDataSource.checkUpdate(NvdApiDataSource.java:443)
at org.owasp.dependencycheck.data.update.NvdApiDataSource.processDatafeed(NvdApiDataSource.java:117)
at org.owasp.dependencycheck.data.update.NvdApiDataSource.update(NvdApiDataSource.java:108)
at org.owasp.dependencycheck.Engine.doUpdates(Engine.java:906)
at org.owasp.dependencycheck.Engine.initializeAndUpdateDatabase(Engine.java:711)
at org.owasp.dependencycheck.Engine.analyzeDependencies(Engine.java:637)
at org.owasp.dependencycheck.App.runScan(App.java:262)
at org.owasp.dependencycheck.App.run(App.java:194)
at org.owasp.dependencycheck.App.main(App.java:89)
Version of dependency-check used
The problem occurs using version X9.0.2 of the cli
To Reproduce
Steps to reproduce the behavior:
Call dependency check with --nvdDatafeed option
dependency-check.sh --nvdDatafeed 'https://host/nexus3/repository/NVDApiCache/nvdcve-{0}.json.gz' -o '...' -f HTML -f XML -s '...' --nvdApiKey '...' --disableRetireJS --disableAssembly
Expected behavior
No NPE
Regards
Ulrich

Try running purge. This looks like it might be an issue with using a database created with 8.4.3 and then trying to utilize 9.x.

While I did just create a PR to resolve the NPE - running purge should resolve the issue for you.

Running dependecy-check.sh --purge solved this.
Thank you very much for this fast reply.


Broken Link (Flexx)

Hi,
There's a broken link on the index page. I'm not sure which page is being referenced but below a couple potential candidates:
Index Page: https://github.com/QuantStack/ipysheet/blob/master/docs/source/index.ipynb
Flexx: https://flexx.readthedocs.io/en/stable/start.html
PScript: https://pscript.readthedocs.io/en/latest/
Best.

Thanks!

I think broken links are a common issue and a radical solution to this problem is automatically checking and reporting them. Luckily the new GitHub actions and  workflows help with that. I recently wrote an action that just does that. URLs-checker will check and report broken links, which is useful to spot similar issues to this one.

Thanks, that is a very useful action! I'll be using that in other repos.
(from mobile phone)
On Sun, 1 Dec 2019, 20:58 Ayoub Malek<EMAIL_ADDRESS>wrote:

I think broken links are a common issue and a radical solution to this
problem is automatically checking and reporting them. Luckily the new
GitHub actions and workflows help with that. I recently wrote an action
that just does that. URLs-checker
https://github.com/marketplace/actions/urls-checker will check and
report broken links, which is useful to spot similar issues to this one.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/QuantStack/ipysheet/issues/148?email_source=notifications&email_token=AANPEPJXWRSSOR52PWCNQC3QWQJQBA5CNFSM4JCVZGOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFRT3UA#issuecomment-560152016,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANPEPI5XPDGEQ5GJACRJSDQWQJQBANCNFSM4JCVZGOA
.


Add HTTP security headers

Concern over the lack of security headers has been raised by others.
While I don't think we have any security vulnerabilities, since we have no exposure to XSS (nunjucks sanitises input) and do not have sensitive data or sessions tokens,  it seems prudent to introduce these best practice measures sooner rather than later.

I think this is all sorted now via a number of PRs including:

#178
#177
#170
#167
#166

@neilbmclaughlin Can this be closed?

Closing as it has been rectified.


Use extract_neurons in wavelet_denoising

This removes some redundant code for determining the neurons (with properties) to return from wavelet_denoising by using an existing helper function (extract_neurons) for that exact purpose.

Not really concerned about the decrease in coverage. Far more interested in cutting down redundant code. This looks good on that front.


[SUP1-101] Consider putting different customers' data in different DB schemas / sharding

Right now we write all contacts, accounts, etc. into the same tables. This makes things very non-performant and not ideal.
From SyncLinear.com | SUP1-101

Migrated to internal project management tool.


Closes #70.

Added the ability to search by multi-word terms using double quotes.

@nwalke Hi again, Thanks again for all the pull requests :+1: , I'll review & merge over the weekend.
I've seen you've been fixing a lot of the issues marked for the next release, Don't worry about #54 since I've pretty much finished it on the custom_role_system branch. Just got to write a good amount of tests and clean it up a little before merging it back it.

Yeah, I saw!  Should be good stuff.

Wow, I just realized this is horribly broken.  Sorry about that...
The logic used to turn terms into strings kind of ruins what I was hoping I could easily do.  I'll fix that up.

Awesome!

@nwalke Yeah, I saw the issue, That's a right pain. Since using PDO quoting for escaping doesn't seem to play well with full text searches I've added some custom escaping. I'm a little nervous about it but I've tested loads of combinations of symbols and characters against it (Trying to inject SQL) and it appears to be work fine. I'll still need to test it against mariaDB before release to ensure there's no differences there.
I also learnt that MySQL won't fulltext search exactly against a phrase. Searching "the tree" would match against the tree and the old tree. Any number of words could be between them. I've added some LIKE queries which are used if any quoted terms are in the search query to resolve this. I found that doing a fulltext match then a LIKE query has minimal performance impact and is still way faster than only using a LIKE query.


PLEASE !!! Fork this project and create a new one

This has so much potential if combined with amazon S3 like service and type safety.

https://github.com/seald/nedb


Migrating from Rebornix to Rdbg debugger support for VSCode

 Rebornix has been deprecated and Rbdg debugger is officially recommended for ruby development in VS Code.
My experience of migration for (pure ruby) code base was pretty straight forward and I just wonder any plan for sketchup-extension-vscode-project ? If yes, I can try and report any compatible issues should be addressed.

The trouble is that debugging Ruby within SketchUp has been provided by a DLL using the ruby-debug-ide protocol: https://github.com/SketchUp/sketchup-ruby-debugger
More info here:
https://forums.sketchup.com/t/vscode-ruby-extension-no-longer-mantained/250058
We've hot had time to investigate what it'd take to make newer debug tools working.
I was wondering if installing some gems would work. And if it does, how far back it goes.
If you have any spare time and any luck with this I'd love to hear!


Testing saga race with a function vs another dispatched action

Issue Summary
I'm struggling to test a saga where race takes an async func or another dispatched action
I have an async function, which I'm mocking with babel-plugin-rewire. This function could be cancelled by an action fired in the meantime so I'm using race.
I'm unsure how to best mock the scenario where the second dispatched action wins. How should I do this?
(I'm relatively new react & saga's so I apologise if this is relatively obvious and just slipping by me).
Current Code
authSaga.js
export function* loginFlow() {
	while (true) {
		const request = yield take("LOGIN_REQUEST");
		const { email, password, redirectTo } = request.data;

		// A `LOGOUT` action may happen while the `authorize` effect is going on, which may
		// lead to a race condition. This is unlikely, but just in case, we call `race` which
		// returns the "winner", i.e. the one that finished first
		const winner = yield race({
                        // Authorise is another saga, which logs the user in async
			auth: call(authorize, { email, password, isRegistering: false }),
			logout: take("LOGOUT")
		});

		// If `authorize` was the winner...
		if (winner.auth) {
			// ...we send Redux appropriate actions
			yield put({ type: "IS_USER_LOGGED_IN", newAuthState: true }); // User is logged in (authorized)
			yield put({
				type: "CHANGE_FORM",
				newFormState: { email: "", password: "" }
			}); // Clear form

			// Send new URL to react router
			yield put(push(redirectTo)); // Go to Home page
		}
	}
}

Currently my best plan was to mock the async function to run infinitely and then dispatch another action which would then be caught and cancel the infinite function.(see below)
However this just causes Jest to run forvever and it never logs anything, so I'm guessing this isn't the correct way to do it. How should you go about this?
testAuthSaga.js
// Import saga
import {
	loginFlow,
	__RewireAPI__ as authSagaRewire
} from "services/auth/authSaga";

// Initial state for store
const initialState = {
	userName: "",
	token: "",
	statusText: {},
	sendingRequest: false,
	loggedIn: false
};

describe("test login saga", () => {
	let sagaTester = null;

	beforeEach(() => {
		// Init code
		sagaTester = new SagaTester({ initialState });
		sagaTester.start(loginFlow);
	});

	test("Logout firing before login completes shouldn't login user", () => {
		// Use rewire to allow mocking of single function
		authSagaRewire.__Rewire__("authorize", function* mock() {
			// Have authorize run infinitely while waiting for next action
			while (true) {
				...
			}
		});

		// Our test (Actions is our standard redux action component). Start the saga with the LOGIN_REQUEST action
                sagaTester.dispatch(
			{ type: "LOGIN_REQUEST" },
			{
				email<EMAIL_ADDRESS>				password: "123",
				redirectTo: "/"
			}
		);

                // Authorize should now be looping indefinitely. Dispatch logout.
		sagaTester.dispatch({ type: "LOGOUT" });

		// Check that LOGOUT gets called before IS_USER_LOGGED_IN
		console.log(sagaTester.getCalledActions());
	});
});

Lib information
    "@babel/core": "^7.4.0",
    "@babel/polyfill": "^7.4.3",
    "@babel/plugin-proposal-class-properties": "^7.4.0",
    "@babel/plugin-proposal-decorators": "^7.4.0",
    "@babel/plugin-proposal-export-default-from": "^7.2.0",
    "@babel/plugin-syntax-export-default-from": "^7.2.0",
    "@babel/preset-react": "^7.0.0",
    "@babel/plugin-transform-react-display-name": "^7.2.0",
    "babel-plugin-rewire": "^1.2.0",
    "babel-plugin-undeclared-variables-check": "6.22.0",
    "babel-preset-stage-1": "^6.24.1",
    "jest": "^24.5.0",
    "jest-dom": "^3.1.3",
    "redux": "4.0.0",
    "redux-saga": "^1.0.1",
    "redux-saga-tester": "^1.0.416",

Try mocking authorize like this:
authSagaRewire.Rewire("authorize", () => new Promise())
It simply returns an unresolved promise, and so its call effect won't resolve and win the race.

That's worked perfectly. Thanks very much @InterAl.

Here is my example test for anyone else who finds this:
test("Hitting logout after submitting login, should log you out", () => {
		// Use rewire to allow mocking of single function
		authSagaRewire.__Rewire__(
			"authorize",
			() =>
				new Promise((resolve, reject) => {
					// Unresolved promise won't fire
				})
		);

		// Our test (Actions is our standard redux action component). Start the saga with the START action
		sagaTester.dispatch(
			loginRequest({
				email<EMAIL_ADDRESS>				password: "123",
				redirectTo: "/"
			})
		);

		sagaTester.dispatch(logout());

		// Wait for the logged in action
		sagaTester.waitFor(LOGOUT);
	});```


Minimal installation

Hi,
We're developing a highly specific web interface based on gemini db's. We're putting this in a docker image, and are trying to keep things as minimal as possible.
Any advice on how to lower the amount of dependencies? For now, we only need the gemini query function, so all the rest is too much.
A conda installation adds a whole lot of unneeded fluff. Is there a better way? Perhaps to only install the executable with the dependencies needed for the query subroutine.
A plus would also be if we could get it to work in a alpine image.
Thanks for the help
M

I can't be much help on this. I guess you'd just try removing stuff and see what happens.

Hi @matthdsm ,
I was wondering how you fared with doing this? I'm also trying to create a minimal installation and conda adds an extra GB in dependencies. I tried installing manually (as described here, which would be a much smaller installation, but unfortunately I run into an irresolvable error (see below) when running the setup.py script.
Downloading https://files.pythonhosted.org/packages/ee/5b/5afcd1c46f97b3c2ac3489dbc95d6ca28eacf8e3634e51f495da68d97f0f/scipy-1.3.1.tar.gz#sha256=2643cfb46d97b7797d1dbdb6f3c23fe3402904e3c90e6facfe6a9b98d808c1b5 Best match: scipy 1.3.1 Processing scipy-1.3.1.tar.gz Writing /tmp/easy_install-KTx62P/scipy-1.3.1/setup.cfg Running scipy-1.3.1/setup.py -q bdist_egg --dist-dir /tmp/easy_install-KTx62P/scipy-1.3.1/egg-dist-tmp-99eDEM Traceback (most recent call last):   File "setup.py", line 46, in <module>     'Topic :: Scientific/Engineering :: Bio-Informatics']   File "/usr/lib/python2.7/dist-packages/setuptools/__init__.py", line 129, in setup     return distutils.core.setup(**attrs)   File "/usr/lib/python2.7/distutils/core.py", line 151, in setup     dist.run_commands()   File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands     self.run_command(cmd)   File "/usr/lib/python2.7/distutils/dist.py", line 972, in run_command     cmd_obj.run()   File "/usr/lib/python2.7/dist-packages/setuptools/command/install.py", line 67, in run     self.do_egg_install()   File "/usr/lib/python2.7/dist-packages/setuptools/command/install.py", line 117, in do_egg_install     cmd.run()   File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 437, in run     self.easy_install(spec, not self.no_deps)   File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 679, in easy_install     return self.install_item(None, spec, tmpdir, deps, True)   File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 726, in install_item     self.process_distribution(spec, dist, deps)   File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 771, in process_distribution     [requirement], self.local_index, self.easy_install   File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 774, in resolve     replace_conflicting=replace_conflicting   File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 1057, in best_match     return self.obtain(req, installer)   File "/usr/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 1069, in obtain     return installer(requirement)   File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 698, in easy_install     return self.install_item(spec, dist.location, tmpdir, deps)   File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 724, in install_item     dists = self.install_eggs(spec, download, tmpdir)   File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 909, in install_eggs     return self.build_and_install(setup_script, setup_base)   File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 1177, in build_and_install     self.run_setup(setup_script, setup_base, args)   File "/usr/lib/python2.7/dist-packages/setuptools/command/easy_install.py", line 1163, in run_setup     run_setup(setup_script, args)   File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 253, in run_setup     raise   File "/usr/lib/python2.7/contextlib.py", line 35, in __exit__     self.gen.throw(type, value, traceback)   File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 195, in setup_context     yield   File "/usr/lib/python2.7/contextlib.py", line 35, in __exit__     self.gen.throw(type, value, traceback)   File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 166, in save_modules     saved_exc.resume()   File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 141, in resume     six.reraise(type, exc, self._tb)   File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 154, in save_modules     yield saved   File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 195, in setup_context     yield   File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 250, in run_setup     _execfile(setup_script, ns)   File "/usr/lib/python2.7/dist-packages/setuptools/sandbox.py", line 45, in _execfile     exec(code, globals, locals)   File "/tmp/easy_install-KTx62P/scipy-1.3.1/setup.py", line 31, in <module>     'static/third_party/bootstrap/css/*', RuntimeError: Python version >= 3.5 required.


more tests

[Current coverage][cc-pull] is 5.67%

Merging [#8][cc-pull] into [master][cc-base-branch] will increase coverage by 0.15%

@@            master        #8   diff @@
========================================
  Files           14        15     +1
  Lines         1412      1445    +33
  Methods          0         0
  Messages         0         0
  Branches         0         0
========================================
+ Hits            78        82     +4
- Misses        1334      1363    +29
  Partials         0         0

Powered by Codecov. Last updated by [0e8a274...c4f0668][cc-compare]
[cc-base-branch]: https://codecov.io/gh/CyberReboot/vent/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/CyberReboot/vent/compare/0e8a2747a155d2702465b1b56b2699eb1846c67a...c4f0668aa04ea16e5a02b90eacef78d5bed4094c
[cc-pull]: https://codecov.io/gh/CyberReboot/vent/pull/8?src=pr


manifest: Add awscli2 to RHEL 9 AMI (CLOUDX-913)

The awscli2 package is included in the upcoming RHEL 9.5.0 release and it would be helpful to include it in AWS AMIs by default.

If this is only in 9.5 and later it will need a check for common.VersionGreaterThanOrEqual(t.Arch().Distro().OsVersion(), "9.5")

If this is only in 9.5 and later it will need a check for common.VersionGreaterThanOrEqual(t.Arch().Distro().OsVersion(), "9.5")

Thanks, @bcl! I missed that even though it was in the section just below the one I edited. 🤦♂

Looks ok to me, assuming 2 things:
* we want it on all ec2 based images (I assume we do)

That's the current plan.

* It is already in the 9.5 repos (otherwise testing will blow up)

It is in the nightly composes today.

Looks ok to me, assuming 2 things:
* we want it on all ec2 based images (I assume we do)

That's the current plan.

* It is already in the 9.5 repos (otherwise testing will blow up)

It is in the nightly composes today.

Looks like it's already been there for a couple of weeks 'cause it's in our rpmrepo snapshots from 01 June.


Update useLayoutEffect dependencies to ensure TabLine resizes

Adds two additional dependencies to the useLayoutEffect inside of TabLine that will ensure it's width is updated properly when the text inside the tab item changes.
Closes #2004
✅ Pull Request Checklist:

[x] Included link to corresponding React Spectrum GitHub Issue.
[x] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[x] Filled out test instructions.
[x] Updated documentation (if it already exists for this component).
[x] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:
I attempted to write a new test to check that the inline style for width is updated correctly, however because the value is calculated using element offsets, those values always end up at 0 in a non-browser environment. So I added a new Storybook story instead to visualize the bugfix.
Scenario 1

View new Storybook story for Tabs -> Tab 1 controlled TabList item
Use the text field to adjust the first tab text
Validate the TabLine grows/shrinks as expected

Scenario 2

View new Storybook story for Tabs -> Tab 1 controlled TabList item
Select Tab 2
Use the text field to adjust the first tab text
Validate the TabLine for Tab 2 moves horizontally to maintain alignment beneath Tab 2

Can probably take similar approach to font loading here https://github.com/adobe/react-spectrum/pull/3759/commits/e8829a8ddafb52122a9b00a9a37727a55c07c495#diff-6fa8be0fd81806f4ca7cebb681f725674ae8cbebd3187fea8fd8939cac53fca7R120


Color picked from screen doesn't immediately update the button

Godot version
d26442e
System information
Windows 10 x64
Issue description

Probably some signal isn't emitted.
Steps to reproduce

Have a ColorPickerButton (can use one from the inspector)
Click it and use the pick button to pick color from screen

Minimal reproduction project
No response

I can reproduce this and have seen this bug when using the color picker.

Because when sampling, the signal is emitted when the LMB is released, but the internal PopupPanel closes when the left button is pressed. So when sampling, the color_changed signal will not be emitted.

I believe the problem appeared with a change to how the popup/viewport works.
Even with the screen Control set as top level, it's still behind the picker's PopupPanel. So, when you click on the screen, instead of calling the _screen_input method, it's calling the ColorPicker's notification method with a NOTIFICATION_WM_CLOSE_REQUEST, which simply hides screen without updating the color.
This could be worked around by adding a emit_signal(SNAME("color_changed"), color); before the screen->hide(); here:
https://github.com/godotengine/godot/blob/d26442e709f6361af9ac755ec9291bb43f2cd69b/scene/gui/color_picker.cpp#L103-L107
But there's probably a better way of doing that?
I tried to fix it more cleanly by creating a new fullscreen popup with a transparent background, but I didn't manage to do this, the background always appeared black.

I'm a little curious about how the screenshot tool/screen recording tool works.

This describes the screen tool works.

https://github.com/godotengine/godot/blob/d26442e709f6361af9ac755ec9291bb43f2cd69b/editor/editor_node.cpp#L2897-L2898
https://github.com/godotengine/godot/blob/d26442e709f6361af9ac755ec9291bb43f2cd69b/editor/editor_node.cpp#L2970-L2981
https://github.com/godotengine/godot/blob/d26442e709f6361af9ac755ec9291bb43f2cd69b/editor/editor_node.cpp#L2957-L2968

The screen recording tool uses another path.

I'm looking at this right now, I think it happens because _screen_input never gets a valid InputEventMouseButton:
Ref<InputEventMouseButton> bev = p_event;
if (bev.is_valid() && bev->get_button_index() == MouseButton::LEFT && !bev->is_pressed()) {
	emit_signal(SNAME("color_changed"), color);

Which leads to that it never emits the color_changed event.
Couldn't figure out what's causing it, might continue with it tomorrow unless someone else fixes it faster.

@MinusKube added your suggested workaround to a PR. I think fixing it for now is preferable to holding off for a proper solution.

This appears to be fixed in master according to https://github.com/godotengine/godot/pull/63886#issuecomment-1434293609.


Rename pilot to docs

Renames the use of "pilot" to "docs" where applicable, and cleans up some other small docs things.
ref: https://github.com/2i2c-org/docs/issues/125

Oh no, now I got relaxed and suddenly it was in the infrastructure repo =/

haha I think this is fine - the PR is only touching docs and tests are happy. IMO we should just try to be reasonable and use our best judgment about whether merging a PR is controversial or not. IMO in this case it's OK


Ensure dependencies are correct

Description
While working with yarn v2 (with Plug-n-Play) it becomes immediately obvious that there are a lot of missing dependency declarations in Tina. Yarn with plug-n-play (and others like pnpm) won't load undeclared transitive dependencies, and it gives a pretty decent error report. Through that I've managed to get Tina working but most of these fixes should be handled in the packages themselves. What I've seen for the most part is we have lots of packages which import a module and don't list it as a peer dependency or a dependency - I think these should be treated as bugs.
Example
An example is @tinacms/fields not declaring @tinacms/form-builder as a dependency.
It's declared as a devDependency here but that doesn't help. Here's where it's being used.
Steps to reproduce
I've created a repo here. In one folder is a next.js app with Tina, and in the other is the identical app with yarn v2. If you have any issues running yarn let me know.
Expected result
The app should boot up, but it throws dependency errors and won't resolve them. I've fixed these in the .yarnrc.yml file but I have them commented out for demonstration purposes. Uncommenting the packageExtensions should result in a successful build.

The issue I have is figuring out what the "correct dependencies" even means.
Let's say  react-tinacms-editor has @tinacms/react-core as a peerDependency.
If I install tinacms then @tinacms/react-core is installed, but npm install will still throw a warning that react-tinacms-editor is missing @tinacms/react-core as a peerDependency even though there will be no problem when running the code.
Well what if I just make @tinacms/react-core a dependency of react-tinacms-editor? That can work sometimes, but because @tinacms/react-core declares a React.createContext I can run into big trouble. If by change that package gets installed in the node_modules in two instances then you'll start seeing really funky bugs because React's Context objects are singletons per installed package.
Since we just switched to fixed versioning, making everything a dependency rather then a peerDependency could be viable now.

Let's say react-tinacms-editor has @tinacms/react-core as a peerDependency.
If I install tinacms then @tinacms/react-core is installed, but npm install will still throw a warning that react-tinacms-editor is missing @tinacms/react-core as a peerDependency even though there will be no problem when running the code.

I'm not sure that's the best example because from what I can see react-tinacms-editor doesn't import anything from @tinacms/react-core. Also - are you saying it would still throw that warning if you did list it in your peer dependencies? I'm saying I don't think that would be the case.
But in theory if react-tinacms-editor did import something from @tinacms/react-core what I'm saying is that it should be listed as a peerDependency. The problem here is that the peer dependency is implicit. By declaring it as a peerDependency we're telling the package manager that we acknowledge we are using this module in our runtime code so make sure you get it from one of our parents. I get it that it's a pain but that's the downside of having a lot of different packages.

even though there will be no problem when running the code.

For some package managers there will be a problem running the code. Since node has no concept of “package”, it doesn’t know whether a file is meant to be accessed, the example you provided wont work on pnpm or yarn pnp. I think it's ok to be loose the peer dependencies if you're the end user but as a package we don't have that luxury.
And yes I agree that you shouldn't make @tinacms/react-core a dependency of react-tinacms-editor because it's also a dependency of tinacms. I understand your point about duplicate singleton issues - I think in general most dependencies should be declared in the tinacms package, while the others should mostly have peerDependencies.  And then of course above tinacms it makes sense that you need to declare the big dogs on your own (react, react-dom, and I guess styled-components)

The issue I have is figuring out what the "correct dependencies" even means.

At least in the context of Yarn PnP (which as of today Tina still does not seem compatible with), it means

Every package you use must be declared explicitly as either a dependency or a peer dependency.
If you depend on a package with peer dependencies, you must explicitly declare its peer dependencies as either dependencies or peer dependencies of your own.

Two examples of an incorrect setup:

Package A uses React and package B, and lists both as dependencies.
Package B uses React, and does not list it as a dependency or peer dependency.

This won't work, because package B needs to explicitly declare React a (peer) dependency.

Package A uses React and package B, and lists both as dependencies.
Package B uses package C, and lists it as a dependency.
Package C uses React, and lists it as a peer dependency.

This won't work, because C's lookup for React stops at B. For it to use A's version of React, B needs to declare React a peer dependency.


Update Get-MailDetailMalwareReport.md

@chrisda

Docs Build status updates of commit f8a056a:
:clock10: Full build: the average full build time is 17 min(s) 41 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit f8a056a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Get-MailDetailMalwareReport.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 622a27b:
:clock10: Full build: the average full build time is 17 min(s) 38 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 622a27b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Get-MailDetailMalwareReport.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


High performance cross product

Added support for the RandomForest model w/ and w/o CrossProduct optimization. The CrossProduct optimization achieved more than 2x speedup.
Note that the following Compiler flags are used and may need to be tuned for different environment:
src/conf/headers/Configuration.h:
#ifndef DEFAULT_MEM_SIZE
#define DEFAULT_MEM_SIZE ((size_t)(62) * (size_t)(1024) * (size_t)(1024))
#endif

#ifndef DEFAULT_NUM_CORES
#define DEFAULT_NUM_CORES 8
#endif

./src/builtInPDBObjects/headers/TreeResult.h:
#define MAX_BLOCK_SIZE 275000
./src/builtInPDBObjects/headers/Forest.h:
#define MAX_NUM_TREES 1600 #define MAX_NUM_NODES_PER_TREE 512
w/o CrossProduct optimization:
./scripts/cleanupNode.sh

./scripts/startPseudoCluster.py 8 15000

bin/testDecisionForest Y 2200000 28 275000 F A 32 model-inference/decisionTree/experiments/HIGGS.csv_test.csv

bin/testDecisionForest N 2200000 28 275000 F A 32 model-inference/decisionTree/experiments/HIGGS.csv_test.csv model-inference/decisionTree/experiments/models/higgs_randomforest_1600_8_netsdb RandomForest

output count:2200000
positive count:1119844
1st time execution:
****UDF Execution Time Duration: ****112.956 secs.
****UDF Load Model Time Duration: ****4.20368 secs.
2nd time execution:
****UDF Execution Time Duration: ****107.671 secs.
****UDF Load Model Time Duration: ****0.804746 secs.
w/ CrossProduct optimization:
./scripts/cleanupNode.sh

./scripts/startPseudoCluster.py 8 15000

bin/testDecisionForestWithCrossProduct Y 2200000 28 275000 32 model-inference/decisionTree/experiments/HIGGS.csv_test.csv model-inference/decisionTree/experiments/models/higgs_randomforest_1600_8_netsdb RandomForest

//**Note that now we need provide one more parameter at the end: numTrees**

bin/testDecisionForestWithCrossProduct N 2200000 28 275000 32 model-inference/decisionTree/experiments/HIGGS.csv_test.csv model-inference/decisionTree/experiments/models/higgs_randomforest_1600_8_netsdb RandomForest **1600**

total count:2200000
positive count:1119844
1st execution time:
****Model Inference Time Duration: ****45.7068 secs.
2nd execution time:
****Model Inference Time Duration: ****44.1866 secs.

@hguan6 Please take a look. Let me know if any problem.

After I ran bin/testDecisionForest N 2200000 28 275000 F A 32 HIGGS.csv_test.csv model-inference/decisionTree/experiments/models/higgs_randomforest_1600_8_netsdb RandomForest, I got an error:
not builtin and no catalog connection, typeId for pdb::AbstractAggregateCompis 8191
not builtin and no catalog connection, typeId for pdb::Computationis 8191
Not create a set and not load new data to the input set
to search for set in Catalog: decisionForest:labels
Cannot remove set from Catalog, Set decisionForest.labels does not exist
to broadcast StorageRemoveUserSet
2:getNextObject with msgSize=80
Failed to delete set on 1 nodes. Skipping registering with catalog
to search for set in Catalog: decisionForest:labels
Set decisionForest:labels does not exist
the internalTypeName for pdb::Vector<float> is pdb::Vector<pdb::Nothing> and typeID is 159
Create PDBCatalogSet instance of primary key being: decisionForest:labels
the internalTypeName for pdb::Vector<float> is pdb::Vector<pdb::Nothing> and typeID is 159
Create PDBCatalogSet instance of primary key being: decisionForest:labels
This is not Manager Catalog Node, thus metadata was only registered locally!
Node IP: localhost updated correctly!
******************** desired size = 1000********************
%%%%%%%%%%%%%%%%%DistributedStorageManagerServer: to add private set%%%%%%%%%%%%%%%
Page size is determined to be 67108864
No Computation and Lambda for partitioning
to broadcast StorageAddset
received StorageAddSet
%%%%%%%%Pangea to add a private set%%%%%%%%%%%
creating set in Pangea in distributed environment...with setName=labels
to add set with dbName=decisionForest, typeName=pdb::Vector<float>, setName=labels, setId=1, pageSize=67108864
type not recognized: -1
type doesn't  exist for name=pdb::Vector<float>, and we store it as default type
path to meta file is pdbRoot_localhost_8109/meta/1_decisionForest/0_UnknownUserData/1_labels
file opened:pdbRoot_localhost_8109/data/1_decisionForest/0_UnknownUserData/1_labels
meta file exists
Number of existing pages = 0
to add set with dbName=decisionForest, typeName=UnknownUserData, setName=labels, setId=1, pageSize=67108864
2:getNextObject with msgSize=52
broadcasted StorageAddSet
Created set.
terminate called after throwing an instance of 'std::invalid_argument'
  what():  stoi
Aborted (core dumped)

Hi Hong, I will investigate the error this evening after teaching and meetings. It seems the program meets errors when parsing the model. Have you tried to use the model that I uploaded to S3 for converting to netsDB?

Hi Hong, I will investigate the error this evening after teaching and meetings. It seems the program meets errors when parsing the model. Have you tried to use the model that I uploaded to S3 for converting to netsDB?

Yes, I converted it from the .pkl file in S3.

@hguan6 I fixed the problem. Please check again.
Note that for the second command, now we need add a parameter to specify the number of trees at the end.
bin/testDecisionForestWithCrossProduct N 2200000 28 275000 32 model-inference/decisionTree/experiments/HIGGS.csv_test.csv model-inference/decisionTree/experiments/models1/higgs_randomforest_1600_8_netsdb RandomForest 1600

@jiazou-bigdata I still got the same error message. Do I need to do something else besides pulling the latest code?

@jiazou-bigdata I still got the same error message. Do I need to do something else besides pulling the latest code?
The model files downloaded from S3 run well from my side. Which branch are you at? Did you recompile the code by running scons libDFTest?

The model files downloaded from S3 run well from my side. Which branch are you at? Did you recompile the code by running scons libDFTest?

I didn't recompile the code. Let me do that now.

I recompiled the code. The w Cross product code runs well, and I got:
****Model Inference Time Duration: ****44.7118 secs.
But I got some other errors when I ran the code without Cross product. The error message for bin/testDecisionForest N 2200000 28 275000 F A 32 HIGGS.csv_test.csv model-inference/decisionTree/experiments/models/higgs_randomforest_1600_8_netsdb RandomForest:
not builtin and no catalog connection, typeId for pdb::AbstractAggregateCompis 8191
not builtin and no catalog connection, typeId for pdb::Computationis 8191
Not create a set and not load new data to the input set
to search for set in Catalog: decisionForest:labels
Cannot remove set from Catalog, Set decisionForest.labels does not exist
to broadcast StorageRemoveUserSet
2:getNextObject with msgSize=80
Failed to delete set on 1 nodes. Skipping registering with catalog
to search for set in Catalog: decisionForest:labels
Set decisionForest:labels does not exist
the internalTypeName for pdb::Vector<float> is pdb::Vector<pdb::Nothing> and typeID is 159
Create PDBCatalogSet instance of primary key being: decisionForest:labels
the internalTypeName for pdb::Vector<float> is pdb::Vector<pdb::Nothing> and typeID is 159
Create PDBCatalogSet instance of primary key being: decisionForest:labels
This is not Manager Catalog Node, thus metadata was only registered locally!
Node IP: localhost updated correctly!
******************** desired size = 1000********************
%%%%%%%%%%%%%%%%%DistributedStorageManagerServer: to add private set%%%%%%%%%%%%%%%
Page size is determined to be 67108864
No Computation and Lambda for partitioning
to broadcast StorageAddset
received StorageAddSet
%%%%%%%%Pangea to add a private set%%%%%%%%%%%
creating set in Pangea in distributed environment...with setName=labels
to add set with dbName=decisionForest, typeName=pdb::Vector<float>, setName=labels, setId=1, pageSize=67108864
type not recognized: -1
type doesn't  exist for name=pdb::Vector<float>, and we store it as default type
path to meta file is pdbRoot_localhost_8109/meta/1_decisionForest/0_UnknownUserData/1_labels
file opened:pdbRoot_localhost_8109/data/1_decisionForest/0_UnknownUserData/1_labels
meta file exists
Number of existing pages = 0
to add set with dbName=decisionForest, typeName=UnknownUserData, setName=labels, setId=1, pageSize=67108864
2:getNextObject with msgSize=52
broadcasted StorageAddSet
Created set.
model-inference/decisionTree/experiments/models/higgs_randomforest_1600_8_netsdb/951.txt
process inner nodes
terminate called after throwing an instance of 'std::invalid_argument'
  what():  stoi
Aborted (core dumped)

Now it should work. Please try again!

Yes, I will try it now.

hguan6, can you take a look at this and help merge these two?

Yes, once I finish the TFDF experiments,  I will take a look.


MacOS says "no credentials found" after some time

Thank you for opening an issue! If this is a bug report, please include the
following information:

Yubico Authenticator version: 4.3.2+1
Operating system and version: MacOS 10.12.6 (same issue on High Sierra)
YubiKey model and version: Yubikey Neo 3.3.0
Bug description summary:

I typically reboot my macs infrequently, perhaps once per month. I have 2, a MacBook and an iMac. Both experience the same problem. After some time, the yubico authenticator application stops generating codes. A reboot of the mac fixes the problem. When it's in the broken state, I open Yubico Authenticator, it says "No YubiKey detected", then "Connecting to YubiKey", then finally (after maybe 20 to 30 seconds) "No credentials found".
I'm not sure how to debug the issue. I've tried different USB ports. I see the same behaviour on both macs (one High Sierra, one Sierra) which leads me to think it's not the computers.
Can I somehow get debugging logs out of the authenticator app?
EDIT: Also, when it's in this "broken" state, quitting Yubico Authenticator does not work. The window disappears, but the application never quits. I need to force quit in order to close it.

Thanks for all the debugging help. I'm guessing it's not possible for you to try with another yubikey? At this point, since there are some known issues with CCID on your firmware version, I would suggest opening a support ticket and looking in to having your device replaced (link them this thread in the ticket).

@dagheyman I have other yubikeys, but they’re older, don’t know if they support all this smart new stuff. I think I have two of these but I’m not 100% sure. I’ll reach out to support as you suggested also.

Testing with a brand new yubikey neo, and I have the same very, very long time until it says "No credentials found". There are no credentials on this one, but it takes more than 1 minute to figure that out.
Now I've added one credential, and I have the exact same process as originally reported.

but it takes more than 1 minute to figure that out

Very wierd, and we can't reproduce this on our macs. Do you have any other software running related to USB or smart cards that you think might be interfering? And just to double check, you see the same behaviour on two different machines?

Yes, same problem on 2 macs. I do have the Estonian e-residency smartcard stuff installed on my desktop, but I don't think I have that installed on my laptop.
I also have many different yubico apps installed, the authenticator, manager, and personalisation tool. I noticed the request for root permissions during install and I wonder if something has been left over from a previous installation that somehow didn't get properly removed. I'm mostly guessing, have no idea how these things work.
I'll double check if I have the Estonian stuff on the laptop.

Just checked and definitely I don't have the Estonian e-id smart card apps on my laptop, and I see the same behaviour on the laptop as on the desktop. They're running different versions of MacOS also. I have the yubico authenticator and the yubikey personalisation tool both installed on the laptop.

@dagheyman I've been testing a bit on my laptop, and I haven't seen the same issue. So it might be that there's a clash between the estonian e-id smart card software and yubico. Any idea how we can debug?

I don't know much about the estonian e-id software. Is it software that is always running? Can I try to reproduce it myself or do I need a e-residency? Does uninstalling it resolve the issue?
There is a new version out of Yubico Authenticator (4.3.3), you could try running that with --log-level DEBUG again and see if it spits out anything interesting.

@dagheyman I'm not sure about the always running question. Is the yubico authenticator always running? I noticed that both require sudo to install, but why that is, I've no idea.
I believe the e-id software can be installed without the need for an id card here: https://installer.id.ee/?lang=eng

Do you have the same issue with 4.3.4 ? Debug logs would be interesting.

@dagheyman I've been keeping an eye on this. I haven't seen the issue recently. I'll keep an eye on it for another month or so, and if it doesn't reappear in that time, I'll close this issue.

I've been keeping an eye on this. I haven't seen the issue recently. I'll keep an eye on it for another month or so, and if it doesn't reappear in that time, I'll close this issue.

Sounds good, thanks.

Using 4.3.4 on OSX 10.11.6
Authenticator says "No credentials found."
File > New Credential... Save -- does nothing

2018-07-29T19:12:49-0400 INFO [ykman.logging_setup.setup:59] Initialized logging for ykman version: 0.7.0
2018-07-29T19:12:49-0400 DEBUG [ykman.descriptor.Descriptor.open_device:80] transports: 0x1, self.mode.transports: 0x7
2018-07-29T19:12:49-0400 DEBUG [ykman.descriptor.open_device:84] Opening driver for serial: None, pid: PID.NEO_OTP_FIDO_CCID
2018-07-29T19:12:49-0400 DEBUG [ykman.descriptor.open_device:86] Attempt 1 of 10
2018-07-29T19:12:49-0400 DEBUG [ykman.driver_otp.open_devices:180] Success in opening key at position 0
2018-07-29T19:12:49-0400 DEBUG [ykman.descriptor.open_device:89] Found driver: <ykman.driver_otp.OTPDriver object at 0x1179b15f8>, pid: PID.NEO_OTP_FIDO_CCID
2018-07-29T19:12:49-0400 DEBUG [ykman.device.init:196] Read config from device...
2018-07-29T19:12:49-0400 DEBUG [ykman.device.init:211] Failed to read config from device
Traceback (most recent call last):
File "/Applications/Yubico Authenticator.app/Contents/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ykman/device.py", line 197, in init
config = DeviceConfig(driver.read_config())
File "/Applications/Yubico Authenticator.app/Contents/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ykman/driver_otp.py", line 133, in read_config
raise NotSupportedError()
ykman.driver.NotSupportedError
2018-07-29T19:12:49-0400 DEBUG [ykman.device.init:117] Config data empty/missing
2018-07-29T19:12:49-0400 DEBUG [ykman.device.init:225] Identified NEO
2018-07-29T19:12:49-0400 DEBUG [ykman.device.init:230] CCID not available, guess capabilities
2018-07-29T19:12:49-0400 DEBUG [ykman.driver_otp.del:167] Destroy <ykman.driver_otp.OTPDriver object at 0x1179b15f8>
2018-07-29T19:12:49-0400 DEBUG [ykman.driver_otp.close:162] Close <ykman.driver_otp.OTPDriver object at 0x1179b15f8>
2018-07-29T19:12:50-0400 DEBUG [ykman.descriptor.Descriptor.open_device:80] transports: 0x1, self.mode.transports: 0x7
2018-07-29T19:12:50-0400 DEBUG [ykman.descriptor.open_device:84] Opening driver for serial: None, pid: PID.NEO_OTP_FIDO_CCID
2018-07-29T19:12:50-0400 DEBUG [ykman.descriptor.open_device:86] Attempt 1 of 10
2018-07-29T19:12:50-0400 DEBUG [ykman.driver_otp.open_devices:180] Success in opening key at position 0
2018-07-29T19:12:50-0400 DEBUG [ykman.descriptor.open_device:89] Found driver: <ykman.driver_otp.OTPDriver object at 0x119dd8b38>, pid: PID.NEO_OTP_FIDO_CCID
2018-07-29T19:12:50-0400 DEBUG [ykman.device.init:196] Read config from device...
2018-07-29T19:12:50-0400 DEBUG [ykman.device.init:211] Failed to read config from device
Traceback (most recent call last):
File "/Applications/Yubico Authenticator.app/Contents/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ykman/device.py", line 197, in init
config = DeviceConfig(driver.read_config())
File "/Applications/Yubico Authenticator.app/Contents/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ykman/driver_otp.py", line 133, in read_config
raise NotSupportedError()
ykman.driver.NotSupportedError
2018-07-29T19:12:50-0400 DEBUG [ykman.device.init:117] Config data empty/missing
2018-07-29T19:12:50-0400 DEBUG [ykman.device.init:225] Identified NEO
2018-07-29T19:12:50-0400 DEBUG [ykman.device.init:230] CCID not available, guess capabilities
2018-07-29T19:12:50-0400 DEBUG [ykman.otp.calculate:201] Sending a challenge to the device. Slot 2. Attempt 1. Wait for touch is False.
2018-07-29T19:12:51-0400 DEBUG [ykman.otp.calculate:211] Got ykpers error 4, b'timeout' as expected.
2018-07-29T19:12:51-0400 DEBUG [ykman.driver_otp.close:162] Close <ykman.driver_otp.OTPDriver object at 0x119dd8b38>
2018-07-29T19:12:51-0400 DEBUG [ykman.driver_otp.del:167] Destroy <ykman.driver_otp.OTPDriver object at 0x119dd8b38>
2018-07-29T19:13:51-0400 DEBUG [ykman.descriptor.Descriptor.open_device:80] transports: 0x1, self.mode.transports: 0x7
2018-07-29T19:13:51-0400 DEBUG [ykman.descriptor.open_device:84] Opening driver for serial: None, pid: PID.NEO_OTP_FIDO_CCID
2018-07-29T19:13:51-0400 DEBUG [ykman.descriptor.open_device:86] Attempt 1 of 10
2018-07-29T19:13:51-0400 DEBUG [ykman.driver_otp.open_devices:180] Success in opening key at position 0
2018-07-29T19:13:51-0400 DEBUG [ykman.descriptor.open_device:89] Found driver: <ykman.driver_otp.OTPDriver object at 0x119e0d6d8>, pid: PID.NEO_OTP_FIDO_CCID
2018-07-29T19:13:51-0400 DEBUG [ykman.device.init:196] Read config from device...
2018-07-29T19:13:51-0400 DEBUG [ykman.device.init:211] Failed to read config from device
Traceback (most recent call last):
File "/Applications/Yubico Authenticator.app/Contents/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ykman/device.py", line 197, in init
config = DeviceConfig(driver.read_config())
File "/Applications/Yubico Authenticator.app/Contents/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ykman/driver_otp.py", line 133, in read_config
raise NotSupportedError()
ykman.driver.NotSupportedError
2018-07-29T19:13:51-0400 DEBUG [ykman.device.init:117] Config data empty/missing
2018-07-29T19:13:51-0400 DEBUG [ykman.device.init:225] Identified NEO
2018-07-29T19:13:51-0400 DEBUG [ykman.device.init:230] CCID not available, guess capabilities
2018-07-29T19:13:51-0400 DEBUG [ykman.otp.calculate:201] Sending a challenge to the device. Slot 2. Attempt 1. Wait for touch is False.
2018-07-29T19:13:52-0400 DEBUG [ykman.otp.calculate:211] Got ykpers error 4, b'timeout' as expected.
2018-07-29T19:13:52-0400 DEBUG [ykman.driver_otp.close:162] Close <ykman.driver_otp.OTPDriver object at 0x119e0d6d8>
2018-07-29T19:13:52-0400 DEBUG [ykman.driver_otp.del:167] Destroy <ykman.driver_otp.OTPDriver object at 0x119e0d6d8>
2018-07-29T19:14:53-0400 DEBUG [ykman.descriptor.Descriptor.open_device:80] transports: 0x1, self.mode.transports: 0x7
2018-07-29T19:14:53-0400 DEBUG [ykman.descriptor.open_device:84] Opening driver for serial: None, pid: PID.NEO_OTP_FIDO_CCID
2018-07-29T19:14:53-0400 DEBUG [ykman.descriptor.open_device:86] Attempt 1 of 10
2018-07-29T19:14:53-0400 DEBUG [ykman.driver_otp.open_devices:180] Success in opening key at position 0
2018-07-29T19:14:53-0400 DEBUG [ykman.descriptor.open_device:89] Found driver: <ykman.driver_otp.OTPDriver object at 0x119e0ddd8>, pid: PID.NEO_OTP_FIDO_CCID
2018-07-29T19:14:53-0400 DEBUG [ykman.device.init:196] Read config from device...
2018-07-29T19:14:53-0400 DEBUG [ykman.device.init:211] Failed to read config from device
Traceback (most recent call last):
File "/Applications/Yubico Authenticator.app/Contents/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ykman/device.py", line 197, in init
config = DeviceConfig(driver.read_config())
File "/Applications/Yubico Authenticator.app/Contents/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/ykman/driver_otp.py", line 133, in read_config
raise NotSupportedError()
ykman.driver.NotSupportedError
2018-07-29T19:14:53-0400 DEBUG [ykman.device.init:117] Config data empty/missing


Add Windriver OSPO

Signed-off-by: Chris Aniszczyk<EMAIL_ADDRESS>Pre-submission checklist:
Please check each of these after submitting your pull request:

[ ] Are you only including a repo_url if your project is 100% open source? If so, you need to pick the single best GitHub repository for your project, not a GitHub organization.
[ ] Is your project closed source or, if it is open source, does your project have at least 250 GitHub stars?
[ ] Have you picked the single best (existing) category for your project?
[ ] Does it follow the other guidelines from the new entries section?
[ ] Have you included a URL for your SVG or added it to hosted_logos and referenced it there?
[ ] Does your logo clearly state the name of the project/product and follow the other logo guidelines?
[ ] Does your project/product name match the text on the logo?
[ ] Have you verified that the Crunchbase data for your organization is correct (including headquarters and LinkedIn)?
[ ] ~10 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

Build failed because of:
No cached entry, and Windriver (Adopter) has issues with logo: windriver.svg, ENOENT: no such file or directory, open '/opt/build/repo/hosted_logos/windriver.svg'
Empty twitter for Apple (Adopter): https://twitter.com/apple
Item Windriver (Adopter) has no image_data


Lost messages using a Web service

When you send a message to a WebService or LogReceiverService lost some messages.
Demo apps:

Sender (AfcNLogTest).
WebServiceReceiver (AfcNLogWebService);
WCFReceiver (AfcNLogWCF);

You can see this by comparing three files:
1 - c:\logs\AfcNLogTest.log:
2014-07-07 17:27:56.9919|TRACE|AfcNLogTest.Program|Log message 0
2014-07-07 17:27:57.6755|DEBUG|AfcNLogTest.Program|Log message 0
2014-07-07 17:27:57.6823|INFO|AfcNLogTest.Program|Log message 0
2014-07-07 17:27:57.6823|WARN|AfcNLogTest.Program|Log message 0
2014-07-07 17:27:57.6823|ERROR|AfcNLogTest.Program|Log message 0
2014-07-07 17:27:57.6979|FATAL|AfcNLogTest.Program|Log message 0

2 - c:\logs\AfcNLogWebService.log:
2014-07-07 17:27:56.9919|TRACE|Client.AfcNLogTest.Program|Log message 0

3 - c:\logs\AfcNLogWCF.log :
2014-07-07 17:27:57.6940|TRACE|AfcNLogTest.Program|Log message 0
2014-07-07 17:27:57.7663|WARN|AfcNLogTest.Program|Log message 0
2014-07-07 17:27:57.7663|FATAL|AfcNLogTest.Program|Log message 0
2014-07-07 17:27:57.7663|INFO|AfcNLogTest.Program|Log message 0
2014-07-07 17:27:57.6940|DEBUG|AfcNLogTest.Program|Log message 0

Ideally, they should be identical!
I will be grateful if you can help solve this problem.
For new results do the following:

Clean c:\logs\AfcNLogWebService.log and c:\logs\AfcNLogWCF.log  and c:\logs\AfcNLogWCF.log ;
Open AfcNLogWebService solution in Visual Studio and Run it;
Open AfcNLogWCF solution in Visual Studio and Run it;
Open AfcNLogTest solution in Visual Studio and Run it;
Compare the log files in the folder c:\logs\;
You can close AfcNLogTest and AfcNLogWebService and AfcNLogWCF.

Related?  #139

@Iehbr89 is it possible to post the code again? Thanks in advance!

Too bad I cannot reproduce this. See #703.
I will check this again when the example code is back online. The fix won't be in 4.0 if we can't reproduce it.

maybe we need also some unit tests with SOAP/WCF (now REST/ApiController)
some info about WCF hosting (for inside unit test): https://msdn.microsoft.com/en-us/library/ee939340.aspx

cannot reproduce, so lowering prio to should have.

possible related #139

Having  the same Issue.

The messages that are received are not in the same order as they are sent.

If I send like 20 to 30 log messages, all the messages are logged properly in other targets such as viewer target but only few are hitting the web service all others are lost.

No Debug information was useful in the internal Log File, double checked it.

Using NLog 4.1

Hi,
We tried to reproduce this, but we failed with that. We really need an example project on this, because (our machines), everything works fine.
To be clear, there are 2 problems?

wrong order
missing messages

Is that correct?
Also, can this has something to do with "cold boot" or "shutting down" (app pool for example)?

Hi,
Yes.
Found why the 2 problems occurred,

Wrong Order - NLog works fine, its due the Web API Application(VS 2013 Web API 2) we created, whenever we get request the application has a pool of threads which assigns to a request and sends it process. We cant tell which thread will run at any given time, so that's why we are getting requests mixed up in wrong order in our application.

Missing Messages - OK, this is weird scenario since we are dealing with multiple threads like say to 20 to 30 there something going wrong in our application or Web API itself which in turn we are losing some requests. So I had to put a lock to sync the threads to make it work.

Now everything works fine. NLog is working fine.
But in some rare case even when putting the locks and everything there are still some missing requests. It may be with the cold boot you are talking about because it always happens when I restart the applications but I am not sure about that.
Thanks for your support guys.

Hey!
Thanks for the info. Can you give some more details (code) on 1. and 2. ? That would be helpful for others :)

We cannot plan this as we need more info to fix this.

Closing this due to inactivity. Please let us know if this still an issue and please provide the requested info.


Android sdk upgrade

Updated Android Estimote SDK to the latest available, and updated methods to support the new SDK. Added support for ranging nearables on Android.

Sorry meant to do this on my copy of the repo.

If you have an working Android SDK update you're welcome to create a pull request to my repo.
('cause I'm not a Java developer).
Thanks :)


Mismatching between mmt-security and Probe: less alerts

I tried to test mmt-sec-standalone and probe with the same pcap. This pcap shows a flooding attack of get requests.
The commands that I tried were
./probe -t flooding_get.pcapng
And
./mmt-sec-stadalone -t flooding_get..pcapng
And as a result I obtain two differents output. MMT-Security rises 19 alerts while Probe rises only 1 alert, as in the images attached.

I think that the cause can be this parameter: By default, MMT-Probe will ignore the security verification on the left of an IP flow when an alert is detected. This is to say that it raises at most one alert per IP flow.
Can you try again within new value, e.g.,:  ignore-remain-flow = false

Perfect, thank you


Enable ORT for HuggingFace workloads

What does this PR do?
This PR is to enable upstream ORT changes for HuggingFace workloads. The changes are picked from https://github.com/ROCmSoftwarePlatform/transformers/pull/14/
It is tested for all ort_huggingface* and ds0_ort_huggingface* workloads in DLM
CC: @jeffdaily @groenenboomj @rraminen

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


zbar: 0.22 -> 0.23

Motivation for this change
Update zbar to 0.23 and add dbus configuration org.linuxtv.Zbar.conf to the closure.
This version adds support for --nodbus to avoid errors like Name Error (Connection ":1.1753" is not allowed to own the service "org.linuxtv.Zbar" due to security policies in the configuration file) when dbus isn't in services.dbus.packages, as it's currently the case.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@delroth @rasendubi

@GrahamcOfBorg build zbar

@GrahamcOfBorg build zbar


[BISERVER-14442] - Database connections using connection pooling will not adhere to changes in the connection details

@pentaho-lmartins
@ssamora
@ppatricio
@smmribeiro

:warning: Build finished in 26m 59s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.steps.combinationlookup.CombinationLookupTest.testCombiInsert (click to expand)
${result.errorDetails}

Tests run: 4891, Failures: 1, Skipped: 7    Test Results

:information_source:  This is an automatic message

:warning: Build finished in 24m 51s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.steps.combinationlookup.CombinationLookupTest.testCombiInsert (click to expand)
${result.errorDetails}

Tests run: 4891, Failures: 1, Skipped: 7    Test Results

:information_source:  This is an automatic message

:warning: Build finished in 27m 12s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.steps.combinationlookup.CombinationLookupTest.testCombiInsert (click to expand)
${result.errorDetails}

Tests run: 4891, Failures: 1, Skipped: 7    Test Results

:information_source:  This is an automatic message

:warning: Build finished in 26m 56s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.steps.combinationlookup.CombinationLookupTest.testCombiInsert (click to expand)
${result.errorDetails}

Tests run: 4891, Failures: 1, Skipped: 7    Test Results

:information_source:  This is an automatic message

:warning: Build finished in 26m 57s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 1 test(s) failed:
org.pentaho.di.trans.steps.combinationlookup.CombinationLookupTest.testCombiInsert (click to expand)
${result.errorDetails}

Tests run: 4891, Failures: 1, Skipped: 7    Test Results

:information_source:  This is an automatic message

Problems with current branch


Add type to not a real type error, and improve message

The type itself isn't actually useful, so closing this.


Call method on expiration

When the state expires, I want to fetch new state from my API. I'd prefer to not duplicate the time checking logic -- so I'd like to have an option to call a method on expiration, allowing me to make a request to my api then dispatch an action to set the redux state (and therefore persist the new state).

You would only get this method to execute on rehydration of redux persist. Can you add the logic on a saga/thunk that happens after that action is fired?

That makes sense and sounds like a good solution. Thanks!


Shift-enter does not insert newline (opt/alt-enter does)

The numbat docs say that shift-enter can be used to insert a newline without submitting the current line. However, on my machine (Mac, in both Terminal.app and VSCode), shift-enter does submit the current line. The way to get a plain newline without submitting is alt-enter.
Is this a bug in numbat and/or should the docs be updated?

This is a difference between the web version and the CLI version. You probably looked at the docs for the web version (https://numbat.dev/doc/web-usage.html) instead of the CLI version (https://numbat.dev/doc/cli-usage.html)?


chore: update var to let/const

Updates the remaining server vars to let/const as discussed in #3151.

The changelog tool wants the changes to match
http://karma-runner.github.io/latest/dev/git-commit-msg.html

Seems like tests fails with these changes. I had same issues, but didn't spent enough time to investigate why. If you would check it, it would be valuable knowledge for everyone :)

Sorry this did not work out. I'm going to close a lot of older pull requests as the source code has changed a lot over the last year.
Thanks!


Support jams >=0.3

From 0.2.x to 0.3.x jams removed the dependency on pandas as the underlying data structure. Supporting jams >=0.3 requires a major overhaul of scaper's internal logic to operate on the new jams data structure.

This change is

cf #21

Coverage remained the same at 100.0% when pulling 30ff375029a20d751584e099e49a282bae5c5996 on newjams into e9c485ed1038e3baccec9759cb399de49968cd4c on master.


[BugFix] Use rollup not table to check UnusedOutputColumns

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #18216
Problem Summary(Required) ：

All the columns of aggregate table cannot be pruned by the UnusedOutputColumns optimization.
Therefore, we check it as follows:
        private void setUnUsedOutputColumns(PhysicalOlapScanOperator node, OlapScanNode scanNode,
                                            List<ScalarOperator> predicates, OlapTable referenceTable) {
            if (materializedIndexMeta.getKeysType().isAggregationFamily() && !node.isPreAggregation()) {
                return;
            }
            // ...
        }

However, there is a case we doesn't consider, where the original table is not aggregate table, but the hit MV is aggregate table.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[x] 2.4
[x] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 6 / 6 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/plan/PlanFragmentBuilder.java
6
6
100.00%
[]

run starrocks_tscancode

run starrocks_admit_test

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-2.3

@Mergify backport branch-3.0


Add LICENSE

Change-type: patch
Resolves: https://github.com/balena-io-experimental/balena-engine-docker/issues/2

I self-certify!


Updated bower.json with main section

To fully support bower the main section is missing in the bower.json file. I updated this to make Office UI Fabric easier to use and inject the code using wiredep.
This should be merged because a newer version of Microsoft 'yo office!' rely on this enhancement.

Hi @StfBauer, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

This is awesome! Thanks @StfBauer !

No problem. Glad I could help!


pico_generate_pio_header() doesn't set include path correctly for .pio.h files inside static libraries

I have a static library with a CMakeLists.txt that starts something like this:

add_library(rp2-async STATIC)
set(SOURCE_FOLDER ${CMAKE_CURRENT_LIST_DIR}/source)
pico_generate_pio_header(rp2-async ${SOURCE_FOLDER}/hardware/uart/pio_uart.pio)
target_sources(rp2-async PRIVATE ${SOURCE_FOLDER}/hardware/uart/pio_uart.cpp)

Then in pio_uart.cpp I try to include the generated header file:

#include "pio_uart.pio.h"

Which doesn't compile because cmake didn't add the include path to the generated .pio.h. Change 'add_library' to 'add_executable' and it compiles just fine.
When I look at the implementation of pico_generate_pio_header() it adds include paths as PRIVATE for executables and as INTERFACE for libaries. If I change INTERFACE to PRIVATE, the source file compiles successfully. Now I don't know nearly enough about cmake to know if this is how to fix it, but I do argue that IMHO generated .pio.h files should not (ever) be part of the public interface of a library.

We exclusively use INTERFACE libraries in the SDK (since they often depend on configuration defines set on the target executable)... that is why "INTERFACE" - everything is public since they are all compiled together.
So I would suggest you do that unless you have a particular reason for creating a static library.
That said, we should fix the cmake to do the correct thing for a static library

Right ... to paraphrase myself: I barely know cmake. Interface library makes sense ... interface library it is.
Also, I just noticed static libraries don't mix that cleanly with pico-sdk anyway. Several SDK files are now compiled twice: once for the library and once for the executable. I guess it might be well defined which of the two .obj files the linker then uses, but it's probably not always harmless. Anyway, interface library it is.

seems this was already closed in 1.3.0


UserPoolDomain set to stack name.

per https://github.com/Senzing/aws-marketplace-evaluation/issues/82

PR merged


Make AzureJacksonMapperAdapter injectable and implement an interface for RestClient

I am trying to use the Azure Data Lake library from a Storm cluster and am repeatably running into issues with the Jackson version that is used in the AzureSDK not being compatible with the version that is provided in Storm.
It would be much easier if the use of jackson was injected via an interface, allowing me to change the implementation of the serialization/deserialization to avoid this problem.

I have previously had the same issue around Jackson dependencies and storm when using the swagger codegen (due to it's dependencies on retrofit/okhttp).

Which version is being used in Storm? I can look into the methods that are potentially incompatible that see if I can use alternatives.
We are actually taking a dependency on retrofit and jackson version is defined by them.

According to mvn central the dependency for Storm is on 2.3.1 for Jackson.
I do know that Retrofit allows the mapper to be pluggable, is it possible to expose this through the Azure API as well?
The line that appears to be causing the problem is in the Jackson Mapper Adapter here:
       mapper.setVisibility(mapper.getSerializationConfig().getDefaultVisibilityChecker().withFieldVisibility(Visibility.ANY).withSetterVisibility(Visibility.NONE).withGetterVisibility(Visibility.NONE).withIsGetterVisibility(Visibility.NONE));

I think the other challenge is that the AzureJacksonMapper is initialised in the build() method of the Buildable class, if it was possible to make this injectable then I would be able to work around the issue I am having.

@jianghaolu is this still an issue?

hi @weidongxu-microsoft could you pls have a look? thanks.


Control Center beta 3 does not open on Mojave

MacOS Mojave 10.14.6 on 15" 2012 MBP

Control Center beta 3 does not open. Nothing happens when clicking; levelling down to app content to click MacOS/Control Center gives this error

Disarming the OS watch tower sprite does nothing
Forcing Control Center out of quarantine results in this:
USER sudo xattr -d com.apple.quarantine /Applications/Control\ Center.app
xattr: /Applications/Control Center.app: No such xattr: com.apple.quarantine
USER sudo codesign --force --deep --sign - /Applications/Control\ Center.app
/Applications/Control Center.app: replacing existing signature
xcrun: error: invalid active developer path (/Library/Developer/CommandLineTools), missing xcrun at: /Library/Developer/CommandLineTools/usr/bin/xcrun
/Applications/Control Center.app: the codesign_allocate helper tool cannot be found or used
In subcomponent: /Applications/Control Center.app/Contents/Frameworks/iTunesAppleScript.framework
I hope you decide to finish it.
best, kk

I know this is late, but this is a Gatekeeper warning. Try pressing Control while you open it. :)


Enhancement: Notesplashes

Week 7 Notesplashes just add a lot of QoL into the game. thats it. if theres a reason not to I understand.

dude. u cant add those till week 7 comes out on desktop

dude. u cant add those till week 7 comes out on desktop

other engines have notesplashes and I was just saying it would be cool.

kade won't add note splashes until week 7 is open source