service-account is not available in the binaries installed by Homebrew.

issue
--service-account is not available in the binaries installed by brew install gdrive
difference
gdrive installed from README.md
 % gdrive help list
List files
gdrive [global] list [options]

global:
  -c, --config <configDir>             Application path, default: /Users/yuehr/.gdrive
  --refresh-token <refreshToken>       Oauth refresh token used to get access token (for advanced users)
  --access-token <accessToken>         Oauth access token, only recommended for short-lived requests because of short lifetime (for advanced users)
  --service-account <serviceAccount>   Oauth service account filename, used for server to server communication without user interaction (filename path is relative to config dir)

options:
  -m, --max <maxFiles>       Max files to list, default: 30
  -q, --query <query>        Default query: "trashed = false and 'me' in owners". See https://developers.google.com/drive/search-parameters
  --order <sortOrder>        Sort order. See https://godoc.org/google.golang.org/api/drive/v3#FilesListCall.OrderBy
  --name-width <nameWidth>   Width of name column, default: 40, minimum: 9, use 0 for full width
  --absolute                 Show absolute path to file (will only show path from first parent)
  --no-header                Dont print the header
  --bytes                    Size in bytes

gdrive installed from brew
% gdrive help list
List files
gdrive [global] list [options]

global:
  -c, --config <configDir>         Application path, default: /Users/yuehr/.gdrive
  --refresh-token <refreshToken>   Oauth refresh token used to get access token (for advanced users)
  --access-token <accessToken>     Oauth access token, only recommended for short-lived requests because of short lifetime (for advanced users)

options:
  -m, --max <maxFiles>       Max files to list, default: 30
  -q, --query <query>        Default query: "trashed = false and 'me' in owners". See https://developers.google.com/drive/search-parameters
  --order <sortOrder>        Sort order. See https://godoc.org/google.golang.org/api/drive/v3#FilesListCall.OrderBy
  --name-width <nameWidth>   Width of name column, default: 40, minimum: 9, use 0 for full width
  --absolute                 Show absolute path to file (will only show path from first parent)
  --no-header                Dont print the header
  --bytes                    Size in bytes

cause
tag 2.1.0 was created on 05/02/2016. (https://github.com/gdrive-org/gdrive/commit/97981f7fd205353907135eacfc0e0ade24b88269)
--service-account has been added on  01/26/2017. (https://github.com/gdrive-org/gdrive/commit/b33b3e96eb6443ae3dff61e0e7b38bb529e328ea)
README.md has been updated on 7/29/2019. (https://github.com/gdrive-org/gdrive/commit/8e12e1c1c961954c162d9bc6c6ddb4661850465d)
README.md lists --service-account, but the actual Not included in tag 2.1.0. (https://github.com/gdrive-org/gdrive/commit/97981f7fd205353907135eacfc0e0ade24b88269)
solution
Reset the tag 2.1.0 to the current master.
Or create a tag, such as 2.2.0 or 2.1.1.
In the former case, no need to update Homebrew formula.

any update on this?

@mlostekk
There are no updates and the README.md explains that it is no longer maintained.
If you want to use service-account, you can use go get to get it.

@mlostekk
There are no updates and the README.md explains that it is no longer maintained.
If you want to use service-account, you can use go get to get it.

oh okay.. sorry, i did not see that.. what a pitty.
but building it on my own works like a charm.. just one question.. where do the files end up.. i cant see it in my drive, but then i list it i can see it


CSVR is incorrect in model for GBUB

Greenbrook CSVRs for residential are 50% deterministic, and show up as such in the occupancy type editor, but show up as 0 in the model.

Deterministic CSVRs do not show up correctly in the model.

I have confirmed that I can make an edit to an occupancy type using the UI to a CSVR with a normal distribution and that edit makes its way to the model. If the CSVR has a deterministic distribution, then the CSVR shows up as 0 in the model.

The attached file will give two opportunities for improvement. I have included a screen shot of how the deterministic CSVR shows up in 1.4.3 and how that looks in the flat file. RS-OS-NB has a deterministic CSVR and this does not show up correctly in the model.
It is worthwhile to consider how we handle the user error in this data. Observe that the occ type data as OSVR uncertainty without an OSVR specified. How do we handle that? My guess is that we use the -901 as the OSVR when we import into 2.0 and then come up with a whacky standard deviation.

Structure Occupancy Types Imports.txt

another good question is how 1.4.3 handled the OSVR but aint nobody got time for that


Include an example of a label with square brackets

See #71
Stale gets confused when label names use square brackets. Until this is fixed, let's show that one can work around that problem by adding quotes around the label.

Thanks!


[Bug] Delete matches (replace with empty string) doesnt work

I get "no changes to sync!"
With the following setup:

you need to add --replace= to Flags as documented here: https://github.com/MagicDuck/grug-far.nvim?tab=readme-ov-file#syncing-results-lines-back-to-originating-files
since we can't differentiate between a pure search and replace with empty string.


Monorepo with pnpm and Vite — 404 errors

Describe the bug
I have two packages: ui and app. app imports styled components from ui, but the styles do not load resulting in 404 errors for <component name>.css.ts.vanilla. files.
I've seen other issues mentioning the same problem (1, 2), all are closed and it seems the fix was pushed to a newer version of vite plugin. I currently use the latest one, 3.1.6, and strangely it doesn't work for me.
Link to reproduction
Here's a repo.
Run pnpm i && pnpm dev from root and visit http://localhost:3000. Nothing will show:

System Info
  System:
    OS: macOS 12.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 2.71 GB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.2 - ~/.nvm/versions/node/v16.13.2/bin/node
    Yarn: 1.22.17 - /opt/homebrew/bin/yarn
    npm: 8.1.2 - ~/.nvm/versions/node/v16.13.2/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Firefox: 99.0.1
    Safari: 15.2
  npmPackages:
    @vanilla-extract/css: ^1.7.0 => 1.7.0
    @vanilla-extract/vite-plugin: ^3.1.6 => 3.1.6
    vite: ^2.9.9 => 2.9.9

Also (if it matters):
➜  vanilla-extract-repro git:(main) pnpm -v
7.1.0

I have the same issue for codeimage. I had to rollback to 3.1.4 since is the latest version working with a monorepo and preserveModules: true

I've got the same issues with yarn v3 going from v3.1.4 to v3.1.6. Seems like v3.1.5 is the culprit.

Thanks for the clear reproduction. PR to fix this is open #716


Vulkan: Event Browser has two typos for clear commands

in WrappedVulkan::Serialise_vkCmdClearDepthStencilImage, we see:
        DrawcallDescription draw;
        draw.name = StringFormat::Fmt("vkCmdClearColorImage(%f, %u)", DepthStencil.depth,
                                      DepthStencil.stencil);

Seems like the string should say vkCmdClearDepthStencilImage.
Also, in WrappedVulkan::Serialise_vkCmdClearColorImage, we see:
        DrawcallDescription draw;
        draw.name = StringFormat::Fmt("vkCmdClearColorImage(%f, %f, %f, %f)", Color.float32[0],
                                      Color.float32[0], Color.float32[0], Color.float32[0]);

Seems like the format string should reference Color.float32[0..3] instead of just [0].

Good catch, thanks! I'm closing this directly as your changes were exactly what I applied.

Thanks for the fix!


POWO search returns nothing

If you enter a POWO search that returns nothing. nothing is reported to the user. Useful to say that this is not valid

I think this might be handled in feature/native-point-toggle but not sure...

closed by #43


fastrtpsgen generated examples won't compile [6212]

In the generated example files has the  line
PParam.rtps.builtin.leaseDuration  = c_TimeInfinite;
should be changed to
PParam.rtps.builtin.discovery_config.leaseDuration = c_TimeInfinite;

We've started to separate the generator Java application from the main repository. Try to use the Java application hosted in this repository. It contains the fix to your issue.

@mathias110 Does it work for you?

I haven't tried it yet due to other more urgent tasks.

I'm closing this because it should be fixed now. Please, feel free to reopen it again if you found that the issue persists.


Fix classification notebook to download FordA dataset without error v2

Before submitting (must do checklist)

[x] Did you read the contribution guide?
[ ] Did you update the docs? We use Numpy format for all the methods and classes.
[ ] Did you write any new necessary tests?
[x] Did you update the CHANGELOG?

Proposed Changes

Closing issues

Codecov Report

Merging #1299 (23c9fa4) into master (e7264c1) will decrease coverage by 81.69%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master   #1299       +/-   ##
==========================================
- Coverage   88.77%   7.09%   -81.69%
==========================================
  Files         193     193
  Lines       11751   11746        -5
==========================================
- Hits        10432     833     -9599
- Misses       1319   10913     +9594

see 176 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Enhancement: Translation files

Add translation files, please.

translation support is alreadu in, it just needs the translated string file for a given language.

I know it's a nitpick but I was thinking of this

ah will check if those are not in the sheet i will add them!


Device Time Stamp is always center of exposure

Some documentation reports that Device Timestamp is sometime center or exposure (COE) and is sometimes start of exposure (SOE).
The Timestamp is always COE. We need to scrub documentation that talks about SOE such as https://docs.microsoft.com/en-us/azure/Kinect-dk/multi-camera-sync#timestamp-considerations

https://github.com/MicrosoftDocs/azure-docs/pull/49583


edgex-security-proxy-setup service fails to start after Ubuntu reboot

🐞 Bug Report
Affected Services [REQUIRED]

 The issue is located in:
When Ubuntu reboots, the proxy-setup service fails to start. This in turn causes the nginx container to fail to start properly.
Is this a regression?

 Yes, the previous version in which this bug was not present was: ....
Description and Minimal Reproduction [REQUIRED]
git clone git@github.com:edgexfoundry/edgex-compose.git
git checkout tags/v3.1.0 -b release/3.1.0
cd compose-builder && make gen mqtt-broker ds-opcua ds-modbus ds-mqtt app-mqtt app-metric-process arm64
docker compose up -d
# wait service running and check
docker ps

# reboot system
sudo reboot

🔥 Exception or Error

🌍  Your Environment
Deployment Environment:
os：  ubuntu 20.04 TLS
arch:  arm64
docker info:

EdgeX Version [REQUIRED]:
3.1.0
Anything else relevant?

Please provide the logs of the two services which cannot be restarted

another service which cannot be started normally is common-config-bootstraper
please check its log

@ethan256 I just figured out the issue.  All your logs look normal, becuase they were the log before the reboot.
I tried to add restart: always into the service of security-proxy-setup, and it works fine.  Please try to use this workaround for now.
@lenny-intel I noticed that we don't define restart: always in security-proxy-setup, and it blocks the starting up of nginx
https://github.com/edgexfoundry/edgex-compose/blob/55680017ff1b7c9db23deb52a21b27b28a7812ac/docker-compose.yml#L917
Do you know the reason or just a missing?
The same situation for edgex-core-common-config-bootstrapper, but it doesn't impact anything as far as I know.


Model predict api (Partial)

partial commit for model predict api,  call to backend inference server is not completed

@Rader The conflicts should be resolve.

@pulltheflower  conflicts resolved, please review


Added support for Harmony HRC20

Description
Added ABI related code to support Harmony HRC20. Harmony has same ABI/VM as Ethereum so most the added code is copied from Ethereum.
Testing instructions

Types of changes

Checklist

[] Prefix PR title with [WIP] if necessary.
[x ] Add tests to cover changes as needed.
[] Update documentation as needed.
[x ] I have read the guidelines for adding a new blockchain
[ ] If there is a related Issue, mention it in the description (e.g. Fixes #<issue_number> ).

I am concerned about the amount of code duplication introduced here.  If it is very similar to Eth Abi encoder, can code be resued?  Either completely, or maybe separate C code but same underlying CPP code.  I havent't checked if there are differences, but if there are, it is OK to modify the existing Eth code to be able to support both.

The current implement re-used all C++ library of Ethereum/ABI ,
#include "Ethereum/ABI.h" and
using namespace TW::Ethereum;
but a JNI layer is defined for both header file and C functions.
TWString *_Nonnull TWHarmonyAbiFunctionGetType(struct TWHarmonyAbiFunction *_Nonnull func_in) {
assert(func_in != nullptr);
auto function = func_in->impl;
std::string sign = function.getType();
return TWStringCreateWithUTF8Bytes(sign.c_str());
}
This is the most code share that I can come up with.. Cab you recommend a better way ?
IMHO, to fully avoid duplicate code, there should be NO seperate JNI for harmony ABI.. The application (swift, or java) can just call ETH JNI functions for all ABI operations as HRC20 / ERCO20 are fully compatible.

let's just use existing Ethereum stuff? no need to add new interface

The CPP ('non-TW') code is reused (sorry I overlooked that), so the actual logic is not duplicated, only the wrappers.  But the wrappers are quite many.
I also suggest just using the TWEthereum... code to avoid code duplication.

let's just use existing Ethereum stuff? no need to add new interface
Yes, the ABI is same as Ethereum.  From smart contract function call to tx.data field generation should be 100% compatible with Ethereum.

So to add a new Harmony. HRC20, how do we add information such as smart contract address for TrustWallet ?

The CPP ('non-TW') code is reused (sorry I overlooked that), so the actual logic is not duplicated, only the wrappers. But the wrappers are quite many.
I also suggest just using the TWEthereum... code to avoid code duplication.

Can you elaborate more ? I don't know how to proceed , TrustWallet App layer is like a blackbox to me.
Are you also saying that I don't need to introduce a JNI layer, instead, the Swift/Java just call Ethereum Swift/Java API to generate the data field for two ERC20 smart contract functions getBalance(...), transfer(...) and append the generated data into *tx->data field and sign/send send *tx to Harmony block chain ?
Is there a test case that I can create to test entire e2e flow ?

@coolcottontail no need to add anything to wallet core then


Mirror policy can't be disabled with value of zero

Description:
We are unable to disable mirroring by using a numerator value of zero.  It's expected that this would effectively disable the mirroring policy, but instead zero appears to be treated the same as configuring 100%.  Configuring the value to any other 1-100 number will mirror the appropriate amount of traffic.
The documentation (https://www.envoyproxy.io/docs/envoy/latest/api-v2/type/percent.proto#type-fractionalpercent) shows that the default numerator value is zero`, but omitting this value also has the same result of all traffic being mirrored.
Config:
virtual_hosts:
- name: envoy_backend_service
  domains: ["*"]
  routes:
  - match:
      prefix: "/"
    route:
      cluster: envoy-backend-green
      request_mirror_policies:
        - cluster: envoy-backend-yellow
          runtime_fraction:
            default_value:
              numerator: 0
              denominator: HUNDRED

Logs:

TBD

It's not great but if you configure a runtime key name I think it will work as you expect: https://github.com/envoyproxy/envoy/blob/e1df07ed752eec63df386970789caabb232daf7f/source/common/router/router.cc#L145-L155
I suppose we could just remove that empty check and just always do the runtime call even if the key is empty as I think it will do the right thing if it doesn't exist. cc @alyssawilk @snowp


[UI :Components] Install button

Summary
Add custom component or extend theme components to support the Install pack call to action dropdown / button (image below).
Note that the theme does not currently export its <Dropdown /> component for general use.
Acceptance criteria

[ ] Install button is prominent and when clicked, opens a TBD NR1 / o11y pack link
[ ] Menu options are TBD.  Just a button as link for now.

Images

Made my first pass at this
Exported DropDown: https://github.com/newrelic/gatsby-theme-newrelic/pull/411
Created Install Component: https://github.com/newrelic/gatsby-theme-newrelic/pull/412

Will move the component to the developer site as discussed

Moved this to the developer repo:
https://github.com/newrelic/developer-website/pull/1359
FYI this requires the Dropdown from the theme so needs newrelic/gatsby-theme-newrelic#411 to be merged as well


Adding documentation on methods and attributes.

Hello my friend.
I would like to congratulate you on the great work with this plugin. I would like to add some feature issues, and patterns that would be important in the use of my project.
My first contribution is adding documentation for methods and attributes.

Thank you @hiuryoliveira!
I'm normally not a fan of comments on all the methods and attributes as I think mostly just adds noise and clutter, and with type hints and good naming of the methods I find that they add little value. However, in an open source package like this one it might add some more value.
I'm willing to merge if you can make a good case for this.

@hiuryoliveira Yes, strict types would be nice. I would accept an PR for that if it does not break anything.


chore: upgrade x

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


switch from camptocamp/systemd to voxpupuli/systemd

I will do some merging to unblock the CI (hopefully)


reset servo on filter overflow

Summary:
Filter logic should reset the servo if the amount of consequential spikes reaches the limit.
Also the spike filter should take in account the amount of seconds passed after the last frequency update because any oscillator has a holdover drift.
Reviewed By: abulimov
Differential Revision: D43676554

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.09 :tada:

Comparison is base (5e77c9c) 58.38% compared to head (ef1bb76) 58.47%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   58.38%   58.47%   +0.09%
==========================================
  Files         126      126
  Lines       11425    11441      +16
==========================================
+ Hits         6670     6690      +20
+ Misses       4209     4206       -3
+ Partials      546      545       -1

Impacted Files
Coverage Δ

servo/pi.go
80.95% <100.00%> (+3.63%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

This is merged


title bug

the names and titles of userscripts are going off screen making it imposible to read the names and descriptions of said userscripts

all the titles started going left slowly until they eventually left the screen
edit:  i am on a fresh install of windows 11 latest stable version using opera gx also freshly installed

https://github.com/magicoflolis/Userscript-Plus/releases
v2.4.13

Added ability to customize width
This may resolve issue


Adjunct not working when inside j:parse

Ticket tracked for Jenkins: https://issues.jenkins.io/browse/JENKINS-65755

https://github.com/jenkinsci/jenkins/pull/5515#pullrequestreview-667429063


SAK-50429 Grader : not loading for non LTI assignments

I just included everything LTI related inside the existing "if", as otherwise it won't work for regular assignments. Please take a look and let me know if this is the way it should go, thanks!

@csev What do you think about this? I think you added this code so I'd rather defer to you on this.


Signal success for evaluator if only HINT-level violations exist

This PR changes the return code of evaluator runs when only hint-severity violations are found.
The reasoning is in short: Hints should only be "hints", not real violations, so the return code should signal "success" (exit code 0) instead of "failure" (exit code 2) which would break the build.
See also the commit message.

Please rebase (to catch up with changed PR checks) and remove the unused import.


BGGSTGB-2: Added telegram bot to the project.

PR Details
Added telegram bot to the project.
Chaned spring-boot-starter version to 2.5.7.
(closes #2)
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

(closes #2)


Capacitated VRP TW with general constraints

Thank you for this rich library and great work. We are trying to model a logistics problem, using OR tools version 6.7 (C sharp), which includes time window on orders & variant vehicle capacities, in addition to the possibility of optional refill at depot.
1- We are using a predefined distance matrix to feed it to the solver as the distance call back data source, and we are using a predefined duration matrix (generated by OSRM) to feed it to the solver as the travel time call back data source.
2- We are using 9 hours soft time constraint for vehicles end times
3- We are using 10 hours hard constraint for orders. For each order, we are setting time window as follows:
model.CumulVar(order, "time").SetRange(order_time_windows[order].start, order_time_windows[order].end);
4- Service times for each order is 10 minutes
5- Penalties are set on each order to 100,000
6- To model refill at depot, we created predefined number of copies for each vehicle and added general constraints on the time dimension so that the start time of a vehicles copy is always greater than the end time of the original vehicle and the previous copies.
Example:
model.solver().Add(model.CumulVar(model.End(vehicle), "time") <= model.CumulVar(model.Start(logical_vehicle), "time"));
Then, we are managing to concatenate the routes in the solution printer.
7- We are using path cheapest arc as a first solution strategy.
All our tests were successful until we reached some cases that caused the solver to run forever. In one of the examples, we had:

Around 700 orders and 28 vehicles.
Total fleet capacity is 44351.
Total orders demands is 53703.

I attached a copy of the exact values of the parameters being sent to the solver:
ProblematicInputs.txt
If we try the solution without enabling depot refill (i.e. without creating copies of the vehicles), the solver responds in few seconds with some orders dropped.
However, if we enable the depot refill, we were never able to get a solution as the solver simply keeps running and never returns a solution (Last trial: We waited for around 9 hours before we killed the process manually).
Noting that in some other examples, we had 1600 orders and the solver responded in less than 1 minute.
I appreciate your feedback if this is some common issue or this is related to a problem in the way we are modeling the problem. I am ready to provide further details were needed.
Thank you

In reference to this discussion, and after we tried the first suggestion (logical vehicles) as explained above, we tried to create one virtual depot for each vehicle and we have set the slackvar as described in this sample.
The solver worked and used one virtual depot, which was good. However, response time jumped from few seconds to 10 minutes. Is this normal? Noting that I still didn't try it on samples with more tight constraints.
The updated code is as follows:
RoutingModel model = new RoutingModel(orders.Length, vehicles.Length, vehicle_starts_, vehicle_ends_);
model.AddDimension(distMatrix_callback, big_distance, big_distance, true, "distance");
model.AddDimensionWithVehicleCapacity(demand_callback, 0, paramsMaster.VehiclesCapacities, true, "demand");
model.AddDimension(totalTime_callback, ParamsMaster.TIME_HORIZON, ParamsMaster.TIME_HORIZON, false, "time");
RoutingDimension capacity_dimension = model.GetDimensionOrDie("demand");
for (int i = 1; i <= vehicles.Length; i++)
{
//RESET SLCAK VAR AT EACH VIRTUAL DEPOT
long index = model.NodeToIndex(i);
capacity_dimension.SlackVar(index).SetRange(0, paramsMaster.VehiclesCapacities.Max());
//MAKE SURE THAT THE SOLVER CAN DROP REFILL NODE IF NOT NEEDED
model.AddDisjunction(new int[] { i }, 0);
}//end for
// SET UP TIME WINDOW AND PENALTY For all orders except DEPOT at index 0
for (int order = 1; order < orders.Length; ++order)
{
//SET THE TIME WINDOW
model.CumulVar(model.NodeToIndex(order), "time").SetRange(orders[order].timeWindow.start_,  orders[order].timeWindow.end_);
//SET ORDERS PENALTIES
if (orders[order].Penalty > 0)
{
int[] pOrders = { order };
model.AddDisjunction(pOrders, orders[order].Penalty);
}//end if
}//end for
for (int vehicle = 0; vehicle < vehicles.Length; ++vehicle)
{
NodeEvaluator2 distance_cost_callback = new DistMatrix(distMatrix, cost_coefficient);
NodeEvaluator2 vehicle_cost_callback = new DistMatrix(distMatrix, cost_coefficient);
model.SetVehicleCost(vehicle, vehicle_cost_callback);
model.SetArcCostEvaluatorOfVehicle(distance_cost_callback, vehicle);
//SET VEHICLES START TIME
model.CumulVar(model.Start(vehicle), "time").SetMin(vehicles[vehicle].StartTime);
//SET VEHICLES END TIME
model.CumulVar(model.End(vehicle), "time").SetMax(vehicleShiftLimit);
//BIAS THE SOLVER TO SOLVE WITHOUT HAVING TO GO TO VEHICLES OVER TIME
model.SetEndCumulVarSoftUpperBound(vehicle, "time", Convert.ToInt64(vehicles[vehicle].EndTime), Convert.ToInt64(cost_coefficient * ParamsMaster.OVERTIME_PENALTY_COEFF));

//Set Max travel distance for each vehicle on distance dimension
model.CumulVar(model.End(vehicle), "distance").SetMax(vehicles[vehicle].MaxDistance);

//Minimize time variables on vehicles
if (ParamsMaster.EARLIEST_POSSIBLE)
	model.AddVariableMinimizedByFinalizer(model.CumulVar(model.End(vehicle), "time"));

}//end for
model.SetFixedCostOfAllVehicles(ParamsMaster.FIXED_VEHICLE_COST);
RoutingSearchParameters search_parameters = RoutingModel.DefaultSearchParameters();
search_parameters.FirstSolutionStrategy = FirstSolutionStrategy.Types.Value.PathCheapestArc;
search_parameters.TimeLimitMs = ParamsMaster.MAX_SOLUTION_RUN_TIME;
Assignment solution = model.SolveWithParameters(search_parameters);


Plugin "import" was conflicted between two extended config

Hey!
I'm getting the following error when using vscode-eslint inside a monorepo:
Error: Plugin "import" was conflicted between ".eslintrc.js » plugin:import/warnings" and ".eslintrc.js » ../../.eslintrc.base.js » plugin:import/warnings".

The error happens when opening the directory apps/web-app inside this monorepo: https://github.com/hmbrg/blitzjs-monorepo-example/tree/main/apps/web-app
I'm using root: true and my settings look like this:
{
  "eslint.workingDirectories": [
    {
      "pattern": "./apps/*/"
    },
    {
      "pattern": "./packages/*/"
    }
  ]
}

What could be wrong here? Thanks so much in advance!

What happens when you run eslint in the terminal in one of the working directories. If it works OK can you then please provide me with a GitHub repository I can clone that demos this. Then I can investigate.

Everything works from the terminal. The GitHub repo is linked in the issue above. Thanks for helping!

Can you please provide exact steps on how to reproduce what you are seeing. And I looked and the repository doesn't contain a VS Code settings.json file in a .vscode root folder. Is it missing

Digging around a little shows that the same error happens in the terminal:

Please make sure that validation happens correctly in the terminal using ./node_modules/.bin/eslint. If you do change the working directory please make sure you have a corresponding "eslint.workingDirectories" entry in the settings

This issue has been closed because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Get framework URLs from frameworks content instead of hard-coded in app

For this story: https://www.pivotaltracker.com/story/show/126767693
Depends on:

[x] https://github.com/alphagov/digitalmarketplace-frameworks/pull/297

This gets a soft-thumbs-up from me but I don't feel I know enough about the content loader yet to pull the big lever...

So we're not linking to the G-Cloud 6 framework agreement anymore?
Is there a chance that someone could still need to see the contract from the service page even if they can't buy the service?
(I realise this comment should be in the other repo, but here we are.)

The G-Cloud 6 link, like the G-5 one, has been made FORBIDDEN by CCS, so no point showing it any more.

FORBIDDEN sounds serious.
👍  when you're ready.

Travis really struggling with NPM today.

Cheers Paul, going to park this here until the CCS page is live.


interleaved <--> sequential conversions

It would be nice to provide means to convert between interleaved and sequential buffers.

You can do it with copy and translate here:
https://docs.rs/audio/0.2.0-alpha.4/audio/buf/index.html


Zoomable map would be useful (mainly for mobile devices)

Explanation and reasoning
The size of the map updates in order to be fit on the screen, but it's not good, if it's a large map (e.g. the world map), because it can't be zoomed into. However you might want to see exactly what are the neighbours of Burkina Faso and what are not.
Implementation
There should be two buttons to control the degree of zoom, which should be stored in a global variable

The map should be cropped if it overflows its container, and also, it should be able to be dragged around.

The last commit tackles most of the job, it seems so far. At least on Laptop. On safari, somehow the overflow: clip doesn't work, I'll try to use overflow: hidden. And I forgot to delete the centre button when removing the map.
BTW I also added a button that centres the map.

It works well enough.


Can't setup the environment for the program

I have tried run the program in python using normal python interpreter 3.11, but unfortunately I couldn't load the package for tensorflow_gnn. It's showing an error while trying to install the pyarow. Can you please suggest the solution
ERROR: Could not build wheels for pyarrow, grpcio-tools, which is required to install pyproject.toml-based projects
ERROR: Failed building wheel for grpcio-tools
ModuleNotFoundError: No module named 'cmake'
error: command 'C:\Users\user\AppData\Local\Programs\Python\Python311\Scripts\cmake.exe' failed with exit code 1
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for pyarrow
Building wheel for grpcio-tools (setup.py) ... error
error: subprocess-exited-with-error

I had a similar issue with python 3.11 and couldn't make it work. Switching to python 3.10 works fine however.

Yes, please use python 3.10. I'll update the instruction.


Allow to specify local model when using llama_cpp

For now, LSP-AI will try to download model file when config with llama_cpp. Are there anyway for user to specify to an already downloaded model in local folder?

Never mind, I found file_path option. I think this should be documented in wiki.
{
  memory = {
    file_store = {},
  },
  models = {
    model1 =  {
      type="llama_cpp",
      repository= "Qwen/CodeQwen1.5-7B-Chat-GGUF",
      name= "codeqwen-1_5-7b-chat-q4_k_m.gguf",
      file_path="/Users/user1/model/codeqwen-1_5-7b-chat-q4_k_m.gguf",
      n_ctx=2048,
      n_gpu_layers= 1000,
    }
  }
}

Glad you were able to find it! It is documented under: https://github.com/SilasMarvin/lsp-ai/wiki/Configuration#llamacpp but that configuration page is getting so large it may be worth redoing our docs at some point soon into a small website. I should also note if you are setting the file_path you don't have to set the repository and name.


Photo validation (size and resoulution)

dev
JIRA

Main JIRA ticket

Code reviewers

[ ] @github_username

Second Level Review

[ ] @github_username

Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST

[ ]  СI passed
[ ]  Сode coverage >=95%
[ ]  PR is reviewed manually again (to make sure you have 100% ready code)
[ ]  All reviewers agreed to merge the PR
[ ]  I've checked new feature as logged in and logged out user if needed
[ ]  PR meets all conventions

e.printStackTrace(); -we have to use logger to log messages.

I replaced it with log.error.


Timestamp Bug : ARLAS-API should only accept milliseconds in the before/after filters

In gitlab by @MohamedHamouGisaia on Oct 20, 2017, 12:52
Timestamps are always returned as milliseconds in seach/aggregation results of Arlas server, regardless of their format in Elasticsearch.
Therefore; time filters (before/after) should only accept millisecond format to keep the API coherence.

In gitlab by @MohamedHamouGisaia on Oct 20, 2017, 12:53
changed title from Timestamp Bug : {-arlas-} should only accept milliseconds in the before/after filters to Timestamp Bug : {+ARLAS-API+} should only accept milliseconds in the before/after filters

In gitlab by @MohamedHamouGisaia on Oct 20, 2017, 12:53
changed the description

In gitlab by @MohamedHamouGisaia on Oct 20, 2017, 17:43
added ~2424199 and removed ~2424198 labels

In gitlab by @MohamedHamouGisaia on Oct 23, 2017, 17:06
mentioned in commit f9338a5f67eb89e324a31014972c54fda8f15d0e

In gitlab by @MohamedHamouGisaia on Nov 10, 2017, 10:00
mentioned in merge request !109

In gitlab by @sfalquier on Nov 17, 2017, 08:07
changed milestone to %19

In gitlab by @sfalquier on Nov 17, 2017, 09:51
Won't do since #125 will remove before/after filter params.

In gitlab by @sfalquier on Nov 17, 2017, 09:51
closed

In gitlab by @sfalquier on Nov 24, 2017, 08:20
removed ~2424199 label

In gitlab by @sfalquier on Nov 24, 2017, 08:21
removed milestone


Enable HTTPS

Issue submitter TODO list

[X] I've searched for an already existing issues here
[X] I'm running a supported version of the application which is listed here and the feature is not present there

Is your proposal related to a problem?
Unable to Run the UI with https and domain
Describe the feature you're interested in
A way to run the UI with https and a domain in docker container
Describe alternatives you've considered
No response
Version you're running
v0.6.2
Additional context
No response

Hi, take a look at this


Python: Makefile changes

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Yes, I build the MPL with this.


ngx-datatable can't be garbage collected - Memory Leak

I'm submitting a ...  (check one with "x")
[X ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
Add table with a column
    <ngx-datatable [rows]="data">
      <ngx-datatable-column></ngx-datatable-column>
    </ngx-datatable>

Parent component can no longer be garbage collected.

Note that just <ngx-datatable [rows]="data"></ngx-datatable> does actually get collected. A column needs to be specified.
(Also I did see #1001 but it's been two years, I feel like this should have been a higher priority)
Expected behavior
The table would be get garbage collected.
Reproduction of the problem
If it's actually this bad just open any app where you can navigate away from the table and see for yourself.
What is the motivation / use case for changing the behavior?
It's preventing our components from being cleaned up.
Please tell us about your environment:

Table version:
16.0.2

Angular version:
8.0.3

Browser: Chrome | Firefox

Language: TypeScript 3.7.3

@marjan-georgiev this was fixed in https://github.com/swimlane/ngx-datatable/pull/1792 and can be closed


Feat add transform rule MergePercentileToArray

MergePercentileToArray is to perform a transformation in this case:
select ss_item_sk, percentile(ss_quantity,0.9), percentile(ss_quantity,0.6), percentile(ss_quantity,0.3) from store_sales group by ss_item_sk;
=》
select ss_item_sk, percentile_array(ss_quantity,[0.3,0.6,0.9]) from store_sales group by ss_item_sk;

run buildall

wait for percentileArray perf opt

run buildall

run xcloud_p1

run cloud_p1

run performance


Enhance sort logic

Is your feature request related to a problem? Please describe.
Enhance sort function to sort by changes and total affected. If some states have equal number of affected people, it should then sort them on delta. Whichever has higher delta will be shown on top.

Describe the solution you'd like
Would like to update the sort function that I wrote in my pr #211 if it gets merged.
In the screenshot attached, if the states have same number of patients, they are then sorted alphabetically - obviously. It'd be great if there were a one more level of sorting on delta.

can I take this up?


Work Package wp-ed.csv

I would like to work on this please!

Results of Phase 1
wp-ed-results.csv

I completed this work package!

Results of Phase 1
wp-ed-results.csv

I would like to work on this please!

Results of Phase 2
wp-ed-results.csv

I completed this work package.

Results of phase 2
wp-ed-results.csv

I completed this work package.

I would like to work on this please!

Results of phase 2
wp-ed-results.csv


running test run with different deeplexicon models

Hi Luca,
Can we run a quick test using the same data (e.g. 10reads) of multiplexed data, and try to use the same exact parameters config file, but just change the specific model used by deeplexicon? (e.g. use model030 in one case and then the final-20).
It seems that one of the models (final-20) gives us errors when we try to demultiplex our reads in the cluster, but we don't get errors when using model030, so we were wondering if perhaps this problem would not occur if we launched deeplexicon directly from masterOfpores? it would be good to test if it is an issue of the model or of the OS. Thanks! Eva

Hi Eva,
we can run any test you want...
We have three models now:
pAmps-final-actrun_newdata_nanopore_UResNet20v2_model.030.h5
resnet20-final.h5
pAmps-rep2-4-train1_newdata_nanopore_UResNet20v2_model.039.h5
which one do you want we test?
Luca

If we can do the comparison of the 3 that will be the easiest. Do you have some test data? Just one file of 4000 reads is more than enough for the test. Thanks!
Get Outlook for Androidhttps://aka.ms/ghei36

From: Luca Cozzuto<EMAIL_ADDRESS>Sent: Wednesday, January 8, 2020 5:51:16 PM
To: biocorecrg/master_of_pores<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [biocorecrg/master_of_pores] running test run with different deeplexicon models (#18)
Hi Eva,
we can run any test you want...
We have three models now:
pAmps-final-actrun_newdata_nanopore_UResNet20v2_model.030.h5
resnet20-final.h5
pAmps-rep2-4-train1_newdata_nanopore_UResNet20v2_model.039.h5
which one do you want we test?
Luca
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/biocorecrg/master_of_pores/issues/18?email_source=notifications&email_token=ADDGUPODX3A6YUR5MTWBCWDQ4YAAJA5CNFSM4KELDD62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEINHAXA#issuecomment-572158044, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADDGUPJ3MX4ZJK3P7DZBN6TQ4YAAJANCNFSM4KELDD6Q.

I got an error with this model: pAmps-rep2-4-train1_newdata_nanopore_UResNet20v2_model.039.h5
2020-01-08 17:34:33.475848: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2020-01-08 17:34:33.476370: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x52a6060 executing computatio
ns on platform Host. Devices:
2020-01-08 17:34:33.476384: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): Host, Default
 Version
XXX lineno: 184, opcode: 160
Using TensorFlow backend.
info: Verbose mode active - dumping info to stderr
info: DeePlexiCon: 0.9.0
info: arg list: Namespace(batch_size=1000, config=None, model='pAmps-rep2-4-train1_newdata_nanopore_UResNet20v2_model.03
9.h5', path='./', threshold=0.5, type='multi', verbose=True, version=None)
info: Please install GPU version of TF
Traceback (most recent call last):
  File "/nfs/software/bi/biocore_tools/git/nextflow/master_of_pores_paper/master_of_pores/NanoPreprocess/bin/cmd_line_de
eplexicon_caller_2019_09_12.py", line 677, in <module>
    main()
  File "/nfs/software/bi/biocore_tools/git/nextflow/master_of_pores_paper/master_of_pores/NanoPreprocess/bin/cmd_line_de
eplexicon_caller_2019_09_12.py", line 207, in main
    model = read_model(config[deeplexicon][trained_model]) if args.config else read_model(args.model)
  File "/nfs/software/bi/biocore_tools/git/nextflow/master_of_pores_paper/master_of_pores/NanoPreprocess/bin/cmd_line_de
eplexicon_caller_2019_09_12.py", line 121, in read_model
    model = load_model(model_name) # as a path
  File "/usr/local/lib/python3.6/dist-packages/keras/engine/saving.py", line 492, in load_wrapper
    return load_function(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/keras/engine/saving.py", line 584, in load_model
    model = _deserialize_model(h5dict, custom_objects, compile)
  File "/usr/local/lib/python3.6/dist-packages/keras/engine/saving.py", line 274, in _deserialize_model
    model = model_from_config(model_config, custom_objects=custom_objects)
  File "/usr/local/lib/python3.6/dist-packages/keras/engine/saving.py", line 627, in model_from_config
    return deserialize(config, custom_objects=custom_objects)
  File "/usr/local/lib/python3.6/dist-packages/keras/layers/__init__.py", line 168, in deserialize
    printable_module_name='layer')
  File "/usr/local/lib/python3.6/dist-packages/keras/utils/generic_utils.py", line 147, in deserialize_keras_object
    list(custom_objects.items())))
  File "/usr/local/lib/python3.6/dist-packages/keras/engine/network.py", line 1075, in from_config
    process_node(layer, node_data)
  File "/usr/local/lib/python3.6/dist-packages/keras/engine/network.py", line 1025, in process_node
    layer(unpack_singleton(input_tensors), **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/keras/backend/tensorflow_backend.py", line 75, in symbolic_fn_wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/keras/engine/base_layer.py", line 489, in __call__
    output = self.call(inputs, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/keras/layers/core.py", line 716, in call
    return self.function(inputs, **arguments)
  File "/home/ubuntu/anaconda3/envs/DeePlexiCon/lib/python3.7/site-packages/keras/utils/multi_gpu_utils.py", line 184, i
n get_slice
SystemError: unknown opcode
`
``

not sure why

Same error with resnet20-final.h5... Maybe we should open an issue here?
https://github.com/Psy-Fer/deeplexicon

Yes we should. Can you place this one in the Deeplexicon one?
We were having issues as well but wanted to test on MasterOfPores to see if the issue was something from our environment, but it seems it is from the model’s environment.
Can you place it there with the verbose?
Thanks so much,
Eva
On 8 Jan 2020, at 7:04 pm, Luca Cozzuto <notifications<EMAIL_ADDRESS>wrote:
Same error with resnet20-final.h5... Maybe we should open an issue here?
https://github.com/Psy-Fer/deeplexicon
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/biocorecrg/master_of_pores/issues/18?email_source=notifications&email_token=AN74X5VK26AWAQ2YZSRVD4DQ4YISXA5CNFSM4KELDD62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEINOE6I#issuecomment-572187257, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN74X5USM642UNXLNGCW66TQ4YISXANCNFSM4KELDD6Q.
--
Eva Maria Novoa, Ph.D. | Group Leader - Epitranscriptomics and RNA Dynamics
Center for Genomic Regulation (CRG)
Dr. Aiguader 88, PRBB Building, 08003 Barcelona, Spain.
Lab phone: +34 93 316 0260 / Office: + 34 93 316 0131
Lab Website:  http://www.crg.eu/en/programmes-groups/epitranscriptomics-and-rna-dynamics

I fixed it by creating a new docker with python 3.7 and the exact version of the packages indicated (newer won't work). https://github.com/biocorecrg/master_of_pores/commit/1d938866fbfd2eb5db21582ec71992b653c3e029

So have you launched the pipeline again with the dockerfile that uses python 3.7 with the 3 models? thanks!
On 9 Jan 2020, at 12:35 pm, Luca Cozzuto <notifications<EMAIL_ADDRESS>wrote:
I fixed it by creating a new docker with python 3.7 and the exact version of the packages indicated (newer won't work). 1d93886https://github.com/biocorecrg/master_of_pores/commit/1d938866fbfd2eb5db21582ec71992b653c3e029
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/biocorecrg/master_of_pores/issues/18?email_source=notifications&email_token=AN74X5S67MD5A43XWU4YTNTQ44DWVA5CNFSM4KELDD62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIP765A#issuecomment-572522356, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AN74X5R2LXV6ENCXRK4S5GDQ44DWVANCNFSM4KELDD6Q.
--
Eva Maria Novoa, Ph.D. | Group Leader - Epitranscriptomics and RNA Dynamics
Center for Genomic Regulation (CRG)
Dr. Aiguader 88, PRBB Building, 08003 Barcelona, Spain.
Lab phone: +34 93 316 0260 / Office: + 34 93 316 0131
Lab Website:  http://www.crg.eu/en/programmes-groups/epitranscriptomics-and-rna-dynamics

Yes I made a new docker image only for demultiplexing (I have to add to the paper) with all the requirements.


Use Logger.add_backend/1

Configuring the backend on config/config.exs may be too early
and cause issues if trying to loading logger config before Sentry
is compiled.
Or it can be an issue in umbrella projects when only some of them
depend on Sentry.

Note the previous snippet also wouldn't work for releases. :)

it can be an issue in umbrella projects when only some of them
depend on Sentry.

Thanks @josevalim - it is one of the pain points I've had in the umbrella app I'm managing, this will help greatly.

@josevalim Thank you so much!! 💖

Oh, I am so sorry, I thought you were referring to Elixir's getting started guide. My bad, thanks for the PR though!

@morgz thanks for updating the docs!


skale-engine version 0.5.3 regression?

$ skale create dd2bis
create application dd2bis

<EMAIL_ADDRESS>preinstall /home/felix/skale/cli/dd2bis/node_modules/.staging/skale-engine-1126d865
mkdir -p node_modules && echo "module.exports = require('..');" > node_modules/skale-engine.js

<EMAIL_ADDRESS>/home/felix/skale/cli/dd2bis
--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  |--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| | +--<EMAIL_ADDRESS>| | | --<EMAIL_ADDRESS>  | | |--<EMAIL_ADDRESS>| | --<EMAIL_ADDRESS>  | |   +--<EMAIL_ADDRESS>  | |   +--<EMAIL_ADDRESS>  | |   +--<EMAIL_ADDRESS>  | |   +--<EMAIL_ADDRESS>  | |   +--<EMAIL_ADDRESS>  | |--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| | --<EMAIL_ADDRESS>  |--<EMAIL_ADDRESS>--<EMAIL_ADDRESS>    +--<EMAIL_ADDRESS>--<EMAIL_ADDRESS>Project dd2bis is now ready.
Pleas change directory to dd2bis: "cd dd2bis"
To run your app: "skale run"
To modify your app: edit dd2bis.js
$ cd dd2bis
$ skale run
/home/felix/skale/cli/dd2bis/node_modules/skale-engine/lib/dataset.js:171
result = combiner(result, res.data);
^
TypeError: Cannot read property 'data' of null
at taskDone (/home/felix/skale/cli/dd2bis/node_modules/skale-engine/lib/dataset.js:171:33)
at Object. (/home/felix/skale/cli/dd2bis/node_modules/skale-engine/lib/context.js:129:4)
at Consumer._transform (/home/felix/skale/cli/dd2bis/node_modules/skale-engine/lib/client.js:120:32)
at Consumer.Transform._read (_stream_transform.js:167:10)
at Consumer.Transform._write (_stream_transform.js:155:12)
at doWrite (_stream_writable.js:301:12)
at writeOrBuffer (_stream_writable.js:287:5)
at Consumer.Writable.write (_stream_writable.js:215:11)
at FromGrid.ondata (_stream_readable.js:536:20)
at emitOne (events.js:77:13)

If you perform once skale run --reset or skale stop; skale run, the problem should disappear. Can you confirm ?
The reason is that you have a skale-server + skale-worker running in version 0.5.2 or before and the master in version 0.5.3. Stopping and restarting force server and worker to run in 0.5.3 as well and fix the problem.
The incompatibility between master in 0.5.3 and server/worker in 0.5.2 is unexpected and was not tested for, otherwise the version would have been set to 0.6.0 instead.

Understood, thank you. One remark, though. For some reason, the first 'skale run --reset' seems to have executed the program twice.
$ cd skale/cli/dd2bis
$ skale run --reset
[ 'Hello world' ]
[ 'Hello world' ]
$ skale run --reset
[ 'Hello world' ]

Closing this one, session server for remote run has evolved a lot, and behaviour changed.


RV901T inputs 5V

For RV901T, the I/O direction of some of the 74HC245 buffers can be set by the FPGA on pin F13 (U600-U607, see Section Buffer. But the VDD on U600-U607 is at 5 V and like also mentioned in #37 for the 5a-75B, the 74HC245 buffers drive the FPGA inputs at 5 V when configured as an input buffer (the 74HC245 is directly connected to the FPGA pins). According to Xilinx, the Spartan-6 is not 5 V tolerant, meaning that it would damage or destroy the FPGA if the buffers are configured as inputs.
Am I missing something or is the board really designed that way?
Shouldn't this be mentioned in the Hardware description?
At least, the DIR input of the buffers is pulled to GND by R608, so during configuration of the FPGA, the buffers are configured as outputs and likely stay like this if the new design does not configure F13.

If you don't need the 5v output level and the 5v tolerant input level try to run the board on 3.3V
This works for me when feeding 3.3V into the 5v line which also feeds the 3.3v regulator.
Or you could also try and feed the 3.3V directly on JP2

Thanks a lot, great to know the board workds with 3.3 V!
But do you agree with me it's a bad idea to put F13 to high when powered with 5 V? If yes, I would propose to mention it in the hardware description.

According to linsn's datasheet the board should work between 3.3 and 5.5v
And according to the 74HC245 datasheet the buffers should work between 2.0 and 6.0 V
Been running it as a mesa 7i90 card with hostmot2 firmware over spi to  linuxcnc on a raspberry pi 4 for several months without any problems. Albeit  still using a  5V > 3.3V level converter on the inputs.
Now you brought this up i wonder if the inputs will be 5V tolerant when the board and buffers are fed from 3.3V?

If I understand correctly, the 74HC245 datasheet, section 7, table 4 (absolute maximum rating), states that the input clamping current must not exceed 20 mA (at condition VI > VCC + 0.5 V). So, assuming the clamping diode has a voltage drop of 0.5 V, the remaining (5 - 0.5 - 3.3) = 1.2 V drops in the current limiting resistor, which is 75 Ohm on RV901T, so there would be an input current of 16 mA which is 80 % of absolute maximum rating. Dirty hack but may work. So at least in theory, at VCC = 3.3 V, the 74HC245 inputs should be 5 V tolerant with a current limiting resistor of 75 Ohm.

"Been running it as a mesa 7i90 card with hostmot2 firmware over spi to linuxcnc on a raspberry pi 4 for several months without any problems."
Do tell! Details man, details! LOL

pauluzs commented...
"Been running it as a mesa 7i90 card with hostmot2 firmware over spi to linuxcnc on a raspberry pi 4 for several months without any problems."
I'll second that: definitely want to know more. Do you have any links on how you flashed the firmware to the card? Is it by coincidence that the Mesa and the RV901T uses the same chipset?
On the other side: thanks to the great work in this repository there is also a development to create a dedicated firmware and driver for LinuxCNC which works on ethernet: https://github.com/Peter-van-Tol/LiteX-CNC/tree/main (still work in progress).
Will try to run the board at 3.3 Volt and modify the buffers to fix in and outputs.

Sorry for the late reply,
Didn't see bleeptech's comment.
It's been a while so i had to search my backups to see what i could find.
In short i made a custom .ucf and .vhd for the rv901's fpga
RV901Tspi.ucf.txt
RV901T_x16card.vhd.txt
Flashing was done by directly flashing the bitstream to flash memory, with openocd on the raspberry pi connected to JP5 , no soldering needed standard dupont jumpers will fit. The linuxcnc spi>fpga connection was made at jp4 which is 3.3V (needs pins soldered)
I did find some notes i made when i did this , this includes the whole process, for the fpga flashing see line 180 and down
pi4_5.9_rt_linuxcnc.txt
Hope this will help you out
Br Pauluzs

@ericfont
Eric,
I have merged your pull request. Do you think this is sufficient to close this issue?
Tom

yes, I think this can be closed now, thanks.


find_object crashes after adding object to scene or adding object by files

Hi, I'm having trouble running find-object as it keeps crashing and I keep getting the following error:
OpenCV Error: Unsupported format or combination of formats (type=0
) in buildIndex_, file /home/user/opencv-2.4.13/modules/flann/src/miniflann.cpp, line 315
terminate called after throwing an instance of 'cv::Exception'
  what():  /home/user/opencv-2.4.13/modules/flann/src/miniflann.cpp:315: error: (-210) type=0
 in function buildIndex_

[find_object_3d-1] process has died [pid 4635, exit code -6,
cmd /home/user/catkin_ws/devel/lib/find_object_2d/find_object_2d rgb/image_rect_color:=/kinect2/qhd/image_color_rect depth_registered/image_raw:=/kinect2/qhd/image_depth_rect
depth_registered/camera_info:=/kinect2/qhd/camera_info __name:=find_object_3d __log:=/home/user/.ros/log/e0a800d0-f234-11e6-91b5-e82aeaab80ce/find_object_3d-1.log].
log file: /home/user/.ros/log/e0a800d0-f234-11e6-91b5-e82aeaab80ce/find_object_3d-1*.log

This happens whenever I import my object or use the take picture option to add an object. I tried the suggestions at the following link and this is what my setup currently looks like:

Could you please kindly help?

Did you try the latest code from source? It looks like there is a commit about OpenCV 2.4.13 that may be related to this error: https://github.com/introlab/find-object/commit/77b95d6b8c7cbbadc985cfe4d4142066afb0599e

I reverted to 2.4.8 and everything is all good now

Find-object crashes about 1 in 3 times on windows 7 laptop.
version is 0.6, opencv 3.0.0 with non-free.
Installed on a 64 bit Windows 7, on a Sony VPCF1 type laptop, running Intel i7 processor
Find-Object was installed by downloading and running the win-64 exe installer file.
The find-object.exe file is date  10/07/2015, size 118KB
example of operation;-
start up Find-Object by clicking on the above .exe file
press space bar for default camera (laptop)
pause camera
add object from file
start camera
crash


Update README.md

Spelling fix
Proposed Changes

Simple spelling fix

Testing

N/A

@duanekord thanks for the PR.


Encryption at rest

I know Sqlite doesn't encryption as rest, but is there anyway we can add encryption at rest ?

Not out of the box. See also https://github.com/pocketbase/pocketbase/discussions/1961.


Improve JSDoc Comment – b/77824265

Adds JSDoc comments instead of weird comments to sample.
See b/77824265
R: @bcoe

@JustinBeckwith Thanks for the detailed comment, I appreciate you taking the time. Talked with @bcoe a bit too.
This PR would be inconsistent with other samples, and looking further, it seems like the rubric would need adjustments before making such a PR.
I'll re-assign the buganizer bug to you and perhaps it can be blocked by a larger effort. Or maybe it could simply be closed as infeasible.


Carpe Auto-Updater

Tauri framework provides a framework for auto-updating Carpe.

[ ] enable auto-updates from tauri.conf.json
[ ] create canonical URL (in repo) to describe current update
[ ] change versioning scheme to semver

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.0o-de-lally seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Mass spec refresh

I used a script to find all fully passing upstream specs and copy them from a local checkout.

For future reference: I hacked this together:
#!/usr/bin/env ruby
# frozen_string_literal: true

require 'json'

spec = JSON.load_file('current.json')['stats']['spec']

walk_spec = lambda do |part|
  part.flat_map do |key, value|
    if value.key?('compiled')
      if value['compiled'] && !value['crashed'] && value['errors'].zero? && value['failures'].zero? && value['success'].positive? && !value['timeouted']
        [key]
      else
        []
      end
    else
      result = walk_spec.call(value)
      if result.empty?
        []
      else
        result.map { |rest| "#{key}/#{rest}" }
      end
    end
  end
end

passing = walk_spec.call(spec)
passing.each do |file|
  `cp ../ruby-spec/#{file} spec/#{file}`
end

This one includes some changes likes:
-  # NATFIXME: Inconsistent results. We can probably fix this once we implement IO#close_read
-  xit "raises IOError on stream not opened for reading" do
+  it "raises IOError on stream not opened for reading" do
     -> { STDOUT.ungetbyte(42) }.should raise_error(IOError, "not opened for reading")
   end

So I probably need to get through all of them before I feel comfortable merging this.


Predicting the survival of the passenger of Titanic

This project is about predicting the survival on the Titanic cruise. The tech stack used here is python, sklearn, pandas etc. The dataset is obtained from kaggle. It has test and train dataset on which model will be trained and tested.

@gargnityansh star and fork the repo

@gargnityansh star and fork the repo


Nothing should happen - however the last element's selection is toggled

@joaomoreno can I take this?

@itamark Please check for help wanted and good first issue issues.


Exception: Value is not valid for 'Value'. 'Value' should be between 'minimum' and 'maximum'.

I receive this kind of uncatching exception when I run many iterations
See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.
************** Exception Text **************
System.ArgumentOutOfRangeException: Value of '142' is not valid for 'Value'. 'Value' should be between 'minimum' and 'maximum'.
Parameter name: Value
at System.Windows.Forms.ProgressBar.set_Value(Int32 value)
at SQLQueryStress.Form1.UpdateUi() in D:_Samples\SQLServer\SqlQueryStress-master\src\SQLQueryStress\Form1.cs:line 414
at SQLQueryStress.Form1.mainUITimer_Tick(Object sender, EventArgs e) in D:_Samples\SQLServer\SqlQueryStress-master\src\SQLQueryStress\Form1.cs:line 283
at System.Windows.Forms.Timer.OnTick(EventArgs e)
at System.Windows.Forms.Timer.TimerNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
...
************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.
For example:

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

Oh, sorry, it may be I have the old version.

Could you try the latest build? I believe it is fixed.

Yes, now I am working with the latest build. It seems it was fixed, there is Min:
progressBar1.Value = Math.Min((int) (_totalIterations / (decimal) _totalExpectedIterations * 100), 100);

Great!


Properly handle lifetime parameters in the derive proc macro

The proc macro #[derive(PureClone)] does not properly handle lifetime parameters:
#[derive(PureClone, Clone)]
struct Foo<'a> {
    x: &'a i32,
}

It incorrectly suggests a lifetime parameter be added when one's already present:
error[E0726]: implicit elided lifetime not allowed here
 --> tests/derive_tests.rs:6:12
  |
6 |     struct Foo<'a> {
  |            ^^^- help: indicate the anonymous lifetime: `<'_>`

error[E0261]: use of undeclared lifetime name `'a`
 --> tests/derive_tests.rs:7:13
  |
6 |     struct Foo<'a> {
  |               - help: consider introducing lifetime `'a` here: `<'a>`
7 |         x: &'a i32,
  |             ^^ undeclared lifetime

error: aborting due to 2 previous errors

No longer relevant as proc macro has been disabled in 31f026d.


Twitter Topic

hello
can yoy add twitter topics?
examples
(Topic: Linux):
https://mobile.twitter.com/i/topics/848959431836487680
(Topic: Android)
https://mobile.twitter.com/i/topics/10026820777

FYI, we don't have Twitter bridge maintainer.

@alix78 I interpret topics as kind of like hashtags?

I can't find anything in the Twitter API documentation that would allow for querying of topics, so I won't be able to add this to TwitterV2Bridge.
Maybe @arnd-s can find something I missed, or figure out a clever way to use a different API endpoint.


Fix charts on Basilisk in collection

Time to fix the charts on collections in Basilisk.
We are not using current Basilisk data in charts.
Add floor prices and buy events as we have on RMRK charts.
https://beta.kodadot.xyz/bsx/collection/3612943633?tab=chart

test cases with many buys in collection

https://beta.kodadot.xyz/bsx/collection/2645998698?tab=history&event=BUY
https://beta.kodadot.xyz/bsx/collection/515729876?tab=history&event=BUY
https://beta.kodadot.xyz/bsx/collection/2600576003?tab=history&event=BUY
https://beta.kodadot.xyz/bsx/collection/2425975522?tab=history&event=BUY
https://beta.kodadot.xyz/bsx/collection/1679439669?tab=history

👋

ASSIGNMENT EXPIRED - @preschian has been unassigned.

hhmm, the PR already exists 🤔
do I need additional step?

ignore

ASSIGNMENT EXPIRED - @preschian has been unassigned.

hhmm, the PR already exists 🤔 do I need additional step?

no, for some reason the bot didn't pick up your opening of PR for this issue, otherwise it wouldn't unassign you. not sure what happened, maybe you've linked the issue after opening PR, or this was caused by the Autocode outage

hey I would like a chart that is a little easier to manipulate, that will add a bar that allows you to move the chart horizontally, without changing the zoom. actually something simpler

I updated the config to disable zoom by scroll and enable zoom by selection/drag. the experience should be better
what do you guys think? @yangwao @jrafaelangarita
link preview: https://deploy-preview-3651--koda-nuxt.netlify.app/bsx/collection/515729876?tab=chart&page=1
https://user-images.githubusercontent.com/734428/183238548-3a3f2ea0-aea1-495c-a852-4fe215ab245e.mov

personally I don't like that way, I would prefer that some + and - buttons appear, perhaps to better control the zoom, and the bar that I mentioned before, since as you can see in the first approach, it is not very well centered and you have to reset , and try again, etc.
idk what do you think? @preschian @yangwao

hey I would like a chart that is a little easier to manipulate, that will add a bar that allows you to move the chart horizontally, without changing the zoom. actually something simpler

2 things:

please, let's try to keep the conversation / feedbacking going in PR, once PR was open ( such as this case )
I think I'd like to stick with the version which already exists and do with this issue, what was supposed to be done, i.e. -> add data to chart.

Feel free to open up new issue about suggested changes to the chart visuals / manipulation :)

I think I'd like to stick with the version which already exists and do with this issue, what was supposed to be done, i.e. -> add data to chart.

👍👍👍
I agree, for now, how about focusing on the title first?
let me summarise the suggested improvements based on the thread discussion. basically, there are two requirements based on GitHub comments:

simple chart (bar, disable zoom) https://github.com/kodadot/nft-gallery/issues/3646#issuecomment-1206680752
show all the buys event on the chart https://github.com/kodadot/nft-gallery/pull/3651#issuecomment-1203727231

to accomplish those requirements, I think we need two types of chart

the requirement for using a bar chart is that each x point only has y data. for this one, I think we need to decide, for example, to use average or sum based on daily. maybe we can show two of them, counted daily:

average from the floor price
volume sum of buys

for showing all the buys events, I think using a scatter/bubble chart should be suitable. because the buy events can have multiple data in one day

cmiiw

@preschian I agree with what you're suggesting about avg / sum, let's just run this by @yangwao to avoid further confusion 😆


Release Functionality Does Not Honor "Send To" Addresses Specified in UI

First of all, thanks for the release function implemented by https://github.com/axllent/mailpit/issues/29. We just now started to test it, and have found a bug where the emails entered in the UI aren't being honored. A secondary bug, as a result of this, is that if the original To address is not on the recipient-allowlist, this actually bypasses it and allows it to be sent since the address the email is actually sent to isn't the one validated.
Background on our setup:

Mailpit container, listening on port 25, configured to relay to localhost:10025. Mailpit is also configured with recipient-allowlist as, say, @mac\.com$.
A postfix container, listening on port 10025, configured to further relay to AWS SES.
AWS SES is in SANDBOX mode, meaning only addresses verified by SES manually are sent.

For the purpose of demo, let's say we have two email addresses:

<EMAIL_ADDRESS>Verified by AWS SES.
<EMAIL_ADDRESS>NOT verified by AWS SES.

To reproduce:

First, generate a test email. For the purpose of demonstrating both bug, we'll have this sent to the email NOT verified by AWS SES:

echo "Test" | mailx -vvv -s "Test Subject" -S smtp=localhost -r<EMAIL_ADDRESS><EMAIL_ADDRESS>

Find email in Mailpit, and attempt to release it, which shows an error. This is working as intended, since @gmail.com isn't in the recipient-allowlist.

Repeat step 2, except now we'll remove<EMAIL_ADDRESS>and put in<EMAIL_ADDRESS>Once clicking on release UI responds with OK status.

On the downstream postfix, we see the email is still getting sent to the address<EMAIL_ADDRESS>(error message is from AWS SES). And no email is sent to<EMAIL_ADDRESS>at all.

2024-01-09T20:54:52.348Z [ERROR] Flow(localhost) Output(aws_0) MessageRejected: Email address is not verified. The following identities failed the check in region US-WEST-2<EMAIL_ADDRESS>
I've also verified that the API is indeed sent with the correct To data, so I do not think this is an UI issue, and potentially may be a problem with perhaps smtpd where the messages are written without changing the To field first.

Thanks for the detailed report @tonyswu! I'm not too sure what is going on here, but I have a suspicion...
Mailpit does not rewrite / overwrite any of the message headers when relaying a message. It simply takes the message and passes it onto the configured downstream SMTPD service telling it to whom it should be sent to. In your case the message is sent to AWS SES telling it to send the message to<EMAIL_ADDRESS>This is standard practice, as a receiving mail server should NOT be reading the headers of the email itself to decide who to send it to as this information is passed to it when receiving the original message.
To explain it better - if you send a normal message via SMTP with 2 people listed in the To and then have 2 people in BCC, your SMTPD will receive the message with 4 email addresses specified in the SMTP request. Not all 4 will appear in the email headers though (ie: typically no BCC header). Your SMTPD will then send out 4 separate SMTP requests to the various hosts, each of them defining 1 address in the SMTP request - even though the message being passed through still has only two emails listed in the To field.
Now I am wondering is AWS SES works differently - in that it does read the original message to decide who to send it to? I really don't know the answer, and I do not have AWS SES so I can't confirm that either, but I suspect this is a "feature" they have (or "bug"?). I suspect it's a feature which, although communicating over SMTP, differs from regular SMTP servers.

Regarding point 4 (the downstream postfix server), is postfix your relay SMTP server (ie: the one Mailpit is configured to use)? Assuming this is correct, then you should be able to see exactly who the message gets sent to in the postfix logs. I have tested in my setup and it works exactly as expected - postfix will only deliver to the accepted recipients you entered in Mailpit and not any other emails in the To etc.
Now I do not know how your postfix then relays emails to SES - is postfix actually relaying via SES, or delivering to SES? Either way, I believe that that is where the issue lies, not in Mailpit.

I did notice that the email that actually arrived in my inbox looked something like<EMAIL_ADDRESS><EMAIL_ADDRESS>in the To field. I'll run some additional tests tomorrow and see if I can figure out if it's indeed something to do with the downstream postfix.

That is very interesting, as it's not Mailpit doing that. Do you have come custom postfix rewrites or something? That may be where the issue is...

I ran some additional tests by putting another postfix instance in front of our SES relay, and judging from the postfix instance in-between it seems that emails are being released to both the original To address as well as the address entered at the release window. I believe from my original setup neither email was sent because it's considered as one API request to AWS SES, and was blocked in its entirety.
Can you confirm if this is the case from your end, that emails are being released to both original To address and the one entered by user? If so then this is still a problem since it bypasses the recipient-allowlist. But if you don't see this behavior then I'll close this issue and do some additional digging on my end and see what I am doing wrong.

@tonyswu I cannot replicate the issue you are experiencing. As I mentioned before, my instance of postfix is only sending emails listed in the release dialogue. All/any other emails referenced in the email headers (eg: To, Cc) are ignored. Mailpit does not modify those fields, not rewrite any email addresses as you experienced, so that am very confused too. What happens is you remove SES from the process (ie: get postfix to deliver the emails directly), does it work them?
As I also mentioned before, you should be able to see who the email is being sent to based on just the postfix logs too.
I still suspect that SES may be the culprit here, which may be somehow combining the original email data with the "send to" list that postfix should be telling it to use. This assumes though that postfix is delivering emails to SES via SMTP - if it is using some other protocol to deliver to SES then I don't know ....

I see. Since you aren't able to reproduce, I'll consider this resolved. Thanks for entering a discussion with me.


Add dark mode based on invert colors

Finally getting around to this one!
Add #62. Only inverts to white. Maybe have a green option? Not sure if thats too funky lol. Maybe at least for the calibration grid?
Also, it doesn't affect the landing page. Not sure if I should update that as well since the toggle isn't there. Maybe set landing page colour scheme based on system settings? Is that too confusing?

Yes! I can see the preview!
I think it's less important to do the main page...people click to that once then spend most of their time on the calibration screen. I wouldn't bother with the main page.

Ah, I'm glad the previews are finally working!


Simplify server_test

newRequest wrapper has minimal utility
sf var was defined but not used anymore
CloseNotifier is used but not utilized

Less code always looks good to me.

Merge? (Also, re: contrib guidelines, I assume we can freely merge given
that this doesn't affect runtime)
On Fri, May 29, 2015 at 9:51 AM, Troels Thomsen<EMAIL_ADDRESS>wrote:

Less code always looks good to me.
—
Reply to this email directly or view it on GitHub
https://github.com/heroku/busl/pull/54#issuecomment-106869389.

Please do.


Clear up what optimizers/schedulers are supported

📚 Documentation
It would be nice to know from the documentation rather than going through the configs.
@omry is there a way I can do:
python train.py optimizer --help

# prints
# optimizer: adadelta, adagrad, adam, adamax, adamw, asgd, rmsprop, rprop, sgd
# optimizer/deepspeed: adam, adamw, cpu_adam, onebitadam

To find all the options for a specific group? I know I can python train.py --help and see all options, but it would be nice to do the above!

Late response, but thank you @omry! This is very helpful :)


Allow better formatting in issues/maintenances

Currently, not even new lines are possible in maintenance/issue descriptions. At least that would be helpful.
Additional Markdown support would be even better, also for the page description shown in the header.

@adamcooke This is a useful feature and would make it easier to do a "postmortem" style of closing update on any incidents with severe impact.

+1 My vote is the markdown..

Will be add

Why was this closed? It's a useful feature to have and the open PR was never merged. 😕

The PR will be merged.


[Identity] Unify usage of MSAL / MSAL Cache

Is your feature request related to a problem? Please describe.
Unify our usage of the MSAL cache to align how other languages are using their MSAL caches. This requires that we first have msal-node support added Identity.
Describe the solution you'd like
Step #1: Wait for msal-node support.
Step #2: Align the use of the msal-cache with the name cache that's being developed to work hand-in-hand with the MSAL cache.

We're still blocking on some bugfixes on the MSAL team. Bumping to October

Closing in favor of #9778


Fix caching in "for narrow" selectors

When we want to pass an argument to a selector, like props.narrow to getRenderedMessages, we currently do so in a way that totally defeats Reselect's caching. We should fix this.
See discussion in chat. In particular, on what to do instead:

The solution recommended in the Reselect docs is to push the inspection of props inside the selector:
https://github.com/reduxjs/reselect#accessing-react-props-in-selectors
I don't love that solution -- it feels awfully implicit to me. [...] I'd much rather stick to passing specifically the narrow down to the selectors, like we currently do.
I guess there's nothing in the Reselect code (AFAICT) that depends on that "props" argument actually being the props of any React component. So we could just say getRenderedMessages(state, props.narrow), and have all the ...ForNarrow selectors take a second argument of type Narrow, and that may just all work great.
(We'd be treating that Narrow as what the Reselect docs expect to be "props".)

So instead of defining selectors so that their call sites look like getRenderedMessages(props.narrow)(state), we should define them so they're called like getRenderedMessages(state, props.narrow).
I don't think this is currently a top priority, though.

An update on how to approach this, something I learned from studying reselect and react-redux after reviewing #2450: in many of these selectors, we really wouldn't get a meaningful benefit from createSelector even if we used it correctly! For example:
export const getFetchingForActiveNarrow = (narrow: Narrow) =>
  createSelector(getFetching, fetching => fetching[JSON.stringify(narrow)] || NULL_FETCHING);

This should just be
export const getFetchingForActiveNarrow = (state: GlobalState, narrow: Narrow) =>
  getFetching(state)[JSON.stringify(narrow)] || NULL_FETCHING;

(Also it should be renamed by s/Active//.) Even if we used createSelector correctly, what the resulting selector would do when called is basically

(We're here because either state or the component's props has changed.)
Check if either state or narrow has changed.
If so, recompute fetching; else we're done.
Check if either fetching or narrow has changed.
If so, recompute the final result.

Whereas the simpler thing, when called, does

(We're here because either state or the component's props has changed.)
Compute fetching.
Compute the final result.

This will always recompute fetching, but that should either be cheap (like in this example) or have its own caching... and it will always recompute the final result. But on the other hand there's some small cost to those "check if changed" lines -- and most importantly, the simpler thing is much simpler to reason about and fully understand.
So in general, whenever the function that computes the final result -- i.e. that last argument to createSelector -- is doing very little work, we're better off dropping the createSelector. In particular if it's just a property access or two and some boolean logic, let's cut createSelector.
(It's possible this is actually a bad example because there's that JSON.stringify, and the caching can avoid that if the state changed only outside of fetching.)

The original example getRenderedMessages, though, is one where there can be a ton of work happening and so we definitely want the caching.
So are a bunch of the selectors in narrowsSelectors, where we go do some work on every message in the narrow.

I've just pushed a handful of commits that make a start on this. See discussion in cc9628e90 and 2d23ea707 and a bit in 31825016e, and additional examples in 61c84e352^..3d9baba57.
Plenty more to do! I count 20 more selectors this applies to, using this search command:
$ perl -0ne '
          print "$ARGV: $1\n" while (/^export const (\w+) = [^\n]*=>\s*createSelector/msg)
        ' src/**/*.js
src/chat/fetchingSelectors.js: getFetchingForNarrow
src/chat/fetchingSelectors.js: getIsFetching
src/chat/narrowsSelectors.js: getStreamInNarrow
src/chat/narrowsSelectors.js: getIfNoMessages
src/chat/narrowsSelectors.js: getShowMessagePlaceholders
src/chat/narrowsSelectors.js: isNarrowValid
src/drafts/draftsSelectors.js: getDraftForNarrow
src/message/messageSelectors.js: getRenderedMessages
src/message/messageSelectors.js: getAnchorForNarrow
src/subscriptions/subscriptionSelectors.js: getIsActiveStreamSubscribed
src/subscriptions/subscriptionSelectors.js: getStreamFromId
src/subscriptions/subscriptionSelectors.js: getSubscriptionFromId
src/subscriptions/subscriptionSelectors.js: getIsActiveStreamAnnouncementOnly
src/title/titleSelectors.js: getTitleBackgroundColor
src/topics/topicSelectors.js: getTopicsForNarrow
src/topics/topicSelectors.js: getTopicsForStream
src/topics/topicSelectors.js: getLastMessageTopic
src/typing/typingSelectors.js: getCurrentTypingUsers
src/unread/unreadSelectors.js: getUnreadCountForNarrow
src/users/userSelectors.js: getAccountDetailsUserFromEmail

Plenty more to do! I count 20 more selectors this applies to, using this search command:

Or, if you find the search UI in VS Code convenient, I just learned that it supports multiline searches!
Hit Ctrl+Shift+F (for "Search: Find in Files"), then Alt+R (to toggle "Use Regular Expressions"; equivalently hit the .* icon in the search box); then paste the query =>\s*createSelector\n?. (The silly \n? is there because, as documented at the link above, this VS Code feature only activates when an explicit \n is present in the query pattern.)
You should get, as of 57643645a, 20 results in 10 files -- same as listed in my previous comment.

With #3350, the last 5 examples of this are all fixed! Each of the places we try to create a cache with createSelector, we now actually succeed in creating a cache that can get used :slightly_smiling_face:
There are still a number of places where we have an unhelpful cache, in the way described in the first comment above: https://github.com/zulip/zulip-mobile/issues/3015#issuecomment-440890524 I'll file a new issue so we don't forget about that.


ACM-3640: fix channel rbac issues

https://issues.redhat.com/browse/ACM-3640

QE and Christine shed light on this issue for 2.7.1 👍


feat: sync llama.cpp

Sync llama.cpp with the b3972 release.
This will close #77.

I’m almost done, just running the final tests.
Mostly based on @Vali-98's work: https://github.com/Vali-98/cui-llama.rn
@Vali-98 , if you have a moment, a quick review would be much appreciated to catch anything I might have missed!

It looks okay from a glance, can't confirm for the IOS code though.
Just to confirm, I applied changes for cui-llama.rn from my fork of llama.cpp: https://github.com/Vali-98/llama.cpp/tree/cui-llama.rn
The current method of patching changes to llama.rn is the main reason why I wanted my own fork instead, as patching the files tends to fail spectacularly when syncing llama.cpp. I assume this is the reason why the CI is failing too.
Ideally for release builds, we would include prebuilt binaries instead of needing to build llama.cpp redundantly every time.

You might want to mention that this adds the vocab_only field as it isn't actually a part of gpt_params on llama.cpp.

This is awesome, thanks for the contribution!
It looks like n_gpu_layers = 0 for disable GPU is broken (see https://github.com/ggerganov/llama.cpp/issues/10089), I'll checkout for that before merge this.


Android package name case sensitiveness.

Hi, thanks for the great package, being using it a lot.
But I got into a pesky problem. On Android, some of my app package names already on play store have upper case letters. rn-rename (on line 81 and in other parts) set the bundleid toLowerCase(). Google doesn't allow the package name to change.
Is there a way I'm missing to keep the case sensitiveness on renaming the Android project?
If not, I'm considering developing this feature in rn-rename myself. In that case, what would be the right way to do it?
Thanks in advance.

It seems like some people may want an option to specify the Android package name for the APK and have this different than the source package name (which I believe has to be lowercase).

Closing, check v3

I faced the same issue,
DataBinding does not work with my package name because it has upper letters.
My App is already published on google play.
So
I changed package name upper letters to small letters in all project and in namespace
But
 I left only applicationId with old package name (with upper litters)
And it work fine, and I uploaded my app to google play successfully.

@01madbouly what version of rnr are you on?


Explicitly state num of threads in OpenMP.

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   82.41%   82.41%
=======================================
  Files          10       10
  Lines         182      182
=======================================
  Hits          150      150
  Misses         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b265a00...7ada8bd. Read the comment docs.


[Masthead/Footer] Accessibility - Form control element  has no associated label

IBM Equal Access Accessibility Checker
Form control element  has no associated label
Elements showing this error
<select ng-reflect-is-disabled="false" ng-reflect-model="10" id="pagination-select-items-per-page-0" class="bx--select-input ng-untouched ng-pristine ng-valid">
<select ng-reflect-model="1" ng-reflect-is-disabled="false" id="pagination-select-current-page-0" class="bx--select-input ng-untouched ng-pristine ng-valid">

@Praveen-sr Could you work with Ram to see whether this bug identified by the IBM Equal Access Accessibility Checker is valid?  If it is, could you let us know what the priority would be.  Thanks.

@abhin07 The masthead/footer components do not contain any pagination elements. Can you provide the page where you see these warnings, please?

@kennylam Apologies, this looks like an error on IBM carbon components. I guess I opened this one by mistake.

Closing based on comments above.


Add a doctor check for a systemd issue

A collaborative effort with @timaa2k .

Codecov Report

Merging #994 into master will decrease coverage by 76.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #994       +/-   ##
===========================================
- Coverage   96.83%   20.76%   -76.08%
===========================================
  Files          28       28
  Lines        1705     1705
  Branches       61       61
===========================================
- Hits         1651      354     -1297
- Misses         51     1350     +1299
+ Partials        3        1        -2

Impacted Files
Coverage Δ

src/dcos_e2e/backends/_docker/__init__.py
28.48% <ø> (-69.7%)
:arrow_down:

tests/test_dcos_e2e/test_node.py
0% <0%> (-100%)
:arrow_down:

tests/test_cli/test_cli.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_legacy.py
0% <0%> (-100%)
:arrow_down:

tests/test_cli/test_utils.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/backends/docker/test_docker.py
0% <0%> (-100%)
:arrow_down:

...est_dcos_e2e/backends/docker/test_distributions.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_cluster.py
0% <0%> (-100%)
:arrow_down:

tests/test_dcos_e2e/test_enterprise.py
0% <0%> (-74.7%)
:arrow_down:

src/dcos_e2e/backends/_docker/_containers.py
26.19% <0%> (-73.81%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9be3a6...e00610b. Read the comment docs.


Unsafe handling of forkpty() failure in pty_spawn()

Please look into the pty_spawn() function in src/pty.c.
int pty_spawn(pty_process *process, pty_read_cb read_cb, pty_exit_cb exit_cb) {
  /* ... */
  pid = forkpty(&master, NULL, NULL, &size);
  if (pid < 0) {
    status = -errno;
    goto error;
  } else if (pid == 0) {
    setsid();
    int ret = execvp(process->argv[0], process->argv);
    if (ret < 0) {
      perror("execvp failed\n");
      _exit(-errno);
    }
  }
  /* ... */
error:
  close(master);
  uv_kill(pid, SIGKILL);
  waitpid(pid, NULL, 0);
  return status;
}

If forkpty() fails, then it returns pid < 0 (actually, according to "man 2 fork", it is -1), and the error handling code does a "goto error". After the "error:" label, pid is still negative, and this negative argument (-1) is propagated to uv_kill(), which is a thin wrapper around kill() on Linux. Which means that kill() is eventually called with the first argument set to -1, and all processes except init are killed. So I'd suggest protecting uv_kill() and waitpid() with a check that pid is positive.

Also, if forkpty() fails, an attempt to close(master) would mean closing some random fd with the number coming from uninitialized memory. So, just a "return status" would likely be a proper way to handle this error.

Fixed on master, Thanks 👍


Language option in settings crashes the app on iOS

Device iPhone SE2
Issue: App crashes
Steps to reproduce Go to Settings > Languages

This is fixed in latest release. Happy to move to done. @ShaunBaker @floridemai

@helloantoine That's strange as it seems nothing has been done to address it...

:crystal_ball:  Great job. Looks good.


[10.x] Fix blade failing to compile when mixing inline/block @php directives

Closes #48407
Updated the php regex from .*? to (?:.(?!(?<!@)@php))*?---long story short this is just a negative lookahead that matches everything that is not followed by @php while also allowing @@pphp.
Partial credit goes to @rikvdh

Looks like they are failing on PHP 8.3. They are not failing on PHP 8.3 for other framework PRs that are open at the moment.

@taylorotwell, tests are passing after rebase

The additional tests suggested by @crynobone do not pass:

    public function testCompilationOfMixedPhpStatements()
    {
        $string = '@php($set = true) @php ($hello = \'hi\') @php echo "Hello world" @endphp';
        $expected = '<?php ($set = true); ?> <?php ($hello = \'hi\'); ?> <?php echo "Hello world" ?>';

        $this->assertEquals($expected, $this->compiler->compileString($string));
    }

    public function testCompilationOfMixedUsageStatements()
    {
        $string = '@php (
            $classes = [
                \'admin-font-mono\', // Font weight
            ])
        @endphp';
        $expected = '<?php (
            $classes = [
                \'admin-font-mono\', // Font weight
            ])
        ?>';

        $this->assertEquals($expected, $this->compiler->compileString($string));
    }

    public function testMultilinePhpStatementsWithParenthesesCanBeCompiled()
    {
        $string = "@php ("
                ."\n    \$classes = ["
                ."\n        'admin-font-mono'"
                ."\n    ])"
                ."\n@endphp"
                ."\n"
                ."\nLaravel";

        $expected = "<?php (\n"
                ."    \$classes = [\n"
                ."        'admin-font-mono'\n"
                ."    ])\n"
                ."?>\n"
                ."\n"
                ."<span class=\"<?php echo  implode(' ', \$classes); ?>\">Laravel";

        $this->assertEquals($expected, $this->compiler->compileString($string));
    }

    public function testMixedOfPhpStatementsCanBeCompiled()
    {
        $string = "@php(\$total = 0)"
                ."\n{{-- ... --}}"
                ."\n
{{ \$total }}
"
                ."\n@php"
                ."\n    // ..."
                ."\n@endphp";

        $expected = "<?php (\$total = 0); ?>\n"
                ."\n"
                ."
<?php echo e(\$total); ?>
\n"
                ."<?php\n"
                ."    // ...\n"
                ."?>";

        $this->assertEquals($expected, $this->compiler->compileString($string));
    }

@CalebDW please mark as ready for review again when tests are addressed

@taylorotwell,
There was a mistake in the third test, I've added the additional tests and corrected the mistake.

Thanks - will give this a shot.

I have faced an issue today, after updating Laravel from 10.24.0 to 10.25.0 by this change.
If you have a single-line PHP Statement that includes a ? or : the blade is failing to parse after this change.
Works:
@php ($var = ('a' == 'b'))
Does not work anymore:
@php ($var = ('a' == 'b' ? 'x' : 'y'))
It works again if you end the line with @endphp But that should not be mandatory.
@php ($var = ('a' == 'b' ? 'x' : 'y')) @endphp works

Hi,
I can confirm that inlined @php is broken when using ternary.

Chiming in here as I've had trouble upgrading to the latest version and I suspect this may be the culprit. Curiously my tests pass locally but they fail in CI (GitHub Actions) and I can't narrow down why.
TypeError: Livewire\Volt\VoltServiceProvider::Livewire\Volt\{closure}(): Argument #1 ($value) must be of type string, null given, called in /home/runner/work/roomies/roomies/vendor/laravel/framework/src/Illuminate/View/Compilers/BladeCompiler.php on line 262 and defined in /home/runner/work/roomies/roomies/vendor/livewire/volt/src/VoltServiceProvider.php:42

I ended up removing Volt and then my tests passed in CI again.
I deployed to production and then some customers complained about receiving blank pages and I was able to replicate. Rolled back to 10.24.0 and the problem has gone away.

This has caused massive issues, and unfortunately I didn't check my app's checkout page when I did the upgrade. Prime example of how tests give you a false sense of security. Can confirm this breaks @php($needsToIncrement++) as well, not just ternary.

@jorisleermakers, @QuentinGab, @dwightwatson @mikescola, @driesvints.
Additional information is needed along with a minimum reproducible example---I added tests for the specific use cases above and they pass regardless of the old or bew regex.

We're reverting this and removing @php() from the docs. We won't recommend using it any further only @php @endphp.

@jorisleermakers, @QuentinGab, @dwightwatson @mikescola, @driesvints.
Additional information is needed along with a minimum reproducible example---I added tests for the specific use cases above and they pass regardless of the old or new regex.
I'm specifically interested in if there are any @php tags before or after the ones that have issues.

I understand that, but I did not succeeded to reproduce the problem with only a simple blade view and inline php.
I assume that the error is not simply caused by the usage of ternary or nullish operator but in combination with something else.


Refactoring

Summary by CodeRabbit

New Features

Enhanced search functionality with exclusion filter for refined results.
Introduced new Lexer class for improved accuracy in parsing CSV data.

Refactor

Improved flexibility by adding new options to existing functions.
Centralized common option constraints for consistency.

Tests

Added comprehensive tests for new search filtering options and CSV lexing capabilities.

Documentation

Updated comments to reflect changes in functionality and testing.

Chores

Temporarily disabled the csv function for further development.

@coderabbitai review

@coderabbitai review

@coderabbitai resolve your review comments, if you are sure it is correct,

@coderabbitai review

@coderabbitai review

@coderabbitai review


Semtech SX1262

Hello. Your project helped me a lot, I continue to experiment with it, and these are the only nodes for hundreds of kilometers. I want to try the Semtech SX1262 and the E22-900M30S seems to be a good option for this.
http://www.ebyte.com/en/product-view-news.aspx?id=453
Could you add support for the Semtech SX1262?
Unfortunately, I do not have enough knowledge to do this.
Thank you very much for your work.

Thanks!
As you do not have all the knowledge, do you know how to make a sensor?
I have ordered a board and will have a look to see if the code would change a lot.
M.

Oh and btw i will work on version 6, the ESP 1 channel gateway version (without version 5)

Благодарность!
Поскольку у вас нет всех знаний, вы знаете, как сделать датчик?
Я заказал плату и посмотрю, сильно ли изменится код.
М.

There are several ideas on how to do this. But the modules are still on the way and I'm not sure if this will work))

Да, и между прочим, я буду работать над версией 6, 1-канальной шлюзовой версией ESP (без версии 5).

Hello. There are some successes with the boards E22-900M30S, Semtech SX1262


[Macros] Allow macro parameters to have default arguments.

SE-0382 allows macro parameters to have default arguments. Enable these default arguments, with the normal type checking rules. One significant quirk to this implementation is that the actual default argument values don't make it to the macro implementation. This is a previously-unconsidered design problem we'll need to address.
Tracked by rdar://104043987.
(cherry picked from commit 9d9f8326c829cd4ec3ca38e7ec40f04ad81daf68)

@swift-ci please test


AWAC doesn't profit from offline data

Hi,
@anair13 , it's nice that we can get the code, seems you answer AWAC questions frequently, so I just directly make "@" to you.
In AWAC paper the main benifit is that switching from offline-training to online training there is no "dip" of the performance. But when I run it on mujoco-gym environment, it doesn't get benifit from the pre-training on offline dataset.

HalfCheetah, it  learns nothing , the episode returns are almost always below zero.
Ant, it performs nearly expert performance after switching from offline to online, but it have a huge dip to nearly zero.
Walker2d, it also has a dip.

I run the code in repo examples/awac/mujoco/awac1.py with all default settings, seems pretraining on offline data doesn't help these experiments.  I find this link in issues(https://drive.google.com/file/d/1Qy5SYIGNwdeTHAGNjbRfuP5pSiRw8JzJ/view), looks in this file the leraning processs also doesn't profit much from the offline-learning.
Do I have to change any hyperparameter? If would be really super nice if I can reproduce the paper result.
Looking forward to your reply.
Best.

Met the same problem... In my case, i checked my result in "pretrain_q.csv", and found it seem like the offline_training procedure didn't actually happen... I'm looking closely into the source code, and i think maybe the default hyperparameters should be alterd.

This is my result for HalfCheetah, as you noted, "it learned nothing".

While the result shown in the paper looks like this:

I noticed that when creating the HalfCheetah-v2 environment, gym raised a warning indicating that HalfCheetah-v2 is outdated, is there any possibility that some changes in the environment caused this problem?

Hi @Winston-Gu , it seems that my question is not related to the problem discussed in here but and I am sorry for that. But I'm trying to reproduce the AWAC results and stucking with creating the figures like showed in the AWAC paper. I see that you maybe could create the similar figures like in AWAC paper. Could you please help me with that?
Thank you so much and wish you have a nice day.