Suppress host output

Currently, calling dbclone.export displays the host output in STDOUT:
Exporting to /home/foo/bar
Host:        mongodb://<username>:<password>@XXXXX.mlab.com:25125/dbclone-test
Selected DB: dbclone-test
------------------
Starting export...
------------------
...

Offer an option to suppress this so we can run in CircleCI which currently does not mask secrets in logs.
Alternately, lets move to TravisCI which does suppress secrets in logs.

Yup that should cover it. There is precedence for flag names like --silent/--quiet or --verbose depending on the default we pick.

Yeah I was thinking about these. We're verbose(-ish) by default here and I'm thinking about using --silent or --quiet to suppress all output.
I'd like to start with just a very explicit --hide-secrets and see how practical that is. It would apply only to two pieces of potentially sensitive data so it feels like a decent starting point.
My thinking is that this is version 0.0.3 right now so we still have enough flexibility to work out the best approach before reaching 1.0.0 :)
Feel free to disagree - just thinking out loud at this point.

Hi @anishkny,
After going back and forth on this I sat down yesterday and started working on callback data not being passed correctly.
As I was moving the logic for printing to StdOut I cleaned up this as well.
Now when using programmatically this will not print display the verbose information.
I hid the sensitive output behind a --verbose flag in CLI mode just as you suggested. Definitely feels far more intuitive than a non-standard approach I considered briefly.
Anyway, these changes are now in master (PR #22). example.js has been updated to use values returned from the exposed methods. All of them have the same signature except for drop method (that's just a boolean).


Update linux_dependencies for Gentoo.

Objective

Add dependencies installation instructions for Gentoo for linux_dependencies.md.

Solution

Edit the linux_dependencies.md.

This looks about right to me :) Thanks for the contribution!

bors r+


AZ Group List, giving out error when using it in Windows Terminal

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az group list
Errors:
400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 215, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 654, in execute
    raise ex
cli/core/commands/__init__.py, ln 718, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
cli/core/commands/__init__.py, ln 711, in _run_job
    six.reraise(*sys.exc_info())
...
python3.6/site-packages/msrestazure/azure_active_directory.py, ln 486, in get_msi_token
    result.raise_for_status()
python3.6/site-packages/requests/models.py, ln 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: http://localhost:50342/oauth2/token

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az group list

Expected Behavior
A list of resource groups should be displayed.
Environment Summary
Linux-4.15.0-1083-azure-x86_64-with-debian-stretch-sid
Python 3.6.10
Installer: DEB

azure-cli 2.7.0

Additional Context

hi @ShinraCorpMixer  This is a known issue similiar to #11749. Could you pls workaround with az login ?

Hello @yungezz the az login command and then doing az group list worked! Thank you for your help! :)


[Slider] A bug about classes.active

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When I provide the active attribute in classes, I will get an error of ‘'active' does not exist in type 'Partial <Record <SliderClassKey, string >>’, However, Slider ’s documentation indicates that it supports ‘classes.active’
https://material-ui.com/zh/api/slider/

Expected Behavior 🤔
The active attribute works！
Environment 🌎

Tech
Version

Material-UI
v4.10.0

React
v16.13.1

Browser

TypeScript
v3.7.5

@MontyMa Thanks for the report, the definitions are not in sync. What do you think of this fix? Do you want to submit a pull request? :)
diff --git a/packages/material-ui/src/Slider/Slider.d.ts b/packages/material-ui/src/Slider/Slider.d.ts
index c8bb045f0..dc388695f 100644
--- a/packages/material-ui/src/Slider/Slider.d.ts
+++ b/packages/material-ui/src/Slider/Slider.d.ts
@@ -59,7 +59,6 @@ export type SliderClassKey =
   | 'colorSecondary'
   | 'marked'
   | 'vertical'
-  | 'rtl'
   | 'disabled'
   | 'rail'
   | 'track'
@@ -68,6 +67,8 @@ export type SliderClassKey =
   | 'thumb'
   | 'thumbColorPrimary'
   | 'thumbColorSecondary'
+  | 'active'
+  | 'focusVisible'
   | 'valueLabel'
   | 'mark'
   | 'markActive'

Would love to work on this if MontyMa is not taking it :)

@konekoya Feel free too :).
This makes me think that we could have invested in the CI to catch all the occurrences of this problem. Considering that https://github.com/merceyz/typescript-to-proptypes is able to extra the props, I imagine we could have extracted the classes too and test them against the JavaScript implementation, crash if not matching. Anyway, that's for another time, let's wait to see how the styles will look like in v5.

Would love to work on this if MontyMa is not taking it :)

I thanks for fixing this bug, Good job!


consider supporting nerdctl+containerd?

Describe the proposal
My development environment uses nerdctl+containerd instead of docker, which makes dapr cli not work on my environment. Will containerd be added as a container runtime? I'd love to try and contribute a PR if this is possible.

Release Note
RELEASE NOTE:

@tianyax Sure, feel free to send a PR.

@tianyax If you are working on this please comment /assign on this issue

/assign

@tianyax There are a couple of questions here ... does nerdctl support all commands that docker supports?
Is there a plan to maintain compatibility with docker command similar to podman?

One other question is is there windows support for containerd and nerdctl?

@tianyax There are a some questions that I have ...

Does nerdctl support all commands that docker supports?
Is there a plan to maintain compatibility with docker command similar to podman?
Is there a nerdctl go library available that can be used instead of the command directly? And if so can that be used for nerdctl?
Is is there windows support for containerd and nerdctl?
What sort of documentation and support is needed for nerdctl when used with dapr?

These questions would help clarify adding support and documentation in the dapr CLI.

For 1,2,5:
nerdctl is a Docker-compatible containerd CLI, and as far as I know it will always be compatible, the community is active (maybe I'll contribute a PR fix if there are some incompatibilities), many users often use alias docker=nerdctl for a consistent experience with docker, so we probably don't need additional documentation(some environment variables may be excluded).
For 4:
nerdctl+containerd supports windows, but I haven’t actually used it. I need to verify the integrity of the function on windows
For 3:
nerdctl go library? I don't see this at the moment, maybe we can use the nerdctl project directly. If the function is simple, is it better to reduce the import of packages?

@mukundansundar Sorry, the --network-alias parameter is not supported when nerdctl run the container,  I will try to fix it, this feature may need to be delayed..

@tianyax Is it possible to use containerd with https://github.com/abiosoft/colima or with Rancher desktop on Macos ?

@tianyax Is it possible to use containerd with https://github.com/abiosoft/colima or with Rancher desktop on Macos ?

@pravinpushkar colima and rancher-desktop both use lima, which implements containerd support on mac by starting a qemu vm and using the containerd runtime inside it.  which makes me think it's not a supported runtime on the mac itself, so I filtered it out. But this should be supported, I will test it later.


Just doesn't work on Alpine (Error relocating /usr/local/lib/libgcc_s.so.1)

https://github.com/dprkh/ushrt/tree/4b7735b4938443e9f15d7d2831b2237b3aadaa3e
> sudo docker run --rm 1c5a070bd160d875b1f9fafe6c3335d821b588311d88c1af33477041581394ff
Error relocating /usr/local/lib/libgcc_s.so.1: __cpu_indicator_init: symbol not found
Error relocating /usr/local/lib/libgcc_s.so.1: __cpu_model: symbol not found

Interesting! I'm pretty slammed, so I probably won't get to this for a bit, but the next step would probably be to track down which dependency wants this symbol, and see if we can remove it.

It appears to be working when compiled from the latest source (36bd375eab32c579f6c1a2eed3d7c2a2dd7b2cdc).
https://github.com/dprkh/ushrt/tree/57fd4228888f3aee02c24291729cc0689b6818bf

Done!

Upon further investigation it appears the version of Just that I received from apk was 1.16, and it doesn't seem like much has changed dependency-wise.
diff --git a/Cargo.toml b/Cargo.toml
index f636509..ad7c8ac 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "just"
-version = "1.16.0"
+version = "1.25.0"
 authors = ["Casey Rodarmor<EMAIL_ADDRESS> autotests = false
 categories = ["command-line-utilities", "development-tools"]
@@ -20,13 +20,15 @@ members = [".", "bin/ref-type", "bin/generate-book", "bin/update-contributors"]
 [dependencies]
 ansi_term = "0.12.0"
 atty = "0.2.0"
+blake3 = { version = "1.5.0", features = ["rayon", "mmap"] }
 camino = "1.0.4"
 clap = { version = "2.33.0", features = ["wrap_help"] }
 ctrlc = { version = "3.1.1", features = ["termination"] }
 derivative = "2.0.0"
+dirs = "5.0.1"
 dotenvy = "0.15"
 edit-distance = "2.0.0"
-env_logger = "0.10.0"
+env_logger = "0.11.0"
 heck = "0.4.0"
 lexiclean = "0.0.1"
 libc = "0.2.0"
@@ -38,8 +40,8 @@ serde = { version = "1.0.130", features = ["derive", "rc"] }
 serde_json = "1.0.68"
 sha2 = "0.10"
 similar = { version = "2.1.0", features = ["unicode"] }
-snafu = "0.7.0"
-strum = { version = "0.25.0", features = ["derive"] }
+snafu = "0.8.0"
+strum = { version = "0.26.0", features = ["derive"] }
 target = "2.0.0"
 tempfile = "3.0.0"
 typed-arena = "2.0.1"
@@ -51,7 +53,7 @@ cradle = "0.2.0"
 executable-path = "1.0.0"
 pretty_assertions = "1.0.0"
 temptree = "0.2.0"
-which = "5.0.0"
+which = "6.0.0"
 yaml-rust = "0.4.5"

 [lib]
@@ -77,6 +79,7 @@ targets = ["x86_64-unknown-linux-gnu"]

 [profile.release]
 lto = true
+codegen-units = 1

 [[test]]
 name = "integration"

I am not going to dig any deeper since the issue seems to be gone, but I would double-check once the latest release actually makes it into the package manager.


How do I catch sentences that long press on words

When I press and select a word, can I get the sentence of the word? How should I call the function if I can?
Examples:
Today is a wonderful day!
When I press "wonderful", I also get "Today is a wonderful day!"

Implement this API in the EPUBNavigatorDelegate: https://github.com/readium/swift-toolkit/blob/9e0339787aa69f96bb16335f55a858d626eaccb9/Sources/Navigator/SelectableNavigator.swift#L38
Then look at the text context in selection.locator.text. The before and after properties should contain more text context around the current selected word.
If this doesn't work, you will need to implement your own JavaScript to do that:
https://github.com/readium/swift-toolkit/blob/9e0339787aa69f96bb16335f55a858d626eaccb9/Sources/Navigator/EPUB/EPUBNavigatorViewController.swift#L17


underrun not properly set / overrun overwritten

I noticed that stats.overrun was set twice with different variables.
Possible that the second line should say
stats.underrun = underflow;
https://github.com/myriadrf/LimeSuite/blob/d6b0371fc074f71fac2ccd43e1e7b6220657fe7c/src/protocols/Streamer.cpp#L113-L114
Regards,
Martin

fixed with 2d43f04d858e7ccb953ef3758948377214196feb


feat: support read-write separation under the leader-follower database

hi @chenquan any update about this PR?


24 Hour

Hello,
Is there a way to stipulate 24 hour clock format?
i.e 14:30 as opposed to 02:30?
Many thanks

You can add:
cards:
- type: custom:digital-clock
firstLineFormat: 'H:MM'
For this.

This worked for me:
On Mon, Nov 6, 2023, 5:24 PM IoT-CI-Ltd @.***> wrote:

Hi,
That does not work
[image: image]
https://user-images.githubusercontent.com/149575798/280759393-de043bb0-e5a4-47a5-baef-61f6bb93f4e8.png
—
Reply to this email directly, view it on GitHub
https://github.com/wassy92x/lovelace-digital-clock/issues/35#issuecomment-1795086206,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQI6GTPFAKLTMFCH3EROB3TYDD6KTAVCNFSM6AAAAAA6VUEWF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJVGA4DMMRQGY
.
You are receiving this because you commented.Message ID:
@.***>

Found the issue, and all sorted now, thanks for your help

firstLineFormat: HH:MM did not work for me. It showed the month instead of minutes.
With firstLineFormat: HH:mm it works correct for me.
https://moment.github.io/luxon/#/formatting?id=toformat


get vm via ID

Is it possible to instantiate the VM object using VM ID instead of the name?
    var compute = new Compute(config);
    var zone = compute.zone(zoneName);
    var vm = zone.vm(vmName);

ideally
    var vm = zone.vm(vmID);

Getting this error when using the ID:
{ ApiError: Invalid value '2991401413435446358'. Values must match the following regular expression: '[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?'

We don't have explicit support for that, as the name is generally the easier alias. However, you can find the VM you're looking for with a filter to getVMs:
zone.getVMs({
  filter: 'id eq<PHONE_NUMBER>435446358'
}, function(err, vms) {
  var vm = vms[0];
});


Use dedicated ViewPager/ViewPager2 actions

General SwipeableActions were used before that were not fully synchronized with ViewPager's state. Tests were flaky in rare conditions because of that.
Not to break public API I have added new methods. But IMO it would be good to get rid of SwipeableActions methods from KViewPager because:

ViewPager doesn't support swipeDown/Up
Are not fully synchronized by Espresso. Since swipe actions ends earlier then ViewPager settles. That makes tests flaky

closes #65

@audkar hey mate appreciate for the contribution! Can't disagree with redundant swipeUp and swipeDown. Could you remove inheritance from SwipeableActions and create temporary copy-paste method with the same signature with @Deprecated annotation please? Also tiny fixes for empty lines.

Fixed


slack.chat.command not working

Getting following response:
{"ok": true, "response": "Oops, that didn\u2019t work. Try again, maybe?"}

Hey
what did you send?

I wanted to run slack slash commands via api. Though no native support was available, I ended up at this repo via stackoverflow link.
I ran the script as described, but it is not running and giving above mentioned response.


does the cache partion can dynamic change?

Hi,thanks for you answer. It is my first time to use CAT may have some simple question:

does the cache partion can dynamic change?
does the CAT must have the kernel support,  whetner it can directly use by r/w msrs?
3.https://lkml.org/lkml/2015/6/25/591 list the kernel support the cat ,it is can use now, which kernel version?

Sure, no problem:

yes it can
the tool & library were initially created to use MSR registers. So it will work on legacy kernels as long as there is MSR kernel driver available. The downside of MSR interface is that the technologies can be managed on logical core basis only - no task or process tracking capability.
Going forward, as these technologies get adopted into upstream kernel the tool will be extended to support kernel interfaces, too. See PID monitoring option.
Latest known to me status of the patchset you refer to is that it not upstream yet

Just a final note on the topic:

mixed use of MSR and kernel interfaces to manage CAT or CMT & MBM may lead to unexpected behavior

I hope it helps.

thanks~


problem seperating instrumental

so i have a problem with seperating the instrument from the vocal when i go to song output and hear the instrument only sound it still have the vocal from the song in there so it doesn't seperate the vocal good enough but when i tried to seperate it myself manually using UVR and using the same model it does a very good job in seperating it so why does it do a terrible job in aicovergen(im running locally)? maybe you can make it use another vocal seperation model(like kim vocal 2) or add an option to change the model it uses, and settings for the seperation or somthing?

why is it when i use uvr it seperate the vocal and instruments perfectly but when i use aicovergen it still have all vocal in the instruments part

@Hulababa-22
Please could you explain about UVR. I am also looking to separate instrumental version.


Unchecked goal in Waypoint 13 for jQuery

Challenge http://www.freecodecamp.com/challenges/waypoint-target-the-parent-of-an-element-using-jquery has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
Your left-well element should have a red background. is unchecked even though the requirements are fulfilled

@UserName thanks for posting this issue!
Your code is incorrect. I mean $("#left-well").parent().css("background-color", "red"); Your code says "Hey, you, browser, make #left-well element's parent's background color red, but you actually need to set background color to red of your #left-well element and not it's parent's. So proper code looks like this:  $("#target1").parent().css("background-color", "red"); or $("#target3").parent().css("background-color", "red"); or $("#target5").parent().css("background-color", "red");

Please review the Guidelines for Contributing, thank you!.


Set feature folder approach

Functionality added
initialized a react app
set the feature folder approach
installed react-redux package
added navigation using react-router

INVALID SUBMISSION 🔴
Hi @ntazelo
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that doesn't have a descriptive README. Professional repo - Rule #5
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


missing match arms diagnostic

Following up on https://github.com/rust-analyzer/rust-analyzer/pull/3689#issuecomment-602718222, this PR creates a missing match arms diagnostic.
At the moment this is a very early draft, but I wanted to open it just to get some initial feedback.
Initial questions:

Have I roughly created the correct boilerplate?
Inside the new validate_match function:

Am I correct in thinking I want to do validation by comparing the match arms against match_expr? And when analyzing match_expr I should be looking at it as a hir_def::expr::Expr?
I mostly copied the chained if-let statements from the struct validation. Shouldn't there be a non-failable way to get an AstPtr from the hir data structures?

Thanks for all the guidance.

Am I correct in thinking I want to do validation by comparing the match arms against match_expr? And when analyzing match_expr I should be looking at it as a hir_def::expr::Expr?

Yes, basically you can get the type of the expr (which is the thing being matched), and then figure out what match arms should be there and compare them with the ones that exist.

Should validate_match be tested only in an integration type test by adding tests to crates/ra_ide/src/diagnostics.rs as I've started to do? This seems to fit the pattern of the missing field diagnostic for structs, but I can see this needing a lot more testing than the missing field validation needed.

We have a test for the missing field diagnostic here in hir_ty. Tests for the diagnostic should be in hir_ty; the quick fix will be calculated in ide, so the tests for that will need to be there.

Also, I am super unhappy about current code organisation for diagnostics in hir, it is kindof bad that diagnostics.rs, expr.rs and the file with the test are three unrelated files. On of the side-effects of this is that some diagnostics are indeed tested on the ide level, and not on the hir level.
So, another related task here is to refactor all this to a single self-contained module (which shouldn't be done in the same PR that adds a new diagnostics).

So, another related task here is to refactor all this to a single self-contained module (which shouldn't be done in the same PR that adds a new diagnostics).

It seems to me perhaps this refactor would be best done before adding another diagnostic. Thoughts on this? If so, I can pivot to looking at that and I'd probably have another round of questions once I get a chance to dive in.
On a different note, I think I found the place where rustc does exhastiveness checking of patterns.
https://github.com/rust-lang/rust/blob/master/src/librustc_mir_build/hair/pattern/_match.rs

It seems to me perhaps this refactor would be best done before adding another diagnostic. Thoughts on this?
edit - On second thought, after looking briefy at the refactoring task and realizing diagnostics cross several crates, I think that would require a broader scope of understanding than I currently have.

My thoughts exactly! Generally, I prefer to add things to the current infra, and then apply refactoring ontop immediately after: that way, I make sure I have all the necessary context in the cache before changing code.

I've spent a little bit of time reading the documentation in rustc around pattern matching, and I think I'm starting to understand.
The entry point for the interesting pattern match exhaustiveness checking work seems to be here.
https://github.com/rust-lang/rust/blob/master/src/librustc_mir_build/hair/pattern/_match.rs#L1626
But it seems that method is able to assume that all of the patterns in all of the arms of the match statement are valid. By that I mean they are patterns which match the type of the match expression. So I assume there is some earlier pass of the compiler which checks for this? But I don't think that earlier pass exists (yet) in rust analyzer?
Does this all sound correct? If so, I wonder if implementing a match arm validation diagnostic is a reasonable stepping stone on the way to an implementation of exhaustiveness checking?

Hm. First of all, we don't have 'passes', i.e. steps that are executed one after the other and when one fails, analysis stops. If we don't want to do this analysis if there are type mismatches in the expression, we need to implement a check for that.
We do type-check match expressions; that's what infer does. We don't report errors for it to the user since there are still too many false positives in type inference in general, but the inference result contains the type_mismatches. So you can check whether there are type mismatches on the match arms and act accordingly.
The last question is, how do we actually want to act if the match doesn't fully type-check. Just skipping the exhaustiveness check is an option, but I actually imagine there are lots of cases where we could still correctly do the analysis even if there are type errors. I think it might be a valid approach to start by always doing the analysis, and then see in which situations we absolutely cannot do it. It'd also be a possibility to skip it for now though.

Sorry, wrong button :grimacing:

I have a basic implementation of exhaustiveness checking which works for match statements made up only of tuples and bools. I think I'm ready to move into enums now, but I'm noticing that an enum in a match statement like:
enum Either {
    Foo,
    Bar,
}

fn foo() {
    match Either::Foo {
        Either::Bar => {},
        _ => {},
    }
}

The Either::Bar match arm pattern seems to be interpreted as a ra_hir_def::expr::Pat::Path. Is this correct? If so, where would I go lookup the enum definition given this Path?

You should be able to get that from infer.variant_resolution_for_pat.

You should be able to get that from infer.variant_resolution_for_pat.

Thanks for the quck feedback. I implemented this here, but variant_resolution_for_pat seems to be returning None for the test case I uncommented in that commit. Do I need to do something different in my test setup to allow this enum to resolve?

Hmm actually yeah, variant_resolutions only records resolutions of record patterns currently (like Foo::Bar { x, y }). I think we could add this though: basically, here, if we have a ConstId, StructId or EnumVariantId, call self.write_variant_resolution(id, it.into()).

@flodiebold @matklad do you have any thoughts on the minimally viable (worth merging) implementation of this?
Exhaustiveness checking currently works for tuples, bools, enums (unit and tuplestruct), and combinations of these types (tuple of enums, enum containing bool, etc).
At a minimum, I need to handle all of the unimplemented!. I can think of a few possible ways to do this:

Completely implement exhaustiveness checking. It doesn't seem necessary to me to wait for a complete implementation of exhaustiveness checking in order to merge this, since even a partial implementation will provide value to users of rust-analyzer.
Add a Unknown variant to the Usefulness enum. Given rust-analyzer must work on incomplete/incorrect code, it seems we'd definitely need some way to represent "I'm not sure if this match arm is useful or not" even if we had a complete implementation of exhaustiveness checking.
Modifying is_useful to return Result<Usefulness, UsefulnessUnknown>. The advantage of this over option 2 is that many of the functions in the _match module will be able to return Result<T, UsefulnessUnknown>, and we can use ? to ergonomically return early when we hit a condition that we can't handle (either it isn't currently implemented, or the source code we are checking is malformed in such a way that it breaks our ability to perform an exhaustiveness check).

Any opinions on these options? General thoughts on what you'd like to see here before this merges?

I think as long as it doesn't crash and doesn't produce false positives, it can't be too minimal :wink:
Maybe some explanatory docstrings would be good, since the purpose of PatStack and Matrix or the meaning of D(self) and S(constructor, self) isn't immediately clear to me.
On the Usefulness, I haven't tried to understand/review the code in detail yet, so I can't really say what's better, but using Result seems fine for now.
I think we should have a quickfix for the diagnostic if we show it; we could just not show it right now though, so it's not really a blocker for merging this.

I think as long as it doesn't crash and doesn't produce false positives, it can't be too minimal

Awesome :+1:
I'll work on cleaning this up, fixing the panics and making sure we err on the side of false negatives rather than false positives, and ping you when it's ready for review.

I've replaced all the panics, using the Result implementation discussed above. It added more complexity than I was hoping, but I still think it is better than the alternatives.
In the meantime I discovered/remembered there is still a potential for an incorrect analysis if the types of the match arms patterns don't align with the type of the match statement expression. I'm working out how to best handle that now.

This is now ready for review. On documentation, I tried to find a balance between referencing the relevant rustc documentation and copying it over, leaning toward referencing it. I'm not sure what the standard practice is here for this project, so let me know if you'd like to see something different.
I also tested this a small amount by running it against this repository. I also ran the CLI rust-analyzer analysis-stats, but I'm not sure that actually checks the diagnostics. In any event, it at least didn't crash, and seems to do the right things based on what I can see.
One thing I did notice while testing it though it that I will get duplicate warnings about missing match arms, since I have cargo watch configured in rust-analyzer, so I get the warning from rustc and rust-analyzer. Are we dealing with that somehow in other diagnostics? I also noticed here that rustc puts that diagnostic on the match expression, while I had somewhat arbitrarily chosen to put it on the match arms. Any opinions on where this should go?

Are we dealing with that somehow in other diagnostics?

No, not at the moment.

I also noticed here that rustc puts that diagnostic on the match expression, while I had somewhat arbitrarily chosen to put it on the match arms. Any opinions on where this should go?

Generally, the smaller target element the better.
@flodiebold do you want to do a final review pass here (not necessary before today's relase, mind you). If not, I can take over the reviewing

I was planning to review it this evening.

Regarding the rustc diagnostic and target element, being able to deduplicate the diagnostic is probably also a good reason to choose the same target element as rustc :thinking:

I also ran the CLI rust-analyzer analysis-stats, but I'm not sure that actually checks the diagnostics.

It doesn't yet, but it should!

I've moved the diagnostic to the match expression (from the match arms) to align with rustc. This makes the duplication much less of a UX problem imo after a small amount of testing.

@flodiebold thanks for the review! I think I've addressed your comments, let me know if there is anything else you'd like to see before this merges.

Somehow I am hitting a panic:
thread '<unnamed>' panicked at 'index out of bounds: the len is 0 but the index is 0', crates/ra_hir_ty/src/_match.rs:278:9
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:78
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1069
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1439
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:198
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:218
  10: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:511
  11: rust_begin_unwind
             at src/libstd/panicking.rs:419
  12: core::panicking::panic_fmt
             at src/libcore/panicking.rs:111
  13: core::panicking::panic_bounds_check
             at src/libcore/panicking.rs:69
  14: <alloc::vec::Vec<T> as alloc::vec::SpecExtend<T,I>>::from_iter
  15: ra_hir_ty::_match::is_useful
  16: ra_hir_ty::_match::is_useful
  17: ra_hir_ty::expr::ExprValidator::validate_body
  18: ra_hir::code_model::Function::diagnostics
  19: ra_hir::code_model::Module::diagnostics
  20: ra_ide::diagnostics::diagnostics
  21: std::panicking::try
  22: ra_ide::Analysis::diagnostics
  23: rust_analyzer::main_loop::handlers::handle_code_action
  24: <F as threadpool::FnBox>::call_box
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

This might be caused by this PR.
use std::borrow::Cow;
use std::str::Utf8Error;

fn result() -> Result<Cow<'static, str>, Utf8Error> {
    unimplemented!()
}

fn main() {
    let location = match result() {
        Ok(loc) => loc,
        Err()
    };
}

Thanks @cynecx for the report.
A minimal example of this is
    #[test]
    fn malformed_match() {
        let content = r"
            fn test_fn() {
                enum Either {
                    A,
                    B(u32),
                }
                match Either::A {
                    Either::A => (),
                    Either::B()
                }
            }
        ";

        check_no_diagnostic(content);
    }

I'll submit a fix tonight.


Rename flannelfox.settings.settings to flannelfox.settings.config

This will make it a bit more legible and sane!

fixed in the testing branch, will be implemented when it becomes the stable version


Suggestion: Disallow "m" ambiguity

Awesome package, thanks Jenna!
Suggestion:  Perhaps too opinionated, but I would love to see "m" (e.g., 30m) disabled as an accepted value given the potential ambiguity between minutes and months.  Minutes is a reasonable assumption and I understand why it's taken as a value, but the package would be even more helpful if there were forced explicitness here.
(There's also potential ambiguity with milliseconds, but that's a bit of a stretch.)
Anyway, thanks again!

hi @sjc5 👋 thanks for the feedback and i agree, explicitness would have been preferred from my side too. however, this package uses timestring internally which allows for these less explicit values. i could update the types perhaps but ppl would still be able to pass these values e.g. JavaScript projects.
personally, i'd prefer to keep the TS/JS experience the same so i could throw some errors, but increasing the size of this package to prevent this use-case doesn't seem all that worth it. this feedback might be better directed at the timestring authors tbh.
thoughts?


Transient ViewModel

Hello,
I am doing an application using Mediatr.
When i register a Transient ViewModel that implements a Handle from INotificationHandler
the first time the publish is executed in a Handler, it creates a new instance of the ViewModel.
If i set the life cycle to Singleton it works correctly.
Notice that the same viewmodel sends the command and has the subscription for the result.
I have a small sample at https://github.com/ruifaguiar/MediatrSample

How has this been solved ? I have the same issue even with singletons.


Add support for OTLP over HTTP/protobuf

Adds support for ingesting OTLP requests over HTTP with protobuf data. Changs in this PR:

Move the existing gRPC export handler and helpers to to otlp_trace.go and tests into otlp_trace_test.go
Add HTTP handler postOTLP that retrieves honeycomb headers, decodes the request body into a OTLP ExportTraceRequest and hands to internal function to process request
Update OTLP grpc Export handler to retrieve honeycomb headers from metadata and hand request to new internal function to process
Adds tests to verify rejection behaviour for non-protobuf based requests to postOTLP and test to pass request to postOTLP handler endpoint

Most recent commits was to add support for gzip/zstd encoding as part of the parsing process.


Added symfony/http-foundation to composer.json

1. Why is this change necessary?
Currently shopware uses symfony/http-foundation in 3.1 version, all other symfony components are 2.8 lol (https://github.com/shopware/shopware/blob/5.4/composer.lock#L2204). Also phpstorm added a new warning which is annoying 😊 . That fixes it 😄

2. What does this change do, exactly?
Adds symfony/http-foundation to composer.json and downgrade it to 2.8 like other symfony dependencies
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

+1 for the explicit declaration.
-1 for the downgrade. I would consider that a BC-Break.

@shyim I found some more missing dependencies that are not explicitly declared. Might you update your PR including these.
--- a/composer.json
+++ b/composer.json
@@ -35,7 +35,9 @@
         "ext-zlib": "*",
         "lib-libxml": "*",
         "symfony/http-kernel": "2.8.34",
+        "symfony/http-foundation": "2.8.34",
         "symfony/config": "2.8.34",
+        "symfony/options-resolver": "2.8.34",
         "symfony/class-loader": "2.8.34",
         "symfony/dependency-injection": "2.8.34",
         "symfony/validator": "2.8.34",
@@ -49,8 +51,11 @@
         "doctrine/dbal": "2.5.13",
         "doctrine/orm": "2.5.14",
         "doctrine/cache": "1.6.2",
+        "doctrine/collections": "^1.4",
+        "doctrine/annotations": "^1.6",
         "beberlei/assert": "2.5.2",
         "zendframework/zend-escaper": "2.5.2",
+        "zendframework/zend-code": "2.6.3",
         "oyejorge/less.php": "<IP_ADDRESS>",
         "guzzlehttp/guzzle": "5.3.2",
         "egulias/email-validator": "1.2.14",

I will update it. Thank you!

@shyim good catch.
It's a pitty that composer update --ignore-platform-reqs ignores the php version configured in config.platform.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-21613
Please use this issue to track the state of your pull request.

Already fixed in 5.5 branch


feat: upgrade to lit major prerelease

What I did

I updated the dependencies to the next major version of lit-element and lit-html.
Added lit-element and lit-html to main package.json to override the versions of lion.

If you want I can also change all your dependencies to lit, so point 2 isn't needed, but they advice to wait with this step.

Although the lit-element@^3 and lit-html@^2 packages should be largely backward-compatible, we recommend updating to the lit package as the other packages are moving towards eventual deprecation. (from Lit-2.0-Upgrade-Guide)

Since its based on prereleases, feel free to change the target branch.

superseded by https://github.com/modernweb-dev/rocket/pull/146


TerminalControl does not produce ENHANCED_KEY in win32 input mode

Environment
Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.19041.0 Microsoft Windows NT 10.0.19041.0

Windows Terminal
Version: 1.1.2021.0

mpv 0.32.0-572-g8fbc4b1737

Steps to reproduce

Play an audio only file as (i.e. only TUI, not GUI):

mpv *.mp3

Press arrow keys to control playback

LEFT and RIGHT
    Seek backward/forward 5 seconds. Shift+arrow does a 1 second exact seek (see --hr-seek).
 Shift+arrow does a 5 second exact seek (see --hr-seek).

Expected behavior
With previous Windows Terminal versions, the current position was modified as expected.
Actual behavior
LEFT, RIGHT, UP, DOWN keys not sending correct key codes:
[input] No key binding found for key 'KP6'.
A: 00:00:09 / 00:49:16 (0%)
[input] No key binding found for key 'KP4'.
A: 00:00:10 / 00:49:16 (0%)
[input] No key binding found for key 'KP8'.
A: 00:00:10 / 00:49:16 (0%)
[input] No key binding found for key 'KP2'.
A: 00:00:16 / 00:49:16 (1%)

If using powershell 7 without Windows Terminal, the arrow keys work ok. And as a reminder, it was working as expected in previous versions of Windows Terminal. Also works as expected in other shells (cmd.exe, Git Bash) without Windows Terminal.
PS: nvim and vim do not have this issue. Looking for other TUI apps to verify their behavior.

I just tried alacritty, version 0.4.3, and now I has the same problem; but I didn't update it. With  alacritty, it it possible to choose between conpty and winpty. With winpty, mpv works as expected.
I guess that conpty got updated with WT, and it produces the new key codes for mpv .
A workaround for mpv is to create an input.conf and map the new key codes that conpty assigns to arrow keys.

KP6/4/8/2 is interesting. Those are not the keys in the traditional T-cluster of arrow keys. Which arrow keys are you pressing? Do you have a number pad? Is numlock enabled?

Just for the record, WT cannot update the version of conpty that comes with Windows. Alacritty is using a version of conpty that was finished almost a year ago. It's missing a bunch of our input changes.
As a workaround, can you see what happens if you put the following setting at the root of your settings file?
"experimental.input.forceVT": true,

KP6/4/8/2 is interesting. Those are not the keys in the traditional T-cluster of arrow keys. Which arrow keys are you pressing? Do you have a number pad? Is numlock enabled?

It's a laptop keyboard. It doesn't have a dedicated number pad. Numlock is not enabled.
The keys are the T-cluster of arrow keys.

Just for the record, WT cannot update the version of conpty that comes with Windows. Alacritty is using a version of conpty that was finished almost a year ago. It's missing a bunch of our input changes.
As a workaround, can you see what happens if you put the following setting at the root of your settings file?
"experimental.input.forceVT": true,

I just installed Windows Terminal v1.0.1811.0 and it works (as it used to do).
Reinstalling alacritty to test.

I didn't know that conpty was not updated by WT. Sorry about making that assumption.
I just tested alacritty 0.4.3 and it has the problem, but now I'm not so sure that it didn't have that issue before. I used WT fulltime.
Is it possible to query my system to know conpty's current version and the last time it was updated?
But since WT v1.0.1811.0 does not have the issue, I am clueless about the root of the problem:

Terminal/shell
Has the issue?
PTY

WT <IP_ADDRESS>.0/any
No
ConPTY

WT 1.1.2021.0/any
Yes
ConPTY

alacritty 0.4.3/PS7
Yes
ConPTY

alacritty 0.4.3/PS7
No
WinPTY

NA / PS7
No
NA

NA / WPS
No
NA

NA / cmd
No
NA

NA / Git Bash
No
NA

I'll reinstall WT 1.1.2021.0 to try the suggested setting:
"experimental.input.forceVT": true,

WT 1.1.2021.0 works as expected with the setting.

WT 1.1.2021.0 works as expected with the setting.

I'm also quite surprised that alacritty has this problem with ConPTY. We made some input changes (#4999) between Terminal 1.0 and 1.1 that are not available to alacritty yet.
You're using ConPTY 10.0.19041.0 (same as the version of Windows you're using.)
Is this a Windows build of mpv? Can you point me to where you got it?
If you want to help debug what is happening, can you do the following?

Set the following settings:

"debugFeatures": true,
"experimental.input.forceVT": false,

Open a new tab in Terminal, and hold down Left Alt and Right Alt

When you do this, you should get two panes, one of which contains weird garbage.

Press the arrow keys. This should generate red text on the right pane.
Send a screenshot of the garbage pane.

Is this a Windows build of mpv? Can you point me to where you got it?

Yes, it is. From sourceforge: https://sourceforge.net/projects/mpv-player-windows/files
FYI and to help other mpv users of WT: https://github.com/mpv-player/mpv/issues/7944
Here you are:

To demonstrate some difference on how applications recieve arrows input, I wrote this program:
#include <stdio.h>
#include <conio.h>

int main(int argc, char **argv)
{
    int c;
    while ((c = getch()) != '\033' /* ESC */)
        printf ("'%c'  0x%02x\n", c < 32 ? '?' : c, c);

    return 0;
}

In windows 10 2004, in normal windows console, pressing the left arrow (at the inverted T arrows cluster) produces:
'α'  0xe0
'K'  0x4b

While in Windows Terminal 1.1.200629002-release1.1 it produces:
'?'  0x00
'K'  0x4b

Caveats:

The program was compiled using x86_64-w64-mingw32-gcc (GCC) 9.2.0 (from Cygwin).
Windows Terminal was not installed properly - it was extracted from the installer and executed in the extracted folder.
mpv uses ReadConsoleInputW and not getch().

Nevertheless, it does seem to suggest that there's some difference between windows console and windows terminal in how non-VT-input applications recieve arrow keypresses, and additionally with my setup I was able to reproduce the OP's issue when pressing the left arrow - mpv perceiving KP4 at the windows terminal, and LEFT at the windows console.

Thanks so much. This has been really helpful.
This is the Terminal equivalent of #2397. There's a specific encoding bit that we were missing from the standard arrow keys.


Fix/add test record by object

Hi there!
This PR is addresses https://github.com/RedHatQE/pylero/issues/175.
I refactored the functions create_incident_report and generate_description to methods of the class TestRun.
In those two methods, I circumnavigate the usage of TestCase by using the project's predefined test case work item (member of project.get_tests_configuration()).
Should also this work item type not exist, I use the base class _WorkItem.
I have tested this exploratively on my side, but I could not figure out how to run the unit tests. Can I do that at all?

but I could not figure out how to run the unit tests

see if this helps, you just create a dummy project and set that in your config and tests will be run against that project, there is no regression w/ this PR.

# gpr 117
From github.com:RedHatQE/pylero
 * [new ref]         refs/pull/117/head -> pr117
Switched to branch 'pr117'

# g cherry-pick ad1561f
Auto-merging setup.py
[pr117 bb6554d] editable temp commit
 Date: Wed Jan 25 08:21:30 2023 +0530
 1 file changed, 2 insertions(+), 1 deletion(-)

# g show
commit bb6554dd7786446a12ac62e28dd1194f76f829b5 (HEAD -> pr117)
Author: Leela Venkaiah G<EMAIL_ADDRESS>Date:   Wed Jan 25 08:21:30 2023 +0530

    editable temp commit

diff --git a/setup.py b/setup.py
index b3f50e8..c7109a3 100644
--- a/setup.py
+++ b/setup.py
@@ -46,7 +46,8 @@ if __name__ == "__main__":
<EMAIL_ADDRESS>         license="MIT",
         package_dir={
-            PACKAGE_NAME: "src/%s" % PACKAGE_NAME,
+            # PACKAGE_NAME: 'src/%s' % PACKAGE_NAME,
+            "": "src",
         },
         packages=[
             PACKAGE_NAME,

# pip install -e .
Obtaining file:///root/toolbox/pylero
  Installing build dependencies ... done
  Checking if build backend supports build_editable ... done
  Getting requirements to build editable ... done
  Preparing editable metadata (pyproject.toml) ... done
Requirement already satisfied: click in /root/toolbox/venv/pylero/lib/python3.12/site-packages (from pylero==0.0.4) (8.1.7)
Requirement already satisfied: suds in /root/toolbox/venv/pylero/lib/python3.12/site-packages (from pylero==0.0.4) (1.1.2)
Building wheels for collected packages: pylero
  Building editable for pylero (pyproject.toml) ... done
  Created wheel for pylero: filename=pylero-0.0.4-0.editable-py3-none-any.whl size=9036 sha256=9ef54ab7abb89f41ec9accd68a07842f6310d3dfdffe0cfc1549fc4f45b43410
  Stored in directory: /tmp/pip-ephem-wheel-cache-3sf9pgxw/wheels/92/72/83/a4d9f0ebfaf6b6fd6d5d457218f1aba28e9ef2e2a6c1bd9e31
Successfully built pylero
Installing collected packages: pylero
  Attempting uninstall: pylero
    Found existing installation: pylero 0.0.9
    Uninstalling pylero-0.0.9:
      Successfully uninstalled pylero-0.0.9
Successfully installed pylero-0.0.4

[notice] A new release of pip is available: 23.2.1 -> 24.0
[notice] To update, run: pip install --upgrade pip

# cp .pylero ~/.pylero

# cd src/unit_tests/

# python -m unittest
..............
----------------------------------------------------------------------
Ran 14 tests in 103.358s

OK

/hold for rework on reviewable diff

I cleaned up my history :)

Great work, I've tested it and it pass my local test without regression.
For test local, after create a dummy project and prepared a .pylero config with it and user token, the src/unit_tests/attribute_test.py have two hard code users USER and ALT_USER might need be created on your instance.
Thanks for working on this.


/etc directory can't access in macos docker

I noticed that the docker-compose uses the '/etc/localtime' and the '/etc/timezone', but this doesn't work in macos, in macos you can't use volumn on /etc directory, it will report an error. I solved this problem by modify the docker-compose and volumn an another localtime into docker.

/etc/timezone issue been fixed in PR #109 , and has been merged into the develop branch, you can try using the develop branch, but it's still in the active development stage.

@cenzhipeng any feedback? or I will close this issue, FYI.


Automate favicons generation

see https://realfavicongenerator.net/api/interactive_api#regain-control

Doesn't really make sense here - not anymore.


Improvements 2022-12-2

Small fixes and changes:

Stop caring about the m1n1 mach-o binary
Add curl, wget, and wormhole-william to the installer environment to make it easier to copy files
Fix the "Error switching console mode" bug
Increase the size of the u-boot font, which makes the NixOS generation picker readable

Previous review comments at https://github.com/tpwrules/nixos-m1/pull/32

I rewrote the U-Boot fix to be a fix by default instead of a suggestion for the user's own config. Hope you don't mind.
Thanks for the improvements.


Mix and Ald packages

Hello,
what kind of Python library are Mix and Adl ?
Can be they used in Jupyter environment?
Thank you for paying attention to this issue,
kind regards

go 'https://github.com/mikemull/midaspy/blob/master/midas/'


How to cleanup pid file in Windows

Hi friends,
This is an awesome project, but I have not yet figured out how to clean up the pid file in Windows when sending a SIGINT from another process.
I have a demo where I set up a server that writes input to a test file.
import sys

from daemoniker import Daemonizer, SIGINT
from demo.server import create_server
from demo.util import PID_FILE_PATH

def main():
    name, port = sys.argv[1:3]

    with Daemonizer() as (is_setup, daemonizer):
        if is_setup:
            print('setup entered')

        is_parent = daemonizer(
            PID_FILE_PATH
        )

        if is_parent:
            print('is parent entered')
    try:
        # Creates an async server set to run forever
        create_server(name, int(port))
    except SIGINT:
        PID_FILE_PATH.unlink()

if __name__ == '__main__':
    main()

However, when I use
from daemoniker import send
from daemoniker import SIGINT

# Send a SIGINT to a process denoted by a PID file
send(PID_FILE_PATH, SIGINT)

To kill the child process the SIGINT exception is not caught and the file is not deleted. Ideas?
EDIT: I've tried different versions of using a SignalHanlder with a different PID file, but I cannot get the tear down to happen gracefully when sending a SIGINT from another process to signal tearing down the server.
import sys

from daemoniker import Daemonizer, SIGINT, SignalHandler1
from demo.server import create_server
from demo.util import PID_FILE_PATH

def main():
    name, port = sys.argv[1:3]
    # I had hoped sending a SIGINT to pid2.pid would trigger the SIGINT cleanup below.
    sighandler = SignalHandler1(PID_FILE_PATH.with_name('pid2.pid'))

    with Daemonizer() as (is_setup, daemonizer):
        if is_setup:
            print('setup entered')

        is_parent = daemonizer(
            PID_FILE_PATH
        )

        if is_parent:
            print('is parent entered')
            sighandler.start()
    try:
        create_server(name, int(port))
    except SIGINT:
        print('Sigint hit')
        PID_FILE_PATH.unlink()

if __name__ == '__main__':
    main()

EDIT: I tried setting up the sighandler only in the "child" process, but every time I send SIGINT to pid2 a new pid2 file is created with a different process number. I'm still not sure how to gracefully clean up.
def main():
    name, port = sys.argv[1:3]

    with Daemonizer() as (is_setup, daemonizer):
        if is_setup:
            print('setup entered')

        is_parent = daemonizer(
            PID_FILE_PATH
        )

        if is_parent:
            print('is parent entered')

    sighandler = SignalHandler1(PID_FILE_PATH.with_name('pid2.pid'))
    sighandler.start()
    try:
        create_server(name, int(port))
    except SIGINT:
        Path('log').write_text('SIGINT HIT')
        sighandler.stop()
        PID_FILE_PATH.unlink()

if __name__ == '__main__':
    main()

EDIT:
I think my async server was preventing the Exception in the main thread from being received. I tried spinning off the server to another thread and it worked.
def main():
    name, port = sys.argv[1:3]

    with Daemonizer() as (is_setup, daemonizer):
        if is_setup:
            print('setup entered')

        is_parent = daemonizer(
            PID_FILE_PATH
        )

        if is_parent:
            print('is parent entered')

    sighandler = SignalHandler1(PID_FILE_PATH.with_name('pid2.pid'))
    sighandler.start()

    # Try running the server in another thread
    thread = Thread(target=create_server, args=(name, int(port)), daemon=True)
    thread.start()
    while True:
        try:
            time.sleep(1)
        except SIGINT as err:
            logger.exception(err)
            sighandler.stop()
            PID_FILE_PATH.unlink()
            break

if __name__ == '__main__':
    main()

Same here.
Got web.py small util. Python 3.6 and OS is windows 10
try:
    # Send a SIGINT to a process denoted by a PID file
    send(d_config['pid'], SIGINT)
except OSError:
    # precess is dead.
    os.remove(d_config['pid'])

Will also help if the server was shut down abnormally. Though can get you in trouble if you can't kill the process because of lack of rights.


When the sample code in the v5.0 document is clicked to copy, the style is wrong and messy

System Info

Operating system and version:  All/Unrelated
Browser and version: All/Unrelated

Steps to reproduce

open (https://getbootstrap.com/docs/5.0/getting-started/introduction/)
click the copy button at the top right of the sample code

What is expected?
Just like the old version of the document, see (https://getbootstrap.com/docs/4.6/getting-started/introduction)

The root cause is the same as #32372 AFAICT


L.control.layers collapses after first mouse hoover

Leaflet version I'm using: 1.0.2
Browser (with version) I'm using: Chrome
OS/Platform (with version) I'm using: Win7

I'm initializing the map with 'collapse:false' option. After first mouse hoover control collapses, but it should stay expanded at all times.
https://playground-leaflet.rhcloud.com/bipo/edit?html,output

The problem lies in that this line is executed even when collapsed: true is set.


Linux container created on Windows produces CTP1009: An error occurred while attempting to download the Azure Functions CLI toolset

Using Visual Studio 2019 16.6.3, I create a bare Function app, with an http trigger.
Once this is complete, I right-click the project and choose Add Docker Support.  I am running Linux docker containers on a Windows machine.
Pressing F5 to debug run the app, the container appears to build successfully.  I can also build it from the command line:
Successfully built c9824aa43e49
Successfully tagged functionapp1:dev

I can also run it from the command line, when using docker run.
However, starting the app seems to fail with this error when run with Visual Studio F5:
error CTP1009: An error occurred while attempting to download the Azure Functions CLI toolset.
1>Done building project "FunctionApp1.csproj" -- FAILED.

I already have the cli tools on my Windows host.  How would I get them into the container that I'm building?  Wouldn't the image mcr.microsoft.com/azure-functions/dotnet:3.0 that I'm using already have them?
This is my Dockerfile, which is the standard one created by VS:
FROM mcr.microsoft.com/azure-functions/dotnet:3.0 AS base
WORKDIR /home/site/wwwroot
EXPOSE 80

FROM mcr.microsoft.com/dotnet/core/sdk:3.1-buster AS build
WORKDIR /src
COPY ["FunctionApp1/FunctionApp1.csproj", "FunctionApp1/"]
RUN dotnet restore "FunctionApp1/FunctionApp1.csproj"
COPY . .
WORKDIR "/src/FunctionApp1"
RUN dotnet build "FunctionApp1.csproj" -c Release -o /app/build

FROM build AS publish
RUN dotnet publish "FunctionApp1.csproj" -c Release -o /app/publish

FROM base AS final
WORKDIR /home/site/wwwroot
COPY --from=publish /app/publish .
ENV AzureWebJobsScriptRoot=/home/site/wwwroot \
    AzureFunctionsJobHost__Logging__Console__IsEnabled=true

When I build this file from the command line using the parameters that VS uses, I get only 5 steps:
D:\src\FunctionApp1>docker build -f "D:\src\FunctionApp1\FunctionApp1\Dockerfile" --force-rm -t functionapp1:dev --target base  --label "com.microsoft.created-by=visual-studio" --label "com.microsoft.visual-studio.project-name=FunctionApp1" "D:\src\FunctionApp1"
Sending build context to Docker daemon  16.38kB
Step 1/5 : FROM mcr.microsoft.com/azure-functions/dotnet:3.0 AS base
 ---> 2fe4640c33c3
Step 2/5 : WORKDIR /home/site/wwwroot
 ---> Using cache
 ---> 97a1f23cd03a
Step 3/5 : EXPOSE 80
 ---> Using cache
 ---> eae663d73848
Step 4/5 : LABEL com.microsoft.created-by=visual-studio
 ---> Using cache
 ---> ca4040cad389
Step 5/5 : LABEL com.microsoft.visual-studio.project-name=FunctionApp1
 ---> Using cache
 ---> 5e6809fb5370
Successfully built 5e6809fb5370
Successfully tagged functionapp1:dev

When I build this container from the command line using a more limited series of parameters, I get an expected 16 steps:
D:\src\FunctionApp1>docker build -t functionapp1 -f FunctionApp1/Dockerfile .
Sending build context to Docker daemon  16.38kB
Step 1/16 : FROM mcr.microsoft.com/azure-functions/dotnet:3.0 AS base
 ---> 2fe4640c33c3
Step 2/16 : WORKDIR /home/site/wwwroot
 ---> Using cache
 ---> 97a1f23cd03a
Step 3/16 : EXPOSE 80
 ---> Using cache
 ---> eae663d73848
Step 4/16 : FROM mcr.microsoft.com/dotnet/core/sdk:3.1-buster AS build
 ---> 052ed32b57d8
Step 5/16 : WORKDIR /src
 ---> Using cache
 ---> f1bed047a022
Step 6/16 : COPY ["FunctionApp1/FunctionApp1.csproj", "FunctionApp1/"]
 ---> Using cache
 ---> f5a24389cfe0
Step 7/16 : RUN dotnet restore "FunctionApp1/FunctionApp1.csproj"
 ---> Using cache
 ---> 5086f1c4636d
Step 8/16 : COPY . .
 ---> Using cache
 ---> 522eea5a423c
Step 9/16 : WORKDIR "/src/FunctionApp1"
 ---> Using cache
 ---> e1705a301eb1
Step 10/16 : RUN dotnet build "FunctionApp1.csproj" -c Release -o /app/build
 ---> Using cache
 ---> 6a5932b5e4dc
Step 11/16 : FROM build AS publish
 ---> 6a5932b5e4dc
Step 12/16 : RUN dotnet publish "FunctionApp1.csproj" -c Release -o /app/publish
 ---> Using cache
 ---> bbeae3c3ad17
Step 13/16 : FROM base AS final
 ---> eae663d73848
Step 14/16 : WORKDIR /home/site/wwwroot
 ---> Using cache
 ---> 4c288f5d2973
Step 15/16 : COPY --from=publish /app/publish .
 ---> Using cache
 ---> 362aa59d9adc
Step 16/16 : ENV AzureWebJobsScriptRoot=/home/site/wwwroot     AzureFunctionsJobHost__Logging__Console__IsEnabled=true
 ---> Using cache
 ---> b38c1667cb41
Successfully built b38c1667cb41
Successfully tagged functionapp1:latest

It seems that the VS-supplied parameter --target base is the one that is removing the additional steps.

Hey @chriswill! Did you figure this out? I was doing some tests and I'm able to run thew container successfully, but one of my colleagues can't. From what I've been reading, it might be related to slow network speeds. How did you sort this?

@DanielSSilva I'm no longer working with containers on this project any longer, so I didn't create or record a solution.

In my case, the resolution was updating the package Microsoft.VisualStudio.Azure.Containers.Tools.Target.
Install-Package Microsoft.VisualStudio.Azure.Containers.Tools.Targets -Version 1.15.1


ShowHealthBarsComponent should support multiple damage containers

Description

Would help with e.g. arachne and probably the structural goggles in the future.
Also if you want to submit health bars in general upstream afterwards feel free, the overlay seems good and the weak point is the GrantComponent spart.

Fixed by #1662


Gear selection and links does not work for me

Describe the bug
In sims (warlock and hunter tested), I am unable to choose gear. When I click on slot icon, nothing happens. Other tabs (settings etc.) works fine.
I am also unable to use links to build - when I open the link, the whole sim is empty - no items, nothing is set up in settings etc
To Reproduce
Steps to reproduce the behavior:

Hard to tell, no sure if someone else reported it.

Expected behavior
I would like to be able to choose gear and open links :)
Sim Links and Screenshots
This si how following link looks on my end:
https://wowsims.github.io/wotlk/warlock/#eJztUj1IHEEU3u/tes4tKKOkGK/abBMJCHN7LJjK1UqwObC50hRaBAuRNEl1uUax0dYDSZvGEMTC31PUw59EFCVK7sTCRLKlIdiKb87rba6w8GP4eN/73nszMM/1BEnS1I1+5DBGeWAG+AbaBI6BGOhrE/BII0LWVOAL0G6lik0FJLKjbz8Mj4tmKVLrcKW8XiV1eEl+orxFpSVyk/L2gny7wmGLjNk8YNM2jpA/WVYWbO76y9ER1yXY+M9eq4zPSZ1UyXc4Y7H+wxXn83ZdJ+W/tfoYKZfYKpQfmiu1wV9LpOJ523XkdImYZ5YN36wa3lgxFT+4Z7dq9OcFw4VF8oWARtbJOa/3yHpGQ/AxKSBJmZ16l3JbWdgKHjphlol3KMGZJoUpvNJBV6AzfDI6rTOhTgchR5kwMJTuCkNtEF5BiV/XJOcmbFX9Tl7hlDrvTkh/OqUYzg2ai7AqsPwpO1l7QH4kant4youoozhrsN/zcqSGs57gN3mDip7sh7+PGjElv7/zyJyBhtxj8KbGk9tRbz0RDeEegQZ51A==

Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: 104.0.5112.81 (64-bit

Additional context
I tried opening it in IE also, but same problem. Links does not work at all, it just does not open, no error message.

You can contact me via Discord - TheNameLess#7783 if that would be better.

Hey mate, did you ever get to fix that issue? Or found a workaround?

Sadly not. 99% of times, when I open the sim, it just won't load. Nothing is inputted (buffs, gear etc.). I can select buffs but I am not able to select gear and when I click on the icon, nothing happens. Also when I press DPS button to sim, it is just endless loading.
There is very low chance for me that it loads properly but I have to spend legit 5-10 minutes refreshing the page, "fishing" for proper load. Once I close my browser, it is gone again.
My plan is to reinstall Windows fairly soon, so I hope it might change something.


Clear the data/log for jobs in Gitea Actions that are too old

Feature Description
Jobs that have been done for too long no longer need to retain data/log, so it is necessary to regularly clean them up.

Log file.
Outputs.
Artifacts? (not sure)
And more?

Screenshots
No response

Maybe a related question?
To save the storage usages, is it worth compressing these data/log?

I was now looking for this 😊
Thanks!!

Maybe we can compress as zip, so that when display via HTTP, it can be unzip by web browser.

Maybe, but I think most important is to be able to purge too, with some Retention setting (e.g. older than 1 month, keep last 3, etc), so that the storage doesn't grow forever.

+1 for purge ability; this is my use case:
I'm managing an interlal Gitea server, and I'm going to make Actions available to my co-worker devs.
Since there's no other way to test push Actions than... pushing, I've played with them by "trial and error" 😉.
These tests caused the repo to actually contain 150+ completely useless job executions, so I'd like to purge all of them before going to "production".
To make it worst, I suppose that once Actions will be made available to anyone on my server, my co-workers will also start testing them with the same result.
And finally, once in production, there's no need for us to keep any of repos Actions logs longer then 2wks...

about the Artifacts would it be possible to add a little rubbish icon next to the file name so they can be deleted manually? (talking about artifacts created by actions and uploaded via actions/upload-artifact)

For me, 7 days is more than enough

For me, 7 days is more than enough

Would be much better to have this interval configurable per repository.

After deleting the old action logs, the spinners don't stop and there are no messages to indicate the log no longer exists.

After deleting the old action logs, the spinners don't stop and there are no messages to indicate the log no longer exists.

Append to me as well when the runner dies because it could not download an action.
So the wheels keep spinning forever

After deleting the old action logs, the spinners don't stop and there are no messages to indicate the log no longer exists.

@bilogic How do you clear the old action logs? Just remove them from disk/storage? If so, I would say it's safe to do that to free up space. However, the old jobs cannot be displayed properly on the UI since there's no code for the inconsistency.

@wolfogre Yes, I just removed from storage, but that was because I had a backup. And yes, my image was to illustrate the need to report an error if the logs are deleted.


Use string.IsNullOrEmpty instead of string.IsNullOrWhitespace

Fixes #3593

There are two other places which use string.IsNullOrWhitespace:

ModelBindingHelper.ConvertSimpleType. It's used as a check before we call into TypeConverter to convert strings to primitives. Passing in a whitespace string here causes an array out of bounds exception from the TypeConverter.
EnvironmentTagHelper which has tests for tabs and spaces.

:watch: for questions

:up: :date:

:shipit: w/ one corrected code comment


The selected dispatch contains malformed data.

I'm getting the message in the Ray tab, while analysing a fully ray-traced game (I'm the developer).
other than that, the other tabs all work fine and I can view my scene.
What could cause this?

Hi Batcholi,
Thankyou for your feedback concerning RRA. If possible, could you please attach a .rra file containing the issue you're seeing as we will investigate. The .rra file doesn't need to be a full game file; just something that highlights the issue you're seeing. As a side question, does your application use ExecuteIndirect or vkCmdDispatchIndirect?

https://drive.google.com/file/d/1NbXfl7-ApPj7EGspidfx5cFwz8wCc0pV/view?usp=sharing


New merge tool and new JEDI build

Description

Update to new version of JEDI code
Use bespoke tool for merging the IODA files.

I don't have any comment about these updates, but I have a question:  Are the geoval files produced here identical to geoval files made from GSI outputs?  It is great if they are. We have to be careful is they are not.

I don't have any comments about these updates, but I have a question: Are the geoval files produced here identical to geoval files made from GSI outputs? It is great if they are. We have to be careful is they are not.

@gmao-jjin3 the intention is not to use these GeoVaLs for running tests in UFO. More just to make comparison plots against the GSI GeoVaLs to make sure the values look similar.


Site typo

Wasn't sure where to add it, hope it's ok.
https://logger.rocketjob.io/rails.html
at Log file name and line number section:
...feature can be used in production, but use care since setting the level too low will slow down the application...
should be:
...feature can be used in production, but use with care since setting the level too low will slow down the application...
Also:
https://logger.rocketjob.io/api.html
A logger instance should be created for every class so that it’s log entries can be uniquely identified from logging entries from other classes.
A logger instance should be created for every class so that its log entries can be uniquely identified from logging entries from other classes.
Another one:
https://logger.rocketjob.io/filtering.html
Give Resque its own logger with the custom filter qpplied to reduce it's verbosity
Give Resque its own logger with the custom filter qpplied to reduce its verbosity

Thank you for the documentation fixes, they have been applied.


Add DSL element for option aliases

e.g. for depends_on "gettext" => :optional we might want to alias that so users can use --with-gettext or --with-nls.
Migrated from https://github.com/Homebrew/legacy-homebrew/issues/41515

Passing on this.


Crash With "Not Enough Animations"

Not Enough Animations Versions:

NotEnoughAnimations 1.1.0
TRansliterationLib 1.0.2

Medieval Weapons Versions:

Medieval Weapons 1.0.7

crash-2021-02-27_17.03.20-server.txt

does this happen if you have medieval weapons and notenoughanimations installed only?

does this happen if you have medieval weapons and notenoughanimations installed only?

I tested with this both mods and its requirements:

fabric-api-0.31.0+1.16
medievalweapons-1.0.7
notenoughanimations-1.1.0
TRansliterationLib-1.0.2

and got this crash report: MultiMC Log

medievalweapons-1.0.8-test.zip
Please test this out (You have to unzip the file)


[5.2] Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

:)

:heart_eyes:


Feature/item design shopping list

I have changed the design of the shopping list recycler view item. Below is the screenshot of the new design :

Well Done @ShahanasParapporu!


helm rollback unsuccessful with service account

Description:
We had a helm chart installed which didn't have service account created.
We later did a helm upgrade of the chart with service account included.
When we did a helm rollback of the chart to original revision (which didn't have service account), pods are in crashLoopBackoff trying to mount the service account token which was deleted during rollback.
Steps to reproduce:

Install helm chart version 0.1.0 from attachment. This chart version doesn't have service account. Verify that pods are in running state.
Perform helm upgrade with chart version 0.1.4 from attachment. This chart version brings in service account "hello-world-sa". Verify that pods are in running state.
Perform a helm rollback to previous version.
After step 3, the new pod created goes to crashLoopBackoff state with error "FailedMount  111s (x70 over 128m)  kubelet, minikube  MountVolume.SetUp failed for volume "hello-world-sa-token-htdxc" : secret "hello-world-sa-token-xxxxx" not found
"

helm_rollback_issue_with_sa.zip
Output of helm version:
[root@e2ecr2 hello-world]# helm version
Client: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}
Output of kubectl version:
[root@e2ecr2 hello-world]# kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:11:31Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-08T17:02:58Z", GoVersion:"go1.12.1", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Minikube

Are we doing something wrong in our chart due to which helm is still keeping reference to service account in deployment even after rollback? Any help would be appreciated.

Seems to be a result of https://github.com/helm/helm/issues/7159. Closing in favour of that ticket. Thanks.

Are we doing something wrong in our chart due to which helm is still keeping reference to service account in deployment even after rollback? Any help would be appreciated.

hey,I have the same isuse, do  #7159 resolve our issue?


allow cache and force refresh on table list

This is a follow-up PR for https://github.com/apache/incubator-superset/pull/5933

Added table_cache_timeout settings to metadata_cache_timeout in database configuration. If table_cache_timeout is unset in the field, cache will not be enabled for the metadata fetch of this database. If it is set to 0, cache will never time out.
Added a button to sqllab UI which allows user to refetch table list metadata, or force refresh cache if cache is enabled.

Codecov Report

Merging #6078 into master will decrease coverage by 0.05%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master   #6078      +/-   ##
=========================================
- Coverage   77.56%   77.5%   -0.06%
=========================================
  Files          47      47
  Lines        9484    9505      +21
=========================================
+ Hits         7356    7367      +11
- Misses       2128    2138      +10

Impacted Files
Coverage Δ

superset/models/core.py
84% <0%> (-1.1%)
:arrow_down:

superset/views/core.py
74.18% <75%> (-0.02%)
:arrow_down:

superset/db_engine_specs.py
56.35% <90%> (+0.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e37b83a...fa77a1b. Read the comment docs.

Please take a look @betodealmeida


Connecting to FE and node template on different machines

Those using VMs and containers locally to manage nodes will need to use the following:
Node host machine
# find your local IP
ip a
# note the IP, as we need it for the FE next.
# start the node on any LAN connected machine
./target/release/node-template --dev --tmp --unsafe-rpc-external --unsafe-ws-external
# take note of the "listening for connection on..." section, should be <IP_ADDRESS>:<ws port, likely 9944>

FE host machine
# edit the web socket the FE template wants to use:
nano  substrate-front-end-template/src/config/development.json

you will set this to:
{
  "PROVIDER_SOCKET": "ws://<ip of your node>:<ws port, likely 9944>"
}

Then start the FE
# start the FE template on any LAN connected machine
yarn start
# take note of the IP and port on your local network the interface is viewable at:
#   Local:            http://localhost:8000/substrate-front-end-template
#   On Your Network:  http://<ip of your FE template host>:8000/substrate-front-end-template

This should now work as expected for a LAN. for testing only! unsafe to use this in production.
Next steps would be to try the private/multi-node network tutorial to connect multiple nodes on the LAN this way. Possibly with a demo using containers.

I volunteer for working on this. I've spent few unnecessary hours researching how to host chain/frontend on the server and connect via browser from the other machine. I will help others avoid it in the future

@kwikiel awesome! Let me know how I can assist it at all 🙏🏼

https://github.com/substrate-developer-hub/substrate-docs/issues/173


force upgrade pygments

An outdated version of pygments caused our build to fail.

Codecov Report

Merging #471 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
- Coverage   74.59%   74.51%   -0.08%
==========================================
  Files          54       54
  Lines        3948     3952       +4
==========================================
  Hits         2945     2945
- Misses       1003     1007       +4

Impacted Files
Coverage Δ

flax/jax_utils.py
59.43% <0.00%> (-2.34%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 604112f...a98d85d. Read the comment docs.


Include cancelled newsletters

What does this change?

Includes cancelled newsletters in the data to be uploaded to S3

How to test

Are cancelled newsletters included?

Converting to draft until https://github.com/guardian/identity/pull/2132 is merged


Use proper case to prevent Don't Call PropTypes warning

https://github.com/facebook/react/pull/7132

Coverage remained the same at 100.0% when pulling 19879aa255bdc26b574355c74f29dac200dc9c39 on jsarman:master into 2252f6f149d0b8d28561053608cc07a3e5ab10d4 on reactstrap:master.

Sorry that test fixed my issue was wasnt proper it should be lower case.

https://facebook.github.io/react/warnings/dont-call-proptypes.html

The normal usage of PropTypes is still supported:

 Button.propTypes = {
   highlighted: React.PropTypes.bool
 };

Nothing changes here.


fixed broken links to classes

couldn't find out what the problem with svg_svg was

thanks @aseipelt 👍


On revolver play second video has pink progress bar.

Nexx version: 3.2.43
Steps:

Play 1 video
Wait for video to end and to start the second one.
Bug: second video has pink progress bar.


missing error_codes.pb.h

Hi, our code is trying to use tensorflow for inference only and includes tensorflow/cc/saved_model/loader.h to load models.
However, we got the following compilation error. your input is appreciated.
 #include "tensorflow/core/lib/core/error_codes.pb.h"```

Hi, please provide the compilation error and try the latest master branch that stands on TF 1.12.

Closing for inactivity. Feel free to reopen if the issue persists.

I've got the same issue. No problem building ./example with the static target, but can't build it with the shared lib, because of this. The file is indeed missing under /usr/local/include/tensorflow/tensorflow/core/lib/core.


Identical bundle names in different sessions highighted as if they were loaded

Preparation
You need a database with two bundles that have the same name but belong to different sessions (in the same session they cannot have the same name). You can use ae_emuDB from the emuRdemodata and do this:
mkdir 0001_ses
mv 0000_ses/msajc010_bndl 0001_ses/msajc003_bndl
cd 0001_ses/msajc003_bndl
rename 010 003 *

Steps to reproduce

Open that database in the emu webapp.
Select one of those bundles.
Unfold the other session.

Consequence
The second bundle is highlighted as if it were loaded. No new bundle is loaded, though, before you actually click it.
Remedy
Only highlight bundles whose bunde and session name match the one currently loaded.

This seems to have been fixed a while ago. Could not reproduce the problem any more so closing issue.


Duplicate assembly references of differing versions

My target assembly has a reference to mscorlib <IP_ADDRESS> which I believe is some subset of the Unity version of mscorlib.  I found a way to make my merging DLL to use that, but since MonoMod injects some types into the assembly, that assembly then gets a reference to the mscorlib used by MonoMod, which is mscorlib <IP_ADDRESS>.  This causes weird behavior in unity.  So I then have to open up the assembly in dnspy and save it in order to get it to remove that extra reference.
The types copied from a source assembly should have the reference to mscorlib changed to whatever the target assembly's version is.

Also, It should remove the reference to MonoMod.exe too. (since that reference is required to build)

The mscorlib issue can be solved by setting up the relink map in the PatchRefs pass.
Blindly removing the reference will break all other references due to how the tokens are referenced.
I never saw that as critical as it never caused issues on my end when working on XnaToFna, neither using the .NET Framework, nor using mono. It could be that Unity's outdated mono fork handles things differently, though.
I'll do it this weekend :)
Regarding the MonoMod reference: It shouldn't cause issues. Some mods use f.e. the runtime relinker and thus break when removing the MonoMod reference. You can Environment.SetEnvironmentVariable("MONOMOD_CLEANUP_ALL", "1"); in MonoModRules to get rid of the reference, though. It's the only thing affected by that environment variable at the moment.

The MonoMod reference won't be removed because MonoModWasHere holds a reference to it.
Yeah, everything compiles fine, and 99% of the game works, but sometimes it runs into places where it says it can't load the type.

MonoMod.WasHere itself shouldn't hold any reference to MonoMod - it's an empty type added to the assembly, accessible via reflection to check if it's been modded via MonoMod.
Maybe something went completely wrong with it while patching Hollow Knight, though :/ Could you please pastebin an IL dump of that type?
Regarding the type load failures: Could you please try catching the TypeLoadException and log it using this method? TypeName doesn't get displayed under some circumstances.

    public static void LogDetailed(this Exception e, string tag = null) {
        for (Exception e_ = e; e_ != null; e_ = e_.InnerException) {
            Console.WriteLine(e_.GetType().FullName + ": " + e_.Message + "\n" + e_.StackTrace);
            if (e_ is ReflectionTypeLoadException) {
                ReflectionTypeLoadException rtle = (ReflectionTypeLoadException) e_;
                for (int i = 0; i < rtle.Types.Length; i++) {
                    Console.WriteLine("ReflectionTypeLoadException.Types[" + i + "]: " + rtle.Types[i]);
                }
                for (int i = 0; i < rtle.LoaderExceptions.Length; i++) {
                    LogDetailed(rtle.LoaderExceptions[i], tag + (tag == null ? "" : ", ") + "rtle:" + i);
                }
            }
            if (e_ is TypeLoadException) {
                Console.WriteLine("TypeLoadException.TypeName: " + ((TypeLoadException) e_).TypeName);
            }
            if (e_ is BadImageFormatException) {
                Console.WriteLine("BadImageFormatException.FileName: " + ((BadImageFormatException) e_).FileName);
            }
        }
    }

The error happens in the game, not in monomod.  My guess is that it's some basic type that for some reason it's looking at <IP_ADDRESS> mscorlib for, except that doesn't exist in the version of unity that the game uses.  (which explains why opening the assembly with dnspy, deleting out monomod and saving and the reference to mscorlib <IP_ADDRESS> goes away).
Here's part of the issue:
.assembly extern mscorlib as mscorlib_9
{
  .publickeytoken = (B7 7A 5C 56 19 34 E0 89 )                         // .z\V.4..
  .ver 2:0:0:0
}
.assembly extern MonoMod
{
  .ver 17:4:6530:30093
}```

and the rest

https://gist.github.com/iamwyza/127fb41ffd707dced28d8d26507c3911

I've created a new branch that should fix the issue. I can't test it right now, though, so I depend on your test results.
https://github.com/0x0ade/MonoMod/tree/fix-multicorlib
If it works, please tell me so I can merge it into the master branch :)

I'll test it out this evening and let you know how it goes.


ProjectInfo miss toString()

ProjectInfo miss toString() method

Thank you for pointing this out.
Classes in the src/main/java/com/google/gerrit/ folder are taken directly from the official Gerrit source code.
I checked their master branch and the ProjectInfo class (here) does not contain a toString() method there as well
Since the ProjectInfo class in this project has to be the same as the one in the official Gerrit release, maybe you could open this issue in Gerrit.
If they decide to modify the class in their code, we will adopt the change here too.

@EFregnan: Thanks for your feedback - fully agree.
@magaofei Thanks for reporting, but please open this report upstream: https://www.gerritcodereview.com/issues.html


Code Quality: Convert local variable or field into constant

Description
Some places in the codebase have useless variables or fields that can be converted to constants.
Concerned code
Using R# to generate the analysis:
Found usages (31 issues)
<src>\<core> (1 issue)
	<src>\<core>\<Files.Core> (1 issue)
		<src>\<core>\<Files.Core>\Helpers (1 issue)
			<src>\<core>\<Files.Core>\Helpers\NativeFindStorageItemHelper.cs (1 issue)
				Convert into constant (0 issues)
<src>\<platforms> (30 issues)
	<src>\<platforms>\<Files.App> (30 issues)
		<src>\<platforms>\<Files.App>\Views\Layouts (1 issue)
			<src>\<platforms>\<Files.App>\Views\Layouts\BaseLayoutPage.cs (1 issue)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\ViewModels\Properties\Items (6 issues)
			<src>\<platforms>\<Files.App>\ViewModels\Properties\Items\DriveProperties.cs (3 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)
			<src>\<platforms>\<Files.App>\ViewModels\Properties\Items\BaseProperties.cs (3 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Utils\Storage\StorageItems (1 issue)
			<src>\<platforms>\<Files.App>\Utils\Storage\StorageItems\VirtualStorageItem.cs (1 issue)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Utils\Storage\Operations (1 issue)
			<src>\<platforms>\<Files.App>\Utils\Storage\Operations\FilesystemHelpers.cs (1 issue)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Utils\Storage\History (2 issues)
			<src>\<platforms>\<Files.App>\Utils\Storage\History\StorageHistoryOperations.cs (2 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Utils\Storage\Helpers (1 issue)
			<src>\<platforms>\<Files.App>\Utils\Storage\Helpers\FileSecurityHelpers.cs (1 issue)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Utils\Storage\Enumerators (2 issues)
			<src>\<platforms>\<Files.App>\Utils\Storage\Enumerators\Win32StorageEnumerator.cs (1 issue)
				Convert into constant (0 issues)
			<src>\<platforms>\<Files.App>\Utils\Storage\Enumerators\UniversalStorageEnumerator.cs (1 issue)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Utils\Shell (1 issue)
			<src>\<platforms>\<Files.App>\Utils\Shell\PreviewHandler.cs (1 issue)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Utils\RecentItem (1 issue)
			<src>\<platforms>\<Files.App>\Utils\RecentItem\RecentItems.cs (1 issue)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Services (2 issues)
			<src>\<platforms>\<Files.App>\Services\WindowsCompatibilityService.cs (1 issue)
				Convert into constant (0 issues)
			<src>\<platforms>\<Files.App>\Services\RemovableDrivesService.cs (1 issue)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Helpers\Win32 (2 issues)
			<src>\<platforms>\<Files.App>\Helpers\Win32\Win32Helper.Storage.cs (2 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Helpers\Environment (3 issues)
			<src>\<platforms>\<Files.App>\Helpers\Environment\SoftwareHelpers.cs (3 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Data\Models (3 issues)
			<src>\<platforms>\<Files.App>\Data\Models\ItemViewModel.cs (3 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Views (1 issue)
			<src>\<platforms>\<Files.App>\Views\PaneHolderPage.xaml.cs (1 issue)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Helpers (1 issue)
			<src>\<platforms>\<Files.App>\Helpers\NaturalStringComparer.cs (1 issue)
				Convert into constant (0 issues)
		<src>\<platforms>\<Files.App>\Helpers\WMI (2 issues)
			<src>\<platforms>\<Files.App>\Helpers\WMI\ManagementEventWatcher.cs (2 issues)
				Convert into constant (0 issues)
				Convert into constant (0 issues)

Gains

Better readability (knowing the data will never change)
Less memory usage

Requirements

Running R# to generate the report of variables and fields that can be converted
Applying the change file by file

Comments
Another case of "peanut butter", a change that individually aren’t hugely meaningful but that over time add up to bigger impact.

Looks good. If we do this, variable naming should also be changed? Can you provide a code snippet?

Looks good. If we do this, variable naming should also be changed? Can you provide a code snippet?

When applied to a variable the naming will not change:
		string cDrivePath = @"C:\";

to
		const string cDrivePath = @"C:\";

at RemovableDrivesService.cs
When applied to a field the naming will need to change, some places use THIS_NAMING and others thisNaming. Rider can also apply a naming convention automatically to all constants in the solution.
Example:
		public static readonly Int32 SORT_DIGITSASNUMBERS = 0x00000008;

to
public static readonly Int32 SORT_DIGITSASNUMBERS = 0x00000008;

at SafeNativeMethods.cs

Looks great. @yaira2 asking for approval.

It would be great to have some benchmarks. If we decide to move forward with this, it would be best to split the changes into multiple PRs to ensure they are properly tested.

This main purpose is not to improve performance but to reduce a chance to be changed accidentally.

Let’s do this, as always, it might help for the review process as well as future reference to split this into a few PRs.

About the naming of constants, is inconsistent across the solution, but in a single click we can fix it. Is a MR for this appropriate?

I don't really see benefit of using const in local methods and I haven't really seen this pattern used in other projects.

About the naming of constants, is inconsistent across the solution, but in a single click we can fix it. Is a MR for this appropriate?

It probably depends on the context

I don't really see benefit of using const in local methods and I haven't really seen this pattern used in other projects.

Very very small peanut butter performance improvement, because the const variable is inlined by the compiler,

using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Configs;
using BenchmarkDotNet.Mathematics;
using BenchmarkDotNet.Order;
using BenchmarkDotNet.Running;

[RankColumn(NumeralSystem.Stars)]
[MemoryDiagnoser]
public class ConstVsNonConstBenchmark
{
    [Benchmark]
    public void ConstVariable()
    {
        const string secretPath = @"C:\Example.txt";
        for (var i = 0; i < 10000; i++)
        {
            if(File.Exists(secretPath))
                File.ReadAllText(secretPath);
        }
    }
    [Benchmark]
    public void NonConstVariable()
    {
        string secretPath = @"C:\Example.txt";
        for (var i = 0; i < 10000; i++)
        {
            if(File.Exists(secretPath))
                File.ReadAllText(secretPath);
        }
    }
}

class Program
{
    static void Main(string[] args)
    {
        var config = DefaultConfig.Instance
            .WithOrderer(new DefaultOrderer(SummaryOrderPolicy.FastestToSlowest));

        var summary = BenchmarkRunner.Run<ConstVsNonConstBenchmark>(config);
    }
}

Not worth the effort, feel free to re-open if someone want to work.


[SPARK-14242][CORE][Network] avoid copy in compositeBuffer for frame decoder

What changes were proposed in this pull request?
In this patch, we set the initial maxNumComponents to Integer.MAX_VALUE instead of the default size ( which is 16) when allocating compositeBuffer in TransportFrameDecoder because compositeBuffer will introduce too many memory copies underlying if compositeBuffer is with default maxNumComponents when the frame size is large (which result in many transport messages). For details, please refer to SPARK-14242.
How was this patch tested?
spark unit tests and manual tests.
For manual tests, we can reproduce the performance issue with following code:
sc.parallelize(Array(1,2,3),3).mapPartitions(a=>Array(new Array[Double](1024 * 1024 * 50)).iterator).reduce((a,b)=> a).length
It's easy to see the performance gain, both from the running time and CPU usage.

Test build #54441 has started for PR 12038 at commit 8908585.

Test build #54441 has finished for PR 12038 at commit 8908585.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54441/
Test PASSed.

@vanzin , I think @zsxwing 's idea of using CompositeByteBuf.addComponents is a better choice, which will only introduce exactly one copy if the small buffer number is lager than 16 and will not introduce any copy if that less than 16. Let me update this PR first.

Test build #54492 has started for PR 12038 at commit 1eacf55.

Test build #54492 has finished for PR 12038 at commit 1eacf55.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54492/
Test PASSed.

will only introduce exactly one copy if the small buffer number is lager than 16

That's better, but is it needed at all? I don't see any comments about why consolidating the buffers is a win in the source for CompositeByteBuf. Traversing the single buffer should be slightly faster because there's less bookkeeping, but there's the cost of copying that data in the first place.
When testing this code, I remember that during large transfers packets would arrive in 64k chunks at the most, so that means that once you're transferring more than 1MB, you'd have to copy things.
Have you tried not consolidating to see whether there's any negative side-effect?

@vanzin

That's better, but is it needed at all? I don't see any comments about why consolidating the buffers is a win in the source for CompositeByteBuf. Traversing the single buffer should be slightly faster because there's less bookkeeping, but there's the cost of copying that data in the first place.

If so we can just set the maxNumComponents with Integer.Max_VALUE for compositeByteBuffer.

When testing this code, I remember that during large transfers packets would arrive in 64k chunks at the most, so that means that once you're transferring more than 1MB, you'd have to copy things.

In my test, the chunk sizes are mainly around 20~30 KB.

Have you tried not consolidating to see whether there's any negative side-effect?

I tested previously with buffers.getFirst().alloc().compositeBuffer(Integer.MAX_VALUE);, and with frame size over 1GB, which consist of about 40000 chunks, I didn't see negative side-effect.
Ok, let's solve this issue without copy for any case.

Test build #54578 has started for PR 12038 at commit 80f7573.

Test build #54578 has finished for PR 12038 at commit 80f7573.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54578/
Test FAILed.

retest this please.

Test build #54580 has started for PR 12038 at commit 80f7573.

Test build #54580 has finished for PR 12038 at commit 80f7573.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54580/
Test PASSed.

@liyezhang556520 looks great but could you update the commit message to reflect the actual change? Thanks

LGTM @liyezhang556520 please ping me when you update the PR description.

@zsxwing , I updated the commit description. Thank you @zsxwing and @vanzin for reviewing.

Merging to master. Thanks, @liyezhang556520 !

cherry-picked into 1.6 branch

@davies has this pr cherry-picked into branch-1.6?

Yes

@davies , but I didn't find this commit in branch-1.6.

@davies , I didn't see the commit in branch-1.6 either, seems this commit can not be simply git cherry-pick because the file path is not the same in master and branch-1.6. Do I need to submit another PR for back-port?


Create ta.js

Tamil lanuguage

This appears to change en to have tamil decodes - I think inside the file you needed to set the language to ta?  That in turn means it breaks the unit tests.
When you fix, could you please squash the commit again into a single commit?

@jeraldfdo Any change you could check out Paul's comment?

Closed by #4120


Merge pull request #1 from shreya2902/ShreyaDevelopment

Added a messages.html file with a text box for the user to input a message, and implemented the Google Maps library to display a map with a marker on it

Hey Shreya, seems like the changes are missing here. Shows files changed 0.