[BEAM-2718] Improve performance of bundle retry

In order to keep a consistent state while handling bundles, very time the state is accessed, a copy is made and kept until the bundle is committed. Here a custom copy is used replicating only the inner structures that are needed and shallow-copying the rest.

Coverage increased (+0.007%) to 69.691% when pulling eba397bbe42c05d33d09489b88dfaf55786fdd79 on mariapython:retry_custom into 6dfd3a2b7d748bff049a34ea39cb5e2a0c45dba0 on apache:master.

Coverage increased (+0.003%) to 69.693% when pulling 8650ea65963f8e3efc5555d8b3aa5474292efd20 on mariapython:retry_custom into df1476d82c05084aa82d1b74593d630a17156599 on apache:master.

R: @charlesccychen

Coverage decreased (-0.01%) to 69.493% when pulling 3f1a714b613353fdfe62e46e63c7bbfa47d98295 on mariapython:retry_custom into 50532f0a92d7ce8dbbdc6c3179ab7b9efde6a746 on apache:master.

Coverage decreased (-0.01%) to 69.496% when pulling 585d8f9de815c3cd65689f06a4abefd0dc10540d on mariapython:retry_custom into 307b03680ba8b6278d80a07b1ce73421804aa994 on apache:master.


bug: the "-" in the dependency name is replaced with "_" in entries.

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)

When a tripartite dependency name contains hyphens -, the entries will only take effect if the hyphens - are replaced with underscores _.
[package]
name = "dev"
edition = "v0.10.0"
version = "0.0.1"

[dependencies]
my-dev = { path = "../../my-dev" } # hyphens in the name

[profile]
entries = ["../base/base.k", "main.k", "${my_dev:KCL_MOD}/base/base.k"] # replace it into underscores

2. What did you expect to see? (Required)
[package]
name = "dev"
edition = "v0.10.0"
version = "0.0.1"

[dependencies]
my-dev = { path = "../../my-dev" }

[profile]
entries = ["../base/base.k", "main.k", "${my-dev:KCL_MOD}/base/base.k"] # the same as the dependency name

3. What did you see instead (Required)
When a tripartite dependency name contains hyphens -, the entries will only take effect if the hyphens - are replaced with underscores _.
4. What is your KCL components version? (Required)
The main branch of kpm

can i work on this @zong-zhe ?


On failed takeItem, re-set item id instead of item object

When trick, switcheroo, and bestow fail, their items are put back on the pokemon
they came from. However, the item object itself was being set, rather than its
id (as is done in thief).
This is causing request messages to be sent from server to client containing an extra object in the item field, instead of a string as expected.
For example (note Furret's item):
>battle-randombattle-47
|request|{"active":[{"moves":[{"move":"Trick","id":"trick","pp":15,"maxpp":16,"target":"normal","disabled":false},{"move":"Aqua Tail","id":"aquatail","pp":16,"maxpp":16,"target":"normal","disabled":true},{"move":"Knock Off","id":"knockoff","pp":32,"maxpp":32,"target":"normal","disabled":true},{"move":"Double-Edge","id":"doubleedge","pp":24,"maxpp":24,"target":"normal","disabled":true}]}],"side":{"name":"0raichu","id":"p1","pokemon":[{"ident":"p1: Furret","details":"Furret, L83, F","condition":"199/277","active":true,"stats":{"atk":174,"def":154,"spa":122,"spd":139,"spe":197},"moves":["trick","aquatail","knockoff","doubleedge"],"baseAbility":"frisk","item":{"id":"choicescarf","name":"Choice Scarf","spritenum":69,"fling":{"basePower":10},"isChoice":true,"num":287,"gen":4,"desc":"Holder's Speed is 1.5x, but it can only select the first move it executes.","cached":true,"exists":true,"fullname":"item: Choice Scarf","category":"Effect","effectType":"Item"},"pokeball":"pokeball"},{"ident":"p1: Azelf","details":"Azelf, L77","condition":"242/242","active":false,"stats":{"atk":197,"def":152,"spa":237,"spd":152,"spe":222},"moves":["nastyplot","dazzlinggleam","taunt","psyshock"],"baseAbility":"levitate","item":"leftovers","pokeball":"pokeball"},{"ident":"p1: Tyrantrum","details":"Tyrantrum, L79, M","condition":"0 fnt","active":false,"stats":{"atk":237,"def":234,"spa":155,"spd":139,"spe":158},"moves":["earthquake","outrage","stealthrock","superpower"],"baseAbility":"strongjaw","item":"lifeorb","pokeball":"pokeball"},{"ident":"p1: Gligar","details":"Gligar, L77, M","condition":"182/227","active":false,"stats":{"atk":160,"def":206,"spa":98,"spd":145,"spe":175},"moves":["uturn","toxic","defog","earthquake"],"baseAbility":"immunity","item":"eviolite","pokeball":"pokeball"},{"ident":"p1: Machamp","details":"Machamp, L77, F","condition":"265/265","active":false,"stats":{"atk":245,"def":168,"spa":145,"spd":175,"spe":129},"moves":["icepunch","stoneedge","knockoff","dynamicpunch"],"baseAbility":"noguard","item":"choiceband","pokeball":"pokeball"},{"ident":"p1: Pidgeot","details":"Pidgeot, L76, F","condition":"251/251","active":false,"stats":{"atk":166,"def":158,"spa":150,"spd":150,"spe":198},"moves":["uturn","heatwave","roost","hurricane"],"baseAbility":"tangledfeet","item":"pidgeotite","pokeball":"pokeball"}]},"rqid":15}

Nice catch!

This is why we need TypeScript...


addresses_to_register config field should be plain string instead of Address

This enforces users to provide full URL and is conflicting with A/CNAME records of the DNS. DNS' A and CNAME records are just for name resolving thus a node connecting to another peer should be the decider for which interface should be accessed by default after name resolution (or should query for an URI record).
Related with #2972

Duplicate of https://github.com/bosagora/agora/issues/2320 ?

Duplicate of #2320 ?

Kinda, I feel explanation of that issue still directs me to provide full URL during registration (using interface fields) but prevent duplication by moving configuration field under interfaces. I think we shouldn't force users to provide full URL for registration.

Let's move the discussion there then.


ImportError: No module named models.embedding

I ran the train_test8.sh and the following message popped up:
Traceback (most recent call last):   File "word2gm_trainer.py", line 27, in <module>     from tensorflow.models.embedding import gen_word2vec as word2vec ImportError: No module named models.embedding
Apparently it's related to the compilation of tutorials from the tensorflow models repo. So I have tried recompiling  tensorflow from sources with the models in it, but in vain.
Any thoughts about this please ?

What version of Tensorflow are you using?

I am using the master version, the most recent.

This repo requires Tensorflow 0.11 or 0.12. It's not compatible with Tensorflow version 1.0 or 1.1 where they have removed the models.embedding module.

Thank you. I will try with that.


Row Labels

I have three row labels that are being centered on the left side panel.  I would like them to be on the top of the screen.  Since my Pivot Table is long, they appear all the way down in the middle.
Love this JS.
Thank You!

Glad you like it! This is something you'll have to do by overriding the CSS.

Wow that was a quick response.
I tried that, but was only successful with the first one, since the classes for the other two are the same.

I'm not sure I follow... can you give me an example of what you tried and why it didn't work?

What browser are you using? In Chrome on the examples site (e.g. https://pivottable.js.org/examples/rcsvs.html) for me right now on the examples the attributes in the left area are always all at the top...

Using FireFox 52.7.2 (32-bit

same issue in IE 11

Got it.  Had to do with a previous css sheet that was affecting the way td's were being positioned.
Thanks for all your time and effort.

👍


libkb: fixes for revoked subkeys

import properly and make sure we don't sign with revoked keys

r? @oconnor663
Just a merge of keybase/go-crypto#15

Looks good, just the questions above.


Golden tests running with impeller like impeller_Play_AiksTest_CanRenderSweepGradientManyColorsRepeat_Metal are flaky

I'm surprised this iOS embedder memory leak fix kicked off a flutter gold check, and even more surprised it caused Golden file changes have been found for this pull request.
https://github.com/flutter/engine/pull/40957

The unexpected flutter gold check is still pending and blocking the PR: https://github.com/flutter/engine/pull/40957

@Piinks Could you help take a look?

I believe the image is flaky, I filed https://github.com/flutter/flutter/issues/124277
@mdebbar maintains the engine instance of Gold.

I took a look at the failing goldens: https://flutter-engine-gold.skia.org/search?crs=github&issue=40957&negative=true&patchsets=1&positive=true
They fall in 2 buckets:

Images with tiny differences from their golden baseline (e.g. this: new pixel is #C42AA3 vs baseline pixel #C426A3. This is correctly auto-approved by fuzzy.
Images with a pixel that's drastically different from the baseline (e.g. this: new pixel is #FFDBAF vs baseline pixel #6200A2). Look at the highlighted pixel in the center:

New
Baseline

Unfortunately, Gold's fuzzy matching doesn't handle this case well.
That said, this feels like a flakiness in impeller that needs to be addressed. The specific pixel sometimes gets painted yellow, and sometimes purple.

From Triage: We discussed this w.r.t what to do with gold tests that run on results obtained from a specific GPU. We are not going to guarantee pixel perfect results across GPUs (even from a specific vendor). Based on guidance from the Skia GPU team, the amelioration was that the Gold failures be reasoned about out-of-band and neither the autorollers or the presubmit checks block PRs. I believe this has been done already. You should not see a red check mark on your presubmits and the autorollers should not care about this difference. The delta will still be triaged as I said, but out of bank.

and blocking the PR.

Did you see the gold failures trigger a red check or was it in the pending state? Also, was the autosubmit/autoroller refusing to process this?
Dan (OOO) also had WIP where gold would instances would only use a specific GPU type. But I am not sure that work was done. In any case, this shouldn't block PRs.
cc @gaaclarke.

Dan (OOO) also had WIP where gold would instances would only use a specific GPU type. But I am not sure that work was done.

Would it be easier to specify the GPU as a parameter for the golden file image? Gold supports thousands of params for image tests, we could just have separate images for each GPU by adding the GPU as a key of the image.

These are the current params I can see we differentiate images for in the engine instance:

@Piinks Here is what dan's PR is doing: https://github.com/flutter/engine/pull/41216/files#diff-356abf8d8d08b3ba08c35d6399e2a21d3107aa16c55f4303bb3b8f96195bbcc0R239
The code looks good, but I'm not sure if that's going to give us the result we want in skia gold (it sounds like it?)

Oh nice, that looks like exactly that, although slightly different, I'll leave mention on the PR. :+1:

This is WAI.  The ameliorations for different GPU returning different results were that the golden runs were being checked out of band, a global conservative fuzz factor applied to gold checks, and the restriction of devices that can perform these gold checks (most notably removing the Intel Iris devices).


Fix issue building memory_stats with opencl

This PR fixes #15477
This bug exists in at least 1.4, 1.5 and master branch, should I send PR for every branch?

Can one of the admins verify this patch?

@tensorflow-jenkins test this please


hideCurrent option doesn't work

Hello again!
Thanks for the great plugin. I've found an issue with version 3.8.2, specifically with the hideCurrent option. It doesn't work correctly on the official example, so I'm confident this isn't an artifact of my implementation.
I think I've found the culprit, starting on line 1563:
if(self.options.hideCurrent) {
    activeElem.hide().promise().done(function () {
        self.listItems.show();
    });
}

After activeElem is hidden, the Promise returns and all of the listItems (including activeElem) are shown. This renders the hideCurrent option inoperative.
One way to fix this issue is to simply compare each list item against activeElem, and only show the item if they are not equal.
if (self.options.hideCurrent) {
    activeElem.hide().promise().done(function () {
        self.listItems.each(function() {
            if (!$(this).is(activeElem)) {
                $(this).show();
            }
        });
    });
}

Hope this helps!

+1

Yep still not working


Remove adaptive pixel sampler

Now that we have an adaptive tile sampler, there is very little reason to use or maintain the adaptive pixel sampler.

Indeed. Make sure to include a project migration step to either the Adaptive Tile Renderer if that sounds feasible, or more like to the Uniform Pixel Renderer, with a warning message that the project conversion had to make this simplification.

Done.


Change ES6 import in README

I would propose to change the es6 import as done in this PR. It practically works exactly the same then, except for one crucial difference: If imported this way the references will be updated when changing the log level using setLevel at runtime. It took me some time to realize that the way the methods have been imported were the issue. Using * seems to be resulting in a separate reference, which doesn't care about the replaceLoggingMethods method.

I think this is something that depends a lot on the environment in your project.
In my experience, I've usually seen ES2015 modules used with a compiler that simply used the CommonJS/AMD output of the module as the full module object. That means import log from 'loglevel' is equivalent to var log = require('loglevel').log in CommonJS land, and that's code that doesn't work (there's no such property), so I'm pretty surprised it's working for you.
The current code (import * as log from 'loglevel') should typically be equivalent to var log = require('loglevel'), which is correct. This was reported by a bunch of Vue users, who all seemed to need this form: https://github.com/pimterry/loglevel/issues/100
There's obviously other ways to handle this though, and I'm not enormously well-versed all in the many ways you can use ES2015 modules in practice. Can you give me some more detail on how you're building your project?

Since it is also an open source project I can share it with you: https://github.com/sulu/sulu-minimal/blob/develop/webpack.config.js
Basically we are using webpack in combination with babel.

import log from 'loglevel' should import the default export

Doh, yes, of course: I was thinking of import { log } ....
This module doesn't have a default export of course though - there's no .default property on the result at all. It looks like that's a Babel-specific solution to this (http://2ality.com/2015/12/babel-commonjs.html#how-babel-imports-commonjs-modules) (where .default instead imports the whole object). It's certainly different to however the originating Vue developers' compilation worked though, and how I've seen it work in ES2015 module implementations elsewhere (TypeScript definitely doesn't do this, for example).
As far as I can tell there isn't really an officially 'right' answer to this yet, because Node hasn't settled on exactly how its internal commonjs to ES2015 mapping is going to work either. I'd be happy to accept a change that included your version here as an alternative though somehow, e.g. 'for babel commonjs module compilation, ...' and 'for some other ES2015 module implementations, including TypeScript, ...'
I'm still a bit confused by your initial comment: 'if imported this way the references will be updated when changing the log level using setLevel at runtime'. The exported log object that import * as log ... imports never gets changed, it's just its properties that change, but that should be fine. Any chance you were using import { error, warn, ... } from 'loglevel'? That would definitely break as you describe.

I do think we need to add some more clarification on this ES6 usage. Like the React community is heavily utilizing ES6 and Babel, and they will be going to look at this docs as well. But when they do import * as log from 'loglevel', what happens is that there is two log objects ("log" and "log.default") are actually being created (refer to http://2ality.com/2015/12/babel-commonjs.html). While "log.default" is original object, if we do log.setLevel, "log.default" will be updated properly, but "log" will stay unchanged.

@pimterry The properties actually don't change (as also @killercentury described), that's the exact problem :-)

Just to reiterate my comment above: while I don't think this current update is ok, as it won't work for everybody, I'm very open to a similar change to fix this, if somebody wants to do some research/testing and come up with a more general version, and a broad outline of who the different forms are relevant to. E.g. 'for babel commonjs module compilation, ...' and 'for some other ES2015 module implementations, including TypeScript, ...'


-OptionalPackagePath parameter is not documented.

Hi!
We recently had some challenges with installing MSIX modification packages using the command line. During our search we found a solution using -OptionalPackagePath
e.g.
Add-AppProvisionedPackage -Online -OptionalPackagePath \\share\modificationpackage.msix -PackagePath \\share\mainpackage.msix -SkipLicense
However, we found that the -OptionalPackagePath is not documented while I believe it is useful to have this parameter documented
regards
Martin

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 84aaef21-a63f-d502-80ff-7732f5456450
Version Independent ID: f077a336-dd7b-bcc5-a95c-451b3c9dd0d2
Content: Add-AppxProvisionedPackage (DISM)
Content Source: docset/winserver2019-ps/dism/Add-AppxProvisionedPackage.md
Product: w10
Technology: windows
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

@JasonGerend  Sir, In this article  Offline title and Online  title, are not visible to the public.  So this article, format must be adjusted soon.

@09mb Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/windows-powershell-docs/pull/2932
Thanks
Sri


[HOLD for payment 2024-04-03] [$500] Scan - Inconsistency of flashlight/torch behavior in Scan tab

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.24-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Prerequisite: Camera use permission is accepted previously
Android App

Login to android Expensify App
Tap FAB button
Tap Request money
Tap on flashlight icon to enable (verify nothing happens)
Tap on green circle to take a shoot with camera (verify photo is taken with flashlight is ON)
Mobile Web
Login to ND Expensify
Tap FAB button
Tap Request money
Tap on flashlight icon to enable (verify flashlight is ON)
Tap on flashlight icon to disable ((verify flashlight is OFF)

Expected Result:
Flashlight should function exactly same behaviour both mobile apps and mobile web
Flashlight icon should be shown in Scan tab within all devices
Actual Result:
Both Android and IOS apps works similarly; flashlight is only ON while taking a photo shoot
In Mobile Web, tapping on the flash icon turns the flashlight ON&OFF without camera taking a shoot
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ea8878e3-55fd-4930-a067-3e5fffbdce3f
https://github.com/Expensify/App/assets/78819774/765741f9-fa33-404c-b4e5-57c5419116f1
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017684a08e378933c3
Upwork Job ID:<PHONE_NUMBER>913547776
Last Price Increase: 2024-01-12
Automatic offers:

s77rt | Reviewer | 28108708
tienifr | Contributor | 28108709

Proposal
Please re-state the problem that we are trying to solve in this issue.
The torch for native only appears when taking a picture, but for mWeb, the torch shows immediately when turned on.
What is the root cause of that problem?
For native, the behavior is the flash is applied when taking the picture.
https://github.com/Expensify/App/blob/c8631be3c34cb7da835ff4db3ca1a8df7e19136f/src/pages/iou/request/step/IOURequestStepScan/index.native.js#L187-L190
But for web, we set up the torch like this:
https://github.com/Expensify/App/blob/c8631be3c34cb7da835ff4db3ca1a8df7e19136f/src/pages/iou/request/step/IOURequestStepScan/NavigationAwareCamera/index.js#L49-L57
What changes do you think we should make in order to solve the problem?

For native, the camera can receive a torch prop that we can set to true.
torch={flash && device.hasTorch}

@neonbhai Thanks for the proposal. I think we are looking to achieve the consistency here the other way around i.e. web should behave like native.

@bernhardoj Thanks for the proposal. Same note as above ^

@tienifr Thanks for the proposal. I agree on the RCA. Regarding the solution, can we improve this and use the track to construct ImageCapture. This Web API have a takePhoto method that supports fillLightMode to choose if flash should be enabled.
PS: I think it would be better if we ship this feature upstream to react-webcam

@neonbhai The mobile (native) behavior was implemented  first. Then support was added to web. I think it makes sense to match the web to the native. If you think the native design is incorrect please raise that to Slack (and tag me and the design team).

Raised this on Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1705368355349939 for more :eyes:

I think we should proceed here with @tienifr's proposal.
🎀 👀 🎀 C+ reviewed
Link to proposal

@tienifr still working on this

This is on hold for payment for another weekish so just clearing the overdue until then.

The PR that introduced the bug has been identified: https://github.com/Expensify/App/pull/28618
The offending PR has been commented on: https://github.com/Expensify/App/pull/28618#discussion_r1542148110
A discussion in #expensify-bugs has been started: Not needed (unique bug)
Determine if we should create a regression test for this bug: No, I don't think we need a test for this inconsistency

Looks like the automation didn't work here either. Handling payment stuff now.

All paid, closing!


chore: exclude services from docs

Related: https://github.com/badges/shields/pull/6677#discussion_r662700176
It was suggested to use a path like services/**/*.service.js, however I'm taking a different approach for 2 reasons:

I'm using excludePattern, as it appears to me exclude doesn't support wildcards. (More Info)
It checks for .js instead of .service.js because the example files in the comment didn't end with .service.js, and wouldn't have been excluded otherwise.

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @SethFalco!

  Generated by :no_entry_sign: dangerJS against d471907e99a3dc58d9fd215ee2bb479a460f2e06

it checks for .js instead of .service.js because the example files in the comment didn't end with .service.js, and wouldn't have been excluded otherwise.

I'm going to have to defer to others on this, but my initial reaction is that pattern could be too encompassing. It does make sense to exclude the individual service classes, but there are other files that I could see having docs for being useful for contributors (e.g various helper functions)

Unfortunate, not that I'm aware of.
The only read-only API would be the unauthenticated API.
I did just check, and I see nothing in the documentation about it, and on the API key page the only option is "Regenerate API Key" which has no other options, it'll just revoke the old key for a new one.

Yeah I think I'd be inclined to go with something like
"excludePattern": ".+\\.service\\.js$"

We do have some "base" files under /services that contain helpers used by quite a few other badges. We haven't really done it (yet), but I think there is value to documenting those and including them in the docs. I wouldn't want exclude docstrings we add to files like
https://github.com/badges/shields/blob/master/services/npm/npm-base.js or
https://github.com/badges/shields/blob/master/services/github/github-api-provider.js
for example.
On reflection, I think the existing files with docstrings under /services do actually match this pattern of being docs for shared helpers not individual services.

Sure, I've updated it to exclude all *.service.js files regardless of parent directory.

We currently don't have any docs in *.spec.js files or *.tester.js files, but could it be worth adding those to ignore as well for future reference?
Something like the following:
.+\\.(service|spec|tester)\\.js$
At the very least, it gives build-docs fewer files to process, but performance isn't a significant issue and there aren't  any reasons to use JSDocs on those files, I don't think.

We do have some "base" files under /services that contain helpers used by quite a few other badges. We haven't really done it (yet), but I think there is value to documenting those and including them in the docs

Agreed

We currently don't have any docs in *.spec.js files or *.tester.js files, but could it be worth adding those to ignore as well for future reference?

Sounds reasonable to me

yep - agreed :+1:


Panic on duplicate field for csv import

Summary:
Importing a csv with duplicate field headers causes a panic. Perhaps a better response might be to return error and exit.
Repro:
csv-import --header "col0,col1,col1" --delimiter "," --skip-records 0 nameof.csv --dest-type "map:0"  /tmp/test::nameofds

merged in https://github.com/attic-labs/noms/pull/2475


Instance hardware info doesn't shows up

the following fields is blank in instance info
CPU NUM:
CPU SPEED:
MEMORY SIZE::
HOST NAME

fixed in bb513300495c36d463e945563de1f56ae3ce381d


🔨 Export UseDataFunctionReturn & RemixSerializedType types

Related to conversation https://github.com/kiliman/remix-typedjson/issues/18 - exports the UseDataFunctionReturn type which makes typing a loader response when consumed via useMatches and should be helpful in concert with the useRouteLoaderData function.

NOTE: The UseDataFunctionReturn utility type simply returns the type of the JSON payload returned from your loader... from return typedjson(payload)
It doesn't actually convert the JSON data back to the native type (via metadata). If you look at the code for useTypedLoaderData, it does the actual conversion via deserializeRemix()
useMatches returns an array of active routes which includes the loader data. This loader data has NOT been deserialized. You will need to do that manually.
import { loader as rootLoader } from '~/root'
type RootLoaderData = UseDataFunctionReturn<typeof rootLoader>

const rootData = deserializeRemix<RootLoaderData>(useMatches()[0].data)

I plan on adding a useTypedRouteLoaderData function that will wrap all this.
const rootData = useTypedRouteLoaderData<typeof rootLoader>("root")

NOTE: The UseDataFunctionReturn utility type simply returns the type of the JSON payload returned from your loader... from return typedjson(payload)

@kiliman That's a great point:
I wrote a simple hook within which I use UseDataFunctionReturn:
const deserializeMatch = <LoaderType>(data: RouteData) =>
  deserializeRemix<UseDataFunctionReturn<LoaderType>>(
    data as RemixSerializedType<UseDataFunctionReturn<LoaderType>>
  )

export const useMatchDeserialized = <LoaderType>(route: string) => {
  const match = useMatches().find((m) => m.id === route)
  if (!match) throw new Error(`Route not found for: ${route}`)
  if (!match?.data) throw new Error(`Route "${route}" did not have data`)

  const loaderData = deserializeMatch<LoaderType>(match.data)
  if (!loaderData) throw new Error(`Route "${route}" could not be deserialized`)

  return loaderData
}

I just realized look at this code that I also had to copy the RemixSerializedType into my repo over to prevent a type issue with the deserializeRemix input
declare type NonJsonTypes =
  | 'date'
  | 'set'
  | 'map'
  | 'regexp'
  | 'bigint'
  | 'undefined'
  | 'infinity'
  | '-infinity'
  | 'nan'
  | 'error'

declare type MetaType = Record<string, NonJsonTypes>

declare type RemixSerializedType<T> = {
  __obj__: T | null
  __meta__?: MetaType | null
} & (
  | T
  | {
      __meta__?: MetaType
    }
)

Would it make sense to export RemixSerializedType as well or is there a way to accomplish that type-inference without doing so?

Went ahead and added RemixSerializedType export as well

Thanks!

This has been published a v0.1.7


Allowing end users to modify replyUrisWithType programmatically

It would be very helpful to modify the replyUrisWithType array programmatically instead of thru the manifest, since the manifest itself can't be upload programmatically.
Are there any plans to add support for either replyUrisWithType changing or manifest updating via CLI/Powershell/API?
Thanks,
Barry

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cc4c5921-4070-a714-44e6-c4309fe5fd53
Version Independent ID: c52c5c94-bb2e-10cb-9673-98aae4aa37d4
Content: Redirect URI (reply URL) restrictions - Microsoft identity platform
Content Source: articles/active-directory/develop/reply-url.md
Service: active-directory
Sub-service: develop
GitHub Login: @madansr7
Microsoft Alias: saumadan

@bmay-cloudwallcapital Thank you for your feedback . We will investigate and update the thread.

@bmay-cloudwallcapital
We don't provide product release dates, roadmap projections, predictions, or guesses in technical documentation.
Refer below for latest releases and updates:
https://azure.microsoft.com/updates
https://www.microsoft.com/microsoft-365/roadmap?filters=Azure Active Directory

Hi @shwetamathur7 I figured a way to do this and worked around it (you can use the GET/PATCH API to update the manifest), but it would be helpful if next time I was pointed to someone who could help with what was blocking me.


Overhaul ExceptionLayoutRenderer PR

Added enums so that the API can set with enums instead of strings.
Converted all delegates to action delegates.

This is for Issue#1016

Current coverage is 73.04%

Merging #1068 into master will not affect coverage as of 16ecbad

@@            master   #1068   diff @@
======================================
  Files          263     263
  Stmts        14901   14909     +8
  Branches      1623    1624     +1
  Methods          0       0
======================================
+ Hit          10885   10891     +6
- Partial        418     419     +1
- Missed        3598    3599     +1

Review entire Coverage Diff as of 16ecbad

Uncovered Suggestions

+0.09% via ...nternal/AspHelper.cs#206...218
+0.09% via ...nternal/AspHelper.cs#188...200
+0.09% via ...nternal/AspHelper.cs#170...182
See 7 more...

Powered by Codecov. Updated on successful CI builds.

This weekend I will review it.

fixes https://github.com/NLog/NLog/issues/1016

hey @Page-Not-Found
I reviewed the code. It looks really good, I added some notes for docs and some code improvements.
I'm happy we can remove the NotSet enum value. :)
Let me know what you think. I still think the switch to dictionary is a great improvement (I use it always for "conversion", but let me know if you think otherwise.

Let me know what you think. I still think the switch to dictionary is a great improvement (I use it always for conversions) but let me know if you think otherwise.

I think the initial format to list conversion is currently in the switch. Do you mean that needs to be changed?
private static List<ExceptionRenderingFormat> CompileFormat(string formatSpecifier)
        {
            List<ExceptionRenderingFormat> formats = new List<ExceptionRenderingFormat>();
            string[] parts = formatSpecifier.Replace(" ", string.Empty).Split(',');

            foreach (string s in parts)
            {
                ExceptionRenderingFormat? renderingFormat = null;

                switch (s.ToUpper(CultureInfo.InvariantCulture))
                {
                    case "MESSAGE":
                        renderingFormat = ExceptionRenderingFormat.Message;
                        break;
                    case "TYPE":
                        renderingFormat = ExceptionRenderingFormat.Type;
                        break;
                    case "SHORTTYPE":
                        renderingFormat = ExceptionRenderingFormat.ShortType;
                        break;
                    case "TOSTRING":
                        renderingFormat = ExceptionRenderingFormat.ToString;
                        break;
                    case "METHOD":
                        renderingFormat = ExceptionRenderingFormat.Method;
                        break;
                    case "STACKTRACE":
                        renderingFormat = ExceptionRenderingFormat.StackTrace;
                        break;
                    case "DATA":
                        renderingFormat = ExceptionRenderingFormat.Data;
                        break;
                    default:
                        InternalLogger.Warn("Unknown exception data target: {0}", s);
                        break;
                }
                if (renderingFormat != null)
                    formats.Add(renderingFormat.Value);

            }
            return formats;
        }

Yes,  that would be a great improvement!

I will write up a proposed code change and put up here again.

Here you go with a sample code
private static readonly Dictionary<String, ExceptionRenderingFormat> _formatsMapping = new Dictionary<string, ExceptionRenderingFormat>
{
	{"MESSAGE",ExceptionRenderingFormat.Message},
	{"TYPE", ExceptionRenderingFormat.Type},
	{"SHORTTYPE",ExceptionRenderingFormat.ShortType},
	{"TOSTRING",ExceptionRenderingFormat.ToString},
	{"METHOD",ExceptionRenderingFormat.Method},
	{"STACKTRACE", ExceptionRenderingFormat.StackTrace},
	{"DATA",ExceptionRenderingFormat.Data},
};

/// <summary>
        /// Split the string and then compile into list of Rendering formats.
        /// </summary>
        /// <param name="formatSpecifier"></param>
        /// <returns></returns>
        private static List<ExceptionRenderingFormat> CompileFormat(string formatSpecifier)
        {
            List<ExceptionRenderingFormat> formats = new List<ExceptionRenderingFormat>();
            string[] parts = formatSpecifier.Replace(" ", string.Empty).Split(',');

            foreach (string s in parts)
            {
                ExceptionRenderingFormat? renderingFormat = null;
                if (_formatsMapping.ContainsKey(s))
                {
                    renderingFormat = _formatsMapping[s];
                    formats.Add(renderingFormat.Value);
                }
                else
                {
                    InternalLogger.Warn("Unknown exception data target: {0}", s);
                }

            }
            return formats;
        }

Yes! that was what I really like.
some last improvements:

pass StringComparer.OrdinalIgnoreCase to the contructor of dictionary:
_formatsMapping = new Dictionary<string, ExceptionRenderingFormat>(StringComparer.OrdinalIgnoreCase)

formatSpecifier.Replace(" ", string.Empty).Split(','), is this   formatSpecifier.Split('.', StringSplitOptions.RemoveEmptyEntries) ?

use  dict.TryGetValue() instead if Contains and [..] - that one is 2 times faster and more logical here.

I think this is ready to merge?
I added one backwards-compatibly question. That's the last thing.

I am with limited internet access. Will get back to this once I am back.
On Dec 18, 2015 15:58, "Julian Verdurmen"<EMAIL_ADDRESS>wrote:

I think this is ready to merge?
I added one backwards-compatibly question. That's the last thing.
—
Reply to this email directly or view it on GitHub
https://github.com/NLog/NLog/pull/1068#issuecomment-165896430.

@304NotModified  I was able to change the methods back to virtual and override them as well. Added one more commit to the PR. Let me know what you feel.

@304NotModified  I was able to change the methods back to virtual and override them as well. Added one more commit to the PR. Let me know what you feel.

Cool! Merged it finally!
Very happy with the end result. It's a big improvement :)


Issue #75

See https://github.com/Activiti/activiti-cloud-charts/issues/75

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Notes on the test suite

I had a look through the test suite. A couple of questions:

What are the multi-letter forms used for? e.g. RR FilePath
Why do you catch the upper case variants as well? f ('R':'|':xs) = Just $ R xs. It would be ideal if you guaranteed only to produce one form.
os == "mingw32" - this always scares me that Haskell programs use a value called OS, matching against a string which is clearly not an OS, and is a toolkit not even installed probably at the wrong bit size. I prefer the isWindows from the extra library - but what you are doing is the Haskell expected pattern, I just don't like it, so go with whatever you prefer.

RR = Relative Read
I made a mistake in the suite, the upper case variants mean fsatrace was unable to determine the full absolute path for the access. Should be fixed now.
As for the os thing, yes, it also left me wondering why it reports "mingw32". I was aware of isWindows, just decided to go with that to avoid another dependency just for the tests.

So is the upper-case R relative thing something Shake should handle? And what is it relative to - the current directory at the time it was captured? Under which circumstances is it generated?
Yep, depending on an extra dependency is always annoying.

I don't think Shake should handle it. It's something that should disappear as soon as everything is working properly. It's there mainly to help figuring out if some tool is using an unimplemented feature.
It's mainly related to the usage of xxxat() function variants, like:
https://github.com/jacereda/fsatrace/blob/master/src/unix/fsatraceso.c#L267
I've never used them and haven't seen them used in any of the major compilers, so I didn't bother to implement them. Those could be asserts, but I decided to report them anyways.
They can also be reported on Windows if obtaining the path associated with a handle fails for some reason. I haven't seen it so far.

The "at" variants of functions are wonderful system calls, and it seems well worth supporting them! (And they aren't that hard.  Here is how I do it in bigbro:
https://github.com/droundy/bigbro/blob/master/linux-proc.h#L3


integrate Tautulli?

Is there any interest in adding an optional integration with Tautulli in kube-plex?
As the Tautilli (formerly plexpy) implementation requires access to the Plex logs in the plex runtime filesystem, running this as a sidecar seems like a logical choice.
If this is something that would be accepted, I'm happy to take a crack at a PR to implement this feature.

This is great news, thank you!


Using .ready() to set state

Hi, I want to use analytic's user/anonymous ID in combination with another A/B testing tool. I want to take the user ID from analytics when it is ready and then update the UI with a state change. I have something like this:
async function loadAnalytics() {
  const [ analytics, context ] = await AnalyticsBrowser.load({ writeKey: 'e4tHcwj8okR871fG0eK5pm58sxijbxjS' })
  analytics.ready(() => {
    console.log(window.analytics.user().anonymousId())
  })
  return analytics
}

I'm calling this inside a component:
useEffect(() => {
  loadAnalytics()
}, [])

But it errors as such:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'user')
Am I using .ready() incorrectly? I don't know how else to reliably get the anonymous ID.
I also need to work out how to set the state from there.

@martyjg Thanks for opening this issue!
Unless you're including the analytics snippet on your page, window.analytics will be undefined. Based on your sample you should be able to just call the analytics object returned by AnalyticsBrowser.load directly.
Also since you're awaiting AnalyticsBrowser.load(), you don't actually need to call .ready() - .load() will resolve after plugins have been registered and the library has finished initializing.

@chrisradek Amazing, thank you!


Not able to build the client on Linux

Describe the bug
The client application cannot be built using the instructions mentioned in the README.
What operating system and which version? Manjaro 5.15.25-1
Which version of Rocket.Chat (Server)? NA
Which version of Rocket.Chat.Electron (Electron/Desktop)? Latest
Is there any setting relevant changed? NA
To Reproduce
Steps to reproduce the behavior:

Clone repo
cd into folder
yarn
yarn start

Expected behavior
Open Rocket.Chat desktop client
Screenshots

Getting the same error on Windows 10 as well.

This start happening on Electron 17, dont know why. But you could try fix it too.


Remove argument internalNames from ArchivePacker::CreateVolume

Generate internalNames from within ArchivePacker instead of forcing users of the library to generate internalNames manually, standardizing the process.
Add error checking to throw an exception when creating volumes containing 2 files with the same internalName (filename not including path).

It isn't clear cut that the function name that ArchivePacker::GetInternalNamesFromPaths can throw an exception for 2 filenames being equivalent. However, implementing this exception inside the function seemed simpler and more efficient than implementing it in a separate function. Let me know what you think.

Hmm, I didn't mean to merge this branch but guess I did.
I just thought of an easy way to separate checking for duplicate internalFilenames from the function that creates the internalFilenames from the paths to be packed. I'll open a branch for this.
It is important to me to check for duplicate internalFilenames as I think allowing inclusion of duplicate filenames doesn't make sense when trying to retrieve files via the binary search. Duplicate filenames originating from different paths or the same path repeated twice should cause the packing to be aborted.
I agree with moving code that checks for and strips .WAV extensions for CLM file inclusion into the OP2Utility code. I'll move the subroutine that does this from OP2Archive to OP2Utility in a new branch.
I'm not following your thought process on the security issue. I don't see how to check where a file will be unpacked to during the file packing process. The user will specify the directory they want the file unpacked to during the unpacking process and I wouldn't be able to predict that up front. I would prefere to leave it up to the  application or user calling the unpack function to choose a safe location where to unpack files.
Thanks,
Brett

Duplicate filenames won't harm a binary search, assuming sort order is maintained (identically compared items must be next to each other), but the search will only be able to find one of them, whichever one it hits first. I agree it should be a packing error to have two identically named files. Though with that said, if internal operations are done by index, rather than name, it would be possible to support identically named files, and still have access to both. At the very least, you'd be able to properly investigate any oddly or maliciously constructed files, where the game might see one, but unpacking it all would reveal the other (possibly by putting it later so it overwrites the malicious file when both are unpacked).
For the security issue, consider unpacking a VOL which contains any filenames such as the following:
/autoexec.bat
/config.sys
C:\Windows\System32\cmd.exe
/etc/passwd  (Linux example)
../../../../../Windows/System32/cmd.exe  (guess the relative depth)
If they were logged on as an admin, that could really mess up their system. Simply prefixing an output folder is not sufficient to default the relative path example. And if the empty string is used to represent the current working directory, which is common in many apps, the paths with a leading / will be treated as absolute rather than relative.
This is something you need to consider during extraction, since it's possible the archive was packed using a 3rd party tool that you don't control.

Good point about a volume being created by a third party.
When unpacking, we can add a check that throws an error if a path is found on any internalName before unpacking commences to catch this sort of thing.


Update the gulp importl10n command to fetch the active language codes

Update the gulp importl10n command to fetch the active language codes
Rather than having to manually maintain a static list of language codes, it's much easier to simply fetch the active ones from mozilla-central instead.
As part of this the code in external/importL10n/locales.js was modernized slightly, by using Promises/async functions to get rid of a bunch of annoying callbacks (which shouldn't be a problem for reasonably modern Node.js versions).

Update l10n files

Have gulp importl10n list locales which may be candidates for removal
Rather than having the script remove locales automatically, which seems like a heavy-handed approach at least initially, listing these for manual checking seems nice though.

Smaller diff with https://github.com/mozilla/pdf.js/pull/11213/files?w=1

Good to see this script getting some improvements!

As always, thanks for reviewing/merging this (and other PRs)!
With these changes, the following locales are listed as candidates for removal:
Consider removing the following unmaintained locales:
ak, bn-BD, bn-IN, csb, hto, kok, ks, ku, lg, meh, mn, nso, rw, sah, sat, sw, ta-LK, tn, tsz, zam, zu

It looks like most of the haven't been updated for years, but I didn't look too closely and thus wasn't sure if outright removal was the right hing to do in this PR.

I like that it notifies us, but allows us to take action if required. I do think removing those locales would be fine for a follow-up patch.


[BUG]lfs_port_internal_nor pxCfg->unlock setting

The pxCfg->lock is configured instead of  pxCfg->unlock. Line #L157 of lfs_port_internal_nor.c should be pxCfg->unlock = &lfs_port_unlock;
https://github.com/FreeRTOS/iot-reference-stm32u5/blob/main/Projects/b_u585i_iot02a_ntz/Src/fs/lfs_port_internal_nor.c#L157
compare to
https://github.com/FreeRTOS/iot-reference-stm32u5/blob/main/Projects/b_u585i_iot02a_ntz/Src/fs/lfs_port_ospi.c#L94

Hi @SlimJallouli,
Sorry for the late response. Thank you for bringing this to attention. I will take a deeper look.
Best,
Jason Carroll

Would you mind opening a PR to address the issue?


Remove the local: and up: special namespaces

These special namespaces don't behave like normal namespaces and require special support for introspection (e.g. #1343). It's simpler to just remove them, since they're not really essential anywhere. FWIW, builtin: also used to be a special namespace, and was demoted to a normal namespace that can be imported with use builtin.
The existence of local: also leads to some unnecessary usage - e.g. writing $local:a to ensure that the code is accessing the local $a. Since Elvish always resolves local variables first, $local:a can always be replaced with $a.
One valid use case for local: is shadowing variables - local:a = foo always creates a new variable, as opposed to a = foo which might be assigning $a from an outer scope. But var a = foo now does the same thing and is preferred.
The removal of up: does lead to some loss of functionality, since it could be used to access shadowed variables. However, this should be rare enough, and no other language I am aware of provides a mechanism to access shadowed variables, and they seem fine.
Timeline:

Deprecate in 0.17.0
Remove in master branch after branching of 0.17.x

I took a brief survey of uses of local: "in the wild" on GitHub and it seems that the majority of places are just using it to declare local variables; such uses are already handled by the upgrader, which will rewrite local:a = x to var a = x (stripping the local:), so I'll probably not include this migration in the upgrader.

It occurred to me that you would be removing the local: namespace in light of introducing explicit variable declaration using var. I concur that the new syntax and semantics is preferable.
Regarding the up: namespace I assumed it was inspired by something like the TCL uplevel command. But, yes, I can't really see much value in retaining the feature and thus it is reasonable to remove it. Also, shouldn't it be possible to achieve the same result by assigning the value of the enclosing lexical scope before defining a new local var with the same name?


Rejection Reason Name not updating

Current behavior

https://jam.dev/c/fb4739b0-7862-4d0c-93ba-3227600ed8c4

This issue is not replicating at my end. If the issue occurs again with a finite number of replication steps, we will reopen it.
Hence, closing this ticket for now.


how to use in a1111 webui?

Currently ComfyUI and Forge versions are available:

https://github.com/huchenlei/ComfyUI-IC-Light-Native
https://github.com/huchenlei/sd-forge-ic-light

I will work on A1111 extension soon.

give it a go
https://github.com/QodiCat/IC-Light-sd-webui


Download gating ranges

Button to download the set ranges (min/max) for each channel.

Implemented - need to confirm that format is correct.

done.


From fediverse to bluesky: can't interact with someone on bluesky

hi hello
I have a bridged fediverse account, they have a bridged bluesky account, but my interactions (replies and likes) with them doesn't appear on bluesky. On https://fed.brid.gy/ap/<EMAIL_ADDRESS>my interactions appear with a green check, but still aren't visible from bluesky. Reposting works.
I prefer not to give the real link because that's their personal account.
thanks for helping :3

Hmm, https://fed.brid.gy/ap/<EMAIL_ADDRESS>shows that your account isn't bridged. Did you disable it?

Sorry for the trouble! I'd need more information to help though...

ok it worked? i think sending the like and replies took more time than the other things? but i think i checked even a long time after some replies?
Anyway it might be my fault, i'll check in the future if it works

Ah, yes, we see delays a bit more often now that Bluesky has switched to their non-archival relay. Sorry!


Changing workspace or minimizing hides NodeTreeWidget on Ubuntu

QDockWidget::visibilityChanged is emitted while changing workspace or minimizing (Ubuntu 16.04.2 LTS, Qt 5.9.1).
It toggles 'Node tree' button and hides NodeTreeWidget.
It's a side effect of toggling 'Node tree' button when user closes Node tree with cross icon.

Fixed by https://github.com/codilime/veles/pull/279


Update lib.rs

Minor performance improvements.

Looks like there's a syntax error there. You'll want to make sure that cargo check and cargo test are clean.
Apart from that, could you tell me about the goal of the change?


xtensa: esp32 : setup software interrupt for esp32chips

Summary
setup software interrupt for esp32chips
Impact
Testing
Tesing on esp32 qemu

could  you please review this again? @Ouss4  @gustavonihei

@Ouss4
This patch I have test on qemu ESP32, you can try it on ESP32s2 and ESP32S3.

@zhuyanlinzyl I'll run a test with an S3 board.

@zhuyanlinzyl I'll run a test with an S3 board.

Actually, since this still doesn't change the context swtiching and only setups up the software interrupt, there isn't much to test here.  I verified that the interrupts numbers are the same as ESP32 and thus the configuration should be correct.


Support for cppcheck

Docs: http://cppcheck.sourceforge.net/

can be merged in: /lintC

please reopen when ready to implement


is-root as a third party module dependency is unnecessary

This:
'use strict';
module.exports = function () {
	return process.getuid && process.getuid() === 0;
};

...Doesn't pay for itself.

Is the solution to replace it with an internal modules, i.e. lib/is-root.js? Could this be a good starter issue for a new contributor?

Or just...
const isRoot = process.getuid && process.getuid() === 0;

Doesn't pay for itself.

What does it cost? Is it really a good idea to start copy and pasting in third party dependencies instead of relying on npm to fetch them for us?
I think that this is a very good writeup on why small modules is a great way to do things: https://github.com/sindresorhus/ama/issues/10#issuecomment-117766328
I think it's better to go in the opposite direction then what this issue is proposing, more things that we can have in separate modules means less things for us to maintain. When an edge case is introduced in how to check for the root user, we don't have to go and update our code to reflect that, it's all done in one place.
I don't think that we should focus on how many lines of code this specific function is, but rather see that it is one specific function that we want, and we don't need to concern ourselves with how it's implemented. By using the is-root package, we don't need to know the nitty gritty of how uid:s work on unix.
Also, is-root has about half a million downloads a month, and the feeling I'm getting from the community is that we are moving towards small focused modules, following the unix philosophy.

This has always been, and always will be, a subjective matter. Most of the evidence cited to support small modules can also be interpreted as against—but again, that's subjective. I'm going to close this because I don't really care to argue about it.


hipBLAS link broken

From the main navigation sidebar, the hipBLAS link goes to a 404.

Fixed in readthedocs.


x/pkgsite: package removal request for github.com/Azure/azure-sdk-for-go/sdk/cognitiveservices/azopenai

What is the path of the package that you would like to have removed?
github.com/Azure/azure-sdk-for-go/sdk/cognitiveservices/azopenai
Are you the owner of this package?
Yes - primary code contributor and owner within the Azure SDK.
What is the reason that you could not retract this package instead?
We're moving this package to a new location (new: github.com/Azure/azure-sdk-for-go/sdk/ai/azopenai). We've marked the the previous package as deprecated and now just want to ensure nobody else picks it up.

you should be able to do this yourself with retract.

@seankhliao , just to check - if we retract this version (and all other versions of this package) will that completely eliminate it from showing up on pkg.go.dev? We're worried people will see the old and new packages and just want the older package to disappear entirely.

If all versions of the package are retracted, that should completely eliminate it from pkg.go.dev.
From https://go.dev/ref/mod#go-mod-file-retract

Wiping out a module including all pseudo-versions and tagged versions:
retract [v0.0.0-0, v0.1.2]  // assuming v0.1.2 contains this retraction.

Thank you @suzmue and @seankhliao, I'll do that. Closing this because you two have taught me a valuable lesson - the true power was in my hands the entire time. ;)

Hey all, sorry to reopen this.
I published a 'retract' for our github.com/Azure/azure-sdk-for-go/sdk/cognitiveservices/azopenai (the old package) but it hasn't removed the old entry from pkg.go.dev.
The version I published (v0.1.2) isn't showing up in the versions list for the package:
https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/cognitiveservices/azopenai?tab=versions
Here's our go.mod, which shows the retract:
https://github.com/Azure/azure-sdk-for-go/blob/4b91f97771d98ea60da9fb1139e03d40c10245b7/sdk/cognitiveservices/azopenai/go.mod#L6
I believe I've got the proper metadata because, when I try to pull the old package version, it gives me the retract message:
go get<EMAIL_ADDRESS>go: module github.com/Azure/azure-sdk-for-go/sdk/cognitiveservices/azopenai is deprecated: use github.com/Azure/azure-sdk-for-go/sdk/ai/azopenai instead
go: warning<EMAIL_ADDRESS>retracted by module author: use github.com/Azure/azure-sdk-for-go/sdk/ai/azopenai instead.
go: to switch to the latest unretracted version, run:
        go get github.com/Azure/azure-sdk-for-go/sdk/cognitiveservices/azopenai@latest

Hi, sorry for the slow response -- this popped up on our radar again thanks to @seankhliao removing the label.
It appears that those versions are retracted (as labeled in pkg.go.dev), and don't show up in search results, but are still viewable.
I'll exclude the path entirely.

@findleyr, thank you for the help, really appreciate it. :)

Looks like this is done now.


Can't parse toml file with comments inside array

Description
The following toml file is valid according the toml-lint.com:
items = [
  # comment
  { id = '001', reviewed = true },
  { id = '002', reviewed = true },

  # comment2
  { id = '003', reviewed = true },
  { id = '004', reviewed = true }
]

however, when reading this file in a typst file, I get error: expected expression unless I remove the comments
Reproduction URL
No response
Operating system
Linux
Typst version

[X] I am using the latest version of Typst

Update: this apparently works after I restart typst watch. so seems to be some issue with the watching/reloading logic itself, instead of the parsing

Probably https://github.com/typst/typst/issues/2601 then

Watching bugs were fixed in https://github.com/typst/typst/pull/2706. If you can still reproduce this, please reopen.


Implementation of UpdateFolder operation

I'm implementing the UpdateFolder and MoveFolder operations right now.
Though I could need some advice on the update class. Right now it only outputs the operations SetItemField, AppendToItemField and DeleteItemField for the UpdateItem operation.
But for UpdateFolder we need SetFolderField, AppendToFolderField and DeleteFolderField.
I just renamed to_xml() to to_item_xml() and copied it to to_folder_xml() to return the respective values. Though, I'm not super happy with that.
Any ideas on a more elegant solution?

NVM the update class. Having two different to_XXXX_xml() functions doesn't seem as bad actually.
But something I stumbled upon again and can't get my head wrapped around. update_item_impl has two overloads. One for a single update and the other for an std::vector<update>. I get that it's convenient for the public functions.
But wouldn't it be acceptable if update_item with a single update item creates a vector on the spot. Moving the update object into the vector and forwarding it to the update_item_impl function shouldn't be much of an overhead. Or is it?
Allocation of 16 (32 on x64) Byte per call. The iteration over the single-item vector should be 4 (8) Byte unless optimized away somehow.
Maybe I'm just overthinking again...


Updated asset gov topics for Azure support

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


sha checksum - file integrity

Aknowledgements

[X] I have checked that there is no other issue describing the same or
similar problem that I currently have, regardless if it has been
closed or open.

[ ] This bug affects Discord website.

[ ] This issue is confirmed to be reproduceable when WebCord is packaged
on at least all three latest supported Electron major releases.

[ ] This issue is reproduceable in Chrome, Chromium or any
Chromium-based browser, e.g Brave or Edge (please write in
Additional Context which browser you have used if it is neither
Chrome nor unmodified Chromium).

[ ] There are no fixes done to master which resolves this issue.

[ ] My issue describes one of the unstable and/or not fully implemented
features.

[ ] I have found a workaround to mitigate or temporarily fix this issue
in affected releases (please write it in Additional context section
below).

Operating System / Platform
🪟 Windows
Operating system architecture
x64 (64-bit Intel/AMD)
Electron version
22.0.0
Application version
4.0.0
Bug description
Not a bug really but, could you please include a sha checksum 256 or 512 so we can verify the downloaded file isn't malicious?
Additional context
No response

Not a bug really but, could you please include a sha checksum 256 or 512 so we can verify the downloaded file isn't malicious?

That should be then filled with feature request template (please do not report them as bugs).

apologies, should have labeled it as feature request not a bug.
from what i know, the sha-checksum only grants that the downloaded file matches the one on the source-website, this does not protect against malicious actors who have access to the actual source-website as they could modify the file and it will go unnoticed as long the checksum matches. But even signatures might not be a gurantee for safety, remember recently nvidia drivers where infected and this was while the signature was intact because some actors got direct access to nvidias infrastructure?
Anyways i probably should pay close attention to signatures and not only the checksum, thanks for the reminder.
Actually i'm not sure how this works, on windows we can inspect file properties with a rightklick on said file, then how can i be sure the signature is legit?

Or maybe i should ask, how do you personally ensure security on your systems when it comes to downloading and installing software?

Or maybe i should ask, how do you personally ensure security on your systems when it comes to downloading and installing software?

As I use Arch Linux as a daily driver, most important software I install is protected using the PGP signature bundled in the packages. Only packages I self-package from AUR aren't always secured by signature and -git packages aren't even verified using checksum.
I believe checksum might also be useless as malicious actor prevention if it is downloaded from the same source as the file itself.

Actually i'm not sure how this works, on windows we can inspect file properties with a rightklick on said file, then how can i be sure the signature is legit?

On Windows, software is signed using the certificate bought by developer from one of the resellers. You can also self-sign software, but that would require importing such certificate. Also SmartScreen actually verifies most unsigned software (in fact this is why WebCord triggers it). I'm not sure through if bought certificates protect anyone from masking as another developer.
On Linux, PGP is designed for self-signing in mind. The security of software signed with PGP depends on your trust to the given public key – importing it doesn't necessarily mean it will be trusted by the OS. The signatures also have to be shared through the secure medium in order to guarantee users will receive the correct key – PGP has a concept of web of trust for that. So as long as you trust the specific developer and have the correct key, you can validate the signatures and tell if these were distributed using the specific key or not.
FYI, there's much more concepts around the security of the distributed software than checksum hashes and software signing – see e.g. binary transparency concept.

Archlinux seems like a great choice, and alot to learn.
So you are saying, i can spare my time when it comes to comparing checksums when i get the checksum from the same site as the file itself, alright that sounds logical. I tought, when downloading software from any original source it might still be worth comparing the checksum because a malicious actor like my internet service provider (forced by law) to inject a state-level-trojan into the file i'm downloading while it is being downloaded (from the original source..) and so i will have a malicious file even when i got it from the original source but the checksum won't match if the ISP modified the file.
Sure if the website hosting the software itself is compromised then checksums are entirely useless.
I've deleted smartscreen.exe it's just a silly censorship measure of microsoft...
So didn't even know it gets triggered by webcord.
The sources you sent seem a bit complicated to be honest, i'd rather just learn how to verify file certificates/integrity instead of understanding the process itself... not the best approach but it'll do the job
For windows i found PGP4win, no idea if i need that software for what i want to achive.
Anyways, in my last reply i mentioned a rightklick on whatever software will provide some information, so i took a screenshot, in this example: protonvpn. And now?
Just to clarify, im thankful for all the information you provided to me and i see that your're just here because of webcord so when my questions don't really fit here i understand that.


Metadata#deploy() fails

I'm not sure if this is an error with this package or jsforce/gulp-jsforce-deploy itself or salesforce but #33 seems similar. Any other information that I could provide that could give a clue as to whats going on here?
{
  checkOnly: false,
  completedDate: '2015-07-09T17:48:54.000Z',
  createdBy: '005F00000062sHA',
  createdDate: '2015-07-09T17:48:54.000Z',
  details: { runTestResult: { numFailures: '0', numTestsRun: '0', totalTime: '0.0' } },
  done: true,
  errorMessage: 'UNKNOWN_EXCEPTION: An unexpected error occurred. Please include this ErrorId if you contact support:<PHONE_NUMBER>-7618 (-824679420)',
  errorStatusCode: 'UNKNOWN_EXCEPTION',
  id: '0AfL000000BrP6dKAF',
  ignoreWarnings: false,
  lastModifiedDate: '2015-07-09T17:48:54.000Z',
  numberComponentErrors: 0,
  numberComponentsDeployed: 0,
  numberComponentsTotal: 0,
  numberTestErrors: 0,
  numberTestsCompleted: 0,
  numberTestsTotal: 0,
  rollbackOnError: false,
  runTestsEnabled: 'false',
  status: 'Failed',
  success: false
}

My gulp config looks like so:
gulp.task('deploy-sandbox', ['build-sandbox-sf-zip'], function() {
  return gulp.src('./sandbox/salesforce-files.zip', {base: '.'})
    .pipe(forceDeploy({
      username: process.env.SF_USERNAME,
      password: process.env.SF_PASSWORD,
      loginUrl: 'https://test.salesforce.com',
      logLevel: 3,
      version: '31.0'
    }))
    .pipe(debug());
});

Seems the zip file content problem. Try using gulp-zip to create zip content file dynamically. Here's a example.
https://github.com/jsforce/gulp-jsforce-deploy


Error activating IScheduler

When using the Ninject and Quartz integrations with the following code:
    static void Main()
    {
        HostFactory.Run(c =>
        {
            c.UseNinject(new WorkerModule());
            c.UseQuartzNinject();

            c.ScheduleQuartzJobAsService(q =>
                    q.WithJob(() =>
                        JobBuilder.Create<NotificationsJob>().Build())
                    .AddTrigger(() =>
                        TriggerBuilder.Create()
                            .WithSimpleSchedule(builder => builder
                                .WithIntervalInSeconds(60)
                                .RepeatForever())
                            .Build())
            );
        });
    }

Error:

An exception of type 'Ninject.ActivationException' occurred in Ninject.dll but was not >handled in user code
Additional information: Error activating IScheduler

I was under the assumption that this would configure IScheduler automatically?

Made Ninject.Extensions.Quartz a listed dependency in the nuspec in 0.4.0 release.


ci: Release .deb and .rpm packages

This adds .deb and .rpm packages for prqlc as release assets on GitHub.

Looking at the artifacts, it seems that only amd64 deb packages exist...

FYI this is looking nice! Clever use of the existing build @vanillajonathan !

FYI this is looking nice! Clever use of the existing build @vanillajonathan !

It was @eitsupi who suggested using the existing build.
This build fails with some codecov check, but I don't know why.
This looks good now? Can we merge?
@eitsupi This is good?

This build fails with some codecov check, but I don't know why.

This is a mistake — you can ignore it.
I think that probably the number of lines increased which means the % of lines checked went down. Ideally we could change the codecov settings so it only considered rust code...

Please check the uploaded artifacts.
As I wrote in https://github.com/PRQL/prql/pull/3810#issuecomment-1816621205, it looks like it was not uploaded correctly. (I don't know if I can really build deb/rpm packages this way in the first place)

@eitsupi Both artifact-deb and artifact-rpm are uploaded. I downloaded artifact-deb, extracted it and was able to install it on my system.
The release step was skipped because it is only ran when if: github.event_name == 'release'.
I think it looks good.

It looks like the arm64 versions are not included in the artifact.
Probably overwritten because the name has not been changed due to architectural differences.
Also, I think that the one for arm64 is also named as amd64 because the architecture is not specified in the first place.
https://github.com/PRQL/prql/actions/runs/6906907289/job/18793515022#step:5:36
https://github.com/PRQL/prql/actions/runs/6906907289/job/18793514701#step:5:146

Looking v good, thanks for refining it @vanillajonathan

@eitsupi Well spotted, I missed that. I was able to fix that by specifying the arch parameter for the build-deb-action.
We can't build anything else than x86_64 with build-rpm-action though. https://github.com/jiro4989/build-rpm-action/issues/6

How about using https://github.com/goreleaser/nfpm?

We could do that, but then I would have to rework the pipeline and it's a bit more code. I think I finally got the pipeline working, so I would like just to merge it and consider this good enough until there is a demand for .rpm packages compiled for ARM.

Since jiro4989/build-rpm-action doesn't seem to be widely used and doesn't have enough functionality, I'm not sure if it's worth using here.
I hope it's fixed now because I don't believe that someone will do it in the future if it's not fixed now, but I won't stop merging if @max-sixty want to merge right away.

I would indeed encourage merging incremental improvements...
ARM would be nice to have, and nfpm looks good. But I would vote to merge given it sounds like @vanillajonathan is happy with it, and that it does make incremental improvements (and is clever in how it shares the build...)

@eitsupi no rush if you're aware but FYI it's waiting on your "request changes" :)

Sorry for the delay.

Thanks @vanillajonathan & @eitsupi !


Add documentation on how to use ng-apimock with other testing frameworks than protractor

I'm working on a project where I wanted to do the testing using Cypress: https://www.cypress.io/
It took me some time to figure out how to best integrate Cypress and ng-apimock, but this is what I ended up doing:
Assuming ng-apimock is running on port 8101. Define the following custom cypress commands in
cypress/support/commands.js:
Cypress.Commands.add("selectScenario", function (identifier, scenario) {
  cy.request("PUT", 'http://localhost:8101/ngapimock/mocks', JSON.stringify({
    identifier: identifier,
    scenario: scenario
  }))
});

Cypress.Commands.add("resetScenariosToDefaults", function () {
  cy.request("PUT", 'http://localhost:8101/ngapimock/mocks/defaults', null);
});

You can then use these commands in your tests as follows:
cypress/integration/example_spec.js:
cy.selectScenario('yourMockName', 'yourScenarioName');
cy.resetScenariosToDefaults();

I'd love to hear if I should be doing something differently. If you agree this is the correct way of integrating ng-apimock with Cypress could you add this to the ng-apimock documentation?
It would be super awesome if there is some kind of cypress-commands.js file in the ng-apimock package which we can simply import in cypress/support/commands.js
I believe implementing that would look something like this:
ng-apimock/lib/cypress/cypress-commands.js:
module.exports = function setupCustomCommands(host, port) {
  const baseUrl = `http://${host}:${port}/ngapimock/mocks`;

  Cypress.Commands.add("selectScenario", function (identifier, scenario) {
    cy.request("PUT", baseUrl, JSON.stringify({
      identifier: identifier,
      scenario: scenario
    }))
  });

  Cypress.Commands.add("resetScenariosToDefaults", function () {
    cy.request("PUT", `${baseUrl}/defaults`, null);
  });

}

cypress/support/commands.js:
const setupCustomCommands = require('ng-apimock/lib/cypress/cypress-commands');
setupCustomCommands('localhost', '8101');

I think it would be cooler though if we don't have to pass in the host and port, because ng-apimock should already know where it is running.

Hi @sandervalstar
Nice that you are also trying to use ng-Apimock with a different framework then Protractor. I'm currently also investigating the use of ng-Apimock with Webdriver.io i.c.m. native mobile apps.
I also talked about this with @mdasberg to pull out some logic from ng-Apimock template for Protractor to a more generic api that can be used by any framework. This will definitely help in getting that done ;-)

Is there a document how to use ngapimock with cypress? I am getting error for selectCommand that i defined as defined on site.


Docs for r12 ?

Hi,
Due to a stability requirement, I am trying to get familiar with Tone.js at r12  - don't suppose the API reference and/or docs/examples for r12 are still available somewhere?
Thanks for that and for keeping Tone sounding sweet!

I'm not sure about the examples but the API docs are here: https://tonejs.github.io/docs/r12/AutoFilter

Thanks @chrisguttandin!
@cristianvogel you can grab the r12 release here which will have all of the example files in there as well.


tio2 example not shipped

from weas_widget import WeasWidget
viewer1 = WeasWidget()
viewer1.load_example("tio2.cif")
viewer1.modelStyle = 2
viewer1.boundary = [[-0.1, 1.1], [-0.1, 1.1], [-0.1, 1.1]]
viewer1.showBondedAtoms = True
viewer1.colorType = "VESTA"
viewer1

ValueError: Failed to download the file tio2.cif

Fixed. Same as #36


[QUESTION] Random sampling of tweets

So I've been trying to download a random sample of tweets from a set time period (one or two days), but not concerning a specific topic or language or anything. Basically a random sampling of all tweets from that time frame. I've messed around with excluding the word search parameter, and trying to create a firehose pull by specifying all languages, etc. but every time I get the error:

CRITICAL:root:twint.run:Twint:Feed:noData'globalObjects'
sleeping for 1.0 secs

Which then repeats with an increasing second count until I interrupt the execution.
I get this error regardless of the limit number I set.
Am I just trying to do something that isn't possible? Or Is there a non-word-based query function that I could use instead?

I think there might be a problem with the program itself, it’s been 4 days I cannot use the program; either critical error, or it stucks at a point while scraping.


Support treating plain strings as commands

So that it's possible to do something like lsr; [some-str m] grep; shift; "vim {}" fmt; exec (though hopefully the quoting can be avoided somehow, or it can use curly braces or something like that).

Fixed as at c4b838b.


Show popups when a Popup entry is missing but title and/or contents are available

Fixes #7014.
We already did this for Text annotations, but as it turns out, we need to do this for every annotation type that works with popups. With this patch, the file mentioned in the issue above (also attached to this PR as a test case) renders the same in PDF.js as it does in any other reader.
@Snuffleupagus Do you have time to review this one? If not, feel free to unassign yourself. The logic is practically the same as we already have for Text annotations, so hopefully it should be relatively easy to review.

/botio-linux preview

/botio test

Maybe Highlight/Underline/Squiggly/StrikeOut annotations should have a common base class? Identical code over four classes is not ideal.

Now that you brought this up, there are more types that have popups (almost all actually), so I'll update the patch later today to move most popup handling to the Annotation/AnnotationElement base classes. Thanks.

/botio-linux preview

/botio-linux preview

/botio-linux preview

/botio test

Looks good, and much better with the helper methods added, thank you for the patch!
/botio makeref


Properly handle exact routing; fixes #39

Hello @pateketrueke, can you please reopen this PR in order for us to fix #39 and #43?


Manual approval required for workflow run<PHONE_NUMBER>

Workflow is pending manual review.
URL: https://github.com/ashishjullia/terraform-w-rollback/actions/runs/3475037472
Required approvers: [ashishjullia]
Respond "approved", "approve", "lgtm", "yes" to continue workflow or "denied", "deny", "no" to cancel.

approve

All approvers have approved, continuing workflow and closing this issue.


Http v3

from v2:

hack to work works without microhttpd upstream
fixes if/else if/ pointed by leandro
using sol_str_slice_from_str()
Check if http's method is null
check the return strptime (if *s != '\0').

fixes on https://github.com/solettaproject/soletta/pull/696

Patchset looks better.
I'm just sad we're not reusing more code in the handlers, but I'm OK to leave this as is as long as that's revisited whenever more packets are supported.

fixes on https://github.com/solettaproject/soletta/pull/711


Updated function definition causing 500 error

I had an issue with one of my projects where this file was causing laravel-opcache to throw a 500 error.

syntax error, unexpected 'public' (T_PUBLIC), expecting variable (T_VARIABLE) {"url":"/opcache-api/compile","exception":"[object] (Symfony\Component\Debug\Exception\FatalThrowableError(code: 0): syntax error, unexpected 'public' (T_PUBLIC), expecting variable (T_VARIABLE) at vendor/symfony/service-contracts/Attribute/SubscribedService.php:30)

After removing public from the function definition, everything worked as expected.
This is to correct the following issue - https://github.com/symfony/symfony/issues/44924

Closing PR as the issue thread has been closed - https://github.com/symfony/symfony/issues/44924


Update documentation around CVE-2024-22030

Related Issues
SURE-7667
Summary
Documentation includes two phases:

Update exist docs around our concerns, for example: We don't properly document our assumptions around CA validations and the risks associated with it (Rancher's threat model for at least certs/CA/TLS/SSL) in our docs.
Update docs around any changes in behavior, or functionality. Mainly with regard to cert rotation, and changes with agent or flags.

Resources:

https://ranchermanager.docs.rancher.com/reference-guides/rancher-security/security-advisories-and-cves
https://www.suse.com/c/rancher-security-update/?_gl=1*5lvo5u*_ga*NzM4OTQzOTk4LjE3MDk1Njg3NjU.*_ga_Y7SFXF9L00*MTcxMDQ0Nzk4Ny4xNC4wLjE3MTA0NDc5ODguNTkuMC4w

From Slack:

The TLS communication between agents and Rancher Manager can be verified using two different modes: CA Bundle or Local trust store.
The former is used when a non-public PKI is being used. The latter is for when the certificates being used come from a public PKI, or their custom CA is expected to already exist on the local trust store for all worker nodes.
Using CA Bundles, makes the TLS behaviour quite strict as only that certificates within that bundle will be trusted.
Using the Local trust store, any CA within the local trust store (on a typical linux install there are >100 CAs), could generate a valid certificate for Rancher Manager.
⚠  In some specific cases, if the TLS verification for a CA Bundle provided fails. Rancher Manager may drop that information and fall back to the Local trust store instead for all future connections. This behaviour is currently being reviewed and will be changed/configurable in the future.


Make it possible to disable ssl checks on production

The default is to enforce ssl usage on production, however in certain circumstances (e.g.: out internal integration test suite) it's actually more convenient to not use ssl.

LGTM. Update the wiki https://github.com/SUSE/Portus/wiki/Configuring-Portus#list-of-configuration-options.

@mssola the wiki has been updated, thanks


Fix for keyword quoting (#40)

The fix is to quote all identifiers. This doesn't do any harm and fixes the problem with unquoted keywords.

The integration test is failing, I will have to fix that.


ImageLoader with fragments

Several people have reported me that ImageLoader doesn't display bitmaps correctly if used inside fragments. Unfortunately I can't reproduce this problem - it works just fine for me. It would be great if someone could attach a demo project with the problem inside. Have some ideas how to fix it. But before applying the fix need to be able to reproduce the problem and test it well.

Hi Fedor,
Like I promised, here is a demo app: https://github.com/DushyanthMaguluru/LazyListFragment that fails to set images correctly. I used a Cursor adapter in combination with a ContentProvider. You should notice that once you click on "Launch UserList" button on the main view, all the images are set to the default image. Only if you scroll down to the bottom and scroll back up, you will see the images being refreshed. And if you look at the logcat you will notice that you will only see these lines:
[ VERBOSE ] => ImageLoader: BitmapDisplayer Initialized
[ VERBOSE ] => ImageLoader: BitmapDisplayer Initialized
[ VERBOSE ] => ImageLoader: BitmapDisplayer Initialized
[ VERBOSE ] => ImageLoader: BitmapDisplayer Initialized
[ VERBOSE ] => ImageLoader: BitmapDisplayer Initialized

Note: I also tried setting the tag like you recommended on a different ticket, image.setTag(url). The results didn't change though.
Finally, I am sorry if there is actually a mistake in my implementation.
Thanks,
Dushyanth

Dushyanth, thank you very much for the code.
I can see what's wrong with it. You pass application context to the adapter. That's why list items are inflated in application context and their getContext() is application not activity. Here's a fix https://github.com/thest1/LazyListFragment/commit/b15c2f635f90ed1b7c9eacd7357d2a077c4847c7.
Now the question is should I make a fix to allow ImageLoader work even under application context not just activity context. I'll have to create additional handlers for that as proposed by Vladislav https://github.com/gingo/LazyList/commit/e9e2c8310f49768d78aad21bb6a29b831d4ef2f4. I'm not sure about that yet. Actually if you use ImageLoader you always have Activity and you can pass it not an application.

 I am sorry to have wasted your time.

Don't worry, you just helped me to figure out a weak place that can cause problems for many other people. So you contribution is highly appreciated.

Thank you. As for changing the ImageLoader to use Handlers, I agree with your point that ImageLoader always has an activity. So not sure if its worth implementing the Handler architecture.


python311Packages.pilkit: unstable-2022-02-17 -> 3.0

Description of changes
Diff: https://github.com/matthewwithanm/pilkit/compare/09ffa2ad33318ae5fd3464655c14c7f01ffc2097...3.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 261583 run on x86_64-linux 1

2 packages failed to build:

sigal
sigal.dist

4 packages built:

python310Packages.pilkit
python310Packages.pilkit.dist
python311Packages.pilkit
python311Packages.pilkit.dist

Result of nixpkgs-review pr 261583 at 8113dbcf run on x86_64-linux 1

1 package failed to build:

sigal

2 packages built successfully:

python310Packages.pilkit
python311Packages.pilkit

sigal's failure is unrelated to this PR.


Getting the tag name of release

I have this workflow:
name: Publish the Debian Package

on:
  release:
    types: [published]

jobs:
  publish-deb-package:
    name: Build and publish the Debian package
    runs-on: ubuntu-latest
    container:
      image: docker://dragoncomputer/dragonfire:latest

    steps:
      - uses: actions/checkout@v1

      - name: Cache pip packages
        uses: actions/cache@v1
        with:
          path: /root/.cache/pip
          key: ${{ runner.os }}-pip-${{ hashFiles('**/setup.py') }}
          restore-keys: |
            ${{ runner.os }}-pip-

      - name: Install dependencies
        run: |
          pip3 install -e .

      - name: Generate the Debian package
        run: |
          dpkg-buildpackage -us -uc
          cd ..
          echo ${{ github.ref }} | cut -c12- | { read version; }

      - name: Upload to release
        uses: JasonEtco/upload-to-release@master
        with:
          args: dragonfire_${version}_amd64.deb
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

With echo ${{ github.ref }} | cut -c12- | { read version; } I aim to get 1.0.7 from refs/tags/v1.0.7(which is the output of the value of github.ref) but passing to args: seems impossible. dragonfire_${version}_amd64.deb resolves into dragonfire_${version}_amd64.deb while either dragonfire_1.0.7_amd64.deb or dragonfire__amd64.deb expected.
How can I achieve what I'm trying to achieve here?

Try using ${{ github.event.release.tag_name }}
I use that for my workflow without issues.

@Andre601 but tag name has v like v1.0.1 and the version's itself has not 1.0.1. I achieved that with this.


SEAB-5422: Don't display certain Events when the referenced entry is unpublished

Description
This PR makes certain Events not visible to the public when the associated Entry is unpublished, by changing the db query logic in the webservice EventDAO object.
The new public visibility rules are described in the following comment:
https://github.com/dockstore/dockstore/pull/5736/files#diff-edaf1d7e4c35dad540477c7a34f5fd00b636cd0d7e93a10849e1337318dbab23R121-R127
Basically, PUBLISH_ENTRY/UNPUBLISH_ENTRY and COLLECTION events are perpetually visible, other entry-related events are visible only when the entry is published, and otherwise, it works mostly the same as before, almost everything else is visible.
In other words, if an entry is unpublished, certain entry-related events (currently, just ADD_VERSION_TO_ENTRY events) become not visible (except to admins and the initiator user), and they become visible again when the entry is republished.
The ticket proposed making entry-related events permanently not visible if they pre-date the last entry unpublish date.  This scheme implemented here is less sophisticated than what the ticket proposed, but the team thought it was ok, and it's simpler and requires less infrastructure, so I went with it.
Review Instructions
Create a workflow/notebook on qa, tag it, wait for the tag to appear on qa, publish it, and then log out and view your profile.  All events that describe your actions on the entry should be visible.  Then, unpublish the entry, log out, and view your profile.  The event that describes the tag should no longer be visible.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5422
Security and Privacy
This PR changes the visibility of Events, making it slightly tighter than previously, with the exception that it explicitly allows the user to see events that they were the target of (subject to the other query constraints).
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that you pass the basic style checks and unit tests by running mvn clean install
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
[x] If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
[x] Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
[x] Do not serve user-uploaded binary images through the Dockstore API
[x] Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
[x] Do not create cookies, although this may change in the future
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

Basically, PUBLISH_ENTRY/UNPUBLISH_ENTRY and COLLECTION events are perpetually visible, other entry-related events are visible only when the entry is published, and otherwise, it works mostly the same as before, almost everything else is visible. In other words, if an entry is unpublished, certain entry-related events (currently, just ADD_VERSION_TO_ENTRY events) become not visible (except to admins and the initiator user), and they become visible again when the entry is republished.
The ticket proposed making entry-related events permanently not visible if they pre-date the last entry unpublish date. This scheme implemented here is less sophisticated than what the ticket proposed, but the team thought it was ok, and it's simpler and requires less infrastructure, so I went with it.

:+1:


Support for Turbo, Rust based webpack successor

Let's support https://turbo.build/.

Turbo is an incremental bundler and build system optimized for JavaScript and TypeScript, written in Rust.

Why is Turbopack blazing fast?
Turbopack’s speed comes from its incremental computation engine. Similar to trends we've seen in frontend state libraries, computational work is split into reactive functions that enable Turbopack to apply updates to an existing compilation without going through a full graph recomputation and bundling lifecycle.
This does not work like traditional caching where you look up a result from a cache before an operation and then decide whether or not to use it. That would be too slow.
Instead, Turbopack skips work altogether for cached results and only recomputes affected parts of its internal dependency graph of functions. This makes updates independent of the size of the whole compilation, and eliminates the usual overhead of traditional caching.

Another Rust-based bundler RSpack. Its USP is compatibility with Webpack plugins and config, which might make it a better fit for Shakapacker.

Another Rust-based bundler RSpack. Its USP is compatibility with Webpack plugins and config, which might make it a better fit for Shakapacker.

PR would be great, @triskweline

Please don't.

@lunaisnotaboy Any reason?

Please don't.

Note this is https://github.com/vercel/turbo not https://github.com/hotwired/turbo 😄 not sure if that's what you were worried about?
I'm all for making React + Rails on par with Next.js in terms of bundler/compiler, loving the SWC add-on already 🙌🏻

Another Rust-based bundler RSpack. Its USP is compatibility with Webpack plugins and config, which might make it a better fit for Shakapacker.

https://www.rspack.dev/guide/migrate-from-webpack.html

Closing as no movement. Looking at Turbo it positions itself as a replacement to Webpack so can't quite support it like we do with SWC and esbuild loaders so don't see this being a change on the horizon

@tomdracz should we have another task for support for https://www.rspack.dev/?

It would be great if Rspack could be supported as well.
We're investigating migrating away from webpack, and rspack seems like a solution that potentially might make it least painful.


Upload zip/tar files should not open them

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.84.2
OS Version: N/A - vscode-dev

Steps to Reproduce:

Upload/Drag & Drop zip/tar file
It will try to open it as well in text editor although files like that cannot be opened.

I believe it comes from: https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/files/browser/fileImportExport.ts#L195
It always open in case of a file, no matter which file it is.

Duplicate https://github.com/microsoft/vscode/issues/168809


Are meeting times correct in the team-compass?

Describe the bug
I tried to drop by a meeting last Wednesday as seen here: https://compass.executablebooks.org/en/latest/meetings/index.html
... but it didn't seem that there was anyone there, and those agendas aren't updated since earlier this year.  Perhaps I'm looking at the wrong place, or has "12:00" in Google Calendar made me 12-hours off by some chance?  I tried to drop by at<PHONE_NUMBER> to the jitsi seen in those agenda documents.
Reproduce the bug
????
List your environment
???

Hi @rkdarst the current meeting time is correct, and we did have the meeting then! The calendar is being shown in PST, however, which I just made #8 to highlight that.
Ideally the embedded calendar would be shown in the users timezone, but a quick search seems to show this might be somewhat involved. That would be a great little sphinx-extension!
Hopefully that note in #8 helps, and can close this issue when it is merged in. 🚀

Ah, I see.  I assumed, without any other information and not looking too much, that it was a local timezone.
I didn't see the timezone anywhere, but looking again there are two ways I could have known:

&ctz=ctz=America%2FLos_Angeles URL parameter in the iframe.
If I click on the event in the calendar and then click on more information.
(it wasn't lost on me that 12:00 EEST was a quite bad time, so I did spend some time looking to try to figure out what I was missing...)

If I remove the ctz parameter from the calendar URL, it does show in my timezone correctly... so maybe try removing that if that does what you need?
Thanks, I'll try to come to a future meeting!

I am certain I checked that and it didn't work. Can verify that trying now, it does work! 🤷♂
I have updated #8 with that approach, thank you! Looking forward to seeing you there. :)


test_cmds fails with python 3.3.1

What steps will reproduce the problem?
1. download plac-0.9.1.tar.gz from pypi
2. install to python 3.3.1 with
    py -3.3 setup.py install
(this is equivalent to c:\python33\python.exe setup.py install)

3. cd plac-0.9.1
   py -3.3 test_plac.py

What is the expected output?

A message telling all ok or no output at all

 What do you see instead?
D:\tmp\plac-0.9.1\doc>py -3 test_plac.py
Running test_batch
Running test_cmd_abbrevs
usage: test_plac.py {help,commit} ...
test_plac.py: error: No command 'foo'
Running test_cmds
Traceback (most recent call last):
  File "test_plac.py", line 230, in <module>
    maybegen = test()
  File "test_plac.py", line 184, in test_cmds
    expect(SystemExit, plac.call, cmds, [])
  File "test_plac.py", line 18, in expect
    func(*args, **kw)
  File "C:\Python33\lib\site-packages\plac-0.9.1-py3.3.egg\plac_core.py", line 3
09, in call
    cmd, result = parser_from(obj).consume(arglist)
  File "C:\Python33\lib\site-packages\plac-0.9.1-py3.3.egg\plac_core.py", line 1
89, in consume
    args = [getattr(ns, a) for a in self.argspec.args]
AttributeError: 'ArgumentParser' object has no attribute 'argspec'

What version of the product are you using? On what operating system?
plac 0.9.1
On windows xp sp3

Please provide any additional information below.
Installing and testing to python 2.7 shows no error.

Running test_plac.py in py 3.3.1 with  pytest 2.3.5 tells that it is the only
test failing in the file, (besides the one for sqlalchemy, which fails because
the module is missing)

Additionally, deprecation warnings are seen for module imp.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 9 May 2013 at 10:49

Fixed in 0.9.3


changed order and timeout for openshift-drools-hacep

makes only sense to merge after https://github.com/kiegroup/droolsjbpm-build-bootstrap/pull/1004 was merged


Package.getStylesheetsPath is deprecated.

Store package style sheets in the styles/ directory instead of stylesheets/ in the project-switcher2 package
Package.getStylesheetsPath (/usr/local/share/atom/resources/app.asar/src/package.js:460:9)
Package.getStylesheetPaths (/usr/local/share/atom/resources/app.asar/src/package.js:471:32)
Package.loadStylesheets (/usr/local/share/atom/resources/app.asar/src/package.js:453:38)
<unknown> (/usr/local/share/atom/resources/app.asar/src/package.js:183:19)
Package.measure (/usr/local/share/atom/resources/app.asar/src/package.js:163:15)
Package.load (/usr/local/share/atom/resources/app.asar/src/package.js:177:12)

Done ;] I'll move on to other deprecated calls and fix then soon.