Compilation error when accessing assigns inside a case block if followed by an eex block accessing assigns inside an HTML tag

I got a compilation error when a case block is followed by an eex block accessing an assigns, but only when the last is enclosed in an HTML tag, like in the following basic example
This code rises a compilation error:
# _my_partial.eex.drab

  <%=
    title =
        case @user.status do
            "1" -> "Enabled"
            "0" -> "Disabled"
            _   -> "Undefined"
        end
    # do something with `title`
  %>

  <%=
    status = @user.status
    # do something with `status`
  %>

Error:
== Compilation error in file lib/my_app_web/views/test_view.ex ==
** (FunctionClauseError) no function clause matching in Macro.do_traverse_args/4

    The following arguments were given to Macro.do_traverse_args/4:

        # 1
        "1Enabled"

        # 2
        nil

        # 3
        #Function<18.28811459/2 in Macro.prewalk/2>

        # 4
        #Function<19.28811459/2 in Macro.prewalk/3>

    Attempted function clauses (showing 2 out of 2):

        defp do_traverse_args(args, acc, _pre, _post) when is_atom(args)
        defp do_traverse_args(args, acc, pre, post) when is_list(args)

    (elixir) lib/macro.ex:271: Macro.do_traverse_args/4
    (elixir) lib/macro.ex:243: Macro.do_traverse/4
    (elixir) lib/enum.ex:1397: Enum."-map_reduce/3-lists^mapfoldl/2-0-"/3
    (elixir) lib/macro.ex:263: Macro.do_traverse/4
    (elixir) lib/macro.ex:258: Macro.do_traverse/4
    (elixir) lib/enum.ex:1397: Enum."-map_reduce/3-lists^mapfoldl/2-0-"/3
    (elixir) lib/macro.ex:263: Macro.do_traverse/4
    (elixir) lib/enum.ex:1397: Enum."-map_reduce/3-lists^mapfoldl/2-0-"/3

Instead, if the case block isn't followed by an HTML enclosing tag, or if both the exx blocks are inside the same HTML enclosing tag, it compile without errors
this code will compile without errors:
# _my_partial.eex.drab

  <%=
    label =
        case @user.status do
            "0" -> "Disabled"
            "1" -> "Enabled"
            _   -> "Undefined"
        end
  %>

  <%=
    status = @user.status
  %>

also this code will compile without errors:
# _my_partial.eex.drab

  <%=
    label =
        case @user.status do
            "0" -> "Disabled"
            "1" -> "Enabled"
            _   -> "Undefined"
        end
  %>

  <%=
    status = @user.status
  %>

It will compile without error also when if is used instead of case, followed by the eex block encolsed in the HTML tag:
# _my_partial.eex.drab

  <%=
    label =
        if @user.status == "1" do
            "Enabled"
        else "Disabled"
        end
  %>

  <%=
    status = @user.status
  %>

Hey, thanks for reporting! It is because in this case Drab must inject  at the beginning of the expression - the bug must be in this code part.


Adding age bin 80-89 and 90+

Is it possible to add an age bin for 80-89 and another for 90+?
Our partners have indicated that this would add more granularity to the data given they test several individuals above 100 yo.

Done! I added new 80 - 89, 90 - 99, and 100+ bins.

@ddooley will refresh the app with @griffie's changes

This is now done!


Setup a node with hardhat

Setup a local node using hardhat and the https://github.com/gnosis/safe-contracts repository.
Additionally, deploying locally other chains such as BSC is also possible. Look into what is possible with hardhat and syncing with other chains.

In my opinion this repository should only require to provide a rpc endpoint. To run a node as a fork of an existing chain you would use the "forking" from hardhat: https://hardhat.org/hardhat-network/guides/mainnet-forking.html But I don't think this should be the focus of this repository

Agreed.


*added endpoint handbook

Description
Added endpoint handbook to explain creation of each type of endpoint
Pull Request Type

[X] Documentation content changes
[ ] Bugfix / Missing Redirects
[ ] Docusaurus site code changes

PR Checklist

[X] The commit message follows our guidelines included in the CONTRIBUTING.md
[X] All tests of Lint, cspell and check-content pass. (How to launch them?)
[X] No sensible content has been committed

LGTM


Fix version check for defaults chart settings route

Fix #930
Backport of #937

It should be good, the fix was backported, I'm surprised the tests aren't working in this case.


Question: How do you make migrations / sync structure between live / dev ?

Do you have a best practice for updating/syncing changes from a local database with the production environment? Is there a way to generate migrations?

We are using TypeORM under the hood, which has all the necessary tools to run the database migrations.
They run automatically on server start as we have syncronize: true.
https://github.com/typeorm/typeorm/blob/master/docs/migrations.md


[attempt-1] Generic NFT safe

This is a draft for a generic NFT safe module.

Will create the MR first to my fork, get review and then reopen if appropriate


Update go.mod to fix v0.4.7 release

Pretty sure goreleaser is failing because go.mod isn't up to date
failure: https://github.com/sigstore/scaffolding/actions/runs/3018886856
Signed-off-by: Priya Wadhwa<EMAIL_ADDRESS>
Summary

Release Note

Documentation

@priyawadhwa I b0rk3d the install when trying to update the knative set up to support k8s v1.25 which required updates to the metallb and I think that's causing some grief at the moment.
I'm working on the fix, but for some reason I can't run Kind on my local mac anymore, so there's that which is nice :)

I can't run Kind on my local mac anymore

😭
haha no worries!! good luck!!

If you want to roll back to using a previous action, we could revert the action to using this one here instead of main:
https://github.com/chainguard-dev/actions/commit/7d1eb557f464d97e5fe5177807a9226141eb9308
Here:
https://github.com/sigstore/scaffolding/blob/main/.github/workflows/fulcio-rekor-kind.yaml#L83
Let me put a PR together for that, sorry!!

This should revert to a known good version.
https://github.com/sigstore/scaffolding/pull/345


Fix LVM-not-detected log rendering

Oneliner to make the warning log line render the error message.

/cherry-pick 4.13

/cherry-pick release-4.13


Can python api for AzureFile support to upload local directory to remote?

Which service(blob, file, queue) does this issue concern?
Azure File
Which version of the SDK was used? Please provide the output of pip freeze.
azure-storage-common==1.3.0
azure-storage-file==1.3.1
azure-storage-nspkg==3.0.0
What problem was encountered?
Can python api for AzureFile support to upload a local directory to remote?
downloading folder is the same requirement
If not, why?
I was using web_hdfs python api which support this behavior
Have you found a mitigation/solution?
If this function is not provided by api , we may recursively invoke create_file_from_path() by folder's hierarchy, but I believe it is too strange

Hi @Cherishty, thanks for reaching out!
I understand that you have a need for uploading/downloading entire directories, but I do not believe the SDK is the right place for that functionality. This is because the SDK is only supposed to be a thin wrapper over the REST API, so the user should be responsible for enumerating the directory and making the decisions about the behavior(ex: whether or not to follow symbolic links). Listing directories should be straightforward.
If you would like to use a tool to upload/download directories, please consider AzCopy, or the experimental AzCopy V2. Here is a guide.

Hi @Cherishty, I agree that a batch SDK could be useful to customers. We currently have this item on our backlog but unfortunately have no timeline yet. Thanks!


CLI for filtering features, fio filter

I started writing this as a standalone script and realized it might be useful as a built in fio command.
The fio filter command reads GeoJSON features from stdin and writes the feature to
stdout if the provided expression evalutates to True for that feature.
For example to create a geojson feature collection containing large polygons only:
fio cat data.shp \
| fio filter "f['properties']['area'] > 1000.0" \
| fio collect > large_polygons.geojson

The python expression is evaluated in a restricted namespace, what is allowed in that namespace is TBD. For now it's just (sum, min, max), the math module, and an object f representing the
feature to be evaluated. I could see shape from shapely and many others being useful.
The whole approach of eval in a restricted namespace seems safe enough for a command line tool but there might be other DSLs that could accomplish the same things (snuggs?)

@perrygeo Awesome idea, definitely. What would you think about changing the query expressions to either 1) align with jq filters, so '.properties.area > 1000.0' instead of "f['properties']['area'] > 1000.0", or 2) extend snuggs expressions in a Hy-like manner like '(> (. (. f properties) area) 1000.0)'?

conceptually, I like the lisp approach. It's consistent with rio calc and and hy or extended snuggs gives us a built in parser.  We could directly leverage python functions, math.sin, shape, etc. But I worry the syntax is a bit esoteric and might scare off some users. Dot notation really doesn't translate to LISP well.
With the jq expressions, they certainly look nice and clean. But could we extend them to support python functions? And how would we parse and evaluate them? At first glance I don't see any existing libraries for using that grammar in python.

Yeah, lisp isn't the right fit here. But I do think that dot accessors are much cleaner in this case than Python dicts and won't require as much attention to quoting and escaping. How about wrapping features in a class that provides getattr() access and surfacing that as f?

@sgillies :+1:  to the getattr() idea, keeps things simple.
I'll give that a shot along with some tests here shortly.

What do you think about adding a dependency to https://github.com/dsc/bunch ?

@perrygeo I think bunch looks very good. Maybe we should bring it all the way into the core for 1.7?

Looks nice but tests don't pass on Python 3. bummer. And there are also performance concerns with copying a dict and creating a bunch of new objects - not a deal breaker for filter but it might be for including in the core.

@perrygeo Asked about my opinion on the use of Python expressions in #273 and since my answer applies to that issue and this in-progress PR, I'll answer here.  I recognize my comments below recommend giving the user mostly unsupervised access to eval() and almost the entire underlying Python environment, but I'm not trying to push these changes on this feature, so feel free to disagree and push back.  This is merely what I have learned in other projects.
I'm in favor of using Python expressions and wrote a sed-like utility called pyin, that is almost identical to this command, because I got sick of looking up sed syntax when I knew how to do it in Python but didn't want to write a script every time.  I went through several iterations in that project and came to some conclusions that I think apply here, although keep in mind that I don't think anyone else is using pyin.

Allowing multiple chained expressions that maintain state between each expression's execution is really powerful.
Don't spend too much time scoping eval().  Python has all kinds of weird ways to access objects and its just not worth the time.  The benefits of allowing users to do whatever they want far outweigh the negatives.
Don't shy away from eval() because its "dangerous".  I have had far more mishaps with a poorly composed rm something*/whatever* than I have composing expressions for pyin and other tools that execute arbitrary code.  Any setup.py executes arbitrary code, so users can be trusted to safely compose Python expressions for filtering dictionaries.  Besides, they're in the terminal anyway where there are any number of bad things to do.
Don't try to be clever about exposing safe ways for the user to define an environment and import modules before evaluating expressions.  Just let them do whatever they want.  py has a good method for auto-importing objects.
Think about the scope of a command that uses eval() before thinking about all the bad stuff users could do.  Sure, the expression __import__('os'); os.remove('*') will do bad things, but why would I type that when I'm trying to filter features?  Anyone attempting to do something nefarious already has access to the computer at this point so taking it upon ourselves to block this syntax is pointless and unnecessarily constrains the user.
A lisp requires all users to learn a new syntax, but Fiona is advertised as a Python library, so a huge percentage of its users already know how they would filter the features in a script.  Expressions just let them do it without having to write the overhead.

As far as scoping the eval() environment goes, its worth limiting direct access to some objects to block the really obvious bad stuff and to help keep people from doing anything really strange.
Using pyin as an example, here's some weird stuff you can do - note that json is automatically imported:
$ fio cat tests/data/coutwildrnp.shp \
    | pyin \
        "json.loads(line)" \
        "'Wilderness' in line['properties']['NAME']" \
        "int(line['properties']['STATE_FIPS']) < 9" \
        "{p: {k.lower(): v for k, v in val.items()} if p == 'properties' else val for p, val in line.items()}" \
        "json.dumps(line)" \
            | fio collect > OUT.geojson

Here's what's going on:

Use fio cat to print GeoJSON features to stdout and pipe them to pyin.
Convert each line to a dictionary.
Only process features where the substring 'Wilderness' appears in the 'NAME' property.
Only process features where the state FIPS code is < 9.
Convert all the field names to lowercase.
Serialize as a JSON string.
Use fio collect to dump to a GeoJSON file.

It's not pretty, but its easy to compose each step in the moment.  Making the property names lowercase took a minute to figure out though, so there's an argument for exposing properties in a separate variable in the eval() environment.  In another project that structures data as a dictionary, I use the data object as the local scope for eval and then copy the entire dict inside an additional variable, but I have been considering removing the fields from the scope and just interacting with the data dictionary because its difficult to rebuild the feature after all the expressions have been evaluated.  This would be like doing eval("'Wilderness' in properties['NAME']", global_scope, feature).  Munch is a good middle-ground.

@geowurster  My intention with limiting the scope in eval was primarily to make it clear that no advanced data manipulations or anything else should be attempted in the rio filter expression - only an expression that evaluates to True/False with no side effects. If anyone would be tempted to, say, rename fields or manipulate the data in any way, I'd point them to pyin or the hypothetical future rio calc #273.
Security is a secondary concern but, as you point out, there are convoluted ways of recovering builtins and such that eval is never going to be safe. Oh well, you're at the command line. If you're calling this with arbitrary user input, you're doing it wrong! We'll just have to make that clear.


Optimize cu_seq_lens calculation for forward pass when using packing

monkeypatch the forward call for LlamaForCausalLM and LlamaDecoderLayer to accept cu_seq_len as a keyword arg

fixed as part of #381


Undocumented v6 breaking change: PrecacheController.install/active

Hi,
Not 100% sure but it seems like in the code and TS typedefs, the PrecacheController install/activate methods now take the event as param, while it wasn't the case before.
Not passing the event lead to console errors after an upgrade:

Uncaught TypeError: Cannot read property 'waitUntil' of undefined

FYI the doc seems wrong to me and this is also not mentioned on the v5-v6 breaking changes, and might be useful to add/fix ;)
https://developers.google.com/web/tools/workbox/modules/workbox-precaching

thanks :)


Consider interface for asynchronous requests

The purpose of this ticket is to track discussion on this feature's impact to the Public API.

What would be a good way to implement this you think? If we are using python 3.x, asyncio looks quite promising. Here is some example/comparison with gevents and tornado: https://hackernoon.com/asynchronous-python-45df84b82434
There is also quora's asynq library. I don't think we should build our own async library for uplink. If we want to support python 2, we might not be able to use asyncio.


Fixes #1635

Description

The busywork/counters/driver is modified to work correctly with NOOPS
networks; checkAgreement is disabled, and logging (interlock) only looks at
the first peer.
Other minor enhancements:

checkAgreement now logs multiple peers concurrently to reduce test time
driver clients now all use a unique random seed

This change is limited to tools/busywork. None of the peer Go code is modified by this PR.
Motivation and Context

Fixes #1635
How Has This Been Tested?

I have been testing this for a few days while profiling NOOPS networks.
Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[] I have run goimports, go vet, and golint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives.  The goal is clean, consistent, and readable code.

Signed-off-by: Bishop Brock<EMAIL_ADDRESS>

I don't understand how my changes could cause a failure of a Behave test. Note that PR #1700 fails with the same error - I think there must be a problem with the Behave tests.

Test #680 is notoriously flaky.  I have learned to ignore the failure as meaningless, so I wouldn't be concerned if you were not changing in the areas of coverage by the test.  I can restart it for you, however.

@ghaskins - I'm sure it's not my fault, but please resubmit the CI check anyway.

@bcbrock looks fine this time

LGTM
Reviewed-by: Greg Haskins<EMAIL_ADDRESS>

@ghaskins Thank you

Test Jenkins comment


Restrict resources related to profiles behind role

Description
Add new role and add checks what Create Update Delete operations for related to profiles resources is hidden behind it.
Related issues
Testing
Manual and unit tests.
FHIR Team Checklist

[ ] Update the title of the PR to be succinct and less than 50 characters
[ ] Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
[ ] Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
[ ] Tag the PR with Azure API for FHIR if this will release to the managed service
Review squash-merge requirements

Semver Change (docs)
Feature (it's a extension of existing functionality)

@brendankowitz any chance you can have review it again?


Check for a Gemfile before running pod commands - fixes #5

Err, so I don't know too much about shell scripting, but in writing out a quick prototype this would check for a local Gemfile and run the right commands if it exists.

Thanks, I think this PR is a perfect fix of #5


yargs.scriptName is not a function

Describe the bug
This is the first time I'm trying it locally and it's not working at all. I tried:

bunx export-size mlly
npx export-size mlly
npm install -g export-size; export-size mlly

Reproduction
export-size mlly
System Info
System:
    OS: macOS 13.6
    CPU: (16) x64 Intel(R) Core(TM) i9
    Memory: 56.81 MB / 16.00 GB
    Shell: 3.6.1 - /usr/local/bin/fish
  Binaries:
    Node: 18.17.0 - /usr/local/bin/node
    Yarn: 1.22.11 - /usr/local/bin/yarn
    npm: 9.6.7 - /usr/local/bin/npm
  Browsers:
    Chrome: 117.0.5938.132

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

+1


Functional Test using upgrade-manager

Fixes #10
Functional test will now use upgrade-manager instead of argo to rotate the nodes
Testing

Ran test manually, passed

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   66.23%   66.23%
=======================================
  Files           5        5
  Lines         616      616
=======================================
  Hits          408      408
  Misses        154      154
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409f8a3...d92cd81. Read the comment docs.


Blaze Enchanter doesn't work

Version: beta-0.1.5
This is what I'm getting in my survival world:

And this is what I get in creative mode:

Thanks for reporting.
I have a flight to another city this morning for my brother's graduation and my aunt's birthday, and there will be no updates or fixes until the 28th.


Add a convenient method getting a string from Request.

Here's a very simple method for making getting the string from a request a little bit easier for users, it shouldn't complicate or slow anything down as AFAIK.

Is there a faster way I'm not seeing by not calling as_reader?
Because it's only utf-8, strings should it be called to_utf8_string to clear up confusion with developers?

Thanks,
Grant Handy

Sorry to leave this languishing for so long, it seems like I wasn't getting email notifications for this repository! I'll take a look in a short while.

Thanks for submitting this @grantshandy, I appreciate you taking the time to open the PR in the first place.
Unfortunately I'm not minded to merge this, for a couple of reasons, mainly that I think a to_string() method is too high-level an abstraction for tiny-http. There's already a lot going on in the background:

Calling .as_reader() first checks if the client is expecting a 100 Continue before it sends its body, if so, sends that response back.
Calling .read_to_string() ultimately invokes read_to_end() on the incoming stream from the client. This blocks until an EOF (in this case closing the connection).
Allocating a String and reading from that incoming stream, finally doing a UTF-8 validity check on the whole buffer before returning.

We're also making a couple of assumptions:

That the client will send the full contents of its request body in a timely manner.
That we have enough memory to hold the full contents of that body.

Everything I've written above is stuff that 'has to happen', for an HTTP server to work, but in my opinion it's something that would be better suited to a layer on top, like Rouille, which has such a read_to_string method on its RequestBody type.

No problem! It seems I just misunderstood the scope of the project. Thanks!


Feature request to support major version, minor version only replacement?

Often, some files like README shouldn't be updating every full version but only updated when major version is updated (e.g., v1 instead of v1.2.3).
semver package has already a parse function that can be used to parse.
I can contribute, but want to hear thoughts.

Probably the best way would be to extend the semantic-release context object used in the template, splitting the major.minor.patch into the following:
nextRelease.major
nextRelease.minor
nextRelease.patch

enabling __VERSION__ = "v${nextRelease.major}" similar to what you want.

Would get this for free if it was extended in semantic-release.

Something along the lines of https://github.com/semantic-release/semantic-release/pull/2128.

But, it'd still require some changes in this repo for detection/confirmation, i think?
v1.2.3 -> v1.2.4 is v1 -> v1
v1.2.3 -> v2.0.0 is v1 -> v2
How would you set up?
            "results": [
              {
                "file": "foo/__init__.py",
                "hasChanged": true,
                "numMatches": 1,
                "numReplacements": 1
              }
            ],

And thanks for putting versions in the upstream. That'd be super useful in other plugins.

or does this still work maybe since it replaced the version (same version to same version)?

I think it would still work.

And thanks for putting versions in the upstream.

We'll see if I can figure out the failing tests. 😄
Maybe fresh eyes tomorrow will help!

__VERSION__ = "v${nextRelease.version.split('.')[0]}"

Should get what you want.

Hmm, I'm actually getting error when the major version does not change.

example log: here
releaserc config: here

[4:16:47 PM] [semantic-release] › ✖  An error occurred while running semantic-release: Error: Expected match not found!
Error: Error: Expected match not found!
- Expected
+ Received

  Array [
    Object {
      "file": "Dockerfile",
-     "hasChanged": false,
+     "hasChanged": true,
      "numMatches": 1,
-     "numReplacements": 0,
+     "numReplacements": 1,
    },
  ]
- Expected
+ Received

  Array [
    Object {
      "file": "Dockerfile",
-     "hasChanged": false,
+     "hasChanged": true,
      "numMatches": 1,
-     "numReplacements": 0,
+     "numReplacements": 1,
    },
  ]
    at /home/runner/work/_actions/cycjimmy/semantic-release-action/v2/node_modules/@google/semantic-release-replace-plugin/dist/index.js:98:35
    at step (/home/runner/work/_actions/cycjimmy/semantic-release-action/v2/node_modules/@google/semantic-release-replace-plugin/dist/index.js:59:23)
    at Object.next (/home/runner/work/_actions/cycjimmy/semantic-release-action/v2/node_modules/@google/semantic-release-replace-plugin/dist/index.js:40:53)
    at fulfilled (/home/runner/work/_actions/cycjimmy/semantic-release-action/v2/node_modules/@google/semantic-release-replace-plugin/dist/index.js:31:58) {
  pluginName: '@google/semantic-release-replace-plugin'
}

probably need to remove the results from your config as it will depend on the version.

doesn't that mean no validation?

After removing the config, I'm still getting the error.

[5:31:47 PM] [semantic-release] › ✖  An error occurred while running semantic-release: Error: Expected match not found!
Error: Error: Expected match not found!
- Expected
+ Received

  Array [
    Object {
      "file": "Dockerfile",
-     "hasChanged": false,
      "numMatches": 1,
-     "numReplacements": 0,
    },
  ]
- Expected
+ Received

  Array [
    Object {
      "file": "Dockerfile",
-     "hasChanged": false,
      "numMatches": 1,
-     "numReplacements": 0,
    },
  ]

Removing the "results" field completely was successful, now I guess there's no validation then.


Not overwrite networkdata if it already exists in BMH

User Story
As a [developer/user/operator] I would like to management IP allocation outside of metal3, when BMH already has a network data specified, it should not be overwritten.
Detailed Description
I want to manage IP allocation by myself, currently the node IP is either allocated by metal3-ipam or using dhcp, but I don't want both, there is no way to achieve that as far as I know, I see BMH support specify networkData, but when I set it, it will be overwritten by metal3machine controller, could we add an option to avoid it?
I only want to customize network data, the dataTemplate is still needed, so I cannot leave networkData empty, as the doc says If the dataTemplate field is set but either the renderedData, metaData or networkData fields in the status are unset, then the Metal3Machine controller will wait until it can find the Metal3Data object and the rendered secrets. It will then populate those fields.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
/kind feature

Have you tried not referencing networkData on the Machine/MachineTemplate level ? Does it overwrite the secret reference of the BMH even when you only specify networkData in the BMH and nowhere else ?

We have to investigate this but on the first glance this is a valid use-case, I am not sure when would this be implemented.
Would you be willing to implement this @ydp ?
/triage accepted

/help

We have to investigate this but on the first glance this is a valid use-case, I am not sure when would this be implemented. Would you be willing to implement this @ydp ? /triage accepted

Hi @Rozzii  Thanks for reply, I would love to implement, my use case is that I am doing an IPam completely outside of metal3, more specifically, I would like each machine get a fixed IP even before cluster provision, I personally not sure if this is a best practice in industry, but based on my understanding, since we are managing bare metal, it would be much more convenient if machine has a fixed IP. This is why I want to set the NetworkData in BMH instead of getting it from metal3machine.
I have already implemented a way to do it here https://github.com/ydp/cluster-api-provider-metal3/commit/e29874c09253032c7d25c8fd17aceab3ac9b5a6c ,  but this might be too hacky? because I used naming to decide whether there is user specified network data. If you have any better idea, I would love to implement it.
BTW, at first, I also try to let the metal3machine controller not wait for network data, it can still continue even if network data empty, but this would change the current behavior.

I think I just found that the API docs is not accurate:

If the dataTemplate field is set but either the renderedData, metaData or networkData fields in the status are unset, then the Metal3Machine controller will wait until it can find the Metal3Data object and the rendered secrets. It will then populate those fields.

Because then I tried again, that when the networkData field in dataTemplate is not set, metal3machine controller will not wait for it.
If it's nil here https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/baremetal/metal3data_manager.go#L186 , https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/baremetal/metal3data_manager.go#L211 metal3Data will be considered ready, then it passes the check https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/baremetal/metal3machine_manager.go#L1587 ,
see my data:
apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: Metal3Data
metadata:
  creationTimestamp: "2023-07-19T18:18:50Z"
  finalizers:
  - metal3data.infrastructure.cluster.x-k8s.io
  generation: 2
  labels:
    cluster.x-k8s.io/cluster-name: test1
    cluster.x-k8s.io/control-plane: ""
    cluster.x-k8s.io/control-plane-name: test1
  name: test1-controlplane-template-0
  namespace: default
  ownerReferences:
  - apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
    controller: true
    kind: Metal3DataTemplate
    name: test1-controlplane-template
    uid: d4668ea0-841b-4724-adbe-dd51587fee51
  - apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
    kind: Metal3DataClaim
    name: test1-controlplane-clvw9
    uid: 72deffbf-b884-4139-9ea3-f1c621f45bd8
  - apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
    kind: Metal3Machine
    name: test1-controlplane-clvw9
    uid: 6eff76fb-b928-4547-90d8-a297d0522684
  resourceVersion: "2375"
  uid: a9a0f9ce-29d4-4b54-bac6-b84ef06623f4
spec:
  claim:
    name: test1-controlplane-clvw9
    namespace: default
  metaData:
    name: test1-controlplane-clvw9-metadata
    namespace: default
  template:
    name: test1-controlplane-template
    namespace: default
status:
  ready: true

So, looks like my code is not needed, and I don't have to implement anything. Maybe we should change the doc a little?


WIP -- CWL: support restarts

Support restarting a cwltoil workflow with the --restart flag,
updates work by @tetron in #1025 and fixes #1100. Adds a test
to demonstrate restart capability by manipulating paths to cause the
initial run of the revsort workflow to fail.
Still a work in progress as the test fails consistently when restarting.
I could use help debugging what I'm missing to correctly restart to
finish this. If you run the test:
make test tests=src/toil/test/cwl/cwlTest.py::CWLTest::test_restart

It completes the expected failure step, but the restart fails with an
EOFError when unpickling a job store (similar to #676 and #1039):
INFO toil.jobStores.fileJobStore: Path to job store directory is '/tmp/user/1001/toil-test-toil.test.cwl.cwlTest.CWLTest-test_restart-l0vC5G/jobStore'.
INFO toil.common: Using the single machine batch system
WARNING toil.batchSystems.singleMachine: Limiting maxCores to CPU count of system (4).
WARNING toil.batchSystems.singleMachine: Limiting maxMemory to physically available memory<PHONE_NUMBER>).
INFO toil.common: Created the workflow directory at /tmp/user/1001/toil-c7c91877-c1bd-4a6e-b2c8-b23d0c3d90b7
WARNING toil.batchSystems.singleMachine: Limiting maxDisk to physically available disk<PHONE_NUMBER>8).
INFO toil.batchSystems.singleMachine: Setting up the thread pool with 40 workers, given a minimum CPU fraction of 0.100000 and a maximum CPU value of 4.
INFO toil.common: Written the environment for the jobs to the environment file
INFO toil.common: Caching all jobs in job store
INFO toil.common: 4 jobs downloaded.
INFO toil.jobStores.abstractJobStore: Checking job graph connectivity...
INFO toil.jobStores.abstractJobStore: 4 jobs reachable from root.
CRITICAL toil.jobStores.abstractJobStore: Repairing job: N/g/jobLYOvLb
INFO toil.jobStores.abstractJobStore: Discarding old statistics and logs...
INFO toil.jobStores.abstractJobStore: Job store is clean
INFO toil.realtimeLogger: Real-time logging disabled
INFO toil.leader: (Re)building internal scheduler state
INFO toil.leader: Checked batch system has no running jobs and no updated jobs
INFO toil.leader: Found 2 jobs to start and 1 jobs with successors to run
INFO toil.leader: Starting the main loop
INFO toil.batchSystems.singleMachine: Executing command: '/home/chapmanb/bio/toil/venv/bin/_toil_worker /tmp/user/1001/toil-test-toil.test.cwl.cwlTest.CWLTest-test_restart-l0vC5G/jobStore N/g/jobLYOvLb'.
INFO toil.batchSystems.singleMachine: Executing command: '/home/chapmanb/bio/toil/venv/bin/_toil_worker /tmp/user/1001/toil-test-toil.test.cwl.cwlTest.CWLTest-test_restart-l0vC5G/jobStore N/2/jobv9Osdj'.
toil.leader: The jobWrapper seems to have left a log file, indicating failure: N/2/jobv9Osdj
toil.leader: Reporting file: N/2/jobv9Osdj
toil.leader: N/2/jobv9Osdj:   ---TOIL WORKER OUTPUT LOG---
toil.leader: N/2/jobv9Osdj:   INFO:rdflib:RDFLib Version: 4.2.1
toil.leader: N/2/jobv9Osdj:   INFO:toil.jobStores.fileJobStore:Path to job store directory is '/tmp/user/1001/toil-test-toil.test.cwl.cwlTest.CWLTest-test_restart-l0vC5G/jobStore'.
toil.leader: N/2/jobv9Osdj:   Traceback (most recent call last):
toil.leader: N/2/jobv9Osdj:     File "/home/chapmanb/bio/toil/venv/local/lib/python2.7/site-packages/toil-3.5.0a1-py2.7.egg/toil/worker.py", line 316, in main
toil.leader: N/2/jobv9Osdj:       job = Job._loadJob(jobWrapper.command, jobStore)
toil.leader: N/2/jobv9Osdj:     File "/home/chapmanb/bio/toil/venv/local/lib/python2.7/site-packages/toil-3.5.0a1-py2.7.egg/toil/job.py", line 673, in _loadJob
toil.leader: N/2/jobv9Osdj:       return cls._unpickle(userModule, fileHandle)
toil.leader: N/2/jobv9Osdj:     File "/home/chapmanb/bio/toil/venv/local/lib/python2.7/site-packages/toil-3.5.0a1-py2.7.egg/toil/job.py", line 696, in _unpickle
toil.leader: N/2/jobv9Osdj:       return unpickler.load()
toil.leader: N/2/jobv9Osdj:   EOFError
toil.leader: N/2/jobv9Osdj:   Exiting the worker because of a failed jobWrapper on host kunkel
toil.leader: N/2/jobv9Osdj:   ERROR:toil.worker:Exiting the worker because of a failed jobWrapper on host kunkel
toil.leader: N/2/jobv9Osdj:   WARNING:toil.jobWrapper:Due to failure we are reducing the remaining retry count of job N/2/jobv9Osdj to 0
toil.leader: N/2/jobv9Osdj:   WARNING:toil.jobWrapper:We have increased the default memory of the failed job to<PHONE_NUMBER> bytes
toil.leader: Job: N/2/jobv9Osdj is completely failed

Thanks for any tips and ideas about how best to debug and proceed.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Jenkins, test this please.

Jenkins, test please

Jenkins, test this please.

The only failing test is CWL test_restart, you can see the test output here http://pastebin.com/UPqgjzLC.
It looks like these are the most relevant lines:
WARNING:toil.leader:X/y/jobxPa_0d:  INFO:cwltool:[job revtool.cwl] /mnt/ephemeral/tmp/tmpRYIG2q$ rev \
WARNING:toil.leader:X/y/jobxPa_0d:      /mnt/ephemeral/tmp/tmpCYsUeI/stg49ff26ed-3fbf-41ba-85bc-eac77910a205/whale.txt > /mnt/ephemeral/tmp/tmpRYIG2q/output.txt
WARNING:toil.leader:X/y/jobxPa_0d:  'rev' not found
WARNING:toil.leader:X/y/jobxPa_0d:  ERROR:cwltool:'rev' not found

Christopher -- thanks for looking at this one. That's right on, that's the new test I'm adding for validating restarts and I can't quite get things working for the restart so it still fails. The initial message in the PR has more details about where I'm stuck at -- the restart complains when unpickling a file and I'm not sure what needs to happen to avoid that problem and restart cleanly. Thanks for any pointers/ideas.

I see now, sorry about that! I've been walking over this and I think I'm getting closer. The job with the EOF error is actually run again despite 'failing completely', for some reason. The job is only run once when I run the pipeline with the forced error failing, so this points to some problem in the restart logic causing a duplicate job being issued.
More evidence of a scheduling error is that the job is run with the same command and unpickles the file successfully on the second try, whereas the file doesn't exist on the first try. It seems like the failing job was just run too early. My next step is identifying where exactly the job is being issued 2X.

Christopher -- thanks for the help debugging. The test job I wrote for this should submit the job multiple times:

First I manipulate the PATH to make the job fail (by moving rev, needed for the job to run, out of the PATH).
Then I fix the PATH and rerun the same job with --restart so it'll hopefully finish cleanly.
Then I run again with --restart to test for an expected failure (restarting on a finished job).

I'm not sure if that's relevant to what you're seeing or not but is the logic behind the tests. From the new code side, I'm now calling toil.restart() on the old directory instead of doing a new workflow. Perhaps there should be more tweaking/fixes from my side, I'm just not sure what to do. Thanks again for the help.

Hi Brad, the problem here seems to be a job being issued multiple times within the second step of your test when the workflow is called with --restart. Since the workflow runs correctly without forcing the initial failure I think this is a ```--restart`` problem, not a workflow or test problem.
When a workflow is running Toil determines what job to run next by looking a finished job's successors. In the --restart case we are seeing the EOF job being issued despite not being part of any finishing job's successors. The job fails, and is then being issued again (correctly this time) when its predecessor finishes.
Unfortunately, I'm out of the office this week and the next so I can't dedicate too much more time to debugging but I would look at the restart code to figure out how it determines which jobs are OK to run when restarting the workflow.  Does the CWL support implement its own restart logic? If so, that's where I would looks first.

You might want to pass --logDebug to the test. Maybe that will reveal something.

Hannes;
Thanks for all the comments. While responding to these I realized the underlying issue might be that cwltoil is exiting poorly for this failure case, and I moved discussion of this to #1122 with more details. I hope if we fix that it'll help here. Would you have any pointers about how best to improve failures with cwltoil runs so they're cleaner?

@chapmanb @cket I think this might now work, I fixed the big bug in toil that was preventing it working correctly. Hope this can be unblocked.

Benedict -- thanks so much for the fixes. This does resolve the problem and get this working correctly. Brilliant. I've updated the tests to synchronize with the latest changes and address Hannes' review and rebased this all into a single clean commit.
So, this looks great to me now and is ready to test/merge if anyone on the Toil team had time to review. Thanks again for all the help getting this working.

IT failed due to PyPI outage.


the full list of emoticons does not appear when they are selected in version 1.40.3

Please see issue https://github.com/klausw/hackerskeyboard/issues/686 for current status of the popup issues.


Add error message for reconstruct surface

Fixes #70
This PR adds an if clause in reconstruct_surface_from_pointcloud that indicates whether the used set of parameters was suitable to generate a surface mesh.

[x] demo.ipynb notebook still works
[x] error message is correctly displayed in terminal in interactive usage

Codecov Report
Patch coverage: 75.00% and project coverage change: -0.02 :warning:

Comparison is base (40215a4) 70.41% compared to head (c11d99c) 70.40%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   70.41%   70.40%   -0.02%
==========================================
  Files           8        8
  Lines         977      980       +3
==========================================
+ Hits          688      690       +2
- Misses        289      290       +1

Impacted Files
Coverage Δ

napari_process_points_and_surfaces/_vedo.py
73.56% <75.00%> (-0.13%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


A failure in an included build should be reported at the end of logging output

When I run a stand alone build (i.e. not a composite build), then Gradle collects all task failures and reports on them at the end of the build, after all of the tasks have completed. This way the failure reports are not interleaved with other logging output but are clearly summarised at the end of the logging output (ok, maybe "clearly" is a bit generous, but at least the summary is complete and the details are in one place at the end of the logging output) .
When I run a composite build, Gradle collects tasks failures for a particular build and reports on them when the tasks for that build have completed, regardless of whether other builds still have work to do. This means that these failure reports are interleaved with other output and can be lost.
Here's an example:
FAILURE: Build failed with an exception.

* Where:
Build file '.../child1/build.gradle' line: 3

* What went wrong:
Execution failed for task ':child1:go'.
> java.lang.RuntimeException (no error message)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 2s

> Task :child2:go
ping 1
ping 2
ping 3
ping 4

Notice the task output after the failure summary produced by tasks from other builds still running. When these tasks produce a lot of output and there are no failures from any of the tasks in those other builds, then the failure summary can be lost entirely.
Expected Behavior
Failure reporting should behave consistently regardless of whether I'm running a stand alone build or a composite build (including when I'm using source dependencies). The failures should be summarised in some form at the end of the logging output of the entire gradle invocation. It would be fine, and even good, if the failures also appear in some form in the logging output when they happen.
Current Behavior
Sometimes failures are reported at the end of the build, sometimes mixed in to the logging output, and sometimes spread across multiple locations in the output.

The changes in #5418 and #5474 rework error handling so that failures are collected only after all builds have completed and then reported.


[bug] Connected state lost when changing page

Link to minimal reproducible example
http://codeprovidedbelow.com
Summary
My Web3button is located in the header component of my nextjs website. When i log in or log out and stay on the same page, it works great.
However, if i log out, click on one of the main nav menu link also located in the header and try to reconnect, the button seems to lost the connection state, the Web3button stills show "Connect Wallet", even if the connection has been initiated. If i try to click on the button again, the modal tries to connect again and shows an error message. I have to fully refresh all the page so the button and the modal get refreshed.
Please find below my app.js where the modal is instanciated :
import "../styles/globals.css";
import { ThemeProvider } from "next-themes";
import Layout from "../components/layout";
import { Provider } from "react-redux";
import { store } from "../redux/store";
import { Web3Modal } from "@web3modal/react";
import Meta from "../components/Meta";
import UserContext from "../components/UserContext";
import { useEffect, useRef, useState } from "react";
import {
  EthereumClient,
  w3mConnectors,
  w3mProvider,
} from "@web3modal/ethereum";
import { configureChains, createClient, WagmiConfig } from "wagmi";
import { arbitrum } from "wagmi/chains";

function MyApp({ Component, pageProps }) {
  const [ready, setReady] = useState(false);
  const scrollRef = useRef({
    scrollPos: 0,
  });
  const chains = [arbitrum];
  const projectId = "xxxxxxxxxxxxxxxxxxxxxxxxxx";
  const { provider } = configureChains(chains, [w3mProvider({ projectId })]);
  const wagmiClient = createClient({
    autoConnect: true,
    connectors: w3mConnectors({ projectId, version: 2, chains }),
    provider,
  });
  const ethereumClient = new EthereumClient(wagmiClient, chains);
  useEffect(() => {
    setReady(true);
  }, []);

  return (
    <>
      {ready ? (
        <WagmiConfig client={wagmiClient}>
          <Provider store={store}>
            <ThemeProvider enableSystem={true} attribute="class">
              <UserContext.Provider value={{ scrollRef: scrollRef }}>
                <Layout>
                  <Component {...pageProps} />
                </Layout>
              </UserContext.Provider>
            </ThemeProvider>
          </Provider>
        </WagmiConfig>
      ) : null}
      <Web3Modal
        themeVariables={{
          "--w3m-accent-color": "#8358FF",
          "--w3m-background-color": "#131740",
        }}
        projectId={projectId}
        ethereumClient={ethereumClient}
      />
    </>
  );
}

export default MyApp;

And my header file :
import Image from "next/image";
import Link from "next/link";
import DarkMode from "../mode/DarkMode";
import Logo from "./../../public/images/logo.png";
import WhiteLogo from "./../../public/images/logo_white.png";
import { v4 as uuidv4 } from "uuid";
import { useRouter } from "next/router";
import {
  isChildrenPageActive,
  isParentPageActive,
} from "../../utils/daynamicNavigation";
import { useEffect, useState } from "react";
import { useAccount, useEnsName } from "wagmi";
import { Web3Button } from "@web3modal/react";
import DropDownInfos from "./fragments/DropDownInfos";

export default function Header() {
  const { address, isConnected } = useAccount();
  const { data: ensName } = useEnsName({ address });
  const [toggle, setToggle] = useState(false);
  const [isCollapse, setCollapse] = useState(null);
  const [hydrated, setHydrated] = useState(false);

  // window resize
  useEffect(() => {
    setHydrated(true);
    window.addEventListener("resize", () => {
      if (window.innerWidth >= 1024) {
        setToggle(false);
      }
    });
  }, []);

/* Some code */

            <div className="ml-8 hidden items-center lg:flex xl:ml-12">
              <Web3Button label="Connect" icon="show" />

PS: I've submitted this issue a second time because my previous issue has been closed. If it was not the right way to do, please forgive me. I've posted this exact same message as a comment at the end of the previous issue opened.
List of related npm package versions
web3modal, wagmi

Replied in your previous issue: https://github.com/WalletConnect/web3modal/issues/968


deprecated macos runners in workflows

macos-11 runner images have been deprecated.
The last time testing newer x86-64 macos runners, there were problems related to the rust-toolchain, which may have been fixed in the meantime.

@ttytm
I am working on this problem, right now.  As I have found out by now, macos-11 does not seem to exist, anymore.  I will prepare a PR which uses macos-12 as well as macos-13 as replacements for the outdated macos-11 setting.  As macos-latest is defined as an alias for macos-14, I will just focus on the other two as we are already testing on macos-14 implicitly due to the redirection.
For further information, please see https://github.com/actions/runner-images#available-images.

I was aware that macos-11 was deprecated for a while announced to be removed. I was just lazy due to the toolchain issue with the newer intel runners and then didn't manage to make an update after the removal.
Thanks for the work and research.


test - new article with errors

Not for merge.

Docs Build status updates of commit f21531d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/powershell/test-new-article-errors.md
:warning:Warning

Details

docs/powershell/test-new-article-errors.md

Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 2, Column 16: [Warning: yaml-header-syntax-error] While scanning a plain scalar value, found invalid mapping.
Line 13, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to <blockquote>
Line 15, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'Test new article'.
Line 17, Column 9: [Warning: bookmark-not-found] Cannot find bookmark '#htird-section' in 'powershell/test-new-article-errors.md', did you mean '#third-section'?
Line 19, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 'Second section') are not allowed. You can only have one top-level heading.
Line 0, Column 0: [Suggestion: toc-missing] Article is not referenced from a table of contents. Every article must be in a TOC.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[Feature] Responsive Tabs

As a developer, I would like have responsive tabs, where icons to scroll (arrows) will show up when there is an overflow.

Already implemented in 1.5
http://w2ui.com/web/demos/#!tabs/tabs-7
Cheers =)

Please close the issue if it has been solved.
Otherwise please elaborate on your feature request.

In our project we are using 1.4.2 version. I would like have responsive tabs, where icons to scroll (arrows) will show up when there is an overflow.
http://w2ui.com/web/demos/#!tabs/tabs-7
is not work ... is possible it?


Reaplacement for dbstart/dbshut from Oracle

The scripts dbstart and dbshut has some limitations.

Multiple Listeners in different ORACLE_HOMEs not supported
dbstart bounce running Instances

This only affects installations without GI or Restart.

I am working on a replacement for dbstart/dbshut.

PR #137


User not authorized to perform kms:DescribeKey operation

Description
Despite providing sufficient permissions to the KMS key policy the cluster is not being created due to insufficient KMS permissions. I'm perplexed by this as it should be very straightforward and all permissions look correct.
Versions

Module version [Required]:
19.15.3

Terraform version:
v1.2.5

Provider version(s):
aws: v5.5.0

Reproduction Code
I've tried letting the eks module generate the key and providing the following variables:
  kms_key_enable_default_policy = true
  kms_key_administrators         =<EMAIL_ADDRESS>  kms_key_owners                     =<EMAIL_ADDRESS>  kms_key_service_users          =<EMAIL_ADDRESS>  kms_key_users                        =<EMAIL_ADDRESS>
and also using an external key as shown in the /examples/complete example:
  create_kms_key = false
  cluster_encryption_config = {
    resources        = ["secrets"]
    provider_key_arn = module.kms.key_arn
  }
...
module "kms" {
  source  = "terraform-aws-modules/kms/aws"
  version = "~> 1.5"

  aliases               = ["eks/${local.name}"]
  description           = "${local.name} cluster encryption key"
  enable_default_policy = true
  key_owners            = [data.aws_caller_identity.current.arn]

}

Steps to reproduce the behavior:
terraform apply
Expected behavior
Cluster is created successfully.
Actual behavior
Upon EKS cluster creation:
│ Error: creating EKS Cluster (my-cluster): InvalidRequestException: User not authorized to perform kms:DescribeKey operation
│ {
│   RespMetadata: {
│     StatusCode: 400,
│     RequestID: "2bc816b4-0a5b-4c0c-bb4d-a43b24d72a40"
│   },
│   Message_: "User not authorized to perform kms:DescribeKey operation"
│ }
│
│   with module.eks.aws_eks_cluster.this[0],
│   on .terraform/modules/eks/main.tf line 25, in resource "aws_eks_cluster" "this":
│   25: resource "aws_eks_cluster" "this" {
│
╵

Despite within the KMS key policy I can clearly see:
{
            "Sid": "KeyOwner",
            "Effect": "Allow",
            "Principal": {
                "AWS"<EMAIL_ADDRESS>            },
            "Action": "kms:*",
            "Resource": "*"
        }

Additional context
I've checked the generated KMS key policy, it's providing the correct permissions to the correct user. I'm also running the Terraform via the same users credentials.
I've checked the AWS troubleshooting key access guide and none of these should apply to me. Very much at a loss to what could be causing this, no explicit denies, SCP's, endpoint policies etc.

same bere.

Same here. I was using Terraform Cloud with a specific AWS IAM role, and my local CLI interactions were with a different SSO role. I added both roles to the aws-auth and as key admins - resolved.

sounds like this is just mis-configuration so I am going to close it out for now


EAM needs restart to use assets

When I download an asset X or Y: ok ,
and want to use them: integrate into a project: fails .
I have to restart EAM to be able to do that .
latest version on an Arch based distro. (flatpak and aur)

I think it would be enough to switch there and back to another asset, or if you perform the action it will not download it again, just validate it and do the action, but yes this is something that needs looking into.


Endpoint on opampbridge should support tls cert

I attemp to try opampbridge on this values
It's asking the endpoint of opamp server. However, based on opamp-go Agent in this repository we have to determine the CA tls for connecting to opamp server.
Is this Endpoint opamp server is http or wss (protobuf) ? In the example, it's given http but i am not sure the communication between agent to server using http. It should be websocket.
I don't find the opamp-server image, but i try to build it localy.

Hi @jaronoff97
I have succeded to connect bridge endpoint to amp server (VM).
I choose amp server (VM) because it's provided the UI. However when i try "Save and Send to Agent", it's not work (the otelcol config is not reflected as i want and some configs part are removed when displayed.

I believe this is a bug in the latest opamp-bridge server. I have seen this reported elsewhere. Would you mind opening a new issue in the operator repo for this, and I can take a look there?

while there, can you also provide a link to the opamp server implementation please?

@jaronoff97 Hi, i really happy and glad to cooperate with you. meanwhile I cannot much contribute in code but I hope can help you for testing. 😅
How do i contact you in private ? Have a slack or something ?

no problem! You can message in the #agentmanwg in the CNCF slack and we can follow up there. Closing this issue for now.


Is there anyway to open agm-snazzy-info-window when mouseOver on agm-marker?

I have the same doubt. Please can anyone answer please

This works for me. I've added a display property to the markers and set it to true on (mouseover).
<agm-marker *ngFor="let marks of markersholder;let i=index"
                    [latitude]="marks.lat"
                    [longitude]="marks.lng"
                    (mouseOver)="showinfo(marks.label, i)">
                    <agm-snazzy-info-window #snazzyInfoWindow
                        [latitude]="marks.lat"
                        [longitude]="marks.lng"
                        [closeWhenOthersOpen]="true"
                        [isOpen]="marks.display">
                  </agm-snazzy-info-window>
</agm-marker>

ts file
let markersholder:any[] = {
    display:false,
     lat:0,
     lng:0
}

showinfo(label: string, index: number) {
        let abc:AgmSnazzyInfoWindow=ViewChild('snazzyInfoWindow'+index);
        this.markersholder[index].display = true;
    }

Thanks @ryandmello1198 , It worked for my project.


Fixed init-list construction when size_type is not int

Rationale in code comments. I thought about adding a new unit test but it was a bit beyond me. Feel free to make suggestions!
Note that this has yet to be amalgamated (waiting for https://github.com/nlohmann/json/pull/4083).

#4083 has been merged

Amalgamated.

Thanks!


Make modules less brittle

Right now, with the introduction of #69, module source contents are added at a different time than the AST tree. This makes it difficult to reason about when modules are or aren't loaded. A better approach might be to have a way of inserting source contents on the fly as needed (and maybe even the same for AST). This would allow parts of the compiler to request source contents/AST and have it dynamically be computed/loaded if it hasn't already.

Idea: Maybe it might be worth it to store Module objects inside modules instead of having N dashmaps for N fields.

I think it's just a simple matter of when the contents get moved into Modules before since a module might not even be inserted because it contains parse errors. What we should do is guarantee that the filename and source of the module is inserted before the ast gets inserted and then this issue should go away


Documentation for Submethod is LTA

The problem
The only example there is the BUILD phaser. It's not clear you can declare your own, for instance.
Suggestions
Check if it match current implementation, link to #3062 when it's created.

Just in case: rakudo/rakudo#3199 will bring some significant changes to the handling of BUILD/TWEAK/DESTROY and submethods in general in roles.


added service principal, pin AML version

@grecoe has code for the az login so that should be fine

@fboylu said az cli is isntalled as a pip dependency in env


problem setting custom config js settings

I’ve configured my interface_config_js settings, but my custom_config_js settings are not working. I've tried everything in the example configurations, but nothing seems to work. Additionally, I'm trying to enable the whiteboard in config.js, but even though Excalidraw is running, the whiteboard is not appearing.

Hello @robbie1-uk!
According to the web image init scripts, the contents of custom-config.js file are appended to the end of the rendered /config/config.js file. You can attach to a running web pod and check if it actually happens by reading the last N lines of this config file. Another option would be using the Developer Console in your browser and checking the config.js file your browser gets when connecting to your Jitsi Meet installation.

hello @spijet, thank you
So should I make these changes in the running pod? Because when I write in values.yaml, it does not make the changes.


Calling migration script from scheduled task

Hi, I would like to call one of the migration scripts that I wrote from a scheduled task. However, the @ChangeSet method requires a MongoDatabase as a parameter and I am not sure how to send it from inside my scheduled task. I tried autowiring MongoDatabase in my ScheduledTasks class and then sending it to the migration script method as parameter, but Spring complains that MongoDatabase is not a recognized bean. Any advice about how to proceed about this would be appreciated. Thank you :)

I found the solution: I can autowire MongoTemplate inside my ScheduledTasks class and do mongoTemplate.getDb() and pass that to the script :)

Hello @aggo ,
I see you found the solution, but I would like to help you by confirming is the right approach.
What Mongock's version are you using? Long time ago we removed the MongoDatabase mandatory parameters in changeSets, no you can use whatever you want(except for MongoTemplate, for which you need to use MongockTemplate, which is just a kind of decorator for MongoTemplate).
Please see our documentation

Hi @dieppa, we are using 4.1.8, but we have code of our own that is used by the migration scripts that uses the MongoDatabase and changing it would be too much work at this point. However, will keep in mind the idea with MongockTemplate, thank you for always being so quick to answer the stuff posted here :) Kudos for the good work!

Great and thanks! I don't fully understand your scenario, but keep into account that even using the mongodatabase, you should get it from MongockTemplate, as otherwise won't be synchronised properly with the lock.
Cheers

Oh, yes, thank you for re-mentioning that. Will do it as such. :)


Fix history navigator to change the position when adding an existing element.

Fixes Microsoft/vscode#29762

@stringham,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@sandy081 I think this is a pretty straightforward fix. Is there anything holding it up?

@stringham,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


[IRGen] Include extra tag bytes in offset in layout strings

rdar://110088270
When extra tag bytes are used in single payload enums, the generated layout string does not include the tag bytes in its offset after the enum payload. This causes subsequent ref count operations to use the wrong memory location.

@swift-ci smoke test


dynamic buttonDisabled

Description
Disable atoms/button temporarily after click.
Issue ticket number and link
Used in:
https://trello.com/c/WwIp31lD/128-group-invite-new-member-functionality-not-working
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have made corresponding changes to the documentation
[ ] Any dependent changes have been merged and published in downstream modules

@nemvalid You are right. Moved the logic to:
https://github.com/Platform-OS/community-solution/pull/332
Closing this.


[FEATURE] Support for aiohttp Trace Config in AsyncHttpConnection for Enhanced Tracing with X-Ray

Is your feature request related to a problem?
I'm encountering difficulties integrating X-Ray tracing with aiohttp requests made through the AsyncHttpConnection class. The core of the issue is that AsyncHttpConnection does not currently seem to allow passing trace_config information to the aiohttp.ClientSession, which is necessary for implementing detailed tracing with AWS X-Ray in asynchronous environments.
What solution would you like?
Would it be possible for AsyncHttpConnection to either support passing trace_configs as part of its initialization parameters or take an option to initialize the trace hooks? Apologies if this is already supported somehow and I missed it. If that's the case, let me know a way I can hook this up without sub-classing AsyncHttpConnection myself.
What alternatives have you considered?
As a workaround, I subclassed AsyncHttpConnection to manually create an aiohttp.ClientSession with the required trace_configs parameter. While this approach works, it requires additional maintenance and familiarity with the internals of both OpenSearch and aiohttp.
from aws_xray_sdk.ext.aiohttp.client import (
        aws_xray_trace_config,  # pragma: no cover
    )

class CustomAsyncConnection(AsyncHttpConnection):
    async def _create_aiohttp_session(self) -> Any:
        if self.loop is None:
            self.loop = get_running_loop()
        self.session = aiohttp.ClientSession(
            headers=self.headers,
            skip_auto_headers=("accept", "accept-encoding"),
            auto_decompress=True,
            loop=self.loop,
            cookie_jar=aiohttp.DummyCookieJar(),
            response_class=OpenSearchClientResponse,
            connector=aiohttp.TCPConnector(limit=self._limit, use_dns_cache=True, ssl=self._ssl_context),
            trace_configs=[aws_xray_trace_config()],
        )

    test_client = AsyncOpenSearch(
        hosts=[settings.SEARCH_CLUSTER_URL],
        connection_class=CustomAsyncConnection,
    )
    info = await test_client.info()
    print(info)
    await test_client.close()

Seems reasonable. There's also a related issue on wanting to introduce metrics, #678. Feel free to contribute!


maid_offhours not functioning

I have an EC2 instance running within Capital One's internal AWS environment. I used to have a maid_offhours tag with value off=(M-F,20);on=(M-F,8) and it worked well for scheduling the start/stop of my instance. However this function has stopped working since late October. Has this function been decommissioned? Is there another option available now?

@alittlefishy if you look at the Lambda function for the custodian offhours policy, click on the button to view the CloudWatch logs for it.  Are there errors in the log?

?  This resolved then?


Section 9.1.2 "Action Specification"

This sentence seems wrong: "The Action Protobuf message, which is used for direct tables only, has the following fields:"
because the Action Protobuf message is also used for tables within action profiles and action selectors, too?
Or perhaps the statement is meant as "which is used as the oneof choice, among those available in a TableAction message, only for direct tables" ?

You're correct. This statement stopped being true when we added the oneshot programming method for indirect match tables with selectors.


Convert pair of coordinates and strand info

Hi,
Thanks for the development of this package ! It's working quite well !
It's more of a question rather than an issue.
I wanted to know if there was a way to convert a pair of coordinates like in the liftOver standalone which is taking a bed file as input with a start and stop coordinates along with the strand information ?
Thanks for you help !

You could certainly do that with this package. I took a stab at this, see code below to lift a bed file, but I'm not sure if it's correct or efficient, feel free to improve or reshape to suit.
#!/usr/bin/env python

import argparse
import gzip
import logging
import sys

from liftover import get_lifter

def get_options():
    parser = argparse.ArgumentParser()
    parser.add_argument('--input', required=True)
    parser.add_argument('--in-build', required=True)
    parser.add_argument('--out-build', required=True)
    parser.add_argument('--output', required=True)
    return parser.parse_args()

def get_sep(line):
    ''' find field seperator
    '''
    return ' ' if line.count(' ') > line.count('\t') else '\t'

def read_bed(path):
    ''' read lines from a bed file

    Yields:
        True/False for if the line should be lifted, then chromosome, start, end,
        remainder of the bed line, and lastly the line separator.
    '''
    opener = gzip.open if str(path).endswith('gz') else open
    with opener(path) as handle:
        for i, line in enumerate(handle):
            if line == '' or line.startswith('#') or line.startswith('browser') or line.startswith('track'):
                yield False, line
                continue
            line = line.strip('')
            sep = get_sep(line)
            contig, start, end, *rest = line.split(sep)
            if len(rest) < 3:
                logging.error(f'line {i+1} lacks strand info: {line}')
                continue
            yield True, contig, int(start), int(end), rest, sep

def lift_regions(regions, lifter):
    for to_lift, *region in regions:
        if not to_lift:
            yield region[0]
            continue
        chrom, start, end, rest, sep = region
        strand = rest[2]
        new_start = lifter[chrom][start]
        new_end = lifter[chrom][end]
        if len(new_start) == 0 or len(new_end) == 0:
            logging.error(f"cannot lift {chrom}:{start}-{end}, does not lift anywhere")
            continue
        elif len(new_start) > 1 or len(new_end) > 1:
            logging.error(f"cannot lift {chrom}:{start}-{end}, lifts to multiple locations")
            continue
        new_start = new_start[0]
        new_end = new_end[0]
        if new_start[0] != new_end[0]:
            logging.error(f"cannot lift {chrom}:{start}-{end}, ends lift to different chromosomes")
            continue
        elif new_start[2] != new_end[2]:
            logging.error(f"cannot lift {chrom}:{start}-{end}, ends lift to different strands")
            continue
        chrom = new_start[0]
        window = [new_start[1], new_end[1]]
        start = min(window)
        end = max(window)
        if strand == '+':
            rest[2] = new_start[2]
        else:
            rest[2] = '+' if new_start[2] == '-' else '-'
        yield f'{sep}'.join([chrom, str(start), str(end)] + rest)

def main():
    args = get_options()
    lifter = get_lifter(args.in_build, args.out_build)
    regions = read_bed(args.input)
    with open(args.output, 'wt') as output:
        for x in lift_regions(regions, lifter):
            output.write(x)

if __name__ == '__main__':
    main()


Instaloader not working on Ubuntu 23.04

When I run instaloader, I get following error,
$ instaloader -V --no-captions --no-metadata-json -s --highlights official_niharica_raizada
Traceback (most recent call last):
File "/home/ashu/.local/bin/instaloader", line 5, in
from instaloader.main import main
ModuleNotFoundError: No module named 'instaloader'
When I try to check the version, again this happens,
$ instaloader --version
Traceback (most recent call last):
File "/home/ashu/.local/bin/instaloader", line 5, in
from instaloader.main import main
ModuleNotFoundError: No module named 'instaloader'
Just to confirm I have version instaloader-4.9.6 installed.

That error is not problem with os and instaloader
Check document


DDC strong mode and exact types

In strong-mode the following test fails (from compile_time_constant_static5_test):
class A {
const A();
}
class Test3<U extends A, V extends B> {
final U x = const A(); //# 11: ok
}
because the result is a compile-time warning.
This is changed behavior from earlier. Is the current behavior expected, then the test should be updated.

Adding a bit of context: We need to specify if/when the strong mode static analysis determines that a given expression has an exact type, and what that knowledge is used for. A typical case would be constant expressions, where the exact type is known at compile-time, but new A() could also be given an exact type when it is known statically that it invokes a generative constructor.
In the given context, a downcast from "exactly A" to B could be rejected because it is guaranteed to fail at run time. A downcast from "exactly A" to U would not be guaranteed to fail at run time (the value of U could be A), so it would be consistent with the approach taken elsewhere in Dart to allow that (except when --no-implicit-casts is specified, of course).
When we have a clear model for which expressions have exact types, and when that's used for what, we can adjust the tests to have the correct expectations.

The intention is that the error only be issued on casts that are guaranteed to fail.  A reasonable approximation of this is to only issue this error when the target type of the implicit cast is a ground type.  That would allow this cast.

Related:
class A {
  const A();
}

class B extends A {
  const B();
}

// Snip...

// Will be instantiated with U=dynamic and V=dynamic.
class Test5<U extends A, V extends B> {
  final U x = const A(); //# 21: ok
  final U x = const B(); //# 22: compile-time error
  final V x = const A(); //# 23: ok
  final V x = const C(); //# 24: compile-time error
  final V x = const C.d(); //# 25: compile-time error
  const Test5();
}

use(x) => x;

main() {
  use(const Test1());
  use(const Test2<A, B>());
  use(const Test3<A, B>());
  use(const Test4<A, B>());
  use(const Test5());
}

#23 is a compile-time error in DDC, but a run-time error in DDK (DDC with the new common front end).

// Will be instantiated with U=dynamic and V=dynamic.
class Test5<U extends A, V extends B> {

This comment is incorrect for Dart 2, dynamic is not a valid type argument for U or V.
Most likely the class will be instantated to bounds: Test5<A, B>, otherwise the instantiation itself will be an error.
The assignment final V x = const A(); should be a valid implicit down-cast. The static type of const A() is A, which is a supertype of the parameterized type V with bound B. A type variable is a subtype of its bounds, so V <: B, and B is a subclass of A.
(The static type system does not have a notion of "exact type", so it can't say for sure that const A() is not assignable to V - so it must follow the usual implicit downcast rules, and A is a supertype of V).

There are even more surprises in this test: const Test5() is the only use of Test5 that we can see, and it should be invoked with type arguments <A, B> based on the feature instantiate-to-bound (where we have had no disagreement at all on what instantiate-to-bound means for simple types like A and B).
But subtest 22 would then (during compile-time construction of the Test5 for that subtest) initialize x whose type annotation has the value A with an instance of type B: That should succeed, but it is marked as compile-time error. So it isn't even a run-time failure which is guaranteed to occur, it's simply surprising. ;)

Trying to actually run it, I can see that the use of exact types in DDC does play a role in Kevin's example after all, because DDC emits a compile-time error for subtest 21 (which is marked ok):
[error] The constructor returns type 'A' that isn't of expected type 'U'. (out/ReleaseX64/generated_tests/language_2/scratch_test_21.dart, line 13, col 15)

We may check the initialization of final U x ... //# 21.. locally (that is, in a way that should be valid for both const and new invocations of the constructor): The initializer has type A, and the variable has a type U which is less-equal-than A according to the bound. So that's a plain downcast, and the only way we can make it a compile-time error is by considering const A() to have an exact type and then concluding that the downcast to U "will never succeed". That, again, is not quite true because U could be A (as it actually is in the invocation of const Test5() in main).
So this means that Kevin's example shows an issue with DDK in relation to const expressions (23), and it again shows the issue with DDC and exact types that gave rise to this issue in the first place.

I agree that #21 should not be a compile-time error.
The static types are U extends A and A, which is an implicit downcast, and the run-time types are A and A, so assignment succeeds.
And #22, #24 and #25 are strong-mode compile-time errors because the static types do not form a valid up- or down-cast. The 22 case is the most surprising because U extends A and B are unrelated subtypes of A  (statically, the parameterized type U is not the type A, it's an unknown subtype of A).
Likewise the static type C is not a related to V extends B.

this still reproduces. should be a quick fix

Closing since both CFE and analyzer seem to agree on disallowing these casts: https://dart-review.googlesource.com/c/sdk/+/115778
Feel free to re-open if this is premature.


Advanced Search Question

I am going to eliminate the drop down for name, inchi, tag, synonym and formula. They will only be on the advanced search page. The functionality to search by INCHI, formula, and name will still be there as we can easily determine that based on the users input. Let me know your thoughts!

I think it would be a great interface improvement to remove the drop-down for formula vs. InChI key. As you said, most of these can be auto-detected from the input.


Source EEM data

Hi Jordan,
Could you upload the source EEM data files? or the template?
Thank you.
Best Regards
penghui

Hello,
I have added a link to the source EEM data in the README of this repository.
Best,
Jordan


Use _to_unitless() instead of .value to obtain unitless arrays

Over in #871 we realized that LightCurve objects must allow columns to be of type Column in addition to Quantity and Time.  This is inherent to AstroPy QTable objects which LightCurve sub-classes.  For example, string values can only be represented by a Column object.
This is important because Column objects do not have a .value attribute.  Several parts of the code (e.g. lc.plot()) currently make the assumption that e.g. lc.flux.value will always work.
Fix needed: we should replace occurrences of column.value with a more generic _to_unitless(column) function which returns .value if column is a Quantity or Time, and returns .data in the case of Column.

For example, here is a snippet of code which currently fails due to the use of flux.value in lc.plot():
import lightkurve as lk
import numpy as np
lc = lk.LightCurve(time=[1,2,3], flux=[4,5,6])
lc.plot()  # this works
lc.flux = np.array([7,8,9])
lc.plot()  # this fails


Audio Not Transmitting to Dialed Number in Twilio Call

Issue Summary

I'm experiencing an issue with the sound not being transferred from the source (client) to the destination (dialed number) when implementing a Twilio call. After the client calls the Twilio number and Twilio dials the number, the two parties are connected, but the sound from the source is not audible at the destination. This is unexpected behavior as the audio should be transmitted seamlessly between both connected numbers.
Steps to Reproduce

Implement a Twilio call where the client calls a Twilio number.
Program Twilio to dial another number upon receiving a call.
Connect the source and destination.

Expected Behavior: The sound from the source should be transmitted and heard at the destination without issues.
Actual Behavior: The source and destination are connected, but the sound from the source is not reaching the destination, resulting in a one-way audio issue.

Hi @hbsciw
Thanks for opening the issue - I'm investigating this issue at the moment. Additional information would be helpful.
On which Android SDK/OS versions do you experience this issue?

Hi @cybex-dev
Thank you for your response
Android version 13
Device Galaxy A51
twilio_voice SDK v0.1.0

@hbsciw wonderful, to confirm caller and recipient are both Android +13?

Caller is android 13, for recipient i test with different devices such as android 13, android 12, ...
For your information the recipient is not app or sdk. recipient is phone number.

@cybex-dev Is there a way to revert to a previous version until the issue is resolved?

Caller is android 13, for recipient i test with different devices such as android 13, android 12, ...
For your information the recipient is not app or sdk. recipient is phone number.

Thanks for the info.

@cybex-dev Is there a way to revert to a previous version until the issue is resolved?

The only alternative is reverting back to 0.0.9 - though keep in mind there are many additional fixes, etc in the latest version.
We have several clients affected by this issue and am actively investigating the cause.

@cybex-dev Is there a way to revert to a previous version until the issue is resolved?

The only alternative is reverting back to 0.0.9 - though keep in mind there are many additional fixes, etc in the latest version.
We have several clients affected by this issue and am actively investigating the cause.

Than you.
Could you give me the branch or the commit relates to this version?

@cybex-dev Is there a way to revert to a previous version until the issue is resolved?

The only alternative is reverting back to 0.0.9 - though keep in mind there are many additional fixes, etc in the latest version.
We have several clients affected by this issue and am actively investigating the cause.

Thank you for your valuable contribution

Same issue here, hope its gonna fixed soon.
we have many angry clients.

@cybex-dev is there anything you can point us to so we might be able to help you.

@ardeshir-33033 @hbsciw

@cybex-dev is there anything you can point us to so we might be able to help you.

Thank you for offering, what would be helpful is to understand what's happening in the background when this issue occurs.
If you could provide Android log outputs (via logcat) when placing the call until it is answered. This would assist in tracking down the issue faster.

![3](https://github.com/cybex-dev/twilio_voice/assets/699071

40/e9594b06-2980-4ac1-8017-a7e143b6edb3)

Thanks for the screenshots, but it doesn't help that much.
Could you copy/paste from logcat instead when you experienced this issue - would help alot, thanks.

I faced this issue as well, I tried with different type of devices but could not be able to receive caller audio from callee.
@cybex-dev

Hi @mohsen-jalali, thanks for the report.
I've been able to consistently reproduce this issue, I'd like to ask everyone who has experienced this issue to assist in testing this scenario:
Please grab the latest version twilio_voice/tree/fix_android_14_microphone_audio, then replicate with the following actions:

Microphone single direction only (inbound)

This will simulate a user installing the app from Play Store and placing an outbound call. Observe audio output from the calling device, but no mic input on call recipient.

Fresh install example app (use your own app), ensure you use proper/valid Twilio credentials
Call FROM device (with app installed)
Observe audio output (i.e. mic input from recipient) is heard on device.
Observe microphone input from caller does NOT work

Note - this is 100% reproducible on first call, but further on it occurs intermittently regardless of caller.

Microphone works bi-directional

This will simulate a user installing the app from Play Store and receiving an "introductory" first call call. Observe audio output from the calling device AND mic input on call recipient.

Fresh install example app (use your own app), ensure you use proper/valid Twilio credentials
Call TO device (with app installed)
Observe audio output (i.e. mic input from recipient) is heard on device.
Observe microphone input from caller works.

Note - this seems to be more reliable, however the same issue is faced with microphone input working intermittently.

Please contribute to the bug tracker link, reposted here - it will help draw attention to this issue.
https://issuetracker.google.com/issues/304335430

I found the solution, the issue was because of not starting foreground service on outgoing calls.
I created a pull request for it and fixed it.
@cybex-dev

I found the solution, the issue was because of not starting foreground service on outgoing calls. I created a pull request for it and fixed it. #181 @cybex-dev

Absolutely amazing - that would explain the Op codes error. I'll review, merge and push latest update today. Many thanks @mohsen-jalali!

@mohsen-jalali initial testing on Google API 34 emulator (the only platform I can reliably and consistently reproduce this issue), does not seem to resolve this no microphone on outgoing calls.
2023-10-14 12:25:12.050   416-432   PermissionCache         audioserver                          D  checking android.permission.CALL_AUDIO_INTERCEPTION for uid=10204 => denied (599 us)
2023-10-14 12:25:12.056   416-6318  AudioFlinger            audioserver                          I  AudioFlinger's thread 0x77d19e0d4bb0 tid=6318 ready to run
2023-10-14 12:25:12.062   416-432   AudioPolicyService      audioserver                          I  App op 27 missing, silencing record AttributionSourceState{pid: 6050, uid: 10204, packageName: com.twilio.twilio_voice_example, attributionTag: (null), token: binder:0x77d0d1caf660, renouncedPermissions: [], next: []}
2023-10-14 12:25:12.065  6050-6253  tvo.webrtc.Logging      com.twilio.twilio_voice_example      I  WebRtcAudioEffectsExternal: enable(audioSession=257)
2023-10-14 12:25:12.065  6050-6253  tvo.webrtc.Logging      com.twilio.twilio_voice_example      I  WebRtcAudioRecordExternal: AudioRecord: session ID: 257, channels: 1, sample rate: 48000
2023-10-14 12:25:12.066  6050-6253  tvo.webrtc.Logging      com.twilio.twilio_voice_example      I  WebRtcAudioRecordExternal: AudioRecord: buffer size in frames: 2880
2023-10-14 12:25:12.067  6050-6253  tvo.webrtc.Logging      com.twilio.twilio_voice_example      I  WebRtcAudioRecordExternal: Number of active recording sessions: 0
2023-10-14 12:25:12.068  6050-6253  tvo.webrtc.Logging      com.twilio.twilio_voice_example      I  WebRtcAudioRecordExternal: startRecording
2023-10-14 12:25:12.071   585-1409  AppOps                  system_server                        E  Operation not started: uid=10204 pkg=com.twilio.twilio_voice_example(null) op=RECORD_AUDIO
2023-10-14 12:25:12.075   416-6318  audioserver             audioserver                          D  FGS Logger Transaction failed
2023-10-14 12:25:12.075   416-6318  audioserver             audioserver                          D  -129
2023-10-14 12:25:12.075   416-6318  audioserver             audioserver                          D  FGS Logger Transaction failed
2023-10-14 12:25:12.076   416-6318  audioserver             audioserver                          D  -129

This should resolve microphone access issues for prior Android 13 devices - will merge but we're not out of the water yet.

Re-opening issue for Android 14.


ISIS-1693 exception when attempt to render ErrorPage itself

This pull request was made for a mandatory school course project
https://issues.apache.org/jira/browse/ISIS-1693

Thanks for this one. But please no Sonar integration here!
We already have sonar cloud integration for the Apache Isis project, which is hosted here [1]. Reason being, that we (the project committers) cannot use GitHub secrets with the main Apache projects. (We don't have the privileges to manage secrets here.) The sonar analysis is published at a daily basis, see [2].
[1] https://github.com/apache-isis-committers/isis-nightly
[2] https://sonarcloud.io/dashboard?id=apache_isis

Hi @MNummila - please give this PR some love, otherwise its likely to get rejected.


Refine issue templates [skip-ci]

What have you changed? (mandatory)
Refined issue template so that user can choice between "Bug Report", "Future Request" and "Question".
What are the type of the changes? (mandatory)

New feature (non-breaking change which adds functionality)

@Hoverbear I updated the templates, PTAL again :)

@lilin90 @Hoverbear PTAL :)

/build

ping @breeswish


Do not update spec by controller

As described in the Kubernetes API conventions, Kubernetes controllers should avoid updating user owned object Spec sections:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#spec-and-status
This removes the logic which modifies the Spec value and ensure the updated value is used only internally.

/test ansibleee-operator-build-deploy-kuttl

/test openstack-ansibleee-operator-build-deploy

/test openstack-ansibleee-operator-build-deploy


This library seems to be deprecated. Other alternatives?

There are no commit after March 2019.
Unfortunately, we have no alternatives. There are many cache libraries, but they are not already managed. FriendlyRepo, the fork of this library, is also no longer managed.
I've searched the libraries used on JVM, not just Android. Among them, caffeine looks good.
But Android is not supported. See here.
Please let me know if you find a good alternative.

Will be announcing a new main repo in 3 days stay tuned


custom URL : relative path

Hello !
I'm back with an other request 😄
I would like to know if it was possible to add the relative path support in the CustomURL setting.
Sometimes we put a settings.json file and snippets in the .vscode folder at root of a project, but not everyone clone the project at the same path
Is it possible to add this support ?
Sorry I'm asking you a lot of things :/

ok, i am fulfilling your requirement


support for cook pools

What changes were proposed in this pull request?
Support for job submissions with "pool" property.
How was this patch tested?
I just built it, I couldn't find any tests under resources-managers for cook. Happy to add one for this change if there's already a framework.

@WenboZhao - A few things. I updated the version of cook client to use the latest that Paul published to clojars. I also had to update the version of the cook resource manager, otherwise it doesn't build.
The "jobs" endpoint has been around for a while and "rawscheduler" is getting deprecated this is a safe change to rollout.


Huge webmention delay?

I just implemented webmention from my website, and sent a webmention to https://fed.brid.gy/webmention. I got 202 response with body:
Added webmention task projects/bridgy-federated/locations/us-central1/queues/webmention/tasks/0364590518903229013 : {'source': '...', 'target': 'https://fed.brid.gy/'}

And I saw that a request with user-agent of Bridgy Fed (https://fed.brid.gy/) accessing my website within 2 minutes. But after one hour I still don't see the new post appearing in the activity tab of https://fed.brid.gy/web/<my domain>, wondering if there are some huge delay even with webmention, or if I did something wrong.

Hmm, sorry for the trouble! What was the post URL? I can take a look.

Hmm, sorry for the trouble! What was the post URL? I can take a look.

https://b.yuxuan.org/fediverse

Looks like we got backed up pretty badly. I'm still not sure why yet, but I'll get the backlog processed and figure out what happened.

Finally got a chance to look at this. Looks like your site doesn't have microformats? If you want to use webmention to trigger BF instead of RSS/Atom, you'll need microformats. https://microformats.org/wiki/microformats2 , https://indieweb.org/microformats

Finally got a chance to look at this. Looks like your site doesn't have microformats? If you want to use webmention to trigger BF instead of RSS/Atom, you'll need microformats. https://microformats.org/wiki/microformats2 , https://indieweb.org/microformats

the doc doesn't make it clear that microformats are required for webmentions, and it worked without microformats before with rss feed 🫤

True! Good point about the docs, sorry about that. I'll update them.
RSS and microformats both provide a predictable way to extract structured data, notably post content and optionally title, from arbitrary HTML. Without those, it's not easy for BF to determine what specifically in your HTML is the post content that you want to federate.

ok anyways I added microformat and looks like it works now (the webmention request now times out at 1s for some reason, but I do see the request from bridgy fed immediately after and then it's updated)


sync - queueing requests

[x] Modify sync service implementation
[x] Testing

below improvements were made on sync

all sync requests are queued and requests are synced periodically to the server.
Change service to be taken up later


Cant Enable DNS over TLS

Hello people i installed linux 18.04 to vps server and i cant enable DNS over TlS i used automate script to install dashboard.

I reinstalled server and wg-dashboard and option enabled but when i tried to edit Server settings after saving settings it dissabled automaticaly why that??

Same problem here, use it on Ubuntu 18.04 TLS, any thoughts?


Test Case Reduction

Introduce a tool that is able reduce bugs we find in a reliable fashion.

We have tool here https://github.com/p4gauntlet/pruner.
It will be integrated soon.


on extended second screen stuck in lower edge

On a single screen your application works wonderfully, but once the mouse cursor reaches another extended screen it goes downwards to the edge of the screen and is stuck there; no way to move the cursor anymore in normal mode.

i did notice this when using a friend's computer recently ... i am not sure why this happens . i'm sure i used to use this on a multimonitor system with both 2 and 3 screens with no hitches when i was a developer .

(fat thumbed close button)

one thing i can think of is that i always had my first 2 monitors slightly offset vertically , which may have masked the bug .
i don't have good access to a windows machine any more to test this on , but i will attempt a patch nonetheless .

I cannot reproduce that it works on two screens with either vertical offset (first screen below/above the other one) between them

awesome discovery  !  but uh . ummm . well , i assume this is still a problem for you though ?  i may have access to a Windows PC soon and can try and come up with a version using MoveMouseToMonitor and accounting for scaling  . Any idea how we can figure out what the scaling is ?...

Apparently there is a built-in variable to figure out the DPI scaling.

huh . turns out it was a 1-line fix  xD . . . i thought i was going to have to gut the whole thing and manually deal with per-monitor DPI  , but on a whim , i decided to just throw that line in and presto

Wow, thank you very much!


revocation

don't know if that's intentional, but it seems like the button on the right should say something like "Remove votes" or "Revoke" instead of "Vote" when people are removing their votes from a ballot.

closing as pre-release issue


Can't install on Debian 8 64 bit

I get this error when installing on my laptop with OS Debian 8 64 bit:

Possibly related to #10255?

@rieftux Please go through some work arounds suggested in  #10255
If that doesn't fix the problem, please update  #10255 with this issue details.
Closing duplicate.


Include Uninstall in makefile

Add option to clean remove the installed script script .

Thanks for the PR, it is merged in #7


Playground Frontend Test workflow (#24728)

Addresses #24728

This PR adds auto-testing with unit tests and integration tests. They run on all PRs and pushes that affect /playground/frontend.
Linter and formatting are commented out because we have many issues there and we fix them on per-file basis when we otherwise change files.
To trigger tests before this is merged:

Fork this branch.
Change any file under /playground/frontend

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

LGTM (internal review)

R: @damondouglas

lgtm thanks y'all!