Safe Links supportability in Office 2016

Inside the "Safe Links settings for Office apps" section at the first bullet point you mention that the client requirements for Safe Links are Microsoft 365 Apps or Microsoft 365 Business Premium. However, on the second bullet point "Office apps are configured to use modern authentication" you also mention Office 2013, 2016 and 2019 which after testing it is proven that they are not working! Can you please clearly verify whether Safe Link policies are only supported in Microsoft 365 Apps, and they are not supported in other Office versions (e.g. 2016)?
Thank you,
George

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e6524290-9545-28fc-9cae-5c4a540ad526
Version Independent ID: e6524290-9545-28fc-9cae-5c4a540ad526
Content: Complete Safe Links overview for Microsoft Defender for Office 365 - Office 365
Content Source: microsoft-365/security/office-365-security/safe-links-about.md
Service: microsoft-365-security
Sub-service: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

Checking

Hello @chrisda. Thank you for your reply. Still the narrative is a little bit confusing. In my opinion it should be written in a way that it clearly says that the only supported clients for Safe Links to work are Microsoft 365 Apps or Microsoft 365 Business Premium and that at the same time Modern Authentication must be enabled in Exchange Online. Finally, just put a note or attention box that will remind everyone that with modern auth enabled the following supported versions of Office are supported or need to be configured in certain way.

Hello @chrisda. Thank you for your reply. Still the narrative is a little bit confusing. In my opinion it should be written in a way that it clearly says that the only supported clients for Safe Links to work are Microsoft 365 Apps or Microsoft 365 Business Premium and that at the same time Modern Authentication must be enabled in Exchange Online. Finally, just put a note or attention box that will remind everyone that with modern auth enabled the following versions of Office are supported or need to be configured in certain way to work.

@gesmyrli, I rewrote it to say this (changes in bold):

Safe Links protection for Office apps has the following client requirements:

Microsoft 365 Apps or Microsoft 365 Business Premium:

Current versions of Word, Excel, and PowerPoint on Windows, Mac, or in a web browser.
Office apps on iOS or Android devices.
Visio on Windows.
OneNote in a web browser.
Outlook for Windows when opening saved EML or MSG files.

Supported Office apps and Microsoft 365 services are configured to use modern authentication. For more information, see How modern authentication works for Office client apps.

OK?


Make csv import more flexible

e.g. allow to change the column order in the csv import preview (see agenda import). Or change the separator (",", ";"). Similar like by csv import in libreoffice.

already done in motions csv import

I would like to test this.


Support OCP secrets with destination mount path

Summary
From user POV it's same as we already support for resources (config maps), I just wrote it slightly differently. Keycloak image has only certain dirs writable so I need to specify destination, but for certs can't use config maps as binary data needs to be base64 encoded as secrets do. I've tested it on what I am preparing for mTLS OIDC test (not that I'm done, but Keycloak starts with keystores and truststores).
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[ ] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[x] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

run tests

GH CI failures go down to the https://github.com/quarkus-qe/quarkus-test-framework/pull/991, luckily this PR changes can affect only OCP and nothing else. Let's pay attention to OCP CI please.


[Enhancement] Provide flag to package without devtools

Objective
Create a flag for the qbrt package command change the packaging process to exclude the devtool from the final bundle. If we can't exclude the devtools then make so they don't launch automatically.
Why?
This might be easy to do and will be required for when the project is more mature anyway.

Indeed, it's a good idea, and we should be able to exclude them. In fact, I'd make that the default behavior (and add a flag like --with-devtools to include them). We'll just have to ensure that something sensible happens if the app calls Runtime.openDevTools when the devtools aren't available.
Also, note that we currently package all of browser/, not only the devtools. We shouldn't do that, per /bin/postinstall.js#L221. But that can be a separate issue.


'vscode': '>=1.48.0 <1.56.0' is not a valid "engines" entry in package.json

Enable 'engines' in the Manifest (package.json) to accept this entry "vscode": ">=1.48.0 <1.56.0"
As described here https://stackoverflow.com/questions/51596127/node-engine-8-x-or-10-x-in-package-json
"engines": {
   "vscode": ">=1.48.0 <1.56.0"
 },

should be a valid entry on the package.xml. But VSCode is not parsing it.

We currently only support the ^1.48.0, >=1.48.0 and 1.48.x syntax. What exactly is the use case you have where you would need such a syntax? Is your extension offering support for older versions of VS Code? If yes, then why? The VS Code team only supports the latest stable version.

@alexdima I was having a problem similar to this. I needed my extension to only support between version 1.41 and up, but below 1.56. This is because in April, the latest version 1.56.1 and up would cause our extension to not work.

@alexdima my extension stopped to work on 1.56. I did everything I could to help your team to identify and fix the bug, but nothing was done. After a month waiting for a solution, I just gave up and decided to stop supporting to my extension.
https://github.com/microsoft/vscode/issues/123281


KHR_texture_transform support?

It seems that this code has disappeared: https://github.com/KhronosGroup/glTF-Blender-IO/search?q=KHR_texture_transform&unscoped_q=KHR_texture_transform
https://github.com/KhronosGroup/glTF-Blender-IO/commit/2786bbd8de72f48bf66189bca09956b24494f818

It just has been moved:

I mean that the term, "KHR_texture_transform" no longer appears anywhere in this codebase, except in the description of that checkbox — the code has accidentally been removed, I think. A test export confirms this isn't working:

Would definitely love to see this feature. IMHO, if the transforms are displaying in the renderer, it would be amazing (and would make the most sense) if they where exported.
The Texture Coordinate + Mapping + Image Texture configuration seems to be fairly common (so common in fact that Ctrl + T does this automatically with Node Wrangler), so holding out hope that this can be translated effectively in export.
Keep up the great work!

@julienduroure Can you push the latest?  Thanks!

From Gitter, it sounds like KHR_texture_transform was working for @dsinni. @EtagiBI could you share a screenshot of the material configuration as well, and ensure you've enabled the Texture Transforms export option?

@EtagiBI could you share a screenshot of the material configuration as well, and ensure you've enabled the Texture Transforms export option?
Works fine with todays build of Blender. Thanks.


Promise.all([]) not allowed

Promise.all/Promise.race can accept an empty array, but after 74d3029de2c3bada8d27de37d31c6718de69f253 they are not accepted in this polyfill.

Thanks for the bug report. I will fix it right away tonight. Sorry about that. I will make sure it’s added to the test suite. Can you point to 8.1.0 temporarily?

Fixed in 8.1.2. Thanks again for the bug report https://github.com/taylorhakes/promise-polyfill/releases/tag/8.1.2


[BUG] BrokenPipe Crash

Issue
Setup:
deno 1.6.3 (release, x86_64-unknown-linux-gnu)
v8 8.8.294
typescript 4.1.3

Opine Version: 1.0.0

Uncaught BrokenPipe: Broken pipe (os error 32)

Details

Hello, it's been a while since Opine crashed randomly with a system error, at the time it was on my mac, now on my windows and also on a linux server, the error returned is still the same:

error: Uncaught (in promise) BrokenPipe: Broken pipe (os error 32)
    at unwrapResponse (deno:runtime/js/10_dispatch_minimal.js:59:13)
    at sendAsync (deno:runtime/js/10_dispatch_minimal.js:98:12)
    at async write (deno:runtime/js/12_io.js:117:20)
    at async BufWriter.write (bufio.ts:499:29)
    at async writeResponse (_io.ts:273:15)
    at async Proxy.respond (server.ts:84:7)
    at async Response.end (response.ts:256:7)

Maybe you have to surround Opine with a try catch?
The crash occurs with any code that uses opine, however I noticed that the more routes there are, the more often it happens

Hey @techtastet :wave:
So Opine is designed currently to catch some errors that are thrown from Deno's Http std lib as you can see here --> https://github.com/asos-craigmorten/opine/blob/main/src/response.ts#L256, namely instances of Deno.errors.BadResource as this is an indicator that the connection has already been closed.
Other than that, the responsibility of error handling lies with your code to add appropriate error handling, either by adding an error middleware to your application, or adding catchs around your middleware code, e.g.
try {
  await res.end();
} catch(e) {
  // ... do something with the error.
}

Check out the error examples and the Error-handling middleware section of the API docs.
Let me know if need further assistance. If you believe it is an issue with Opine, please provide a reproduce-able code example 😄

Hey @techtastet :wave:
So Opine is designed currently to catch some errors that are thrown from Deno's Http std lib as you can see here --> https://github.com/asos-craigmorten/opine/blob/main/src/response.ts#L256, namely instances of Deno.errors.BadResource as this is an indicator that the connection has already been closed.
Other than that, the responsibility of error handling lies with your code to add appropriate error handling, either by adding an error middleware to your application, or adding catchs around your middleware code, e.g.
try {
  await res.end();
} catch(e) {
  // ... do something with the error.
}

Check out the error examples and the Error-handling middleware section of the API docs.
Let me know if need further assistance. If you believe it is an issue with Opine, please provide a reproduce-able code example 😄

This appears to originate from a bug in the std library which has since been fixed. See:

https://github.com/denoland/deno/issues/8830
https://github.com/denoland/deno/issues/6319
https://github.com/denoland/deno/issues/6002

And was fixed in: https://github.com/denoland/deno/pull/8365
Please re-open if you are finding it still happens and provide a reproduceable example 😄

This appears to originate from a bug in the std library which has since been fixed. See:

https://github.com/denoland/deno/issues/8830
https://github.com/denoland/deno/issues/6319
https://github.com/denoland/deno/issues/6002

And was fixed in: https://github.com/denoland/deno/pull/8365
Please re-open if you are finding it still happens and provide a reproduceable example 😄

The issue still exist and it happens when the request is cancelled. I use OpineHttpProxy in this case too.

It seems that deno also can throw Deno.errors.BrokenPipe if a connection is closed unexpectedly (https://github.com/denoland/deno_std/issues/659#issuecomment-800419398), and it is not being caught in:
https://github.com/asos-craigmorten/opine/blob/fe9adf5f82703ab464adb3aecf29b05f542ce2f8/src/response.ts#L266-L273
Thus resulting in a server crash

Yeah, looks like closed this in error. We will need to handle Deno.errors.BrokenPipe errors emitted when calling the .next() on the server iterator.
TBC if can wrap the response
https://github.com/asos-craigmorten/opine/blob/fe9adf5f82703ab464adb3aecf29b05f542ce2f8/src/response.ts#L256-L263
or if need to catch at the top-level loop
https://github.com/asos-craigmorten/opine/blob/fe9adf5f82703ab464adb3aecf29b05f542ce2f8/src/application.ts#L569-L571
It sounds like we would benefit from moving from the async interator to a while loop where call .next() manually, e.g.
// ... rest of code

while (!closed) {
  try {
    const req = await server.next();
  } catch (e) {
    // handle Deno.errors.BrokenPipe and other errors
  }

  // ... rest of code
}

// ... rest of code

For future reference, I could reproduce it by
app.get("/",  function(req, res) {
  res.send("a ".repeat(9999999));
});

and spamming F5 in firefox.
This cancels the previous load before re-requesting the page. There is probably a better way, but this worked in a pinch.

Ah nice @Tc-001 that will be useful for repro + figuring out if fix. Can probably add a "racing server" like integration test similar to what the std/http module has for these kind of edge cases in real world apps.


Consider additional Async fns

Off the top of my head, it may be useful to provide:

unwrap / expect or some variant
Conversions between Option<T>.

If we can convert Async to Option, does Async need to have it's own explicit unwrap/expect functions as well?
Pros of having explicit functions:

No need for verbosity of async.into().unwrap()
Better panic messages ("tried to unwrap Async result which isn't ready" over "tried to unwrap None value")

Cons:

Have to maintain extra functions for parity with Option, list may grow in the future (e.g. map, and_then, etc.)

I'd personally prefer to avoid these if we can (just cut down on API surface area), but if they're inevitable they're inevitable. My preference would be to go the route of Result and perhaps add a .ready() method returning Option<T>, then you've got all the normal methods.
@ipetkov Result<Option<T>, E> unfortunately got too unwieldy with Stream, where the return type would be Result<Option<Option<T>>, E> and the readability of a match decreased drastically. Having the readable Async<T> in the middle ended up fixing that problem, though.

@alexcrichton Definitely not advocating against Async, just weighing benefits of duplicating Option APIs on it!
That said, using ready() seems like a good compromise to avoid the manual duplication effort!

I added this to the 0.2 release awhile back, but I don't think it should block it, we can always add functions at any time.

I would find an Async::and_then() which is like map but for fallible conversions (deserialization, etc.) useful.
Compare
match inner_future.poll().map_err(Into::into)  {
    Ok(Async::Ready(val)) => transform(val).map(Async::Ready),
    other => other,
}

to
self.inner_future.poll().map_err(Into::into).and_then(|async| async.and_then(transform))

I'm gonna close this issue -- folks can feel free to open PRs with specific proposals.


Updating commit convention

Instead of fixes into every commit: "fixes #XX" in the PR description and we'd like to use "issue #XX" in the individual commits since the PR as a whole fixes the issue.

was moved to https://github.com/ai-cfia/.github/pull/10


[SPARK-50385][CORE] Use class name prefix for REST Submission API thread pool

What changes were proposed in this pull request?
This PR aims to use a meaningful class name prefix for REST Submission API thread pool instead of the default value of Jetty QueuedThreadPool, "qtp"+super.hashCode().
https://github.com/dekellum/jetty/blob/3dc0120d573816de7d6a83e2d6a97035288bdd4a/jetty-util/src/main/java/org/eclipse/jetty/util/thread/QueuedThreadPool.java#L64
Why are the changes needed?
This is helpful during JVM investigation.
BEFORE (4.0.0-preview2)
$ SPARK_MASTER_OPTS='-Dspark.master.rest.enabled=true' sbin/start-master.sh
$ jstack 28217 | grep qtp
"qtp1925630411-52" #52 daemon prio=5 os_prio=31 cpu=0.07ms elapsed=19.06s tid=0x0000000134906c10 nid=0xde03 runnable  [0x0000000314592000]
"qtp1925630411-53" #53 daemon prio=5 os_prio=31 cpu=0.05ms elapsed=19.06s tid=0x0000000134ac6810 nid=0xc603 runnable  [0x000000031479e000]
"qtp1925630411-54" #54 daemon prio=5 os_prio=31 cpu=0.06ms elapsed=19.06s tid=0x000000013491ae10 nid=0xdc03 runnable  [0x00000003149aa000]
"qtp1925630411-55" #55 daemon prio=5 os_prio=31 cpu=0.08ms elapsed=19.06s tid=0x0000000134ac9810 nid=0xc803 runnable  [0x0000000314bb6000]
"qtp1925630411-56" #56 daemon prio=5 os_prio=31 cpu=0.04ms elapsed=19.06s tid=0x0000000134ac9e10 nid=0xda03 runnable  [0x0000000314dc2000]
"qtp1925630411-57" #57 daemon prio=5 os_prio=31 cpu=0.05ms elapsed=19.06s tid=0x0000000134aca410 nid=0xca03 runnable  [0x0000000314fce000]
"qtp1925630411-58" #58 daemon prio=5 os_prio=31 cpu=0.04ms elapsed=19.06s tid=0x0000000134acaa10 nid=0xcb03 runnable  [0x00000003151da000]
"qtp1925630411-59" #59 daemon prio=5 os_prio=31 cpu=0.06ms elapsed=19.06s tid=0x0000000134acb010 nid=0xcc03 runnable  [0x00000003153e6000]
"qtp1925630411-60-acceptor-0<EMAIL_ADDRESS>(http/1.1)}{M3-Max.local:6066}" #60 daemon prio=3 os_prio=31 cpu=0.11ms elapsed=19.06s tid=0x00000001317ffa10 nid=0xcd03 runnable  [0x00000003155f2000]
"qtp1925630411-61-acceptor-1<EMAIL_ADDRESS>(http/1.1)}{M3-Max.local:6066}" #61 daemon prio=3 os_prio=31 cpu=0.10ms elapsed=19.06s tid=0x00000001314ed610 nid=0xcf03 waiting on condition  [0x00000003157fe000]

AFTER
$ SPARK_MASTER_OPTS='-Dspark.master.rest.enabled=true' sbin/start-master.sh
$ jstack 28317 | grep StandaloneRestServer
"StandaloneRestServer-52" #52 daemon prio=5 os_prio=31 cpu=0.09ms elapsed=60.06s tid=0x00000001284a8e10 nid=0xdb03 runnable  [0x000000032cfce000]
"StandaloneRestServer-53" #53 daemon prio=5 os_prio=31 cpu=0.06ms elapsed=60.06s tid=0x00000001284acc10 nid=0xda03 runnable  [0x000000032d1da000]
"StandaloneRestServer-54" #54 daemon prio=5 os_prio=31 cpu=0.05ms elapsed=60.06s tid=0x00000001284ae610 nid=0xd803 runnable  [0x000000032d3e6000]
"StandaloneRestServer-55" #55 daemon prio=5 os_prio=31 cpu=0.09ms elapsed=60.06s tid=0x00000001284aec10 nid=0xd703 runnable  [0x000000032d5f2000]
"StandaloneRestServer-56" #56 daemon prio=5 os_prio=31 cpu=0.06ms elapsed=60.06s tid=0x00000001284af210 nid=0xc803 runnable  [0x000000032d7fe000]
"StandaloneRestServer-57" #57 daemon prio=5 os_prio=31 cpu=0.05ms elapsed=60.06s tid=0x00000001284af810 nid=0xc903 runnable  [0x000000032da0a000]
"StandaloneRestServer-58" #58 daemon prio=5 os_prio=31 cpu=0.06ms elapsed=60.06s tid=0x00000001284afe10 nid=0xcb03 runnable  [0x000000032dc16000]
"StandaloneRestServer-59" #59 daemon prio=5 os_prio=31 cpu=0.05ms elapsed=60.06s tid=0x00000001284b0410 nid=0xcc03 runnable  [0x000000032de22000]
"StandaloneRestServer-60-acceptor-0<EMAIL_ADDRESS>(http/1.1)}{M3-Max.local:6066}" #60 daemon prio=3 os_prio=31 cpu=0.13ms elapsed=60.05s tid=0x000000015cda1a10 nid=0xcd03 runnable  [0x000000032e02e000]
"StandaloneRestServer-61-acceptor-1<EMAIL_ADDRESS>(http/1.1)}{M3-Max.local:6066}" #61 daemon prio=3 os_prio=31 cpu=0.12ms elapsed=60.05s tid=0x000000015cd1c810 nid=0xce03 waiting on condition  [0x000000032e23a000]

Does this PR introduce any user-facing change?
No, the thread names are accessed during the debugging.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.

Could you review this PR, @panbingkun ?

Thank you so much, @panbingkun .

All tests passed already in the first commit, 6c9bdd1.
I just resolved the conflicts.
Since this is a one-liner PR, could you try to merge this PR via the following script, @panbingkun ?

https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py

All tests passed already in the first commit, 6c9bdd1.
I just resolved the conflicts.
Since this is a one-liner PR, could you try to merge this PR via the following script, @panbingkun ?

https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py

Okay, let me try, Thank you very much for providing me with such detailed guidance, ❤!

Merged to master.
Thank you, @dongjoon-hyun and @yaooqinn.

Thank you again to @dongjoon-hyun for guiding me step by step towards progress ❤ !

Thank you, @panbingkun and @yaooqinn .
To @panbingkun , I'm happy we are in the same Spark community! 😄

Thank you again to @dongjoon-hyun for guiding me step by step towards progress ❤ !


grt: snap pin position on grid only when track is not at the edge of the shape

Fix https://github.com/The-OpenROAD-Project/OpenROAD/issues/1197
Signed-off-by: Eder Monteiro<EMAIL_ADDRESS>

Maybe a small test case would be good?


Add Quality Control Outputs

This pipeline as it stands takes fastq files, and produces bams + filtered vcfs, using GATK standard hard filters. It produces a few quality control outputs, such as basic bam statistics and a few things like SNPs per interval, but we do not produce extensive QC reports or output.
At a minimum, we should add calculations of mappability, coverage, and callable site bed files (using customizable rules for mappability and coverage cutoffs). These will aid in filtering and are necessary for any additional downstream steps. This requires at least the following:

[ ] A rule or rules to calculate per-sample coverage from each bam file in a compressed format. Potentially also use this to produce a summed coverage file and a mean coverage file. Space is an issue as even in bigBedGraph format these can be large files. May want to consider smoothing coverage values for better compression and efficiency of bedGraphs.
[ ] A rule or rules to calculate mappability for each reference genome and produce a bedGraph of mappability scores
[ ] A rule or rules to take coverage and mappability bedGraphs and produce a callable sites bed file.

A second level of quality control that would be valuable is an assessment of individual-level problems, ideally to identify individuals with excess missing data or other departures from expectations. This could also include screening for related individuals. Ideally this step would output a variety of sample lists that can be used in downstream filitering, e.g. one of just the high quality unrelated individuals, and one of all high quality individuals regardless of relatedness. First steps here might be:

[x] A rule or rules to compute missingness per individual and plot missingness vs coverage.
[x] Code that tries to automate the determination of "bad" individuals based on configurable cutoffs and deviations from regression line (e.g., individuals with too much missing data relative to predicted for coverage may be problematic even if the absolute level of missingness is not too high)
[x] A rule or rules to compute relatedness, and ideally also identify clusters of relatives and select the best based on some objective criteria (missing data?) of the set to retain for analyses that exclude relatives. Methods to calculate relatedness depend to a certain extent on coverage so this may be complicated to implement smoothly and generically.

Another level of quality control would be to implement some basic analyses that can help spot problems. The simplest option here is probably PCA, but various STRUCTURE-like options may also be of interest.

[x] A rule or rules to run and plot PCA.

Need to decide whether haploidifying low-coverage data is worthwhile here.
Also need to decide how tunable to make LD pruning.

[x] A rule or rules to run and plot ADMIXTURE or something similar, perhaps also with pong-style visualizations.

Finally, at the moment we do not provide much in the way of tunable filtering options or other assessments of site-based quality, beyond fixed GATK filter commands and the callable sites bed file. There are of course other options for extending site-based filtering in various ways:

[x] Add rule to plot distributions of filtering statistics? May be too complicated and of little value, at least until we move towards better variant filtering options. But could also be useful to start to see when filtering options don't do much. This is probably best done in conjunction with, e.g. Ts/Tv rate and things like that.
[x] Add rule to implement other site-filtering metrics, such as departures from HWE. Need to be careful here as population structure could be present in many sample sets. Might be a way to use results from PCA/STRUCTURE to define groups to test for HWE departures in, but would likely get hard to automate.

Adding some notes based on Zoom discussion 9/20.

Erik has code that already handles a fair bit of the plotting and downstream analysis: PCA, missingness vs depth, distributions of filtering statistics. The plan is for @erikenbody and @cademirch to pick the commits that add this code and submit a pull request to add this functionality to the main repository.
The coverage calculations need to be ported from old code in the manuscript repository and probably rewritten.
Relatedness calculations is on deck to be written next.

Adding another comment, as after running a few of these pipelines I am starting to think that some other QC would be useful to see.
One that would be very useful is just some kind of crude SNPs/bp plot, as that can be a quick visual way to identify problematic scaffolds. This probably needs the mappability and coverage beds done first to ensure that completely filtered windows don't end up problematic. However, a simple first step would be to add a rule that computes SNPs per bp and add a plot to the QC output that summarizes this per chromosome/scaffold (perhaps ignoring scaffolds less than some size threshold), or perhaps per interval. That would be a quick way to see problems.
Also, I think some basic filtering data would be useful, just a bit of information on how many snps are filtered, and perhaps Ts/Tv ratios for different classes of filtered sites or something. I think we can leave more detailed exploration of filtering to a later project, though.


Support numeric types other than 32bit integers

Bicep version
v0.1.37-alpha
Describe the bug
When I try to add a parameter that takes a large input ,like the following, i receive an error
Error BCP010: Expected a valid 32-bit signed integer
param sqlMaxSize int {
    default:<PHONE_NUMBER>
}

However, 'maxSizeBytes' of Microsft.Sql/servers/databases allows larger than 32-bit int

does this work if you were to adjust the defaultValue in the ARM template JSON? I think that is (supposed to be) the max size for a parameter of type int, but it is possible that SQL accepts that.

FWIW the JSON spec doesn't define a maximum number size. NewtonSoft.Json (the library used by ARM and many RPs to process JSON) allows numbers up to 380 digits long; we should probably update Bicep to align:
https://github.com/JamesNK/Newtonsoft.Json/blob/666d9760719e5ec5b2a50046f7dbd6a1267c01c6/Src/Newtonsoft.Json/JsonTextReader.cs#L60-L62
https://dotnetfiddle.net/iPcWhP

There's also the question of supporting other number formats like floats, decimals and binary/hex notations

@majastrz - do you know why we set the current limit on our int type?

This is a really good issue! Totally agree we should align with Newtonsoft for literal values, but need to confirm that the runtime handles them correctly.

Probably it is not related to that but certain ARM Template functions (like mul()) have limit on the maximum number supported. Was not very high limit but I do not remember how much. It can be easily tested though.

Probably it is not related to that but certain ARM Template functions (like mul()) have limit on the maximum number supported. Was not very high limit but I do not remember how much. It can be easily tested though.

Thanks for pointing this out. That's definitely something we'll need to be careful with.

FY I've updated the title to cover other numeric types

In the runtime we have two types: int and number. The latter covers floating point numbers and big integers. Some of the functions can use ints and some use number types. (I left TODOs in bicep on functions that support the number type.) The runtime allows number in literal values and maybe also in param/var values (the latter part needs to be verified).
I think the bare minimum we can do is match the runtime behavior in bicep. Ideally, I would like to remove the distinction between int and number from the runtime entirely but I don't know how feasible that would be. I don't think we should be adding more number types to bicep, though.

To unblock, you can use a string parameter type which this resource type will accept. We'd like to do a short-term fix to allow you to use the int type with these large values, and then do a more proper fix that @majastrz detailed above.

Idea - could we use 'simple' integers (5, 100, 100000) for 32bit int and with .0 (5.0, 100.0) for number type? That would solve the problem and as @majastrz wrote - it would align types with the runtime.

Idea - could we use 'simple' integers (5, 100, 100000) for 32bit int and with .0 (5.0, 100.0) for number type? That would solve the problem and as @majastrz wrote - it would align types with the runtime.

Idea - could we use 'simple' integers (5, 100, 100000) for 32bit int and with .0 (5.0, 100.0) for number type? That would solve the problem and as @majastrz wrote - it would align types with the runtime.

Note that we don't technically need to be able to disambiguate at the syntax level - it would be perfectly fine to interpret '1234' as an int, and '1234567890123456789' as a number.
Personally I feel like enforcing this is going to confuse people - e.g. if you have:
var diskSize =<PHONE_NUMBER> // 1Gb

And then decide to double it:
var diskSize =<PHONE_NUMBER> // 2Gb

You then get a syntax error and are forced to use a totally different syntax which you may not be familiar with:
var diskSize =<PHONE_NUMBER>.0 // 2Gb

Idea - could we use 'simple' integers (5, 100, 100000) for 32bit int and with .0 (5.0, 100.0) for number type? That would solve the problem and as @majastrz wrote - it would align types with the runtime.

Note that we don't technically need to be able to disambiguate at the syntax level - it would be perfectly fine to interpret '1234' as an int, and '1234567890123456789' as a number.
Personally I feel like enforcing this is going to confuse people - e.g. if you have:
var diskSize =<PHONE_NUMBER> // 1Gb

And then decide to double it:
var diskSize =<PHONE_NUMBER> // 2Gb

You then get a syntax error and are forced to use a totally different syntax which you may not be familiar with:
var diskSize =<PHONE_NUMBER>.0 // 2Gb

My choices (in order of preference) would be:

Review the functions that only allow 'int' and not 'number'. If it's only functions like range() and substring(), I wouldn't have too much heartburn if we didn't catch misuse (e.g. range(0, 0.123)) - if it allows us just to simplify and create a single 'number' type which encapsulates int, float & bigint - to align with JSON.
Consider number a subtype of int, and use the literal value to interpret whether the value is an int type or a number type.

Having said that, I have a hard time imagining how we're going to make this work reliably with distinct 'number' types, when the underlying platform does not clearly disambiguate between them - feels like there are far too many edge cases. For example:
// integer by integer division without a decimal - int or float?
var isThisAnInt = 1024 / 8

// integer by integer division with a decimal - int with overflow or float?
var isThisAnInt = 1024 / 9

// integer by integer division - do we overflow in the multiplication, or return a bigint type?
var isThisAnInt = 1024 * 1024 * 1024 * 1024

// the type declaration is named 'int' - but this can technically take a float value. Should we treat this as a number or an int?
param int myFloat

param int largeInt
param int largeInt2
// What happens here? We can only really safely assume `shouldBeNumber` is a number type or we face overflow.
var shouldBeNumber = largeInt * largeInt2

My choices (in order of preference) would be:

Review the functions that only allow 'int' and not 'number'. If it's only functions like range() and substring(), I wouldn't have too much heartburn if we didn't catch misuse (e.g. range(0, 0.123)) - if it allows us just to simplify and create a single 'number' type which encapsulates int, float & bigint - to align with JSON.
Consider number a subtype of int, and use the literal value to interpret whether the value is an int type or a number type.

Having said that, I have a hard time imagining how we're going to make this work reliably with distinct 'number' types, when the underlying platform does not clearly disambiguate between them - feels like there are far too many edge cases. For example:
// integer by integer division without a decimal - int or float?
var isThisAnInt = 1024 / 8

// integer by integer division with a decimal - int with overflow or float?
var isThisAnInt = 1024 / 9

// integer by integer division - do we overflow in the multiplication, or return a bigint type?
var isThisAnInt = 1024 * 1024 * 1024 * 1024

// the type declaration is named 'int' - but this can technically take a float value. Should we treat this as a number or an int?
param int myFloat

param int largeInt
param int largeInt2
// What happens here? We can only really safely assume `shouldBeNumber` is a number type or we face overflow.
var shouldBeNumber = largeInt * largeInt2

According to documentation (https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-syntax#data-types), only int as a type is specified. I run some tests, and it seems that ARM does not have problem in receiving nor outputting large integer values:
{
  "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
  "contentVersion": "<IP_ADDRESS>",
  "parameters": {
    "parameter1": {
      "type": "int",
    }
  },
  "resources": [],
  "outputs": {
    "output1": {
      "type": "int",
      "value": "[parameters('parameter1')]"
    },
    "output2": {
      "type": "int",
      "value": "[mul(1024,mul(1024,mul(1024,mul(1024,1024))))]"
    }
  }
}

    "outputs": {
      "output1": {
        "type": "Int",
        "value":<PHONE_NUMBER>776
      },
      "output2": {
        "type": "Int",
        "value":<PHONE_NUMBER>776
      }
    },
    "parameters": {
      "parameter1": {
        "type": "Int",
        "value":<PHONE_NUMBER>776
      }
    },

Therefore I think at least we should align with ARM and make int a 64bit, not the 32 one.
As I browse through docs, I don't see anywhere type number mentioned - I found float only and it's used only as input for some resources - it cannot be neither inputted or outputted.
Even if json allows me to put 3.14 as input parameter value for parameter of type int, it fails on deployment with Template parameter JToken type is not valid. Expected 'Integer'. Actual 'Float'. error. As far as I remember (and SO confirms, see https://stackoverflow.com/questions/43919465/make-newtonsoft-jsonconvert-default-to-int32-rather-than-int64), Newtonsoft.Json parses values without point to long by default.
To sum up I propose following:

[ ] - change int32 to int64
[ ] - support float with limitations: not an input or output - only to use in supported resources' properties.

We could make a separate issue for float support and limit scope of this change to original case - int64 support.
WDYT?

According to documentation (https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/template-syntax#data-types), only int as a type is specified. I run some tests, and it seems that ARM does not have problem in receiving nor outputting large integer values:
{
  "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
  "contentVersion": "<IP_ADDRESS>",
  "parameters": {
    "parameter1": {
      "type": "int",
    }
  },
  "resources": [],
  "outputs": {
    "output1": {
      "type": "int",
      "value": "[parameters('parameter1')]"
    },
    "output2": {
      "type": "int",
      "value": "[mul(1024,mul(1024,mul(1024,mul(1024,1024))))]"
    }
  }
}

    "outputs": {
      "output1": {
        "type": "Int",
        "value":<PHONE_NUMBER>776
      },
      "output2": {
        "type": "Int",
        "value":<PHONE_NUMBER>776
      }
    },
    "parameters": {
      "parameter1": {
        "type": "Int",
        "value":<PHONE_NUMBER>776
      }
    },

Therefore I think at least we should align with ARM and make int a 64bit, not the 32 one.
As I browse through docs, I don't see anywhere type number mentioned - I found float only and it's used only as input for some resources - it cannot be neither inputted or outputted.
Even if json allows me to put 3.14 as input parameter value for parameter of type int, it fails on deployment with Template parameter JToken type is not valid. Expected 'Integer'. Actual 'Float'. error. As far as I remember (and SO confirms, see https://stackoverflow.com/questions/43919465/make-newtonsoft-jsonconvert-default-to-int32-rather-than-int64), Newtonsoft.Json parses values without point to long by default.
To sum up I propose following:

[ ] - change int32 to int64
[ ] - support float with limitations: not an input or output - only to use in supported resources' properties.

We could make a separate issue for float support and limit scope of this change to original case - int64 support.
WDYT?

I also started looking at possibility of changing int to long and I got blocked by:
namespace Azure.Deployments.Expression.Expressions
{
    public class JTokenExpression : LanguageExpression
    {
        public JTokenExpression(int value);
        public JTokenExpression(string value, TemplateErrorAdditionalInfo additionalInfo = null);

        public JToken Value { get; }

        public override void Accept(LanguageExpressionVisitor visitor);
        public override JToken EvaluateExpression(ExpressionEvaluationContext context, TemplateErrorAdditionalInfo additionalInfo = null);
    }
}

Constructor accepts int and string - and that's a blocker to support long (for float we'd use float() function)

I also started looking at possibility of changing int to long and I got blocked by:
namespace Azure.Deployments.Expression.Expressions
{
    public class JTokenExpression : LanguageExpression
    {
        public JTokenExpression(int value);
        public JTokenExpression(string value, TemplateErrorAdditionalInfo additionalInfo = null);

        public JToken Value { get; }

        public override void Accept(LanguageExpressionVisitor visitor);
        public override JToken EvaluateExpression(ExpressionEvaluationContext context, TemplateErrorAdditionalInfo additionalInfo = null);
    }
}

Constructor accepts int and string - and that's a blocker to support long (for float we'd use float() function)

I also started looking at possibility of changing int to long and I got a small blocker:
namespace Azure.Deployments.Expression.Expressions
{
    public class JTokenExpression : LanguageExpression
    {
        public JTokenExpression(int value);
        public JTokenExpression(string value, TemplateErrorAdditionalInfo additionalInfo = null);

        public JToken Value { get; }

        public override void Accept(LanguageExpressionVisitor visitor);
        public override JToken EvaluateExpression(ExpressionEvaluationContext context, TemplateErrorAdditionalInfo additionalInfo = null);
    }
}

Constructors exists for int and string only - which means that expression in bicep:
var x = 5 * 5 * 5 is converted to "x": "[mul(mul('5', '5'), '5')]" instead "x": "[mul(mul(5, 5), 5)]".
It does work, but does not look nice :)

I also started looking at possibility of changing int to long and I got a small blocker:
namespace Azure.Deployments.Expression.Expressions
{
    public class JTokenExpression : LanguageExpression
    {
        public JTokenExpression(int value);
        public JTokenExpression(string value, TemplateErrorAdditionalInfo additionalInfo = null);

        public JToken Value { get; }

        public override void Accept(LanguageExpressionVisitor visitor);
        public override JToken EvaluateExpression(ExpressionEvaluationContext context, TemplateErrorAdditionalInfo additionalInfo = null);
    }
}

Constructors exists for int and string only - which means that expression in bicep:
var x = 5 * 5 * 5 is converted to "x": "[mul(mul('5', '5'), '5')]" instead "x": "[mul(mul(5, 5), 5)]".
It does work, but does not look nice :)

@alex-frankel @anthony-c-martin @majastrz  any chance we can extend the library with constructor receiving long?

@alex-frankel @anthony-c-martin @majastrz  any chance we can extend the library with constructor receiving long?

I also started looking at possibility of changing int to long and I got a small blocker:
namespace Azure.Deployments.Expression.Expressions
{
    public class JTokenExpression : LanguageExpression
    {
        public JTokenExpression(int value);
        public JTokenExpression(string value, TemplateErrorAdditionalInfo additionalInfo = null);

        public JToken Value { get; }

        public override void Accept(LanguageExpressionVisitor visitor);
        public override JToken EvaluateExpression(ExpressionEvaluationContext context, TemplateErrorAdditionalInfo additionalInfo = null);
    }
}

Constructors exists for int and string only - which means that expression in bicep:
var x = 5 * 5 * 5 is converted to "x": "[mul(mul('5', '5'), '5')]" instead "x": "[mul(mul(5, 5), 5)]".
It does work, but does not look nice :)

Something like "x": "[mul(mul('5', '5'), '5')]" will not evaluate correctly at runtime. You will get an error like this: The template language function 'mul' expects its first
parameter to be of type 'Integer'. The provided value is of type 'String'.`

I also started looking at possibility of changing int to long and I got a small blocker:
namespace Azure.Deployments.Expression.Expressions
{
    public class JTokenExpression : LanguageExpression
    {
        public JTokenExpression(int value);
        public JTokenExpression(string value, TemplateErrorAdditionalInfo additionalInfo = null);

        public JToken Value { get; }

        public override void Accept(LanguageExpressionVisitor visitor);
        public override JToken EvaluateExpression(ExpressionEvaluationContext context, TemplateErrorAdditionalInfo additionalInfo = null);
    }
}

Constructors exists for int and string only - which means that expression in bicep:
var x = 5 * 5 * 5 is converted to "x": "[mul(mul('5', '5'), '5')]" instead "x": "[mul(mul(5, 5), 5)]".
It does work, but does not look nice :)

Something like "x": "[mul(mul('5', '5'), '5')]" will not evaluate correctly at runtime. You will get an error like this: The template language function 'mul' expects its first
parameter to be of type 'Integer'. The provided value is of type 'String'.`

@alex-frankel @anthony-c-martin @majastrz any chance we can extend the library with constructor receiving long?

Unfortunately, this library is used internally be several services, so we will have to be extremely careful about making a change like this.

@alex-frankel @anthony-c-martin @majastrz any chance we can extend the library with constructor receiving long?

Unfortunately, this library is used internally be several services, so we will have to be extremely careful about making a change like this.

@alex-frankel @anthony-c-martin @majastrz any chance we can extend the library with constructor receiving long?

Unfortunately, this library is used internally be several services, so we will have to be extremely careful about making a change like this.
I do realise but changing int to long should not have big impact, as int can be implicitly cast to long. But I do agree - this needs to be taken carefully.

But until then this issue is blocked, as we will not be able to write long values json files or we need to do some extra overhead like mul(int('0'),int('0')).

@alex-frankel @anthony-c-martin @majastrz any chance we can extend the library with constructor receiving long?

Unfortunately, this library is used internally be several services, so we will have to be extremely careful about making a change like this.
I do realise but changing int to long should not have big impact, as int can be implicitly cast to long. But I do agree - this needs to be taken carefully.

But until then this issue is blocked, as we will not be able to write long values json files or we need to do some extra overhead like mul(int('0'),int('0')).

json('1232132132131212') or int(31231221321321)?

json('1232132132131212') or int(31231221321321)?

it has to be json, int casts to C#'s int, not long - perhaps something to align? Seems that it might be a problem in certain resource providers, as we might not know if certain API will accept int32 or int64.

it has to be json, int casts to C#'s int, not long - perhaps something to align? Seems that it might be a problem in certain resource providers, as we might not know if certain API will accept int32 or int64.

Yeah, it has to be json(). The int function internally uses int.TryParse().
The user passing a number that is too large for the API isn't different than any other badly configured resource. So we feel it's fine if that fails at runtime. (It's also the responsibility of each RP to validate and produce an error on the PUT request if the request body exceeds their limits at runtime or preflight time.) We don't currently have any reliable metadata we could use to check this at compile-time. And even if we did, it'd be limited to situations where hard-coded numbers are being used.

Yeah, it has to be json(). The int function internally uses int.TryParse().
The user passing a number that is too large for the API isn't different than any other badly configured resource. So we feel it's fine if that fails at runtime. (It's also the responsibility of each RP to validate and produce an error on the PUT request if the request body exceeds their limits at runtime or preflight time.) We don't currently have any reliable metadata we could use to check this at compile-time. And even if we did, it'd be limited to situations where hard-coded numbers are being used.

I updated the PR. In plain usage (var x =<PHONE_NUMBER>13) it's being written to json file as a number (ExpressionEmitter uses JsonTextWriter.WriteValue that accepts long).
The workaround is only if long is a part of expression.
The PR does not handle floating point numbers - they still need to be handled - I'll open separate issue for it, as it's a little bit more tricky I think.

I updated the PR. In plain usage (var x =<PHONE_NUMBER>13) it's being written to json file as a number (ExpressionEmitter uses JsonTextWriter.WriteValue that accepts long).
The workaround is only if long is a part of expression.
The PR does not handle floating point numbers - they still need to be handled - I'll open separate issue for it, as it's a little bit more tricky I think.


the content isn't destroyed when $destroy is used in new Vue

Version
2.6.14
Reproduction link
codepen.io/jim-jw/pen/powemmX
Steps to reproduce
const app = new Vue({
el: '#app',
},
data: {
message: 'Hello Vue!'
},
});
app.$destroy();
What is expected?
this page is empty
What is actually happening?
this page has Hello Vue!

This is expected and has been reported before: you have to remove it yourself


Key Vault For D365 BC Issue

Hi all,
I am facing an issue with reading Key Vault from Azure using Dynamics Business Central codeunit App Key Vault Secret Provider. For the development, I am using a container-based Business Central Server instance.
Steps were done to configure the key vault:

Was created a Self-Signed certificate.
A key vault application was created on the Azure portal.
Added Dynamics 365 Business Central ISV Key Vault Reader.
Was added a certificate for the Key Vault reader.
Permissions were granted for the reader application.
Configured container Server Instance using script Set-BcContainerKeyVaultAadAppAndCertificate.ps1
Added link to key vault to the app.json
Added the code in the BC extension which should read the secrets.

The issue is that the Initialization of the key vault is passing successfully, but the secrets are not returning, no error rises, which does not allow to identify a reason why it's happening. Can anyone advise something to solve this issue? Maybe anything was missed from my side?

Hi! Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the AL compiler and developer tools of the latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal

Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company


Warning after upgrading to Expo 46 / Next.js 12.2

Thanks for all the effort on the recent PR to upgrade Solito.  I followed the diffs in https://github.com/nandorojo/solito/pull/137 and was able to upgrade our repo successfully.  The only thing I am seeing is the warning:
WARN  Constants.platform.ios.model has been deprecated in favor of expo-device's Device.modelName property. This API will be removed in SDK 45
I am not super worried about this, but also saw that there was some discussion about this warning during the upgrade process.  But didn't see anything specifically to fix it.  Our app is running fine but was wondering if people we're still seeing this and / or have been able to fix it?
In my yarn.lock:
<EMAIL_ADDRESS>  version "8.6.1"
  resolved "https://registry.yarnpkg.com/expo-asset/-/expo-asset-8.6.1.tgz#86355b3e231e8aa6cf68a456ce9746dff1478b48"
  integrity sha512-urbUp1YtwH2J0Qc3inGQJdqTjWKML77SeMNgff+iR9MUE8gDkFqSCDjrBi7i5Oj5DDtq43mmtDg8G8ei6Vchcg==
  dependencies:
    blueimp-md5 "^2.10.0"
    expo-constants "~13.2.2"
    expo-file-system "~14.1.0"
    invariant "^2.2.4"
    md5-file "^3.2.3"
    path-browserify "^1.0.0"
    url-parse "^1.5.9"

<EMAIL_ADDRESS>  version "13.1.1"
  resolved "https://registry.yarnpkg.com/expo-constants/-/expo-constants-13.1.1.tgz#78c26c760cc63cd5608bc4b51bd159d7339d8054"
  integrity sha512-QRVHrrMCLenBzWZ8M+EvCXM+jjdQzFMW27YQHRac3SGGoND1hWr81scOmGwlFo2wLZrYXm8HcYt1E6ry3IIwrA==
  dependencies:
    "@expo/config" "^6.0.14"
    uuid "^3.3.2"

<EMAIL_ADDRESS><EMAIL_ADDRESS>  version "13.2.4"
  resolved "https://registry.yarnpkg.com/expo-constants/-/expo-constants-13.2.4.tgz#eab4a553f074b2c60ad7a158d3b82e3484a94606"
  integrity sha512-Zobau8EuTk2GgafwkfGnWM6CmSLB7X8qnQXVuXe0nd3v92hfQUmRWGhJwH88uxXj3LrfqctM6PaJ8taG1vxfBw==
  dependencies:
    "@expo/config" "~7.0.0"
    uuid "^3.3.2"

poe-react-apps on  upgrade/solito-expo-next-deps ❯ yarn why expo-asset
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "expo-asset"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "_project_#expo-app#expo" depends on it
   - Hoisted from "_project_#expo-app#expo#expo-asset"
info Disk size without dependencies: "444KB"
info Disk size with unique dependencies: "2.81MB"
info Disk size with transitive dependencies: "13.16MB"
info Number of shared dependencies: 64
✨  Done in 0.40s.

Thanks!

Looks like this should help: https://github.com/expo/expo/issues/15110

I actually saw that and tried several of those resolutions but had missed one of them that ended up fixing it. Thank you!
I manually removed all expo-constant deps references from my yarn.lock and re-ran yarn and all good 👌🏻


[FEATURE REQ]: Track 2 Management SDKs: Exception type with error details for ARM Exceptions

Library or service name.
Azure Management libraries (not currently a management core, I don't think, but this is where this should go).
Is your feature request related to a problem? Please describe.
Currently, in Track 1 management SDKs, Exceptions contain serializable representations of the HttpRequest, HttpResponse and important information for lookign up errors in Azure logs.  This is especially useful in PowerShell, where exception details are written to a stream and can be processed by further cmdlets, but is generally useful in diagnosing issues with any .Net application that uses management SDKs.
What feature would you like to get added? What problem is it solving?
Add a new Exception type for ARM clients that includes ARM-specific headers for locating ARM logs:
RequestId
ClientRequestId
Add Request and Response data to existing RequestFailedException so that similar debugging mechanisms can be used for data plane SDKs.
Request Uri
Request Method (Verb)
Request Headers
Request Body (if small enough)
Response Status Code
Response Headers
Response Body (if small enough)
.Net SDK Generator for ARM should use this exception type for ARM service exceptions.

After offline discussion, we would do custom shared parsing in Azure.Core. We wouldn't use the generator to parse the error models (x-ms-error-response schemas). Instead, we would generalize some information we look for to parse out of the response to create the new exception information. This reduces the number of classes created and reduces the memory used to create a type that simply gets pulled apart into another type.

@AlexanderSher can you help to confirm if this issue has been fixed in the Azure.Core?

@HarveyLink please help to verify if this has been fixed or not

It collects some of the information https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/core/Azure.Core/src/RequestFailedException.cs#L129

The extra info method was created 9 months ago, it doesn't contain much infomation we need.
For the required info:

[ ] Request Uri
[ ] Request Method (Verb)
[ ] Request Headers
[ ] Request Body (if small enough)
[x] Response Status Code
[x] Response Headers
[x] Response Body (if small enough)

The Azure.Core team discussed this issue and we decided that adding the Request into the RequestFailedException type doesn't add much value and can lead to a confusing API:

The Request information can already be obtained for diagnostic purposes by enabling SDK logging.
The Request type is not exposed to end-users via client library methods. Instead, it is provided as a public type so that it can be inspected via custom pipeline policies in advanced scenarios. Adding it to the RequestFailedException would be confusing for most users as they never interact directly with the Request type, where as the RequestFailedException type is thrown for mainline scenarios.

For these reasons, we are going to close out this issue as not planned. Please feel free to reopen if you would like to discuss further.


Error Types

I am getting error types in my arduino IDE.  The errors are pointing to the MusicPlayer.h file
error: 'playingstatetype playingState', declared using anonymous type, is used but never defined [-fpermissive]
extern playingstatetype playingState;
error: 'typedef volatile enum playingstatetype' does not refer to the unqualified type, so it is not used for linkage [-fpermissive]
playingstatetype;
error: 'ctrlState_t ctrlState', declared using anonymous type, is used but never defined [-fpermissive]
extern ctrlState_t ctrlState;
error: 'typedef volatile enum ctrlState_t' does not refer to the unqualified type, so it is not used for linkage [-fpermissive]
ctrlState_t;
do you know why this may be ?

@rickybobby15 - same here, any luck resolving this?

Same for me. The interesting thing is we are already quite a few guys experiencing the same issue but there is response from Seedstudio. This may show their code is corrupted and the music shield is useless.

when using the newest Arduino IDE to compile the code errors above happened.
It's ok now,
Just delete volatile bufore typedef enum


Use polyfill for specific classes

Hi there
First thank you for the great work!
I already used this polyfill and it worked great when using the data attribute.
Would it be possible to also include the possibility to use it for arbitrary selectors without specifying the data attribute?
Sometimes there are cases, especially in a CMS, where we can only change a class or a class from an outside element.
It would be great if we could use it for example like this
objectFitPolyfill('.selector .to .image)
// or jQuery version
$('.selector .to .image').objectFitPolyfill()

Thanks, Razrael

With this one you can: https://github.com/bfred-it/object-fit-images
objectFitImages('.selector .to .image');


Ensure that config has converged before changing system version

FYI @hakonhall

Consider the comment, and merge if you have a reasonable answer :)

Ah, every 30 minutes isn't often. Not likely an issue :)


added a authenticate route and added basic form page

Please check the basic form page.
and here is how it looks,

the css styles may not be good now, but imporved it as far as i can.
thankyou.

i added a  .env file in the .gitignore file of temporary backend, it is required, since, the sensitive detials are in the .env , and it is not good to display in the repo. so i added the .env file in the .gitignore.

Hi, @rohan2734 . The authenticate page should be Login page, where the user has to enter username/password.
So it should look like ->

Username
Password
New User SignUp
And Login via facebook/google etc.
And a separate page for SignUp , where this form you created with more details will go.
So for now, just make this a login page, i'll raise a separate issue for signup page. You can claim that.

@ashishnagpal2498  bro, i have done the login page only or also called as signin. and i didnt add any details for signup page, where in signup page, you dont have the phone number, so the page which I have made is login page only aslo called as signin page.

please finalize ur  requested changes with comments , then i will  do the changes.

@ashishnagpal2498  will delete the phonenumber also, i will add in signup page.

@ashishnagpal2498  bro any more changes ?

LinkedIn and google logos don't look good try using proper logo

@rohan2734

Remove p tag from linkedIn, float property, don't apply background-color to icon.
Correct the color code for both linkedIn and Google options.
And your PR will be good to go.

Refer the above comment. Impt
Because you have used  tag that is why LinkedIn Icon is coming above.
Also the color code. How many times do I have to mention that ?
Compare your page ->
I corrected that in inspect.

Don't you see any difference between your color codes and this ?

ok i will edit the color code, the last time you said me the color code only for google, but not linkedin, i will change, and please understand why i used float, once check it what happens if you remove it, i already said you what happens if you remove it.

do you want me to change the g+ icon also or ,is it ok? for signing in with Google.  ?

Just follow the steps I am mentioning in the PR review section.

Remove float property
Remove p tag
Remove background color from icon.
The alignment is totally wrong.
Can you see the difference ?
Use flex-property, dividing icon and text. Each text of the option should start with same place vertically.

@anushbhatia Kindly review the PR.

Maintaining spacing between the LinkedIn logo and the text

Maintaining spacing between the LinkedIn logo and the text

@anushbhatia , open the netlify link, the linkedIn icon is not what I asked for, as shown in above image. Do read the comments of PR review, you will get to know :)

Text is still not vertically aligned. And that cannot be done as those are of unequal length.
Using text-align center will make all the content to center. Due to unequal size the position of text mismatch.
The best way to solve this problem is by using flex-box.
Follow the steps and see the changes. Try to inspect the page and remove/add properties you will understand it better.

Make the anchor tag  as display flex. justify-content: center. Make the tag of same size as li no need of width. Use padding on li for keeping side space.
icons - flex-basis: 25px
text -> take a span and apply property flex-basis:160px
Remove text align- center from li and a tag

Can you see each text is aligned vertically. Do all the changes then only request a review.

@anushbhatia , This PR is ready to be merge. Let me know when should I.


Home location not set when launching pwsh.exe from WSL

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Open a WSL terminal and then launch pwsh.exe -wd ~. Previously, this would start PowerShell in C:\Users\parker. On v7.4.0 it first lists a bunch of errors from my profile due to $HOME not being defined, and then starts in the current WSL directory. Further attempts to cd ~ give the error:
Set-Location: Home location for this provider is not set. To set the home location, call "(get-psprovider 'FileSystem').Home = 'path'".

This issue shows up when launching pwsh.exe under tmux or from a regular WSL shell.
Expected behavior
PowerShell knows where the home directory is.

Actual behavior
`$HOME` is undefined and `cd ~` fails.

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.4.0
PSEdition                      Core
GitCommitId                    7.4.0
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

Nevermind. It turns out this blog post which suggests setting USERPROFILE/w in WSLENV, causes that variable to be deleted from the Windows environment. The correct way to share it with WSL is USERPROFILE/up.


New version: RussellBanks.Komac version 1.1.0

Pull request has been created with Komac v1.1.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Changes new hashing behavior to parse new as /subscribers/new

This PR corrects new as left tab behavior
Fixes: #27730

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Thanks! Please go through our guide on submitting a pull request to learn how to present your proposed changes to Zulip, so that your work can be reviewed.


CustomerRequest missing riskDataCustomerRequest element on XML generation

General information

SDK/Library version: 3.1.0
Environment: Doesn't matter
Language, language version, and OS: Java

Issue description
CustomerRequest https://github.com/braintree/braintree_java/blob/master/src/main/java/com/braintreegateway/CustomerRequest.java#L156
The method buildRequest does not add the element RiskDataCustomerRequest even though is it part of the Customer Request.
Test Case
    CustomerRequest customerRequest = new CustomerRequest();
    customerRequest.riskData().customerBrowser(USER_AGENT);
    customerRequest.riskData().customerIP(REMOTE_IP);
    customerRequest.customField("test_field", "test123);
    System.out.println(customerRequest.toXML());

will output
<customer>
    <customFields>
        <test_field>test123</test_field>
    </customFields>
</customer>

I think all that is required is to add the missing addElement statement.
i.e.
addElement("riskDataCustomerRequest", riskDataCustomerRequest).

@Stexxen Thanks for raising this issue. It looks like a bug in the SDK. We'll post here once we have a fix out for this.

@Stexxen We're also happy to accept PRs if this is something you're interested in fixing!

@sestevens Could be something we can do, but someone from Braintree will need to confirm that the XML tag
<riskDataCustomerRequest></riskDataCustomerRequest>

Is the correct tag, as I'm only guessing that's what it should be.

@Stexxen The tag should be:
<risk-data></risk-data>

It looks like the element is being added correctly in our .NET SDK: https://github.com/braintree/braintree_dotnet/blob/18dc68b57092258f5f5e7982a7b0146394a5bd97/src/Braintree/CustomerRequest.cs#L102.

unfortunately it looks like they use different XML schemas. (Do they use different endpoints?
Java (camelCase)
   addElement("deviceData", deviceData).
   addElement("paymentMethodNonce", paymentMethodNonce).
   addElement("defaultPaymentMethodToken", defaultPaymentMethodToken).

C# (snake-case)
  AddElement("device-data", DeviceData).
  AddElement("payment-method-nonce", PaymentMethodNonce).
  AddElement("default-payment-method-token", DefaultPaymentMethodToken).

Unless the implementation specific RequestBuilder does something to normalise the 2 naming conventions?

That said, it suggests that the Java line would either be
   addElement("riskData", riskDataCustomerRequest).

or
   addElement("riskData", riskDataCustomerRequest.riskData()).

Oh, good catch. The endpoint accepts XML tags in both dash case and camel case. So it would be
addElement("riskData", riskDataCustomerRequest).

@Stexxen This issue has been fixed in version 3.2.0 of the SDK.


Cell stuck when running a cell against a non  existent local venv

https://github.com/microsoft/vscode-jupyter/issues/12203#issuecomment-1331256270

Fixed with https://github.com/microsoft/vscode-jupyter/pull/12559


The size of tensor a (3) must match the size of tensor b (9) at non-singleton dimension 0

When I use beam search to generate caption for a picture on Colab, this error occurs. My transformers version is 4.25.1. And it works when I use nucleus sampling. How should I solve this

I commented out the line that causes error and uncommented the line below as a temporary solution

 I commented out the line that causes error and uncommented the line below as a temporary solution

Yeah, that's what I did. But it's strange that I can use these two methods in the official demo Colab notebook, but I can't use beam search when I write the code myself.

 I commented out the line that causes error and uncommented the line below as a temporary solution

And I succeeded after downgrading the transformers version to 4.16.0. But it seems that I cannot import AutoProcessor when using this version of transformers.

same issue

same issue， waiting for fixing

same issue

I suggest opening an issue with kohya_ss in his repo as he is the one maintaining the behind the scene code. I only wrap his script in a GUI: https://github.com/kohya-ss/sd-scripts

 When I use beam search to generate caption for a picture on Colab, this error occurs. My transformers version is 4.25.1. And it works when I use nucleus sampling. How should I solve this

Dude, I also ran into this problem when I changed sample = False to sample = True like this:

This will allow for successful execution. But I wonder why beam search doesn't work and only nuclear search can be used

 When I use beam search to generate caption for a picture on Colab, this error occurs. My transformers version is 4.25.1. And it works when I use nucleus sampling. How should I solve this

Dude, I also ran into this problem when I changed sample = False to sample = True like this:
This will allow for successful execution. But I wonder why beam search doesn't work and only nuclear search can be used

I have same problem and  using transformers=4.25.1  did not help

I found that when commented out the line in /model/blip.py line 131 fix the problem:

Don't know why, hope someone can provide the detail explanation down the hood.

When you comment out this line, the dimension 9 will be 3, so it can run. But this is not the beam search since you just keep one result!

in order to solve this problem you need to set num_beams=1 not 3. (for instance in blip_vqa.py line 92)

I solved this problem, if the transformers is 4.16.0, everything is ok. But I used the transformers4.36.2, in this case, in the 818 lines of the generation_utils.py of transformers:
you need to comment out the _expand_dict_for_generation function where the encoder_hidden_state was multiplied again with the beam search num!
Finally solved!!!

You should submit a PR to Koby’s in his sd-scripts repo to fix it for good.

Updating to 1.0.2 fixed it for me.

I used Transformers==4.17 and did not face further issues


VSTS to VSTS work item migration says not supported

I'm trying to migrate work items (VSTS to VSTS).  The WorkITemRevisionReplayMigrationContext says the following:
WorkItemRevisionReplayMigrationContext: 1 - Migrating: 5802 - User Story
WorkItemRevisionReplayMigrationContext: ...Replaying 8 revisions of work item 5802
WorkItemRevisionReplayMigrationContext: ...not supported
WorkItemRevisionReplayMigrationContext: Average time of 0:571 seconds per work item and 0 hours 0 minutes 0:000 seconds estimated to completion
Any ideas?

I was able to fix my problem by adding "User Story": "User Story" to the WorkItemTypeDefinition.


Adonis tests are failing when we setup application on different PC or location or after re-installing the dependencies.

Description
I don't know if this is a bug or not but all tests are failing when I set up the adonis application on a different location or PC or in case I delete the node_modules directory and re-install the npm dependencies. At the moment, I found two issues :

route from the test context is getting undefined.
loginAs function is not working.

Test 1

  test('Need email|mobile & password to login.', async ({ client, route }) => {
    const response = await client.post(route('api.login')).accept('json')

    response.assertStatus(422)

    response.assert?.containsSubset(response.body(), {
      errors: [{ field: 'email' }, { field: 'password' }],
    })
  })

Test 2
test('An authenticated user can see the list of categories too.', async ({ client, assert }) => {
    const categories = await CategoryFactory.createMany(5)

    const user = await UserFactory.create()

    const response = await client.get('/api/categories').loginAs(user).accept('json')

    response.assertStatus(200)

    response.assert?.equal(5, response.body()?.length)

    assert.containsSubset(response.body(), categories.map(({ id, type, name }) => ({ id, type, name })))
  })

These tests were passing when I set up the fresh AdonisJS application but failed after re-installing dependencies/relocating by repo clone. I have attached two screenshots of the test results.
Expected Behaviour
If route and loginAs functions were passing before push (Push to git repo) then it should be working when I clone the code and installl the dependencies in another location or PC.
Steps to Reproduce

Install the fresh adonis application via commands.
Write some functional tests (just like above I mentioned). Tests should utilize the functions route from the test context  and loginAs in test suite body. Tests should be passing.
Delete node_modules directory OR move application files to the new location without node_modules directory and install dependencies via yarn
Run the test command node ace test and the above two test examples will fail.

Package version
v2.0.7
Error Message & Stack Trace

Relevant Information

Do you have .env.test file in the project root? If yes, what is the value of SESSION_DRIVE in it.
As a side note - We encourage everyone to use Github discussions and only use issues when something is confirmed as a verified bug

Okay, will create the discussion next time. Yes, I do have .env.test here is the content in it.
PORT=3334
HOST=<IP_ADDRESS>

NODE_ENV=development

APP_KEY=ILxcpFhAtxuEmQos7L0QF0qPui0FDn2N

DRIVE_DISK=local

SESSION_DRIVER=memory

CACHE_VIEWS=false

DB_CONNECTION=pg

PG_HOST=localhost
PG_PORT=5432
PG_USER=docker
PG_PASSWORD=secret
PG_DB_NAME=test_runner

SMTP_HOST=localhost
SMTP_PORT=587
SMTP_USERNAME=<username>
SMTP_PASSWORD=<password>

I have inspected this file:
"testProviders": [
    "@japa/preset-adonis/TestsProvider"
  ]

and seems it's not getting execute.

This morning I moved the application to new location without node_modules after installation of npm dependencies tests getting failed. and all fails are due to route function and loginAs function. I have updated @japa/preset-adonis/TestsProvider/index.js with following code in both codebases fresh-application and existing-application. I am getting logs in fresh-application only.
// @japa/preset-adonis/TestsProvider/index.js

"use strict";
/*
 * @japa/preset-adonis
 *
 * (c) Japa.dev
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
Object.defineProperty(exports, "__esModule", { value: true });
/**
 * AdonisJS provider for registering japa class to the container
 */
class TestsProvider {
    constructor(app) {
        this.app = app;
    }
    register() {
        console.log('Tests Provider register call')

        this.app.container.bind('Japa/Preset/Test', () => {
            const { Test } = require('@japa/runner');
            return Test;
        });
        this.app.container.bind('Japa/Preset/TestContext', () => {
            const { TestContext } = require('@japa/runner');
            return TestContext;
        });
        this.app.container.bind('Japa/Preset/Assert', () => {
            const { Assert } = require('@japa/assert');
            return Assert;
        });
        this.app.container.bind('Japa/Preset/ApiClient', () => {
            const { ApiClient } = require('@japa/api-client');
            return ApiClient;
        });
        this.app.container.bind('Japa/Preset/ApiRequest', () => {
            const { ApiRequest } = require('@japa/api-client');
            return ApiRequest;
        });
        this.app.container.bind('Japa/Preset/ApiResponse', () => {
            const { ApiResponse } = require('@japa/api-client');
            return ApiResponse;
        });
    }
    boot() {
        console.log('Tests Provider boot call')
        this.app.container.withBindings(['Adonis/Core/Route', 'Japa/Preset/TestContext'], (Route, TestContext) => {
            TestContext.macro('route', function (routeIdentifier, params, options) {
                return Route.makeUrl(routeIdentifier, params, options);
            });
        });
    }
}
exports.default = TestsProvider;

Is the TestProvider registered inside the .adonisrc.json file in that old project? If possible please share your project as a repo for me reproduce the issue

Yes, it's registered there. I will invite you to the repo.

@thetutlage you must have received the invitation of the repo.

Just noticed that the .env.test file you shared has NODE_ENV = development. It should be set to test. That is the reason the "testProviders" are not loading

Okay, let me try it with test mode.

@thetutlage thank you so much for the help. You made my day. Closing the issue now.


Access controls should inherit and only have to be chosen once for multi volume works

Should do what FileSets do

Closed as a duplicate of #721


list defaults in --help output

memcached has a bunch of default options: would be nice to list them in the output of --help alongside their options. keep the alignment of the output in mind.

@dormando  could you please direct me to the docs which explain how I can set-up the dev environment and build the code etc..


PT-1720 | feat: upgrade to HDS v3.5 & RHHC v1.0.0-alpha255 that uses HDS V3.5

Description :sparkles:
Issues :bug:
Closes :no_good_woman:
DEV-XXX:
Related :handshake:
Testing :alembic:
Automated tests :gear:
Manual testing :construction_worker_man:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:

kultus-ui branch is deployed to platta: https://kultus-ui-pr304.dev.hel.ninja :rocket::rocket::rocket:


test(freefax): add e2e tests with gherkin

Hello @fchabrolle,
Your pull request is now closed due to inactivity.
Feel free to re-open it if you have any update.
Anna Bot for OVH UX <3

Thanks @fchabrolle!
I will merge your pull request in order to move forward and find a way to implement these kind of tests.
Stay tuned!


Edit to readthedocs.io -- Adding Internal Reference Hyperlink for appendixD.rst

Added a missing reference link about MEMBER OUTPUT LISTS to the relevant page from the readthedocs.io site (https://openfast.readthedocs.io/en/dev/source/user/subdyn/input_files.html#member-output-list).
Adhered to the referencing conventions used throughout the readthedocs.io

Dear @reilandsberger!  Thanks adding this!  We'll get this into our next release, which is scheduled for tomorrow :)


when we will release 3.0 Beta version and Formal version? Is here any plan here, thank you!

hi ,when we will release 3.0 Beta version and Formal version? Is here any plan here, i have checked Openssl website, i get cann't too much info. can you help reply? thank you.

marking as inactive, to be closed at the end of 3.4 dev, barring further input


loadMemoryFromFile doesn't work with memories of aggregate types

Type of issue: bug report
Impact: API addition (no impact on existing code)
What is the current behavior?
Mem of type Bundle is split into single-type memories with names like theMem_field1 and theMem_field2. Unfortunately, the loadMemoryFromFile annotation only contains the top-level name, so when processed by treadle, one receives the error
java.util.NoSuchElementException: key not found: MyModule.theMem

What is the expected behavior?
loadMemoryFromFile should work on memories of aggregate types.
Please tell us about your environment:
master branch of all relevant repos

Okay, so I'm going to try to fix this by adding a firrtl pass which replaces a LoadMemory annotation for a Bundle memories with one LoadMemory for each sub-data.
The fix should definitely happen at the firrtl level since chisel doesn't know that memories are split; and both chisel2verilog and treadle depend on the firrtl annos (meaning that there's a common place to insert the modification).
Writing a compiler pass is motivated by annotations generally not having type information. To add this would also require chisel annotations to know too much about the firrtl IR (i.e. fir.Type). Thus, the only place where types and annotations are seen together is in CircuitState, which is only available to passes.

Looks like the actual issue is that the treadle ExecutionEngine does another lowering pass but with the original (i.e. non-renamed) LoadMemoryAnnotations. The ToLoFirrtl seems to be necessary, though, since the input appears to be HighFirrtl.
This is a temporary fix:
--- a/src/main/scala/treadle/executable/ExecutionEngine.scala
+++ b/src/main/scala/treadle/executable/ExecutionEngine.scala
@@ -422,6 +423,9 @@ object ExecutionEngine {
     val timer = new Timer

     val loweredAst: Circuit = if(treadleOptions.lowCompileAtLoad) {
+      optionsManager.firrtlOptions = optionsManager.firrtlOptions.copy(
+        annotations = optionsManager.firrtlOptions.annotations.filter(_.isInstanceOf[LoadMemoryAnnotation])
+      )
       if(treadleOptions.allowCycles) {
         optionsManager.firrtlOptions = optionsManager.firrtlOptions.copy(
           annotations = optionsManager.firrtlOptions.annotations :+ DontCheckCombLoopsAnnotation

Turns out the real issue was that chisel-testers2 was passing the old, un-renamed annotations into the ToLoFirrtl pass. This is what I get for using bleeding edge repos!

Thanks for finding and fixing the bug :)


Bump Lightning-rc branch from 0.36.0 to 0.37.0

Description of the Change: Bump Lightning-rc branch from 0.36.0 to 0.37.0

Wrongly created. Closing


Is there any upcoming support for AMD graphic cards?

My laptop specs:
Processor: AMD® Ryzen 5 4600h with radeon graphics × 12
Graphics: AMD® Radeon rx 5600m / AMD® Renoir

We definitely want to add support for AMD graphic cards, but we don't have one at our disposal at the moment to add support.

supported with v3 now


feat: override local UI feature flags

Proposal on how to implement local UI feature flag overrides.
Details: https://www.notion.so/rilldata/Local-UI-Feature-Flags-Proposal-1ac2dc2530224c9f860c3f54d67ba616

Closing for now given the problems mentioned in the Notion doc. We should consider re-opening this in the future.


Fixes typo in README.md

If you want the proc to ever return nil, you'll need to use equality test rather than assignment ;-)

Ah, when the lambda has two arguments the return value is ignored. The ternary operator is for the record's property assignment.


Basic MAUI sample

Does anyone know of a basic MAUI sample using InTheHand.Net.Bluetooth. Or is this not supported?
With a basic proof-of-concept (scan for devices) I immediately hit a dead end (code and error below).
There is some indication in the commits/issues that MAUI has been looked at. Still too early, or am I doing something really dumb?
   at System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(Int32 errorCode)
   at WinRT.DelegateExtensions.DynamicInvokeAbi(Delegate del, Object[] invoke_params)
   at ABI.Windows.Foundation.IAsyncOperationMethods`1.GetResults(IObjectReference _genericObj)
   at ABI.Windows.Foundation.IAsyncOperation`1.global::Windows.Foundation.IAsyncOperation<TResult>.GetResults()
   at InTheHand.Net.Sockets.BluetoothClient.PlatformDiscoverDevices(Int32 maxDevices)
   at InTheHand.Net.Sockets.BluetoothClient.DiscoverDevices(Int32 maxDevices)
   at InTheHand.Net.Sockets.BluetoothClient.DiscoverDevices()
   at MauiBlutoothTester.MainPage.OnCounterClicked(Object sender, EventArgs e)
in E:\MauiBlutoothTester\MainPage.xaml.cs:line 27

What platform is this on? Window? Is Bluetooth turned on when you run this and correctly running discovery from Settings?

Hi @peterfoot ,
I have made a small repo illustrating what I am seeing at https://github.com/TwoTicketsPls/Maui-32-Feet-Issue
It contains bare bones MAUI and WPF versions of the same DiscoverDevices call. The WPF one works fine. The MAUI fails.
Windows 11. Latest version of VS2022 Preview. I have only tested Windows as the target platform. Bluetooth is turned on. Running discovery from Settings enumerates the target devices successfully (as does the WPF version).

Hi TwoTicketsPls,
I Tested yout repo: You have to handle Permissions first!
This is what i get:
[0:] Error searching for devices:	Need android.permission.BLUETOOTH_SCAN permission for android.content.AttributionSource@a287fb6f: AdapterService getScanMode
Dont ask me for a Solution i am fighting the same problem

Thanks @chno299 .
I never got as far as testing on Android, as it bombs for me on Windows with the debug output.
Exception thrown: 'System.Runtime.InteropServices.COMException' in Microsoft.Windows.SDK.NET.dll
Error searching for devices:	A method was called at an unexpected time.

Stack Trace:
   at WinRT.DelegateExtensions.DynamicInvokeAbi(Delegate del, Object[] invoke_params)
   at ABI.Windows.Foundation.IAsyncOperationMethods`1.GetResults(IObjectReference _genericObj)
   at InTheHand.Net.Sockets.BluetoothClient.PlatformDiscoverDevices(Int32 maxDevices)
   at Maui_32_Feet_Issue.MainPage.OnCounterClicked(Object sender, EventArgs e) in E:\Maui-32-Feet_Issue\Maui-32-Feet_Issue\MainPage.xaml.cs:line 27

Using .NET MAUI running win forms app I get the same problem
Stack Trace
at System.Runtime.InteropServices.Marshal.ThrowExceptionForHR(Int32 errorCode)
at WinRT.DelegateExtensions.DynamicInvokeAbi(Delegate del, Object[] invoke_params)
at ABI.Windows.Foundation.IAsyncOperationMethods1.GetResults(IObjectReference _genericObj)    at ABI.Windows.Foundation.IAsyncOperation1.global::Windows.Foundation.IAsyncOperation.GetResults()
at InTheHand.Net.Sockets.BluetoothClient.PlatformDiscoverDevices(Int32 maxDevices)
at InTheHand.Net.Sockets.BluetoothClient.DiscoverDevices(Int32 maxDevices)
at BuildingSwayLib.Toothy..ctor() in C:\Software\MAUI\BuildingSway\BuildingSwayLib\Toothy.cs:line 16
HResult    -2147483634
A method was called at an unexpected time.

I get the very same error on Android Emulator, although I think I added all necessary permissions in the Android manifest.
Does anyone has a working example?
It's kind of a killer to get such problems on a sample app provided in the library repo...

There are now two implementations of the windows dll. WPF will by default pick the Win32 version, Maui uses WinUI and will target Windows 10 so will pick the WinRT implementation. There was an issue with how the library calls async methods in a currently sync only API. I've now fixed this for 4.0.32 to get past this block. However there is still a known issue with the WinRT api that it has quite a long timeout when doing a discovery. My plan is eventually to offer a better async alternative using the DeviceWatcher as this will allow you to track devices going in and out of range as well as limit the time taken or number of devices to return (the current implementation takes a set time even if you request only 1-2 devices).
The Android issue is unrelated - for recent versions of Android you have to explicitly request permission from the user (as well as having the correct permissions in the manifest). I have some code for this which plugs into the MAUI permissions system which I will be releasing as a separate NuGet.

@peterfoot do you have a reference to the Android-permission system code?
If not, it would be great if you could keep this thread posted when your android-MAUI-permissions package gets released 👍
Thank you for your hard work!


Full input validation on wallet RPC methods

[ ] __construct
[ ] _run
[ ] _transform
[ ] _print
[ ] create_address
[ ] label_address
[ ] create_account
[ ] label_account
[ ] tag_accounts
[ ] untag_accounts
[ ] set_account_tag_description
[ ] transfer
[ ] transfer_split
[ ] sweep_all
[ ] sweep_single
[ ] relay_tx
[ ] get_payments
[ ] get_bulk_payments
[ ] incoming_transfers
[ ] make_integrated_address
[ ] split_integrated_address
[ ] set_tx_notes
[ ] get_tx_notes
[ ] set_attribute
[ ] get_attribute
[ ] get_tx_key
[ ] check_tx_key
[ ] get_tx_proof
[ ] check_tx_proof
[ ] get_spend_proof
[ ] check_spend_proof
[ ] get_reserve_proof
[ ] check_reserve_proof
[ ] get_transfers
[ ] get_transfer_by_txid
[ ] sign
[ ] verify
[ ] import_key_images
[ ] make_uri
[ ] parse_uri
[ ] get_address_book
[ ] add_address_book
[ ] delete_address_book
[ ] start_mining
[ ] create_wallet
[ ] open_wallet
[ ] make_multisig
[ ] export_multisig
[ ] import_multisig_info
[ ] finalize_multisig
[ ] sign_multisig
[ ] submit_multisig

Update to include new 0.12 "Lithium Luna" methods (see https://github.com/monero-integrations/monerophp/issues/43 )

monero-wallet-rpc checks type and validity of parameters, no need to duplicate efforts.


Swift 3 compatibility

Hey, I'd love to see this lib available in Swift 3 so I can implement it in my project.
Thanks 😄

Fixed by https://github.com/seedco/Formalist/pull/42


profile id is in the endpoint card

profile id is still present in the endpoint card

i have already implemented it. it is in my https://github.com/project-chip/zap/pull/1354

it is the same to https://github.com/project-chip/zap/issues/394 issue.

cool thank you!


NPE found in SSR

What package(s) are you using?

[x] Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
[ ] Legacy/CDAI
[ ] Legacy/Security

Detailed description

Describe in detail the issue you're having.
We see the following NPE when doing SSR (server side rendering) with React. After doing some self debugging, the getColTitle has a few lines trying to do col.Header().props.children.props but ``col.Header().props.childrenisundefined`, causing the NPE.

[2023-10-20T13:52:10.575] [FATAL] @console/console-platform-express-setup - Cannot read properties of undefined (reading 'props') TypeError: Cannot read properties of undefined (reading 'props')
    at checkTitle (/Users/flannanl/Git/projects-ui/node_modules/@carbon/ibm-products/lib/components/Datagrid/utils/getColTitle.js:24:36)
    at getColTitle (/Users/flannanl/Git/projects-ui/node_modules/@carbon/ibm-products/lib/components/Datagrid/utils/getColTitle.js:29:89)
    at getAccessibilityProps (/Users/flannanl/Git/projects-ui/node_modules/@carbon/ibm-products/lib/components/Datagrid/Datagrid/DatagridHeaderRow.js:34:40)
    at /Users/flannanl/Git/projects-ui/node_modules/@carbon/ibm-products/lib/components/Datagrid/Datagrid/DatagridHeaderRow.js:135:8
    at Array.map (<anonymous>)
    at HeaderRow (/Users/flannanl/Git/projects-ui/node_modules/@carbon/ibm-products/lib/components/Datagrid/Datagrid/DatagridHeaderRow.js:112:6)
    at /Users/flannanl/Git/projects-ui/node_modules/@carbon/ibm-products/lib/components/Datagrid/Datagrid/DatagridHead.js:26:7
    at Array.map (<anonymous>)
    at DatagridHead (/Users/flannanl/Git/projects-ui/node_modules/@carbon/ibm-products/lib/components/Datagrid/Datagrid/DatagridHead.js:23:82)
    at processChild (/Users/flannanl/Git/projects-ui/node_modules/react-dom/cjs/react-dom-server.node.development.js:3353:14)
    at resolve (/Users/flannanl/Git/projects-ui/node_modules/react-dom/cjs/react-dom-server.node.development.js:3270:5)
    at ReactDOMServerRenderer.render (/Users/flannanl/Git/projects-ui/node_modules/react-dom/cjs/react-dom-server.node.development.js:3753:22)
    at ReactDOMServerRenderer.read (/Users/flannanl/Git/projects-ui/node_modules/react-dom/cjs/react-dom-server.node.development.js:3690:29)
    at renderToStaticMarkup (/Users/flannanl/Git/projects-ui/node_modules/react-dom/cjs/react-dom-server.node.development.js:4314:27)
    at /Users/flannanl/Git/projects-ui/node_modules/@apollo/client/react/ssr/getDataFromTree.js:21:21
    at new Promise (<anonymous>)
    at process (/Users/flannanl/Git/projects-ui/node_modules/@apollo/client/react/ssr/getDataFromTree.js:19:16)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Is this issue related to a specific component?
Datagrid

What did you expect to happen? What happened instead? What would you like to
see changed?
I expect no issue with SSR with the Datagrid component.

What browser are you working in?
Chrome

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive)
package are you using?
@carbon/ibm-products 1.59.1

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?
IBM Cloud Projects

Steps to reproduce the issue

Step one
Step two
Step three
etc.

Please create a reduced test case in CodeSandbox
https://codesandbox.io/s/github/carbon-design-system/ibm-products/tree/main/examples/carbon-for-ibm-products/SidePanel

Additional information

Screenshots or code
Notes

Hey @flannanl, this seems to be a duplicate of #3649. I'm taking a look at this today and will post an update on #3649 when it is fixed.


"LegacySupport" flag was removed between v12.7.0-preview.41 and v12.7.0

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
A flag was added in https://github.com/ChilliCream/hotchocolate/pull/4709 for the related issue: https://github.com/ChilliCream/hotchocolate/issues/4706
But after upgrading to v12.7.0, the flag is no longer there:

Steps to reproduce

Try to use the LegacySupport flag in the PagingOptions

                .SetPagingOptions(
                    new PagingOptions
                    {
                        LegacySupport = true,
                        IncludeTotalCount = true,
                        InferConnectionNameFromField = false,
                    }
                )

Relevant log output
No response
Additional Context?
No response
Product
Hot Chocolate
Version
12.7.0

@sgabler-solytic  12.7.0-preview.41 is now the current working branch of v13. We backported a lot of changes for another (two?) releases of v12.
What exactly are you using of v12.7 preview? can you just "go back" to 12.7?

I assumed that v12.7.0-preview.41 is a lower version than v12.7.0, because it's a preview of the upcoming stable version v12.7.0. Maybe that's a wrong assumption?
I originally raised this issue in the slack chat: https://hotchocolategraphql.slack.com/archives/CD9TNKT8T/p1643307651419039, but then later created #4706.
After reading the slack discussion again, I can now see that @michaelstaib originally added the legacy support in v12.7.0-preview.2.

I then upgraded to preview.41 some time later and the legacy support still worked. Only after upgrading to v12.7.0 (without any preview suffix) it stopped working.
We (or anyone who wants to upgrade from v10) need this flag, otherwise we can't upgrade from HC10 to HC12, as it's a breaking change between the versions.
Or am I missing something? 🤔

12.7 preview became 13 and we reset the version 12.7

The feature is not gone ...  we probably can cherry-pick it to 12.9

👍 That would be highly appreciated. Then I'll be able to finalize the upgrade from HC10 to HC12

@michaelstaib @PascalSenn what was the final outcome here? I remember reading something somewhere, but can't find it anymore

I will put it in 12.12

We have moved this one to 12.13

@michaelstaib I assume the preferred way of dealing with this issue it now to use a rewriter?
From the docs:

To avoid breaking schemas on a stitched schema, you can add a rewriter that rewrites all first: Int and last: Int on a connection to first: PaginationAmount and last: PaginationAmount. You also have to make sure that you register a new IntType on the root schema and rewrite all downstream schemas.

If yes, then I think we can close this issue

The issue is fixed on 13 with the legacy support available.

Just to give some background here. The change was not the simplest and we could not make it work in 12 without introducing another breaking change. I am closing this issue since it is solved with 13.


Vagrant 1.7 and latest deps

Add's support for vagrant 1.7, updates the lock file to recent dependencies, includes dependencies for Windows, ensures that chef-zero is run with the same ruby as vagrant so that "#!/usr/bin/env ruby" doesn't trigger errors on Windows and makes it easier to bump patch release numbers while allowing building of pre-release gems with identifiable versions.

Hi @electrofelix
I've been following this repository for a while now and I've seen several good PRs (this one included) simply be left here without any feedback or prospect of being merged.
Meanwhile, I've forked it and merged the PRs that I found good and useful.
Although, I don't particularly like having done that, it seemed a way to make the situation workable.
Since you made this PR recently, I assume you are actively interested in using the plugin.
I am too, but I don't see how to proceed, since I can't seem to get in contact with the original maintainer.

Hey every, I just got @miguelaferreira's email.  Sorry for not responding to these issues.  I do not actively use this plugin anymore, so I am working to transfer the project so you can all continue developing it.
Sorry for delaying project so much.

Hi @electrofelix
I've looked through your changes and it LGTM.
However, since some of the older PRs have been merged, this one does not merge cleanly anymore.
Would you be so kind as to rebase your PR?

LGTM


[doc] Add some more signposting to cryptolib API documentation.

Also move the "asynchronous operations" section to the end of the document.
This addresses some post-merge feedback from https://github.com/lowRISC/opentitan/pull/19551

@jadephilipoom: Looks even more polished, now :)


Fix multiple relative pointer transform

We don't track if we applied the relative pointer transform on a pointer when we save or load. Since multiple variables can be aliased to the same pointer, we may apply the transform more than once.

Good catch!


Cookbook style documentation

Any updates on this?

Curious as to what this entails.  Will this be done by external resource or
are there plans to draw on internal resources.
I previously offered to assist if it is all internal and within our group.
Alison
On Sun, Jan 15, 2017 at 5:01 PM, Chris Chua<EMAIL_ADDRESS>wrote:

Any updates on this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/uber/react-vis/issues/213#issuecomment-272752401, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC2FJm521ZZvRUwGw393lSlWCIthePczks5rSsFtgaJpZM4Le7Wb
.

@chrisirhc I think that this should be done after the gh-pages documentation refactor. That will make this step a lot easier since the examples that we can use will done. Maybe we can just borrow those example and add them to a live editor, like FormidableLabs/component-playground. Thoughts?

Do these examples need to be editable?

It seems like we went a different direction on the docs, marking as closed?