I18N: Add more languages

Is your feature request related to a problem? Please describe.
Currently, Uppload v2 only has English (en) and Dutch (nl) as language options.
Describe the solution you'd like
We want to add support for 10 (?) more languages before we launch v2.
Describe alternatives you've considered
Using machine-generated translations would be a backup plan.
Additional context
In Uppload v1, our amazing contributors added I18N, but since keys are changed, we'll need some help in adding those languages back:

Turkish by Ekrem Erdem (not on GitHub)
Spanish by @elnino-ict
German by @jkniest and @dingsbams

Read our translation guideline here: https://github.com/elninotech/uppload/blob/master/CONTRIBUTING.md#translations

We could add Greek translation if this would be useful?

@sigma-technology Would be great, thanks!


[python] update_uns feature [WIP]

Issue and/or context: This is a WIP
Changes:
Notes for Reviewer:
This PR is not ready for review. Please do not review it.

Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

apis/python/src/tiledbsoma/io/ingest.py
86.88% <28.57%> (-0.55%)
:arrow_down:

... and 76 files with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.


Support projects that don't use the Django group permissions system

I just tried to install django-sql-dashboard on an internal project and immediately got an error when going to /dashboard/:
ValueError: Cannot query<EMAIL_ADDRESS>Must be "Group" instance.

After a bit of digging, I discovered that the culprit was this line in Dashboard.get_visible_to_user:
cls.objects.filter(
    models.Q(owned_by=user)
    | models.Q(view_policy__in=allowed_policies)
    | models.Q(view_policy=cls.ViewPolicies.GROUP, view_group__user=user)
)

The last bit there assumes that you have a User model which is using the PermissionsMixin (or otherwise has a groups relationship).
In my project, the User model is very simple:
class User(AbstractBaseUser):
    id = models.UUIDField(primary_key=True, default=uuid.uuid4, editable=False)
    # other fields removed
    is_superuser = models.BooleanField(default=False)
    email = LowercaseEmailField(unique=True)

    USERNAME_FIELD = "email"

    @property
    def is_staff(self):
        return self.is_superuser

    def has_module_perms(self, app_label):
        return True

    def has_perm(self, perm, obj=None):
        return True

In other words - users can access /admin/ if their is_superuser flag is set, but otherwise are just logged in and can access everything. I'm not using the Django permissions system at all, really.
I'm not sure how to fix this in the general case - could django-sql-dashboard somehow detect whether the groups relationship exists? Or should it be a setting? Or an entirely custom auth system? Or should I just stop being difficult and install the Django permissions system like everyone else? 🙂

See also #113 - feature request for custom auth.

We do use the Django Admin, but we only expose it to internal users (ie devs). We have a single boolean flag is_superuser which distinguishes users that can log into the Admin from those that can't. We assume that any user that can access the Admin automatically has permission to do anything with any more (hence the has_module_perms and has_perm both return True in the model above.
I imagine this setup isn't all that uncommon - after all the PermissionsMixin is an optional mixin for custom User models, so it's likely that plenty of Django users do something like this.
I suppose a CBV approach would be one way of solving this. Or maybe a function-based view factory which allows you to pass in a custom function as an argument that the view uses to get a list of visible dashboards for the current user? django-sql-explorer solves this sort of thing by putting callback functions in settings, but I always thought that approach was a bit odd.


KAFKA-3233: expose consumer per-topic metrics

In version of <IP_ADDRESS>, the old consumer will provide the metrics reporter per-topic consumer metrics under group 'ConsumerTopicMetrics'. For example:
*.ConsumerTopicMetrics.clientId.[topic name].BytesPerSec.count
*.ConsumerTopicMetrics.clientId.[topic name].MessagesPerSec.count
These consumer metrics are useful since it helps us monitor consumer rate for each topic. But the new consumer(<IP_ADDRESS>) doesn't expose per topic metrics anymore, even though I did find sensor objects in consumer metrics object collecting per-topic metrics.
After investigation, I found that these sensors are not registering any KafkaMetrics.

@hachikuji Would you mind taking a look again?

@happymap Overall, LGTM. One question I had is whether it makes sense to add a configuration option to disable topic metrics. I can imagine users might not want them in mirror maker use cases for example.    We don't necessarily have to address this in this patch.

@hachikuji Are you thinking people would want to disable them because they have significant performance impact? Does this patch add risk of performance degradation?

@granthenke I doubt it's a performance concern, I was just wondering if users would want the ability to turn off topic-level collection. I remember the LI folks told me their mirror maker cluster copied in the low thousands of topics and I can imagine not wanting to collect metrics for all of them. But maybe we can just expect users to filter them in their reporter/collector in that case? I'm not too familiar with the metrics libraries, but I took a quick look around and they seem pretty light, so memory overhead is probably not a concern.

@hachikuji I was trying to migrate the old consumer to 0.9 consumer. The old consumer client exposes per-topic metrics by default and these consume rates for each topic are useful for us. So I expect same kind of metrics from new consumer as well in terms of consistency. But I can add a flag tho if this feature might not be something that a lot of people need.
But if these metrics are not exposed, any reason someone still put sensors there to collect per topic samples?

@happymap Let's not do it here. A configuration change would probably require a KIP and it's unclear whether it's even needed. I suggest we keep the patch as it is and introduce a configuration option later only if someone really needs it. Definitely for 99% of use cases, there is no harm to having the topic-level metrics.

@hachikuji could you help merge this change, if you are ok with it?

@hachikuji @guozhangwang I removed the 'topic' prefix and all tests have passed. Could you help merge this change?

LGTM, merged to trunk.


Convert test assertions to provide more informative failure messages

Description
Our current test suite uses traditional assertion methods, such as assertTrue(), which can be less informative and harder to debug when tests fail. To improve the readability and debugging experience, it has been suggested to convert these assertions to ones that provide clearer error messages, aiding in debugging.
Example Conversion
Current assertion:
assertTrue(session.sql("SELECT * FROM " + tableName1).collectAsList().isEmpty());

Converted to AssertJ:
assertThat(session.sql("SELECT * FROM " + tableName1).collectAsList()).isEmpty();

Reference
This enhancement has been motivated by @nastra's comment on #256, highlighting the benefits of making these changes. A few tests have already been converted in commit ca580fa, which can serve as a reference for the conversion process.

As discussed, I will take this up with me.


Get correct codeowners matching - https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

According to https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners, the correct way to recursively match folders is just folder/ not folder/*
Thanks Leah for pointing this out

Thanks for doing this Danny


Implement simple api example

closes #1

For the sake of simplicity of the Proof of Concept I manage only to make a simple app, by now with the design decision of using a class to instantiate the app and that don't expect any callbacks.
import { AxumApp } from "./index";

const app = new AxumApp();

app.get("/");

app.listen(3000);

❯ http :3000
HTTP/1.1 200 OK
...
Hello World!


Fix clicking on non-image attachments

stateProps doesn't have selectedConversation, so use routePath instead
@keybase/react-hackers

@keybase/react-hackers bump


InputType in model  is causing db generation to fail

Having input type in Model causing generation to fail.
We need to have additional case added to the visitor to ignore input types
create table "task" ("id" serial primary key, "completed" boolean, "description" varchar(255), "id" varchar(255), "name" varchar(255), "created_at" timestamptz, "updated_at" timestamptz) - column "id" specified more than once

I believe the error you are saying is nothing to do with having an input type in the model.
Take the following input schema example:
type Note {
    id: ID
    title: String
    text: String
}

input NoteInputTwo {
  title: String
}

This will not fail - the custom input will not be transferred into the output schema, but I can successfully run the application.
What you are seeing occurs when a model contains an id with type other than ID.
You can reproduce this error by changing the id type:
type Note {
    id: Int
    title: String
    text: String
}

input NoteInputTwo {
  title: String
}

graphback db will give you:
create table "note" ("id" serial primary key, "id" integer, "title" varchar(255), "text" varchar(255), "created_at" timestamptz, "updated_at" timestamptz) - column "id" specified more than once

Ok.. so we need to require ID! field anyway so the issue is related to the PR I'm working on and going to resolve this there.


I deployed contact address and NFT, you said I didn't during 60 days, any help please

i did on the reported period and got the confirmation from the mint page. I see a lot of users with the same issue, probably this should be corrected to solve it in a massive way.
Cheers.

please contact in discord #Scroll-Origins-Support channel, you can provide your wallet address and deployment tx hash there.


str.includes Fails

Which version of PhantomJS are you using? Tip: run phantomjs --version.
v2.1.1

What steps will reproduce the problem?

Try using str.includes ... example code: console.log(String('intTest'.includes('int'))); => JavaScript error / exception, code exits. Note, this is inside a web page I am opening (rasterize.js).

Which operating system are you using?
Ubuntu v16.04

Did you use binary PhantomJS or did you compile it from source?
Installed using apt-get.

Please provide any additional information below.

I've had success using https://www.npmjs.com/package/phantomjs-polyfill-includes

Hi,
I may be missing your point, but to make sure ... my issue is with this command inside my web page, that PhantomJS is loading => not within PhantomJS executing this command (inside it's JS) file ... make sense?
Thanks!


Paragraph in a cell

I am using your EasyTable library and it is fantastic, for my use it is better than itext7. I have only one problem. I'm trying to insert a paragraph with multiple lines inside a cell but it gives me an error. Here is my class.
The error is:
Exception in thread "main" java.lang.NullPointerException         at org.vandeseer.easytable.drawing.cell.ParagraphCellDrawer.drawContent(ParagraphCellDrawer.java:52)         at org.vandeseer.easytable.TableDrawer.lambda$new$0(TableDrawer.java:53)         at org.vandeseer.easytable.TableDrawer.drawRow(TableDrawer.java:161)         at org.vandeseer.easytable.TableDrawer.drawWithFunction(TableDrawer.java:145)         at org.vandeseer.easytable.TableDrawer.lambda$drawPage$1(TableDrawer.java:75)         at java.lang.Iterable.forEach(Iterable.java:75)         at org.vandeseer.easytable.TableDrawer.drawPage(TableDrawer.java:74)         at org.vandeseer.easytable.TableDrawer.draw(TableDrawer.java:70)         at it.baz.ProvaPDF.crea(ProvaPDF.java:66)         at it.baz.ProvaPDF.main(ProvaPDF.java:21)
'
ProvaPDF.txt
pom.xml.txt
Thank you

Hi @buzzer83,
glad that you find the library useful. 😃
I will have a look at the issue soon.
Best,
Stefan

The solution is as simple as:
        TableDrawer tableDrawer = TableDrawer.builder()
                .contentStream(contentStream)
                .page(page) // <-- This was missing
                .startX((page.getMediaBox().getUpperRightX() - 200) / 2)
                .startY(page.getMediaBox().getUpperRightY() - 20)
                .table(myTable)
                .build();

I mentioned this for the use of links in the README: https://github.com/vandeseer/easytable#enable-links but I just realized that one would also need it for using any ParagraphCell. As I stated in the README as well: This whole thingy is a bit experimental. But I think I will add some more meaningful exception and or message so that it's easier to catch this issue :wink:

Thanks you.


Adonis 5 typescript support?

This package will updated to new adonis version?

Issue doesn't adhere to the guidelines of creating a proper issue.

Make sure that you are only reporting bugs or submitting feature requests on Github.
In case of feature requests, please be descriptive and explain how this feature helps a broader audience and not just you.

If you are not submitting a bug and neither a feature request, then please use the discussion threads
In any case, issues which are not descriptive enough will be closed. Please respect our time.


chore: fix spelling mistakes in ring theory files

Just as a curiosity, how are you finding these? Did you run a spell-checker on the entirety of Mathlib? If so, that's awesome.

bors merge


android:paddingStart attribute without API level qualifier caused crashes on some API < 17 devices

In files like library/src/main/res/layout/md_listitem_singlechoice.xml
There is a android:paddingStart attribute, that looks harmless. But actually it's not harmless, that's why lint warns us that that attribute should not be used unless you put the xml file inside the -v17 qualifier.
The reference is this bug: https://code.google.com/p/android/issues/detail?id=60055
In my app, which uses material-dialogs, there has been around 30 reports of crashes with the following stack traces:
android.view.InflateException: Binary XML file line #23: Error inflating class TextView
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:710)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:752)
at android.view.LayoutInflater.inflate(LayoutInflater.java:495)
at android.view.LayoutInflater.inflate(Native Method)
at android.view.LayoutInflater.inflate(LayoutInflater.java:397)
at android.widget.ArrayAdapter.createViewFromResource(ArrayAdapter.java:371)
at android.widget.ArrayAdapter.getView(ArrayAdapter.java:362)
at com.afollestad.materialdialogs.MaterialDialogAdapter.getView(Somewhere:45)
at android.widget.AbsListView.obtainView(AbsListView.java:2472)
at android.widget.ListView.measureHeightOfChildren(ListView.java:1250)
at android.widget.ListView.onMeasure(ListView.java:1162)
at android.view.View.measure(View.java:15562)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5107)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:310)
at android.view.View.measure(View.java:15562)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5107)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1396)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:681)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:574)
at android.view.View.measure(View.java:15562)
at com.afollestad.materialdialogs.internal.MDRootLayout.onMeasure(Somewhere:194)
at android.view.View.measure(View.java:15562)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5107)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:310)
at android.view.View.measure(View.java:15562)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5107)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1396)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:681)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:574)
at android.view.View.measure(View.java:15562)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:5107)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:310)
at com.android.internal.policy.impl.PhoneWindow$DecorView.onMeasure(PhoneWindow.java:2423)
at android.view.View.measure(View.java:15562)
at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:2031)
at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:1224)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:1425)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1142)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:4709)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:725)
at android.view.Choreographer.doCallbacks(Choreographer.java:555)
at android.view.Choreographer.doFrame(Choreographer.java:525)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:711)
at android.os.Handler.handleCallback(Handler.java:615)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:137)
at android.app.ActivityThread.main(ActivityThread.java:4947)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:511)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1038)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:805)
at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:132)
at dalvik.system.NativeStart.main(Native Method)
Caused by: java.lang.NumberFormatException: Invalid int: "6.0dip"
at java.lang.Integer.invalidInt(Integer.java:138)
at java.lang.Integer.parse(Integer.java:375)
at java.lang.Integer.parseInt(Integer.java:366)
at com.android.internal.util.XmlUtils.convertValueToInt(XmlUtils.java:123)
at android.content.res.TypedArray.getInt(TypedArray.java:254)
at android.content.res.XResources$XTypedArray.getInt(XResources.java:1002)
at android.widget.TextView.<init>(TextView.java:1072)
at android.support.v7.widget.AppCompatTextView.<init>(Somewhere:44)
at android.support.v7.widget.AppCompatTextView.<init>(Somewhere:40)
at android.support.v7.internal.app.AppCompatViewInflater.createView(Somewhere:99)
at android.support.v7.app.AppCompatDelegateImplV7.createView(Somewhere:782)
at android.support.v7.app.AppCompatDelegateImplV7.onCreateView(Somewhere:810)
at android.support.v4.view.LayoutInflaterCompatHC$FactoryWrapperHC.onCreateView(Somewhere:44)
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:681)
... 54 more

The solution should be removing the android:paddingStart from the file mentioned above and similar files, and use the -ldrtl qualifier to support RTL.

By the way, you can't test this on an emulator, because this is caused by unspecified behavior on older Android versions. Prior to 4.2 (I think), Google didn't disallow OEMs to add their own attributes. Hence, paddingStart was mapped to some manufacturer-specific attributes that expects an int value, that's why it crashes when parsing '6.0dip'.
The crash report of my app from Google Play shows me 2 devices with this behavior:

Galaxy Tab 7.7 (GT-P6810) Android 4.1
Galaxy Note 10.1 (p4noterf) Android 4.1

Same here - about 160 crashes only for the latest version.
For now we don't use this library for devices with Samsung brand.

This isn't a bug as much as it is yet another issue with samsung. Google should be helping us here though, IIRC build tools 22+ automatically fixes this in layout files by removing paddingStart attributes in the main file and creating copies of them in -v17 resource directories where that attribute is safe to use. @yukuku @Sivanga what build tools versions are you using?

@hzsweers We are using buildTools version 21.1.1

Ah, yeah I believe you'll solve your problem when you update to 22.0.1.

I see, I was also using build tools 21.1.2. I didn't know build tools 22+ removes paddingStart attributes etc. Any reference on the web?

No official references (classic Google...), but a redditor and I talked and confirmed it when I posted about it awhile back.
Basically any xml file that has one of those problematic attributes gets copied completely into a new file under -v17 and the attributes are removed in the original file.

I'll check , thanks!

@hzsweers  Thanks! Confirmed with building material-dialogs with Build Tools 22.0.1:
	   android:paddingStart="@dimen/md_listitem_control_margin"

does not appear in layout/md_listitem_singlechoice.xml, and then a copy of the original file is generated at layout-v17 folder.
Same with the original layout-ldrtl variant — the original is automatically located at layout-ldrtl-v17, and the one without the paddingStart is at layout-ldrtl folder.

Cool! Glad that worked. I think it's probably best to just close this since
the solution is a build tools version. 22 has been out for awhile, so
hopefully people can update to it soon enough.
On Wed, Jul 1, 2015 at 5:40 AM yukuku<EMAIL_ADDRESS>wrote:

@hzsweers https://github.com/hzsweers Thanks! Confirmed with building
material-dialogs with Build Tools 22.0.1:
   android:paddingStart="@dimen/md_listitem_control_margin"

does not appear in layout/md_listitem_singlechoice.xml, and then a copy
of the original file is generated at layout-v17 folder.
Same with the original layout-ldrtl variant — the original is
automatically located at layout-ldrtl-v17, and the one without the
paddingStart is at layout-ldrtl folder.
—
Reply to this email directly or view it on GitHub
https://github.com/afollestad/material-dialogs/issues/589#issuecomment-117644516
.


Support passing tuple to 'after' parameter

Currently, the 'after' parameter in select supports only maps (objects). It should be possible to pass tuple into this parameter.
Possible variants:
a) Automatic checking if the passed object has number keys starting from 1 (it is effectively a tuple)
b) Separate the option into two: after_tuple and after_object

Fixed in #51. Closed


FIX MESS CODE

[ ] rewrite save system
[ ] remake smoke system
[ ] make more smokes
[ ] remake player access system
[ ] find a better way of loading
[ ] remake warp system and changing room system
[ ] refactory playerBase
[ ] make a entityBase
[ ] remake folder gerency
[ ] use more groups to acess objects
[ ] study good code clean code and whatever
[ ] remake system of folders and files
[ ] remake how worlds and dimensions is organized

I am very angry right now

this #49 is happening again
and the game is crashing when changing rooms

finally, peace


DCKUBE-451 Use NFS-Ganesha to support file locking over NFSv3

Using Ganesha we can expose the lockd ports on predictable ports. Doing so with the kernel mode lockd would require us to set the files /proc/sys/fs/nfs/nlm_tcpport and /proc/sys/fs/nfs/nlm_udpport, which we can't do from Docker/Kubernetes out of the box.
You can have a look at 1f2542853ee50543a8df75e10eef764662c5aae1 to see what would be necessary for this to work with the kernel mode NFS lockd.

LGTM, pending passing builds.


Phoenix

..is a Framework, that can generate static pages:
http://www.sebastianseilund.com/static-markdown-blog-posts-with-elixir-phoenix

Does that output generate an index.html that can be hosted on a service S3? From what I read it generates an index.html.exx


Support Tuya 0d devices

see this discussion github.com/codetheweb/tuyapi
there are devices which cannot be read with the DP_QUERY
requires code like
var jsonIn = dev.FillJson("{\"dps\":{\"1\":null,\"2\":null,\"100\":null,\"102\":null,\"103\":null}}", true,true,true,true);
byte[] request = dev.EncodeRequest(TuyaCommand.CONTROL_NEW, jsonIn);

in progress - see branch device-suport-od

adressed in https://github.com/volker76/tuya_mqtt.net/commit/498c74bfc493a32cee9d1b2e08a647828647cd0f

closed with version v1.0.0


resilio-sync: 2.6.3 -> 2.6.4

Motivation for this change
This release is a hotfix for a WebUI security issue:
https://forum.resilio.com/topic/71647-latest-desktop-build-264/
Since update fixes a security issue, it should probably be backported to nixpkgs 19.09.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

Picked to release-19.09 in e04700a944005c60606a6461ec5b25c710420653


Specify the exact Youtube URL

Example for the song "Bless the Lord (Ten Thousand Reasons)"
Given URL : mediaUrl=https://www.youtube.com/watch?v=r3K3roEF36k
originalKey=G
Expected URL :  mediaUrl=https://www.youtube.com/watch?v=r3K3roEF36k

Hi Vicky, the comments field shall have many properties separated by a newline char.
"originalKey" is one such property meant to display the musical key of the song. Our android app displays this key in Landscape mode.


Update documentation for start_copy_from_url() source_authorization with more detailed explanations

Hi,
Our application is using start_copy_from_url() to copy blobs from one storage account to another (different subscriptions). The sender requested us to use service principal to interact with the storage. We tried to pass the parameter source_authorization to authenticate the https requests. However the documentation is not clear how the format of the string should look like, and what the client secret is.

Ensure "bearer " is the prefix of the source_authorization string. -> how is the format look like? We tried "bearer {client-secret}", "Bearer {client-secret}" and "bearer: {client-secret}" but no success.
For the client secret, do you mean only the client secret generated by a service principal? When we use a service principal, we normally provide client_id, client_secret and tenant_id. So we dont need to provide client_id or tenant_id?

Will you please update and enrich the documentation of this method using source_authorization? Thank you

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.23647323,azure-spring:0.18212682,Authorization:0.103432454'

Thanks for the feedback.
Could you help to provide the information which library did you use and which version?
Thanks.

Hi Xiang, I am using the BlobClient and the library is azure-storage-blob   12.14.1. Thank you very much

Thanks for the information.

Hi @a-alwu, thanks for reaching out. I do agree this documentation is a bit confusing. What source_authorization is actually looking for is an OAuth Bearer token that has access to the data you are copying. So, what you need to do is use a different library/function to fetch a proper Bearer token using your tenant id, client id, and client secret and then supply it to start_copy_from_url
One example is to use ClientSecretCredential from the azure-identity package to fetch a token with a specific scope.  Here is a sample of that:
from azure.identity import ClientSecretCredential

secret_cred = ClientSecretCredential(
    tenant_id="<tenant-id>",
    client_id="<client-id>",
    client_secret="<client-secret>"
)

access_token = secret_cred.get_token("https://storage.azure.com/.default")
source_authorization = f"Bearer {access_token.token}")

Hopefully that helps and we will update the documentation to make this less confusing. Thanks.

Thank you very much @jalauzon-msft :) Will test it out and let you know asap.

Just tested. It worked. Thanks a lot.


upgrading plugin breaks my things

andi,
plugin was previously working perfectly. now, my syntax-highlighted code looks as follows:

what's my play?

Dear cavaunpeu,
can you please post a url from your blog ?
Are any other syntax highlighting plugins active ? if so, please disable them!
did you paste your code snippet directly into the VisualEditor or did your use the "Code Insert Dialog" ?
best regards, Andi

WP Markdown plugin was creating havoc. Disabled, and now working. Closed.


stdenv: port to generic OS.

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew tests with your changes locally?

More work towards making Homebrew/brew a cross-platform core for e.g. Linuxbrew and Tigerbrew too.

I was just peeking around and made a comment, but I'm not sure I'll be able to do a full review. Looks like nice stuff.

A few quirks that need to be ironed out, but nothing major. I'd appreciate if there was a second round of review once the initial round of comments has been addressed (and once I had time to review the related superenv changes and cross check with them).
How was this PR tested locally? I'd suggest to build some formulae of varying complexity from source with --env=std (cover multiple build systems, use formulae that exercise some of the relocated features from ENV) and to also run their tests with brew test (as that further exercises Stdenv).

Should be fine except for the test failure and the final style nit (that didn't really apply earlier).


Challenge Submission 1

Challenge 1:
Canister URL(s): - issue redeem cycle
OR
Repo URL: https://github.com/beecoder77/azle-react
Oisy wallet principal: dbryv-fxjm2-nmrfd-ptvqh-qft5f-haz2k-ygqp4-kklhi-fixl2-ftvwo-bae

new canister URL(s): https://6cz7v-oyaaa-aaaak-qiu2q-cai.raw.icp0.io/

Submission 1
custom Frontend get data from backend

Submission 2
Hit API newsapi.org to get ICP news!


Storage solution for maintaining games unless clear board is clicked.

Currently if you refresh or navigate away from the page you will lose your game. Need a way to save games.
Solution:
Utilize local storage to store local copies of the current game which will be reset when clear board is clicked/confirmed. This is a temporary solution and will be replaced with a database solution at a later date.

Currently there's a bug with this implementation where if you have autoplay running it will still be running when you return but the interval is lost so it really isn't running anymore. So need to fix thatt.


No bypass alarm API - System fails to arm if any zones have errors

If using the eldes security app, when trying to arm alarm an error modal is displayed if e.g. a window is not closed and allows to bypass the zones to arm the system anyway.
Is it possible to add this API to the integration so that HA could always make sure to arm the alarm regardless if someone forgot to close a window, etc? Right now it just tries to arm and times out after failing.

Its definitely possible. Just I'm seeing this modal for the first time. I will try to replicate this case and will inform about progress.

I would try this myself, but I've no way of testing what requests are sent by the android app. I tried scrapping with fiddler, but couldn't get it to work.

You can try to set up https://www.charlesproxy.com. This how I got all API endpoints.
But no worries, I will try to open my house doors and arm. Probably it will show same warning, just never tried 😄

You can try to set up https://www.charlesproxy.com. This how I got all API endpoints. But no worries, I will try to open my house doors and arm. Probably it will show same warning, just never tried 😄

For me on android Charles do not work, because every app needs changes to approve Charles, so it should only be possible on ios. Only on android 6 version it is possible to get these charles events, then this change was not made.
One of the possible ways would be to deconstruct apk, but it needs more work, but probably it will have proguard so it could be pretty hard to get source code and such apps mostly have this.


Timeout ssh.Dial

Fixes #199
By default, golang.org/x/crypto/ssh.Dial does not timeout. This sets the default timeout to 15 seconds per attempt.
We expose perDialTimeout to the user, allowing them the ability to set the per-dial timeout. Setting perDialTimeout to 0 implies no timeout.

LGTM


meta: should use client streaming gRPC for heartbeat

Currently, we establish a new RPC call for each heartbeat. It would be better to use client streaming for this long-running task.
https://github.com/singularity-data/risingwave/blob/ba8203a27655f6783d810ff8a0529c4ece3e673b/src/rpc_client/src/meta_client.rs#L126-L137
Related: #4553

establish a new RPC call

In practice, we are using existing open channels. So I don't think stream is strictly necessary.

+1, in practice we are always using one single HTTP/2 connection.

+1, in practice we are always using one single HTTP/2 connection.

On connection, yes. But there'll also be no need to spawn a new task every time to serve this heartbeat on the meta service too. Not that important though.


Can't do lessons or reviews

The main page which shows the number of available lessons and reviews is fine, but once clicked on (either one), nothing loads. The following error is logged to the console: Refused to display 'https://www.wanikani.com/review/session' in a frame because it set 'X-Frame-Options' to 'SAMEORIGIN'.

Thank you for having noticed this!
This issue was fixed a month ago with the <IP_ADDRESS> release, but for some reason this version wasn't released on the Chrome Web Store. I just published it again.
If your Wanikani Companion client doesn't automatically update to version <IP_ADDRESS>, you can try to remove and reinstall the app. Otherwise, you can also directly run it from the source.

Awesome! I just got a notification about new permissions, and it resolved the issue. Thanks


[v1.12.4 -> v2.3.0] - Order of arguments for runtime.JsonMerge and runtime.JSONMerge are being flipped.

Hi there.
I'm working on a project where the team currently use the<EMAIL_ADDRESS>command line tool, and we were looking into upgrading to the newest version v2.3.0.
The issue I'm having is that when any small change is made to the existing openapi yaml spec and we run the following command with<EMAIL_ADDRESS>oapi-codegen --config api/config.yaml  ./api/openapi.yaml> ./api/v1/go/ServerConfig.gen.go
It generates hundreds of changes - most of them are benign but some are breaking changes.
The change that is causing issues is to do with converting any instance of the deprecated runtime.JsonMerge to the preferred runtime.JSONMerge. This should be a straightforward drop-in replacement, but for some reason the order of the arguments being supplied is flipped like so:

This change breaks some of our tests.
However, after I do a find and replace in ServerConfig.gen.go to change runtime.JSONMerge(t.union, b) to runtime.JSONMerge(b, t.union) the tests all pass. Obviously modifying the generated file isn't a solution, but it seems to pinpoint the fact that the issue is oapi-codegen reversing the order of the arguments to runtime.JSONMerge.
This is quite surprising to me, as the result of merging two JSON objects shouldn't depend on the order of the arguments.
I'm still actively looking into this, and when I've a bit more time available I'll supply steps to replicate from scratch.
Thanks loads!

The order does matter as the first parameters type is used.  The problem is arising when b is an array and t.union is empty.  In the old code merged is an array containing b in the second merged is {} as an object cannot be merged with an array and nil is assumed to be an object not an array.  Swapping the parameter order back to what it was would fix this

I believe a change to line 56 of pkg/codegen/templates/union.tmpl merged, err := runtime.JSONMerge(b, t.union)
will fix the issue

This was an intended change as part of #998 - are you seeing any issues related to this, or was it just surprising?

Can you please share some examples of the difference in behaviour you're seeing and what issues it's causing?
This will help us work out the impact and whether this needs to be a default change, or if it can be made a "compatibility option" that can be opted in for folks who are affected by this
(as we've not heard of this causing issues until now)
Thanks!

Hey Jamie,
I'll throw together a minimal reproduction example shortly :)
Thanks loads,

Hi there.
Background
I've threw together a bit of a walkthrough that hopefully explains the situation better. Attached is a zip of all files used.
oapi-issue-minimal.zip
config.yaml
package: Openapi
generate:
  models: true
  echo-server: true
  embedded-spec: true

openapi.yaml
openapi: "3.0.0"
info:
  version: 1.0.0
  title: Minimal ping API server
paths:
  /ping:
    get:
      responses:
        "200":
          $ref: "#/components/responses/PingResponse"
components:
  schemas:
    PingResponseOne:
      type: object
      properties:
        message:
          type: string
    PingResponseTwo:
      type: object
      properties:
        error:
          type: string
  responses:
    PingResponse:
      description: Example ping union response
      content:
        application/json:
          schema:
            oneOf:
              - $ref: "#/components/schemas/PingResponseOne"
              - $ref: "#/components/schemas/PingResponseTwo"

Using the above config files and<EMAIL_ADDRESS>I run the following command:
oapi-codegen --config config.yaml  openapi.yaml > ./api/Output-1-12-4.gen.go

Similarly, using<EMAIL_ADDRESS>I run the same command and output it to a different file.
oapi-codegen --config config.yaml  openapi.yaml > ./api/Output-2-4-0.gen.go

If you look at line 57 in both of these output files, you can see that between oapi-codegen versions the function used to merge JSON has changed along with the order that the arguments are supplied.
Output-1-12-4.gen.go
57	merged, err := runtime.JsonMerge(b, t.union)

Output-2-4-0.gen.go
57	merged, err := runtime.JSONMerge(t.union, b)

The issue
The problem this causes (as pointed out by @davidsteed1) is that the order of the arguments is significant, specifically around how it handles nil and empty values. The test function below should illustrate this a bit better.
package main

import (
    "encoding/json"
    "reflect"
    "testing"

    "github.com/oapi-codegen/runtime"
)

func TestJSONMerge(t *testing.T) {
    /*
	    oapi-codegen v1.12.4 generates JSON merges using the deprecated JsonMerge function.
	    The parameters are supplied as `runtime.JsonMerge(b, t.union)` (see Output-1-12-4.gen.go l:57)
    */
    old, _ := runtime.JsonMerge(nil, []byte(`[]`))

    /*
	    oapi-codegen v2.4.0 generates JSON merges using the newer JSONMerge function.
	    The parameters are supplied as `runtime.JSONMerge(t.union, b)` (see Output-2-4-0.gen.go l:57)

	    This test fails, showing that the order of arguments is significant. This is what
            causes some tests to break in our codebase.
    */
    new, _ := runtime.JSONMerge([]byte(`[]`), nil)

    var oldJson, newJson interface{}

    err1 := json.Unmarshal(old, &oldJson)
    err2 := json.Unmarshal(new, &newJson)

    if err1 != nil || err2 != nil {
	    t.Fatal("Failed to unmarshal JSON data")
    }

    if !reflect.DeepEqual(oldJson, newJson) {
	    t.Errorf("%v and %v are not equal", oldJson, newJson)
    }
}

Hopefully this highlights a little more why changing to the new JSONMerge function, and reversing the arguments causes our test suite to fail.


Demo code has incorrect partition keys

I believe the partition keys given in the demos are incorrect. I believe the partition keys should be "category" instead of "Personal"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 239e3b2d-4a09-c6a1-ab36-70b60a18f8b5
Version Independent ID: 10a323f6-5a10-8b38-6339-48ee7a4c54b3
Content: Register and use stored procedures, triggers, and user-defined functions in Azure Cosmos DB SDKs
Content Source: articles/cosmos-db/how-to-use-stored-procedures-triggers-udfs.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @timsander1
Microsoft Alias: tisande

Thank you @michaellyoungg  for your feedback. We are reviewing this and will get back shortly.

Let me know if I'm missing anything and I'd be happy to reopen. #please-close


SQLi: add current_user

Description
SQLi bypass submitted by Shivam Bathla.
Example payload:
id=1%2bcurrent_user::int
Todo: add function current_user.

Adding to rule 942151 at PL1 is not enough because current_user does not require a (.


Update gimli to 0.14.0

@philipc, in case you missed it:
error[E0308]: mismatched types
   --> src/lib.rs:525:71
    |
525 |                     Some(gimli::DW_LANG_Rust) => demangle_rust_symbol(u.0.name.buf()),
    |                                                                       ^^^^^^^^^^^^^^ expected enum `std::borrow::Cow`, found &[u8]

    |
    = note: expected type `std::borrow::Cow<'_, str>`
               found type `&[u8]`
error[E0308]: mismatched types
   --> src/lib.rs:560:29
    |
560 |     String::from_utf8_lossy(mangled)
    |                             ^^^^^^^ expected &[u8], found enum `std::borrow::Cow`
    |
    = note: expected type `&[u8]`
               found type `std::borrow::Cow<'_, str>`
    = help: here are some functions which might fulfill your needs:
            - .as_bytes()
error: aborting due to 2 previous errors
error: Could not compile `addr2line`.

Coverage remained the same at 0.0% when pulling ada0c75371e506de7c33fc63f18e2cacb0dd4e76 on philipc:gimli into 6680e3d157575817c901e6679e51f1469a86b80c on gimli-rs:master.


[ Bugfix ] [ Optimization ]  Initialize transactions with the index coming from within the smart contract.

To be done after https://github.com/Kukuza/kukuza-contracts-monorepo/issues/4

Done


Dlib was compiled to use SSE41 instructions, but these aren't available on your machine.,

Hello everyone, I installed this on my nas with docker. The CPU of my nas is intel G5420. According to ark.intel.com, the instruction set extension supported by this CPU is Intel®SSE4.1 and Intel®SSE4. 2. Therefore, SSE41 should be supported, but it throws the following exception. Can someone take a look?
thanks in advance
 * Restarting nginx nginx,
   ...done.,
Dlib was compiled to use SSE41 instructions, but these aren't available on your machine.,
Traceback (most recent call last):,
  File "manage.py", line 22, in <module>,
    execute_from_command_line(sys.argv),
  File "/miniconda/lib/python3.8/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line,
    utility.execute(),
  File "/miniconda/lib/python3.8/site-packages/django/core/management/__init__.py", line 377, in execute,
    django.setup(),
  File "/miniconda/lib/python3.8/site-packages/django/__init__.py", line 24, in setup,
    apps.populate(settings.INSTALLED_APPS),
  File "/miniconda/lib/python3.8/site-packages/django/apps/registry.py", line 114, in populate,
    app_config.import_models(),
  File "/miniconda/lib/python3.8/site-packages/django/apps/config.py", line 211, in import_models,
    self.models_module = import_module(models_module_name),
  File "/miniconda/lib/python3.8/importlib/__init__.py", line 127, in import_module,
    return _bootstrap._gcd_import(name[level:], package, level),
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import,
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load,
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked,
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked,
  File "<frozen importlib._bootstrap_external>", line 783, in exec_module,
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed,
  File "/code/api/models.py", line 44, in <module>,
    im2vec = Im2Vec(cuda=False),
  File "/code/api/im2vec.py", line 20, in __init__,
    self.model, self.extraction_layer = self._get_model_and_layer(model, layer),
  File "/code/api/im2vec.py", line 66, in _get_model_and_layer,
    model = models.resnet152(pretrained=True),
  File "/miniconda/lib/python3.8/site-packages/torchvision/models/resnet.py", line 288, in resnet152,
    return _resnet('resnet152', Bottleneck, [3, 8, 36, 3], pretrained, progress,,
  File "/miniconda/lib/python3.8/site-packages/torchvision/models/resnet.py", line 226, in _resnet,
    state_dict = load_state_dict_from_url(model_urls[arch],,
  File "/miniconda/lib/python3.8/site-packages/torch/hub.py", line 559, in load_state_dict_from_url,
    return torch.load(cached_file, map_location=map_location),
  File "/miniconda/lib/python3.8/site-packages/torch/serialization.py", line 595, in load,
    return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args),
  File "/miniconda/lib/python3.8/site-packages/torch/serialization.py", line 764, in _legacy_load,
    magic_number = pickle_module.load(f, **pickle_load_args),
_pickle.UnpicklingError: unpickling stack underflow,
,
If you suspect this is an IPython 7.19.0 bug, please report it at:,
    https://github.com/ipython/ipython/issues,
or send an email to the mailing list at<EMAIL_ADDRESS>,
You can print a more detailed traceback right now with "%tb", or use "%debug",
to interactively debug it.,
,
Extra-detailed tracebacks for bug-reporting purposes can be enabled via:,
    %config Application.verbose_crash=True,
,
Dlib was compiled to use SSE41 instructions, but these aren't available on your machine.,

I have added a parameter to disable sse4 instructions. The build should be ready in a hour or so. Could you please do a docker-compose down, docker-compose pull and docker-compose up, to try if it works then?

I have added a parameter to disable sse4 instructions. The build should be ready in a hour or so. Could you please do a docker-compose down, docker-compose pull and docker-compose up, to try if it works then?

it worked, thanks for you solved this issue so quickly.

it worked, thanks for you solved this issue so quickly.


Shading effect for partial terrain

I am going to apply shading effect to terrain.
Applying to entire globe layer is possible but for partial rendering is impossible.
In Cesium, load terrain using CesiumTerrainProvider and it doesn't support material property.
https://sandcastle.cesium.com/?src=Globe Materials.html
This sample shows how to apply shading effect to entire globe layer.
But when I load specific terrain like
viewer.terrainProvider = new Cesium.CesiumTerrainProvider({
url: Cesium.IonResource.fromAssetId(asset_id),
requestVertexNormals: true
});
console.log (viewer.terrainProvider);
and I can't find material property in terrainProvider. Also it affects entire globe layer when I load specific partial terrain.
I think it would be good if there is feature to style partial terrain, not entire.
Best
Bojan

I meet the same problem，Could anyone provide some help？

Sorry we missed your question @cr8tpro .  If you are still having issues, please comment on the Cesium Community Forum: https://community.cesium.com/

I am not sure why you closed this issue. Cesium itself doesn't provide shading effect for self loaded terrain.

I'm sorry @cr8tpro, I misread what you were asking for.
Terrain inherently covers the extent of the entire globe, so you're right that can't apply that material styling to just a sub-section of the terrain.
Unfortunately, I don't think this is a feature we're going to add to open source CesiumJS.  We have additional analytics features such as measuring slope and shading a polygon drawn on terrain based on the slope as part of our Cesium Analytics package.  You can learn more about this here: https://cesium.com/ion-sdk/


issue 11248: add support for stdout backend, also add ability to configure multiple backends

Adds support for multiple OUTPUT sections (output plugins / backends) for fluent-bit.
Also adds support for the "stdout" output plugin
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #11248

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/assign kfox1111

Oops, messed up merge. Will create a new PR.


Game fixes and ocr docs

Description
Please provide a summary of the changes, including relevant motivation and context.
Closes #(issue_number)
Checklist:

[x] I have read the Contribution Guidelines
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

Contributor License Agreement
By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.
(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

Nice!

@CodiumAI-Agent /describe

@CodiumAI-Agent /improve

@CodiumAI-Agent /add_docs

PR Analysis

🎯 Main theme: The PR mainly focuses on game integration and OCR improvements.
📝 PR summary: This PR introduces a game feature to the application, which is displayed when a user is waiting for a process to complete. It also changes the directory path for Tesseract OCR languages and removes a Python script for detecting blank pages. The 'remove-blanks' endpoint is also moved from the 'CLI' group to the 'Java' group.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 3, because the PR includes changes in multiple files and introduces a new feature (game), which needs to be thoroughly reviewed for potential issues. However, the code changes are not too complex.
🔒 Security concerns: No security concerns found

PR Feedback
💡 General suggestions: The PR seems to be well-structured and the changes are clearly defined. However, it would be beneficial to add tests for the new game feature to ensure its correct functionality. Also, it would be helpful to provide more detailed commit messages to better understand the changes made in each commit.
 🤖 Code feedback:relevant filesrc/main/resources/static/js/downloader.jssuggestion
It would be better to move the hardcoded timeout value (5000 ms) to a constant at the top of the file. This would make it easier to modify the value in the future if needed. [medium]
relevant line'+    const timeoutId = setTimeout(() => {'relevant filesrc/main/resources/templates/fragments/common.htmlsuggestion
The game button creation and insertion logic is duplicated in the 'common.html' and 'downloader.js' files. It would be better to keep this logic in one place to avoid code duplication and potential inconsistencies. [important]
relevant line'+            var gameButton = $('Bored waiting?');'relevant filesrc/main/java/stirling/software/SPDF/controller/api/misc/OCRController.javasuggestion
The path to the Tesseract languages directory is hardcoded. It would be better to move this to a configuration file or environment variable, making it easier to change the path without modifying the code. [important]
relevant line'+        String tessdataDir = "/usr/share/tessdata";'relevant filesrc/main/java/stirling/software/SPDF/config/EndpointConfiguration.javasuggestion
It would be beneficial to add a comment explaining why the 'remove-blanks' endpoint was moved from the 'CLI' group to the 'Java' group. This would provide context for the change and help future developers understand the reasoning behind it. [medium]
relevant line'+        addEndpointToGroup("Java", "remove-blanks");'

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  About the 'Code feedback' section
The review tool provides several type of feedbacks, one of them is code suggestions.
If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results.
Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_review, enable_review_labels_effort, and more.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

PR Review

      PR feedback                       ⏱ Estimated effort to review [1-5]
3, because the PR includes changes across multiple files and technologies (Java, HTML, JavaScript, CSS), which requires a reviewer to have a broad understanding of the project's architecture and the technologies used. The changes involve both backend and frontend modifications, including adjustments to game logic, OCR configurations, and Docker compose files.

 🧪 Relevant tests
No

 🔍 Possible issues

The removal of the detect-blank-pages.py script without a clear replacement or reasoning might lead to functionality loss or regressions in detecting blank pages.
Changing the tessdata directory might affect OCR accuracy or functionality if the new directory does not contain the expected tessdata files or if permissions are not correctly set.
The addition of a game feature on the waiting screen might not be aligned with the professional or expected use of the software, potentially affecting user experience or perception.

 🔒 Security concerns
No

 Code feedback:
relevant filesrc/main/resources/static/js/downloader.js
suggestion

Consider adding an event listener to dynamically show the game button based on actual processing time rather than a fixed timeout. This approach can improve user experience by adapting to the actual wait time. [medium]

relevant lineconst timeoutId = setTimeout(() => {
relevant filesrc/main/resources/templates/fragments/common.html
suggestion

Ensure accessibility for the new game feature by adding aria-label attributes to the game controls and making sure the game can be operated with keyboard inputs. This will help in making the game accessible to users with disabilities. [important]

relevant linevar gameButton = $('Bored waiting?');
relevant filesrc/main/java/stirling/software/SPDF/config/EndpointConfiguration.java
suggestion

Re-evaluate the removal of the "remove-blanks" endpoint from the CLI group. If this functionality is being moved or replaced, ensure there's clear communication or documentation for users who might rely on this feature. [important]

relevant line-        addEndpointToGroup("CLI", "remove-blanks");
relevant filescripts/detect-blank-pages.py
suggestion

If the removal of detect-blank-pages.py is intentional, consider adding a Java-based replacement or integrating an existing library to maintain the functionality of detecting blank pages within the application. This ensures that the feature set remains consistent. [important]

relevant line-import cv2

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


2023 April Updates

Overall Review of Changes:

Standardized CIS and STIG Tables.
Added Two new bugs to known issues.

Issue Fixes:
-Updated a few URLs pointing to the previous version of our deprecated readthedocs.
Enhancements:
-Added YouTube Videos and badges to pages.
How has this been tested?:
directly on our readthedocs site under devel build of the site.

Thank you Sir!


Anti-aliasing on iPad 2

Using iPad2, visit http://jsfiddle.net/intrinsica/vf062L6c/
Text is rendered almost unreadable.
Graphics rectangle appears with "cross-hair" artifacts on corners and at intersections with other rects.
This issue was introduced with PIXI v3 and is related to anti-aliasing.
Screen shot from iPad2 attached...

Ah yes! This is because ios devices do not support Antialiasing natively. So FXAA is being used instead.
If you add an object to behind the text then it does improve. http://jsfiddle.net/x54kahqp/
But if the quality is still not good enough I would recommend removing the antialiasing for ipad.

Thanks for shedding light on this. I didn't quite understand all of this from the release notes. Now it makes sense. Looks like I'll have to detect the device and switch accordingly.


BDAT not supported

Getting this error for some messages
Your message contains invalid characters (bare line feed characters) which the email servers don't support.
additional information is referencing BDAT command. Can't seem to find any references to this in the code or existing issues. Any suggestions?
"This error occurs when the email program or device used to create or send an email message adds bare line feed characters into the message. When bare line feed characters are included in a message, the SMTP protocol chunking feature is required to transmit the message between email servers. Chunking uses the SMTP protocol BDAT command, but the recipient's email server doesn't support the BDAT command."

At this point, go-guerrilla does not support BDAT / Chunking (RFC3030) and is not advertising it in the EHLO phase.
If a sending server is trying to use Chunking against a go-guerrilla server it is not working in the standards.
We might implement Chunking at some point, but it can be a quite complex issue.


Autocomplete predictions

We should look into making a autocomplete predictions feature for the search bar, to help users find the right keyword easier and faster.

I will use Jquery and see if I can make this work using the following script.

Fixed in #45


send method collides with ruby's builtin Object.send

I've hit an issue where the journald-logger gem does not work as a drop-in replacement for Logger.
The delayed_job code calls the logger by running
logger.send(level, "#{Time.now.strftime('%FT%T%z')}: #{text}")

where level is a symbol, like :info, :debug etc. It expects to be calling the ruby Object.send method, which will forward to the appropriate instance method logger.info, logger.debug, etc. depending on the log level.
However, journald-logger overrides the send method with a method that behaves completely differently, so this doesn't work.
(Note that the code using the send method can be changed to call __send__ instead to work around this issue, but requiring code changes means it's not a drop-in replacement.)

Hello, thanks for the report. Let's move it to the PR which fixes it - can you review please?
https://github.com/theforeman/journald-logger/pull/8


style: put underscores in all test names

Codecov Report
Base: 84.54% // Head: 84.49% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (7cdd0e3) compared to base (73cb564).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   84.54%   84.49%   -0.06%
==========================================
  Files          84       84
  Lines       13766    13766
==========================================
- Hits        11638    11631       -7
- Misses       1750     1755       +5
- Partials      378      380       +2

Impacted Files
Coverage Δ

server/test/write.go
88.88% <ø> (ø)

server/test/check.go
90.10% <100.00%> (ø)

server/test/connected_objects.go
99.41% <100.00%> (ø)

server/test/delete_store.go
72.91% <100.00%> (ø)

server/test/list_objects.go
72.00% <100.00%> (ø)

server/test/read_authzmodel.go
100.00% <100.00%> (ø)

server/test/read_authzmodels.go
100.00% <100.00%> (ø)

server/test/read_changes.go
89.85% <100.00%> (ø)

server/test/write_assertions.go
96.90% <100.00%> (ø)

server/test/write_authzmodel.go
100.00% <100.00%> (ø)

... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[1.3.5-prepare][cherry-pick][Fix-#4567]worker-server logback partial …

worker-server partial-logs are not printed
See #4566、#4567

+1

Codecov Report

:exclamation: No coverage uploaded for pull request base (1.3.5-prepare@af056a1). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             1.3.5-prepare    #4665   +/-   ##
================================================
  Coverage                 ?   37.20%
  Complexity               ?     2590
================================================
  Files                    ?      449
  Lines                    ?    20304
  Branches                 ?     2458
================================================
  Hits                     ?     7554
  Misses                   ?    12034
  Partials                 ?      716

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af056a1...064f1bc. Read the comment docs.


[Feature] Application Level Throttle Policy reset Support For APIM

Related Issue :

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


CentOS Stream 9

Start CentOS Stream 9
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Do you mind adding a workflow for this distribution?

Hope this is ok!


"failed: no objects visited" error when creating only secrets via helm

Output of helm version:
Client: &version.Version{SemVer:"v2.10.0", GitCommit:"9ad53aac42165a5fadc6c87be0dea6b115f93090", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.10.0", GitCommit:"9ad53aac42165a5fadc6c87be0dea6b115f93090", GitTreeState:"clean"}
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-21T09:17:39Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"windows/amd64"}
Server Version: version.Info{Major:"1", Minor:"10+", GitVersion:"v1.10.6-gke.2", GitCommit:"384b4eaa132ca9a295fcb3e5dfc74062b257e7df", GitTreeState:"clean", BuildDate:"2018-08-15T00:10:14Z", GoVersion:"go1.9.3b4", Compiler:"gc", Platform:"linux/amd6
4"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):
GKE
Issue Description
I have a helm template which I am using to create secrets. I created a chart which only creates secrets for my applications. When I run the chart in --debug --dry-run mode it works fine and I do not get any error. But when I actually try to create a secret from it I get below error:

Error: release test failed: no objects visited

Below is how i created my chart:

helm create test
values.yaml content:

   secrets:
      test: YmFzZWw=

helm install --name  test test --debug

This is my helm template to create secret:
    apiVersion: v1
    kind: Secret
    metadata:
      name: {{ $.Release.Name }}-secrets
      labels:
        chart:    {{ $.Chart.Name }}-{{ $.Chart.Version | replace "+" "_" }}
        release:  {{ $.Release.Name }}
        heritage: {{ $.Release.Service }}
    data:
    {{- range $key, $val := .Values.secrets }}
      {{ $key }}: |-
    {{ $val | indent 4}}
    {{- end }}

But When i run kubectl get secrets I see that my secret named test-secrets was created successfully. And when I use kubectl describe I even see the content.

/bug

FWIW,  am seeing the same with a Job instead of secrets.  I am using helm
10:19 $ helm version
Client: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}

I am using hooks
  annotations:
    "helm.sh/hook-weight": "100"
    "helm.sh/hook": post-install,post-upgrade
    "helm.sh/hook-delete-policy": before-hook-creation

HI @bradleyd, this issue happens for :

secrets
Configmaps
jobs
cronjobs

It's not a big issue but it is quite annoying

@Krishna1408 thanks for the quick response.    I just added a || true to the end for now until a fix is in.

@Krishna1408 @bradleyd
I had the same issue with the error "failed: no objects visited" trying to create secrets by helm.
After removing unused annotations the deployment works with following version:
Client: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}

Annotations removed:
annotations:
    "helm.sh/resource-policy": keep
    "helm.sh/hook": pre-install,pre-upgrade

helm upgrade --install ...

As there are not so many people raising this issue it's been neglected till now.. I hope someone sees it and take some action. I'll see if I can do anything to fix it.

This is an issue for me as well.  I want to deploy a job to perform some tasks, but since there is no deployment, statefulset, etc...  the deployment fails.  As a work around I'm looking at having to create a deployment that does essentially nothing.

+1 on this

+1

+1

+1

+1 for me as well.

+1

Can someone re-label this issue as a bug? It renders impossible to use jobs as hooks as documented here

This particular error occurs when a chart does not define any templates.
If I'm understanding the reports here, are all the resources within the chart are marked as a hook? Hooks are considered "un-managed" by tiller. If everything is marked as a hook and there are no other objects to install, that would definitely trigger this error.
I'm not sure if that would be considered a bug though given that this was an intentional design decision. What's the use case here for having a chart with only hooks but no resources?

After mulling this through I don't think this is a bug from the backend's point of view, but rather a usability issue which we can address with docs or a better understanding of the use cases involved.

I just deleted all the "+1" comments in this thread. In the future, please add a :+1: to the OP instead. That way we can keep the discussion moving forward without a bunch of +1 comments flooding the thread. Thanks!

If I'm understanding the reports here, are all the resources within the chart are marked as a hook?

No, we do not have only hooks. In my case, we have a functioning chart with multiple deployments, and we want to add a single job as a pre-install,pre-upgrade hook. And that doesn't work, because Helm needs to wait of its completion.

If you wouldn't mind providing an example to use for testing purposes, that would be helpful to identify the issue. Thanks!

@bacongobbler after deploing on staging we call a job for updating a schema using a symfony command.
@bacongobbler after deploing on staging we call a job for updating a schema using a symfony command.

apiVersion: batch/v1
kind: Job
metadata:
name: schemaupdate
labels:
app: {{ $.Values.app.name }}
tier: schemaupdate
annotations:
helm.sh/hook: "pre-install,pre-upgrade"
helm.sh/hook-delete-policy: "before-hook-creation"
spec:
template:
metadata:
labels:
app: {{ $.Values.app.name }}
tier: schemaupdate
spec:
restartPolicy: Never
imagePullSecrets:
- name: "{{ $.Values.gitlabRegistrySecret }}"
containers:
- name: php
image: gitlab.myhostedgitlab.it:4567/app/fpm:{{$.Values.app.tag}}
command: ["bin/console","doctrine:schema:update", "--dump-sql", "--force"]
imagePullPolicy: Always
resources:
requests:
memory: "{{ $.Values.job.schemaupdate.resources.requests.memory }}"
cpu: "{{ $.Values.job.schemaupdate.resources.requests.cpu }}"
limits:
memory: "{{ $.Values.job.schemaupdate.resources.limits.memory }}"
cpu: "{{ $.Values.job.schemaupdate.resources.limits.cpu }}"
env:
{{ include "deployment.mysql-env" . | indent 10 }}

After deploying with helm we have the no object visited even if the job was successfull.

We use hooks for delete previous deployment of the job for allowing us to see logs from the pod.

We can simplify that job like this (for debug purposes):
apiVersion: batch/v1
kind: Job
metadata:
  name: schemaupdate
  labels:
    app: myapp
    tier: schemaupdate
  annotations:
    helm.sh/hook: "pre-install,pre-upgrade"
    helm.sh/hook-delete-policy: "before-hook-creation"
spec:
  template:
    metadata:
      labels:
        app: myapp
        tier: schemaupdate
    spec:
      restartPolicy: Never
      containers:
        - image: alpine:3.8
          command: ["sleep","10"]

Obviously you need at least an other working non-hook template to make it testable, but it shouldn't matter which one, it's enough that it's a resource that Helm is able to deploy on its own.

Hi @bacongobbler
Here is the usage we have of a chart containing hooks only: we got inspired by the documentation on hooks that says Execute a Job to back up a database before installing a new chart, and then execute a second job after the upgrade in order to restore data.
So, among others, we built a Job which goal is to backup some data. This Job is to be executed before some other installation stuff.
The reason why we decided to put this into an independent chart, with only hooks in it are the following:

A Pre-Hook is convenient for executing the backup “before” the other installation steps; so let's put our Job as a Hook
In case the execution of the Job is correct, we don’t want the Job and the corresponding Pod to remain visible in Kubernetes. We want to keep them only in case of error. So the "helm.sh/hook-delete-policy": hook-succeeded,before-hook-creation annotation is exactly answering this need
Such a backup is required in different situations, and we want to be able to execute the backup independently from the installation steps. So having a dedicated chart is again very convenient as we can helm on it only, or we can helm a set of charts that includes this backup chart (or the chart could even be a dependency of other charts)

I understand your point when you say that hooks are not resources managed by helm, so this is not a bug when helm says that there are no resources in the given chart… but I would argue that even if hooks are not “managed” by Helm, Hooks are notions defined by Helm, so there is not really “no [Helm-defined] objects visited” in such charts because there are hooks!

What is the recommendation for such use cases where we have to execute a job and delete that after its done without using hook? Because I can't execute it with hook in place since there was no resource for the hook

So, we do have a scencario in which we'd like to run a pre-install hook and not create a resource in the same workload:
During deployment, we're using a chart that gets values from hashicorp vault & creates secrets from them (using vault & consul-template). We do not want to integrate this into the charts themselves as we'd have to use custom charts then, which we'd have to maintain.
So a pre-install hook would be perfect for this as it can execute before anything else and prepare the secrets needed, however we run into this error. If there is a workaround please let me know!

Making this behavior optional, would be great!

This issue prevents causes the tutorial here: https://helm.sh/docs/chart_template_guide/#a-first-template to fail.
Client: &version.Version{SemVer:"v2.14.1", GitCommit:"5270352a09c7e8b6e8c9593002a73535276507c0", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.1", GitCommit:"5270352a09c7e8b6e8c9593002a73535276507c0", GitTreeState:"clean"}

Oh, so this error is not actually an error, that's great news. If this can't be fixed, would it be possible to change the message into something that explains that everything is fine?

Hi! Could anyone give an update on this topic, please? I have a very similar case to what has already been mentioned. Although the deployment is successful, job finishes, helm states the error. Is there any fix or workaround for this?

Thank you everyone for your comments/opinions on this.
A lot of the examples provided deal with firing off a job as a one-off thing. I'm curious to understand why Helm is being used in this way.
As context, Helm was designed to be used as a package manager: it installs and manages an application in a traditional manner, similar to apt, yum and brew.
Chart hooks are quite similar to other package manager's pre-install/post-install hook systems. They're meant to be used as supportive tooling for the package to be installed, but are not meant to be used as a stand-alone object. In other words, they were never designed to be the package.
The examples provided above are similar to asking brew to fire a pre-install hook, but never install something in the operating system. I'm having a really tough time understanding why a package manager should accommodate this workflow.
Are there previous examples where this workflow has been provided by other package managers?

@bacongobbler my use case doesn't involve hooks or anything like that so this may be an outlier. I just want to be able to install CRDs individually without any other necessary resources in the templates directory as mentioned in #7247. This is part of a work around due to #6581 where I am unable to put new crd versions in the same chart. I would expect this to be possible without an error since a chart can contain arbitrary kubernetes resources. This is occurring with helm3 for additional context.

Are there previous examples where this workflow has been provided by other package managers?

I think traditional package repositories often contain meta-packages that only exist to bundle dependencies (or signal some sort of system state).
I believe it is usually possible to start developing a package and have working tests and CI right from the start, without making it install any placeholder resources.
 A combination of settings that results in no resources not being deployed might be the desired initial state—especially when the Chart is used in an automated way, e. g. packaged as an Operator.

As a workaround just define dummy service i.e.
apiVersion: v1
metadata:
 name: google
spec:
 type: ExternalName
 externalName: google.com```

hello
i ran into the same issue and i dont see any solution here. can some one provide what needs to be done.
Error: UPGRADE FAILED: "job1-controller"  has no deployed releases

In what all scenarios is this error seen? Because I am not using any hooks like pre-install, but still getting the error as "No objects visited".

Hi Vaishali,
My Use Case:
It is important to note that if you are importing secrets from *.tgz file, then it might work as expected (as long as it was packaged using helm package command). If you are extracting the package using tar -xvf *.tgz, then it doesn't extract the secrets charts properly in MacBook, and if you install from folder, then this cause the error.
My tar looks like this when I print the content, but actually when I try to unpack it, it extracts differently. Could be in Helm2, it is not possible to unpack it easily? I tried various posts to get the right command to extract and update the security as per our need, and install from there.
tar -tvf cs-secrets-16.7.1000-0847.tgz
-rwxr-xr-x  0 0      0         149  1 Jan  1970 cs-secrets/Chart.yaml
-rwxr-xr-x  0 0      0        2320  1 Jan  1970 cs-secrets/values.yaml
-rwxr-xr-x  0 0      0        1089  1 Jan  1970 cs-secrets\templates\_helpers.tpl
-rwxr-xr-x  0 0      0        2406  1 Jan  1970 cs-secrets\templates\secrets.yaml
-rwxr-xr-x  0 0      0         354  1 Jan  1970 cs-secrets\.helmignore
Amit

In what all scenarios is this error seen?

@vaishali-prophecy see https://github.com/helm/helm/issues/4670#issuecomment-472896695

My tar looks like this when I print the content, but actually when I try to unpack it, it extracts differently. Could be in Helm2, it is not possible to unpack it easily?

The chart format is the same between Helm 2 and Helm 3... Can you perhaps explain what you are trying to do, and what issues you're running into?

My tar looks like this when I print the content, but actually when I try to unpack it, it extracts differently. Could be in Helm2, it is not possible to unpack it easily?

The chart format is the same between Helm 2 and Helm 3... Can you perhaps explain what you are trying to do, and what issues you're running into?

Hi Mat,
Our Product Vendor Documentations are asking to install the secrets.tgz post modifications of the values in the values.yaml file. It would be nice if you could guide us how can I unpack (preserves the directory structure) the secrets.tgz provided by the Product Vendor, and repackage it using Helm2 (supported by Product Vendor).
As I'm new to the helm, I used tar -xvf secrets.tgz, but it doesn't preserve the directory structure as printed in the tar -tvf secrets.tgz. It seems there are other ways to override the secrets without unpacking the secrets.tgz.
Please help!

That should work. That's what I use for unpacking and inspecting charts, and that's how Helm does it, too.

Here is another example if this message:
NAMESPACE=sandbox

cat <<EOF > yaml/values.jenkins.yaml
rbac:
  install: true
  apiVersion: v1
EOF

helm install jenkins stable/jenkins \
  -f yaml/values.jenkins.yaml \
  --namespace $NAMESPACE

I am hitting this problem - I have a couple Charts all which share the same Secret and my initial plan was to create a Chart just for those Secrets, but then I hit the error described in the original post. I imagine this must be a common scenario with multiple Pods sharing the same Secret - what is the advised practice for this in Helm 3?

I am having the same issue and no way to troubleshoot the same. When i enter help upgrade it just fails with the message "Release failed: no objects visited".
When i run with --debug no XRROR is shown. Is there a solution to this?

One possible cause is due to pod allocation policy, I have seen this error while deploying more replicas than the number of nodes.

I'm hitting the same issue when trying to install a chart, which only installs the CRDs from crds directory.

I'm having the same issue with the Hook for a Job. I need to create a Job and wait for it's completion, but I can't do this with the --wait flag, since it doesn't work for a Job. When I switched to setting a Job with the Hook, I came into this problem. What is the workaround?
P.S. Users are weird sometimes and we need strange use-cases, such as a Job creation in a separate deployment flow. Sorry for that :) But since it is allowed by Helm to have different resources deployed separately, it would be good to have a workaround for such kind of issues.

My use case: Have helm execute a job (custom built docker image/pod).
My workaround is to have a deployment with replicaCount: 0
Works for me!

Hi, in our case our templates have been guarded with conditions. We forgot to set the values and as a result, no template was rendered. Just letting know.

Not stale please.

Not stale annyoing bot.

/lifecycle freeze

/remove-lifecycle stale

Not stale

Helm 2 is no longer supported.
Helm 3:
Per the description I created a chart (helm create chart foo). In that chart I removed everything under templates and created a single template file:

templates/secret.yaml

---
apiVersion: v1
kind: Secret
metadata:
  name: {{ $.Release.Name }}-secrets
  labels:
    chart:    {{ $.Chart.Name }}-{{ $.Chart.Version | replace "+" "_" }}
    release:  {{ $.Release.Name }}
    heritage: {{ $.Release.Service }}
data:
{{- range $key, $val := .Values.secrets }}
  {{ $key }}: |-
{{ $val | indent 4}}
{{- end }}

I set the chart's values.yaml as specified in the issue description:

values.yaml

---
secrets:
  test: YmFzZWw=

Then install it
helm install foo foo

NAME: foo
LAST DEPLOYED: Thu Jan 13 10:56:48 2022
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None

Is this issue still valid for helm 3?

Also tried with making it a hook with no error:

templates/secret.yaml

---
apiVersion: v1
kind: Secret
metadata:
  annotations:
    helm.sh/hook: "pre-install,pre-upgrade"
    helm.sh/hook-delete-policy: "before-hook-creation"
  name: {{ $.Release.Name }}-secrets
  labels:
    chart:    {{ $.Chart.Name }}-{{ $.Chart.Version | replace "+" "_" }}
    release:  {{ $.Release.Name }}
    heritage: {{ $.Release.Service }}
data:
{{- range $key, $val := .Values.secrets }}
  {{ $key }}: |-
{{ $val | indent 4}}
{{- end }}

With the following Helm version:
$ helm version
version.BuildInfo{Version:"v3.7.2", GitCommit:"663a896f4a815053445eec4153677ddc24a0a361", GitTreeState:"clean", GoVersion:"go1.17.4"}

And following reproducing steps:
helm create foo
cd foo && rm -r ./templates
mkdir -p ./crds/
cat <<EOF > ./crds/test.yaml
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  # name must match the spec fields below, and be in the form: <plural>.<group>
  name: crontabs.stable.example.com
spec:
  # group name to use for REST API: /apis/<group>/<version>
  group: stable.example.com
  # list of versions supported by this CustomResourceDefinition
  versions:
    - name: v1
      # Each version can be enabled/disabled by Served flag.
      served: true
      # One and only one version must be marked as the storage version.
      storage: true
      schema:
        openAPIV3Schema:
          type: object
          properties:
            spec:
              type: object
              properties:
                cronSpec:
                  type: string
                image:
                  type: string
                replicas:
                  type: integer
  # either Namespaced or Cluster
  scope: Namespaced
  names:
    # plural name to be used in the URL: /apis/<group>/<version>/<plural>
    plural: crontabs
    # singular name to be used as an alias on the CLI and for display
    singular: crontab
    # kind is normally the CamelCased singular type. Your resource manifests use this.
    kind: CronTab
    # shortNames allow shorter string to match your resource on the CLI
    shortNames:
    - ct
EOF
helm install test .

I no longer get any warnings or errors!

Thanks for confirming. I'll close this issue then.


Preview 5 - Controls not Responding to Mouse Clicks

Describe the bug
Buttons, DatePicker, and Window Close and Minimize buttons are not responding to mouse clicks.
The running (or debugging) app needs to be closed from within the IDE (Rider).
I've had no problem with click events until Avalonia Preview 5.
To Reproduce
Click on a control.
Expected behavior
Control should respond to the mouse click and run the associated event.

Avalonia 11.0.0-preview5
Microsoft Windows 11 Pro
10.0.22621 Build 22621

It was fixed with the latest nightly builds.

Ah, OK. Thanks.
Is the latest nightly reasonably stable?


Fix JSON history corruption.

Also adds new logic to preserve the JSON representation of unknown operations, to protect from version downgrading or removal of extensions.
Closes #1990.

I have extensively tested this and it works as expected - merging.


TRS Client keeps hammering the TRS Servers at a fixed rate after getting 5xx/4xx

This causes a lot of trace output but also in real world should be dealt via an exponential backoff.

wontfix


Flow .19

This version of flow is really nice!
Some new things include being able to define a .flow file. This will help with our platform files.
Say we have foo.render.desktop.js and foo.render.mobile.js, we can declare their types in foo.render.js.flow and flow will use that as their type interface.
Another cool thing is the React Component inference works correctly now!

I, for one, welcome our typed overlords.
@keybase/react-hackers

:+1:


Fixes a possible typo on the Finnish age bins

Currently, the age bins shown in the CVS files for Finland are:
0-9 	10-49 	20-59 	30-39 	40-49 	70-59 	60-69 	70-79 	80-

but they seem wrong. Exploring the query done to obtain the data it seems this should be:
0-9 	10-19 	20-29 	30-39 	40-49 	50-59 	60-69 	70-79 	80-

This seems like a straightforward change, and I agree it seems like we made a mistake. If you are still interested in pursuing this PR, please sign the CLA so we can merge the code.

In the process of finding out who has to sign the CLA in my university...

Hi @dpshelio please let me know if you are still interested in pursuing this PR, otherwise we will have to close it.
FYI, the vast majority of contributors sign their own CLAs instead of making contributions to our repos on behalf of their company / university.

Closing due to inactivity


Add CSV output support for repeated/fieldset fields

I was writing a probe module I intended to use with the CSV output module but ran into trouble when I needed to print repeated fields.
I just added a (recursive) function in case there are multiple repeat levels (as well as to avoid adding the space at the end of cs_process() for every Repeated field/Field set).

We specifically don't support CSV for repeated fields, since the number of output fields wouldn't be constant. How are you handling this?

Since I haven't heard from you, I'm going to close this pull request. Feel free to reopen if you have an answer to my previous question. Thanks!