feat: Update signer-function logic to be more dynamic

Right now I can pass a signer function to request the required key on demand like this example with veramo:
    const signer: Signer = async (data: string) => context.agent.keyManagerSign({ keyRef: key.kid, data })
    const sdjwt = new SDJwtInstance({
      signer,
      hasher: this.algorithms.hasher,
      saltGenerator: this.algorithms.salltGenerator,
      signAlg: alg,
  })

The problem is, that the signAlg is a static value so I am not able to use any other sign algorithm in my signer.
Suggestion
The signer will return not just the signature, but also the used signAlgorithm. This would allow a more dynamic approach
We could think about using this approach also for the hasher, beside the specification of sd-jwt is limited to sha-256. But It would make this approach more generalised when we change it now for the signature

Input data of signer function is Base64url(header) + '.' + Base64url(payload). The value of signAlg is put into header (e.g. {alg: "EdDSA", typ: "sd-jwt"}). So I think we can't use signer's return value to set header.

My first intention was to create an sdjwtInstance and issue it after the algorithm is decided. What I think was algorithm is more reusable than claim.
However as you told, framworks provide multiple alg. I propose using optional parameters in issue, present and verify method to inject the signer and signAlg.
And instance's signer and signAlg value is a default

So we should not pass the header + payload in the signer function, but only the payload? Like you said: the type of key could be defined in when selecting the issuer -> and then the key.


feat: merge complex fields - [TOL-1022]

This is currently a WIP

[ ] handle when we add a new entry
[ ] add tests

closed in favour of #33


Use of the tool.

Hey, first of all, thanks for sharing the tool. Clone the repository, create a virtual environment where you install all the dependencies, but the truth is that I don't understand how to really use it. I would love to make a video (which would be in Spanish) showing the use of it and giving some example to respect.
Any information to the respect would serve me.
Thank you.

It is still in the development process, so I have not yet written any docs for this. You can read files by using classes from the root of the library's dir for now.

Okay, thanks for the information. I will wait patiently to spread this great tool. I tried to convert .wmo files, but I didn't really get around to it.


Julius High Word Error Rate (WER)

Hello,
I installed Julius 4.3.1 on windows/Cygwin and used my own Arabic acoustic model HTK 3.4, corpus 8.5 hours, ngram LM, tied.list. The decoder is working well. However, the results is far away from HTK HDecode. I have HDecode HTK WER = 30% while in Julius it is 90% which I think there is something wrong in Julius decoder configuration.
The configurations are:
-input mfcfile
-filelist filelist/test.scp
-nlr test.lm
-v test.dic
-h hmmsdef.mmf            # acoustic HMM (ascii or Julius binary)
-hlist tied.list        # HMMList to map logical phone to physical
-b 10000
-s 20000             # hypotheses stack size on 2nd pass (#hypo)
-m 10000            # hypotheses overflow threshold (#hypo)
-n 100                # num of sentences to find
I also applied the LM scale factor (10) that I'm using in HTK as follows:
-imp 10.0 0.0
the log file as attached.
log.txt
If you kindly help tweaking the decoder as I think it should give closed WER to HTK.
Appreciate your response.
Regards
Abdo

To get Julius properly decoding I suggest you download some examples from GIT from other branches , such as https://github.com/julius-speech/dictation-kit and carefully study its contents. To tune Julius and get it working is quite a lot of work. I have been tuning my results for the last 8 years, and just only recently I get a WER of around 11%. However a good starting point is an example available above. Another good resource is http://voxforge.net
Julius is quite different than HTK - the only similar thing between them is that Julius can read HTK models. Apart of that not too much in common. To get you a good starting point here is config I use:
-input file
-filelist models\test.dbl
-htkconf models\wav_config
-h models\PLPL-Legal-v0.1.am
-hlist models\PLPL-Legal-v0.1.phn
-d models\PLPL-Legal-v0.1.lm
-v models\PLPL-Legal-v0.1.dct
-b 2000
-walign
-fallback1pass
-spmodel sp
-multipath
-spsegment
-norealtime
-spmodel sp
-gprune none
-sepnum 150
-lmp 12 -4
-lmp2 12 -4
-b2 360
-n 40
-s 2000
-m 8000
-lookuprange 5
-sb 80
-forcedict

You also seem to have quite a few errors in your log
ERROR: error in reading parameter file: D:/Luminous/Test/corpus/output/test/004270.mfcc
read analyzed parameter
Error: gzfile: failed to open "D:/Luminous/Test/corpus/output/test/004271.mfcc"
ERROR: error in reading parameter file: D:/Luminous/Test/corpus/output/test/004271.mfcc
read analyzed parameter
Error: gzfile: failed to open "D:/Luminous/Test/corpus/output/test/004272.mfcc"
ERROR: error in reading parameter file: D:/Luminous/Test/corpus/output/test/004272.mfcc
read analyzed parameter
Error: gzfile: failed to open "D:/Luminous/Test/corpus/output/test/004273.mfcc"
ERROR: error in reading parameter file: D:/Luminous/Test/corpus/output/test/004273.mfcc
read analyzed parameter
Error: gzfile: failed to open "D:/Luminous/Test/corpus/output/test/004274.mfcc"
ERROR: error in reading parameter file: D:/Luminous/Test/corpus/output/test/004274.mfcc
read analyzed parameter
Error: gzfile: failed to open "D:/Luminous/Test/corpus/output/test/004275.mfcc"
ERROR: error in reading parameter file: D:/Luminous/Test/corpus/output/test/004275.mfcc
Can it be that some of the files were completely ignored, thus your high WER?

Hello,
The error because i excluded some noisy files from mfcc. I can eliminate this error by removing the mfcc files from the filelist. however, i don't think it has effect on the results.
What do you see?

Hello palles77,
thank you so much for the parameters you sent, it makes much improvement on the level of debugging and word alignment.
I just have another question, i did split the score of AM and LM, i got the following:
AM: -38075.484375  LM: -988.138062
i believe that the score are far way each other as i used scale factor 10.0 in htk, however, i couldn't find it as lmp doesn't reflect on these far results. Any ideas?

I never looked at these AM and LM figures, never could make out what they actually mean. I suppose you could debug Julius in Windows using VS2013 as I am doing normally and see how these values are calculated.
In terms of files sent to Julius I would recommend sending WAV files instead of MFC if possible - makes things easier and less prone to errors. If you really want some more help from me you can send me your models and wave files and I can try experimenting with them, however I do not really know your native language, so I might not be much of help anyway.

Hello @Abdolrahman ,
The scores of Julius are in log10, whereas the HTK scores are in log.  the LM score reflects both LM weight and word penalties.


Keys are only regenerated if the user forces it to avoid breaking existing deployments

Fixes #211
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Running integration tests again

Integration tests passed


CLO Refactor

Refactoring ContinuousLocalOptimization to be more flexible for other optimization methods. This version uses the structure I proposed with a separate Optimizer class:

rather than keeping the optimizer within the wrapper:

I didn't really have a preference when we discussed this, so if you prefer the latter, let me know and it's pretty easy to swap between the two approaches. The only significant difference between the two I can come up with is that it is easier to swap the optimizer in the former approach. Maybe this is useful if a user wants to have a different objective function/optimization method after a period of evolution?
Changing the interface like this would break existing code, do you think it's worth it to provide a legacy version of the class with some switch between the two if the new version can't be used?
On a side note, the linter is complaining about a lot of older code. So I'll probably have to go through that at some point and change things to get the score above the 9.8 threshold.

Travis build seems to be failing because it can't find a proper scipy version (see here).

Also, I'm ok with breaking backwards compatibility at this point (since we are pre v1.0)
And lets ignore travis (we should probably remove it from the CI because we're using github actions now)

Renamed the optimization interface, moved it to its own file, and made Chromosome implement it (see the conversation about the interface for more details). Also renamed some of the modules to align with their classes.
I decided to leave the changes in doc/ out of this PR since I'll be looking at the docs in the near future.


java.lang.IllegalAccessError: failed to access class com.linecorp.armeria.server.AbstractContextPathServicesBuilder

Compiler version
Scala version 3.3.3 and 3.5.1
Minimized code
The code below runs in Java. But in Scala, it throws an  IllegalAccessError exception.
package experiment

import com.linecorp.armeria.common.HttpResponse
import com.linecorp.armeria.server.Server

@main def hello(): Unit =
  val server = Server.builder()
    .contextPath("/v1")
    .service("/", (ctx, req) => HttpResponse.of("Hello, world"))
    .and()
    .build()
    .start()

  println(s"server started = ${server}")

build.sbt
val scala3Version = "3.5.1"

lazy val root = project
  .in(file("."))
  .settings(
    name := "test-armeria",
    version := "0.1.0-SNAPSHOT",

    scalaVersion := scala3Version,

    libraryDependencies ++= Seq(
      "com.linecorp.armeria" % "armeria" % "1.30.1",
    )
  )

Output
Exception in thread "main" java.lang.IllegalAccessError: failed to access class com.linecorp.armeria.server.AbstractContextPathServicesBuilder from class experiment.Main$package$ (com.linecorp.armeria.server.AbstractContextPathServicesBuilder and experiment.Main$package$ are in unnamed module of loader 'app')
	at experiment.Main$package$.hello(Main.scala:9)
	at experiment.hello.main(Main.scala:6)

Expectation
The code should run without error.

The same code works in Scala 2.12.13
package experiment

import com.linecorp.armeria.common.HttpResponse
import com.linecorp.armeria.server.Server
object Test {

  def main(args: Array[String]): Unit = {
    val server = Server.builder()
      .contextPath("/v1")
      .service("/", (ctx, req) => HttpResponse.of("Hello, world"))
      .and()
      .build()
      .start()

    println(s"server started = ${server}")
  }
}

val scala3Version = "2.12.13"
lazy val root = project
.in(file("."))
.settings(
name := "test-armeria",
version := "0.1.0-SNAPSHOT",
scalaVersion := scala3Version,

libraryDependencies ++= Seq(
  "com.linecorp.armeria" % "armeria" % "1.30.1",
)

)

This seems to have been fixed in nightly ( 3.6.1-RC1-bin-20241016-2fc299b-NIGHTLY), but not in 3.5.2-RC2.
We might need to bisect the fix and backport to the LTS.
cc @prolativ
The following works:
//> using scala 3.6.1-RC1-bin-20241016-2fc299b-NIGHTLY
//> using dep com.linecorp.armeria:armeria:1.30.1
package experiment

import com.linecorp.armeria.common.HttpResponse
import com.linecorp.armeria.server.Server
object Test {

  def main(args: Array[String]): Unit = {
    val server = Server.builder()
      .contextPath("/v1")
      .service("/", (ctx, req) => HttpResponse.of("Hello, world"))
      .and()
      .build()
      .start()

    println(s"server started = ${server}")
  }
}

@Gedochao I confirmed that 3.6.1-RC1-bin-20241016-2fc299b-NIGHTLY fixes the problem

I would be grateful if this fixed can be backport to the next  possible 3.5.x. Thanks in advance

3.5.2 final has already been shipped. It will be backported to 3.6.0 or 3.6.1

I needed to slightly modify the snippet to close the server so that it doesn't hang the bisecting tests.
/tmp/bisect/ArmeriaServer.scala
//> using dep com.linecorp.armeria:armeria:1.30.1

import com.linecorp.armeria.common.HttpResponse
import com.linecorp.armeria.server.Server
object Test {
  def main(args: Array[String]): Unit = {
    val server = Server.builder()
      .contextPath("/v1")
      .service("/", (ctx, req) => HttpResponse.of("Hello, world"))
      .and()
      .build()
    println(s"starting server")
    val started = server.start()
    started.get()
    println(s"server started")
    server.stop()
    println(s"server stopped")
  }
}

Bisected with
scala-cli project/scripts/bisect.scala -- --should-fail --releases 3.5.1-RC1-bin-20240628-1efbb92-NIGHTLY... run /tmp/bisect/ArmeriaServer.scala

The bisect points to https://github.com/scala/scala3/pull/21362

Ah, I've just bisected it to the same commit, adding sys.exit(0) would do the job as well for bisect purpose.
I'll start backporting this to 3.6.0-RC1. I propose to close it after backporting to 3.3.5 LTS

@WojciechMazur as far as I can see the issue was fixed on 10.08, which was before the cut-off of release-3.6.0, so this shouldn't need any backporting for 3.6.x. Or did I miss something?

That's correct, I've just checked to ensure it's included, so no work needed for Next release


Add documentation

Ran make html for gh-pages

@soumith

Do you need to redo this due to the recent merge?

I did it in commit df5d216 (different from 8e29244 which is the pre-merge)


Update README.md

Checklist

Adresses Issue:
Quick summary of changes
Changes are GNU/BSD Compatable: [yes/no]
Changes are applicable to the wider community.
Request help with testing if needed.

/test-e2e


Hotfix/docs

文档补充

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          103       103
  Branches        21        21
=========================================
  Hits           103       103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59a1965...99a1087. Read the comment docs.


i cant load all my manga in aniyomi

Steps to reproduce
i just update my aniyomi
then i want to reload it, just 15 of em
but i have 100 manga
this not happend before
Expected behavior
i have 100 manga, should it reload all of them
Actual behavior
but the result is just reload 15 of them, this never happend before
Crash logs
there is no crash, force close
Aniyomi version
<IP_ADDRESS>-3393
Android version
Android 10
Device
Xiaomi Poco M3
Other details
this is never hapend before update, maybe this cause of the apps not stable yet? or just me, please help me
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

this is the intended behaviour. go to settings > library > library update restrictions to change this.


Add discord webhooks

Hey, add discord webhooks for plugin. Good feature when you have discord and site.

Webhooks which would send messages when a new punishment is created?

Webhooks which would send messages when a new punishment is created?

Yea


ubi filesystem extraction

From what I can tell, binwalk doesn't support extraction of ubi filesystems.
I'm not certain if there's a magic that can be used to detect them.
There are python tools that can be used to extract ubi files such as ubidump
What would it take to include such a tool?
I know that third party tools are sometimes used in extraction.
sasquatch comes to mind.
Sometimes these third party tools have to be manually installed.
Ever thought about pulling them in as submodules?

I will push the changes I made to my fork when I have time, or you can make them yourself
Add an extractor method to the class @  https://github.com/ReFirmLabs/binwalk/blob/master/src/binwalk/plugins/ubivalid.py
Have it use the ubifs tools. Follow the cpio plugin as a guide
If I remember correctly the command I used for the extraction in that method was ubi_image_extract

UBI is supported in Binwalk v3:


Cli: Run a function from a list of functions in a functionapp locally

Can you explain what you mean a bit more? Is this a feature request or something that's not working as you're expecting?

I have a function app with some function in it
how can i run only one function instead of all function locally?

I have a function app with some functions in it
how can i run only one function instead of all functions locally?

Use func run. See https://blogs.msdn.microsoft.com/appserviceteam/2016/12/01/running-azure-functions-locally-with-the-cli for a walkthrough

I've already try func run <functionname> but it's not working.

I can confirm it does usually work.
One thought you did use func init? I forget that sometimes for a new folder and then it doesn't work
You'd need to provide more info about your configuration for any one to help.

I have three time trigger functions
first function start every minute second every 2 minutes and third every 3 minutes.
when i run only the second function using CLI with func run secondFunction comand this is the out put:
Listening on http://localhost:7071/
Hit CTRL-C to exit...
Reading host configuration file 'C:\dev\Azure Functions\New folder\host.json'
Host lock lease acquired by instance ID '000000000000000000000000B567BE4B'.
Generating 3 job function(s)
Starting Host (HostId=369676140f284042807825956a6e3a0c, Version=<IP_ADDRESS>, ProcessId=8444, Debug=True)
Found the following functions:
Host.Functions.firstFunction
Host.Functions.secondFunction
Host.Functions.thirdFunction
Executing 'Functions.secondFunction' (Reason='This function was programmatically called via the host APIs.', Id=8710a77f-434f-4580-a51c-65719866dcd6)
Function started (Id=8710a77f-434f-4580-a51c-65719866dcd6)
C# second function executed at: 1/19/2017 12:49:37 PM
Function completed (Success, Id=8710a77f-434f-4580-a51c-65719866dcd6)
Executed 'Functions.secondFunction' (Succeeded, Id=8710a77f-434f-4580-a51c-65719866dcd6)
Job host started
Executing 'Functions.firstFunction' (Reason='Timer fired at 2017-01-19T12:50:39.3050459+01:00', Id=ff39e5eb-16d2-4183-88f6-8f6166182edf)
Function started (Id=ff39e5eb-16d2-4183-88f6-8f6166182edf)
C# first function executed at: 1/19/2017 12:50:39 PM
Function completed (Success, Id=ff39e5eb-16d2-4183-88f6-8f6166182edf)
Executed 'Functions.firstFunction' (Succeeded, Id=ff39e5eb-16d2-4183-88f6-8f6166182edf)
Executing 'Functions.secondFunction' (Reason='Timer fired at 2017-01-19T12:50:39.3220597+01:00', Id=059506d5-c155-48b4-9be9-0e7cbc4515d5)
Function started (Id=059506d5-c155-48b4-9be9-0e7cbc4515d5)
C# second function executed at: 1/19/2017 12:50:39 PM
Function completed (Success, Id=059506d5-c155-48b4-9be9-0e7cbc4515d5)
Executed 'Functions.secondFunction' (Succeeded, Id=059506d5-c155-48b4-9be9-0e7cbc4515d5)
The next 5 occurrences of the schedule will be:
1/19/2017 12:51:00 PM
1/19/2017 12:54:00 PM
1/19/2017 12:57:00 PM
1/19/2017 1:00:00 PM
1/19/2017 1:03:00 PM
The next 5 occurrences of the schedule will be:
1/19/2017 12:51:00 PM
1/19/2017 12:52:00 PM
1/19/2017 12:53:00 PM
1/19/2017 12:54:00 PM
1/19/2017 12:55:00 PM
The next 5 occurrences of the schedule will be:
1/19/2017 12:52:00 PM
1/19/2017 12:54:00 PM
1/19/2017 12:56:00 PM
1/19/2017 12:58:00 PM
1/19/2017 1:00:00 PM
Executing 'Functions.firstFunction' (Reason='Timer fired at 2017-01-19T12:51:00.0036647+01:00', Id=6a837330-0451-47ca-b173-f4b07a310fe2)
Function started (Id=6a837330-0451-47ca-b173-f4b07a310fe2)
C# first function executed at: 1/19/2017 12:51:00 PM
Function completed (Success, Id=6a837330-0451-47ca-b173-f4b07a310fe2)
Executed 'Functions.firstFunction' (Succeeded, Id=6a837330-0451-47ca-b173-f4b07a310fe2)
Executing 'Functions.thirdFunction' (Reason='Timer fired at 2017-01-19T12:51:00.0166724+01:00', Id=380aef01-fe10-4c8c-93ae-d8f9324946a8)
Function started (Id=380aef01-fe10-4c8c-93ae-d8f9324946a8)
C# third function executed at: 1/19/2017 12:51:00 PM
Function completed (Success, Id=380aef01-fe10-4c8c-93ae-d8f9324946a8)
Executed 'Functions.thirdFunction' (Succeeded, Id=380aef01-fe10-4c8c-93ae-d8f9324946a8)
Executing 'Functions.firstFunction' (Reason='Timer fired at 2017-01-19T12:52:00.0010279+01:00', Id=027cd34c-1bcb-4e3b-bf26-1ee4cc93976a)
Function started (Id=027cd34c-1bcb-4e3b-bf26-1ee4cc93976a)
C# first function executed at: 1/19/2017 12:52:00 PM
Executing 'Functions.secondFunction' (Reason='Timer fired at 2017-01-19T12:52:00.0010279+01:00', Id=e2e02e0b-e376-42c5-9bde-b3ce6cf2143b)
Function started (Id=e2e02e0b-e376-42c5-9bde-b3ce6cf2143b)
C# second function executed at: 1/19/2017 12:52:00 PM
Function completed (Success, Id=e2e02e0b-e376-42c5-9bde-b3ce6cf2143b)
Executed 'Functions.secondFunction' (Succeeded, Id=e2e02e0b-e376-42c5-9bde-b3ce6cf2143b)
Function completed (Success, Id=027cd34c-1bcb-4e3b-bf26-1ee4cc93976a)
Executed 'Functions.firstFunction' (Succeeded, Id=027cd34c-1bcb-4e3b-bf26-1ee4cc93976a)
Executing 'Functions.firstFunction' (Reason='Timer fired at 2017-01-19T12:53:00.0009321+01:00', Id=9c478d57-f7e4-431c-85d1-2d5970290522)
And so on...
why firstFunction and secondFunction run?

@mz-rafiq This is a confusing behavior of func run that needs to be documented (I've added this note to this issue: https://github.com/Azure/Azure-Functions/issues/108).
When you do func run functionName, the CLI does two things: 1) starts the Functions Host (which will cause other triggers to fire, if applicable), and 2) invokes the entry point of functionName.
Thanks for raising this, this is something we should definitely clarify in both the docs and ideally the CLI help text.
I'm closing this particular issue as it will be resolved with documentation.

It seems we need a list of all the differences between local and azure as you mentioned another diff recently.
For example on this case I guess in azure the host is run but sleeping till the timers trigger?
Out of interest when exactly do the timers start ticking in both cases?

{ 	"functions":["secondFunction"] }  in host.json resolved my problem

@mz-rafiq You can also disable the function you don't want to run, but I assumed you were looking for a solution that didn't involve changing the config.
@SteveALee In this case, the local and remote behave the same. When you're in the Azure Portal, the functions are running and triggering if the function is enabled. If the timer is defined as very far in the future (e.g. a timer that runs every day), then when you run in a dedicated plan, the Functions runtime is doing the scheduling. If you use a Consumption plan, the central listener will wake up the Function app when it needs to execute.
See https://docs.microsoft.com/en-us/azure/azure-functions/functions-scale#consumption-service-plan for more details.


Add more relevant files into test coverage calculation

Fix #000 (<-- Add issue number here)
IMPORTANT: Each pull request (PR) should resolve an issue. Please create the issue if it hasn't been created, unless you're fixing typos or making minor changes to documentation or infrastructure. In that case, just leave the issue number as #000.
Details
If the PR title isn't enough to describe your PR, please provide details here.
Checks
Make sure these boxes are checked before your PR is ready to be reviewed and merged. Thanks!

[ ] PR is concisely and descriptively titled 📑 and links to the original issue 🔗.
[ ] Code is in uniquely-named feature branch and has no merge conflicts 📁.
[ ] Tests pass -- look for a green checkbox ✅ a few minutes after opening your PR.
[ ] @mentions of the person or team responsible for reviewing proposed changes. By default, use @BadwaterBay/reviewers.
[ ] (Optional) Screenshots/GIFs are attached 📎 in case of UI updates.

We're happy to help you get this ready. Don't be afraid to ask for help, and don't be discouraged if your tests fail at first.

Thank you for contributing to this project!

Codecov Report

Merging #48 into master will decrease coverage by 10.54%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #48       +/-   ##
===========================================
- Coverage   43.87%   33.33%   -10.55%
===========================================
  Files           3        5        +2
  Lines          98      129       +31
  Branches        5        7        +2
===========================================
  Hits           43       43
- Misses         55       86       +31

Impacted Files
Coverage Δ

src/lib/revert.ts
0.00% <0.00%> (ø)

src/bin/vaniquery.ts
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e36ad...2137d1a. Read the comment docs.


MySQL or PostgreSQL ?

I found that servicecomb uses PostgreSQL by default. Is there any consideration for this? Is there a priority for the two choices of MySQL and PostgreSQL?

It's caused by PostgreSQL license is compatible with the Apache License, so we can provide the binary release which includes PostgreSQL client.  If you still want to use MYSQL, you can put the MySQL client  into the classpath yourself.


Bump version, perform mutation to support new modules

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Bump the version to 4.6.0 from 4.5.0, and run mutation to fix module names.
Companion to https://github.com/ni/niveristand-scan-engine-module-libraries/pull/20.
Why should this Pull Request be merged?
This is required for https://github.com/ni/niveristand-scan-engine-module-libraries/pull/20 to work correctly.
What testing has been done?
Testing detailed in the modules pull request.

-[ ] D.R.Y. The mutation code is exactly the same between 4.5 and 4.6. Pull the common code into a subVI or collapse cases.


Workflow stop but task does not stop

I stopped the workflow, but the task in the workflow didn't stop, it kept going in circles

@gaozhenfeng1 Could you show us the worker logs about the issue? Thans so much!


ARROW-3172: [Rust] Update documentation for datatypes.rs

Codecov Report

Merging #2513 into master will increase coverage by 0.98%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
+ Coverage   86.24%   87.23%   +0.98%
==========================================
  Files         308       13     -295
  Lines       47094     1347   -45747
==========================================
- Hits        40615     1175   -39440
+ Misses       6405      172    -6233
+ Partials       74        0      -74

Impacted Files
Coverage Δ

rust/src/datatypes.rs
73.42% <33.33%> (ø)
:arrow_up:

python/pyarrow/ipc.pxi

go/arrow/array/bufferbuilder.go

go/arrow/math/uint64_amd64.go

cpp/src/arrow/status.h

python/pyarrow/tests/test_deprecations.py

cpp/src/plasma/client.cc

cpp/src/arrow/io/test-common.h

cpp/src/arrow/pretty_print.h

cpp/src/arrow/ipc/ipc-read-write-test.cc

... and 286 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7e6c3...c2a1a76. Read the comment docs.

@kszucs @andygrove I'm not sure why the windows build failed.  The previous commit only failed the non-windows build because thats where we run the fmt tool.
I just ran everything locally on windows and it's all good, I think Appveyor just timed out or something.  I think this should be good to merge (not sure how to re-trigger CI without making changes to confirm my theory), what do you think?

It was a temporary network issue. Thanks @paddyhoran!


added approve functionality to prolific_recruiter, made some suggesti…

added approve functionality to prolific_recruiter, made some suggestions for function draft_study
FEATURES:
- recruiter class can retrieve submission info from study
- recruiter class can approve submissions
QUESTIONS:
- I changed a few things in the draft study method (had to test it myself: locals[...] doesn't work since locals is a function
locals()[...] would work (it doesn't spit out an error, but still doesn't change the variables themself.
- Some of the comments adressing the reviewers or explaining changes. These comments should then be deleted by the
reviewers. Should I do it this way or what would be a better way to communicate?

Hi @younesStrittmatter, this PR is based on the old codebase, and will need to be redone before it can be merged. I'm closing for now (but keeping the branch open). Let's talk in the next month about how we can merge it into the current codebase.


[WIP - Do not merge] Initial support for Mac CPPCodegen

This is the initial support for enabling Mac CPPCodegen HelloWorld. In addition to enabling the platform in ILCompiler, I have also added some dummy helpers and refactored gcenv.unix.cpp to address duplicate symbols that are now present in gcrhenv.cpp.
@janvorli @jkotas PTAL

Hi @gkhanna79, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Closing as I will publish an updated PR.


Special case SM2 when decoding PEM file

fix: https://github.com/openssl/openssl/issues/20420
It is different that the SM2 private key PEM files generated by the version 1.1 and the version after 3.0, which the file generated by 1.1 is BEGIN as  "-----BEGIN EC PRIVATE KEY-----". To enable the version after 3.0 to support SM2 PEM private key file generated by 1.1 version, we have to special case SM2 when we encounter the EC type.

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

I would really like to see a test case for this. Also, with a test case this would not be acceptable with CLA: trivial, we would need a CLA signed from you. Would it be possible?
https://www.openssl.org/policies/cla.html

@JerryDevis you need to commit this with git command line

This PR has the label 'hold: cla required' and is stale: it has not been updated in 30 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

This PR has the label 'hold: cla required' and is stale: it has not been updated in 61 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

This PR has been closed.  It was waiting for a CLA for 90 days.

This PR has been closed.  It was waiting for a CLA for 222 days.


xypath needs latest messytables

xypath needs latest messytables otherwise test_getattr test in test_bag fails

This commit fixes the erroring test here; probably sensible to ensure this change doesn't affect https://github.com/scraperwiki/databaker (though I don't think it does).

xypath and databaker tests pass with messytables==0.15.0, so merging.


notifier.clear resets color too

I don't know if this is on purpose or not, but after calling notifier.clear, the color as well as the stroke widths get reset.
I set the widths when creating the new notifier and set the color in the build()-method of my widget to white.
after I call notifier.clear with a tap on a button, the color is black again (as per default).
setting the widths
@override   void initState() {     final width = 3.5;     notifier = ScribbleNotifier(widths: [width, width * 2, width * 3], sketch: );     super.initState();   }
changing the color:
@override   Widget build(BuildContext context) {     final theme = Theme.of(context);     notifier.setColor(theme.colorScheme.onBackground);

fixed in 0.4.0


[Button] Disabled buttons emit click event

Description
Click event is triggered on disabled buttons when clicking the button text.
Steps to reproduce the issue

Visit https://web-components.carbondesignsystem.com/?path=/story/components-button--default
Check "disabled" in Knobs
Open Actions tab
Click button background (no click event is triggered)
Click button foreground text (click event is triggered)

These are Storybook actions only. onClick needs to be set when authoring a page, whether the component is disabled or not.

No this is a problem in actual production applications. the onClick event is fired when clicking a disabled button, but only when clicking the foreground text. It should not be fired at all when disabled.

Weighing in; It is just my hunch but I have an impression that the disabled state of button in shadow DOM is not applied to the slotted light DOM child. Need PoC test case to see it's correct or not, though.

@asudoh @RobertaJHahn @kennylam Can you please re-open this issue since it is indeed valid? Thanks!


Don't panic on invalid gzip stream

Before this change automerge-rs would panic if the gzip data in a raw column was invalid; after this change the error is propagated to the caller correctly.
Fixes #476

Thanks for this! I think we can make it a bit cleaner by adding an Error type to the Direction trait and then doing the unwrap for compression in the compress function. I've submitted a PR to your branch, what do you think?
(I wish this was a mailing list, then I would just send the diff right here in this message).

Great, thanks! I merged your changes in to mine :D.
Conrad
Sent via Superhuman @.***>
On Wed, Dec 14, 2022 at 4:15 AM, alexjg @.***> wrote:

Thanks for this! I think we can make it a bit cleaner by adding an Error
type to the Direction trait and then doing the unwrap for compression in
the compress function. I've submitted a PR to your branch, what do you
think?
(I wish this was a mailing list, then I would just send the diff right
here in this message).
—
Reply to this email directly, view it on GitHub
https://github.com/automerge/automerge-rs/pull/477#issuecomment-1351006578,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAXAQA7FSAOXNOLVHUQGSLWNGT6HANCNFSM6AAAAAAS6AE23M
.
You are receiving this because you authored the thread.Message ID:
@.***>


Investigate if possible to exclude log when restoring

No: the log is an essential part of the database and is used during RESTORE process (redo/undo phases) to ensure consistency.


Cannot use keychords

I am trying to use keychords in swhkd. I set up keychords like this:
super  + g; b
brave-browser
When I try to launch swhkd with pkexec swhkd -c ~/.config/hypr/swhkdrc, I get the following error:
unknown symbol at line 17.
This is where the above keychord starts. I am assuming this has something to do with the ';' . Is there another way to setup keychords with swhkd? I used the above syntax to setup keychords with sxhkd.

Hi we use something called key modes. Read man page for more details.


Add Sliding Windows in _g2p_v2 to separate the word segmentation results into Chinese and English segments

In function _g2p_v2(in chinese_mix.cpp)，in order to add pre_merge_for_modify (to regulate the Chinese segmentation results), it is necessary to add a sliding window after the Jieba word segmentation. The sliding window will determine the left and right boundaries of Chinese or English word segmentations in the Jieba result's vector, the Chinese part will serve as the input for pre_merge_for_modify.

fixed in https://github.com/apinge/MeloTTS.cpp/commit/134d3d172a3af418fbd578172405faa8a34f712b


BXMSPROD-512 Create jenkins job to run the PNC build config

Merge after BXMSPROD-511

Jenkins retest this please


Can it sort a JS object that reference to other variable?

const x = ''
const o = {
  path: [],
  component: x,
  name: 'test'
}

Got an error message from VSCode Invalid JSON. JSON5: invalid character 'x' at 3:14

Hi @dews ,
This extension cannot parse the reference values. Underneath it tries to parse the Json object from the selected string and would throw an error if the selected text is not a valid JSON.


ARROW-18256: [C++][Windows] Use IMPORTED_IMPLIB for external shared Thrift

@evetion Does this work with your use case?

@github-actions crossbow submit -g cpp

+1


disable automount SA token only on tests with min istio revisions >= 1.16

Testing multiple istio versions involves older istio versions which doesn't support sidecars with disable automount SA token. This was enabled form 1.16 onwards.
Please provide a description of this PR:

In response to a cherrypick label: new pull request created: #44491

In response to a cherrypick label: new pull request created: #44492

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio/istio#release-1.16 from head istio-testing:cherry-pick-44449-to-release-1.16: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-44449-to-release-1.16."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to a cherrypick label: new pull request could not be created: failed to create pull request against istio/istio#release-1.17 from head istio-testing:cherry-pick-44449-to-release-1.17: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-44449-to-release-1.17."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

/cherry-pick release-1.18

@jacob-delgado: new pull request created: #44533

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Add new action 'change jira issue status'

This action is widely used in many projects in which I participate. I think that it will be useful to other fastlane users. It allows you to automate a flexible methodology using continuous delivery.

Hey @CognitiveDisson,
Thanks for your fastlane pull request, this looks great!
We recently introduced the new fastlane plugin system that allows you to distribute and maintain your own plugins, and still be exposed to fastlane users.
We'd love this new action to be a fastlane plugin so people who want to use it, can easily add it to their project.
Please let us know how the integration goes, and if you need any help getting up and running 🚀


Manage project with poetry

This PR was initially started to resolve #111 by pinning pillow but seeing the work related to #49 done by @christopherwoodall in #108 I add to the discussion by adding dependency and package build management  with poetry.
You can install the riffusion package with pip install . and the script interfaces will be riffusion and riffusion-server respectively

Additionally this PR updates the code to support latest version of streamlit

I really like the use of poetry for managing the build/dev environment and keeping the requirements as a dependency list.

Great. Thanks 🙏
I can add a github action to publish to pypi next week

@hmartiro @SethForsgren @christopherwoodall can you have a look at this once you have time?
I've added the action to publish to pypi and it looks like riffusion is still not squated there

@piiq if the name is available I would try to grab it as fast as possible. You can always share the repo key with the developers if they decide to publish it.

Hey @piiq , thank you for the work here! I don't have experience with poetry, but I'm concerned that requirements.txt pins all package versions. Most people install with -r requirements.txt and this isn't going to play nice with any other packages in that case is it? Would like help understanding that

Hey @piiq , thank you for the work here! I don't have experience with poetry, but I'm concerned that requirements.txt pins all package versions. Most people install with -r requirements.txt and this isn't going to play nice with any other packages in that case is it? Would like help understanding that

Warning: wall of text 😂😅
poetry is a tool that can be used to solve the dependency tree and generate the requirements.txt files.
Poetry solves all the deps (including the dependencies of the dependencies of the dependencies) in a way they all play nicely with each other. Poetry uses the top level deps specified in pyproject.toml and generates a poetry.lock artifact with the info on the package version range.
After poetry is done with it's job it can use it and the lock file to produce the requirements.txt files so that the average user doesn't need to know anything about poetry and use the lib the usual way (pip install ...)
So what we're seeing here are auto-generated requirements files that are produced by these 2 commands:
poetry export -f requirements.txt --without-hashes --output requirements.txt
poetry export -f requirements.txt --only dev --without-hashes --output requirements-dev.txt

That's "poetry export dependencies information in a 'requirements.txt format' without hashes into a requirements.txt file"
When you install the dependencies with -r requirements.txt everything should works apart from the fact that you won't have riffusion available for import in your environment namespace and the shortcuts like riffusion-cli and riffusion-server will not work.
To install the package in full you can pip install riffusion and install it from pypi or pip install . from the source code folder.
Now if we consider using riffusion in environments with other dependencies - this would very much depend on the other dependencies. pip itself has some dependency tree resolution mechanism although it's more loose than what we can get with poetry or requirements.txt files so it does the job, but may produce unnecessary and "false positive" warning messages. But it still works.
If you have a specific use case in mind of riffusion not playing nicely with a specific package that's not in the dependency tree - let me know and we'll take a look how we can address that.
If you have any other questions - don't hesitate to ask

And mypy gha check is expected to pass now


Click @username in chat to highlight

Would be a neat moderation feature if it was possible to click someones @username in chat to highlight the spoken user in chat. This would help in bigger chats in case a mod misses something. Chatters often reacts very quickly to example racism with "cmonBruh @username" or the likes of it.

Added comment to #228 so this is not a duplicate.


Try to fix readthedocsbuild

could also just switch to using the conda env for the docs.  There, when you install the graphviz python package, you get the graphviz binaries as well, and pandoc is included in the default anaconda channel even (probably also in conda-forge)

Installing graphviz fixed the build, the diagrams show up again now. I gues sthat readthedocs changed from an image where it was pre-installed to an image not coming with it

See https://ctapipe--2365.org.readthedocs.build/en/2365/ctapipe_api/calib/index_camera.html#class-inheritance-diagram


Postgres: Don't fail if hstore is not installed

Codecov Report

Merging #26 into master will decrease coverage by 0.23%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   86.16%   85.93%   -0.24%
==========================================
  Files          33       33
  Lines        1113     1116       +3
==========================================
  Hits          959      959
- Misses        154      157       +3

Impacted Files
Coverage Δ

populous/backends/postgres.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598201d...efcb3f8. Read the comment docs.


Better ways to clean-up processes on Linux

https://stackoverflow.com/questions/284325/how-to-make-child-process-die-after-parent-exits/36945270#36945270
http://pythonhosted.org/python-prctl/

Can't we just use an atexit hook to do this? Don't see why another linux specific dependency would be necessary.

atexit only get executed when the process exits in a clean way.

Wouldn't signals be a more precise cross-platform way of handling it though?

How?

https://stackoverflow.com/questions/40866576/run-atexit-when-python-process-is-killed

Cannot catch sigkill.

Can that library catch it though? I was under the impression that NOTHING can catch SIGKILL. That's the point of SIGKILL isn't it?

NVM, I understand it's a hook on the child. Still this would only solve the issue on Linux. There is a way of dealing with this on Windows, but it's far more complicated. The only reliable way would be to pole the parent from the subprocesses. The signal solution would solve pretty much ever other case though with the exception of SIGKILL and without the need for a Linux specific non-UNIX call for an edge case. Thoughts?

If prctl solves the problem for Linux I'll use it. You're welcomed to add better support for windows if you like.

Another really clever method is the following:

This assumes the child is still able to run code when parent dies, which is not necessarily true. The child can be stuck in IO.

For example when parent dies and a child is waiting data from the parent.

Wouldn't the child receive an EOF? All file descriptors are closed when a process is terminated by any means right? Therefore the child would receive an EOF.

It could be waiting data from a queue, from a named pipe, from shared memory, etc.


Fix bad static_cast causing crashes

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description

it used to read garbage from Channel data, it doesn't anymore

Testing this now, will have it merged in around midnight or tomorrow if everything looks good


Font: print square for unknown characters

done, unicode character 0xfffd is used to represent glyph-not-found characters.


Fix docker uuid

Security fix - do not allow a docker user access ghrunner resources

@alexbaden could you please take a look as well; @Garra1980 asked CI patches to be reviewed by you or Ilya


setApiKey is not a function using imports

Issue Summary
When I try to import the mail service, I have the following error:

mail_1.MailService.setApiKey is not a function

Example code
import {MailService} from '@sendgrid/mail';
MailService.setApiKey('myKey');

Technical details:

sendgrid-nodejs Version: master (latest commit: [commit number])
"@sendgrid/mail": "^6.3.1" in package.json
ts-node v7.0.1, node v11.0.0, typescript v3.1.1

Any help or pointers would be great. Trying to use require() as documented gave me the error and new MailService() would not work either. Thanks!

I replaced
import {MailService} from '@sendgrid/mail';
with
import MailService from '@sendgrid/mail';
and everything worked as expected.

The typescript types are not kept up to date and it uses module.exports so to use the types:
"@sendgrid/mail": "^6.4.0",
import MailService from "@sendgrid/mail/src/mail";

I've tried each of these and still having trouble.

node v10.24.1
@sendgrid/mail ^7.4.5

import { setApiKey, send } from '@sendgrid/mail';  await setApiKey(process.env.SEND_GRID_API_KEY);       const mailOptions = {         from: "Delores Digital"${process.env.EMAIL_USER},         to: to,         subject: 'Welcome to Delores Digital',         html: Welcome to Delores Digital
${otp} is your otp for Login.Please Enter the OTP to proceed.,       };       await send(mailOptions);
I have the same issue but this code works for me


Assertion of throw()

Hello.
Do you think functionality like pytest.rises would be useful for crispy?
The idea is that the test case expects a raise of exception and if the specified exception was raised, the assertion returns True. In the case of GML, this could be throw() with certain parameters.
Already now I can implement such functionality with crispy, but it turns out to be quite verbose:
function never_enough(number) {
	enum errors
	{
		toobig,
		toosmall,
	}

	if number > 42
		{
		throw(errors.toobig)
		}
		else
		{
		throw(errors.toosmall)
		}
}

runner = new TestRunner("runner");
suite = new TestSuite("suite");
runner.addTestSuite(suite);

test_too_small = new TestCase("test_too_small", function() {
	try
	{
		never_enough(34)
	}
	catch(_err)
	{
		assertEqual(_err, errors.toosmall)
	}
});
suite.addTestCase(test_too_small);

test_too_big = new TestCase("test_too_big", function() {
	try
	{
		never_enough(43)
	}
	catch(_err)
	{
		assertEqual(_err, errors.toobig)
	}
});
suite.addTestCase(test_too_big);

runner.run();

Thanks for your attention and your project.

Hello 👋
Thank you for submitting your feature request and your interest in the library!
Passing the enums through throw() works in the example, but would lead to having to write error messages in a specific way that would not be readily apparent to the end user. Outside of testing, having the method throw 0 or 1 wouldn't convey what the error was.
I think this would be a nice feature to add. I'm not exactly sure what the best way would be to implement it at the moment. A couple of my goals would be to keep the user from having to write out a verbose enum or the try/catch statement. I'll have to look into it further.

@treylav my apologies for not getting to this sooner. Thank you for the feature suggestion.
Added assertRaises and assertRaiseErrorValue.


xref object stream incorrectly inserted in place of object

For an input document where an xref object stream's number has been reused by a later incremental update (intentionally or not), qpdf will output the xref in place of the object.
One way that this might actually happen: if you start with a PDF with an object stream xref that incorrectly does not include its own object number and then later do an incremental update to append some content (e.g. a text stamp), you might miss the xref's object number when figuring out the next available object number to use. Your output is a PDF + an appended stamp where the previous xref has the same object number as your first stamp object (a font, for example). This PDF, while malformed, is still viewable in acrobat and other readers. If you pass it through qpdf, the xref object gets written in place of the intended object which can cause the output to no longer be viewable (e.g. if it's a font, at least in my version of acrobat - 9.5.5 on linux...).
The incremental update spec doesn't mention xref updates, and it seems like that isn't really meant to be done, but I do think it makes sense to always use the latest version of an object.
I've attached some sample data: clean.pdf is the original (malformed) PDF, clean-stamped.pdf is an example stamped/incrementally updated version (with an object number collision between the xref and a font), and clean-stamped-qpdf.pdf is the resulting output (with an xref object in place of that font).
clean.pdf
clean-stamped.pdf
clean-stamped-qpdf.pdf

Thanks for the data and the clear explanation. This may require some special case code in qpdf, but I don't imagine it will be very hard to fix.

I am not convinced that the explanation of the problem is accurate.
It seems to me that the problem is that the XRef stream is object 25 0 according to the xref table, but is labeled (incorrectly) as 26 0 obj. This triggers an attempt to reconstruct the cross reference table, resulting in the XRef stream replacing the the font as object 26 0.
Would it make sense to check that xref table entry 26 points to a valid object 26 and if so relabel the xref stream as object 25 before deciding to reconstruct the cross reference table?

Sure, there may be some other mechanism at play here! I can try and generate a PDF where the xref table is really missing (rather than being incorrectly labeled as I've done in the example) and see what happens.

XRef / object streams are probably a bit of a red herring
What appears to be happening is that there are duplicate objects 26 0, one of which is really object 25 0. When qpdf attempts to access 25 0 it recognizes the error and attempts to correct the xref table, when in this case the proper way to correct this would be
to correctly label object 25 0 as 25 0.
This suggests to me the following heuristic when encountering an unexpected objgen (say for example 13 0) when attempting to load an object by offset:
Try to load object 13 0. If this is successful (i.e. if the xref table entry for 13 0 to a different valid object 13 0) than warn about the unexpected objgen but load the object anyway. Otherwise, repair the xref table, i.e. do what we are currently doing.

If you agree that this is the right approach I can do a PR.

My impulse is to say that this is not a safe change.
I'd say to check how other viewers handle this including something poppler-based, evince, okular, ghostscript with old and new PDF interpreter, Adobe Reader if you have a copy, chrome, firefox. It may be possible to test their behavior with this case by creating a file where the object that is wrong in this way is something that will change the appearance in an obvious way like replacing one standard font with another. If it seems like other viewers are recovering in this fashion, especially Adobe reader, then it might be safe. If Adobe reader doesn't do this, then qpdf shouldn't do it.
It's likely that a heuristic like this will change the way a lot of files recover. Changing the logic around file recovery would be extremely high risk as a lot of people have come to depend on qpdf being able to recover certain files. A very common case of incorrect xref offsets is when people generate PDF templates with text, then fill in the text without adjusting offsets and lengths. I've seen this more times than I can count. If the difference in lengths happens to cause some objects to be offset just the right amount, this recovery would render those previously usable files useless. The PDF spec (earlier, pre-ISO versions) recommend recovery by looking for object numbers at the beginning of the line the way qpdf does it, so deviating from this is likely to cause qpdf to recover differently from other viewers, which could be hazardous.

Taken a step back, I am not entirely clear whether this is a / the real issue or an artifact of the (possibly) hand-crafted example of the issue that @ztravis  is experiencing.
If this is not the real / a real-life problem then I am not to keen to spend much time on it.

This is a real issue we've encountered - I can't share the specific PDFs involved, but I've generated some additional test data that mimics more closely the original xref data for at least one "type" of broken input which appear to have been generated by iText 5.4.5. In these, named "broken-*.pdf", the xref stream includes its own object number but as a free object. I've also generated a set of PDFs where the original stream was well formed but the stamping logic used the same object number as the previous xref (with/without incrementing the generation number). The same issue occurs in all of these cases.
That being said, I admit this is a pretty rare issue and requires a few steps to trigger and something to be wrong along the way (either a malformed starting PDF or buggy stamping logic). I also appreciate that this loading/cleaning code is sensitive and changes can have unintended effects elsewhere! If there's a way to fix this, or at least to warn when it happens, that would be great, but I understand that you can't deal with every possible weird thing in a PDF!
broken.pdf
broken-stamped.pdf
broken-stamped-qpdf.pdf

It is normal and expected for the xref stream to be a numbered object that is not otherwise referenced. If something is reusing the object ID, that's a mistake. The xref stream's offset is supposed to be in the xref stream and counted in the /Size field in the trailer dictionary. What I see in broken.pdf is that the xref stream is object 25 and is accounted for by /Size being 26 in the trailer dictionary. However object 25 does not actually appear in the xref stream, which is wrong. I think this matches your description. However in this case, qpdf doesn't seem to have any issues with the file, so I guess I'm not seeing the problem you're seeing.
I'll study it more closely.
One thing that might help would be if you can provide the output of qpdf --json-output --json-stream-data=none out.json (from qpdf 11) on one of your broken files. You can inspect out.json before sending it. There may be metadata strings, like outlines, but there will be no stream data. You can redact the strings. In combination with this, you could provide the output of qpdf --show-xref infile.pdf.
Can we ignore the original files you posted in favor of the new ones? The difference appears to be that the original file (clean.pdf) has the xref stream numbered as 26 whereas broken.pdf has it numbered as 25. Was that a mistake in the hand-creation of an example?

In broken.pdf, the xref stream is object 25; there are 26 entries in the xref stream, but the last one (for object number 25) is a "free object" entry - the actual object reference does not appear in the xref stream. There's no issue running that PDF through qpdf, but the version "broken-stamped.pdf" has an incremental update that uses that "free" object number 25 for a font entry, and that stamped PDF (which has two object 25s - the xref, which never appears in an xref, and the font) is what ends up malformed when going through qpdf.
The two sets of files are very similar and exhibit the same issue. The first set was just simpler for me to generate, but in both cases the xref stream shares the same object number as a later font resource, and the xref stream object offset never appears in any xref table. That being said, the first example does have the additional issue that the original xref stream includes a reference to an object "25 0" that does not match the actual object found there, so feel free to ignore that set of files if that complicates the analysis.
I think an even simpler example would be a normal PDF with a correct xref stream that then had an incremental update that reused the object number and generation of the xref stream; based on the general idea of an incremental update the new object should take precedence over the xref, but I agree that reusing an xref object like this is a bad idea, and maybe not worth the effort to fix... In this case there is no malformed xref, just a reused object number.
Here is such an example:
simple-stamp.pdf

The key problem with broken-stamped.pdf seems to be that there are two objects 25 0, the font and the xref stream. When doing a qpdf --show-xref qpdf correctly shows the font as object 25 0, but when rewriting the file it writes out the xref stream. Manually changing the  objgen of the xref stream to say 39 0 fixes the problem and allows qpdf to rewrite the file correctly.
None of the viewers I tried (including Acrobat) had a problem displaying the stamp correctly despite the errors in the pdf file. (This is probably not surprising given that they wouldn't have any reason to try access the xref stream by objgen.)
Occular allowed me to edit the file. It maintained the xref streams for all incremental updates but changed the objgen for the first xref stream from 25 0 to the invalid 31 0. qpdf was able to rewrite the output correctly.

I have done my analysis. The actual issue is that, when qpdf reads the xref stream, which it does early, it gets stored in the object cache by number even though it wasn't read through the xref table/stream. Then the reused object gets loaded into the xref table correctly, but since it's already in the cache, that doesn't have any effect. I believe the correct fix (a one-liner) is to simply not insert the object in the cache when we indicate to readObjectAtOffset that we don't care and are not checking the object ID. As already explained in the comments, this happens for xref streams and linearization hint tables, which I believe would be subject to the same bug. I will push up a fix momentarily.

My one-line fix isn't quite right, but that is what the problem is.

I've summarized the issue in more detail in a comment in the code, but the basic issue is this. When a file is updated by append, an object's xref entry would be first read in the later xref, then read again the earlier one, but the earlier one would be ignored because we want the later one to take precedence. For example:

appended xref says object 10 is at byte offset 500; store that in the xref table
original xref says object 10 is at byte offset 200; ignore that because object 10 is already in the xref table
when resolving object 10, we go to offset 500

What's happening here is (using my made up numbers)

appended xref says object 10 is at byte offset 500; store that in the xref table
object 10 is the old xref stream, so it gets read and cached by its offset in /Prev, not through the xfef tale
original xref says object 10 is at byte offset 200; ignore that because object 10 is already in the xref table
when resolving object 10, although the xref table correctly says 500, we already have the object in cache, so the cached object prevails.

My "fix" is, for the special case of xref streams, we do not add the object to the object cache if the object is already in the xref table.
I believe the same bug applies to linearization hint streams, but there is other code that relies on information added to the cache for the linearization hint stream, so fixing it for that case would be quite a bit more difficult. This is a very obscure problem, and I think it would be even more obscure to have this bug with the linearization hint stream. The xref stream may often be at the end of the file and be the highest numbered object, so writers may reuse it. It's also more likely to be left out of the xref table. However linearization hint streams are floating around in the middle, and writing linearized files is much harder and therefore less likely to be done by junky writers that don't follow the spec. As such, I think the likelihood of encountering this bug with reused linearization hint streams is very low, and it's not worth reworking the existing code to make it possible to fix it for that case.

My fix is in #819

I hand-coded a simple PDF that has this problem. It's in the test suite. I used a font again for override but the font actually matters in the file, so the file displays differently when processed with qpdf before and after the fix.


Wikipedia links are broken for some reason

Paste this in the chat room:
http://en.wikipedia.org/wiki/Metro_Design_Language
and it'll come out like this:
Language" title="http://en.wikipedia.org/wiki/MetroDesignLanguage">http://en.wikipedia.org/wiki/MetroDesign_Language
It's the markdown logic in js.

I removed the markdown support for now


Obtain shaded jar for latest build?

Hi mmlspark team! I'm currently trying to run mmlspark (specifically the mmlspark.exlainers subpackage) on a Qubole spark cluster. The Qubole cluster is finicky in that I seem unable to provide a --packages argument for installing mmlspark, and instead must rely on passing a .jar file. From local testing, I found that the latest snapshot  appears to have the explainers subpackage: com.microsoft.ml.spark:mmlspark:1.0.0-rc3-179-327be83c-SNAPSHOT
Is there any way to obtain a .jar file with mmlspark and all dependencies, which if provided to the cluster would mimic the behavior of passing the the above maven coordinates as the --packages arg? I've tried downloading, unpacking, and repacking all jars listed during pyspark initialization into a single jar then supplying that to my cluster, but received this error each time:
>>> from mmlspark.explainers import *
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'mmlspark.explainers'

I've also tried downloading all the individual jar files into the pyspark working directory and supplying all of them in comma-separated format as the --jars argument, which yields the same ModuleNotFoundError. I don't think it's an environment issue, as supplying the the maven coords above as the --packages argument results in the correct behavior.
Would appreciate any/all help!

Please feel free to re-open if needed


[Bug report] External Link in sidebar is broken.

Description
SideBar value:
{
  '/': [
    { text: '网站首页', link: 'https://www.bennyhuo.com', children: [] },
    '',
    ...
  ]
}

And the generated link is something like: 'https://www.bennyhuo.com/book/https://www.bennyhuo.com'.
Reproduction
https://www.bennyhuo.com/book/
Used Package Manager
npm
System Info
System:
    OS: macOS 13.0
    CPU: (8) arm64 Apple M1
    Memory: 79.88 MB / 8.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.1 - ~/.nvm/versions/node/v16.15.1/bin/node
    Yarn: Not Found
    npm: 8.11.0 - ~/.nvm/versions/node/v16.15.1/bin/npm
  Utilities:
    Git: 2.37.1 - /usr/bin/git
  Browsers:
    Chrome: Not Found
    Edge: Not Found
    Firefox: Not Found
    Safari: 16.1
  npmPackages:
    @vuepress/bundler-vite:  2.0.0-beta.61
    @vuepress/bundler-webpack: Not Found
    @vuepress/cli:  2.0.0-beta.61
    @vuepress/client:  2.0.0-beta.61
    @vuepress/core:  2.0.0-beta.61
    @vuepress/markdown:  2.0.0-beta.61
    @vuepress/plugin-active-header-links:  2.0.0-beta.61
    @vuepress/plugin-back-to-top:  2.0.0-beta.61
    @vuepress/plugin-container:  2.0.0-beta.61
    @vuepress/plugin-docsearch: Not Found
    @vuepress/plugin-external-link-icon:  2.0.0-beta.61
    @vuepress/plugin-git:  2.0.0-beta.61
    @vuepress/plugin-google-analytics: Not Found
    @vuepress/plugin-medium-zoom:  2.0.0-beta.61
    @vuepress/plugin-nprogress:  2.0.0-beta.61
    @vuepress/plugin-palette:  2.0.0-beta.61
    @vuepress/plugin-prismjs:  2.0.0-beta.61
    @vuepress/plugin-pwa: Not Found
    @vuepress/plugin-pwa-popup: Not Found
    @vuepress/plugin-register-components: Not Found
    @vuepress/plugin-search: Not Found
    @vuepress/plugin-shiki: Not Found
    @vuepress/plugin-theme-data:  2.0.0-beta.61
    @vuepress/plugin-toc: Not Found
    @vuepress/shared:  2.0.0-beta.61
    @vuepress/theme-default:  2.0.0-beta.61
    @vuepress/utils:  2.0.0-beta.61
    vue:  3.2.47
    vue-loader: Not Found
    vue-router:  4.1.6
    vuepress: 2.0.0-beta.61 => 2.0.0-beta.61
    vuepress-vite:  2.0.0-beta.61
    vuepress-webpack: Not Found

You are not using the default theme


How to load a dataset with the output a tokenizer?

I planned to use datatrove to apply my tokenizer so that data is ready to use with nanotron.
I am using DocumentTokenizer[Merger] which produces *.ds and *ds.index binary files, although, from what I understood, nanotron is expecting datasets (with "input_ids" keys).
I see that things like ParquetWriter cannot be piped after DocumentTokenizer.
Am I missing a piece?
Are there some helpers to convert ds files into parquet files (or something loadable with datasets) for a given context size?

Hi, I pinged the nanotron team internally and they are working on moving support of datatrove's .ds files to the public repo :)

Following up on this:

Are there some helpers to convert ds files into parquet files (or something loadable with datasets) for a given context size

I was wondering the same thing. I really like datatrove, but as of now I cannot use the tokenization pipeline, since there is no way to load the data :D

Hi! Two things:

you can always convert the text data to any format by using a writer. For instance, you can convert it to parquet using a ParquetWriter. This will convert the data with the text and not with the actual tokens, however
I have just added a torch Dataset that can load tokens from a dataset tokenized by datatrove into .ds files here. Let me know if you would require some changes to this class for it to work with your setup

Nanotron also has support for a custom dataloader now, where you can plug in datatrove's Dataset directly: https://github.com/huggingface/nanotron/pull/162
Closing the issue

Awesome, thanks a lot @guipenedo


Improve documentation around intersection of partitions + materializations + incremental strategies on BigQuery

Replacing partition(s) is a good strategy to partialy update time-growing BigQuery table idempotently.
While it is supported in dbt, its behavior is hard to understand, and actually there seem to be some bugs.

Partitioning type
dbt configuration

Ingestion time partitioning
materialization='table' and specifies partitions

Column based partitioning
materialization='incremental', incremental_strategy='insert_overwrite'

Problems

Partial update (i.e.: non full replace) of ingestion-time partitioned table is achieved using materialization='table' unlike column partitioned table
Cannot specify time granularity for ingestion-time partitioned table
With incremental_strategy='insert_overwrite', specifying both partition_by and partitions has two bugs: 1. it raises type error, 2: it trys to insert data out of specified partition
With some combination of options, specified value is ignored, but undocumented

materialization='table' and specify partitions → partition_by is ignored
incremental_strategy='insert_overwrite' → unique_key is ignored
incremental_strategy='merge' → partitions is ignored

Suggested solutions

Allow partition_by = {'field': '_PARTITIONTIME'} to make ingestion time partitioned table
Make partitions option to work only with 'insert_overwrite'-ing ingestion time partitioned table

This change makes materialization='table' behave only full replace, so it going to be a breaking change

Enhance document so that user can understand the behavior based on the combination of options

Note:

partition_by option should be supported on materialization='table' (full replace) or incremental_strategy='merge' too

In the meantime, I'm going to transfer this issue to the docs.getdbt.com repo, since that will be the place to contribute improvements to documentation.

Oh I was lost in woods of dbt-labs/dbt like "where's my issue gone?" haha!

we'd actually like to rip it out in its entirety (dbt-labs/dbt#2332)

In lieu of ingestion-time partitioning, we believe everyone should be using column-based partitioning.

I'm not sure I understand the implications of a user specifying partition_by = {'field': '_PARTITIONTIME'}, if it's not actually an ingestion-partitioned table.

I understand it's good idea to encourage users to use column-based partitioning instead of "ingestion-time" partitioning so that they can have better/explicit controlling over how a table is partitioned.
However, it's sill quite popular to use ingestion-time partitioning in my organization wide, and they are actually  ingestion-time partitioned. The reason we explicitly specify partitions are

It's a good way to make jobs idempotent. Running query with writeDisposition: WRITE_TRUNCATE, destiantionTable: foo.bar.baz$20210823 replaces the partition (here, the date is the actual date it runs), unlike running with writeDisposition: WRITE_APPEND, destiantionTable: foo.bar.baz.
It's necessary to run on delayed recovery for incidents like a job failure. In this case, the date specified will be the date the job is planned to run, not the actual date it runs, so the exception for "ingestion time".

Of course any use case of ingestion-time partitioning can be covered by column-based partitioning, but migration won't happen unless there's strong motivation. So I'd be little happier if ingestion-time partitioning will be stayed as a first-class citizen in dbt (note that we've just started using dbt in a experimental project, so it won't bother us even if the change happens).

There may be a few buggy edge cases with incremental_strategy: insert_overwrite + specific values of partitions + partition_by. If you could open those bug reports as new issues, I'd really appreciate it!

Here: https://github.com/dbt-labs/dbt/issues/3788

@tmshn It appears this issue has been addressed so I am going t close it out. Feel free to reopen if I am wrong!


Sugestion for to improve text_button.dart

On constructor of the widget TextButton, will be best if to have anothers parameters.
Something like:

 const TextButton({
    Key? key,
    required String? text, // New Parameter
    required VoidCallback? onPressed,
    TextStyle textStyle, // New Parameter
    VoidCallback? onLongPress,
    ButtonStyle? style,
    FocusNode? focusNode,
    bool autofocus = false,
    Clip clipBehavior = Clip.none,
    required Widget child,
  }) : super(
    key: key,
    text:text // New Parameter
    onPressed: onPressed,
    onLongPress: onLongPress,
    textStyle:textStyle // New Parameter
    style: style,
    focusNode: focusNode,
    autofocus: autofocus,
    clipBehavior: clipBehavior,
    child: child,
  )
}

I know that I can to put this parameters on Widget Text, and call by it on child of TextButton... but such as name is TextButton, will best if the  dont is need to call Text Widget

I clearly understand what you are proposing but, this is agains Flutter's styling guidelines where most of the widgets are expected to receive a generic widget rather than a specific data type.
You can always create a custom widget that wraps the TextButton.
Thank you


Complete project scope document

Project Scope Document
The recommended outline for the project scope document is as follows:
Cover Page with Project Title and Group Members
Project Summary
Project Motivation
Project Goals
Use Cases
Methodology
What are your inputs, outputs and intermediate processing steps?
How will you tackle this problem? What is your proposed solution?
System Design – include block diagrams, subsystems and components
Demonstration Sequences (from the simplest to the most complex)
Final Demonstration
Intermediate Demonstration (a subset of the Final Demo)
Development Milestones
What will be accomplished by the Intermediate Demo and the Final Demo?
Make this schedule fine-grained to guide your own project development process.
Work Partitioning
How will you partition the work among team-members?
Conclusions
References
Include a few relevant pieces of work available in the literature – ideally, these references are cited in the rest of the document.
Submission:   Please submit your project scope document by email to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Sorry forgot to share: https://docs.google.com/document/d/1myITlUZhzs5H4FrAvcsyeSvQtAiFV63-muI_6SN2br0/edit?usp=sharing


New component suggestion -> InsetHeader

Hi @siriwatknp
I hope you are well. I was just thinking that an InsetHeader component could be useful for the case where we need to have search filters in an app further down the normal header and that either remains fixed or relative.
Please let me know what you think of the idea.
Kind regards,
@aress31

Agree, I have seen something like that in gitbook. will try to make it live.


No dependency on angular in bower.json

In bower.json file there is no dependencies section and angular-paging is not dependent on angular. But it is.
In my case I use wiredep plugin for gulp which sorts vendor js files based on their dependencies when concatenating and minifying them. Because it thinks that angular-paging is not dependent on angular it pasts it before angular in concatenated vendor.js file. And it doesn't work of course. It must be after angular because it uses angular for defining it's module.
So we need to add this:
      "dependencies": {
        "angular": "1.3+"
      }

to the bower.json file. (I don't know which angular version angular-paging is really need)

Sounds good! I'll get this added into the next release probably targeting either the 1.3 or 1.2 version of angular.

Ok, thanks! Now I'm using overrides section in my bower file for this. But it will be good if angular-paging will declare it's dependencies out of the box. :+1:

Closed with version 2.2.0 release


Ipv6 vxlan

note that for outer ipv6 vxlan, need pmd fix in
https://github.com/elibritstein/dpdk.org/tree/ipv6-zero-udp-csum

Can one of the admins verify this patch?

the pmd patch on top of 19.05 is at:
http://patches.dpdk.org/patch/56072/
the pmd patch on top of master-net-mlx is at:
http://patches.dpdk.org/patch/56081/

The commit message does not explain what was the original bug and how this patch fixes it.
Need to update it.

if you refer to the one in dpdk-pmd, the commit message was clear enough to dpdk reviewers, and it is already applied to master-net-mlx branch.


[feature request][discussion] Allow downloading examples and tutorials directly from Pyro documentation

Hi Pyro Devs!
While instructing new users on how to download and run the examples/tutorials, it seems to me that there is no simple way to instruct users to download just these folders directly.
To improve usability I would suggest the following:

Create separate example and tutorial zip files under releases.
Link those zip files from within the relevant example documentation.

What do you think?
Thank you in advance!

Why not simply shallow clone?
git clone --depth 1 git@github.com:uber/pyro.git

Thanks for the tip!
Would it be OK if clarified the README to also say that the source code of Pyro is required to run the examples? (there is probably no need for separate folders)

Maybe I should clarify, now the README could be read like you could just run the examples by installing the [extras] package. I would just like to clarify the phrasing a bit, so that it is more clear that you also need to get the examples folder to run things.

Sure, go ahead and clarify the README!


add_signature method not working

Hello, I have a ts code that works fine when I try to do: transaction.addSignature(notary, bs58.decode(sigStr));
On python on the other hand, it's returning:
Traceback (most recent call last):
  File "c:\Users\Downloads\Solana\Solana\test.py", line 260, in <module>
    asyncio.run(test())
  File "C:\Users\AppData\Local\Programs\Python\Python39\lib\asyncio\runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "C:\Users\AppData\Local\Programs\Python\Python39\lib\asyncio\base_events.py", line 642, in run_until_complete
    return future.result()
  File "c:\Users\Downloads\Solana\Solana\me_launchpad.py", line 254, in test
    tx_instructions.add_signature(pubkey=PublicKey(infos.notary), signature=base58.b58decode(str(sig_str)))
  File "C:\Users\AppData\Local\Programs\Python\Python39\lib\site-packages\solana\transaction.py", line 271, in add_signature
    raise ValueError("unknown signer: ", str(pubkey))
ValueError: ('unknown signer: ', 'A8b43w4efa2G6T4pQR9Hif8nj5A3ow2bnx6dAzYJBffP')

I am 99% sure that the my python code and the ts codes are 1:1 and this is the last step needed for my transaction.
I previously add the infos.notary as a signer through anchorpy like this:
remAccounts.append(AccountMeta(pubkey=PublicKey(infos.notary), is_signer=True, is_writable=False))
Yet when I try to add a signature it gives that first error.
Could you please help me out?
I'm currently using the latest version of both, solanapy and anchorpy. Python version is 3.9.10

#182 Error was due to this, could you please take a look?


Failed at the<EMAIL_ADDRESS>postinstall script.

Install failed with the newest puppeteer 19.3.0

The problem does not come directly from this package.


Deprecation of current Browser/OS IDs for string based ones.

Change the current Browser and OS IDs from a signed integer to string. This is needed because the Analytics data is actually an unsigned int for these values which causes some of the values imported to appear as negative.

@clubycoder  - Can you review and approve this PR


Add documentation note about JSON.parse not being spec compliant

Part of #66114
Fixes #40394
List all known differences between Godot's JSON parser and the specs, as taken from #66114.
The crashes are not listed here as they are fixed in #66117. Invalid escape sequences are fixed in #66170.

Fair point, this makes it more convenient to list all spec-breaking differences as well.
I left out the invalid escape sequences from the docs, since I am planning on fixing them. I also left out two very minor parsing differences (null byte at end, and form feed as whitespace) as I don't think they'll cause any problems in real-world applications.

Thanks!


Show shared networks in the OpenStack provisioning dialog

Show shared networks in the OpenStack provisioning dialog.
Shared networks were lost during refactoring, adding specs
to make sure shared private networks show under all tenants.
Steps for Testing/QA [Optional]
Create shared network in the OpenStack, that network should be available when choosing any tenant.
Public networks should not be affected, only connection through router and right tenant association to floating IP is checked.
Fixes:
http://talk.manageiq.org/t/cannot-select-shared-openstacck-networks-for-instance-provisioning/1753

@Ladas Please label for euwe if required

@miq-bot add_label euwe/yes

Euwe Backport details:
$ git log
commit 75d3f0ba8cc0cb951e7d54f59dc9d3e187660651
Author: Brandon Dunne<EMAIL_ADDRESS>Date:   Tue Oct 4 18:13:24 2016 -0400

    Merge pull request #11653 from Ladas/openstack_provisioning_show_shared_private_networks

    Show shared networks in the OpenStack provisioning dialog
    (cherry picked from commit eefb054637381774cafb32a881a34e901b7e2b8c)

@Ladas
Back to 2016
G have lost shared networks again.
http://talk.manageiq.org/t/cannot-select-shared-openstacck-networks-for-instance-provisioning/1753/3
:(

@ITD27M01 looks like it has been fixed https://bugzilla.redhat.com/show_bug.cgi?id=1594665


Adds path base to redirect location and tests

As title says

cc @Tratcher @natemcmaster

:up: :date:

:ship: :it:


Optimize traversal of directory

During directory traversal, ['derivatives', 'sourcedata'] is removed from dir list.

closes issue #346.

Ready for review.

You missed https://github.com/INCF/bids-validator/blob/c82f0064ad95c8fee5a3f42776d590444acbcf48/validators/bids.js#L219

Ready for review.

Also ignore all . files and folders (and their subfolders) at any folder level. See #348

ready for review. .

Have you tested it in the browser?

I tried for about 2-3 hours but couldn't get browserify work properly.

What about my other comment? https://github.com/INCF/bids-validator/pull/346#discussion_r149762423

After https://github.com/INCF/bids-validator/pull/367 will be merged it should be easier to test the web version.

i checked web version of validator for this PR. It works fine.

I just tested it and it does not seem to ignore files in /derivatives.

However the command line version does seem to work as expected
filo@MSI MINGW64 /d/drive/workspace/bids-validator ((347d2f6...))
$ bin/bids-validator /d/data/ds000051_R2.0.2/
        1: You should define 'SliceTiming' for this file. If you don't provide this information slice time correction will not be possible. (code: 13 - SLICE_TIMING_NOT_DEFINED)
                ./sub-01/func/sub-01_task-abstractconcretejudgment_run-01_bold.nii.gz
                ./sub-01/func/sub-01_task-abstractconcretejudgment_run-02_bold.nii.gz
                ./sub-01/func/sub-01_task-abstractconcretejudgment_run-03_bold.nii.gz
                ./sub-01/func/sub-01_task-abstractconcretejudgment_run-04_bold.nii.gz
                ./sub-01/func/sub-01_task-abstractconcretejudgment_run-05_bold.nii.gz
                ./sub-01/func/sub-01_task-abstractconcretejudgment_run-06_bold.nii.gz
                ./sub-01/func/sub-01_task-abstractconcretejudgment_run-07_bold.nii.gz
                ./sub-01/func/sub-01_task-abstractconcretejudgment_run-08_bold.nii.gz
                ./sub-02/func/sub-02_task-abstractconcretejudgment_run-01_bold.nii.gz
                ./sub-02/func/sub-02_task-abstractconcretejudgment_run-02_bold.nii.gz
                ... and 92 more files having this issue (Use --verbose to see them all).

        2: Not all subjects contain the same files. Each subject should contain the same number of files with the same naming unless some files are known to be missing. (code: 38 - INCONSISTENT_SUBJECTS)
                ./sub-01/anat/sub-01_run-02_inplaneT2.nii.gz
                ./sub-01/anat/sub-01_run-03_T1w.nii.gz
                ./sub-02/anat/sub-02_run-02_inplaneT2.nii.gz
                ./sub-02/anat/sub-02_run-03_T1w.nii.gz
                ./sub-03/anat/sub-03_run-02_inplaneT2.nii.gz
                ./sub-03/anat/sub-03_run-03_T1w.nii.gz
                ./sub-04/anat/sub-04_run-02_inplaneT2.nii.gz
                ./sub-04/anat/sub-04_run-03_T1w.nii.gz
                ./sub-05/anat/sub-05_run-02_inplaneT2.nii.gz
                ./sub-05/anat/sub-05_run-03_T1w.nii.gz
                ... and 18 more files having this issue (Use --verbose to see them all).

        Summary:                 Available Tasks:                  Available Modalities:
        249 Files, 2.11GB        abstract-concrete judgment        inplaneT2
        13 - Subjects                                              T1w
        1 - Session                                                bold

let me work on it again..

i tried implementing filter function https://github.com/suyashdb/bids-validator/blob/optimizeTraversalOfDirectory/utils/files.js#L102-L107 in 3 different ways inspired by previous issue similar to this where changing forEach to for helped us.
But in this case, none of them worked. Any pointers that you think might be causing this. meanwhile i am going through various stack overflow questions.

The code you wrote is not even called when operating in the browser:
https://github.com/suyashdb/bids-validator/blob/optimizeTraversalOfDirectory/utils/files.js#L9
https://github.com/suyashdb/bids-validator/blob/optimizeTraversalOfDirectory/utils/files.js#L92

In other words your filetering code should be outside of this if statements (so it would be applied in either case - if the validator is used as a command line or if the validator is used in the browser):
https://github.com/suyashdb/bids-validator/blob/optimizeTraversalOfDirectory/utils/files.js#L78

fs and zlib are only available if the code is running via node.js (commandline) not in the browser. This is why the conditional import was put there to begin with.

yes true. There is discussion on stackoverflow about other fs like module(for eg: browserify-fs) which will work with browser. Though it's not been useful or my implementation have been incorrect.

I don't think you need any additional modules. Consider that the original readDir function called the callback function on an array of file objects. In node.js context the readDir function was taking a string - path to a directory - and traversing the file system recursively to create the array of file objects. In context of a browser this was not necessary and the dir argument of the readDir function is already an array of file objects. That is why in context of a browser the readDir does not do much.
To implement the required functionality you need to filter the array of file objects before callback is called.

may be my understanding in limited, but i haven't understood how "the dir argument of the readDir function is already an array of file objects". In the case of browser fs is not loaded control wont go inside if condition rather it will directly proceed to else clause where callback is called with dir passed as another parameter.


Not working: if let navigationController = self.navigationController as? ScrollingNavigationController {

if let navigationController = self.navigationController as? ScrollingNavigationController {
            navigationController.followScrollView(tableView, delay: 50.0)
        }else{
            print("ScrollingNavigationController NOT LOADED")
        }

I always get ScrollingNavigationController NOT LOADED.
What should be the problem?

You are probably using a plain UINAvigationController instead of a ScrollingNavigationController

Thanks, this worked.
Now if the navigation bar is collapsed and I go to back to the first viewcontroller I get black navigation bar.

https://github.com/andreamazz/AMScrollingNavbar#handling-navigation

https://github.com/andreamazz/AMScrollingNavbar#handling-navigation
It worked.

Now at the bottom I get black (the size of this black bottom is same as navigationbar)

I have to close this because didn't know how to solve unfortunately, it is the tabbar which i wanted to hide but nevermind.


Scrolling issues when inside a container that overflows

What is the problem?

I have a parent element of the selection area with the following style:
  height: 100vh;
  overflow: auto;

What is the current behavior?

When scrolling, the selection area stays in the same position on screen, instead of also scrolling.
Please provide the steps to reproduce and create a CodeSandbox.

https://codesandbox.io/p/sandbox/viselect-vanilla-forked-bjz7jz
What is the expected behavior?

The selection area should also scroll, when scrolling down the screen.
Your environment:
Toolset (e.g. webpack, vite, vue-cli...): esbuild
Version (@viselect/<insert package><EMAIL_ADDRESS>Browser:  Safari 16.3
OS:  MacOS Ventura

Seems like this happens when the keys are used... will be fixed with the next patch release :)

Would like to pop in here and say I'm facing this issue with a horizontal scrolling container as well.
Using React version

Hey @simonwep again! 😄 I decided to choose your library and here I am dealing with same issue. I have radix-ui scroll area, and inside it, I want to use your selectable, but cannot scroll while selecting 😞 any idea?

Hey @simonwep again! smile I decided to choose your library and here I am dealing with same issue. I have radix-ui scroll area, and inside it, I want to use your selectable, but cannot scroll while selecting disappointed any idea?

Could you re-produce it on https://codesandbox.io? Maybe your case is a good starting point for me to fix it, this has always been a somewhat tricky issue

Sure, here is exactly your code from demo, but in scroll area wrapper - https://stackblitz.com/edit/vitejs-vite-fdtdkl?file=src%2FApp.jsx

Hey, @simonwep, I found solution. Working on PR right now

This seems to be a duplicate of #153, please move the discussion there. Maybe changing your boundary fixes it?


makeColors correctly handles CellFlags::Hidden

fix #699

Thanks!
Note: the selecting also doesn't work by mouse double-clicking (as in Konsole).

Note: the selecting also doesn't work by mouse double-clicking (as in Konsole).

Thanks for pointing that out, selection and cursor highlight should work correctly now.


Export CSV not working with a different encoding than UTF-8

Hello.
I want to export the content of the table in ANSI encoding. I must do that because Excel 2016 doesn't read utf-8 csv file correctly.
I pass the following options to ToolkitProvider
exportOptions = {
fileName: 'export.csv',
noAutoBOM: false, // true or false, both won't work
separator: ';',
blobType: 'text/csv;charset=ansi' // also tried "application/octet-stream", etc.
};
The file will always be exported in UTF-8.
I've seen this issue:
https://github.com/react-bootstrap-table/react-bootstrap-table2/issues/702
It doesn't work for me.
Maybe this is the solution ?
https://github.com/eligrey/FileSaver.js/issues/28
Thanks for your reply.

@luupqvinh we leverage fileSaver and in our source we did the same thing like eligrey/FileSaver.js#28. So I think so far I still also have no idea about this issue. maybe we can discover more detail from fileSaver, but need some time.

@AllenFang The problem is solved added "\uFEFF" before content.
_fileSaver2.default.saveAs(new Blob(["\uFEFF"+content], { type: blobType }), fileName, noAutoBOM);
In the file exporter.js

The problem is solved added "\uFEFF" before content.
_fileSaver2.default.saveAs(new Blob(["\uFEFF"+content], { type: blobType }), fileName, noAutoBOM);
In the file exporter.js

@AllenFang could you upload an update for issue of the accents.?
The problem is solved by adding  "\uFEFF" before content.
_fileSaver2.default.saveAs(new Blob(["\uFEFF"+content], { type: blobType }), fileName, noAutoBOM);
In the file exporter.js

Any updates on this issue?

I am having the same problem... Any solution?

@AllenFang
I add '\uFEFF' at transform func() for this code.
react-bootstrap-table2-toolkit/lib/src/csv/exporter.js

var transform = exports.transform = function transform(data, meta, columns, _, _ref) {
  var separator = _ref.separator,
      ignoreHeader = _ref.ignoreHeader,
      ignoreFooter = _ref.ignoreFooter;

  var visibleColumns = meta.filter(function (m) {
    return m.export;
  });
  var content = '\uFEFF';  <================This
  // extract csv header
  if (!ignoreHeader) {
    content += visibleColumns.map(function (m) {
      return '"' + m.header + '"';
    }).join(separator);
    content += '\n';
  }

the data is correct for excel. Please consider about this.

@AllenFang
I would like to create a PR for this isuue.

@AllenFang I'm having the same issue when exporting to CSV with Chinese characters. And the solution above _fileSaver2.default.saveAs(new Blob(["\uFEFF"+content], { type: blobType }), fileName, noAutoBOM); works really well. Probably noAutoBOM option does not work with FileSaver.js any longer?

any fix?

Any update ? Does PR #1128 can fix this annoying bug ?

+1 the same issue.

+1

+1


command 'ng add @angular/pwa --project ' break with 'zsh: segmentation fault'

Command
add
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
The command 'ng add @angular/pwa --project ' breaks with 'zsh: segmentation fault'. Do you know if this is a problem with angular-cli, angular/pwa, node, npm or my computer ? And how to solve it ?
Minimal Reproduction
ng add @angular/pwa --project isotope
Exception or Error
ℹ Using package manager: npm
✔ Found compatible package version<EMAIL_ADDRESS>✔ Package information loaded.

The package<EMAIL_ADDRESS>will be installed and executed.
Would you like to proceed? Yes
✔ Packages successfully installed.
zsh: segmentation fault  ng add @angular/pwa --project isotope

Your Environment
Angular CLI: 15.1.6
Node: 18.17.0
Package Manager: npm 9.6.7
OS: darwin arm64

Angular: 15.2.9
... animations, cdk, common, compiler, compiler-cli, core, forms
... material, platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1502.9
@angular-devkit/build-angular   15.2.9
@angular-devkit/core            15.2.9
@angular-devkit/schematics      15.1.6
@angular/cli                    15.1.6
@schematics/angular             15.1.6
rxjs                            7.8.1
typescript                      4.9.5

Anything else relevant?
Chip : Apple M2 Pro
Mac OS Ventura - 13.5 (22G74)

Does this happen in a newly created project for you as well?
If possible, could you try creating a new v16 project and try the ng add command?
You should be able to quickly setup a project via npx @angular/cli@latest new ngadd-test --defaults (or any project name instead of ngadd-test).


Remove pod spec url

It seems this is no longer needed, and causes an error when running 'pod install'.
Thanks so much for open-sourcing this project!

Lovely, sorry for literally taking a year plus to look at this! Fell through the cracks somehow. Thank you!


I can't able to use  const gsmarena = require('gsmarena-api');

Maybe try import gsmarena from 'gsmarena-api'?