Extraneous 'default' and 'adhoc' clusters in results

I have the following clusters set up in my riak_explorer.conf file:
clusters.localdev.riak_node =<EMAIL_ADDRESS>clusters.localdev.development_mode = on

clusters.qa1.riak_node =<EMAIL_ADDRESS>clusters.qa1.development_mode = on

clusters.production1.riak_node =<EMAIL_ADDRESS>clusters.production1.development_mode = off

But in the 'list clusters' result (GET /explore/clusters/), it returns the following:

qa1
production1
localdev
default

(And also occasionally adhoc, though I can't figure out when that happens).
So, two questions:

Can we get rid of the 'default' listing, since that's not actually in the config?
Is the appearance of the 'adhoc' cluster some sort of user error, or is that still a thing?

The adhoc cluster gets automatically added, and was necessary in a previous implementation of the Riak Mesos Framework. The idea being that if you use control endpoints on a node that doesn't exist in any of the existing clusters, then that cluster is now part of the "adhoc" cluster because it was created at run time instead of at config/start time. I think there is still a place for the "adhoc" cluster, but you're right, it should be intentionally added with an endpoint, or maybe we even support a new "create cluster" endpoint to support it. The problem it was solving doesn't even exist any more in the RMF, so I have no problems with getting rid of at least how it is instantiated now anyway.
And yeah, the fact that the default cluster even shows up when you don't define it is likely an oversight by me, I'll see if I can easily remedy that problem.

Tested, works, no longer returns either default or adhoc. Thanks Drew! Closing.


Add a new BooleanInput component

Closes #21
This component repeats the common 'yes/no' radio input pattern which is used throughout the form. It's typically used in conjunction with a question, for example:
Do you need any reasonable adjustments?
[radio inputs]
○ Yes    ○ No
Bound to a data model with v-model, it will return a JavaScript boolean true or false given a 'Yes' or 'No' answer respectively.
Example usage
<template>
  <fieldset>
    <legend>Do you have any criminal convictions?</legend>
    <BooleanInput v-model="has_criminal_conviction" />
  </fieldset>
</template>

Note: This implements the component discussed in #21, but does not add unit tests so that ticket will not be 'done' after this PR is merged. Unit tests on this component will follow later – this PR is to aid rapidly implementing our end-to-end journey.

I'm adding a 'closes' keyword to this as the described unit tests should be expressed under their own ticket/milestone.  Adding that now.


Authentication with environment variables not working

The Telegraf agent fails to connect to Azure_Monitor using environment variables AZURE_TENANT_ID, AZURE_CLIENT_ID and AZURE_CLIENT_SECRET with the following error message:
2019-11-05T15:57:50Z E! [agent] Error writing to outputs.azure_monitor: unable to fetch authentication credentials: azure.BearerAuthorizer#WithAuthorization: Failed to refresh the Token for request to https://uksouth.monitoring.azure.com/subscriptions/<subscription-id>/resourceGroups/<resource-group>/providers/Microsoft.Compute/virtualMachines/azuredemo-ops-manager-vm/metrics: StatusCode=400 -- Original Error: adal: Refresh request failed. Status Code = '400'. Response body: {"error":"invalid_request","error_description":"Identity not found"}
OS:
#64~16.04.1-Ubuntu SMP Wed Aug 7 14:10:35 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Telegraf agent:
# systemctl status telegraf.service
● telegraf.service - The plugin-driven server agent for reporting metrics into InfluxDB
   Loaded: loaded (/lib/systemd/system/telegraf.service; enabled; vendor preset: enabled)
   Active: active (running) since Tue 2019-11-05 13:10:03 UTC; 3s ago
     Docs: https://github.com/influxdata/telegraf
 Main PID: 1347 (telegraf)
   CGroup: /system.slice/telegraf.service
           └─1347 /usr/bin/telegraf -config /etc/telegraf/telegraf.conf -config-directory /etc/telegraf/telegraf.d
Nov 05 13:10:03 xxx systemd[1]: Started The plugin-driven server agent for reporting metrics into InfluxDB.
Nov 05 13:10:03 xx telegraf[1347]: 2019-11-05T13:10:03Z I! Starting Telegraf 1.12.4

I have got the following env variables configured via /etc/environment:
$ env | grep AZURE
AZURE_CLIENT_ID=xxxxxxx
AZURE_TENANT_ID=xxxxxxxx
AZURE_CLIENT_SECRET=xxxxxxxx

I believe this means that the client ID specified in AZURE_CLIENT_ID doesn't exist in the tenant ID specified in AZURE_TENANT_ID.  If you have the Azure CLI installed please run the following command to confirm.
az ad sp show --id $AZURE_CLIENT_ID

And look at the value of the appOwnerTenantId property, it should match $AZURE_TENANT_ID.

Hey Joel, many thanks for acting on this. This seems not to be the case as the AZURE_CLIENT_ID 's appOwnerTenantId property is indeed holding the same value as the env variable AZURE_TENANT_ID. Here is the command I used as per your guidance:
$az ad sp show --id xxxxxx | jq .appOwnerTenantId                                       "yyyyyyyyy"

It was just a guess as the error message returned from the oauth endpoint is vague.  Before I follow up on that, is this running in an Azure VM and are you sure the env vars are properly set?  Unfortunately we don't have logging wired into the auth package.  Since you're using NewAuthorizerFromEnvironmentWithResource() can you add some logging to EnvironmentSettings.GetAuthorizer() to verify it's picking up the client secrets?

I can confirm the issue is happening on an Azure VM and the variable are set globally using /etc/environment. We added debugging messages on the auth.go and auth_test.go and changed the test code to not set the env vars so we could check if they are being properly read. Tests on my laptop confirmed the code is able to read them.
Meanwhile, I'd like to share with you this link of a very similar issue with Azure CLI which seems to have the same root cause.

Thanks for confirming.  Do you know if the initial token acquisition works and this fails later on when trying to refresh?

I ask because the returned error message is similar to ones you'd get for a failed MSI authentication.

Can you please elaborate more on that? This use case is about running Telegraf agent which uses the go-autorest, but the agent documentation claims the environment-based auth is supposed to be used to replace MSI auth. This rational seems to be confirmed by the EnvironmentSettings.GetAuthorizer() code, doesn't it?
I can confirm the VM hasn't got any MSI assigned though.

You are correct that client/secret credentials will be preferred if available.  I brought this up as the error message from the authentication endpoint is very vague, and I have seen the same message returned from failed MSI authentication attempts.  If the VM doesn't have any MSI assigned it further suggests that the environment credentials aren't being found.

Got it! That makes sense. Unfortunately I was not able to do it today. I couldn't rebuild the Telegraf agent using the changed go-autorest package. I suspect this snippet in authorisation.go is being executed and causing the error.

Yep that's the place.  This ultimately calls ServicePrincipalToken.refreshInternal() which sends the token request.

Hey Joel, we managed to recompile Telegraf agent using our forked version with the debugging msgs and it showed us that the env vars are being read. During the process, we also got the pleasant surprise that the new binary is able to authenticate against AAD using the env vars. Digging further, we found that the Telegraf agent currently uses the go-autorest release 10.12.0. We believe this issue has been fixed by this commit, therefore we have just created the PR #6656 on the Telegraf repo.

That commit fixed multi-tenant authorization which doesn't appear to be the case here.  At any rate if moving to the latest version resolves the issue then perhaps that's good enough.  I'm going to close this for now, please ping if you have further questions.

I found that the MS documentation is very specific to Linux. I had the following environment variables set in Windows:
ARM_SUBSCRIPTION_ID
ARM_CLIENT_ID
ARM_CLIENT_SECRET
ARM_TENANT_ID
ARM_ENVIRONMENT
Replacing ARM with AZURE fixed it for me.

@kunalnanda I don't believe that all SDKs support these environment variables (unfortunately there were several implementations floating around until we standardized).  For the env vars supported by the Go SDK have a look at the README.


feat: add plugin-sui

Relates to:
#868
Risks

no new risks presented

Background
What does this PR do?
Introduce new Eliza Agent Plugin to manage a Sui Wallet
What kind of change is this?
Features (non-breaking change which adds functionality)
Why are we doing this? Any context or related work?
Add the ability for Eliza agents to interface with the Sui Blockchain.
Documentation changes needed?
Testing
Where should a reviewer start?

Goto packages/plugin-sui directory
Run pnpm i
Run pnpm test

stdout | src/tests/wallet.test.ts > WalletProvider > Wallet Integration > should check wallet address
Cache miss for fetchPortfolioValue
Cache miss for fetchPrices

stdout | src/tests/wallet.test.ts > WalletProvider > Wallet Integration > should check wallet address
Fetched portfolio: { totalUsd: '0.90126', totalSui: '0.9' }
Cache miss for fetchPrices

 ✓ src/tests/wallet.test.ts (1) 778ms
   ✓ WalletProvider (1) 777ms
     ✓ Wallet Integration (1) 777ms
       ✓ should check wallet address 776ms

 Test Files  1 passed (1)
      Tests  1 passed (1)
   Start at  00:37:43
   Duration  1.98s (transform 203ms, setup 0ms, collect 845ms, tests 778ms, environment 0ms, prepare 76ms)

Detailed testing steps
For e2e Test:

Replace Default Character Here

    // Replace the existing character initialization with custom setup
    const character = defaultCharacter;

    character.plugins = [suiPlugin];
    character.modelProvider = ModelProviderName.OPENAI;
    let characters = [character];

Updated to generateObjectV2
Tested out and transferred 1 SUI ALmxao2hvCRoxHc6x8vMw9JxbUceBLruR98W9bhzXJx

Looks like there's a hold on merging new plugins due to high-volume:

https://discord.com/channels/1253563208833433701/1316266980118106133/1316267190697070593


Select & Autocomplete Panel causes lag and choppy animation

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Smooth animation when entering into input by holding down a key.
What is the current behavior?
The animation is choppy
What are the steps to reproduce?
https://stackblitz.com/edit/angular-33e4nh

Select the 1st AutoComplete to open panel.
While Panel is open hold down the tab key (It will scroll through till the last Autocomplete)
Repeat step 1 and 2 for a few times.
Go to the last input and hold down a key. (The animation will be choppy)

What is the use-case or motivation for changing an existing behavior?
The animation should not be choppy
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Chrome OS
Angular 5.2.3
Material 5.2 & 5.2.1 & 5.2.2
Is there anything else we should know?
Not happening on 5.1.1 and below
Suspect is due to the opening of panels
Suspect is due to #7721

Hi, any updates on this issue, it is preventing our team to upgrade beyond 5.1.1

I can definitely reproduce it in your example, but I wasn't able to in our local dev app. It looks like there's a keydown event leak somewhere. My hunch is that it was fixed in master by https://github.com/angular/material2/pull/10160.

Hi, @crisbeto wanted to double check if #10160 is released for 6.0.0 vibranium-vivarium.

Seems to be resolved in 6.0.0


Resolved problem with $Features due to Contains method being case sensit...

...ive
The Contains method that is used throughout the Set-TargetResource
function is case sensitive. This caused a configuration to fail if the
features were specified in a case other than upper case which is how
they are specified in the function. The easiest way to resolve this
issue was to add a line to convert $Features to upper case.

Hi @mikefrobbins, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;


TdsParserStateObject methods should be clear about their target

Reading though ReadSniError there is code like this:
        private void ReadSniError(TdsParserStateObject stateObj, uint error)
        {
            if (TdsEnums.SNI_WAIT_TIMEOUT == error)
            {
                ...

                if (IsTimeoutStateExpired)
                { // This is now our second timeout - time to give up.
                    fail = true;
                }
                else
                {
                    stateObj.SetTimeoutStateStopped();
                    Debug.Assert(_parser.Connection != null, "SqlConnectionInternalTds handler can not be null at this point.");
                    AddError(new SqlError(TdsEnums.TIMEOUT_EXPIRED, (byte)0x00, TdsEnums.MIN_ERROR_CLASS, _parser.Server, _parser.Connection.TimeoutErrorInternal.GetErrorMessage(), "", 0, TdsEnums.SNI_WAIT_TIMEOUT));

where the IsTimeoutStateExpired is called on the this reference but the timeout is stopped on stateObj parameter. Similarly _parser is called on `this' not the state object parameter. The function should either be static and always call methods on the parameter passed in or it should be instance and not require the stateObj parameter.
Any other methods on TdsParserStateObject should be identified and changed inthe same way so that it is clear which stateObject they are operating on. The equivalence of this == stateObj is never checked only assumed.

Hi @Wraith2
I agree state should be managed properly in such state driven methods. We'll take a look at this soon after release.


[WIP] Update UML

This solves #72 and #59.

I just noticed that this renders some images differently, for example, the arrows in the returns and executes lines in uml-commands are not rendered in the new image.

I have rebased this branch on #86, exported all .uxf files as .svg files and converted those to .pdf. I believe everything now renders correctly, except

Figure 2.1, it's too wide. Scaling the width should resolve this;
Figure 5.3, "uses" is cut off. Minor issue but perhaps worth investigating regardless.

Please do compile and take a look yourselves!

Other updates will be in later PRs


unify configs in pyproject & ruff

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
unify all python related configs in pyproject.toml
replace flake8 by ruff
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

let's wait the PL update is resolved in #222


Do not build guided pool examples with older GCC compilers

Buildbot confirms that this now passes on the gcc 4_9 builder. I do not know how to fix the problem correctly, so the safest thing is to simply disable the tests on gcc4.9 and lower

FYI http://rostam.cct.lsu.edu/builders/hpx_gcc_4_9_boost_1_60_centos_x86_64_release/builds/148
is a buildbot output where the compilation fail can be seen to be suppressed.

I'm not proud of myself, but I wasted too much time trying to fix it for an old compiler and at some point you have to give up and move on - and no - nobody else will ever use this feature on gcc 4.9, so we don't need to worry about it.
We can remove gcc 4.x support after this release yes?


Inline function on previous unmounted component gets next component value(前一个卸载的组件上的内联函数会获取下一个组件的值)

Version
3.2.25
Reproduction link
sfc.vuejs.org/
Steps to reproduce
click "next" button, view console log
点击 “下一步” 按钮，查看控制台输出日志
What is expected?
console log:
init one one
destroy one one
init two two
What is actually happening?
console log:
init one one
destroy two one
init two two

That's expected. you first change currentValue, then the component re-renders, and then the destroy callback gets called.
If you need help in solving this differently: chat.vuejs.org

Oh, I see, thank you.

I got the desired result by use the closure function.


Spiky Bracers - New Description and Flavor Text

The relic changed, now let's change the description and flavor text.

And done.


Export web page to "misc" type with "notes" and "howpublished" custom fields

Hi,
I am using a modified version of the Zotero BibTeX translator, which is inferior to yours, but simpler, and therefore easier to adapt to my needs.
I would like to switch to Better BibTeX, but I must be overlooking something, because I could not find anywhere in the options where to handle the web pages. Due to the poor support of BibTeX (and style files) for this, I generally use the "misc" category, with the last accessed date in the "notes" field, and the url in the "howpublished" field. Is there a way to handle it with Better BibTeX? (I know that Zotero dropped this, and this is precisely with I am using a modified translator...)
Best.

Do you have a sample of what you want to achieve?

That's only for Better BibTeX, right? I mean Better BibLaTeX use the @online type… (@retorquere: two labels "BibTex" / "BibLaTeX" might help)
FWIW: http://tex.stackexchange.com/questions/3587/how-can-i-use-bibtex-to-cite-a-web-page

This can only be for BibTeX, right. I'm on the fence on how to best do this; on the one hand it can be done using bibtex[...], as publishing web pages this way is hackish in any case. On the other hand, if that reference at stack exchange you link to is the "best" way to do it, I might as well bite the bullet and just always export webpages that way.

Yes, indeed, it is only for BibTeX, which is still required by almost any publisher (a least in my domain)... And what I need is to add custom howpublished and note fields to the @misc entries. These fields need to be custom, since they may change depending on the publisher. (I then regenerate a corresponding BibTeX file.)
The StackExchange example shows what I would like to achieve, but I do want to keep the other fields (which are sometime used, and already produced by the Zotero translator). See also the Wikipedia example, BibTeX entry
I my personal case, I also use the urldate field (in addition to the "note") for the last accessed date. I use the href package for the howpublished field (while others may prefer url or even nothing). And I use the journal field for the web-site, if relevant.
Here is an example of my current output (which uses author instead of journal, but all of this stays in Zotero):
@misc{ntp.org_clock_2015,
        title = {Clock {Quality}},
        url = {http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm},
        urldate = {2015-02-13},
        note = {(last accessed 2015-02-13)},
        author = {{NTP.org}},
        year = {2015},
        howpublished = {\href{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}},
        file = {NTP.org - 2015 - Clock Quality.html:/Users/jipodine/Documents/zotero/storage/BXUMNKVE/NTP.org - 2015 - Clock Quality.html:text/html}}
}

(As a side note, since UTF is not supported by BibTeX, I always escape everything. I noticed that the file field is not, but I think it could be ignored anyway.)

And yes, it is hackish, but the "best" way because the only one that works with the old styles that are still required.

If it's custom, have a look there: https://zotplus.github.io/better-bibtex/export.html#add-your-own-biblatex-fields but that's at the item-level and won't solve your problem if you've to change the fields depending on the publisher.
If you actually need a way to customize the export (almost) each time, a custom translator is the best solution. The other solution would be to allow users of BBT to customize the export, but that's a lot of work.

Customizing the export is not technically hard, but

I can't give any support other than helping to debug for translators that deviate from my own.
It requires rebuilding the extension since the translators are written in coffeescript, compiled to javascript, and the result is bundled inside the extension
Mozilla is going to make this impossible soon since extension will have to be signed, and changes in files inside the extension invalidate the signature, and the modified extension will not load.

Modifying the assembled BBT translator is technically possible (if you're going this way, have a mental health professional on speed-dial, and pick one BBT installs into the translators dir rather than from the BBT sources), and you could just drop it into your translators folder (don't forget to change the name and ID, or bad stuff will happen), but I'm afraid I cannot offer support for it beyond hints on how to get certain things done. If it breaks, it breaks.
I don't want to add a "add your ownpost-processing javascript", because that's going to be impossible to debug.
Per-item is is indeed possible using the page @gracile-fr links to, even if it will require the upcoming 1.2.35 to enable LaTeX inside those constructs (currently, everything in those constructs is escaped).
I don't currently have an idea how I would cleanly add per-publisher variability. Not against it in any way, but I'd need something clean, that doesn't add a bazillion preferences to the already extravagant prefs pane of BBT. The only thing that springs to mind is XSLT, but I wouldn't say that XSLT is especially easy to create (or debug).

I could just add the "howpublished" field, subject to the "fancyURLs" setting, I don't see much harm in that. For the "notes" field it's a different matter, as it requires inserting text not entered into Zotero, which would probably require translation.

@jipodine : for the entry you posted in https://github.com/ZotPlus/zotero-better-bibtex/issues/329#issuecomment-135977082, could you right-click on that in Zotero, select "report zotplus error", and post the resulting debug ID here? I may have a solution (of sorts).

@jipodine the file field is not escaped as it is not used in bibliographies, but is used by JabRef and others to open the associated file. You might be interested in https://github.com/ZotPlus/zotero-ascii-rename.

@jipodine I will need your help in getting a resolution.

@retorquere : here is the debug ID: 7XIZE5P3. Thank you for looking at this, and the clarification about the filefield.
Of course, the solution that is needed here is a global per-collection, as I would rather use a post-processing script (on the resulting BibTeX file) than manually update every item in Zotero.

I'm looking for a way to achieve this that doesn't require you to manually edit each entry, which doesn't make too many unwarranted assumptions on the output, and which doesn't assume everyone speaks English. On it, but not a quicky.

Not released yet, but you can try to see if this is what you're after: install http://tempsend.com/8AE794DF08, go into about:config, and set preference extensions.zotero.translators.better-bibtex.postscript to
  if (this.item.itemType === 'webpage' && Translator.BetterBibTeX) {
    if (this.has.urldate) {
      this.add({ name: 'note', value: "(accessed " + this.has.urldate.value + ")" });
    }
    if (this.has.url) {
      this.add({ name: 'howpublished', bibtex: "{\\href" + this.has.url.bibtex + this.has.url.bibtex + "}" });
    }
  }

I'm still on the fence on the form in which I should release this. The code in the preference is ran for every non-cached reference after BBT has done all its work, and allows modifying the reference in place before it's flushed out. The problem with this is that you have to know the internal API to make it work, this API has exactly zero documentation, and I honestly don't feel like documenting all of it. Plus, this is almost guaranteed to require adjustment at some point as I sometimes do change the internal API.

I've updated https://zotplus.github.io/better-bibtex/export.html with some documentation

@jipodine are you still interested? I'd love to get verification that this solves your problem.

Yes, of course, I am still interested :) Thank you for your good solution, as it allows customisation, and will less break anyway that changing parts of a generated script (which is what I am doing now)...
Some points need to be cleared, though... When I copied the script you provided in extensions.zotero.translators.better-bibtex.postscript, I got the following result, with nested \href tags:
@misc{ntp.org_clock_2015,
  title = {Clock {Quality}},
  url = {\href{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}},
  timestamp = {2015-02-13 17:15:15},
  urldate = {2015-02-13},
  author = {{NTP.org}},
  year = {2015},
  file = {NTP.org - 2015 - Clock Quality.html:/Users/lambert/Documents/zotero/storage/BXUMNKVE/NTP.org - 2015 - Clock Quality.html:text/html},
  note = {(accessed 2015-02-13)},
  howpublished = {\href{\href{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}}{\href{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}}}
}

I then tried without the script:
@misc{ntp.org_clock_2015,
  title = {Clock {Quality}},
  url = {\href{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}},
  timestamp = {2015-02-13 17:15:15},
  urldate = {2015-02-13},
  author = {{NTP.org}},
  year = {2015},
  file = {NTP.org - 2015 - Clock Quality.html:/Users/lambert/Documents/zotero/storage/BXUMNKVE/NTP.org - 2015 - Clock Quality.html:text/html}
}

So I guessed that there were 2 issues:

the url is already encoded with the \href tag (as it appears in the url BibTeX field)
there is an error in the documentation, as the href tag must be used with a url and a description

With the modified script:
if (this.item.itemType === 'webpage' && Translator.BetterBibTeX) {
    if (this.has.urldate) {
      this.add({ name: 'note', value: "(accessed " + this.has.urldate.value + ")" });
    }
    if (this.has.url) {
      this.add({ name: 'howpublished', bibtex: this.has.url.bibtex });
    }
  }

I finally got this result
@misc{ntp.org_clock_2015,
  title = {Clock {Quality}},
  url = {\href{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}},
  timestamp = {2015-02-13 17:15:15},
  urldate = {2015-02-13},
  author = {{NTP.org}},
  year = {2015},
  file = {NTP.org - 2015 - Clock Quality.html:/Users/lambert/Documents/zotero/storage/BXUMNKVE/NTP.org - 2015 - Clock Quality.html:text/html},
  note = {(accessed 2015-02-13)},
  howpublished = {\href{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}{http://www.ntp.org/ntpfaq/NTP-s-sw-clocks-quality.htm}}
}

While this is correct, I would suggest not to encode the url, so as one could choose to use \url, \href or no tag. Also, the documentation should be corrected (and could use the \url form, which is simpler).

This is all up to the scripter (that is: you). The urls were already wrapped in hrefs because you have the "fancyURLs" set to true, and that is what they do. If you want to fiddle around with the URL itself, you can find it as this.has.url.value rather than this.has.url.bibtex. You can do something like
this.add({name: 'howpublished', value: this.has.url.value, enc: 'url'})

and that will follow the "fancyURLs" setting.

This has already been release BTW.

Everything is clear, now. So everything works fine, and only the documentation could be updated to use either your last form, that works according to the fancyURLs setting:
if (this.item.itemType === 'webpage' && Translator.BetterBibTeX) {
    if (this.has.urldate) {
      this.add({ name: 'note', value: "(accessed " + this.has.urldate.value + ")" });
    }
    if (this.has.url) {
      this.add({name: 'howpublished', value: this.has.url.value, enc: 'url'});
    }
  }

or this one that works no matter the fancyURLs setting:
if (this.item.itemType === 'webpage' && Translator.BetterBibTeX) {
    if (this.has.urldate) {
      this.add({ name: 'note', value: "(accessed " + this.has.urldate.value + ")" });
    }
    if (this.has.url) {
      this.add({ name: 'howpublished', bibtex: "{\\url{" + this.has.url.value + "}}" });
    }
  }

Here I used the \url tag, as it is easier, but note that the \href tag was broken in the doc anyway, as it should be:
this.add({ name: 'howpublished', bibtex: "{\\href{" + this.has.url.value + "}{" + this.has.url.value + "}}" });

Thanks a lot.

The last two aren't correct; this.has.url.value needs to be verbatim, not raw, as not all valid URL characters are safe for verbatim. You could do that with
this.add({ name: 'howpublished', bibtex: "{\\url{" + this.enc_verbatim({value: this.has.url.value}) + "}}" });

I've opened a wiki page for examples; I'd appreciate it if you could add your example there. I'll consolidate into the web site perhaps at a later point.

I did, for the wiki page. Please do check that this is correct (and update the documentation page).


FIX: Fix creation of translations with targetLanguageKeys defined

If you try to create translations with the parameter --target-language-keys defined, you will get an error that translationUnits is not defined in Neos\Kickstarter\Service\GeneratorService. This is, because Neos\Flow\I18n\Xliff\V12\XliffParser::getParsedData will return an array (for each <file>-Entry in the Xliff-File, typically only one entry). So we need to use the first item of that data to get the translationUnits from it.
The PR is made against the 4.3 branch, as this is the latest still supported version.

Sry, i made this in the wrong package, should go to flow-development-collection. I will add the pull request there later that day.


VSO -> VSTS

Should we rename the VSO default formatter to VSTS?
Microsoft has renamed the project to Visual Studio Team Services.
https://www.visualstudio.com/en-us/products/what-is-visual-studio-online-vs.aspx

Only if it's changed in tslint.


Use st_mtim if st_mtime is macro, fix #1510

Should unbreak builds against musl and on FreeBSD, I also saw that glibc remains okay. Please re-check AIX, Android, macOS and Solaris if you have them nearby.

solaris builds and tests successfully
ninja-solaris-build.log

ninja builds, but ninja_test does not - seems unrelated to this patch, see #1618

this test does not appear to break anything that isn't already broken on AIX.
builds on AIX fail both here and on master.
if the failure is worked around (as in #1622), the tests fail exactly the same place both here and on master (subprocess_test.cc:83). i don't think it will hurt anything to pull it in as is, and the issues on AIX should probably be looked at separately.


Update chapters in 'Authoring Gradle Builds/Learning the Basics' part of user manual

This addresses the most obvious issues with theses chapters:

Update all snippets to use lazy task configuration APIs
Update custom task implementation snippets to use properties
Remove a few parts that recommend outdated things and add a few comments for clarification

This does not aim to restructure this part of the documentation, which we can consider in a next step.
(Talking extensively about tasks, before even getting to plugins, should be reconsidered)

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

@bot-gradle test this

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.

@bot-gradle test this

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test this

OK, I've already cancelled the old build and triggered a new ReadyForMerge build for you.


Default route nested in anonymous route no longer working

It would be nice if this worked in 1.0:
    <Route path="/(:locale)">
      <Route path="login" component={Login}>
      <Route component={App}>
        <IndexRoute component={Dashboard} />
        /* more routes here */
      </Route>
    </Route>

In 0.13 I had it working like so:
    <Route handler={Locale} path="/:locale?">
      <Route name="login" handler={Login} />
      <Route handler={App} path="">
        <DefaultRoute name="dashboard" handler={Dashboard} />
      </Route>
    </Route>

But now, path /en/ gets resolved to Locale rather than Dashboard.
I've tried various ways of rearranging the routes but can't seem to get it to resolve to Dashboard no matter what I try. Perhaps I'm missing something?

can you list some urls and which components you expect to be rendered? I can't quite follow what is expected.

I'd expect /en/ to match the IndexRoute but instead it only matches the outermost route. Essentially it would be nice if it could do a "deep" or "greedy" match, following any anonymous nested routes. Sorry if I'm not explaining this very well, I hope this makes more sense?

I think this is the behaviour I was trying to explain in https://github.com/rackt/react-router/issues/2037
Suppose we have the following layout

the header is always visible. If we go to /login, the content ( with the menu ) disappears, to show the login form.
the route "/" should displays the Content with SubHome1 as default page.
I managed to implement this in react-router 0.13 doing
<Route handler={App} name="app" path="/">
    <DefaultRoute handler={Home} />
    <Route handler={Home} name="home" path="/">
            <Route handler={subHome1} name="subHome1" path="/" />
            <Route handler={subHome2} name="subHome2" path="/subHome2" />
      </Route>
      <Route handler={Login} name="OtherPage1" path="/login" /

But I can't make it work with react-router 1. Is it still even possible ?
Sorry @jscheid if it's unrelated but I think it could be.

It looks like the same issue to me @flocks

@jscheid it seems like you are trying to do similar thing to #2159

@knowbody no, this is different from #2159. I guess the locale part is a bit of a red herring. Instead, the issue seems to be that index routes won't be matched when nested inside anonymous routes (by which I mean routes without a path attribute.)
I think the problem is here: https://github.com/rackt/react-router/blob/e738c88a05a537d4b93b5946097eb2629598fa74/modules/matchRoutes.js#L56 which will stop as soon as the path so far matches, which sometimes is too early.
All this being said, I've now worked around the issue by getting rid of anonymous routes (using outer components inside the nested routes instead), so feel free to close this. However, I still think it would be useful if this worked (like it did in 0.13).

@jscheid, I think that I am facing the same issue. I have something like that:
    <Route path='/' component={App}>
        <IndexRoute component={Authent}
                    onEnter={(location, replaceWith) => authenticated(location, replaceWith)}>
            <IndexRoute component={Dashboard} />
            <Route path='dashboard' component={Dashboard}>
                <Route path='add/?' component={AddWidget} />
            </Route>
            <Route path='account/?' component={Account} />
            <Route path='*' component={NotFound}/>
        </IndexRoute>
        <Route path='login(/:email)' component={Login} />
        <Route path='register/?' component={Register} />
    </Route>

However, I do not see the dashboard appearing.

@ekaradon as far as I understand you're not supposed to nest anything inside an IndexRoute but yes, if you were to restructure it to use a pathless Route it looks like you would run into the same issue.

I'm also facing this issue, migrating from 0.13.3 to 1.x.
I'm trying to render 'App > List > Home' for the root of the application ('/').
I've tried to following, with no luck.
<Route path='/' component={ App } history={ history }>
  ...
  <Route component={ List }>
    <Route component={ Home }>
  </Route>
  ...
</Route

<Route path='/' component={ App } history={ history }>
  ...
  <Route component={ List }>
    <IndexRoute component={ Home }>
  </Route>
  ...
</Route

<Route path='/' component={ App } history={ history }>
  ...
  <Route component={ List }>
    <Route path='/' component={ Home }>
  </Route>
  ...
</Route

<Route path='/' component={ App } history={ history }>
  ...
  <Route path='/' component={ List }>
    <Route path='/' component={ Home }>
  </Route>
  ...
</Route

This just doesn't make sense... If you want to do that why you just don't put Home and List inside and App component and then have a route like:
<Route path='/' component={ App }>
</Route>

@knowbody I does make sense, but I might have left too much out.
<Route component={ List }>
  <Route path='/area' component={ Area } />
  <Route path='search' component={ Search } />
  <Route path='/type' component={ Type } />
  <Route path='/' component={ Home } />
</Route>

App contains the application layout (header, footer, etc) and List contains layout for the content part, when it is a list page, which there is several versions of, which only affect a minor part of the whole content.

@danieljuhl now it's a bit more clearer :)
If I understood correctly this is what you look for (quick example):
import React, { PropTypes, Component, ContextTypes } from 'react';
import createBrowserHistory from 'history/lib/createBrowserHistory';
import { Router, Route, Link, IndexRoute } from 'react-router';

let history = createBrowserHistory();

class Navigation extends Component {
  render() {
    return (

<Link to='/'>Home</Link>

<Link to='/search'>Search</Link>

    );
  }
};

class Search extends Component {
  render() {
    return
Search
;
  }
}

class Home extends Component {
  render() {
    return
Home
;
  }
}

class List extends Component {
  render() {
    return (

List

        {this.props.children}

    );
  }
}

class App extends Component {
  render() {
    return (

App

        <Navigation />
        {this.props.children}

    );
  }
}

export default class Root extends Component {
  render() {
    return (
      <Router history={createBrowserHistory()}>
        <Route component={App}>
          <Route path='/' component={List}>
            <IndexRoute component={Home} />
            <Route path='search' component={Search} />
          </Route>
        </Route>
      </Router>
    );
  }
}

also @jscheid and @flocks could you tell me if this issue can be closed, because this issue starting to be like an open ended question...

@knowbody Spot on, besides I have a bunch of other routes, so that path='/'should be located on the first (and outer-most) route. Hence the ... in the initial comment.

@knowbody : I don't think so because it seems today impossible to manage nested default route like below.
<Route path='/' component={App}>
    <Route component={Authent}
                onEnter={(location, replaceWith) => authenticated(location, replaceWith)}>
        <IndexRoute component={Dashboard} />
        <Route path='dashboard' component={Dashboard}>
            <Route path='add/?' component={AddWidget} />
        </Route>
        <Route path='account/?' component={Account} />
    </Route>
    <Route path='login(/:email)' component={Login} />
    <Route path='register/?' component={Register} />
</Route>

Here the component Authent will never be called.
For me, the issue is real and the fact that people come here to ask questions comes from that something seems like missing.

@ekaradon I hear you all. and as you can see I'm trying to help you all as well.
First of all instead of just throwing your routes here and saying this does not work for me, doesn't make it easy for me to help you. Please explain what are you expecting to get. Looking on what you showed above my answer is simple as: your route with the Authent component does not have a path hence can't be matched and is not being displayed. Although I know that's not the answer you are looking for.

@danieljuhl could you also explain in steps what are you expecting?
something like:

navigating to / gives me App, List and Home component
navigating to /search would keep App, but will replace...

that will be very helpful for me to understand it properly. Thanks

Well, what I want to do is having nested components which are activated by default if no routes are specified.
For example, by default my url will be: my.website.com
And I Want to activate the following components -> App > UserAuthenticated > HomeUser
But today, I only get -> App -> User_authenticated working only if I am using IndexRoute and which does not support nesting route and so prevent me from rendering HomeUser

@ekaradon no worries :)
I understand that first part, what happens after that, which components should always be mounted which ones needs changing?

I think that the best way would be to be able to specify a default route to be used when no path is remaining. The default route could be a route without a path.
<Route component={myDefaultChoice} />

So while we have a path, we are following it, but as soon as the current path evaluated is empty, we have to look for a default route. If none we stop there, otherwise we continue on the default route.
For example, with the following URL:
my.website.com/dashboard/activities
We would first be looking for the master route '/' and next to the Auth Component which ensure the user is authenticated, then to the dashboard. We would then search for the route 'activities' (which could be a module responsible for some menu about activities) and then would go for the default module which just present the last activities.
I think that the following routes should be able to complete this task.
    <Route path='/' component={App}>
        <Route component={Auth}>
            <Route path='dashboard' component={Dashboard}>
                <Route path='activities(/)' component={ActivitiesMenu}>
                    <Route component={LastActivities} />
                    <Route path='other' component={OtherComponent} />
                </Route>
                <Route path='other' component={OtherComponent} />
            </Route>
            <Redirect from='' to='/dashboard' />
        </Route>
        <Route path='other' component={OtherComponent} />
    </Route>

A complementary/other solution would be to make Redirect able to interpret blank segment path? Maybe the simplest solution. I am not sure however about this one, still learning the new API from 1.0. :)

@ekaradon in your case, why wouldn't you use onEnter for doing the user validation? (see the auth-flow example)

@knowbody Yes, indeed, but I prefer to say that all these roads need to have the user logged in by grouping them below a component (which checks that the user has a valid session) rather than setting the onEnter of each component which require the user to be authenticate.
Imagine I have these routes when logged in:

dashboard
account
messages
news
activities
I think it is better to create a section login_required rather than calling for each of these routes the event onEnter.

It does not have to modify my URL because it is not bound to an action that the user wants to do. It is just an internal logical rule. So it has to be visible from the developer side, minimizing the risks of giving access to not authorized sections of the website, however it has to be transparent for the user.
Rephrasing @jscheid we had before the defaultRoute which should be replaced by the Route without a path. It would be a pity to not be able to use the vertical hierarchy layout that xml offers for rights management, no?

but this is what onEnter will do for you. You just set it up on your parent Route and no matter if you hitting / or /news it will trigger the onEnter.

Not sure to understand, how do I avoid this?
<Route path='/' component={App}>
    <Route path='login(/:email)' component={Login} />
    <Route path='register/?' component={Register} />
    <Route path='dashboard' component={Home} onEnter={(l, r) => auth(l, r)} />
    <Route path='news' component={News} onEnter={(l, r) => auth(l, r)} />
    <Route path='account' component={EndUserClient} onEnter={(l, r) => auth(l, r)} />
    <Route path='activities' component={EndUserClient} onEnter={(l, r) => auth(l, r)} />
</Route>

<Route path='/' component={App} onEnter={(l, r) => auth(l, r)}>

Indeed, the problem is solved but in my case, my auth app is also making appears the user menu with the logout button for example...

@ekaradon You can use a route that doesn't consume any portion of the URL path. Put your onEnter on that route.
<Route onEnter={auth}>
  <Route path="dashboard" component={Home} />
  // ...
</Route>

And how do I enter in this route without any path?

@knowbody  I expect / to use App > List > Home and /search to use App > List > Search. If I can accomplish in another way that's fine, but I can't figure out any method that works.

@danieljuhl I believe you can use the same workaround that I've settled on:
In Home.render: return <App><List>...</List></App>.
Same for Area, Search, Type.
Basically, collapse the route hierarchy. Once it's flat, IndexRoute should work again.
Not exactly DRY but should do the job... hope this helps.
I think to get the underlying issue recognized, somebody will have to write a test case that demonstrates the problem.

@jscheid my problem in your solution is that I have other routes on the route, which does not use the list component.  I am just misleading route pattern feature.
Here is what I do:
<Route component={TopLevel} onEnter={auth_check}>
    <Route path='(/)' component={CheatingAppWithSomeMenu}>
        <IndexRoute component={RealDashboard} />
        <Route path='/dashboard/'>
            <Route path='add(/)' component={DashboardCanBeExtended} />
        </Route>
        <Route path='/others'  component={Others} />
    </Route>
    <Route path='login(/:email)' component={Login} />
    <Route path='register(/)' component={Register} />
    <Route path='*' component={NotFound} />
</Route>

I have noticed that path='' does not exist, but I have also noticed that you can make it optional using "()" operator.
But this is where the weird thing occurs. Like I am in an optional path, I have to add the optional path before each of my new routes in order to make them recognized. Here, it is just the "/", but it could be more like "/home/dashboard/" if you define a path like "(/home/dashboard)".
For example:
<Route component={TopLevel} onEnter={auth_check}>
    <Route path='(/)' component={CheatingAppWithSomeMenu}>
        <Route path='dashboard' />
    </Route>
</Route>

The route my.website.com/dashboard can never be reached (while it should be).
An other solution would be to write your like:
<Route component={TopLevel} onEnter={auth_check}>
    <Route path='(/)' component={CheatingAppWithSomeMenu}>
        <IndexRoute component={RealDashboard} />
    </Route>
    <Route path='/' component={CheatingAppWithSomeMenu}>
        <Route path='/dashboard/'>
            <Route path='add(/)' component={DashboardCanBeExtended} />
        </Route>
        <Route path='/others'  component={Others} />
    </Route>
</Route>

This will also works.
However, I think that all these workaround look like bugs themself (at least the need to duplicate the CheatingAppWithSomeMenu part). And I think that it is not the proper way to solve the initial issue which is the disappearing of DefaultRoute. Furthermore, write path='(/)' is really clumsy.
But well, until now, this is the only solution I have found.


JOSM Remote Control doesn't work on ChromeOS

From what I could tell, the actual requests to Remote Control are sent at this point. In that line, the address <IP_ADDRESS> is hardcoded. Unfortunately, that address doesn't work on ChromeOS as JOSM is forced to run on a special VM. Instead, it needs to be accessed through penguin.linux.test. Perhaps a snippet like
var localhost = window.navigator.userAgent.contains("CrOS") ? "penguin.linux.test" : "<IP_ADDRESS>";
sendJOSMCommand(`http://${localhost}:8111/import?new_layer=true&layer_name=` +
                     adjustedDateString + '&upload_policy=never&download_policy=never&url=' +
                     encodeURIComponent(overpassApiURL))

added to that function would fix the problem, but I don't know enough to be sure of myself.

Thanks, @weech , I don't have a Chromebook to test this on but will look into it. Out of curiosity, if you install a browser on the VM and use it for MapRoulette, will it contact JOSM correctly?

I gave it a try running Vivaldi in the VM, and it works correctly from there.

Closing as there is a work-around, and we're not likely to fix this anytime soon. I'd be happy to consider a PR if someone wants to submit one.


Update fabric-protos-go to v0.2.0

fabric-protos-go v0.2.0 is released for Fabric v2.5.
Signed-off-by: David Enyeart<EMAIL_ADDRESS>

Replaced by https://github.com/hyperledger/fabric/pull/3807


[eas-cli] update:configure less verbose output

Why
Make eas update:configure output less verbose and similar to eas build:configure
UX
Before:
🎉 Your app is configured with EAS Update!

Next steps:

Update a production build:
1. Create a new build. Example: eas build --profile production.
2. Make changes in your project.
3. Publish an update. Example: eas update --channel production.
4. Force close and reopen the app at least twice to view the update.

Preview an update:
1. Publish an update to a branch. Example: eas update --branch new-feature.
2. In Expo Go or a development build, navigate to Projects > [project name] > Branch > Open.

After:
quins-MacBook-Pro:AwesomeProject2 quin$ ~/Documents/eas-cli/packages/eas-cli/bin/run update:configure
🎉 Your app is configured with EAS Update!

- Run eas build:configure to complete your installation
- Learn more about other capabilities of EAS Update: https://docs.expo.dev/eas-update/introduction/

Test Plan

[ ] tests still pass

/changelog-entry chore Make update:configure less verbose


Cifer Chain Registry.

Cifer Chain Registry.
Please review Cifer Chain Registry.
Website : https://cifer.ai/
Whitepaper : https://cifer.ai/pdf/CiferAI_WhitePaper_1_0.pdf
CiferAI_WhitePaper_1_0.pdf

Update Change denom name and update token images please review.
Our pull request for bench32 registry is now under reviewing.


Add single colour base layer

To increase print performance with multi material printers introduce a small layer of multicoloured shapes on top of a single coloured base.

This is some nice functionality. There are two issues that need addressing.

The default settings seem to create a gap

The UI now seems confusing to me.
The code introduces a duplicate colour without user input. I'd prefer if this behaviour was more predictable and under control by the user. Maybe a checkbox and colour input?


How to unload CSS dynamically (before loading new)

Is there anyway to unload a loaded CSS with this package?
This would allow dynamically changing the CSS, for instance based on user input.
I notice on a HTML control/component that I am dynamically loading uses this css loader plugin, that on requiring/loading other .css files later, the styles seems to become 'stacked'. By that I mean that earlier styles are not removed again, only the new .css is put on top of it.
See this screenshot for an explanation. It shows that the order in which .css'es are loaded is of importance, while in my case I want them to be mutually exclusive, i.e. unload old CSS first before loading new (I'm using bootstrap themes).

In Removing or replacing a stylesheet (a <link>) with JavaScript/jQuery - Stack Overflow the question says:

although the element is removed, the styles are still applied to the current page in both Opera and Firefox).
Is there any other way?

The answer says:

To cater for ie you have to set the stylesheet to be disabled as it keeps the css styles in memory so removing the element will not work, it can also cause it to crash in some instances if I remember correctly.

Check out that answer.
So appart from the obvious cross-browser issues, you also need to consider at least this: There is a limit on how many style sheets you can have on a page. Will navigating back-and-forth repeatedly trigger this limit? Will removing one sheet and then adding a new one increase the sheet count? Then you've got a problem.
However, there is perhaps a better approach: twitter bootstrap - How to dynamically change themes after clicking a drop down menu of themes - Stack Overflow basically suggests:
$("#stylesheet").attr('href',themeurl);

See it in action.


HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation

Contributed-by: Charles Connell<EMAIL_ADDRESS>FYI @charlesconnell, I had to fix some merge conflicts here so doing it as a PR to let the whole test suite run

Looks fine, but I also had these branches going: https://github.com/HubSpot/hbase/tree/HBASE-28260/branch-3/wal-avoid-local-writes, https://github.com/HubSpot/hbase/tree/HBASE-28260/branch-2/wal-avoid-local-writes

branch-3 was a clean cherry-pick and the UTs all passed locally. Happy to use your branch here if you prefer for branch-2. Either way, I will cherry-pick to branch-2.6 once merged.

Sounds good. Feel free to merge this when ready.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 16s
branch-2 passed

+1 :green_heart:
compile
3m 14s
branch-2 passed

+1 :green_heart:
checkstyle
0m 55s
branch-2 passed

+1 :green_heart:
spotless
0m 44s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
2m 17s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 57s
the patch passed

+1 :green_heart:
compile
4m  3s
the patch passed

+1 :green_heart:
javac
4m  3s
the patch passed

+1 :green_heart:
checkstyle
1m  8s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 26s
Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6.

+1 :green_heart:
spotless
0m 54s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
3m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

38m  2s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5762/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5762

JIRA Issue
HBASE-28260

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 263e4bccd713 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / af94d17d77

Default Java
Eclipse Adoptium-11.0.17+8

Max. process+thread count
80 (vs. ulimit of 30000)

modules
C: hbase-common hbase-asyncfs hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5762/1/console

versions
git=2.34.1 maven=3.8.6 spotbugs=4.7.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 42s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 44s
branch-2 passed

+1 :green_heart:
compile
1m  8s
branch-2 passed

+1 :green_heart:
shadedjars
5m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 47s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 20s
the patch passed

+1 :green_heart:
compile
1m 11s
the patch passed

+1 :green_heart:
javac
1m 11s
the patch passed

+1 :green_heart:
shadedjars
5m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 46s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 51s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 16s
hbase-asyncfs in the patch passed.

+1 :green_heart:
unit
216m  0s
hbase-server in the patch passed.

244m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5762/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5762

JIRA Issue
HBASE-28260

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 5d0405b99f3d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / af94d17d77

Default Java
Temurin-1.8.0_352-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5762/1/testReport/

Max. process+thread count
4253 (vs. ulimit of 30000)

modules
C: hbase-common hbase-asyncfs hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5762/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 52s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 55s
branch-2 passed

+1 :green_heart:
compile
2m  9s
branch-2 passed

+1 :green_heart:
shadedjars
8m 30s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 25s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 29s
the patch passed

+1 :green_heart:
compile
1m 58s
the patch passed

+1 :green_heart:
javac
1m 58s
the patch passed

+1 :green_heart:
shadedjars
8m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m 53s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 17s
hbase-asyncfs in the patch passed.

+1 :green_heart:
unit
212m  0s
hbase-server in the patch passed.

255m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5762/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/5762

JIRA Issue
HBASE-28260

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 7839206b407d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / af94d17d77

Default Java
Eclipse Adoptium-11.0.17+8

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5762/1/testReport/

Max. process+thread count
4495 (vs. ulimit of 30000)

modules
C: hbase-common hbase-asyncfs hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5762/1/console

versions
git=2.34.1 maven=3.8.6

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


optimizations for scorer

Includes optimization for isMatch() and scorer method, as discussed in #20

I see the charcode(i) VS string[i] issue should still happens in the main scoring loop.
I guess a lot of it is bypassed after correcting isMatch and skiping non match.

Ok I'll merge this, but I'll tell you there may be some change to prepQuery.charCodes in the near future.
Namely the dictionary may contain an integer instead of a boolean.
I'm testing a bit parallel algorithm to make a second isMatch that allow a configurable level of error.
(say try to be robust against a single/few character typo or something like that)


Any Intent to support AssistantV2?

@dairan We are going to keep this app on the V1 service for the foreseeable future.  Is there a particular reason why you are interested in pursuing V2 as opposed to V1?

@germanattanasio Any advice in this regard?


feat: support json output

I added a parameter format -f like eslnit, supports passing json and stylish by default is stylish
If json is passed, the output looks like this
[{"file_path":"./test1.js","error_count":0,"warning_count":1,"messages":[{"severity":"Warning","message":null,"line":0,"column":0,"offset":8,"end_line":0,"end_column":16}]}]

Similar to #1555, it's going to be really hard for me to merge a huge PR like this, I need to find a time to architect this feature.

Handled in https://github.com/oxc-project/oxc/pull/2452


Fix x86_64 windows (wac) functionality

It seems like the x86_64 version is hosted on a different endpoint.

This is a duplicate of https://github.com/silentbugs/hon-client-scraper/issues/1

Closing since this is a duplicate of #1.


[otbn, rtl] Qualify secure wipe control signals with secure wipe running

This introduces an extra check for all secure wipe control signals to ensure secure wipe is running.
This still has some work left to do. Smoke tests pass but I haven't run any further tests.
Currently it doesn't trigger any alert when one of the secure wipe control signals is asserted but secure wipe isn't actually running. This could be added.
Finally there's a TODO in the commit that needs attending to.

Thanks Greg for your draft PR. I've taken this as a source of inspiration for #22924. The main differences between your draft PR and my implementation are:

I've flopped secure_wipe_running_o inside the start stop controller to ensure we have separate drivers for the signals we want to protect and the signal we check against. This allows reducing the code changes as we don't need to introduce prim_bufs.
Instead of qualifying, my PR does a comparison and flags an error in case of mismatches. The error is factored into the fatal internal error signal (already factors in a different secure wipe error around spurious secure wipe ack detection).
Also the flopped signals used for wiping GPR and WDRs with zero or URND inside otbn_core are now protected. This is also pretty critical in my view.

Superseded by @vogelpi's work: https://github.com/lowRISC/opentitan/pull/22924


All keys released when any key of group released in action_is_pressed

Godot version:
v3.1.alpha.custom_build.37c5aa1
OS/device including version:
Arch Linux up-to-date
Kernel 4.18.16-arch1-1-ARCH
Issue description:
When checking for input press with Input.is_action_pressed and the action has a group of keys, if you press more than one of the key of the group, it will return true. However, if you release only one of them, the statement will return false, as if all of them has been released.
Steps to reproduce:

Open the Minimal reproduction project below.
Run the main scene.
Press W and keep it pressed. Both W and Any labels will be shown.
Press S and keep it pressed, without releasing W. W, S and Any labels will be visible.
Release W while keeping S pressed. Instead of hiding W label and keeping S and Any visible, all labels will be hidden, as if all keys of the group has been released.

Minimal reproduction project:
Issue.zip

I can reproduce this on commit https://github.com/godotengine/godot/commit/12482bf8840ce2fa84d6eea7999628be426cba8d.

See #30888


Clean up of std.uni (part 2)

Removes all total, non-global imports and replaces them with selective imports
encapsulates a unsafe subtraction from size_t

Wow seems like std.uni get's a lot of love recently!
LGTM!

After reading the code more, I realized that the check was redundant, so I dropped it.

LGTM

Auto-merge toggled on

Thanks!


item slot must have only one child

When i put a code comment in the Draggable component slot, it will throw error.

I think the comments shouldn't be include.

same issue

you have to use the name element or else it is not working correctly - I created a PR (#171) to add this to the docs.
if you want to use a custom variable name you can do #item="{ element: item }"

It considers your comment to be part of the div. I had the same issue and deleting the comment fixed it.

因为注释也被当成了元素


Support for num-modular

The support for num-modular might need to be coordinated with the progress of that crate.

The implementation of fast div should be moved to the num-modular crate.
Then the support for num-modular should be implemented for UBig (and IBig).
Then the support for num-order::NumHash can be implemented for FBig and RBig.

Finished in v0.4


dropdown widget prevents shift-enter from working

doing using Interact; dropdown(["one","two","three"]) in IJulia, and then changing the dropdown selection, seems to make IPython ignore shift-enter in subsequent cells; or rather it treats it just as "enter"  and inserts an ordinary newline in the cell.
(I can still run subsequent cells, but only by clicking the "run" button in the toolbar.
So, somehow the dropdown widget seems to be altering IPython's keybindings.  (@Carreau?)

I have just encountered the problem. Very annoying because you need to shutdown your notebook and restart it (the refresh does not solve the problem for me)
I can confirm that with

IPython 2.2.0 and firefox 34.0.5
IPython 2.3.1 and firefox 35.0

once the dropdown widget has been used, there is no way to use anymore the shift-enter keys to run a cell. The only way left is to use the run icon.
Note that with google-chrome it works correctly.
Any idea ?

Seems to be fixed on IPython 3.0


APT repository has bad hash metadata

Our mirroring tool fails because the file contents hash don't match the metadata:
failed to download package 60c3b935404f79ff3ea84e7be86523501de474dfa20ebf6ac7c05e211d684935 from URL http://packages.microsoft.com/repos/vscode/pool/main/c/code-insiders/code-insiders_1.14.0-1496812357_amd64.deb: hash mismatch for http://packages.microsoft.com/repos/vscode/pool/main/c/code-insiders/code-insiders_1.14.0-1496812357_amd64.deb: got 1b2e12c96927eb6437a4dbb5c40d6f6431812dc9372b265bb30f4f93396247d6; expected 60c3b935404f79ff3ea84e7be86523501de474dfa20ebf6ac7c05e211d684935
I think maybe you need to regenerate the hashes(?).

Thanks for the report, I notified the team we submit the packages to. I published a new version so I think the problem should be resolved.

This is not fixed.  Repro:

download http://packages.microsoft.com/repos/vscode/pool/main/c/code-insiders/code-insiders_1.14.0-1496812357_amd64.deb and http://packages.microsoft.com/repos/vscode/dists/stable/main/binary-amd64/Packages

$ sha256sum code-insiders_1.14.0-1496812357_amd64.deb
1b2e12c96927eb6437a4dbb5c40d6f6431812dc9372b265bb30f4f93396247d6  code-insiders_1.14.0-1496812357_amd64.deb

$ egrep 'Filename|SHA256' Packages | grep -A 1 code-insiders_1.14.0-1496812357
Filename: pool/main/c/code-insiders/code-insiders_1.14.0-1496812357_amd64.deb
SHA256: 60c3b935404f79ff3ea84e7be86523501de474dfa20ebf6ac7c05e211d684935

@evmar I'll forward this to them thanks.

It appears this is fixed.


maps_in in the graph?

Hi,
I'm trying to extract some intermediate values from the model. The graph requires 3 inputs, as listed by Gs.list_layers() and Gs.input_names:
('latents_in', <tf.Tensor 'Gs/latents_in:0' shape=(?, 17, 32) dtype=float32>, [])
('labels_in', <tf.Tensor 'Gs/labels_in:0' shape=(?, 0) dtype=float32>, [])
('maps_in', <tf.Tensor 'Gs/maps_in:0' shape=(?, 16, 256, 256) dtype=float32>, [])

latents_in is the sampled z vector, and it appears labels_in is not required (the last dimension is 0). However, I'm not able to understand what maps_in is. How can I get maps_in?

Hi, Thank you for the interest in the work!
I have couple deadlines over the next days so will definitely try to get back to you by the end of the week!

Hi, apologies for the large delay in my response and thanks so much for raising that point!
maps_in refers to a unused remnant that stayed in the pickle and doesn't impact the model's behavior. I recommend loading the model using --recompile and then it should save a new snapshot that doesn't have the field. I will also update the checkpoints to not include that unnecessary field!

Just thought to update I updated the pretrained networks files to match the source code so maps_in doesn't appear anymore!


Office 365 ATP automated investigation events

Docs Build status updates of commit 6f88743:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

office-365-management-api/office-365-management-activity-api-schema.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add a comment describing the code explorer shortcoming

The goal is to avoid letting people think that this is the generic way to access the file storing a template, because it is not.

I like this help note!  Merged. Thanks.


[ongoing] rewrite web module to spark java

Web module runs on spring boot. I am currently working on porting it to spark java. I might need to change the Main class to not render the freemarker template itself but to instead return the template name and model so spark can render it.

This will affect the output handler which is now terribly non pure. It should return the template and model

fixed and merged


Website mentions npm run

http://electron.atom.io/ mentions npm install && npm run, but npm run is not a thing :) Should be changed to npm start.

Duplicate of https://github.com/atom/electron-quick-start/issues/5

My bad, wrong npm script in my head. Closing here and fixing on the website 👍 Thanks!

🔗 https://github.com/atom/electron.atom.io/commit/ca6866da2ff700a07c5735843740d989ca293e10


Chat can't be scrolled

I tried making overflow: auto but didn't help.

Fixed in commit cf8450c .


Failed to implement COM interface in v0.56

Summary
error[E0433]: failed to resolve: could not find windows_core in the list of imported crates
--> tests\event_test\src\lib.rs:4:1
|
4 | #[implement(IUIAutomationEventHandler)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ could not find windows_core in the list of imported crates
|
= note: this error originates in the attribute macro implement (in Nightly builds, run with -Z macro-backtrace for more info)
Crate manifest
[package]
name = "event_test"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies.windows]
version = "0.56.0"
features = [
    "implement",
    "UI_UIAutomation",
    "Win32_UI_Accessibility",
]

Crate code
use windows::core::*;
use windows::Win32::UI::Accessibility::*;

#[implement(IUIAutomationEventHandler)]
pub struct MyEventHandler {
}

impl IUIAutomationEventHandler_Impl for MyEventHandler {
    fn HandleAutomationEvent(&self,sender:Option<&IUIAutomationElement>,eventid:UIA_EVENT_ID) -> windows::core::Result<()> {
        todo!()
    }
}

See #2917


[5p] [Documentation] Document Feature Traces

Ideally, a developer could run the agent with the lowest verbose mode and with only the Integration Feature Trace enabled in order to “trace” the execution of an integration. => “Developer mode”

[ ] Public and repository docs
[ ] Prepare small Troubleshooting session for GTS

Closing it in favor of https://github.com/newrelic/infrastructure-agent/issues/1086


Can't add more properties

I love this plugin but am encountering an issue. I've already used it to annotate much of my design, however now when I go to get properties of something, nothing happens. I use  ⌃ + ⇧ + 4  and the box for properties does not appear at all. It doesn't work when I go to the plugins menu rather than using the shortcuts either.
I'm attaching a gif showing that I'm able to get the size of an element but not the properties.

I'm finding this just happens randomly. I got it working again.

world you share your .sketch file let me test

Unfortunately no, cause that could get me in trouble at work. Sorry.

On Aug 20, 2015, at 6:25 AM, utom<EMAIL_ADDRESS>wrote:
world you share your .sketch file let me test
—
Reply to this email directly or view it on GitHub.

You have to try new update plugin and test. Maybe is working


Add dynamic GOROOT setting for zsh

Uses the same approach as the Java plugin (https://github.com/halcyon/asdf-java#java_home) to set the GOROOT env variable before commands, so no manual setting is necessary.
I've only implemented zsh right now, but could add bash, fish, xonsh, etc.
Partially fixes #28  – not sure if this plugin should set GOPATH

thank for your script, i made it a little faster by a small change
asdf_update_golang_env() {
  local go_root
  go_root="$(asdf where golang)"
  if [[ -n "${go_root}/go" ]]; then
    export GOROOT
    GOROOT="${go_root}/go"
  fi
}

autoload -U add-zsh-hook
add-zsh-hook precmd asdf_update_golang_env

the PR has been pending almost 2 years now :O (and the issue has been active for 3 years)

Thank you for merging and your ongoing maintenance 🎉


Added description of the new concept mapping, fixes #32

coverage: 100.0%. remained the same
when pulling 321b962c11b9c65fe31a36215af9db77cb2055e5 on pint_units_for_concept_mapping
into 8070bd82d5b7a0b2988ceb52f05d2aa9eb2c3ea7 on main.


coordinate pixel access for raster tile

Pull Request Test Coverage Report for Build 530378629

59 of 62 (95.16%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 80.865%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

datatypes/src/raster/raster_tile.rs
59
62
95.16%

Totals

Change from base Build 527869167:
0.1%

Covered Lines:
12213

Relevant Lines:
15103

💛  - Coveralls


Show values of primitive placeholders

Is your feature request related to a problem?
There's currently no easy way to show the value of primitive placeholders.
Desired solution

Code lenses "Compute xy"/"Refresh xy"
Show the result in the output tab?
Show the result as inlay hints after the terminating semicolon of an assignment?

Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
No response

:tada: This issue has been resolved in version 0.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
v0.13.0
GitHub release

Your semantic-release bot :package::rocket:


Support detecting cl.exe in vs2019

Use setuptools.msvc instead of distutils.msvc9compiler to detect cl.exe

Thanks @eternalphane!
It looks nice to discover VS2019, however I'm concerning that CUDA 10.0, which is still in our supported CUDA version, does not support VS2019.
https://docs.nvidia.com/cuda/archive/10.0/cuda-installation-guide-microsoft-windows/index.html
Let me try your patch on CUDA 10.0 environment later.

Could you fix the comments here as well?
https://github.com/cupy/cupy/blob/b01641dedb065f65a4d3f846cf3c6222693a8e44/cupy/cuda/compiler.py#L54-L56
the VC++ compiler used to build Python / CuPy to the PATH -> the latest VC++ compiler found via setuptools

I've tookover the work in #6025.


bookstack: Article titles ending with ".js" result in a 404 error

Describe the bug

When an article title ends with ".js", as in "Getting started with Node.js", then the generated URL will never load; it will always return a 404 error, and show in the error log as a failed attempt at opening a static file. It seems that the included nginx config matches a bit too generously on static asset extensions.
Steps To Reproduce
Steps to reproduce the behavior:

Set up Bookstack via nixpkgs module and let it handle the nginx configuration, standard setup.
Create an article whose title ends with ".js"
Save the article, which attempts to load the article and produces a 404

Expected behavior

Should show the article correctly.
Screenshots

Additional context

Metadata

Cannot run metadata command for unclear reasons, but the system is running NixOS 24.11 deployed via Morph.
Notify maintainers

@ymarkus

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Should be fixed by #363581.


Icon request: login.gov

URL of the site or app (required): https://login.gov/
Logo resources for the icon (optional, but recommended): https://login.gov/assets/img/logo.svg
Hex color of the main brand color (optional): #112E51

Done :)
https://github.com/krisu5/aegis-icons/blob/master/PNG/login.gov.png


1.21.1 not showing up

I just downloaded the seedcracker and when I launched it, 1.21 or 1.21.1 was not showing up. So I checked here if any had similar issues they did (post by Ghost942), I followed their steps but when I checked the file they both said 1.21.1 and when I loaded the seedcracker in game it only displayed up to 1.20.2. Any know the issue?

I have the same problem


Can not load model

There is an Error: http.client.RemoteDisconnected: Remote end closed connection without response
Code:
net = torch.hub.load("chenyaofo/pytorch-cifar-models", "cifar10_resnet20", pretrained=True)
Environment:
Pytorch 1.11

This maybe an network issue. I test the above code just now and it works well.
Thanks for your feedbacks. I an going to add some proxy tricks to make it can be accessed by those users with network issues.

There is a solution, I think it can help you.
import torch
import torch.hub as hub

def patch_hub_with_proxy():
    download_url_to_file = hub.download_url_to_file

    def _proxy_download_url_to_file(
        url: str,
        *args,
        **kwargs
    ):
        if url.startswith("https://github.com"):
            cdn_url = "https://ghproxy.com/" + url
            return download_url_to_file(cdn_url, *args, **kwargs)
    hub.download_url_to_file = _proxy_download_url_to_file

    def _git_archive_link(repo_owner, repo_name, ref):
        return f"https://github.com/{repo_owner}/{repo_name}/archive/refs/heads/{ref}.zip"
    hub._git_archive_link = _git_archive_link

patch_hub_with_proxy()

net = torch.hub.load("chenyaofo/pytorch-cifar-models", "cifar10_resnet20", force_reload=True, pretrained=True)

print(net)


added count unique lines

added count unique lines, please review

@CowCompanion let's add a separator character between the count and the line text.
Use :


Update the scoreboard after the first match was finished

Open: Calculation and Display of Score to be designed.

Done with #130


Customizing pull request title and commit messages

Hello again @VBeytok @andrii-bodnar, and @Bartlebyy 👋
I just created a new workflow with this Action and it created a PR with the title New Crowdin translations by Github Action. This is clear enough (and it worked on the very first try with over 35,000 files 😍), but I'd like to be able to configure it so my project's commit messages and the pull request title are semantic, like feat: new Crowdin translations.
Is it possible to configure this in the Workflow? If not, consider this a feature request! :)
cc @alebourne

Hello @zeke :wave:
We are happy to hear that you like this GitHub Action. Customizing pull request title and commit messages it's a great feature request!
Thank you for the suggestion!


saving files from URLs in emails

Is your feature request related to a problem? Please describe.
Some companies send URLs for download instead of the actual file (pdf) itself.
Describe the solution you'd like
I'd like the option for this URL to be extracted and the file saved to Google Drive

@chrismazanec thanks for this feature request, it sounds like a good feature to be added. :-)
The interesting part would be how to detect the relevant URLs to be downloaded (e.g. using a regex) without downloading each and every URL and how to deal with possibly multiple matching URLs.
Maybe you can describe your use case a bit with more details to better understand how this should work.

@ahochsteger this works /(https?:\/\/[^\s'"<>]+)/g for matching all URLs. relevant ones could be filtered/limited using extra var/regex, limiting the URLs to be downloaded. by default, all URLs could be downloaded (excluding duplicates).
the use case is for invoicing - a company sends a link to download the invoice instead of the actual attachment. successful download with curl requires setting the user agent to desktop browser.

@chrismazanec, would it be possible for you to test the PR #144 which implements the feature you requested?
You can use the script ID 1yhOQyl_xWtnGJn_bzlL7oA4d_q5KoMyZyWIqXDJX1SY7bi22_lpjMiQK and version 124 of the Gmail Processor Lib in Google Apps Script that points to a development snapshot containing these changes.
When you confirm that it's working, I'll merge the PR and create a new release.

I got to test this, and it works beautifully, thank you for your hard work!  🙏 (even better than I imagined)


Interface to configure cronjobs or something similar

Hi!
Would it be possible to add a file to addon_config in which we can configure cronjobs for the paperless user like running the document_export?
Best,
Paul

Why not using home assistant automation?

So far mainly because I could not figure out how to:D See https://github.com/BenoitAnastay/paperless-home-assistant-addon/issues/196#issuecomment-2496158468


Nominator: Be more verbose when we are not nominating

This should help better debug the reason(s) why a node is not nominating.
Currently we only see a bunch of 'Nominating X at Y" but nodes can get stuck.

Fixed method name


Join stake pool endpoint (part 1 - no signCert impl)

Issue Number

#896
Overview

[x] I have added pools check in endpoint
[x] I have added createCert
[x] I have added submitCert
[x] I have added computeCertFee
[x] I have added test and adapted other tests affected

Comments

In the forthcoming PR I will tackle signCert impl (waiting here for mkDelegationCertTx to find its way into master first)

@paweljakubas do you think of any way to split that PRs into smaller ones that aren't dependent on other PRs?
In particular, I think that the whole API part could be merged already if we replaced the wallet engine function implementations by error "createCert: not implemented".
What do you think?

doing a 3rd round of review

bors r+


CURL Timeout

Greetings!
I am trying to track down the timeout settings for CURL. I cannot seem to find a number value, or at least one I understand :)
At times the CURL seems to timeout fairly fast, like to up the timer.
In CurlRequest.php see this:
    protected int $connecttimeout = 0;

    protected int $timeout = 10;

Are these the setting I am looking for?
Thank you!

Hello,
Sorry it s difficult to have acces to internet thoses Last week.
You can change the timeout value in the config file.
Regards

Thank you for reply.
I must be using an older version; the timeout is not in config file. Mine is like:
<?php
return [
    'apiKey' => getenv('OPENAI_API_KEY'),
    'downloadDir' => __DIR__ . '/../download',
    'serializeDir' => __DIR__ . '/../serialize'
];

Have made mods for classroom use and need to keep all my mods. Can I simply add the timeout to my config, or are there other files I must modify?

Hello,
Look the current code :
config/conf.php
Regards

Ok, as I stated we have modified your release before you added the option to config file. I simply asked:
"Have made mods for classroom use and need to keep all my mods. Can I simply add the timeout to my config, or are there other files I must modify?"
Anyway, thanks for your help.

Hello,
You can hardcode the value in the curling class or change the value in the ajax file.
https://github.com/EasyGithDev/PHPOpenAI-Playground/blob/main/public/imagine.php
Look at line 73.
In all case, it s better to add the value in the config file.
Regards

I forgot to thank you and close. Closing now:)


Use multi-episode player link.

Description
This swaps out the player URL so multiple episodes will appear; the original embed was using the single episode player.
Reviewer Notes
The player should automatically show new episodes after this gets deployed.
Screenshot

I apologize for not getting this into the original PR, I didn't realize there were different embed links.


Add a plan for the interface(s)

As it's been discussed quiet a few times we will need a plan for the interfaces in order to replace CubeGui with CEF.
@aschaeffer and I did agree that this should be split up into different components, that are listed below:

a HUD component that should be really BARE (since it is always rendered)
a lightweight menu component, that is responsible for in-game menus (the thing that appears when you press "ETC", that renders the loading screen (...)
the main component that includes settings, master list, repository manager (...), which does already have a repository @inexor-game/interface

Related:
#312
#98

Related:
#342
https://github.com/inexor-game/code/wiki/User-interface-Menu

All of the above now are in work and have independent tickets. Closing this.


Knowledge Quest Teams Bot

Q
A

New sample?
yes

What's in this Pull Request?
This PR contains bot sample for Knowledge Quest Teams Bot, an interactive Chat Bot application designed to allow users to test their knowledge on specific topics using the power of OpenAI.
This solution is awarded as the Best AI-powered solution during Microsoft Teams Global Hack 2023.

Works like a charm thanks @nanddeepn  and team <3

@BobGerman  sample reviewed and template added. Ready for final review and merge.


kitty: 0.11.3 -> 0.12.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build kitty

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: kitty
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: kitty
Partial log (click to expand)
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fmsh7048dx2g4r545lwadjq28wkh818v-kitty-0.12.0/lib  /nix/store/fmsh7048dx2g4r545lwadjq28wkh818v-kitty-0.12.0/bin
patching script interpreter paths in /nix/store/fmsh7048dx2g4r545lwadjq28wkh818v-kitty-0.12.0
/nix/store/fmsh7048dx2g4r545lwadjq28wkh818v-kitty-0.12.0/lib/kitty/kitty/launcher/kitty: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/hy65mn4wjswqih75gfr6g4q3xgqdm325-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/fmsh7048dx2g4r545lwadjq28wkh818v-kitty-0.12.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/874xh4svba6wp7bwiiw32cixkh3g4n3a-kitty-0.12.0-terminfo
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/874xh4svba6wp7bwiiw32cixkh3g4n3a-kitty-0.12.0-terminfo
checking for references to /build in /nix/store/874xh4svba6wp7bwiiw32cixkh3g4n3a-kitty-0.12.0-terminfo...
/nix/store/fmsh7048dx2g4r545lwadjq28wkh818v-kitty-0.12.0

Success on aarch64-linux (full log)
Attempted: kitty
Partial log (click to expand)
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xj8nvxjfhkrxyw9cdkqb5h31vg50617s-kitty-0.12.0/lib  /nix/store/xj8nvxjfhkrxyw9cdkqb5h31vg50617s-kitty-0.12.0/bin
patching script interpreter paths in /nix/store/xj8nvxjfhkrxyw9cdkqb5h31vg50617s-kitty-0.12.0
/nix/store/xj8nvxjfhkrxyw9cdkqb5h31vg50617s-kitty-0.12.0/lib/kitty/kitty/launcher/kitty: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python3"
checking for references to /build in /nix/store/xj8nvxjfhkrxyw9cdkqb5h31vg50617s-kitty-0.12.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/cmiqmq73qwa2j1gj001m3q3icdfcb7nr-kitty-0.12.0-terminfo
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/cmiqmq73qwa2j1gj001m3q3icdfcb7nr-kitty-0.12.0-terminfo
checking for references to /build in /nix/store/cmiqmq73qwa2j1gj001m3q3icdfcb7nr-kitty-0.12.0-terminfo...
/nix/store/xj8nvxjfhkrxyw9cdkqb5h31vg50617s-kitty-0.12.0


Line info missing for JsonSerializationException

When JsonSerializationException is thrown, there is line info within the error message, but not in the exception itself. So we need to parse the error message to get the line info.
If we take a look at JsonReaderException, line info is presented in the error message, and also exposed in the exception properties.
Much appreciated if we can have the similar implementation of JsonReaderException for JsonSerializationException.

Good suggestion. Done


[c-interop] Make Extern a suppressible language feature

Fixes building the standard library's .swiftinterface with older Swift compilers.

Addresses regression from https://github.com/apple/swift/pull/69352.

@swift-ci please smoke test

@tshortli Thank you for fixing this :pray: I don't know when older compiler parses newer stdlib's module interface, but is it safe to change the symbol name depending on whether the compiler supports the feature?
Looks like other suppressible language features are not ABI-affecting features but @_extern is.

If @_extern here affects the ABI of something that was existing and therefor users in this configuration might actually depend on then I suppose your concern is valid. If that's the case I'm afraid we need to revert https://github.com/apple/swift/pull/69352 and go back to the drawing board with how to implement it in a way that does not break the stdlib interface for older compilers.

Thanks for your detailed explanation. Those functions attributed with @_extern are only referenced from debugger, so hopefully it just breaks LLDB's language swift refcount command. To avoid the breakage, I think the safest way would be to keep the old wrong (but works on most platforms) way like below:
#if compiler(>=5.3) && $Extern
@_extern(c, "swift_retainCount") @usableFromInline
#else
@_silgen_name("swift_retainCount")
#endif
internal func _swift_retainCount(_: UnsafeMutableRawPointer) -> Int

It looks to me like the functions that gained @_extern(c) in https://github.com/apple/swift/pull/69352 are only the retainCount family of functions, which are only ever used from the debugger right? If that's the case, I'm inclined to say that it's unfortunate but not a showstopper that they be broken in the configuration where an older compiler is being used. However, we should fix this properly in a follow up. It looks to me like maybe a proper fix for this would be to print the @_silgen_name(<name>) attribute instead of @_extern(c, <name>) for the branch where the @_extern attribute is not supported. Does that make sense? It seems like it would return things to the status quo from before https://github.com/apple/swift/pull/69352.

It looks to me like the functions that gained @_extern(c) in https://github.com/apple/swift/pull/69352 are only the retainCount family of functions, which are only ever used from the debugger right?

Yes, that's correct.

If that's the case, I'm inclined to say that it's unfortunate but not a showstopper that they be broken in the configuration where an older compiler is being used.

Yeah, that's reasonable. If it's not critical path, I think we can accept the breakage.

It looks to me like maybe a proper fix for this would be to print the @_silgen_name() attribute instead of @_extern(c, ) for the branch where the @_extern attribute is not supported. Does that make sense?

Hmm, they have slightly different ABI semantics and we can expect there is no other usage of @_extern except for stdlib at the moment, so falling back as a part of compiler output might be too much.

@swift-ci please smoke test macOS

@swift-ci please smoke test Linux

@swift-ci please smoke test


Added Batch Videos & OS Cleanup

Feature: Added batch_videos.py which can batch process a directory of video files into ready to run sh/bat automation files ready for further processing along with auto convert_fbx.py. A class has been created to be used if needed.
Chore: cleaned up convert_fbx.py so Windows & Unix paths are present if the pipeline needs it.

Great work!


Added .gitignore rules and files with fixed line endings

Added rules to include Juriscraper internal libraries path and ignore configuration files for pipenv and VSCode.
Also, fixed line endings for HTML files for automated tests.
#410

Thanks.


fix: remove format extension for public-id

Resolves
Issue #22, i.e. publicId getting malformed in case it contains "."-char other than as part of extension
Technical note
I removed it completely because I think it is not taking effect anyways, due to the explicit "f_[format]" transformation that is applied later on (https://github.com/mayashavin/cloudinary-api/blob/main/packages/url/lib/url.ts#L127)
E.g., If I take the url from the sample

https://res.cloudinary.com/adacmkv/image/upload/f_auto,q_auto/v1608641937/ADAC Klassik/2021/Events/AEC/RS134993_RS129423_8.1_v7gpvg.jpg

even with auto-format (aka f_auto) this will result in content-type image/web_p being downloaded in most modern browsers, despite the .jpg extension that is part of the publicID.

From my understanding the file-extension is only taken under consideration if there is no format-option present, wich will never be the case here?

Looks great. Thanks for contributing ❤  and sorry for the late review :)


verific license question

Hi Guys
I wish to use verific as a frontend for yosys.
I wonder if i need the :

"RTL elaboration" license
Simple parsing license is enough and yosys doing the elaboration by itself ?
By reading the verific frontend code it seems that verific already "boolianized" the RTL so it is probably option 1.

Thanks!

Yes, you need an "RTL elaboration" license.


Can’t assign to member of type that uses generic parameter, though member is assignable to same type

Bug Report
🔎 Search Terms
assign member of generic variance
🕗 Version & Regression Information

This error changed between 3.9.7 and 4.0.5; v3 says ‘0’ is not assignable instead of ‘number’ is not assignable.
Nightly version at time of test: v5.0.0-dev.20230126

⏯ Playground Link
Playground link with relevant code
💻 Code
type AllNumericAttributes = {[index: string]: number};
declare function takesNumber(arg0: number): boolean;
export const zeroOutNumericAttributeNoGeneric = function(
    vector: AllNumericAttributes,
    selectedAttributeName: string,
) {
    takesNumber(vector[selectedAttributeName]);
    vector[selectedAttributeName] = 0;
    return vector;
}
export const zeroOutNumericAttributeUsesGeneric = function<T extends AllNumericAttributes>(
    vector: T,
    selectedAttributeName: keyof T,
) { //sometimes we need T as a generic to constrain other parameters, return type, etc.
    //TS can figure out vector[selectedAttributeName] is a number for reading, but not writing:
    takesNumber(vector[selectedAttributeName]);
    vector[selectedAttributeName] = 0; //Err: 'number' is not assignable to type 'T[keyof T]'
    return vector;
}

🙁 Actual behavior
Can't assign a number to what static analysis should be able to determine is, in fact, a number, though the analysis can determine that it is a number for the purpose of assignability to a function parameter.
🙂 Expected behavior
No error here; can assign a number to a numeric type even when a generic type parameter is involved in determining that type.
I tried many versions of this, including other ways of specifying what the attributes were instead of by an index type, and this was the simplest version that demonstrated inability to assign.

This is a correct error; it is factually the case that vector[selectedAttributeName] is not necessarily assignable from number. In other words, you could have written
const p: { n: 3 } = { n: 3 };
zeroOutNumericAttributeUsesGeneric(p, "n");

Darn. I oversimplified an issue to the point of incorrectness, seeing that the issue was retained as simplification progressed but failing to complete analysis about the direction of extends testing on the final step.  Will have to try again.


Parallel part

We need to check the parts for the parallel computing toolbox on the scm

SCM only has R2013, the interactive servers don't have the parallel toolbox. :-/

mymatlab_compiler has parallel toolbox

Transfection and conversion example working with  675d93a on R2015b.