Add IsNull to nint/nuint based structs for handle == IntPtr.Zero checks

Is your feature request related to a problem? Please describe.
This pattern is used extensively to check if a handle is valid.
Describe the solution you'd like
We add this or similar via a partial to multiple classes.
public bool IsNull => Value == nint.Zero;

Describe alternatives you've considered
IsValid could be another name for it.

Looking at HANDLE, I see it already has a static Null property and an instance IsNull property.
 But nint isn't necessarily a handle or pointer, so 'null' isn't a concept that directly applies to it.
Are there structs that are backed by nint that should rather be treated like handles (thus backing with IntPtr)? Can you name some so I can look into it?
Yes, yes, I know that syntactically IntPtr and nint is nearly identical nowadays. But IMO it's useful to maintain the semantic distinction.

I think I am repeating myself without realizing I think we looked into it in #610.
Examples:

HIMC
HKL

I think we closed it previously because we wanted to be sure something was a handle vs just a pointer. So anything that was annotated as a handle already has the IsNull property.

Yes, yes, I know that syntactically IntPtr and nint is nearly identical nowadays. But IMO it's useful to maintain the semantic distinction.

This came up in the #csharp-lang-design channel in https://aka.ms/dotnet-discord. When some of us were making this point about a semantic distinction, one of the language design team members said:

No, it's literally not a meaningful distinction. It will be normalized for display. It's like int vs Int32.

Thanks for sharing, @jnm2. I guess I'll just have to accept that.
Still, if we can tell from the metadata that a one typedef struct represents a pointer and another doesn't, I think it's fair to use that as an indicator to add IsNull in one case and not in another.
After all, a handle could legitimately be 0 and still be valid, while a pointer couldn't be 0 and valid. So adding IsNull in both cases could lead to misuse as code assumes IsNull means it isn't valid, but for an opaque handle type, that isn't true.

Duplicate of #610.


Test issue

This is a test issue to demonstrate the feature branch lifecycle.

See feature/1_test-issue.


Avoiding empty blocks

Hello!
It leads to syntax errors if there are empty blocks '{ }' in graphql requests. There will be an empty block in your request if you create a mutation with no response defined. In this case you have one property (mutation's name) with several arguments but no children.
For example:
An empty class defining the mutation request:
 @GraphQLProperty(name="myMutation", arguments={         @GraphQLArgument(name="myArgument1"), @GraphQLArgument(name="myArgument2")     }) public class MyMutationModel {}
Creating the request:
GraphQLRequestEntity requestEntity = GraphQLRequestEntity.Builder()     .url("http://graphql.example.com/graphql").     .arguments(new Arguments("myMutation",         new Argument("myArgument1", "value1"), new Argument("myArgument2", "value2")))     .request(MyMutationModel.class)     .build(); GraphQLResponseEntity<Boolean> responseEntity = graphQLTemplate.query(requestEntity, Boolean.class);
The created request would look like this:
mutation {myMutation(myArgument1:"value1", myArgument2:"value2") { } }
But a vlid request has to look like this:
mutation {myMutation(myArgument1:"value1", myArgument2:"value2") }
I think it would be a good idea to prevent empty blocks from being created in general. Because Property.class' member variable "children" is an empty map, at least in this case, it is very likely that empty blocks will be created.
My little modification would fix this behaviour. Or is there another way to deal with requests like this?
Cheers,
Christian

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.chass seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Pull Request Test Coverage Report for Build 43

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.71%

Totals

Change from base Build 28:
0.0%

Covered Lines:
459

Relevant Lines:
465

💛  - Coveralls

Pull Request Test Coverage Report for Build 43

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.71%

Totals

Change from base Build 28:
0.0%

Covered Lines:
459

Relevant Lines:
465

💛  - Coveralls

Looks great, thanks for this contribution!

Thank you for accepting this change! Could you tell me, when the next verson will be released and will be available in the repository?
Thanks, Christian

@mrchass just released v0.1.2 the fix should be available now!


Determination Templates Not Implemented

Describe the bug
There is functionality for the user to add determination message templates but those templates are not imported when the user creates a determination for an application.
To Reproduce

Create determination template messages.
Add a determination to an application.

Expected behavior
I expect that those determination template messages would populate the text editor.
Priority

Low priority (annoying, would be nice to not see)

Affected roles

Staff
Reviewers

Additional context
Patch inbound.

Related to https://github.com/HyphaApp/hypha/issues/2080

I think it is fixed with issue #2809.

Correct, closing now.


Add travis to CI list

Hi all,
Autotester is great and getting such a wide coverage with free tools is quite hard, however there are great tools like travis out there which run reliable and could assist your PR workflow.
It runs for every commit and PR reliably the unittests on a Linux 64bit machine and on OSX. On every forced push it runs again, too. Everyone can immediately see/follow the entire log.
It takes ~15min for both builds to complete.
You can see an example build here:
https://travis-ci.org/greenify/phobos/builds/111955286
I assume that you all are familiar with travis - it's probably the most popular ci service out there and has a lot of other features in case they might be needed.
PS: If you decide to merge this, don't forget to add travis to the hooks list.

DMD also uses a similar setup - maybe @MartinNowak can push Travis testing forward for Phobos?

@klickverbot

Duplicating this on Travis for no good reason seems like a waste of their resources.

My experience from the CI results of autotester over the last two weeks is that its mostly on pending (as you can see here) and travis will run smoothly -> usually a good & fast feedback (failing tests, correct style e.g. no trailing whitespaces ...)

I agree with @klickverbot here, let's not another CI that tests the same thing, it will just incur more maintenance cost w/o providing any benefit.
We can't replace the auto-tester b/c of all the other platforms we're testing.
A big delay in the auto-tester is caused by a lack of github hooks, sth. that is relatively easy to fix.

A big delay in the auto-tester is caused by a lack of github hooks, sth. that is relatively easy to fix.

Okay I do agree, but it would be nice to have that. I filed an issue for this:
https://issues.dlang.org/show_bug.cgi?id=15746


Issue to play mp4 file with new 10.4.2 Alcinoe components

Hi.
I have an issue  with my Delphi 10.3 project when I run it on 10.4.2 with new Alcinoe components. On 10.3 my mp4 file was played good, video and sound. On 10.4.2 same file plays only sound and on shows when picture on playSurface.
New alcinoe components was installed succefuly. Update.bat was runned, pathed files was added to source path. jar filed in project was replaced by new 10.4.2. version.
How to fix this issue?

hello yarpa, can you try to play the mp4 on the demo app (alfmxControls). on with OS? android or iOS?

hello yarpa, can you try to play the mp4 on the demo app (alfmxControls). on with OS? android or iOS?

Ок. I will try. Android OS. Will reply later.

I tryed to compile that project on another computer with 10.4.2 components, and its works fine. I think this is some local problem. Thanks, issue is solved.


sensors: Add driver for Vischay VCNL36825T Proximity Sensor

Base driver without power management and interrupt support.

@MaureenHelm: I finished trigger support today, should I add the code to this pull request, or is a separate more suitable?

I finished trigger support today, should I add the code to this pull request, or is a separate more suitable?

Separate, please

I tested the driver on a custom board based on a Nordic nRF 52840 with this sensor used for proximity measurements which we need to detect proximity against an immobile target.


bootstrap script not working on latest npm

Bug report
The bootstrap script no longer works with the latest npm due to https://github.com/npm/cli/issues/4552.
A temporary workaround is being added to the CI to use an older version https://github.com/open-rmf/rmf-web/pull/598. The old version can be reverted once the bug is fixed in npm.

when does this bug fixed? Is there another way to use rmf-web?

This should have been fixed on main branch, do you still have it?
also a work around for now is to use an npm version older than 8.4

This should have been fixed on main branch, do you still have it? also a work around for now is to use an npm version older than 8.4

My situation:bootstrap script can work on latest npm right now ,but "cd rmf-web/packages/dashboard" and "npm start" no work
like this:

:thinking: could you maybe write the exact commands that you are using in each terminal?
and in the dashboard package, does running npm run build before the npm run start get you any different result?

thinking could you maybe write the exact commands that you are using in each terminal? and in the dashboard package, does running npm run build before the npm run start get you any different result?

1>cd rmf-web-main && cd scripts && ./bootstrap.sh (1st terminal)

2>ros2 launch rmf_demos_gz office.launch.xml server_uri:="ws://localhost:8001" (2nt terminal)

3>cd rmf-web-main/packages/dashboard && npm run start (3rd terminal)

result:
[start:rmf-server] from tortoise import Tortoise
[start:rmf-server] ModuleNotFoundError: No module named 'tortoise'
[start:rmf-server] npm ERR! Lifecycle script start:rmf-server failed with error:
[start:rmf-server] npm ERR! Error: command failed
[start:rmf-server] npm ERR! in workspace<EMAIL_ADDRESS>[start:rmf-server] npm ERR! at location: /home/dch/rmf-web-main/packages/dashboard
[start:rmf-server] npm run start:rmf-server exited with code 1
[start:react] Compiled successfully!
[start:react]
[start:react] You can now view rmf-dashboard in the browser.
[start:react]
[start:react] Local: http://localhost:3000/
[start:react] On Your Network: http://<IP_ADDRESS>:3000/
[start:react]
[start:react] Note that the development build is not optimized.
[start:react] To create a production build, use npm run build.

So the lifecycle error should appear when using the latest npm version, which it does in your case.
To confirm this, I've upgraded my npm version and I get a lifecycle error as well, and when I downgrade the npm version it goes away.
So I would suggest deleting the node_module in rmf_web root dir, downgrade npm to the LTS which should be v16.14.2, and bootstrap and run everything again.
Hopefully this will solve the problem for you, if not we can investigate further

I install 16.14.2 by "nvm install 16.14.2" and "nvm use 16.14.2" ,then bootstrap and run everything again. it still don't works. as follow:

sometimes, when i run "./bootstrap" ,i found an ERROR : husky > Failed to install
as follow:

It 's matter or not?

the error this time is coming from a ros2 package, it complains numpy is not installed

"cd rmf-web"&&"pipenv install numpy" and run"npm start" once again
bingo ,it works!
thank you very much ,mayman99

Glad it worked!

it was still not working on latest, we had to downgrade npm for it to work... issue persists

Yup, apologies, I was following the conversation at the tail end of this thread and got a little trigger-happy. I'll be more careful next time

I think https://github.com/open-rmf/rmf-web/pull/611 was to fix this issue, not https://github.com/open-rmf/rmf-web/pull/559. Will be closing this.


Missing entries in imageContentSourcePolicy.yaml

Version
$ oc-mirror version
Client Version: version.Info{Major:"", Minor:"", GitVersion:"v0.2.0-alpha.1-26-g6d68758", GitCommit:"6d68758", GitTreeState:"clean", BuildDate:"2022-05-09T14:54:45Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/amd64"}

What happened?
The imageContentSourcePolicy.yaml file produced by the oc-mirror tool is missing entries and only seems to include top level entries. When using oc adm catalog mirror the top level and lower level entries are included in the imageContentSourcePolicy.yaml file.
For example, the oc-mirror log shows an image being mirrored to the registry
.oc-mirror.log
uploading: [myregistry.co.uk:5004/rhacm2/kube-state-metrics-rhel8](http://myregistry.co.uk:5004/rhacm2/kube-state-metrics-rhel8) sha256:7f98061eced566acfa4041b49f2e574a81e91be6d72791aac71342ebb81871eb 14.37MiB

But the imageContentSourcePolicy created only has the top level rhacm2 folder :
- mirrors:
  - [myregistry.co.uk:5004/rhacm2](http://myregistry.co.uk:5004/rhacm2)
  source: [registry.redhat.io/rhacm2](http://registry.redhat.io/rhacm2)

What did you expect to happen?
When mirroring using oc adm catalog mirror, the imageContentSourcePolicy creates entries for each of the images mirrored. I would expect oc-mirror to behave the same:
  - mirrors:
    - [myregistry.co.uk:5004/rhacm2/rhacm2-kube-state-metrics-rhel8](http://myregistry.co.uk:5004/rhacm2/rhacm2-kube-state-metrics-rhel8)
    source: [registry.redhat.io/rhacm2/kube-state-metrics-rhel8](http://registry.redhat.io/rhacm2/kube-state-metrics-rhel8)

How to reproduce it (as minimally and precisely as possible)?
Mirror images into a local repository and check that the imageContentSourcePolicy.yaml file includes entries for each of the images mirrored with their full path.
Anything else we need to know?
References

Hi @marpears. The ICSP example that you posted is a valid ICSP for all images contained within the rhacm2 namespace. The cluster with this ICSP installed will be able to pull any image that starts with registry.redhat.io/rhacm2 from myregistry.co.uk:5004/rhacm2


Transparent Multicluster: Logical/Physical Cluster Namespaces

Use Case: Transparent Multicluster
Objectives:

[ ] User can add a second location
[ ] Deployed application moves between locations when service is disrupted (cluster down)
[ ] Ingress follows application

Details
Namespaces should be addressable by a name human readable name even when conflicts may exists at the physical cluster level.  Map namespace requests between the name given in a workspace to the physical cluster's actual namespace name

@imjasonh I took a bit of liberty on the details based on how I interpreted the task in our breakdown doc, feel free to correct that as necessary.

To do this, we first need syncer to become multi-lcluster-aware, then to take the lcluster name into account when it puts things into namespaces in the pcluster.
For example, if a Deployment is created in lcluster my-lcluster in my-namespace, and gets scheduled/synced to my-pcluster, it could be created in the namespace kcp--my-lcluster--my-namespace, or hash either component to avoid name length limits.
Perfectly avoiding name length limits can happen later, just having something that avoids conflicts among two lclusters should be good enough for prototype2.
If someone wants to pick this up while I'm absent I'd be happy to help talk through it more, review code, etc., as much as I can.

Doesn't it imply building a syncer-dedicated virtual workspace that aggregates resources (by delegating to the shard proxy) and filter / present them (as well as the API themselves) in a way that corresponds to the syncer needs ? cc @sttts

Doesn't it imply building a syncer-dedicated virtual workspace that aggregates resources (by delegating to the shard proxy) and filter / present them (as well as the API themselves) in a way that corresponds to the syncer needs ? cc @sttts

Maybe? Is it not possible/advisable to make a *-cluster informer with a label filter? I'll do whatever you tell me is most efficient.
The main issue on syncer's side is that it needs to transform the incoming lcluster+namespace into a non-colliding namespace, then transform it back when updating status upstream.

As an aside we should consider a *-cluster informer a virtual workspace, since it is

Just saw this.  I'd be happy to work on this (though I'm off on Friday).

I've got something working, and I've written an e2e test.  Just trying to get the test to pass now :smile:.


fix: serverless-http compatibility

if you use serverless-http to serve soap server the url lib is compiled http://example.com/?wsdl to ?wsdl=.

Coverage remained the same at 94.855% when pulling 7bc88a66b51d4761bb145669b8a593fc5a6952f2 on wik89:bugfix/query-param-wsdl into 699b9847e5f562686e685da0ff5b0a3aecc12076 on vpulim:master.

This breaks handling of wsdl request where some letters are not in lower case. E.g.:
?WSDL
?Wsdl
If you are going to compare using startingWith the please replace reqQuery.startsWith('?wsdl') by reqQuery.toLowerCase().startsWith('?wsdl')

@paulish can you open a PR to fix this?


Avoid retrying requests finished with 'UNAUTHORIZED' errors

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
All YDB errors are retryable now with no exceptions. This causes hanging of driver.Table().Do() calls in case if invalid credentials were provided.
Issue Number: #1550.
What is the new behavior?
Errors with code UNAUTHORIZED are returned immediately to the caller.
Other information
Fixes #1550 and YQ-3843.

Codecov Report
Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 41.03%. Comparing base (2c755e5) to head (468e1d7).

Files with missing lines
Patch %
Lines

internal/pool/pool.go
42.85%
4 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (2c755e5) and HEAD (468e1d7). Click for more details.
HEAD has 517 uploads less than BASE

Flag
BASE (2c755e5)
HEAD (468e1d7)

unit
72
5

go-1.21.x
48
2

ubuntu
103
2

macOS
24
3

go-1.22.x
48
2

integration
72
0

ydb-23.3
24
0

go-1.23.x
55
1

windows
24
0

ydb-24.2
24
0

ydb-24.1
24
0

ydb-nightly
7
0

experiment
7
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1563       +/-   ##
===========================================
- Coverage   71.13%   41.03%   -30.11%
===========================================
  Files         363      362        -1
  Lines       37576    37445      -131
===========================================
- Hits        26731    15365    -11366
- Misses       9767    21571    +11804
+ Partials     1078      509      -569

Flag
Coverage Δ

experiment
?

go-1.21.x
43.55% <42.85%> (-26.97%)
:arrow_down:

go-1.22.x
41.00% <42.85%> (-27.60%)
:arrow_down:

go-1.23.x
40.97% <42.85%> (-30.05%)
:arrow_down:

integration
?

macOS
41.03% <42.85%> (-0.02%)
:arrow_down:

ubuntu
41.00% <42.85%> (-30.13%)
:arrow_down:

unit
41.03% <42.85%> (-0.02%)
:arrow_down:

windows
?

ydb-23.3
?

ydb-24.1
?

ydb-24.2
?

ydb-nightly
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


quantities breaks/fails on rescaling

We encoutered two issues:
import quantities as pq
import numpy as np
import neo
times = np.arange(0, 3) * pq.s
ev = neo.Event(
    times=times
)
new_time = ev.rescale('us')

giving:

---------------------------------------------------------------------------

TypeError                                 Traceback (most recent call last)

<ipython-input-14-2b5a13ab6d4a> in <module>
      6     times=times
      7 )
----> 8 new_time = ev.rescale('us')

~\Miniconda3\envs\sp_git\lib\site-packages\neo\core\event.py in rescale(self, units)
    165         units
    166         '''
--> 167         obj = super(Event, self).rescale(units)
    168         obj.segment = self.segment
    169         return obj

~\Miniconda3\envs\sp_git\lib\site-packages\neo\core\dataobject.py in rescale(self, units)
    280
    281         # Rescale the object into a new object
--> 282         obj = self.duplicate_with_new_data(signal=self.view(pq.Quantity).rescale(dim), units=units)
    283
    284         # Expected behavior is deepcopy, so deepcopying array_annotations

TypeError: duplicate_with_new_data() got an unexpected keyword argument 'signal'

and:

import quantities as pq
import numpy as np
import neo
times = np.arange(0, 3) * pq.s
ev = neo.Event(
    times=times
)

a = 1*pq.us
b = 2*pq.us

ev_a = ev - a
ev_b = ev + b

for t0, t1 in zip(ev_a, ev_b):
    print(t1-t0)

Yielding not exact results:

3e-06 s
3.000000000086267e-06 s
2.9999999997532e-06 s

which we deal with by rescaling ev to us (not trough ev.rescale('us'), see 1st issue), then it does return exact values.

The first issue is a bug, it should be fixedd by #810.
The second issue is fundamentally a problem of the floating point representation, there's nothing we can do at the level of Neo, I don't think.


gpu issue

Hello @Lilac-Lee ,
I'm running the test.py on threedmatch dataset with all your default settings in the code, but got the following error, can you please help me with this?
`(env_lk_revisited) mingli@tarsserver4:~/env_lk_revisited/PointNetLK_Revisited$ python test.py
init_trans shape is (627, 6)
Traceback (most recent call last):
File "test.py", line 154, in
main(ARGS)

File "test.py", line 110, in main
test(args, testset, dptnetlk)

File "test.py", line 104, in test
dptnetlk.test_one_epoch(model, testloader, args.device, 'test', args.data_type, args.vis)

File "/home/mingli/env_lk_revisited/PointNetLK_Revisited/trainer.py", line 122, in
test_one_epoch
_ = model.AnalyticalPointNetLK.do_forward(ptnetlk, voxel_features_p0, voxel_coords_p0,
File "/home/mingli/env_lk_revisited/PointNetLK_Revisited/model.py", line 189, in
do_forward
r = net(q0, q1, mode, maxiter=maxiter, xtol=xtol, voxel_coords_diff=voxel_coords_diff, data_type=data_type, num_random_points=num_random_points)
File "/home/mingli/env_lk_revisited/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "/home/mingli/env_lk_revisited/PointNetLK_Revisited/model.py", line 210, in
forward
r, g, itr = self.iclk_new(g0, p0, p1, maxiter, xtol, mode, voxel_coords_diff=voxel_coords_diff, data_type=data_type, num_random_points=num_random_points)
File "/home/mingli/env_lk_revisited/PointNetLK_Revisited/model.py", line 296, in
iclk_new
J = self.Cal_Jac(Mask_fn, A_fn, Ax_fn, BN_fn, max_idx,
File "/home/mingli/env_lk_revisited/PointNetLK_Revisited/model.py", line 260, in
Cal_Jac
J = torch.einsum('ij,jk->ik', J_, warp_condition).unsqueeze(0)   # 1 X K X 6
File "/home/mingli/env_lk_revisited/lib/python3.8/site-packages/torch/functional.py", line 327, in
einsum
return _VF.einsum(equation, operands)  # type: ignore[attr-defined]
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument mat2 in method wrapper__bmm)
`
Thank you in advance.

Hi, thanks for your comment. I have updated the code.


Update README and Sphinx index page

Need to update content of the README file. Also, update the index page of the Sphinx documentation to be similar with the README on GitHub.

Updated index page for Sphinx documentation. Also added contributing guidelines. Still need to update README on GitHub.

Updated the README on GitHub.


Question on memory usage for LSTM?

Platform: OSX 10.10.3.
Revision: Reasonably current (17/5) git pull of Torch7 and rnn.
Runtime: CPU (not GPU - yet).
Background: I'm modelling events that happen over a 30-day window, with each window divided into 3 minute time-steps. So each distinct user has 3024(60/3)=14,400 events with a lot of these simply encoding the fact that nothing happened. I've got 60k users to look at initially and an 80:20 split between train and test, so 48k training users and 12k test users.
Problem: I inevitably run out of memory about 60 minutes after training - running into the 1 GB luajit cap. Adding collectgarbage() inside the forward / backward loop helped but only to delay the out of memory from 1 minute to 60 minutes. I'm using Tensors throughout my code, not tables.
My planned solutions: I'm working on restructuring my code to load the training data on the fly from storage and then using subsets of the data as mini-batches to hopefully remain within the 1 GB limit as well as evaluating more compressed / efficient ways of modelling the events themselves (but part of my research is to see how good LSTM is at extracting features from the events through time without having to preprocess those events..).
Question: Is this behaviour (exceeding the 1 GB luajit mem limit) simply expected behaviour in the current LSTM code for a dataset of this size - that it's using a table somewhere to maintain state (e.g. unrolling through time etc.) or is it more likely that there is a bug somewhere in my code manifesting itself as this problem and RNN / LSTM should have a stable / reasonable mem usage profile?

If you are training the LSTM with very large sequences (1000+), then the memory limit could possibly be located in the LSTM code as it maintains a state (which is a table stored in a table) for each step. However, your sequence would have to be very large. If this is your case, then I suggest cutting the training problem into smaller sequences of say 100-500.
For testing (i.e. with lstm:evaluate()), you could use the entire sequences without incurring any memory overhead (it only keeps track of the previous state). But this is only true when you use the nn.LSTM directly without nn.Sequencer.
Otherwise, your computer may be simply running out of memory. I have often seen people confuse the 1G luajit mem limit issue with just plain old not enough physical memory.

Ok, thanks! I wrote my code around Sequencer first (and hit this problem) so switched over to nn.LSTM directly to see if I could get more control over what was happening. I'll play around with successively smaller sequence sizes and report back. I should have mentioned each event is modelled as a 33-bit vector so individually they are quite small, so that points to the sequence length.
RE: simply running out of memory, yes it could be this and will check this as well. As a (tenuous) sanity check I built the same model in keras / Theano and ran the same size dataset through it. It worked but was swapping very, very heavily on an 8 GB RAM machine.

Keep me posted. Thanks.

Hi - I propose closing this issue for now, at least until I can provide more debug details on exactly where the memory is going - all of the Torch LSTM impls exhibit the same performance for relatively large numbers of timesteps (Zaremba, Karpathy, rnn). Based on that, unrolling the network through time is an expensive operation in Torch the platform, not in rnn the impl..
For now I've gotten around it by moving the time dimensionality into the data layer which isn't ideal but works (memory-wise at least, still testing confusion matrix accuracy..).


Feat: menu expandable and menu mini

:tada: This PR is included in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use sqlite by default in docker

This allows for easy setup with no extra configuration.
Also update docs to reflect the new and easy way to run PowerDNS-Admin.
Signed-off-by: Felix Kaechele<EMAIL_ADDRESS>

LGTM. Merging your PR. Thanks @kaechele


Fix some typos for Bell Canada Training

Fix some typos for Bell Canada Training

Closing this request , will create another one later


[docs] Add tutorial for CDC 3.0 pipeline

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Add tutorial for CDC 3.0 pipeline
Solution
No response
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

I am willing to do.


Mitmweb: accessibility: Screenreaders have a tough time with the MITMweb UI

Problem Description
A clear and concise description of what the bug is.
Screenreaders depend on semantic HTML to do their best work. The way mitmweb works is divergent from the norm in various ways, which means WAI-ARIA can and should be used in order to make the UI usable for screenreader users. The current issues:

It is currently impossible to know what flow has focus, this is seemingly only indicated visually.
The shortcut key list (triggered by ? ) seems to be using an inaccessible editor component and therefore cannot be used. Likely codeMirror or a CM derivative of some kind. That is, if I'm seeing the right thing, it took me several tries to get it to come up.
The keyboard shortcut help (invoked with ?) I haven't been able to get to work at all.
Obviously there might be more, but these are currently the biggest showstoppers.

Steps to reproduce the behavior:

Enable any kind of screen reader (Narrator or NVDA on Windows, VoiceOver on Mac, Orca on Linux).
Arrow through the flows in an MTIMmweb session.
Observe that nothing happens whatsoever.

Suggested Remediation Steps:

Add a live region ( aria-live="polite") to the interface.
On  changing flow, set the inner HTML of the live region to some distinguishing flow identifier, think ID, host name etc. This will make the screenreader echo the new content and should make arrowing through flows work at least.
nice-to-have: echo brief status messages to that same region to indicate other operations have happened, e.g. flow info having been opened and other such things.
Semantically mark up the various regions of the UI. Right now it's an absolute pain to get from the list of flows to ...anywhere, really. Even adding invisible headings would be better than what it's doing now.

System Information
Paste the output of "mitmproxy --version" here.
Mitmproxy: 5.3.0
Python:    3.6.9
OpenSSL:   OpenSSL 1.1.1h  22 Sep 2020
Platform:  Linux-4.15.0-117-generic-x86_64-with-Ubuntu-18.04-bionic

Hi @zersiax,
Sorry for letting you down here and thanks for speaking up. I think I wrote most of mitmweb at a point where I didn't have much experience with web accessibility. We definitely should do better here.
FWIW I don't think we have a keyboard shortcut help, but we do use CodeMirror, so that might be what's causing it. Let's check if we can upgrade to CodeMirror 6 on that front, which claims to be much more accessible.

oh wow :)
I seem to have made a bit of a mistake here :) I was under the impression the "user interface" area of the docs were about mitmweb but they are not, which ...explains a thing or two about why things weren't working as expected :)
A quick update:

CodeMirror is indeed accessible in the sense that the contents of the editor cannot be read. This means you can't check input, can't see what's already in the editor without crl+a ctrl+c-ing it into another editor. There are more accessible alternatives, chiefly the Monaco editor. I don't know about the latest version of codeMirror in that regard, but can certainly find out.
ignore the bit about arrowing through flows, that doesn't apply in the web version. However, adding a bit of ARIA to indicate stuff has happened would be good. Essentially, the table rows work when you hit enter on them, but this isn't indicated to a screenreader very clearly which is really easy to fix.

I'll report back into this issue when I find more, and see if I can't fix some of these myself in a PR later :)

Fantastic, thanks! 🍰 If you have any questions please don't hesistate dropping by in our developer Slack. I unfortunately won't be able to spend any significant time on mitmweb in the next few weeks, but this here is definitely something I'm going to look at once I get there.
CodeMirror 6 claims to be "designed from the start with accessibility in mind, avoiding a number of pitfalls that the current crop of editors suffer from" as their very top feature, so I'd be cautiously optimistic here. Then again I'd also be happy to switch to Monaco, we really don't do that much with the editor at the moment. :)

May I take on this Issue


Looking for input manipulation side of MPK (version 1)

Hey,
I'm looking for some functionality that MPK v1 had that MPK v2 did not retain.
MPK v1 had Macros, _Togglesprint, and Flight disable toggle.
Were these functions removed to leave MPK v2 as a purely informational mod?
If so, I would love to know if/where these functions were sent/added to.
(My apologies if this information was on a #Discord somewhere.  May be worth noting in the description?)

I'm really just looking to disable double jump fly and replace its keystroke(s)... I used to a command keybind for /mpk fly

... I'm so dumb... how did I not find fpk mod instead... fml


Android gradle-based build should support local-engine builds

When working on the Flutter engine and the Flutter framework simultaneously, it's useful to be able to create complete builds of apps that use a locally modified version of the framework and of the engine.
The flutter tool supports this workflow in the old Android build system using the --local-engine flag.  We should make sure the gradle-based workflow also supports this feature (i.e., via a configuration file, similar to how we support it in the Xcode-based build).

This might already work.  I just filed  the issue so we make sure to check it.

Probably doesn't work yet, at least according to #6761.

Tracking this in #6761.


Apple Authenitcation

Hello! Thanks for providing a wonderful tool!
I've been using the tool and suggested it to some teammates but some of them were uneasy about supplying their Apple credentials. I noticed in the README, there is this snippet about auth with a link, but the link is dead.
The Apple authentication flow is described in [Apple.paw](https://github.com/RobotsAndPencils/XcodesApp/blob/main/Apple.paw), which will allow you to play with the API endpoints that are involved using the [Paw](https://paw.cloud/) app.

Could someone please provide an updated link or refer to a part in the code dealing with the authentication stuff? Would like to continue using this!

Issue for broken link in readme: #141. PR to add file: #152. Here's the signIn function:
https://github.com/RobotsAndPencils/XcodesApp/blob/3b1254a48eb6fae3c54f61dee15da6961078d214/Xcodes/AppleAPI/Sources/AppleAPI/URLRequest%2BApple.swift#L19


Great app but small request

Hi
Great clock face. Small request. Could we have the temp in centre grade as an option. I'm from the UK

You got it! submitted the update (v0.0.3) for review. Thanks for the suggestion!

Wow great thanksOn 21 May 2018 13:27, Noah Pendleton<EMAIL_ADDRESS>wrote:You got it! submitted the update (v0.0.3) for review. Thanks for the suggestion!
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

No worries! once you update, if you view "My Clock" in the app, you should see a little configuration gear that has the settings. You may need to exit the app gallery on the mobile phone and go back it for it to refresh.

 I have sorted it. What a great clock face.


Docs of setState hook showcase usage that might lead to bugs

URL: https://reactjs.org/docs/hooks-state.html
Example from the docs:
import React, { useState } from 'react';

function Example() {
  // Declare a new state variable, which we'll call "count"  const [count, setCount] = useState(0);
  return (

You clicked {count} times

      <button onClick={() => setCount(count + 1)}>
        Click me
      </button>

  );
}

When toggling values or incrementing counters, I think people should be encouraged to use the setState variant that takes an function as argument.
So here:
setCount((prevCount) => prevCount + 1)

We just ran into a bug caused by this today. And having this as the first bit of documentation might to lead to more bugs like this as people might assume it's safe to use setState like this.
I get that the functional argument might be too advanced for the initial docs of setState, but maybe then the counter might not be the best example to use.
Update:
Or linking to here might help? https://reactjs.org/docs/state-and-lifecycle.html#state-updates-may-be-asynchronous

This is explained in the new documentation. (https://beta.reactjs.org/apis/usestate#updating-state-based-on-the-previous-state)

The new documentation will replace the current one soon.

nice, thanks for the update

Happy to help. 👋


[PECO-444] Fix error logging bug

Errors emitted by Thrift may contain some additional fields with complicated nested structures, and when trying to serialize them another error was triggered ("TypeError: Converting circular structure to JSON").
Solution: log only error message + stacktrace.
Also, this PR slightly modifies 'error' event handler of DBSQLClient: previously re-emitting 'error' event caused unhandled exception appearing in console; but since we already log it using logger - that behavior was no longer needed and therefore is disabled now.
Also see comments to the code for other details.
Related to databricks/databricks-sql-nodejs#87 and databricks/databricks-sql-nodejs#85 (hides original error in both cases)

When do you plan to release a new version with this fix?


REPLACE INTO feature missing in Medoo.

Note that I am not referring to Medoo's existing replace feature.
MySQL allows REPLACE INTO queries which update existing rows or insert new row into the database if matching ones don't exist.

REPLACE works exactly like INSERT, except that if an old row in the table has the same value as a new row for a PRIMARY KEY or a UNIQUE index, the old row is deleted before the new row is inserted.
https://dev.mysql.com/doc/refman/5.7/en/replace.html

This is a massively useful feature which could be implemented for non-MySQL DBs if required.
Note that I am not referring to Medoo's existing replace feature.

REPLACE INTO doesn't work fine with the foreign key constrains since it removes the row with duplicate key and insert new. I've moved to INSERT ... ON DUPLICATE KEY UPDATE syntax in MySQL. Poorly such syntax is supported only by MySQL.

Is there documentation on how to use that syntax with Medoo?
On 17 Nov 2015 4:53 am, "SyuTingSong"<EMAIL_ADDRESS>wrote:

REPLACE INTO doesn't work fine with the foreign key constrains since it
removes the row with duplicate key and insert new. I've moved to INSERT
... ON DUPLICATE KEY UPDATE syntax in MySQL. Poorly such syntax is
supported only by MySQL.
—
Reply to this email directly or view it on GitHub
https://github.com/catfan/Medoo/issues/318#issuecomment-157267474.

It's a MySQL syntax, not supported by other DB. Medoo haven't provide a method to do that, you can call $medoo->query($sql) or $medoo->exec($sql) to run SQL directly.

little confused here as this was closed by @catfan with no explanation. I assume this feature was not picked up?


Thank You

I've included you in the special thanks of my new bot for the part cyNaoko played in its inception. If wasn't for it, and nuclearace's subsequent port of it to Node, I wouldn't be as adept with Javascript and Node as I am today.
Have a pleasant day.

I'm glad you found my code useful.


View submitted projects by category implemented

Nav bar at the top allowing submissions to view: 1. Web, 2. Mobile, 3. Other, in that order


Dir grouping/v1

Closes redmine ticket: https://redmine.openinfosecfoundation.org/issues/3069

Hey @catenacyber !
Could you please have a look at this?

Repalced with #115


Can zod-fixture generate fixture from typscript interface like autoFixture?

This is a library i have been waiting for a long time in js/ts world.
I have been use autoFixture in .net.
It allow to generate model fixture from an interface.
Could this be enhancement of this awsome library?
For example:
const fixture = createFixture<Interface>()
                .With(x => x.MyText, "Ploeh")
                .Create();

Hey @peterhe2000 , sadly that isn't possible AFAIK.
The reason for this is that a typescript interface is just a contract that is used at compile time.
To create a fixture we need to get the properties at run-time.
This is why we need an extra dependency, zod for example.


Craft 4

Hello, is this plugin also in the roadmap to be upgraded to Craft 4?

Yes but... it will no longer be a standalone plugin and will be directly integrated into Sprout Forms.

Thank you @BenParizek ! Looking forward to the launch. :)
Closing this now.


Couldn't create pid file "/var/run/sshd.pid": Permission denied

This could be from some of the recent pid file changes to rsconf. Not sure.

This doesn't actually prevent the devbox from starting. It is just printed out but things still work fine...

switched to vm_devbox


SimpleItemTouchHelperCallback: setAlpha() crashes on older devices < API11

SimpleItemTouchHelperCallback.setAlpha() crashes our app on devices < API11. Please add use of ViewCompat instead or some other solution.
Our specific issue is in clearView() line 110 but it's also used in onChildDraw().

The current version of the  library do not support on the devices which API <11.


Restructure SlotAllocator interface

Splits SlotAllocator#determineParallelismAndAssignResources into 2 methods.
(There are a few naming issues that would need be solved; e.g. VertexAssignment doesn't quite make sense imo (because we assign things later...))

Merged via cd1090f7477435ddcacc111a584b55a638563e8d

Merged via cd1090f7477435ddcacc111a584b55a638563e8d


SearchView QML Controller

This is an early PR to get the ball rolling for the SearchView QML.
I still need to:

Test the docs build on windows,
Fix some outstanding GC bugs that are hard to repro.

But aside from minor tweaks - this is ready fro review.

@ldanzinger Sorry for the delay. I've update the docs and fixed any errors that were found.


Map usecase

Version 1 of the use case. Is for some routes very slow. The test is a integration test and does only work with the real APIs.

@mariushegele please check the build log. There appears to be an error with the vvs service.
@timozuther please check the build log. There appears to be an error with the yelp service.

I don't see an error with the yelp service. Could you give me more details about the error?

I don't see an error with the yelp service. Could you give me more details about the error?

It resolved itself :)


Tasks workDir as Dockerfiles WorkDir

I created a task and taskrun that runs a container. Container runs a build artifact from  a work directory named app.
My task is like following,
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
  name: step-runner
  namespace: tekton
spec:
  steps:
  - name: intermediary
    image: myimage
    workingDir: /app

Problem is, the value of workingDir attribute is not in my hand always. Is there any way to initialize it with dockerfiles WORKDIR
My Dockerfile is like following
....
....
WORKDIR /app
COPY --from=builder /app/bin /app
EXPOSE 8080
# Run the executable
CMD ["./test-app"]

/kind question

@zeromsi thanks for the issue report. Just checking here - did you try running your Task without the workingDir field in the step? Since pull request https://github.com/tektoncd/pipeline/pull/3920 Tekton should no longer override the docker image's WORKDIR unless the Step explicitly requires it.
If you tried it and saw an issue - what working directory did your image run in? what version of Tekton Pipelines are you using? And what does your feature-flags ConfigMap from the tekton-pipelines namespace look like?
# Get the values from the feature-flags configmap
$ kubectl get configmap -n tekton-pipelines -o yaml feature-flags

Cheers!

thanks @zeromsi, I'm going to close but feel free to reopen if this issue is still unresolved!


Dev

CI TEST

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   97.06%   97.06%
=======================================
  Files          15       15
  Lines        1944     1944
  Branches      209      209
=======================================
  Hits         1887     1887
  Misses         36       36
  Partials       21       21

Impacted Files
Coverage Δ

mutatest/tests/test_run.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa7660...041cde4. Read the comment docs.


How to hide the descriptions of tabs ?

Version
Tell us which versions you are using:
"^4.0.0-beta.31"
Expected behaviour
I want to hide descriptions of tabs.
Actual behaviour
I cannot hide the descriptions.

@dextermb  Thanks it worked !!!

@Koshukey 👍 be sure to close this thread then


Issues following these steps on Server 2022 VM

Hello!
I followed the steps here: https://docs.microsoft.com/en-us/virtualization/windowscontainers/quick-start/set-up-environment?tabs=Windows-Server for Windows Server in a brand new Server 2022 VM (running on Hyper-V in Windows 10).
Then I followed the steps in this page: https://docs.microsoft.com/en-us/virtualization/windowscontainers/quick-start/run-your-first-container and got an error:
PS C:\Users\Administrator> docker pull mcr.microsoft.com/windows/nanoserver:ltsc2022
error during connect: In the default daemon configuration on Windows, the docker client must be run with elevated privileges to connect.: Post "http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.24/images/create?fromImage=mcr.microsoft.com%2Fwindows%2Fnanoserver&tag=ltsc2022": open //./pipe/docker_engine: The system cannot find the file specified.

This was running in an elevated PowerShell so... what gives?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a1c4c54-7721-58ce-f77d-be0ef0c687bf
Version Independent ID: 70e52446-1c7b-78ff-67f2-1f6c0d058788
Content: Run your first Windows container
Content Source: virtualization/windowscontainers/quick-start/run-your-first-container.md
Product: windows-server
Technology: windows-containers
GitHub Login: @v-susbo
Microsoft Alias: viniap

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Add new Logging driver "fluentd"

This patch provides fluentd logging plugin for docker, which is mentioned at #12540.
How to confirm behavior of this patch/new logging driver.

Setup dev docker container
Build repository with this patch by make BINDDIR=. binary
Copy binary and execute it in debug mode docker -dD
Attach from external environment by docker exec -it kickass_heisenberg /bin/bash
Build/execute another docker container from other console, built on Dockerfile and configuration file below:

# sh
$ docker run --net=container:kickass_heisenberg tagomoris/docker-fluentd
# Dockerfile
FROM kiyoto/fluentd:0.10.56-2.1.1
MAINTAINER<EMAIL_ADDRESS>RUN mkdir /etc/fluent
ADD fluent.conf /etc/fluent/
ENTRYPOINT ["/usr/local/bin/fluentd", "-c", "/etc/fluent/fluent.conf"]
# fluent.conf
<source>
  type forward
</source>
<match docker.**>
  type stdout
</match>

Execute hello-world container on attached environment: docker run --log-driver=fluentd hello-world
Got logs

2015-04-20 09:32:27 +0000 [info]: starting fluentd-0.10.56
2015-04-20 09:32:27 +0000 [info]: reading config file path="/etc/fluent/fluent.conf"
2015-04-20 09:32:27 +0000 [info]: gem 'fluentd' version '0.10.56'
2015-04-20 09:32:27 +0000 [info]: using configuration file: <ROOT>
  <source>
    type forward
  </source>
  <match docker.**>
    type stdout
  </match>
</ROOT>
2015-04-20 09:32:27 +0000 [info]: adding source type="forward"
2015-04-20 09:32:27 +0000 [info]: adding match pattern="docker.**" type="stdout"
2015-04-20 09:32:27 +0000 [info]: listening fluent socket on <IP_ADDRESS>:24224
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":"Hello from Docker."}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":"This message shows that your installation appears to be working correctly."}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"log":"","source":"stdout"}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":"To generate this message, Docker took the following steps:"}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":" 1. The Docker client contacted the Docker daemon."}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":" 2. The Docker daemon pulled the \"hello-world\" image from the Docker Hub."}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":"    (Assuming it was not already locally available.)"}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":" 3. The Docker daemon created a new container from that image which runs the"}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":"    executable that produces the output you are currently reading."}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":" 4. The Docker daemon streamed that output to the Docker client, which sent it"}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":"    to your terminal."}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":""}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":"To try something more ambitious, you can run an Ubuntu container with:"}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":" $ docker run -it ubuntu bash"}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":""}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":"For more examples and ideas, visit:"}
2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: {"source":"stdout","log":" http://docs.docker.com/userguide/"}

@tagomoris Overall looks cool. But I'd be much more eager to merge if for msgpack serialization were used something simpler then ugorji/go. Our logging structure is defined and we can generate serializer with msgp for example, but we need something like PostRaw([]byte) from fluentd library.

Hmm, I have 2 options:

rewrite fluent-logger-golang with simpler msgpack serializer library (but it runs slower than ugorji/go): github.com/vmihailenco/msgpack
send log events to Fluentd as JSON over TCP: that has less efficiency (in both CPU usage and network traffic)

Using JSON is much more simpler and easy to implement, but it requires more CPU usage if container generates large amount of logs.
@LK4D4 thoughts?

@tagomoris what about PostRaw as I said and generated serializator in docker? we can disable ugorji/go with tag if we want. I don't see any particular problem with rewriting fluent-logger-golang only for our type of messages, which will be even faster then ugorji, but I want use community-provided solutions :)
Basically PostRaw is https://github.com/t-k/fluent-logger-golang/blob/master/fluent/fluent.go#L106 (body of else).

@LK4D4 make sense.
But Fluentd's all events are structured data (like JSON object), with tag & time, transferred in JSON/MessagePack. Fluentd doesn't have raw data in any way. It's biggest feature of Fluentd as a log collecting service.

Now I'm going to rewrite this patch with JSON serialization, without ugorji/go.

@tagomoris So, whole problem, that we don't want to expose PostRaw from t-k/fluent-logger-golang because it "isn't right"?
Why we can't send to TCP msgpack serialized data? As I see t-k/fluent-logger-golang doing just this.
I'm not in particular happy with json too, I think we can find compromise.

There are no problem to send TCP msgpack serialized data, and to add methods like PostRaw on t-k/fluent-logger-golang (or its fork). Fluentd's will not break any compatibilities of its protocol.
Now I'm concerning about serializer, especially for msgpack.
@LK4D4 are you serious to write msgpack serializer in docker source tree only for this purpose?
I think that it's better to implement this feature based on JSON serialization at first, because JSON serializer is already used by jsonfilelog. And then we can re-fix this feature with msgpack serializer if someone complain its speed/efficiency.

@tagomoris It is pretty easy to generate serializer if we know structure(and we know), and it will be superfast. Makes sense to make logs as fast as we can, it is most loaded part of docker. And generating serializer is very cheap: https://github.com/tinylib/msgp

@LK4D4 Ah, i got you mentioned finally!
OK, I'll add PostRaw -like method and then fix this patch without ugorji/go. Please wait a litte...

Updated patch w/ fluent-logger-golang v0.6.0, which depends on msgp and serializer code by msgp.
We (Fluentd community) decides to change serializer library from ugorji/go/code to msgp for its lightweightness. (And now fluent-logger-golang is hosted on fluent organization.)
Now fluent-logger-golang has also PostRaw method, but there's no difference between using PostRaw w/ pre-serialized data and just using PostWithTime.
@LK4D4 Could you review once more? (only dependencies are changed)

2015-04-20 09:45:09 +0000 docker.483cb7e2cc42.stdout: ...

Would it be possible to also include the container name (not just container id) in the tag?

@fw42 yes, tag can contain any strings, including container name. But too long/complex tags are not good for users in general.
How about to add container_id and container_name attributes in log data to show log sources to users? (like journald logging driver does)

How about to add (...) container_name attributes in log data to show log sources to users?

Hmm you mean the application itself should include the container name in it's own logs (in every single line)? That seems like an anti-pattern to me. I don't want my application to (have to) know that it is even running inside a container.

@tagomoris: To clarify the use-case, I think it would be nice to be able to use different fluentd output plugins based on the container name. If the container name were part of the fluentd tag, that would be pretty easy. Do you have another idea?

@fw42

Hmm you mean the application itself should include the container name in it's own logs (in every single line)?
No. Logging driver get container name and id when initialized, like journald logger. I pushed a commit to do so.
Application doesn't have to take care about it. (I paste example log w/ container_id and container_name below)

2015-05-09 10:17:21 +0000 docker.a4da785a4379.stdout: {"source":"stdout","log":"Hello from Docker.","container_id":"a4da785a4379b10d3d2789084d788099c7322b6ac055526937badbadf8df83a3","container_name":"/modest_franklin"}

I think it would be nice to be able to use different fluentd output plugins based on the container name. If the container name were part of the fluentd tag, that would be pretty easy.

Hmm, it seems true for me too.
But at the same time, Fluentd's tags are likely used to format file paths on filesystems. Docker container name includes / char, so using container name in tags will make many troubles on filesystems.
I have no idea how we should handle it. Should we remove /? or replace with any other chars?

It will be configurable with --log-opt option to select ID or Name for tags (and tag prefix, now it is a constant docker).

@tagomoris oh, almost forgot; there's another PR that implements changing the "tag" (to use, e.g. the container-name) for the syslog driver.
It hasn't been approved yet, and needs a rebase (because the --log-opt PR (https://github.com/docker/docker/pull/12422) was merged)
You can find that PR here; https://github.com/docker/docker/pull/12668. I think it would make sense to make sure both drivers use the same approach. (Not taking a position here which approach that would be)

I added a commit to get logger options below from --log-opt:

port: fluentd port [24224]
host: fluentd host [localhost]
tag: tag of fluentd logs [docker.CONTAINER_ID_SHORT]

this value overrides any specifications for tag-prefix/tag-type

tag-prefix: prefix part of tag [docker]
tag-type: second part of tag, options are id/fullid/name [id]

How do you think about this change? @LK4D4 @fw42 @thaJeztah

Awesome. Changes in the last commit look good to me.
Tests are broken though.

Thanks for moving to --log-opt; as mentioned, I think the design/approach for specifying the "tag" format should be reviewed together with https://github.com/docker/docker/pull/12668, for a consistent UI.

Oops. Rebased, solved the conflict and pushed it.
If it's ok, I'll fix documents once more.

@thaJeztah @LK4D4 could you take a look at?

I've rebased on master again, and added docs about --log-opt options.
Please review once more!

ping @LK4D4 PTAL (also https://github.com/docker/docker/pull/12876#issuecomment-101058662)

Is this likely to make the 1.7.0 release?

It's better for me to merge ASAP.
iPhone$B$+$iAw?.(B
2015/05/19 23:04$B!"(BGraeme Johnson<EMAIL_ADDRESS>$B$N%a%C%;!<%8(B:

Is this likely to make the 1.7.0 release?
$B!=(B
Reply to this email directly or view it on GitHub.

I reviewed, but note that this is still in design-review. We need some more approvals to move it to code-review.
ping @docker/core-maintainers

@LK4D4 What's the approval process? What should we do next? Who we need to convince? (CC/ @docker/core-maintainers)
@graemej @fw42 If you guys can endorse this feature from Shopify, that would be awesome.

We are definitely interested in this feature in general, but we haven't reviewed the implementation in detail. I took a look at the changes in this repo (which looked good to me), but I didn't really have time yet to look too closely at the package that is being pulled in...

I think specifying the tag can't be really abstracted that much because each driver will have its own format and its own requirements (like fluentd needs "." and syslogs needs "/"). Also, for instance, journald doesn't need a tag option at all (or better, it's a map configured inside New with data from the logger.Context)
What I'm saying is this tag(s) should specified like --log-opt fluentd-tag=name --log-opt fluentd-prefix=docker (prepending the driver name) given --log-opt shouldn't be either checked nowhere other than the driver it needs it
ping @thaJeztah @LK4D4 @tagomoris

I think specifying the tag can't be really abstracted that much because each driver will have its own format and its own requirements (like fluentd needs "." and syslogs needs "/")

Hm, yes, you could be right there. In that case, the proposed drivername- namespace/prefix makes sense.

@thaJeztah Yup, prefix is nice.

credit for prefix goes to @LK4D4 to be honest :)

Thanks for many great review comments. I added a commit to:

move parser code for --log-opt values into a separated function
use fluentd- prefix for all options
use fluentd-address only to specify host/port of Fluentd server
use fluentd-tag with text/template syntax to format Fluentd tags

Could you check it again? @LK4D4 @runcom @thaJeztah

If you guys can endorse this feature from Shopify, that would be awesome.

For what it's worth logging is the part of our stack we're least happy with.  We want logs out of files and off-machine as quickly as we can.  The structure of our Rails logs do not lend themselves nicely to existing syslog log drivers and fluentd looks like it a proven solution that offers more flexibility.
If this makes it in we'll use it: but we have a strong preference for running official packages in production hence my earlier question about it making the 1.7.0 milestone.

Oops, forgot to ping @LK4D4 & @docker/core-maintainers on that last comment.
Q: What's the approval process to take this to the next step?

We need approve from majority of core maintainers I think :)
I approve.

+1 here!

@LK4D4 how about pluginifying log-driver ?

@tiborvass What do you mean? :) Like make them remote?

How many more +1 needed? Are there any things I can do for that?

My opinion on this: I don't like that it brings in that much code in, but I still think we should move forward until we have a better solution to offer. In particular, Go 1.5 will give us a way to dynamic load such things (so basically: plugins for free as long as they are written in Go): that will be an opportunity to clean up later.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "logger-driver-fluentd" git@github.com:tagomoris/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~10
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Pushed some update:

rebased on master (because tests failed on windows)
updated fluent-logger-golang to v1.0.0
fixed some documents

Moving to code review.

@tagomoris can we squash commits like vendor commit and driver commit?

@LK4D4 done

@LK4D4 @runcom @cpuguy83 ping?

hi

Apologies, @tagomoris, it's been busy because of the release candidates. I do see this needs another rebase.
ping @runcom @LK4D4 @cpuguy83 PTAL

Rebased once more.

code LGTM

This PR is doomed. I can't get janky pass :(

@tagomoris:
panic: fluent#reconnect: failed to reconnect!

goroutine 187 [running]:
github.com/fluent/fluent-logger-golang/fluent.func·001()
        /go/src/github.com/docker/docker/vendor/src/github.com/fluent/fluent-logger-golang/fluent/fluent.go:215 +0x10c
created by github.com/fluent/fluent-logger-golang/fluent.(*Fluent).reconnect
        /go/src/github.com/docker/docker/vendor/src/github.com/fluent/fluent-logger-golang/fluent/fluent.go:221 +0x8c

Looks pretty brutal for me.

https://github.com/docker/docker/pull/13015 is merged.
After rebased and applied reviews, ready to merge?

@repeatedly Yes, we will merge it when we test it properly. I'm doing all that I can :)

@LK4D4 Do you mean that do not panic in any situation and should retry to reconnect forever?

Add one more commit to try to reconnect forever (& once more rebase)

@tagomoris You shouldn't panic in your library. You can return error on failed reconnect instead.

@LK4D4 Yeah, but it's a originally external library, and I've fixed not to panic (in reasonable years). Isn't it enough for docker project?

@tagomoris It's okay for me if it won't panic.

@LK4D4 I got relieved to hear that. The commit bb2d681 made it so.

@icecrime @thaJeztah @cpuguy83 are there more things to get this merged?

I wonder if this can test someone with existing fluentd installation. @tagomoris Maybe you have docker image with fluentd which will print messages to stdout?

I'm sorry to say this, but the commits need to be squashed :pensive: otherwise LGTM

@LK4D4 just uploaded tagomoris/docker-fluentd is what I'm using for test of this patch
@calavera squashed

@tagomoris Thanks. You can rebase while I'm testing.

Rebased. Test failure seems from bug out of this patch.

@LK4D4 done

@tagomoris Is \r at each log end desired behavior?

Apart from question driver works perfect. Disconnect handling just amazing.

@LK4D4 it's normal as a kind of Fluentd's input data. there's many way to remove it, or to handle logs with newlines.

LGTM
ping @calavera @docker/core-maintainers
try driver yourself, pls. It's very easy with tagomoris/docker-fluentd

@tagomoris I'm sorry, but seems like now we have another msgpack serializer vendored: hashicorp/go-mspack. Is it possible to use it to reduce size of your patch?

@LK4D4 you can show it in last commit.

@LK4D4 once I tried, but it's impossible.

:( okay

Can you please merge this? Or more reviewer needed?

@tagomoris I think at least one.

LGTM. Moved to docs review.

Hey, I'm just a passer-by who is looking forward to seeing this merged. FWIW, I put some comments on some of the docs. Hope it's useful.

@tmatsuo Thank you for many good comments. I've updated document files.

Looks better!
put some more comments

Add a commit and pushed.

Thanks @tagomoris
The document looks great to me (I'm a novice on docker, but I can understand the document easily) :+1:
@LK4D4 et al. Maybe it's your turn to do the docs review.

@tagomoris Apologies for stepping on your PR.  I wanted to test the new organization and I knew your PR was in docs/review and almost ready to merge.

@moxiegirl @LK4D4 rebased again, on master branch, which already has document file for this driver.

Thanks @tagomoris for being patient.  LGTM

@LK4D4 ready for merge at will

@LK4D4 ty.  @tagomoris Thank you for this contribution. We really appreciate your work.

:+1:

:+1:

Yes, merged! Thanks so much @tagomoris sorry this took so long

Great work @tagomoris (moris-san) :100:

Thank you so much! I'm very looking forward the release of next version!

Great job @tagomoris and Docker team! :+1:

Thanks @tagomoris :smile: we've been looking forward to this!


idk

Type: Feature Request
hey how are you guys doing
VS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:39:26.248Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

Thanks for creating this issue. We think this issue is unactionable or unrelated to the goals of this project. Please follow our issue reporting guidelines.
Happy Coding!


feat: hover effect on home page elements & redirecting to their respective pages

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
This PR adds the missing animation on the website, In the whole website each button have some hover effect but on home page "Learn","Create" and "Socialize" button has no effect on it which looks odd.
I also added the cursor pointer on hover.
Fixes #1262
Type of change
Change in UI.
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Tested on my local system.
Checklist:

[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Screenshots or example output

@priyankarpal please review it.

@letscodedanish @priyankarpal
I liked the changes. However I have some thouhts...
Now Learn Create Share looks like they are links. It gives us an opportunity to actually link them meaningfully.

Learn can be linked to /plays
Create can be linked to how the 'Create' button is linked
Share can be linked to this modal we already have..

What do you think?

@letscodedanish @priyankarpal
I liked the changes. However I have some thoughts...
Now Learn Create Share looks like they are links. It gives us an opportunity to actually link them meaningfully.

Learn can be linked to /plays
Create can be linked to how the 'Create' button is linked
Share can be linked to this modal we already have..

What do you think?

yeah! it would be great if we do.

@letscodedanish @priyankarpal
I liked the changes. However I have some thoughts...
Now Learn Create Share looks like they are links. It gives us an opportunity to actually link them meaningfully.

Learn can be linked to /plays
Create can be linked to how the 'Create' button is linked
Share can be linked to this modal we already have..

What do you think?

yeah! it would be great if we do.

@letscodedanish Do you want to take up these changes?

Yes @atapas im taking up these changes, i would like to know the path for each button where we will be redirected by clicking on it.

Yes @atapas im taking up these changes, i would like to know the path for each button where we will be redirected by clicking on it.

Yeah that I mentioned in my earlier comment.

@atapas I have done the changes you suggested, its working fine for all the three icons.
Learn is linked to /plays
Create is linked to the 'Create' button
Share is linked to the modal we already have.

@atapas please review it, so that i can do the further changes if needed.

https://app.netlify.com/sites/reactplayio/deploys/6527c8492676f90008532962

@letscodedanish
Let me know when errors are fixed. It still fails

@atapas have a look.

https://app.netlify.com/sites/reactplayio/deploys/6528e6166e1a9a00087d9fd2

Still got one lint error

@letscodedanish
still

@atapas I dont know why its giving prettier error, i have done the correct spacing according to the linting rules. If you can suggest something?

@atapas check on the latest commit, in my system it's not giving an error, if it still gives an error while deploying we can drop the idea of socialize modal pop-up and can simply redirect to the footer part.
For the "Learn" and "Create" button it's working totally fine the animation and the functionality both.

@letscodedanish You just need to put an enter(new line on the specified line number)

@letscodedanish You just need to put an enter(new line on the specified line number)

okay @atapas I did that , have a look.

@letscodedanish Understand the error here:

At the line number 21, you have a space then enter.. instead it is asking you to remove the space before the enter.
Btw, doesn't  the lint error comes in dev mode?

@letscodedanish Understand the error here:

At the line number 21, you have a space then enter.. instead it is asking you to remove the space before the enter.
Btw, doesn't the lint error comes in dev mode?

I fixed what you said, and yes the lint errors are not coming in dev mode. Everything is working as per we wanted if this errors doesn't count.

@letscodedanish Understand the error here:

At the line number 21, you have a space then enter.. instead it is asking you to remove the space before the enter.
Btw, doesn't the lint error comes in dev mode?

I fixed what you said, and yes the lint errors are not coming in dev mode. Everything is working as per we wanted if this errors doesn't count.

This is concerning.. because this PR is very close to done... But now able to test out due to lint issues. Could you please confirm you are running all the format and lint commands mentioned in the readme?
You previous link fixed worked but there is one more.

I just remove the extra space & let see

Can we do it @priyankarpal @atapas as my hacktoberfest timer is going to end.

It still has the same error. format code & lets see
https://github.com/reactplay/react-play?tab=readme-ov-file#format-the-code

I have only added the functionality of "Learn" and "Create" for now to avoid the error and see the hover effect, we can take the socialize button in a new PR separately. For now please have a look on it @priyankarpal @atapas .

@priyankarpal please have a look on it.


Handle the additional Texlive packages

We can:

install a bundle @pkgw like did here (see https://github.com/conda-forge/staged-recipes/pull/518#issuecomment-216530676)
package manager: https://www.tug.org/texlive/doc/tlmgr.html (see https://github.com/conda-forge/staged-recipes/pull/518#issuecomment-216563521)

IMO it would be good to have certain packages (e.g. whatever things like nbconvert or knitr need per default) installed when the default install method (not sure if that is texlive-core or a different package) is used.

So, TexLive is pretty massive and I would like to steer clear of some of the mistakes made by more traditional package managers of installing the kitchen sink. It would be nice if this package remained very minimal to solve that problem.
Though I do agree with @janschulz that we should have one package (probably a metapackage) to install the minimum usable level of TeX for use with things like nbconvert and knitr. I just do not think that texlive-coreshould be it. Maybe we could create a new package for that purpose and call it something liketexlive-basic` or similar. Not attached to that name per se, but something that conveys that minimum level of usability.

BTW: where are additional packages installed to if the user uses the package manager? That was a pain to configure in the miktex package...

Also, interested in the answer to this question. Didn't keep up with the latest changes to the PR. May muck around to see how this works now.

Regarding that last question, this seems like an interesting read, which could give us some pointers.

Seems Slack prefers not to use tlmgr, but repackages everything and use their package manager to do that. While that is a sensible decision in some ways, it requires a large amount of bandwidth to do. It might be nice to have tlmgr if people are uninterested in packaging/maintaining something TeX package.

We are having some discussion here on TeX Live and how we should use it in conda-forge. I'm copying you guys ( @damianavila @takluyver @willingc @minrk @rgbkrk @parente @pelson ) as I think we could really benefit from your feedback. The main use cases would be conversion programs like nbconvert and, as such, could be included in things like docker-stacks. If you have any thoughts on how you would like to see it packaged and how you would like to use it, that would be very useful for informing how we might proceed.

BTW: where are additional packages installed to if the user uses the package manager? That was a pain to configure in the miktex package...

To answer this question, @janschulz, the package manager is disabled by default. The source code does not include this possibility. There is a fair question of whether we want to have another package manager used (and if we want it installed by default).
IMHO we should investigate setting up tlmgr, but do so as a separate package (just as is the case with pip). This way if users want to use it to get something we didn't package, they have an option to do so. It should also be an explicit step for them to install it. Though we should really caution against using it for any complex packages and instead try to package those at conda-forge.

At a minimum I'd love to get a baseline test that ensures our use of Tex with nbconvert is handled. Not sure if that means testing notebooks direct or finding out what minimum set of features we need.

The set of Texlive packages in my texlive-selected recipe has enough to run nbconvert — see this file. Be warned that you need to install a fairly large number of Texlive packages to get an installation that runs at all, so if you want to distribute packages individually, you're going to be asking people to install a really large number of little packages. This is what led me to decide to put them all into one big lump.

The set of Texlive packages in my texlive-selected recipe has enough to run nbconvert — see this file.

Thanks for the pointers.

Be warned that you need to install a fairly large number of Texlive packages to get an installation that runs at all, so if you want to distribute packages individually, you're going to be asking people to install a really large number of little packages.

Not sure that there is agreement about breaking them up, but if there is we can still always have a metapackage to handle installation of all of these smaller packages as if they were bundled.

It would be great if we could use tlmgr to freely install non-conda tex packages completely analogously to how pip can be used to install non-conda python packages.

I moved all my work flow to tectonic, installed with conda, and it works great for my needs. Thanks @pkg!

@moskalenko if you can get that build going i'll be happy to merge it.

Luckily pull request #18 has now solved missing pdflatex and latex binaries (which it turns out were just missing symlinks).
Hopefully I'll be able to use conda install -c conda-forge texlive-core in more places, but in others I do still need additional packages via `tlmgr`` or otherwise.

@pkgw What happened to your texlive-selected conda package?

@smithsp I developed tectonic :-)

Would it at least be possible to build xelatex as a part of texlive-core, so JupyterLab could export notebooks to PDF via nbconvert? The nbconvert specifically requires xelatex. Thanks.

I have the same use case (convert notebooks to PDF). I guess it is still not possible to support this use case via conda-forge packages alone?

any chance this is being worked on?


Scala 3: Support nested generic auto-generated mappings

The following construct is fully automatically supported in Scala 2:
case class Inner(val b: String)
case class Outer(val inners: Seq[Inner])

Due to an error that the TSType[Seq[Inner]] cannot be found.
The cause is not entirely clear, the mechanism tot support generics from #180 was replicated and an implicit conversion for Seq[T] is available

Supported in 0.8.2


Webpage rendering error on IE 11, showing blank page.

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
Operating System: Windows server 2016 Base (ami-27a58d5c)
IE version 11.1593.14393
Error Message:
Internet Explorer can't render mxnet.io webpage. Showing blank page with scroll bar.
Debug tool shows:
Could not locate https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/less/grid.less specified in source map https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css.map.

Minimum reproducible example
https://mxnet.io or https://mxnet.incubator.apache.org/
Steps to reproduce
or if you are running standard examples, please provide the commands you have run that lead to the error.

What have you tried to solve it?

@kevinthesun

Did this issue pop up recently? Bootstrap version hasn't been changed since last year.
IE can be problematic since many html5/css3 features are not supported. Use chrome/firefox/safari if possible.


Create CycleSort.cpp

Hi there!!
I added Cycle sort algorithm.

@all-contributors please add @Sravanthgithub  for his code


Use the same syllable time offset for repeated vocal lines by linking lines together

This might be difficult to implement, but I've got an idea that may be useful for everyone. For songs that repeat lines (such as the lines that are present in every chorus), producers often use the same vocal recording. It would be great if users could 'link' duplicate lines, such that changing the position of a syllable marker in one line, changes it by the same offset from a line's starting timestamp in all linked lines.
This would make the LRC file more consistent, and it will also be faster as you don't have to time the syllables for the other linked lines, only the start timestamp.
Hopefully you understand what I mean. I also understand you probably don't want to implement this, but it's also a reminder for myself that I would like this feature.

As you can imagine, this isn't motivating at all.

Difficult to implement.
The same lyrics line does not always have the same timing.
I don't want to add useful functions for the lukewarm work of "sound phrase copy and paste".

Well, if there's one possibility, maybe it's time to make up a new karaoke time format that I used to think about.
[00:00.00]abc [0.50]def [.50]ghi[50]
[00:02.00]jkl [0.25]mno [1.25]pqr[1.]

Except for the beginning of the line, describe the relative time from the previous time.
Well, I didn't pay much attention to the karaoke format, so I stopped thinking about it.
ご想像の通りこれは全くやる気にならない。

実装が難しい。
同じ歌詞行が同じタイミングとは限らない。
サウンドフレーズコピペという手抜きに対する便利機能なんてつけたくない。

まあ一つだけ可能性があるなら、昔考えてた新カラオケタイムフォーマットをでっち上げるときかな？
[00:00.00]abc [0.50]def [.50]ghi[50]
[00:02.00]jkl [0.25]mno [1.25]pqr[1.]

行頭以外は直前の時間からの相対時間を記述する。
まあカラオケフォーマットにそんなに思い入れもないので、思い付き程度で止まってるけど。

Yes, I understand. You're right that they don't always have the same timing, but after the user changed the first occurrence of a line, and realizes it doesn't match up in a different occurrence, they would just 'unlink' them.
I think your offset idea would be great! The users could just copy-paste the first occurrence's timing to all other occurrences in TextEdit, right? And on Download it would use regular timestamps again. That's already very close to my suggestion, and I would love to see that. It seems much easier to implement as well.

No, I won't do it.
This is just an external format, and absolute time is easier when handling it inside the program.
There is no point in converting if the final output is in absolute time. (I'm not enthusiastic about duplicating lines)
いや、やらないよ？
これはあくまで外部フォーマットで、プログラム内部で扱うなら絶対時間の方が楽だし。
最終的に絶対時間で出力するなら変換する意味がない。（私は行の複製に乗り気ではない）


[number-input]: input value not updating correctly on first interaction

🐛 Bug report
When using the number input machine, the input value does not update as expected after pressing the backspace key during the first interaction.
💥 Steps to reproduce

the initial value is "", step value is 1
increment the value using the getIncrementTriggerProps()
the input value will be 1
hit the backspace key
a. the input is now empty
b. we expect api.value to be empty as well, but it's still set to 1
c. and if we check the devtools, we can also see that input html element still holds a value of 1

💻 Link to reproduction

Stacblitz reproduction: https://stackblitz.com/edit/stackblitz-starters-zmtev1?file=pagesContent%2Findex.tsx
🧐 Expected behavior

Following the steps described above, I expected api.value to be set to 0 after step 4
🧭 Possible Solution
I cloned the repo and tried to play with the number-input machine, but I could not figure out the cause of the bug.
However, inside packages/machines/number-input/src/number-input.connect.ts, in the getInputProps function, the onChange callback is not called when reaching the step 4.

🌍 System information

Software
Version(s)

Zag Version
0.78

Browser
brave

Operating System
macos

📝 Additional information

This was surprising to see as well. It must be something with React's onChange handler not getting called.
Switched it to onInput since it's more resilient across frameworks. I will cut a new release shortly.


Crash Docker aeternity/epoch:latest sha256:f41a86443c2c67ed

Expected Behavior
Running container as before. Removed all data, keys etc.
Actual Behavior

Crash after start

Steps to Reproduce the Problem

Pull latest image
Start with black keys and db directory

Logs, error output, etc.
...
ae_1  | 13:08:15.277 [info] Starting aevm
ae_1  | 13:08:15.278 [info] Starting aecore node
ae_1  | 13:08:15.279 [info] Initializing keys manager
ae_1  | {"Kernel pid terminated",application_controller,"{application_start_failure,aecore,{{shutdown,{failed_to_start_child,aec_conductor_sup,{shutdown,{failed_to_start_child,aec_conductor,{{badmatch,{error,beneficiary_not_configured}},[{aec_conductor,init,1,[{file,\"/app/_build/prod/lib/aecore/src/aec_conductor.erl\"},{line,157}]},{gen_server,init_it,2,[{file,\"gen_server.erl\"},{line,365}]},{gen_server,init_it,6,[{file,\"gen_server.erl\"},{line,333}]},{proc_lib,init_p_do_apply,3,[{file,\"proc_lib.erl\"},{line,247}]}]}}}}},{aecore_app,start,[normal,[]]}}}"}
ae_1  | Kernel pid terminated (application_controller) ({application_start_failure,aecore,{{shutdown,{failed_to_start_child,aec_conductor_sup,{shutdown,{failed_to_start_child,aec_conductor,{{badmatch,{error,b
ae_1  |
ae_1  | Crash dump is being written to: erl_crash.dump...done
ae_ae_1 exited with code 1

Specifications

Virtualization: none
Hardware specs:

RAM: 64GB
CPU: i7

OS: Ubuntu 16.04
Node Version:

Latest release (0.18.0) introduced required configuration of beneficiary, please follow the documentation at: https://github.com/aeternity/epoch/blob/v0.18.0/docs/docker.md#generating-beneficiary-account-for-the-first-time to setup and configure it.


Stream Stops if you focus out of the tab

Scenario:
Peer1 - Combines and Share Streams
Peer2 - Received Stream
Peer1 - Looses focus on tab, by navigating to another tab or opening another program
Peer2 - Received Stream stops
Peer1 - Focuses to chrome tab that did the sharing
Peer2 - Resumes receiving the stream
Issue:  Normally, this doesn't happen with WebRtc and Streams, is the issue that the merger is stopped? Is there some way we can continue making the merger work while in the background?

Chrome throttles background tabs, and I assume this includes canvas animation (which the merger relies on). Certain APIs like WebRTC and media playback aren't throttled (else you could never play music in a background tab).
The chrome://flags "Throttle expensive background timers" might work.

Its not really feasible to ask users to turn on/off a flag for our intended use

No, it's not a solution for production. It could rule out Chrome throttling though.

You think that this doesn't happen with other browsers?

I was correct, Chrome is throttling the "requestAnimationFrame" timer. Replacing it with a normal timer does not work either. Sorry, but nothing can be done, Chrome has intentionally blocked animation timers inside background tabs. :/
I'll leave this open if thing change with the Chrome policy in the future.

Firefox has the same policy, and shows the same behaviour.

You can try using another Javascript context to keep the timers running. Webworkers and serviceworkers have been patched, but using a popup window or pinging the client from a server using websockets still works.
I'm closing this issue as it can't be fixed within video-stream-merger. There's no way to implement this without timers.

https://developers.google.com/web/updates/2017/03/background_tabs

Great news everyone who was affect by this issue: Chrome considers tabs with audio playing to be foreground tabs, so video-stream-merger will now play a silent track.
Background throttling will not happen and stream won't freeze! (At least until browsers catch on and fix this...)


Various ToS and DPA updates

Clarifying data definitions (Usage vs. Customer Data)
Clarifying our role as a Controller (under the DPA)
Remove customer's obligation to grant at least 30 days' notice of termination
Remove our obligation to provide 30 days' notice for Termination for Convenience

Note that the changes here to the data definitions and the DPA mirror those we've made in our MSA.


cannot open terminal tool under SSH - linux

when trying to open a terminal window when connected to RPI via SSH i get the following error:
The terminal process failed to launch: A native exception occurred during launch (/lib/arm-linux-gnueabihf/libc.so.6: version `GLIBC_2.28' not found (required by /home/pi/.vscode-server/bin/b3e4e68a0bc097f0ae7907b217c1119af9e03435/node_modules/node-pty/build/Release/pty.node)).
vscode version - 1.78.2
host machine - windows
remote machine - rpi
RPi OS - RPI stretch
when using VSCode version 1.77 all is working well

having the same issue, was working till the update

Confirmed that it was happening in 1.78, but not in 1.77

Merging to https://github.com/microsoft/vscode/issues/181720


(dateRangeChange) does not fire when using the shortcut buttons

(dateRangeChange) does not fire when using the "This week", "Last week" etc shortcuts. It does fire when manually selecting dates. Using Angular 4 and Chrome.

Also [(dateRange)] does not change either. This is visible in the demo too: https://danielykpan.github.io/date-range-picker/
The From/To texts do not change when using the shortcut buttons.

Hi, to trigger the return of the date object from : xxx to: xxx just add << this.dateRangeChange.emit(Object.assign({}, this.datePick)); >> at the end of each case scenario on the switch(range) case :'tm', case 'lm' etc etc
Cheers


Load warning improvements

Load warnings should be relative to the number of cores and not arbitrary. Also, the variable suggested the 5 minute load was being used, but it was 1 minute. Perhaps we could add this as a configuration option?

I don't think this is failing due to my changes ... hopefully :see_no_evil:

@rawkode Cool thing!
Don't worry, the tests do not fail because of your implementation. ;) They fail because you branched off of master, but the tests just had been introduced on next (our development branch, btw.).
Could you rebase your PR against next? That would be awesome, and makes it a lot easier to test for us.
Thanks.

Btw. nproc is linux specific. We need to move that into the OS specific block. On OSX we could use sysctl -n hw.ncpu to get the number of cores. See https://coolaj86.com/articles/get-a-count-of-cpu-cores-on-linux-and-os-x/

New PR (#252) to replace this, as I thought it would be better to create a new branch off of next


No module named carla error

I followed all the instructions in the getting started doc and keep getting the no module name carla error when carla is imported in scenario_runner.py. Any suggestions?
Desktop):

OS: [Windows 10]
CARLA Version [CARLA 0.9.7]
Python version [3.7]

C:\Program Files\CARLA_0.9.5\scenario_runner-master>set CARLA_ROOT=C:/'Program Files'/CARLA_0.9.5
C:\Program Files\CARLA_0.9.5\scenario_runner-master>set PYTHONPATH=$PYTHONPATH:C:/'Program Files'/CARLA_0.9.5/PythonAPI/carla/dist/carla-0.9.5-py3.7-win-amd64.egg:C:/'Program Files'/CARLA_0.9.5/PythonAPI/carla/agents:C:/'Program Files'/CARLA_0.9.5/PythonAPI/carla
C:\Program Files\CARLA_0.9.5\scenario_runner-master>python scenario_runner.py --scenario FollowLeadingVehicle_1 --reloadWorld
Traceback (most recent call last):
File "scenario_runner.py", line 30, in
import carla
ModuleNotFoundError: No module named 'carla'
Here's what I did and the error

Please check your python version: python --version and make sure if it's 3.7

Hey @raeed17. Did you set up the environment variables? You can check #580 or #367 on how to do so (we are also gonna change the Docs soon to explain)

Hey @glopezdiest , I have executed the instructions given in the docs and updated the environment variables manually. Still, I'm getting the error "No module named Carla". Python version is 3.7.6. Can you please help me with this?

I have executed the instructions given in the docs and updated the environment variables manually

We just updated the Docs, so are you referring to "new" docs or the old ones? In any case, that error is because the CARLA .egg isn't being found. Try writing env at a command window an check the PYTHONPATH variable. Is it pointing towards your CARLA .egg?

I have executed the instructions given in the docs and updated the environment variables manually

We just updated the Docs, so are you referring to "new" docs or the old ones? In any case, that error is because the CARLA .egg isn't being found. Try writing env at a command window an check the PYTHONPATH variable. Is it pointing towards your CARLA .egg?

I edited the environment variables from the Control panel. Anyways, No module named "Carla" error is gone now. Thanks for that. :)
When I execute python scenario_runner.py --scenario FollowLeadingVehicle_1 --reloadWorld
I'm getting the following error,
Traceback (most recent call last):
File "scenario_runner.py", line 567, in
sys.exit(main())
File "scenario_runner.py", line 556, in main
scenario_runner = ScenarioRunner(arguments)
File "scenario_runner.py", line 128, in init
signal.signal(signal.SIGHUP, self._signal_handler)
AttributeError: module 'signal' has no attribute 'SIGHUP'

@LikhitaNukala  SIGHUP is not available on Windows. We updated SR recently to avoid this problem. Can you update to the latest version?

@LikhitaNukala As @fabianoboril said, we recently fixed that problem. This is the PR, #561, in case you can't update to the latest version

@fabianoboril I have a scenario runner version 0.9.9, which I have downloaded yesterday. Still I'm getting the error.
So, I have changed the code as @glopezdiest said.

@LikhitaNukala Yeah, that fix was done very recently and ScenarioRunner 0.9.9 doesn't have it. I'd still recommend using the latest version instead of 0.9.9, as we've made some refactor changes but that's obviously up to you. Closing this issue as it seems to be resolved

Hello guys,
I have the same issue.
I've set parameters as below:
set CARLA_ROOT=D:\Softwares\Engineering\Simulators\Carla\WindowsNoEditor
set SCENARIO_RUNNER_ROOT=D:\Softwares\Engineering\Simulators\Carla\scenario_runner-0.9.10
set PYTHONPATH=%PYTHONPATH%;%CARLA_ROOT%\PythonAPI\carla\dist\carla-.egg
set PYTHONPATH=%CARLA_ROOT%\PythonAPI\carla\agents
set PYTHONPATH=%CARLA_ROOT%\PythonAPI\carla
set PYTHONPATH=%CARLA_ROOT%\PythonAPI
after running this code :
python scenario_runner.py --scenario FollowLeadingVehicle_1 --reloadWorld
I get this error:
File "scenario_runner.py", line 44, in
from srunner.scenarioconfigs.openscenario_configuration import OpenScenarioConfiguration
File "D:\Softwares\Engineering\Simulators\Carla\scenario_runner-0.9.10\srunner\scenarioconfigs\openscenario_configuration.py", line 21, in
from srunner.scenarioconfigs.scenario_configuration import ActorConfigurationData, ScenarioConfiguration
File "D:\Softwares\Engineering\Simulators\Carla\scenario_runner-0.9.10\srunner\scenarioconfigs\scenario_configuration.py", line 65, in
class ScenarioConfiguration(object):
File "D:\Softwares\Engineering\Simulators\Carla\scenario_runner-0.9.10\srunner\scenarioconfigs\scenario_configuration.py", line 83, in ScenarioConfiguration
weather = carla.WeatherParameters()
AttributeError: module 'carla' has no attribute 'WeatherParameters'
I am using:
Window 10,
Python 3.7.6
Scenario Runner 0.9.10
I must use this code for my master project.
Thank you all.

@SiNa-Dehbari This is related to python not finding the CARLA egg. Could you check that the CARLA .egg is at the PYTHONPATH and that the path is correct)

Thank you @glopezdiest
I changed the path and fortunately that error was disappeared.
but still I am not able to run any scenario.
I follow these steps:
1- open CarlaUE4.exe
2- run an example from PythonAPI folder. (to make sure everything works fine)
3- open new terminal on scenario runner folder and run this line of code:
python scenario_runner.py --scenario FollowLeadingVehicle_1 --reloadWorld
after this step, my Carla window jumps to new scene and weather changes to sunny or rainy.

but still there is no actions for a scenario and after a while I get this error (in the terminal of Scenario runner)
Preparing scenario: FollowLeadingVehicle_1
ScenarioManager: Running scenario FollowVehicle
Not all scenario tests were successful
Please run with --output for further information
Destroying ego vehicle 667
ERROR: failed to destroy actor 667 : unable to destroy actor: not found
No more scenarios .... Exiting
could you please let me know what should I do?
Thank you in advance

Yeah, you are just missing one more step. This command python scenario_runner.py --scenario FollowLeadingVehicle_1 --reloadWorld creates the scenario, now you have to launch the manual control (the ScenarioRunner version!!), in order to manually move the ego vehicle.

Thank you so much @glopezdiest
I think I have set the variables permanently on windows.
(when I open a new terminal I don't set variables by command any more and I get no error)
but in the 3rd step, I open new terminal and write this command:
python manual_control.py
and get this error:
Traceback (most recent call last):
File "manual_control.py", line 67, in
from examples.manual_control import (World, HUD, KeyboardControl, CameraManager,
ModuleNotFoundError: No module named 'examples'
Have I missed any steps? or is it still related to variable?
and one more thing:
as you are developer of this package and I have to work whit this in future. may I have your email address please?
mine is<EMAIL_ADDRESS>

Dear All,
Regarding to my Problem:
<Traceback (most recent call last): File "manual_control.py", line 67, in from examples.manual_control import (World, HUD, KeyboardControl, CameraManager, ModuleNotFoundError: No module named 'examples'>
I found that on the tutorial for  setting the variables, on the last line instead of   "   ;   "  is  " : ".
<set PYTHONPATH=%PYTHONPATH%:%CARLA_ROOT%\PythonAPI>
and I changed it to ;
<set PYTHONPATH=%PYTHONPATH%;%CARLA_ROOT%\PythonAPI>
and now it works.

Hi SiNa-Dehbari,
I meet the same error of manual control as well, could you please tell me if I need to set the environment variables in the new terminal for manual control? (FYI, I set the environment variables through system. Sadly, I still meet the error after set the environment variables.)
Thanks,
Yang

Hi SiNa-Dehbari,
I meet the same error of manual control as well, could you please tell me if I need to set the environment variables in the new terminal for manual control? (FYI, I set the environment variables through system. Sadly, I still meet the error after set the environment variables.)
Thanks,
Yang

You can also do this :
go to for ex in my case : CARLA_0.9.13\WindowsNoEditor\PythonAPI\carla\dist
You'll find an .egg file for example in my case with python version (py-3.7)
now if you ever wanted to run a python script run it with py -(version of python corresponding to .egg file)
if you have the version of python on your computer then the code will run. if not a message saying that the python version is not installed. Then you have to install the version of python corresponding to .egg file. and always run python code using : py -"version of corresponding python" example.py
Example : py -3.7 .\dynamic_weather.py
-3.7 is the version corresponding to .egg file ( my .egg file is : carla-0.9.13-py3.7-win-amd64.egg )