Possible improvements to analyzer

I gave the new EmmyLuaAnalyzer a whirl and here's some things I found:
Bugs

[x] Hover state does not show class fields

[ ] "Read more" arrow always shows, even with subwindow is empty

[x] ---@deprecated does not appear in hover. Calls to deprecated methods should be ~striken()~.

[ ] Clicking EmmyLua in status bar results in "emmy.stopServer not found" error message.

[x] Putting an invalid path (e.g. "fakedir" into workspace.library in emmyrc.json caused crash on startup. If you change/add this mid-session EmmyLua becomes non-responsive (and stop is broken).

[x] #12

[ ] Completions for ---@ should should only be type annotation related [@class,@param,@return,etc]

[x] #13

[ ] Duplicate functions (with different params) inside a ---@meta are not suggested as multiple options (first wins?)

[ ] Types on ... are not properly checked and ...? is displayed as... in function signatures.

[x] Class field descriptions do not appear as part of extended suggestion, but are present in the hover window.

[x] #14

[ ] Assignments to optional returns (e.g. string? or string|nil do not preserve their nullability in types. This should be _File? or _File?.

[x] workspace.library in .emmyrc.json only works with relative paths. 0.6.15 changelog here says:

Now all places where paths can be filled support relative paths, absolute paths, and ${workspaceFolder} to represent the workspace, ~ to represent the user directory
Tildes do not expanded properly (~/proj becomes /proj). Absolute paths are wrongly concatenated as paths under workspaceFolder. ${workspaceFolder}/../whatever works as designed.

[ ] Assignments should preserve transitive comment annotations.

[x] Quote handling for @alias types is not right (duplicated double quotes): "".  Dunno if the EmmyLua types need to updated.  Here is how LuaLS defines them for reference.

Settings

[x] Please increase the default for workspace.preloadFileSize. Maybe 5120000?

[x] .emmyrc.json: It'd be sweet to have a JSON schema. Then if you set "$schema" to the url users get config validation for free in VSCode. Are you intending to support .laurc.json as well? You're close enough to the LuaLS .luarc.json schema that I think you could implement proper superset of what it supports.

[ ] .emmyrc.json: Please add support for runtime.nonstandardSymbol.  Here's what I use for Playdate Development: ["+=", "-=", "*=", "/=", "//=", "%=", "<<=", ">>=", "&=", "|=", "^="]

Future suggested capabilities

[x] Add colors/tokenize type/names inside comment annotations.  fun(), | and : get fancy colorization, but everything else is just a comment (green).

[ ] Analyzer should warn on duplicate assignments (unless inside ---@meta file)

[ ] Analyzer should warn when assigning incorrect types.

[ ] Analyzer should warn/error when nullable types are not checked for nil before calling. E.g. err:len() should have warning.

[ ] Analyzer should warn when assigning to constants (this will fail at runtime)

Steps to reproduce:

Create a folder with an .emmyrc.json:

{
    "workspace": {
        "preloadFileSize": 5120000,
        "library": [
            "../playdate-luacats"
        ]
    }
}

Checkout https://github.com/notpeter/playdate-luacats/
Profit?

good work, but there are some things that are not as you said. Emmylua does not define syntax highlighting, but instead uses the default highlighting of VScode, which is maintained by Sumneko. The reason you didn't see it is because it was overwritten by your other plugins

Good work yourself! It's impressive to see this coming together.  Sorry to do such a big dump all at once.  I totally understand if some of these are by-design or out-of-scope, but I just wanted to share initial feedback of what I saw using the new LS for a couple hours.
All the screenshots only have the EmmyLua and EmmyLuaCodeStyle extensions installed (I uninstalled Sumneko), but I had wrongly assumed that EmmyLuaVscode and EmmyLuaAnylzer were providing syntax highlighting and grammar definitions (via DocumentSemanticTokensProvider or your own Grammar) but you are correct, this is just the default TextMate syntax highlighting, currently maintained by Sumneko.
Took me a minute to find it, but the main VSCode repo has vscode/extensions/lua which points to the LuaLS/lua.tmbundle repo that I didn't know existed.  Thanks for pointing me in the direction of this.  I'll see if I can take a crack at a PR there which does some basic syntax highlighting of annotations (/me casually dusts off oniguruma regex syntax manual)
Otherwise, enjoy your holiday. Excellent stuff.

By default, the highlighting in VSCode is like this, I don't know why it's not rendered on your computer:

You've asked many questions, and it's hard for me to respond to each one individually. I've turned some tasks into issues and responded within them. For other task questions, I'll give a general response:

Type checking is not currently implemented because type inference is not yet perfect. Also, many linters take time to develop (sumneko lua has been accumulating for several years, and many people submit PRs, I'm basically doing it alone, so it will be slower in terms of time).
The alias issue is how emmylua supported it in the past, but I've tried to be as compatible as possible with both syntaxes.
Regarding the compatibility with .luarc.json, I initially planned to directly use .luarc.json, but I found that many configurations are meaningless to my language service. So, I adopted a form that is basically consistent with it, but to avoid confusion, I didn't directly use .luarc.json, but used .emmyrc.json instead.

Sounds great! I understand if there's certainly a difference in feature set vs LuaLS, but I'm very excited for there to be multiple players in the Lua Language Server space.  Your .NET code is definitely more accessible than LuaLS's mix of Lua and C++ spread across nearly a dozen repos.  I'm going to go ahead and close this issue, I created it mostly to document my first couple hours evaluating it and I thought you would appreciate the feedback.
Excited to see how things progress. In particular, hopefully you can get cross platform builds that don't require the CLR going as that will certainly ease adoption. I think this is part of the success of LuaLS -- it does not need to depend / interop with your target lua environment, everything is batteries-included when you add the extension.
Anyways, impressive work and I hope the feedback was useful.

Because it uses a lot of reflection libraries, it's currently not AOT-compilable. dotnet projects can be compiled in a self-contained manner, but the result of the compilation is to package the entire dotnet runtime, which will cause the package size to increase significantly, roughly from 6mb to 70mb. This is also not conducive to distribution. Initially, this project was written in Rust, and used a lot of libraries and ideas from rust-analyzer. However, at that time, Rust's debugging tools were too poor. After a few years, I see that C# has become very popular now, and various debugging tools are very complete. So I rewrote the project in C#.

Gotcha. 70mb is a little chunky, but I don't think it's out of line.  Looking at my language servers:

Server
Size

lua-language-server
21MB

yaml-language-server
29MB

pyright
29MB

gopls
31MB

typescript-language-server
35MB

rust-analyzer
39MB

vscode-css-language-server
94MB

vscode-eslint
108MB

I'm not super familiar with the modern .NET ecosystem, but if it's possible (even if it includes the whole runtime) I'd suggest building a fat executable.  Developers on MacOS/Linux are unlikely to have a prexisting runtime installed and it's not immediately clear that what is needed is the runtime (scroll down and look in the right-hand column, 72MB) and not the SDK (front and center, 600MB).
You could support an automated install method (e.g. homebrew formula, chocolatey, etc) that installs the CLR as dependency but if you're targeting the widest possible audience I wouldn't worry about another 100MB.


milestone 2 feedback

Good job

[ ] it's better to provide explanation for each graph after it and explain what you see and how that answers your research questions.

[x] explore different types of graphs. you only have bar charts. it's better to have different ways to show the results of your research

Edited the milestone 2 python lab notebook

I tried to include different versions but since most of the entries are non-numerical, it is hence I plotted as bar charts. More/different types of visualizations are created using Tableau. The tableau workbook is uploaded in the repository.


Git Bash no longer works in Console2

I have been using Console2 as my Git terminal, loading in a Git bash window, however I made the mistake of installing Docker, which uninstalled the version of Git that I had, and installed the latest version. Now when I set up my Console2 configuration to load in the Git bash window, opening Console2 will trigger Git bash to open it's own window, outside of Console2..

Hey, this is the issue tracker for the git-scm.com website, not Git itself. If you still want to discuss this issue, you should reach out to the community.
Since this is specifically relevant to G4W, you might also want to follow up over at git-for-windows/git.


Add s3 writer

Description
Convert s3 cli code to also support writing to s3. Writers are added as optional subcommands to the parent command with their own arguments. Custom click.Group introduced to add some custom formatting and text in help messages.
To limit the scope of this PR, most existing files were not touched but instead new files were added for the new flow. This allowed only the s3 connector to be updated without breaking any other ones.

overall looks good. appreciate that you have kept it straightforward. a couple comments/questions.
not this pr, but once we add s3 write support for all connectors, reminder we'll want to bump some docs: README (to include steps for output connectors?), s3 example to include output?, output connectors documentation doc.


Add link to the survey in the footer every page of the EUI

:wq

Changes in this PR:
Add link to the survey in the footer every page of the EUI
Trello card / Rollbar error (etc)
https://trello.com/c/BAkEpDo3/415-eui-feedback-survey
Screenshots of UI changes:
Before

After

[ ] Requires env variable(s) to be updated

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2114db8). Click here to learn what that means.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #642   +/-   ##
=======================================
  Coverage        ?   70.14%
=======================================
  Files           ?       22
  Lines           ?      767
  Branches        ?       35
=======================================
  Hits            ?      538
  Misses          ?      221
  Partials        ?        8

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Breaking change in 4.6.1

https://github.com/ardatan/graphql-tools/pull/3550
I think you accidentially pushed an ESM-only release as 4.6.1. So even if it is a minor release, it has a breaking change that drops CJS.

@ardatan  You're right I did sorry, it has been fixed now in version 4.6.3, if you update to that should resolve the issue 😄

Thank you for this project and also for quick response!

❤


Add Resources Open Sources

Open Source

[x] #49 -
[x] #50 - Top 3 open source business intelligence and reporting tools
[x] #51 - Top 5 open source alternatives to Trello
[x] #52 - Top 5 open source alternatives to Gmail
[x] #53 - Top 4 open source command-line email clients
[x] #54 - Top 7 open source tools and free resources for writing
[x] #55 - Top 10 open source alternatives to Minecraft
[x] #56 - Top 4 open source tools for diagramming in Fedora
[x] #57 - Top 3 open source tools for creating presentations
[x] #58 - Top 3 open source content management systems
[x] #59 - Top 4 open source ERP systems
[ ] #60 - Top 4 open source LDAP implementations
[x] #61 - Top 3 open source alternatives to Google Analytics
[x] #62 - Top 5 open source customer relationship management tools
[x] #63 - Top 3 open source scanning utilities
[x] #64 - Top 4 open source text editors
[x] #65 - Top 8 open source data visualization tools
[x] #66 - Top 5 open source tools for taming text

##Add biome

done


feat(core): add mode include/exclude to input filters option

Status

WIP
Description
Issue: https://github.com/orval-labs/orval/issues/1676
Extend the filters input option by introducing a mode optional parameter to specify if filtering should include or exclude tags or schemas.
Related PRs
List related PRs against other branches:

branch
PR

yesyesufcurs:issues/739
link

Todos

[X] Tests
[X] Documentation
[ ] Changelog Entry (unreleased)

Steps to Test or Reproduce
Add a tag that should be filtered out to orval.config:
output: {
	mode: :"exclude"
    tags: ["pets"]
},

Only endpoints that do not contain the tag "pets" will be generated.

Running the build now.  This looks like a good change.

@jbcam
Thanks for the good reinforcement!
I have just one request. we have tests yaml as a regression test in the tests directory so could you please add a new test case like petstore-filter-exclude-mode to here?
master/tests/configs/default.config.ts#L9-L18

@soartec-lab no problem! should be ok now (and rebased)


Implement stub versioning

[ ] Added or updated tests
[ ] Documented user facing changes

Changes

Implemented folder based stub versioning, as suggested in #1547. Stubs are loaded from stubs/9.0.0 by default, but can be overridden by creating copies in alternate version folders. Any versions that are above the currently installed Laravel version are ignored.
Breaking changes

Laravel 10 stubs cause errors.

Hi,
This looks great. I adjusted it a little bit, so that the common stub files are organized in common folder instead of 9.0.0 And whenever a version needs to override something specific, it can go into it's own folder. And added tests for it.


Review current API mapping and identify any changes we will need for React migration

Although unlikely, we might need to change or update our current APIs to accommodate any work we're going to do during the React migration. @td-usds is building some API documentation for our current state, so it would be good to review that with him, and then discuss a migration plan.

How accurate is https://github.com/CDCgov/prime-reportstream/blob/master/prime-router/docs/openapi.yml ?

Is it correct that this is a non-issue with the new FE work?


Revert "Merge pull request #208 from navikt/java-21-take2"

This reverts commit 00af4223f9a406b14f07fb845e0e999930a48427, reversing changes made to a797f233002a4997a890a9d9e14292e64b4a813b.

Trenger ikke reverte når det virker 😁


Avoid grid3D crash

🦟 Bug fix
Summary
Grid3D is crashing because some of the pointers are not properly initialized
Checklist

[x] Signed all commits for DCO
[ ] Added tests
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[x] codecheck passed (See contributing)
[x] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Is the scene3d test known to be bad?

I think that we probably introduced a flaky test here https://github.com/ignitionrobotics/ign-gui/blob/ign-gui3/test/integration/scene3d.cc#L223-L225


📝 Update/fix links in docs to use HTTPS

The pattern of the first two commit. Replace files inside docs but exclude *.svg by
http://(?!127|local|0\.0|examp|192|flask|docs\.python|callbackhell|jinja|www\.celeryproject)

with
https://

The third commit:
http://flask.pocoo.org/ -> https://flask.palletsprojects.com
http://docs.python-requests.org -> https://requests.readthedocs.io
http://jinja.pocoo.org -> https://jinja.palletsprojects.com
http://www.celeryproject.org/ -> https://docs.celeryproject.org

Awesome! That was very clever! :nerd_face: :rocket:
Thanks for your contribution :coffee:


x/tools/gopls: support autocompletion of unimported packages

See for https://github.com/Microsoft/vscode-go/issues/2484 for context.

When this does get into gopls please send a PR or log an issue to the vscode Go plugin so that we can disable the similar feature (in non module mode) there to avoid duplicate suggestions

@stamblerre
Just a question.
Is this issue means only of stdlib like gocode?
Or, all of packages ingo.mod?

It would be all available packages, not just stdlib.

@stamblerre
great.
Are you doing now developing this feature?
I do not know what you remember me, I maintained nsf/gocode for a while. If you not yet develop this feature, I would want to help you.

I am not actively working on it yet, so you're absolutely welcome to get started on it.

@stamblerre @saibing I found out that this is a difference between https://github.com/saibing/tools & https://github.com/golang/tools/tree/

From https://github.com/microsoft/vscode-go/issues/2575:
There are really two components to this issue. For example (in both cases, time is not imported):

Typing "ti<>" and getting package time as part of the autocompletion results.
Typing "time.<>" and getting autocompletions for the members of package time.

At master, gopls now supports completing all unimported packages. There may still be performance issues, but the functionality exists.

It works now!

It works now!

does it works for go modules gpls? which version is it ?

versions

vscode : 1.39.2
vscode-go: 0.11.7

my settings
 // go settings
    "go.buildOnSave": "off",
    "go.lintTool":"golangci-lint",
    "go.lintFlags": [
        "--fast"
    ],
    "go.useLanguageServer": true,
    "go.languageServerExperimentalFeatures": {
        "documentLink": false
    },
    "[go]": {
        "editor.snippetSuggestions": "none",
        "editor.formatOnSave": true,
        "editor.codeActionsOnSave": {
            "source.organizeImports": true
        }
    },
    "gopls": {
        "usePlaceholders": true, // add parameter placeholders when completing a function
        "completeUnimported": true, // autocomplete unimported packages
        "watchFileChanges": true,  // watch file changes outside of the editor
        "deepCompletion": true,     // enable deep completion
    },

when i type this codes below
package main

func main() {
	time.No
}

gopls output error
[Info  - 5:23:18 PM] 2019/10/22 17:23:18 no completions found
	At = {3 8}
	Failure = cannot resolve time

We don't yet have the exports loaded for the unimported packages, so it won't complete if you type grpc.. However, if you begin typing grpc, you will see the completions suggestions pop up, and then when you select one and hit enter, the corresponding import will be added so you can then add the period and get further completions from the package.

https://github.com/golang/go/issues/31906#issuecomment-545056493

Sorry No suggestions pop up

@chengyayu: Are you using gopls at master? To install it, you have to clone the repo, cd into the gopls directory and run go install.

@chengyayu: Are you using gopls at master? To install it, you have to clone the repo, cd into the gopls directory and run go install.

yes! it works! thanks for your suggestions.

Does anybody know how to make this work for YCM in vim? I've tried to update the code of gopls (in YCM) to master, but the completion of unimported packages still doesn't work.

When we're using go mod and enabling completeUnimported, gopls seems to suggest all modules in module caches. As a result, too many modules appear as candidates.
I think it is helpful that gopls only suggests modules that the project we are editing are depending on excepting indirect modules, isn't it?

We haven't yet implemented ranking for unimported candidates, but I think that issue can be solved with improved rankings. The ordering should probably be something like standard library packages are preferred over dependencies in the main module followed by packages in the module cache.
We still want to suggest packages from the module cache that haven't been added as dependencies because users may still be interested in importing them.

@stamblerre
Thank you for your response!

The ordering should probably be something like standard library packages are preferred over dependencies in the main module followed by packages in the module cache.

It sounds good!

We still want to suggest packages from the module cache that haven't been added as dependencies because users may still be interested in importing them.

I think we have several different needs for completeUnimported like below:

do not complete unimported packages.
complete only standard packages.
2 + direct dependent modules.
3 + indirect dependent modules.
4 + all module caches.

So, I think it is better that gopls provides the option to control completeUnimported behaviour (or change completeUnimported option from just bool type to string type like hoverKind) in addition to sorting you mentioned.
How about this?

I don't think the number of results matters, only the order in which they appear.
So long as the ranking is good, there is no need for any kind of control of filter of the nature you suggest, the editor can just limit the total number of candidates shown.

@110y to @ianthehat's point, why have yet another option (or n+ options), if instead the packages are ranked by some hierarchy? e.g. (autocompletions ranked first to last)

imported packages
stdlib
unimported packages
...

I think the only thing left to do here is turn it on by default.

What about the increased completion latency when there are a lot of unimported packages?

@heschik

I think the only thing left to do here is turn it on by default.

How to turn it on currently?

You can add the following to your VSCode settings:
"gopls": {
    "completeUnimported": true
}

@stamblerre thank you. Any idea why this popup keeps showing?

I already have gopls installed by pressing that Update button. I also tried cloning github.com/golang/tools repo, and ran go install inside the gopls folder.
The popup remains there everything I opened VS Code. Quitting doesn't help.


[HELP] Could you please set the Japanese language so that I can use it in Japan?

There is a Japanese item in the settings, but Japanese cannot be used.
I would be happy if I could at least use Japanese with openAI...

The Japanese locale not working is a limitation of Vector's firmware. It was taken out in 1.7 for whatever reason - and 1.6< doesn't work with wire-pod.
As for adding the language to wire-pod, someone who speaks Japanese will have to come around and add it themselves. I only speak English. The other languages were added thanks to pull requests.


Updated Glarysoft.GlaryUtilities to version <IP_ADDRESS>

PS C:\Users\Test> winget install -m "M:\Git\winget-pkgs\manifests\g\Glarysoft\GlaryUtilities\<IP_ADDRESS>"
Found Glary Utilities [Glarysoft.GlaryUtilities]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.glarysoft.com/gu5setup.exe
  ██████████████████████████████  18.9 MB / 18.9 MB
Successfully verified installer hash
Starting package install...
Successfully installed

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Interesting Build #209502
				Response Code: 0
				Response: An error was encountered while processing request. Exception: <!DOCTYPE html PUBLIC '-//W3C//DTD XHTML 1.0 Transitional//EN' 'http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd'><meta content='text/html; charset=utf-8' http-equiv='content-type'/><title>Service unavailable</title>

Our services aren't available right now

We're working to restore all services as soon as possible. Please check back soon.

0SGYRYQAAAACVoCSK0bV9RJUU0KYiDa4eV1NURURHRTA4MTYAMjFiMzFlYTItZDBmNy00MWFkLTg0Y2MtMDhiZTc3MTU2ODUx

Exception Message: The remote server returned an error: (503) Server Unavailable. (type WebException)


Updates for the Puppet language

This PR resolves two issues with the Puppet language in Linguist:

Updates the language color based on the Puppet Labs style guide
Adds an additional sample to prevent files containing only the line hiera_include('classes') from being categorized as Pascal

For an example of the Pascal mis-classification, please see https://github.com/garethr/puppet-mesos-example/search?l=pascal

:+1: thanks @rji - this will be live in the next release of Linguist (next week some time)


How can i create cakePHP project with laradock?

Maybe you should follow these install instruction:
https://github.com/laradock/laradock#Installation
https://book.cakephp.org/3.0/en/installation.html
*Remember to enter workspace  container to install cakePHP project
*Maybe you need to set httpd.conf or nginx.conf root correctly
Hope this helps.

You have to start by installing Laradock as a fresh project. Once the workspace is up and running, you can then bash into the container and install a CakePHP or any other project for that matter.
This is what i was thinking as well (not specifically for Cake) but for any work i want to do. This whole project seems to a lot more useful than just "Laravel".

I have successfully created my projects in local by nginx, php-fpm and mysql. Thanks you so much!


accuracy of computation

My issue is about https://docs.scipy.org/doc/scipy/reference/tutorial/integrate.html
Reproducing code example:
import scipy.integrate as integrate
import scipy.special as special
integrate.quad(lambda x: special.jv(2.5,x), 0, 4.5)

Result in tutorial:
(1.1178179380783249, 7.8663172481899801e-09)

Actual result:
(1.1178179380783246, 7.866317250224184e-09)

Scipy/Numpy/Python version information:
scipy.__version__  1.4.0.dev0+Unknown
numpy.__version__ 1.16.5
sys.version_info(major=3, minor=7, micro=4, releaselevel='final', serial=0)

What's the issue here? The numbers look very close--are you saying that when you run the code in the docstring & outside of the docstring on the same machine you get different answers with each?
Is it documented somewhere that the results of these calculations should not differ by those amounts when executed in different environments or on different machines?

The difference is smaller than the reported error (that's the second value of the result). And the difference is of the order of the machine epsilon, so it's really the same number.


Repo sync for protected CLA branch

The pull request is created from main637998913277347765sync_temp to main to fix git push error for protected CLA branch

Docs Build status updates of commit 3640d49:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[ Go Live][August 08] (#6651)

[Doc Improvement][Update Tools and SDK revamp for Visual Studio] (#6642)

.

.

Update debug-teams-app-visual-studio.md

.

Update debug-teams-app-visual-studio.md

[Doc Improvement][Update existing code snippet] (#6575)

Doc Improvement

Minor edits

Minor edits

Minor edits

Minor edits

Minor edits

Minor edits

Minor edits

Minor edits

Minor edits

Minor edits

Update msteams-platform/concepts/deploy-and-publish/appsource/prepare/in-app-purchase-flow.md

Co-authored-by: Wajeed-msft<EMAIL_ADDRESS>
Update msteams-platform/concepts/deploy-and-publish/appsource/prepare/in-app-purchase-flow.md

Co-authored-by: Wajeed-msft<EMAIL_ADDRESS>Co-authored-by: Wajeed-msft<EMAIL_ADDRESS>

[Doc Issue][Deeplink to another apps in MS Teams is not supported in mobile platform][2560995] (#6605)

Doc Issue

Minor edits

Minor edits

Update deep-links.md

minor edits
Co-authored-by: v-habibaumme<EMAIL_ADDRESS>

[Doc Improvement][Update deploy Teams app to the cloud using Visual Studio] (#6650)

.

Update deploy-teams-app.md

Update teams-toolkit-overview-visual-studio.md

Co-authored-by: v-ksar<EMAIL_ADDRESS>Co-authored-by: v-silakshmi<EMAIL_ADDRESS>Co-authored-by: Wajeed-msft<EMAIL_ADDRESS>Co-authored-by: v-habibaumme<EMAIL_ADDRESS>

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/deploy-teams-app.md
98
2
link
:white_check_mark:

msteams-platform/toolkit/teams-toolkit-overview-visual-studio.md
95
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f192d76:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/deploy-teams-app.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/teams-toolkit-overview-visual-studio.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


GH Comedy Crusade Project: Capstone Project

In this pull request I

Created
Use semantic HTML tags.
Apply best practices in HTML code.
Used FlexboxUse CSS selectors correctly.
Used CSS Grid
Created Navigation Menu
Created Mobile First UI
Applied JavaScript best practices and language style guides in code.
Use JavaScript to manipulate DOM elements.
Use JavaScript events.
Used objects to store and access data.

https://www.loom.com/share/70393eefae8849dcb0ab4d398f72e37f


your demo does not work in chrome

What happens?
open
https://docs.scalar.com/swagger-editor

swagger-editor:1 Uncaught DOMException: Failed to construct 'WebSocket': The URL's scheme must be either 'ws' or 'wss'. 'https' is not allowed.
at n (https://docs.scalar.com/assets/main-BddZxNko.js:189:19890)
at wye (https://docs.scalar.com/assets/main-BddZxNko.js:189:21742)
at Xat (https://docs.scalar.com/assets/main-BddZxNko.js:189:29302)
at https://docs.scalar.com/assets/main-BddZxNko.js:1835:7498
stuck forever in

works in firefox
What did you expect to happen?
that it works under chrome
OpenAPI Document
No response

fixed by #1907


Real linear memory algoithm

I noticed that the previous implement is not true.
This implement are truly linear memory( but complexity is not good.)

I have to fix
go run main.go -c config.txt 5 ggatgcatgca atgcatgcatg

We have to know the alignment starts from  match or gap.


HAWQ-110. Re-phrase error message for gpcheckhdfs to make it consiste…

Please review and comment.

Look good to me. +1

+1


Prettify list encoding

More closely match official TOML examples for arrays by excluding trailing commas. Also makes dump_list more Pythonic.
For example, the return value for
print(toml.dumps({"data": [1, 2, 3, "abc"]}))
that used to be
data = [ 1, 2, 3, "abc",]
will now be
data = [ 1, 2, 3, "abc" ]

Codecov Report

Merging #349 (99d17a2) into master (3f637db) will decrease coverage by 89.74%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #349       +/-   ##
==========================================
- Coverage   89.74%   0.00%   -89.75%
==========================================
  Files           5       5
  Lines        1063    1062        -1
==========================================
- Hits          954       0      -954
- Misses        109    1062      +953

Impacted Files
Coverage Δ

toml/encoder.py
0.00% <0.00%> (-88.33%)
:arrow_down:

toml/ordered.py
0.00% <0.00%> (-100.00%)
:arrow_down:

toml/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

toml/decoder.py
0.00% <0.00%> (-89.80%)
:arrow_down:

toml/tz.py
0.00% <0.00%> (-88.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f637db...99d17a2. Read the comment docs.

Codecov Report

Merging #349 (99d17a2) into master (3f637db) will decrease coverage by 89.74%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #349       +/-   ##
==========================================
- Coverage   89.74%   0.00%   -89.75%
==========================================
  Files           5       5
  Lines        1063    1062        -1
==========================================
- Hits          954       0      -954
- Misses        109    1062      +953

Impacted Files
Coverage Δ

toml/encoder.py
0.00% <0.00%> (-88.33%)
:arrow_down:

toml/ordered.py
0.00% <0.00%> (-100.00%)
:arrow_down:

toml/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

toml/decoder.py
0.00% <0.00%> (-89.80%)
:arrow_down:

toml/tz.py
0.00% <0.00%> (-88.24%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f637db...99d17a2. Read the comment docs.


Fix deprecation warning in paramater declaration

Updated pos2 and pos4 values from int to float as type implicitly mentioned in parameter declaration as rclpy.Parameter.Type.DOUBLE_ARRAY in publisher_forward_position_controller and publisher_joint_trajectory_controller.
Fixes: #1239 in ros2_controllers

@mergifyio backport humble iron


Add envfile rotation DAG

Fixes

Fixes https://github.com/WordPress/openverse-infrastructure/issues/968 by @sarayourfriend
Description

Adds a DAG to rotate the envfiles in the environment files buckets. The DAG finds the 3 most recent envfiles for each service, and then deletes everything else in the buckets.
Drafted because I'm still trying to understand how best to test this. @stacimc @AetherUnbound if either of y'all have any input/ideas about how to test this, please let me know. I've tried changing the AWS connection locally to test the listing logic, but Airflow expects to be able to write logs to S3 using those same connection credentials, so the tasks fail immediately when they can't write to the logs bucket. Should I give up trying to test against the real buckets and just mock responses out in unit tests? That's about as good as just trying to run it in production and seeing what happens, as it'll depend entirely on whether I get the mocks right... and there's no sure-fire way to test that with our current tools, as far as I know. I've seen this moto library mentioned around before as a good way to mock AWS resources but we don't use it at all, and it's missing implementation for describe_launch_template_versions anyway... it might still be useful for other parts.
Let me know what y'all think. I'll leave this drafted until then/until I come up with something on my own. Thanks in advance.
Testing Instructions

TBD.
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
PRs) or the media properties generator (ov just catalog/generate-docs media-props
for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Here are my suggestions for testing:

Use a connection ID which is specific to this DAG, but defaults to AWS_CONN_ID. This allows the conn ID to be defined locally in your .env file and used exclusively for the actions of this DAG, while all using the same conn ID in production. An example for this is the AWS_RDS_CONN_ID which is used in the staging database restore DAG.
If you want to mock interactions with S3 specifically, you can use the minio instance that gets spun up with the catalog for preloading and operating on S3 file. The add Rekognition labels is an example of this (files in s3-data folder, like the Rekognition one, get loaded in when the stack is first created).
Beyond those needs, I would simply mock the responses from the hook functions. We do this in numerous places throughout the codebase: 1, 2, 3, etc.

Okay, thanks! I'll go with the specific-connection approach first, I do remember now using that to test the RDS snapshot rotation DAG before.


fix: Running tests on static scaffolding gives errors

Brick

[x] model
[ ] feature_brick
[ ] app_ui
[x] service
[ ] service_package

Description
Running the unit tests on static scaffolding did not pass all the auto generated tests.
Steps To Reproduce

Follow the instructions on installing and generating the static scaffolding including tests and home
Make sure mason, mocktail, bloc_test is installed
Run the test
Result is not 100% passed

Expected Behavior
100% tests passed
Screenshots

Additional Context
I just followed the instructions on the documentation for standing up static scaffolding and then ran the test straight after.

Thanks @fedomain - I have created a fix for these issues and incorporated back into the scaffolding_test brick.


Instanda technical test solution sweta

@instanda-technicaltest  can you please review PR : https://github.com/chrisusher-instanda/eShopOnWeb/pull/10


What's the difference between the single_frame_predictions and all_frame_predictions?

video_frames, single_frame_predictions, all_frame_predictions = \     model.predict_video("test.mp4")
I see in function def predictions_to_scenes(), it use the single frame predictions. The single frame predictions has the same shape with all_frame_predictions. We have already predict the frame is whether or not the shot boundry, Why we also want to know the all keyframes predcitions ? is it same?
Thank you for your contribution!

See the paper for details (arxiv.org/abs/2008.04838).
But you can safely use only single_frame_predictions and discard all_frame_predictions.


Error: error creating Connector: error creating Connector: error sending validation request: 404 Not Found

Hello team,
When trying to create a s3 sink connector with the terraform plugin based on the s3-sink-connector example , I got the following error
Error: error creating Connector: error creating Connector: error sending validation request: 404 Not Found

Unfortunately, the error is not very informative and I can't understand either the error comes from some wrong settings/authorisations linked to Confluent or linked to AWS.
Would you mind going me some pointers on how I could fix this error?
Thx!

@npfp thanks for waiting!
Could you confirm if you ran into this issue with this resource definition?

Hi @linouk23
Many thx to get back to me. Indeed, I used this resource definition and finally got the reason:
environment {
    id = confluent_environment.staging.id
  }

wasn't correctly set (I was using a wrong terraform variable) so the error. It took me some time to get to it as I was more looking on the aws credentials part.


Compiler does not warn when adressing the same hub by same relation multiple times

rtjj_1101_aaa_bbb_lnk [TTT] following parent hub common operation list
parent_key_1:  HK_RTJJ_1101_AAA >> HK_RTJJ_1101_AAA  [F1_AAA_BK1F]
parent_key_2:  HK_RTJJ_1101_BBB_TTT >> HK_RTJJ_1101_BBB_TTTTT  [F3XX_BBB_BK1_TTT|F6XX_BBB_BK2F_TTT]
parent_key_3:  HK_RTJJ_1101_BBB_TTT >> HK_RTJJ_1101_BBB_UUUUU  [F3XX_BBB_BK1_TTT|F6XX_BBB_BK2F_TTT]
parent_key_4:  HK_RTJJ_1101_BBB_TTT >> HK_RTJJ_1101_BBB_VVVVV  [F3XX_BBB_BK1_TTT|F6XX_BBB_BK2F_TTT]
key:  LK_RTJJ_1101_AAA_BBB_TTT >> LK_RTJJ_1101_AAA_BBB  [F1_AAA_BK1F|F3XX_BBB_BK1_TTT|F6XX_BBB_BK2F_TTT|F3XX_BBB_BK1_TTT|F6XX_BBB_BK2F_TTT|F3XX_BBB_BK1_TTT|F6XX_BBB_BK2F_TTT]
rtjj_1101_aaa_bbb_lnk [UUU] following parent hub common operation list
parent_key_1:  HK_RTJJ_1101_AAA >> HK_RTJJ_1101_AAA  [F1_AAA_BK1F]
parent_key_2:  HK_RTJJ_1101_BBB_UUU >> HK_RTJJ_1101_BBB_TTTTT  [F4XX_BBB_BK1_UUU|F7XX_BBB_BK2F_UUU]
parent_key_3:  HK_RTJJ_1101_BBB_UUU >> HK_RTJJ_1101_BBB_UUUUU  [F4XX_BBB_BK1_UUU|F7XX_BBB_BK2F_UUU]
parent_key_4:  HK_RTJJ_1101_BBB_UUU >> HK_RTJJ_1101_BBB_VVVVV  [F4XX_BBB_BK1_UUU|F7XX_BBB_BK2F_UUU]
key:  LK_RTJJ_1101_AAA_BBB_UUU >> LK_RTJJ_1101_AAA_BBB  [F1_AAA_BK1F|F4XX_BBB_BK1_UUU|F7XX_BBB_BK2F_UUU|F4XX_BBB_BK1_UUU|F7XX_BBB_BK2F_UUU|F4XX_BBB_BK1_UUU|F7XX_BBB_BK2F_UUU]
rtjj_1101_aaa_bbb_lnk [VVV] following parent hub common operation list
parent_key_1:  HK_RTJJ_1101_AAA >> HK_RTJJ_1101_AAA  [F1_AAA_BK1F]
parent_key_2:  HK_RTJJ_1101_BBB_VVV >> HK_RTJJ_1101_BBB_TTTTT  [F5XX_BBB_BK1_VVV|F8XX_BBB_BK2F_VVV]
parent_key_3:  HK_RTJJ_1101_BBB_VVV >> HK_RTJJ_1101_BBB_UUUUU  [F5XX_BBB_BK1_VVV|F8XX_BBB_BK2F_VVV]
parent_key_4:  HK_RTJJ_1101_BBB_VVV >> HK_RTJJ_1101_BBB_VVVVV  [F5XX_BBB_BK1_VVV|F8XX_BBB_BK2F_VVV]
key:  LK_RTJJ_1101_AAA_BBB_VVV >> LK_RTJJ_1101_AAA_BBB  [F1_AAA_BK1F|F5XX_BBB_BK1_VVV|F8XX_BBB_BK2F_VVV|F5XX_BBB_BK1_VVV|F8XX_BBB_BK2F_VVV|F5XX_BBB_BK1_VVV|F8XX_BBB_BK2F_VVV]

Fixed and covered via t1105c


Create haskell.org/ghcup/

ghcup is becoming the preferred way to install the Haskell tool chain, it should have a place on the official Haskell website; it could start as a simple HTML+CSS+JS webpage.
It would be great if it looked something like the rustup page which has: one sentence describing what it is, a command to run to install the whole toolchain (auto-detected based on OS), where to ask for help, and an "official Rust project" badge.
Once the bootstrap-haskell script is merged this script should also be hosted on haskell.org to make it clear that it's an official offering. Then installing the Haskell toolchain would be as easy as:
curl https://get-ghcup.haskell.org -sSf | sh

/cc @hasufell

If this is just about a subdomain in the haskell infra, it doesn't belong on this repo, which is about the webpage as such. Just reach out to<EMAIL_ADDRESS>when things are ready to go.

You mean people click on haskell-platform, then are told "use ghcup", click on ghcup page, and then download?

Of course not! That would be silly! Rather, what I'd like to happen is that A)  the platform page can give direct install instructions for ghcup (the script would help with this) and furthermore once we have the new platform plans as sketched above, we could even possibly just swap the download page for the platform install page entirely, and it might no longer be controversial to unify in that way.

a subdomain in the haskell infra...reach out to<EMAIL_ADDRESS>
Will do, wasn't sure what the distinction was for what things belonged here vs. in a separate subdir/repo. As @hasufell mentioned this wasn't just about a subdomain but also updating /downloads. This also ties into #221 which I think is a great improvement over what's there now, and could be augmented to include ghcup once it is GA.

we could even possibly just swap the download page for the platform install page entirely

I'd be in favour of that as well, it appears that page already has OS auto-detect which is really nice. Do you know what the release cadence is for Haskell PLatform and when it might be possible to recommend ghcup for Mac?

did we want to add a subdomain still? how/where should it point? or should we host the script directly as well?

My vote would be:
https://haskell.org/ghcup - super simple landing page with what ghcup is and command to get it (a la https://rustup.rs/)
https://get-ghcup.haskell.org - where the script is hosted on the haskell.org domain, indicating its an officially supported project

Someone just gotta do it. The details are not that important. I don't have access to any infrastructure.

just to close the loop, I set up the account and contacted hasufell with the login info.


Document the build script

The defunct release procedure should also be removed from the release notes.

Duplicate of #108.


Some questions...

Hi, I want to do the Super Resolution task by replace the clip text feature with the clip image feature. I think the image feature space and the text feature space must be the one, so I think it can work. but when I just do it, the model just output some white images, what's the wrong?

Hi, I want to do the Super Resolution task by replace the clip text feature with the clip image feature. I think the image feature space and the text feature space must be the one, so I think it can work. but when I just do it, the model just output some white images, what's the wrong?

Hello, I think the image feature space and the text feature space are not the same. Although CLIP has brought the two spaces as close as possible, there is still some gap between them.
Moreover, GALIP uses text features before normalization for training, and it is not appropriate to directly replace text features with image features. You can change GALIP's code and retrain a version based on image features.


Yatin: Watch<EMAIL_ADDRESS>

Yatin requests the watch of the watch_keyword dr\.obohealinghome1411(?:@gmail\.com). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

<EMAIL_ADDRESS>has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by cigien in Charcoal HQ. Reason: 'by request: typo'


setmathface mathbf not working properly

Description
Define \mathbf with \setmathface fails to give anything, see the mwe and the output mwe.pdf.   The example  below used to work great one year ago.
Add info or delete as appropriate:

Relevant for XeTeX
yes
Relevant for LuaTeX
yes
Issue tracker has been searched for similar issues?
I searched and found nothing
Links to <tex.stackexchange.com> discussion if appropriate
no

Minimal example demonstrating the issue
\documentclass{article}

\usepackage[math-style=ISO,bold-style=ISO]{unicode-math}

\setmathfontface\mathbf{MinionMath-Bold}[ Extension = .otf, ]

\setmathfont[%
    Extension = .otf,%
    Scale = 1,%
    Script = Math,%
]{MinionMath-Regular}

\begin{document}

\( \mu \mathbf{\mu}\)

\end{document}

Further details
mwe.pdf
mwe.log

Can someone please find out what goes wrong here?  Perhaps I made a mistake, instead of finding a bug of unicode-math.  Any input is appreciated.

Simply because there's no such \setmathfontface command…

Simply because there's no such \setmathfontface command…

Please read section 4.4 in the unicode-math.pdf.

If you want bold math symbols use \symbf. \mathbf is for loading a bold text font in a mathematical context.


Fix bn_digitcount

bn_digitcount used to use bn_bitcount. This would give the maximum digits, which would often be higher than the actual number. This would result in leading zeroes in bn_format.

Thanks!


Add instrumentation of parcel layer

Instrument HPX parcel transport layer allowing to tie in APEX (or other performance measurement tools)

Moving to the next milestone

This was fixed by merging #2353


Use static imports for standard test utilities

Change
import org.junit.Assert;
to
import static org.junit.Assert.assertTrue;
AND
Update all
Assert.{{ method }}*
to
{{ method }}*

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3171/
Test FAILed.

again

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3173/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3462/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3534/
Test PASSed.

Can you remove the change to alluxio-ui/npm-shrinkwrap.json which is unrelated to this PR?

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3545/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3547/
Test PASSed.


Remove HTTPS from secure wget url

Since wget on the most recent version of the Remarkable firmware (<IP_ADDRESS>) has no certificate validation, it fails.
Quick and dirty justification of the fix:
reMarkable: ~/ wget https://toltec-dev.org/thirdparty/bin/wget-v1.21.1
Connecting to toltec-dev.org (<IP_ADDRESS>:443)
wget: note: TLS certificate validation not implemented
wget: TLS error from peer (alert code 80): 80
wget: error getting response: Connection reset by peer
reMarkable: ~/ wget http://toltec-dev.org/thirdparty/bin/wget-v1.21.1
Connecting to toltec-dev.org (<IP_ADDRESS>:80)
saving to 'wget-v1.21.1'
wget-v1.21.1         100% |*****************************************************************************************| 3042k  0:00:00 ETA
'wget-v1.21.1' saved

Thanks for the PR, but I believe this is already included in #423.


Only two dimensional

It looks as if this code is built only for two dimensions. What's up with that? Please add some kind of note to make it obvious.

does this algorithm support high dimensional data?

looking at the code it is still unclear whether the algorithm supports more than 2 dimensions. Please can someone clarify?

Hi, sorry for the delay. The code only supports two dimensions. The partitioning code and the distance function, both assume that there are only two dimensions to the data.

Has smietana's commit above made the distance calculation multi-dimensional? If so is it possible to alter the partitioning code?

From a quick look at the code it seems that way. I think it should be possible to alter the partitioning code as well, but it is a little bit more involved. I do not know of a generic way that would work for n dimensions, but I think that if you have a specific use case, it may be easier to come up with a custom partitioner for your needs. My memory is fuzzy, but I think one of the challenges was that the data became too sparse in higher dimensions. If you have more details, I could provide some ideas on how to solve it.

Hi, could you give any suggestions to process multi-dimensional vectors and Where I can adjuest the code？


Handle v4 job kill request forwarding

First draft for forwarding v4 job kill request to the right genie box. No tests added yet. Trying to get an early feedback on design.

Looks good so far, however it would be nice if this service can be reused to also route requests for logs.
Does what you have in mind cover this?
If so, could you flesh it out?

@mprimi Are you talking about a service like JobOwnerRoutingService with a method like routeToOwner(jobId) which will do the actual forwarding. This method can be used by any other service(log, job kill) to do the forwarding? Currently what I had in mind was a service which will just return the job owner hostname whether v3 or v4.

?? Not clear to me why will it not work. The end point which serves log would use JobOwnerService like JobRestController.killJob(). Are you looking for that change?

Oh, you're right, it would work, assuming we keep the current plan for log syncing

@tgianos The semantics of the JobOwnerService in my head are to tell which server "owns" the job. For v3 ownership means which server spawned the job. For v4, it means which server has the active connection to the agent. AgentRoutingService in my head is the one which is responsible for keeping track of which server owns the active connection to an agent. Its like a routing table which one can query to get information on how to "reach" an agent(via the active connection). Hence JobOwnerService uses it and JobSearchService to answer the question which server owns the job for v4 and v3 respectively. JobKillService then uses  JobOwnerService to get the owner instead of JobSearchService and does the request forwarding as per its need. Any other service, like the one which is trying to get the logs for a job, will use JobOwnerService to get the owner and do the request forwarding as per its need. Since each service might have different needs for doing forwarding(like which headers to look at) we(I and @mprimi) don't think that there is much value in having a service to do the forwarding. If the need arises later, we can refactor.
To answer your question
"If logs don't exist on any node will this service return a null/empty for which node owns a job?"
JobOwnerService is independent from the kind of request(get log, 'kill jobetc). So, it will be up to log service to decide if it needs the job owner or not. For e.g if logs are implemented such  that for v4 the logs are on the server with the active connection(owner) then log service will useJobOwnerService` else it will not.
This PR was a quick and dirty thing I put up to get early feedback. I have left out answering few of your comments which are just a manifestation of that.
Thanks for the comments.

@tgianos Had a discussion with @mprimi about JobOwnerService. We think that this service is not doing much right now. Its just doing a switch based on a if statement to get the job owner. Its not very clear whether this will be reusable in the getLogs piece. So, to keep things simple I am going to add the method getJobOwnerHostname in JobRestController as a helper and get rid of the JobOwnerService. Later when the implementation of getting logs for v4 is more clear we can refactor.


Plugin does not have proxy support

The plugin does not work in environments where a proxy is in place. The communication with keycloak is not possible in this case.

#34 should fix the problem

Done. Thanks to @domkun for providing a pull request.


Contact

Hey lllyasviel
Thanks for work you've done - Have tried to get in touch previously, but not been super successful so giving this a shot.
Would love to talk about pulling the community together post-SD3 to figure out how we can push openly licensed ecosystem forward. Let me know if you're interested in chatting and we can get in touch to discuss

Have a few other folks pulled in - Let me know if you're interested @lllyasviel


Version 4: Use datediff_bug, refactorings to avoid insert-exec

See CHANGELOG.md
NOTE: The main diff is in a commit by itself here, much easier to read: https://github.com/vippsas/mssql-changefeed/pull/3/commits/5a623a5f306107843e2fee6ffe7eedefe86fa397#diff-6378bb7a92b920b4e31b2d7ffc3f818e6ae8f274640a0af7f2cda7a992f9b980

NOTE: The main diff is in a commit by itself here, much easier to read: https://github.com/vippsas/mssql-changefeed/commit/5a623a5f306107843e2fee6ffe7eedefe86fa397#diff-6378bb7a92b920b4e31b2d7ffc3f818e6ae8f274640a0af7f2cda7a992f9b980


⚠ Empornium has degraded performance

In 5187de1, Empornium ($EMP) experienced degraded performance:

HTTP code: 500
Response time: 1390 ms

Resolved: Empornium performance has improved in 3306f08 after 8 minutes.


Create presets

React
Server (+ Babel)
Client (+ Babel)
Auto-install
Conventions (where files/builds go by default)
...

I want this.  What about you @insin?

My original intent was to separate the low-level .api() stuff from the high-level .presets() (or .features()).
But, seeing it like this, it kinda puts the two concepts together in a way that reads well.
I just can't find an alternative way of doing it that's clean in ES5 (by design) that separates the two, nor do I know if that's truly necessary.

Yes, do want.
Also gives me a path to insin/nwb#112 as I've been bitten by CI failures which eslint-plugin-import would have caught due to case-insensitive/case-sensitive import differences.


[5.9] Avoid creating binding patterns in a couple more positions

5.9 cherry-pick of #1804

Explanation: Allows the parser to correctly parse the patterns case let E<Int>.foo(x) and case let (y[0], x), where only x becomes a binding. Previously we would attempt to treat E and y as bindings.
Scope: Affects parsing of patterns
Issue: rdar://108738034
Risk: Low, only affects code that was previously invalid
Testing: Added tests to test suite
Reviewer: Alex Hoppen

https://github.com/apple/swift/pull/66804
@swift-ci please test


TypeScript Error: failed to transpile tslib.es6.js

Here is all my config hope it help fixing an issue!
> rollpkg build

✓ Cleaning dist folder 1 ms
✓ Checking rollpkg invariants 3 ms
✓ Creating rollup config 0 ms
✗ FAILED AT: Creating esm, cjs builds

TypeScript Error: failed to transpile '[...]/node_modules/tslib/tslib.es6.js'

tsconfig.json
{
    "extends": "rollpkg/configs/tsconfig.json",
    "compilerOptions": {
        "target": "es5",
        "lib": ["esnext"],
        "module": "esnext",
        "moduleResolution": "node",
        "rootDir": "./src",
        "strict": true,
    },
    "include": ["src" ],
    "exclude": [
        "node_modules",
        "**/tests/*",
        "dist"
    ]
}

package.json
{
  [...]

  "name": "vuito",
  "main": "dist/vuito.cjs.js",
  "module": "dist/vuito.esm.js",
  "types": "dist/index.d.ts",
  "sideEffects": false,
  "files": ["dist"],

  [...]
}

Not sure about this.. does upgrading to node v14 help?
Does it work if you don’t add any tsconfig overrides to the extended config?
Also note that if you’re using any web apis you’ll need to add dom to the tsconfig lib field.

I was able to reproduce it, I think it's related to an updated dependency and "target": "es5". In the mean time Rollpkg v0.4.2 should work fine.
npm i --save-dev --save-exact<EMAIL_ADDRESS>

The culprit was rollup-plugin-typescript2, I had to downgrade to v0.29.0. I just published Rollpkg v0.5.1, this should fix the issue.

Alright, thanks for your time and this great lib!
Have a nice day!

@mathix420 when you have a chance can you confirm that v0.5.1 fixes your issue, thanks.

Yes, v0.5.1 fixes this issue!
As my project gone more complex I ended up using a manual rollup config, but I created a branch with the rollpkg if you want to check https://github.com/mathix420/vuito/tree/rollpkg


Enhance test facilities and fixtures

Yes on the xml comments, help would be appreciated

Yes on the xml comments, help would be appreciated

OK, I'll work on it this afternoon.


Remove dead link from Multus cookbook

Signed-off-by: Antonin Bas<EMAIL_ADDRESS>

But the link is not really dead - I read it this week when testing with Macvlan?

The domain name doesn't appear to be registered anymore.

/skip-all

Yeah, probably it happened after my reading (I remember it was Wed).


Move CLI docs generation trigger into CI pipeline

Since some time, the auto-generation of CLI docs doesn't work anymore in the docs repo. (link)
This is due to us skipping CI builds for pushed tags, and also a timing issue between a pushed tags and CLI artifact being built for it and the triggered auto generation which needs that CLI artifact.
This workflow could be fixed by moving the send-event-on-release-push.yml pipeline into the CI pipeline with an if conditional so that it's only being run on (pre)releases. This way, we can be sure that the CLI artifact is already built.
Also, the skip-ci tag needs to be removed from the versionrc file to re-enable builds for release commits.

/unstale

Hello , does this issue still persist ??

Hi @rghdrizzle
The issue is heavily outdated, I will close it.


ability for desmear step function to determine if desmearing is worthwhile based on inputs

Is your feature request related to a problem? Please describe.
For calibrating a synthetic master dark, some frames in the input dataset may need to be desmeared while others may not.  An edit to the structure of the walker could be done to handle this, or we could add optional inputs to the desmear step function to handle this.  This would also be useful for a regular (non-calibration) dataset as well; instead of having the user separately figure out if desmearing is appropriate before specifying a recipe for the dataset, the step function could handle it automatically.
Describe the solution you'd like
There could be inputs for expected values, in e- units, for mean FPN (or perhaps max value for FPN since it may have a mean of 0), read noise, mean CIC, and mean dark current.  If these are not specified, they could be taken from a specified synthesized master dark if appropriate.  (In the context of a recipe for making a synthesized master dark, the user would specify the numbers in the aforementioned inputs.)  If none of these are specified, the step function makes no recommendation.  Based on these inputs and the EM gain and exposure time used for a given frame, the step function would determine how far above the values to be subtracted in the desmearing are compared to the non-smeared noise.  If significantly above (determined by an optional input, number of standard deviations which could default to 2 maybe), the desmearing is recommended.  Then there could be an override flag (True or False) to override the step function's recommendation to smear or not.
Additional context
If there are cases where a user wants to override the desmear step function's recommendations for only a subset of frames in a dataset, then I think a change to the walker's structure would be needed.  This would also be true for any other step function for which a user wants different keyword arguments per frame in an input dataset.

Is this something you want to try to get in this release? Or is this a longer-term project?

It's not necessary for this release.  Just a longer-term project.


bugfix: table list default project name missing

when run table.Load() get request
GET http://service-corp.odps.aliyun-inc.com/api/projects/tables/auto_import_fence_od_dl

restore to old version
GET http://service-corp.odps.aliyun-inc.com/api/projects/my-odps-project/tables/auto_import_fence_aoi_di1

LGTM

LGTM


spelling: Replace occurrences of "iff" with "if"

A common typo is "iff" instead of "if", find and replace the occurrences and add a spelling entry.

Is this definitely a typo? Authors might be using this coming from a more academic background, where  'if and only if'[1] is meant here as a more restrictive conditional 'if'.
[1] https://en.wikipedia.org/wiki/If_and_only_if

Is this definitely a typo? Authors might be using this coming from a more academic background, where 'if and only if'[1] is meant here as a more restrictive conditional 'if'.
[1] https://en.wikipedia.org/wiki/If_and_only_if

The more you know... It does make it harder for spellchecker tools as it isn't recognized.

looks like there might be a few more? (e.g. include/zephyr/xen/public/arch-arm.h, include/zephyr/net/http/parser_url.h, ...)
https://github.com/search?q=repo%3Azephyrproject-rtos%2Fzephyr+"+iff+"&type=code

I didn't modify those, as these files appear to be copies of MIT projects.


Add a cog icon in the DevoxxGenie menu bar

Would be nice to have a cog icon/button in the DevoxxGenie menu so the user can go directly to the Settings page.

Looks like a "Settings" icon is already there, so should be something else that when clicked it takes you to the Settings page.

Yeah, you are right. There is a Cog icon if using the "old" IntelliJ UI. It was replaced by three vertical dots in the new UI.
Maybe a Wrench would be an UI independent solution?

This Wrench icon is part of the IntelliJ Icon Set and wouldn't need additional resources.


Add basic metadata schema

This PR introduces a possible basic metadata schema for orderly2
The contents of inst/schema/outpack.json are really what I think would be most useful to get feedback on. I've done a quick check and I think this makes an acceptable common denominator for orderly. Thoughts I was never totally sure on:

I am not 100% sure about the time element, either in the schema or the interface.  These are things that we track in orderly and I believe they are always things that will exist, but not totally sure.
There are lots of ways of modelling inputs vs dependencies and I've changed my mind a few times already.  The current arrangement is an attempt to minimise how much cross checking between different parts of the schema might be needed
The "extra" fields part is designed to take arbitrary additional data. We might force some sort of namespacing here (so require all keys to contain a dot or colon, such as orderly:displayname)
The "name" field could be more flexible than the we currently have - imagining that this could include incoming/data as a name for example - probably reflecting an on-directory layout but perhaps not?
The parameters field stands out as a little odd, but given the usefulness of filtering based on parameters as simple key-value elements I thought we might keep it here.

I've used openssl for the file hashing because then we can use it to sign the resulting json so that you could increase the level of trust that you have the results are unmodified (so far as you trust the originating server) without having to trust the intermediate nodes, and also so that we can use sha256 rather than md5
I've also sidestepped validating that dependencies are "real", that is that they can be found at the source location. We may want to add that later.
I've also sidestepped important details about where we store these things, and the issues around tracking where things can be found.  I am leaning towards something like:
.outtpack/<locationId>/<name>/<id>

or even just
.outtpack/<locationId>/<id>

for the metadata store, but still noodling around with that.
There are some TODO's in the code, they're mostly just extra validation that could be done, and can be added here or later so long as we like the overall direction

Comments on @EmmaLRussell's comments:
Just commenting on the json schema...

So the outpack schema is intended to be a general description of what would be a report version in orderly, with just the essentials which would need to be supported by any implementation of 'orderly2'?

Yes - this is the minimum set of values that must be provided

You don't intend to include something corresponding to a report here i.e. the code source for the task, as a name or source location? I guess that's going to differ per implementation but you'd always expect there to be something of that nature in the background?

It is expected that at path there will be a directory with all this stuff, and name will be related to the directory (but possibly resolved by the underlying implemenation).  So for orderly/orderly2 we'll have concrete outputs in archive/<name>/<id> which will be passed as path here when running things.  But for other engines it might be useful useful to have more structure to the reports that have been run.

Nothing about traceability by user - corresponding to author/requester?

This has not turned out to be useful in practice!  But when we migrate things we'll pull those over as orderly.author/orderly.requested

How much of this schema is intended to be available before/during/after task has run? Is one of these things getting passed around before it runs, or is it all after the fact? So is Task ID just a UID that can get assigned at any time? (I'd been thinking of it like report version id but maybe it's more like the running key).

Everything here is post task run - most likely we'll need a few primatives for during task run.  Examples include:

collect a set of hashes to confirm that files have not changed (orderly does this already)
dynamic inclusion of dependencies (so copy things over, and record somewhere the dependencies are being used)
dynamic description of outputs (see below)

Does a task necessarily know all of its outputs before it runs? (I think we talked about this possibility before, that outputs might depend on data encountered while running.) In which case, might dependencies be more of a pattern defining a group of files rather than a single known file? Maybe not, if this is all post hoc (as seems to be suggested by inclusion of hashes and file sizes).

At the point where the metadata is written this will be known, but in the general case it won't be needed before the runs.

Comments on @r-ash's comments
Couple of small things noticed in json but looks good.

What I'm not sure about is how this is going to provide the tracking you mention in orderly2 README. Where is info about where this artifact was computed, it's canonical location or where dependencies are fetched from? (maybe this is coming later too?)

This is going to be added on top; the schema here captures the things that would hold independent of that.

Is this going to replace the run rds? Or do we still have use for that?

Run ids being the orderly ones? We'll keep those I think as they've been useful and noone objects to the format (see the regex in the schema).

Where is this going to fit in orderly?

User starts report running orderly_run or orderly_run_remote or via web interface
orderly runs report (as currently does) saving output to drafts
orderly generates outpack for the report run to some location
User commits report
orderly moves report output from drafts to archive & does something with this outpack?
Or maybe only created on commit?

This will become a dependency of orderly - we'll use it to pick up most of the low level running and hashing eventually.  This metadata happens at your step 3, yes, replacing orderly_run.rds really

Also wondering how this will be used when a user runs orderly_pull_archive or orderly_pull_dependencies will we change those functions to read all info from the outpack for that report which is stored on the server?

Not totally sure what you're asking here, but the remote interface will end up being built on this new format yes - nothing we need there is broader than the things currently captured in this metadata subset (name, id, parameters, really - date might also be useful, we get a manifest of files etc).

I still haven't quite understood the relationship between this minimal set of metadata and the full metadata desired for orderly2 (canonical location etc.) Is the idea that this schema will get expanded when the details of those trickier bits are worked out, or is there an envisioned use case for a more pared down metadata format as seen here?

Does https://github.com/vimc/orderly2/blob/main/structure.md help with that?


Ability to pass functions as tag names

Currently you can pass Skate element constructors as tag names (not raw web component constructors, yet), but you cannot pass a raw function.
They have different outcomes. The Skate custom element constructors convert into a string that is the custom element tag name.
Functions should get executed and passed the attrs / props and children so that they can act as templates. Essentially they become stateless, "private" custom elements that behave like templates, but are just functions and are composable.
JSX would look something like this:
function List (props, chren) {
  return
{chren()}
;
}

function Item (props, chren) {
  return
{chren()}
;
}

<List>
  <Item>item 1</Item>
  <Item>item 2</Item>
</List>

This has the greatest impact to templating languages and their ability to compose in functions as tag names, but also can be used by the raw vdom.element() function or Incremental DOM functions as they'd be implemented at that level.
vdom.elementOpen(List);
  vdom.elementOpen(Item);
    vdom.text('item 1');
  vdom.elementClose(Item);
  vdom.elementOpen(Item);
    vdom.text('item 1');
  vdom.elementClose(Item);
vdom.elementClose(List);

or:
vdom.element(List, () => {
  vdom.element(Item, 'item 1');
  vdom.element(Item, 'item 1');
});

I like it. Looks like https://facebook.github.io/react/docs/reusable-components.html#stateless-functions

The only possible issues with this is memory spikes. If you use this, everything between the opening and closing tag will be deferred until later. Worst-case scenario is that it brings it down to the memory usage of something like React or Virtual DOM that build and then discard large trees.


python310Packages.gradient-utils: relax pymongo constraint

Description of changes
Fix build (https://hydra.nixos.org/build/199332661)

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 202813 run on x86_64-linux 1

4 packages built:

python310Packages.gradient
python310Packages.gradient-utils
python39Packages.gradient
python39Packages.gradient-utils


pull-though cache and Hashicorps AWS provider v5.71.0 problems

Following problems appear in the context of pull-though cache and Hashicorps AWS provider v5.71.0 problems:
The condition in pkg/mirror/service.go checks for the first version in the list which is not set for v5.71.0. The Platform check a few lines below does exactly that. So the condition should be removed.
Otherwise this fails:
curl -H "Authorization: Bearer XXXX" https://localhost/v1/mirror/registry.terraform.io/hashicorp/aws/5.70.0.json
{"errors":["core.ProviderVersions doesn't contain any platforms"]}

While testing this I found out, that without BORING_REGISTRY_AUTH_STATIC_TOKEN set the jwt token will be checked in a not so ideal way in pkg/mirror/transport.go. We should only cast the token if it is stored in the context. Example:
curl https://localhost/v1/mirror/registry.terraform.io/hashicorp/aws/5.69.0.json
{"errors":["failed to type assert to string"]}

Please have a look at https://github.com/boring-registry/boring-registry/pull/199 for further details.

Thank you for your contribution!
The project urgently needs better unit test coverage...

Released in v0.15.4. Thanks!


Scale dependent slope

New analyses "scale dependent height/slope/curvature"

The scale dependent slope is simply the square root of the ACF divided by the distance

Thanks for the PR! If it's okay that we keep the unit "1" for slopes, that I can also so the changes on the PR.

Closed with #611


Date is not accurate

Thanks for make great theme.
but i found some bug which is Date is not accurate. (in screenshot)
Do you kwow how to custom a date?
i appreciate your theme again. thanks.

I reply you from my user experience in this theme.
The date is using the format YYYY-mm-dd.
By default must be the format in the file-name (with a '-' before the title of the post) and in the header (the header requires an extended version which I generate using date +"%Y-%m-%d %H:%M:%S %z").
This cannot be changed AFAIK but you can change the way it is viewed in the from page or in each post. I mean, only the low-level version (how you write and publish a post) is the thing that cannot be changed.
Here i show you an example in my _config.yml about how to change the format showed:
theme_config:
	  appearance: "auto"
	  back_home_text: "Atrás"
	  date_format: "%d-%m-%Y"
	permalink: /:categories/:year/:month/:day/:title:output_ext

Thanks @EchedelleLR for the comment. I am closing this issue.


add client title differentiation for streaming support

With other clients, the client/window title would be changed according to what account you're logged in to(in game), allowing multiple sources of different accounts at the same time.

Duplicate of #1918


Is it safe to fork before closing?

I made a bot daemon using TDLib, and want it to fork into the background after authorizationStateReady is received, so the administrator would know whether its login is successful or not. I did some attempts but they ended up in failures. May I do it safely? If so, how? Thank you very much.

You can't fork a process while TDLib is run.

@levlam Ok, that's pretty unfortunate. Thank you anyways.


Reporting errors at invalid positions

I'm submitting a bug report
Webpack version:
2.1.0-beta.25
Please tell us about your environment:
Linux (Kubuntu 16.04)
Current behavior:
After compilation are reported errors on invalid (non-existing) places.
I already asked at SO (no relevant answer), TypeScript (nice guy demonstrated that compiler works fine), awesome-typescript-loader (no response) and angular2-webpack seed (no response). I am not sure if this is a webpack issue, but I would be glad if someone could take a look at it and pinpoint a culprit.
Expected/desired behavior:
Not reporting errors on invalid positions.
Reproduction:

seed I am using - https://github.com/preboot/angular2-webpack/tree/37aa21cae03349e9d1438287e7e0306a8d20ca0e
added following compiler options to tsconfig.json:

    "noImplicitAny": true,
    "noImplicitReturns": true,
    "noImplicitThis": true,
    "strictNullChecks": true,
    "forceConsistentCasingInFileNames": true,
    "skipLibCheck": true

run npm start

Please note there is a few errors which are valid (those in app.module.ts). 19 of 22 reported errors are invalid, reported in non-existing places. (Error in api.service.spec.ts reported by tsc is not printed, probably because only used files for build are compiled?)
Example (the path is in my source, not in some library):
[default] /xxx/src/main.ts:11:96
    Index signature of object type implicitly has an 'any' type.
...
[default] /xxx/src/main.ts:11:853
    Parameter 'store' implicitly has an 'any' type.

Note the high column numbers.
My main.ts:
import { enableProdMode } from '@angular/core';
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';
import { AppModule } from './app/app.module';

// depending on the env mode, enable prod mode or add debugging modules
if (process.env.ENV === 'build') {
  enableProdMode();
}

export function main() {
  return platformBrowserDynamic().bootstrapModule(AppModule);
}

if (document.readyState === 'complete') {
  main();
} else {
  document.addEventListener('DOMContentLoaded', main);
}

It seems that those errors come from libraries after concatenation (just a guess).

What is the expected behavior?
Reporting only existing errors on valid places. If skipLibCheck is enabled then no errros from libraries should be reported.

What is the motivation / use case for changing the behavior?
Be able to build a TypeScript project with strict compiler options turned on.

Browser: not relevant

Language: [TypeScript 2.0.6]

Thank you.

Sounds like an error in a-ts-loader...

Ok, thanks for tip. I'll try the other loader, since maintainer(s) of an awesome-typescript-loader
doesn't seem to care. And I was hoping that I would get a cleanly and easily set up building from seed :disappointed:. Well, time to start learning webpack...

Tried ts-loader and it reports exactly same invalid errors :cry:. Error output is formatted a bit differently, but those errors appear at exactly same places. Seems a bit strange that two different TypeScript loaders would be suffering from an error leading to exactly same invalid errors.
Error in ./src/main.ts
(11,96): error TS7017: Index signature of object type implicitly has an 'any' type.

Error in ./src/main.ts
(11,853): error TS7006: Parameter 'store' implicitly has an 'any' type.

Tested on beta 26.

cc @vladima

@mnn It would be great if you could create a minimal test repo which demonstrate the issue.

Not sure about minimal, but could following suffice? This branch reports only those weird errors (19 in dashboard - npm start).

Problem remains. Tested with newest versions:
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
Updated test repo (this time its in a master branch).

Still broken. :disappointed: All packages in test repo updated to current version just now.

Aaand ... still broken. Updated all packages just now. Versions:
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>

Issue still persists with updated packages. test repo: https://github.com/mnn/angular2-webpack/
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>

Closing due to inactivity. Please test with latest version and feel free to reopen if still regressions. Thanks!


After demo, provide separate indexes for Donor, Sample, and Dataset

After talking with @shirey, we concluded that although this wouldn't be hard, the current single-index can be accommodated in the portal well enough, and there are other higher priorities right now.
After the May demo, this may be prioritized.

We're happy with the combined access, and having to deal with them split out would actually be more work at this point. Closing. (but if someone else would use this, feel free to re-open.)


vai disabled/enabled tests

Issue: Steve Vai
Forward port of https://github.com/rancher/rancher/pull/45945
Problem
Adding in test cases to test Steve with Vai first disabled, then enabled. In addition to testing the results from Steve, also check within the cache database as well.
Solution
Added in validation tests to test with Steve, disabled, enabled and to also check the databases.

Approving but can we get a jenkins pass log for this please?

Jenkins job linked in our internal communication as well ✅
 --- PASS: TestVaiTestSuite (409.50s)
     --- PASS: TestVaiTestSuite/TestVAI (328.09s)
         --- PASS: TestVaiTestSuite/TestVAI/InitialState (21.73s)
             --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled (21.73s)
                 --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretFilters (1.77s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretFilters/Filter_with_negation_and_namespace (0.38s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretFilters/Filter_by_namespace (0.40s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretFilters/Filter_by_name_and_namespace (0.30s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretFilters/Filter_by_single_label (0.31s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretFilters/Filter_by_multiple_labels (0.37s)
                 --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/PodFilters (1.71s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/PodFilters/Filter_by_nginx_image (0.52s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/PodFilters/Filter_by_busybox_image (0.57s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/PodFilters/Filter_by_non-existent_image (0.62s)
                 --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretSorting (5.08s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretSorting/Sort_by_name_ascending (0.87s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretSorting/Sort_by_name_descending (0.74s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretSorting/Sort_by_namespace_ascending (0.64s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretSorting/Sort_by_namespace_descending (0.64s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretSorting/Sort_by_name_and_namespace_ascending (0.60s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretSorting/Sort_by_namespace_and_name_ascending (0.57s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretSorting/Sort_by_name_ascending_and_namespace_descending (0.51s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretSorting/Sort_by_namespace_descending_and_name_ascending (0.51s)
                 --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretLimit (13.04s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretLimit/Paginate_50_secrets_with_limit_10 (3.65s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretLimit/Paginate_100_secrets_with_limit_25 (7.14s)
                     --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/SecretLimit/Paginate_30_secrets_with_limit_50 (2.25s)
                 --- PASS: TestVaiTestSuite/TestVAI/InitialState/TestWithVaiInitiallyDisabled/NormalOperations (0.13s)
         --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest (306.36s)
             --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretFilters (24.33s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretFilters/Filter_with_negation_and_namespace (9.05s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretFilters/Filter_by_namespace (6.80s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretFilters/Filter_by_name_and_namespace (8.47s)
             --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/PodFilters (4.70s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/PodFilters/Filter_by_nginx_image (0.45s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/PodFilters/Filter_by_busybox_image (2.22s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/PodFilters/Filter_by_non-existent_image (2.02s)
             --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretSorting (4.25s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretSorting/Sort_by_name_ascending (0.54s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretSorting/Sort_by_name_descending (0.55s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretSorting/Sort_by_namespace_ascending (0.60s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretSorting/Sort_by_namespace_descending (0.46s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretSorting/Sort_by_name_and_namespace_ascending (0.52s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretSorting/Sort_by_namespace_and_name_ascending (0.50s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretSorting/Sort_by_name_ascending_and_namespace_descending (0.61s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretSorting/Sort_by_namespace_descending_and_name_ascending (0.47s)
             --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretLimit (13.16s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretLimit/Paginate_50_secrets_with_limit_10 (3.99s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretLimit/Paginate_100_secrets_with_limit_25 (7.03s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/SecretLimit/Paginate_30_secrets_with_limit_50 (2.14s)
             --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/CheckDBFilesInPods (16.96s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/CheckDBFilesInPods/Checking_pod_rancher-69c5675d5c-7j4hp (6.04s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/CheckDBFilesInPods/Checking_pod_rancher-69c5675d5c-frb5w (5.50s)
                 --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/CheckDBFilesInPods/Checking_pod_rancher-69c5675d5c-qv42s (5.36s)
             --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/CheckSecretInDB (65.44s)
             --- PASS: TestVaiTestSuite/TestVAI/ToggleVaiAndRetest/CheckNamespaceInAllVAIDatabases (135.16s)
 PASS

Looks good to me but it would be good to have couple of tests -- delete a secret and check for the sorting function. Also, the pagination working as expected after we delete some secrets.


Ability to enable for just a group of users, not for all users on the server

https://github.com/pondersource/sciencemesh-php/issues/181

Admin dialog for this

There's no need admin setting for this case. NextCloud and Owncloud has this feature on its own.


[SPARK-25685][BUILD] Allow running tests in Jenkins in enterprise Git repository

What changes were proposed in this pull request?
Many companies have their own enterprise GitHub to manage Spark code. To build and test in those repositories with Jenkins need to modify this script.
So I suggest to add some environment variables to allow regression testing in enterprise Jenkins instead of default Spark repository in GitHub.
How was this patch tested?
Manually test.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #4363 has started for PR 22678 at commit cc34da8.

Test build #4363 has finished for PR 22678 at commit cc34da8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Sorry for closing the conversation mistakenly @dongjoon-hyun . I will update the documentation soon.

LGTM

retest this please

LGTM, pending Jenkins

Test build #97303 has started for PR 22678 at commit d8e7ad0.

Test build #97303 has finished for PR 22678 at commit d8e7ad0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97303/
Test PASSed.

Merged to master


Origin of the dataset

Hi!
It's a bye but I would like to know the origin of the dataset. Namely if it comes from malaria patients.

hello, can I find out if the patient from the blood cell dataset is an adult or a child? and does the patient have a history of illness and what country or city is the patient from? thanks


Zipping file with spaces in path

ZipArchive needs to surround _filename with double quotes.
E.x.
  'zip ',_filename,' ',tempFilename,' -q' ⍝ This will cause an error

zip /mnt/c/Users/Holdens Thinkpad/Documents/Dyalog APL-64 19.0 Unicode Files/JWTAPL/Dist/bkaw-JWTAPL-2.1.0.zip /tmp/spacequacker_230219664.tmp -q
'zip "',_filename,'" ',tempFilename,' -q' ⍝ This will not
zip "/mnt/c/Users/Holdens Thinkpad/Documents/Dyalog APL-64 19.0 Unicode Files/JWTAPL/Dist/bkaw-JWTAPL-2.1.0.zip" /tmp/spacequacker_230219664.tmp -q

Fixed with 0.115.0


feat: unstoppable domain integration

@amritkumarj thanks for the PR, we actually going to create a separate package for name resolving and then merge this in.

we are in the process of moving name resolving to #154

closing this as #154 and #180 added this feature set, let us know if something is missing


i18n(zh-cn): Update netlify.mdx

Description (required)
Update netlify.mdx
Related issues & labels (optional)

#8952
Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

zh-cn
guides/deploy/netlify.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


index.php/Vichaya - error message is not clear

Test Steps

Entered invalid email or password
Received error message "wrong details"

Problem: Error message is not clear or specific.
Suggested Solution: Change message to "Incorrect username or password."

Done


Missing mapping for some Issue API response items

The ff. Redmine API response items are not being mapped or ignored in the current implementation.

actual_start_date
actual_due_date

May I ask if the above fields be included in the mapping of the API response to an Issue bean?

my recommendation would be to submit this suggestion on redmine.org forum and see if anyone wants to contribute to this library.

Thanks for the quick reply @alexeyOnGitHub.
Would it be okay if I create a PR to update the above mentioned bean?

sure, please include some tests demonstrating that the fix works.

I've file PR. Please check the ff. link.
365

Just a question, would it still be possible to add the same changes to v3?
My project still uses Java 8 and I noticed that master needs to Java 11 to compile.
Not really an expert regarding this matter but I've tried compiling master to a JAR and manually added it to my project and my project would fail to start due to incompatible Java versions.
However, V3 does work properly.

my recommendation would be to migrate to Java 14+ at this point if at all possible. Java 8 has been EOL for years now.
I don't mind if this gets into 3.x branch, but I would prefer someone from redmine.org to drive this - review, test with various redmine versions, approve the PR, etc.  I do not use Redmine anymore and I cannot afford proper testing and reviews for this project at this point.

@alexeyOnGitHub Regarding EOL for Java 8, please see my comment on #353
It is in still under active maintenance until 2022, Commercially it is supported until 2030.
Besides, I can understand that you can not give the project full attention and appreciate your ongoing involvement.
Thank you for that.
@francton14 Changes are good that 4.0.x is still building against Java with minor modifications to the build setup.
@alexeyOnGitHub Would you accept patches to rollback the required runtime dependencies to Java 8 for 4.0.x?

@stolp  if some Redmine team wants to take over this library, they are welcome to make whatever changes they feel right - remove Java 11, drop the fluent-style API and get back to the old style, etc. it is hard for me to imagine requirements for this library if I no longer actively use it.
just out of curiosity - what is the reason that is stopping you from migrating your projects to at least JDK 11? it should be available on all platforms, and its backward compatibility is pretty good.
would it be practical to spend some time migrating the remaining project(s) to Java 11+ (I would suggest Java 14 actually, at least for better NPE handling) - instead of pushing various dependencies back into JDK8 world?

@alexeyOnGitHub I finally took the step from migrating my project to Java 11 a few months ago, so I currently have no personal stake in a backport to Java 8. This product now depends on over 350 other external libraries, so a runtime migration had to be a huge planned effort. Although it may possible easier next time, I am not eager to go to next LTS (17) any time soon.
Being through this, I can feel the pain others like @francton14 may have to go through porting their projects just because a downstream library decided to up their requirements.
The friendliest way for utility libraries is to keep their own runtime requirements as low as possible to make life as easy as possible on their consumers. Look for example at the Apache Commons or Spring libraries. They typically depend on Java 8 (or sometimes even lower) but do work with later versions.
Hence my suggestion and offer to work in that direction. I just like too see this code as usable as possible for everyone. This is not the only project where I am advocating this defensive approach.