chore: optimise rate calculation

Closes #788

Optimized rate calculation as a slope ~ delta(count)/delta(t), instead of summing the count deltas between each of the timestamp interval pairs
Optimized the search for startIndex of TimestampedCounts from linear to binary
Rate calculation remains linear in case of pod restart, which is a rare case

Can anybody explain to me why we introduced the concept of WidowClosed?

Can anybody explain to me why we introduced the concept of WidowClosed?

https://github.com/numaproj/numaflow/pull/795. Ideally, this should be removed by #788

Can anybody explain to me why we introduced the concept of WidowClosed?

#795. Ideally, this should be removed by #788

I was expecting the delta calculation happens during GetRate() which is memory operation only, would not cause any performance issue, there's no need to introduce the complexity to calculate it during metrics fetching.

I was expecting the delta calculation happens during GetRate() which is memory operation only, would not cause any performance issue, there's no need to introduce the complexity to calculate it during metrics fetching.

Won't GetRate be called frequently for auto-scaling?

3 times in 30 seconds.

I was expecting the delta calculation happens during GetRate() which is memory operation only, would not cause any performance issue, there's no need to introduce the complexity to calculate it during metrics fetching.

Won't GetRate be called frequently for auto-scaling?

3 times in 30 seconds.

Can anybody explain to me why we introduced the concept of WidowClosed?

#795. Ideally, this should be removed by #788

I was expecting the delta calculation happens during GetRate() which is memory operation only, would not cause any performance issue, there's no need to introduce the complexity to calculate it during metrics fetching.

Delta calculation only happens once GetRates() is called, prior to that just the counts are fetched and updated in the queue.


FX2 firmware too large?

I just built firmware.bin on 8ae10d25574f583828203a85be58edfd92cbc8c7 and found that it contains over 10 kBytes of text:
firmware$ size glasgow.ihex
   text	   data	    bss	    dec	    hex	filename
      0	  11059	      0	  11059	   2b33	glasgow.ihex

This seems problematic given that the FX2 has only 8kB of RAM.
As one might expect, attempting to load this firmware onto the device fails:
$ sudo result/bin/glasgow  factory
Traceback (most recent call last):
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/bin/.glasgow-wrapped", line 12, in <module>
    sys.exit(main())
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/cli.py", line 656, in main
    exit(loop.run_until_complete(_main()))
  File "/nix/store/yv4pzx3lxk3lscq0pw3hqzs7k4x76xsm-python3-3.7.2/lib/python3.7/asyncio/base_events.py", line 584, in run_until_complete
    return future.result()
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/cli.py", line 337, in _main
    device = GlasgowHardwareDevice(firmware_file, VID_CYPRESS, PID_FX2)
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/device/hardware.py", line 100, in __init__
    self._download_firmware(input_data(f, fmt="ihex"))
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/device/hardware.py", line 80, in _download_firmware
    self._write_ram(address, data)
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/device/hardware.py", line 72, in _write_ram
    self.usb.controlWrite(usb1.REQUEST_TYPE_VENDOR, REQ_RAM, addr, 0, data)
  File "/nix/store/ry142lhv029chh1rh7jsyah11wf7443g-python3.7-libusb1-1.7/lib/python3.7/site-packages/usb1/__init__.py", line 1481, in controlWrite
    sizeof(data), timeout)
  File "/nix/store/ry142lhv029chh1rh7jsyah11wf7443g-python3.7-libusb1-1.7/lib/python3.7/site-packages/usb1/__init__.py", line 1457, in _controlTransfer
    mayRaiseUSBError(result)
  File "/nix/store/ry142lhv029chh1rh7jsyah11wf7443g-python3.7-libusb1-1.7/lib/python3.7/site-packages/usb1/__init__.py", line 133, in mayRaiseUSBError
    __raiseUSBError(value)
  File "/nix/store/ry142lhv029chh1rh7jsyah11wf7443g-python3.7-libusb1-1.7/lib/python3.7/site-packages/usb1/__init__.py", line 125, in raiseUSBError
    raise __STATUS_TO_EXCEPTION_DICT.get(value, __USBError)(value)
usb1.USBErrorInvalidParam: LIBUSB_ERROR_INVALID_PARAM [-2]

The FX2 has 16KiB of RAM (CY7C68013A-56LTXC).

The following is output from glasgow -vv factory, as requested by @whitequark:
$ sudo result/bin/glasgow -vv  factory --revision C
D: glasgow.device.hardware: found revA device without firmware
D: glasgow.device.hardware: loading firmware from /nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/glasgow.ihex
write_ram 58880 1
write_ram 0 6
write_ram 11 3
write_ram 19 3
write_ram 27 3
write_ram 35 3
write_ram 43 3
write_ram 51 3
write_ram 59 3
write_ram 67 3
write_ram 75 3
write_ram 83 3
write_ram 91 3
write_ram 99 98
write_ram 256 3
write_ram 260 3
write_ram 264 3
write_ram 268 3
write_ram 272 3
write_ram 276 3
write_ram 280 3
write_ram 284 3
write_ram 288 3
write_ram 292 3
write_ram 296 3
write_ram 300 3
write_ram 304 3
write_ram 308 3
write_ram 312 3
write_ram 316 3
write_ram 320 3
write_ram 324 3
write_ram 328 3
write_ram 332 3
write_ram 336 3
write_ram 340 3
write_ram 344 3
write_ram 348 3
write_ram 352 3
write_ram 356 3
write_ram 360 3
write_ram 364 3
write_ram 368 3
write_ram 372 3
write_ram 376 3
write_ram 380 3
write_ram 384 3
write_ram 388 3
write_ram 392 3
write_ram 396 3
write_ram 400 3
write_ram 404 3
write_ram 408 3
write_ram 412 3
write_ram 416 3
write_ram 420 3
write_ram 424 3
write_ram 428 3
write_ram 432 3
write_ram 436 3
write_ram 440 1
write_ram 446 10783
Traceback (most recent call last):
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/bin/.glasgow-wrapped", line 12, in <module>
    sys.exit(main())
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/cli.py", line 656, in main
    exit(loop.run_until_complete(_main()))
  File "/nix/store/yv4pzx3lxk3lscq0pw3hqzs7k4x76xsm-python3-3.7.2/lib/python3.7/asyncio/base_events.py", line 584, in run_until_complete
    return future.result()
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/cli.py", line 337, in _main
    device = GlasgowHardwareDevice(firmware_file, VID_CYPRESS, PID_FX2)
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/device/hardware.py", line 100, in __init__
    self._download_firmware(input_data(f, fmt="ihex"))
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/device/hardware.py", line 80, in _download_firmware
    self._write_ram(address, data)
  File "/nix/store/5smg02nfkfy3x29zaqcbmqiicggvg2im-python3.7-glasgow-0.1/lib/python3.7/site-packages/glasgow/device/hardware.py", line 72, in _write_ram
    self.usb.controlWrite(usb1.REQUEST_TYPE_VENDOR, REQ_RAM, addr, 0, data)
  File "/nix/store/ry142lhv029chh1rh7jsyah11wf7443g-python3.7-libusb1-1.7/lib/python3.7/site-packages/usb1/__init__.py", line 1481, in controlWrite
    sizeof(data), timeout)
  File "/nix/store/ry142lhv029chh1rh7jsyah11wf7443g-python3.7-libusb1-1.7/lib/python3.7/site-packages/usb1/__init__.py", line 1457, in _controlTransfer
    mayRaiseUSBError(result)
  File "/nix/store/ry142lhv029chh1rh7jsyah11wf7443g-python3.7-libusb1-1.7/lib/python3.7/site-packages/usb1/__init__.py", line 133, in mayRaiseUSBError
    __raiseUSBError(value)
  File "/nix/store/ry142lhv029chh1rh7jsyah11wf7443g-python3.7-libusb1-1.7/lib/python3.7/site-packages/usb1/__init__.py", line 125, in raiseUSBError
    raise __STATUS_TO_EXCEPTION_DICT.get(value, __USBError)(value)
usb1.USBErrorInvalidParam: LIBUSB_ERROR_INVALID_PARAM [-2]

I also have this patch applied for debugging purposes:
diff --git a/software/glasgow/device/hardware.py b/software/glasgow/device/hardware.py
index b4b8ad6..81c8acd 100644
--- a/software/glasgow/device/hardware.py
+++ b/software/glasgow/device/hardware.py
@@ -68,6 +68,7 @@ class GlasgowHardwareDevice:
             pass

     def _write_ram(self, addr, data):
+        print("write_ram", addr, len(data))
         self.usb.controlWrite(usb1.REQUEST_TYPE_VENDOR, REQ_RAM, addr, 0, data)

     def _cpu_reset(self, is_reset):

This was fixed by commit whitequark/libfx2@a06b7f573f71abe6e. Did you run git submodule update?

Ahh, this commit wasn't present on the commit pointed to in the revC0 tag.

Actually, I don't see how this could be fixed by that commit. The fx2 library appears nowhere in the backtrace. It looks to me like this issue just exists independently in software/glasgow/device/hardware.py.

Good point! Can you try this patch:
diff --git a/software/glasgow/device/hardware.py b/software/glasgow/device/hardware.py
index 8b454a7..7b4d190 100644
--- a/software/glasgow/device/hardware.py
+++ b/software/glasgow/device/hardware.py
@@ -68,7 +68,11 @@ class GlasgowHardwareDevice:
             pass

     def _write_ram(self, addr, data):
-        self.usb.controlWrite(usb1.REQUEST_TYPE_VENDOR, REQ_RAM, addr, 0, data)
+        while len(data) > 0:
+            chunk_length = min(len(data), 4096)
+            self.usb.control_write(usb1.REQUEST_TYPE_VENDOR, REQ_RAM, addr, 0, data[:chunk_length])
+            addr += chunk_length
+            data = data[chunk_length:]

     def _cpu_reset(self, is_reset):
         self._write_ram(REG_CPUCS, [1 if is_reset else 0])

Made it much farther with that patch (although control_write should be controlWrite).


[FEATURE] Create a new Util method for a common pattern

Is your feature request related to a problem?
We have the below pattern in couple of WorkflowSteps in the codebase
inputs.containsKey(foo) ? Booleans.parseBoolean(inputs.get(foo).toString()) : null

This can be refactored into a util method to avoid duplication.
What solution would you like?
Create a Util method in ParseUtils.java file, have the above code in it. Invoke the util method everywhere where the above pattern is found.
What alternatives have you considered?
Keep it as it is
Do you have any additional context?
Add any other context or screenshots about the feature request here.

@martinpkr can you comment on this issue so we can assign it to you?

Will do in 20-25 minutes!
On Thu, 30 May 2024 at 18:51, Daniel Widdis @.***>
wrote:

@martinpkr https://github.com/martinpkr can you comment on this issue
so we can assign it to you?
—
Reply to this email directly, view it on GitHub
https://github.com/opensearch-project/flow-framework/issues/720#issuecomment-2140028113,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU52WT6PESGW5MFEPS7BICDZE5DI7AVCNFSM6AAAAABIP7IAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQGAZDQMJRGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Will do in 20-25 minutes!

You just did, haha!

Didn’t know it worked like that, awesome haha
On Thu, 30 May 2024 at 18:56, Daniel Widdis @.***>
wrote:

Will do in 20-25 minutes!
You just did, haha!
—
Reply to this email directly, view it on GitHub
https://github.com/opensearch-project/flow-framework/issues/720#issuecomment-2140045666,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AU52WTYILORUH44HS65CEO3ZE5D33AVCNFSM6AAAAABIP7IAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQGA2DKNRWGY
.
You are receiving this because you were assigned.Message ID:
@.***>


fix: refractor volumes for Delay Start services

Fix #761
Signed-off-by: Cherry Wang<EMAIL_ADDRESS>

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[ ] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[X] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

This PR blocked edgex-taf-pipeline PR #121.


[libpng] Fix CMake targets

Fix related issue #8704 #8241 #1627.
PR https://github.com/microsoft/vcpkg/pull/3092 rename the static lib name, but doesn't update it in cmake target file.
libpng has no feature that need to test locally.

on osx, vxl failed due to conflict with qt5-location:x64-osx, it should not relate to libpng changes here
Failures:
Building package vxl[core]:x64-osx... done
Installing package vxl[core]:x64-osx...
The following files are already installed in /Users/vagrant/azure_agent/_work/2/s/installed/x64-osx and are in conflict with vxl:x64-osx
Installed by qt5-location:x64-osx
lib/libclipper.a
Elapsed time for package vxl:x64-osx: 20.14 min

The vxl conflict should be solved by https://github.com/microsoft/vcpkg/pull/8777

/azp run

@ras0219-msft, thanks for fix vxl conflict  issue, currently this PR ready to merge.

Any pending issue on this merge request? It would be really helpful for me

@freddy77, currently CI offline for maintenance, we will give priority to merge this PR after the CI back online.

/azp run

@grdowns, please priority to review and merge this PR, thanks!

this PR broke libpng when deploying in a "release-only" mode.

#9198 should fix the problem


Remove the spaces after opening and before closing non empty curly brackets

I wish there was an added setting for formatting the JavaScript. Which removes the spaces after opening and before closing non empty curly brackets.
It is basically the same rule as insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets but for curly brackets instead of square brackets.
Thanks!

Try   "javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false


drivers: input: sbus remote controller support

Add support SBUS RC controller connected through UART
@fabiobaltieri Only open point is the discord discourse regarding event id for signalling status.

I think an event id corresponding to the devices becoming available/unavailabile is not a bad idea in principle as that's effectively the equivalent of an /dev/input node appearing and disappearing

Thanks for the review and coding tips, wasn't aware of the use of BUILD_ASSERT with DT_PROP very nice feature to statically check dts configs.

I think it's better to go for a custom callback at this stage so you have full flexibility to add what you need, we can always look into unifying things later and keep the driver api for backward compability.

I'll take look at the callback when I'll find time to implement CRSF which gives way more metadata.


img-to-svg don't installing

yarn add img-to-svg
> npm ERR! gyp ERR! node -v v14.15.1  npm ERR! gyp ERR! node-gyp -v v7.1.2 npm ERR! gyp ERR! not ok
Please ask for help, does it depend on yarn or node js version?

have the same problem

have the same problem

Just install graphicsmagick first @LeGitHubDeTai @krychaxp
https://formulae.brew.sh/formula/graphicsmagick


added SSHSourceRestriction option

We need the SDRA-green/blue/dev/migration security group to have restricted inbound rules for port 22.
Need to specify correct range for it.
@hradilm @vasicem how can we test if this works?

I think after the deployment we can just look at the security group for the beanstalk app right?


⚠ Bofrost.com has degraded performance

In 58e0752, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 511 ms

Resolved: Bofrost.com performance has improved in eb1691b after 29 minutes.


Internationalization support

Thanks for this awesome library. Keep the great work up!
Does this library support internationalization? E.g drawable on left side will be on right side in case of Arabic language/locale.
My suggestion is to change left/right with start/end to avoid confusion if it supports internationalization.

Sure will look into it. Thanks for the suggestion.

Sounds good works 👍👌
Does it supports DrawableStart and drawableEnd


Can't catch error if no Email client on Android

I'm trying to handle with no email app exception, but it's not work on Android, because its never fall the .catch and .then always return null as result
Alert: Its work fine in IOS
openInbox({
 title: 'Title',
 message: 'Message',
}).catch((err: EmailException) => {
 if (err.message === 'No email apps available') {
  alert('No email');
  } else {
   alert('Default error');
  }
 });

I think this information is indeed currently not passed back from the native bit of the Android integration to the javascript side. Definitely something we could add I think.

I think this information is indeed currently not passed back from the native bit of the Android integration to the javascript side. Definitely something we could add I think.

This would be much appreciated. The lack of throwing an error when no email client is found on Android is potentially a blocker for me right now in using this library.

Anyone able to do a PR for this?

Anyone able to do a PR for this?

Yes, I can. I have already created the fix in a forked repo - will create the PR later today.


community: add SearchResourceEncryptionKey support

Description

Added support for SearchResourceEncryptionKey from azure.search.documents.indexes.models. This enhancement allows for encryption key management within Azure Search resources.

Added mock tests

Hello @baskaryan could you please review this PR ?

Hello @efriis could you please review this PR ?

Hello @baskaryan and @efriis could you please review this PR ?


Link error: undefined reference to all functions when building test_filter

I've built the pcie driver and libxtrxll, but libxtrxdsp results in a linking error:
$git rev-parse --short HEAD
5dc9e4d
$mkdir build
$cd build
$cmake -DFORCE_ARCH=x86_64 -DCMAKE_INSTALL_PREFIX:PATH=$HOME/root ..
$make
Scanning dependencies of target xtrxdsp
[ 11%] Building C object CMakeFiles/xtrxdsp.dir/xtrxdsp.c.o
[ 22%] Building C object CMakeFiles/xtrxdsp.dir/xtrxdsp_filters.c.o
[ 33%] Building C object CMakeFiles/xtrxdsp.dir/xtrxdsp_filters_data.c.o
[ 44%] Building C object CMakeFiles/xtrxdsp.dir/xtrxdsp_no.c.o
[ 55%] Linking C shared library libxtrxdsp.so
[ 55%] Built target xtrxdsp
Scanning dependencies of target test_filter
[ 66%] Building C object tests/CMakeFiles/test_filter.dir/test_filter.c.o
[ 77%] Linking C executable test_filter
../libxtrxdsp.so.0.0.1: undefined reference to `xtrxdsp_iq16_ic16i_avx'
../libxtrxdsp.so.0.0.1: undefined reference to `xtrxdsp_iq16_ic16i_sse2'
../libxtrxdsp.so.0.0.1: undefined reference to `xtrxdsp_iq16_conv64_sse2'
...
../libxtrxdsp.so.0.0.1: undefined reference to `xtrxdsp_ic16i_iq16_avx'
collect2: error: ld returned 1 exit status
make[2]: *** [tests/CMakeFiles/test_filter.dir/build.make:96: tests/test_filter] Error 1
make[1]: *** [CMakeFiles/Makefile2:125: tests/CMakeFiles/test_filter.dir/all] Error 2
make: *** [Makefile:152: all] Error 2

I needed to change CMakeLists.txt to get it to work:
index 2198183..346b153 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -78,7 +78,7 @@ set(GENERIC_TUNE "")
 include_directories(".")

 set(XTRX_DSP_FILES xtrxdsp.c xtrxdsp_filters.c xtrxdsp_filters_data.c xtrxdsp_no.c)
-if(ARCH STREQUAL "x86")
+if(ARCH STREQUAL "x86_64")
     set(XTRX_DSP_FILES ${XTRX_DSP_FILES}
                        xtrxdsp_x86_sse2.c
                        xtrxdsp_x86_avx.c

This is not a proper fix because it breaks x86. Also, the auto-detection using -print-multiarch is broken.

Maybe the intention was to set -DFORCE_ARCH=x86 rather than what I did. Try with that instead.

Yes, the proper way is to use -DFORCE_ARCH=x86. But you're right it's ambiguous for x86_64 target.
I'll incorporate this:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2198183..80f8333 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -78,7 +78,7 @@ set(GENERIC_TUNE "")
 include_directories(".")

 set(XTRX_DSP_FILES xtrxdsp.c xtrxdsp_filters.c xtrxdsp_filters_data.c xtrxdsp_no.c)

-if(ARCH STREQUAL "x86")
+if(ARCH MATCHES "^x86*")
     set(XTRX_DSP_FILES ${XTRX_DSP_FILES}
                        xtrxdsp_x86_sse2.c
                        xtrxdsp_x86_avx.c

Thank you. I patched CMakeLists to default to x86, because I didn't see how to pass the option when using the build procedure shown in the README in https://github.com/xtrx-sdr/images
Haven't been able yet to get the XTRX running, when I connect it over USB nothing gets enumerated on the host. I don't know if that's expected because the XTRX is not flashed yet, or if it is a problem.
I need to compile the kernel module on another machine, which has a mini-PCIe port.

Thanks. This worked for me:
-if(ARCH STREQUAL "x86")
+if(ARCH STREQUAL "x86" OR ARCH STREQUAL "x86_64")

Then:
cmake -DFORCE_ARCH=$(uname -m) ..
make

Testing the programs:
# ./test_xtrxdsp_sc32i_iq16
Total errors: 0
# ./test_filter
CPU Features: SSE2+ SSE4.1+ AVX+ FMA+
Using avx_fma for xtrxdsp_sc32_conv64

And it just hangs indefinitely.
I don't know why cmake was not able to set CC_ARCH though.

USB2 on XTRX itself isn't working, see https://github.com/xtrx-sdr/images/issues/9
./test_filter works differently. It expects data on stdin and produces filtered data on stdout. I.e. it can be used in FIFO or a pipe like style.
Detecting CC_ARCH is based on compiler meta info. Each Linux distribution makes it different so in some cases it won't work well

update to master
feel free to reopen if any problem is discovered


Second level menu items are missing on docs

This is a Bug Report
When left column menu goes 3 levels deep, for example Concepts >> Workloads >> Pod is active,  2nd level items following the active parent, for our example anything that follows "Workloads", are not displayed.
Check the screenshot for the page https://kubernetes.io/docs/concepts/workloads/pods/, items like "Services, Load Balancing, and Networking" that come after Workloads are missing:

Behavior is confirmed for Firefox and Chrome, both in normal and private windows.

/area web-development

@sftim It is not likely a designed behavior because it does not follow a predictable pattern when folding the parent items. Even if that is the case, there should be some indicator because there is no way to know Concepts has hidden items.
Current implementation makes it very hard to navigate between third level pages, i.e from "Pods" or its children to "Services, Load Balancing, and Networking" and its children. More importantly there is no obvious benefit in hiding them.

@snnsnn @sftim  what's the behaviour decided here and is anyone working on this issue?

The SIG Docs consensus was that this isn’t intended behavior, and we should be looking into a PR to address it.
/triage accepted
/lifecycle frozen
/priority backlog

There's no hint at the moment that anyone's working on this.

Pull requests are welcome
Work to diagnose the issue further is welcome

okay, it's reproducible . Will check for the fix. @sftim  you can assign to me.

For Kubernetes SIG Docs, anyone can work on any issue (our more jargon-y way of saying this is “no cookie licking”) and open a pull request to propose a related change.

(for my part, I rarely assign issues to myself - but when I have a draft or finished PR ready, I will link it to the issue and that  provides a hint in the issue about progress).

How to run the website in local?

Are folks still seeing this issue? i was just looking at the site, and second level items under Workloads are now visible when on the Pods page.

@sftim do you know of a PR that may have addressed this? or another example of where this is happening on the site? thanks!
let me know if i'm misunderstanding the issue :)


D18

Moved stuff around for Cohort 18.
Included all changes on Master from December 20th till now.

@brendalong 👍
Merge it!


allow not base units to be found

In some situations base units can't be calculated. In this case the base unit function should return None and no base units should be assigned.

now raising a valueerror of unknown units


Organ donor promotion on completed transaction pg.

https://trello.com/c/caDndyIX
Completed transaction pages need to optionally show organ donor registration promotion. Display is toggled, and 'Join' link URL is configured from Publisher: https://github.com/alphagov/publisher/pull/371

Edit: copy has been updated as required by Nayeema.

If the organ-donor-registration-promotion div is shown, we need to get the title "Satisfaction survey" shown above the survey section. You can see that in the mock-up here.

@marksheldonGDS: updated. thanks for pointing-out!

@edds would you mind giving this a once-over?


guild train mnist:cnn fails when building with a Docker image - always hangs at Step 20

i tried to increase the RAM allocated to the image, but it always fails at the same step.
note:  mnist:softmax works fine.

@cfregly Could you point me to the Dockerfile you're using so I can attempt to recreate this?

Closing for lack of followup. Please feel free to reopen if needed.


[SPARK-21067][DOC] Fix Thrift Server - CTAS fail with Unable to move source

What changes were proposed in this pull request?
This PR aims to fix CTAS fails after we closed a session of ThriftServer.

sql-distributed-sql-engine.md

It seems the simplest way to fix [SPARK-21067].
For example :
If we use HDFS, we can set the following property in hive-site.xml.
<property>
  <name>fs.hdfs.impl.disable.cache</name>
  <value>true</value>
</property>
How was this patch tested
Manual.

Can one of the admins verify this patch?

Links to #25197 #25058 #25218 .

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Test build #4836 has started for PR 25364 at commit 52421d1.

Test build #4836 has finished for PR 25364 at commit 52421d1.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Merged to master, but I left the JIRA open.


sonarr: <IP_ADDRESS>4 -> <IP_ADDRESS>4

Description of changes
https://github.com/Sonarr/Sonarr/compare/v<IP_ADDRESS>4...v<IP_ADDRESS>4
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hm, how did you generate this update? I’ve run updateScript and fetch-deps step gets stuck after #327651 or perhaps some other recent .NET build infrastructure change (or perhaps my patience runs out after ~10 minutes).

@tie I just ran the updateScript locally as
nix-shell maintainers/scripts/update.nix --argstr package sonarr

It did take awhile, maybe ~10 mins -- I walked away while it ran.
FWIW I checked the bot logs before opening the PR -- looks like it's definitely trying to run the script, but I assume it's also timing out.


No module named 'oscar.apps.customer.notifications' when installing in Django 3

Found a bug? Please fill out the sections below.
Issue Summary
I'm trying to install django-oscar according to instructions in docs. after setting everything and trying to test site, I get a message "No module named 'oscar.apps.customer.notifications'" trying to access any page of the site after logging in
Thank you in advance for your help and hard work
Steps to Reproduce
Just did a fresh install and started dev server. did login and got 500 on all pages
Technical details

Python version: 3.6.9
Django version: 3.1.4
Oscar version: 3.0

You've used the instructions for version 2.6 of Oscar, while installing version 3.0 (customer.notifications was moved in Oscar 3). See also https://github.com/django-oscar/django-oscar/issues/3407#issuecomment-644688612 .

Oops, Thank you for your fast answer. although I changed to instructions of v3.0 after a couple steps, I overlooked a change in context_processors.
Great job with Oscar!  I hope to do some contributions to the project in a near future. :-)


Osiris Update

hi guys i needed to ask this question everytime when osiris updates should i need to download again like with new files osiris.sln ?

just change the code in specify files

like changing the new files to the old files

like changing the new files to the old files

just download githubdesktop then u can easily update ur cheat when daniel updated

yea i downloaded the new version bıt everyday its updated 😔


spec/abi.dd: ELF and Mach-O targets now use DWARF EH

Only Win64 targets still use the DigitalMars EH tables support code.

Searching for trailing whitespace
Searching for tabs
./spec/abi.dd:870:	$(P Conforms to the DWARF $(LPAREN)debugging with attributed record
./spec/abi.dd:871:	formats$(RPAREN) Exception Handling conventions.


Reproduction: find stubbed children

Good morning,
I'm wondering how should I test such a scenario. I want to stub some component, but also want to check if this component exists.

This should be a StackOverflow question.
You can pass an object with a custom component stub:
const wrapper = mount(ComponentWithChild, { stubs: {
'child-component' : Component
}})
expect(wrapper.contains(Component)).to.be.true

Thanks @eddyerburgh  for response, but it doesn't solve my issue. In that way Component is not stub, but is rendered.
In similar scenario, when I use shallow instead of mount, I'm able to use expect(wrapper.contains(Component)).to.be.true. In my case I don't want to use shallow, because I want other children to be rendered, but wanted to not render one specific child, because it contains some logic I don't want to be calculated during tests.
This pr was more proposition to implement that question, sorry I didn't create issue for that, but thought that I'll get quicker response by pr ;)

I've updated my previous response, that should do what you want


Add sanity check for date type for sequence function

thanks for working on this
but it looks like this does not match presto semantics
when i try this on presto it succeed, but it sound like it wont succeed here
(1) :
select SEQUENCE(cast ('3892314-06-02'as DATE), cast ('3892314-06-02'as DATE))
the output is
[
"+3892314-06-02"
]
also when run
(2):
select SEQUENCE(cast ('3892314-06-02'as DATE), cast ('3892329-06-02'as DATE))

  "+3892314-06-02",
  "+3892314-06-03",
  "+3892314-06-04",
  "+3892314-06-05",
  "+3892314-06-06",
  "+3892314-06-07" ...

for
(3):
select SEQUENCE(cast ('3892314-06-02'as DATE), cast('4045127-11-23'as DATE))
the expected error message is
result of sequence function must not have more than 10000 entries
also can you add a summary and refer to the fuzzer issue.

@kewang1024 Ke, would you update PR description to explain the problem and proposed solution. Is this behavior consistent with Presto?

@mbasmanova I will be looking at the behavior of date_diff today.

Thanks Laith for catching the issue, if we match java presto’s behavior, then we need to adjust the utilities function (diffTimestamp) instead of sequence function.
On sequence function level, it can only limit the data, however java presto doesn’t have that limit.
After discussing offline, we decide to fix the date_diff instead.


Is Slim-Http and Slim PSR-7 implementations different

Hi,
Is slim framework and https://github.com/slimphp/Slim-Http implementations are different ?
If not, it may be good not to require slim framework itself.

slim http is a fork for slim4 which is still in discussion. slim 3 is the stable psr7 implementation


AIOHTTP Error

$pqa --llm groq/llama3-8b-8192 --summary_llm groq/llama3-8b-8192 ask "what is ARCH"

  + Exception Group Traceback (most recent call last):
  |   File "/Library/Frameworks/Python.framework/Versions/3.11/bin/pqa", line 8, in <module>
  |     sys.exit(main())
  |              ^^^^^^
...
    |   File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/aiohttp/__init__.py", line 254, in __getattr__
    |     raise AttributeError(f"module {__name__} has no attribute {name}")
    | AttributeError: module aiohttp has no attribute ClientConnectionResetError. Did you mean: 'ClientConnectionError'?
    +------------------------------------
sys:1: RuntimeWarning: coroutine 'MetadataPostProcessor.process' was never awaited
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x12a121c50>
Unclosed connector
connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x12ca95e80>, 25720.358243708)]']
connector: <aiohttp.connector.TCPConnector object at 0x1296000d0>
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x12cad2850>
Unclosed connector
connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x12ca96190>, 25719.605680375)]']
connector: <aiohttp.connector.TCPConnector object at 0x12cd0e8d0>

I've tried solving this error for so long, I've previously had some issues with SSL certificates, but those should be resolved by now.  Issue at https://github.com/Future-House/paper-qa/issues/759, should solve the problem but I've used both aiohttp==3.10.6
and aiohttp==3.11.11, both to same problem. Running this on a .venv/bin/python, 3.11, macOS, certifi==2024.12.14, paper-qa==5.8.0. I've exported my GROQ api-key. I've also ran this on a main.py, to no avail.
from paperqa import Settings, ask, Docs
from dotenv import load_dotenv
load_dotenv()

answer = ask(
    "What manufacturing challenges are unique to bispecific antibodies?",
    settings=Settings(
        llm="groq/llama3-8b-8192",
        summary_llm="groq/llama3-8b-8192",
        paper_directory="docs",
    ),
)

├── litellm [required: >=1.44, installed: 1.56.4]
│   ├── aiohttp [required: Any, installed: 3.10.6]
│   │   ├── aiohappyeyeballs [required: >=2.3.0, installed: 2.4.4]
│   │   ├── aiosignal [required: >=1.1.2, installed: 1.3.2]
│   │   │   └── frozenlist [required: >=1.1.0, installed: 1.5.0]
│   │   ├── attrs [required: >=17.3.0, installed: 24.3.0]
│   │   ├── frozenlist [required: >=1.1.1, installed: 1.5.0]
│   │   ├── multidict [required: >=4.5,<7.0, installed: 6.1.0]
│   │   └── yarl [required: >=1.12.0,<2.0, installed: 1.18.3]
│   │       ├── idna [required: >=2.0, installed: 3.10]
│   │       ├── multidict [required: >=4.0, installed: 6.1.0]
│   │       └── propcache [required: >=0.2.0, installed: 0.2.1]

Hi @VSandwar74 looks like you are hitting: AttributeError: module aiohttp has no attribute ClientConnectionResetError. Did you mean: 'ClientConnectionError'?
To share, we use aiohttp==3.11.10 in our local dev right now: https://github.com/Future-House/paper-qa/blob/525bb320e962df7ddff514acb07977999a8d3677/uv.lock#L31-L32
I am thinking you might have a different aiohttp version in your actual env than what is printed by pip list.
When you run your Python module, can you print the aiohttp.__version__ to confirm what version you have?
import aiohttp
from paperqa import Settings, ask, Docs
from dotenv import load_dotenv

print(aiohttp.__version__)

load_dotenv()

answer = ask(
    ...
)


sinkv2(cdc): fix some races of source manager

Signed-off-by: qupeng<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #7986
Issue Number: close #7983
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/run-verify

/run-all-tests

/run-integration-test

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-integration-test

/run-kafka-integration-test

/merge


how to do the same for client.cc with c++?

Can you please run this under these environment variables:
GRPC_VERBOSITY=DEBUG
GRPC_TRACE=cares_resolver,cares_address_sorting
and share the output? That will print some useful extra debug info.
Originally posted by @apolcyn in https://github.com/grpc/grpc/issues/23273#issuecomment-648347127

If you're asking how to set environment variables, I suggest you consult your shell manual.
This isn't a gRPC problem, so I'm closing this.


Virtual fields do not work with associations

Virtual fields do not work with the following setup:
Recipe model
<?php
class Recipe extends AppModel {

	public $hasMany = [
		'Ingredient',
	];

	public $virtualFields = [
		'test' => '1',
	];

}

Ingredient model
<?php
class Ingredient extends AppModel {

	public $belongsTo = [
		'Recipe',
	];

}

Controller
<?php
$this->Ingredient->find('all', [
	'contain' => [
		'Recipe' => [
			'fields' => [
				'test',
			],
		],
	],
]);

@janriokrause Thank your for your report. And sorry for the inconvenience. I didn't know that find() didn't support virtual fields of associations listed in joins option... I'll work around it.

I don't know if we misunderstand, but the core find() call does support virtual fields. Your plugin also supports virtual fields, but fails in certain circumstances like specifying the fields key in contain.
Take a look at these working examples with EagerLoader activated.
$this->Recipe->find('all', [
	'fields' => [
		'test',
	],
]);

$this->Ingredient->find('all', [
	'contain' => [
		'Recipe' => [
			// 'fields' => ['test'],
		],
	],
]);

The second example is the same as above but with commented out fields key. Hence, CakePHP selects all the fields. Even the virtual field is selected correctly. Your plugin only fails when I specify a virtual field in the fields key. But if the array key is outside contain, like my first example, there is no problem at all.

Sorry for my lack of words. Probably, find() doesn't support queries like the following:
$this->Ingredient->find('all', [
	'fields' => [
		'Recipe.test', // virtual fields of associations
	],
	'joins' => [
		[
			'table' => 'recipes',
			'alias' => 'Recipe',
			'type' => 'LEFT',
			'conditions' => [
				'Recipe.id' => 'Ingredient.recipe_id',
			]
		]
	],
]);

And this is that my plguin does. So I need to work around it if fields option is specified. I'll fix it today.

Fixed in version 0.3.0.


Pagination of facets

Problem Description:
Facets will be paginated to reduce network load.
Expected Behavior/Solution:
Support pagination as implemented with https://github.com/project-lux/lux-marklogic/issues/160 and https://github.com/project-lux/lux-marklogic/issues/161
https://github.com/project-lux/lux-frontend/issues/252
Dependencies/Blocks:

Blocked by

https://github.com/project-lux/lux-marklogic/issues/160
https://github.com/project-lux/lux-marklogic/issues/161

@gigamorph - this is moved to dev board for 6/7 performance test.

Approved by UAT

Closing looks good in prod.


Fixed README info for README.md

Current coverage is 95.41%

Merging #3 into master will not affect coverage as of f020737

@@            master      #3   diff @@
======================================
  Files            7       7
  Stmts          131     131
  Branches        24      24
  Methods          0       0
======================================
  Hit            125     125
  Partial          1       1
  Missed           5       5

Review entire Coverage Diff as of f020737

Powered by Codecov. Updated on successful CI builds.


[ALLUXIO-3293] Fix retry policy being invalid when reading local block from a crashed local worker

https://alluxio.atlassian.net/browse/ALLUXIO-3293

alluxio-bot, check this please

alluxio-bot, check this please

alluxio-bot, check this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/221/
Test PASSed.

I feel the retry logic should stay in FileInStream and make BlockInStream simpler (try or fail). The reason is FileInStream already keeps the retry logic and data structures, so it is easier to reason. @snodawn @aaudiber  ? e.g., in FileInStream.positionedReadInternal, we can move mBlockStore.getInStream into the try block and exception will be handled by handleRetryableException and retry continues.

@snodawn can you also remove the CLA missing label of this PR by signing a contribution license agreement. It's all electronic and will take just minutes?

+1 for keeping the retry logic in FileInStream. If BlockInStream.create fails, we can throw a new error containing the failed worker name, then FileInStream can add the worker to the list of failed workers and do the retry.

@apc999 @aaudiber , so we can move mBlockStore.getInStream and updateStream in FileInStream to try block, and add CreateStreamFailedException bringing the failed worker address when failed.  If there is no problem, i will add the test code later.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/272/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/273/
Test PASSed.

Merged build finished. Test PASSed.

@snodawn @aaudiber  I thought a bit more on this patch and realized that it can be actually more complicated than I expected previously.  If we only retry in FileInStream, we have no way to get the failed worker address on creating the BlockInStream. I think that is why initially @snodawn put the retry and update the failed workers in BlockInStream.
I am playing with some fix locally to see if there is a good (clean I mean) workaround and will let you know

@apc999 yes.  One way is to retry in BlockInStream, but it may make BlockInStream seem to be a little complex. Another way is add the failed worker info in a new exception as I do in my new commit, which will need to modify more than one files. Of cause, I think the second way may be more standard.

@snodawn @aaudiber , how about the following fix?
Essentially, this fix aims to achieve:

Update failedWorkers when BlockInStream.create throws exception
Still keep the retry in FileInStream class
Make sure updateStream() and mBlockStore.getInStream() are within the try-catch so retry can proceed.

diff --git a/core/client/fs/src/main/java/alluxio/client/block/AlluxioBlockStore.java b/core/client/fs/src/main/java/alluxio/client/block/AlluxioBlockStore.java
index 9b9ce55175..971cf1fd4b 100644
--- a/core/client/fs/src/main/java/alluxio/client/block/AlluxioBlockStore.java
+++ b/core/client/fs/src/main/java/alluxio/client/block/AlluxioBlockStore.java
@@ -44,6 +44,7 @@ import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

 import java.io.IOException;
+import java.net.ConnectException;
 import java.util.Collections;
 import java.util.List;
 import java.util.Map;
@@ -212,7 +213,12 @@ public final class AlluxioBlockStore {
     if (dataSource == null) {
       throw new UnavailableException(ExceptionMessage.NO_WORKER_AVAILABLE.getMessage());
     }
-    return BlockInStream.create(mContext, info, dataSource, dataSourceType, options);
+    try {
+      return BlockInStream.create(mContext, info, dataSource, dataSourceType, options);
+    } catch (ConnectException e) {
+      failedWorkers.put(dataSource, System.currentTimeMillis());
+      throw e;
+    }
   }

   private Set<WorkerNetAddress> handleFailedWorkers(Set<WorkerNetAddress> workers,
diff --git a/core/client/fs/src/main/java/alluxio/client/file/FileInStream.java b/core/client/fs/src/main/java/alluxio/client/file/FileInStream.java
index b3560c65a1..db528a35bd 100644
--- a/core/client/fs/src/main/java/alluxio/client/file/FileInStream.java
+++ b/core/client/fs/src/main/java/alluxio/client/file/FileInStream.java
@@ -113,8 +113,8 @@ public class FileInStream extends InputStream implements BoundedStream, Position
     CountingRetry retry = new CountingRetry(MAX_WORKERS_TO_RETRY);
     IOException lastException = null;
     while (retry.attempt()) {
-      updateStream();
       try {
+        updateStream();
         int result = mBlockInStream.read();
         if (result != -1) {
           mPosition++;
@@ -122,7 +122,9 @@ public class FileInStream extends InputStream implements BoundedStream, Position
         return result;
       } catch (UnavailableException | DeadlineExceededException | ConnectException e) {
         lastException = e;
-        handleRetryableException(mBlockInStream, e);
+        if (mBlockInStream != null) {
+          handleRetryableException(mBlockInStream, e);
+        }
         mBlockInStream = null;
       }
     }
@@ -151,8 +153,8 @@ public class FileInStream extends InputStream implements BoundedStream, Position
     CountingRetry retry = new CountingRetry(MAX_WORKERS_TO_RETRY);
     IOException lastException = null;
     while (bytesLeft > 0 && mPosition != mLength && retry.attempt()) {
-      updateStream();
       try {
+        updateStream();
         int bytesRead = mBlockInStream.read(b, currentOffset, bytesLeft);
         if (bytesRead > 0) {
           bytesLeft -= bytesRead;
@@ -163,7 +165,9 @@ public class FileInStream extends InputStream implements BoundedStream, Position
         lastException = null;
       } catch (UnavailableException | ConnectException | DeadlineExceededException e) {
         lastException = e;
-        handleRetryableException(mBlockInStream, e);
+        if (mBlockInStream != null) {
+          handleRetryableException(mBlockInStream, e);
+        }
         mBlockInStream = null;
       }
     }
@@ -214,8 +218,9 @@ public class FileInStream extends InputStream implements BoundedStream, Position
         break;
       }
       long blockId = mStatus.getBlockIds().get(Math.toIntExact(pos / mBlockSize));
-      BlockInStream stream = mBlockStore.getInStream(blockId, mOptions, mFailedWorkers);
+      BlockInStream stream = null;
       try {
+        stream = mBlockStore.getInStream(blockId, mOptions, mFailedWorkers);
         long offset = pos % mBlockSize;
         int bytesRead =
             stream.positionedRead(offset, b, off, (int) Math.min(mBlockSize - offset, len));
@@ -227,7 +232,9 @@ public class FileInStream extends InputStream implements BoundedStream, Position
         lastException = null;
       } catch (UnavailableException | DeadlineExceededException | ConnectException e) {
         lastException = e;
-        handleRetryableException(stream, e);
+        if (stream != null) {
+          handleRetryableException(stream, e);
+        }
         stream = null;
       } finally {
         closeBlockInStream(stream);

@apc999, agree.  But moving mBlockInStream = null and stream = null to if block would be better?

looks good. Also make sure to update the javadoc for getInStream to indicate that in case of failure it will update the passed-in failedWorkers map

@snodawn if my proposed fix works for you, can you update this PR (also plugin Andrew's comments)?

@apc999 ok.  I will also add the test code later. And please check again, thanks.

@snodawn that is fine. have you pushed your change here?

@apc999 @aaudiber
I'm sorry to miss closing this PR, and try hard to re-open it, but no effect. So I create a new one in https://github.com/Alluxio/alluxio/pull/7828. And the new codes are pushed there.


Integration Test - Release - 2019/12/03 17:11:44

Auto create for integration test. IssueCommandFlow

#pri1

Just type '#pri3'

#pri2

#pri3

#assign PRMergerTest1

#assign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#reassign PRMergerTest2

GitHub user PRMergerTest2 has been removed from the MicrosoftDocs organization, so they were automatically removed as an assignee.

#reassign NonAllowedUser

NonAllowedUser is not a valid GitHub ID, or is not a collaborator on this repo.

#please-close


Linux App

I Can't Figure Out How To Open The App On Chromebook There's So Many Different Things To Press Inside The Linux Nintendo Switch Discord Status App

I do not have a Chromebook to test this on, but what happens when you try to run the application?


[tests] Add unit tests for the loadbalancer.go functions

/kind feature
What happened:
The cloud-provider-openstack code most related to this project lives in loadbalancer.go which is lacking almost all unit tests. This task is to write tests for all of the functions there. Please note that it is untrivial to create tests for methods using gophercloud library, so calling the OpenStack APIs.
List of Tests:

[x] getSecurityGroupName
[x] getListenerProtocol
[x] GetLoadBalancerName
[x] nodeAddressForLB
[x] getStringFromServiceAnnotation
[x] getIntFromServiceAnnotation
[x] getBoolFromServiceAnnotation
[x] buildMonitorCreateOpts
[x] buildPoolCreateOpt
[x] buildBatchUpdateMemberOpts
[x] buildListenerCreateOpt
[x] getMemberSubnetID
[x] getSubnetID
[x] getNetworkID
[ ] checkListenerPorts
[x] updateServiceAnnotations
[ ] createLoadBalancerStatus
[ ] GetLoadBalancerSourceRanges

/assign

I am currently working on these functions:
getBoolFromServiceAnnotation
buildBatchUpdateMemberOpts
buildListenerCreateOpt
updateServiceAnnotations

Working on getSecurityGroupName,GetLoadBalancerSourceRanges,getSubnetId

@sakshi-1505: I think getSecurityGroupName() is being done here: https://github.com/kubernetes/cloud-provider-openstack/pull/2389.  I will close the PR since I guess there is one already created but needs some more changes.

@dulek I guess there are multiple PRs created, out of which none is merged but those Prs occupy 50% of the function listed above. Do you think there is some other level 2 task I can pick? I have already built devstack on my local machine as was suggested in the Outreachy guide before I jumped on picking these issues.

I already open a PR for

getSecurity group name
Getloadbalancername
nodeaddressforlb
GetStringfromserviceannotation
Updateserviceannotation
GetnetworkId
GetMembersubnetId

And I am currently working on ‘Getloadbalancersourcerange’

Ugh, I had created a PR already for that #2401. I will close the PR since I guess there is one already created but needs some more changes.

I already opened a PR for this :
https://github.com/kubernetes/cloud-provider-openstack/pull/2389

@sakshi-1505: I'll try to find more functions that are lacking unit tests and allow writing tests fairly easily. The problem is that gophercloud is pretty hard to mock, so any functions actually making calls to OpenStack are problematic.
@KingDaemonX: I think it'll be better to make sure some of the functions can be worked on by the rest of the participants. You've definitely already proven your dedication and golang proficiency.

Okay!  I will drop this “Getloadbalancersourcerange” that isn’t in the PR and look into some other stuff

@sakshi-1505: I'll try to find more functions that are lacking unit tests and allow writing tests fairly easily. The problem is that gophercloud is pretty hard to mock, so any functions actually making calls to OpenStack are problematic.

@dulek It's fine if there are not enough functions, I can try contributing to another issue.

The problem is that gophercloud is pretty hard to mock, so any functions actually making calls to OpenStack are problematic.

How about we run a devstack & prefer to run integration tests for such functions instead of unit tests?

Hello @dulek i'm currently working on
buildMonitorCreateOpts
buildPoolCreateOpt
getSubnetID

I am working on checkListernerPorts, createLoadBalancerStatus, GetLBSourceRanges.


keys are not trimmed

Version: 0.4.2
OS: OSX (but irrelevant)
I came across this issue when attempting to render a cookiecutter template from a user config
where there was a space between a key and the colon.
While this is very trivial, it is hard to root cause because the error message is something like
Error message: 'dict object' has no attribute 'python_3_6' and only careful examination of the dumped structure shows the problem
"interpreter_versions": {
            "python_2_7": "no",
            "python_3_5": "no",
            "python_3_6 ": "yes",
            "python_3_7": "yes"
        },

How to reproduce
If you take this (valid) YAML example and parse it through poyo
python_3_6 : yes

you get (note the space after the python_3_6 key
>>> from poyo import parse_string
>>> config = parse_string("python_3_6 : yes")
>>> config
{'python_3_6 ': 'yes'}

whereas it should have been {'python_3_6': 'yes'}

Hi @lbrack! 👋
Thank you for raising this bug!

Thanks again @lbrack! This should be fixed on master now. 🐓


Errors on compile

This line of code is causing a few errors for me wherever it is used:
const TArray< TWeakObjectPtr<UObject> >&SelectedObjects = DetailLayout.GetDetailsView().GetSelectedObjects();
Errors: C2228 C2530
"Left of '.GetSelectedObjects' must have class/struct/union"
"'SelectedObjects': references must be initialized"

Seems you are using UE 4.18. Please make sure you downloaded the corresponding branch: https://github.com/Phyronnaz/Voxel/tree/4.18/


Standard Email field is not excluded from the translation of Preferred Email

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Unless a customer clears out all email fields AND sets the Preferred Email value to the translated version of 'None' then the Standard Email field label is set as the Preferred Email picklist value in non-english language orgs.

What is the expected behavior?
The Standard email field is excluded from translations associated to Preferred Email.

What is the motivation / use case for changing the behavior?
This localization issue impacts customers working in non-english language orgs and can cause them to encounter errors as well as confusion working in EDA.

Steps to reproduce:

Using Spanish language as an example:

Verify Translation Workbench is enabled and that the Spanish language is active.
Verify Preferred Email is enabled in EDA Settings
In Translation Workbench select Translate and verify that the picklist values for Preferred Email have been translated.
Create a Contact and enter a value into the University Email field.
Notice that the Preferred Email is now set to 'University Email' AND that the standard email field is populated with the University Email email address.
Click on View Profile --> Settings --> Language & Time Zone and change Language from English to Espanol. Click Save.
Navigate back to the Contact record you created and confirm that you see the translated picklist value for Preferred Email
ex: Correo electrónico de la universidad
Edit the Preferred Email field and select the value of '--Ninguno--' and click Save.
You will encounter a translation error that basically indicates: Select a value for E-mail preference.
Clear out the value of the University Email field and click Save
Notice that the translated value for the Standard Email field is now the value set for Preferred Email. (i.e. 'Correo electrónico')
Clear out the value for the Standard Email field and set the Preferred Email field to the value of '--Ninguno--' and click Save.
The Preferred Email field value clears out and works as expected

Workaround:

Keep Preferred Email enabled AND clear out the values of all email fields, then set the Preferred Email value to '--Ninguno--' and click Save. Doing so will clear out the value of Preferred Email.
Disable Preferred Email (least recommended approach).

See W-10150836

Please follow this Known Issue in the Trailblazer Community for updates.


spec changed, update basic packages to 1.0.29, service packages to 1.…

…0.27, cli to 1.0.52

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.asssaver97 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Fixed #25743 -- Bail early if the input to localize(_input) is a string

More details at https://code.djangoproject.com/ticket/25743

merged in 9a2aca60304dc2e98f9ef45636e129d225cb981f, thanks!


Remove form element from multiple input field

As a developer, when I save a value in particular input field (Refer attached image)  I should be able to remove that whole element from the list. So is it possible to do it or is there any way to do that (I'm using latest version 0.8.13)

I need a gist of what you are doing to be able to help, an image doesn't provide enough information for anyone to support your issue.
The example demo has a "Save to Gist" button you can use to create one from a schema and form definition.

Scenario is like this. Initial, I have 'Add List' button then I click Add List button so if it display a new field with Input field with save button. It is possible to add any number of fields like that. Then, it is needed to input some thing on input filed and then click save.
So when someone click save button, it is needed to save the data and remove that particular field (Same behaviour which is done by the 'X' icon at top of each field).
I hope this clarify the scenario what i am looking for and information needs for you.
Rgs,
Anushka

Take a look at the example page and look at the array example. You can add any field type inside an array including a button, by default the array will also have an X for removal and you can listen for Angular destroy events to capture the backend changes you need.
Please re-open if you do not feel the question has been answered sufficiently :)

Hi @Anthropic, what i need is, it needs to remove that particular array element which user click save button with out any user interaction. User clicks save button and that field is remove from the form array. How can i user angular destroy event for that ??

@anushkamahesh in that case you would have the function called by the save button handle it all, so you don't need the destroy event for that case, just call your save function and on confirmation from the server that it was saved, splice the item out of your array.

Here is example view https://embed.plnkr.co/NT6cvVybfuZnFIhgU1Xm/. In order to slice in need to get the particular index of the array to the controller how can i do that

@anushkamahesh there is a PR in progress #652 to help make this easier as it currently only works if the array is not nested. If it isn't nested then there is an arrayIndex value available to pass to your function, but I think that will work better one the above PR is merged.


Bootstrap 4 Navigation

I think there is should be an option on the settings page to use Bootstrap 3 or 4. Because the HTML structure of the navigation is slightly different. Thanks.

Hello,
You can easily customize HTML view of navigation. Just create in your theme catalog a new dir: modules/navigation/ and paste there this file: https://github.com/sruupl/batflat/blob/master/inc/modules/navigation/view/nav.html
Batflat will detect that your theme uses a different view for a given module.


Dependency / build-order solver does not consider runtime deps .

I noticed this when putting up a PR to wolfi that changed lots of packages.
It appeared to me that the solver did not consider runtime dependencies, but c-i was doing test immediately after build.
So for a package P that depended on A for build and A and C for runtime, there was no guarantee that C would be built before P.
It is possible that this is acceptable, and the build/test should simply be changed to do "build all the things and then test all the things".  I don't have a good argument against that, but the current process in github actions was 'make package/' and then 'make test/'.

In elastic builds I believe all builds are done first, then tests.
We could adopt same for GHA builds too. Not sure how much work that would be.


Add parameter for random seed

Description
Add parameter "random_seed" to ppo_common_config to specify a random seed.
If set to "null" the current time is used as seed (and printed to stdout), so even when not specifying a fixed seed, we always use a known seed (so runs can be reproduced).
The idea is that you can normally leave it "null" but if you want to reproduce a training run (e.g. for debugging), you can get the seed from the output of that run and set it in the config.
How I Tested
Started the training to verify there is no error.
I fulfilled the following requirements

[x] All new code is formatted according to our style guide (for C++ run clang-format, for Python, run flake8 and fix all warnings).
[x] All new functions/classes are documented and existing documentation is updated according to changes.
[x] No commented code from testing/debugging is kept (unless there is a good reason to keep it).

It seems to me this will work only in accelerated time. In non accelerated time, the simulated  pressure controlled robot as started by pam_mujoco will start moving as soon at it started (because of gravity), i.e. even if the learning algo is started in  a deterministic fashion, it will interact with a pseudo robot which may be in different states when it starts. On the other hand, in accelerated time, mujoco iterations occurs only when the learning algo requires them to happen.
Maybe this is fine and only accelerated mode will be used.

@vincentberenz You are right, that's a good point to keep in mind.  I don't see a way to make it deterministic in this case due to the unknown timing, so I think that's a limitation we have to live with.

ooooh, it is merged already


NIFI-9706 Add Memory Consideration to JoltTransformJSON

Description of PR
NIFI-9706 Adds a SystemResourceConsideration annotation with SystemResource.MEMORY to the JoltTransformJSON processor. The JoltTransformJSON processor reads the entire FlowFile content into memory prior to executing the Jolt transformation, which can result in memory errors when the object representation exceeds available heap memory.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Merged, but temporarily in a weird place with syncing between Apache and Github.


refactor: change patching of setattr in SignalGroupDescriptor, make more explicit

adding SignalGroupDescriptor as a class attribute will patch the class's __setattr__ method (on the first access of the descriptor on an instance).  This PR:

changes the moment when that patching occurs
provides an opt-out mechanism (in which case the user must patch __settattr__ themselves)
documents it more obviously
uses a cleaner context manager within the evented_setattr pattern

(magicgui test failure is only related to the bad version naming on the rc v0.8.0rc0 ... will fix in the next rc)


Have only one source of configuration

Currently, there is two separate ways to configure trivy-operator settings. There are settings configured as environment variables to the deployment, and some other options configured in a configmap.  This leads to complexity in code, for example, all controllers receive etc.Config and also trivyoperator.ConfigData which represent the different way of configuring trivy-operator.  Also, from a UX point, it is preferable to change configurations on a configmap then restart the pod, simpler than changing an env var on a deployment.

@chen-keinan Do you mind if I take this issue?

@josedonizetti thanks for picking this up! This would be a very nice improvement!

@josedonizetti was the mentioned pull request pending more development or pending review when it was closed for being statle?


Feat/integrate oid4vp into mobile sdk rust swift kotlin

Merge #35 first.

NOTE: Need to fix rebased commit history. Would be nice if we can squash commits for simplifying rebasing.
NOTE: Cargo.lock is added to his branch. Should we add it to .gitignore? I noticed it had not beed added, possibly for a reason.

Cherry pick oid4vp changes, refactor for incoming VDC collection changes.
Rebase on oid4vp-rs once merged.


fix: bug fixes for #508

Bug fixes for #508.
Changelog
New

N/A

Changed

Renamed child prop closeMenu to onClick in OverflowMenu.

In Tabs, removed onSelectionChange from the props rest variable to eliminate it being passed into the nav element as an event handler. Reworked methods handleTabClick, handleTabKeyDown, and handleTabAnchorFocus, to receive onSelectionChange as an argument.

Changed test getTriggerPosition in Tooltip-test so that an object is passed to triggerPosition, instead of a string.

Removed

N/A

Nice fix @JMGordon!


Request to expose certain protected APIs as public

Hello,
I would like to request that certain APIs which are currently protected be exposed as public for broader access. Specifically, I am interested in accessing createCompressAction(), getExtension(), length() in FileExtension enum for customized rollover strategy which we have written at our end.
Could you please consider this request and let me know if it is possible to make these APIs public? I would be happy to provide more information or answer any questions you may have.
Thank you for your time and consideration.
Best regards,
Karthi

Hello @Karthi1711,
Can You submit a PR with the changes?

I think we want to be careful here @ppkarwasz: Do we really want to lock down an API as public for such low level classes and be bound to binary compatibility? Or are we going to say this class is not part of BC?

@garydgregory,
I would just prefer to see this request in the form of a PR, that we can discuss on the code.

PR created: https://github.com/apache/logging-log4j2/pull/1683.


[PE-D][Tester D] Allows updating of information to the same information

Updating the name of a person to the same name is allowed.

Labels: type.FeatureFlaw severity.Low
original: Xilef121/ped#6

Expected behaviour, no conflict


Unboxing fields

We should provide a way to unbox fields.
The problem we should solve is the indirections added as you "wrap" a type in other types, to add functionality.
For example, I have an immutable string type in the standard library:
type Str:
    # UTF-8 encoding of the string.
    data: Array[U8]

and I want to implement another string type in another library that adds a memoized hash code field to the type:
# A string with memoized hash code.
type HashStr:
    str: Str
    hash: Option[U64]

This implementation will have a layer of indirection when accessing the string.
Another example would be implementing a stack using a Vec:
# Same as `Vec`, but doesn't allow random access.
# Not an alias to avoid using it as `Vec`.
type Stack[T]:
    vec: Vec[T]

fn Stack.push(self, elem: T) = self.vec.push(elem)
fn Stack.pop(self): Option[T] = self.vec.pop()

Note that in this example fields of the Vec in array will change as a result of some of the operations: push will re-allocate a new array and update the Vec's array field.
Another, and very common, example is iterator types: array and array iterator, string in character iterators etc. For example:
type StrIter:
    str: Str            # indirection when accessing the str contents
    byteIdx: Usize

type VecIter[T]:
    vec: Vec[T]         # indirection when accessing the vec contents
    idx: Usize

Notes
Unboxing a type in a field is only possible if the unboxed type has no mutable fields, or the type with the unboxed field owns (i.e. initializes with the fields) the value.
As an example to the first case:
type Str:
    data: Array[U8]

type StrIter:
    str: Str
    byteIdx: Usize

fn StrIter.new(str: Str) =
  StrIter(str = str, byteIdx = 0)

Since strings are immutable (we don't have a syntax for mutable/immutable fields yet), the data field will never change once initialized. So StrIter constructor can take a Str argument and unbox it in its str field.
As an example to the second case:
type Vec[T]:
    array: Array[T]
    len: Usize

type Stack[T]:
    vec: Vec[T]

Stack can't take a Vec argument in its constructor and unbox it. The argument may be aliased, and other references to it can push elements and cause the len and array fields to change.
However it can unbox the Vec field if it allocates it (so there are no other aliasing at the time of allocating Stack), and we allow interior pointers so others can alias the Vec in Stack (e.g. if we provide a method that returns self.vec).
A variation of the second idea is we allow unboxing just one field, and generate code so that the values of the unboxing type can work as a value of the unboxed type. In the example above, this means Stack can be passed to a function that expects Vec. I.e. non-coercive subtyping, this is basically the approach some OO langs take when extending classes.

A variation of the second idea is we allow unboxing just one field, and generate code so that the values of the unboxing type can work as a value of the unboxed type. In the example above, this means Stack can be passed to a function that expects Vec. I.e. non-coercive subtyping, this is basically the approach some OO langs take when extending classes.

Relevant Rust RFC from 2014: RFC 223.


[Enhancement] Custom scrollbars are not visible on touch devices

Because this check relies on a scrollbar-width to be truthy this and scrollbars on mobile devices are usually floating/auto-hide and don't take up layout space.
https://github.com/RobPethick/react-custom-scrollbars-2/blob/a5838518889667dfc755d4d4d5b2e99018416c5c/src/Scrollbars/index.js#LL450C13-L450C30
Is this intentional? (Because this also affects mac-books with trackpad for example.)
One workaround is to force visible scrollbars (not confirmed to work on all devices) like so: https://stackoverflow.com/a/22907848/1629723
A prop/option to change this behaviour would be nice.

I think this will help you. It's a little buggy, but overall it works.
https://www.npmjs.com/package/react-custom-scrollbars-with-mobile

Hi, thanks for the reply, I kinda forgot about this. In the end I created some simple custom scrollbars using framer-motion.


Update README with links to SDL Image / Mixer 1.2.x

Update README to save a google search to the proper 1.2.x version of the Image and Mixer library.
Just testing GitHub collaboration.

This is a blast from the past!


Download size

The default is to run an 8MiB sector size miner. This results in 5.8GB of proof data needed on startup:
matt@Matts-MacBook-Pro filecoin-proof-parameters-8k % du -sh .
5.8G	.

Perhaps we can start with a 2K sector size miner by default, and give the option to run 8M if wanted, as 2K sector size is a lot smaller.
matt@Matts-MacBook-Pro filecoin-proof-parameters % du -sh .
2.0G	.

Also the image itself is 1.5GB. Most of that is the lotus/boost binaries. These are not stripped, and constitute 1.3GB. By stripping this can be reduced down to 783MB:
root@497c71917abc:/usr/local/bin# ls -l
total 1304520
-rwxr-xr-x 1 root root 179700016 Apr 14 09:45 boost
-rwxr-xr-x 1 root root 189575672 Apr 14 09:48 boostd
-rwxr-xr-x 1 root root 139131032 Apr 14 09:52 booster-bitswap
-rwxr-xr-x 1 root root 145816536 Apr 14 09:51 booster-http
-rwxr-xr-x 1 root root 146361656 Apr 14 09:46 boostx
-rwxr-xr-x 1 root root 199370624 Apr  6 02:59 lotus
-rwxr-xr-x 1 root root 185908304 Apr  6 03:01 lotus-miner
-rwxr-xr-x 1 root root 149914032 Apr  6 03:06 lotus-seed
root@497c71917abc:/usr/local/bin# du -sh .
1.3G	.
root@497c71917abc:/usr/local/bin# strip *
root@497c71917abc:/usr/local/bin# ls -l
total 801416
-rwxr-xr-x 1 root root 112016856 Apr 14 20:20 boost
-rwxr-xr-x 1 root root 119805080 Apr 14 20:20 boostd
-rwxr-xr-x 1 root root  80601576 Apr 14 20:20 booster-bitswap
-rwxr-xr-x 1 root root  85259496 Apr 14 20:20 booster-http
-rwxr-xr-x 1 root root  85657352 Apr 14 20:20 boostx
-rwxr-xr-x 1 root root 129836112 Apr 14 20:21 lotus
-rwxr-xr-x 1 root root 116600240 Apr 14 20:21 lotus-miner
-rwxr-xr-x 1 root root  90854312 Apr 14 20:21 lotus-seed
root@497c71917abc:/usr/local/bin# du -sh .
783M	.

Docker image has been reduced down to 1GB by stripping the binaries.
The default is now a 2k network. 8M can be selected in the .env file
This means the total download on first run is about 3GB vs the original 7.5GB.


Allow for decimals

force double value with the decimal places that exist

force double value with the decimal places that exist

allow backspace

Refactor #6


Implement Django documentation similar to Sphynx or Swagger.

See: https://docs.djangoproject.com/en/1.8/ref/contrib/admin/admindocs/

/admin/doc --- now provides documentation structure, however we need """docstrings""" with specific Django format for models, tags and views.

Closing due to inactivity.  Can re-open as time permits.

Re-open for consideration

Re-open for consideration


[FLINK-5197] [jm] Ignore outdated JobStatusChanged messages

Outdated JobStatusChanged messages no longer trigger a RemoveJob message but are
logged and ignored. This has the advantage, that an outdated JobStatusChanged message
cannot interfere with a recovered job which can have the same job id.

Merging this PR. @uce reviewed the backport.

Forgot to include the closing tag in the commit.


[AutoPR compute/resource-manager] missing section for compute 2019-07-01

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7193

(message created by the CI based on PR content)


Adding new diversity/lua libs

Environment

VerneMQ Version: 1.3.1
OS: Linux
Erlang/OTP version (if building from source):

Expected behavior
Due the nature of luerl the provided libs in lua are limited to what vmq_diversity already provides. I expect some interface to inject more libs into the lua environment. Maybe via loading a custom plugin providing dependencies and erlang/lua mappings.
Actual behaviour
I found no way to add my own libs for use in lua scripts.

@baranga Thanks for reporting. This would be great of course. However, as correctly noted, this isn't possible at the moment.
https://github.com/erlio/vernemq/blob/master/apps/vmq_diversity/src/vmq_diversity_script_state.erl#L229 would be the place to hook in... a PR would be highly appreciated! :D

@dergraf I really try to figure out how to do that. I imagine some kind of interface in vmq_diversity for other plugins to add their luerl libs. Or would it be better to implement this in a more config driven approach?


Fix workshops page

Number of Volunteers: 1
NOTE: Check with @kaushal0494 first since he is working on #21.
Currently it looks like below.

We should make each box roughly at the same size. Probably we need to replace the text with a blurb. If so, we need to ask workshop organizers to provide such information.
ICLR version: https://iclr.cc/virtual_2020/workshops.html

@hao-fang  What if we don't include the blurb (description) instead just have the title and the list of organizers? I did that for tutorials page https://virtual.acl2020.org/tutorials.html
I think at this point asking workshop organizers for a shorter text is going to take additional time. And anyways, it is just a matter of someone clicking on the link. They can then view the description in the individual workshop page.

@raosudha89 Sure. Let's do the simple version.

Sounds good. I will work on this.

Done and created a PR for this https://github.com/acl-org/acl-2020-virtual-conference/pull/130


Liquid Filters: Inverse access not possible

Filter rdf_property and rdf_property_list: Not possible to access statements where the current rendered property is the object (inverse access).
Currently you can only access statements where the current property is the subject. An extra optional parameter has to be implemented

This can be closed, I've moved it to https://github.com/white-gecko/jekyll-rdf/issues/23


[Event Request] Codeunit 5342 "CRM Synch. Helper"

We need a few changes in Codeunit 5342 "CRM Synch. Helper"
REASON: We have custom statuses in D365 Sales, and we need a different process for determining the status value. We also need to update some other fields (the remaining amount of the invoice), and this place would be ideal as the status has almost the same conditions.
    [IntegrationEvent(false, false)]
    local procedure OnUpdateCRMInvoiceStatusFromEntryBeforeModify(var CRMInvoice: Record "CRM Invoice"; var NewCRMInvoice: Record "CRM Invoice"; CustLedgerEntry: Record "Cust. Ledger Entry")
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnUpdateCRMInvoiceStatusFromEntryBeforeCheckFieldsChanged(var CRMInvoice: Record "CRM Invoice"; var NewCRMInvoice: Record "CRM Invoice"; CustLedgerEntry: Record "Cust. Ledger Entry"; var ChangeNeeded: Boolean)
    begin
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeCalculateActualStatusCode(CustLedgerEntry: Record "Cust. Ledger Entry"; var CRMInvoice: Record "CRM Invoice"; var IsHandled: Boolean)
    begin
    end;

    procedure UpdateCRMInvoiceStatusFromEntry(var CRMInvoice: Record "CRM Invoice"; CustLedgerEntry: Record "Cust. Ledger Entry"): Integer
    var
        NewCRMInvoice: Record "CRM Invoice";
    begin
        with CRMInvoice do begin
            CalculateActualStatusCode(CustLedgerEntry, NewCRMInvoice);
//EVENT REQUEST + add ChangeNeeded to the condition
            OnUpdateCRMInvoiceStatusFromEntryBeforeCheckFieldsChanged(CRMInvoice, NewCRMInvoice, CustLedgerEntry, ChangeNeeded);
            if ChangeNeeded or (NewCRMInvoice.StateCode <> StateCode) or (NewCRMInvoice.StatusCode <> StatusCode) then begin
            // if (NewCRMInvoice.StateCode <> StateCode) or (NewCRMInvoice.StatusCode <> StatusCode) then begin
//EVENT REQUEST
                ActivateInvoiceForFurtherUpdate(CRMInvoice);
                StateCode := NewCRMInvoice.StateCode;
                StatusCode := NewCRMInvoice.StatusCode;
//EVENT REQUEST
                OnUpdateCRMInvoiceStatusFromEntryBeforeModify(CRMInvoice, NewCRMInvoice, CustLedgerEntry);
//EVENT REQUEST
                Modify();
                exit(1);
            end;
        end;
    end;

    local procedure CalculateActualStatusCode(CustLedgerEntry: Record "Cust. Ledger Entry"; var CRMInvoice: Record "CRM Invoice")
    begin
        with CRMInvoice do begin
            CustLedgerEntry.CalcFields("Remaining Amount", Amount);
//EVENT REQUEST
            OnBeforeCalculateActualStatusCode(CustLedgerEntry, CRMInvoice, IsHandled)
            if IsHandled then
                exit;
//EVENT REQUEST
            if CustLedgerEntry."Remaining Amount" = 0 then begin
                StateCode := StateCode::Paid;
                StatusCode := StatusCode::Complete;
            end else
                if CustLedgerEntry."Remaining Amount" <> CustLedgerEntry.Amount then begin
                    StateCode := StateCode::Paid;
                    StatusCode := StatusCode::Partial;
                end else begin
                    StateCode := StateCode::Active;
                    StatusCode := StatusCode::Billed;
                end;
        end;
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11320.

Your changes went in June 28th, meaning they will ship with 22.4 in August.


error occurred when drawing

hello,bro.i meet a problem after i choose the correct replay_roadnet.json and replay.txt file and click start.it says -start replaying - error occurred when drawing. i dont know is that my browser's problem?byw my replay.txt is empty,i dont know is  that normal?

If your replay.txt is empty, it means you did not save the replay or some error occurs when running CityFlow. You can test your browser by running an existing replay_roadnet.json and replay.txt by running "frontend/download_replay.py".

thanks so much! And I test the download-replay and it runs ok.that means my browser is ok. But when I run example config,my replay.txt do empty.I do set savereplay:true.could you please give me more help?but the replay_roadnet file works well
发自我的iPhone
------------------ Original ------------------
From: Chang Liu @.>
Date: Thu,Mar 25,2021 2:03 PM
To: cityflow-project/CityFlow @.>
Cc: shuan19920309 @.>, Author @.>
Subject: Re: [cityflow-project/CityFlow] error occurred when drawing (#120)
If your replay.txt is empty, it means you did not save the replay or some error occurs when running CityFlow. You can test your browser by running an existing replay_roadnet.json and replay.txt by running "frontend/download_replay.py".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

How many steps did you run? You can output the total vehicle count in every step to see whether the simulation is working.

I create the engine then it will crate the replay_roadnet.json and replay.txt.and I just need run these two file in my browser.is that right.and i check the vehicle number is always  0. because my replay.txt is empty
发自我的iPhone
------------------ Original ------------------
From: Chang Liu @.>
Date: Thu,Mar 25,2021 7:53 PM
To: cityflow-project/CityFlow @.>
Cc: shuan19920309 @.>, Author @.>
Subject: Re: [cityflow-project/CityFlow] error occurred when drawing (#120)
How many steps did you run? You can output the total vehicle count in every step to see whether the simulation is working.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

En, you should run the engine after you create it by "eng.next_step()".

oh! I success. I appreciate you so much! You helps me a lot. thanks!!!
:)
发自我的iPhone
------------------ Original ------------------
From: Chang Liu @.>
Date: Thu,Mar 25,2021 8:11 PM
To: cityflow-project/CityFlow @.>
Cc: shuan19920309 @.>, Author @.>
Subject: Re: [cityflow-project/CityFlow] error occurred when drawing (#120)

You are welcome~

hello! I meet the problem that the replaylogfile.json and replay.txt file can be loaded successfully, but it shows "drawing roadnet faeiled"!
I use the google browser, and I think these two file is correct.
Can you give me some suggestion about this problem? Or, can you tell me which browser you are use ?  Thanks a lot!

Please check the roadnet file you uploaded in GUI corresponds to roadnetLogFile in config.json

oh! I success. I appreciate you so much! You helps me a lot. thanks!!! :) 发自我的iPhone
…
------------------ Original ------------------ From: Chang Liu @.> Date: Thu,Mar 25,2021 8:11 PM To: cityflow-project/CityFlow @.> Cc: shuan19920309 @.>, Author @.> Subject: Re: [cityflow-project/CityFlow] error occurred when drawing (#120)

hello,I have the same question,the replay.txt is empty.I have used "eng.next_step()",but the file "replay.txt" is also empty.How did you solve this problem?


Amazing, explains without being too formal

I have to say this one of the most informative whilst fun diagrams I have seen for some time. It has all of the technical detail without needing to be too formal

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 87364a28-e1df-eda3-2480-11556ac578be
Version Independent ID: eebcf9e0-2ff4-d3b5-687f-682adf0b005b
Content: Linux Containers on Windows 10
Content Source: virtualization/windowscontainers/deploy-containers/linux-containers.md
Service: windows-containers
Product: windows-containers
GitHub Login: @scooley

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


DockerFile error Step 6/16 : COPY conf/ /conf

hi,
It seems like there is an error in the docker file in the final steps, please see below.
Step 6/16 : COPY conf/ /conf
COPY failed: stat /var/lib/docker/tmp/docker-builder660373075/conf: no such file or directory
I tried to delete the lines:
COPY conf/ /conf
COPY test/ /tmp/test
but still failing to build. (Step 6/13 : COPY check_wwwdata.sh /usr/bin/check_wwwdata
COPY failed: stat /var/lib/docker/tmp/docker-builder849396188/check_wwwdata.sh: no such file or directory)

It looks like you are missing assets in your build process. Because you do not have the assets the build is failing.
Just look at this
COPY check_wwwdata.sh /usr/bin/check_wwwdata
COPY check_folder.sh /usr/bin/check_folder

If you do not have check_wwwdata.sh present on your host build dir, there is nothing to copy and hence an error.  So as far as I can tell, no, there is not an error in the Dockerfile. I just ran a complete build without issue. This has something to do with your local environment.


add a Prometheus exporter for ElasticSearch

Following #37 which added the JMX exporter agent to the CE process, here is what I propose for adding an ElasticSearch exporter. It runs elasticsearch_exporter in an additional container of the sonarqube pod, using (by default) the bitnami/elasticsearch-exporter image.
Regarding configuration of the chart, this PR adds the following values:
prometheusExporter:
  esMetricsPort: 8002
  elasticsearch:
    image: bitnami/elasticsearch-exporter:1.2.0
    esUri: http://localhost:9001
    extraArgs:
      - "--es.indices"
      - "--es.shards"
    securityContext:
      readOnlyRootFilesystem: true
      runAsNonRoot: true
    resources: ...

The ES exporter will be enabled/disabled together with the two other ones, via prometheusExporter.enabled.
I also wanted to keep the listen port value next to the other exporter ports (prometheusExporter.{webBeanPort,ceBeanPort}), hence the prometheusExporter.esMetricsPort.
For other values (configuration of the container itself, and elasticsearch_exporter parameters), I thought it would be confusing to mix them with pre-existing prometheusExporter.* values (even if prefixed with es), hence the new prometheusExporter.elasticsearch subtree.  I'm not 100%sure it's the right choice, you let me know what you think.
Regarding backward compatibility, I think adding this container is okay. Even when it doesn't work as expected out-of-box (if the ElasticSearch address has been customized in sonar.properties), it should be fine, the exporter will still be running.

Hi @thomasgl-orange ,
thanks for the PR. i had a look at it looks good to me. i am just a bit hesitant with the introduction of a sidecar container that exports generic ES metrics as these metrics do not seem to be that important as some are checked via api/system/health  and sonarqube will report to be unhealthy if something is wrong with ES anyway. Some other metrics, like elasticsearch_filesystem_data_available_bytes seem useful, but should probably better be monitored by a node exporter or directly in the PV.
Monitoring is a topic at the moment and i hope to get some momentum on that soon. i will discuss this topic with my PM on monday if it makes sense to introduce a generic ES exporter or if we can ship a better solution directly with SQ soon, so please stand by :)

these metrics do not seem to be that important as some are checked via api/system/health and sonarqube will report to be unhealthy if something is wrong with ES anyway. Some other metrics, like elasticsearch_filesystem_data_available_bytes seem useful, but should probably better be monitored by a node exporter or directly in the PV.

I am mostly interested in the elasticsearch_jvm_* metrics actually, to check if our ES JVM sizing is okay, and detect any worrying trends as our SQ usage grows, before we reach the unhealthy point. I would have been happy simply using the JMX exporter, but it looks like the agent won't work on ES.

Monitoring is a topic at the moment and i hope to get some momentum on that soon.

:+1:

i will discuss this topic with my PM on Monday if it makes sense to introduce a generic ES exporter or if we can ship a better solution directly with SQ soon, so please stand by :)

Sure, consider this PR as food for thought. I you end up adding a Prometheus-compatible endpoint directly in SQ, with metrics for the three JVMs (alike what's in /api/system/info), I will be more than happy too :)

Hello @thomasgl-orange ,
i had a chat with my PM on this issue and we concluded that it would make more sense to solve this in a homogenized way in the future. There is MMF-2022 to keep an eye on for a solution on monitoring that is coming with SQ in the future.
thank you again for sending over this good PR :)


WIREFRAMES: FilterBar

As a user I want to be able to filter the work items, in the list view and boards view, based on filtering criteria as set in the template.
This issue is for the listing part only. Do we need any visual indicator, apart from the side bar, that the list of work items have been filtered by a work item type?
Please note point 3 in user story 658:
The work item type filter may or may not stack with the current display context ("Backlog" or "Iteration X"). The decision is on UX how this work.
VC's

Use any capabilities from the PF Filter possible
Choose Filter Type
Choose established filtering criteria, if possible. If not type ahead will suffice.

FIlter bar wireframes updated and interaction reflected in Hierarchy wireframes:
https://redhat.invisionapp.com/share/YVA4PGYA3#/216508673_Hierarchy_1_Level

Wireframes updated to hide other parts of the pages beyond the filter bars and posted to InVision:  https://redhat.invisionapp.com/share/56AH8F1XM


lost in trash

Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
Expected behavior
I should be able to move a deleted message in the trash back to another folder or the inbox. Cannot figure out how. Neither context menu nor other commands seem to provide this feature.
Actual behavior
feature not available
Steps to reproduce

n/a

Environment
K-9 Mail version: 5.600
Android version: 7.1
Account type (IMAP, POP3, WebDAV/Exchange):
Please take some time to retrieve logs and attach them here:
no logs

Duplicate of #1796


scheduling result tables disappear from the page when user back from edit mode.

open pod's detail → switch to edit page → switch to non-edit page → scheduling result tables disappear from the page.
https://user-images.githubusercontent.com/44139130/131511142-be065538-1bcf-46f7-b15b-53df8a53f6c3.mov
/kind bug

This issue may be unnecessary because of #17
/hold

/close This issue is not needed because of #17

/close


Simple typo ... missing an 'r' at the end.

Change Summary

Related issue number

Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)

Duplicate of https://github.com/samuelcolvin/pydantic/pull/1713


json.at_or_default(key, defaultval)

Describe the feature in as much detail as possible.

if (j.contains("access_token"))
{
    j.at("access_token").get_to(t.access_token);
}
else
{
    t.access_token = "";
}

This tends to be a lot of boilerplate to ensure something's there. I just want to supply a default within the single line if the key does not exist in the json struct.

Include sample usage where appropriate.

json.at_or_default("nonexistantkey", "default") should return "default", as the key does not exist.
However,
json.at_or_default("existing", "default") // "existing" exists, and contains "nondefault" should return "nondefault" as the key does exist.

Have a a look at value.
https://nlohmann.github.io/json/classnlohmann_1_1basic__json_adcf8ca5079f5db993820bf50036bf45d.html#adcf8ca5079f5db993820bf50036bf45d

Works for me!


[Question] Does Fluid itself support report metrics to Prometheus?

In the docs, I only find one document about monitoring. But it's about monitoring runtime/engine. My question is " Does fluid itself support to be monitored via reporting metrics to Prometheus?"

Thank you for the question. Fluid has supported the metrics reporting in the components. For example, it's in https://github.com/fluid-cloudnative/fluid/blob/master/cmd/dataset/app/dataset.go#L92. And we will provide grafana dashboard JSON.

Thanks for your answer. Got it.


Add Sublime Text

Thank you for contributing! Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Due to the customization aspect of the software, a lot of plugins, themes and syntax styles are using this topic (among others, which are referenced) on their projects. It deserves a proper description 😃

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Thanks so much for your first contribution!  You rock, @p3lim!