[SPARK-8014] [SQL] Avoid premature metadata discovery when writing a HadoopFsRelation with a save mode other than Append

The current code references the schema of the DataFrame to be written before checking save mode. This triggers expensive metadata discovery prematurely. For save mode other than Append, this metadata discovery is useless since we either ignore the result (for Ignore and ErrorIfExists) or delete existing files (for Overwrite) later.
This PR fixes this issue by deferring metadata discovery after save mode checking.

Merged build triggered.

Merged build started.

Test build #33981 has started for   PR 6583 at commit 8fbd93f.

Test build #33981 has finished for   PR 6583 at commit 8fbd93f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merged build triggered.

Merged build started.

Test build #34006 has started for   PR 6583 at commit 1aafabd.

LGTM

Test build #34006 has finished for   PR 6583 at commit 1aafabd.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class SortOrder(child: Expression, direction: SortDirection) extends Expression
abstract class BinaryMathExpression(f: (Double, Double) => Double, name: String)

Merged build finished. Test PASSed.

I am merging it to master and branch 1.4.


updated chalk from 1.1.3 to 2.3.0

chalk has had many improvements. For my case, I needed the ability to specify yellowBright color, which the older version of chalk did not support for me on Windows at least. Being able to use a wider range of colors really makes the tables pop.

Because of pm2 we have a nodejs version constraint >= 0.12 which isn't supported by this new version of chalk. I'm not sure when we can drop 0.12. @vmarchaud any idea?

We have planned to drop 0.12 for PM2 3.0 but currently it's not possible

Thanks @vmarchaud keeping this open since then.

upgraded to 3.x


Critical Error: Function recursion limit exceeded.

it started happening lately for some reason

@DMD-x Can you post the contents of your config.json file?
To open it, just hold Shift when clicking Edit Configuration in the tray menu

@SaifAqqad

@DMD-x commit ef12ddd1267e7ce99395642935f45b5f4ea652f1 should fix this issue, you can test it in the pre-release build here

unfortunately, still the same issue but different error code:

the config screenshot:

that's really weird, and unfortunately I can't reproduce it any more

@DMD-x commit d1fed34a50ead9d36031b28ee3ed98e1991d831d should definitely fix it
You can test it in the latest pre-release

Thanks a lot it works finally!


The SDK 'MSBuild.Sdk.SqlProj/2.6.1' specified could not be found

I am trying to build the below .csproj with  mcr.microsoft.com/dotnet/sdk:8.0  in a Dockerfile.

<PropertyGroup>
	<TargetFramework>netstandard2.0</TargetFramework>
	<SqlServerVersion>SqlAzure</SqlServerVersion>
	<ImplicitUsings>enable</ImplicitUsings>
	<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
	<Content Include="..\..\Env\Application.Database.Environment\**\*.sql" />
</ItemGroup>

However, it's failing with the error in the build step.
 Unable to find package MSBuild.Sdk.SqlProj. No packages exist with this id in source(s): nuget.org MSB4276: The default SDK resolver failed to resolve SDK "MSBuild.Sdk.SqlProj" because directory "/usr/share/dotnet/sdk/8.0.101/Sdks/MSBuild.Sdk.SqlProj/Sdk" did not exist. The SDK 'MSBuild.Sdk.SqlProj/2.6.1' specified could not be found
I am not sure if this is intended to work this way. However,  I am trying to build a docker image with the dacpac and then would run sqlPackage in this container in a separate Azure devops pipeline to deploy to the databases.
This is my docker file

# Use the official .NET SDK image as the base image
FROM mcr.microsoft.com/dotnet/sdk:8.0 AS build

# Set arguments
ARG Database=Environment
ARG PROJECT_NAME=Application.Database.Build.$Database.csproj
ARG SERVICE_PATH=/Build/Environment
ARG RELATED_CODE_PATH=/Environment

WORKDIR /app

# # Copy related code
COPY --chown=1001 ./$RELATED_CODE_PATH ./$RELATED_CODE_PATH

# Copy the necessary project files to the container
COPY --chown=1001 ./$SERVICE_PATH ./$SERVICE_PATH

# Set the working directory inside the container
WORKDIR /app/$SERVICE_PATH

# Restore
RUN dotnet restore $PROJECT_NAME

# Buidl and Publish
RUN dotnet build -c Release $PROJECT_NAME -o /app/dacpacs && \
    dotnet publish --no-restore -c Release -o /app/publish

# Set up the runtime image
FROM mcr.microsoft.com/dotnet/runtime:7.0 AS runtime

# Copy the built application from the build image
COPY --from=build /app/out .

Please share the full csproj content, not just fragments

Thas is all I have in the csproj file

This was a network issue related to a firewall, not the tool itself.


Problem with detection on Clevo device

What are you experiencing an issue with?

[ ] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[x] Aurora supported device, (Clevo device)
[ ] Aurora Scripts
[ ] Aurora Updater
[ ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[ ] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[x] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
Program should be detecting Clevo Keyboard
Actual behavior:
After installation, program initially detects the keyboard and works fine. upon restart of the program or laptop, the keyboard is no longer detected
How often does this problem occur?

This problem occurs every time the program is restarted or the laptop is restarted
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

Install and run program
Close program completely/ turn off computer
Run program/ turn on computer

What is the version of Aurora you are experiencing this issue with?

My version is... v0.6.0b
Does the previous version of Aurora have this issue?
Have not used a previous version
Please include any logs, screenshots, or files that are related to this issue:

https://pastebin.com/m6X6csH2

Check if Clevo Keyboard is enabled at Aurora Settings > Device Manager

Update: Program works fine when run as administrator, however doesn't load on startup.

Where is the device manager setting located?

Any updates on this?


Docking branch for ImGui.NET

Do you think it would be possible to create a branch with these changes, similar to how it is in dear imgui? We should definitely keep it apart from master, but I think it may be useful for others who want a .NET version of this
(The changes were made with cimgui and the CodeGenerator, nothing else has been modified)

There is now a docking branch available now. I am having trouble setting docking up, could you maybe tell me how you did it? Like, whenever I transfer some of my code from C++ to C#, it can't find thinks like DockBuilder, etc?


Submit module to Magisk Modules repo

It would help discoverability by users and make the project more future-proof.
https://github.com/Magisk-Modules-Alt-Repo/submission

i disagree. not needed.

@j-hc not needed but would be helpful/ convenient. A phone or a computer aren't "needed", either - all we "need" is food, water, air, shelter .. ;)


Event Aggregation topics (CWP-57036)

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--prisma-cloud-docs--hlxsites.hlx.page/
After: https://--prisma-cloud-docs--hlxsites.hlx.page/
Worker: https://prisma-cloud-docs-production.adobeaem.workers.dev/?branch=

the build check failed because of bad indentation in the Book.yaml file. WIll raise a new request.


Doc-string format

Is there a reason to utilize this docstring format...
:param [str, list, tuple] tids
:returns requests.models.Response
:raises Exception, ValueError

vs. this one?
Parameters:
    - tids [str, list, tuple] - twitter id numbers
Returns:
    - requests.models.Response
Raises:
    - Exception, ValueError

The latter is, IMO, much more readable but I've seen the first a lot and I wasn't sure if there are any functional differences?

There was no particular reason. But we can use the second one as the standard.

There was no particular reason. But we can use the second one as the standard.

See #27

See #27

this has been merged. Thanks, Kaicheng!

this has been merged. Thanks, Kaicheng!


Manually query the deployed supplychain smartcontract on the besu network

Describe the bug
The transactions send to besu network using the eth_sendRawTransaction is retuning empty logs witha success status.
To Reproduce
Steps to reproduce the behavior:

Edit Besu Network.yaml
Set besu network
Deploy the quorum sample chaincode
Try to invoke addContainer and getSingleContainer functions manually.

Expected behavior
the log field in getSingleContainer should be returning the values for the new container.
Screenshots

Additional context
Try emitters with solidity chaincode.

used js script to call invoke the smartcontract createContainer and getContainer functions using the contract ABI and web3-eea.js library for private transactions. not getting any output in the getContainer function result even after the transaction is successful.
Next steps include the web3.js library to invoke the functions using the sendRawTransaction.

used js script to call invoke the smartcontract createContainer and getContainer functions using the contract ABI and web3-eea.js library for private transactions. not getting any output in the getContainer function result even after the transaction is successful.
Next steps include the web3.js library to invoke the functions using the sendRawTransaction.

The transaction is not returning any logs since there are no events being emitted in the function getSingleContainer.
The function is declared as a view function, which means that it is supposed to be queried (use eth_call instead of eth_sendRawTransaction). The return value of a function can only be retrieved using the JSON RPC method eth_call.


#if nested inside an #each

I am finding that a nested "#if" if doesn't evaluate as true when it should if it sits inside an "#each"
EG the {{image}} always seems to be null
{{#each Links}}

{{#if image}}{{/if}}

{{title}}

{{/each}}

Assuming image is a property of a link.  If so, you need to preface your object reference with a this.

Yes image belongs to link. I tried this but it didn't work
{{#if this.image}}{{/if}}

What does your Links object look like?

Hi jrlost,
I managed to work around this by changing the way I deserialize my data.
I was storing links as JSON in my db and using JsonConvert.DeserializeObject(). I tried changing this to use JavaScriptSerializer and DeserializeObject() and it now works.
So I guess it is the way the object was being created.
Thanks for your help. Glad to get it sorted.


Make API endpoints return the correct status code when returning an error

Hi,
I am using this library with the Estranged.Lfs.Api and Estranged.Lfs.Authenticator.GitHub addons.
Not sure if this is an issue on my end, but looking at source code and other examples, I have built my own IBlobAdapter, which will return errors in certain circumstances. Testing this in Postman locally, my error object is populated and code is set, but the status code returned by the server is still 200 OK. It would be nice to set the status code in the response when handled internally by the library, as as far as I'm aware I do not have control over this.

Hi Daniel,
This is part of the Git LFS spec: https://github.com/git-lfs/git-lfs/blob/main/docs/api/batch.md

If there are problems accessing individual objects, servers should continue to return a 200 status code, and provide per-object errors. Here is an example:

That’s because it’s a batch response, and the response could be partial. If this library did anything different, LFS clients would break as it’s no longer following the spec.
Alan

Makes sense, I forgot about that quirk of the API spec - that it supports actually processing multiple files at the same time. Thanks!


Cannot load a newspaper.build() when i try to load again

import newspaper
cnn_paper = newspaper.build('http://bbc.co.uk')
print(cnn_paper.articles)

The first time it works fine. BUT, when i run this code again
cnn_paper.articles return a empty list
did i miss something?? or is it a glitch?

I never mind i got it. memoize article parameter is the key


CP template no longer in list of issue templates

It looks like after https://github.com/flutter/flutter/pull/127507, the CP template is no longer in the list at https://github.com/flutter/flutter/issues/new/choose

YAML syntax error: (): could not find expected ':' while scanning a simple key at line 12 column 1. [Learn more about this error.](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/common-validation-errors-when-creating-issue-forms)

Would be great if GitHub linted these types of issues. I'm not seeing this one in the linter I'm using.


YARN-11470. FederationStateStoreFacade Cache Support Guava Cache.

Description of PR
JIRA: YARN-11470. FederationStateStoreFacade Cache Support Guava Cache.
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 13s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 36s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 43s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 36s

trunk passed

+1 :green_heart:
shadedclient
24m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 15s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
1m 29s

the patch passed

+1 :green_heart:
shadedclient
23m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
3m  5s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

105m 12s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5609

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ade3a104ba21 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 00dbec8db6ac91668f7c87f42fc40ee749f08545

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/1/testReport/

Max. process+thread count
535 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 45s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 46s

trunk passed

+1 :green_heart:
compile
10m 31s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
8m 56s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 47s

trunk passed

+1 :green_heart:
mvnsite
1m 44s

trunk passed

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 19s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 48s

trunk passed

+1 :green_heart:
shadedclient
24m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
9m 51s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
9m 51s

the patch passed

+1 :green_heart:
compile
8m 51s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
8m 51s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 38s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 17 new + 164 unchanged - 0 fixed = 181 total (was 164)

+1 :green_heart:
mvnsite
1m 34s

the patch passed

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 13s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
3m 50s

the patch passed

+1 :green_heart:
shadedclient
24m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
1m  4s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
3m 17s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

162m 15s

Reason
Tests

Failed junit tests
hadoop.yarn.conf.TestYarnConfigurationFields

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5609

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9a41388d4ef7 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 62587d1ee9c08a0aa933c239dc0043b4758b000b

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/2/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 30s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 36s

trunk passed

+1 :green_heart:
compile
10m 29s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
8m 56s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 48s

trunk passed

+1 :green_heart:
mvnsite
2m 35s

trunk passed

+1 :green_heart:
javadoc
2m 26s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 11s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m 33s

trunk passed

+1 :green_heart:
shadedclient
24m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 48s

the patch passed

+1 :green_heart:
compile
9m 51s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
9m 51s

the patch passed

+1 :green_heart:
compile
8m 48s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
8m 48s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 38s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 164 unchanged - 0 fixed = 167 total (was 164)

+1 :green_heart:
mvnsite
2m 25s

the patch passed

+1 :green_heart:
javadoc
2m  8s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 59s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m 47s

the patch passed

+1 :green_heart:
shadedclient
24m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  5s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 21s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
3m 17s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

176m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5609

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 718cf032d12f 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9609a097c6bcebd234f525586d6958359cb583bd

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/3/testReport/

Max. process+thread count
564 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Can you help review this pr? Thank you very much!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 46s

trunk passed

+1 :green_heart:
compile
10m 27s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
8m 49s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 48s

trunk passed

+1 :green_heart:
mvnsite
2m 36s

trunk passed

+1 :green_heart:
javadoc
2m 27s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 11s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m 36s

trunk passed

+1 :green_heart:
shadedclient
23m 56s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 48s

the patch passed

+1 :green_heart:
compile
9m 49s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
9m 49s

the patch passed

+1 :green_heart:
compile
8m 47s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
8m 47s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 38s

the patch passed

+1 :green_heart:
mvnsite
2m 25s

the patch passed

+1 :green_heart:
javadoc
2m  9s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m  2s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
spotbugs
5m 46s

the patch passed

+1 :green_heart:
shadedclient
24m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  4s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 21s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
3m 17s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

176m  0s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5609

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint

uname
Linux 84ac90c09175 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ee634de982706077dbee05a8b6cbe33f87e04e6d

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/4/testReport/

Max. process+thread count
531 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 32s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 37s

trunk passed

+1 :green_heart:
compile
10m 30s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
9m  0s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 44s

trunk passed

+1 :green_heart:
mvnsite
3m  8s

trunk passed

+1 :green_heart:
javadoc
2m 54s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 28s

branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
19m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  0s

the patch passed

+1 :green_heart:
compile
9m 52s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
9m 52s

the patch passed

+1 :green_heart:
compile
8m 56s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
8m 56s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 4 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m 39s

the patch passed

+1 :green_heart:
mvnsite
2m 54s

the patch passed

+1 :green_heart:
javadoc
2m 31s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 24s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 25s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs

+1 :green_heart:
shadedclient
23m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  5s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 22s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
3m 19s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 24s

hadoop-yarn-site in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

177m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5609

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint markdownlint

uname
Linux 366ae9eb4f90 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8425562c65900b67063a252c3fa6578e719ebac2

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/5/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 51s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 57s

trunk passed

+1 :green_heart:
compile
9m 56s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
8m 59s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 48s

trunk passed

+1 :green_heart:
mvnsite
3m 44s

trunk passed

+1 :green_heart:
javadoc
3m 27s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 14s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 38s

branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
20m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  7s

the patch passed

+1 :green_heart:
compile
9m  6s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
9m  6s

the patch passed

+1 :green_heart:
compile
8m 31s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
8m 31s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m 38s

the patch passed

+1 :green_heart:
mvnsite
3m 21s

the patch passed

+1 :green_heart:
javadoc
3m  2s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 52s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 34s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs

+1 :green_heart:
shadedclient
20m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 14s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 41s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
3m 28s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 33s

hadoop-yarn-site in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

177m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5609

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint markdownlint

uname
Linux 2301004e136d 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0039781b66cb1db6fb748635a4d0c03d4dc8bfe4

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/6/testReport/

Max. process+thread count
724 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
17m 23s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 53s

trunk passed

+1 :green_heart:
compile
9m 37s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
8m 35s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 50s

trunk passed

+1 :green_heart:
mvnsite
3m 40s

trunk passed

+1 :green_heart:
javadoc
3m 27s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
3m 15s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 39s

branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
20m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  5s

the patch passed

+1 :green_heart:
compile
9m  6s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
9m  6s

the patch passed

+1 :green_heart:
compile
8m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
8m 25s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m 39s

the patch passed

+1 :green_heart:
mvnsite
3m 21s

the patch passed

+1 :green_heart:
javadoc
3m  1s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 56s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 34s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs

+1 :green_heart:
shadedclient
20m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 13s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 41s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
3m 28s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 33s

hadoop-yarn-site in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

176m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5609

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint markdownlint

uname
Linux af592c427c30 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 6b75349eec655cd9ebf0093a11083df6a176ce83

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/7/testReport/

Max. process+thread count
562 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  9s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m 12s

trunk passed

+1 :green_heart:
compile
10m 26s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
8m 50s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 45s

trunk passed

+1 :green_heart:
mvnsite
3m  6s

trunk passed

+1 :green_heart:
javadoc
2m 54s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 39s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 28s

branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
22m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 24s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  1s

the patch passed

+1 :green_heart:
compile
9m 53s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
9m 53s

the patch passed

+1 :green_heart:
compile
9m 50s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
9m 50s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 39s

the patch passed

+1 :green_heart:
mvnsite
2m 52s

the patch passed

+1 :green_heart:
javadoc
2m 32s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 25s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs

+1 :green_heart:
shadedclient
23m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  5s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 24s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
3m 17s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 25s

hadoop-yarn-site in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

183m 13s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5609

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint markdownlint

uname
Linux 0f364fe6bb13 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e3852b143ec68707ab86ffbe32917dc6f84f8d7c

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/8/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 53s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 25s

trunk passed

+1 :green_heart:
compile
7m 36s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
6m 42s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
checkstyle
1m 48s

trunk passed

+1 :green_heart:
mvnsite
2m 56s

trunk passed

+1 :green_heart:
javadoc
2m 54s

trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 37s

trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 29s

branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
23m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 49s

the patch passed

+1 :green_heart:
compile
6m 51s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
6m 51s

the patch passed

+1 :green_heart:
compile
6m 40s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+1 :green_heart:
javac
6m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 38s

the patch passed

+1 :green_heart:
mvnsite
2m 40s

the patch passed

+1 :green_heart:
javadoc
2m 31s

the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
2m 25s

the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

+0 :ok:
spotbugs
0m 25s

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs

+1 :green_heart:
shadedclient
23m 17s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  2s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
5m 16s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
3m 15s

hadoop-yarn-server-common in the patch passed.

+1 :green_heart:
unit
0m 24s

hadoop-yarn-site in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

163m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5609

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint markdownlint

uname
Linux c0c746febe26 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e9352f7493ce7119ed687f6509bfacae55977285

Default Java
Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/9/testReport/

Max. process+thread count
530 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5609/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Thank you very much for helping to review the code!


Is it possible to fetch the most recent message in a channel?

In Telegram, I can do:
    messages = await a2t(self.client.get_messages)(ch_peer, limit=1)
    last_msg = messages[0]

And my understanding is that this queries the Telegram server.
Is this possible in TDLib?
EDIT: And if not, is it possible to send a nudge to Telegram server to encourage it to send all messages queued up for sending? Sometimes it takes several seconds a long time for a message to be delivered. I test with 2 clients and sometimes there's a big delay between the clients getting the message.

Duplicate of https://github.com/tdlib/td/issues/1469


Enabling  lazy loading for multi-processing variables used in training functionality

Description of changes:
AWS Lambda doesn't have /dev/shm mount which is required for multi-processing used in the training code. These variables do not have to be initialized during inference time. Refactoring multiprocessing components to initialize on the call instead on initial imports.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-1366-2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1366/2/index.html


remove s in backupvolfile-server

Hi,
Problem :
mount -t glusterfs -o defaults,_netdev,backupvolfile-servers=[HOST2] [HOST1]:/[VOLUME] [MOUNT_POINT]
Invalid option: backupvolfile-servers
I thinks the problem du in gluster/providers/mount.rb:88
backupvolfile-servers instead of backupvolfile-server

This reverts https://github.com/shortdudey123/chef-gluster/pull/72
Can you confirm with a doc think that this should be reverted?  The current code seems correct

Hmm did some digging and it looks like the plural form that is currently in master never appears in the glusterfs codebase.
@vchung-nz can you verify where you saw the plural form?

Yes, I cannot find it as well.  I am not using that option any more, but a manual test with backupvolfile-servers also returned invalid with glusterfs 3.9 l have now!  So please go ahead and revert, sorry about any problem caused.

@vchung-nz thanks for verifying and no problem!

@imatpro let me fix up the broken testing a sec so that this does not cause master tests to fail when i merge it

@shortdudey123 Thanks


python310Packages.devtools: 0.8.0 -> 0.10.0, python310Packages.executing: 0.8.2 -> 1.2.0

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg build python310Packages.python-socketio ansible-core python310Packages.devtools python310Packages.executing

This should go to staging-next, because devtools currently does not build on staging-next.

So I picked the devtools commit as 4f1ab0953d7

Picked the leftovers into #208232


Implement zitadel.feature.v2gamma.FeatureService Queries

As a developer, I want to have an example service for a new mutlitenancy settings API query side with inheritance so I can test the experience by using it with all my API clients.
Acceptance Criteria

[ ] zitadel.feature.v2gamma.FeatureService GET method is implemented
[ ] The implementation adheres to #7592
[ ] The FeatureService implements the behavior for multitenancy enabled settings. Especially inheritance information is returned with the property values.
[ ] The docs from #7649 are updated according to new learnings
[ ] The API Guidelines from #7592 are updated according to new learnings
[ ] Implementation in #7756 is updated according to new learnings
[ ] Subissues defined with #7649 are updated according to new learnings
[ ] Standard logic is reused
[ ] New standard logic is made reusable
[ ] The implementation is unit tested
[ ] The implementation is integration tested

Closing as outdated


Is there a better way to achieve this? What would be the best way to convert a SKImage/SKBitmap to a Carto Bitmap?
Thanks!

Hi. Not very familiar with Skia API, but there seem to be two options:

Simply 'save' the created image to PNG blob and then use Bitmap.CreateFromCompressed method from CARTO SDK.
Convert your SKBitmap to Android Bitmap (or iOS UIImage) and then use BitmapUtils.CreateBitmapFromAndroidBitmap (or BitmapUtils.CreateBitmapFromUIImage) from SDK.

The first option is slower but cross platform, so it depends which one is better.


Selenium - VBA problem while downloading the file automatically using FIREFOX

Hi I am Guruprasad working on Selenium - VBA to automate a download of a xls report using Firefox.
I tried to setPreference but still it is asking my Firefox open file dialog while saving the file following are my details:
Firefox version: 46.0
I am using the Firefox web driver through Excel sheet
Following is my code:
Public Sub testing_selenium_FireFox_driver()
Dim objs As New FirefoxDriver
On Error GoTo error_Firefox_driver
Dim strpath As String
strpath = "C:\"
objs.setPreference "browser.download.folderList", 2
objs.setPreference "browser.download.dir", path
objs.setPreference "browser.download.manager.alertOnEXEOpen", False
objs.setPreference "browser.helperApps.neverAsk.saveToDisk", "application/vnd.ms-excel, application/x-download, application/msword, application/msexcel, application/xls, application/csv, application/ris, text/csv, image/png, application/pdf, text/html, text/plain, application/zip, application/x-zip, application/x-zip-compressed, application/download, application/octet-stream"
objs.setPreference "browser.download.manager.showWhenStarting", False
objs.setPreference "browser.download.manager.focusWhenStarting", False
objs.setPreference "browser.download.useDownloadDir", True
objs.setPreference "browser.helperApps.alwaysAsk.force", False
objs.setPreference "browser.download.manager.alertOnEXEOpen", False
objs.setPreference "browser.download.manager.closeWhenDone", True
objs.setPreference "browser.download.manager.showAlertOnComplete", False
objs.setPreference "browser.download.manager.useWindow", False
objs.setPreference "services.sync.prefs.sync.browser.download.manager.showWhenStarting", False
objs.setPreference "pdfjs.disabled", True
objs.Get ""
objs.Window.Maximize
Please let me know what I am doing wrong here.. It is surely not working as when I am testing the file is not geting automatically saved on the provided location.
Please somebody can help urgently that will be a great help this is the only step remaining from myside to complete.

I got it to work by adding 2 lines.  When the prompt comes up the first time click Save and click the checkbox to do this for docs of this type.  The first line I added was to make the profile persistent.  That way it remembers what you set rather than creating a new profile in a temp dir.  The second line tells it to use the dir you set.  Both lines are marked by 'Added.
`Public Sub testing_selenium_FireFox_driver()
Dim objs As New FirefoxDriver
objs.SetProfile "Download", persistant:=True  ' Added
objs.setPreference "browser.download.folderList", 2
objs.setPreference "browser.download.useDownloadDir", True  'Added
objs.setPreference "browser.download.dir", "C:\temp"
objs.setPreference "browser.download.manager.alertOnEXEOpen", False
objs.setPreference "browser.helperApps.neverAsk.saveToDisk", "application/vnd.ms-excel, application/x-download, application/msword, application/msexcel, application/xls, application/csv, application/ris, text/csv, image/png, application/pdf, text/html, text/plain, application/zip, application/x-zip, application/x-zip-compressed, application/download, application/octet-stream"
objs.setPreference "browser.download.manager.showWhenStarting", False
objs.setPreference "browser.download.manager.focusWhenStarting", False
objs.setPreference "browser.download.useDownloadDir", True
objs.setPreference "browser.helperApps.alwaysAsk.force", False
objs.setPreference "browser.download.manager.alertOnEXEOpen", False
objs.setPreference "browser.download.manager.closeWhenDone", True
objs.setPreference "browser.download.manager.showAlertOnComplete", False
objs.setPreference "browser.download.manager.useWindow", False
objs.setPreference "services.sync.prefs.sync.browser.download.manager.showWhenStarting", False
objs.setPreference "pdfjs.disabled", True
objs.Get "http://..../mydoc.docx"
objs.Window.Maximize
End Sub`


Some unit tests failed. Let me try to fix them.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 26s
Docker mode activated.


Fix S3Client.copy return value consistency

Description

Adds support for num/size copy response for single-file copies.
Motivation and Context

S3Client.copy doesn't return a tuple if not copying a directory. This patch adds support for num/size tuple copy response for non-directories.
Have you tested this? If so, how?

Adds assertions for minimum values to existing copy tests.
All s3_test.py tests pass locally.

Just tagging a couple other recent luigi/contrib/s3.py contributors to quicken the review process. Your review would be appreciated!
@gardenunez @ouanixi

@gardenunez Thanks for the review and suggestions!

Another suggestion would be to extract copy-dir and copy-file logic inside copy to a separate function. Maybe even to have copy_dir and copy_file functions instead of copy, this one I still not sure.

I have no opposition to this refactor, but it is outside of the scope of this PR. Feel free to contribute it separately though :)


Remove "beta" and "unsupported" labels from Libre

What it says on the tin. This PR has no associated Trello card, as it's just changing two labels, and can go out with the next release.

 #492 ⁃  [uploader] update dependencies


fix(eventstore): sub queries

It's now possible to add multiple queries to an eventstore-query. This should improve query performance if multiple aggregates are requested in one query.

approve apart from unsolved conflicts

merge main myself and resolved it


ACF Image Field Rendering

Incredibly helpful plugin. Thank you for your exceptional work and foresight.
It seems that ACF image fields are using the id of the current blog rather than the network media source, and therefore return an empty array to the theme layer.
I noticed that in version 1.2.0 that there is code about line 421 that forces galleries to use the network media source id. Would this be adaptable to also work with ACF?

ACF support is one of the items on my todo list. I'm hoping that ACF has some filters in it that facilitate serving its media files from the central media site. It should be possible.
See #21.

in the image crop and file field it is possible to add switch_blog() to bring them to work!

Came to say that I successfully used switch_to_blog() as mentioned above to get an ACF image field's content from my main site.
Here's a full example from inside a repeater field:
switch_to_blog(1);
$image = get_sub_field('photo');
restore_current_blog();

However, I'm currently stuck trying to get the same to work with an ACF options page image field. Using switch_to_blog() in that context gets back the corresponding option field for the switched blog - which is more of an ACF issue, but means the shared image can't be retrieved from the original source this way.

Okay, I figured out how to grab ACF images that are stored as options. The problem is in the "format" parameter on get_field() - it defaults to "true", which causes ACF to call get_post() on the image's ID, which we don't want because it looks for the image in the wrong blog.
So I was able to get it working by passing "false" for the "format" argument to get_field(), which gets back the image's ID, which we can then use to call acf_get_attachment() in the proper blog;
$image_id = get_field('photo', 'option', false);
switch_to_blog( $main_blog );
$image = acf_get_attachment( $image_id, 'full' );
restore_current_blog();

Not sure if that's relevant to getting this working in NML, but hopefully it's helpful to someone.

Thanks for the post @raelshark

Fixed in 1.5.0.

Thanks for those code pointers @raelshark, it helped a lot. Cheers!


Search console mobile usability issues

Try not to change the current appearance of the site and it looks almost similar after solving the issue


Cannot find main.* for any supported scripting backend

Running KDE Plasma/X11 on Arch
I'm receiving this error when trying to use rikai-mpv:

Cannot find main.* for any supported scripting backend in: /home/charlie/.config/mpv/scripts/rikai-mpv
I've followed the README installation step by step, including installing all the necessary dependencies.
Here is my folder structure:

I haven't changed any configs, and have also unchecked the "Allow applications to block compositing" option.
The script seems to be semi functioning, as the subtitles are rendered differently when the script is enabled:

When I hover over the subtitles, nothing appears, however the black outline around the subtitles disappears.

Here are my dependency versions:
python 3.11.3
PyQt5 5.15.9
node v20.2.0
typescript 5.0.4
yarn 1.22.19
socat <IP_ADDRESS>
QtWebEngineWidgets
PyQtWebEngine 5.15.6
PyQtWebEngine-Qt5 5.15.2
PyQt6-WebEngine 6.5.0
KDE Plasma 5.27.5
For what it's worth, I have tried changing my global theme in plasma as discussed in #12 but to no avail.

I managed to fix the issue by installing all the dependencies through Arch's package manager rather than via pip/npm.
First I uninstalled the existing dependencies:
pip uninstall PyQtWebEngine
sudo npm uninstall -g typescript
sudo npm uninstall -g yarn

Then I installed them through the package manager (for me, I use yay):
yay python-pyqt5-webengine
yay typescript
yay yarn

Then I redid the yarn/typescript stuff:
cd ~/.config/mpv/scripts/rikai-mpv/rikaichamp-backend/
yarn install
tsc

And now everything works! Thanks for making this awesome tool :D


Use docker in builds

Maybe we can support docker in building environment?
Actually, I've done some experiment on dockerfile and docker-compose.
Somehow there's still some problems in MySQL container settings for non-ascii. :neutral_face: Even though, I think we should make a standard procedure for environment builds.

+1

+1
Good idea!

Here is my current effort on docker.
With Django + MySQL + Nginx containers.
Finally I resolved the encoding issue in MySQL config with a defined config under ./bin/nginx/mysql_charset.conf. And not sure how to config nginx, it's under ./bin/nginx/nginx.conf.
Any comment on it~


Updated config.go - Externalizing svg data to meshmodel_metadata.json

Description
This PR fixes ([Adapters] Config.go: lint error due to long SVG line) #101
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@Revolyssup @leecalcote  fyi

@b0id Would you lowercase and hyphenate the keys? Refer to column names here https://docs.google.com/spreadsheets/u/2/d/1DZHnzxYWOlJ69Oguz4LkRVTFM79kC2tuvdwizOJmeMw/edit#gid=0

Yes, I thought you might say that.  Will do.

@Revolyssup done.

🚀


Tasks should use bound resources from TaskRuns

3 main changes:

Templating from outputs
Actually using bound resources
Removing name from bindings

Before this change, Tasks were retrieving the Resources to use by
looking for PipelineResources with exactly the name that the Resource is
declared with in the Task. This means that the Resource binding in
Pipelines (and TaskRuns) was doing absolutely nothing.
Instead, we now map bound Resources inside of TaskRuns. The name of a
Resource declared in a Task is a parameter, which we fulfill by
providing the key aka parameter of the Task, and the corresponding
Resource reference we should use for that key.
This allows us to use the same Task with different Resources without
having to change the Task or the Resource.
This was not caught by any tests because the tests were co-incidentally
using the same name for the Resources and the Resource
key/name/parameter in the Task. Now the tests use different names.
This came up while creating example yaml for #89 - as soon as I tried to
use two different git resources (one upstream, one my fork) I realized
that the mapping was not working.
This also partially addresses #138 by removing the Name field from the
bindings, which is not required.
This addresses part of #64 by adding templating from outputs.

Sorry reviewers 😞

W1025 19:33:14.857] + dep-collector -check ./cmd/controller ./cmd/webhook
W1025 19:33:14.861] 2018/10/25 19:33:14 Error collecting transitive dependencies: github.com/knative/build-pipeline/cmd/controller
W1025 19:33:14.861]  -> cannot find package "flag" in any of:
W1025 19:33:14.862] 	/go/src/github.com/knative/build-pipeline/vendor/flag (vendor tree)
W1025 19:33:14.862] 	/usr/lib/google-golang/src/flag (from $GOROOT)
W1025 19:33:14.862] 	/go/src/flag (from $GOPATH)

🤔

/test pull-knative-build-pipeline-build-tests

/test pull-knative-build-pipeline-build-tests

@bobcatfish the only thing is the params in the output which we can deal with later I guess


Icelandic holidays and other dates

Discussion of the creation of a API endpoint for Icelandic holidays.
As I have seen too many questions on the existence of an API for listing Icelandic holidays then this issue should be the starting point of such a resource. For best results this should not do any scraping but do it's own calculation of these dates.
Amongst key things that need to be discussed:

[ ] Definition of the queries.
[ ] Definition of the results.
[ ] iCal support?
[ ] Should other dates that have names be included (bónda-/konudagur) and how should those be defined so not to confuse with legal holidays.
[ ] Are there nice open source holiday calculators out there that we could base on.
[ ] Other types of related date based data that would be nice.

Other Projects:

moment-holiday
date-holidays (Includes Iceland(unverified))
HolidaysCalendar

Resources:

Vísindavefur: Hverjir eru lögbundnir frídagar okkar Íslendinga?
Wikipedia: Lögbundnir frídagar á Íslandi

Jumped the gun possibly.
Undocumented API exists https://github.com/apis-is/apis/tree/master/endpoints/calendar that uses https://github.com/gaui/fridagar-node
Is everyone happy with it? Does it need improvement or shall we just document it and close the issue?

Is everyone happy with it? Does it need improvement or shall we just document it and close the issue?

I think documenting it and closing would be great ✨


Update main.css

And I could suggest to change the avatar picture and the gradient color on the left for the pictures below (if you change the gradient, then you would need to change the color on the line 2482 for #535454)

Hello @lorenamd !
I totally agree with the change of the gradient and the avatar. Could you include those changes in this PR, I will be very happy to merge it (:
Thank you !

I am new in Github, but I have tried before to upload these images in their folder but it says "File uploads require push access to this repository".

I will add the images in another PR. Thank you for your help 😸


DBZ-TBA Create Unittests for ServiceAccountDependent Class

Create Unittests for ServiceAccountDependent Class
Test Coverage: 100%

hi @jcechace,
Could you please take a look on this PR to add unittests on the ServiceAccountDependent class.
Thank you


Puppeteer "Page crash!" error

I'm unable to get puppeteer to take a screenshot.
I read in another issue to use a docker deployment and found the following Dockerfile.
FROM node:9-alpine

# Installs latest Chromium (63) package.
RUN apk update && apk upgrade && \
    echo @edge http://nl.alpinelinux.org/alpine/edge/community >> /etc/apk/repositories && \
    echo @edge http://nl.alpinelinux.org/alpine/edge/main >> /etc/apk/repositories && \
    apk add --no-cache \
      chromium@edge \
      nss@edge

RUN apk update && apk upgrade && \
    apk add --no-cache bash git openssh

# Help prevent zombie chrome processes
ADD https://github.com/Yelp/dumb-init/releases/download/v1.2.0/dumb-init_1.2.0_amd64 /usr/local/bin/dumb-init
RUN chmod +x /usr/local/bin/dumb-init

COPY . /app/
WORKDIR app

# Install deps for server.
RUN yarn

# Skip downloading Chromium when installing puppeteer. We'll use the installed package.
ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD true

# Use Puppeteer 0.11.0 b/c it bundles Chromium 63.
RUN yarn add<EMAIL_ADDRESS>
RUN addgroup -S pptruser && adduser -S -g pptruser pptruser \
    && mkdir -p /home/pptruser/Downloads \
    && chown -R pptruser:pptruser /home/pptruser \
    && chown -R pptruser:pptruser /app

# Run user as non privileged.
USER pptruser

EXPOSE 8080

ENTRYPOINT ["dumb-init", "--"]
CMD ["yarn", "start"]

and im launching puppeteer with:
	const browser = await puppeteer.launch({
		executablePath: '/usr/bin/chromium-browser',
		args: ['--disable-dev-shm-usage','--no-sandbox', '--headless', '--disable-gpu']
	});

Is there something i'm missing? All i can think of is increasing shm-size but i thought if i used --disable-dev-shm-usage it would use /tmp instead of the 64MB limit in /dev/shm?
Error message:
> (node:27) UnhandledPromiseRejectionWarning: Error: Page crashed!
>     at Page._onTargetCrashed (/app/node_modules/puppeteer/lib/Page.js:92:24)
>     at Session.Page.client.on.event (/app/node_modules/puppeteer/lib/Page.js:88:56)
>     at Session.emit (events.js:180:13)
>     at Session._onMessage (/app/node_modules/puppeteer/lib/Connection.js:199:12)
>     at Connection._onMessage (/app/node_modules/puppeteer/lib/Connection.js:98:19)
>     at WebSocket.emit (events.js:180:13)
>     at Receiver._receiver.onmessage (/app/node_modules/ws/lib/WebSocket.js:141:47)
>     at Receiver.dataMessage (/app/node_modules/ws/lib/Receiver.js:389:14)
>     at Receiver.getData (/app/node_modules/ws/lib/Receiver.js:330:12)
>     at Receiver.startLoop (/app/node_modules/ws/lib/Receiver.js:165:16)
>     at Receiver.add (/app/node_modules/ws/lib/Receiver.js:139:10)
>     at Socket._ultron.on (/app/node_modules/ws/lib/WebSocket.js:138:22)
>     at Socket.emit (events.js:180:13)
>     at addChunk (_stream_readable.js:274:12)
>     at readableAddChunk (_stream_readable.js:261:11)
>     at Socket.Readable.push (_stream_readable.js:218:10)

I believe this is because the Alpine build of Chrome currently predates the --disable-dev-shm-usage flag's implementation. (I think Alpine's on v63 or v64, where that flag was not launched until v65).
Since I can't see a means of specifying custom docker runtime options, you're probably out of luck until either Zeit allows custom arguments, or Alpine's repository catches up to the current build of Chromium.

Thank you so much for the effort you have put into this issue! 😊
However, since we completely re-worked the entire codebase of Now CLI and this issue does not apply to the new code anymore, I'm closing it now.
You can read more about our biggest release yet here: https://zeit.co/blog/now-2


Fix ANCM environment variables bugs

New rules:

web.config overrides everything but ASPNETCORE_IIS_HTTPAUTH and ASPNETCORE_HOSTINGSTARTUPASSEMBLIES
ASPNETCORE_IIS_HTTPAUTH is always overridden by the ANCM
For ASPNETCORE_HOSTINGSTARTUPASSEMBLIES web.config value overrides the global environment variable. In out of proc case Microsoft.AspNetCore.Server.IISIntegration is appended to the global environment variable if web.config doesn't have one.

Fixes: https://github.com/aspnet/AspNetCore/issues/4566

Just ASPNETCORE_IIS_HTTPAUTH or should we establish a well-known prefix? Will probably save us from a shim change in the future?

I'm keeping ASPNETCORE_IIS_HTTPAUTH behaviour for backwards compatibility. I doubt we would need to add any other variable like this in the future.

Hey guys! Has this been released or will it be released soon? How would I know which version it would be in?
Thanks for all your work!

Hey guys! Has this been released or will it be released soon?

This was merged as part of .NET Core 3.0, so it should be present in the latest preview builds available here: https://dotnet.microsoft.com/download/dotnet-core/3.0


New pack register CLI command syntax

Cherry picked just the CLI syntax change from #3020.
Resolves #3001
I'm also working on some other related changes.
TODO

[ ] Tests for pack register API endpoint

Current coverage is 76.49% (diff: 100%)

Merging #3043 into master will increase coverage by 0.01%

@@             master      #3043   diff @@
==========================================
  Files           430        430
  Lines         21988      21988
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          16816      16819     +3
+ Misses         5172       5169     -3
  Partials          0          0

Diff Coverage
File Path

•••••••••• 100%
st2client/st2client/commands/pack.py

Powered by Codecov. Last update 30a9fd8...5a5e75b


Soft Sensors - Boot Progress and OS states

    "/xyz/openbmc_project/state/host0": {
      "AttemptsLeft": 2,
      "BootProgress": "xyz.openbmc_project.State.Boot.Progress.ProgressStages.Unspecified",
      "CurrentHostState": "xyz.openbmc_project.State.Host.HostState.Off",
      "OperatingSystemState": "xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Inactive",
      "RequestedHostTransition": "xyz.openbmc_project.State.Host.Transition.Off"
    }

https://gerrit.openbmc-project.xyz/#/c/6350/

Spent more time on reviews , testing and discussion.


Correct misspelled word [Firmare -> Firmware]

The word Firmware is misspelled on line 254

Great! Thanks!


Adding placeholder text?

Is there a way to show placeholder text? (Some custom grey text, visible if nothing is selected and nothing has been typed in yet)

I'm looking for a way to do this too ... in the multiselect.min.js file in line 31 it shows the text of when you select all the items, maybe we should do something like that ...

you can use this code
$('.multiselect-input').attr('placeholder', 'Please Select');


[BUG] - Problem icons with thema light

Describe the bug
As you can see from the image some icons when the theme is in light mode are not seen well.
Screenshots

Desktop (please complete the following information):

OS: macOS 12.3
Xcode: 13.3

Yeah noticed this too. We might change it from yellow to another color and ditch yellow all-together.

Looks like they change the yellow shade. I think I read that the use of a certain variable will do that for you.

@austincondiff : What program are you viewing the files with XCode?

Yes, those screenshots are in Xcode

@austincondiff : Again, this is not so well seen in the case of the light background.

@Angelk90 I pointed this out to @lukepistrol earlier, but selected items should get white icons as shown here in Xcode.

@austincondiff : Yes, this could be the ideal solution.

just assigned it to myself

@austincondiff : Editor: Agate

@austincondiff : Again, this is not so well seen in the case of the light background.

was fixed in #259


Provide packaging via setuptools pyproject.toml with entrypoint and tests

Help me fix workflows, if possible. Experienced in GitLab CI/CD but not GitHub workflows.

Hi. Some of the changes really are helpful, such as adding a packaging file and standardizing the file structure. I don't have a lot of dev experiences in Python (or any other languages actually, I do not work as a developer lol), so those improvements are welcome.
Since I do believe the good practice of contributing to a project is to add one specific feature at a time, and not to add personalized changes. So some of the changes are more suitable to be in your own repo, if without discussions first. Such as changing the script name, requiring requires-python = ">=3.10", or bumping the version to 1.0.0. Adding compiled binary is also weird.
(Or did you mistakenly created the PR in my repo, instead or yours?)
I would add the following. I can do these myself, but you could create separate PRs since you have already worked a lot on it:

Add tests. Probably use the tests in github workflow
Use a project file, either pyproject.toml or setup.py would be fine. And also adapt the project structure accordingly. But keep this change minimal like only adding a main function would be enough to create a entry point.
More if you consider them appropriate.

Sorry to close this first. You can continue to discuss here, it's alright:)

Thanks for your feedback. I have adjusted the changes to minimal, with the following adaptations based on your feedback:

Bumping version to the next feature release 0.3.0 instead of a major
Changing back the entrypoint to fio-cdm
Provide an entrypoint test according to the GitHub workflows
I have left the required Python version to at least 3.9.13 since this is the Ubuntu 22.04 default currently. Anyone using Ubuntu from now on has at least that version after the latest sudo apt upgrade
I will remove the binaries, yes, this is sketchy. I used the Windows binaries from the fio installer. However, we should not ship that. Changes incoming in short, however I will leave my fork-master with these binaries.

I suggest creating multiple PRs, each containing changes about one topic.

* Bumping version to the next feature release `0.3.0` instead of a major

Probably leave that for me to decide

* I have left the required Python version to at least `3.9.13` since this is the Ubuntu 22.04 default currently. Anyone using Ubuntu from now on has at least that version after the latest `sudo apt upgrade`

It's about users who are using other version or distros, like older Ubuntu, Debian, etc. They have different versions of Python on their machine. That's the reason to keep the supported environment as wide as possible.

Update: If you have your own intention of distributing this tool, e.g., for windows WSL users (I guess that's why you assume Ubuntu 22.04 to be default?), you can leave the tight requirement in your own version.
You are free to publish a "pycdm" with your preferences, I think the MIT license permits it.


Adjust setting: maximal variants to display to 1000

Is your feature request related to a problem? Please describe.
The maximal variant display count of 200 is to stringent. It is easy to overlook that variants are cut off.
Describe the solution you'd like
We should increment this to 500 and also display a more verbose warning in a red box if the variant count is cut off.
Describe alternatives you've considered
N/A
Additional context
N/A

Resolution Proposal
Implement settings defaults change and add the box to the display.
Affected Components
VarFish server
Affected Modules/Files
variants/templates/*
Required Architectural Changes
None
Required Database Changes
None
Backport Possible?
Yes
Resolution Sketch

[ ] adjust settings for max. variants
[ ] adjust template with warning box

I'm deciding on leaving the settings as is and just display a verbose box on top in case of truncation.


Consolidate build scripts

Modify build-and-publish.sh to use build.sh.
Modify build.sh to accept an optional --publish flag to further simplify its use by build-and-publish.sh.

To be implemented after #27 is resolved

PR #27 was closed. Feel free to refactor the scripts. :-)

This was addressed as far as I can tell.


QA testing for https://github.com/microsoft/workshop-library/blob/main/react-get-started/README.md

[ ] All elements of the workshop are in place (README, workshop designer, solution if necessary, any images if necessary, slides, a call-to-action with a Learn module linked (usually in "Next Steps" area), a knowledge check (either in slides or directly linked to the workshop README) and an area to extend knowledge.
[ ] The workshop can be done in its listed time frame
[ ] Instructions are clear and well written
[ ] The workshop is bug-free
[ ] The workshop 'flows' well

[x] The workshop can be done in its listed time frame
[x]  Instructions are clear and well written
[x]  The workshop is bug-free
[x]  The workshop 'flows' well
[ ] All elements of the workshop are in place (README, workshop designer, solution if necessary, any images if necessary, slides, a call-to-action with a Learn module linked (usually in "Next Steps" area), a knowledge check (either in slides or directly linked to the workshop README) and an area to extend knowledge.
An area to extend knowledge is MISSING!

thank you! I'll add a section!

done, thank you!


feat: temporalfilter util 함수 추가

날짜별 commit, cloc를 가져오고 오름차순으로 정렬하였습니다.

@all-contributors please add jeonghye-choi  for code

https://github.com/all-contributors please add 'jeonghye-choi'  for code

@all-contributors please add kmin-jeong for code

@all-contributors please add @jeonghye-choi for code


[HIPIFY] Isn't hipify-clang preprocessor based tool?

I have attempted to migrate below code using hipify-clang in Windows environment.
`#if 0
#include <mpi.h>
#else
#include <omp.h>
#endif
int main()
{
//CUDA code
return 0;
}`
But encountering following error:
C:\Users\APENDLIX\AppData\Local\Temp\test.cu-10f48a.hip:16:10: fatal error: 'mpi.h' file not found #include <mpi.h>          ^~~~~~~ Exception Code: 0xC0000005
I'm wondering about why it is considering mpi.h though it is disabled. Isn't hipify-clang preprocessor based tool? Am I missing anything to consider for migration?

What is HIPIFY AMAP?

I meant, to HIPIFY (CUDA sources) As Much As Possible.


Dash 3.0.0 support?

As per the title, are there plans to support Dash 3.0.0? Are code changes required?

I haven't really been following it, so, not sure how bad it is. Maybe @squarebracket has a better idea.
I think if it's not a lot of work (or if someone wants to submit a PR) it would be nice to have a version that supported it but our focus is on our http-streaming project nowdays.

Are there any updates on this?
https://github.com/videojs/videojs-contrib-dash/pull/334
Thanks

any updates?

Unfortunately, we don't have the bandwidth to work on this. Updating to 3.0 isn't a drop-in update https://travis-ci.org/github/videojs/videojs-contrib-dash/builds/661448572. If someone makes a PR to update it to 3.0 we'd be happy to review and release the update, but we don't have plans to update it ourselves right now.

Wasn't this closed by https://github.com/videojs/videojs-contrib-dash/pull/349 ?
The Readme still says only 2.x is supported though

Yup, latest contrib-dash uses dash 3.x. Guess we forgot to update the readme (and this issue)


23.7-RC3 SMART status widget showing extra info that does not make sense

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[X] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[X] The title contains the plugin to which this issue belongs

Describe the bug
Since upgrading to 23.7 and still present in RC3 the SMART status widget looks like shown in the attachment.
Tip: to validate your setup was working with the previous version, use opnsense-revert (https://docs.opnsense.org/manual/opnsense_tools.html#opnsense-revert)
To Reproduce
Steps to reproduce the behavior:

Update to 23.7
Install os-smart plugin
Place SMART status widget on dashboard

Expected behavior
The sesX devices should not be there.
Screenshots

Kind regards,
Patrick

I see. What was wrong with the old method?
On my hardware:
root@opnsense:~ # sysctl -n kern.disks
ada1 ada0
root@opnsense:~ # smartctl --scan
/dev/ses0 -d atacam # /dev/ses0, ATA device
/dev/ada0 -d atacam # /dev/ada0, ATA device
/dev/ada1 -d atacam # /dev/ada1, ATA device
/dev/ses1 -d atacam # /dev/ses1, ATA device


Improvement/hd 3904

Issue : HD-3904

Hello benzekrimaha,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name
description
privileged
authored

/after_pull_request
Wait for the given pull request id to be merged before continuing with the current one.

/bypass_author_approval
Bypass the pull request author's approval
:star:

/bypass_build_status
Bypass the build and test status
:star:

/bypass_commit_size
Bypass the check on the size of the changeset TBA
:star:

/bypass_incompatible_branch
Bypass the check on the source branch prefix
:star:

/bypass_jira_check
Bypass the Jira issue check
:star:

/bypass_peer_approval
Bypass the pull request peers' approval
:star:

/bypass_leader_approval
Bypass the pull request leaders' approval
:star:

/approve
Instruct Bert-E that the author has approved the pull request.

:writing_hand:

/create_pull_requests
Allow the creation of integration pull requests.

/create_integration_branches
Allow the creation of integration branches.

/no_octopus
Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead

/unanimity
Change review acceptance criteria from one reviewer at least to all reviewers

/wait
Instruct Bert-E not to run until further notice.

Available commands

name
description
privileged

/help
Print Bert-E's manual in the pull request.

/status
Print Bert-E's current status in the pull request TBA

/clear
Remove all comments from Bert-E from the history TBA

/retry
Re-start a fresh build TBA

/build
Re-start a fresh build TBA

/force_reset
Delete integration branches & pull requests, and restart merge process from the beginning.

/reset
Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

one peer

Conflict
There is a conflict between your branch improvement/HD-3904 and the
destination branch development/1.
Please resolve the conflict on the feature branch (improvement/HD-3904).
git fetch && \
git checkout origin/improvement/HD-3904 && \
git merge origin/development/1

Resolve merge conflicts and commit
git push origin HEAD:improvement/HD-3904

Request integration branches
Waiting for integration branch creation to be requested by the user.
To request integration branches, please comment on this pull request with the following command:
/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Conflict
There is a conflict between your branch improvement/HD-3904 and the
destination branch development/1.
Please resolve the conflict on the feature branch (improvement/HD-3904).
git fetch && \
git checkout origin/improvement/HD-3904 && \
git merge origin/development/1

Resolve merge conflicts and commit
git push origin HEAD:improvement/HD-3904

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

one peer

Conflict
There is a conflict between your branch improvement/HD-3904 and the
destination branch development/1.
Please resolve the conflict on the feature branch (improvement/HD-3904).
git fetch && \
git checkout origin/improvement/HD-3904 && \
git merge origin/development/1

Resolve merge conflicts and commit
git push origin HEAD:improvement/HD-3904

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

one peer

Conflict
There is a conflict between your branch improvement/HD-3904 and the
destination branch development/1.
Please resolve the conflict on the feature branch (improvement/HD-3904).
git fetch && \
git checkout origin/improvement/HD-3904 && \
git merge origin/development/1

Resolve merge conflicts and commit
git push origin HEAD:improvement/HD-3904

I have successfully merged the changeset of this pull request
into targetted development branches:

:heavy_check_mark: development/1

The following branches have NOT changed:

development/1.0
development/1.1

Please check the status of the associated issue HD-3904.
Goodbye benzekrimaha.
The following options are set: approve


Additional Fix For Handling conn_handle=0

A conn_handle of 0 should be handled as a valid connection handle while BLE_HS_CONN_HANDLE_NONE should be the proper assignment for the cases where the connection is no longer valid. This fix includes some spotted areas where a check for a valid connection handle is not properly handled.

Should be resolved by now. Thanks.

Ok, looks good to me. Thank you for the fix!


Can't sign with Passport (founder's edition)

I used the Passport to import the watch-only wallet into Sparrow. When I went to sign it didn't work: "invalid QR code".

Logs and screenshot attached. Not sure if a Sparrow issue or an issue with Passport.
sparrow.log

Yes, I used the airgapped option to import the watch-only wallet.

Are you also seeking assistance on the Telegram chat?

Not really. In the Telegram group there was another issue related to passport, but not this. The failed signing with the Passport I just posted here.

From the log file it appears this was due to the same bug you recently reported. Marking as a duplicate of #981.


Export with user permissions fails

Problem Description
Exports create files owned by root.
Attempting to run with user permissions fails with:
touch: cannot touch '/opt/drawio-desktop/unwanted-lines.txt': Permission denied

Replicate issue
Create any diagram called diagram.drawio, then attempt an export with user-permissions:
$ docker run --rm -it -w /data -v $(pwd):/data \
    -u $(id -u):$(id -g) \
    rlespinasse/drawio-desktop-headless:v1.24.0 \
    -x -o diagram.drawio.png diagram.drawio
touch: cannot touch '/opt/drawio-desktop/unwanted-lines.txt': Permission denied

Why is this a problem?
personally:
Automating image exports on a CI server (Jenkins), files owned by root cause future attempts to clean a build fail, causing future CI tasks on that branch to fail.

With #71, you will be able to run as non-root
docker run -it -u $(id -u):$(id -g) -e HOME=/data/home -w /data -v $(pwd):/data rlespinasse/drawio-desktop-headless

[!CAUTION]
You will need -e HOME=/data/<whatever

:tada: This issue has been resolved in version 1.26.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


wip: to use fluentbit instead of fluentd

Explain the details for making this change. What existing problem does the pull request solve?
Put Closes: #XXXX in your comment to auto-close the issue that your PR fixes (if such).

superseded by https://github.com/uselagoon/lagoon-charts/pull/155


Command + Control + F not working for fullscreen.

I want to open the fullscreen mode in a software called slicereader.
It seems to be fussy about how to open the fullscreen mode; first you have to press down Command, then you need to press Control, then you need to press F. If you press the keys in any other sequence, the bell is rung and it does not work.
I'm guessing this is why this key-command is not working:
KeyCode::F | ModifierFlag::COMMAND_L, | ModifierFlag::CONTROL_L
I know it is possible to press keys in sequence with the __{ ... }__ syntax, but is there a way to press modifier keys in a certain sequence while holding them in?
What I want to do is first press command and hold it, then control and hold it, then f.

If you press the keys in any other sequence, the bell is rung and it does not work.
I cannot reproduce this issue.

Anyway, you can specify modifier order by using sticky modifier.
    <autogen>
      __KeyToKey__
      KeyCode::A,

      KeyCode::VK_STICKY_COMMAND_L,
      KeyCode::VK_STICKY_CONTROL_L,
      KeyCode::A,
      Option::NOREPEAT,
    </autogen>

Thanks a bunch!