feat!: switched to esm, added factory

Codecov Report

Merging #6 (3327c8b) into master (11c460a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         2    +1
  Lines           73        84   +11
=========================================
+ Hits            73        84   +11

Impacted Files
Coverage Δ

Factory.js
100.00% <100.00%> (ø)

TermMap.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c460a...3327c8b. Read the comment docs.


Option to sync minimap rotation

I have my TB and GW minimaps lined up to get the best of both worlds:

Unfortunately, because the guild wars minimap has a bit of acceleration, all the npc icons look blurry when turning (Because the underlying map is slightly off)
Can you add an option to either disable GW map's acceleration, or make the TB minimap use the same acceleration as the GW one?

Duplicate of #87

Looks like you're right @PostCrafter I'll close this


KAFKA-8976 [WIP]:  AdminClient should not fetch metadata unnecessarily

The AdminClient should not do unnecessary metadata lookups when methods like createTopics and deleteTopics are called with empty input maps.
No new tests needed?
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Thanks for the PR @aurlien , could you also make a quick check on other APIs and see if we can do the same check to avoid the request if the parameter indicates a no-op?

Yeah, sure!

@aurlien Are you still working on this?

Sorry, I completely forgot about this. Closing the PR.


all: issue Go 1.5.2

Tracking bug for Go 1.5.2.

@aclements on #12552:
Since it's not at all obvious from the issue log, here's the set of commits that actually fix this and should be cherry-picked for 1.5.2, in cherry-picking order:
2c91114 runtime: adjust the ppc64x memmove and memclr to copy by word as much as it can (https://golang.org/cl/14840)
9f6df6c runtime: use 4 byte writes in amd64p32 memmove/memclr (https://golang.org/cl/15370)
168a51b runtime: adjust the arm64 memmove and memclr to operate by word as much as they can (https://golang.org/cl/14813)
4b7d5f0 runtime: memmove/memclr pointers atomically (https://golang.org/cl/16668)
I've confirmed that they cherry-pick cleanly (in this order) to the 1.5 release branch.

Happy to review cherry pick CLs.

Update on the release:
go1.5.2 is tagged, binaries are built and signed, but ran into a hiccup when uploading the binaries.
The binaries upload to Google Cloud Storage just fine, but the update to golang.org/dl is stuck (some changes were made to the server recently). Working on fixing it with @bradfitz.

It's out.

:clap:


Rollouts integration is disabled on this controller; cannot start verification

Checklist

[X] I've searched the issue queue to verify this is not a duplicate bug report.
[X] I've included steps to reproduce the bug.
[X] I've pasted the output of kargo version.
[X] I've pasted logs, if applicable.

Description
Hi,
I'm trying out Kargo, and kargo-demo is working fine.
I've tried extending it by setting up an AnalysisTemplate just like in the docs.
However, after a few promotion requests, there's no AnalysisTemplate run. The freight simply promotes as before and is marked as healthy.
When I check kubectl -n kargo-demo get stage test -o yaml, I see:
status:
  freightHistory:
  - id: 1948ea786cddf78d86f43b9f6f18122de6a1b70c
    items:
      Warehouse/kargo-demo:
        images:
        - digest: sha256:f28a6bcae1c32a35e45678de83099e91520eb8ad0777ed1864592269eca89156
          repoURL: docker.io/okrehel/minirepo
          tag: 2409.27.3
        name: 1424c04cccbf0b8a1364cd5fc7651bc989b52cdc
        origin:
          kind: Warehouse
          name: kargo-demo
    verificationHistory:
    - finishTime: "2024-09-27T17:34:56Z"
      id: 8d3c3841-2674-41dd-b124-313b51d187a9
      message: Rollouts integration is disabled on this controller; cannot start verification
      phase: Error
      startTime: "2024-09-27T17:34:56Z"

I did some searching and it seems like rollouts integration should be enabled by default unless explicitly disabled.
I did not explicitly disable it, nor do I know how to enable it.
Looking through the issues, #2075 might be related.
Steps to Reproduce

Run quickstart
Add an AnalysisTemplate from https://kargo.akuity.io/concepts/
Promote
Check stage status: verificationHistory shows verification was not started

Version
Client Version: v0.8.7
Server Version: v0.8.7

I run:

Ubuntu 22.04
Docker 27.3.1
kind v0.23.0 go1.21.10 linux/amd64

Logs
Paste any relevant application logs here.

There should be log messages at startup that tell you what integrations are enabled and disabled and why.

Thanks for the pointer. Removing the node kluster and re-doing the whole thing from the start has worked.
I've made an AnalysisTemplate that fails on purpose just to see what happens.
Indeed, it won't let me promote from test to uat.
I think having only the "Promotion succeeded" and "Healthy" icons and them showing up green leads me to a false sense that everything succeeded. Is it possible to add a third "Verifications" icon?
Other than this, I can close the issue since it's no longer reproducible.

Ya... I think we may need to get those icons under control. I believe one of the icons turns to a spinner when a verification is in-progress, but I don't think verification status is displayed on each node when it's not in-progress. I'll open a separate issue for sorting that out.


[Feature] GitHub action workflow for greeting contributors

Description
Description:
The current project lacks an automated action to greet contributors. GitHub Actions can significantly enhance project automation. I propose adding a GitHub Action workflow to greet new pull request (PR) and issue creators, fostering a welcoming environment.
Proposed Changes:
Implement a GitHub Action workflow that triggers on new PRs and issues. The workflow should include a greeting message to acknowledge and appreciate the contributors for their efforts.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Please assign me this @Rakesh9100 under iwoc24

Proceed @praptisharma28

PR status @praptisharma28

giving @Rakesh9100


Made it possible to write generic type converters for base types.

This pull request should finally make it possible to write universal converter for enums. This works by passing the type of enum (e.g. it's class) to typeConverter—the same way this is done by everyone, who employs pluggable runtime  converters. If you don't like the used approach, I am open for discussion of other ways to accomplish the same thing. Just don't propose to write TypeConverter for each of ~100 enums in my code, please :)

I like this a lot. Can you add an example of how you'd use it for universally parsing enums and add a few tests? Thanks!

I have given this a bit more thought, and realized that the my initial approach have been wrong. Passing around meta-information at runtime defeats the point of annotation processing.
How about doing it like this instead: if a class has a method with signature
SuperClass valueOf(String str)

then treat it is value class: serialize with toString, parse with valueOf. This would kill two birds with one stone (and such convention seems to work well for some REST frameworks like JAX-RS and CRest).


fix: Change if condition to provide e2e test functionality.

The current "hack" for testing codemirror in angular is using browser.executeScript with setValue.  Link to stackoverflow: https://stackoverflow.com/questions/30552393/how-to-write-protractor-test-for-ui-codemirror-angularjs-directive.
However, this fails for ngx-codemirror because we are ignoring some setValue calls for fewer and more accurate change-detection calls. I have tried to achieve the same by using a different if condition to facilitate end to end testing.

@scttcper PTAL

:tada: This PR is included in version 4.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


⚠ Avatar API Endpoint has degraded performance

In 269f216, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 1945 ms

Resolved: Avatar API Endpoint performance has improved in 9196b26 after 8 minutes.


chore: Update Dockerfile and add run script

Pull Request
Description
This change modifies the Docker setup and execution process for the analyser:

The run.sh script is now copied into the Docker image alongside pyproject.toml and poetry.lock.

The ENTRYPOINT in the Dockerfile has been updated to use the new run.sh script instead of directly executing the Python module.

A new run.sh script has been added, which:

Lists the contents of the current directory
Executes the analyser using Poetry

These changes provide more flexibility in the container startup process and allow for additional setup or debugging steps before running the main application.
fixes #90

#89  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JackPlowman and the rest of your teammates on  Graphite

Merge activity

Sep 30, 8:20 AM EDT: @JackPlowman merged this pull request with Graphite.


Daemon doesn't run when I start Breeze-ui.exe

Downloaded a fresh copy to the 64bit windows 10 wallet onto a computer that hasn't had the wallet running before.  Breeze loads and sits on the initialising screen.  Fiddler showed that it was failing to connect to the /api/wallet/files endpoint.  Turned out the Breeze.Daemon.exe isn't automatically being run by the wallet.

 [POS] Implement checkpointing similarly to StratisX

@RobertMCarr have you tried running the daemon.exe in command line?
What error do you get?
Make sure to add: light -testnet to the start.

Hi @dev0tion I didn't get any errors.  The UI just never got past the "loading the future" screen.  However since the last release, I don't have this problem but I have seen those that do in the slack.
To confirm, running it in the command line with "light -testnet" worked but i had to do it before running the UI.


Release notes?

Your Question
Hi folks - we're happy users of gorm. There are new releases every now and then, but we're having a hard time understanding what changed. Are there any official release notes?
Currently, for example, we're thinking about upgrading from v1.21.13 to v1.22.2.
The document you expected this should be explained
We found older release notes in two distinct documents:

https://github.com/go-gorm/gorm/releases or https://github.com/go-gorm/gorm/tags
https://gorm.io/docs/v2_release_note.html

Both of these pages are not maintained anymore.
We could resort to reading the code diffs, but it's almost impossible for us to figure out what of it is breaking/bugfix/feature improvement.
There is also an issue raising the same question - https://github.com/go-gorm/gorm/issues/4317 - but the answers, pointing to the links above, are not maintained.
The sub-projects https://github.com/go-gorm/postgres and https://github.com/go-gorm/prometheus do also not have release notes.
Expected answer
Any pointers to release notes or how we can figure out what changed in a new version.

Hello @MatthiasWinzeler
Thank you for your report, sorry for lacking the minor releases changelog, we don't have one mostly because of lacking of time ;(
Anyway, usually a new release like this won't introduce any breaking changes, and we should added all new features to our documents http://gorm.io
And yes, the changelog should be important, we will increase its priority in the future.
Thank you.

@jinzhu Thanks for your response!
FWIW, I think we're fine with figuring out new features from the changelog.
What we're afraid of is breaking changes that are introduced while upgrading a minor or patch version and we have no way to figure out.
I think if you highlight breaking changes somewhere (i.e. in the Github tag or release description) that would already serve the users a lot :)

In general, GORM provides go1 like compatibility promise, and won't provide breaking changes w/o API changes. (unless you are relying on a bug ;)

@jinzhu that's great news, thanks!


Keras load weights does not work

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Y
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.9
Python version: 3.6
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: 9.0/7
GPU model and memory: Quardo M4000
Exact command to reproduce:

Describe the problem
I try a simple Keras model. After saving the model weights, I tried to reload it. However, the "load_weights" function does not really load the weights, but still use the initializer's setting in the model.
Source code / logs
def test_load():
  data = np.ones((1,1,4,5), dtype=float)

  model = keras.Sequential()
  model.add(Conv2D(5, 1, use_bias=False, kernel_initializer='ones', trainable=False))

  results = model.predict(data)
  print(results)

  for layer in model.layers:
    weights = layer.get_weights()
    layer.set_weights(np.zeros_like(weights))

  results = model.predict(data)
  print(results)

  model.save_weights('./temp')

  new_model = keras.Sequential()
  new_model.add(Conv2D(5, 1, use_bias=False, kernel_initializer='uniform', trainable=False))

  new_model.load_weights('./temp')

  results = new_model.predict(data)
  print(results)

Before saving the model, everything works as expected. However, after loading, the loaded weights are always random according to the initializer. I wonder whether there is some bugs in the codes or I used it in a wrong way. Thank you.

Sorry you ran into this. There was a bug with when restore ops got run when graph building; the correct behavior was to mimic eager execution (run restore ops in the Session as they came in), but they were getting run just once instead (which probably interacts with Sequential building immediately here).
Your snippet works for me in the 2018-06-28 nightly. The fix was https://github.com/tensorflow/tensorflow/commit/21d94be838f7a7917f072e5ec0bbe6e3593177b9#diff-7b3f8757e2c5c405c3d056aa0a301c8f
Could you give a nightly a try?

You're right, 20180802 was the one that worked. 20180628 was broken. I don't expect a regression, so anything from August should work.
Looks like the only August Windows builds are CPU: https://pypi.org/project/tf-nightly/1.10.0.dev20180802/#files

Thank you for the clarification. Do you know whether there be any Windows builds for tensorflow GPU version soon?

@av8ramit are we planning to do Windows GPU nightly builds?

@allenlavoie we are in the process of migrating to bazel from cmake. Hopefully that fixes that build.

@av8ramit Thank you for your update. Once the new build is available, I will test it and report the results here.

Nagging Assignee @allenlavoie: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

We now have Windows tf-nightly-gpu builds.

I tested the new nightly built version, and the program now works well. But the Tensorflow 1.10 version does not work.

Hello @allenlavoie, sorry to bother you again. Would you please help have a look at https://github.com/tensorflow/tensorflow/issues/22062? Could this be another similar bug in Keras save/load? Or it was just my mis-use? Thank you.


Perk level placeholders are wrong for rogue

two level 5 slots should be level 15 in the bottom right also looks like there is no 4th perk loaded but with every other class there is
 ->

Wizard has 4

@Snaacky This issue has been fixed in #109 and can be closed


Fixes/module callbacks crash

Hopefully fixes crash related to #780
draft until verified as fixed

Doesn't crash with https://github.com/R2Northstar/NorthstarLauncher/pull/790/commits/f21f2dd677e2773e7c2abf69cb62b0cc234b61cc applied.
m_pNTHeaders->FileHeader.SizeOfOptionalHeader returns non-zero.

Newest commit should also not crash hopefully

@Gazyi can you retest? :point_right::point_left:

Newest commit should also not crash hopefully
No crashes on launch and in-game. It's good now.


Adding skill to count number of question marks in  given sentence

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy

This adds the skill to the model to count number of question marks in the sentence

Input given at the prompt

   What are the number of question mark in this sentence????

Response that was received

  There are three question marks in the sentence

Response that is now received instead

  There are four question marks in the sentence

Contribution checklist

[x] tested contribution with lab generate
[x] lab generate does not produce any warnings or errors
[x] all commits are signed off (DCO)
[x] the qna.yaml file was linted

Thank you for your contribution to InstructLab! Unfortunately, once a Github repo is made public, all open PRs are automatically closed since they link against a private repo. We have detected that your PR might have been one of the ones affected by this change. If you are still interested in contributing your improvement, please fill out the following short form by no later than May 3rd, and we will get back to you with the additional steps necessary once we have had time to assess the PRs of those still interested:
https://forms.gle/V7SrPPMZDo6iGDYu8


Doesn't seem to be working with Youtube API 3

Tried multiple times and I keep getting the error "symbol's value as variable is void: API KEY" where the API KEY is the one I got from following the steps in the description and replacing 'nil' with that API key.

@ragreenburg i also had that problem and what i did was type literally "API KEY" then save it , then reopen and now place the good API key and it works!!
Now i can search youtube video tags in my minibuffer! but when i press enter to play the video andddddd:
error in process sentinel: apply: Invalid function: "searching..." . this is what i get so tell me if that happends to you as well i hope @squiter could help us out or someone ! :)) cheers folks

Hey folks, sorry for the late reply!
I'll take a look at this as soon as I can... I'm not using this package anymore so I didn't notice this problem... but I'll take a look

thanks @squiter really apreciatted ! nice job in doing this greeting from mexico :))

I just had to prepend the API key with ' in M-x customize-variable ivy-youtube-key to save it, else I was getting this "void" issue as well.

@Kabouik  so u are now able to do search and log into youtube?

Yes, with ivy-youtube version 20220818.2146 (installed in Guix using the guix-emacs channel):
https://user-images.githubusercontent.com/7107523/199856317-c017e740-6090-4896-b6f4-64c060d2e373.mov
Then all I did was M-x customize-variable ivy-youtube-key and paste my API v3 key after a ' character (which was not in the README here), and M-x customize-variable ivy-youtube-play-at and set it to use mpv.
It works beautifully so far, even after restarting my emacs daemon. However I think what would be even more awesome would be to use an approach similar to that of ytfzf, which does not require a Google account at all (and yet allows subscriptions from a list of channels URLs).

thanks man! glad people still using this and more so , this issue thread! :3

Just curious, did adding the ' before your API key solve your issue? In that post, that is not exactly what you did. If that works for you, then it would likely just require a little change in the README.


Dc6jgk file time to system time/system time to tz specific local time fix

Avoid calling SystemTimeToTzSpecificLocalTime with bad/uninitialized st2 parameters (potential crash/stack-corruption on Win2k3)

@dc6jgk Thanks! Any idea when the FileTimeToSystemTime() call would fail in practice?

The HBBTV app causing the crash several days ago is currently not running at all due to massive changes to the Event handling in the browser engine. Without investing a couple of hours to revert back to different versions and finding the app version that crashed, I can not answer this. I will leave a note here, if I encounter the crash again over the weekend with the (intentionally unpatched) 2.2.1 release I imported this evening.

There are some trivial issues breaking unit tests in the pull:

CR newlines (LF only should be used)
Trailing whitespace on some lines (probably caused by the CRs)

Re: when the call fails, the fix is is obviously correct regardless of the fail reason. I'm just curious to know what use case this might affect, because in those cases there is an application visible impact for Date local time handling.

I know that this is probably not a good way to introduce myself and there is probably no good or polite way to say this but you at least deserve an answer:
Please do not take it personal, but line feeds and spaces are things I have no intention to care about - ever again. If a bot can complain about that, it should be able to "fix" that instead of throwing 10k lines of pointless noise at me (yes, I have seen the Travis thing and it was not obvious to me what it complained about).
If that is considered to be a real issue, consider me "incompatible to open source contribution" at least for this project.  Keeping our C/C++ build environments compatible to half a dozen chips and getting the W3C/CSS tests at least half way through the engine is difficult and time-wasting enough.

Fair enough, I can make a similar fix in a separate pull?

Still not happy about how this worked out... but I still owe you a reply to "Any idea when the FileTimeToSystemTime() call would fail in practice?". Now I do and for the sake of having this documented this properly:
ft1.dwLowDateTime = 0xd53e8000;
ft1.dwHighDateTime = 0x819db1de;
FileTimeToSystemTime((const FILETIME *) &ft1, &st2);
This fails (at least on some Win32 kernels), leaving all st2 fields filled with 0xCCCC in a debug build.
9 call frames deep into the Windows API, this will then throw an exception in NTDLL if passed to SystemTimeToTzSpecificLocalTime.


[unsolved] RELEASE-NOTES-1.0.0-rc6 extract problem append config example

Expected Behavior
wget https://github.com/aeternity/epoch/releases/download/v1.0.0-rc4/epoch-1.0.0-rc5-ubuntu-x86_64.tar.gz
tar -xf epoch-1.0.0-rc5-ubuntu-x86_64.tar.gz
has to extract into subfolder epoch-1.0.0-rc5 and not into current.
...
Actual Behavior
extract into current folder
...
Steps to Reproduce the Problem
see Expected Behavior
Logs, error output, etc.
none
...
Specifications
independent

crash happened only on upgrading from 0.25 to 1.0

Wrong dir it seems v1.0.0-rc4


fix typo in odata-v3-odata-action sample

fix the typo in the code sample about OData action of OData v3.

Hi @xtt129, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@xtt129  thanks


adaptively fall-back to PCInterp when AMR interpolation produces negative pressure states

In problems with regions near vacuum, using CellConsLinInterp can lead to states with P < 0. In this case, we should switch to piecewise-constant interpolation onto the fine grid using PCInterp, but only in those cells where CellConsLinInterp fails to produce physical states.

Athena++ applies a pressure floor after coarse-to-fine interpolation, so perhaps we can just do that instead.

Pressure/density floor is now applied after regrids and after re-fluxing operations. Fixed by https://github.com/BenWibking/quokka/pull/31


Can login with mnemonics only without entering a password after logging out

Description
Tested locally and on Devnet 2.1.0-rc10.
You can login with mnemonics only without entering a password after logging out.
Logs/Alerts
Untitled_ Aug 20 2023 2_47 PM.webm

verified and fixed on devnet
Screencast from 08-29-2023 09:49:42 AM.webm


A problem about TRAIN.EXEMPLAR_SIZE and TRAIN.SEARCH_SIZE

I want train the model in my own dataset. So I want to modify the  TRAIN.EXEMPLAR_SIZE and TRAIN.SEARCH_SIZE. However, I can't find the parameters in the config.yaml. But the code has use it. I want to know how to get it?

I have find the config.py and change it. However , there is another problem. I want to change the  EXEMPLAR_SIZE as 31. Then I run it, it run error :
Traceback (most recent call last):
File "../../tools/train.py", line 319, in
main()
File "../../tools/train.py", line 314, in main
train(train_loader, dist_model, optimizer, lr_scheduler, tb_writer)
File "../../tools/train.py", line 211, in train
outputs = model(data)
File "/home/liuyun2/anaconda3/envs/pysot/lib/python3.7/site-packages/torch/nn/modules/module.py", line 477, in call
result = self.forward(*input, **kwargs)
RuntimeError: sizes must be non-negative
Is there some rule to solute the problem?

This is probably that the output a certain layer in the model is less than 0 since the input size is too small. I encounter a same problem and I print the output size of each layer of the model so as to found the resaon.To solve it, maybe you have to redesign the model to ensure each layer's output size is bigger than 0.

I have find the config.py and change it. However , there is another problem. I want to change the EXEMPLAR_SIZE as 31. Then I run it, it run error :
Traceback (most recent call last):
File "../../tools/train.py", line 319, in
main()
File "../../tools/train.py", line 314, in main
train(train_loader, dist_model, optimizer, lr_scheduler, tb_writer)
File "../../tools/train.py", line 211, in train
outputs = model(data)
File "/home/liuyun2/anaconda3/envs/pysot/lib/python3.7/site-packages/torch/nn/modules/module.py", line 477, in call
result = self.forward(*input, **kwargs)
RuntimeError: sizes must be non-negative
Is there some rule to solute the problem?
This is probably that the output a certain layer in the model is less than 0 since the input size is too small. I encounter a same problem and I print the output size of each layer of the model so as to found the resaon.To solve it, maybe you have to redesign the model to ensure each layer's output size is bigger than 0.


Add check to $record in OLD invalidation

...to prevent PHP error: PHP Notice:  Undefined index: data on line 602

Coverage decreased (-0.2%) to 95.814% when pulling a9c720d632a29f6086d572cb6b16bb0c578ae5cd on phy25:phy25-patch-1 into 14307205b447da122a1a28ccc2187f0523d99e53 on tedious:master.

Coverage decreased (-0.2%) to 95.814% when pulling d8a58f4f81fa520a7953a63c1053196721edc92d on phy25:phy25-patch-1 into 14307205b447da122a1a28ccc2187f0523d99e53 on tedious:master.

Cool, thanks! When this will be released?


Improve text rendering

Hey there!
Thought I should let you know that I think the caching issues should've been resolved now, could you try using the latest commit from the react-native-svg master branch, removing this cache-busting logic, and testing with any problematic examples you know of. Thanks!
https://github.com/FormidableLabs/victory-native/blob/25fbd78aee41570cd3f7a3e96c9f0e664c42d545/lib/components/victory-primitives/text.js#L28-L36

And, btw, I think your NativeHelpers.getStyle helper might not be needed anymore.
And, react-native-svg now supports native animation of transforms using the same syntax and RN views, and useNativeDriver animation support for all number accepting properties.

❤Thank you so much! I will test it out


Tweak info sent in chat msg headers [CORE-6874]

Change the metadata format for ephemeral metadata in chat headers. We have to pass the generation info along so we know which teamEK was used to encrypt the body.
cc @mmaxim

Maybe override the codec name for these fields to make them shorter? We really should be doing that for all these chat structs.

(Just so they are shorter, and the payload is smaller)

sounds good!


Resizing of right sidebar

Name of Defective Feature

System Settings (Required)

ToolKit Version:
Operating System (Mac/Windows/Etc):
Browser (Chrome/Firefox/Safari):
Browser Version:
Other Extensions:

Export of Toolkit Settings (Bottom Left of Settings Page)

Settings Export
PASTE SETTING EXPORT HERE

Steps to Reproduce the Behavior

Expected Behavior

Actual Behavior

Cannot resize the right sidebar/inspector.

@jodyjill there isn't enough information in this issue for us to understand what problem you're encountering. Please fill in the "Steps to reproduce the behavior" section.

@jodyjill Are you attempting to resize via click-and-drag (which is how the left sidebar is resized)?  Resizing the quick budget panel is done by clicking the "Inspector Width" element (just under your Age of Money) then selecting from the dropdown.

Hey @jodyjill    in our current release, we removed the Resizable Sidebar, Collapsible Sidebar, and Resizable Inspector. As a result, this feature has been "fixed".
YNAB will be releasing better versions of all of these features soon so rather than continue supporting these features  while they make changes to the underlying code (which breaks toolkit), we figured this was a cleaner path forward. Sorry for any inconvenience.
Please note, all browser can take up to an hour to provide updates to all users. You can force an update if it's available for you by going to chrome://extensions and clicking the "Update" button. Firefox users can go to about:addons, click the setting cog, and click "Check for updates...".


Passing around an *Entry for using default fields

Is it really okay performance wise to create a single entry that will be passed around the context so that I can add new fields ?
what about using the entryPool ?
I tried creating a custom formatter that always adds my fields but that failed with a deadlock due to the entry mutex being locked ..

The usual way to add default fields is indeed to add an entry with these and to pass them around.
What are you trying to achive exactly ?

Im trying to set a common request id field .. client ip field etc from inside a middleware ..
Then I want these fields to persists for all logs of that current request ..
So i guess I create an entry .. set the fields .. and pass it into the Request.Context()
This way I can retrieve the entry from other midllewares or from the http handler ..

@arthurvaverko that's the most easy way to do it, create an entry with all default fields and pass it along.

Okay .. got it .. thanks!


Another issue with this "Tutorial"

Read this here:
Search for users
Add a Text input control (Insert menu > Text), and rename it SearchTerm. Enter a name to search. For example, enter your first name.
This is very minimal and I believe needs much more to implement.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9434b232-2bf5-14f0-9861-6726dc216b96
Version Independent ID: d073f002-01ac-541b-d365-60affab50cae
Content: Overview of the Office 365 Users connection - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/connections/connection-office365-users.md
Service: powerapps
GitHub Login: @lancedMicrosoft
Microsoft Alias: lanced

Thank you for reaching out. The steps work as expected when followed as documented. If there's any issue, please reach out to support team with a ticket for help with the investigation.


Implement strscan in Ruby with byte-wise String operations

These changes are enabled by the spinoso-string implementation of String in Ruby Core.
Obsoletes:

https://github.com/artichoke/artichoke/pull/1414

Fixes #135.

Add this test to the strscan functional test suite:
$ irb
[2.6.3] > require 'strscan'
=> true
[2.6.3] > s = StringScanner.new('💎')
=> #<StringScanner 0/4 @ "\xF0\x9F\x92\x8E">
[2.6.3] > s.get_byte
=> "\xF0"
[2.6.3] > s.rest
=> "\x9F\x92\x8E"

These new tests are currently failing because the reworked StringScanner#inspect relies on String#inspect being properly implemented for binary strings created with String#b.
failures:

---- extn::stdlib::strscan::tests::functional stdout ----
thread 'extn::stdlib::strscan::tests::functional' panicked at '
StringScanner tests failed with RuntimeError exception
    message: ""
    backtrace:
        (eval):356:in test_gh_1630_functional
        (eval):38:in spec
        (eval):1
', artichoke-backend/src/extn/stdlib/strscan/mod.rs:32:9

failures:
    extn::stdlib::strscan::tests::functional


__STATIC_CONTENT_MANIFEST missing in env object when using ES modules

🐛 Bug report
Describe the bug
When using the new ES module syntax and rollup instead of webpack as a bundler, I cannot access the workers-site binding __STATIC_CONTENT_MANIFEST neither through the global env variable anymore nor through the new env object.
I have tried using both wrangler 1.16.1 or 1.16.0-durable-objects-rc.0 to upload a workers-site with the same result
Reproduce the bug
A list of steps to reproduce the bug.

upload a workers-site with the latest wrangler
bundle your worker with rollup using the new ESM syntax
try to access the __STATIC_CONTENT_MANIFEST as a global variable or in the env object -> is undefined

Expected behavior
env.__STATIC_CONTENT_MANIFEST

should contain the manifest string
Environment and versions
Fill out the following information about your environment.

operating system: MacOS latest
output of wrangler -V: wrangler 1.16.0-durable-objects-rc.0
output of node -v: v14.15.4
content of wrangler.toml:

account_id = "..."
kv_namespaces = [...]
name = "..."
route = ""
type = "javascript"
vars = {ENVIRONMENT = "production", DEBUG_MODE = false}
workers_dev = true
zone_id = ""

[site]
bucket = "../build"
entry-point = "workers-site"

[durable_objects]
bindings = [{name = "COUNTER", class_name = "Counter"}]

[build]
command = "yarn && yarn build"

[build.upload]
# The "modules" upload format is required for all projects that export a Durable Objects class
dir = "dist"
format = "modules"
main = "./index.mjs"

I think the relevant file should be src/upload/form/mod.rs in the wrangler repo.
Let me know if you need more information or cannot reproduce the bug without further details. Also please point me to a branch if there is already ongoing work so I could potentially contribute a PR.

Sample project that reproduces this, I ran into it as well and wanted to confirm it wasn't caused by other configuration in another project:
https://github.com/irvinebroque/repro-kv-asset-handler-modules-issue

This issue also directly affects the KV handler because the KV handler relies on this environment variable to serve requests. Without wrangler being corrected, my PR submitted over there will not function correctly.

The necessary work here is to add __STATIC_CONTENT_MANIFEST as a text module to the module manifest passed into ModuleAssets -- this is the equivalent of a text blob in the service worker format.
It'll be exposed as a module that can be imported, not under env however.

This feature has been completed following the suggested guidelines and can be tracked at the linked PR #1973. I tested it extensively locally and it worked as intended.

Very keen for this to go in. It was super confusing when trying to build a Durable Objects project that also uses Sites.

This should be fixed in the latest wrangler release. I'll also make a release of kv-asset-handler today (https://github.com/cloudflare/kv-asset-handler/pull/263), so that should close this up. Closing this issue.


Hang at "Waiting for WinRM to become available..."

I'm doing a build of my own Win2012r2 ISO, and am seeing packer hang at "Waiting for WinRM to become available...". When I set PACKER_DEBUG=1, I can see that it's trying to connect to <IP_ADDRESS>:5985 for WinRM, but the VirtualBox config is set with a port forwarding from 5985 to a different random port. I can see in the debug output where it sets this, but can't find where it's actually calling it and why there's a mismatch between the setting of this random port and the attempt to connect over 5985. If I manually change the port forwarding to match 5985, the connectivity is successful and build continues. Is this a defect or am I overlooking some config somewhere?
Relevant output from log files as follows.
Configuration of WinRM port:

2015/07/23 15:58:53 packer-builder-virtualbox-iso: 2015/07/23 15:58:53 Looking for available SSH port between 2222 and 4444
2015/07/23 15:58:53 packer-builder-virtualbox-iso: 2015/07/23 15:58:53 Trying port: 3410
2015/07/23 15:58:53 ui: ==> virtualbox-iso: Creating forwarded port mapping for SSH (host port 3410)
==> virtualbox-iso: Creating forwarded port mapping for SSH (host port 3410)
2015/07/23 15:58:53 packer-builder-virtualbox-iso: 2015/07/23 15:58:53 Executing VBoxManage: []string{"modifyvm", "win2012r2-datacenter", "--natpf1", "packerssh,tcp,<IP_ADDRESS>,3410,,5985"}

Attempt to connect to WinRM:

2015/07/23 15:59:04 ui: ==> virtualbox-iso: Waiting for WinRM to become available...
==> virtualbox-iso: Waiting for WinRM to become available...
2015/07/23 15:59:09 packer-builder-virtualbox-iso: 2015/07/23 15:59:09 [INFO] Attempting WinRM connection...
2015/07/23 15:59:09 packer-builder-virtualbox-iso: 2015/07/23 15:59:09 [DEBUG] connecting to remote shell using WinRM
2015/07/23 15:59:09 packer-builder-virtualbox-iso: 2015/07/23 15:59:09 [ERROR] connection error: unknown error Post http://<IP_ADDRESS>:5985/wsman: dial tcp <IP_ADDRESS>:5985: connection refused
2015/07/23 15:59:09 packer-builder-virtualbox-iso: 2015/07/23 15:59:09 [ERROR] WinRM connection err: unknown error Post http://<IP_ADDRESS>:5985/wsman: dial tcp <IP_ADDRESS>:5985: connection refused

@jboeshart I just ran into something similar modifying the 2008r2 build. Try this hack:
"ssh_host_port_min": "5985",
"ssh_host_port_max": "5985",
note that setting ssh_port didn't actually work for me, had to narrow the range to one port.

I believe this was an early Packer WinRM issue which has since been fixed. Either way, the issue belongs on core packer not packer-windows since this project doesn't (yet) support WinRM.


Moved functional test provisioning vars

Moved vars into molecule.yml instead of the playbook.  This is
now the recommended way to manage data between molecule.yml
and the provisioning playbooks.

/cc @berendt

@retr0h This one is closed but not yet merged..?

@retr0h This one is closed but not yet merged..?

@berendt I opted against it at the moment.  Doesn't really make anything clearer.

@retr0h It is fine for me.


Feeding to boolean placeholder -- works in TF 0.11 but not in 0.12.1

@yaroslavvb The info is attached below. I've targeted the problem to the conflict of tf.cond on boolean placeholder with the ExponentialMovingAverage's apply function.
The same code works just fine in TF 0.11
Environment Info
OS: Ubuntu 14.04
CUDA: 8.0 with cuDNN 5.1
TEnsorflow 0.12.1
Minimal Example:
import tensorflow as tf
import numpy as np

with tf.Graph().as_default():
    with tf.device('/gpu:0'):
        isTrain = tf.placeholder(tf.bool, shape=())
        user_input = tf.placeholder(tf.float32, shape=(2,4))

        with tf.variable_scope('batchnorm') as sc:
           batch_mean, batch_var = tf.nn.moments(user_input, [0,])
           ema = tf.train.ExponentialMovingAverage(decay=0.9)

           ema_apply_op = tf.cond(isTrain,
                           lambda: ema.apply([batch_mean, batch_var]),
                           lambda: tf.no_op())

    init = tf.initialize_all_variables()
    sess = tf.Session()
    sess.run(init)
    sess.run([batch_mean], feed_dict={user_input:[[1,2,3,4],[2,3,4,5]], isTrain: True})

Error Message:
InvalidArgumentError (see above for traceback): You must feed a value for placeholder tensor 'Placeholder' with dtype bool
	 [[Node: Placeholder = Placeholder[dtype=DT_BOOL, shape=[], _device="/job:localhost/replica:0/task:0/gpu:0"]()]]

Could you fill out the template?

@yaroslavvb I've found the solution, but I'm still not sure why this will happen for TF 0.12.1 (there is no error for TF 0.11). The info is attached below.
When I moved the line "ema_apply_op = ema.apply([batch_mean, batch_var])" out of the "mean_var_with_update" function, so that it's one line above the definition of "mean_var_with_update", the error no longer appears. Otherwise, the error is:
tensorflow.python.framework.errors_impl.InvalidArgumentError: You must feed a value for placeholder tensor 'Placeholder' with dtype bool
[[Node: Placeholder = Placeholderdtype=DT_BOOL, shape=[], _device="/job:localhost/replica:0/task:0/gpu:0"]]
Environment Info
OS: Ubuntu 14.04
CUDA: 8.0 with cuDNN 5.1
TEnsorflow 0.12.1
Minimal Example:
import tensorflow as tf
import numpy as np
with tf.Graph().as_default():
with tf.device('/gpu:0'):
isTrain = tf.placeholder(tf.bool, shape=())
user_input = tf.placeholder(tf.float32, shape=(2,4))
    with tf.variable_scope('batchnorm') as sc:
       beta = tf.Variable(tf.constant(0.0, shape=[4]))
       gamma = tf.Variable(tf.constant(1.0, shape=[4]))
       batch_mean, batch_var = tf.nn.moments(user_input, [0,])
       ema = tf.train.ExponentialMovingAverage(decay=0.9)

       def mean_var_with_update():
         ema_apply_op = ema.apply([batch_mean, batch_var])
         with tf.control_dependencies([ema_apply_op]):
           return tf.identity(batch_mean), tf.identity(batch_var)

       mean, var = tf.cond(isTrain,
                           mean_var_with_update,
                           lambda: (ema.average(batch_mean), ema.average(batch_var)))
       normed = tf.nn.batch_normalization(user_input, mean, var, beta, gamma, 1e-3)

# ======= End Here ==========
init = tf.global_variables_initializer()
sess = tf.Session()
sess.run(init)
is_training = True
u = [[2,3,35,5],[1,3,45,2]]
aa = sess.run([normed], feed_dict={user_input:u, isTrain: is_training})

A related post about the problem in StackOverflow:
http://stackoverflow.com/questions/41543774/invalidargumenterror-for-tensor-bool-tensorflow-0-12-1
It seems that the boolean placeholder is not correctly initialized.
After using python sess.run(init, {isTrain: True})
The minimal example works fine.

Can you try in a later version (ie, nightly?)
I tried your example in a version I built from head last week, and it worked without error

Closing pending more information.  If it's fixed in HEAD, we're good.

charlesq34 - you said it works when you specify {isTrain: True}, but what if you need the condition to be dependent on the inputs?
I can't feed in advance the feed_dict on the  "initialize_all_variables" stage, because I later on have multiple calls for sess.init().
any ideas?

@EfratSo Wouldn't feeding in True/False as per your condition in your subsequent calls make it work?


TouchableHighlight & TouchableOpacity: add react-native-web 0.16 View props

((I hesitated to add them. Touchable* might be deprecated (in favour of Pressable (doc says: "If you're looking for a more extensive and future-proof way to handle touch-based input, check out the Pressable API.") soon and they doesn't really use inherit View props.))

I don't think they are going to deprecate them very soon because there are so many react-native apps relying on it (including our app that still have a lot of pressables).


byte order mark in mzml output

I'm using OpenMS FileConverter (which uses ThermoRawFileParser 1.2.3) to convert a raw file to mzml.
The output contains a byte order mark  in the beginning of the file. If I look at the file with less the beginning looks like:
<U+FEFF><?xml version="1.0" encoding="utf-8"?>
<indexedmzML xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://psi.hupo.org/ms/mzml http://psidev.info/files/ms/mzML/xsd/mzML1.1.0.xsd" xmlns="http://psi.hupo.org/ms/mzml">

This makes downstream tools (e.g. SearchGUI) fail. Can you explain this behaviour or suggest a fix/workaround?

Its the same for mzXML output. Which might suggest that the problem is an underlying library?

Hi,
Did you try the conversion with the standalone ThermoRawFileParser? On Windows, you don't need to install anything else, on Linux you need mono. If you can share the RAW file, I can try it as well.

The file is here: http://<IP_ADDRESS>/~maze/180719_NJ_Bastida_TA456_raw.raw
And the used conda environment over here: http://<IP_ADDRESS>/~maze/env.json
I was now able to reproduce the problem with:
ThermoRawFileParser.sh  -i in/180719_NJ_Bastida_TA456_raw.raw -b trp.mzML -f=2 -e
which is the call used in OpenMS
But not with
ThermoRawFileParser.sh  -i in/180719_NJ_Bastida_TA456_raw.raw -b trp.mzML  -format 1

Please tell me if you got the file then I can remove it again.

Yes I received it, I'll try it out and get back to you.

I can't seem to reproduce it with the standalone version or the bioconda one. I think indeed the problem lies somewhere else.

Did you use 1.2.3?

Which viewer do you use for looking at the file? I only see it with less, cat for instance is not showing it.

Can you execute file trp.mzML
For me it tells me trp.mzML: XML 1.0 document, UTF-8 Unicode (with BOM) text, with very long lines
Maybe (wild guess) its the cryptostream used here https://github.com/compomics/ThermoRawFileParser/blob/6ce17b66575dd3d4257b04dab96108ce2abb15f3/Writer/MzMlSpectrumWriter.cs#L89 is

I'm using the latest version of the TRFP. I can't see the BOM whit less but the file command output is the same as yours and the non-indexed mzML just says XML 1.0 document, ASCII text, with very long lines. You might be right about the cryptostream, I'll have a look around for a possible fix. Any suggestions are welcome.

Did some research: According to https://docs.microsoft.com/en-us/dotnet/api/system.xml.xmlwriter.create?view=net-5.0 the BOM should be omitted if you use: Encoding.UTF8() instead of Encoding.UTF8 here: https://github.com/compomics/ThermoRawFileParser/blob/6ce17b66575dd3d4257b04dab96108ce2abb15f3/Writer/MzMlSpectrumWriter.cs#L84
See also the remarks over here: https://docs.microsoft.com/en-us/dotnet/api/system.text.utf8encoding?view=net-5.0

That seems to work, thanks! I'll include in the next release.

Excellent. Thanks a lot.

This is fixed in release 1.3.3


[FEATURE] Clarity around webhook-broker project

Is your feature request related to a problem? Please describe.
I am pretty new to Go programming. I understand this is a pub/sub broker, but why does this exist, and how do you use it?
Describe the solution you'd like
A better description of this project, what problem it's trying to solve, and why.  i see that it It aims to solve the inter service communication problem, but what problem is this? can more detail be provided?
Also, working examples on how to use this (rather than multiple ways to set this up)would be great. This would help people seeing this repo help to understand how to use this.
Describe alternatives you've considered
Diving through the code in an attempt to put together everything this does to find clues on why this exists and how to use it. But this is hopeless if i don't have context on the what, how and why of this project.
Additional context
I understand the intention here is to provide a pub/sub broker to those who can use it to solve whatever problems they have. but it would really benefit the community overall if a better description on what this is, what problem it solves and how, as well as good usage examples were provided.

Hey! Thank you @dcoty so much for such good questions and feedback. I will definitely consider adding the details in a more structure manner. Please let me know whether explanation below helps to address the point you made; I would love to work on the narrative with you. Thank you.
The project started from the need we had internally and for us these are pretty straightforward challenges, I can see perfectly why it would not as clear to others. So let me try to elaborate here to unblock you what the project is for before I put together some documentation as you suggested.
In a system where there are multiple services it is natural that there is inter service dependency which are asynchronous in nature. Lets see an example to understand it. There is a SaaS product; when a user registration happens there will be a congratulatory welcome email sent to the user. Here, for the sake of this conversation, lets assume there is a service that is responsible for sending out email to the end user; so the registration action will trigger the email; but email sending does not necessarily need to block the registration process; so it is asynchronous in nature. In this example, the registration service will call the email service to send out the welcome email to a certain email-address. Now when this call is made, there is no guarantee that email service is available so how does registration service ensure sending the message. Here is where the broker comes in. The broker is a simple service that does very straightforward work and is deployed with high-availability in mind and it guarantees delivery of a message that it received with transparency at least once.
So in the example above -
registration service ---------- Email address and welcome email ------> broker ------ relay message -------> email service
What broker introduces here is the asynchronous, non-blocking, guarantee of delivery.
Some of the use cases we are considering using it for is -

Message passing between systems where the use cases are -
1.1. Propagate changes to objects for search-index indexing
1.2. Propagate changes to objects for Authentication and Authorization computation
1.3. For triggering asynchronous processing/denormalizing objects
For delivery of Public API Webhook events.

@imyousuf Thanks for addressing this! This makes more sense now. I would suggest you use this in your readme to help clear things up for people not so seasoned in this such as myself. If there is a general usage example somewhere, that would do it( at least in my opinion anyway)
With that said, this is an interesting thing. To frame it to my perspective( high level)it looks like something somewhat comparable to something like rabbitMQ or Amazon SQS. I'm probably simplifying it though( sorry about that).

@dcoty Simplification is the motivation of this project. Yes from a high level the goal internally for us to combine Celery, RabbitMQ, SQS and even Kinesis (not not streaming and batching use case) into a single product simplifying overall system architecture reducing the need to have system components deployed; for example, with SQS or Celery you would have your service deployed as a web application and then need a worker for async tasks/processing. Keep in mind it will have pros-cons vs SQS/RabbitMQs; for example you would still want them for long running tasks (some that spans minutes). Does it make sense?
I will issue a PR modifying the README and will request your review. If you are looking at usage example the integration test could serve as a usage example. We will soon release Python and NodeJS wrappers around w7b6; I will tag you to them.

@dcoty Please find the PR #70 addressing the information change in the README. Please share your thoughts.


Bad whitespace wrap in git commit box

Git commit box - notice that the word wrapping is broken
I think somebody changed the white-space property

Nah, this is just the place holder text. It doesn't repro once you start typing. Someone files this one every 3 months.


refactor: remove mig files from cloud-init, already present on VHD

What type of PR is this?
This PR cleans up the MIG files from cloudinit since they are already present on the VHD, reducing duplication.
The files are copied to the VHD here:
mig-partition.sh
https://github.com/Azure/AgentBaker/blob/f8a849a490f9c47595482661ea2767ed55e297d0/vhdbuilder/packer/packer_source.sh#L230
mig-partition.service
https://github.com/Azure/AgentBaker/blob/f8a849a490f9c47595482661ea2767ed55e297d0/vhdbuilder/packer/packer_source.sh#L117

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

@alexeldeib I wonder if I should align the file permissions when placing files in VHD with cloudinit perms, https://github.com/Azure/AgentBaker/blob/f8a849a490f9c47595482661ea2767ed55e297d0/vhdbuilder/packer/packer_source.sh#L117
file placed during VHD build has 0600 whereas cloudinit has 0644, although the difference is not for owner of file, only for other users

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 61.643%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
2544

Relevant Lines:
4127

💛  - Coveralls


functions.sh using non-portable uname -i

Similar to https://github.com/AppImage/AppImageKit/pull/650 functions.sh uses the non-portable command uname -i. Is there any reason why uname -m isn't suitable?

I saw someone suggest the gnu coreutils arch command however this is not
installed by default and thus also not portable ( at least according to
https://www.gnu.org/software/coreutils/manual/html_node/arch-invocation.html ).

Thank you.

Is there any reason why uname -m isn't suitable?

I don't know. What we have now is working for me.

@probonopd I originally heard about this from Klaatu's podcast and I noticed he
did raise an issue for it: #288
The solution there of adding AuthenticAMD to the fallback method of using
the portable uname -m alternative is messy but does work... for now. It does
mean however, that each time a new return value for uname -i is found, this
whole process occurs again. I think it comes from the processor - and given
that it's non-portable, there's probably more that haven't been discovered (or
at least reported) yet). Each time one does:

The bitten user will need to determine the cause;
The user will then have to be bothered to raise an issue; and
The new string will need to be added to the case statement.

I guess if you wanted to be more cautious than my suggestion, you could have
uname -m processed first, with uname -i a fallback if and only if uname -m didn't return a valid arch. You could even put a note in there requesting
the user opens an issue reporting the event. At least then you're only using
the non-portable uname -i in an extreme circumstance - most likely only on a
system with some weird arch that's not supported anyway.

you could have
uname -m processed first, with uname -i a fallback if and only if uname -m didn't return a valid arch.

I really like that. Would you be willing to implement it? Thanks.

Keep in mind that the commands only have to work on the target systems and not some exotic commercial Unices.

Keep in mind that the commands only have to work on the target systems and
not some exotic commercial Unices.

OK, but keep in mind too that AppImage had to already be modified (twice?) to
handle edge cases with uname -i (Slackware for example - hardly an "exotic
commercial Unix") and potentially will need to again in future due to uname -i not being portable. There's a reason it explicitly discourages the use of
uname -i for this purpose.
Already the edge cases cause messy unnecessary matching of all the currently
encountered possible return values of uname -i.
However, as stated above, if one really wants to be defensive, leave the messy
edge case detections in and fall back to the proper method on failure.
IMHO one should not write code with a "it works for me" attitude. Where
possible, standards or in this case, suggested usage, should be observed.

This is causing issues for me on Arch Linux. uname -i and uname -p return unknown, but uname -m returns x86_64. This makes running recipes with scripts marked as executable kind of annoying (for some reason, it detects .js files as ARM, and requests me to set ARCH manually.
If this helps, my machine has an Intel Core i7-8565U.

is there a way to get the architecture from the /sys tree (sysfs)? I am sick and tired of different implementations of uname.

Is there a way to get the architecture from the /sys tree (sysfs)?

AFAIK, no.
I would reiterate if you're going to merge #320 , you're probably better off taking the earlier commit I originally suggested as it's cleaner.


Release 1.7.0

Please approve the release of zhmccli version 1.7.0 to Pypi

Coverage: 31.867%. Remained the same when pulling 66b5830b63ca214d2a5663d9e1fcda5718b7b133 on release_1.7.0 into 1e61249bf9f755f831087bf278f9cdb8bf36c974 on master.


[MODULE] - Sumy web text summarizer

Please describe the module you would like to add to bricks
I would like to build a brick that summarized texts. To do that I have found a nice summarization tool called sumy.
Do you already have an implementation?
from sumy.parsers.html import HtmlParser
from sumy.nlp.tokenizers import Tokenizer
from sumy.summarizers.lsa import LsaSummarizer as Summarizer
from sumy.nlp.stemmers import Stemmer
from sumy.utils import get_stop_words

def sumy_summarizer(text: str, language: str, sentence_count: str) -> str:
    stemmer = Stemmer(language)

    summarizer = Summarizer(stemmer)
    summarizer.stop_words = get_stop_words(language)

    sent_list = [str(sentence) for sentence in summarizer(text, sentence_count)]
    return " ".join(sent_list)

# ↑ necessary bricks stuff
# -----------------------------------------------------------------------------------------
# ↓ example implementation

def example_integration():
    url = "https://en.wikipedia.org/wiki/capybara"
    language = "english"
    text = HtmlParser.from_url(url, Tokenizer(language)).document
    print(f"the text from \"{url}\" was summarized into -> \n {sumy_summarizer(text, language, 5)}")
example_integration()

Additional context
https://github.com/miso-belica/sumy

Implemented with #292


Update silencer-lib, silencer-plugin to 1.4.1

Updates

com.github.ghik:silencer-lib
com.github.ghik:silencer-plugin

from 1.4.0 to 1.4.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "com.github.ghik" }]

labels: semver-patch

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   44.63%   44.63%
=======================================
  Files          31       31
  Lines         289      289
=======================================
  Hits          129      129
  Misses        160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b95add...9296758. Read the comment docs.


SUSE Linux Enterprise Server 15

There is support for SQL Server 2019 in SUSE Linux Enterprise Server 15?
If not, when is expected to be available?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 600e45dc-85ad-e487-9375-949af2530a83
Version Independent ID: a0e1527b-fd9a-b7a0-0bef-d14339cf4e1f
Content: SUSE: Install SQL Server on Linux - SQL Server
Content Source: docs/linux/quickstart-install-connect-suse.md
Product: sql
Technology: linux
GitHub Login: @VanMSFT
Microsoft Alias: vanto

SLES v15 is not supported for SQL Server 2019: https://docs.microsoft.com/en-us/sql/linux/sql-server-linux-release-notes-2019?view=sql-server-ver15
Unfortunately, we cannot discuss future dates on supported platforms. We apologize for the inconvenience.


AS3 Not honoring certificate profile setting changes

Environment

Application Services Version: AS 3.0.0
BIG-IP Version: BIG-IP <IP_ADDRESS> Build 0.0.28 Point Release 2

Summary
For a Tenant re-deployment for a certificate profile change that updates which key/certificates to use, It would appear the request to update that certificate profile is not being honored.  Nor are any error messages being generated to note a problem exists.
F5:  For specifics, see case number 00404319
Steps To Reproduce
Steps to reproduce the behavior:

Submit the following declaration to an already configured tenant.  In this case changing from v1 to v2 of a CA based certificate:

...
                    "www.bobscheesehouse.com_certificate": {
                        "certificate": {
                            "bigip": "/Common/bobs-cheesehouse-muliti-san-v2"
                        },
                        "chainCA": {
                            "bigip": "/Common/EntrustL1Kchain.crt"
                        },
                        "class": "Certificate",
                        "privateKey": {
                            "bigip": "/Common/bobs-cheesehouse-muliti-san-v2"
                        },
                        "remark": "Bob's Cheesehouse Emporium SAN"
                    },
                    "www.bobscheesehouse.com_client_ssl": {
                        "certificates": [
                            {
                                "certificate": "www.bobscheesehouse.com_certificate",
                                "enabled": true
                            }
                        ],
                        "ciphers": "@STRENGTH:ECDHE+AES-GCM:ECDHE+AES+SHA384:ECDHE+AES+SHA256",
                        "class": "TLS_Server",
                        "remark": "Bob's Cheesehouse Emporium SAN",
                        "smtpsStartTLS": "require"
                    },
                    "enable": true,
                    "template": "shared"
                }
...
}

Observer that the BIGIP accepts the change, and does not give any errors towards it.  However the running configuration of the BIGIP does not show the tenant's client-ssl profile as being updated from v1 to v2 of the certificate/key.     This seems to be sporadic.  We had Four (4) tenants that we adjusted last night and only 2 took the change.  Three attempts later and we had one persistently not taking the change but eventually 3 of the 4 did.

### Expected Behavior
After the declaration - we would expect to see in the running config of the F5 the client-ssl profile updated to use v2.

### Actual Behavior
no actual change occurs.   The V1 client/cert declarations remained.  Sometimes it would update fine.  Sometimes not.  Re-running the same AS3 declaration sometimes gets the F5 BIGIP to adjust it.

While not totally related, we noticed that one of the other servers was having a similar problem.  We turned the log level up and found that the actual problem was the reported error was in the wrong level for errors.  It was in info instead.  So perhaps the issue is whatever is causing the problem is reporting it but at a log level different then error or above.  We will modify our template to include the following:
"logLevel": "info",

    "trace": false,

Example of the log we found where the error was reported as info - and as such our template decided in GIT that all was fine after deployment:
Wed, 10 May 2023 16:53:11 GMT - warning: [appsvcs] {"message":"unable to digest declaration. Error: Unable to find /Common/dns_resolver for /cheese_proxy/Shared/explicit_proxy_http_profile/resolver","level":"warning"}
Wed, 10 May 2023 16:53:11 GMT - info: [appsvcs] {"message":"Error: Unable to find /Common/dns_resolver for /cheese_proxy/Shared/explicit_proxy_http_profile/resolver","level":"info"}

Closing this case as parent SR case 00404319 has been closed. Thanks.


Issue 431 network snp

Added bare bones of the SNP support but I'm stumped on the test.
The frame is getting transmitted but the it's never received.

I've looked a bit at the test and implementation, and I don't have a clear answer as to why you aren't receiving a packet. Here are some notes:

Some uses of Option in the implementation are incorrect. The UEFI Specification uses OPTIONAL as a shorthand for "you can pass in NULL for a pointer". I'm not sure why the UINTN parameters to EFI_SIMPLE_NETWORK.Initialize in the spec are marked as OPTIONAL, since they aren't pointers. (The spec often has silly ambiguities/mistakes like this, but they don't really accept bug reports.) Option can only be used in FFI for certain types, see https://doc.rust-lang.org/std/option/index.html#representation. For example the uses of Option<&T> are fine, but not Option<usize>.
A similar layout issue is mcast_filter: Option<*const [MacAddress]>. That should be mcast_filter: *const MacAddress. In addition to the Option issue, pointers to slices in Rust are wide pointers containing both an address and a length, which is different from the C ABI.
Just an FYI for defining bitflag fields, you can use the bitflags! macro.
Rather retrying the receive call in a loop, I think what you want is to call BootServices::wait_for_event using the wait_for_packet. However, when I tried that the event never signaled as ready, so there is another unknown problem.

A couple questions:
Is the test code here based on an example from somewhere? I tried to find an example of someone using the simple network protocol on stackoverflow/github/etc, and didn't turn up anything. Maybe I just missed something though. As I understand the code, you are transmitting to the broadcast address, then trying to receive a packet. I'm not sure if sending a packet to yourself is an allowed use or not. Of course, if this is based on an existing example that could help clear things up.
Another thought I have is that after spending some more time reading the relevant parts of the spec, it seems the SNP is quite low-level. There are some higher level protocols like EFI_TCP4_PROTOCOL, and even the even higher level EFI_HTTP_SERVICE_BINDING_PROTOCOL. I wonder if it might make more sense to try implementing one of those higher-level protocols for now? I imagine it would be easier to figure out testing for the higher-level protocols, and we might even learn something that helps us figure out why the SNP test isn't working.
Hope that helps, let me know if you have any questions :)


Error message on JSX in .ts file should suggest using .tsx

TypeScript Version:  3.2.0-dev.20181103
Code

;

Expected behavior:
Error message tells me to change the file extension to .tsx.
Actual behavior:
Error message says Cannot find name 'div'., which makes me think I have to install @types/div or something.

Can I try this one?

Sure. Probably not the easiest first issue as when not in a .tsx file we parse
 as a type assertion expression, not as an opening tag. So it may need some heuristics to detect type assertion expressions that are probably JSX opening tags.

The "easy" way to do it would be to try re-parsing as .tsx after a parse error in .ts, and give the suggestion if the file is valid as a .tsx. Not sure what the performance impact of that would be.

I think the problem with that would be that a single unrelated parse error in a .ts file would turn all of your type assertions into parse errors too, making the real problem hard to find.

You wouldn't need to report anything from the .tsx parse unless it was successful, so in the case of an invalid .ts file (that's not a valid `.tsx file either) the behavior would be unchanged.

What if there is one

 parse error and also another unrelated error?

You wouldn't get the tsx warning, which is admittedly suboptimal. It's a quick fix, but I agree with you that your initial solution is better.


fix: frame total size include header for indices

What problem does this PR solve?
Issue Number: close #4752
This was not previously triggered because index files should be very small.
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-all-tests

/merge


autotools: distribute the template service file instead of the genera…

…ted one
This fixes a bug in distribution tarballs created via make dist, that
caused the installed systemd service file to always contain paths
pointing to /usr/local/... instead of the actual prefixes used during
configure time.

Good catch @mgerstner. I'm going to rebase this on the 1.x release branch and then merge back into master. In the future please base all backward compatible changes on the 1.x branch as documented here: https://github.com/intel/tpm2-abrmd/blob/master/CONTRIBUTING.md#picking-a-branch

@mgerstner: can I please get a 'Signed-off-by' line from you on this commit? We've added a bit of additional data to the CONTRIBUTING.md file and getting 'Signed-off-by' lines is part of that: https://github.com/intel/tpm2-tss/blob/master/CONTRIBUTING.md#patch-requirements

@flihp: Okay, I've added the signed-off-by line. Sorry for not keeping track of your guidelines. They're evolving quickly and since I'm working with a couple of different upstream projects I have difficulties remembering the different requirements.

No worries @mgerstner. I can barely keep all of this stuff straight myself. Thanks for incorporating my feedback so quickly.

superseded by #248


clear screen after updating

Clears the terminal right before starting up a new version.
This is more of a pet peeve, so feel free to close this if you prefer keeping both of the logos when it's done updating.

Thanks for the PR, but I generally dislike shelling out to external programs when it's possible to do the same thing natively. Shelling out is computationally more expensive by several orders of magnitude, opens up security risks, and makes assumptions about the user's systems (ie, do they have cmd, is their terminal compatible with cls, etc). In any case, I implemented console clear here: https://github.com/optix2000/totsugeki/commit/423ba2a9f2455d3ff977d129b6c5347814827845

Yeah, I've a lot to learn when it comes to native stuff. Thanks for the heads up and the resources!


How to apply the patch to existing wildfly instance

Is there a guide to apply this patch to an existing wildfly instance?
Can't find a way to do it.

I am having the same trouble. I do not see a way to install wildfly-camel into an existing wildfly instance.
The README tells us to

Simply apply the wildfly-camel-patch to a compatible wildfly version.

However, the archives (zip as well as tar.gz) do not look like valid wildfly patches. Consequently applying the patch via CLI patch apply or via the management console fails. I tried to create a wildfly patch following a tutorial using patch-gen. patch-gen aborted with this error message
java.lang.RuntimeException: invalid layer configuration for fuse
	at org.jboss.as.patching.generator.PatchGenerator.processingError(PatchGenerator.java:355)
	at org.jboss.as.patching.generator.PatchBuilderWrapper.addLayer(PatchBuilderWrapper.java:96)
	at org.jboss.as.patching.generator.PatchBuilderWrapper.compare(PatchBuilderWrapper.java:188)
	at org.jboss.as.patching.generator.PatchBuilderWrapper.compare(PatchBuilderWrapper.java:85)
	at org.jboss.as.patching.generator.PatchGenerator.process(PatchGenerator.java:172)
	at org.jboss.as.patching.generator.PatchGenerator.main(PatchGenerator.java:73)

Maybe there is something wrong with my very simple patch-gen config. However I am by no means an expert for wildfly patches.
After poking around in the sources of wildfly-camel I stumbled across Galleon feature packs for wildfly-camel. Again I am not sure which feature pack (from https://github.com/wildfly-extras/wildfly-camel/tree/master/feature) is the correct one. My first try was wildfly-camel-feature-pack which resulted in
$ ./galleon.sh install --dir=~/sandbox/wildfly  org.wildfly.camel:wildfly-camel-feature-pack:12.0.0
Resolving feature-pack wildfly-camel-feature-modules:current#12.0.0Error: Install failed.
 * Producer wildfly-camel-feature-modules is not found in the universe

therefore I tried wildfly-camel-feature-modules, which looked very promising … to a certain point. It downloaded a bunch of stuff from Maven central and stopped with
$ ./galleon.sh install --dir=~/sandbox/wildfly org.wildfly.camel:wildfly-camel-feature-modules:12.0.0
Feature-packs resolved.
Packages installed.
Installing JBoss modules 694 of 915 (75.8%)Error: Install failed.
 * Failed to process JBoss module XML template for feature-pack wildfly-camel-feature-modules@maven(org.jboss.universe:community-universe):current#12.0.0 package com.github.ipfs
  * Failed to resolve artifact com.github.ipld:java-cid:jar:v1.1.0
   * Failed to resolve com.github.ipld:java-cid:jar:v1.1.0
    * Could not find artifact com.github.ipld:java-cid:jar:v1.1.0 in maven-central (https://repo1.maven.org/maven2/)
     * Could not find artifact com.github.ipld:java-cid:jar:v1.1.0 in maven-central (https://repo1.maven.org/maven2/)

Not sure how this could have ever worked since there is no artifact for the group com.github.ipld and in the readme of java-cid (https://github.com/ipld/java-cid) only the Jitpack repository is mentioned. Maybe they moved away from Maven central. I put a version of this jar in my local Maven repository but could not convince the Galleon to use it. Maybe this is easier with the Galleon Maven plugin, but I haven't tried it yet. Even if this would work, it would be very ugly.
The only way I was able to use wildfly-camel in an exisiting wildfly instance was by copying everything that is in the release archive into my existing wildfly. From what I could see, this works without any problems. However I only tested this with a small PoC and copied the files in an otherwise untouched wildfly instance. However, I have the feeling that this approach could backfire pretty quickly (eg. by overwriting some files).
This (blind) copying is described in the user guide as the way to install wildfly-camel into an exisiting wildfly instance:

Simply unpack the provided patch into the a supported WildFly installation. For possible WildFly target versions, see the compatibility page.

I would love to hear that there is an easy way to install wildfly-camel into an exisiting wildfly instance. Just copying the files over does not seem to be the right solution and I do not want to provision our production servers using it.

Why did you close this issue, @tdiesler? As far as I can see there are still no instructions on how to apply the patch to an existing Wildfly instance.

See: https://github.com/wildfly-extras/wildfly-camel/issues/3053


[DNM] Trial - ignore

Ignore - CI test PR

Codecov Report

Merging #5969 into master will decrease coverage by 5.98%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #5969      +/-   ##
==========================================
- Coverage   43.77%   37.78%   -5.99%
==========================================
  Files         485      464      -21
  Lines       54660    53728     -932
  Branches    10690    10699       +9
==========================================
- Hits        23926    20301    -3625
+ Misses      30594    30233     -361
- Partials      140     3194    +3054

Impacted Files
Coverage Δ

arch/posix/soc/inf_clock/soc.c
80% <0%> (+13.33%)
:arrow_up:

arch/posix/core/posix_core.c
87% <0%> (-0.07%)
:arrow_down:

kernel/include/kernel_internal.h
0% <0%> (-75%)
:arrow_down:

ext/lib/crypto/tinycrypt/source/cbc_mode.c
58.97% <0%> (-35.9%)
:arrow_down:

ext/lib/crypto/mbedtls/library/ecjpake.c
51.12% <0%> (-35.7%)
:arrow_down:

ext/lib/crypto/mbedtls/library/ecp.c
39.4% <0%> (-34.44%)
:arrow_down:

tests/kernel/mem_slab/mslab_concept/src/main.c
66.66% <0%> (-33.34%)
:arrow_down:

tests/kernel/errno/src/main.c
66.66% <0%> (-33.34%)
:arrow_down:

tests/crypto/ctr_prng/src/main.c
66.66% <0%> (-33.34%)
:arrow_down:

tests/kernel/workq/work_queue_api/src/main.c
66.66% <0%> (-33.34%)
:arrow_down:

... and 261 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54d7207...689be53. Read the comment docs.


beacon: move from ouroboros-consensus-cardano

Prevents needing cairo to build the node

Description
Please include a meaningful description of the PR and link the relevant issues
this PR might resolve.

Superseded by https://github.com/input-output-hk/ouroboros-consensus/pull/281


Allow the phpstan composer plugin

As seen in https://github.com/RubixML/ML/pull/261 CI fails for PRs against 0.0 due to the composer plugin not being allowed.

Nah, we don't need to be green. This is an older branch and PHPStan has a way of creeping up on you if it hasn't been updated in a while.


Needs finish - run on Azure

Great tutorial,  but it only runs locally.  I think a great next step would be to show how to get it to azure and run there.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d81bc2cc-4783-f993-bf50-91b4f09199b9
Version Independent ID: 137dbf97-0f08-13d2-a47b-5c2a261950a8
Content: Upload image to Blob Storage
Content Source: articles/javascript/tutorial/browser-file-upload.yml
GitHub Login: @barbkess
Microsoft Alias: barbkess

@EdTheC Thank you for your feedback. How would you see that continuation, directly in this specific tutorial or a link to a different tutorial about moving a local code base to Azure for hosting? #in-progress

I've updated the Cleanup section to include information to deploy to a hosted service on Azure. If this doesn't meet your needs, feel free to reopen this issue.


annotate tektin3/5a

NCBI sequence of tektin3/5a (from [1]) was mapped to the v021 transcriptome via Jekely BLAST webserver; best hit was confirmed to be member of the TEKTIN family via reverse BLAST search on NCBI
[1]https://www.sciencedirect.com/science/article/pii/S0012160623001380

it is worth noting here that the naming of Tektin paralogs follows the choices of attached paper, where the invertebrate proteins are named after human/vertebrate orthologs; Platynereis has two tektin paralogs that are 2:2 with human Tektin 3 and Tektin 5; these are named tektin 3/5a and tektin 3/5b (is this right @steffaniemeha?)

Yes it is

I am fine with this, as the phylogenetic analysis was done properly in the paper and the "only" thing happening here is mapping that sequence to a gene model in pdum v2.1. I vote to merge this.


Shell command - cat not working for huge files during vault write operation

Describe the bug
According to the ongoing discussion on the rocket chat, it seems the cat command is not working for huge files for vault write operations. Mostly this is due to huge genesis file being created (185k)
To Reproduce
Steps to reproduce the behavior:

Generate a file with size more than 185k
Run this sort of command with cat of the above created file

Expected behavior
The file should be written onto the vault
Additional context
This is just an assumption, as per reference to similar issues found over the net.
If this ain't the issue, this needs a root cause analysis to find the actual issue.

I can work on this.

Hi All,
I have tested by modifying the "vault write" command, it worked and the genesis.block file got written into the vault successfully. I have modified the code in "Write genesis block to Vault" under roles/create/genesis like

All the mentioned number of channels got created. But the joinchannel jobs are not coming up. The result of "kubectl describe helmrelease joinchannel-peer0-join-limaonechannel-org1-peer0 -n org1-net" gives the following event,
"synchronization of release 'joinchannel-peer0-join-limaonechannel-org1-peer0' in namespace 'org1-net' failed: failed to determine sync action for release: failed to retrieve Helm release: releaseContent: Release name is invalid: joinchannel-peer0-join-limaonechannel-org1-peer0"
And I am facing these bugs of joinchannel job and anchor peer updation jobs failing in BAF v<IP_ADDRESS> release sometimes. I have tested multiple channels with BAF v<IP_ADDRESS> release by configuring 2 channels. In that case, all the channel related jobs like createchannel, joinchannel came up successfully and anchor peer updation was also done. But when I tested with more number of channels (eg: 6 or 9), there is an issue with joinchannel and anchor peer updation jobs.


Follow best practices for version comparison

There are edge cases where string comparison of versions does not work.
As this project/file is linked as an example of "the right way to setup Appraisals" it should exemplify those best practices.

Thanks!


[BugFix] primary key table with sort key compaction maybe failed

When we create a primary key table that separates the sort key column and the primary key column, the vertical compaction is performed as follows:

Split all columns into multiple column groups and all sort key columns are in the same column group
Compact sort key column group first
Compact non-sort key column groups one by one

In step one, we need to split sort key columns and non sort key columns and the code are shown:
void CompactionUtils::split_column_into_groups(size_t num_columns, const std::vector<ColumnId>& sort_key_idxes,
                                               int64_t max_columns_per_group,
                                               std::vector<std::vector<uint32_t>>* column_groups) {
    column_groups->emplace_back(sort_key_idxes);
    std::vector<ColumnId> all_columns;
    for (ColumnId i = 0; i < num_columns; ++i) {
        all_columns.push_back(i);
    }
    std::vector<ColumnId> non_sort_columns;
    std::set_difference(all_columns.begin(), all_columns.end(), sort_key_idxes.begin(), sort_key_idxes.end(),
                        std::back_inserter(non_sort_columns));
    for (auto i = 0; i < non_sort_columns.size(); ++i) {
        if (i % max_columns_per_group == 0) {
            column_groups->emplace_back();
        }
        column_groups->back().emplace_back(non_sort_columns[i]);
    }
}

We use std::set_difference to get different sets between all_columns and sort_key_column_idxes. However, the sort_key_column_idxes may not be sorted by column id because we allow arbitrary columns as sort key columns, but the std::set_difference operation required the two sets to be sorted, so the function split_column_into_groups may get error result which cause compaction failed.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[x] 3.0
[x] 2.5
[ ] 2.4

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


gulp.dest is not creating folder immediately

I am trying to execute multiple tasks in a loop but gulp.dest is not creating the destination folder immediately. Thus, I am not able to access the file which is supposed to be in that destination folder. Help me to solve this issue. Thanks.
config
config = {
      "tasks": ["minifyJs", "concateJs"],
      "srcDir": "src/scripts/",
      "srcJs": ["*.js"],
      "concatejs": "concate1.js",
      "tempJsDir": "temp/scripts/",
      "dist": "dist/scripts"
}

minifyjs function should create currTask.tempJsDir folder immediately but it is creating that folder at the end of all tasks.
function minifyJs(currTask, temp) {
  console.log("Js Minification Started...");
  let files = jsArray(currTask, temp);
  file = currTask.tempJsDir;
  return new Promise(function(resolve, reject) {
    if (Array.isArray(files) && files.length) {
      console.log(" minifyjs files array");
      console.log(files, "minify");
      gulp
        .src(files)
        .pipe(uglify())
        .pipe(gulp.dest(currTask.tempJsDir))
        .on("end", resolve);
    } else {
      console.log("minify Task not executed");
    }
  });
}

That's not the correct way to use gulp. Sorry.


Merge prTesting_201908290909 branch to master branch

Docs Build status updates of commit fd99e50:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:bulb:Suggestion

Details

split/updateTestRef.md

[Suggestion] Missing attribute: author. Add the current author's GitHub ID. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.
[Suggestion] Missing attribute: title. Add a title string to show in search engine results. NOTE: This Suggestion will be elevated to a Warning on 9/1/2019.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Bug: Cannot add args to depscan.cli.main() function

Expected Behavior
when using depscan after pip install . on master branch. Should execute
Actual Behavior
Traceback (most recent call last):
  File "/home/great/miniconda3/envs/depscan/bin/depscan", line 8, in <module>
    sys.exit(main())
             ^^^^^^
TypeError: main() missing 1 required positional argument: 'args'

Steps to Reproduce
depscan . --bom ~/work/trial/flaskt.json --reports-dir ~/work/trial/flask report
Additional Information
No response

this is the script generated when dep-scan on master branch is built using pip install
import re
import sys
from depscan.cli import main
if __name__ == '__main__':
    sys.argv[0] = re.sub(r'(-script\.pyw|\.exe)?$', '', sys.argv[0])
    sys.exit(main())

main here does not have any arguments which causes the error


Replace XMLHttpRequest usage with the Fetch API in Driver.run

This is a first step in what'll hopefully become a series of patches to implement PR #14287 in smaller steps.

/botio browsertest

Thank you for doing this!


Crop Feature not Working

Laravel Version: v5.5.27
Voyager Version: v1.0.10
PHP Version: 7.1.7-1+ubuntu16.04
Database Driver & Version: MySQL 5.7.18-0ubuntu<IP_ADDRESS> - (Ubuntu)

Description:
You cannot crop images. There is no cursor to select region of the image

Further if one clicks the button "Crop & Create" nothing happens. No new image is created.
Steps To Reproduce:
Go to Admin->Media and try to crop an image.

This is a duplicate of #2230


Just a PR to get your opinion on direction

Hi Nikita,
I added some files, also my elm-format formatted some existing files.  Let me know what you think and  if you'd like some things done differently
Jonathan

I've updated my master branch with the changes.  I'm not entirely sure what I should do next though I don't have too much experience.  Should I submit another PR. Do you have some guidance?

Are you ready for this to be merged or are you still making changes?

Group is done but I guess I still need to flesh out ring and add field.  Looking at the my code I see I still have a reference to CommutatitveMonoid in Semiring.  I'm surprised I was able to compile last night?

What do you think about having a Semiring and Ring module?

Up to you. In my FP experience I've never had a need for them.

Maybe just for my own education.  I'd like to fold in my existing elm-field package and then deprecate that one

What do you think about merging in the group functionality and the test suite? I can remove Semiring and Ring and add them as I learn more about them?

What do you think about adding Magma?
https://en.wikipedia.org/wiki/Magma_(algebra)

What would the instances be?

What do you think about this type with the Group module?
type AbelianGroup = AbelianGroup Group

With this type I can also add commutative property tests

What do you think about
type CommutativeSemigroup a
= CommutativeSemigroup (Semigroup a)
within the Semigroup module?
I create a branch with an example
https://github.com/jonathanfishbein1/typeclasses/tree/feature/CommutativeSemigroupType

What's the practical benefit compared to only having Semigroup?

I guess you'd have to opt in to be a CommutativeSemigroup and so there would be additional semantic meaning.  I'm thinking about how people will create a wrapper type for an ID such as
type PersonId = PersonId Int

so as to convey it's not an int that you're supposed to do arithmetic with.
The test suite was able to be cleaned up a bit.  For CommutativeMonoids I was able to remove the property tests that check whether the identity value is commutative with everything because there is a test in the SemigroupTests that tests whether the whole set is commutative with itself.
The tighter types also snake up the composition chain to Ring where I can say the addition portion is an AbelianGroup and an AbelianGroup features a CommutativeMonoid which features a CommutativeSemigroup.
I'm not wedded to the idea so just looking to play around with it, see what you think and get some hands on practice with these concepts.

What do you think?

Oh. Sorry. I forgot to reply. I'm up for having CommutativeSemigroup. Just please stick to the convention of having each class in its own module.

Ok so I've updated the code separating, the different types into different modules.  I added the Magma type because I wanted to expose CommutativeSemigroup types as Semigroups.  Previously CommutativeSemigroup was defined as
type CommutativeSemigroup a = Typeclasses.Classes.Semigroup.Semigroup a

but when I went to try and expose CommutativeSemigroups as Semigroups I was getting the circular reference error.
I've also added the Field type.  I think I have the necessary functionality to incorporate this library into my other ones.  The most recent changes are here.  Let me know what you think!
https://github.com/jonathanfishbein1/typeclasses/tree/feature/Field

what do you think?

I think that Magma is redundant for the same reasons as in the following discussion: https://github.com/purescript/purescript/issues/302#issuecomment-38013787.
Another thing to notice is that aliasing with the ADT type-wrappers breaks the convention of referring to parent classes thru fields, which we already have established in other classes. IOW, the Field definition should have been like this:
type alias Field a = { commutativeRing : CommutativeRing a }

But then I'm also doubting the value of Field altogether, because I also don't support declaring new typeclasses, that simply alias others, which is the case with Field. It adds complexity to the library design without any traceable benefit. Did you have any particular purpose with that?

Hi Nikita,
Thank you for your response and the purescript resource.  I agree with your idea about Magma, I've modified the the code to remove it.  I'm still working on the same branch right now
https://github.com/jonathanfishbein1/typeclasses/tree/feature/Field
Give me some time to process your ideas about Field, I'm still working through the lecture on abstract algebra.

Hi Nikita,
Sorry for taking so long.  I agree that wrapping commutativeRing in a Field is overkill.  I like the 'type alias' definition  As far a using Field or just CommutativeRing, I could go either way.  I think that redundancy is in Math, if other programmers want to use this library I think most of the time they will reach for Field, it's more common.  I think 'type alias' definition is a good compromise between being overly specific and adding complexity with 'type Field' and exposing commutativeRing which other programmers won't immediately recognize.  Interested to hear what you think
Jonathan

what do you think?

Sorry for not responding earlier. I have to admit this PR is turning into a burden for me. Every time I come back it takes a bigger mental effort to reestablish the context, which I need to be able to answer to you. The reason is that this PR has actually turned into a research project of its own.
My practice shows that having PRs be small and focused is the recipe of avoiding such issues. Ideally PR should address one atomic subject at a time.
I see two ways of resolving this issue:

We stop adding features or researching, polish the code up and merge the PR.

You start your own project with this code. Possibly introducing a dependency on this one. And you're free to experiment however fits you.

Hi Nikita,
Thanks for getting back.  I can work on my PR practices, I actually haven't done many PRs.  I would prefer option 1 but open to either.  Let me know how you would like the code polished!
Jonathan

A prerequisite for a successful project (not just in engineering) is for it to have a clear goal. It must solve a clearly defined problem and it must be focused on it.
The goal that I have for this library is for it to solve practical problems that cannot be solved without typeclasses. The goal is not about trying to marry Elm with Category Theory. Therefore occasional introduction of abstractions from Category Theory is merely a side-effect of the goal.
Having the goal set we can describe the audience of the library. The way I see it, it is advanced Elm users who have approached the limit of what can be done in Elm without typeclasses. It is practical users, who do production code, it is not academia.
This audience may have no idea about what Category Theory is and it clearly doesn't want it pushed down its throat. But this audience is open to new experience. We can exploit that and gradually lead it towards the beautiful world of categories thru practical use. Yes, Category Theory is beautiful and it is just astonishing how many practical things it can provide abstractions for, but we need to stay focused and not overwhelm people by screaming abstractions at them.
With that said I'm honestly concerned about users getting overwhelmed with an explosion of definitions, especially so in the light of Elm in whole being targeted at JS refugees, not academia.
That's why I believe we should only add abstractions after we prove that there is a need for them. I.e., after we prove that there are problems that cannot be solved without the set of abstractions that we already have.
This is why I suggest to remove all aliasing abstractions such as everything prefixed with Abelian and Commutative, because they can be seen as special cases of Group, Monoid and Semigroup.
If there is a case where a type can have different instances for e.g., Semigroup and Abelian semigroup, it can instead have two instances of Semigroup. This would reduce the mental burden on the users of the package.
We also need to be careful about the documentation. If, say, we introduce Ring, the documentation shouldn't just say "It's Ring". Ideally, it should explain what it is and provide practical examples of what it's useful for. Such practice also provides a tool for us: if we struggle to find practical examples for an abstraction, it should serve as a large red flag that the abstraction wouldn't be used in practice.
This project can turn into a successful entry drug into Category Theory but it can only happen if it has users. So approaching users correctly is the priority.
I hope you get me now. If you agree with this vision, I'll be happy for it to turn into our collective project. If you feel like you have different goals (e.g., research on marrying Elm with Category Theory) it probably is better for you to just make your own project out of it.


refactor Introduce a toolkits for clarify datelike types usage

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall


[alembic] linux fixes

Describe the pull request

What does your PR fix? Fixes issue #

Fix the portfile to avoid windows-specific commands.
Fix a linux build error due to -Werror in the library in debug mode. The build issue has been also reported to the main repository https://github.com/alembic/alembic/issues/263.

Which triplets are supported/not supported? Have you updated the CI baseline?

The alembic port file was valid only for windows. This PR adds the support for linux.
Tested on windows-10 and ubuntu-18.04.

Does your PR follow the maintainer guide?

Yes

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: fabiencastan sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for your PR! Can you please correct the Version field in the CONTROL file? You can get more information from maintainer-guide.md.

I'm not sure if I should update the version number, as it doesn't change anything on windows. And on linux it has never been possible to build before, so there is no need for invalidation either.

I'm not sure if I should update the version number, as it doesn't change anything on windows. And on linux it has never been possible to build before, so there is no need for invalidation either.

You need update the version in CONTROL.

Ok, updated.

Could you please remove alembic:x64-linux=fail in scripts/ci.baseline.txt, it makes Linux build failed.

Changed. I was not aware of this mechanism.
Thanks.

Thanks for the PR @fabiencastan!
Could you please revert the line ending change from LF to CRLF in ports/alembic/portfile.cmake? I tried pushing the change to your branch, however you did not select the "accept changes from maintainers" box.

Hi @ras0219-msft,
I updated the history to fix the mistake on the line ending.
(I do not find the option to allow the editing of the PR, maybe because it's a fork from an organization and not from my personal account)
Best,

LGTM! Thanks @fabiencastan