[HOLD Web-Expensify#38772] Update policy type definitions and use areChatRoomsEnabled flag

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/314223
Tests/QA

Sign into OldDot, create or navigate to an existing paid policy. Save the policyID.
Run the following snippet to enabled chat rooms for the policy.const policyID = '<policyID>';
API.policy_get({policyIDList: policyID}).then((response) => {
    const policy = response.policies[policyID];
    policy.areChatRoomsEnabled = true;
    API.policy_save({policyID, value: policy});
});

Sign into NewDot (you'll need to sign out first because of the new reliable updates changes). FAB > New Room. Verify the paid policy shows up as an option under "Workspace".

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@hayata-suenaga @marcaaron fixed the types, good for another look. Thanks!

@marcaaron good for another look, thanks!

Asked a C+ to complete the checklist

@hayata-suenaga I don't really think this needs to be tested externally. It just adds some types, let's just go ahead and merge it

@hayata-suenaga @rushatgabhane the testing steps are included in the OP

@rushatgabhane friendly bump on this review!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.73-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.73-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.74-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.74-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

Can an Expensify employee please provide a payment summary for this issue?

I think @rushatgabhane (C+) will receive payment for the internal PR review

Sorry I need a specific amount to approve the payment.

I think the usual amount for internal PR review is $250

Ah it's actually $500. Mind updating your comment?

Payment summary: $500 for @rushatgabhane for PR review and testing

$500 payment approved for @rushatgabhane based on summary above.


Honor inactive package classifier, skip deprecated packages by default

[ ] CI test invocation should also now scan the classifiers. If the inactive classifier is set, the package should be skipped in tox environments. We don't need to actively test it.
[ ] If a user provides the argument BUILD_INACTIVE=true at queue time, these inactive packages should be built regardless of inactive status.

An inactive classifier will looks like this:

Development Status :: 7 - Inactive

Please play with core first :p
Inactive:

azure
azure-common
azure-mgmt
azure-servicemanagement-legacy

Active:

azure-core
azure-core-experimental
azure-core-tracing-opencensus
azure-core-tracing-opentelemetry
azure-mgmt-core

First goal would be to enforce black on the core folder, without having to black the inactive SDK.
Thanks!

This is completed! We've entirely moved to individual pyproject.toml now!


Driver should support SAN options

Just found that we are starting to add SAN support on other plugins: https://github.com/HewlettPackard/chef-provisioning-oneview/pull/30
Our driver should have SAN support options.

Yes, that would be needed for enterprise usage I believe
Frances
From: Edward Raigosa<EMAIL_ADDRESS>Sent: Friday, January 08, 2016 10:03 PM
To: HewlettPackard/docker-machine-oneview
Subject: [docker-machine-oneview] Driver should support SAN options (#67)
Just found that we are starting to add SAN support on other plugins: HewlettPackard/chef-provisioning-oneview#30https://github.com/HewlettPackard/chef-provisioning-oneview/pull/30
Our driver should have SAN support options.
—
Reply to this email directly or view it on GitHubhttps://github.com/HewlettPackard/docker-machine-oneview/issues/67.


[#1668] fix: Replace assertions with exception-throwing codes

What changes were proposed in this pull request?
Replace assertions with exception-throwing codes to make them work in production.
Why are the changes needed?
For: https://github.com/apache/incubator-uniffle/issues/1668.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.

PTAL. @zuston @jerqi

ping @zuston @jerqi

Gently ping @zuston @jerqi

ping @zuston @jerqi ~~~


Custom SSL port

I was looking at the code and it seems that now, there is no way to specify to which SSL port will I perform the redirect.
This is an issue when I am testing locally with a custom HTTPS server that is listening on port, say, 3001 which is different from the default 443.
I will gladly make the necessary fixes and submit a PR, but would like to listen to your opinion first before start coding anything.

Hey,
Could be a nice addition - Would welcome a PR. Should just be very careful to not cause any issues with complex / unusual URLs.
Florian


Reset measurement while on instantaneous mode disables pulse feedback

What the issue says on the tin. All forms of feedback are disabled: clicks, LED, display flashes, haptic. The reading on all modes continues to update with new pulses though. Seemingly the only way to clear the bug is to power cycle it. Note that reset measurement while in average, cumulative, or history mode doesn't affect pulse feedback.
Unit is a FNIRSI GC-01 with the Geehy processor and an M4011 tube. Reproducible with 2.0.3 as well as the latest build of 2.0.4, currently d2693b8.

Thanks for the report! Fortunately very easy to reproduce.


Cann't Delete image when click backspace on soft-keyboard on Android4.4

Using this, Cannot delete image in the editor, Android 4.4 devices.

I have the same problem

http://stackoverflow.com/questions/14560344/android-backspace-in-webview-baseinputconnection

@viviwen123  When I use your solution(Override deleteSurroundingText method),can delete image success,but cann't insert characters.I need your help.

@onion4 Do you solve this problem? I have the same problem.

@Override
public InputConnection onCreateInputConnection(EditorInfo outAttrs) {
return new FixInputConnection(super.onCreateInputConnection(outAttrs),true);
}

@onion4 哥们我也遇到你这个问题了  可以删除图片 不能输入字符 最后咋解决的呢

I refer to http://stackoverflow.com/questions/16499178/cant-get-backspace-to-work-in-codemirror-under-phonegap-on-android-4-x
1:Override onCreateInputConnection in RichEditor.java
@Override
public InputConnection onCreateInputConnection(EditorInfo outAttrs) {
MyCustomInputConnection connection = new MyCustomInputConnection(this, false);
return connection;
}
2:Custom InputConnection:
public class MyCustomInputConnection extends BaseInputConnection{
public MyCustomInputConnection(View targetView, boolean fullEditor) {
    super(targetView, fullEditor);
}

@Override
public boolean deleteSurroundingText(int beforeLength, int afterLength) {
    // magic: in latest Android, deleteSurroundingText(1, 0) will be called for backspace
    if (beforeLength == 1 && afterLength == 0) {
        // backspace
        return super.sendKeyEvent(new KeyEvent(KeyEvent.ACTION_DOWN, KeyEvent.KEYCODE_DEL))
            && super.sendKeyEvent(new KeyEvent(KeyEvent.ACTION_UP, KeyEvent.KEYCODE_DEL));
    }

    return super.deleteSurroundingText(beforeLength, afterLength);
}

}

@pangxinlong Why can not enter Chinese?

@pangxinlong But cant input some charactors... such as CHINESE language~

@onion4 use x5 core (http://x5.tencent.com/)can fix this problem

@onion4 use x5 core ( http://x5.tencent.com )can fix this problem

@viviwen123 it not work can you tell me version of x5?

@viviwen123 No, its not work.

@freestyletime It works for me. Have you use com.tencent.smtt.sdk.WebView insted of system's WebView ?

@wuzheng4android @freestyletime I didn't have an Android 4.4 phone right now, you can have a  try of my fork: https://github.com/viviwen123/richeditor-android and see if it works.

@viviwen123   its not work...

Anybody resolved this problem ?

use tencent x5

@wuzheng4android Hi man... Are u sure? doesnt work on it.


chore: introduce notation for AlternatingMap

Use M [Λ^ι]→ₗ[R] N for AlternatingMap R M N ι,
similarly to the existing notation M [Λ^ι]→L[R] N
for ContinuousAlternatingMap R M N ι.

bors merge


fix: make preferences accessible on Safari

What type of PR is this?
Bugfix
What this PR does / why we need it:
When using Safari, the preferences link does not work. Using mousedown event instead of focus event should allow for better browser compatibility.
Which issue(s) this PR fixes:
#56

thanks!


Getting CSPCAN examples to work.

Hi,
I am trying to get the following example to work on my NXP board as a CSP CAN client and a Raspberry Pi node as a CSP CAN server. The only change I made is address = 0, and server_address = 27. May I know what changes I ought to make to get the example to work?
Thanks,
Ed
csp_server_client_zephyr.c
main.c
I am using python_bindings_example_client.py on the Raspberry Pi Client side. I am assuming that the server address is set to 27.
libcsp.init(27, "test_service", "bindings", "1.2.3", 10, 300)
libcsp.zmqhub_init(27, "localhost")
libcsp.rtable_set(0, 0, "ZMQHUB")
libcsp.route_start_task()
However, there doesn't seem to be any ping transactions coming through. The log on the Client side is as follows and no ping tx is followed.
*** Booting Zephyr OS build v3.6.0-4321-gec0e2d630868 ***
[00:00:00.001,000]  csp_sample_server_client: Initialising CSP
[00:00:00.002,000]  csp_sample_server_client: CAN interface added successfully.
[00:00:00.002,000]  csp_sample_server_client: Connection table
[00:00:00.002,000]  csp_sample_server_client: Interfaces
[00:00:00.002,000]  csp_sample_server_client: Client started.
[00:00:00.002,000]  csp_sample_server_client: Client task started
The log tx is as follows.
LD_LIBRARY_PATH=build PYTHONPATH=build python3 examples/python_bindings_example_server.py
Hostname: test_service
Model:    bindings
Revision: 1.2.3
Routes:
27/5 LOOP
0/0 ZMQHUB

The only change I made is address = 0

Address 0 is a special reserved address for the local.  You can't send any packet out to 0.

@Ed4129 Please reopen this or open a new one if you have more questions. Thanks.


Exception throwed when "ErodeMask" parameter is set as "true"

I try to use segmented images as masks to registrate two images. When i set "ErodeMask" parameter as "false", it works, but when i set "ErodeMask" parameter as "true", exception is throwed which is described as "Requested region is (at least partially) outside the largest possible region". What may cause this exception?
Thanks!

Perhaps the erosion reduces the mask to zero? Is your mask quite small?

Hello, everyone)
I try use mask to fixed image for apply registration. But after start code, i have mistake in logs: 'the bounding box of the mask lies entirely out of the InputImageRegion!'. After studying chats with a similar error, I want to try using install ErodeMask to false. How i can do it?
My code now:
parameter_object = itk.ParameterObject.New()
parameter_map_translation = parameter_object.GetDefaultParameterMap('translation')
parameter_map_translation['MaximumNumberOfSamplingAttempts'] = ('4', )
parameter_object.AddParameterMap(parameter_map_translation)
parameter_map_affine = parameter_object.GetDefaultParameterMap('affine')
parameter_object.AddParameterMap(parameter_map_affine)
resolutions = 5
Grid_Spacing_PhysicalUnits = 15.
parameter_map_bspline = parameter_object.GetDefaultParameterMap('bspline', resolutions,
Grid_Spacing_PhysicalUnits)
parameter_object.AddParameterMap(parameter_map_bspline)
print(parameter_object)
elastix_object = itk.ElastixRegistrationMethod.New(img_1, img_2)
elastix_object.SetFixedImage(img_1)
elastix_object.SetMovingImage(img_2)
elastix_object.SetFixedMask(fixPosM)
#elastix_object.SetMovingMask(movDoM)
#parameter_object['ErodeFixedMask'] = 'false'  I want apply something like this
elastix_object.SetParameterObject(parameter_object)
elastix_object.SetLogToConsole(True)
elastix_object.UpdateLargestPossibleRegion()
result_image = elastix_object.GetOutput()


Installation is heavy because of the compilation of mypy from source

I don't know very well how python works and how it's dependencies are integrated with nix but it looks like mypy is not really needed for the end user.
But nix-alien always wants mypy at version 0.942 which isn't in the cache, which makes every updates quite heavy.
On my machines, it monopolize my CPU for about 10 to 20 minutes.
If that's not really needed, would it be possible to avoid this?

I don't know very well how python works and how it's dependencies are integrated with nix but it looks like mypy is not really needed for the end user.
But nix-alien always wants mypy at version 0.942 which isn't in the cache, which makes every updates quite heavy. On my machines, it monopolize my CPU for about 10 to 20 minutes.
If that's not really needed, would it be possible to avoid this?

Yeah, it shouldn't be necessary for release. mypy and black are both declared as dev dependencies only, so they shouldn't be needed in release binaries.
The issue is, I am using poetry2nix and AFAIR there isn't anyway to create a release-only derivation that don't try to build the dev dependencies. I will take a look anyway.
The alternative is that I may remove black/mypy from the pyproject.toml file and them just include somewhere else (devShell maybe), and run this as a separate step in the CI. This was reproducibility issues though.

Should have been solved with PR #19.
Feel free to reopen this issue if this is not the case.


WIP: remove references to assets/ directory

All model assets are stored on Cloud Object Storage.

I have also updated the README-template.md to remove all references to the assets folder.

Should we also remove the assets folder? It's already created in MAX-Base: https://github.com/IBM/MAX-Base/blob/bae5b07a1ab7c93658037b6119c542350d430019/Dockerfile#L4

Thanks for https://github.com/IBM/MAX-Skeleton/pull/23/commits/26a7b870987c7e826a38d161dfd9bbc45e7b3d09 @ptitzler, you read my mind!

Should we also remove the assets folder? It's already created in MAX-Base: https://github.com/IBM/MAX-Base/blob/bae5b07a1ab7c93658037b6119c542350d430019/Dockerfile#L4

There should be no need to explicitly remove it because GitHub doesn't store information about empty directories. (assets/ should disappear)

Should we also remove the assets folder? It's already created in MAX-Base: https://github.com/IBM/MAX-Base/blob/bae5b07a1ab7c93658037b6119c542350d430019/Dockerfile#L4

Yes, but that'd be a different PR.


websocket-example

Build a simple websocket with hollywood actors.

Checking this tomorrow! Thanks for this!

I've reviewed the code. It has a few issues with it. To get this into a shape where we could accept it would be quite a bit of work. It's hard to review as I have no idea what a Hodor or a Goblin in and there is no statement of intent.
Also, there is a lot of global scope used, which is bad in itself.
It's been a while, so I perfectly understand if you don't want to do the effort.

@perbu
Hodor is valuable actor process to guard Websocket sessions storage.
Humans are connected websocket sessions.
Goblins are slaves who are working for humans. Each goblin works for corresponding human.
We can create too many goblin easily, They are cheap. Also we can kill them without thinking(actor.Poison).
I had learned some websocket stuff when I was at university(youtube @anthonygg_) and I've tried to implement it. If I remind correctly, problem is about getting actor ip in wrong scope. When I wrote this code I didn't know about go scheduler works.
I remember that anthony's actor model doesn't use channels, he was creating actor id's for each actor. With that he can send data through RPC. However, Actors are staying on (let steal) or (blocking)? If actors are staying on blocking mode, where is the go scheduler effect on actor design. If actors are staying on (let steal) mod, how infinitive loops are handled.


Notification: refresh & payload

@aleffert  please review.

to handle notification payload change.
to avoid duplicated notification events.

A couple nitpicks. Looks good! :+1:


Add Media Session types

This adds types for the Media Session API. Fixes https://github.com/microsoft/TypeScript/issues/19473
The only thing that could be improved with the types is that:
interface MediaSession {
    setActionHandler(action: MediaSessionAction, handler: MediaSessionActionHandler | null): void;
}

interface MediaSessionActionHandler {
    (details: MediaSessionActionDetails): void;
}

should really be:
interface MediaSession {
    setActionHandler(action: 'seekbackward' | 'seekforward', handler: MediaSessionSeekActionHandler | null): void;
    setActionHandler(action: 'seekto', handler: MediaSessionSeekToActionHandler | null): void;
    setActionHandler(action: MediaSessionAction, handler: MediaSessionActionHandler | null): void;
}

interface MediaSessionActionHandler {
    (details: MediaSessionActionDetails): void;
}

interface MediaSessionSeekActionHandler {
    (details: MediaSessionSeekActionDetails): void;
}

interface MediaSessionSeekToActionHandler {
    (details: MediaSessionSeekToActionDetails): void;
}

But I couldn't figure out how to insert the additional interfaces and the MediaSessionSeekActionDetails and MediaSessionSeekToActionDetails types from the widl file.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Rowno sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

You might want to check addedTypes.json and its additional-signatures field..

I spent a couple of hours hacking around in the addedTypes.json and overridingTypes.json files but couldn't figure out how to make it work properly.

We might need some documentation for those files... For now, something like this should work.
"callback-functions": {
  "callback-function": {
    "MediaSessionActionHandler": {
      "name": "MediaSessionActionHandler",
      "override-signatures": [
        "(details: MediaSessionSeekActionDetails): void"
      ]
    }
  }
}

And for additional-signatures:
"interfaces": {
  "interface": {
    "MediaSession": {
      "methods": {
        "method": {
          "setActionHandler": {
            "additional-signatures": [
              "setActionHandler(action: 'seekbackward' | 'seekforward', handler: MediaSessionSeekActionHandler | null): void"
            ]
          }
        }
      }
    }
  }
}

Additionally, caniuse.com says that only Chrome (and new Edge) support MediaSession API, so I want to wait until another browser supports this API before putting it in the standard library.

Fair enough

It seems MediaSession API has landed Firefox in version 82.


Project name not being equal to package name causes incompatibility with goimports if configured onsave

Package name - raven
Project name - raven-go
Could we have something common for both?

What's the question? A package can't be named raven-go, and we can't use just the name raven as a repository name. What would you suggest?

Closing due to inactivity and long overdue cleanup. Feel free to let me know if it's still relevant.


How to train by using single GPU？

If I only have a 3080ti GPU, can I train LoFTR？
BTW，how to modify the program so that I can use single GPU to train or test？
Looking forward to your reply. Thank you very much！

@Aran99G
hi,i meet the same problem, did you solve it?

hi,i meet the same problem, did you solve it?

hi,i meet the same problem, did you solve it?

hi，I had this problem too

我找到了问题所在，windows系统可能不支持
import os
os.environ["PL_TORCH_DISTRIBUTED_BACKEND"] = "gloo"
在你的代码里加上就可以了

If I only have a 3080ti GPU, can I train LoFTR？ BTW，how to modify the program so that I can use single GPU to train or test？ Looking forward to your reply. Thank you very much！


add tests for non-standard board sizes

Include tests for board sizes other than 8x8

Ok - good tests.


🐛 Fix duplicate question while up/down-ing, while surveying

What does this change
Fixes duplicate question while up/down-ing, while surveying
What issue does it fix
Partial prevents problem mentioned at #398 . But doesn't completely fix it
Notes for the reviewer
I couldn't resist adding extra space after question
Checklist

[ ] Unit Tests
[x] Documentation - N/A
[x] Schema (porter.yaml) - N/A

Just so we remember what the fix looks like, here's a screencap:

The "[Use arrows to move...]" prompt is put on a new line so that it is less likely to wrap and trigger the bug.
A space was added which indents that text a bit under the question.

/azp run porter-integration

@carolynvs

The "[Use arrows to move...]" prompt is put on a new line so that it is less likely to wrap and trigger the bug.

Yes

A space was added which indents that text a bit under the question.

Space was added to align question with answer. Unfortunately it misaligns help text

One more thing, I removed the work credential from Enter the %s that will be used to set credential %q to make it short. Is that OK ?
I put it in draft mode cuz I want to write A test. But I couldn't find a way to simulate a terminal with specific width to trigger bug. So, Lets just merge it


database: put missing predicates in consts and un-expose some of them

Fixes #16

didn't the deletelayer PR also use fieldIs?

LGTM


[WIP] Harfbuzz integration

See https://github.com/tangrams/fontstash-es/pull/18 for fontstash-es API update; mainly script/bidi detection.
No font fallbacks, if the font doesn't support any codepoint for the shaping plan, it will simply fail for now (fixing https://github.com/mapzen/eraser-map/issues/101).
Build system integration can be followed here: https://github.com/tangrams/harfbuzz-icu-freetype, where Harfbuzz RAGEL generated files are directly inside the repo, we would need to regenerate those everytime we update the version of Harfbuzz.

ICU dependency will be removed for a smaller library (UCDN).
Sorry for the lots of diffs in CMake, we should consistently use 4 spaces tabs in it.

[ ] Solve cases with multiple bidi detected (ICU might be useful in that case)

YAY :metal:

@hjanetzek can you review https://github.com/tangrams/fontstash-es/pull/18 for this pull request.

@hjanetzek , can you review please.
What is done by this pull request:

build system integration
bidi detection (single direction detection, LTR/RTL)
extension of fontstash-es api to detect drawable strings, along with harfbuzz functionalities

What should still be done:

multiple bidi handling within a string which involves line break detection with libunibreak to break shaping into different runs
font fallbacks through a font manager (which would somehow have a platform-dependent font resolution) for unresolved codepoints

Based on a discussion with @hjanetzek, implementation is ready but we decided to hold onto merging this branch for now for two reasons:

using harfbuzz is a no-op until font-fallback is added
shaping is a time-consuming step, which is aggravated by unseen labels

Just to clarify, in terms of extra computation, we only apply shaping when
needed though, right?
On Tue, Jan 26, 2016 at 2:13 PM, Karim Naaji<EMAIL_ADDRESS>wrote:

Based on a discussion with @hjanetzek https://github.com/hjanetzek,
implementation is ready but we decided to hold onto merging this branch for
now for two reasons:

using harfbuzz is a no-op until font-fallback is added
shaping is a time-consuming step, which is aggravated by unseen
labels

—
Reply to this email directly or view it on GitHub
https://github.com/tangrams/tangram-es/pull/475#issuecomment-175185824.


exodus: 22.2.25 -> 22.3.11

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/exodus/versions.
meta.description for exodus is: "Top-rated cryptocurrency wallet with Trezor integration and built-in Exchange"
meta.homepage for exodus is: "https://www.exodus.io/"
meta.changelog for exodus is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/vpil0378gh9wk2gx0acg27bwszs0m2mz-exodus-22.3.11/bin/Exodus had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/vpil0378gh9wk2gx0acg27bwszs0m2mz-exodus-22.3.11/bin/exodus had a zero exit code or showed the expected version
0 of 2 passed binary check by having a zero exit code.
0 of 2 passed binary check by having the new version present in output.
found 22.3.11 with grep in /nix/store/vpil0378gh9wk2gx0acg27bwszs0m2mz-exodus-22.3.11
found 22.3.11 in filename of file in /nix/store/vpil0378gh9wk2gx0acg27bwszs0m2mz-exodus-22.3.11

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
exodus

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vpil0378gh9wk2gx0acg27bwszs0m2mz-exodus-22.3.11 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A exodus https://github.com/r-ryantm/nixpkgs/archive/bf7df22a4f58164163434658307f4aedc650b2e5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vpil0378gh9wk2gx0acg27bwszs0m2mz-exodus-22.3.11
ls -la /nix/store/vpil0378gh9wk2gx0acg27bwszs0m2mz-exodus-22.3.11/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

exodus

Maintainer pings
cc @mmahut @rople380 for testing.

Page latest version is 22.4.22


Runelite settings Import/Export

Describe the solution you'd like
Add an option to the Runelite plugin panel to import or export Runelite settings to/from a text file. Stretch goal would be to allow partial imports/exports by plugin or by setting, i.e. I can only share my drop highlight list if I desire.
Describe alternatives you've considered
Share settings to other people via a link to a Runelite profile page from your RL client if you are logged in.
Additional context
I see people asking "How can you do this in Runelite" or "Can I get your setup". This issue is requesting a possible solution to that problem.

C:\Users\*NAME*\.runelite\ has a file settings.properties which holds all this information.

but settings.properties contain username. So i dont think is safe share with someone that file.
<EMAIL_ADDRESS>farmingTracker.XYZABC@KLMN.COM.12594.4771=8\:1528866648

With the addition of config profiles in 831189459ba51538b239a33b7d632bd2d9e4e8a3, you can export and import profiles. Account-specific settings are saved separately from config profiles, so for any sufficiently-new profile (which doesn't have legacy data/keys), they would not be exposed or shared.


External-dns should use zoneIdFilters when multiple DNS domains are passed through

Description
You can pass through ARNS for zones which is configuring the IAM role to allow to change specific zones in route53 but you will receive errors in the log if you have zones which are not meant to be managed by external-dns in the EKS cluster. In addition to increased logging this can also cause external-dns to get stuck trying to add records for a particular domain when it does not have permissions
If your request is for a new feature, please use the Feature request template.

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]:

v4.7.0

Terraform version:
1.0.9

Provider version(s):

Reproduction Code [Required]
Have multiple route53 zones some managed by EKS, some not
Expected behavior
No AWS IAM permissions errors in the logs and able to create all records
Actual behavior
AWS IAM permissions errors in the logs and unable to create all records, unless restrict to the domains
Additional Information
Previous change #838 switches to ARNs, this is okay for IAM but you need the domain name for the filters, so it may be better to do a data lookup on the domain names, to get the ARNs for the IAM role

this is all possible from the implementation side - trying to do data lookups within the module dynamically is a challenging thing, instead users are now able to do the lookup on their end and pass in via set values

zoneIdFilters in the helm chart is a list so I don't think you can use the set stuff as that looks like just for maps. So currently would need to override the whole values until #863. I don't think it is that hard to do data lookups, example code for IAM policy:
data "aws_route53_zone" "selected" {
  for_each     = var.domains
  name         = each.value.name
  private_zone = each.value.private_zone
}

data "aws_iam_policy_document" "external_dns_iam_policy_document" {
  statement {
    effect    = "Allow"
    resources = [
      for domain in aws_route53_zone.selected : domain.arn
    ]
    actions = [
      "route53:ChangeResourceRecordSets",
    ]
  }

  statement {
    effect    = "Allow"
    resources = ["*"]
    actions = [
      "route53:ListHostedZones",
      "route53:ListResourceRecordSets"
    ]
  }
}

Then in the templated yaml file something like:
zoneIdFilters:
%{ for domain in domains ~}
- ${domain}
%{ endfor ~}

this should work I believe:
	...
	set_values = [
		  {
			  name = "zoneIdFilters[0]"
			  value = "xxx"
		  }, {
			  name = "zoneIdFilters[1]"
			  value = "yyy"
		  }
	]

or even:
	...
	set_values = [
		  {
			  name = "zoneIdFilters"
			  value = "[xxx,yyy,zzz]"
		  }
	]


Trivial solution for trivial goals.

The [Test] passed to the solve function is a conjuction of tests.
In a similar vein to all, an empty list should mean that the condition
was met. That is, all the conditions in the list were met, there just
weren't any conditions.
This comes up when you want to create a problem which is attempting to
find a plan between two [a]s. The [] to [] case will result in a
failure to solve due to no goals being set.

I raised this more to start discussion than actually proposing a way to do this. Perhaps there just needs to be a shift in the way the input is fed to downward when there are no goals.


Will there be an update to support the latest Detox version?

Hello,
I was interested if there is an update to this project to support the latest Detox version. Did not integrated it yet, planning to, but just wanted to ask first .
Thank you!

Hi, I don't plan to update this package myself. But feel free to submit PR to fix this.


Feature extraction from 2D image

Hi,
I am working with 2D images currently. I can use pyradiomics to generate features. But I have one issue or doubt.
My images are in .png format (8bit grayscale). So when I use these 2d images directly, I can have a set of radiomics features.
In some older issues in pyradiomics, I found the moderator was asking to use  sitk.joinseries () for 2d images. So I used that and the code is running and generates features as well.
But the problem is the features obtained from direct 2d images and after joinseries() are not same. I understood that it may not be same. But my question is which one is the correct way or calculating features, as I will have different results using two different method.

Which features are different?
There should be no difference in features. The only special case is shape, for which there is a 3D en 2D equivalent.
In those older issues, joinseries was required, as PyRadiomics did not yet support 2D input, which is not an issue anymore.

I can confirm that since 2D extraction has been officially supported I have found no issues extracting features from truly 2D png image files (exported from an ultrasound scanner).

What is the code to extract features on a 2d grayscale image (.png for example) without inputting also an inputMask too? I would like to extract some GLCM, GLSZM features but it is asking for inputMask too.


Navigation 3D Max Slope Variable Limit Too Low

Godot version
3.5.1 Stable
System information
Windows 11
Issue description
On the advice of user @rburing in chat I've opened up a potential usability issue with regards to how the 3D navmesh bakes on sloped surfaces in 3.5.1 and I've detailed the problem in this thread on the Godot forums.
https://godotforums.org/d/31289-investigating-the-floating-navmesh-agent-behaviour-and-fixing-it-for-good/14
Initially thought when I was first investigating the behaviour it was some kind of issue with the navmesh agent itself and experimented a lot to find out what was going on but after a lot of fiddling I realised that was just the navmesh agent reacting to the way the navmesh agent getting either trapped within the navmesh itself because I increased the height to make the slopes bake correctly with an offset or they would be too many gaps baked into the mesh that I was baking on because the slopes were too high for the current 90 degrees max slope variable to deal with.
I don't know if this necessarily counts as a 'bug' but I seem to have accidentally stumbled on a small limitation with the engine itself that could be solved with some tweaking. Would appreciate some comments on this, there are use cases like with my game where I would like the nav mesh agents to be able to walk up slopes beyond the limits currently in place. Due to how many problems it causes it definitely has caused confusion on whether or not the navmesh is simply broken in how it behaves currently or something else and needs addressing.
Steps to reproduce
https://godotforums.org/d/31289-investigating-the-floating-navmesh-agent-behaviour-and-fixing-it-for-good/14
Minimal reproduction project
No response

As mentioned in chat max slope has nothing to do with this. A right angle equals 90 , and therefore a slope is always measured between 0 (horizontal) and 90 (vertical) which is the limit. As also mentioned need an MRP for this, just by looking at the images I doubt there is a bug, this kind of landscape should have no issues so I assume it is just a setup problem.

Well, in this case the problem is not the physics or the navigation but the extreme scaling values that scale 3D nodes up and down in your project. While some scaling may be o.k. (better avoid node scaling all together) such large values (x50) with multiple nodes in the nodetree are asking for problems.
Your source geometry mesh for the navmesh baking is basically miniature tiny. The navmesh baking still manages to bake it somehow but has to scale the result up a lot with the scaled node. If you go back to original scale that matches the values in the NavigationMesh bake properties you can immediatly see why things go wrong while voxelizing this 3D source mesh and why with certain settings the baking goes so wrong and creates gaps on all slopes. Due to the tiny scale a single cell basically needs to flatten so much surface area to create the minimum cell size that the slope turns into a single cell that has a large height difference which is threaded like it is a wall creating the gaps.
There are bugs in the actor movement logic in this project. The scripts are convoluted so I did not attempt to find the bug and created a new basic navigation actor for testing that had no issues with pathfinding or movement on this navmesh.

Thanks a lot for all this detail! It's needed, that's fascinating, I didn't know scale could affect it so much, I had mixed and matched the scale quite a bit to try and understand what was going on with the baking but I've been initially thinking that it was the slope. Would you mind explaining which values in the navmesh the scale of the land mesh it's baking to need to be the same? That's something I simply haven't seen discussed in tutorials or even the documentation.

Why would you even need to scale things up x50???

@Zireael07 I was rage experimenting

Okay, now I have some time again, I've been messing with the scale and everything and put it back to the default settings, it is now baking over the slopes correctly. I haven't yet experimented with steeper slopes and I will be doing but when I reduce the cell height to the minimum the gaps appear again. Ideally I think I want to have the navmesh hugging the island mesh for the sake of accuracy and minimal tweaking.
I take it when it comes to the scale if I want to change that I should be changing it within Blender and then re-importing it? That's something important I hadn't understood so I'll be doing that from now on.  Yeah I was raging hard at this problem and not paying attention.

Just posting up screenshots as well to show I've got the scales normal now.

The cell_height is used for the baking voxels and this value is also used for the navmesh height offset from the "ground". Low height values cost a lot of baking  performance as it needs to create multiple additional voxel grid layers to cover the same geometry height. If the height cells are too small the geometry angle might not be conderised a walkable slope but a vertical wall and that is way additional gaps appear with too small cell heights. You should never count on the navmesh offset being accurate towards the collision to e.g. place actors on the ground, as it is an aproximation, especially on slopes the offset can vary greatly.

Thanks again for all that detail it really is helping, I'll get to experimenting again and see what I can do with all of this. I think one thing is clear if there are no bugs and this is just a bit of a fiddly job to get through. There needs to be a proper write up done on exactly what you can do to make everything work correctly once I'm done I'll be happy to do a write up on the forum.
However I would also recommend this be done for the documentation because otherwise you'll have a lot of frustrated complainers like me not understanding what's going on with tall these variables and any topic I make is potentially going to get buried after awhile. I mean if it's approved by everyone else, I have no problem doing a write up for the documentation as well to specifically deal with slopes.
It's kind of funny now I think about it because I suspect that even the tutorial makers weren't posting up any information on this significant issue they seemed to cheat really and use completely flat floors whenever they made their tutorials which makes me wonder how much they had really tinkered with the navmesh.
One thing I might recommend debug wise is to prevent any annoyance with the scaling is maybe have a check run when the navmesh is baked or a mesh is made a child of the navmesh to see if the scales are equal and if they're not flag up a yellow warning. This will be another way you can reduce any potential spam about these settings.

Hi i am completely new to open source can someone navigate me or assign me this issue

@shazzsamed This turned out to be user error, not a real issue. Plus Godot doesn't practice assigning people issues

@1Lethn1
If you think something should be added to the existing navigation documentation please look at the Godot 4 doc here and go from there as Godot 3.5 has no backport of this navigation doc rightnow. Also for baking take into account the NavigationMesh class-doc here as it was decided to not repeat class-doc info, e.g. baking property descriptions, inside the godot-doc navigation pages.

@smix8 Will do! Thanks, I'll even throw in a basic wondering script as I've got that working properly now as well to get people started, basic movement from point A to point B is easy to look up.

Hurray! Ultra steep slopes are now baking correctly with a bit of height offset, I've still got experiments to do now with the agent movement and making sure that's relatively glitch free but I'm quite happy I think this can be counted as a solved issue. When I've got the time I'll do a more organised and coherent write up on the topic to help out anyone else who stumbles on this navmesh weirdness and doesn't know what to do.

I think this can be counted as a solved issue

I guess this issue can be closed then.


Appstudio update test-component-pac-yxde

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-yxde-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
23 seconds
clone-repository

✅ Succeeded
28 seconds
build-container

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
10 seconds
inspect-image

✅ Succeeded
12 seconds
deprecated-base-image-check

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
11 seconds
show-summary

✅ Succeeded
8 seconds
show-sbom

Pipelines as Code CI/test-component-pac-yxde-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
21 seconds
clone-repository

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
40 seconds
build-container

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
14 seconds
sbom-json-check

✅ Succeeded
7 seconds
inspect-image

✅ Succeeded
7 seconds
deprecated-base-image-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary


MIN4200-TL-XH miss values

Hello
it's been a while i'm struggling with official integration cause i was missing "import from grid" and "consumption" values, so i managed to switch to grott, using the MQTT i have 133 entities (but it's a mess) with your plugin 57 entities but i still miss these values + export to grid
Inverter: MIN4200-TL-XH mapped with "MIN", i tried out "default" and "TL3" with no luck, how can add these missing values?

hope someone can help me out
Thanks
Paris

I'm sorry but this integration just presents the values that are exposed by Grott, I have an SPH inverter myself so I'm not sure the correct configuration settings for your inverter.
The place to ask is probably over here: https://github.com/johanmeijer/grott

the values are exposed by Grott i guess  (still trying to understand)

when i use your extension i don't see the values, there is a pull request with these changes on your repo i though it was related

Oh wow, yeah, I have no idea how I missed that PR. I'll review it later today and merge it if there are no issues, thanks for bringing it to my attention!

Hello @muppet3000, I use an SPF 6000 ES PLUS and I have a similar issue with missing values. I just did my first installation of the whole process (installed the Growatt inverter last month).
I use the Grott stable branch (2.8) the Grott server log looks like this below;

The MQTT dump
{"device": "KHM0H5B1JA", "time": "2024-09-29T14:12:17", "buffered": "no", "values": {"datalogserial": "xxxxx", "pvserial": "KHM0H5B1JA", "pvstatus": 12, "vpv1": 1482, "vpv2": 2547, "ppv1": 10790, "ppv2": 39610, "buck1curr": 200, "buck2curr": 735, "op_watt": 9000, "pvpowerout": 9000, "op_va": 2498560, "acchr_watt": 0, "acchr_VA": 0, "bat_Volt": 5386, "batterySoc": 75, "bus_volt": 4548, "grid_volt": 0, "line_freq": 0, "outputvolt": 2297, "pvgridvoltage": 2297, "outputfreq": 5000, "invtemp": 503, "dcdctemp": 320, "loadpercent": 162, "buck1_ntc": 546, "buck2_ntc": 397, "OP_Curr": 42, "Inv_Curr": 44, "AC_InWatt": 0, "AC_InVA": 0, "faultBit": 0, "warningBit": 0, "faultValue": 0, "warningValue": 0, "constantPowerOK": 7533, "epvtoday": 130, "pvenergytoday": 130, "epvtotal": 3670, "eacCharToday": 0, "eacCharTotal": 1518, "ebatDischarToday": 95, "ebatDischarTotal": 2537, "eacDischarToday": 0, "eacDischarTotal": 2646, "ACCharCurr": 0, "ACDischarWatt": 8710, "ACDischarVA": 9500, "BatDischarWatt": 0, "BatDischarVA": 0, "BatWatt": -40870, "invfanspeed": 60}}
However, when I check the Grott HA add-on, I only see 8 entities with just 4 being figure related.

Thanks for your help in setting this up and your detailed docs, it made setting things up easier.


Edited demo/index.html

I have edited index.html as per issue 5247

Can one of the admins verify this patch?

Thanks for the fix.

Thanks for merging


scankeys link is broken

... in readme.md
Thanks for the nice project!

Fixed.  Thanks for the report.


Updating en version of file to comply with #306 & copy to sw folder for translation

Thanks for the cleanup, that is a very good pull request!
Should we add "translation headers"?

Althio,
Yes,  sorry forgot the headers.  I'm in London all day for missing maps so
won't get the chance to add them.
Nick
(OSM=Tallguy)
dodgy didgits as using a phone with a spell chequer.
Humanitarian OpenStreetMap Team Member
On 15 May 2015 06:53, "althio"<EMAIL_ADDRESS>wrote:

Thanks for the cleanup, that is a very good pull request!
Should we add "translation headers"?
—
Reply to this email directly or view it on GitHub
https://github.com/hotosm/learnosm/pull/372#issuecomment-102269510.

@Nick-Tallguy Pull request for headers at #373 please check and merge if applicable.


[W6.6c][T10-B2]YapZuoXuan

user story LO

@wishingmaid
Accepting this PR with minimal review and I found no important issue.


Always close file descriptor (eventually runs out of them)

File descriptor is not closed if no error occurs. Eventually they get exhausted after 1000 NSData( contentsOfFile: path )

good catch looks fine to me


No data? Subscription doesn't send "ready" and blocks all other subscriptions

Meteor.publish("Avatars", (api) ->
  check(api, String)
  return [] unless @userId
  PgConnection.select('SELECT a."id", a."name" FROM "Avatars" AS a WHERE a."api" = $1 AND a."userId" = $2', [api, @userId])
)

If there are no avatars for current user, subscription breaks itself and other subscriptions that hit the server after that.

Thanks for the issue! Big time whoops on that :hushed: :speak_no_evil:
Just released, version 0.0.5 fixes this problem.

Thank you for the fix!


http-proxy-middleware require import has changed

Since http-proxy-middleware has a version higher v1.x.x the import of the require statement has changed... Please refer to docs --> https://github.com/chimurai/http-proxy-middleware
I had that issue when I installed this package with version > 1.x. During build process I got that error proxy is not defined. Well, the import has changed, as I said.
Hope that helps and thank you for CRA. Keep up the good work!

duplicates #8515
related to #8524 #8537

Dupe of #8515. Thanks!


Plan name is not changed while swapping

A couple of weeks ago I did a pull request with small change in Subscription class.
It was this one:  While swapping plans the name should be also changed (not only 'plan' attribute/db column)
It's been accepted. I can see it in the code on the GitHub but when I update the package (or do fresh install) it's not there.
I really need it working.
Do I do something wrong?
I'd also be very honored if you add me to the contributors list :)

Hi @core45 i looks like the version number has not been bumped. @sandervanhooft
you could try using dev-master as version in your composer to get the latest commits.
You are not listed in the contributors page because your commits are not related to your GitHub account. It’s core45@someip instead of a commit with your e-mail address..

Here you go!
https://github.com/mollie/laravel-cashier-mollie/releases/tag/v2.0.5


Introduce type annotations

Supersedes #59. Now that the minimum requirement is Python 3.6 it is fairly easy to intermingle the type annotations in the code directly.
Please test this against your typed code to make sure the annotations are correct.

@lonvia : Thank you for this change! I am interested to use/test the type annotations in combination with mypy. Do you plan to release this anytime soon (under a new version number) for pypi? That would make it super-easy to include it in my (pet) project.

A new release is imminent because I have a couple of bugs piled up where fixes need to be published. However, I would be really grateful if you could give it a quick try before the release to test if I haven't broken things.

@lonvia : I tested ee760fa with my current pet project. It uses only SimpleHandler and SimpleWriter. The result is: mypy --strict runs through without issues and the .pbf output is the byte-exact output as in my other setup.
I had an issue building pyosmium. As far as I could understand, it is related to the usage of Python 3.10. I attach my notes from the process, but apart from maybe adjusting your README there is probably not much you can do about it. I used Ubuntu MATE 22.04.1 LTS.
sudo apt install python3-build python3.10-venv
git clone https://github.com/osmcode/pyosmium.git
cd pyosmium
mkdir contrib
cd contrib
git clone https://github.com/osmcode/libosmium
git clone https://github.com/mapbox/protozero
git clone https://github.com/pybind/pybind11
cd ..

l@box:~/Desktop/pyosmium$ python3 -m build -w
* Creating venv isolated environment...

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/build/__main__.py", line 372, in main
    built = build_call(
  File "/usr/lib/python3/dist-packages/build/__main__.py", line 202, in build_package
    out = _build(isolation, builder, outdir, distribution, config_settings, skip_dependency_check)
  File "/usr/lib/python3/dist-packages/build/__main__.py", line 140, in _build
    return _build_in_isolated_env(builder, outdir, distribution, config_settings)
  File "/usr/lib/python3/dist-packages/build/__main__.py", line 104, in _build_in_isolated_env
    with _IsolatedEnvBuilder() as env:
  File "/usr/lib/python3/dist-packages/build/env.py", line 104, in __enter__
    executable, scripts_dir = _create_isolated_env_venv(self._path)
  File "/usr/lib/python3/dist-packages/build/env.py", line 258, in _create_isolated_env_venv
    executable, script_dir, purelib = _find_executable_and_scripts(path)
  File "/usr/lib/python3/dist-packages/build/env.py", line 303, in _find_executable_and_scripts
    raise RuntimeError(f'Virtual environment creation failed, executable {executable} missing')
RuntimeError: Virtual environment creation failed, executable /tmp/build-env-uni1pvd8/local/bin/python missing

ERROR Virtual environment creation failed, executable /tmp/build-env-uni1pvd8/local/bin/python missing

# some links:
# - https://github.com/pypa/build/issues/215
# - https://github.com/deadsnakes/issues/issues/198

sudo apt install python3-virtualenv
virtualenv -p python3 venv/
source venv/bin/activate
pip install build[virtualenv]  # per https://github.com/pypa/build/issues/215#issuecomment-1016989092

sudo apt install cmake libbz2-dev libboost-dev # install the minimum of dependencies of osmium according to https://osmcode.org/libosmium/manual.html#dependencies

python3 -m build -w  # will create ./dist/osmium-3.5.0-cp310-cp310-linux_x86_64.whl

# some info about my system

l@box:~$ python3 --version
Python 3.10.6

l@box:~$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.1 LTS
Release:	22.04
Codename:	jammy

I am looking forward to your release. Thank you for maintaining pyosmium! 👍👍👍


EKS k8s v1.11 -> v1.13 upgrade

I have question
Right now, I am trying to use the latest and greatest v5.0.0 EKS module to do the upgrade. The tf plan looks good, and then I went straight to do the upgrade.
I did not specify cluster_version (so it should be 1.13 by default). I kind of expect it should go straight to v1.13, but seems have step in the middle of using v1.12.
Not sure if that is common upgrade process for everyone.
I'm submitting a...

[ ] bug report
[ ] feature request
[x] support request
[x] kudos, thank you, warm fuzzy

What is the current behavior?
v1.11 to v1.13 upgrade becomes like v1.11 to v1.12 to v1.13 two upgrades.
Environment details
All are the latest.

Affected module version: v5.0.0
OS: Mac
Terraform version: 0.12.5

Any other relevant info

OK, it turns out I have to explicitly specify cluster_version to v1.13 (to upgrade the cluster to v1.13). That is interesting.

Also the cluster_version on the registry info page needs to be updated:

Hi. AWS only allows you to upgrade a single minor version at a time. 1.11 -> 1.12 -> 1.13 etc. I highly recommend reading the upgrade documentation for other steps to perform within your cluster when upgrading. AWS does not manage any of the resources within your cluster:
https://docs.aws.amazon.com/eks/latest/userguide/update-cluster.html
The default cluster version in module version 5.0.0 is 1.12. master branch has been updated to 1.13 but this has not been released yet.


adding new approvers - nnmin-aws

What this PR does / why we need it:
This PR adds nnmin-aws and DanielCKennedy as approvers to this repo.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Updated. Removed @DanielCKennedy for now.

/lgtm
/approve

/ok-to-test


Correct new line problems

Just figured out how to fix the new line problem we had.
We could leave tests folder ignoring normalization:
tests/**/*          crlf=false

But that only works if no other overrides it so all other attributes must be more selective
src/**/*.json       eol=crlf
src/**/*.ts         eol=crlf
scripts/**/*.cmd    eol=crlf
scripts/**/*.js     eol=crlf
scripts/**/*.js.map eol=crlf
scripts/**/*.json   eol=crlf
scripts/**/*.ts     eol=crlf

In order for git to convert LF to CRLF it also need to have clean files with CRLF. So I updated all the files under src. And I got this warning outputted if I try to add LF:
warning: LF will be replaced by CRLF in src/compiler/emitter.
The file will have its original line endings in your working directory

Otherwise, I think git tries to be smart and not normalize files to prevent an explosion from happening.
I just tried everything above and it works for me on a Mac with:
git --version
git version 2.3.2 (Apple Git-55)

I actually have a commit for this here: https://github.com/Microsoft/TypeScript/commit/52e6b7f09a8e2fb9118836d1e360badf2ac675ec
Mainly I did this because some on the team would prefer we whitelist instead of blacklist files. I'm generally rethinking it now.

@DanielRosenwasser I think that solution turns off all normalization even under src. With eol=crlf we can convert LF to CRLF.

@tinganho why would that be? I thought later entries in .gitattributes got priority.
Also, I thought the idea was that we wanted autocrlf for src.

+src//*.json  text
+src//*.ts    text

I believe the text attribute normalize to LF. At least according to their man page:
When a text file is normalized, its line endings are converted to LF in the repository.

Also, I thought the idea was that we wanted autocrlf for src.

The autocrlf can have three values? false, true and input. But also looking at this table. There can still be mixed crlf and lf line endings for all three values:
http://stackoverflow.com/questions/1249932/git-1-6-4-beta-on-windows-msysgit-unix-or-dos-line-termination/1250133#1250133

@DanielRosenwasser can you give this a test and see what we need to do here.

@tinganho  and @DanielRosenwasser do we still need this?

I think if we want LF converted into CRLF then this is still relevant. Though there exists -text attribute now in .gitattributes. It will treat everything as binary files and not do any conversion/normalization at all. Most non-windows repo just have the text attribute to convert CRLF to LF. This just the opposite.

Here's still my idealized scenario:

Everything is -text unless otherwise specified
Everything in src is text.
Everything in scripts is text.
All top-level text files are text.
doc/docx/pdf files have astextplain for diffing.

This PR addresses a different view: that the text should just always be CRLF, which some on the team do agree with, but I personally don't. I'd prefer we didn't go down that route.

My question is more  about the source issue. We have got regular issues about line ending until we added "-text". i have not seen any since. is this still an issue we need to fix?
if so, @DanielRosenwasser 's proposal seem to have less movig pieces, and i would just enforce this on src.

I think @DanielRosenwasser proposal is to have LF now in src and scripts. I personally like LF more than CRLF.
http://git-scm.com/docs/gitattributes

I'm also have not been able to set overriding rules in gittattributes. I'm not sure why. If you see my PR I set everything explicitly.

I'm also have not been able to set overriding rules in gittattributes. I'm not sure why.

Same, this is why I haven't been able to get this moving. What OS are you running on @tinganho?

Mac OS.
On Sat, Jun 20, 2015, 09:27 Daniel Rosenwasser<EMAIL_ADDRESS>wrote:

I'm also have not been able to set overriding rules in gittattributes. I'm
not sure why.
Same, this is why I haven't been able to get this moving. What OS are you
running on @tinganho https://github.com/tinganho?
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/TypeScript/pull/3174#issuecomment-113692144
.

so what are we doing with change at this point?

I think it would be appropriate to close this and open up a new PR some point down the line to accomplish what I've described.

closing then. thanks

Changes Unknown when pulling 5d470fd92b7a0360e8f4632cea86fdbe164ec2ff on tinganho:gitattributes into ** on Microsoft:master**.


New beta or stable release

Would it be possible to get a new beta or stable release for this module. It protects against unintended updates for production sites using the module.

Along with this, we've begun to use a changelog generator to help create a good reference for release changes. There's a little bit of setup, but it beats manually creating them for each release. The additional info noted for each release is a huge help in skimming through fixes, enhancements and everything in between.


see if the weather api returns the city and state that can be used as a backup if geocoding returns unknown

does not return city/state


[qt5] update to 5.12.6

Library name: qt5*
New version number: 5.12.6
https://wiki.qt.io/Qt_5.12_Release

@Neumann-A Do you have a plan to update Qt5? We are really busy.

@TheScarfix this is the 6th Qt LTS release of this branch this year. I can't speak for everyone but I rarely pull a release from Qt without six months passing by and 5.12.5 is already in the ports tree.
Please feel free to submit a pull request with a version bump but you might want to wait a bit because there is something going on with the build bots which run on the pull requests right now.
A port as big as Qt really needs to pass CI tests before being merged. The port is too complex to just bump because there was a new release upstream.

@JackBoosY No plan at all. What I want is rewrite the qt5 metaport to be all features for the different qt5 subports and then update. But as long as CI is not working it is probably just adding more work for you ;)
@heydojo I don't think you need to lecture TheScarfix on this since he typically makes the PRs for updating qt which I just happened to hijack in the past. But I think bumping the version to 5.12.6 will be trivial when CI is back up (since 5.13 is also already working through the [latest] feature)


Verifying SMR Address for a space not working

Describe the bug
I want to verify my SMR address, paying the needed SMR, it says verificaion finished, but nothing happens, SMR will get refunded, but the status "unverified" keep as it is.
To Reproduce
Steps to reproduce the behavior:

Go to 'https://soonaverse.com/space/0xd04b96aed8c3ab9fd9a94072817db16de8b95285/collections'
Click on 'manage'
Click verify and send the needed SMR
See error -->  " Not yet verified "

Expected behavior
I would expect that my SMR adress gets verified for my collections.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Windows 10
Browser : Chrome
Version 117.0.5938.92

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@flyingrabbit-lab - can you check this please?

@f15hfood Could you provide me the tangle transaction id with which you paid for the verification?

yah sure, tried it again today: 0xff64cfca848c13fd51de530b542c3d3516e3c6e1d79f2ca85c440085615f8e86
https://explorer.shimmer.network/shimmer/transaction/0xff64cfca848c13fd51de530b542c3d3516e3c6e1d79f2ca85c440085615f8e86

Ah, now I understand what the issue here is. When you verify your space address it does not instantly set's the address. It creates a proposal that needs to be approved
https://soonaverse.com/space/0xd04b96aed8c3ab9fd9a94072817db16de8b95285/proposals

@adamunchained This happened before, I think we should update to UI to display a clear message pointing users to proposals page.

thanks a lot @flyingrabbit-lab and @adamunchained  yah I was not aware if there are 2 guardians, that there will upcome a proposal

Will tweak UI.

As per Taskforce request, adding some comments based on what I think the issue is:

UI needs to be tweaked to tell user there is a proposal that needs to voted on. Or ideally, it even redirects user to it.


Add support to text files for read/write #32

What is the purpose of this pull request?
Currently we have support for json,avro,parquet and csv.
By this we will have support for text files.
We want to use spark-sftp in our following Gimel project.
https://github.com/paypal/gimel
Gimel provides unified Data API to access data from any storage like HDFS, GS, Alluxio, Hbase, Aerospike, BigQuery, Druid, Elastic, Teradata, Oracle, MySQL, etc.
How was this patch tested?

Placed a text file in SFTP.
Used the following code to read the file config and printed the content of DF.
val df = spark.read.
format("com.springml.spark.sftp").
option("host", "SFTP_SERVER").
option("username", "USER").
option("password", "xxxxx").
option("fileType", "txt").
option("header", "false").
load("config"
For write, used the following code to write to SFTP.
df.write.
format("com.springml.spark.sftp").
option("host", "SFTP_SERVER").
option("username", "USER").
option("password", "xxxxxx").
option("fileType", "txt").
option("hdfsTempLocation","/tmp/basu/").
save("newConfig.gz")

@bagopalan - Code changes are fine. Could you please modify README to include txt file as well. Also please add a sample code to read txt file.

@samuel-pt , changed the README to have sample code to read text file. I already added sample text file in the resources which will be used in test classes.

@bagopalan - Merged the changes. I will publish the release in next week


Need Help in Apply Custom Styling Table Columns

I'm submitting a ...  (check one with "x")
[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior
I'm not able to apply border on some condition for a set columns.
Expected behavior
I want to put a border on right side of columns fulfilling a condition. This is more like grouping the columns but without having a header for that group. Please have a look on attached image for a sample.
Reproduction of the problem : Sample Image

What is the motivation / use case for changing the behavior?
This is peculiar use case of our application. I cannot put forth complete use case due to security guidelines of company.
Not sure if this will be candidate for enhancement. You may like to advise.
I'll be glad if you could help me implement this behavior.
Please tell us about your environment:

Table version: 9.2.0

Angular version: 4.0.3

Browser: [all]

Language: [all]

Any update on this?


[Question] Reference a with from another with?

I'm trying to write a more complex version of the following query:
Business \
  .with(available_products: Product.for_category(category_id))
  .with(sale_products: available_products.on_sale)
  .find_by_sql(<<-EOSQL
    SELECT *
    FROM businesses
    INNER JOIN available_products ON available_products.business_id = businesses.id
    LEFT JOIN sale_products ON sale_products.business_id = businesses.id
  EOSQL

In my hypothetical example here, I want to find businesses with available products for a particular category, but only return the products that are on sale in my JSON. The above doesn't work because available_products is (unsurprisingly) undefined.
Is it possible to references the available_products with in the sale_products with somehow like I can in raw SQL (without just writing SQL for the second with)?

With takes a hash, so you can pass multiple CTEs into one with call, does that work?

Ah, I see what you're getting at. Let me respond in a little bit.

Is there a reason you don't chain on_sale on the original CTE?

I wrote this in SQL originally and I'm now trying to backport it to this. I think the issue is that I want to join Business on all available products, but only want sale_products to appear in the JSON at the end.
I think a more descriptive SELECT would've been:
SELECT
  businesses.id,
  businesses.name,
  array_to_json(array_remove(array_agg(sps), null)) as sale_products

Generating JSON like:
[
  {
    id: 1,
    name: "Super Company",
    sale_products: [
      {
        id: 100,
        name: "Great Product",
        price: 123.45,
        sale_price: 82.37
      },
      {
        id: 101,
        name: "Cheap Thing",
        price: 8.30,
        sale_price: 4.12
      }
    ]
  },
  {
    id: 2,
    name: "Sweet Corp",
    sale_products: [
      {
        id: 200,
        name: "Tasty Item",
        price: 10.01,
        sale_price: 9.13
      }
    ]
  }
]

I'm mostly exploring at this point. Not sure if any of this is a good idea compared to completely separating querying from JSON generation. Was exploring a "No ORM" approach vs. a pure AR approach, and am just seeing what splitting the difference looks like.

I have a similar scenario with chaining mulitple CTEs. I'm struggling with the syntax of using one CTE within the next. @danmcclain, can you post an example of what you mean by:

Is there a reason you don't chain on_sale on the original CTE?

Thanks!

+1


fix misleading message

Description
Fixes #741 misleading message on remove collection. Replace "delete" with "remove" since collection is not deleted from disk, only remove from Bruno.
Before

After

Contribution Checklist:

[x] The pull request only addresses one issue or adds one feature.
[x] The pull request does not introduce any breaking changes
[x] I have added screenshots or gifs to help explain the change if applicable.
[x] I have read the contribution guidelines.
[x] Create an issue and link to the pull request.

Thanks for taking care of this @flof !


Traffic law in the United States

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
https://github.com/instructlab/taxonomy/issues/811
Describe the contribution to the taxonomy

...
...
...

Input given at the prompt

   ...

Response from the original model

  ...

Response from the fine-tuned model

  ...

Contribution checklist

[ ] The contribution was tested with ilab generate
[ ] No errors or warnings were produced by ilab generate
[ ] All commits are signed off (DCO)
[ ] The qna.yaml file contains at least 5 seed_examples
[ ] The qna.yaml file was linted and prettified (yaml-validator can do both)
[ ] An attribution.txt file in the same folder as the qna.yaml file
[ ] Content does not include PII or otherwise sensitive or confidential information
[ ] Content does not include anything documented in the project's Avoid these Topics guidelines

Closing per combined PR here: https://github.com/instructlab/taxonomy/pull/1151


Make extractSymbol explicitly drop JSDoc nodes

Since they're neither statements nor expressions, they cannot be extracted.  Ironically, we then fail to create an (unobservable) error describing why they cannot be extracted, skip past trivia (bonus: isTrivia returns false, but skipTrivia moves past them), and compute an invalid range.
Note that users encountering this error aren't necessarily trying to extract JSDoc comments - we compute this on their behalf whenever a range is selected.
Fixes #33332

Thanks!


Epic: Improve function descriptions for planners

[!NOTE]
This issue tracks all of the items necessary for aligning semantic function serialization with the rest of Microsoft.

### .Net
- [ ] https://github.com/microsoft/semantic-kernel/issues/2915
- [ ] https://github.com/microsoft/semantic-kernel/issues/3129
- [ ] https://github.com/microsoft/semantic-kernel/issues/3140
- [ ] https://github.com/microsoft/semantic-kernel/issues/1978

### Python

### Java

Marking as closed for .NET, will create new issues for Python and Java


Why can't I see the "Albums" icon?

I am running the latest LMS (v8.5.0 -<PHONE_NUMBER>) and lms-material plugin 4.4.1 and when I enter the "My Music" section I can't see the "Albums" icon to enter the Albums view

You have enabled 'Release type support' in LMS. This then splits (what was) "Albums" into "Albums", "EPs", "Singles", etc. With this enabled it makes no sense to refer to a list of "Albums, EPs, etc." as "Albums" - because it contains more than albums. And if, for example, you only had "EPs" then if "Albums" were used as the title here when you browsed Material would state (e.g.) "100 EPs" - again no sense. For this reason Material changes the string to "Release" - but the view when entered is the same.
If you want an explicit "Albums" view that only contains albums you can use "Extended Browse Modes" -e.g.:

...which leads to:


onCanvasClick is not triggered when position changes

Hi,
Another question, I am injecting this calendar timeline in the page in a certain position. But the content above it might get cleared bcs of user action, like:
<content />
<Timeline />          --->             <Timeline />

In this case, the onCanvasClick is not working properly. But if I put the content back, this onCanvasClick starts to work again.
I guess this happen bcs of the html canvas behavior. Another scenario to test is, if you minimize your browser height, the canvas will also lose track.
So is there any workaround method?

hi @hotyhuang can you please provide a codesandbox link that reproduces this issue?  Just fork one of the examples

👍 excellent thank you

Looks like this is fixed in beta:
https://codesandbox.io/s/jvy8wkvrvy
Can you confirm @hotyhuang ?  If so, I'll keep this open until that is released

related to https://github.com/namespace-ee/react-calendar-timeline/issues/159

@mcMickJuice I think the click is not so accurate with sandbox itself. But ye, the actual problem is resolved in this beta.
Btw, when are you guys planning to do the next release?

Very soon. I'm waiting on a response from someone regarding a bug they encountered this morning.  Hopefully this weekend.

https://github.com/namespace-ee/react-calendar-timeline/issues/296


How to install in Angular Framework

I tried to install it in my angular project with tailwindcss installed and I'm getting the following error:
Error: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
Error: Unable to parse color from string: at new Color (/app/node_modules/color/index.js:49:10) project | at Color (/app/node_modules/color/index.js:24:10) project | at /app/node_modules/tw-colors/dist/lib/index.js:52:70 project | at /app/node_modules/lodash.foreach/index.js:221:11 project | at baseForOwn (/app/node_modules/lodash.foreach/index.js:153:20) project | at /app/node_modules/lodash.foreach/index.js:190:14 project | at forEach (/app/node_modules/lodash.foreach/index.js:290:10) project | at /app/node_modules/tw-colors/dist/lib/index.js:48:38

Hi, can you share your tailwind config?

Hi, can you share your tailwind config?

`const { createThemes } = require('tw-colors');
module.exports = {
darkMode: 'media',
content: [
"./src/**/*.{html,ts}",
],
theme: {
extend: {},
},
plugins: [
createThemes({
light: {
primary: "steelblue",
secondary: "darkblue",
},
dark: {
primary: "",
secondary: ""
}
}),
],
}`
this is my tailwind config


If anyone wants to build and compile V3.0 with the ATmega4809 chip using an FT232R Breakout

Working with an ATmega4809
https://github.com/gotnull/Solder-Reflow-Plate/blob/main/Board Versions/70mm by 50mm Ver3.0 ATmega4809/Software/SW1.0_HW3.0_70by50mm.ino
To Prepare

Include MiniCoreX in additional boards via the Arduino IDE Boards Manager: https://mcudude.github.io/MegaCoreX/package_MCUdude_MegaCoreX_index.json
Install Bounce2, Adafruit_GFX and Adafruit_SSD1306 libraries (Tools->Manage Libraries)

To Program

Select the following settings under (Tools)

Board > MegaCoreX > ATmega4809
Clock > Internal 16MHz
BOD > BOD 2.6V
EEPROM > EEPROM retained
Pinout > 48 pin standard
Reset pin > Reset
Compiler LTO > LTO Disabled
Bootloader > No bootloader

Compile to ATmega4809
I followed this guide here: https://swharden.com/blog/2022-12-09-avr-programming/
Specifically this setup:

Connect the programmer as shown with the RX pin directly to the UPDI pin of the microcontroller and the resistor between the RX and TX pins. IMPORTANT: The Reflow Plate must be powered externally via 12V with a minimum of 5A during this process.
I used a 10KΩ 0.5W resistor instead. This is even closer to the recommended value. 10KΩ is a common pull-up resistor value used in many electronics applications. It should work well for the UPDI interface.
Ensure a modern version of Python is installed on your system
pip install pymcuprog
Use the device manager to identify the name of the COM port representing your programmer. In my case it was /dev/tty/usb.serial-AH00XXXX on MacOS.
I then interacted with the microcontroller by running pymcuprog from a terminal. This command returns the Device ID (1E9651 for my ATmega4809) indicating the UPDI connection is working successfully.
pymcuprog ping -d atmega4809 -t uart -u /dev/tty.usbserial-AH00XXXX

Connecting to SerialUPDI
Pinging device...
Ping response: 1E9651
Done.

I used Arduino IDE to compile my C code and generate the hex file (turn on verbose output during compilation to know the location of your .ino.hex file). Now you can use pymcuprog to load the hex file onto the chip. It’s slower to program and inconvenient to drop to a terminal whenever you want to program the chip, but it works.
pymcuprog write -f SW1.0_HW3.0_70by50mm.ino.hex -d atmega4809 -t uart -u /dev/tty.usbserial-AH00XXXX --erase

Connecting to SerialUPDI
Pinging device...
Ping response: 1E9651
Erasing device before writing from hex file...
Writing from hex file...
Writing flash...
Done.

Is the script the same?


Cache returns stale response body data on when ETag is the same (Windows only)

Environment
OkHttp 4.2.2
Only happens on Windows.  On linux and MacOS, the correct (expected) behavior occurs.
Description
On Windows, the OkHttp Cache does not update response body data for a request when a later response has the same ETag as a previous response.
Steps

Request a URL /a/b

Response Header: 404, no ETag
Response Body: '{ "message": "Not Found" }'
Cache Updated

Request a URL /a/b with "If-Modified-Since" header

Response Header: 304, ETag "C"
Cache automatically converts - client sees:

Response Header: 404, ETag "C"
Response Body: '{ "message": "Not Found" }'

Request a URL /a/b with "Cache-Control: no-cache" to force retrieval of new data

Response Header: 200, ETag "C"
Response Body:  '{ data: "..." }'
NOTE: Yes, that is the same ETag with different data - not good, but cache should still work
Cache Updated? (I think this is where the problem starts).

Request a URL /a/b with "If-None-Match" equal to ETag "C"

Expected Result

Response Header: 304, ETag "C"
Cache automatically converts - client sees:

Response Header: 200, ETag "C"
Response Body:  '{ data: "..." }'

Actual Result

Response Header: 304, ETag "C"
Cache automatically converts - client sees:

Response Header: 200, ETag "C"
Response Body: '{ "message": "Not Found" }'

Automated Test
I know it is not great to point to a test on an external project but the test fully automated and will repro the issue every time:
https://github.com/github-api/github-api/blob/967512629821b706e8d06ef9b3e57061f397d073/src/test/java/org/kohsuke/github/extras/okhttp3/GitHubCachingTest.java#L59
To run automated repro:

clone the repository on Windows with JDK 8+
remove the assumeFalse() call
run mvn install

Notes
This issue was found and can be reproduced using https://github.com/github-api/github-api .
It is exposed due to a bug in GitHub server responses (see https://github.com/github-api/github-api/issues/669) but it is still a bug in this OkHttp Cache behavior on Windows.

Thanks for your help @bitwiseman! I’ve set up VirtualBox and Windows 10 to reproduce locally. The sad news is we’ve designed OkHttp’s cache with assumptions of POSIX file systems, and Windows doesn’t satisfy these assumptions.
In particular:

We can’t delete a file that has active readers. This happens when a cache write updates a file that’s still being written.
We can’t atomically rename a file on top of an existing file. This happens when a cache write updates an existing cache entry. It may also happen with the journal.

I think the easiest solution is to recover (more) gracefully when Windows’ file systems prevent us from doing what we can do reliably on POSIX. We won’t be able update the cache when it’s actively being read, though we should be able to invalidate the stale entry to-be-replaced.
I’d like to start by figuring out exactly which operations in our test suite Windows rejects, and adding tests that use our FaultyFileSystem to synthesize these. That way we can quickly iterate on Windows’ behavior without having to drag out a Windows VM or PC. We’ll also need to keep CI on Windows so we can be sure we aren’t missing anything.
I’m surprised this project has gone so long with such problems in our caching on Windows. Fixing that will be a worth focusing on over the next few weeks.

@swankjesse
Thanks!  Sorry, I wasn't able to get a test working for this.  Thanks for getting the local repro.

@bitwiseman I think this is fixed on master. If you’d like to try the latest code please do!

@swankjesse Hello, I am reading and learning DiskLruCache recently. I found one thing about this commit that I don't understand, that is:
When we call Entry.newSource(), the "lockingSourceCount" will increase, but not in Editor.newSource(). If we read the cache through Editor.newSource(), will this problem happen again?


Findings metrics filter in product overview

Hi,
First of all, thank you for your work, this tool seems to be more and more popular :)
We have a small problem in our workflow, we do not understand why findings metrics in the product overview take only unverified findings.
This configuration lets think that there is no active findings on this product.
We suggest displaying all active findings and using the metrics page for advanced filters.
Thanks by advance

Hi,
Please rebase your PR on the newest dev branch. Thanks.

Hello @H4ckd4ddy, if you wouldn't mind, could you open a new PR that is originally based off the dev branch.  Thanks!

Hi, can you rebase against dev? We know there are some inconsitencies in the metrics. Today we merged another improvement: #2216
Further improvements will be done in #2215 once we agree on definitions of "active", "verified", "closed", etc.

Ok, thanks, I  close this one, and open a new PR


Test creating address spaces with a non-privileged user

Systemtests currently run as cluster-admin, which in turn does not test the permissions granted to non-admin users.
Should be tested on OpenShift 3.9 and 3.10

Started looking into this, created
https://github.com/EnMasseProject/enmasse/issues/1515 [deploying-single-address-space] link on documentation site not working
to begin with.

https://github.com/EnMasseProject/enmasse/pull/1552


Bot stops responding after 30~ or so minutes of no chat

Seems that the bot dies over time, can't really see or find any reason to why. Requires a bit of research. Failing pong?

Seems to have been a problem with twitch. Might want to make it detect stealth disconnection or something? Automatic restart also works. Suggestions appreciated.

Seems to no longer happen.


How to run a subgraph with images of different scales and accumulate their results and pass to the subsequent node?

How to run a subgraph with images of different scales (the number of scales are not fixed and is dependent on the image size) and accumulate their results and pass to the subsequent node?
In particular, my use case is to do multiscale processing for bounding box detections.

Since the number of scales is not fixed, it is likely that you have say n images. Let's keep this in a vector, so std::vector<ImageFrame> images on CPU and std::vector<GpuBuffer> images on GPU.
You can then use BeginLoopCalculator and EndLoopCalculator to iterate through a collection of such images.
Here is an example of how these calculators are used in multi-hand tracking: https://mediapipe.readthedocs.io/en/latest/multi_hand_tracking_mobile_gpu.html#multi-hand-landmark-subgraph
Another relevant github issue: https://github.com/google/mediapipe/issues/218

@yxchng Closing this issue due to inactivity. Please feel free to reopen if you have follow-up questions.


The modulation argument of CanvasItem.draw_mesh does not work.

Godot version
4.0dev (0638ca00373a7fb9e0c114ccc43eae7a17f6f61d)
System information
Arch Linux
Issue description
When drawing a mesh inside a CanvasItem the modulation argument is not taken into account.
Steps to reproduce
Create a Node2D with this script:
extends Node2D

var texture := load("res://icon.png")
var mesh := ArrayMesh.new()
var a = []

func _init():
	a.resize(Mesh.ARRAY_MAX)
	a[Mesh.ARRAY_VERTEX] = PackedVector2Array([Vector2(0, 0), Vector2(100, 0), Vector2(0, 100)])
	a[Mesh.ARRAY_TEX_UV] = PackedVector2Array([Vector2(0, 0), Vector2(1, 0), Vector2(0, 1)])
	a[Mesh.ARRAY_COLOR] = PackedColorArray([Color(1,1,1), Color(1,1,1), Color(1,1,1)])
	a[Mesh.ARRAY_INDEX] = PackedInt32Array([0, 1, 2])
	mesh.add_surface_from_arrays(Mesh.PRIMITIVE_TRIANGLES, a, [], {}, Mesh.ARRAY_FLAG_USE_2D_VERTICES)

func _draw():
	# Draw without texture
	draw_mesh(mesh, null, Transform2D(), Color(1, 0, 0, 1))

	# Draw sith texture
	var xform := Transform2D()
	xform.origin = Vector2(0, 100)
	draw_mesh(mesh, texture, xform, Color(1, 0, 0, 1))

This results in this:

Both of those should be tinted red as the modulation argument suggests.
Minimal reproduction project
Mesh2DNoModulation.zip

Was already reported at issue #49781.  As I mention in the comments, it is broken for polygon2d and line2d nodes as well, textured+textureless+vertex colors (vertex colors getting the most benefit for an individual node due to a more due to a complex setup that cannot be changed as easily as colors or textures).
They also say:

Reduz suggested that it might be intended, because the way it works has changed. In that case, it's a documentation issue about how it can be achieved now.

Although yes hopefully this can be fixed.

Ah, so the issue has several consequences then, good to know.

Is there a difference between the 2 issues you posted? Does the pull request you made fix the other situations, or is it a minor fix and that's why you assigned reduz on this issue?

Is there a difference between the 2 issues you posted? Does the pull request you made fix the other situations, or is it a minor fix and that's why you assigned reduz on this issue?

You mean https://github.com/godotengine/godot/issues/49825 ? It is an unrelated issue. I just reused the mesh drawing code as steps to reproduce as both issues happen using draw_mesh.


Auto-PR for Splink 3 -> 4 merge

After #1984 I opened a PR for the 3 -> merge (#1988). It would be nice for such a PR to open automatically, if one is not yet present, so we have one perpetually on-the-go.
This could probably run subsequent to the job from #1984 (i.e. on pushes to master) - we need to wait (afaik) until master has new commits before we are able to open one anyhow.

We aren't merging up anymore, so this is unnecessary.


buildx: install release binaries from a fork

adds a new API method that uses the github releases API to find the appropriate version to download.

loosely based on https://github.com/nicks/setup-buildx-action/commit/e277290f62e75fac3ae0447800900f75a2fe2ec5
The old approach always built from scratch, which added about 2 minutes to the CI pipeline. The new approach takes 30s (from cold cache) or 2s (if the tool is cached).

thanks @crazy-max ! I cut a new version of this PR based on your comments. After this PR:

the download() function can download binaries from private forks
the download() codepath uses the github api to fetch release. we no longer read from buildx-releases.json

PTAL?
This will also require some changes downstream to make this work (right now, setup-buildx-action doesn't even go down the download() code path if it sees a URL)


chore: jsonfmt securityinsights

Automation for azure-sdk-for-go

Automation for azure-sdk-for-python

Can one of the admins verify this patch?


Broken escape codes on Windows 10 using cmd.exe

👋🏻
I'm testing the following code:
package main

import (
	"fmt"
	"os"

	"github.com/fatih/color"
)

var Bold = color.New(color.Bold).SprintFunc()

func main() {
	s := fmt.Sprintf("Name: [%s] ", "default name")
	fmt.Fprint(os.Stdout, Bold(s))
}

On macOS the output is correctly bolded (as expected), while the output on Windows 10 cmd.exe displays:
←[1mName: [default name] ←[0m

I've noticed old issues like https://github.com/fatih/color/issues/91 where it mentions certain functions aren't supported by cmd.exe and so I'm not sure if there's a similar resolution here?
Any feedback/guidance appreciated.
Thanks.

Hi @Integralist
If you use color.Output, it should work for both macOS and Windows:
fmt.Fprint(color.Output, Bold(s))

This makes sure to use the correct parser. You can also use the handy Printxxx methods of the colow, which use the correct stdout under the hood:
Bold.Print(s)

Thanks I'll take a look at this 👍🏻

@fatih Thanks for the feedback, this appears to work but I'm just noting for future travellers that I was initially still seeing an issue with escape codes being displayed rather than rendered.
For example, using your suggestion...
fmt.Fprint(color.Output, Bold(s))

This printed fine on macOS but on Windows, although the text was 'bolded' I was seeing it prefixed with ←[0m...

Turns out this was because before that line I still had...
fmt.Fprint(os.Stdout, Bold(s))

And so I'm guessing that was not closing off the ANSI escape code properly. So doing the following would make Windows render correctly...
fmt.Fprint(os.Stdout, Bold(s))
fmt.Println("---")
fmt.Fprintf(color.Output, bold(s))

Oh! and for anyone usingos.Stderr, the equivalent to use is color.Error.

@fatih sorry to hijack this issue, but quick question, should this be working on Windows?


Remove query options from the webserver's directory listing and fix the webserver's HTML correctness

The commit messages contain more details about the individual changes. This work is preparation for upcoming refactoring of this file, which will be easier if this is out of the way first. Moreover, it makes the directory listing easier to work with for development and more similar to that of known implementations like Nginx or Apache.

/botio unittest

The ?frame option puts the directory listing in a resizable frame, but
the other side of the frame is always empty. This functionality is traced
back to the original code from commit https://github.com/mozilla/pdf.js/commit/4df24f457aceb77ab7660222253edb4d15243a61 from 2014, but even back then I doubt this was ever really used.

This mode is actually mentioned in the README, under the following section, hence it's probably not unused:
https://github.com/mozilla/pdf.js?tab=readme-ov-file#getting-the-code
Note that the point of this mode is to be able to easily open any PDF document (from test/pdfs/) in the viewer for quick testing, since clicking on the links on the right will open that PDF document directly in the viewer (on the left side).
While it's not something that I use every week (or even month), please note that it has occasionally been useful during testing/debugging since it's often the fastest way to open a number of test PDFs in the development viewer.
Also, assuming that we agree that this should be removed, is the removal complete?
For example, the following if-block seems to be written specifically for this mode:
https://github.com/mozilla/pdf.js/blob/440208daa6385b853d503a1537064ed6e04fd0e1/test/webserver.mjs#L251-L254

You're completely right, I somehow overlooked the mention in the README. The reason it didn't work for me in my testing was because I had added the <!DOCTYPE html> bit already and that actually breaks the frame solution somehow (apparently the target="pdf" bit only works in quirks mode). I still don't find the functionality really useful myself, but given that is is indeed used sometimes and mentioned in the README I don't think we should remove it.
I'll create an alternative PR soon that removes the reduced directory listing bits while keeping the frame functionality in place. Thanks for providing me with this information!


Add option to pass worker url to the ffmpeg.load

🥳

@kisel4363 I think this PR doesn't make sense as the workerURL in the config is for ffmpeg-core.worker.js, so passing the worker here doesn't work.
Can you share more context of your use case here?

Hey @jeromewu. Here's the issue I opened in the Remix repo.
https://github.com/remix-run/remix/issues/8215
Not sure if this is a Remix issue or an ffmpeg/WASM issue.
Would you be able to take a look at the reproduction repo I created (linked in the above issue)... I'm kinda stuck.

I have no experience in remix and thus don't know how to help. You can try 0.12.8 and see if assigning a custom classWorkerURL helps.

@jeromewu The fix from #652 does not seem to be in the ESM module for 0.12.8:
https://unpkg.com/browse/<EMAIL_ADDRESS>

@dchristensen Fixed in 0.12.9


Target Azure Sentinel to avoid 400 Error

Line 113 of the Connect Threat Intel Platform Sentinel docs page specifies Microsoft Sentinel as the target product, however if this is sent to the Graph API endpoint a 400 error will be returned. Using Azure Sentinel resolves the issue. Per the API docs

This issue has already been corrected in PR https://github.com/MicrosoftDocs/azure-docs-pr/pull/207301.
#please-close