Unexpected validation of nested generic models

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
When using nested generic models A and B, if the nested object is initialized with the generic type unspecified (or not identical to , it will fail to validate in the parent model, regardless if it would be possible through coercsion.
pydantic_core._pydantic_core.ValidationError: 1 validation error for B[int]
b
  Input should be a valid dictionary or instance of A[int] [type=model_type, input_value=A(a=2), input_type=A]
    For further information visit https://errors.pydantic.dev/2.0.2/v/model_type

I'm not sure if I am stating this correctly or if this is unreasonable behavior to expect.
Example Code
from pydantic import BaseModel, TypeAdapter
from typing import Generic, TypeVar, Any

T = TypeVar("T")

class A(BaseModel, Generic[T]):
    a: T

class B(BaseModel, Generic[T]):
    b: A

if __name__ == "__main__":
    a = A.model_validate({"a": 2})

    # this works as expected
    b = B[int].model_validate({"b": {"a": 2}})

    # this does not
    b = B[int].model_validate({"b": a})

Python, Pydantic & OS Version
pydantic version: 2.0.1
        pydantic-core version: 2.0.2 release build profile
                 install path: ****
               python version: 3.11.1 (tags/v3.11.1:a7a450f, Dec  6 2022, 19:58:39) [MSC v.1934 64 bit (AMD64)]
                     platform: Windows-10-10.0.19045-SP0
     optional deps. installed: ['typing-extensions']

Selected Assignee: @adriangb

@dmontagu transferred this to you since it's recursive generics

Okay, I think there's a couple things going on here:

First, Pydantic creates subclasses any time you subclass with something besides the exact parameter inputs. As a result, A[int] is a proper subclass of A, so instances of A, such as that created with a = A.model_validate({"a": 2}), are not instances of A[int]. For reasons that require going into a bit more detail (which I will do below), right now, your B[int] model has the field a: A[int], i.e., the typevar of A there is bound to int, not unbound as you might expect. Because of that, you are getting an error that the instance you are passing isn't a subclass of the model class it should be.
For a while, I've been suggesting that we change the way generics work in pydantic so that instances of A[<Thing1>] can be validated into instances of A[<Thing2>] regardless of the relationship between Thing1 and Thing2, just revalidation will happen if they aren't the same. This would make a lot of standard behavior work better, e.g., your script above. However, that would require some tweaks in pydantic core that might be difficult to implement without significant performance consequences, so I don't know whether that will be viable in the short term.
If your intent was that the parameter on A should be the same as the parameter on B, namely, if you meant:
from pydantic import BaseModel, TypeAdapter
from typing import Generic, TypeVar, Any

T = TypeVar("T")

class A(BaseModel, Generic[T]):
    a: T

class B(BaseModel, Generic[T]):
    b: A[T]

then you may be able to fix this by just doing a = A[int].model_validate({"a": 2}).

The second issue here is that we don't currently handle typevar scopes properly. In particular, even though there is no T on the A annotation in the definition of B, pydantic currently sees A and A[T] as equivalent, so your b: A is seen by pydantic as b: A[T], which obviously is a bit different in meaning.
This is probably going to be challenging to deal with in general and I think the best option for this may just be to tolerate some misbehavior for now and wait for PEP 695, which I think will largely resolve this if you use the new syntax it will introduce. (To be clear, I'm definitely open to a PR that fixes this misbehavior, just I think it might be hard. But maybe there's a smart way to do it better.)
But, if you don't intend for A and B to have the same parameter, then probably the easiest way to deal with this today is to just use different typevars for the two classes:
from pydantic import BaseModel, TypeAdapter
from typing import Generic, TypeVar, Any

T = TypeVar("T")

class A(BaseModel, Generic[T]):
    a: T

S = TypeVar("S")

class B(BaseModel, Generic[S]):
    b: A

if __name__ == "__main__":
    a = A.model_validate({"a": 2})
    b = B[int].model_validate({"b": {"a": 2}})  # OK
    b = B[int].model_validate({"b": a})  # OK

Let me know if I've misunderstood your problem and even given the above you don't have a work-around or aren't satisfied with these suggestions.
I think between PEP 695, the existence of workarounds, and potential future refactors to pydantic generics that might resolve this issue in other ways, I think fixing this "properly" today is not currently a very high priority (though as mentioned above I'd be happy to review a PR attempting to fix it even today). I'd be happy to treat this issue with higher priority if there is broad interest though.

This might be a separate issue with subclasses, but I also ran into this today:
from pydantic import BaseModel
from typing import Any

class A[T](BaseModel):
    my_a: 'A[Any] | None' = None
    my_as: list['A[Any]'] = []
    my_field: T

class Subclass[T](A[T]):
    pass

a = A(my_field=123)  # ok
b = Subclass(my_field="abc")  # ok
a2 = A(my_field=123, my_a=a)  # ok
a3 = A(my_field=123, my_a=b)  # ok
a4 = A(my_field=123, my_as=[a, b])  # ok
a5 = Subclass(my_field=123, my_a=a)  # not ok
a6 = Subclass(my_field=123, my_as=[a, b])  # not ok


Synchronized with a bug fix in sphinx_auto_embed; added a new example; reorganized the example doc structure

…; reorganized examples to be more modular

:white_check_mark: Build SMT 0.1.215 completed (commit https://github.com/SMTorg/SMT/commit/510bf2348a by @)

:white_check_mark: Build SMT 0.1.216 completed (commit https://github.com/SMTorg/SMT/commit/d16a9f7d3b by @)


mapping scheme from Service ports to ports that Envoy listens on

We'll need to sort out how ports on the service map to ports that Envoy listens on. Right now they're 1:1, but I imagine inside the Envoy container we'll want to listen on e.g. 8080/8443, and then have the Service map 80->8080 and 443->8443. However, since we need to handle arbitrary ports, not just those two, we'll need some kind of mapping scheme. I'll file an issue for this.
Originally posted by @skriss in https://github.com/envoyproxy/gateway/pull/188#discussion_r937085989

Currently, gateway.spec.listeners[].port is processed differently between xds and infra IRs. The infra IR uses this port for the Kube Envoy service port. The xds IR uses this port for envoy listeners.
Option 1
Have the xds IR use the container ports of the envoy pod for listener ports when provider=Kube. To accomplish this, the continerPorts can be configurable (defaulting to http=8080/https=8443) through the EnvoyProxy API. The EnvoyProxy is referenced by the managed GatewayClass. If unreferenced the xds IR should use the default ports for Envoy listeners. Otherwise, get the ports from referenced EnvoyProxy.
Option 2:
Keep the xds IR as-is. Instead, have the infra IR use gateway.spec.listeners[].port to configure Envoy's containerPorts instead of Envoy service ports. Instead, have the service ports configurable (defaulting to http=80/https=443) through the EnvoyProxy API. The EnvoyProxy is referenced by the managed GatewayClass. If unreferenced the infra IR should use the default ports for the Envoy container ports. Otherwise, get the container ports from referenced EnvoyProxy.

the good news here is that EG can the flexibility to control Service->Container port mappings.
for every service port / gateway listener port , the gateway api translator could generate a container port (which might need to be in the unprivileged port range 1024-65535)
the gatewayapi translator needs to pass the service port and the container port to the Infra manager via the infra IR
the gatewayapi translator needs to pass the container port in the Xds IR


[helpers] Fix TrimShortHTML

Fixes #7081
where some tags are siblings of p tag

The fix looks good, but you could help me by getting the commit message into shape.
For this PR I would write something ala:
helpers: Fix TrimShortHTML

Where some tags are siblings of p tag.

Fixes #7081

Theimportant part being the title and the "Fixes" syntax.

Fixed
I must be careful about it. Thanks

That's a pretty slick solution.


Consider Glium backend

Unlikely to be possible, just something to keep an eye on.
cc @tomaka

I totally lost track of the internal design of gfx, but I think this is possible.
I'm not opposed to adding low-level things in glium (unsafe or not).

@tomaka thanks, sounds promising :) It would be rather useless if not for the high-level stuff that I'm doing, which I'd like Glium users to have access to as well.

What I mean is that gfx is already converting high-level things into low-level things. So in order to write a glium backend, glium may have to have to accept more low-level things.

I am curious about the overhead of converting the draw state. Piston-Graphics needs this for glium_graphics so we could use it as a test case to see whether a Glium back-end is a good idea?

@bvssvni that would be a great start!

Isn't a Glium back-end quite redundant, given that every platform Glium supports, is automatically supported by OpenGL? Seems like a lot of effort for no benefits.
If it means replacing the OpenGL back-end with Glium, then it's a completely different story of course.

I don't think this is an option/reasonable anymore due to our new low level direction.


Add limitation for React client beta

This PR adds a limitation to the PDF Document Generation module documentation related to the new React client that will be introduced with the 10.7.0 release as a public beta.

Looks good @allard-mx . Please file another PR to this doc when the React stuff is enabled and we'll be sure to remove this limitation.


Reduce the Scope of variables

Security: Refactorize the code to ensure that each variable has the least possible scope.

Solved in commit https://github.com/DavidDuranPerez/Simulator_Casio_fx-82MS/commit/e895816d7986657484a6a875b8e23a71820ffceb


Update roboto-font-path to be relative to the package name

This allows the mixin to avoid using relative URLs. This is troublesome when using tools like webpack.

Hmm. But this only works with webpack. And this package is not webpack specifiy. Also you can just override the $roboto-font-path variable to be ~roboto-fontface/fonts without having to change it here in the package itself. This way you have what you want and this package stays compatible with non-webpack use cases.

@choffmeister Has a good point. Closing this pull request. Thanks!


feat: support Inline policies

what

support inline policies

why

no need for reusable policies

references

closes #78

/terratest

/terratest


Add Sign in with GitHub headful lite to sample app

Test failed at FIRInstanceIDTokenManagerTest, which is irrelevant to our code. Submitting.


Use in MarqueeLabel?

Hi, beautiful fonts. I wonder if there is a way to use them within another class -- one that performs an animation of the label? Thanks

Each of classes in this package is not a UILabel subclass but a custom UIView.
So if the animation manager requires UILabel,  I guess they don't work as expected.


feat: Record passed status for challenges

Closed #78

@laike9m 搜了一下 jotai 似乎没有直接通过 CDN 引入然后直接使用的示例或相关文档，所以我就没有暂时没有尝试了；最后简单实现了一下效果如下所示：

完成的 icon 放在了右侧，这样就可以暂时不用动 Sidebar 里面文字的布局了，比较省时省力

Sorry, I thought this PR is WIP so I didn't review it. Is it ready for review?

Sorry, I thought this PR is WIP so I didn't review it. Is it ready for review?

Yes, it is.

The original density of the challenge list feels right to me, I'd rather we don't change it. Could you change it back?
I haven't finished reading the implementation, should be done tomorrow.

Density? Which part of css style do you refer? Padding, margin or width?

Old

New

See the paddings in the left sidebar

A design question:
Right now we basically have two copies of state, one in PassedState._state, one in localStorage. There's a bunch of code just for syncing the two states.
I'm wondering, is it possible to remove PassedState._state, and just use localStorage as the single source of truth? e.g. when a test passed, update localStorage directly. I feel if implemented this way, the code can be hugely simplified.
Performance should be the same, since we need to update localStorage anyway. Even if not, it shouldn't matter here.
See if it makes sense to you. Happy to discuss more.

@laike9m Done

Is it possible to reduce the empty space between challenge name and the check mark?

The sidebar is a lot wider than before

There's a bug with challenge selection: previous highlight does not disappear

This is because we set <script type="module"></script> to import passedState from a module, so HTMX can't refer the global removeHighlight function, it has been put to local scope.

There's a bug with challenge selection: previous highlight does not disappear

This is because we set <script type="module"></script> to import passedState from a module, so element can't refer the global removeHighlight function, it has been put to local scope.

I have fixed this bug temporarily by splitting the one script tag in challenge-sidebar.html into modular and global script tag.
But some unknown potential issues will be raised in sometime because of the scope. For this situation, maybe the better choice is to switch to JavaScript tool(like Vite) to solve.

There's a bug with challenge selection: previous highlight does not disappear

This is because we set <script type="module"></script> to import passedState from a module, so element can't refer the global removeHighlight function, it has been put to local scope.

I have fixed this bug temporarily by splitting the one script tag in challenge-sidebar.html into modular and global script tag.
But some unknown potential issues will be raised in sometime because of the scope. For this situation, maybe the better choice is to switch to JavaScript tool(like Vite) to solve.

I think at this point, bring in tools like Vite might be something we can try (with the assumption that it doesn't increase the complexity of managing things. btw TS is still no-go). I can take a look at it.
The bigger concern is whether Zeabur supports a project with both Python and Node.js environment. I'm not so sure @MichaelYuhe


Problem with clone catalog

Rancher Versions:
Server: 1.5.1
healthcheck: rancher/healthcheck:v0.2.3
ipsec: rancher/net:v0.9.4
network-services: rancher/network-manager:v0.4.8
scheduler: rancher/scheduler:v0.7.4
Docker Version:
Docker version 17.03.0-ce, build 60ccb22
OS and where are the hosts located? (cloud, bare metal, etc):
Private dedicated server
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node, internal DB
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
I restart docker server, reboot host. Few times. After this I was try to download my templates. Don't work. I getting errors:
time="2017-04-01T15:01:28Z" level=error msg="Failed to update existing repo cache: exit status 128"
When I go to catalog/community and click to refresh. It refreshing some time, but after that time icon change to triangle. I get this:
time="2017-04-01T14:57:02Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:57:04Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:57:13Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:57:22Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:57:24Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:57:35Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:57:43Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:57:44Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:57:55Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:58:03Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:58:16Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:58:23Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:58:38Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:58:44Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:58:58Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:59:05Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:59:18Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:59:25Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:59:40Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T14:59:46Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T15:00:00Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T15:00:06Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T15:00:09Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T15:00:20Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T15:00:26Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T15:00:29Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T15:00:42Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T15:00:47Z" level=error msg="Failed to update existing repo cache: exit status 128"
time="2017-04-01T15:00:49Z" level=error msg="Failed to update existing repo cache: exit status 128"
Even when I don't refresh. Of course when I changeing my private templates nothing happen.
I try to git pull in /var/lib/cattle/cache/global/{id}/ but get this:
fatal: unable to access 'https://github.com/my-public-repo/': Could not resolve host: github.com
ping google.pl not working. Of course in docker rancher-server.
Someone can help?

I'm getting similar error, I don't see any catalogs on dashboard..I tried adding internal git repos but it is still not working.
I'm using Rancher: 1.5.3-try2 version. I'm seeing below errors in my log file.
I'm using rancher server built on top of redhat-7 base image.
2017-04-05 20:13:20,653 ERROR [:] [] [] [] [ecutorService-1] [i.c.p.task.impl.TaskManagerImpl     ] Task [run.scheduled] failed io.cattle.platform.lock.exception.FailedToAcquireLockException: Failed to acquire lock [SCHEDULED.UPGRADE]
	at io.cattle.platform.lock.provider.impl.StandardLock.lock(StandardLock.java:56) ~[cattle-framework-lock-0.5.0-SNAPSHOT.jar:na]
	at io.cattle.platform.lock.impl.AbstractLockManagerImpl$1.withLock(AbstractLockManagerImpl.java:17) ~[cattle-framework-lock-0.5.0-SNAPSHOT.jar:na]
	at io.cattle.platform.lock.impl.LockManagerImpl.doLock(LockManagerImpl.java:30) ~[cattle-framework-lock-0.5.0-SNAPSHOT.jar:na]
	at io.cattle.platform.lock.impl.AbstractLockManagerImpl.lock(AbstractLockManagerImpl.java:13) ~[cattle-framework-lock-0.5.0-SNAPSHOT.jar:na]
	at io.cattle.platform.lock.impl.AbstractLockManagerImpl.lock(AbstractLockManagerImpl.java:37) ~[cattle-framework-lock-0.5.0-SNAPSHOT.jar:na]
	at io.cattle.platform.systemstack.service.UpgradeManager.run(UpgradeManager.java:112) ~[cattle-system-stack-0.5.0-SNAPSHOT.jar:na]
	at io.cattle.platform.systemstack.task.RunScheduledTask.run(RunScheduledTask.java:23) ~[cattle-system-stack-0.5.0-SNAPSHOT.jar:na]
	at io.cattle.platform.task.impl.TaskManagerImpl$1.doRun(TaskManagerImpl.java:100) ~[cattle-framework-system-task-0.5.0-SNAPSHOT.jar:na]
	at org.apache.cloudstack.managed.context.NoExceptionRunnable.runInContext(NoExceptionRunnable.java:15) [cattle-framework-managed-context-0.5.0-SNAPSHOT.jar:na]
	at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) [cattle-framework-managed-context-0.5.0-SNAPSHOT.jar:na]
	at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55) [cattle-framework-managed-context-0.5.0-SNAPSHOT.jar:na]
	at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:108) [cattle-framework-managed-context-0.5.0-SNAPSHOT.jar:na]
	at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52) [cattle-framework-managed-context-0.5.0-SNAPSHOT.jar:na]
	at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) [cattle-framework-managed-context-0.5.0-SNAPSHOT.jar:na]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [na:1.8.0_121]
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308) [na:1.8.0_121]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180) [na:1.8.0_121]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294) [na:1.8.0_121]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [na:1.8.0_121]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_121]
	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_121]
time="2017-04-05T20:13:20Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:21Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:21Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:22Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:23Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:23Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:24Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:25Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:25Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:26Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:27Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:27Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:28Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:29Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:29Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:30Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:31Z" level=error msg="Failed to update existing repo cache: exit status 129"
time="2017-04-05T20:13:31Z" level=error msg="Failed to update existing repo cache: exit status 129"

This is My Dockerfile

https://gist.github.com/rammaram06/2e9e589d2ffc53a34ee6a80015effcd5

contents of /var/lib/cattle from official rancher server image

contents of /var/lib/cattle from image built on redhat 7

local.db file is missing on the redhat Image I built, could you pls let me know what I'm missing in my Dockerfile

`
root@02d7ffe10735:/# ls -la /var/lib/cattle
total 5156
drwxr-xr-x  4 root root    4096 Apr  4 22:24 .
drwxr-xr-x 36 root root    4096 Mar 24 16:35 ..
drwxr-xr-x  3 root root    4096 Mar 24 16:37 cache
-rw-r--r--  1 root root      36 Apr  4 22:23 cluster-id
-rw-r--r--  1 root root     105 Apr  4 22:22 keys.properties
-rw-r--r--  1 root root 5246976 Mar 24 16:37 local.db
drwxr-xr-x  2 root root    4096 Apr  5 00:00 logs
-rw-r--r--  1 root root       0 Apr  4 22:23 master.conf
-rw-r--r--  1 root root      32 Apr  4 22:24 rancher
-rw-r--r--  1 root root     350 Apr  4 22:24 repo.json
`
Here i have local.db. I remove all images and containers and still not working. Before I was using 1.2 rancher and all was fine. Maybe it crash when I upgrade?

Same problem as #8372 maybe?

Thanks for comment. I will check database. I have different errors but maybe it will help :) Thanks for advice.

Having the same problem. Everything else seems to be working just fine, but the custom catalogue is unreachable. The log pretty much shows the same thing.

I managed to resolve the issue. The git repository we were storing our catalog was private. For some reason, though, the private key installed on the rancher server (in ./ssh/*) was not working. In case somebody else is having similar issues - try fixing your key.

I was able to solve my issue..redhat 7 had old version of git and it caused the issue. After upgrading it, everything working well.

@rammaram06  what version of Redhat and git version that fixed this problem ?

Please reply if you still run into anything.

In case other people hits this problem:
I also had this error and our problem was because of an existing .git/index.lock in cached repo.
So in our Rancher container, we looked for our custom catalog repo in /var/lib/cattle/cache/global/.
git pull gave us following error:
fatal: Unable to create '/var/lib/cattle/cache/global/c55dba93ce64e96ccc91a3c81ff18c39/.git/index.lock': File exists.

If no other git process is currently running, this probably means a
git process crashed in this repository earlier. Make sure no other git
process is running and remove the file manually to continue.

We just deleted this .git/index.lock and everything went fine :-)


Chrome Install Issue

In case you didn't realize, Chrome does not allow .crx files to be installed and enabled from the extension screen anymore, only from the webstore. I had to unpack it and load it as an unpacked extension in developer mode for it to work. The easy fix would be to upload it to the store.

Excellent extension though!!

Thanks for letting me know! I uploaded the zip to Google drive and replaced the link on the original Reddit post.


Add some missing properties in typings

These are used in this JSFiddle so they had to be added to the typings. Note that there may be quite a few more properties missing, but I'm not sure where the complete list of possible properties would be listed. Are you aware of such a list? If so, I'll amend this PR with the full list of properties.

It's hard to aggregate all the available properties from MDL since preact-mdl mostly acts as a passthrough in that regard.  I was pulling them from their components list.


URLs are case sensitive

URLs shouldn't be case sensitive, it just feels wrong. Might be helpful:
http://stackoverflow.com/questions/12684183/case-insensitive-mapping-for-spring-mvc-requestmapping-annotations

OK, I'll put this on the list of things to implement

@spara was this fixed?

Fixed in https://github.com/dockersamples/atsea-sample-shop-app/commit/addb0c85dc808b3a7602805343a1ea29cd6d79a1


Question: Is is possible to parse/serialize to/from java.util.Map?

Hi,
I'd like to serialize/parse between java.util.Map and  JSON string. And following codes don't work because I did not set annotations. Is is possible to parse/serialize to/from java.util.Map? If yes, how can I do it?
Serialize
Map<String, Object> map = new HashMap<String,Object>();
map.put("key", 1);
String json = LoganSquare.serialize(map);

Parse
String json = "{\"key\":1}";
Map<String, Object> map = LoganSquare.parse(json, Map.class);

Thanks,

The reason for this library's existence is to help developers create proper models and stick to good OOP practices, and to have those models parse extremely quickly. Since parsing/serializting directly to/from a dictionary is exactly what this library is trying to help developers get away from, it will not be supported at any time.

@EricKuck Thank you for your response!


Whether to consider adding log collection？

use elk on k8s.

ELK is not an option for Kubernetes, the official way of doing log collection is with Fluentd and based on your cloud vendor you would use Cloudwatch or Stakdriver. For on-prem/bare-metal setup you would use ElasticSearch.
From an application perspective as log as you log in JSON format like podinfo does, Fluentd will push those logs into whatever backend you use.


Chrome security fix tracking?

The classic argument against non-mainstream browsers is the mainstream (FF & Chrome) have big security teams rolling out patches the quickest. How long does ungoogled-chromium typically take to apply upstream security patches? (And I guess a subset would be a comparison between upstream security patches of chrome vs chromium.)
Thanks!

The real question is how long it takes us to remove the tracking stuff that gets added on each release as all security stuff is done on the chromium side.
The answer to that is there is no fixed time since everyone here helps when they have free time.

Short answer: It depends. At the time of writing, maybe 1-2 weeks for major updates, less for small revisions. Please note that these numbers have a large variance, and change over time.
Longer answer:
First, Chrome is just Chromium, with some more Google-specific changes (notably Google API keys, Widevine DRM). There is very little difference in amount of code, and no difference in versioning between them.
Small Chromium revisions are quick because there usually isn't any code we need to change, aside from the Chromium version to build with.
Major updates can take some time because the Chromium codebase can change quite a bit. In addition, Google has been making changes that make our patches grow larger (notably Safe Browsing), which increases the time it takes to update.
In addition, everyone here is an anonymous independent contributor. There is no formal organization of any kind, and definitely no obligations from anyone.
Let us know if you have more questions.


Support optional adopting ownership of AWS cred secret (possibly SSH keys as well)

SD would like to have the AWS creds secret go away with the cluster deployment. We did not support this as we thought creds would be shared by multiple clusters. However optionally we could add a boolean to the cluster deployment spec indicating it should adopt and own the AWS creds secret. (and probably ssh key secret as well) Controller could then make sure we own these objects as soon as it's possible to do so.

Discussed with team, we're thinking this may not have much good precedent, so maybe it's best for you guys to assign the ownership yourselves over the API per the link I sent earlier today. https://github.com/openshift/hive/blob/master/contrib/pkg/installmanager/installmanager.go#L406
We can come back to this in future if needed.
How do you all plan to use namespaces?

We plan to create all objects in one namespace.
(We considered namespace-per-cluster vs putting everything in one namespace.  We figured we might not get permissions to create namespaces.)
permalink for above link to SetControllerReference() usage: https://github.com/openshift/hive/blob/54021425ba626acc45fce92b5b43a848c0e46ac7/contrib/pkg/installmanager/installmanager.go#L406

I would recommend against everything in one namespace personally, I'd honestly rank that as the last option available. It's going to be really hard to debug, I don't necessarily know how it will scale, it's the least effective for protecting data in the event something is compromised, and there's more risk things will collide or someone will see something they shouldn't. Hive was designed for either (a) one customer account per namespace (potentially multiple clusters), or (b) one account per cluster. Both will give you much stronger separation of data.
We can definitely get you permissions to create and delete namespaces.

About sharing secrets: our use case for wrapping Hive treats each cluster as fully independent, so we independent secrets per cluster.

aws creds are provided by customers, their choice to provide same or different creds...
pull secret is per customer, but our component won't store it and won't assume it, we'll get it from the user management component for each cluster creation request.  It's easier for us to create separate secrets per cluster.
SSH keys we generate for each cluster.
IIRC admin creds secret is generated by Hive per cluster, right?  For GC, is it owned by Hive?

@jhernand @nimrodshn see https://github.com/openshift/hive/issues/109#issuecomment-441697526 let's reconsider using namespaces?

The reason to not use namespaces is that the administrators of the clusters where we deploy our application don't want to give us permission to create/delete namespaces. And I kind of understand it. If we had that permission then we could accidentally delete other important namespaces. In addition we would need much broader permissions. For example, currently we need permissions to read/write secrets in one particular namespace, and we use a role binding for that, inside the relevant namespace. If we create a namespace per cluster then we would need permissions to read/write secrets in all namespaces, as we don't know the names of the namespaces in advance. Not sure if there is a way to limit this kind of permission to a set of namespaces, for example to all the namespaces starting with uhc-. @dgoodwin note that currently you are the owner of the production Hive cluster, so you may want to think that twice.
@cben @zgalor @nimrodshn @tzvatot I think that if we implement this it should be configurable, so that we can easily (with a command line option?) change from using namespaces to not using them, because I am afraid that this decision to allow us to create namespaces may change if the team that administers Hive changes.
Regarding the clean-up of secrets, we generate all of them, so we can clean-up them ourselves, it isn't a big deal.

Closing per above, SD will own their own secrets for now.
Namespace discussion will continue elsewhere.


Figma stress of all components using testing checklist

Summary
Use the component contribution checklist to ensure all 36 existing components are behaving as expected.
💬 Description
As a starting point, use the contribution checklist to validate existence components. Subsequently, try out all variants, props, and settings to ensure intended behaviour is executed.
💰 User value
More stable experience in both Figma components and potentially any follow through into developed components.
📚 User Stories
N/A
📝 Acceptance Criteria
All 36 components tested.
Outcomes documented per component with indication as to whether fix made, or work required to fix. This will be the basis for further tickets if necessary.
✏ Designs
If there's a Figma design file (or other mock-up), include it here.
## 🧾 Guidance
If there's written guidance or documentation, include a link to it here.
Additional info
Tell us anything else useful to help us understand your suggestion.

Completed. Further tickets being created from work done in this ticket.


RHINENG-13972 suggestions engine server setup

PR Title :boom:
Server setup for Suggestions Engine (renamed from PCP Generator).
Why do we need this change? :thought_balloon:
Please include the context of this change here.
Documentation update? :memo:

[ ] Yes
[X] No

Security Checklist :lock:
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
:guardsman: Checklist :dart:

[ ] Bugfix
[X] New Feature
[ ] Refactor
[ ] Unittests Added
[ ] DRY code
[ ] Dependency Added
[ ] DB Migration Added

Additional :mega:
Feel free to add any other relevant details such as links, notes, screenshots, here.

Merging the PR, @upadhyeammit. Thanks for the review!


ignored_packages not woking in Preferences.sublime-settings in project folder

I create a Preferences.sublime-settings in project's folder, and want to ignored some packages ONLY in this project. but not working.

The ignored_packages setting cannot be controlled by this package as it is an application-global setting that affects all windows/tabs.


Correct mistake in hoverNodeId

PR #8081 lost original functionality of hoverNodeId. This adds condition to make sure original functionality is preserved.
@miq-bot add_label ui, bug
@h-kataria please review.

@h-kataria just the error about rightNid being undefined. The quadicon issue is more complicated.

looks good.


Card titles should indicate Wrath metaupgrades

It would be nice to have some sort of indicator in the card title when Wrath causes a damage increase to a card. Current proposal would be to update the card render() to look for the presence of wrath upgrades and, if present, render an overlay image that adds a wrath icon to the top-right corner and render the increase count on top of that, similar to how rendering energy cost works.

Note that Wrath can upgrade base game colorless cards! So this will need to be implemented with SpirePatches on AbstractCard, not with overrides in CustomJorbsModCard.

Implemented in 3fd9aa2

Maybe move the text a tiny bit to the right. What say ye?

Yes to both

Moved text slightly right, still need to do the portrait-view bit

fixed as of 2dcb32a


market_order can not pass validation

client = Client(config.account['key'], config.account['secret'])
order = client.order_market_buy(
    symbol='BCPTBNB',
    quantity=1,
    #newOrderRespType='FULL'
    )

and I got following, but market order just has no 'price' parameter
Traceback (most recent call last):
  File "test.py", line 18, in <module>
    quantity=1,
  File "C:\Python27\lib\site-packages\binance\client.py", line 650, in order_market_buy
    return self.order_market(disable_validation=disable_validation, **params)
  File "C:\Python27\lib\site-packages\binance\client.py", line 619, in order_market
    return self.create_order(disable_validation=disable_validation, **params)
  File "C:\Python27\lib\site-packages\binance\client.py", line 465, in create_order
    validate_order(params, self._products)
  File "C:\Python27\lib\site-packages\binance\validation.py", line 40, in validate_order
    price = float(params['price'])
KeyError: 'price'

@duduzhu v0.3.8 fixes the market order validation.


Do not treat errors as decoder exception

Motivation: Today when Netty encounters a general error while decoding it treats this as a decoder exception. However, for fatal causes this should not be treated as such, instead the fatal error should be carried up the stack without the callee having to unwind causes.
Modifications: Instead of translating any error to a decoder exception, we let those unwind out the stack (note that finally blocks still execute).
Result: Fatal errors will not be treated as innocent decoder exceptions.
Relates #6096

@jasontedor I like the change and imho its a good start in the right direction. Did you also check all the other decoder / encoders to ensure the same is done there ?

Did you also check all the other decoder / encoders to ensure the same is done there ?

No, this specific one is hurting us right now as some of our users are seeing decoder exceptions hiding out of memory errors and I want to get a fix in quickly. I can take a more careful look at the others soon.

@normanmaurer I've now checked all the other places and I have another patch ready to push. My preference would be to get this PR in (since it's ready) and then I can immediately open a follow-up. What do you think?

@jasontedor works for me...

Cherry-picked into 4.1 (5eca326c3568566f334b31b18f7866af19a989c8) and 4.0 (4ad6ed17ebb62959c382b8d9372372e2911c68f6) . @jasontedor thanks


separate Visit and MOAB classes

Separate the first step (generate visit files) from the second step (create geometry with PyMOAB) by creating two separate classes.
Steps can be linked by writing out a file containing data like level values, etc.

addressed by #33


C1.87.1

did it again this is what i get following these steps

https://app.codeship.com/projects/ed6528c0-4705-0138-52f2-023a8cbf32f1/builds/084357a3-1c0a-4897-9455-2bee8f1edae0


error FS0193: internal error: Method not found: 'FileSystem Shim.get_FileSystem()'.  running tests

If you see an error like this: when running AppVeyor it is because the version of fsharp.compiler.dll is loaded from the GAC rather than the LKG directory.
C:\Microsoft>"C:\Microsoft\visualfsharp\tests\..\lkg\FSharp-14.0.23413.0\bin\Fsi.exe" --exec --nologo "C:\Microsoft\visualfsh
arp\tests\\Convert-NUnit2Args-to-NUnit3Where.fsx" -- "Smoke" "ReqPP,NOOPEN,NO_CI,Expensive"

error FS0193: internal error: Method not found: 'FileSystem Shim.get_FileSystem()'.
```

When we created the LKG we used a preview of the compiler that had some of Don's recent reformatting PR's in it, rather than the DEV15 RTM version, it had a bug fix we wanted to use.

I think the solution is to for us to downgrade the LKG to the RTM version of the compiler:

Kevin

It would appear that I have installed a preview on my machine with the refactored code.  So be careful using the previews.

The sooner we have an entirely coreclr based LKG the sooner I will like it.

It would appear that I have installed a preview on my machine with the refactored code. So be careful using the previews.

I think this is because of this line in appveyor-build.cmd:
call vsintegration\update-vsintegration.cmd release

As noted in DEVGUIDE.md this clobbers the installed F# SDK on the machine under c:\Program Files and is thus highly invasive on the VS installation.  I don't think this should be necessary to run tests.
I'm going to submit a PR to remove this line and see if CI testing still passes.

See @enricosada's comment  https://github.com/Microsoft/visualfsharp/pull/904#issuecomment-175637484 The
call vsintegration\update-vsintegration.cmd release

was added to support testing of portable templates, and it's possible that command needs to be run prior to a full test run.  However that currently means that anyone following the DEVGUIDE.md instructions will trash the F# installation on their machine irrevocably.
I think we should remove this line from the Appveyor and Jenkins CI for now (by pulling this PR) and add instructions in TESTGUIDE.md that it may be needed prior to some specific tests.

@dsyme I would prefer a better solution than just removing the line and not running all of the tests.  I expect it's quite easily solvable using msbuild and binding redirect magic.
It's just a matter of someone figuring out the magic.

@KevinRansom i think it's not needed for ci build in appveyor-build.cmd
the only vs test we run are the unit test,  no need for portable lib and update-vsintegration.cmd (i think)
if '%TEST_VS%' == '1' (
%_msbuildexe% vsintegration\fsharp-vsintegration-unittests-build.proj /p:Configuration=Release
@if ERRORLEVEL 1 echo Error: VS integration unit tests build failed && goto :failure
)

.
The others vs test are not run, see appveyor-build.cmd@350
rem tests for TEST_VS are not executed

@KevinRansom I agree we need to get to the point where we can safely run all tests in CI and on people's dev machines (though preferably without overwriting the installed VS bits under Program Files)

Closing this since #904 was already pulled.


fix(#255): enable probe() to accept params as list or object

Includes tests for probe().

@ayuwono, this fixes documents.probe() so that it can accept params as a list or an object. It also adds tests  for probe() (including tests using transactions) to test-basic. Can you review?

Looks good to me Mike


Add Danish translations

This adds Danish translations for the strings in notifications.html and notifications_bootstrap.html

Coverage remained the same at 97.255% when pulling d81be016b54be5d174214440a16fd4529b69f5cc on madsweitling:master into 3c5e48b0411f61e2061e294ad60d5ab2edff05b4 on arteria:master.

Tanks @madsweitling
Your changes will be available in the next release 👍


Added order ID to the data that gets sent to the receipt email template

Pre-Flight checklist

[X] Testing

[X] Code is tested
[X] Changes have been manually tested

What are the relevant tickets?
#619
What's this PR do?
Adds the order ID to the email receipt template so that the link to the online receipt works, and adjusts the generated URL so that the page loads properly.
How should this be manually tested?
Complete a purchase. The link in the sentence "You can also access your receipt by clicking here" should include an ID and should take you to the correct order history page.

Codecov Report

Merging #679 (b83a87e) into main (9de6d6c) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head b83a87e differs from pull request most recent head 09ba59f. Consider uploading reports for the commit 09ba59f to get more accurate results

@@           Coverage Diff           @@
##             main     #679   +/-   ##
=======================================
  Coverage   85.84%   85.84%
=======================================
  Files         124      124
  Lines        5424     5424
  Branches      875      875
=======================================
  Hits         4656     4656
  Misses        630      630
  Partials      138      138

Impacted Files
Coverage Δ

ecommerce/mail_api.py
90.47% <ø> (ø)

ecommerce/discounts.py
77.19% <0.00%> (-1.76%)
:arrow_down:

ecommerce/views/v0/__init__.py
74.43% <0.00%> (+0.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de6d6c...09ba59f. Read the comment docs.


Module can not get prices

Hi there
First of all thank you for this module.
It worked fine for at least 6 months.
Unfortunately since 2 weeks I am getting on the module in the mirror the following message:
Getting metal prices.
It seams there is a problem with the page the module is getting the prices from, because if you go to the page
https://api.metals.live/
you get the error massage 502 Bad Gateway
If you could find a fix for it, that would be great.
Thank you in advance

There is nothing I can do. This is the equivalent of saying "Github is down, fix it!" There's nothing for me to fix. The API is down. It has been for days, maybe weeks. I don't know who runs the API, and therefore don't have a way to contact them. I have looked for other free alternatives and have not found any.
If you can find a free alternative, feel free to post it here and I can attempt to change the code to use a different API. But unless another free metals API is found, we're at the mercy of whoever runs metals.live

Have you looked at https://rapidapi.com/solutionsbynotnull/api/live-metal-prices/pricing (50/mo free) or https://metals.dev/pricing (250/mo free)?  Daily or 2/x daily would be better than nothing.  I have used other APIs through rapidapi and have not had any trouble.  Of course, both would require the user to get an API key.

I have updated to use api.metals.dev. New version is available. ReadMe has been updated to reflect the new changes.


Is this useful for Chinese text image?

Is this useful for Chinese text image?

I am sorry to inform you that because all the PSNs mentioned in our paper are pre-trained on TextZoom, which is an English dataset, we also only test the ability of our model on this dataset. So, I am not sure whether our model works well on Chinese text images. However, if you have a PSN pre-trained on a Chinese dataset, I think you can try to train our model by yourself following our paper. Parhaps it can also works well on that dataset.


May 2024 endgame

Endgame Template

Thursday

[x] Ensure that any CI test failures have issues assigned to that area's owner.
[x] Work with the build champ to drive the build to green by fixing/disabling tests or pinging area owners to do so.

Friday

[x] Review Component Governance (Click on "microsoft/vscode-jupyter" on that page) and resolve all High/Severe issues.

[x] Focus on resolving Critical and High priority issues as others will be addressed in the debt week.
[x] Manually add any repository dependencies (if you can't add manually, refer here). Only add a cgmanifest.json if the components are not NPM or are not dev only.
Instructions on updating npm dependencies in package.json & package-lock.json can be found here.

[x] Create new release branch with format release/release-YYYY.MM.

Note: The release branch should not be changed after this step (not including hotfixes)

[x] Create a PR to main with the following changes... (Warning: this should happen right after creating the release branch. If this is deferred till later, the main and release branches can diverge significantly, which may cause merge conflicts.)

[x] At this point, the vscode engine version should also be the same as in the release branch- will be bumped when the next release happens
[x] Bump the version number in main to the next monthly ("YYYY.M.0") version number (e.g. if the latest is 2022.2.0, bump it to 2022.3.0).

[x] Run npm install to update package-lock.json

Monday (Debt/Release week)

[x] Obtain VS Code stable RC for sanity testing
[x] Manually run the Stable pipeline against the release/release-YYYY.MM branch

Enable Publish Extension, you do not need an approval to build the VSIX.
DO NOT ask for approval for the extension publish step, this step should only be done after sanity testing is done and ready to release.

[x] Sanity test release candidate VSIX against VS Code RC
Tip: You can use the dev containers in the this repo for testing against linux (just open the repo and use thd command Dev Containers: Reopen in Container)

[ ] Windows

[ ] win32-x64
[ ] win32-arm64

[ ] macOS

[ ] darwin-x64
[ ] darwin-arm64

[ ] Linux

[ ] linux-arm64
[ ] linux-armhf
[ ] linux-x64
[ ] alpine-arm64
[ ] alpine-x64

[ ] Candidate bug fixes found from sanity test should be checked into main and cherry-picked to release branch

After a candidate fix is merged, a pre-release build can be released by manually running the pre-release devops pipeline against the release branch.

Satelite extensions/npm packages

[ ] Reach out to the owners of each of these to coordinate the releases (if any).

If there are no releases for each of the following, then mark them as done.
Else the ownsers of each to mark as done when they are done.

[ ] JupyterHub (@DonJayamanne)

No need to pin VS Code engine
Release directly from main branch (pipeline)
PreRelease directly from main branch manually (pipeline)

[ ] Jupyter (Notebook) Renderers (@DonJayamanne)

No need to pin VS Code engine (unless you want to test something against VS Code insiders and not ship to stable users)
Release directly from main branch (pipeline)

[ ] Jupyter Powertoys (@DonJayamanne)

No need to pin VS Code engine (unless you want to test something against VS Code insiders and not ship to stable users, e.g. depends on some new Jupyter Extension API)
Release directly from main branch (pipeline)

[ ] Jupyter Cell Tags (@rebornix)

No need to pin VS Code engine
Release directly from main branch (pipeline)

[ ] Jupyter Slideshow (@rebornix)

No need to pin VS Code engine
Release directly from main branch (pipeline)

[ ] Jupyter KeyMap (@rebornix)

No need to pin VS Code engine
Release directly from main branch (pipeline)

[ ] Tensorboard (@DonJayamanne)

No need to pin VS Code engine
Release directly from main branch (pipeline)
PreRelease directly from main branch manually (pipeline)

[ ] zeromq-prebuilt (@DonJayamanne)

Release directly from main branch (pipeline)
Release by adding a git tag and pushing it upstream (e.g. 6.0.0-beta.16.8)
Can test bundles by manually running and publishing releases to github releases (download and test the bundles manually from github releases)

[ ] @vscode/zeromq (@DonJayamanne)

To be done after relesing zeromq-prebuilt
Release directly from main branch (pipeline)

[ ] @vscode/jupyter-extension (@DonJayamanne)

Release directly from main/relese branch (pipeline)

[ ] Gather (@DonJayamanne)

No need to pin VS Code engine
Release directly from main branch (pipeline)

Tuesday

[x] Make sure Component Governance is happy
[x] Release

[x] Verify the PR Pipeline on Github actions is green against the release branch.
[x] Approve the Publish stage of the last Stable pipeline that's successfully sanity tested.
[x] Ensure a tag with the released version number on the commit that was released was created.

This step occurs in the Publish Stage of the stable pipeline linked above.

[ ] If any steps were unclear or changed in this endgame plan please update the endgame_plan.md file to make it clear for the next release

Wednesday/Thursday (Day of VS Code releasing the next insider version)

[ ] Bump the engines.vscode version on the main branch to point to the next version. For example, from 1.58.0 to 1.59.0

As needed

[ ] Determine if a hotfix is needed

Use the same release/release-YYYY.MM branch

[ ] Ensure the version in package.json is updated as follows:

If released version is YYYY.MM.0, then hot fix will be YYYY.MM.1
If released version is YYYY.MM.1, then hot fix will be YYYY.MM.2

[ ] Verify all candidate issues
[ ] Sanity test release candidate VSIX against VS Code RC
Tip: You can use the dev containers in the this repo for testing against linux (just open the repo and use thd command Dev Containers: Reopen in Container)

[ ] Windows

[ ] win32-x64
[ ]
[ ] win32-arm64

[ ] macOS

[ ] darwin-x64
[ ] darwin-arm64

[ ] Linux

[ ] linux-arm64
[ ] linux-armhf
[ ] linux-x64
[ ] alpine-arm64
[ ] alpine-x64

[ ] Ensure that another tag was created for the new version's commit.

If a tag was not pushed, investigate in the  Publish Stage of the stable pipeline linked above, and manually add one using: git tag -a YYYY.MM -m YYYY.MM -s -f

[ ] Sanity test release candidate VSIX against VS Code RC
Tip: You can use the dev containers in the this repo for testing against linux (just open the repo and use thd command Dev Containers: Reopen in Container)

[ ] Windows

[ ] win32-x64
[ ] win32-arm64

[ ] macOS

[ ] darwin-x64
[ ] darwin-arm64

[ ] Linux

[ ] linux-arm64
[ ] linux-armhf
[ ] linux-x64
[ ] alpine-arm64
[ ] alpine-x64

releasing jupyter renderers blocked by marketplace being down


Bug with key in consul when changing profiles

This might be more of edge case, but running with a profile will correctly populate consule (i.e. docker-rules-engine) but if you remove the profile, then it will continue to use the same key despite the name changing.

@rsdmike , can you please add the steps to recreate?


Add: last message and scheduled message to campaign show.

closes #103

Rebased and back to this:


"noDataContent" text is shown during loading

Should be shown if the json web-response returns an empty object.
How to reproduce:

go to http://js-grid.com/demos/odata-service.html
press F5
and you should see "No found" during the loading

I agree, looks like not something expected. Thanks for the report!

Any  update on this issue? Thanks.

I still don't see good solution to this one.
It happens because the data option is an empty array on the grid creation, and grid has no items indeed. So technically, this is the right behavior.
We could show the grid without rows on the first load, but this also seems not correct. Imagine you have autoload: false, and grid is not loading automatically, but you want to load data yourself, or even don't want to use controller and just set data option when you want later. In this case you will have an empty grid, and this is not right behavior, right.
Feel free to share how you see the right behavior.

I would say all you need is if autoload: true simply show the loading overlay until its been loaded and if no data comes back then show the noDataContext. If data has been specified on initialising then simply show the noDataContext straight away.

hello, any solution?


V1.2 Add support for ExpiryDate and Type as fields for Ingredient

Fixes #35

Codecov Report

Merging #36 (f7085d8) into master (42f61eb) will decrease coverage by 0.45%.
The diff coverage is 67.79%.

@@             Coverage Diff              @@
##             master      #36      +/-   ##
============================================
- Coverage     72.18%   71.73%   -0.46%
- Complexity      399      417      +18
============================================
  Files            70       73       +3
  Lines          1233     1323      +90
  Branches        125      140      +15
============================================
+ Hits            890      949      +59
- Misses          311      328      +17
- Partials         32       46      +14

Impacted Files
Coverage Δ

...rc/main/java/fridgy/logic/commands/AddCommand.java
100.00% <ø> (ø)

...java/fridgy/model/ingredient/ExpiredPredicate.java
0.00% <0.00%> (ø)

...rc/main/java/fridgy/model/util/SampleDataUtil.java
20.00% <0.00%> (ø)

src/main/java/fridgy/logic/parser/ParserUtil.java
89.13% <60.00%> (-8.10%)
:arrow_down:

...ain/java/fridgy/storage/JsonAdaptedIngredient.java
84.37% <61.53%> (-15.63%)
:arrow_down:

.../main/java/fridgy/model/ingredient/ExpiryDate.java
66.66% <66.66%> (ø)

src/main/java/fridgy/model/ingredient/Type.java
66.66% <66.66%> (ø)

.../main/java/fridgy/model/ingredient/Ingredient.java
94.23% <78.57%> (-3.39%)
:arrow_down:

...c/main/java/fridgy/logic/commands/EditCommand.java
95.00% <87.50%> (-2.02%)
:arrow_down:

...ain/java/fridgy/logic/parser/AddCommandParser.java
100.00% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f61eb...f7085d8. Read the comment docs.

I think the isSameIngredient method should be modified to matching name, type, expiry date.
For adding new ingredient, if a same ingredient is added, the quantity should be increased instead of rejected.

@rootkie

For adding new ingredient, if a same ingredient is added, the quantity should be increased instead of rejected. Since quantity is yet to be implemented, I think this can be done in the PR that is adding the quantity field.

What happens to the other fields (description and tags) of the new and existing ingredient? When you check based on name, type, expiry then combine based on that equality, are tags combined as well? What about description?

@rootkie

For adding new ingredient, if a same ingredient is added, the quantity should be increased instead of rejected. Since quantity is yet to be implemented, I think this can be done in the PR that is adding the quantity field.

What happens to the other fields (description tags type) of the new and existing ingredient? Since this is basically a combine operation, when you check based on name, type, expiry then combine based on that equality, are tags combined as well? What about description?
Idk if this is a good idea and the edit command might be better for this.

That's a good point. I am thinking more about the complexity invovled when recipe is executed, which ingredient should be consumed. This will have a direct impact on how we define the identity of ingredients. I think we can discuss this further during meeting.

@rootkie

That's a good point. I am thinking more about the complexity invovled when recipe is executed, which ingredient should be consumed. This will have a direct impact on how we define the identity of ingredients. I think we can discuss this further during meeting.

For simplicity I suggest isSameIngredient only checks based on name, reject duplicates based on name. If the user wants 2 apples with different expiry then they can name it differently.
So recipe is just executed based on name and quantity.

@rootkie

That's a good point. I am thinking more about the complexity invovled when recipe is executed, which ingredient should be consumed. This will have a direct impact on how we define the identity of ingredients. I think we can discuss this further during meeting.

For simplicity I suggest isSameIngredient only checks based on name, reject duplicates based on name. If the user wants 2 apples with different expiry then they can name it differently. So recipe is just executed based on name and quantity.

I'm not so sure on what could be a solution for the combination of description, tag and type, but I think if we check based on name, then we will have a different problem: eg. users being forced to name their apple with like apple, apple 2, even though they r the same apples with different expiry. And then recipe consumption which only consumes apple will not be able to consume apple 2.

I'm not so sure on what could be a solution for the combination of description, tag and type, but I think if we check based on name, then we will have a different problem: eg. users being forced to name their apple with like apple, apple 2, even though they r the same apples with different expiry. And then recipe consumption which only consumes apple will not be able to consume apple 2.

I dont see an issue with that actually. apple new apple old is fine to me, anyway how many identical apples with different expiries will someone buy? Unless they are hoarding apples.
Recipe consumption will treat them as 2 different items. The user can split the quantity of apples themselves.

I'm not so sure on what could be a solution for the combination of description, tag and type, but I think if we check based on name, then we will have a different problem: eg. users being forced to name their apple with like apple, apple 2, even though they r the same apples with different expiry. And then recipe consumption which only consumes apple will not be able to consume apple 2.

The user can edit the recipe to split the quantity amongst the different apples. Either way that will be a user issue and not a bug on our side, since they are treated as 2 different items.


feature/context

Context refactoring.

@Schille @vvvityaaa I have moved the context into a separate group and refactored the context in all commands. I didn't manage to get some tests for the context running which I commented out. Furthermore we would need to adapt the documentation. After this PR is merged, I am free to work on the tests and check the Documentation.

Closes #113 .

Could you please add the new context command group and description to the documentation? There is already a brief section for the context feature here (you may adjust accordingly): https://cli.unikube.io/reference/overview.html#context-management and then add some meaningful docstrings, too.

I adjusted the docs.


Is it Possible to disallow flight and god mode in claimed area?

I know its possible to disallow the command execution for /fly and /god, but I also want the players whom have flight and god enabled, to automatically have them disabled by the claim. is this at all possible or should i just move on to command blocks?
In the picture is my attempt to deny flight and god mod using /claimoption, but for some reason its not working :(
PS. we are also running luck perms on the server. and command blocks are disabled on server for safety reasons.
mc version: 1.12.2

GD/LP version?
As a fix for now you could also use the griefdefender.player-command-enter option to run a fly/god disable command on everyone entering.

thank you for your reply @DrWurzeli
versions:
GD 1.2.6
SpongeForge 1.12.2-2838-7.2.1-RC4011
Lp 5.0.63
I tried the below cmds but they're not working :/
/claimoption player-command-enter "/god %player% false" [run_for=member, run_as=console]
/claimoption player-command-enter [run_for=public, run_as=console] "/god %player% false"
/claimoption player-command-enter "/god %player% false" [run_as=console]


Fix footer across all page

make footer across all page
please assign me to work on this issue.

please assign me this task.

@saimohan11 if the current assigned contributor won't submit his PR , I will assign this to you

Heyy @MinavKaria I'd like to work on this issue, could you please assign it to me?


barButtonIconStyle, titleStyle, navigationBarStyle, sceneStyle ignored in Route that is inside nested Router

Please give detail description and example code. These properties for Router, not Route.

We used it fine inside Routes, not inside Router.

This manifest itself in 1.x. Trying if 2.x will show something better.

There was breaking changes introduced within 1.x and 2.x versions. So please create issues only for latest versions.

Same for 2.x, styles are ignored in Route.

Sure, because it is not for Route. Again: API (syntax) was changed, no need to create issues related to old version syntax incompatibility...

Was it changed from Route to Router in 1.x -> 2.x transition (eg. it was meant for Route in 1.x)?

Each major version update introduces API changes.

Eh... that was not what I asked.

I would like to know if those style props were actually meant for Route in 1.x, so we did our code right when we used 1.x, and 1.x -> 2.x was the time when they were moved to Router.

So that when moving to 2.x, it is supposed to take styles used inside Route and move them into Router; or we just did it wrong from beginning and it just manifests now...

It is not only change. Now the component uses exNavigator component for navigation

There is small probability that recent changes broke something, please try version 2.0.8 for example.

Ad "It is not only change. Now the component uses exNavigator component for navigation": You always used exNavigator for navigation, didn't you?

0.3.* version didn't use it, i didn't know what old version you used before.

I did not start that early, so it was exNavigator as far as I can remember.

Changes should be minimal between 1.x and 2.x, please try 2.0.8

Ad "There is small probability that recent changes broke something, please try version 2.0.8 for example.": I don't know if anything is actually broken in this issue. I need to get an answer to my question: "Were navigationBarStyle etc. meant to be used in Route in 1.x and this was changed in 1.x -> 2.x transition so they are now meant to be used in Router?".

If it was so (1.x way was "put xxxStyle in Route", 2.x is "put xxxStyle in Router"), then this is non-issue. But I still did not hear from you whether it is yes or no.

@aksonov Maybe I solved the mystery. One of the Routes with style props, the one that appeared first in chronological order, had wrapRouter={true}. Could it be so that both 1.x and 2.x should actually use xxxStyle props in Router but b/c of wrapRouter in was actually inherited by wrapped Router from Route's props?

Yes, it could be.


UI - Rancher v2 apikeys font/spacing issue

Rancher versions:
rancher/server: v2, alpha21
Docker version: (docker version,docker info preferred)
17.03.02
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
Ubuntu 16.04.03
Spacing issues in display, also, this font in v2 seems too wide, would prefer the font from Rancher v1.6.x or some other Powerline fonts.

Version - 2.0 master 4/2
Verified fixed


Switch createFilterOptions with matchSorter experiment

Experimenting with using matchSorter instead of createFilterOptions. Not ready for review.

After some experimentation and more research into the matchSorter, it proves to be far too slow in showing the results from the search bar to the user. Unfortunately, matchSorter also does not have a filterLimit property or similar which we can utilize in hopes of speeding things up.


⚠ Bofrost.si has degraded performance

In 0ba334f, Bofrost.si (https://www.bofrost.si) experienced degraded performance:

HTTP code: 200
Response time: 2672 ms

Resolved: Bofrost.si performance has improved in 4de0343.


Improve placing entities via the [R] shortcut in the editor

When placing entities via the "R" shortcut in the editor, the ray-cast may hit the shape (or shapes) currently placed.
I suspect this relates to placing hierarchies of entities instead of a single entity with a shape attached, which is currently not handled.
Reported by @Danchyg1337.

Steps to reproduce:

On the root node: Attach new entity (With component) -> Character Controller
Place it with R on the ground
Place it with R on top of any prop that's higher than the ground
Repeat from step 2

Happened due to nodes having bounds with zero extents. Fixed in the latest beta build!


Add alternate client mount provisioners

Fixes Issue #2093
Signed-off-by: Nathaniel Clark<EMAIL_ADDRESS>

This change is

In #2093 the mount will succeed regardless if the command failed.
Can you add set -e to:
https://github.com/whamcloud/integrated-manager-for-lustre/blob/a2fc50f2ce4084117a40968c8a6a80f2bac1458c/vagrant/scripts/mount_lustre_client.sh#L1-L3


Fix #16218

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change
This one-liner allows you to actually specify an icon property for menu items
Alternate Designs
A possible alternate design would be to find a way to use for(in) loop to assign every property. I went with the design I did because it required the least amount of changes and I'm less likely to screw it up
Why Should This Be In Core?
The alternative is to put this little code snippet in your package that will make you cringe really hard.
(function() {
	var _ = window.require('underscore-plus');
	var oldpick = _.pick;
	// please forgive me
	_.pick = function(...args) {
		if(args[1] == 'type' && args[2] == 'label' && args[3] == 'enabled') {
			args.push('icon');
		}
		return oldpick.call(this, ...args);
	};
})();

Benefits
You can now use icons in menu items
Possible Drawbacks
In order to use this you have to use atom.contextMenu.add
Applicable Issues
#16218

Hey @monster860, I know this PR has been open for a very long time now. We didn't get to review it on time. I don't foresee Atom supporting icons on menus. For that reason, I am closing this for now.


remove font size change - too small

We're not going to change the base font-size for now.

its impossible to read need to at least set it to 16px standard
what concerns do you have about this?

its impossible to read need to at least set it to 16px standard
what concerns do you have about this?

A value between 14-16px is the standard, combined with a readable font such as Inter (the one we are using). Check what font-size is using this platform, for example. You don't seem to have any problem to read my comments.

I see your "standard readable text" with this ...

Which part isn't readable?

The chat mostly and the names on the avatars

The chat mostly and the names on the avatars

Then start with that instead of changing the global font-size. Usernames in avatars and chat use text-sm, which is 0.875rem or ~12px, and that's why you see them small. Usernames might stay like that, but I designed the chat to be at 14px (even though there will be a chat setting to increase or decrease the font-size).

you set it globally and it it doesnt just affect chat. when i removed that prop the whole site had a subtle and very comfortable adjustment that was much more pleasing to read

I kinda felt the same issue on the whole website the font aize is a bit small, little uncomfortable but if we increase it may spoil the whole look of the site. The font size change option should help to customise the size according to our eyes.

Little big but a lot more comfortable to read

This needs to reopen the font size on the site is too small. @benawad should weigh in here


Files in config.lua dont work

Describe the bug
Setting some files to be matched in config.lua dont work
To Reproduce
Steps to reproduce the behavior:
try my extension: https://marketplace.visualstudio.com/items?itemName=AtomontageInc.vscode-atomontage-lua
Environment (please complete the following information):

OS: Windows
Client: VSCode

Also seems like words only match after pressing doing one file change and only if editing a file containing the word, not if the word is in any other file in the workspace

I can't understand what you mean, please tell more details.

I have created a config.lua like this:
-- if not set, the folder name will be used
name    = 'Atomontage'
-- list of matched words
--words   = { "self%:Attach", "self%:Start" }
-- list or matched file names. `.lua`, `.dll` and `.so` only
files   = {'Sky%.lua', "Camera Controller%.lua", "Brush%.lua", "Voxel Inspector%.lua"} --those dont work?
-- lsit of settings to be changed
configs = {
    {
        key    = 'Lua.runtime.version',
        action = 'set',
        value  = 'Lua 5.3',
    },
    {
        key    = 'Lua.runtime.builtin',
        action = 'prop',
        prop   = 'io',
        value  = 'disable',
    },
    {
        key    = 'Lua.runtime.builtin',
        action = 'prop',
        prop   = 'os',
        value  = 'disable',
    },
}

and my project contains some of the file names at root i.e. Sky.lua

however the dialogue to enable my third party library doesn't show up


Doesn't want to work in Safari

See maldenma.beta.mapgeo.io in safari, and click on one of the brown buildings that is on a streetview road, e.g. https://maldenma.beta.mapgeo.io/properties/074 261 101
The expected result is a streetview image, but instead it shows up as grey. All of the methods run, but it just doesn't generate it properly.

Could you provide the code to be able to recreate this bug?

{{street-view lat=property.lat lng=property.lng
      width='100%'
      height='100px'
      panControl=false
      zoomControl=false
      linksControl=false
      addressControl=false}}

38.046393,-121.25591

Tested and working fine on safari. Using Safari v9.0.1


adds postgres instructions

added two new sections showing how to get the postgres connector and how to connect to a running postgres instance

Not sure if this is the right place for it or should we need to open a new issue.
It generates a horizontal scroller since the generated table is not contained in the page

we're using a template, so the best place is here: https://github.com/executablebooks/sphinx-book-theme

we're using a template, so the best place is here: https://github.com/executablebooks/sphinx-book-theme

I'll open an issue there


README.md screenshot fixed

Basically the last screenshot link wasnt working (https://linus-sex.tips/YaceZlOLdx.png)

Development is no longer on github, see https://codeberg.org/thatonecalculator/NerdFetch


ActivityTimeout for gRPC keep alive pings

What is the reason to ignore HTTP/2 protocol pings for reset ActivityTimeout?
In my case proxing gRPC stream with Keep Alive Pings not working as expected.

HTTP/2 and TCP pings are not propagated to user code, therefore ActivityTimeout does not know about them.
You set the ActivityTimeout to higher value, or you can try to enforce more gRPC traffic (e.g. gRPC pings if there is such a thing).

Thanks for reply!


Samples: iso_broadcast can not work properly unless some extra configuration flags

Describe the bug
If user build this sample for nrf52840, the sample can not work properly.
After adding more configuration flags in prj.conf, the sample can broadcast BIGinfo and BIS.
Need to add these flag in separate Board folder or prj.conf
The flags
CONF_BT_CTLR_ADV_EXT
CONF_BT_CTLR_ADV_PERIODIC
CONF_BT_CTLR_ADV_ISO

This isn't really a bug, as those are "just" board specific configurations. Not sure what the correct label is though.
@cvinayak

Do we have a list of nrf boards that support extended advertising?
Do we have a list of nrf boards that support broadcast ISO?

All nRF52 and nRF53 Series SoCs support Extended Advertising, Broadcast ISO and Synchronized Receiver. The Kconfig are not implicitly/default enabled until the implementation reach acceptable maturity (I see bug during my development/testing and most implementation is still work in progress). Users are open to explicitly enable the Kconfig(s).
That said, the Kconfigs are accordingly enabled in tests only for CI and regression coverage.

So you would argue that we perhaps shouldn't add the suggested Kconfigs to the specfic board files for samples @cvinayak ?
Or did I misunderstand your comment?

This isn't really a bug, as those are "just" board specific configurations. Not sure what the correct label is though.

I agree, but given that we anyway have plans to enable those features in the built-in controller, and users tend to see Bluetooth as whole, we might as well leave it as a low-prio bug that we close in the near future.

This isn't really a bug, as those are "just" board specific configurations. Not sure what the correct label is though.

I agree, but given that we anyway have plans to enable those features in the built-in controller, and users tend to see Bluetooth as whole, we might as well leave it as a low-prio bug that we close in the near future.

What about marking it as a enhancement instead?

So you would argue that we perhaps shouldn't add the suggested Kconfigs to the specfic board files for samples @cvinayak ? Or did I misunderstand your comment?

We shouldn't add the suggested Kconfigs to specific boards, not yet.

So you would argue that we perhaps shouldn't add the suggested Kconfigs to the specfic board files for samples @cvinayak ? Or did I misunderstand your comment?

We shouldn't add the suggested Kconfigs to specific boards, not yet.

What would be the criteria for when then? If it waits until they are accepted maturity, wouldn't we just enable the common config (e.g. CONFIG_BT_EXT_ADV)?

Passing conformance tests is the criteria to remove EXPERIMENTAL tag and to enable as default. Host and Controller are separate components and yes, host CONFIG_BT_EXT_ADV could implicitly enable the CONFIG_BT_CTLR_ADV_EXT when the Controller component is conformant.
Until the implementation is conformant, users should explicitly be aware of using the feature, hence let users enable it in there application conf file.
(question of the ADV_EXT name will arise, Advertising Extensions Feature in Controller is considered the parent of Extended Advertising (when enabling BT_BROADCASTER) and Extended Scanning (when enabling BT_OBSERVER).

Passing conformance tests is the criteria to remove EXPERIMENTAL tag and to enable as default.
I thought EXPERIMENTAL referred to the API stability, and not so much the conformance test :o (but that's outside the discussion of this issue).

So you suggest that we close this issue, as we won't add the experimental controller configs to the specific board config files?

If you decide to close this issue, I respect the decision. However, this is sample code, not internal test code, it means that everybody can set up and run it. If the current configuration can't make the board run properly, please leave something in readme of this sample to let the user know that how to meet the criteria to run this sample manually, otherwise, they will be frustrated.

If you decide to close this issue, I respect the decision. However, this is sample code, not internal test code, it means that everybody can set up and run it. If the current configuration can't make the board run properly, please leave something in readme of this sample to let the user know that how to meet the criteria to run this sample manually, otherwise, they will be frustrated.

I think updating the README might be the better choice here. Even if we add the suggested changed to specific board files, that will only "solve" the issue for those specific boards.

A reminder, how to handle this?

I think the best course of action is to update the README file in the affected samples.

I think the best course of action is to update the README file in the affected samples.

Great.
What are your opinions? @cvinayak , @carlescufi


[BUG] after goes to index.html YouTube video should be responsive it is not showing properly in mobile

Description
Describe the bug:
Video is not showing properly in mobile view
Expected behavior:
It should be showing properly on every device

Actual behavior:
A clear and concise description of what actually happened.
Reproduction Steps
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected result:
A clear and concise description of what you expected to happen at each step.
Actual result:
A clear and concise description of what actually happened at each step.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional Information
Device (please complete the following information):

OS: [e.g., Windows, macOS, Linux]
Browser [e.g., Chrome, Safari, Firefox]
Version [e.g., 22]

Additional context:
Add any other context about the problem here.

Hello @akshitagupta15june please assign this issue to me under gssoc 24

@akshitagupta15june Please closed this issue I am sorry but after running in my local and in inspect after selecting multiple device video is coming properly. I am sorry .
For different dimension i checked

his @akshitagupta15june  I'm interested in this issue, please assign it to me under GSSoc '24 .

Go for it!!
@akshitagupta15june Please closed this issue I am sorry but after running in my local and in inspect after selecting multiple device video is coming properly. I am sorry .
For different dimension i checked

Hello @akshitagupta15june I am closing this issue I am sorry but after running in my local and in inspect after selecting multiple device video is coming properly. I am sorry .
For different dimension i checked please check above screen shot thank you


Make profile form functional.

All of the functionality from account_management has been brought over, so
users can update their name, email, password, and reset their private key from
inside oc-id.
I think this is ready now.  The corresponding PR on the account_management repo to remove the stuff that was added here is https://github.com/chef/account_management/pull/114
ping @chef/chef-visual-interaction

:+1:

Don't forget on merging this to update the changelog - since this in the server, we can do it using the automated changelog. Ask in the LOB room how to do this, but it's what you put into your merge commit, I believe.

@mmzyk I don't know that I've ever specified a message for a merge commit.  GH does that automatically when you merge your PR, no?

Ah, probably. I always use the command line. My understanding is that you can specific the change log message in any commit and it will be picked up, doesn't have to be the merge commit.
I believe it of the form:
ChangeLog
And anything else after a one line white space is ignored.
Can @stevendanna @sdelano @joedevivo @marcparadise @tylercloke confirm? (since I'm not on the LOB team I can't ping that alias directly)

Which, speaking of merge commits, I know the LOB team will want you to rebase before merging, fyi.

@raskchanky If you rebase you should be good to go on this.
 Then you can amend the last commit in this group to have the auto changelog line, as directed here:
https://github.com/chef/omnibus#changelog
An example can be seen in this commit: https://github.com/chef/chef-server/commit/a51da388b6b937addc7baf8d2fb131187f8999b2
Looks like it's just have a line with
ChangeLog-Entry: line to go in the changelog


update the libraries

There is a new release system for all the libraries. This allows for updating libraries separately.
ftp://ftp.cs.ru.nl/pub/Clean/builds/ contains all these builds and there are symlinks for the latest versions.
In this way we can separate the different libraries. Moreover, the layout has changed for the user. For example clean-platform is no longer a submodule of iTasks. clean-platform bundles now come per OS, thus there are no more OS-Independant, OS-Posix folders anymore. Even more so, Sapl is a now living in $CLEAN_HOME/lib/Sapl and the same for Graphcopy and friends.

The new release system is a terrible change that does not solve the problem which really needs to be solved; (versioned) package management.
Ideally, we would not only store library and module but also its version number. Then we could simply index all versions of the libraries and allow the user to select an older version. With the nightly builds, this is impossible because (1) it is not possible to download an old release, (2) there are too many dates to store / have the user select and (3) there may be a 'new' nightly build with nothing changed.
But that's not a problem with cloogle. The nightly builds make it impossible for people to compare their code because they will be working on different versions, etc. Always offering the latest versions on cloogle is an arbitrary choice and will only be useful to the very few who update their system every day because they need to work on the latest system. Most people download the stable release, so at least for those libraries I wouldn't want to offer the nightly builds. For iTasks and clean-platform: yes, we could offer the latest builds, but that always remains an arbitrary choice and will keep annoying users until the release system is revisited properly.
We could invest time in that but I think it's better to develop a usable workflow first.

Maybe we should just update clean-platform and iTasks, thus leave the base system as is. There are no stable versions of those and it is really ennoying to have to grep the source to find my favourite functions.

Yes, maybe, but then we need to rebuild and clean the cache with every new commit. I talked to Bas today and he was interested in versioning the libraries, so maybe we can wait for that instead? Or if you can adapt the dockerfile to get the latest sources (in both the backend and src/view.php) then I can setup something to rebuild every night.

Is this done now, since https://github.com/dopefishh/cloogle/commit/356bcd5bd596d1505749d23160877801f096475e?

@dopefishh I had to change index.html because clean-platform was renamed to Platform; do similar things need to be done for iTasks?

I've changed index.html and added gast in #85. However, this doesn't work, the advanced dos protection is not working

this is done and tested, I'll merge #85


remove non-ascii test cases from anagram

Removes unicode specific test cases for anagram. This refers to #413.

Remind me to close #318 too.


 Using to test the bots.

My test is done. Closing this.


Add reverse_resolve/2 to Ethers.NameService

Closes #118

Nicely Done. Thanks for the contribution 💜


Cross fails with error: "rustup" "target" "list" failed with exit code: Some(1)

On about 25-June, all of our Travis builds started to fail with the error message:

error: "rustup" "target" "list" failed with exit code: Some(1)

I don't know why it started on 25-June.  It's probably either a change to Travis (they updated their builders, but they claim it was done by 21-June), or Rustup, or Cross.  We should also report this bug upstream to japaric/cross
https://travis-ci.org/nix-rust/nix/builds/246718360

Turns out that Travis was cacheing our .cargo and target directories (because we told it to).  When rustup 1.5.0 came out on 24-June, that broke the build.  Something in our .cargo didn't like it, I guess.  Through the Travis control panel, I cleared our caches, and the problem is resolved.

My nightly builds started failing, and clearing the cache was the solution.
Thanks for posting this issue, along with how to fix it!


Canvas rendered forEachLayerAtPixel does not work with multiple layers

The Coordinate value is being manipulated inside the layer loop so that the method only works for the first layer.

Outch. Do you think you can come up with a PR incl. tests?

Thanks for your work on this @tschaub.


Is WRITE_CONTACTS permission required if only read methods used?

The README states:

Make sure you add the following permissions to your Android Manifest
<uses-permission android:name="android.permission.READ_CONTACTS" />
<uses-permission android:name="android.permission.WRITE_CONTACTS" />

Is WRITE_CONTACTS required if I only plan to read the contact information?

You should be fine by just setting READ_CONTACTS.


Add option selecting huggingface inference engine

maybe also add a test that make sure you are using all tokens?
Option 1 is A
and 2 is A blah blah
And make sure they are different


Local engine builds should use Fuchsia's goma rbe

This requires downloading different goma binaries than the ones present in depot_tools.
@godofredoc Could you add a link here to any relevant docs that we should follow.

/cc @iskakaushik


UI error can not read property 'map' of null

Seeing below message with when changing 'status' filter in the workflow history table.
UI Version: latest
Cadence Version: v0.5.5
DB Backend: mysql
Expected: No error message

Hi @pgohite , are you able to pull the latest cadence-web and retest please? If you can't reproduce I will close the issue. Thanks!

Hi @pgohite , I am going to close this issue for now. Feel free to reopen if you believe this is still an issue.
Thanks!


Unable to import results from serenity to x-ray

Hi,
I am facing this issue with the action. It is configured, and running but it's not importing results from the .html file to x-ray.
If you see below screenshot, I get no error, but it just doesn’t import anything

Can any one help with this issue?

@sahni619 given the screenshot it looks like it did not find any files.
Are you sure there are reports in the defined path? Also (I am not an expert in cucumber specifically) but are those really .html reports?
Based on the official doc it looks they should be .feature files? https://docs.getxray.app/display/XRAY/Importing+Cucumber+Tests+-+REST

Thanks @mikepenz for chiming in. So, when I run my project on my local using mvn clean verify, it generates a target folder with index.html. This file when opened in chrome have all the information like the features I have written to test.
I also tried to use testPaths: "**/test/features/*.feature" because that's where my feature file resides, but it does the same thing.
But I am not sure if the endpoint which is mentioned in the docs is configured in the action?

The *.html file is usually the report which is only meant for direct viewing things. but usually reports imported into systems are in a different format (like the documentation in *.feature)
The action retrieves files via this method herE:
https://github.com/mikepenz/xray-action/blob/main/src/processor.ts#L84-L88
https://github.com/mikepenz/xray-action/blob/main/src/utils.ts#L115-L118
Given this log message here:
https://github.com/mikepenz/xray-action/blob/main/src/processor.ts#L155
The globber could not find any files matching your path definition.
Looks like "**/test/features/*.feature" does not lead to results

Closed by mistake

I did some changes in the path and now it gives me above issue. Thanks for your support @mikepenz

Do you have the cucumber export as json? Cucumber json reports are supported.
I am sorry that I forgot about it, but *.feature files are not yet supported. Please see here: https://github.com/mikepenz/xray-action/issues/320

So, I tried the json as well. I am getting cucumber-reports in json format, but still unable to import. Not sure why. Is there something I may be missing?

Please report back, otherwise will close for inactivity

Hi @sahni619 Can you please help me solve this error.
Getting 400 bad request while importing the test results: Message:BadRequest url=https://xray.cloud.getxray.app/api/v2/import/execution/junit?projectKey=stu&TestPlanKey="stu453"
Command: mvn clean compile test xray:import-results
In pom.xml gives:

app.getxray
xray-maven-plugin
0.7.3
test

215FFD69FE46447280000000000
1c00f8f22f56a8684d7c18cd61470000000
true
CALC
1.0
junit
target/cucumber.xml


The hosted HTTP server is slow to load files

If I use the cli command like this, the browser will quickly load the report:
vizviewer --once result.json

If I start the hosting server and then type the address into the browser, the browser will load for a long time without results
vizviewer --server_only result.json

I noticed that sometimes the trace loading would stuck. However, I don't think it's related to --once because they are using the exact same http server code. This is kind of spontaneous and I think that's some Perfetto artifact.

Is there a good way to circumvent this problem?


question: Authenticate users with client certificates

Is there a way to authenticate a user with a valid client certificate?
For example, if the user has a valid client certificate, issue them a token and grant them access to the portal. If they do not have a valid certificate, prompt them like normal for a username, password.
I know caddy itself has a way to check client certificates, but I do not see any way to integrate that with the portal.

@Jontron123 , this is not possible at the moment. The client cert is does not reach the plugins, i.e. caddy does not propagate it. Thus, no matching to acuswr identity.
You may want to ask for a feature enabling client cert propagation in “caddy” repo.


Feature request: allow margin for top/bottom and left/right

Looking at main.c line 129, it looks like zwlr_layer_surface_v1_set_margin allows for setting top, bottom, left and right margin.
Would you consider adding a config param to allow for margin_x = value (to set left and right) and margin_y = value (to set top and bottom)?
Ideally I would like to be able to offset the bar with different values for the x and y axis, rather than moving them in unison.

Hello. I prefer the variant with:
margin = top right bottom left
margin = top-bottom right-left
margin = all

just like with css margin. Feel free to create a pull request.


So much detail missing

The provisioning process is missing so much detail about different options and scenarios and the the behavior of the app. It makes it very difficult to plan a deployment.
Examples of details that would be good to understand -

Duplicate Users in Active Directory- What happens when two users have the same name? Does the agent create two users and have the smarts to give the 2nd user a number or something? Does it fail on the 2nd user because that name already exists?
Out of scope Delete/Disable - "Users out of scope may be disabled or deleted". So which is it? Will they be deleted or will they be disabled? What scenario causes each option? What is the configuration and options for each?
Scoping filters - Do scoping filters support functions like now()? Can you calculate a date or other similar functions?
De-provisioning/re-hire users - What happens when users are disabled in SF? Can they be moved out to a disabled OU? Can a re-hire be moved back to an active OU? Does it reset the password?

There just seems to be so much missing detail from actually using this product in a real world scenario.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 90fd487d-65b9-917b-4687-650b34dc4d81
Version Independent ID: 27a18d45-66ab-bc71-d928-93f93fb190dd
Content: Tutorial: Configure SuccessFactors inbound provisioning in AD and Microsoft Entra ID - Microsoft Entra ID
Content Source: docs/identity/saas-apps/sap-successfactors-inbound-provisioning-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @cmmdesai
Microsoft Alias: chmutali

@CountlessNumber
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.


Create Dependabot config file

Enable Dependabot for security notifications on dependencies https://dependabot.com/

Thanks!

Thanks!

@dlorenc the dependabot has to be enabled for the repository. I forgot to mention that.

@dlorenc the dependabot has to be enabled for the repository. I forgot to mention that.

@dlorenc the dependabot has to be enabled for the repository. I forgot to mention that.

Thanks @naveensrinivasan , enabled on https://github.com/ossf/scorecard/settings/security_analysis

@dlorenc the dependabot has to be enabled for the repository. I forgot to mention that.

Thanks @naveensrinivasan , enabled on https://github.com/ossf/scorecard/settings/security_analysis

@inferno-chromium thanks for the update. I don't have permission to view that was the reason I had to mention it.

@inferno-chromium thanks for the update. I don't have permission to view that was the reason I had to mention it.


Brew installation method does not work

==> Tapping hidetatz/tap
Cloning into '/usr/local/Homebrew/Library/Taps/hidetatz/homebrew-tap'...
remote: Enumerating objects: 59, done.
remote: Counting objects: 100% (59/59), done.
remote: Compressing objects: 100% (55/55), done.
remote: Total 59 (delta 12), reused 8 (delta 0), pack-reused 0
Receiving objects: 100% (59/59), 7.89 KiB | 2.63 MiB/s, done.
Resolving deltas: 100% (12/12), done.
Error: Invalid formula: /usr/local/Homebrew/Library/Taps/hidetatz/homebrew-tap/Formula/kubecolor.rb
kubecolor: Calling bottle :unneeded is disabled! There is no replacement.
Please report this issue to the hidetatz/tap tap (not Homebrew/brew or Homebrew/core):
  /usr/local/Homebrew/Library/Taps/hidetatz/homebrew-tap/Formula/kubecolor.rb:9

Error: Cannot tap hidetatz/tap: invalid syntax in tap!
Failed to install [hidetatz/tap/kubecolor]
Some packages were not installed

==> Some tasks were not executed successfully

Unsure where the error is, seems in brew formula

I am also hitting this issue:
`==> Homebrew was updated to version 3.4.0
More detailed release notes are available on the Homebrew Blog:
https://brew.sh/blog/3.4.0
==> Tapping hidetatz/tap
Cloning into '/usr/local/Homebrew/Library/Taps/hidetatz/homebrew-tap'...
remote: Enumerating objects: 59, done.
remote: Counting objects: 100% (59/59), done.
remote: Compressing objects: 100% (55/55), done.
remote: Total 59 (delta 12), reused 8 (delta 0), pack-reused 0
Receiving objects: 100% (59/59), 7.89 KiB | 2.63 MiB/s, done.
Resolving deltas: 100% (12/12), done.
Error: Invalid formula: /usr/local/Homebrew/Library/Taps/hidetatz/homebrew-tap/Formula/kubecolor.rb
kubecolor: Calling bottle :unneeded is disabled! There is no replacement.
Please report this issue to the hidetatz/tap tap (not Homebrew/brew or Homebrew/core):
/usr/local/Homebrew/Library/Taps/hidetatz/homebrew-tap/Formula/kubecolor.rb:9
Error: Cannot tap hidetatz/tap: invalid syntax in tap!`

I confirm that I am also seeing the same issue with Homebrew version 3.4.0.

Me too

Same problem here... any workaround?

@fveas you can install it with the following command:
brew install jjuarez/homebrew-tap-1/kubecolor

@fveas you can install it with the following command:
brew install jjuarez/homebrew-tap-1/kubecolor

Works for me. 👍

@fveas you can install it with the following command:
brew install jjuarez/homebrew-tap-1/kubecolor

Thank you. That worked.

same issue the official tap repo didn't work

A mi tambien me funciono

This issue is now fixed. Please reopen if it still happens.