nixos/systemd-lib: discard string context for X-Restart-Triggers

The files only track if the service unit should be restarted, the actual contents are irrelevant.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I'm not sure what it's solving?

On my machine this removed some files which trigger restarts but are only used at build time for other files
 ➜ nix store diff-closures /nix/var/nix/profiles/system-259-link/ /nix/var/nix/profiles/system-260-link/
02overridedns: ε → ∅
extra-hwdb: ε → ∅
extra-udev: ε → ∅
ipv6-privacy-extensions.rules: ε → ∅
nameservers: ε → ∅

For example ipv6-privacy-extensions.rules is used to build {98,99}-ipv6-privacy-extensions.rules
 ➜ fd ipv6-privacy-extensions.rules /etc/
/etc/udev/rules.d/98-ipv6-privacy-extensions.rules
/etc/udev/rules.d/99-ipv6-privacy-extensions.rules

In theory, if something isn't actually a dependency of the unit in some way, it shouldn't be in restartTriggers.

There are some use cases like restarting VMs or networking things which are not present on the actual machine and forgetting there discard string is easily done.

But either way, you would expect the derivation to be present?

No, it is just a string which triggers a restart.

Manually interacting with string contexts is hacky, we shouldnt.

No it isn't and in some core places we are already relying on it. It needs to be carefully chosen but this is a place where this is a good fit.

What's the problem you're trying to solve here?

We don't actually need the derivations behind the strings logically.

For example ipv6-privacy-extensions.rules is used to build {98,99}-ipv6-privacy-extensions.rules

Ok, but why is the restart trigger ipv6-privacy-extensions.rules instead of {98,99}-ipv6-privacy-extensions.rules? If the thing being built is the thing that actually matters, then you really want that derivation to be the restart trigger, don't you?

I don't know but that sounds reasonable but it also shows that oversights can happen which could be easily avoided.

I don't know but that sounds reasonable but it also shows that oversights can happen which could be easily avoided.

I don't know what this means w.r.t this PR.

➜ nix store diff-closures /nix/var/nix/profiles/system-259-link/ /nix/var/nix/profiles/system-260-link/
02overridedns: ε → ∅
extra-hwdb: ε → ∅
extra-udev: ε → ∅
ipv6-privacy-extensions.rules: ε → ∅
nameservers: ε → ∅

That those oversights don't need to be fixed up by hand.

I'm also no fan of that. Manually interacting with string contexts is hacky, we shouldnt.

I agree.  However:

What's the problem you're trying to solve here?

There is a legitimate problem/need here.
There is an analogy between the Nix store and a garbage collector.
Most memory garbage collectors have the concept of a "weak reference" -- if an object has only weak references pointing to it (but not ordinary/strong references), it can be garbage collected, and those weak references become null or something similar.
Nix doesn't have weak references.  I think they would be the right solution to the excessive closure size issues that @SuperSandro2000 is seeing.
We should probably take some time to think about what it would mean for Nix to have weak references, and implement them carefully.  I think the right way to do it would be something like builtins.placeholder, where you hand it a store path for the normal/strong reference and it gives you back a different storepath which is the weak reference.  I'm not entirely sure what the weak-reference storepath should be, but my first guess is that it should be a hard link.

I think you've gone the opposite direction here. The question was "why do you need this". Your answer was effectively "Given that I've decided I need this, here is the theory to explain its existence." It's not yet shown that it's reasonable to need this

I think we are talking about different "this"es :)
I thought the question was "why do you need to use unsafeDiscardStringContext", and my answer was "because Nix's store-GC lacks a feature found in most memory-GCs".
I guess if the question was "why do you not want to pull X-Restart-Triggers paths into the closure", the answer seemed pretty obvious: save network bandwidth and disk space by reducing closure bloat.  Now, if you don't think that's a good enough answer, that's perfectly okay.  But it is a legitimate answer.

I think you've gone the opposite direction here. The question was "why do you need this". Your answer was effectively "Given that I've decided I need this, here is the theory to explain its existence." It's not yet shown that it's reasonable to need this

I think we are talking about different "this"es :)
I thought the question was "why do you need to use unsafeDiscardStringContext", and my answer was "because Nix's store-GC lacks a feature found in most memory-GCs".
I guess if the question was "why do you not want to pull X-Restart-Triggers paths into the closure", the answer seemed pretty obvious: save network bandwidth and disk space by reducing closure bloat. Now, if you don't think that's a good enough answer, that's perfectly okay. But it is a legitimate answer.

But you don't save disk space/closure bloat. If let's say the restart trigger is nginx and its config file store path, while the process itself reads through a symlink in /etc/, no matter if you discard the string context or not, nginx needs that config file to start, so you need to have it somewhere in the closure anyways.


Speed up model building

The model building is very slow.
from pyjobshop import Model

# A job consists of tasks, which is a tuple (machine_id, processing_time).
jobs_data = [
    [(0, 3), (1, 2), (2, 2)],  # Job0
    [(0, 2), (2, 1), (1, 4)],  # Job1
    [(1, 4), (2, 3)],  # Job2
    [(2, 3), (1, 4), (0, 8)],  # Job3
    [(1, 3), (0, 4), (2, 2)],  # Job4
    [(1, 3)],  # Job5
] * 1000
num_jobs = len(jobs_data)

model = Model()
jobs = [model.add_job() for _ in range(num_jobs)]
machines = [model.add_machine() for _ in range(3)]

for job_idx, task_data in enumerate(jobs_data):
    tasks = [model.add_task(job=jobs[job_idx]) for _ in task_data]

    # Add processing times.
    for idx, (machine_idx, duration) in enumerate(task_data):
        model.add_processing_time(tasks[idx], machines[machine_idx], duration)

    # Impose linear routing precedence constraints.
    for task_idx in range(1, len(tasks)):
        task1, task2 = tasks[task_idx - 1], tasks[task_idx]
        model.add_end_before_start(task1, task2)

num_jobs = len(jobs)
num_machines = len(machines)
num_tasks = len(model.tasks)

print(f"Building model with: {num_jobs=}, {num_machines=}, {num_tasks=}")

result = model.solve(
    solver="ortools",
    time_limit=0.1,
    log=True,
    num_workers=8,
)

poetry run python -m cProfile -o output.prof sandbox.py

Three main points of inefficiency:

[x] Setup times
[x] Task alternative graph constraints

From 6 seconds to 2.66.

[x] Many calls to ProblemData.constraints

From 11 seconds to 6.

Not changing setup times because the main bottleneck is when the setup times matrix becomes too big (quadratic in number of tasks) but this is a non-issue when we have 5K tasks. The main problem is when the setup times are active, i.e., nonzero, which create a shitton of sequence variables.

Next: tackling the sequence variables construction.
from pyjobshop import Model

# A job consists of tasks, which is a tuple (machine_id, processing_time).
jobs_data = [
    [(0, 3), (1, 2), (2, 2)],  # Job0
    [(0, 2), (2, 1), (1, 4)],  # Job1
    [(4, 4), (2, 3)],  # Job2
    [(5, 3), (1, 4), (0, 8)],  # Job3
    [(6, 3), (0, 4), (2, 2)],  # Job4
] * 50
num_jobs = len(jobs_data)

model = Model()
jobs = [model.add_job() for _ in range(num_jobs)]
machines = [model.add_machine() for _ in range(12)]

for job_idx, task_data in enumerate(jobs_data):
    tasks = [model.add_task(job=jobs[job_idx]) for _ in task_data]

    # Add processing times.
    for idx, (machine_idx, duration) in enumerate(task_data):
        model.add_processing_time(tasks[idx], machines[machine_idx], duration)

    # Impose linear routing precedence constraints.
    for task_idx in range(1, len(tasks)):
        task1, task2 = tasks[task_idx - 1], tasks[task_idx]
        model.add_end_before_start(task1, task2)
        model.add_previous(task1, task2)
        model.add_setup_time(machines[machine_idx], task1, task2, 1)

num_jobs = len(jobs)
num_machines = len(machines)
num_tasks = len(model.tasks)

print(f"Building model with: {num_jobs=}, {num_machines=}, {num_tasks=}")

result = model.solve(
    solver="ortools",
    time_limit=1,
    log=True,
    num_workers=8,
)

CP Optimizer is fairly invariant to the model size since it has its own efficient implementation of sequence variables (hence no quadratic building times). It takes about 1 second to create
Building model with: num_jobs=8000, num_machines=20, num_tasks=16500

and about 2 seconds to pass the information to the solver. This is overhead we can't do much about.


Non-deterministic editor behavior in test suite

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.66.0
OS Version: Arch Linux x86_64

Steps to Reproduce:
This is reproducible with any language (tested with LIGO, TypeScript, and a dummy FooBar language, demonstrated below), but I'll provide a minimal example. Create a new TypeScript extension, containing a test suite like this:
import * as assert from 'assert';
import * as path from 'path';
import * as vscode from 'vscode';

function runTest(i: number, b: boolean) {
  test(`Test ${i}`, async () => {
    const uri = vscode.Uri.file(path.join(__dirname, `test${b ? i : ''}.foobar`))
    const doc = await vscode.workspace.openTextDocument(uri)
    const editor = await vscode.window.showTextDocument(doc)
    const originalContents = doc.getText()

    await vscode.commands.executeCommand('editor.action.commentLine')
    const newContents = doc.getText()
    assert.equal(newContents, `// ${originalContents}`)

    await vscode.commands.executeCommand('editor.action.commentLine')
    const revertedContents = doc.getText()
    assert.equal(originalContents, revertedContents)

    editor.hide()
  });
}

suite('Open the same file', () => {
  for (let i = 1; i <= 10; ++i) {
    runTest(i, false)
  }
})

suite('Open different files', () => {
  for (let i = 1; i <= 10; ++i) {
    runTest(i, true)
  }
})

The first suite's tests will always fail randomly, while the second always succeeds. Is there any way to make it never fail?
Note: I've attached a .tar.gz file, executed with git archive --format tar, containing a repo demonstrating this bug with the test above. See:
test-bug-example.tar.gz
You'd expect this to always succeed, but it fails in random order. In the repo, I've attached some notes and a failure example in the README.md, one of which I repeat here:

Note that this is a minimal reproduction of a real test suite (see this test suite), however, in there, I was able to reproduce the bad behavior regardless of whether the same or different files are used. The issue in there is the same: the expectation fails, where it should be commented, it's not.

Everything that is documented to return a Promise has an await on it, so in theory this shouldn't happen, am I missing something? Even putting await in everything has no impact.
I don't know whether this is something I've been doing wrong or if there is an issue in Visual Studio Code, so I hope this issue can help bring some light on this matter. Thanks for the attention!

Hey! I was wondering about this, we have a test suite that was disabled because it would randomly fail. I'm not sure if there is a workaround for this, so I decided to ask. Is there something that I can do in the meantime on our side?

I've tested this locally and it seems to be caused by editor.hide(). The JSDoc reads:
        /**
         * Hide the text editor.
         *
         * @deprecated Use the command `workbench.action.closeActiveEditor` instead.
         * This method shows unexpected behavior and will be removed in the next major update.
         */
        hide(): void;

I think the root cause is that this API method returns void but its implementation is async and perhaps the next test races against this method. After replacing editor.hide() with await vscode.commands.executeCommand('workbench.action.closeActiveEditor'); the tests always pass for me. Could you please also try that?

Thanks for your reply!
I tried it on the example test suite, and it seems to work. But trying it on a real test suite still causes the tests to fail non-deterministically, although a bit less frequently now. I've put a link to it here: https://gitlab.com/serokell/ligo/ligo/-/blob/139422bdecee3ecfa349d5bb07ad73641f68aa27/tools/lsp/vscode-plugin/test/vsc-test/comment.test.ts
This is one example of failure:
  1) LIGO: Insert comments (LIGO-425 regression)
       Line comments are inserted correctly (CameLIGO):

      AssertionError [ERR_ASSERTION]: 'let x : int = 42\n' == '// let x : int = 42\n'
      + expected - actual

      -let x : int = 42
      +// let x : int = 42

        at /build/vscode-plugin/client/out/test/vsc-test/comment.test.js:35:16
        at Generator.next (<anonymous>)
        at fulfilled (client/out/test/vsc-test/comment.test.js:5:58)
        at processTicksAndRejections (internal/process/task_queues.js:93:5)

  2) LIGO: Insert comments (LIGO-425 regression)
       Line comments are inserted correctly (ReasonLIGO):

      AssertionError [ERR_ASSERTION]: 'let x : int = 42\n' == '// let x : int = 42\n'
      + expected - actual

      -let x : int = 42
      +// let x : int = 42

        at /build/vscode-plugin/client/out/test/vsc-test/comment.test.js:35:16
        at Generator.next (<anonymous>)
        at fulfilled (client/out/test/vsc-test/comment.test.js:5:58)
        at processTicksAndRejections (internal/process/task_queues.js:93:5)

Could it be an interference with the language server? It doesn't really try to modify files in any capacity and I would expect that VS Code can still execute files independently of it, but it's nice to be sure...
Just for clarification on why we have this test: we have a tool to automatically generate the configuration and syntax highlighting for files, this is a regression test because once we messed up how it inserts comments.

Sorry, I see this issue has a "needs more info" tag, what extra information may I provide to help in the investigation? Or what steps may I perform to better help isolate this issue?

Using await vscode.commands.executeCommand('workbench.action.closeActiveEditor') seems to be the right thing AFAIK, as we use the same in our tests.
@bpasero Do you have any ideas why closing an editor and opening the same file would fail every now and then in extension unit tests?

Thanks Alex for the initial investigation, I agree that closing an editor needs to be properly awaited on because that operation is async since it may bring up a dialog asking to confirm in case the editor is dirty.
I do not give support for tests that are not minimal so please try to isolate this in a minimal test suite that I can run to reproduce.
Thanks for understanding.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


1.7 Passing NetworkDisabled: true in API fails

You can see this one from doing
./bundles/1.7.0-dev/binary/docker-1.7.0-dev run --networking=false -it ubuntu
Warning: '--networking' is deprecated, it will be removed soon. See usage.
Error response from daemon: Cannot start container 8f81ec7f7350dfe2be5869340a48f95cffa256c2b90fad21d87cb12d70bc44a8: network namespace path is empty

But the same happens by hitting the API with NetworkDisabled: true in Config

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO


Drop caching of resolved configuration and previous lookups

This commit ensures that the hiera configuration is resolved on each
invocation and that no values are cached between invocations.
A side effect of this is that the cache provided in the ProviderContext
now has the same short life cycle as the invocation.

👍 LGTM - functional test passed, in that all of these queries returned the correct results without restarting the server. Prior to this change, it required a restart to get the right answer:
eric@recury # curl 'http://localhost:8080/lookup/wordpress.database_password?var=environment:production'
"ProductionPassword"                                                                                eric@recury # curl 'http://localhost:8080/lookup/wordpress.database_password?var=environment:foobar'
"Awesom3p4ass"                                                                                eric@recury # curl 'http://localhost:8080/lookup/wordpress.database_password?var=hostname:pop-os&var=environment:production'
"node_password"


Adds pull request description template

/fyi: @juwai/platform-all

Temporarily tagging: https://github.com/juwai/in-house/issues/74

@imlazyone: Please merge. Thanks.


Build Image overlay component

We need to create a new overlay image component. It should have two states

Text visible: On hover - an image would show and the text would fade out. On click -it should link to a particular URL
Image is visible: On hover - text would show and image would fade out. On click -it should link to a particular URL

Support gif (low-pri).


gowitness: 3.0.4 -> 3.0.5

Diff: https://github.com/sensepost/gowitness/compare/refs/tags/3.0.4...3.0.5
Changelog: https://github.com/sensepost/gowitness/releases/tag/3.0.5

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 351214

x86_64-linux

:white_check_mark: 1 package built:

gowitness


Unloading after setting the wallpaper

I went through the readme and I found consider unloading those that you no longer need but I'm not sure what no longer needed means. Does it mean that once I set the wallpaper I can unload it
eg flow:
hyprctl hyprpaper preload ~/Pictures/myepicpng.png
hyprctl hyprpaper wallpaper DP-1,~/Pictures/myepicpng.png
hyprctl hyprpaper unload ~/Pictures/myepicpng.png

Will the above cause any issues?

shouldnt. Try it

Yeah I tried it later, forgot to update.
If I execute them manually it seems fine, the wallpaper is still set, but if I run it as part of a script hyprpaper crashes.
I'm guessing it's because the image is unloaded before it actually gets set.

Is there any way where we can have only one image loaded at a time, like a setting in the config or a flag that unloads the previous image when preloading a new one?
Cause in my use case I'm using an app called variety to set my wallpapers and it calls a script (with the path to the image) that checks the DE/WM and sets the wallpaper. I don't have access to the previous image in this case so something like this would be useful, or like #19 would also work ig.

unload all added in 3571e20b55da7921a47d4910204b40ab1701b5c4
Close if you wish.

@Jacob3075  I wrote a script for using one wallpaper at a time #21

@vaxerski I just checked the commit changes, shouldn't this be called in handleUnload
https://github.com/hyprwm/hyprpaper/blob/3571e20b55da7921a47d4910204b40ab1701b5c4/src/config/ConfigManager.cpp#L115
right now it's in handleWallpaper so the command it matches is ... wallpaper all instead of ... unload all

@Wa1t5 I checked script, it might work but I feel like there's better ways to it

@Jacob3075 Yep, I updated it to use hyprctl, but I still need to commit, I'll do it tomorrow have to sleep now

@Jacob3075 my retardness. Fixed.

Cool, thanks 👍👍


suggest etcd-server >= 3.4.0 in deb pkg

WHAT is this pull request doing?
Sets a minimum version of 3.4.0 for the suggested etcd-server dependancy.
HOW can this pull request be tested?

Not sure if 3.4.0 is the correct minimum version, WDYT?


[Merged by Bors] - style(SetTheory): remove useless parentheses

These were caused by a bad notation precedence in mathlib3, where the local version of ^ was given precedence 0. We're not using the local notation at all in Mathlib4 (partly because it was broken, which this PR fixes).

Cleaning up this file now makes it easier to deal with fallout from attempts to fix leanprover/lean4#2220

This is a nice fix, thanks!
bors merge

(Unfortunately this will cause merge conflicts with the fixes for #2220... Oh well)


[Bug] In Shared mode consumption scenario, resetCursor gets the wrong position

Search before asking

[X] I searched in the issues and found nothing similar.

Version
pulsar 2.9.2
Minimal reproduce step

Create a topic with 1 partitions, send traffic normally
start two consumer process instance in Shared mode
One process calls acknowledge after normal consumption
Another process delays calling acknowledge with Thread.sleep(100000L) after consumption
After a while, resetCursor("persistent://chenjianbo-tenant1/chenjianbo-ns/test111","subscription1", System.currentTimeMillis() - 5 * 60 * 1000), but the getPublishTime of received message of the first process is 1 hour ago.

What did you expect to see?
getPublishTime  is the correct time
What did you see instead?
after resetCursor , the first process returns the earliest data of the topic
Anything else?
I found this problem occur when searchPosition and getLastPosition is equals, and individualDeletedMessages is not empty at the same time
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

fixed : https://github.com/apache/pulsar/pull/20457


Identical enum names

#627 made code much clearer in most of cases, but looks like it breaks on some SVDs which have different fields with identical enum names.
cc @luojia65
For example some NXP SVDs (see https://github.com/posborne/cmsis-svd/blob/master/data/NXP/LPC178x_7x.svd) have many enumeraredValues with name ENUM:

We need that diff tool :D

@burrbull: I discovered this note on descriptions of dimArrayIndex:

User is responsible for uniqueness across description.

Will this help to solve our issue here?

Looks like problem is that there are multiple different enums with the same name under one register. I may suggest one of following ideas:
1. we generate field name instead if such condition exists, or

2. we note that same enumeratedValues name should not exist, and the users should patch their SVD files instead

Can't it be a valid solution that an enum variant with a payload which covers all the values that "map" to the same name is used?
E.g. for the SVD section below, this enum would be generated:
enum RR_INITMOD {
     mod_63,
     mod_1_63(u8),

            <field>
              <name>RR_INITMOD</name>
              <description>Initialization Delay Modulus</description>
              <bitOffset>16</bitOffset>
              <bitWidth>6</bitWidth>
              <access>read-write</access>
              <enumeratedValues>
                <enumeratedValue>
                  <name>MOD_63</name>
                  <description>63 cycles (same as 111111b)</description>
                  <value>0</value>
                </enumeratedValue>
                <enumeratedValue>
                  <name>MOD_1_63</name>
                  <description>1 to 63 cycles</description>
                  <value>0x1</value>
                </enumeratedValue>
                <enumeratedValue>
                  <name>MOD_1_63</name>
                  <description>1 to 63 cycles</description>
                  <value>0x2</value>
                </enumeratedValue>
                <enumeratedValue>
                  <name>MOD_1_63</name>
                  <description>1 to 63 cycles</description>
                  <value>0x3</value>
                </enumeratedValue>
                <enumeratedValue>
                  <name>MOD_1_63</name>
                  <description>1 to 63 cycles</description>
                  <value>0x4</value>
                </enumeratedValue>
                <enumeratedValue>
                  <name>MOD_1_63</name>
                  <description>1 to 63 cycles</description>
                  <value>0x5</value>
                </enumeratedValue>
                <enumeratedValue>
                  <name>MOD_1_63</name>
                  <description>1 to 63 cycles</description>
                  <value>0x6</value>
                </enumeratedValue>
                <enumeratedValue>
                  <name>MOD_1_63</name>
                  <description>1 to 63 cycles</description>
                  <value>0x7</value>
                </enumeratedValue>
....

I was thinking was correct as this bit suggests there is no constraint on the values to map to different names, but for each value there is a name to show:

_An enumeratedValue defines a map between an unsigned integer and a string._

> In [enumeratedValues element section](https://www.keil.com/pack/doc/CMSIS/SVD/html/elem_registers.html#elem_enumeratedValues) of CMSIS-SVD standard 1.3.9, it says:
>
> > This information generates an enum in the device header file.
>
> Suggested from quoted notes above, the standard indicates that each enumeratedValues information section should generate one enum structure under device level code description. As most programming language disallows multiple enum structure exist with the same name under one namespace, I may suggest the second idea more as it matches the suggestion in CMSIS-SVD standard.


fix Gitter badge URL

Bump.

Bump.

Bump.

Another friendly bump =)

Sorry for the late delay, thanks for the quick fix!

You are welcome. Thanks for providing your time and the invested work.


[feat] Reduce Source Code Folder Size

Describe the problem
Disclaimer: I'm new in Tauri and Rust
The source code folder size is extremely big, ~2GB - ~4GB. That is crazy amount for just an hello-world app.
I thought node_modules is the only one that can take that much space!!!
I noticed this folder: src-tauri/debug is taking the most space.
Is there anyway that we can move this folder out of scope so we can use it for all the Tauri project instead of just one?
Describe the solution you'd like
Move all the big folders to use globally for every Tauri project.
Alternatives considered
No response
Additional context
No response

These are Rust's build artifacts. You can change the target dir with this config https://doc.rust-lang.org/cargo/reference/config.html#buildtarget-dir
Note that this also changes tauri's output dir (where it creates the app bundles).

Also note that to share build artifacts between projects you can use tools like sccache, but it's out of scope for Tauri

I also think the folder is too big. my used pnpm create tauri-app with vanilla .
2.5GB in the first pnpm tauri dev;
;
4GB in the first pnpm tauri build;
.
this is use pnpm create tauri-app with svelte:

I also think the file is too big;
First run in  pnpm tauri dev and pnpm tauri build.

I also think the folder is too big;

There really is not much we can do, other than maybe reducing our dependencies, i don't know. This is really a Rust "issue" not a Tauri issue :/

First run in pnpm tauri dev and pnpm tauri build = 5GB

tauri dev and tauri build do not share build artifacts since they translate to cargo build and cargo build --release so you end up with twice the build artifacts.

This is a situation common to many rust projects and "Not something Tauri can do anything about. :tm:". Something I have personally used in the past is this:
https://github.com/holmgr/cargo-sweep
But a headsup in the docs is a good idea @KiddoV

I'm not sure what we should add to the docs for this specific scenario. We're not talking about old/leftover build artifacts, but the ones from a fresh build. For this specifically the only thing we can add is a warning that users should expect a ~2GB target folder (or 4-5 if debug and release builds are present)
If you guys mean we should add tips about keeping it at ~2gb then sure, we can add a note about cargo-sweep and cargo clean, and that it should be run once in a while and especially after each new Rust release.
-> Where should that go in the docs? In the Development category?


Use alias to get rid of ../ paths for modules

Lots of ../../.. in the source and in the docs made things pretty cumbersome. Now, there's an alias @ which points to the root directory. I went with @ instead of a name like root just to avoid any confusion thinking there's a real npm module with that name.
Also, this could have been done with a single babel plugin, but there seems to be some concern that jest or webpack caching may break, so instead I went with tool-specific plugins/settings for webpack/jest/rollup. See https://github.com/tleunen/babel-plugin-module-resolver/issues/346 and other issues for details on the potential problem with the babel plugin.
For now, I kept all the ./ sibling paths. I'd be find switching those to absolute, but there isn't as much to gain there, so I just left them for now.
cc @stevelikesmusic I'll be merging this right away to keep things moving, but feel free to continue the convo if you have any other opinions here.

Nice addition @jdeal!


Migrations fail on clean database

Hey there,
Just upgraded to Wagtail 1.4.2
I get the following error when I run all the migrations on a clean database
self = <django.db.backends.utils.CursorWrapper object at 0x10e9b7be0>
sql = 'INSERT INTO "wagtailcore_page" ("path", "depth", "numchild", "title", "slug", "live", "has_unpublished_changes", "url... VALUES (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s) RETURNING "wagtailcore_page"."id"'
params = ('0001', 1, 1, 'Root', 'root', True, ...)

    def execute(self, sql, params=None):
        self.db.validate_no_broken_transaction()
        with self.db.wrap_database_errors:
            if params is None:
                return self.cursor.execute(sql)
            else:
>               return self.cursor.execute(sql, params)
E               django.db.utils.IntegrityError: duplicate key value violates unique constraint "wagtailcore_page_path_key"
E               DETAIL:  Key (path)=(0001) already exists.

venv/lib/python3.4/site-packages/django/db/backends/utils.py:64: IntegrityError

this seems to be the migration that causing the problem
venv/lib/python3.4/site-packages/wagtail/wagtailcore/migrations/0001_squashed_0016_change_page_url_path_to_text_field.py:33: in initial_data

Hey there, I found that this error only occurs when you have multiple database connections setup.
If that is not relevant, I will close the issue

Hi @colinfrankb - if this only occurs with multiple databases, it sounds like this is effectively a duplicate of #2234. Does that sound right?
(We'd like to support multiple databases cleanly, but that tends towards more of an enhancement than a bugfix...)

Hey @gasman
Yes that sounds exactly like the problem.
Closing this issue


Strange Show/Read instances for IPv4

I believe it would make more sense for the Show instance for IPv4 to be the following:
instance Show IPv4 where
  showsPrec p addr = showParen (p > 10)
    $ showsPrec 11 a
    . showChar '.'
    . showsPrec 11 b
    . showChar '.'
    . showsPrec 11 c
    . showChar '.'
    . showsPrec 11 d
    where
    (a,b,c,d) = toOctets addr

So, the IPv4 address XX.XX.XX.XX would show as "XX.XX.XX.XX", instead of "ipv4 XX XX XX XX"
The strangeness of the Read instance follows from this reasoning.
If you think this is a good idea, I can make a PR. Otherwise, please explain why you do not think it is a good idea.

The same goes for IPv6.

The reason that I wrote them this where is that  a show instance should generate valid haskell code. This isn’t exactly a law, but derived show instances clauses always generate valid haskell code, and every type in base, containers, unordered-containers, text, and bytestring follows this rule. So, I try to play along.  This means that if someone writes a data type with an IPv4 field  and derives a show instance for it, this show instance will produce valid haskell code. This is handy for playing around in GHCi. (The way I see it, using show outside of GHCi is generally not a good idea).  Originally, the instances  originally, the instances  for all the types in this package were just the derived instances,  but those were unreadable for humans, so I ended up changing them to their current form. It is an attempt to strike a balance between readability and being haskell code.
There is some precedent for using a smart constructor forward the show instance like this. In older versions of text and vector, the instances work like this:
pack “foo”
fromList [1,2,3]

But with the introduction of OverloadedStrings and OverloadedLists,  these instances were changed to their current, simpler forms.

That is understandable.
Perhaps it would be enough to provide print functions that are not bound by precedent?

What does "print functions that are not bound by precedent" mean?
module Net.IPv4 ( ... ) where

print :: IPv4 -> IO ()
print = ...

Is that what you are describing?

Yes.
On Dec 27, 2017 1:11 PM, "Andrew Martin"<EMAIL_ADDRESS>wrote:

What does "print functions that are not bound by precedent" mean?
module Net.IPv4 ( ... ) where
print :: IPv4 -> IO ()
print = ...
Is that what you are describing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/andrewthad/haskell-ip/issues/24#issuecomment-354163217,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARyL698XEthNZn1XFmFNuVcyQQ5mVTGjks5tEpZjgaJpZM4RM8_c
.

Yeah, that sounds fine. I'll take a PR that provide a print function in each module as:
print :: TheType -> IO ()
print = Data.Text.IO.putStrLn . encode


Offline access

Can we have offline access to evernote with this app?
It would be nice that I could take a note, or modify existing notes, when the PC is offline, and then when it gets online, the note is synced automatically.

I'll second this request!

I think this app like iframe and can't offline work

Yeah, this application just opens the official evernote website in an Electron contained window. Had it used the Electron API to render it's own frontend, something like offline support would've been added (the former would obviously take a lot of work, and the latter is something of a mini-project itself).


Improve e2e

Codecov Report

Merging #27 (493c67e) into master (0256f39) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           49        49
  Lines          970       971    +1
  Branches       223       223
=========================================
+ Hits           970       971    +1

Flag
Coverage Δ

root
100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...cli/src/bin/wuzzle-unregister/wuzzle-unregister.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0256f39...493c67e. Read the comment docs.


Highlight errors in config node sidebar

Fixes #4397
This highlights any config nodes with errors in the config node sidebar.

Relying purely on a coloured border isn't idea but is a quick win. Ideally, we'd have the change/error badges consistent with the main workspace, but they are SVG artefacts and the config node sidebar is pure html. I may come back to refine this, but this moves things forward.
It reuses the CSS for unknown nodes so should be compatible with existing themes.

Now updated to show the warning triangle, including tooltip with details of the error:


prebuilt binary package for release.

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to  the what)
Parquet-rs provides CLI tool. but install requires Rust.
Describe the solution you'd like
A clear and concise description of what you want to happen.

provide prebuilt package for debian, we can use cargo-deb.
provide prebuilt package for rpm, we can use cargo-rpm.

but cargo-rpm seems no maintainer.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Another option might be to provide download of a statically linked binary. I don't think we should have any shared dependencies beyond glibc and so could possibly get away with sidestepping package management? 🤔
I've had success using this approach for Golang projects in the past...


Salesforce toolkit

Where are you using SuperAGI?
MacOS
Which branch of SuperAGI are you using?
Main
Do you use OpenAI GPT-3.5 or GPT-4?
GPT-3.5
Describe your issue.
This issue outlines the features and functionality required for the development of a Salesforce Toolkit. The toolkit aims to enable developers to interact with Salesforce's APIs for various purposes related to customer relationship management (CRM), sales, and business processes.

Provide functionality to retrieve and manipulate data stored in Salesforce.
Manage leads and opportunities within Salesforce.
Manage accounts and contacts in Salesforce.
Manage tasks and events in Salesforce.

please assign this i can help to this in contributing

Sure Vibhorjoshi!
Please create a PR in SuperAGI tools repo.
Here are the instructions to quickly get you started with contributing to SuperAGI's Tools Repository:

Start building your toolkit by following the instructions in this link
Once you've built the toolkit, make sure you've taken care of the following before submitting your toolkit for a pull request:
All the toolkit documents are made with a snake case.
Your Toolkit covers all the required unit tests.
You have included a README.md which helps the user configure the toolkit with SuperAGI. You can refer to an example Toolkit README here.
Start raising a pull request to merge your branch with the main of SuperAGI-Tools. Once approved, your tool will be merged to the main and available for the community to use!

If you think there are other additional advantageous features that could be included in the toolkit mentioned above, please don't hesitate to include them.


Created a liveness check for crunchy postgres

Signed-off-by: sathyaseelan<EMAIL_ADDRESS>
What this PR does / why we need it:

Created python script for liveness check of crunchy postgres
created a liveness litmus job

Note:

Deleted the application pod while the liveness is running the liveness failed and retry the status and its continue to run.
Finally deleted the statefulset the liveness if failed and the litmus job is completed

@ksatchit @dargasudarshan @gprasath  can you please review this PR

Connecting to the PostgreSQL database...
pass 1
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Failed
Connecting to the PostgreSQL database...
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed

sathyaseelan_n@cloudshell:~ (strong-eon-153112)$ kubectl get pods -n litmus -a
NAME                 READY     STATUS      RESTARTS   AGE
liveness-pg-r2b4h    0/1       Completed   0          11m

Good one @nsathyaseelan ! Can we take the init timeout/retry & liveness cmd timeout/interval/retry as ENV ? Would be better to have all the liveness probes taking a standard set of "liveness" params (though there may be app-specific additions)
Also, can we have the image being used in the job placed in the openebs repo ?

Postgres liveness job logs after implementing review commands:
Connecting to the PostgreSQL database...
pass 1
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Running
liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed
Connecting to the PostgreSQL database...
liveness Running
liveness Running
liveness Running
liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed
Connecting to the PostgreSQL database...
Liveness Failed


Expose G2 Engine Error Types

coverage: 71.259% (+0.1%) from 71.122%
when pulling 2ed5bee2b2ed213d37d53fab137e67cca757884c on error_types
into 1b39f743092ca95ce72408d67ab721c4be9ab616 on main.


Why redirected to /accounts/profile/ after login?

Why I am always redirected to /accounts/profile/ after login?  Can this behavior be modified on config?

It's default Django behaviour.
And yes, you can change it by setting the the standard Django setting named LOGIN_REDIRECT_URL


Where are the other images from?

I am looking at the following web page, https://openseadragon.github.io/examples/ui-reference-strip/.
In looking at "Horizontal Scrolling Image Reference Strip", I see 13 different images, as I scroll the strip.
Looking at the page source, I can see 7 image references, that collectively cover only the first two images on the "Horizontal Scrolling Image Reference Strip", one of these is a gif, why? and where do all the remaining images come from, 11 different images in total are missing from the JavaScript for the use of OpenSeadragon?
Thank you in advance for helping me to understand this.

OpenSeadragon can open a variety of tiled image formats. When you give it a tileSources array, it can be a mixture of any of those formats. In the case of the examples on that page, for some reason we're using both LegacyTileSource and DziTileSource. The LegacyTileSources are specified inline, whereas the DziTileSources are just URLs. Here's the code (starting at line 85 of that page's source):
tileSources:    [{
    type: 'legacy-image-pyramid',
    levels:[{
        url: '/example-images/rbc/rbc0001/2003/2003rosen1799/0001q.jpg',
        height: 889,
        width:  600
    },{
        url: '/example-images/rbc/rbc0001/2003/2003rosen1799/0001r.jpg',
        height: 2201,
        width:  1485
    },{
        url: '/example-images/rbc/rbc0001/2003/2003rosen1799/0001v.jpg',
        height: 4402,
        width:  2970

    }]
},{
    type: 'legacy-image-pyramid',
    levels:[{
        url: '/example-images/rpbaasm/0900/0908/090801t.gif',
        height: 150,
        width:  116
    },{
        url: '/example-images/rpbaasm/0900/0908/090801q.jpg',
        height: 400,
        width:  310
    },{
        url: '/example-images/rpbaasm/0900/0908/090801r.jpg',
        height: 860,
        width:  667
    },{
        url: '/example-images/rpbaasm/0900/0908/090801v.jpg',
        height: 1650,
        width:  1279

    }],
},
    "/example-images/highsmith/highsmith.dzi",
    "/example-images/pnp/ppmsca/05900/05954/05954.dzi",
    "/example-images/pnp/ppmsca/05900/05954/05955.dzi",
    "/example-images/pnp/ppmsca/05900/05954/05956.dzi",
    "/example-images/pnp/ppmsca/05900/05954/05957.dzi",
    "/example-images/pnp/ppmsca/05900/05954/05958.dzi",
    "/example-images/pnp/ppmsca/05900/05954/05959.dzi",
    "/example-images/pnp/ppmsca/05900/05954/05960.dzi",
    "/example-images/pnp/ppmsca/05900/05954/05961.dzi",
    "/example-images/pnp/ppmsca/05900/05954/05962.dzi",
    "/example-images/pnp/ppmsca/05900/05954/05963.dzi"
]

As you can see, the first LegacyTileSource consists of three JPEGs, each bigger than the next. The second LegacyTileSource has four tiles, the first one a GIF and the others JPEGs. I don't know why this would be, except that that's just how the sample tiles were encoded in this case. At any rate, OpenSeadragon doesn't mind if you mix file types like that.
Does that answer your question?

There are thirteen different images in the first strip in the top viewport.
The three .jpg and then the single .gif and three more .jpg URLs account for only the first two images in the viewport.
I want to know where the remaining eleven different images come from.
When I navigate to the dzi files, save them and then open them with an editor, I don't see any image references or URLs in the DZI files.

Each of the thirteen images is not just a single image file, but a "tiled image"... each image has been broken up into multiple tiles, and each tile is saved as a separate image file. In the case of the first image, there are just three tiles, specified right there. In the case of the second image, there are four tiles. All the remaining images are in DZI format. That format specifies an XML file (with the .dzi extension, though .xml is accepted) that tells OpenSeadragon about the structure. The format also specifies where to find the tiles: in a folder next to the .dzi file. In the case of the third tiled image in the example (http://openseadragon.github.io/example-images/highsmith/highsmith.dzi) the tile folder is at:
http://openseadragon.github.io/example-images/highsmith/highsmith_files/
That folder is further broken down into numbered folders for tile level, and inside of each of those are a number of individual image files (the individual tiles). You can explore this structure in the example-images repository (in its gh-pages branch):
https://github.com/openseadragon/example-images/tree/gh-pages/highsmith/highsmith_files
The same goes for the remaining 10 files specified above.
If you'd like to learn more about the DZI format, this page has a lot of info:
https://msdn.microsoft.com/en-us/library/cc645077(VS.95).aspx

I knew that, "NOT!", he says sheepishly. Thank you for dragging me into the light.
I realize now that there is a deeper level of understanding I had entirely failed to follow.
This information and the Microsoft link should go a long way to a better understanding by me.
Many thanks again.

Happy to help :)


Change TravisCI build to use new container-based infrastructure

See docs here:
http://docs.travis-ci.com/user/migrating-from-legacy/
Places we're currently using sudo:

https://github.com/NVIDIA/DIGITS/blob/v2.0.0-rc3/.travis.yml#L24
https://github.com/NVIDIA/DIGITS/blob/v2.0.0-rc3/scripts/travis/install-caffe.sh#L22-L24
And this whole file: https://github.com/NVIDIA/caffe/blob/v0.12.2/scripts/travis/travis_install.sh

That last file is the main problem. We need to make sure all the packages we need are whitelisted and then do this:
http://docs.travis-ci.com/user/migrating-from-legacy/#How-do-I-install-APT-sources-and-packages%3F

Also, they're currently working on 14.04 support. That would greatly simplify the build process since we could get more dependencies through apt-get.
http://next.travis-ci.com/

It's possible that upgrading to 14.04 could help with some of the performance issues we're seeing on TravisCI - #332, #357, #372.

Another possible improvement - cache the Caffe and Torch builds on the Travis build machines.
Example of caching dependencies and specific folders:
https://github.com/NVIDIA/caffe/blob/v0.14.0-beta/.travis.yml#L17-L23

TravisCI is going to solve this for us automatically in the next few weeks.

Starting in the first week of December 2015 (next week!) we'll begin the process of migrating the entire workload off our OpenVZ platform and onto out new GCE setup.
https://blog.travis-ci.com/2015-11-27-moving-to-a-more-elastic-future

Closing. I may address some of these other comments in future PRs.


Added support for SNAL attack

Description
This pull request adds the support of the SNAL Attack proposed in [1].
[1]Steal Now and Attack Later: Evaluating Robustness of Object Detection against Black-box Adversarial Attacks. [Paper]
Fixes # (issue)
Type of change
Please check all relevant options.

[ ] Improvement (non-breaking)
[ ] Bug fix (non-breaking)
[X] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

[X] Notebook Example

Test Configuration:

OS: Ubuntu 20.04
Python version: 3.8.12
ART version or commit number: 900f4700
PyTorch version: 1.13.1+cu116
cudnn version: 8302

Checklist

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] My changes have been tested using both CPU and GPU devices

Hi @CNOCycle Thank you very much for your contribution of the SNAL attack to ART!


Would be more faithful to data if sparklyr represented NA as Spark lit(null:*) instead of blank and NaN.

For Spark 2.0.0 spark-2.0.0-bin-hadoop2.7, sparklyr 0.4.26, dplyr 0.5.0, R 3.3.2, on OSX 10.11.6 I am seeing NA converted to blank (for strings/factors) and NaN for numeric when moving data from a local data.frame to Spark.  This seems needlessly unfaithful, as I think Spark has a NULL representation (please see here for some notes).  A complete example of the issue can be found here, and I am pasting the example below.
library('sparklyr')
packageVersion('sparklyr')
s200 <- my_db <- sparklyr::spark_connect(version='2.0.0',
   master = "local")

d2 <- data.frame(x=factor(c('z1',NA,'z3')),y=c(3,5,NA),z=c(NA,'a','z'),
                 stringsAsFactors = FALSE)
print(d2)

d2r <- copy_to(s200,d2,'d2',
               temporary = FALSE,overwrite = TRUE)
print(d2r)
d2x <- as.data.frame(d2r)
print(d2x)
summary(d2x)
str(d2x)

    ## 'data.frame':    3 obs. of  3 variables:
    ##  $ x: chr  "z1" "" "z3"
    ##  $ y: num  3 5 NaN
    ##  $ z: chr  "" "a" "z"

I believe this is a duplicate of https://github.com/rstudio/sparklyr/issues/151.
I think using NaN is the right thing to do for numeric types, but for characters + factors we definitely need to get to the bottom of the empty string vs. NA value issue!

Thanks (and sorry about the dup).  I agree the library should be as faithful as practical, but most databases allow NULL in numeric columns.  So I think NULL~NA and NaN~NaN is possible.

Does look like a dup of https://github.com/rstudio/sparklyr/issues/151 , I'll close this one.


Improve Instruction generation with respect to higher-kinded continuations

From the following closed symbol set:
data A k = A1 k | A2 (Maybe k)

We can derive a CoA:
data CoA k = CoA
  { coA1 :: k
  , coA2 :: Maybe k
  }

But the a2 symbol is improperly generated:
a1 = liftF (inj (A1 ()))
a2 = liftF (inj (A2 id))

Instead, a2 should be:
a2 = liftF (inj (A2 (Just ())))

or:
a2 = liftF (inj (A2 (pure ())))

One approach might be to analyze the A2 constructor for simple higher-kinded wrappers around the continuation parameter (like Maybe and Either) and have default implementations.
Another approach might be to look for an applicative instance with which pure would be usable.
Given that higher-kinded continuations are really only necessary when manipulating control flow, I think this can wait a while for resolution. I'll push it to post 1.0 milestone since I'm looking for usable generation at the moment, not absolute correctness of generation as incorrect generation is generally non-compilable.

Not currently applicable.


Remove sign-in assistant from assign-teams-add-on-licenses.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/8868.

@DaniEASmith PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


fix: CMSG_HEADER_ALIGNMENT was not properly equal to the C Header file in illumos

A small fix for illumos so we can add more archs to the definition. This aligns the defintions in libc with the corresponding C Headers.
I ran all the steps it asked me and only got an issue with cc1: note: unrecognized command-line option '-Wno-unknown-warning-option' may have been intended to silence earlier diagnostics although that seems to me like I am using a different gcc that CI.
This is part of the ARM work goin on at the moment.
CC: @richlowe and @jclulow for coordination.

This doesn't seem to be harmful but I'd like to hear @jclulow and/or @pfmooney's views just in case.

@Toasterson Have you run the libc tests with this change on x86 (and if it's functional, the in-progress ARM platform)?

This doesn't seem to be harmful but I'd like to hear @jclulow and/or @pfmooney's views just in case.

I'm content with the change, so long as the tests are still clean on illumos.

So Originally I tested by Compiling the ARM rustc cross compiler and compiling my Rust programs for aarch64. (The rustc aarch64 target-spec is waiting for this PR to complete)
I now ran the tests and found a bug in the tests. GCC tries to compile a main.c file to get native_getpwent_r but that fails.
I get
   Compiling libc-test v0.2.140 (/ws/toasty/rust-libc/libc-test)
The following warnings were emitted during compilation:

warning: /ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c: In function '__test_fn_native_getpwent_r':
warning: /ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c:24289:24: error: 'native_getpwent_r' undeclared (first use in this function)
warning: 24289 |                 return native_getpwent_r;
warning:       |                        ^~~~~~~~~~~~~~~~~
warning: /ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c:24289:24: note: each undeclared identifier is reported only once for each function it appears in
warning: /ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c: In function '__test_fn_native_getgrent_r':
warning: /ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c:24294:24: error: 'native_getgrent_r' undeclared (first use in this function)
warning: 24294 |                 return native_getgrent_r;
warning:       |                        ^~~~~~~~~~~~~~~~~
warning: /ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c: In function '__test_fn_native_getpwent_r':
warning: /ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c:24290:13: error: control reaches end of non-void function [-Werror=return-type]
warning: 24290 |             }
warning:       |             ^
warning: /ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c: In function '__test_fn_native_getgrent_r':
warning: /ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c:24295:13: error: control reaches end of non-void function [-Werror=return-type]
warning: 24295 |             }
warning:       |             ^
warning: /ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c: At top level:
warning: cc1: note: unrecognized command-line option '-Wno-unknown-warning-option' may have been intended to silence earlier diagnostics
warning: cc1: all warnings being treated as errors

error: failed to run custom build command for `libc-test v0.2.140 (/ws/toasty/rust-libc/libc-test)`

Caused by:
  process didn't exit successfully: `/ws/toasty/.cargo-target/debug/build/libc-test-248b631f5c35cebb/build-script-build` (exit status: 1)
  --- stdout
  TARGET = Some("x86_64-unknown-illumos")
  OPT_LEVEL = Some("0")
  HOST = Some("x86_64-unknown-illumos")
  cargo:rerun-if-env-changed=CC_x86_64-unknown-illumos
  CC_x86_64-unknown-illumos = None
  cargo:rerun-if-env-changed=CC_x86_64_unknown_illumos
  CC_x86_64_unknown_illumos = None
  cargo:rerun-if-env-changed=HOST_CC
  HOST_CC = None
  cargo:rerun-if-env-changed=CC
  CC = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64-unknown-illumos
  CFLAGS_x86_64-unknown-illumos = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64_unknown_illumos
  CFLAGS_x86_64_unknown_illumos = None
  cargo:rerun-if-env-changed=HOST_CFLAGS
  HOST_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
  running: "gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-Wall" "-Wextra" "-D_XOPEN_SOURCE=700" "-o" "/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/src/cmsg.o" "-c" "src/cmsg.c"
  exit status: 0
  cargo:rerun-if-env-changed=AR_x86_64-unknown-illumos
  AR_x86_64-unknown-illumos = None
  cargo:rerun-if-env-changed=AR_x86_64_unknown_illumos
  AR_x86_64_unknown_illumos = None
  cargo:rerun-if-env-changed=HOST_AR
  HOST_AR = None
  cargo:rerun-if-env-changed=AR
  AR = None
  cargo:rerun-if-env-changed=ARFLAGS_x86_64-unknown-illumos
  ARFLAGS_x86_64-unknown-illumos = None
  cargo:rerun-if-env-changed=ARFLAGS_x86_64_unknown_illumos
  ARFLAGS_x86_64_unknown_illumos = None
  cargo:rerun-if-env-changed=HOST_ARFLAGS
  HOST_ARFLAGS = None
  cargo:rerun-if-env-changed=ARFLAGS
  ARFLAGS = None
  running: "gar" "cq" "/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/libcmsg.a" "/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/src/cmsg.o"
  exit status: 0
  running: "gar" "s" "/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/libcmsg.a"
  exit status: 0
  cargo:rustc-link-lib=static=cmsg
  cargo:rustc-link-search=native=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out
  -----------------------------------------
  cargo:rerun-if-changed=../src/lib.rs
  cargo:rerun-if-changed=../src/macros.rs
  cargo:rerun-if-changed=../src/fixed_width_ints.rs
  cargo:rerun-if-changed=../src/unix/mod.rs
  cargo:rerun-if-changed=../src/unix/solarish/mod.rs
  cargo:rerun-if-changed=../src/unix/solarish/compat.rs
  cargo:rerun-if-changed=../src/unix/solarish/illumos.rs
  cargo:rerun-if-changed=../src/unix/solarish/x86_64.rs
  cargo:rerun-if-changed=../src/unix/solarish/x86_common.rs
  OPT_LEVEL = Some("0")
  HOST = Some("x86_64-unknown-illumos")
  cargo:rerun-if-env-changed=CC_x86_64-unknown-illumos
  CC_x86_64-unknown-illumos = None
  cargo:rerun-if-env-changed=CC_x86_64_unknown_illumos
  CC_x86_64_unknown_illumos = None
  cargo:rerun-if-env-changed=HOST_CC
  HOST_CC = None
  cargo:rerun-if-env-changed=CC
  CC = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64-unknown-illumos
  CFLAGS_x86_64-unknown-illumos = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64_unknown_illumos
  CFLAGS_x86_64_unknown_illumos = None
  cargo:rerun-if-env-changed=HOST_CFLAGS
  HOST_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
  running: "gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-Wall" "-Wextra" "-Wall" "-Wextra" "-Werror" "-Wno-unused-parameter" "-Wno-type-limits" "-Wno-address-of-packed-member" "-Wno-unknown-warning-option" "-Wno-deprecated-declarations" "-Wno-deprecated-declarations" "-D_XOPEN_SOURCE=700" "-D__EXTENSIONS__" "-D_LCONV_C99" "-o" "/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/67cd148b4c1ea303-main.o" "-c" "/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c"
  cargo:warning=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c: In function '__test_fn_native_getpwent_r':
  cargo:warning=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c:24289:24: error: 'native_getpwent_r' undeclared (first use in this function)
  cargo:warning=24289 |                 return native_getpwent_r;
  cargo:warning=      |                        ^~~~~~~~~~~~~~~~~
  cargo:warning=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c:24289:24: note: each undeclared identifier is reported only once for each function it appears in
  cargo:warning=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c: In function '__test_fn_native_getgrent_r':
  cargo:warning=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c:24294:24: error: 'native_getgrent_r' undeclared (first use in this function)
  cargo:warning=24294 |                 return native_getgrent_r;
  cargo:warning=      |                        ^~~~~~~~~~~~~~~~~
  cargo:warning=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c: In function '__test_fn_native_getpwent_r':
  cargo:warning=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c:24290:13: error: control reaches end of non-void function [-Werror=return-type]
  cargo:warning=24290 |             }
  cargo:warning=      |             ^
  cargo:warning=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c: In function '__test_fn_native_getgrent_r':
  cargo:warning=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c:24295:13: error: control reaches end of non-void function [-Werror=return-type]
  cargo:warning=24295 |             }
  cargo:warning=      |             ^
  cargo:warning=/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c: At top level:
  cargo:warning=cc1: note: unrecognized command-line option '-Wno-unknown-warning-option' may have been intended to silence earlier diagnostics
  cargo:warning=cc1: all warnings being treated as errors
  exit status: 1

  --- stderr
  rust version: 1.65.0

  error occurred: Command "gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-Wall" "-Wextra" "-Wall" "-Wextra" "-Werror" "-Wno-unused-parameter" "-Wno-type-limits" "-Wno-address-of-packed-member" "-Wno-unknown-warning-option" "-Wno-deprecated-declarations" "-Wno-deprecated-declarations" "-D_XOPEN_SOURCE=700" "-D__EXTENSIONS__" "-D_LCONV_C99" "-o" "/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/67cd148b4c1ea303-main.o" "-c" "/ws/toasty/.cargo-target/x86_64-unknown-illumos/debug/build/libc-test-9d9b3b050483f738/out/main.c" with args "gcc" did not execute successfully (status code exit status: 1).

@pfmooney did we recently change some things in the API's there? because the C file generated tries to find all the API's like automake does just all in one big C file. So there needs to be a header definition added to that file I think

In general it seems wrong to me that the C file looks for native_* without linking them because without the native_ prefix the functions exist.

The failure seems unrelated anyway, @bors r=JohnTitor,pfmooney

:pushpin: Commit 595c2aba82937ab954037c1ebe4baf5f88afe9b4 has been approved by JohnTitor,pfmooney
It is now in the queue for this repository.

:hourglass: Testing commit 595c2aba82937ab954037c1ebe4baf5f88afe9b4 with merge 362b0d765402dc2bcc22f8a68be3a6e15f2d0fd0...

:broken_heart: Test failed - checks-actions

 error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-1.25.0.toml.sha256' to '/Users/runner/.rustup/tmp/c5re5ggquj09ubvw_file': failed to make network request: error sending request for url (https://static.rust-lang.org/dist/channel-rust-1.25.0.toml.sha256): operation timed out: operation timed out

@bors retry

:hourglass: Testing commit 595c2aba82937ab954037c1ebe4baf5f88afe9b4 with merge 79b7d3c7520a29c98f346285b1184091fd36fff2...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor,pfmooney
Pushing 79b7d3c7520a29c98f346285b1184091fd36fff2 to master...


Feature/slice 122 cannot add custom processor in some cases

Coverage increased (+1.06%) to 69.03% when pulling ab4e667801104e0aaa7403a38453108b10036560 on feature/SLICE-122-Cannot-add-custom-processor-in-some-cases into a7c4fa2b7956126aafe2899dfad3ceebd8ba1000 on master.


When enable gcp , got nothing from the gcp file

basic information
srs version: srs-5.0.63
machine: centos7.9
How to replay the issue?
./configure --with-gperf --with-gcp
make
rm -f gperf.srs.gcp*; ./objs/srs -c conf/console.conf

# Or CTRL+C to stop GCP
killall -2 srs

after kill the srs,
got such console log
[2022-09-30 04:41:23.352][Trace][3068][7u88002y] TCP: clear zombies=1 resources, conns=1, removing=0, unsubs=0
[2022-09-30 04:41:23.352][Trace][3068][5yl585wi] TCP: disposing #0 resource(HttpConn)(0x1f35680), conns=1, disposing=1, zombies=0
[2022-09-30 04:41:24.210][Trace][3068][9r84c019] Hybrid cpu=1.00%,27MB
[2022-09-30 04:41:24.216][Trace][3068][tz15tf07] Process: cpu=1.00%,27MB, threads=2
[2022-09-30 04:41:29.211][Trace][3068][9r84c019] Hybrid cpu=1.00%,27MB, cid=2,2, timer=61,0,0, clock=0,29,18,1,0,0,0,0,0, free=1
[2022-09-30 04:41:29.221][Trace][3068][tz15tf07] Process: cpu=1.00%,27MB, threads=2
^C[2022-09-30 04:41:32.061][Trace][3068][765pjp4b] sig=2, user terminate program, fast quit
[2022-09-30 04:41:32.223][Trace][3068][765pjp4b] cleanup for quit signal fast=1, grace=0
[2022-09-30 04:41:33.225][Trace][3068][tz15tf07] quit for thread #2(hybrid) finished
PROFILE: interrupts/evictions/bytes = 0/0/64

then analyse the gperf.srs.gcp file
$ ./objs/pprof --text ./objs/srs gperf.srs.gcp
Using local file ./objs/srs.
Using local file gperf.srs.gcp

There is nonthing about the cpu analysis.
Expect behaviour
get some function call information

issue resolved


Add axioms for energy transformation #1543

Added two axioms to energy transformation.
Type of change (CHANGELOG.md)
Updated

Improved Axiomisation #

Closes #1543
PR-Assignee

[ ] 🐙 Follow the Pull Request Workflow
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

In the header it says that you updated a definition. Did you or is it an artifact? The header should contain clean descriptions for documentation

One minor remark for the next PR: please check again the the naming conventions for branches

everything seems to be fine to me, just make sure there are no issues with "Resolve Conflicts" when you merge.

@viktorwichern on august 1st, we are going to do the next release. Can you manage to fix this PR by then?

Yes, I'll close this PR and open a new one.


CIR returns multiple values

Similarly to conversion inchikey -> smiles, other conversions can return multiple hits, separated by newline.

What is the reasoning behind treating the first of the set as a response and throw away the rest? Is it the best hit?

CIR provides no additional information about its outputs, so I assume the first one is the best hit. Nevertheless, the response contains only the values themselves separated by a newline, so there is no way to decide their fitness.

Well that is confusing, does the API have some docs or is it presented "as is"? :D

Documentation is here (when it works...), but the responses are not really described (e.g. it wasn't even clear there can be multiple hits in a response, thus this issue).

So just to clarify, is this issue still active?

@xtrojak can this be closed?

Yes, all retrieve methods wrap the result in retrieve_first method, so it should be good.


Making JavaScript to TypeScript migration easier : Suppress errors

Motivation
I am looking for community ideas to make partial migration from JavaScript to TypeScript easier. Currently the errors suppression mechanism is ugly :  http://basarat.gitbooks.io/typescript/content/docs/types/migrating.html and can cause long term pain. (Am I overlooking something?)
Plan
I imagine that one creates a .ts file and writes plain JavaScript inside it and has a way to tell TypeScript to only reports errors that are invalid JS.  Anybody have suggestions on how the configuration for this should look like?

We've been talking a lot about this lately. Migration is painful enough in certain cases to be an adoption blocker.

that are invalid JS

I have some ideas, but I'm curious how you define this? Syntactic errors only?

I'm curious how you define this

Implementation
I feel like going though diagnostics disabling reporting all to begin with, and then switching on the ones that make sense for all JavaScript. Especially switching on the Syntactic ones.
Configuration

Providing finer control over diagnostics so that a team controls what valid JS means to them. Question : How to specify these ignored error codes?

Secondly how to tell compiler this .ts file should be treated like js.

Both questions are configuration related (assuming an implementation around using diagnostic error codes sounds reasonable).

I don't understand - in what way is the migration painful? The compiler still generates JS files. The editor (or an external filtering tool) can be used to filter out error messages in legacy code (based on both paths or error codes), i.e. tsc | tsc-filter-errors
Besides there is no better todo message than a compiler error: its there exactly as long as the code isn't annotated and its impossible to forget to add/remove it.

Pushing the filtering downstream means multiple toolchains have to agree on the error filtering schema, and implement them with 100% consistency. It's herding :cat2: :cat2: :cat2:
It's also more natural to specify in the file itself what the "migration state" of that file is instead of mucking with a giant list of files in a config file somewhere (not to mention if that file is used in multiple projects). Flow uses a similar setup.

Besides there is no better todo message than a compiler error

We kind of have to acknowledge developer irrationality on this front. No one can get away with checking in a toolchain that produces 150 errors and tell their team "Hey guys, we'll fix those when we get around to it". I've worked on teams that did try that (with a style checker that just produced a total number of warnings in the default build pipeline) and the number of errors actually grew over time because it was totally ignored.

Reading the blog post and not having tried it myself http://blogs.msdn.com/b/typescript/archive/2016/01/28/announcing-typescript-1-8-beta.aspx can this be closed because of allowJS or is there something more? :rose:

sounds good. closing. we can reopen if there are other feedback.

#6802 could potentially come into play here also. That issue will track any design & implementation.

I agree, I think a developer should a super power of TS to hide an error if he/she decides to...
maybe a ///TS_IGNORE above a line that ts inferred an error on...
be great!

I would propose maintaining syntax consistency with https://github.com/palantir/tslint/issues/1175.
// ts:disable-next-line

"errorReporting": {
  "excludeFiles": ["src/legacy/**/*.ts", ...],
  "excludeCodes": [7005, ...]
}

The above would be great!
Currently, the inability to disable specific errors that I don't care about is the biggest downside for me about TypeScript. (mostly for cases where I just want it to default to type "any", because I know the code works fine despite not being compile-time-guaranteed type-safe)

The above is really needed. Here is an example of code that I believe is correct but throws a bunch of errors:
export type Constructor<T> = new (...args: any[]) => T; export default function FooableMixin<T extends Constructor<{}>>(Base: T) {     return class extends Base implements IFooable {         constructor(...args: any[]) {             super(...args);         }     } } export class BaseBar {} export class FooableBar extends FooableMixin ( BaseBar ) {}
This throws: TS4060, TS4093 and TS4020
Because I cannot export the anonymous class so its public.
A really nice solution would be to not turn off Errors but turn them into Warnings.

There is another flavor of the issue when I use an existing library such as http://trackingjs.com/. I want to suppress errors based on their place (library) rather than specific errors. This may need to be a tsconfig option.


I found a new issue on jiocinema at another url.

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
I found a new issue on jiocinema at another url.
Url:  https://www.jiocinema.com/tv-shows/maa-durga/1/ma-durga-16th-apr-2016/3152389
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
Microsoft Windows [Version 10.0.22631.3737]
(c) Microsoft Corporation. All rights reserved.

C:\Users\moder\Downloads\JC>yt-dlp -vU https://www.jiocinema.com/tv-shows/maa-durga/1/ma-durga-16th-apr-2016/3152389
[debug] Command-line config: ['-vU', 'https://www.jiocinema.com/tv-shows/maa-durga/1/ma-durga-16th-apr-2016/3152389']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [f10589e34] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.22631-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2024-02-01-git-94422871fc-essentials_build-www.gyan.dev (setts), ffprobe 2024-02-01-git-94422871fc-essentials_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.19.1, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.31.0, sqlite3-3.35.5, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1798 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
[debug] Downloading _update_spec from https://github.com/yt-dlp/yt-dlp/releases/latest/download/_update_spec
[debug] Downloading SHA2-256SUMS from https://github.com/yt-dlp/yt-dlp/releases/download/2024.05.27/SHA2-256SUMS
Current version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
Current Build Hash: 160b304bef9fa134d523b46cc3647a727e40584338379eb4e0d1047de945fad9
Updating to<EMAIL_ADDRESS>from yt-dlp/yt-dlp ...
[debug] Downloading yt-dlp.exe from https://github.com/yt-dlp/yt-dlp/releases/download/2024.05.27/yt-dlp.exe
Updated yt-dlp to<EMAIL_ADDRESS>from yt-dlp/yt-dlp
[debug] Restarting: yt-dlp -vU "https://www.jiocinema.com/tv-shows/maa-durga/1/ma-durga-16th-apr-2016/3152389"
[debug] Command-line config: ['-vU', 'https://www.jiocinema.com/tv-shows/maa-durga/1/ma-durga-16th-apr-2016/3152389']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [12b248ce6] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.22631-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2024-02-01-git-94422871fc-essentials_build-www.gyan.dev (setts), ffprobe 2024-02-01-git-94422871fc-essentials_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.02.02, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.2, sqlite3-3.35.5, urllib3-2.2.1, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Loaded 1820 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[jiocinema] Extracting URL: https://www.jiocinema.com/tv-shows/maa-durga/1/ma-durga-16th-apr-2016/3152389
[jiocinema] Downloading guest token
[jiocinema] 3152389: Downloading playback JSON
[jiocinema] 3152389: Downloading JSON metadata
[jiocinema] 3152389: Downloading m3u8 information
ERROR: [jiocinema] 3152389: No video formats found!; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
Traceback (most recent call last):
  File "yt_dlp\YoutubeDL.py", line 1606, in wrapper
  File "yt_dlp\YoutubeDL.py", line 1762, in __extract_info
  File "yt_dlp\YoutubeDL.py", line 1821, in process_ie_result
  File "yt_dlp\YoutubeDL.py", line 2825, in process_video_result
  File "yt_dlp\YoutubeDL.py", line 1104, in raise_no_formats
yt_dlp.utils.ExtractorError: [jiocinema] 3152389: No video formats found!; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U

Okay, the issue here is that the jiocinema extractor filters out too many extractors. https://github.com/yt-dlp/yt-dlp/issues/10144#issuecomment-2156706489
We will use this issue to keep track of that issue specifically.
However, even with that fixed, this video wouldn't download. The DASH stream the browser uses is DRM protected. The HLS stream is corrupted, where the variant URLs return with a 404. So this is another instance of #10225. Sadly, there is nothing yt-dlp can do about the site serving corrupt data.


Finish-Event not working

I have tried to put a finish-event on one of the stages for a Quest, for example giving an item to the player. But it does not work when the player completes that stage, the only way I got it to work was to make the event a start-event at the beginning of the next stage.
I have also tried this with events that include teleporting the player, applying effects and despawning npcs, the only way it works is to make it a start-event.

This is also the same for mob spawning as well

Update: I think this is only when there is more than one stage, it seems to work when a finish-event is on a Single Stage Quest, but not multiple ones.

Cannot duplicate. Please post the related quest.

Well it happens with quite a few quests if you put the finish-event as something such as despawning an NPC.
Here's one quest we had that didn't work, so we changed the finish-event: faeambush to a start-event in the next stage.
custom1:
name: A Fair Deal
npc-giver-id: 108
ask-message: Poor cat... Perhaps there's something you can do for it.
finish-message: And so, you think to yourself, "What in the world was that about??"
gui-display: name-FISHING_ROD:amount-1
requirements:
mcmmo-skills:
- Taming
mcmmo-amounts:
- 20
fail-requirement-message: The cat blatantly ignores you. Perhaps you need to work on your animal skills...
stages:
ordered:
'1':
fish-to-catch: 1
start-message: Looking towards you, Pangur Bán let's you pet him. Perhaps a fish would score some brownie-points.
'2':
locations-to-reach:
- Quests 137.0 40.0 -449.0
reach-location-radii:
- 7
reach-location-names:
- Pangur Bán's Stump
finish-event: FaeAmbush
'3':
npc-ids-to-kill:
- 116
npc-kill-amounts:
- 1
death-event: DeathFail
'4':
items-to-deliver:
- name-RAW_FISH:amount-1
npc-delivery-ids:
- 108
delivery-messages:
- The cat gobbles the poor fish up, totally undisturbed by the events it just witnessed.
finish-event: TitleComplete
rewards:
quest-points: 2
mcmmo-skills:
- Fishing
- Taming
mcmmo-levels:
- 5
- 2
This is what the FaeAmbush event is:
FaeAmbush:
message: You sense a disturbing force approaching...
commands:
- npc spawn 116
When it was a finish-event, the NPC didn't ever spawn. Only when we changed it to a start-event on the next stage.

Sorry whoshenry, could you throw that up on pastebin or something? I can't seem to get the file formatted properly with no indents.

Sure, the quests entry - http://pastebin.com/2Jmgj1EC and the events entry - http://pastebin.com/8Vgqvhdj

I was able to complete the quest using the information you provided (I only changed the NPC IDs to some I had already spawned). http://i.imgur.com/QpccXLn.png

Closing (tested working). If the issue persists, please open a new ticket.


Implement FASTA file processing

This is a rewrite of the Biopython FASTA file processing library
https://github.com/biopython/biopython/blob/master/Bio/Seq.py

I'm confused. How is this different from #5?

I'm confused. How is this different from #5?

#5 is not merged, dunno why the PR shows up as merged. You can ignore it


Files starting with a . are ignored

I was trying to upload an aws lambda within one of my modules but terragrunt ignores:

.prettierrc.js
.eslintrc.js
.eslintignore

And that makes the deploy script of my lambda fail, is that how it is supposed to be or is it a bug? Maybe I'm just missing a configuration.
Thanks

Closing as duplicate of #394.


feat: Process requirements to support dependency aliases

I have a chart that uses dependency aliases (https://docs.helm.sh/developing_charts/#alias-field-in-requirements-yaml).
Landscaper was able to deploy it correctly but it would always try to update it, even when there was no changes at all. I investigated a little and found out that landscaper doesn't load the chart values correctly when using aliases. This breaks the diff between helm state and file state and makes Landscaper attempt an update.
By looking at Helm code I found out that the chart dependencies are actually updated in the "chartutil.ProcessRequirementsEnabled" method. This will add dependencies for aliases but also remove disable charts. I only tested this for dependencies aliases but I think that removing disabled charts is also something we want to do.
I have not added tests at this time. I'm not familiar enough with the code yet but I think that we would need to be able to inject the "chartutil.LoadRequirements" method somehow to test this.

Looks good to me, thanks!