Multiple paths for package in manifest release

Is it possible to have multiple paths trigger a release for a package in the release-please-config.json?
I'm using Turborepo, which has apps and packages directories which contain apps and libraries, respectively. I would like it if updates to a specific package triggered a release for an app.
Can this be achieved, currently?

I'm unfamiliar with Turborepo, but we have a concept of workspace plugins that are meant to trigger dependency version bumps between dependent components in a monorepo. These plugins build a dependency tree of interrelated libraries and if a library is updated, we try and bump the version in any other libraries that depend on that library. You may be interested in the node-workspace plugin if your components all have package.json files

@chingor13 I am in need of this feature as well. Are there any workspace plugins that work for Go projects?

I was envisioning something like this is the config:
{
  ...
  "packages": {
    "app": {
      "package-name": "app"
      "dependencies": ["shared"]
    },
    "shared": {
      "package-name": "shared"
    }
  },
}

So that if anything in my shared directory changes it would trigger a release of my app with a major/minor/patch bump that matches what type of bump was done on shared

@hspitzley-czi I think that's what the node-workspace plugin is supposed to do. Unfortunately, I haven't had the time to try it out. It's on our backlog though.

@hspitzley-czi I think that's what the node-workspace plugin is supposed to do. Unfortunately, I haven't had the time to try it out. It's on our backlog though.

My understanding was that that plugin was specific to nodejs so I was hoping for a language agnostic solution that would allow me to define dependencies in my Go monorepo

@hspitzley-czi I think that's what the node-workspace plugin is supposed to do. Unfortunately, I haven't had the time to try it out. It's on our backlog though.

I just tried this out, it does not as expected yet.

it bumped the version in PR, but included not in the released output

The behavior would be similar to the node-workspace plugin but language agnostic and require a bit more manual configuration in the release config.

This does seem very similar to what the workspace plugins are doing, but with a different versioning strategy -- where the semver bump type is matched. It might be possible to modify the workspace plugins to accept a versioning strategy configuration where it knows the version type change of the source artifact and it matches that version type change when it bumps the dependee artifact.

@chingor13

A language-independent plugin is hard because it needs to know which files to update, unless you are going to only rely on the configuring generic updaters (Generic, GenericXml, etc.)

We rely on the inline comment markers like this ( (which I guess are powered by the generic updaters?). We find these work nicely. We use them heavily for updating documentation, etc, so it's no issue for us.

I would appreciate something like this for managing a monorepo containing a number of C++ projects. Language specific version updates are not of great interest in this case either. Though it does seem like using the extra-files config of the manifest could be used to customize version number information.
A simple way to model that X package incorporates extra code from specific paths, and conventional commits to those paths affect the version number as if they where in the directory of X package would greatly simplify shared code scenarios.

@chingor13 Are you in favor of having an implementation for this? I will happily do it if it's something I know isn't a dead-end.

Any news related to this? I think it would be super useful to have this feature 🙏


Error on Cancel FA Ledg. Entries with type Proceeds on Disposal

Hello
In 16.3 in codeunit 5600 "FA Insert Ledger Entry", function InsertFA is added a new code:
    if FALedgEntry."FA Posting Type" = FALedgEntry."FA Posting Type"::"Proceeds on Disposal" then begin
        TempFALedgerEntryReverse := FALedgEntry;
        TempFALedgerEntryReverse.Insert();
        ReverseFALedgerEntryAmounts(FALedgEntry);
    end;

this code cause an error when trying to cancel entries with FA Posting Type = Proceeds on Disposal:
Error: "FA Error Entry No. = 89 does not match the journal line for Fixed Asset No. = FA000010 in Depreciation Book Code = COMPANY"
The reason is in next code:
    if ErrorEntryNo > 0 then begin
        if not FALedgEntry2.Get(ErrorEntryNo) then
            Error(
              Text000,
              FAName(DeprBookCode), FALedgEntry2.FieldCaption("Entry No."), ErrorEntryNo);
        if (FALedgEntry2."Depreciation Book Code" <> FALedgEntry."Depreciation Book Code") or
           (FALedgEntry2."FA No." <> FALedgEntry."FA No.") or
           (FALedgEntry2."FA Posting Category" <> FALedgEntry."FA Posting Category") or
           (FALedgEntry2."FA Posting Type" <> FALedgEntry."FA Posting Type") or
           (FALedgEntry2.Amount <> -FALedgEntry.Amount) or
           (FALedgEntry2."FA Posting Date" <> FALedgEntry."FA Posting Date")
        then
            Error(
              Text001,
              FAName(DeprBookCode), FAJnlLine.FieldCaption("FA Error Entry No."), ErrorEntryNo);

The problem is that in the new code (shown in the beginnig) the Amount of the FALedgEntry was reversed and has same sign with FALedgEntry2.Amount (the entry that we want to cancel), so it not pass the check.

Thank you for reaching out. Your request could be reporting a product bug not related to the AL extensibility.
Please reach out to the relevant support channels as specified in Product Support
On premises - https://support.microsoft.com/en-us/supportforbusiness/productselection?sapId=93d37907-ad94-d591-22e9-593cfa09dd3f
On line – read more here https://docs.microsoft.com/en-ca/dynamics365/business-central/dev-itpro/administration/manage-technical-support or contact your partner
If you are a partner open a support incident through Partner Center - https://partner.microsoft.com/en-us/pcv/dashboard/overview


docs: Fix data type for submessages field on message type.

Before this commit our docs mentioned string[] data type for submessages field on the message object. This commit changes the type to object[] and correctly mentions all fields of the submessage object.

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

I would have thought our OpenAPI validation tests would have caught this, where we validate every non-failed payload against the schemas. I opened https://github.com/zulip/zulip/issues/25896 to track that issue.

(The textual descriptions are not really up to our writing quality standards here, but it's an "experimental" feature and I don't feel the need to address that right now).


chore(release): 1.73.0

See CHANGELOG

404 on https://downloads.apache.org/maven/maven-3/3.8.6/binaries/apache-maven-3.8.6-bin.tar.gz
Seems https://downloads.apache.org/maven/maven-3/3.8.7/binaries/apache-maven-3.8.7-bin.tar.gz should be in place.


Intermittent 'Repository Dose Not Exists !' error whilst trying to sync

Describe the bug
Intermittent 'Repository Dose Not Exists !' error whilst trying to sync
To Reproduce
Steps to reproduce the behavior:

Run workflow for multiple repositories

Expected behavior
Workflows should sync across all repositories
Additional context
We have multiple repositories being used for syncing and we are constantly running into the Repository Dose Not Exists ! error. It does not happen all the time but intermittent

@kevinvella1 sorry about that. but can you provide more info?

is that a private repository ?
how often dose this occur for you ?
have you tried setting up proper Access Token for it ?

This error occurs when the token provided to the action in the input GITHUB_TOKEN does not have access to the downstream repos.

I can reliably reproduce this by calling the action twice.
      - name: Fetching Local Repository
        uses: actions/checkout@master

      - name: Running Workflow Sync - K8s
        # uses: varunsridharan/action-github-workflow-sync@decdb07b953f882d879ffbd4eb82a588842e22b9
        uses: FATMAP/action-github-workflow-sync@cd4f0dbfb282260c1fcad62bd31a6a7c1d00d410
        env:
          REPOSITORIES: |
            FATMAP/search-infra
          WORKFLOW_FILES: |
            github-actions/k8s/.=.github/workflows
        with:
          DRY_RUN: ${{ env.DRY_RUN }}
          REPOSITORIES: ${{ env.REPOSITORIES }}
          WORKFLOW_FILES: ${{ env.WORKFLOW_FILES }}
          GITHUB_TOKEN: ${{ secrets.WORKFLOW_SYNC_PERSONAL_ACCESS_TOKEN }}
          PULL_REQUEST: true
          COMMIT_EACH_FILE: true

      - name: Running Workflow Sync - K8s
        # uses: varunsridharan/action-github-workflow-sync@decdb07b953f882d879ffbd4eb82a588842e22b9
        uses: FATMAP/action-github-workflow-sync@cd4f0dbfb282260c1fcad62bd31a6a7c1d00d410
        env:
          REPOSITORIES: |
            FATMAP/search-infra
          WORKFLOW_FILES: |
            github-actions/k8s/.=.github/workflows
        with:
          DRY_RUN: ${{ env.DRY_RUN }}
          REPOSITORIES: ${{ env.REPOSITORIES }}
          WORKFLOW_FILES: ${{ env.WORKFLOW_FILES }}
          GITHUB_TOKEN: ${{ secrets.WORKFLOW_SYNC_PERSONAL_ACCESS_TOKEN }}
          PULL_REQUEST: true
          COMMIT_EACH_FILE: true

Run FATMAP/action-github-workflow-sync@cd4f0dbfb282260c1fcad62bd31a6a7c1d00d410
-------------------------------------------------------
⚙ Basic Config
  * AUTO_CREATE_NEW_BRANCH     : false
  * COMMIT_EACH_FILE           : true
  * PULL_REQUEST               : true
  * DRY_RUN                    : true
  * WORKFLOW_FILES_DIR         : workflows
  * WORKSPACE                  : /home/runner/work/workflow-sync/
  * SKIP_CI                    : false
  * COMMIT_MESSAGE             : false
-------------------------------------------------------

📓 FATMAP/search-infra
  ⚙ Repository Config
  	Slug        : search-infra
  	Owner       : FATMAP
  	Git URL     : ***github.com/FATMAP/search-infra.git
  	Branch      : default
  	Local Path  : /home/runner/work/workflow-sync/FATMAP/search-infra/default/
  	✔  Repository Cloned
  	✔  Pull Request Branch "file-sync-10-master-1622567253" Created From master

  🗃 Git Config
  	> Name  : Workflow Sync Bot
  	> Email<EMAIL_ADDRESS>
  github-actions/k8s/.=.github/workflows
  	✔  github-actions/k8s/. => .github/workflows
  ✔  [file-sync-10-master-1622567253 b010d2e] 💬 - Files Synced | Runner ID : 10 | ⚡ Triggered By FATMAP/github-file-sync
   2 files changed, 135 insertions(+)
   create mode 100644 .github/workflows/kustomize-lint.yaml
   create mode 100644 .github/workflows/skaffold-deploy.yaml

  Warning: ⚠ No Changes Are Pushed
  Git Status
  On branch file-sync-10-master-1622567253
  nothing to commit, working tree clean

0s
Run FATMAP/action-github-workflow-sync@cd4f0dbfb282260c1fcad62bd31a6a7c1d00d410
  with:
    DRY_RUN: true
    REPOSITORIES: FATMAP/search-infra

    WORKFLOW_FILES: github-actions/k8s/.=.github/workflows

    GITHUB_TOKEN: ***
    PULL_REQUEST: true
    COMMIT_EACH_FILE: true
    WORKFLOW_FILES_DIR: workflows
    AUTO_CREATE_NEW_BRANCH: false
    SKIP_CI: false
    COMMIT_MESSAGE: false
  env:
    DRY_RUN: true
    REPOSITORIES: FATMAP/search-infra

    WORKFLOW_FILES: github-actions/k8s/.=.github/workflows

-------------------------------------------------------
⚙ Basic Config
  * AUTO_CREATE_NEW_BRANCH     : false
  * COMMIT_EACH_FILE           : true
  * PULL_REQUEST               : true
  * DRY_RUN                    : true
  * WORKFLOW_FILES_DIR         : workflows
  * WORKSPACE                  : /home/runner/work/workflow-sync/
  * SKIP_CI                    : false
  * COMMIT_MESSAGE             : false
-------------------------------------------------------

📓 FATMAP/search-infra
  ⚙ Repository Config
  	Slug        : search-infra
  	Owner       : FATMAP
  	Git URL     : ***github.com/FATMAP/search-infra.git
  	Branch      : default
  	Local Path  : /home/runner/work/workflow-sync/FATMAP/search-infra/default/
  Error: 	🛑  Repository Dose Not Exists !

Additionally, these errors do not fail the workflow, which they probably should


updated_error_message

Signed-off-by: Axit Patel<EMAIL_ADDRESS>Description
This PR fixes #5231
Notes for Reviewers
In the Error Code Reference Guide,I have swap \n for
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #5424 (058772a) into master (6b100a3) will decrease coverage by 4.29%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5424      +/-   ##
==========================================
- Coverage   17.42%   13.12%   -4.30%
==========================================
  Files         107      107
  Lines        9909     9909
==========================================
- Hits         1727     1301     -426
- Misses       7760     8331     +571
+ Partials      422      277     -145

Flag
Coverage Δ

gointegrationtests
?

unittests
13.12% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/error.go
0.00% <0.00%> (ø)

mesheryctl/internal/cli/root/system/update.go
1.05% <0.00%> (-58.95%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
1.88% <0.00%> (-55.19%)
:arrow_down:

mesheryctl/internal/cli/root/system/status.go
1.14% <0.00%> (-55.18%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
1.92% <0.00%> (-48.08%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
2.15% <0.00%> (-44.61%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
3.26% <0.00%> (-36.96%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.03% <0.00%> (-23.03%)
:arrow_down:

mesheryctl/internal/cli/root/system/dashboard.go
1.70% <0.00%> (-9.41%)
:arrow_down:

mesheryctl/pkg/utils/healthcheck.go
8.82% <0.00%> (-4.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b100a3...058772a. Read the comment docs.


Routes are not ensured when connect to VM console via WebSocket

When connect to vm console via tunnel or directly, the routes are ensured.
https://github.com/apache/cloudstack/blob/45daa1ce591a43442c30cc6ec9a70124440063eb/services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java#L291-L297
https://github.com/apache/cloudstack/blob/45daa1ce591a43442c30cc6ec9a70124440063eb/services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java#L301-L302
However, when connect to console via websocket url, router are not ensured
https://github.com/apache/cloudstack/blob/45daa1ce591a43442c30cc6ec9a70124440063eb/services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java#L287-L288
The issue only impacts the VMs on the ESXi 7 hosts in a different subnet than the subnet in which CPVM was created.
ISSUE TYPE

Bug Report

COMPONENT NAME

CLOUDSTACK VERSION

4.19/4.20

CONFIGURATION

OS / ENVIRONMENT

SUMMARY

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

fixed in #8922


[Bug] [community] Stale bot will close issue/pr unexpected

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Our stale bot will close our issue/PR unexpected, this situation would make our missing user feedback.
Something information for you:

When issue not activity(no comment or labels add) for 14 days will mark as stale, and it would close for next 3 days. Issue with label Waiting for reply, new feature, DSIP would not close

But when user create bug or feature issue and maintainer without answer for 17 days, it will be close to, I think this is not the behavior we want. Solution: Maybe we should add labels Waiting for reply when use create bug or feature issue.
Another unexpected situation is when maintainer answer user issue at first time, and user add addition information but maintainer would not answer for 17 days is also would be close. Solution: I am not sure how to cover this situation, maybe we should see other repo how to handle it.

What you expected to happen
See above
How to reproduce
See above
Anything else
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

But when user create bug or feature issue and maintainer without answer for 17 days, it will be close to, I think this is not the behavior we want. Solution: Maybe we should add labels Waiting for reply when use create bug or feature issue.

I add create new draft PR to add label when issue submit.

Fix #6676


add formula and cask options to cmd brew log

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

add --formula and --cask options to brew log

@hyuraku Does this change mean brew log works for formulae and casks? If so, you'll need to update the documentation and can you provide some sample output for formulae and casks? Thanks!

@MikeMcQuaid

Does this change mean brew log works for formulae and casks?

Yes, it does!

you'll need to update the documentation

Sure.

Great work as usual, thanks again @hyuraku!


Helpful error message with invalid cupy.reshape.

Raise same exception as numpy.
It's better to put an error message than mere assertion violation.

I fixed test.

OK. LGTM!


Use chiasm-dataset

An instance of chiasm-dataset should be created when loading a data table.

Done. Relates to https://github.com/chiasm-project/chiasm-dataset/issues/2


Add channel-specific moderation buttons

What should be added?
Channel-specific moderation buttons
Why should it be added?
Some channels that you moderate in may require "harsher punishments". If you mini-mod, then you probably wouldn't need said buttons in other channels.

That would be a great feature. Actually one of things I miss most in Chatterino.


fix(filterFilter): allow array like objects to be filtered

Throw error if filter is not used with an array like object.
Previous PR #10352 restricted filterFilter to use only arrays, but it can perfectly work with array like objects.
Closes #11782

Previous PR #10352 restricted filterFilter to use only arrays, but it can perfectly work with array like objects.

A little correction: filterFilter has not been supporting array-like objects (in the broad sense) since forever.
It did support objects prototypally inheritign from Array up until v1.1.2.
Since then it was just returning the original, non-array object unchanged.
All PR #10352 did, was throw an error instead of silently returning the original object (no functionality was changed).

We should also have tests for as many array-like objects as possible.
(By "array-like" I mean objects for which isArrayLike() would return true.)

I would like to have tests for more types of array-like objects (e.g. strings, jQuery objects etc).
But it's not a blocker. I would be glad landing it as is too.

@gkalpak I've added more checks in the test, for both string and a nodelist. As expected, the source of filter.js remained unchanged with these additions.

LGTM
(The commit message should be changed to feat instead of fix, but that can be done during merging.)
Thx @gonzaloruizdevilla

I think we can merge this with the change to the arguments test; although I wonder if an even less array-like object would fail when passed to Array.prototype.filter?

The "arraylike-ness" of the input is determined using isArrayLike(), so it's very possible to have something non array-ish pass as array-like as long as it passes the following test:
typeof length === 'number' && length > 0 && (length - 1) in obj

But it doesn't seem to break Array.prototype.filter (in Chrome at least). E.g.:
var obj = {length: 10, k1: 'v1', k2: 'v2', 9: 'test'};
Array.prototype.filter.call(obj, function () { return true; });   // results in: ['test']

Other than that, isArrayLike recognizes objects with length: 0 (which also doesn't pose any problems to Array.prototype.filter) or arrays, strings and node-lists (all of which are tested against).
--
Besides, even if there is a way to break it (and you try really hard), you might end up with an error.
But this is what you would end up with previously as well. (filterFilter would throw an error if passed an non-array input.)

Awesome let's go with it!

Trying really hard :smile:,  the only thing I've achieved is to kill the performance with an object like {0:"a",1000000000:"c",length:1000000001, someotherProperty:"x"}, which looks very far-fetched to me.
@petebacondarwin Thanks for your suggestion, it is much more readable now.
I've updated the PR and the commit message.

LGTM


npm install/npm start failing.

I've got an older project that I need to update but npm install > npm start is failing.
to be clear - I've already removed the node_modules directory and tried to re-run.
I also tried updating the package.json file to the most recent version so all packages are up to date, but  it continues to fail.
I just updated to the latest stable version of node.js 11.6.0 and the previous version where I first found this error was from around version ~10.8
Here is the output from npm install which seems remarkably thin judging based on previous instances of use:
><EMAIL_ADDRESS>install /Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme/node_modules/fsevents
> node install

node-pre-gyp WARN Tried to download(404): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.4/fse-v1.2.4-node-v67-darwin-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v67 ABI, unknown) (falling back to source compile with node-gyp)
  SOLINK_MODULE(target) Release/.node
  CXX(target) Release/obj.target/fse/fsevents.o
../fsevents.cc:63:6: warning: field 'async_resource' will be initialized after field 'lockStarted' [-Wreorder]
   : async_resource("fsevents:FSEvents"), lockStarted(false) {
     ^
1 warning generated.
  SOLINK_MODULE(target) Release/fse.node
  COPY /Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme/node_modules/fsevents/lib/binding/Release/node-v67-darwin-x64/fse.node
  TOUCH Release/obj.target/action_after_build.stamp

><EMAIL_ADDRESS>install /Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme/node_modules/node-sass
> node scripts/install.js

Cached binary found at /Users/SMG_Rob/.npm/node-sass/4.11.0/darwin-x64-67_binding.node

><EMAIL_ADDRESS>postinstall /Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme/node_modules/uglifyjs-webpack-plugin
> node lib/post_install.js

><EMAIL_ADDRESS>postinstall /Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme/node_modules/node-sass
> node scripts/build.js

Binary found at /Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme/node_modules/node-sass/vendor/darwin-x64-67/binding.node
Testing binary
Binary is fine

><EMAIL_ADDRESS>postinstall /Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme/node_modules/gifsicle
> node lib/install.js

  ✔ gifsicle pre-build test passed successfully

><EMAIL_ADDRESS>postinstall /Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme/node_modules/jpegtran-bin
> node lib/install.js

  ✔ jpegtran pre-build test passed successfully

><EMAIL_ADDRESS>postinstall /Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme/node_modules/optipng-bin
> node lib/install.js

  ✔ optipng pre-build test passed successfully
added 1271 packages from 987 contributors and audited 25417 packages in 35.791s
found 0 vulnerabilities

Here is the error output:

><EMAIL_ADDRESS>start /Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme
> gulp

internal/modules/cjs/loader.js:605
    throw err;
    ^

Error: Cannot find module 'run-sequence'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:603:15)
    at Function.Module._load (internal/modules/cjs/loader.js:529:25)
    at Module.require (internal/modules/cjs/loader.js:657:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at Object.<anonymous> (/Applications/MAMP/htdocs/my-project/wp-content/themes/my-theme/gulpfile.js:9:19)
    at Module._compile (internal/modules/cjs/loader.js:721:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:732:10)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `gulp`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Not sure what I need to do here to get sass running compiling again and would love any help I could get.

gulp-cli needs to be installed globally, from what I can see regarding your error.

No, gulp-clidoes not have to be installed globally.

Strange, because I have never had the problem with npm install/start & the only solution I could find was to install gulp-cli globally from another git repository where they were having issues.


PHP8.3 + gd: Unable to load dynamic library 'gd.so'

Describe the bug

Same as described in https://github.com/shivammathur/setup-php/issues/767, I'm seeing the warning during the setup-php task.
==> Setup Extensions
Run shivammathur/setup-php@v2
/usr/bin/bash /home/runner/work/_actions/shivammathur/setup-php/v2/src/scripts/run.sh

==> Setup PHP
✓ PHP Installed PHP 8.3.0-dev (81e236cde56ff006d9c661140790b42f40ffc43b)

==> Setup Extensions
PHP Warning:  PHP Startup: Unable to load dynamic library 'gd.so' (tried: /usr/lib/php/20230831/gd.so (/usr/lib/php/20230831/gd.so: undefined symbol: gdImageCreateFromAvif), /usr/lib/php/20230831/gd.so.so (/usr/lib/php/20230831/gd.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
✓ dom Enabled
✓ curl Enabled
✓ libxml Enabled
✓ mbstring Enabled
✓ zip Enabled
✓ pcntl Enabled
✓ pdo Enabled
✓ sqlite3 Enabled
✓ pdo_sqlite Enabled
✓ bcmath Enabled
✓ soap Enabled
✓ intl Enabled
PHP Warning:  PHP Startup: Unable to load dynamic library 'gd.so' (tried: /usr/lib/php/20230831/gd.so (/usr/lib/php/20230831/gd.so: undefined symbol: gdImageCreateFromAvif), /usr/lib/php/20230831/gd.so.so (/usr/lib/php/20230831/gd.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
PHP Warning:  PHP Startup: Unable to load dynamic library 'gd.so' (tried: /usr/lib/php/20230831/gd.so (/usr/lib/php/20230831/gd.so: undefined symbol: gdImageCreateFromAvif), /usr/lib/php/20230831/gd.so.so (/usr/lib/php/20230831/gd.so.so: cannot open shared object file: No such file or directory)) in Unknown on line 0
✓ gd Installed and enabled
✓ exif Enabled
✓ iconv Enabled
✓ imagick Enabled
✓ fileinfo Enabled

Version

[x] I have checked releases, and the bug exists in the latest patch version of v1 or v2.
[x] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems

Ubuntu 22.04.3
PHP versions

8.3
To Reproduce

Entire workflow file: https://github.com/statamic/cms/actions/runs/6694693364/workflow?pr=8845
Relevant lines:
  - name: Setup PHP
    uses: shivammathur/setup-php@v2
    if: steps.should-run-tests.outputs.result == 'true'
    with:
      php-version: ${{ matrix.php }}
      extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, soap, intl, gd, exif, iconv, imagick, fileinfo
      coverage: none

Expected behavior

Should install PHP with no warnings.
Screenshots/Logs

Here's the workflow run: https://github.com/statamic/cms/actions/runs/6694693364/job/18195065968?pr=8845
The "Setup PHP" step shows the warnings.
Additional context
We have strange test failures on GitHub Actions which we can't recreate locally. I'm trying to rule out a problem with the GitHub PHP installation itself being the issue by getting rid of the warnings.
This warning was already reported and apparently fixed mentioned in https://github.com/shivammathur/setup-php/issues/767
Are you willing to submit a PR?

Unfortunately not, I wouldn't know where to begin.

@jasonvarga
Please replace the apt-spy2 step as it breaks package lists. As a result, it is not able to install the required libgd version using from ppa:ondrej/php.
You can still ensure that your lists are updated and there are no broken packages using apt.
- name: Update apt sources
  if: steps.should-run-tests.outputs.result == 'true' && matrix.os == 'ubuntu-latest'
  run: |
    sudo apt-get check || sudo apt --fix-broken install -y
    sudo apt-get update

I had that line in there as per the recommendation of https://github.com/actions/runner-images/issues/675#issuecomment-1419388451 but apt-get update is probably enough.
The warnings are now gone, and my tests even pass.
Thanks very much!


Need to use screen area mode wisely

Currently, there's lot of white space, which does no good. It is extremely apparent on small screens, like Raspberry Pi 7" LCD. For example:

So, in reality, only about 3-5 controls fit onto the screen, which results in a lot of scrolling and general inconvenience. Especially for such a show-it-all app like BHD.
My suggestions:

Drastically reduce margins and padding for everything.
Use (if possible) an adaptive reflow, instead of fixing layout to three columns.

I think this is solved with new design.


Shows WILL USE CUDA after compile. But returns false for dlib.DLIB_USE_CUDA

Using anaconda
Expected Behavior
Output of dlib.DLIB_USE_CUDA should be True, indicating usage of GPU
Current Behavior
Output of dlib.DLIB_USE_CUDA is False. Also GPU is never used by the library.
compile output:
-- Using CMake version: 3.16.3
-- Compiling dlib version: 19.19.99
-- Enabling AVX instructions
-- Found system copy of libpng: /usr/lib/x86_64-linux-gnu/libpng.so;/usr/lib/x86_64-linux-gnu/libz.so
-- Found system copy of libjpeg: /usr/lib/x86_64-linux-gnu/libjpeg.so
-- Searching for BLAS and LAPACK
-- Searching for BLAS and LAPACK
-- Checking for module 'cblas'
--   No package 'cblas' found
-- Found LAPACK library
-- Found BLAS library
-- Looking for cuDNN install...
-- Found cuDNN: /usr/lib/cuda/lib64/libcudnn.so
-- Enabling CUDA support for dlib.  DLIB WILL USE CUDA
-- C++11 activated.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/irfan/dlib-master/build
setup output:
running install
running bdist_egg
running egg_info
writing dlib.egg-info/PKG-INFO
writing dependency_links to dlib.egg-info/dependency_links.txt
writing top-level names to dlib.egg-info/top_level.txt
package init file 'dlib/init.py' not found (or not a regular file)
reading manifest file 'dlib.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
no previously-included directories found matching 'tools/python/build*'
writing manifest file 'dlib.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
running build_ext
Building extension for Python 3.8.2 (default, Mar 26 2020, 15:53:00)
Invoking CMake setup: 'cmake /home/irfan/dlib-master/tools/python -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/home/irfan/dlib-master/build/lib.linux-x86_64-3.8 -DPYTHON_EXECUTABLE=/home/irfan/anaconda3/envs/CV/bin/python3 -DCMAKE_BUILD_TYPE=Release'
-- pybind11 v2.2.2
-- Using CMake version: 3.16.3
-- Compiling dlib version: 19.19.99
-- SSE4 instructions can be executed by the host processor.
-- AVX instructions can be executed by the host processor.
-- Enabling AVX instructions
-- Found system copy of libpng: /usr/lib/x86_64-linux-gnu/libpng.so;/usr/lib/x86_64-linux-gnu/libz.so
-- Found system copy of libjpeg: /usr/lib/x86_64-linux-gnu/libjpeg.so
-- Searching for BLAS and LAPACK
-- Searching for BLAS and LAPACK
-- Checking for module 'cblas'
--   No package 'cblas' found
-- Found LAPACK library
-- Found BLAS library
-- C++11 activated.
-- Configuring done
-- Generating done
-- Build files have been written to: /home/irfan/dlib-master/build/temp.linux-x86_64-3.8
Invoking CMake build: 'cmake --build . --config Release -- -j8'
[ 68%] Built target dlib
[100%] Built target dlib_python
creating build/bdist.linux-x86_64/egg
copying build/lib.linux-x86_64-3.8/dlib.cpython-38-x86_64-linux-gnu.so -> build/bdist.linux-x86_64/egg
creating stub loader for dlib.cpython-38-x86_64-linux-gnu.so
byte-compiling build/bdist.linux-x86_64/egg/dlib.py to dlib.cpython-38.pyc
creating build/bdist.linux-x86_64/egg/EGG-INFO
copying dlib.egg-info/PKG-INFO -> build/bdist.linux-x86_64/egg/EGG-INFO
copying dlib.egg-info/SOURCES.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying dlib.egg-info/dependency_links.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying dlib.egg-info/not-zip-safe -> build/bdist.linux-x86_64/egg/EGG-INFO
copying dlib.egg-info/top_level.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
writing build/bdist.linux-x86_64/egg/EGG-INFO/native_libs.txt
creating 'dist/dlib-19.19.99-py3.8-linux-x86_64.egg' and adding 'build/bdist.linux-x86_64/egg' to it
removing 'build/bdist.linux-x86_64/egg' (and everything under it)
Processing dlib-19.19.99-py3.8-linux-x86_64.egg
removing '/home/irfan/anaconda3/envs/CV/lib/python3.8/site-packages/dlib-19.19.99-py3.8-linux-x86_64.egg' (and everything under it)
creating /home/irfan/anaconda3/envs/CV/lib/python3.8/site-packages/dlib-19.19.99-py3.8-linux-x86_64.egg
Extracting dlib-19.19.99-py3.8-linux-x86_64.egg to /home/irfan/anaconda3/envs/CV/lib/python3.8/site-packages
dlib 19.19.99 is already the active version in easy-install.pth
Installed /home/irfan/anaconda3/envs/CV/lib/python3.8/site-packages/dlib-19.19.99-py3.8-linux-x86_64.egg
Processing dependencies for dlib==19.19.99
Steps to Reproduce
1 - cmake  -D CMAKE_PREFIX_PATH=/usr/lib/cuda/ -D DLIB_USE_CUDA=1 -D USE_AVX_INSTRUCTIONS=1 ..
2 - cd ..
3 - python3 setup.py install

Version: 19.19.99
Where did you get dlib: github repo
Platform: ubuntu 20.04 64-bit
Compiler: gcc-7, g++-7

From your log:
"dlib 19.19.99 is already the active version in easy-install.pth"
I think indicates, that the dlib version you just built is allready installed (likely a non cuda build)
and as it its allready there it will not be overwritten ...
try:
pip uninstall dlib
and then
python3 setup.py install

From your log:
"dlib 19.19.99 is already the active version in easy-install.pth"
I think indicates, that the dlib version you just built is allready installed (likely a non cuda build)
and as it its allready there it will not be overwritten ...
try:
pip uninstall dlib
and then
python3 setup.py install

So how do I uninstall the dlib installation that I just built?


Jest example needs update

It turns out I have to add these two methods to the test so the jest test can run successfully.
.launch()
.newPage()
or else I'm getting error:
: TypeError: Cannot read property 'goto' of null
at Target._handleFunc (/Users/jayhe/Desktop/jestDemo/node_modules/differencify/dist/target.js:111:50)
The successful jest test I'm using:
import Differencify from 'differencify';
const differencify = new Differencify({ debug: true });
describe('tests differencify', () => {
it('validate github page appear correctly', async () => {
await differencify
.init()
.launch()
.newPage()
.goto('https://github.com/NimaSoroush/differencify')
.screenshot()
.toMatchSnapshot()
.close()
.end();
});
});

Hi @hejhj ,
Yeah, you are right. I'll update the docs.
BTW, there are integration tests for this project which using Jest to run tests. you can look at those test as example as well: https://github.com/NimaSoroush/differencify/blob/master/src/integration.tests/integration.test.js


Failed to add binary version of framework in Xcode 13

In our team we have no opportunity to import swift-snapshot-testing using GitHub.
And we decided to build a binary version of xcframework and put it inside project. But when we upgraded Xcode to 13 version it stoped working.
We set property Build for distribution = YES in project.  Please select a toolchain which matches the SDK.

'XCTAttachment' is not a member type of class 'XCTest.XCTest'
'XCTestCase' is not a member type of class 'XCTest.XCTest'

I don't know why, but the problem is in this lines:
public var diff: (Value, Value) -> (String, [XCTAttachment])?
public typealias SnapshotTestCase = XCTestCase
  init(
    toData: @escaping (_ value: Value) -> Data,
    fromData: @escaping (_ data: Data) -> Value,
    diff: @escaping (_ lhs: Value, _ rhs: Value) -> (String, [XCTAttachment])?

The same thing is her: https://github.com/Quick/Quick/issues/961

@ton252 did you find any solution to this?

@mariusfanu The only solution (dirty) that I found is to hide any public declaration of XCTestCase XCTAttachment.
For example change XCTAttachment to Any and check type inside function (I know this is a dirty way)

Yes, that's not ideal, thanks for the response

I solved this by using swift-create-framework tool and this xcodebuild argument (ENABLE_TESTING_SEARCH_PATHS):

swift create-xcframework --package-path . --stack-evolution --configuration debug --output xcframeworks-debug --platform ios --xc-setting ENABLE_TESTING_SEARCH_PATHS=YES

@osrufung Using ENABLE_TESTING_SEARCH_PATHS=YES allowed me to generate an xcframework but when added in test target i am getting the following error.
'XCTAttachment' is not a member type of class 'XCTest.XCTest'
Any idea?

@Nikoloutsos I had the same issue recently. I tried to edit manually the abi and swiftinterface files by replacing XCTest.XCT with XCT,
Basically removing every reference to XCTest.
It seems working for me with this.

@rcasula Exactly, wondering why pointfreeco do not expose an xcframework by default on the tag release artifacts 🤔


Add linux-riscv64 to the evaluation pipeline

It should be supported as well.

cc @sxa @smlambert could I please get a review? Thanks!


Usability: Labels (or at least alt text) for buttons

I was looking specifically at the clone workspace button, since it's got the "copy" icon, which is close but not an exact match in this case. It would be useful for users not familiar with the application to be able to read what the buttons will do before clicking them.
This site recommends adding labels to all buttons: https://axesslab.com/icons-ruining-interfaces/
I'd be interested in learning what others think about this.

I agree that all buttons should have labels by default.


XMPP SASL fix, username and emote fix, example service file

Fix for XMPP auth with newer SASL
Fix for username formatting
For for emotes
Example discord-xmpp.service file for systemd

Sweet! I like what you guys have done with it and was hoping you'd pull request sometime.


Signatures are not properly verified in some message formats

My understanding was, that signatures are always calculated over the content of the literal data packet, but apparently this is not the case.
In case of OPS COMP(LIT) SIG, the signature is made over the compressed data packet.
Further, in case of OPS1[OPS2 LIT SIG2] SIG1, where OPS[_] indicates a OPS with the nested flag set to true, OPS2 and SIG2 are also part of the data that gets hashed for OPS1. Not sure if I have this implemented the proper way currently.

I made some local changes to the OpenPGP Interoperability Test Suite to also check the signatures and it turns out, that PGPainless fails to process roughly half of the test vectors of this section: https://tests.sequoia-pgp.org/#Unusual_Message_Structure
I will try to make the new DecryptionStream fix these issues.

JUnit tests for broken messages are to be found in https://github.com/pgpainless/pgpainless/tree/messageStructureTest

Fixed by wrapping InputStreams into BufferedInputStreams before wrapping into BCPGInputStreams.
See https://github.com/bcgit/bc-java/issues/1257


simple_setup.py unable to find "config/DeviceList.json" when it installs json parser

When json parser is not installed before running simple_setup.py , the following conditional branch is executed
This line of code changes the working directory to home + "/other_packages/json/build"
Due to which the file read of config/DeviceList.json happens in home + "/other_packages/json/build" as opposed to the intended eros/ directory.
This causes the python script to fail with
Running Simple Setup...
Creating Directories...
Installing Dependencies via apt...
Installing other dependencies from source...
Generating Default Config Files...
Traceback (most recent call last):
  File "scripts/simple_setup.py", line 77, in <module>
    main()
  File "scripts/simple_setup.py", line 73, in main
    run_setup()
  File "scripts/simple_setup.py", line 60, in run_setup
    with open("config/" + config_file_list[i], 'r') as in_file:
IOError: [Errno 2] No such file or directory: 'config/DeviceList.json'

@KaushikNeelichetty This is fixed as of commit: 9d51fe2b546a3fc1d926fada6bbc05b71d69a290.  If you don't wish to update your eros content, I've found that you can resolve this issue by simply running the simple_setup.py script twice.


The "target" folder is not wiped if it contains a "rls" folder

Running cargo wipe target -w removes the debug/release folders in target, but the rls folder (created by the Rust Language Server -- I use VS Code) is left untouched, so the target folder is not wiped in the end:
rust
├─ guessing_game
│  ├─ src
│  └─ target
│     └─ rls
│        └─ ...
└─ hello_cargo
   └─ src

Is this the intended behavior? Thank you!

No, that is not the indented behaviour.
However, some files might be left behind if there is lack of permissions, or if, more likely in your case, some files are currently in use.
If this is the case, there should be a visual indication.

My guess is that Visual Code keeps some files inside target/rls open.
Can you please retry with Visual Code closed?
Maybe the last message, "All Clear!", should be changed so something else in this case.

I tried what you suggested, but didn't work even after rebooting, curiously:
/media/Home-Computer/rust$ cargo wipe target
[DRY RUN] Recursively searching for all "target" folders in /media/Home-Computer/rust...

Nothing found!

After some tinkering, I suspect the behavior is caused by the Rust plugin. Switching to rust-analyzer solved the problem.


Proposal: Improve hz template documentation

Is your feature request related to a problem? Please describe.
I'am trying to define a handler struct for each service defined idl, which is a widely used pattern in API development.
Taking hertz-examples/tree/main/hz/template/package as an example, what the package template offers is:
// HelloMethod .
// @router /hello [GET]
func HelloMethod(ctx context.Context, c *app.RequestContext) {
	//  you can code something
	var err error
	var req example.HelloReq
	err = c.BindAndValidate(&req)
	if err != nil {
		c.String(400, err.Error())
		return
	}

	resp := new(example.HelloResp)

	c.JSON(200, resp)
}

What I am looking for is the follwoing:
type HelloHandler struct {

}
// HelloMethod .
// @router /hello [GET]
func (h *HelloHandler) HelloMethod(ctx context.Context, c *app.RequestContext) {
	//  you can code something
	var err error
	var req example.HelloReq
	err = c.BindAndValidate(&req)
	if err != nil {
		c.String(400, err.Error())
		return
	}

	resp := new(example.HelloResp)

	c.JSON(200, resp)
}

I found it challenging to follow the documentation becuase of the following reasons:

The default package.yaml file is not available to download as a file. The full template is way too long to copy, plus there is no copy button.
The lack of documentaion on which file is customizable. After reading documentation, It turned out handler.go ,router.go, register.go, middleware.go, client.go, handler_single.go, middleware_single.go are paths that can be modified. This is not really reader friendly as we have to go thourgh the whole file to understnad what's happening here.
There is no explaining on what variables are avaialble in each template. For example, handler.go explicitly refers to .PackageName, .Imports, .Methods, .Serializer but there is no clarifaction on what variable we are able to refer to when exectuing this template. It took me a few trial and error to figure out .ServiceName is not accessible in the handler.go template.

  - path: handler.go
    delims:
      - '{{'
      - '}}'
    body: |-
      // this is my custom handler.

      package {{.PackageName}}

      import (
      	"context"

      	"github.com/cloudwego/hertz/pkg/app"

      {{- range $k, $v := .Imports}}
      	{{$k}} "{{$v.Package}}"
      {{- end}}
      )

      {{range $_, $MethodInfo := .Methods}}
      {{$MethodInfo.Comment}}
      func {{$MethodInfo.Name}}(ctx context.Context, c *app.RequestContext) {
        //  you can code something
      	var err error
      	{{if ne $MethodInfo.RequestTypeName "" -}}
      	var req {{$MethodInfo.RequestTypeName}}
      	err = c.BindAndValidate(&req)
      	if err != nil {
      		c.String(400, err.Error())
      		return
      	}
      	{{end}}
      	resp := new({{$MethodInfo.ReturnTypeName}})

      	c.{{.Serializer}}(200, resp)
      }
      {{end}}

Describe the solution you'd like
We can use the following layout. It helps to nevigate to the exactly section which user want to modify, say I only want to modify handler, why should I go through and understand the whole file?

Customize Package Template
1.1 how to get default template
1.2 how to specify template file in command line
1.3 breakdown of each section
1.3.1 handler.go (includes breif explaination, default value, a list of available variables and their type (i.e. .VAR). I guess go doc would really helps in this case)
1.3.2 ...

The same structure could be applied to customised layout as well.
Describe alternatives you've considered
I believe it's a better idea to bundle template files with hz release. One possible way is providing additional flags to generate /template/package.yaml or/and  /template/layout.yaml when creating a new project.
Additional context
None.

@Haswf
Thanks for your advice!
I will answer you  based on your three questions.

All templates are available at hertz-example and the documentation I should not mark. And there is really no copy button on the document.
In theory, all files can be customized. But at the moment it is not recommended to modify the "register.go" file due to update command. However, I understand that the average user only need to modify handler.go and middleware.go.
Previously I thought the variable names in the template would explain what each variable does, but now it seems a bit cumbersome. I will provide the explanation of the variable names in the template. Also, why do you use the ".ServiceName" variable in "handler.go"?

I think the documentation layout you gave is very good, would you like to propose a "PR" based on your idea? I will also work with you on this


Dapr Sidecar Missing on Some Pods After AKS Node Pool restarts/scales

In what area(s)?

/area runtime
/area operator
What version of Dapr?

1.12.1
Expected Behavior

After restarting or scaling the AKS node pool, I expect all deployments annotated for Dapr to start with their respective Dapr sidecar containers. The pods should show as 2/2 containers ready, indicating both the application and the Dapr sidecar are running.
Actual Behavior

Randomly, some deployments do not get the Dapr sidecar container after an AKS node pool restart or scale operation. The pods for these deployments show as 1/1 containers ready, indicating only the application container is running without the Dapr sidecar.
Steps to Reproduce the Problem

Use Dapr version 1.12.1 in an AKS environment.
Annotate several deployments with Dapr sidecar injection.
Manually scale down and then scale up the AKS node pool or restart the node pool.
Observe that randomly, some deployments will not have the Dapr sidecar container running.

Release Note

RELEASE NOTE: FIX Dapr Sidecar Missing on Some Pods After AKS Node Pool restarts/scales

This is a known issue that might see an improvement in 1.13. However, the recommended mitigation is this: https://docs.dapr.io/concepts/dapr-services/operator/#injector-watchdog.

Thank you, @yaron2. The suggestion to use the injector watchdog was effective and resolved our issue.


Add TestNet Warning to Bitcoin Address fields

On all bitcoin fields, add warning that the address must be valid for testnet, until we switch to the mainnet.

Concur.

What bitcoin addresses is valid for test net?

@JustVic any address from a testnet wallet. CoPay is one that's easy to set up for the testnet.


Generic functions issue in VM with --preview-dart-2 option

Consider the following code:
typedef void T<X>();
void t<X>() {}

T f = t;

main() {
  print (t is T);
  print (f is T);
}

When run in VM with --preview-dart-2 option this code produces
false
true

No issues in VM without --preview-dart-2 option it produces
true
true

Why results on  VM with --preview-dart-2 are different?
Dart VM version: 2.0.0-dev.59.0 (Unknown timestamp) on "linux_x64"

typedef void T<X>() is equivalent to typedef T<X> = void Function<X>().
As such, T f = t is equivalent to T<dynamic> f = t, which is equivalent to void Function() f = t. During the assignment step of t to f the generic function t is specialized to be a function of type void Function<dynamic>() and the generic type is dropped.
This explains why t is T and f is T have different results.


pre-commit: PR69471

Link: https://github.com/llvm/llvm-project/pull/69471
Requested by: @nikic

/close


Feature Request: Preserve orientation between setImages

Calling PanoViewer.SetImage resets orientation to (0,0,0). It would be convenient for applications move between images to preserve orientation.
This workaround doesn't work:
var orientation = {
yaw: panoViewer.getYaw(),
pitch: panoViewer.getPitch(),
fov: panoViewer.getFov()
}
panoViewer.setImage(newImage);
panoViewer.lookAt(orientation, 0);
Instead, you need set orientation on the "ready" event, which is a little extra code complexity to pass orientation around.

@schpokatron
Thanks for the suggestion! I think it would be great to have a such feature.
I can't change lookAt as it might break other viewers, but I think we can add a new option for the setImage.
panoViewer.setImage(newImage, {
  yaw: 123,
  pitch: 0,
  fov: 65,
});

@schpokatron
Thanks for the suggestion! I think it would be great to have a such feature.
I can't change lookAt as it might break other viewers, but I think we can add a new option for the setImage.
panoViewer.setImage(newImage, {
  yaw: 123,
  pitch: 0,
  fov: 65,
});


IOS iframe blurry until interacted with

Once my model loads in, it goes blurry until it is interacted with. My website is a wix site and I used an iframe for my code. It seems to be blurry only with IOS, and It is the same on chrome and safari.
Video demo:
https://vimeo.com/479985534
My code entered into wix iframe:

 src="https://ad-link-to-ar.s3-eu-west-1.amazonaws.com/My+site/uploads_files_2424049_candle_milk_honey.glb"
poster="https://ad-link-to-ar.s3-eu-west-1.amazonaws.com/My+site/candleposter.png"
ios-src="https://ad-link-to-ar.s3-eu-west-1.amazonaws.com/My+site/uploads_files_2424049_candle_milk_honey.usdz" ar quick-look-browsers="safari chrome" camera-controls minimumRenderScale="1" >

- model-viewer: v1.3.0
Browser Affected

[ ] Chrome

[ ] Safari

OS

[ ] iOS

Sorry I missed this earlier. This is expected behavior (it's low-res while moving, transitioning to high-res when still). I noticed you tried to fix it with minimumRenderScale=1, but it's not an attribute, it's a static property. Try this instead:
const ModelViewerElement = customElements.get('model-viewer');
ModelViewerElement.minimumRenderScale = 1;

See alternatives here.

If this works, but you don't notice a corresponding drop in frame-rate, please post here about that. I'm beginning to wonder if the GPU is somehow throttled in iframes on iOS.


Add "getMassPropertiesPerCandidate" RPC operation

This adds the ability to get mass properties for multiple elements separately with just a single request. The existing "getMassProperties" aggregates mass properties of all given candidates.

Can you consider targeting master instead of release/3.0.x? We typically make changes on master and then backport to appropriate release branch(es).

I assume you were seeing issues with having this loop on the frontend? How many elements are you getting mass properties for?


move the logging into an independent lib

actually no, you're setting the export to the method

require('./lib/logging_utils')
[Function: createBackendLogger]

+1

+1


Use controller.FilterController(&v1beta1.TaskRun{})

Changes
I'd updated the PipelineRun controller to use this, but missed this place in the TaskRun controller.  This is made possible by TaskRun implementing kmeta.OwnerRefable.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[ ] Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including
functionality, content, code)
[ ] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
NONE

/lgtm
/approve

Not sure why this would fail...  I'm thinking flake...
/retest


Storage Spaces overview  & Storage Spaces in Windows

When taking on the task of actually implementing something in your documentation I like to print a copy of the instructions, mark it up and carry the copy to the platform I plan to use for the test before putting it up on a live system.   The seems to be a persistent problem with your web pages for at least the last 10 years.  When are the web page editors going to learn how to make that possible. No, if i download the PDF it is not always the same content so I can't print from that text.  Obviously there is a QC issue here

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5889391f-be98-72d7-45cc-7843687125f0
Version Independent ID: e7210874-fedb-39f8-9e5b-01d12fc27ccf
Content: Storage Spaces overview
Content Source: WindowsServerDocs/storage/storage-spaces/overview.md
Product: windows-server
Technology: storage-spaces
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Hi @mfstanton,
Have you tried printing to PDF from your browser with headings and footers deselected?
We'd like to express our gratitude for your commitment to our documentation. Unfortunately, we’ve recently fallen short of our usual standards in addressing documentation concerns in a timely manner and offer our apologies for any inconvenience we’ve caused.
Because this issue is now outdated, we’re closing this request. If we've addressed the documentation issue, this thread will also be closed. However, if you believe there’s still a documentation concern, you're encouraged to open a new GitHub issue. We welcome any additional suggestions for improving our documentation to provide a more satisfactory experience in the future. Thanks for your understanding and continued support.
#please-close


Feature Request: Add enginePath Argument to Engine::build Method

First, thank you for maintaining this project—it's a really great library!
Would it be a bad idea to add an optional enginePath argument to the Engine::build method? This would allow users to specify where to store .engine models, defaulting to a reasonable path for backwards compatibility.
This feature is particularly useful for Dockerized applications, enabling better file organization and management.

Sure, happy to open a PR within the next few days.


Tracker should track playerID instead of name

Players changes their name pretty often, this will make the bot not work properly.
Could you make it go by ID instead of names?
Example:
https://api.battlemetrics.com/players/956053153/servers/4094307, although the name isn't really there, but you might find a solution to that ^^
Also, maybe grouping?

Thank you for the idea. I changed a lot about the way the bot functions. Now you can add users like normal (by their in-game username), and it'll fetch their ID and use that from then on. It checks if their name has changed every time they get on or off.
If you use the command !add ally, !add enemy, or !add squad they will appear in separate groups.
In the future I'd like to implement adding users by their ID and custom group names.
Tracking users by ID rather than username now uses less CPU and, in most cases, less bandwidth.
I'm currently working on a website in my spare time that gives this bot a better interface and keeps a database of every time a user gets on or off.


PyCharm automatic import suggestions

Hi,
I have this code snippet in PyCharm:
def main(
    acquisition_dir: str,
    trace_log_files: list[str],
    order_name: str,
    barcode: str,
):
    img = imread('test.tif')

When I configure the interpreter via conda, PyCharm suggests the correct import (from tifffile import imread). Now I have configured the interpreter via pixi-pycharm, but it will not suggest any imports.
I can still write and execute the code, but I need to write the imports myself. So this is more a quality of life feature :slightly_smiling_face:
If I add the import myself, I can run the code via the configured pixi-pycharm interpreter :+1:

Hmm, i cannot seem to reproduce this example...

This shouldn't have anything to do with using pixi or conda. I think(?) how pycharm finds these things is by finding the correct python executable and then just scanning the site-packages directory of this environment (that's what's happening when you see Updating skeletons).
Maybe pycharm just didn't refresh the skeletons yet?

This is how it looks for me right now:

And I only get these suggestions:

In the Interpreter Paths dialog I can click the refresh button, which triggers Updating skeletons. But in the end nothing changes.
Maybe I will try a fresh install of PyCharm next.

Hmm weird, that looks exactly like my setup...

Sounds like a reasonable assumption.
I have no idea where this is going wrong. Also resetted the caches of PyCharm, but so far nothing worked.

Hi, found this while troubleshooting a different typing problem. Thanks for the screenshots of the External Libraries widget, it gave me an idea what the problem might be. That highlighting is for "non-project" files, so pycharm thinks that items found in the .pixi folder are actually project files. My typing symptoms went away when I excluded the .pixi folder (right click ->  Mark Directory as -> Excluded).
It's not clear to me WHY the project vs non-project distinction confuses pycharm so much. However, I don't think there's anything for this project to fix, except maybe document the need to exclude the pixi folder from the project files if it is in the project folder.

Thanks, that sounds doable! @tibuch could you try if that fixed the issue?

Yes, this works! Thank you @richardsheridan!
But, I can't rename the environment and they are now all called default. But I think this is another issue :slightly_smiling_face:

they are now all called default

xref #10

Added some documentation for this in #28


Live preview

What about make some live preview? You may use GitHub pages. ;)

@HoBi where this is a such a small implementation, more of a quick demo, I think GH pages would be overkill. A mega nav is relatively common enough that the screenshot is sufficient. But thanks for the suggestion.


where is the 'laravelAdminMenus' variable defined ?

Well..
in admin dashboard , sidebar.blade.php has 'laravelAdminMenus' variable.
I would like to figure out where the variable  start  and what contains.
I searched whole source  but failed to find out.
Where is if from ?

@sanhar did you find out where it is defined? I can find the menus.json file, but I do not understand how the variable $laravelAdminMenus gets set


Add option to do timed measurement that doesn't use lead-off detection

We can also use an "Auto" option that detects touch stability in the first second and chooses time or release as the end condition.


feat: add support for different tenants

This adds the option to specify the NowSecure tenant endpoint.
We don't use the default NowSecure tenant, so for use to be able to use the plugin, we must be able to point to different tenants

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@onyxmueller can you please review this one?

Thanks @mieliespoor!
I think you might have missed my comment about rubocop not being happy with the syntax. Let me see if it's something I can fix for you.

FYI, I will merge this but will publish the gem after I update the README with the new option. I will try to do that tonight or tomorrow.

Gem published under version 0.2.0. 🚀
https://rubygems.org/gems/fastlane-plugin-nowsecure/versions/0.2.0
Would you mind validating it works as expected from your end?


Cannot write shifted letters in US

To Reproduce
Steps to reproduce the behavior:

create script with:

down + control + key "r" => write("AAbb")

Hit Ctrl-r
only bb is inserted

Expected behavior
AAbb inserted
Desktop (please complete the following information):

Distro: Ubuntu
Version: master++
Method of installation install.sh
Keymap: us
Keyboard: Laptop built-in

Additional context
I have found a fix for this, will PR

Actually, this should be reopened as not fully fixed, the test case above now works with "all-in-one" keymaps like /usr/share/keymaps/i386/qwerty/defkeymap.kmap.gz, but not with any keymap that includes /usr/share/keymaps/i386/include/qwerty-layout.inc.gz like us.kmap or no.kmap.
This is because of the structure of Keymap.lua, readLinuxMap(path) is called for each keymap separately and excepts to have the modifier keycodes by the end of the file. But qwerty-layout.inc.gz has only letter keys, not the modifer keys.
I guess Keymap.lua should be refactored to remeber combo_pre accross all readLinuxKBMap calls (not feeling like doing it myself).


Dependency Issue: "Unmet peer dependency<EMAIL_ADDRESS>

Version

react-native-router-flux v3.2.7
react-native v0.23.1

Expected behaviour
This command should install react-native-router-flux in current project without having trouble on dependencies:
npm i react-native-router-flux --save
Actual behaviour
This error message will be printed with unmet dependencies:
├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  └──<EMAIL_ADDRESS>
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

Steps to reproduce

cd /tmp  (I'm on OSX here)
react-native init AwesomeProject
cd AwesomeProject
npm i react-native-router-flux --save

Output:

$ npm i react-native-router-flux --save
<EMAIL_ADDRESS>/private/tmp/AwesomeProject
├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

Arg.... "React Native 0.22 is required" in readme just found.
sorry


Refactor service registry aggregation to support multi-cloud meshes

What this PR does / why we need it:
The current aggregation model stores model data in individual platform registries, nested within the aggregate controller. With the upcoming PRs for supporting multi-cluster Istio, we'd have to support not only remote registries but multiple local registries as well. Adding new registries also meant a lot of repetitive code that can be avoided by encapsulating event handing in the controller and access for xDS in the MeshResourceView. This PR flattens and simplifies access to the model data.
Upcoming PRs will:

tweak individual platform registries to only feed events to the Mesh View.
add support for new features like bring your own name and gateways for non-flat network
add performance tests for MeshResourceView devoid of any particular platform registry implementation

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
fixes #1833
Special notes for your reviewer:
Release note:

1st of several PRs for adding multi-cluster capability - https://github.com/istio/istio/issues/1223. This PR is mostly a refactor of existing code to separate out the platform registry interfaces from that needed by xDS. Upcoming platform registries should only be limited to model.Event generation and leave the ResourceView for storage and retrieval.

@gnirodi: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.
Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gnirodi: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
79b1b61969120ce3b1a13bedc8233f8db94aed18
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm while I'd have normally agreed to this, the current code makes readability really hard, by the overuse of the term controller. The whole reason for this change is to move to a flat model. The rename to MeshResourceView is a step towards that goal. I'd prefer to call that out rather than mask it.

There are not enough comments in the code. Please explain at a high-level
what's happening for any block >20lines of code.
On Fri, Dec 15, 2017 at 9:20 AM Gregory Hanson<EMAIL_ADDRESS>wrote:

@GregHanson commented on this pull request.
In pilot/adapter/serviceregistry/aggregate/mesh_view.go
https://github.com/istio/istio/pull/2191#discussion_r157254616:

+func (r *Registry) HandleServiceInstance(i *model.ServiceInstance, e model.Event) {

k := BuildServiceInstanceKey(i)
r.MeshView.handleServiceInstance(k, i, e)
+}

+// AddRegistry adds registries into the aggregated MeshResourceView
+func (v *MeshResourceView) AddRegistry(registry Registry) {

// Create bidirectional associations between the MeshView and
// the registry being added
registry.MeshView = v
v.registries = append(v.registries, registry)
+}

+// Services lists services from all platforms
+func (v *MeshResourceView) Services() ([]*model.Service, error) {

lbls := resourceLabelsForName(labelServiceName)

labels would probably suffice and be more readable
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2191#pullrequestreview-83872063, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJGIxkhrrZ_7BKKf_nV3c5b99Fjd8haMks5tAqpvgaJpZM4RDWe9
.

@gnirodi: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
007312b6d4e09b9b034317d61d061fd22f8684f7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov comments are intended for times when the code is doing something slightly different from what's intended. Unnecessary commenting is bad for a variety of reasons:

it's usually a sign that there are too many deviations from expected behavior
comments become stale very quickly with respect to code being modified
sadly until we have a universal spoken language that is as water-tight as the compiler,  code is much better understood than the English language, especially where there are a large number of contributors and interpretation of the comment is often left to discretion of the reader.
Also given the fact that everyone interprets vocabulary differently, it's impossible to satisfy everyone's disparate views on terms within concise comments.

Unnecessary commenting is likely to be a bigger barrier for contributions

If you don't want to write comments in the code, it helps to comment tricky
bits in the PR review. It saves reviewers time.
On Fri, Dec 15, 2017, 10:21 AM Gautam Nirodi<EMAIL_ADDRESS>wrote:

@kyessenov https://github.com/kyessenov comments are intended for times
when the code is doing something slightly different from what's intended.
Unnecessary commenting is bad for a variety of reasons:

it's usually a sign that there are too many deviations from expected
behavior
comments become stale very quickly with respect to code being
modified
sadly until we have a universal spoken language that is as
water-tight as the compiler, code is much better understood than the
English language, especially where there are a large number of contributors
and interpretation of the comment is often left to discretion of the reader.
Also given the fact that everyone interprets vocabulary differently,
it's impossible to satisfy everyone's disparate views on terms within
concise comments.

Unnecessary commenting is likely to be a bigger barrier for contributions
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2191#issuecomment-352076409, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJGIxlTMTNjgsvp0budmjUyyJvY5NsMLks5tAri9gaJpZM4RDWe9
.

/test istio-presubmit

@gnirodi: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
0c080e4a2453511ca1674508cbdd398f14df70df
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnirodi: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
4842d8c71e465366c69814e0bdda7ca226f72b2d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-presubmit

@gnirodi: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
4842d8c71e465366c69814e0bdda7ca226f72b2d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnirodi: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
f3ab00def91ba5b9ff825758b2a7346f5698b253
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnirodi: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
a355efb482bfc028d4784178e8b6006d977dfa62
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnirodi: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
c0efbc97aba6e73d069a2f9b1cfbc834ab81af4d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The problem is that it's not clear ( and I don't know any good way ) to
find what actually changed in behavior, and what is simply
renaming.
We are trying to reach prod stability - I won't argue names, good or bad
they have been reviewed and everyone working on
pilot is familiar with them. But even if it was a really bad naming - the
problem is that reviewers need to understand what risks
and changes this PR introduces. MeshResourceSet or ResourceView makes even
less sense than the previous name - we can't
go around prefixing everything with 'mesh', and 'resource' in this case
means a Service or ServiceInstance, it is highly confusing
since 'resource' is a very generic name.
The actual impact of the rename - in particular since internal comments
still use the previous name - will be confusion for
every other pilot developer.
If there is an immediate benefit to this - besides that you like the new
name - it is hard to see with the rename.
On Fri, Dec 15, 2017 at 6:37 PM, istio-bot<EMAIL_ADDRESS>wrote:

@gnirodi https://github.com/gnirodi: The following test failed, say
/retest to rerun them all:
Test name Commit Details Rerun command
prow/istio-presubmit.sh c0efbc9
https://github.com/istio/istio/commit/c0efbc97aba6e73d069a2f9b1cfbc834ab81af4d
link
https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/2191/istio-presubmit/1456/ /test
istio-presubmit
Instructions for interacting with me using PR comments are available here
https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md.
If you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://github.com/kubernetes/test-infra/blob/master/commands.md.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/2191#issuecomment-352154892, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAFI6qL_AZ2TyRov65EukI2rhsSRq14oks5tAyzogaJpZM4RDWe9
.

@gnirodi: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-presubmit

@gnirodi: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnirodi: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test istio-pilot-e2e

prow/istio-presubmit.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnirodi: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnirodi: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-presubmit

@gnirodi: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test istio-pilot-e2e

prow/e2e-smoke.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test e2e-smoke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnirodi: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-smoke.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test e2e-smoke

prow/istio-pilot-e2e.sh
0538f0a0f8539d0bed67ca80a03b5799a2cc78e7
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

what's the status with this (old-ish) PR ?


config file version (37) is newer than supported version (35)

I'm getting the following error  "Failed to initialize config: config file version (37) is newer than supported version (35). If this is expected, use -allow-newer-config to override." on WIN 11 - Home - 22H2. I'm using the latest versions of syncthing and synctrayzor.
How to use the command "-allow-newer-config to override"?
Can you help? Thanks in advance.

I had this exact same issue.  The problem was that I had launched the base Windows syncthing install prior to using synctrayzor.  The synctrayzor install uses an older version at first launch, then updates to the latest version after starting.  I fixed the issue by deleting the C:\Users<username>\AppData\Local\Syncthing folder and relaunch synctrayzor.  When it launches, it will repopulate the syncthing folder.

I had this exact same issue.  The problem was that I had launched the base Windows syncthing install prior to using synctrayzor.  The synctrayzor install uses an older version at first launch, then updates to the latest version after starting.  I fixed the issue by deleting the C:\Users<username>\AppData\Local\Syncthing folder and relaunch synctrayzor.  When it launches, it will repopulate the syncthing folder.

Hi as-loan. Ok, I'll try this solution and see if it works for me.
Thanks!👍

Just want to confirm that this still works. I'm not sure what a possible solution would be.

Hi Jesse. I upgraded to last version of Syncthing, didn't modify synctrayzor and, till now, it's working.

Ok! Got it. 👍

Alternative is to use the command line option as indicated in the error message.
Open settings (on the right side, toward the bottom)
Switch to syncthing tab
Open advanced section
add -allow-newer-config into the command line parameters box
Now restart syncthing.  It will start, then upgrade to the latest version.
Once it has started OK, go back into the settings and remove the option.  It will prompt to restart syncthing.
I suspect the option exists to provide this upgrade route without losing any config.  It's not clear how much syncthing actually tries to do with the config before it switches to the new version.  The syncthing site says

--allow-newer-config
Try loading a config file written by a newer program version, instead of failing immediately.

As the config is an XML file I expect (providing they do not introduce some change in the xml layout that breaks older code) it will load and the autoupgrade function will kick in before it does anything else.

I had this exact same issue. The problem was that I had launched the base Windows syncthing install prior to using synctrayzor. The synctrayzor install uses an older version at first launch, then updates to the latest version after starting. I fixed the issue by deleting the C:\Users\AppData\Local\Syncthing folder and relaunch synctrayzor. When it launches, it will repopulate the syncthing folder.

It works!


Release new version (1.5.2?)

Could you please make a release/tag, Probably 1.5.2?
It will be great to remove warnings from the build pipeline. The issue was fixed in PR #167.

Oh yeah, I should do that. After so many years I'm still pretty bad at this "release" thing. 😜

Related to release a new version you might want to make that new version is marked as the latest version.
Currently, if you check https://github.com/lycheeverse/lychee-action/releases you see that https://github.com/lycheeverse/lychee-action/releases is marked as latest.
I think this also affects how information is shown on the marketplace, there v1 is also the latest version.

1.5.2 is out.
@vpereira01 made sure that the latest version shows up on the Marketplace again. Thanks for the hint. 👍


Death Table

hi all,
Not sure if it's been propagated to who ever is managing this now but as well the specimen table needing fixing the death table is now needed (implemented in CaRROT-CDM here https://github.com/HDRUK/CaRROT-CDM/pull/153 )

Still me. Is the death table any simpler, or will it require a similar treatment to specimen?

:) should be very straight forward for death, there's not a lot to it:
https://github.com/HDRUK/CaRROT-CDM/blob/c4867cc03761001925276f599b116a1acae71ea6/carrot/cdm/objects/versions/v5_3_1/death.py#L9
We might need some examples of the 'cause' concept ID though - to make sure that returns a domain associated to 'death' and the right names get picked up.
To explain what I mean --- it's the same as how a concept ID for female 8532 has the domain GENDER and then we use a function to look up which table the _concept_id is in... and pick the first "allowed" table.. in the case of gender - person... I vaguely remember how this all works and might be able to help out, I am still 30% for technical help.

Now that https://github.com/HDRUK/CaRROT-CDM/pull/153 is merged, are you able to advise on what's required in CaRROT-Mapper to support this @calmacx ?

Yeah sure, do you want to just leave it with me to make a PR or at least a draft PR to show you? I can do it next week

That would be great, thanks

@spco - this fell off my radar, but will have a stab at it this week

After discussion, we've decided this is not required for CO-CONNECT. May be required for other projects, but often death is not recorded using the death table, or reasons for death are deduced from observations and conditions around the time of death rather than that column in the death table.
Shelving this for now, but will leave the issue open.

Closed in favour of #646


[Suggestion] Offline auth support?

Are there any way to use cracked accounts?
Where we just enter username, and it`ll login as cracked minecraft user

As much as I would like to , I just do not want to do anything that could lead to Mojang/Microsoft nuking this.
Though I could probably move the Auth in a way that it only requires an account to download the game files. Launching should not be the issue.


CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy

Currently, it is possible to change the template used by virtual routers, but other system VMs do not have the same feature. The virtual router template is configured according to the respective global settings parameters: router.template.hyperv, router.template.kvm, router.template.lxc, router.template.xenserver, router.template.ovm, router.template.vmware.
This PR allows users to configure templates for storage system VMs (SSVMs) and console proxy system VMs with parameters similar with the virtual router template configuration:  ssvm.template. and consoleproxy.template.
If a parameter is null then we use the default system VM.
This feature was useful in a practical scenario where the console proxy system VM template was customized.

Very nice and interesting! It might even be that in the future we should leverage this even more. This SSVM template is now difficult to manage since it has to be able to handle 3 different scenarios.

Interesting PR, I'll ping couple of colleagues who may have more operational insights -- @PaulAngus @DagSontebo and others.

@GabrielBrascher can you rebase and fix conflicts?

Sorry by the delay @rafaelweingartner, I will do it soon. Thanks!

@GabrielBrascher can you fix the conflicts please?

This PR may be closed, the global setting names may be confusing but the router.xxx global settings apply for cpvm, ssvm too.

functionally this is good. I definately would want a marvin test for this that at least proves the success case so we can track regressions if we merge it.

@GabrielBrascher thanks for replying. When we do update new systemvmtemplate with every release, it does get used for all systemvms and not just only routers so I disagree what you share. We can test of course, see this upgrade path for example where only the new template's name is updated for the router.xxx global settings: https://github.com/apache/cloudstack/blob/master/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41000to41100.java#L175

I verified that changing systemvmtemplate by following the changes that the upgrade path does, indeed changes the systemvmtemplate for all vrs and systemvms (cpvm/ssvm). This may be closed @GabrielBrascher. If you'd prefer, please perform a test yourself, thanks.

Thanks, @rhtyd. I used that code in CloudStack <IP_ADDRESS> when it was requested to edit system VM template but without that code, it was updated only templates for virtual routers. After that, I created a PR for the master.
I will review all and perform a test here as well to make sure.

@GabrielBrascher perhaps you can explore refactoring of the systemvmtemplate upgrade code we've as part of the upgrade path, as an service layer API that may also be used via registerTemplate to make it easier to register/use a new systemvmtemplate.

Hi @GabrielBrascher, @rhtyd,
what's the status of this? The feature looks interesting. Would be nice to specify different templates.
Also I have the feeling you both misunderstood each other. Rhtyd talked about changing the SystemVM-template which leaves CS no other option as to deploy the new template when a systemvm needs to be deployed.
Gabriel talked about the possibility to specify another template to use as CP or SSVM i think. I think that are two different things.

That is indeed the main goal, @DennisKonrad. Thanks for pointing that!

@rhtyd What do you think? Maybe you could clarify on what you disagree with in this request or where/why you want to see changes to this?

@DennisKonrad I'm told by our guys that the router global setting in fact DOES change the temple for the ssvm and cpvm. Which would unfortunately make this redundant.
Some of the ShapeBlue guys are working on a discrete API to update/change the system VMs template at any time.

@PaulAngus I think so too. But the feature here allows for different templates instead of having the same template for router, ssvm and console proxy.
Feel free to correct me on this :)

@PaulAngus @rhtyd this PR allows to have different templates for Virtual Router (VR), Console Proxy VM (CPVM), and Storage System VM (SSVM); thus, a feature that we all know it is not yet implemented for CloudStack. I do not see any technical reason for blocking this PR.
Cases where this can be useful:

VR has template A, SSVM has template B, and CPVM has template C;
VR has template A, SSVM has template A, and CPVM has template B;
VR has template A, SSVM has template B, and CPVM has template A; and
VR has template A, SSVM has template B, and CPVM has template B;

I created this PR at 2017 because it was a critical feature for a data center in Brazil. For sure this would help multiple CloudStack's users, @DennisKonrad is one of them.
Additionally, I experienced (more than once) a case where it was not possible to configure all system VMs with the same template (VR with template A, SSVM template A, CP template A). I will explain myself.
The method findSystemVMReadyTemplate is called during the creation of SSVM and CPVM.
    @Override
    public VMTemplateVO findSystemVMReadyTemplate(long zoneId, HypervisorType hypervisorType) {
        SearchCriteria<VMTemplateVO> sc = readySystemTemplateSearch.create();
        sc.setParameters("templateType", Storage.TemplateType.SYSTEM);
        sc.setParameters("state", VirtualMachineTemplate.State.Active);
        sc.setJoinParameters("tmplHyper", "type", Host.Type.Routing);
        sc.setJoinParameters("tmplHyper", "zoneId", zoneId);
        sc.setJoinParameters("vmTemplateJoinTemplateStoreRef", "downloadState", VMTemplateStorageResourceAssoc.Status.DOWNLOADED);

        // order by descending order of id
        List<VMTemplateVO> tmplts = listBy(sc, new Filter(VMTemplateVO.class, "id", false, null, null));

        if (tmplts.size() > 0) {
            if (hypervisorType == HypervisorType.Any) {
                return tmplts.get(0);
            }
            for (VMTemplateVO tmplt : tmplts) {
                if (tmplt.getHypervisorType() == hypervisorType) {
                    return tmplt;
                }
            }

        }
        return null;
    }

Thus, SSVMs and CPs templates are selected by descending order of id from table vm_template where the template type is of 'SYSTEM', the state is as 'Active', type of 'Routing', zone id as zoneId, has been downloaded and the hypervisor of the hypervisorType. In some cases more than one templates fit the select (multiple templates of 'SYSTEM', 'Active', 'Routing', same zone Id, same hypervisor), thus it returns the template that has the bigger Id, not the one that is configured for the router. Furthermore, if a root admin registers a new template for the system VM this template will not be owned by the system (type is of 'ROUTING', not 'SYSTEM'). Only during upgrades, the templates that are marked as 'ROUTING' are converted to 'SYSTEM'.
Note that for the VR the template is selected as follows. This DOES NOT happen for SSVM and CPVM:
final String templateName = retrieveTemplateName(hType, routerDeploymentDefinition.getDest().getDataCenter().getId());
final VMTemplateVO template = _templateDao.findRoutingTemplate(hType, templateName);

In conclusion, I am not seeing any technical reason to block this PR. What do you think guys? @DaanHoogland @dhlaluku @nvazquez @dagsonstebo @wido

thanks @DennisKonrad OK, now that I understand why you're doing this, I can see what you're trying to achieve.
IMO what you are trying to achieve is great, but there is a lot around that the feature that would need to take into account before it would be 'safe' for users who are not so familiar with your design intent.
for instance (off the top of my head):
Now that there would potentially be no 'main/default' template, how do we define which system VMs & VRs need updating, when a new system vm template is 'required' for a new release. we check one now, what would we check in future?
Would we potentially need a 'requires update' state for cpvm and ssvm?
If you you've already thought of of this (and maybe more), awesome! then could you maybe share your FS to allay my paranoia .

That is a good point @PaulAngus.
What I have in mind is to keep system VM upgrade as it is on current documentation, adding just one point regarding the fact that the user should set the upgraded template for all system VMs [1], or update his customized templates based on the new template.
[1] VR, SSVMs and CPVMs templates configured with the upgraded template; or set SSVM and CPVM as null and the VR template with the upgraded template.

@PaulAngus I agree with @GabrielBrascher that the default way of upgrading should stay the same. If no 'personalized' templates are set, the vr router template should be used.
The "required update" idea seems more of an enhancement to me that would be great even regardles of this pr here ;) If a user does not upgrade his svm's according to the documentation that might not be a problem (if lucky).
But a friendy reminder (in the UI) would be nice.

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1030

@blueorangutan test

@GabrielBrascher can you triage this yourself?
Is it still applicable?
Do we want it in 4.15?

@DaanHoogland thanks for the ping. I think that it is more a matter of working with the systemvm upgrade process.
Considering that it was not a top priority and 4.13.1/4.14.0 were on tigh schedule I did not invevst much time on this one. I will take another look on it as soon as 4.14 is released and we faced the python3 migration :)


Asking several permissions

Hello ! I tried asking several permissions in a row (for exemple External storage and Camera) but I can't find a way, there is alway an issue like some permission request getting skipped....
How can I do that using your plugin ?
Thanks !

Hi, Tsequier,
This is a one way to ask permission request in a row. Please try it.

set permission you want to ask in a queue.
call first permission request and set callback that request next permissions.
Continue to the end

Sample Code
    public Queue<AndroidPermission> permissionQueue = new Queue<AndroidPermission>();
    public Action allPermissionRequested;

    void RequestPermissions(){
        permissionQueue.Enqueue (AndroidPermission.ACCESS_COARSE_LOCATION);
        permissionQueue.Enqueue (AndroidPermission.CAMERA);
        permissionQueue.Enqueue (AndroidPermission.WRITE_EXTERNAL_STORAGE);

        allPermissionRequested = () => {
            // action for all permission requested!!
        };

        RequestPermission ();
    }

    void RequestPermission(){
        if (permissionQueue.Count > 0) {
            var p = permissionQueue.Dequeue ();
            UniAndroidPermission.RequestPremission (p, RequestPermission, RequestPermission);
        } else {
            allPermissionRequested ();
        }
    }

note
Once you request permission, the second time you only have to change it by android setting.
thanks,

Thanks for your answer, I'll try that !

Hi, this is not working. After asking for 1st permission, nothing is coming and app is stuck. If i close and reopen the then the next permission is coming up and so on. Can you solve this issue ?

Hi, for me Co-routine doesn't work. But I found another way.
I call the  RequestPermission() in Awake() and call all permissions one after another.
My code.
`private void Awake()
{
RequestPermission();
}
public void RequestPermission()
{
    UniAndroidPermission.RequestPermission(AndroidPermission.WRITE_EXTERNAL_STORAGE, OnAllow, OnDeny, OnDenyAndNeverAskAgain);
    if (UniAndroidPermission.IsPermitted(AndroidPermission.WRITE_EXTERNAL_STORAGE) || !(UniAndroidPermission.IsPermitted(AndroidPermission.WRITE_EXTERNAL_STORAGE)))
    {
        UniAndroidPermission.RequestPermission(AndroidPermission.CAMERA, OnAllow, OnDeny, OnDenyAndNeverAskAgain);
        if (UniAndroidPermission.IsPermitted(AndroidPermission.CAMERA) || !(UniAndroidPermission.IsPermitted(AndroidPermission.CAMERA)))
        {
            UniAndroidPermission.RequestPermission(AndroidPermission.ACCESS_FINE_LOCATION, OnAllow, OnDeny, OnDenyAndNeverAskAgain);
        }
    }
}`