Installation failure in terminal on some machines

Describe the bug
Installation failure in terminal on some machines (@dfalster's terminal), seems to be an issue with pandoc as a key dependency to build vignettes
To Reproduce
#install.packages("remotes")
remotes::install_github("traitecoevo/austraits", build_vignettes = TRUE)
Expected behavior
A successful build and calling vignette("austraits") will be error free
Error messages
Error: Vignette re-building failed.
Execution halted
Error: Failed to install 'austraits' from GitHub:
System command 'R' failed, exit status: 1, stdout + stderr (last 10 lines):
E> --- re-building 'structure.Rmd' using rmarkdown
E> Error: processing vignette 'structure.Rmd' failed with diagnostics:
E> Pandoc is required to build R Markdown vignettes but not available. Please make sure it is installed.
E> --- failed re-building 'structure.Rmd'
Hmms, seems Rstudio can find pandoc but R in terminal can't
#Rstudio

rmarkdown::pandoc_version()
[1] '<IP_ADDRESS>'

Terminal

rmarkdown::pandoc_version()
[1] '0'

Seems to be happening with other users in RStudio

But it looks like this user (Payal) didn't have some dependencies on their machine (they recently updated R which is already a bit pain haha), so I suggested:
remotes::install_github("traitecoevo/austraits", dependencies = TRUE, upgrade = "ask", build_vignettes = TRUE)
so they can install all the dependencies and upgrade any that are out of date.
Lets see how that goes

I also failed to install in katana on demand, I got a similar error about the vignette structure.Rmd and the package kableExtra.
I opted to install the package with build_vignettees=FALSE for now, let's see how it goes.

@fontikar I am also unable to build the package on RStudio, using either install code (with or without dependencies = TRUE).
E  creating vignettes (5.2s)
--- re-building ‘austraits.Rmd’ using rmarkdown
Error: processing vignette 'austraits.Rmd' failed with diagnostics:
object ‘faststack’ is not exported by 'namespace:fastmap'
--- failed re-building ‘austraits.Rmd’
--- re-building ‘dictionary.Rmd’ using rmarkdown
Error: processing vignette 'dictionary.Rmd' failed with diagnostics:
object ‘faststack’ is not exported by 'namespace:fastmap'
--- failed re-building ‘dictionary.Rmd’
--- re-building ‘structure.Rmd’ using rmarkdown
Error: processing vignette 'structure.Rmd' failed with diagnostics:
object ‘faststack’ is not exported by 'namespace:fastmap'
--- failed re-building ‘structure.Rmd’
SUMMARY: processing the following files failed:
‘austraits.Rmd’ ‘dictionary.Rmd’ ‘structure.Rmd’
Error: Vignette re-building failed.
Execution halted
Error: Failed to install 'austraits' from GitHub:
System command 'R' failed, exit status: 1, stdout + stderr (last 10 lines):
E> --- re-building ‘structure.Rmd’ using rmarkdown
E> Error: processing vignette 'structure.Rmd' failed with diagnostics:
E> object ‘faststack’ is not exported by 'namespace:fastmap'
E> --- failed re-building ‘structure.Rmd’
E>
E> SUMMARY: processing the following files failed:
E>   ‘austraits.Rmd’ ‘dictionary.Rmd’ ‘structure.Rmd’
E>
E> Error: Vignette re-building failed.
E> Execution halted
with dependencies:
--- re-building ‘austraits.Rmd’ using rmarkdown
Quitting from lines 17-30 (austraits.Rmd)
Error: processing vignette 'austraits.Rmd' failed with diagnostics:
package or namespace load failed for 'dplyr' in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]):
namespace 'vctrs' 0.3.4 is already loaded, but >= 0.3.8 is required
--- failed re-building ‘austraits.Rmd’
--- re-building ‘dictionary.Rmd’ using rmarkdown
Error: processing vignette 'dictionary.Rmd' failed with diagnostics:
'set_envvar' is not an exported object from 'namespace:xfun'
--- failed re-building ‘dictionary.Rmd’
--- re-building ‘structure.Rmd’ using rmarkdown
Quitting from lines 12-37 (structure.Rmd)
Error: processing vignette 'structure.Rmd' failed with diagnostics:
package or namespace load failed for 'dplyr' in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]):
namespace 'vctrs' 0.3.4 is already loaded, but >= 0.3.8 is required
--- failed re-building ‘structure.Rmd’
SUMMARY: processing the following files failed:
‘austraits.Rmd’ ‘dictionary.Rmd’ ‘structure.Rmd’
Error: Vignette re-building failed.
Execution halted
Error: Failed to install 'austraits' from GitHub:
System command 'R' failed, exit status: 1, stdout + stderr (last 10 lines):
E> Error: processing vignette 'structure.Rmd' failed with diagnostics:
E> package or namespace load failed for 'dplyr' in loadNamespace(j <- i[[1L]], c(lib.loc, .libPaths()), versionCheck = vI[[j]]):
E>  namespace 'vctrs' 0.3.4 is already loaded, but >= 0.3.8 is required
E> --- failed re-building ‘structure.Rmd’
E>
E> SUMMARY: processing the following files failed:
E>   ‘austraits.Rmd’ ‘dictionary.Rmd’ ‘structure.Rmd’
E>
E> Error: Vignette re-building failed.
E> Execution halted
In addition: There were 12 warnings (use warnings() to see them)

Any ideas what could be causing this?

Hi @tinaparky apologies for a late reply! Lets get you up and running ASAP!
I suspect there are two problems at hand:

various packages on your computer that are out of date
some issue with building of vignettes (we've bee having heaps of trouble with this since the beginning!)

I recommend you for now, skip the building of vignettes and try update all the packages on your computer. This line of code should install the dependencies needed for austraits and upgrading any exisiting ones that is needed by the package. You will need to follow the prompts in the R console! i.e. selecting 1 = All when asked if you want to update your packages.
remotes::install_github("traitecoevo/austraits", dependencies = TRUE, upgrade = "ask")
Let me know how that works for you!

Related to #47

In the latest patch release, we've precompiled all vignettes so they don't require on the fly building using dependencies. This should streamline the installation process and avoid hiccups addressed in this issue. We've also included more detailed instructions in the README for installation, by setting dependencies = TRUE and upgrade = ask it forces the user install all dependencies (Imports, depends, suggests) to actively update any dependencies they have already installed.


Memory Leaks on Linux

We had reports of Memory leaks when signing/verifying a with Swift-JWT. We recreated this on our own repo JWT along with encryption and decryption. This produced the following memory report: leaks.txt which highlights leaks at:
evp_key = .init(PEM_read_bio_PUBKEY(bio, nil, nil, nil))

This is due to the evp_key not being properly freed after it was referenced by:
var pkey_ctx = EVP_PKEY_CTX_new(evp_key, nil)

(Mirrored for private key).
There are also leaks in encrypt and decrypt where allocated memory from pointers wasn't being deallocated.

These leaks are fixed by PR #36

Closing now fix has been merged and release in BlueRSA 1.0.24


NixOS module(s) for running a cardano-node SPO

We need NixOS module(s) for starting a node as SPO (two node may be needed). We should re-use the upstream NixOS module as much as possible.
Both configuration files (we can choose to target a single public testnet for now) and secret keys can be put inside a directory in this flake for now (well, at least until we don't have to delegate real ADAs, I would avoid to push secret keys that could be used for retrieving ADAs, even for public testnets).
For now let's keep everything in this repo, in future we may consider if to move to cardano.nix.

fixed by https://github.com/mlabs-haskell/spo-anywhere/pull/21


Can't seem to get output

I tried running it then got an error that it was missing config.yml, so I created this file and added port: 3000. I started the program, but there is no output, expected gin output but got nothing.
Any guidance available? I would love to contribute to this project and use it as the basis for my next project.
It does appear to be working though

Getting things like:
{{ entry.attributes.title }}

{{ entry.attributes.markdown }}

Any idea why vue isn't working?

It appears to be missing the vendor folder entirely.

Can you provide the basic requirements in the vendor folder in the repo, then ignore the rest.

Currently this project is just a test. I'll add further configuration instruction in the README.md.


[suggestion] icns tool  github.com/jackmordaunt/icns

I noticed the readme links to a website for png => icns conversion. I wrote a utility that does exactly this conversion. Perhaps it would be a valuable suggestion as well as, or instead of, the website link.
https://github.com/jackmordaunt/icns

good idea. I use your lib and it work great


Remove createJSModules @override marker - RN 0.47 compatibility

createJSModules is now not required on Android from RN 0.47. I actually can't build an app on RN 0.47 without removing this method/@ovveride marker. This is backwards compatible according to my tests.

should not the whole method be removed rather than just the override decorator?

This makes it compatible with old RN versions.


empty shared_name disable shared_subscription

Hello Chirpstack Team
My Problem :
I see #407 and this Chirpstack Forum
Yes RabbitMQ 3.13 use MQTTv5 but shared subscriptions is not yet supported :
RabbitMQ Blog
In my stack I use chirpstack gateway bridge + chirpstack + RabbitMQ 3.13
But if we use shared subscription. I must config ChirpstackGatewayBridge, cause he use MQTT 3.1,
like this
event_topic_template="$share/chirpstack/eu868/gateway/{{ .GatewayID }}/event/{{ .EventType }}"
state_topic_template="$share/chirpstack/eu868/gateway/{{ .GatewayID }}/state/{{ .StateType }}"

Maybe a futur release of RabbitMQ change that and broke GatewayBridge.
A Solution
I edit mqtt.rs if share_name is empty I don't want to use share subscription feature else use it
Thanks for reading
PS: I can miss something in config

Thanks @jbnoblot, I have been diving into the MQTTv5 specs, and I noticed that a MQTT does not have to provide the shared-subscription feature. In the connack payload that is returned by the MQTT broker, it can indicate if the feature is supported: https://docs.rs/rumqttc/latest/rumqttc/v5/mqttbytes/v5/struct.ConnAckProperties.html#structfield.shared_subscription_available
This means we might even solve this issue without config changes.

@jbnoblot the above commit solves the issue with connecting to RabbitMQ (MQTTv5 interface). I have tested this locally and when connecting to Mosquitto it uses the shared subscription prefix, when connecting to RabbitMQ it does not. No config change needed in the .toml :-)

@brocaar Wow more elegant. Better solution. that's awesome.
Thank you for this. 🙌🙌🙌


OS X build fails to launch on fresh miniconda

[scorlay@mbp ~/Desktop]$ r
dyld: Library not loaded: @rpath/libintl.9.dylib
  Referenced from: /Users/scorlay/miniconda3/lib/R/lib/libR.dylib
  Reason: image not found
Abort trap: 6

The issue appears to be with the gettext package, which provides libintl.8.dylib instead of libintl.9.dylib.
I wonder how R was linked with libintl.9.dylib

Are there any r packages installed in your environment from defaults?

This now seems to work with a more recent miniconda.


Centos8 podman is 1.1.0?

Why the podman version is 1.1.0 in centos8, how can I install the latest version of podman use yum ?

@lsm5 can you assist please?

Probably not until centos enables sig repos for centos8. For now you gotta wait for stuff to land in base CentOS.

Centos7 is v1.4.4, but I really want to use the latest version of podman!

Ok


[Tabs] Scrollable Tabs throwing error when used inside dialog

Problem description
Per discussion in #6502, using scrollable tabs inside a dialog can cause a "Cannot read property 'scrollLeft' of null' error to be thrown when the dialog is dismissed.
This problem occurs because dismissing the dialog triggers a re-render of the dialog and its children.  During re-render, the tabs are scrolling the selected tab into view which also fires a scrolling event.  The DOM reference to the event listener is going out of scope but the event handler callback is firing and now has a null instance variable.
Although the null variable is the symptom, I think the real problem is that the handlers for dealing with tab selection change and/or width resize are firing when the respective props haven't changed.  This can also cause the tab strip to scroll the selected tab into view when it really should not.  Ultimately, that leads to the null variable issue.
I will work up a PR to improve the lifecycle workflow and address null variable issue as well.
Link to minimal working code that reproduces the issue
https://www.webpackbin.com/bins/-Kig2FesYczwJewQHSF1

Versions

Material-UI: 1.0.0.alpha-11
React: 15.5.4
Browser: Shouldn't matter, but seen in Chrome 57.0.2987.133

Aside from the error thrown we can see the following scroll triggered:

@oliviertassinari That brings me back! <BLINK><IMG SRC="HTML-like-its-1995.gif"></BLINK>


Migrated the classic algorithm for choosing markers from SingleR.

Codecov Report

Merging #10 (f9c46b9) into master (1b12abd) will decrease coverage by 0.12%.
The diff coverage is 98.21%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   99.33%   99.21%   -0.13%
==========================================
  Files          20       22       +2
  Lines        1353     1521     +168
==========================================
+ Hits         1344     1509     +165
- Misses          9       12       +3

Impacted Files
Coverage Δ

include/singlepp/ChooseClassicMarkers.hpp
96.47% <96.47%> (ø)

tests/src/ChooseClassicMarkers.cpp
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b12abd...f9c46b9. Read the comment docs.


It looks like the auth is working, but I am not confident in the axios call. Getting

          It looks like the auth is working, but I am not confident in the axios call. Getting

error:
gcpApi:  {
  url: {
    protocol: 'https:',
    hostname: 'www.googleapis.com',
    pathname: 'drive/v3/files/1YmuVswG_Lj3GQp13RCmAGNzavBRT20Ncwk1trWVPdVg'
  },
  method: 'GET',
  headers: {
    authorization: 'Firebase {token}'
  }
}
gcpApi:  Error: connect ECONNREFUSED <IP_ADDRESS>:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1146:16) {
  errno: -61,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '<IP_ADDRESS>',
  port: 443,
  config: {
    url: 'https:://www.googleapis.com/drive/v3/files/1YmuVswG_Lj3GQp13RCmAGNzavBRT20Ncwk1trWVPdVg',
    method: 'get',
    headers: {
      Accept: 'application/json, text/plain, */*',
      authorization: 'Firebase {token}',
      'User-Agent': 'Chrome'
    },
    transformRequest: [ [Function: transformRequest] ],
    transformResponse: [ [Function: transformResponse] ],
    timeout: 0,
    adapter: [Function: httpAdapter],
    xsrfCookieName: 'XSRF-TOKEN',
    xsrfHeaderName: 'X-XSRF-TOKEN',
    maxContentLength: -1,
    maxBodyLength: -1,
    validateStatus: [Function: validateStatus],
    transitional: {
      silentJSONParsing: true,
      forcedJSONParsing: true,
      clarifyTimeoutError: false
    },
    data: undefined
  },
  request: <ref *1> Writable {
    _writableState: WritableState {
      objectMode: false,
      highWaterMark: 16384,
      finalCalled: false,
      needDrain: false,
      ending: false,
      ended: false,
      finished: false,
      destroyed: false,
      decodeStrings: true,
      defaultEncoding: 'utf8',
      length: 0,
      writing: false,
      corked: 0,
      sync: true,
      bufferProcessing: false,
      onwrite: [Function: bound onwrite],
      writecb: null,
      writelen: 0,
      afterWriteTickInfo: null,
      buffered: [],
      bufferedIndex: 0,
      allBuffers: true,
      allNoop: true,
      pendingcb: 0,
      prefinished: false,
      errorEmitted: false,
      emitClose: true,
      autoDestroy: true,
      errored: null,
      closed: false
    },
    _events: [Object: null prototype] {
      response: [Function: handleResponse],
      error: [Function: handleRequestError]
    },
    _eventsCount: 2,
    _maxListeners: undefined,
    _options: {
      maxRedirects: 21,
      maxBodyLength: 10485760,
      protocol: 'https:',
      path: '://www.googleapis.com/drive/v3/files/1YmuVswG_Lj3GQp13RCmAGNzavBRT20Ncwk1trWVPdVg',
      method: 'GET',
      headers: [Object],
      agent: undefined,
      agents: [Object],
      auth: undefined,
      hostname: null,
      port: null,
      nativeProtocols: [Object],
      pathname: '://www.googleapis.com/drive/v3/files/1YmuVswG_Lj3GQp13RCmAGNzavBRT20Ncwk1trWVPdVg'
    },
    _ended: true,
    _ending: true,
    _redirectCount: 0,
    _redirects: [],
    _requestBodyLength: 0,
    _requestBodyBuffers: [],
    _onNativeResponse: [Function (anonymous)],
    _currentRequest: ClientRequest {
      _events: [Object: null prototype],
      _eventsCount: 7,
      _maxListeners: undefined,
      outputData: [],
      outputSize: 0,
      writable: true,
      destroyed: false,
      _last: true,
      chunkedEncoding: false,
      shouldKeepAlive: false,
      _defaultKeepAlive: true,
      useChunkedEncodingByDefault: false,
      sendDate: false,
      _removedConnection: false,
      _removedContLen: false,
      _removedTE: false,
      _contentLength: 0,
      _hasBody: true,
      _trailer: '',
      finished: true,
      _headerSent: true,
      socket: [TLSSocket],
      _header: 'GET ://www.googleapis.com/drive/v3/files/1YmuVswG_Lj3GQp13RCmAGNzavBRT20Ncwk1trWVPdVg HTTP/1.1\r\n' +
        'Accept: application/json, text/plain, */*\r\n' +
        'authorization: Firebase {token}\r\n' +
        'User-Agent: Chrome\r\n' +
        'Host: localhost\r\n' +
        'Connection: close\r\n' +
        '\r\n',
      _keepAliveTimeout: 0,
      _onPendingData: [Function: noopPendingOutput],
      agent: [Agent],
      socketPath: undefined,
      method: 'GET',
      maxHeaderSize: undefined,
      insecureHTTPParser: undefined,
      path: '://www.googleapis.com/drive/v3/files/1YmuVswG_Lj3GQp13RCmAGNzavBRT20Ncwk1trWVPdVg',
      _ended: false,
      res: null,
      aborted: false,
      timeoutCb: null,
      upgradeOrConnect: false,
      parser: null,
      maxHeadersCount: null,
      reusedSocket: false,
      host: 'localhost',
      protocol: 'https:',
      _redirectable: [Circular *1],
      [Symbol(kCapture)]: false,
      [Symbol(kNeedDrain)]: false,
      [Symbol(corked)]: 0,
      [Symbol(kOutHeaders)]: [Object: null prototype]
    },
    _currentUrl: 'https:://www.googleapis.com/drive/v3/files/1YmuVswG_Lj3GQp13RCmAGNzavBRT20Ncwk1trWVPdVg',
    [Symbol(kCapture)]: false
  },
  response: undefined,
  isAxiosError: true,
  toJSON: [Function: toJSON]
} {
  url: 'https://www.googleapis.com/drive/v3/files/1YmuVswG_Lj3GQp13RCmAGNzavBRT20Ncwk1trWVPdVg'
}

Just attempting to grab a drive file of the logged in user. I removed the token from the errors.
Originally posted by @Calhistorian in https://github.com/david-asher/electron-firebase/issues/10#issuecomment-963633995

The error is ECONNREFUSED and I tend to trust these error reports, so this looks more like a connection problem than an authentication problem. Usually to debug these further I will run the chrome debugger and look at the network trace to try and get more information.


[pkg] update jsnext:main -> module

"module" is the new field name for specifying an ESM entry
point that the various bundlers have coordinated around

Coverage increased (+0.2%) to 94.647% when pulling 3c17a2c4e0de7ebc765fe03df9dbb0f216e3e002 on evan-scott-zocdoc:side-effects into 3062ca13cd1cfbcef1c4a0cd5543f5fcd329c1d9 on moment:develop.

Coverage increased (+0.2%) to 94.647% when pulling 3c17a2c4e0de7ebc765fe03df9dbb0f216e3e002 on evan-scott-zocdoc:side-effects into 3062ca13cd1cfbcef1c4a0cd5543f5fcd329c1d9 on moment:develop.

This was already addressed in 9ce89e7fea881b39be23b8c0646f7ef7817985d9.
Also we're not removing the jsnext:module for backwards compatibility.


opencv_version

hello， I would like to know which version of opencv you are using？

I don't think it matters at all as far as you use any major version 4.x onwards. Just use the latest one (4.5.5 right now) and you will be fine.

Hi, may I ask which version of Eigen is? I met the following problems when compiling (using OpenCV 4.5.5 , Open3D 0.10.1)
In file included from /usr/local/include/eigen3/unsupported/Eigen/CXX11/src/util/CXX11Meta.h:14:0,
from /usr/local/include/eigen3/unsupported/Eigen/CXX11/Tensor:31,
from /home/yr/cvlib/opencv-4.5.5/modules/core/include/opencv2/core/eigen.hpp:64,
from /home/yr/Open3DGen/src/math_modules.h:9,
from /home/yr/Open3DGen/src/math_modules.cpp:1:
/usr/local/include/eigen3/unsupported/Eigen/CXX11/src/util/EmulateArray.h:254:30: error: redeclared with 1 template parameter
template  struct array_size;
^~~~~~~~~~
In file included from /usr/local/include/Open3D/3rdparty/Eigen/Core:151:0,
from /usr/local/include/Open3D/Camera/PinholeCameraIntrinsic.h:29,
from /usr/local/include/Open3D/Open3D.h:30,
from /home/yr/Open3DGen/src/math_modules.h:2,
from /home/yr/Open3DGen/src/math_modules.cpp:1:
/usr/local/include/Open3D/3rdparty/Eigen/src/Core/util/Meta.h:402:55: note: previous declaration ‘template<class T, class EnableIf> struct Eigen::internal::array_size’ used 2 template parameters
template<typename T, typename EnableIf = void> struct array_size {
^~~~~~~~~~
In file included from /usr/local/include/eigen3/unsupported/Eigen/CXX11/src/util/CXX11Meta.h:14:0,
from /usr/local/include/eigen3/unsupported/Eigen/CXX11/Tensor:31,
from /home/yr/cvlib/opencv-4.5.5/modules/core/include/opencv2/core/eigen.hpp:64,
from /home/yr/Open3DGen/src/math_modules.h:9,
from /home/yr/Open3DGen/src/math_modules.cpp:1:
/usr/local/include/eigen3/unsupported/Eigen/CXX11/src/util/EmulateArray.h:255:41: error: redefinition of ‘struct Eigen::internal::array_size<const std::array<_Tp, _Nm> >’
template<class T, std::size_t N> struct array_size<const std::array<T,N> > {


Feature request: parity with regex-based vim-tex-syntax highlighter

I was experimenting with using this grammar in neovim through the nvim-treesitter plugin. Unfortunately the highlighting this grammar provides does not compare favorably with neovim's built-in regex-based latex highlighter. Here is an example from a tikz file of mine (file available here); the first is regex-based, the second is tree-sitter based:

My chosen colorscheme disadvantages the tree-sitter example, true, but also things like lack of differentiating highlighting on underscores or dollar signs jump out. Also, the regex-based highlighter does neat things like color the nested \begin and \end tokens differently to match them with their counterpart, which should be tree-sitter's bread & butter.

Unfortunately the highlighting this grammar provides does not compare favorably with neovim's built-in regex-based latex highlighter.

Yeah, I can imagine that one. Originally, this grammar was designed to replace the parser of texlab (but in the end it did not end up replacing it). So there still needs some work to be done in order to provide a good highlighting experience. I was hoping that this grammar can provide a good foundation for a tree-sitter based highlighter.

My chosen colorscheme disadvantages the tree-sitter example, true, but also things like lack of differentiating highlighting on underscores or dollar signs jump out.

This is not something, I can easily fix in my repository as I only provide the actual parser and not the highlighting queries. These live in another repository. I think its nvim-treesitter. The only change I can make from my side is parsing sub- and superscripts correctly.

Also, the regex-based highlighter does neat things like color the nested \begin and \end tokens differently to match them with their counterpart, which should be tree-sitter's bread & butter.

I am assuming you mean some kind of rainbow highlighting? In that case, I would say that it is quite difficult with tree-sitter's highlighting engine but I am not sure. Again, you may be better off reporting this over at nvim-treesitter as I am not in charge of the highlighting queries. I only provide the grammar itself and nothing else.

@pfoerster Thanks for all your work on this grammar! I too wrote my own tree-sitter grammar with the hope it would serve as the backbone of an interpreter for that language; I discovered (as I assume you did) tree-sitter isn't really designed for that use-case.
This actually kinda dovetails with an issue of my expectations about where the highlighting rules should live (see https://github.com/nvim-treesitter/nvim-treesitter/issues/1478); the tree-sitter syntax highlighting docs say it should live with the grammar in the repo, but I guess nvim-treesitter separates those queries into nvim itself? Seems strange; the nature of those queries is they are separated from any particular colorscheme, are tightly bound to the design of the grammar itself, and are standard enough to be independent from any client of the tree-sitter grammar. So, it would make sense for them to live in the grammar repo with the grammar itself. But perhaps I'm not seeing the big picture here. Anyway, feel free to close this as I guess those queries are separate from this grammar.

The highlighting queries for neovim indeed live in https://github.com/nvim-treesitter/nvim-treesitter/tree/master/queries/latex (it turns out that while much of it can be shared, some details are specific to the actual use case -- i.e., how the queries are used). But I, too, often struggle with whether a certain feature is something that can be done by a query or should be implemented in the parser... I'm sure help with extending is appreciated on both sides!
For what it's worth, the current queries are already pretty close to feature-parity with the base tex.vim syntax file,  but the extended, package-aware rules (especially those in the vimtex filetype plugin) are on a different level, still (and I'm not sure how reasonable it is to expect a similar support from the "built-in" tree-sitter highlighting; I think this requires a separate nvimtex plugin).
Color schemes are indeed a separate thing; nvim-treesitter defines basic TSFunction etc. highlight groups, but they also define more low-level texTSFoo groups for the actual captures, so you can use them for a LaTeX-specific color scheme.


fan, vacuum: replace device_state_attributes usage.

The device_state_attributes property has been deprecated since 2021.4
but only just started issuing startup logs.
This addresses Issue #78.

Thank you very much for your contribution ! I'll issue a new release ASAP to fix the ongoing warnings


Add fractional derivative examples

See this paper for more background on the context of fractional derivatives in the SIR model.
Solvers implemented in https://github.com/SciFracX/FractionalDiffEq.jl and https://github.com/JuliaTurkuDataScience/FdeSolver.jl

Added examples with FdeSolver.jl and FractionalDiffEq.jl. I should flesh out an example based on section 4.1 of https://epubs.siam.org/doi/abs/10.1137/21M1398549, as suggested by @slwu89

See also https://arxiv.org/abs/1505.02492 and https://arxiv.org/abs/1511.02545


microtar from mem

I don't know how good form this is, but this is useful when A) obviously when you have your tar file in mem, B) useful when you have a inflated (decompressed!) gzip buffer from e.g. zlib.
// mtar from mem buffer

static int mem_write(mtar_t *tar, const void *data, unsigned size)
{
	return MTAR_EWRITEFAIL;
}

static int mem_read(mtar_t *tar, void *data, unsigned size)
{
	unsigned char *buf = (unsigned char *)tar->stream;
	memcpy(data, buf + tar->pos, size);
	return MTAR_ESUCCESS;
}

static int mem_seek(mtar_t *tar, unsigned offset)
{
	return MTAR_ESUCCESS;
}

static int mem_close(mtar_t *tar)
{
	// Todo, Delete the data?
	return MTAR_ESUCCESS;
}

int mtar_open_mem(mtar_t *tar, void *data)
{
	int err;
	mtar_header_t h;

	// Init tar struct and functions
	memset(tar, 0, sizeof(*tar));
	tar->write = mem_write;
	tar->read = mem_read;
	tar->seek = mem_seek;
	tar->close = mem_close;

	tar->stream = data;

	err = mtar_read_header(tar, &h);
	if (err != MTAR_ESUCCESS)
	{
		mtar_close(tar);
		return err;
	}

	// Return ok
	return MTAR_ESUCCESS;
}
// --------

I realize the memcpy may be unnecessary, I didn't check if data = buf + tar->pos was sufficient.


[Bugfix] Include setup_cython.py in Dockerfile.rocm

A previous PR added a setup_cython.py script to use Cython compilation to improve performance of certain key files.  This PR updates Dockerfile.rocm to call setup_cython during the build so that docker images can benefit from these optimizations.

Change made against the wrong branch -- will close this PR and open a new one.


ci: codedev token

fix: https://github.com/envoyproxy/gateway/pull/2558
doc: https://docs.codecov.com/docs/adding-the-codecov-token#github-actions

@phlax @Xunzhuo need token for codedev, can you help to set the secret?

Will update it tomorrow

Will update it tomorrow

not sure why it's passed now.

Should we close this ?

Should we close this ?

yeah, I crosschecked and we are not adding a TOKEN to our repo or org secrets, so not sure what's happening here

/close this for now, reopen it if needed later


There is no Authentication and Authorization

all data is exposed to everybody

Risk accepted due to the fact that there is no sensitive or confidential data hosted in the live sites

There is free for open-source authentication library called auth0 that we could explore for this purpose.
Node SDK:

https://github.com/auth0/node-auth0


[PROBLEM] An action works no more

Describe the problem
I have a problem with the plugin since yesterday.... have configured 3 actions on my Harmony:

cinema - turns on a media player, A/V receiver & TV.
Netflix - turns on the TV and launches the Netflix app.
eintertain - turns on the TV & Telekom Receiver

Since yesterday action 3 does not work reliably - when I start this action on the Harmony remote control the message appears that the action is started but very often only the TV is switched on - when ending the action the same, sometimes only the TV is switched off! I have tested extensively and the Telekom receiver is mostly only at the 2nd or 3rd execute the action on or off!
If I start the action on the Harmony remote everything works - both devices are switched on and when switching off the same!
Actions 1+2 work fine - I have powered down the receiver & Harmony Hub and restarted Homebridge with no success! Since this has never happened since I use the plugin and also only one action is affected by it, I'm pretty clueless what the reason can be...
To Reproduce
I switched on Entertain and the TV manually, activated the Homebridge Debug Log and switched off action 3 - works, the Telekom receiver and the TV are switched off! Then I turned on action 3 - only the TV is turned on, the telecom receiver remains off.
IOS (please complete the following information):

Version 14.4
Device: iPhone 12 Pro Max

Logs
homebridge.log.txt
Config
{
"name": "Harmony",
"hubIP": "<IP_ADDRESS>",
"publishAllTVAsExternalAccessory": true,
"TVAccessory": true,
"mainActivity": "Fernsehen",
"playPauseBehavior": true,
"switchAccessories": true,
"showTurnOffActivity": "true",
"addAllActivitiesToSkippedIfSameStateActivitiesList": true,
"platform": "HarmonyHubWebSocket",
"_bridge": {
"username": "xxx",
"port": 46696
}
}

Hi,
Did you change anything in your conf ? harmony plugin only send the activity command to the hub, t is the hub itself which launch each action. Are you sure there is no IR issue between the hub and the device that not always works ? Depending on your remote, it could be sent by it so it won't have the same behavior I think. Try with harmony app on your phone you should have the same erratic behavior .

Hi Nico!
I have not changed anything in the configuration for ages! Have just tested both with the original remote control of the Telekom receiver, the Harmony Elite remote control and the app on my iPhone several times and each time works the action on or off! About the plugin it now unfortunately no longer works, it is only the TV switched but no longer the Telekom receiver!

You are using an harmony activity right, not a custom sequence or something like that ?

Yes, right!

sl like I said it is very strange, since the plugin only activate the activity (not what is inside). Could you run in debug and post any log when activating / turning off ? Did you try with switches (instead of input of TV accessory) or vice-versa ?

The logs i‘ve uploaded in my first post have the needed turn off / activate action with the nom working power on! I use it as switches... indeed, very strange- works perfect in the last years...

Sorry, missed the logs . However everything seems fine : [3/7/2021, 2:20:42 PM] [Harmony] (Harmony)INFO : SET on an activty in skippedIfsameState list Entertain
[3/7/2021, 2:20:42 PM] [Harmony] (Harmony)INFO : Activty Entertain is false, wants to set to true
[3/7/2021, 2:20:42 PM] [Harmony] (Harmony)INFO : Activty Entertain will be sent command 29968007
[3/7/2021, 2:20:42 PM] [Harmony] (Harmony)INFO - activityCommand : Returned from hub {"cmd":"harmony.activityengine?runactivity","code":200,"id":"0.12144464999462112","msg":"OK"}
Did you try setting a new activity with this device ?

I have three activities on the Harmony hub, the other both are working perfect! Do you mean to delete the activity on the harmony and create a new one with the same settings? I can try this tomorrow when i‘m back home!
And thanks for your help!

Hi @nicoduj
I recreated the action on the hub, uninstalled the plugin, deleted the child bridge and reinstalled the plugin and turned on debug mode! Have then run the action several times, the Telekom receiver has not responded once - I hope you find something in the logs...
homebridge.log.txt

Hi, did not see anything in the plogs. One idea however : If you have renamed your activties in home app, maybe you can try to delete the file named harmonyPluginNames_XXX in the root directory of your homebridge folder.
Have no other idea for the moment, the activity is fine through harmony app ?

Closing since I have no update on this.


etcdctlv3: expose store size and raft status in 'etcdctl status' command

ref https://github.com/coreos/etcd/issues/4797
@xiang90

Do you have any example output?

example output:
➜  bin git:(memberStatus) ✗ ./etcdctl status
+-----------------+------------------+-----------+-----------+-----------+----------+----------------------+
|    ENDPOINT     |        ID        |  VERSION  | STORESIZE | RAFTINDEX | RAFTTERM |       RAFTLEAD       |
+-----------------+------------------+-----------+-----------+-----------+----------+----------------------+
| <IP_ADDRESS>:2379  | 8211f1d0f64f3269 | 2.3.0+git |     24576 |     87086 |        6 |<PHONE_NUMBER>6912138824 |
| <IP_ADDRESS>:22379 | 91bc3c398fb3c146 | 2.3.0+git |     24576 |     87086 |        6 |<PHONE_NUMBER>6912138824 |
| <IP_ADDRESS>:32379 | fd422379fda50e48 | 2.3.0+git |     24576 |     87086 |        6 |<PHONE_NUMBER>6912138824 |
+-----------------+------------------+-----------+-----------+-----------+----------+----------------------+

@xiang90 Updated. PTAL. Sample output:
➜  bin git:(memberStatus) ✗ ./etcdctl status
+-----------------+------------------+-----------+---------+-----------+-----------+------------+
|    ENDPOINT     |        ID        |  VERSION  | DB SIZE | IS LEADER | RAFT TERM | RAFT INDEX |
+-----------------+------------------+-----------+---------+-----------+-----------+------------+
| <IP_ADDRESS>:2379  | 8211f1d0f64f3269 | 2.3.0+git | 25 kB   | false     |         9 |     100080 |
| <IP_ADDRESS>:22379 | 91bc3c398fb3c146 | 2.3.0+git | 25 kB   | false     |         9 |     100080 |
| <IP_ADDRESS>:32379 | fd422379fda50e48 | 2.3.0+git | 25 kB   | true      |         9 |     100080 |
+-----------------+------------------+-----------+---------+-----------+-----------+------------+

@mqliang Can you please update the commit message of the last message to etcdctl: print db size and raft status in 'etcdctl status' command (add etcdctl as subpkg in commit message)

@xiang90 Reworked. Sorry for my missing.

@mqliang gofmt fails (https://semaphoreci.com/coreos/etcd/branches/pull-request-4957/builds/3).

@xiang90
Checking gofmt...
Checking govet...
Checking govet -shadow...
Checking goword...
./test: line 104: goword: command not found
Checking for license header...
license header checking failed:
  ./vendor/golang.org/x/tools/present/html.go
  ./vendor/golang.org/x/tools/oracle/pos.go
  ./vendor/golang.org/x/tools/imports/mkstdlib.go
  ./vendor/golang.org/x/tools/go/callgraph/static/static.go
  ./vendor/golang.org/x/tools/go/buildutil/tags.go
  ./vendor/golang.org/x/tools/go/buildutil/fakecontext.go
  ./vendor/golang.org/x/tools/go/ast/astutil/util.go
  ./vendor/github.com/gogo/protobuf/protoc-gen-gogo/descriptor/gostring.go
  ./vendor/github.com/dustin/go-humanize/times.go
  ./vendor/github.com/dustin/go-humanize/si.go
  ./vendor/github.com/dustin/go-humanize/ordinals.go
  ./vendor/github.com/dustin/go-humanize/number.go
  ./vendor/github.com/dustin/go-humanize/humanize.go
  ./vendor/github.com/dustin/go-humanize/ftoa.go
  ./vendor/github.com/dustin/go-humanize/comma.go
  ./vendor/github.com/dustin/go-humanize/bytes.go
  ./vendor/github.com/dustin/go-humanize/bigbytes.go
  ./vendor/github.com/dustin/go-humanize/big.go

Some files I import have no license header. Any  suggestion?

@mqliang I think there is something wrong with your godep at the first place. this pr introduces tons of dependencies which it should not. We recently changed the repo layout. Probably you need to do a rebase. Then you will need to cd into cmd dir to vendor dependency again. Sorry for the inconvenience!

@xiang90 @mqliang godep will mess up with cd cmd && godep save ./.... It did work like that in the middle of the revendor PR but unfortunately it seems like it doesn't now; it tries to vendor etcd.
My workaround right now is:
# from etcd project root
ln -s cmd/vendor vendor
godep save ./cmd/...
rm vendor
rm -rf cmd/Godeps
mv Godeps cmd/

@mqliang I just introduced the dependency here: https://github.com/coreos/etcd/pull/5041. So just rebase with master, then everything should be OK.

Thanks!


FROM header changes more than once

Hello,
I'm currently troubleshooting a 530 From/Sender name is not valid error and am combing through SMTP logs to get a better understanding of the issue.
[34m[smtp.1:2673][0m [2020-12-21T20:17:56.546] DEBUG -- : [UIIQHB] [34m=> 235 Granted for acme/ent-relay[0m

Provided that the above-emboldened attribute is the unique transaction/exchange ID, is it normal to see the MAIL FROM attribute updated multiple times for one transaction? I'm seeing the following on a recurring basis:
[34m[smtp.1:2673][0m [2020-12-22T20:59:07.741] DEBUG -- : [IWH2TC] [32m<= MAIL<EMAIL_ADDRESS>[34m[smtp.1:2673][0m [2020-12-22T20:59:08.332] DEBUG -- : [IWH2TC] [32m<= MAIL<EMAIL_ADDRESS>[34m[smtp.1:2673][0m [2020-12-22T20:59:11.282] DEBUG -- : [IWH2TC] [32m<= MAIL<EMAIL_ADDRESS>[34m[smtp.1:2673][0m [2020-12-22T20:59:12.759] DEBUG -- : [IWH2TC] [32m<= MAIL<EMAIL_ADDRESS>What I find very interesting about this is that the last entry in the log indicates a change in domain. While this Postal instance does in-fact have two organizations on it, I'm not sure I understand why a sender from one domain would spill into the mail traffic for the other.
I created a small tool in Node.JS for log inspection and from what I can gather, the only transactions reaching successful dispositions are the ones where the MAIL FROM attribute is updated only once. All other failed transactions show multiple log entries where this attribute is being changed.
Both organizations dispatch to Postal via EXIM relay, so if it's necessary for the headers to be manipulated in some way or another to prevent this from occurring, this is not an issue for us.
Any insight on this matter is greatly appreciated.
Thanks!

That is a good spot, you can see how Postal handles mail from here https://github.com/postalhq/postal/blob/2595481b266199d8e29347dea2764f2c10202805/lib/postal/smtp_server/client.rb#L231-L247
I believe that each individual message should only have one mail from so the fact there are multiple in your situation implies that your relay isn't completing one connection before starting another or is potentially misconfigured in another way.
I don't fully understand what is happening in that code but I imagine that the recorded mail from is being replaced until the sending software moves on to the next command. The error you're seeing is because the found domain from mail from doesn't match the domains in the same server as the credential key, which is understandable if multiple are being sent.

Thank you for the swift response. Knowing which routine does this interpretation helps significantly. I'm going to run a series of tests and see what sort of patterns I can identify.
I'll report back here once I've nailed something. Thanks!

I've completed some tests and am very surprised by what I've found.

TL;DR
Maybe having two tenants using the same EXIM router caused this issue?

The production instance of Postal that we're using relays mail sent to it from a cPanel/WHM server running EXIM as the mail transfer agent**. The cPanel server has two tenants on it and in Postal, each tenant is configured as a separate organization each with its own mail server and set of SMTP credentials.
**After a misconfigured WooCommerce incident, the cPanel server's IP address reputation was in the can, so relay was our only immediate choice for getting up and running quickly. Postal was a dream to setup and has been superb.
In our initial setup, only one EXIM router was configured to dispatch mail from EXIM to Postal, but a lookup string expansion was used to ensure that each connection supplied the correct set of credentials:
#ROUTER
send_via_postal:
  driver = manualroute
  senders =<EMAIL_ADDRESS><EMAIL_ADDRESS>  domains = ! +local_domains
  transport = postal_smtp
  route_list = * postal.example.com
  no_more

#AUTH
postal_login:
  driver = plaintext
  public_name = LOGIN
  client_send = : ${extract{user}{${lookup{$sender_address_domain}lsearch{/etc/postalcredentials}}}}: \
                  ${extract{pass}{${lookup{$sender_address_domain}lsearch{/etc/postalcredentials}}}}

Operating under the assumption that only one message would be sent per SMTP connection to Postal, this would have appeared to work correctly. However, that doesn't seem to be what was happening.
Based on the log data from Postal, it looks like a connection would open to transfer a message for example.com, and while that connection was open, a message for acme.com would also be transferred while still under the connection authenticated for example.com. Of course, as you've seen from the initial post, this would update the MAIL FROM attribute, and cause the message to fail delivery with code 530.
I expected that concurrent transfers like this would only take place if the messages were received by EXIM at the same time, so I programmed a filter to freeze all outbound messages, and then used the CLI tools to release for transfer to Postal all at once. Contrary to my expectation, each message was sent over its own SMTP connection, and Postal processed the deliveries normally.
At this point, I'm not entirely certain why this issue was occurring. There's a possibility that my test procedure is not bulletproof, but I'm relatively confident it's simulating the conditions I'm trying to replicate. What I hope will be the final nail in the coffin is the separation of the two tenants' traffic into two different routers both pointed at Postal. If EXIM is transferring more than one message per SMTP connection, then I should think that two different routers would ensure that each tenants' messages at least travel over the correctly-authenticated connection.
I'd be curious to know your thoughts on this. Should more than one message per SMTP connection be getting transferred like this?
Cheers and thanks again,
Stephan

I think it is fine to send more than one message per SMTP connection but one message needs to be fully transferred before the next one can start unless there is some kind of threading process to allow multiple messages to be transferred simultaneously.
You can see in that file how the connection can be re used to send further messages but the messages must match the domain used in the original credential.
It may be that exim has interpreted the postal connection as a more low level gateway that can handle everything thrown at it rather than something which needs a bit more care and attention.
Exim may be expecting some kind of threading behaviour which postal doesn't yet implement. You could have a look at #751 but I'm not sure how useful that will be.
Your example suggested that exim was trying to send four messages simultaneously so something to be aware of would be some queuing behaviour at your end to ensure exim was able to properly separate messages.
I don't really know much about exim but hope some of that was useful!

Quite helpful, yes — thank you!
I configured EXIM to treat each connection to Postal as a separate router, even though they both are required to share the same authenticator. In this way, EXIM opens one connection to Postal per collection of messages it needs to send per domain:
example_send_via_postal:
  driver = manualroute
  senders =<EMAIL_ADDRESS><EMAIL_ADDRESS>  domains = ! +local_domains
  transport = example_postal_smtp
  route_list = * postal.example.com
  no_more

acme_send_via_postal:
  driver = manualroute
  senders =<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>  domains = ! +local_domains
  transport = acme_postal_smtp
  route_list = * postal.example.com
  no_more

Since implementing this change, I've kept an eye on logs for a week and no unexpected failures have occurred. Things are working smoother than ever.
Thank you for your help with this! :sunglasses:

Quite helpful, yes — thank you!
I configured EXIM to treat each connection to Postal as a separate router, even though they both are required to share the same authenticator. In this way, EXIM opens one connection to Postal per collection of messages it needs to send per domain:
example_send_via_postal:
  driver = manualroute
  senders =<EMAIL_ADDRESS><EMAIL_ADDRESS>  domains = ! +local_domains
  transport = example_postal_smtp
  route_list = * postal.example.com
  no_more

acme_send_via_postal:
  driver = manualroute
  senders =<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>  domains = ! +local_domains
  transport = acme_postal_smtp
  route_list = * postal.example.com
  no_more

Since implementing this change, I've kept an eye on logs for a week and no unexpected failures have occurred. Things are working smoother than ever.
Thank you for your help with this! :sunglasses:


zeppelin-R build fails with bower

I am using the old version of zeppelin-R, which just gives you a interpreter jar which can be used to create an interpreter with minimal manual steps.
As we need to take data back and forth from R interpreter to scala interpreter, we would like to use new version of zeppelin-R. So I cloned this new version and provided the below command to build.
mvn clean install -Pspark-1.5 -Dspark.version=1.5.0 \
  -Dhadoop.version=2.7.1 -Phadoop-2.6 -Ppyspark \
  -Dmaven.findbugs.enable=false -Drat.skip=true -Dcheckstyle.skip=true \
  -DskipTests \
  -pl '!flink,!ignite,!phoenix,!postgresql,!tajo,!hive,!cassandra,!lens,!kylin'

Unfortunately I am getting the below exception
[INFO] Running 'bower --allow-root install' in /home/ubuntu/work/predictive-service/latest-zeppelin-R/zeppelin-R/zeppelin-web
[ERROR]
[ERROR] module.js:340
[ERROR]     throw err;
[ERROR]           ^
[ERROR] Error: Cannot find module '/home/ubuntu/work/predictive-service/latest-zeppelin-R/zeppelin-R/zeppelin-web/node_modules/bower/bin/bower'
[ERROR]     at Function.Module._resolveFilename (module.js:338:15)
[ERROR]     at Function.Module._load (module.js:280:25)
[ERROR]     at Function.Module.runMain (module.js:497:10)
[ERROR]     at startup (node.js:119:16)
[ERROR]     at node.js:901:3
[INFO] ------------------------------------------------------------------------

I tried with sudo as well. I am trying to build it on a EC2 instance.
Please help me to resolve this issue.

Zeppelin trunk had the same error and it has been fixed. I will merge trunk and push asap.

This comes from https://issues.apache.org/jira/browse/ZEPPELIN-634 which has just been fixed.
I have rebased. Can you pull rscala branch latest changes and try again?

Thanks, now build is successful, but unfortunately not able to open notebooks.
The header of zeppelin UI and notebook UI is not rendering in notebook
Here is the screen shot

I double check (fresh build of latest commit) and it works well for me. Can you force refresh the page in your browser (Shift-F5)? next step would be to debug the http requests with firebug or chrome developer...

I debugged the http requests using firebug.
Zeppelin server returning HTTP status 500 for the request http://host:8080/api/security/ticket.
Do I need to set anything in cookie or do I need to add any property?
Sorry if I am not aware of that

I have a 200 (OK) on that HTTP request with response: {"status":"OK","message":"","body":{"principal":"anonymous","ticket":"anonymous"}}
This comes from the recent merge of the authentication based on Shiro which is configured by the ./conf/shiro.ini file. You should have that content for the [url] section:
[urls]
# anon means the access is anonymous.
# authcBasic means Basic Auth Security
# To enfore security, comment the line below and uncomment the next one
/** = anon
#/** = authcBasic

With rebuild everything is working fine
Thanks a lot for your help


Use externally-defined OpenSearch version when specified.

Signed-off-by: dblock<EMAIL_ADDRESS>Description
Backporting #179 to 1.x.
The 1.x branch is -rc1 rn? Something looks fishy about how branches are used.
Issues Resolved
Closes #177.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #180 (5625ae4) into main (254510e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               main     #180    +/-   ##
==========================================
  Coverage     99.89%   99.89%
- Complexity     2471     2512    +41
==========================================
  Files           245      245
  Lines          5748     5853   +105
  Branches        333      342     +9
==========================================
+ Hits           5742     5847   +105
  Misses            5        5
  Partials          1        1

Impacted Files
Coverage Δ

...c/main/java/org/opensearch/sql/expression/DSL.java
100.00% <0.00%> (ø)

...in/java/org/opensearch/sql/data/type/ExprType.java
100.00% <0.00%> (ø)

...ava/org/opensearch/sql/data/type/ExprCoreType.java
100.00% <0.00%> (ø)

.../org/opensearch/sql/data/model/ExprValueUtils.java
100.00% <0.00%> (ø)

...rg/opensearch/sql/analysis/ExpressionAnalyzer.java
100.00% <0.00%> (ø)

...pensearch/sql/ppl/parser/AstExpressionBuilder.java
100.00% <0.00%> (ø)

...pensearch/sql/sql/parser/AstExpressionBuilder.java
100.00% <0.00%> (ø)

...nsearch/sql/expression/aggregation/Aggregator.java
100.00% <0.00%> (ø)

...arch/sql/expression/function/FunctionResolver.java
100.00% <0.00%> (ø)

...ch/sql/expression/aggregation/CountAggregator.java
100.00% <0.00%> (ø)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 254510e...5625ae4. Read the comment docs.


onie-nos-installer: fix sstate skip for onie-bundle

Presumably the intention of this value was to skip the sstate creation for the onie-bundle task, but setting it 0 allows it.
Fix this by setting SSTATE_SKIP_CREATION to 1, and also state the SSTATE_TASKS so it actually becomes considered (or so).

Found a cleaner fix, now bundled in the reproducibility PR..


Mono: Editor complains about missing mono path despite mono being bundled w/ the editor

Godot version:
3.1 Alpha5
OS/device including version:
Windows 10 64bit
Issue description:
Godot has mono bundled with releases, problem is the editor is still looking for the mono path locally and spits out this error
ERROR: find_mono: Cannot find mono in the registry
   At: modules/mono/utils/mono_reg_utils.cpp:161
Editing project: Z:/GameDev/Projects/Prototypes/ProjectDark (Z:::GameDev::Projects::Prototypes::ProjectDark)
OpenGL ES 3.0 Renderer: GeForce GTX 1060 6GB/PCIe/SSE2
ERROR: find_mono: Cannot find mono in the registry
   At: modules/mono/utils/mono_reg_utils.cpp:161
erasing C:\Users\Lamonte\AppData\Roaming/Godot/projects/ProjectDark-23b8da764d6571b21c2186076d56d43a/filesystem_update4
erasing Z:/GameDev/Projects/Prototypes/ProjectDark/.mono/metadata/scripts_metadata.editor
ERROR: Cannot find Mono's assemblies directory in the registry
   At: modules/mono/editor/godotsharp_builds.cpp:181
Running: D:\godot-devel\Godot-Devel.exe --path Z:/GameDev/Projects/Prototypes/ProjectDark --remote-debug <IP_ADDRESS>:23685 --allow_focus_steal_pid 22264 --position 320,180
OpenGL ES 3.0 Renderer: GeForce GTX 1060 6GB/PCIe/SSE2
ERROR: find_mono: Cannot find mono in the registry
   At: modules/mono/utils/mono_reg_utils.cpp:161

Workaround
Install any mono version to suppress the error
Dev Notes

The following error is expected if you don't have Mono installed and you selected MSBuild (Mono) as the build tool:
ERROR: Cannot find Mono's binaries directory in the registry
   At: modules/mono/editor/godotsharp_builds.cpp:181


Build error:  "ProCenter.Database.publish.xml  not found"

I am attempting to build ProCenter in VisualStudio Pro 2015 on Windows 10.  Most of the solution builds without issues.  However, the build fails with two errors which appear to be due to a missing file - ProCenter.Database.publish.xml.  Could this have been omitted from the commit?
Error text follows:
Error		03030: Could not copy the file "C:\Users\gdp72\PROCenter\ProCenter.Database\ProCenter.Database.publish.xml" because it was not found.	ProCenter.Database	C:\Windows\Microsoft.NET\Framework\v4.0.30319\Microsoft.Common.targets	3713

The "missing" file is referenced on line 85 of
https://github.com/OBHITA/PROCenter/blob/master/ProCenter.Database/ProCenter.Database.sqlproj#L85


Renaming metadata collisions to _original needs to be refined and documented

Original slack conversation

[ ] Its current behavior is not documented. @pablo-gar suggests adding to the cellxgene schema guide or its successor. Please note @MaximilianLombardo.

[ ] The granularity for renaming is coarse. In some cases, the value is exactly the same. In others, an ontology has been added, but the label value is the same. For example in https://cellxgene.cziscience.com/e/cfa3c355-ee77-4fc8-9a00-78e61d23024c.cxg/, the only major difference is between tissue and tissue_original. @pablo-gar notes:

We could do some extra checks in cellxgene-schema apply to avoid redundancy when found (i.e. not creating an "_original" when redundant) ...

cellxgene-schema will no longer rename collisions. Duplicate names are not allowed and will fail validation. The curator is responsible for ensuring that duplicates are not present.


Adding cwd field to trace_exec image-based gadget

Adding cwd field to trace_exec image-based gadget
Testing done

Unit Tests
Local Testing

Could you please rebase? I would like to check in the CI that it interacts well with the changes from #3138.


check-db.js script should report the actual cause of a connection error

Describe the feature or enhancement
While trying to install Umami I was stuck for quite a while at this stage:
✓ DATABASE_URL is defined.
✗ Unable to connect to the database.

The check-db.js script does not report what the actual exception raised by Prisma was. Credentials were correct, I was able to do a manual connection with psql with the given password etc., but this error persisted.
The problem turned out to be that Prisma was not finding the right version of the OpenSSL library*. But finding this out involved quite a bit of guesswork and wasted over an hour of my life.
The check-db.js script should actually show the exception that caused the connection to fail.
(* Why on earth it needs this in order to connect to a local database without SSL is anyone’s guess …)

It should report it now in the latest version.

Hi, I'm using provided docker compose and I'm having this issue too.
I would suggest getting more details about this error too (if possible).
NB: if needed umami could add an optional ENV variable to switch at DEBUG or VERBOSE level if it helps to solve some configuration issues (without impacting the current legacy startup logs level/verbosity)

@dpk, i fixed it in #2786, released in v2.13.0


Unable to use this module using node require()

After doing "npm i rsocket-core" and creating a .js file that simply does:

const RSC = require('rsocket-core')

I get an error similar to this one:
internal/modules/cjs/loader.js:302
      throw err;
      ^

Error: Cannot find module '/.../node_modules/rsocket-core/build/index.js'. Please verify that the package.json has a valid "main" entry
    at tryPackage (internal/modules/cjs/loader.js:294:19)
    at Function.Module._findPath (internal/modules/cjs/loader.js:525:18)

Please note that I don't want to use the "import" showed in examples because I need to run a simple node script from the command line.
EDIT: This seems to work if locking version to 0.0.10 so maybe it's a problem related to the latest 0.0.11 release

Same problem to me.

Hi-
There was some issues with the 0.11 release. Please try the 0.16 release.

It works with 0.16  release.  :)

It works again with versino 0.16, thanks :-)
But there is another minor issue: npm audit finds that the dependency on 'ws' for 'rsocket-websocket-server' uses an obsolete version with 1 high security vulnerability and should be upgraded.
You use ws version 2.3.1 while the latest one is 7.2.0, can you upgrade?


[flow-router-ssr][but/feature] SSR when dot in url

I am wondering if there is a way that the SSR is also working when a dot is inside the url.
Example:
url.com/users/timo.ruetten
This url will not rendered on server the DOM.
url.com/users/timo-ruetten will be rendered on server instead.
Is there any way to make sure that a url with a dot will also be rendered on server ?

I have fixed it now for me.
In server/route there is this method:
  _isHtmlPage(url) {
    const pathname = Url.parse(url).pathname;
    const ext = pathname.split('.').slice(1).join('.');

    // if there is no extention, yes that's a html page
    if (!ext) {
      return true;
    }

    // if this is htm or html, yes that's a html page
    if (/^htm/.test(ext)) {
      return true;
    }

    // if not we assume this is not as a html page
    // this doesn't do any harm. But no SSR
    return false;
  }

So everytime when its not .html or .html but with dot in url no SSR is given. This is very bad in my case. In my case I changed the code to check if its a typical file of my app like images and documents and if not returning true. In my case of app its important to render also urls with dots in it on SSR.
It would be nice to improve this method so its more easy to have control if a URL has to be rendered on Server.


bpf/Makefile: add target for analyzing files

The static analyzer might catch future issues.
Signed-off-by: Alexander Alemayhu<EMAIL_ADDRESS>

Not sure it's worth adding it to the tests. It might introduce false positives, but currently it's reporting this
a@alemayhu:~/opt/og/src/github.com/scanf/cilium/bpf$ make check
clang -Iinclude -D__NR_CPUS__=8 -O2 -target bpf -I. -Wall -Werror -Wno-address-of-packed-member -Wno-unknown-warning-option --analyze *.c
In file included from bpf_lxc.c:47:
./lib/conntrack.h:224:5: warning: Value stored to 'action' is never read
                                action = ACTION_CREATE;
                                ^        ~~~~~~~~~~~~~
./lib/conntrack.h:227:6: warning: Value stored to 'action' is never read
                                        action = ACTION_DELETE;
                                        ^        ~~~~~~~~~~~~~
./lib/conntrack.h:229:6: warning: Value stored to 'action' is never read
                                        action = ACTION_CLOSE;
                                        ^        ~~~~~~~~~~~~
./lib/conntrack.h:376:5: warning: Value stored to 'action' is never read
                                action = ACTION_CREATE;
                                ^        ~~~~~~~~~~~~~
./lib/conntrack.h:379:6: warning: Value stored to 'action' is never read
                                        action = ACTION_DELETE;
                                        ^        ~~~~~~~~~~~~~
./lib/conntrack.h:381:6: warning: Value stored to 'action' is never read
                                        action = ACTION_CLOSE;
                                        ^        ~~~~~~~~~~~~
bpf_lxc.c:259:3: warning: Value stored to 'ip6' is never read
                ip6 = data + ETH_HLEN;
                ^     ~~~~~~~~~~~~~~~
7 warnings generated.


fix: [jaspr_riverpod] vsyncOverride is missing a variable

Description
When trying to run the examples/flutter_embedding example, get the following error:
 ~/gadfly/temp/jaspr/examples/flutter_embedding/ [main*] jaspr serve
✓ [CLI] Starting jaspr in development mode... (5.3s)
[BUILDER] [ERROR] Error compiling dartdevc module:jaspr_riverpod|lib/jaspr_riverpod.ddc.js
[BUILDER] [ERROR]
[BUILDER] [ERROR] packages/jaspr_riverpod/src/framework.dart:317:5: Error: The getter 'vsyncOverride' isn't defined for the class '_UncontrolledProviderScopeElement'.
[BUILDER] [ERROR] - '_UncontrolledProviderScopeElement' is from 'package:jaspr_riverpod/src/framework.dart' ('packages/jaspr_riverpod/src/framework.dart').
[BUILDER] [ERROR] Try correcting the name to the name of an existing getter, or defining a getter or field named 'vsyncOverride'.
[BUILDER] [ERROR] vsyncOverride ??= _jasprVsync;
[BUILDER] [ERROR] ^^^^^^^^^^^^^
[BUILDER] [ERROR] packages/jaspr_riverpod/src/framework.dart:317:5: Error: The setter 'vsyncOverride' isn't defined for the class '_UncontrolledProviderScopeElement'.
[BUILDER] [ERROR] - '_UncontrolledProviderScopeElement' is from 'package:jaspr_riverpod/src/framework.dart' ('packages/jaspr_riverpod/src/framework.dart').
[BUILDER] [ERROR] Try correcting the name to the name of an existing setter, or defining a setter or field named 'vsyncOverride'.
[BUILDER] [ERROR] vsyncOverride ??= _jasprVsync;
[BUILDER] [ERROR] ^^^^^^^^^^^^^
[BUILDER] [ERROR] packages/jaspr_riverpod/src/framework.dart:373:9: Error: The getter 'vsyncOverride' isn't defined for the class '_UncontrolledProviderScopeElement'.
[BUILDER] [ERROR] - '_UncontrolledProviderScopeElement' is from 'package:jaspr_riverpod/src/framework.dart' ('packages/jaspr_riverpod/src/framework.dart').
[BUILDER] [ERROR] Try correcting the name to the name of an existing getter, or defining a getter or field named 'vsyncOverride'.
[BUILDER] [ERROR] if (vsyncOverride == _jasprVsync) {
[BUILDER] [ERROR] ^^^^^^^^^^^^^
[BUILDER] [ERROR] packages/jaspr_riverpod/src/framework.dart:374:7: Error: The setter 'vsyncOverride' isn't defined for the class '_UncontrolledProviderScopeElement'.
[BUILDER] [ERROR] - '_UncontrolledProviderScopeElement' is from 'package:jaspr_riverpod/src/framework.dart' ('packages/jaspr_riverpod/src/framework.dart').
[BUILDER] [ERROR] Try correcting the name to the name of an existing setter, or defining a setter or field named 'vsyncOverride'.
[BUILDER] [ERROR] vsyncOverride = null;

Steps To Reproduce

Clone jaspr repo (this Issue was made against the commit: 3495cfd0693fed99a34ffec0f9f0b8ac9bbfb18e)
cd examples/flutter_embedding
install dependencies
jaspr serve

Doctor Output
 ~/gadfly/temp/jaspr/examples/flutter_embedding/ [main*] jaspr doctor
[✓] Jaspr CLI (Version 0.9.3)
  • Dart Version 3.1.1 (stable) (Tue Sep 5 12:20:14 2023 +0000) on "macos_x64" at /Users/matthew/fvm/versions/3.13.3/bin/cache/dart-sdk/bin/dart
  • Running on macos Version 13.3.1 (a) (Build 22E772610a) - Locale en-US
  • Analytics: Enabled

[✓] Current Project
  • Dependencies on core packages:
    • jaspr: ^0.9.0
    • jaspr_builder: ^0.9.0 (dev)
    • jaspr_web_compilers: ^4.0.5 (dev)
    • jaspr_flutter_embed: ^0.1.4
    • jaspr_riverpod: ^0.3.6
  • Uses server-side rendering: true
  • Uses experimental compilers: true
  • Uses flutter embedding: true

Expected Behavior
For the flutter_embedding example to have been served to localhost:8080 without hitting an error.
Additional Context
I think this commit may have introduced the regression.

This actually comes from a change in riverpod, where vsyncOverride was removed in the latest version:
https://github.com/rrousselGit/riverpod/pull/3072

@schultek Thanks for finding the root cause! I updated #139 accordingly


Refine The Wiki

Hi. Could you pls refine the wiki of some peripheral mod?
The current SP wiki is not that clear and readable. Some results of the method are missing (like the radar ones).
Here are some wiki of other CC:T addons that might help :
https://docs.advanced-peripherals.de/peripherals/chat_box/
https://github.com/TechTastic/ValkyrienComputers/wiki
https://cccbridge.tweaked-programs.cc/peripherals/

I'll do it eventually...

Please explain how the ray casters direction settings work when the ray caster is pointed straight down because I need it for a giant spider I'm doing. (I'm using the ray caster to measure the distance from the end of each of the legs to the ground)

@Robro0-625 just test it yourself. experiment


Revert "add option to pass scwOnboardMode to eth_requestAccounts (#13…

…83)"
This reverts commit 5d54a0a49ce63d4b9fc4ec1bce9c349feee7a412.
Summary

How did you test your changes?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Stress test

To make sure that lol will not slow down or memory leak in long run, stress should be done.

I've added stress task in lol-perf which starts 4 nodes and performs 1MB commit repeatedly to the cluster in given time (I used 300 seconds). The ave. response time is calculated every seconds but slow down wasn't seen and memory bloat wasn't seen as well.


Community Events Resources - Page Rendering Issues

The https://main--shredit--stericycle.aem.live/en-us/secure-shredding-services/shredding-events/community-shred-events-resources page is not rendering properly. The PDFs also 404. Please fix links and page rendering.

Should look like: https://www.shredit.com/en-us/secure-shredding-services/shredding-events/community-shred-events-resources

@MarquiseRosier the PDFs on this page were resulting in 404 errors. I replaced the links but they are not connecting to the images (showing the link vs being a hyperlink), and the 3rd image is not rendering properly


Use of colour: highlight contrast (WCAG 2.2 Level A - Accessibility)

Background
The eQ service identified this issue within the ONS Design System following their DAC audit report (18/01/2024).
Issue
Colour was used as the sole means of identifying information or states.

The highlight applied to certain keywords within questions, such as ‘demonstration’ and ‘delivery mileage cars’ in the screenshot and below code reference does not contrast sufficiently with the white page background to meet WCAG AA. The yellow highlight colour could be difficult for some low vision users to see, meaning that these users may not understand the emphasis of this text in the same way as other users.
In this case, the background colour is relied upon as the only means of indicating the importance of this text.
Highlight: #F0F762
Background: #FFFFFF
Contrast ratio: 1.2:1
This issue applies throughout the service wherever this highlight colour has been used.
Suggested solution
Ensure that where colour is used to indicate information or importance, this colour change achieves a contrast ratio of at least 3:1. In this case, the highlight styling must achieve this contrast ratio against the white page background. The adjusted highlight colour should also retain a sufficient contrast ratio against the text, as per 1.4.3 Contrast (Minimum). We also
recommend providing an additional visual indicator to aid users in identifying highlighted text, such as an outline.
Tasks

Investigate whether the change can be made and any impacts
Decide the best solution
Implement the solution
Update eQ with progress

Info

eQ DAC reports/docs
Issue ID: DAC_Use_Of_Colour_01
DAC report pages: 48 to 49
WCAG Reference: 1.4.1 Use of Color (Level A):

Understanding Use of Color
How to Meet Use of Color

Actions before developers can implement:
@Majsol @JNATION85

[ ] Agree colour for highlighting.
[ ] Agree on (not) implementing outline.

@daniellecorke

[ ]  Double check screenreader comments.

Details
Highlight Colour:
This is easy enough to change, but there are decisions involved.
One thing to note is that it seems very difficult (might not be possible) to get a contrast level that will pass AAA standards for regular text, whilst maintaining 3:1 contrast between the highlight colour and the background white of the webpage.
As the original highlight was from the 'supporting palette' - my recommendation would be to replace it with another colour from that pallette  --ons-color-jaffa-orange: #fa6401; this has the required contrast between the background and highlight and passes AA for regular text and AAA for large text. This change would affect all highlighting, including links that have been clicked on and highlights in tables.
Outlining:
As far as I'm aware it would be very difficult to outline the highlighting in the case that it is used for words in the middle of a body of text. In this case, we could also recommend underlining the text? I wouldn't advise adding an underline to all highlighting uses, because it has different uses across the Design System and for some the underline wouldn't be appropriate.
Screenreader Comments:
This doesn't seem to be relevant to this ticket, as such I wanted to check if there's a relevant screenreader comment and that this comment is being addressed elsewhere?

@balibirchlee  Apologies - my mistake. There are no screen reader comments for this issue. I've removed that part.

Look into adding the underline in eQ and retest with DAC

Change made in eQ


Updated constraint name

Issue #, if available: N/A
Description of changes:
Updated constraint name from non_head_constraints to non_scope_constraints.

Were these JSON files broken by #302? Is there some test we should have in CI to catch this sooner?


updated ms windows svg named it microsoft

Hello,
I'd like to ask if there is any update on the status of this PR.
One minor comment: the suggested new logo is actually Windows logo, not MS logo.
MS logo looks like this (notice the different perspective from the Windows logo): https://en.wikipedia.org/wiki/Microsoft#/media/File:Microsoft_logo_(2012).svg

@vmuzikar sorry for the delay! Could you rebase from latest master and fix any issues and I'll review?


[5.5] [SILGen] Used formal type when bridging completion handler arguments.

Explanation: When calling ObjC methods from Swift as async methods, a completion handler to be passed to the ObjC method is synthesized by SILGen.  Being called from ObjC, that completion handler receives ObjC types such as ObjCBool and NSString.  On the other hand, the Swift code that is calling-as-async that ObjC method expects native types like Bool and String.  Consequently, part of the completion handler's implementation is to bridge those bridged values to native values.
The utility code for doing this bridging requires the formal type be passed in.  Previously, that foreign type was being retrieved from the lowered type.  For many things (e.g. ObjCBool and NSString), that worked fine.  However, for block types, it did not; the "formal" type that can be obtained from a SILFunctionType is still a SILFunctionType.  And the utility bridging code requires AnyFunctionTypes in order to work.
Here, the formal original native method type is passed down, bridged back to a formal ObjC type, and passed through to the bridging utility code.  Additionally, the abstraction pattern used for unsafe continuations is changed to a type reference from opaque, allowing block arguments not to have bound generic arguments or require an extra thunk.
Issue: rdar://79383990
Original PR: https://github.com/apple/swift/pull/38370
Testing: New regression tests, Swift CI
Reviewed by: @jckarter
Risk: Low.
Scope: Limited to Swift import of ObjC methods as async functions.

@swift-ci please test

@swift-ci please nominate

@swift-ci please test

@swift-ci please clean test windows platform

Build failed
Swift Test OS X Platform
Git Sha - bcab190c55959a338c16851e7e1c422fac334ed8

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 32a6cd248bad552691b4233ef50eaf4963591323

@swift-ci please test

@swift-ci please clean test windows platform


chore: migrate svelte to v5 release

This migrates both svelte templates to svelte v5 release. It might fix #215

@aklinker1 checks are passing now 😄


Adds API for retrieving type from Module or Struct

My use case is that I need to serialize the polymorphic embed and, once in the
front-end, need to distinguish them. I could reinvent the wheel and derive the
type there, but since this lib already does it for me... ;)

Thank you @jmnsf. Why did you create a new module (Polymorphic) to get the type?

@mathieuprog np. Yeah, I should have explained that, just spent a few minutes trying to figure out what I was thinking myself 😅.
So the general convention for use modules is to keep the injected code as minimal as possible. This means having most of the code in the "used" module, which is called from the "user". So the best thing (imo) would've been to do this:
defmodule PolymorphicEmbed do
  @callback get_polymorphic_type(module() | struct()) :: atom()

  @doc false
  def get_type(%module{}, meta_data),
    do: get_type(module, meta_data)

  def get_type(module, meta_data) when is_atom(module) do
    meta_data
    |> Enum.find(&(module == &1.module))
    |> Map.fetch!(:type)
    |> String.to_atom()
  end

  defmacro __using__(opts) do
    # ...

    @behaviour PolymorphicEmbed

    @doc "Returns the concrete type for a struct or module."
    @impl PolymorphicEmbed
    @spec get_polymorphic_type(module() | struct()) :: atom()
    def get_polymorphic_type(module_or_struct),
      do: PolymorphicEmbed.get_type(module_or_struct, @__meta_data)

    # ...
  end
end

(The behaviour itself is just a best practice so we get compiler warnings if we forget to implement something. Ecto.Type uses this too.)
So minimal code is injected into the "user" module and we get the same behavior. The thing is that PolymorphicEmbed happens to be the top module for this package, and adding a get_type function there, even with @doc false, feels wrong to me, so I pulled that into a different module.
GenServer does this though, so maybe it would be correct? Let me know what you'd rather go for and I'll make the changes:

How it is, PolymorphicSchema.get_polymorphic_type(struct) and separate behaviour module.
Same API but same module with @doc false get_type/2
Public PolymorphicEmbed.get_type(struct) that pulls the info from a get_polymorphic_metadata/0 callback in the Schema
Public PolymorphicEmbed.get_type(struct) that pulls the info from metadata via Module.__info__(:attributes)

Honestly not sure which would be the best option.

@jmnsf I did a refactor following your comments; your thoughts on this will be appreciated:)
This is the new code for PolymorphicEmbed:
https://github.com/mathieuprog/polymorphic_embed/blob/master/lib/polymorphic_embed.ex
(I wanted to make a PR for you to review but I messed up, ended up in master..)
The idea: instead of injecting all the functions (public and private), I inject a module CustomType to which I delegate the calls for the Ecto Type.
The advantage of this, is that it creates a nice API; especially interesting as we want to add public functions to it that are not Ecto-Type-related (in this case, get the type of the polymorphic embed).
First, what do you think about this new design?
Then, if you'd approve this, I'd let you add your changes based on this new code. If you rather want I do it, just let me know.
Note that there was already a public function get_module_from_type/1 that was accessed by the form helper.
We should rename it to get_polymorphic_type as you suggested in the PR.
Currently the get_module_from_type/1 function resides in CustomType. If we want to separate that function into its own module (because it is actually not used by any of the Custom Type functions - cast/dump/load/type), as you did in the PR, it's going to be slightly trickier as the module options (to build the metadata), is passed to CustomType. We should then extract that logic, and pass the metadata to both CustomType and the new module (which I would call something like TypeGetter, a more meaningful/explicit name than Polymorphic).
Something like:
use PolymorphicEmbed.CustomType, unquote(opts)
use PolymorphicEmbed.TypeGetter, unquote(opts)

But instead of opts, the computed metadata.
Another option is to just leave the function in CustomType.

@jmnsf @plasticine I created a new release that includes get_polymorphic_type/1.
@jmnsf if I could see some code showing the use of that function that'd be appreicated:)

@jmnsf @plasticine note that the API has changed since v0.9.0
To retrieve the type you have to write now:
PolymorphicEmbed.get_polymorphic_type(Reminder, :channel, SMS) # :sms

See example in docs.

Hey @mathieuprog, sorry for the delayed response. Thank you for all the changes! I see that it's quite different now from the initial design due to ParameterizedType, so not sure if I'm replying on time. But my use case is pretty straight-forward:
  defp serialize_flow_step(flow_step, own_attrs) do
    flow_step
    |> Map.take([:id, :next_step_id, :__type__ | own_attrs])
    |> Map.put(:run_if, serialize(flow_step.run_if))
    |> Map.put(:__type__, FlowStep.get_polymorphic_type(flow_step))
  end

I'm just serializing the type as JSON for the UI to know what it is.

Thank you, that was in case I want to add an example in the readme, as I mentioned your use case https://github.com/mathieuprog/polymorphic_embed#get-the-type-of-a-polymorphic-embed
By the way note that you should now cast with this library's function. Not related to parameterized type refactoring, but because of issue https://github.com/mathieuprog/polymorphic_embed/issues/10
The new code is way more simple as there are no more macros and code injection. Each function cast/load/dump receives the options as argument.
There's still another open PR of yours left. If associations is a blocking problem we can maybe already filter them out, but it'd be a temporary solution.

@mathieuprog yup, saw your comment! I'll try to pick that up in the next few days and adapt it to this solution (plus fix the issue you pointed out)
Thank you for the pointers 👍


custom.properties file instead of touching semux.properties

Background:
As of now, the semux.properties file must be modified to change some settings, like enabling API, changing port numbers, etc…
Issue:
It is quite annoying to update the node because of that, because one has to re-apply the changes on each Semux upgrade. It is not safe to overwrite the semux.properties file, because new version can provide some new properties or can change some defaults (like it was when upgrading my testnet validator from 1.3.x to 1.5.x).
Solution:
Introduce another file, e.g. custom.properties where users can create/overwrite values from semux.properties. On each new upgrade, one would just copy the custom.properties over to new location.
I can develop it, just need the green light.

Version 1.5 has EVM related properties, they are not present in 1.3.

They should all have reasonable defaults set.

I'm not sure I understand: ale the properties declared in the semux.properties have defaults hardcoded in the Semux node? That means I can wipe the file out, reduce it to 0 and everything should work fine?

There are a few properties that are required like p2p seed nodes, but all the new properties we are adding have defaults.  So yes, you should be able to delete most of the properties in the file and it'll continue to work
We only expect that on upgrade that old configs should still work without changes.  Check out the AbstractConfig class.  If we missed setting a default for VM feature that would be a bug

If that is the case, then I am closing this issue. From now on I will just overwrite semux.properties on upgrades.


Problems with nested component library link

What type of issue is this?
other
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[X] 💥 Google Chrome
[ ] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

SPFx version 1.11.0
Node.js version v10.24.1

Issue description
I have a component library (A) that has linked inside it another component library (B) that calls another component library (C).
If I go in gulp serve on the component library (B) there are no problems, I can correctly load the page and the component (C) is called correctly.

If I go to serve on the component (A), the component (C) is not retrieved correctly. From the serve I noticed that the path is wrong.

[SPLoaderError.loadComponentError]:
Failed to load component "bb4e5de1-5686-4157-b8ff-64d79b68fac3" (XXXXX). Original error: Failed to load component dependency "bb4e5de1-5686-4157-b8ff-64d79b68fac3" from component "XXXXXX" (Failed to load component "5f4e0468-a12a-4778-9a2f-71d4dd6b826e" (XXXXXX). Original error: Failed to load URL 'https://localhost:4321/node_modules/ew-auth-provider/node_modules/ew-log-listener/dist/dist/ew-log-listener-library.js' for resource 'ew-log-listener-library' in component '5f4e0468-a12a-4778-9a2f-71d4dd6b826e' (XXXXX). The file was not found in the server. Make sure that you are running 'gulp serve'.). Original error: {3}
Why does it look for the component in the path "dist/dist"?
What can be the problem? Do you have any suggestion?

Not sure if it is the same as my problem but I was getting that with other packages due to a bad webpack.js I had copied into my project when troubleshooting.  Removing the file fixed it for me.

So - does this problem only happen during gulp serve?  I'm guessing that you have a couple of SPFx libraries at play (the two components in your errors).  Are they in different packages?  If they are all installed into the app catalog, do things work correctly?


src, test: Adds a basic FindInputs action

This action heuristically detects inputs to tools and records them after the tool is run. The tool works much like the existing FindOutputs action.

LGTM, one small nit.


Retrieve countrly list from server

Get residence list from server instead.

Also fix merge conflict ;)

Coverage increased (+0.08%) to 31.732% when pulling 3638994c49f4ac9db815307e19b1eab96c3fe083 on nuruddeensalihu:nuru/fix_countryList into c8ee51a3e4f10f5eb676e0a499547eae0692ed5d on binary-com:master.


nameof revisions based on PR #2425

nameof revisions based on PR #2425
Moved nameof to the list of conceptual keywords and made some other changes.
Suggested Reviewers
@svick @timmi-on-rails @BillWagner

Should nameof also be added to operator-keywords.md, since it's listed as operator keyword in the TOC?

Yes, it should be, @svick. I've added it to this PR.


Add this Website!

URL: https://boffosocko.com/
Author's Twitter Handle: (optional) @ChrisAldrich
The fun feature I like most about this site is the vast collection of IndieWeb integrations.

while I love chris' indieweb stuff, I'm looking more for something like an easter egg or otherwise nonsensical feature.


docs: update static to isr

🔗 Linked issue
#20963
❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Update key in descriptions list of "Rendering Modes" documentation page to use isr and match code snippet.
Resolves #20963
📝 Checklist

[X] I have linked an issue or discussion.
[X] I have updated the documentation accordingly.

@danielroe's suggestions incorporated!

Thank you ❤

Is it correct to assume that isr/swr provides that same behaviour as static?
I'm having trouble understanding the variety of options. The re-rendering sounds very appealing but the reason for going for Static Site Generation mode is the highest performance. Which seems to be lost when using swr/isr.


Move documentation to JSDoc

There's no JSDoc to speak of in the current state of the library. Longer-term, it would be good to move to a process that auto-generates documentation based on JSDoc (to match what we're planning for other libraries), so moving over the current documentation captured in the README to JSDoc would be a first step.
CC: @gauntface

Will get on this ASAP.
On Thu, 25 Aug 2016, 23:24 Addy Osmani<EMAIL_ADDRESS>wrote:

Assigned #155 https://github.com/GoogleChrome/sw-precache/issues/155 to
@gauntface https://github.com/gauntface.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/sw-precache/issues/155#event-768480146,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIh8GB0CUofZigYmaPsJ-l_dUJF0NtWks5qjoaigaJpZM4JqBt5
.

Oh, I wasn't saying that you had to do it, @gauntface. I was just CC:ing you as a heads-up.


lineWrapping: cursor should skip last whitespace when moving right + incorrect char width

Refer to this example, v 5.27.4
For textarea inputStyle, when a line wraps on whitespace, and you move cursor from the last word-character on line 0 right, it should move the cursor to line 1. CM currently advances cursor after the whitespace (last character on line 0).
This results in inconsistent and unexpected behavior (all text editors wrap the cursor to the next line as described above). You can see the standard behavior when you switch to contenteditable inputStyle in that example.
Inconsistency arises when you move the cursor (refer to the example) manually via keyboard/command right which moves it after the whitespace still on line 0, while if you move the cursor programmatically (cm.setCursor{ line: 0, ch: 40 }), it correctly puts the cursor at the start of line 1.
From this incorrect behavior arises related bug which we'd not have to solve otherwise: the last whitespace has variable width depending on the editor size, and may end up just 1px wide:

Moving left from line 1 to 0 does not exhibit this behavior.

And now it becomes obvious why goLineLeft doesn't work correctly (https://github.com/codemirror/CodeMirror/issues/4840) when (visually) at the end of line 0, because the charCoords() checks char 40 which is at line 1 (but the cursorCoords() checks cursor which is at line 0).

Solution seems simple: Set position's sticky: "after" when moving horizontally (unless there's something that'll break due to this change, but I think it shouldn't).
You can check a proposed fix here - it also contains changes to goLineRight to make the behavior consistent, and also fixes related issue: https://github.com/codemirror/CodeMirror/issues/4840

Simply setting sticky to "after" is not the solution -- it's set to "before" for a reason, namely that in principle, the cursor should stick to the character it just moved across when moving right. When there's no whitespace around the line-wrapping point, it should appear at the end of the current line before moving to the next line.
@adrianheine Do you think it would be safe to set the stickiness to "after" in moveLogically/moveVisually whenever a whitespace character was skipped?

When there's no whitespace around the line-wrapping point, it should appear at the end of the current line before moving to the next line.

Not necessarily. E.g. Atom, Brackets, or notepad++ doesn't do that -- they don't allow you to move the cursor after the last character on a wrapped line if there's no space after it, and instead move it to next line:

Sublime text does allow that, but to counterbalance it, it doesn't allow that from the left-to-right movement on the next line.
So, we should decide on a behavior (I'd go with the one used in most editors, i.e. the first one), and stick to it.
Problem with current behavior is that it's not consistent. It allows both behaviors which is not consistent and thus results in incorrect behavior (as demonstrated e.g. when setting cursor programmatically).

I'm facing a similar issue and wondering if there's a config option to allow CodeMirror to leave the cursor movement up to the browser?

@Niharika29 no... there are 2 different inputStyles (contenteditable & textarea, one used on mobile and the other on desktop, simply put) and if we let browsers do their own thing on each (which is not possibly anyway, at least for textarea inputStyle, due to how CM works), we would end up with potentially wildly inconsistent behavior (WTBS, currently there still are inconsistencies stemming up from some of the parts of contenteditable behavior being left up to the browser).
In any case, even native behavior varies across browsers. If you try this fiddle, chrome handles cursor movement "correctly", while FF has the same inconsistent behavior as CM currently does. So deferring to native browser behavior wouldn't solve this problem.
I'm gonna issue a PR addressing this, but we need to settle on a solution (there are 2 ways to do this, both correct). Also it'll be a breaking change not to take lightly (unless we put it under an option, but that could complicate the codebase considerably, and I think CM should handle cursor movement correctly by default).


[BUG] Maybe give slightly more vertical space for charts

Describe the bug
Just barely not enough s.t. we weed to click for the x axis.
To Reproduce
URL: https://browser.datacommons.org/browser/dc/p/zyl5s3qrrmeq3
Screenshots
If applicable, add screenshots to help explain your problem.

Closing this with the new browser UI launched.


Why only stdio mode is returned, not other backend modes?

https://github.com/SeaQL/sea-streamer/blob/34e96914761bb6cf1ccde68d4aaa1fe0758ae246/sea-streamer-socket/src/consumer_options.rs#L120
    fn mode(&self) -> SeaResult<&ConsumerMode> {
        self.stdio.mode().map_err(map_err)
    }

    /// Get currently set consumer group; may return `StreamErr::ConsumerGroupNotSet`.
    fn consumer_group(&self) -> SeaResult<&ConsumerGroup> {
        self.stdio.consumer_group().map_err(map_err)
    }

the stdio is just used a standin, it's mode is actually applied to other backends IIRC

ah okay, so the mode config is set to all backends, including stdio, so returning only stdio here is not wrong. the problem though, is we can't compile without the stdio backend. it does not fetch many more dependencies, but still may we should make it possible to compile without the stdio backend.


V0.5.0 - add secondary log support

Cherry-pick out the commits that were being used in the add_secondary_log_support branch. This specific branch is used within https://github.com/mavenlink/mobile repo. In order to bump the version of Rails there, we need be on a higher version of act-fluent-logger-rails.

What's the plan on QAing this?

@juanca Similar to upgrading the gem on Big Maven, we can verify that the logs are being generated with the right parameters in Datadog

If we are adding this just for the sake of pushing data to datadog then we could be using a datadog plugin -- or possible a plugin that pushes data to an arbitrary app. I dunno, kinda seems better than dealing with our forked gem in the long-run.

@a-bates I think this PR might have been superseded by some of the recent work on the logging integration refactor... if I understand the refactor, it should be easier for us to tack on extra logging modules in a better design pattern than building this dual-logging functionality into this gem.
Please let me know what you think

@diclophis This was pretty long ago, so I'm not 100% sure, but I believe that this was an update done strictly for bumping the rails version on mobile. Looking through it now, it doesn't look like its relevant anymore, so I think we can go ahead and close this one out.

Thanks @a-bates closing this out now


Allow affinity to be set for the instance group pods

Is your feature request related to a problem? Please describe.
Not necessarily, but it can become a problem on some production systems that want to direct the pods to specific affinity.
Setting the affinity also helps the k8s scheduler to do a better job.
Describe the solution you'd like
Have a clear way to pass the pod affinity to the instance group pods.
Describe alternatives you've considered
Additional context
If the cf-operator doesn't yet support this, it must be implemented there first.

@f0rmiga I would say that this is a pure cf-operator implementation. Am I wrong?

Well, there's a cf-operator side of it, but we need to expose the API to set it on KubeCF.

Some connection to https://github.com/cloudfoundry-incubator/kubecf/issues/254 regarding affinity, which has a higher priority now based on production environment observations.


fix(packages/explorer/src/utils.js): Fixed precision in formatting

What does this pull request do? Explain your changes. (required)

Fixed precision in formatting to make it default to the length of number passed to the function.
How did you test each of these updates (required)

Does this pull request close any open issues?

re 211
Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

It would probably be easier to apply this by changing the default value. @yondonfu what do you think?

Seems reasonable (unless there is some UI reason for limiting the # of decimals)

There are some UI effects I saw when I changed the default value for decimals, but I have a fix for that.


fix: consider existing frames when waiting for a frame

Thanks for taking a look! The idea of using utils.attachFrame for testing this looks good to me. Updating the PR.


Use upcoming Windows Terminal font as default

A while ago, at Build 2019 Microsoft mentioned that they are going to release a new open source monospaced font with programming ligatures for new Windows Terminal.
It would be great if, after the font is released, it will be used by default in VS Code instead of Consolas.
Blog post about new Windows Terminal

We might do this, we can evaluate once it's a thing


[BUG] RetrieveTable appears stuck during initializing

it should show a loading spinner which is actually already in the JS & HTML code but somehow that's never visible.
assuming a bug here.

fixed by commit 517e778


Doesn't work on Windows 11

Opening Internet Explorer just opens Microsoft Edge, and LegacyUpdate doesn't work on modern browsers.

I mean, while you're right, I don't get why you'd want to.  The whole point of Legacy Update is to update legacy products, just use the regular Windows Update on 11?

Opening Internet Explorer just opens Microsoft Edge, and LegacyUpdate doesn't work on modern browsers.

Pretty sure you can use Internet Explorer Mode within Microsoft Edge

Ok, @PeterStrick.


Test

Any future plan to add test? Maybe use something like https://github.com/json-schema/JSON-Schema-Test-Suite ? Thanks.

Yes. See #18.


Image for validation test "GLTF ext MSFT_LOD" not ok

This validation test ("GLTF ext MSFT_LOD") does not fail because there's not enough differences for the error to kick in, but we can clearly see in the picture that the current rendering does not match the test picture:

Maybe the current rendering is ok and the test picture should be updated, or maybe the rendering is wrong. I don't know so I let you guys see what's going on.

@bghgary changed the MSFT_LOD recently so I guess it is an image issue ?

@Popov72, thanks a ton for reporting it !!!

I removed the MSFT_lod as rendering LOD support because it wasn't complete and caused some issues. This test is trying to test that. I will remove the test.

PR in question: https://github.com/BabylonJS/Babylon.js/pull/11840