Helicopter mixer scale throttle to -1 .. +1

Not sure why it worked for me without this change. I cannot test it myself. Should fix https://github.com/PX4/Firmware/issues/8013

@dagar Can you review this change?

The interesting thing about the current implementation is that once the helicopter mixer runs there is no way I could use the throttle mixer in another channel.
For example as a work around I wanted to use another throttle (plain) mixer at ch6.
M: 1
O: 10000 10000 0 -10000 10000
S: 0 3 0 20000 -10000 -10000 10000
and the servo at ch6 did not move, once I had the helicopter mixer running.

Thanks @LorenzMeier We will try it in the coming days.

@bartslinger @LorenzMeier Works perfect! Thanks

Hi @tubeme, just wondering, was your motor ESC connected to channel 1 or channel 6? I have a problem to make the motor work.
I was trying to separate the collective control with the motor speed. Do you have any idea how can I achieve that?
Thanks.

Hi @JL-1994 We have no ESC but servo for the throttle. We are setting up IC engine heli.
The throttle is connected to CH1 with the Blade130 mixer we are using.
And the Throttle and Swash Plate can be scaled totally separated. So you could achieve what you need with the just tweaking the mixer.
With the Helicopter mixer there is no way you could use other channel for throttle, like your example at CH6. We tried this workaround first. It did not work.

Thanks for the info @tubeme. I've still got some question:

So the IC engine heli will spin the motor at constant rpm without the control of the PX4?

May I know how does the servo for the throttle of your heli works? Spinning the main motor?

I've tried connecting the CH1 to an ESC but the motor doesn't spin. Is it a bug or does the channel only will make a throttle servo work, not an ESC? Any advice? @bartslinger

@JL-1994 Here are some answers.
1+2. THe IC engine heli works exactly like the real helicopter. You don't have a constant throttle! You have an IC engine throttle (servo connected to the air intake valve of the IC like in a real car). The IC engines (and the Jet ones in the real helicopter) are with a very slow response so in order to control with precision they introduced the swash plate with which we change the angle of attack of the blade (and roll+pitch movement). Both the throttle and the angle of attack of the blade are in sync, each with a different scaling. You can control this with the blade130 mixer.
The same holds for the electric heli's. The only difference is that you give the PWM commands not to a servo but to an ESC.

Check the ESC and motor, is it working? make ESC calibration (outside the pixhawk, classic way) and see if it spins the motor properly outside the Pixhawk setup.

Do you hear the ESC arming once you connect the battery? Or do you hear beeps from the ESC all the time until you arm?
@bartslinger actually wrote this mixer using and electric heli with ESC connected to CH1.

Thanks for the explanation~ You are right, my ESC wasn't working and I realise I didn't change to the debugged code. Finally it's working now! Thank you so much!


Feature request: Add historical data to audit report

Partners have mentioned this as a request in several meetings now, and on at least one occasion a user described it as their number 1 priority:
The audit report only includes the current information for the various data types (projects, subrecipients, awards, expenditures). But for some of those fields, the historical data is still relevant and important to help with auditing and validation.
This was flagged primarily about monetary amount fields. In particular, in our workbooks we collect and for each project. But when we output that data to the bulk upload csvs those fields are actually given a new label in each quarter (e.g. Q4_2022_Obligations__c or Q4_2022_Expenditures__c). This historical data is important because the treasury keeps a record of the historical quarterly Obligations/Expenditures for each project, and will use those values to validate future values (a cumulative number can't be reduced in the future).
Adding the old quarterly values to the audit report would help partners detect errors sooner in their process.
Note: We should check with partner's if there are other field names that they would like to see historical data for, or if the quarterly Obligations and Expenditure numbers are enough.

Re: 2/5 convo with Joe - this has been completed


⚠ Fortnite has degraded performance

In c70ea76, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1572 ms

Resolved: Fortnite performance has improved in f4f1097.


Unique identifiers for files and directories

We have CIDs and other unique identifiers in WNFS that point to the following things:

Public content
Public file header (wrapper around content + metadata)
Private encrypted content
Private encrypted file header (wrapper around content + metadata)

It should be made clear to users that de-duplication is achieved automatically with WNFS when using the public file system. The private file system does not have that because each file is encrypted with a different key. https://talk.fission.codes/t/does-wnfs-deduplicate-content/4067
Questions to answer and problems to solve:

[ ] How do I get a unique name for my file or directory? Should fs.write() by default not overwrite a file?
[ ] How do I point to an exact version of a file or directory? How does this differ between the public and private side?
[ ] How do I make private content public and vice versa? What happens with the unique identifiers?
[ ] What does Webnative recommend to identify/link a file from another file? Example, a picture associated with a blog post.

The internal data structures should not be exposed. Instead, the interface should be easy to learn and be as helpful as possible to help people build various kinds of apps.

These are good questions! Some quick thoughts below (with my usual disclaimer that I'm just exploring ideas here, not imposing what should happen with my CTO powers 😛)

Should fs.write() by default not overwrite a file?

Bash overwrites by default. The macOS Finder prompt the user if they want to overwrite or use a unique name.

What happens with the unique identifiers?

If I'm understanding correctly, the unique content ID is intentionally lost when moving to the encrypted side. If it's later moved back to public, then it would have the same CID again.

What does Webnative recommend to identify/link a file from another file? Example, a picture associated with a blog post.

I had assumed that this would live in the metadata header, but would love to know if others have thoughts!

because WNFS is concurrent, you also have the option of making it a concurrent/conflicting write.

Good point. I'm starting to think we should not overwrite by default and be explicit, as we're leaning towards explicitness a bit more now in other areas of Webnative.

I had assumed that this would live in the metadata header

With the new rs-wnfs file system I think that's the way to go yeah. That said, couldn't hurt to think about some other patterns, as I'm sure there will be quite a few apps that have their own format (maybe they don't want to conform to one system, legacy reasons, etc)

I'm starting to think we should not overwrite by default and be explicit, as we're leaning towards explicitness a bit more now in other areas of Webnative.

To make this explicit, we would add an option to fs.write?
What happens when an overwrite is attempted but not permitted? Webnative throws an exception?

Bash overwrites by default. The macOS Finder prompt the user if they want to overwrite or use a unique name.

It might be useful to consider interactive vs non-interactive interfaces. The macOS Finder prompt has a user present to determine what to do. Bash might not.
Webnative is non-interactive. Are there other purely non-interactive systems that we could look at to see how they handle this?

Another consideration is whether overwrites are destructive or not. In our current implementation, we have the file.history API, which means overwrites aren't destructive. More of an append.
As a wild idea/alternative to making overwrites explicit, how about if fs.write returned an identifier for the previous version of the file? Or the file.history.list function for the file. It would keep the syntax of fs.write simpler and make it more convenient to reach back for previous versions of the file.

Addressed in #500 (see PR description)
Part of #501

How do I get a unique name for my file or directory? Should fs.write() by default not overwrite a file?

Mutations return a CID that can be used for a unique name or just use a UUID.
We've added fs.create() that adds suffix to the name if the file or directory already exists.

How do I point to an exact version of a file or directory? How does this differ between the public and private side?

A capsuleCID and contentCID are returned from a public mutation, which can be used with the read method. For the private side you get capsuleRef, which can also be used with read. You can also get these unique identifiers with their respective methods on the file system (ie. contentCID, etc).

How do I make private content public and vice versa? What happens with the unique identifiers?

You can now use the move method to move a file or directory from public to private and vice versa. Unique identifiers depend on the destination partition.

What does Webnative recommend to identify/link a file from another file? Example, a picture associated with a blog post.

Use paths or the unique identifiers.


Add LGSL code for the Care Act 2014

So we can create a local transaction for this service.
Zendesk: https://govuk.zendesk.com/agent/tickets/921650

:+1:


Inotify instances reached or too many open files

The following error occurs when baremaps is looking for changes in files.
app_1  | [ERROR] 2022-01-16 12:37:53.521 [Thread-3277] EditorResources - User limit of inotify instances reached or too many open files
app_1  | [ERROR] 2022-01-16 12:37:53.521 [Thread-3276] EditorResources - User limit of inotify instances reached or too many open files
app_1  | [ERROR] 2022-01-16 12:37:53.524 [Thread-3278] EditorResources - User limit of inotify instances reached or too many open files
app_1  | [ERROR] 2022-01-16 12:37:53.525 [Thread-3279] EditorResources - User limit of inotify instances reached or too many open files
app_1  | [ERROR] 2022-01-16 12:37:53.561 [Thread-3280] EditorResources - User limit of inotify instances reached or too many open files
app_1  | [ERROR] 2022-01-16 12:37:53.564 [Thread-3281] EditorResources - User limit of inotify instances reached or too many open files
app_1  | [ERROR] 2022-01-16 12:37:53.721 [Thread-3283] EditorResources - User limit of inotify instances reached or too many open files

The service lacked the stateless annotation and new file watchers were created for each requests resulting in this error. #414 contains a fix for this issue.


Value was missing for variable tag: kotlinVersion

flutter create -t module flutter_module
exception
TemplateException: Value was missing for variable tag: kotlinVersion. (4:27)
ext.kotlin_version = '{{kotlinVersion}}'
^

Closing this in favor of https://github.com/flutter/flutter/issues/118298


feat: 增加系统table搜索栏显示隐藏控制

General

✏ Mark the necessary items without changing the structure of the PR template.

[ ] Pull request template structure not broken

Type

ℹ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

ℹ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

[x] My code follows the style guidelines of this project
[ ] Is the code format correct
[ ] Is the git submission information standard?
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

增加系统table搜索栏显示隐藏控制

增加系统table搜索栏显示隐藏控制


i.MX RT10XX: Add PWM support

Add PWM driver for RT10xx MCUs

Codecov Report

Merging #14047 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #14047   +/-   ##
=======================================
  Coverage   52.23%   52.23%
=======================================
  Files         307      307
  Lines       45469    45469
  Branches    10526    10526
=======================================
  Hits        23753    23753
  Misses      16914    16914
  Partials     4802     4802

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8642be0...ca92fd8. Read the comment docs.

Please enable pwm samples and tests too.

Would still like to see this

Done, at least form rt1064 for now

rebased

@MaureenHelm , could you please review?

Please enable pwm samples and tests too.

Would still like to see this

Done, at least form rt1064 for now

It doesn't work:
***** Booting Zephyr OS build v1.14.0-rc3-2405-ga061dbda9cc8 *****
PWM demo app-blink LED
pwm pin set fails
[00:00:00.008,000] <err> pwm_mcux: Too long period (1171875), adjust pwm prescaler!

Will you please fix?

Will you please fix?

@MaureenHelm , well PWM source clock is 150MHz and maximum pwm clock prescaler is 128, which give a minimal clock of 1171875 Hz for the PWM. With the 16-bit resolution we can then have a maximum period of 0.05 second (2^16/1171875 = 0.05) whereas sample requests up to 1 second period. I can propbably modify the sample or at least customize for mimx board. what do you think?

@MaureenHelm , fixed now

hi @MaureenHelm , could you please review again?


When running in Octane, TwilAppSettings does not see groups

Description
When running my application under Octane (RoadRunner), I get the following error:

The settings group 'site' does not exist

This group corresponds to what I have configured.
The error is thrown from multiple places, including middleware (where I check to see if the site is in a published state) and in views (where I get the default site title, description, and other SEO stuff).
What's interesting, is that if I sign into the admin panel, my modules don't show up at the top, but the activity log populates perfectly fine. (Notably, I am able to sign into my CMS account.)
However, if I revert to a valet/nginx-backed setup, everything works as you'd expect.
This tells me something is wrong in relation to Octane. I cannot tell if it's simply a database manager issue, or perhaps something is loading up as a singleton before it should (not sure if that is even a thing).
Any ideas?
Versions
Twill version: 3.0.2
Laravel version: 10.13.1
PHP version: 8.1.x
Database engine: Postgres 14

Just checked in middleware (before the call to TwillAppSettings) what the database manager connection details are, using DB::connection()->getConfig(), and they are correct. I've cleared cache, views, and routes as well.

Hi @mikerockett,
Thanks for reporting this. We previously addressed issues to make sure Twill works with Octane, but this new feature from Twill 3 may have introduced a regression.
In traditional PHP, each request is a fresh PHP process and any static properties or static variables are reset between requests. With Octane, if you modify a static property or variable in one request, that modification will still be present for the next request.
This should be straightforward to fix. You may actually be able to address the problem in your own code. I'll give this a try asap if you don't come back with a solution.

Hi @ifox – thanks for the quick reply. :)
Could this potential regression on one class cause others to break? As noted, my modules don’t appear in the admin panel either.
Also, not sure where static properties come into the mix as the app settings class is bound to the container, and I would assume that the resolvable instance would refresh between requests as it is not a singleton.

I played around a bit, and I can get things to work when I use a scoped binding on the container, via the register method of the app service provider:
$this->app->scoped(TwillAppSettings::class, fn () => new TwillAppSettings);
$this->app->scoped(TwillNavigation::class, fn () => new TwillNavigation);

Then, I can inject these anywhere, or resolve via the facades, and they resolve as I'd expect them to.

New problem:
With the above “patch” in play, renderBlocks() now has an issue.

Call to a member function newInstance() on null

It works the first time I load the page, but the next load causes it to fail here in vendor/area17/twill/src/Helpers/BlockRenderer.php:260.
$class = Block::findFirstWithType($block->type)->newInstance();

For now, I'm just going to revert my patch-work and run without Octane 😅

I managed to get it working by creating a singleton for each of the concrete classes exposed by a Twill facade. And there I thought facades were singletons by default. Octane doesn't treat them like that, by the looks of it.

Hi, could i ask u what did u do with the trouble BlockRenderer.php:260 ?
i tried to create singleton for  Block, but it doesnt work.

@adss332 I did it like this:

Method (called in boot) to override bindings; `AppServiceProvider.php`
private function overrideTwillBindings(): void
{
  $this->app->singleton(
    Twill\TwillAppSettings::class,
    static fn () => new Twill\TwillAppSettings()
  );

  $this->app->singleton(
    Twill\TwillNavigation::class,
    static fn () => new Twill\TwillNavigation()
  );

  $this->app->singleton(
    Twill\TwillBlocks::class,
    static fn () => new Twill\TwillBlocks()
  );

  $this->app->singleton(
    Twill\TwillCapsules::class,
    static fn () => new Twill\TwillCapsules()
  );

  $this->app->singleton(
    Twill\TwillConfig::class,
    static fn () => new Twill\TwillConfig()
  );

  $this->app->singleton(
    Twill\TwillPermissions::class,
    static fn () => new Twill\TwillPermissions()
  );

  $this->app->singleton(
    Twill\TwillRoutes::class,
    static fn () => new Twill\TwillRoutes()
  );

  $this->app->singleton(
    Twill\TwillUtil::class,
    static fn () => new Twill\TwillUtil()
  );
}

Thank u very much!

Have to say using Laravel 11 with Octane, impact of this issue is getting much higher, making panel absolutely unusable.
We got it working by moving previously mentioned overrides from AppServiceProvider to withSingletons method of bootstrap/app.php file, otherwise in modules with lots of blocks 60 secs wasn't enough to render the page.
It worked well, but we mentioned irrelevant including of CMS users navigation link into other, not related to settings, sections, and, by each new request, it was getting duplicated that mush, so we couldn't see any other section links.
Got it fixed by recreating UserController inside App\Http\Controllers\Twill namespace without calling TwillPermissions::showUserSecondaryNavigation() in the __construct method and manually registering TwillRoutes::module('users', ['except' => ['sort', 'feature']]); inside routes/twill.php.
Refs: UserController.php#L97, RoleController.php#L48, GroupController.php#L46


Parallelise git data extraction

The extraction of git data is pretty slow on big repository, such as kubernetes.
We might speed things up parallelising some of the work done in this area.

Made irrelevant by https://github.com/elhmn/waking-git/pull/43#issue-1533929882


implement video clipping

I.e. I want 10s - 20s, 25s - 28s etc. and save all separately

this should be easy with yt_dlp now, just pass the correct argument


Is it possible to log by fields anh send logs to elasticsearch?

Hi,
I'm doing a project about log analysis using ELK Stack, I met problem that sending log from nodejs to elasticsearch, and I found pino-elasticsarch. However, I wonder that it is possible to use logger by filed (like status code, method, URL,...).
Thanks for any helps

maybe @delvedor can help

@lioaslan it’s not entirely clear to me what you are trying to achieve.
Can you add an example?

I'm building server for a website use hapi and hapi-pino for logging.
I want to analyze log (about status code, route, timestamp) for some personal purpose. I use elasticsearch and kibana to do it
Between hapi-pino and Elasticsearch, I try to use pino-elasticsearch to send log. However, it not worked, elasticsearch don't get anything
This is my code for registering hapi-pino:

const streamToElastic = PinoElasticsearch({
                index: 'offshorevn-api',
                type: 'log',
                consistency: 'one',
                node: 'http://elastic:changeme@localhost:9200',
                'es-version': 6,
                'bulk-size': 200,
                ecs: true
            });

            await server.register({
                plugin: HapiPino,
                options: {
                    logPayload: true,
                    prettyPrint: process.env.NODE_ENV !== 'production',
                    redact: {
                        paths: ['req.headers', 'payload.user.password', 'payload.file'],
                        remove: true
                    },
                    stream: streamToElastic
                }
            });

Maybe that's stupid, Elasticsearch still get log but it don't log anything about that.


ERR_MODULE_NOT_FOUND on React/NextJs

Getting the below error for "creatUserWithPasskey" on build. Works fine locally on dev mode.

Might have to do with package changes.


Can not fold comments

re #46597

open /extensions/typescript-language-features/src/features/organizeImports.ts
try to fold the block comment on line 64
🐛 cannot fold the block comment

Duplicate of https://github.com/Microsoft/TypeScript/issues/22732


feat: EnvoyPatchPolicy Status

compute the Accepted condition in the gateway-api layer

compute the Programmed condition in the xds-translator layer

Enhance Xds IR to hold the EnvoyPatchPolicy status

Publish the EnvoyPatchPolicy status from the xds-translator layer

provider subscribes to the status and writes it into the API server

Relates to #24

hey @Xunzhuo gen-check keeps failing because make testdata is unable to set the LastTransitionTime to null, any idea what is required to get this to work ?


fixed schedules, keys, updated vuetify

Codecov Report

Merging #71 into 2019.2 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           2019.2      #71   +/-   ##
=======================================
  Coverage   94.28%   94.28%
=======================================
  Files          15       15
  Lines         875      875
=======================================
  Hits          825      825
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a514536...903043b. Read the comment docs.


hobby

why can't i find the plug in on hoobs?

No clue; I neither use nor endorse hoobs.  Better ask hoobs support.


A number of improvements to the grid handling

Two interpolation tests in ntv2/mod.rs (succesfully validated against ESRI's ntv2_cvt program)
Improve check for NTv2 file header sanity
Improve readability and correct vector capacity in ntv2 parse_subgrid_grid()
Reduce visibility of SubGridHeader
Clean up the use block in ntv2 subgrid.rs
In the inverse case, don't iterate in reverse order over the grid collection in deformation & gridshift operators (we still want to hit the same grid as in the forward case)

@Rennzie does this look OK to you?

🤩 Looks great @busstoptaktik !

I'm curious to know if the precision is about what you'd expect given the off by half differences you'd noticed between the PROJ interpolation that of RG?

@Rennzie no, these differences are probably too large, and I'm staring myself to blindness today, checking interpolation code between ESRI's ntv2_cvt, PROJ's hgridshift and Rust Geodesy's gridshift.
PROJ and ESRI agree on the tenth to hundredth of a millimeter, while RG is sightly off, only agreeing with the other two on the millimeter level.
I have even reimplemented ESRI's code in RG, with next to no difference, so I assume the problem is in the calculation of the cell relative coordinates.
I'm looking into it, but it is a nasty problem, not the least because the grid is only single precision, so where and when you convert to f64 in the process will also make a difference.
My comparison routine is this:
$ echo 2.1686 41.3874 0 0 | cct -d 5 proj=pipeline step proj=hgridshift grids=./path/to/100800401.gsb step proj=utm zone=31 --

><PHONE_NUMBER>8  4581973.06191

$ ntv2_cvt -f .\path\to\100800401.gsb  41.3874 2.1686 | proj -f %9.5f +proj=utm +zone=31

><PHONE_NUMBER>8    4581973.06190

$ echo  41.3874 2.1686 | cargo run -- "geo:in | gridshift grids=100800401.gsb | utm zone=31"

><PHONE_NUMBER>2 4581973.06152

In summary:
PROJ:<PHONE_NUMBER>8  4581973.06191
ESRI:<PHONE_NUMBER>8  4581973.06190
RG:<PHONE_NUMBER>2  4581973.06152

Thanks for looking into it. Please let me know if I can help in any way.


Configure multiple interfaces

The SETUPINTERFACE command parses the json for a single interface and configures it. It would be nice to have a command (setupmultiinterface/setupinterfaces?) to configure multiple interfaces or modify the existing command to support multiple interfaces. Helps reduce the round trips in case of multiple interfaces. I see that the SETUPROUTE command, currently supports multiple routes.

@gao-feng What do you think of this? I can take this up if we agree how this should be handled?

@amshinde I'm ok with this, it's great if you can change runv to satisfy this modification. ;)


The Banner Plugin isn't Working in Either PC or Phone

Same here

same

me too, didn't work now

Also happened to me today when I disabled and tried to re-enable.
Try this: https://github.com/jparkerweb/pixel-banner
I just installed it and seems to be a great replacement. It inherits the syntax from banners, repo is current and it has way more features.
Don't think the devs will fix this issue anytime soon.

Also happened to me today when I disabled and tried to re-enable.
Try this: https://github.com/jparkerweb/pixel-banner
I just installed it and seems to be a great replacement. It inherits the syntax from banners, repo is current and it has way more features.
Don't think the devs will fix this issue anytime soon.

wow, really grateful!!

@rossoj85 Many thanks, finally an alternative !

Thanks for mentioning 🚩 Pixel Banner!
I built it for my own use and not necessarily a "banners" replacement, but I am glad others are finding it useful 😀
https://obsidian.md/plugins?search=Pixel Banner


DOC: document constructors of scipy.signal.lti

The documentation of scipy.signal.lti leaves quite a bit of ambiguity.
http://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.lti.html
(numerator, denominator) -- should say that the numerator and denominator are each arrays of polynomial coefficients, from lowest to highest degree (or is it the other way around), e.g. [2.4, 0.5, 1.1] represents 2.4 + 0.5x + 1.1x^2.
Probably good to refer to http://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.tf2zpk.html#scipy.signal.tf2zpk since this has a detailed explanation.
(zeros, poles, gain) -- how do you enter pairs of complex zeros and poles?
(A,B,C,D) -- have some text that refers to a state-space representation and explains what format is necessary

http://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.lti.freqresp.html#scipy.signal.lti.freqresp
"See scipy.signal.freqresp for details." -- if you're going to say "See X for details" please include a hyperlink to X.

this was addressed in gh-3954


Fix: fix workflowstep depends-on-app

Description of your changes

Fixes #
I have:

[ ] Read and followed KubeVela's contribution process.
[ ] Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
[ ] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

can you describe the bug?


Fix: Typos in Upgrade texts

Synced all upgrade text with FFG's app.

Need to fix the cases where it puts the flavor text as the card ability.


-fskip-empty-tasks 0 breaks simulation

Repro: Run https://github.com/hturki/barnes-hut/blob/37e410541cc6e5815505978063d25253501a9075/barnes_hut.rg with "-i <path/to> bodies-32768.csv -fskip-empty-tasks 0"
bodies-32768.csv.zip
Without the "-fskip-empty-tasks 0" task things run fine. With it, you get:
terra: /home/users/hturki/legion/runtime/realm/deppart/partitions.cc:149: Realm::Event Realm::IndexSpace<N, T>::create_equal_subspaces(size_t, size_t, std::vector<Realm::IndexSpace<N, T> >&, const Realm::ProfilingRequestSet&, Realm::Event) const [with int N = 1; T = long long int; size_t = long unsigned int]: Assertion `0' failed.
https://github.com/StanfordLegion/legion/blob/stable/runtime/realm/deppart/partitions.cc#L148-L149

@streichler This is unimplemented functionality for a call to create_equal_subspaces with an index space that contains a sparsity map.

Equal partitions of sparse index spaces have been around since commit 284a71b.


Code style adherence check on CI

Following https://github.com/0xPolygonMiden/compiler/pull/61#discussion_r1415664265
Motivation
We don't have to spend time checking the code style during the code review process.
Suggested solution
Delegate code style checks to CI.
Use rustfmt in a separate CI job to check the code formatting and fail if it does not match our style defined in rustfmt.toml in the repo root. Here is an example of a CI job that does that - https://github.com/ergoplatform/sigma-rust/blob/a360b255f8780d3ae9e6da44266c774e6e4055c5/.github/workflows/ci.yml#L177-L190
rustfmt.toml:
# see https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=import#imports_granularity
import_granularity = "Module"

Provide developers with local tools to author the code according to our style guide.
rust-analyzer uses rustfmt to format the code on save and can be additionally configured to introduce new imports with a given granularity. Each editor has its way of configuring the rust-analyzer. For VSCode, the option for import granularity is rust-analyzer.imports.granularity.group (in our case, set to module).
https://rust-analyzer.github.io/manual.html#auto-import

Done in https://github.com/0xPolygonMiden/compiler/pull/188


Increase timeout for quicktests

Motivation
Lately quicktests have been failing due to timeouts more often. In most runs they take ~4 minutes to complete but sometimes they take a bit longer. 7 minutes should be enough in these cases
Changes
Increased timeout for quicktests from 5 to 7 minutes.
Test Plan

TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors mereg

bors merge


Specify default audio format

Hello,
When I try to --extract-audio how can I also specify a number of --audio-formats so that if it is .m4a or .mp3 or .webm it doesn't convert but if it's something else it converts to .mp3?
Additionally, with --extract-audio which formats are kept and which are converted?
Thanks,
Daniel

When I try to --extract-audio how can I also specify a number of --audio-formats so that if it is .m4a or .mp3 or .webm it doesn't convert but if it's something else it converts to .mp3?

AFAIK currently it's impossible with the CLI only, while I guess it's possible with this approach. Also, I think such a feature will be never implemented as a CLI option because it's highly customized and rather complicated.

Additionally, with --extract-audio which formats are kept and which are converted?

If there are audio-only files (for example videos on YouTube), youtube-dl will just download the audio-only file and do no conversion. Otherwise, conversion occurs.

@yan12125 I understand that conversion doesn't occur if it can download the audio directly but is there any way of knowing what format it will convert to if it can't download just the audio?

This code segment determines the output codec from the input file codec and the preferred codec option (--audio-format). In short, if the preferred codec is not set, youtube-dl tries to keep the same codec as the input file.


SECURITY: Ports Exposed to the Internet: MySQL & PhpMyAdmin, bypasses UFW firewall

Info:

Docker version ($ docker --version): Docker version 18.09.5, build e8ff056
Laradock commit ($ git rev-parse HEAD):  27af2bca8c9527414779f62a1ad98209aefd90a9
System info (Mac, PC, Linux):  Linux
System info disto/version: Ubuntu 18.04

Issue:

In a linux production system that uses UFW firewall, Ports for PhpMyAdmin and MySQL are exposed to the internet, by-passing the UFW firewall.
It was realized that even with private key SSH and 64 character password for PhpMyAdmin (PMA) and MySQL
Randomware still managed to destroy our data
After checking https://www.yougetsignal.com/tools/open-ports/ ports for PMA and MySQL are open.
Turns out the combination of Docker and UFW introduces a security flaw.
Explanation of the flaw<EMAIL_ADDRESS>The fix is adding the following in sudo nano /etc/docker/daemon.json:
{ "iptables": false }

Then UFW can take control
EDIT "iptables": false  causes containers to lose internet connection
or:
Prefixing <IP_ADDRESS> on the said the ports (any ports that should not be exposed)
ref: https://stackoverflow.com/a/22100687/3553367
use:
PMA_PORT=<IP_ADDRESS>:8080
MYSQL_PORT=<IP_ADDRESS>:3306

instead of:
PMA_PORT=8080
MYSQL_PORT=3306

Prefixing <IP_ADDRESS> should be introduced in the default ENV, as it should work with all platforms (only tested on Ubuntu 18.04)
The original ENV opens up a security issue for all Laradock users, especially those with less experience like me, until a problem occurs.
adding { "iptables": false } into daemon.json should be mentioned in the guide, or referenced to some link when setting up Laradock
EDIT "iptables": false  causes containers to lose internet connection

Expected behavior:
PMA and MySQL Ports should be closed

Reproduce:
Setup a production Laradock, and your MySQL and PMA ports will be open in:
https://www.yougetsignal.com/tools/open-ports/

You should not be using Laradock for production or where your internal machine is port forwarded.

@bbashy
Laradock is meant for production, otherwise it really beats the point because we want to develop locally using same/similar environment as if it were to be in production
Apparently  the guide in http://laradock.io/ did have a section titled:
Prepare Laradock for Production (https://laradock.io/documentation/#prepare-laradock-for-production) and we're supposed to use production-docker-compose.yml
However it's really not obvious at all, having to read the guide so many times.
The guide to set up in Digital Ocean (https://laradock.io/guides/#Digital-Ocean) does not mention the issue either, exposing ports to the internet
Regardless the solution I have offered is simple, and should help a lot of people

It's main purpose is to be a dev environment. There's a lot of bloat software if you're using it in production...
It says to remove the database ports and it links to an article about adding iptables: false to the config.
Use a docker image that's the same OS and versions and it will be the same.

@bbashy
I actually have a few servers running Laradock, one of it is running in production, and so happens to have another layer of firewall installed (VMWare/virtualization stuff)
I really can't imagine/think of an production alternative to Laradock
because it has really helped develop and deploying quite fast. Though I'd probably prefer a single Dockerfile instead.
Do you know of a better way? It should be revolved around Docker through...
Other than that, I really think we should suggest the following as the default env
PMA_PORT=<IP_ADDRESS>:8080 #contain port in host only
PMA_PORT=8080 #expose port externally

MYSQL_PORT=<IP_ADDRESS>:3306 #contain port in host only
MYSQL_PORT=3306 #expose port externally

It really solves a security flaw, making it work well for production, and doesn't seem to do any harm.

I tested and this workaround worked for apache2. Thanks!

The same goes to MariaDB
MARIADB_PORT=<IP_ADDRESS>:3306 #contain port in host only
MARIADB_PORT=3306 #expose port externally

Same goes for MariaDB
MARIADB_PORT=<IP_ADDRESS>:3306 #contain port in host only
MARIADB_PORT=3306 #expose port externally


Map two methods in GeneratorType

Hmm, what exactly is first biome?

Hmm, what exactly is first biome?
It gets the first biome in the biome list of biome source

Hm, how is the first biome value used? Is it used in some more specific context, or is it totally arbitrary?

Hm, how is the first biome value used? Is it used in some more specific context, or is it totally arbitrary?

It's used when generating buffet worlds to get the only biome


BoxGeometry

Gonna skip Geometry and BoxGeometry, and use just BufferGeometry and BoxBufferGeometry for the initial demo.
The Geometry classes are merely for extra convenience on top of the BufferGeometry classes, so we can skip those.

Re-opening, to track for after the initial demo.


Add a back to top button

Add a back to top button to improve website usability

May I work on this?

@unm07 Sure, nice idea. Assigned you the issue you can start working on it. Also, make sure it works on mobile devices as well.


How can i run it?

Hello how can i run it after i got the android data from the app waze?
Thanks in advance!

Hello, how can i run it?


Unable to create user and send email through SCIM2 API when verifyEmail attribute is true

Describe the issue:
I want to verify the user email and i am trying to create user through SCIM2 API.
However i am getting following error.
{"schemas":["urn:ietf:params:scim:api:messages:2.0:Error"],"scimType":"invalidValue","detail":"Error in adding the user<EMAIL_ADDRESS>Email address not found for email verification","status":"400"}
When i don't set verifyEmail in request payload, User is created successfully.
Note: I am able to create user from management console and email is being set successfully.
How to reproduce:
Call this end point https://localhost:9443/t/carbon.super/scim2/Users as POST request.
Payload: {"emails":[{"type":"work","value":"faizan***@hotmail.com","primary":true}],"password":"faizan","schemas":[],"name":{"givenName":"Faizan","familyName":"Ali"},"userName":"faizan***@hotmail.com","urn:ietf:params:scim:schemas:extension:enterprise:2.0:User":{"verifyEmail":true}}
Expected behavior:
API should create a user and send verification email.
Environment information :

Product Version: IS 6.0.0
OS: Linux
Database: H2
Userstore: JDBC

Note<EMAIL_ADDRESS>is dummy email and in actual request i am using my valid email.
I verified that claim http://wso2.org/claims/emails.home contain the value i am sending while user creation without verifyEmail

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Rearrange "secrets" in Helm values

Currently in Helm values.yaml for this chart there is a dedicated secrets section holding values for data like st2 username/password, SSL certs, SSH keys and so on.
We wanted to move it to dedicated secrets.yaml when it gets implemented in Helm (https://github.com/kubernetes/helm/issues/2196).
But if that doesn't happen, - just obsolete dedicated secrets section and merge it with all other sections as any other Helm chart does.
https://github.com/StackStorm/stackstorm-enterprise-ha/blob/95fe6bb5f0d76ef772ad3f4391ff5cd3e00d1d86/values.yaml#L82-L100
Feedback needed: which approach/way looks better and friendlier to you?

Why not separate out the secrets to their respective services rather than aggregating them.
i.e.
serviceA:
  secrets:
    foo: a
serviceB:
  secrets:
    bar: b

instead of:
secrets:
  serviceA:
    foo: a
  serviceB:
    bar: b

?
This would still work well with a separate secrets.yaml file

It all depends and on what's the future of https://github.com/helm/helm/issues/2196 and where it'll go or whether it'll get implemented anytime.
Looking back, feels like going with YOLO approach and planning for "now":
st2:
  username: st2admin
  password: ***

what's used by the other official Helm charts was a more natural way comparing to:
secrets:
  st2:
    username: st2admin
    password: ***

or
st2:
  secrets:
    username: st2admin
    password: ***

In any case, relying on helm/helm#2196 is a long shot, the issue wasn't very active lately. I don't have any issues using either of the solution you guys mentioned, as long as we can progress on the features that we want to implement :)

https://github.com/helm/helm/issues/2196 was just closed. I agree by the maintainer, considering it wasn't addressed by anyone until this moment.
Hence we should just get rid of using secrets keyword for Helm values and rearrange them.


Any plans for Mac/Metal support?

Hi, I've been using this library on a 4090 with great success (it provides absolutely best in class performance there).
I was considering getting a Mac with the M2 Ultra 128-192GB unified memory to run larger models, until I saw that this library is currently only implemented for CUDA and ROCM. Do you already have any plans to port it to Metal?

There are currently still no plans to add Mac support, no. I don't own one and can't see myself getting one anytime soon. Feel free to take a stab at it though. :)

what if I send you a mac? @turboderp

it's kind of a big deal, almost all AI devs use macbooks


[docs] fixed issue with minus sign not showing

'&#x2212 ' The text set on the 'zoom out' button.
->
'−' The text set on the 'zoom out' button.

Wrong fix.
Plus sign is not expected to be shown here.
But there is still bug with apostrophe, which should be solved in Leafdoc.
P.S.
I remember something similar was already reported...

Related to #7317
I agree with @johnd0e , this is a Leafdoc upstream issue. The default value in question is a string containing a HTML escape sequence and not the related unicode glyph; the documentation should reflect that.

The default value in question is a string containing a HTML escape sequence and not the related unicode glyph;
the documentation should reflect that.

Well, that is pretty obvious from the value itself


Uncaught Error: Module did not self-register.

[Enter steps to reproduce:]

...
...

Atom: 1.40.0 x64
Electron: 3.1.10
OS: Unknown macOS version
Thrown From: Atom Core
Stack Trace
Uncaught Error: Module did not self-register.
At ELECTRON_ASAR.js:166

Error: Module did not self-register.
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:166:20)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:740:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:180:18)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:559:12)
    at Function.Module._load (internal/modules/cjs/loader.js:551:3)
    at Module.require (/app.asar/static/index.js:72:46)
    at require (internal/modules/cjs/helpers.js:20:18)
    at customRequire (/Users/jh/Desktop/Atom.app/Contents/Resources/app/static/<embedded>:1:688158)
    at get_KeyboardLayoutManager (/Users/jh/Desktop/Atom.app/Contents/Resources/app/static/<embedded>:14:2744622)
    at get_manager (/Users/jh/Desktop/Atom.app/Contents/Resources/app/static/<embedded>:14:2744724)
    at Object.getCurrentKeyboardLayout (/Users/jh/Desktop/Atom.app/Contents/Resources/app/static/<embedded>:14:2744850)
    at e.keystrokeForKeyboardEvent (/Users/jh/Desktop/Atom.app/Contents/Resources/app/static/<embedded>:14:1087821)
    at KeymapManager.keystrokeForKeyboardEvent (/Users/jh/Desktop/Atom.app/Contents/Resources/app/static/<embedded>:11:1246932)
    at KeymapManager.handleKeyboardEvent (/Users/jh/Desktop/Atom.app/Contents/Resources/app/static/<embedded>:11:1244917)
    at WindowEventHandler.handleDocumentKeyEvent (/Users/jh/Desktop/Atom.app/Contents/Resources/app/static/<embedded>:11:284329)

Commands
  2x -2:10.5.0 tree-view:duplicate (span.name.icon.icon-file-text)
     -0:46.2.0 core:copy (div.tool-panel.tree-view)
     -0:45.9.0 core:paste (div.tool-panel.tree-view)

Non-Core Packages
script 3.18.1

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way 😀


rand unconditionally depends on the winapi crate

I was more than a little surprised to see this scrolling by when I built rand on a Linux box!
   Compiling winapi v0.2.1
   Compiling winapi-build v0.1.1

Is this really necessary? The only extern crate winapi I see in this crate is inside a #[cfg(windows)] module.

Closing due to this comment: https://github.com/rust-lang/rand/pull/65#issuecomment-127768260


fix(deps): update module github.com/tubenhirn/dagger-ci-modules/v4 to v4.4.18

This PR contains the following updates:

Package
Type
Update
Change

github.com/tubenhirn/dagger-ci-modules/v4
require
patch
v4.4.17 -> v4.4.18

Release Notes

tubenhirn/dagger-ci-modules
v4.4.18
Compare Source
Bug Fixes

deps: update module dagger.io/dagger to v0.7.2 (7c2fb37)
deps: update module github.com/tubenhirn/dagger-ci-modules/v4 to v4.4.17 (144e342)

Miscellaneous Chores

deps: update renovate/renovate docker tag to v35.120.0 (35696cf)
deps: update renovate/renovate docker tag to v35.137.0 (6ffba08)
deps: update renovate/renovate docker tag to v35.140.0 (83dd523)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 4.4.19 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


document['key'] not returning the same as document.key for relationships

I am getting different values back when accessing relationships using [] and the dot notation. Below is a code example

require 'mongoid'

class Nurse
  include Mongoid::Document
  embeds_one :name
end

class Name
  include Mongoid::Document
  embedded_in :namable, polymorphic: true

  field :first_name, type: String

  def to_s
    first_name
  end
end

nurse = Nurse.new(:name => Name.new(:first_name=>"Fred"))

puts "nurse['name'] #{nurse['name']}"
# => nurse['name']
puts "nurse.name #{nurse.name}"
# => nurse.name Fred

What is even worse is if I load a parent object from the db, and I change its child object. The dot notation is correct, but the [] notation reflects the old value. It doesn't matter if I save or reload the object, I still get the same behavior.

Using the bracket syntax is reading the attributes directly from the attributes hash, where using the accessor goes to the relation in memory. In this case the embedded document is not in the attributes hash yet since Model#as_document hash not been called yet (which happens on save) so it's returning nil. Mongoid's behaviour is not going to change around this until 3.0 so you'll have to stick with using the normal accessor for now.


Angular 17 Directive -

Hi There,
Firstly thanks for this. Definitely speeds up the process.
Think there may be bug introduced in the last patches:
Console reads:
ANGULAR-PAYSTACK: Insert a callback output like so (callback)='PaymentComplete($event)' to check payment status
Seems the callback is not passing all the way through - this is true using both the AngularPaystackComponent and the AngularPaystackDirective.
Paystack is being provided in the app module:  Angular4PaystackModule.forRoot()

Just tested and it works, can you share what you're doing or follow the example here


set the colors of the selected bottom nav elements to newPrimary

Issue
Relevant issue number

Resolves #583

Please check the following

[ ] Do the tests still pass? (see Run the Tests)
[X] Is the code formatted properly? (see Linting (Formatting))
For New Features:

[ ] Have tests been added to cover any new features or fixes?
Has the documentation been updated accordingly: No need, minor UI change.

Please describe additional details for testing this change

Similar implementation used to set the color as is done in TheHeader.vue
Can see result in image below
Note: The primary color clashes a bit with the brown background in dark mode. For that, an option considered was to change the variant of the v-btn to plain instead of text to hide background. However, did not proceed with it since it also lowers the opacity of the text. More details here.

bumped it


Addition of FAQs | Issue #88

Completed #88
https://github.com/user-attachments/assets/f046f82a-59cc-4a3e-8357-a22456279e0e
@yatulearn please check, and merge

@yatulearn review and merge this

your pr has conflicts kindly resolve them

your pr has conflicts kindly resolve them

I have resolve all of them, please review again and merge

add faqs just above the footer

add faqs just above the footer

done please review

We will review all the changes it may take some time due to holidays

@yatulearn please review and merge this


Add hitbox data support

Plans for this are:

Have a separate hitbox class
Each Player will get 4 hitboxes as specified in the google drive doc
Do testing to ensure memory locations are correct

This is done


makefile: disable flag-parameter check

Signed-off-by: disksing<EMAIL_ADDRESS>What problem does this PR solve?
This check is usually unnecessary
What is changed and how it works?
Disable it.
Check List
Tests

No code

/merge


Add Coverage reporting to coveralls.io

https://coveralls.io/github/kotct/dot
Also add badges for travis and coveralls to the readme.
This is a part of #53.

Changes Unknown when pulling c1b13d66f1065625b25a51f06e2036f08f2fdda5 on coverage-reporting into ** on master**.

Changes Unknown when pulling c1b13d66f1065625b25a51f06e2036f08f2fdda5 on coverage-reporting into ** on master**.

Changes Unknown when pulling c1b13d66f1065625b25a51f06e2036f08f2fdda5 on coverage-reporting into ** on master**.

what

@rye @samontea actually ready for review, sorry for the confusion

Changes Unknown when pulling f18f7758847522f4409fbc470cbc2bca21935245 on coverage-reporting into ** on master**.

Changes Unknown when pulling f18f7758847522f4409fbc470cbc2bca21935245 on coverage-reporting into ** on master**.


resource_babysitter display no resource name if 'metadata' as a whole included in omitted_fields

Describe the bug
resource_babysitter display no resource name if 'metadata' as a whole included in omitted_fields
To Reproduce

In resource_babysitter configuration user: omitted_fields = ["metadata"]
Create a deployment change in the cluster

Expected behavior
Change deployment name is displayed
Thank you @tuananh2508 for reporting it

we did! closing


Introduce ENABLE_JSON_LOGGING

This change adds the ENABLE_JSON_LOGGING option to export restic metadata in JSON format. The goal is to improve accessibility by allowing users to utilize tools like jq to process the metadata. This enables users to create external scripts for extracting metadata and sending notifications using run_commands.
update doc and include notify script as sample to send backup metadata via apprise
Export LOG_FILE and create docker-compose for contributing

export LOG_FILE so it will be available for subprocess executed via run_commands
Add docker-compose.contribute.yml facilitate contributing process
make notify executable and copy it to /usr/local/bin
notify: update content to only include summary and errors for now. jq was complaining on payload too large when using verbose mode.
update doc

@djmaze that's will also make it easy to restore snapshots in the futur


How to directly access Tensor element in a c++ gpu Operator?

I try to access Tensor element in Forward function in my new c++ gpu Operator,but got violation access error.
Following is code snippet:
...
auto scale_data = out_data[CTCLoss_enum::k_scale_data].get<xpu, 4, DType>(s);
auto max_prob = out_data[CTCLoss_enum::k_max_prob].get<xpu, 3, DType>(s);
DType epsilon = 1.0 / std::sqrt(std::numeric_limits<float_t>::max());
...
for (int n = 0; n < scale_data.size(0); ++n)
{
	for (int y = 0; y < scale_data.size(2); ++y)
	{
		for (int x = 0; x < scale_data.size(3); ++x)
		{
			max_prob[n][y][x] = epsilon;// this will cause violation access error
			...
		}
	}
}

I am new to cuda programming.In this case,I prefer to access Tensor element directly,shoud I write a new mshadow_op to do this?
The code runs well in cpu mode.

you can't access gpu memory from cpu. write a kernel instead

If I write a mshadow_op expression to compute result and assign it to the destination,then will mshadow_op generate cuda kernel for me?
I look at the other mxnet operator but there I don't know how to write a gpu operator kernel in Forward function that both for cpu and gpu. @piiswrong

Thanks,I just write a <<<1,1>>> kernel to do the computation,and will optimize it later.


vendor: update containerd to current master

@AkihiroSuda PTAL (relates to https://github.com/moby/buildkit/pull/1482)

Ugh; looks like something broke;
test -c -o /ou...
2020-05-11T22:45:34.1742634Z #11 43.56 # github.com/AkihiroSuda/containerd-fuse-overlayfs [github.com/AkihiroSuda/containerd-fuse-overlayfs.test]
2020-05-11T22:45:34.1742774Z #11 43.56 ./fuseoverlayfs.go:293:52: undefined: snapshots.WalkFunc
2020-05-11T22:45:34.1742929Z #11 43.56 ./fuseoverlayfs.go:299:25: too many arguments in call to storage.WalkInfo

All green now 👍


Pull Request - Div Table

A table with following features:
-Drag & Drop any rows or columns
-Sort
-Search
-Name tag popup
-Mobile Version
I have test the UI & layout through http://localhost:4000/ and it works fine.
Known issue:
I have not started my SASS chapter yet, so the SASS code is not following the best practice.

Hi @jmatembu, do I have other outstanding issues in my pull request?

No @kubbafox
Just merged. I love those tables, I see myself using them a lot. Thanks for the awesome work.


Duplicate requests when removing entangled filters

Package
filament/filament
Package Version
v3
Laravel Version
v10
Livewire Version
v3
PHP Version
8.2
Problem description
If

you combine two or more filters on your table and
at least one of those filters has is $entangled (ie. adding searchable() to a select, adding toggle() to a filter, or using a date filter with native(false))

then when you remove one of the other filters the component will be rendered twice and therefore your table query will also happen twice.
I'm pretty sure this is related to the current issue with LW entangled. However, interestingly, the toggle() component while it does use $entangled, does NOT use $watch...So it might only be related to entangled and not $watch.
I'm documenting this here hoping it'll help give insight into the overall problem with LW and $entangled.
Here's a video showing the issue
The first pass is with no entangled filters. Watch debug bar and you'll see just one request per removed filter.
The second is with a different toggled() applied to the filter. You'll now see duplicate requests in LW when removing the other filters.
(The video was longer with demos of the other filters exhibiting the same issue, but the file size was too large to upload)
https://github.com/filamentphp/filament/assets/6097099/24c383db-da7d-4807-9c86-8ca62e3a3c2a
Expected behavior
Removing entangled filters should only trigger one request.
Steps to reproduce

Add a filter that doesn't use entangled (like a filter with a form input on it)
Add another filter that does use entangled (like a checkbox filter that has the toggle() method on it)
Apply both filters to the table
Remove the non-entanlged filter and watch debugbar for 2 requests.

Reproduction repository
https://github.com/archilex/demo/tree/duplicate-query-with-filter-demo
Relevant log output
No response

And if you're wondering, you can ignore the duplicate queries that debugbar shows at the bottom. That's due to the select filter querying the users to build the select options. The issue still occurs even without the select.

Hopefully this is related to all the other LW/Alpine issues like #7940 and others. I submitted a failing test for this at Livewire that will hopefully help them as they look into the problem.

I think this is a LW issue, so closing this. We can reopen if the issue is on the Filament side.


Add tapac —version for verification

tapac --help generates a lot of lines. Adding a tapac --version should be clearer for installation verification purposes.

Added in 241a8cad1eea8bc0234123dc33b8888b45d60594


getting node version

hi, how can i get node version, for example(1.21.2), instead of git hash, using aptos core rest api, or ts sdk?
thanks, dante

hi @dev-dantealighieri , not sure what you mean by "node version" but with the API this is the node info you can query for
https://fullnode.testnet.aptoslabs.com/v1/
with the ts-sdk, you can use https://github.com/aptos-labs/aptos-ts-sdk/blob/main/src/api/general.ts#L85


Inventory, Toolbar, and cursor updates. Bug fixes.

Improvements for inventory items.
Simplified the scene structure for Inventory (previously InventoryContainer) and Toolbar.
Updated all PowerQuest assets by Popochiu ones.

Just letting you know I'm following your work and can't wait to try Popochiu out in the hope to switch out of Unity and into Godot! :)
Keep it going! <3

Thank you so much for your comment 🥲. It makes feel very happy to know the project is interesting for others.
This week I'll start working on the documentation, so I hope to have it ready as soon as possible so that others can start using the plugin.

It's a while I wanted to get in touch to offer my support. Have you got a Discord server or any other channel to get involved with the project?

That sounds great! I'll create the Discord server for the project this week. Having support will help the project a lot.

Looking forward to it! :+1:

Hey @stickgrinder . I've created the Discord server already: https://discord.gg/Frv8C9Ters


Markdown links/embeds producing errors

Whenever a regular markdown link or embed is included in a note, and I try to export that note to any format, I get an error along the lines of
Error at "C:/Path/To/Obsidian/Note"
(line 4, column 2): unexpected 'l' [link](https://google.com) ^

Wikilinks work fine, but these don't...
The same is also true for markdown embeds for example ![alt text](path/to/image)
I am on Windows 10, I have the latest version of the plugin installed (1.10.3) with Pandoc version <IP_ADDRESS>.

It seems to be the same problem.
https://github.com/mokeyish/obsidian-enhancing-export/issues/163#issuecomment-1962365788

It seems to be the same problem.
#163 (comment)

Same problem, I already tested with the proposal from #163 (comment) but it doesn't solve the problem


[stable/sysdig] Update the notes to contain the reference to Secure tab

Signed-off-by: Néstor Salceda<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
This PR includes a new link for Secure to see the infrastructure we are securizing.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @bencer

/lgtm
/approve


Document sundown policy

The sundown policy and the pragmatic policies around when to expect upgrades
and what the tremor team's priorities around support is needs to be documented
clearly to reflect current procedures and practice.

I'm wondering, should this policy perhaps be an RFC? We usually do them for code but a policy like this could benefit from extra viewpoints.


Add to load path for C++ plugins

Currently the only way to add to the C++ plugin search path is through the Python API. Would be useful to have an environment variable to control this, to not have to install the plugin into XSTUDIO_ROOT.

Yep, we need to expose this via the preference json files.


[Feature Request] Integration with the Health app as a data source for Cycling Distance

Hello! Thank you for developing this app! I was wondering if you’d consider adding integration with the native Health app to make it a data source for Cycling Distance? It would be really useful and appreciated :)

Hello! Thank you very much for the suggestion, that sounds like a great addition to the app! I currently have a few smaller changes ready for the next update, but will try to add this to the next major update that I release. I can post an update here once I get a chance to work on it :)

Great, thanks! Looking forward :)


A smart contract that deploys an NFT or ERC20 (or have contracts for both)

Deploy NFT and/or ERC20

Or https://eips.ethereum.org/EIPS/eip-1155? Has both in one contract

@cachemonet0x0CF6619 sorry I never got to this. I am still a bit new to this idea. Can you explain in brief why we would want to have a contract for this and not deploy them separately like we do now?


[UnderlineNav] : Final implementation and UI fixes & docs improvement

TLDR: This PR addresses a couple of implementation issues, UI fixes as well as some documentation improvement.

Issues addressed in this PR:

Render menu items as the given as prop to the UnderlineNav
Wrap the nav with a container that overflow: hidden to prevent arrow buttons showing up when they are supposed to be hidden.
Display loading counters for all nav items.
Add string type to counter prop to support cases like 12K
Remove event.preventDefault() from click and keypress handlers as UnderlineNav should support with href along with react routing configuration. When react routing is configured, it ignores the href
Take the 4px left and right padding off from the link items and add 8px as a gap between the list items to align with design specs and take that gap value into account when calculating the possible number of items that can fit in the screen.
UI fixes to align with design specs.

Improvements in this PR:

Add responsive behaviour example to the documentation (Scroll behaviour for the course pointer devices)
Add React router example to the documentation
Some docs update in general

Merge checklist

[x] Added/updated tests
[x] Added/updated documentation
[x] Tested in Chrome
[x] Tested in Firefox
[x] Tested in Safari
[x] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

👋🏼 @danielguillan I have implemented the feedback you have given me here. I have a concern here for the touch target size though. I am not sure if it would be semantically correct to make the 44x44 wrapper div clickable to achieve the min touch target while keeping the button in a smaller width and height (because the focus ring should be around the button) if that makes sense. I think, the entire target touch area should be a button element. If that is the case, here how they will/should look. Unless I am missing a point here!

Rest should be fine. I would appreciate your feedback on the fixes 🙏🏼  Also just to provide a context on giving 8px gap between items and removing the 4px padding left and right, I had to slightly change the responsive calculation because  the items got 8px shorter due to removing the padding and that space went into the gap. it should be working fine and should be aligned with the design specs (I hope at least.)
Looking forward to hearing your feedback 🙌🏼

Overflow behaviour drastically changed due to the accessibility concerns and it would have been too complex to deal with merge conflicts here. So I am closing this PR and addressed above issues separately in these PRs:

https://github.com/primer/react/pull/2447
https://github.com/primer/react/pull/2448
https://github.com/primer/react/pull/2449


Auto save through onChange() and requestSave()

This is only a demo, and I haven't figure out if we need to remove the listener. Glad to make changes and adapt this into #10 if needed.

Thank you. I'll take a look into listener removing and get back to you this week.

Thanks for taking time reviewing the PRs. I noticed that the memory leak problem of Ketcher React has been fixed recently but not released. Don't know if this is related. https://github.com/epam/ketcher/pull/3027

Hello, @Acylation 👋 😃
I think we need to remove the listener manually using unsubscribe. Here is an example

FYI, implementations of subscribe and unsubscribe are here.

Changes are made according to your sample code in PR #10 and I will close this. Thanks for the instruction.


Float-Values will be ignored by "withFloatFormatting" - Configurations

I've added floatFormattingProperties by .withFloatFormattingProperties but my Container consists of Float-values but no Double-values. So during the addGenericDataRow - Method of the ExportToExcelUtility-Class, the column will be found as a configured floatformattingcolumn but there will be checked, if the values are instanceof Doubleor BigDecimal. Otherwise it will be ignored.
The result is, that the generated excel-sheet does not have the float-values included because they were ignored during the generationprocess.
The instanceof - check must be extended to include Float!

I can confirm this Issue.


Broken link in wrapper, opencv, dnn

https://github.com/opencv/opencv/blob/master/samples/dnn/ssd_mobilenet_object_detection.cpp

Thanks @arielbernal
The sample was based on SSD demo in OpenCV 3.4, and it seem to be removed / renamed.


Database Setup

I am trying to run the server and I think it complains about the database. How to set-up the database properly?

Try with MySql as database. On last line it says "can't connect to localhost:..." try changing port.


Error: 'recursive' is defined as a property in class 'CdkTreeNodeToggle<T, T>', overridden in 'NzTreeNodeToggleDirective'

Reproduction link
https://github.com/NG-ZORRO/ng-zorro-antd/
Steps to reproduce
Install nz-zorro with angular cdk
What is expected?
no errors with successful build.
What is actually happening?
Errormessage while building the project with ng serve:
Error: node_modules/ng-zorro-antd/tree-view/toggle.d.ts:10:9
- error TS2611: 'recursive' is defined as a property in class 'CdkTreeNodeToggle<T, T>',
  but is overridden here in 'NzTreeNodeToggleDirective<T>' as an accessor.
10     get recursive(): boolean;
           ~~~~~~~~~

Environment
Info

ng-zorro-antd
17.1.0

Browser
None

When I remove the get and set in the declared class in toggle.d.ts. everything works, but this is no solution.
I deleted my whole node_modules and retryed npm i. Didn't helped. Found no solution in web.
current package.json dependencies:
"@angular/animations": "^17.1.0",
"@angular/cdk": "^17.1.0",
"@angular/common": "^17.1.0",
"@angular/compiler": "^17.1.0",
"@angular/core": "^17.1.0",
"@angular/forms": "^17.1.0",
"@angular/platform-browser": "^17.1.0",
"@angular/platform-browser-dynamic": "^17.1.0",
"@angular/router": "^17.1.0",
"@angular/service-worker": "^17.1.0",
"@ant-design/icons-angular": "^17.0.0",
"@capacitor-community/sqlite": "^5.4.2-2",
"@capacitor/core": "^5.5.1",
"@fortawesome/angular-fontawesome": "^0.14.0",
"@fortawesome/fontawesome-svg-core": "^6.4.2",
"@fortawesome/free-brands-svg-icons": "^6.4.2",
"@fortawesome/free-regular-svg-icons": "^6.4.2",
"@fortawesome/free-solid-svg-icons": "^6.4.2",
"@ngxs/storage-plugin": "^3.8.2",
"@ngxs/store": "^3.8.2",
<EMAIL_ADDRESS>"^5.1.4",
"cytoscape": "^3.25.0",
"d3": "^7.8.5",
"d3-timelines": "^1.3.1",
"intro.js": "^7.0.1",
"jeep-sqlite": "^2.3.4",
"jszip": "^3.10.1",
"ng-zorro-antd": "^17.1.0",
"rxjs": "~7.8.0",
"tslib": "^2.6.2",
"zone.js": "~0.14.2"
devDependencies:
"@angular-devkit/build-angular": "^17.1.0",
"@angular-eslint/builder": "^17.2.0",
"@angular-eslint/eslint-plugin": "^17.2.0",
"@angular-eslint/eslint-plugin-template": "^17.2.0",
"@angular-eslint/schematics": "^17.2.0",
"@angular-eslint/template-parser": "^17.2.0",
"@angular/cli": "^17.1.0",
"@angular/compiler-cli": "^17.1.0",
"@biomejs/biome": "1.4.1",
"@capacitor/cli": "^5.5.1",
"@ngxs/devtools-plugin": "^3.8.2",
"@types/cytoscape": "^3.19.15",
"@types/d3": "^7.4.3",
"@types/jasmine": "~5.1.0",
"@types/node": "^20.9.1",
"@typescript-eslint/eslint-plugin": "^6.11.0",
"@typescript-eslint/parser": "^6.11.0",
"eslint": "^8.53.0",
"jasmine-core": "~5.1.0",
"karma": "~6.4.0",
"karma-chrome-launcher": "~3.2.0",
"karma-coverage": "~2.2.0",
"karma-jasmine": "~5.1.0",
"karma-jasmine-html-reporter": "~2.1.0",
"typescript": "~5.3.3"

I also have same issue. I think it is because there is `recursive: boolean' in CdkTreeNodeToggle.
I temporary remove get recursive() and set recursive(value: boolean) from NzTreeNodeToggleDirective.
but I am also waiting to fix this issue ASAP.

Greetings @Coder-Zertrax @ksrae,
I have created a stackblitz with the same configurations that @Coder-Zertrax provided.
I do not encounter any error; please provide more details. I am using the basic part in ng-zorro documentation.
Could you please review it and tell me what I should change to reproduce the same error as yours?
Even better If you could provide a stackblitz yourselves.
Additionally, please verify your imports. Remove all the imports related to tree view in your component import section, and import only NzTreeViewModule. Then, check if the issue is fixed or not. The cause of the problem might be the import of the new standalone component/directives.

Heeeeelp!!!!!!!!

Idk why, but the issue is solved by itself. I changed nothing. Just worked on another branch and tested the installation some minutes again. I think CdkTreeNodeToggle<T,K=T> has been changed somehow?
When I wrote this issue, CdkTreeNodeToggle<T,K=T><EMAIL_ADDRESS>had a variable recursive: boolean;. Now it's changed to get recursive(): boolean; and set recursive(value: BooleanInput); like in the toggle.d.ts. When I manually change the getter and setter to the variable, I get the exact same error, like I mentioned in my first post.
Maybe something changed in the CdkTreeNodeToggle in the last hours on npm? Idk.

Idk why, but the issue is solved by itself. I changed nothing. Just worked on another branch and tested the installation some minutes again. I think CdkTreeNodeToggle<T,K=T> has been changed somehow? When I wrote this issue, CdkTreeNodeToggle<T,K=T><EMAIL_ADDRESS>had a variable recursive: boolean;. Now it's changed to get recursive(): boolean; and set recursive(value: BooleanInput); like in the toggle.d.ts. When I manually change the getter and setter to the variable, I get the exact same error, like I mentioned in my first post. Maybe something changed in the CdkTreeNodeToggle in the last hours on npm? Idk.
EDIT: But my Pipline on GitLab throws the same error. Hmm, I'm baffled. Currently it works on my local machine.
EDIT 2: I killed my package-lock.json and my node_modules folder again and tried npm i again. It's broken again. Maybe NPM downloads a wrong version of angular/cdk?
EDIT 3: I reproduced it with the following steps: (I use npm v8.8.0 and node v21.5.0)

Create a new Angular Project on your local machine (not stackblitz): ng new test-17-1-0
Delete the created node_modules and package-lock.json file.
Run npm i in the project folder.
Import your code from main.ts file from stackblitz into your app.component.ts and the same package.json I mentioned in my first post.
Run ng serve.

Or just download Step 1, 2 & 4 and hit npm i and ng serve: test-17-1-0.zip
result:

Yeah that's really odd what's been happening; i checked Angular/cdk and they haven't had any new updates in the last 2 day, so it couldn't have been a new release causing the issues.
Thank you for creating a reproducible scenario, I will get back to you as soon as I can.

@Coder-Zertrax @ksrae @DimkaIvanyushin
Well the problem wasn't what I expected at all :)
In your tsconfig.json file, add this:
"skipLibCheck": true

@Coder-Zertrax @ksrae @DimkaIvanyushin
Well the problem wasn't what I expected at all :)
In your tsconfig.json file, add this:
"skipLibCheck": true

For more info, I suggest you watch this video, dude is literally called ts wizard :); around 0.40 he explains why it is a good idea to have "skipLibCheck": true.

This is more a hotfix, not a real solution or? I will try it.

This is more a hotfix, not a real solution or? I will try it.

Have you had the time to check it?
I don't know really what's changed recently; i tracked the recursive in cdk and it goes back to 7 years ago(link), and our recursive has been around for 4 years(link).
So maybe others are using "skipLibCheck": true, since when you create angular app this is the default config.
@Coder-Zertrax
Have you had any change in your tsconfig file recently?
Maybe created a new angular project but copied an old angular project assets into it?
@ksrae
And can you check that in your Angular v13, did you have this line of code in your tsconfig file?
I have to dig deeper, but for now this line of code should solve your server problem.

@ParsaArvanehPA I never changed the tsconfig since I work on this project (half a year). This project exists since angular 14 or 15. I added SkipLibCheck: true Yesterday, so my build will not fail. It works now. It works with 17.0.0 with SkipLibCheck: false.
When nobody changed anything, then node must has a niche bug or a transpiler or compiler has an bug. Idk.

@ParsaArvanehPA I never changed the tsconfig since I work on this project (half a year). This project exists since angular 14 or 15. I added SkipLibCheck: true Yesterday, so my build will not fail. It works now. It works with 17.0.0 with SkipLibCheck: false.
When nobody changed anything, then node must has a niche bug or a transpiler or compiler has an bug. Idk.
EDIT: In the 1.7.0, there is the getter and setter. In 1.7.1 the getter and setter get switcht to a variable.

import { NzTreeViewModule } from 'ng-zorro-antd/tree-view';
After deleting this module, the error disappeared。like this err

It seems that the error is caused by importing {NzTreeViewModule} from "ng zorro antd/tree view";

I also have same issue.

Same here :-))

Same


[Hotfix] Deactivate src dest check

Hi team!
I need help with this Issue / PR.
As we are deploying calico CNI by default, we have to deactivate the src dest check.
On Master nodes is solved, just added the attribute to the ec2_instance terraform resource.
The problem is within the worker nodes.
Launch configuration resource does not provide a way to deactivate the src dest check, so we have to do it "manually".
I found some alternatives:
As a "plain script" in the cloud-init userdata:

https://stackoverflow.com/questions/57504230/source-dest-check-in-aws-launch-configuration-in-terraform
Using a unit with a docker container (with a golang sw): https://github.com/rubenv/ec2-disable-source-dest

Additional info:
I tried to create an ec2 instance with the same AMI as we are using for the auto-join feature.
Also i have used the worker-join userdata cloud-init configuration (without some attributes).
~~But i can not make it working. ~~
1st problem: The unit file is not written.
2nd problem: If you try the container, it needs EC2 permissions.
Please, i need help with this. I have create a trello card to track it: https://trello.com/c/605OYtQ6
Thanks!

What if launching the container with hostNetwork=true? This should inherits in someway the profile of the ec2 instance and everything should be ok. I know that is not the most sure approach, as long as  is in our cluster managed by us, in a vpc, could be ok imho

What if launching the container with hostNetwork=true? This should inherits in someway the profile of the ec2 instance and everything should be ok. I know that is not the most sure approach, as long as is in our cluster managed by us, in a vpc, could be ok imho

I tried with no luck. I don't know if i did correctly :(

@angelbarrera92  does the iam profile is capable to modify its ec2 attributes?

on top of the permission of putting the right permission for iam profile, can be an idea to implement internally (in the furyagent?) the src/dest host check changes instead of calling an external docker ? I saw the code and is something really easy to be done.  Let me know what do you think!

@angelbarrera92 does the iam profile is capable to modify its ec2 attributes?

I have created the IAM Role for this test but...
f**k I think i executed the instance without the iam instance profile...
the 2nd problem can be fixed ensuring the instance has permissions + running with network host.

on top of the permission of putting the right permission for iam profile, can be an idea to implement internally (in the furyagent?) the src/dest host check changes instead of calling an external docker ? I saw the code and is something really easy to be done and makes sense in the autojoin feature.
Let me know what do you think!

About this... I was thinking about it. Currently the issue is only present in our AWS installation because gke, aks are managed services and OCI does not have this kind of checks.
If you find a better approach, please suggest it ;) I didn't found the "perfect" way.
Thanks for the debug!

 src/dst check AWS

@lzecca78 , you were right. With the IAM Role associated to the instance + docker run --net=host it works.
BUT
I don't know why the file (the unit) is not created -.-
I see some warnings in the cloud-init log:
Feb  4 12:25:59 ip-10-0-1-244 50-motd-news[870]:    Mac. Supports cloud-init for fast, local, cloud devops simulation.
Feb  4 12:26:03 ip-10-0-1-244 cloud-init[1197]: /usr/lib/python3/dist-packages/requests/__init__.py:80: RequestsDependencyWarning: urllib3 (1.25.8) or chardet (3.0.4) doesn't match a supported version!
Feb  4 12:26:03 ip-10-0-1-244 cloud-init[1197]:   RequestsDependencyWarning)
Feb  4 12:26:06 ip-10-0-1-244 cloud-init[1197]: Cloud-init v. 19.3-41-gc4735dd3-0ubuntu1~18.04.1 running 'modules:config' at Tue, 04 Feb 2020 12:26:03 +0000. Up 22.66 seconds.
Feb  4 12:26:07 ip-10-0-1-244 cloud-init[1450]: /usr/lib/python3/dist-packages/requests/__init__.py:80: RequestsDependencyWarning: urllib3 (1.25.8) or chardet (3.0.4) doesn't match a supported version!
Feb  4 12:26:07 ip-10-0-1-244 cloud-init[1450]:   RequestsDependencyWarning)
Feb  4 12:26:07 ip-10-0-1-244 cloud-init[1450]: Cloud-init v. 19.3-41-gc4735dd3-0ubuntu1~18.04.1 running 'modules:final' at Tue, 04 Feb 2020 12:26:07 +0000. Up 27.11 seconds.
Feb  4 12:26:07 ip-10-0-1-244 cloud-init[1450]: Cloud-init v. 19.3-41-gc4735dd3-0ubuntu1~18.04.1 finished at Tue, 04 Feb 2020 12:26:07 +0000. Datasource DataSourceEc2Local.  Up 27.37 seconds

File:
cloud_final_modules:
- [users-groups, always]
- [scripts-user, always]
write_files:
-   content: |
        # My new /etc/sysconfig/samba file

        SMBDOPTIONS="-D"
    path: /tmp/samba
-   content: |
        [Unit]
        Description=Disable EC2 source/dest check
        Requires=docker.service
        After=docker.service

        [Service]
        Type=oneshot
        RemainAfterExit=yes
        ExecStart=/usr/bin/docker run --net=host --rm rubenv/ec2-disable-source-dest

        [Install]
        WantedBy=multi-user.target
    path: /lib/systemd/system/ec2-disable-source-dest.service
    permissions: '0644'
runcmd:
- systemctl daemon-reload
- systemctl enable ec2-disable-source-dest.service
- systemctl start ec2-disable-source-dest.service

Any idea?

Ok....
The problem was between the PC and the chair :(
I was using this file:
cloud_final_modules:
- [users-groups, always]
- [scripts-user, always]
write_files:
-   content: |
        # My new /etc/sysconfig/samba file

        SMBDOPTIONS="-D"
    path: /tmp/samba
-   content: |
        [Unit]
        Description=Disable EC2 source/dest check
        Requires=docker.service
        After=docker.service

        [Service]
        Type=oneshot
        RemainAfterExit=yes
        ExecStart=/usr/bin/docker run --net=host --rm rubenv/ec2-disable-source-dest

        [Install]
        WantedBy=multi-user.target
    path: /lib/systemd/system/ec2-disable-source-dest.service
    permissions: '0644'
runcmd:
- systemctl daemon-reload
- systemctl enable ec2-disable-source-dest.service
- systemctl start ec2-disable-source-dest.service

And the correct one is
#cloud-config
cloud_final_modules:
- [users-groups, always]
- [scripts-user, always]
write_files:
-   content: |
        # My new /etc/sysconfig/samba file

        SMBDOPTIONS="-D"
    path: /tmp/samba
-   content: |
        [Unit]
        Description=Disable EC2 source/dest check
        Requires=docker.service
        After=docker.service

        [Service]
        Type=oneshot
        RemainAfterExit=yes
        ExecStart=/usr/bin/docker run --net=host --rm rubenv/ec2-disable-source-dest

        [Install]
        WantedBy=multi-user.target
    path: /lib/systemd/system/ec2-disable-source-dest.service
    permissions: '0644'
runcmd:
- systemctl daemon-reload
- systemctl enable ec2-disable-source-dest.service
- systemctl start ec2-disable-source-dest.service

Can you find the difference? #cloud-config 🤦♂
After fixing it, it started to work

So the PR is ready to be evaluated by the team as it works ;)

Sure it needs EC2 permissions, I would avoid the docker container + systemd unit and go with the simple script

I'd prefer to have plain script rather than the docker systemd unit

I'd prefer to have plain script rather than the docker systemd unit

Uhmmmmmm.
Do you mean you don't like the "docker run" inside the unit approach or the "systemd" one?

Agree with Philippe. The container embeds 15 lines of go code that can easily be ported to a script. This is faster and avoid layers (systemd that launch a container)

So, you are suggesting to replace the unit file + systemctl commands with:
runcmd:
  - AWS_AZ="$(curl -s http://<IP_ADDRESS>/latest/meta-data/placement/availability-zone)"
  - AWS_REGION="${AWS_AZ::-1}"
  - INSTANCE_ID="$(curl -s http://<IP_ADDRESS>/latest/meta-data/instance-id)
  - aws ec2 modify-instance-attribute --no-source-dest-check --instance-id ${INSTANCE_ID} --region ${AWS_REGION}

I am almost sure that aws cli is already present in the instance, but we have to double check before going to this approach

@angelbarrera92 the change is persistent across reboots? Or you need to apply it every time?

@angelbarrera92 the change is persistent across reboots? Or you need to apply it every time?

It's a one shoot configuration so it's persistent across reboots.

$ AWS_AZ="$(curl -s http://<IP_ADDRESS>/latest/meta-data/placement/availability-zone)"
$ AWS_REGION="$(echo $AWS_AZ | sed 's/.$//')"
$ INSTANCE_ID="$(curl -s http://<IP_ADDRESS>/latest/meta-data/instance-id)"
$ aws ec2 modify-instance-attribute --no-source-dest-check --instance-id ${INSTANCE_ID} --region ${AWS_REGION}

Tested, and working. From the previous version i had to change the AWS_REGION command from:
$ AWS_REGION="${AWS_AZ::-1}"

to:
$ AWS_REGION="$(echo $AWS_AZ | sed 's/.$//')"

Because runCmd is executed with /bin/sh instead of /bin/bash 🤦♂
Now the PR is ready to be discussed again ;)

LGTM, let's merge it!


feat: add TranslatableInput and TranslatableTextarea components (resolves #127)

Adds TranslatableInput and TranslatableTextarea components from Accessibility Exchange platform: Translation management UI. This work also cleans up blade templates for the components by adding a common trait that generates ids and label values for them.
Testing

Verify that TranslatableInput and TranslatableTextarea get rendered correctly depends on selected locale

P.S. There are a few other cases we will need to address:

What if the current locale is not one of the locales?
What of one of the locales is a signed language? I know I mentioned this before and I haven't solved it yet but it's something we should look at.

Both of these can be left for future work.

P.S. There are a few other cases we will need to address:

What if the current locale is not one of the locales?
What of one of the locales is a signed language? I know I mentioned this before and I haven't solved it yet but it's something we should look at.

Both of these can be left for future work.

Right, I am sorry if I have missed, but what format does signed language would have?


⚠ Jenkins Plugins Artifactory has degraded performance

In b0c8a52, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1309 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 76b222c after 25 minutes.


Handle returned error code differently based on the serverless command

In the case where, for example, the API gateway functionality is disabled, calling serverless deploy fails when the command tries to get the api-gw endpoints. The command also returns an error code to the Linux shell, so any automated deployment script (for example in Jenkins) considers the deployment to have failed. However, the deployment succeeded, what failed was the call to display  the summary info printed to the standard output.
The command should maybe only abort and return an error code if the "main" serverlesscommand failed. For example, serverless deploy should only fail when the deployment failed, while serverless info should fail if getting the api-gw endpoints has failed.
In the case where serverless deploy works but getting the api-gw info fails, this should still be displayed in the output of the command, the only difference should be that the command does not abort and does not return an error code to the Linux shell.

Thanks for the PR, I've merged this. Will be included in the upcoming release.

Ok thx!


Sling Model Support

Feel free to cherry pick specific changes. pom update, example HelloModel which injects HelloService and displays information in servicecomponent.

@steeleforge: I've merged your other pull request, and among several other changes, we also integrated the SlingModels example.
Please tell me if you think that some other changes are meaningful to be added!

Thanks for adding sling-models! I'm excited to use them alongside sightly in userland AEM dev!
The archetype might work fine for AEM6, but my understanding is embedding sling-models is necessary for 5.6 compatibility. If the archetype is moving away from abandons 5.6 compatibility in milestone 9, release notes should highlight this.
Also, cleaning up the pom files might be a prudent change as there are some spacing/indentation issues in the core pom and its parent pom

Also, cleaning up the pom files might be a prudent change as there are some spacing/indentation issues in the core pom and its parent pom

Good point, see PR #29

The archetype might work fine for AEM6, but my understanding is embedding sling-models is necessary for 5.6 compatibility. If the archetype is moving away from abandons 5.6 compatibility in milestone 9, release notes should highlight this.

Another good point ; since the archetype embeds the aem-api artifact I find it implicit that we use 6.0 . We should document this properly though, perhaps with a table of archetype version -> minimum CQ version.


Vite Web3Js frontend template

What :computer:

Adds a vite web3.js to front-end templates examples
Second thing updated with this PR
Third thing updated with this PR

Why :hand:

Reason why first thing was added to PR
Reason why second thing was added to PR
Reason why third thing was added to PR

Evidence :camera:
Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

@itsacoyote
Thanks!
Updated PR

Updated PR!
@itsacoyote


Syntax highlight is incorrect for "newState"

What docs page needs to be fixed?

Section: Basic Tutorial
Page: Reducers

What is the problem?
The code snippet
(previousState, action) => newState

is rendered as

The html source is

(previousState, action) =>
newState

What should be changed to fix the problem?
The variable newState should be rendered as a normal variable.

Hi @timdorr Can you please tell me why you closed this issue?

Because he made a commit that changed the variable name and fixed the issue:
https://redux.js.org/basics/reducers

I see. Thank you @markerikson.


Receiving updates twice per change

I am receiving updates twice per change (like a save). Everything else is working totally fine if I ignore the repetition. Is this due to some mistake in configuration from my part?

I use the following custom snippet to send update -
.
.
team.save()
event = SubscriptionEvent(
    operation='TEAM_STATE_CHANGE',
    instance=team
)
event.send()

I had earlier tried with post_save.connect(post_save_subscription, sender=Team, dispatch_uid="team_post_save") which also resulted in updates being dispatched twice per change/save, so I decided to try with the above custom event but it still doesn't seem to solve the issue.
This is my subscription resolver -
def resolve_teamUpdates(root, info, roomID):
    return root.filter(
        lambda event:
        (
            (
                event.operation == 'TEAM_JOIN_ROOM' or
                event.operation == 'TEAM_STATE_CHANGE' or
                event.operation == 'TEAM_LEAVE_ROOM'
            ) and
            isinstance(event.instance, Team) and
            event.instance.room.id == int(roomID)
        )
    ).map(lambda event: event)

Also in my django logs, I couldn't see anything surprising.

I am using a Daphne ASGI server & Django >3.0 (and react apollo in the client-side).

facing same issue, any updates?

eventually used this https://github.com/datadvance/DjangoChannelsGraphqlWs worked like a charm and easier to set up

SubscriptionEvent() calls channel_layer.group_send() to add RX event to the observer.
If you have several channel connections (e.g. from 3 browsers), it will be going to add 3 events and resolve 3 times per event.
I think maybe SubscriptionEvent() throw the event to the consumer directly (not channel_layer).
But unfortunately I could not find the way so far.

I also have this issue, and I receive a subscription event for every person that is subscribed. So if there are 10 subscriptions, one change occurs, every subscriber receives 10 event notifications


[Bug]: What the goal to have a image request on www.photopea.com ?

Is there an existing issue for this?

[X] I have searched the existing issues and checked the recent builds/commits of both this extension and the webui

What happened?
Your extensions do request on external site www.photopea.com, what the point of that?
Steps to reproduce the problem
...
What should have happened?
...
Commit where the problem happens
webui:
controlnet:
openpose-editor:
What browsers do you use to access the UI ?
Mozilla Firefox
Command Line Arguments
...

Console logs
...

Browser logs
...
Additional information
No response

Photopea edit is part of ControlNet extension feature, which was implemented here: https://github.com/Mikubill/sd-webui-controlnet/pull/2346.
The point of having photopea edit is to help user align multiple preprocessor result images together in a layered fashion.

You really need to download to photopea logo on website each time I launch webui? That called a security breach


Split-up pools.json file into multiple

This splits out the large pool.json file into a more maintainable set of entities. One JSON file per pool. Backwards compatibility is provided with the added script contrib/create-old-pools-json.py.
Other formats, as discussed in e.g. https://github.com/0xB10C/known-mining-pools/issues/38#issuecomment-845819260 can be added later if needed.
The new format also allows for easier merging with other pool.json files from forks (btccom and blockchain-info).
Closes #38

Python scripts mentioned in the commit messages:
# to-entities.py
# converts pool.json to the file-per-pool structure

import json

names = dict()

with open("pools.json", "r") as f:
    pools = json.load(f)

    for tag in pools["coinbase_tags"]:
        e = pools["coinbase_tags"][tag]
        name = e["name"]
        link = e["link"]
        if name not in names:
            names[e["name"]] = { "links": set(), "addresses": set(), "tags": set() }
        if link != "":
            names[name]["links"].add(link)
        names[name]["tags"].add(tag)

    for addr in pools["payout_addresses"]:
        e = pools["payout_addresses"][addr]
        name = e["name"]
        link = e["link"]
        if name not in names:
            names[name] = { "links": set(), "addresses": set(), "tags": set() }
        if link != "":
            names[name]["links"].add(link)
        names[name]["addresses"].add(addr)

for name in names:
    filename = name.rstrip('.').replace("'", "").replace(" ", "-").replace(".", "-").replace("/", "").replace("&", "").replace("(", "").replace(")", "").lower()
    pool = names[name]

    content = {
        "name": name,
        "addresses": list(pool["addresses"]),
        "tags": list(pool["tags"]),
        "links": list(pool["links"]),
    }

    with open("entities/"+filename+".json", "w") as out:
        json.dump(content, out, indent=2, ensure_ascii=False)

# sort-pools-json.py
# sorts the addresses and tags in pool.json file to make the files comparable
import json

names = dict()

with open("pools.json", "r") as f:
    pools = json.load(f)

    tags = pools["coinbase_tags"]
    addresses = pools["payout_addresses"]

    tags = dict(sorted(tags.items()))
    addresses = dict(sorted(addresses.items()))

    with open("pools-sorted.json", "w") as out:
        content = {
            "payout_addresses": addresses,
            "coinbase_tags": tags
        }
        json.dump(content, out, indent=2, ensure_ascii=False)

ForkMonitor was fetching this file…

Sorry, wasn't aware. Guess the symlink to generated/pools.json doesn't work for fetching this file..

It might work if I had fetched it locally, but I was fetching the file from Github.


Merge pull request #1 from ypinskiy/master

update

There are no files changed in this PR. Did you mean to add something?


[DNM] update readme to test mergify

Describe what this PR does
Testing updated mergify rules.
When someone approves this PR, and a subsequent update is made, the approval should be removed. Any requests for changes should be kept, and not dropped.
Is there anything that requires special attention
After testing, this PR should be closed without getting merged.
Related issues
See-also: #583

@nixpanic approved can you update the PR to verify it

@Madhu-1 can you leave a review to request changes too? After updating that negative review should stick around.

@nixpanic done

@nixpanic I think its working as expected, Thanks for the  Fix :+1

It looks to be working as expected. Dismissing a approval happened within a minute after updating the PR. The 'changes requested' review is still there after 10 minutes.


Provide type definitions for all packages

Describe the solution you'd like
@sap/xsenv and @sap/xb-msg (and probably others) do not come with Typescript type definitions. I would like you to provide some.
Describe alternatives you've considered
I am currently writing some myself, which is not ideal.
Impact / Priority
Getting started: I think a lot of people will just use other libraries when they see that the SAP library comes without type definitions because writing/generating the definitions yourself is tedious.

Hi @brodo,
our team is not responsible for the libraries you mentioned. Our team will not provide type definitions for other SAP libraries. Instead I reached out to the maintainers to inform them and will let you know how to contact them once I heard back.
Sorry that I can't be of more help!

Hey, I checked with the colleague behind xsenv. They are now aware of the issue, but you can open a formal request through ServiceNow with the component BC-XS-JS


General questions

Hey,
Is this project abandoned? It looks like I can't build my own docker image anymore due to several issues. I was looking for alternatives and I found EMQX, I could bet that they've started by copying VerneMQ and built on top of it. Are there any connections?

@urechi LoL.
VerneMQ is alive and kicking. Completely unrelated to EMQX.
Why don't you help and fix what doesn't seem to work for you?

:point_right: Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
:point_right: Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.