Fix Build Details button being disabled on equipped builds

This is intended. Showing details for an equipped build is disabled to facilitate future UI changes to character UI.


Keycloak and User Synchronization

In Keycloak, the user ID should be the same as the ID in the identity users table. The "sub" claim in the token should exist in users.
Currently, when creating users in EShopIdentityUserAppService, the ID will not be the same:
https://github.com/abpframework/eShopOnAbp/blob/327fbcc341fd7b5bb7dfa223593d3df2a7721c89/services/identity/src/EShopOnAbp.IdentityService.Application/Identity/EShopIdentityUserAppService.cs#L38
        var createdUser = await base.CreateAsync(input);
        await _backgroundJobManager.EnqueueAsync(new IdentityUserCreationArgs(input));

Each one will create a different ID.

When CreateUserLoggedInEto is executed:
https://github.com/abpframework/eShopOnAbp/blob/327fbcc341fd7b5bb7dfa223593d3df2a7721c89/apps/public-web/src/EShopOnAbp.PublicWeb/EShopOnAbpPublicWebModule.cs#L199
and the event is published:
https://github.com/abpframework/eShopOnAbp/blob/327fbcc341fd7b5bb7dfa223593d3df2a7721c89/services/identity/src/EShopOnAbp.IdentityService.Application/UserLoggedInEventHandler.cs#L34
For the admin user, this process is fine as it will delete and re-create the admin user to match the ID.
However, for other users, it will attempt to re-create them with the same username but without roles. This can lead to validation issues when creating a new user with the same name.

We are trying to integrate an ABP project with Keycloak. The issue is with the first created user, "admin." We need to sync it with Keycloak in Data Seeder.

Also, there is an issue with updating the password (it will be updated only in the identity user)


Deviation in the BBC functionality between (at least) LearnLib 0.14.0 and 0.16.0

Due to the update of AbstractLTSminMonitorMealy in 75b1987782c8f0167534a5e0b60ec285a11ab6f9, the behavior of the BBC functionality in LearnLib changed (at least) between 0.14.0 and 0.16.0. (Sorry, I have not tried 0.15.0) I believe that the previous behavior is the expected one.
Here is a concrete example to reproduce this deviation + a summary of the reason for the deviation in my understanding: https://github.com/MasWag/deviation-LearnLib-0.14.0-vs-0.16.0

Dear @MasWag,
thanks for reporting this issue and providing a testcase for reproducing it. You are right, this has been a regression in one of our refactorings to better handle null values. Unfortunately, the current implementation is not really in line with the interface definitions (see here as well) and we need to clean this up some time in the future.
I have added some test-cases in LearnLib (including the use-case you have described in your repo) so that we hopefully won't break things again.
I am currently a little bit busy with some side-projects. Can you live with using the 0.14 version or the current development version for now?

Thanks a lot for your quick response. Yes, I will keep using LearnLib 0.14 for the time being.


Similar Paper

I read another paper with almost the same name
Weakly Supervised 3D Object Detection from Lidar Point Cloud
https://arxiv.org/pdf/2007.11901.pdf
Could you explain more about the difference?

There are two major differences:

The targeted problem is different.
-Though the titles are very similar (weakly supervised ...), their work is more "semi-supervised" and our work is more "unsupervised". This is because, their method still requires 3D bbox annotations (while the number of annotations is smaller than fully supervised methods). Our method does not require annotated 3D bbox at all. Our object proposal stage is completely unsupervised.

The methodology is significantly different.
-In the two-stage detection framework:
In the first stage, we propose the UPM (unsupervised 3D object proposal module) that generates object proposals using Normalized Point Cloud Densities. Their method uses limited annotation to learn cylinder object proposals.
In the second stage, we propose the cross-model knowledge distillation scheme that transfers the knowledge from off-the-shelf image datasets to the point cloud domain to enable the learning of 3D object detection from point clouds. Their method learns to refine the proposals from the limited annotations.

Thanks for your quickly reply. I went through these two papers. Your idea is kind of understandable by using UPM and images. But theirs is mainly focus another point as you mentioned above.


Support field names containing dots

Consider the following two documents:
A: { foo: { bar: 2 } }
B: { 'foo.bar': 2 }

The query below matches only document A, but would also match document B if it ran against a MongoDB collection:
const isMatch = sift({ 'foo.bar': 2 });

isMatch({ foo: { bar: 2 } }); // true
isMatch({ 'foo.bar': 2 });    // false

I'm unable to get MongoDB to behave here: https://mongoplayground.net/p/eiTJyGJPzfH.
Anything I'm missing?

@crcn Apologies, I can't reproduce this anymore. I either made a mistake or my client lib was doing something shady with https://www.mongodb.com/docs/manual/reference/operator/aggregation/getField/#mongodb-expression-exp.-getField under the hood.


make prompt_tokens_details and completion_tokens_details optional

Legacy models such as GPT3.5 doesn't return these fields, so we make them optional.

It seems that spec was even updated even more, its been addressed in v0.26.0. Thank you for your prompt response though!


Adding links to the section1 contents

This not an issue but perhaps a request.
I would like to add links to the buttons in the section1 contents. For example, there are three blocks with buttons on each. If you could give an example of how to add links to them separately, that would be great.
The goal here is to showcase a list of books/articles which would link to the contents when clicked.
I know you might not have free time for this request, and I completely understand that. Thanks.

Okay, I've added this 👍


Release 1.1.6

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #256   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          13     12    -1
  Lines          89     83    -6
=====================================
- Hits           89     83    -6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cd633d...993a483. Read the comment docs.


FilterUi: loading the list should not change the width of the dialog

This is what it looks like when we load a list of long values:

This is what it should look like


feat: Add AvailableMedians method

Description

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch (see PR Targeting)
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Codecov Report

Merging #1657 (ce2d90d) into main (51982f3) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
+ Coverage   55.29%   55.36%   +0.06%
==========================================
  Files          73       73
  Lines        7503     7507       +4
==========================================
+ Hits         4149     4156       +7
+ Misses       3034     3031       -3
  Partials      320      320

Impacted Files
Coverage Δ

x/oracle/keeper/historic_price.go
72.78% <100.00%> (+0.76%)
:arrow_up:

x/oracle/keeper/params.go
80.39% <0.00%> (+5.88%)
:arrow_up:

Nice.
On performance, is it much of a problem to be calling AvailableMedians and then (usually) MedianOfMedians right after?

They're both going to call HistoricMedians() which iterates through medians in the store. The other option instead of having this method is to add an extra parameter to MedianOfHistoricMedians() like minMedians which would enforce a minimum amount of medians for it to return something by checking the length of the medians returned by HistoricMedians(). This would be one less call to HistoricMedians() than first calling AvailableMedians() and then MedianOfHistoricMedians(). What do you think about this approach @toteki?

I think that enforcement would create an error return, which would be indistinguishable from other more serious errors (invalid denom, etc) with inspecting the error.
What about keeping the AvailableMedians method but also adding a return to the other functions, for example MedianOfMedians(ctx,denom,numStamps) (sdk.Dec, uint32, error) where the uint32 is the number of stamps actually read?

I think that enforcement would create an error return, which would be indistinguishable from other more serious errors (invalid denom, etc) with inspecting the error.
What about keeping the AvailableMedians method but also adding a return to the other functions, for example MedianOfMedians(ctx,denom,numStamps) (sdk.Dec, uint32, error) where the uint32 is the number of stamps actually read?
Would reduce the load from 2 -> 1 HistoricMedians and allow leverage to determine whether a lower than expected number of stamps constitutes an error or just a case.

Made that update to MedianOfMedians and the other methods as well i.e. AverageOfMedians, MaxOfMedians, and MinOfMedians👍


Feature Request: Support for Invoking HTTP-based APIs via OpenAPI Spec

I would like to propose an enhancement to Spring AI that could significantly broaden its application: the ability to generate and invoke HTTP-based API calls dynamically based on OpenAPI specifications.
Current Functionality:
Spring AI currently allows the registration of custom Java functions with the OpenAiChatModel, which the model can then call by generating a JSON object with the required arguments. This setup works excellently for predefined functions where the function signature is known beforehand.
Proposed Enhancement:
Extend the functionality to allow the AI to interpret OpenAPI specifications and generate HTTP requests dynamically. This feature would enable developers to automate interactions with various APIs without needing to manually define each possible function or endpoint.
Benefits:
Enhanced Flexibility: Automating the generation of API calls based on OpenAPI specs would make Spring AI more adaptable, allowing it to interact with a broader range of external APIs.
Reduced Development Time: Developers wouldn't need to manually define and maintain function signatures for each API endpoint they wish to call. Instead, they could simply provide the OpenAPI spec and let the AI handle the rest.
Increased Productivity: This feature could automate complex workflows involving multiple API calls, making it easier to build sophisticated applications quickly.
Implementation Suggestion:
Function Bean: Introduce a new type of function bean that can interpret OpenAPI specs and generate the corresponding HTTP requests. This bean would parse the OpenAPI document, extract endpoint details, and formulate the necessary request parameters dynamically.
AI Integration: Enhance the OpenAiChatModel to understand when to call these new function beans based on the provided API documentation and user requests.
Example Use Case:
Imagine a staffing application that interacts with an API to manage contacts. Currently, a developer might need to:
GET a contact's UUID.
Use that UUID in a subsequent POST request to update their email address.
With this proposed enhancement, the developer could provide the OpenAPI spec for the staffing API, and the AI could dynamically generate and execute these calls based on the user's request.
Conclusion:
This feature would greatly enhance the capabilities of Spring AI, bringing it closer to the functionality offered by frameworks like LangChain, but with the added robustness and flexibility of the Spring ecosystem. It would empower developers to automate complex workflows and integrate with a vast array of external APIs more efficiently.

For mor context, I think what I'm asking for is a way to build an agent, eg. Build an Agent

I've labelled the issue with 'agent' and 'function calling' so that we can review in these contexts.  Agents, if we do anything at all, would be post 1.0 GA.  Improvements to function calling are being working on for 1.0.

I would suggest a concept of "AI function call support API spec" to make the scope simpler and easier to implement instead of supporting the full OpenAPI spec.
"AI function call support AP"  are endpoints that satisfied conditions

The endpoint MUST be a POST endpoint.
The endpoint MUST accept a JSON request body.
The endpoint MUST return a JSON String response body.
The endpoint SHOULD be secured with an API key, and we will pass the API key with x-api-key in the header. (api key header can be configurable).

In the real world there's a lot of complex scenarios and we do not want to adapt to specific case. That would make the core logic of spring-ai really complex to adopt to these cases. The suitable approach is building "connector" API - which is the API following the above conditions to wrap the real / complex API execution. For any endpoint which is not satisfied, a wrapper endpoint is a MUST.
With that thought, I come with a super simple stupid approach to implement this as below:
1/ Create the APIFunctionCallback implements the FunctionCallback interface with below simple code:
@Getter
@Builder
@Slf4j
public class ApiFunctionCallback implements FunctionCallback {
    private String name;

    private String description;

    private String inputTypeSchema;

    private String apiEndpoint;

    private String apiKey;

    private ApiClient apiClient;

    @Override
    public String call(String functionInput) {
        try {
            return apiClient.execute(apiEndpoint, functionInput, apiKey);
        } catch (Exception e) {
            log.error("Error calling API: {}", apiEndpoint, e);
            return "";
        }
    }
}

2/ The inputTypeSchema: we accept the JSON schema string - which can be generated easily from the input of the OpenAPI spec or setup in the configuration.
In my case, I have a need to setup a JSON configuration where I can load all of these API specs and can use them as function call for my AI Agent. I come with this approach to adopt it first while waiting the official solution from spring-ai implementation.
Let me know if you have other ideas / comments.
Thanks


⚠ Grafana1 has degraded performance

In 34ad58f, Grafana1 (https://grafana1.jenshamann.solutions) experienced degraded performance:

HTTP code: 200
Response time: 5758 ms

Resolved: Grafana1 performance has improved in 66786f2.


Don't expose selectedNode

For privacy reasons, please do not expose the selectedNode attribute anymore, as this information could be misused by websites. It isn't / should not be necessary for the daepp to run :)

related to #366?

Well kind of, this one is a getter, the other one a setter so to say

Expose network id.

Current version of wallet doesn't have such problems. Feel free to reopen this issue, if it will pop up again.


Add alternate driver location for Semantic Layer Tableau integration

A customer had issues with the location from the official docs but the alternate location worked for them.
What are you changing in this pull request and why?

Checklist

[ ] Review the Content style guide so my content adheres to these guidelines.
[ ] For docs versioning, review how to version a whole page and version a block of content.
[ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

[ ] Add page to website/sidebars.js
[ ] Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

[ ] Remove page from website/sidebars.js
[ ] Add an entry website/static/_redirects
[ ] Run link testing locally with npm run build to update the links that point to the deleted page

hey @aiguofer -- looks like this pr https://github.com/dbt-labs/docs.getdbt.com/pull/4562/files from @DevonFulcher addresses already

if it's teh same, am i ok to close this one and merge #4562

Ahh nice! yeah they're the same :)


PWN-5621 - update action panel inside the token details

Jira Ticket
https://p2pvalidator.atlassian.net/browse/PWN-5621
Description of Work

refactor action buttons into custom view
use custom view on token history screen
hide BUY button if it's not SOL/USDC

Cannot get what did you do in this PR?
The task is about username in details but you have different changes here

Cannot get what did you do in this PR? The task is about username in details but you have different changes here

sorry, wrong task linked, gotta fix that


WIP: Ducks

Refactoring directory structure for better maintainability
https://medium.freecodecamp.org/scaling-your-redux-app-with-ducks-6115955638be
https://github.com/alexnm/re-ducks
https://github.com/alexnm/re-ducks/blob/master/example-duck/index.js
https://github.com/jthegedus/re-ducks-examples/tree/master/re-ducks-todos/src/state/ducks/todos
https://github.com/erikras/ducks-modular-redux
Transactions

ethjs sendTransaction

Listings

transformer - logs affect normalized listings

EthereumProvider

abis
event signatures
log topics
ethjs getLogs (poll)

done


Fix redis transaction when traffic is mirrored

Commit Message: Fix redis transaction when traffic is mirrored
Additional Description:
When envoy is configured to mirror Redis traffic, using transactions (MULTI) would not work well, possibly leading to a crash. This PR fixes this issue by making the following changes:

I have defined MULTI, EXEC, and DISCARD as write commands, so they will be mirrored even when read commands are excluded from mirroring.
A dedicated connection for the transaction is opened for each redis server that receives mirrored commands, the same way a dedicated connection is opened to the main redis server.

This PR fixes the following issue: https://github.com/envoyproxy/envoy/issues/26342
Risk Level: Low
Testing: Integration tests and local tests. Reproduced the problem by using the same configuration used in the open issue.

Unfortunately Signing off previous commits is complicated since I have a merge commit. Closing this PR and opening a new PR: https://github.com/envoyproxy/envoy/pull/28244

Opened a new PR with commits signed properly: https://github.com/envoyproxy/envoy/pull/28244


Raise if remove_columns is called with unknown column by default

Is your feature request related to a problem?
Currently, Table.remove_columns ignores unknown columns by default. However, then it can happen that users expect that certain columns are removed, but they are still there due to a typo.
Desired solution
Add a new optional, keyword-only parameter ignore_unknown_names: bool = False.
If ignore_unknown_names is False, call _check_columns_exist to ensure that all given names are valid. Otherwise, keep the current behavior.
Possible alternatives (optional)
No response
Screenshots (optional)
No response
Additional Context (optional)
No response

:tada: This issue has been resolved in version 0.27.0 :tada:
The release is available on:

v0.27.0
GitHub release

Your semantic-release bot :package::rocket:


timedoctor: update maintainer

Motivation for this change
@kamadorueda will no longer support this package. I will take over.

Thanks Daniel


Quick Accent: Doesn't place accent window correctly on vertical monitors

Microsoft PowerToys version
0.62.0
Running as admin

[ ] Yes

Area(s) with issue?
Quick Accent
Steps to reproduce
Use Quick Accent on a vertical monitor. The window won't appear where it should be.
✔ Expected Behavior
If I put Left for the Toolbar position, it shows up normally on my horizontal "main", horizontal monitor. I'd expect the same on my vertical monitor
❌ Actual Behavior
Toolbar appears in the wrong locations on vertical monitor. When Left is selected for the Toolbar position setting, the actual toolbar appears almost all the way to the right of the screen. Center is even worse as it won't show on my vertical monitor (I assume it's being displayed off-screen as the accents actually ARE being selected)
Here's an image of what it looks like (note the toolbar on the sort of lower right of my vertical monitor)

Other Software
No response

Thanks for your message. This is a Duplicate of an other issue. Additional comments may be added there. /dup #20316


Install plugins as "$logstash_user"

Fix Issue https://github.com/elastic/puppet-logstash/issues/307

Hi @elconas, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?


Add ability to run update_pipeline.py with a parameter that has value is none

Hello @samiyaakhtar ,I am using Bedrock. I have 3 stages corresponding to 3 environments (dev, qa, prod), each of which is transformed by Fabrikate into Infra-materialized. I am using Spektate in 3 places.

After building the image.
After the release (release stage).
After Fabrikate transforms.
After running at positions 1 and 2, Spektate creates and updates a row but when running at position 3, it creates a new line. I expect that after running, there will be only 1 row for each environment.
I have found a solution to this problem, but it needs a little modification in the script. The script needs to support running with an input variable of 1 none value
ex:

python "$ HOME / spektate / pipeline-scripts / update_pipeline.py" $ (ACCOUNT_NAME) $ (ACCOUNT_KEY) $ (TABLE_NAME) $ (PARTITION_KEY ) imageTag $ IMAGE_TAG p2 $ BUILD_TAG manifestCommitId
I have also tried to fork the code and changed it myself. Can you take a look?
https://github.com/TaiNguyen2406/spektate/blob/master/pipeline-scripts/update_pipeline.py

Hi @TaiNguyen2406, apologies for the late response here. Thanks for the suggestion above - we have actually been expecting the use of spk cli to be downloaded and ran for updating the pipelines and so we haven't managed to keep these python scripts up to date.
Would you like to make a PR for this change if you prefer to use the python scripts from your pipelines?

Hi, I've created pull request.


Side inputs: Bug fixes

Use the correct regex in Util#getSystemStreamFromNameOrId
Handle end of stream during dispatch of message to side input
processor
Fix validation to check for presence of side input processor for a
given store instead of looking up the side input processor factory.

@prateekm please take a look


Missing models for hair segmentation

I attempted to follow the instructions for the hair segmentation example, but the build failed with:
WARNING: Download from https://storage.googleapis.com/mirror.tensorflow.org/bitbucket.org/eigen/eigen/get/8071cda5714d.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
WARNING: Download from https://mirror.bazel.build/github.com/Maratyszcza/FP16/archive/febbb1c163726b5db24bed55cc9dc42529068997.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found

Similar to https://github.com/google/mediapipe/issues/3, https://github.com/google/mediapipe/issues/19 and https://github.com/google/mediapipe/issues/96, it's a temporarily network issue. Please retry the Bazel command. Thanks.


Job fails when turbo_rails sends an empty string in the argument list

I have a turbo_rails model booking.rb which has
broadcasts_refreshes_to :jump
This enqueues a job with the following raw data:
  {
  "id": 26,
  "queue_name": "default",
  "class_name": "Turbo::Streams::BroadcastStreamJob",
  "arguments": {
    "job_class": "Turbo::Streams::BroadcastStreamJob",
    "job_id": "ec0afdd3-0c15-42e0-a174-91c0e8c2c852",
    "provider_job_id": null,
    "queue_name": "default",
    "priority": null,
    "arguments": [
      "",
      {
        "content": "<turbo-stream action=\"refresh\"></turbo-stream>",
        "_aj_ruby2_keywords": [
          "content"
        ]
      }
    ],
    "executions": 0,
    "exception_executions": {
    },
    "locale": "en",
    "timezone": "UTC",
    "enqueued_at": "2024-04-10T11:12:48.383565000Z",
    "scheduled_at": "2024-04-10T11:12:48.383452000Z"
  },
  "priority": 0,
  "active_job_id": "ec0afdd3-0c15-42e0-a174-91c0e8c2c852",
  "scheduled_at": "2024-04-10T12:12:48.383+01:00",
  "finished_at": null,
  "concurrency_key": null,
  "created_at": "2024-04-10T12:12:48.383+01:00",
  "updated_at": "2024-04-10T12:12:48.383+01:00"
}

The job then fails with:
Message	ERROR: zero-length delimited identifier at or near """" LINE 1: NOTIFY "", '"\u003cturbo-stream action=\"refresh\"\u003e\u00... ^
/Users/rob/.rvm/gems/ruby-3.3.0/gems/actioncable-enhanced-postgresql-adapter-1.0.1/lib/action_cable/subscription_adapter/enhanced_postgresql.rb:56:in `exec'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/actioncable-enhanced-postgresql-adapter-1.0.1/lib/action_cable/subscription_adapter/enhanced_postgresql.rb:56:in `block in broadcast'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/actioncable-<IP_ADDRESS>/lib/action_cable/subscription_adapter/postgresql.rb:54:in `block in with_broadcast_connection'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/activerecord-<IP_ADDRESS>/lib/active_record/connection_adapters/abstract/connection_pool.rb:227:in `with_connection'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/actioncable-<IP_ADDRESS>/lib/action_cable/subscription_adapter/postgresql.rb:51:in `with_broadcast_connection'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/actioncable-enhanced-postgresql-adapter-1.0.1/lib/action_cable/subscription_adapter/enhanced_postgresql.rb:74:in `with_broadcast_connection'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/actioncable-enhanced-postgresql-adapter-1.0.1/lib/action_cable/subscription_adapter/enhanced_postgresql.rb:39:in `broadcast'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/actioncable-<IP_ADDRESS>/lib/action_cable/server/broadcasting.rb:50:in `block in broadcast'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:206:in `block in instrument'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications/instrumenter.rb:58:in `instrument'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/activesupport-<IP_ADDRESS>/lib/active_support/notifications.rb:206:in `instrument'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/actioncable-<IP_ADDRESS>/lib/action_cable/server/broadcasting.rb:48:in `broadcast'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/actioncable-<IP_ADDRESS>/lib/action_cable/server/broadcasting.rb:27:in `broadcast'
/Users/rob/.rvm/gems/ruby-3.3.0/gems/turbo-rails-2.0.5/app/channels/turbo/streams/broadcasts.rb:91:in `broadcast_stream_to'

I assume this is related to the empty string
    "arguments": [
here=>      "",
      {

fwiw: The same job runs ok on sidekiq
--
Rails 7.1.3
Solid Queue: 0.3.0

Hey @ConfusedVorlon, I'll look into this one. It's very strange, as Solid Queue doesn't do anything special with job arguments. It relies on Active Job's serialize method to store them and on Active Job's execute method to deserialize and run it 🤔
In any case, I'll investigate and might ask more questions.

Looking at this though - it seems wrong that there is no identifier for the refresh.
It wasn't so obvious with the other content in the solid queue case.
Digging in now to see what/if I'm doing wrong...

Thank you! I suspect that's the deserialized version of the arguments, though 🤔 Because Active Job needs to distinguish between Ruby kwargs (_aj_ruby2_keywords) and symbol keys (_aj_symbol_keys), and there you just have:
{"content"=>"<turbo-stream action=\"refresh\"></turbo-stream>"}

My suspicion is that Sidekiq is doing something to the empty string before executing the job so that it doesn't fail. The thing is that having an empty string there seems wrong, because that'd be the channel you're broadcasting to 😕 I'm not sure how this can work with Sidekiq. When you're using Sidekiq, do you see the messages being broadcasted at all?

not sure what sidekiq is doing. I'm just reading args from the sidekiq web interface.
happy to dig elsewhere if you can point me in the right direction.
I figured out what the trigger is though - jump is an optional association, and in this case it is nil.
So - I'm guessing roughly: turbo_rails is calling booking.jump, finding nil and generating an identifier from that which is an empty string.
I think I can work around this with an after_update_commit that checks before broadcasting.
It feels like this is probably something where turbo_rails could just help me out and not broadcast to a nil association.
I have no idea what the correct behaviour ought to be for solid_queue...

little more info - I was confusing this broadcast with a different one.
So - I thought it was doing a job that was being done elsewhere. Obviously in fact it is a non-job.
Nonetheless, sidekiq does seem to be behaving as if it is performing the job for whatever that's worth...
web               | [ActiveJob] Enqueued Turbo::Streams::BroadcastStreamJob (Job ID: a54de5b5-2eb2-46b4-92fc-92cf60c19aee) to Sidekiq(default) with arguments: "", {:content=>"<turbo-stream action=\"refresh\"></turbo-stream>"}
worker            | 2024-04-11T15:02:28.868Z pid=73365 tid=27it class=Turbo::Streams::BroadcastStreamJob jid=467375c301c89d35ed714e79 INFO: start
worker            | 2024-04-11T15:02:28.909Z pid=73365 tid=27it class=Turbo::Streams::BroadcastStreamJob jid=467375c301c89d35ed714e79 INFO: Performing Turbo::Streams::BroadcastStreamJob (Job ID: a54de5b5-2eb2-46b4-92fc-92cf60c19aee) from Sidekiq(default) enqueued at 2024-04-11T15:02:28.867699000Z with arguments: "", {:content=>"<turbo-stream action=\"refresh\"></turbo-stream>"}
worker            | 2024-04-11T15:02:28.909Z pid=73365 tid=27it class=Turbo::Streams::BroadcastStreamJob jid=467375c301c89d35ed714e79 INFO: Performed Turbo::Streams::BroadcastStreamJob (Job ID: a54de5b5-2eb2-46b4-92fc-92cf60c19aee) from Sidekiq(default) in 0.96ms
worker            | 2024-04-11T15:02:28.910Z pid=73365 tid=27it class=Turbo::Streams::BroadcastStreamJob jid=467375c301c89d35ed714e79 elapsed=0.041 INFO: done

Aha! That's very useful.

not sure what sidekiq is doing. I'm just reading args from the sidekiq web interface.

Ahh got it! Yes, that'd be the deserialized arguments. It's ok, don't worry about that.

It feels like this is probably something where turbo_rails could just help me out and not broadcast to a nil association.

Yes, I agree! Maybe it's better to reopen the issue you opened in the turbo-rails repo and add this info 🤔

I have no idea what the correct behaviour ought to be for solid_queue...

I think the right behaviour is the one you're getting, since for Solid Queue the job and its arguments are a sort of a black box, and doesn't have any influence on why the job might be failing here (an empty string passed to the PostgreSQL cable adapter). However, that's also true for Sidekiq, and this:

Nonetheless, sidekiq does seem to be behaving as if it is performing the job for whatever that's worth...

worker            | 2024-04-11T15:02:28.909Z pid=73365 tid=27it class=Turbo::Streams::BroadcastStreamJob jid=467375c301c89d35ed714e79 INFO: Performing Turbo::Streams::BroadcastStreamJob (Job ID: a54de5b5-2eb2-46b4-92fc-92cf60c19aee) from Sidekiq(default) enqueued at 2024-04-11T15:02:28.867699000Z with arguments: "", {:content=>"<turbo-stream action=\"refresh\"></turbo-stream>"}
worker            | 2024-04-11T15:02:28.909Z pid=73365 tid=27it class=Turbo::Streams::BroadcastStreamJob jid=467375c301c89d35ed714e79 INFO: Performed Turbo::Streams::BroadcastStreamJob (Job ID: a54de5b5-2eb2-46b4-92fc-92cf60c19aee) from Sidekiq(default) in 0.96ms

is certainly strange! Is it possible the error isn't being surfaced here, and the job is somehow ending at Sidekiq's Dead set? My Sidekiq experience is very limited, as I only used it in production about 7 years ago, but I know there are multiple ways you can handle errors in Sidekiq. Is it possible the failure is being silenced somehow?

Thank you so much for your help here. It's really appreciated.
I'll definitely open a turbo_rails issue. Not exactly sure where is best to catch this or I'd send a PR.
As far as I can tell, Sidekiq really does think that it is processing the job. It isn't incrementing the failed count - it would retry by default and keep the job around. It certainly does that with other broadcast jobs - but I haven't dug deeply enough to be 100% sure.
My suspicion is that it just carries on regardless. The empty argument seems to be a postgres specific complaint, and sidekiq isn't going anywhere near that, so I assume it just doesn't care.
I do have a slight spidey-sense, where I do wonder if solid_queue should behave differently.
Digging a bit deeper, the job is enqueued here:
https://github.com/hotwired/turbo-rails/blob/6a60eb4f72d2e834f91279b0a6f95be411ae6174/app/channels/turbo/streams/broadcasts.rb#L71
  def broadcast_refresh_later_to(*streamables, request_id: Turbo.current_request_id, **opts)
    refresh_debouncer_for(*streamables, request_id: request_id).debounce do
      Turbo::Streams::BroadcastStreamJob.perform_later stream_name_from(streamables), content: turbo_stream_refresh_tag(request_id: request_id, **opts)
    end
  end

streamables is [nil], so stream_name_from(streamables) is ""
In principle - there is nothing wrong with an empty string as an argument.
Should solid queue reject this ?
It seems like some postgres wierdness might be creeping in where it shouldn't....

I should have done about three steps ago!
So - following through all the way to the actual job.
class Turbo::Streams::BroadcastStreamJob < ActiveJob::Base
  discard_on ActiveJob::DeserializationError

  def perform(stream, content:)
    binding.b
    Turbo::StreamsChannel.broadcast_stream_to(stream, content: content)
  end
end

sidekiq does indeed call this with stream == ""

I figured I'd simplify things and just create my own job.
It works fine with empty string arguments.
So - presumably the postgres error is unrelated to solid queue.
@rosa Thank you for your help with this rabbit hole!


[DS-3154] Maven release process fails when using Java 8 because of Javadocs errors

I couldn't stand it.  XMLUI also needs a lot of javadoc fixing.  I hope you don't mind my butting in.
While fixing javadoc, I'm also very liberally accepting NetBeans' other minor suggestions, and trying to make the javadoc output look like it does in the source.  A lot of text was written without recalling that javadoc is treated as (sort of) HTML:  smooshed into a rectangle unless marked up, pruned of unrecognized XML-ish things, and the like.  Things that bother the spell-checker tend to be things that render better as {@code} anyway.  And so on.
I'm ruthlessly removing from overriding implementations any doc comment that adds nothing of substance.  In such cases, documentation will be supplied by the overridden method.

This is huge enough.  I'll start another PR with more of these fixes.

+1 via code review. As noted, in the future, we probably should limit these PRs to just JavaDocs changes. This one includes some minor code cleanup/refactoring, but it all seems sane.

+1 by inspection


Eslint in "react-scripts" -  "4.0.3" doesn't work

Added following scripts rule and executed using "npm run lint". Looks like i am not getting any eslint errors/warnings
"lint": "eslint --max-warnings=0 src/**/*.{ts,tsx}"
But if i add "eslint:recommended" to the eslintConfig in package.json, I get errors/warnings.

I was also facing that problem.
With this command eslint will not lint files in the src folder, it will lint files in sub folders of src folder
"scripts": {"lint": "eslint src/**/*.js src/**/*.jsx"}
Rather you should use this command
"scripts": {"lint": "eslint src --ext .js,.jsx"}


Add Support for Kafka Connect

@r-vasquez FYI I've pulled in the latest from main and bumped the galaxy version as we discussed.


Color-bg or Layout-bg change background color to image

Issue type
I'm submitting a ...  (check one with "x")

[ ] bug report
[ ] feature request
[X] question about the decisions made in the repository

Issue description
I tried to change the background image for color-bg and layout-bg. its gives error . can you plz advice

answered here https://github.com/akveo/nebular/issues/391


Add title to file browser cascade dialog in Id output directory selec…

…tion, and safeguard against null description elsewhere
Fixes issue #1519
Brief summary of changes
Filebrowser was throwing because description was passed to it as null due to upstream changes. Guarded against null description and provided an actual description for ID tool output folder browser.
Testing I've completed
CHANGELOG.md (choose one)

updated...

@AlbertoCasasOrtiz for your review

Thanks @AlbertoCasasOrtiz


Fixing ARM Template

Connection strings were incorrect; updated everything to the latest version and order.
Fixes #
Proposed Changes

Confirmed deployment with this template. -Everything works correctly.


Ram bug

[HDS ::ffff:<IP_ADDRESS>] Recording download stream 1 is still awaiting generator although stream was closed 10s ago! This is a programming mistake by the camera implementation which prevents freeing up resources.
Rpi 4b crashes after a few days because memory is filled up... could it be because of this? Only in the latest versions

I’ve got this too. It’ll open a new instance of ffmpeg on my Mac every time this error occurs and so I’ve ended up having to kill 15-20 ffmpeg processes at once to free up memory

I'm also having this issue and have many ffmpeg processes stuck running.

Duplicate of https://github.com/potmat/homebridge-google-nest-sdm/issues/150


Multiadmin creates a server folder called 0 from time to time with only log files in it

Is this still an issue?

Yes.

What's in your config?
Have you tried my 3.0.0 test version on Discord?

I have not tried 3.0.0, I don't use any custom MA config settings.

Can you list the name of the subdirectories within your servers folder? I'm wondering if you have a space or something that could possibly cause the name to be read wrong?

I'm not sure if the text file being there would cause issue, I'd definitely suggest trying my MultiAdmin 3.0.0 version


Load PSFunction for GetRedirectedUrl

Update manifest for Microsoft as an initial test only.

Manifest version 6.5.1 created


v2.0 Glorified Wishlist

separated out from v1.6 wishlist
v2.0 stuff
Do these in the v1.5-maintenance branch (touches engine)

[ ] Image Editor should be using WSIImage for the generic IO.
[ ] Premultiplied alpha (MUST consider effect on image editor, audit the universe, etc.)

"Helpfully," moving Image Editor to WSIImage conveniently sidesteps this problem. Define WSIImage as being straight-alpha, and IImage as being premultiplied.
Expanded BadGPU's Texture Conversion Engine. ( https://github.com/20kdc/gabien-common/commit/bcaacc89ae9bb10872dd50ff5ca449d38de0543d )

"Accelerator"

[ ] Layout Cleanup: UIFlowLayout
[ ] Layout Cleanup: Actually use UIFlowLayout
[ ] Layout Cleanup: "Scroll-less Stack" (for items that will always be hosted within an SVL; skips stuff)
[ ] Scroll layouts that don't consider elements not on-screen right now
[ ] (far-fetched) GaBIEn UI Designer: Is it possible?

"Pizzazz"

[ ] Symbols should be using PVA

"Black-Hole Data Compression" (Point of no return - past this point, merging v1.6 changes into v2.0 will become very hard)

[ ] Replace MagicalBinder with either 'advanced' DM paths or just dedicated schema elements on a case by case basis
[ ] RevertibleIRIO: Additional interface to create a shallow savestate of this IRIO and to restore from savestate
[ ] All concrete IRIOs report to an IO session manager, a dummy will exist for independent IRIOs / Out Of App IO / etc.
[ ] Nearly every piece of code in the entire project that writes to an IRIO needs to establish a session
[ ] Concrete IRIO reporting needs to store enough data to REVERT CHANGES!!! IO session manager can choose to store this data
[ ] Draw the rest of the owl

"Forge"

[ ] Componentize UIMapView services (StuffRenderer etc.)

New backends should be able to add and pull services from StuffRenderer independently of the rest of R48 code. Think dependency injection, but, like, without the injection.

[ ] Make UIMapView replacable - a new backend should be able to just throw it all out, if necessary

"Atom"

[ ] Datum 100% of SDBOldParser

A reminder: it's okay to be explicit in the Java-side of the interface because macros or such can clean it up.

[ ] Delete SDBOldParser
[ ] Implement a library in D/MVM for better JSON access using macros
[ ] RMMV: Schema
[ ] RMMV: System
[ ] RMMV: Rendering

Writing this down here because it might be useful:
It might be an idea to have a dedicated "patch" object. These will be needed for undo anyway, and also can be used to batch the changes for undo/redo and do all sorts of useful stuff. The patch can then be "submitted" to a central object which can filter it down to the IRIOs. The main thing to worry about, then, is preventing writing patches "early", somehow (while also still having that as a transitionary feature or for special cases).
Patch objects also need to maintain IRIO identity, somehow.


Add interface guidelines for section intro content length

Adds content length guidance and do's and don'ts for section intro.
Docs preview

@danielguillan Minor comment on something unrelated to this change, but in the SectionIntro guidelines is the text in the images, which seem to be incorrectly justified. Maybe a Figma thing as it doesn't happen in React.


Abort fetching component for route: "/"

Need more details on this.  How are you running the application to generate this error, etc.


Documentation:  Using Comment blocks in functions

Please select a category the issue is focused on?
Function Documentation
Let us know where something needs a refresh or put your idea here!
It could be advantageous for developers to have commented blocks of code for future developers making updates.  These comment blocks could point out salient features of the code and/or give a more detailed explanation of how the code works/processes.  This would be seen by developers  or by users inspecting the code on github.
We would like to establish a common way to use these comment blocks in our code.
DoD:
Programming strategy has recommended best practice for using comments blocks in code.
@sgorm123 Does this capture our discussion yesterday?

@bms63 , @sgorm123 , I am not sure what you have discussed. I have added a "Comments" section in the programming strategy (see linked PR).
Could you have a look?

@bms63 , should we remove the "release Q4" label? Or do you think we have an agreement until next week?

Maybe, let's try.


Minimize cicd_setup.sh now that lots of tooling configs are checked in

This will streamline GitHub Actions to not run the entire Copier routine, now that most necessary configs are present. It will just have to install the Python dependencies and run the appropriate tool.

It will probably be necessary to check in the requirements in .tooling as well, if we want to avoid Copier usage in CICD. It may be possible to have those requirements files intentionally overlooked by Dependabot by explicitly specifying which requirements to look for (just those in root).


kde-dolphin: Add version 22.12.2-1828

Closes #9801

[x] I have read the Contributing Guide.

/verify

/verify

/verify


Added spec for destroy functionality

This PR fixes #62 adds-spec-to-test-Observable-destroys-correctly
yarn test output :

@GabrielCTroia made the changes

Hey @vinayakhegde1 I'm about to merge this, but it seems like the first commit you made is not signed. Could you please sign it using this tutorial https://docs.github.com/articles/about-gpg/

@GabrielCTroia i tried using ssh but still getting unverified idk what wrong i did :(

@GabrielCTroia i tried using ssh but still getting unverified idk what wrong i did :(

Hmm, this is what it says

If you've done it I can merge it like this, it's just that I think github won't be able to track your contribution for Hactoberfest without it 😔

@GabrielCTroia I'll ask someone on discord if anyone can help

@GabrielCTroia i think the issue is that i cloned the project using ssh key which is why i am getting an error let me try i think i have to create a pr again lol

@GabrielCTroia oh my lord it's done now 🧐

Hi @vinayakhegde1, thank you so much for your effort with the signing commits – it's such a pain I know :(!
I was ready to merge this but it seems there are some issues now with the code. Could you please do a rebase off of the current main (there's been some refactoring)?

Quick rebase guide in case you haven't done it before:

make sure you pull the latest main from origin
go back to your branch and run git rebase main
if there are any conflicts fix them, but there shouldn't be. The only change was with the onUpdate method which is what fails atm
once you rebased you can run yarn build-all-libs to see if everything works
you need to push your code again, but by force this time using git push -f from your branch

See here a more in-depth tutorial on rebasing https://www.freecodecamp.org/news/the-ultimate-guide-to-git-merge-and-git-rebase/

@GabrielCTroia okay no issue I'll check the tutorial

Hello @GabrielCTroia I tried my best but  I was unable to resolve the issue at this time sorry for the inconvenience . I tried to change the onupdated to onupdate but I'm finding hard to understand the git rebase I fixed the conflicts manually but still couldn't solve the actual issue

Hello @GabrielCTroia I tried my best but I was unable to resolve the issue at this time sorry for the inconvenience . I tried to change the onupdated to onupdate but I'm finding hard to understand the git rebase I fixed the conflicts manually but still couldn't solve the actual issue

Hey @vinayakhegde1 no worries. Do you need me to take over this, or do you want to do a bit of pair programming one of these days?
Let me know what would work best for you and thank you! 🙏


Allow the user to specify individual credentials on the command line

e.g.
docker app install --credential name=somevalue bundle.json

Credentials added with --credential always come after those added with
--credential-set (irrespective of the order on the command line).
A credential specified with --credential cannot override any previous
credential, including those specified in a credential set.
The test bnudle used is based on
https://github.com/deislabs/example-bundles/blob/0e8af9a2f1270bd72045a515637a432e74743d5d/example-credentials/bundle.json
But with cnab/example-credentials:latest → a digested ref (with the digest I
pulled today)
Signed-off-by: Ian Campbell<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

This is the basics, but I'm going to look at implementing support for --credential name=@file to read from file (like `curl has) and will add that here.

I added a commit to allow --credential name=@file.
I'm not 100% sure about this, especially the UX complexity needed to allow literal strings which start with @ (see the comment). It might be better to have a separate --credential-file name=file thing, but then we get into a complicated discussion about the precedence/ordering of --credential-set, --credential and --credential-file and how they interact.

Maybe the answer to "then we get into a complicated discussio" is a custom flag.Var compatible variable which can accumulate all of --credential-set, --credential and --credential-file into one place and preserve the order they appeared on the command line such that we can then do the more logical/expected thing and apply them in the order they are given.

I am not sure about the "@" syntax. Something that might be used a lot (I think) is exec instead of reading a file (e.g. for executing a gcp/aws/azure CLI tool for obtaining a short lived token). This is already supported in credential-sets, and I suppose also with doing things like --credential "name=$(awscli get-token ...)".

Exec instead of reading from a file is handled by the shell and not the tool I think (maybe it's different on windows?).
I think the right thing to do is just drop the @ syntax, you can always use --credential foo=<(/some/file) (or --credential foo=$(cat /some/file))

OK, dropped the final commit in favour of recommending the use of the shell syntax.
I need to look at why the linter in complaining.

Linter fixed.

There's a conflict, please rebase 🦁

@silvin-lubecki rebase, dropped that blank line and fixed a random bug I spotted while refactoring during the rebase (see the new first commit)

Tests are failing
=== RUN   TestCredentials/missing
    --- FAIL: TestCredentials/missing (0.42s)
        commands_test.go:465: assertion failed:
            --- expected
            +++ actual
            @@ -1,2 +1,2 @@
            -bundle requires credential for secret2
            +bundle requires credential for secret3

Urk, it passed on the other CI. It must be somehow non-deterministic (not sure how I missed that!). I guess there is a map in there somewhere. Will see what I can do!

Hm, from running:
e2e$ DOCKERAPP_BINARY=../bin/docker-app DOCKERCLI_BINARY=../bin/docker-linux go test -test.run TestCredentials/missing -test.v -test.count=100 .

It seems to have a ~8% failure rate (I'd have guessed either 50% or 33%) I guess that's why I didn't see it.
It's easy enough to fix -- I'll just make sure only one credential is missing.

Fixed, it survived the -test.count=100 rune from above.


Display of clinvar variants is broken

Describe the bug
The plot is on the variants page but should be on genes. Also, displays nothing and not all exons.
To Reproduce
Steps to reproduce the behavior:

Go to https://reev.cubi.bihealth.org/variant/chr17:43063903:G:T/grch38
See plot from first screenshot

Expected behavior
Should display something similar to second screenshot.
Screenshots
REEV

ClinVar

Additional context
N/A

dupe of #118


[Bug] Hero section is covered by the nav bar

Contact Details
<EMAIL_ADDRESS>What happened?
A bug happened! Hero section is covered by the nav bar
Version
0.1.0rc (Default)
What browsers are you seeing the problem on?
No response
Relevant log output
No response
Contribution Guidelines

[X] I have gone through the contribution guidelines

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Sure, go ahead. @ShakthiW

Hey @ShakthiW ,Any Update?

As you have not responded we will close this issue?


[IMPROVE] Change backup save popup

Please change the "use skip instead" pop up to a small pop(same as copying address) up instead to a pop up that needs to be acknowledged.

QA done.


Release istio.yaml to simplify the installation.

Fixes  https://github.com/knative/docs/issues/2166.
hack/release.sh creates a file named istio.yaml so that users can do kubectl apply -f istio.yaml.
It is vastly inferior to using istioctl, but at least it is consistent and as easy as kubectl apply -f contour.yaml
Docs change: https://github.com/knative/docs/pull/3151
/assign @mattmoor @tcnghia
/hold

Ping.
/cc @nak3 @arturenault

Ping.
/cc @nak3 @arturenault

/lgtm

/lgtm

@JRBANCEL please unhold when you are OK.

@JRBANCEL please unhold when you are OK.

/hold cancel

/hold cancel


proposal: net: Listener.Close should not return until the socket is really closed

What version of Go are you using (go version)?
1.9
Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
linux/amd64
Proposal
I'm taking TCPListener as an example, but I'm pretty sure the issue applies to UDP and Unix domain sockets as well. TCPListener.Close is documented as "Close stops listening on the TCP address." However, Close() does not guarantee that the address is safe to listen on again. This is because if a concurrent goroutine is in the middle of an Accept() call on the same listener, it will hold an additional reference, via an fdmutex readLock, to the underlying file descriptor. Consequently, in the typical case, Close() will merely decrement the reference count and return without actually calling close(2) on the file descriptor.
Because the runtime sets SO_REUSEADDR on all its listen sockets, the address will be free for bind(2) again immediately after the close(2) system call returns. But since close(2) will not execute until both Close() and Accept() return, a synchronization primitive (e.g., a chan or a sync.WaitGroup) is currently required in order to produce the necessary happens-before relationship to safely create a new TCPListener.
Here's a test case (adapted from one suggested by @davecheney on the golang-nuts list):
https://gist.github.com/slingamn/3b0f81169de6578c732ec279828c4866
This case will reliably panic with: panic: listen tcp :6502: bind: address already in use.
The proposal is that all the Listener types affected by this issue should perform this synchronization automatically in their Close methods. This would (at least on POSIX platforms) make it safe to re-listen on an address immediately after Close.
Here are some reasons in support of this change:

The present behavior is counterintuitive because it contradicts the behavior of the underlying, eponymous system calls. (On Linux, with SO_REUSEADDR set, the address is available immediately after close(2) returns; any concurrent accept(2) call will fail with EBADF. This behavior is arguably being simulated, inaccurately, by the polling layer, which does not actually do a blocking accept(2).)
The present behavior is a source of race conditions. If the time.Sleep() call is deleted from the above test case, the program reliably executes without a panic, even when built with -race. It's easy to write code that appears to work, but has a lurking race.
The present behavior is a source of confusion. Here's one example, which includes a workaround that either never worked, or does not work under the current runtime.
Althought "happens-after both Accept() and Close() return" is currently a sufficient condition to safely listen on the address again, this is not clearly specified in the documentation; it seems more like an implementation detail than anything else. It is not clear that future versions of the runtime will behave the same way.
The change appears to have no serious implications for backwards compatibility or performance (since closing a Listener is a relatively uncommon operation, relative to, e.g., accepting new connections).

Thanks very much for your time.

Sorry --- did anyone have thoughts on this?

Proposal reviews are done approximately weekly.  When this one will be reviewed depends on the overall load.
My initial reaction is that this seems reasonable, but what is special about TCPListener?  Currently I believe that for all the net types with a Close method the Close method returns only with a promise that the socket will be closed when all pending I/O is complete or times out.  Should we change all of the Close methods to wait until the socket descriptor is actually really closed?

Thanks for the clarification --- I was confused because the latency of the review process in practice often outperforms the specification :-) (This seems to be a common issue in systems design, e.g., O_PONIES.)
In my opinion, TCPListener, UDPListener, and UnixListener are all special because their file descriptor is associated with a unique resource --- the address they were bound to with bind(2) --- that will not be released until close(2) is called. (Normally, the resource being held is not unique --- something like an ephemeral port, or just the entry in the file descriptor table. It is less important to know exactly when such a resource has been released.)
This was my intention with the original proposal title of "Listener.Close() should not return until the underlying address is freed". The goal is to have Listener.Close reclaim the address so that it can be bound again; the fact that this can only be accomplished via close(2) is more of a detail.

It's not clear to me if this should be restricted to listeners. It's plausible that other special fds might also exist and that we should instead make sure that when any fd Close returns, the underlying close(2) system call has returned.
It's then not clear to me if this would potentially cause any deadlocks by making Close wait for pending I/O to be aborted, and that pending I/O might take a long time.
Or maybe we should do this for all fds we poll, since at least there we (think we) know how to abort pending I/O promptly.

I think it would definitely help to enumerate any other cases that might be "special"; thus far I can only think of listeners.
It seems like an implementation at the poll / fdMutex level should be deadlock-free, because the fdMutex semaphores are the "innermost" synchronization primitives held on those code paths. It also seems like the code shouldn't have to wait for any blocking I/O calls to complete, just for other goroutines to wake up from waitRead and waitWrite and realize that Close is trying to close the socket? But this in itself could conceivably have an impact on performance for some workloads.

Per discussion with @ianlancetaylor let's just try making internal/poll's Close do this for all file descriptors and back down to Listeners only if we find some reason to do so.


Nix the welcome popup

Closes #4325.

I don't understand this error:
The command "LD_LIBRARY_PATH=/usr/local/lib make bgrun test doc -j2" exited with 2..

It means the test run failed, and there should be a more specific traceback further up in the log output.
The problem here is that we need to remove the tests for the welcome popup. :)

Python is grouchy, isn't it?

@mattbk Well, in all fairness, we do ask it to be grouchy. ☺


Department based colours

Describe the feature
With the addition of the new live map, it would be a nice feature if we could set a colour that the units would appear as on the live map if they're in that department.
This would allow us to quickly distinguish units on the map and would also provide a colour that could be used in the API to set unit blips within the game too.
Additional Context
No response

This won't be possible currently


Replace many impls of (Add|Mul|AddAssign|MulAssign)<Self> with derive macros

The derive macros defer to the versions implemented on Self-type references.
This eliminates a lot of the impl boilerplate (& might go away when Rust figures out how to to autoref/deref on operators).
Hopefully this also serves as inspiration for extension of the approach to Sub, Neg ...

@Pratyush At the end of the day, this PR is pretty much exactly auto_impl specialized to the std::ops::(Add|...) traits, triggered on the struct rather than on the trait. It's a very generic approach that I'm happy taking in the direction that's the most useful.
Would you mind opening (two) issues fleshing out your thinking?

Superseded by https://github.com/scipr-lab/zexe/pull/98


Revert "Add official govulncheck action to Go Tests workflow (#28456)"

This reverts commit a9a0f8dbfca2166cfdf0e13731c3646622438955.
v1.0.1 wasn't on the allowlist and got blocked immediately.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @damccorm
lesson learned on the allowlist versioning

v1.0.1 was allowlisted and passes, closing


[Feature request] new integration for mercury parser

Hi there,
Postlight has open sourced mercury parser api, it comes with many pre-defined scrapping rules, therefore, I'd like to request it to be integrated into miniflux.
It lives as a standalone microservice, just like Wallabag. However, instead of sending out the content, it modifies the existing content, this is the part that stops me (not a go dev) from developing it.
I've made a dockerized version of the api if you want a test.
Cheers,
Henry

8215f4817d6a6080a93b9b444ad072cb105fbd8a
I try implementing mercury parser API support. But I seem that there are too many conflicts to make a pull request. I can make a pull request if repository owner like.

I would like to avoid external dependencies as much as possible. I would rather accept pull-requests to improve the builtin scraper/readability feature: https://github.com/miniflux/miniflux/blob/master/reader/readability/readability.go

I stumbled across this while looking into integration within Miniflux (my feed reader, where i send most of my articles to wallabag).
https://github.com/HenryQW/mercury-parser-api
Usage seems pretty simple, you just send a URL via a get request to the container and it returns a well parsed article.

Closing as won't fix.


import sbmlutil throws errors in some cases (particularly on Google colab)

This is probably due to the import sbmlutil statement in types.pyx. Changing this to the usual importing style in other bioscrape modules (for example: import bioscrape.sbmlutil) should fix this. Creating this issue to track this bug.

Fixed with #25


Open in external editor fails

When pressing e I'm getting the following warning, and the process never completes.
/1ib/python3.9/site-packages/euporie/commands/base.py:165: RuntimeWarning: coroutine 'edit_in_external_editor' was never awaited
self.handler()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

euporie 1.3.2, OSX,  export EDITOR=nvim

Hi!
I've fixed this in the dev branch here: https://github.com/joouha/euporie/commit/a740a7e6bbeeb912158d60fbc26f589cccdf8933
I'll make a new release tomorrow which includes this change

I've released v1.4.0 with the fix :+1:


Update setup guide for 0.70 and 0.71 to node 16

version 0.70 of react-native added a .node-version file specifying Node version 16: https://react-native-community.github.io/upgrade-helper/?from=0.69.9&to=0.70.0
0.70 and 0.71 docs still had version 14 listed, this updates those values.
/docs folder already lists 16 as changed here: https://github.com/facebook/react-native-website/pull/3580

0.70 and 0.71 docs still had version 14 listed, this updates those values.

Those docs are correct as 14 was the minimum supported version for 70 and 71 (16 is recommended).


Issue when formatting scenario outline examples

Hi and thanks for your project which seems to be promising !
I started to play with it and faced to my first issue when I don't have any feature description line and also on the alignment of scenario outline examples.
If you take a look at my feature
Feature: Test Welcome page

    Scenario Outline:
        When I navigate in <locale> language
        Then I should see "<message>"

        Examples:
            | locale | message                           |
            | fr     | Bienvenue %USERNAME%.             |
            | de     | Herzlich Willkommen %USERNAME%.   |
            | ar     | مرحبا %USERNAME%                  |
            | ja     | ようこそ %USERNAME%                |

When I apply a check or fix command it formats the feature like the following :
Feature: Test Welcome page

    Scenario Outline:
        When I navigate in <locale> language
        Then I should see "<message>"

        Examples:
          | locale | message                         |
| fr     | Bienvenue %USERNAME%.           |
| de     | Herzlich Willkommen %USERNAME%. |
| ar     | مرحبا %USERNAME%                |
| ja     | ようこそ %USERNAME%                 |

As you can see, it created 2 extra empty lines between Feature and Scenario Outline sections, and failed on example lines.
I'm using Windows, don't know if it could be related.
Thanks for your help !

@tifabien are you using windows new line char at the end of lines?

I'm using \n (LF) chars indeed. Could it be problem?

@tifabien no. I was not be able to reproduce the problem here coping and pasting the code above. Could you send me the file in attach?

I'm not able to send you the file right now but will send you monday morning.
Btw, I ran also your unit tests which failed too. Weird as they passed with Travis...

@tifabien weird indeed. please, send me more information about your environment and the file on Monday.

Hi @malukenho
As promise you'll find attached my feature file (I renamed the file into .txt extension as .feature is not supported by GH)
welcome.txt
Think the error could be on PHP_EOL chars as my feature has LF chars (to be consistent with my project) but PHP_EOL is CRLF in Windows.

@tifabien could you please check on dev-master if everything is OK?

@malukenho I tested on dev-master and it works like a charm :+1: Thanks very much !
Btw I got a question regarding the 2 empty lines between Feature and Scenario sections. Shouldn't we have only one extra line?

@tifabien actually it's expecting only one line (at least for me), look at https://github.com/malukenho/kawaii-gherkin/blob/master/tests/functional/check-file-can-format-table-using-unix-line-endings.phpt#L26

@malukenho I tested on both Windows and Mac and fix command adds 2 empty lines between Feature and Scenario sections. Think you should only have one empty line between the two section.
Is it voluntary you did not add the Feature section in your https://github.com/malukenho/kawaii-gherkin/blob/master/tests/functional/check-file-can-format-table-using-unix-line-endings.phpt test file?

Well, the Feature session is not showed up in the diff when you run the check command, I'll testing the diff output on console.
Sorry for the lack of time, I'll fix it during the day.

@malukenho I just checked your fix and it seems working well !
Thanks a lot !

@tifabien nice \o/
I'll tag kawaii-gherkin by tomorrow, so you can use the new version. Thank you by report the bug :dancer:


Update

Very cool! I'd prefer to have the sensor selectable though, perhaps by passing it in as an argument when instantiating. Any thoughts on that?

I am writing a competition entry on this project and will modify code to add a sensor parameter.

Great! I'm going to close this old pull request - open a new one when you're ready.


Unsupported platform for Apple Sillicon

I found this problem when trying to run it on my MacBook Pro (with M1 Pro)

Thank you. Should be fixed in 0.5.3, can you confirm it?


Add support for Magento 1 projects

Add support for Magento 1 projects

Recently used the project to setup Magento 1.14 site on my local.
Had to do a couple of changes and the setup manually, but it did work.
docker-compose.yml
version: "3"

services:

  app:
    image: mage2click/magento-nginx:1.15-alpine
    ports:
      - "80:8000"
      - "443:8443"
    depends_on:
      - db
      - phpfpm
    volumes: &appvolumes
      - ~/.composer:/var/www/.composer:delegated
      - appdata:/var/www/html
      - sockdata:/sock

  db:
    image: percona:5.7
    ports:
      - "3306:3306"
    env_file: env/db.env
    volumes:
      - dbdata:/var/lib/mysql

  phpfpm:
    image: mage2click/magento-php-versions:5.6-fpm
    depends_on:
      - db
    volumes: *appvolumes

volumes:
  appdata:
  dbdata:
  sockdata:

nginx.conf
root $MAGE_ROOT;

client_body_buffer_size 8k;
client_max_body_size 10M;
client_header_buffer_size 1k;
large_client_header_buffers 4 16k;

if ($server_port = 80) { set $httpss off; }

location /
{
    index index.html index.php; ## Allow a static html file to be shown first
    try_files $uri $uri/ @handler; ## If missing pass the URI to Magento's front handler
    expires 30d; ## Assume all files are cachable
}

## These locations would be hidden by .htaccess normally
location /app/                { deny all; }
location /includes/           { deny all; }
location /lib/                { deny all; }
location /media/downloadable/ { deny all; }
location /pkginfo/            { deny all; }
location /report/config.xml   { deny all; }
location /var/                { deny all; }

## Disable .htaccess and other hidden files
location  /.
{
    return 404;
}

## Magento uses a common front handler
location @handler
{
    rewrite / /index.php;
}

## Forward paths like /js/index.php/x.js to relevant handler
location ~ .php/
{
    rewrite ^(.*.php)/ $1 last;
}

## Execute PHP scripts
location ~ .php$
{
    ## Catch 404s that try_files miss
    if (!-e $request_filename) {
        rewrite / /index.php last;
    }

    expires off; ## Do not cache dynamic content
    fastcgi_pass fastcgi_backend;
    fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name;
    #fastcgi_read_timeout 1500;
    fastcgi_param MAGE_RUN_CODE default; ## Store code is defined in administration > Configuration > Manage Stores
    fastcgi_param MAGE_RUN_TYPE store;
    fastcgi_param HTTPS on;
    fastcgi_param HTTP_X_FORWARDED_PROTO https;
    fastcgi_buffer_size 32k;
    fastcgi_buffers 4 32k;
    include fastcgi_params; ## See /etc/nginx/fastcgi_params
    fastcgi_param SERVER_PORT 443;
}

Had to change the mutagen sync configs as well and removed the vendor sync
bin/mutagen
mutagen create \
        --label=mage2click-sync=html \
        --default-file-mode=0644 \
        --default-directory-mode=0755 \
        --default-owner-beta=app \
        --default-group-beta=app \
        --sync-mode=two-way-resolved \
        --ignore=/.idea \
        --ignore-vcs \
        ${CONTAINER_SRC_SYNC_DIR}/app docker://$(docker-compose ps -q phpfpm|awk '{print $1}')/var/www/html/app/

Hope it helps someone, trying to setup M1 on there local using the project

Hey @atishgoswami,
Check also feature/magento-1 branch and M1.md for setup information 😉

Silly me, should have checked the branches.
Will test it out thanks @shkoliar


Unable To Deploy NitroAdjudicator or EthAssetHolder

Describe the bug :bug:
While attempting to set up a test harness, I import the NitroAdjudicatorArtifact and EthAssetHolderArtifact from the package, and use them to create a truffle-contract object. Attempts to deploy said contracts fail, however, with the following error message: Error: Contract error: contract binary not set. Can't deploy new instance..
Looking at the package directory, this appears to be correct. The contract artifacts included in the package declare bytecode as a string, but do NOT include the actual bytecode, making it impossible to deploy.
To Reproduce
You can see my code linked below. If you'd like to test it out, do so by cloning the repo, fetching and switching to the appropriate branch, and navigating to the channel-testing directory. Then run npm install and npm test.
Sorry, this is very much "proof-of-concept" right now and the code is messy.
Instantiating the Truffle Contract object:
https://github.com/ScopeLift/scorched-earth/blob/force-moveable/channels-testing/test/scorched-earth-test.ts#L21
Attempting to deploy the contract, where the error occurs.
https://github.com/ScopeLift/scorched-earth/blob/force-moveable/channels-testing/test/scorched-earth-test.ts#L67
Expected behavior
A new contract instance should be deployed to my local testnet.
Environment (if no logs are attached)
macOS 10.14 with npm 6.13.4 and node v12.16.1

Hi @apbendi thanks for your interest in our project.
I checked out your repo and ran npm install as you suggested. I see the contract artifacts under node_modules and I am seeing the actual bytecode included under the bytecode key.  Could you double check and confirm that it those values are missing from your installation?
I also ran npm test and see your error. I'll dig in some more to try and work out what's going wrong.

I got your test to pass by doing this:
const NitroAdjudicator = contract.fromABI(
  ContractArtifacts.NitroAdjudicatorArtifact.abi,
  ContractArtifacts.NitroAdjudicatorArtifact.bytecode
);
const EthAssetHolder = contract.fromABI(
  ContractArtifacts.EthAssetHolderArtifact.abi,
  ContractArtifacts.EthAssetHolderArtifact.bytecode
);

Let me know if this works for you!

Hey @geoknee, that did the trick! Thanks a lot for looking into this so quickly. Not sure why the bytecode doesn't appear to be there in the module directory, but there must be some explanation, because it's working. Regardless, I appreciate your prompt feedback :)


improve LIKE regex performance up to 12x

Which issue does this PR close?
While working on #6118, I realised we can significantly improve the Regex branch of Predicate for LIKE and ILIKE queries.
Rationale for this change
Significant improve in performance of LIKE queries:

Running this script
#!/usr/bin/env bash
set -ex
if [ "$#" -ne 2 ]; then
  echo "Usage: $0 branch-name bench-filter"
  exit 1
fi
BRANCH_NAME=$1
BENCH_FILTER=$2
git checkout master
rm -rf target/criterion
cargo bench -p arrow --bench comparison_kernels -F test_utils -- --save-baseline master $BENCH_FILTER
git checkout $BRANCH_NAME
cargo bench -p arrow --bench comparison_kernels -F test_utils -- --save-baseline $BRANCH_NAME $BENCH_FILTER
critcmp master $BRANCH_NAME

With ./bench.sh improve-like-regex like on c2-standard-8 GCP instance.
with hackstack length 4 (default)
+ critcmp master improve-like-regex
group                                              improve-like-regex      master
-----                                              ------------------      ------
ilike_utf8 scalar complex                          1.17    358.8±5.76µs    1.00    307.0±1.44µs
ilike_utf8 scalar contains                         1.00  1161.5±17.13µs    1.31   1516.2±4.97µs
ilike_utf8 scalar ends with                        1.05    246.9±2.88µs    1.00    234.6±0.59µs
ilike_utf8 scalar equals                           1.16    249.1±3.29µs    1.00    214.3±0.51µs
ilike_utf8 scalar starts with                      1.11    279.7±3.69µs    1.00    251.4±0.45µs
ilike_utf8_scalar_dyn dictionary[10] string[4])    1.00     49.1±0.67µs    1.79     88.0±0.20µs
like_utf8 scalar complex                           1.08    311.4±1.78µs    1.00    288.5±0.81µs
like_utf8 scalar contains                          1.01    376.5±1.01µs    1.00    374.0±0.66µs
like_utf8 scalar ends with                         1.15    268.8±0.52µs    1.00    234.7±0.90µs
like_utf8 scalar equals                            1.25    271.4±0.61µs    1.00    217.4±0.45µs
like_utf8 scalar starts with                       1.00    234.5±0.79µs    1.08    253.9±1.13µs
like_utf8_scalar_dyn dictionary[10] string[4])     1.00     49.2±0.24µs    1.79     88.2±0.42µs
like_utf8view scalar complex                       1.00    169.4±1.01ms    3.13    529.6±3.51ms
like_utf8view scalar contains                      1.00    384.0±0.43ms    1.04    400.1±0.58ms
like_utf8view scalar ends with                     1.00     53.6±0.19ms    1.10     59.0±0.20ms
like_utf8view scalar equals                        1.03     30.3±0.08ms    1.00     29.4±0.10ms
like_utf8view scalar starts with                   1.00     55.0±0.24ms    1.01     55.5±0.20ms
nilike_utf8 scalar complex                         1.16    358.4±5.66µs    1.00    307.9±1.05µs
nilike_utf8 scalar contains                        1.00  1160.2±15.34µs    1.31   1517.2±5.90µs
nilike_utf8 scalar ends with                       1.05    246.6±1.00µs    1.00    234.5±0.51µs
nilike_utf8 scalar equals                          1.16    249.1±3.31µs    1.00    214.2±0.42µs
nilike_utf8 scalar starts with                     1.11    279.8±3.45µs    1.00    251.5±0.73µs
nlike_utf8 scalar complex                          1.09    313.4±4.82µs    1.00    287.7±0.75µs
nlike_utf8 scalar contains                         1.01    376.0±1.23µs    1.00    373.7±0.58µs
nlike_utf8 scalar ends with                        1.15    268.8±1.15µs    1.00    234.5±0.39µs
nlike_utf8 scalar equals                           1.25    271.6±3.42µs    1.00    217.3±0.48µs
nlike_utf8 scalar starts with                      1.00    234.9±2.93µs    1.08    253.7±0.48µs

with haystack length 0..400
As described in https://github.com/apache/arrow-rs/pull/6128#issuecomment-2254513573
+ critcmp master improve-like-regex
group                                              improve-like-regex      master
-----                                              ------------------      ------
ilike_utf8 scalar complex                          1.00      2.4±0.06ms    9.45     23.0±0.08ms
ilike_utf8 scalar contains                         1.00      3.8±0.04ms    6.02     22.9±0.06ms
ilike_utf8 scalar ends with                        1.00   970.7±43.73µs    1.21  1171.2±51.28µs
ilike_utf8 scalar equals                           1.00   626.4±24.91µs    1.21   760.1±36.51µs
ilike_utf8 scalar starts with                      1.00  1025.3±22.76µs    1.12  1150.5±83.44µs
ilike_utf8_scalar_dyn dictionary[10] string[4])    1.79     88.2±0.17µs    1.00     49.3±0.14µs
like_utf8 scalar complex                           1.00  1707.9±24.96µs    12.76    21.8±0.09ms
like_utf8 scalar contains                          1.00      5.3±0.03ms    1.01      5.4±0.02ms
like_utf8 scalar ends with                         1.02   480.0±15.99µs    1.00   472.4±11.46µs
like_utf8 scalar equals                            1.00     90.7±0.24µs    1.39    126.4±0.18µs
like_utf8 scalar starts with                       1.00    496.5±9.34µs    1.03   509.9±14.96µs
like_utf8_scalar_dyn dictionary[10] string[4])     1.79     87.9±0.14µs    1.00     49.1±0.15µs
like_utf8view scalar complex                       1.00    178.5±0.35ms    3.00    535.2±3.98ms
like_utf8view scalar contains                      1.04    400.0±0.42ms    1.00    385.9±0.75ms
like_utf8view scalar ends with                     1.04     56.8±0.19ms    1.00     54.8±0.23ms
like_utf8view scalar equals                        1.00     29.8±0.09ms    1.02     30.5±0.13ms
like_utf8view scalar starts with                   1.00     55.3±0.21ms    1.02     56.1±0.27ms
nilike_utf8 scalar complex                         1.00      2.4±0.07ms    9.58     22.9±0.09ms
nilike_utf8 scalar contains                        1.00      3.8±0.04ms    6.02     22.8±0.10ms
nilike_utf8 scalar ends with                       1.00   980.9±20.47µs    1.05  1034.4±26.55µs
nilike_utf8 scalar equals                          1.00   651.9±41.19µs    1.07   698.9±24.53µs
nilike_utf8 scalar starts with                     1.00  1034.2±18.20µs    1.12  1162.5±52.16µs
nlike_utf8 scalar complex                          1.00  1696.5±43.69µs    12.86    21.8±0.09ms
nlike_utf8 scalar contains                         1.00      5.3±0.01ms    1.02      5.4±0.03ms
nlike_utf8 scalar ends with                        1.00   468.4±16.73µs    1.04   485.3±18.10µs
nlike_utf8 scalar equals                           1.00     90.7±0.15µs    1.39    126.5±0.23µs
nlike_utf8 scalar starts with                      1.00    498.8±9.86µs    1.04   521.1±12.16µs

What changes are included in this PR?
Changed regex_like so that leading and trailing % are simply removed instead of being replaced with ^.* and .*$ respectively, so LIKE '%foo%' becomes Regex('foo') instead of Regex('^.*foo.*$').
Are there any user-facing changes?
Since we had .dot_matches_new_line(true) I believe this is the exact same behaviour as we had before, just much faster.

Nice find, surprised it is faster (would have thought it would be optimized away).

Ye I was surprised too. It makes sense that if you don't have .dot_matches_new_line(true), you need to iterate through all of .* to check validity.

I know one of the ClickBench queries has a giant LIKE that dominates performance on several -- e.g. https://github.com/apache/datafusion/blob/ea8c287855ae799573a56697db63e7b16edf3a37/benchmarks/queries/clickbench/queries.sql#L21-L24

Since that will already use Predicate::Contain, that case should be improved by #6128, not this.
This case will help with more complex LIKE queries, and ILIKE contains queries.


Facing issue in tabris serve

Problem description
i am just going to start development in tabrisjs, i am using mac environment
when i am going to do tabris serve  it will run sucessfully but when i am going to see my app in browser it will give me error You don't have authorisation to view this page

Expected behavior

Environment

Tabris.js version: 2.6.1
Device: Chrome
OS: Mac OS 10.12.6

Code snippet
// A minimal, *self-contained* code snippet to reproduce the problem:

You need to put the app in the Tabris.js Developer app, not a browser.  You can download the app here:
App Store
Play Store
Microsoft Store

i am started app in local pc and as per documentation in website

In the Developer App, go to the URL tab, enter the URL printed by the CLI

Your browser is not the developer app.  Download one of the three aforementioned apps

Nowadays a QR code will be shown in the browser when navigating to a Tabris CLI server URL. Let us know if you still have this issue @jd048.


Adds "repo guessing" to the docker name cache

When the name cache is checked for the image name for a source ID
and there's no image name known,
it gets all tags from an appropriate repo.
If it doesn't know of an appropriate repo,
it now guesses, based on the algorithm that
the docker builder uses to generate a repo.
TECHOPS-1314

Current coverage is 59.90% (diff: 91.30%)

Merging #234 into master will increase coverage by 0.10%

@@             master       #234   diff @@
==========================================
  Files           128        128
  Lines          6792       6804    +12
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           4062       4076    +14
+ Misses         2368       2367     -1
+ Partials        362        361     -1

Powered by Codecov. Last update ce04132...9c65993


buildbot: 2.9.2 -> 2.10.0

Motivation for this change
Updates buildbot to the latest version.
cc @nand0p @ryansydnor
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108145 run on x86_64-linux 1

9 packages failed to build and are new build failures:

buildbot
(python38Packages.buildbot)
buildbot-full
(python38Packages.buildbot-full)
buildbot-ui
(python38Packages.buildbot-ui)
python37Packages.buildbot
python37Packages.buildbot-full
python37Packages.buildbot-ui

21 packages built:

buildbot-worker (python38Packages.buildbot-worker)
python37Packages.buildbot-pkg
python37Packages.buildbot-plugins.console-view
python37Packages.buildbot-plugins.grid-view
python37Packages.buildbot-plugins.waterfall-view
python37Packages.buildbot-plugins.wsgi-dashboards
python37Packages.buildbot-plugins.www
python37Packages.buildbot-worker
python38Packages.buildbot-pkg
python38Packages.buildbot-plugins.console-view
python38Packages.buildbot-plugins.grid-view
python38Packages.buildbot-plugins.waterfall-view
python38Packages.buildbot-plugins.wsgi-dashboards
python38Packages.buildbot-plugins.www
python39Packages.buildbot-pkg
python39Packages.buildbot-plugins.console-view
python39Packages.buildbot-plugins.grid-view
python39Packages.buildbot-plugins.waterfall-view
python39Packages.buildbot-plugins.wsgi-dashboards
python39Packages.buildbot-plugins.www
python39Packages.buildbot-worker

Builds failures are because of cfn-lint failing.

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108145 run on x86_64-linux 1

9 packages failed to build and are new build failures:

buildbot
(python38Packages.buildbot)
buildbot-full
(python38Packages.buildbot-full)
buildbot-ui
(python38Packages.buildbot-ui)
python37Packages.buildbot
python37Packages.buildbot-full
python37Packages.buildbot-ui

21 packages built:

buildbot-worker (python38Packages.buildbot-worker)
python37Packages.buildbot-pkg
python37Packages.buildbot-plugins.console-view
python37Packages.buildbot-plugins.grid-view
python37Packages.buildbot-plugins.waterfall-view
python37Packages.buildbot-plugins.wsgi-dashboards
python37Packages.buildbot-plugins.www
python37Packages.buildbot-worker
python38Packages.buildbot-pkg
python38Packages.buildbot-plugins.console-view
python38Packages.buildbot-plugins.grid-view
python38Packages.buildbot-plugins.waterfall-view
python38Packages.buildbot-plugins.wsgi-dashboards
python38Packages.buildbot-plugins.www
python39Packages.buildbot-pkg
python39Packages.buildbot-plugins.console-view
python39Packages.buildbot-plugins.grid-view
python39Packages.buildbot-plugins.waterfall-view
python39Packages.buildbot-plugins.wsgi-dashboards
python39Packages.buildbot-plugins.www
python39Packages.buildbot-worker

Builds failures are because of cfn-lint failing.

2.10.0 has been released, so I have updated the PR. The NixOS test succeeds locally with a cached cfn-lint.
cc @makefu because I had to update sqlalchemy-migrate.

2.10.0 has been released, so I have updated the PR. The NixOS test succeeds locally with a cached cfn-lint.
cc @makefu because I had to update sqlalchemy-migrate.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108145 run on x86_64-darwin 1

13 packages failed to build and are new build failures:

buildbot: log was empty
(python38Packages.buildbot): log was empty
buildbot-full: log was empty
(python38Packages.buildbot-full): log was empty
buildbot-ui: log was empty
(python38Packages.buildbot-ui): log was empty
buildbot-worker: log https://hastebin.com/raw/ezagedeleh
(python38Packages.buildbot-worker): log https://hastebin.com/raw/ezagedeleh
python37Packages.buildbot: log https://hastebin.com/raw/ezagedeleh
python37Packages.buildbot-full: log https://hastebin.com/raw/ezagedeleh
python37Packages.buildbot-ui: log https://hastebin.com/raw/ezagedeleh
python37Packages.buildbot-worker: log https://hastebin.com/raw/ibasuleseg
python39Packages.buildbot-worker: log https://hastebin.com/raw/ucemekulof

21 packages built:

python37Packages.buildbot-pkg
python37Packages.buildbot-plugins.console-view
python37Packages.buildbot-plugins.grid-view
python37Packages.buildbot-plugins.waterfall-view
python37Packages.buildbot-plugins.wsgi-dashboards
python37Packages.buildbot-plugins.www
python37Packages.sqlalchemy_migrate
python38Packages.buildbot-pkg
python38Packages.buildbot-plugins.console-view
python38Packages.buildbot-plugins.grid-view
python38Packages.buildbot-plugins.waterfall-view
python38Packages.buildbot-plugins.wsgi-dashboards
python38Packages.buildbot-plugins.www
python38Packages.sqlalchemy_migrate
python39Packages.buildbot-pkg
python39Packages.buildbot-plugins.console-view
python39Packages.buildbot-plugins.grid-view
python39Packages.buildbot-plugins.waterfall-view
python39Packages.buildbot-plugins.wsgi-dashboards
python39Packages.buildbot-plugins.www
python39Packages.sqlalchemy_migrate

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108145 run on x86_64-darwin 1

13 packages failed to build and are new build failures:

buildbot: log was empty
(python38Packages.buildbot): log was empty
buildbot-full: log was empty
(python38Packages.buildbot-full): log was empty
buildbot-ui: log was empty
(python38Packages.buildbot-ui): log was empty
buildbot-worker: log https://hastebin.com/raw/ezagedeleh
(python38Packages.buildbot-worker): log https://hastebin.com/raw/ezagedeleh
python37Packages.buildbot: log https://hastebin.com/raw/ezagedeleh
python37Packages.buildbot-full: log https://hastebin.com/raw/ezagedeleh
python37Packages.buildbot-ui: log https://hastebin.com/raw/ezagedeleh
python37Packages.buildbot-worker: log https://hastebin.com/raw/ibasuleseg
python39Packages.buildbot-worker: log https://hastebin.com/raw/ucemekulof

21 packages built:

python37Packages.buildbot-pkg
python37Packages.buildbot-plugins.console-view
python37Packages.buildbot-plugins.grid-view
python37Packages.buildbot-plugins.waterfall-view
python37Packages.buildbot-plugins.wsgi-dashboards
python37Packages.buildbot-plugins.www
python37Packages.sqlalchemy_migrate
python38Packages.buildbot-pkg
python38Packages.buildbot-plugins.console-view
python38Packages.buildbot-plugins.grid-view
python38Packages.buildbot-plugins.waterfall-view
python38Packages.buildbot-plugins.wsgi-dashboards
python38Packages.buildbot-plugins.www
python38Packages.sqlalchemy_migrate
python39Packages.buildbot-pkg
python39Packages.buildbot-plugins.console-view
python39Packages.buildbot-plugins.grid-view
python39Packages.buildbot-plugins.waterfall-view
python39Packages.buildbot-plugins.wsgi-dashboards
python39Packages.buildbot-plugins.www
python39Packages.sqlalchemy_migrate

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108145 run on x86_64-linux 1

1 package marked as broken and skipped:

python39Packages.sqlalchemy_migrate

1 package failed to build and are new build failure:

pytrainer: log was empty

29 packages built:

buildbot (python38Packages.buildbot)
buildbot-full (python38Packages.buildbot-full)
buildbot-ui (python38Packages.buildbot-ui)
buildbot-worker (python38Packages.buildbot-worker)
python37Packages.buildbot
python37Packages.buildbot-full
python37Packages.buildbot-pkg
python37Packages.buildbot-plugins.console-view
python37Packages.buildbot-plugins.grid-view
python37Packages.buildbot-plugins.waterfall-view
python37Packages.buildbot-plugins.wsgi-dashboards
python37Packages.buildbot-plugins.www
python37Packages.buildbot-ui
python37Packages.buildbot-worker
python37Packages.sqlalchemy_migrate
python38Packages.buildbot-pkg
python38Packages.buildbot-plugins.console-view
python38Packages.buildbot-plugins.grid-view
python38Packages.buildbot-plugins.waterfall-view
python38Packages.buildbot-plugins.wsgi-dashboards
python38Packages.buildbot-plugins.www
python38Packages.sqlalchemy_migrate
python39Packages.buildbot-pkg
python39Packages.buildbot-plugins.console-view
python39Packages.buildbot-plugins.grid-view
python39Packages.buildbot-plugins.waterfall-view
python39Packages.buildbot-plugins.wsgi-dashboards
python39Packages.buildbot-plugins.www
python39Packages.buildbot-worker

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108145 run on x86_64-linux 1

1 package marked as broken and skipped:

python39Packages.sqlalchemy_migrate

1 package failed to build and are new build failure:

pytrainer: log was empty

29 packages built:

buildbot (python38Packages.buildbot)
buildbot-full (python38Packages.buildbot-full)
buildbot-ui (python38Packages.buildbot-ui)
buildbot-worker (python38Packages.buildbot-worker)
python37Packages.buildbot
python37Packages.buildbot-full
python37Packages.buildbot-pkg
python37Packages.buildbot-plugins.console-view
python37Packages.buildbot-plugins.grid-view
python37Packages.buildbot-plugins.waterfall-view
python37Packages.buildbot-plugins.wsgi-dashboards
python37Packages.buildbot-plugins.www
python37Packages.buildbot-ui
python37Packages.buildbot-worker
python37Packages.sqlalchemy_migrate
python38Packages.buildbot-pkg
python38Packages.buildbot-plugins.console-view
python38Packages.buildbot-plugins.grid-view
python38Packages.buildbot-plugins.waterfall-view
python38Packages.buildbot-plugins.wsgi-dashboards
python38Packages.buildbot-plugins.www
python38Packages.sqlalchemy_migrate
python39Packages.buildbot-pkg
python39Packages.buildbot-plugins.console-view
python39Packages.buildbot-plugins.grid-view
python39Packages.buildbot-plugins.waterfall-view
python39Packages.buildbot-plugins.wsgi-dashboards
python39Packages.buildbot-plugins.www
python39Packages.buildbot-worker

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108145 run on x86_64-linux 1

1 package marked as broken and skipped:

python39Packages.sqlalchemy_migrate

1 package failed to build and are new build failure:

pytrainer: log was empty

29 packages built:

buildbot (python38Packages.buildbot)
buildbot-full (python38Packages.buildbot-full)
buildbot-ui (python38Packages.buildbot-ui)
buildbot-worker (python38Packages.buildbot-worker)
python37Packages.buildbot
python37Packages.buildbot-full
python37Packages.buildbot-pkg
python37Packages.buildbot-plugins.console-view
python37Packages.buildbot-plugins.grid-view
python37Packages.buildbot-plugins.waterfall-view
python37Packages.buildbot-plugins.wsgi-dashboards
python37Packages.buildbot-plugins.www
python37Packages.buildbot-ui
python37Packages.buildbot-worker
python37Packages.sqlalchemy_migrate
python38Packages.buildbot-pkg
python38Packages.buildbot-plugins.console-view
python38Packages.buildbot-plugins.grid-view
python38Packages.buildbot-plugins.waterfall-view
python38Packages.buildbot-plugins.wsgi-dashboards
python38Packages.buildbot-plugins.www
python38Packages.sqlalchemy_migrate
python39Packages.buildbot-pkg
python39Packages.buildbot-plugins.console-view
python39Packages.buildbot-plugins.grid-view
python39Packages.buildbot-plugins.waterfall-view
python39Packages.buildbot-plugins.wsgi-dashboards
python39Packages.buildbot-plugins.www
python39Packages.buildbot-worker

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 108145 run on x86_64-linux 1

1 package marked as broken and skipped:

python39Packages.sqlalchemy_migrate

1 package failed to build and are new build failure:

pytrainer: log was empty

29 packages built:

buildbot (python38Packages.buildbot)
buildbot-full (python38Packages.buildbot-full)
buildbot-ui (python38Packages.buildbot-ui)
buildbot-worker (python38Packages.buildbot-worker)
python37Packages.buildbot
python37Packages.buildbot-full
python37Packages.buildbot-pkg
python37Packages.buildbot-plugins.console-view
python37Packages.buildbot-plugins.grid-view
python37Packages.buildbot-plugins.waterfall-view
python37Packages.buildbot-plugins.wsgi-dashboards
python37Packages.buildbot-plugins.www
python37Packages.buildbot-ui
python37Packages.buildbot-worker
python37Packages.sqlalchemy_migrate
python38Packages.buildbot-pkg
python38Packages.buildbot-plugins.console-view
python38Packages.buildbot-plugins.grid-view
python38Packages.buildbot-plugins.waterfall-view
python38Packages.buildbot-plugins.wsgi-dashboards
python38Packages.buildbot-plugins.www
python38Packages.sqlalchemy_migrate
python39Packages.buildbot-pkg
python39Packages.buildbot-plugins.console-view
python39Packages.buildbot-plugins.grid-view
python39Packages.buildbot-plugins.waterfall-view
python39Packages.buildbot-plugins.wsgi-dashboards
python39Packages.buildbot-plugins.www
python39Packages.buildbot-worker