[Doc Improvement][TeamsFx collaboration][2440380]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md
98
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 185907a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md
98
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit b542a6a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md
96
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 7fcdee9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 209a90f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md
96
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit e493e5f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 31b7c56:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md
94
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit ef22ca2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 145335c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md
94
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md
94
11
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md
94
10
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit d294c18:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 09343e9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md

link
:warning:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f49fd65:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md

link
:warning:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1749689:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit f49bc8c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md
96
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/toolkit/TeamsFx-collaboration.md
96
9
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 89f8e30:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/TeamsFx-collaboration.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update specs2-cats, specs2-core to 4.10.2

Updates

org.specs2:specs2-cats
org.specs2:specs2-core

from 4.6.0 to 4.10.2.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.specs2" } ]

labels: library-update, semver-minor

Superseded by #115.

Superseded by #115.


Abstract caching from http frontend

This is basically just moving things around, but the http front end no longer hard depends on the file caching. Some other components like template.go still do, but once this is done, we can have different cache drivers.

neat


Anyone who would kindly share their training code?

Since it seems that the complete training code will never be released, is there anyone who would kindly share their working code?
Thanks in advance

I am also looking for the training code.

https://www.kaggle.com/code/daggerx/modnet?scriptVersionId=107316373
You'll need to modify some stuff a bit but mostly this is the code that I'm currently using for training.

https://www.kaggle.com/code/daggerx/modnet?scriptVersionId=107316373 You'll need to modify some stuff a bit but mostly this is the code that I'm currently using for training.

how good were teh results you got @yashsandansing

@skyler14 sorry for the late reply. I did try experimenting with the training but it went horribly wrong with my training loop. The images had random blobs in the center that was considered as background. So the results were worse than this pre-trained model. I suspect my training loop had some critical errors that I missed
Considering that I had very little experience back then, the code was very bad. I will try to create a PR for this as soon as I can

https://www.kaggle.com/code/daggerx/modnet?scriptVersionId=107316373 You'll need to modify some stuff a bit but mostly this is the code that I'm currently using for training.

Hi, do you only have one picture per training batch? Because I noticed that in your data processing section, the size of the images is not consistent and you should not be able to train batches.
May I ask you with solve this problem?

https://www.kaggle.com/code/daggerx/modnet?scriptVersionId=107316373 You'll need to modify some stuff a bit but mostly this is the code that I'm currently using for training.

I tried, but couldn't train normally


Add handling for rules that are both deprecated and redirected

Follow up to #9689 adds tooling for warning on rules that are deprecated because we replaced them with another rule.
Previously we would display no warnings for deprecated redirected rules because the redirect took place before the warnings could be displayed.
As with the other changes, this is immediately used for testing. Deprecates all of the PGH rules and adds redirects where relevant.
Closes https://github.com/astral-sh/ruff/issues/8931

Eh we have a problem here where redirected rules are being treated as stable when in preview... I need to investigate further.


BUG FIX: generate both TryFrom for Robj and &Robj for ndarray view 1.

Will try to address #500

I think the bug in #500 occurred because none of the tests try to create the ndarray view from an Robj, but &Robj.
Thus I added a test for that. Feel free to code-golf the test.

For some reason, I had convinced myself that @multimeric wrote this code. But that's not the case.
Thus I'll just merge now that we have one approval.

Closes #500


Update the column headers in the peakgroups search output

BUG DESCRIPTION
Problem
Column headers in the peakgroups search results (both basic and advanced) use Caroline's Processed tissue data.  They should use the terms from issue #107.  They could also be informed by the peakgroups tab of customer-desired consolidated view formats
Steps to reproduce

Go to http://<IP_ADDRESS>:8000/DataRepo/search_peakgroups/ and search for tissue is brain

Current behavior
Names used in Caroline's Processed tissue data
Expected behavior
Use the terms from issue #107 -  TraceBase Terms and Definitions.
Suggested Change
Simple edit of search_peakgroups and the basic search templates.
Comment
Change the column headers from Caroline's terms to agreed upon terms (issue #107)
Originally posted by @hepcat72 in https://github.com/Princeton-LSI-ResearchComputing/tracebase/pull/127#discussion_r662395704

ISSUE OWNER SECTION
Assumptions

List of assumptions made WRT the code
E.g. We will assume input is correct (explaining why there is no validation)

Requirements

List of conditions to be met for the feature
E.g. Every column/row must display a value, i.e. cannot be empty

Limitations

A list of things this work will not fix
E.g. Getting edge case X to work requires too much effort and will not be
fixed in this effort.

Affected/Changed Components

Files
Environment variables
External executables
Database tables
Cron job settings
Etc.

DESIGN
GUI Change description
Describe changes the user will see.
Code Change Description (Pseudocode optional)
Describe code changes planned for the fix.
Tests
A test should be planned for each requirement (above), where possible.

Dupe of #147


Error when using EscPosEncoder

Hi, iam trzing to use EscPosEncoder for ionic in my ionic 5 app, but iam not able to make it work. I succesfully installed package, import it in my provider, but when i try to use it i get "Unknown Codepage" error, even if iam entering right string for codepage:
`import EscPosEncoder from 'esc-pos-encoder-ionic';
...
testEncode(){
let encoder=new EscPosEncoder();
let result=encoder.codepage('cp852')
.text('Iñtërnâtiônàlizætiøn')
.codepage('cp936')
.text('简体中文')
.encode();
console.log(result);
}
`
Any ideas whats wrong? When i try to run it on mobile device, i get "Runtime compiler is not loaded" Error, when iam trying to access page, to which is my printService provider injected(ESCPosEncoder is imported inside that provider). Iam using ionic 5 with angular 8.2.14

Hello Vertex05,
Try to initialize encoder first
...
const result = encoder.initialize().codepage('cp852');
...


Move OffsetPaginatedListDto Client interface to be part of pagination module (#114)

What was changed? Why is this necessary?

Moved OffsetPaginatedListDto interface to be part of the pagination module for (#114)

How to test

This is bare minimum acceptable testing

[ ] ./mvnw clean install -U

I think we need to add this to the changelog?

@venki09 added to the change log now https://github.com/cerner/beadledom/pull/116/commits/abba5dbff4b79663669c9879b5fdfa19d8c88b82#diff-4ac32a78649ca5bdd8e0ba38b7006a1e


[MRG] Ordered_gradients now in SplittingContext

Closes #22
This PR:

Allocates ordered_gradients and ordered_hessians in SplittingContext instead of for each node.
Puts sum_gradients and sum_hessians in SplittingContext (no performance or memory gain from this, just cleaner code IMHO)
Parallelizes the population of ordered_gradients and ordered_hessians

I don't see any clear performance gain on the higgs boson benchmark but it doesn't seem to hurt at all, memory usage will surely be better now.

I like the approach. I think the memory benefit will only be visible when recycle the sample TreeGrower instance (and therefore the same SplittingContext instance) over and over for all the trees.

Merged! Thanks @NicolasHug.


fix image plot bug

Thank for pointing out this problem. As you may have found out, the input matrix need to be transposed to be positioned correctly. I will also update/rotate the example file durer.txt (which is actually now a 600 * 900 matrix) accordingly.

@jzstark I am not sure your new implementation is correct either. Try the following code:
let z0 = Mat.create 100 100 200. in
let z1 = Mat.zeros 100 100 in
let z = Mat.((z1 @|| z0) @= (z1 @|| z1)) in
Plot.image z;;

The right square should be top right. As I said before, it is flipped! So transpose will not solve the problem.
Please make sure your code well tested before PR, thanks.


Update of Readme.md for page viewing

Seeing that the web site only had a simple title, I have decided to keep it a little longer so that it is not empty.

Your readme is just a copy of the readme from SpotX for Windows.
This repository was created to establish a unified, mirrored address for both Bash and PowerShell


fix find_package

fix #219, fix #225, fix #244, fix #188

@cmazakas
We discussed this briefly after Peter's comment. Any opinions?

#244 helped me notice the tests target is not namespaced and therefore ambiguous.
This creates problems even though it won't recreate the target because some other script might try to create a target with the same name afterward.
I don't know if this tests name is just a coincidence or purposeful.

I looked at other libraries. find_package(Boost) and install are common in libraries that have been accepted, including boost.beast.
In any case, this PR should be extra helpful during the review so people don't have to patch the boost tree to use the library and don't keep creating more similar issues about integration. Patching the boost tree is not even an option sometimes.
This PR also considers Peter's comment about how libraries shouldn't install anything when not root project. Christian also already had a look at it. We discussed it on Slack.

What happens when you build the Visual Studio 2019 solution?

What happens when you build the Visual Studio 2019 solution?

I didn't have any problems, but it would be good if you could check because I'm still confused about the custom toolchains.

gtg


Ability to create runnable bundles

hivew should be able to take a directory full of runnable sources (a folder per runnable), build them all into WASM packages, and bundle them all into a .tar.gz or .zip

Initial version is merged


Web login overlap fix

I've fixed the resizing issues. Simple enough to review and merge by anyone.

When I resize it, the description goes to the bottom and falls off the picture.

It needs to go below, that's how I'm countering the resizing. The alternative of shrinking text would result in non readable text cause it would go too small🤷🏾♂...


Hot-reload causes Story (and thus widgets) to be rebuilt / reinitialised

It's unclear if this is intentional, but when hot-reloading, the Stories are rebuilt causing any Stateful widgets to lose their state and reload.
return Storybook(
      stories: [
        Story(
          name: 'Test,
          builder: (context) {
            return TestWidget();
          }
        )
      ]
);

class TestWidget extends StatefulWidget {
  const TestWidget({super.key});

  @override
  State<TestWidget> createState() => _TestWidgetState();
}

class _TestWidgetState extends State<TestWidget> {
  @override
  initState() {
    super.initState();
    print('initState');
  }

  @override
  Widget build(BuildContext context) {
    return const Placeholder();
  }
}

Hot-reload is meant to preserve state, so is this a bug? or intentional feature to help in testing stateful widgets?

You know what, this might be a problem I've caused outside of Storybook. Sorry for the noise.


Failure to rebind control channel address after worker recovery

A recovering worker intermittently fails to bind the control channel address.
This is different than the errors we saw because of #1982 #1832, since those were at startup, where worker addresses weren't assigned. In this new error, the address has already been assigned, and it's upon recovery that we see the error.
Circle CI log: https://circleci.com/gh/WallarooLabs/wallaroo/561?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
Command: make integration-tests-testing-correctness-tests-log_rotation resilience=on debug=true
Error snippet:
worker1
****RESILIENCE MODE is active****
****This is an enterprise feature. You may need to obtain a paid usage agreement to use this feature in production. See the Wallaroo Community License at https://github.com/WallarooLabs/wallaroo/blob/master/LICENSE.md for details, and also please visit the page at http://www.wallaroolabs.com/pricing****
****CLUSTERING MODE is active****
****This is an enterprise feature. You may need to obtain a paid usage agreement to use this feature in production. See the Wallaroo Community License at https://github.com/WallarooLabs/wallaroo/blob/master/LICENSE.md for details, and also please visit the page at http://www.wallaroolabs.com/pricing****
****AUTOSCALE MODE is active****
****This is an enterprise feature. You may need to obtain a paid usage agreement to use this feature in production. See the Wallaroo Community License at https://github.com/WallarooLabs/wallaroo/blob/master/LICENSE.md for details, and also please visit the page at http://www.wallaroolabs.com/pricing****
||| Resilience directory: /tmp/res-data|||
||| Log-rotation: true|||
Recovering from recovery files!
recover_worker_names: initializer
recover_worker_names: worker1
Restarting a listener ...

metrics outgoing connected
worker1 control: unable to listen on (:)
This should never happen: failure in /root/project/lib/wallaroo/ent/network/control_channel_tcp.pony at line 105

unable to recreate, marking as resolved


MOB-M-1: Default Hardcoded HMAC Key

Analysis of the Attack
Blackberry note the default environment settings file contain a hardcoded HMAC key string. It is common pattern to see default values changed, therefore this may result in “insecure by default” deployments.
Recommendation
• Do not provide a default value for items that require entropy
• Ideally generate these values within provisioning scripts
• Ensure guidance is provided within the documentation on the critical nature of the value and
how it should be managed. This may include references to secret material management service APIs.

@obrien-j any suggestions here?
The HMAC is in the .env file and gets pulled into the app.

Works for me.


Event Request codeunit 99000856 "Planning Transparency" OnPublishSurplusOnBeforePlanningElementInsert

Hello, could you please add IsHandled to exist event OnPublishSurplusOnBeforePlanningElementInsert before PlanningElement.Insert();?
if not IsHandled then // new change
PlanningElement.Insert();

[IntegrationEvent(false, false)]
    local procedure OnPublishSurplusOnBeforePlanningElementInsert(var UntrackedPlanningElement: Record "Untracked Planning Element"; var IsHandled: Boolean) // new change
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10846.


Events entity management

[ ]  Create Event entity
[ ]  Create Events Category entities
[ ]  Create Events List page
[ ]  Create Event single page
[ ]  Update Event Button on Homepage


Terrafrom Cloud Run Basic Initialization

Service account terraform docs:

for setting up compute service account using terraform: https://cloud.google.com/compute/docs/access/create-enable-service-accounts-for-instances#console
for setting up kubernetes service account using terraform: https://medium.com/the-telegraph-engineering/binding-gcp-accounts-to-gke-service-accounts-with-terraform-dfca4e81d2a0


Default HACS repo

awaiting branding approval

awaiting approval https://github.com/hacs/default/pull/1793


Output location change

I have the following output template
<script>
// my custom code from the template that needs to be loaded after webpack
</stript>

<script>
//from webpack
</stript>

is there a way to change the ordering so that  the webpack build isn't always at the end

Any updates, feedback?

Any updates, feedback?

https://github.com/GlebFeklistov/webpack-html-generator, please try this. Its solved this? problem

I have the following output template
<script>
// my custom code from the template that needs to be loaded after webpack
</stript>

<script>
//from webpack
</stript>

is there a way to change the ordering so that the webpack build isn't always at the end

Try this module https://github.com/glebfeklistov/webpack-html-template, his solved you problem, look jsChunks.

thx


Adds Registry HKCU/HKLM Autorun Persistence

Created SharpSploit.Persistence.Autorun - a class for abusing the Windows Registry to establish peristence.
It simply drops a new ExpandedString Registry Value into Software\Microsoft\Windows\CurrentVersion\Run, in either HKCU or HKLM.
Two Unit Tests are included for testing the addition of Values in HKCU and HKLM.

Note: I had to upgrade the MSTest NuGet packages to 1.4.0 for them to run on my machine.

Any feedback, alterations, suggestions etc are welcome.

Occurs to me that perhaps modules like this should utilise functions from https://github.com/cobbr/SharpSploit/blob/master/SharpSploit/Enumeration/Registry.cs instead of re-inventing them?

@rasta-mouse I liked your idea to utilize functions in the SharpSploit.Enumeration.Registry class, and made that conversion. Would you mind giving this a quick test to make sure it still performs like you expect?


Bump the version of the allowed umbrella chart for upgrade when a release/x.y branch is created

It is easy to miss this when a release branch is cut. We do not have automated tests for umbrella chart upgrade at the moment. This change should bring this change to notice (if the version is not bumped correctly).

Could you please remind me, why do we need to check the umbrella chart version again?
The upgrade-job is tied to a single version of Mayastor. It might be that a user uses this upgrade-job with a different version of Mayastor from a different openebs/openebs chart. The version 'lock' prevents this.

Could you please remind me, why do we need to check the umbrella chart version again?

The upgrade-job is tied to a single version of Mayastor. It might be that a user uses this upgrade-job with a different version of Mayastor from a different openebs/openebs chart. The version 'lock' prevents this.

What happens if we release a new umbrella chart, with no mayastor changes?

The upgrade-job is not prepared to handle this. The new umbrella chart cannot be accommodated, with the way it is today. This is a bug.
I'll try to fix this. I'll try to remove this dependency on the version number.

This change is not required. It'd be better to verify the mayastor version attached to an installed umbrella chart release. Helm doesn't support viewing this information from the helm secret/configmap yet. Maybe this could resolve this. Alternatively, reading directly from the secret/configmap could be a good solution.


Fix Windows build & CI

What was changed

Fixed Windows build, Windows CI and lint issues
Why?

green checks
Checklist

Closes

How was this tested:

CI

Any docs updates needed?

still dealing with this failure https://github.com/temporalio/cli/actions/runs/5262862061/jobs/9512447848#step:5:154
go test succeeds when running locally on Windows, however not in Github Actions. Haven't found yet what causes this

sent one more blocker PR into Go SDK https://github.com/temporalio/sdk-go/pull/1140


Added Ability to save benchmark results to a text file for later comp…

I added the ability to save the benchmark results to a text file and wanted to share it with you guys, just in case you want to incorporate it.

In general this looks good, but I see too many unrelated changes.. Can you try to limit/revert these, then I can accept the PR.


crypto.randomBytes is not a function

When trying to create TFA QR code I get this error:
crypto.randomBytes is not a function     at Object.generateSecretASCII
How can I solve this?

I think you are trying to use this library in the browser. The library is only compatible with Node.js

I believe so, but it used to work.
Maybe you any idea how can I make it work again?

Maybe you used a bundler? Like webpack, webpack polyfills the Node APIs in the browser, so it should work with it.

We are using webpack but it still doesn't work. Maybe I should config something?

If you are on webpack 5 you need: https://www.npmjs.com/package/node-polyfill-webpack-plugin

I am still getting this error: [Vue warn]: Error in created hook (Promise/async): "TypeError: crypto.randomBytes is not a function"
But I am not sure what version of webpack we are using, we use it with Laravel


Forward return value from http.Server's listen() to allow chaining

When using express without express-ws, the following works:
const port = 80;
app
  .listen(port)
  .on('listening', () => {
    console.log(`listening on port ${port}...`);
  });

Patching express with express-ws breaks this, because listen() now returns undefined. For express' implementation of listen(), see here.
This PR simply forwards the return value from server.listen() to allow chaining calls again.

Hi @maxtruxa,
I agree that this is the way it should have worked all along. Didn't intend to change this behavior. Thanks a lot for fixing it! Merging right away.


nodenamenr servname provided, or not known

I following the tutorial here: https://serverless.com/blog/flask-python-rest-api-serverless-lambda-dynamodb/:
It was working wonderfully for me, but I've come back to it a few weeks later (all in git, so no changes) and I'm now getting the following error:
Traceback (most recent call last):
  File "/Users/aloughran/Code/node_modules/serverless-wsgi/serve.py", line 50, in <module>
    serve(*sys.argv[1:])
  File "/Users/aloughran/Code/node_modules/serverless-wsgi/serve.py", line 42, in serve
    use_evalex=True)
  File "/Library/Python/2.7/site-packages/werkzeug/serving.py", line 720, in run_simple
    s.bind((hostname, port))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 228, in meth
    return getattr(self._sock,name)(*args)
socket.gaierror: [Errno 8] nodename nor servname provided, or not known.

The problem is more than likely an issue with my configuration, but I'm lost on working out where the nodename/servname should be passed by the wsgi config, or what could be tripping me up.
Thanks in advance.

Ok, weirdly localhost had been removed from my /etc/hosts file.

@andylockran  - how did you solve it?


fix: adapt to use 4bytes address to dump more data

Hi !
First of all, thanks for the contribution.
My main concern with this PR is that the 4-byte read command (13h) is not available on all SPI EEPROMs.
I would suggest that you modify the PR to support both legacy read (03h) and extended address read (13h) so the script can work on both cases. Once done, I'll be happy to merge this.


FIX 406

Handled exceptions as done for get_role_managed_policy_data
Fixes: https://github.com/lyft/cartography/issues/406

I was only joking when I tagged you in that issue but thank you!

Was an easy fix :) didn't take long and happy to contribute to a project which we use 😄


Login not working

Desc:
When trying to login to the application i get an error
Replicate:
1.use chrome x86 v84.948
open new tab url : adjfl;ajdfladsjf
login user:
login pass:
click login button
expected result
should be able to see this page:

actual result:

issue fixed. you can continue testing


Proposed design changes for decoding

I've discussed the idea outlined below with a few people (in person at the Typelevel summit last week, etc.), but it's somewhat relevant to the plans in #226, so I decided it's time to go ahead open an issue for it.
Paul Chiusano has a blog post where he argues that cursors aren't the right abstraction for things like JSON decoding. They're too powerful—they provide modification operations that don't make sense at all in the context of decoding and navigation operations (moving up the tree) that are probably always a bad idea there.
So far I've stuck with Argonaut's cursor-based model for decoding because it's a simple solution if you want to be able to track history during decoding and already have a nice cursor implementation lying around. The full power of cursors is useful in non-decoding contexts, so we don't want to strip out the parts that are unnecessary for decoding, which means we'd need a new mechanism that looks a lot like a cursor without those parts. So far that hasn't seemed worth the effort.
I think that I'd like to make this change in circe 0.5. You'll still be able to construct decoders from HCursor => Decoder.Result[A], but the preferred route will be to use a new algebra that provides a more limited set of navigation operations. You build up your decoder using these operations and then interpret it into one of several contexts:

Option if you want fail-fast decoding with no history or position information.
Xor[DecodingFailure, ?] for fail-fast decoding with history / positions.
ValidatedNel[DecodingFailure, ?] for error accumulation with history / positions.

This has a handful of advantages. The first is just that as an abstraction it fits the problem more elegantly—it's less possible to construct nonsensical decoders (e.g. decoders that make modifications that will just be thrown away or decoders that snoop around higher up the document than the current focus).
The second advantage is that it supports potential optimizations that the current model doesn't. Most obviously, if you don't care about having position information to put in your error messages, you don't have to pay the cost of tracking history as your decoder moves around the document. It also may be possible to rearrange navigation operations to avoid unnecessary work (that's probably further down the line, though).
The goal would be to make this switch without breaking existing code (at least for a deprecation cycle), but it would be a major change, and some decoders you can write right now simply wouldn't be possible under the new model (only uselessly strange ones, I hope).
Does this seem reasonable for circe 0.6? Any objections or concerns?

We spoke about this offline at Typelevel Summit last week and I know I would be interested (hopefully others too) in what kind of optimizations would be possible here! Do I smell a new blog post?
All in all, it seems reasonable for an 0.5 cut. What would you call it if it's not so much a Cursor?

Sounds very nice to me. I've only needed fail-fast decoding without history on multiple occasions.

Both this proposal and #226 sound great

For what it's worth this is almost definitely happening in circe 0.10.0. I have an experiment that's 90%-ish source compatible, is slightly faster with like 30% fewer allocations, and supports the possibility of interpreters for non-circe ASTs or even stuff like BSON, so I'm pretty confident the idea is a good one.

Closing in cleanup run, If anyone cares about this, please comment and I'll reopen.


fix: pfe-navigtation-item shouldn't add duplicative event listeners

Fixes #869

Lying graph tells mischief


Remove vibe.d dependency: It's fetched even when unused

Package optional 1.2.1 depends optionally on vibe.d for the test configuration: One of optional's goals is good vibe.d-interop. There is no such dependency in release configuration.
As a result, even when we build package optional for release and not for testing, dub will nonetheless always fetch vibe.d and its dependency stdx-allocator.

The fetching of all dependencies of the optional-using program takes longer.
When a Linux distribution maintainer packages the optional-using program, he must separately package all dependencies. Reason: Most distributions forbid internet access when building a package from the recipe. Result: Extra workload for the maintainer.
The Linux distribution packaging becomes much fatter because vibe.d and its dependencies must be included to satisfy dub at build time. vibe.d is fat! Its source is 12 MB to 14 MB, the source comes with, e.g., libcrypto-1_1.dll and other such Windows binaries that make for 4 MB by themselves already.

The fundamental problem is in dub's design. Its only FAQ is: Why are dependencies downloaded that belong to configurations that are not being built? At dependency-downloading time, dub doesn't yet know which configuration we want.
Maybe the Linux distro packagers can mock vibe.d to satisfy dub's desire to fetch optional's unused dependency when building optional. But it feels like we should fix this before it comes to distribution. :-) Thus:

Can you remove optional's optional dependency on vibe.d?
Or can you move the vibe.d-dependent tests to a separate dub.json that sits in a subtree of optional and thus is ignored for scanning the dependencies? Then the main optional doesn't have to depend on vibe.d in any configuration, and dub will then be happy without vibe.d.

Sure! Can do number 2. And will do as soon as I get around to it.
As long as there’s a command line that can be run from root that runs all tests then I have no issues with having the vibed tests in a different dub.json

Hehe, immediate after the second ping 6 months after the first :p But I'll take compliment 😊


Implement to_be_radix builtin in the comptime interpreter

Problem
That intrinsic is missing from the comptime interpreter
Happy Case
to_be_radix can be used on a Field type in comptime
Workaround
None
Workaround Description
No response
Additional Context
No response
Project Impact
Blocker
Blocker Context
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response

Implemented here but this can be worked around by reversing in Noir for the time being now that it returns an array rather than a slice.


Deflake integration tests

How to categorize this PR?

/area testing
/kind flake
What this PR does / why we need it:

Gardenlet Shoot Care Suite.
We need to create the seed and project only once. This PR moves the seed and project creation from BeforeEach to BeforeSuite.

https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/7989/pull-gardener-integration/1662050474792062976
https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/7981/pull-gardener-integration/1661805577690419200
https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/7973/pull-gardener-integration/1661259252641042432

Before:
$ stress -p 32 ./test/integration/gardenlet/shoot/care/care.test
...
10m55s: 622 runs so far, 2 failures (0.32%)
11m0s: 628 runs so far, 2 failures (0.32%)
11m5s: 628 runs so far, 2 failures (0.32%)
11m10s: 638 runs so far, 2 failures (0.31%)

After:
$ stress -p 32 ./test/integration/gardenlet/shoot/care/care.test
...
17m50s: 1016 runs so far, 0 failures
17m55s: 1016 runs so far, 0 failures
18m0s: 1025 runs so far, 0 failures
18m5s: 1026 runs so far, 0 failures

Garden controller tests:
Fake waiting for components to be healthy by faking the until function in tests.

Before:
❯ stress -p 16 ./test/integration/operator/garden/garden.test
...
13m25s: 565 runs so far, 6 failures (1.06%)
13m30s: 565 runs so far, 6 failures (1.06%)
13m35s: 575 runs so far, 6 failures (1.04%)
13m40s: 580 runs so far, 6 failures (1.03%)

After
❯ stress -p 16 ./test/integration/operator/garden/garden.test
...
11m25s: 563 runs so far, 0 failures
11m30s: 568 runs so far, 0 failures
11m35s: 577 runs so far, 0 failures
11m40s: 577 runs so far, 0 failures
11m45s: 578 runs so far, 0 failures

Which issue(s) this PR fixes:
Fixes #7990
Special notes for your reviewer:
Release note:

NONE

Pod scheduling timeout.
/retest

/milestone v1.72

/retest


azure service discovery does not report public IP

Bug Report
What did you do?
Run azure service discovery
What did you expect to see?
A label with VM's public IP should be added to the target VMs
What did you see instead? Under which circumstances?
The label with public IP was missing
Environment

System information:
Linux 4.15.0-50-generic x86_64

Prometheus version:
prometheus, version 2.9.2 (branch: upstream-master, revision: d6a4daa26a861c8642dca467cc6afc450bbc6b2f)
go version:       go1.12.4

Prometheus configuration file:

# my global config
global:
  scrape_interval:     15s
  evaluation_interval: 30s
  # scrape_timeout is set to the global default (10s).

scrape_configs:
- job_name: service-azure
  azure_sd_configs:
    - environment: AzurePublicCloud
      authentication_method: OAuth
      subscription_id: xxxxxx
      tenant_id: xxxxxx
      client_id: xxxxxx
      client_secret: xxxxxx
      port: 9100

The label for public IP is not added because azure SDK does not populate PublicIPAddressPropertiesFormat on network interface request.
A simple workaround would be to add another remote API call to network.PublicIPAddressesClient.
However that will double number of remote API read operation and cause throttling of Azure Resource Manager.
I've opened an issue https://github.com/Azure/azure-sdk-for-go/issues/4829 for Azure SDK team.
Once addressed, I can proceed with fixing and resolving this issue.

is this not fixed with https://github.com/prometheus/prometheus/pull/5475 ?

@Deshke unfortunately not. Azure does not populate public IP in getNetworkInterfaceByID().
There was another related issue which I fixed in #5587

@dmitsh
I'm not familiar with Azure SDK, is it possible to get VM's FQDN for workaround?

@dmitsh
I'm not familiar with Azure SDK, is it possible to get VM's FQDN for workaround?

@silencev you may want to take a look at https://github.com/dmitsh/prometheus/blob/ds-up-azure-discovery-wip/discovery/azure/azure.go#L504
The result is of type network.Interface. FQDN could be retrieved by following Interface->InterfacePropertiesFormat->InterfaceEndpoint->InterfaceEndpointProperties->Fqdn

I'm using relabel for workaround now.
composing the FQDN my-cname.centralus.cloudapp.azure.com by CNAME tag and VM region
  - source_labels: [__meta_azure_machine_tag_CNAME, __meta_azure_machine_location]
    separator: .
    regex: (.+)
    replacement: ${1}${2}.cloudapp.azure.com:8080
    target_label: __address__

Please send us a PR with this feature, but if this lookup causes another RPC call to the API, we'd likely not add it because the Azure API limits are very low already and adding additional RPCs will make things worse.


Rendering trees & leaves

It seems that there is no way to render tree leaves in the usual way, using textures with alpha channel and writing depth when and only when pixels from texture are opaque.

You should be able to use any standard technique with a diffuse texture and define ALPHAMASK in your material definition in order to have it discard pixels with < 0.5 alpha. In the material .xml file, the line <shader psdefines="ALPHAMASK" /> should enable it.


Doubt regarding training data

In Table 2, it's mentioned that a total of 12.2M vision-text pairs are used. However, the GitHub repo shares 703K video-text and 558K image-text pairs; Can you share the missing pretraining data?

A similar mismatch is also noticed for finetuning data as well, would it be possible to share the entire training data?

Sorry for the confusion. We may have no plan to release our training data. In the README file, we just provided the pre-training and fine-tuning datasets from Video-LLaVA to demonstrate how to train a VideoLLM with our codebase.

Thanks for letting me know.


User Story #2 - Add landing page so that users can navigate to their destination page

Value Proposition
As a developer
I want to have a homepage
So that i can direct users around my site
Description

Acceptance Criteria

[ ] There are two different navigation elements which are displayed as buttons. Here you can choose between searching for a restaurant or adding a menu.
[ ] A lottie animation should be seen at first glance

Tasks

[ ] Create a new branch
[ ] Create a new landing page
[ ] Add lottie animation
[ ] Create two different buttons under the lottie animation

Complexity
M

Hi Kolja,
ich finde es sehr klar, was du erreichen möchtest.

Allerdings, wäre ich User deiner fantastischen App wüsste ich nicht, was in Deskription:  "extern und intern" gemeint ist Es sei denn, ich klicke und sehe und erfahre.
Deine User Story ,würde ich demnach auch etwas anpassen.

Ich freue mich schon auf deine App :-)

Hello Meral, thank you for your feedback. I will adapt the user story now.

Hey Kolja, I see you changed your description "external and internal " to "guest and owner" ... Wenn du heute etwas Zeit hast, dann lass uns kurz besprechen, was du erreichen willst.

Hi Kolja,
looks good!
I am not sure if as a user I would understand the difference between "guest" and "owner"... Maybe you could add each one small sentence like "You are hungry? Click here to browser through you favorite restaurants menus" (for the user)

Hello Claudia, thank you for your feedback. I will update the user story.


Update bug bounty relevant information

[x] Update bug bounty scope
[ ] Update bug bounty amount

High: 100k to 1000k
Medium: 10k to 50k (requires approval)
Low: 2k to 10k (requires approval)

[ ] Check that all links are working

The tag for 1.3.0 is still missing
The deployments for 1.3.0 in the Safe deployments repo are not final yet

[x] Update deployment related information (e.g. about custom networks)

@rmeissner I think the honey pot part of the bug bounty should be removed since there is no honey pot currently anymore. That Safe is now used for Defi^^


Add 5022 in load balancer

[Enter feedback here]
Hi Team,
I have worked on a case where customer has configured AG on FCI which they have spanned across two regions. Post creating load balancer with VNN they have noticed that the secondary region AG went in disconnecting mode. After doing various checks we figured out that 5022 wasn't reachable. To resolved this we have created a new load balancer rule with port 5022.
It's a suggestion to check it , if we can add that in document as well.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a9894346-d829-29f1-4ffb-3bdcf6bc99f9
Version Independent ID: 28d4ffb9-e681-82b8-1436-86ea3ede4b69
Content: Configure a load balancer & availability group listener (Azure portal) - SQL Server on Azure VMs
Content Source: azure-sql/virtual-machines/windows/availability-group-load-balancer-portal-configure.md
Service: virtual-machines-sql
Sub-service: hadr
GitHub Login: @tarynpratt
Microsoft Alias: tarynpratt

@Sweta020116
Thanks for your feedback! We will investigate and update as appropriate.

@Sweta020116
Thanks for your contribution. Please add your ideas in below link, so our production team can review it and update the same.
Ideas · Community (azure.com)


Update single column (or map update) doesn't work

GORM Playground Link
https://github.com/go-gorm/playground/pull/150
Description
Updating a single column by Update and UpdateColumn simply doesn't work. It returns an error: unsupported data type: map[<col_name>:<col_value>]. It also happens with Updates(map[string]interface{}{...})
This is not matching the function documentation and the official documentation (https://gorm.io/docs/update.html).

DB.Model(User{Model: gorm.Model{ID: user.ID}}).Update("name", "foo")


vivaldi cask errors with 403

#7664: $ brew cask install vivaldi
==> Downloading http://vivaldi.com/download/Vivaldi_TP2_<IP_ADDRESS>.dmg

curl: (22) The requested URL returned error: 403 Forbidden
Error: Download failed on Cask 'vivaldi' with message: Download failed: http://vivaldi.com/download/Vivaldi_TP2_<IP_ADDRESS>.dmg

Hi @chrisopedia just a guess here, but do you by any chance have a .curlrc file?  The output of brew doctor should warn of its presence (although the "test" suggested there isn't perfect).  I actually ran into this the other day when testing vivaldi, and removing the line referer = ";auto" from my .curlrc made everything work swimmingly.

I do have a .curlrc with that line.  Why would removing that fix this?

AFAICT because they designed it that way.  Running just curl on the download link should be a little more enlightening; It complains to me about cookies and I get a 1010 error, which apparently is specific to certain CloudFlare setups.  Googling will give more details, but this Stack Exchange answer goes through most of the reasons.

I don't have any .curlrc and having no issues with the mentioned URL at all:
 curl -I -L http://vivaldi.com/download/Vivaldi_TP2_<IP_ADDRESS>.dmg

HTTP/1.1 302 Found
Date: Wed, 18 Feb 2015 22:40:37 GMT
Content-Type: text/html; charset=iso-8859-1
Connection: keep-alive
Set-Cookie: __cfduid=d92f2049e9e3a20c80ea295ee0b76aba01424299237; expires=Thu, 18-Feb-16 22:40:37 GMT; path=/; domain=.vivaldi.com; HttpOnly
Location: https://vivaldi.com/download/Vivaldi_TP2_<IP_ADDRESS>.dmg
Vary: Accept-Encoding
CF-Cache-Status: EXPIRED
Expires: Thu, 19 Feb 2015 22:40:37 GMT
Cache-Control: public, max-age=86400
Server: cloudflare-nginx
CF-RAY: 1badba37ddd80b81-LHR

HTTP/1.1 200 OK
Server: cloudflare-nginx
Date: Wed, 18 Feb 2015 22:40:38 GMT
Content-Type: application/x-apple-diskimage
Content-Length: 76972530
Connection: keep-alive
Set-Cookie: __cfduid=de64223726da8ddb76aef990af1f118621424299238; expires=Thu, 18-Feb-16 22:40:38 GMT; path=/; domain=.vivaldi.com; HttpOnly
Last-Modified: Wed, 04 Feb 2015 10:58:52 GMT
ETag: "1ff5b3-49681f2-50e4112a68f2f"
CF-Cache-Status: HIT
Expires: Thu, 19 Feb 2015 22:40:38 GMT
Cache-Control: public, max-age=86400
Accept-Ranges: bytes
CF-RAY: 1badba3da0130a7e-LHR


Is there any way to achieve mult-lingual intent classification

Want to contribute to DeepPavlov? Please read the contributing guideline first.
What problem are we trying to solve?:
I am new to this repo. I am trying to solve the multi-lingual intent classifications for one of my chatbots. is there any way to achieve the same?

Hey @SAIVENKATARAJU ,
Could you describe your task in more details? Do you have specific intent dataset in mind?
We have a bunch of configs for text classification, for example, you can use insults_kaggle_bert_torch.
Define TRANSFORMER variable as bert-base-multilingual-cased and train the model with your intent dataset.

@SAIVENKATARAJU I see, do you use some specific intent dataset, what set of intents you are interested in?


[bug] Jumbo furnace doesnt keep JDT fuel canister in fuel slot

Jumbo Furnace version
v<IP_ADDRESS>
Minecraft Version
1.21
(Neo)Forge Version
21.1.58
Modpack & Version
Craftoria 1.3.2
Describe the issue
Jumbo furnace mod doesnt keep just dire things fuel canister in the fuel slots
Steps to reproduce

open the jumbo furnace
put JDT fuel canister in fuel slot
smelt something in the furnace
watch as JDT fuel canister moves to output in jumbo furnace

Expected behaviour
to stay put in fuel slot
Screenshots
javaw_AcLIGQDhVE.webm
Log files
none sadly as this isnt a crash
Additional information
it seems to work only once, then instantly puts it in the fuel slot, like in the video.

i cross posted this in JDT #178


Develop the Upcoming Event section on the About us page while also importing the Footer and subscribe section

https://www.figma.com/design/w1Hoj9ESFonR8tDl5WLedU/Event-Management?node-id=0-1&node-type=canvas&t=LaYd43Mtw6Tn6FYp-0

This has been worked on before

@nobledeveloper01 Thank you for pointing that out. I will close the issue rightaway


Sound while loading screen

Hello! I want to congrat you for your work, it is a very usefull plugin. I am trying to play music in loading screen, is there a way to do so? Thank you!

Hi @javiseg, just add your audio files like movie clips in the Movies path.

I tryed it but it didn't work. Does it need to be in a specific format?


Minor corrections

I don't think you should have removed the new strings

I think that was just bad timing on the PR, and as long as they're empty strings and not in the main translation file (en-GB) it shouldn't prove too much of an issue

oh ok, I thought he removed them intentionally :P

Yeah, bad timing. I thought it would be obvious. I guess you guys have some script to automatically deal with that (add the missing strings to the updated file) so I didn't took any action on that regard.


client: support printing cURL command

Prepare for changing etcdctl to use etcd/client.
The old client support cURL debugging output.

lgtm

@barakmich Merging since it is low risk.


add Institute of Software, Chinese Academy of Sciences

Institution/School Name
Institute of Software, Chinese Academy of Sciences
Instiution/School Website
http://www.iscas.ac.cn
Email Users
Please place an x between the square brackets if yes

[x] Students
[x] Academic/Teaching Staff
[ ] Other/Support Staff
[ ] Alumni

Education Levels
Please place an x between the square brackets if yes

[x] Post-graduate research
[x] Graduate School
[ ] College (University) or Undergraduate School or equivalent
[ ] Community College or equivalent
[ ] High School or equivalent
[ ] Elementary School or equivalent

Additional information can refer to #9899.

@Licheam First stage of verification passed, official domain is is.cas.cn as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: http://english.is.cas.cn/et/Enrollment/Professor_Introduction/

@Licheam We need more information of this organization courses. Also we need to verify your identity and check whether you authorized by the organization to apply on their behalf. Please send us an email to<EMAIL_ADDRESS>mentioning this request number https://github.com/JetBrains/swot/pull/18273. I have to close the request here. Thank you.

@Licheam Thank you for your patience while waiting for a review and processing your request. Pull request merged.
Please notice that the educational license is for educational use only. If the employees of the Academy, who are neither students nor teachers, need the license, please ask them to send a message to<EMAIL_ADDRESS>to get an academic discount for a paid license.


support pkg/errors stacktrace output

Hey @alf-ytakada , I'm just working at something similar (and a little more sophisticated), so maybe wait a bit, I'll probably send PR next week :)


"Choose your county" search form field doesn't clear when closed and reopened [Android]

When an entry is made into the "Chose your county" search field, with autocomplete, if the user decides to close the overlay, the next time the user opens that overlay, the input field retains the user's previous entry, and the search field's label and hint aren't announced, but instead the previous search text (for example, "Xx") by TalkBack

This issue persists in latest build (Monday, September 21, 2020)

@jonnyjames Should be fixed in the next release


Potential race condition exists between an observer subscribing to a query and when that query's response comes back

Describe the bug
I am seeing a bug in my application when using mocked network requests (i.e. query fetch requests resolve immediately), resulting from a race condition between these network requests resolving and a component's observer subscribing to the query's changes. Unfortunately, I can not reproduce it outside of our proprietary codebase, so simply demonstrating the theoretical possibility will need to suffice.
Consider two components, A and B, both of which call useQuery with the same queryKey (thus sharing the same underlying Query instance).

A calls useQuery. This creates a new Query instance and the query begins fetching. A receives isLoading: true from the hook.
B calls useQuery, sharing the same Query instance as A, and therefore not executing a new fetch. B receives isLoading: true from the hook.
The useEffect hooks for A execute, resulting in the query observer for A calling addObserver on its query (via useSyncExternalStore), thus subscribing to query state notifications.
The network request resolves, updating the Query state and notifying A of changes.
The useEffect hooks for B execute, so now B is subscribed to query state notifications, but it does not get notified of the query state updates from the previous step. This is the race condition.
A re-renders with the updated query state, B does not.

This race condition exists because React Query does not control how the JS event loop will schedule the useEffect calls vs. the resolution of the network request, since both are happening asynchronously. Of course, the moment any real network latency is added to the network call, the execution of the useEffect hooks first is effectively guaranteed. Furthermore, while I can reproduce this dependably in Chrome, I am not able to do so in Firefox, which hints at the role that the JS engine is playing in regards to how the work is being scheduled on the event loop.
Our codebase currently has nearly 1700 testcafe tests, and this edge case bug appeared on only a few, all of which were in the same test suite, thus indicating just how much of an edge case it is.
FWIW, component B in our case is a child of component A, and is rendered as a Next.js dynamic component. I don't see any reason to believe that is relevant beyond it having some random effect on the scheduling of work on the event loop, but in theory so could anything else.
Solution
I'd be happy to open a PR to patch this if desired. The solution is fairly simple: the observer needs to subscribe to query notifications immediately, rather than waiting until the useEffect hooks get executed. Since the handleStoreChange function is not available from useSyncExternalStore until the useEffect hooks are called, however, this initial subscription would just set a flag to indicate that handleStoreChange needs to be called once it is available. Such a flag could be implemented as an instance property on the observer or as a ref inside useBaseQuery, but regardless it would look something like this:
const [observer] = React.useState(
  () => {
    const observer = new Observer<TQueryFnData, TError, TData, TQueryData, TQueryKey>(
      queryClient,
      defaultedOptions,
    )
    observer.subscribe(() => {
      observer.needsToFlushStoreChange = true
    })
    return observer
  }
)

useSyncExternalStore(
  React.useCallback(
    (onStoreChange) => {
      if (isRestoring) return () => undefined;
      if (observer.needsToFlushStoreChange) {
        observer.needsToFlushStoreChange = false;
        onStoreChange();
      }

      observer.listeners = []; // Remove `needsToFlushStoreChange` subscription
      return observer.subscribe(notifyManager.batchCalls(onStoreChange));
    },
    [observer, isRestoring]
  ),
  () => observer.getCurrentResult(),
  () => observer.getCurrentResult()
);

Your minimal, reproducible example
N/A
Steps to reproduce
As described above, I am not able to create a standalone reproduction.
Expected behavior
I expect all components that call useQuery to be subscribed to that query in time to immediately receive state updates.
How often does this bug happen?
Almost always
Screenshots or Videos
No response
Platform

OS: OSX 13.3.1, and whatever version of Alpine Linux our CI uses
Chrome 113.0.5672.126

Tanstack Query adapter
react-query
TanStack Query version
4.29.7
TypeScript version
4.3.2
Additional context
No response

As described above, I am not able to create a standalone reproduction.

Could you try to add a failing test case in our codebase to show the problem?
observer.listeners = []; // Remove `needsToFlushStoreChange` subscription

this seems wrong because it doesn't clean up the observer correctly. Also, in your solution, you're calling observer.subscribe inside React.useState initializer, which I think violates the rules of react: we shouldn't have side-effects in there ...

Unfortunately I can't add a failing test case because I can't find a way to dependably reproduce the issue.

it doesn't clean up the observer correctly

Fair enough, I didn't dig too far into what the exactly correct implementation details would be. Hopefully the general approach is still clear enough.

in your solution, you're calling observer.subscribe inside React.useState initializer, which I think violates the rules of react: we shouldn't have side-effects in there

The instantiation of the QueryObserver in useState leads to the instantiation of a Query object and potentially kicks off a fetch request. So side effects are already occurring in useState. But... just typing this out made me realize that maybe this is the way the race condition bug should be fixed: don't execute the network request as a side effect in useState! Instead, it should start in a useEffect hook.

The instantiation of the QueryObserver in useState leads to the instantiation of a Query object and potentially kicks off a fetch request. So side effects are already occurring in useState

no, it doesn't kick off a fetch request. I guess it looks like that from the code, because the constructor calls setOptions, which can trigger a fetch, but it doesn't in this case, because it only triggers a fetch if it has listeners, which it never has in this situation:
https://github.com/TanStack/query/blob/049e0c6e56c6314f4042e9c4849244a19e311161/packages/query-core/src/queryObserver.ts#L177
the fetches really happen when the useSyncExternalStore subscription is triggered, which happens, similar to useEffect, after the component has rendered.

Got it. Still, I question whether subscribing to the query immediately violates some inviolable rule of React. Does instantiating the query in the first place not constitute some kind of side effect?

Does instantiating the query in the first place not constitute some kind of side effect?

No, this is just instantiating a resource, like:
const [now] = useState(() => new Date())

new Date() or new QueryObserver() makes no difference

Ok, certainly happy for an alternative solution that you deem more appropriate. The main goal of this post was to call out the potential race condition.

By the way, looks like I had the described problem in my project( I had the same query in three places. Sometimes random query is not notified about changes. I pretty sure about that race condition, cause if I change an inner state of a component with such query, that query will receive the lates state from cache.

By the way, @TkDodo why do you use useState for observer? Looks like ref here is a better choice.

Why would ref be a better choice? It has no lazy initializer function so you need more code...

@TkDodo Looks like observer has a stable link, so it is quite useless to add it to deps arrays) But yeah, it doesn't matter. useState is ok. The real problem is a race condition.
So, right now, to fix my problem I have to do:
const useSomethingQuery = (...args) => {
  const [,rerender] = useState(0);

  // This useEffect is used to refresh query state
  useEffect(() => {
    rerender(Math.random());
  }, [])

  return useQuery(args);
}

And it's not bullet proof too, cause the race still can be there( So, what do you think about PR with @ericbiewener fix?

You can't setup a subscription during rendering (in the useState initializer), I'm pretty sure about that. What might work is useLayoutEffect. See this slightly related discussion: https://twitter.com/acemarke/status/1661129572908138496

So, useLayoutEffect can be ok. So, what do you think? I can do a PR. Or @ericbiewener )

yeah let's try that with a PR 👍

@TkDodo is there any docs, how to publish a temp release from a branch just to test it in our project?

While useLayoutEffect will likely reduce the possibility of a race condition, are we sure that it will fully eliminate the possibility? The docs say that it blocks the browser from repainting, but do we know that it will block the Query from notifying its observers?
I understand that not performing side effects outside of useEffect or useLayoutEffect is a "rule" of React. However, I'm not convinced that it can't be violated under any condition. Furthermore, I'd still argue that side effects are already occurring in the useState hook. Why isn't the instantiation of a class instances a side effect? And what about the fact that the Query gets added to the QueryCache at that time as well? Ultimately, having a QueryObserver that is instantiated in an unsubscribed state seems like the fundamental problem.

Ok, @ericbiewener @TkDodo https://github.com/TanStack/query/pull/5464 check it out)

So interestingly, we had this in v3 inside the useEffect that sets up the subscription:
https://github.com/TanStack/query/blob/baf722f4943ff1fd9fce970e13eef1817c26e562/src/react/useBaseQuery.ts#L100-L102
But I'm not sure what the useSyncExternalStore equivalent of that is. I was thinking that it shouldn't be needed, but it seems the subscribe function of uSES also runs potentially too late ... so, maybe this?
  React.useSyncExternalStore(
    React.useCallback(
      (onStoreChange) => {
        const result = isRestoring
          ? () => undefined
          : observer.subscribe(notifyManager.batchCalls(onStoreChange))

+        observer.updateResult()

        return result
      },

      [observer, isRestoring],
    ),
    () => observer.getCurrentResult(),
    () => observer.getCurrentResult(),
  )

?

I have a failing test and a fix; brace yourselves

@TkDodo are there any docs, how to publish a temp release from a branch just to test it in our project?

@artem-malko generally, codesandbox does preview builds. It's just that the bot doesn't seem to be working quite well right now.
what should work is just depending on:
"@tanstack/react-query": "https://pkg.csb.dev/TanStack/query/commit/33dacbe/@tanstack/react-query",

33dacbe is the latest commit from my PR.

@TkDodo

what should work is just depending on:

No, it doesn't work. I have webpack, which says, that workspace: * is something unknown for it)

workspace:* dependencies should've been replaced during build 🤔


fmt: %2x/%02x verb prints one element for a zero length []byte

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go1.7
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build602491044=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"

What did you do?
Run the program at https://play.golang.org/p/p6yew65soY
package main

import (
	"fmt"
)

func main() {
	var b []byte
	fmt.Printf("%q\n", fmt.Sprintf("%02d", b))
	fmt.Printf("%q\n", fmt.Sprintf("%2x", b))
	fmt.Printf("%q\n", fmt.Sprintf("%02x", b))
}

What did you expect to see?
"[]"
""
""

What did you see instead?
"[]"
"  "
"00"

Not a bug. %02x means that the format is reserving 2 runes of space for the argument, and that that space is 0-filled from the left. Compare with https://play.golang.org/p/QCbJYhHKmz which fills the space with blanks.

PS: The '0' in %02x is a format flag, it's not part of the width 2. See https://golang.org/pkg/fmt/ and look for "Other flags" .

That is sort of surprising; the '0' and ' ' are applied per element when the slice is non-zero length (https://play.golang.org/p/8hqqedcxsS), and are not applied at all for %02d in the linked program above. There is a whole heap of non-orthogonality here.

@kortschak Hm, it is confusing indeed. I see the following sections in the fmt documentation:
For compound operands such as slices and structs, the format applies to the elements of each operand, recursively, not to the operand as a whole. Thus %q will quote each element of a slice of strings, and %6.2f will control formatting for each element of a floating-point array.

However, when printing a byte slice with a string-like verb (%s %q %x %X), it is treated identically to a string, as a single item.

Not sure that's sufficient. Leaving for @robpike to comment.

Re-opening. It looks like a bug to me. %d is working fine, %x has inconsistencies.

cc @martisch

I just had a look and the change is just the deletion of the condition at https://tip.golang.org/src/fmt/format.go#L357 with associated code readjustment (change the prior condition to be for width == 0 or just for length == 0 before this, and return early). However, that this is specifically in place, and that there are tests for this behaviour suggests someone did intend it.

"That is sort of surprising; the '0' and ' ' are applied per element when the slice is non-zero length" i do not think this is true.
The 2 is a bad test for the padding as %x will always print 2 places for strings/byteslices with a leading zero if need be.
The padding is always applied to the whole string:
"However, when printing a byte slice with a string-like verb (%s %q %x %X), it is treated identically to a string, as a single item."
https://play.golang.org/p/9lNwDG3qeo
%d is different from %x on strings and slice in that:
The %d on a slice is the recursive application:
"For compound operands such as slices and structs, the format applies to the elements of each operand, recursively, not to the operand as a whole."
So all the formatting applies to each element and fmt puts [ ] around the slice.
The %x is the special case:
"However, when printing a byte slice with a string-like verb (%s %q %x %X), it is treated identically to a string, as a single item."
And %x for a string has these rules:
' ': put spaces between bytes printing strings or slices in hex (% x, % X)
%x	base 16, lower-case, two characters per byte
and the 0 modifies the padding for the whole string

Thanks, Martin. TBH, I was just searching this morning for something to debug some byte slices, reading through the fmt_sbx, it's clear I wanted "%# x" as the format (which I will now remember). Maybe this is really just a documentation bug — a couple of examples perhaps?

examples: Sure if others agree that current behavior of padding the whole string should not be changed since it has been the case since at least 1.4?
Maybe 2 examples for byteslice formatting with %x under the section "However, when printing a byte slice with a string-like verb (%s %q %x %X), it is treated identically to a string, as a single item."  ?
	fmt.Printf("%q\n", fmt.Sprintf("%#12x", b))  yields "    0x000102"
	fmt.Printf("%q\n", fmt.Sprintf("% #x", b))   yields "0x00 0x01 0x02"

or better adding another sentence for clarification what the effects are?

Perhaps it's best to document better rather than change the behavior. There are no executable examples in this package, and to provide them is a major undertaking. Maybe just a few words in the existing package documentation would help.

The fact that []byte is treated like string for the purposes of %s %q %x %X is documented and emphasized multiple times in the existing doc comment. I don't believe adding any new emphasis is going to help here.
As @martisch already mentioned:
For compound operands such as slices and structs, the format
applies to the elements of each operand, recursively, not to the
operand as a whole. Thus %q will quote each element of a slice
of strings, and %6.2f will control formatting for each element
of a floating-point array.

However, when printing a byte slice with a string-like verb
(%s %q %x %X), it is treated identically to a string, as a single item.


Add files via upload

As soon as we are not able to to debug the whole code, we are going to replace the /src/main and /ser/test dir, this should make fix and build should pass the integration testing

Tests still failing, then issue should not be under /src/main and /src/test. Need further investigation


distance module

As promised many weeks ago, this adds a !distance module to compute the Levenshtein distance between two strings.
Algorithm shamelessly stolen from Wikipedia, with some modifications for string indexing.

😭

🤩


application builder: In SSR body of server.ts is not taken into consideration when running ng serve with @angular-devkit/angular-builder:dev-server

Command
serve
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
When setting up a new application with SSR on, the development mode (ng serve) doesn't use the content from the server.ts file. It looks like the build process only checks whether the server.ts file exists - even if the file is empty, the build goes through without issues and the app is served but if it's missing, you get an error like this:
✘ [ERROR] TS6053: File '/path/to/your/app/server.ts' not found.
  The file is in the program because:
    Root file specified for compilation [plugin angular-compiler]

If your app depends on some custom logic written in server.ts, e.g custom providers, injecting those into your app doesn't work right now in dev mode and it throws an error: NullInjectorError: No provider for [your_injectable].
Minimal Reproduction
Minimal reproduction:

ng new test-app --ssr
add console.log to server.ts
ng serve

Message from console.log won't appear in the terminal.
Reproduction of example when you want to provide values in server.ts (e.g. as in migration steps from @nguniversal to @angular/ssr)

run ng new test-app --ssr
manually create injection tokens e.g for REQUEST
in server.ts

import { REQUEST } from './src/express.tokens';

...

 // All regular routes use the Angular engine
 server.get('*', (req, res, next) => {
   const { protocol, originalUrl, baseUrl, headers } = req;

   commonEngine
     .render({
      bootstrap,
      documentFilePath: indexHtml,
      url: `${protocol}://${headers.host}${originalUrl}`,
      publicPath: browserDistFolder,
      providers: [
        { provide: APP_BASE_HREF, useValue: baseUrl },
        { provide: REQUEST, useValue: req },
      ],
    })
    .then((html) => res.send(html))
    .catch((err) => next(err));
});

inject the REQUEST token e.g. in app.component.ts
run ng serve

After opening the app, you'll see R3InjectionError:
[vite] Internal server error: R3InjectorError(Standalone[_AppComponent])[InjectionToken REQUEST -> InjectionToken REQUEST -> InjectionToken REQUEST]:
  NullInjectorError: No provider for InjectionToken REQUEST!

Exception or Error
No response
Your Environment
Angular CLI: 17.0.3
Node: 18.17.1
Package Manager: npm 10.0.0
OS: darwin arm64

Angular: 17.0.4
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, platform-server
... router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.3
@angular-devkit/build-angular   17.0.3
@angular-devkit/core            17.0.3
@angular-devkit/schematics      17.0.3
@angular/cli                    17.0.3
@angular/ssr                    17.0.3
@schematics/angular             17.0.3
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.2

Anything else relevant?
No response

Duplicate of https://github.com/angular/angular-cli/issues/26323

@alan-agius4, this issue is not a duplicate of #26323.
#26323 is concerned with the provisioning of REQUEST and RESPONSE within the context of the Angular stereotypes (component, directive, service, pipe, module).
While in this issue, we are concerned with the development tooling: in Angular v17, the start script runs ng serve which uses the @angular-devkit/build-angular:dev-server builder as specified in the angular.json. Here is the call stack we are interested in for this builder:

https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/builders/dev-server/index.ts#L18
https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/builders/dev-server/builder.ts#L75
https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/builders/dev-server/builder.ts#L77
https://github.com/angular/angular-cli/blob/main/packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts#L78 which has a comment reading...// Avoid bundling and processing the ssr entry-point as this is not used by the dev-server.


Bug: Helix Swarm module should support SSO logins

Expected Behaviour
There should be an option in helix-swarm module to enable SSO when creating the service.
Current Behaviour
There is no option currently.
Possible Solution
To enable, you have to add the following line to the config.php file:
        'p4' => array(
            // ...
            'sso'       => 'enabled',
         ),

Steps to Reproduce
Install the helix-swarm module and load it up in the browser.
Cloud Game Development Toolkit version
latest

I would also like to see Perforce update the container to support this as an environment variable.

Agreed, that would be the cleanest solution

Looked into this further. Documenting here.
The Helix Swarm docker container leverages a shell script configure-swarm.sh for creation of config.php programmatically off of environment variables:
configure_swarm()
{
    local php_config_export
    local new_config

    echo "Configuring Swarm installation..."
    # Use PHP to construct initial new values, and read in existing config.php
    # Anything we declare will "win", preserving other existing settings.
    # shellcheck disable=SC2155
    local php_config_export="$($PHP -r "\
        \$config = array(
            'environment'   => array(
            'hostname'  => '$SWARM_HOST',
        ),
        'p4' => array(
            'port'      => '$P4PORT',
            'user'      => '$SWARM_USER',
            'password'  => '$SWARM_PASSWD',
        ),
    );
if (strlen('$EMAIL_HOST')) {
    \$config['mail'] = array(
        'transport' => array(
          'host' => '$EMAIL_HOST',
        ),
    );
}
file_exists('$SWARM_CONFIG') && is_array(\$old_config = include '$SWARM_CONFIG' ) && \$config = array_replace_recursive(\$old_config, \$config);
unset(\$config['environment']['base_url']);
if (strlen('$BASE_URL')) {
    \$config['environment']['base_url'] = '/' . '$BASE_URL';
}
var_export(\$config);")"
    local new_config="\
<?php
/* WARNING: The contents of this file is cached by Swarm. Changes to
 * it will not be picked up until the cached versions are removed.
 * See the documentation on the 'Swarm config cache'.
 */
return $php_config_export;"

Of note, the shell script states: "Anything we declare will "win", preserving other existing settings."
The approach will be the creation of a config.php file prior to swarm startup that can be used to inject other settings such as sso => enabled.


implement webhook

solves #11

I will add a design document and test cases to this PR shortly. Manually tested the PR and it works and improves UX

post-merge, rest this PR on a KinD cluster and it works as expected

thanks @asm582
@sairameshv can you review this PR?

It looks like you haven't run go mod vendor to keep it in sync with the go.mod.

Looks good to me except for minor comments, but I'd like it reviewed by someone who better understands K8s and webhooks.

/cc @sairameshv

Code looks good to me from the webhook perspective.
/lgtm


orm.json not supported

I have a model class like:
class User(orm.core.Entity):
    name = orm.PrimaryKey(str)
    profile = orm.Required(orm.json)

When I attempt to make use of this field, mypy fails to see orm.json as being equivalent to a dict, so I can neither call user.profile.copy() nor can I return user.profile as a dict directly.

Wait, right, orm.json could be something that isn't a dict. Never mind.


Liking main document

Hi,
Is there a configuration where users can like/dislike the original post/document like in Disqus?

Hi ritchie, that's not part of comments-ui but we can consider adding that, or re-using another package that provides this functionality.

@matteodem Thanks. A star or like/dislike system would be amazing!

@matteodem Was wondering if we were able to provide this functionality using https://atmospherejs.com/barbatus/stars-rating?

Yes sure, feel free to test it out and see if it works well.

This has been added in the latest version 1.1.0, see https://github.com/ARKHAM-Enterprises/meteor-comments-ui/blob/master/GUIDE.md


UX guidelines for on-screen text

Since there's a PR to update our UX guidelines (#759), I'll create a new issue to track new guidelines for on-screen text, rather than creating a WIP PR for it which would result in merge conflicts:
1 - The title of a setting should explicitly describe what a setting affects.
Example: A setting to default the expanded or collapsed state of link previews
- incorrect: "Link previews"
- correct: "Automatically expand link previews"
2 - Use the active voice
- incorrect: "This action will delete..."
- correct: "This action deletes..."
3 - Be concise
- incorrect: "Are you sure that you want..."
- correct: "Are you sure you want..."
4 - Ensure plural interpretations work when applicable
- incorrect: "...breaks the integration using it"
- correct: "...breaks any integrations using it"
5 - Test text with machine translation to reduce non-obvious, English-specific jardon:
- incorrect: "There are a few configuration settings you might want to fiddle with when setting up your instance of Mattermost"
- correct: “There are a few configuration settings you can adjust when setting up your instance of Mattermost.”
Note: The incorrect string above machine-translated into German and then back into English looks like this: "There are some configuration settings you could know if your instance Matter Most violin".
See https://pre-release.mattermost.com/core/pl/nf9agdb48ife9yrhzw7z4cj6do for more details

Great start!
Propose we include the "Thor test", or refer to it as the embodiment of the "Mattermost voice for documentation and help text." The Thor test asks "How would Agent Coulson explain this to Thor?" which means explaining something to an alien being in simple terms without jargon or complexity.
This is probably the "north star" to think about (include being concise, easy to translate) and the other guidelines seem like finer details/safety net checks.

consideration of surrounding UI, including titles above the input field (e.g. "Notification Preferences for [CHANNEL]) and
consistent with naming of input fields with similar actions, e.g. "Send email notifications", "Send desktop notifications".

See #1084 for proposed changes