Implement IVsProject4 on AbstractHostObject

Customer scenario
Undoing a rename using the file renamer code fix, fails.
Bugs this fixes:
#1216
Partially fixes: https://github.com/dotnet/roslyn/issues/16546
(either VSO or GitHub links)
Workarounds, if any
The workaround is for the user to manually undo the changes that the code fix made to the project.
Risk
Low.
Performance impact
None.
Is this a regression from a previous update?
No
Root cause analysis:
We only started using the code fixes against .NET Core projects.
How was the bug found?
Customer reported.
Dev Notes
Implement IVsProject4 on the hierarchy that we pass to Roslyn so that it can remove items from the project.

tag @dotnet/project-system @CyrusNajmabadi

Tagging @MattGertz  for approval.

@srivatsn @davkean Let's take to Shiproom, but JoC's question here is going to be if we've just scratched the surface of code fix issues in .NET Core projects, and would it be safer just to disable them in the short term for those project types (and yeah I know that leads to its own complicated set of questions when solutions have more than one type of project).  Let's be prepared to answer that question.

Approved to merge (via 370315)


Data Query Support

limit
offset
order_by / sort
filter

This will clearly depend on backend capabilities.

big +1 obviously.

@pudo TODO: specify what this looks like in JSON (I need that to serialize it into the url for persistence at the very least ...)

@maxogden @pudo @kindly I'd be interested in your thoughts and feedback on this proposal.

First steps on this are done, now its missing hash url serialization I think?

As this includes sorting this now subsumes #23.


python312Packages.tesla-fleet-api: 0.5.6 -> 0.5.9

Diff: https://github.com/Teslemetry/python-tesla-fleet-api/compare/refs/tags/v0.5.6...v0.5.9
Changelog: https://github.com/Teslemetry/python-tesla-fleet-api/releases/tag/v0.5.9
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 311021 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.teslemetry
python311Packages.tesla-fleet-api
python311Packages.tesla-fleet-api.dist
python312Packages.tesla-fleet-api
python312Packages.tesla-fleet-api.dist


ParameterService Question

Hi there! This is a phenomenal library. I've integrated it extensively for a complex cross-platform commmunications app. A few questions:

Is there a way to dynamically create Scopes at runtime? Or is compile-time definition a fixed constraint?
For the ParameterService -- are the objects that are created by the factory callback cached at the DI layer? Or is it just the factory that is cached? For example -- if I wanted to use a ParameterService registration for a factory that creates arbitrary view models, initialized w/provided parameters -- are those objects cached? For the N+1 occurence that a given ParameterService receives the same parameters, is the previously-produced object (returned in the factory callback) returned?

Never tried it. The scope is set in the static's lazy initializer so I'm not sure how you'd change it. Ummm... you could try using a variable on the initializer but seems a bit clunky. Note that once a given Factory has been resolved for the first time there's no way to change the scope afterwards.
Scopes cache the created objects, so if a parameterized object was cached you'd get a service with whatever the value was previously. If no scope was specified then you get a unique object with the current parameter.
Glad you're enjoying the library. If you're up to a little quid pro quo, I have a couple of things I'd like an opinion on in regard to future directions...

https://github.com/hmlongco/Factory/issues/51


Detect Enhancement or task with the 'regression' keyword

Coverage decreased (-0.1%) to 27.205% when pulling a368e42fa81509d52e28e69660f24ab4d409bc64 on sylvestre:master into 808cfec7395b27af5f34852c8e2ed6c2d630922c on mozilla:master.

I kept bug 1204123 open for testing

The "meta" case is not too bad (it's possible that a meta bug is a big defect and there are many steps to fix it, filed as separate bugs)

Yeah, i agree
Le jeu. 4 avr. 2019 à 20:40, Marco<EMAIL_ADDRESS>a écrit :

The "meta" case is not too bad (it's possible that a meta bug is a big
defect and there are many steps to fix it, filed as separate bugs)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mozilla/relman-auto-nag/pull/518#issuecomment-480015632,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAswjpTl6HjuAmZ4JXYlhtC-N2zy1jlPks5vdkcEgaJpZM4cdUSw
.


Move tokio to dev-dependency

This PR moves tokio to be a dev-dependency, so the rt-multi-thread and macros features aren't forced on the user.
Closes #6.

Thanks!


timeTouch: change detecting code using indexedDB and Navigation-Timing API

I change detecting code using indexedDB and window.performance
http://caniuse.com/#search=Navigation Timing

iOS8+ Safari and Webview support indexedDB. but, iOS9 Webview does not support indexedDB.
iOS 8.0 Safari and Webview support Navigation-Timing API but, it is removed for poor performance in iOS 8.1
Navigation-Timing API is back on iOS9 Safari and Webview (http://www.mobilexweb.com/blog/ios9-safari-for-web-developers)

I checked following browsers

Browser
as-is(using WebGL)
to-be (using indexedDB and Navigation-Timing)

iOS7 Safari
false
false

iOS7 Webview
false
false

iOS8 Safari
true
true

iOS8 Webview
true
true

iOS9 Safari
true
true

iOS9 Webview
true
true

Reference #17

While this does improve the code a bit its much more fragile. Since the intention is to detect iOS8+ and it seems very possible the indexedDB support could change in the future this code is also likely to break in the future. On the other hand WebGL support seems very unlikely to be removed.

this PR checks iOS9+ using Navigation-Timing API.
I wonder if Navigation-Timing API will be removed in the future.

merged


Use parens for shadowing parts of folder name in route

Describe the problem
Similar to (groups) for assigning different layouts to files with equal base route, we could also give (xyz) special meaning for ignoring parts of folder names?
Describe the proposed solution
(2023-03-02)post-3/+page.svelte
(2023-02-12)post-2/+page.svelte
(2023-01-28)post-1/+page.svelte

are nicely sorted by date in the file tree but would be served as
/post-3
/post-2
/post-1

by the app.
Alternatives considered
You could make the date string a separate folder.
(2023-03-02)/post-3/+page.svelte
(2023-02-12)/post-2/+page.svelte
(2023-01-28)/post-1/+page.svelte

Importance
nice to have
Additional Information
No response

We can't do this as it would be a breaking change — (2023-03-02)post-3 is already a valid route. We could potentially revisit for 2.0, but not before then

That's actually a nice idea. Using a folder with parens isn't too bad as VS code for example just opens up the first folder that holds a file.

Not sure how I feel about this. I don't think this is something that warrants the additional implementation complexity, and potentially taking away a valid route.

taking away a valid route

You'd still be able to do https://kit.svelte.dev/docs/advanced-routing#encoding so I don't think that's a concern.
As for whether this is a worthwhile feature, I don't know.

I tend to think we shouldn't do this. The () syntax could be confused with grouped routes. But primarily, each time we add a new piece of syntax the routing system becomes harder for users to understand and I don't think the benefit is worth it in this case.


SampleRate at 16000 with distorted/slow audio

Hi Muaz,
I have implemented RecordRTC with only audio on Angular 2. I am using Chrome and Firefox. With a sample rate of 16000, an 3 seconds duration audio will be long 8 seconds. With a sample rate of 44000, the audio will be recorded correctly.
Here is my configuration:
this.recordRTC = RecordRTC(audioStream, {
    recorderType: RecordRTC.StereoAudioRecorder,
    type: 'audio',
    mimeType: 'audio/wav',
    numberOfAudioChannels: 1,
    desiredSampRate: 16000,
    sampleRate: 16000
});
this.recordRTC.setRecordingDuration(3000).onRecordingStopped(this.processAudio.bind(this));
this.recordRTC.startRecording();

How can i solve it? I need a sample rate of 16000. Thanks.

Hi @muaz-khan , I am facing the same issue. Is there any quick work around for this? Thanks.

+1

Please do not set sampleRate along with desiredSampRate.
Try this demo:

https://github.com/muaz-khan/RecordRTC/blob/master/simple-demos/16khz-audio-recording.html

recorder = RecordRTC(microphone, {
    type: 'audio',
    recorderType: StereoAudioRecorder,
    desiredSampRate: 16000,
    // numberOfAudioChannels: 1 // your choice
});

And you will get something like this:

I was trying to reduce the size of my recorded audio, I started by reducing the channel to one and then reducing the sample rate. It works fine on 48000 (default)
In my example i'm only using desiredSampleRate
 var mediaConstraints = {
    audio: true ,
    recorderType: StereoAudioRecorder,
    numberOfAudioChannels: 1,
    desiredSampleRate: 16000
}

still the sound is recording in slow-mo.
Using Angular v1.6.1 and recordRtc v5.4.1

I was having this issue too, removed the sampleRate and it works fine with this
new RecordRTC(stream, {     type: 'audio',     mimeType: 'audio/wav',     recorderType: RecordRTC.StereoAudioRecorder,     numberOfAudioChannels: 1,     desiredSampRate: 16000 })

You can also try this....works perfect
       type: 'audio',         numberOfAudioChannels: isEdge ? 1 : 2,         checkForInactiveTracks: true,         bufferSize: 16384,         //bufferSize: 4096,         recorderType: StereoAudioRecorder,         desiredSampRate: 22050


Truncated display while using --Info-Parameters from the CLI

Example:
OverallBitRate_Mode       : Bit rate mode of all streams (VBR, CBR)
OverallBitRate_Mode/Strin : Bit rate mode of all streams (Variable, Constant)
OverallBitRate            : Bit rate of all streams in bps
OverallBitRate/String     : Bit rate of all streams (with measure)
OverallBitRate_Minimum    : Minimum Bit rate in bps
OverallBitRate_Minimum/St : Minimum Bit rate (with measurement)
OverallBitRate_Nominal    : Nominal Bit rate in bps
OverallBitRate_Nominal/St : Nominal Bit rate (with measurement)
OverallBitRate_Maximum    : Maximum Bit rate in bps
OverallBitRate_Maximum/St : Maximum Bit rate (with measurement)

Note: That's said i could have missed a raw formatting option somewhere...

hard-code limit = 25 char:
https://github.com/MediaArea/MediaInfoLib/blob/master/Source/MediaInfo/MediaInfo_Config.cpp#L839
@JeromeMartinez auto-calc width?

@Sami32 try hot fix:
else if (Option_Lower==__T("info_parameters"))
{
    ZtringListList ToReturn=Info_Parameters_Get();

    size_t max_len = 0;
    for (size_t i = 0; i < ToReturn.size(); i++)
         max_len = std::max(max_len, ToReturn(i, 0).size());
    //Adapt first column
    for (size_t Pos=0; Pos<ToReturn.size(); Pos++)
    {
        Ztring &C1=ToReturn(Pos, 0);
        if (!ToReturn(Pos, 1).empty())
        {
            C1.resize(max_len + 1, ' ');
            ToReturn(Pos, 0)=C1 + __T(" :");
        }
    }

    ToReturn.Separator_Set(0, LineSeparator_Get());
    ToReturn.Separator_Set(1, __T(" "));
    ToReturn.Quote_Set(Ztring());
    return ToReturn.Read();
}

max_len = 36

@pavel-pimenov Thank you for the hot fix, though i didn't planned to build MediaInfo, as i never tried it to be honest. Thanks to the snapshots provided :wink:

@pavel-pimenov I take it.

(for reference, duplicate on Sourceforge: https://sourceforge.net/p/mediainfo/bugs/1071/ )


Key

current diagram needs to have a key, to indicate which is push/pull, and what the +/- for chords mean

Fixed by 9870bf3


libpostal_expand_address may use excessive memory and ultimately fail for certain input

Hi,
If libpostal_expand_address is used for the following address:
I I2 E E I2 I I O I2 I E I E OE!O 74 E2 E 26 I EO E 100, CHEONGJU-SI, 12345, Republic of Korea
...the expander does not return a result before the process is killed for using too much memory (over 9.5G). This was tested using the C API example normalization code from the docs against a version of libpostal built today (5780a08).
The first part of this address is obviously ridiculous, but nonsense like this does appear in data. Is there a change that can be made so that the expander doesn't crash when it encounters such input?

So that wasn't a memory leak or any bug, just that if we treat garbage strings like that as a regular English address (language classifier predicts a ~5% probability that it's English, which is just above the threshold where we would consider the English abbreviations), there are millions of possible interpretations for what it could mean ("E" can be the letter "E" or "East", "I" can be the letter "I", "Interstate", "Island", or the Roman numeral for 1. Then multiply all of that by the outer loop which does all possible hyphenations, etc.)
Luckily our string tree iterator precomputes the number of permutations before looping through them, so rather than trying to determine whether it's garbage input a priori, it's easy to short-circuit the process if the number of permutations exceeds some theshhold n. Setting n=100 for both the outer and inner loop (~10k strings max, 20k with Roman numerals, which are done in post-processing) seems reasonable.
Pull https://github.com/openvenues/libpostal/commit/a7e67c4967b9f12c2461e14cc4db2662309a7fb8 to pick up the changes. Fixes this and similar issues.

Makes sense, thanks for the quick change

No worries.


Pipeline update for Converge on common developer tools - Odo/Devfiles

Epic: Converge on common developer tools - Odo/Devfiles 156

@tseelbach @marikaj123 also consider the question:  Need to update the pipeline to use devfiles, is it just a matter of porting current pipeline or do we need new pipelines for each stack?

not doing in Kabanero at this time


How to inference the motion control signal?

Could you please show a simple demo of predicting the motion control signal? I check the repo codes and paper and understand that I need to set the args.use_car_sensor = True and set the value of key car_info of the inputs.
https://github.com/jxbbb/ADAPT/blob/35fd7cf5a5ac6d5a5c7a5e5e6d40af9e9b980799/src/tasks/run_caption_VidSwinBert_inference.py#L84
But I have no idea what I should use as the value of car_info and the model will predict exactly which signals. Could you give some specific instructions? Thanks a lot.

Thank you for your interest. The inference codes of motion prediction have not  been released, which would be a possible future job for us. And the args args.use_car_sensor is used for an ablation study in our paper (which locates at TABLE III: Single+).

May I know where is the label of control signals? It seems that the BDD-X dataset does not contain such labels, only caption labels are found.


Sync Problem

扩展版本 (extension version): 1.4.7
浏览器版本 (browser version): Version 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)
操作系统 (operating system): Win 10 Enterprise version 10.0.15063
问题描述 (problem description): Sync icon indicates not logged in but on login page 'GitHub Has authorized with: xxxxxx'

实际行为 (actual behavior):
期望行为 (expected behavior):
重现步骤 (reproduce step):

Will SYNC ever work??  It has never worked for me.
It just takes me to a dead site that times out.  https://boss.cnwangjie.com/login


change default screen control crash

Hi, I want change the default control in the pad so I add the following code in my project:
viewer.scene.screenSpaceCameraController.rotateEventTypes = [
Cesium.CameraEventType.MIDDLE_DRAG,
Cesium.CameraEventType.PINCH, // something worng in this line
{
eventType: Cesium.CameraEventType.LEFT_DRAG,
modifier: Cesium.KeyboardEventModifier.SHIFT
}
];
when I using 2 fingers to move the camera, the web will crash.

@swhkyo could you please post a question to the Cesium forum?  You'll get a better response there; we use this GitHub repo for feature requests and bugs.


Make offset an optional argument for the sized Buffer read/writes

https://nodejs.org/docs/latest/api/buffer.html#buffer_buf_readbigint64be_offset
As far as I can tell this has always been optional.
Also @mroch, what is flow's policy for targeting versions of node?  noAssert was removed in node 10 (see the same linked docs).  If flow targets a particular version, maybe it should be removed.
Also!  readBigInt64BE and *BigInt* pals are missing here.  Ditto the same question as above: should they be added?

@isker: our policy for targeting node is very... not good. I'd like the node definitions to move to flow-typed so they can be versioned. it'd keep them from interfering if you're working on a web project. and it'd also be great for making PRs like this not have to wait for a flow release.
the main problem then is that you don't get out-of-the-box support for node, but given how inaccurate it is now, I think it's right to trade off a bit of (arguable) usability for correctness.
it's similar but a bit better defined for React... we try to target the latest public release of React, but that can be a problem if you don't keep them both up to date together. moving react to flow-typed has similar benefits.

Got it.  Thanks for taking the time to spell that out.
For what it’s worth, the ergonomics on flow-typed aren’t great either.  It’s got the versioning problem addressed but the inability to specify dependencies among libdefs kills many nontrivial libs in the water.
That certainly wouldn’t be a problem for node or react, though 🙂.
I will open an additional MR that adds the missing APIs later.

I will open an additional MR that adds the missing APIs later.

Nevermind.  These all return BigInt, support for which has been stuck in a series of doomed PRs.  🙃
#7534
#7602


fix issue 17848 - Example of floating point literals in the documenta…

…tion is invalid
'd' is not a valid float suffix. It's not in the grammar, and dmd doesn't accept it. Changing to 'L' suffix.

There are a couple of problems here.
exhibit a: 1L is actually not a floating point, it's a long.
exhibit b: 1. says "OK, int". No, it's actually a double.
You may want to make a note that the L suffix requires a decimal and subsequent digit to be considered a real.

exhibit a: 1L is actually not a floating point, it's a long.

Right. Instead of trying to fix the example, I'm just going to remove it. It doesn't really add anything over the 'f' example anyway. Amended the commit.

exhibit b: 1. says "OK, int". No, it's actually a double.

Pre-existing, unrelated to issue 17848.


Bug: Incorrect error message on negative start position for remove

import MagicString from 'https://esm.sh/magic-string';

const s = new MagicString('problems = 99');

s.remove(-1, 5);

Uncaught Error: end must be greater than start

Lead me on a bit of a wild goose chase before I realized the issue was with the start position, not that the end was somehow less than the start.

It seems it works like String::slice.
https://github.com/Rich-Harris/magic-string/blob/8e77538d1d03feefe9b114cdff31fba2ef243b4d/src/MagicString.js#L471-L473


Small correction to sweeps_hscv3p1_api.ipynb

positions1 was a remnant from testing. Needs to be deleted, as there is no positions1 function

Oops should have caught that in my review.  But glad you did now!


Canvas Editor Update

Hello! 😄
This PR has several items and fixes for the Curve Editor. *There are pending items to be solved of course.
Improvements in
1.Width Resize, Canvas drag
2.Refactor lambda functions
3.Reposition of canvas
4.Keyframe selection
5.Control Point Fixes
6. Save tangents in file
7. Timeline resize value
8. Memory leak bugs solved
9. Delete the last animation
And bugs related in #8478
Dragging the canvas does not follow the mouse (mouse looks faster than canvas)
When canvas moves on selected frames, it does not reposition vertically at frame value
Repair zoom/frame button (Frame button)
Frame selected button should only work when we have selected keyframes
Resize window doesn't resize the editor (width)
Save animations should save tangents
On edit animation, animation should update to have tangents...
Value box sometimes gets floats beyond three decimals
Linear interpolation control not working, Lerp only to next keyframe
The scale of moving tangent points is not correct
Deselect single key (if control points enabled) cannot be done
When dragging a control point on a tangent, the control point cannot be lowered any further down than past the bottom of the frame. Please see the reference video on the Teams Channel.
Adjusting control points of a tangent appears to improperly affect the animation values. Please see the reference video on the Teams Channel.
If I play the animation inside the editor and my keyframes go minus 0 (-1.... -100) I can't play animations and I get and extra frame zero on my selected animation keys
Load from a snippet
Save to a snippet
I could not figure out how to expand the viewable frame range. Is this related to the zoom buttons being missing/broken?
When breaking tangents on a key and dragging the handles, the movement of the handles seems to be limited to vertical movement only? I expected it to allow me to drag the tangent handles horizontally as well.
Select Coordinate Animation, shows selected list background and displays the correct curve
When dragging keyframes, coordinate animations, should update its frame, but not its values

Ok it is a monster one so I will ask more reviewers to have a look
I REALLY need to make sure the subsequent PR will be more atomic

Yes, agree. I think this one was a special case. But yes, the idea is that the next PRs are one per bug

You can ignore the webgl2 error

I'm uploading the updates for the comments. For certain styles, since these affect SVG elements directly I left them currently there. I added classes for the ones affecting divs and other HTML elements. I'll be working on the documentation/comments for the code in general.

Up?

I'm still working on the documentation for this PR. If you like I can submit a new PR just for the documentation, so we could merge this one?

deal!


language: add else clause as part of if comprehension

Is your feature request related to a problem? Please describe.
One of the more frequently asked questions on Slack and GitHub discussions is why else is missing from CUE (an incomplete list):

Numerous instances on Slack
https://github.com/cue-lang/cue/issues/111
https://github.com/cue-lang/cue/issues/2092

See also https://github.com/cue-lang/cue/issues/571, regarding not() builtin.
In https://github.com/cue-lang/cue/issues/111#issuecomment-873385832, @mpvl does not rule out adding else, saying:

It is not missing, it was deliberately omitted. I’m not entirely against adding it, but only after getting more data and experience with comprehensions and seeing how they develop. Conditional expression tend to lead to awful configurations, and although comprehensions are grammatically not expressions, they are getting close and just might develop into them.

Raising this issue to capture more data, experience, feedback etc, because right now there is not an open issue to capture such responses.
Describe the solution you'd like
Adding support for else clauses in if comprehensions.
Describe alternatives you've considered
Per https://github.com/cue-lang/cue/issues/2092, explicitly stating the negation of the if clause, which leads to errors.
Additional context
n/a

In https://github.com/cue-lang/cue/issues/111#issuecomment-873385832, @mpvl does not rule out adding else,

Now we have more data and know of several designs, in addition to considering future language extensions, I'm much more leaning to not supporting an else construct now.  A switch statement construct is more general and often results in better code.
Also, for now you can simulate a switch statement as such:
a: [ // switch
    if foo != _|_ {
        wasSet: true
    },
    {
        wasSet: false
        foo: "bar"
    }
][0]

This avoids the problem, even now, of having to negate the if condition.
The benefit of this switch construct is that you can combine it with other forms of conditionals. For instance, a common construct is
if expr != _|_ {
    a: expr
}

This is unnecessarily verbose. With the query extension, we foresee being able to instead write something like
a: <- expr // syntax tbd

The switch approach naturally allows for "else" values even in this case. A dedicated else construct does not provide solution for this very common case. Another benefit of the switch approach is that it discourages the use of the nested if anti pattern.
As said, you can use this "switch" idiom even in today's CUE. But we plan to have a bit more syntactic support for this, for instance:
a: switch([
    if foo != _|_ {
        wasSet: true
    },
    {
        wasSet: false
        foo: "bar"
    }
])

This better signals intend and will allow cue vet to detect "unreachable" elements.
I would also not be opposed to having a more dedicated language construct that handles this, although I'm not sure how this would look like if one wants to cover all cases. Maybe something like, using the more precise builtins
a: switch {
    case isdefined(foo):
        wasSet: true
    case X=expr; isvalid(X): // a possible way to not have to repeat expr, I guess we could allow this in `if` too.
        X
    default:
        wasSet: false
        foo: "bar"
}

I like where this is going, though needing to supply an array to the penultimate switch above is onerous, even if it would allow existing source code highlighters and formatters to play along more easily. For the last proposed form above, is there any precedent for a keyword-prefixed block like that in CUE, not using a function call-like syntax?
More potential prior art to consider: Common Lisp's cond and case macros.

Personally I hope there is a else construct.
Manually negating the if condition like the following snippet does is error prone.
if a || b == 0 {
    c: "category a"
}
if !a && b != 0 {
    c: "category b"
}
...

I'm not sure if this kind of usage can be covered by a switch construct.
And I'm a little worried about the performance implication without a else construct to short-circuit the evaluation.


Add ability to set your own common labels for all resources

This change gives us a new optional variable that we can set which allows you to add your own custom labels to all of the resources being deployed. Currently we are able to do this with Pods but not anything else like deployments, config-maps etc.
This is already quite common among many other open source helm charts. It fixes a problem for us where we use these labels for identifying which teams own certain resources which in turn helps us direct prometheus alerts to the correct teams.

apologies for missing out the description, I've updated it now


Cherry Pickings from main to 21.09 Release.

Description

cherry picking the followings.
moved resource bundle to core in podspec
fixed crash caused by image with 744 W X 84 H.
updated outdated unit tests

How Verified

ran scenario and tests cards.

Microsoft Reviewers: Open in CodeFlow

azp run ios-ci.yml


Add duration field in rule template

Proposal
I want to know the duration of abnormal status when I receive the alert，plz？

GitHub issues are not the right place to ask questions for Prometheus.
See the information here: https://prometheus.io/community/


Update README.md

Fixed grammar

Thank you for the whole bunch of fixes, but it looks like the meaning has changed in some of the sentences.

Don't bother pointing those sentences out so I can fix it

Thanks for your work, I cherry-picked some fixes in #284


Per-function requirements DockerFile

I was wondering if I could use Per-function requirements with separate DockerFile for each module if I have multiple modules in the same Serverless.yml file

That is not currently supported

Hey 👋 I'm closing this ticket as it looks like it's heavily outdated, we can of course reopen it if needed 👍


File Dropped to VSCode With WSL Window should have Linux Style Path

For example, I dragged and dropped notepad.py file from windows location to my vscode window with wsl:ubuntu. When I want to run this file from wsl I copy the path but it shows windows style path so I cannot run it from wsl. I suggest this path should be Linux type if the window is open on Linux.

In a remote WSL window, all paths should be linux paths from the WSL file system.
How exactly did you open nodepad.py? It has a Windows path, which is unexpected.

If it was drag and drop, drop should be disabled when targeting a remote window

If it was drag and drop, drop should be disabled when targeting a remote window

Yes it was a drag and drop, but I opened this issue not to disable it. (Because it's helpful, I don't want to open a new project window just for a file) Just to show the/copy the wsl path. So that I can paste the path to terminal and still make some tests for that file on Linux bash.

The code that does the drop does not know how to convert the Windows path to a WSL path.
As it's not easy to implement as we lack some hooks. The UI doesn't know about WSL, it's all done in an extension.
At some point we just disabled dropping when in a remote windows. I guess this got enabled again as there are some useful scenarios, but users need to live with the restrictions.
As a user, you just need to be aware that most tools in the remote window can't handle the Windows paths. Better avoid drag and drop in a WSL window.


Auto Move Image error

If there is no images folder and have turned on the option to "Auto Move Image" I get an error.

Thank you for your feedback. The bug has been fixed


chore(deps): bump https://github.com/zeebe-io/zeebe-cluster-helm from 0.0.107 to 0.0.108

Update zeebe-io/zeebe-cluster-helm from 0.0.107 to 0.0.108
Command run was jx step create pr chart --name zeebe-cluster --version 0.0.108 --repo https://github.com/zeebe-io/zeebe-full-helm.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: salaboy
If they are not already assigned, you can assign the PR to them by writing /assign @salaboy in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Force macOS 10.14 for CI

At the moment this appears to work, don't know for how long they will keep 10.14 around.
Temporarily fixes #37.

Ok, 10.14 still points to Catalina...


chore(main): release 1.2.0

:robot: I have created a release beep boop
1.2.0 (2023-10-27)
Features

add alb backend pool binding support (8d472c6)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/amestofortytwo/terraform-azurerm-selfhostedrunnervmss/releases/tag/v1.2.0 :sunflower:


koa hangs when using ctx.body with 500kB of JSON [UPD: actually it's not the reason]

tested on OS: Ubuntu, koa: 2.0, 2.2, nodejs: 7.6, 7.9
Originally in my project there was mongoose data aggregation with 100kB of output data. Requests were running up to 200ms, but sometimes they just stoped responding.
So I assigned JSON copy of DB collection to ctx.body to test this issue.
ctx => { ctx.body = [hella huge array] }
Same thing, but now I have to make just 7-15 requests (fr. 0.5req/sec, but this doesn't actually mater) to see that one of them a bit laggy and the next one doesn't apears in logs and hangs. CPU consuption is 100% on node.js process.
express.js runs fine, by the way.
Sorry for my bad english. Hope that it would be easy to reproduce the problem. And good luck with solution. My project is not so big, so I going to port it to express.js. So no hurry.
UPD: turns out that koa is fine, see my comments below

Have you tried to use a stream? In general, you can with Mongoose:
const JSONStream = require('streaming-json-stringify')

...

ctx.body = JSONStream()

User.find({})
  .cursor()
  .pipe(ctx.body)

It’s much better when you have a lot of data.

Thanks for advice, I'll use it for response speed optimisation, but it will not solve the problem.
I have found what have been causing this behavior. In my project there is a sheduled http request using axios. When this requests are disabled, koa response runs fine with any amount of data.
So I changed axios to "request" and now the problem is gone.


chore: use the latest version of helpscout beacon dependency

Should we not also upgrade iOS to the latest as well so they're on par?

Makes sense! Updates and tested - works fine


Running .nvm node as bash interpreter

I'm trying to write a script for internal usage with our company, and it's surfaced an issue with .nvm and its reliance on scripting and user home as its installation basis.
The issue is this: how do I point to a specific version of an .nvm node with my bash interpreter in a generic way.
This doesn't work for obvious reasons:
#! /Users/ddrew/.nvm/versions/node/v5.6.0/bin/node

The interpreter line doesn't allow ~ so any reference to user home is unavailable.
And there doesn't seem to be a generic location to point to (I might expect a link in /usr/local/bin to installed node instances a la #! /usr/local/bin/node_5.6.0 where /usr/local/bin/node_5.6.0 -> /Users/ddrew/.nvm/versions/node/v5.6.0/bin/node)
Am I missing something or is there really no way to do this?

You don't - you nvm use in the shell session you want to use it in, and which node will point to the right place. nvm is not designed to be used outside a shell environment.

So I have to write a special wrapper script for this script just to run the script in the right env?

If you want to use it with nvm, yes.

You wouldn't need to write a whole wrapper script. you can use bash as the interpreter and wrap just the JavaScript code as shown.
#!/bin/bash
# Send everything after the next line to node until bash sees endOfJS
~/.nvm/versions/node/v4.3.1/bin/node << 'endOfJS'

// All my JavaScript code
console.log(process.title);
console.log(process.version);

endOfJS


Invarient Violation: Objects are not valid as a React child (found: object with keys {date}).

Issue
Expected Behavior
Code

Environment

react-native -v:
node -v:
npm -v:
yarn --version:
target platform: Android | iOS
operating system:

Has anybody else found this problem with the tutorial?


AttributeError: 'NoneType' object has no attribute 'addr'

Hay,
I've just tried to give the  examples/plot_cfg example a go but keep receiving the "AttributeError: 'NoneType' object has no attribute 'addr'" error. I've tried a couple of PE32 executables but get the same error with all of them, I'm guessing it's an issue with the fact I'm targeting PE files?
Thanks

Hi! Sorry for my late answer. PE files are supported. Its hard to say anything without an explicit backtrace, or binary, but my guess is that your binary doesn't contain the symbol you are looking for, so the variable main will be null at ([*]), and it throws the error when the code tries to read its addr property in the next line.
if __name__ == "__main__":
    proj = angr.Project("../samples/ais3_crackme", load_options={'auto_load_libs':False})
[*]    main = proj.loader.main_bin.get_symbol("main")
    analyze(proj, main.addr, "ais3")

If you think its not the case, you can give me your script and a backtrace, or the script and the binary, and I can have a look on the error.


PostHog for Mobile

Goal

Increased adoption in our mobile SDKs, specifically by new org sign-ups

Plan
Alternatives content:

[x] UXCam (110/m) - @Lior539
[ ] hotjar for mobile apps (260/mo) - @andyvan-ph

Blogs:
(Will chat to Manoel for more ideas)

[ ] Blog with Manoel on how we built mobile session replays (aim to get on hackernews) - @ivanagas
[x] Mobile app metrics to track (600/m, KD 9) @Lior539
[ ] Best mobile app engagement metrics to track (maybe this is a tutorial) (70/m, KD 28)
[ ] Best mobile app engagement metrics to track (maybe this is a tutorial)
[ ] Maybe: Mobile app benchmarks
[x] Best free and open source mobile analytics tools - @Lior539
[x] Best mobile app session replay tools (20m, KD4) - @Lior539

Tutorials:

[x] How to set up iOS session replays - @Lior539
[x] How to set up Android session replays - @Lior539
[x] ~How to set up React Native session replays~ We dont support RN replays

Case studies:

[ ] Two case studies featuring mobile-first customers

Housekeeping:

[ ] Update existing alternatives+ in-depth guides to include mobile session replay (especially Logrocket,  fullstory, smartlook, who are the main session replay alternatives. Will need to to check the others too, though). @andyvan-ph
[ ] Update alternatives+ in-depth guides to include mobile analytics for mixpanel, amplitude, google analytics, smartlook, microsoft clarity (Biggest players in the space. Will need to to check the others too, though) @andyvan-ph

Other ideas:

[ ] Promote Posthog/blogs/the newsletter in mobile dev specific newsletters - @ivanagas

Related issues

For writing session replay alternatives: https://github.com/PostHog/product-internal/blob/main/competitors/2023-07-11-mobile-recordings-research.md

tagging @charlescook-ph @andyvan-ph @ivanagas @jtemperton for comment.
This is a list to get us started, and we will probably add more items as we go along. Would love to hear your feedback, thoughts, ideas.
Also, curious to hear if you think we should do the "Posthog vs xyz"  guides, given they're usually quite high effort and the alternatives blogs cover similar content already (and are usually lower effort)

PostHog vs Y

I'm usually not a big fan of articles such as X vs Y because it's always super biased for X or Y and most of the time the reader does not learn anything.
The type of content I "Manoel" like to read is when you learn something from it, an example:
An article explaining the importance of DAU/MAU for Mobile, then you teach how to install the PH SDK, how to capture the DAU/MAU data either automatically or manually, create the dashboard, and explain how to "read" the dashboard.
DAU/MAU is just an idea, the mobile dashboard has many other interesting insights: https://posthog.com/templates/mobile-dashboard, and of course we don't need to stick to those anyways.

Blog with Manoel on how we built mobile session replays (aim to get on hackernews)

I also want to submit a talk with a topic around this technical challenge at conferences, so the blog post can be the first version of it.

Promote Posthog/blogs/the newsletter in mobile dev specific newsletters

Yes, I know quite some, and I know Microsoft Clarity is already promoting Replay for Mobile as well

Increased adoption in our mobile SDKs, specifically by new org sign-ups

I'd love to see some insights like this, the ratio of new mobile org sign-ups, or even existing orgs sending events/using feature flags, etc using the Mobile SDKs.
I tried to do that with Metabase already but Metabase isn't designed to read the data from all customers within more than a few days, the query just times out, we probably need to capture this info during events ingestion/flags evaluation, or find another way (happy to learn more from you all here).

I'd say no to comparisons. There's no search demand for them yet and, as you say, alternatives cover most of the ground anyway.

Big +1 to promotion in Android and iOS app newsletters. This phase is all about awareness and they're good for awareness if we can nail the messaging.

I think we should go deep on tutorials. We know this works for us and plays to our strengths. What are the problems mobile devs trying to solve? What are they trying to track? How can they do that in PostHog? We should look beyond just mobile session replay.

Since it's in the goals already, we can include a use case landing page. Assume at least one, though it might make sense to do separate ones for Android and iOS analytics. I will look into that.

Migration guides? I suspect migrating from Firebase to PostHog could be a good one.

I think we can include a paid ad component as well for awareness. Could be comparisons ads as an alternative to actual guides.

I'd recommend using Ahrefs to do some competitive keyword analysis and see what they're ranking for. We don't necessarily want to do the same things, but will be useful context / inspo for ideas.

@robbie-c may have good ideas here as one of our resident mobile app experts!

From a commercial standpoint, based on our experience with the Flurry sunsetting/migration, I would suggest not prioritizing that. I'm not sure we sold a single deal from it, and the mismatch in expectations/pricing were nontrivial. It's entirely possible some people migrated without taking the deal and self-served to high volume.
I've heard Firebase more often than I've heard Appsflyer on calls (contrary to industry numbers, but take w a grain of salt since this is not systematic). But some comparisons that explain the differences, and (without seeming too sales-y) justify the added value you'd get from PostHog commensurate w the increased cost, would be really helpful from my perspective.
High volume mobile customers are ideal for us if we can get over the pricing hump, because users are mostly logged in (ie not personless), and the use cases lends itself to flags/a-b testing on top of analytics, which makes us much more sticky.

"Best free and open source mobile analytics tools" blog: Similar ones are some of our best performing content, we don't rank here.
Influencers: I've already started to reach out to some here, we might be able to capture some latent demand like we did with Theo and "google analytics alternatives"
+1 to updating existing alternatives, session replay for X tutorials, no comparisons,
Rather than deep dive tutorials on specific problems, would be nice to have some SEO content related to mobile like the ones I listed here. I find that non-product, non-SEO tutorials don't drive a lot of impact.
Lets get some demand for a migration guide before we write them.
I can do newsletter ads, will take it out of existing newsletter ad budget
Happy to help with Manoel's blog too

"Best free and open source mobile analytics tools" blog: Similar ones are some of our best performing content, we don't rank here.

+1 to this. I'm sure there's search for android and iOS. Will hard to rank, but worth doing long-term anyway.

Some random thoughts:

For React Native, Expo is a major player (I would not start a new react native app without using expo), and they already list us in the analytics tools section https://docs.expo.dev/guides/using-analytics/ . I would see if we could a more prominent position in their integration section, i.e. a top level page (which Firebase/Sentry/Supabase already have) given that we ar more than just analytics. They are a YC company so maybe James or Tim could reach out.
I think comparing posthog analytics vs Firebase analytics could also be a comparison of all of our features vs Firebase, e.g. feature flags. E.g. my startup couldn't use Firebase's feature flags because they were missing some features that we do have at posthog (you couldn't do server-side evaluation of flags for a user, and there wasn't a way to create groups of users that always saw the same value for a flag).
What would go into posthog vs appsflyer? Afaik the main selling point of appsflyer is their mobile attribution stuff (storekit integration etc) which we don't have yet
I didn't know until I just googled it that Flutter had caught up with React Native's popularity, is there anything we can talk about there?
In terms of features, push notifications would be huge, I know it's being worked on. Auth / deep links / attribution / crash reporting would also be amazing

Thank you everyone for the feedback:

Removed in-depth vs guides
Removed flurry (its shutting down)
Removed appsflyer alternatives (It's more marketing attribution focused)
Add case studies for mobile first customers
Added a bunch of blogs

Note we already have a bunch of existing tutorials+blogs on mobile e.g. best mobile app ab testing tools

I can do newsletter ads, will take it out of existing newsletter ad budget
Happy to help with Manoel's blog too

@ivanagas this sounds good. Since both of these go hand-in-hand (you could probably promote Manoel's blog in the newsletters?), is it okay if I assign both of these to you?

@Lior539

We dont support RN replays

hold my beer... https://posthog.com/docs/session-replay/react-native

CLosing out as not focusing on this in Q4


feat: Shareable StarSearch prompts

As a user of StarSearch, I want to have the option to share prompts I create so that I can showcase some of my StarSearch results or so that others can use my prompts for their own purposes.

There is no design for this at the moment. I've created a proof of concept in #3324.

Added ideas to your PR, but sharing here as well. https://github.com/open-sauced/app/pull/3324#issuecomment-2097112422

Adding @bdougie's comments here:
I'd love to see us reuse elements from other places.
Gemini uses a share icon.

OpenSauced Highlights already have a share experience with the 3 dots.

I'd love to avoid adding more design debt with whatever solution we approach.

We shouldn't have to do anything extra to shorten URLs with our API that uses Dub underneath. Any *.opensauced.pizza URL can be shortened with it.

Here's the proof of concept PR that you can take over or cherry pick from @brandonroberts #3324.


[ENH] fit repeated initialization in Lloyd's algorithm

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This adds fit attempts to the lloyds algorithm. This is needed because the result of kmeans is so dependent on the initial center intialisations, by rerunning the model multiple times (10 times by default) with different starting centers and then saving the best results, this overall improves the consitency and quality of the models produced.
Does your contribution introduce a new dependency? If yes, which one?
No

What should a reviewer concentrate their feedback on?

Any other comments?

PR checklist

For all contributions

[x] I've added myself to the list of contributors.
[x] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[ ] I've added unit tests and made sure they pass locally.

For new estimators

[x] I've added the estimator to the online documentation.
[x] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

I've added get_test_params to both clusterers so it should pass the tests quickly. I have also switched back the default distance to DTW


Added text insertion action to Cursorless public api

Fixes #1754
Checklist

[x] I have added tests
[x] I have updated the docs and cheatsheet
[/] I have not broken the cheatsheet

This might be a good PR to use for the inaugural changelog note (https://github.com/cursorless-dev/cursorless/issues/1795).

Agreed. Pokey maybe we should try to discuss tomorrow were and exactly how we want these files to look and this might be the first one?

Sure, happy to discuss. Is there something specific from the description of #1795 that is unclear that you wanted to discuss?

For once it doesn't even say where to place the files. Should I link the pull request, the creation date and so on?

It provides an example of changelog/2023-08-expanded-talon-api.md. I would also put PR number and release date in frontmatter

I made a try here
https://github.com/cursorless-dev/cursorless/pull/1886/commits/bdbfa75e070b73d05302f543c621be45b90d8152


Minimal example of async function

Hi, this is a great project to abstract away the complex Excel SDK. It would be very good if an example could be added of how to use the .Asynchronous Args method. I've tried to use the example from xll_sqlite but my code freezes excel and unfreezes on any keypress failing with a "#CALC" error, this calls again the calc function and if one waits, the final result is displayed.
Is there a way to make an async function similar to the async of Excel-DNA, which don't block the worksheet and keeps the calculation on the background even when moving around to other cells?
This is the code that I was testing, slightly modified from the xll_sqlite one.
void execa(OPER12 x, LPOPER12 h)
{
	std::this_thread::sleep_for(std::chrono::seconds(x.as_int()));
	x.val.num *= 2;
	int result;
	XLOPER12 ret;
	result = ::Excel12(xlAsyncReturn, &ret, 2, h, &x);
	result = result;
}

AddIn xai_execa(
	Function(XLL_VOID, "xll_execa", "EXECA")
	.Arguments({
		Arg(XLL_LPOPER12, "x", "is x"),
		})
		.Asynchronous()
		.ThreadSafe()
		.Volatile()
);

void WINAPI xll_execa(LPOPER12 px, LPOPER12 ph)
{
#pragma XLLEXPORT
	std::thread t(execa, *px, ph);
	t.detach();
}

On my todo list. Happy to look at your pull requests on how to get this working.

You can use .Uncaled() to get limited access to some Excel functions. I use this for handles because they call xlfCaller and xlCoerce.


Add OpenThread THCI python script for Thread Certification testing.

@jwhui Please have a review about this pull request when you have time. Thanks.

LGTM 👍


Post agent time out retry

How to cancel retrying when using post agent timeout？

Hi, sorry there currently isn't an option to stop the retrying.


Add FundingSection component

We can automate a funding section by inferring package.json.
Describe the solution you'd like
Create a component that renders a funding section inferred in package.json.

Thanks! What would this look like in markdown?


Prepeare Carrierwave update

See https://github.com/sanger/sequencescape/issues/2349
This pull request

Updates the configuration to be forward compatible with 2.0.0
Avoids unnecessary chunking of files

This also includes the rails 5.2.3 changes, so hold off merging until that's been validated.

Rails 5.2 seems to be working fine.


Bug: nil pointer of .Content in layouts/_default/list.html template

https://gohugo.io/templates/lists/ does not work:
execute of template failed: template: _default/list.html:33:4: executing "_default/list.html" at <$.Content>: error calling Content: runtime error: invalid memory address or nil pointer dereference

We found a work around:
        {{if not .Draft }}
                {{.Content}}
        {{else}}
                This document is in progress, and could not be rendered yet.
        {{end}}

We do not know, if it happen only at the .Kind section or all .Draft

Duplicates #6210


raft: raft cf size becomes huge when a store is down.

Assume we start 3 stores for loading data, but 1 is down. The raft cf size will become huge and the raft log can't be compacted until applied index - first index >= RAFT_LOG_GC_LIMIT.
Now the RAFT_LOG_GC_LIMIT is 100000, for loading data, the average log size is 32KB, so the total raft log size will become very huge before compaction.
Like etcd, we can reduce RAFT_LOG_GC_LIMIT to 5000, see https://github.com/coreos/etcd/blob/master/etcdserver/raft.go#L44.
But we may still meet https://github.com/pingcap/tikv/issues/424.

It will be more practical to gc raft log according to their size rather than their count. If the pending raft log exceed haft the region size, sending all the pending raft log may perform worse than just sending a snapshot. Especially when issue #1250 is resolved.


Remove the golang genproto dependency from WORKSPACE.

This CL transitions to using gogoslick for the google/rpc/code.proto
messages. In doing so, it also removes the remaining uses of the
standard golang generated code for protos from the codebase.
Tested with:
$ bazel clean
$ bazel test ...

This change is

Jenkins job mixer/presubmit passed

I'm not sure I love collapsing the codes into the rpc namespace along with this. Some of the codes read better (e.g. rpc.FAILED_PRECONDITION) but others not so much (e.g. rpc.INTERNAL; IMO code.INTERNAL is more clear). It also makes it less obvious we're working with the canonical error codes. Maybe it's just because I'm used to working code.

it looks like the option go parts of the proto files are ignored by the current protoc setup. Not entirely sure why. I can dig further.
FWIW, code.proto declares its package as google.rpc. The collapsing then happens, in part, from the gogoslick options.

I don't think it's worth blocking this PR over code vs rpc.

OK. Then I'll submit now and maybe next week during a down moment will play with separating.


SPIKE: Multiplex events are written to FHIR

Background
To send FHIR events to the Universal Pipeline, first we'll need to convert our TestEvents to the FHIR format.
Action Requested
After multiplex TestEvents are created in addMultiplexResult, export them to FHIR format.
One recommendation for doing this would be to create a new instance of TestEventExport that only converts multiplex TestEvents. This may require changes to AzureStorageQueueTestEventReportingService, however.
Please note that while the method is called addMultiplexResult, it processes all tests that are created. We want to only convert the tests with multiple Result objects, one per disease.
We'll pair closely with ReportStream devs for this ticket, since we'll be relying on their FHIR schema.
There are several libraries we could use for the FHIR conversion - implicit in this ticket is a research spike to determine the best option (if ReportStream doesn't already have a strong opinion on it). HAPI's FHIR library looks like one option.
Acceptance Criteria
Decisions have been made around next steps to take (FHIR library, work required to implement schema)
Further tickets are written to make sure that multiplex test events are being converted to FHIR in a format that ReportStream can accept and process.
Additional Information
Check the ReportStream FHIR Sharepoint for additional resources.

Using the ReportStream CLI I was able to convert our CSV into an HL7 and that HL7 into FHIR.
Files:
https://gist.github.com/BobanL/dfe9bfd37f62c6032a1df866fdad133b
Commands ran to generate HL7 & FHIR:
./prime data --input-schema primedatainput/pdi-covid-19 --input ./ReportStream.csv --output-schema hl7/test-covid-19 --output-format HL7 --output-dir ./ --output ./ReportStream.HL7

./gradlew primeCLI --args='fhirdata --input-file "ReportStream.hl7" --output-format FHIR --output-file "ReportStream.fhir"'


Da 5 cicd pipeline (Creation of CICD pipeline to automate our unit tests)

Removed a stream lit options menu import library which was causing tests to fail within the pipeline and in my local environment.
Created the GitHub Workflow file which automatically tests every push on every branch and will test every pull request merge into the Master branch.
Changed the tests_psotgress.py file name to 'test_postgress.py' as it wasn't being picked up correctly by the GitHub Workflow.
Additional requirements added to the requirements.txt file to allow the CICD pipeline to work.

I don't know why the last 2 fail for a single test that toggles the downsample button when the rest pass without issue. This will be looked at the but the CI/CD appears to be working correctly.


systemd unit for sPRUNED

A ready-made systemd unit for spruned makes for reliable oprations. Tested on Ubuntu 16.04, but should be quite universal where systemd is used.

Pull Request Test Coverage Report for Build 250

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 75.414%

Totals

Change from base Build 249:
0.03%

Covered Lines:
2457

Relevant Lines:
3258

💛  - Coveralls

Nice, thanks, now using it on raspbian 9.4 :-)


ARROW-15371: [C++][Release] Missing libsqlite-dev from the verification docker images

Successfully resolves the flight SQL compile error in https://github.com/apache/arrow/pull/12187
Since there is another issue with the verification the crossbow jobs are going to fail until both this PR and #12190 gets merged.


Create Button-Slider

This is sort of the union of grouped buttons and Slider. The component lists several options to choose between, radio-button style, but the interaction method allows for both tapping on one of the options or dragging the slider knob between the options. The knob text updates as the knob moves. The elements to choose from auto-size to be evenly spaced. The knob reflects this same size and fully covers the element text.

Demonstrated in this video: https://www.youtube.com/watch?v=fnh7TfrGSec

DONE! (push directly to master)


Recreate the namespace when transitioning to Managed

holding until we reach agreement.

Is that quorum of 2 out of us 3? ;)


[Feature] Financial Goal Planner

Are you adding a new feature?

[x] YES
[ ] NO

Are you enhancing the old feature?

[ ] YES
[x] NO

Is your feature request related to a problem?

[ ] YES
[x] NO

Describe your feature/enhancement.
Helps users set and track their financial goals, such as saving for a down payment, purchasing a car, or planning a vacation. By parameter like goal type, time frame, target amount
Can you add the feature by yourself?

[x] YES
[ ] NO

Additional Information
Assign this issue to me under GSSOC'23

@ighoshsubho please assign this issue to me


A0 1216 push docker image to dockerhub to release 7

Populates changes from main to the workflow that deploy to testnet and mainnet. These changes add building docker image without docker-entrypoint.sh as entrypoint and push it to Docker Hub.

Ignore this pull request


feat: add icon for .elm files

Description
Pulled the Elm icon from Atom File Icons and added it here.
Motivation and Context
I love Elm, would like to see the icon in my Sublime sidebar :)
How Has This Been Tested?
I built the package and checked the generated files in dist/zpatches/icons and dist/zpatches/single.
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have read the CONTRIBUTING document.

Thanks a lot! I'll review it soon.


chore: configure eslint to not ignore strings for max length

🔧 What changed
There are several lines in our codebase that exceed the maximum length of 130. Most of them are because refs are treated as strings. This change to the eslint config will make it so lines with strings must also be 130 characters or less. The /cypress director was added to the ignore list, because it tests long urls that are not treated as strings.

I'm sorry Ma'am, but your PR title does not comply with our guidelines 🤣
Cc @NabbeunNabi for a good laugh

I'm sorry Ma'am, but your PR title does not comply with our guidelines 🤣
Cc @NabbeunNabi for a good laugh

Actually, it does. 😛 CI ran and failed before I even wrote the PR title (hint: it tested the branch name). Take a look at the CI logs. Cc @NabbeunNabi


Can i write a Sidekiq job updating the index async?

Hi there
I'm just getting started with your chewy gem because it looks great and I'd like to try it.
A question. Is it possible to hook into the update_index action and perform the updating inside an async sidekiq job?
Example:
class User <  ActiveRecord::Base
  after_save    { Indexer.perform_async(:index, self.class.name,  self.id) }
  ......
end

And a Sidekiq worker named "Indexer":
class Indexer
  include Sidekiq::Worker

  def perform(operation, model_name, record_id)
    #update elasticsearch index here...
  end
end

when i do again bin/spring stop it run TacosIndex but when i run TacosIndex::Taco.import(Taco.all)
it error Faraday::ConnectionFailed: Connection refused - connect(2) for "localhost" port 9200

You have to install and run elasticsearch: brew install elasticsearch on OS X

yes thanks pyromaniac ^^

@pyromaniac If you have a generic way of implementing indexing strategies, I'll be happy to fold my code in. The reason I wrote the gem was that the async update was very different to the way chewy handles updates.
Also, what specifically isn't up to date? Even though it's scratchy-ware, we do use the gem in production. So it will get eventually updated when we update chewy and/or Rails. If that's not fast enough for you guys, patches are welcome ;-)

Hey @averell23! By not-up-to-date I meant current master for sure. And also https://github.com/toptal/chewy/pull/119 here is the PR you could check out and even try to cooperate :)

BTW Use after_commit instead of after_save. Becase worker can catch job BEFORE database close transaction or transaction can be rollbacked.

I've added this change a couple of days ago


fixes errors on Python 3

Changes Exception catching syntax
implements a fake smart_unicode function if it is not available.

Can you please take a look at the Travis CI build errors, pep8 complains about syntax:
password_policies/forms/validators.py:12:5: E731 do not assign a lambda expression, use a def
password_policies/forms/validators.py:12:29: E231 missing whitespace after ':'

I'll gladly merge when fixed. Do you use this on Python 3? If so would it be possible for you to extend the .travis.yml file to include testing on Python 3?

Sure, I'll fix both errors. At the moment I'm only using the validators file so I don't know if there is any issue on porting the rest code to python 3.4, but I'll have a look.

I'm closing this PR as the newer PR #39 should solve your issue. Feel free to reopen if you think I'm wrong.


Allow users to create SSH keys and assign these to a NuvlaBox

Nuvla should only keep the public key and allow the user to save the private key (with the note that this is the only opportunity to save the key, since Nuvla will not keep it).
When registering a new NuvlaBox, the public key should be (as an option?) configured for SSH connection, while ensuing that password SSH connection is disabled.

@mebster this is now covered right?

Yes. Closing.


React-router error when using withRouter(NavLink)

When following the example in example/src/SiteWrapper.react.js, I get the following error:
Warning: React does not recognize the `staticContext` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `staticcontext` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    in a (created by Link)
    in Link (created by Route)
    in Route (created by NavLink)
    in NavLink (created by Route)
    in Route (created by withRouter(NavLink))
    in withRouter(NavLink) (created by Nav.Link)
    in Nav.Link (created by NavItem)
    in li (created by ClickOutside)
    in ClickOutside (created by NavItem)
    in NavItem (created by Nav)
    in ul (created by Nav)
    in Nav (created by Site.Nav)
    in div (created by Grid.Col)
    in Grid.Col (created by Site.Nav)
    in div (created by Grid.Row)
    in Grid.Row (created by Site.Nav)
    in div (created by Container)
    in Container (created by Site.Nav)
    in div (created by Site.Nav)
    in Site.Nav (created by Site.Wrapper)
    in div (created by Page.Main)
    in Page.Main (created by Site.Wrapper)
    in div (created by Page)
    in Page (created by Site.Wrapper)
    in Site.Wrapper (at SiteWrapperExample.js:137)
    in SiteWrapperExample (at Dashboard.js:47)
    in App (at index.js:11)
    in Router (created by HashRouter)
    in HashRouter (at index.js:10)

I get the same error when trying to do the following in my own components:
<Nav.Link RootComponent={withRouter(NavLink)} icon="users" to="/users">
  Users
</Nav.Link>

However, when I remove the use of withRouter (as in the example pre #242), it works fine:
<Nav.Link RootComponent={NavLink} icon="users" to="/users">
  Users
</Nav.Link>

react version: 16.4.1
react-router version: 4.3.1
react-router-dom version: 4.3.1
tabler-react version: 1.15.0

This should only be an issue when using a StaticRouter, the official solution appears to be: destructure the staticContext prop when you withRouter https://github.com/ReactTraining/react-router/issues/4683#issuecomment-285707741.
Note: if I remember correctly the only reason we are wrapping the NavItems in the example is so that they get the active prop.


Barplots in the circular layout

This was mentioned in #97 (which has since been closed, since the focus of that was on the circular layout).
Now that the circular layout is implemented and tested, supporting visualizing tip-level feature metadata as barplots would be a really cool feature to add. This could be useful for a few different types of feature metadata, ranging from Songbird/ALDEx2/... differentials (or other "importance scores") to taxonomy annotation confidence values, etc.

Also, it'd be cool to optionally support visualizing information passed over from Emperor as barplots -- it could be really useful to see e.g. presence information as tip-level information, while maintaining previous coloring of the tree (e.g. by feature metadata). Biologically, this would be a way of showing what particular taxa are unique to which groups of selected samples, or something along those lines.

From doing some planning, I think there are three types of barplots that would be good to work on supporting (and potentially more if requested):

Assign each tip a bar of fixed length, and alternate the colors of the bars based on a feature metadata field. These could be either categorical colors (e.g. taxonomy annotations) or quantitative colors (e.g. Songbird/ALDEx2/etc. differential values, other types of feature importance scores as suggested by @shihuang047, etc.).
Example: The "Host Class" ring in Fig. 1 of Song/Sanders et al. --

Assign each tip a bar of fixed color, and alternate the lengths of the bars based on a (quantitative) feature metadata field.
Example: The relative abundance barplots in Fig. 2A of Baker et al. (not exactly comparable b/c this barplot has more than one category, but the same general idea) --

Assign each tip a bar of fixed length, and draw a stacked barplot based on this tip's sample presence information for a selected sample metadata field. (To give an idea of what this would look like, for "body site" in the moving pictures dataset, tips unique to gut samples would have a completely red bar; tips split 50/50 between left and right palm samples would have a half blue / half orange bar; and so on.)
Example: The "Diet" ring in Fig. 1 of Song/Sanders et al., see above

I imagine these are ranked roughly in order of how useful they'll be (maybe 3 and 2 could be switched around, though). So IMO it makes sense to start with the first type of barplot. (Happily, I think this will also be the easiest of the three to implement :)
Other considerations

We would ideally allow for users to select multiple "layers" of barplots, which would allow for intricate displays as shown in the Song/Sanders et al. tree above.

Barplots should work with either circular or rectangular layouts, since both of these guarantee that tips will be allocated some space to themselves in a consistent way (... if that makes sense, there's probably a more elegant way to phrase that).

That being said, it might be best to start off with implementing these for the circular layout first, since most of the figures with barplots I've seen use a circular layout.

All of the figures above (and probably like 95% of the tree figures I've seen while working in bioinformatics, let's be real) use iTOL, so we should of course cite iTOL in the code, paper, etc. as the inspiration for this functionality.

Thanks for breaking this down @fedarko, very helpful. After thinking about this for a little bit, here's some thoughts. I had to think of it in terms of features and samples:

Feature metadata bars:

Length defined by feature metadata variable or default size if unspecified.
Color defined by feature metadata variable or default color - this would optionally support continuous color maps.

Sample metadata bars:

For a categorical variable, show stacked bar chart of prevalence across samples for a metadata variable. For example percent healthy vs sick samples with each feature (we do this in the qemistree preprint - see figure 3).
For a continuous variable, show the average value across samples for a metadata variable. For example average pH per feature. In this case color and height can be fixed (initially) but should be able to be defined by other metadata variables.

For drawing the bars, I think using shaders will be the most performant solution. I think addressing #214 should help us get startecd.
In both cases it sounds like we should allow to have multiple rings of information. In any case, I agree that we should start with the case that's easier to implement and move from there.

I agree 🎩-tip to iTOL and other tools like Anvio, ggtree, FigTree, Topiary Explorer, and so many more ✨


Heroku demo is not working

Hi
I wanted testing a feature in Heroku demo, but I think email settings are not properly.

Hi @andresf01 what feature did you want to test? In my mind the demo is more of a "look and feel" test demo for people that want to just check it out what it looks like, I don't think it can be properly configured for a full installation without other settings. I'm certainly open to ideas on how to improve it though!

@gwasser I wanted test how to works replies from email because I have some problems now with my mail service.

Yeah the demo isn't really meant to do that. However, it is a starting point! Feel free to copy the demo project and configuration into your own folder and add settings for your mail service or other customizations, it should work with minimal setup and changes ideally. If you think the demo is missing any important defaults, let me know or send a PR!


NuGet Package Manager (3.1) shows descriptions from old versions of the package

For example in this package:
https://www.nuget.org/packages/FileHelpers-Stable/
You can see:

But if you search FileHelpers in the UI in visual studio 2015 (last version of NuGet installed) you get:

Wrong name, description, Download count, displayed, I updated the description from the old package and anyway it shows this way

Another issue with this package is that if I install version 2.9.9 (latest is 3.1)
It said that there is an update available but only gives the Unistall option

@johnataylor could this be a V3 API thing or client?

I don't if you reseted something, but now it shows a bit better, at least descriptions, anyway package tittle is different in nuget.org and in visual studio addon
Nuget shows: Deprecated FileHelpers
Visual Studio addon: FileHelpers-Stable   (it never shows the package tittle Deprecated FileHelpers)

Thanks

Maybe if the package has a Tittle the GUI can show it with the package name between ()
Deprecated FileHelpers (FileHelpers-Stable)
If name and tittle are the same or no tittle so show the Package Name
Now the behavior is:
WebPage shows only the tittle in the search
GUI: Shows only the package name

Are you still seeing this issue? @MarcosMeli

Yes @maartenba is still different in 3.4.1
It is an inconsistency between app and web pages for example
https://www.nuget.org/packages/FileHelpers-Stable/
Shows as tittle Deprecated FileHelpers 3.1.2
Also in search in the page if you search for FileHelpers
https://www.nuget.org/packages?q=filehelpers
If shows the title: Deprecated FileHelpers in the search result
But finally in the app it still shows the Package Id FileHelpers-Stable but not the tittle.
Thanks

So it's basically the title showing in the package manager UI that is not what you expect it to be?
/cc @emgarten @yishaigalatzer

Exactly in the web pages the package.Title is showing but in the UI the package.Id
Thanks

From what I see now the title is shown correctly:

Please reopen the issue if you think the problem persists.


Integration several datasets

In the following example, predictions of the first biodiversity dataset are used as an additional predictor for the second dataset. However, the extracted predicted values are also added to the first dataset. Is there a particular reason for this? As far as I understand it, it should be enough to only add the values to the next following biodiversity dataset?
distribution(background) |>
  add_predictors(env = predictors, transform = "scale", derivates = "none") |>
  add_biodiversity_poipo(poipo = virtual_species, field_occurrence = "Observed",
                         formula = formula(paste("observed ~ a + b"))) |>
  add_biodiversity_poipo(poipo = virtual_species, field_occurrence = "Observed",
                         formula = formula(paste("observed ~ c + d"))) |>
  train(method_integration = "predictor")

Not quite sure what you mean, but passing on predictions to the next models is the default for engines that don't support joint estimation of multiple datasets, the parameter method_integration applies (default: "predictor"). Extracted predictors are in this case added.

It needs to pass on predictions among multiple steps. One can think of an example where like 3 or more different datasets are added.
Ultimately the number of predictors in the model object does not matter as long as they are present. Spatial (or temporal) projections only make use of those predictors in the equation (formula).

It needs to pass on predictions among multiple steps. One can think of an example where like 3 or more different datasets are added.

I understand that and it's done within the loop in train() as well as updating the formula object. My question is why in the code example above the extracted predictor values are added to the first data.frame which stores covariates a + b. Doesn't it only require c + d+ prev.prediction but NOT a + b + prev.prediction? For example, the first formula is also not updated using a skip, but the data.frame still is.

My question is why in the code example above the extracted predictor values are added to the first data.frame which stores covariates a + b. Doesn't it only require c + d+ prev.prediction but NOT a + b + prev.prediction?

If at some point we want project() to reproduce the formula of train() we would need all the predictors in the dataset (unless full models are saved in the object, which would be even larger in size than additional columns).

Even if its not particular used during any later predictions, it adds unnecessary to the data.

if you think it is critical to fix, and it does not affect the functionality of method_integration="predictor" , then feel free to commit a fix.

I think this can be closed due to https://github.com/iiasa/ibis.iSDM/pull/119 right?

I think so yes


pmix: 3.2.1 -> 3.2.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/openpmix/openpmix/releases.
meta.description for pmix is: "Process Management Interface for HPC environments"
meta.homepage for pmix is: "https://openpmix.github.io/"
meta.changelog for pmix is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.2.2 with grep in /nix/store/0ncm88w58m8ri2nlm20cz21l5mahx97k-pmix-3.2.2

directory tree listing: https://gist.github.com/081d931dc85659ac2a84217f65bef003

du listing: https://gist.github.com/7c22c11eae56c6c1b7be022e0ed552b9

Rebuild report (if merged into master) (click to expand)

281 total rebuild path(s)

111 package rebuild(s)

100 x86_64-linux rebuild(s)
84 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
94 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
cntk
dl-poly-classic-mpi
elmerfem
freecad
getdp
globalarrays
gromacsDoubleMpi
gromacsMpi
haskellPackages.haskell-mpi
hdf5-mpi
highfive-mpi
hpcg
hpl
ior
lammps-mpi
migrate
netcdf-mpi
neuron-full
neuron-mpi
openmolcas
openmpi
paraview
parmetis
pmix
precice
python37Packages.arviz
python37Packages.baselines
python37Packages.cntk
python37Packages.dask-gateway
python37Packages.dask-jobqueue
python37Packages.dask-ml
python37Packages.dask-mpi
python37Packages.dask-xgboost
python37Packages.datashader
python37Packages.dftfit
python37Packages.distributed
python37Packages.dm-sonnet
python37Packages.edward
python37Packages.fenics
python37Packages.fipy
python37Packages.graph_nets
python37Packages.h5py-mpi
python37Packages.lammps-cython
python37Packages.mask-rcnn
python37Packages.mpi4py
python37Packages.neuron-mpi
python37Packages.optuna
python37Packages.pymc3
python37Packages.pyslurm
python37Packages.rl-coach

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0ncm88w58m8ri2nlm20cz21l5mahx97k-pmix-3.2.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pmix https://github.com/r-ryantm/nixpkgs/archive/495f7a062c004cf8e30056e748f5a06616df50fe.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0ncm88w58m8ri2nlm20cz21l5mahx97k-pmix-3.2.2
ls -la /nix/store/0ncm88w58m8ri2nlm20cz21l5mahx97k-pmix-3.2.2/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @markuskowa for testing.

@GrahamcOfBorg test slurm


feat(lexer): Tokenize binary operations (+, -, *, /, %, **)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.75%. Comparing base (723faef) to head (8547d21).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #12       +/-   ##
===========================================
+ Coverage   66.66%   93.75%   +27.08%
===========================================
  Files           2        2
  Lines           9       16        +7
===========================================
+ Hits            6       15        +9
+ Misses          3        1        -2

Flag
Coverage Δ

unittests
93.75% <100.00%> (+27.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


initial commit to simplify demo app

[x] used setup.cfg
[x] docker-compose for local setup
[x] use .aptible directory and test deployment instructions
[ ] add .github dir with workflow examples

It does work with changes (along with messages being received)

also may want to break out setup.cfg/pyproject.toml into separate commits (in chunked update/cleanup PR so it is easier to follow for someone tracking up commits)

I removed all references to new files that are unnecessary for now, I kept a branch locally and will do what the team desires after discussion. It may live in a separate repository as a consequence


Best practices when using "let"

We use let quite often in our tests. eg
let(:foo) { SomeBar.new }

I can well imagine that would require quite some work to add type checking for (resolving at the access line). Just in case I have missed something obvious, does rspec-sorbet have anything that could help here? Is it planned, or do you have any guidance as to what we should do?

Hi @hlascelles 👋   rspec-sorbet is mostly focused on letting instance/class/object doubles pass through Sorbet's runtime type checking, i.e:
class Foo
  extend T::Sig

  sig { params(bar: MyThing) }
  def initialize(bar)
    @bar = bar
  end
end

...

let(:my_thing) { instance_double(MyThing) }

it 'works' do
  Foo.new(my_thing)
end

This tends to work pretty well in @tricyle projects and just helps make sure that where we are passing doubles into methods we're at least passing the right kind of double.
I'm not sure if that helps answer your question?

Yes, thank you! I can fully understand the utility of the above - and I can well understand getting let to be typed (or even the rest of rspec tests) would be a real trial. One for another day I think. Cheers.


Choose cat

Q
A

Is bugfix?
No

New feature?
Yes

Fixed issues

Optional description...

Review Requested !


Upgrade the Cosmos SDK dependencies to v0.50

With the recent upgrade of the monerium/module-noble to Cosmos SDK v0.50, this library needs to be upgraded to take full advantage of a simpler and cleaner library dependencies.

@gislik Check out https://github.com/noble-assets/adr36/commit/a1725145caa5675e09b6fcf29564a141ae418ae9! Not on main yet but usable, and already used inside the module 😄

Thanks @johnletey ... you're always one step ahead of me. I was preparing a PR with minimal changes but going to note that a full-blown rewrite would be needed to future-proof the implementation. Amazing.

You can see the draft PR but I'd much rather use your eden branch as the basis for the PR.

I've release the eden branch as v1.0.0-rc.0!

Great news. I’ll close my PR.


Unkown on CocoaPods

Hey,
I noticed a podspec file in the repo.
Is there any plan on publishing swifter as a pod ?

Hey,
It's not added to the podspecs master repo https://github.com/CocoaPods/Specs
You need to add git repository address to use it:
pod 'Swifter', :git => 'https://github.com/glock45/swifter.git'

Thanks !

Pods seems to think swifter doesn't support osx. Executing "pod install" gives this output:
Analyzing dependencies
Pre-downloading: `Swifter` from `https://github.com/glock45/swifter.git`
[!] The platform of the target `talldudekit` (OS X 10.9) is not compatible with `Swifter (1.0.1)`, which does not support `osx`.

hi guys --
I've just pushed Swifter pod to the Spec ( https://github.com/CocoaPods/Specs/commit/133db899974f022984a657c1335187f5408a9f3a ).
best


[HOLD for payment 2022-11-22] [$250] BUG: Able to check Select all checkbox of the manage members page when there is only me (workspace owner) on the list reported by @adeel0202

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to Settings
Go to Profile
Delete profile pic if already exist
Click on avatar
Click on Upload photo
Choose a high resolution photo
Click Save
Go to any workspace
Click Manage members
Remove other members if exist by selecting all and then clicking on remove button
Click on Select all checkbox

Expected Result:
Not able to check Select all checkbox when there is only me on the list
Actual Result:
Able to check Select all checkbox when there is only me on the list
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.2.18-4
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/197283885-026876bb-5007-4d75-af04-e9866f0acd8a.mov
https://user-images.githubusercontent.com/43996225/197283936-19897b99-875a-4499-97aa-deba2dbc5ef3.mp4
Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666371501103159
View all open jobs on GitHub

@adeel0202 @kavimuru , you shouldn't be able to remove the admin of a workspace, right? So that box wouldn't/shouldn't be checked since it's not actionable... right?
https://user-images.githubusercontent.com/22508304/197305081-d7df3956-41fa-4db2-98d0-3ac3248fc00d.mp4

@mallenexpensify Yes, shouldn't be able to select the admin to delete. But it allows to remove and then error message appears. This is only reproducible by following the same steps in the actions performed. Please change the profile image of size 3mb.

Unable to reproduce on staging/Chrome with my test account. used a 4mb and 5mb test image. Works as expected.
https://user-images.githubusercontent.com/22508304/197555942-8e91b089-8788-4f87-b5f2-748d0c574020.mp4
Tried other setups too - added two people then tried to select all, still no luck.
Anything else I might be missing?  @kavimuru @adeel0202 are you both still able to repro?

I'm also still able to reproduce.

Also you should remove the member right after adding profile picture.

yup, you have to perform all the steps in a go and as quickly as possible.
upload a high res photo > go to any workspace > manage members page > select all > remove all selected members > select all

Still not able to, tried multiple test accounts too, on staging and production, in chrome and firefox.
Gonna dish to Engineering to see if they can.

yup checking now, was caught up with some other issues

hey, I'm also not able to reproduce. This was on staging and nothing of relevance came up in the console either. Anything else I could try to reproduce @kavimuru @adeel0202 ?
https://user-images.githubusercontent.com/48188732/198432539-c14571e7-5c29-4c07-b7af-e1ad7bfde768.mov

@srikarparsi can you please try with a slower internet connection? I'm not sure but maybe you and @mallenexpensify are not able to reproduce because probably you guys have relatively faster internet connections.
Also, can you guys please try to reproduce this one as well?

good idea @adeel0202, just tried it with slow connection and I'm able to reproduce the issue.
https://user-images.githubusercontent.com/48188732/198729771-3b4c90f2-683e-49c3-bb4e-27599b72a575.mov
Will try reproducing the other one now.

I'm able to reproduce the second issue as well (manage members screen displaying an error after uploading high res profile picture with slow internet connection). I agree that the two issues are probably related. I'm a little busy with some other issues so will mark it external to get it looked at quicker.
https://user-images.githubusercontent.com/48188732/198732161-4bdb870e-35fc-43ec-a8f4-9b2484e1e61a.mov

Job posted https://www.upwork.com/jobs/~015b8c264cc213a4cb

Job's up, only been one biz day....

Proposal
Problem
When users have a slow connection and upload a high-resolution photo, then the user removes some members from the workspace, these policy members in Onyx aren't deleted immediately and just marked pendingAction is delete as this below image

Solution
n Expensify/App/src/pages/workspace/WorkspaceMembersPage.js
we will add a filter to only pick out policy member who isn't marked pendingAction is delete
The sample PR: tienifr/App: Pull Request 20
Result:
https://user-images.githubusercontent.com/113963320/199687822-36b01f4b-35f6-4f15-aa22-d69e8bb187c2.mp4

@sobitneupane can you review @tienifr 's proposal above plz?

Hey @mallenexpensify, just dropping a note as a reminder to keep the pressure on to find a contributor and get this one closed out :)
Maybe consider doubling price tomorrow (7 day marker) as that could help surface a winning proposal and get us into the PR stage sooner! Will leave it to ya from here.

@srikarparsi , please review @tienifr 's proposal above
https://github.com/Expensify/App/issues/12066#issuecomment-1301842942

This looks great to me as well. Thank you @tienifr, assigning you to the issue.

thanks @srikarparsi , I applied to the job, the PR will be ready by Nov 9

Hired @tienifr .
@adeel0202 and @sobitneupane , can you please apply? https://www.upwork.com/jobs/~015b8c264cc213a4cb

Hi @sobitneupane I just created a PR for this issue: https://github.com/Expensify/App/pull/12545
Could you help to review it? Thanks

Updated BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@srikarparsi @sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@srikarparsi @sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@srikarparsi @sobitneupane]  A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@laurenreidexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:
[ ] [@laurenreidexpensify] Applicable payments have been made. This potentially includes the issue reporter, the contributor that fixed the issue, and/or the contributor+ that helped on the issue.

There is a regression from this issue's PR https://github.com/Expensify/App/issues/12770 .

@sobitneupane @srikarparsi can you confirm the status of the regression hold on this? Thanks

@laurenreidexpensify
PR was deployed to production 3 days back.

All payments have been issued in Upwork.
@srikarparsi @sobitneupane can you please add any relevant links here

Confirming Regression testing here

hey @sobitneupane, do you have the bandwidth to work on the first three steps: https://github.com/Expensify/App/issues/12066#issuecomment-1317191255


Fix MoreResources.md next page link

The next page link is wrong on MoreResources.md.

Duplicate of https://github.com/facebook/react-native/pull/14487


Reviews for my mod

Try it out.
Note : It overrides the default chat functionality and passes true so it might not work correctly with mods that rely on it. especially chat3 or other chat mods.
https://github.com/mightyjoe781/censor

It censors bad words and keeps a tab of bad score, when someone goes beyond that it kicks them.
Removes links from chat messages

No matter how many blacklist mods there are, there will never be a perfect one. Players can always find loopholes, for example:  "I want to put my long white giraffe in your small cat."


Change the path for bootstrap-ratio-utilities

// Responsive ratio utility.
@import "../../node_modules/bootstrap-ratio-utilities/scss/responsive-ratio.scss";
Should be
// Responsive ratio utility.
@import "../../node_modules/bootstrap-ratio-utilities/scss/bootstrap-ratio-utilities.scss;

New path
// Responsive ratio utility.
@import "../../node_modules/bootstrap-ratio-utilities/utilities/scss/responsive-ratio.scss";


Trying to access fields of data from createResource throws error

Describe the bug
When I try to access a property of an object from a resource, I get the following error in the console:
Unhandled Promise Rejection: TypeError: undefined is not an object (evaluating 'data().date')

Here's my code:
// data fetcher

export async function fetchDay(date: string) {
    const response = await fetch(`${API_URL}/days?date=${date}`);

    console.log(`${API_URL}/days?date=${date}`);

    return response.json();
}

// the component

const params = useParams();
const [data] = createResource(params.day, fetchDay);

return (

        <Card>
            <CardHeader>

{data().date}

            </CardHeader>
            <CardContent>
                {props.children}
            </CardContent>
        </Card>

)

Now if I try to render just data() it works and renders [object Object]. However if I try to log it in the console, it outputs undefined.
The code is the same as in the docs on Solid's website here: https://docs.solidjs.com/guides/routing-and-navigation#accessing-parameters
Your Example Website or App
https://github.com/matronator/dochazka
Steps to Reproduce the Bug or Issue
Run the app.
Expected behavior
Be able to access the properties returned from data().
Screenshots or Videos
No response
Platform

OS: [e.g. macOS]
Browser: [Safari]
Version: [1.8.15]

Additional context
No response

Without an options.initial value, the resource's value will initially be undefined, so either use data()?.date or use an iniital value that defines date with a placeholder.

Sorry, yeah, my problem was that the response was an array, but it didn't report anything in the console, just failed silently when I tried accessing a property on an array.


Add better instructions for how to add ontology tags to new pathways

Add better instructions for how to add ontology tags to new pathways

There is now a proper "new pathways" task: https://wikipathways.github.io/academy/stages/task-new-pathways/index.html

"new pathways" task has been merged into "recent changes", and the path/navigation has been updated.


Enable Travis and AppVeyor for rel branches

@mikeharder,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


resize gap

creates the following commands.
will resize gaps for views in focused container, so it can resize gaps for one or many views
resize gap grow inner n
resize gap shrink inner n
will resize gap for current workspace.
resize gap grow outer n
resize gap shrink outer n
anyway, this is pretty easy to add. and isnt this why containers have gaps as a variable anyway.

Airblader gaps has a different syntax:
https://github.com/Airblader/i3#gaps

ahh, i guess i should of checked that.
ill fix that,

ok done.

Update the man page. Looks good otherwise.


Fix a bug in the RGB-to-grayscale conversion

I noticed and fixed the following typo during a code review of the Pigo code base:
--- a/core/grayscale.go
+++ b/core/grayscale.go
@@ -6,7 +6,7 @@ import (

 // RgbToGrayscale converts the image to grayscale mode.
 func RgbToGrayscale(src *image.NRGBA) []uint8 {
-       rows, cols := src.Bounds().Dx(), src.Bounds().Dy()
+       cols, rows := src.Bounds().Dx(), src.Bounds().Dy()

This doesn't result in a memory fault since the image array bounds are not exceeded even with the axes swapped around, but it does mean that the grayscale conversion is scrambling the image, which probably has implications for detection quality on non-equilateral images.
For reference, the other locations in the code base that use src.Bounds() look to be correct:
$ git grep src.Bounds
README.md:cols, rows := src.Bounds().Max.X, src.Bounds().Max.Y
cmd/pigo/main.go:       cols, rows := src.Bounds().Max.X, src.Bounds().Max.Y
examples/web/main.go:           cols, rows := src.Bounds().Max.X, src.Bounds().Max.Y
vendor/github.com/fogleman/gg/util.go:  dst := image.NewRGBA(src.Bounds())

Thanks for the observation. I have merged back your fix in the master branch.


use WinExist instead of WinGetID

Fixes mhyllander/gpg-bridge-wsl2-ruby/issues/17

That's fast, thank you.