Web UI: Explicitly strip newlines from chunks when uploading

@rdmark Just a question on this. Please bear with me if this question does not apply for this ticket, because I have not digged deeper into this.
In general, issues caused by newlines are typical for cases where the upload protocol/format is not a binary format. A good example is ftp, where you can choose between text/ASCII and binary transfer format. If you transfer binaries with text format enabled you run into very similar issues with ftp like the one this ticket is addressing. Can it be that there is a general problem with uploading binaries in the web UI, e.g. because the code or the libraries used are trying to deal with text instead of binary format?

@nucleogenic I would have appreciated if somebody had explained why my concerns are not justified and a sequence of line feed characters that is actually a valid part of the binary cannot just be stripped.

@uweseimet Yes, It's a mystery where the CRLF comes from. Your theory sounds believable, that somewhere in the software stack the data is treated as text and not binary.
In the python code we create the file object in binary append mode, as per the documentation: https://docs.python.org/3/tutorial/inputoutput.html#reading-and-writing-files
The one thing I can imagine is that a corner case bug with dropzone.js and the particular version of Chrome that the reporter is using.
I'm hoping that we can get some more feedback and test data from the user and then decide what to do next.

@rdmark In order to reproduce this problem, what about creating an image file that only contains sequences of CR, CR/LF and LF and that is big enough to require several chunks? For testing the upload there is no need for an image with valid filesystems.
If there is an issue with binary/ASCII format, it might also depend on the charsets/locales used on the client and the server.

@uweseimet A file consisting of nothing but CRLF does indeed get corrupted with the code in this PR. (And works before the change.)
One idea I had, is to add a check for the size of a transferred chunk, and strip trailing line endings only when the actual size exceeds the expected size. Thoughts?

IMO this is not a solution. I bet that you are missing something.Am 29.10.2023 09:16 schrieb Daniel Markstedt @.***>:
@uweseimet A file consisting of nothing but CRLF does indeed get corrupted with the code in this PR. (And works before the change.)
One idea I had, is to add a check for the size of a transferred chunk, and strip trailing line endings only when the actual size exceeds the expected size. Thoughts?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

I added some debug output and will ask the original reporter to test once they respond. Logging should at least tell us if the chunk size and offsets are correct.

I recommend not to change anything until it is fully clear where this problem comes from, and there should be more than one user who can reproduce it.All in all either the technologies you are using cannot deal with binary uploads (unlikely), you are not using them correctly and are missing something, or there is no problem and the respective user's setup is some broken.IMO there are no other alternatives.Am 29.10.2023 12:33 schrieb Daniel Markstedt @.***>:
I added some debug output and will ask the original reporter to test once they respond. Logging should at least tell us if the chunk size and offsets are correct.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@rdmark Correct me if I am wrong: The latest comments in #1157 say that there is no problem at all, don't they?

I want to ask the original reporter to try one more thing: the current develop code... just to make sure that the adding of the logging didn't have an effect on their corner case.


Operator website updates

Add a glossary
Move explanation from the file formats and index page to glossary
Reference glossary from other pages
Bump recommended version to v0.5.2
Trigger a build of the website when changes are made to the operator docs
Deploy porter v1 website on push

Affected pages:

https://deploy-preview-80--porter-operator.netlify.app/operator/
https://deploy-preview-80--porter-operator.netlify.app/operator/glossary/
https://deploy-preview-80--porter-operator.netlify.app/operator/file-formats/

@VinozzZ Okay I've updated the PR with your feedback, please take a look


Feature/add pit in control

https://github.com/user-attachments/assets/33eed49c-b7f1-499b-88dd-5fd2adb1dc42


bugfix: When the staticDir is set by the env, capure an error.

@mnmtanish Could you take a look at this and do a release.

Released v2.12.1


Backporting to sbt 0.7.4

Hi,
I am asking nicely :) , is there any possibility for a backporting to sbt 0.7.4 ?
Thanks

To support versions before the major 0.10.* shift, that would require a non-trival amount of work. Fortunately, the guy behind the old coffeescript plugin for sbt 0.7 series seems to still be actively maintaining it, https://github.com/rubbish/coffee-script-sbt-plugin. For older versions of sbt, I recommend using his plugin.

Thanks ! :)


RRule::from_str panics at empty strings.

Hey there :)
I've noticed that FromStr implementation panics on empty value:
RRule::from_str("");

results in
thread 'tokio-runtime-worker' panicked at 'attempt to subtract with overflow', /home/akhramov/.cargo/registry/src/github.com-1ecc6299db9ec823/rrule-0.5.7/src/rrulestr.rs:567:44

What happens in this case is rrule_vals ends up being empty, i.e. of zero length:
https://github.com/fmeringdal/rust_rrule/blob/7c8d64b028b3c7c1b55b55ad088ecbcb48d8bdc5/src/rrulestr.rs#L394-L395
Then we attempt to subtract 1 from zero, which is invalid for usize, an unsigned type
https://github.com/fmeringdal/rust_rrule/blob/7c8d64b028b3c7c1b55b55ad088ecbcb48d8bdc5/src/rrulestr.rs#L567
All in all, this library saved me tons of time and I can't express how grateful I am. Thank you!

Hi, thanks for reporting the issue.

All in all, this library saved me tons of time and I can't express how grateful I am. Thank you!

It makes me very happy to hear that you liked this library :)
I am planning to release a new version within a week a so, and will remember to add a fix for this issue to that release. Will keep you updated here when it is released.
Please let me know if you find more bugs!

This should now be fixed in version 0.5.8


Fix DSN parsing

When only using a DSN, I received the error that no adapter was specified.  Found the DSN parser was never called, so the adapter was never set.

any chance you can add a test so this doesn't break again?


Plugin seems to make Jacoco Coverage not including coverage from unit tests

Hi,
I seem to be having a problem in my Android library project. I am trying to create tests for a project that uses code that is hard to test. So, I restructured some of the old code using AspectJ and your plugin. But, when it comes time to generate the coverage report. It keeps on returning 0%, even though when I generate coverage in IntelliJ IDEA it's giving me >0%.
This is the build.gradle that I used
plugins {
    id 'com.android.library'
    id 'kotlin-android'
    id 'kotlin-android-extensions'
    id "kotlin-kapt"
    id "com.ibotta.gradle.aop"
    id "de.mannodermaus.android-junit5"
    id "jacoco"
}

android {
    compileSdkVersion 27

    defaultConfig {
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"

    }

    buildTypes {
        debug {
            testCoverageEnabled true
            ...
        }
    }
    ...
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }
}

...

task jacocoTestReport(type: JacocoReport, dependsOn: ['test[FLAVOR]UnitTest', 'create[FLAVOR]CoverageReport']) {

    reports {
        xml.enabled = true
        html.enabled = true
    }

    def fileFilter = [ '**/R.class', '**/R$*.class', '**/BuildConfig.*', '**/Manifest*.*', '**/*Test*.*', 'android/**/*.*' ]
    def debugTree = fileTree(dir: "$project.buildDir/preWeave/[FLAVOR]", excludes: fileFilter)
    def mainSrc = "$project.projectDir/src/main/java" // This is the directory the previous team use to place their Kotlin code

    sourceDirectories.setFrom(files([mainSrc]))
    classDirectories.setFrom(files([debugTree]))
    executionData.setFrom(fileTree(dir: project.buildDir, includes: [
            'jacoco/test[FLAVOR]UnitTest.exec', 'outputs/code-coverage/[FLAVOR]AndroidTest/connected/*coverage.ec'
    ]))
}

jacoco {
    toolVersion = "0.8.7"
}

tasks.withType(Test) {
    jacoco {
        includeNoLocationClasses = true
        excludes = ['jdk.internal.*']
    }
}

I read your plugin code and it seems that this code is suspicious to me
    private fun cleanUpAfterWeaving(compileTask: AbstractCompile, preWeaveDir: Provider<Directory>) {
        compileTask.apply {
            project.copy {
                from(destinationDirectory)
                into(preWeaveDir)
            }

            project.delete(destinationDir)
        }
    }

Does this code really do what I think it does? Which is to delete the tmp directory of Kotlin build classes? Because I've read from a StackOverflow post that Jacoco should be directed to the folder where Kotlin compiled the code. So, I first used the postWeave directory to no result. Then I used the preWeave directory, but I'm still getting nothing. Is there anything different between preWeave and tmp directory? If there is, would it be possible not to delete destinationDir?
P.S.
This is a great plugin! Thanks for creating this plugin.

Thanks for the kind words! This issue of Jacoco reporting 0% actually sounds really familiar. I think we ran into this at Ibotta with our core app.
I guess the good news is, that I don't believe it's because of what our plugin is doing. Our coverage reports are working as expected. I just ran tests in one of our app modules and produced the following report. Note, that AccountPresenterImpl is one of the classes we have AOP woven into.

The question is why does it work for us, and not you? I'm assuming this is a global issue you are experiencing, where none of your tests are showing coverage. Is that accurate?
For what it's worth, we are using a Jacoco Android library. And our configuration for it is very simple, and seems to be working for us. Are you using this, or would you consider trying it to see if it resolves the issue? It seems to greatly clean up the Jacoco configuration, on top of just "working" for us.
@vdelricco Do you recall any other details that might be useful here?

Thanks for the tag @eschlenz, I think what you suggested would be good to try regarding the jacoco android plugin.
@david-blacnet the other thing I'll mention is that the 0.8.7 release of Jacoco fixed a lot of issues related to code coverage with Kotlin.
When we updated our toolVersion to 0.8.7 like in your example, I found that we were not seeing any of the touted benefits of the new release.
Upon further investigation, it seemed we were still having an older version picked up and used.
Adding this block to our root gradle file solved that:
subprojects {
    configurations.all {
        resolutionStrategy {
            eachDependency { details ->
                if ('org.jacoco' == details.requested.group) {
                    details.useVersion jacoco_tool_version
                }
            }
        }
    }
}

where jacoco_tool_version is currently set to 0.8.7.
I don't know if that's the case in your project currently, or that problem was caused by the plugin we use, but figured I'd mention it just in case.

@eschlenz and @vdelricco thanks for your suggestions. I have got it working now!

Glad to hear it!


User can claim their own incentive rewards

Problem
Users will receive incentive rewards for LPing on individual pools. We need to show how much they have gained and allow them to claim rewards.
Proposed Solution

[Preferred] if through multisig we can do it custodial. we would need claiming contract (just find one that exists). expose to coinhippo with SDK call
[Alternative-riskier]  offchain send from hotwallet

Acceptance Criteria
From an end tester and/or user perspective, the below criteria must be met to consider this done:

[ ] User can see their rewards in the UI
[ ] User can claim their rewards to their wallet
[ ] [TBD] Do we have any rewards lockup period?

Will re-craft this task for LP staking.


fixing typo

typo: step -> stage
Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ x] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

typo

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Preview environment: https://ci.pr.harness.io/pr-390


Fix #4 and added new timer layout

Added vibrator feedback to Alarm Toggle, Alarm Day Toggle | Stopwatch start/stop, Stopwatch restart/share/lap.
Change layout for timer
Change layout for setting
Added #4
Note* Check code. As I said I'm very new so double check the code

I can't compile the application, android studio gives me some errors.  Can you generate an apk?  If you can send it to me.

If I delete these lines

it makes me compile an apk without problems, but when you open the app and click settings the app crashes

@gun4qmm7h Thanks thank you so much for your help.
I solved it works, soon I will publish another more updated and modern clock project, it is ready I need some time to test and publish it, stop working on this project, wait until I publish the other one and then we will work on that

@qw123wh could you tell me what the problem was and how you fix it? I would love to learn from my mistakes.

@gun4qmm7h actually I did not understand the error from what it was caused, maybe it was the application source code that had some problem, I don't think there are errors in your commits. Anyway take a look at this new version
https://github.com/qw123wh/new-clock
I added the changed the timer look and fixed # 4 thanks to your commits, I added swipe to delete alarm, then i changed the app name. I released a debug app try it and let me know if you like it

I love the new look and feel of it.  I notice the vibration feedback is missing when clicking on things (I don't really care to much about it, just wondering why it's gone). Also are we moving to the new-clock project or is that just the early release version and it will be updated here later?

We will switch to the new-clock version of the clock, this current version will be abandoned.  The vibration feedback I have not added (for me the vibration to the touch has never worked), however if you want you can fork the new app and add this function, but if you are interested as a function, however, also add an option in the settings for be able to activate / deactivate the vibration feedback at the user's choice.

@qw123wh if it's ok with you, can you add me on discord so we can work on this new clock project together? I feeling like using discord would be easier then using GitHub.
BigGuy#8103

I have no discord, if you want the email to contact me is<EMAIL_ADDRESS>write me there then I'll give you my telegram usurname


PHPLIB-463: Implement spec test runner for retryable reads

https://jira.mongodb.org/browse/PHPLIB-463

Merged in https://github.com/mongodb/mongo-php-library/commit/27892777027c7015da3be75f69978dabeabedcf7.


fix: Fixed table naming via attributes

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[ ] I have executed pre-commit run -a on my pull request

This PR is included in version 1.0.1 :tada:


A11y: Repetitive on Android (external by eDAD team)

No required changes in WebChat. This is a tracking issue for an external team to fix an issue downstream (Android).

This is workaround-ed in Web Chat by using a short-lived section in a live region twin.


Add action to calculate the correction to apply in Tx reposition relative to target

This would set the value of X, Y and potentially Z mechanical re-position

New feature was added at 21f1e128456b3397deaf90e23ca819c58b9c98ca


https://github.com/Azure-Samples/java-microservices-asa-e-lab/blob/main/docs/05_passwordless/0503.md

Lab: 05 'Create service connections from the microservices to the database server'
Description of issue - Items identified in QA

- In Task 'Step by step guidance', Step 5: The new connection failed to validate using the command given, unfortunately I was not able to identify a modified command that did succeed to validate - CO may be able to dig deeper to root-cause on this issue.
One possibility might be because resource provider Microsoft.ServiceLinker was not registered before running the command.  If so, it might be recommended to add a step immediately previous to proactively register it:
az provider register --namespace Microsoft.ServiceLinker
az provider show -n Microsoft.ServiceLinker --query registrationState

Another possibility, which is what was taken in this QA to move past issue - one can manually validate in the Azure UI via the Settings > Service Connector menu option, click the 'the active deployment page' link at the top of page, and then selecting and validating manually from there works as expected:

I do not see in my notes that I ran into this issue. I also do not see this as an issue reported from any of the students during training. Can update when I run through this again.
@SkillableKarl @vermegi


lib: fix merging of functions

Description of changes
When trying to merge to functions, the module system errors with something like:
error
… while calling anonymous lambda
         at /nix/store/3ghy6irqjf72xmvzvi7j5amy6qp1b347-source/lib/options.nix:122:38:
          121|     if length list == 1 then head list
          122|     else if all isFunction list then x: mergeDefaultOption loc (map (f: f x) list)
             |                                      ^
          123|     else if all isList list then concatLists list

       … from call site
         at /nix/store/3ghy6irqjf72xmvzvi7j5amy6qp1b347-source/lib/options.nix:122:41:
          121|     if length list == 1 then head list
          122|     else if all isFunction list then x: mergeDefaultOption loc (map (f: f x) list)
             |                                         ^
          123|     else if all isList list then concatLists list

       … while calling 'mergeDefaultOption'
         at /nix/store/3ghy6irqjf72xmvzvi7j5amy6qp1b347-source/lib/options.nix:119:29:
          118|
          119|   mergeDefaultOption = loc: defs:
             |                             ^
          120|     let list = getValues defs; in

       … while evaluating a branch condition
         at /nix/store/3ghy6irqjf72xmvzvi7j5amy6qp1b347-source/lib/options.nix:122:10:
          121|     if length list == 1 then head list
          122|     else if all isFunction list then x: mergeDefaultOption loc (map (f: f x) list)
             |          ^
          123|     else if all isList list then concatLists list
            class = "IN";
       … while calling the 'all' builtin
         at /nix/store/3ghy6irqjf72xmvzvi7j5amy6qp1b347-source/lib/options.nix:122:13:
          121|     if length list == 1 then head list
          122|     else if all isFunction list then x: mergeDefaultOption loc (map (f: f x) list)
             |             ^
          123|     else if all isList list then concatLists list
          };
       … while calling 'isFunction'
         at /nix/store/3ghy6irqjf72xmvzvi7j5amy6qp1b347-source/lib/trivial.nix:339:16:
          338|   */
          339|   isFunction = f: builtins.isFunction f ||
             |                ^
          340|     (f ? __functor && isFunction (f.__functor f));
            "404.julienmalka.me" = {
       … in the left operand of the OR (||) operator
         at /nix/store/3ghy6irqjf72xmvzvi7j5amy6qp1b347-source/lib/trivial.nix:339:41:
          338|   */
          339|   isFunction = f: builtins.isFunction f ||
             |                                         ^
          340|     (f ? __functor && isFunction (f.__functor f));
              CAA = [ ];
       … while calling the 'isFunction' builtin
         at /nix/store/3ghy6irqjf72xmvzvi7j5amy6qp1b347-source/lib/trivial.nix:339:19:
          338|   */
          339|   isFunction = f: builtins.isFunction f ||
             |                   ^
          340|     (f ? __functor && isFunction (f.__functor f));
              MX = [ ];
       … while calling anonymous lambda
         at /nix/store/3ghy6irqjf72xmvzvi7j5amy6qp1b347-source/lib/options.nix:157:20:
          156|   */
          157|   getValues = map (x: x.value);
             |                    ^
          158|

       … while selecting an attribute
         at /nix/store/3ghy6irqjf72xmvzvi7j5amy6qp1b347-source/lib/options.nix:157:23:
          156|   */
          157|   getValues = map (x: x.value);
             |                       ^
          158|

       error: expected a set but found a string:

The semantics of function merging is, given parameter x, apply all functions to x and merge the results.
Looks like the current implementation of mergeDefaultOption  gets the value of x, applies the functions to x and then recursively calls mergeDefaultOption.
The problem is that mergeDefaultOption will try to get the value of x again, which is not possible.
This is my tentative to fix this, but as I am not an expert with the module system, this might be a little clumsy.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

mergeDefaultOption is used in types.unspecified and other types that don't have an explicit merge function.
Could you give an example of a module where the error occurs?
(We'll need this for a test case anyway; see lib/tests/modules.sh and lib/tests/modules for its data, though I haven't determined whether this is a non-breaking solution yet - can be tricky)

The situation happenened while trying to merge 2 attrsets that add a toString__ attr. Will try to come up with a minimal reproducer.


Make Env::AppBundle constructor exception safe

When the Env::AppBundle constructor throws an exception
it still needs to run ~AppBundle(), otherwise the JobQueue
isn't properly shut down.  Specifically the  JobQueue
can destruct without waiting on outstanding jobs in the
queue.
This change ensures that if Env::AppBundle constructor
throws, Env::AppBundle::~AppBundle() runs.
This fixes the unit test crash exposed by PR #3047.

Codecov Report

Merging #3120 into develop will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3120      +/-   ##
===========================================
+ Coverage    68.83%   68.83%   +<.01%
===========================================
  Files          686      686
  Lines        55393    55393
===========================================
+ Hits         38129    38132       +3
+ Misses       17264    17261       -3

Impacted Files
Coverage Δ

src/ripple/ledger/impl/ApplyView.cpp
82.6% <0%> (+2.6%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fccb7e1...711e9d5. Read the comment docs.


Replace Demo image with animated gif

Possible tools for GIF creation: https://github.com/phw/peek, https://www.cockos.com/licecap/, https://www.screentogif.com/

Let me know if you like this

Let me know if you like this

Hi @SJellen, that looks great!
I think the second one is more like what I was thinking.
Maybe more of the fonts could be included, though, such as Monospace and one of the Script fonts?
Anyway, it's looking good. Thanks for your help. :+1:

@SJellen At the start, I think it should have the original text with no modifications and maybe highlight smaller selections? I'd also probably avoid Math Sans since it's almost like normal text and avoid the circle and square fonts and subscript since they can be a bit difficult to read.
The 2nd gif in the first message was pretty much perfect, just it would be nice to have some of the more useful fonts represented.
I like the idea of clicking the eraser at the end, but maybe avoid fonts that can be ambiguous (eg. fonts with no distinction between upper and lowercase) so that the text is the exact same as it started when you click it. It would make a cool loop that way :smile:

heres demo4.
I tried  to get in as many as I could. The issue is that the longer the video the lower quality the gif.
**oops,  I just saw your note about the subscript **

@SJellen This is great!
Would you like to make a PR to fix the issue?


Fix tag test that’s barfing on correct "notes" submission

This test should not have failed: https://travis-ci.org/openaddresses/openaddresses/builds/67757550 in pull #1036.

…actually, “notes” should be “note,” but the test output wording is not great.


Usage of arrays with a size of 0

In the open thread code, there is usage in a few places of arrays of 0 size.  This feature (zero sized arrays) seems to be a specific feature enhancement to the gnu/gcc compiler.  Since I am tied to IAR, it would be nice to update the code to be more compiler independent...  I am also creating this ticket based on the info from the below user group thread...
https://groups.google.com/forum/#!searchin/openthread-users/array|sort:relevance/openthread-users/kNBYtAVJfSc/svRVOPq-AQAJ
Places where arrays of size zero I found are at:
openthread\src\core\thread\network_diagnostic_tlvs.hpp

class IPv6AddressListTlv: public NetworkDiagnosticTlv, its private data member Ip6::Address mIPv6AddressList[0]

class ChildTableTlv: public NetworkDiagnosticTlv, its private data member ChildTableEntry mChildTableEntry[0]

Thanks for submitting this issue!  I'll have a PR out soon that enforces C++03 and does not allow GNU extensions.


Output value on internal transactions is wrong

An internal TX e.g., https://cardanoscan.io/stakekey/stake1u9ttjzthgk2y7x55c9f363a6vpcthv0ukl2d5mhtxvv4kusv5fmtz should have no input/output and only the fee (should be also recognized)
Instead this is shown
🔑 stake1u...usv5fmtz
✉ 1 new transaction(s)
⤴ Sent Funds   06.12.2022, 07:50 PM
🔹Fee 0.18 ₳
🔹Output -695.48 ₳

Working properly in integration tests

Implementation of internal TX completed
It looks like this
🔁 Internal Transfer  29.11.2022, 11:33 AM
🔹Fee 1.11 ₳


Test: If you ask class for its interfaces, then no filtering

It was useful to test this, but there is no reason to keep this test working in the future. Therefore, I close this pull request.


Almost as bad as ps_edition_basic

ps_mbo is the source of lots of  problems on the forum.
However, ps_edition_basic is worse. ps_edition_basic requires PHP version 8.1. So its presence in the EDITION BASIC sabotages the compatibility with older PHP versions.
As you see this only after you have enabled debug mode very few people find this out.

Hello,
Thanks for the feedback.
Be sure we are trying our best to handle problems/issues developers or merchants can encounter.
The message about the PHP support version is transmitted.
I close this issue.


NextJs images not showing in Azure

I deployed nextjs to azure but after the build, the image sizes are 0B. Image is not showing in product but if I add the following to next.config.js file, it works
{ images: {   unoptimized: true } }

@joshuaolusayo Can you provide some more details about your deployment here? Information like your package.json and initialization of Application Insights would be helpful. Thanks!

@JacksonWeber I am using NextJs of 13.x. When I switched to version 14 also, it also did not work.
This is from my package.json:
"next": "13.5.6",
"react": "^18",

This is a screenshot of the build output... The images are showing 0B. I guess this is the reason why they are not showing inside the webapp... but then, after adding { images: { unoptimized: true } } inside next.config.js, it all works file

@joshuaolusayo Do you believe this issue is related to Application Insights? Or are you just having trouble deploying next.js apps in general to Azure App Service without using the unoptimized: true flag on your containers?

@JacksonWeber I believe it has to do with Azure. Image optimization is not working when using NextJs Image component (next/image). The only workaround is to add unoptimize of true to next config which removes the optimization on all images (a great feature that's part of my reason for considering NextJs). Without adding that in next config, none of the images are shown

@joshuaolusayo I see. That makes sense. Are you having any issues with Application Insights? This seems to be an issue relating to App Service image deployment. Unless you believe otherwise, can I close this issue?

You're absolutely right... but will closing the issue helps in resolving it?

@joshuaolusayo This issue should be reported via a ticket in the Azure Portal. This repository can specifically help with issues directly relating to the usage of the Application Insights SDK.

Oh! I get... Please, is there a link that could help to report the issue? Thank you so much for the help so far

Thank you @JacksonWeber . You can close this issue now


Running cayo build does not generate cache-busting file names unless .cayo dir is deleted manually

Pretty sure .cayo is supposed to be deleted before running the build process, but if it's not that'd be that's why this is happening. This is important for systems that rely on the filenames to change between builds, so it can cache bust (i.e., mine).

Possibly a Vite bug?? I think it's caching files in a dir to optimize between builds.


【Feature Request】Will the codebse support relative position embedding ?

Thanks for your great work. I wanna to adopt flash attention in my codebase but I find that it's hard to apply it to the attention with ralative position embedding. Could you help me?

The CUDA implementation doesn't support relative position embedding. The experimental Triton implementation has attention bias (and hence could work with relative pos emb) but I found the backward gradient to be sometimes wrong due to race conditions (from the Triton compiler).
Not sure how helpful this is but you can play with the Triton implementation.

@tridao do you know whether (and when, if not) the triton implementation can support relative positional embeddings with learnable parameters, e.g., kerple?

Relative pos emb can be done with attention bias. The experimental Triton implementation linked above supports attention bias (the forward seems robust enough, the backward might have some race conditions).
I don't have the bandwidth to work on this but you can play with the Triton code, it's a self-contained Python file.

@tridao thanks for the reply. However, per my understanding, if we go with attenton bias for relative pos emb, then it cannot be learnable. Coudl you recommend a path if we wanna have learnable relative pos emb in triton flash attn?

@tridao thanks for the reply. However, per my understanding, if we go with attenton bias for relative pos emb, then it cannot be learnable. Coudl you recommend a path if we wanna have learnable relative pos emb in triton flash attn?

Right, you'd need to implement the attention bias gradient in the backward pass. You can start with the Triton implementation and implement it there.


[Packager] Refactor packager (separate preprocessor step)

Maybe I'm messing something up, but I have not been able to get the packager to work with es6 modules, or anything requiring the Babel runtime. From digging around in the packager a little more, I believe this has to do with the fact that it runs the transform on each file individually.
I am able to this stuff working by running Babel on my files myself before they reach the packager, but it seems messy to preprocess it twice.

I need to investigate this further, will submit a PR if I pursue it.


TP - need to be able to view/manage orphaned parameters in Traffic Portal

Old UI provided the ability to view orphan params. New UI should have similar ability.
Would also be nice if the TP would provide the ability to bulk delete orphans, which the previous UI did not. Very useful for housekeeping.

this would be solved by #1363


There was errors in docker compose runing.

Dear miguelgrinberg,
When I have checked out 17f, and completed docker compose running, there was logs :

flasky_1  | INFO  [alembic.runtime.migration] Context impl MySQLImpl.
flasky_1  | INFO  [alembic.runtime.migration] Will assume non-transactional DDL.
flasky_1  | INFO  [alembic.runtime.migration] Running upgrade  -> 38c4e85512a9, initial migration
flasky_1  | INFO  [alembic.runtime.migration] Running upgrade 38c4e85512a9 -> 456a945560f6, login support
flasky_1  | INFO  [alembic.runtime.migration] Running upgrade 456a945560f6 -><PHONE_NUMBER>11, account confirmation
flasky_1  | INFO  [alembic.runtime.migration] Running upgrade<PHONE_NUMBER>11 -> 56ed7d33de8d, user roles
flasky_1  | INFO  [alembic.runtime.migration] Running upgrade 56ed7d33de8d -> d66f086b258, user information
flasky_1  | INFO  [alembic.runtime.migration] Running upgrade d66f086b258 -> 198b0eebcf9, caching of avatar hashes
flasky_1  | INFO  [alembic.runtime.migration] Running upgrade 198b0eebcf9 -> 1b966e7f4b9e, post model
flasky_1  | INFO  [alembic.runtime.migration] Running upgrade 1b966e7f4b9e -> 288cd3dc5a8, rich text posts
flasky_1  | INFO  [alembic.runtime.migration] Running upgrade 288cd3dc5a8 -> 2356a38169ea, followers
flasky_1  | INFO  [alembic.runtime.migration] Running upgrade 2356a38169ea -> 51f5ccfba190, comments
flasky_1  | [2020-09-21 13:43:55 +0000] [1] [INFO] Starting gunicorn 19.7.1
flasky_1  | [2020-09-21 13:43:55 +0000] [1] [INFO] Listening at: http://<IP_ADDRESS>:5000 (1)
flasky_1  | [2020-09-21 13:43:55 +0000] [1] [INFO] Using worker: sync
flasky_1  | [2020-09-21 13:43:55 +0000] [28] [INFO] Booting worker with pid: 28
flasky_1  | <IP_ADDRESS> - - [21/Sep/2020:13:55:59 +0000] "GET / HTTP/1.1" 200 3133 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.2 Safari/605.1.15"
flasky_1  | <IP_ADDRESS> - - [21/Sep/2020:13:55:59 +0000] "GET /static/styles.css HTTP/1.1" 200 - "http://localhost:8000/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.2 Safari/605.1.15"
flasky_1  | <IP_ADDRESS> - - [21/Sep/2020:13:56:00 +0000] "GET /static/favicon.ico HTTP/1.1" 200 - "http://localhost:8000/" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.2 Safari/605.1.15"

Home page works. But I have not received confirm email after registering. I remembered I have input correct mail username and password. What's the matter?

You may want to run your application in debug mode, so that Flask-Mail generates logging.

I modified MAIL_SERVER and FLASKY_MAIL_SENDER, and have received confirm email. Thanks.
世界充满希望 机会就在眼前  李力

------------------ 原始邮件 ------------------
发件人:                                                                                "miguelgrinberg/flasky"<EMAIL_ADDRESS>发送时间: 2020年9月21日(星期一) 晚上10:23
收件人<EMAIL_ADDRESS>抄送: "李力"<348104201<EMAIL_ADDRESS>主题: Re: [miguelgrinberg/flasky] There was errors in docker compose runing. (#485)
You may want to run your application in debug mode, so that Flask-Mail generates logging.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


1365 - How Many Numbers Are Smaller Than the Current Number

Description of the Problem
Given the array nums, for each nums[i] find out how many numbers in the array are smaller than it. That is, for each nums[i] you have to count the number of valid j's such that j != i and nums[j] < nums[i].
Return the answer in an array.
Example 1:
Input: nums = [8,1,2,2,3]
Output: [4,0,1,1,3]
Explanation:
For nums[0]=8 there exist four smaller numbers than it (1, 2, 2 and 3).
For nums[1]=1 does not exist any smaller number than it.
For nums[2]=2 there exist one smaller number than it (1).
For nums[3]=2 there exist one smaller number than it (1).
For nums[4]=3 there exist three smaller numbers than it (1, 2 and 2).
Example 2:
Input: nums = [6,5,4,8]
Output: [2,1,0,3]
Example 3:
Input: nums = [7,7,7,7]
Output: [0,0,0,0]
Code
class Solution(object):
    def smallerNumbersThanCurrent(self, nums):
        """
        :type nums: List[int]
        :rtype: List[int]
        """

Link To The LeetCode Problem
LeetCode

I would like to be assigned this.


Accessibility: Add ErrorPanel component to StoredCardFieldsWrapper

Summary
I added the same behavior that was inside CardFieldsWrapper.tsx into StoredCardFieldsWrapper.tsx to improve accessibility in the latter.
Tested scenarios
Saved stored payments
Fixed issue:  #1608

@diego9497 - thanks for the PR :-)


Parameters missing various fields

When a parameter is rendered in a table, it has the data type, and whether or not it is required. But, it is missing pattern and format fields.

Would be great if you had a short example that I could use as test-case. This might be fixed with bootprint/bootprint-json-schema#10 (at least for patterns)

I'm not sure if this is related, I may make a new issue if you think this should be one.
So, my parameters aren't showing in the table.
Sample :
/**
 * @swagger
 * /login:
 *   post:
 *    description: Authenticate user.
 *    produces:
 *      - application/json
 *    parameters:
 *      - name: email
 *        in: body
 *        required: true
 *        type: string
 *      - name: password
 *        in: body
 *        required: true
 *        type: string
 *    responses:
 *      '200':
 *        type: object
 *        properties:
 *          JSESSIONID:
 *              type: String
 *          required:
 *            - JSESSIONID
 */

So this renders a table in the HTML file with the method (post) the title (/login) and the response (200) but the parameter field is empty. Also the properties of '200' don't show up.
What I'm running in the console is :  swagger-jsdoc-generator swagspec.json > config.json && bootprint openapi config.json swagger where "swagspec" is my configuration file, config.json is the json generated from the swagger comments (I should rename it, I now this might be confusing) and swagger is the folder where the HTML and CSS are saved.
Any idea on what's the problem is?

This is a separate issue. There should be a schema-property in the response-object


Implement IPEDS12MoInstAct02to16.do

Write and implement IPEDS12MoInstAct02to16.do which will download and build a panel data set of the "12-month instructional activity" IPEDS Survey. Using sshnd available at:
https://raw.githubusercontent.com/adamrossnelson/sshnd/1.0/sshnd.do

Done. See:
https://github.com/adamrossnelson/StataIPEDSAll/blob/master/IPEDS12MoInstrAct02to16.do


This  is bad to while(true)

while (true) {
    attempts += 1;
    code = await runCommandAndStreamOutput(
      _pubCommand(arguments),
      workingDirectory: directory,
      mapFunction: filter,
      environment: _createPubEnvironment(context),
    );
    if (code != 69) // UNAVAILABLE in https://github.com/dart-lang/pub/blob/master/lib/src/exit_codes.dart
      break;
    printStatus('$failureMessage ($code) -- attempting retry $attempts in $duration second${ duration == 1 ? "" : "s"}...');
    await new Future<Null>.delayed(new Duration(seconds: duration));
    if (duration < 64)
      duration *= 2;
  }

I am not think this is good idea .
It makes me force to close my android studio.
I think It can't help me to find problem ,and it makes me be agitated
while (attempts<3)   I think three is good

I think @yangyudaddy is suggesting that the code (which is from here) should have some maximum number of iterations. Currently it will keep doubling the wait time till 64 seconds and then loop indefinitely if it can't connect to pub.
I'm not sure why it would make Android Studio hang though (unless it's blocking waiting for the process to terminate). If it's being run from tooling I'd agree it should probably bail after a while though. If it hasn't succeeded after 10 mins, probably it won't because something is broken.

@DanTup  I am from China. You know we  connect network to update by VPN. If we just forget for set proxy for terminal , that is trouble with us.  Especially， we change net from  outline net to company net.

Should this be moved to the dart-lang/pub repo?

In my opinion, the fix should be in the code above (it should give up after a certain number of iterations and display a message about what it was doing, how long it tried for, and some hints about what the issues might be).

Sorry, I missed that this is part of Flutter, I just saw pub.dart.
Sorry for the noise.

Code 69 happens when there's a network error. Sometimes network errors happen for 11 minutes, so timing out after 10 minutes doesn't work.


feat: child behaviors in behavior sequence are now reorderable

Description
In the Step Inspector all behaviors, transitions, and conditions are reorderable now. They can be moved up and down. Therefore, a new 'ReorderableListOfAttribute' attribute is introduced. The BehaviorSequence uses it now.
Depends on: https://github.com/Innoactive/Creator/pull/128
Fixes: TRNG-495
Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
This was tested manually, since it's a UI change.
Test Configuration: Home PC, Unity 2019.4.1f1 LTS
Checklist

[x] My code follows the Coding Conventions
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Tests should work as soon as Core is on develop

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Mediasite with multiple video sources (added example with no authentication)

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.04.07. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[X] I've verified and I assure that I'm running youtube-dl 2019.04.07

Before submitting an issue make sure you have:

[X] At least skimmed through the README, most notably the FAQ and BUGS sections
[X] Searched the bugtracker for similar issues including closed ones
[X] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[X] Bug report (encountered problems with youtube-dl)
[X] Feature request (request for a new functionality)

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Video: https://lecturecapture.wustl.edu/mediasite/Play/c63b969f11ff44c88b10249d51a86a2d1d

Description of your issue, suggested solution and other information
There are two different sources of video in a "video", would it be possible to add a feature that would download them both instead of just one of them?

$ youtube-dl -F 'https://lecturecapture.wustl.edu/mediasite/Play/c63b969f11ff44c88b10249d51a86a2d1d'
[Mediasite] c63b969f11ff44c88b10249d51a86a2d1d: Downloading webpage
[Mediasite] c63b969f11ff44c88b10249d51a86a2d1d: Downloading JSON metadata
[Mediasite] c63b969f11ff44c88b10249d51a86a2d1d: Downloading ISM manifest
WARNING: [Mediasite]  is not a supported codec
[Mediasite] c63b969f11ff44c88b10249d51a86a2d1d: Downloading MPD manifest
[Mediasite] c63b969f11ff44c88b10249d51a86a2d1d: Downloading ISM manifest
WARNING: [Mediasite]  is not a supported codec
[Mediasite] c63b969f11ff44c88b10249d51a86a2d1d: Downloading MPD manifest
[Mediasite] c63b969f11ff44c88b10249d51a86a2d1d: Downloading ISM manifest
WARNING: [Mediasite]  is not a supported codec
[Mediasite] c63b969f11ff44c88b10249d51a86a2d1d: Downloading MPD manifest
[Mediasite] c63b969f11ff44c88b10249d51a86a2d1d: Downloading ISM manifest
WARNING: [Mediasite]  is not a supported codec
[Mediasite] c63b969f11ff44c88b10249d51a86a2d1d: Downloading MPD manifest
[info] Available formats for c63b969f11ff44c88b10249d51a86a2d1d:
format code              extension  resolution note
video2-1.6-2_A_audio_1   m4a        audio only DASH audio  126k , m4a_dash container, mp4a.40.2 (44100Hz)
video2-1.2-2_A_audio_10  m4a        audio only DASH audio  128k , m4a_dash container, mp4a.40.2 (44100Hz)
video1-0.6-2_A_audio_1   m4a        audio only DASH audio  126k , m4a_dash container, mp4a.40.2 (44100Hz)
video1-0.2-2_A_audio_5   m4a        audio only DASH audio  128k , m4a_dash container, mp4a.40.2 (44100Hz)
video2-1.0-video-296     ismv       400x224     296k , AVC1, video only
video2-1.2-1_V_video_9   mp4        400x224    DASH video  296k , mp4_dash container, avc1.42400d, video only
video2-1.0-video-496     ismv       400x224     496k , AVC1, video only
video2-1.2-1_V_video_8   mp4        400x224    DASH video  496k , mp4_dash container, avc1.42400d, video only
video2-1.0-video-796     ismv       640x360     796k , AVC1, video only
video2-1.2-1_V_video_7   mp4        640x360    DASH video  796k , mp4_dash container, avc1.42401e, video only
video2-1.0-video-1296    ismv       640x360    1296k , AVC1, video only
video2-1.2-1_V_video_6   mp4        640x360    DASH video 1296k , mp4_dash container, avc1.4d401e, video only
video2-1.4-video-1498    ismv       960x540    1498k , AVC1, video only
video2-1.6-1_V_video_2   mp4        960x540    DASH video 1498k , mp4_dash container, avc1.4d001f, video only
video2-1.0-video-1596    ismv       960x540    1596k , AVC1, video only
video2-1.2-1_V_video_5   mp4        960x540    DASH video 1596k , mp4_dash container, avc1.4d401f, video only
video2-1.0-video-2596    ismv       960x540    2596k , AVC1, video only
video2-1.2-1_V_video_4   mp4        960x540    DASH video 2596k , mp4_dash container, avc1.4d401f, video only
video2-1.0-video-3313    ismv       1280x720   3313k , AVC1, video only
video2-1.2-1_V_video_3   mp4        1280x720   DASH video 3313k , mp4_dash container, avc1.4d401f, video only
video2-1.0-video-4596    ismv       1280x720   4596k , AVC1, video only
video2-1.2-1_V_video_2   mp4        1280x720   DASH video 4596k , mp4_dash container, avc1.4d4020, video only
video2-1.0-video-5596    ismv       1920x1080  5596k , AVC1, video only
video2-1.2-1_V_video_1   mp4        1920x1080  DASH video 5596k , mp4_dash container, avc1.4d4028, video only
video1-0.0-video-296     ismv       400x224     296k , AVC1, video only
video1-0.2-1_V_video_4   mp4        400x224    DASH video  296k , mp4_dash container, avc1.42400d, video only
video1-0.0-video-496     ismv       400x224     496k , AVC1, video only
video1-0.2-1_V_video_3   mp4        400x224    DASH video  496k , mp4_dash container, avc1.42400d, video only
video1-0.0-video-796     ismv       640x360     796k , AVC1, video only
video1-0.2-1_V_video_2   mp4        640x360    DASH video  796k , mp4_dash container, avc1.42401e, video only
video1-0.0-video-1296    ismv       640x360    1296k , AVC1, video only
video1-0.2-1_V_video_1   mp4        640x360    DASH video 1296k , mp4_dash container, avc1.4d401e, video only
video1-0.4-video-1499    ismv       960x540    1499k , AVC1, video only
video1-0.6-1_V_video_2   mp4        960x540    DASH video 1499k , mp4_dash container, avc1.4d001f, video only
video2-1.1               m3u8       unknown
video2-1.5               m3u8       unknown
video2-1.3               mp4        unknown
video1-0.1               m3u8       unknown
video1-0.5               m3u8       unknown
video1-0.3               mp4        unknown    (best)
$ youtube-dl -f 'video1-0.3,video2-1.3' -o '%(title)s.%(format_id)s.%(ext)s' 'https://lecturecapture.wustl.edu/mediasite/Play/c63b969f11ff44c88b10249d51a86a2d1d'

This will download multiplex 0 of type 'video1' as one file, and multiplex 1 of type 'video2' as another. I used pre-multiplexed streams above for simplicity, but separate audio and video streams can be combined with the + operator as usual (e.g. -f 'video2-1.2-1_V_video_1+video2-1.2-2_A_audio_10'). If you want all streams in a single file, you'd have to wait for #6454 to get merged.  I used pre-multiplexed streams above for simplicity, but separate audio and video streams can be combined with the + operator as usual (e.g. -f 'video2-1.2-1_V_video_1+video2-1.2-2_A_audio_10'). If you want all streams in a single file, you'd have to wait for #6454 to get merged. I wouldn't hold my breath.


Feature/checker

What does this PR do?

Updated logrus version
Added health-go to be used as our health check package
Added Healthcheck to dockerfile
Removed logstash formatter
Added wiremock instead of actual hosts
Added more tests

👍

👍

+1