APIM - GraphQL schema requirement [text change only]

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify - Text clarification only for existing functionality: GraphQL API import requires GraphQL schema

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
No change to service
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
June 2022
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

For review: @adrianhall @hoonality

Close/reopen to retrigger build/validation


Adding service with same name after removing it on a k8s cluster fails

What's your CLI version?
0.85.36
Description & steps to reproduce

using kurtosis over a k8s cluster

kurtosis service add test-enclave test2 httpd --ports http=80
kurtosis service rm test-enclave test2
kurtosis service add test-enclave test2 httpd --ports http=80 returns:

Error:  An error occurred running command 'add'
  Caused by: An error occurred calling the run function for command 'add'
  Caused by: An error has occurred when running Starlark to add service
  Caused by: An error occurred executing instruction (number 1) at DEFAULT_PACKAGE_ID_FOR_SCRIPT[2:18]:
  add_service(name="test2", config=ServiceConfig(image="httpd", ports={"http": PortSpec(number=80, wait="30s")}, files={}, entrypoint=[], cmd=[], env_vars={}, private_ip_address_placeholder="KURTOSIS_IP_ADDR_PLACEHOLDER"))
  Caused by: Unexpected error occurred starting service 'test2'
  Caused by: Failed registering service with name: 'test2'
  Caused by: Error registering service 'test2'
  Caused by: An error occurred creating Kubernetes service in enclave '29ed5c3747464c77b14e220558541658' with ID 'test2'
  Caused by: Failed to create service 'test2' in namespace 'kt-test-enclave'
  Caused by: services "test2" already exists

Desired behavior
The service with the same name should be able to be added, in accord with functionality over Docker cluster.
What is the severity of this bug?
Painful; this is causing significant friction in my workflow.
What area of the product does this pertain to?
CLI: the Command Line Interface

@Tedi it seems that the k8s service resource is not removed when you remove the enclave's service, I don't remember well but I think it was left there for a reason, or probably it's a bug. You could double-check my assumption.
@mieubrisse Do you remember why the k8s service is not removed in this circumstance?

Yep, I have some context here but maybe not the solution - when we were developing k8s, waiting for k8s to actually remove things took a veryyyyyy long time. We instead implemented "tombstoning", where Kurtosis would say "hey k8s, clean this up" and k8s would do it on its own sweet time while Kurtosis proceeded. That said, my understanding is that service cleanup should still happen immediately (even if Pod descheduling didn't).
So my two thoughts are either:

This is tombstoning happening (in which case we'll need to think of a solution)
This is just a flat bug in Kurtosis


Append signature to file

Does this library includes to append the signature to the original file? Of not, is there an easy way to do this?

A signature is generated and appended to a newly formed, canonicalized XML document. Depending on the type of signature you are after, this may or may not be enough for you. Please provide more information about the signature spec you are after, maybe I can help with the implementation.
As far as being easy - from experience I can say that this usually isn't easy in PHP, but I should be able to guide you in the right direction.

Hi,
Thanks for your response. I have already fixed is so this can be closed.
Regards,
Ronnie
—
Verzonden via Mailbox
On Wed, Nov 18, 2015 at 6:09 PM, Marcel Tyszkiewicz
<EMAIL_ADDRESS>wrote:

A signature is generated and appended to a newly formed, canonicalized XML document. Depending on the type of signature you are after, this may or may not be enough for you. Please provide more information about the signature spec you are after, maybe I can help with the implementation.
As far as being easy - from experience I can say that this usually isn't easy in PHP, but I should be able to guide you in the right direction.
Reply to this email directly or view it on GitHub:
https://github.com/MrMarchello/php-XmlDigitalSignature/issues/2#issuecomment-157780767


Android: example build failed

What I did:

cloned repository
ran yarn install in terminal in Example folder
ran react-native run-ios -> this was ok
ran react-native run-android -> failed

What went wrong:
Execution failed for task ':app:mergeDebugResources'.
> Error: java.lang.RuntimeException: com.android.builder.internal.aapt.AaptException: AAPT2 compile failed:

before the Error appears, there are few logs of this kind
> Task :app:mergeDebugResources
/Users/Pavel/.gradle/caches/transforms-1/files-1.1/appcompat-v7-24.0.0.aar/74cbb38e018f31a50b2829379ad307ae/res/values/values.xml:235:5-90: AAPT: invalid dimen

so it may be releated to appcompat-v7-24.0.0?
my setup:

running on macOS,
trying to run on device Nexus 5X Android 8.1.0
installed versions of RN on system
react-native-cli: 2.0.1
react-native: 0.51.0

what I tried:

Run ./gradlew clean
delete node_modules and run npm install instead of yarn
installed android SDK 24.0.0 (then tried cleaning project again, restart terminal)

This issue seems to be inactive and thus I gonna close it.
If you still face the problem, please reopen it

Hey @CptFabulouso
As I've recently encountered a very similar issue on a completely different project and not related to the use of this library I decided I'll post about it here, as this issue is what I've found when googling for the aapt2 problem.
So in my case the problem was my installation of Android Studio that upgraded android gradle plugin to a beta version that for some reason was lacking the aapt2 binaries. The only thing I had to change was the gradle file located under android/build.gradle that specifies which version of android gradle plugin should be used. I changed that to version 3.1.0 that worked ok for me (android studio upgraded to 3.2-beta or sth):
dependencies {
  classpath 'com.android.tools.build:gradle:3.1.0'
}

I'm also facing same problem. I try every solution from internet. But I'm hanging with bug still.

I'm also facing same problem. I try every solution from internet. But I'm hanging with bug still.

Did you find any solution?


Release Google.Cloud.Shell.V1 version 1.0.0-beta01

Changes in this release:
Initial release.

Created release for Google.Cloud.Shell.V1-1.0.0-beta01


quojs and webpack

I like quojs,and i want to use webpack + quojs ,but I found that quojs does not seem to support the use of webpack. Hope the author adds the support ，Thank you。

@dtlovebmm1314 this fork works with webpack (well it builds at least, I have tested the functionality yet).
https://github.com/marvelapp/QuoJS/

@j0hnsmith thank you. .


Typo in "Why some Azure AD roles are for other services" section

The last sentence of the Why some Azure AD roles are for other services section should read "Service-specific roles is one category ..." rather than "Server-specific roles is one category ..."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32f33bd6-2487-d3fa-6d83-bbbe8bf4959e
Version Independent ID: dc6ceeab-09e0-4a51-d36b-a9a8e0527492
Content: Understand Azure Active Directory role concepts
Content Source: articles/active-directory/roles/concept-understand-roles.md
Service: active-directory
Sub-service: roles
GitHub Login: @curtand
Microsoft Alias: curtand

@nickamon
Thanks for your feedback! We will investigate and update as appropriate.

@nickamon
I have created a PR to update the documentation and will now close out this issue. Please allow some time for the changes to reflect and if you don't see the document update, please let me know.
I will be more than happy to re-open this issue and look into what happened.
Thank you for your time and patience!


initial 0.1.51

aws-c-s3 0.1.51
Destination channel: defaults
Links
{ticket_number}
Upstream repository
dependency for aws-crt 0.18.16 -> aws-sdk-cpp 1.10.55 -> arrow-cpp 14.0.1 -> pyarrow 14.0.1 which would address CVE

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_e6jcvsj2_p/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description

===== ERRORS =====

clone/recipe/meta.yaml:42: missing_documentation: The recipe is missing a doc_url or doc_source_url
clone/recipe/meta.yaml:42: missing_dev_url: The recipe is missing a dev_url
===== Final Report: =====
2 Errors and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(124): `conda run conda-lint /tmp/abs_00bwywrghj/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description

===== ERRORS =====

clone/recipe/meta.yaml:42: missing_dev_url: The recipe is missing a dev_url
clone/recipe/meta.yaml:42: missing_documentation: The recipe is missing a doc_url or doc_source_url
===== Final Report: =====
2 Errors and 1 Warning were found


Crash when base and class identical

Godot version: 35c1694
OS/device including version: Ubuntu
Issue description: If a script extends a given class and has the same class_name, the engine will silently crash. The project can't be reopened unless you change the "project.godot" file. It's obvious that self-inheritance will lead to problems. The engine should nonetheless not crash but print out the error.
Steps to reproduce:
Create a node and attach following script.
extends A
class_name A

Save the script.
Add another line and resave.

Might be the same problem as #9609 . If the code doesn't handle loops in inheritance there isn't much difference between loops of size 1, 2 or any other size.

I can confirm the crash in 88a36e20. It loops and crashes in GDScript::get_instance_base_type().
When loading the project with such a script saved, it no longer crashes for me though, but prints:
ERROR: load: Resource: 'res://Control.gd' is already being loaded. Cyclic reference?
   At: core/io/resource_loader.cpp:363.
SCRIPT ERROR: GDScript::reload: Parse Error: Class 'A' could not be fully loaded (script error or cyclic dependency).
   At: res://Control.gd:1.
ERROR: reload: Method/Function Failed, returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:579.

And prints this when parsing the script:
ERROR: _update_exports: Path extending itself in  res://Control.gd
   At: modules/gdscript/gdscript.cpp:461.

If you modify the script and save, it crashes.


[FluidLite] Bump to latest version

What does your PR fix?

Sorry that I already file a PR for this lib again but this PR fixes the incorrect playback of drum sounds in some MIDIs.
Therefore a version bump is required here to fix audio issues.
https://github.com/divideconcept/FluidLite/commit/fdd05bad03cdb24d1f78b5fe3453842890c1b0e8

Which triplets are supported/not supported? Have you updated the CI baseline?

FluidLite is disabled in the CI because of conflicts with FluidSynth. As this only adds the linked commit above the chance of breakage is 0 - you can verify the syntactic correctness by looking at it (to reduce confusion: The drums are on Channel 10 in the MIDI spec but the counting is from 0, so channel 9 is referenced)
I verified that the hash is correct:
> wget https://github.com/divideconcept/FluidLite/archive/fdd05bad03cdb24d1f78b5fe3453842890c1b0e8.tar.gz
> sha512sum fdd05bad03cdb24d1f78b5fe3453842890c1b0e8.tar.gz
8118bec2cb5ee48b8064ed2111610f1917ee8e6f1dc213121b2311d056da21d7f618ef50735e7653d2cccf1e96652f3ccf026101fccb9863448008918add53e0  fdd05bad03cdb24d1f78b5fe3453842890c1b0e8.tar.gz

Does your PR follow the maintainer guide?

Yes. I only bumped the version

Thanks for your contribution!


How do I use 'skip' and 'limit' in search?

Hello, great job, I would take a question.
In the example below, as I would use 'skip' and 'limit'?
local results = exampleCollection:find({color = "blue"})
Grateful

I don't think they're implemented, actually.

I'll give it a whirl soon.


Merge tables with destructuring

It would be very interesting if we can have some kind of destructuring like js has.
const obj1 = { a:1, b1: 1 }
const obj2 = { a:2, b2: 2}
const obj3 = {...obj1, ...obj2}

{
    a1: 1,
    b1: 1,
    a2: 2,
    b2: 2
}

MoonPlus compile to Lua. Lua {} != JS {}. Lua has table.unpack is close but not equal to JS "...". And we can only add syntax sugar, no magic to MoonPLus compiler.
Any thing that so specific like above "a -> a1, a2" should easy implement in user code, it not wise to pack it compiler.
Thanks and regards.

MoonPlus is a transpiler generating Lua codes. The only way to support this syntax has to be this way.
const obj1 = {a1: 1, b1: 1}
const obj2 = {a2: 2, b2: 2}
const obj3 = {a3: 2, b3: 2}
const obj4 = {...obj1, ...obj2, ...obj3}

compiled to
local obj1 <const> = {a1 = 1, b1 = 1}
local obj2 <const> = {a2 = 2, b2 = 2}
local obj3 <const> = {a3 = 2, b3 = 2}
local obj4 <const> = {}
for k, v in pairs(obj1) do
  obj4[k] = v
end
for k, v in pairs(obj2) do
  obj4[k] = v
end
for k, v in pairs(obj3) do
  obj4[k] = v
end

How about writing a helper function to serve the same purpose instead of inserting lots of codes by the transpiler?
mix = (...)->
  t = {}
  tbs = {...}
  for tb in *tbs
    for k, v in pairs tb
      t[k] = v
  t

const obj1 = {a1: 1, b1: 1}
const obj2 = {a2: 2, b2: 2}
const obj3 = {a3: 2, b3: 2}
const obj4 = mix obj1, obj2, obj3

Sounds good, thanks


Upstream ability to run commands as root via repo2docker

Carbonplan has transitioned to use repo2docker and can no longer install code-server which seem to require sudo rights. I responded that we'll explore if we can work this.
https://2i2c.freshdesk.com/a/tickets/758

I did some exploring on specifically installing code-server without being root user. It seems it can be installed with npm, but I ran into:
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package<EMAIL_ADDRESS>npm WARN EBADENGINE   required: { node: '16' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.5.0' }
npm WARN EBADENGINE }

Apparently supporting node 18 is tracked in https://github.com/coder/code-server/issues/6230

I just learned that repo2docker has an entrypoint that makes us get logs to ~/.jupyter-server-log.txt which is really helpful for us to help users help themselves instead of needing our help.
I now also ended up opining (https://github.com/jupyterhub/repo2docker/issues/1009#issuecomment-1595011655.) if the repo2docker should or shouldn't accept a feature allowing this, I think adding support for a postBuildAsRoot file makes sense. I understand that you and Min disagree though, so unless you or Min agrees of supporting something like that I figure we shouldn't go for it.

I found code-server via conda-forge, it helped downgrade node to version 16, and then it worked. I'll communicate this as a resolution to https://2i2c.freshdesk.com/a/tickets/758, and we can close this as I figure we don't need to decide on working on that feature or not if there is agreement to do it upstream.
channels:
  - conda-forge
dependencies:
  - pip
  - python=3.10.*
  - code-server
  - pip:
    - jupyter-vscode-proxy


Add/remove a tail to a multi-tail arrow

As a User, I want to add or remove a tail to/from a multi-tail arrow so that I can accurately represent the number of reactants in my synthesis tree.
Acceptance Criteria:

Right-clicking on the multi-arrow element with select or arrow tools should open a context menu with the option to "Add tail".

If the user clicks the "Add tail" option, a new tail should be added exactly in the middle between the first two tails with the biggest distance.

Right-clicking on a tail should open a context menu with the option to "Remove tail". This option should be disabled for the upper and lower tails.

If the user selects the "Remove tail" option, the selected tail should be removed from the arrow.

History events should be supported - User can Undo (Ctrl + Z)/Redo (Ctrl+ Shift + Z) actions with tails (adding, removing);

Erase tool removing the whole element, not the tail.

OUT OF SCOPE - Selection style will be implemented in a separate story - https://github.com/epam/ketcher/issues/5057

OUT OF SCOPE - The new tail must have hover and selection highlights together with the whole arrow element - https://github.com/epam/ketcher/issues/5057.

Exploratory testing is completed on the RC Remote environment:

Ketcher [Version 2.25.0-rc.1] Build at 2024-09-03; 15:37:29
Indigo Version 1.24.0-rc.1.0-gb8f099851-x86_64-linux-gnu-11.2.1
Windows 11 Enterprise
Chrome Version 128.0.6613.120 (Official Build) (64-bit)

The following checks were performed, and tests are updated:

Tails can be added/removed using right-click menu for added from the KET file Multi-Tailed Arrows according to spine lengths on Canvas with/without chemical elements:

Undo/Redo actions for adding/removing of tails for Multi-Tailed Arrows added by Tool or from KET file;
Copy-Paste and Cut-Paste actions for Multi-Tailed Arrows added by Tool or from KET file after adding/removing of tails;
Movement of Multi-Tailed Arrows added by Tool or from KET file after adding/removing of tails;

Two issues related to this feature were detected and fixed:

https://github.com/epam/ketcher/issues/5309
https://github.com/epam/ketcher/issues/5310


Repeating error: Settings sync is suspended because of successive authorization failures. Please sign in again to continue synchronizing.

Issue Type: Bug
Microsoft Authentication Log:
[Info  - 14:55:22.727] Reading sessions from keychain...
[Info  - 14:55:23.70] Got stored sessions!
[Trace  - 14:55:23.70] Read the following session from the keychain with the following scopes: email offline_access openid profile
[Info  - 14:55:23.70] Refreshing token for scopes: email offline_access openid profile
[Info  - 14:55:23.636] Token refresh success for scopes: email offline_access openid profile
[Info  - 14:55:23.642] Getting sessions for all scopes...
[Info  - 14:55:23.642] Token available from cache (for scopes email offline_access openid profile), expires in 4103993 milliseconds
[Info  - 14:55:23.642] Got 1 sessions for all scopes...
[Info  - 14:56:01.735] Getting sessions for all scopes...
[Info  - 14:56:01.735] Token available from cache (for scopes email offline_access openid profile), expires in 4065900 milliseconds
[Info  - 14:56:01.735] Got 1 sessions for all scopes...
[Info  - 15:56:18.662] Getting sessions for all scopes...
[Info  - 15:56:18.662] Token available from cache (for scopes email offline_access openid profile), expires in 448973 milliseconds
[Info  - 15:56:18.662] Got 1 sessions for all scopes...
[Info  - 15:56:18.751] Getting sessions for all scopes...
[Info  - 15:56:18.752] Token available from cache (for scopes email offline_access openid profile), expires in 448883 milliseconds
[Info  - 15:56:18.752] Got 1 sessions for all scopes...
[Info  - 16:03:17.636] Refreshing token for scopes: email offline_access openid profile
[Info  - 16:03:18.169] Token refresh success for scopes: email offline_access openid profile
[Info  - 16:03:18.172] Getting sessions for all scopes...
[Info  - 16:03:18.172] Token available from cache (for scopes email offline_access openid profile), expires in 3848996 milliseconds
[Info  - 16:03:18.172] Got 1 sessions for all scopes...
[Info  - 16:38:02.530] Getting sessions for all scopes...
[Info  - 16:38:02.530] Token available from cache (for scopes email offline_access openid profile), expires in 1764638 milliseconds
[Info  - 16:38:02.531] Got 1 sessions for all scopes...
 However for me it seems to only happen on Ubuntu 20.04 and not on Windows 10.
Can also confirm this issue happening on other devices running Ubuntu 20.04 and different vsCode configurations.
All of us are using Microsoft accounts to sync settings

This has been going on for a while now. I have it on Windows10.

I've also been seeing this issue for around 2 weeks when using a Microsoft account to sync, on Fedora Linux.

/duplicate

https://github.com/microsoft/vscode/issues/133201


Teardown developer deployment

While working on NG deployment procedure, especially when it comes to multi node deployments, developer sometimes has to restart the operation from a clean slate. This PR aims to create a single devsetup target, which will upon invocation remove as much of the previous deployment as possible. That includes crc, ansibleee, operators and all VMs.
Before merging I would squash all commits. I'm keeping them now if there are any adjustments necessary.

recheck

recheck


Fix bdb RollbackException bug

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #4977
Problem Summary(Required) ：

In bdb, after transferring the master, there may be logs in the old master that have not been synchronized to other nodes, and these logs need to be cleaned up. After cleaning these logs, the bdb environment will throw a RollbackException, and the environment should be rebuilt. So we should catch the RollbackException, and rebuild the bdb environment.
The current handling of InsufficientLogException is somewhat problematic; we should rebuild the bdb environment after synchronizing data from other nodes.
Since we handle the InsufficientLogException in the getDatabaseNames() function, there is no need to address the exception in the open() function, so remove the extra code.

[FE PR Coverage check]
:disappointed: fail : 20 / 44 (45.45%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/journal/bdbje/BDBEnvironment.java
8
30
26.67%

:large_blue_circle:
com/starrocks/journal/bdbje/BDBJEJournal.java
12
14
85.71%

I had not found the issue have anything with the issue and the commit message.
The issue describes the problem about copy the meta from a running FE.
The commit message describes a transferring problem. It makes me confused.

I had not found the issue have anything with the commit message. The issue describes the problem about copy the meta from a running FE. The commit message describes a problem that results from transferring master. It makes me confused.

The cases that transfer master and remains log that not synchronized to other nodes is not easy to reproduce. So I just manually simulated a scenario with the same result in issue. But actually it is the transferring master that causes the result in the production environment.

Glad to see so many comments.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.gengjun-git seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

[FE PR Coverage check]
:disappointed: fail : 20 / 44 (45.45%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/journal/bdbje/BDBEnvironment.java
8
30
26.67%

:large_blue_circle:
com/starrocks/journal/bdbje/BDBJEJournal.java
12
14
85.71%

[FE PR Coverage check]
:disappointed: fail : 20 / 47 (42.55%)
file detail

path
covered line
new line
coverage

:large_blue_circle:
com/starrocks/journal/bdbje/CloseSafeDatabase.java
0
3
00.00%

:large_blue_circle:
com/starrocks/journal/bdbje/BDBEnvironment.java
8
30
26.67%

:large_blue_circle:
com/starrocks/journal/bdbje/BDBJEJournal.java
12
14
85.71%


Run integTests against remote cluster

This task depends on the cdk being worked on by perf test team. It requires cdk to spin up single/multi node clusters which can be used by integTest job

[Triage]: We will revisit this in 2.0 version

We don't need this task, performance testing already has a way to do this


Less performance in .net framework

Is there any problem or why I am getting huge CPU usage and less throughput in .Net framework?
In .Net Core and .Net 5 it's working great.
Most of the cpu usage in this call

bool buildSuccess = await msg.BuildFromStream(token).ConfigureAwait(false);

Thanks in advance.

Hi @shanto462 which version of the library and which version of .NET Framework are you using?  Do you see the CPU utilization go high when it's idle, or only when receiving a message?
Also do you see this same behavior in the Test.Client and Test.Server projects?
Cheers, Joel

Thank you @jchristn for responding.

I tried with .Net Framework 4.72 and 4.8.
I am using the latest version of the library.
CPU utilization is going high when receiving a message.
I faced really bad performance in the Test.Throughput project comparing with .net core and .net 5.
I was testing by sending 10000 messages from a client.
It took 3-4 seconds to transfer all the messages. But client was using up to 60% of the cpu. And server is taking few minutes to receive all the message and cpu usage is same as client. My cpu is core i 7 9900k. so I guess 60% of the cpu is huge deal.
But in .net core and .net 5, cpu usage is nothing to be worried and time is as expected.

Hi @shanto462 thanks for the kind words.  What message size were you using in the Test.Throughput project?  I just tested with 4 clients, 4096 messages, 65536 bytes/message on .NET Framework 4.6.1
Results:
  Number of clients             : 4
  Number of messages per client : 4096

  Expected message count        : 16384
  Messages sent successfully    : 16384
  Messages failed               : 0

  Expected bytes                :<PHONE_NUMBER>
  Bytes sent successfully       :<PHONE_NUMBER>
  Bytes received successfully   :<PHONE_NUMBER>

  Elapsed time (ms)             : 0ms
  Elapsed time (seconds)        : 1s

  Messages per second           : 16384 msg/s
  Bytes per second              :<PHONE_NUMBER>B/s
  Kilobytes per second          : 1048576kB/s
  Megabytes per second          : 1024MB/s

CPU utilization spiked as expected, but dropped quickly.
I'll also re-target to both 4.7.2 and 4.8 on my side to see if I can reproduce.

Results from 4.7.2:
Results:
  Number of clients             : 4
  Number of messages per client : 4096

  Expected message count        : 16384
  Messages sent successfully    : 16384
  Messages failed               : 0

  Expected bytes                :<PHONE_NUMBER>
  Bytes sent successfully       :<PHONE_NUMBER>
  Bytes received successfully   :<PHONE_NUMBER>

  Elapsed time (ms)             : 0ms
  Elapsed time (seconds)        : 1s

  Messages per second           : 16384 msg/s
  Bytes per second              :<PHONE_NUMBER>B/s
  Kilobytes per second          : 1048576kB/s
  Megabytes per second          : 1024MB/s

Results from 4.8:
Results:
  Number of clients             : 4
  Number of messages per client : 4096

  Expected message count        : 16384
  Messages sent successfully    : 16384
  Messages failed               : 0

  Expected bytes                :<PHONE_NUMBER>
  Bytes sent successfully       :<PHONE_NUMBER>
  Bytes received successfully   :<PHONE_NUMBER>

  Elapsed time (ms)             : 0ms
  Elapsed time (seconds)        : 1s

  Messages per second           : 16384 msg/s
  Bytes per second              :<PHONE_NUMBER>B/s
  Kilobytes per second          : 1048576kB/s
  Megabytes per second          : 1024MB/s

What message size were you using from the client?  Were you using single client or multiple clients?  Which OS and version were you using?  My tests were done on Win10 Pro on my laptop; it's 16GB with an i7-8550U, which is definitely less powerful than yours, so something weird must be going on.

Now I was using the async variant of the send function.
That function was causing problem for me.
Now it is ok, but there is a lot difference between .net framework and .net core/ .net 5 performance

Ok - let me try amending Test.Throughput to include an async variant.  Will report back and see how they compare.

Just pushed an update with async variants for Test.Throughput, here are the results.  All tests were 4 clients sending 4096 messages of size 65536 using async send.
net461
Results:
  Number of clients             : 4
  Number of messages per client : 4096

  Expected message count        : 16384
  Messages sent successfully    : 16384
  Messages failed               : 0

  Expected bytes                :<PHONE_NUMBER>
  Bytes sent successfully       :<PHONE_NUMBER>
  Bytes received successfully   :<PHONE_NUMBER>

  Elapsed time (ms)             : 0ms
  Elapsed time (seconds)        : 1s

  Messages per second           : 16384 msg/s
  Bytes per second              :<PHONE_NUMBER>B/s
  Kilobytes per second          : 1048576kB/s
  Megabytes per second          : 1024MB/s

net472
Results:
  Number of clients             : 4
  Number of messages per client : 4096

  Expected message count        : 16384
  Messages sent successfully    : 16384
  Messages failed               : 0

  Expected bytes                :<PHONE_NUMBER>
  Bytes sent successfully       :<PHONE_NUMBER>
  Bytes received successfully   :<PHONE_NUMBER>

  Elapsed time (ms)             : 0ms
  Elapsed time (seconds)        : 1s

  Messages per second           : 16384 msg/s
  Bytes per second              :<PHONE_NUMBER>B/s
  Kilobytes per second          : 1048576kB/s
  Megabytes per second          : 1024MB/s

net48
Results:
  Number of clients             : 4
  Number of messages per client : 4096

  Expected message count        : 16384
  Messages sent successfully    : 16384
  Messages failed               : 0

  Expected bytes                :<PHONE_NUMBER>
  Bytes sent successfully       :<PHONE_NUMBER>
  Bytes received successfully   :<PHONE_NUMBER>

  Elapsed time (ms)             : 0ms
  Elapsed time (seconds)        : 1s

  Messages per second           : 16384 msg/s
  Bytes per second              :<PHONE_NUMBER>B/s
  Kilobytes per second          : 1048576kB/s
  Megabytes per second          : 1024MB/s

I'm having a hard time reproducing what you are seeing - could you reduce the code down to something you can share that highlights the behavior?  Definitely want to help get to the bottom of this...  Thanks, Joel

I don't know what is going on. I am using the Test.Throughput  Project.
I was thinking is there any problem with stream.readasync() method in .net framework.
This method is the critical path.

This is the result I am getting
using 1 client, 65536 message size and 4096 messages :(

Messages sent after 31 seconds
Waiting on 108 to complete processing (1 second pause)
Results:
Messages sent successfully     : 4096
Messages failed                : 0
Bytes sent successfully        : 268435456
Bytes received successfully    : 268435456
Elapsed time sending (ms)      : 31911ms
Elapsed time sending (seconds) : 31s
Send bytes per second          : 8659208.26B/s
Send kilobytes per second      : 8456.26kB/s
Send megabytes per second      : 8.26MB/s

After starting without any debugger
Too much difference but still lacking performance than .net core and .net 5

Messages sent after 5 seconds
Waiting on 108 to complete processing (1 second pause)
Results:
Messages sent successfully     : 4096
Messages failed                : 0
Bytes sent successfully        : 268435456
Bytes received successfully    : 268435456
Elapsed time sending (ms)      : 5322ms
Elapsed time sending (seconds) : 5s
Send bytes per second          : 53687091.2B/s
Send kilobytes per second      : 52428.8kB/s
Send megabytes per second      : 51.2MB/s

Hi @shanto462 were you able to find anything more on this?  I wasn't able to reproduce on my end, and you mentioned you were using the test.throughput project - were you able to use ANTS or something similar to track it down?  If not I'll close.

Hi @shanto462 were you able to find anything more on this?  I wasn't able to reproduce on my end, and you mentioned you were using the test.throughput project - were you able to use ANTS or something similar to track it down?  If not I'll close.


[CARBONDATA-3789]Fix cache issue in case of compaction failure in compaction post listeners

Why is this PR needed?
Consider a scenario where the post-event Is called in case of compaction and then the listener is basically selecting the ongoing compacted segment data and loading SI table load after main table compaction. During that time the cache is loaded, if in case this is failed, then the cache is still present but the actual segment isn't, so which will lead to consecutive failures.
What changes were proposed in this PR?
So, when the failure happens, the cache should be cleared either in the index server or in the driver cache.
Does this PR introduce any user interface change?

No

Is any new test case added?

No

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2904/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1187/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1190/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2907/

@akashrn5 : Issue is happening when a segment is removed from main table but cache is not cleaned right?
When the SI table compaction disable why not just disable SI, why need to remove whole segment of main table ?

@akashrn5 : Issue is happening when a segment is removed from main table but cache is not cleaned right?
When the SI table compaction disable why not just disable SI, why need to remove whole segment of main table ?

@ajantha-bhat , once the main table compaction is finished, say example, 0.1 for segments 1, 2, then 0.1 segment data of the main table is selected and loaded to SI table's 0.1 segment. So if while loading 0.1 to SI fails, then 0.1 entry won't be present in the main table, and the cache will have this entry for the main table.
So when next time again the same 0.1 is compacted for 0,1 segments as it was failed before, in SI it will fire a select query to 0.1 of the main table, since the cache is not cleared, it will try for old carbondata files and say file not found.

So if while loading 0.1 to SI fails, then 0.1 entry won't be present in the main table

This is what I mean, why we need to fail the main table compaction when SI compaction fails ?

we can load SI separately from compacted segments later from rebuild/refresh command

we do not have any refresh command for SI FYI. as we haven't made it like the other indexed on carbon table. So this is the old behavior.

compacting whole main table again will take huge time, as maintable already compaction is success we should handle like other datamaps.

compacting whole main table again will take huge time, as maintable already compaction is success we should handle like other datamaps.

main table compaction is success functionally, but not yet committed as success segment in metadata. So handling like other datamaps is altogether new requirement. cannot handle here.

ok. LGTM


Migrate git proxy helpers to use Open3

What was the end-user problem that led to this PR?
The problem was that git proxy helpers had a few pending TODOs.
What was your diagnosis of the problem?
My diagnosis was that we should get the TODOs done, because now they can be done.
What is your fix for the problem, implemented in this PR?
My fix is to fix the TODOs by migrating git proxy helpers to use Open3 instead of backticks.
Why did you choose this fix out of the possible options?
I chose this fix because it works.

Any reviews anybody? :)

@bundlerbot r+

@bundlerbot retry

@bundlerbot r=hsbt


4.1.x: Rebuild for pcre21040

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Just cherry-picked commits from main and rerendered.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

(Windows build are just flaky for now. Note to self: Fix miktex to be more reliable and not do post-install things etc...)


Add ostree support

This PR is a MVP. For some image types the details page will be empty but instead of changing the routing I am leaving it empty since soon other blueprint customization will be added to the wizard and the routing would need to be changed back.
Also see issue https://github.com/osbuild/cockpit-composer/issues/1465

Maybe not relevant for the first version, but might make sense to look at how these things are done in edge fleet managment in crc if we can steal anything from there.

Maybe not relevant for the first version, but might make sense to look at how these things are done in edge fleet managment in crc if we can steal anything from there.

@teg Unfortunately they don't allow customizations and only build RHEL for Edge Commit (.tar) and RHEL for Edge Installer (.iso) image types.
I do want to steal their review page though :) I think it is very clean.

Everything looks good to me, I think we can merge!


refactor: remove arrow_batchtes_to_json

This PR addresses the first part of issue #24981. It replaces the usage of &arrow_json::writer::record_batches_to_json_rows(batches.as_slice())? with arrow_json::ArrayWriter in the file influxdb3_server/src/http.rs.

[x] I've read the contributing section of the project README.
[x] Signed CLA (if not already signed).

The change itself looks solid, but I think that this is a good opportunity to add some more tests for JSON formatted output, to guard against regressions.
I took a look around and from what I see the only test that confirms that this works is here:
https://github.com/influxdata/influxdb/blob/a5eba2f8f25d8a6dd1ea9237a7278427853473d4/influxdb3_server/src/lib.rs#L343-L355
Can you add an end-to-end query test that verifies this functionality? We have several such tests in this file, but the existing tests for the v3 query APIs only assert on pretty formatted table output. You could add a test for JSON formatted output. There is an example of asserting on JSON output for the v1 query API here:
https://github.com/influxdata/influxdb/blob/a5eba2f8f25d8a6dd1ea9237a7278427853473d4/influxdb3/tests/server/query.rs#L516-L517

I've added an end-to-end test. WDYT?

@JeanArhancet I will follow up on the build failures with my team on Monday. Those may not be related to your PR.

Hey @JeanArhancet I think that the fix for the build was recently merged to main in https://github.com/influxdata/influxdb/pull/25044, but that may have merged after you created your fork.
Can you try updating your fork and rebasing off main?

Hey @JeanArhancet I think that the fix for the build was recently merged to main in https://github.com/influxdata/influxdb/pull/25044, but that may have merged after you created your fork.
Can you try updating your fork and rebasing off main?

Done @hiltontj


id2label and label2id setup for inference

I have add the id2label and labnel2id top the pretrained model, I know this is a Sentence Transformer model but I dont know if there is a way to pass the label mapper to the head of the SetFitModel
model = SetFitModel.from_pretrained("sentence-transformers/paraphrase-mpnet-base-v2",num_labels=num_classes,id2label=id2label,label2id=label2id)
In that way in inference time we just call the SetFit Model

Hey @rjac-ml indeed the current way we save the model isn't ideal because the config.json file is missing the label2id and id2label mappings.
I'll add this when I get some time (unless you'd like to open a PR yourself, which is certainly welcome!)

Closed via #439


New rule: no-implicit-package-dependencies

I'd like a new rule to raise a lint error when I import a module that is not explicitly declared in the dependencies block of package.json. Like this eslint plugin: https://github.com/lennym/eslint-plugin-implicit-dependencies.
Motivation: this problem is an unresolved question when using dependency hoisting in monorepos: https://github.com/yarnpkg/rfcs/blob/master/implemented/0000-workspaces-install-phase-1.md#unresolved-questions
We should consider adding a linter configuration option to specify the location of package.json similar to --project (maybe --manifest). Alternatively, we could walk up the folder tree until we find a package.json for each linted file/folder (potentially expensive).

:-1: for --manifest
Currently there is no way for rules to access anything but their config. We should not introduce some special behavior just for one rule.
Specifiying the path in tslint.json as rule option won't work, because we cannot resolve relative paths without knowing where the config comes from.
:+1: for using the findup approach. Although there might be a performance hit, we only have to do this once for every file that contains imports from node_modules.
Caching comes to mind, but that's not really possible as we don't know when to clear the cache. Ideally the host system caches these recurring file system operations and we don't need to worry.

Fair points, findup seems fine to me.

Do we need to handle path mappings specified in tsconfig.json?
https://www.typescriptlang.org/docs/handbook/module-resolution.html#path-mapping

The rule should have a "dev" option to also look at devDependencies.
That option could then be enabled for tests.


Event Hub Scaler logic is not properly accounting for initial state of empty EventHub partitions

Numerous test have proven that the KEDA Azure Event Hub scaler on a greenfield Event Hub the scaling mechanism does not handle the unprocessedEventCountInPartition correctly and sets the scale metric to a large number which causes the HPA to scale to the maximum.
I believe the issue is with the logic in this function:
https://github.com/kedacore/keda/blob/c2b901b8031c39975fb9ab199304e3986c4e0c31/pkg/scalers/azure_eventhub_scaler.go#L119-L146
Specifically lines 132-142
This issue was also observed by @Christle in https://github.com/kedacore/keda/pull/798#issuecomment-623264756

Looking into it.

The reason for that is the initial state of lastsequencenumber -1. If there is already a checkpoint inside the storage account, but partitioninfos with lastsequencenumber -1 exists, then it runs to line unprocessedEventCountInPartition = (math.MaxInt64 - partitionInfo.LastSequenceNumber) + checkpoint.SequenceNumber. This make no sense with -1. And you get a high number. When Messages comes in, the problem is gone. Except in our case where the messages comes over an iot hub into the event hub. Then the lastsequencenumberstays on -1 and will not increment.
But i think, this is easy to solve with a returns 0 on -1.

i will add small fix into the PR #798

@christle  - I've a fix for this issue in this PR
https://github.com/kedacore/keda/pull/848

@christle - I've a fix for this issue in this PR
#848

ok, thanks

@christle - I've a fix for this issue in this PR
#848

ok, thanks

Should this one be closed?

Jup, this should land in v1.5!


Update documentation design

I saw https://github.com/DFE-Digital/govuk-components/pull/279 and got distracted…

updates homepage content and illustration
uses a design more aligned to GOV.UK design system (controversial, but plenty of other tools use the font and crown)
refactors CSS into components
uses simpler and more consistent Slim markup
fixes manual line wrapping to meet 80 characters
uses smart quotes
combines rendered and HTML output into tab UI
renames fields to use same names as used in the GOV.UK Design System docs
copies govuk-frontend assets, styles and JavaScript (using postinstall in package.json – is there a way to do this with Nanoc?)

Sorry this is one big PR, but I got carried away 😊

A few thoughts having gone through this exercise…

Can I just register my long held hatred of whitespace dependent syntax. HAML, Slim, Sass, CoffeeScript, Pug… absolutely awful and pointless exercises. Made updating the guide much harder as had to relearn/figure out how HTML and Ruby is represented in this alternate bizarro universe where using a curly brace or semicolon is somehow considered a sin 🤬 </rant>
Is there a better option than Nanoc for the guide? It’d be much easier to write/update Markdown content files rather than write Slim. You’d ideally want a generator that allowed you to insert Ruby partials.
Related, is there a generator that would allow you to use the GOV.UK components gem for many of these partials? Maybe this is possible with Nanoc?

Thank you so much for this ❤
I'm totally open to improving the docs and making it easier for people to contribute. Even though I love proper Sass syntax I understand it's marmiteesque, I'll switch that over to SCSS.
Originally, way back, I tried various static site generators and Nanoc (which is more of a build-your-own SSG kit really) was the only one that made it straightforward for me to integrate the library directly. I do hear you though, and will take a closer look at making it more straightforward. Markdown's already a first class citizen in Nanoc, but as you say, we just need a way of injecting partials.
Having had a quick look, the one downside to using a three-quarters column is that the code blocks often get chopped and need a bit of sideways scrolling. Perhaps they can keep their full width but the other elements are limited to 75% - something like this maybe?

Either way, huge thanks for the effort. Massive improvements (and no more shady symlinks 😂).


next export Error: No router instance found

Bug report
Describe the bug
When i export my app i get following error:-
Error: No router instance found.
You should only use "next/router" inside the client side of your app.
app works perfectly fine with next build, next start and next command  but fails for following export command:-

next export -o public

Here is the output of above command:-
next export -o public

using build directory: /home/sumit/Documents/projects/opensource/project/.next
copying "static" directory
copying "static build" directory
No "exportPathMap" found in "next.config.js". Generating map from "./pages"
exporting path: /404
true
exporting path: /about
true
exporting path: /chapter_leader
true
exporting path: /code_schools
true
exporting path: /faq
true
exporting path: /get_involved
true
exporting path: /history
true
Error: No router instance found.
You should only use "next/router" inside the client side of your app.

at throwIfNoRouter (/home/sumit/Documents/projects/opensource/project/node_modules/next/dist/lib/router/index.js:110:11)
at Object.get (/home/sumit/Documents/projects/opensource/project/node_modules/next/dist/lib/router/index.js:65:7)
at OutboundLink_OutboundLink (/home/sumit/Documents/projects/opensource/project/.next/server/static/_DxySqg9SIvl5Y3zScEb6/pages/_app.js:200:85)
at d (/home/sumit/Documents/projects/opensource/project/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:29:492)
at za (/home/sumit/Documents/projects/opensource/project/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:31:494)
at a.render (/home/sumit/Documents/projects/opensource/project/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:36:147)
at a.read (/home/sumit/Documents/projects/opensource/project/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:35:333)
at renderToString (/home/sumit/Documents/projects/opensource/project/node_modules/react-dom/cjs/react-dom-server.node.production.min.js:47:6)
at renderPage (/home/sumit/Documents/projects/opensource/project/node_modules/next/dist/server/render.js:319:26)
at Function.getInitialProps (/home/sumit/Documents/projects/opensource/project/node_modules/next/dist/server/document.js:65:25)

error Command failed with exit code 1.
Package information

next(7.0.2)
react(^16.6.0)

Additional context
Please let me know if any further details are required to understand this problem.

Can you provide a minimal reproduction in a GitHub repository?

@timneutkens  Please check above referenced pull request.

I just ran the latest master branch yarn build and then yarn export -o public and both worked perfectly.


coral-hive: handle t.* correctly

The existing code treats t.* as *, which is apparently incorrect.

Thanks @uzshao for this patch. LGTM.
Will approve once integration tests pass.


SSL causes cypher mismatch

I've gotten the application running on AWS's EKS product. I'm trying to get the domain to resolve correctly. I have ssl enabled for each of the services in the chart and have been able to get the IP for the ingress controller. I'm using Cloudflare for my DNS provider and have added an un-proxied A record that points to the external IPV4 for the ingress controller.
When I try to access the application, however, I get an error that the browser can't get a secure connection - Unsupported protocol The client and server don't support a common SSL protocol version or cipher suite.
@dcrdev is there additional setup necessary on Cloudflare to get ssl to terminate correctly?

@cmbirk if this is unproxied, then it likely has little to do with cloudflare as it's just dns, unless you are using dnssec (dns over tls) . Couple of questions:
Is this still using the nginx default ssl cert? If this is the case, it's self signed and issued against localhost and is therefore invalid and will not work be valid to any browser when accessed raw. With cloudflare full encryption - this doesn't matter for dev environments when proxied, as e2e encryption is maintained, it's just not validating the ca issuer. In production I would recommend using strict mode and either buying a certificate or using a cloudflare origin certificate  : https://dash.cloudflare.com/account_id_goes_here/domain_goes_here/ssl-tls/origin .
What is the output of?
## find name of an nginx controller pod
$ kubectl get pod

$ kubectl logs <name_of_nginx_controller_pod> | tail -n 1000

If it is actually proxied:

Are you using the nginx default certificate:

Yes: it's self signed - make sure strict mode is off in cloudflare security, so that it's not validating the certificate; this will not work. If you have selected strict from the get go - cf will likely be unable to issue a csr for it's own certificates.
No: have you made sure that both private key and certificate are in pem format, are b64 encoded and referenced correctly in the ingress config inside the helm chart.

@dcrdev when I proxy the domain on Cloudflare I get a 525 error from Cloudflare saying the SSL handshake failed.
I am using the nginx default cert. I haven't installed any other certs, and I'm using Cloudflare full security ( not strict ).
Requested logs are included below:
logs.txt

The logs show the process sighup repeatedly, also shows that the tls secret does not exist. Is your cluster rbac enabled?
Either way at this point I would just create the secret yourself and rather than generate a new self-signed cert, I would use an origin certificate:

Click create cert

Generate cert with rsa

Save cert and key

Copy the cert (1st box) into a raw text file called cert.pem, do the same for the second box except call it key.pem; make sure to copy all of it including begin/end.

Create the secret

kubectl create secret tls tls-secret \
    --key key.pem \
    --cert cert.pem

Reload the controller

kubectl delete pod <controller_pod> #helm will bring the pod back for you automatically here

That appears to have worked for the root domain! I'm getting errors in the web pod not being able to access the api, however. The specific error I'm getting is:
Error: Network error: request to https://api.shop.example.com/graphql failed, reason: getaddrinfo ENOTFOUND api.shop.example.com api.shop.example.com:443

I'm trying to run this at a multi-level subdomain.
Eg. ( using example.com )
shop.example.com - web
api.shop.example.com - api
etc, etc.
I have the certificate set up for *.example.com, *.shop.example.com, example.com, and shop.example.com. I also have CNAME records pointing api.shop to shop.example.com.
Does it make sense that the CNAME DNS records wouldn't be resolving inside the cluster? I'm also not able to get a secure connection to the api.shop.example.com subdomain. Do these need different DNS records?
I appreciate all of the help @dcrdev !

BTW, I've replaced the actual urls with examples above

It appears that the default Cloudflare certs don't cover multilevel subdomains

Yeah it needs to be a separate dns entry for multi-level, or a wildcard one with cname flattening.
I don't use multi-tiered subdomains myself, so haven't really tried it on cloudflare origin certs; but looks possible:

^ It wouldn't let me have two levels of wildcards, but you can add static entries.
Either way the validity of it doesn't matter too much for dev, thee important part is the encryption between origin and cf. Other if you need sa validation, other options are:

Generate your own wildcard sa certificate:

$ cat << EOF > openssl.conf
[req]
req_extensions = v3_req
[v3_req]
subjectAltName = @alt_names
[alt_names]
DNS.1 = *.example.com
DNS.2 = *.shop.example.com
EOF

$ openssl req -new -newkey rsa:2048 -sha256 -nodes -out cacert.csr -keyout cacert.key -config openssl.conf
$ openssl x509 -req -sha256 -days 365 -in cacert.csr -signkey cacert.key -out cacert.crt

LetsEncrypt via cert-manager - https://docs.bitnami.com/tutorials/secure-kubernetes-services-with-ingress-tls-letsencrypt (step 3)

I've tried this on a regular domain as well. I'm thinking the web pod can't access external urls? Is that a possibility?
I'm able to load https://api.example.com/graphql in my browser, but the web node is erroring with:
Error: Network error: request to https://api.example.com/graphql failed, reason: getaddrinfo ENOTFOUND api.example.com api.example.com:443

It looks like this was a lag in DNS propagation. It's running!
Thank you so much @dcrdev and keep an eye out for a documentation PR :)

This looks to be solbed.


General Release

Description

Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


vim: color with syntax=haskell

filetype=haskell breaks autocmd FileType ghcid, this pr uses syntax=haskell to enable highlighting instead

Thanks for the patch. CC @cloudhead as the maintainer of the Vim mode. (Please ignore the CI failures, they aren't related to this work)

Thanks for the patch. CC @cloudhead as the maintainer of the Vim mode. (Please ignore the CI failures, they aren't related to this work)

Thanks!

Thanks!


Move Let's Encrypt certificate validation to DNS challenge  #2

This is just updated original  PR #342, since we solved the issue with wildcard DNS. CP of original text:
This PR moves Let's Encrypt ACME certificate validation to DNS challenge (prereq to Istio deployment). It also addresses couple of related issues (see GPII-3781 for detials ).
Changes introduced:

Change ACME validation method to dns01
~Add dedicated service account for cert-manager for DNS challenge~ - this has already been merged in
Move cert-manager (Cluster)Issuer inside gpii-flowmanager and gpii-preferences charts
Change email used for Let's encrypt to ops@, or individual user emails for non-prod/stg envs

Since current implementation of ClusterIssuer will leave resources behind, cleanup should be done in non-ephemeral envs:
kubectl delete clusterissuer letsencrypt-production
kubectl delete clusterissuer letsencrypt-staging

[ ] Cleanup STG
[ ] Cleanup PRD

LGTM

Tested and working, LGTM


webpack: create directories if they do not exist

create directories for webpack aliases if they do not exist
formatted prettierjs
closes inveniosoftware/invenio-theme#204

Do you see any problem cleaning up the following if this is merged?

.gitkeep files that serve as directory placeholders for the initial build to work
dirty solution on bootstrap script of cookiecutter-invenio-instance

Outcome of IRL discussions: We will add a templates folder in cookiecutter-invenio-instance.
@topless Can I get you to remove the folder creation part, and then we merge the formatting changes part of the PR.


glob expression + log format

Allow to call markdown-table-formatter with a glob parameter to find files to format
Allow to call markdown-table-formatter without arguments (**/*.md will be used by default to collect files)
Fix logs format

Codecov Report

Merging #9 (be8afcc) into master (4fdcbd0) will increase coverage by 0.62%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   84.50%   85.13%   +0.62%
==========================================
  Files           4        4
  Lines          71       74       +3
==========================================
+ Hits           60       63       +3
  Misses         11       11

Impacted Files
Coverage Δ

lib/cli.js
82.05% <85.71%> (+1.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fdcbd0...be8afcc. Read the comment docs.


Community Exchange Introduction/Tracking

👋 Hi @AkashSingh3031 ,
I am your GitHub mentor for the GitHub Education, Community Exchange (CX) project. I'll be collaborating with you on preparing your repo for CX.
You mentioned in your submission that you wanted to submit a Learn + Collaborate repo. This means that you would like to teach students, step by step, how to build this project as well as invite other students to collaborate and add features to this repo. I will generate issues, which will provide guidance on how to prepare your repo for a Learn + Collaborate CX submission on June 1, 2022.
This issue will serve as a tracking issue to track all issues related to CX. I recommend creating a new branch for every issue and opening a pull request to track changes so we can effectively collaborate with each other and merge changes when you and I feel like those changes are ready to be merged on your primary branch.
Your repo is already in great shape! I am very impressed with it's current state so there won't be too much I will recommend for updates/changes 😅
If you have any questions or concerns, please feel free to leave a comment on this issue or any of the other issues that are generated.
I look forward to working with you :octocat:
Issues

[x] https://github.com/AkashSingh3031/The-Complete-FAANG-Preparation/issues/263
[x] https://github.com/AkashSingh3031/The-Complete-FAANG-Preparation/issues/264
[x] https://github.com/AkashSingh3031/The-Complete-FAANG-Preparation/issues/265

Thank You @ericdrosado Sir!
I am ready to work on this repo under your guidance.

@ericdrosado Sir!
Check the repo
If any changes are required then comment here

@AkashSingh3031 you are all set for now. I will send you a message next week on next steps to submit your repository! 🎉

@AkashSingh3031 you are all set for now. I will send you a message next week on next steps to submit your repository! 🎉

Ok, Sir


ClassNotFoundException with langchain4j 0.17 and Quarkus 3.13.3

Describe the bug
After executing quarkus:dev on a new empty project directly downloaded from code.quarkus.io with langchain4j I receive a ClassNotFoundException
2024-08-21 16:27:39,108 ERROR [io.qua.dep.dev.IsolatedDevModeMain] (main) Failed to start quarkus: java.lang.NoClassDefFoundError: dev/langchain4j/service/output/ServiceOutputParser
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:534)
        at java.base/java.lang.Class.forName(Class.java:513)
        at io.quarkus.deployment.util.ServiceUtil.classesNamedIn(ServiceUtil.java:29)
        at io.quarkus.deployment.ExtensionLoader.loadStepsFrom(ExtensionLoader.java:160)
        at io.quarkus.deployment.QuarkusAugmentor.run(QuarkusAugmentor.java:106)
        at io.quarkus.runner.bootstrap.AugmentActionImpl.runAugment(AugmentActionImpl.java:331)
        at io.quarkus.runner.bootstrap.AugmentActionImpl.createInitialRuntimeApplication(AugmentActionImpl.java:254)
        at io.quarkus.runner.bootstrap.AugmentActionImpl.createInitialRuntimeApplication(AugmentActionImpl.java:58)
        at io.quarkus.deployment.dev.IsolatedDevModeMain.firstStart(IsolatedDevModeMain.java:91)
        at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:430)
        at io.quarkus.deployment.dev.IsolatedDevModeMain.accept(IsolatedDevModeMain.java:57)
        at io.quarkus.bootstrap.app.CuratedApplication.runInCl(CuratedApplication.java:138)
        at io.quarkus.bootstrap.app.CuratedApplication.runInAugmentClassLoader(CuratedApplication.java:93)
        at io.quarkus.deployment.dev.DevModeMain.start(DevModeMain.java:131)
        at io.quarkus.deployment.dev.DevModeMain.main(DevModeMain.java:62)
Caused by: java.lang.ClassNotFoundException: dev.langchain4j.service.output.ServiceOutputParser
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
        at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:561)
        at io.quarkus.bootstrap.classloading.QuarkusClassLoader.loadClass(QuarkusClassLoader.java:509)
        ... 16 more

Expected behavior
to start the dev mode normally
Actual behavior
It shows the exception in the output
How to Reproduce?

go to code.quarkus.io
generate a project with langchain4j, ollama, rest, camel-langchain4j
download and unzip
mvn quarkus:dev

Output of uname -a or ver
Darwin MAC-L0153 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:04 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6020 arm64
Output of java -version
openjdk version "21.0.2" 2024-01-16 LTS OpenJDK Runtime Environment Temurin-21.0.2+13 (build 21.0.2+13-LTS) OpenJDK 64-Bit Server VM Temurin-21.0.2+13 (build 21.0.2+13-LTS, mixed mode)
Quarkus version or git rev
3.13.3
Build tool (ie. output of mvnw --version or gradlew --version)
Apache Maven 3.9.4 (dfbb324ad4a7c8fb0bf182e6d91b0ae20e3d2dd9) Maven home: /Users/jonathan.vila/.sdkman/candidates/maven/current Java version: 21.0.2, vendor: Eclipse Adoptium, runtime: /Users/jonathan.vila/.sdkman/candidates/java/21.0.2-tem Default locale: en_GB, platform encoding: UTF-8 OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
Additional information
Changing it manually to Langchain4j and ollama to 0.16 fixes the issue

Thanks for reporting.
I'll take a look when I get back next week

I don't see camel-langchain4j in code.quarkus.io. What is the exact dependency?

I don't see camel-langchain4j in code.quarkus.io. What is the exact dependency to use?

I think this may be the source of the problem, Camel has its own langchain4j component, but it's not using Quarkus at all (it's not a Quarkus extension), and most likely depends on a different langchain4j version than the Quarkus version that is used

    <dependency>
        <groupId>org.apache.camel.quarkus</groupId>
        <artifactId>camel-quarkus-langchain4j-chat</artifactId>
    </dependency>

[image: Screenshot 2024-08-26 at 09.06.46.png]
On Mon, Aug 26, 2024 at 8:00 AM Georgios Andrianakis <
@.***> wrote:

I don't see camel-langchain4j in code.quarkus.io. What is the exact
dependency to use?
—
Reply to this email directly, view it on GitHub
https://github.com/quarkiverse/quarkus-langchain4j/issues/820#issuecomment-2309384556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOALERPA4NRKDYZ4G46CG3ZTK76RAVCNFSM6AAAAABM6EFNTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZGM4DINJVGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks.
The problem is exactly what @jmartisk described and there is nothing we can do on our side.

@jamesnetherton @ppalaga maybe worth experimenting having a Camel Quarkus extension for the LangChain4j Camel component.
Also, I wonder if having a BOM for Quarkus LangChain4j would make sense? Similar to what was done here: https://github.com/quarkiverse/quarkus-amazon-services/blob/main/bom/pom.xml .
Note that we don't have a mechanism in the tooling to contribute the BOM automatically unfortunately.

Also, I wonder if having a BOM for Quarkus LangChain4j would make sense?

We already have one :)

maybe worth experimenting having a Camel Quarkus extension for the LangChain4j Camel component.

camel-quarkus-langchain4j-chat is a Quarkus extension.

depends on a different langchain4j version than the Quarkus version

They should be in sync. If you want to see which versions we align to, they're here:
https://github.com/apache/camel-quarkus/blob/3.13.x/pom.xml#L59
https://github.com/apache/camel-quarkus/blob/3.13.x/pom.xml#L138
There was a note added to the extension docs recenrly
https://camel.apache.org/camel-quarkus/next/reference/extensions/langchain4j-chat.html#extensions-langchain4j-chat-quarkus-langchain4j-bom
All of the camel-langchain4j bits are currently labelled as experimental, so there's plenty of room to improve things in this area.


Add function(s) to enable use of BC Sans font for rmarkdown/html/shiny

I also wonder if we shouldn't at least provide instructions on how to create a word template that uses BC sans as well.
Another place where this would be useful is ggplot2. We could bundle the font with the package actually a la: https://github.com/hrbrmstr/hrbrthemes/tree/master/inst/fonts

Bundling it is a great idea, and it's open license so no problem. As for a Word template, I think it's meant to be a web font, not necessarily for print (serif fonts are apparently better for print, sans for web).

I am not sure if this feature should live in the bcgovrpackage, which is focussed on set up of repos in bcgov and bcgov-c.


InvalidRequest error using Invite endpoint

I am consistently getting InvalidRequest errors when attempting to use the Invite endpoint in my project and the Graph Explorer.  This has been working, but as of this morning I have tried various iterations of the Invite request body on different SharePoint files in the Graph Explorer without success.
An example request and response is below:
Request :
POST v1.0/drives/{driveId}/items/{itemId}/invite
{
 "recipients": [
    { "email": "{email}" }
  ],
  "message": "test",
  "requireSignIn": true, // I've tested with true and false values for both of these
  "sendInvitation": true,
  "roles": [ "read"]
}

Response:
Failure - Status Code 400
{
    "error": {
        "code": "invalidRequest",
        "message": "The request is malformed or incorrect.",
        "innerError": {
            "request-id": "fced3ea6-196c-433e-8aed-48e463a5020c",
            "date": "2018-05-15T16:22:14"
        }
    }
}

Thanks for your feedback.  This issue should now be fixed.  Could you let us know if it's not, and provide a recent request-id/date?  Thanks!

Thank you for the update!  We are no longer experiencing the issue, so it does appear to have been fixed!


Add Nong Song: Coffee

Song Name
Coffee
Artist Name
Jack Stauber's Micropop
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=6D830xSFET0
Direct File Link
No response
Song ID
536893
Start Offset [ms]
0
Extra
No response

accept


Fix typo

a -> an

@changeworld : Thanks for your contribution! The author, @rayne-wiselman, has been notified to review your proposed change.

Thanks! sign-off


Add API documentation

Note that documentation in general is not finished. This just adds the skeleton for the API docs, I also didn't adapt docstrings for Sphinx style yet, it will be a separated PR.
To see the docs:

Checkout to the branch
poetry install --with docs
cd docs
make html
Open _build/html/index.html in your browser.
Use a bar on the left and go to the API documentation.

I also used built-in Sphinx type hints support (see discussion in Discord) because the second variant was buggy. Although, I like the result.

Documentation build will be fixed after #458.


Change loop to if check

Instead of looping over each menu in the cls._active_sessions list the presence of menu in the active sessions list is checked.

Good catch. Thank you


change print() calls to logging() calls

Simple fix, more professional, should be done soon

Issue planned to be resolved in issue #21 object orientated approach switch.


feat: Distinct Errors

Added RestoreError that contains the restorePreamble
Added TxError for invokeHostFunctionErrors and transaction submission errors

Closed in favor of #50


adding missing m4,d2,t2,and g2 ebs encryption flavors

I was getting this error:
--ebs-encrypted option is not supported for m4.large flavor.
I knew this was incorrect because its supported according to AWS docs:
http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/EBSEncryption.html
I put in a fix with latest instance types that support ebs encryption.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

Hello,
I thought you might be interested it that new and very nice stuff, just take a look here http://parawycro.ericevangelista.com/oiaucllt
<EMAIL_ADDRESS>


Assertion in SessionEndTime fails on computer with Danish culture (UTC+1)

The assertion Debug.Assert(SessionStartTime <= ret) fails on a computer with Danish culture and UTC+1. The problem is that SessionStartTime has already been converted to local time, but ret has not, hence SessionStartTime will be approx 1 hour larger in the comparison.

Fixed by PR #451


Occasional "Handler on dead thread" exception when backing out of VideoActivity

Not a crash but a logged error (probably a printStackTrace()). Please close if this is not an issue. Happens SOMETIMES when leaving an active dash video activity. Am I missing some tear-down code?
This is in my onPause()
    if (mVideoView.isPlaying()) {
        mVideoView.stopPlayback();
        mVideoView.setVideoSource(null);
    }

And here is the stacktrace
W/MessageQueue: Handler (android.os.Handler) {421a1010} sending message to a Handler on a dead thread
java.lang.RuntimeException: Handler (android.os.Handler) {421a1010} sending message to a Handler on a dead thread
at android.os.MessageQueue.enqueueMessage(MessageQueue.java:294)
at android.os.Handler.enqueueMessage(Handler.java:618)
at android.os.Handler.sendMessageAtTime(Handler.java:587)
at android.os.Handler.sendMessageDelayed(Handler.java:558)
at android.os.Handler.sendMessage(Handler.java:495)
at net.protyposis.android.mediaplayer.dash.DashMediaExtractor$2.onSuccess(DashMediaExtractor.java:625)
at net.protyposis.android.mediaplayer.dash.SegmentDownloader$ResponseCallback.onResponse(SegmentDownloader.java:239)
at okhttp3.RealCall$AsyncCall.execute(RealCall.java:141)
at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1080)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:573)
at java.lang.Thread.run(Thread.java:856)

Thanks, this seems to happen when a segment download finishes at the same time the activity is destroyed. Not really a problem, but I'll still fix it for the next version.

Issue is fixed in 4.3.2.

Awesome, I'll test it out ASAP and let you know if I see it anymore

Cannot reproduce. Closing


Flag tests and option updates

[ ] I have reviewed the Contributing Guidelines
[ ] I agree to license my contributions under the same license as in this repository
[ ] I have verified that the tests pass

Description
this pull request enables most of the flags for the interfaces (required, optional, single connection, strict type matching (on inputs).  as well as tests for them and corresponding C api functions.
NOTES:  this will likely not pass all the test yet.  I would like it reviewed before updating all the API files since that will add 100's of files to the review which are autogenerated and likely won't help the review.   So be aware of that.

This also addresses #426

the buffer_data flag is not fully enabled as that really will only matter for dynamic subscriptions which are also not enabled yet.


Exclude invalid subtypes (#228)

As far as I can tell adding an applied <:< genericType subtype check fixes issue #228.

@jfwilson Wow, you implemented my suggestion even momentarily before I suggested it!

Thank you for the contribution, @jfwilson! I'll publish a new version now.

Version 0.14.2 should be in Maven Central soon.


modify user report task for generating csv

 [QAE17] As an Admin I want to prepare, send and analyse applicant feedback surveys for the 17/18 award year, so I can gain insights into users opinions on this years awards (6)

 [QAE17] As an Admin I want to prepare, send and analyse applicant feedback surveys for the 17/18 award year, so I can gain insights into users opinions on this years awards (6)


Lock ttfunk to 1.7.x in 2.3.x release line

ttfunk is the TTF/OTF font library used by Prawn. Prawn only locks ttfunk to the major version 1 (~> 1.0). When ttfunk 1.8.0 was released, Asciidoctor PDF releases in the 2.3.x release line got this upgrade transitively on the install. However, ttfunk 1.8.0 requires Ruby headers (i.e., development libraries to install). This new requirement violates our commitment to adhere to semantic versioning. Therefore, it's necessary to lock ttfunk to 1.7.x and defer the upgrade to the Asciidoctor PDF 3 release.
There has also been at least one report that the ttfunk upgrade causes some glyphs in TTF fonts to not resolve. That's yet another reason to hold it back until we have time to investigate and assess the situation.

Unfortunately, this means the users of Asciidoctor PDF will have to wait until Asciidoctor PDF 3 is released to get the improvements to the OTF font support introduced by ttfunk 1.8.0.

Resolved by 21760a1591619e606be0f48889af6f871c87772e. This fix will not be added to main.


Tests: use packit rewritten php-dist

Signed-off-by: Arjun Sreedharan<EMAIL_ADDRESS>

Do not merge until https://github.com/paketo-buildpacks/php-dist/pull/67 is merged


Sieve only accepting power from below

Version: exmachinis-1.18.2-1.0.2.jar
Sieve only accepting power from below using the pipez energy pipe, the block only outputs items on the bottom therefore it conflicts with its power requirement

The sieve accepts power from any side, not just the bottom.


#285 Dozer interceptor

#285 Dozer interceptor
I've created patch, but I cannot check how it works, because dozer project is not compiled on my PC.

@ssarabun ; can you rebase with latest to force travis to retest

How can I do it? Do I need to new pull request?

@ssarabun ; https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

@garethahealy thank you for your help, I have some problem with java 8. There are a lot of projects that use  java 7, and to increase version, it is not good idea.
I've checked, dozer will be compiled with java 7 too, can I decrease version and commit changes?

It is very bad for me, because I work with JEE7 and I cannot change stack. If dozer works with JDK 8 and more, a lot of developers will have to refuse from dozer. And I think that enterprise projects are main users of dozer.

JEE7 can be run on JDK8 and would expect all JEE7 application containers to support JDK8 now, for example, JBoss EAP supports JDK8.

JBoss EAP works, but some extensions for JBossEAP not work.

@ssarabun ; just trying to understand what this PR is trying to do. Looking at the code, it seems you want to decide whether or not to write the destination value. That logic is already here:

https://github.com/DozerMapper/dozer/blob/master/core/src/main/java/org/dozer/MappingProcessor.java#L954-L969

Is there another condition you want to check that isn't already supported?

Hi @garethahealy
Which decision do you make?
Will you apply current pull request?
How about JDK7?

@ssarabun ; I dont like the idea of passing in MapperInterceptor to the mapper, which is then passed through several method calls. It feels like there is a better solution which works via the events mechanism.

@garethahealy

I dont like the idea of passing in MapperInterceptor to the mapper, which is then passed through several method calls.

Yes, I think so

It feels like there is a better solution which works via the events mechanism.

Could you provide additional info about that?

Closing for time being, as PR direction is not the best. Needs further investigation to solve problem in a better way.


Cannot define property:33, object is not extensible

Hello,
I'm using windows 7, after cloning this repo and applying this patch https://github.com/chrisgladd/grunt-phantomcss/pull/36 the install process went well although calling default grunt task phantomcss:visualTest returns:
Warning: cannot define property:33, object is not extensible. Use --force to continue.
Aborted due to warnings.
My npm and node versions:
npm -v
2.5.1
node -v
v0.12.0
Thanks in advance!

Fixed in v0.3.0


Redact query arguments in dm log

What problem does this PR solve?

Issue Number: close #11489
What is changed and how it works?
Redact query arguments in dm log when there is retryable error happen in dm syncer.
Have searched for arguments in dm source code to find if there are any missing part for redacting, this one seems like the last missing piece.
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

None

/ok-to-test


Add analysis modal doesn't render content in Safari

:(
Thanks for reporting it, @arianaescobar!

Closing this, since was already reported here: https://github.com/CartoDB/cartodb/issues/10241


Rule PSUseDeclaredVarsMoreThanAssignments generates false positives (warnings) where it should not

Problem #1:
It is common in psm1 files to define variables that are used by functions in the rest of the module.  These module-scope variables are often initialized and not used in the psm1 file itself.  Yet running Invoke-ScriptAnalyzer against a psm1 file that defines these variables and properly initialized them causes warnings to be generated using this rule.
Solution #1:
Once Invoke-ScriptAnalyzer supports invocation against modules (as proposed in #199), this rule should check more broadly to see if variables that are declared and initialized in a script module (psm1) file are used in other files in the module.  These variables that are in "script" scope can be found by looking for $script:variableName or by looking for references to Get-/Set-/Remove-Variable -Scope Script -Name variableName.
Problem #2:
This rule generates a warning against a function that sets a built-in variable using the script scope. I have the following line in one of my functions:
$Script:PSDefaultParameterValues['Get-DoPxWebRequestHeader:AccessToken'] = $AccessToken
Solution #2:
That line is perfectly valid, and it is not initializing a variable that is never used because it is a built-in variable.  This rule needs to ignore built-in variables, whether they are scoped (script/global, or using numeric scopes with Get-/Set-Variable in the -Scope parameter) or not.

Addressed in https://github.com/PowerShell/PSScriptAnalyzer/pull/205


Bug with multicheckbox and required

Hi,
Error is incorrect when you use a multicheckbox and option required.
See example:
http://plnkr.co/edit/IleV3U8AVY0Va3lbmUve?p=info
Steps to reproduce:

step 1 : check Travel and uncheck Travel (last checkbox) => there is an error : Type is required : field is in red : all is ok
step 2 : check Research => the field Type is in error : BUG

Only the last checkbox is used to check 'Required'

@kentcdodds do you want me to take point on this?  It is a recurring problem.  I think this issue should be moved to https://github.com/formly-js/angular-formly-templates-bootstrap.

Thanks @ckniffen, I was actually just about to say that the solution is either fix the bootstrap template so it handles this scenario or make an example of a custom validator that does require like people expect it should. What approach do you think?
Either way, I'm moving this to the bootstrap templates.

Moved: https://github.com/formly-js/angular-formly-templates-bootstrap/issues/26


AVL Tree | Python

Implementation of AVL Tree in Python -
Type of Issue -

[x] Adding New Code

Programming Language

[x] Python

Self Check

Ask for issue assignment before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Happy Coding,

Hi, can you assign this to me? I want to work on this issue.

Sorry, I'm working on this issue right now


Typings

@unional What do you think of this?  I've generated typings for all of the components that you can use with reactor (everything with an xtype).  My primary motivation for this was to enable IntelliSense, particularly within visual studio code, but I imagine it will be helpful for those using TypeScript as well.  I want to at least make sure it won't hurt.  Can you comment?
Thanks!

For generating typings, you may consider taking a look into https://github.com/thanhptr/extts
I'm using that to generate typings for Ext 3.2.0.
extts generate typings based on jsDuck result, which contain more information including comments.
There are some issues, e.g. "Optional" fields are not generated correctly (i.e. without ?).
Another cheap route is trying out https://github.com/SitePen/dts-generator
I have not used it myself.
You may able to use it by renaming the files to .ts first.

I've actually used our internal docs tool, called doxi, to generate these (the same tool that's used to generate the API docs on sencha.com), so it should be accurate.  I've made two modifications to the doxi output to generate typings:
1.) I've camel-cased xtypes so that something tabpanel becomes TabPanel, in keeping with React conventions
2.) I've added props for each event, so for example, the "click" event on Button yields a onClick prop in the typings.

Also, I have actually marked required configs as such, there just aren't many of them.  I'm going to see about adding comments as well...


🐛 BUG:workers.api.error.no_access_to_vectorize [code: 100158]

Which Cloudflare product(s) does this pertain to?
Workers for Platforms
What version(s) of the tool(s) are you using?
wrangler 3.0.0,
What version of Node are you using?
No response
What operating system and version are you using?
windows 10
Describe the Bug
command :- npm run deploy

<EMAIL_ADDRESS>deploy
wrangler deploy

⛅ wrangler 3.49.0 (update available 3.50.0)
Your worker has access to the following bindings:

Vectorize Indexes:

VECTORIZE_INDEX: vector-db

AI:

Name: AI
Total Upload: 429.25 KiB / gzip: 78.31 KiB

X [ERROR] A request to the Cloudflare API (/accounts/255dab2a23e265656e7d09e8ef1f5a0b/workers/scripts/rag-oncopanion) failed.
workers.api.error.no_access_to_vectorize [code: 100158]
If you think this is a bug, please open an issue at:
https://github.com/cloudflare/workers-sdk/issues/new/choose
Please provide a link to a minimal reproduction
No response
Please provide any relevant error logs
No response

Vectorize is currently only available on the Workers Paid plan: https://developers.cloudflare.com/vectorize/


build Android library error

I've run it successfully in windows ,
but Build android  libraries has a error.
hope you can give me some suggest.
ERROR: C:/msys64/home/wujinliang/_bazel_wujinliang/2pedqfuc/external/XNNPACK/BUILD.bazel:4629:19: Compiling src/subgraph/leaky-relu.c failed: (Exit 1): clang failed: error executing command external/androidndk/ndk/toolchains/llvm/prebuilt/windows-x86_64/bin/clang -gcc-toolchain external/androidndk/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/windows-x86_64 -target ... (remaining 112 argument(s) skipped) clang: error: no such file or directory: '/w' clang: error: no such file or directory: '/D_USE_MATH_DEFINES' INFO: Elapsed time: 275.955s, Critical Path: 133.97s INFO: 1378 processes: 619 internal, 759 local. FAILED: Build did NOT complete successfully make: *** [Makefile:52: android_arm64] Error 1

Currently building apk on Windows doesn't work (cf. https://github.com/homuler/MediaPipeUnityPlugin/issues/59#issuecomment-779152562 ).
Will you try building on WSL2, please?

thx your reply,
i cant build your project succeed in mac os,  the mediapipe helloworld is build succeed.
so  can i use mac os?

i am try to use WSL2 now

@homuler  linux has some trouble ,   are you succeed  build this in mac os?
can you share the Android libraries and ios libraries ?
thx

@homuler   a good news is use bazel 3.7.2 is build succeed!
and i can run it in unity on ios platform.
but when i build in iphone8, it crash...
shold i do some setting when  build ios?

this is Xcode log:
2021-03-12 10:59:02.023523+0800 MediaPipeUnityPlugin[7649:3393245] Error loading /var/containers/Bundle/Application/34D6F2E1-39AC-472E-A665-A5E49A66B8FA/MediaPipeUnityPlugin.app/Frameworks/UnityFramework.framework/UnityFramework:  dlopen(/var/containers/Bundle/Application/34D6F2E1-39AC-472E-A665-A5E49A66B8FA/MediaPipeUnityPlugin.app/Frameworks/UnityFramework.framework/UnityFramework, 265): Library not loaded: @rpath/MediaPipeUnity.framework/MediaPipeUnity   Referenced from: /var/containers/Bundle/Application/34D6F2E1-39AC-472E-A665-A5E49A66B8FA/MediaPipeUnityPlugin.app/Frameworks/UnityFramework.framework/UnityFramework   Reason: image not found

@homuler i  solved the crash problem, but when it run in iphone the camera cant run.
there is the log:
UnityEngine.Events.UnityEvent1:Invoke(T0)
UnityEngine.EventSystems.EventFunction1:Invoke(T1, BaseEventData) UnityEngine.EventSystems.ExecuteEvents:Execute(GameObject, BaseEventData, EventFunction1)
UnityEngine.EventSystems.StandaloneInputModule:ProcessTouchPress(PointerEventData, Boolean, Boolean)
UnityEngine.EventSystems.StandaloneInputModule:ProcessTouchEvents()
UnityEngine.EventSystems.StandaloneInputModule:Process()
(Filename: ./Runtime/Export/Debug/Debug.bindings.h Line: 35)
Unable to open archive file: /var/containers/Bundle/Application/B3453BE6-60A8-41ED-8480-D81258AA489C/MediaPipeUnityPlugin.app/Data/Raw/mediapipe
Mediapipe.AssetBundleManager:LoadAssetBundle()
Mediapipe.AssetBundleManager:PrepareAsset(String, String, Boolean)
DemoGraph:Initialize()
DemoGraph:Initialize(GpuResources, GlCalculatorHelper)
d__23:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
[ line 584]
(Filename:  Line: 584)
Failed to read data for the AssetBundle 'mediapipe'.
Mediapipe.AssetBundleManager:LoadAssetBundle()
Mediapipe.AssetBundleManager:PrepareAsset(String, String, Boolean)
DemoGraph:Initialize()
DemoGraph:Initialize(GpuResources, GlCalculatorHelper)
d__23:MoveNext()
UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
[ line 450]
(Filename:  Line: 450)
NullReferenceException: Object reference not set to an instance of an object.
at Mediapipe.AssetBundleManager.PrepareAsset (System.String name, System.String uniqueKey, System.Boolean overwrite) [0x00000] in <00000000000000000000000000000000>:0
at DemoGraph.Initialize () [0x00000] in <00000000000000000000000000000000>:0
at DemoGraph.Initialize (Mediapipe.GpuResources gpuResources, Mediapipe.GlCalculatorHelper gpuHelper) [0x00000] in <00000000000000000000000000000000>:0
at SceneDirector+d__23.MoveNext () [0x00000] in <00000000000000000000000000000000>:0
at UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) [0x00000] in <00000000000000000000000000000000>:0
(Filename: currently not available on il2cpp Line: -1)
-> applicationWillResignActive()
-> applicationDidEnterBackground()
`

@homuler i fix it , now it can run in ios.
thx,
why i cant build Android in mac os?
it has error,
`ERROR: /private/var/tmp/_bazel_alan/7d3f5562cb55fafea5f1c5b1dd2c9dd7/external/com_google_mediapipe/mediapipe/java/com/google/mediapipe/framework/jni/BUILD:27:11: C++ compilation of rule '@com_google_mediapipe//mediapipe/java/com/google/mediapipe/framework/jni:mediapipe_framework_jni' failed (Exit 1): clang failed: error executing command external/androidndk/ndk/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang -gcc-toolchain external/androidndk/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64 -target ... (remaining 81 argument(s) skipped)
Use --sandbox_debug to see verbose messages from the sandbox clang failed: error executing command external/androidndk/ndk/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang -gcc-toolchain external/androidndk/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/darwin-x86_64 -target ... (remaining 81 argument(s) skipped)
Use --sandbox_debug to see verbose messages from the sandbox
src/main/tools/process-wrapper-legacy.cc:80: "execvp(external/androidndk/ndk/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang, ...)": No such file or directory
INFO: Elapsed time: 67.423s, Critical Path: 59.29s
INFO: 852 processes: 171 internal, 637 darwin-sandbox, 44 worker.
FAILED: Build did NOT complete successfully
make: *** [android_arm64] Error 1
`

Looks like an issue with the NDK version.

Looks like an issue with the NDK version.

The ndk 21

Looks like an issue with the NDK version.

The ndk 21

try ndk 18  ：）

Use --sandbox_debug to see verbose messages from the sandbox

Please follow the above instructions first, and share the log.
cd C && bazel build -c opt --config=android_arm64 --sandbox_debug mediapipe_api/java/org/homuler/mediapipe/unity:mediapipe_android

this is the log :
5 warnings generated.
 No such file or directory
Target //mediapipe_api/java/org/homuler/mediapipe/unity:mediapipe_android failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 55.582s, Critical Path: 33.13s
INFO: 239 processes: 140 internal, 99 darwin-sandbox.
FAILED: Build did NOT complete successfully

It looks like $ANDROID_NDK_HOME/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang is missing.
Does it exist?
If it does not exist, you may have failed to install Android NDK properly.

i want to know how to install android ndk for mac  ,i try to download the ndk for mac and use Android Studio install then
add it in path.
but it looks all doesnt work;
can you tell me how to install ?

See https://developer.android.com/studio/projects/install-ndk

now is build succeed , but has many warning.
and in unity project has a error:
#if UNITY_ANDROID
if (IsGpuEnabled()) {
PluginCallback callback = GetCurrentContext;       //------here  has a  error
  var fp = Marshal.GetFunctionPointerForDelegate(callback);
  GL.IssuePluginEvent(fp, 1);
}

#endif

Will you create another issue with detailed logs, please?


I want to make a customised GitHub Profile, how can i make one?

Description
A brief description of the question or issue:
You can also join the discord community here
Feel free to check out other cool repositories of EddieJoaude Comminity here

Create a repo with the same name as your user, in your case mohit01-beep
Then update the README.md to customise your GitHub profile

Here are some examples for inspiration https://github.com/EddieJaoudeCommunity/awesome-github-profiles (note: you can look at their raw README files to see how they did it)

I still didn't get it when i opened the link of awesome GitHub profiles
It says in steps that you have to take a screenshot of customized GitHub Profile Page,
But i was asking how to make that one
And after i clicked at some of their example for inspiration of GitHub Profile
it's just Screenshot of them- no code, no text
So it didn't help me much
can you tell me where is the code to make like them so i can experiment with it and see how my profile will look

I think you are confusing that repo with how to customise your page.
The instructions on the link are how to add someones customised profile to that repo for displaying in the readme, not how to customise your GitHub profile.
If you want to customise your github profile, which I think  you do as it is not customised yet, then you need to follow these steps in the above comment https://github.com/EddieJaoudeCommunity/support/issues/42#issuecomment-669892859
If you want inspiration from the awesome-github-profiles repo, then click on the the users name not the image and view their README.md file (raw), to see how they have achieved it.

yeah i found how to edit my README.md file thanks for helping @eddiejaoude

Ok great 👍


support Passport as Koa-middleware

Would be great to be able to use passport as part of koa.
Perhaps this could be a wrapper to expose the middleware (*) as generator functions instead.

+1

still no progress?

₊1

+1

+1

+1

+1

+1

+1

Notice that Authenticator.prototype.framework function, So i build a Koa framework plugin module passport-koa  to support Koa.  Tested with CustomStrategy and JWTStrategy by now.

I can't resist beating this dead horse. 6+ years.


Website advanced tutorial docs incorrect

Description
Advanced tutorial section on using .driftignore says edit .gitignore.
Open the .gitignore file at the root of the repository, where we execute driftctl and add a line like aws_s3_bucket

This is now fixed, thanks for reporting this to us 🙏🏻


Support for altitude metadata

The module works very well but the one thing I found that is missing is the altitude information which is in fact in metadata. Other modules are able to grab this information so can exifr?

Hello, I dont think I understand. Exifr can parse altitude if it is included in the image. such as in the demo page http://mutiny.cz/exifr/

Agh, I didn't look at the raw data and have been using the .gps method which only returns longitude and latitude so I didn't notice. Sorry for the mistake.

Also why isn't the altitude in the .gps method?