Restoring snapshot causes VM to go to suspended state

Versions:
ovirt-engine-<IP_ADDRESS>-0.1.el8ev.noarch
ovirt-web-ui-1.9.1-1.el8ev.noarch
firefox-104.0-5.fc36.x86_64
Steps to Reproduce:

Have a VM (powered off)
Create a snapshot for the VM
Click on the restore icon of that snapshot (confirm restore)
Check VM state after the restore

Actual results:
VM is suspended.
Expected results:
VM is still powered off.
Additional info:
This isn't happening in Admin Portal.

This is well reproduced on oVirt >= 4.5.2 as a result of this fix https://github.com/oVirt/ovirt-engine/pull/516
And specifically due to this line fix: https://github.com/ahadas/ovirt-engine/blob/6ce8656a5817302f1ce4e81cdbd5951630299e6d/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java#L46:
    `vmDynamic.setStatus(withMemory ? VMStatus.Suspended : VMStatus.Down);`

Since for snapshots created via web-ui, withMemory is always set to true, regardless to the way the snapshot was created, i,e, even if it was created with no memory included.
Details
When restoring a snapshot via web-ui:

the web-ui doesn't mention the restore_memoryparameter as part of the restore post query http://ovirt.github.io/ovirt-engine-api-model/master/#services/snapshot/methods/restore
and the default on rest api in that case is restore_memory = true as shown here
https://github.com/oVirt/ovirt-engine/blob/41851f27e401c3a47d6c94f70f278cb4fbc59bdc/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendSnapshotResource.java#L60-L63
https://github.com/oVirt/ovirt-engine/blob/41851f27e401c3a47d6c94f70f278cb4fbc59bdc/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java#L23
Please note that the restore itself does check if the actual memory is included in the snapshot and if it can be restored or not, so there wasn't a bug in restoring, even though web-ui send a missing API request for restoring memory of snapshots that doesn't include it.
After this bug fix https://github.com/oVirt/ovirt-engine/pull/516, the VM is always set to suspend status since it always asked to restore a memory of a snapshot.

solution
It seems that a fix should be done on web-ui  by adding the restore_memory parameter to the restore endpoint.
We do have this value within snapshot.get('persistMemoryState') so just need to pass it to Api.restoreSnapshot.

It seems that a fix should be done on web-ui by adding the restore_memory parameter to the restore endpoint. We do have this value within snapshot.get('persistMemoryState') so just need to pass it to Api.restoreSnapshot.

Since the API is also affected by this, it's better to solve it on the backend side

Ok so it sounds like, after https://github.com/oVirt/ovirt-engine/pull/653 if a VM snapshot is restored, the VM can end up with a state of:

Down ... if the snapshot does not include memory
Down ... if the snapshot includes memory, but the restore_memory action flag is set false
Suspended ... if the snapshot include memory, and restore_memory action flag is true (explicitly or by default of not false)

@isaranova - Is that your understanding? If you restore a VM snapshot with memory on webadmin, does the VM end in the Suspended status?  If you restore a VM snapshot without memory on web-ui, does the VM end in Down status?
I'm guessing this issues isn't really an issue and what you're seeing is just the way it is supposed to work now.
@sgratch - From web-ui, if the VM is running, a snapshot can be created with memory.  That attribute does flow through the snapshot create action.  The persistMemoryState internal param name transforms to persist_memorystate in the action.  Here is the create modal with memory:

On the restore action, the service and web-ui defaults to restoring the memory (if available in the snapshot) by not explicitly specifying the parameter in the action POST.  API doc: http://ovirt.github.io/ovirt-engine-api-model/master/#services/snapshot/methods/restore.  I don't think it make sense to say "don't restore the memory even if it exists" just to force all restores to leave a VM down.
@ahadas - I agree with your assessment.  The issue, if there actually is one, is best handled on the backend/engine side.

@sjd78 @isaranova
Before latest fix on backend  https://github.com/oVirt/ovirt-engine/pull/653, there was a bug on rest/web-ui since the actual memory inclusion for the snapshot was not checked via rest and therefore whenever a snapshot was restored via rest/web-ui, the  restore_memory action flag was set to true by default and therefore the vm was always suspended.
On webamdin it worked as expected and suspended only when memory was really included.
The current behavior after the fix should be the same for webadmin and web-ui as follows:
If a VM snapshot is restored, the vm status will end up with the status of

suspend - if the active snapshot includes memory.
down - if the active snapshot doesn't include memory.

The restore_memory action flag is not relevant anymore for this flow via web-ui/rest.

@isaranova the fix was done on engine backend so moving this to QE's verification just to make sure that it's fixed for web-ui use case.


feat(LinearAlgebra/CliffordAlgebra): port SpinGroup

In this PR, we define lipschitz, pinGroup and spinGroup, and prove some basic lemmas.
Ported from leanprover-community/mathlib/pull/16040.
Co-authored-by: Jiale Miao<EMAIL_ADDRESS>Co-authored-by: Eric Wieser<EMAIL_ADDRESS>

This PR is a port of leanprover-community/mathlib#16040 .

[x] Port all contents of leanprover-community/mathlib#16040
[x] Prove invertible_of_invertible_ι missing from leanprover-community/mathlib#16040 (with @eric-wieser 's help)

[ ] depends on: #9076

[x] Pass CI
[x] Write a proper commit message for the PR, adding all co-authors and deps
[x] Fix naming issues
[x] Fix style issues
[x] Remove macro_rules
[x] Minimize imports and deps
[x] Add porting notes as PR comments
[ ] Review PR here or on Zulip
[ ] Discuss math on Zulip (if needed)
[ ] Discuss regressions from Lean 3 on Zulip (if needed)

!bench

Drive-by comment: is this awaiting review? Then it would to label it as such, otherwise this may slip through the queue. :-)

Sorry, I made the same mistake again: use git pull origin master --rebase=false to merge without rebase, but during pushing with VSCode, it did the rebase again. Now it's fixed by git reset --hard 230250ce7b5b1bfc211ce37f381549685553b7ef, redo the merge and fix, then a forced push.

This PR looks mostly fine, but there are still some places where it needs some work. Are you planning to continue working on this PR? Would you like some help from others, or do you want to hand over completely? (In the latter case, please label it with please-adopt.)

For discussions, see zulip. The only work left in this PR is to use the Subgroup approach instead of the Submonoid approach. @eric-wieser suggested this, but later he commented that "it's not so clear a win as I'd hoped, and want to write down why", so I didn't move forward with the suggestion.
My plan was to work on follow-up PRs built on this PR, but got distracted by other work. I think this PR is ready to merge as long as there is no objection to the Submonoid approach. I can also work out the Subgroup approach if it's clearly preferred.

My personal opinion is that this PR has been in an acceptable state for a(n unacceptably) long time, and that the Subgroup vs Submonoid design choice is not something that should prevent future work from happening. I agree that this can be figured out in a later PR. So...
maintainer merge

@eric-wieser can you have a final look?

bors merge

My personal opinion is that this PR has been in an acceptable state for a(n unacceptably) long time, and that the Subgroup vs Submonoid design choice is not something that should prevent future work from happening. I agree that this can be figured out in a later PR. So...

I agree with this, but didn't find the time to come back and say it. Sorry for letting this drag on so long @utensil!

bors merge

Weird, looks like one of the runners went offline before the build finished: https://github.com/leanprover-community/mathlib4/actions/runs/10460865400
Let's try again.
bors r+

One of the runners ran out of space. Re-running
bors r+


Issue with viewing logs on the resource details page

Describe the bug

Steps to reproduce
https://github.com/seal-io/walrus/assets/26084756/0186bcec-ae2f-4793-9475-9aa8efad77b0
Expected behavior

Environment

Walrus version: main 73e6ce88f4205e030d30ff4276e82d687c0ccdd0
UI version: dev-a942812

Additional context
Add any other context about the problem here.

Environment

Walrus version: main 73e6ce88f4205e030d30ff4276e82d687c0ccdd0
UI version: dev-860ae96

Test Result: pass


Added lib to NPM and created the main file attr in the package.json

+1 for getting this into NPM

@qrpike any chance I could get the ability to publish to player.js on NPM?

Sure, what's your npm name/email. Thanks.

<EMAIL_ADDRESS>On Fri, Jul 24, 2015 at 1:23 PM, Quinton Pike<EMAIL_ADDRESS>wrote:

Sure, what's your npm name/email. Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/embedly/player.js/pull/23#issuecomment-124585706.

--
Sean Creeley | Co-Founder Embedly
100 North Washington St #503 | Boston 02114
415.891.9917 |<EMAIL_ADDRESS>| @screeley
http://embed.ly | @embedly

Cool - added you as owner.

Thanks!
On Friday, July 24, 2015, Quinton Pike<EMAIL_ADDRESS>wrote:

Cool - added you as owner.
—
Reply to this email directly or view it on GitHub
https://github.com/embedly/player.js/pull/23#issuecomment-124587444.

--
Sean Creeley | Co-Founder Embedly
100 North Washington St #503 | Boston 02114
415.891.9917 |<EMAIL_ADDRESS>| @screeley
http://embed.ly | @embedly


Missing animation when overridden shouldRenderAsCluster uses zoom level to decide

Summary:
Using zoom level to decide if a cluster should be rendered makes the animation of markers moving from the clusters towards their final position stop working. The markers just "appear".
Steps to reproduce:
Use a custom renderer like this to disable clusters on zoom level 15 and closer:
https://github.com/blurpy/android-maps-utils/blob/60398d9190028c82d231db69ba8404cfcb3274c3/demo/src/com/google/maps/android/utils/demo/CustomAnimationNotWorkingClusterRenderer.java
Zoom to you reach level 15.
I have a fork of the code with a modified demo app using this renderer: https://github.com/blurpy/android-maps-utils/tree/zoom-animation-bug
Expected behavior:
All zoom levels should display markers animating in and out of clusters.
Observed behavior:
Animations work on all zoom levels except the last one. The renderer has specified that no clusters should be rendered at zoom level 15 or closer. When reaching level 15 the markers just pop up instead of animating out of clusters.
Solution?:
I don't understand all the details of how this framework works, but I noticed that having two different callbacks to decide if a cluster should be rendered made animations work. Seems like the framework expects shouldRenderAsCluster to be "stable", as in returning the same result based on the same input. Using zoom level in the decision breaks that assumption.
See https://github.com/blurpy/android-maps-utils/commit/60398d9190028c82d231db69ba8404cfcb3274c3
This commit contains a custom renderer enabled by default that overrides the old shouldRenderAsCluster, and one that uses the new shouldRenderAsClusterForAnimation. Both tries to disable clusters at zoom level 15. Switch between them in the ClusteringDemoActivity to see the difference in behavior.
The change I made to make this work seems a bit hacky to me, so I didn't submit a pull request. Also don't know if it breaks something, but I'm using this in an app at the moment and haven't noticed any issues.
Note: this exact same issue (and workaround) happens in the iOS version of the framework (https://github.com/googlemaps/google-maps-ios-utils) as well.

They fixed this properly in the iOS version (referenced above). Could a similar fix be applied here as well perhaps?

This is still unresolved on Android :/

+1. Would love if this could be fixed upstream; I'm using @blurpy 's fork for now. Thanks @blurpy!

Fix from blurpy does not worked for me. My dirty quick fix is to remove one shouldRenderAsCluster check. It produced no issues yet.
public class DefaultClusterRenderer<T extends ClusterItem> implements ClusterRenderer<T> {
    ...
    private class RenderTask implements Runnable {
        ...
        public void run() {
            ...
                    // Remove that shouldRenderAsCluster check and animation will work.
                    if (shouldRenderAsCluster(c) && visibleBounds.contains(c.getPosition())) {
                        Point point = mSphericalMercatorProjection.toPoint(c.getPosition());
                        existingClustersOnScreen.add(point);
                    }

I just upgraded this library in my app from v0.5 that I have been using since posting this issue, to v3.4.0.
I was hoping the issue had been fixed since it's been 6 years and it's been closed, but with the stock DefaultClusterRenderer the same issue is still present.
Is there some officially supported way to disable clusters on certain zoom levels in the newer versions? There is a new method called shouldRender() that mentions zoom level, but the only thing I was able to accomplish with it is not getting anything rendered below a certain zoom level, which is not quite what I'm looking for.
Unlike @nenick I was able to get my original workaround to function exactly as before by patching DefaultClusterRenderer, so the workaround is still valid.
Unless there is a new way to handle this issue, then it should be reopened.


Update index.html

Added • bullet point to end of symbols

This is a duplicate of #4.

Hey @TheButterZone, thanks so much for contributing! I merged this in in #4, hope you find it useful.


🔧 Update release-drafter.yml

Add labels of refactor and dependencies to the category of Internal.

Codecov Report

Merging #7 (5c8f282) into master (014b658) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            9         9
  Lines          130       130
=========================================
  Hits           130       130

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Integrate GreenKeeper GitHub bot [still needed?]

Site: https://greenkeeper.io/
Bot: https://github.com/apps/greenkeeper
GreenKeeper bot checks for newer versions of dependencies in package.json files, create a new branch and runs the pipeline with the updated version; it also automatically creates a PR to update them.
Here it is in action: https://github.com/johnpapa/vscode-peacock/pull/139

There is new integrated bot into github (dependabot). Public beta is available. Might be worth checking ;)

I like the idea of bot updating dependencies. We would avoid massive dependency updates and keep always up to date. Would love to see it in our repo.

Yup, I saw it. We could play with both and see what suits us better :)


Correct use of Alt Tags/Image Descriptions

User Story: Accessibility #1
Size: Large
Reason for adding to Sprint: As we add content to our page, we must ensure that alt tags are used appropriately. Images should be evaluated for both content and function in terms of accessibility. To do this I will be following the WEBAIM guidance to ensure that alt tags are utilized or left null depending on the value of the image.
Priority: High

Task-branch name: bio-page
Notes: Added a Maya image on this page. Because I captioned the image, I have left the alt tags as null.


Update README.md

Pull Request Test Coverage Report for Build #3

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build #2:
0.0%

Covered Lines:
104

Relevant Lines:
104

💛  - Coveralls


add content about LSP8 TokenId Format + Metadata differences

What does this PR introduce?

Add a new section under the LSP8 Standard page called LSP8 Collection vs TokenId Metadata that describe the difference between setting metadata for a tokenId vs for the whole collection.

Add tables that describe the different types of TokenId Formats + tab for Mixed formats

Will be fixed and merged on the 18th Dec


Network tile split related issues.

Using Minecraft 1.12.1, Forge <IP_ADDRESS>3, Teckle 1.12-5.378-SNAPSHOT.
Placed Sorting Machine, attached to some tubes and chests on either side to test. When I tried to load the world again, this happened: https://hastebin.com/ecorehaxan.md

1.12.2? That doesn't exist as far as I know 🤔
Having trouble reproducing this. Any chance you can give some more detailed steps or an image?

I can confirm the crash. Here's how it happened:

Loaded a singleplayer world
Spawned a sorting machine using JEI
Place the sorting machine on the ground. It was either facing east or west.

This crashed my client, with this crash log: https://hastebin.com/ajoyehajim.py
Loading back into the world gave me this crash: https://hastebin.com/ipovaxabaf.py
I was using 1.12.1, Forge <IP_ADDRESS>2, teckle-1.12-5.363.jar

363 is out of date. Test with 378 or greater.
On Aug 28, 2017 3:56 PM, "TheDeviantCrafter"<EMAIL_ADDRESS>wrote:

I can confirm the crash. Here's how it happened:

Loaded a singleplayer world
Spawned a sorting machine using JEI
Place the sorting machine on the ground. It was either facing east
or west.

This crashed my client, with this crash log: https://hastebin.com/
ajoyehajim.py
Loading back into the world gave me this crash: https://hastebin.com/
ipovaxabaf.py
I was using 1.12.1, Forge <IP_ADDRESS>2, teckle-1.12-5.363.jar
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/elytra/Teckle/issues/20#issuecomment-325506086, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABusJG7vnEv3JGbi9EGSn9ZcuqTOO3Xuks5sc0WEgaJpZM4PEeBw
.

Great. Now I can't reproduce it either, although I did the very same thing now. And yes, you're right, there's no 1.12.2. :P

There's still definitely some weird stuff going on with saving and loading: https://youtu.be/hw6rIJH4dHs

I'll look into the transport stuff but as I said before, items are
invisible because it would be a pain to send so many packets on each client
connecting.
On Aug 29, 2017 12:17 AM, "MRebhan"<EMAIL_ADDRESS>wrote:

There's still definitely some weird stuff going on with saving and
loading: https://youtu.be/hw6rIJH4dHs
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/elytra/Teckle/issues/20#issuecomment-325576732, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABusJL7pUUNj179AvfIi2jqkNvFE6GzZks5sc7skgaJpZM4PEeBw
.

Leaving a note here for myself, working on the weird sorting machine bug and found the source. Not sure how I'm going to go about a fix quite yet. ItemNetworkAssistant will call onNodePlaced during onNeighbourChange when it cant find a network tile. This is fine in some cases but it results in a sorting machine creating a secondary network when the node is destroyed. This causes a new network to be created that shouldn't exist and with no block to tell it to stop existing it simply stays in limbo, then when serialization is attempted there's an attempt to reference the network tile that doesn't exist which causes an error and eventually a crash.

Copy of #21

Using Minecraft 1.12.2, Forge <IP_ADDRESS>3, Teckle 1.12-5.378-SNAPSHOT.
When activating a transposer, it doesn't pull an "OH SHIT TECKLE BROKE" message appears in the log. The item might or might not get removed from the attached inventory.
Log: https://hastebin.com/ejabicapuw.md

I made a bunch of changes in https://ci.elytradev.com/job/elytra/job/Teckle/job/1.12/94/
Please try this version and see if you still have any of these issues (or if anything else pops up)

Using 5.385 from maven, after saving and loading, this exception occurs (which is similar to the first one I've encountered). Again, this only occurred once, I can't reproduce it again with a new world. Strange. Haven't encountered any other errors though.

And there's another one, again on loading the world. This time it didn't crash the client entirely, just took all the items out of the attached chest and tubes https://hastebin.com/tazivicoxe.md (might or might not be related to my block, still testing)
And the transposer bug is kind of still there: this occurs because the transposer's bufferData is null

Was the world that you loaded from the previous version? If so that would probably be why, I hadn't tested with an older world.

I've made a few changes to fix bugs I've been finding myself.
Try the most recent builds and see if they work.

Closing due to inactivity, if you find any more issues that haven't been mentioned here please open a new issue.


Moved DiscordSocketClient events to individual Manager classes.

Moved EventHandler to EventManager to avoid conflict with System's EventHandler type.
Added IServiceCollection extension method to include new managers.

Build fails because I didn't change the EventService file, which has a reference to ConversionHandler, which has been removed and replaced instead with the new UserManager class.


Failed deploy with Ghost 0.5.8 on Azure Website

When I upgraded the site, it failed to start. By looking at the Kudu console, I noticed that npm had failed. My upgraded site was missing its package.json file. I manually uploaded the package.json and ran "npm install" but it failed again with the following error:
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
MSBUILD : error MSB3428: Could not load the Visual C++ component "VCBuild.exe". To fix this, 1) install the .NET Framework 2.0 SDK, 2) install Microsoft Visual Studio 2005 or 3) add the location of the component to the system path if it is installed elsewhere.  [D:\home\site\wwwroot\node_modules\testem\node_modules\socket.io\node_modules\socket.io-client\node_modules\engine.io-client\node_modules\ws\build\binding.sln]
MSBUILD : error MSB3428: Could not load the Visual C++ component "VCBuild.exe". To fix this, 1) install the .NET Framework 2.0 SDK, 2) install Microsoft Visual Studio 2005 or 3) add the location of the component to the system path if it is installed elsewhere.  [D:\home\site\wwwroot\node_modules\testem\node_modules\socket.io\node_modules\socket.io-client\node_modules\engine.io-client\node_modules\ws\build\binding.sln]```

I suspect it is a limitation with Azure website. Does the updater need to build the node packages before uploading them?

Thanks for reporting! I haven't seen this error before and successfully upgraded a bunch do sites to 0.5.8, so I'm eager to find out what happened here.
Which version did you upgrade from?

I am on an older version (0.4.0). I am not sure what happened. I reverted to the backup (which worked fine). I could never find any detailed logs and I suspect it is because I run on a shared Azure website.
I noticed a few other oddities (index.js wasn't copied and some of the core files were missing). I will try it again. It seems like a very handy tool. @felixrieseberg any suggestions on finding the correct error log? I think one of the powershell scripts failed.

Hey @masonkmeyer, you can find logs on your website by going to yourwebsite.scm.azurewebsites.net. Click on 'Debug' and then 'Powershell' to get access to all files on your server, including the logs.
I have concluded that updating from a version this old might be too difficult to implement into the updater, but I'm happy to walk you through a manual update. As soon as you're on anything above 5, you will be fine with the upgrader :smile:. Shoot me a mail at<EMAIL_ADDRESS>if you want the help!
I'll be closing this in the meantime.


Error CanColor

I got an error after install package by npm and copy/paste template from 'It's awesome, but how to use it?'.

ERROR in node_modules/saturn-datepicker/datepicker/datepicker.d.ts(12,20): error TS2305: Module ${path_here} has no exported member 'CanColorCtor'.
node_modules/saturn-datepicker/datepicker/datepicker.d.ts(42,22): error TS2420: Class 'SatDatepickerContent' incorrectly implements interface 'CanColor'.
Property 'color' is missing in type 'SatDatepickerContent'.

#48

I've just got this error while upgrading from Angular 9 to 10
ERROR in node_modules/saturn-datepicker/datepicker/datepicker.d.ts:57:22 - error TS2420: Class 'SatDatepicker<D>' incorrectly implements interface 'CanColor'.
  Property 'defaultColor' is missing in type 'SatDatepicker<D>' but required in type 'CanColor'.

57 export declare class SatDatepicker<D> implements OnDestroy, CanColor {
                        ~~~~~~~~~~~~~

  node_modules/@angular/material/core/common-behaviors/color.d.ts:15:5
    15     defaultColor: ThemePalette | undefined;
           ~~~~~~~~~~~~
    'defaultColor' is declared here.

from Angular 9 to 10

did you find a fix?

Guys, I don't think it is fixed. Is it ?

I'm getting the same error too, and the older bug that's already closed two years ago doesn't fix this new problem.


[testing/wip] build docker image

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

Codecov Report

Merging #2644 (a64f84e) into main (5260c77) will decrease coverage by 0.01%.
The diff coverage is 72.72%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2644      +/-   ##
==========================================
- Coverage   78.76%   78.75%   -0.02%
==========================================
  Files         178      178
  Lines       12298    12289       -9
==========================================
- Hits         9687     9678       -9
  Misses       2188     2188
  Partials      423      423

Impacted Files
Coverage Δ

...ps/27-interchain-accounts/controller/types/msgs.go
91.11% <ø> (-1.05%)
:arrow_down:

...ps/27-interchain-accounts/host/keeper/handshake.go
89.06% <ø> (-0.49%)
:arrow_down:

modules/core/keeper/grpc_query.go
0.00% <0.00%> (ø)

modules/apps/transfer/ibc_module.go
64.96% <66.66%> (ø)

modules/apps/transfer/keeper/msg_server.go
100.00% <100.00%> (ø)

modules/apps/transfer/keeper/relay.go
90.63% <100.00%> (ø)

modules/apps/transfer/types/msgs.go
95.12% <100.00%> (ø)

modules/apps/transfer/types/packet.go
92.00% <100.00%> (ø)

modules/core/02-client/keeper/grpc_query.go
68.20% <100.00%> (ø)


python311Packages.pymc: fix hash mismatch

Description of changes
Address https://github.com/NixOS/nixpkgs/pull/311383#issuecomment-2120049385.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

What was the reason for the hash mismatch? Did the upstream tarball change? Do you still have that cached? Can you create a diff between old and new?

What was the reason for the hash mismatch? Did the upstream tarball change? Do you still have that cached? Can you create a diff between old and new?

Might be an error on my side as building pymc from both this new branch and the current master gives the same derivation. I got trapped by local caching I guess.

Can you show a diff between the two src fods?

Can you show a diff between the two src fods?

❯ diff -r /nix/store/3pll919h7jz9m2mgq6n06d6dgm323fhn-source /nix/store/0jazwc70z5dsx79ar5rvci9ssq61yvqs-source
diff '--color=auto' -r /nix/store/3pll919h7jz9m2mgq6n06d6dgm323fhn-source/pymc/_version.py /nix/store/0jazwc70z5dsx79ar5rvci9ssq61yvqs-source/pymc/_version.py
41c41
<     git_refnames = " (HEAD -> main, tag: v5.15.0)"
---
>     git_refnames = " (tag: v5.15.0)"

Result of nixpkgs-review pr 313089 run on x86_64-linux 1

2 packages failed to build:

python311Packages.bambi
python311Packages.bambi.dist

2 packages built:

python311Packages.pymc
python311Packages.pymc.dist


Small bug in recursiveFix func

Describe the bug
I uncovered a small bug in schema.go, the recursiveFix func overwrites the passed in colPath by using it in the append function to add the column name to the column path on L684. Since go slices may or may not reuse the underlying array depending on capacity, this does not always necessarily return a slice that points to a newly allocated array (I have been bitten by this bug before, it's one of go's "gotchas"). This resulted in the go schema to have the same column path for all fields in a list element and thus invalid parquet.
message test_result {
  required binary version (STRING);
  required binary variant (STRING);
  required binary task_name (STRING);
  optional binary display_task_name (STRING);
  required binary task_id (STRING);
  optional binary display_task_id (STRING);
  required int32 execution;
  required binary request_type (STRING);
  required int64 created_at (TIMESTAMP(MILLIS,true));
  required group results (LIST) {
    repeated group list {
      required group element {
        required binary test_name (STRING);
        optional binary display_test_name (STRING);
        optional binary group_id (STRING);
        required int32 trial;
        required binary status (STRING);
        optional binary log_test_name (STRING);
        optional binary log_url (STRING);
        optional binary raw_log_url (STRING);
        optional int32 line_num;
        required int64 task_create_time (TIMESTAMP(MILLIS,true));
        required int64 test_start_time (TIMESTAMP(MILLIS,true));
        required int64 test_end_time (TIMESTAMP(MILLIS,true));
      }
    }
  }
}

Using this schema, all the column paths for the list elements were ["results", "list", "element", "test_end_time"] because test_end_time is the last field in the group and the recursive function continuously overwrites the colPath argument and assigns it to each column's path field.
I can put up a PR for the fix, it is a one-line change:
col.path = append(append(col.path, colPath...), col.name)

Let me know if I can provide any more info, thanks!

i already made a pr but nobody replies yet, here is the repo: https://github.com/csimplestring/parquet-go if you want to use


Has this been abandoned?

I'm still around, but work and maintaining so many projects can take its toll
I just released a new version with an updated numpy version, which seemed to be the primary issue with HA, as far as i can tell


Update installation.md

Made changes to reflect issue #556

Sorry, just did this myself😅. Thanks anyway for the PR, appreciated!


Hack for unsupported OS distros.

This is a hack for unsupported OS distros.
KernelMonitor doesn't support some OS distros for now e.g. GCI. Ideally, we should only run KernelMonitor on nodes on supported OS distro. However, NodeProblemDetector is running as DaemonSet, it has to be deployed on each node:

There is no node affinity support for DaemonSet now https://github.com/kubernetes/kubernetes/issues/22205
There is no node label for OS Distro, so we can't use node selector, either

If some nodes have unsupported OS distro e.g. the OS distro of master node in gke/gce is GCI, KernelMonitor will throw out error, and NodeProblemDetector will be restarted again and again because it's a DaemonSet.
To avoid this, we decide to add this temporarily hack. When KernelMonitor can't find the kernel log file, it will print a log and then return nil channel and no error. Since nil channel will always be blocked, the NodeProblemDetector will block forever.
I've tried to schedule the NodeProblemDetector on GCI image, the cpu usage is 0.01% core and memory usage is < 5MB.
TODOs:

Add journald support to support GCI. Consider reusing the code in cadvisor, and maybe replace hpcloud/tail with the simpler implementation in cadvisor https://github.com/kubernetes/node-problem-detector/issues/3
Schedule KernelMonitor only on nodes with supported OS distros. (with node label+selector or affinity)

@dchen1107
/cc @kubernetes/sig-node

LGTM


Metric to EvaluationModule, MetricInfo to EvaluationModuleInfo

This PR renames Metric and MetricInfo to the more generic EvaluationModule and EvaluationModuleInfo to reflect the fact that now also comparisons and measurements can be loaded. Related to the changes in #40.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Segmentation fault and odd behaviour

I am running into problems running various programs.
There is odd behaviour and crashing when running some programs.
For example I am receiving errors about:

Segmentation fault
Stack overflow
Converting string to number always returns 0, for example for the string "99"

Details:

Using the linux example to run
The problem occurs on interp, fast interp. Did not test AOT.
I am using the commit 01e85144f4063db9809464fb40c0a95b16f83562

Example settings for cmake:
cmake .. -DWAMR_BUILD_AOT=0 -DWAMR_BUILD_FAST_INTERP=0 -DWAMR_BUILD_LIBC_BUILTIN=0 -DWAMR_BUILD_LIBC_WASI=0

Here is a small test .wat file that results in a Segmentation fault (core dumped) error.
I added the .wasm file of this code as an attachment here: main4.zip.
Commenting out either the export for __data_end or the export for __heap_base will allow the program to run.
You can also change one of the underscores to a or add an underscore to make it run.
For example a_heap_base and ___heap_base respectively.
(module
  (memory (;0;) 0)
  (global (;0;) i32 (i32.const 0))
  (global (;1;) i32 (i32.const 1))
  (func $main (result i32)
    i32.const 20)
  (export "memory" (memory 0))
  (export "main" (func $main))
  (export "__data_end" (global 0))
  (export "__heap_base" (global 1))
)

GDB report:
Starting program: /home/local/<user>/Documents/wasm-micro-runtime/product-mini/platforms/linux/build/iwasm main4.wasm
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x0000555555569a86 in load_from_sections (module=0x5555557782f0, sections=0x5555557783c0,
    error_buf=0x7fffffffd930 "", error_buf_size=128)
    at /home/local/<user>/Documents/wasm-micro-runtime/core/iwasm/interpreter/wasm_loader.c:1630
1630                            if (global->type == VALUE_TYPE_I32
(gdb)

If you need more information or need me to try something do tell.

@Rochet2, thanks for finding the issue! The exported globals __data_end and __heap_base have special meanings, generally they are generated by clang compiler to mark the end of data, the end of explicit stack, and also the beginning of heap area which is used by memory allocation. We resolve these data to try to decrease memory usage, and prepare for future multi-thread support. If the __heap_base is detected and there is no memory.grow opcode, which means no memory allocation and heap area isn't used, we will shrink the linear memory space to the value of __heap_base to decrease memory usage, which is very important for embedded system.
There is issue when resolving these data, we have fixed it in latest patch, please try again.

Thanks for quick response and fix.
The segmentation fault was fixed and at the same time the functionality in my code for converting a string to number started working.
I still run into the stack overflow, but I will make a separate issue for that once I get information on how to reproduce it.


Github to Jira Integration is not working properly

Current Issues:

the Smart Commits are not updated to their associated Jira issues in a timely manner
Workflow is not working

Here are the current steps I followed and the above issues observed along the way:

Install the App
Follow the instructions on install and configuring the App
Go to Board and Select an Issue
Copy the command to create branch from Development
Make changes in branch and add Smart Commit syntax
a. It seems like the comment command works when written as the title of the commit and/or the body of the commit

Add vanilla Jira Smart Commit plugin WP-134 #review #comment trying out vanilla smart commit where everything resides on the title

build(package): WP-134 add Jira Smart Commit plugin

- this one supports semantic versioning from someone who branced off digitalroute

WP-134 #review #comment Trying this plugin out

Make a pull request and merge commits
When the syncing was done, I saw:

where it seems to be able to associate with the right issue and writes the comments, but the status changes were executed
Update my Github to include the email that is associated with my Jira account, and update git config to use that email git config --global user.email <my-email-used-in-jira>
Make a Smart Commit, create Pull Request and merge commits to branch

chore: remove unused committizen jira smart commit plugins

WP-134 #review

Update wasn't reflected in Jira Board until the repos are manually resynced. However, the status did not get updated and the comments made before were duplicated.

Hey @Michael-Xie,
the first screenshot you posted is not from this app but seems to be from some other GitHub integration app. Might it be that you have installed a different app than the "GitHub for Jira" app (there are quite a few)? We can only help you with the "GitHub for Jira" app.
Let us know if you have sorted it out, we're happy to help!
Cheers,
Tom

Hey @Michael-Xie,
the first screenshot you posted is not from this app but seems to be from some other GitHub integration app. Might it be that you have installed a different app than the "GitHub for Jira" app (there are quite a few)? We can only help you with the "GitHub for Jira" app.
Let us know if you have sorted it out, we're happy to help!
Cheers, Tom

We have Github for Jira installed. At the same from the screenshot below, it looks like there is another app that is installed, Github-Jira Integration. This one is probably what my admin went through. Thanks for pointing out on the first screenshot from my first post.

What would the installation process look like when installing Github for Jira?

@Michael-Xie After installing Github for Jira, have you added your github org to it in the configuration page?

@Michael-Xie After installing Github for Jira, have you added your github org to it in the configuration page?

Yep, I got my Jira admin to configure with our github org. And have also uninstalled the other App that was causing a bunch of issues mentioned in the original post.
After that was set, I was able to have the Smart Commit work for associating issues to branch/commits, setting workflow statuses and comments.
Thanks again for help from @mboudreau and @thombergs for quickly catching the misinstallations from the plethora of Jira and Github integration apps.

@Michael-Xie Cheers mate.


Bad padding for inline chat zone widget

Good padding on the toolbar

Toolbar too close to the border

Tried to trigger inline chat in multiple places in the editor - does seem good as it looks like the first screenshot :)


Refactor: separate ctxrunner from database

This continues the work I started in #192. My goal this time was to separate the low-level ctxrunner machinery, which parses and runs a context.py file, from the database.
Using user-editable variables in the context file has never been turned on, and this PR still doesn't, but it changes the way they will work if/when we do. They would be labelled with an input# prefix (e.g. input#sample_type) instead of var# like variables defined in the context file. A higher level piece would be responsible for finding their values and passing them in when running a context file - the precise mechanism for passing them down still to be decided.
I also moved some of the context file checks into a separate ContextFile.check() method. The idea is that we can still read a context file and tell you about its contents even if e.g. a raw variable depends on a proc variable. For now, the context file is checked whenever we execute it, so if there are any issues all processing is stopped, but I'd like to relax that in the future, e.g. to allow processing variables without issues.

Ah joy :grimacing:

That happened once to me this morning too, not sure. Let's fix it in another PR unless it really messes with CI.

(oh, I missed that the test_context_file test is actually failing, maybe it's related to that)

Thanks James!


Test the commands layer

Issue To Be Solved
The command layer: https://github.com/onflow/flow-cli/tree/master/internal is lacking tests which has lead to multiple bugs with typos etc because it requires manual testing to detect that.
Suggest A Solution
Write tests that execute functions in the command layer (functions were extracted with the purpose of testability).
Transaction example:
Test for send function here https://github.com/onflow/flow-cli/blob/master/internal/transactions/send.go#L55
Use mock ReaderWriter with afero mock loader to mock file loading like done here: https://github.com/onflow/flow-cli/blob/master/pkg/flowkit/config/loader_test.go#L88-L89
Test returned results in different formats.

@sideninja For comparing the console print outputs of commands for testing, I was thinking about using some 2 pointer approach that compares equivalence of non-format characters (ie. \n, \t, <whitespace character>). However this approach totally disregards formatting so I'm not too sure of how viable this is, however I have some ideas of how we can lightly regard formatting, but what are your thoughts on this approach?

I would say that once we have the service layer mocked out you can to an exact string match, since the result from the service layer will be predictable you can also exactly predict the output in different formats. If a formating changes (like adding a new line) then it's ok for the test to also break and require being updated.


Slowly working on enhancements and scalability

I am slowly working on enhancements and scalability to SMIA-CUKIE. The first step of this is ensuring unit tests are adequate moving forward so that we have a solid foundation to build upon.

the development branch should now be stable enough to run. It works against the production_tester images.
note that you should tweak the production_testers config file if you plan to test these images on your own

dev branch has been promoted to master with release 2.0.0


Make scenario specific setting overwritable: Matrix server

Analysis
Introduction
Currently each scenario has some hardcoded settings specified. Some of these settings should be made overwritable through the CLI arguments of the scenario player when starting a scenario in order to make scenarios more dynamic in regards to which environment they are run in. This should be done as a solution to https://github.com/raiden-network/team/issues/682.
At the moment the matrix server used per node can be defined in the scenario file. If no matrix server is specified Raiden will automatically choose the one with best round time, which is desired behavior for the user, but if we want to simulate that nodes are located far from each other it's convenient to be able to specify which matrix servers to use. @nlsdfnbch alternatively mentioned the option to physically spin up the Raiden nodes on different Digital Ocean servers around the world.
Solution
Make it possible to overwrite the
  node_options:
    0:
      matrix-server: https://transport01.raiden.network

setting through an argument when starting the Scenario Player.

This can be handled using a jinja2 template - no changes required.


examples/console: fix deposits to other

What
When 'other' is included in the deposit command as the second parameter, have the deposit go to the other participant.
Why
This is how the deposit used to work, but a bug was introduced recently which prevented us from following the code path where the deposit was directed to the other participant.

oops, forgot to change that, thx


Phoenix arg delegate sometimes ignored

Checked for duplicates
No - I haven't checked
Is this a regression?
Yes - This worked in a previous version
Version
3.0.1
Describe the bug
When using an arg delegator to modify an enum arg, the default_value is ignored in favor of the first value from the dictionary (not the range from the delegate). The delegate range values appear in the form fill panel next to the argument name, but the dropdown instead contains values from the original dictionary.
Here, 'Garbage' and 'Wrong' are values from my delegate, but the dropdown values are still the values from the dictionary.

Reproduction
My delegate implementation:

const epoch_params_delegate: (
  argDef: FswCommandArgument,
  paramDictionaries: ParameterDictionary[],
  channelDictionary: ChannelDictionary | null,
  precedingArgValues: string[],
) => FswCommandArgumentEnum = (argDef: FswCommandArgument) => {
  let enumArgDef = argDef as FswCommandArgumentEnum;
  return {
    arg_type: 'enum',
    bit_length: enumArgDef.bit_length,
    default_value: 'Wrong',
    description: enumArgDef.description,
    enum_name: enumArgDef.enum_name,
    name: enumArgDef.name,
    range: ['Garbage', 'Wrong'],
  };
};

Logs
No response
System Info
Local Aerie 3.0.1

Severity
Moderate

Renamed from "Enum argument delegate range and default are ignored" to capture some additional behavior: I'm also seeing that an argument delegate which replaces a repeat-type arg with a string-type arg is obeyed by the form fill and linting, but isn't acknowledged by the autofill, which still fills in a blank value for the repeat (although the linter identifies the generated value as wrong).

Oh, it's actually even more elusive...using the "Enter" autofill after selecting the command stem from intellisense obeys the delegate, but selecting "Add Missing Arguments" from the argument editor form is where I get the incorrect repeat arg formatting.


chore(master): release 0.16.0

:robot: I have created a release beep boop
0.16.0 (2023-09-13)
Features

add authz versioning (e21bebf)
implements audit sink CRUD operations (cfe23ad)

Miscellaneous Chores

deps: update actions/checkout action to v4 (5b82085)
deps: update everything (e280b20)
upgrade dependencies (aedc4e8)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/indykite/indykite-sdk-go/releases/tag/v0.16.0 :sunflower:


proposal :: Orchestrate DNS-Services

problem
when wanting to deploy dedicated app clusters to clients through templating the orchestration yaml-files, the question is, how do i easly setup the dns for this.
proposal
there are great services such as dnssimple with an api. hashicorp's competing tool terraform has got some additionals "outside world" providers like said dnssimple
rational
If I might decide to go with fig/composer, and decide against beeing system agnostic, because I just know I want to do all I do the docker way - for some whatever reason - I might also want to be able to set up adjacent services such as DNS and probably mailchimp or similar...

well there are allready solutions for that "problem".
Easy (and basic) => docker links (but does not support circular linking)
A little bit more tricky (but work well in container) => skydock/skydns(2)

I got probably misunderstood:
Is skyshock/skydns the solution to expose individual services to the outer world? Let's say I want to automatically spin up 1000 dedicated client-instances a day, as soon as those 1000 clients checked out successfully on the webshob. Maybe I understand too little about the pitfalls of DNS setup and skydns is indeed the solution, but I might eventually claim none-the-less: I want a simpler one like dnassimple-api. Deploy and forget.

You are right i misunderstood your need ! ;-). Fig is just an orchestration tool you need to dig into service discovery and service publishing (take a look at progrium blog http://progrium.com/blog/)

Thanks for the link, I might with some additional resarch be able to figure it out, my suggestion however was to include external services such as Amazone Route53 or dnssimple directly into the composer cli, so you can specify it in your composer files, instead of accessing their api through external coding.

@blaggacao can this issue be closed?


Castle mock configuration issue

Hi team,
I have one doubt in castle mock server. if the api response is dependent on request how to resolve the issue
Thanks and regards
Sharan

Hi @Sharan134.
Is this still a problem? The description is a little bit unclear. Could you elaborate?


Windows Provisoning agent minimum OS required

The documentation currently says that the Windows VM Agent needs at least Windows Server 2008 SP2 but Windows Provisioning agent doesn't support lower than Windows Server 2008 R2. Proposing a change to make this accurate.
We have had customers file ICMs against this quoting this documentation.

#assign: @MsGabsta
@MsGabsta

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@mimckitt - GitHub won't let me assign it to @MsGabsta ... can you review this? thanks.

#assign: @GabstaMSFT

Windows VMAgent and Windows Provisioning Agent are 2 different components; hence it makes sense have different support scope. Back when VMAgent requested to support WS2008 SP2, the customers agreed to bring their specialized VMs, so WinPA was not involved/required. Does the customer migrate from WS2008 SP2 to later OS versions? Or I would suggest adding more details to our WinPA public document to explain it does not support WS2008 SP2, but Azure still welcome customers bring their own specialized WS 2008 SP2 VMs to have limited VM extension supports. (FYI, not all the VM Extensions supprts WS2008 SP2)

Closing this PR per https://github.com/MicrosoftDocs/azure-docs/pull/104398#pullrequestreview-1285436951.
Thanks for contributing!

Thank you for reviewing. We do have customers reaching out about this and having issues provisioning using WinPA on Server 2008 SP2. They point to this line as why they believe that it should work. I fully agree that the edit I suggested is not the correct way to update the documentation but we would still like to update this documentation in some way so customers are not confused on what they are able to do. Would someone from your team be able to assist with this update?

@albuss-msft, I will look at the wording and bring some more clarity to it so that it is clear that Guest Agent and Provisioning Agent have different requirements and link to the PA one.


Form input "Value" property

I am trying to create a form and collect.
I am using 'value' to collect user input onChange but material-ui uses 'value' for setting value to the input field not collecting the value in the field. This is causing all sort of bugs, e.i. not being able to enter input, pickers not displaying default values and not accepting values.
constructor() {
        super();
        this.state = {
            title: "",
            description: "",
            location: "",
            start_time: "",
            start_date: "",
            end_time: "",
            end_date: ""
        };
    }

updateInput = e => {
        this.setState({
            [e.target.name]: e.target.value
        });
    };

<form className="event-form" onSubmit={this.addNewEvent}>
                        <Input
                            type="text"
                            placeholder="Event title"
                            className="event-title"
                            inputProps={{
                                'aria-label': 'Description',
                            }}
                            multiline={1}
                            rows={1}
                            onChange={this.updateInput}
                            value={this.state.title}
  </form>

@UserOn3 Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!

Thanks for a quick response:
I've placed the code on here:
https://codesandbox.io/s/vml2vmp687?fontsize=14
and
https://codesandbox.io/embed/vml2vmp687?fontsize=14
I hope it helps. Let me know if you need more information.


ENH: Move docs folder to sphinx-docs

Closes #759
Moving all existing documentation onto RTD so that it is all in one consistent place. Also fixes problems with RTD not displaying all markdown documentation correctly.

I suggest renaming sphinx-docs to docs, as is common practice.

For some reason the images are not currently rendering properly and I can't figure out why:

Going to open a separate issue for this and investigate later - this PR is already becoming oversized and it's not a major issue as it only affects two images, one of which is in the README anyway.
Marking this PR as ready for review (many other issues to be opened shortly, RTD is far from finished!)

The image in https://innereye-deeplearning--768.org.readthedocs.build/md/deploy_on_aml.html is still not showing up. Is that expected?

not expected but I haven't figured out the fix yet, opening a new issue to focus on that next. It builds and displays just fine locally, and doesn't 404 when you navigate to the URL of the image. It just doesn't seem to be uploading the source images correctly for some reason.


Undefined acronym

Type of issue
Missing information
Description
[Enter feedback here]
"TFM" is used throughout this article but isn't defined.
Page URL
https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-1#when-to-target-net80-vs-netstandard
Content source URL
https://github.com/dotnet/docs/blob/main/docs/standard/net-standard.md
Document Version Independent Id
6819a4a7-7527-d8c7-e132-767f7344e00e
Article author
@gewarren
Metadata

ID: 9eb8b774-c6f0-8235-6964-15219baf2ea7
Service: dotnet
Sub-service: standard-library

TFM = target framework moniker.

PR submitted here, hopefully this does the trick!


Reading, recording and editing Regular Grammars

[ ] Create class Grammar
[ ] export_to()
[ ] import_from()
[ ] to_NFA()
[ ] UI support (editing)

The methods described above were implemented as functions (exportGrammar, importGrammar), in the module models/FileUtil.py.


请求加入本地化，以及从Google Authenticator导入数据，定时备份令牌到云盘的功能。

其他的都很好了
这几项应该挺急需
云盘用常用的那些就完事了……
手机导入导出令牌挺麻烦的
万一忘了备份令牌，手机丢了，或者坏了，两步验证就死翘翘了……
直接导出到网盘可以说是很重要了，除了常用的网盘支持外，可以加入WEBDAV服务器。这样也能导入到自己的服务器了。
定时同步应该也挺重要的，怕忘记导出……
Google Authenticator有源码，数据位置，数据结构应该能搞清楚，可能需要root吧，没root就当没有这功能就行了，或者能够通过adb shell的权限弄到数据？真想导出Google Authenticator的数据的话应该不会介意开电脑……
本地化有助于更好的用户体验……

Hi @daiaji it would help if you write in english, the yandex/google translation is not very accurate unfortunately. From the inaccurate translation you seem to be asking about Google Authenticator export function - but this is FreeOTPPlus and it already has an import/export function.

FreeOTP+ supports Google's document framework so if you have installed Webdav app that exposes document API, FreeOTP+ can use it directly.
I think scheduled backup could be a good idea. Maybe we should just expose a Tasker or any open sourced alternative interface so other app can schedule the backup
Google has only open sourced very old version of Google authenticator. I don't think it would be easy to import from Google Authenticator.

2. I think scheduled backup could be a good idea. Maybe we should just expose a Tasker or any open sourced alternative interface so other app can schedule the backup

I am concerned about the reliability of this solution ...

3. Google has only open sourced very old version of Google authenticator. I don't think it would be easy to import from Google Authenticator.

Google doesn't seem to be that great.

There is localization, however only italian and another language.
You can translate it and create a pull request:
https://github.com/helloworld1/FreeOTPPlus/blob/master/app/src/main/res/values/strings.xml

@daiaji feel free to use https://crowdin.com/project/freeotpplus - I'll submit create pull's from there

Thank for @6543 for providing crowdin option for localization. Closing this issue since other requests are not actionable for now.


Implement parallel building

With the ROS rebuilds we could still save ~50% of the time if we would execute builds in parallel.
Lot's of time is taken by linking packages into an environment, and by running low-cpu stuff like cmake scripts.
We can create a graph of all recipes, and run all in parallel whenever possible.

There are some additional interesting possibilities with the Jobserver plugin to GNU Make (used by catkin_tools). We can implement things similar to catkin_tools to run make in parallel over multiple packages.


[suggestion/feature] Slow initial loading on older/cheap phones. Fix might be hiding images?

My assumption is that images in an ebook will cause long loading times is because you always see the pictures visually loading and taking their sweet time as you are locked out until they are done loading. And, you are forced to load the pictures at a start of a book because each time the reader loads it doesn't jump straight to the bookmark, it always loads the start of the book before jumping forward.
Small QoL improvement would be adding an option to not load images at all until requested, kinda like spoiler but when clicking the spoiler the image will load there and then rather than initial loading of book. (or rather just make this the default behaviour of spoiler even)
Another way to improve performance might be to reduce the amount of pre-rendered text off screen, I'm not sure if you can control this, but I think it'd help especially slow devices.

Had something similar in mind.
The Image Load though is more a percived Slowness i think - the major slowdown happens due to the 2nd Part you mentioned. Inserting a high amount of paragraphs / dom elements is basically taking most of the time - the dom is not performant.
Something like a virtual scroller can potentially help. Main Challenges to be solved would be the fact that most existing ones are static height dependant and most likely impacts functionality like bookmarking and character count as they are dom / scroll dependant as of today.
Lets see - i guess main focus was always desktop and mobile just came recently more in focus with jidoujisho

Yeah it was originally for specific users on desktop, which is why it wasn't that optimized for older devices / mobile phones.
The fix for this would be implementing virtual scroll, though I still haven't figured out the way to implement this without breaking other features

Reason as to why I thought delaying loading images until requested from the book was because I've tested 2 books with and without images, and they do pretty much get about 30-40% improved speeds loading a file. Could be entirely dependant on stucture of files I'm using though?
In the end, its not a massive issue in the slightest and it really comes down to how slow of a device you are using, was really just thinking blocking images would've being a relatively simple QoL change, now it sounds like it really comes down to effort versus reward and it doesn't seem like alot of a reward having to find some other way to improve it.

Just to be clear: what i meant is that the majority of the load is spent on the dom itself.  Lazy Loading Images will most likely still optimize some of the load Time for slow Devices (just not the big part, and the faster the device the less you will notice it).
It seems from the theory at least easier to achieve than switching to a complete virtual scrolling element (though it adds on top complexity in case of such an implementation). I may can check the difference when i find time after the current planned story

Yah it depends on the files (like how many images, their original size, how much text the book has etc.).
Just to be clear: What i meant is that the majority of the load resides in the dom. Still Offloading Images will most likely also lead to some lower times to a specific degree (the faster the device the less noticeable it gets)..
Its overall easier to implement than the whole virtual scroller i guess but will already have some issues with bookmark functionality. Its currently based on the current scroll position which is problematic when it can continously change due to later or earlier loaded images.
Does not hurt to keep this story as reminder for future extensions - maybe someone also finds a clever idea later

I have similar problems, but I don't have a particularly cheap phone. I also experience this in longer novels, even if there are 0 images (so I don't know that lazy loading images is the correct solution, although it should help in some cases).
For some context, I converted a bunch of web novels to epubs because I prefer the look and feel of ttu reader, plus the character counter. One I tried to read was ~890k characters (so, longer than most LNs, but shorter than a lot of WNs). On desktop it wasn't too bad, but on mobile it was basically unusable.
The problem, like mentioned in OP, is that it doesn't load from the book mark, it sends you to the beginning of the file until it's done loading the whole thing, and the page is pretty much unresponsive until it finished (which could take several minutes in my case), and if I'm unlucky, when it finishes loading it won't jump to the bookmark so I'll have to reload and try again.
Anyways, I know you said you knew the solution already (virtual scrolling), just wanted to jump in and say there's still interest for this

@RawToast just FYI I'm working on page-based view (instead of continuous scroll). Internally it'll load book parts (instead of merging them into one giant html) into view, which will improve the loading time for most EPUBs
Just letting you know in case you start working on it (as mentioned in the other issue), since my changes will have a lot refactor

Closing this unless the pagination's not good enough for load time


plugins/lsp/neocmake: init

https://github.com/neocmakelsp/neocmakelsp

This will be solved by #2365

Awesome


LAB_06_Upgrade_and_migrate_Windows Server.md

Source:
In addition, you want to test and document the Storage Migration Services functionality tovalidate its usage for migrations of on-premises file servers.
Current Translation:
さらに、記憶域移行サービスをテストし、オンプレミスのファイル サーバーの移行への使用方法を検証して文書化する必要があります。
Suggested Translation:
さらに、記憶域移行サービスの機能を使用してオンプレミス ファイル サーバーを移行する方法について、テストを実施し、文書化する必要があります。

Fixed

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team

Hello contributor,
Thank you for your contribution! We are processing your suggestions and we will update you shortly.
Kind regards,
Microsoft Worldwide Learning Team


[Bug] BucketDelayedDeliveryTracker.containsMessage is not thread-safe, but it's called from another thread

Search before asking

[X] I searched in the issues and found nothing similar.

Read release policy

[X] I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version
any released version of Pulsar
Minimal reproduce step
There's code that calls BucketDelayedDeliveryTracker.containsMessage.containsMessage from another thread
https://github.com/apache/pulsar/blob/1c53841cc7f585bdd8ff6702d74f37491d8cc9c6/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java#L389-L392
What did you expect to see?
Having thread-safety aspects considered in the BucketDelayedDeliveryTracker implementation.
What did you see instead?
There seem to be thread safety issues in BucketDelayedDeliveryTracker
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

Hi @lhotari,
I'm interested in contributing to Pulsar and believe this issue is a good starting point. I've reviewed the contribution guidelines and have submitted a PR for it: https://github.com/apache/pulsar/pull/23195. Since this is my first contribution, I'd appreciate it if you could take a look and let me know if there's anything I may have missed. I want to make sure I'm on the right track.
Thank you!


Extending other providers

Proposition:
#[provider]
struct SubProvider;

#[provider]
struct MainProvider {
    #[extend]
    sub: SubProvider
}

Progress:

[x] Proof of concept
[x] Support to extend a provider extending another provider
[x] Refactoring
[x] Add support for a provider ID
[ ] Support for external crates
[x] Documentation
[x] Benchmark
[ ] Gather more use cases

Waiting for more use cases.


Make idle culler settings configurable from the nebari-config.yaml

Reference Issues or PRs

Closes #1283
This PR makes it so users can configure the JupyterLab idle-culler settings directly from their nebari-config.yaml. The pattern that I used to achieve this was with a Terraform templatefile, which is a pattern that I believe we can use to modify other configuration files in the future (this might include the .bashrc and similar files).
I still need to add documentation for this but to change the idle-culler settings, you can add the following to your nebari-config.yaml:
jupyterlab:
  idle_culler:
    server_shutdown_no_activity_timeout: 100
    kernel_cull_connected: true

Any subset of the idle culler settings can be configured like this. By default, the jupyterlab key is not included.
What does this implement/fix?
Put a x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds a feature)
[ ] Breaking change (fix or feature that would cause existing features not to work as expected)
[ ] Documentation Update
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Other (please describe):

Testing

[x] Did you test the pull request locally?
[ ] Did you add new tests?

Any other comments?

Thanks, @iameskild I will have a look in a few minutes

Awesome! Thanks @viniciusdc!
For to be sure, I tested these on the GCP as well 👍

Hi @iameskild we both tested and all seams working, I will go ahead and merge this one.


ServiceMember.dimension looks like it should be array in Microsoft.ADHybridHealthService

The description here is of an oject of Item, which is a key/value object. O
https://github.com/Azure/azure-rest-api-specs/blob/9585c0c2827232575b192478fe6af0c2cec18ca1/specification/adhybridhealthservice/resource-manager/Microsoft.ADHybridHealthService/stable/2014-01-01/ADHybridHealthService.json#L6034-L6039
The example of this object has it as an array of Item.


Need to add a dropdown to filter the projects per organization.

Currently we show all of the accessible projects for the current user in a flat list. We need to add a way for the user to select what organization (or none) they are interested in before listing all projects.

This seems like problem mostly faced by googlers.

@ILMTitan I vote we just close this and look into it again if we get requests from other users.  I think the new project selection UI will solve this for most.


Can't change progressBar color in Java code

I can't find a way to change the color of progress bar without using CSS. Looks like adding style in xml doesn't work.
Is it even possible? Can anyone give an example how to make progress bar orange just by using java code?

Yes, even i need this.

currently there is no direct method for this, however you can use the method lookup to get a specific node and change its styling after being shown on the scene.


add eu-west-2 region

Hi,
This PR enables eu-west-2 region.
Best regards,
Michal

Hey.
Thank you for your contribution, but this repository is READ ONLY. You should close this PR and make a new one at http://github.com/async-aws/aws.
Regards
The bot at SubtreeSplit.com


Add check for unexpected references in conditions

When creating the model for a message specification it should be ensured that conditions refer only to previous message fields or known enumeration literals.

The checks in #22 are incomplete in that type constraints are not honored. The following case would not be recognized as a contradiction:
type R is range 1 .. 100;
type M is
   message
       F1 : R
         then F2 if F1 > 100;
       F2 : R;
   end message;

F1 > 100 is not a contradiction by itself, but violates the constraints of type R. When proving the specification we have to to generate a constraint for every variable Var according to its type:

modular type: Var < modulus
range type: Var >= first /\ Var <= last
always_valid enumeration: Var < 2**Size
regular enumeration: Var = enum(enum'first) \/ enum(enum'first + 1) \/ ... \/ enum(enum'last)

Also, enumeration literals used should belong to the correct enumeration type.

Looks like we cannot easily check whether enumeration literals belong to the right enumeration type. We'd need to do real type inference for that to work in general. I disabled the respective test for now (553b6fc). @treiher: Opinions?

I think this limitation is acceptable for now. We can look into it in the future.

Opened #87 to track that.


❓ [Question] Why was this Repo renamed to TensorRT ?

Thank you all for the great work on Torch-TensorRT.
It's been a pleasure to see it evolve since the days of TRTorch.
This repo went through multiple names but I think the current one is extremely confusing, if I clone both this repo and the original TensorRT repo I now have two TensorRT folders.
This is extremely confusing and at times infuriating. Would it be possible to know more about what prompted this naming choice ?
Wouldn't it be clearer to use Torch-TensorRT ?
PS: it seems other people are confused and are posting issues for TensorRT here

The reason we named it TensorRT is it follows convention within the pytorch org. Ex. vision, text, xla, tvm. This was the option amongst a few different options the PyTorch/Meta and NVIDIA teams agreed on when moving the the project to PyTorch to have the project best fit in. I get that it could potentially be confusing. Personally I have a pytorch_org directory to contain the pytorch projects Im looking at. I know others do git clone git@github.com:pytorch/TensorRT Torch-TensorRT. I believe we still have support in the code base to handle some of the legacy names so it should not break bazel.

Ok, thank you it's clearer now


Test preferences with mobileconfig and json and see if anything breaks if keys are missing.

I need people to test permutations of the configurations and report here if things break. We know that at the very least to get Nudge working you need a configuration that contains at least this.
But what happens if other things are missing or added? Or what if fake keys are added? How will the code currently work?
com.github.macadmins.Nudge.json
{
  "optionalFeatures": {
    "asyncronousSoftwareUpdate": true,
    "attemptToFetchMajorUpgrade": true,
    "enforceMinorUpdates": true
  },
  "osVersionRequirements": [
    {
      "aboutUpdateURLs": [
        {
          "_language": "en",
          "aboutUpdateURL": "https://support.apple.com/en-us/HT211896#macos1121"
        },
        {
          "_language": "es",
          "aboutUpdateURL": "https://support.apple.com/es-es/HT211896"
        },
        {
          "_language": "fr",
          "aboutUpdateURL": "https://support.apple.com/fr-fr/HT211896"
        },
        {
          "_language": "de",
          "aboutUpdateURL": "https://support.apple.com/de-de/HT211896"
        }
      ],
      "majorUpgradeAppPath": "/Applications/Install macOS Big Sur.app",
      "requiredInstallationDate": "2021-02-28T00:00:00Z",
      "requiredMinimumOSVersion": "11.3",
      "targetedOSVersions": ["11.0", "11.0.1", "11.1", "11.2"]
    }
  ]
}

com.github.macadmins.Nudge.mobileconfig
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>PayloadContent</key>
	<array>
		<dict>
			<key>PayloadDescription</key>
			<string>Configures all Nudge preferences</string>
			<key>PayloadDisplayName</key>
			<string>Nudge Preferences</string>
			<key>PayloadIdentifier</key>
			<string>com.github.macadmins.Nudge.preferences.example</string>
			<key>PayloadOrganization</key>
			<string></string>
			<key>PayloadType</key>
			<string>com.github.macadmins.Nudge</string>
			<key>PayloadUUID</key>
			<string>CA02957C-7472-446B-9F77-3E0414405556</string>
			<key>PayloadVersion</key>
			<integer>1</integer>
            <key>osVersionRequirements</key>
            <array>
                <dict>
                    <key>aboutUpdateURLs</key>
                    <array>
                        <dict>
                            <key>_language</key>
                            <string>en</string>
                            <key>aboutUpdateURL</key>
                            <string>https://support.apple.com/en-us/HT211896#macos1121</string>
                        </dict>
                        <dict>
                            <key>_language</key>
                            <string>es</string>
                            <key>aboutUpdateURL</key>
                            <string>https://support.apple.com/es-es/HT211896</string>
                        </dict>
                        <dict>
                            <key>_language</key>
                            <string>fr</string>
                            <key>aboutUpdateURL</key>
                            <string>https://support.apple.com/fr-fr/HT211896</string>
                        </dict>
                        <dict>
                            <key>_language</key>
                            <string>de</string>
                            <key>aboutUpdateURL</key>
                            <string>https://support.apple.com/de-de/HT211896</string>
                        </dict>
                    </array>
                    <key>majorUpgradeAppPath</key>
                    <string>/Applications/Install macOS Big Sur.app</string>
                    <key>requiredInstallationDate</key>
                    <date>2021-02-28T00:00:00Z</date>
                    <key>requiredMinimumOSVersion</key>
                    <string>11.3</string>
                    <key>targetedOSVersions</key>
                    <array>
                        <string>11.0</string>
                        <string>11.0.1</string>
                        <string>11.1</string>
                        <string>11.2</string>
                        <string>11.2.1</string>
                    </array>
                </dict>
            </array>
		</dict>
	</array>
	<key>PayloadDescription</key>
	<string>Configures Nudge application</string>
	<key>PayloadDisplayName</key>
	<string>Nudge</string>
	<key>PayloadIdentifier</key>
	<string>com.github.macadmins.Nudge.example</string>
	<key>PayloadOrganization</key>
	<string>Nudge</string>
    <key>PayloadScope</key>
    <string>System</string>
	<key>PayloadType</key>
	<string>Configuration</string>
	<key>PayloadUUID</key>
	<string>2F54F734-132D-4539-B583-F1DCF23DB5EB</string>
	<key>PayloadVersion</key>
	<integer>1</integer>
</dict>
</plist>

Full profiles can be found here:
https://github.com/macadmins/nudge/tree/main/Example Assets

But what happens if other things are missing or added? Or what if fake keys are added? How will the code currently work?
If I set requiredMinimumOSVersion to
MobileConfig: 11.6
JSON Config: 11.5
and install both, it will default to the MobileConfig, if I remove that key from mobileconfig but have the JSON it uses the 11.5 from JSON, If I remove the JSON file then the UI doesn't launch and this is logged
2021-02-18 04:34:46.070493-0800  localhost Nudge[48988]: [com.github.macadmins.Nudge:utilities] Current operating system (11.1) is greater than or equal to required operating system (0.0)
Putting an invalid 11.abc results in the comparison failing and no line Current operating system (11.1) is greater than or equal to required operating system xxx
Putting in unsused keys has no effect.
All in all it's pretty robust, are we comfortable mixing JSON and Profile prefs like this? Have DM'ed you some questions on some of the logic.

Yeah I have no issue with profile and json doing that. In fact that's exactly what I want.
One thing I'm curious about is what happens with the aboutUpdateURL and text if you supply a locale but nothing in it. Or specify the keys but no locale.
Thanks,
Erik Gomez

From: Rory Murdock<EMAIL_ADDRESS>Sent: Thursday, February 18, 2021 7:30:00 AM
To: macadmins/nudge<EMAIL_ADDRESS>Cc: Erik Gomez<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [macadmins/nudge] Test preferences with mobileconfig and json and see if anything breaks if keys are missing. (#114)
But what happens if other things are missing or added? Or what if fake keys are added? How will the code currently work?
If I set requiredMinimumOSVersion to
MobileConfig: 11.6
JSON Config: 11.5
and install both, it will default to the MobileConfig, if I remove that key from mobileconfig but have the JSON it uses the 11.5 from JSON, If I remove the JSON file then the UI doesn't launch and this is logged
2021-02-18 04:34:46.070493-0800 localhost Nudge[48988]: [com.github.macadmins.Nudge:utilities] Current operating system (11.1) is greater than or equal to required operating system (0.0)
Putting an invalid 11.abc results in the comparison failing and no line Current operating system (11.1) is greater than or equal to required operating system xxx
Putting in unsused keys has no effect.
All in all it's pretty robust, are we comfortable mixing JSON and Profile prefs like this? Have DM'ed you some questions on some of the logic.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/macadmins/nudge/issues/114#issuecomment-781344421, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABLL6GDHRSHBVNXB6436CZLS7UI5RANCNFSM4XZPAJSQ.

Putting an invalid 11.abc results in the comparison failing and no line Current operating system (11.1) is greater than or equal to required operating system xxx

This is incorrect. I Tested this a Swift Playground
print("11.2".compare("11.3", options: .numeric))
orderedAscending

print("11.2".compare("11.abc", options: .numeric))
orderedAscending

print("11.2".compare("11.1", options: .numeric))
orderedDescending

The comparison is actually happening and Nudge is detecting that the machine is out of date. That line only gets printed if the machine is running a higher OS than the requiredOSVersion.

One thing I'm curious about is what happens with the aboutUpdateURL and text if you supply a locale but nothing in it. Or specify the keys but no locale.

Tested this now. In both cases, Nudge does the right thing and does not display the More Info button.

I'm closing this. Feeling good about this.


Prepping for 0.6.3 release

Logging was updated to fix bugs as well allow for more user control of the log files. Additionally, most prints were moved to the stdout stream handler so that users could also shut off messages to the screen
The imexamine class was updated so that analysis functions could be more easily called by external entities. This was primarily to support ginga plugins, and a new imexam plugin for ginga.
A dictionary is now returned to the user when they request information on the active DS9 windows which are available.
Tests updated to be consistent with new package logging
Documentation and the jupyter examples updated
Fixed bug with loading user specified fits extensions for both ginga and ds9

Coverage decreased (-0.9%) to 26.325% when pulling e4cf35c62a34c5e3e10c701aa7377f4769363dbc on sosey:fix_logging into eea1c17a38e866f9b19060bd735c361c7a05b1a9 on spacetelescope:master.

Coverage decreased (-0.8%) to 26.347% when pulling b045390f6504a66713fd9fd25d23bce4fa51e99d on sosey:fix_logging into eea1c17a38e866f9b19060bd735c361c7a05b1a9 on spacetelescope:master.


Enhancement (Maybe bugfix?): Republisher support for OutputStreams in Collections

Now that we have a 1:1 correspondence between Publishers and OutputStreams in Units, and the ability to set Publisher specifics from the OutputStream initializer, it is now a little unintuitive and surprising that OutputStreams in Collections do not actually result in the creation of a Publisher that we could subscribe to from another process.  In particular, if a user has an OutputStream as part of a Collection that they want to expose on a public port (e.g. by defining the host or port keyword arguments for the collection OutputStream) -- currently, no Publisher will be created which is confusing behavior at best (and maybe a bug at worst).  The only time Publishers and Subscribers are created are when there is an OutputStream or InputStream defined as part of a Unit.
Adding a "Republisher" Unit at the collection level for each collection OutputStream could alleviate this confusing behavior, but at the expense of occupying more sockets and performance degradation. A Republisher decorator or hint of some sort might allow a user to explicitly define when an OutputStream is republishing a topic could be a beneficial feature addition, as well as a warning when it appears that a user is attempting to interact directly with Collection level Streams.  Currently, this is a bigger issue with OutputStreams because Subscriber objects have no configurable keyword arguments, but that's subject to change (future stream type enforcement/message filtering?) so it may be that republishers are required for all collection streams (performance regressions be damned).

@pperanich and @hannahgooden; I'd appreciate your thoughts on this when you get a chance.

lol oops -- reopening


CMake: Add CMake support

Added CMakeLists.txt file to ntp-client so that it can able build via CMake

@0xc0170 @hugueskamba

Let's rebase the branch and open new PR (travis should not be there anymore).


Unable to build for iOS

Unable to build iOS app when Data Dog RN SDK is added as a dependency.
React Native Version: 0.64.0
Describe what happened
Undefined symbols for architecture arm64:
  "Network.NWPath.isConstrained.getter : Swift.Bool", referenced from:
      closure #2 () -> Swift.Bool? in closure #1 (Network.NWPath) -> () in Datadog.NWPathNetworkConnectionInfoProvider.init(monitor: Network.NWPathMonitor) -> Datadog.NWPathNetworkConnectionInfoProvider in libDatadogSDK.a(NetworkConnectionInfoProvider.o)
  "Swift._ArrayBuffer._copyContents(initializing: Swift.UnsafeMutableBufferPointer<A>) -> (Swift.IndexingIterator<Swift._ArrayBuffer<A>>, Swift.Int)", referenced from:
      generic specialization <serialized, Swift._ArrayBuffer<Swift.Int8>> of Swift._copyCollectionToContiguousArray<A where A: Swift.Collection>(A) -> Swift.ContiguousArray<A.Element> in libDatadogSDK.a(ActiveSpansPool.o)
  "(extension in Foundation):__C.NSFileHandle.readToEnd() throws -> Foundation.Data?", referenced from:
      Datadog.File.read() throws -> Foundation.Data in libDatadogSDK.a(File.o)
  "static Foundation.JSONEncoder.OutputFormatting.withoutEscapingSlashes.getter : Foundation.JSONEncoder.OutputFormatting", referenced from:
      static (extension in Datadog):Foundation.JSONEncoder.default() -> Foundation.JSONEncoder in libDatadogSDK.a(JSONEncoder.o)
  "(extension in Foundation):__C.NSFileHandle.seekToEnd() throws -> Swift.UInt64", referenced from:
      Datadog.File.append(data: Foundation.Data) throws -> () in libDatadogSDK.a(File.o)
  "(extension in Foundation):__C.NSFileHandle.write<A where A: Foundation.DataProtocol>(contentsOf: A) throws -> ()", referenced from:
      Datadog.File.append(data: Foundation.Data) throws -> () in libDatadogSDK.a(File.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Steps to reproduce the issue:

yarn add dd-sdk-reactnative
from project root: cd ios
from ios folder: pod install
follow instructions here: https://github.com/DataDog/dd-sdk-reactnative#readme
open Xcode project and build

Describe what you expected:
For the app to build without error
Additional context
- Version of the SDK: 1.0.0-beta1
- A copy of your package.json file
package.json.txt

Hi @tbeech , sorry for the delay replying. Indeed we still need to have a proper troubleshooting documentation. This is something we'll trying to fix in the short term future. Let us know if you have any other issue with this library.


Parallel race operation

Problem
Although the language lets us join multiple concurrent computations, we cannot do that in a nondeterministic way; computations cannot be ordered by their completion times.
Solution

Use the go keyword?
Operation type: [T] -> [T]

foo = \() [number] {
  race([number 1, 2, 3])
}

References

#580
#579
#1085

Closed by #758 and #1239.


Fixes the spec file as it should display the recipe name and not default

Signed-off-by: Franklin Webber<EMAIL_ADDRESS>Description
The chef recipe generator creates a recipe file and a matching spec file. This spec file should be named after the recipe it is spec'ing.

Nice. Thanks


Figure 38.6-2 is missing

Section Number Figure 38.6-1
Issue Figure 38.6-2 is missing
Proposed Change *
The last sentence of Cross-Profile considerations reads, "The Patient Demographics Supplier may act as a proxy to an existing PDQ or PDQv3 environment as shown in Figures 38.6-1 and 38.6-2."
Figure 38.6-2 referred to in that sentence exists in the PDF but not in this IG.
Priority:

Low: Typo or other minor classification that an editor can manage. Requires no group discussion.

@DavidPyke Did you chose to combine these two diagrams into one?
I tend to like the new single diagram. Is there any concern with dropping the text reference to the diagram that does not exist?

I did combine them, I should have adjusted the text.  I'll do that.


PHP support

you forgot to add it to https://github.com/krzyzanowskim/tree-sitter-xcframework/blob/main/Sources/tree_sitter_language_resources/LanguageResource.swift


[Existing API Name] : PotterAPI

Brief Description 🤓
PotterAPI is a Harry Potter API developed with Express.js and available in multiple languages.
This API stores information and images of books, characters, and spells. It provides a way to search for books, characters, and spells based on various criteria such as keywords, or id. The API returns detailed metadata and can include additional features such as image URLs for each character.
Provide reference!
https://github.com/fedeperin/potterapi?tab=readme-ov-file
Select the open source program you are contributing to
Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

Greetings @DonaldReddy🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gssoc24 to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

/gssoc24

Hey @DonaldReddy ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗.
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


Odd behavior of primary clipboard

Selected text in gnome-terminal does not get pasted into kate and vice versa, i.e. selected content in kate not get pasted into gnome-terminal.
Interestingly, the text from kate could be pasted e.g. to konsole, and vice versa, so there's probably some subtle bug in clipboard handling.
Steps to reproduce:

Open gnome-terminal and kate.
Select a text in gnome-terminal.
Try pasting the selected with middle mouse button into kate.

OS: Archlinux
Sway version: 0.10-1

Known issue with wlc. Wayland and x clipboards are not synced.

@SirCmpwn could you please link the issue?

I've heard alike somewhere, but recently when I had to refer the problem myself, I couldn't find anything on wlc or sway github, or anywhere, as if I imagined the discussion I saw.

It's not really an issue that goes on anything. The solution requires an external daemon that should be a separate project.

@SirCmpwn well If the problem is just that, then Gnome already has the daemon (I just checked: the problem did not reproduce in gnome-on-wayland), and the problem again boils down to Sway: why doesn't Sway use this daemon?

Because sway isn't GNOME.

Could you please elaborate?

They don't design their software to be reusable in other projects. Knowing them it probably involves dbus too.

So you don't know for sure… Anyway, somewhere should be the issue opened, to refer to. Because XWayland isn't going anywhere soon. E.g. I feel, it gonna take a long time for Wine to get ported.
Then, if not Sway, where should I open a bug for this? XWayland project? Anything else?

You should just implement it if you're that concerned about it. Opening a bug doesn't really change anything.

@SirCmpwn Why would this be implemented as an external daemon instead of as part of wlc? Is clipboard handling done in sway itself, or is there some reason why wlc would only handle the clipboard for wayland applications? It seems like it has a bunch of xwayland-specific code already.

I suppose it could be implemented that way but a daemon could be reused for other compositors. Unlike GNOME, sway does strive to make reusable component ;)

Hm, I think it's important enough to expect it to work out-of-the-box though. For example KeePassX uses Qt4 and AFAIK that means it will run through XWayland. And Chromium users probably also copy links or text into other applications frequently enough (Chromium still uses gtk2, not sure how far they've gotten with porting to gtk3).
We should probably also ask @Cloudef: is clipboard sharing with X programs something you would like to have in wlc?

You're right that it should work OOTB, but remember sway is 0.x and not done.

Oh, I see what you mean. Well, we can automatically run the daemon.

Alright, sounds good enough. Considering gtk2 and qt4 are kind of phasing out and it's gonna be a while until it's realistic for most i3 users to switch to sway, this might not be such a big thing actually.
Just looked up if there were efforts to port keepassx to qt5, and actually it's already done and works (in arch it's as simple as installing keepassx-git from AUR) :)


About the "@" syntax used in code ?

Hello @dbolya
Thank you for your great contribution.
Inside the source code, I found some places where you use the "@" syntax such as:
        cos_sim = coeffs_norm @ coeffs_norm.t()
        pred_masks = proto_masks @ proto_coef.t()
        intersection = masks_a @ masks_b.t()
        masks = proto_data @ masks.t()

Would you mind give me a quick explanation about this syntax?

The @ operator performs matrix multiplication, see https://www.python.org/dev/peps/pep-0465/

@tlind Thank you


Team Apply page

Proposal:
Proposal written by Monkeyyy11
What is the title of your proposal?: Team Apply page
Is it a suggestion for the website or for the bot?: Website
Explain your proposal more accurately (It's best to give as much information as possible, so that we can implement the proposal better): A website page where you can apply for all differnent lenoxbot team roles like moderator, documentation moderator
Why should we add this feature?: It‘s better than google forms (what we currently use)
ReportID: 125

➤ LenoxBot commented:
Approve:
good idea
Denarioyt#3352

➤ LenoxBot commented:
Approve:
agree with denario
🎃CrEePeR28 || Furkan🎃#3532

➤ LenoxBot commented:
Approve:
agree with Denario and Furkan
Profxy#5396


added face-api models

Adds the face-api models from: https://github.com/justadudewhohacks/face-api.js?files=1

Super!

@joeyklee Should I merge this and keep a copy of the face-api model here or have we changed how this process works?

Oh wow this is an old one! From ages ago actually. Mmm I think for now probably it's ok to add this in. I will merge now.

This whole repo isn't really being used or maintained, but we will likely need to figure out a better solution of storing models somewhere since keeping them in the git history will bloat this repo up!

Indeed, however, I am using it now as a place to store example charRNN models for the IMA assignment this week!

It looks like we'll need to merge this into main to unbreak our FaceAPI model which is depending on the models in this branch: https://github.com/ml5js/ml5-library/blob/36a7ceafce4ccd31700c316b5beb32c862221a3c/src/FaceApi/index.js#L23

Opened issue https://github.com/ml5js/ml5-library/issues/1093 to come back and fix this. For now, to bypass having this be broken until we release again, I opened up another branch called face-api with the models files in it.