Replace redundant explicit move-ctors&move-op= by default

Why not just allow compiler do its job?

std::atomic is not copyable or movable. Have you built this successfully?

Yup.
viktor@pc:~/d/t/build|master✓
➤ git show | grep default
    Replace redundant explicit move-ctors&move-op= by default
+            Cell(Cell&&) = default;
+            Cell& operator=(Cell&&) = default;
+        MPMCBoundedQueue(MPMCBoundedQueue&&) = default;
+        MPMCBoundedQueue& operator=(MPMCBoundedQueue&&) = default;
+        ThreadPool(ThreadPool&&) = default;
+        ThreadPool& operator=(ThreadPool&&) = default;
+        Worker(Worker&&) = default;
+        Worker& operator=(Worker&&) = default;
viktor@pc:~/d/t/build|master✓
➤ make clean ; make
Scanning dependencies of target HEADER_ONLY_TARGET
[ 12%] Linking CXX static library libHEADER_ONLY_TARGET.a
[ 12%] Built target HEADER_ONLY_TARGET
[ 25%] Building CXX object tests/CMakeFiles/fixed_function_test.dir/fixed_function.t.cpp.o
[ 37%] Linking CXX executable fixed_function_test
*** Testing FixedFunction ***
 - for type size 8
    function size is 24
    overhead is 200%
 - for type size 16
    function size is 32
    overhead is 100%
 - for type size 32
    function size is 48
    overhead is 50%
 - for type size 64
    function size is 80
    overhead is 25%
 - for type size 128
    function size is 144
    overhead is 12.5%
 - test ( alloc/dealloc => succeed )
 - test ( free func => succeed )
 - test ( free func template => succeed )
 - test ( void func => succeed )
 - test ( class method void => succeed )
 - test ( class method 1 => succeed )
 - test ( class method 2 => succeed )
 - test ( lambda => succeed )
[ 37%] Built target fixed_function_test
[ 50%] Building CXX object tests/CMakeFiles/thread_pool_test.dir/thread_pool.t.cpp.o
[ 62%] Building CXX object tests/CMakeFiles/thread_pool_test.dir/thread_pool2.t.cpp.o
[ 75%] Linking CXX executable thread_pool_test
*** Testing TP ***
 - test ( post job => succeed )
[ 75%] Built target thread_pool_test
[ 87%] Building CXX object benchmark/CMakeFiles/benchmark.dir/benchmark.cpp.o
[100%] Linking CXX executable benchmark
[100%] Built target benchmark
viktor@pc:~/d/t/build|master✓
➤ ./tests/fixed_function_test
*** Testing FixedFunction ***
 - for type size 8
    function size is 24
    overhead is 200%
 - for type size 16
    function size is 32
    overhead is 100%
 - for type size 32
    function size is 48
    overhead is 50%
 - for type size 64
    function size is 80
    overhead is 25%
 - for type size 128
    function size is 144
    overhead is 12.5%
 - test ( alloc/dealloc => succeed )
 - test ( free func => succeed )
 - test ( free func template => succeed )
 - test ( void func => succeed )
 - test ( class method void => succeed )
 - test ( class method 1 => succeed )
 - test ( class method 2 => succeed )
 - test ( lambda => succeed )
viktor@pc:~/d/t/build|master✓
➤ ./tests/thread_pool_test
*** Testing TP ***
 - test ( post job => succeed )
viktor@pc:~/d/t/build|master✓
➤ ./benchmark/benchmark
Benchmark job reposting
***thread pool cpp***
reposted 1000001 in 326.825 ms
reposted 1000001 in 326.917 ms
reposted 1000001 in 326.93 ms
reposted 1000001 in 326.941 ms
reposted 1000001 in 327.907 ms
reposted 1000001 in 328.6 ms
reposted 1000001 in reposted 1000001 in 328.945 ms
328.943 ms
reposted 1000001 in 329.994 ms
reposted 1000001 in 330.661 ms
reposted 1000001 in 330.985 ms
reposted 1000001 in 330.991 ms
reposted 1000001 in 331.382 ms
reposted 1000001 in 331.648 ms
reposted 1000001 in 331.799 ms
reposted 1000001 in 331.814 ms
***asio thread pool***
reposted 1000001 in 7704.77 ms
reposted 1000001 in 7707.09 ms
reposted 1000001 in 7710.09 ms
reposted 1000001 in 7713.3 ms
reposted 1000001 in 7714.2 ms
reposted 1000001 in 7714.54 ms
reposted 1000001 in 7719.97 ms
reposted 1000001 in 7722.57 ms
reposted 1000001 in 7723.58 ms
reposted 1000001 in 7727.21 ms
reposted 1000001 in 7727.41 ms
reposted 1000001 in 7727.56 ms
reposted 1000001 in 7728.78 ms
reposted 1000001 in 7729.22 ms
reposted 1000001 in 7729.29 ms
reposted 1000001 in 7731.99 ms

gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

It's true that all the current tests pass, but the truth is that move is not being tested. Apologies for that. As an example, the following test produces a compilation error with your changes:
doTest("ctor0", []
{
    ThreadPoolStd pool;
    auto pool2 = std::move(pool);
});

As per above


Remove contracts symlink

it was only required for populus build; now it can go

LGTM, let's wait till tests pass.


chore: Update storage module versions

Signed-off-by: Derek Trider<EMAIL_ADDRESS>

Note that once #2815 is done, this module doesn't need to be imported from the main Aries module anymore.


reset the state for the delay context action if it is not the delete action

Details

Reset the state for the delay context action if it is not the delete action. delete action modal handles/reset the state by itself.
Fixed Issues

$ 11086
PROPOSAL: 11086
Tests

Open the context menu for any message
Click on copy to clipboard action of popover
On the same opened popover click Delete comment
Delete comment should work and delete the message

[X] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the context menu for any message
Click on copy to clipboard action of popover
On the same opened popover click Delete comment
Delete comment should work and delete the message

[X] Verify that no errors appear in the JS console

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above

[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms

[X] I ran the tests on all platforms & verified they passed on:

[X] iOS / native
[X] Android / native
[X] iOS / Safari
[X] Android / Chrome
[X] MacOS / Chrome
[X] MacOS / Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)

[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product was added in all src/languages/* files
[X] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers

[X] I followed the guidelines as stated in the Review Guidelines

[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)

[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)

[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such

[X] I verified that if a function's arguments changed that all usages have also been updated correctly

[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)

[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

[X] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for expected offline behavior are in the Offline steps section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots

Web

Recording_1669097982090.webm
Mobile Web - Chrome

Mobile Web - Safari

https://user-images.githubusercontent.com/14358475/203307888-528720e1-5606-434a-9443-bfab806dc8e7.mp4
Desktop

Recording_1669097982090.webm
iOS

https://user-images.githubusercontent.com/14358475/203307141-1f06cfcb-c6f1-4a24-a1fc-424f8020b66e.mp4
Android

https://user-images.githubusercontent.com/14358475/203311348-fa0e7eed-f1f9-4d0e-a19d-b465081b8981.mp4

@Pujan92 I don't follow the change. We're adding a check whether delete modal is visible. Tomorrow if we add another action/modal we'll end up with the complex branching.
I personally liked this proposal here by @0xmiroslav. @deetergp what are your thoughts?

I personally liked this proposal here by @0xmiroslav. @deetergp what are your thoughts?

That solution is cleaner but the only concern there is about mutating the state directly which I think we should avoid.

I personally liked this proposal here by @0xmiroslav. @deetergp what are your thoughts?

That solution is cleaner but the only concern there is about mutating the state directly which I think we should avoid.

@Pujan92 one of the earlier comments was mutating the state with this.state = ..., the one I linked uses setState with a callback. Not mutating the state there.

Oh, Ok. But I think in that case delete won't work as we are resetting report fields. I just tried that, can you plz check once.

tests well for me

Copy to clipboard and delete working together for you? I just put in your changes but seems not working
ed179627-b711-443f-9d91-b62889ec774d.webm

Bumping @deetergp

@Pujan92 can you elaborate my code changes you applied for test?

I added it here, please correct me if I added it incorrectly or you can share the working video.
   runAndResetOnPopoverHide() {
        this.setState({reportID: '0', reportAction: {}}, () => {
            this.onPopoverHide = this.runAndResetCallback(this.onPopoverHide);
            this.onPopoverHideActionCallback = this.runAndResetCallback(this.onPopoverHideActionCallback);
        });
    }

@Pujan92 I already guessed you missed this code:
    hideContextMenu(onHideActionCallback) {
        if (_.isFunction(onHideActionCallback)) {
            this.onPopoverHideActionCallback = onHideActionCallback;
        }
        this.setState({
-           reportID: '0',
-           reportAction: {},
            selection: '',
            reportActionDraftMessage: '',
            isPopoverVisible: false,
        });
    }

Oh, yes. It is working as expected @0xmiroslav 🎉

@Pujan92 Can you work on the changes please?

@Pujan92 Can you work on the changes please?

Done, applied the suggested change by @0xmiroslav .

@Pujan92 Sorry I should've highlighted this. I just started to test this and saw we're on the old theme. We've moved to Dark theme since the time we've merged and had a regression. Can you please take the latest main branch? Also update the PR screencasts to cover the new UI.

Ok.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/3069065/205139358-b7cb77a3-f190-4715-a4ba-b8559c70e6e7.mov

Mobile Web - Chrome
https://user-images.githubusercontent.com/3069065/205139436-48529070-2ef6-4f38-b74f-104368b3ed94.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/3069065/205139562-6d826cbf-5b50-436d-bc5b-a34b1803c263.mov

Desktop
https://user-images.githubusercontent.com/3069065/205139611-ec4e4907-5f43-475b-9d19-415c9c062e3b.mov

iOS
https://user-images.githubusercontent.com/3069065/205139779-d2b25fbb-b042-4ae3-b541-a30ef7e0c4b1.mov

Android
https://user-images.githubusercontent.com/3069065/205139845-b58bd3f0-68cf-4b57-a6bc-1ddaaec03f13.mov

Thanks for the updated changes @Pujan92. Appreciate you sticking around and taking this to the finish line.
@deetergp All yours.
I am not sure why @Julesssss is still tagged.  I don't have a way to change this. May be @deetergp can help.
🎀 👀 🎀
C+ reviewed

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Normalize all paths for the input

Description
As can be seen below when executing ts-node src/index.ts -i  with an absolute path program tries  to look for directory + path name which results in this 'D:\\til-tool\\D:\\example'
D:\til-tool> ts-node src/index.ts -i D:\example
Error: ENOENT: no such file or directory, scandir 'D:\til-tool\D:\example'
    at Object.readdirSync (node:fs:1452:3)
    at Object.module.exports.readDirectory (D:\til-tool\src\utility\readDirectory.ts:8:22)
    at Object.<anonymous> (D:\til-tool\src\index.ts:62:32)
    at Module._compile (node:internal/modules/cjs/loader:1254:14)
    at Module.m._compile (C:\Users\pavel\AppData\Roaming\npm\node_modules\ts-node\src\index.ts:1618:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
    at Object.require.extensions.<computed> [as .ts] (C:\Users\pavel\AppData\Roaming\npm\node_modules\ts-node\src\index.ts:1621:12)
    at Module.load (node:internal/modules/cjs/loader:1117:32)
    at Function.Module._load (node:internal/modules/cjs/loader:958:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12) {
  errno: -4058,
  syscall: 'scandir',
  code: 'ENOENT',
  path: 'D:\\til-tool\\D:\\example'

Thanks for the feedback! This tool is basically designed to support 'Relative path" starting from the tool directory. I'll be refactoring this one when I have a chance. Thanks


SAKIII-4574 modified embedcontent widget to use a batch request to get c...

https://jira.sakaiproject.org/browse/SAKIII-4574

New pull request at https://github.com/sakaiproject/3akai-ux/pull/1473


Doxygen cannot genearete document.

In v1.0.0, Doxygen cannot generate the document of the rpp_driver::I2cMaster and others.
The root cause of this problem is the new conditional compile which covers the whole i2cmaster.hpp.  To overcome it, we should add some new predefined macro. For example, the current implementation of the conditional compile  is like this :
https://github.com/suikan4github/rpp_driver/blob/f380e2b3bb627307570cfc471da681ec3f8d8a46/src/i2c/i2cmaster.hpp#L13
We can change it to :
 #if __has_include(<hardware/i2c.h>) || __has_include(<gmock/gmock.h>) || DOXYGEN_COMPILE

And then, add DOXYGEN_COMPILE macron to the Doxyfile.

Ready to release.


Add rails command

rails is another command that comes up frequently during ruby/rails
development.
This adds a shortcut for brevity:
> nib run web rails
becomes
> nib rails web
This preserves arguments to rails:
>nib rails web --version
Rails 5.0.0.beta2

Looks good. Thanks for catching the README update. Squash and merge?


Add retries for obtaining image data

Clarifying #34, it was happening to 200 responses. Referring to an excerpt of the logs:
2024-01-13 18:32:07,483 INFO Fetching metadata of images...
2024-01-13 18:32:09,041 ERROR Failed to get detailed information for image: {'image_set_id': '...885c', 'image_id': 'ExYd...'} for Reason: API response is missing data.

It was in the form Failed to get detailed information for image: {image_ids} for Reason: API response is missing data., which corresponds to the logging from get_image_data(). Had the response not been 200, it should have logged from get_detail_image() from image_utility.py, which wasn't the case (notice the missing second : after Reason:).
As of the latest commit, I was still getting the same errors, with the error even being logged just under 2 seconds apart:
2024-01-14 00:50:34,012 INFO Fetching metadata of images...
2024-01-14 00:50:35,614 ERROR Failed to get detailed information for image: {'image_set_id': '...2bd6', 'image_id': 'CQp9...'} for Reason: API response is missing data.

With this PR, the program would be able to retry and retrieve the image data from the links several times until data is successfully retrieved for all images, merging results from previous attempt until no None values remain.
For now, the retries is set to 5, which should ideally be configurable as discussed in #34 in a future commit. As it is, I was able to download all 157 images successfully with the file method and this PR within 2-3 tries.

Anyway, an example of the output with this PR would look like so:
2024-01-14 00:50:34,012 INFO Fetching metadata of images...
2024-01-14 00:50:35,614 ERROR Failed to get detailed information for image: {'image_set_id': '...2bd6', 'image_id': 'CQp9...'} for Reason: API response is missing data.
...
2024-01-14 00:50:39,240 WARNING Failed to get detailed information for some images. Retrying (1) and merging...
2024-01-14 00:50:40,749 ERROR Failed to get detailed information for image: {'image_set_id': '...32dc', 'image_id': 'H4XS...'} for Reason: API response is missing data.
...
2024-01-14 00:50:42,495 WARNING Failed to get detailed information for some images. Retrying (2) and merging...
2024-01-14 00:50:43,863 ERROR Failed to get detailed information for image: {'image_set_id': '...a058', 'image_id': 'XhA0...'} for Reason: API response is missing data.
2024-01-14 00:50:47,308 INFO Starting download of 157 images.
2024-01-14 00:50:49,231 INFO Statistics zipped.
2024-01-14 00:50:49,278 INFO Successfully downloaded 157 of 157 images in 15.27 seconds.

@rc-gr
I can't replicate the issue with my 1600 images and the new timeout.
Can you see if increasing the timeout helps?
The issue is that the API returns a 200 and an empty data or data['value'] in the body.

@rc-gr
Also the performance of the detail API degrades the more often you call it in a time frame to the point where even going to https://bing.com will give you an error.
It seems to be IP bound because it needs no authentication.

The issue is that the API returns a 200 and an empty data or data['value'] in the body.
Yes, so this PR would at least prevent the need to re-run the program to merge the results from each attempt with different incomplete downloads manually.

@Richard-Weiss Unfortunately, as of e382624, I'm still getting said empty data from some images each run:
Attempt 1 (127/157)
2024-01-14 01:55:29,300 INFO Fetching metadata of images...
2024-01-14 01:55:31,066 ERROR Failed to get detailed information for image: {'image_set_id': '...199f', 'image_id': 'zmX3...'} for Reason: API response is missing data.
...
2024-01-14 01:55:33,122 INFO Starting download of 127 images. (out of 157)

Attempt 2 (135/157)
2024-01-14 02:01:52,112 INFO Fetching metadata of images...
2024-01-14 02:01:54,057 ERROR Failed to get detailed information for image: {'image_set_id': '...3c49', 'image_id': 'NDm5...'} for Reason: API response is missing data.
...
2024-01-14 02:01:55,429 INFO Starting download of 135 images.

Perhaps it might be a difference in geographical location that's causing such spotty access to the image pages on my end.

@rc-gr
That shouldn't really be possible to happen this quickly because of the timeout.
Can you try making sure you have the latest commit and no other changes by stashing your changes and using git reset origin --hard after you synced your fork?
You can also debug the _do_request method in the _RequestContext class in the client.py file of aiohttp-retry and set a conditional breakpoint at the current_attempt += 1 line to break if current_attempt == 7.
If it's not breaking it's not doing all the attempts first which would lead to this behavior.

@Richard-Weiss  Yes, I performed git reset origin --hard. Same issue.

You can also debug the _do_request method in the _RequestContext class in the client.py file of aiohttp-retry and set a conditional breakpoint at the current_attempt += 1 line to break if current_attempt == 7.
If it's not breaking it's not doing all the attempts first which would lead to this behavior.

Even if this is the case, why would it re-attempt when the data is not entirely empty? If I were to log just after data = await response.json() and print data, I get this (the first line. Third line shows what the normal data would look like):
2024-01-14 02:36:17,736 INFO {'iusn': False, 'totalEstimatedMatches': 0, 'value': None, 'generativeImageCaption': None, 'selectedIndex': 0}
2024-01-14 02:36:17,737 ERROR Failed to get detailed information for image: {'image_set_id': '...ac41', 'image_id': '43au...'} for Reason: API response is missing data.
2024-01-14 02:36:17,738 INFO {'iusn': False, 'totalEstimatedMatches': 4, 'value': [{'contentUrl': '...', 'datePublished': '2024-01-10T22:04:33.0000000-08:00', 'hostPageDiscoveredDate': '2024-01-10T22:04:33.0000000-08:00', 'encodingFormat': 'jpg', 'width': 1024, 'height': 1024, 'thumbnailUrl': '...', 'imageId': '...', 'imageAltText': "...", 'name': "...", 'source': 'BingGenerativeImage', 'hostPageUrl': '...', 'sicid': '...', 'UniqueId': {'Namespace': None, 'K': 0, 'KValue': 0}}...'selectedIndex': 2}

@rc-gr Also the performance of the detail API degrades the more often you call it in a time frame to the point where even going to https://bing.com will give you an error. It seems to be IP bound because it needs no authentication.

Okay...Then perhaps some additional configurable safeguards can be added on top of this PR? For example, perhaps adding a delay between each attempt, or a dynamic one depending on how large the collection is, might help?

@rc-gr
I think I know what the problem might be.
Because it's a 200 it's not retried by aiohttp-retry.
I would need to add a callback like in the collection import that checks the data and data['value'].
It's just really odd that it didn't happen to me after the implementing the timeout.
I'll create a new PR for it that should address this directly.

@rc-gr
Can you try #42?
It should prevent invalid 200 responses from not being retried, but it was hard for me to replicate.
If I lowered the timeout by too much I got 203s but not invalid 200s.
I only got one and it was retried in that case.

@Richard-Weiss Okay, now I'm getting feeback from get_detail_image(), but the performance seems to be worse in comparison to what I had as of this PR. The retries using 2804738 doesn't seem to want to get back the proper data...
You may compare the logs (with the values removed) below:
As of 2804738 (92 of 157 images, ~4.5 mins to start of download):
bing_image_creator_2804738.log
As of this branch with this PR (140+ of 157 images each, 2 attempts, ~5 secs to start of download):
bing_image_creator_file-outer-retry.log

Also, I tried 2804738 using a different IP address. It works, but it's still taking too long, and I'd still like to be able to use the program without a proxy:
2024-01-14 08:44:59,887 INFO Fetching metadata of images...
2024-01-14 08:49:27,753 INFO Starting download of 157 images.
...
2024-01-14 08:49:36,902 INFO Successfully downloaded 157 of 157 images in 277.02 seconds.

@rc-gr
Yeah, I noticed the callback being really expensive for some reason.
I'll look into merging main with this and pulling the functionality into a dedicated method, so it can be used for both strategies.

@rc-gr
Can you check if it works with my commits to this PR?
I'm ready to merge if it works with you, I can't replicate the issue on my end.

@Richard-Weiss Yep, seems to be working in order.
All that's left is to have the attempts configurable sometime later in the config. For now, 5 gives enough slack without being obnoxiously long in my opinion. With the 157 images, the program took 24.29 secs with max attempts for me.

@rc-gr
Sure, I can add a setting for that.

@rc-gr
I added the setting to the config, you can try it out.


Exported basic link classes

Used an intermediary object so I could put accessibility warnings on the members in TSDocs.
See Abstract for design references.

no

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I still might eventually need this, but the time hasn't come.


Move verification out into separate script to fix ARM64 use

Some platforms don't have the clang sanitizer checks available that are used in the verification tests, currently on these the output files can't even be amalgamated. To fix this, separate amalgamation and verification so that the later can be skipped. Fixes #273

If anyone knows why the fuzzing workflow suddenly can't find miniz_export.h anymore lemme know, I thought I hadn't moved anything around that could possibly break that (this file should still be generated by test.sh after my pull request is applied) so I don't understand what's going on there. Or is the workflow just generally broken? I can't quite make sense of it.
I would really love for this whole ARM64 musl-libc situation to get fixed soon, because it's just quite cumbersome to work around and I'm starting to shift a lot of my projects to more heavily support various ARM64 variants.

If https://github.com/richgel999/miniz/commit/a77af68d92249324a8b41986bf048becf403e1cf was the reason why CIFuzz / Fuzzing failed then maybe this is still good to go in. Sadly I don't know how to trigger the build again to test if it works now. Nevertheless, the underlying problem with platforms without libsanitize support seems to remain.


Not an issue searching for knowlege (best practice for not been banned from whatsapp)

HI, all. weach are the best practice for NOT been banned from whatsAPP.
yesterday i sent 293 messages then BANNED, today i just add to google account 593 contacts.
and send 593 messages with 1.30 minutos interval and not BANNED.
please some advice.
Victor

The 293 number you sent to are they in your contacts list? Or not?

It sounds like you are using this repo for spam. This is strongly against what we stand for. WhatsApp will notice unsolicited messages with contacts that you have never been in touch with before.

i try it to add to contact in the phone, but no luck.

i try it to add to contact in the phone, but no luck.

can't add users to contact or is there no point in having contacts on cell phone?


Tag Versions

1.9.5 > 1.93
OR
1.9.5 < 1.93
Is it spell error?

1.9.5>1.9.4>1.93

From the number , 93 > 9 .
1.93 is 1.9.3 ?

done, I've renamed these tags, thanks~!


Add v2 route

Pull Request Test Coverage Report for Build 1368

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 75.6%

Totals

Change from base Build 1363:
0.0%

Covered Lines:
2938

Relevant Lines:
3692

💛  - Coveralls

:tada: This PR is included in version 1.14.5 :tada:
Your semantic-release bot :package::rocket:


Improve MPMCQueue Performance

Add waiting thread queue to wake up worker threads in LIFO order.
Modify underlying data structure.

#19614


No autocomplete for native JavaScript props and methods

From @fronteed on September 17, 2016 10:16

VSCode Version: 1.5.1
OS Version: OS X El Capitan

Autocomplete for native methods and properties in JavaScript doesn't work inside IIFE (Immediately-Invoked Function Expression).
Steps to Reproduce:

Type document.get at the top of JS file - you will get 'getElementById` autocomplete suggestion.

Type document.get inside IIFE construction - you'll get no autocomplete suggestion for getElementById.

(function (window, document) {
  document.get| // no autocomplete
})(window, document)

This looks like an issue, I hope this will be fixed in the next release.
Copied from original issue: Microsoft/vscode#12186

From @rozzzly on September 17, 2016 15:3
Offtopic.. but what theme is that lol looks nice.

@fronteed thanks for opening this issue. Moving to TypeScript language service (powers JavaScript auto complete).

Should be working correctly in latest drop of TypeSript (TS 2.0.2 or later). VSCode ships with an older version of TypeScript. Please see Using Newer TypeScript Versions documentation for more details on updating your VSCode to use a different version of TypeScript.

Current issue still exists in VS Code v1.5.3, please check it again.

Current issue still exists in VS Code v1.5.3, please check it again.

what version of TS have you been using with VSCode 1.5.3?

@mhegazy I'm using a built-in one.

Well. as i noted in https://github.com/Microsoft/TypeScript/issues/11012#issuecomment-248387807

Should be working correctly in latest drop of TypeSript (TS 2.0.2 or later). VSCode ships with an older version of TypeScript. Please see Using Newer TypeScript Versions documentation for more details on updating your VSCode to use a different version of TypeScript.


[BUG][Sounds] Strange behavior with sounds

I have observed some strange behavior with sounds.
sound = this.sound.add('some sound 1');
sound = this.sound.add('other sound 2');
sound.play();

In this case both 'some sound 1' and 'other sound 2' will play at the same time.

I'm unable to replicate it.
Can you provide an example demonstrating this behavior?

I will try to create a test case.

@pavle-goloskokovic So did you replicated it?

@ZaDarkSide I'll look into it

Ok, I figured it out, it's not a bug with Sound API but with Loader.
When you load the second file, complete event callback is called twice, for both files, even if you call self.load.reset(); before loading audio file.
I've updated fiddle to log message when on complete callback is called: https://jsfiddle.net/L4gkttkx/48/

Great news, well we should fix that somehow.

Yes, because Loader.reset doesn't remove any previously bound event listeners, because people were complaining that when the Scene finished loading (and reset the Loader) their event listeners were lost too. Can't have both :)

I have managed to fix it my code.
https://jsfiddle.net/L4gkttkx/51/

@ZaDarkSide or you could just add self.load.removeAllListeners(); below self.load.reset();

OK, thanks for the hint.


Remove unnecessary analysis/nodes related view dependencies

The primary change is removing unnecessary view dependencies and extracting some logic that didn't belong in the views.
Secondary changes that was enabled by this:

Removed a lot of unnecessary boilerplate in the test setups.
Make the node definitions collection on the analysis definitions collection private, i.e. no more analysisDefinitionsCollection.analysisDefinitionNodesCollection…
Fixed a bug on the composite analysis node view; render a secondary source pointing to the owner-layer even if it isn't the layer's head node

@xavijam can you review, please?
cc @javierarce FYI

retest this please

Bump, fixed some minor issues I found after updating

:+1:


Navigation menu tooltip issue

Prerequisites

[X] I have read the Contributing Guidelines.
[X] I have not leaked any internal/restricted information like screenshots, videos, code snippets, links etc.

What happened?
Hi Team,
Unable to see any tooltip on hover on navigation menu.
Expectation - Able to see menu name inside tooltip when navigation bar is collapsed

Kindly help to suggest on the same.
What type of frontend framework are you seeing the problem on?
Angular
Which version of iX do you use?
2.1.2
Code to produce this issue.
<ix-menu>
  <ix-menu-item home-tab tab-icon="home"> Home </ix-menu-item>
  <ix-menu-item tab-icon="globe"> Normal Tab </ix-menu-item>
  <ix-menu-item tab-icon="star" disabled> Disabled Tab </ix-menu-item>
</ix-menu>

Hello @praveenn16 - thanks for your insights. This issue has already been reported and currently we are working on it. As this is a duplicate i will close this issue.


Rename "styles" prop to "css"

This renames the styles prop for passing in css styles to a component to css.
Why was this change made?
styles is too closely related to style which would add the passed in styles as inline styles to an element, instead of funneling it through Stardust's css-in-js processor.
Example
Before:
 <Button content="Click here" styles={{backgroundColor: "red"}} />

Now:
 <Button content="Click here" css={{backgroundColor: "red"}} />

agree, lets wait for other folks expressing their ideas on that. Speaking of the points expressed

However, I am not sure that this is enough. Do we want to just rename the prop to css and still talk about it as styles throughout the code?

we might come to some other naming convention, but, frankly, doesn't seem to be that critical - due to this 'styles' term won't be ambiguous within the Stardust context. Don't get me wrong: if there are reasons to rename these files, lets rename them - just saying that it shouldn't be the factor that will stop us from making this move, as it seems to be not that critical.

Random places which were not renamed - mergeComponentStyles function, all themes/**/*Styles.ts files and variables in them

quite similar thoughts on this. To me it seems that if we would pedantically follow naming convention that would resemble prop name just for the sake of following it (here I might be mistaken, but currently it won't be ambiguous to me if we'll talk about styles applied via css prop).

css diverges from Fabric which uses styles.

here the question we might ask ourselves is 'whether we are fine to leave styles prop name as it is' - here I'd definitely vote for changing it, even given that we will diverge from Fabric's names, as it introduces quite serious chance to confuse client.

So, to conclude - absolutely support the move introduced in the PR, and see it as a very necessary thing to do. See points raised by @miroslavstastny as important ones to agree upon, and make all the necessary steps to address and overcome them to make this styles rename change happen :)

A few thoughts.  If we do this, some more renaming is likely in order.  I also want to give current thoughts on why we may not want to rename but remove the styles prop.
Style file renaming
If we rename the prop, I don't think filenames are an issue at present.  We can / should rename the files in a separate PR.
Non-public filename contracts can iterate in another PR if necessary.  They don't affect users and we can safely rename them with git mv ....  That command works best if there are no changes to the files when moving them, otherwise, git sometimes gets confused and thinks you deleted the old file and made a new one opposed to simply moving it with changes.
Context / Theme interface
This is more of a concern to me.  The user will still do:
<Provider theme={{ componentStyles: { Button: { ... } } }} />

<Button css={{ ... }} />

This seems like it should be called theme.componentCSS to align with the css prop.  However, see next point.
Discouraging style overrides
It is currently too easy to override styles, just pass a styles prop.  If we make this prop even shorter, it will only increase its appeal (however minimal the increase might be).
Overriding styles should not be part of the normal usage of Stardust, since the user should use the APIs and allow the component to correctly handle styles.  Evidence from early first usages is that the first thing the user tends to do is reach for styles to make things look right.  This destroys the hope of allow the theme to control the UI.  Any theme updates are going to conflict with whatever the user has overridden with an inline style.  Users should be pushed hard toward using the correct component with correct APIs instead of hacking styles all over the place.
Stardust style overrides might be compared to React's dangerouslySetInnerHTML prop.  Yes, in React you can pass an HTML string, however, it is extremely dangerous and you are skipping the whole point of React by doing so.  Yes, in Stardust you can pass your own CSS overrides, but you are skipping one of the main points of using Stardust by doing so.
One idea was to remove the styles prop entirely.  The user could still override styles, but they need to do so by importing the Provider and passing a new theme on context.  Reasons to consider this:

This would certainly discourage the user from overriding several styles on several components in a view.
The user would rather try to use the component APIs to achieve the goal (which is what we want).
The user would push styles overrides higher up in the tree since they need to be in a theme.  Putting them in a theme also forces you to organize them better and use theme concepts, like variables.

Feedback?

TL;DR
Would rather suggest to stay with renaming, note removing - at least as a first step (with all the necessary rename refactoring being done for that). Simple explanation is that removal is much more serious change, and while styles -> css has clear evolutionary benefit of avoiding client's confusion, removal of this prop, in contrast, is rather a contradictory decision. Personally feel strict tension against removing this prop altogether, because this move won't solve the goal it is intended for.

Stardust style overrides might be compared to React's dangerouslySetInnerHTML prop.  Yes, in React you can pass an HTML string, however, it is extremely dangerous and you are skipping the whole point of React by doing so.  Yes, in Stardust you can pass your own CSS overrides, but you are skipping one of the main points of using Stardust by doing so.

Cannot completely agree with this, and here are the reasons for that. First thing to note is that any major component library, and even Web itself (via style attribute) allows 'inline' style customizations. Stardust isn't aimed to introduce anything new, but just resembles already emerged patterns. So, here we will break this promise, and I might say for certain that this move will be generally very discouraging to the client.
was
<Button styles={...} .. />

now
// this provider is introduced just to wrap a Button
// note how many things client should know about Stardust just to simply style the Button:
// - Provider concept,
// - 'componentStyles',
// - the fact that selectors work by component display name
// - 'root'
<Provider theme={ componentStyles: { Button: { root: ... }  }} >
    <Button ... />
</Provider>

Here are few things to note

what we'll end up with is that Provider will be used for specific component only (the first thought client would have in terms of how situation with styling should be addressed), and it won't fix the problem - essentially, we will left at the same point as it was with styles props, but with much more efforts required from client to style component
the second point aims to address potential objection like 'ok, that seems to be exactly the thing we were striving for - to make it harder to the client to not use Provider'. Yes - but we are not solving the problem we would really like to solve - to direct client towards organising styles into themes with that. If there is no mental organisation of styles in client's head yet, irregardless of which tools we would suggest to style, there won't be any structure and consistency in client styles at the end. Provider will be used just as an annoying hack, and after couple of uses the very next thought of the client would be to wrap it like:

const withStyles = (Element, styles) => <Provider theme={ ... }>{Element}</Provider>

// and latter
render() {
  return withStyles(<Button ... />,  { border: ... })

After that client would left being mad on us that we haven't introduced this way for customising component styles (and had wasted her time on learning all these concepts), and will just use this shortcut everywhere in the code.

once again to reiterate previous point - theming need is something that naturally emerges in client head, and it emerges at the moment when there is clear vision on how styles should be organised. Note that this is a natural flow that is introduced by tools that are provided by Web (style attribute vs CSS styles) and any component library. If we remove this capability, I am absolutely sure that we would rather raise client's confusion and even desire to find a better component library that is not that restrictive and revolutionary in this commonly adopted aspect.

So, to conclude - I would suggest to stay with renaming, at least as a first step (with all the necessary rename refactoring being done for that). Feel strict tension against removing this prop altogether, because this move wouldn't solve the goal it is intended for.

Agree with @kuzhelov's evaluation and don't believe making it hard for developers to override styles is the right approach here. Why?

variables are great, but they by far don't cover all the permutations on how a component can be styled. If we want maximum adoption, should we not also opt for flexibility?
Moving every style override into the theme is not practical as that assumes that the change applies to all components of a type. How is a local permutation achieved that is not supported by stardust yet?

I recognize the need to have a mechanism to prioritize variables over css overrides. Maybe this can be approach through education in form of console.warn when a developer makes a change through custom styles that could be made through variables?

As newcomer I may be will have a more clear eye there.

For customising we have:

themes as files
themes as object, I know that is the same thing, but from my side it looks differently
styles

Too many options. May be I wrong, but neither emotion nor styles-components doesn't allow you to override styles dynamically with a css prop, https://codesandbox.io/s/k2mv409ox3

<Button content="Click here" styles={{ color: 'red' }} />
<Button content="Click here" style={{ color: 'red' }} />

Can someone explain me what is going in the code abowe? The renaming for styles to css doesn't solve this problem at all.
So, I have an unpopular opinion and will agree with Levi, let's drop styles at all 😈

Given that the general suggestions are to drop entirely the styles prop, let's close this PR as it will not bring much value long term.


Error setup role to manage Route53 dns01

Describe the bug:
We are looking to change our admin user to role, according with tutorial:
https://cert-manager.io/v1.2-docs/configuration/acme/dns01/route53/,
but seem like some configuration is not correct, because the sts assumerole no seems to be rights into role cert manager.
  Warning  PresentError  24s  cert-manager  Error presenting challenge: error instantiating route53 challenge solver: unable to assume role: AccessDenied: User: arn:aws:sts::123456789:assumed-role/cert-manager/123456789123 is not authorized to perform: sts:AssumeRole on resource: arn:aws:iam::123456789:role/cert-manager

Role created: cert-manager
Policy attached:
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Action": "route53:GetChange",
      "Resource": "arn:aws:route53:::change/*"
    },
    {
      "Effect": "Allow",
      "Action": [
        "route53:ChangeResourceRecordSets",
        "route53:ListResourceRecordSets"
      ],
      "Resource": "arn:aws:route53:::hostedzone/*"
    },
    {
      "Effect": "Allow",
      "Action": "route53:ListHostedZonesByName",
      "Resource": "*"
    }
  ]
}

IRSA attached to role:
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Action": "sts:AssumeRoleWithWebIdentity",
      "Principal": {
        "Federated": "arn:aws:iam::123456789:oidc-provider/oidc.region-aws.amazonaws.com/id/123456789123456789"
      },
      "Condition": {
        "StringEquals": {
          "oidc.eks.region-aws.amazonaws.com/id/123456789123456789:sub": "system:serviceaccount:cert-manager:cert-manager"
        }
      }
    }
  ]
}

Add role to clusterissuer:
    solvers:
    - dns01:
        route53:
          region: region-aws
          role: arn:aws:iam::123456789:role/cert-manager

Add role to serviceaccount:
apiVersion: v1
kind: ServiceAccount
metadata:
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam::123456789:role/cert-manager

Expected behaviour:
Should be validate new certificate when add new ingress with the secret specified.
Steps to reproduce the bug:
Install cert manager 1.2, configure the above conf added into this post, adding a single certificate with secret specify to auto create certificate managed.
Anything else we need to know?:
Environment details::

Kubernetes version: 1.17
Cloud-provider/provisioner: AWS
cert-manager version:  1.2.0
Install method: e.g. helm/static manifests: static manifest

kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/<version>/cert-manager.yaml

/kind bug

Hi all,
have the same issue
any ETA on this bug ?
thanks!

seems IAM role should be absent in ClusterIssuer solver if IAM role is already attached to controller by IRSA:
    solvers:
    - dns01:
        route53:
          region: region-aws
          # that's enough!

@viatcheslavmogilevsky thanks for the tip! This should definitely be added to the docs, could simplify this page quite a bit: https://cert-manager.io/docs/configuration/acme/dns01/route53

@viatcheslavmogilevsky thanks for the suggestion. That change helped! It should definitely be documented

Thanks @mamachanko for your PR updating the documentation. I left some comments:

https://github.com/cert-manager/website/pull/1487#discussion_r1728607715

I don't know much about AWS and IRSA....can you explain (in the documentation note) why the role does not need to be supplied in this case.
The documentation for the Go Web SDK suggests that RoleARN is required

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/credentials/stscreds#AssumeRoleOptions
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/credentials/stscreds#WebIdentityRoleOptions

I'm interested to understand this because I'm currently working on the following update to the Route53 solver code in cert-manager:

WIP: Allow STS token to be refreshed by the AWS client if necessary cert-manager#7236

Please review the following documentation PR and feedback:

https://github.com/cert-manager/website/pull/1555


Attaching a zip file to the report

🤔 What's the problem you're trying to solve?
Attaching a zip file to the html report in Java.
I have tried several media types but always get an error:

Couldn't display application/octet-stream attachment because the media type is unsupported. Please submit a feature request at https://github.com/cucumber/cucumber/issues
Couldn't display .zip  attachment because the media type is unsupported. Please submit a feature request at https://github.com/cucumber/cucumber/issues
Couldn't display application/x-zip attachment because the media type is unsupported. Please submit a feature request at https://github.com/cucumber/cucumber/issues
Couldn't display application/x-zip-compressed attachment because the media type is unsupported. Please submit a feature request at https://github.com/cucumber/cucumber/issues

✨ What's your proposed solution?
Handle the media type "application/zip" in the Java method Scenario#attach.

⛏ Have you considered any alternatives or workarounds?
No.
📚 Any additional context?
My zip file contains a csv file

This text was originally generated from a template, then edited by hand. You can modify the template here.

Which Cucumber and Html formatter version are you using? This was implemented https://github.com/cucumber/react-components/pull/333.


Gradle 1.0.0

I can't compile project with Gradle 1.0.0. Help please with this issue.

the same issue
error message from android studio 1.3
" This project does not use the Gradle build system. We recommend that you migrate to using the Gradle build system. "


Cache failed model resolutions in the Request-Scoped resource model cache

The request-scoped resource model cache is currently used to cache the results of successful resource - to - model adaptations, i.e. adaptation that did not yield null.
However, if there are a lot of adaptations that yield no model instance, e.g.  in cases where resources are adapted to some model types by default, it would be desirable to also cache null adaptation results to increase performance by reducing the number of cache lookups in the resource model registry.

Implemented, done!


"Podu Cristinii", "Românești", "Vlăsceni" are listed in the drop-down menu

Description:
When user writes ”Podu Cristinii”, "Românești" and "Vlăsceni" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Podu Cristinii"

Expected results
The location appears in the drop-down menu as "Sat Podu Cristinii, DÂMBOVIȚA (Potlogi)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Românești"

Expected results
The location appears in the drop-down menu as "Sat Românești, DÂMBOVIȚA (Potlogi)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Vlăsceni"

Expected results
The location appears in the drop-down menu as "Sat Vlăsceni, DÂMBOVIȚA (Potlogi)".


text-zipper-0.10 test suite failure

I'm citing from https://hydra.nixos.org/build/60677565/nixlog/1:
Running 1 test suites...
Test suite text-zipper-tests: RUNNING...

Words
  moveWordLeft
    does nothing at the start of the text
    moves from middle of the word to the start
    moves from end to beginning
    stops at beginning of line if word boundary
    moves across lines from beginning of line
    skips multiple space characters
    skips multiple space characters across lines
    always lands on the start of a word
  moveWordRight
    does nothing at the end of the text
    moves from middle of the word to its end
    moves from beginning to end
    stops at end of line if word boundary
    moves across lines from end of line
    skips multiple space characters
    skips multiple space characters across lines
    always lands at the end of a word FAILED [1]
  deletePrevWord
    does the same cursor movement as moveWordLeft
    has the same prefix than moveWordLeft
    has the same suffix than before
  deleteWord
    does no cursor movement
    has the same prefix than before
    has the same suffix than moveWordRight

Failures:

  tests/WordsSpec.hs:74:
  1) Words.moveWordRight always lands at the end of a word
       Falsifiable (after 4 tests and 5 shrinks):
       ["\r"]
       (0,0)
       TextZipper { above = [], below = [], toLeft = "\r", toRight = "" }

Randomized with seed<PHONE_NUMBER>

Finished in 0.5627 seconds
22 examples, 1 failure
Test suite text-zipper-tests: FAIL

Thanks!


yarn package not working

Rollup is failing. Looks like a missing config file? Help / pointers would be most appreciated.
yarn run v1.22.5
$ rollup -c
[!] Error: Could not resolve entry module (rollup.config.js).
Error: Could not resolve entry module (rollup.config.js).
    at error (/home/jim/projects/onlinewardleymaps/node_modules/rollup/dist/shared/rollup.js:5251:30)
    at ModuleLoader.loadEntryModule (/home/jim/projects/onlinewardleymaps/node_modules/rollup/dist/shared/rollup.js:18410:20)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at Function.Module.runMain (internal/modules/cjs/loader.js:834:11)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:623:3)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Hi Jim. Try running Yarn in the wmlandscape folder. I did some work recently to make the core of OWM available as a package for viscose-wardley-maps. Roll up was used to help with this.

Great, that works to create dist/index.js in the wmlandscape folder. How do I get that into the vscode-wardley-maps project? And how can I get my vscode working with my local build of the extension, please?

If you remove the wmlandscape package from vscode-wardley-maps and then re-add as a package but with a relative path to your local copy of OWM/wmlandscape that should drag your local changes in.

How do I get that into the vscode-wardley-maps project?

When a pull request gets merged into this repository a new version of wmlandscape will be published to NPM. It's then a case of incrementing the package version in vscode-wardley-maps and publishing a new build of the extension

Thanks, Damon!

Reopening this in case you want to edit README.md or improve the build file - I don't have any familiarity with yarn to know what the right solution is.

Info added to readme.
https://github.com/damonsk/onlinewardleymaps/blob/0ca27312b8f592cfa2582dcd1b8d28e92f4ad6c4/README.md?plain=1#L41


error!!

PLEASE READ THE POSTING GUIDELINES AND ANSWER THE QUESTION BEFORE POSTING, OTHERWISE ISSUE WILL BE CLOSED AND MARKED AS INVALID

I hereby declare the following issue is a [tool specific question/bug report] and it is NOT a help request about creating a phishlet.
I am fully aware that this is not a customer support portal, I can't demand answers and I'm aware I am using a free tool.
I am not going to use Evilginx to hax my girlfriend's account or use it for any other illegal purpose.
I am not trying to set up a domain on FreeNOM (also read the sentence above again).
I am not a robot.

Please type in "I CONFIRM" below if you confirm the sentences above or otherwise make some funny remark:

Thanks!
Hello,
i encountered this error several times while installing evilginx.
acme: Error 403 - urn:acme:error:unauthorized - Account creation on ACMEv1 is disabled. Please upgrade your ACME client to a version that supports ACMEv2 / RFC 8555. See https://community.letsencrypt.org/t/end-of-life-plan-for-acmev1/88430 for details.

PLEASE READ THE POSTING GUIDELINES AND ANSWER THE QUESTION BEFORE POSTING, OTHERWISE ISSUE WILL BE CLOSED AND MARKED AS INVALID

I hereby declare the following issue is a [tool specific question/bug report] and it is NOT a help request about creating a phishlet.
I am fully aware that this is not a customer support portal, I can't demand answers and I'm aware I am using a free tool.
I am not going to use Evilginx to hax my girlfriend's account or use it for any other illegal purpose.
I am not trying to set up a domain on FreeNOM (also read the sentence above again).
I am not a robot.

Please type in "I CONFIRM" below if you confirm the sentences above or otherwise make some funny remark:
__
Thanks!
Hello,
i encountered this error several times while installing evilginx.
acme: Error 403 - urn:acme:error:unauthorized - Account creation on ACMEv1 is disabled. Please upgrade your ACME client to a version that supports ACMEv2 / RFC 8555. See https://community.letsencrypt.org/t/end-of-life-plan-for-acmev1/88430 for details.

i can help you with the<EMAIL_ADDRESS>


Create graphql schema file on first artisan call

If the file does not exist, an error message is displayed.
ErrorException

  file_get_contents(/path/to/installation/schema.graphql): failed to open stream: No such file or directory

  at vendor/pwweb/artomator/src/Generators/GraphQL/GraphQLQueryGenerator.php:35
     31▕     public function __construct(CommandData $commandData)
     32▕     {
     33▕         $this->commandData = $commandData;
     34▕         $this->fileName = $commandData->config->pathGraphQL;
  ➜  35▕         $this->fileContents = file_get_contents($this->fileName);
     36▕         $this->templateData = get_artomator_template('graphql.query');
     37▕         $this->templateData = fill_template($this->commandData->dynamicVars, $this->templateData);
     38▕     }
     39▕

      +16 vendor frames
  17  artisan:37
      Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

Should be easy enough to check for the file existing. Question is whether a simple blank file is enough or whether the lighthouse commands need to be run instead. May be possible to use a ->call() to run the lighthouse artisan command needed?


Push chunk override from map_blocks into blockwise

Instead of calling dask.array.blockwise and then fiddling with the
chunks under the hood, pass the new chunking scheme into blockwise.
The verification that the number of blocks didn't change is now made
inside blockwise, so it will be a bit more robust.
To make that verification work I also improved the code inside blockwise
that estimates the chunks up front (in the adjust_chunks=False case, as
used by map_blocks). Previously it made the arbitrary choice of taking
the input with the most indices. When there is broadcasting, that can
get the wrong number of blocks (which is what lead to bugs to
like #4299). It now, per dimension, takes the chunk scheme with the most
blocks. Note that this might alter the behaviour in cases where the
chunking schemes are inconsistent and no explicit chunking scheme is
provided, but I believe the behaviour was undefined to start with.
A benefit of this change is that it's now possible to detect cases where
the user-provided chunks have more than one element and there should
only be more than one element (previously the check was skipped because
broadcasting wasn't correctly handled, as a workaround for #4299).

[ ] Tests added / passed
[ ] Passes black dask / flake8 dask

@TomAugspurger I think you've probably looked at some of this before for #4299 - do you think you could review it?

Just to confirm, we have tests for the ValueError being raised in blockwise, since it would have previously been tested to raise in map_blocks?

I believe that's the case. From what I can tell, blockwise with align_arrays=False is undocumented, only used by map_blocks, and not directly tested, which is why I didn't feel the need to test this directly through blockwise.

Thanks @bmerry !  This is in.


Letter Č not rendered on Android, only a box visible.

This is what I'm expecting:

This is what actually happens:

Notice the last column in the first row, it should say "KOLIČINA", not "KOLI□INA".
On Samsung API 28 and on Xiaomi API 30 it works just fine, but on another Xiaomi API 29 this box is displayed.

Logs

[✓] Flutter (Channel master, 2.1.0-11.0.pre.149, on Linux, locale en_US.UTF-8)
    • Flutter version 2.1.0-11.0.pre.149 at /home/user/Development/flutter
    • Framework revision 1c7f038dbb (6 days ago), 2021-03-09 02:14:04 +0530
    • Engine revision f751d04fa0
    • Dart version 2.13.0 (build 2.13.0-107.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/user/Android/Sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /home/user/Development/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /home/user/Documents/android-studio
    • Flutter plugin version 44.0.1
    • Dart plugin version 191.8593
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Android Studio (version 4.1)
    • Android Studio at /home/user/Development/android-studio
    • Flutter plugin version 51.0.2
    • Dart plugin version 201.9002
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.53.2)
    • VS Code at /usr/share/code
    • Flutter extension version 3.20.0

[✓] Connected device (2 available)
    • M2006C3LVG (mobile) • BA6H5LVWDAROW4V4 • android-arm    • Android 10 (API 29)
    • Chrome (web)        • chrome           • web-javascript • Google Chrome 88.0.4324.182

• No issues found!

@ljmatan
Please provide a complete minimal reproducible code sample that shows this issue.
Thanks.

Sorry! Forgot to do so.
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: ErrorExample(),
    );
  }
}

class ErrorExample extends StatelessWidget {
  static final Set<String> _columnLabels = const {
    'ŠIFRA',
    'NAZIV ARTIKLA',
    'J.M.',
    'KOLIČINA'
  };

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Table(
          border: TableBorder.all(
            color: Colors.black45,
            width: 1 / 3,
          ),
          columnWidths: {
            0: FractionColumnWidth(.125),
            1: FractionColumnWidth(.55),
            2: FractionColumnWidth(.125),
            3: FractionColumnWidth(.2),
          },
          children: [
            TableRow(
              children: [
                for (var label in _columnLabels)
                  TableCell(
                    verticalAlignment: TableCellVerticalAlignment.middle,
                    child: Padding(
                      padding: const EdgeInsets.symmetric(vertical: 3),
                      child: Text(
                        label,
                        textAlign: TextAlign.center,
                        style: const TextStyle(
                          fontWeight: FontWeight.w600,
                          fontSize: 11,
                        ),
                      ),
                    ),
                  ),
              ],
            ),
          ],
        ),
      ),
    );
  }
}

@ljmatan
Can you also confirm if this also occurs on web as well using canvaskit ?

Running with flutter run -d chrome --web-renderer canvaskit, the same issue is not present.

I am unable to replicate this issue on the devices tried:

Samsung 8.1.0 (api 27)
Samsung S10 (api 30)
Redmi 5 Plus (api 27)

flutter doctor -v
[✓] Flutter (Channel master, 2.1.0-13.0.pre.160, on macOS 11.2.3 20D91 darwin-x64, locale en-AO)
    • Flutter version 2.1.0-13.0.pre.160 at /Users/pedromassango/Code/flutter_master
    • Framework revision f4e5354580 (31 minutes ago), 2021-03-18 06:21:01 -0400
    • Engine revision 38c4dac68b
    • Dart version 2.13.0 (build 2.13.0-148.0.dev)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/pedromassango/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.
[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.
[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      :hammer: https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      :hammer: https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[✓] IntelliJ IDEA Community Edition (version 2020.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 54.0.3
    • Dart plugin version 203.7759
[✓] VS Code (version 1.54.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0
[✓] Connected device (4 available)
    • Redmi 5 Plus (mobile)      • 0258ff700005  • android-arm64  • Android 8.1.0 (API 27)
    • sdk gphone x86 64 (mobile) • emulator-5554 • android-x64    • Android 11 (API 30) (emulator)
    • macOS (desktop)            • macos         • darwin-x64     • macOS 11.2.3 20D91 darwin-x64
    • Chrome (web)               • chrome        • web-javascript • Google Chrome 89.0.4389.90
! Doctor found issues in 1 category.

Keeping this issue open for further investigation, as it seems to be device + os specific.

I assume this is a font issue. The font used in testing doesn't correspond to the original screenshot. And in that original screenshot I believe there is Č missing as well, but substituted by character taken from some default font. If you look carefully, you can see slightly greater font weight, but more obviously the shape of Č is different form O, but these characters are similarly rounded in rows below.

@jan-tosovsky-cz I think you may actually be right, in the first screenshot the font is replaced with the standard one it seems at this letter. It is however not working as intended it seems on Xiaomi API 29.


1.83 update

The main update is the fact that the project is no longer using a virtual workspace to build the standard library.
I still need to confirm if such a thing is responsible for surpassing the old git patch warnings.

IFAICT, the introduction of https://github.com/rust-lang/rust/pull/128534 and https://github.com/rust-lang/cargo/pull/14358 makes the injection of the in-house compiler-builtins unnecessary in cargo. It should then be only a matter of directly adding compiler-builtins = { git = 'https://github.com/solana-labs/compiler-builtins' } in the standard library.
@LucasSte cargo, compiler-builtins and rust are all projects I have worked before, as such, cherry-picking was relatively easy. On the other hand, I never touched the LLVM project so synchronization is like walking in a dark room with a tiny candle.
I will stop at the current number of repositories because it would take too much time to tackle LLVM. Let me know if everything else is OK.


Uninstall Windows Defender on Windows 10 with powershell command throws command not found.

Operating System Version: Windows 10
Provider (VirtualBox/VMWare): VirtualBox
Vagrant Version: 2.1.4
Packer Version: 1.2.5
Is the issue reproducible or intermittent?
reproducible

Description of the issue:
I building Windows 10 Image with packer and see this
virtualbox-iso: Uninstall-WindowsFeature : The term 'Uninstall-WindowsFeature' is not recognized as the name of a cmdlet, function,
virtualbox-iso: script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is
virtualbox-iso: correct and try again.
virtualbox-iso: At C:\Windows\Temp\script-5b8c0576-1fa9-8084-8c97-01482396904d.ps1:19 char:3
virtualbox-iso: +   Uninstall-WindowsFeature Windows-Defender-Features
virtualbox-iso: +   ~~~~~~~~~~~~~~~~~~~~~~~~
virtualbox-iso:     + CategoryInfo          : ObjectNotFound: (Uninstall-WindowsFeature:String) [], CommandNotFoundException
virtualbox-iso:     + FullyQualifiedErrorId : CommandNotFoundException

Uninstall-WindowsFeature is a Powershell cmdlet from Windows Server, but it is not exist on Windows 10.
I suggest we must use
Set-MpPreference -DisableRealtimeMonitoring $true
to disable Windows defender on Windows 10
This is only one thing i found in powershell commands to disable defender.
I suggest we must use Group policy settings, regedit commands to disable all Windows Defender related configs and stop and disable all Windows Defender related services.
Another option, that i see is to use Freeware Third-party utility called Defender Control v1.3
https://www.sordum.org/9480/defender-control-v1-3/
direct link: https://www.sordum.org/files/small-tools/DefenderControl.zip
Unzip it and start  "DefenderControl.exe /d"  from admin cmd.

This is not too big of a deal because Windows-Defender gets properly disabled during install-utilities.ps1: https://github.com/clong/DetectionLab/blob/master/Vagrant/scripts/install-utilities.ps1#L19-L29
However, I agree that it would be cleaner to do this correctly in the Packer build. It just needs a switch based on the host operating system. I'll open a PR for this, unless you want to take a stab at it.

Fixed in #149 in the Packer build scripts


How i can restore combo png like golden apple

Describe your problem here.
so, im making a gapple port or smth  (i dont know really) but im trying to get combo Sprite like golden apple,
so i cant do it.....
can someone help me?

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no. i didnt

place this on the mods/<yourmod>/scripts folder with the name restoreComboSprite.lua
setProperty("showCombo", true)

place this on the mods/<yourmod>/scripts folder with the name restoreComboSprite.lua
setProperty("showCombo", true)

Bro

Are you modding a build from source or with lua?
Source

find showCombo in PlayState and enable it

thx for it! but its not like that

In popUpScore(), change this line insert(members.indexOf(strumLineNotes), rating), to this:
insert(members.indexOf(strumLineNotes), rating);
insert(members.indexOf(strumLineNotes), comboSpr);

im on experimental bracnh

im on experimental bracnh

Find comboGroup.add(rating) and change it to:
comboGroup.add(rating);
comboGroup.add(comboSpr);

didnt work,

didnt work,

How so? And send your popUpScore PlayState function here so I can help you

so i need to send playstate.hx?

so i need to send playstate.hx?

No, only the popUpScore function

how

how

You see, the internet has this cool thing called "✨ COPY and PASTE ✨"
So, just paste the function code inside a code block like this
function popUpScore()
{
    // da code
}

What's the code in your popUpScore in PlayState @matepro260 ?


SB Release PRs need to target release branch during RC and GA phase

During the RC/GA timeframe, a release branch is created in the installer repo (e.g. release/8.0.1xx). All updates for that version of .NET should be targeting that branch. For the 8.0 RC 1 release, the generated PR for updating source-build config ended up targeting the main branch. This is because the release was marked as a preview release when queuing the build.
Marking a release as preview has the following effect in the release pipeline:

Updates the reference URL for the release notes to include preview in the path
Parses out the build number for display purposes
Targets the main branch for the generated PR

It's the last item that is problematic here for RC/GA releases.

@mthalman I'm guessing we can't just mark RC as a non-preview release, right?

@mthalman I'm guessing we can't just mark RC as a non-preview release, right?

In my original post I point out the implications of not marking it as a preview. The effects of doing that are not what we want.

Oh, my bad, I miss-understood you
We could just look at the type of the release in the PR logic and if its isPreviewRelease but the releaseName or some other paramater contains RC or GA switch back to the other flow

PR - https://dev.azure.com/dnceng/internal/_git/dotnet-release/pullrequest/37641

PR merged, the pipeline should now target the release branch for RC releases


[Feature]: allow resetting a users API-key

Describe the feature
A user should be able to reset their api-key, this is important functionality to have in case users leak their key. This should generate a new api-key and persist it in the users table.
Questions

A JWT will be cached with the api-key or a cookie sid as the key for 10 minutes, should we also clear this? Can we?
Should this only be possible through the console?

Tasks
[] Add a new reset endpoint to auth
[] Update gateway to forward reset requests to auth
[] Clean the cache in gateway
[] Add a subcommand to the cli
Suggestion or Example of how the feature would be used
No response
Duplicate declaration

[X] I have searched the issues and this feature has not been requested before.

Shuttle Batch 2.0 project https://shuttle-hq.notion.site/535743328783490baacd6fbb7befdd5d?v=f0988ae59d8f47e788bed373047a4255&p=916eeba051f74a07a27f20efb8711bc8&pm=s.
Picked by @jonaro00 and @hseeberger.

Looking at the code it seems to me that there is only one API key per user. Is that correct?

Yes, that is correct. :+1:

I saw a suggestion to allow users to have more than one key, but we can wait with that until later if deemed appropriate.


Preset: add "requireSpaceBetweenArguments" rule to all presets

Also corrects link to yandex code-style
Fixes #940

Coverage remained the same at 98.9% when pulling 73a0d64bddde46f6e01d6ab201bc4d1614703b43 on markelog:940 into b4532e38d2d6b7440ba89266e0f9751744956614 on jscs-dev:master.

LGTM

+1, though I hope the test data for each preset already has an instance where this rule is used.

@mrjoelkemp good point, added

Coverage remained the same at 98.9% when pulling bb0cb142422c063cdb5b62ac6fa55fd864a31bd5 on markelog:940 into 8ddbd46c893c2b86d30a738dd6f19386d4be2e31 on jscs-dev:master.

I'll land this.


feat: Add Mode & Mode Sepolia

Motivation
Newly launched Mode Network is not currently supported in ethers-rs
Solution
Adds support for Mode Network's Mainnet & Testnet (https://docs.mode.network)
Also adds Mode Mainnet support for Multicall3.
PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

squashed a commit to remove trailing slashes in the explorer URLs


lightgrey color in build [scrutinizer] badge for unknown status

Badge before:

Badge after:

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @Jowitam!

  Generated by :no_entry_sign: dangerJS

Thanks for the PRs you've submitted over the last few days :)


Credentials support?

On client-side we can deal with cookies specifying credentials option.
https://fetch.spec.whatwg.org/#concept-request-credentials-mode
But, have any idea about cookies on server-side (node-fetch)?

You should add them manually as headers. You can in fact use the same code for server and for client, because on client the Cookie headers are ignored and credentials: 'include' works instead.
fetch('/', {
  credentials: 'include',
  headers: {'Cookie': 'foo=bar;bar=foo'}
})

@XeeD not great, but works.
Thanks!

Hi, I'm having an issue where cookies that are set in between redirects are not persisted. With the request module, this is handled much more cleanly, but I would love to use the fetch spec if I can. In the browser it works perfectly fine, but since node-fetch requires cookies to be handled manually it doesn't perform the same as on the browser, and breaks in my case.

@coverslide this question finally comes, the short answer is: node-fetch doesn't have a concept of cookies at the moment. If you are facing a POST then redirect then GET request, it breaks.
Any library (request for example) implementing such support use custom cookie store, which is not trivial in server-side context.

closing this issue as the main problem has a workaround.
(added coverslide's suggestion to #8, it's something we would like to provide a workaround, possibly by implementing redirect header extraction)

I agree with @lillem4n, this issue is far from being solved.
I cannot set cookies through HTTP, and then later on use them in fetch requests that require these cookies.
This is regardless of whether the credentials header is set or not.

@lillem4n @itskibo Reopening this, as it is indeed still an issue.

Same problem here, works greet with regular fetch but not with node-fetch and not with axios either sadly

Same problem here, works greet with regular fetch but not with node-fetch and not with axios either sadly


API documentation is not yet published

I see the documentation states the API docs are not yet published.  Is this module not yet complete?  Any idea when it will be considered ready for consumption?
Thanks -
John

Fixed this in the README.  Docs are here:

NodeJS<EMAIL_ADDRESS>Python: Coming soon!
Go: https://godoc.org/github.com/pulumi/pulumi-vsphere/sdk/go/vsphere


No results message for index tables

Originally created by Tom Smyth at 2015-08-23 02:59, migrated from redmine-#2938

Priority changed from 4 to 3

By Tom Smyth at 2015-08-23 07:00

Priority changed from 3 to 2

By Tom Smyth at 2015-08-27 18:10

Status changed from New to Closed

By Tom Smyth at 2015-08-30 01:44


Features & Bug fixes

Introduced Caching for Roles / Channels / Bot Accounts per Guild
Introduced a Scoped Cache which allows easier access to the cached data
Replaced Default Remora's CommandResponder and InteractionResponder with a custom one
Added the ability to return the error messages directly to the user from IResult
Added the ability of blocking commands until initialization is being complete
Introduced DiscordPermissionHelper.cs for easier accessing and computing Effective Permissions
Added DateTime & DateTimeOffset on DiscordFormatter.cs
Fixed #10
Changed UserReminder.cs DateTimes to DateTimeOffsets for consistency
Added on UserHiddenChannel.cs the CreatedAt date
Added the ability to manually un-hide channels that were hidden through a Category

i Replaced the default Command Responder and Interaction responder for 2 main reasons.
The first is to be able to not process commands while bot is initializing i.e caching data on startup.
and the second reason to properly handle Error IResults.

What's the purpose behind the scoped cache? I assume you just need a cache to use during a scope? But then it seems to only be reliant on the underlying singleton?

It's only for easier accessibility for the cached entries of the guild the command triggered for. It can be used only with CommandContext, and it lets you omit entirely the guildid on the request. However because it extends from the DiscordCache, it gives you the ability to search for other guilds as well.
for example you want to take the GuildMember of the current user instead of doing
_discordCache.GetGuildMember(_commandContext.GuildID.Value.Value, _commandContext.User.ID.Value);

you can simple use
_discordCache.GetInvokingGuildMember();

which is less verbose.


--stride Mode

Can you bring a feature to skip the search?
--stride

Yes i can, but it will take some time.

How do I use --stride? It does not work for me :(

How do I use --stride? It does not work for me :(

This feature has not arrived yet.


Permission denied to git user on the docker image.

Hello Folks,
I'm having the same issues described in the https://github.com/gogits/gogs/issues/3029 closed issue, but in my case I'm using the docker image on a docker swarm mode cluster. To fix the issue, normally I run the following command:
docker exec -u root $(docker ps -q --filter ancestor=gogs/gogs) chown -R git:git /app
But when the containers are scaled to another nodes (or recreated with newest versions) I need to run the same command (fortunately my Ansible is working hard for that) again on each node that have gogs started.
Informations about my environment:
Gogs Image: Latest (2017 Gogs Version: <IP_ADDRESS>5, Go 1.8)
Docker 13.0.1/17.03-ce
Operating Systems: CoreOS stable, CentOS 7
Database: PostgreSQL
This is the output for the command  'docker service logs gogs_gogs':
https://gist.github.com/gcavalcante8808/7878776e3583567049aeca2d072b3a2b
I think that a RUN instruction creating the folder 'data' inside the '/app' or giving the ownership of the folder to user git will fix the problem (or using the acl to give the access).
Thanks in Advance.

Hi, are you using the official Gogs image? If yes, it is created https://github.com/gogits/gogs/blob/master/docker/start.sh#L34. Deployment issue goes to user forum.


Use direction from velocity in NodeListManager

The NodeListManager currently calculates direction from indices; it should use the one computed by velocity in the CalView.

Done


python networking docs added

Related Issue
Fixed : #636
Description

i have added Python Networking section added

i have added category.json accordingly for it
i added table in this section as needed to make user more readable

i added note for issue to keep in mind for particular topic

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / Videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist

[x] I have performed a self-review of my code.
[x] I have read and followed the Contribution Guidelines.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional Context
[Include any additional information or context that might be helpful for reviewers.]
Resources for Guidance
Here are some resources that may be helpful as you contribute to CodeHarborHub:

Code Harbor Hub Community Features
Docusaurus Documentation
React.js Documentation
Markdown Guide
MDX Documentation
Mermaid Documentation

Resources for DSA Features on Our Site:

Tabs: Switch Languages
Line Numbering
Math Equations

hey @Ajay-Dhangar , i have table and note like stuff to make it professional as you suggest.
after review it if you want please make it level 3.

hey @Ajay-Dhangar , i have table and note like stuff to make it professional as you suggest. after review it if you want please make it level 3.

hey @Ajay-Dhangar , please answer


feat: dtis 53 using biometrics

Description
In this pull request PR we introduce the setup and verification of biometric authentication for logging into the wallet. We have utilized the @aparajita/capacitor-biometric-auth library for this purpose.
Biometric Authentication Requirements:
Biometric authentication will only be enabled if the device supports a strong level of authentication; this means FaceID or TouchID for iOS, and fingerprint authentication for Android. Devices not meeting these criteria will not utilize biometric options during the security setup process on the SetPasscode page.
Setup Process:
The biometric setup is integrated during the onboarding phase on the SetPasscode screen, right after the user successfully enters and confirms a 6-digit passcode. If the biometric setup process is canceled, an alert message will inform the user can configure biometric settings later in the settings page.
Settings Page Options:
A new option has been added to the settings page to enable or disable biometric security. Once enabled, the Login/Lock page will automatically initiate the biometric verification process if strong biometric authentication is available.
New Hook: useBiometricAuth
We have introduced a new hook, useBiometricAuth, which can be used in any component of the app. This hook implements the handleBiometricAuth method, which returns true if verification is successful, false if not, or an error if something goes wrong during the verification process, such as user cancellation. In such a case, the user will be need to enter the passcode to login.
Checklist before requesting a review
Issue ticket number and link

[x] This PR has a valid ticket number or issue: DTIS-53

Testing & Validation

[x] This PR has been tested/validated in IOS, Android and browser.
[x] The code has been tested locally with test coverage match expectations.
[x] Added new Unit/Component testing (if relevant).

Security

[x] No secrets are being committed (i.e. credentials, PII)
[x] This PR does not have any significant security implications

Code Review

[x] There is no unused functionality or blocks of commented out code (otherwise, please explain below)
[x] In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

[x] If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
[x] In case PR contains changes to the UI, add some screenshots to notice the differences

Routes issue
We have identified a bug in the management of the onboarding routing. Currently, if a user opts not to create a password, closes the app, and then reopens it, the password creation screen reappears after unlocking the app. This issue disrupts the intended user experience and needs to be addressed.
This bug will be fixed in the next PR by checking and correcting the flags that drive the onboarding routing logic. It is essential to ensure that the user's initial choices are respected and persisted across sessions to prevent recurring screens that have already been declined.
Additional Note: Unrelated Test Failure in App.tsx
One of the tests in App.tsx is currently failing, though it is unrelated to the changes introduced in this PR. The test titled "Force status bar style is dark mode on iOS" is not executing as expected. The failure stems from an incomplete mocking of the getPlatforms method, which is supposed to simulate an iOS device environment.
This fix should be implemented separately from the current PR to maintain focus on each set of changes, it will be skiped in this PR.
IOS
https://github.com/cardano-foundation/cf-identity-wallet/assets/9588549/c3b0fc1a-a0ca-4fab-8fa7-9ce7d89ce047
https://github.com/cardano-foundation/cf-identity-wallet/assets/9588549/04f5fba4-4818-4d76-9cc4-27bc4114b5e0
https://github.com/cardano-foundation/cf-identity-wallet/assets/9588549/b36f5d6a-c086-48b8-b9d4-886ce6330818
https://github.com/cardano-foundation/cf-identity-wallet/assets/9588549/e646fea0-dffa-4825-90f5-38e079b9f2a9
Android
https://github.com/cardano-foundation/cf-identity-wallet/assets/9588549/6eb860a8-4d81-4002-97ee-f8c8d4e0327b
https://github.com/cardano-foundation/cf-identity-wallet/assets/9588549/a84a5ce3-153c-44b5-a2c0-25856803e92e
Settings page

I have observed that the biometrics authentication process initiates too quickly upon starting the app, leading to it overlapping with the splash screen. This results in a cluttered user experience as the splash screen has not fully disappeared before the biometric prompt appears.
To enhance the user experience, we recommend handling the splash screen's visibility manually. By doing so, we can ensure that the splash screen is completely hidden before the biometric authentication begins. This can be efficiently managed by introducing a flag within Redux to control the timing of the biometric process activation.
https://github.com/cardano-foundation/cf-identity-wallet/assets/9588549/b5395eb3-bdb7-465f-9521-807b6928e249

In some videos in the description, after log in the native biometrics screen is still on the screen quite a while after switching to the next screen post login. Is this an emulator thing or something we need to look at?