brew style --fix

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Fixing master with brew style --fix

Review period skipped due to critical label.

Thanks @dduugg!

Sorry if this was my fault!

I made Ubuntu 18.04 not required, since GitHub's having a brownout of those deprecated runners now: https://machomebrew.slack.com/archives/CTHMNNM7H/p1678137681762709.


Fix the bug that when no service account is specified in annotation, empty service accounts are returned.

NONE

@wattli PTAL. Thanks!

what's the desired behavior when there is no annotation ? which service account is used?
cc @costinm we were just talking about this

@ldemailly @costinm
The annotation is to mark the service accounts that run the service on VMs. Note that the service can be run by Kubernetes pods, in which case the pods' service accounts do not need to be annotated (since this info can be retrieved from apiserver).
So if the annotation is empty, the service may still be run by the K8s pods. And the secure naming info is a mapping from the service to the pods' service accounts.

Sorry for the late response, good work, thanks!


Elaborate to the monitors (Healthchecks and Uptime Kuma) when IP detection fails

@JvdMaat Hi, let's start a new issue to fix the bug. As mentioned earlier, I am curious about whether Uptime Kuma will retain "OK" after pining a push monitor with the following sequence:

https://uptimekuma.mydomain.com:3002/api/push/abcdefg?status=up&msg=OK&ping=
https://uptimekuma.mydomain.com:3002/api/push/abcdefg?status=down&msg=&ping=

I forgot to say thank you for your reporting. :grin:

Line 1 brings the monitor up the second I click on it.
Line 2 brings it down the second I click on it.
But the Message in UptimeKuma is "OK" in both instances.
I then tried this: (To get ahead of where I think you're going)
https://uptimekuma.mydomain.com:3002/api/push/abcdefg?status=down&msg=IPv6Failed&ping=
Which brought the monitor down, and the Message was IPv6Failed.
I then did: https://uptimekuma.mydomain.com:3002/api/push/abcdefg?status=up&msg=IPv6Failed&ping=
Which brought it back up, but with the IPv6Failed message.

And regarding your IPv6 comment. I officially have IPv6 on my router. I had it on my main network as well, but I think I ended up turning it off as it was causing issues. Due to a router limitation I could only DHCP my IPv6 range to my main subnet, and I couldn't get it on the IoT network, or the tenant's network. (And my docker host is on the IoT network).
So personally I just ignored the IPv6 error that way if I ever get IPv6 working internally, it'll work automagically.
But I see where you're coming from that it is an error (though not fatal, as IPv4 DDNS does get updated).
So maybe have the msg be something like:
https://uptimekuma.mydomain.com:3002/api/push/abcdefg?status=up&msg=IPv6 configured but not detected&ping=
or
https://uptimekuma.mydomain.com:3002/api/push/abcdefg?status=down&msg=IPv6 failed. Update DOMAINS environment variable to IP4_DOMAINS&ping=
(To be honest, I just did a thorough search of your README, and I couldn't find a way to disable IPv6 except to update DOMAINS environment variable to IP4_DOMAINS. And it doesn't say anywhere it should be disabled if not available. So you'll find that 95% of your userbase likely has IPv6 enabled in CFDDNS, but not actually available on their network (or not configured to work with CFDDNS correctly)).
Also, I just tested those two lines, and they work with spaces and all.
And I also found out that if the status is down, and you send a new status=down push with a different message, that will show up in the logs. (I am assuming the same holds true for an up state with a new msg, but did not test)

And last comment (for now). I did just update my docker compose to IP4_DOMAINS, and lo and behold, Uptime Kuma now says CFDDNS is up.
(So to your credit, CFDDNS is working with UK as long as there's no errors ;) )

@JvdMaat I will think about how to improve README, but FYI, you can do IP6_PROVIDER=none to disable IPv6. (I thought you would see the hint If your network does not support IPv6, you can disable it with IP6_PROVIDER=none when it first fails. Could you confirm that it's missing? If it's missing it's a bug I want to fix.)

Line 1 brings the monitor up the second I click on it.
Line 2 brings it down the second I click on it.
But the Message in UptimeKuma is "OK" in both instances.

So the difference between Healthchecks and Uptime Kuma is that Uptime Kuma by default will "keep" the previous message that was for successful pings. I found this very confusing, but can certainly adds a few hacks work around it.
I believe the main solution here is to say what has failed and I have updated the issue accordingly. Thank you again for your report.

I do not have the IP6_PROVIDER set.. Logs show:

Changed IP4_DOMAINS back to DOMAINS and added the IP6_PROVIDER, and now it's:

@JvdMaat The hint means that you can add IP6_PROVIDER=none. The updater will check all the settings and try to come up with a coherent global plan. So, if you only specify domains for IPv4, it will disable IPv6 for you, because there are no domains waiting for an IPv6 address. If you have DOMAINS=... and IP6_PROVIDER=none, the updater will also know that you don't want IPv6. I tried to make sure the updater will always come up with the most reasonable plan, so there are multiple ways to achieve the same result. You can either do IP4_DOMANS=... as you did now, or add IP6_PROVIDER=none.
What I am wondering is why the updater did not seem to give you a hint that you can add IP6_PROVIDER=none in your original setup. If you have time doing more experiments, I would like to see whether you can see that if we revert it back to DOMAINS=... without IP6_PROVIDE=none. I consider the absence of that useful hint a serious UI bug.

So the difference between Healthchecks and Uptime Kuma is that Uptime Kuma by default will "keep" the previous message that was for successful pings. I found this very confusing, but can certainly add some hacks work around it.

I just did a bunch of URL testing.. And I take back my earlier report that you could update the message if the monitor is already in a state. That did not work again. (Not sure why it worked that one time).
Also, if msg is empty, it assumes "OK". In all other cases, it prints the message on status change between up/down.
(I set the status to up with a different message text, and then down with no msg, and it just said OK as the message)

@JvdMaat Well, assuming the message is OK when the status is down is certainly confusing. 😅 Thanks for the report. I'm tracking this bug at #616.

@JvdMaat Thanks for the confirmation! I will still work on the README (tracked at #617).

Actually the fix is still not great. It should skip all the "success" messages when "error" messages are present.

Ok. Let me know if you have a version to test, and I can fiddle with the various combinations of IP6 and how that looks in UptimeKuma.

@JvdMaat Thanks for the volunteering. (I don't expect that you would have time to test it again.) The edge tag (the development version) should show "Failed to detect the IPv6 address" in Uptime Kuma. However, I don't want to claim I know how Uptime Kuma really works. :sweat_smile: Maybe I have to check its source code some day...

Some quick testing. With either IP4_DOMAINS, or IP6_PROVIDER=none (ie, IPv6 disabled), UptimeKuma shows up and OK.
With IP6 enabled, but failing it shows the appropriate message:

@JvdMaat But it seems there's still a strange "OK" there?

I manually ran the URL to set it down with no msg. (Just so Cloudflare DDNS could set it to up with the OK)

@JvdMaat Got it. Guess the problem is solved. I honestly think you (as an Uptime Kuma user) should/can complain about why it's still showing "OK" when status is down. :sweat_smile: (Maybe it's because the updater explicitly sent "OK" when it works? It's confusing either way.)
I will not release the new version because you are not suffering from the bug after disabling IPv6, and there's no security concern, either. I hope that's okay for you. If you are fine with this, I encourage you to switch back to the lastest tag because I have been using edge for testing new features.

Sounds good. I'll switch back to 1.11.0. And yeah, I now have IP6 disabled, and UptimeKuma working perfectly.
Thanks!

@JvdMaat Got it. Guess the problem is solved. I honestly think you (as an Uptime Kuma user) should/can complain about why it's still showing "OK" when status is down. 😅 (Maybe it's because the updater explicitly sent "OK" when it works? It's confusing either way.)

Maybe since it does send a push notification, but with status=down?
But from some quick testing looks like if msg is omitted or blank, it just uses OK as the default message. So UK assumes the sending party will include a message, and if not, substitutes OK as the default.
I just stopped my Cloudflare DDNS container to see if that will also give a down with OK message, or if the Message will be different. Will update in 10+ minutes once the monitor times out on getting a push.

And there it is:

So yeah.. UptimeKuma will just use OK if no msg is specified.


Query: optimize OrderBy on navigation property

OrderBy could be optimized on navigational property.
For example, this query
this.context.Parts
    .Select(t => new ViewPartModel()
            {
                id = t.Id,
                title = t.Titles
                    .OrderBy(t2 => t2.IsDefault)
                    .Select(t2 => t2.Translates
                        .Where(t3 => t3.LangISOCode == Lang)
                        .Select(t3 => t3.Title)
                        .FirstOrDefault())
                    .FirstOrDefault()
    }).OrderBy(t => t.title)
    .Skip(0)
    .Take(50)
    .ToArray()

produce this SQL:
SELECT [t].[Id], (
    SELECT TOP(1) (
        SELECT TOP(1) [t30].[Title]
        FROM [VarDesign_Parts-Title_Translates] AS [t30]
        WHERE ([t30].[LangISOCode] = 'SLV') AND ([t20].[Id] = [t30].[PartTitleId])
    )
    FROM [VarDesign_Part-Titles] AS [t20]
    WHERE [t].[Id] = [t20].[PartId]
    ORDER BY [t20].[IsDefault]
) AS [title]
FROM [VarDesign_Parts] AS [t]
ORDER BY (
    SELECT TOP(1) (
        SELECT TOP(1) [t3].[Title]
        FROM [VarDesign_Parts-Title_Translates] AS [t3]
        WHERE ([t3].[LangISOCode] = 'SLV') AND ([t2].[Id] = [t3].[PartTitleId])
    )
    FROM [VarDesign_Part-Titles] AS [t2]
    WHERE [t].[Id] = [t2].[PartId]
    ORDER BY [t2].[IsDefault]
)
OFFSET 0 ROWS FETCH NEXT 50 ROWS ONLY

but better would be:
SELECT [t].[Id], (
    SELECT TOP(1) (
        SELECT TOP(1) [t30].[Title]
        FROM [VarDesign_Parts-Title_Translates] AS [t30]
        WHERE ([t30].[LangISOCode] = 'SLV') AND ([t20].[Id] = [t30].[PartTitleId])
    )
    FROM [VarDesign_Part-Titles] AS [t20]
    WHERE [t].[Id] = [t20].[PartId]
    ORDER BY [t20].[IsDefault]
) AS [title]
FROM [VarDesign_Parts] AS [t]
ORDER BY [title]
OFFSET 0 ROWS FETCH NEXT 50 ROWS ONLY

There is no need to select fields again for ORDER BY, just use already returned field if exists.
I am attaching screenshot for ClientStatistics in Management Studio. Trial 1 and 2 are SQL created by EF. Trial 3 and 4 are when I manually correct sort. The difference in execution is approx half faster.

Further technical details
EF Core version: 2.0
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 10
IDE: Visual Studio 2017

Duplicate of #6703
De-duping a SelectExpression in order by is non-trivial task. It is same QueryModel but when we translate it both times, we generate different aliases to avoid name clash. So inside SelectExpression we cannot match and de-dupe it like we do with other complex expression.
@MaklaCof - Given there is perf differences, we will discuss this in team in next triage meeting. Thanks for detailed info on perf.

Given there is perf differences, we will discuss this in team in next triage meeting. Thanks for detailed info on perf.

Great. Thank you.
I imagine this is common scenario when you display result in grid (together with columns from detail tables) and you want to order by column from detail table.

Related #20291


fix: typos in prefix-command decorator

Description
Fixed a documentation typo for the @PrefixCommand() decorator:

Thanks!


feat: add crescent provider

Description
closes: #82

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] added appropriate labels to the PR
[ ] targeted the correct branch
[ ] provided a link to the relevant issue or specification
[ ] added a changelog entry to CHANGELOG.md
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

looks like the failure here is just due to the coingecko call right?
should we start running our tests with that disabled?


Update README.md

The README.md for this project is tragically out-of-date. Much of the information in it is now actually unhelpful or simply irrelevant. Also, this readme does little to capture what the project is about.

This was updated with the DEPLOY.md in #65


Fix bug where Senders were not unparked upon calling Receiver::try_next

Fixed by moving calls to unpark_one and dec_num_messages into next_message so that calling them cannot be missed (as it was with try_next).
Closes #861

Thanks!


fix: remove warns from rosa list versions command to avoid issues

When deploying a ROSA managed cluster, if ROSA cli is not the latest version, we got some warnings:
13:09:58  ods-ci-ods_ci.utils.scripts.logger: INFO     CMD: rosa create cluster --cluster-name rosacesar24jul --replicas    2 --region us-east-2 --compute-machine-type m5.2xlarge --yes --version WARN: The current version (1.2.41) is not up to date with latest released version (1.2.42).
13:09:58  WARN: It is recommended that you update to the latest version.
13:09:58  4.15.21 --channel-group stable --sts
13:09:58  >: /bin/sh: -c: line 1: syntax error near unexpected token `('
13:09:58  >: /bin/sh: -c: line 1: `rosa create cluster --cluster-name rosacesar24jul --replicas    2 --region us-east-2 --compute-machine-type m5.2xlarge --yes --version WARN: The current version (1.2.41) is not up to date with latest released version (1.2.42).'

This is affecting the rosa create cluster because the version retrieved from rosa list versions command is not properly parsed

Verified in smoke job 6286


Upload multiple documents at once

Functionality from the multiple image uploader was used. It was all rather easy to do because most of the work had already been done!
The jQuery plugins from the image uploader have been copied across, which means they are in the repo twice. They are in different apps though, which do not have to be installed at the same time, so they can not simply use the wagtailimages version of the scripts, sadly. The scripts could be moved in to admin, which is always installed if duplicating the scripts is an issue?

Brilliant! Thanks @timheap. You may also like to check my work on https://github.com/torchbox/wagtail/pull/1234 which I believe slightly refactored some of the upload code, removes the concept of having a separate "upload screen", and the mandatory field requirements.
Regarding script location I think the uploader scripts should be seen as a reusable asset, just like the icons or the other javascript plugin systems e.g choosers. It seems there are quite a few users trying to do file/image upload systems as part of their own private apps and if they could reuse these upload scripts it would improve the aesthetic all round.

:+1:

This is working very nicely - thanks @timheap! I'd definitely prefer the js/vendor files to be moved to wagtailadmin rather than duplicated between wagtailimages and wagtaildocs, as per @davecranwell's reasoning.
Ideally, it would be nice to see the copy-and-paste trimmed down further - a general-purpose multiple-uploader CBV would make a nice addition to wagtailadmin.views.generic, I reckon - but I wouldn't make that a blocker for merging this.

I've moved the duplicated JS files to wagtailadmin, and fixed the SASS errors.

Rebased and merged in e131a9bcaf3f06b06f65481e936fd08564fbe056 + parents, including updating the views to use permission policies (fcb3adb2f0073a49a5aa6ee67089cf04a31137f0). Thanks!


Add Switch component

https://github.com/seamapi/react/assets/11382084/552fb64c-8368-4f2a-a39b-1c6ebdb0a619

Looks nice, can you add a story to the Library section so we can check it out?

62ade83


New option: --clean

Cleans all renderings for particular file.
What should be cleaned:

Rendered data in "render" directory.
Rendered data for each profile in "render/project.conf/" directory
Cache data

Would be nice to implement this as action:
renderchan --action clean some-file.blend


[Tooling] genkit start implementation is not 100% windows compatible

$ npx genkit start -- npx tsx .\src\index.ts

Error in app process: Error: spawn npx ENOENT
[Telemetry Server] initialized local file trace store at root: C:\Users\abc\test1\.genkit\traces
Telemetry API running on http://localhost:4034
node:internal/child_process:286
      const err = new ErrnoException(exitCode, syscall);
                  ^

Error: spawn npx ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'spawn npx',
  path: 'npx',
  spawnargs: [ 'tsx', '.\\src\\index.ts' ]
}

Node.js v21.7.3

Look into https://www.npmjs.com/package/cross-spawn

Facing the same error on Macbook air m2 while running this command:
npm run genkit:start -a http://localhost:3100
Error in app process: Error: spawn tsx ENOENT
[Telemetry Server] initialized local file trace store at root: ~/functions/.genkit/traces
Telemetry API running on http://localhost:4033
node:internal/child_process:285
      const err = new ErrnoException(exitCode, syscall);
                  ^

Error: spawn tsx ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:285:19)
    at onErrorNT (node:internal/child_process:483:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn tsx',
  path: 'tsx',
  spawnargs: [ '--watch', 'src/genkit-sample.ts', 'http://localhost:3100' ]
}

Node.js v22.11.0

By the way it was working fine previously.

Facing the same error on Macbook air m2 while running this command: npm run genkit:start -a http://localhost:3100
Error in app process: Error: spawn tsx ENOENT
[Telemetry Server] initialized local file trace store at root: ~/functions/.genkit/traces
Telemetry API running on http://localhost:4033
node:internal/child_process:285
      const err = new ErrnoException(exitCode, syscall);
                  ^

Error: spawn tsx ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:285:19)
    at onErrorNT (node:internal/child_process:483:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn tsx',
  path: 'tsx',
  spawnargs: [ '--watch', 'src/genkit-sample.ts', 'http://localhost:3100' ]
}

Node.js v22.11.0

By the way it was working fine previously.

Can you please share your genkit:start script configuration in package.json?

Hi @pavelgj
Here's my full package.json file
{   "main": "lib/index.js",   "scripts": {     "genkit:start": "genkit start -- tsx --watch src/genkit-sample.ts",     "lint": "eslint --ext .js,.ts .",     "build": "tsc",     "build:watch": "tsc --watch",     "serve": "npm run build && firebase emulators:start --only functions",     "shell": "npm run build && firebase functions:shell",     "start": "npm run shell",     "deploy": "firebase deploy --only functions",     "logs": "firebase functions:log"   },   "name": "functions",   "engines": {     "node": "18"   },   "dependencies": {     "@genkit-ai/firebase": "^0.9.4",     "@genkit-ai/googleai": "^0.9.4",     "express": "^4.21.1",     "firebase-admin": "^12.6.0",     "firebase-functions": "^6.0.1",     "genkit": "^0.9.4"   },   "devDependencies": {     "@typescript-eslint/eslint-plugin": "^5.12.0",     "@typescript-eslint/parser": "^5.12.0",     "eslint": "^8.9.0",     "eslint-config-google": "^0.14.0",     "eslint-plugin-import": "^2.25.4",     "firebase-functions-test": "^3.1.0",     "tsx": "^4.19.2",     "typescript": "^4.9.5"   },   "private": true }

@pavelgj
Here's what I got, it opens the localhost URL but not still working and throwing this error while running this command npm run genkit:start -a http://localhost:3100 :
Telemetry API running on http://localhost:4034
Genkit Developer UI: http://localhost:4001
node:internal/modules/cjs/loader:1249
  const err = new Error(message);
              ^

Error: Cannot find module 'genkit'
Require stack:
- /Users/omarbakry/Desktop/KIB/Projects/paytally/functions/src/genkit-sample.ts
    at node:internal/modules/cjs/loader:1249:15
    at nextResolveSimple (/Users/omarbakry/.npm/_npx/fd45a72a545557e9/node_modules/tsx/dist/register-DCnOAxY2.cjs:3:942)
    at /Users/omarbakry/.npm/_npx/fd45a72a545557e9/node_modules/tsx/dist/register-DCnOAxY2.cjs:2:2550
    at /Users/omarbakry/.npm/_npx/fd45a72a545557e9/node_modules/tsx/dist/register-DCnOAxY2.cjs:2:1624
    at resolveTsPaths (/Users/omarbakry/.npm/_npx/fd45a72a545557e9/node_modules/tsx/dist/register-DCnOAxY2.cjs:3:760)
    at /Users/omarbakry/.npm/_npx/fd45a72a545557e9/node_modules/tsx/dist/register-DCnOAxY2.cjs:3:1038
    at m._resolveFilename (file:///Users/omarbakry/.npm/_npx/fd45a72a545557e9/node_modules/tsx/dist/register-RyGUjI6j.mjs:1:789)
    at Function._load (node:internal/modules/cjs/loader:1075:27)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:218:24) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/omarbakry/Desktop/KIB/Projects/paytally/functions/src/genkit-sample.ts'
  ]
}

Node.js v22.11.0
Failed running 'src/genkit-sample.ts http://localhost:3100'

why are you running it like npm run genkit:start -a http://localhost:3100?
Try running just npm run genkit:start.

@pavelgj
I need to -a http://localhost:3100 to call the flow endpoints locally within my mobile app

-a option was removed from genkit start...
also, I'm not sure I fully understand, but you don't need that option to call the flow from your mobile app.


Add porno by persus

Song Name
porno
Artist Name
Kpersillo
Source
Youtube
Youtube Link
TklO8RGH-Rk
Direct File Link
No response
Song ID
467339
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 10565740
Downloaded: Yes

No sé descargael audio que quiero


[RUN-4165] Add documentation for the mx show-java-version command

This PR adds documentation for the recently added mx show-java-version command, which shows the configured Java version of the app. This command was added in 10.14.0, 10.12.2, 10.6.12 and 9.24.26.

Yes...I forgot to add a release note. Maybe something like: "We added the show-java-version to the mx command line tool."

Added the RN here: https://github.com/mendix/docs/pull/8073/commits/eff7a076fdb09176b1252907577d94dab80232b5


Johtaylo/teams members added

Pull Request Test Coverage Report for Build 85051

0 of 0   changed or added relevant lines in 0 files are covered.
912 unchanged lines in 109 files lost coverage.
Overall coverage increased (+0.4%) to 77.901%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookAdapter.cs
1
96.67%

/libraries/Adapters/Microsoft.Bot.Builder.Adapters.Facebook/FacebookClientWrapper.cs
1
93.24%

/libraries/integration/Microsoft.Bot.Builder.Integration.ApplicationInsights.Core/ApplicationBuilderExtensions.cs
1
71.43%

/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisApplication.cs
1
95.45%

/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisApplication.cs
1
96.43%

/libraries/Microsoft.Bot.Builder.AI.LUIS/V3/LuisUtil.cs
1
96.5%

/libraries/Microsoft.Bot.Builder/BotStateSet.cs
1
85.0%

/libraries/Microsoft.Bot.Builder.Dialogs/Debugging/SourceRange.cs
1
46.15%

/libraries/Microsoft.Bot.Builder.Dialogs/Memory/Scopes/MemoryScope.cs
1
88.37%

/libraries/Microsoft.Bot.Builder.Dialogs/PersistedStateKeys.cs
1
60.0%

Totals

Change from base Build 85048:
0.4%

Covered Lines:
5640

Relevant Lines:
7240

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.5.3
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.5.3


SCV icons path problem

Informations
It's quite problematic to load icons through javaScript.
The only reason i decided to user trumbowy was clean way to replace all css and icons.
So pleas add easy way to give relative path for icons inside *.scss. (for example variable with path like it was till 2.0.0-beta.8)
(it it's already possible please mention this in documentation)
Moreover not setting svnPathis throwing error in console.
Browser + version: chrome/ie10
OS: win
Resolution: 2.0.0+
How to reproduce the bug?
try to use Trumbowyg without setting path to icons through js.

Use svgPath, also see #256.

I've just added a global $.trumbowyg.svgPath option which can be set to false to disable SVG js loading.
I can't just hide network error and I can't put SVG management in CSS due to actual support of SVG features sucks, e.g. I

this works, thank you Alex.
//2019-08-16 angularjs fix, when minimizing will help to avoid >> You must define svgPath: https://goo.gl/CfTY9U
$.trumbowyg.svgPath = '/static/bower_components/trumbowyg/dist/ui/icons.svg';


Yosegi-70 New class added to Boolean generic test.

What is the necessity of this update? What is updated?
The Boolean generic test does not include OptimizedNullArrayDumpBooleanColumnBinary.
Added unit tests and bug fixes.
How did you do the test? (Not required for updating documents)

LGTM


Household select2 should show full_name

Originally created by Tom Smyth at 2015-09-12 12:33, migrated from redmine-#3080

Status changed from New to Closed

By Tom Smyth at 2015-09-23 05:42


Release of version <IP_ADDRESS> of SqlServerDsc

Releasing version <IP_ADDRESS>

This change is

Codecov Report

Merging #1044 into master will increase coverage by 1%.
The diff coverage is 99%.

@@           Coverage Diff           @@
##           master   #1044    +/-   ##
=======================================
+ Coverage      96%     97%    +1%
=======================================
  Files          32      32
  Lines        3515    3925   +410
=======================================
+ Hits         3395    3839   +444
+ Misses        120      86    -34


Refactor SearchConditionSerializer to use a FieldSetRegistry

Q
A

Bug Fix?
no

New Feature?
yes

BC Breaks?
yes

Deprecations?
no

Fixed Tickets

License
MIT

A new inspection was created.

The inspection completed: 5 updated code elements

Hmm. Travis seems be one a break.

A new inspection was created.

The inspection completed: 1 new issues, 5 updated code elements


User Login

Hi,
How can i get only the data of a user who login to the application. Should i use Multi tenant to get this or is there any other method to get it. For Example if an Employee login, only the employee data has to be show to him.
thank you
Srinivas

Use
Authorization.userDefinition at client and server side

Hi @javaman63 ,
Can you please explain how to implement Authorization.userDefinition. If posible with an example.
Thanks ,
Srinvas

Have a look around in guide, multitenancy and permissions.

@srinivas1910  Do you can resolved this?


Feature/games 002

Implemented basic Tic-Tac-Toe:

Tic-Tac-Toe menu screen
Tic-Tac-Toe game
linked with main menu

Fixed build error with strings.xml
Pair Programmed with Marcel Schanes.
#2

Please check again. Thank you!


Add Windows 11 target

Update build scripts to use EWDK 11 21H2 for Win10 target and EWDK 11 22H2 for Win11 target

I see that in the projects Win11/x86 configuration were added. Of course we can remove them later but each such removal will request the change in the root virtio-win.sln (change project ref config to 'Win11/x64/nobuild') and will trigger full rebuild.
If possible I would suggest to make the change in root SLN file, then specific projects can be changed without triggering full rebuild.

@YanVugenfirer
The build part is finished. SDV in progress.

+1 for me. There are some auxilliary 32-bit executables that will be good to have for test purposes only. But in case of need the binaries for Win10 can be used.


support splitting data retrieval and data transformation

Hi Roee.
This PR is not finalized. I would like your thoughts on whether this is the right direction.
Let's review when you have the time.
Currently, the get_flight_info in server.py does not run _infer_schema and transform_schema for passthrough. I will change that after PR #30 is merged.


Changes Saves for Edit Color

We can't saves the changes and choose the color in Color edit with WrestleMinus .

And same thing for Show Edit

https://cdn.discordapp.com/attachments/283102473940369409/560597530077822979/unknown.png
Apologies for the delay.  Save changes should show once you have made a change to the light or to the show edit and then hit enter.

I will eventually have it there but greyed out until edited in future versions.


Use HTTP for LS download when "http.proxyStrictSSL" setting is false.

(for #2849)

[x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Has a news entry file (remember to thank yourself!)
~[ ] Has sufficient logging.~
[x] Has telemetry for enhancements.
[x] Unit tests & system/integration tests are added/updated
[x] Test plan is updated as appropriate
~[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)~
~[ ] The wiki is updated with any design decisions/details.~

@ericsnowcurrently Please make some more changes, see https://github.com/Microsoft/vscode-python/issues/2849#issuecomment-479633873


Out of Memory in B44Compressor (79258415)

Hello OpenEXR team,
As part of our fuzzing efforts at Google, we have identified an issue affecting
OpenEXR (tested with revision * develop 12283c2d2a7e3bb1baffb52437334d40c9152e50).
To reproduce, we are attaching a Dockerfile which compiles the project with
LLVM, taking advantage of the sanitizers that it offers. More information about
how to use the attached Dockerfile can be found here:
https://docs.docker.com/engine/reference/builder/
Instructions:
unzip artifacts_79258415.zip
docker build --build-arg SANITIZER=address --tag=autofuzz-OpenEXR-79258415 autofuzz_79258415
docker run --entrypoint /fuzzing/repro.sh --cap-add=SYS_PTRACE -v $PWD/autofuzz_79258415/poc-2b68475a090117f033df54c2de31546f7a1927ecadd9d0aa9b6bb8daad8ea971_min:/tmp/poc autofuzz-OpenEXR-79258415 "openexr/OpenEXR/exrheader/exrheader" /tmp/poc
docker run --cap-add=SYS_PTRACE -v $PWD/autofuzz_79258415/poc-2b68475a090117f033df54c2de31546f7a1927ecadd9d0aa9b6bb8daad8ea971_min:/tmp/poc -it autofuzz-OpenEXR-79258415
Alternatively, and depending on the bug, you could use gcc, valgrind or other
instrumentation tools to aid in the investigation. The sanitizer error that we
encountered is here:
==7==AddressSanitizer's allocator is terminating the process instead of returning 0
==7==If you don't like this behavior set allocator_may_return_null=1
==7==AddressSanitizer CHECK failed: /build/llvm-toolchain-5.0-5.0.2~svn328729/projects/compiler-rt/lib/sanitizer_common/sanitizer_allocator.cc:218 "((0)) != (0)" (0x0, 0x0)
    #0 0x4ee69f in __asan::AsanCheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) (/fuzzing/openexr/OpenEXR/exrheader/.libs/exrheader+0x4ee69f)
    #1 0x50a565 in __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) (/fuzzing/openexr/OpenEXR/exrheader/.libs/exrheader+0x50a565)
    #2 0x4f3c46 in __sanitizer::ReportAllocatorCannotReturnNull() (/fuzzing/openexr/OpenEXR/exrheader/.libs/exrheader+0x4f3c46)
    #3 0x4f3ccf in __sanitizer::DieOnFailure::OnOOM() (/fuzzing/openexr/OpenEXR/exrheader/.libs/exrheader+0x4f3ccf)
    #4 0x51a774 in operator new[](unsigned long) (/fuzzing/openexr/OpenEXR/exrheader/.libs/exrheader+0x51a774)
    #5 0x7fc93f764007 in Imf_2_2::B44Compressor::B44Compressor(Imf_2_2::Header const&, unsigned long, unsigned long, bool) /fuzzing/openexr/OpenEXR/IlmImf/ImfB44Compressor.cpp:494:18
    #6 0x7fc93f75e471 in Imf_2_2::newCompressor(Imf_2_2::Compression, unsigned long, Imf_2_2::Header const&) /fuzzing/openexr/OpenEXR/IlmImf/ImfCompressor.cpp:156:13
    #7 0x7fc93f7b55e2 in Imf_2_2::getScanlineChunkOffsetTableSize(Imf_2_2::Header const&) /fuzzing/openexr/OpenEXR/IlmImf/ImfMisc.cpp:1831:30
    #8 0x7fc93f84a328 in Imf_2_2::MultiPartInputFile::Data::readChunkOffsetTables(bool) /fuzzing/openexr/OpenEXR/IlmImf/ImfMultiPartInputFile.cpp:738:36
    #9 0x7fc93f848ed4 in Imf_2_2::MultiPartInputFile::initialize() /fuzzing/openexr/OpenEXR/IlmImf/ImfMultiPartInputFile.cpp:429:12
    #10 0x7fc93f8481a0 in Imf_2_2::MultiPartInputFile::MultiPartInputFile(char const*, int, bool) /fuzzing/openexr/OpenEXR/IlmImf/ImfMultiPartInputFile.cpp:136:9
    #11 0x51f1a2 in printInfo(char const*) /fuzzing/openexr/OpenEXR/exrheader/main.cpp:290:24
    #12 0x520e28 in main /fuzzing/openexr/OpenEXR/exrheader/main.cpp:562:13
    #13 0x7fc93e1072e0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x202e0)
    #14 0x4262b9 in _start (/fuzzing/openexr/OpenEXR/exrheader/.libs/exrheader+0x4262b9)

We will gladly work with you so you can successfully confirm and reproduce this
issue. Do let us know if you have any feedback surrounding the documentation.
Once you have reproduced the issue, we'd appreciate to learn your expected
timeline for an update to be released. With any fix, please attribute the report
to "Google Autofuzz project".
We are also pleased to inform you that your project is eligible for inclusion to
the OSS-Fuzz project, which can provide additional continuous fuzzing, and
encourage you to investigate integration options.
Don't hesitate to let us know if you have any questions!
Google AutoFuzz Team
artifacts_79258415.zip

This POC now aborts with 'Invalid size field in header attribute'


Unused BasicDataStats

In your API, there are 70 different rune statistics, but in Riot's API documentation there are only 65.

BasicDataStats is shared with Items, where some extra parsing of descriptions is done to extract stats that aren't sent by the API but that the item has.


pythonPackages: pint: init at 0.7.2

Motivation for this change
Add python pint package for working with physical quantities.
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Messed up with git. Will resubmit.


[REQUEST] Celcius or other custom units for temperature.

I would like support for non Fahrenheit temperature.

You can choose to use celsius units in the module settings.  Is that what you need?

Couldn't find it at the time. Thanks.


[The setter 'doNotOpenAgain isn't defined for the class 'RateMyApp']

Describe the bug
When I attempt to implement .doNotOpenAgain, I get the following error "The setter 'doNotOpenAgain isn't defined for the class 'RateMyApp'".
//RateMyApp Preferences
  RateMyApp _rateMyApp = RateMyApp(
    preferencesPrefix: 'rateMyApp_',
    //Minimum number of days a user has to have the app installed, 3
    minDays: 3,
    //Minimum number of launches before showing prompt, 5
    minLaunches: 5,
    //Number of days before requesting a rating, 7
    remindDays: 7,
    //Number of launches before requesting a rating, 5
    remindLaunches: 5,
);

@override
   void initState() {
   super.initState();
   _rateMyApp.init().then((_){
      //if (_rateMyApp.shouldOpenDialog) {
      _rateMyApp.showStarRateDialog(
        context,
        title: 'Enjoying Liquid',
        message: 'Please leave a rating!',
        onRatingChanged: (stars) {
          return [
            FlatButton(
              onPressed: () {
                if (stars!= null) {
                  _rateMyApp.doNotOpenAgain = true;
                  _rateMyApp.save().then((v) => Navigator.pop(context));
                  if (stars <= 3) {
                    //Navigate to Contact Screen
                    Navigator.push(
                      context,
                      MaterialPageRoute(
                        builder: (_) => ContactSupportScreen(),
                      ),
                    );
                  } else if (stars >= 4) {
                    print('Leave a Review');
                  }
                } else {
                  Navigator.pop(context);
                }
              }, //onPressed
              child: Text('Ok'),
            ),
          ];
        },
        dialogStyle: DialogStyle(
          titleAlign: TextAlign.center,
          messageAlign: TextAlign.center,
          messagePadding: EdgeInsets.only(bottom: 20.0),
        ),
        starRatingOptions: StarRatingOptions(),
      );
      //}
    });
  }

`
Additional context

rate_my_app: ^0.5.0+1

Yes, that's the new 0.5.0 behavior. The condition "Do not open again" can now be removed and therefore this getter/setter is not available anymore.
I see that you want to create a "Rate" button. What you can do is to replace those two lines :
_rateMyApp.doNotOpenAgain = true;
_rateMyApp.save().then((v) => Navigator.pop(context));

By :
_rateMyApp.callEvent(RateMyAppEventType.rateButtonPressed).then((_) => Navigator.pop(context));

The rateButtonPressed event will trigger the Do not open again condition (see here).
Easier no ? :wink:

@Skyost Thanks for clarifying.


1.56.0 broke the "Search in folder" option

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
After upgrading Atom Beta from 1.55.0 to 1.56.0-beta.0 I can no longer right-click on a folder in my Project tab and choose "Search in folder". After clicking on "Search in folder" nothing happens anymore. The search dialog doesn't get launched.
If I use the OS menu "Find > Find in Project" then the dialog launches though.
Steps to Reproduce

Install 1.56.0-beta.0 build
Right-click on any folder in your Projects file lister
Select "Search in Folder"
BUG: Search panel should appear but doesn't.

Expected behavior:
The search panel should open.
Actual behavior:
Nothing happens
Reproduces how often:
Every time. Consistent. Rolling back to 1.55.0 fixes the issue.
Versions
Atom    : 1.55.0
Electron: 6.1.12
Chrome  : 76.0.3809.146
Node    : 12.4.0
apm  2.5.2
npm  6.14.8
node 12.4.0 x64
atom 1.55.0
python 2.7.16
git 2.31.1
MacOS 11.2.3

Cherry-picked the commit to the  1.56-releases


What is the difference with  GroupedGemm of Cutlass

https://github.com/NVIDIA/cutlass/blob/main/python/cutlass/op/gemm_grouped.py#L71

Hi! This is a PyTorch wrapper around CUTLASS grouped GEMM kernels :)


usage example?

There's not quite enough example material for me to put this together.  Could I have some help with this ioctl?
The C header is ...
#define USBDEVFS_CONTROL           _IOWR('U', 0, struct usbdevfs_ctrltransfer)

...and I've got the Rust version of that struct ready to go...
#[derive(Debug)]
#[repr(packed)]
struct USBFS_control_transfer {
        bRequestType :u8,
        bRequest     :u8,
        wValue       :u16,
        wIndex       :u16,
        wLength      :u16,
        timeout      :u32, // in milliseconds
        data         :*mut u8;
};

Thanks.

Answer below.  A key bit is to use repr(C) instead of repr(packed).  That one had me pulling my hair for a while.
#[derive(Debug)]
#[repr(C)]
pub struct USBFS_control_transfer {
        bmRequestType:u8,
        bRequest     :u8,
        wValue       :u16,
        wIndex       :u16,
        wLength      :u16,
        timeout      :u32, // in milliseconds
        data         :*mut u8,
}

//#define USBDEVFS_CONTROL           _IOWR('U', 0, struct usbdevfs_ctrltransfer)
ioctl!(readwrite ioctl_control_transfer with b'U', 0; USBFS_control_transfer);

fn f() {
    ...
    let mut mystruct = USBFS_control_transfer{...};
    ioctl_control_transfer(self.file.as_raw_fd(), &mut mystruct)
    ...
}


Add support for non Spring Boot tests

We don't support anything that's not a SpringBootTestContextBootstrapper and the mapping currently assumes that everything is a Spring Boot test. In the interest of making our support a bit more generic, it would be nice to have an AotTestContextProcessor that handles the TCF as well as a way to create the mapping for multiple implementations.

FTR, we no longer have an assumption about Spring Boot test for the mapping as this is taken care of by the AotTestContextProcessor implementation now.

Great work, @snicoll! 👏


Update license year

TO DO:

[ ] Wait to the next year (99% done)
[ ] Merge!

:octocat:

Pretty sure it's already 2018 somewhere (e.g. in Toby-land). :shipit:


A doubt at line 350 in dqn.cpp

Firstly, sorry I posted this as an issue as I wasn't able to find your mail.
Doubt: I am not able to understand whether the solver takes a million steps at solver_->step(1) as mentioned in dqn_solver.txt or only a single step.
According to me 1 step == forward propagate, calculate errors, backpropagate errors and update filter weights.
Can you please clarify this?
Sorry I wasn't able to get this part of caffe documentation.
Thanks!
Regards.

No problem. Feel free to ask any question here.
solver_->Step(1) is a single step, an update from a minibatch of 32 transitions.

Thanks a lot! I am also training an agent (rom: breakout) but facing quite a lot of difficulties as I am not using caffe but cudnn library.  I'll then be asking you, my further queries here only. I hope to get some help.
Thanks a lot again.
Regards.

Hi again,
As I said earlier, I am using breakout as the rom. I have written some code and it's working fine but unfortunately it's not learning as the slider in the game(the agent) either gets stuck to the left end of the screen or the right end.
After a lot of struggle, I am still unable to understand the reason for that. Do you have any clue why's that happening or can you have a look at my code please. I have added you as a collaborator in my private repo.
Thanks!
Regards.

I've not read your code yet, but the discussion of this thread can be some help
https://groups.google.com/forum/#!topic/deep-q-learning/k1CzQxOi_v4

Thanks a lot for that link! I think I can make it up from here.


[ADAM-2194] Disable coveralls reporting from Jenkins test script

Fixes #2194

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/3040/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/3041/
Test PASSed.


tab (vi) shows up as (v)

Issue found in 91e0c129815926aa4b6b2f1827091dc43f46b05b
We have labelled at tab vi in the editor and it is rendering on the site as v.
http://www.cl.cam.ac.uk/~ipd21/rutherford/scooter/app/#!/edit/master/content/questions/maths/workbook/fc5_comp_func.json

It shows up as vi for me?

I just changed this as it was v in the editor before. It probably just hadn't changed for you yet


Mejorar las instrucciones de instalación

Hola amigo, me gustaría probar el ib, pero se me dificulta la instalación ya sea en local o en un servidor, me podrías ayudar con eso?

Sorry I don't speak Spanish

Sorry I don't speak Spanish

They basically said that they need help installing, (Hello friend, I would like to try the ib, but I find it difficult to install either locally or on a server, could you help me with that?)

What OS are you using?

Windows, también uso XAMPP con MySQL y Apache, lo que no se es que poner en la sección de "Almacenamiento seguro ", también en localhost, al momento de instalar, no me carga los css, pero en el servidor hosting si.

I've never tested the software on Windows but I assume the CSS not loading has something to do with the diffrences between *nix and Windows. As for the secure storage it's the path to a file that stores the encryption keys for the database credentials. You should put it in a place where you webserver can access it and cannot be accessed externally. I'll try to make the install instructions clearer on the next release.


implement a symptom checker and add links to the helpful links section

Is your feature request related to a problem? Please describe.
add a symptom checker so that the users can check if the require examination
Describe the solution you'd like
implement a symtom checker than can evaluate the result based on the answers of the users
example:
https://covid.bhaarat.ai/
https://www.apple.com/covid19/
Describe alternatives you've considered
for now add the links to these websites in the helpful links
Additional context

@aakash714 Please review #250

Yeah it's great

Maybe we can later add this in "Showcase".


CUE - Confirm if proctored OTC results are reaching CA

CUE is inquiring if their proctored results are being delivered to CA.
Per CUE, CA shared on a recent AIMS call that they do not want OTC results, but ok with proctored results. Hence, we need to confirm whether RS is routing CUE's Proctored OTC results to CA's primary feed.
CA has completely turned off their secondary feed citing data quality and completeness concerns with OTC data.

Was likely turned off when secondary feed was turned off.  @jbiskie @brick-green-agile6 can one of you two look into this?

@brick-green-agile6 could you please take a look at this today? Thank you.

@anshulkumar-usds Just reviewed the most recent results and they are not going to CA. Still trying to lock down which specific quality filter is blocking the results from continuing.

Checked the CUE files against the quality filters for CA. They are failing for two reasons:

Missing CLIA
Missing Provider ID

Shared updates with CUE - no further questions at this time.


HTMX/Templ support?

Tell us about your feature request
I used the project to build an HTMX server using Templ. Would we want there to be an option in the cli to setup? I know the project is meant to be minimalistic, so I wasn't going to add it unless people think it is a good idea.
My thought is that opting into this would add another folder for web ui stuff with a basic route to get the project started.
Let me know your thoughts.
Disclaimer

[X] I agree

I had some time to think about this.
Honestly I love this idea and I think blueprint can definitely benefit from it.
HOwever, one thing I want to do is add a --advanced flag that gives many more prompts. In that advanced mode, one of the prompts.
I think the current non advanced flow is pretty exhausted and I want to keep it that way.
What do YOU think?

I think that is smart. Keep it simple for most everyone, but add functionality if people want it. I'll start looking at it over the holiday and see what I can come up with.

I'm 100% down for adding this idea with the --advanced flag.
@briancbarrow What do you think of using my htmx-go library for this? It has a lot of convenient utilities for working with HTMX, like checking if a request is HTMX with htmx.IsHTMX() and autocomplete/documentation that plays well with LSP/Intellisense. It will definitely help people Focus on the actual code of your application.
The only issue is that the library is only built for net/http types, so Fiber integration might be a challenge. But Templ will also have issues with Fiber too.
I like Templ too, so I can help out with integrating Templ, and my htmx-go library.

Bringing in frontend library, it would be nice to also add integration test with something like playwright-go, so people don't forget to write tests.

Guys, @briancbarrow did an amazing job bringing HTMX templates into Blueprint. More importantly, there is logic for simply implementing other features in the future. If you have time, please help him with this PR #149  @cedric-appdirect  @angelofallars


Atrx clonality exploration

Purpose/implementation Section
What scientific question is your analysis addressing?
In response to a reviewer comment about ATRX clonality in general and between ALT +/- tumors, I am plotting some figures for a supplemental figure
What was your approach?
Added:

density plot of ATRX VAF by ALT status
density plot of ATRX VAF by ALT status and oncogenicity
correlation plot of ATRX VAF vs tel hunter score
Calculated a stat for distribution differences, but the N for ATRX ALT- is so low (4) and the means of the VAFs by group are similar that this was not significant

#	Exact two-sample Kolmogorov-Smirnov test

# data:  pos$VAF and neg$VAF
# D = 0.35, p-value = 0.7283
# alternative hypothesis: two-sided

Did not attempt this on the 3 group plots because of the low Ns
What GitHub issue does your pull request address?
NA, revisions
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Is there anything that you want to discuss further?
Also had to add a new R package, stats, to run the KS test.
Any additional thoughts on these?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes
Results
What types of results are included (e.g., table, figure)?
ATRX clonality figure with panels B, C, D
What is your summary of the results?
Reproducibility Checklist

[ ] The dependencies required to run the code in this pull request have been added to the project Dockerfile.

Documentation Checklist

[ ] This analysis module has a README and it is up to date.
[ ] The analytical code is documented and contains comments.

The modified code in this branch runs fine, but I'm getting the following error in the 00-table2-somatic-mmr.R script when running run_tables.sh in this branch and master:
Error in `select()`:
! Problem while evaluating `everything(dgd_maf)`.

This is caused by lines 53-64 in the Rscript:
dgd_maf <- read_tsv(file.path(anno_maf_dir, "dgd_maf-goi-oncokb.tsv")) %>%
  rename(Kids_First_Biospecimen_ID = Tumor_Sample_Barcode) %>%
  filter(Hugo_Symbol %in% goi$genes,
         Variant_Classification %in% mut_of_interest,
         ONCOGENIC %in% c("Likely Oncogenic", "Oncogenic")) %>%
  mutate(HGVSp_Short = case_when(is.na(HGVSp_Short) & Variant_Classification == "Splice_Region" ~ "splice",
                                 TRUE ~ as.character(HGVSp_Short)),
         MMR = paste(Hugo_Symbol, HGVSp_Short, sep = " ")) %>%
  select(Kids_First_Biospecimen_ID, Hugo_Symbol, HGVSp_Short, MMR,
         Variant_Classification, GENE_IN_ONCOKB, VARIANT_IN_ONCOKB,
         ONCOGENIC, MUTATION_EFFECT, everything(dgd_maf)) %>%
  unique()

I think the problem is the inclusion of dgd_maf within the everything() function, since the variable hasn't been assigned yet. I removed this and the module ran without any issues. But please double check.

I have gone through and fixed the error which was causing samples to be counted multiple times based on having more than one ATRX variant - this was due to the VAF being recorded in the table for that output. I broke this and the clonality table apart so now everything runs as expected.


feat: SDK support for new diagnostics endpoints

Asana: https://app.asana.com/0/1208505982103877/1208604478475174/f

Ruby 2.7 passes. Ruby 3.0 fails due to dependency issues with installed packages.


bump svd v0.7, rm ref

bump svd-parser to v0.7, rm ref in match patterns without changing functionality

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Emilgardis (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks for the pr!
This is a duplicate of #256, if you did a pr to register-derived-from fixing merge conflicts I would be happy to approve that :)


Enable hibernation by adding the snippets only when the setting is enabled.

Don't put many fixes in the one PR. We should make small fix get into faster.

@LiliDeng  is this still useful?

@LiliDeng is this still useful?

I will split the PR, then make this one for hibernation cases only.

@LiliDeng is this still useful?

I will split the PR, then make this one for hibernation cases only.


manifest.go: add the layers validation type

Layer has several  mediatype types, it should be completed all the mediatype.
Signed-off-by: zhouhao<EMAIL_ADDRESS>

Closing in favor of #111


CI: fix appveyor to use fixed versioning

since the GIT_* env variables are not available

merged via https://github.com/pydata/pandas/commit/07c84d5957ad665431bc7bfee4f40c0f1c3bf47c


Allowing resume behavior tree by set tree instance manually.

Currently, we can obtain the running instance of a behavior tree by invoking BTPlayer.get_tree_instance(). However, there are times when a user may wish to temporarily exit the current behavior tree to execute a different one and return to it later. This is a common scenario when utilizing smart objects, as it allows for the transfer of actor control between different behavior trees."
Possible implement: When you are prepared to exit, encapsulate the BT context within an object and return it to the user. This object can then be passed to the resume method to continue the BT.

Potential Workaround: Add multiple BTPlayer nodes to the scene tree, and activate/deactivate them on demand (see BTPlayer.active).

Closing as it was implemented some time ago


Game crashes when scrolling through Freeplay with the Mouse Wheel too quickly

Describe your bug here.
was just messing around on freeplay after beating a song and the game just abruptly crashed while i was using my mouse wheel to scroll quickly

Command Prompt/Terminal logs ()
No response
Are you modding a build from source or with Lua?
No modding
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Base mod, nothing was changed.

Can you provide the logs for this crash?

can't unfortunately. it was a not responding crash as seen in the screenshot rather than a haxe crash, so it didn't generate a crash log file
i suppose that'd be more of a freeze than a crash but i use those two interchangeably so i'm not too sure

I was not able to reproduce this bug. Feel free to reopen this issue if it persists in 1.1 (and please give logs/crash report)


opening project

We have written the needed data into your clipboard because it was too large to send. Please paste.
Issue Type: Performance Issue
I clicked the folder which i want to open in visual studio but it can't show in vs code
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:34:32.027Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz (8 x 2112)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.83GB (3.14GB free)

Process Argv
--crash-reporter-id 3cb5186d-5fe9-40a4-a63e-d8390301417e

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    1	   103	 13360	code main
    0	    12	  2100	   crashpad-handler
    1	    60	  8616	   window (Issue Reporter)
    1	   190	 12284	   gpu-process
    0	    24	 16016	   utility
    0	    65	 16404	   shared-process
    0	   135	 18108	   window (playground - Visual Studio Code)
    0	    30	  9304	     searchService
    0	    68	  9408	     extensionHost
    0	    16	  4024	       c:\Users\vivek\.vscode\extensions\tabnine.tabnine-vscode-3.1.12\binaries/3.2.22/x86_64-pc-windows-gnu/TabNine.exe --client=vscode --no-lsp=true --client-metadata clientVersion=1.51.1 pluginVersion=3.1.12 t9-vscode-AutoImportEnabled=true t9-vscode-TSAutoImportEnabled=true t9-vscode-JSAutoImportEnabled=true vscode-remote=false vscode-remote-name=undefined vscode-extension-kind=1 ide-restart-counter=0
    0	    12	  4180	         "c:\Users\vivek\.vscode\extensions\tabnine.tabnine-vscode-3.1.12\binaries/3.2.22/x86_64-pc-windows-gnu/TabNine.exe" --client=vscode --no-lsp=true --client-metadata clientVersion=1.51.1 pluginVersion=3.1.12 t9-vscode-AutoImportEnabled=true t9-vscode-TSAutoImportEnabled=true t9-vscode-JSAutoImportEnabled=true vscode-remote=false vscode-remote-name=undefined vscode-extension-kind=1 ide-restart-counter=0 --no_bootstrap
    0	   500	  9816	           "c:\Users\vivek\.vscode\extensions\tabnine.tabnine-vscode-3.1.12\binaries/3.2.22/x86_64-pc-windows-gnu/TabNine.exe" --client=vscode --no-lsp=true --client-metadata clientVersion=1.51.1 pluginVersion=3.1.12 t9-vscode-AutoImportEnabled=true t9-vscode-TSAutoImportEnabled=true t9-vscode-JSAutoImportEnabled=true vscode-remote=false vscode-remote-name=undefined vscode-extension-kind=1 ide-restart-counter=0 --no_bootstrap --inner
    0	    11	 17604	         console-window-host (Windows internal process)
    0	    25	 12444	       "C:\Users\vivek\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\vivek\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\node\jsonServerMain" --node-ipc --clientProcessId=9408
    0	    11	 12352	     watcherService
    0	    11	 17716	       console-window-host (Windows internal process)

Workspace Info
|  Window (playground - Visual Studio Code)
|    Folder (playground): 6 files
|      File types: js(5) json(1)
|      Conf files:;

Extensions (2)

Extension
Author (truncated)
Version

LiveServer
rit
5.6.1

tabnine-vscode
Tab
3.1.12

having the same issue in MacOS Big Sur 11.0.1

I clicked the folder which i want to open

Where did you do this? Windows Explorer? Somewhere else?

having the same issue in MacOS Big Sur 11.0.1

Turns out I had a full screen vs code window open and for some reason that was causing new windows to open with no project even though I was opening them from the terminal, and going through the open file dialog caused a no-op
exiting from my full screen session and restarting fixed it for me.


[Question] Why is there Polymer.Base.set/notifyPath?

I wonder why these are used to set values to paths?
I understand that these methods are supposed to fire property-changed events to notify elements that something changed.
But isn't this what Object.observe is for?

Polymer 1.0 doesn't use Object.observe. Both native Object.observe and the Object.observe polyfill had performance issues under different circumstances.

Thanks.


php-local file name encoding

I'm using php-local and discovered some problems with file name encoding.
i use this demo (   ) can type a Chinese characters for  Folder name  ,but using php-local,  it say " Folder creation failed" and it also can't list the file it contain the Chinese characters.please help. Thank you !

Hi @ampmBIG5, can you please post any PHP error logs? I'll take a look at the code later, but I remember this was working correctly.


package.json of jest-environment-jsdom is't same as that in npm registry

Do you want to request a feature or report a bug?
report a bug
What is the current behavior?
pcakage.json file of jest-environment-jsdom installed from npm registry is.
 {
  "name": "jest-environment-jsdom",
  "version": "21.2.1",
  "repository": {
    "type": "git",
    "url": "https://github.com/facebook/jest.git"
  },
  "license": "MIT",
  "main": "build/index.js",
  "dependencies": {
    "jest-mock": "^21.2.0",
    "jest-util": "^21.2.1",

    // look at this
    "jsdom": "^9.12.0"
  }
}

but in github source
"jsdom": "^11.4.0"
If the current behavior is a bug, please provide the steps to reproduce and
either a repl.it demo through https://repl.it/languages/jest or a minimal
repository on GitHub that we can yarn install and yarn test.
What is the expected behavior?
please upgrade jsdom  in npm registty
Please provide your exact Jest configuration and mention your Jest, node,
yarn/npm version and operating system.

Feel free to install<EMAIL_ADDRESS>which comes with the latest version of jsdom.


funds-manager: Use dummy key for arbitrum client

Purpose
This PR updates the CLI in two ways:

Allows each config entry to be set by an environment variable. This will make it easier to deploy the funds-manager via terraform.
Removes the Arbitrum private key argument. We don't need a private key for any arbitrum client operations, so instead we use a dummy key -- the master key used in nitro dev nodes.

Testing

Ran the funds manager with the dummy key and environment variables

Won't we need a keypair soon enough to manage a hot wallet? can just leave the CLI arg and default to this for devex

We can add it back when we need it


CLI should support aggregated catalog operation

By specification Service Manager supports https://github.com/Peripli/specification/blob/master/api.md#aggregated-catalog
Add CLI command to list aggregated catalog

no longer relevant, api is removed


Method to trigger catalog container refresh

Feature Request
Is your feature request related to a problem? Please describe.
When we build an updated catalog image, we typically want to test against it immediately. Currently, that means manually bouncing the catalog pod.
Describe the solution you'd like
I'd like the build process to be able to trigger the catalog operator to check for a new image or perhaps just invalidate the current pod and force the creation of a new catalog pod.
I imagine that is an API endpoint I could hit or perhaps modifying the CatalogSource to set up a 'spec.refresh: true' item that it would remove as soon as it gets a new catalog built.

Rather sad to seeing this going stale.

I'm still interested in this.

Started discussion on Slack:
https://kubernetes.slack.com/archives/CAW0GV7A5/p1603113023166700

Evan Cordell pointed out on slack that simply changing the CatalogSource's image ref would serve the purpose using existing capability just fine.


R Interactive hangs on reset

Please briefly describe what you were doing that led to the issue, if applicable:

load a data.frame

inspect it with head()

reset R interactive from the ribbon

variable name still exists in .GlobalEnv, but the variable does not

head() hangs

The variable still appears in the Variable Explorer, but cannot be inspected.
>  ls()
character(0)
If you have any screenshots demonstrating the issue, please include them as well to help us diagnose it better.
Additional information:
Additional resets appear to clear the problem.
OS Information
Version:       Microsoft Windows NT 6.3.9600.0
RTVS Information:
Assembly: Microsoft.VisualStudio.R.Package, Version=0.3.20418.1523, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
R Install path:
C:\Program Files\Microsoft\MRO\R-3.2.4

Thanks for reporting it! Most likely, this is the same issue as in #1629. Would you be interested in testing the fix? If so, please ping me at<EMAIL_ADDRESS>

We have now shipped RTVS 0.4, which contains the likely fix for this issue. If you have had a chance to try it out, could you share your experience? Are you still running into this problem?

0.3 I think :-)

I'll close this for now - please reopen if it still repros.


ci: update github-actions

actions/checkout 2 -> 3
actions/download-artifact 2 -> 3
actions/upload-artifact 2 -> 3
imjonbo/issue-bot 2 -> 3

This fixes on-target CI.  The self-hosted runner updated and removed node v12, because it is EOL and no longer receiving security updates.

actions changes do not break anything, they just update node.
issue-bot has breaking changes, but I do not think they apply: release notes

r? @thalesfragoso
(rust-highfive has picked a reviewer for you, use r? to override)


Added a failing test for PyQT plotting (passes <0.1.7, fails at later versions).

Includes a self contained test for #769.
Includes all the changes from #770.
@jenshnielsen I did not know how to make this PR clean into your branch as there are many forks.
Very important note, I have tested that this test passes on the 0.1.7 version of QCoDeS but not on the more recent update.

            Args:

                startranges: The plot can automatically infer the full ranges
                             array parameters. However it has no knowledge of the
                             ranges or regular parameters. You can explicitly pass
                             in the values here as a dict of the form
                             {'paramtername': {max: value, min:value}}
            """
        axismapping = {'x': 'bottom',
                       'y': 'left'}
        standardunits = self.standardunits
        for i, plot in enumerate(self.subplots):
            # make a dict mapping axis labels to axis positions
            for axis in ('x', 'y', 'z'):
>               if self.traces[i]['config'].get(axis):
E               ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

qcodes/plots/pyqtgraph.py:529: ValueError
============================== 1 failed, 2 passed in 7.86 seconds ==============================

As a separate additon I've put the Travis.Yaml file we use for PycQED that allows testing pyqtgraph plotting in the online builds (so that we can get rid of the @skipif statements).
language: python
notifications:
  email: true

cache: pip

python:
  - "3.6"

env:
    - TRAVISCI=true PYTHON=3.6

before_install:
    - if [ ${TRAVIS_PYTHON_VERSION:0:1} == "2" ]; then wget http://repo.continuum.io/miniconda/Miniconda-3.5.5-Linux-x86_64.sh -O miniconda.sh; else wget http://repo.continuum.io/miniconda/Miniconda3-3.5.5-Linux-x86_64.sh -O miniconda.sh; fi
    - chmod +x miniconda.sh
    - ./miniconda.sh -b -p /home/travis/mc
    - export PATH=/home/travis/mc/bin:$PATH

# command to install dependencies
install:
    - export GIT_FULL_HASH=`git rev-parse HEAD`
    - conda update conda --yes
    - conda create -n test_env python=${PYTHON} --yes
    - source activate test_env
    - conda install numpy scipy pyopengl pytest flake8 six coverage matplotlib --yes
    - conda install -c bioconda pygraphviz --yes
    - conda install cython --yes
    - conda install pyqt --yes;

    - pip install --upgrade pip
    - pip install -r requirements.txt
    - pip install git+git://github.com/DiCarloLab-Delft/Qcodes.git
    - pip install coverage pytest-cov pytest --upgrade
    - pip install codacy-coverage
    - echo ${QT}
    - echo ${TEST}
    - echo ${PYTHON}
    - pip install -e .

before_script: # configure a headless display to test plot generation
- "export DISPLAY=:99.0"
- "sh -e /etc/init.d/xvfb start"
- sleep 3 # give xvfb some time to start

# command to run tests
script:
    - py.test pycqed/tests --cov=pycqed --cov-report xml --cov-config=.coveragerc

after_success:
    - pip install codacy-coverage
    - python-codacy-coverage -r coverage.xml

@AdriaanRol Thanks I just pushed a fix to get the tests passing locally. Thanks for the Travis script. It's been on my list but I haven't gotten around to do it yet. I will add that as a new PR

@jenshnielsen , I haven't run your updated code but I'm wondering do the correct units get displayed now (as they are clearly not None).

The scaling code will do nothing as as the trace data structure is completely different from the one defined by the loop but it will not crash

@jenshnielsen , I guess I'll have to check it out then.
It would be to bad though as this is something that previously worked fine (at least for us) and would then be broken upon updating.

I don't think it's broken but the new functionality will just do exactly nothing for you as it cant find the units and labels of your plot it can't update them

@jenshnielsen I guess then my question is, will it find it if I give it as arguments to the plot function as it is in the example test I made? (I would assume it does).


Update app-insights-javascript.md

Added an escape backslash in Shared_Layout.cshtml as it showed up as Shared_Layout.cshtml

Hi @KvdM, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;


Speckle ETABS requirements (Rey's braindump)

Further requirements

[x] #813
[x] #793
[x] #794
[ ] Analysis results to other structural software
[x] Unit Tests
[ ] #814
[x] Revit to ETABS

results viz in rhino is a workflow that needs to be explored more in-depth conceptually.  Need AT look from Arup on how ArupLA tools does this and feedback on how people want to visualize results in the viewer in general.
Analysis results to other structural software is not a feasible idea/smart idea. Results shouldn't be forced into other software.


Docker image for development

Development on such a project without a Docker image will be pot luck.

I'd love to see standard build envs for mbed.
I'm using https://github.com/aschmidt75/docker-mbed-cli-gcc-arm
but would appreciate a way supported by ARM.

@aschmidt75 are you attempting to take the Eclipse Che path?

I don't know about Eclipse's Che path, i'm just using containers for years now for this kind of build system helpers - works quite well.

adding to @loverdeg-ep and @davidhyman , on the IETF we are using the mbed cli to test what we call a suit manifest file. There are detailed notes about a couple of hackathons we have had and a common problem we identified is that newcomers need a lot of time to get started with their environment. We found it could be very useful to have an isolated environment using docker or nix.

Thanks for the link @jaimejim
@screamerbg Requirement or not, we certainly have proof that it would be used.

Issue header has missing or incorrectly filled in fields! Please fix.

@BlackstoneEngineering please review my comments regarding Eclipse Che as well.
Our path internally is chasing Eclipse Che. It would provide a similar, even better solution than the Cloud 9 path that was taken in the past.
I want devs to be able to go as far as remote step debugging without installing a single tool on their computer.
Also seems like a natural progression for the work @thegecko is doing with Theia.

@SenRamakri / @theotherjimmy , i'm seeing a demand for a docker container from customers and developers in the wild. As we are about to engage in general installer updates / rework I would like to add getting an official mbed docker container with all the tools and compiler in it added to the list.

An official Docker image would also help with running a CI for mbed based products.

I agree with @loverdeg-ep and company that this would be an awesome tool to have!

help with running a CI for mbed based products.

My thoughts exactly.

docker pull jaim/mbed-cli

Could be useful for those who want to give it a try. The Dockerfile is on the repo.

@jaimejim you find a way to use the gdb client in the container for debug with an IDE running on the host machine?

https://www.arm.com/company/news/2019/04/docker-and-arm-partnership
We have our own but still waiting for something official...

Thank you for raising this issue. Please note we have updated our policies and
now only defects should be raised directly in GitHub. Going forward questions and
enhancements will be considered in our forums, https://forums.mbed.com/ . If this
issue is still relevant please re-raise it there.
This GitHub issue will now be closed.


[Bug]: The submit and reset button is missing in the Generate crud  insert modal

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The submit and reset button is missing in the Generate crud  insert modal

Steps To Reproduce

go to release.app.appsmith.com
open any application
click on + icon next to page
click on generate page
select any datasource
generate a new page and now once page is created
click on + icon on the table
inside the insert modal
the submit and rest button is missing as in attached screenshot

Public Sample App
No response
Environment
Release
Issue video log
No response
Version
v1.12

testing on release, I tested with the mock users datasource, and can see the buttons.
https://github.com/appsmithorg/appsmith/assets/94514895/8bf683c4-f169-4ebd-8faf-1558a0690dc3

Reducing the priority as it is a resolution issue

Bumping this issue up to prod because it should have made it's way there by now if it was not fixed

for the modals in crud gen apps, should we make the height more suitable for all screen sizes?


Language lookup, req.language and valid language mismatch

Describe the bug
It's a bit tricky and I hope I will describe this issue well. It is not a bug per se, but more an issue.
In the "Access current language section", it is said to use the following snippet to get the current language:
const currentLanguage = req ? req.language : i18n.language

The problem is req.language may not be a whitelisted/valid language. Having a look at i18next-express-middleware's code, req.language is set based on the user language, independently from what the valid languages of your app are:

https://github.com/i18next/i18next-express-middleware/blob/ea4989b183b31ad5bd58e7a6b71300f722f45cd5/src/index.js#L21
https://github.com/i18next/i18next-express-middleware/issues/139#issuecomment-342465691
https://github.com/i18next/react-i18next/issues/797#issuecomment-476073445

I would expect a way to get the first valid language in i18n.languages for the given req.language instead of using req.language directly, which may be en-US for example, when the app can just accept en due to load: languageOnly.
Occurs in next-i18next version
1.2.1
Steps to reproduce
Any setup, where xx-XX accept-language header is set before xx
Expected ~behaviour~ snippet
Any way to get the valid lang the page will be actually rendered with
Screenshots
If applicable, add screenshots or a GIF to help explain your problem.
OS (please complete the following information)

Device: MBP 2016 13'
Browser: Chrome (but reproducible with any browser

Additional context
n/a

Sure, feel free to submit a PR updating the docs. That's not a bug though - ultimately it's up to the end user to consume i18next in whatever way they feel is necessary.

cool, I'll have a deeper look at how to solve this issue 🤔

Quick question, is it normal that with:
{
  defaultLanguage: 'fr',
  otherLanguages: ['de', 'it']
}

I get preload: [ 'de', 'it', 'fr', 'fr-FR' ], server-side on some browser?

Not sure what you mean exactly, but the preload array is set here.


add jet primitives, refactor tests

Addresses #2431
Add rules for the following:

lax.bitwise_not (needed to defjvp_zero too)
lax.is_finite
lax.shift_left
lax.shift_right_arithmetic
lax.shift_right_logical
lax.bitcast_convert_type (no test)
lax.conj
lax.imag
lax.rem
lax.clamp
lax.max
lax.min

Tests for were modified from jnp -> lax in cases where the jnp primitive doesn't directly use the lax version (sign and round).
In particular, boolean operators from jnp don't use the lax versions at all! e.g. logical_and test passed without defining a jet rule for lax.and_p, it only needed a rule for lax.ne_p.
Added some special casing for primitives which don't take float as input based on lax_autodiff_test.py. It might make sense in the future to refactor the tests to use this always.
Refactor some jet rules to use def_comp, and add more special cases for integer_pow for efficiency.

@googlebot I consent.


C#: Extract the metadata handle

This is a fix for the rather unsatisfactory getLabel() solution we use when matching C# and CIL types/methods etc. Instead, populate a metadata_handle/3 extensional which records the metadata handle (a unique integer in an assembly) for each extracted entity in both the CIL and C# extractors.
The pair (assembly, handle) can be used to uniquely and efficiently identify the corresponding C#/CIL method.
The dbstats are needed to ensure the suitable join order (handle,assembly).
Note that #29460 on Semmle/code is needed to bump the db and submodule.

This pull request introduces 1 alert when merging 74945bd0ba915f844ebfc4aa89b94b0dcb9dee80 into 044dcfbf66a26c8adc6cc86158a9b376eb0d4e8e - view on LGTM.com
new alerts:

1 for Missed 'readonly' opportunity

Comment posted by LGTM.com


Add unifyai.py file to add to repo

Unify LM module ready to integrate into the repository

I can not merge it because of the test fails... must try in another way


fix: firestore pagination issue

Description
As per the documentation the where clause must always come before the order by clause, and the startAfter clause must come after the order by clause i.e the recommended order : where clause --> order by --> start after. However, the way code was written it applies the where clause after the startAfter i.e as per the code : order by --> start after --> where clause .
In this PR, we change the logic to make sure we follow the order where clause -> order by and startAfter / endBefore when generating query.
Fixes https://github.com/appsmithorg/appsmith/issues/32604
documentation link. - https://firebase.google.com/docs/firestore/query-data/query-cursors
Changes were taken from the PR created by @sumitsum here https://github.com/appsmithorg/appsmith-ee/pull/4001
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8814737910
Commit: 4c7ed97cc1808a537d40682fc0e930cd0e30be70
Cypress dashboard url: Click here!

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

Refactor

Improved the order of operations in Firestore queries to enhance query performance and reliability.

/build-deploy-preview skip-tests=true

Tested the functionality on dp, and everything looks good except for the test cases.

Unit test will be added in the upcoming PR. We can goahead with the change here.

Unit test will be added in the upcoming PR. We can goahead with the change here.

@rishabhrathod01 since this initially originated from an a-force query and it is a production issue, we can go ahead with the fix and raise a separate PR for test cases.


add example of how to use spin registry push in CLI help text

Example:
spin registry push michellenoorali/spin-hello-world:0.1.0

It took me a while to figure out what reference should be. An example in the CLI help text would have made things a little clearer.

This should now be addressed by https://github.com/fermyon/spin/pull/2135 😄

Thank you @ogghead !


Running a group with -E should exclude that check from the run

Right now prowler ignores the -g argument and continues to run every check excluding the check specified in the -E argument

I still find this to be the case with latest version of docker image.

can you please confirm that you are using the latest version? https://hub.docker.com/r/toniblyx/prowler/builds

This is strange, but a docker pull toniblyx/prowler:latest is bringing an image that was created 3 months ago... Its digest does however match what docker hub says was last updated 12 hours ago though: f7e27058b6defdfdee61ac0dd010918f158d8dabfa63bf3b2906ee7bf466dae5. When looking at the files inside the image I can see that recent changes are missing, so this image tag is definitely not up to date. For example this file added 2 days ago is missing: https://github.com/toniblyx/prowler/blob/master/checks/check_extra761
I have tried removing the image and pulling once again, still the same...

$ docker pull toniblyx/prowler:latest
latest: Pulling from toniblyx/prowler
e7c96db7181b: Already exists
a355bbeeb7bb: Pull complete
Digest: sha256:f7e27058b6defdfdee61ac0dd010918f158d8dabfa63bf3b2906ee7bf466dae5
Status: Downloaded newer image for toniblyx/prowler:latest
docker.io/toniblyx/prowler:latest

$ docker run --entrypoint=/bin/bash --rm -it toniblyx/prowler:latest
Unable to find image 'toniblyx/prowler:latest' locally
latest: Pulling from toniblyx/prowler
e7c96db7181b: Already exists
a355bbeeb7bb: Pull complete
Digest: sha256:f7e27058b6defdfdee61ac0dd010918f158d8dabfa63bf3b2906ee7bf466dae5
Status: Downloaded newer image for toniblyx/prowler:latest
bash-4.4$ ls -la /prowler/checks/check_extra76*
-rw-r--r--    1 prowler  root          1538 Jul  4 08:39 /prowler/checks/check_extra76
-rw-r--r--    1 prowler  root          2720 Jul  4 08:39 /prowler/checks/check_extra760

To me it looks like the codebase is not being freshly cloned wherever the docker image is being built

Oh of course - you see on your Dockerfile you are cloning the repo - now that will get cached once and never run again as docker has no way to know that the git clone command will result in a different outcome - https://github.com/toniblyx/prowler/blob/master/util/Dockerfile#L11
I suppose the Dockerfile should be changes to do an ADD . /prowler instead of cloning - that way you are guaranteed to get new images when the code changes.

I have opened a PR for it. Now I have found another bug, which is actually related to this issue: while the group argument (-g) is now being respected, only the first check in the comma separated exclusion argument is being respected. (for example -g cislevel1 -E check120,check25 results in check 120 being ignored, but not check 25)

And a separate PR to actually fix this issue described above.


feat(db): separate ledger/protocol_param logic from collections

I want to merge #678 first, to not delay it any further.


Check if there is a setting to auto delete branches on merge

There is:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-the-automatic-deletion-of-branches


Any way to improve the computational speed of the linalg.symeig() function?

Is your feature request related to a problem? Please describe.
Yes. My general goal is to inversely determine the material parameters of a finite element model. The algorithm includes solving the eigenproblem posed by the mass and stiffness matrices of the finite element model. The overall steps are something like

material_parameters = neural_network_model(inputs)
Kmatrix, Mmatrix = assemble(mesh, material_parameters)
eigen_solution = xitorch.linalg.symeig(A=Kmat, neig=100, M=Mmat)
loss = loss_function(eigen_solution)
loss.backward()

The above algorithm with xitorch works flawlessly. The only issue is that once the problem size is non-trivial (with more than 10,000 degrees of freedom), it takes too long to solve the eigenproblem (~ 3min) that training becomes impractical. I noticed that the solution speed is independent of the number of requested eigenpairs.
Describe the solution you'd like
I wonder if it's possible to speed up the eigen solution since I only need a few of the lowest eigenpairs. The matrices in the finite element system are very sparse. However, I noticed that they are converted back when used to solve the eigenproblem.
Describe alternatives you've considered
Right now, the only eigen solution package that I found that supports both general eigenproblem and backward is the xitorch.linalg.symeig() (so many thanks for this amazing work!). The eigen solver in the scipy package is fast for a subset of eigenpairs, but it doesn't support backward().
Additional context
I'm not familiar with the eigen solution algorithms, but any suggestion is appreciated. And thank you again for this amazing work!

Thanks for raising the issue. If you don't specify your symeig method, it will be defaulted to exact eigendecomposition, i.e. using the algorithm below: https://github.com/xitorch/xitorch/blob/aaee1ed17de65b614484cf51a312e1530a705ace/xitorch/_impls/linalg/symeig.py#L27-L44
Where it basically computes all the eigenvalues and just keep 100 of them.
There is another algorithm we implemented which is davidson, but not being used extensively, so it might fail.
You can try it by specifying xitorch.linalg.symeig(..., method="davidson").
If Davidson's method does not work, another option is to implement LOBPCG method, which we might be able to implement.

@mfkasim1 Thank you for the quick response! I did try to use the "davidson" method. However, the performance since to be much worse than the default method out of the box. For a matrix size of 4500x4500, the default method took about 8 seconds, while the "davidson" method took close to 10 minutes. I also noticed much higher CPU load when using the "davidson" method. I wonder if there's any tweaking that I can do to this method to make it faster...
For the LOBPCG method, do you think it can reach performance on par with packages like scipy, especially for sparse matrices? I'm curious if you have any plans to implement it "soon" ... I hope I could attempt to do it myself, but I assume it must be very difficult for someone who doesn't know the internals of PyTorch and is not very math-savvy.


Dynamic track endpoint

With the new different streams, we can add the capability to client send the url to be tracked and processed - i.e. /track/youtube.com%"Fwatch?v=.... It should be fairly simple in the frontends. rust frontend can have the url as parameter. This can remove links config.

for server, app_state can keep which links are currently requested by clients and start tasks on demand instead of a fix list in the startup.
Can keep a last_read field to stop processing streams which are no longer requested by any client (5-10 mins timeout). This makes server worker finish jobs. if websockets are implemented in the future, we can know if a client drops from the event so no timeout is necessary, we can basically keep a counted reference.
We may need server worker for each image-proc instead since we don't have a fixed pool of tasks from the beginning.
First track request of a track can be slow - need to test how quick the system can get that in place.

(i.e. flutter, seed, cli and standalone cli)

[x] server implementation with actix-web url dispatch and new dynamic follow mechanism #395
[x] rust frontend changes #395

Closing to rest of the client changes for #397


Tenant owner can list the namespace not managed by Capsule

Bug description
As a Tenant Owner I am able to list the namespace not managed by Capsule.
How to reproduce
Create a Tenant oil as a cluster admin
apiVersion: capsule.clastix.io/v1beta2
kind: Tenant
metadata:
  name: oil
spec:
  owners:
  - name: alice
    kind: User

Create a namespace db as a cluster admin
kubectl create ns db
kubectl label ns name=db

Create a RoleBinding admin as a cluster admin
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  name: admin
  namespace: db
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: admin
subjects:
- apiGroup: rbac.authorization.k8s.io
  kind: User
  name: alice

Note: Issue is not tied to any Role you can refer any Role or ClusterRole in the RoleBinding but in subject user needs to be Alice.
Create a namespace oil-frontend as a Alice user
kubectl create ns oil-frontend

List the namespace as a Alice user
kubectl get ns

NAME           STATUS   AGE
db             Active   3h
oil-frontend   Active   1h

Expected behaviour
As a Tenant owner I should only see the namespaces managed by Capsule. In the above e.g. only oil-frontend should be listed.
Additional context

Helm Chart version: v0.4.2

@prometherion I can work on this issue. I have debugged this issue and found the root cause.
capsule-proxy cached the RoleBindings using RoleBindingReflector to get the mapping of user and namespaces and then set the  label selector in the request to show only those namespaces which belongs to that user. I think the issue here is capsule-proxy cached all the RoleBindings present in the cluster.
As the purpose of RoleBindingReflector is to get the mapping of user and a capsule managed namespace it should only cache the RoleBinding created by Capsule.
The fix for this issue is in two places:

Capsule controller will add default label let say capsule.clastix.io/managed-by: capsule to a capsule-<tenant_name>-0-admin RoleBinding when syncing the RoleBindings. This RoleBinding is created by default in the namespace managed by Capsule.
RoleBindingReflector will use label selector instead of fields.Everything() while creating watcher in the capsule-proxy.

optionsModifier := func(options *metav1.ListOptions) {
     options.LabelSelector = "capsule.clastix.io/managed-by: capsule"
}
watcher := cache.NewFilteredListWatchFromClient(clientset.RbacV1().RESTClient(), "rolebindings", "", optionsModifier)

In this way only Capsule managed RoleBindings are cached.
Please provide the feedback on the root cause and the proposed solution.

Hi @sagar-jadhav
It’s not a bug, it is a feature that was added in https://github.com/clastix/capsule-proxy/issues/149
The main idea behind this feature was following: if a person had permissions in any namespace (it doesn’t actually matters if is managed by capsule or not), it means that this permission was explicitly granted for him and he should be able to see this namespaces using namespace list operation (because he already have some permissions it makes no sense to hide it)
One of the use cases for this feature would be, for example, allowing tenant admins from all cluster tenants to have permissions only for reading logs on a shared ingress located in some other namespace (which can be an another tenant or standalone namespace)

Thanks for the prompt response, Max!
The role binding reflector has been implemented by Max prior to the introduction of a capsule-proxy specific CustomResourceDefinition, such as the ProxySetting resource.
My idea is, in the longer term, to drop the role-binding reflector since it's hard-coded to the admin role (that could be misleading, it depends) since the purpose of the ProxySetting custom resource definition.
If this is blocking you, we introduced a new flag that is "disabling" the role binding reflector and relies only on the remote state of the Kubernetes cluster, bypassing the cache, such as the --disable-caching flag: it has been designed for a different purpose (#266) but it can work for you.

Closing, also considering that discussion about the role binding reflector deprecation has started with #268.


Release tag 2.1.0 missing

Readme lists 2.1.0 as the version, while the latest version in the repo is 2.0.1.

+1
gdrive version shows: gdrive: 2.0.1 however I was supposed to have downloaded the 2.1.0


documentation update to version 0.2.7

Coverage remained the same at 96.338% when pulling 0aaadeeedf85a78c9b1ef0763a5901b163171518 on documentation-update into 7acc07c184a153d5690b89b6d1f6c89f1cbdbd0f on master.


Does/how/when signs the gapi auth js client users in upon revisit?

After reading a lot on the gapi client for google authentication, I'm confused how gapi is handling my access/refresh tokens.
After implementing GAPI auth, it logs me in automatically every time I revisit.
I cannot find any documentation here about this behaviour...
I have three questions:

Is there any way to disable this?
Where does GAPI keep the access tokens?
When does GAPI check if there already was a user logged into the browser? (at gapi.load()?)

No. You can use gapi.auth2.authorize if you don't want such behavior.

In memory in the client app. It also caches the tokens issued in the IFrame opened.

At gapi.auth2.init().

Thank you for your explanation!


rename repo to NLog.Targets.Redis?

Maybe we should rename this repo to NLog.Targets.Redis
That's more transparant I think.
(note: github will create a redirect for NLog.redis then)

@gamingrobot is that a yes? ;)

Done!


XIVY-9722 Refresh iframe only refreshes the dialog and not the process

Replace the browser history with the current dialog url, so a refresh loads the dialog url in the iframe instead of restart the process

Before:

After:

@ivy-cst
https://developer.mozilla.org/en-US/docs/Web/API/History_API/Working_with_the_History_API?bla=true#the_replacestate_method seems to fix this problem :+1:


Ignore deprecation warning for NSURLConnection delegate method

This delegate method is causing a build failure with PCK.
Signed-off-by: John Foley<EMAIL_ADDRESS>

Looks good.  I just bumped the travis build (how is that still a thing?)

Thanks @mjstallard !