Discrete I/O control

I am currently discussing with @Bdelspi a way to control an electric gripper through ROS and from what I can tell, there has not been any IO control implemented in this driver. I am not aware of how this is implemented in other drivers, but I would imagine it would be as simple as creating a "gripper server" in the VAL 3 code listening on a certain socket. @gavanderhoorn am I on the right track here?

Related: #313

We don't necessarily need to use a different server task: the network decoding logic already switches based on packet id, and we have packet ids we could use for IO related functionality. That is, if we want to use simple message for this.
IIRC, Staublis have an XML-RPC server (I seem to remember SRS uses this, but I can't find any docs on it). If it does exist, does it allow access to the IO? If so, we could write a simple Python node that would wrap (a part of) the XML-RPC interface and expose ROS services (perhaps Actions) to toggle IOs, and we could publish IO state on topics.
If there is no XML-RPC (or other software-only interface), we could consider implementing support for (fi) the Motoman set of IO messages (See REP-I4 here for the IDs).

Reason I'm hesitant to add simple message support in staubli_val3_driver for this is because in my opinion I'd rather see people use a proper fieldbus. Something like Modbus TCP is relatively trivial to get working (on the PC side), and are typically well supported by ind robot mfgs.

I'm perfectly fine recommending the use of a fieldbus instead. In that case, I'd like to maybe see some tools included with the driver, I.E. a modbus configuration file for the controller and some kind of sample code for the PC side. Is that something typically included with other robot drivers, or is it normally left up to the user?

Is that something typically included with other robot drivers, or is it normally left up to the user?

It's not typically included with a robot driver as it's not really part of it.
A modbus configuration can be used with and without a(n industrial) robot. Additionally, there is almost no common configuration between use-cases: in the end the modbus library would be reading/writing coils. Mapping those to higher-level concepts (ie: opening/closing a gripper) is something completely defined by the application and/or integrator.

Having written this: I would not be opposed to creating an example configuration and then linking it from the driver's readme / documentation.
Having such an example would be very useful, as it would provide a starting point for users looking to set up something similar.
If you find something is specific to Staubli controllers in such a configuration/package @marshallpowell97, we could consider hosting it in this repository. But if there isn't, it would be better not to do that.

If you find something is specific to Staubli controllers in such a configuration/package @marshallpowell97, we could consider hosting it in this repository. But if there isn't, it would be better not to do that.

Both of our controllers (CS8/CS9) use an XML file for the Modbus configuration. I'm not sure if the format is specific to Staubli, but I can provide an example:
<?xml version="1.0" encoding="ISO-8859-1" standalone="yes"?> <TOPICSLIST> 	<TOPIC Name="Modbus" Card="0" Channel="0" Equipment="0" RefreshPeriod="200" Actif="1"> 		<MODULE Tag_name_root="Bit" IDModule="BOOLEAN" InputSize="" OutputSize="1"> 			<ITEM Name="mbItem1" Syntaxe="%Q0" Offset="0"/></MODULE> 		<MODULE Tag_name_root="Word" IDModule="WORD" InputSize="" OutputSize="0"> 			</MODULE> 	</TOPIC> 	<GENERAL_PARAMETERS TopicName="Modbus" TCP_Port="502" ConnectionNumber="2"/> </TOPICSLIST>

Having such an example would be very useful, as it would provide a starting point for users looking to set up something similar.

I agree.

+1 from me on adding/documenting modbus features. I tried implementing generic IO support but couldn't get it to work in the short amount of time I had access to a Stäubli. Only way later I discovered the Modbus/TCP interface and therefore used a ProfiNet Master Hilscher card to control the gripper.
For me it would also be interesting to have a generic interface for discrete IO. I think you @gavanderhoorn once mentioned this would need to be started with a discussion on discourse.ros.org right? Similar to the ones from reapp https://github.com/antonxy/industrial_core/blob/reapp/industrial_msgs/srv/IORead.srv

To move this forward: could you perhaps put together some sort of example of what you are thinking of @marshallpowell97?
We can then decide later where to host this.

For me it would also be interesting to have a generic interface for discrete IO. I think you @gavanderhoorn once mentioned this would need to be started with a discussion on discourse.ros.org right? Similar to the ones from reapp https://github.com/antonxy/industrial_core/blob/reapp/industrial_msgs/srv/IORead.srv

What I would like to see discussed a little is the ROS API itself. That's why I suggested posting on Discourse.

To move this forward: could you perhaps put together some sort of example of what you are thinking of @marshallpowell97?

Here is an example: IOControl.zip
modbus.xml is the configuration file for the modbus server on the controller which is configured for 2 inputs and 2 outputs (not used right now, but could potentially be useful).
IOControl.py is the python script to write to the inputs on the controller. The usage would be:
python IOControl.py  -i [ip address] -p [port] -o [output number] -v [value to write (true/false)]
I think this would require an "IO task" in the VAL 3 server to be monitoring the Modbus input and write that value to the correct output since it is not possible to directly link an input to and output (nor would it be desirable IMO). That would mean that the only "modifications" that the user would need to make would be linking a digital output variable to the correct physical output on the controller via the pendant.
For example, if a user wanted to use this to control the valves in the arm, they would need to:

Load modbus.xml onto the controller via FTP or USB and reboot
Link the digital output variable to valve1
Run IOControl.py with the correct parameters (wrapped in a ROS node? I'm not 100% what the correct implementation is here)

Hm. This is not completely what I had in mind.
My experience with modbus and staublis is limited. Do I understand you correctly when I say that it's impossible to configure the server such that it will allow writing to controller outputs directly?

Do I understand you correctly when I say that it's impossible to configure the server such that it will allow writing to controller outputs directly?

That's correct, unfortunately. From my understanding it's a safety concern.

@gavanderhoorn It turns out I was wrong about this and it IS possible to link an input to an output using dioLink(). Would that make it closer to what you had in mind?

If we can indeed configure modbus as you would normally do, then we could provide some reference configurations and perhaps even select a specific library / ROS package which we've verified works.
 If we gather a few and test them, we should select one or two and provide known-working configurations and .launch files.


scheduler:170] unknown project: test

11:21:40 scheduler:170] unknown project: test
test 是项目名
系统是 win7 32位
谢谢了,

这种问题去usergroup上问吧。

English please, how to reproduce this issue?

In my case, It seems the mysql can't respond at once,this issues shows while you start  or restart the project and then you reboot your machine.You need a good tunning of mysql when there is  a lot of blob stored in the mysql tables.And I still get another problem which the scheduler went died sometimes.

occurs on sqlite too.

same issue

Same issue
Clean setup - everything seems fine - but my projects are not recognized.
Neither with sqllite nor with MySQL.
Project record is stored in the database.
But not started.

same problem as longtengxp asked
11:21:40 scheduler:170] unknown project: test
any answer?

@longtengxp @ihipop


Fix data merge issue, releated to #628

Hello @PoisonAlien,
I create this PR to close #628. It indicates that there is a bug in current code for merging SNP location and Kataegis regions.
The following code test if the new code works for the issue and also reports consistent results as show case in current vignette.
Please go further take a review carefully.
# library(maftools)
devtools::load_all("~/Documents/GitHub/maftools/")
# the data is from #628
maf = data.table::fread("example.MAF")
mafobj <- read.maf(maf, vc_nonSyn = unique(maf$Variant_Classification))

#debug(rainfallPlot)
rainfallPlot(maf = mafobj, detectChangePoints = TRUE, ref.build = "hg38", savePlot = TRUE)

brca <- system.file("extdata", "brca.maf.gz", package = "maftools")
brca = read.maf(maf = brca, verbose = FALSE)
rainfallPlot(maf = brca, detectChangePoints = TRUE, pointSize = 0.4)

Best,
Shixiang

Hi @ShixiangWang ,
Thanks a ton for the PR. I had to modify it a bit since it was plotting arrowheads several times on top of each other. But your approach using foverlaps was a nice one.


Update the MI 4.1.0 migration docs

Description:
Update the MI 4.1.0 migration docs, which were in APIM 4.1.0, by cleaning up the MD files.

This is complete now.


Update site with MTGOTraders leaderboard prize info, buy deck, sponsorship info and logo

I have the logo in EPS but github doesn't like that.

I've added sponsorship and prize info.
Still need a buy a deck link and to use the logo (footer?)

Added logo to footer in 6e6514f6. Not adding buy a deck - let's give Cardhoarder primacy there because they are our biggest sponsor.


parser.Invoke/InvokeAsync doesn't exist, examples unclear

The default example ends in await rootCommand.InvokeAsync(args); as the Main method in the original sample is async.
In the 'customize help for a single option or argument' section though it's unclear where the new code goes, it seems to imply that it should replace the above line since it references the rootCommand as input to the CommandLineBuilder.
However, the final line contains parser.Invoke(args); which is invalid. The Parser class in the latest beta release only has a Parse method.
This also doesn't show how to then return the proper int result back to the main method from this new invocation?
Overall:

[ ] It's unclear what code to add/replace from the start example to get the full picture
[ ] The code given is incorrect against the latest beta it says it's for as it doesn't compile
[ ] The new code (assuming it was supposed to be replaced) doesn't show how to return the value again (it's also odd it's no longer async?)

[ ] The second example does show using an parser.InvokeAsync, but again that method doesn't exist.

[ ] The changing of the header example down below pulls in another dependency and doesn't show how to do something more simple like just add a few lines of text or something else...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 65b05a5b-736e-0c49-edff-fd736bd969cb
Version Independent ID: 7580e28c-776e-f479-54d7-adedd93f63a2
Content: How to customize help in System.CommandLine
Content Source: docs/standard/commandline/customize-help.md
Product: dotnet-fundamentals
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

@hawkerm, Thanks for reporting these issues - I'm adding the missing instructions in #30276.


Custom action keys/buttons are not saved

Operating system or device - Godot version:
3.0 master Linux
Steps to reproduce:

Create new action in project and attribute some keys/buttons to it
Save and close project
When reopening project all keys/buttons for action are gone

It's a regression from the removal of InputEvent as a built in type. When it was removed the serialization was removed and now it in VariantWriter::write it falls to the case of Variant::OBJECT that assumes a Resource with a path, InputEvent is not such a Resource so it emits null as a fallback.
I don't have time to fix this, just putting it here to make the life of whoever fixes this easier.

I'm currently taking a stab at this.  I have keyboard mapping working again.  I just need to implement and test the other input types.

I was just about to submit a pull request (see my branch here) when I discovered that @reduz probably sort of fixed this in his "Added .hdr format support" commit.  His approach serializes all object properties instead of hand selecting them.  Its more generic, but it also fills config files with a lot more cruft:
Old approach (used in my branch):
test=[
InputEvent(KEY65,C)
]

New:
[input]

test=[ Object(InputEventKey,"resource_local_to_scene":false,"resource_name":"","alt":false,"shift":false,"control":true,"meta":false,"command":true,"pressed":false,"scancode":65,"unicode":0,"echo":false,"script":null)
 ]

I can see this destroying the legibility of large input maps.
I attempted to test loading and saving input maps with his new approach, but I hit a couple of problems:

The new function "get_fallback_environment()" introduced in the hdr commit segfaulted when I saved the input map config, but it still wrote the input map to my project file (so thats probably a separate issue)
Attempting to start godot with the new config resulted in the error: "error: Expected property name as string"

Provided the new approach actually works, I like the idea of generically handling Variant:OBJECT and the more human readable shift/control/meta/alt (vs S/C/M/A).  But it would also be nice to preserve the terseness of the original format.

Some follow up:

The Object parser in variant_parser currently has the following issues:

It attempts to read the property name twice, which causes the parsing to error out.  removing the second get_token results in a successful parse
the output variable "value" is not being set after a successful parse

I fixed the problems in (1) and Object loading no longer fails, but the parsed InputEvent objects still aren't added to the input map because the conversion from Variant:OBJECT -> Ref<InputEvent> is failing (input_event.is_null() returns false).

I have verified that the type in "Object *obj = ClassDB::instance(type)"  is correct (InputEventKey, InputEventJoypadButton, etc).
I have also verified that Object's properties are being set to the correct values from the InputEvents.  ex: the Object property "scancode" is set to a Variant::INT with a value of 65

Does anyone have a clue what could be going wrong in the conversion?  I'm less familiar with that section of the code.

Varaint is one of the more horrible parts of Godot.
When creating a Variant from an Object* no Reference is created only the objData.obj is assigned and not objData.ref. When you cast to Ref it's assumed that for all objects a ref is valid (which is not the case).
You can also see the horrible const violation and notice that actually casting from\to object (from a technical C++ perspective) shouldn't be possible and only RefPtr should be since the value is the Ref and not the object.
<rant>
I actually tried to remove the Object conversion but then the code compiles but crashes randomly since Object has an implicit cast to bool (why?) and this causes the template magic to assume that all assignments from Object -> Variant should create a bool variant. This means it's impossible to have the compiler check and modify all the places that convert from\to Object.
</rant>

Ok I'm pretty sure everything is working now.  This line did the trick:
// value is the variant output variable from parse_value()
value = REF(obj->cast_to<Reference>());

Thanks for the assistance!  That last comment was hugely helpful.  I should have a pr out soon.


Emergency Reset Button.

This would reset all GPU settings back to default even of GPUs not currently plugged in. (I currently need this feature lol)
Other thing, what files would I have to edit to stop the crash of a bad OC on this GPU?

This is already a thing, it wipes all GPU configuration

Ok thank you :3


New i2c master driver issue: read blocks forever (IDFGH-11957)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.2 master branch
Espressif SoC revision.
ESP32 Rev1.0
Operating System used.
Windows
How did you build your project?
Command line with Make
If you are using Windows, please specify command line type.
PowerShell
Development Kit.
WEMOS LOLIN32 (ESP32 WROVER)
Power Supply used.
USB
What is the expected behavior?
example: read chip revision of BME280 => i2c_master_transmit_receive should deliver chip revision byte
What is the actual behavior?
i2c_master_transmit_receive blocks forever, regardless if a timeout value != -1 is specified
Steps to reproduce.
esp_err_t i2c_master_bus_read_byte(i2c_master_dev_handle_t dev_handle, uint8_t mem_address, uint8_t *data)
{
uint8_t buf[1] = {mem_address};
uint8_t buffer[1];
esp_err_t ret = i2c_master_transmit_receive(dev_handle, buf, 1, buffer, 1, CONFIG_I2C_TIMEOUT);
*data = buffer[0];
return ret;
}
void app_main(void)
{
i2c_master_bus_config_t conf = {
.i2c_port = -1,
.sda_io_num = GPIO_NUM_23,
.scl_io_num = GPIO_NUM_19,
.clk_source = I2C_CLK_SRC_DEFAULT,
.glitch_ignore_cnt = 7,
};
ESP_LOGI(LOGTAG, "MasterInit call new master bus");
i2c_master_bus_handle_t handle = NULL;
esp_err_t err = i2c_new_master_bus(&conf, &handle);
if (err != ESP_OK)
{
    ESP_LOGE(LOGTAG, "i2c new master failed:%d", err);
}
else if (i2c_master_probe(handle, 0x76, 10) == ESP_OK)
{
    ESP_LOGI(LOGTAG, "found device at $%02x", 0x76);

    i2c_master_dev_handle_t hDev = NULL;
    i2c_device_config_t cfg = {
        .dev_addr_length = I2C_ADDR_BIT_LEN_7,
        .device_address = 0x76,
        .scl_speed_hz = 400000,
    };

    err = i2c_master_bus_add_device(handle, &cfg, &hDev);
    if (err == ESP_OK)
    {
        ESP_LOGI(LOGTAG, "read chip revision of BM*280");
        uint8_t reg = 208;
        uint8_t data = 0;

        err = i2c_master_bus_read_byte(hDev, reg, &data);
        ESP_LOGI(LOGTAG, "receive: %d", err);
        if (err == ESP_OK)
            ESP_LOGI(LOGTAG, "Chip ID=%02x", data);
        else
            ESP_LOGE(LOGTAG, "failed %d", err);
    }

    // freigeben
    i2c_master_bus_rm_device(hDev);
}

Debug Logs.
I (333) i2c_master.c: #cmds=2, addr=$76, wait=1
I (333) i2c_master.c: 1) status=4
I (343) i2c_master.c: 2) status=4
I (343) i2c_master.c: op code=0 (read=2)
I (343) i2c_master.c: start end command...
I (353) i2c_master.c: ... done.
I (353) i2c_master.c: #cmds=1, addr=$76, wait=1
I (363) i2c_master.c: 1) status=4
I (363) i2c_master.c: 2) status=4
I (373) i2c_master.c: op code=3 (read=2)
I (373) i2c_master.c: start end command...
I (383) i2c_master.c: ... done.
I (383) i2c_master.c: master trans start ...
I (383) i2c_master.c: ... done.
I (393) i2c_master.c: waiting for trans_done done.
I (393) main: found device at $76
I (403) main: read chip revision of BM*280
I (403) i2c_master.c: #cmds=6, addr=$76, wait=10
I (413) i2c_master.c: 1) status=4
I (413) i2c_master.c: 2) status=4
I (423) i2c_master.c: op code=0 (read=2)
I (423) i2c_master.c: start end command...
I (433) i2c_master.c: ... done.
I (433) i2c_master.c: #cmds=5, addr=$76, wait=10
I (433) i2c_master.c: 1) status=4
I (443) i2c_master.c: 2) status=4
I (443) i2c_master.c: op code=1 (read=2)
I (453) i2c_master.c: write...
I (453) i2c_master.c: ... done.
I (453) i2c_master.c: #cmds=4, addr=$76, wait=10
I (463) i2c_master.c: 1) status=1
I (463) i2c_master.c: 2) status=1
I (473) i2c_master.c: op code=0 (read=2)
I (473) i2c_master.c: start end command...
I (483) i2c_master.c: ... done.
I (483) i2c_master.c: #cmds=3, addr=$76, wait=10
I (493) i2c_master.c: 1) status=1
I (493) i2c_master.c: 2) status=1
I (493) i2c_master.c: op code=2 (read=2)
I (503) i2c_master.c: read...
I (503) i2c_master.c: ... done.
I (513) i2c_master.c: #cmds=2, addr=$76, wait=10
I (513) i2c_master.c: 1) status=0
I (523) i2c_master.c: 2) status=0
I (523) i2c_master.c: op code=2 (read=2)
I (523) i2c_master.c: read...
I (533) i2c_master.c: ... done.
I (533) i2c_master.c: #cmds=1, addr=$76, wait=10
I (543) i2c_master.c: 1) status=0
I (543) i2c_master.c: 2) status=0
I (543) i2c_master.c: op code=3 (read=2)
I (553) i2c_master.c: start end command...
I (553) i2c_master.c: ... done.
I (563) i2c_master.c: master trans start ...

More Information.
I traced it down to function s_i2c_send_commands (i2c_master.c #423).     i2c_hal_master_trans_start(hal); never returns...

Yes, I already notice this. And it has been fixed internally. I think it will sync to github very quickly.

A quicker way if you want to try is to find s_i2c_read_command function. Copy-paste following code.
static bool s_i2c_read_command(i2c_master_bus_handle_t i2c_master, i2c_operation_t *i2c_operation, uint8_t *fifo_fill, BaseType_t *do_yield)
{
    i2c_master->async_break = false;
    const size_t remaining_bytes = i2c_operation->total_bytes - i2c_operation->bytes_used;
    const i2c_ll_hw_cmd_t hw_end_cmd = {
        .op_code = I2C_LL_CMD_END
    };
    i2c_hal_context_t *hal = &i2c_master->base->hal;
    i2c_bus_handle_t handle = i2c_master->base;
    i2c_ll_hw_cmd_t hw_cmd = i2c_operation->hw_cmd;

    *fifo_fill = MIN(remaining_bytes, SOC_I2C_FIFO_LEN - i2c_master->read_len_static);
    i2c_master->rx_cnt = *fifo_fill;
    hw_cmd.byte_num = *fifo_fill;

    i2c_master->contains_read = true;
#if !SOC_I2C_STOP_INDEPENDENT
    if (remaining_bytes < SOC_I2C_FIFO_LEN - 1) {
        if (i2c_operation->hw_cmd.ack_val == ACK_VAL) {
            if (remaining_bytes != 0) {
                i2c_ll_master_write_cmd_reg(hal->dev, hw_cmd, i2c_master->cmd_idx);
                i2c_master->read_len_static = i2c_master->rx_cnt;
                i2c_master->cmd_idx++;
            }
            i2c_master->read_buf_pos = i2c_master->trans_idx;
        } else {
            i2c_ll_master_write_cmd_reg(hal->dev, hw_cmd, i2c_master->cmd_idx);
            i2c_master->cmd_idx++;
        }
        i2c_master->trans_idx++;
        i2c_master->i2c_trans.cmd_count--;
        if (i2c_master->async_trans == false) {
            if (xPortInIsrContext()) {
                xSemaphoreGiveFromISR(i2c_master->cmd_semphr, do_yield);
            } else {
                xSemaphoreGive(i2c_master->cmd_semphr);
            }
        }
    } else {
        atomic_store(&i2c_master->status, I2C_STATUS_READ);
        portENTER_CRITICAL_SAFE(&handle->spinlock);
        i2c_ll_master_write_cmd_reg(hal->dev, hw_cmd, i2c_master->cmd_idx);
        i2c_ll_master_write_cmd_reg(hal->dev, hw_end_cmd, i2c_master->cmd_idx + 1);
        if (i2c_master->async_trans == false) {
            i2c_hal_master_trans_start(hal);
        } else {
            i2c_master->async_break = true;
        }
        portEXIT_CRITICAL_SAFE(&handle->spinlock);
    }
#else
    portENTER_CRITICAL_SAFE(&handle->spinlock);
    // If the read command work with ack_val, but no bytes to read, we skip
    // this command, and run next command directly.
    if (hw_cmd.ack_val == ACK_VAL) {
        if (i2c_operation->total_bytes == 0) {
            i2c_master->trans_idx++;
            hw_cmd = i2c_master->i2c_trans.ops[i2c_master->trans_idx].hw_cmd;
            i2c_master->i2c_trans.cmd_count--;
        }
    }
    i2c_ll_master_write_cmd_reg(hal->dev, hw_cmd, i2c_master->cmd_idx);
    i2c_ll_master_write_cmd_reg(hal->dev, hw_end_cmd, i2c_master->cmd_idx + 1);
    portEXIT_CRITICAL_SAFE(&handle->spinlock);
    i2c_master->status = I2C_STATUS_READ;
    portENTER_CRITICAL_SAFE(&handle->spinlock);
    if (i2c_master->async_trans == false) {
        i2c_hal_master_trans_start(hal);
    } else {
        i2c_master->async_break = true;
    }
    portEXIT_CRITICAL_SAFE(&handle->spinlock);
#endif

    return i2c_master->async_break;
}

Thx, that does the job! :)


Hotfix fragment not working

Need to do more explicit test, fails if hideHeader
is undefined
Logical conjunction tries to evaluate possibly undefined key hideHeader
Using ternary operator to test if feature flag is enabled first.

Also consider changing pageConfig.hideHeader to pageConfig?.hideHeader


[GOBBLIN-1012] Implement CompactionWithWatermarkSuite

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title.

https://issues.apache.org/jira/browse/GOBBLIN-1012

Description

[x] Here are some details about my PR:
A compactionWatermark is a timestamp indicating the data we've seen up to that time is compacted. If we explicitly checked that we've seen all the data up to that time, the timestamp would be published also as completionAndCompactionWatermark.
CompactionWithWatermarkSuite reports compaction watermarks as part of the compaction pipeline and publishes watermarks as hive table properties

Tests

[x] My PR adds the following unit tests:
CompactionWatermarkCheckerTest covers that compaction watermark time is computed and set to task state correctly
CompactionWatermarkActionTest covers that compaction watermarks are updated in hive table parameters

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2857 into master will decrease coverage by 41.61%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #2857       +/-   ##
============================================
- Coverage     45.72%    4.1%   -41.62%
+ Complexity     9085     747     -8338
============================================
  Files          1913    1917        +4
  Lines         72021   72127      +106
  Branches       7943    7955       +12
============================================
- Hits          32929    2961    -29968
- Misses        36074   68847    +32773
+ Partials       3018     319     -2699

Impacted Files
Coverage Δ
Complexity Δ

...ion/suite/CompactionWithWatermarkSuiteFactory.java
0% <0%> (ø)
0 <0> (?)

...compaction/suite/CompactionWithWatermarkSuite.java
0% <0%> (ø)
0 <0> (?)

...n/compaction/action/CompactionWatermarkAction.java
0% <0%> (ø)
0 <0> (?)

.../compaction/verify/CompactionWatermarkChecker.java
0% <0%> (ø)
0 <0> (?)

...n/converter/AvroStringFieldDecryptorConverter.java
0% <0%> (-100%)
0% <0%> (-2%)

...he/gobblin/cluster/TaskRunnerSuiteThreadModel.java
0% <0%> (-100%)
0% <0%> (-5%)

...n/mapreduce/avro/AvroKeyCompactorOutputFormat.java
0% <0%> (-100%)
0% <0%> (-3%)

...apache/gobblin/fork/CopyNotSupportedException.java
0% <0%> (-100%)
0% <0%> (-1%)

.../gobblin/kafka/writer/KafkaWriterCommonConfig.java
0% <0%> (-100%)
0% <0%> (-7%)

...ker/task/TaskLevelPolicyCheckerBuilderFactory.java
0% <0%> (-100%)
0% <0%> (-2%)

... and 1116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4483268...f9a1fae. Read the comment docs.


PZ69 support for radio presets

It would also be great if the software could detect whether or not you've selected preset channels for a given radio, and allow you to select between them.

Do you refer to DCS-BIOS or SRS?

Specifically, using the flight panels through SRS. My squadron uses presets heavily for intra-flight comms, CTAF, etc. It would be useful if SimpleRadio could tell when the knob for UHF/VHF radios are set to use preset instead of manual, and view and allow changing which preset is being selected (rather than just adjusting the manual frequency).

Hmm, I have to check that. It should be that if you have presets selected in SRS, DCSFP should then up/down these, not frequencies.

Are you referring to FC3 modules now, using SRS? Because when it is a DCS-BIOS module it is not possible at the moment. I found a bug in DCSFP SRS code.
If you were in SRS PRESET mode and turned the small radio dial SRS switched over to using FREQ. This I have fixed.

Created a release with this fix + others.

I'm unfamiliar with the SRS presets you're talking about—we may be referring to the same thing or speaking past one-another.
I primarily fly the A-10C, and the VHF/UHF radios can either use manually-set frequencies or use preprogrammed frequencies via a separate dial. I'd like the software to detect when a given radio is in manual or preset mode. In manual mode it should work as it does currently, but when in preset mode the panels should show the current preset (e.g., 3) and allow cycling the preset knob up or down.
I'll test this release and see if it does what I'm hoping for :)

OK, then it isn't working at the moment (A-10C). But is doable and sensible. I'll have a look at the DCS-BIOS profile for this.

It seems that it is these controls that shows whether the radio is in PRESET:
VHFFM_FREQEMER
VHFAM_FREQEMER
UHF_MODE
and these controls holds the channel:
VHFAM_PRESET
VHFFM_PRESET
UHF_PRESET_SEL
I'll fix this.

You can check the latest release.

Thanks for all your hard work!


Rust: Add pre-development stub

What would you like to be added?
A rust version of the collatz package
Why is this needed?
No module is complete without a rust version.
Implementation Language
No response

I'd be happy to consider adding one; although a package with the "collatz" name already seems to exist -- https://crates.io/crates/collatz, that didn't stop the C# or npm from being added, so this should also be included!

I'm happy to add this to the roadmap, although will likely happen after the Ruby and R implementations, as they don't have existing named packages for this yet. See https://github.com/Skenvy/Collatz/blob/main/ADD_LANG.md for how to add a stub!

Feel free to bypass most of the README template in that, as this is a pre-development stub, only the first two lines of the readme template are expected, along with comments about the existing package and the repository that it comes from --  see https://github.com/Skenvy/Collatz/blob/main/C%23/README.md for an example of this.

From this issue https://github.com/rust-lang/rust/issues/100000 ; accepting the Rust emoji's as "❤🦀❤"


fix public init

sorry, just a quick fix for public init

Gonna merge this and release it as 17.0.1 as an exception to normal semver rules due to significance of the bug.


Error executing apple add command

Hi, hope everything is going well,
Im having the following error when trying to execute the apple add command
Error: POST /developer-accounts/ failed: Internal Server Error
Any ideas for the causes of this error?

Hi, this error happened because there already were multiple accounts added for the team you were trying to add. It should be fixed now.


Airbrake on low internet connectivity

Before even I start, having used airbrake in past gives me the impression things I'm looking for perhaps do not exist yet in airbrake. But I just want to double-check.
We have our system deployed at remote places where internet connectivity is not stable. We would love to have error monitoring capability like airbrake in our system but we are not sure what would happen in an event(error event on airbrake) if the internet at the remote system is currently down. Will it drop the error(I'm assuming, it does)? Also is there a provision to send those errors to the airbrake system when the internet is up on the system?

Hey, Viren! In gobrake v5.6.0 we've actually released a feature called "backlog". I am not sure why it's not mentioned in the CHANGELOG (@chimanjain could you please add a mention?).
This somewhat helps in your scenario. If the airbrake server is unreachable, the error you are trying to send (or an APM event) would be cached and attempted to send later. I don't see any documentation on how to use it, though (@chimanjain, again, could you please work on that?).

Yes, there is a provision for that, we provide a backlog retry mechanism which retries to send the errors and monitoring stats to Airbrake after some time. To read more, please check the documentation here and in FAQ.


Move QueueJob out of tree

According to the design of https://github.com/kubernetes/community/pull/2337 , most of QueueJob feature are covered by PodGroup. It's better to move QueueJob out of tree :)

I'd like to keep QueueJob here as an example of customized controller.


all the data disappeared

Description
What steps will reproduce the problem?

All my data including python scripts and data was removed when I tried to remove just one file through file explorer!!!
Traceback
  File "/Applications/Anaconda/anaconda3/lib/python3.7/site-packages/spyder/plugins/editor.py", line 1921, in load
    filenames = [_convert(filenames)]
  File "/Applications/Anaconda/anaconda3/lib/python3.7/site-packages/spyder/plugins/editor.py", line 1912, in _convert
    fname = osp.abspath(encoding.to_unicode_from_fs(fname))
  File "/Applications/Anaconda/anaconda3/lib/python3.7/posixpath.py", line 383, in abspath
    cwd = os.getcwd()
PermissionError: [Errno 1] Operation not permitted

Versions

Spyder version: 3.3.6
Python version: 3.7.0
Qt version: 5.9.6
PyQt5 version: 5.9.2
Operating System: Darwin 19.0.0

Dependencies
pyflakes >=0.6.0  :  2.1.1 (OK)
pycodestyle >=2.3 :  2.5.0 (OK)
pygments >=2.0    :  2.4.2 (OK)
sphinx >=0.6.6    :  2.2.1 (OK)
rope >=0.9.4      :  0.14.0 (OK)
jedi >=0.9.0      :  0.15.1 (OK)
psutil >=0.3      :  5.6.3 (OK)
nbconvert >=4.0   :  5.6.0 (OK)
pandas >=0.13.1   :  0.25.2 (OK)
numpy >=1.7       :  1.17.2 (OK)
sympy >=0.7.3     :  None (NOK)
cython >=0.21     :  None (NOK)
qtconsole >=4.2.0 :  4.5.5 (OK)
IPython >=4.0     :  7.9.0 (OK)
matplotlib >=2.0.0:  3.1.1 (OK)
pylint >=0.25     :  2.4.3 (OK)

We're very sorry but this looks like a problem with Catalina and not with Spyder. Catalina has several permission problems like the one you posted above, that were not present in previous versions.
Besides, if you didn't have your code and data under version control (git or mercurial), there's nothing we can do to help you.


breakpoints source code fix, see issue https://github.com/nolimits4web/swiper/issues/2789

breakpoints parameters like spaceBetween and other breakpoint variables brought in sometimes as strings so the fix to this breakpoints responsive mode is to convert these variables to integers where appropriate (except 'auto' of course) so example slidesPerView and slidesPerGroup (I need this for breakpoints functionality)
This is a pretty straight forward fix, have a look at the pull request and the commit.
I've also created a build in my fork, called it v4.4.2 of swiper. see my fork here: https://github.com/entreprise7pro/swiper

Thanks, but please remove all debug information and I will merge it

@nolimits4web  , ok I have removed the debug information as requested.

looks like still a couple minor issues the CI picked up on
/home/travis/build/nolimits4web/swiper/src/components/core/breakpoints/setBreakpoint.js
12:1    error  Trailing spaces not allowed          no-trailing-spaces
17:49   error  Expected '===' and instead saw '=='  eqeqeq
17:100  error  Expected '===' and instead saw '=='  eqeqeq

ok @nolimits4web  I made also the ci fixes.

Merged, thanks! I also tweaked it a bit to the following:

slidesPerView can be float
This part is not needed:

if (typeof breakPointsParams.slidesPerGroup !== 'undefined') {
      // Use the breakpoint slidesPerGroup, otherwise we'd get the default desktop setting.
      swiper.params.slidesPerGroup = breakPointsParams.slidesPerGroup;
    }
    if (typeof breakPointsParams.slidesPerView !== 'undefined') {
      // Use the breakpoint slidesPerView, otherwise we'd get the default desktop setting.
      swiper.params.slidesPerView = breakPointsParams.slidesPerView;
    }
    if (typeof breakPointsParams.spaceBetween !== 'undefined') {
      // Use the breakpoint spaceBetween, otherwise we'd get the default desktop setting.
      swiper.params.spaceBetween = breakPointsParams.spaceBetween;
    }

This is already done in Utils.extend(swiper.params, breakpointParams); above


Setup to use new runner

PR Analysis

🎯 Main theme: Updating the CI/CD pipeline
📝 PR summary: This PR updates the CI/CD pipeline to use a newer macOS version, a newer iPhone simulator, a newer version of the checkout action, and a newer version of Ruby.
📌 Type of PR: Enhancement
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 1, because the changes are straightforward and limited to configuration files.
🔒 Security concerns: No security concerns found

PR Feedback
💡 General suggestions: The changes made in this PR are straightforward and make sense. However, it would be beneficial to add a brief explanation in the PR description about why these updates are necessary. This would provide context to reviewers and anyone looking at this PR in the future.
 🤖 Code feedback:relevant file.github/workflows/build.yamlsuggestion
Consider parameterizing the macOS version and the iPhone simulator version. This would allow for easier updates in the future and could potentially allow for testing on multiple versions simultaneously. [medium]
relevant lineruns-on: macos-14relevant file.github/workflows/build.yamlsuggestion
It seems that the ruby version is removed from the 'ruby/setup-ruby@v1' action. If the ruby version is specified in another place (like '.ruby-version' file), it's fine. Otherwise, it might be better to keep the ruby version here to ensure the correct version of ruby is being used. [important]
relevant line-          ruby-version: 2.7.4

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  About the 'Code feedback' section
The review tool provides several type of feedbacks, one of them is code suggestions.
If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results.
Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_review, enable_review_labels_effort, and more.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

PR Review

      PR feedback                       ⏱ Estimated effort to review [1-5]
2, because the changes are straightforward and involve updating versions and configurations in CI/CD and Ruby version files. However, ensuring compatibility and functionality with these new versions requires some attention.

 🧪 Relevant tests
No

 🔍 Possible issues

The update from macOS-12 to macOS-14 in the CI/CD pipeline might introduce compatibility issues with the existing codebase or dependencies that have not been tested against macOS-14.
Upgrading Ruby from version 2.7.8 to 3.0.6 could lead to potential breaking changes due to differences between Ruby 2.x and Ruby 3.x, such as keyword arguments.

 🔒 Security concerns
No

 Code feedback:
relevant file.github/workflows/build.yaml
suggestion

Consider adding a step to cache dependencies to speed up the build process. This can be done using actions like actions/cache to cache installed gems based on a key, for example, a hash of the Gemfile.lock. This is particularly useful to avoid reinstalling gems for every build, thus reducing build times. [important]

relevant line- uses: ruby/setup-ruby@v1
relevant file.github/workflows/build.yaml
suggestion

Verify if all dependencies of the project are compatible with Ruby 3.0.6, especially since moving from Ruby 2.x to 3.x can introduce breaking changes. It might be necessary to update the Gemfile or other dependency configurations to ensure compatibility. [important]

relevant line3.0.6
relevant file.github/workflows/build.yaml
suggestion

Ensure that all actions used in the workflow are compatible with macOS-14. This includes checking compatibility for actions/checkout@v4, ruby/setup-ruby@v1, and any other actions or scripts that might be indirectly affected by the macOS version upgrade. [medium]

relevant lineruns-on: macos-14
relevant file.github/workflows/build.yaml
suggestion

Since the Ruby version is being updated, consider specifying the Ruby version explicitly in the ruby/setup-ruby@v1 step to ensure consistency and clarity. This helps in making the CI/CD pipeline's behavior more predictable. [medium]

relevant line- uses: ruby/setup-ruby@v1

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


[consoleApp] [Manage] Enabling a jdbc secondary user store via Console Manage doesn't work

Describe the issue:
Enabling a jdbc secondary user store via Console Manage doesn't work
How to reproduce:
1.Access https://localhost:9443/console
2.Login as super admin
3.Navigate to Manage > Userstores > New Userstore > JDBC
4. Add a maria db Userstore as a secondary userstore by giving the necessary details
4.Save
5. Go to added userstore edit view > Enable Userstore
6. Update
Observation
UI says update is succesful. Login to the management console and check the status of the userstore. It will show as disabled. Also in the console if we log back and see enable option is not updated it shows as disabled
Environment information
Mssql 2019
uniqueid jdbc primary US
IS 5.11.0 beta3
ubuntu 16.04
Chrome Version 85.0.4183.121

Related https://github.com/wso2/product-is/issues/10316

Related issue: https://github.com/wso2/product-is/issues/9879
This was resolved by https://github.com/wso2/identity-apps/pull/1250


Create worker

Create a Heroku worker, which should get the current forecast for the following geolocation: @-9.6602869,-35.7059512
OpenWeatherMap accepts geolocated queries and it is the one which has the biggest limit of queries and so on. It also has special conditions for opensource projects.

Example of API call: http://api.openweathermap.org/data/2.5/weather?units=metric&q=Maceio,br&appid=MYAPPID

Worker created and already being scheduled on Heroku. Every 10 minutes now. We will  change to hourly soon.


add hip-clang dockerfile

Based on @scxiao 's onnx runtime dockerfile for hip-clang and rocm3.7

@pfultz2 it looks like we already have a dockerfile for hip-clang used for our CI from PR #651. However, do we want another Dockerfile that builds from source? Otherwise, we should update the readme and point them to the hip-clang.docker.

However, do we want another Dockerfile that builds from source?

Yea we probably do, but I am not sure what to call it.

Build for this one is completed and can be merged.


clean data

write a sql function to clean out the double spaces in the database

Now that I am able to pull large datasets I should start looking for other weirdness too

ALSO, data types! Right now pretty much everything is str (er I mean varchar) but I should convert the numeric stuff into ints or floats and so on. Lots of this to be done in the headers table: date ranges into dates, maybe make countries a category - I think that's a thing in SQL.


Is this to help with selling POTIONS or all items?

Program can work with all items; especially useful for cleaning out an entire bank alt. Atm all items are user specified through file; but will build out an all items


Fix styling of page

Bootstrap 4 broke the styling. Fix it so that it looks close to the older screenshots found on readme.

@RavenCode I made a pull request that solves this issue, please let me know if anything else should be added.


Updated Functions host version to 3.0.15411.

Releasing new Host versions.
V3 Release

PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] If applicable, the PR references the bug/issue that it fixes in the description.
[x] New Unit tests were added for the changes made and CI is passing.

Hi @kashimiz
Looks CI fails by exceed timeout of python language worker.

@pragnagopa This is the one.

Abandoning to include Python worker hotfix.


Update the game over message

Update the game over message so people know how to play again!

good code


[Feature] change Password and Forget Password

Description
this features will enhance the user experience @Nishitbaria can you please assign this task to me
Screenshots
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

Can you explain me how you are going implement this feature

@Nishitbaria I will be designing a page and backend connection if a user needs to change his/her password he can go to that particular page and enter his credentials and he can reset the password.
When it comes to the forgetting password feature if a user unexpectedly forgets his password he/she can use their mail and can reset the password.


Move js.use(x).as[T] out of the core

There are 3 good reasons for that:

It definitely can be implemented and tested outside of the core, so it should.
With Scala.js-defined JS classes, this feature has lost a lot of its usefulness (GitHub reports 2 occurrences of js.use in .scala files in the wild, and one of them should really be a Scala.js-defined JS class).
It is the only macro in the core library, so getting rid of it means getting rid of all macros in the core lib.

I definitely agree. I'm wondering whether we should just remove it and revive it if somebody asks for it.

I propose the following:

Deprecate in 0.6.17.
Remove in 1.0.0 (without replacement).
Revive if necessary.

I'm not a big fan of deprecating without replacement in 0.6.17. Because if people do use it and use fatal warnings, it's too much breakage in a minor release.
I'd actually rather just remove it in 1.0.0 without replacement, and revive if necessary.

Fair enough :)


README.md: mention SEPA transfers

Motivation for this change
They don't incur a fee and should thus be preferred.
Should we modify the homepage so we can directly link to the account information?

Should we modify the homepage so we can directly link to the account information?

sure, why not. but that's a topic for https://github.com/NixOS/nixos-homepage


Create an InfiniBand / OFDED example

It would be good if we had an InfiniBand/OFED example for our users.

It turns out the horovod example covers this!


ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host

Describe the bug
When using the CLI (also when connection to dev.azure.com), i randomly get the error:
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host
or anything similar to:
_Error occurred in request., ConnectionError: HTTPSConnectionPool(host='vssps.dev.azure.com', port=443): Max retries exceeded with url: /yooag/apis/Graph/Descriptors/5a03b89b-f97f-4155-bd7b-3b6819ef62d5 (Caused by ProtocolError('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None)))
It also happens when i try to push / commit somehing to azure devops repositories.
All of this only happens from home, with my work computer. In the office it works and with my personal PC it also works from home.
Running & "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe" -c "import requests; print(requests.get('https://login.microsoftonline.com/').status_code)" you can see that this seems to happen randomly.
When running the same command it sometimes works, and sometimes it does not. But it always fails after very few commands.
I am NOT running behind a proxy.
Related command
any connection / command to the Azure CLI
Errors
Commands run in order they appear within a few seconds:
PS C:\Users\JakobWolf> & "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe" -c "import requests; print(requests.get('https://login.microsoftonline.com/').status_code)"
200
PS C:\Users\JakobWolf> & "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe" -c "import requests; print(requests.get('https://login.microsoftonline.com/').status_code)"
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 715, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 404, in make_request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 1058, in validate_conn
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 419, in connect
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 449, in ssl_wrap_socket
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 493, in _ssl_wrap_socket_impl
File "ssl.py", line 517, in wrap_socket
File "ssl.py", line 1108, in _create
File "ssl.py", line 1379, in do_handshake
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/adapters.py", line 486, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 799, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/retry.py", line 550, in increment
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/packages/six.py", line 769, in reraise
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 715, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 404, in make_request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 1058, in validate_conn
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 419, in connect
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 449, in ssl_wrap_socket
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 493, in _ssl_wrap_socket_impl
File "ssl.py", line 517, in wrap_socket
File "ssl.py", line 1108, in _create
File "ssl.py", line 1379, in do_handshake
urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/api.py", line 73, in get
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/api.py", line 59, in request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 589, in request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 725, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 725, in
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 266, in resolve_redirects
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 703, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/adapters.py", line 501, in send
requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
PS C:\Users\JakobWolf> & "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe" -c "import requests; print(requests.get('https://login.microsoftonline.com/').status_code)"
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 715, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 404, in make_request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 1058, in validate_conn
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 419, in connect
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 449, in ssl_wrap_socket
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 493, in _ssl_wrap_socket_impl
File "ssl.py", line 517, in wrap_socket
File "ssl.py", line 1108, in _create
File "ssl.py", line 1379, in do_handshake
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/adapters.py", line 486, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 799, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/retry.py", line 550, in increment
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/packages/six.py", line 769, in reraise
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 715, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 404, in make_request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 1058, in validate_conn
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 419, in connect
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 449, in ssl_wrap_socket
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 493, in _ssl_wrap_socket_impl
File "ssl.py", line 517, in wrap_socket
File "ssl.py", line 1108, in _create
File "ssl.py", line 1379, in do_handshake
urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/api.py", line 73, in get
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/api.py", line 59, in request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 589, in request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 725, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 725, in
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 266, in resolve_redirects
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 703, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/adapters.py", line 501, in send
requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
PS C:\Users\JakobWolf> & "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe" -c "import requests; print(requests.get('https://login.microsoftonline.com/').status_code)"
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 715, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 404, in make_request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 1058, in validate_conn
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 419, in connect
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 449, in ssl_wrap_socket
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 493, in _ssl_wrap_socket_impl
File "ssl.py", line 517, in wrap_socket
File "ssl.py", line 1108, in _create
File "ssl.py", line 1379, in do_handshake
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/adapters.py", line 486, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 799, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/retry.py", line 550, in increment
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/packages/six.py", line 769, in reraise
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 715, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 404, in make_request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 1058, in validate_conn
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 419, in connect
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 449, in ssl_wrap_socket
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 493, in _ssl_wrap_socket_impl
File "ssl.py", line 517, in wrap_socket
File "ssl.py", line 1108, in _create
File "ssl.py", line 1379, in do_handshake
urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/api.py", line 73, in get
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/api.py", line 59, in request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 589, in request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 725, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 725, in
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 266, in resolve_redirects
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 703, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/adapters.py", line 501, in send
requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
PS C:\Users\JakobWolf> & "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe" -c "import requests; print(requests.get('https://login.microsoftonline.com/').status_code)"
200
PS C:\Users\JakobWolf> & "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe" -c "import requests; print(requests.get('https://login.microsoftonline.com/').status_code)"
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 715, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 404, in make_request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 1058, in validate_conn
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 419, in connect
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 449, in ssl_wrap_socket
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 493, in _ssl_wrap_socket_impl
File "ssl.py", line 517, in wrap_socket
File "ssl.py", line 1108, in _create
File "ssl.py", line 1379, in do_handshake
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/adapters.py", line 486, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 799, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/retry.py", line 550, in increment
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/packages/six.py", line 769, in reraise
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 715, in urlopen
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 404, in make_request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connectionpool.py", line 1058, in validate_conn
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/connection.py", line 419, in connect
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 449, in ssl_wrap_socket
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\urllib3/util/ssl.py", line 493, in _ssl_wrap_socket_impl
File "ssl.py", line 517, in wrap_socket
File "ssl.py", line 1108, in _create
File "ssl.py", line 1379, in do_handshake
urllib3.exceptions.ProtocolError: ('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/api.py", line 73, in get
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/api.py", line 59, in request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 589, in request
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 725, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 725, in
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 266, in resolve_redirects
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/sessions.py", line 703, in send
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\requests/adapters.py", line 501, in send
requests.exceptions.ConnectionError: ('Connection aborted.', ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
PS C:\Users\JakobWolf> & "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe" -c "import requests; print(requests.get('https://login.microsoftonline.com/').status_code)"
200
PS C:\Users\JakobWolf> & "C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe" -c "import requests; print(requests.get('https://login.microsoftonline.com/').status_code)"
200
Issue script & Debug output
See errors.
Expected behavior
No error.
Environment Summary
azure-cli                         2.55.0
core                              2.55.0
telemetry                          1.1.0
Extensions:
azure-devops                      0.26.0
Dependencies:
msal                            1.24.0b2
azure-mgmt-resource             23.1.0b2
Python location 'C:\Program Files\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\JakobWolf.azure\cliextensions'
Python (Windows) 3.11.5 (tags/v3.11.5:cce6ba9, Aug 24 2023, 14:38:34) [MSC v.1936 64 bit (AMD64)]
Additional context
No response

Thank you for opening this issue, we will look into it.

Based on your description, this likely stems from a network issue.

All of this only happens from home, with my work computer. In the office it works and with my personal PC it also works from home.

Is your VPN connection unstable?

Based on your description, this likely stems from a network issue.

All of this only happens from home, with my work computer. In the office it works and with my personal PC it also works from home.

Is your VPN connection unstable?

As i wrote already, no proxy, no vpn. Its only on work computer. And it works on my personal computer (which is in the same network). It also is pretty consistent in that it always happens more than not on work pc and never happens on personal.

This doesn't make sense.
Since you've eliminated all other possibilities, I have no additional advice to give.


The first command in the Git-LFS is wrong

In the Git-LFS page is written:
1. Download and install the Git command line extension. You only have to set up Git LFS once.

    git lfs install

However install is not an available command:
$ git lfs install
Error: unknown command "install" for "git-lfs"
Run 'git-lfs --help' for usage.

I guess you mean git lfs init

The command name changed in Git LFS v1.1.0 (though git lfs init will continue to work for awhile). You can substitute git lfs init for git lfs install, and git lfs uninit for git lfs uninstall.

I just ran into this same issue. Running git lfs init fixed it.


When should I use Environments?

what's the difference without Environments?
webpack build faster or what?

If you don’t know, just don’t use them :).

We added “Environments”, because some users want them for Babel. For my opinion, it is better to do not use them :).

@ai thanks. may be use with other stuff.


BaseObjectDeserializer throws a lot of Exception typed exceptions.

Deserialiser throws a lot of Exception typed exceptions that can't be discriminately caught.

Closing this ticket as we are moving to Jira to reduce noise. You can access it there.


Compilation error on Ubuntu: no member named ‘getConnectionRef’

Hello,
I am trying to compile your addon on a fresh Ubuntu installation.
I generated a new project, using the PG and when compiling, I get those errors:

../../../addons/ofxJSONRPC/libs/ofxHTTP/src/BasicJSONRPCServer.cpp|94|error: ‘class ofx::HTTP::WebSocketFrameEventArgs’ has no member named ‘getConnectionRef’|
../../../addons/ofxJSONRPC/libs/ofxHTTP/src/BasicJSONRPCServer.cpp|99|error: ‘class ofx::HTTP::WebSocketFrameEventArgs’ has no member named ‘getConnectionRef’|
../../../addons/ofxJSONRPC/libs/ofxHTTP/src/BasicJSONRPCServer.cpp|107|error: ‘class ofx::HTTP::WebSocketFrameEventArgs’ has no member named ‘getConnectionRef’|

Any ideas where are those coming from?
Thanks

I'm in the middle of updating a few things -- this should be working if you use the develop branches of ofxHTTP and ofxJSONRPC.  Can you give them a try?

I just tried it and got different errors:

../../../addons/ofxHTTP/libs/ofxHTTP/src/WebSocketConnection.cpp|147|error: ‘class ofx::HTTP::WebSocketFrame’ has no member named ‘getData’|
../../../addons/ofxHTTP/libs/ofxHTTP/src/WebSocketConnection.cpp|215|error: ‘class ofx::HTTP::WebSocketFrame’ has no member named ‘getData’|

Ahh to use develop the master brach of of is required. Let me see if I can
get this sorted out ...
On Wed, Apr 29, 2015, 7:52 AM Mathieu Hingant<EMAIL_ADDRESS>wrote:

I just tried it and got different errors:
../../../addons/ofxHTTP/libs/ofxHTTP/src/WebSocketConnection.cpp|147|error:
‘class ofx::HTTP::WebSocketFrame’ has no member named ‘getData’|
../../../addons/ofxHTTP/libs/ofxHTTP/src/WebSocketConnection.cpp|215|error:
‘class ofx::HTTP::WebSocketFrame’ has no member named ‘getData’|
—
Reply to this email directly or view it on GitHub
https://github.com/bakercp/ofxJSONRPC/issues/6#issuecomment-97417333.

ah ok, yes I forgot to mention that I am using the linux version of OF, downloaded from the website.

OK.  You should be able to use the develop branch of JSONRPC w/ the develop branch of ofxHTTP and the stable branch of openFrameworks (the one you downloaded from the web!).
Can you give it try?  Thanks!

Ok now the empty project compiles fine.
Then I tried with another project, realised that it needs to have ofxNetwork included too....made few changes to use your new changes and it compiled fine.
Thanks!

Closing this as it seems to work now.  Thanks!


[Feature Request] Trigger click on NavMenu collapse

Existing Component
Yes
Component Name
NavMenu
Description
Please add trigger="click" in NavMenu when collapse

very important issue

Sorry, we have no plan to support this.


Fix Nav menu render on top of button

Closes: #1996
What's Changed

drop menu close to nav end

drop menu far from nav end

TODO

[ ] Explanation of Change(s)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

Pulling this down and giving it a try, I notice that the new edge class doesn't seem to be being applied to the menus on the GraphiQL view, probably because that page has its own custom JS and isn't currently including the file you modified. (I think this may have been commented on in the main 1.4.0 review PR, but in any case it would probably be good if the GraphiQL template were updated to include inc/javascript.html instead of partially duplicating its contents).


API: submenus extension point

This PR fixes #100172

[x] Fix non-editor submenus, fix dropdown submenus: address SubmenuItemAction vs ContextSubMenu confusion
[x] Fix native context menus
[x] Support nested submenus
[x] Prevent submenu cycles
[x] Expand the set of menus which have submenu support
[ ] Support top-level toolbar submenus, including icon for the action item

@sbatten @isidorn Native submenus were yet another implementation, dependent on the bogus ContextSubMenu class. I deleted that class.

@sbatten @jrieken Recursive submenus work in custom UI:

But they break down in native UI, since the entire menu hierarchy must be given to Electron at the time of creation:

Because of the limitation and the fact that it would simply be a gimmick, I'll write some code to prevent menu cycles.

@jrieken I've refactored menusExtensionPoint.ts heavily to make it easier to maintain the list of API menus, give it a look: https://github.com/microsoft/vscode/pull/102784/commits/c3cef6f8ee46ff7a4fa664d63c656ba96dfc1313

Submenus now work across most menus! Check this out:

Very cool work 👏

@jrieken Thanks for the post-mergeum review! 🙏


knativekafkapartition CE extension does not conform to spec

Describe the bug
The CE Extension knativekafkapartition was recently added, but it does not conform to the CloudEvent spec.
https://github.com/knative-extensions/eventing-kafka-broker/pull/3464
CloudEvents attribute names MUST consist of lower-case letters ('a' to 'z') or digits ('0' to '9') from the ASCII character set. Attribute names SHOULD be descriptive and terse and SHOULD NOT exceed 20 characters in length.
With the NodeJS library in particular, it throws an error because "knativekafkapartition" is 21 characters.
Could it be changed to "knkafkapartition" possibly? (and probably "knativekafkaoffset" to "knkafkaoffset" too)
Expected behavior
Keep all CE extension names 20 characters or less.
To Reproduce
Any event produced will have this header if I'm not mistaken.
Knative release version
1.13

Thanks for catching this @cchayka-campsci ! I'll add a fix here, but would you mind also opening an issue to the NodeJS library as well? Since this requirement is only a SHOULD in the spec, they should accept values without throwing an error if the length is wrong IMO.
Since this will change behaviour for users (including those who originally requested this feature) we will need to discuss whether or not this fix gets backported or if we just use the new extension going forwards (i.e. 1.15+)
cc @matzew @pierDipi for whether we should backport this or not

/triage accepted
/assign

Hey @cchayka-campsci I opened a PR to the node SDK and the new release (8.0.2) includes a fix for the bug you were encountering. I'm not sure if we will be changing the names of the extensions as that is a breaking change for our users


Add flag for toggling permessage-deflate

This is a workaround for https://github.com/cdr/code-server/issues/3014 until we figure it out (if it is indeed related which it might not be; the zlib errors could merely be side effects of a connection issue).

increase coverage by 0.12%
👏 You + Codecov helping us build a habit of increasing code coverage!

Refactored; it's not any more pure but it's simpler. I think we could have an interesting discussion on whether we should pass args (and other variables) around instead of using a global access pattern at some point.
Coverage went down because of the code added in entry so I split some of those functions out in order to test them. One of them is now used for all the integration tests so those should reflect reality more closely now.

I think we could have an interesting discussion on whether we should pass args (and other variables) around instead of using a global access pattern at some point

Agreed! I prefer passing args because it's easier to mock/test things. But global access does come in handy when writing code. It would be a good discussion though.

I'm going to fix the trivy scan in a PR soon so you can ignore for now


How to disable warning message?

During the npm installation I am getting the following errors:
npm WARN optional Skipping failed optional dependency /chokidar/fsevents:
npm WARN notsup Not compatible with your operating system or architecture<EMAIL_ADDRESS>
This appears every time I run npm install.  How do I disable this useless warning message?
chokidar 1.6.0 | ubuntu 16.04 | npm 3.10.3

npm install --no-optional


Alan walker - the spectre

Song Name
Alan walker - the spectre
Artist Name
alan walker
Source
Youtube
Youtube Link
alan walker
Direct File Link
https:/www.youtube/alan walker - the spectre
Song ID
9165093
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 91328416
Downloaded: si

Solo no quiero que me eliminen :(

Song alan walker

Aceptar
El lun., 19 de agosto de 2024 5:27 p. m., auto-nong[bot] <
@.***> escribió:

Thanks for contributing!
Someone will soon review your request.
Here is the JSON result for the reviewer:
{
"name": "Alan walker - the spectre",
"artist": "alan walker",
"source": "youtube",
"startOffset": 0,
"yt-id": "alan walker",
"songs": [
9165093
]
}
To accept the request, a reviewer needs to write "accept".
—
Reply to this email directly, view it on GitHub
https://github.com/FlafyDev/auto-nong-indexes/issues/3109#issuecomment-2297594622,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BKUPKUBN337JIZJZ2FIPNVLZSJWNJAVCNFSM6AAAAABMYV6YY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJXGU4TINRSGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

reject
alan walker is not a link... also tf is going on here


test-branch/execute-job/quoted-authorization/1e96e737-c420-40aa-a675-499221881b76

PR for testing 5b95f7d588813958c5a79ace7dd848fd89be0993

/canonical/self-hosted-runners/run-workflows 5b95f7d588813958c5a79ace7dd848fd89be0993


Powershell Reference overhaul

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/Consume-Packages/Reinstalling-and-Updating-Packages.md
:white_check_mark:Succeeded

docs/Guides/Create-NET-Standard-Packages-VS2017.md
:white_check_mark:Succeeded

docs/Policies/NuGet-FAQ.md
:white_check_mark:Succeeded

docs/TOC.md
:white_check_mark:Succeeded

docs/Tools/Package-Manager-Console.md
:white_check_mark:Succeeded

docs/Tools/PowerShell-Reference.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-add-bindingredirect.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-find-package.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-get-package.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-get-project.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-install-package.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-open-packagepage.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-sync-package.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-uninstall-package.md
:white_check_mark:Succeeded

docs/Tools/ps-ref-update-package.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Addressing https://github.com/NuGet/Home/issues/2107 (and https://github.com/NuGet/docs.microsoft.com-nuget/issues/271).


set the home spaces list to show recently visited spaces

There were the following issues with your Pull Request

Commit: b45cdb60e4b2d17f168f4799a116a3342626bef4
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com

@joshuawilson snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-914-fabric8-ui.int.rdu2c.fabric8.io

There were the following issues with your Pull Request

Commit: b45cdb60e4b2d17f168f4799a116a3342626bef4
Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com

@joshuawilson snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-914-fabric8-ui.int.rdu2c.fabric8.io


Beta channel: stdin.readLineSync() type issue

String input = stdin.readLineSync();
won't compile.
Error:
Error: A value of type 'String?' can't be assigned to a variable of type 'String' because 'String?' is nullable and 'String' isn't.
String input = stdin.readLineSync();
Works fine in channel stable.
Running minimal dart file from CLI

Hi @jackeymason
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Looks like you have Null Safety enabled. You can easily fix this by replacing your first line by making your input nullable: String? input = stdin.readLineSync();.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Hi @jackeymason
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Looks like you have Null Safety enabled. You can easily fix this by replacing your first line by making your input nullable: String? input = stdin.readLineSync();.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Sorry, just getting started with Dart, and the behavior that appeared broken to me was only occurring in the beta channel. Are there a Beta channel API docs?

On Jan 13, 2021, at 2:04 AM, Pedro Massango<EMAIL_ADDRESS>wrote:

Hi @jackeymason
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Looks like you have Null Safety enabled. You can easily fix this by replacing your first line by making your input nullable: String? input = stdin.readLineSync();.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Sorry, just getting started with Dart, and the behavior that appeared broken to me was only occurring in the beta channel. Are there a Beta channel API docs?

On Jan 13, 2021, at 2:04 AM, Pedro Massango<EMAIL_ADDRESS>wrote:

Hi @jackeymason
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community for resources and asking questions like this,
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Looks like you have Null Safety enabled. You can easily fix this by replacing your first line by making your input nullable: String? input = stdin.readLineSync();.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

No that I know.

No that I know.


Update GlorpSQLite3 README.md link

The link to SQLite3 in the readme redirects to a SQLite3 library that does not utilize Glorp. I believe the correct link is: https://github.com/PierceNg/glorp-sqlite3.

The link is OK as it is. The referenced project includes an optional group with the Glorp-related code. It's also continuously tested See https://github.com/pharo-rdbms/glorp/blob/master/.smalltalkci/.SQLite3.ston

Ok thanks.
I realize that something is missing in the project documentation.
The readme said "Use its Metacello snippet to load both Glorp and the driver in one go" and when I am on the page there is no script to "load both Glorp and the driver in one go" and no mention to Glorp!
It's not clear that we need to load a thing that isn't obvious to guess.

Please propose an update to the readme so it's more clear. The docs in the
project are in need of some love.
On Sat, Jan 20, 2024, 09:57 Pierre Laborde @.***> wrote:

Ok thanks.
I realize that something is missing in the project documentation.
The readme said "Use its Metacello snippet to load both Glorp and the
driver in one go" and when I am on the page there is no script to "load
both Glorp and the driver in one go" and no mention to Glorp!
It's not clear that we need to load a thing that isn't obvious to guess.
—
Reply to this email directly, view it on GitHub
https://github.com/pharo-rdbms/glorp/pull/152#issuecomment-1902087687,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQCK6ES6XBEE5WV7M32TDDYPO5MJAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4DONRYG4
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Please propose an update to the readme so it's more clear. The docs in the project are in need of some love.
…
On Sat, Jan 20, 2024, 09:57 Pierre Laborde @.> wrote: Ok thanks. I realize that something is missing in the project documentation. The readme said "Use its Metacello snippet to load both Glorp and the driver in one go" and when I am on the page there is no script to "load both Glorp and the driver in one go" and no mention to Glorp! It's not clear that we need to load a thing that isn't obvious to guess. — Reply to this email directly, view it on GitHub <#152 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQCK6ES6XBEE5WV7M32TDDYPO5MJAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4DONRYG4 . You are receiving this because you modified the open/close state.Message ID: @.>

You have right :)
I will propose an update if I succeed to load the sub-project with glorp >< see: https://github.com/pharo-rdbms/Pharo-SQLite3/issues/108

I don't have access to the computer until the next month. But doing
something like this should work:
Metacello new
repository: 'github://pharo-rdbms/Pharo-SQLite3/src';
baseline: 'SQLite3';
load:#('Core' 'glorp')
There's no need to manually load the dependencies. And if you want to load
it by hand you need to use the same version declared as dependency in the
Baseline.
On Sat, Jan 20, 2024, 10:39 Pierre Laborde @.***> wrote:

Please propose an update to the readme so it's more clear. The docs in the
project are in need of some love.
… <#m_-5032872237467112048_>
On Sat, Jan 20, 2024, 09:57 Pierre Laborde @.> wrote: Ok thanks. I
realize that something is missing in the project documentation. The readme
said "Use its Metacello snippet to load both Glorp and the driver in one
go" and when I am on the page there is no script to "load both Glorp and
the driver in one go" and no mention to Glorp! It's not clear that we need
to load a thing that isn't obvious to guess. — Reply to this email
directly, view it on GitHub <#152 (comment)
https://github.com/pharo-rdbms/glorp/pull/152#issuecomment-1902087687>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQCK6ES6XBEE5WV7M32TDDYPO5MJAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4DONRYG4
https://github.com/notifications/unsubscribe-auth/AAQCK6ES6XBEE5WV7M32TDDYPO5MJAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4DONRYG4
. You are receiving this because you modified the open/close state.Message
ID: @.>
You have right :)
I will propose an update if I succeed to load the sub-project with glorp

< see: pharo-rdbms/Pharo-SQLite3#108
https://github.com/pharo-rdbms/Pharo-SQLite3/issues/108

—
Reply to this email directly, view it on GitHub
https://github.com/pharo-rdbms/glorp/pull/152#issuecomment-1902096363,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQCK6AC4OXNIUHR24437XTYPPCILAVCNFSM6AAAAABCDEQW3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGA4TMMZWGM
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Thanks I will complete my issue with this dicussion :)


Enabling autocomplete for Holohub run command

Adding autocomplete for HoloHub run command

This is great!  Thanks for adding autocomplete


Remove .near and #nearbys for MongoDB models.

Geocoding (fetching and saving coordinates) for Mongo-backed models is
still supported, but querying should be done through MongoDB's built-in
commands.

Great--thanks! I would love to merge this into drop_mongo_near but because that branch won't be merged until 1.3.0 you can also remove the deprecation warning...

Also/separately, I think we can remove the bson_ext gem from the various Gemfiles.


Added editors for MobSpawn features

This addition of MobSpawn feature editors reimplement GetString to provide developers / modders with more easily understood names.
This PR does need some help. Specifically In the dropdown, show only the part of the name before the colon. In the features list, show the whole thing with the parameters. Currently, the dropdown does not have these new names.

A follow-up PR will be made too address user-friendly editor names for types.


Fix for Video class - #110

YouTube is removing &pb=1 and rendering it all in

Is the Video class working with StreamURLFetcher?

Is the Video class working with StreamURLFetcher?

Yes. Everything is working as should. I ran syncExample.py and it completed without any errors

Sure. Let's get it merged.


binja enforce the usage of the return value, although it was discarded

Version and Platform (required):

Binary Ninja Version: [e.g. 3.2.4000-dev] (if version is stable, please also test the latest development build via the "Update Channel" option)
OS: manjaro

Bug Description:
while reversing windows x86 binary i noticed that, binja enforce the usage of return value as shown in the pictures below

eax was discarded but binja enforce it which corrupt the rest of the analysis.
Expected Behavior:
after NOPing the function call, the analysis become correct as shown.

Additional Information:
Sorry i cant provide the binary ;)

Related to https://github.com/Vector35/binaryninja-api/issues/4511.
The problem is BN thinks the function memcpy uses register ebp as its return value, which is wrong. Can you try unchekcing the ebp checkbox in the Cloberred Registers list in the Edit Function Properties dialog of the memcpy function?

thanks, after removing ebp from the clobbered registers the analysis was corrected.


fix(downstream-api-from-api-docs): Updates code snippet

Aims to replace the Obsoleted method call mentioned in the code snippet in Option 2 (call a downstream api):

Using the existing code snippet when working with the latest Microsoft.Identity.Web package (v2.50) to use the updated (non-obsoleted) method.
Not sure if this is definitely the right method to replace this with, or where else in the documentation this also might need updating, but it resolved the Obsoleted error message I was seeing when following the current guidance

@cilwerner
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Improvements to LayeredCloud

added ParallelLayeredCloud, which performs the build-step in seperate threads
added a "WordStartScheme" interface, which specifies the starting point to look for word-placements

added RandomWordStart (previous default behaviour)
added CenterWordStart (always start in center)

added BubbleTextNormalizer, which converts text-characters to bubble-enclosed characters (requires a supporting font)

Love the additions :)
And :+1: for the first performance PR
I'll look over everything in a bit.

I've created a performance test to check speeds:
this is the code: http://pastebin.com/NH66P0fd
I have removed all randomness, so it produces 2 times exactly the same picture
this is the output:
ParallelLayeredWordCloud 4Tile took 26.794 secs to compute
NormalLayeredWordCloud 4Tile took 74.677 secs to compute
ParallelLayeredWordCloud 4Tile took 29.244 secs to compute
NormalLayeredWordCloud 4Tile took 83.044 secs to compute
ParallelLayeredWordCloud 4Tile took 30.129 secs to compute
NormalLayeredWordCloud 4Tile took 84.838 secs to compute

Hey I checked over the code, looked good! Only had a few minor comments.
I also request you add a generated word cloud using your bubble text normalizer so I can showcase it.
Thanks again, and thanks for the performance breakdowns.

In regards to the bubble text. I noticed that the bottoms of the circles are missing. Do you need to make the rectangle being rendered on taller? Or is it supposed to be cut off?

In regards to the bubble text. I noticed that the bottoms of the circles are missing. Do you need to make the rectangle being rendered on taller? Or is it supposed to be cut off?
It seems to be a problem with the wordbox size, as not all fonts seem to have a corret height computed

I've noticed this with a couple of fonts, but dont know where the error originates.

Thanks man!