2.x version bump to 2.5.0

Description
Increment the version on the 2.x branch to the next development iteration.
Category
Maintenance
Issues Resolved

Related #1140

Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1221 (47fd02b) into 2.x (ff8e2b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #1221   +/-   ##
=======================================
  Coverage   71.78%   71.78%
=======================================
  Files          88       88
  Lines        2027     2027
  Branches      269      269
=======================================
  Hits         1455     1455
  Misses        509      509
  Partials       63       63

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

https://github.com/opensearch-project/opensearch-build/pull/2931 has been merged and security has been added to build manifest. We have to wait until a build run is triggered so the artifact is available.

@RyanL1997 Can you look into the integration test failure, is this an intermittent issue?

@peternied @RyanL1997 and I looked into this earlier and it looks like its due to this issue: https://github.com/actions/runner-images/issues/6399
ubuntu-latest is now resolving to ubuntu-22.04 instead of ubuntu-20.04 and it did not have firefox pre-installed. There was a recent update to ubuntu-22.04 to include firefox so this should be resolved later this week. There is also the option to install firefox explicitly using an action like this: https://github.com/opensearch-project/security-dashboards-plugin/pull/1226/files#diff-65ae1168eecd2c82b28b52c8a2c[…]bfa781144b33f0d74909103d9R10-R15

Update: I have already added the driver fix of Selenium into this PR. The original fix on main is (#1229 ).


Refactor util/mkdef.pl for DSOs

So far, util/mkdef.pl has only been used to create symbol export maps for out shared libraries.  This PR expands the concept to work on DSOs (engines) as well.
This was done in a hard coded manner for Windows and VMS already, but with this PR, the same thing can be done on Unix as well (wasn't so far), and also becomes uniform on all supported platforms.

Thanks for the approval, @t-j-h, but I discovered it was a bit premature.  I encountered issues on VMS, which I'm working on now.  This PR is WIP 'til I'm done.

All right, this works correctly on VMS now, and I've verified that the engines load correctly.

Oh, and Travis failure is not relevant


Ide icons

@goanpeca @ccordoba12 opening this so that you can see what it looks like.
This is not intended to be merged as is. I want to add an intermediate layer with qtawesome that automates certain things like graying disabled font icons etc...
This requires the qtawesome 0.1.5, which I just pushed to pypi. Please update with pip install --upgrade.
Besides, I want to make the spyder font its own project so that people can use it for the web as well, with the same mechanism as fontawesome.

@SylvainCorlay looking at it now :)
I really like how the icons look inside the menus (small versions) but I am not entirely convinced on the look for the toolbars... maybe if we make the toolbars smaller it would look better?

Indeed, the icons are really crisp in the menus but not pixel-perfect in the toolbars. Changing the size of the toolbars (bigger or smaller) should solve it.

It seems the height of the toolbar is platform dependent and cannot be forcibly set. However, we can adjust icon sizes.

@SylvainCorlay checking them now, waayyyyyyy better :-)
It is looking very good (on linux so far), great job man.

Now on windows

We need to add the white background for the Spyder icon
the save all icon looses detail so I guess we need to see what is going on there... also we should cater for the case when the user has trutypefonts disabled on the OS, cause it will look bad on start, and this is an OS wide setting, so not sure what could be done inside Spyder, besides generating png files on the fly...

@goanpeca I fixed the issue with the spyder logo.
Regarding the disabled buttons, yes.
I am also not taking care of file types for now.

@SylvainCorlay cool :), what do you think of using filled vs, outlined icons?

I think that we could include in the json file (or somewhere else) the pixel perfect setting for the specific fonts used (if the fonts have any such setting) so that instead of defining a 0.9 arbitrary scale factor (line 14), we use a default value that makes sure the resulting icon is set to the pixel perfect value (14px for font awesome)

Yeah, would should do something along these lines for the pixel perfect.
I am not sure about filled vs outlined icons. What do you mean?

Why the icons in the browser (for the exact same size in pixels) look so much better than the ones in a Qt application?
Font Awesome website / qtawesome Screenshot

Is this the anti-aliasing issue on Windows? In my case, they look very much alike.

For the Contour vs Filled I mean:

OK, not all icons have both versions (like the save button).

@SylvainCorlay yes I know, but besides the save button, most of the icons have a filled version, and my opinion is that the GUI looks more uniform if filled ones (I think it does look better) instead of a mixed of both. In the worst case, we make a filled save icon...

Ok I made a check with windows... and there is a catch, it seems that when ClearType (a windows only thing) is enabled... it results in aliased icons :disappointed:

OK, I can make some tries with filled icons. Although for fa.copy = copy and fa.clipboard = paste, I don't see much of an alternative and I have used it consistently everywhere.

Just a few comments from @goanpeca screenshot:

I don't like the Debug button. Please try to leave it as it was, i.e. a play-and-pause button
Step in, step out and step into are confusing. I know they are the classical icons used in IDEs but it's not easy to visually distinguish among them.
Maximize current plugin is not that clear as before.
The icons for running cells are too dense. I mean, I think too much is going on with them.
Python path manager is really hard to understand.
Probably the icons looked better if the toolbars were smaller :-)

@ccordoba12 the screenshots are a bit out of date. Running the branch should show something nicer now. The toolbar is smaller.
I agree on the icon to maximize current pluging. We need to make it again.
The step-out  and step-into are really what I find much better about the new theme actually. Notice that the scale of the screenshot is not 1:1

Good to know! Sorry for not being on gitter. I was very busy finishing 2.3.4 and other things for the next Anaconda release, so I wanted to focus just on that. I'll come back to gitter this week :-)

@ccordoba12 thanks for the comments, I agree with all of them :-), this is still a work in progress so hold on for some updates soon.

I've got around 250 instances of call to qta.icon as of now. I have redesigned all the glyphs of the spyder font to be pixel-perfect at the same sizes as the font-awesome ones (14px and multiples) .
A few important ones are still missing, specifically, Run selection and Select all (See request https://github.com/FortAwesome/Font-Awesome/issues/4842 but will probably make one in the spyder font)

It seems a rebase is needed here :-)

Just rebased. Will create the icon manager we talked about with the freedesktop names sometimes in the week.

@SylvainCorlay, can you rebase to see if we can get rid of the Failed travis test?

Sure. In any case, this will require adding qtawesome.

True, can you add that in the travis_install.sh inside the continuous integration?
Add it to TEST_PACKAGES= in line 127 and 131

Just now checking on windows.
I think we need to fix something about how the fonts scale inside the actual button, or how the button size changes the actual font that gets rendered, because it looks weird..( not centered on the button or with a piece cropped.)

Yes, I am aware of this issue / and have a couple of clues. It seems to depend on the toolbar size. It seems that the C++ QtAwesome library also has this problem.

Rebased. qtawesome does not get installed though.

Slightly updated screenshot. If you want to test from source, please update to the latest qtawesome.

Remains the file explorer and the outline explorer icons.

I am looking at the best way to write the icon manager, to switch between the font awesome icons and the old theme, and use freedesktop naming convention for icons in the icon manager.

@SylvainCorlay it is looking better and better. Great job.
We can have a chat on the icon manager

I guess if you want to use the freedesktop thinguie then I guess that should be the top layer... otherwise, we would have to create a spyder specific naming convention.

from iconmanager import get_icon

icon = get_icon('free-desktop-naming-convention')

and on the module we can then define there our icons and the normal system of icon retrieval using Qt's from theme...

Totally, My only reservation is about how to handle plugins.
Something like the conda package manager should not depend on a
spyder-specific icon manager and be able to use the icons.
On Sun, Apr 19, 2015 at 8:27 AM, Gonzalo Peña-Castellanos <
<EMAIL_ADDRESS>wrote:

I guess if you want to use the freedesktop thinguie then I guess that
should be the top layer... otherwise, we would have to create a spyder
specific naming convention.
from iconmanager import get_icon
icon = get_icon('free-desktop-naming-convention')
and on the module we can then define there our icons and the normal system
of icon retrieval using Qt's from theme...
—
Reply to this email directly or view it on GitHub
https://github.com/spyder-ide/spyder/pull/2260#issuecomment-94271280.

hmmm well.. if it is going to be installed as a plugin for spyder then it SHOULD use the icon manager, what we need to think is how to let the user specify paths to its own icons, in case spyder does not provide enough icons.

And at the same time be consistent with freedekstop thinguie. We need to be clear on this in the plugin guide... on how to use icons and what to do in case of new icons.

@SylvainCorlay, I have to agree with @goanpeca, great work!! I have a couple of comments based on your last screenshot:

Could you try to remove the horizontal lines present in the Run cell icons? Maybe that would make them clearer :-)
I'd like to see the debug icons in light blue and not in red. I think that color is nicer to the eye.
I insist that I'd prefer a play-and-stop button for the Debug icon. First, we were harshly criticized in the past for using skeuomorphic icons. Second, that'd make the transition between the old and new themes easier to the eye. And third, I like the old icon much more than the new one because it delivers the idea of debugging better (I mean, from the point of view of a scientist): it's about interrupting execution at a certain point. Yes, sometimes it's to find bugs, but other times is just to inspect what the program is doing at that point.
The icon to open a folder next to the working directory toolbar should be the same as the one to open a file. That last icon is much better than the current one.
For the Python icon: could one snake be in black (say the top one), and the other in white? I think both snakes in black makes the icon too dense, i.e. not easy to grasp :-)

1 .2. 3. 5. Done (I used a stack icon for the Python logo (see screenshot)). I also have new icons for the outline explorer @blink1073 .
4. I need to draw the icon -> will do this tomorrow. Btw, don't you think that people will try using it as a button to Pause / Continue ?

@SylvainCorlay ,

I preferred the old icons you used for cells (removing the inside of the cells in gray).

I do not really like the look of the outline explorer icons. The font looks bad... Is this a limitation of the actual font in qtawesome? in which case maybe we need to define the fonts for those specific letters.

We should define a coherent color palette that is makes sense for the entire Spyder UI. It does not make sense to have pastel blue for icons in the debugger, a not so pastel green for run operations, and then a strong blue for the class icon in the outline explorer.

 Making them pixel perfect is going to be a manual work.
After posting the screenshot, I changed their "blue" color to the same as
the new debug part.
On Mon, Apr 20, 2015 at 4:43 AM, Gonzalo Peña-Castellanos <
<EMAIL_ADDRESS>wrote:

@SylvainCorlay https://github.com/SylvainCorlay ,

I preferred the old icons you used for cells (removing the inside of
the cells in gray).
2.
I do not really like the look of the outline explorer icons. The font
looks bad... Is this a limitation of the actual font in qtawesome? in which
case maybe we need to define the fonts for those specific letters.
3.
We should define a coherent color palette that is makes sense for the
entire Spyder UI. It does not make sense to have pastel blue for icons in
the debugger, a not so pastel green for run operations, and then a strong
blue for the class icon in the outline explorer.
—
Reply to this email directly or view it on GitHub
https://github.com/spyder-ide/spyder/pull/2260#issuecomment-94394973.

For instance... the Object Inspector currently follows the cerulean motive I believe...
So perhaps our colors should be consistent with that motive https://bootswatch.com/cerulean/

I actually prefer the default one. http://bootswatch.com/default/ This is what I started using when experimenting with sphinx + travis + qtawesome. http://sylvaincorlay.github.io/qtawesome/

Yes sure... but, the whole interface should be consistent (including the object inspector)

I agree.

Someone suggested that the TODO: FIXME etc.. should not be a check mark cause it gives the wrong impression that it is fixed... instead of giving the idea that is something pending. I agree with that, and we should perhaps change that, so todos etc should be maybe an exclamation mark instead of a check.

I disagree, every other editor I've used uses a check mark, and if you google image search for "todo icon", they are all check marks.

An exclamation point would work for FIXME though.

@blink1073, we can define some icons for each wording so it is clearer
@SylvainCorlay
We also should normalize the way we call certain things... we have Preferences, Settings and Options... We should have only two, I would vote for Preferences (Global as it is right now) and Settings for any specific panel or widget.
Preferences should have an icon and Settings should have a different icon.
The icon for Run Setting should then use the same icon as it uses for the other settings, so It should be a Play on Top of a Cog, instead of a Play on top of a Wrench.

I you (anyone) believe the button should be called options and use a Cog, then maybe we should change the name of the Run Settings to Run Preferences (and leave it like it is)

@SylvainCorlay, this is looking better and better with each iteration! Thanks a lot for your work on this one ;-)
Still of concern to me:

The cell icons are not clear enough. Why not try to emulate our current icons? I mean, they could be a transparent rectangle with a black border (to emulate a file), with another (smaller) rectangle in the center filled with a light grey color (to emulate a cell), and a play button next to it. I think you get the idea :-)
I think the Python icon would be better in black and white, or even better, black and transparent. That would make things more consistent with the rest of the theme.
What if we use the new Jupyter icon for our IPython consoles? The current one is not that good.

@ccordoba12

Yes, I have been coming back and forth different designs. Next time I edit the font, I will see if I can get better cell icons
Ok. In any case, this can be changed anytime. It is just an icon stack with two glyphs, one for the upper python and one for lower python.
Yes the current logo is a bit thin. Although Jupyter and IPython are two different things (IPython is the jupyter kernel for the Python programming language)

Btw, what do you think of my earlier remark on the debug icon?

Btw, what do you think of my earlier remark on the debug icon?

Sorry, I missed it :-) You're probably right. What other alternative do you propose besides the bug icon?

Yes the current logo is a bit thin. Although Jupyter and IPython are two different things (IPython is the jupyter kernel for the Python programming language)

Then we need to continue using the IPython icon :-)

Btw, what do you think of my earlier remark on the debug icon?

Sorry, I missed it :-) You're probably right. What other alternative do you propose besides the bug icon?

No idea. Maybe something like http://fortawesome.github.io/Font-Awesome/icon/sort-amount-asc/ but with equal-length lines...

@SylvainCorlay, I don't like too much. I still prefer play-and-pause

A stack with a play button and a terminal prompt icon?
http://fortawesome.github.io/Font-Awesome/icon/terminal/

@ccordoba12 I replaced it with the play-pause button.

Thanks!! I know I'm a hard b**ch to please, but I really think it looks better ;-)

I added an option to switch themes in the main settings, although you need to restart Spyder for it to be applied (The names of the themes are Spyder 2 and Spyder 3 themes).
I would still need to rework the outline explorer icons to be pixel perfect and make something a bit less rough for the icon manager. I am not renaming things to FreeDesktop naming conventions for now. This will be in a different PR where I want to also handle the system icons that are used in certain standard dialogs.
Question:

What is the cleanest way to say that Spyder depends on qtawesome? For now I just manually added qtawesome installation to the Travis script.

cleanest in terms of? It can be an optional dependency... in which case there is only one option in the preferences.
Now we can restart spyder, and I added support for asking the user if he wants to restart when an option (a combobox for now) has changed... so it can be coupled with that

I am making it the default theme in Spyder 3, and calling the old theme Spyder 2. Hence it is an actual dependency. Overall, I think that the new look is much more pleasant to work with overall.

Rebased to the latest master plus covered the new completion icons.

Rebased.

How about using git submodules for qtawesome (and for qtpy) ?
I finally tested this PR, it looks really great, and even more with the Breeze KDE theme I use.
I have a few comments (that could maybe be fixed in another PR)

In the preferences I'd put the Icon choice after the Theme choice, not before.
A QGridLayout would look better for these options so that the comboboxes are aligned.
The icons in the toolbars are quite big. Since I usually hide all toolboxes i don't know if it's an actual problem.
The icons for functions, classes and so on are good, the colors are clearly different, but I find the text on them too thin so their signification is not clear at first sight. They look a bit blurred, maybe it's because their size makes them not pixel perfect ? Also maybe I'm just not used to them.
The folder icon for the Run properties (F6) is not centered in the pushbutton:

@nodd, thanks for the positive feedback. Regarding the point raised.

preference order: ok
QGrilLayout: ok
Indeed it is bigger than before. I picked a multiple of the pixel perfect size. With the font-bearing, a 16px icons results in a 14px font size which is the targeted pixel-perfect size -> picked 32.
I have not made pixel-perfect circled letters. This is quite difficult actually. I will probably get back to this after the PR.
Regarding the folder icon, I need to look into it!

submodules would be a way to avoid the hassle of having to package qtpy and qtawesome in the different package managers that distribute Spyder. However they remain a half-baked feature of git. For example, removing cleanly a submodule requires touching subdirectories of the .git repo. There are all kinds of other annoyances with it in my opinion.

@Nodd or @SylvainCorlay can you post an updated screenshot of it is looking so far :-) ?

Here it is.

Great work @SylvainCorlay, looking pretty!

rebased

Done. Now Spyder restarts when changing the icon theme.

Btw, @ccordoba12 , with the latest Anaconda, and Ubuntu, Spyder does not have icons in the menubars. (Either with the master branch, or the version released with Anaconda).

@ccordoba12 I think you should definitely have this on your SciPy talk, so even if it is not perfect right now and some icons might need tweaking we should try to push this PR forward, or @SylvainCorlay will loose his mind soon.

I was also thinking we should merge this as it is, and finish the problematic icons later.
@SylvainCorlay:

I don't know what's happening with Anaconda, I'll investigate later today.
Is this ready to merge?

This PR depends on qtawesome but does not list it as a dependency in the setup.py, so either we need to add ti to external-py... or change the setup.py
@SylvainCorlay ?

Hey @ccordoba12

We need to figure out what to do with dependencies. In that regard, it is not ready to be merged.
Regarding the specific icon design discussions, I will open other PRs as more feedback comes. I am sure that more will come as soon as it is in master. See e.g. https://github.com/FortAwesome/Font-Awesome/issues/6619 (please +1)
This modifies a lot of files and it is painful to rebase when other PRs get merged.

I think we should add qtawesome directly to spyder inside external-py so that master works without installing something. When spyder 3.0 is due to be released we might consider making it a dependency in setup.py.

Instead of external-py#, which is not shipped in our source based installers (only on the Windows ones), we should use
spyderlib/utils/external

We could even move this dir to
spyderlib/external

to avoid long import statements. And we should also add qtpy there too.
My rationale for this is:

We control both projects and their release dates, so we can easily copy/paste their codes in this folder when we do new releases.
I don't expect these projects to have a lot of movement, which would justify using submodules.

Ok for submodules. It makes sense for this usecase.

sure!

The problem with submodules is that we'd need to add some special magic to allow people to install Spyder from master.
That's why I think it should be easier just to do copy/paste's when updates are needed. That's what we already do with pep8, for example :-)

What magic is required if the users clone it with --recursive?

Btw, I solved the alignment issue, and switched to the three-lines version of the debug action buttons.

:+1: for spyderlib/external.
+0 for submodules. Those are nice but add some complexity and I'm not sure it's worth it.

Just moved qtawesome to spyderlib/external.

Sweet. Then we should merge and test now

Well you have merge privileges ;)

I would but I do not want make @ccordoba12 angry :imp:

I just tested this branch and have one complaint: the toolbar icons are too big (30x30?). I'd like to see them at the same size as they are now before merging.

Done.

The reason why I increased the size is to use a pixel-perfect size. (qtawesome icons are pixel-perfect at 16px (which corresponds to a font size of 14px, the pixel perfect size of font-awesome).
I am sure there will be changes to be made after this is merged. That is why I think it is preferable to merge it long ahead of a release. (it also touches a lot of files). I will open PRs for specific icon changes like a re-design of the run-cell icons and the circled letters icons of the outline manager.
Best,

This is beautiful. Thanks so much everyone for your work on Spyder!
On Sat, Jun 6, 2015 at 8:50 AM, Sylvain Corlay<EMAIL_ADDRESS>wrote:

Done.

The reason why I increased the size is to use a pixel-perfect size.
(qtawesome icons are pixel-perfect at 16px (which corresponds to a font
size of 14px, the pixel perfect size of font-awesome).
I am sure there will be changes to be made after this is merged.
That is why I think it is preferable to merge it long ahead of a release.
(it also touches a lot of files). I will open PRs for specific icon changes
like a re-design of the run-cell icons and the circled letters icons of the
outline manager. Best,

—
Reply to this email directly or view it on GitHub
https://github.com/spyder-ide/spyder/pull/2260#issuecomment-109606755.

Ok, first review done.

@ccordoba12 I moved the icon manager, followed your suggestions.

for the pythonpath icons, there were two png files which were the same icon with different sizes. I just use the bigger one now (hence only one entry in the icon manager)
there was no package_collapsed.png file anyway.
I propose to use the same image for window_nofullscreen and collapse. The icons are essentially the same and I don't see the point of having multiple entries in the manager. I now use the image file of the nofullscreen, which is the one of the main toolbar. The other image was only used in the profiler and onecolumntree.

@ccordoba12 I have done the requested changes.

@ccordoba12 any update?

Yes, please make Spyder 2 the default theme for now. When Spyder 3 is finished, we can make it the default :-)

Done. The merge button is in the lower-right area of the page ;)

Ok, waiting to hear from Travis before pressing the green button!
I tested things in Qt4 and 5 and I'm glad to report they are working fine :-)

Awesome. There are a couple of icon related prs coming your way, that depend on this.

Ok, here we go!

@SylvainCorlay, I just noticed some small errors after merging (damn!): Some icons that are inherited from the operating system are missing in Spyder 2!
The ones I can't see after a quick inspection are:

in the Working directory toolbar: Browse a working dir
In the File Explorer plugin: Previous and next buttons
In the Find widget (i.e. the one you get after pressing Ctrl+F in the Editor): Next result

Please fix these issues ASAP :-)

Hum this should work normally. I will fix tonight.

I see what is going on. The commit where I fixed this was lost in a rebase. It is really simple.

@ccordoba12 : fixed in #2480.


[Wait for #2166] [ Tensor ] Support NHWC for multiply and divide  @open sesame 04/06 09:40

This PR includes changes of Tensor and TensorDim to support NHWC
computation for multiply and divide. It also includes unittests to
evaluate.
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: jijoong.moon<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2172. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @jijoongmoon, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2172-202304061655500.054980993270874-9b253f53d9d7e2ec6b2f9364658c6f61de63e5c7/.

This is included #2238


Clearly mark F# script

To avoid confusing users interested in precompiled F#.

@jrr : Thanks for your contribution! The author, @ggailey777, has been notified to review your proposed change.

Thanks @jrr! #sign-off


Cache diagnostic mode config during server start up

Purpose

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7880952769

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7880952769
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7882264404

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7882264404
Status: failure

Covered with https://github.com/wso2/carbon-kernel/pull/3872


IN and NOT IN operators not implemented for Numeric field

I needed to query for incidents in state 6, 7, or 8 as well as those not in state 6, 7, or 8. I did not see an obvious way to do this. I was able to add the following functions to the Numeric() class in the numeric.py module to get what I needed:
def in_list(self, value):
    """
    Example: impact.in_list([3, 4])

    All records in which the Impact field has one of the values 3 or 4.
    """

    value = ",".join(str(v) for v in value)
    return self._condition(NumericOperator.ONEOF, value)

def not_in_list(self, value):
    """
    Example: impact.not_in_list([3, 4])

    All records in which the Impact field does not have one of the values 3 or 4.
    """

    value = ",".join(str(v) for v in value)
    return self._condition(NumericOperator.NOT_ONEOF, value)

I used the following in my select() to use it:
Incident.incident_state.not_in_list([6, 7, 8])
Should I have done this a different way?

Added in https://github.com/rbw/snow/pull/41
Thanks for your contributions btw - appreciated.

Fixed in 0.2.1


Wrong input key for Cohere models in BedrockLLM

I'm using the cohere.command-r-v1:0 model to test some prompts. After noticing that Cohere doesn't support Chat #33, I changed to BedrockLLM. However I keep getting the following message:
ValueError: Error raised by bedrock service: An error occurred (ValidationException) when calling the InvokeModel operation: Malformed input request: #: required key [message] not found#: extraneous key [prompt] is not permitted, please reformat your input and try again.
I have tried several methods including:
import boto3

session = boto3.Session(region_name=region)
boto3_bedrock = session.client(service_name="bedrock-runtime")

llm = BedrockLLM(region_name="us-east-1", model_id="cohere.command-r-v1:0" client=boto3_bedrock, verbose=verbose)
llm.invoke("Hey") # Fails

# ----------------------------------

prompt = ChatPromptTemplate.from_messages(
        [
            ("system", "You are a greeting chatbot, greet users only"),
            ("human", "{greeting}"),
        ]
    )
chain = (prompt | llm)

chain.invoke({"greeting": "Hey"}) # Fails

After validating the error message and line 134 in libs/aws/langchain_aws/llm/bedrock  I think it should be rewritten as:
@classmethod
def prepare_input(
    cls,
    provider: str,
    model_kwargs: Dict[str, Any],
    prompt: Optional[str] = None,
    system: Optional[str] = None,
    messages: Optional[List[Dict]] = None,
) -> Dict[str, Any]:
    input_body = {**model_kwargs}
    if provider == "anthropic":
        if messages:
            input_body["anthropic_version"] = "bedrock-2023-05-31"
            input_body["messages"] = messages
            if system:
                input_body["system"] = system
            if "max_tokens" not in input_body:
                input_body["max_tokens"] = 1024
        if prompt:
            input_body["prompt"] = _human_assistant_format(prompt)
            if "max_tokens_to_sample" not in input_body:
                input_body["max_tokens_to_sample"] = 1024
    elif provider == "cohere"):
        input_body["message"] = prompt
    elif provider in ("ai21", "meta", "mistral"):
        input_body["prompt"] = prompt
    elif provider == "amazon":
        input_body = dict()
        input_body["inputText"] = prompt
        input_body["textGenerationConfig"] = {**model_kwargs}
    else:
        input_body["inputText"] = prompt

    return input_body

Here are my dependencies:
langchain==0.1.19
langchain-aws==0.1.3
I'm using Python 3.11

Hello.
I am facing the same problem.
I think the format of json_body is different between command-r and command, so I have to rewrite the following.
  # Command-R
  if messages:
      input_body["chat_history"] = messages['chat_history']
      input_body["message"] = messages['message']
  # Command
  else:
      input_body["prompt"] = prompt

I assume that Command R will be currently unsupported, just as Claude3 does not support BedrockBase.
https://github.com/langchain-ai/langchain-aws/blob/main/libs/aws/langchain_aws/llms/bedrock.py#L744
    @root_validator()
    def validate_environment(cls, values: Dict) -> Dict:
        model_id = values["model_id"]
        if model_id.startswith("anthropic.claude-3"):
            raise ValueError(
                "Claude v3 models are not supported by this LLM."
                "Please use `from langchain_community.chat_models import BedrockChat` "
                "instead."
            )
        return super().validate_environment(values)

It would be better to use ChatBedrock for this purpose.
I am now implementing my own Rv request with the following PR.
https://github.com/langchain-ai/langchain-aws/pull/42

I was trying to do my own commit; however, I'm not really sure how to locally test it. Any pointers @ksaegusa?

@HFR1994
I followed the steps below to install my repository locally:
git clone https://github.com/ksaegusa/langchain-aws.git
cd langchain-aws
git switch add_cohere_model
pip install -e libs/aws/

After that, I wrote a simple script to verify the functionality.

I hope this answers your question

Thanks for this update!
Any news on when https://github.com/langchain-ai/langchain-aws/issues/43 will be merged?

Use ChatModelConverse or ChatBedrock(beta_use_converse_api=True), as mentioned in #238. We will be tracking any new gaps with cohere in that issue, please feel free to comment there.


Number of private endpoints per subscription is not 64000.

[Enter feedback here]
Number of private endpoints per subscription  is NOT 64000, which should be 65536.
https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/azure-subscription-service-limits#private-link-limits
Please check Portal.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 36f49a06-90b1-cbe1-3853-2c38277b79f8
Version Independent ID: 02ff6f6c-3ef6-b48f-060d-b290419e0aba
Content: Azure subscription limits and quotas - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/azure-subscription-service-limits.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@yinoa Thanks for bringing it to our attention. We will review it and update as appropriate.

@yinoa Thanks for bringing it to our attention. We will review it and update as appropriate.

@tfitzmac FYI. Please review and update the documentation.

@tfitzmac FYI. Please review and update the documentation.

@KumudD - it looks like the private link limit is 65536 per region per subscription. Do you know if that is correct? Should the 64000 be updated?

@KumudD - it looks like the private link limit is 65536 per region per subscription. Do you know if that is correct? Should the 64000 be updated?

@sumeetmittal @malopMSFT Please can you confirm the private link limit value per region per subscription. Thanks!

@sumeetmittal @malopMSFT Please can you confirm the private link limit value per region per subscription. Thanks!

Any update?

Any update?

@sumeetmittal @malopMSFT - the portal indicates that the number of private endpoints is 65536 per region per subscription. However, the documentation states the limit is 64000 per subscription. Does the documentation need to be updated?

@yinoa | @tfitzmac
Apologies on the delayed response. So the confusion lies in the fact that our portal experience displays the limit based on Kibibyte = 1024 and not Kilobtes = 1000.
So essential the limit is 64k on documentation but that is 64* 1024 = 65,536. Though this is an upper limit, we do not encourage customers to stress test this as

Latency with creating private endpoints is greatly increased the closer you are towards the limit ~84secs per pe
There will be an error thrown if you pass 65,536

@ivapplyr - thanks for this information. Do you know if the limit is applied per region or per subscription?

@tfitzmac  per subscription

It sounds like there is no doc update.
#please-close


L515-How to use IMU data (stored in bag file) to calculate camera extrinsics (in OpenGL or OpenCV)?

Closed as duplicate.


iOS: File Not Received While App is in Background + Background Task Assertion

So after struggling with getting everything set up correctly I finally have this working so that I can send a file on iOS and it's received by my app, BUT the event handler is only called when I switch back over to my app and until I do that the sent file is sitting in limbo.
Running in debug mode against my phone from Xcode I can see that the plugin initialized successfully, and nothing is logged indicating an issue. I switch over to Photos and do the open-with action and select my app, then I get the dialog showing the selected image and can enter a message. I tap Post and the window closes, but my handler is not invoked. It's only when I switch over to my app that I get the following:
[ProcessSuspension] 0x######## - WKProcessAssertionBackgroundTaskManager: Ignored request to start a new background task because the application is already in the background
[ProcessSuspension] 0x######## - WKProcessAssertionBackgroundTaskManager: Ignored request to start a new background task because the application is already in the background
intent received
...
THREAD WARNING: ['OpenWithPlugin'] took '776.545898' ms. Plugin should use a background thread.

Similarly, if my app isn't running and I use the open-with action from Photos it doesn't cause my app to open. When I then run my app in debug mode using Xcode it picks up the message once the app loads, but logs the following warning:
THREAD WARNING: ['OpenWithPlugin'] took '57.57021' ms. Plugin should use a background thread.
openwith initialized
intent received
...

The 'openwith initialized' message is one I'm logging in the success callback of cordova.openwith.init
After either switching to my app or starting it running the phone immediately switches me back over to the Photos app, away from my app even though it only activated my app when I switched over to it or started it running.
I'm really hoping I'm doing something incorrect here and that the plugin should be activating my app if it's not running or is in the background to process the openwith handler. The communication does seem to be happening and the App Group, etc., seem to be properly configured because it's capable of sending and receiving the file, but having to manually activate / run the app in order to get it receive the sent file isn't really practical because for the user it seems like they sent their file, but nothing happened.
This is using version 2.0.0 of the plugin and I'm running Xcode 11.5 and iOS 13.5.1 on an iPhone.

You are not alone.
My feeling is that the plugin uses the wrong events to detect changes at launch and only the onResume is detected.


push version v0.2.0, update dependency of websocket

I was just in the "tagzzz all of the packagezzz!" mood, so I thought I'd push a new version of plotly too. I believe I can tag the master branch. I'll see once this is merged.
With the changes that happened since v0.1.0, I guess a new release was overdue anyways, haha.
Note that I just selected the current websocket version, since I don't know anymore which version had the last breaking change (I know there was one).

Ah, nice. Pushing the tag worked.


flathub: user tracking and respecting user privacy

Hello,
I noticed that when I'm on flathub, Firefox blocks by default
Tracking:

Google Analytics
Browser-update.org (?)

Is this right place to ask, why Flathub

doesn't work without JS (even over the fact it's very simple page I see) [8 months old issue],
doesn't include privacy policy page [3 years old issue]
didn't yet replaced Google Analytics with Mamoto or whatever else [already 2 years since the issue]

?
As we produce our software to respect users data and privacy, would be great, if platform as Flathub did the same.

Hello,
I noticed that when I'm on flathub, Firefox blocks by default
Tracking:
* Google Analytics

* Browser-update.org (?)

Is this right place to ask, why Flathub
* [doesn't work without JS](https://github.com/flathub/linux-store-frontend/issues/219) (even over the fact it's very simple page I see) [8 months old issue],

Flathub will always require JS.

* doesn't include [privacy policy page](https://github.com/flathub/linux-store-frontend/issues/24) [3 years old issue]

Why duplicate the issue then?

* didn't yet replaced [Google Analytics with Mamoto](https://github.com/flathub/linux-store-frontend/issues/162) or whatever else [already 2 years since the issue]

Same here.

Because it's like no-one gives attention to it. We (GNOME apps) should publish on Flathub, but it fails to provide even basic features (like privacy policy) to it's users. That's terrible.

Sure, it's an open source project and contributions are very much welcome. There's some WIP thing to replace the frontend with something better & does replace the Google Analytics with something else.
Closing this one as it doesn't bring anything new, please leave a comment on those issues if you have anything to add or plan to contribute to the website itself

@bilelmoussaoui have you considered reply to the JS issue and close it then, why you're so agile and closing this one?

Because this one is a duplicate :) I will have a look at the other issue

Google Analytics was removed in #270

Also I noticed that Browser-update.org tracking warning disappeared.
Thank you!


URL encode non ASCII characters using UTF-8

Fixes https://github.com/request/request/issues/926
Fixes https://github.com/request/request/issues/1678
Closes https://github.com/request/request/pull/2004

This PR has been closed as "abandoned" as a part of an automated cleanup. If this is a mistake and you are still interested in merging this PR, please do the following:

[ ] Rebase your changes onto the master branch (even if there are no merge conflicts, we want to make sure your change is under the most recent tests).
[ ] Push your updated branch to Github to update this PR.
[ ] Make sure this PR's Travis tests are still passing. (Run npm test locally if tests are still failing).
[ ] Comment here to let us know that you've updated the PR and are still interested in getting it merged. Somebody from the project will respond and work with you to review.

Thank you for your understanding. If you have any questions, please check out https://github.com/request/request/issues/2556 and feel free to comment / ask anything there.


Bump grpc to 1.45 (latest point release is 1.45.2)

I also got the tests running in the build. Hopefully this will speed up the process with which we can accept external PRs

I wonder if we should release 1.43_0 and 1.44_0 before 1.45_0 for the community.

Yes, we probably should stay on top of these and do so (they've also already released 1.46 fwiw)

I wonder if we should release 1.43_0 and 1.44_0 before 1.45_0 for the community.

Yes, we probably should stay on top of these and do so (they've also already released 1.46 fwiw)

@ido-namely should I just turn this pr into 1.43_0, so we can have a better PR experience for 1.44_0 and later?

I wonder if we should release 1.43_0 and 1.44_0 before 1.45_0 for the community.

Yes, we probably should stay on top of these and do so (they've also already released 1.46 fwiw)

@ido-namely should I just turn this pr into 1.43_0, so we can have a better PR experience for 1.44_0 and later?

Yes, that's what I was thinking too.

Thank you for all the work, especially around testing in the CI.

I'd love it if we didn't need to do a pr to release a new version, and just base it off the tags... Maybe one day 😄

Thank you for all the work, especially around testing in the CI.

I'd love it if we didn't need to do a pr to release a new version, and just base it off the tags... Maybe one day 😄

Me too, but on the other hand I do prefer the version to be sourced controlled.
I think it would be great if we utilize Renovate (example) to open these PRs automatically. Now with your addition of the tests to the CI it would make everything much easier.

Thank you for all the work, especially around testing in the CI.

I'd love it if we didn't need to do a pr to release a new version, and just base it off the tags... Maybe one day 😄

Me too, but on the other hand I do prefer the version to be sourced controlled. I think it would be great if we utilize Renovate (example) to open these PRs automatically. Now with your addition of the tests to the CI it would make everything much easier.

Yeah, that seems nice. I wonder if we can enable that for this repo, or if not, if dependabot could be configured to do so

Generally, is it expected that error messages will go to stdout instead of stderr in the pertinent scripts?
Normally I echo >&2 ... for errors, but these scripts might be special cases.

I can modify it to do that. These are home grown tests that were written by people who might not be that familiar with bash/linux scripting... Like I thought about doing color coding on the pass/fail statements, but I don't really know how to do that, and it seemed like a lot of effort, so I just went with the incremental improvements


Error message when trying to save a file

From<EMAIL_ADDRESS>on 2012-06-18T08:59:47Z
Spyder Version:  2.2.0dev
Python Version:  2.7.3
Qt Version:      4.8.1, PyQt4 (API v1) 4.9.1 on Linux
What steps will reproduce the problem?
1, Saving a file in editor.
When I run spyder --reset, then it is ok to save about 2 or 3 files, but after that it produces the error every time I try to save a file. At least for most files. What is the expected output? What do you see instead? I expect the file to be saved without a problem.
Instead I see messages like this:
"Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/spyderlib/plugins/editor.py", line 1586, in save
return editorstack.save(index=index, force=force)
File "/usr/local/lib/python2.7/dist-packages/spyderlib/widgets/editor.py", line 1312, in save
self.emit(SIGNAL('file_saved(long,long)'), id(self), index)
TypeError: file_saved(long,long).emit(): argument 1 has unexpected type 'long'"
The file is, however, in most cases saved, but spyder does not recognize it is saved.
Please provide any additional information below
.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=1094

From ccordoba12 on 2012-07-04T07:38:58Z
I haven't seen this error, but it seems quite serious.
Several questions:

How many files do you have opened when tryint to save?
Are you trying to save from an Editor window? I mean, the one you can create using the option 'New window' from the Editor options menu?
What distro are you using?

Summary: Error message when trying to save a file
Labels: Cat-Editor MS-v2.2

From ccordoba12 on 2012-07-04T07:39:22Z
issue #1098 has been merged into this issue.

From<EMAIL_ADDRESS>on 2012-07-04T08:53:55Z
Hi,
first I have to tell that I protected the
"self.emit(SIGNAL('file_saved(long,long)'), id(self), index)" line with a try -- except block and since then everything seems to be working fine.
I admit I have no idea of what this line should be doing.
But anyway, I have no recent memory of how exactly the error is occuring.

I didn't really observe any connection between number of files open and the error.
No, I tried saving from the Editor part of the main spyder window.
I never used the editor window, so I don't know if the error occurs there or not.
I use Ubuntu 12.04

Let me know if you need any more details, I will try to collect more information for the above questions.

From<EMAIL_ADDRESS>on 2012-07-04T09:11:29Z
And also changed this line:
editor.go_to_line(clines[index])
to this:
editor.go_to_line(clines[min(index,len(clines)-1)])
(Around line 2000)

From pierre.raybaut on 2012-07-28T00:35:07Z
Handling the error by placing the code block in a try...except statement is not the right approach here as the signal is triggering actions to be performed when saving files.
Try moving tabs in the Console plugin, you should have the same kind of error if I understand it correctly.
Then using one of the attached patchs should work.
Please keep us posted.
Attachment: patch_for_v2.1.10.diff patch_for_v2.2.0dev.diff

From<EMAIL_ADDRESS>on 2012-07-31T13:21:10Z
Hello pierre, I try to apply the patch for v2.1.10.diff but I can not apply it cleanly
with
patch -p1 < blabla.diff
is seems that the patch is for a windows machine and I am working on a unix one :)
(Stripping trailing CRs from patch.)
patching file spyderlib/plugins/editor.py
Hunk #1 FAILED at 997.
Hunk #2 FAILED at 1052.
2 out of 2 hunks FAILED -- saving rejects to file spyderlib/plugins/editor.py.rej
(Stripping trailing CRs from patch.)
patching file spyderlib/widgets/editor.py
Hunk #1 FAILED at 1194.
Hunk #2 FAILED at 1285.
Hunk #3 FAILED at 2327.
Hunk #4 FAILED at 2370.
4 out of 4 hunks FAILED -- saving rejects to file spyderlib/widgets/editor.py.rej
(Stripping trailing CRs from patch.)
patching file spyderlib/widgets/tabs.py
Hunk #1 FAILED at 76.
Hunk #2 FAILED at 246.
Hunk #3 FAILED at 303.
3 out of 3 hunks FAILED -- saving rejects to file spyderlib/widgets/tabs.py.rej

From ccordoba12 on 2012-07-06T08:27:34Z
issue #1098 has been merged into this issue.

From<EMAIL_ADDRESS>on 2012-07-31T13:24:05Z
picca@mordor:~/Debian/main/spyder/spyder$ file spyderlib/plugins/editor.py
spyderlib/plugins/editor.py: Python script, UTF-8 Unicode (with BOM) text executable, with CRLF line terminators

From<EMAIL_ADDRESS>on 2012-07-31T13:47:45Z
ok, here a patch which works on top of 2.1.10 in Debian.
Attachment: 0003-from-upstream-fix-1098.patch

From pierre.raybaut on 2012-08-01T00:17:44Z
Ok, so apart from the Windows/Linux compatibility issue, I assume that the patch is working? (it's actually fixing this bug?)
Status: Started

From<EMAIL_ADDRESS>on 2012-08-01T01:25:41Z
hi Pierre,
so now I applied the patch. It wasn't easy, since I wasn't sure which version to patch against. And also wasn't sure which patch file to use.
I think I was using the 2.2.0dev version, originally but downloaded the latest widgets/editor.py from mercurial.
The 0003-from-upstream-fix-1098.patch worked on plugins/editor.py and on widgets/tabs.py, but not on widgets/editor.py. (not the 2.2.0dev and not the mercurial version)
Then I tried the patch_for_v2.2.0dev.diff which worked on widgets/editor.py but not on the other two.
I will try now and see how it works. But since my spyder is now getting to be a mess of many different versions, there is a pretty good chance that it won't.
Then I'll probably have to get the latest from mercurial.
Regarding moving tabs:
I have to admit I don't know how. Tried the obvious with the mouse, but didn't work.

From<EMAIL_ADDRESS>on 2012-08-01T02:42:45Z
It seems something is really messed up with my installation.
I get the following message when I try to set a breakpoint.
File "/usr/local/lib/python2.7/dist-packages/spyderlib/widgets/editor.py", line 475, in breakpoints_changed
if self.editor.breakpoints != breakpoints:
AttributeError: 'CodeEditor' object has no attribute 'breakpoints'
It seems I have to reinstall

From pierre.raybaut on 2012-08-01T03:08:58Z
The patches that I've attached earlier should be working with the latest mercurial revisions of bothe v21 and default branches.

From pierre.raybaut on 2012-09-09T09:58:07Z
This issue was updated by revision 6260313cb49b .
Status: Fixed


feat: Add GET /markets/{marketSymbol}/ticker endpoint

Signed-off-by: Alexandre Ferreira<EMAIL_ADDRESS>

Codecov Report

Merging #1 (65543e0) into main (495b3b4) will increase coverage by 0.17%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
+ Coverage   36.15%   36.32%   +0.17%
==========================================
  Files           3        3
  Lines         260      267       +7
==========================================
+ Hits           94       97       +3
- Misses        144      148       +4
  Partials       22       22

Impacted Files
Coverage Δ

bittrex/bittrex.go
46.87% <57.14%> (+2.87%)
:arrow_up:

bittrex/ws.go
41.73% <0.00%> (-0.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495b3b4...65543e0. Read the comment docs.


ElementLocations should change less often during small edits

The following ElementLocations use character-based offsets.
FunctionElement
ImportElement
LocalVariableElement (delta from enclosing element)
I found these by looking at overrides of "get identifier".
Using character offsets in locations makes them unstable while making even minor edits. Whenever an ElementLocation changes, the incremental resolver needs to invalidate entries in the AnalyzerCache. As a result we do more work than needed.
There may be a performance win by not doing this work, but I don't think we know how much yet. (As far as I can tell, Elements are used as keys only for constant evaluation.)

Here is one possibility: Elements form a tree, and each parent has a list of children beneath it. When there's no suitable name, perhaps we could use the offset into the parent's list of children?
This would be robust against small edits that don't change child order (such as reformatting code or editing comments). Larger edits (such as inserting a new child into the list or reordering children) would require more recalculation.

Experimental attempt at this: https://codereview.chromium.org/1658333003/
(I don't plan to do any further work on this for now.)


cConsole template maitainance

@hiagofranco as maintainer of this template, would like to continue maintaining?
The next update will bump major, with breaking changes, and we will clean the templates. Let us know.
#268

Hi @microhobby, thanks for the message, I will not maintain it anymore since I am not using it, so it does not make sense to me to maintain it. If someone wants to take over, please proceed. Thanks!

Hi @microhobby
I don't use it in production, but I use it to do some testing.
Can you explain a little bit what is the effort to be a mantainer for a template?
So that I can evaluate if I can take this role or not.

Hello @escherstair,
The effort of being a maintainer for the template is maintaining the template updated and ideally checking with some frequency that the template is working. Also, if we or someone reports an issue on the template the maintainer is responsible for fixing it.
For the cConsole in specific it should not be a big effort to maintain it as the technologies related with the C language and this specific template (compiler, toolchain, Makefile, etc) don't require many updates. Also, this template is almost identical with the cppConsole template, so when we do updates related to the template on the cppConsole we also do for this one. So, most of the time, being a maintainer on this template will basically be making sure that it has received the same updates as the cppConsole template, and also fix issues on the template when someone reports or you find one (with our help to do so if you like needed).


Use AndroidX support lib

Summary:
Use AndroidX in place of legacy Android support libraries. This is required for any Android projects that use AndroidX for support libraries.
See: https://developer.android.com/jetpack/androidx/migrate
Specifically react-native-gesture-handler currently has a 4 PRs to migrate to AndroidX being blocked by this down stream dependency for our tests that require react-native-slider.

@aarongrider Can you please check the comments above? I'll be glad to merge your PR after you resolve the discussion.

Happy to try and resolve, but I'm wondering if we should wait to merge this until RN 60 is released with AndroidX support. As far as I understand, AndroidX projects are incompatible with legacy support projects when compiled from source. This library shouldn't be a huge issue for consumers since you distribute compiled aar's, but it's something we should keep in mind.

How about splitting it into two PRs, one for Gradle cleanup and AndroidX.

+1 for what @dulmandakh said. I'd appreciate grade cleanup in this PR, leaving AndroidX support to 0.60 release.
Btw. I've just merged detox PR which conflicts with this PR. sorry about that. Thanks for all the work @aarongrider

Sounds good! Will do.

seeing this issue today #82 after these releases: https://developers.google.com/android/guides/releases
is there any movement on this? There are many libraries in the RN community that are affected since they use old support dependencies

I have the same question, the app doesn't work, the problem is pretty similar to the issue #82

@Taylor123 @natasha08n I'm working on 0.60 update, you can expect rc version soon

Sorry @aarongrider, I'm deeply sorry, but I have to close this PR. I've tried to use your changes in 0.60 update PR, but there were too many conflicting files since I had to re-create example from the scratch. Also, most of these changes aren't suitable for a final 0.60 release, please refer to the https://github.com/react-native-community/react-native-slider/pull/87 for AndroidX support.


onEnterRules add prefix on newline inside Javadoc

Add some onEnterRules to Java language configuration to add the usual prefix (*) when inserting a new line in Javadoc.
Those were actually copied from typescript language configuration which shares the same syntax for comments.

@alexr00 thanks, newer version of this PR should cover your comments.


Toolbar not goes up when tapped in textview

Hi,
I am facing this issue. I have integrate QMCHATVIEWCONTROLLER in my project.
Expectation :- Inputtoolbar should go above the keyboard.
I am using cocoapod.

@ErAshu, What version of QMChatVC do you use?

I also have this issue @VitaliyGuru ... not sure how to check the version?

Using MBProgressHUD (0.9.2)
Using QMChatViewController (<IP_ADDRESS>)
Using QMServices (0.4.5)
Using QuickBlox (2.9)
Using SDWebImage (3.8.2)
Using SVProgressHUD (2.0.4)
Using TTTAttributedLabel (2.0.0)


uber-licence adds duplicate licence header with incorrect year (2015)

Running uber-licence on files with the most recent year (2016) results in a duplicate licence being added to the top of the file with an outdated year.
Example diff after running uber-licence:
--- a/test/admin-tests.js
+++ b/test/admin-tests.js
@@ -1,3 +1,23 @@
+// Copyright (c) 2015 Uber Technologies, Inc.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+
 // Copyright (c) 2016 Uber Technologies, Inc.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy

Fixed in 2.0.1.


Intercept or inspect pre-normalized path

Hi folks,
I was hoping someone with a reasonable familiarity with IIS's inner workings could take a look at this question on Stack Overflow. I'm having trouble understanding where path normalization (the function that follows these lines, maybe?) occurs in the request life-cycle, and whether I can operate at any level on the pre-normalized path without doing something wildly inadvisable.
Thank you.

I have responded to the question on Stack Overflow. Let me know if you have additional concerns there.


Refactor/curp client

Please briefly answer these questions:

what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Introduce the new client architecture.

what changes does this pull request make?
As above

are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No

There's a tmp commit message in 8c5313f9a6a8c290af5bc8628869eb9660c48b27

There's a tmp commit message in 8c5313f

Reworded


Automatically replace 'YourReferenceHere' with author-name and year where possible.

YourReferenceHere seems to be hard-coded on this line:
https://github.com/citation-file-format/cffconvert/blob/b6045d78aac9e02b039703b030588d54d53262ac/src/cffconvert/lib/cff_1_x_x/bibtex.py#L31
It would be better to replace this with something like:
try:
    ref_alias = self.author[10:].replace(" and ",", ").split(",")[0] + self.year[10:12]
except:
    ref_alias = "YourReferenceHere"
return "@misc{"+ref_alias+",\n" + joined + "\n}\n"

Hi Nik, thanks for making this issue. I don't think there is a way to automatically create the label such that it fits everybody's preferred way, hence I'm choosing to leave it as-is. However, a reference manager might be able to do what you want, see for example here https://docs.jabref.org/setup/citationkeypatterns


Add prompt before shutdown

Small edit of the Poweroff app to add a prompt and prevent accidental shutdown

Thanks! Although I think this PR might accidentally contain some slopeclockpp changes too?
If you do a PR from your master branch on GitHub and then make more changes, those get mirrored too. Is it possible to do a new PR with just the poweroff changes?

Ah, sorry about that. Here's the correct one: https://github.com/espruino/BangleApps/pull/2969


Migrate to Gradle Kotlin DSL

It'd be a great aid to actually make the CI match what we have in Kord or Kordx emojis.

It'd be a great aid to actually make the CI match what we have in Kord or Kordx emojis.


backport: Switch RNG to PRNG/Add RNG strengthening (10ms once every minute)

Cherry-picked from:
https://github.com/bitcoin/bitcoin/pull/14955
https://github.com/bitcoin/bitcoin/pull/15224
Rebased on #3521, #3511, #3520, #3487 and #3466.

I managed to cut #3466 by casting randData to unsigned char* as a temporary workaround until people decide on that PR. I also needed the rest of the commits from #3520 but rebased on top of #3313. If this branch looks ok I can push here and work to get it cleaned up. No worries if not though.

In hindsight, I remember comments from #3313 that some of the picks from #3520 cause the UB problem again so I'll keep working on this.

I managed to cut #3466 by casting randData to unsigned char* as a temporary workaround

I left you a comment on that commit because that solution's not right.
If you want to initialize 50,001 bytes with random data of max 32 bytes at a time, you'll need to loop through it.

Built and tested (unit, qa) on Ubuntu 22.04.4 LTS x86_64.
Also did some basic GUI testing (new receiving address, generate block) with no errors.


autoname doens't generate a name if options object is present

Signal / Memo options are usually used to customize the equals function, so the name option could still be generated.

this one is actually already working


Builds with ndarray backend <0.15 and using ndarray-linalg fail

Due to this, all builds using the ndarray backend <0.15 and using the ndarray-linalg feature fail, and it seems they will continue to fail forever. Therefore support for older ndarray backends (at least when using the *-linalg feature) should be and will be removed.

Fixed in #504


Upgrade to FFTM 1.2.2

Signed-off-by: Matthew Whitehead<EMAIL_ADDRESS>

I think this go.mod file was created with an older version of Go. This PR is superseded by:
https://github.com/hyperledger/firefly-evmconnect/pull/49


Progress bar shows up as lots of question marks in windows

This probably can be fixed by encoding all strings in TerminalIO.print method like this:
"some that should be printed to screen.".getBytes(StandardCharsets.UTF_8)
We could also encode the strings from the prompts to utf8 encoding. I am not sure what encoding tmc-core uses, but if it uses system's default encoding then we can just encode it back to default character set at tmc utils.

This is encoding problem at Windows terminal. This can be fixed by setting encoding into UTF-8.


DPS update speed

Thanks for great integration!
I'm thinking to move few my devices from localtuya integration. Everything works much better with your integration but I found that localtuya integration updates device dps much faster. For example if I turn on/off or change target temperature of my dehumidifier using Tuya mobile application, or PM25 sensor was updated, the localtuya integration get the new data almost instantly in your integration it's takes around 20-25 seconds. Can you explain this? Is it possible to make this faster?

I have not looked closely at how localtuya is handling updates, but they have their own forked version of pytuya which they have customised themselves (this integration is using tinytuya, which is another derivative of the original pytuya).  There are a couple of things that might improve the speed

as an early design decision, the upstream developer (nicole-ashley/homeassistant-goldair-climate) chose to poll the devices rather than use a persistent connection to allow co-existence of the mobile app and home assistant.  Co-existence doesn't really work that well, since the app doesn't similarly co-operate, so a persistent connection might help. Though I did try it once, and any improvement didn't seem to be automatic, since the poll commands still need to be sent over the persistent connection, but it allow the poll rate to be increased without overloading the tuya device.
Tuya devices send out broadcast messages. I have thought about using these for discovery, but I suspect that they may also help with getting push updates from the device without polling.

Related to #116

Thanks for explanation, polling explains the slow updates.
About co-existence with Tuya mobile app, I know from the forum that many Tuya compatible bulbs can handle only one connection but fortunately for me all my Tuya device can handle more than one connection and I doesn't have this problems and unfortunately I can't test this case.

I second this request. I have a fan I have configured that definitely updates instantly under Local Tuya and takes a little longer with this integration.
Another issue I’m experiencing that might be related is that a quick succession of commands like turn on/off a light sometimes results in some of them to be delayed.

It seems the way that localtuya does it is to use a persistent connection with asyncio, but it isn't as simple as making the connection persistent, the way the connection is handled also needs to change.  tinytuya has added support for persistent connections, so refactoring device.py to use it should give a big improvement to update speed for external status changes, though it still probably will not be sufficient to support battery powered sensors.

@make-all, just updated to the new version.
When I control the switch from HA, no issues.
When I use the switch (simple_switch) physically, it updates HA after about 2-3 minutes.
Tested with Local Tuya (@rospogrigio
rospogrigio), works as expected in both ways (reacts immediately <1sec.
I believe the issue became worse, in previous version it was updating faster (about 30 sec.).

Can you please look in the log for any messages from tuya-local.

I have released 2023.1.2 based on my investigation into how my protocol version 3.1 device is working when set to "auto" protocol detection.

Just updated to 2023.1.2.
It s better, usually synchronized with the switch immediately, but occasionally losses sync.
Meaning, I turn off from the switch (physically), but the status in HA is still on (happens occasionally.
There is nothing in the log (it is clear).
The log from the integration switch:
{
"home_assistant": {
"installation_type": "Home Assistant OS",
"version": "2023.1.5",
"dev": false,
"hassio": true,
"virtualenv": false,
"python_version": "3.10.7",
"docker": true,
"arch": "x86_64",
"timezone": "Asia/Jerusalem",
"os_name": "Linux",
"os_version": "5.15.80",
"supervisor": "2022.12.1",
"host_os": "Home Assistant OS 9.4",
"docker_version": "20.10.19",
"chassis": "vm",
"run_as_root": true
},
"custom_components": {
"smartthinq_sensors": {
"version": "0.29.3",
"requirements": [
"pycountry>=20.7.3",
"xmltodict>=0.12.0",
"cchardet>=2.1.7"
]
},
"sonoff": {
"version": "3.3.1",
"requirements": [
"pycryptodome>=3.6.6"
]
},
"nuki_ng": {
"version": "0.2.1",
"requirements": []
},
"adaptive_lighting": {
"version": "1.4.1",
"requirements": []
},
"mass": {
"version": "2022.12.1",
"requirements": [
"music-assistant==<IP_ADDRESS>",
<EMAIL_ADDRESS>]
},
"powercalc": {
"version": "v1.3.0",
"requirements": [
"numpy>=1.21.1"
]
},
"huawei_mesh_router": {
"version": "<IP_ADDRESS>",
"requirements": []
},
"citymind_water_meter": {
"version": "2.0.10",
"requirements": []
},
"circadian_lighting": {
"version": "2.1.3",
"requirements": []
},
"hacs": {
"version": "1.29.1",
"requirements": [
"aiogithubapi>=22.10.1"
]
},
"alarmo": {
"version": "v1.9.7",
"requirements": []
},
"xiaomi_cloud_map_extractor": {
"version": "v2.2.0",
"requirements": [
"pillow",
"pybase64",
"python-miio",
"requests",
"pycryptodome"
]
},
"ramzor_sensor": {
"version": "0.1.0",
"requirements": []
},
"scheduler": {
"version": "v0.0.0",
"requirements": []
},
"webrtc": {
"version": "v2.3.1",
"requirements": []
},
"ui_lovelace_minimalist": {
"version": "v1.1.6",
"requirements": [
"aiofiles==0.8.0",
"aiogithubapi>=22.2.4"
]
},
"browser_mod": {
"version": "2.2.0",
"requirements": []
},
"hebcal": {
"version": "2.0.9",
"requirements": []
},
"localtuya": {
"version": "5.0.0",
"requirements": []
},
"iphonedetect": {
"version": "1.4.0",
"requirements": []
},
"simpleicons": {
"version": "v2.2.0",
"requirements": [
"simpleicons==7.14.0"
]
},
"shelly": {
"version": "1.0.2",
"requirements": [
"pyShelly==1.0.2",
"paho-mqtt==1.6.1",
"websocket-client"
]
},
"reolink_dev": {
"version": "0.61",
"requirements": [
"reolink==0.0.64",
"aiosmtpd>=1.4.2"
]
},
"ytube_music_player": {
"version": "20220205.01",
"requirements": [
"ytmusicapi==0.24.0",
"pytube==10.5.1",
"integrationhelper==0.2.2"
]
},
"miwifi": {
"version": "2.9.0",
"requirements": []
},
"tuya_local": {
"version": "2022.1.2",
"requirements": [
"pycryptodome~=3.16.0",
"tinytuya==1.9.1"
]
},
"smartir": {
"version": "1.17.6",
"requirements": [
"aiofiles==0.6.0"
]
}
},
"integration_manifest": {
"domain": "tuya_local",
"iot_class": "local_push",
"integration_type": "device",
"name": "Tuya Local",
"version": "2022.1.2",
"documentation": "https://github.com/make-all/tuya-local",
"issue_tracker": "https://github.com/make-all/tuya-local/issues",
"dependencies": [],
"codeowners": [
"@make-all"
],
"requirements": [
"pycryptodome~=3.16.0",
"tinytuya==1.9.1"
],
"config_flow": true,
"is_built_in": false
},
"data": {
"name": "Shelter Room Light",
"type": "simple_switch",
"device_id": "REDACTED",
"local_key": "REDACTED",
"host": "REDACTED",
"protocol_version": "auto",
"api_version_set": 3.3,
"api_version_used": 3.3,
"api_working": true,
"status": {},
"cached_state": {
"updated_at":<PHONE_NUMBER>.14835,
"1": false
},
"pending_state": {},
"connected": true,
"home_assistant": {
"name": "Shelter Room Light",
"name_by_user": null,
"disabled": false,
"disabled_by": null,
"entities": [
{
"disabled": false,
"disabled_by": null,
"entity_category": null,
"device_class": null,
"original_device_class": "switch",
"icon": null,
"unit_of_measurement": null,
"state": {
"entity_id": "switch.shelter_light_master",
"state": "off",
"attributes": {
"device_class": "switch",
"friendly_name": "Shelter Room Light"
},
"last_changed": "2023-01-17T20:03:48.148645+00:00",
"last_updated": "2023-01-17T20:03:48.148645+00:00"
}
}
]
}
}
}

I would suggest switching protocol version to 3.3.  With it set to "auto", if the device starts giving errors or refusing connections for some reason, the auto protocol detection will trigger, which will delay the reconnection as it tries the different protocol versions.  In particular, trying version 3.2 seems to take a long time to fail.  I find with my devices, even when they do not respond right away because of errors, they are back around 5 seconds later with the protocol version set to a fixed version.

And when you "turn off from the switch", do you mean a switch on the device itself, or are you killing the power with an external switch (which would send the device completely offline and unable to communicate the state change).

I am talking about switching on and off from the touch button on the switch (switch power is not cut, always powered).
I have tried to set to version 3.3 manually.
Hard to tell whether I see a difference, as I don't think that the device disconnects (there is no message of device became unavailable in the logs.
I have simply tried to turn on/off the switch about 20 times.
It seems like it is synchronized about 17-18 times out of 20, which is actually not perfect but not bad either, which could be the fact that setting 3.3 manually did help.
Thank you very much for your hard work supporting the issue.

I tried this myself, and after 35 attempts, finally got a delay of 2s to reflect the state when tinytuya got an invalid response from the device immediately after the switch.  It seems I am unable to reproduce any substantial issue, so any additional info you can gather would help (maybe by setting the log level for custom_components/tuya_local/device, or tinytuya to debug).

As a simple test, I have tested for two switches which are synchronized as a master/slave (used in a hall to switch the same light from two places).
It losses synchronization after the second/third switch of any of the two switches.
Both are 3.3.
To provide a log, could you please instruct me how to enable the logging in the logger(what exactly should be used)?

logger:
  default: warning
  logs:
    custom_components.tuya_local.device: debug

Thanks,
Just adding the switch to test, enabled the logger.
In the meanwhile, I have found another bug, less critical.
I have, by mistake, chosen 3.2 instead of 3.3 as the protocol.
The integration is stuck on the add screen without timeout or any error, you have to cancel manually and start over adding the device.

OK, enabled the logs, the issue still persists, occasionally, the switch state change isn't caught by the HA state.
I press the touch switch, it changes state to off (physical switch), the light connected physically to the switch turns off, and the LED of the switch is off, but HA state is on.
The log is clean, nothing caught.
Is there anything else I can enable to debug so it could catch additional debug info?

By the way, another observation I could see, this is how the log of the switch looks like:

We can see that it skips a change (there are missing on/off switches between the states).
There are multiple ONs and OFFs, when we expect to see on>off>on>off....
Another case could be that it reads the same state twice (just a guess).

You said you had two switches linked.  Is the syncing of switch states also causing the command to be sent twice to the light?  I don't think it will cause any problems, as long as the light itself is able to handle it.

I have unlinked it, as I can’t control the light.
As the slave switch doesn’t receive the off command from the master switch (we see ON and ON again, no OFF), the slave switch stays on.
So I am not sure what would be the reason.
It might be that the OFF is interpreted as ON, or it is double ON, or it simply misses the toggled state.
Till this morning, after about 12 hours, the log has no Tuya local messages.


tnbCrow- Milestone - 1

Link to the original project proposal.
https://github.com/thenewboston-developers/Projects/issues/129
Link to most recent milestone payout request.
Null
Milestone Description
Detailed application architecture, user flow, and stories.

Document every condition of trade cycle: https://github.com/tnbCrow/Backend/issues/59
Documented detail User Flow: https://github.com/tnbCrow/Management/issues/14
Write detailed User Stories: https://github.com/tnbCrow/Management/issues/13.
Generate OpenAPI documentation
Debug toolbar for database optimization

Coins: 30k
trade-post API endpoint tasks

Finalize the database model according to the updated user flow and stories
Validates if the seller has enough balance before creating the trade post
Locks seller's coins after trade post are created
Only authenticated user can create the post
Only the owner of the trade post can edit the trade post
Owner can load extra coins into the trade post
Owner can withdraw coins from the trade post
trade post will be created including the fees for the seller
fees will be refunded when withdrawing coins from the trade post
checks if the user has enough balance before loading the coins or creating trade post
transaction fees could be edited through the admin portal, do not lock coins for buyers.

Coins: 40k
trade-request API endpoint tasks

Finalize the database model according to the updated user flow and stories
the user will be able to send a trade request to the post owner
only the owner or initiator can view the trade request
if the user wants to sell coins; they need to have coins loaded with fees
amount of coins request cannot exceed the post amount
fees calculated with seller sends trade request
the user with the ability to accept/ reject/ cancel trade request
trade-request expired if no action within a day
unlock coins back if trade request expired/ rejected or canceled with fees
separate permissions for the separate status of trade-requests
if trade-request accepted; move the buyer + seller to an active trade
permissions on already updated trade-request.

Coins: 40k
active-trades API endpoint tasks

Finalize the database model according to the updated user flow and stories
only the initiator and post owner can take part in active trade
real-time chat functionality
correct permissions can only change the status of active trade
checks if payment windows expired before letting the seller cancel the trade
our moderator can join in chat if a dispute created
admin can change the status to canceled or completed
once both parties confirm payment; update the balance of the buyer
create an entry in the CompletedTrade model.

Coins: 50k
MVP site backend tasks

Architect the backend structure of the MVP site.
Implement the models and CRU of completed trades data.
Automate the updating of the Statistics table with completed trades data.
CRUD to blacklisted accounts that lists the accounts connected to scammers.
API endpoint to return the Statistics to be used in discord bot.
Deploy the site.

Coins: 50k
Design Tasks

Complete the design of the MVP site. Coins: 8k
Logo of tnbCrow. Coins: 10k
Create OG images for social sharing and social media banners. Coins: 5k
Drafting/sketching product specifications for core pages in the user flow. Coins: 5k
Create user flow for the web and mobile experience. Coins: 10k
Design the wireframe for each component in the proposed user flow for both platforms. Coins: 25k

Coins: 63k
Frontend Tasks

Develop the FE of MVP according to the design.
Integrate the FE with Django templates.

Coins: 25k
Requested Payment Upon Completion
298,000

Objective
Estimated Value (coins)

Detailed application architecture, user flow, and stories
30,000

trade-post API endpoint tasks
40,000

trade-request API endpoint tasks
40,000

active-trades API endpoint tasks
50,000

MVP site Backend tasks
50,000

Design Tasks
63,000

Frontend Tasks
25,000

Marketing Tasks
10,000

Project Wallet
79c0d308e31b9c4cf0f2bdaae65e2d8476c355084035ee11755facaa9597ff98

Hey @hussu010, we are going to have a meeting with govs regarding the standard method to calculate the number of coins for milestones.


Support for Panels with Shift-Register for row selection

Support for Panels which use a Shift-Register (e.g. RT5957) for row selection on A,B,C. See issue #117 for details.

Thanks for this - good work ... changes seems to be pretty self contained so I merged to master.
Did some stylistic changes to Readme to guide the reader to what is most common. Cheers!


Enhanced Pre-Commit Configuration for Improved Code Quality

[x] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

This updated pre-commit configuration enhances code quality by organizing hooks into categories, adding comments for clarity, and including additional checks for formatting and linting, such as black and isort. It maintains version consistency for all hooks and specifies exclusions for certain directories, ensuring that the configuration is both effective and user-friendly. These changes aim to streamline code review processes and enforce best practices across the codebase.
Inconsistent Code Formatting: Issue #123
Linting Errors: Issue #456
YAML Syntax Errors: Issue #789

Fake PR

Fake PR

why so

yml references non-existent/outdated repos
quoted issue links don't exist
yml wrongly formatted
Nothing seems right about this PR.


Unable to authorize

Expected Behavior

To push the Authorization Code via the obtain_access_token function and receive the access_token.
Current Behavior

Currently I am receiving the authorization code, but unable to get the access_token
Possible Solution

Steps to Reproduce

Open new project -> pip install drifactorial
Following the guide: https://dribia.github.io/drifactorial/usage/authorization/
Up tot "Authorize your user for using the application" goes well
When I enter:
token = dummy_factorial.obtain_access_token(  client_id=client_id,  client_secret=client_secret,  redirect_uri=redirect_uri,  authorization_key=authorization_key, )

I recieve the following errors:
>>> token = dummy_factorial.obtain_access_token( ...     client_id=client_id, ...     client_secret=client_secret, ...     redirect_uri=redirect_uri, ...     authorization_key=authorization_key, ... ) Traceback (most recent call last):   File "<stdin>", line 1, in <module>   File "C:\Users\CND127KONB\PycharmProjects\pythonProject\venv\lib\site-packages\drifactorial\__init__.py", line 379, in obtain_access_token     response = self._post_token(data=data)   File "C:\Users\CND127KONB\PycharmProjects\pythonProject\venv\lib\site-packages\drifactorial\__init__.py", line 360, in _post_token     response = request.urlopen(request_url)   File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1520.0_x64__qbz5n2kfra8p0\lib\urllib\request.py", line 216, in urlopen     return opener.open(url, data, timeout)   File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1520.0_x64__qbz5n2kfra8p0\lib\urllib\request.py", line 525, in open     response = meth(req, response)   File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1520.0_x64__qbz5n2kfra8p0\lib\urllib\request.py", line 634, in http_response     response = self.parent.error(   File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1520.0_x64__qbz5n2kfra8p0\lib\urllib\request.py", line 563, in error     return self._call_chain(*args)   File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1520.0_x64__qbz5n2kfra8p0\lib\urllib\request.py", line 496, in _call_chain     result = func(*args)   File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.10_3.10.1520.0_x64__qbz5n2kfra8p0\lib\urllib\request.py", line 643, in http_error_default     raise HTTPError(req.full_url, code, msg, hdrs, fp) urllib.error.HTTPError: HTTP Error 400: Bad Request

I have tried putting in the client_id, client_secret, redirect_uri and authorization_key manually by hand, so to make sure they match..
Looking into the drifactorial -> init.py file, hovering over the variables named at step 1, they do not visualize the variable values..

I also have issues with getting access_token. I get this error message "certificate verify failed: unable to get local issuer certificate".


Parameters not loading into controlnet

Hello. Please forgive me if this is in the wrong place or even the wrong question, but I don't think I am totally sure what this extension is doing.
You say that it loads controlnet parameters that are saved into an image into controlnet, but I cannot seem to make this happen.
In the main tab "ControlNet Fastload v1.2," I upload an image with load only or load and save and it doesn't display anything. It just shows the file uploaded, but it doesn't show parameters or even the image (like in your example picture 2).
But I am not sure if that has anything to do with it either because in your example video when you send it to controlnet, all it loads in is just the image sent and enables the controlnet tab.  No data is carried over like weight, start step, controlnet model, etc.
Is this extension supposed to carry that data over into controlnet? Because if it is, it isn't for me.
Is there anything that does do that? Because that is really what I need to find: Something that carries over the controlnet data stored in the file metadata to the actual controlnet tabs. I thought that's what this was.

I apologize for not detailing the usage process in the readme. I'll make sure to include a clearer guide in the upcoming v1.2.1 update.
The intended design of my extension is as follows:
Firstly, you need to run both the Controlnet and Controlnet Fastload plugins simultaneously and set Controlnet Fastload to "Save Only." At this point, the Controlnet Fastload extension will save the Controlnet data either in the generated image or in an additional .cni file, depending on your settings (by default, it's stored in the additional .cni file).
After that, you can drag and drop the image or .cni file containing the Controlnet data to "Load data from file" or view the saved data using the "View saved data" option.
I deeply apologize for any confusion or inconvenience caused. Please note that I'm an individual developer and appreciate your understanding and feedback.

That's alright. Thanks for taking the time to respond and uploading another video that I'm sure others will also find useful.
And just to let you know, I did figure out how to get controlnet metadata to import properly: It seems that it works correctly in SD.next/vlad diffusion, but is just broken in a1111.

Cool! Is this working in A1111 now?

Cool! Is this working in A1111 now?

Sure

Cool! Is this working in A1111 now?

Sure, this plugin is tested well in the latest master branch of a1111 now (https://github.com/AUTOMATIC1111/stable-diffusion-webui/commit/5ef669de080814067961f28357256e8fe27544f4), I am not closing this issue simply because it contains a complete plugin usage demo video, and I don’t have time to organize it into the documentation.

Sadly Error:  "C:\Users\AppData\Local\Temp\gradio\49fe93436c31582a03552cc27ef0f62b362585f1\00023-1054344531.png does not contain valid Controlnet Fastload data." And I hit save. Well was a good idea.

Sadly Error: "C:\Users\AppData\Local\Temp\gradio\49fe93436c31582a03552cc27ef0f62b362585f1\00023-1054344531.png does not contain valid Controlnet Fastload data." And I hit save. Well was a good idea.

Huh? Are you sure you followed the steps in the video one by one?


Glob to find stale dist-infos

This is a preparation for https://github.com/python-poetry/poetry/pull/3742.
It seems the sibling method is not documented/tested, so not clear what to do on that front.
Alternative might be to pass through name in dist_info_name unescaped if it's the *-glob?

Hi @nickray thank you for the change. Looking at the desired change, I am not sure if this needs to be here per-say. This can be, and imho should be, done poetry side without core changes.

Closing. See https://github.com/python-poetry/poetry/pull/3742#issuecomment-817270281.


[Enhancement] Remove sensitive info from audit log of create resource stmt

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes https://github.com/StarRocks/starrocks/issues/13324
Problem Summary(Required) ：

This PR removes access key/secret from audit log of create resource stmt. The new output would be like
2022-11-16 10:28:26,584 [query]<EMAIL_ADDRESS>EXTERNAL RESOURCE "spark0" PROPERTIES (     "type" = "spark",     "spark.master" = "yarn",     "spark.submit.deployMode" = "cluster",     "spark.jars" = "xxx.jar,yyy.jar",     "spark.files" = "/tmp/aaa,/tmp/bbb",     "spark.executor.memory" = "1g",     "spark.yarn.queue" = "queue0",     "spark.hadoop.yarn.resourcemanager.address" = "resourcemanager_host:8032",     "spark.hadoop.fs.defaultFS" = "hdfs://namenode_host:9000",     "working_dir" = "hdfs://namenode_host:9000/tmp/starrocks",     "broker" = "broker0",     "broker.username" = "user0",     "broker.password" = "*XXX" )|Digest=|PlanCpuCost=0.0|PlanMemCost=0.0|PendingTimeMs=0

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

run all

[FE PR Coverage Check]
:heart_eyes: pass : 8 / 9 (88.89%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/ast/CreateResourceStmt.java
1
2
50.00%
[53]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
6
6
100.00%
[]

:large_blue_circle:
com/starrocks/common/util/PrintableMap.java
1
1
100.00%
[]


feat: Handle more expressive types++

fixes https://github.com/ipvm-wg/ipvm/issues/24
Ipld <=> Wit/Wasmtime Value Types
Wasmtime shim for instantiation, execution, parsing component wasm mods
Allows for Wats if given Wasm-component Wats
Store in database via to/from sql functions and necessary types
More robust receipt implementation across pubsub/wire
Moves project to workspace
Adds ipvm-guest-wasm package for testing/compiling out wasms w/ Wit IDLs
Fixtures for testing variations
Cleanup

Codecov Report

Merging #49 (642ddec) into main (d544010) will increase coverage by 6.03%.
The diff coverage is 38.13%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   12.11%   18.15%   +6.03%
==========================================
  Files          16       18       +2
  Lines        3698      920    -2778
  Branches     1921      223    -1698
==========================================
- Hits          448      167     -281
+ Misses       2680      710    -1970
+ Partials      570       43     -527

Impacted Files
Coverage Δ

ipvm/src/db.rs
0.00% <ø> (ø)

ipvm/src/lib.rs
100.00% <ø> (ø)

ipvm/src/main.rs
1.00% <0.00%> (ø)

ipvm/src/network/client.rs
0.00% <ø> (ø)

ipvm/src/network/eventloop.rs
0.00% <0.00%> (ø)

ipvm/src/network/pubsub.rs
0.00% <ø> (ø)

ipvm/src/network/swarm.rs
0.00% <0.00%> (ø)

ipvm/src/test_utils/rvg.rs
50.00% <ø> (ø)

ipvm/src/wasm/wasmtime/shim.rs
0.00% <0.00%> (ø)

ipvm/src/workflow/config.rs
0.00% <0.00%> (ø)

... and 13 more

FYI, cc @expede and others, nightly linting fails currently due to https://github.com/rust-lang/rust-clippy/issues/10318.

@expede merging as per our discussion yesterday.


Fix populate script

The populate script is not working with the migration to Rollmelette, and should be fixed.

The script fails because it uses the -a flag which was replaced by -f, as mentioned in this comment https://github.com/crypto-bug-hunters/bugless/pull/48#discussion_r1519566053
I replace the -a with account index to -f with from address and the populate script runs perfect for me. I will push the changes


Proposal about daily loss

Could you please add a single file with daily rus loses? Reason is to get it in convenient way on different controllers where downloading and parsing is not trivial.

Could you please add a single file with daily rus loses? Reason is to get it in convenient way on different controllers where downloading and parsing is not trivial.

You can easily join two files based on date or day key


Merge to stable

Codecov Report

:exclamation: No coverage uploaded for pull request base (stable@65e1ff3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             stable      #60   +/-   ##
=========================================
  Coverage          ?   49.72%
=========================================
  Files             ?       13
  Lines             ?      362
  Branches          ?        0
=========================================
  Hits              ?      180
  Misses            ?      182
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e1ff3...3e53645. Read the comment docs.


CIF-911 - Update Component paths to not use "Venia" term

Description
As a first step to make our components more generic, we need to update the paths of the components to not contain venia anymore and instead use /apps/core/cif.

Moved the components to /apps/core/cif.
Renamed clientlibs to match best practices of WCM core components.
Updated component references in templates + policies.
Renamed component group to CIF Core Components

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[X] All unit tests pass on CircleCi.
[X] I ran all tests locally and they pass.

Codecov Report

Merging #48 into master will decrease coverage by 10.75%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master      #48       +/-   ##
=============================================
- Coverage     56.88%   46.13%   -10.76%
  Complexity      135      135
=============================================
  Files            25       21        -4
  Lines           842      659      -183
  Branches         49       49
=============================================
- Hits            479      304      -175
+ Misses          340      332        -8
  Partials         23       23

Flag
Coverage Δ
Complexity Δ

#karma
?
?

#unittests
46.13% <ø> (ø)
135 <ø> (ø)
:arrow_down:

Impacted Files
Coverage Δ
Complexity Δ

...nal/models/v1/productteaser/ProductTeaserImpl.java
12.24% <ø> (ø)
7 <0> (ø)
:arrow_down:

.../internal/models/v1/navigation/NavigationImpl.java
76.47% <ø> (ø)
11 <0> (ø)
:arrow_down:

...models/v1/productcarousel/ProductCarouselImpl.java
27.08% <ø> (ø)
4 <0> (ø)
:arrow_down:

...onents/internal/models/v1/product/ProductImpl.java
37.83% <ø> (ø)
20 <0> (ø)
:arrow_down:

...mponents/internal/models/v1/header/HeaderImpl.java
7.69% <ø> (ø)
1 <0> (ø)
:arrow_down:

...nal/models/v1/searchresults/SearchResultsImpl.java
77.58% <ø> (ø)
19 <0> (ø)
:arrow_down:

...e/components/internal/models/v1/HeroImageImpl.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

...nternal/models/v1/productlist/ProductListImpl.java
31.18% <ø> (ø)
14 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401dd4a...f51640a. Read the comment docs.


[PE-D][Tester E] Broken link in UG 3.2.10

The link tries to take me to localhost:6149. I don't know what the intended purpose of the link is.

Labels: severity.Low type.DocumentationBug
original: willowisp01/ped#12

is this a duplicate of #124


Add AWS_CREDENTIALS_FILE for alternate credentials file location

The credentials file is hard-coded for ~/.aws/credentials with no environment variable to specify an alternate location.  For many organizations, keeping credentials on an unencrypted volume is not allowed.  Simple one-line change to be in a forthcoming pull request to add this capability.

Linking pull request: https://github.com/boto/botocore/pull/600

Closing out issue.  This was fixed in #623


5xx status codes ranges are not supported

When I define my status code with code like 5xx I receive error:
[ EnforcerException: One or more errors exist in the OpenApi definition
at: paths
at: /v1/leads > post > responses
Property not allowed: 5xx

Nice catch. I hadn't thought of this scenario. I'll get working on a fix.

Nice catch. I hadn't thought of this scenario. I'll get working on a fix.

@malkevych Sorry about the wait on this one. Looking at the spec OpenAPI version 2.0 does not support wildcard response codes, but 3.0.0 and newer do. Make sure that you're following the spec there. Also, the response function used to validate and serialize responses did not support wildcard response codes but I have now added that in.
These changes have been published to npm as version 1.13.1.
I hope that resolves the issue for you. Let me know if there is anything else.
Thank you.

@malkevych Sorry about the wait on this one. Looking at the spec OpenAPI version 2.0 does not support wildcard response codes, but 3.0.0 and newer do. Make sure that you're following the spec there. Also, the response function used to validate and serialize responses did not support wildcard response codes but I have now added that in.
These changes have been published to npm as version 1.13.1.
I hope that resolves the issue for you. Let me know if there is anything else.
Thank you.


Add .vscode auto-generated folder to .gitignore

Fixes
Do not add the files generated by Visual Studio Code to be tracked by Git
Description of the changes:
Allows editing in Visual Studio Code without those files being tracked by Git.
How changes were validated:
N/A

Thanks for updating the .gitignore! 😊


LoadImage does not return proper data?

The first image is created from LoadImage.
The 2nd image is created from LoadImageFile.
These data si visualized from Image.Matrix by debugger.

This is caused by matrix_new6 method.
It was introduced in develop branch and it is not published as nuget.

It's not bug but sample program has wrong code.
DlibDotNet and FaceRecognitiionDotNet has no wrong.