Missing SOA for '.' zone when using zoneFile

When I'm attempting to use zoneFile feature (passed as values to helm configuration), I get an error saying plugin/file: file "/etc/coredns/example.db" has no SOA record for origin .. I think the point to note here is that there is a period ('.') in the error message, that doesn't appear to be a part of the sentence.
Reading through coredns docs for file, there is a syntax passage:

file DBFILE [ZONES...]

DBFILE the database file to read and parse. If the path is relative, the path from the root plugin will be prepended to it.
ZONES zones it should be authoritative for. If empty, the zones from the configuration block are used.

It appears that ZONES defaults to '.' zone since that is what is written at the top of Corefile: https://github.com/ori-edge/k8s_gateway/blob/79e977fc53b8239955252673173d1df69f5dd129/charts/k8s-gateway/templates/configmap.yaml#L9
Is it possible to add a feature where we can specify the list of zones while specifying zoneFile configuration option?

I remember it was working a few months ago https://github.com/networkop/nmos-kubernetes/blob/main/dns-values-http.yml
Are you able to manually test to confirm that adding zones fixes that error?

Yes, once I add . IN SOA ns.${SECRET_DOMAIN}. root.${SECRET_DOMAIN}. ( 2 2h 1h 24h 1h ), the error goes away and coredns can properly start. (btw, the ${SECRET_DOMAIN} gets properly resolved to my domain, so that is not an issue)
While this lets coredns+k8s_gateway start, it does not look like this configuration is correct, since my DNS queries return some unexpected values. I think the correctness of this SOA entry for '.' zone is outside of the scope of this ticket.

ok, so what you've changed is the content of the zone file, which is a user-supplied input.
Do you think that helm charts need to be changed?

Oh, sorry, I haven't realized that by saying 'zones' in the previous message you meant zones in corefile. I tried it and it seems that coredns still requires SOA record for the zone passed in file configuration setting. However, I set it to the same value that k8s-gateway sets (k8s-gateway.networking.domain.com. and hostmaster.k8s-gateway.networking.domain.com.), and it seems to be working pretty well that way.
I think adding '.' into zone files is a way to bypass the error, but I don't think it is a proper fix, since it doesn't quite make sense why this DNS server has to be an authoritative server for '.' zone. If the DNS on the main network is configured to point to this service, without the use of split-horizon DNS setup, this service will act as authoritative server and will respond with empty queries to all other domains like google.com, github.com and so on.
Because of the above reasons, I would think that allowing to specify which zones the particular zonefile applies to would be a more desirable solution. With this setup, this would also open up a feature of letting coredns act as a split-horizon DNS.

yep, this makes sense.
I think what you're trying to achieve can be done using the extraZonePlugins. So, we could drop that Line39 completely and instead you would do something like this:
extraZonePlugins:
  - name: file
    parameters: /etc/coredns/myzone.db k8s-gateway.networking.domain.com

zoneFile:
  filename: myzone.db
  contents: "your content"

The above should render the following configmap:
data:
  Corefile: |-
    .:1053 {
        k8s_gateway foo.com {
          apex release-name-k8s-gateway.default
          ttl 300
        }
        file /etc/coredns/myzone.db k8s-gateway.networking.domain.com
    }
  myzone.db:     your content

This is how the coredns's helm charts are designed (if I'm not mistaken).  wdyt @qlonik ?

just as I click send, I've found this
https://github.com/coredns/helm/blob/13550344baed72aa720497df8b8b61051f5461b2/stable/coredns/templates/configmap.yaml#L44-L50
For some reason, I can't see the following piece in the latest coredns helm charts anymore.
      {{- range .Values.zoneFiles }}
        file /etc/coredns/{{ .filename }} {{ .domain }}
      {{- end }}

will try to do some more digging

looks like here's where that block has disappeared
https://github.com/coredns/helm/commit/c73b5d0c2d7b9b41a0574672efec6569c4413991

looks like this was unintended. The zoneFiles.domain value is not even used now in coredns's helm charts.
so I'm fine either way, whatever you think is easier.
option A:
      {{- range .Values.zoneFiles }}
        file /etc/coredns/{{ .filename }} {{ .domain }}
      {{- end }}

option B:
extraZonePlugins:
  - name: file
    parameters: /etc/coredns/myzone.db k8s-gateway.networking.domain.com

feel free to submit a PR for this

I think if the line 39 is removed from the k8s_gateway/charts/k8s-gateway/templates/configmap.yaml file, it will be a breaking change to expect to add extraZonePlugins configuration (as shown in option B). I also finally managed to pass extraZonePlugins as helm values, and I ended up with a following bunch of default settings removed.
    log
    errors
    health {
        lameduck 5s
    }
    ready
    prometheus <IP_ADDRESS>:9153
    forward . /etc/resolv.conf
    loop
    reload
    loadbalance

So, I think the option A will be a nicer one. I'll create a PR for that today. :+1:

Ah shoot. Yesterday after debugging for a few hours, I figured that coredns with file plugin doesn't quite match my use case. I still think the improvement proposed here is a good one and should be kept.

But for a future reference, here is a note on what I found
My split-horizon DNS setup has the majority of names setup via cloudflare and seen from outside, but I want to overwrite a very small subset of names to resolve to local IPs. When I'm using file plugin, coredns becomes authoritative for the domain name and doesn't consult with upstream service for names that are missing in its own records. It simply returns NXDOMAIN for missing domain name. Realistically, what is necessary is to allow fallthrough for those queries. Unfortunately, it turned out that file plugin doesn't provide fallthrough.
However, I found some other approaches using other plugins that support fallthrough. There is one using hosts plugin (webarchive) and another one using external-dns and etcd plugin.
It seems it could also be possible to synchronize DNS by using secondary plugin or by using transfer plugin with cloudflare. However those features are only supported on enterprise accounts, which renders this approach not realistic.
Another way might be to use alternate external plugin for coredns, but I'm not very familiar with compiling coredns for k8s to include the plugin, so I didn't attempt it.
It might also be possible to use rewrite plugin to overwrite some of the queries to hardcoded IPs.
One more way that might work is to have Dnsmasq, PiHole or Adguard sit in front of coredns and resolve those overwrites, before passing queries those don't know about to coredns (with this plugin) and coredns will forward remaining queries it doesn't know about to upstream like cloudflare or google DNS.
Yet another way might be to support ExternalName by k8s_gateway as mentioned in https://github.com/ori-edge/k8s_gateway/issues/1#issuecomment-816022215. This way, since k8s_gateway supports fallthrough, all unknown queries will end up going to upstream as well.

Given the use of other plugins that require files present in the container (e.g. hosts requires hostfile to be given to it), maybe it would also be a good idea to provide a way to inject other files so they can be referenced within extraZonePlugins block? That could be covered by a different issue though.

I see. I think hosts plugin may be the easiest solution for you in this case. ExternalName would require a resolvable CNAME record.

Thanks for the suggestion.
I think we can close this issue, since we resolved and merged the zoneFiles feature


Antivirus flags "pathwatcher.node" as trojan malware

Prerequisites

[x] Can you reproduce the problem in [safe mode]?
Yes
[x] Are you running the [latest version of Atom]?
Yes. Downloaded Atom a few minutes ago. Version 1.10.2
[x] Did you check the [debugging guide]?
Yes
[x] Did you check the [FAQs on Discuss]?
Yes
[x] Are you reporting to the [correct repository]?
I think so.
[x] Did you [perform a cursory search] to see if your bug or enhancement is already reported?
Yes.

Description
On starting Atom and on performing certain actions like searching for new packages or even just opening the package manager, my antivirus (360 total security) reports that a trojan has been detected.
After adding the patchwatcher.node file to my antivirus whitelist and restarting Atom, the problem went away. I think it might be worth looking into, though.
Steps to Reproduce

If you have 360 total security installed, launch Atom
If you haven't already seen the alert, try to install a new package from the package manager

Expected behavior: [What you expected to happen]
When I search for a package, I expect to see results.
Actual behavior: [What actually happened]
A trojan alert is displayed by my antivirus and I do not see my search results afterwards.
Versions
Atom 1.10.2
Windows 10 Pro x64

There is no such thing as patchwatcher.node — do you mean pathwatcher? If that is the case, I would recommend switching to a better antivirus software.
This is a ridiculous false positive most likely triggered based on filesystem activity. Since you are on Windows, why don't you simply rely on the built-in antivirus and malware protection? It's more than adequate.
/cc @atom/feedback

There is no such thing as patchwatcher.node

There actually is - it's created when running npm install at %localappdata%\Atom\app-dev\resources\app.asar.unpacked\node_modules\pathwatcher\build\Release\pathwatcher.node.

thomasjo, ah yes, that was a typo. I meant pathwatcher.node. Sorry for the confusion.
360 Total Security does a lot more than just protection for me, so I can't just revert to Windows Defender.
I've used Atom without any more of this issue for most of today, so I'm reasonably sure that the issue has been resolved in my case. I only reported this so you guys might have a look, in case it's something that can be fixed on Atom's part. Clearly, the offending file is doing something that the antivirus thinks is suspicious.

@khalibloo All it does is monitor files and directories. My only recommendation at this point is to open report this to 360 as a false positive; https://www.360totalsecurity.com/en/suspicion/

I've reported the file to 360 as a false positive. Thank you very much for your time.

Since it appears to be a 360 Total Security issue, I'm closing.


How do I fix this?

I need this for Discord.py and this happens.
https://i.gyazo.com/926ec4e6829dae9beda694dd7fbf7af0.png
I did have a very successful install though.
https://i.gyazo.com/a6edec6da5e9ebba4a9399d8524eda9a.png

Looks like when I edit the code some more it starts to do this.
https://i.gyazo.com/e942ff0f6eda9ebd54e3f36f64d6a986.png

It is fixed in my fork now. Issue though is that libopus.dll must be in the folder of whatever uses opuslib. Also made it version 1.0.2 on my version as well.
the link to my version is.
https://github.com/AraHaan/opuslib/tree/patch-1


Lock uws version

uws maintainer has published an empty package as latest on npm, breaking this build.
This commit locks the version to latest working one.
More;
https://www.reddit.com/r/node/comments/97kn8r/the_uws_npm_deprecation_response/

Awesome thanks!


[Shared] Add placeholder to Input.ChoiceSet

Automatically generated task. Any updates to the title and body will be overwritten. Do NOT modify the labels.
Shared implementation of #3198

@RebeccaAnne is there a more recent Input.Evolution related issue that is tracking this work that we can dup this to ?

@shalinijoshi19 It's a little orthogonal, but we could pull this one into the input stuff. I'll leave open for now until i update the doc to add this feature.


Problem Set Grading

Hi Professor Coombs,
I was wondering how the syllabus will be updated given problem set 3 becoming optional. I know you said that that problem set would not count as a drop, but I wanted to confirm that all problem sets would still accumulate to 50% of our grade and if that is the case then each problem set would become 12.5% of our grade, accounting for 2 drops and 1 optional problem set.
Thanks,
Rawson

Yes, that's correct. They count for 50% of the grade still.


Introduced PHPStan on CI

I just ran PHPStan on FPP and it provides me with some interesting facts.
I think it would help further development, so I'm suggesting to use it.
I've never used it though, so it's just a wild suggestion.

Sorry for being slow on this one, will check it asap.

No hurry :)
Let me know if you want me to squash the commits before merge (if you want to merge).


Slides: Introduction to forecasting as an epidemiological problem, and its relationship with nowcasting and R estimation

reopening as these are only a very early bullet point draft at the moment

Happy with where this is now or needs more work?

Happy


How to opt out of RTL transformation?

We're trying to implement support for right-to-left styles in one of our libraries that utilizes tss-react. I was expecting to be possibly be able to use flip: false, as showcased in the MUI guide for RTL, within the relevant withStyles and makeStyles usages we have, but I don't believe this is supported in tss-react.
Does there exist a method by which we can opt out of RTL transformation currently, and we're just not using it properly, or is this a potential new feature that could be implemented?
Thanks!

I'm sorry I've nothing to offer regarding LTR at the moment but I'm more than willing to work on it if you suggest an API proposal to support it.

So I was able to work out a solution that works for me currently. Probably should've tried this before, but the inline comment syntax mentioned in the MUI RTL guide does in fact work.
For example, in a withStyles style property:
withStyles(
  Component,
  (theme) => ({
    root: {
      // Won't flip to "textAlign: 'right'" in RTL:
      textAlign: 'left /* @noflip */'
    }
  })
);

This is satisfactory for my needs, so feel free to close out unless you feel strongly about supporting some other alternative API :)

Thanks a lof for your valuable feedback!


[vtk] link error when linking agains vtk:x64-windows-static

On Windows 10 using CMake 3.16.0 with Visual Studio 17, I get the following link error when building against vtk:x64-windows-static:
LINK : fatal error LNK1104: cannot open file 'pugixml.lib'
A sample CMakeLists file is attached. The source file contains an empty main method.
CMakeLists.txt

Confirmed.

After changing LINK_PRIVATE to LINK_PUBLIC in SOURCE/IO/CityGML/CMakeLists.txt line 7, it works.

Hi @dbonhaus, thanks for reporting this issue!
I've fixed it in #9958, please update vcpkg and rebuild vtk.
Thanks.

Somehow I am still getting the same error. I updated my local copy of vcpkg, made sure that the relevant change was there, then reinstalled VTK (vtk:x64-windows-static) from scratch. I then deleted the cache for my sample project and reconfigured and rebuilt it, but I'm still getting the pugixml link error.

@dbonhaus Could you provide failure log?

The error message is not very informative:
"LINK : fatal error LNK1104: cannot open file 'pugixml.lib'"
The problem seems to be that pugixml.lib is in the project properties, but without an absolute path. I uploaded a snapshot of the linker properties in Visual Studio. Let me know if there is another log file that might be more informative and I will provide it.

@dbonhaus
Did you create this project yourself? vcpkg will add VCPKG_PATH/installed/TRIPLET/lib / VCPKG_PATH/installed/TRIPLET/debug/lib to the path LIB_PATH and try to link all static libraries in this path, so pugixml.lib should not be added by vcpkg.

No, the project was generated by CMake (3.16.0).

Confimed.

I am having this issue after updating several packages including VTK.

In IO\CityGML\CMakeLists.txt:
if(VTK_USE_SYSTEM_PUGIXML AND NOT pugixml_INCLUDE_DIRS)
  find_package(pugixml REQUIRED)
  vtk_module_link_libraries(vtkIOCityGML LINK_PUBLIC pugixml)
endif()

I think this is caused by the incorrect use of pugixml.

@dbonhaus @manvscode
Could you add find_dependency(pugixml CONFIG) to VCPKG_PATH/installed/TRIPLET/share/VTK/VTKConfig.cmake line 110?
If it works, I will open a PR to fix it.

Hello @JackBoosY.
I having the same issue @manvscode described.
Adding find_dependency(pugixml CONFIG) doesn't seem to work.

@RamadanAhmed Sorry, we should include CMakeFindDependencyMacro.cmake first:
include(CMakeFindDependencyMacro)
find_dependency(pugixml CONFIG)

@JackBoosY after applying suggested changes the pugixml.lib is still missing unfortunately.

Just ran into the same problem.
What solved it temporarily for me is adding these two lines at the end of the installed VTKConfig.cmake
include(CMakeFindDependencyMacro)
find_dependency(pugixml REQUIRED)

Look forward to the proper fix.

@dbonhaus @manvscode
Could you add find_dependency(pugixml CONFIG) to VCPKG_PATH/installed/TRIPLET/share/VTK/VTKConfig.cmake line 110?
If it works, I will open a PR to fix it.

I no longer see link errors involving pugixml, but I see two new ones:
1>vtkIOCore-8.2.lib(vtkLZMADataCompressor.cxx.obj) : error LNK2019: unresolved external symbol __imp_lzma_easy_buffer_encode referenced in function "protected: virtual unsigned __int64 __cdecl vtkLZMADataCompressor::CompressBuffer(unsigned char const *,unsigned __int64,unsigned char *,unsigned __int64)" (?CompressBuffer@vtkLZMADataCompressor@@MEAA_KPEBE_KPEAE1@Z)
1>vtkIOCore-8.2.lib(vtkLZMADataCompressor.cxx.obj) : error LNK2019: unresolved external symbol __imp_lzma_stream_buffer_decode referenced in function "protected: virtual unsigned __int64 __cdecl vtkLZMADataCompressor::UncompressBuffer(unsigned char const *,unsigned __int64,unsigned char *,unsigned __int64)" (?UncompressBuffer@vtkLZMADataCompressor@@MEAA_KPEBE_KPEAE1@Z)
I have the 2020.01 tag of vcpkg checked out.

@JackBoosY @RamanKutseika @dbonhaus  I can confirm that adding these lines to VTKConfig.cmake, at 110, will fix the problem:
include(CMakeFindDependencyMacro)
find_dependency(pugixml REQUIRED)

I tested both linking debug and release binaries.  I do not see any problems with liblzma.

@RamanKutseika Port pugixml gererated debug library named pugixml.lib, so I guess no fault here.

@dbonhaus
lzma library should be imported with path ${VTK_INSTALL_PREFIX}/lib/lzma.lib and ${VTK_INSTALL_PREFIX}/debug/lib/lzmad.lib, you can find them in share\vtk\Modules\vtklzma.cmake
And VTK_INSTALL_PREFIX was set in VTKConfig,cmake line 13:
if (_vtk_installed_prefix_full STREQUAL _vtk_requested_prefix_full)
  set(VTK_INSTALL_PREFIX "${CMAKE_CURRENT_LIST_DIR}/../..")
else ()
  set(VTK_INSTALL_PREFIX "${CMAKE_CURRENT_LIST_DIR}")
  get_filename_component(VTK_INSTALL_PREFIX "${VTK_INSTALL_PREFIX}" PATH)
  get_filename_component(VTK_INSTALL_PREFIX "${VTK_INSTALL_PREFIX}" PATH)
endif ()

Hi guys, I've fixed this issue in #10379, please update vcpkg and rebuild vtk.
Thanks.

@dbonhaus
lzma library should be imported with path ${VTK_INSTALL_PREFIX}/lib/lzma.lib and ${VTK_INSTALL_PREFIX}/debug/lib/lzmad.lib, you can find them in share\vtk\Modules\vtklzma.cmake
And VTK_INSTALL_PREFIX was set in VTKConfig,cmake line 13:
if (_vtk_installed_prefix_full STREQUAL _vtk_requested_prefix_full)
  set(VTK_INSTALL_PREFIX "${CMAKE_CURRENT_LIST_DIR}/../..")
else ()
  set(VTK_INSTALL_PREFIX "${CMAKE_CURRENT_LIST_DIR}")
  get_filename_component(VTK_INSTALL_PREFIX "${VTK_INSTALL_PREFIX}" PATH)
  get_filename_component(VTK_INSTALL_PREFIX "${VTK_INSTALL_PREFIX}" PATH)
endif ()

I just tried the latest vcpkg and I'm still seeing problems with lzma (but not with pugixml). I'm not sure I follow your comment. Are you saying I should explicitly specify lzma as a dependency in my CMake file? Shouldn't VTK take care of the dependency? Everything seems to be as you indicated in the VTK config files.

@dbonhaus
According to my comment above, lzma was imported through VTK_INSTALL_PREFIX to determine the absolute path of the dependent library, and the value of VTK_INSTALL_PREFIX is VCPKG_PATH/installed/TRIPLET/share/vtk/../.., then lzma library path should be VCPKG_PATH/installed/TRIPLET/share/vtk/../../lib/lzma.lib and VCPKG_PATH/installed/TRIPLET/share/vtk/../../debug/lib/lzmad.lib.
So there should be no problem here.
Could you provide the failure log?

Here are the link errors:
1>vtkIOCore-8.2.lib(vtkLZMADataCompressor.cxx.obj) : error LNK2019: unresolved external symbol __imp_lzma_easy_buffer_encode referenced in function "protected: virtual unsigned __int64 __cdecl vtkLZMADataCompressor::CompressBuffer(unsigned char const *,unsigned __int64,unsigned char *,unsigned __int64)" (?CompressBuffer@vtkLZMADataCompressor@@MEAA_KPEBE_KPEAE1@Z)
1>vtkIOCore-8.2.lib(vtkLZMADataCompressor.cxx.obj) : error LNK2019: unresolved external symbol __imp_lzma_stream_buffer_decode referenced in function "protected: virtual unsigned __int64 __cdecl vtkLZMADataCompressor::UncompressBuffer(unsigned char const *,unsigned __int64,unsigned char *,unsigned __int64)" (?UncompressBuffer@vtkLZMADataCompressor@@MEAA_KPEBE_KPEAE1@Z)

@dbonhaus Could you provide the full log?
Thanks.

I modified the test project to reproduce the error.
vtk_test.zip
I also included the CMake cache file. I suspect something about the CMake configuration either is the problem or triggers the problem.

There seem to be a lot more problems with the test project associated with the use of the static run time (x64-windows-static). I added /MT to the CXX flags but it didn't help.

Well, now I can confirm that this issue still exists and I will continue to deal with this issue.

__imp_lzma_easy_buffer_encode incorrect EXPORT macro, I will fix this issue in the nearly futhre.

@Neumann-A Seems the export cmake files has problem, what do you think?

@JackBoosY: Is ParaView not built in x64-windows-static CI? I would have thought that this would have found such an issue in VTK (or LZMA).

@JackBoosY I checked the logs of #12342 and Paraview built fine with it. Maybe the problem is linking against VTK_LIBRARIES instead of a target? I currently don't have a installation of VTK so I cannot check the value of VTK_LIBRARIES.

@Neumann-A ParaView is not added to the pre-build process currently, and this issue appeared before adding ParaView.
@dbonhaus Does this issue still exist? Please note to use find_package(vtk CONFIG REQUIRED) instead of find_package(VTK CONFIG REQUIRED).

@Neumann-A ParaView is not added to the pre-build process currently, and this issue appeared before adding ParaView.
@dbonhaus Does this issue still exist? Please note to use find_package(vtk CONFIG REQUIRED) instead of find_package(VTK CONFIG REQUIRED).

I've the same issue with vcpkg using wide integration.

@GeneralAdmin More details please?

I no longer see any link errors as of vcpkg 2020.11 if I use find_package(VTK CONFIG REQUIRED). It doesn't work with lower case vtk. If I specify components in the find_package command, I see the link error again, but that seems like a VTK issue rather than a vcpkg issue.

@dbonhaus thanks for the information.

Hi @martinken, can you please take a look?
We are not sure this issue is caused by vtk itself or vcpkg.

I found that some cmake files start with uppercase VTK, and the rest start with lowercase vtk. I think there is something wrong here.

no it is not.....
vtk-config.cmake is the important one
due to its naming the config can be found via find_package(VTK) AND find_packakge(vtk) but this doesn't mean both are correct.  Internally VTKs config is probably using PACKAGE_FIND_NAME somewhere which is why lowercase vtk is not working. That said the correct way to find VTK is to always use uppercase VTK since that is used in any example by vtk itself (https://gitlab.kitware.com/vtk/vtk/-/blob/master/Examples/GUI/Qt/ImageViewer/CMakeLists.txt).
So this issue can be closed since find_package(VTK) is working

@Neumann-A At least our usage is incorrect:
he package vtk:x64-windows-static provides CMake targets:

    find_package(3.13 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE ZLIB::ZLIB)

    find_package(3.16 CONFIG REQUIRED)
    target_link_libraries(main PRIVATE PostgreSQL::PostgreSQL)

    find_package(99 CONFIG REQUIRED)
    # Note: 36 target(s) were omitted.
    target_link_libraries(main PRIVATE X11::SM X11::Xi X11::Xt X11::Xv)

    find_package(vtk CONFIG REQUIRED)
    # Note: 159 target(s) were omitted.
    target_link_libraries(main PRIVATE LZ4::LZ4 OGG::OGG VTK::lz4 VTK::ogg)

PS F:\vcpkg>


Lights dont function properly

In 1.8 i can turn a light off and never get it back on.
[11/17/2021, 14:21:43] [Security System] Error: Failed to change light state: Error: POST https://www.alarm.com/web/api/devices/lights/94428553-1201/turnOn failed: 423
at post (/usr/local/lib/node_modules/homebridge-node-alarm-dot-com/node_modules/node-alarm-dot-com/dist/index.js:489:15)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at authenticatedPost (/usr/local/lib/node_modules/homebridge-node-alarm-dot-com/node_modules/node-alarm-dot-com/dist/index.js:433:17)
at ADCPlatform.changeLight (/usr/local/lib/node_modules/homebridge-node-alarm-dot-com/src/index.ts:909:5)

anyone else experiencing?  still have this after the 1.11 patch installed via terminal.  all other functions seem solid.  can turn lights off, but cannot turn any on.

Also, prior to the reset issues if the code was modified with brightness=true it would get the lights to turn on consistently.

I'm also having this problem.  I can turn off the light but it will not turn it back on

Any thoughts on the issue?

I'm also experiencing this issue with 1 of my 2 lights, which I thought was strange.  Everything else works solid so far.
[1/6/2022, 9:22:53 PM] [Security System] Updating light Master Light (96029166-1207), state=false, prev=true
[1/6/2022, 9:25:59 PM] [Security System] Error: Failed to change light state: Error: POST https://www.alarm.com/web/api/devices/lights//turnOn failed: 423
at post (/homebridge/node_modules/homebridge-node-alarm-dot-com/node_modules/node-alarm-dot-com/dist/index.js:489:15)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at authenticatedPost (/homebridge/node_modules/homebridge-node-alarm-dot-com/node_modules/node-alarm-dot-com/dist/index.js:433:17)
at ADCPlatform.changeLight (/homebridge/node_modules/homebridge-node-alarm-dot-com/src/index.ts:909:5)

I am having the same issue. Has anyone had success at all?

Same issue here i can turn all  lights off but only can turn only one light back on. Any solution to this issue?

For those having issues with lights I have two questions:  1) What type of lights are you trying to control?  Z-wave devices directly communicating with your panel or a cloud to cloud integration (i.e., Lutron).   2) Are the devices on/off switches or dimmers?
I have a mix of both in my setup but primarily Lutron devices which are natively HomeKit supported (I exclude the ADC versions of my Lutron devices to not create dupes). I do have one z-wave on/off device directly communicating with my panel but haven't experienced any issues with it.  Hence, I'm wondering if this is a dimmer related problem.  I remember previous issues with the dimmer implementation.

GE zwave to Qolsys without dimmer
Get Outlook for iOShttps://aka.ms/o0ukef

From: ngori @.>
Sent: Thursday, January 20, 2022 12:50:01 PM
To: node-alarm-dot-com/homebridge-node-alarm-dot-com @.>
Cc: Stugatza @.>; Author @.>
Subject: Re: [node-alarm-dot-com/homebridge-node-alarm-dot-com] Lights dont function properly (Issue #90)
For those having issues with lights I have two questions: 1) What type of lights are you trying to control? Z-wave devices directly communicating with your panel or a cloud to cloud integration (i.e., Lutron). 2) Are the devices on/off switches or dimmers?
I have a mix of both in my setup but primarily Lutron devices which are natively HomeKit supported (I exclude the ADC versions of my Lutron devices to not create dupes). I do have one z-wave on/off device directly communicating with my panel but haven't experienced any issues with it. Hence, I'm wondering if this is a dimmer related problem. I remember previous issues with the dimmer implementation.
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnode-alarm-dot-com%2Fhomebridge-node-alarm-dot-com%2Fissues%2F90%23issuecomment-1017763811&data=04|01||a5f99685167348f1a91508d9dc3d4898|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637782978027486256|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=43jVSeEbEJHEWPAWTomgaAr7cICrHgIkrj3TppsXuo8%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOCFBWCU23GJHXUIXBBGWHTUXBDMTANCNFSM5IHZY2LQ&data=04|01||a5f99685167348f1a91508d9dc3d4898|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637782978027486256|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Tx107ynUHVZfIbz2SmqD9VnrgLUlmplWFjBcNUS4Eyg%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||a5f99685167348f1a91508d9dc3d4898|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637782978027486256|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=FgEojd9sL1h4KI6JCfwNAMsFqBuwUieJzo1YRUUghac%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||a5f99685167348f1a91508d9dc3d4898|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637782978027486256|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=dwbAuL%2FmT0l6AnywJkI1N7RGqz9s81q7r7ejDSCRGXA%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

Zwave to ADT panel no dimmers connected to alarm.com one light works all others don’t but all the same switches

Same issue here. Alarm.com. All but one light works. The one that fails can be turned off but not turned on
Error: Failed to change light state: Error: POST https://www.alarm.com/web/api/devices/lights/94329577-1211/turnOn failed: 423
at post (/usr/local/lib/node_modules/homebridge-node-alarm-dot-com/node_modules/node-alarm-dot-com/dist/index.js:489:15)
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at authenticatedPost (/usr/local/lib/node_modules/homebridge-node-alarm-dot-com/node_modules/node-alarm-dot-com/dist/index.js:433:17)
at ADCPlatform.changeLight (/usr/local/lib/node_modules/homebridge-node-alarm-dot-com/src/index.ts:909:5)
Any ideas appreciated

@kwallac has submitted a PR to correct this issue on the node-alarm-com repo (the interface module for this plugin).  I can't test this PR but if some of the folks having issues could test and report back we can hopefully merge his fix.
https://github.com/node-alarm-dot-com/node-alarm-dot-com/pull/23

Sill question, but what is the best way to get the latest pkg installed
On Feb 8, 2022, at 9:36 AM, ngori<EMAIL_ADDRESS>wrote:
@kwallachttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkwallac&data=04|01||731cd1591a0046a1539708d9eb10543f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799277626788507|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=rx96hQW9Qbtq754FDaxu6MpaAO%2FT6wY5iHl6gQJnmuc%3D&reserved=0 has submitted a PR to correct this issue on the node-alarm-com repo (the interface module for this plugin). I can't test this PR but if some of the folks having issues could test and report back we can hopefully merge his fix.
node-alarm-dot-com/node-alarm-dot-com#23https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnode-alarm-dot-com%2Fnode-alarm-dot-com%2Fpull%2F23&data=04|01||731cd1591a0046a1539708d9eb10543f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799277626788507|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=HHeBTdKEUcDPmKpIFz1hChx%2BeV0ac7sU3640LTfD6%2Bc%3D&reserved=0
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnode-alarm-dot-com%2Fhomebridge-node-alarm-dot-com%2Fissues%2F90%23issuecomment-1032677288&data=04|01||731cd1591a0046a1539708d9eb10543f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799277626788507|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=zyuBghijvOHAqi%2BlZMuRZK1fUE2MDC88wruBkZM9c3Y%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOCFBWFCXY4K5AQLLOW3SF3U2ES5DANCNFSM5IHZY2LQ&data=04|01||731cd1591a0046a1539708d9eb10543f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799277626788507|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=ERN5VhD%2BoKmlWeQ4viZXsuXiKmZO23IcE3uMxFDLoG8%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||731cd1591a0046a1539708d9eb10543f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799277626788507|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=kp788DtpzkMhVCeaZWOEaQHCb%2BNs9jZqHsLDvUz13DM%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||731cd1591a0046a1539708d9eb10543f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799277626788507|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=QQfRhJ9VESacohssATR%2BuYvhc%2Fsxe2CTU3wcAZmbcnM%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

The fix requires an extra parameter (isDimmer) to be passed to the node-alarm-dot-com method. I have a PR for the homebridge-node-alarm-dot-com plugin that does and have tested end-to-end and all works. Not sure how to manage the dependency though as it assumes the https://github.com/node-alarm-dot-com/node-alarm-dot-com/pull/23 PR has been accepted as version 1.1.11

@kwallac I only see a PR for the node-alarm-dot-com interface nothing for home-bridge-node-alarm-dot-com?

Hi @ngori I went ahead and created https://github.com/node-alarm-dot-com/homebridge-node-alarm-dot-com/pull/93
but as mentioned requires an update to the node-alarm-dot-com library per https://github.com/node-alarm-dot-com/node-alarm-dot-com/pull/23
I've tested that it works with both types of lights (dimmable and non-dimmable)

Can this be merged into the homebridge repo and made avail as an update?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Kevin Wallace @.>
Sent: Tuesday, February 8, 2022 1:13:58 PM
To: node-alarm-dot-com/homebridge-node-alarm-dot-com @.>
Cc: Stugatza @.>; Author @.>
Subject: Re: [node-alarm-dot-com/homebridge-node-alarm-dot-com] Lights dont function properly (Issue #90)
Hi @ngorihttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fngori&data=04|01||d4cdf53fdcc24febe03b08d9eb2ec796|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799408415047656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=j%2BFIAKxALg8P5WrG0TN7RusaRLHmqOA7ZY4Cg3dvcuU%3D&reserved=0 I went ahead and created #93https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnode-alarm-dot-com%2Fhomebridge-node-alarm-dot-com%2Fpull%2F93&data=04|01||d4cdf53fdcc24febe03b08d9eb2ec796|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799408415047656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=qCwPjdNCVvkWiWxvbP0fdtkZr%2BFd3Mi1yv%2FHaJt9RR4%3D&reserved=0
but as mentioned requires an update to the node-alarm-dot-com library per node-alarm-dot-com/node-alarm-dot-com#23https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnode-alarm-dot-com%2Fnode-alarm-dot-com%2Fpull%2F23&data=04|01||d4cdf53fdcc24febe03b08d9eb2ec796|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799408415047656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Ba82MO3dz2EUcyyTHKoUBe12%2BsUjEk%2ByrgsOJWfnJpc%3D&reserved=0
I've tested that it works with both types of lights (dimmable and non-dimmable)
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnode-alarm-dot-com%2Fhomebridge-node-alarm-dot-com%2Fissues%2F90%23issuecomment-1032916243&data=04|01||d4cdf53fdcc24febe03b08d9eb2ec796|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799408415047656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=r%2BYFoUR0h4ZtwCmHz66RQL%2FymBjebi253nIjUFe0C2w%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOCFBWHNCV32QXRO6XLX6IDU2FMONANCNFSM5IHZY2LQ&data=04|01||d4cdf53fdcc24febe03b08d9eb2ec796|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799408415047656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=5xeFZGcweTQShTEjqad1vVX%2FH8P9ifz2ekTbIZiecwc%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||d4cdf53fdcc24febe03b08d9eb2ec796|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799408415047656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=JVv0XKXgYSKRCMpKdXevzdv7%2BFn%2FX9ZiMl7inwD1jhg%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||d4cdf53fdcc24febe03b08d9eb2ec796|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637799408415047656|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=uL06p%2BJuyTNvXCVOcKcPwRtM6pXJSvtHtij%2FWDw%2B9qo%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

@kwallac @ngori Thank you both so much for your help. As you can tell, I've been absent due to personal reasons so it was so great to see a pull request! This has been merged into 1.8.1-beta.0. Please test and let me know if you run into bugs.

The fix is performing great!  Appreciate everyone’s hard work on this one.
On Feb 9, 2022, at 2:09 PM, Chase Lau<EMAIL_ADDRESS>wrote:
@kwallachttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkwallac&data=04|01||039b25bccd3141c0665808d9ebffbd01|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637800305892966203|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=QXN2dAczQ7qZd7qTaR6VkR6GnZ8z%2BXU9mFXGJo3xqqI%3D&reserved=0 @ngorihttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fngori&data=04|01||039b25bccd3141c0665808d9ebffbd01|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637800305892966203|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Nc6jhdwSq1KAHOLoDMZ%2Bc1vUSU7oZU98IYPM6Gv5geI%3D&reserved=0 Thank you both so much for your help. As you can tell, I've been absent due to personal reasons so it was so great to see a pull request! This has been merged into 1.8.1-beta.0. Please test and let me know if you run into bugs.
—
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnode-alarm-dot-com%2Fhomebridge-node-alarm-dot-com%2Fissues%2F90%23issuecomment-1034101583&data=04|01||039b25bccd3141c0665808d9ebffbd01|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637800305892966203|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=k0pz2pASV%2FgC%2FkwFzRBbmXL%2FrPV1p1vFSH8Rew%2BefX4%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOCFBWDMAEET222AQKEGNDLU2K3XVANCNFSM5IHZY2LQ&data=04|01||039b25bccd3141c0665808d9ebffbd01|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637800305892966203|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=Xvk06ruQKAIQKgItXmSKtjcS1CYNhWqFloof2x%2FJ%2BCs%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||039b25bccd3141c0665808d9ebffbd01|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637800305892966203|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=y2MWvWtpOW0S1p3N%2B0pgEKhWz6qTEtHCy5b4ad%2BEkK8%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||039b25bccd3141c0665808d9ebffbd01|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637800305892966203|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=AVFVfKCRshn35sjbIqLNPwHWljsqFqM4i%2FhKC91GDd0%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

Can someone please guide me through on how to implement the fix? I'm a complete newbie. I would highly appreciate that! I can reimburse you for your time! Thank you

@ChrArk  If you are using Homebridge UI interface you can click on the wrench, then "Install Previous Version", then from the version list the beta with the change implemented will be at the top.

Thank you so much for explaining it!!! I’ll give that a try tonight.
Kind regards / Mit freundlichen Grüßen
Christian Arkenberg

On Feb 11, 2022, at 9:29 AM, ngori @.***> wrote:

@ChrArk If you are using Homebridge UI interface you can click on the wrench, then "Install Previous Version", then from the version list the beta with the change implemented will be at the top.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.

@ngori Thank you again everything works fine now! Thank you to everyone who made all this possible and shared it with the public! One more question I ordered a Z-shield for the raspberry PI but it seem like I don't even need that? Can someone explain why and when its needed and when not? I'm assuming it functions similar to a hub which we have the IQ pad for correct?

I'm not familiar with the z-Shield but it looks like a Zigbee interface for Home Assistant. The IQ panel has only limited Zigbee functionality for use with the image sensors. It doesn't support other devices (lights, switches, outlets). The IQ panels do have decent z-wave functionality. So it just depends on what you are trying to do if you need the Z-Shield.

@ngori Thank you again everything works fine now! Thank you to everyone who made all this possible and shared it with the public! One more question I ordered a Z-shield for the raspberry PI but it seem like I don't even need that? Can someone explain why and when its needed and when not? I'm assuming it functions similar to a hub which we have the IQ pad for correct?

Hello. Are people in the Hoobs system able to update to this beta program. I am having the same problems with my lights.


How to force the bot to use a specified location and not the last used location

Use specified location
Uses location where it left off
[01:01:05] [x] Coordinates found in passed in location, not geocoding.
[01:01:05]
[01:01:05] Location Found: 37.787994,-122.407440
[01:01:05] GeoPosition: (37.787994, -122.40744, 0)
[01:01:05]
[01:01:05] [x] Parsing cached location...
[01:01:05]
[01:01:05] [x] Last location flag used. Overriding passed in location
[01:01:05] [x] Last in-game location was set as: (37.7963525004378, -122.39431257768616, 0)

did you pull recent code? this is sorted. checks if config location changed and if yes it overrides last in-game

Turn off use cached location in config file

it works fine with cached loc. on (and i would keep cached on..)

if he keeps cached on it will not use the location he sets. So why should he keep it on?

starting location is stored in the same file as last in-game. so if he changes the starting loc. the bot realises that and overrides cached one.. so new loc. works and avoiding teleports is in place as well. thats why

just rm data/location..xxx... when you want it to not use last location

Yes, you have to remove the file data/last-location-username.json so you have no previous location stored.

Thanks :D its working now


Support for Python 3.9

I tried to run example file and got this
Traceback (most recent call last):
  File "C:\Users\Admin\AppData\Roaming\Python\Python39\site-packages\flexxamples\demos\demo.py", line 7, in <module>
    from flexx import flx
ImportError: cannot import name 'flx' from 'flexx' (C:\Users\Admin\AppData\Roaming\Python\Python39\site-packages\flexx\__init__.py)

$ pip list
Package                Version
---------------------- ---------
astroid                2.4.2
autopep8               1.5.4
certifi                2020.6.20
chardet                3.0.4
colorama               0.4.4
dialite                0.5.3
flake8                 3.8.4
flexx                  0.8.1
idna                   2.10
isort                  5.6.4
jedi                   0.17.2
lazy-object-proxy      1.4.3
mccabe                 0.6.1
parso                  0.7.1
pip                    20.2.4
pluggy                 0.13.1
pscript                0.7.4
pycodestyle            2.6.0
pydocstyle             5.1.1
pyflakes               2.2.0
pylint                 2.6.0
PySide2                5.15.1
PySimpleGUI            4.30.0
python-jsonrpc-server  0.4.0
python-language-server 0.35.1
requests               2.24.0
rocket-python          1.2.15
rocketchat-API         1.9.1
rope                   0.18.0
setuptools             50.3.2
shiboken2              5.15.1
six                    1.15.0
snowballstemmer        2.0.0
toml                   0.10.1
tornado                6.0.4
ujson                  4.0.1
urllib3                1.25.11
webruntime             0.5.8
wrapt                  1.12.1
yapf                   0.30.0

$ python --version
Python 3.9.0

In files:
\flexx\app\_app.py
\pscript\commonast.py

I found this lines:
from base64 import encodestring as encodebytes
from base64 import encodestring as encodebytes, decodestring as decodebytes

But in base64.py no encodestring/decodestring functions, because they was deleted in 3,9 branch of python
Please fix it, or add to documentation attention about flexx don`t work with 3,9 python

Looks like python 2.7 compatibility imports maybe. I guess they can just be replaced by
from base64 import encodebytes, decodebytes

Looks like python 2.7 compatibility imports maybe. I guess they can just be replaced by
from base64 import encodebytes, decodebytes
I tried to do this. But new error appear.

I fink it can be fixed i̶f̶ ̶y̶o̶u̶ ̶a̶d̶d̶ ̶t̶h̶i̶s̶ ̶c̶o̶d̶e̶ ̶i̶n̶t̶o̶ ̶C̶:̶\̶P̶r̶o̶g̶r̶a̶m̶ ̶F̶i̶l̶e̶s̶\̶P̶y̶t̶h̶o̶n̶3̶9̶\̶L̶i̶b̶\̶b̶a̶s̶e̶6̶4̶.̶p̶y̶
If you add this funcs in \flexx\app_app.py and _\pscript\commonast.py
def encodestring(s):
    """Legacy alias of encodebytes()."""
    import warnings
    warnings.warn("encodestring() is a deprecated alias since 3.1, "
                  "use encodebytes()",
                  DeprecationWarning, 2)
    return encodebytes(s)

def decodestring(s):
    """Legacy alias of decodebytes()."""
    import warnings
    warnings.warn("decodestring() is a deprecated alias since Python 3.1, "
                  "use decodebytes()",
                  DeprecationWarning, 2)
    return decodebytes(s)

It is simple funcs, which call funcs in base64 file.
I think its simple to fix)

I renamed the title to reflect the bigger picture.

Looks like python 2.7 compatibility imports maybe. I guess they can just be replaced by
from base64 import encodebytes, decodebytes

edit:
Just tried that, but looks like there is a little bit more work to do...

I did:
from base64 import encodebytes

and it worked with python 3.9.2 and flexx 0.8.1

Thanks! Yeah replacing these imports might be enough. We should also update CI to make sure the tests pass for py39 too.

Why is this closed? I just installed flexx and the simplest example does not run because of this dusty bug. Please fix it.

It has been fixed in master. But I have not created a new release yet. In part because I'd like to be sure that everything works on py3.9 (in CI). Ideally we'd also move CI from Travis to GH Actions ...
Anyway, you can pip install -U https://github.com/flexxui/flexx/archive/master.zip to get the latest version

Not a proficient user of Flexx, but following some recent updates it seems to not work properly for me on Windows10 with conda-managed python 3.9(.10 or .12).
Similar results on several similarly-configured machines.  Running the basic demo.py from flexxamples, it renders the "Starting Flexx App" title, but nothing else.  First error reported in the browser console is:

Uncaught SyntaxError: missing ) after argument list     flexx-core.js:1658

which appears to be a malformed call to the JS function $Loop._process_actions
In order to isolate, I started a fresh Windows Sandbox Win10 VM, installed a fresh mini-conda environment (Python 3.9.10) and created several child environments for various versions of Flexx.

v0.8.4 and v0.8.3 fail as described herein;
v0.8.2 works as expected;
v0.8.1 works with the patching described earlier for this issue.

I have not had time to investigate in further detail, for my limited purposes sticking with 0.8.2 is probably fine.
Thank you for the work you have been putting into this.

@tticknor Could you try updating pscript? The latest version is 0.7.7

This looks like #711, where the new pscript caused an error in Flexx, which needed a fix. Maybe a similar error is triggered with the new Flexx, but an old pscript ...

Using pscript 0.7.7 resolves the problem I noted above, all seems to work as expected.

Latest pscript version on conda-forge is 0.7.5, hence conda install of Flexx > 0.8.2 does not provide working configuration.
installing Flexx via pip (into an otherwise conda installation) offers pscript 0.7.7 and does provide a working configuration.

Thank you for the suggestion and feedback.

Ah, that makes sense. I've stopped actively maintaining my conda recipes since binary wheels have become ubiquitous.


Azure Storage FileService and Share clients Javadocs

Implements #3898 and #3901. Behind PR #3918
Adds Javadocs with samples to the FileService and Share clients and the model classes creating in PR #3918.

Close the one as we moved the work to #3907


Feature/new footer

Adds new in-app footer

@darrellsilver @jcudmore what do you think?

I'm 👍; can't wait!

👍 😄

Unfort I think we need to link to the homepage... students who hear about a redesign, or otherwise want to poke around, need some way to do so. How about adding "Home" to the "About" column.
The 2nd & 3rd columns should be in alphabetical order, no?

isn't the way to see the homepage just to log out? that's what I would do.

ya good point; updated!

saxy 🎷
:+1: after comments


Document the dataset release format

The file structure and format of the released files should be documented on the website.

Done: https://riverbench.github.io/documentation/dataset-release-format/


Rain removal

Hi, thanks for public your awesome works,
Currently, the provided denoising model is very nice, But it does not work well with rain images. May I ask if you will public other checkpoints of like remove rain, deblur? Or please give some suggestions to train them using your model. Thanks

Excuse me, did you go to the rain successfully?

Excuse me, did you go to the rain successfully?

I have trained on rain removal but the result is not very good. However, it can compare with the others rain removal methods.

May I ask how you train? What datasets are used?
------------------ 原始邮件 ------------------
发件人:                                                                                "ZhendongWang6/Uformer"                                                                                @.>;
发送时间: 2022年7月23日(星期六) 下午3:58
@.>;
<EMAIL_ADDRESS>主题: Re: [ZhendongWang6/Uformer] Rain removal (Issue #31)
I have trained on rain removal but the result is not very good. However, it can compare with the others rain removal methods.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Sorry, it has been a long time and is deleted now. The dataset is collected by ourselves and is formatted as the valid other for training. Below are rain videos, You can prepare the dataset by yourself
https://pixabay.com/videos/search/rain/?pagi=6

Thank you for your reply. I would like to ask how did you go about your rain training afterwards? Which model is used?
------------------ 原始邮件 ------------------
发件人:                                                                                "ZhendongWang6/Uformer"                                                                                @.>;
发送时间: 2022年7月23日(星期六) 晚上8:49
@.>;
<EMAIL_ADDRESS>主题: Re: [ZhendongWang6/Uformer] Rain removal (Issue #31)
Sorry, it has been a long time and is deleted now. The dataset is collected by ourselves and is formatted as the valid other for training. Below are rain videos, You can prepare the dataset by yourself
https://pixabay.com/videos/search/rain/?pagi=6
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


Create a simple gym environment

Start with https://github.com/robotology/gym-ignition

Looked into https://github.com/robotology/gym-ignition and I really like the idea using C++ API directly instead of ignition-transport (with Python binding).

One thing that struck me is that I could not find in source code direct interaction with plugins and how that is handled. I saw few branches with implementations of their own controllers via components (JointForceCmd - same as with JointTrajectoryController I worked on). I understand that plugins would need to expose their API in some way to make them usable directly, but I gotta ask about it.
Another thing is the currently lacking support for sensors, which would be very limiting to me. If that is not possible, I might need to stick with ignition-transport + ros2 <-> ign bridge.

Regardless, my first opinion was that the project is generally very complex and difficult for me to get started on. I will begin with my own environments and return to it once I reproduce at least one very simple DRL use case.

For Readings in Robotics, I created a simple PandaPush environment with DDPG/SAC + HER

https://github.com/AndrejOrsula/drl_grasping/tree/reproduce_her

This implementation is not very clean and it also uses a custom ignition interface

https://github.com/AndrejOrsula/ign_py

This issue is still relevant, as I have decided to create a simple env using gym-ignition instead of custom implementation.
For missing features, I still need to decide whether to use custom implementation (e.g. ignition transport to get sensor data) or to fork gym-ignition and try my best to tackle that until I give up :)

Added in https://github.com/AndrejOrsula/drl_grasping/pull/25

Added in https://github.com/AndrejOrsula/drl_grasping/pull/25


Add work precision sets and an automated workflow for the same

Description
Created work precision sets for time vs abstols, and added a workflow to create a pr with new benchmarks on every release.

The script work_precision_sets_abstols.py creates and saves the plot in benchmark_images folder, and prepends the release_work_precision_sets.md  file with the plot.
The workflow runs the script on every release and creates a pull request.

I tested the workflow and it works. I couldn't trigger workflow without a release so I added the workflow dispatch option and manually triggered it on my fork. It created this PR which looks good.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[ ] No style issues: $ flake8
[ ] All tests pass: $ python run-tests.py --unit
[ ] The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.
Further checks:

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added that prove fix is effective or that feature works

Another picky general comment about the plots. The aspect ratio of the plots look a bit strange (e.g. the ones with 2 columns and 1 row are a bit too tall). I found this blog that gives some hints on how to automatically scale them so they look nice.

Looks great, thanks! Are there any changes you need to do or shall I merge?

Looks great, thanks! Are there any changes you need to do or shall I merge?

Codacy is erroring out on the '_' in the file name. Should I rename the file or should I leave it as it is?
No other changes from my side!

I believe it is because for Markdown files it is recommended to use - instead of _. Maybe try renaming release_work_precision_sets.md to release-work-precision-sets.md and see if it works.


Input demo should focus text field

On https://jaredreich.com/projects/notie.js/, pressing the Input button opens an overlay, but the input element in the dialog is not automatically focused. This unnecessarily forces the user to click/tap on said input element to start using it.
Btw, I think this functionality should be provided by the library, automatically. Also, please see if you can integrate keyboard accessibility; after activating the Confirm/Input buttons, the dialog should be focused and the focus order should be trapped inside said dialog (so that the user doesn’t accidentally focus other page elements that are behind the overlay).

Great suggestions, will look into this, thank you.


Helm Chart

Summary
Create a helm chart for easy installation

I have cleaned up the kustomize so that should do for now.
If there is a strong need we can convert that to helm.
It is nice to have the RBAC generated.


Document that the kube-proxy's --masquerade-all conflicts.

Fixes #499

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

LGTM


Local deployment environment

This PR adds code for local testing of the playbooks.
It uses Vagrant and VirtualBox for running virtual machines. In this virtual machines vagrant runs ansible playbooks and integration tests after completion.
poa_platform enviornmental variable select the platform to run tests on - ubuntu or centos.
Makefile automates one-by-one test of all the playbooks types. It takes about 20 minutes on i5 to pass full set of tests.
One may want to run provisioning for only one machine: vagrant up explorer.

Should this also work for centos? I'm getting this error:
TASK [preconf : Install packages] **********************************************
failed: [explorer] (item=[u'bc', u'haveged', u'rsync', u'iotop', u'dstat', u'sysstat', u'htop', u'lbzip2', u'pigz', u'unzip', u'zip', u'mtr', u'tcpdump', u'openssh-client', u'sudo', u'mc', u'net-tools', u'screen', u'git', u'cloud-utils', u'build-essential', u'nload']) => {"changed": false, "cmd": "apt-get update", "item": ["bc", "haveged", "rsync", "iotop", "dstat", "sysstat", "htop", "lbzip2", "pigz", "unzip", "zip", "mtr", "tcpdump", "openssh-client", "sudo", "mc", "net-tools", "screen", "git", "cloud-utils", "build-essential", "nload"], "msg": "[Errno 2] No such file or directory", "rc": 2}

which seems to be caused by running apt update because it should be yum

Actuall, since these errors are not related to the PR, I've opened a separate issue https://github.com/poanetwork/deployment-playbooks/issues/90


Explicit mention to Defender for Business in this page

This page https://docs.microsoft.com/en-us/microsoft-365/security/defender-endpoint/respond-machine-alerts doesn't mention MDB product in the "Applies to" section.
However, manual response actions like isolate device seem to be available in MDB according to this other article:
https://docs.microsoft.com/en-us/microsoft-365/security/defender-business/compare-mdb-m365-plans?view=o365-worldwide#compare-microsoft-defender-for-business-to-microsoft-defender-for-endpoint-plans-1-and-2
In which it is mentioned:
Endpoint detection and response (behavior-based detection and manual response actions) > MDB (YES)
Please review and update accordingly this page.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6efb7742-1171-00f4-ab40-6bcc479078ca
Version Independent ID: 9a79f573-5f20-0e4c-822e-8af4ebf65422
Content: Take response actions on a device in Microsoft Defender for Endpoint
Content Source: microsoft-365/security/defender-endpoint/respond-machine-alerts.md
Product: m365-security
Technology: mde
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@smedin4 Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/8058
Once the author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @smedin4 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Context on the README document

When folks are coming directly to this repository, they won't be able to get a context of what's going on in this repo. I think it will be beneficial to pull some information from the docs repo and put it here to give some information and context of what's, what are the plan and the trajectory.

agreed! now that 0.4 is released, we can get rid of a lot of the technical documentation and replace it with other material; this was the plan/idea behind moving the deployment information to the odk docs website. i will do that soon. thanks for the feedback!


Questions about ninja

I'm looking for build system for macOS, Linux and Windows.
Does ninja is independent build system? take a look  how to compile hello world in c with ninja.
Could you provide some examples for building c++ with ninja?

build static library
build dynamic library
build executable binary linking with static library
build executable binary linking with dynamic library

Do you provide detail document about ninja?
thx

I strongly recommend you use a higher level tool, like cmake or meson.
Ninja is almost certainly not what you want for this.

Does ninja is independent build system? take a look how to compile hello world in c with ninja.

Ninja is a command runner, like Make.
The same way people would usually use something like GNU autotools to generate Makefiles, people would typically use something like Meson or cmake to generate ninja files.
It is of course possible to write your own rules by hand, but it's not ergonomic and supporting options of any kind, including "which OS to compile for", is needlessly painful.


Design fix in IE10

The words run together and are out of the box in the address select boxes in IE for both versions of the tool. We should fix this so the design appears better on the site in IE.
Note: The functionality is working fine in IE so this is only a design/look issue.
Mapbox backend:

Census backend:

This is the primary design issue in IE10


[Spike] Evaluate recert for CRC

recert  is a tool to regenerate all cryptographic objects in a cluster (both in the etcd database and filesystem files) before it starts.
This spike is to evaluate this tool for CRC and see if we can consume it without compromising around our start up time and overall cluster stability.

We looked into recert and the way we can consume it to have this binary as part of the bundle creation and then it should be run before the kubelet service and the cert expire date is not set explicitly and in our case we are patching the images for 1 year of cert expire and it worked till now.
Also I though we can also avoid creating a custom kubeconfig as part of crc post cluster start but that was not possible that moment (need to check if that is changed now)

we are patching the images for 1 year of cert expire and it worked till now.

It's been working so far, but this means we have non-official builds in our cluster, we need to maintain the build scripts, ...
Moving to something provided by upstream/OpenShift is an improvement from that perspective.
Then it has to work for our needs, it should not slow down cluster startup, ...


Upgrade vulnerable dependencies

I got a warning in my project about some potential vulnerable dependencies in this package, so I just ran npm audit fix and incremented the patch version.

Thx David!


Update the ContainerOptionsBuilder with new publish all ports option

The following change is to provide the configuration option
PublishAllPorts which will map all exposed ports on a container to
random and available ports on the host machine.
This configuration option is documented
here.
CHANGELOG.md is not updated, because I do not think there are any breaking changes.
What did you implement:
Closes: https://github.com/softprops/shiplift/issues/214
How did you verify your change:
I have added a test to the builder; builder::tests::container_options_publish_all_ports
Ran cargo test with the following results.
running 12 tests
test builder::tests::container_options_publish_all_ports ... ok
test builder::tests::container_options_nested ... ok
test builder::tests::container_options_host_config ... ok
test builder::tests::container_options_env ... ok
test builder::tests::container_options_simple ... ok
test builder::tests::container_options_restart_policy ... ok
test builder::tests::container_options_publish ... ok
test builder::tests::registry_auth_password_all ... ok
test builder::tests::registry_auth_password_simple ... ok
test builder::tests::logs_options ... ok
test builder::tests::registry_auth_token ... ok
test builder::tests::container_options_expose ... ok

test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

   Doc-tests shiplift

running 1 test
test src/lib.rs -  (line 5) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

What (if anything) would need to be called out in the CHANGELOG for the next release:
Nothing I think?

I have a few concerns I was not sure how to go about testing.

Docker version support
This feature is documented in the earliest version documented here https://docs.docker.com/engine/api/version-history/ (1.18), and is in the latest with no mentioned change in the change logs, but I am not sure about possibly earlier versions not listed on that page.

I did not test possible conflicts if this PublishAllPorts and the port mapping are provided.
I assumed this to be the responsibility of docker, but maybe this tool wants to do some checks before hand in the builder for possibly conflicting configurations? (again assumes it would even be a conflict)

Thanks for the addition @tylerhjones


npm start give errors

If I run 'npm install && npm start' I get error.
Content of npm-debug.log is:

0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info prestart<EMAIL_ADDRESS>6 info start<EMAIL_ADDRESS>7 verbose unsafe-perm in lifecycle true
8 info<EMAIL_ADDRESS>Failed to exec start script
9 verbose stack Error<EMAIL_ADDRESS>start: electron main.js
9 verbose stack Exit status 1
9 verbose stack     at EventEmitter. (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:214:16)
9 verbose stack     at emitTwo (events.js:87:13)
9 verbose stack     at EventEmitter.emit (events.js:172:7)
9 verbose stack     at ChildProcess. (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:24:14)
9 verbose stack     at emitTwo (events.js:87:13)
9 verbose stack     at ChildProcess.emit (events.js:172:7)
9 verbose stack     at maybeClose (internal/child_process.js:818:16)
9 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)
10 verbose pkgid<EMAIL_ADDRESS>11 verbose cwd /home/dev/WebstormProjects/electron-quick-start
12 error Linux 2.6.32-504.8.1.el6.x86_64
13 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
14 error node v4.2.3
15 error npm  v2.14.7
16 error code ELIFECYCLE
17 error<EMAIL_ADDRESS>start: electron main.js
17 error Exit status 1
18 error Failed at the<EMAIL_ADDRESS>start script 'electron main.js'.
18 error This is most likely a problem with the electron-quick-start package,
18 error not with npm itself.
18 error Tell the author that this fails on your system:
18 error     electron main.js
18 error You can get their info via:
18 error     npm owner ls electron-quick-start
18 error There is likely additional logging output above.
19 verbose exit [ 1, true ]

Tried various versions of node 4.x and 5.x and 0.12.x.  Same issue.
Running on Centos 6.6

I now see that Centos is not in the list of supported OS.  I guess that it the problem for me.  I should have checked first.


What makes the glider being drifted? (same question asked on notion)

@rakeshv24 Which part of the code make the glider being drifted? It could be helpful for @GauravKumar9920 on migration of ocean current plugin. The ocean wave model being used in the world sdf was only for visual unless https://github.com/srmainwaring/asv_wave_sim is ported.

@woensug-choi my immediate response is that the buoyancy plugin is causing the vehicle to move. However, when I adjust the vehicle's mass to make it neutrally buoyant as mentioned here, the drift doesn't appear as much. Additionally, we might need to use a better set of added mass values.

Conversation continues at https://yeongdocat.notion.site/Under-water-Current-Dave-9905dc2a4ad54b6da0fceea023f7cf04?pvs=4


Question

How would I get rid of the members open on hover thing?

sorry for the late reply, i rarely ever check github issues. you can dm me(carrot#8812) and ill help you remove it.

All good man I think you've helped me couple of times on discord as well already


CHECK_WAVE: Does not check inputs

The following
Function Fails()

	Make/FREE/D wv
	CHECK_WAVE(wv, 0, minorType = 0)
End

gives
•runtest("Procedure")
  Start of test "Unnamed"
  Entering test suite "Procedure"
  Entering test case "Fails"
  Leaving test case "Fails"
  Finished with no errors
  Leaving test suite "Procedure"
  Test finished with no errors
  End of test "Unnamed"

Two problems:

The input for majorType is not valid, but accepted
The minor type is actually valid as this is NON_NUMERIC_WAVE (aka 0) but the test should fail with this interpretation

In PR #288 the constant NON_NUMERIC_WAVE is changed to 0x100 to enable intentional selection of this property. This also results in 0 as an invalid minor type.


[Bug]: can't use swc-plugin-coverage-instrument with rsbuild

Version
System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M2 Pro
    Memory: 8.07 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 123.0.6312.107
    Safari: 17.2.1
  npmPackages:
    @rsbuild/core: ^0.5.9 => 0.5.9
    @rsbuild/plugin-react: ^0.5.9 => 0.5.9

Details
Hi
I am migrating my webpack app to rspack.
Really impressed so far with the speed and overall developer experience. Keep up the great work!
I'm trying to use swc-plugin-coverage-instrument but getting the following error:
Html Webpack Plugin:

Error: [html-rspack-plugin]: [html-rspack-plugin]:   × Module parse failed:
  ╰─▶   × JavaScript parsing error: The left-hand side of an assignment expression must be a variable or a property access.
          ╭─[32:1]
       32 │     if (!coverage[path] || coverage[path].hash !== hash) this = this;
       33 │     var actualCoverage = coverage[path];
       34 │     this = this;
          ·     ────
       35 │     return actualCoverage;
       36 │ }
          ╰────

  help:
        File was processed with these loaders:
         * builtin:swc-loader??ruleSet[1].rules[3].use[0]
        You may need an additional loader to handle the result of these loaders.

My rspack config:
import { defineConfig } from '@rsbuild/core';
import { pluginReact } from '@rsbuild/plugin-react';

export default defineConfig({
  plugins: [pluginReact()],
  tools: {
    swc: {
      jsc: {
        experimental: {
          plugins: [['swc-plugin-coverage-instrument', {}]],
        },
      },
    },
  },
});

Any help would be welcome :-)
Reproduce link
https://github.com/eidellev/rspack-bug-reproduction
Reproduce Steps
npm run dev

It may be related to https://github.com/web-infra-dev/rspack/issues/5921.
The version of swc-plugin must be aligned with the rspack builtin swc_core .

Thank you @SoonIter for the quick reply.
I don't think this is related. I tried rolling back the plugin to an older version and got a panic like in the issue you linked to.

rspack 0.6.0 which should fix this issue will be released soon.
please wait for the new version of rsbuild that comes with rspack 0.6.0 or try out @rspack/core@nightly

@xc2 Thank you!

Fixed in v0.6.0

Works great. Thanks @chenjiahan !


Add json reader

Add the possibility to read json files (simulation model parameters are stored in json in the database).
This is a straightforward implementation following the yaml reader routines. general.collect_data_from_yaml_or_dict has not been renamed (although it can read now as well json files). My feeling is that the file name file be too long if we do collect_data_from_yaml_or_json_or_dict.
Additional adopted simtools/applications/validate_file_using_schema.py to validate json files (integration test added).

@VictorBarbosaMartins - I've followed your suggestions, thanks for this.
Waiting for the tests and will then merge.


Supermicro boot order issues

As tested several times, it seems the Supermicro tasks do not always work as intended.  Although BootSourceOverrideEnabled is set to once, the machines do not instantly boot to a virtual iso and instead follow the typical pattern of running through the entire boot order.  I am unsure if this is an issue with the tasks, the hardware, redfish or the firmware.  The only known workaround at the moment is to ensure cdrom is earlier in boot order than the hard disk and observe the status of the install and manually eject the virtual cdrom once the install completes writing to the disk.

I believe #97 also fixed this.


Get XAR working to massively optimize Zulip process startup times

Even with the optimizations we've done in #9953, a basic Zulip process with all Python dependencies takes 1.5s to startup, and most of that is unavoidable given the set of dependencies we have (principally, Django itself).
The main idea we haven't tried that could potentially make a huge difference is integrating Facebook's Xar tool (https://code.fb.com/data-infrastructure/xars-a-more-efficient-open-source-system-for-self-contained-executables/) for optimizing the Python startup time of Zulip.  Based on the benchmarks they list there, one could easily imagine making Zulip process startup time more like a few hundred milliseconds, which is fast enough that we could basically declare victory here.
However, I'm not sure how to get Xar working with Zulip's virtualenv, and further investigation is required.
E.g. we don't have a setup.py file and it's not clear how to use Xar without one (I opened https://github.com/facebookincubator/xar/issues/27 for this).  It's also not clear it supports all the Python versions we need, and how we'd do the production toolchain work given that Zulip supports a range of architectures.  But I think we can figure that out once we have a basic prototype of e.g. running manage.py help via a Xar archive.  Eventually we'll want to make manage.py and uwsgi work with this, but even just manage.py would be huge for our production server restart load situation.
Working on this may be difficult just because it involves using a Facebook open source project that has only 13 commits of public history, but I don't think it requires deep context on how Zulip works.
If we do get this working, it'd be nice to write a blog post about it.

On startup time: the Django import is fast, the Django setup itself is the most time consuming part, which takes ~33% of the main() in tools/lib/provision.py
Total time: 7.88087 s
File: ./lib/provision.py
Function: main at line 212

Line #      Hits         Time  Per Hit   % Time  Line Contents
==============================================================
   212                                           @profile
   213                                           def main(options):
   214                                               # type: (Any) -> int
   215
   216                                               # yarn and management commands expect to be run from the root of the
   217                                               # project.
   218         1         34.0     34.0      0.0      os.chdir(ZULIP_PATH)
   219
   220                                               # setup-apt-repo does an `apt-get update`
   221                                               # hash the apt dependencies
   222         1         18.0     18.0      0.0      sha_sum = hashlib.sha1()
   223
   224        47        199.0      4.2      0.0      for apt_depedency in APT_DEPENDENCIES[codename]:
   225        46        254.0      5.5      0.0          sha_sum.update(apt_depedency.encode('utf8'))
   226                                               # hash the content of setup-apt-repo
   227         1        127.0    127.0      0.0      sha_sum.update(open('scripts/lib/setup-apt-repo', 'rb').read())
   228
   229         1         12.0     12.0      0.0      new_apt_dependencies_hash = sha_sum.hexdigest()
   230         1          4.0      4.0      0.0      last_apt_dependencies_hash = None
   231         1         22.0     22.0      0.0      apt_hash_file_path = os.path.join(UUID_VAR_PATH, "apt_dependencies_hash")
   232         1        115.0    115.0      0.0      with open(apt_hash_file_path, 'a+') as hash_file:
   233         1         30.0     30.0      0.0          hash_file.seek(0)
   234         1         43.0     43.0      0.0          last_apt_dependencies_hash = hash_file.read()
   235
   236         1          5.0      5.0      0.0      if (new_apt_dependencies_hash != last_apt_dependencies_hash):
   237                                                   try:
   238                                                       install_apt_deps()
   239                                                   except subprocess.CalledProcessError:
   240                                                       # Might be a failure due to network connection issues. Retrying...
   241                                                       print(WARNING + "`apt-get -y install` failed while installing dependencies; retrying..." + ENDC)
   242                                                       # Since a common failure mode is for the caching in
   243                                                       # `setup-apt-repo` to optimize the fast code path to skip
   244                                                       # running `apt-get update` when the target apt repository
   245                                                       # is out of date, we run it explicitly here so that we
   246                                                       # recover automatically.
   247                                                       run(['sudo', 'apt-get', 'update'])
   248                                                       install_apt_deps()
   249                                                   with open(apt_hash_file_path, 'w') as hash_file:
   250                                                       hash_file.write(new_apt_dependencies_hash)
   251                                               else:
   252         1         41.0     41.0      0.0          print("No changes to apt dependencies, so skipping apt operations.")
   253
   254                                               # Here we install node.
   255                                               proxy_env = [
   256         1          4.0      4.0      0.0          "env",
   257         1         21.0     21.0      0.0          "http_proxy=" + os.environ.get("http_proxy", ""),
   258         1         10.0     10.0      0.0          "https_proxy=" + os.environ.get("https_proxy", ""),
   259         1         15.0     15.0      0.0          "no_proxy=" + os.environ.get("no_proxy", ""),
   260                                               ]
   261         1      37326.0  37326.0      0.5      run(["sudo", "-H"] + proxy_env + ["scripts/lib/install-node"])
   262
   263                                               # This is a wrapper around `yarn`, which we run last since
   264                                               # it can often fail due to network issues beyond our control.
   265         1          8.0      8.0      0.0      try:
   266                                                   # Hack: We remove `node_modules` as root to work around an
   267                                                   # issue with the symlinks being improperly owned by root.
   268         1         56.0     56.0      0.0          if os.path.islink("node_modules"):
   269         1      29537.0  29537.0      0.4              run(["sudo", "rm", "-f", "node_modules"])
   270         1      21236.0  21236.0      0.3          run(["sudo", "mkdir", "-p", NODE_MODULES_CACHE_PATH])
   271         1      34630.0  34630.0      0.4          run(["sudo", "chown", "%s:%s" % (user_id, user_id), NODE_MODULES_CACHE_PATH])
   272         1      36486.0  36486.0      0.5          setup_node_modules(prefer_offline=True)
   273                                               except subprocess.CalledProcessError:
   274                                                   print(WARNING + "`yarn install` failed; retrying..." + ENDC)
   275                                                   setup_node_modules()
   276
   277                                               # Install shellcheck.
   278         1      24492.0  24492.0      0.3      run(["sudo", "scripts/lib/install-shellcheck"])
   279
   280                                               # Import tools/setup_venv.py instead of running it so that we get an
   281                                               # activated virtualenv for the rest of the provisioning process.
   282         1       3111.0   3111.0      0.0      from tools.setup import setup_venvs
   283         1     625329.0 625329.0      7.9      setup_venvs.main()
   284
   285         1        529.0    529.0      0.0      setup_shell_profile('~/.bash_profile')
   286         1        408.0    408.0      0.0      setup_shell_profile('~/.zprofile')
   287
   288         1      26809.0  26809.0      0.3      run(["sudo", "cp", REPO_STOPWORDS_PATH, TSEARCH_STOPWORDS_PATH])
   289
   290                                               # create log directory `zulip/var/log`
   291         1        160.0    160.0      0.0      os.makedirs(LOG_DIR_PATH, exist_ok=True)
   292                                               # create upload directory `var/uploads`
   293         1         71.0     71.0      0.0      os.makedirs(UPLOAD_DIR_PATH, exist_ok=True)
   294                                               # create test upload directory `var/test_upload`
   295         1         64.0     64.0      0.0      os.makedirs(TEST_UPLOAD_DIR_PATH, exist_ok=True)
   296                                               # create coverage directory`var/coverage`
   297         1         62.0     62.0      0.0      os.makedirs(COVERAGE_DIR_PATH, exist_ok=True)
   298                                               # create linecoverage directory`var/node-coverage`
   299         1         63.0     63.0      0.0      os.makedirs(NODE_TEST_COVERAGE_DIR_PATH, exist_ok=True)
   300
   301                                               # `build_emoji` script requires `emoji-datasource` package which we install
   302                                               # via npm and hence it should be executed after we are done installing npm
   303                                               # packages.
   304         1         24.0     24.0      0.0      if not os.path.isdir(EMOJI_CACHE_PATH):
   305                                                   run(["sudo", "mkdir", EMOJI_CACHE_PATH])
   306         1      27081.0  27081.0      0.3      run(["sudo", "chown", "%s:%s" % (user_id, user_id), EMOJI_CACHE_PATH])
   307         1     394032.0 394032.0      5.0      run(["tools/setup/emoji/build_emoji"])
   308
   309                                               # copy over static files from the zulip_bots package
   310         1     867523.0 867523.0     11.0      run(["tools/setup/generate_zulip_bots_static_files"])
   311
   312         1          8.0      8.0      0.0      webfont_paths = ["tools/setup/generate-custom-icon-webfont", "static/icons/fonts/template.hbs"]
   313         1        980.0    980.0      0.0      webfont_paths += glob.glob('static/assets/icons/*')
   314         1       1351.0   1351.0      0.0      if file_or_package_hash_updated(webfont_paths, "webfont_files_hash", options.is_force):
   315                                                   run(["tools/setup/generate-custom-icon-webfont"])
   316                                               else:
   317         1         74.0     74.0      0.0          print("No need to run `tools/setup/generate-custom-icon-webfont`.")
   318
   319         1          6.0      6.0      0.0      build_pygments_data_paths = ["tools/setup/build_pygments_data", "tools/setup/lang.json"]
   320         1         51.0     51.0      0.0      from pygments import __version__ as pygments_version
   321         1          9.0      9.0      0.0      if file_or_package_hash_updated(build_pygments_data_paths, "build_pygments_data_hash", options.is_force,
   322         1       1009.0   1009.0      0.0                                      [pygments_version]):
   323                                                   run(["tools/setup/build_pygments_data"])
   324                                               else:
   325         1         53.0     53.0      0.0          print("No need to run `tools/setup/build_pygments_data`.")
   326
   327         1     328459.0 328459.0      4.2      run(["scripts/setup/generate_secrets.py", "--development"])
   328         1     731671.0 731671.0      9.3      run(["tools/update-authors-json", "--use-fixture"])
   329
   330         1          9.0      9.0      0.0      email_source_paths = ["tools/inline-email-css", "templates/zerver/emails/email.css"]
   331         1       1371.0   1371.0      0.0      email_source_paths += glob.glob('templates/zerver/emails/*.source.html')
   332         1       1831.0   1831.0      0.0      if file_or_package_hash_updated(email_source_paths, "last_email_source_files_hash", options.is_force):
   333                                                   run(["tools/inline-email-css"])
   334                                               else:
   335         1         82.0     82.0      0.0          print("No need to run `tools/inline-email-css`.")
   336
   337         1          6.0      6.0      0.0      if is_circleci or (is_travis and not options.is_production_travis):
   338                                                   run(["sudo", "service", "rabbitmq-server", "restart"])
   339                                                   run(["sudo", "service", "redis-server", "restart"])
   340                                                   run(["sudo", "service", "memcached", "restart"])
   341                                                   run(["sudo", "service", "postgresql", "restart"])
   342         1          6.0      6.0      0.0      elif options.is_docker:
   343                                                   run(["sudo", "service", "rabbitmq-server", "restart"])
   344                                                   run(["sudo", "pg_dropcluster", "--stop", POSTGRES_VERSION, "main"])
   345                                                   run(["sudo", "pg_createcluster", "-e", "utf8", "--start", POSTGRES_VERSION, "main"])
   346                                                   run(["sudo", "service", "redis-server", "restart"])
   347                                                   run(["sudo", "service", "memcached", "restart"])
   348         1          6.0      6.0      0.0      if not options.is_production_travis:
   349                                                   # The following block is skipped for the production Travis
   350                                                   # suite, because that suite doesn't make use of these elements
   351                                                   # of the development environment (it just uses the development
   352                                                   # environment to build a release tarball).
   353
   354                                                   # Need to set up Django before using template_database_status
   355         1         88.0     88.0      0.0          os.environ.setdefault("DJANGO_SETTINGS_MODULE", "zproject.settings")
   356         1       4439.0   4439.0      0.1          import django
   357         1    2642880.0 2642880.0     33.5          django.setup()
   358
   359         1       3955.0   3955.0      0.1          from zerver.lib.test_fixtures import template_database_status, run_db_migrations
   360
   361         1          4.0      4.0      0.0          try:
   362         1         10.0     10.0      0.0              from zerver.lib.queue import SimpleQueueClient
   363         1      41877.0  41877.0      0.5              SimpleQueueClient()
   364                                                       rabbitmq_is_configured = True
   365         1          7.0      7.0      0.0          except Exception:
   366         1          5.0      5.0      0.0              rabbitmq_is_configured = False
   367
   368                                                   #if options.is_force or not rabbitmq_is_configured:
   369                                                   #    run(["scripts/setup/configure-rabbitmq"])
   370                                                   #else:
   371                                                   #    print("RabbitMQ is already configured.")
   372
   373         1         22.0     22.0      0.0          migration_status_path = os.path.join(UUID_VAR_PATH, "migration_status_dev")
   374         1          5.0      5.0      0.0          dev_template_db_status = template_database_status(
   375         1          4.0      4.0      0.0              migration_status=migration_status_path,
   376         1          4.0      4.0      0.0              settings="zproject.settings",
   377         1    1631156.0 1631156.0     20.7              database_name="zulip",
   378                                                   )
   379                                                   #if options.is_force or dev_template_db_status == 'needs_rebuild':
   380                                                   #    run(["tools/setup/postgres-init-dev-db"])
   381                                                   #    run(["tools/do-destroy-rebuild-database"])
   382                                                   #elif dev_template_db_status == 'run_migrations':
   383                                                   #    run_db_migrations('dev')
   384                                                   #elif dev_template_db_status == 'current':
   385                                                   #    print("No need to regenerate the dev DB.")
   386
   387                                                   #test_template_db_status = template_database_status()
   388                                                   #if options.is_force or test_template_db_status == 'needs_rebuild':
   389                                                   #    run(["tools/setup/postgres-init-test-db"])
   390                                                   #    run(["tools/do-destroy-rebuild-test-database"])
   391                                                   #elif test_template_db_status == 'run_migrations':
   392                                                   #    run_db_migrations('test')
   393                                                   #elif test_template_db_status == 'current':
   394                                                   #    print("No need to regenerate the test DB.")
   395
   396                                                   # Consider updating generated translations data: both `.mo`
   397                                                   # files and `language-options.json`.
   398         1          6.0      6.0      0.0          paths = ['zerver/management/commands/compilemessages.py']
   399         1       6888.0   6888.0      0.1          paths += glob.glob('static/locale/*/LC_MESSAGES/*.po')
   400         1        885.0    885.0      0.0          paths += glob.glob('static/locale/*/translations.json')
   401
   402         1      14847.0  14847.0      0.2          if file_or_package_hash_updated(paths, "last_compilemessages_hash", options.is_force):
   403                                                       run(["./manage.py", "compilemessages"])
   404                                                   else:
   405         1        138.0    138.0      0.0              print("No need to run `manage.py compilemessages`.")
   406
   407         1     336031.0 336031.0      4.3      run(["scripts/lib/clean-unused-caches"])
   408
   409         1         63.0     63.0      0.0      version_file = os.path.join(UUID_VAR_PATH, 'provision_version')
   410         1         81.0     81.0      0.0      print('writing to %s\n' % (version_file,))
   411         1        449.0    449.0      0.0      open(version_file, 'w').write(PROVISION_VERSION + '\n')
   412
   413         1         21.0     21.0      0.0      print()
   414         1         25.0     25.0      0.0      print(OKBLUE + "Zulip development environment setup succeeded!" + ENDC)
   415         1          5.0      5.0      0.0      return 0