ref(build): Add central build directory from JS SDK

⚠ Only merge after #320 was merged and this was rebased
This PR makes a change to the build process: Previously, transpiled JS, declaration files and source maps were written into dist. To align Replay with the build process in the SDK monorepo, this PR makes the following changes:

Change build output to build/npm (see explanation below)
Change build:npm command to execute a prepack script
Temporarily introduce the ./scripts/tmp-prepack.ts script which copies files like README.md, LICENSE and package.json into build/npm. This is a simplified version of the monorepo's prepack script. While doing so, the script makes changes to package.json to align the entry points.

This file will be removed once we migrated as we can then use the monorepo's prepack script.

Remove the files entry in package.json for consistency with the monorepo (we just rely on .npmignores)
Adjust occurrances of dist folder, replacing or adding build as appropriate

As of this PR, the build directory will have the following structure:
<replay-root>/
├─ build/
│  ├─ npm/ <-- everything in this directory goes into the NPM tarball
│  │  ├─ types/
│  │  │  ├─ *.d.ts files (+maps)
│  │  ├─ index(.es)?.js file + map
│  │  ├─ package.json
│  │  ├─ LICENSE
│  |  ├─ README.md
├─ ...

More context on the JS SDK's build directory structure:
While this is arguably not the simplest setup, the structure below serves two purposes:

Have one directory per SDK into which all build and artifact (tarball, CDN bundle) related files go
Be able to make modifications to the files we ship vs. the ones we keep in the repo.
For example, we remove certain properties in the shipped package.json, which our users don't need

Once we finished the migration of Replay, the build directory structure will be identical to the JS SDK structure of SDK packages with bundles:
<replay-root>/
├─ build/
│  ├─ bundles/ <-- that's where the CDN bundles will live
│  ├─ npm/ <-- everything in this directory goes into the NPM tarball
│  │  ├─ types/
│  │  │  ├─ *.d.ts files (+maps)
│  │  ├─ esm/
│  │  │  ├─ ESM JS files (+maps)
│  │  ├─ cjs/
│  │  │  ├─ *CJS files (+maps)
│  │  ├─ package.json
│  │  ├─ LICENSE
│  |  ├─ README.md
├─ ...

Note that as soon as we change the entry point paths in package.json (main, modules, types), we're technically introducing a breaking change. It is however a very edge-case-y scenario in which users import modules from an explicit path rather than from the top-level package:
// this import would break after moving the index file to esm/index.es.js
import {} from<EMAIL_ADDRESS>
// this import would still work as expected
import {} from '@sentry/replay';

I would argue that introducing this breaking change is fine as long as we're in this 0.x/alpha state but I'm happy to hear other opinions on this.
As of this PR nothing breaking is happening yet.

Thanks for the detailed explanation -- I agree with you in regards to the breaking change.

size-limit report 📦
Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
dist/index.js	0 B (-100% 🔽)	0 ms (-100% 🔽)	0 ms (-100% 🔽)	0 ms
build/npm/index.js	34.88 KB (+100% 🔺)	698 ms (+100% 🔺)	71 ms (+100% 🔺)	769 ms

I guess we can't simplify this transition for size-bot 🤔


auto-casting bug with structural types

error: This is an ambiguous function call. [line:46 col:14] in
line 45: if (_cancellation.PolicyPeriod.CancellationProcess.canRequestQuote().Okay and perm.System.advancecancellation and _cancellation typeis PolicyContractChangeable) {
line 46: return _cancellation.canStartJobXxx(null, _policyPeriod)
line 47: }
explicitly casting _cancellation to the PolicyContractChangeable structure in line 46 fixes this

e2ee9ac753785968221731a094e05d65118d1eda


Fix warning about moved from object

Closes #3805

Coverage remained the same at 100.0% when pulling bef2e56ff15f7ae7477315ca8b01afcf0180131c on issue_3805 into 7f72eedc2d4fc196d389f5aa0b2659f70dabe278 on develop.


Automated cherry pick of #4428: Bugfix: Pod or gateway interface use a different MAC from the

Cherry pick of #4428 on release-1.9.
#4428: Bugfix: Pod or gateway interface use a different MAC from the
For details on the cherry pick process, see the cherry pick requests page.

/skip-e2e which failed on an irrelevant test, which is tracked by https://github.com/antrea-io/antrea/issues/4477
/test-networkpolicy

/test-latest-networkpolicy


States are not updated correctly

West Bengal has 69 as per https://www.mohfw.gov.in/

Please file issues pertaining to the codebase only. Data discrepancies should be reported in the telegram group (check footer of the website)


GC Clamp Property Added to Primer Class

Reference Issues/PRs
#28
What does this implement/fix? Explain your changes.
gc_clamp attribute added to the Primer class
Any other comments?
:red_circle: It's odd but the test sample driven from oligoevaluator is different from what the issue and the references says. We should find out what is wrong with either of these sources.

Codecov Report
Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.72%. Comparing base (09cfd0a) to head (b249343).

Files with missing lines
Patch %
Lines

opr/primer.py
76.93%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #32      +/-   ##
==========================================
- Coverage   85.00%   84.72%   -0.28%
==========================================
  Files           5        5
  Lines         140      157      +17
  Branches       14       16       +2
==========================================
+ Hits          119      133      +14
- Misses         13       15       +2
- Partials        8        9       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@sadrasabouri @sepandhaghighi
Guys I wanted to review this PR, but why you've removed me?

@sadrasabouri @sepandhaghighi Guys I wanted to review this PR, but why you've removed me?

Hi @AHReccese
It's not a major PR and doesn't need two reviewers.
Now you can start your work on #29.


Find In Files doesn't search outside of workspace

VSCode Version: 1.14.2; 1.15.0-insider
OS Version: Windows 10 (1703.15063.502); MacOS 10.12.5 (Sierra)

Steps to Reproduce:
According to issue #17164, in version 1.14, Find in Files should allow you to search outside of the workspace much like every other advanced text editor available. However, this still doesn't appear to work.
Reproduces without extensions: No

This does work, what are you trying?

Not sure if this is related, but when I try to search for a file deep within the folder structure, it does not return results with the latest release. However if you search the exact name of the file, the results. come up.
Example,
In my directory structure there is a file called layout_list that can be in several different folders listings, offers, events, etc. ...
I used to be able to search listings widget_layout_list, and the results would return the one that 's in listings, now it shows no results.

That doesn't sound related, @rwatts3 can you open a new issue with more details about exactly what you are trying to search for? I don't quite follow.


DOC: Fixed path problems

Closes #652
FYI: You have some other minor problems with docs:

Click to expand
quickbook.quickbook-to-boostbook ..\bin.v2\libs\compute\doc\msvc-14.1\debug\threadapi-win32\threading-multi\compute.xml
Generating Output File: ..\bin.v2\libs\compute\doc\msvc-14.1\debug\threadapi-win32\threading-multi\compute.xml
doxygen-action ..\bin.v2\libs\compute\doc\none\msvc-14.1\debug\threadapi-win32\threading-multi\autodoc-xml.xml-dir
The system cannot find the file specified.
../boost/libs/compute/include/boost/compute/algorithm/accumulate.hpp:159: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/accumulate.hpp:160: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/adjacent_difference.hpp:67: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/adjacent_difference.hpp:68: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/adjacent_find.hpp:117: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/all_of.hpp:23: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/any_of.hpp:27: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/binary_search.hpp:24: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/copy.hpp:829: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/copy_if.hpp:42: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/copy_n.hpp:33: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/count.hpp:26: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/count.hpp:27: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/count_if.hpp:29: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/count_if.hpp:30: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/equal.hpp:24: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/equal_range.hpp:27: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/exclusive_scan.hpp:47: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/exclusive_scan.hpp:48: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/exclusive_scan.hpp:49: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/fill.hpp:274: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/fill_n.hpp:23: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/find.hpp:26: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/find_end.hpp:91: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/find_if.hpp:24: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/find_if_not.hpp:25: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/for_each.hpp:48: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/for_each_n.hpp:22: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/gather.hpp:65: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/generate.hpp:26: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/generate_n.hpp:24: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/includes.hpp:111: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/inclusive_scan.hpp:45: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/inclusive_scan.hpp:46: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/inclusive_scan.hpp:47: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/inner_product.hpp:30: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/inner_product.hpp:31: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/inplace_merge.hpp:27: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/iota.hpp:30: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/is_partitioned.hpp:25: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/is_permutation.hpp:37: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/is_sorted.hpp:33: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/lexicographical_compare.hpp:108: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/lower_bound.hpp:25: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/max_element.hpp:46: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/max_element.hpp:47: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/merge.hpp:40: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/minmax_element.hpp:34: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/minmax_element.hpp:35: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/min_element.hpp:46: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/min_element.hpp:47: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/mismatch.hpp:32: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/next_permutation.hpp:132: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/none_of.hpp:23: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/nth_element.hpp:27: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/partial_sum.hpp:25: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/partial_sum.hpp:26: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/partial_sum.hpp:27: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/partition.hpp:25: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/partition_copy.hpp:27: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/partition_point.hpp:30: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/prev_permutation.hpp:132: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/random_shuffle.hpp:31: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/reduce.hpp:268: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/reduce.hpp:269: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/reduce_by_key.hpp:54: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/reduce_by_key.hpp:55: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/remove.hpp:25: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/remove_if.hpp:25: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/replace.hpp:72: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/replace_copy.hpp:28: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/reverse.hpp:55: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/reverse_copy.hpp:54: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/rotate.hpp:24: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/rotate_copy.hpp:23: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/scatter.hpp:82: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/scatter_if.hpp:86: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/search.hpp:35: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/search_n.hpp:103: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/set_difference.hpp:124: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/set_intersection.hpp:112: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/set_symmetric_difference.hpp:135: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/set_union.hpp:137: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/sort.hpp:179: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/sort_by_key.hpp:131: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/stable_partition.hpp:34: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/stable_sort.hpp:75: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/stable_sort_by_key.hpp:129: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/swap_ranges.hpp:25: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/transform.hpp:32: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/transform_reduce.hpp:33: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/transform_reduce.hpp:34: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/unique.hpp:34: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/unique_copy.hpp:130: warning: Found unknown command `\Omega'
../boost/libs/compute/include/boost/compute/algorithm/upper_bound.hpp:26: warning: Found unknown command `\Omega'
xslt-xsltproc.windows ..\bin.v2\libs\compute\doc\none\msvc-14.1\debug\threadapi-win32\threading-multi\autodoc-xml.doxygen
xslt-xsltproc.windows ..\bin.v2\libs\compute\doc\none\msvc-14.1\debug\threadapi-win32\threading-multi\autodoc-xml.boostbook
../boost/libs/compute/include/boost/compute/event.hpp:318: Cannot handle sectiondef with kind=protected-attrib
../boost/libs/compute/include/boost/compute/memory_object.hpp:245: Cannot handle sectiondef with kind=protected-attrib
common.copy ..\boost\libs\compute\doc\autodoc.xml
..\bin.v2\libs\compute\doc\none\msvc-14.1\debug\threadapi-win32\threading-multi\autodoc-xml.boostbook
        1 file(s) copied.
xslt-xsltproc.windows ..\bin.v2\libs\compute\doc\msvc-14.1\debug\threadapi-win32\threading-multi\compute.docbook
Reference to method 'boost::compute::buffer::get_info' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::command_queue::get_info' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::command_queue::enqueue_nd_range_kernel' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::command_queue::enqueue_barrier' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::command_queue::enqueue_marker' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::context::get_info' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::device::get_info' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::event::get_info' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::kernel::get_info' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::kernel::get_arg_info' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::kernel::set_arg' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::pipe::get_info' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::platform::get_info' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::program::create_with_source' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::program::create_with_binary' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Reference to method 'boost::compute::program::get_info' is ambiguous. Found:
              Match in namespace ::
              Match in namespace ::
Cannot find class named 'vector_type::iterator'
Cannot find class named 'vector_type::const_iterator'
Cannot find class named 'placeholder'
Cannot find class named 'placeholder'
Cannot find class named 'placeholder'
Cannot find class named 'placeholder'
xslt-xsltproc-dir.windows ..\boost\libs\compute\doc\html\standalone_HTML.manifest

I am closing this as there is no response


lazyloadxt with bootstrap carousel

When I use lazyloadxt in my bootstrap carousel page,
It couldn't load the image when carousel auto slide.
Then, I use:
$(window).lazyLoadXT({ updateEvent: 'load orientationchange resize scroll touchmove focus slid.bs.carousel' });
also not work.
Must modify the jquery.lazyloadxt.min.js:
change this line:
updateEvent: "load orientationchange resize scroll touchmove focus"
to:
updateEvent: "load orientationchange resize scroll touchmove focus slid.bs.carousel"
then It is work when carousel auto slide.

You use improper way to initialize LazyLoadXT. Instead, use
$.lazyLoadXT.updateEvent += ' slid.bs.carousel';

Now you can use this:
https://github.com/ressio/lazy-load-xt#bootstrap-and-jquerymobile
to handle it.


simple previewer with only text not working in latest builds

Am just providing a url to previewer , which used to work in ealier versions , to be exact it was working in Ver 1.0.4 , now with latest version its only showing a link text .
                                     LinkPreview(
                                        text: urltxt ,
                                        width:MediaQuery.of(context).size.width,
                                      ),

its placed inside a list builder . Any thoughts ?
Flutter 2.6.0-6.0.pre.83 • channel master • https://github.com/flutter/flutter.git
Framework • revision b889915997 (19 hours ago) • 2021-09-14 14:08:36 +0200
Engine • revision abb1980f65
Tools • Dart 2.15.0 (build 2.15.0-96.0.dev)

Please read a changelog or check the README. This is now a controlled widget and you need to store the preview data somewhere, and provide it back.


adding Sketch-n-Sketch

A research project that several students and I are working on at UChicago.

Oh awesome! Someone mentioned this class to me, it's very exciting to have your work featured here. I'll merge this in as soon as I have some time tonight or tomorrow.

Thanks, I appreciate it!
— Ravi

On Dec 15, 2015, at 12:08 PM, Luke Westby<EMAIL_ADDRESS>wrote:
Oh awesome! Someone mentioned this class to me, it's very exciting to have your work featured here. I'll merge this in as soon as I have some time tonight or tomorrow.
—
Reply to this email directly or view it on GitHub https://github.com/lukewestby/builtwithelm/pull/15#issuecomment-164843585.


Added option to handle shirt size option

Description

This change is to support the handling of shirt size option of vRA, so that users can enter the shirt size value (combination of CPU, RAM and Storage) of the desired VM they wish to provision, provided the blueprint they wish to provision has the shirt size option set up.
Issues Resolved

None. This is just an enhancement
Check List

[Y] All tests pass.
[Y] All style checks pass.
[Y] Functionality includes testing.
[Y] Functionality has been documented in the README if applicable

Signed-off-by: Vinu Philip<EMAIL_ADDRESS>

Also password credential has been masked in Debug mode
Signed-off-by: Vinu Philip<EMAIL_ADDRESS>

Hi @vinuphilip can you recommit with a DCO. It looks like you added it as a github comment but it needs to be in the actual commit. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco for details.

hey @mwrock - i have again did a re-commit with minor changes to readme notes with DCO sign off in the commit message. Would it work

The DCO check is still failing. Thats probably because the original commit without the DCO is still in the PR.  That should do it.


Require external packages for libnvidia-egl-gbm/wayland/x11 ASAP (gh …

…issue#12, issue#13, issue#14)

require libnvidia-egl-gbm since Leap 15.5/sle15-sp5 (gh issue#12)
require libnvidia-egl-wayland since Leap 15.7/sle15-sp7 (gh issue#13)
require libnvidia-egl-gbm since Leap 15.7/sle15-sp7 (gh issue#14)

@scaronni-nvidia JFYI ...


Mstyp/scribblelens

Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
[ ] Did you read the contributor guideline?
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
Fixes # (issue).
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Similar to #2903, please see comment there: https://github.com/pytorch/fairseq/pull/2903#issuecomment-731650795

Oh gosh, so sorry to spam you. I'll try to decouple the fork in github and be more careful!


Defer creation of Expectations

Given a parser whose hot part looks like this:
    val fieldName = Rfc7230.token.string
    val fieldValue = P.repSep0(Rfc5234.vchar.rep, P.charIn(" \t").rep).string.surroundedBy(Rfc7230.ows)
    val header = ((fieldName <* P.char(':')) ~ fieldValue).map {
      case (k, v) => Header.Raw(CIString(k), v)
    }
    val headers = (header <* P.string("\r\n")).rep0

CharIn.makeError is dominating the stack trace and allocations.  It is created at the end of each repetition, only to be nulled out and gc'ed if we've made any progress.
[info] Benchmark                                                         Mode  Cnt       Score       Error   Units
[info] Http1DecoderBench.http1Decoder                                   thrpt    5  194717.904 ± 27142.805   ops/s
[info] Http1DecoderBench.http1Decoder:·gc.alloc.rate                    thrpt    5    2375.264 ±   330.882  MB/sec
[info] Http1DecoderBench.http1Decoder:·gc.alloc.rate.norm               thrpt    5   13436.503 ±     0.524    B/op
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Eden_Space           thrpt    5    2378.683 ±   323.143  MB/sec
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Eden_Space.norm      thrpt    5   13456.252 ±   205.497    B/op
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Survivor_Space       thrpt    5       0.008 ±     0.004  MB/sec
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Survivor_Space.norm  thrpt    5       0.044 ±     0.019    B/op
[info] Http1DecoderBench.http1Decoder:·gc.count                         thrpt    5     508.000              counts
[info] Http1DecoderBench.http1Decoder:·gc.time                          thrpt    5     552.000                  ms
[info] Http1DecoderBench.http1Decoder:·stack                            thrpt              NaN                 ---

Here, we wrap every Chain[Expectation] in an Eval, so that the expectations can be created lazily.  Care must be taken not to close over mutable state, namely, state.offset.  We significantly increase speed and reduce garbage:
[info] Http1DecoderBench.http1Decoder                                   thrpt    5  353576.391 ± 39077.640   ops/s
[info] Http1DecoderBench.http1Decoder:·gc.alloc.rate                    thrpt    5    2293.983 ±   253.014  MB/sec
[info] Http1DecoderBench.http1Decoder:·gc.alloc.rate.norm               thrpt    5    7146.434 ±     0.264    B/op
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Eden_Space           thrpt    5    2294.376 ±   247.756  MB/sec
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Eden_Space.norm      thrpt    5    7147.791 ±    94.745    B/op
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Survivor_Space       thrpt    5       0.007 ±     0.002  MB/sec
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Survivor_Space.norm  thrpt    5       0.023 ±     0.006    B/op
[info] Http1DecoderBench.http1Decoder:·gc.count                         thrpt    5     494.000              counts
[info] Http1DecoderBench.http1Decoder:·gc.time                          thrpt    5     519.000                  ms
[info] Http1DecoderBench.http1Decoder:·stack                            thrpt              NaN                 ---

I'll work on cleaning up and providing a runnable benchmark, but wanted to get early feedback.
We might also make it leaner with simple thunks rather than an Eval that's always later.

The win looks really good and I'm definitely interested in merging when green and we sort out any mima issues.

Drat.  I was afraid stack safety would be an issue with the thunks.  I'll pause here and see if people agree with the problem before I pour more into the solution.

A thunk is slightly lighter than Eval, but not much more so, and Eval does indeed take care of stack safety.
Replacing Eval.later with Eval.always is marginally slower, but eliminates some allocations:
[info] Http1DecoderBench.http1Decoder                                   thrpt    5  337942.154 ± 42747.443   ops/s
[info] Http1DecoderBench.http1Decoder:·gc.alloc.rate                    thrpt    5    2072.398 ±   261.164  MB/sec
[info] Http1DecoderBench.http1Decoder:·gc.alloc.rate.norm               thrpt    5    6754.582 ±     0.565    B/op
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Eden_Space           thrpt    5    2075.145 ±   264.493  MB/sec
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Eden_Space.norm      thrpt    5    6763.527 ±   113.341    B/op
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Survivor_Space       thrpt    5       0.008 ±     0.003  MB/sec
[info] Http1DecoderBench.http1Decoder:·gc.churn.G1_Survivor_Space.norm  thrpt    5       0.025 ±     0.009    B/op
[info] Http1DecoderBench.http1Decoder:·gc.count                         thrpt    5     480.000              counts
[info] Http1DecoderBench.http1Decoder:·gc.time                          thrpt    5     520.000                  ms
[info] Http1DecoderBench.http1Decoder:·stack                            thrpt              NaN                 ---

I need my CPU back so I can't run a proper number of iterations right now, but looking good on the JSON:
bench/jmh:run -i 4 -wi 2 -f 1 -t 1 .*catsParseParse
Before, on 9e67814:
[info] Benchmark                   Mode  Cnt   Score    Error  Units
[info] BarBench.catsParseParse     avgt    4  ≈ 10⁻⁴           ms/op
[info] Bla25Bench.catsParseParse   avgt    4  36.105 ±  4.108  ms/op
[info] Qux2Bench.catsParseParse    avgt    4  10.878 ±  1.018  ms/op
[info] Ugh10kBench.catsParseParse  avgt    4  84.775 ±  4.723  ms/op

After, on 9561249:
[info] Benchmark                   Mode  Cnt   Score    Error  Units
[info] BarBench.catsParseParse     avgt    4  ≈ 10⁻⁴           ms/op
[info] Bla25Bench.catsParseParse   avgt    4  30.502 ±  1.736  ms/op
[info] Qux2Bench.catsParseParse    avgt    4   9.649 ±  1.508  ms/op
[info] Ugh10kBench.catsParseParse  avgt    4  76.212 ±  6.961  ms/op

Error on both:
[info] java.lang.RuntimeException: Error(256941,NonEmptyList(InRange(256941,,,,)))
[info] 	at scala.sys.package$.error(package.scala:27)
[info] 	at cats.parse.bench.JmhBenchmarks.catsParseParse(JsonBench.scala:47)
[info] 	at cats.parse.bench.jmh_generated.CountriesBench_catsParseParse_jmhTest.catsParseParse_avgt_jmhStub(CountriesBench_catsParseParse_jmhTest.java:190)
[info] 	at cats.parse.bench.jmh_generated.CountriesBench_catsParseParse_jmhTest.catsParseParse_AverageTime(CountriesBench_catsParseParse_jmhTest.java:152)


Revert "[flutter_tools] reland: fold process resolution logic into the flutter tool"

Reverts flutter/flutter#67957
This still isn't correct, sorry should have tested more.
which/where only work for an executable name on windows, not a path.
TBR @zanderso

lgtm


docker installation instruction updates

Updates

clarity of language in the docker.md introduction page, additional reference links
unified voice and reduced redundancy in docker-compose instructions
proposed page name change for clarity/ease of use: Running Fidesctl in Docker -> Running Fidesctl with Docker Compose

I did some additional editing on this pass to cut down the uses of "we," "our," etc, and draw the tone of the installation article more in line with modern style guide recommendations for second-person instructions with clear directions.


Avoid downloads when file exists and matches

Is your feature request related to a problem? Please describe.
When pulling files from Artifactory, they are pulled every time, even if "force_overwrite" is set to false. When a file pull is very large, this can greatly slow down things unnecessarily in the case that a matching local file already exists and matches the remote. In v2.3.1 the artifactory provider did not download every time. It changed to download regardless of whether remote and local files matched on commit eef9a5cd96c10665b5fe8e50337f7979757d9b59.
Describe the solution you'd like
If the remote file and the local file have matching checksums, and "force_overwrite" is set to "false", then do not download the remote file.
Please let me know if you would accept a pull-request to re-enable the ability to skip downloads when the remote file matches the local file.

@mscottnelson we very much welcome PR from our community.

This should have been working - @alexhung if you check history for this code I made some changes - you can check them out and see if you can identify the issue (or just revert)


someone to go full genius and get this to support firefox

Yeah I need someone to help get this extension to function correctly on firefox. I've been trying but I think i'm too dumb.
What I've seen so far:

Redirecting is not working (declartiveNetRequest issue) even though the rule is being applied.
The listeners don't seem to be working either (runtime.onMessage and webRequest.onCompleted)
If anyone can fix this I'd appreciate it so much lol
I'd like to keep using this framework, since it feels really convenient. But if you can get this working by reverting back to no framework, we can work with it at least.

To get this working on firefox do these steps:
Add modify the manifest part of package.json to this:
"manifest": {
    "browser_specific_settings": {
      "gecko": {
        "id": "{743ff2c1-74c2-4384-a218-2c33d6a765a5}"
      }
    },
    "permissions": [
      "declarativeNetRequest",
      "declarativeNetRequestFeedback",
      "storage",
      "tabs",
      "activeTab",
      "alarms",
      "webRequest",
      "declarativeNetRequestWithHostAccess"
    ],
    "web_accessible_resources": [
      {
        "resources": [
          "leetcode-problems/*"
        ],
        "matches": [
          "https://www.plasmo.com/*"
        ]
      }
    ],
    "host_permissions": [
      "https://*/*"
    ]
  }

In your firefox browser type in for the url: about:debugging
Click the "This Firefox" button
You'll see the temporary extension area.
Now in the code in your terminal run "pnpm run dev --target=firefox-mv3"
You'll see a build folder with a folder called "firefox-mv3-dev"
In your Firefox browser click "Load Temporary Add-on" and select any file from the firefox-mv3-dev
The extension should be applied.

Wish I could help, but i can't get the firefox build to work lol, have you tried putting "webRequestBlocking" in instead of "declarativeNetRequestWithHostAccess"?

whoops I forgot to close this issue, I actually figured out the problem. The extension worked the whole time, but apparently whenever you develop in Firefox you don't get extension permissions automatically like chrome. You have to manually enable them, and the extension needs these permissions to work


Add ability to specify options for the jsx subtask.

Description
This PR adds the ability to pass options to the jsx subtask that will get passed to react's transform function (documented here: https://github.com/sindresorhus/gulp-react#reactoptions)
It also adds a default options object that is used if one is not specified:
options = {
    stripTypes: true
};

Testing
Could download the Flow examples and try compiling them with wGulp. @dominicfrost-wf might be in a good place to do this quickly
@trentgrover-wf
@evanweible-wf
FYI @shanesizer-wf

	When this pull is merged I will not be able to function
	properly because no ticket is included in the title.

Last updated on Monday, January 12 05:29 PM CST

+1

+10 it works!! and +1 on defaulting stripTypes  to true

+1

@jayudey-wf @charliekump-wf ready for merge and 0.7.5 release

QA Resource Approval: +10

[ ] Testing instruction
[ ] Dev +1's
[ ] Dev/QA +10 with detail of what was tested
examples worked per Dominic Frost
[ ] Unit test created/updated
[ ] All unit tests pass

Merging into master. @charliekump-wf


Add variant for salaries and benefits A/B test

Trello card
Trello-4203
Context
We need to add a separate page under a new path with identical content so we can configure the A/B test.
Changes proposed in this pull request

Add variant for salaries and benefits A/B test

Guidance to review

@ethax-ross This looks fine to me but one of the build tests failed


Release Event Hubs January update for Java

This issue is to track the work in the Event Hubs library for the January update

@conniey, @srnagar Please move the pending items to #8082 and close this issue as we have now shipped the Event Hubs library. Please provide links to the released maven packages below


Complete Release Workflow

This is a workflow that will release all PASS modules.  It builds on the approach in the Release Java Modules.  The workflow requires a Release Version and Next dev version as input.  In order to run the workflow, a PAT needs to be set like instructed in the Release Java Workflow instructions.
I tried to make the workflow so that is can be re-run in the case where one of the steps fails for some reason.  As one can see, there are several steps where failure can occur, so the workflow may not be re-runnable in all failure scenarios, but should cover the most common cases.
I will work on updating the release documentation once this workflow is reviewed/merged.
Note, I had to merge an initial version of pass-complete-release.yml to main so I could run tests, thus the diff in the file instead of being new.

I'll work on squashing some of these commits since there are so many.

@markpatton I was looking around at the repos and actions, and I think for the Snapshot steps in this workflow, the only thing that we really have to do is update the version to dev next version and push the commit.  The building/publishing/docker image pushing all look to happen already in existing workflows in each repo.  I think I can remove all those steps from the complete workflow, right?

@markpatton I was looking around at the repos and actions, and I think for the Snapshot steps in this workflow, the only thing that we really have to do is update the version to dev next version and push the commit. The building/publishing/docker image pushing all look to happen already in existing workflows in each repo. I think I can remove all those steps from the complete workflow, right?

@markpatton actually, looking at this closer, there is an issue with how I have commits pushing for the release and snapshot for each repo.  Each push will start the main push trigger workflow in the respective repo, which we don't want for the release version I think.  I will have to think about this a bit.  Maybe we can chat on Thursday when my conference is done.

@markpatton actually, looking at this closer, there is an issue with how I have commits pushing for the release and snapshot for each repo. Each push will start the main push trigger workflow in the respective repo, which we don't want for the release version I think. I will have to think about this a bit. Maybe we can chat on Thursday when my conference is done

@markpatton sorry for the multiple comments, but I think I can clean this up by using a tag-ignore in the on push event in each of the workflows in the repos that are triggered on main pushes.  I will change the complete workflow to include a tag that will cause the repo push workflows to ignore the pushes that come from the complete release workflow.

Closing while I make these changes: https://github.com/eclipse-pass/main/pull/980#issuecomment-2111148786

@markpatton sorry for the multiple comments, but I think I can clean this up by using a tag-ignore in the on push event in each of the workflows in the repos that are triggered on main pushes. I will change the complete workflow to include a tag that will cause the repo push workflows to ignore the pushes that come from the complete release workflow.

@markpatton I have made the following changes to address this issue:

Added a tag command in the Snapshot commits that will tag each repo for the initial Snapshot version with <dev-next-version>-init.  This tag will be pushed to the repo origin.
Opened the 5 linked PRs. Each PR is updating the workflows that trigger from pushes to main so that they don't trigger if the commit has a tag.  The only commits that have tags now are when we do releases.

Once the 5 PRs have been merged, I will run another RC release test.


esify should not try to convert .js.erb files into ASTs

In global-reference-to-import, findDeclaringFile is returning .js.erb files.  findNamedExports then attempts to parse those with jscodeshift.
e.g.,:

admin/modules/mixins/date_handler.coffee contains a reference to Shopify.DateRangeDb.
DateRangeDb is exposed by admin/date_range_db.js.erb

Affects 50+ files in admin; probably many more outside that.

@justinthec the .js.erb files are providing useful context, so we can't just ignore them.  I think you created a proof of concept for non-jscodeshift export discovery, so maybe we can just drop that in to fix this?

I could switch the searching strategy based on the file extension. .js --> AST, .js.erb --> ag regex search. Are there any other js file extensions to know about?

I'd assume that any file type within app/assets/javascripts has the potential to show up in search results (sidenote: which probably means its pointlessly sifting through a bunch of node_modules folders).
I'm not sure if two code paths for this is worth it.  Was the difference in performance that large?

The difference was about 50 ms

If the code is already written, then let's go with two code paths.

Can we get this fixed soon?  It's not going to be a good experience for anyone trying to use esify right now.

I will get the PR up tonight.


Compliance tool failed

How does the compliance tool work exactly? I tried to validate some same valid aasx.json files with the compliance tool, but It always shows the test failed.
The only time test was successful was when I ran the same files generated from examples that are already inside this repo.

The compliance tool checks the compliance to the meta-model, based on our implementation If the check fails, most likely the .aasx-files you tried are not valid, the output of the compliance tool should point you in the direction of where the issue with the files is. If you think, there is a bug in our implementation, please specify what you encountered.

For example, I have a sample JSON file that is valid as json aasx and can be loaded in another aasx server as well.
But when I check with the compliance tool it fails.
Check the file in the attachment
FestoDemoAAS.zip

When I run the compliance tool on your provided AAS, it shows the following:
Validate file against official json schema
Status.FAILED
	<LogRecord: compliance_check, 40, <redacted>\venv\lib\site-packages\basyx\aas\compliance_tool\compliance_check_json.py, 103, "'asset' is a required property

Failed validating 'required' in schema['properties']['assetAdministrationShells']['items']['allOf'][2]:
    {'properties': {'asset': {'$ref': '#/definitions/Reference'},
                    'conceptDictionaries': {'items': {'$ref': '#/definitions/ConceptDictionary'},
                                            'type': 'array'},
                    'derivedFrom': {'$ref': '#/definitions/Reference'},
                    'security': {'$ref': '#/definitions/Security'},
                    'submodels': {'items': {'$ref': '#/definitions/Reference'},
                                  'type': 'array'},
                    'views': {'items': {'$ref': '#/definitions/View'},
                              'type': 'array'}},
     'required': ['asset']}

On instance['assetAdministrationShells'][0]:
    {'assetInformation': {'assetKind': 'Instance',
                          'billOfMaterial': [{'keys': [{'idType': 'Iri',
                                                        'type': 'Submodel',
                                                        'value': 'http://acplt.org/Submodels/Assets/TestAsset/BillOfMaterial'}]}],
                          'globalAssetId': {'keys': [{'idType': 'Iri',
                                                      'type': 'Asset',
                                                      'value': 'https://acplt.org/Test_Asset'}]}},
     'idShort': 'FestoDemoAAS',
     'identification': {'id': 'https://example.com/ids/aas/3235_8090_6012_8932',
                        'idType': 'Iri'},
     'modelType': {'name': 'AssetAdministrationShell'},
     'submodels': [{'keys': [{'idType': 'Iri',
                              'type': 'Submodel',
                              'value': 'https://example.com/ids/sm/1145_8090_6012_5097'}]},
                   {'keys': [{'idType': 'Iri',
                              'type': 'Submodel',
                              'value': 'https://example.com/ids/sm/4445_8090_6012_7409'}]},
                   {'keys': [{'idType': 'Iri',
                              'type': 'Submodel',
                              'value': 'https://example.com/ids/sm/2110_9090_6012_8448'}]},
                   {'keys': [{'idType': 'Iri',
                              'type': 'Submodel',
                              'value': 'https://example.com/ids/sm/5410_9090_6012_0950'}]},
                   {'keys': [{'idType': 'Iri',
                              'type': 'Submodel',
                              'value': 'https://example.com/ids/sm/2402_1191_1022_1090'}]}]}">

This tells us, that the attribute asset is missing in the AAS FestoDemoAAS with ID https://example.com/ids/aas/3235_8090_6012_8932.
According to the specification Details of the Asset Administration Shell Part 1 v2.0.1 page 58, this attribute is mandatory:

Because of that, the compliance check fails.

I think the file I provided uses v3
Details of the Asset Administration Shell Part 1 v3
Does this means that compliance tool will only check the compliance with version 2 ?

The compliance tool uses the SDK, thus it only checks compliance with the version the SDK implements. The main branch currently implements DotAAS v2.0.1, a version for V3.0RC02 is currently in preparation, see https://github.com/eclipse-basyx/basyx-python-sdk/pull/18.


First line of terminal isn't really visible when editor is zoomed in

VSCode Version: 1.8.1
OS Version: Ubuntu 16.10

Steps to Reproduce:

Zoom in by pressing CTRL & +
Open integrated terminal -> the first line isn't really shown, see attached screenshot

Fixed this today, should be in tomorrow's Insiders build


Chat - New messages not showing up in conversation when clicking on bold text in LHN offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to http://staging.new.expensify.com/
Log in any account
Receive a new message from a user
Turn off internet
Tap on bold chat in LHN

Expected Result:
The new messages must be displayed in the conversation history
Actual Result:
When user in offline mode, tap on bold chat in LHN, the new messages are not displayed in the conversation history
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/efb442bb-fc9e-40a2-9387-a75f40dd56ec
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Thanks @bernhardoj 🏆
Closing, dupe of https://github.com/Expensify/App/issues/21000#issuecomment-1607975714
and...

Yes, in that case I think we should just close this issue and mention that it will be solved by ongoing back-end refactors. Thanks so much for the convo!


Localize "Container Environment" page to Italian

I would like to have the "Container Environment" page to be translated into Italian
page https://kubernetes.io/docs/concepts/containers/container-environment/
/language it
/priority important-soon

/assign
/lifecycle active


chore: ignore coverage from index and types files

Codecov Report
Base: 96.36% // Head: 96.79% // Increases project coverage by +0.43% :tada:

Coverage data is based on head (b16a0a5) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4257      +/-   ##
==========================================
+ Coverage   96.36%   96.79%   +0.43%
==========================================
  Files          45       86      +41
  Lines        2281     3274     +993
  Branches      640      882     +242
==========================================
+ Hits         2198     3169     +971
- Misses         80      103      +23
+ Partials        3        2       -1

Impacted Files
Coverage Δ

src/react/QueryClientProvider.tsx

src/react/setBatchUpdatesFn.ts

src/devtools/utils.ts

src/core/query.ts

src/core/queryCache.ts

src/core/mutationCache.ts

src/react/useMutation.ts

src/devtools/Logo.tsx

src/core/queryObserver.ts

src/devtools/theme.tsx

... and 121 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


boards: fvp_base_revc_2xaemv8a: permit running Zephyr at EL1NS

It may be needed to run Zephyr at EL1NS level with CONFIG_ARMV8_A_NS
In order to run at EL1NS, you'll need a proper Firmware loaded in the FVP model
to run Zephyr at non-secure EL3.
The ARM TF-A for FVP can used to run Zephyr as preloaded BL33.
This adds the necessary cmake scripts to load the TF-A binaries and
load Zephyr as preloaded BL33 payload.
Signed-off-by: Neil Armstrong<EMAIL_ADDRESS>

Maybe it's better to introduce TF-A as a Zephyr module?

It would be great in order to run FVP tests automatically in EL1NS.
It will benefit for #37506 since QEmu is not ready yet, but FVP only needs these TF-A binaries to run the test successfully

Maybe it's better to introduce TF-A as a Zephyr module?

Actually trusted-firmware-m is already a Zephyr module, so trusted-firmware-a could be

@carlocaione I still have an open comment here, with a reasoning why the environment variable as minimum should go to the CMake cache.
https://github.com/zephyrproject-rtos/zephyr/pull/37603#discussion_r695238927

@carlocaione I still have an open comment here, with a reasoning why the environment variable as minimum should go to the CMake cache.
#37603 (comment)

@tejlmand implemented and tested it works on multiple terminals


Implement special cases for section_tortuosity calculation.

Sections with less than 2 points have tortuosity 1.

resolves #503.

Thanks!


chore: release v0.6.3

:robot: I have created a release beep boop
0.6.3 (2023-11-08)
What's Changed

chore(docs): improve readability of README.md by @coffeebeats in https://github.com/coffeebeats/gdenv/pull/146
chore: update github.com/charmbracelet/log to v0.3.0 by @coffeebeats in https://github.com/coffeebeats/gdenv/pull/148
chore: run go mod tidy by @coffeebeats in https://github.com/coffeebeats/gdenv/pull/150

Full Changelog: https://github.com/coffeebeats/gdenv/compare/v0.6.2...v0.6.3

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/coffeebeats/gdenv/releases/tag/v0.6.3 :sunflower:


Advanced training in prep for AWS Ops improvements planning

Describe the Issue
In order to properly move forward more training is needed on AWS and GCP.  This is personal training but this Ops training can be applied for PA team as well if prioritized
Additional Context
Plan is needed for team to ramp up knowledge here, set priorities and put plans in place to create the things we do not have in the Operations space so that we can more formally solidify the BC Gov AWS Public Cloud service offering as an Enterprise-level service.  This ticket specifically address work needed around our AWS platform services
Acceptance Criteria

Initiate first training sessions for AWS Ops training series (ie. 1/4 of online sessions - Later tickets for the remaining parts)
Summarize advanced Ops recommendations and have discussion with AWS
Create further tickets for Ops planning around this and any other possible investigations or training needed

.
.
.
.
.
.
.
.
.
.
.
Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
It should be testable with no room for interpretation
It should be either “pass” or “fail”
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

AWS training for course that was available through them and Global knowledge (architect course).  Was completed.  Closing


Bugfix fix coredump cause by fmt::format param malformt

Problem summary
fix coredump cause by fmt::format param malformt
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[x] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[x] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[x] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM


[DOCS] Add blogs to site

Change Logs
blogs update for the site
Impact
none. Site updates
Risk level (write none, low medium or high below)
none
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

Tested locally. The redirection works fine. Images are usually visible only after the merging of PR!


Update docs/getting-started/installing-core-linux.rst with latest versions and fix typo

We should update the installing-core-linux document with the latest versions of the runtime or make it version agnostic like currently shown on http://dotnet.github.io/core/getting-started/. Also found a typo in the instructions on running the app.

Need to wait until Beta 8 comes out


Is it only for users?

I don't see urls for admin to reply to users about the tickets.

You can reply to tickets using the inline admin if you click on any ticket. See screenshot below. Hope this answers your question.

Please reopen if the issue should not be resolved, thanks!


Can't get vectorStoreTest with MongoDBAtlasVectorStore to work locally

Bug description
I am having trouble with MongoDBAtlasVectorStore. Basically when I copy and paste this into my project because the similarity search isn't working...
List<Document> ds = List.of(
                new Document(
                        "Spring AI rocks!! Spring AI rocks!! Spring AI rocks!! Spring AI rocks!! Spring AI rocks!!",
                        Collections.singletonMap("meta1", "meta1")),
                new Document("Hello World Hello World Hello World Hello World Hello World Hello World Hello World"),
                new Document(
                        "Great Depression Great Depression Great Depression Great Depression Great Depression Great Depression",
                        Collections.singletonMap("meta2", "meta2")));

        vectorStore.add(ds);
        Thread.sleep(25000); // Await a second for the document to be indexed

        List<Document> results = vectorStore.similaritySearch(SearchRequest.query("Great").withTopK(1));

The result I see is not correct...

Environment
Java 23
Spring AI 1.0.0-M3
Steps to reproduce
See repo here. You can add the code above to that and see it doesn't work
Expected behavior
I would expect it to return a document as it does in the test.
Minimal Complete Reproducible example
See above more available here

Got debugging into source working now trying to understand why the query is returning 0 records. Also running the build locally with mvn clean install to make sure it isn't an environment issue.

It seems that the way the vector store is working isn't allowing me to aggregate properly. I added a script
https://github.com/jrgleason/spring-ai-example/blob/ADD_MQTT_SUPPORT/app/debug/mongodb/test-count.js
That seems to confirm this can someone see what I am doing wring with my config?


Cannot make user who "joined" collection project via mobile an admin of said project

If someone "joins" a collection project via mobile (so far I've tested only iOS but I imagine it works for both platforms), then they cannot be made an admin of said project. This error is returned:

If one then goes to the project's webpage and clicks "unfollow" I think they still can't be added as an admin.
If one leaves a project via mobile, they can be added as an admin.

I think this is probably pending the discussion on what to do about joining / following projects.

This should actually be fixed now, if you want to check @tiwane . But definitely more to talk about next week

Fixed in d29242e


Shield speed penalties should be reduced for characters who meet their strength requirements

Shields have statistics that follow the same rules as armor: Price, Speed Penalty, and Bulk. See page 274 for the rules for those statistics.

https://2e.aonprd.com/Rules.aspx?ID=213

While wearing a suit of armor, you take the penalty listed in this entry to your Speed, as well as to any other movement types you have, such as a climb Speed or swim Speed, to a minimum Speed of 5 feet. If you meet the armor’s Strength threshold (see below), you reduce the penalty by 5 feet.

https://2e.aonprd.com/Rules.aspx?ID=206
So, for example, this means that a Fortress Shield's speed penalty of 10 ft should be reduced to a penalty of 5 ft when the shield is used by someone with 18 strength.

Aw, no, nevermind... with a strict reading of the rules as written, this doesn't work because the shields have no Strength threshold at all.  Even the Hefty 14 isn't an actual strength threshold.  This means that Tower Shield and Fortress Shield are special cases of armor/shield that have a speed penalty value but don't have a strength threshold value... which feels a bit like a designer oversight, but does mean that RAW there's no normal way to reduce their speed penalties.


Rename modid.mixins.json to platos.mixins.json

That would not be conflicts between mods

yup I should have already done this.... dont use any mixins currently but good spot!


Adds a switch to control cleanup behavior after E2E test

Description
It often is hard to analyze failing E2E tests when the environment they failed in is already cleaned up. This PR adds a switch that allows fine tuning cleanup behavior via an environment variable:
TEST_ENV_CLEANUP

always - cleanup after each test
never - never clean up
onSuccess - only cleanup if test was successful

How can this be tested?

Prepare an environment to run E2E tests in
set said environment variable to a value of you choice and run E2E tests
observe if cleanup has happened the way you expected by checking resources on the test cluster

Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly
[x] I have read and understood the contribution guidelines

Feature is no longer needed, at least in the intended way. Back to the drawing board


Add presto connector for H3

More a question than an issue, are you planning to release a presto connector for H3, similar to the bing tiles currently in presto/geospatial ?
https://github.com/prestodb/presto/blob/master/presto-docs/src/main/sphinx/functions/geospatial.rst

See https://github.com/foursquare/h3-presto


fix: In development mode, warns if user tries to Vue.set a property t…

…hat already exists.
In development mode, warns if user tries to Vue.set a property that already exists. Issue reported
in #8129. Codepen demonstrating the issue available at
https://codepen.io/chrisvfritz/pen/rvzgBR?editors=1010
fix #8129

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[ ] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] It's submitted to the dev branch for v2.x (or to a previous version branch), not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
[ ] New/updated tests are included

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva I'm trying to add a test for this, but struggling a bit.  Here is a codepen of a test that I expect should pass for this.  https://codepen.io/bigtunacan/pen/rvGgoB?editors=0010#

I'm trying to add a test for this, but struggling a bit.

Could you provide more information on where you struggled? For example, are you not sure where the test should go, or did running the tests not work, etc?

@chrisvfritz I placed the test in test/unit/modules/observer/observer.spec.js.
The test fails with the generic message FAILED Observer Cannot enable reactivity on a property that is already defined
So then I ran the tests against Chrome with inspector to see what is happening; the warning is getting hit in test the same as in dev, but yet it fails in my test (which I also linked in the codepen above).
I could also push my changes onto this pull request, but I didn't necessarily want to do that when I know the test isn't working yet.

@bigtunacan You may have to wrap your expectation in waitForUpdate (like in this test).

Can you upload the exact code you're trying? It's OK if the test is failing - we'll squash when we merge anyway.

@chrisvfritz Ok; I've updated the PR

@posva I believe this should be ready to merge now.

@posva Just curious since it's been sitting for awhile and shows as "Changes requested".  Are you still waiting on anything from me to merge this in?  I thought everything was good now?

I think it makes more sense to convert a property to a reactive one if it's not, which should be the intention in most cases anyways.

I think it makes more sense to convert a property to a reactive one if it's not, which should be the intention in most cases anyways.

I think the issue is that someone may add a property with standard assignment after the fact as shown in this codepen from the original issue https://codepen.io/chrisvfritz/pen/rvzgBR?editors=1010
Most likely this is not what the person meant to do so it would be good to provide a warning in dev environments.
It could be changed to set the property to reactive, but that would seem inconsistent as you would being with a property that is not reactive and then at some point in time it becomes reactive.

I agree with you @bigtunacan. We just had an internal discussion about this in the Vue team and never came up with any valid use cases for making an unreactive property reactive - and the ability just opens a subtle hole for reactivity bugs. So a warning does seem ideal here.


Can't write bool that's nulled by concatenation

Hi,
I tried to write an adata which is a result of outer concat and I get the following error.
TypeError: Can't implicitly convert non-string objects to strings

Above error raised while writing key 'bool' of  to /

Reproducible code snippet:
from anndata.tests.helpers import gen_adata
import pandas as pd
import anndata as ad

a = gen_adata((5, 5), obsm_types=(pd.DataFrame,))
b = gen_adata((3, 5), obsm_types=(pd.DataFrame,))

del b.obsm["df"]

# del a.obsm["df"]["bool"] # this works fine

adatas = ad.concat({"a": a, "b": b}, join="outer", label="group")

adatas.write("test.h5ad")

Is this a bug or should we not write nulled bools like this?

I think we should create a pandas boolean column during creation, so that we can handle the null values.

Solved with #992


Update Blog Link

Major Releases and CU releases appear on the Azure Update feed more than the legacy MSDN feed.

@ckittel : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Deserializing special double, float values

Hi! I have json from external to me system like this:
Source/destination JSON
{
  "test1":4.94065645841247E-324,
  "test2":1.79769313486232E+308,
  "test3":-1.79769313486232E+308,
  "test4":не число,
  "test5":Infinity,
  "test6":-Infinity
}

Expected behavior
I'm expect csharp special values (Nan, PositiveInfinity, NegativeInfinity, etc), or simpler double/float numbers for float and double after deserialization
Actual behavior
Newtonsoft.Json.JsonReaderException: Input string '1.79769313486232E+308' is not a valid number. Path '1.events.pl[0].data.test%20key11', line 1, position 2631.
at Newtonsoft.Json.JsonTextReader.ParseNumber (Newtonsoft.Json.ReadType readType) [0x005b7] in <2c34b75de3fc4b43babbd260b14ffeeb>:0
at Newtonsoft.Json.JsonTextReader.ParseValue () [0x002a3] in <2c34b75de3fc4b43babbd260b14ffeeb>:0
at Newtonsoft.Json.JsonTextReader.Read () [0x0004c] in <2c34b75de3fc4b43babbd260b14ffeeb>:0
JsonConvert.DeserializeObject(json, new JsonSerializerSettings {
                        Culture = CultureInfo.InvariantCulture,
                        NullValueHandling = NullValueHandling.Include,
                        FloatFormatHandling = FloatFormatHandling.String,
                        FloatParseHandling = FloatParseHandling.Double
                    });

FloatFormatHandling, FloatParseHandling - don't help me. Crash will be independently

I have the same issue.
Any news ?

After checking, actually double.MaxValue is 1.7976931348623157E+308
So 1.79769313486232E+308 is not a valid double.
Issue is in the external system.

For those who stumble upon this, an explanation of why this is the way it is:
1.79769313486232E+308 is a common 15-digit rounding of the 17-digit Max Value of a Double, 1.7976931348623157E+308.
Why is this a common problem?
By default, double.ToString() returns 15 digits of precision. Because of this, double.MaxValue.ToString() results in a return string of "1.79769313486232E+308". This is not a valid double, but it is the 15-digit rounded version of double.MaxValue. You must specify that you want a round trip capable result if you want a truly safe string representation of a double. You do this with the "R" format string: double.MaxValue.ToString("R"). It is very odd, but here's the result of two lines of round trip parsing:
double.Parse(double.MaxValue.ToString()) // Throws an exception
double.Parse(double.MaxValue.ToString("R")) // Executes fine and returns double.MaxValue
So the short answer...the value you're using isn't a valid double. It's up to you to manually account for those edge cases or prevent them from forming by preemptively using the "R" format string on floating point values.

in my case bug really placed in external system (but developed in our company). So we fixed him as @daveforjc posted (but many times ago).
But i think that not anytime exists ability for fix like this and lib must have option for process bad data


Move pinholes pkg and rename it to "failsaferules"

I needed to update the module name in order to import the allowrules pkg in the api pkg.

/lgtm
/approve


[Feature]: Only owner can change gloabal

Description
I had a player who didn't quite understand what global meant make every village they came across a global waystone. This flooded everyone's waystone menu with randomly generated waystones. They thought they needed to be global in able to teleport to them.
Describe the solution you would like
Two solutions: 1) make it so villager waystones can't be made global or 2) make it so only the owner can make the global. (With OP override.)
Anything else?
No response

There's already a config option for that. Check the wiki

Oh weird, my config in this pack doesn't have that. Mine only has "can_players_toggle_global_mode": true Guessing the pack dev is using an old config, sorry! Will regen and change it then, thank you!

Hmm, what version of the mod do you have?

3.1.5, regenerating the config worked. It was probably just a really old config, as the pack is pretty old.


Matthias comments on intro

Added Introduction to HIP with feedback from Matthias.

Closed in favor of PR #3558


2 factor authentication error.

I'm getting an error '
An error occurred

No valid client certificate found in the request. No valid certificates found in the user's certificate store. Please try again choosing a different authentication method.

when attempting to login with an account that has 2 factor authentication enabled.
Steps to reproduce:

Build and run this sample. (active-directory-dotnet-native-uwp-v2)
Click 'Call Microsoft Graph API'
Login with account that has 2 factor authentication enabled (an @Microsoft.com account for example).
Click 'Sign in with PIN or smartcard'
A message about a pop up is briefly displayed. Followed by the error mentioned above.

How can I login using my 2 factor PIN or certificate?

This is a limitation of WAB on the UWP platform.
the workaround is to select "signin with alternate methods" (other than the PIN). The phone authentication works.


Bulk upsert with pk fields

Hi,
thanks for django-manager-utils  and query-builder: both have a very nice, clean API and are very helpful!
I've come across a weird case where I have a custom (CharField) primary key and want to do a (postgres) native bulk_upsert on that. That isn't currently possible because of this line in querybuilder/query.py:
all_fields = [field for field in ModelClass._meta.fields if field.column != pk_name]
(https://github.com/ambitioninc/django-query-builder/blob/develop/querybuilder/query.py#L1198)
Is there a specific reasons why PKs aren't allowed here? Maybe because of some implementation detail of AutoFields? From some cursory testing, bulk upserts work just fine with custom PKs. I don't have a complete demonstration case, but it could look something like this:
class PersonModel(models.Model):
    name = models.CharField(max_length=40, primary_key=True)

bulk_upsert(User.objects.all(),
    [User(name=str(i)) for i in range(100)],
    ['name'],
    native=True)

After some more testing, it appears that the bulk upsert would only pick up existing rows but fail on new ones ... I guess non-integer PKs aren't supported by postgres after all.

@trifle the latest version of querybuilder (0.14.1 #81 ) addresses the issue of upserting AutoField keys, so I am going to close this issue. If this doesn't solve the problem you are running into, feel free to reopen or make another issue. Thanks!


Running locally didn't work for me

Hello Anthony,
I followed the instructions on your blog and I couldn't log in locally.  When I published it and tried to login it worked.
After clicking the login page (https://localhost:5001/login-providers) and clicking the Sign in with Github link it returns to https://localhost:5001/.auth/login/github and says Sorry, there's nothing at this address.
Here's my Blazor Azure Static WebApp GitHub page.
Anyway, thanks for the blog.  Looking forward to when Azure Static Web Apps (ASWA) will have native support for Blazor and also when ASWA supports Azure Function using c#.
Thanks
John Marsing

It only works when deployed. There isn’t a great way to test auth locally right now. C# functions as well as native building of Blazor apps are coming soon. Being able to use auth locally is going to be a bit further out.

thanks,


[Bug report] fail to run in msys2 & cygwin shell on windows: spawn git ENOENT

✅ Checklist

[X] I am using the latest version
[X] I have searched FAQ

📄 System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
    Memory: 3.52 GB / 15.92 GB
  Binaries:
    Node: 20.16.0 - ~\.nvm\versions\node\v20.16.0\bin\node.EXE
    npm: 10.8.1 - ~\.nvm\versions\node\v20.16.0\bin\npm.CMD
    pnpm: 9.7.0 - ~\AppData\Local\pnpm\pnpm.EXE

🔎 Description
Concise Description
I can't run czg in msys2 environment: https://www.msys2.org/
Steps to reproduce
pacman -S --noconfirm git
npm i -g czg
czg -a

Screenshots or Screen Recording(if possible)
$ czg -a
<EMAIL_ADDRESS>
? Select the type of change that you're committing: feat:     A new feature
? Denote the SCOPE of this change (optional): empty
? Write a SHORT, IMPERATIVE tense description of the change:
 [Infinity more chars allowed]
 add new file
? Provide a LONGER description of the change (optional). Use "|" to break new line:

? List any BREAKING CHANGES (optional). Use "|" to break new line:

? Select the ISSUES type of change (optional): skip

###--------------------------------------------------------###
feat: :sparkles: add new file
###--------------------------------------------------------###

?  Yes
spawn git ENOENT

I think this might be the unix path used by git: https://www.msys2.org/docs/git/

Emmm. git command not found ?
Do you have the bin path of git in your Windows system environment variables? You should properly configure your local git environment before using this tool.

Hi @Zhengqbbb . Here's the result:
$ which git
/usr/bin/git

$ git --version
git version 2.46.0

$ node -e "require('child_process').spawn('git', ['-v'], { stdio: 'inherit' });"
git version 2.46.0

I guess the reason is not related by git path, but msys2 git uses cygwin which only support unix paths.

I think I should give up to use msys2 git: https://www.msys2.org/docs/git/
According to the official doc, this git will break down some git tools due to the confused by Unix paths.
And your project works properly with git-for-windows.
Thank you all the same.


401 handling

This PR adds an explicit interceptor for handling 401 errors in authen.js.
Whenever a 401 error is encountered the handler is called. The handler renders the login window and on successful login, fetches the new session and sets it in the authen module.
It also adds logic to subscribe to change in session. This is used in navbar to update the once the user has logged in.
Can be tested here https://dev.gpcrconsortium.org/~chirag/chaise/recordedit/#1/experiments:experiment

@jrchudy Yes thats right. Each app's run block subscribes to session changes. But the app doesn't calls getSession(). It is called by the navbar.

Cool. I was testing it out from a bunch of different login scenarios and it behaves properly.
It's just a different way to think about the problem in a somewhat less linear way. By less linear I guess I mean that you have to understand how each of these components communicate together to understand the whole flow. Merge when you are ready.


Create Col+ data package specs

see https://github.com/CatalogueOfLife/datapackage-specs

https://github.com/Sp2000/coldp


Documentation for commands

Hello!
Autocomplete in Zed is... very bad, but following problem can be part-solved by adding documentations for functions.

In plugin (eg: php-mode) config.json, section "builtins" now:
["function_name","function_name", "..."]
do:

{
    "function_name":"function_name(string $arg1, int $arg2, mixed $arg3) Function summary description"
}

Add support for documentation in app (don't know, where changes must be added)
In autocomplete box show:
function_name(string $arg1, int $arg2, mixed $arg3) Function summary description

For now, Zed is only one good offline editor, but it's functionality is very poor :(
I hope, that we can make Zed better.
Best regards, Nikita, backend PHP developer.

I am having trouble finding documentation also


Add UI tests

Xcode 7 introduced UI testing - use this to test scrolling and invalidation.

Can't do this as yet with the UI testing framework.


Make posting stickies asynchronous

We have stickies/create.js.rjs, but we're not submitting stickies remotely when we create them. The page actually redirects to localhost:3000/notices after a sticky is posted.

Ajax implemented in #147


Question about the minimum GPU memory requiments for single GPU and multi GPU training respectively

They are both around 23GB for nuScenes on 3090/4090, and maybe 15GB for SemanticKITTI/KITTI on 3090/4090.

got it


[Move parentage] diverticulosis, small-intestinal

Mondo term (ID and Label)
diverticulosis, small-intestinal
In general, diverticulosis is not a Mendelian disease and this entry relates to OMIM:223320 , which does not clearly document a case of Mendelian diverticulosis.
In general, diverticulosis can be seen as a feature of a number of genetic diseases (and for this reason it is an HPO term). It is also correct to consider diverticulosis as a disease entity. The actual etiologies are not clear but low-fiber diet is a risk factor.
I would suggest that digestive system disorder is a better parent term.
@ahamosh
Reason for deprecation
Suggested term to consider
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

Totally.  Diverticulosis is not Mendelian and is a digestive disease.


Submariner is not working for LKE

I have create 3 clusters in Linode / LKE (1) hub cluster for broker, (2) us-east and (3) us-west cluster. I have collected the output of the following command in the git repo below:
calicoctl get ippools -o wide --allow-version-mismatch

subctl diagnose all
subctl show all
subctl gather

Logs: https://github.com/tamalsaha/lke-submariner
Can you please help me make this work? Thanks a lot!

I think we might have found the source of the issue from Yossi's comment below:
https://kubernetes.slack.com/archives/C010RJV694M/p1684767007974559?thread_ts=1684727924.394349&cid=C010RJV694M
I see that subariner does not discover the podCIDR correctly in my case.

https://github.com/submariner-io/submariner-operator/blob/devel/pkg/discovery/network/calico.go#L53
https://github.com/submariner-io/submariner-operator/blob/devel/pkg/discovery/network/generic.go#L54
https://github.com/submariner-io/submariner-operator/blob/devel/pkg/discovery/network/generic.go#L155-L172

findPodIPRangeKubeController does not work for me. Because
$ k get pods -n kube-system --show-labels

NAME                                       READY   STATUS    RESTARTS   AGE     LABELS
calico-kube-controllers-689746b4fc-zxmcb   1/1     Running   0          4h6m    k8s-app=calico-kube-controllers,pod-template-hash=689746b4fc
calico-node-7b64f                          1/1     Running   0          4h6m    controller-revision-hash=7cf99d9574,k8s-app=calico-node,pod-template-generation=1
calico-node-dv5hn                          1/1     Running   0          4h6m    controller-revision-hash=7cf99d9574,k8s-app=calico-node,pod-template-generation=1
calico-node-xvfz7                          1/1     Running   0          4h5m    controller-revision-hash=7cf99d9574,k8s-app=calico-node,pod-template-generation=1
coredns-75fd9f59f7-74j6p                   1/1     Running   0          4h6m    k8s-app=kube-dns,pod-template-hash=75fd9f59f7
coredns-75fd9f59f7-rw28c                   1/1     Running   0          4h6m    k8s-app=kube-dns,pod-template-hash=75fd9f59f7
csi-linode-controller-0                    4/4     Running   0          4h6m    app=csi-linode-controller,controller-revision-hash=csi-linode-controller-857df897b9,role=csi-linode,statefulset.kubernetes.io/pod-name=csi-linode-controller-0
csi-linode-node-8p5r4                      2/2     Running   0          4h6m    app=csi-linode-node,controller-revision-hash=d59df455b,pod-template-generation=1,role=csi-linode
csi-linode-node-954m7                      2/2     Running   0          4h5m    app=csi-linode-node,controller-revision-hash=d59df455b,pod-template-generation=1,role=csi-linode
csi-linode-node-xmtgr                      2/2     Running   0          4h6m    app=csi-linode-node,controller-revision-hash=d59df455b,pod-template-generation=1,role=csi-linode
kube-proxy-kpkbk                           1/1     Running   0          4h6m    controller-revision-hash=7fc48f5466,k8s-app=kube-proxy,pod-template-generation=1
kube-proxy-wtczf                           1/1     Running   0          4h6m    controller-revision-hash=7fc48f5466,k8s-app=kube-proxy,pod-template-generation=1
kube-proxy-xh2p5                           1/1     Running   0          4h5m    controller-revision-hash=7fc48f5466,k8s-app=kube-proxy,pod-template-generation=1
root-ssh-manager-7gplb                     1/1     Running   0          3h10m   app=root-ssh-manager,controller-revision-hash=5446488d7b,pod-template-generation=1
root-ssh-manager-gqqfj                     1/1     Running   0          3h10m   app=root-ssh-manager,controller-revision-hash=5446488d7b,pod-template-generation=1
root-ssh-manager-hqfms                     1/1     Running   0          3h10m   app=root-ssh-manager,controller-revision-hash=5446488d7b,pod-template-generation=1

LKE is managed cluster and kube-controller-manager is invisble.
Then submariner tries to find podCIDR range from the kube-proxy pod's command[]. There are 2 problems here:

The pod label selector component=kube-proxy is not present in my case.
The command[] does not have the --cluster-cidr. Rather kube-proxy has a configmap mounted that has this data in YAML format correctly.

$ k get pods -n kube-system kube-proxy-kpkbk -o yaml
apiVersion: v1
kind: Pod
metadata:
  creationTimestamp: "2023-05-22T13:22:51Z"
  generateName: kube-proxy-
  labels:
    controller-revision-hash: 7fc48f5466
    k8s-app: kube-proxy
    pod-template-generation: "1"
  name: kube-proxy-kpkbk
  namespace: kube-system
  ownerReferences:
  - apiVersion: apps/v1
    blockOwnerDeletion: true
    controller: true
    kind: DaemonSet
    name: kube-proxy
    uid: 197c7858-48f6-4ca6-b33a-cfa668a58c16
  resourceVersion: "709"
  uid: eda3a8f0-ad10-4c37-8978-a95260b59542
spec:
  affinity:
    nodeAffinity:
      requiredDuringSchedulingIgnoredDuringExecution:
        nodeSelectorTerms:
        - matchFields:
          - key: metadata.name
            operator: In
            values:
            - lke109600-163534-646b6c270f06
  containers:
  - command:
    - /usr/local/bin/kube-proxy
    - --config=/var/lib/kube-proxy/config.conf
    - --hostname-override=$(NODE_NAME)
    env:
    - name: NODE_NAME
      valueFrom:
        fieldRef:
          apiVersion: v1
          fieldPath: spec.nodeName
    image: linode/kube-proxy-amd64:v1.26.3
    imagePullPolicy: IfNotPresent
    name: kube-proxy
    resources: {}
    securityContext:
      privileged: true
    terminationMessagePath: /dev/termination-log
    terminationMessagePolicy: File
    volumeMounts:
    - mountPath: /var/lib/kube-proxy
      name: kube-proxy
    - mountPath: /run/xtables.lock
      name: xtables-lock
    - mountPath: /lib/modules
      name: lib-modules
      readOnly: true
    - mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      name: kube-api-access-7jj2s
      readOnly: true
  dnsPolicy: ClusterFirst
  enableServiceLinks: true
  hostNetwork: true
  nodeName: lke109600-163534-646b6c270f06
  preemptionPolicy: PreemptLowerPriority
  priority:<PHONE_NUMBER>
  priorityClassName: system-node-critical
  restartPolicy: Always
  schedulerName: default-scheduler
  securityContext: {}
  serviceAccount: kube-proxy
  serviceAccountName: kube-proxy
  terminationGracePeriodSeconds: 30
  tolerations:
  - key: CriticalAddonsOnly
    operator: Exists
  - operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
  - effect: NoSchedule
    key: node.kubernetes.io/disk-pressure
    operator: Exists
  - effect: NoSchedule
    key: node.kubernetes.io/memory-pressure
    operator: Exists
  - effect: NoSchedule
    key: node.kubernetes.io/pid-pressure
    operator: Exists
  - effect: NoSchedule
    key: node.kubernetes.io/unschedulable
    operator: Exists
  - effect: NoSchedule
    key: node.kubernetes.io/network-unavailable
    operator: Exists
  volumes:
  - configMap:
      defaultMode: 420
      name: kube-proxy
    name: kube-proxy
  - hostPath:
      path: /run/xtables.lock
      type: FileOrCreate
    name: xtables-lock
  - hostPath:
      path: /lib/modules
      type: ""
    name: lib-modules
  - name: kube-api-access-7jj2s
    projected:
      defaultMode: 420
      sources:
      - serviceAccountToken:
          expirationSeconds: 3607
          path: token
      - configMap:
          items:
          - key: ca.crt
            path: ca.crt
          name: kube-root-ca.crt
      - downwardAPI:
          items:
          - fieldRef:
              apiVersion: v1
              fieldPath: metadata.namespace
            path: namespace
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2023-05-22T13:22:54Z"
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: "2023-05-22T13:22:57Z"
    status: "True"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: "2023-05-22T13:22:57Z"
    status: "True"
    type: ContainersReady
  - lastProbeTime: null
    lastTransitionTime: "2023-05-22T13:22:51Z"
    status: "True"
    type: PodScheduled
  containerStatuses:
  - containerID: containerd://68fbbc9b7141da97296a02b9ae49e3ff5733d1cc5ff61a8f40aada3e40e6523e
    image: docker.io/linode/kube-proxy-amd64:v1.26.3
    imageID: docker.io/linode/kube-proxy-amd64@sha256:9fd18772468841f2eb567b07ed7022cda7aab2365b4539d32a08c525d2d94c1a
    lastState: {}
    name: kube-proxy
    ready: true
    restartCount: 0
    started: true
    state:
      running:
        startedAt: "2023-05-22T13:22:57Z"
  hostIP: <IP_ADDRESS>
  phase: Running
  podIP: <IP_ADDRESS>
  podIPs:
  - ip: <IP_ADDRESS>
  qosClass: BestEffort
  startTime: "2023-05-22T13:22:54Z"

$ k get cm -n kube-system kube-proxy -o yaml
apiVersion: v1
data:
  config.conf: |-
    apiVersion: kubeproxy.config.k8s.io/v1alpha1
    bindAddress: <IP_ADDRESS>
    clientConnection:
      acceptContentTypes: ""
      burst: 0
      contentType: ""
      kubeconfig: /var/lib/kube-proxy/kubeconfig.conf
      qps: 0
    clusterCIDR: <IP_ADDRESS>/16 # This must be the PodCIDR for LKE!
    configSyncPeriod: 0s
    conntrack:
      maxPerCore: null
      min: null
      tcpCloseWaitTimeout: null
      tcpEstablishedTimeout: null
    enableProfiling: false
    healthzBindAddress: ""
    hostnameOverride: ""
    iptables:
      masqueradeAll: false
      masqueradeBit: null
      minSyncPeriod: 0s
      syncPeriod: 0s
    ipvs:
      excludeCIDRs: null
      minSyncPeriod: 0s
      scheduler: ""
      strictARP: false
      syncPeriod: 0s
    kind: KubeProxyConfiguration
    metricsBindAddress: ""
    mode: ""
    nodePortAddresses: null
    oomScoreAdj: null
    portRange: ""
    udpIdleTimeout: 0s
    winkernel:
      enableDSR: false
      networkName: ""
      sourceVip: ""
  kubeconfig.conf: |-
    apiVersion: v1
    kind: Config
    clusters:
    - cluster:
        certificate-authority: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt
        server: https://67d96b4d-7bf7-4328-80ee-450b32e2830e.us-east-1.linodelke.net:443
      name: default
    contexts:
    - context:
        cluster: default
        namespace: default
        user: default
      name: default
    current-context: default
    users:
    - name: default
      user:
        tokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
kind: ConfigMap
metadata:
  creationTimestamp: "2023-05-22T13:21:43Z"
  labels:
    app: kube-proxy
  name: kube-proxy
  namespace: kube-system
  resourceVersion: "303"
  uid: b95b5e9d-88eb-45c8-9656-c60ceb8cc8a8

Notice the clusterCIDR: <IP_ADDRESS>/16 # This must be the PodCIDR for LKE!
Once this fails, code tries to find podCIDR range from node spec and that has the following data
apiVersion: v1
kind: Node
metadata:
  name: lke109600-163534-646b6c270f06
spec:
  podCIDR: <IP_ADDRESS>/24
  podCIDRs:
  - <IP_ADDRESS>/24
  providerID: linode://46358710

apiVersion: v1
kind: Node
metadata:
  name: lke109600-163534-646b6c272e97
spec:
  podCIDR: <IP_ADDRESS>/24
  podCIDRs:
  - <IP_ADDRESS>/24
  providerID: linode://46358711

apiVersion: v1
kind: Node
metadata:
  name: lke109600-163534-646b6c274e5a
spec:
  podCIDR: <IP_ADDRESS>/24
  podCIDRs:
  - <IP_ADDRESS>/24
  providerID: linode://46358712

So, it seems that node spec.podCIDR only defines a given node's podCIDR range, not the cluster podCIDR. This also looks like a bug
https://github.com/submariner-io/submariner-operator/blob/devel/pkg/discovery/network/generic.go#L182-L191
as the submariner code just returns the first node's podCIDR as cluster podCIDR.
I tried to override this by passing podCIDR to subctl join command, but it is ignored with the following message:
$ subctl join --kubeconfig /home/tamal/Downloads/tamal-us-east-kubeconfig.yaml broker-info.subm \
                                       --clusterid cluster-us-east \
                                       --globalnet \
                                       --clustercidr <IP_ADDRESS>/16
 ✓ broker-info.subm indicates broker is at https://246aea18-562e-400f-989d-32f9c7e85b49.cpc1-us-central.linodelke.net:443
 ✓ Discovering network details
        Network plugin:  calico
        Service CIDRs:   [<IP_ADDRESS>/16]
        Cluster CIDRs:   [<IP_ADDRESS>/24]
 ⚠ The provided pod CIDR for the cluster (<IP_ADDRESS>/16) does not match the discovered CIDR (<IP_ADDRESS>/24)
 ✓ Retrieving the gateway nodes
 ✓ Retrieving all worker nodes

It seems like this part of the codebase has not been modified for sometime, as various assumptions are incorrect.
Proposal:

Allow subctl join to override  --clustercidr even if it does not match the discovered podCIDR, as the auto discover mechanism will probably never be completely accurate.
Fix the obvious bugs/issues in the auto network discovery code.
For calico CNI, code should also check the spec.cidr for the default-ipv4-ippool IPPool.

apiVersion: crd.projectcalico.org/v1
kind: IPPool
metadata:
  creationTimestamp: "2023-05-22T13:23:10Z"
  generation: 1
  name: default-ipv4-ippool
  resourceVersion: "863"
  uid: f03a4a24-da85-4bbc-a79e-e71f92a94b9c
spec:
  allowedUses:
  - Workload
  - Tunnel
  blockSize: 26
  cidr: <IP_ADDRESS>/16
  ipipMode: Always
  natOutgoing: true
  nodeSelector: all()
  vxlanMode: Never

After passing --clustercidr <IP_ADDRESS>/16 with subctl join command, the basic curl nginx.nginx-test.svc.clusterset.local:8080 command is working. :tada:
But when I run the full test suite, some tests are still failing. You can see it here: https://github.com/tamalsaha/lke-submariner/blob/master/e2e-tests.md
Can you help me fix those tests?

@tamalsaha Very nice explanation of the problem, description of the root cause, and even possible solutions, well done!
As per subctl verify failures, it appears that some TCP connectivity tests have failed,
could you please run subctl verify  after changing Calico default-ip-pool to VxLAN overlay on both clusters ?

Hello, I have tried to switch to VXLAN mode by editing IPPool. But if I do that then even curl to a local nginx service does not work anymore.

OK,
After Calico overlay set to VxLAN please restart all submariner route-agent pods , you can use [1]  command and retry.
In case it didn't help, set Calico overlay back to IPIP restart all  submariner route-agent , and attach the subctl gather
[1]
kubectl delete pod -n submariner-operator -l app=submariner-routeagent

Hi,
I tried as you said. But VXLAN is not working. I have attached the output of subctl gather command.
submariner-20230523090055.zip

Hi @tamalsaha , sorry for the late response,
any update on this ?

Ack,
I checked the logs and they seem OK,
I noticed that only the connectivity tests (in subctl verify) between pods that run on non GW nodes failed,  Submariner uses VxLAN (port 4800) for intra-cluster communication between GW node and other nodes , could you please check if UDP port 4800 is allowed between nodes ?
Also could you please add  --packet-size 500 parameter when you run the subctl verify command (to verify that you don't hit MTU issue) ?

This issue seems to be similar to - https://github.com/submariner-io/submariner/issues/2660

Is there any update so far? I got stuck at same place.  @tamalsaha


[feature request] toHaveClass()

For me it is really rare to check that the className is exactly something. Plus, the order of the classes don't matter but can make a test fail if using toHaveClassName().
toHaveClass() would just check if a class is in className.
EDIT: right now I'm using expect(wrapper.hasClass('foo')).toBe(true);

Hmm. Honestly, that's how I would have expected .toHaveClassName() to work.. I wouldn't think it has to be an exact match, but instead just that the component has that className at least.. I'd be open to a PR to fix this.

I use expect(node.find('.myClass')).toBePresent(); which is almost as explicit as hasClass().

@franzheidl Thanks for another solution but it does not convey the same meaning. I wanted to know if a specific element had a class... not if any element had a class.

@mikegleasonjr would you be willing to contribute a PR to add that matcher?

@blainekasten I will try to do it today!

@mikegleasonjr I was just looking into this. And I'm fairly certain this is the existing behavior of toHaveClassName. Can you write up an example where this is not as expected?
Specificially I'm looking at this test that is checking for one class on a node that has 2 classes.
https://github.com/FormidableLabs/enzyme-matchers/blob/master/packages/enzyme-matchers/src/assertions/__tests__/toHaveClassName--tests.js#L21

I'm going to close this. Let me know if it's still an issue and we can reopen it!