Use editor.wordSeparators for Ctrl+D multicursor

VSCode Version:

Version 1.7.1
Commit 02611b40b24c9df2726ad8b33f5ef5f67ac30b44
Date 2016-11-03T13:46:46.244Z
Shell 1.3.8
Renderer 52.0.2743.82
Node 6.5.0

OS Version:

x86_64, Linux-4.8.8-200.fc24.x86_64-x86_64-with-fedora-24-Twenty_Four

Steps to Reproduce:
1.I changed wordSeparators options to

"editor.wordSeparators": "`~!@#$%^&*()=+[{]}\|;:'",.<>/?"

then I tried to multiselect word like "go-home" with keyboard shortcut  crlt + D

3.It multiselect either "go" or "home" depend on where I put my cursor, while It should select the whole word "go-home"

ctrl+d currently uses the word definition as it comes from the language configuration.
We could consider changing ctrl+d to use the word definition provided in editor.wordSeparators.

@alexandrudima Can extensions change the word definitions? Installing sublime keymap helped me greatly in transitioning to vs code, I wonder if this could be added to a How you're used to sublime behaving package :)

We have two kinds of word definitions.

1. editor.wordSeparators
This is a configuration setting with the default of `~!@#$%^&*()-=+[{]}\\|;:'\",.<>/?. AFAIK extensions are not supposed to change defaults for built-in settings, but I'm not sure anymore. Maybe @sandy081  knows ?

This is currently mostly used when doing word navigation or double clicking or in the match whole words in the find widget.

2. a language configuration wordDefinition
This comes in via a language configuration (driven entirely by extensions that contribute languages to VS Code). Most languages contribute it via a language configuration file, but it is possible to overwrite the settings via languages.setLanguageConfiguration in the API.

This is used in very many places, including in Ctrl+D today.

That being said, it is not a really good idea to mess with any of those from an extension.
e.g. the json extension sets a certain word definition for json and expects that to be the one used by the suggestions. If another one comes in, things might not go so well. i.e. changing the word definition for a language might break in subtle ways various language features.
This issue is about if we should move Ctrl+D over to use editor.wordSeparators, as Ctrl+D is perhaps more like word navigation than like suggestions, debug variables, etc.

AFAIK extensions are not supposed to change defaults for built-in settings, but I'm not sure anymore. Maybe @sandy081 knows ?

Yes, an extension cannot register a built in configuartion.

Just wanted to chime in: this little thing is really bugging me. I recently tried transitioning from PHPStorm and am delighted so far with the result.
But: Ctrl+D not honoring the wordsSeparators is that one thing which I always trip about.
Would it be possible to have a config-switch to choose which word definitions should be used?
I would also like to say thank you for this amazing piece of software, I really like it!

Bump.   I depend on ctrl+d to select a word in the way I choose.  I'd also love to see settings for honoring camelCase word splitting, but I can live without it.

Bump. Just dug through several ctrl+d / cmd+d threads to find this.
In Atom, I could override my nonWordCharacters for every type of file. This was something you could set in the settings for each language package, or from your config file.
Is there an option that exists to achieve this that I'm not finding? (One that doesn't potentially break other functionality like noted above)
Personally, I just want my hotkeys to manipulate/traverse/select text in a consistent pattern for any file type.

This is so jarring.
How am I to know what every language deems a word separator? The editor really should be consistent in this respect. Ctrl + D is normally a huge time saver, however with little inconsistencies across different languages in this behaviour I'm wasting time not only manually selecting text with the mouse, but time researching a fix for something that's driving me crazy.
At the very least I feel this should be an option, but should really be changed by default to act the same way as a double click on a word would.

I'm glad to learn about Ctrl+D. When using PHP and double-clicking a variable (e.g. $var), the dollar-sign is not selected for some reason. It is, though, when using Ctrl+D.

Is the change here that Ctrl+D will use editor.wordSeparators instead of the language configured word separators? Verified that, but I'm not sure it's a good change. Word separators change based on language, in Lisp I want ? to be included in my words, in TS I don't. This seems to be strictly reducing the effectiveness of language configured word separators.

Is the change here that Ctrl+D will use editor.wordSeparators instead of the language configured word separators? Verified that, but I'm not sure it's a good change. Word separators change based on language, in Lisp I want ? to be included in my words, in TS I don't. This seems to be strictly reducing the effectiveness of language configured word separators.

Configure per-language settings like so:
    /* Remove $ for JavaScript, PHP, and PowerShell.  */
    "[javascript]": {
        "editor.wordSeparators": "`~!@#%^&*()-=+[{]}\\|;:'\",.<>/?"
    },
    "[php]": {
        "editor.wordSeparators": "`~!@#%^&*()-=+[{]}\\|;:'\",.<>/?"
    },
    "[powershell]": {
        "editor.wordSeparators": "`~!@#%^&*()-=+[{]}\\|;:'\",.<>/?"
    },
    /* Remove $ and - */
    "[scss]": {
        "editor.wordSeparators": "`~!@#%^&*()=+[{]}\\|;:'\",.<>/?"
    }

This may depend on your use-casefor CTRL+D.  In my opinion this is not a "language" feature, but an "editor" one, and so I have the opposite opinion to you :|

@mbomb007

Configure per-language settings like so

I understand that I am able to configure this myself, but the whole point of language extensions is that they configure it for me. And sure the language extension could contribute that setting, but they already contribute word boundaries, why are we making them do it twice?

This may depend on your use-casefor CTRL+D. In my opinion this is not a "language" feature, but an "editor" one, and so I have the opposite opinion to you :|

I think thats a good argument to make this a setting, preferably disabled by default as this will affect many peoples workflows, and only ~4 have explicitly requested it.

I like the fact that I can change the behavior of double-clicking on some text per-language by changing the word boundaries. Idk why PHP has $ as a boundary character by default. I don't particularly care if Ctrl+D does the same or not, but I think it makes sense for it to respect any settings changes made.

@mbomb007

I don't particularly care if Ctrl+D does the same or not, but I think it makes sense for it to respect any settings changes made.

I (and possibly three other people) do care.  It's the primary reason that I have been literally unable to use vscode the last times that I have attempted to.  It's like having someone move the "[" and "]" keys - finger memory of many years must be retrained, and it calls into question the worthiness of the effort.
It's behaviour is expected to be predictable in an instant, without thinking "Oh wait, am I in PHP right now? What am I doing in PHP?  Why?  Why even any of this suffering and uncertainty?  What's the point?"
If I do need to select a chunk of text like asd$jkl#three then I can always know to select it before hitting CTRL+D, without wondering if vscode has some idea about files that end in ".whatever".
Anyway as @JacksonKearl suggests, a setting is a really good idea, especially since at this moment code exists for doing it both ways!  IDEs should have more settings than any other software in the world.

The concept of a "word" is different per language. If you want it to behave the same way no matter the language, you don't have to change "editor.wordSeparators".

However this gets resolved, it'd be greatly appreciated if someone could do a write-up on how a user should go about controlling this, and what all is affected.
It's especially frustrating to me when packages add their own word separators. Personally, I'd prefer to be able to force all my word separators to be consistent, as I think contextual changes based on different language types is confusing when it comes to keyboard navigation and selecting text, though I can see where many users would find it handy. For me, it'd be nice if I could force my Editor: Word Separators setting to apply regardless of any language type's settings.
I'm still confused why double clicking and using cmd+d (ctrl+d for non mac) selects different text in certain cases.

@JacksonKearl This is intentional, as in it was a feature request and now it is closed with an intentional change.

@alexdima Do you have a link to why things would seem to be behaving inconsistently?
Simple example: .classname {
cmd+d from the middle of the text selects .classname with the leading dot in an scss file
double clicking the middle of the text selects only classname
This is just one of many inconsistencies I've come across that are frustrating.

@jsunsawyer I think we are in agreement? 😄

@alexdima Hmm, I think I'm confused on word definitions then. Is this not something that can be edited. Are you saying that we're stuck with inconsistencies because certain languages have word definitions that supersede wordseparators settings?

Here is what will change in the upcoming 1.44 and is available for you to try in Insiders since about 1 month: Ctrl+D will now select words based on the setting editor.wordSeparators and no longer based on the language configuration.


Custom recipe for scipy with cythonrecipe

Ive a stripped down functionality of scipy lfilter, i could successfully build my recipe when targeted for host PC x86_64, which gives shared object built via cython
when i include the same recipe to kivy, i could pass the compilation step, while installation it stilll seeks to install at my development machine instead of ardroid folders.
 RAN: /home/sosdt002/kivy/plotgraph/.buildozer/android/platform/build/build/other_builds/hostpython3/desktop/hostpython3/native-build/python setup.py install -O2

  STDOUT:
running install
running build
running build_ext
running install_lib
creating /usr/local/lib/python3.7
error: could not create '/usr/local/lib/python3.7': Permission denied

my scipy recipe from local folder
from pythonforandroid.recipe import CythonRecipe
from pythonforandroid.toolchain import Recipe, shprint, current_directory,info
import urllib.parse
import sh
import glob

class ScitoolsRecipe(CythonRecipe):
    url = 'file://' + urllib.parse.quote("/home/sosdt002/Desktop/scitools")
    name = 'scitools'

    depends = ['numpy', 'cython']

    def build_arch(self, arch):
        Recipe.build_arch(self, arch)  # a hack to avoid calling
                                   # PythonRecipe.build_arch
        self.build_cython_components(arch)
        self.install_python_package(arch)  # this is the same as in a PythonRecipe

    def install_python_package(self,arch):
        '''Automate the installation of a Python package (or a cython
        package where the cython components are pre-built).'''
        # arch = self.filtered_archs[0]
        env = self.get_recipe_env(arch)
        # shprint(echo, '$PATH', _env=env)
        info('Installing {} into site-packages'.format(self.name))

        with current_directory(self.get_build_dir(arch.arch)):
            hostpython = sh.Command(self.ctx.hostpython)

            # shprint(hostpython, 'setup.py', 'install', '-O2', _env=env)

    def build_cython_components(self, arch):
        env = self.get_recipe_env(arch)
        info("arch={}".format(env))
        with current_directory(self.get_build_dir(arch.arch)):
            hostpython = sh.Command(self.ctx.hostpython)

            # This first attempt *will* fail, because cython isn't
            # installed in the hostpython
            try:
                shprint(hostpython, 'setup.py', 'build_ext', '-v', _env=env)
            except sh.ErrorReturnCode_1:
                pass

            # ...so we manually run cython from the user's system
            shprint(sh.find, self.get_build_dir('armeabi-v7a'), '-iname', '*.pyx', '-exec',
                      'cython', '{}', ';', _env=env)

            # now cython has already been run so the build works
            shprint(hostpython, 'setup.py', 'build_ext', '-v', _env=env)

            # stripping debug symbols lowers the file size a lot
            build_lib = glob.glob('./build/lib*')
            shprint(sh.find, build_lib[0], '-name', '*.o', '-exec',
                    env['STRIP'], '{}', ';', _env=env)
            shprint(hostpython, 'setup.py', 'install', '-O2', _env=env)

recipe = ScitoolsRecipe()

reading around blogs i found running buildozer with root is not advise to overcome permission issue


Contract now does not generate logic within generated wrapper modules.

For externalization - only uses wrappers.
For storage, no inner module.

This change is

crates/cairo-lang-starknet/src/contract_test.rs line 51 at r2 (raw file):
Previously, orizi wrote…
it won't :(

Ah, I see why, should consider fixing it (not here), but unrelated.


updated grafana to use the newest version 4.2.0

I updated grafana package to use the newest version, I have been testing this version in dcos 1.9 and work better then 3.1.1 version. Was not 100 sure if i setup the new version write with the directory, let me know if it is not correct or if i need to do more to contribute this new version.

@lockwobr thanks for the PR!! Can you please bump the version to 4.2.0:0.2 to reflect the package change? Also, can you please add the new screenshots to the tutorial in https://github.com/dcos/examples/tree/master/cadvisor-influxdb-grafana (if you're running 1.9 already just add the tutorial for 1.9 directly with the new screenshots -- I'll update 1.8 afterwards).
Other than that LGTM-- tested and working!  Thanks!!

@fernandosanchezmunoz I dont have an env anymore to get screen shots, but i did bump the version number.

@ryadav88 this is tested and working. Let me know your thoughts on pushing without updating the tutorial. I don't have the bandwidth just now so if you want to take that one go ahead.

@lockwobr can you please bump the package version in the Marathon app definition too please.

@fernandosanchezmunoz we have an open PR  : https://github.com/dcos/examples/pull/136

@fernandosanchezmunoz I can hard code like
"DCOS_PACKAGE_VERSION": "4.2.0-0.2",
or can ? or should do it so it pulls from the package.json like
"DCOS_PACKAGE_VERSION": "{{package.version}}",

Well to be honest I haven't tried the second form and I'm not sure it would
work. The first one would work for sure. If you can try the second and
check in Marathon that it actually works, then it'd be even better.
thanks!
2017-04-25 13:29 GMT-04:00 Brian Lockwood<EMAIL_ADDRESS>
@fernandosanchezmunoz https://github.com/fernandosanchezmunoz I can
hard code like
"DCOS_PACKAGE_VERSION": "4.2.0-0.2",
or can ? or should do it so it pulls from the package.json like
"DCOS_PACKAGE_VERSION": "{{package.version}}",
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mesosphere/universe/pull/1063#issuecomment-297105643,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEEZTpm9CJEybBed6xMI8us8St9nErebks5rzi2KgaJpZM4M2VZQ
.

@fernandosanchezmunoz I don't have a place to test it, and looking at the other packages none of them have it that way so it might not work, and since can't test this change, went with the safe route.

LGTM


[Bug]: error TS2821: Import assertions are only supported when the '--module' option is set to 'esnext' or 'nodenext'.

Version
29.1.1
Steps to reproduce
With the following TS config:
{
    "compilerOptions": {
        "module": "esnext",
        "resolveJsonModule": true,
    }
}

And, the following Jest config:
{
    "preset": "ts-jest"
}

A file index.ts which imports a JSON file with a type assertion e.g.
import * as config from './config.json' assert {type:'json'}

when imported in a Jest test file e.g.
import index from './index'

describe('test', () => {
    test('should pass', () => {
		expect(index).toBeDefined()
    })
})

gives an error.
Expected behavior
Test passes.
Actual behavior
Test fails with a TS error:
    index.ts:1:41 - error TS2821: Import assertions are only supported when the '--module' option is set to 'esnext' or 'nodenext'.

    1 import * as config from './config.json' assert {type:'json'}
                                              ~~~~~~~~~~~~~~~~~~~~

Debug log
{"context":{"call":null,"logLevel":10,"namespace":"ts:serviceHost","package":"ts-jest","version":"29.1.1"},"message":"readFile","sequence":412,"time":"2023-09-01T20:04:41.079Z"}
{"context":{"call":null,"logLevel":20,"namespace":"hoist-jest","package":"ts-jest","version":"29.1.1"},"message":"visitSourceFileNode(): hoist jest","sequence":413,"time":"2023-09-01T20:04:41.196Z"}
{"context":{"fileName":"C:\\project\\index.ts","logLevel":20,"namespace":"ts-compiler","package":"ts-jest","version":"29.1.1"},"message":"_doTypeChecking(): computing diagnostics using language service","sequence":414,"time":"2023-09-01T20:04:41.208Z"}
{"context":{"diagnosticCodes":[2821],"diagnosticText":"\u001b[96mindex.ts\u001b[0m:\u001b[93m1\u001b[0m:\u001b[93m41\u001b[0m - \u001b[91merror\u001b[0m\u001b[90m TS2821: \u001b[0mImport assertions are only supported when the '--module' option is set to 'esnext' or 'nodenext'.\n\n\u001b[7m1\u001b[0m import * as config from './config.json' assert {type:'json'}\n\u001b[7m \u001b[0m \u001b[91m                                        ~~~~~~~~~~~~~~~~~~~~\u001b[0m\n","logLevel":20,"namespace":"TSError","package":"ts-jest","version":"29.1.1"},"message":"created new TSError","sequence":415,"time":"2023-09-01T20:04:41.209Z"}
{"context":{"logLevel":20,"namespace":"ts-jest-transformer","package":"ts-jest","version":"29.1.1"},"message":"created new transformer","sequence":416,"time":"2023-09-01T20:04:41.216Z"}

Additional context
This error happens regardless of whether the Jest config is provided as JSON, JS or TS file.
Also, TS doesn't throw this error when transpiling index.ts file.
In fact, TS throws this error if the value of module is changed from esnext.
So, the value of module is indeed correct, but somehow TS Jest doesn't get it.
On a related note, changing the value of module to some invalid value triggers a different error about the value being invalid:
error TS6046: Argument for '--module' option must be: 'none', 'commonjs', 'amd', 'system', 'umd', 'es6', 'es2015', 'es2020', 'es2022', 'esnext', 'node16', 'nodenext'.

So, it looks like TS Jest is overriding the esnext value.
Environment
Binaries:
    Node: 18.17.1 - C:\Program Files\nodejs\node.EXE
    npm: 9.6.7 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    jest: ^29.6.4 => 29.6.4

Would love to get a real solution. For now I suppress the import assertion error using:
// @ts-ignore, because when setting node module resolution to Node16, tsc raises an error for the import assertion.
import configSchema from "./config-schema.json" assert { type: "json" };

any update on this issue? Stumbling on it today 🙃

Try putting
	"extensionsToTreatAsEsm": [".ts"],
	"globals": {
		"ts-jest": {
			"useESM": true
		}
	}

into your jest.config, and set the NODE_OPTIONS=--experimental-vm-modules environment variable, or use node --experimental-vm-modules.
Also see https://github.com/kulshekhar/ts-jest/issues/3525 and https://jestjs.io/docs/ecmascript-modules

(Or use vitest)

@sezanzeb is right. This feature only exists when using Jest in ESM mode. You can check documentation how to do it at https://kulshekhar.github.io/ts-jest/docs/guides/esm-support

hey again 👋 , i confirmed that the workarounds mentioned will work for import assertions , but will not yet work for import attributes. I've opened a separate feature request here about this:
https://github.com/kulshekhar/ts-jest/issues/4505


Could't analyze webpack bundle, Could't analyze webpack bundle

Version
2.5.22
Reproduction link
https://github.com/riiccardo/vue-simple-todo-error
Steps to reproduce

open vue-ui
run serve task got error
build task got error too

What is expected?
Compile Code But...
What is actually happening?
Could't analyze webpack bundle, Could't analyze webpack bundle

idk what is this error every thing is up to date
vue v2.5.22
vue-cli-service v3.4.0
vue-template-compiler v2.5.21

few days ago i got error in Vue ui setup with core-js and apollo-env
today i got error with compiling :((

its not question just go use that repo !

First, this is about a webpack plugin maybe the Vue cli not configuring it correctly, in which case you should open an issue there not in Vue repo. Secondly, if you want us to put more time in, give more context instead of just pasting the error as the title and giving zero context


In-computer audio input

Is there any way to take audio input from inside the computer (any application), maybe via a virtual audio driver. For now, it can only take in default microphone input. Thanks. @sveinbjornt @MrYakobo @adisidev

You should be able to change your default audio input source in System Settings to a virtual audio driver and everything should work. The code in hear just uses the default input source.

You should be able to change your default audio input source in System Settings to a virtual audio driver and everything should work. The code in hear just uses the default input source.

Thank you @sveinbjornt. I am looking at a use case where I need to use my default external microphone to take in my voice, and the virtual audio driver to transcribe what I hear (from a video or other speakers in a virtual meeting) but not my own speech. So can this be modified to take in non-default (any) virtual audio driver? Thanks so much.

Why not do this post hoc? Does this need to be (near) live? If you have both audio channels written to disk there is no problem with post hoc processing using input files.

Why not do this post hoc? Does this need to be (near) live? If you have both audio channels written to disk there is no problem with post hoc processing using input files.

Thank you @sveinbjornt. Yes it has to be live as we are developing real-time ASR of a meeting while the person using it is speaking at the same time in a different language to another program or channel. So the virtual audio driver needs to send the output as input to "hear", while the default microphone is used by the user as input for another program or channel. Can this be done? Thanks.

Should be simple enough to modify the hear source code to do what you want. Maybe I'll implement a flag to specify audio input device at a future date. Keeping this open.

Should be simple enough to modify the hear source code to do what you want. Maybe I'll implement a flag to specify audio input device at a future date. Keeping this open.

That is highly appreciated @sveinbjornt. Just a side track, would it be possible to (modify and) extend this to iOS since the services are all provided by Apple?

Well, hear uess a macOS API (which is probably also available on iOS) but people don't run command line apps on iOS so that's probably a no-go.


Issue with Negative Values in Sweep

Negative values in sweep
Fix with np.absolute before addition to matrix?

Fixed by changing sign in config.py


Remove the WebSocketAbstractions repo.

#233 @Eilon

Could you also add AntiForgery while you're at it?

In release?

:shipit: for this.

Sorry that would be dev only. Maybe change it when merging release -> dev

@pranavkm I added Antiforgery for dev. You'd also forgotten to merge release->dev after the last branching.


norder limitation

Hi,
I'm using healpix for a different project, and have been looking around for implementations and came across yours which seems interesting. However, the limitation is at norder <= 15. Current norder doesn't allow high resolution images of nebulas for example when overlaying different frequency image survey maps (infrared, nir, xray etc). Can you tell me what the exact reason for this is? I might be able to help somehow.
I downloaded healpix 3.8 and the doc provides a healpix2 cpp that allows for much higher resolutions, which indicates that the norder can be increased?
Any pointers to the reasons of the limitations greatly appreciated as I can further investigate.

The direct root of the limitation is here.
https://github.com/michitaro/healpix/blob/6282f3e0da97264e71fed468044daaf44e8296bb/src/index.ts#L546
This function is for converting scheme from RING to NEST.
If the function could handle values of order > 16, the limitation can be eliminated.
(But, we have to care about the range of values being not bigger than Number.MAX_SAFE_INTEGER)
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER

BTY, this library's license if MIT and HEALPix's license is GPL, so we cannot port HEALPix's implementation into this library.

Thanks for these, I will study them in parallel to the healpix primer I have been taking notes from. Here are some thoughts:

it seems that the conversion from norder to npix where npix is the HPX key for the quad to extract has the big int which will overflow using a normal int maxed out at 2^53. The reference you added on mozilla's site mentions BIGINT.
Is this the only function that requires handling larger ints?

I'll get back when I find something interesting
Thanks again

On 27 Dec 2021, at 11:39 am, Koike Michitaro @.***> wrote:
The direct root of the limitation is here.
https://github.com/michitaro/healpix/blob/6282f3e0da97264e71fed468044daaf44e8296bb/src/index.ts#L546 https://github.com/michitaro/healpix/blob/6282f3e0da97264e71fed468044daaf44e8296bb/src/index.ts#L546
This function is for converting scheme from RING to NEST.
If the function could handle values of order > 16, the limitation can be eliminated.
(But, we have to care about the range of values being not bigger than Number.MAX_SAFE_INTEGER)
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_SAFE_INTEGER
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1001283353, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFOUDG673PWHDHBGOWTUS67TRANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Sorry, I forgot there was a similar discussion. See this issue.
https://github.com/michitaro/healpix/issues/8
JavaScript's bit-operation supports only 32bit integers, so bit_{,de}combine cannot handle large integers.
If the function could handle values without bit-operations, the limitation would be reduced.

Yes, that's what I thought as we are talking powers of 2 to subdivide each unit pixel of the sphere. Have you considered breaking the bit to smaller parts? like taking the overflow bits and shifting them across to another 32-bit integer? I'm going to try these to see how far it can be taken. I'm looking at getting norder to up to 23.

On 27 Dec 2021, at 4:44 pm, Koike Michitaro @.***> wrote:
Sorry, I forgot there was a similar discussion. See this issue.
#8 https://github.com/michitaro/healpix/issues/8
JavaScript's bit-operation supports only 32bit integers, so bit_{,de}combine cannot handle large integers.
If the function could handle values without bit-operations, the limitation would be reduced.
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1001369587, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFLCFTGAJCLQCH2LMO3UTADMXANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

I found a thin wrapper for the native BIGINT type which provides all bit operations, arithmetic operations and others. I think these are sufficient to provide larger npix integers for healpix. I will keep reading your code and understand it better and try a version using some larger powers of 2.

On 27 Dec 2021, at 4:44 pm, Koike Michitaro @.***> wrote:
Sorry, I forgot there was a similar discussion. See this issue.
#8 https://github.com/michitaro/healpix/issues/8
JavaScript's bit-operation supports only 32bit integers, so bit_{,de}combine cannot handle large integers.
If the function could handle values without bit-operations, the limitation would be reduced.
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1001369587, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFLCFTGAJCLQCH2LMO3UTADMXANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Have you considered breaking the bit to smaller parts? like taking the overflow bits and shifting them across to another 32-bit integer?
I think this is a good idea and more feasible than introducing BigInt.

I wonder introducing BigInt needs a lot of changes.

I started converting operators to bigInt versions and am adding sqrt using newton’s method. Will see if it will work on all test cases properly
Sent from sputnik7

On 28/12/2021, at 5:04 PM, Koike Michitaro @.***> wrote:

Have you considered breaking the bit to smaller parts? like taking the overflow bits and shifting them across to another 32-bit integer?
I think this is a good idea and more feasible than introducing BigInt.
I wonder introducing BigInt needs a lot of changes.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.

The current test case generator generates only cases for norder <= 16, so tweak the file before your tests.
https://github.com/michitaro/healpix/blob/master/spec/generate-testcase.py
The case generator generates cases using random numbers, so the cases might not be comprehensive (edge cases might be missing). Keep in mind that.
I wonder BigInt and Newton Method bring some disadvantages on performance, so a flag to turn off BigInt mode will be helpful.

I’m using test cases on the Hubble space telescope hips surveys. I checked the potential performance issues, however I’m not sure if 12 million bigint operations a second would be an issue in applications that require healpix. I’m writing a separate set of functions, wrapped into a HealpixIndex object. I’m just filtering the function chain to see where the bigints come in to play. Nside can go up to 2 to 26 as bigint’s max stable is 2 to 52. So far the biggest possible value would be 12nsidenside which is 2 to 53. It’s the possible trig functions or others i have not clearly identified which may be an issue but I think it’s worth it.
Sent from sputnik7

On 28/12/2021, at 5:34 PM, Koike Michitaro @.***> wrote:

The current test case generator generates only cases for norder <= 16, so tweak the file before your tests.
https://github.com/michitaro/healpix/blob/master/spec/generate-testcase.py
The case generator generates cases using random numbers, so the cases might not be comprehensive (edge cases might be missing). Keep in mind that.
I wonder BigInt and Newton Method bring some disadvantages on performance, so a flag to turn off BigInt mode will be helpful.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.

I’m not sure if 12 million bigint operations a second would be an issue in applications that require healpix.

Wow, bigint operations are so fast? If so, they won't be bottleneck.

I’m writing a separate set of functions, wrapped into a HealpixIndex object.

😲

I've read through all the functions you wrote, and compared them with my notes, and your header and nomenclature for the variables, projection methods and representations. it seems as though p and q come from the bit_combine and bit_decombine with some propagation into a few more functions so it shouldn't be too bad. Reconverting to number in crucial areas with pi divisors and others should isolate most of the bigInt requirements.
one thing of note, since a lot of transforms have a definite pattern on the 3 ring region cases, there might be a way to just generate some lookup tables. nside, jj, pp and some others. This can probably boost performance slightly.

On 28 Dec 2021, at 11:39 pm, Koike Michitaro @.***> wrote:
I’m not sure if 12 million bigint operations a second would be an issue in applications that require healpix.
Wow, bigint operations are so fast? If so, they won't be bottleneck.
I’m writing a separate set of functions, wrapped into a HealpixIndex object.
😲
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1002110650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFNF34OSS4OQVVZI2R3UTG4YXANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Just wanted to double check with you in terminology::

p     :  north-east axis in base pixel            [0, 1)
q     :  north-west axis in base pixel            [0, 1)

Are both p and q meant to be ints or floats?
Thanks

On 28 Dec 2021, at 11:39 pm, Koike Michitaro @.***> wrote:
I’m not sure if 12 million bigint operations a second would be an issue in applications that require healpix.
Wow, bigint operations are so fast? If so, they won't be bottleneck.
I’m writing a separate set of functions, wrapped into a HealpixIndex object.
😲
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1002110650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFNF34OSS4OQVVZI2R3UTG4YXANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Just wanted to double check with you in terminology::

p     :  north-east axis in base pixel            [0, 1)
q     :  north-west axis in base pixel            [0, 1)

Are both p and q meant to be ints or floats?
Thanks

On 28 Dec 2021, at 11:39 pm, Koike Michitaro @.***> wrote:
I’m not sure if 12 million bigint operations a second would be an issue in applications that require healpix.
Wow, bigint operations are so fast? If so, they won't be bottleneck.
I’m writing a separate set of functions, wrapped into a HealpixIndex object.
😲
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1002110650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFNF34OSS4OQVVZI2R3UTG4YXANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Hi,
So I took the tests suite and customised them as I wasn't able to run npm run my-test. I extracted the json test suite and wrote my own routine to compare the various expected/resulting outputs. I got the below:
vec2pix_nest
mismatch 0
vec2pix_ring
mismatch 0
ang2pix_nest
mismatch 0
ang2pix_ring
mismatch 0
nest2Ring
mismatch 0
ring2nest
mismatch 0
pix2vec_nest
mismatch 0
pix2vec_ring
mismatch 0
nside2pixarea
mismatch 0
nside2resol
mismatch 0
max_pixrad
expected
0.48146047147606696
got
0.4814604714760669
mismatch 13
corners_nest
mismatch 0
corners_ring
mismatch 0
orderpix2uniq
mismatch 0
uniq2orderpix
mismatch 0
nside2order
mismatch 0
For some reason maxrad has a distance of abs(a-b) of 5.xxxxe-17, which I suspect is due to conversion from BigInt to Number before passing it through some divisor.
Coincidentally, 10e-17 is probably the limit of base 10 digits on an integer, so the conversion issue may be there. I even tried abs(a-b) > 10e-5 then false but no luck so far. Will dig deeper until all have 0 mismatch.

On 28 Dec 2021, at 11:39 pm, Koike Michitaro @.***> wrote:
I’m not sure if 12 million bigint operations a second would be an issue in applications that require healpix.
Wow, bigint operations are so fast? If so, they won't be bottleneck.
I’m writing a separate set of functions, wrapped into a HealpixIndex object.
😲
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1002110650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFNF34OSS4OQVVZI2R3UTG4YXANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Hi,
So I took the tests suite and customised them as I wasn't able to run npm run my-test. I extracted the json test suite and wrote my own routine to compare the various expected/resulting outputs. I got the below:
vec2pix_nest
mismatch 0
vec2pix_ring
mismatch 0
ang2pix_nest
mismatch 0
ang2pix_ring
mismatch 0
nest2Ring
mismatch 0
ring2nest
mismatch 0
pix2vec_nest
mismatch 0
pix2vec_ring
mismatch 0
nside2pixarea
mismatch 0
nside2resol
mismatch 0
max_pixrad
expected
0.48146047147606696
got
0.4814604714760669
mismatch 13
corners_nest
mismatch 0
corners_ring
mismatch 0
orderpix2uniq
mismatch 0
uniq2orderpix
mismatch 0
nside2order
mismatch 0
For some reason maxrad has a distance of abs(a-b) of 5.xxxxe-17, which I suspect is due to conversion from BigInt to Number before passing it through some divisor.
Coincidentally, 10e-17 is probably the limit of base 10 digits on an integer, so the conversion issue may be there. I even tried abs(a-b) > 10e-5 then false but no luck so far. Will dig deeper until all have 0 mismatch.

On 28 Dec 2021, at 11:39 pm, Koike Michitaro @.***> wrote:
I’m not sure if 12 million bigint operations a second would be an issue in applications that require healpix.
Wow, bigint operations are so fast? If so, they won't be bottleneck.
I’m writing a separate set of functions, wrapped into a HealpixIndex object.
😲
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1002110650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFNF34OSS4OQVVZI2R3UTG4YXANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Hi again, and HNY :)
So here is the result of testing for norder up to 24.
note: the comparisons are slowing the process down as some have to go through arrays of n elements.
note2: The example mismatch really isn't one if you think about it. There's a single 10e-17th decimal change between the python output and the js result.
vec2pix_nest
mismatch 0
vec2pix_ring
mismatch 0
ang2pix_nest
mismatch 0
ang2pix_ring
mismatch 0
nest2ring
mismatch 0
ring2nest
mismatch 0
pix2vec_nest
mismatch 0
pix2vec_ring
mismatch 0
nside2pixarea
mismatch 0
nside2resol
mismatch 0
max_pixrad
expected example
0.48146047147606696
got
0.4814604714760669
mismatch 21
corners_nest
mismatch 0
corners_ring
mismatch 0
orderpix2uniq
mismatch 0
uniq2orderpix
mismatch 0
nside2order
mismatch 0
made 278096 comparisons in 3.011 seconds

On 28 Dec 2021, at 11:39 pm, Koike Michitaro @.***> wrote:
I’m not sure if 12 million bigint operations a second would be an issue in applications that require healpix.
Wow, bigint operations are so fast? If so, they won't be bottleneck.
I’m writing a separate set of functions, wrapped into a HealpixIndex object.
😲
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1002110650, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFNF34OSS4OQVVZI2R3UTG4YXANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Oh, sorry for the delayed response and Happy new year!
Wow! Super progress!

If you can make a PR, I will tweak the test codes to suit your codes.

Hi,
I'm just having some issues with testing the function query_disc_inclusive_nest. I'm not sure what it's meant to return, normally a list of ipix?
Once I got this one fixed, I can send you the repo.

On 5 Jan 2022, at 11:50 am, Koike Michitaro @.***> wrote:
If you can make a PR, I will tweak the test codes to suit your codes.
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1005312879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFIESCITYIJ76XDSNYLUUOPW5ANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

query_disc_inclusive_nest does not return any list but accepts a callback function whose only parameter is ipix.
like this:
https://github.com/michitaro/healpix/blob/7c0e9d8f21cf1126b255ac37b90865fece321413/docs/example/src/query_disc/main.ts#L26
This is to avoid allocating a large amount of memory when the resultant ipxs are too many.
If you want to get the list of ipxs, you can do something like this:
const a = []

for (const ipix of query_disc_inclusive_nest(...)) {
  a.push(ipix)
}

How the example of healpix.query_disc_inclusive_nest work can be seen here.
https://michitaro.github.io/healpix/query_disc.html

thanks for the explanation below. However, I'm not sure what function to callback.
You wrote:

const a = []
for (const ipix of query_disc_inclusive_nest(...)) {
a.push(ipix)
}

the last argument of query_inclusive_nest is meant to be a callback. Do I just call function (ipix) as the last argument?
Sorry, not very familiar with the ES6 js semantics.

On 11 Jan 2022, at 12:09 pm, Koike Michitaro @.***> wrote:
query_disc_inclusive_nest does not return any list but accepts a callback function whose only parameter is ipix.
like this:
https://github.com/michitaro/healpix/blob/7c0e9d8f21cf1126b255ac37b90865fece321413/docs/example/src/query_disc/main.ts#L26 https://github.com/michitaro/healpix/blob/7c0e9d8f21cf1126b255ac37b90865fece321413/docs/example/src/query_disc/main.ts#L26
This is to avoid allocating a large amount of memory when the resultant ipxs are too many.
If you want to get the list of ipxs, you can do something like this:
const a = []
for (const ipix of query_disc_inclusive_nest(...)) {
a.push(ipix)
}
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1009534697, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFP3LT3CUS6BUJPEZFDUVOGNZANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

No all good, I did some tests for length of arrays when pushing ipix through the callbacks and they match.
I'll run some more tests then show you the results on a high order HST survey image

On 11 Jan 2022, at 12:11 pm, Koike Michitaro @.***> wrote:
How the example of healpix.query_disc_inclusive_nest work can be seen here.
https://michitaro.github.io/healpix/query_disc.html https://michitaro.github.io/healpix/query_disc.html
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1009535519, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFPDSB4ZW7JMQ5TVBUTUVOGU3ANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Hi,
So I've gotten the pixlist working from query_disc_inclusive_nest, however the results don't match. I tried adding values to the healpy module function ipix = hp.query_disc(nside=8, vec=[1, 0, 0], radius=0.008328107069661798)
it returns an empty array. The results I get from my modification matches another healpix module, which are:
nside=8, v=[1, 0, 0] radius=0.008328107069661798
 304n
 293n
 282n
 271n
Would it be possible to create some test cases of returned ipix lists from the generate-testcase.py?

On 11 Jan 2022, at 12:11 pm, Koike Michitaro @.***> wrote:
How the example of healpix.query_disc_inclusive_nest work can be seen here.
https://michitaro.github.io/healpix/query_disc.html https://michitaro.github.io/healpix/query_disc.html
—
Reply to this email directly, view it on GitHub https://github.com/michitaro/healpix/issues/25#issuecomment-1009535519, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJHQFPDSB4ZW7JMQ5TVBUTUVOGU3ANCNFSM5KYW7M4Q.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Hi,
Sorry for the delayed response.
Use hp.query_disc(nside=8, vec=[1, 0, 0], radius=0.008328107069661798, inclusive=True, nest=True) instead.
It also returns the same results.
import healpy

ipix = healpy.query_disc(nside=8, vec=[1, 0, 0], radius=0.008328107069661798, inclusive=True, nest=True)
print(ipix)
# [271 282 293 304]


Resize fix

Short description of what this resolves:
This fixes an issue where dimensions were not getting measured right when the window was resized to be smaller. This caused issues with our new desktop support.
Changes proposed in this pull request:

Make sure dimensions get measured correctly when the window is resized both smaller and bigger
Add new unit tests that cover the width() and height() methods and also window resizing

Ionic Version: 2.x

Doing some final testing of this on my end. @manucorporat let me know if you see anything else you would like changed and ill let you know when ive finished my testing.

Alright, my testing seems to check out on both android and iOS.


Add Delay HIL test

Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝

[ ] I have updated existing examples or added new ones (if applicable).
[ ] My changes were added to the CHANGELOG.md in the proper section.

Extra:

[ ] I have read the CONTRIBUTING.md guide and followed its instructions.

Pull Request Details 📖
Description
Adds an HIL test for Delay.
Not really sure, how useful these tests are though. Using the same value of delay as timeouts ends up in timeouts which is expected (correct me if I'm wrong). I used "random" delay values, maybe I can tune them a little bit but not sure if that make sense. Any feedback/suggestion is appreciated.
Testing
Run Delay test locally on multiple chip targets and manually triggered HIL job for this branch.

As discussed in our last meeting, let's leave this open as draft until we have a solution to testing https://github.com/esp-rs/esp-hal/pull/1415#pullrequestreview-1996836823

I guess we could finish this off by doing something like this: https://github.com/esp-rs/esp-hal/pull/1503/files#diff-e59763db0f920701a0f837f4ad608deb797df5ffeb0adc976fc65eaecd1a2915R40-R42 we are sorta dependent on either breaking, but if either break we probably want to know?


Urgent Fix - fix type

Issue #, if available:
Description of changes:
Urgent fix of type
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Duplicates #256


[REQUEST] Quark Double Door Compat

Is your feature request related to a problem? Please describe.

Double doors don't open at the same time like normal doors do with Quark installed

Describe the solution you'd like

Double tall doors should open at the same time when Quark's double doors are enabled in the config.

Describe alternatives you've considered

None that I could think of.

Now in version 2.1.2 of Dramatic Doors.


admin: add metrics endpoint

part of https://github.com/istio/ztunnel/issues/13

@zirain: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
6c44ef559b627fc90dbda53365113b466e8af7bc
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

test_ztunnel
16ee30355a9bd8ab8312983e76be86df24f5cb6e
link
true
/test test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Feature/fiat payments

Proposal for Billing Feature Structure
This PR proposes a structure for the upcoming billing feature. It includes some entities to showcase the structure, so please overlook any weak typing or lack of implementations for now.
Main Concepts
Dedicated Module

The billing module should ideally include all entities necessary to implement its business requirements within its domain.
It would be beneficial for the module to contain database accessors, services, controllers, and routers.
The module should aim to hide the complexity of business logic under the hood.
It should expose only HTTP APIs and control what can be imported by other modules.

Flat Structure

To maintain clarity, avoid deeply nested submodules. Since the application domain is already clear, a flat structure is suggested.

CamelCase for files.

Names should ideally reflect the main export. While names like utils and helpers are common, they can be misleading. Instead, consider using names that clearly describe their purpose, such as StringService for something that works with strings.

Exports

It's generally better to avoid files containing code for multiple purposes. Splitting them can help ensure each file serves a single purpose, which aids in clarity and maintenance.

Database

Direct access to Sequelize DB models should be limited. Abstracting Sequelize using a repository pattern can help ensure the app doesn’t depend heavily on the storage mechanism.
This abstraction can be beneficial, especially if ORM or DB changes are needed in the future.

Workers

Workers should operate independently of the main HTTP app to prevent potential performance issues under load.
Consider using a CLI as a dedicated entry point for workers. Building a container for the job and running it with the infrastructure (e.g., this example) can provide a dedicated environment while maintaining a unified codebase.

Dependency Injection (DI)

Utilizing dependency injection can produce more testable and independent code that relies on interfaces.
While classes are a natural fit for DI, a functional approach can also be effective. DI can be beneficial even in apps without a specific framework.

Migrations

We need to discuss our approach to migrations. Using Sequelize for this might increase our dependency on it and impose structural obligations on our app.
It may be worth considering other tools or methods for handling migrations to maintain flexibility.

Note: This is a proposal. I welcome counter-arguments and suggestions. The goal is to have a constructive discussion and agree on an approach we can follow consistently.

How do you DI being implemented? I know there's some libraries to automate the instantiation based on the type.

@baktun14 DI is an approach. Instead of importing a dep and using directly it should be provided as an arg to a function/class. Like I did in the example.
Although I agree some automation would be nuts.

@baktun14 @Redm4x BTW decided to investigate DI question just a bit. Some options:

https://github.com/zazoomauro/node-dependency-injection/wiki
https://docs.nestjs.com/standalone-applications

both things should be easy to use from the start.
Basically the flow would be:

use classes as usual
register them
create context and put it into hono route context

Say, we have these dependency flow:
WalletController -> WalletService -> UserWalletModel
These classes are the same as if there's no automated DI, so no extra work. What needs to be done:

new lib to manage that
create a simple service defining all the deps. In case with the lib that would be creating a container and a lib, in case with nest it would be a module + context
add it to hono with a middleware

I don't see too much effort in this. If you guys think this is beneficial it's better be done imo.

oh, this one seems even better https://www.npmjs.com/package/typedi

oh, this one seems even better https://www.npmjs.com/package/typedi

Yea this is the one I saw in an article.

Ok, added TypeDI - this is really not a big deal in terms of effort, the impact though is changing imo

added drizzle https://github.com/akash-network/cloudmos/pull/251/commits/837319c7c6a27a671acff033ac6ccf440d3bfefb
this is a fully functional example. I personally see no reason not to start migrating slowly.

What's the naming convention for services? camelCase or PascalCase?

I tried to describe is the convention in the description of this PR. I personally like it in a different way. However, I tried to match something that we already have in the project. I am open to change this to something we can commonly agree to.

What's the naming convention for services? camelCase or PascalCase?

I tried to describe is the convention in the description of this PR. I personally like it in a different way. However, I tried to match something that we already have in the project. I am open to change this to something we can commonly agree to.
I personally like nest JS convention when directories are named in snake case and files are named in snake case with an extension containing the type of the file. Like some-class.service.ts. The file should contain a class or a function that that is named the same as the file by camel case. To me, this approach reduces cognitive load when going through the code radically.

I was referring to logHttpRequests.ts and postgres.ts that are camelCase.

What's the naming convention for services? camelCase or PascalCase?

I tried to describe is the convention in the description of this PR. I personally like it in a different way. However, I tried to match something that we already have in the project. I am open to change this to something we can commonly agree to.

I personally like nest JS convention when directories are named in snake case and files are named in snake case with an extension containing the type of the file. Like some-class.service.ts. The file should contain a class or a function that that is named the same as the file by camel case. To me, this approach reduces cognitive load when going through the code radically.

I was referring to logHttpRequests.ts and postgres.ts that are camelCase.

Right, those are files and match the main exported function


Does rspack normalModuleLoader plan to align beforeLoaders and other hooks with webpack 5?

Current
webpack NormalModuleCompilationHooks:

rspack js side NormalModuleHooks:

My Confusion
In addition, I found some code about before_loaders on the rust side, but the definition here is a litter different from webpack. Does it only need to be exported on the js side before it can be used? Please forgive me if my understanding is wrong.

Background
My webpack project use this hooks to add some custom loader context.
compiler.hooks.compilation.tap(PLUGIN_NAME, (compilation) => {
    NormalModule.getCompilationHooks(compilation).beforeLoaders.tap(PLUGIN_NAME, (loaders, mod) => {

Is there any possibilities to expose beforeLoader?
This is part of https://github.com/Trinovantes/vue-ssr-assets-plugin that I would like to move into Rspack. Without that this cannot be done.


[Python][FlightRPC]Why does do_put not return results?

Describe the usage question you have. Please include as many useful details as  possible.
When I use do put, the server writes data, but the client can only read none. Why?
pyarrow version == 9.0.0
Logs:
# server
2023-05-22 12:15:57.491 | INFO     | __main__:__init__:13 - server init: grpc+tcp://localhost:5555
2023-05-22 12:16:18.571 | ERROR    | __main__:do_put:25 - do put: cmd b'xxx', data size: 10 4, 0 MB, column names: ['col_0', 'col_1', 'col_2', 'col_3']
2023-05-22 12:16:18.571 | ERROR    | __main__:do_put:29 - write success

# client
create_table cost 0.0004131793975830078 s
result = None
result = None
result = None
result = None
result = None
result = None
result = None

Server Code:
import struct

import pyarrow
from pyarrow import flight
from pyarrow.flight import FlightServerBase

from loguru import logger

class FlightRpcListener(FlightServerBase):
    def __init__(self, host, port):
        super().__init__(self._make_location(host, port))
        logger.info(f'server init: {self._make_location(host, port)}')

    @classmethod
    def _make_location(cls, host: str, port: int) -> str:
        return 'grpc+tcp://' + host + ':' + str(port)

    def do_put(self, context, descriptor, reader, writer):
        if descriptor.descriptor_type != flight.DescriptorType.CMD:
            raise pyarrow.ArrowInvalid("Must provide a command descriptor")

        cmd: str = descriptor.command
        table: pyarrow.Table = reader.read_all()
        logger.error(f'do put: cmd {cmd}, data size: {table.num_rows} {table.num_columns}, '
                     f'{table.nbytes // (1024 ** 2)} MB, column names: {table.column_names}')

        writer.write(struct.pack('<i', 1000))
        logger.error('write success')

server = FlightRpcListener(host='localhost', port=5555)
server.serve()

Client  Code:
# -*- coding: UTF-8 -*-
import time

import numpy as np
import pyarrow
from pyarrow import flight

def create_table(n_rows, n_cols):
    start = time.time()
    table = pyarrow.Table.from_pydict({f'col_{c}': np.random.randint(0, 100, size=[n_rows]) for c in range(n_cols)})
    print(f'create_table cost {time.time() - start} s')
    return table

def create_client(port):
    return pyarrow.flight.FlightClient(f'grpc+tcp://localhost:{port}')

def run(cli, data):
    writer, reader = cli.do_put(
        flight.FlightDescriptor.for_command('xxx'),
        data.schema)
    writer.write_table(data)
    writer.close()

    while True:
        print(f'result = {reader.read()}')
        time.sleep(1)

def start_write_stream(cli):
    data = create_table(10, 4)
    run(cli, data)

if __name__ == '__main__':
    client = create_client(5555)
    start_write_stream(client)

Component(s)
FlightRPC, Python

writer.close closes both halves of the connection (yes, this is confusing). You probably want writer.done_writing instead. This should work:
    with writer:
        writer.write_table(data)
        writer.done_writing()
        print(f'result = {reader.read()}')

Thank you for your advice. It does work.


Fix enablement path for CNI

Fixes https://github.com/istio/istio/issues/18644

@ostromart: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
7005365da584a81b7217ea87b3190c0cc693df9b
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
7005365da584a81b7217ea87b3190c0cc693df9b
link
/test gencheck_operator

test_operator
7005365da584a81b7217ea87b3190c0cc693df9b
link
/test test_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
7005365da584a81b7217ea87b3190c0cc693df9b
link
/test gencheck_operator

test_operator
7005365da584a81b7217ea87b3190c0cc693df9b
link
/test test_operator

e2e_operator
7005365da584a81b7217ea87b3190c0cc693df9b
link
/test e2e_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

In response to a cherrypick label: #522 failed to apply on top of branch "release-1.4":
Using index info to reconstruct a base tree...
M	cmd/mesh/testdata/manifest-generate/output/all_on.yaml
M	cmd/mesh/testdata/manifest-generate/output/flag_output_set_values.yaml
M	cmd/mesh/testdata/manifest-generate/output/flag_set_values.yaml
M	cmd/mesh/testdata/profile-dump/output/all_off.yaml
M	cmd/mesh/testdata/profile-dump/output/demo-auth_certmanager_on.yaml
M	cmd/mesh/testdata/profile-dump/output/sds_policy_off.yaml
M	data/profiles/default.yaml
M	pkg/vfs/assets.gen.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/vfs/assets.gen.go
CONFLICT (content): Merge conflict in pkg/vfs/assets.gen.go
Auto-merging data/profiles/default.yaml
Auto-merging cmd/mesh/testdata/profile-dump/output/sds_policy_off.yaml
Auto-merging cmd/mesh/testdata/profile-dump/output/demo-auth_certmanager_on.yaml
Auto-merging cmd/mesh/testdata/profile-dump/output/all_off.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/flag_set_values.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/flag_set_values.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/flag_output_set_values.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/flag_output_set_values.yaml
Auto-merging cmd/mesh/testdata/manifest-generate/output/all_on.yaml
CONFLICT (content): Merge conflict in cmd/mesh/testdata/manifest-generate/output/all_on.yaml
error: Failed to merge in the changes.
Patch failed at 0001 Fix enablement path for CNI


fix: set default dark theme if theme options is like dark

Types

[x] 🐛 Bug Fixes

Background or solution
fix #1398
Changelog

/publish


Lab 08, Exercise 3, Task 2 - Typo

In steps 1 and 2, replace:
Get-AzResourceGroup -Name 'az800l08*'

With
Get-AzResourceGroup -Name 'AZ800-L08*'

This has now been fixed. Thank you.


[v2] f7-range not working

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: 2.0.8

Framework7-Vue Version: 2.0.7

Platform and Target: webbrowser, but same error exists on vue-f7-webbrick-cordova app

Live Link or JSFiddle: reproducable using Official Starter Templates (I used https://github.com/framework7io/framework7-template-vue-webpack)

What you did
Use the default app from https://github.com/framework7io/framework7-template-vue-webpack. Start dev server and try the slider on the form page.
Expected Behavior
Slider changes
Actual Behavior
On firefox, the slider does not move, no error in js console
On chrome the slider does move, but gives js error:
Uncaught TypeError: range.on is not a function
at HTMLDivElement.handleTouchStart (framework7.esm.bundle.js?c501:12119)
at HTMLDivElement.handleEvent (dom7.module.js?d8c4:321)
handleTouchStart @ framework7.esm.bundle.js?c501:12119
handleEvent @ dom7.module.js?d8c4:321

I have updated package.json to use git master for both framework7 and framework7-vue, but the issue is not solved. I get the same error on chrome and the slider is not working in firefox

nolimits4web solved this  in 2.0.10


Fixes for RC 2.0.12

@tronical if possible please take a look at:
6aa6ae6257e18825dff9d303bbd75e4b8533c0ec
4850fb67d61d5c2881e19ba341d97ba01234e23c
We are using the pre-built Docker images from the community Containerfiles: https://github.com/commontorizon/Containerfiles
Let me know if this is ok on your side, thanks in advance.

@tronical if possible please take a look at:
4850fb6
6aa6ae6
We are using the pre-built Docker images from the community Containerfiles: https://github.com/commontorizon/Containerfiles
Let me know if this is ok on your side, thanks in advance.

Thanks for making these changes to improve build times.
Overall this looks good to me.
One detail I noticed is that for the rustSlint SDK configuration, the slint-sdk-XX container is used, which contains Slint compiled for C++ in /usr - as well as the whole cmake/ninja setup. Similarly, the debug image for Rust will contain libslint_cpp.so. I /think/ it should not cause any conflict, but it's something to keep an eye on maybe.
One thing we do need to sort out though is the update process.
I can think of three scenarios:

You update base-version say from 3.0.9-bookworm to 3.10 (I'm making the version up :-). In that case you rebuild the slint-sdk/slint-base images, push them, and then update vscode-torizon-templates. Easy.
We make a new minor or patch release of Slint. We update the release/1 branch and upload a newer Slint to crates.io.
a. For C++, a local build (without docker) will pick up the latest 1.x release through this reference. However builds for Torizon depend on slint-sdk/slint-base being updated. The image version referenced in Dockerfile however does not include a Slint version.
b. For Rust, a local build (without docker) as well as a build for Torizon will pick up the latest minor release (unless the version is pinned in the application's Cargo.toml.).
A new Rust version is released. The slint-sdk/slint-base images should be updated, but existing users won't be able to benefit from updates, and they can't update to a newer version of Rust themselves because they're using slint-sdk/slint-base.

I think the scenario 2.a and 3. are problematic for users. Maybe they want to use a newer version of Slint (it's still a young product, so frequent updates are likely), but they can't. Similarly, Rust is still moving fast (while maintaining compatibility), but users can't update unless they re-create the docker files from the vs code extension.
Those were primary motivations for me for the full-fledged docker file, that is slower to build initially, but in the long term gives more power to users because they can make changes.
One way out would be to extend the version of the slint-sdk and slint-base images to include the slint version and the rust version. It doesn't mean that every combination needs to be built, latest slint release in combination with the rust version that's current at that point would suffice. Combine that with a comment in the docker file that tells users: Hey, if you want to update, this is what you need to change, and perhaps we'd have a flexible solution that doesn't compromise on the speed-up of providing pre-built images.
We can add an item on our TODO list (Slint) to notify you to rebuild the slint-sdk/slint-base images when we make a new release, but you retain control over what Torizon base image to choose, etc.
What do you think?
(cc @ogoffart - Olivier, I can fill you in on the current and the propose mechanism if you're interested)

Ok, a brief chat later, suggestion: Use ${BASE_VERSION}-${SLINT_VERSION} as version for slint-sdk/slint-base and here select the corresponding vX.Y.Z tag instead of the branch. Then add a comment in this repo's Docker files that this selects the slint version and maybe a link to docker hub where people can see what versions are available. Would that make sense?

We can add an item on our TODO list (Slint) to notify you to rebuild the slint-sdk/slint-base images when we make a new release, but you retain control over what Torizon base image to choose, etc.
What do you think?

@tronical I think that would be great to have this notification. As we have our template updater mechanism, I hope that users who want to use the newest versions will be able to do so easily whenever we have a new version of the images.

Ok, a brief chat later, suggestion: Use ${BASE_VERSION}-${SLINT_VERSION} as version for slint-sdk/slint-base and here select the corresponding vX.Y.Z tag instead of the branch. Then add a comment in this repo's Docker files that this selects the slint version and maybe a link to docker hub where people can see what versions are available. Would that make sense?

Totally, I will work on these changes.

Looks good - thanks!


NEWLINES_RULES: fix can cause long lines

Need to think of how we can prevent the creation of long lines by this rule .

Error in WhiteSpaceRule.
in OPERATOR_REFERENCE logic -> KtBinaryExpression


Enforce global lock in oci hooks

See
#3518
#2908
and probably others.
At this point, nerdctl simply cannot be used in any non trivial scenario involving CNI and concurrency.
Besides local context, this started cropping up as soon as I disabled retries on the CI and cranked up parallelism on tests.
The bottom-line MAY be that CNI plugins cannot be used concurrently at all - whether by design or not - this is unconfirmed though.
A "proper" fix is likely very involved - probably rewriting most / all of CNIEnv, or the cni plugins themselves. As floated in the tickets, it is not even clear if separate binaries + ocihooks is a tenable design at all.
Anyhow, this is the best I can think of right now that does not involve too much work: enforce a global lock in hooks. It is a hammer. It will hurt performance, likely. But then the choice is "does not work" vs. "works slowly".
As stated in the comment, it will probably not even cover all cases - but it is better than nothing and will make things a bit more acceptable.
This has been forked out of #3517 which is currently ground zero.

@AkihiroSuda at your convenience.
(pending green)

Failure is the usual TestIPFSComposeUp/stargz


Support determining the style of hyperlinks

Right now hyperlinks are always underlined and it would be nice if it was possible for clients to define the SpanStyle used there.
I understand this goes beyond the scope of replacing Android's Html.fromHtml() API, so I totally understand if it’s also out of the scope of this library. But since this may potentially be a blocker for some people (it would be for me), I thought I would still file this just in case.
I guess the simplest option would be to receive a urlSpanStyle as an argument for AnnotatedStringHtmlHandler. I’m hoping since we’re already receiving the compactMode boolean there, this won’t hurt the API too much.
I’ll open a PR so it hopefully helps discussing about this change. And thanks a lot for open sourcing this ❤

Hello, thank you for your contribution, I didn't expect to receive a pull request so quickly!
I was actually considering the same change, as I prefer my hyperlinks colored and not underlined. However, API-wise, I would prefer to expose a more generic data class as third argument, that will contain more styling customizations, not just the url span style.
I'll publish a new release later today or tomorrow that includes this ability. Thank you!

That's great to hear, thanks! Feel free to close my PR in this case, then ✌

Fixed in version 0.9.0


Add upload step

[x] Add upload view
[x] Add test archive fixture (dataset-0001.zip)
[x] Add tests for the upload view

Coverage remained the same at 100.0% when pulling<PHONE_NUMBER>394d645783a14e80850b5fadf0a73c on add-upload-step into 972614b1a13b641e31a822a454cc745b701ae60d on master.

Coverage remained the same at 100.0% when pulling 4d65506d7a3e92fbb087755a6d308052b4ca72a9 on add-upload-step into 1ea86f479c224fdf06dc4ab0f47ba17a9588d9eb on master.


Feature request: option to "close" partial auras

it would be nice if we could close auras that are not fully around a token.

Would also be nice if we could fill in the aura with color if we wanted.

The fill aspect was asked for in #9, and is on the way.
There's limited space in the UI for any more options, so I have been working on a UI overhaul as time permits, and as Foundry's murky documentation allows.

This is now live with v2.0.0. Enjoy!


Feature #36

Any Field-nested component with an input flag (meaning the input is passed props.input = true) will be passed all of the relevant input props. This allows for plugging in custom input components into a Field. See below:

<Form>
  <Field name="email">
    <CustomEmailInput input /> {/* Passed input props! */}
  </Field>
  <Field name="address">
    <CustomAddressInput /> {/* NOT passed input props! */}
  </Field>
</Form>

Coverage increased (+0.006%) to 99.468% when pulling 62059bcfd5159d45f721a2fbc2f4aa0d46081d8f on feature-#36 into e935952663d26b2198c1a3409c553b18aa5920ea on release-1.2.0.


feat: Add Flagsmith provider

This PR
Adds a library project for Flagsmith provider with implementation and tests
Related Issues
https://github.com/open-feature/dotnet-sdk-contrib/issues/90
https://github.com/Flagsmith/flagsmith-dotnet-client/issues/78
Notes
We are going to use OpenFeature and Flagsmith in our projects. Unfortunately  dotnet-sdk-contrib doesn't have Flagsmith provider, so i implemented it.
Follow-up Tasks

[x] Implement
[x] Add unit tests for general funcations
[x] Add unit tests for using OpenFeature evaluation context
[x] Review from Flagsmith team

How to test
Just create FlagsmithProvider using FlagsmithClient or FlagsmithConfiguration according to https://github.com/Flagsmith/flagsmith-dotnet-client/tree/main/Example

Hey @dabeeeenster, could someone from the Flagsmith team please take a look when you have a moment?

I did thm strange. Sorry. I'll recreate the branch

Recreated here https://github.com/open-feature/dotnet-sdk-contrib/pull/91

@beeme1mr, I've added my review here and I'm happy being added to the component owners, but could you add another one of the Flagsmith team, novakzaballa, as a component owner too please?

Hi @beeme1mr,
Do we need anything else?

I just had one question about the icon, but the rest looks good. @toddbaert, did you have any other concerns?
Before we merge, could you lease update the component_owners.yml to include @matthewelwell, novakzaballa, and yourself?

done

Could you please also add a readme under src/OpenFeature.Contrib.Providers.Flagsmith/? It should have installation instructions and usage examples. Sorry, I didn't notice that it was missing in my last review!

Could you please also add a readme under src/OpenFeature.Contrib.Providers.Flagsmith/? It should have installation instructions and usage examples. Sorry, I didn't notice that it was missing in my last review!

I just copied readme form flagd provider and adapted to Flagsmith provider.

@toddbaert can we complete the PR? :)

@vpetrusevici very nice! I like the delegate implementation. This is a great addition!
I'm approving but you have some minor formatting issues (you should be able to test your fixes with dotnet-format --folder --check). I'll keep an eye on the PR and re-run the checks / merge as soon as they pass.
I added #pragma warning disable format for json in tests. it's strange but dotnet-format tries to fix this string...


Coordinate transformation.

This probably belongs to Bokeh. Is there plan to support coordinate transformation in Glyphs? Namely, for visualizing astronomy data we would like to use an equal area projection. Even the degenerated cylindrical (z=sin(theta)) coordinate will give a much better perception on density of points.
This is probably relevant for geographical data as well.

@rainwoodman, I don't think we have plans to support coordinate projection within datashader itself, but making sure all your input data is in the same coordinate system is important.  Have you tried projecting to equal-area before datashading?

Thanks. I tried this. Is there a way to set the tick labels to the values
before transformation?
On Jun 22, 2016 7:41 AM, "Brendan Collins"<EMAIL_ADDRESS>wrote:

@rainwoodman https://github.com/rainwoodman, I don't think we have
plans to support coordinate projection within datashader itself, but making
sure all your input data is in the same coordinate system is important.
Have you tried projecting to equal-area before datashading?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/bokeh/datashader/issues/175#issuecomment-227765939,
or mute the thread
https://github.com/notifications/unsubscribe/AAIbTINjo24Behc1app-LMzn8tJPuYJ3ks5qOUmzgaJpZM4I7jCW
.

The imminent bokeh release (0.12) does allow that, using a custom tick formatter implemented in https://github.com/bokeh/bokeh/pull/4504 .  There is a release candidate on the dev channel that includes that support, and the real release will be very soon now.

Yes. It will be cool to try it out then. Shall I close this issue?

I'll close it, thanks!


Create unapec

https://unapec.edu.do
https://unapec.edu.do/academia/programas-de-grado/?cat=tec

@raimymejia I am sorry, the domain unapec.edu.do is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


[KYUUBI #5795][FOLLOWUP] Using correct time unit for pod cleanup executor

:mag: Description
Issue References 🔗

https://github.com/apache/kyuubi/blob/a0fdead6d257be54127d84f526918e4fd52a18ce/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala#L1234-L1241
The timeunit should be millsecond not minute here.
And using ThreadUtils.scheduleTolerableRunnableWithFixedDelay to prevent unexpected issue.
Describe Your Solution 🔧
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklists
📝 Author Self Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

[ ] Pull request title is okay.
[ ] No license issues.
[ ] Milestone correctly set?
[ ] Test coverage is ok
[ ] Assignees are selected.
[ ] Minimum number of approvals
[ ] No changes are requested

Be nice. Be informative.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a0fdead) 61.28% compared to head (910e725) 61.20%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5858      +/-   ##
============================================
- Coverage     61.28%   61.20%   -0.08%
  Complexity       23       23
============================================
  Files           609      609
  Lines         36282    36283       +1
  Branches       4976     4976
============================================
- Hits          22235    22208      -27
- Misses        11655    11675      +20
- Partials       2392     2400       +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thanks, merged to branch-1.8


chore: refactor controllers

Removes PermissionsService and adds ControllerService

@im-adithya @bumi I feel like we unfortunately went a bit backwards on this PR.
I suggest we make the minimal change to create a common interface for the controller methods and then consider the other stuff as a follow-up. Does that sound ok?

@im-adithya I talked with @bumi  and we thought for now it's not worthwhile to make this change as it's opening up some other issues (as per the comments). For now we'd like to close this one and focus on some more other things (changing the authentication to not use a session cookie for example). I will create a new issue keep track of this though and link to this PR.


Node naming convention?

When first working on this module, I didn't give much thought how nodes should be named. If it would be an improvement to change the naming scheme, it should happen as soon as possible.
Right now everything is prefixed with "Box2D".
Pros:

It's very clear and obvious

Cons:

It makes bulky names bulkier, such as Box2DPrismaticJoint and Box2DPhysicsBody.
it takes 0.2 seconds longer to type than I'd like and is annoying for my left hand because I never use right-shift

Another idea is to use the prefix "B2".
Pros:

it's shorter and more concise
feels a bit more sleek and cool 😎
my left hand's quality of life improves by an amount that may or may not be within the margin of error for measuring "hand quality of life"

Cons:

?
effort
might be prone to confusion between, say, B2Joint and b2Joint

Other ideas are welcome.
I should note: Switching names should not be too difficult for existing projects. Doing a find/replace from "Box2D" to "B2"/whatever in each .tscn file should do the trick.
I'm serious enough about this issue that I'll make a name change if it's actually a good idea, but it's also unimportant enough that a singular thumb down might close this.

i'm fine with whatever, but the prefix is nice right now because i can regex on box2d* and find all box2d godot code.  b2* gives me all the thirdparty box2d src.
Maybe B2D as the godot prefix?   Pro - it still has '2D' in the name which most other 2D nodes have as well.

I think I'll stick to keeping the naming as-is. While I genuinely dislike the bulk of "Box2D", I think it's the best option. There aren't many naming variations to choose from.


Support Epoller to forward oom score notifications.

I investigated https://github.com/google/gvisor/issues/2433 .
We probably can forward oom score notifications by using oom.Epoller (this is in the containerd/pkg/oom package) like runc's shim.
・https://github.com/containerd/containerd/blob/master/runtime/v2/runc/v2/service.go#L76-L80
・https://github.com/containerd/containerd/blob/master/runtime/v2/runc/v2/service.go#L334-L336
While oom.Epoller is supported on containerd v1.3 ,  gvisor-containerd-shim depends on containerd v1.2 and there are several other changes we have to follow between v1.2 and v1.3.
Can we move to v1.2 to v1.3? Or should we use v1.2 and implement Epoller like runc's shim?
To: @ianlewis

Yeah, that's what I suspected would be the right way for it to work as well. I'm looking at upgrading packages from containerd 1.3 but some e2e tests fail. See #55

I posted on the PR but it looks like we'll have to stick with using packages from containerd 1.2 if we want to maintain compatibility with 1.2. Containerd seems to maintain backwards compatibility with shims built from previous versions but isn't forwards compatible with shims built from later versions.
https://github.com/google/gvisor-containerd-shim/pull/55#issuecomment-616934492
It looks like we'll need to copy the code from epoll.go for the time being.
https://github.com/containerd/containerd/blob/release/1.2/runtime/v2/runc/epoll.go

it looks like we'll have to stick with using packages from containerd 1.2 if we want to maintain compatibility with 1.2
It looks like we'll need to copy the code from epoll.go for the time being.
That makes sense. Thanks!


Replace icons for drug and disease profile pages

We will need an icon consistent with the DNA helix shown in the target profile page that could be used for drug summary page and disease profile page.

New icons have been created using the Medicine (Line) collection to ensure consistency in design and icon weight.

Target icon
Disease icon
Drug icon
Associations icon

@d0choa @andrewhercules The icons for the target, drug, and disease page have been update. You can check them out here: https://platform-app.netlify.com

Based on yesterday's front-end meeting, I have updated the disease icon to a stethoscope to account for the phenotypes and measurements we include in the Platform.

New disease icon

Disease icon has been updated.


Bugfix null pointer on plugin version collision

Is an error actually the right way to proceed, or should we warn and rename the file?

As discussed, @dankwart-de, this can be merged after update to current devel.


Use canonical import path for libvirt

What this PR does / why we need it:
Switches the import path for libvirt from the GitHub mirror to the canonical vanity import path (libvirt.org/libvirt-go).
Special notes for your reviewer:
Assuming I've done everything correctly, this PR should introduce no functional changes.
Release note:

NONE

/retest
/lgtm
/approve
/hold
Looks good, please feel free to unhold whenever you're ready.

Looks good, please feel free to unhold whenever you're ready.

@danielBelenky can you expand a bit on that? The PR is ready as far as I'm concerned, and I've never had to unhold a PR before - I'm not even sure if I have the appropriate permissions. Am I missing some process-related requirement?

/hold cancel

@andreabolognani you should have the permission. the hold command is useful for cases where you want to block the merge on approved PRs for some time. This allows authors to move the PR forward without a maintainer looking at the PR again (who for whatever reason thought that it may not yet be ok for  the author to move forward with it). Other cases are that some minor changes are still discussed where the maintainer is already happy with the code, but wants to give contributors the chance to finish the discussion on them. Here the hold can again be removed from the people on the discussion without the need for a maintainer. Cases like this basically.

@rmohr this mostly makes sense to me but it sure is different from how things are done in other projects I contribute to, so it will probably take me a while to wrap my head around it... In the meantime, thanks for the explanation and for being around to help shepherd my patches through :)


Fix right sidebar to scroll with main page

This addresses the first item. It makes the right sidebar headings list to scroll along with the main page.
I removed isScrollToCurrentHeadingHappened logic. Not sure what the intention of this was, but it was causing the sidebar to only scroll once and not every time the current heading in the main page changed.
scrollIntoView had some weird behavior so I am setting scrollTop instead.

Thanks! Looks good from quickly trying on https://dvc-org-sidebar-scroll--pwaktw.herokuapp.com/doc/command-reference/remote/modify#available-parameters-per-storage-type. Idk about the implementation details but will ask someone else to please check that 🙂

Per @shcheklein I need this PR to be in a private clone, so I am closing this PR.


New version JWAS: 0.5.4

Registering: JWAS
Repository: https://github.com/reworkhow/JWAS.jl
Version: v0.5.4
Commit: dc8efa9cde657ee2d3db9ce8621b0e81dd41be3c
Proposed by: @reworkhow
Reviewed by: @reworkhow
Reference: https://github.com/reworkhow/JWAS.jl/commit/dc8efa9cde657ee2d3db9ce8621b0e81dd41be3c#commitcomment-33348821

Please add some compatibility constraints on julia and your other deps:
[compat]
julia = "1"
...

see https://julialang.github.io/Pkg.jl/v1/compatibility/

compatibility constraints is added.

@fredrikekre


Drops release candidate from MODULE_VERSION

Description
MODULE_VERSION now set to 2.0.0 in preparation for release.
Checklist

[ ] Investigated and inspected CI test results

If any of these don't apply, please comment below.
Testing Performed
2.0.0-rc2 has been tested thoroughly in collector itself and alongside the main product.

Test failures are from an old build of MODULE_VERSION 2.0.0, which did not contain the fix for the process arguments. We'll need to bump the cache when we merge to ensure that the probes are rebuilt.


support for ViewController dependency Injection ?

Any support for viewController dependency injection ?
extension UIStoryboard {

    @available(iOS 13.0, tvOS 13.0, *)
    public func instantiateInitialViewController<ViewController>(creator: ((NSCoder) -> ViewController?)? = nil) -> ViewController? where ViewController : UIViewController

    @available(iOS 13.0, tvOS 13.0, *)
    public func instantiateViewController<ViewController>(identifier: String, creator: ((NSCoder) -> ViewController?)? = nil) -> ViewController where ViewController : UIViewController
}

This feature doesn't exist yet. This is the issue tracking this feature request: https://github.com/mac-cain13/R.swift/issues/569


Basic Sema support for covariant collection casting.

What's in this pull request?

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

The previous revert was required because of missing stdlib support.
I believe that support is now present, at least so that this won't
crash on Linux.

@swift-ci Please test and merge.

@rjmccall , this is dead, right?

Yes, I think I merged this manually.


add more python versions as tests

Coverage remained the same at 89.793% when pulling b34a6649d9631cdb563996a1a6f0c436440bf81d on travisimprovement into ddf91d13cc9931a6b33b43802b95f349bb813f37 on master.

Coverage remained the same at 89.793% when pulling 62bc99d63c10ce2796eab137fcb752b26e809881 on travisimprovement into ddf91d13cc9931a6b33b43802b95f349bb813f37 on master.

Coverage remained the same at 89.793% when pulling 62bc99d63c10ce2796eab137fcb752b26e809881 on travisimprovement into ddf91d13cc9931a6b33b43802b95f349bb813f37 on master.

Coverage decreased (-89.8%) to 0.0% when pulling f547651528daed346d670a0077d021a01e8fcda4 on travisimprovement into ddf91d13cc9931a6b33b43802b95f349bb813f37 on master.

Coverage decreased (-89.8%) to 0.0% when pulling 42491597d49e9c795e25a462105d60d937767c72 on travisimprovement into ddf91d13cc9931a6b33b43802b95f349bb813f37 on master.

Coverage remained the same at 89.793% when pulling 8dd5a8ee7cc06d9b874c117ca95180e8a9cf4483 on travisimprovement into ddf91d13cc9931a6b33b43802b95f349bb813f37 on master.


⚠ Avatar API Endpoint has degraded performance

In a8e3a20, Avatar API Endpoint (https://avatar.roblox.com/v1/avatar-rules) experienced degraded performance:

HTTP code: 200
Response time: 5176 ms

Resolved: Avatar API Endpoint performance has improved in c786073 after 7 minutes.


Replace 'accounts.Puzzler' with get_user_model()

ForeignKey/ManyToManyFields in other app Models are more generalized and
scalable this way.

This is just a simple cleanup :broom:


Initial AuctionSuperApp and claim tests

Initial implementation and testing of AuctionSuperApp
Includes test cases for claiming and should unblock #37
I've created a v1 branch as the main branch to capture the new Superfluid and auction design.

@brossetti1 I added solidity-coverage awhile back. The coverage results are currently being included in the repo, but maybe they shouldn't? We could ignore coverage results and just have a separate branch that generates them from a CI action or something?


Support offline doc generation

What's new

Scripts for generating docs included as static files
copies scripts into static directory before runs

Self-checks

[ ] I have prototyped this new feature (if necessary) on Figma
[ ] I'm familiar with and follow this Typescript guideline
[ ] I added unit-tests for new components
[ ] I tried testing edge cases
[ ] I tested the behavior of the components that interact with the backend, with an e2e test

I've refactored our static file usage to be cache instead, most of them were name changes. The real static files to be used are placed in the hardcoded static directory, that is not configurable.

Just tested without network access and it looks good so far


Instructios for Windows users

Windows users must to add / at beginning of MOUNT variables to can run commands outside container.

Sadly, this will not work as expected.
Using pwd inside a funcion is the only way of making the aliases folder agnostic.
The way proposed here, you would need to source the file each time you change the directories.
Perhaps another approach for windows or a separated windows version of the scripts would do the trick.
I don't actually have a windows machine for testing. And I know there are several docker issues related with windows.
I'll let this to the community but I will never sacrifice Linux users habilities (and when possible mac users) in face of making it windows compatible.
I'm not against it. just make it separated files if possible, so windows don't slow other systems down.
Thanks for the contribution anyway, I hope you can contribute a windows separated file that works for windows users, just don't change on the linux versions.