Backport swift 3.0 code coverage fixes to swift 2.3

What's in this pull request?
This PR backports several swift 3.0 code coverage fixes to swift 2.3.
Resolved bug number: (SR-1850)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci Please test

@swift-ci smoke test OS X platform

I forwarded compiler-rt/swift-3.0-branch to compiler-rt/swift-2.3-branch.

@swift-ci smoke test OS X platform

The build preset the bot wants to use doesn't exist in 2.3. I've backported a few changes to swift/utils/build-presets.ini and am testing them locally. I'll update the PR once that's done.

@swift-ci smoke test OS X platform

@tkremenek Is this good to merge, or does the code coverage backporting effort need more discussion?

@vedantk sorry, I was (am) on vacation.  I'll merge now.

Thanks for taking a look at this while you were away :).


cmd/go: no Module information in list -e output after any error loading package

What version of Go are you using (go version)?

$ go version
go version devel +0cb3415154 Tue Feb 16 02:07:02 2021 +0000 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/myitcv/gostuff/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel +0cb3415154 Tue Feb 16 02:07:02 2021 +0000"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/tmp/tmp.MFFZzggPNu/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build741706514=/tmp/go-build -gno-record-gcc-switches"

What did you do?
go list -e -f {{.Module}}

-- blah.go --
package blah

import _ "embed"

//go:embed README.md
var readme string
-- go.mod --
module mod.com

go 1.16

What did you expect to see?
mod.com

What did you see instead?
<nil>

This has implications for users of go list, i.e. go/packages.

In cmd/go/internal/load.Package.load, it looks like we don't populate the Module field if there was any error loading the package. For example, if a blah.c file is present but the package doesn't use cgo or swig, the Error field is populated but the Module field is not.
I don't think anything prevents us from populated the Module field here.

Hey @jayconrod , I would like to help out to fix this issue. How should I proceed?

Hey @jayconrod , I would like to help out to fix this issue. How should I proceed? Thanks :)

@sidntrivedi012 Your help is most welcome.
I think this can be fixed in pkg.go by moving this block up to right after we push the import path on the stack.
Please make sure to add a regression test in src/cmd/go/testdata/script. There's a README there that explains the format.

I can take this one up if this in the backlog. @jayconrod  Please feel free to assign this one to me. 🙏🏽

Hey @supriya-premkumar , I got somewhat stuck in the weekdays so couldn't get the bandwidth to work on it.
I am planning to write a patch for it in this weekend. Will surely comment here to assign it to you if I fail to triage it.
Thanks 😃

Hey @supriya-premkumar , I got somewhat stuck in the weekdays so couldn't get the bandwidth to work on it.
I am planning to write a patch for it in this weekend. Will surely comment here to assign it to you if I fail to triage it.
Thanks 😃

No worries at all. Go for it!


Math Magicians: React setup

[ ] Set up a React app.
[ ] Use React documentation.
[ ] used the correct Gitflow.

@Owusu-Desmond
Thank you for the Reminder and Feedback.


bevy-rust-gpu: Missing entrypoint system configurability

Currently, the path to the entrypoint file is hardcoded, and all materials send entrypoint info to the same place.
Need to refactor to allow multiple entrypoint files, and allow each material to specify which one it will write to (i.e. by giving it the appropriate SyncSender)

Done.


Simd.js Asm.js : Disable Float64x2 and remove SIMD ops not in the spec

These are the items on our asm.js/simd.js spring cleaning list:

[x] Disable Float64x2 and FromFloat64x2 opcodes
[x] Remove "and, or, xor, not" for float32x4 type
[x] Remove "min/max" for integral types
[x] Remove/clean-up unit tests
[ ]  Get a go from MSFT
[ ] lunch?

Actual Output:
Not Available

Expected Output:
Not Available

We'll be submitting a PR shortly

@abchatra , please confirm this is OK for release/1.2, and label accordingly. If we don't have it, then some currently unsupported data types/ops will be exposed in the library along with unused implementation code.

@nmostafa ; Arun @arunetm raised an issue that we might need a negative test case in issue's description? Kindly advise if the testcase is indeed needed and what other corrections I should make to the description.

@nmostafa I am ok with cleanup if this doesn't impact anything other than SIMD code. It is a bit late in the cycle for general cleanup. Also, why can't this be merged into master instead of 1.2?

The cleanup touches only SIMD code, and it is low risk in my opinion. The only issue I see from merging to master is that we will be shipping currently unsupported SIMD types and operations (removed from spec or postponed to phase 2). So we should at least disable those in JavascriptLibrary and AsmJs validation.

Ok sure. I have marked it 1.2


Add required prop to Input, TextField, SelectField, and DateField

#308  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @techniq and the rest of your teammates on  Graphite


Files served from wrong directory.

I created a new container called test and stopped the original one created by wocker.
When I run wocker ps it shows that I am running the test container.
However when I visit http://wocker.dev the files from the original wocker container are still being served.
Any changes I make to files within the test container are not showing up in the browser. In fact I can delete the entire wordpress installation with out any change.
Did I miss some step along the way?

Did you create a new container before stopping the original one?
You have to stop the running container before creating or starting another.
If you stop a container, the name of the directory will be changed from wordpress to ID_CONTAINERNAME, and you can find them in your local data directory.
After you stop a container, if you enter $ wocker run --name test, a new wordpress directory and container will be created. Make change here. Again, $ wocker stop test will move wordpress directory to ID_test.
When you restart a container using a Wocker command e.g. $ wocker start test, ID_test will be taken back to wordpress.

Okay got it. When I create a container it is named ID_CONTAINERNAME when I run that container the directory is changed to wordpress
So the current live directory will always be named wordpress. Then when I stop a container it reverts back to its ID_CONTAINERNAME
It all makes sense.

Exactly.


Clearing cache on a per-site basis?

In order to clear cache, one can: bin/grav clear-cache. I wonder what's the implication for a multi-site scenario: when multiple sites are present, does the command clear the cache for all the sites? If so, is it possible to clear the cache for just any particular site?

The CLI commands are not really multisite aware.  They need to be refactored to support multisite.

Right. Thanks for pointing that out.
What about the API/programatic side? Can one call a function in PHP like:
clearCache('subdomain.domain.com');
to clear the cache for site subdomain.domain.com?
This will be useful in the multi-tenant scenario, where after any tenant has edited their docs, we clear the cache for that particular tenant only, while not affecting other tenants' cache.

I'm hitting this too in combination of this and

https://github.com/getgrav/grav/issues/1314
https://github.com/getgrav/grav/issues/1660 and https://github.com/getgrav/grav/issues/2846

As in https://github.com/getgrav/grav/issues/1314, I want to listen on the onBeforeCacheClear event which is triggered on web-based cache-clear but also on ./bin/grav clearcache
As in https://github.com/getgrav/grav/issues/1660 and https://github.com/getgrav/grav/issues/2846, I'm in a multisite context.
Consequence: The theme and plugins are not loaded when running ./bin/grav clearcache and consequently, their event-listeners are not triggered.


Fare expired

Hey,
I have kinda weird problem, I'm using the widget from this sdk in the following way:
let behavior = RideRequestViewRequestingBehavior(presentingViewController: self)
let dropOff = CLLocation(latitude: event.coordinate.latitude,
    longitude: event.coordinate.longitude)

let parameters = RideParametersBuilder().setDropoffLocation(dropOff).build()

behavior.requestRide(parameters)

but for some reason, in doesn't work as expected in the USA. When I select uberPool and request a ride, popup appears with "fare expired" message. However when I request uberX, it works just fine.
Even weirder is that it works in Czech republic even with uberPool.
Is there any reason for this message, is this expected behavior? Because it doesn't look like it.
I read somewhere that it may be related to "surging".

Hi @Xioshock thanks for the report! Your intuition was correct, this is not the expected behavior. We are working to fix this on our side, no SDK update or changes will be required for your app. I'll update this thread when it has been fixed.

This issue should now be resolved. No updates to the SDK are necessary


fix: 3d_columns example

Using:
bevy = "0.10.1"
hexx = "0.5.3"
Rust version 1.67.0

The .collect() is required to get a Vec. Does it compile on your computer ?

The .collect() is required to get a Vec. Does it compile on your computer ?

Yes, it only compiles when I remove .collect()

Oh, I bet this is a main vs latest situation again. I bet the API has changed since the last release.

Oh, Gotcha! I thought it was the other way around, thought I was updating the code to run on the latest API version. My bad!

Yes, I managed to get Hex::ring to return an iterator instead of a Vec in #68
Theses changes are in the unreleased section of the changelog, the 0.6.0 should release soon


can you upload the paper?

Thank you for the open source code, but I can't find the paper you mentioned in README file, so can you upload the paper?

Hi!
Thank you for the interest, but the paper is yet to be published. I can let
you know when the paper is published with the link if you'd like.
On Mon, 24 Aug 2020 at 15:03, lslynf<EMAIL_ADDRESS>wrote:

Thank you for the open source code, but I can't find the paper you
mentioned in README file, so can you upload the paper?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rootskar/EEGMotorImagery/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH5IOH3GAHPQQV3G33RGBWDSCJJKNANCNFSM4QJNQW5A
.

Thank you for the open source code, but I can't find the paper you mentioned in README file, so can you upload the paper?

The paper has now been published and is available at https://www.mdpi.com/2073-431X/9/3/72


TypeError: '<' not supported between instances of 'int' and 'bytes'

Tested with python3.8, it throws this error:
[dani@tool bcm-cfedump]$ python -m bcm_cfedump -D /dev/ttyUSB0 -O nand.img -t 0.02 nand

Waiting for a prompt...

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 193, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/bcm-cfedump/bcm-cfedump/bcm_cfedump.py", line 477, in <module>
    main()
  File "/bcm-cfedump/bcm-cfedump/bcm_cfedump.py", line 457, in main
    c.wait_for_prompt()
  File "/bcm-cfedump/bcm-cfedump/bcm_cfedump.py", line 328, in wait_for_prompt
    self._read(b"\r\n")
  File "/bcm-cfedump/bcm_cfedump.py", line 314, in _read
    return self.ser.read(*a, **kw)
  File "/usr/lib/python3.8/site-packages/serial/serialposix.py", line 481, in read
    while len(read) < size:
TypeError: '<' not supported between instances of 'int' and 'bytes'
[dani@tool bcm-cfedump]$

However the commit 6d61613a175b229e11fb20eddfbe4480c337cbb7 works ok

Hi, it looks like the serial library changed their API https://github.com/Depau/bcm-cfedump/blob/master/bcm_cfedump.py#L328
I can't test it, if you can send a pull request it would be great.

What version of pyserial did you use when this was written? I'm hoping a quick fix would be to use that version instead.

What version of pyserial did you use when this was written? I'm hoping a quick fix would be to use that version instead.
try my commits in my forked branch.
my python version: 3.6
pyserial version: latest release (for this moment 2020/11/18)

Hi!
I've got python 3.9 & pyserial 3.4 and get the same error:
`$ python3 bcm_cfedump.py -D /dev/ttyUSB0 -O nand.bin -t 0.01 nand
Waiting for a prompt...
Traceback (most recent call last):
File "/home/../02_MEGASync/Systèmes/Routers/bcm-cfedump-master/bcm_cfedump.py", line 478, in
main()
File "/home/../02_MEGASync/Systèmes/Routers/bcm-cfedump-master/bcm_cfedump.py", line 458, in main
c.wait_for_prompt()
File "/home/../02_MEGASync/Systèmes/Routers/bcm-cfedump-master/bcm_cfedump.py", line 329, in wait_for_prompt
self._read(b"\r\n")
File "/home/../02_MEGASync/Systèmes/Routers/bcm-cfedump-master/bcm_cfedump.py", line 315, in _read
return self.ser.read(*a, **kw)
File "/home/../.local/lib/python3.9/site-packages/serial/serialposix.py", line 563, in read
while len(read) < size:
TypeError: '<' not supported between instances of 'int' and 'bytes'
`
... and i'm trying to follow this conversation of yours to try to solve my issue https://github.com/Depau/bcm-cfedump/pull/3 .
Am I on the right track?

I already said
I can't test it, if you can send a pull request it would be great

Ok, let me try it. Be patient.

What version of pyserial did you use when this was written? I'm hoping a quick fix would be to use that version instead.

try my commits in my forked branch. tested with ASUS AC86U in CFE console (MX30LF2G18AC 256MB flash).
i'll make a PR later.
my python version: 3.6
pyserial version: latest release (for this moment 2020/11/18)
use "nand" command to dump memory, the nand_bulk still has problem it can't work correctly.
ps. Dumpping over serial console is really slow. It took 37hr for a 256MB nand flash in 1.2Bytes/s avg speed with 115200 bps baudrate

Already created a virtual environment with python36 and current pyserial version 3.5 and no dice. Same error.
Let me keep trying.

What version of pyserial did you use when this was written? I'm hoping a quick fix would be to use that version instead.

try my commits in my forked branch. tested with ASUS AC86U in CFE console (MX30LF2G18AC 256MB flash).
i'll make a PR later.
my python version: 3.6
pyserial version: latest release (for this moment 2020/11/18)
use "nand" command to dump memory, the nand_bulk still has problem it can't work correctly.
ps. Dumpping over serial console is really slow. It took 37hr for a 256MB nand flash in 1.2Bytes/s avg speed with 115200 bps baudrate

Already created a virtual environment with python36 and current pyserial version 3.5 and no dice. Same error.
Let me keep trying.

Does the pull request i made not working for u ?
https://github.com/Depau/bcm-cfedump/pull/3

Please lmk if merging #3 fixes it.

I hadn't tried it... what was I thinking?
I just did. It does solve the "int and bytes" issue... but i'm not sure this is the result we are expecting:

$ python ./bcm-cfedump-master-hpo14/bcm-cfedump-master/bcm_cfedump.py -D /dev/ttyUSB0 -O nand.img -t 0.01 nand

Waiting for a prompt...
Error caused by line: '**Exception 32: EPC=80A4BB28, Cause=0000801C (BusErrWr )'
Block 0 page 0 read failed, retrying.
Traceback (most recent call last):
File "./bcm-cfedump-master-hpo14/bcm-cfedump-master/bcm_cfedump.py", line 280, in read_pages
yield self.read_page(block, page)
File "./bcm-cfedump-master-hpo14/bcm-cfedump-master/bcm_cfedump.py", line 261, in read_page
addr, buf_temp = parse_serial_line(line.decode())
File "./bcm-cfedump-master-hpo14/bcm-cfedump-master/bcm_cfedump.py", line 30, in parse_serial_line
addr = int(m.group('addr'), 16)
AttributeError: 'NoneType' object has no attribute 'group'
[this las three 'File' lines  repeats itself eight times.]


Dynamic selector

There's a need for a catch-all Dynamic selector, that matches any message in the process' mailbox to handle cases where it receives a non-tuple message.

For sure. Thank you

This has been released, see the selecting_anything function


Error Cannot find module '.\bin\test-server.js' while run yarn start

Purpose: run examples of this project
Steps

Clone the repo (master branch)
Run command: yarn
Run command: yarn start

At step 3: It throw error
D:\Develop\hapi-swagger (master -> origin<EMAIL_ADDRESS>λ yarn start
yarn run v1.15.2
$ node ./node_modules./bin/test-server.js
internal/modules/cjs/loader.js:584
    throw err;
    ^

Error: Cannot find module 'D:\Develop\hapi-swagger\node_modules.\bin\test-server.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:582:15)
    at Function.Module._load (internal/modules/cjs/loader.js:508:25)
    at Function.Module.runMain (internal/modules/cjs/loader.js:754:12)
    at startup (internal/bootstrap/node.js:283:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:622:3)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I'm not sure this is an issue or not. Please guide me how to play around with this project.
Many thanks,

It appears there used to be a folder called .bin with an example server for npm start back in 6.x: https://github.com/glennjones/hapi-swagger/tree/v6.2.1
I'll add back.


Display loglevel panic when docker --help

- What I did
There is no panic loglevel displayed when docker --help  excuted.

-l, --log-level string   Set the logging level ("debug", "info", "warn", "error", "fatal") (default "info")

- How I did it
to add panic level

eg:
flags.StringVarP(&commonOpts.LogLevel, "log-level", "l", "info", "Set the logging level ("debug", "info", "warn", "error", "fatal", "panic")")

- How to verify it

#docker --help
-l, --log-level string   Set the logging level ("debug", "info", "warn", "error", "fatal", "panic") (default "info")

Signed-off-by: chchliang<EMAIL_ADDRESS>

I'm not sure this is useful, because it logs nothing at all until it panics

ping

I agree with @AkihiroSuda; I don't think we need to mention this, as it isn't really useful. Feel free to comment though if you have a specific use for this


 I tried getting the local dev machinery set up, but ran into a bunch of issues... in looking into said issues, I found some of them had been fixed by newer versions.
This PR just gets to a happier dependency/setup place so that subsequent PRs aren't quite as involved.
Changes

[x] bump up blockly to 9

[x] uses much improved, first-class upstream typings, less (Partial)JSONObject
[x] add name to theme

[x] bump many dev dependencies, notably:

[x] @jupyterlab/builder to avoid verdaccio, etc.
[x] lerna (5.x not supported anymore)
[x] use jlpm all over

[x] remove extra yarn
[x] remove extra run in commands
[x] add yarn-deduplicate

[x] typescript just because
[x] update tsconfigs a bit

[x] target: es2018
[x] use references for single watch

[x] bump up binder python

[x] default's 3.10 anyway, now

[x] pin jupyterlite==0.1.0b18 (it's going to get a bit bumpy for a sec)

Thank you so much, @bollwyvl!

Well, I don't know what releaser is going on about, or why it's npm packing a private package. But otherwise, this seems pretty ready to go to get on to other work.

Well, I don't know what releaser is going on about, or why it's npm packing a private package. But otherwise, this seems pretty ready to go to get on to other work.

Yes, I looked a little bit at the PR, and it looks good. Thanks, @bollwyvl.
Don't worry about the releaser; I'll take a look at that.


[local_auth] App throws Required security features not enabled PlatformException

Description
A Java-based project throws Required security features not enabled PlatformException while Kotlin based project works when using the latest local_auth: ^1.1.4 using official sample
Edit
Happens with Kotlin as well https://github.com/flutter/flutter/issues/80352
Note
Make sure you've all the security and biometrics features enabled, fingerprint registered on the device/emulator before reproducing the issue.
Edit Note
App throws same error even when you don't have biometrics registered (it should lead to add biometrics instead https://github.com/flutter/flutter/issues/80510)
Steps reproduce

Create a project with java support on the latest flutter channel
Add the latest local_auth: ^1.1.4 to your pubspec.yaml and bump min SDK to 2.12.0  if it isn't already and click pub get in the IDE or execute flutter pub get
Copy official sample to `main.dart.
Add Android Integration  to MainActivity.java

import android.os.Bundle;
import io.flutter.app.FlutterFragmentActivity;
import io.flutter.plugins.flutter_plugin_android_lifecycle.FlutterAndroidLifecyclePlugin;
import io.flutter.plugins.localauth.LocalAuthPlugin;

public class MainActivity extends FlutterFragmentActivity {
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        FlutterAndroidLifecyclePlugin.registerWith(
                registrarFor(
                        "io.flutter.plugins.flutter_plugin_android_lifecycle.FlutterAndroidLifecyclePlugin"));
        LocalAuthPlugin.registerWith(registrarFor("io.flutter.plugins.localauth.LocalAuthPlugin"));
    }
}

and modify AndroidManifest.xml to add biometrics permission and io.flutter.app.FlutterApplication namespace for application
    <uses-permission android:name="android.permission.USE_BIOMETRIC"/>

    <application
       android:name="io.flutter.app.FlutterApplication"

Run flutter application on an Android device with biometrics registered
Click the first two buttons and make sure biometrics are available to test and click authenticate button and see the error

screenshot

logs
Launching lib\main.dart on RMX2001 in debug mode...
Running Gradle task 'assembleDebug'...
Note: C:\Users\Taha\AppData\Local\Pub\Cache\hosted\pub.dartlang.org\local_auth-1.1.4\android\src\main\java\io\flutter\plugins\localauth\LocalAuthPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: C:\Users\Taha\AndroidStudioProjects\flutter_app\android\app\src\main\java\com\example\flutter_app\MainActivity.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
√ Built build\app\outputs\flutter-apk\app-debug.apk.
Installing build\app\outputs\flutter-apk\app.apk...
Debug service listening on ws://<IP_ADDRESS>:62882/bfmhV1NEw2k=/ws
Syncing files to device RMX2001...
I/GED     (21912): ged_boost_gpu_freq, level 100, eOrigin 2, final_idx 27, oppidx_max 27, oppidx_min 0
I/ple.flutter_ap(21912): ProcessProfilingInfo new_methods=585 is saved saved_to_disk=1 resolve_classes_delay=5000
D/ColorViewRootUtil(21912): nav bar mode ignore false downX 396 downY 957 mScreenHeight 2400 mScreenWidth 1080 mStatusBarHeight 54 globalScale 1.125 nav mode 0 rotation 0 event MotionEvent { action=ACTION_DOWN, actionButton=0, id[0]=0, x[0]=396.0, y[0]=957.0, toolType[0]=TOOL_TYPE_FINGER, buttonState=0, classification=NONE, metaState=0, flags=0x0, edgeFlags=0x0, pointerCount=1, historySize=0, eventTime=3215979, downTime=3215979, deviceId=4, source=0x1002, displayId=0 }
D/ColorViewRootUtil(21912): nav bar mode ignore false downX 438 downY 1468 mScreenHeight 2400 mScreenWidth 1080 mStatusBarHeight 54 globalScale 1.125 nav mode 0 rotation 0 event MotionEvent { action=ACTION_DOWN, actionButton=0, id[0]=0, x[0]=438.0, y[0]=1468.0, toolType[0]=TOOL_TYPE_FINGER, buttonState=0, classification=NONE, metaState=0, flags=0x0, edgeFlags=0x0, pointerCount=1, historySize=0, eventTime=3216784, downTime=3216784, deviceId=4, source=0x1002, displayId=0 }
D/ColorViewRootUtil(21912): nav bar mode ignore false downX 367 downY 2202 mScreenHeight 2400 mScreenWidth 1080 mStatusBarHeight 54 globalScale 1.125 nav mode 0 rotation 0 event MotionEvent { action=ACTION_DOWN, actionButton=0, id[0]=0, x[0]=367.0, y[0]=2202.0, toolType[0]=TOOL_TYPE_FINGER, buttonState=0, classification=NONE, metaState=0, flags=0x0, edgeFlags=0x0, pointerCount=1, historySize=0, eventTime=3217874, downTime=3217874, deviceId=4, source=0x1002, displayId=0 }
I/flutter (21912): PlatformException(NotAvailable, Required security features not enabled, null, null)
I/SurfaceView(21912): 238834373 visibleChanged:true -> SurfaceHolder.Callback.surfaceDestroyed
D/Surface (21912): Surface::disconnect(this=0x76c9092000,api=1)
D/ViewRootImpl(21912): setSurfaceViewCreated, created:false
D/Surface (21912): Surface::disconnect(this=0x76c9092000,api=-1)
D/SurfaceView(21912): updateScreenMode w:0 h:0 ViewRoot w:1080 h:2400
D/SurfaceView(21912): try to resquest 90Hz
D/ViewRootImpl(21912): set screen refresh mode 0 due to SurfaceView-238834373
D/Surface (21912): Surface::disconnect(this=0x76e28e4000,api=1)
V/PhoneWindow(21912): DecorView setVisiblity: visibility = 4, Parent = android.view.ViewRootImpl@28d9810, this = DecorView@61f4f0d[MainActivity]
I/GED     (21912): ged_boost_gpu_freq, level 100, eOrigin 2, final_idx 27, oppidx_max 27, oppidx_min 0
E/libEGL  (21912): call to OpenGL ES API with no current context (logged once per thread)
D/SurfaceView(21912): updateScreenMode w:0 h:0 ViewRoot w:1080 h:2400
D/SurfaceView(21912): try to resquest 90Hz
D/View    (21912): [Warning] assignParent to null: this = DecorView@61f4f0d[MainActivity]
I/InputTransport(21912): Destroy ARC handle: 0x76e2606280

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.4, on Microsoft Windows [Version 10.0.19042.870], locale en-US)
    • Flutter version 2.0.4 at C:\Users\Taha\Code\flutter_stable
    • Framework revision b1395592de (11 days ago), 2021-04-01 14:25:01 -0700
    • Engine revision 2dce47073a
    • Dart version 2.12.2

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.2)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31112.23
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Users\Taha\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.3.3
    • Flutter plugin version 55.0.5
    • Dart plugin version 211.6693.108

[✓] VS Code (version 1.55.1)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • RMX2001 (mobile)  • EUYTFEUSQSRGDA6D • android-arm64  • Android 10 (API 29)
    • Windows (desktop) • windows          • windows-x64    • Microsoft Windows [Version 10.0.19042.870]
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 89.0.4389.114
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 89.0.774.68

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.1.0-13.0.pre.574, on Microsoft Windows [Version 10.0.19042.870], locale en-US)
    • Flutter version 2.1.0-13.0.pre.574 at C:\Users\Taha\Code\flutter_master
    • Framework revision 02efffc134 (2 days ago), 2021-04-10 03:49:01 -0400
    • Engine revision 8863afff16
    • Dart version 2.13.0 (build 2.13.0-222.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.9.2)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.9.31112.23
    • Windows 10 SDK version 10.0.19041.0

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Users\Taha\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.3.3
    • Flutter plugin version 55.0.5
    • Dart plugin version 211.6693.108

[✓] VS Code (version 1.55.1)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.21.0

[✓] Connected device (4 available)
    • RMX2001 (mobile)  • EUYTFEUSQSRGDA6D • android-arm64  • Android 10 (API 29)
    • Windows (desktop) • windows          • windows-x64    • Microsoft Windows [Version 10.0.19042.870]
    • Chrome (web)      • chrome           • web-javascript • Google Chrome 89.0.4389.114
    • Edge (web)        • edge             • web-javascript • Microsoft Edge 89.0.774.68

! Doctor found issues in 1 category.

Ran into this issue when reproducing https://github.com/flutter/flutter/issues/80021

I create 2 projects by local_auth: ^0.6.3+2 on flutter  sdk: ">=2.7.0 <3.0.0" and local_auth: ^1.1.4 and flutter  sdk: ">=2.12.0 <3.0.0".
I run both project in same emulator. Im Using using official sample for both project. It's video
When I lunch local_auth: ^0.6.3+2 project and tapped on Authenticate button  this dialog is appeared :
https://pasteboard.co/JWY7Yc9.png
But  when I lunch  local_auth: ^1.1.4 project and tapped on Authenticate button I just get this error:
PlatformException(NotAvailable, Required security features not enabled, null, null)
I expect to see this configuration dialog like  local_auth: ^0.6.3+2 project on local_auth: ^1.1.4 project.
Both these project lunched in one emulator and no finger print configuration do on android security setting.
In  local_auth: ^0.6.3+2 project, default biometric dialog is appeared to send user to biometric configuration part but local_auth: ^1.1.4 project, I got just error.
All my problem is Why new local_auth plugin can't move the user to configuration biometric mobile part if did not set before like my video ? yet.
And how can I fix the problem?

Issue verified on Samsung S10 and replicable using latest stable version which throws Required security features not enabled error on screen, as below:

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.4, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.0.4 at /Users/dhs/documents/fluttersdk/flutter
    • Framework revision b1395592de (7 days ago), 2021-04-01 14:25:01 -0700
    • Engine revision 2dce47073a
    • Dart version 2.12.2

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (3 available)
    • SM G975F (mobile) • RZ8M802WY0X • android-arm64 • Android 10 (API 29)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 14.4.1
    • macOS (desktop)           • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 89.0.4389.114

! Doctor found issues in 1 category.

We have the same issue as in https://github.com/flutter/flutter/issues/80510
The PlatformException says NotEnrolled if there is no fingerprint registered. Should open settings.

prioritized

For this bug , I rollback my project into none sound null safety.  Unfortunately I didn't get any useful feedback from contributor.

this is a major bug, could it be prioritised please ?

same here! any update?

I fixed this bug, changing this line in the AndroidManifest.xml.
<activity
android:name=".MainActivity"
Replace with:
<activity
android:name="io.flutter.embedding.android.FlutterFragmentActivity"

I fixed this bug, changing this line in the AndroidManifest.xml.
<activity
android:name=".MainActivity"
Replace with:
<activity
android:name="io.flutter.embedding.android.FlutterFragmentActivity"

I still got error. Could you share your simple project ?

I can confirm, on some device, it shows required security features not enabled and some devices PlatformException(NotEnrolled, No biometrics enrolled on this device., null, null), instead of dialog

If there is no fingerprint registered, the PlatformException says NotAvailable on an Android emulator and NotEnrolled on a real device.
It should show a dialog for opening settings, instead it's doing nothing.
@TahaTesser since this is an important security feature and an official flutter.dev package, could this bug be prioritized?

I can confirm that this regression still exists. This is really bad for user experience and app stability.

on Android Go to  : Settings => Security
Add fingerprint
if you use emulator you can simulate finger touch from (fingerprint)

on Android Go to : Settings => Security
Add fingerprint
if you use emulator you can simulate finger touch from (fingerprint)

At previous versions(before null safety) , itself opened  fingerprint part

on Android Go to : Settings => Security
Add fingerprint
if you use emulator you can simulate finger touch from (fingerprint)

At previous versions(before null safety) , itself opened fingerprint part

Here is work around :
check if any biometrics enrolled on this device if not it will show settings to enroll biometrics, and setup PIN/Pattern/Pass if necessary.
using open_settings plugin
https://pub.dev/packages/open_settings
Future<void> authenticate() async {
    bool authenticated = false;
    if (await authenticateIsAvailable()) {
      try {
        authenticated = await auth.authenticate(
          localizedReason: 'Let OS determine authentication method',
          useErrorDialogs: true,
          biometricOnly: true,
        );
      } on PlatformException catch (e) {
        print(e);
        return;
      }
    } else {
      //   TODO OPEN SETTINGS;
      print(" Device Not Supported ");
      OpenSettings.openBiometricEnrollSetting();
    }
  }

  Future<bool> authenticateIsAvailable() async {
    final isAvailable = await auth.canCheckBiometrics;
    final isDeviceSupported = await auth.isDeviceSupported();
    return isAvailable && isDeviceSupported;
  }

note
 final LocalAuthentication auth = LocalAuthentication();

I find solution from this article https://medium.com/flutter-community/flutter-local-authentication-with-fingerprint-and-face-recognition-744d5d7f6c4
Author use get it library for using local_auth. Maybe it will useful for someone

I have tested this on the latest stable and master versions on flutter along with local_auth version 2.0.2. This issue seems to be fixed. I have tested on both a Java based project as well as a Kotlin based one. None throws any error and the authentication works as expected.
Code sample used
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// ignore_for_file: public_member_api_docs

import 'dart:async';

import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:local_auth/local_auth.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final LocalAuthentication auth = LocalAuthentication();
  _SupportState _supportState = _SupportState.unknown;
  bool? _canCheckBiometrics;
  List<BiometricType>? _availableBiometrics;
  String _authorized = 'Not Authorized';
  bool _isAuthenticating = false;

  @override
  void initState() {
    super.initState();
    auth.isDeviceSupported().then(
          (bool isSupported) => setState(() => _supportState = isSupported
              ? _SupportState.supported
              : _SupportState.unsupported),
        );
  }

  Future<void> _checkBiometrics() async {
    late bool canCheckBiometrics;
    try {
      canCheckBiometrics = await auth.canCheckBiometrics;
    } on PlatformException catch (e) {
      canCheckBiometrics = false;
      print(e);
    }
    if (!mounted) {
      return;
    }

    setState(() {
      _canCheckBiometrics = canCheckBiometrics;
    });
  }

  Future<void> _getAvailableBiometrics() async {
    late List<BiometricType> availableBiometrics;
    try {
      availableBiometrics = await auth.getAvailableBiometrics();
    } on PlatformException catch (e) {
      availableBiometrics = <BiometricType>[];
      print(e);
    }
    if (!mounted) {
      return;
    }

    setState(() {
      _availableBiometrics = availableBiometrics;
    });
  }

  Future<void> _authenticate() async {
    bool authenticated = false;
    try {
      setState(() {
        _isAuthenticating = true;
        _authorized = 'Authenticating';
      });
      authenticated = await auth.authenticate(
        localizedReason: 'Let OS determine authentication method',
        options: const AuthenticationOptions(
          useErrorDialogs: true,
          stickyAuth: true,
        ),
      );
      setState(() {
        _isAuthenticating = false;
      });
    } on PlatformException catch (e) {
      print(e);
      setState(() {
        _isAuthenticating = false;
        _authorized = 'Error - ${e.message}';
      });
      return;
    }
    if (!mounted) {
      return;
    }

    setState(
        () => _authorized = authenticated ? 'Authorized' : 'Not Authorized');
  }

  Future<void> _authenticateWithBiometrics() async {
    bool authenticated = false;
    try {
      setState(() {
        _isAuthenticating = true;
        _authorized = 'Authenticating';
      });
      authenticated = await auth.authenticate(
        localizedReason:
            'Scan your fingerprint (or face or whatever) to authenticate',
        options: const AuthenticationOptions(
          useErrorDialogs: true,
          stickyAuth: true,
          biometricOnly: true,
        ),
      );
      setState(() {
        _isAuthenticating = false;
        _authorized = 'Authenticating';
      });
    } on PlatformException catch (e) {
      print(e);
      setState(() {
        _isAuthenticating = false;
        _authorized = 'Error - ${e.message}';
      });
      return;
    }
    if (!mounted) {
      return;
    }

    final String message = authenticated ? 'Authorized' : 'Not Authorized';
    setState(() {
      _authorized = message;
    });
  }

  Future<void> _cancelAuthentication() async {
    await auth.stopAuthentication();
    setState(() => _isAuthenticating = false);
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Plugin example app'),
        ),
        body: ListView(
          padding: const EdgeInsets.only(top: 30),
          children: <Widget>[
            Column(
              mainAxisAlignment: MainAxisAlignment.center,
              children: <Widget>[
                if (_supportState == _SupportState.unknown)
                  const CircularProgressIndicator()
                else if (_supportState == _SupportState.supported)
                  const Text('This device is supported')
                else
                  const Text('This device is not supported'),
                const Divider(height: 100),
                Text('Can check biometrics: $_canCheckBiometrics\n'),
                ElevatedButton(
                  onPressed: _checkBiometrics,
                  child: const Text('Check biometrics'),
                ),
                const Divider(height: 100),
                Text('Available biometrics: $_availableBiometrics\n'),
                ElevatedButton(
                  onPressed: _getAvailableBiometrics,
                  child: const Text('Get available biometrics'),
                ),
                const Divider(height: 100),
                Text('Current State: $_authorized\n'),
                if (_isAuthenticating)
                  ElevatedButton(
                    onPressed: _cancelAuthentication,
                    child: Row(
                      mainAxisSize: MainAxisSize.min,
                      children: const <Widget>[
                        Text('Cancel Authentication'),
                        Icon(Icons.cancel),
                      ],
                    ),
                  )
                else
                  Column(
                    children: <Widget>[
                      ElevatedButton(
                        onPressed: _authenticate,
                        child: Row(
                          mainAxisSize: MainAxisSize.min,
                          children: const <Widget>[
                            Text('Authenticate'),
                            Icon(Icons.perm_device_information),
                          ],
                        ),
                      ),
                      ElevatedButton(
                        onPressed: _authenticateWithBiometrics,
                        child: Row(
                          mainAxisSize: MainAxisSize.min,
                          children: <Widget>[
                            Text(_isAuthenticating
                                ? 'Cancel'
                                : 'Authenticate: biometrics only'),
                            const Icon(Icons.fingerprint),
                          ],
                        ),
                      ),
                    ],
                  ),
              ],
            ),
          ],
        ),
      ),
    );
  }
}

enum _SupportState {
  unknown,
  supported,
  unsupported,
}

Video
https://user-images.githubusercontent.com/50555895/167820834-bdac5e0c-3d0f-48bc-9d96-9159cb7bee77.mov

flutter doctor -v
[✓] Flutter (Channel master, 2.13.0-0.0.pre.1026, on macOS 12.3.1 21E258 darwin-arm, locale en-US)
    • Flutter version 2.13.0-0.0.pre.1026 at /Users/nabeelparkar/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c1b909e3fc (4 hours ago), 2022-05-10 22:49:08 -0700
    • Engine revision 70c5bdfa3b
    • Dart version 2.18.0 (build 2.18.0-103.0.dev)
    • DevTools version 2.13.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
    • Android SDK at /Users/nabeelparkar/Library/Android/sdk/
    • Platform android-32, build-tools 32.0.0-rc1
    • ANDROID_SDK_ROOT = /Users/nabeelparkar/Library/Android/sdk/
    • Java binary at: /opt/homebrew/opt/openjdk@11/bin/java
    • Java version OpenJDK Runtime Environment Homebrew (build 11.0.15+0)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /Applications/Brave Browser.app/Contents/MacOS/Brave Browser

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] IntelliJ IDEA Ultimate Edition (version 2022.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 67.0.4
    • Dart plugin version 221.5588

[✓] VS Code (version 1.67.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.40.0

[✓] Connected device (3 available)
    • V2050 (mobile)  •<PHONE_NUMBER>000NM • android-arm64  • Android 12 (API 31)
    • macOS (desktop) • macos           • darwin-arm64   • macOS 12.3.1 21E258 darwin-arm
    • Chrome (web)    • chrome          • web-javascript • Brave Browser <IP_ADDRESS>

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Device specifications
Vivo V21 5G - Android 12 (API 31)


Added ps command

Added both function of ps command and screenshot.

Hello @AJINKYA924 . Please check the updated readme.md once again.


Task and Contacts icons not showing on map / Waypoints for Tasks and Contacts not showing

Bug
Task and Contact map icons do not show on map
Waypoints for Tasks and Contacts do not show when selected.
To Reproduce
Add LuaBot test contact
Add LuaBot test task
Expected behavior
Should add task icon to map and show waypoint when task is selected.
Should add contact icon to map and show waypoint when contact is selected.

I've tried to look into this but it's beaten me, I have no idea. As we discussed last night @ZopharShinta it seems the client is expecting something to 'show' the waypoints once they're set but without client code I'm not sure how we find this.


DnnImageHandler does not set sensible browser cache headers

Description
DnnImageHandler does not set a max-age or expires HTTP header. This means the content will not be effectively cached by the browser.
Steps to reproduce
I've got a custom OpenContent module, which I'm using to serve news articles. Sometimes my users upload astoundingly large images, so to work around this I've used DnnImageHandler.ashx to serve something appropriate. e.g. /DnnImageHandler.ashx?mode=file&w=400&file=/Portals/0/OpenContent/Files/385/mma-mobile-bg.jpg
Current result
When I run this through the webpagetest.org, it reports:

Leverage browser caching of static assets: 50/100
FAILED - (No max-age or expires) - https://url-to-my-site/DnnImageHandler.ashx?mode=file&w=400&file=/Portals/0/OpenContent/Files/385/mma-mobile-bg.jpg
FAILED - (No max-age or expires) - https://url-to-my-site/DnnImageHandler.ashx?mode=file&w=400&file=/Portals/0/OpenContent/Files/388/tyler-gebhart-488825-unsplash.jpg

Expected result
DnnImageHandler.ashx sets an appropriate Cache-Control: max-age header (e.g. Cache-Control: max-age=86400) along with an appropriate ETag header (e.g. an ASCII hash of the image) or Last-Modified header.
Ideally I can disable this and/or customise the max-age with a querystring argument (setting it to 0 seconds would effectively disable it).
Affected version
I've tested with 9.2.0.
Affected browser
Any browser.

TL;DR: Fix or remove the nonsensical Last-Modified header. Set the Expires header to the far future.
It turns out DnnImageHandler does return Cache-Control, Expires, Last-Modified and ETag headers (I've stripped out the irrelevant ones):
Cache-Control: public
Date: Wed, 11 Jul 2018 09:09:52 GMT
Expires: Wed, 11 Jul 2018 09:19:52 GMT
Last-Modified: Wed, 11 Jul 2018 09:09:52 GMT
ETag: 2B521CFA9E685E2147DB92759B354FA2745901A1

The ETag appears to be correct, and stays the same on subsequent requests. However, the Last-Modified header contradicts it: it's set to the same time as the request, rather than when the image was actually generated. This could be a bit confusing for the browser - the image is unchanged, but it was last modified a moment ago? What do I do? Assuming the generated images are being cached on the server, perhaps use their created date this header? Even easier would be to remove the header altogether and rely on ETag.
Secondly, the expires header is set only 10 minutes into the future. Unless this is being used for very rapidly changing content, this ought to be set a lot longer so the browser doesn't try to reload the image if the user comes back to the page 20 minutes later. If Daniel Mettler's blog post is anything to go by, setting it to 30 days (2592000 seconds) would be better.
Finally, it appears that the caching behaviour can be disabled (e.g. for rapidly changing content) using the existing NoCache querystring parameter.

@OllyHodgson are you able to submit a pull request for this issue?

You can configure the Expires header using an app setting in the web.config, like this (see ReadSettings method):
<add key="DnnImageHandler" value="clientcacheexpiration=2592000" />

And here's where it sets Last-Modified, not sure if that should just be removed, or set to a different value…


new capabilities for more timeouts and way of changing the way we find elements

NewCommand timeout
idleTimeout
We found a bug/feature in Appium that was making it hard to find an element so for some of our tests we need to add change this with the new cap. of simpleIsVisibleCheck (Appium has more "smart" logic to help with web element validations which we don't need)

the continuous integration is failing because there are tests which check the capabilities being built. After those are passing I see no reason to not include this.


CRUD API for tiering

What type of PR is this?
kind new feature
What this PR does / why we need it:
This PR contains Create,Update,List,Get and Delete tier API for sample tier
Which issue(s) this PR fixes:
Fixes
#1259
#1260
#1261
#1262
Test Report Added?:
kind TESTED
Test Report:
Create Tier:

Update Tier:

List Tiers:

Get tier:

Delete Tier:

Special notes for your reviewer:

Please do the following:

run make goimports to format your all file in go standard.
Update the "What type of PR is this?" section
Add the all Crud issues no in the section "Which issue(s) this PR fixes:"

@vineela1999 @PravinRanjan10 In case of update tiers, can the admin remove any previously added backends from the tier if user has already created a bucket using that tier and is assigned to that backend.
For ex: Tier A has Backend X and Backend Y.
User creates bucket with Tier A that gets created in Backend Y.
Admin updates the Tier A and removes the Backend Y from the list of backends.
Will this action be allowed?

@vineela1999 @PravinRanjan10 In case of update tiers, can the admin remove any previously added backends from the tier if user has already created a bucket using that tier and is assigned to that backend.
For ex: Tier A has Backend X and Backend Y.
User creates bucket with Tier A that gets created in Backend Y.
Admin updates the Tier A and removes the Backend Y from the list of backends.
Will this action be allowed?

No. This action will not be allowed. Update(removing backend) only possible if there is no bucket associated with that backend.

@PravinRanjan10 What if a particular backend is upgraded / downgraded ?
For ex: Tier A has Backend X and Backend Y.
User creates bucket P with Tier A that gets created in Backend Y.
Backend Y is costing is now changed and company policy wants it to be changed to Tier D.
How will the admin handle this situation?

@vineela1999 Where is the associated issue? What is the requirement and design changes considered for this? Where is the API spec defined?

@PravinRanjan10 What if a particular backend is upgraded / downgraded ?
For ex: Tier A has Backend X and Backend Y.
User creates bucket P with Tier A that gets created in Backend Y.
Backend Y is costing is now changed and company policy wants it to be changed to Tier D.
How will the admin handle this situation?

@PravinRanjan10 @vineela1999
Did you get a chance to look at this?

#1270 opened one issues to track all optomization and validation relted things

LGTM

LGTM


Change Courses to Course

In this code, I had to change Courses to Course.
public async Task OnGetAsync()
{
Course = await _context.Course
.Include(c => c.Department)
.AsNoTracking()
.ToListAsync();
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d0026f69-7e5d-0d3e-5586-16ecc0656ff0
Version Independent ID: 3cb264da-2ff1-1256-572f-aa4ebca6e255
Content: Razor Pages with EF Core in ASP.NET Core - Read Related Data - 6 of 8
Content Source: aspnetcore/data/ef-rp/read-related-data.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Thanks. We'll get this fixed in the next update.


Add excluded sections support

So in the end I tried  it (#8) :rofl: .
Its just a quick change, but it seems to be working :). Any suggestions?

@OndraM Thanks! 👍


jest-koa-mocks: allow configuring subdomainOffset on koa's app instance

Overview
Please allow passing subdomainOffset which would then be set on the koa app's instance inside createContext function. Maybe customProperties could be used for that.
This is necessary to control how ctx.subdomains array is constructed from requested url.
https://koajs.com/#settings
Type

[x] New feature
[x] Changes to existing features

Motivation

What inspired this feature request? What problems were you facing,
or what else makes you think this should be in quilt?

I think that's the only thing which is missing to fully mock the koa's context object.

it just struck me I can still configure it after creating the mock...:
      const ctx = createMockContext({ url, headers });
      ctx.app.subdomainOffset = subdomainOffset;
      console.log(ctx.subdomains); // now resolved with passed subdomainOffset


Transfer to executablebooks: change repo owner

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   97.71%   97.71%
=======================================
  Files           8        8
  Lines         350      350
=======================================
  Hits          342      342
  Misses          8        8

Impacted Files
Coverage Δ

mdformat/_cli.py
92.30% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d6c35...b480734. Read the comment docs.


How to teardown a module instantiated with Elm.embed

I couldn't find anything in the documentation or source code.
When I need to remove a component, how am I supposed to stop it?
I don't want to have to delete the element, just clear it.
Would deleting the element from the DOM even get the job done?  Would the garbage collector be able to clean up the Elm code?

Looks like fullscreen and embed return an object with three methods, one of them being .dispose().
Source: elm-core/Native/Runtime.js#L171-L175
function dispose() {
  removeListeners(listeners);
  inputs = [];
}

This looks like what I was hoping for!  I'll leave this open in case some other contributor wants to confirm, but I'll give dispose a try.


Autosplitter no longer working on current version

This autosplitter looks nice to speedrun the game but it seems to not work anymore with the current version. Is it possible to make it work?
Note: Wrack has been chosen into the Ultimate Decathlon 7 speedrun tournament, it would be fantastic that runners can use it :D
Thanks for your work.

I'm excited to see people speedrunning this game again ! I'll see what I can do next week.

From: Benjamin FÜHRMANN<EMAIL_ADDRESS>Sent: Monday, February 4, 2019 5:26:23 AM
To: Dalet/LiveSplit.Wrack
Cc: Subscribed
Subject: [Dalet/LiveSplit.Wrack] Autosplitter no longer working on current version (#1)
This autosplitter looks nice to speedrun the game but it seems to not work anymore with the current version. Is it possible to make it work?
Note: Wrack has been chosen into the Ultimate Decathlon 7 speedrun tournament, it would be fantastic that runners can use it :D
Thanks for your work.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Dalet/LiveSplit.Wrack/issues/1, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABsurJUJkXEJ-MsGPc06Oe83AacEC87Mks5vJ7ZvgaJpZM4agh2b.


Ruby 2.7 deprecations

We're using Ruby 2.7 and are getting warnings from this gem:
database_cleaner-core-2.0.0.beta2/lib/database_cleaner/cleaners.rb:41: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
database_cleaner-core-2.0.0.beta2/lib/database_cleaner/cleaner.rb:28: warning: The called method `initialize' is defined here

I'd be more than happy to put up a PR...is there a minimum version of Ruby that this database_cleaner v2 plans to support?

@ngan That would be great. We are currently maintaining Ruby 2.5 and higher: https://github.com/DatabaseCleaner/database_cleaner/blob/master/.travis.yml

@etagwerker here ya go: https://github.com/DatabaseCleaner/database_cleaner/pull/667


Corrected some comment numbering.

I noticed some comment numbers were off so I fixed them.

Thanks @crswll !


No name 'debug' in module 'tensorflow'

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10 Pro
TensorFlow installed from (source or binary): pip install tensorflow-gpu --upgrade
TensorFlow version (use command below): 1.0.1
Bazel version (if compiling from source): N/A
CUDA/cuDNN version: Cuda:8, CuDnn:5.1
GPU model and memory: Pascal TitanX (x2)
Exact command to reproduce:
from tensorflow.python import debug as tf_debug

You can collect some of this information using our environment capture script:
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
Won't import.  This is the exact import from the docs; I have done nothing fancy; just normal install of everything.
Source code / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.
you can replicate this really easy.
python -c "from tensorflow.python import debug as tf_debug;"

@caisq: This works for me with 1.0.0 on Mac.  Not sure if this is a Windows issue or a version issue.

TFDBG is not functional in 1.0.x on Windows. This is a known issue. It should have been fixed in 1.1.0.


Pubsub test

chore: Add pubsub scaler e2e test
Fixes #1528

/run-e2e gcp-pubsub.test.ts

/run-e2e gcp-pubsub.test.ts

Tests look a bit unstables.
Could you take a look please @RamCohen ?

   ✔ creating the gcp-sdk pod should work.. (598ms)
error: unable to upgrade connection: container not found ("gcp-sdk-container")
error: unable to upgrade connection: container not found ("gcp-sdk-container")
error: unable to upgrade connection: container not found ("gcp-sdk-container")
ERROR: (gcloud.pubsub.subscriptions.create) You do not currently have an active account selected.
Please run:

  $ gcloud auth login

to obtain new credentials.

If you have already logged in with a different account:

    $ gcloud config set account ACCOUNT

to select an already authenticated account to use.

/run-e2e gcp-pubsub.test.ts

/run-e2e gcp-pubsub.test.ts

/run-e2e gcp-pubsub.test.ts Update: You can check the progres here

@RamCohen FYI
  ✔ creating the gcp-sdk pod should work.. (***.3s)
Activated service account credentials for<EMAIL_ADDRESS>API [pubsub.googleapis.com] not enabled on project [538407947***74]. Would you
like to enable and retry (this will take a few minutes)? (y/N)?

ERROR: (gcloud.pubsub.topics.create) PERMISSION_DENIED: Cloud Pub/Sub API has not been used in project 538407947***74 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/pubsub.googleapis.com/overview?project=538407947***74 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.
- '@type': type.googleapis.com/google.rpc.Help
  links:
  - description: Google developers console API activation
    url: https://console.developers.google.com/apis/api/pubsub.googleapis.com/overview?project=538407947***74
- '@type': type.googleapis.com/google.rpc.ErrorInfo
  domain: googleapis.com
  metadata:
    consumer: projects/538407947***74
    service: pubsub.googleapis.com
  reason: SERVICE_DISABLED
command terminated with exit code ***
API [pubsub.googleapis.com] not enabled on project [538407947***74]. Would you
like to enable and retry (this will take a few minutes)? (y/N)?

Well, at least we are getting somewhere...
I'll push a revision which does the enablement

It's better to do it in the console.
Please enable Pubsub, GCS and stackdriver APIs

It's better to do it in the console. Please enable Pubsub, GCS and stackdriver APIs

@tomkerkhove could you PTAL on this?

/run-e2e gcp-pubsub.test.ts

Current error:
ERROR: (gcloud.pubsub.topics.create) PERMISSION_DENIED: Cloud Pub/Sub API has not been used in project<PHONE_NUMBER>4 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/pubsub.googleapis.com/overview?project=53840794774 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.

'@type': type.googleapis.com/google.rpc.Help
links:

description: Google developers console API activation
url: https://console.developers.google.com/apis/api/pubsub.googleapis.com/overview?project=538407947***74

'@type': type.googleapis.com/google.rpc.ErrorInfo
domain: googleapis.com
metadata:
consumer: projects/53840794774
service: pubsub.googleapis.com
reason: SERVICE_DISABLED
command terminated with exit code ***
API [pubsub.googleapis.com] not enabled on project [53840794774].

/run-e2e gcp-pubsub.test.ts

🤦 ...
I enabled Pub/Sub lite instead of this...
Thanks for the link, now it's enabled. Retrying

Also enabled these (picture is in Spanish but I think is understandable):

don't think we need cloud reporting or profiling or pubsub lite
remember to also enable cloud storag

Is this?

/run-e2e gcp-pubsub.test.ts

right now I keep enabled the API from the last picture, the link that you sent me about PubSub and stackdriver + stackdriver  monitoring

Still getting the same error. Are you sure you are enabling it for the right project (if there is more than one) ?
ERROR: (gcloud.pubsub.topics.create) PERMISSION_DENIED: Cloud Pub/Sub API has not been used in project<PHONE_NUMBER>4 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/pubsub.googleapis.com/overview?project=53840794774 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.

'@type': type.googleapis.com/google.rpc.Help
links:

description: Google developers console API activation
url: https://console.developers.google.com/apis/api/pubsub.googleapis.com/overview?project=538407947***74

'@type': type.googleapis.com/google.rpc.ErrorInfo
domain: googleapis.com
metadata:
consumer: projects/53840794774
service: pubsub.googleapis.com
reason: SERVICE_DISABLED
command terminated with exit code ***
API [pubsub.googleapis.com] not enabled on project [53840794774]

I think so.
Maybe credentials are not related with my account? Let me update the secret with another new google application credentials

Go the the Pub/Sub service in the console like this:

/run-e2e gcp-pubsub.test.ts

Let's wait this execution, I have updated the service account with another. I'm not totally sure if the previous was correct

Seems Ok now :-)

/run-e2e gcp-pubsub.test.ts

Yes, I think other the credentials were wrong because the email was different.

Thanks a ton for this e2e test!!! ❤


Move shared survey code to ui-core

Currently, code for converting Juniper Surveys into SurveyJS models is duplicated in ui-admin and ui-participant. This moves that code into ui-core. It also moves the custom survey components that are currently part of ui-participant. This is necessary to have a complete survey preview in the admin UI.
In some cases, the admin and participant implementations of functions differed. In those cases, the participant UI version was used.

Is it expected that the top-level package-lock.json changed when there were no changes to the top-level package.json? Is it because of the change in ui-core/package.json in the context of npm workspaces?

Yes, package-lock.json is for the entire workspace (all 3 ui-* packages and the root package.json). It looks like some dependencies got moved up to the top-level node_modules folder now that they're used by ui-core.


Avoid OSAL IDs in messages/data files

Is your feature request related to a problem? Please describe.
OSAL runtime types aren't really defined as part of the external (i.e. mission-scope) interface.  The osal_id_t is one such example - it is a local runtime type, not really intended to be saved in data files or command/telemetry messages.
This might seem pedantic because it is simply a uint32, but when using CFE with a command/data dictionary tool this becomes apparent that the OSAL types used in telemetry and data files aren't part of the data dictionary.  (OSAL itself doesn't have a cmd/tlm interface so it naturally wouldn't provide any such entity).
Describe the solution you'd like
Use the CFE_ES_ResourceID_t instead.  Call CFE_ES_ResourceID_FromOSAL() when writing and CFE_ES_ResourceID_ToOSAL() when reading, to do the type conversion.  The underlying value is compatible (i.e. both 32 bit uint32, same numbers) so it should be transparent to external tools.
Describe alternatives you've considered
Have OSAL provide a stablized CMD/TLM definition of IDs?  (but CMD/TLM interface is not really part of OSAL's role - it is a runtime library)
Requester Info
Joseph Hickey, Vantage Systems, Inc.

CCB 2020-10-28

Consider removing OSAL IDs in dump files since they're not consistent and are runtime specific
@jphickey to make list of where the IDs pop up in the codebase

Checked the CFE code, I only see one instance of OSAL IDs in messages or data files - the ModuleId field of the CFE_ES_AppInfo struct which in turn is reported within the "One App" telemetry message as well as the "query all apps" data file:
https://github.com/nasa/cFE/blob/e0d1ce883476931c86adc00adac49edea1a30d5a/fsw/cfe-core/src/inc/cfe_es.h#L363
So this currently (at least out of the box) probably has no meaning or usefulness for a ground system.
I said "currently" because although AFAIK there is no interface that allows a ground system to query OSAL resources by ID, someone could easily write an app to do so, in which case the ID becomes useful.
The other option would be to just switch it to the CFE_ES_ResourceID_t type instead, which is backward compatible.

Found another one, the CFE_SB_PipeD_t structure is written in the SendPipeInfo command.  This one had thrown me off because it appears in the cfe_sb_priv.h file - suggesting it is an internal data structure.  But it actually is written to a stats file, making it effectively also a telemetry message.  This is probably a separate issue to resolve...

Submitted #982 about "private" SB Pipe data


DOMException

Hello, I am currently getting this Error when using html2pdf with Angular and Ionic.
DOMException: Failed to set the 'adoptedStyleSheets' property on 'ShadowRoot': Sharing constructed stylesheets in multiple documents is not allowed

onExportPDF() {
        const options = {
            filename: 'job_report.pdf',
            image: {type: 'jpeg', quality: 0.98},
            html2canvas: {scale: 2, logging: true, dpi: 192, letterRendering: true},
            jsPDF: {unit: 'mm', format: 'a4', orientation: 'portrait'}
        };
        const content: Element = document.getElementById('job-report');

        html2pdf()
            .from(content)
            .set(options)
            .save();
 }

Anyone have a know the issue to stop the DOMException? It works fine. The PDF comes out nice, but it's a nasty error to have in the console, and it makes my hamburger button for my side menu disappear.

Got it working by doing it with jsPDF & Dom to Image. No more DOMException!
import * as jspdf from 'jspdf';
import domtoimage from 'dom-to-image';

// export report to a pdf
onExportPDF() {
        const div = document.getElementById('job-report');
        const options = { background: 'white', height: 1000, width: 800};
        domtoimage.toPng(div, options).then(
            (dataUrl) =>
            {
                const doc = new jspdf.jsPDF('portrait', 'mm', 'a4');
                doc.addImage(dataUrl, 'PNG', 0, 0, 210, 297);
                doc.save('job_report.pdf');
            })
}

Same problem here


Upgrade xterm to newer version

Remove null-loader hack to keep old xterm working with
newer version of webpack
Remove vendored older version of xterm fit addon

Refinement of https://github.com/jupyterhub/binderhub/pull/1248
Co-authored-by: Kenan Erdogan<EMAIL_ADDRESS>

feels good

ya hopefully we can try dependabot or something of that sort for js dependencies? But this is a biggish bump, hopefully future bumps are easier.

Has one of you tested this locally to see if it still works in the various cases that it is used?

@betatim yeah I did.

@yuvipanda I ended up causing a merge conflict in this after merging another PR of yours. I'd press merge if this wasn't for that or if I was confident enough to solve the conflict myself.

@consideRatio i've fixed the conflict!


Indexer local Bulk ingest API

Summary
Indexer local Bulk ingest API
Requirements

[ ] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[ ] I've read and agree to the Code of Conduct.

Still WIP


Fix for #749 - LogConverter.ParseAddress sometimes throws an error

Change the hex number path of LogConverter.ParseAddress to use TryParse instead of parse. Return 0 if parsing fails.
closes #749

Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Matt Bierner). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Revert "Avoid copying data just to compress them when it is not necessary."

Reverts vespa-engine/vespa#18903
@hmusum PR
build broke

👍


Removing support for fsdoc in favor of fstardoc

Dear all,
As discussed in #1877, we planned to remove support for fsdoc, instead migrating to the use of a lighter weight documentation generator fstardoc that @jaybosamiya has been building.
In short, going forward, we will generate documentation directly from F* source files using a standalone script rather than trying to parse and then print back comments associated with specific AST elements. You can see .scripts/fstardoc for an example of how that is meant to work.
So, towards removing fsdoc, this pull request has the following features:

Removes all special support in the parser for fsdoc comments. This should hopefully reduce brittleness in the parser when parsing comments, one of the pain points so far in using fsdoc.

Removes the fsdoc nodes in the Parser.AST, instead treating (** *) comments as just normal comments.

This means that fsdoc comments are no longer associated with top-level definition as Comment attributes.

It also means that the interactive mode, which used to support looking up the comments associated with an identifier no longer supports this feature in any meaningful way. I did not remove the documentation query from the interactive mode's API, since I hope we can mimic the documentation lookup functionality in some other way, e.g., by relying on position information associated with identifiers and comments to look up comments that just precede the location of the identifier. We are already using this kind of position information to print comments in the pretty printer---it would be nice to do that for the interactive queries too, but I have not done this yet.

We have discussed this for a long time, but I realize that removing this feature altogether may still be quite contentious. Please do chime in with your opinion, one way or another. Thanks!

I really like that we'll now be able to use (** *) style comments without the interactive mode just dying out due to parser brittleness. This will definitely be a massive gain imho for people to start writing more docs as they go along with their proofs.
As far as the interactive mode goes, if I understand correctly, this would mean that C-c C-s C-d in the Emacs mode would be impacted. Is there anything else that I'm missing for usage?

Thanks for the comments @jaybosamiya
Yes, only C-c C-s C-d would be impacted. That key combination triggers the following query to F*
 ... "requested-info":["type","defined-at","documentation"]

F* would still respond with the type and the defined location. It's just that the doc string would be empty, until we find some other way to associate comments with definitions.

I hope we can mimic the documentation lookup functionality in some other way, e.g., by relying on position information associated with identifiers and comments to look up comments that just precede the location of the identifier

Big +1 from me here. It would be nice to support this feature while keeping the compiler completely agnostic to it.
I took a look at the diff and it seems reasonable.

The changes look fine to me as well, thanks!


Fixing jest tests, initial CI pipeline, adding commitizen, starter config for automation tools

Description
Hey @gabrielkuettel , wanted to make another round of contributions. Let me know what you think - these are mostly minor and cosmetic but can serve as a starting point for ci/unit tests and etc. Let me know what you think :)

Please explain the changes you made here

Fixing jest tests. The tests weren't compiling correctly with typescript setup. Added a few changes to the Example page test and one unit test with snapshots.
Custom unofficial logo for the project. I tried to get a font close enough to the NFD logo. If you'll like it i can also supply psd file separately so you can tweak it further yourself if needed in future 👍
Initial row of readme badges. You guys can later add ci status badges, coverage and etc if you want.
Added commitizen and cz-conventional-changelog to help with commit messages. I can remove this if you guys don't want it. But it just aids with conventional commit messages.  It can also generate the changelog for you. Task is completely optional.
Adding pull request template. You can edit this to your liking. I just added a few things that I thought would be helpful.
Adding yaml for auto_assign bot. This will automatically assign the PR to the project owner. If you want to use it after merging this PR, you will need to install the bot from the marketplace. Otherwise can remove this file just let me know.
Adding renovate.json. This will help with keeping dependencies up to date via automated bot (ive set it to once a month with preference over aggregating minor bumps into single pr, then major bumps are always isolating individual packages). If you want to use it after merging this PR, you will need to install the bot from the marketplace. Otherwise can remove this file just let me know.
Adding initial build pipeline. This will run the build and test tasks on every push or on PR to main.

Checklist

Please, make sure to comply with the checklist below before expecting review

[x] Code compiles correctly
[x] Created tests which fail without the change (if possible)
[x] All tests passing
[x] Extended the README / documentation, if necessary

@pbennett pushed one extra commit that updates the icon to the one with fully filled letters.
And below is an svg version so you can use it to revamp further if needed. Font used is called Disco Deck

This looks great. 👍 @drichar and I have some tweaks we need to discuss. We'll update here. This is a massive help, thanks.


Incorrect clone path for installation instructions

The current install instructions tell to clone this repository and then cd into nord-gnome-terminal to run the setup script. As this repository is called gnome-terminal, the git repo is cloned into the gnome-terminal location and the copy+paste instructions do not work.

Added a small PR with the fix.


chore: fix BiDi deserializer

Closes #11259
With this change this test [evaluation.spec] Evaluation specs Page.evaluate should fail for circular object is failing,
not sure how to action on it.

Decided to disable the test, in BiDi we have the InternalId and we may be able to reproduce the circular object so [evaluation.spec] Evaluation specs Page.evaluate should fail for circular object actually does not need to fail but passes.


Unable to render svg element with a nested path.

The following should render an svg element with a nested , but it's only rendering the svg, which produces no visible element. Phlex v1.9
              svg(
                class: "w-6 h-6 mr-2 text-gray-800 dark:text-white",
                aria_hidden: "true",
                xmlns: "http://www.w3.org/2000/svg",
                fill: "currentColor",
                viewbox: "0 0 24 24"
              ) do |s|
                s.path(
                  fill_rule: "evenodd",
                  d: "M5 5c.6 0 1-.4 1-1a1 1 0 1 1 2 0c0 .6.4 1 1 1h1c.6 0 1-.4 1-1a1 1 0 1 1 2 0c0 .6.4 1 1 1h1c.6 0 1-.4 1-1a1 1 0 1 1 2 0c0 .6.4 1 1 1a2 2 0 0 1 2 2v1c0 .6-.4 1-1 1H4a1 1 0 0 1-1-1V7c0-1.1.9-2 2-2ZM3 19v-7c0-.6.4-1 1-1h16c.6 0 1 .4 1 1v7a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2Zm6-6c0-.6-.4-1-1-1a1 1 0 1 0 0 2c.6 0 1-.4 1-1Zm2 0a1 1 0 1 1 2 0c0 .6-.4 1-1 1a1 1 0 0 1-1-1Zm6 0c0-.6-.4-1-1-1a1 1 0 1 0 0 2c.6 0 1-.4 1-1ZM7 17a1 1 0 1 1 2 0c0 .6-.4 1-1 1a1 1 0 0 1-1-1Zm6 0c0-.6-.4-1-1-1a1 1 0 1 0 0 2c.6 0 1-.4 1-1Zm2 0a1 1 0 1 1 2 0c0 .6-.4 1-1 1a1 1 0 0 1-1-1Z",
                  clip_rule: "evenodd"
                )
              end

Oh, I think I might know what the issue could be. If this is in a Phlex::SVG component, you don’t need to pick up |s| and call path on s.
If it's in a Phlex::HTML component, the svg method there yields an instance of a Phlex::SVG, which you can call methods on. This allows you to use SVG methods from an HTML context.

I've tried it both ways, neither one of which produces any nested path element. I've also tried making an 'Icon' class and having that inherit from Phlex::SVG or Phlex::HTML and rendering that in my template, which weirdly produces nothing, not even an svg element.

It looks like there was some issue with the plain content following the svg element. It was calling a method that was overridden by a stub generated by phlexing.fun. Thanks for the help on this!


feat(server_openvr): Add Quest Pro controller and headset emulation; Use VRLink hand tracking icons for the hand tracker controllers; Misc refactoring to reduce prop.rs linecount

OK so,

Refactored to the new stuff, and fixed a bug while I was at it (last PR accidentally set all info to the headset device ID lol)
Added the VRLink stuff incl the model and input profile. Needs more work in a different PR, the shuttlecock is at the wrong position and none of the bindings work. But it's not any worse than it was tbh, adds a nice visual indication of hand tracking.
Created a local function for all the icons stuff and moved everything to use it incl the headset emulation


USE_LOCATION is not defined

Hi Dan,
Getting around to testing this.  When running seg_images_in_folder.py, pointing to the weights/model you provided, I get the following error:
(imageseg) E:\NAU\Python\bedPicking\segmentation_zoo\res_unet>python seg_images_in_folder.py
Version:  2.1.0
Eager mode:  True
GPU name:  [PhysicalDevice(name='/physical_device:GPU:0', device_type='GPU')]
Num GPUs Available:  1
Z:/toProcess/bedPicking/forModelTraining/DanTrainedModels/sidescan_1class_batch_4.h5
Z:/toProcess/bedPicking/forModelTraining/images
Traceback (most recent call last):
  File "seg_images_in_folder.py", line 538, in <module>
    if USE_LOCATION:
NameError: name 'USE_LOCATION' is not defined

Should USE_LOCATION be set in the configuration file or something?
Thanks!

Thanks. New feature / not yet documented/implemented - yes, USE_LOCATION=True in config file

I believe the time is nigh to retire USE_LOCATION -


update tiflash proxy

Signed-off-by: Lloyd-Pottiger<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: ref #4879
Problem Summary:
update proxy to 20220601_161546
What is changed and how it works?
TiKV implement #4879, update proxy to pick recent changes.
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/cc @CalvinNeo @JinheLin

should we cherry pick this to TiFlash 6.1?

should we cherry pick this to TiFlash 6.1?

I will pick

should we cherry pick this to TiFlash 6.1?

weiwan says we do need to do that.

/merge

/merge


A logo for rlsl

I would appreciate it very much if anyone would like to design a logo for rlsl as I am not a very good artist myself.
I am also working on a GPU path tracer with a friend, maybe I can create some nice looking fractals in the future that could be used as a logo.

I created an SVG in InkScape:

Inspiration:

I like it a lot, although I found a slight issue with the shape of the curve. It seems that the inner cutout is some kind of ellipsoid, but your recreation doesn't exactly mimic the geometry of the original. In the original, the curve envelops the inner ellipsoid, whereas in the recreation, the ellipsoid is overlapped. See the following pictures:

I add other Khronos logos for reference, to illustrate that the inner ellipsoid retains its shape even when used around longer labels:

Additionally, the font that they use in their logos seems to be
	Main Font: Helvetica Neue 55 Roman, Helvetica Neue 75 Bold
	TM/Registered TM: Helvetica Neue 75 Bold

(found in the SPIR Logo Pack at https://www.khronos.org/legal/trademarks/)

I did a trace to match the curve of the SPIR logo. I also don't have access
to helvetica. Arial is the closest I have.
I can share the svg where you can see the curve matches the reference and
change the font.
Danny
On Thu, Jun 14, 2018, 04:43 Jakub Hlusička<EMAIL_ADDRESS>wrote:

Additionally, the font that they use in their logos seems to be
Main Font: Helvetica Neue 55 Roman, Helvetica Neue 75 Bold
TM/Registered TM: Helvetica Neue 75 Bold
(found in the SPIR Logo Pack at https://www.khronos.org/legal/trademarks/)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MaikKlein/rlsl/issues/49#issuecomment-397251830, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATRjJTAQK9zSSSZxJB85w5HCbrUM92Oks5t8j5fgaJpZM4UmfjE
.

@dannyfritz Thanks for creating the logo :). Would you like to make a PR and put the svg file somewhere under media/?
Also I am not sure if the logo is too similar to the SPIR logo. It might invoke the wrong impression that this in an official Khronos project.

Heh, let's consider it a good talking point to get more people interested in making a logo in that case. :wink:

Someone is giving away logos for open source projects. https://github.com/arasatasaygin/openlogos. Do you see a fitting logo for rlsl on there?


Standardize the use of "clause" and "subclause"

SMPTE has switched to the use of "clause" instead of "section" to conform with ISO Directives.
Often, text mentions "this clause." Most of the time, it is obvious what it means, but not always. To standardize its use, I propose the following:

"This clause" refers only to the clause's top level, i.e., Clause 4, and cannot be used in, e.g., 4.1, 8.5.2, etc. Specifically, "this clause" would be used only if the clause has no subclauses.
"This subclause" would be used only in the subclause that contains the statement, e.g., 7.3.2, A.1.5.
"This annex" refers only to the annex' top level, i.e., Annex E, and cannot be used in, e.g., E.3, C.4.7, etc. Specifically, "this annex" would be used only if the annex has no subclauses.

All other references must specify the clause, subclause, or annex, e.g., Clause 6, Subclause 2.4, Subclause D.3, Annex H.
Pertaining to the use of "subclause" to refer to a subsection of an annex, I looked for a directive within ISO. There was no directive, but within the ISO Directives document, there was the use of "subclause" to specify a subsection of an annex.

All other references must specify the clause, subclause, or annex, e.g., Clause 6, Subclause 2.4, Subclause D.3, Annex H.

I was wondering about this.
I note that html-pub currently generates internal references such as:

That is, "Clause" is automatically pre-pended but "Subclause" never is.
This does appear to be in-line with: https://www.iso.org/sites/directives/current/part2/index.xhtml#_idTextAnchor321
It would be useful to have some guidance on referencing Subclauses in other documents because following the ISO directives would suggest something like "as specified in SMPTE ST 2067-2:2020, 5.1" (to refer to Subclause 5.1) but that doesn't look very clear (whereas this structure for referencing a Table or something would be fine e.g. "as specified in SMPTE ST 2067-2:2020, Table 3")

Hi Thomas,
I would go with the ISO directive.
I have, at times, suggested using "subclause," when stating "this clause"
was ambiguous. To conform with ISO, we should instead state, "...as
specified in this clause (6.5)..." or "as specified in this clause
(6.5)..." There should never be ambiguity.
Use uppercase when referring to a specific clause: "Clause 8", "Clause
3.5", "Clause A.3.3"
Use lowercase when referring to a clause in general: "this clause", "this
clause (4.9)", "in 4.9 (this clause)"
Annexes are a special case, as the top level is referred to as "Annex X",
whereas the sublevels of the annexes are referred to as clauses. see:
https://www.iso.org/sites/directives/current/part2/index.xhtml#_idTextAnchor292
As far as including "Clause" when specifying a clause (Clause 3.2, Clause
C.8.5) vs. specifying only the number (3.2, C.8.5), we can either
require the use of "Clause" or leave it to the editor's choice. For
example, in a table in which there are a list of references, it would be
visually cleaner not to include "Clause" before every reference.
All the best,
Ellen

As far as including "Clause" when specifying a clause (Clause 3.2, Clause C.8.5) vs. specifying only the number (3.2, C.8.5), we can either require the use of "Clause" or leave it to the editor's choice

So, I think we're saying that:

When referencing clauses/subclauses in the same document this is already taken care of by the tooling per my comment above and this doesn't need to change
When referencing a clause/subclause in a different document the only difference to (1) is that optionally the "Subclause" prefix may be included -- for example, either of these would be acceptable:

"as specified in SMPTE ST 2067-2:2020, 5.1"
"as specified in SMPTE ST 2067-2:2020, Subclause 5.1"

"as specified in SMPTE ST 2067-2:2020, 5.1"

+1

"as specified in SMPTE ST 2067-2:2020, Subclause 5.1"

-1


Add privacy policy page

related issue: https://github.com/panvol/pandemic-volunteers/issues/8

Closed in favor of https://github.com/panvol/pandemic-volunteers/pull/38


Adopt pydantic-settings with Pydantic V2

Here is the list of changes:

class Config is not valid anymore and has to be replaced with model_config. Example:

    class Settings(BaseSettings):
        apple: str

        class Config:
            env_prefix = 'foobar_'

has to be replaced with:
    class Settings(BaseSettings):
        apple: str

        model_config = ConfigDict(env_prefix='foobar_')

Model.dict() is not available anymore and Model.model_dump() has to be used.
Defining env for a field under class Config is not valid and validation_alias has to be used. Example:

    class Settings(BaseSettings):
        apple: str = ...

        class Config:
            fields = {'apple': {'env': 'BOOM'}}

has to be replaced with:
    class Settings(BaseSettings):
        apple: str = Field(None, validation_alias='BOOM')

Initializing settings class with field name whenever validation_alias is defined does not work anymore. Example:

class SettingsModel(BaseSettings):
    foobar: str = Field(validation_alias='foobar_env')

SettingsModel(foobar='test')  # Raises validation error

Defining env in Field is not valid anymore and validation_alias has to be used. Example:

    class Settings(BaseSettings):
        foobar: str = Field(..., env='foobar_env_name')

has to be replaced with:
    class Settings(BaseSettings):
        foobar: str = Field(validation_alias='foobar_env_name')

customise_sources is not part of class Config anymore and moved to BaseSettings class.

Codecov Report
Patch coverage: 95.40% and project coverage change: -0.84 :warning:

Comparison is base (0ecac22) 96.31% compared to head (0972a89) 95.47%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   96.31%   95.47%   -0.84%
==========================================
  Files           4        5       +1
  Lines         244      243       -1
  Branches       60       58       -2
==========================================
- Hits          235      232       -3
- Misses          9       10       +1
- Partials        0        1       +1

Impacted Files
Coverage Δ

pydantic_settings/utils.py
75.00% <75.00%> (ø)

pydantic_settings/sources.py
95.58% <97.14%> (+0.05%)
:arrow_up:

pydantic_settings/main.py
100.00% <100.00%> (+1.75%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Thanks @samuelcolvin for the review. I've addressed all of them.


Fix extending Filter example code in README.md

It was missing a "?" in method ProjectFilter::deleted()

plz help me


Can't run examples on Simulaqron

I'm trying to run examples from the 0.8.6 version on Simulaqron 4.0.0, specifically the teleportation.

First issue (solved) was with the epr_socket.create_keep()[0] on app_sender.py file that doesn't exit; apparently it currently is .create()[0]. Same with app_receiver.py containing epr_socket.recv_keep()[0].

Second issue was the timeout from epr_socket from receiver's side. It seems the receiver's EPR socket times out: TIMEOUT, no EPR generation received. and couldn't figure out what happened - there's not clear message. Regarding this I tried to:

change the app_id and epr_socket_id values from receiver to 1 on EPRSocket()'s epr_socket_id at app_receiver.py and EPRSocket()'s remote_epr_socket_id at app_sender.py  to see whether there was a conflict over app_ids and epr_socket_ids from sender and receiver; however no success.

On the network.yaml parameters I set all the fidelity and gate_fidelity keys values to 1.0 and t1 and t2 to 0 so it would always pass all the generated qubits from one node to the other.
Any clues on why there's this timeout problem with epr_socket ?

it works properly on NetQASM 0.9 (although it is defined as not compatible with SimulaQron 4.0)


GPUImageVideoCamera's resumeCameraCapture method don't work

GPUImageVideoCamera's resumeCameraCapture method don't work
I called pauseCameraCapture then called resumeCameraCapture, but camera didn't resume capture.
here is my code:
- (void)viewWillAppear:(BOOL)animated
{
    [super viewWillAppear:animated];
    [self.vm.recorder.camera resumeCameraCapture];
}

- (void)viewWillDisappear:(BOOL)animated
{
    [super viewWillDisappear:animated];
    [self.vm.recorder.camera pauseCameraCapture];
}

ps: self.vm.recorder.camera is a GPUImageVideoCamera instance.

Same problem here


Question

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53164eff-103d-eca4-525c-10d7a841fafe
Version Independent ID: 49892013-e5d0-4d0a-dce7-18b7008bfe63
Content: Deploy Azure Monitor at scale using Azure Policy - Azure Monitor
Content Source: articles/azure-monitor/deploy-scale.md
Service: azure-monitor
Sub-service: general
GitHub Login: @bwren
Microsoft Alias: bwren

@adravi Thank you for reaching out, not sure if you had any specific feedback or question regarding the documentation please feel free to circle back to us.


MINOR: Remove unused FeatureLevelListener

It looks like this interface has not been used anywhere since the merger https://github.com/apache/kafka/pull/12050.
Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

@chia7712 Hello, PTAL.


Fix http example to write to response

@kjbekkelund ups, sorry didn't see this PR... thanks for noticing and fixing it :)


Better visual GridField selector for “add block” UI

Allow for more UX control than in the default dropdown
Allow thumbnails (e.g. “three squares” icon for a three-image gallery tile)
Categories for available blocks
Description on what a block does
Should be a generic GridField component

Designs: https://projects.invisionapp.com/share/VMDZ9YAGX#/screens/261615433

@newleeland will create some mockups for this.

We're doing this at the moment and tracking progress in issues like https://github.com/dnadesign/silverstripe-elemental/issues/338 https://github.com/dnadesign/silverstripe-elemental/issues/339 https://github.com/dnadesign/silverstripe-elemental/issues/340 https://github.com/dnadesign/silverstripe-elemental/issues/341, let's track progress there to reduce duplication =)