[Enhancement]: Code Licensing from Cosmology's Software

Prerequisites

[X] You read the guidelines for contributing.
[X] You checked that the enhancement has not yet been reported (also through closed issues).

Describe the current behavior
This repository has copied and pasted code from Cosmology's software, but hasn't included the licenses from those repositories. General rule of thumb is that those licenses, while MIT or BSD or Apache, still have to be included inside of this codebase.
While we appreciate the utility of our software in diverse projects, it is crucial to adhere to the licensing terms under which our code was released. The original code from Cosmology is distributed under [MIT/BSD/Apache] licenses, which, among other conditions, require the inclusion of the original license text in any derivative works or distributions.
Explain the motivation
We believe in open-source collaboration and are more than willing to see our software being used widely. However, it is imperative that such use complies with the legal and ethical standards set by the open-source community.
Provide a list of references
No response

Hi dan, meanwhile thank you for getting in touch with us, we also believe in open source and its ethics.
It is not our intent to lack ethics or anything else, if this has happened I apologize and will see to it that it is rectified, can you be more specific with respect to which parts are lacking in licensing with respect to the work belonging to Cosmology? So that we can point it out correctly?
Thank you

Thanks @DavideSegullo
As you mentioned some inspiration/reference w/o copy/paste, you could include it in a "Credits" section, similar to how we do in telescope: https://github.com/cosmology-tech/telescope?tab=readme-ov-file#credits
For the code that was directly copied, feel free to just grab the license and stick it in a folder somewhere, or rename our LICENSE to Cosmology-LICENSE or whatever makes more sense to you
Thanks again and appreciate your work :)

This commit is merely paraphrasing and re-writing our code that was copy/pasted w/o license attribution https://github.com/nabla-studio/quirks/commit/a50727d0d0b9e48b29d4362c0aa449077fb1047e
Their decision to rewrite the function to avoid using our code directly can be a way to sidestep licensing issues, but it closely has been rewritten in a way that resembles ours and our functionality (cleanly I may add). It's substantially similar and clearly derivative, I'd suggest this is not the best approach to resolving this issue.

As agreed with @pyramation, I attach the email communication for transparency.
Discussion on Quirks Project Licensing
From: Dan Lynch
Date: 21 Dec 2023, 03:03 AM
Email<EMAIL_ADDRESS>Hey David,
First off, I want to express our appreciation for the work you've been doing. It's great to see our code from Cosmology being valued and utilized in your projects. This kind of collaboration is what makes the open-source community thrive.
However, some of our team members have noticed an issue that needs your attention. We found that parts of our code from the cosmos-kit, chain-registry, and @chain-registry/keplr libraries (and potentially others) have been copied into your repository without the accompanying licenses. Here's a link to the specific issue we've noticed: https://github.com/nabla-studio/quirks/issues/41.
To stay compliant with the licensing terms, it’s important to include the original LICENSE files from these repositories in your codebase. This step is crucial not only for legal compliance but also for maintaining the ethos of open-source sharing and acknowledgment.
Could you please take a look at this and add the necessary LICENSE files to your repository? This should be a straightforward fix, and it would help ensure that all usage is above board and respectful of intellectual property rights.
Thanks for your understanding and prompt action on this matter. If you have any questions or need further clarification, feel free to reach out.
Dan

From: Davide Segullo
Date: 21 Dec 2023, 02:25 AM
Email<EMAIL_ADDRESS>Hola Dan,
In the meantime I thank you for the report, I appreciate the work you do and I too have used and made some contributions to your libraries, it is obviously not nabla's intent to appropriate anyone's work and so we will make the necessary corrections.
Going into detail, with respect to the libraries you indicated, can you give me confirmation that the parts taken into analysis are the following:

keplr/utils.ts, the use of these utilities, which I specify were imported without using your lib, because having a different chain registry I was having problems with typescript and in fact as you note above I use specific imports of my data types.

Regarding the chain-registry, what do you think was taken from your repository? The scripts I made, which are divided into one for generating the typescript part and one for content, are profoundly different from what you did.
In fact, I wrote this package because in your library the export of data is done in bulk and with a single object, which disabled the possibility of taking advantage of the three-shake, which often forced me to import more dependencies than I needed.

In my specific case there are two scripts to do this:

schema generator
data generator

In fact as you see also the output of the library is different.

Regarding cosmos-kit, what do you think was taken from your repository?

If you refer to the registry of each wallet, I definitely used you as a reference, as already mentioned I used your library and contributed (for example in the part that deals with suggesting cw20 tokens). But you can see that the structure is not identical, also I was working these days to migrate this data structure to the wallet-registry standard.
If there is any specific part that turns out to be copied, could you kindly point me to it so that I also know which licenses I need to point to correctly?
thank you!

From: Dan Lynch
Date: 21 Dec 2023, 10:05 PM
Email<EMAIL_ADDRESS>Hola David,
Thank you for your swift and detailed response. It’s great to see your commitment to resolving these concerns and your valuable contributions to the open-source community. Let's address your points for clarity:
Keplr/utils.ts: Yes this is definitely some of the code that I wrote personally. It's understandable why you needed to adapt our utility code due to TypeScript and chain registry compatibility.
Chain-Registry Scripts: If the scripts in your project are entirely original and not derived from our codebase, then there's likely no issue with licensing. I have a question though, are you interested in collaborating on making these updates in the chain-registry, which is used by a lot of teams? Sounds like maybe we can make some improvements which then we could improve for other devs and the community at large.
Cosmos-Kit: Perhaps this is where things were inspired, I don't see any exact copy paste, but very similar structures and typings, property names here and there. IIf there was inspiration/reference as you mentioned, it would be great to mention it in a readme as you said. Using our work as a reference is a cornerstone of open-source collaboration, and your contributions are highly valued.
Regarding the chain registry scripts and Keplr utils, I see a significant opportunity for collaboration. Given the recent updates/fixes we've made to the Keplr util (which looks like your lib doesn't have), working together could ensure that we all stay aligned with the latest improvements. There's a real chance here to avoid duplication of efforts and ensure that we're all benefitting from the most current and efficient solutions.
I'm thinking along the lines of a joint effort to enhance these tools. Our team is more than willing to examine and potentially integrate your library's advancements into our work. Of course, your contributions would be fully acknowledged and credited. The primary goal here is to consolidate our efforts to bring about the greatest benefit to the community.
How do you feel about this idea? If you're open to it, perhaps we could set up a meeting after holidays to discuss potential collaboration pathways and how we can align our development efforts for mutual benefit.
Dan Lynch
(***) ***-****

From: Davide Segullo
Date: 2 Jan 2024, 10:42 AM
Email<EMAIL_ADDRESS>Hola Dan,
We are back from Christmas vacations, hope you had a good break!
We are currently working on a "references" section to collect the softwares we considered during the design and development of quirks.
As you can see, we are constantly improving the documentation, and this reference will join it.
For sure, "Cosmos kit" is part of the references of this work, together with other libraries from DX and other products. Our research and analysis were conducted with the goal of incorporating the best elements from the current state of the art and addressing any unresolved issues.
WRT the licensing, we're committed to avoiding any appropriation of others' code. At the same time, we do not want to complicate the licensing of quirks. For this reason, we decided to rewrite that function.
According to the opportunity to collaborate, meanwhile we thank you for the proposal, obviously quirks is an open source project and is open to contributions from anyone. Nevertheless, since their profoundly different nature and approaches, we don't think the projects can be combined (neither "cosmos kit" with "quirks" nor the "chain registry").
In conclusion, we will continue to contribute to opensource code and it will be nice to see your contributions to our library as well. Thanks again, see you soon.
PS. Considering the open source spirit that characterizes both nabla and you, we'd love to be able to share this conversation on GitHub so that we can follow up on the issue you've opened and trace the motivations of both of us.
If you agree, in addition to our motivations (which we'll go ahead and report), we'd like to report on your responses as well. Let us know.
Davide

From: Dan Lynch
Date: 4 Jan 2024, 10:39 PM
Email<EMAIL_ADDRESS>I hope this message finds you well. Thank you for your email, and for taking the time to address the concerns regarding our software. I appreciate your initiative in creating a references section, acknowledging the various software inspirations in the development of 'quirks.' This gesture towards recognizing the contributions of different projects is commendable and very much in the spirit of open-source collaboration.
However, I would like to discuss a few important points regarding the licensing and use of our code in your project. As you are aware, the initial version of the function used in 'quirks' was directly copied from our software. Given this direct usage, it is necessary to adhere to the specific licensing requirements. While I understand and respect your decision to rewrite the function to avoid licensing complexities, it is important to consider the legal implications of such an approach.
The rewritten code, as it stands, appears to be a paraphrased version of the original code. Even though the code has been rewritten, if it is substantially similar or derivative, it could potentially infringe on copyright, depending on the originality and complexity of the code in question. It is essential to recognize that rewriting does not automatically circumvent copyright laws, especially if the new code closely resembles the original in function and structure.
In line with the open-source ethos that both Nabla Studio and we cherish, I believe it is crucial to respect and comply with licensing terms. This not only ensures legal compliance but also fosters a healthy and respectful open-source community. In this context, I would suggest that including the appropriate license attribution in your project would be the most straightforward way to resolve this issue. This approach would honor the legal requirements and acknowledge the contribution of our software.
Regarding your proposal to share this conversation on GitHub, I am open to this idea as it promotes transparency and open dialogue in the community.
I look forward to exploring how we can work together in a way that benefits the wider open-source community, respecting each other's work.
Thank you once again for your attention to this matter.
Dan Lynch
(***) ***-****

From: Davide Segullo
Date: 8 Jan 2024, 11:53 AM
Email<EMAIL_ADDRESS>Dear Dan,
I hope this message finds you well.
I want to address your previous concerns regarding the function in question. It is responsible for providing Keplr with a "suggested chain" object and, for this reason, its output and format are specified as requirements. According to its new implementation, it is evident it was independently developed from scratch, without directly copying or paraphrasing existing code.
Anyway, in keeping with our commitment to open-source principles, we are currently integrating the license document you mentioned in our previous exchange (https://github.com/cosmology-tech/chain-registry/blob/main/LICENSE) into the quirks repository to further demonstrate our dedication to open-source practices and attributing value to developers' work.
I would like to remark that quirks was born as a tool to solve the several problems we have encountered over time on both cosmos-kit and other related tools in the ecosystem - as also described in detail here: https://quirks.nabla.studio/docs#why.
Also, I want to let you know that we initially were sorry you thought that our work was a copy/paste or paraphrase of code from existing projects like cosmos-kit, chain-registry, and @chain-registry/keplr. However, we appreciate that your perspective has changed after a closer examination of the code. For this reason, we encourage you to conduct a more thorough initial review in the future to avoid making premature judgments.
In the end, I want to remark that here at nabla, we are strong advocates for open-source contributions. We consistently acknowledge and credit original work as is also evident in the credits section of the quirks repository. Moreover, as you know, our commitment extends beyond mere recognition, as we actively contribute to projects like cosmos-kit and others - as demonstrated by our past works.
We hope for your future contribution to quirks, in the spirit of an innovative and respectful open-source community to which we are being.
Happy coding!
Best regards,
Davide

Appreciate it!
Since it seems we may have been misunderstood, I'd like to mention that our perspective of code copy/pasted can be verified from git commits, which is not a premature judgement. Anyhow we don't need to spend more time on this, thanks for squaring it away :)
This is just the top of one of the files. The structure which has been credited (thank you) nearly replicates cosmos-kit identically in terms of class structure, and associated files such as registry.ts, and extension.ts per each wallet.

https://github.com/nabla-studio/quirks/blame/2be816409507b35865492ab75280dd4d4683e4ee/packages/wallets/src/keplr/utils.ts
https://github.com/cosmology-tech/chain-registry/blame/c8644d2e748b506abf7e174f2c50bfdb77277ca8/packages/keplr/src/index.ts


User File Uploading Damages Certain Files

When specially encoded (in this case, not utf-8 encoded) files are uploaded by the user, they are corrupted and cannot be opened or read as normal.
Example: .jpg files and .pptx files:

This is due to we cannot have a general solution for all different file types and encodings. To support other file formats, we have to integrate the corresponding encoder/decoder.
As we are good with utf-8 files for now, we may not consider moving forward with other files in the near future.


Rename action methods without verb

Proposed Changes
Several action methods (mostly around options) did not begin with a verb which is confusing. As 1.0 has not been shipped yet, renaming them for clarity.

@MartinHjelmare Ok I think I got them all. It was mostly the options methods with issues outside of addon as I followed the same pattern for all of them.


Added settings option to show started events

This pull request introduces an option to show already started events.
Since the current version does filter by the starting datetime, I've added a check to see whether the event has ended.
If the started events are shown, the events list get filtered by their end date.
If the settings option is not present, the behaviour is as before.
The develop branch was not working for me (one error from UIKit and another from the parseISO function in date-helpers.js), therefore I've made a branch from master.

Thanks for your pull request!
These changes look good to me. If @schefbi agrees, we can merge them.

The develop branch was not working for me (one error from UIKit and another from the parseISO function in date-helpers.js), therefore I've made a branch from master.

This shouldn't have happened. Did these errors occur while you were building the project? Have you tried to run npm install to update the dependencies?

Sorry, this change was not supposed to land in this branch...

@AramLoosman Bitte im wiki dokumentieren!

@sche Ich habe einen Eintrag hinzugefügt. Ich weiss nicht, ob Aussenstehende Wikis bearbeiten können.

This shouldn't have happened. Did these errors occur while you were building the project? Have you tried to run npm install to update the dependencies?

Yes I have. I get an error when running ember serve and also in the frontend/dev.console.

Thanks for reporting the bug. We'll track it in issue #62.


Uncaught TypeError: Cannot read property 'namespace' of undefined

I am currently using "vue-formio": "^4.0.7" without Typescript and coming across the 'namespace' error.
I was able to fix the issue by editing Form.js line 144
from
var namespace = _this.options.namespace || 'formio';
to
var namespace = _this.hasOwnProperty('options') ? _this.options.namespace : 'formio';
When I pushed the code into production via vercel it is retrieving the current lib, is there a way to extend the Form.js setupForm function with my changes?

I was able to add my changes into my production build by using this fix via patch-package!

I've just found this same error. Can we reopen this issue, as it is not fixed yet?


add validation, mutation, and signed policy icons

For the validation and mutation icons use a label that doesn't take color (use the border outline color)
- they should be wrapped in a square box
Leverage #76 to add the properties before we have the api in place for the policy hub

Moving to blocked as the integration with ArtifactHub (#83) will give us the ability to query for these properties.

Reference f2155c1, f270ab1
Currently using generic icons until eos-icons and rancher-icons are merged.


Unable to Install latest Dbeaver Eclipse Plugin

System information:

Operating system Win10
DBeaver version - DBeaver IDE	<IP_ADDRESS>105160657
Additional extensions -

Connection specification:

Database name and version
Driver name
Do you use tunnels or proxies (SSH, SOCKS, etc)?

Describe the problem you're observing:
unable to install the plugin. getting following error
Cannot complete the install because one or more required items could not be found.
Software being installed: DBeaver IDE <IP_ADDRESS>105160657 (org.jkiss.dbeaver.ide.feature.feature.group <IP_ADDRESS>105160657)
Missing requirement: DBeaver MySQL Support <IP_ADDRESS>105160657 (org.jkiss.dbeaver.ext.mysql <IP_ADDRESS>105160657) requires 'bundle com.sun.jna.platform 0.0.0' but it could not be found
Cannot satisfy dependency:
From: DBeaver Databases <IP_ADDRESS>105160657 (org.jkiss.dbeaver.db.feature.feature.group <IP_ADDRESS>105160657)
To: org.jkiss.dbeaver.ext.mysql [<IP_ADDRESS>105160657]
Cannot satisfy dependency:
From: DBeaver IDE <IP_ADDRESS>105160657 (org.jkiss.dbeaver.ide.feature.feature.group <IP_ADDRESS>105160657)
To: org.jkiss.dbeaver.db.feature.feature.group [<IP_ADDRESS>105160657]
Steps to reproduce, if exist:
installed fresh eclipse, and trying to install the Dbeaver plugin
Include any warning/errors/backtraces from the logs

Cannot complete the install because one or more required items could not be found.
Software being installed: DBeaver IDE <IP_ADDRESS>105160657 (org.jkiss.dbeaver.ide.feature.feature.group <IP_ADDRESS>105160657)
Missing requirement: DBeaver MySQL Support <IP_ADDRESS>105160657 (org.jkiss.dbeaver.ext.mysql <IP_ADDRESS>105160657) requires 'bundle com.sun.jna.platform 0.0.0' but it could not be found
Cannot satisfy dependency:
From: DBeaver Databases <IP_ADDRESS>105160657 (org.jkiss.dbeaver.db.feature.feature.group <IP_ADDRESS>105160657)
To: org.jkiss.dbeaver.ext.mysql [<IP_ADDRESS>105160657]
Cannot satisfy dependency:
From: DBeaver IDE <IP_ADDRESS>105160657 (org.jkiss.dbeaver.ide.feature.feature.group <IP_ADDRESS>105160657)
To: org.jkiss.dbeaver.db.feature.feature.group [<IP_ADDRESS>105160657]

reinstalled eclipse and tried again, worked. hence closing the issue,


zl group freeze

here's an issue with group when its group size is larger than the max list size. This freezes Pd.

fixed with https://github.com/porres/pd-cyclone/commit/a4faf589a3903da1189d36ceba596d231b9fae4a


snippets not working

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.75.0
OS Version: windows NT x64 10.0.22000

Steps to Reproduce:

test.html

html.json
2.
The feature will not work. Since yesterday

/duplicate of #173244 which is currently pinned at the top or the Issues page.
Already fixed in Insiders and will be in upcoming 1.75.1

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Undeclared Identifier : [Package]

Hello! I'm finding: C:\Users"user"\AppData\Local\Temp\nimble_5952\githubcom_blmvxernimnmap\nmap.nimble(3, 2) Error: undeclared identifier: 'Package'.
I've commented line 3 and 13, removed the name property, changed the folder from alpha to nmap and updated the property requires to : requires "nim >= 0.19.4". After that I was able to build it from my temp folder.
Strangely I was able to build it from https://nimble.directory/pkg/nim-nmap ,
Thanks for your mod!

I fixed this: https://github.com/TensorTom/nim-nmap/blob/master/nmap.nimble
Please merge. Until merge, you can do: nimble install https://github.com/TensorTom/nim-nmap.git


Compile fails on clang 9.0.0

Arch Linux
clang version 9.0.0 (trunk) (llvm/trunk 358753)
clang -Werror -Wall -Wno-unknown-warning-option -Wno-multichar -Wno-int-in-bool-context -std=gnu11 -D_GNU_SOURCE -DVERSION="0.11.1" -I. -D_USE_MATH_DEFINES -Wno-deprecated-declarations -g -DGB_INTERNAL -c Core/timing.c -o build/obj/Core/timing.c.o
clang -Werror -Wall -Wno-unknown-warning-option -Wno-multichar -Wno-int-in-bool-context -std=gnu11 -D_GNU_SOURCE -DVERSION="0.11.1" -I. -D_USE_MATH_DEFINES -Wno-deprecated-declarations -g -c Misc/wide_gb.c -o build/obj/Misc/wide_gb.c.o
Misc/wide_gb.c:154:47: error: format specifies type 'unsigned long long *' but the argument has type 'WGB_exact_hash *' (aka 'unsigned long *') [-Werror,-Wformat]
                sscanf(line, "%llu,%i,%i,%i", &frame_hash, &scene_id, &scene_scroll.x, &scene_scroll.y);
                              ~~~~            ^~~~~~~~~~~
                              %lu
Misc/wide_gb.c:218:57: error: format specifies type 'unsigned long long' but the argument has type 'WGB_exact_hash' (aka 'unsigned long') [-Werror,-Wformat]
                fprintf(frames_file, "%llu,%i,%i,%i\n", scene_frame->frame_hash, scene_frame->scene_id, scene_frame->scene_scroll.x, scene_frame->scene_scroll.y);
                                      ~~~~              ^~~~~~~~~~~~~~~~~~~~~~~
                                      %lu
2 errors generated.
make: *** [Makefile:162: build/obj/Misc/wide_gb.c.o] Error 1

(Thanks for enabling the issue tracker!)

I think that this highlights another problem. -Werror shouldn't be used by default when compiling. I imagine that the idea is to force developers to not introduce new warnings, but different versions of compilers may have different warnings, so it isn't realistic to expect that your code is always going to be warning-free.


Mixcloud throws 'postMessage' on 'DOMWindow' error and invalid VidYard url doesn't fire onReady.

Current Behavior

Passing a valid Mixcloud url to react-player throws "Failed to execute 'postMessage' on 'DOMWindow'" error message even though the player successfully loads. I noticed this same issue occurred previously with YouTube in this ticket. I'm wondering whether or not the library can do anything about it given this comment from the author and if the same fix for YouTube can even apply here.
Passing an invalid VidYard url to react-player doesn't fire onReady (as well as mixcloud) like SoundCloud for example. Also wondering if the library may or may not be able to do something about it.

Expected Behavior

Mixcloud doesn't throw "Failed to execute 'postMessage' on 'DOMWindow'"
VidYard (and Mixcloud) to call onReady.

Steps to Reproduce

Visit CodeSandbox link (these issues can even be reproduce in the demo site).

Environment

CodeSandbox example: https://codesandbox.io/s/nostalgic-montalcini-phpkg?file=/src/App.js

Other Information
Mixcloud error messages:

Vidyard error messages:

In case anyone would actually be looking at this...
<!DOCTYPE html>
<html>
	<head>
		<script src="https://widget.mixcloud.com/media/js/widgetApi.js" type="text/javascript"></script>
		<script type="text/javascript">
			function loadVideo() {
				const frame = document.getElementById("myframe");
				const player = Mixcloud.PlayerWidget(frame);
				player.ready.then(function() {
					console.warn('player loaded');
				});
			}
		</script>
	</head>
	<body>
		<button onclick="loadVideo()">Load video</button>
		<iframe id="myframe"></iframe>
	</body>
</html>

StackBlitz


Migrate to AndroidX

Is your feature request related to a problem? Please describe.
Migrating to AndroidX is inevitable!!
Describe the solution you'd like
Update the freshdesk android dependency to the latest version. I had requested this to the freshdesk team they now support AndroidX. Check this issue
Describe alternatives you've considered
Nil
Additional context
Mark the latest version number that doesn't support AndroidX and put that in README.md

I will update the Freshchat SDK to version 2.9.0. But if you are facing problems in the meantime have you tried adding these properties to gradle.properties
android.enableJetifier=true
android.useAndroidX=true

@daadu Updated the package to version 1.2.1 this includes the new Freshchat android version 2.9.0.

@fayeed Please migrate it to AndroidX
App is crashing at start and the app is already migrated to AndroidX.
java.lang.RuntimeException: Unable to get provider android.support.v4.content.FileProvider: java.lang.ClassNotFoundException: Didn't find class "android.support.v4.content.FileProvider" on path: DexPathList[[zip file "/data/app/com.clickparamount.agency-WxREl3jYvqli1_ag0EefAw==/base.apk"],nativeLibraryDirectories=[/data/app/com.clickparamount.agency-WxREl3jYvqli1_ag0EefAw==/lib/arm64, /data/app/com.clickparamount.agency-WxREl3jYvqli1_ag0EefAw==/base.apk!/lib/arm64-v8a, /system/lib64]]

@amitkhairnar44 you just need to change this line in AndroidManifest.xml.
From this:
        <provider
        android:name="android.support.v4.content.FileProvider">

To this:
        <provider
        android:name="androidx.core.content.FileProvider">

@fayeed Thank you
Issue is resolved now
Please update the documentation


Added Microsoft Direct X Web Installer v9.29.1974.1

[ Yes ] Have you signed the Contributor License Agreement?
[ Yes ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ Yes] Have you validated your manifest locally with winget validate --manifest <path>?
[ Yes ] Have you tested your manifest locally with winget install --manifest <path>?
[ Yes] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-No-Executables


[ASK] colspan in a row

Hello,
Is it possible if i do colspan in my rows ?

There is no colspan function.

Ok.


refactor: clean code

Pull Request: Refactor/clean code
Description:
The goal of this PR is to introduce the implementation of the TryFrom trait for the RustAgent struct. Moreover, the point is also to clear the code, cleaning unwrap and other bad practices.
Changes:
Todo :

[x] Changed From to TryFrom (Rust agent)
[ ] Handle some unwrap()
[ ] ...

Testing:
As before

As we discussed, sounds like it would be too much work to refactor everything up to tonight :/


Possible bug in circles model

Just noticed that on Line 71 of circles/functions.c the value of xmemory->fx is being overwritten with the count of the number of iterations at the end of the kernel. This seems out of place, as xmemory->fx and xmemory->fy have been adjusted within the neighbourhood search and nothing done with the result (so why would they be treated differently?).
https://github.com/FLAMEGPU/FLAMEGPU/blob/master/examples/CirclesBruteForce_float/src/model/functions.c#L71

Working on fix now, bug present in 3 versions, offending line of code was commented out in float partitioned circles.

https://github.com/FLAMEGPU/FLAMEGPU/pull/10


Allow  to generate

<TonConnectButton> always generates <button> without type= attribute. As such, it can't be used inside <form>, as it works as <button type="submit"> and intercepts form submits when users presses Enter.
There should be a way to generate <button type="button">. In fact, it should be the default mode, as there is never a reason for Wallet Connect button to behave as a form submit button.

This seems to require a change in upstream as well.


Have service methods return a Result<T>.

To accomplish this, there will have to be a decent number of backwards incompatible changes, but moving towards long-term stability and interoperability with the async I/O ecosystem, this may be a HUGE win. Some of the biggest benefits:

error type coercion could be defined and then used in handlers for better error handling and propagation.
for gRPC patterns of error handling where the error is embedded in the response type (way more flexible), this would still work. Wouldn't be able to use ? though.
the async/await ecosystem seems to be depending upon #[async] methods having a return type of Result<T>. Aligning with this will help in achieving C10K+ level throughput with these services.

I know it is not as simple as this. The grpc lib here has a lot of code built up around not returning Result types. But I wanted to at least get the discussion started. I would rather put in the work on this project as opposed to start a completely new project.

I'm not sure I understand.
Result is now Future or Stream.
AFAIU, these two declarations should be equivalent:
trait MyService {
    fn foo(&self) -> Future<MyReturn, MyError>;
    #[async]
    fn foo(&self) -> Result<MyReturn, MyError>;
}

(Unfortunately, I couldn't verify it, because compiler reports error when I use #[async] in trait).
So trait signatures in grpc are async now. And ideally you should be able to choose async/await or direct future/stream implementation, and it doesn't matter which style declaration is.
(And even if it wouldn't possible to implement function with Future signature with #[async], you can always use async_block!).
C10K is possible now, because functions are async, as I said.

What is the benefit of returning Result as opposed to a Future? I can't see any, more than that - I see it as harmful for the interfaces - ServiceAsync? I think we just recently got rid of that.

error type coercion could be defined and then used in handlers for better error handling and propagation.

I am not sure I understand but futures are defined as Future<Item=T Error=E> whereas results are defined as Result<T, E> and both contain the same error type information.

for gRPC patterns of error handling where the error is embedded in the response type (way more flexible), this would still work. Wouldn't be able to use ? though.

gRPC error codes could be returned either using a Result or a Future type.

the async/await ecosystem seems to be depending upon #[async] methods having a return type of Result. Aligning with this will help in achieving C10K+ level throughput with these services.

I am not completely sure I understand what do you mean but maybe you are more concerned about scheduling of these futures on the server?

Hey all, thanks for getting back with me. All solid feedback, and after reviewing your comments a few times, I am left with a few questions & a few things I need to test. Looks like I am at least incorrect on the title of this issue, but a few things are still up in the air:

AFAIU, these two declarations should be equivalent:

@stepancheg in principal I agree, however:

(Unfortunately, I couldn't verify it, because compiler reports error when I use #[async] in trait).

Yea, I will need to do some additional testing as well (needs to be on nightly, of course), just to ensure there are no edge cases we are overlooking.
Just to expound on a few points (which I should have clarified in my original comment):

the efforts around async/await in rust are falling into pretty specific patterns. One of those patterns is described here: https://github.com/alexcrichton/futures-await#technical-details

#[async] - this attribute can be applied to methods and functions to signify that it's an asynchronous function. The function's signature must return a Result of some form (although it can return a typedef of results). Additionally, the function's arguments must all be owned values, or in other words must contain no references. This restriction may be lifted in the future!

The essence of this issue is focused on alignment with where async/await is going in rust (I know it is not stable yet, but mostly trying to generate discussion and todo items for this), and the futures-await effort seems to be a source of truth on that front.
The area where I appear to be incorrect: when a function is marked with #[async] (which requires a return Result type), its Result type is transformed into a future. So that should mean this crate is g2g (though, as mentioned above, needs to be tested to be sure).

lastly, my points about use of ? for error propagation & coercion; I supposed they are still valid, however a function could simply be written with a return type of Result & then mark that function as #[async] & it should satisfy the traits generated by this grpc/proto system AND would allow use of ?.

So, @crackcomm

What is the benefit of returning Result as opposed to a Future?

I am most likely incorrect with that sentiment in the title of this issue. We should be able to keep the return types as Futures & if someone wants to use #[async], they should be able to without any issue.

The items that are outstanding then:

test this on nightly by using methods returning Results & marked with #[async] and ensure they still work with the generated code (they should coerce to the needed Future types ... we'll see).
as far as scheduling of the futures, would be nice to experiment with the new tokio revamp which is taking place, so that we could use cpu pool or tokio/mio reactor for higher throughput (depending on workload, of course).

I understood this issue was a request to switch from {Single,Streaming}Response to a Result<...> type in rpc methods in service traits. Is that correct?
The answers seem to indicate this is already possible, but looking at the library code, I don’t see how.
Cheers.

@andrenth the idea is that if you choose to use nightly & enable proc macro, conservative impl trait & generators as described here, then you can simply decorate one of your handlers with #[async] and it will transform your Result into a Future.
** Disclaimer, theoretically this should work with the gRPC system here, but per my comments above, this remains to be tested. Please report your findings if you get around to doing this.

@thedodd Yeah, I understood that idea, but currently handlers return SingleResponse or StreamingResponse, not Result. That's why I'm confused.

Yea, both types of futures. The question that needs to be answered is if the compiler will coerce our Result type (which is already being coerced into a Future when the function is decorated with #[async]), into the appropriate SingleResponse or StreamingResponse future.
Need to test and find out where the walls are. Hopefully I’ll be able to do so as well soon.

Hopefully I am answering your question effectively.

I think I see what you mean now. They're not futures exactly, but newtypes for futures. What you're trying to find out is if the #[async] decorator will see through that.

Yea, https://docs.rs/grpc/0.2.1/grpc/struct.SingleResponse.html looks like they are thin wrappers around GrpcFuture. Could be problematic.

So, it has been quite some time since this discussion was started.
Per the discussion we had going above, the return type of the services (E.G., those which return a SingleResponse, same with the other response types), are not actually futures. They are just structs which wrap a future, but are not actually futures.
So, as of now, we can not actually decorate service request handlers with #[async] or #[async(boxed)]. E.G.:
/// *NOTE:* the return type here is neither a `Result` nor a `Future`.
/// It is a struct wrapping a `Future`, but itself does not impl `Future`.
fn create_project(&self, opts: RequestOptions, req: CreateProjectRequest) -> SingleResponse<CreateProjectResponse> { ... }

Per the above example, decorating the fn with #[async] would break due to the fact that the return type no longer conforms to the generated grpc code. Moreover, decorating and updating the return type to be a result (or any other type), breaks for the same reason.
All in all, I should update the title to be Have service methods return a `Future<T>`. If this change were to be made, then we could use async/await out of the box with this framework.

Has there been any progress on this? I'd be willing to put time into it and send a patch if I had some guidance on what's acceptable. Is modifying the service trait functions to return a Future<T> acceptable?

@autrilla I’ve been using a workaround. Basically I’ve been having the service impl methods call private methods which are async, and then wrap the future in the SingleResponse type or the appropriate stream type from the service impl method.
This has been working pretty well, and has allowed for significantly more robust error handling.
Once the response types are restructured to use futures, then we won’t need private async methods anymore.
As far as framework progress in this front, haven’t seen any movement yet.

@thedodd thanks a lot for the response. I'm not sure I understand how you wrap the future in the SingleResponse. Do you just manually create the SingleResponse with ::new, adding the metadata in yourself?


MockFileSystem.File.Move on Windows and .Net 8 doesn't rename a file name's case

Describe the bug
Possibly related to https://github.com/TestableIO/System.IO.Abstractions/issues/1138
On Windows and .Net 8, FileSystem.File.Move successfully renames a file if the destination has a different case than source whereas MockFileSystem.File.Move doesn't rename the file.
To Reproduce
Steps to reproduce the behavior:
Using System.IO.Abstractions.TestingHelpers 21.0.29
static void Main(string[] args)
{
    FileSystem fs = new FileSystem();
    MockFileSystem mockFs = new MockFileSystem();

    Console.WriteLine("Real file system");
    MoveFile(fs);

    Console.WriteLine("Mock file system");
    MoveFile(mockFs);
}

static void MoveFile(IFileSystem fileSystem)
{
    string tempDir = fileSystem.Path.GetTempPath();
    string src = fileSystem.Path.Combine(tempDir, "src.txt");
    string dest = fileSystem.Path.Combine(tempDir, "SRC.TXT");  // different case

    // create source file
    using (_ = fileSystem.File.Create(src))
    {
    }

    // move file
    fileSystem.File.Move(src, dest);

    // check the moved file's name exact case
    string movedFile = fileSystem.Directory.GetFiles(tempDir, "src.txt").First();
    Console.WriteLine($"Successfully moved \"{src}\" to \"{movedFile}\"");

    if (fileSystem.File.Exists(src))
        fileSystem.File.Delete(src);

    if (fileSystem.File.Exists(dest))
        fileSystem.File.Delete(dest);
}

Actual output
Real file system
Successfully moved "C:\Users\El-Gor-do\AppData\Local\Temp\src.txt" to "C:\Users\El-Gor-do\AppData\Local\Temp\SRC.TXT"
Mock file system
Successfully moved "C:\temp\src.txt" to "C:\temp\src.txt"

Expected behavior
MockFileSystem.File.Move should successfully rename the file to SRC.TXT
Real file system
Successfully moved "C:\Users\El-Gor-do\AppData\Local\Temp\src.txt" to "C:\Users\El-Gor-do\AppData\Local\Temp\SRC.TXT"
Mock file system
Successfully moved "C:\temp\src.txt" to "C:\temp\SRC.TXT"

When fixing this, it would probably be easy to also have an eye out for the correct behaviour in File.Copy and File.Replace when source and destination differ only in casing...

Hi @vbreuss, @El-Gor-do,
first time contributor here. I would like to look into fixing this.

Hi @vbreuss, @El-Gor-do,
first time contributor here. I would like to look into fixing this.

Please feel welcome to create a pull request.

@vbreuss - I'll look into this, Bro. Please assign it to me👍

@RobinDoesUnity :
Are you still working on this issue?

Hi @vbreuss, you can assign it to someone else. Sorry, I was busy these days.


Crashes when settings.xml is missing or has invalid format

The Settings.xml format changed in 0.16.0 to support a new settings menu and to eliminate hardcoded settings. The new settings file is incompatible with ones from older versions. Nanoforge crashes on startup if your settings file isn't using the new format or is missing.
The crashes should be fixed and if the settings file is missing or invalid an empty one should be generated.

Fixed by 564022d1cc7f7868bc55b399e3f5b1fbcbf61652.


feature request: click on legend items to filter map

Plotly has a nice feature that when click on items in a legend it filters the data.
For instance, in this map, you can toggle the data on or off:
https://plot.ly/~Dreamshot/547/access-to-paid-vacation-by-occupation-private-industry-2010-2014/
I've spoken to lots of people who want ways to filter data on their maps from the editor. This seems like a natural way to incorporate that.

Already planned! :)
Look at this! :) -> https://github.com/CartoDB/cartodb-management/wiki/Embeds-revamp

nice! you're steps ahead of me :)


Filetype plugin not recognised when using generic filename _.vim and plugin starts with the recommended disabling option

Steps to reproduce

Create three files entitled text.vim, text_a.vim and text_b.vim within the folder ~/.vim/ftplugin (you may have to create this folder if it does not exist):

Copy and paste the following into text.vim:

" Disabling option per :help write-filetype-plugin
if exists("b:did_ftplugin")
	finish
endif
let b:did_ftplugin = 1

nnoremap <leader>test :echom "echo from text"<CR>

Copy and paste the following into text_a.vim:

" Disabling option per :help write-filetype-plugin
if exists("b:did_ftplugin")
	finish
endif
let b:did_ftplugin = 1

nnoremap <leader>testa :echom "echo from text_a"<CR>

Copy and paste the following into text_b.vim:

nnoremap <leader>testb :echom "echo from text_b"<CR>

Now returning to your home directory create a generic text file:

echo "hello world" >> hw.txt

Opening the text file using vim (vim hw.txt) and test each of the files in turn by entering <leader>test, <leader>testa and <leader>testb.  The first and last of these commands will work correctly (you will see the echo statement), the second statement will fail and instead vim will enter insert mode.

Expected behaviour
The second command above, <leader>testa, should show an echo statement.
The higher order issue is that filetype plugins do not appear to be recognised when they are given a generic filename in the format of <filetype>_<name>.vim (as per :help ftplugin-name) and they additionally include the recommended disabling option if exists("b:did_ftplugin") (as per :help write-filetype-plugin).  Filetype plugins that follow the naming format <filetype>.vim or do not include the disabling option do not appear to be affected.
This appears to be a breaking change introduced in a relatively recent update (though unsure which) as I have only become aware of it as my own ftplugin, vim-groff-viewer, ceased working for no obvious reason.
Apologies in advance if this is some configuration problem on my side, I've spent a good while trying to narrow down other options (e.g. deleting all plugins that might be interfering).  I at first thought the issue was nroff files only, but it appears to be wider.
NB - This issue also affects neovim v 0.9.1 (which admittedly tends to be my daily driver), I have not reported there.
Version of Vim
9.0.1678
Environment
OS: Manjaro Linux 23.0.0
Terminal: alacritty
Shell: zsh
Logs and stack traces
None.

So after several more hours of chasing my tail, I realise the above is wrong.  I thought that the combination of <filetype>_<name>.vim plus disabling option was key.  It isn't that specifically - in the above example if you delete text.vim then text_a.vim will echo a statement.  It is only when text_a.vim exists at the same time as text.vim (plus disabling option) that this behaviour is seen.  And it does not appear to be a particularly new issue (if an issue is what it is) - I've checked on older versions of vim and it happens there too.
This may even be correct behaviour, which seems slightly odd, but possible; appreciate being put out of my misery...

Yep, ok, pretty sure this is correct behaviour.  No issue.  Whatever the issue is with my plugin, it is related, but isn't this.


Make sure paramiko version is pinned.

Proposed fix for issue: https://github.com/internaphosting/netman/issues/5

:+1:

:+1:


python.exe doesn't support asyncio. The issue can be worked around by re-running idf.py with the "--no-hints" argument. (IDFGH-9499)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
master
Operating System used.
Windows
How did you build your project?
Command line with Make
If you are using Windows, please specify command line type.
None
Development Kit.
ESP32-C6-WROOM-1
Power Supply used.
USB
What is the expected behavior?
Executing action: flash
Running ninja in directory C:\Users\Developer\espressif\HA_on_off_light\build
Executing "ninja flash"...
ERROR: D:\Espressif\python_env\idf5.1_py3.7_env\Scripts\python.exe doesn't support asyncio. The issue can be worked around by re-running idf.py with the "--no-hints" argument.
What is the actual behavior?
Upload
Steps to reproduce.
try to flash anything
Debug Logs.
No response
More Information.
No response

Please use the Windows tool installer from https://dl.espressif.com/dl/esp-idf/ in order to install a working environment. The Python environment the installer offers doesn't have this issue and solves other potential issues as well.

@georgik Just in idea: Maybe the installer needs another sanity check for determining which Python is suitable. We could test if asyncio support is present or not.
There was another report recently (#10712).

@dobairoland The embedded 3.8 shipped with the installer should be ok. Or are there some missing parts. It is some time after it is EOL, but it is the only remaining version supporting Windows 7. Probably with dropping of 4.1 by the end of February we can drop also 3.8 and move forward to more modern version.

The embedded 3.8 shipped with the installer should be ok. Or are there some missing parts?

@georgik Yes, that one is perfectly fine.
At least at some point there was the possibility to select Pythons which are already installed on the computer. I remember you mentioned some kind of sanity checks these need to pass in order to be eligible to use it with ESP-IDF. Is this no longer supported? If not then you can ignore my suggestion.

Please use the Windows tool installer from https://dl.espressif.com/dl/esp-idf/ in order to install a working environment. The Python environment the installer offers doesn't have this issue and solves other potential issues as well.

Yes, that works

Answers checklist.
I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
I have checked if the solution shared before works but nothing changed.
Operating System used.
Windows
How did you build your project?
With the toolbar "build" then run but run is not working
If you are using Windows, please specify command line type.
None
Development Kit.
ESP32-C6-WROOM-1
Power Supply used.
USB
What is the expected behavior?
C:\esp-idf-v5.1-rc2\tools\check_python_dependencies.py:12: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
import pkg_resources
Executing action: flash
Running ninja in directory C:**\eclipse-workspace_esp32\test4\build
Executing "ninja flash"...
ERROR: C:\Espressif\python_env\idf5.1_py3.7_env\Scripts\python.exe doesn't support asyncio. The issue can be worked around by re-running idf.py with the "--no-hints" argument.
What is the actual behavior?
return error
Steps to reproduce.
try to flash anything
Debug Logs.
No response
More Information.
No response


Created NodeJS Backend

Moved React Frontend to client folder and created server in root directory.
(Followed Heroku convention; you can move these files to server folder if needed).
Created a basic node server.
Added concurrently and nodemon as devDependencies.

concurrently is used to run commands simultaneously.
nodemon is only used in development mode.

If using JWT token make sure to add cookie parser

Removed Redundant backend folder from client directory.
Client is always nested in server and not vice-versa.
Please store all private keys in .env


7277 Codified Error Messages

Updated the ActionMessages.kt -> InvalidHL7Message() method to take an optional ‘ErrorCode’ string
Created an enum ‘ErrorCode’ to allow for consistent nomenclature and containment of the error codes to be passed into the InvalidHL7Message() method or the FieldPrecisionMessage() method.
The front-end can then use the 'ErrorCode' to display a friendly message. i.e. In FileHandlerMessaging.tsx -> ErrorRow we call the ErrorCodeTranslation enum which maps the error codes to a friendly message.

Test Steps:

Log into RS as Admin
Click on the Validate feature and validate an hl7 file that contains invalid phone or a ValidationError
Notice the Error message is now friendly

Changes

Checklist
Testing

[ ] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Linked Issues

Fixes #7277

Looks like Test test incorrect HL7 content() FAILED is breaking the back-end build


fix(app): do not delete autosaves before restoring

I wish you could hide PRs...

I wish you could hide PRs...

Haha, you didn't exactly go stealth in the naming of the PR. fix: restore expected autosave behaviour would have been the other option :)

I tested the following scenarios:

launch a session, add files, shut it down, recover work (session_commit=HEAD, autosave_root_commit=HEAD)
same as the above except add files and commit them (but do not push the changes)
same as the above but with a combo of committed and uncommitted work
launch a session, add stuff, commit and push, then add more file, then shut session down, then launch a session from commit HEAD-1 (session_commit=HEAD-1, autosave_root_commit=HEAD-1) - in this case the work is restored
same as above except launch a session from HEAD (session_commit=HEAD, autosave_root_commit=HEAD-1) in this case the work is not recovered and the autosave branch is deleted


Turn off caching distinct relative globs

Because MSBuild globs preserve the fixed directory from the project file instead of returning fully qualified paths, it is harder than previously thought to cache distinct relative globs pointing to the same file, as the cached glob expansions would need to be rebased to multiple fixed directory parts.

Issue to turn back optimization: #3889


Events "buddylist_overlay" and "chatproxy-presence" never received

Description of the problem
When listening, events "buddylist_overlay" and "chatproxy-presence" are never received, so the getUserActiveStatus() method always returns None. Is it just me?
Code to reproduce
from fbchat import Client
client = Client("email", "pw")
client.listen(markAlive=True)

Environment information

fbchat 1.7.3

On a brighter note I found that the following request:
POST https://m.facebook.com/buddylist_update.php HTTP/1.1
Host: m.facebook.com
Cookie: ...

data_fetch=true&send_full_data=true&THEUSUALPAYLOADSTUFF

returns the list of ids of the currently active friends if the following form (status=0 is active/idle):
{
  "__ar": 1,
  "payload": {
    "buddylist": [
      {
        "id":<PHONE_NUMBER>26604,
        "status": 0
      },
      {
        "id":<PHONE_NUMBER>,
        "status": 0
      },
      ...

Hmm, concerning, I'll have a closer look when I get the time. Possibly related to #430?

Well monitoring the websocket I'm seeing this messages, so it's possible:
.../orca_presence{"list_type":"full","list":[{"u":XXXXXXXXX,"p":0,"l":1566490349},{"u":XXXXXXXXX,"p":2,"c":9969664},{"u":XXXXXXXXX,"p":0,"l":1566493521},{"u":XXXXXXXXX,"p":0,"l":1566494154,"c":9961488}...

The given request is useful.  Trouble is, if you want to be up-to-date on who's online and who's not you have to send this request a lot.  It would be great if the buddylist_overlay event (or whatever is being used) would work in that situation.

Should be fixed in #494, release v1.9.0


warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>

Exerpt from package.json
"peerDependencies": {
"jquery": "1.9.1",
"popper.js": "^1.16.0"
}

Your package.json should have our peerDependencies and dependencies.

@XhmikosR react-bootstrap/react-overlays depends on @popperjs/core v2.0.0. May be this is to do with their implementation, but I wonder if bootstrap also upgrades this package it causes breaking changes elsewhere? Those packages already taken the risk if there is one.

We won't be updating to popper.js 2.x in v4 because it drops support for some browsers that our v4 supports. For master it's planned as long as someone provides a patch.


Add support for overloading comparison operations in relay (#2910)

This commit adds support for overloaded comparison operators in the python binding for relay. I'm not sure how best to add testcases for this and couldn't find any obvious examples. A simple python script that uses all the comparison operators as in the issue #2910 report works just fine.
This is my first contribution to tvm, so all suggestions are welcome.

Looks good, could you add some tests cases to ensure it is working as intended?

Thanks for the feedback . I've had a look and tried to add some testcases and there was something that puzzled me and I don't fully understand.
I would have expected a testcase like this to pass.
from tvm import relay
a = relay.Var("a")
b = relay.expr.const (1.0, dtype='float32')
c = (a == b)
d = relay.equal(a, b)
assert (c.astext() == d.astext())
while
c = (a < b)
d = relay.less (a, b)
assert (c.astext () == d.astext ())
passes.
Any clues / suggestions ?

We don't overload equality because it interacts with Python's collections is ways which are not desirable. You should just test the comparisons you added.
We can add an english method for checking equality if we want.

ping @u99127

@tqchen - sorry I've been a bit busy recently. I've now pushed in my updates with the tests.

thanks @u99127 , this PR is now merged


[SPARK-41127][CONNECT][PYTHON] Implement DataFrame.CreateGlobalView in Python client

What changes were proposed in this pull request?

This PR adds CreateGlobalTempView and CreateOrReplaceGlobalTempView to Python DataFrame API.
Meanwhile, this PR extends LogicalPlan to let it have the ability to deal with Command.
Why are the changes needed?

Improve API coverage.
Does this PR introduce any user-facing change?

NO
How was this patch tested?

UT

Can one of the admins verify this patch?

Merged to master.


Fixed wrong json content for ValidErrorTx transaction [ECR-2444]

Overview
Fixed the method that used to return wrong JSON representation of the ValidErrorTx transaction.

See: https://jira.bf.local/browse/ECR-2444
Definition of Done

[x] There are no TODOs left in the code
[ ] Change is covered by automated tests
[x] The coding guidelines are followed
[x] Public API has Javadoc
[ ] Method preconditions are checked and documented in the Javadoc of the method
[ ] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes

Pull Request Test Coverage Report for Build 1447

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.22%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

exonum-java-binding-qa-service/src/main/java/com/exonum/binding/qaservice/transactions/ValidErrorTx.java
0
1
0.0%

Totals

Change from base Build 1446:
0.0%

Covered Lines:
2701

Relevant Lines:
3367

💛  - Coveralls


Standardizing capitalization and subreddit prefixes in the README

Fixes
Regularize the capitalization of:

Python (should be capitalized)
Gitter (should be capitalized)

And standardizes the prefix of Reddit subreddits to r/ from /r/ and adds it to the codeblock reference for r/redditdev. Reddit no longer uses the initial slash in the vast majority of their apps and website, starting from first enabling the omission several years ago. r/ is the only standard used on both New Reddit and the mobile apps and sites. /r/ persists mainly as a legacy styling in areas which have not been updated in a while (for example. moderator invites are still displayed as coming from /r/SUBREDDIT).
This pull request may be construed as splitting hairs, so I totally understand if the changes are deemed too insignificant.

I also updated the Markdown reference link in References to the official guide.

Thanks for the contribution! Feel free to add yourself to the authors file if you're not already there and make a new PR for it.

Thanks @bboe! I'm already in there due to a previous pull request. :)


Setting up to use default Github env. variables

Instead of having to hard code the destination_repo, it might be ideal if this can take default GitHub env. variables.
Please see below.
This could come in handy, especially if this yml is to be used as a template for multiple repos.
...
    - name: Pushes output to destination repository
      uses: dmnemec/copy_file_to_another_repo_action@main
      env:
        API_TOKEN_GITHUB: ${{ secrets.GITHUB_TOKEN }}
      with:
        source_file: 'fromFolder/'
        destination_repo: '${GITHUB_REPOSITORY}'
        destination_folder: 'toFolder'
...

That change for destination would copy a file from inside the repo to another location in the same repo, via a commit. I'm not sure I'm following what you're asking here.

Thank you for the reply and yes, that's exactly what it is.
We are thinking running a GitHub Action that does some linting and then extracting some code snippets that gets created in the fromFolder and then move them into toFolder .
If destination_repo accepts either itself or a separate repo as an argument that can be passed in, then it'll do the trick.

I also noticed that I can't get env variable that already defined to work.
source_file: '$PATH/file.txt'
cp: can't stat '$PATH/ile.txt': No such file or directory
I tried several ways with no luck.
Hope there is a update add envs support if isn't there already
thanks.


Godoc link in readme broken

Hopefully a quick and easy fix: the godoc link in the readme.md is broken:
https://godoc.org/github.com/windmilleng/tilt
Note that there's a new location which we could use: https://pkg.go.dev/github.com/windmilleng/tilt

Hmm, you mean the "godoc:reference" link at the top of README.md? That seems to work fine, it takes me here: https://pkg.go.dev/github.com/windmilleng/tilt?tab=doc or am I misunderstanding?

OH wait I understand now, I turned on automatic redirects from godoc.org -> pkg.go.dev. Will go fix :)


Could you please provide an example? I am interested in Surface GO uefi settings from intune.

[Ide írja be a visszajelzését]

A dokumentum adatai
⚠ Ezt a szakaszt ne szerkessze. A szakasz a docs.microsoft.com ➟ GitHub-problémák hivatkozásaihoz szükséges.

ID: fd336518-8c61-8497-3881-890e8653da5e
Version Independent ID: e6aee767-8226-64fe-5756-1a698df24154
Content: UEFI CSP
Content Source: windows/client-management/mdm/uefi-csp.md
Product: w10
Technology: windows
GitHub Login: @ManikaDhiman
Microsoft Alias: dansimp

Especially to turn on the "battery limit".

Added PR #5564

Ref. #5530

PR #5578 has been merged into the public branch here on Github.
It may take a few days before the content is available on docs.microsoft.com .

@loriand71 - From our understanding, the issue has been resolved based on this merged commit https://github.com/MicrosoftDocs/windows-itpro-docs/commit/eb5d6fa7437fa05d5a35d611480a7d300933e691. If you feel it hasn't been resolved, please re-open this issue.
Thank you for your contribution to make the docs better! Much appreciated!


fix(github): Update ownership

What does this PR do?
Remove ownership of corechecks/embed/* from agent-devx-infra team, and assign to agent-delivery

Motivation
I was surprised to be involved in this PR

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge

/merge


Content for Frontend Setup in Base Camp

What changed? Why?
New content
Notes to reviewers
How has it been tested?

Review Error for amhayslipcb @ 2023-11-28 18:08:49 UTC
User failed mfa authentication, see go/mfa-help

Review Error for CryptoUGuy @ 2023-12-11 21:52:17 UTC
User must have write permissions to review


CH 07 - Modeling, Inference, and Meaning

Could you please expand on how "a modeling construct's meaning is given by the pattern of inferences that can be drawn from it" (pg. 199)?
This feels like an important statement, but I'm having a tough time wrapping my head around the implications. Is there a more tangible example available?

In OO modeling, what does it mean to say that something is a subclass of something else?
It means that instances of the subclass will respond to methods defined at the superclass ("method inheritance").
It means that attributes defined in the superclass will be available for describing instances of the subclass.
What does it mean in RDFS?  It means that certain inferences can be drawn (as described in the book).
This means that you can prove theorems about your models.   If A subclassof B and B subclassof C, does that mean that A subclassof C?  That's a theorem; it isn't a policy question, you answer it by proving a theorem based on the inference structure.


Increase test coverage for --sniffs and --exclude options

Description
While working on https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/344, it was noted that there are no existing tests for the code being changed. This pull request aims to add some tests to cover the existing behaviour.
Suggested changelog entry

Improve test coverage of internal functionality

Related issues/external references
Related to #344
Types of changes

Chore - no functional changes, only code coverage

PR checklist

[x] I have checked there is no other PR open for the same change.
[x] I have read the Contribution Guidelines.
[x] I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
[x] I have added tests to cover my changes.
[x] I have verified that the code complies with the projects coding standards.

@jrfnl, I think this is ready for another review now. When we're happier with the final delta, I can rewrite the history so there are fewer commits before this is merged in.

:tada: Yes. A squash-merge via GitHub is fine with me.
Thanks for your coaching here too @jrfnl.


Add type checking, refactor generators

Checklist:

[ ] Added tests for changed code where applicable.
[ ] Documentation reflects the changes where applicable.
[ ] Updated the CHANGELOG.md file with your changes.
[ ] My PR is ready to review.

Resolves: #120
Description of the changes being introduced by the pull request:

Codecov Report

Merging #245 (21054b5) into master (4feab18) will decrease coverage by 0.24%.
The diff coverage is 99.55%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##            master     #245      +/-   ##
===========================================
- Coverage   100.00%   99.76%   -0.24%
===========================================
  Files           15       18       +3
  Lines          418      433      +15
===========================================
+ Hits           418      432      +14
- Misses           0        1       +1

Impacted Files
Coverage Δ

fastapi_mvc/__init__.py
100.00% <ø> (ø)

fastapi_mvc/generators/loader.py
97.05% <90.00%> (-2.95%)
:arrow_down:

fastapi_mvc/cli/__init__.py
100.00% <100.00%> (ø)

fastapi_mvc/cli/base.py
100.00% <100.00%> (ø)

fastapi_mvc/cli/cli.py
100.00% <100.00%> (ø)

fastapi_mvc/cli/generate.py
100.00% <100.00%> (ø)

fastapi_mvc/cli/new.py
100.00% <100.00%> (ø)

fastapi_mvc/cli/run.py
100.00% <100.00%> (ø)

fastapi_mvc/cli/update.py
100.00% <100.00%> (ø)

fastapi_mvc/constants.py
100.00% <100.00%> (ø)

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Pipe variables to feedback view controller

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion

Read the contribution guidelines (CONTRIBUTING.md).
If this has been discussed in an issue, make sure to link to the issue here.
If not, go file an issue about this before creating a pull request to discuss.

Testing

Make sure all existing tests in the repository pass after your change.
If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

At this time we cannot accept changes that affect the public API.  If you'd like to help
us make Firebase APIs better, please propose your change in a feature request so that we
can discuss it together.

This still needs to be tested locally to confirm that the network calls work.


New Empty Window != New Empty Window

I'm using Ubuntu 18.04. this may be a GDE issue?
I have vscode pinned to the sidebar. When I right click on it there's a context menu with "New Window", "New Empty Window" etc.
They don't really seem to be labelled well, or even behave consistently.
It seems that both options do the same thing if vscode isn't running (restore the previous workspace), and both also do the same thing when vscode is running (create a new instance of vscode)?
it's a bit annoying if I want to create a new project. I have to do "New Window" which opens my previous workspace, then "New Window" again to get a new window, then close the first window.

New Empty Window passes in the --new-window CLI argument as documented in code --help:
-n --new-window                   Force to open a new window.

If this does not work as expected please create a new issue.


Error with -Inf rewards

As @juliohm found, If rewards of -Inf are used, solver.jl line 137 will end up with NaN and there will eventually be hard-to-diagnose errors.
Behavior for this needs to be defined and tested.

We have a couple options:

Replace line 137 with something like

if best_node.V != -Inf
    best_node.V += (R-best_node.V)/best_node.N
end

After 137, add @assert !isnan(best_node.V)

Yeah, I think we should support -Inf so the first one seems best. Positive inf will throw a warning because that makes little sense. If they return a NaN reward, they will have to catch that themselves.


Add "droplet kernels" command: List all available kernels for a Droplet.

Would you be interested in this?

Yes. Thanks.


NumberInput validation

Project organization

Related to https://github.com/liteflow-labs/marketplace-template/issues/72
Related https://trello.com/c/eErTVlGD

MARKETPLACE TEMPLATE PR:
https://github.com/liteflow-labs/marketplace-template/pull/89/
Description
Adding validation for number inputs throughout the library
How to test
This is currently partially testable in storybook, some are gated behind the login flow and can be tested on this PR https://github.com/liteflow-labs/marketplace-template/pull/89/ :
Components should be testable They are:

[ ] Offer -> Form -> Bid -> Default
[ ] Offer -> Checkout -> Multiple
[ ] Sales -> Auction -> Form -> Default
[ ] Sales -> Direct -> Form -> Is Single / Is Multiple
[ ] Token -> Form -> Create -> Is Single / Is Multiple

Templates (doesn't build right now therefore cannot be tested). Validate functions should be okay but I added the display of the errors in the UI and since I can't preview it, it's not tested right now. This could be tested in marketplace-template repo with PR https://github.com/liteflow-labs/marketplace-template/pull/89/ :

[ ] Explore page -> Filters -> Min/Max price

To test for price inputs:

[ ] Value need to be positive
[ ] Value can't exceed maximum decimal of currency
[ ] Value cannot be empty unless optional

To test for quantity inputs:

[ ] Value need to be positive
[ ] Value need to be a minimum of 1
[ ] Value can't exceed the maximum available quantity
[ ] Value need to be integers

To test for royalty input:

[ ] Value can be optional or 0
[ ] Value need to be positive
[ ] Value cannot exceed the maximum allowed royalty
[ ] Is there a maximum decimal ? not for now.

Checklist

[x] Update related changelogs

 GIG - Royalty+price input - Negative value

@achampagnedev Missing the quantity input in Offer/Form/Bid

The summary of Sales/Direct/Form needs a similar fix for BigNumber crash as Offer/Form/Summary

@NicolasMahe This is ready to test. I think I covered most cases. I can see a potential issue with currency.decimals whenever present. It seems that either the number of decimals is not updated when switching currency but it's always 18. Will take a look in the morning. Marketplace Template PR is also available and can be compared with this one for anything that can't be tested well within the storybook scope.

@NicolasMahe Updated with requested updates.

Normalized translation variables
Added back min/max to prevent stepper from going below or above value of validation (except in the case of prices where min is 0 but will still require the user to enter a value above 0)
Removed duplication with the quantity BigNumber and using a single memo
Removed the format as it seems like the input already returns a StringOrNumber but the result seems to always be a string. the onChange returns a string so the setValue is still set as a string
The validation on explore page needing to be converted toString() seems to affect the filters if not passed as a number in the files above filter logic. I tried to change the logic around to string but had issues with the filters not working. I suppose we can create an other issue for it if we want to fix this as well but I think filters might change soon with collections.

Let me know if I missed anything or didn't solve the right way

Let's make this modif on https://github.com/liteflow-labs/starter-kit/pull/89 first so we can test them easily and then bring them back to the lib.
I feel a lot of issues are still present because on the lack of testing because the current lib organisation.

@achampagnedev Now that PR https://github.com/liteflow-labs/starter-kit/pull/89 is merged, you can bring the same modif to this PR


Document expected BIO operations for libssl

If your custom BIO does not implement BIO_CTRL_FLUSH, it won't work, but this is not document anywhere.

Checklist

[x] documentation is added or updated

This pull request is ready to merge

Merged to all the active branches. Thank you for your contribution.


Deployment of a local registry

Implementation of a local registry as specified in #165.

Skopeo is installed on node setup, allowing images to be transferred between registries without docker
A local registry is deployed upon setup of the master node
A script has been added to populate the local registry using images from a remote registry
Test have been updated to include an image from the local registry

Notes

Skopeo installation without compiling from source only works for ubuntu 18.04+ or Debian 10
The local registry does not support SSL
When no registry is specified in the imagename, the orchestrator defaults to docker.io, which is the default Kubernetes behavior
Storage size for the local registry volume has been set to 5 GiB for now. This might need to be adjusted depending on the requirements

Thanks for the review, I'll also try to run the tests locally to see if anything is wrong on my end. Regarding the spellcheck, it is complaining about a command line argument used in a markdown file. Should I add that parameter to the exceptions?

yes wrt the spellcheck, don't worry about the test failures as of now.


Updated relay-term node packages to work with node version 12.20.1

Refer to this link for build results (access rights to CI server needed):
https://edge-jenkins.isgtesting.com/job/test_team-build-edge_node_modules/31/

Refer to this link for build results (access rights to CI server needed):
https://edge-jenkins.isgtesting.com/job/test_team-build-edge_node_modules/31/


23.1.7+ routing problem

Hi Opnsense Teams!,
Iv'e got an issue here that I cant seem to get resolved. On 23.1.6 what you see in this screen capture works just fine but any higher that 23.1.7+ it does not. Got 5 Single gateways configured as "FAR GATEWAYS" that are rechable VIA <IP_ADDRESS>/24 via STATIC ROUTES <IP_ADDRESS> witch corresponds to my Cisco Wan interface.

To make it somehow kind of working in 23.1.7+, I need to make my Opnsense Lan Interface the gateway of <IP_ADDRESS>/24 witch make no sence to me since it should be <IP_ADDRESS> to make matther worse the single gateway witch correspond to my Opnsense Lan Interface need's to have it's IP correspond to "dynamic" for my setup to work.
What's working in 23.1.6+

And for some reason in 23.1.7 inside of the overview Tab, my lan interface dosent seem to care at all about the auto-detection of it's own defaut-gateway, with always seem to want to go to <IP_ADDRESS>/28 with correspond to VLAN 40 running on my Cisco Router.
Lan interface in 23.1.6:

Here is an example of my Routing table between 23.1.6 VS 23.1.7+
23.1.6:

23.1.7+

In 23.1.6 you can clearly see that my "FAR NETWORK" are correctly showing. But in 23.1.7 without me changing anything nothing is getting picked up correctly. But as previously stated if I set the default Gateway of <IP_ADDRESS>/24 to my Opnsense Lan interface thing start to kind of working again.
Please help 👍
Nick
Software version used and hardware type if relevant, e.g.:
OPNsense 23.6.1 (amd64, OpenSSL).
Intel® Xeon™  E5-1620 v2 @ 3.70GHz (4 cores, 8 threads)

I think that would be https://github.com/opnsense/core/commit/25e2c0a301
opnsense-patch 25e2c0a301
Cheers,
Franco

PS: To be released in 23.1.9 this week.

Hi to all!,
Just updated again to 23.1.8 with the proposed patch and it's all working as before. @ChristopherZender Thank's for your input!
@fichtner Thank you,
Nick


Install Error: ... has no certificates at entry assets/databases ...

Hello,
i've made an unsigned apk out of my IDE (Eclipse) and now i can't install the app.
LogCat says the following :
02-01 17:21:42.445 E/PackageParser(2183): Package eu.padalton.altstoffsammelstellen_noe has no certificates at entry assets/databases/altstoffsammelstellen_noe.zip; ignoring!
Pleas help me ... your libary is great and i realy like to use it.

jarsigner -verbose -keystore xxxstore -signedjar xxx_signed.apk -digestalg SHA1 -sigalg MD5withRSA xxx.apk xxx


Loss cannot converge

As shown above，the fine-tune loss become larger, the config and training details are all follow yours. could you please tell me some possible reasons？

2 epoch, the losses have not decreased yet.

Hi @CYL0089
have you tried reducing the batch_size number?
For me it converges on batch_size 2 but not on 3. I am using 2X3090s.
Cheers


[Feature request] Cursor lock

Resident Evil 4's cursor has a horrible tendency to go onto my second monitor whenever I Alt+Tab. It also prevents the game's cursor from showing. If I wanted modify settings in the re4_tweaks GUI, I wouldn't be able to because the cursor isn't there.
The only way to "fix" this issue currently is to just restart the game. But even when doing that, it happens again.

Would also be nice if we can toggle the cursor hiding code too (without breaking the games mouse code), when debugging game in windowed mode alt-tabbing doesn't always make the cursor show up again - usually have to force it by using CTRL+ALT+DEL twice (useful Windows hotkey for forcing cursor to reappear)
Maybe wouldn't be too useful for players, but a toggle for devs (or IsDebuggerAttached() check) would probably make things a lot easier for code modders.

I haven't got time to test it, but here's the link to the build with that commit for easier access if anyone wants to test it:
https://github.com/nipkownix/re4_tweaks/suites/7127864152/artifacts/282913147

I haven't got time to test it, but here's the link to the build with that commit for easier access if anyone wants to test it:
https://github.com/nipkownix/re4_tweaks/suites/7127864152/artifacts/282913147

Can confirm this fixes the issue for me as well. I can Alt + Tab out of the game as many times as I want and my mouse cursor appears and is usable both when using a different program and when navigating the game. No more need to right-click to get it to appear again.

Nice!
@emoose, this should fix the stuff you mentioned as well.


input value validator - not equal to some number is required

Description of the feature
input value validator - not equal to some number is required.
need more validators like class validators in typescript.
Code example (if possible)
#[graphql(validator(not_equal = 0))]

you can implement you own validator 🙂
https://github.com/async-graphql/async-graphql/blob/a42da838124a477bc4744fcb92196cea48f68754/tests/validators.rs#L306


Divergence of the number of shards in the metastore vs as seen from the control plane

As observed on airmail
select count (*) AS shards from shards;
 shards
--------
 763471
(1 row)

While the control plane sees a much lower shard count (~3000s)

This is probably not the cause, but this causes a divergence between metastore and CP
        if let Err(control_plane_error) = self
            .auto_create_indexes(&request.subrequests, ctx.progress())
            .await
        {
            return Ok(Err(control_plane_error));
        }

I suspect the problem is that we
- open shard on metastore
- init shard on ingest
- only update the model for successfully initialized shards

So if an ingester happens to be unreachable etc., we end up with some dangling shard in the metastore.

scale_up shards seems buggy too.
   let open_shards_response = match progress
            .protect_future(self.metastore.open_shards(open_shards_request))
            .await
        {
            Ok(open_shards_response) => open_shards_response,
            Err(error) => {
                warn!("failed to scale up number of shards: {error}");
                model.release_scaling_permits(&source_uid, ScalingMode::Up, NUM_PERMITS);
                return;
            }
        };

Split into #5013 #5014 #5020


Scala Stream Collector: crash rather than hanging when unable to bind to the supplied port

Log output:
@4000000056ee2bc20cd97b6c Starting snowplow-stream-collector
@4000000056ee2c6b0bc02014 04:51:45.069 [scala-stream-collector-akka.actor.default-dispatcher-4] INFO  akka.event.slf4j.Slf4jLogger - Slf4jLogger started
@4000000056ee2c6b0c71d05c 04:51:45.208 [scala-stream-collector-akka.actor.default-dispatcher-4] DEBUG akka.event.EventStream - logger log1-Slf4jLogger started
@4000000056ee2c6b0c777d7c 04:51:45.209 [scala-stream-collector-akka.actor.default-dispatcher-4] DEBUG akka.event.EventStream - Default Loggers started
@4000000056ee2c79100497f4 04:51:59.268 [main] INFO  c.s.s.c.s.sinks.KinesisSink - Creating thread pool of size 10
@4000000056ee2ccd2efeff8c 04:53:23.787 [main] INFO  c.s.s.c.s.sinks.KinesisSink - Stream xxx exists and is active
@4000000056ee2ccd2f310824 04:53:23.788 [main] INFO  c.s.s.c.s.sinks.KinesisSink - Creating thread pool of size 10
@4000000056ee2ccd3b46b49c 04:53:23.994 [main] INFO  c.s.s.c.s.sinks.KinesisSink - Stream xxx exists and is active
@4000000056ee2cde2d9bc9f4 04:53:40.765 [scala-stream-collector-akka.actor.default-dispatcher-5] DEBUG spray.can.server.HttpListener - Binding to /<IP_ADDRESS>:8080
@4000000056ee2cdf2fe204bc 04:53:41.803 [scala-stream-collector-akka.actor.default-dispatcher-9] WARN  spray.can.server.HttpListener - Bind to /<IP_ADDRESS>:8080 failed, timeout 1 second expired
@4000000056ee2cdf30526e14 04:53:41.810 [scala-stream-collector-akka.actor.default-dispatcher-9] INFO  akka.actor.DeadLetterActorRef - Message [akka.io.Tcp$CommandFailed] from Actor[akka://scala-stream-collector/user/IO-HTTP/listener-0#1528805508] to Actor[akka:$
@4000000056ee2ce0206ed564 04:53:42.544 [scala-stream-collector-akka.actor.default-dispatcher-8] DEBUG akka.io.TcpListener - Successfully bound to /0:0:0:0:0:0:0:0:8080
@4000000056ee2ce020748a54 04:53:42.544 [scala-stream-collector-akka.actor.default-dispatcher-8] INFO  akka.actor.LocalActorRef - Message [akka.io.Tcp$Bound] from Actor[akka://scala-stream-collector/system/IO-TCP/selectors/$a/0#-1857599492] to Actor[akka://scala$
@4000000056ee2ce022d244bc 04:53:42.583 [scala-stream-collector-akka.actor.default-dispatcher-5] DEBUG akka.io.SelectionHandler - Monitored actor [Actor[akka://scala-stream-collector/user/IO-HTTP/listener-0#1528805508]] terminated
@4000000056ee2ce022d8d084 04:53:42.584 [scala-stream-collector-akka.actor.default-dispatcher-13] DEBUG akka.io.TcpListener - Closing serverSocketChannel after being stopped

Instead it should crash out. Let's also add a longer timeout to bind to the socket.

This can be reproduced by running two SSC processes attempting to use the same port.

Re adding a longer timeout: it looks like this is done using the bind-timeout setting documented here, which apparently defaults to 1s. What do we think the timeout should be?
Also, if the target port is already in use the bind fails immediately regardless of the timeout. I think this is fine - if the port is already in use there is no reason to think it will become free in the near future.

Can we update this ticket name to match the commit please!

Done!


fix formatting of inference

Another blocker for https://github.com/dlang/dmd/pull/5881
This fix makes it work with or without 5881.

Auto-merge toggled on

mind the autotester


Progressive stub removal, angle merge after simplification

Implements 2 ideas:
Progressive stub removal
When we set the min length and remove stubs, we usually remove all of them in one go. But it might make sense to remove them progressively because we keep more. Consider for example this:

If we set min length = 4, then with the old version we loose all but the line 0 to 5. What this pr does is that it removes first all the stubs with length 1, then all the stubs with length 2, ..., 4 and in between we merge the graph. Like that the result is a continuous line from 0 to 8.
Angle merge
After simplification, we merge lines at nodes with more than 2 edges prioritizing merging by angle between edges. Edges that for large angles get merged first. This creates nice long linestrings for transportation_name and other layers that wand to do label placement...

I read by the way that what we are doing here with angle merging is sometimes called "strokes based on the principle of good continuation".


Customizing ring color and other colors

What's the recommended way of changing the color of the ring and the key highlight colors?

Edit scripts/i3lock-next, specifically lines 60-74.

Thank you!


vdk-pipelines-controls-service: upgrade to 3.9 in the vdk init container

Why?
The newest version of quickstart-vdk docker image was changed to use python 3.9 instead of 3.7. https://hub.docker.com/r/versatiledatakit/quickstart-vdk/tags
This caused a test to fail because it was looking for python 3.7.
This change points it to 3.9 instead.
What?
Change to version 3.9
How has this been tested?
integration tests
What type of change are you making?
Bug fix
Signed-off-by: murphp15<EMAIL_ADDRESS>

This would be a breaking change as jobs relying on 3.7 would stop working. And we should avoid/minimize breaking changes.
We need to make it
A) either configurable with default being 3.7
B) Make it so that it will work with any python version (e.g do not hard code the python path with a version)


Wrong TweetLength() with CJK characters

First, sorry for my bad English.
I'm working in a simple tweet composer program which uses Tweetinvi as the Twitter API library.
Now I have to get the tweet length before compose it, following calculation mechanism of Twitter's tweet length. So I decided to use someString.TweetParts().Content.TweetLength() but I've faced with a problem.
The problem is, you may know, the new tweet length model(Extended Tweet) uses byte length(Alphabets and other Latin characters, e.t.c. are 1 byte per character(0.5 count). CJK characters including Kanji are fixed to 2 bytes(1 count) per character I think), instead of character length.

This shows the difference of length calculation with Korean characters which are counted 1 per character. Top is my program, center text box is from Tweetdeck. The progress bar of my program has Maximum property which was set to 280, and (textbox.Text).TweetParts().Content.TweetLength() used as progress bar's value.
As you see, Tweetdeck tells me that the texts are reached its length limit, but my program doesn't.
Not only Korean characters, but also Japanese and Chinese characters.

Same program, same Tweetdeck with English characters(alphabet) which are counted 0.5 per character. Both my program and Tweetdeck tell me that the texts are reached its length limit.
Sorry for my bad explanation... but check about it out please!!

Hello,
Please note that Tweetinvi in version 3.0 (which is in testing at the moment) will not support TweetLength.
The reason behind this is that Twitter changed their calculation algorithm and until I have time to properly redevelop this feature to match all the new conditions from Twitter you will have to use their library twitter-text.
It is very simple to use and I will suggest that you use the node.js version inside a micro service.
I know this is not ideal and this decision has been made so that you do not send incorrect information to your clients.
You can find Twitter official length library here : https://github.com/twitter/twitter-text
Thanks,
Linvi

I will put back the function as part of the StringExtensions but change the name.
DEV NOTE :  Change 3.0 internal TweetLength to public static EstimateTweetLength and provide additional information as to why this is an estimate.

OK then maybe I have to find the way to use twitter-text with Node.js within my program... I really appreciate you explaining!

Reopening until obsolete restored in 3.0

Renamed to EstimateTweetLength


Place holder NPM packages - 404 -<EMAIL_ADDRESS>

I haven't looked through the full dependency graph for this but am running into:

playground-typescript-worker.js:37 Error fetching<EMAIL_ADDRESS>from CDN: CDN HTTP 404 error
playground-typescript-worker.js:37 Error fetching<EMAIL_ADDRESS>from CDN: CDN HTTP 404 error

with
import * as deckgl from 'deck.gl';

demo
Happens in 0.14.8 and 0.15.1.
This is probably fixable upstream? Not sure where though.

fs and child_process are both Node built-in modules, so it seems like some module in that import graph is assuming it's in a Node context, instead of a Web context, and trying to import those built-ins.
One of the culprits is this file: https://unpkg.com/browse/<EMAIL_ADDRESS>It seems like deck.gl is supposed to work in the web, so I'm surprised that this module is in its import graph.

Seems some bundlers such as webpack provide handling for these cases. https://webpack.js.org/configuration/node/#node
{
  node: {
    fs: 'empty'
  }
}

Seems some bundlers such as webpack provide handling for these cases. https://webpack.js.org/configuration/node/#node, with automatic polyfills or just returning an empty module.

Hmm, will have to think about whether we want to support this. I feel a little reluctant to add complexity to the bundling system to work around libraries that are not intrinsically web compatible. IMO libraries that want to support the web should simply not publish modules that depend on Node imports; they should have a different entry point, or a different package, for the Node context. If the feature that depends on a Node API isn't required and can simply be blanked out, then it doesn't seem like it should be in the main import graph.

Seems like a workaround would be to use the importMap to point at a local, empty module or polyfill if available.

That could work! Let me know if you get it to work.

I was able to get this to work with importMap.imports. In the future, might want to consider support for the browser field of the package.json in the form of:
browser: {
  fs: false,
  '../some/path': false<
}

(This is the other usage not the compiled js entry for browsers that is in the NPM docs).

This seems to be a never ending chase down a rabbit hole that probably won't end until I recreate the behavior in parcel/webpack/etc.


Development

The update contains four commits:
MEC1501 headers to ext/hal/microchip/mec
MEC1501 DTSI file to dts/arm/microchip
MEC1501 SoC folder/files to soc/arm/microchip/mec
MEC1501 board folder/files to boards/arm/mec15xxevb_assy6853
Hello world example can be built and prints out expected message on UART 0 of MEC1501 EVB.

Codecov Report

Merging #15055 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #15055   +/-   ##
=======================================
  Coverage   52.93%   52.93%
=======================================
  Files         309      309
  Lines       45268    45268
  Branches    10451    10451
=======================================
  Hits        23961    23961
  Misses      16542    16542
  Partials     4765     4765

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6249ac...748a2f2. Read the comment docs.

@scottwcpg thanks for the PR and welcome. Since this seems to be a work in progress, I have taken the liberty to tag it as DNM (Do Not Merge).

My apologies for this being pushed to zephyr instead of my fork at github.com/MicrochipTech/zephyr.  git remote -v shows I'm pointing to my fork but the push went here. I cloned MicrochipTech/zephyr and then ran west init -l zephyr/ and west update.  Could the west tool have changed something to cause my push to go here instead of my fork?

@mbolivar , @carlescufi , @tejlmand : Please see comment above

@scottwcpg If you did not intend for this PR to be sent upstream, I will then close it.

Could the west tool have changed something to cause my push to go here instead of my fork?

West doesn't create pull requests, so I'm not sure how that could have happened, sorry.


Remove ProcessorJob enter and exit methods

What is the purpose of the change
Remove ProcessorJob enter and exit methods which should not be added.
Brief change log

Remove ProcessorJob enter and exit methods

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API: yes

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not documented

@lindong28 Could you review this PR?


UI searchpage - facet locatie

The work for this feature is in this branch. However, I have some questions regarding the indexing of the spatial information in TriplyDB's Elasticsearch and need some input there.


Fix missing CMake content for new DB plugin

I wasn't paying attention and @cessenat had neglected to update src/databases/CMakeLists.txt as well as add a CMakeLists.txt for the curve 3d plugin.
This update fixes that...tested manually on macOS

I wasn't paying attention and @cessenat had neglected to update src/databases/CMakeLists.txt as well as add a CMakeLists.txt for the curve 3d plugin.
This update fixes that...tested manually on macOS

Apologies and thanks to you @markcmiller86


[Polkadot] Remove transport and hw-app dependency

📝 Description
The goal of this PR is to remove from the coin-framework and coin-polkadot, their dependencies to hw-transport and hw-app packages.
It is replaced by the injection of the notion of Signer, which conforms to the interface of hw-app.
This notion is yet to define more precisely and to be generalized.
⚠ The main issues that need to be fixed are:
✓ Remove Transport dependencies from coin-framework/bot/types.ts
--> it seems that Transport is not used, only declare...
✓ Remaining errors inside LLC, related to the lack of disponibility of transport (BTC and ADA).
--> Update the way ::getShapeAccount and ::sync methods so they can be built with Signer, by composing them.
✓ Call to withDevice inside generated repository, without any real deviceId.
--> Relies on UI call to Bridge function, that requires the deviceId. Then use it to create dynamically ""Signer"", from this deviceId.
** Update **
⚠ The ""Signer"" notion here is only to abstract hw-app-*. The rework in this PR is only abstracting getAddress and limited sign method call.
This PR shows that the coin-modules have limited surface dependency, but deep one. Next thing to do, might be to rework those syncAccounts and sync functions.
❓ Context

Impacted projects: coin-framework, coin-polkadot, live-common
Linked resource(s): LIVE-7315 (This is a sub task of EPIC: LIVE-6235)

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

👋  ESLint config has been unified on develop after we merged https://github.com/LedgerHQ/ledger-live/pull/3622 – this will improve the project consistency, remove eslint dependencies duplicates, and overall simplify the maintenance. This comes with a prettier library upgrade and unification of the prettierrc too, so you likely have conflicts with develop.
Hopefully, here is the procedure to easily fix this. please proceed as follow:
Step 1: sync your branch with develop up to the config changes:
2 cases

if your branch were continuously rebased with develop and don't have any merge commit, you can do

git rebase aa1e0ebc0a0498b4350754899b6a368fbd42e811

otherwise prefer

git merge aa1e0ebc0a0498b4350754899b6a368fbd42e811

then, apply the config
pnpm i
pnpm lint:fix --force

if there are remaining errors that lint couldn't fix, please fix them and pnpm lint again.
then commit in your branch.
git commit -a -m "chore: lint fixes"

Step 2: finalize the rebase/merge with develop
2 cases

if your branch were continuously rebased with develop and don't have any merge commit, you can do

git pull --rebase origin develop

otherwise prefer

git merge origin/develop

you should now be up to date. 👍

Thanks and sorry for the inconvenience,
gre


Polyfill for URL() constructor?

Hello,
Is this part of window.fetch somehow? I notice it's in one of the spec examples, but it's not available in all browsers: https://developer.mozilla.org/en-US/docs/Web/API/URL/URL
Should the polyfill get added here?
Thanks.

The URL polyfill can be added to projects as needed. The fetch polyfill does not use URL so we don't need to reference it here.


2.1 Strings - Rabin-Karp Algorithm - Video

Description
Discuss the Rabin-Karp Algorithm. Mention about its implementation, complexity, examples.
Important: Do not use assign command for this issue.
Task

[ ] Video

Note

While requesting the issue to be assigned, please mention your NAME & BATCH NUMBER.
Kindly refer to Issue Guidelines.
Changes should be made inside the DSA/directory & DSA branch.
Name of the file should be same as the issue.
This issue is only for 'GWOC' contributors of 'DSA' Domain.

@nimisha-yadav  Can I work on this issue?
Likita Rai - DSA batch 2

@nimisha-yadav Can I work on this issue? Likita Rai - DSA batch 2

Assigning this issue to you @likitarai1, all the best!

Will you add Hacktoberfest label to this?

@nimisha-yadav please review my PR #5225


Wildcards in index search

Wildcards are currently not supported but are necessary sometimes.

Regex index search implemented.


Storage update event

Send an update message an let the application create a trigger (so when another tab changes it the other can detect this)
window.addEventListener('storage', function(e) {
  window.parent.postMessage('cross-storage:updated', '*');
});

Interesting idea. Rather than just updated, I wonder if it'd be worth emitting events for any cross-storage client request, if desired.

Issue's pretty old - closing for now. If there's any interest, a PR is welcome!

@danielbreves I'm using CrossStorage to implement a Single-Sign-On, where the user can login in one app domain and won't have to login in another app domain.
I would like to cache a value from CrossStorage into localStorage and then remove it when it is removed from CrossStorage (this would help a lot in terms of performance).
Having a hook on CrossStorage events would be awesome.
I'm willing to PR if you can outline the needed steps to achieve this.
Expected API:
const crossStorage = new CrossStorageClient(...);

crossStorage.on('set', (key, value) => { ... });
crossStorage.on('del', (key) => { ... });

@alexilyaev did you mean to mention @danielstjules?

@danielbreves Yep, sorry, updated :-)