MAINT: Silence warnings during linprog benchmarks

Closes gh-21769. Which in turn deals with the issue of having a lot of logspam along the lines of:
 UserWarning: Reading `.npy` or `.npz` file required additional header parsing as it was created on Python 2. Save the file again to speed up loading and avoid this warning.

Basically using a tiny script like so:
import argparse
import subprocess
import numpy as np
import warnings

def convert_npz_file(file_path, output_file):
    data = np.load(file_path, allow_pickle=True)
    data[data.files[0]]
    np.savez_compressed(output_file, **data)

def run_with_error_checking(command):
    try:
        subprocess.run(command, check=True, capture_output=True)
    except subprocess.CalledProcessError as e:
        print(f"Error running command: {e}")
        convert_npz_file(file_path, output_file)
        return False
    return True

if __name__ == "__main__":
    parser = argparse.ArgumentParser(
        description="Convert NPZ files to Python 3 compatible format."
    )
    parser.add_argument("input_file", help="Path to the input NPZ file")
    parser.add_argument("output_file", help="Path to the output NPZ file")
    args = parser.parse_args()

    file_path = args.input_file
    output_file = args.output_file

    # Run the command with -W error
    command = [
        "python",
        "-W",
        "error",
        "-c",
        f"import numpy as np; data=np.load('{file_path}', allow_pickle=True); data[data.files[0]]",
    ]
    if run_with_error_checking(command):
        convert_npz_file(file_path, output_file)

Which is then just used in a loop:
cd benchmarks/benchmarks/linprog_benchmark_files/
for file in "$(pwd)"/*.npz; do
python fixOldWarnings.py $file $file
done

Pending https://github.com/numpy/numpy/issues/20995 there doesn't seem to be much to be done regarding the increase in size..
Also not sure if this is a good tradeoff (size for reduction in log-spam).

The file size increase is ~13 kb only and in benchmark files that are not included in wheels - so not a concern I'd say.


FAB label programatically - not workin

Hi there,
I'm trying to show the label of the button's programatically, only when user opens the app for the first time. So, I can do this two ways:

Put the labels on XML and hide then programatically if it's not the first time
Don't put the label on XML and show it if it's the first time

The 2) way makes more sense.
Neither can get me there.
Solution 1), when I set the label to null or "", the label appears empty (it should not even appear)
Solution 2), when I set the label programmatically, it doens't show (show empty, like on 1))
Am I missing something?
A little code:

 if (fab != null && !app().getFirstLaunch()) {
     FloatingActionButton button = null;

     for (int i = 0; i < fab.getChildCount(); i++) {
         if (fab.getChildAt(i) instanceof FloatingActionButton) {
             button = (FloatingActionButton) fab.getChildAt(i);
             button.setLabelText(null);
         }
     }
 }

    if (fab != null && app().getFirstLaunch()) {
        ((FloatingActionButton) fab.getChildAt(0)).setLabelText(getString(R.string.fab_photo));
        ((FloatingActionButton) fab.getChildAt(1)).setLabelText(getString(R.string.fab_search));
        ((FloatingActionButton) fab.getChildAt(2)).setLabelText(getString(R.string.fab_notifications));
        ((FloatingActionButton) fab.getChildAt(3)).setLabelText(getString(R.string.fab_profiles));
        ((FloatingActionButton) fab.getChildAt(4)).setLabelText(getString(R.string.fab_feed));
    }

Not even via button.setLabelVisibility(View.GONE)!

Fixed. Now the setLabelVisibility(View.GONE) method should work as expected. Will upload new build on weekends.


Update workflow.md

Minor cosmetic changes to intro paragraph. Replaced "buffer" with "file" to help newbies (like me), but left it "buffer" in the "Pro Tips" section.

I might make some more changes, but wanted to gauge interest before spending time. One thing I might like to revise is the way to set the working module. Rather than suggesting to open just any file, I would suggest open a file something like runtests.jl borrowed from what I see and like in JuliaWeb. Then, you can simply click the module and choose your module rather than run a command.

Looks good to me. Thanks

RE: adding to main Julia docs.
I'm working on adding similar functionality (eval directly into module) as a REPL mode at the standard Julia REPL. When that happens I will definitely write up similar docs to live there also


Use cuda-version to constrain cudatoolkit.

This PR changes CUDA 11 packaging to rely on cuda-version pinnings to constrain the installed version of cudatoolkit.
See also: https://github.com/rapidsai/cudf/pull/13615

/merge

cc @rapidsai/kvikio-cmake-codeowners (for review)


Short answer type not supported

Despite all the short-answer tests (that appear to pass), this format is producing "MC" type questions. The grammar doesn't define Short Answer anywhere.
According to this reference:

Answers in Short Answer question-type are all prefixed by an equal sign (=),
indicating that they are all correct answers. The answers must not contain a
(~). If there is only one correct Short Answer, it may be written without the
equal sign prefix, as long as it cannot be confused as True-False. For short
answer, feedback is shown only when students input the
corresponding correct answer.

Making the grammar recognize the difference could be complex. Modifying the question type from "MC" to "Short" might be easier when the conditions are satisfied.

Need a test case for

If there is only one correct Short Answer, it may be written without the
equal sign prefix, as long as it cannot be confused as True-False.


Print usage instead of panic for no arguments

Previously, if no arguments were passed to the root command, a panic was triggered which in turn bypassed the error handling strategy. Also the provided message was not really helpful to the user.
With this commit the usage is printed instead. Additionally, an error is returned which is correctly handled by the error handling strategy.

Nevermind, I have confused two error messages. I need to further investigate my problem... Sorry.

👍
Maybe the panic should have been better documented.
It should never happen in reality...

@posener The problem I am currently encountering is, that as soon as subcommands are defined, it is no longer possible to call the application without them:

Calling the application with only root level flags (that are not a help flag).
Calling the application with no commands or flags.

For some reason, I thought the panic was the problem, which is obviously wrong. However it is triggered by the main.go inside the example folder. The call to ParseArgs() should rather be a Parse() call.
Should I create an issue for these findings, are they intentional or should I just continue fixing it and re-open this PR once I am done?

Yes, this is how it was designed to.
I think that most CLIs, if they choose to have subcommands, they enforce
them. Good known examples are git, docker, go, kubectl.
Why does your command is different?
On Fri, Sep 25, 2020, 23:46 Jan<EMAIL_ADDRESS>wrote:

@posener https://github.com/posener The problem I am currently
encountering is, that as soon as subcommands are defined, it is no longer
possible to call the application without them:

Calling the application with only root level flags (that are not a
help flag).
Calling the application with no commands or flags.

For some reason, I thought the panic was the problem, which is obviously
wrong. However it is triggered by the main.go inside the example folder.
The call to ParseArgs() should rather be a Parse() call.
Should I create an issue for these findings, are they intentional or
should I just continue fixing it and re-open this PR once I am done?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/posener/cmd/pull/24#issuecomment-699147161, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHAN7X3E2XERSIVGLLFFS3SHT6T7ANCNFSM4RZ7PLFA
.

@posener You are 100% correct. What all these applications do, if you call them without any subcommands, is that they print the usage instructions. Thats what I was going to implement at first and how I discovered theses issues.
Just printing that a subcommand is missing might not be very helpful to a user who is not familiar with the tool. I will adapt my PR accourdingly, so that it will print the usage information, if called without sub commands. Is that fine with you?

Sounds great, thanks 👍
On Fri, Sep 25, 2020, 23:56 Jan<EMAIL_ADDRESS>wrote:

@posener https://github.com/posener You are 100% correct. What all
these applications do, if you call them without any subcommands, is that
they print the usage instructions. Thats what I was going to implement at
first and how I discovered theses issues.
Just printing that a subcommand is missing might not be very helpful to a
user who is not familiar with the tool. I will adapt my PR accourdingly, so
that it will print the usage information, if called without sub commands.
Is that fine with you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/posener/cmd/pull/24#issuecomment-699151001, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHAN7TLHGW6OTYA3V5ZKFTSHT7W5ANCNFSM4RZ7PLFA
.

The PR could be merged not from my point of view. I am unsure how I caused the coverage to go down though :(.


ffi: Add IrUnitHandlerInterface to perform user-defined handling for deserialized IR units.

Description

This PR adds IrUnitHandlerInterface as described in #539. These methods will be called inside the IR stream deserializer to perform user-defined handling for each type of IR unit.
Regarding design choice, we will use concept to define methods required from a user-implemented handler. OOP with inheritance is not used to avoid the virtual call overhead.
We also add a unit test with a trivial handler that doesn't do anything meaningful to test the interface's basic functionality and show an example of implementing a handler. The unit test also ensures the concept template can be properly compiled with a correct interface implementation.
Validation performed

Ensure all workflows passed
Ensure newly added unit tests passed

@coderabbitai review


Error while convert the Tensorflow to tensorflowlite model

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow installed from (source or binary):
TensorFlow version (or github SHA if from source):

Provide the text output from tflite_convert
Some of the operators in the model are not supported by the standard TensorFlow Lite runtime. If those are native TensorFlow operators, you might be able to use the extended runtime by passing --enable_select_tf_ops, or by setting target_ops=TFLITE_BUILTINS,SELECT_TF_OPS when calling tf.lite.TFLiteConverter(). Otherwise, if you have a custom implementation for them you can disable this error with --allow_custom_ops, or by setting allow_custom_ops=True when calling tf.lite.TFLiteConverter(). Here is a list of builtin operators you are using: ADD, CONCATENATION, CONV_2D, DEPTHWISE_CONV_2D, LOGISTIC, RESHAPE. Here is a list of operators for which you will need custom implementations: TFLite_Detection_PostProcess.

Graph_def_file = ssdlite_mobilenet_v2_coco_2018_05_09/tflite_graph.pb
Also, please include a link to a GraphDef or the model if possible.
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Please have a look on #27241, FAQ, Select operators from TensorFlow. Let us know if that resolves the issue. Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Change (some) select2 instances to use AJAX queries

As the database size grows (at least in my case) the number of possible entries for drop-down boxes is very large. It may make sense to look at transitioning some of the drop-down menus to using ajax queries to fill the selections based on user queries.
i.e. fill out the drop-down menus with results as the user types

Implemented in https://github.com/inventree/InvenTree/pull/1716


ARROW-10549: [C++][Dataset] RADOS dataset

This PR contains a basic implementation of the Dataset API on Ceph that uses the librados C++ API to defer evaluation of expressions to a RADOS storage backend. The storage-side code is included, as well as unit and integration tests.
The Dataset implementation on RADOS is done by adding new RadosDataset and RadosFragment classes. A scanning operation triggers the evaluation of expressions on the storage-side. The PR includes a wrapper for the librados library, as well as a mock, that allows to run unit tests without having a Ceph instance. Integration tests have been modified in order to install Ceph and run without the mocks (running tests against a single-node Ceph "cluster").
The storage-side code is implemented as a RADOS CLS (object storage class) using Ceph's RADOS SDK. The code lives in cpp/src/arrow/adapters/arrow-rados-cls/, and is expected to be deployed on the storage nodes (Ceph's OSDs) prior to operating on tables through the RadosDataset implementation. This PR includes a cmake configuration for building this library if desired (ARROW_CLS cmake option).
Follow up work includes: dataset discovery, python bindings, large fragment stripping, IPC improvements on the backend, and a python library for writing tables.

we are working on a different version of this same functionality, and thus will close this for now. thanks!

we are working on a different version of this same functionality, and thus will close this for now. thanks!


ESP32-C3: Connecting and disconnect to enterprise access-point in a loop stops working after a few iterations

see https://github.com/esp-rs/esp-hal/issues/2201#issuecomment-2363566900
It seemed it will be solved by updating the drivers which apparently improved the situation but didn't fully solve it.
This seems to happen only on ESP32-C3 - e.g. on ESP32-C6 it runs forever (or at least until it exceeds my patience).
It only affects wpa2-enterprise - connecting to a wpa2-personal access-point in a loop works fine

Update: Seems it IS fixed by the driver update


add annotations for FunctionsConversion

cherry-pick experiment
Below commit from cnch-ce-merge is cherry-picked:
commit 1a5f04039a2d8a75b1249838230287d4d7567b11
Author: dylan.ghee<EMAIL_ADDRESS>Date:   Thu Feb 9 15:22:14 2023 +0800

    add annotations for FunctionsConversion

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.dylan.ghee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Create FizzBuzzAsCompilerError.cpp

oof

This code was stolen.
https://www.adamtornhill.com/articles/fizzbuzz.htm


MAC os support

Anything to try with clang or gcc, otherwise a ticket to watch support.

In WebUI 1.x (Written in C++), someone was maintaining the Mac support. Currently, WebUI 2.x is wholly rewritten in C, and no one has yet created a PR for Mac.
If no one creates a PR for Mac in the next week or two, then I will work on it. It's just a one-weekend day job. Please keep this open. Thank you for reporting.

@hassandraga I'd give it a shot, but it doesn't look like the build process is documented anywhere. Any tips on where to get started?

Hi @cowboyd, The build process is very simple, take a look on the Linux build as it should be similar to macOS.
This is the how Firefox run in macOS in the code, you can search 'macOS' keyword in the code to see the other commands that still need to be implemented. I guess no C code is needed, but we need someone that have a macOS, and he know how to run web browsers from command line.
In the other hand, you can simply test and share with us the commands result before & after installing the browsers, me or someone will implement it.
Google Chrome
Check if browser exist by the returning code: open -R -a "Google Chrome"
Browser path: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome
Firefox
Check if browser exist by the returning code: open -R -a "firefox"
Browser path: /Applications/Firefox\ Firefox.app/Contents/MacOS/Firefox\ firefox
Epic Browser
Check if browser exist by the returning code: open -R -a "Epic"
Browser path: /Applications/Epic\ Epic.app/Contents/MacOS/Epic\ Epic
Vivaldi Browser
Check if browser exist by the returning code: open -R -a "Vivaldi"
Browser path: /Applications/Vivaldi\ Vivaldi.app/Contents/MacOS/Vivaldi\ Vivaldi
Brave Browser
Check if browser exist by the returning code: open -R -a "Brave"
Browser path: /Applications/Brave\ Brave.app/Contents/MacOS/Brave\ Brave
Yandex Browser
Check if browser exist by the returning code: open -R -a "Yandex"
Browser path: /Applications/Yandex\ Yandex.app/Contents/MacOS/Yandex\ yandex-browser
Chromium Browser
Check if browser exist by the returning code: open -R -a "Chromium"
Browser path: /Applications/Chromium\ Chromium.app/Contents/MacOS/Chromium\ chromium
Someone last year tested and implemented the Google Chrome commands on macOS, but the other browser's command is just our imagination! never tested before.

I add a build for MacOS. For some context, I'm trying to get this running with Deno and MacOS. It does appear to work, however, the hello_world.ts return immediately, and does not wait for webui.wait();

open -a "Google Chrome" worked but not with -R flag

Thank you for the macOS support.
About the issue, I re-test it in Windows using Chrome, and it seems to be working. Can you please follow those steps to share the log:

Re-build the lib using make debug command
Copy webui-2-x64.dyn in examples/TypeScript/Deno/module
Run deno run --allow-all --unstable hello_world.ts
Share the logs here

open -a "Google Chrome" worked but not with -R flag

Indeed, open -R -a "Google Chrome" is the way how WebUI checks quickly if Google Chrome is installed, it's supposed not to run it.
To run it, WebUI will use something like that /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --user-data-dir="/tmp/WebUIChromeProfile" --no-first-run --disable-gpu --disable-software-rasterizer --no-proxy-server --safe-mode --disable-extensions --disable-background-mode --disable-plugins --disable-plugins-discovery --disable-translate --bwsi --disable-sync --incognito --app=http://localhost:123456.

@cowboyd You can re-test it using the last commit. If you still have an issue with webui.wait();, please feel free to open a new one.

file:///Users/carflow/Sites/newwebui/webui/examples/TypeScript/Deno/module/webui.ts:5340: Uncaught TypeError: Deno.UnsafePointer.create is not a function
But it does open in chrome, opens in chrome no matter what actually

@gregpalaci, Are you trying to run a TypeScript example? if yes, please make sure you are using the latest Deno, as they just recently did major changes on pointers support using v8. I test it using Deno v1.31.3.

I guess that is built into the binary via include/webui.h ?

Yes, if your UI calls .js or .ts files, WebUI tries to interpret those files using Deno or Nodejs if available. But you can fully control this behavior using APIs.
webui_script_runtime(my_window, webui.runtime.deno); // Deno
webui_script_runtime(my_window, webui.runtime.nodejs); // Nodejs
webui_script_runtime(my_window, webui.runtime.none); // Disable this feature

@gregpalaci I just discovered that we forgot to update the Deno examples to WebUI v2.1.1. I will update it soon. Thank you for pointing this out.

deno 1.29.2 (release, aarch64-apple-darwin)
v8 <IP_ADDRESS>
typescript 4.9.4
just FYI

Starting from Deno 1.31 (Replace pointer integers with v8::External objects), which is used by webui.ts. I think you should upgrade your Deno to the latest.

Brave Browser
Check if browser exist by the returning code: open -R -a "Brave"
Browser path: /Applications/Brave\ Brave.app/Contents/MacOS/Brave\ Brave

open -R -a "Brave Browser"
Brave doesn't work

open -R -a "Brave Browser" won't run the browser, but it returns the exit code, 0 mean it exists, otherwise, it means it does not exist.
The latest commit support Chrome in macOS. The support for Brave in macOS is also included but has yet to be tested. Can you please try open -W "/Applications/Brave.app"? Or, simply clone the latest commit and run the examples.

open -W "/Applications/Brave.app"
The file /Applications/Brave.app does not exist.
open -W "/Applications/Brave Browser.app" opens

Sorry I meant this error from before I understand the -R flag now
$: open -R -a "Brave" Unable to find application named 'Brave'

Great! Then we should fix this in the code.
Would you like please change this line online (no need for git clone & push)?

Please, let's continue at https://github.com/alifcommunity/webui/issues/75.


Connect to Redis via SSL

I am using Azure Redis Cache, which offers the option to connect via SSL. Is SSL supported in this package? I manage to connect via the non-SSL port, but as soon as I change the RedisOptions to try connecting to the SSL port, the connection fails with the following error:
"Error: Redis connection to xxx.redis.cache.windows.net:6380 failed - read ECONNRESET
at RedisClient.flush_and_error "

The solution is to enable non-SSL port in Azure
https://azure.microsoft.com/en-us/documentation/articles/cache-nodejs-get-started/

In case anyone else comes here from google, it looks like this should be supported now:
https://docs.microsoft.com/en-us/azure/azure-cache-for-redis/cache-nodejs-get-started#connect-to-the-cache

It took me a second to see what exactly the difference was, hence calling it out here for others to find. The key difference is providing the name of the redis host as part of the tls object:
{
  auth_pass: REDISACCESSKEY,
  tls: {servername: REDISHOSTURL}
}

@ntziolis Thanks it helped a lot.


@openshift/dynamic-plugin-sdk or @openshift-console/dynamic-plugin-sdk

Which is correct to use, @openshift/dynamic-plugin-sdk or @openshift-console/dynamic-plugin-sdk?
The OpenShift 4.12 docs here point to the openshift/console-plugin-template repo. That repo is using @openshift-console/dynamic-plugin-sdk.
I noticed that @openshift-console/dynamic-plugin-sdk is missing implementations of documented functions like k8sListResource, k8sCreateResource, etc. The types are there but the implementation isn't. Those functions are implemented in this repo though.

Hello @RyanMillerC

Which is correct to use, @openshift/dynamic-plugin-sdk or @openshift-console/dynamic-plugin-sdk?

OpenShift Console 4.12 uses its own plugin SDK implementation via @openshift-console/dynamic-plugin-sdk and @openshift-console/dynamic-plugin-sdk-webpack packages. When writing a plugin for OpenShift Console 4.12 or earlier, you should use these packages.
See "OpenShift Console Versions vs SDK Versions" section in Console plugins README which maps Console release versions to plugin SDK package versions.

I noticed that @openshift-console/dynamic-plugin-sdk is missing implementations of documented functions like k8sListResource, k8sCreateResource, etc. The types are there but the implementation isn't.

Console K8s utility functions like k8sListResource are declared here - these are typically wrapped via adapterFunc for backwards API compatibility.
These utilities should be available through @openshift-console/dynamic-plugin-sdk package in terms of both code and typings :thinking: when you clone Console repo and run yarn install it will automatically rebuild all Console plugin SDK dist packages at frontend/packages/console-dynamic-plugin-sdk/dist.
The core subdirectory is for @openshift-console/dynamic-plugin-sdk package published to npmjs. Console k8sListResource and other K8s utilities are in lib/utils/k8s/k8s-resource.js under this subdirectory.
I think the issue may be with export name - the function is exported under name k8sList and not k8sListResource.
export {
  k8sGetResource as k8sGet,
  k8sCreateResource as k8sCreate,
  k8sUpdateResource as k8sUpdate,
  k8sPatchResource as k8sPatch,
  k8sDeleteResource as k8sDelete,
  k8sListResource as k8sList,
  k8sListResourceItems as k8sListItems,
} from '../utils/k8s';

Those functions are implemented in this repo though.

Right, we copied Console K8s utility functions into this repo and tweaked them a bit. But we export them as e.g. k8sListResource instead of k8sList which is likely the source of confusion :smiley:

cc @spadgett

Thanks for the response @vojtechszocs.
To be 100% clear, I'm developing a plugin that will be bundled into a community operator. Based on your reply I will use (@openshift-console/dynamic-console-plugin and related) that github.com/openshift/console provides since I'm targeting OpenShift 4.12 and below.
Are the packages (@openshift/dynamic-console-plugin and related) that this repo provides for future versions of OpenShift (4.13 and on)?

What threw me off on k8sListResource vs k8sList is this comment that says to use k8sCreateResource instead of k8sCreate:
@deprecated Use {@link k8sCreateResource} instead.
...
export const k8sCreate = <R extends K8sResourceCommon>(
...

The other get, create, list k8sActionResource functions have a similar deprecated message.


Incompat with More company

More company now lets you change your cosmetics in-game but having Lethal Performance makes it so you can't see your character when doing so

Here is how it looks like without lethal performance

Fixed in 0.4.3


Typing errors in certificate validity check text

Describe the bug

Please correct the typing errors:
certifivate -> certificate
couintry -> country
Technical details

iOS wallet app 1.1.0

@kerstin-oppermann-tsi fixed and will be available on the next build

is fixed in release 1.1.0(tst)


Kubernetes Resource Typescript Generation

Just stumbled across this project and already a general fan! I'm currently using cdk8s, which has an import feature which allows for generating typescript class/validation from kubernetes resource definitions and CRDs. Is this something JK would consider?
Related #54

Yes I think so. If it can be written as, or compiled to, pure JavaScript, it could just be a module to be called with (say),
jk run -m @jkcfg/kubernetes/importtypes

This seems plausible -- it's just recursion over a YAML structure, and jk can read YAMLs. But it may not be trivial!


Fix get_dead_nodes query

partial fix for  #1028

I had not considered using Timestamp (which is effectively "last updated") as a solution.  Interesting.
Can this include updating the log & Error messages to differentiate between a node with an expired heartbeat and a node that never generated a heartbeat?
I'm think about this:
https://github.com/microsoft/onefuzz/blob/48978ce881ed3e1f9fce1b6f49f05043f18002fb/src/api-service/__app__/onefuzzlib/workers/scalesets.py#L389-L395
and this:
https://github.com/microsoft/onefuzz/blob/48978ce881ed3e1f9fce1b6f49f05043f18002fb/src/api-service/__app__/onefuzzlib/workers/scalesets.py#L399-L403


Mocha: Permission denied error occured in Jenkins while Integrating Playwright_Mocha with Jenkins via GItHub

I am trying to run Playwright_Mocha through Jenkins, so I have created a Repository in Git Hub and the same is given in Jenkins Configuration (Source Code Management).
I have given the Build Step, to run my automation script which executes as shell command "npm run aboutPage" In which aboutPage has the script as below in package.json file.
 "scripts": {
"aboutPage": "mocha --timeout 800000 --config= ./.mocharc.js ./test/aboutPage.spec.js"
}

below are the dependencies which I have installed in my project.
{
  "dependencies": {
    "@supercharge/fs": "^3.4.0",
    "allure-commandline": "^2.18.1",
    "allure-mocha": "^2.0.0-beta.19",
    "chai": "^4.3.6",
    "chai-dom": "^1.11.0",
    "chai-jquery": "^2.1.0",
    "chai-visible": "^0.1.5",
    "fs-extra": "^10.1.0",
    "mocha": "^10.0.0",
    "mocha-allure-reporter": "^1.4.0",
    "mochawesome-report-generator": "^6.2.0",
    "mochawesome-screenshots": "^1.7.3",
    "mysql": "^2.18.1",
    "node-localstorage": "^2.2.1",
    "node-sessionstorage": "^1.0.0",
    "playwright": "^1.27.0",
    "prettier": "^2.7.1",
    "read-excel-file": "^5.5.3",
    "sessionstorage": "^0.1.0",
    "winston": "^3.8.2",
    "winston-daily-rotate-file": "^4.7.1"
  },
  "devDependencies": {
    "mochawesome": "^7.1.3"
  }
}

When I build Jenkins, below is the error displayed in the Console Output:
npm run aboutPage

<EMAIL_ADDRESS>aboutPage /home/qabot/data/jenkins_home/workspace/TestDemo_QA_Automation_QATAR
mocha --timeout 800000 --config= ./.mocharc.js ./test/aboutPage.spec.js

sh: 1: mocha: Permission denied
npm ERR! Linux 4.15.0-1113-azure
npm ERR! argv "/home/qabot/.nvm/versions/node/v4.3.2/bin/node" "/home/qabot/.nvm/versions/node/v4.3.2/bin/npm" "run" "aboutPage"
npm ERR! node v4.3.2
npm ERR! npm  v2.14.12
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>aboutPage: mocha --timeout 800000 --config= ./.mocharc.js ./test/aboutPage.spec.js
npm ERR! Exit status 126
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>aboutPage script 'mocha --timeout 800000 --config= ./.mocharc.js ./test/aboutPage.spec.js'.
npm ERR! This is most likely a problem with the playwright_mocha package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     mocha --timeout 800000 --config= ./.mocharc.js ./test/aboutPage.spec.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls playwright_mocha
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/qabot/data/jenkins_home/workspace/TestDemo_QA_Automation_QATAR/npm-debug.log
Build step 'Execute shell' marked build as failure
Finished: FAILURE.
Please let me know what and where I am doing wrong.
Thanks in advance

@RaviThippana please note this is Mocha's issue tracker, not a help forum. Thank you.


Implement fire weather index

Please check if the PR fulfills these requirements

[x] This PR addresses an already opened issue (for bug fixes / features)
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated
[ ] bumpversion (minor / major) has been called
[ ] Tags have been pushed

What kind of change does this PR introduce? (Bug fix, feature, docs update, etc.)
Adds new indicator.

Does this PR introduce a breaking change? (Has there been an API change?)
No

Other information:
Fixes #204

When merging, please put fixes #{issue number} in your comment to auto-close the issue that your PR addresses. Thanks!

@tlogan2000 First go at it.  Also, should we expose all underlying indicators as xclim indicators ? So far only fwi is exposed.

Pull Request Test Coverage Report for Build 825

124 of 138 (89.86%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 91.979%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

xclim/utils.py
4
6
66.67%

xclim/indices/fwi.py
106
118
89.83%

Totals

Change from base Build 819:
-0.2%

Covered Lines:
1399

Relevant Lines:
1521

💛  - Coveralls

Pull Request Test Coverage Report for Build 825

124 of 138 (89.86%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 91.979%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

xclim/utils.py
4
6
66.67%

xclim/indices/fwi.py
106
118
89.83%

Totals

Change from base Build 819:
-0.2%

Covered Lines:
1399

Relevant Lines:
1521

💛  - Coveralls

@tlogan2000 First go at it.  Also, should we expose all underlying indicators as xclim indicators ? So far only fwi is exposed.

Yes. exposing sub indicators would be good ... I know that some users use at the very least the drought code (dc) individually

We might want to take some time to look more deeply into numba for the ufunc calls?  It could possibly help with the runlength performance as well
https://medium.com/capital-one-tech/dask-numba-for-efficient-in-memory-model-scoring-dfc9b68ba6ce
https://towardsdatascience.com/how-i-learned-to-love-parallelized-applies-with-python-pandas-dask-and-numba-f06b0b367138

Ok. I suggest we keep optimizations for a later time. One issue at the moment is that not all lines of codes are exercised by the test suite. I'd like us to make sure we get full coverage before optimizing. Ideas of where we'd get a larger sample of fwi values with a larger range of inputs ? Another option is to create a synthetic data set from the original fortran code.

Ok. I suggest we keep optimizations for a later time. One issue at the moment is that not all lines of codes are exercised by the test suite. I'd like us to make sure we get full coverage before optimizing. Ideas of where we'd get a larger sample of fwi values with a larger range of inputs ? Another option is to create a synthetic data set from the original fortran code.

I agree re:optimizing was just mentioning it. I have come across numba a few times now (again yesterday) but is probably not a priority...  I will see if I can find another source of test data (input / output) for FWI.
I think implementing a mechanism of np.cumsum on the entire fire season at once would likely be beneficial.  From memory I think right now the code has to run in a loop using previous days values as t0?

Correct. It wasn't obvious to me however how we could vectorize the code.

I have a test dataset for FWI. Sending it through email and letting you put it where it needs to be.

Even once code is complete we may need to investigate how to determine a season start date if no snow cover data is avaliable ( e.g. CC projections?). Not sure b is appropriate for areas with lots of snow accumulation.
Taken from
http://nofc.cfs.nrcan.gc.ca/bookstore_pdfs/29152.pdf
(a) In regions normally covered by snow during
the winter, begin calculations on the third day
after snow has essentially left the area to which
the fire danger rating applies.
(b) In regions where snow cover is not a
significant feature, begin calculations on the
third successive day that noon temperatures of
12 °C or higher have been recorded.
In either case, use the following starting
values:
FFMC 85; DMC 6; DC 15

A (similar) method here:
http://cwfis.cfs.nrcan.gc.ca/background/dsm/fwi
FWI Calculation Start-up
To determine spring start-up dates and starting fuel moisture code values, the procedures described in Turner and Lawson (1978) are used. There are two methods, depending on snow cover.
Method 1
For stations that report significant snow cover during the winter, start-up occurrs when the station has been snow-free for three consecutive days. Significant snow cover is defined as a mean snow depth of more than 10 cm, with snow cover present at least 75% of the days in January and February. Start-up values are as follows:
Fine Fuel Moisture Code (FFMC) set to 85
Duff Moisture Code (DMC) set to 6
Drought Code (DC) set to 15*

Method 2
For stations that do not report significant snow cover during the winter, start-up occurs when the mean daily temperature is 6°C or higher for three consecutive days. This temperature represents the approximate lower limit for plant growth. Start-up values are as follows:
FFMC set to 85
DMC set to 2 times the number of days since precipitation
DC set to 5 times the number of days since precipitation*

*Where overwinter precipitation data are available, the DC is set according to an alternative, more rigorous method, Turner and Lawson (1978), which takes into account the fact that saturation of the deep fuel layers may not occur over the winter. In areas with low overwinter precipitation, the starting value for the DC can be significantly higher than the default.

Possibel test data using MERRA2
https://data.giss.nasa.gov/impacts/gfwed/

bingo
https://open.canada.ca/data/en/dataset/3d528848-3d43-41c9-83e3-11eae5c50ee8

Does not include the FWI values...

I'll see if people from the CFS can provide some input output data that we can use to validate with

Ok, in the meantime I'm trying to compare results with GFWED.

Managed to run the FWI calculation on MERRA and I'm getting values fairly close to GWFED values northward of the 30th latitude. There are differences south of 30. The code has probably been adapted, but I can't find the code they're using.
Oh, and it's extremely slow...
Can't spend a lot more time on it. Has someone some time to investigate the gfwed differences and code optimization ?

I can try to dig into this probably next week though... Meetings today and tomorrow

https://github.com/SantanderMetGroup/fireDanger/blob/devel/R/fwi1D.R

GFWED Code: https://portal.nccs.nasa.gov/datashare/GlobalFWI/v2.0/20181216.GFWEDCode.tar.gz

GFWED Code: https://portal.nccs.nasa.gov/datashare/GlobalFWI/v2.0/20181216.GFWEDCode.tar.gz

Are we back to Matlab?? :)

No, but it's useful to see how they computed the FWI so may resolve any differences between their results and ours.

Was only kidding.  It seems like a good start.  Personally will be able to follow it better than R....  I'll likely have time to look more at this thurs/fri this week

Pre-christmas push: We now have a working code for all indices! It packs all the computation into one large temporal iterator
The individual indices are still iterated spatially, but could easily be vectorized, either by replacing math by numpy or using numba's @vectorize or both. I'll do some benchmarking for that. I tested with data from Merra2 over one year and compared with the calculations of GFWED. Instead of starting from scratch, I started the calculations with the indices from GFWED. I get a mean error of 20% on all indices, but it's getting there. (Also, I am not using the proper snow_depth` data yet.

@aulemahal I'm wondering about the timeline on this PR. Think it could be closed by Friday?

Seems ambitious. I suggest this goes into 0.14.

Indeed, Friday the 10 is a bit ambitious, but one or two weeks might be feasible.


Fixed text errors

Fixes #135

Hey! @andytudhope ! My PR is ready for review and merge. Thanks!

the vast majority of these changes are either incorrect (likely because they were found using an automated tool), or they change "onchain" to "on-chain" which is incorrect.  But thanks for the PR!


Add "build-finished" JSON message.

This adds a JSON message when a build is finished.  This is useful for tools to know when to stop parsing JSON, which is particularly useful for commands like cargo test or cargo run where additional output may follow.
Closes #7978

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton I thought some more about the comment you left, but I really think it is better just to have a single message.  I wouldn't want tools to have to listen for N messages to know when things are done.  And generally I don't need to know when something launches.
We can add "launched" messages in the future if it looks like people want it.  Also, I think the libtest JSON message already has a separate message for "starting", so test frameworks may already cover that need.

Seems reasonable for me to add, it's not like this will burden us with backward compatibility, and it does seem useful.
However, I do have a gut feeling that a "proper" solution here is allowing clients to split Cargo's command in two phases, building and running.  But it seems unlikely that we actually add such a --no-run flag, and, even if we do, such addition wouldn't be precluded by the BuildFinished message. We might even want to have BuildFinished message anyway, to, for example, convey the [optimized + debuginfo] in 60 seconds info in machine-redable form.

cargo build --example foo I think is 100% identical to a hypothetical cargo run --no-run.  The JSON even gives you the path to the executable, so a tool can just run it directly (there might be some rare dylib path issues, but programs probably shouldn't rely on those, or the tool can just execute cargo run if it wants to be safe/simple).  My tool just executes cargo run and once it sees the text ^\s*Running  it stops looking for JSON messages.  I can switch to looking for "build-finished" with this PR.

@rfcbot fcp merge
I'm personally ok doing this, and it also seems plausible to take the strategy that @matklad mentions but I don't think there's any reason they need to be mutually exclusive!

That's enough of sign-off for me, and we can always back out if there are other objections!
@bors: r+

:pushpin: Commit c889bbfba8103657afc41d48365817467de605b4 has been approved by alexcrichton

:hourglass: Testing commit c889bbfba8103657afc41d48365817467de605b4 with merge 239f2bfd0ccce5478837861a43cfc73a44dc64b2...

:sunny: Test successful - checks-azure
Approved by: alexcrichton
Pushing 239f2bfd0ccce5478837861a43cfc73a44dc64b2 to master...


Create accordion-v2.html

Fixes issue #499

Good job @rahulkarda
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

Star this repository. ⭐
SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .
Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.


proposal: Go 2: call error handling functions with ...

Proposal Details
In the current Golang language, error handling requires the use of if statements and return values to check and handle errors. While this approach is effective, it introduces a lot of repetitive code and redundant error handling logic in the codebase. To simplify the error handling process, improve code readability, and maintainability, we propose enhancing the error handling syntax sugar in Golang to make it more concise and flexible.
Background:
In the existing Golang language, error handling is typically done as follows:
func Do(param string) (string, error) {
    return "", nil
}

func DoMany(param string) error {
    result, err := Do(param)
    if err != nil {
        return err
    }
    // Handle result
    return nil
}

This approach requires the use of if statements and return values to check and handle errors, resulting in a lot of repetitive code and redundant error handling logic. To simplify the error handling process, improve code readability, and maintainability, we propose enhancing the error handling syntax sugar in Golang.
Proposal:
We propose introducing the following new syntax sugar to simplify error handling in Golang:

Use named optional functions as error handlers:

func check(err error) error {
    return err
}

var nilOrReturn = check

func handle(err error, param string) error {
    return fmt.Errorf("error: %w, param: %s", err, param)
}

Support using syntax sugar to handle errors in function calls:

func DoMany(param string) error {
    // 1. regular error handling
    _, err := Do(param)
    if err != nil {
        return check(err)
    }

    // 2. is syntax sugar of 1
    _, err = Do(param)
    nilOrReturn...(err) // flexible naming notation

    // 3. is syntax sugar of 2, perhaps the most use case
    result1, check...err := Do(param)
    fmt.Println(result1)

    // 4. also support multiple params handler
    _, err = Do(param)
    handle...(err, param)

    // -----------------edge cases-------------------
    // 5. allow omit extra parameter?
    _, err = Do(param)
    handle...(err, /*param: default zero? */ )

    // 6. similar to 5, but a little bit make sense
    _, handle...err = Do(param)

    // 7. syntax error? many conflictions
    _, handle...(err, param) = Do(param)

    // 8. not necessary?
    inverseOrder := func(msg string, err error) error {
        return err
    }
    _, err = Do(param)
    inverseOrder...(param, err)
    return nil
}

Additional Examples:

func Do2(param string) (string, error) {
    return nil, nil
}

func handle2[T any](err error) (T, error) {
    var t T
    return t, err
}

func handleMore[T any](err error, param string) (T, error) {
    var t T
    return t, fmt.Errorf("error: %w, param: %s", err, param)
}

func DoMany2(param string) (string, error) {
    result, handle2[string]...err := Do2(param)
    return result, nil
}

func DoMore(param string) (string, error) {
    result, err := Do2(param)
    handleMore[string]...(err, param)
    return result, nil
}

Apologies in advance for any lack of thoroughness, any suggestion is appreciated.

Please fill out https://github.com/golang/proposal/blob/master/go2-language-changes.md when proposing language changes

I don't think it's clear where the conditional branch went?

Would you consider yourself a novice, intermediate, or experienced Go programmer?
experienced.
What other languages do you have experience with?
java,scala,javascript,python,rust
Would this change make Go easier or harder to learn, and why?
harder to learn as introduced new syntax.
Has this idea, or one like it, been proposed before?
yes.
If so, how does this proposal differ?
difference to the keyword approach, check, handle:
this proposal allow to capture more variables than the handle clause.
differ from the leftside function: 52416
the leftside function is immediately return for any error while this proprosal allow us handle the error before return.
Who does this proposal help, and why?
all go developer, the code will be less verbose and repetitive.
What is the proposed change?
see #1.
Please describe as precisely as possible the change to the language.
see #1.
What would change in the language spec?
new feature, see #1.
Please also describe the change informally, as in a class teaching Go.

Show example code before and after the change.
What is the cost of this proposal? (Every language change has a cost).
How many tools (such as vet, gopls, gofmt, goimports, etc.) would be affected?
many tools affected, eg: vet, linters, gopls, gofmt
What is the compile time cost?
not sure, but I believe it is small
What is the run time cost?
small cost
Can you describe a possible implementation?
No.
Do you have a prototype? (This is not required.)
How would the language spec change?
Orthogonality: how does this change interact or overlap with existing features?
Yes there will be overlap with existing error handling.
Is the goal of this change a performance improvement?
No
If so, what quantifiable improvement should we expect?
How would we measure it?
Does this affect error handling?
If so, how does this differ from previous error handling proposals?
Is this about generics?
If so, how does this relate to the accepted design and other generics proposals?

@seankhliao
The new syntax will either do return or nothing based on the error value. My proposal is below statment will be eventually translated to the idiomatic if err != nil ...
// before
result1, check...err := Do(param)
// after
_, err := Do(param)
if err != nil {
    return check(err)
}

This looks a lot more like general function inlining (check, handle are all inlined at caller sites) rather than something particular to error handling. If I'm not wrong, we have to carefully consider how inlining might be used in other ways, and the effect it will have on readability and linear control flow expected from Go.

This seems like another variation on the previous "try" proposal #32437, and it is unclear how it addresses the problems that ultimately caused that proposal to be retracted. Therefore this is a likely decline. Leaving open for a further four weeks for final comments.

@griesemer

To start, your proposal is pretty unclear. You introduce a few functions (check, handle) and some syntactic sugar, but you're not explaining how these connect. There are examples that may be clear to you, but they are certainly not clear to everybody else.

Apologize for causing any understanding difficulty. Although I thought It is quite simple and concise, I am glad to provide more explanations.
// before
result1, check...err := Do(param)
// after
_, err := Do(param)
if err != nil {
    return check(err)
}

The ... syntax is working like to say code manipulation operator.
There are 2 alternative ways of using.

It can also be used in a single statement.
Then It will simply be translated to a nil error check following a function call following a return.
It can be put on the left side of a function call in form of {{$functionName}}...{{$variableName}}
Then it will firstly create a new line and then do the same as 1st alternative

The handle function is used to handle error,

it has at least 1 parameter
the 1st parameter must be error type
it may return 0 or 1 or more values.
Below are valid examples.

func check(err error) error
func check[T any](err error) (T, error)
func check[T any](err error, otherArgs ...any) (T, error)

You are obviously introducing new syntax (the ... in the middle of variable lists) without an explanation or any analysis of how such a syntax change would affect the grammar of the language or whether it might cause problems. It's a pretty big hammer.

Excellent point, I insist not to fix the grammar but this do affect the language in many perspectives. And that's why I don't  wish this proposal be closed. It is hard to say affects without enough contributes and I ofcourse welcome for comments.

Second, as @alandonovan already mentioned, this doesn't look any better (e.g., more lightweight) from just glancing at the examples (which remain unclear) than many of the error handling proposals that came before this one, so it's not clear why this proposal should stand out above the rest.

Please let's forgot just mentioning many proposals balabala, could you please show me the real point. I believe there were some shining proposals ever appeared, But I suspect they are 'all' declined.
If I must raise out the any better, I already mentioned before.

compare to the "try" proposal, this proposal more more encourage to handle the error in explicit way
At least from my view, this is the better
compare to the "try" proposal, this proposal allow add context to the error result
This is the better as well

Finally, Go does have error handling, and it's explicit. It just so happens that in some code that explicit error handling code can be somewhat pervasive, while in other code it's not that pervasive. People who deal with code that have a lot of error handling would like a better solution. Others don't care that much. And again others think that Go's error handling is fine as is. And the split between these groups appears to be somewhat even, making it difficult to push forward an approach that is not obviously superbly better than what we have. And it seems that such an obviously superbly better approach has not yet surfaced (of course, individual authors of error handling proposals may feel differently, but that doesn't matter if not enough people agree). It doesn't seem what you are proposing is obviously superbly better than any of the other proposals that came before this one.

Sorry for the inaccuracy words. Yes, agree with most of the comments. I know it is hard to reach consesus, I wish we can achieve  it quickly while I also understand how hard it is. But from my point, we'd better encourage ideas rather than do nothing.

Per
// before
result1, check...err := Do(param)
// after
_, err := Do(param)
if err != nil {
    return check(err)
}

check...err is translated into the "after" code, is that correct? Can I write something else than check? Can I write foo...err (and define a foo function)? These are things that all need to be clarified.
I also point out that the use of ... in this context looks very odd. ... is not used elsewhere in Go as a "code manipulation operator", so it seems unwise to give it some completely different meaning. It's unclear what it means for ... to be on the left side of a function call.
But separately, the syntax you're implying with your examples is unlike anything else we have in Go. There's no convincing argument why this is any better than any of the many other error handling proposals.

check...err is translated into the "after" code, is that correct? Can I write something else than check? Can I write foo...err (and define a foo function)? These are things that all need to be clarified.
Correct and Yes and Yes.

No change in consensus, so declined.
— rfindley for the language proposal review group


Add jishaku

add jsk cog to bot

poetry.lock might be broken, would be great if someone checked

Appears that Jishaku is missing in the lock?
Delete the file and do poetry install


Add the HIST and IGMTF model on Alpha360

Add the HIST and IGMTF models to the main branch
Description
Adding the HIST and IGMTF models on Alpha360. I have tested the code, it can work well.
Motivation and Context

How Has This Been Tested?

[ ] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
[ ] If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

Pipeline test:
Your own tests:

Types of changes

[ ] Fix bugs
[ ] Add new feature
[ ] Update documentation

Please Fix the CI bugs


added starter code

Added html, assets folder, image folder in assets folder and css folder in assets folder. Added css to css folder. copy code template from Xandromus file urban-octo-telegram/develop added the images from the file to my own images folder copied the html and css code to my own.

added starter code from github account Xandromus file urban-octo-telegram


Dependency computation should only consider installed packages

We need to filter runtime_dependencies to include packages that are actually installed.
This can happen if some packages were manually removed. Filtering prevents a nil pointer error being thrown during the computation of dependencies.

@gelraen ran into another nil error :). Have a look when you have time?

Thanks!


fix: upgrade to version 3.0.602

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign daveconde
You can assign the PR to them by writing /assign @daveconde in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gsm
97495b646ccaa158a7be8f639f9dce261165e2e0
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Avoid showing adult content

Description
Both in the Movies list as well as Suggestions there are many titles that are 18+ adult content (sexual). It is not clear to me where this list is sourced from but I cannot find a way to make jellyseer kids safe
btw: using discover language: italian
Version
1.6.0
Steps to Reproduce

Set Discover language to Italian
Go to Movies
The first suggestions are adult content movies (e.g. titles by Tinto Brass)

Screenshots
No response
Logs
No response
Platform
desktop
Device
Thinkcentre
Operating System
Ubuntu 20
Browser
Firefox
Additional Context
No response
Code of Conduct

[X] I agree to follow Overseerr's Code of Conduct

Adult content is already filtered. But that filter is done by not allowing the content with the tag adult in them. But due to there being so many of those in tmdb, a lot slip through as they aren't properly tagged. There's nothing we can do about it except change it directly on tmdb (it's open source so you can do it too)

this is clearly possible… though unfeasible. Imagine retagging hundreds of
movies with the risk of new movies releases with the wrong tags finishing
in the jellyseer suggestions that are using your kids.
Wouldn’t be possible to add in settings a tag “blacklist” filtering out all
shows and movies with those tags? we are speaking of tags like:

sexploitation
prostitute
softcore
erotic movie

quite self explicative.
Please consider to take action in order to make jellyseer kids friendly.
Thanks
On Fri, 25 Aug 2023 at 17:11, Fallenbagel @.***> wrote:

Adult content is already filtered. But that filter is done by not allowing
the content with the tag adult in them. But due to there being so many of
those in tmdb, a lot slip through as they aren't properly tagged. There's
nothing we can do about it except change it directly on tmdb (it's open
source so you can do it too)
—
Reply to this email directly, view it on GitHub
https://github.com/Fallenbagel/jellyseerr/issues/460#issuecomment-1693520611,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFOR3F6YMCUMF46JPOPRB3XXC6CZANCNFSM6AAAAAA36EN6BQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

We are already blacklisting adult tags. Like I said a lot of tmdb adult movies (especially asian ones) are MISSING that tag so a lot still gets through

Thanks for your reply and ... sorry for insisting. My question is:
Would you consider to add a form box in Settings where users can blacklist
tags in a custom way? In this way, most of the erotic movies would be
easily filtered out.
Thanks for listening.
On Sun, Aug 27, 2023 at 2:23 PM Fallenbagel @.***>
wrote:

We are already blacklisting adult tags. Like I said a lot of tmdb adult
movies (especially asian ones) are MISSING that tag so a lot still gets
through
—
Reply to this email directly, view it on GitHub
https://github.com/Fallenbagel/jellyseerr/issues/460#issuecomment-1694654589,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFOR3A5FGH47L7YFLXMXHLXXM343ANCNFSM6AAAAAA36EN6BQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Thanks for your reply and ... sorry for insisting. My question is:
Would you consider to add a form box in Settings where users can blacklist
tags in a custom way? In this way, most of the erotic movies would be
easily filtered out.
Thanks for listening.

I'm sorry that I still don't understand what you mean by blacklist tags, when the movie doesn't contain a tag 😅

Thank you for your quick reply.
The tags are indeed there.
I give you an example. The following movie is the 2nd suggestion from
jellyseer when I click the button Movies (movie language is set to italian):
https://www.themoviedb.org/movie/37265-cosi-fan-tutte?language=it
as you can see this movie is erotic, containing -- among others -- the tag
"anal sex"
tags are explicit in erotic movies, they just do not contain the tag
"adult".
My question is:
would it be possible to have a form in the Settings to exclude custom tags?
In this way it' d be possible to sort out tags like the ones I cited
before, eg:

sexploitation
prostitute
softcore
erotic movie

is it clear now?
Thanks
On Sun, Aug 27, 2023 at 4:54 PM Fallenbagel @.***>
wrote:

Thanks for your reply and ... sorry for insisting. My question is:
Would you consider to add a form box in Settings where users can blacklist
tags in a custom way? In this way, most of the erotic movies would be
easily filtered out.
Thanks for listening.
I'm sorry that I still don't understand what you mean by blacklist tags,
when the movie doesn't contain a tag 😅
—
Reply to this email directly, view it on GitHub
https://github.com/Fallenbagel/jellyseerr/issues/460#issuecomment-1694688562,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFOR3A3UHXCSKPVIN3BAQTXXNNQ3ANCNFSM6AAAAAA36EN6BQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Oh yes. That is what I meant by filter system is in the works upstream. It requires some codebase changes as the TMDB API does not directly support excluding certain tags from queries afaik

It'd be great if you can consider it.
Thanks a lot for listening
On Sun, Aug 27, 2023 at 6:53 PM Fallenbagel @.***>
wrote:

Oh yes. That is what I meant by filter system is in the works upstream. It
requires some codebase changes as the TMDB API does not directly support
excluding certain tags from queries afaik
—
Reply to this email directly, view it on GitHub
https://github.com/Fallenbagel/jellyseerr/issues/460#issuecomment-1694713272,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFOR3BNVRC73KYRNJZFJBLXXN3R3ANCNFSM6AAAAAA36EN6BQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

It'd be great if you can consider it.
Thanks a lot for listening

Never said we weren't considering just might take some time because it requires some codebase changes 😔
Hopefully it's implemented on upstream(overseerr) sooner if not here then.
Also might be a good idea to make a PR on Overseerr to mentioning about the blacklist idea IF the feature request does not exist in the their repo

Seems like TMDB does have something for that in their api:
https://www.themoviedb.org/talk/606da6c698f1f10029694d78
Not by tags but actually by country & age ratings for both movies and TV-Shows ...

We already use the include_adult parameter as false.

parallel topic / feature request @ overseer: https://github.com/sct/overseerr/issues/3533
From this discussion it seems like TMDB does have something for that in their api:
https://www.themoviedb.org/talk/606da6c698f1f10029694d78
Quickly looking up the API reference for /discover-movie there seem to be parameters for that too ... e.g. include_adult or certification_country

We already have include_adult as false. But not everything is properly tagged on tmdb thus it passes by. This applies to certification as well.

I know this is not necessarily a perfect solution, but it could be something to consider. Is there a chance that we could set a maximum rating (ex PG-13), and it will only show results that are under that rating? I think it could cause accidental over blocking, as some movies could be rated R because of violence instead of sexual acts.

We are already blacklisting adult tags. Like I said a lot of tmdb adult movies (especially foreign ones) are MISSING that adult tags so a lot still gets through (ref: https://discord.com/channels/783137440809746482/1077244770012901486/1077291218989502565).
The way it can be filtered through the TMDB api is using tags like these:
Which you can see are missing on some adult movies that bypasses the filter for example:
Here you can see that we already do filter adult content:
https://github.com/Fallenbagel/jellyseerr/blob/3fd016808bf92013537813c281867874ea1b8ae3/server/api/themoviedb/index.ts#L127
Or are you talking about manually blacklisting? Because if so user inputted filters are not supported yet but its in the works.

Any update on manually being able to filter tags?
screenshot for reference.

Any update on manually being able to filter tags?
screenshot for reference.

That would be a future enhancement to the blacklist feature we recently introduced.

Any update on manually being able to filter tags?
screenshot for reference.

That would be a future enhancement to the blacklist feature we recently introduced.

yes great addition! I was playing around with it but only single movies for now, correct? I just started using jellyseer coming from Omni. Very impressed with everything but especially the UI/X is sublime. Thanks for the hard work, shall I make a new feature request describing it? and link back to this issue as well?

yes great addition! I was playing around with it but only single movies for now, correct? I just started using jellyseer coming from Omni. Very impressed with everything but especially the UI/X is sublime. Thanks for the hard work, shall I make a new feature request describing it? and link back to this issue as well?

Yes only single item. If the feature request doesn't exist, yes please. So it's easier to track

Superseded by #1076


chore(pytest): move config to pyproject.toml

I've moved pytest's config from pytest.ini to pyproject.toml as that's where most configs are located these days, and it's also nicer to gather them in a single file instead of having one for each tool in my opinion.

Codecov Report

Merging #770 (7bcb093) into master (046327b) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
- Coverage   96.62%   96.21%   -0.42%
==========================================
  Files          41       41
  Lines        2930     2929       -1
==========================================
- Hits         2831     2818      -13
- Misses         99      111      +12

Flag
Coverage Δ

unittests
96.21% <ø> (-0.42%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

tests/test_tools.py
68.00% <0.00%> (-24.00%)
:arrow_down:

copier/tools.py
88.09% <0.00%> (-4.77%)
:arrow_down:

tests/conftest.py
90.90% <0.00%> (-4.55%)
:arrow_down:

copier/cli.py
96.47% <0.00%> (-1.18%)
:arrow_down:

copier/main.py
94.13% <0.00%> (-0.30%)
:arrow_down:

copier/user_data.py
93.66% <0.00%> (+0.42%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Installation issues with dependencies, when building from source

During the installation steps,
python3 setup.py install causes some installation errors within the package.
For example, opencv had to be seperately installed
using conda install -c menpo opencv
After which there were still inconsistencies with the scikit-image package.
PFA screenshots -

Updated the installation steps. Kindly check if they are working.

@StarkX18 is it working now?


allow appending ReadCNIConfiguration into the default CNI plugins

If CILIUM_CUSTOM_CNI_CONF = true, cni_install.sh will not generate the 05-cilium.conf. but cilium-agent will skip writing the ReadCNIConfiguration into WriteCNIConfigurationWhenReady, too.  We hope that cni_install.sh skips generating the file 05-cilium.conf but cilium-agent can write the ReadCNIConfiguration into WriteCNIConfigurationWhenReady ( In the previous version, cilium-agent will write the ReadCNIConfiguration when CILIUM_CUSTOM_CNI_CONF is true). here we change the logic, if opts.ReadCNIConfiguration is not empty, cilium-agent will generate the CNI conf.

if os.Getenv("CILIUM_CUSTOM_CNI_CONF") == "true" && opts.ReadCNIConfiguration == "" {
		return
	}

We have two our own CNI plugins, tnet.conf yyy-istio.conf.  They are managed by their applications. We hope cilium-agent can append ReadCNIConfiguration (the cilium CNI conf) into tnet.conf because it depends on tnet.conf.

ReadCNIConfiguration is not empty (tnet.conflist) ---> WriteCNIConfigurationChainingMode = false ---> write ReadCNIConfiguration directly into WriteCNIConfigurationWhenReady (net.conflist)

ReadCNIConfiguration (origin.conf) is not empty ---> WriteCNIConfigurationChainingMode = true ---> DefaultCNIConfiguration (tnet.conf)  is not empty and DefaultCNIConfiguration exists --> Insert ReadCNIConfiguration (origin.conf)  into DefaultCNIConfiguration (tnet.conf) and write it into WriteCNIConfigurationWhenReady (tnet.conflist)  --> final files under /etc/cni/net.d: tnet.conflist tnet.conf.cilium_bak yyy-istio.conf

ReadCNIConfiguration (origin.conf) is not empty ---> WriteCNIConfigurationChainingMode = true ---> DefaultCNIConfiguration is not empty but it doesn't exist ---> WriteCNIConfigurationWhenReady (tnet.conflist) exists --> Insert ReadCNIConfiguration (origin.conf)  into WriteCNIConfigurationWhenReady  (tnet.conflist)  (this is to silution cilium-agent restarting) --->   final files under /etc/cni/net.d: tnet.conflist tnet.conf.cilium_bak yyy-istio.conf

ReadCNIConfiguration  (origin.conf) is not empty ---> WriteCNIConfigurationChainingMode = true ---> DefaultCNIConfiguration is empty ---> WriteCNIConfigurationWhenReady (tnet.conflist)doesn't exist --> Read the default CNI plugin (tnet.conf because it is before yyy-istio.conf after sorting by name ) --->  Insert ReadCNIConfiguration (origin.conf) into the default CNI plugin tnet.conf  and write it into WriteCNIConfigurationWhenReady (tnet.conflist) --->   final files under /etc/cni/net.d: tnet.conflist tnet.conf.cilium_bak yyy-istio.conf

allow appending ReadCNIConfiguration into the default CNI plugins

@squeed I see that #22035 is to refactor the cni management part. Could you have a look at my proposal about the appending ReadCNIConfiguration into the existing CNI plugins like the aws plugins.  We want to the same function like mergeExistingAWSCNIConfig.  But we want it is more general.

I was reading the CNI chaining code, and I think this check also has to go; it requires that the network name be "generic-veth", which is obviously silly.
In reality, the mere presence of a RawPrevResult is sufficient.
Can you take care of this as a part of this PR too?

@sofat1989 do you have any update on this PR?

@sofat1989 Any plans to continue this PR?

@sofat1989 I think I've taken care of this in #24956 -- I'll close this for now, and feel free to reach out otherwise.


I built a site with Eleventy!

I finaly managed to create a first site with Eleventy, hosted on Netlify: https://precious-prana.com/
The source code is on Github: https://github.com/nhoizey/precious-prana.com/

@nhoizey Do you tell me what would like to show on the website description field?
title: Precious Prana
description: ...
source: https://github.com/nhoizey/precious-prana.com/
twitter: @nhoizey

@csakiistvan here is a description in English:

Precious Prana is a wellness community that allows active mothers to recharge their batteries, to know how to manage their energy and to achieve a balance between personal, professional and family life.

Thanks!

Thank you!


Disable UTs for Windows while stablizing it

Signed-off-by: Chang Liu<EMAIL_ADDRESS>Description
UTs are unstable on Windows.
Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation] Maintenance
Issues Resolved
https://github.com/opensearch-project/security-dashboards-plugin/issues/1195
Testing
UTs, ITs
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1202 (ba7f8a7) into main (b451cb2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1202   +/-   ##
=======================================
  Coverage   71.78%   71.78%
=======================================
  Files          88       88
  Lines        2027     2027
  Branches      269      269
=======================================
  Hits         1455     1455
  Misses        509      509
  Partials       63       63

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternied The open issue is in the PR description. Requiring an unstable workflow significantly slows down the PRs. The flaky workflow has to be re-run on multiple PRs, which are not right experience. I'd suggest to resolve the flaky tests before enabling the workflow.

@opensearch-project/security Are we good to temporarily disable UTs on Windows as it is flaky and needs re-trying on PRs.

https://github.com/orgs/opensearch-project/teams/security Are we good to temporarily disable UTs on Windows until it gets stablized as it is flaky and needs re-trying on PRs.

This doesn't feel right. The Windows platform is shipping in 2.4, disabling these tests opens shipping a platform build without knowing if its functional. Looking at the related issue there was only reported failure that seems network related, are there other issues?

@peternied BWC tests were disabled when they failed? How is this case different?

BWC tests were disabled when they failed?

They BWC tests in the security repository have not been disabled, they continue to run and fail, but they are not required to merge changes.  If you'd like to change the branch protections in this repository not to require windows tests to pass to merge I think that is a decent work around.  If you do so please create a follow up issue to reenable the protections once it has stabilized [1]

How is this case different?

Updating network timeouts or retries on the yarn client are tweaks than can be made in this repository without any outside parties - I recommend we do that.  The BWC failures in security are because of a problem in several repository, it cannot be resolved by our team/maintainers directly.
[1] https://github.com/opensearch-project/security/issues/2235

Thanks for the context!

I recommend we do that.

@peternied Would you mind taking on this as you have the most context on the UTs on Windoes platform?

@peternied Would you mind taking on this as you have the most context on the UTs on Windoes platform?

Thanks for your confidence but I cannot take this work on

@peternied Would you mind taking on this as you have the most context on the UTs on Windoes platform?

Thanks for your confidence but I cannot take this work on

The error could help narrow down the root cause. @peternied If no plan to fix this, then I don't see value to keep it run for now. It should be disabled until it gets stablized.
2022-11-03T04:08:57.2968807Z info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
2022-11-03T04:08:57.5331813Z info There appears to be trouble with your network connection. Retrying...
2022-11-03T04:10:18.3867635Z ERROR [bootstrap] failed:
2022-11-03T04:10:18.3870994Z ERROR Error: Command failed with exit code 1: C:\npm\prefix\node_modules\yarn\bin\yarn.js install --non-interactive
2022-11-03T04:10:18.3872060Z           at makeError (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:25150:11)
2022-11-03T04:10:18.3879284Z           at handlePromise (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:24085:26)
2022-11-03T04:10:18.3880256Z           at processTicksAndRejections (internal/process/task_queues.js:95:5)
2022-11-03T04:10:18.3881649Z           at async installInDir (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:23821:3)
2022-11-03T04:10:18.3883826Z           at async Project.installDependencies (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:14780:5)
2022-11-03T04:10:18.3890831Z           at async Object.run (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:9003:11)
2022-11-03T04:10:18.3892253Z           at async runCommand (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:57870:5)
2022-11-03T04:10:18.3895322Z           at async Module.run (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:263:3)

There are several maintainers on this project - maybe someone else can take this work on?  @RyanL1997 do you think you could look into the root causes / fixes?

There are several maintainers on this project - maybe someone else can take this work on? @RyanL1997 do you think you could look into the root causes / fixes?

@peternied community are looking forward to your ownership and taking responsibility. You are super, you can do it. Make community be proud of you.

According to the investigation I made on this issue, here is the output from my side:

I couldn't constantly reproduce this error.
This a connection issue on the github server. There is nothing we can do to make their connection more stable.
I'm also filling a issue for bug fix and enhancement request on github community to see if they can also offer some help. (see: https://github.com/orgs/community/discussions/38837)

However, I agree with that we can temporarily disable this test until we figure out a fix/enhancement.

@cliu123 Thanks for articulating the actual problem, and for opening the discussion thread on GH.
@peternied Thanks for insisting on that we don't disable tests because some connectivity is flaky. This feels like the right thing to do.
I think a possible way forward is to keep running these tests and retrying them and seeing if the transient connectivity issue goes away. It's annoying, but it could just be something on the network that someone is working on. If it doesn't go away, I would change the GHA to retry the entire job (I don't know how to do that), and otherwise ignore the job failures on windows only, rather than disabling the tests. @cliu123 @peternied, what do you think? would the latter be acceptable?
@seraphjiang I suggest deleting your comment and letting this issue to be discussed by the contributors and maintainers of this project.

@dblock I've already changed the branch protection policy. Merging PR no longer requires UTs on Windows to pass now. The workflow fails on most of PRs. As a maintainer, I would rather not to keep a flaky check running and merge things with failures. This would not be the best way to earn trust or confidence on quality from the community. But this is a team decision, if that's what we want to do, I'll leave it as is.

I've discussed with @dblock offline. He no longer has objections on this and will let the maintainers move forward with this.

created an issue to track fix and re-enabling separately: https://github.com/opensearch-project/security-dashboards-plugin/issues/1211

created an issue to track fix and re-enabling separately: https://github.com/opensearch-project/security-dashboards-plugin/issues/1211


Unable to run tasks

Issue Type: Bug
Not sure how to reproduce, but I'm unable to run basically any tasks from VSCode. I have tried the insiders build as well. The errors most often seen are:
The terminal process command 'C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command echo testing' failed to launch (exit code: {2});
and
The terminal process terminated with exit code: {0}
VS Code version: Code - Insiders 1.43.0-insider (3943d614597f9f7c384846613d417e97ea6d5ab4, 2020-03-03T21:20:08.233Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz (8 x 4200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.96GB (4.64GB free)

Process Argv
--folder-uri file:///src/jessefuckingbaker.visualstudio.com/GuitarScraper/scraper-processor

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

path-intellisense
chr
1.4.2

gitignore
cod
0.6.0

bracket-pair-colorizer-2
Coe
0.0.29

git-project-manager
fel
1.7.1

camelcasenavigation
map
1.1.1

vscode-azurefunctions
ms-
0.21.0

remote-containers
ms-
0.106.0

remote-wsl
ms-
0.42.3

azure-account
ms-
0.8.8

csharp
ms-
1.21.12

vsliveshare
ms-
1.0.1653

material-icon-theme
PKi
4.0.1

quicktype
qui
12.0.46

UPDATE:
Just tested the same task against the same version with all extensions disabled, same results.

Please share your tasks.json and all settings.json.

Please share your tasks.json and all settings.json.

 I don't see the "echo testing" task you mention. Can you share that? Also, can you try disabling all extensions and see if it still occurs?

Nothing suspicious looking there. I don't see the "echo testing" task you mention. Can you share that? Also, can you try disabling all extensions and see if it still occurs?

Sorry, not getting email notifications here for some reason. Yea, I'll try that tonight. As for the echo testing failure, I removed it after it didn't work.
{
      "type": "shell",
      "command": "echo testing",
      "label": "testing"
}

Thanks for the additional testing. I still can't get a repro though. In the integrated terminal can you try the following:

launch cmd (just run cmd)
run C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command echo testing. This is the command that the task is running.

What is the output?

What is the output?

testing

@Tyriar Do you have any ideas about what could be going on here? @ronniehicks is getting this error when running a very simple task:
The terminal process command 'C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command echo testing' failed to launch (exit code: {2})
The command doesn't require that anything be on the path: C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command echo testing
And the exit code looks to be bogus and I don't understand why that could be happening based on the code here:
https://github.com/microsoft/vscode/blob/2502f01cb4b12a872c8103f56f43684b6653c267/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts#L1058-L1058

After updating to 1.43 I am also unable to run any shell tasks. Instead it just opens a shell, when exiting the shell it "finishes" the task.
Settings for my integrated terminal:
    "terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\cmd.exe",
    "terminal.integrated.fontFamily": "Fira Mono",
    "terminal.integrated.shellArgs.windows": [
        "/k",
        "C:\\app\\CMDer\\vsCode.bat"
    ],

The task I tested to run:
        {
            "label": "echo",
            "type": "shell",
            "command": "echo Hello",
            "group": "build",
            "problemMatcher": [],
            "options": {
                "shell": {
                    "executable": "C:\\WINDOWS\\System32\\cmd.exe",
                    "args": []
                }
            }
        }

I tried to specify the shell without any commands in the "option" setting, as I am using the CMDer init batchfile in my standard VS Code shell settings. But that didn't help either.
What I see in the shell opened by the task:
> Executing task: echo Hello <

Microsoft Windows [Version 10.0.17763.1039]
(c) 2018 Microsoft Corporation. Alle Rechte vorbehalten.

C:\Users\RJI1SGM\Documents\140_Skripte\testfolder>dir
 Datenträger in Laufwerk C: ist Windows
 Volumeseriennummer: 6C74-AE1F

 Verzeichnis von C:\Users\RJI1SGM\Documents\140_Skripte\testfolder

10.03.2020  15:42    <DIR>          .
10.03.2020  15:42    <DIR>          ..
10.03.2020  15:42    <DIR>          .vscode
10.03.2020  15:42                52 test.py
               1 Datei(en),             52 Bytes
               3 Verzeichnis(se), 118.185.291.776 Bytes frei

C:\Users\RJI1SGM\Documents\140_Skripte\testfolder>exit

Terminal will be reused by tasks, press any key to close it.

@Joinyy in the future, please open a new issue if it isn't 100% clear that your issue is the same.
Your task also doesn't work in 1.42 because you don't have any args here:
            "options": {
                "shell": {
                    "executable": "C:\\WINDOWS\\System32\\cmd.exe",
                    "args": []
                }
            }

And it doesn't work without the options because you specify args here and they conflict with the args that tasks automatically uses:
    "terminal.integrated.shellArgs.windows": [
        "/k",
        "C:\\app\\CMDer\\vsCode.bat"
    ],

I recommend removing the options from your task and setting "terminal.integrated.automationShell.windows": "cmd.exe"

@alexr00 thanks for your recommendation, I'll take a closer look at the issues in the future.
The tasks are working now for me, so something might have changed from 1.42 on as you mentionned.

These errors are often related to anti-virus software blocking the terminal from being created. Things you can do:

Try set/unset the windowsEnableConpty setting
Try trace logging to see if that gives any useful information https://github.com/microsoft/vscode/wiki/Terminal-Issues
Check devtools for errors

 "gitProjectManager.baseProjectsFolders": [
        "~/src",
        "/src"
    ],

After a little more digging I discovered the issue, and I believe it's been impacting my OmniSharp experience as well. I use Git Project Manager to quickly switch between projects and since I work across Mac and Windows I put both OS locations in the list. The second one, /src is for windows and apparently VSCode does not like that path for relative pathing. When I switch it to C:/src for the windows path it works fine.
Thanks for the help all! Let me know if you're interested in any of the logs or anything else.


Fix orthographic translations and zoom

This should make Camera3D(scene, projectiontype=Orthographic) pixel perfect in terms of translations. Also fixes the initial zoom level.
Fix https://github.com/JuliaPlots/Makie.jl/issues/1142.

I also added a shift_lookat variant for Orthographic projections now, so this should close #1157. Though I think it would be good to disable that for perspective cameras...

Oh yea, this would also close #1144 now I think?

Oh yea, this would also close #1144 now I think?

Yeah, sure !

@SimonDanisch, do you mind if I merge this ?

Seems like a good idea... Have you tested this locally?

Seems like a good idea... Have you tested this locally?

Yes, it does fix https://github.com/JuliaPlots/Makie.jl/issues/1142.

For NEWS.md:

fixed initial zoom level of orthographic 3d camera
adjust orthographic translations to follow cursor movements exactly
fix cursor focused zooming for orthographic cameras


detail-view-listings-WIP

To Do:

Mobile Styling
Reviews
Configure click outside image-viewer boundary
Fill images in React slider

obsolete


refreshing OVAL definitions taking longer

hi,
while updating the new oval data: the refreshing taking too long. Is this an issue? How long does it take to refresh the definitions normally?

The latest version of goval-dict is ultra fast, so update it and try it.

pulled the latest master branch and it worked. Thanks


transitioning between stages

In the phases-overhaul branch, the only way to manipulate a player's stage is the setActivePlayers event.
For example, to set the current player's stage to 'A', you can do:
ctx.events.setActivePlayers({ currentPlayer: 'A' });

However, this has two problems:

It clobbers the state in activePlayers (if some other player was in there, they would be removed).

It cannot set the stage of the player that made the move (it only works on the "current player").

We could change the semantics of setActivePlayers to overcome these, or split it into multiple events that do different things.

IIRC isn't there the possibility to pass a value directly?
setActivePlayers({
  value: { [playerID]: 'stage' }
})

That said, obvious candidates would include:

addActivePlayer
removeActivePlayer

(Side note: keep meaning to write a test for this, but I think I saw that setActivePlayers({ others: 'stage’ }) was preserving currentPlayer if it was already in activePlayers)

Another idea that's been growing on me is to have a simple endStage event that's analogous to endPhase.
All this does is that it removes the player from activePlayers.
However, if the stage config contains a next, or if next is passed to endStage, then we just take the player to that stage instead. This is exactly how phases work and I think having the same concept for stages will reduce the cognitive overhead of having to grok different APIs.
I think if we arrange things so that we just have endTurn, endPhase, endStage and setActivePlayers, that would be a nice elegant API.

Now that I’m working on moveLimit (#452), I think setStage would probably also need a way to set a moveLimit, perhaps via a second options argument:
setStage('main', { moveLimit: 2 })

Otherwise users would only be able to set move limits inside setActivePlayers.

Oh, I think that's perfectly ok.
Users can use setStage just to move between stages and setActivePlayers if
they want the more advanced options.
On Wed, Sep 11, 2019, 12:00 AM Chris Swithinbank<EMAIL_ADDRESS>wrote:

Now that I’m working on moveLimit (#452
https://github.com/nicolodavis/boardgame.io/pull/452), I think setStage
would probably also need a way to set a moveLimit, perhaps via a second
options argument:
setStage('main', { moveLimit: 2 })
Otherwise users would only be able to set move limits inside
setActivePlayers.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nicolodavis/boardgame.io/issues/447?email_source=notifications&email_token=AABZULRMNYDLDXGJ3WZLZA3QI7ABFA5CNFSM4IRLKFH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6LTY6A#issuecomment-530005112,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABZULXUFO7HN5EG4K4VX3LQI7ABFANCNFSM4IRLKFHQ
.

I think of setStage as a simple "get me to this other stage".  I'd prefer to have it as minimal as possible.  I'm open to adding more options to it in the future, but let's wait and see how people use the new API first.
setActivePlayers can be the swiss-army knife with all the fancy options.

@nicolodavis Totally understand.
I’ve finished work on moveLimit in #452. My concern was that with this implementation we reset move counts when calling setActivePlayers, so a scenario where one player’s stage changes but the others stay the same would not currently support move limits for that one player. Otherwise, you’d have to use setActivePlayers and do something like moveLimit - numMoves for each other player, which would be pretty complicated.

An example of just how complicated that would be:
const turn = {
  activePlayers: {
    all: true,
    moveLimit: 4,
  },

  moves: {
    move: (G, ctx) => {},

    changeStage: (G, ctx) => {
      ctx.events.setActivePlayers({
        value: {
          ...ctx.activePlayers,
          [ctx.playerID]: 'newStage',
        },
        moveLimit: {
          value: {
            ...Object.keys(ctx._activePlayersMoveLimit).reduce((obj, key) => {
              obj[key] =
                ctx._activePlayersMoveLimit[key] -
                ctx._activePlayersNumMoves[key];
              return obj;
            }, {}),
            [ctx.playerID]: 2,
          },
        },
      });
    },
  },
};


Spanish options

Hi! i am starting to use the library, but i want to work with spanish configurations. Is there a way to do that? Which is the best configuration?
Much much thanks in advance.

To add a little more context to the problem, there are special spanish characters that the model is not registering. For example the characters: ñ, á, é, í...

Hi, Pix2Text uses the EasyOCR text recognition engine for Spanish language support. I cannot add recognition for other Spanish characters on top of it. Sorry. You can consider replacing EasyOCR with another Spanish OCR engine.


assert_regex_in_logs task

Abstract
In some scenarios it makes sense to check the log files for certain output (e.g. the PFS support is enabled). Currently this can only be checked implicitely.
Specification
Add a new assert_regex_in_logs task to the SP that can match a certain regex on the log output of a certain or all nodes.

@palango Is it still needed? What is the problem you are trying to solve?

The idea was to add a generic assertion method, so we don't have to add a new assertion task every time we want to test something new.
I think the idea might still make sense, but it's not urgent as far as I understand.