Limit urlib3's version to avoid requests 2.18.4's dependency

Currently, Installing this package has success, but kaggle command is failed by VersionConflict. (log below)
urllib3 1.23.0 has released in 2018-06-04.
But requests 2.18.4(latest) is limited urllib3's version to less than 1.23.0. (source)
This limitation has already changed in requests. (source)
But this change have not released in pypi yet.
For this reason, in this PR, I propose to limit urllib3's version as interim measures.
$ pip --no-cache-dir install kaggle
Collecting kaggle
  Downloading https://files.pythonhosted.org/packages/46/79/3630c8a7c96c382a2c2e65445c1291ac12e36e868e5c390f348b1d4d6171/kaggle-<IP_ADDRESS>.tar.gz
Collecting urllib3>=1.15 (from kaggle)
  Downloading https://files.pythonhosted.org/packages/bd/c9/6fdd990019071a4a32a5e7cb78a1d92c53851ef4f56f62a3486e6a7d8ffb/urllib3-1.23-py2.py3-none-any.whl (133kB)
    100% |████████████████████████████████| 143kB 956kB/s
Collecting six>=1.10 (from kaggle)
  Downloading https://files.pythonhosted.org/packages/67/4b/141a581104b1f6397bfa78ac9d43d8ad29a7ca43ea90a2d863fe3056e86a/six-1.11.0-py2.py3-none-any.whl
Collecting certifi (from kaggle)
  Downloading https://files.pythonhosted.org/packages/7c/e6/92ad559b7192d846975fc916b65f667c7b8c3a32bea7372340bfe9a15fa5/certifi-2018.4.16-py2.py3-none-any.whl (150kB)
    100% |████████████████████████████████| 153kB 3.8MB/s
Collecting python-dateutil (from kaggle)
  Downloading https://files.pythonhosted.org/packages/cf/f5/af2b09c957ace60dcfac112b669c45c8c97e32f94aa8b56da4c6d1682825/python_dateutil-2.7.3-py2.py3-none-any.whl (211kB)
    100% |████████████████████████████████| 215kB 1.1MB/s
Collecting requests (from kaggle)
  Downloading https://files.pythonhosted.org/packages/49/df/50aa1999ab9bde74656c2919d9c0c085fd2b3775fd3eca826012bef76d8c/requests-2.18.4-py2.py3-none-any.whl (88kB)
    100% |████████████████████████████████| 92kB 9.9MB/s
Collecting tqdm (from kaggle)
  Downloading https://files.pythonhosted.org/packages/93/24/6ab1df969db228aed36a648a8959d1027099ce45fad67532b9673d533318/tqdm-4.23.4-py2.py3-none-any.whl (42kB)
    100% |████████████████████████████████| 51kB 18.5MB/s
Collecting idna<2.7,>=2.5 (from requests->kaggle)
  Downloading https://files.pythonhosted.org/packages/27/cc/6dd9a3869f15c2edfab863b992838277279ce92663d334df9ecf5106f5c6/idna-2.6-py2.py3-none-any.whl (56kB)
    100% |████████████████████████████████| 61kB 15.1MB/s
Collecting chardet<3.1.0,>=3.0.2 (from requests->kaggle)
  Downloading https://files.pythonhosted.org/packages/bc/a9/01ffebfb562e4274b6487b4bb1ddec7ca55ec7510b22e4c51f14098443b8/chardet-3.0.4-py2.py3-none-any.whl (133kB)
    100% |████████████████████████████████| 143kB 7.3MB/s
requests 2.18.4 has requirement urllib3<1.23,>=1.21.1, but you'll have urllib3 1.23 which is incompatible.
Installing collected packages: urllib3, six, certifi, python-dateutil, idna, chardet, requests, tqdm, kaggle
  Running setup.py install for kaggle ... done
Successfully installed certifi-2018.4.16 chardet-3.0.4 idna-2.6 kaggle-<IP_ADDRESS> python-dateutil-2.7.3 requests-2.18.4 six-1.11.0 tqdm-4.23.4 urllib3-1.23
$ kaggle competiton
Traceback (most recent call last):
  File "/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages/pkg_resources/__init__.py", line 659, in _build_master
    ws.require(__requires__)
  File "/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages/pkg_resources/__init__.py", line 967, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages/pkg_resources/__init__.py", line 858, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (urllib3 1.23 (/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages), Requirement.parse('urllib3<1.23,>=1.21.1'), {'requests'})

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/yoshifumi.seki/workspace/env/bin/kaggle", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3017, in <module>
    @_call_aside
  File "/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3003, in _call_aside
    f(*args, **kwargs)
  File "/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages/pkg_resources/__init__.py", line 3030, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages/pkg_resources/__init__.py", line 661, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages/pkg_resources/__init__.py", line 674, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages/pkg_resources/__init__.py", line 858, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (urllib3 1.23 (/Users/yoshifumi.seki/workspace/env/lib/python3.6/site-packages), Requirement.parse('urllib3<1.23,>=1.21.1'), {'requests'})

Do you mind adding an explanatory comment so that I remember to remove it later?  Thanks!

Thank you for reviewing. I has finished adding comment.
When remove this restriction according to comment, this problem will occur again when upgrade urllib3.
So this PR is interim measures, I think that's enough.
If would you like, freeze version of requests and urllib3 for stabilization, or, I create issue to discuss this problem.

Merged and released as 1..3.10.  Thanks!

I think freezing the versions makes sense.  I come from Java and Maven land where that's the norm.  Feel free to file an issue for tracking purposes - I'll try to get to it this week.


Can O' Spam: Watch trypureeasecbdgummies

Can O' Spam requests the watch of the watch_keyword trypureeasecbdgummies. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

trypureeasecbdgummies has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


[Feature] Combine time dropdowns on dashboard

Currently, a drop down appears when results are shown that has the options "last 24h", "last week", and "last month". Especially with the split to separate upload and download, I suggest that it would be more reasonable that all four graphs (upload, download, ping, jitter) are controlled by only one dropdown, instead of each having their own time settings. Currently, if I want to view my last week of results, I have to change the dropdown 4 times. I do understand that they are different graphs but I think it would be more intuitive if they shared an X-axis.

#1252 😉


cert_validator: Add and populate the local address in extra validation context

Add and populate the local address in extra validation context so that custom cert_validator extension can use it if needed.
This is only needed additional parameter at the moment and It is added as an optional field.

/retest

/assign @danzh1989

/assign @danzh2010

/retest

/retest

/retest

/retest

/assign @yanavlasov

/retest

Why do you need the local address to verify the remote certificate?
What will this be used for? There isn't any usage of this data in the PR.
You should add an integration test to validate that this works as expected.

It is used for mTLS in our private extension.  Local address is required in the API communicating to the remote validation server. We will add the integration test for it internally and I added the comment here to clarify it a bit.

+1 for a unit test for the self address you added.

+1 for a unit test for the self address you added.

I am wondering do you have the pointer to existing test example that will hit this function? I checked context_impl_test before. Whole function will not be hit.

timed_cert_validator

Thanks for example. Yes, that is also extension specific test, which i planned to test it in our extension test internally.

You can add a test cert validator to check the self address and config it for ssl_socket_test or some e2e tests. I just realize that cert validation logic is hard to test in unit test by the nature of boring SSL. An example will be: test/extensions/transport_sockets/tls/cert_validator/timed_cert_validator.h and its usage in integration tests

Thanks for example. Yes, that is also extension specific test, which i planned to test it in our extension test internally.

You probably also want a basic test in OSS code to prevent someone cleaning up unused code in the future.

/retest

/retest

@ggreenway and @danzh2010 . We have validated this local address usage in our internal extension.
Existing ssl_integration_test has already hit this path multiple times. In other words, it is a safe change with test covered by ssl_integration_test.  I think it is a bit overkill to add a test validator extension just for a few lines of change here that are safe. But I definitely can add one if that is strongly preferred. If so, I hope to add it in a followup pr so our internal development can be unblocked.
Please let me know what do you think.

/retest

/retest

I think I'm with @danzh2010 on adding the test. It is odd to add new functionality without any test coverage. It should at least validate that the plumbing is working correctly, and the value is observed in the extension.
/wait-any

I think I'm with @danzh2010 on adding the test. It is odd to add new functionality without any test coverage. It should at least validate that the plumbing is working correctly, and the value is observed in the extension.
/wait-any

The plumbing and the value has been already validated in our internal extension's integration test.. Existing ssl_integration_test also validate that this PR is safe. The change here is in callback that is deeply nested in the code which i think integration test with custom extension or a whole new extension is only way to validate it, which I think it is overkill here
I am ok with adding the test validator if it is strongly preferred. But I hope to do it in a follow-up PR to unblock

Moreover, IMHO, the value of integration test that requires whole test validator is quite limited.

The only thing we can probably test there is this localAddress is available to be used. i.e., it is not nullptr.
We can not test the usage of this local address because there is no validator in OSS that use it and there is no remote validation server in OSS requires it.

Regarding 1: I can change the code to something like below to further prove its accessibility, which i confirmed with ssl_integration_test . But i chosen a conservative approach because i feel it is a bit disruptive to existing code.
  ASSERT(callbacks != nullptr);
  ASSERT(callbacks->connection().connectionInfoProvider().localAddress() != nullptr);

If you feel the code example above is good or any other testing value can be added with a dummy test validator, please let me know.

@yanavlasov @danzh2010 @ggreenway , i have added the test in ssl_socket_test to validate the access method that is used in caller site.  Plumbing here is simple as function argument passing. So I think callee site/plumbing is fine as long as the argument passed is available and accessible on the caller site.
PTAL. Thanks

Can you add checks for expected context to the test/extensions/transport_sockets/tls/cert_validator/timed_cert_validator.cc ?
/wait-any

please hold off pushing CI for the next few hours while we push through release CI

/retest

/retest

/retest

It was my mistake that i didn't realized timed_cert_validator is a test validator until I saw its path from test/extension. (name of the file is not that obvious). I have added the integration test to validate the local address. @danzh2010 @yanavlasov @ggreenway  PTAL. Thanks!

@ggreenway gentle ping; the other two reviewers have approved.


protect against wrapped upgrade error leading to panic

Summary
It is possible that ChanUpgradeTry could return a wrapped upgrade error which would be returned as true in IsUpgradeError but panic when being casted to an UpgradeError. This is not an immediate concern as we have verified this will never occur and even if this was changed, the tests should fail, but as a way to future proof maintenance, we may restructure the code slightly so we don't have the possibility to panic if we have been returned a wrapped upgrade error.
Discussed during our internal security audit

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

Sure @hoangdv2429! Thanks for picking this up, I'll assign it to you.


Request for a callback with information regarding the chosen share channel.

Use case
I would like to get the channel that was selected to share, back to the flutter application after using the share package call.
Using mixpanel analytics, I need to report the app/channel that was used to share, in order for my client to understand how the users are sharing info with the app.
Proposal
It would be handy to have the name of the app ie. 'Email', 'Whatsapp' etc, returned as a string, in a callback after sharing.

Hi @shaun0203
Can you please give us some reference that is already possible to do on Android and iOS? Some examples
Thank you

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


CASMINST-4709 export token for ntp script

Signed-off-by: Jacob Salmela<EMAIL_ADDRESS>Summary and Scope
Adds an explicit step to export the token for use in csm_ntp.py
Issues and Related PRs

Resolves CASMINST-4709

Testing
Tested on:

#redbull

Test description:
ncn-s004:~ # TOKEN=token
ncn-s004:~ # /srv/cray/scripts/common/chrony/csm_ntp.py
You must set BSS TOKEN environment variable
ncn-s004:~ # export TOKEN
ncn-s004:~ # /srv/cray/scripts/common/chrony/csm_ntp.py
Chrony configuration created
Problematic config found: /etc/chrony.d/cray.conf.dist
Problematic config found: /etc/chrony.d/pool.conf
Restarted chronyd

Risks and Mitigations
Low.
Pull Request Checklist

[ ] Version number(s) incremented, if applicable
[ ] Copyrights updated
[ ] License file intact
[ ] Target branch correct
[ ] CHANGELOG.md updated
[ ] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

Changes from the 1.2 PR implemented https://github.com/Cray-HPE/docs-csm/pull/1705


Make base glob configurable via coverageBaseDir

Rational
On big workspaces (e.g. 12k directories, 74k files) recursive glob lookup ** is very time consuming. Currently there is no way to avoid it via configuration options.
manualCoverageFilePaths is the only option, however it eliminates any kind of glob lookup, which is not desired.
Change
Introduce coverageBaseDir that allows users to fully customize lookup glob for coverage files
It defaults to **, so existing behavior is not going to change.

Converted to draft. #270 should go in first

@ryanluker this PR is ready for review

@ryanluker Do you have any updates on the 2.6.0 release date?

@amatosov-rbx I was hoping the last item from the milestone would get in but if it isn't by Sunday I will just go away with a release. https://github.com/ryanluker/vscode-coverage-gutters/milestone/31

@amatosov-rbx 2.6.0 should be out now! thanks again for the effort in adding / fixing this 😁 .
https://github.com/ryanluker/vscode-coverage-gutters/releases/tag/v2.6.0

@ryanluker Thanks for getting the release out and quick feedback on fixes and additions =)


How to turn off on_kubernetes_any_resource_all_changes trigger that sends messages to telegram in every pod creation.

subj, i found it was declared in ConfigLoader as internal trigger.
Notifications on every pod creation/deletion is redudant in our logic, or we just want to separate telegram alerts for release notifications and alerts. it would be helpful to do that.

Thank you for reporting this @IdeoG
Do you have any customPlaybooks configured?
If so, can you please share your customPlaybooks section ? (Please make sure not to share any sensitive value)

builtinPlaybooks:
- triggers:
    - on_kubernetes_warning_event:
        namespace_prefix: jupyterhub
  actions:
    - resource_babysitter: {}

so, it's a part of my values.yaml config file.

Oh, i see, suddenly, i used trainers.values.yaml filename, so i renamed it to values.yaml and hope it will help. Thank you!

Hmm, it didn't work. Pod created/deleted events are coming to my tg group. Is there any ideas

Can you please share your generated_values.yaml file (without the sensitive values, if there are any)

builtinPlaybooks:
- triggers:
    - on_kubernetes_warning_event:
        namespace_prefix: jupyterhub
  actions:
    - resource_babysitter: {}

globalConfig:
  signing_key: ...
  account_id: 631b58c8-d88d-4c63-b7c8-94e0be313823
sinksConfig:
- telegram_sink:
    name: personal_telegram sink
    bot_token: ...
    chat_id: -1001758586891
disableCloudRouting: true
runner:
  sendAdditionalTelemetry: false

Can you explain when you'd like to get a notification on telegram?
For example, when a deployment is created, or when a statefulset is changed?

Sure! My use cases:

Deployment update was started and finished
Deployment was created and creation was successful
Any k8s object warnings from namespace
Pod errors, such as OomKiller, Loopbackoff

Thank you for your help!

Thank you
In general, when adding new playbooks, you should use the customPlaybooks value, and not the builtinPlaybooks
Specifically, regarding your use cases:

Deployment update

- triggers:
  - on_deployment_update: {}
  actions:
  - resource_babysitter:
      fields_to_monitor:
      - spec

This will send a change event, whenever the deployment spec change.

Deployment creation

- triggers:
  - on_deployment_create: {}
  actions:
  - create_finding:
      aggregation_key: "Deployment Created"
      severity: INFO
      title: "New deployment created"
      description: "New deployment: name - $name on namespace - $namespace"

k8s warnings from namespace
This might be too spammy, but if you do want it, this is the playbook you need:

- triggers:
  - on_kubernetes_warning_event_create:
      exclude: ["NodeSysctlChange"]
  actions:
  - event_report: {}
  - event_resource_events: {}

Pod crash loops, oom kills etc are configured by default. You don't need to modify anything

So, your values.yaml file should have:
customPlaybooks:
- triggers:
  - on_deployment_update: {}
  actions:
  - resource_babysitter:
      fields_to_monitor:
      - spec

- triggers:
  - on_deployment_create: {}
  actions:
  - create_finding:
      aggregation_key: "Deployment Created"
      severity: INFO
      title: "New deployment created"
      description: "New deployment: name - $name on namespace - $namespace"

- triggers:
  - on_kubernetes_warning_event_create:
      exclude: ["NodeSysctlChange"]
  actions:
  - event_report: {}
  - event_resource_events: {}

Please let us know if you have additional questions


[sdk] Update to Gecko SDK 3.2

This PR updates the sdk_support submodule to the Gecko SDK 3.2 release. It also updates the openthread submodule
Testing
I was able to form a network using ot-cli-ftd on two brd4161a boards and pinged both directions successfully.
The sleepy-demo also works as LEDs work as expected and the MTD is sleeping properly

@googlebot I consent.

@googlebot I consent.

LGTM

LGTM

@googlebot I consent.

@jwhui This should be ready to merge after CI passes

@romacdon , would you like to review this PR? You are tagged as a reviewer :)

@romacdon , would you like to review this PR? You are tagged as a reviewer :)

Hi @jwhui , @romacdon may be tied up with other tasks. He had asked us to proceed with the merge if things look okay. He will review as soon as he has bandwidth (even if it is post-merge).

@lmnotran would it be possible to include a link to the release notes for major updates like this in the future? hugely helpful to understand what's changing for those of us that don't love Simplicty Studio. Or is this somewhere in the contents?
https://www.silabs.com/documents/public/release-notes/open-thread-release-notes-<IP_ADDRESS>.pdf


Declaration file non-exported types are importable

TypeScript Version:  3.9.2, 3.8.3, 3.1.6 3.0.3 (and likely more)

Search Terms:
declaration file export, non-exported types,  implicit export, dts, .d.ts, es-modules declaration
Code
module.d.ts
export declare const explicitlyExported: {};
declare const implicitlyExported: {};

importer.d.ts
import { implicitlyExported } from "./module"; // no error, is usable import

Expected behavior:
Error: Module '"./module"' has no exported member 'implicitlyExported'.
Actual behavior:
No error.
Even thought it wasn't exported, implicitlyExported is available for import.
Playground Link:
n/a (declaration file issue)
Related Issues:

As far as we can tell, this is how TS currently decides which mode to use for declaration files. Is this intended? What is the use case for implicit exports / mixed mode?

has export declaration
no export declaration

has >= 1 import or export statement
ESM-style
implicit exports (mixed mode)

no import or export statements
ESM-style
ambient

Yeah, this is unfortunately... by design... if you add export {}, you'll get correct private-ness. We could opt to change this, but it'd definitely be a breaking change that walks back something that we've been calling "working as intended" for a long time.

Thanks @weswigham

Are there any plans on changing this behavior, maybe in a major release some time?

No


Do not get workflow execution from database when shard is closed

What changed?
Do not get workflow execution from database when shard is closed

Why?
When a shard is closed, we should stop all the operations to the database from that shard. Read operation was allowed because it is safe. But since we do a checksum validation after GetWorkflowExecution from database, a false negative result might be returned from the validation if we allow reading data after a shard is closed.

How did you test it?
unit test

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 018df756-1f81-4f0c-b823-e66fcb0dee3f
Details

7 of 7 (100.0%)  changed or added relevant lines in 3 files are covered.
95 unchanged lines in 16 files lost coverage.
Overall coverage decreased (-0.02%) to 62.881%

Files with Coverage Reduction
New Missed Lines
%

common/task/weighted_round_robin_task_scheduler.go
1
89.05%

client/history/client.go
2
38.1%

common/task/fifo_task_scheduler.go
2
84.54%

common/util.go
2
91.69%

service/history/execution/mutable_state_util.go
2
37.63%

service/history/handler/handler.go
2
49.59%

common/persistence/nosql/nosqlplugin/cassandra/workflow.go
3
61.93%

service/matching/taskListManager.go
3
79.7%

service/history/task/transfer_standby_task_executor.go
4
86.6%

service/history/task/fetcher.go
5
85.57%

Totals

Change from base Build 018df723-a9b1-4bc8-8fcb-531607223dca:
-0.02%

Covered Lines:
92945

Relevant Lines:
147811

💛  - Coveralls


JavaScript

JavaScript
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

Completed JS merge to PSG application.


submodule coremark. clean git status after a build

I'm working on building a firesim workload for this and got dirty git status after running a build.
This PR:

submodules coremark with the correct HASH
changes the build to point to the riscv64 dir rather than copying it
moves the coremark.riscv dir back out to the top

Can you add to the README that you need to run a git submodule update --init. Then this lgtm


Invoker auto-tune

This PR updates the generic search to use invokers instead of run and measure.
All relevant solvers are updated to support the new way of things, which has led to significant removal of duplicated code.
Things not done yet:

Fix fused conv 1x1u: at the moment it will have some build parameters duplicated when built for running and probably doesn't use invoker in the actual run.
Rigorous testing.

@alexandraBara Hey there, here is the PR.
I don't think I'll change anything related to generic_search and stuff from now on.
Unless I'll find bugs in the implementation while testing, but I don't think there would be any nontrivial changes.

@alexandraBara Hey there, here is the PR draft.
I don't think I'll change anything related to generic_search and stuff from now on.
Unless I'll find bugs in the implementation while testing, but I don't think there would be any nontrivial changes.

@DrizztDoUrden  Sounds good, ill use your branch for my changes.

@pfultz2 @DrizztDoUrden I am not fully aware of what you are discussing here, but perhaps it is worth to merge PR #212 here. It adds a lot of const stuff.

We are discussing new code from this PR.

Obviously ;)

More testing is in progress, but mostly the PR is finished.

During the time we developed Invokers, changes have occurred: some iGemm WrW solvers that use tuning appeared. Therefore, we need to pause this PR until Invokers support for iGemm WrW implemented.
@DrizztDoUrden is switching to implementation of Invokers for iGemm WrW right now.

@DrizztDoUrden Merge conflicts ;((

@DrizztDoUrden what is going on with this PR?

Not much at the moment, I need #233 to get merged to finish this. But the rest is simple.

@DrizztDoUrden Could you please rebase this PR.

It looks like my ritual dances have made test god happy, so this PR is mostly ready. I am going to finish some additional manual testing tomorrow or on Thursday.

@DrizztDoUrden Good news!
Please let us know if you need some assistance with testing. Perhaps you can ask @alexandraBara as she is tinkering with tuning right now (I guess) and might have some good tests on hand.

Well, I have kind of manually check all solvers (I hope) to be good at tuning.

Well, I have kind of manually checked all solvers (I hope I haven't missed something) to be good at tuning.

I can run a little tunning sesh with this branch if necessary

I can run a little tunning sesh with this branch if necessary

@alexandraBara That would be great, thanks a lot!

@DrizztDoUrden merge conflicts.
@alexandraBara have you completed the tuning sesh?

@DrizztDoUrden merge conflicts.
@alexandraBara have you completed the tuning sesh?

Yes, i emailed my findings to Vasili and Artem.

Looks like there is exhaustive search in wrw Winograd too. I'll make a PR with that batch of invokers soon.

All please review.

I don't see any failures on my tests, including Winograd wrw, which was the last one to fail due to being not implemented.

@alexandraBara If you have any questions about the changes, feel free to ask me anywhere you would feel comfortable.

@atamazov does this have your seal of approval?

@daniellowell Let me make a quick check tomorrow morning.

The check is not that quick... but almost done

This now blocks Tuna and iGEMM development.

@daniellowell Let's merge this?


Python API | Option to add username, secret and key

What is the current behavior?
We consume DG in our production. I have been provided with username, key and secret for testing some features for prod build.

What's happening that seems wrong?

I read the docs, but I don't see examples where I can given key, secret and username. The instantiation example contains api_key and api_url in the params dictionary. By just giving key and url, it throws unautorized exception.

Hi @chintanckg, I believe you can only provide the api_key and api_url, as we are using Bearer Token Authentication.

@chintanckg Also, please note that with Basic Authentication you can use a username and password (key and secret) but we use Bearer Authentication as stated earlier. In our API docs, it states You may embed basic authentication credentials in the callback URL. Here's that reference: https://developers.deepgram.com/api-reference/#authentication

Another thing to check is to make sure your API key has not expired.

@chintanckg, an important note, you may not be using the latest Deepgram API. If the url you're sending requests to is not https://api.deepgram.com/ then you're likely using the Brain API which allows username/password combinations for authentication. This SDK only supports our newest API that makes requests to https://api.deepgram.com/

Basic Authentication worked. Requesting support for the same in the sdk as well, as user will have to write req_body code for brain.deepgram, basic authentication and other ways of authentication. Posting here, the code that worked for me, maybe it will be helpful to other users:
`def get_transcription(filename, key_boost_list):
headers = {}
headers['Authorization'] = 'Basic {}'.format(
base64.b64encode('{}:{}'.format(username, password).encode('utf-8')).decode('utf-8'))
headers['Content-Type'] = 'audio/mpeg'
data = open(filename, 'rb')
args = [
('punctuate', 'true'),
('multichannel', 'true'),
('search', ''),
('diarize', 'false'),
('language', 'en'),
('model', 'prodigaltech'),
('uttseg', 'true'),
('sentiment','true')
('version', 'v3'),
('numerals', 'true'),
]
keywords = []
if key_boost_list:
    for key in key_boost_list:
        keywords.append(('keywords',key))
args.extend(keywords)
resp = requests.request(method='POST', data=data, headers=headers, url=url, params=args)
print(resp.request.url)
if resp.ok:
    return (True, resp.json())
return (False, resp)`

Here, username will be the key and password will be the secret.

Hi @chintanckg thank you for posting your solution! That always helps others as well. We appreciate it! :)


Bootstrap usage

User Story:
For the challenge, I would like to use  Bootstrap to rebuild my Portfolio.
Acceptance Criteria:

The bootstrap solution should minimize the use of media queries
Bootstrap cards for each project

The project solution changed to cards. The leading (1st) Portfolio card is expanded according to previous portfolio project requirements.

The bootstrap solution used across the project - some standard bootstrap class constructions are changed/adjusted (using other bootstrap classes) to match design requirements.


CDC checkpoint stucks when pd leader changes

What did you do?

run test case: 	pd_leader_switch_sync

What did you expect to see?

CDC checkpoint should not stucks, and CDC should not restart when  pd leader changes

What did you see instead?

CDC checkpoiny stucks, and CDC restart seen when PD leader changes

[2023/06/06 06:18:03.972 +00:00] [ERROR] [upstream.go:161] ["init upstream error"] [error="[CDC:ErrReachMaxTry]reach maximum try: 10, error: [CDC:ErrCheckClusterVersionFromPD]failed to request PD 503 Service Unavailable no leader\n, please try again later: [CDC:ErrCheckClusterVersionFromPD]failed to request PD 503 Service Unavailable no leader\n, please try again later"] [errorVerbose="[CDC:ErrReachMaxTry]reach maximum try: 10, error: [CDC:ErrCheckClusterVersionFromPD]failed to request PD 503 Service Unavailable no leader\n, please try again later: [CDC:ErrCheckClusterVersionFromPD]failed to request PD 503 Service Unavailable no leader\n, please try again later\ngithub.com/pingcap/errors.AddStack\n\tgithub.com/pingcap/errors@v0.11.5-0.20220729040631-518f63d66278/errors.go:174\ngithub.com/pingcap/errors.(*Error).GenWithStackByArgs\n\tgithub.com/pingcap/errors@v0.11.5-0.20220729040631-518f63d66278/normalize.go:164\ngithub.com/pingcap/tiflow/pkg/retry.run\n\tgithub.com/pingcap/tiflow/pkg/retry/retry_with_opt.go:69\ngithub.com/pingcap/tiflow/pkg/retry.Do\n\tgithub.com/pingcap/tiflow/pkg/retry/retry_with_opt.go:34\ngithub.com/pingcap/tiflow/pkg/version.CheckClusterVersion\n\tgithub.com/pingcap/tiflow/pkg/version/check.go:93\ngithub.com/pingcap/tiflow/pkg/upstream.initUpstream\n\tgithub.com/pingcap/tiflow/pkg/upstream/upstream.go:157\ngithub.com/pingcap/tiflow/pkg/upstream.(*Manager).AddDefaultUpstream\n\tgithub.com/pingcap/tiflow/pkg/upstream/manager.go:92\ngithub.com/pingcap/tiflow/cdc/capture.(*captureImpl).reset\n\tgithub.com/pingcap/tiflow/cdc/capture/capture.go:220\ngithub.com/pingcap/tiflow/cdc/capture.(*captureImpl).run\n\tgithub.com/pingcap/tiflow/cdc/capture/capture.go:303\ngithub.com/pingcap/tiflow/cdc/capture.(*captureImpl).Run\n\tgithub.com/pingcap/tiflow/cdc/capture/capture.go:278\ngithub.com/pingcap/tiflow/cdc/server.(*server).run.func1\n\tgithub.com/pingcap/tiflow/cdc/server/server.go:396\ngolang.org/x/sync/errgroup.(*Group).Go.func1\n\tgolang.org/x/sync@v0.1.0/errgroup/errgroup.go:75\nruntime.goexit\n\truntime/asm_arm64.s:1172"]
[2023/06/06 06:18:03.972 +00:00] [ERROR] [capture.go:305] ["reset capture failed"] [error="[CDC:ErrReachMaxTry]reach maximum try: 10, error: [CDC:ErrCheckClusterVersionFromPD]failed to request PD 503 Service Unavailable no leader\n, please try again later: [CDC:ErrCheckClusterVersionFromPD]failed to request PD 503 Service Unavailable no leader\n, please try again later"] [errorVerbose="[CDC:ErrReachMaxTry]reach maximum try: 10, error: [CDC:ErrCheckClusterVersionFromPD]failed to request PD 503 Service Unavailable no leader\n, please try again later: [CDC:ErrCheckClusterVersionFromPD]failed to request PD 503 Service Unavailable no leader\n, please try again later\ngithub.com/pingcap/errors.AddStack\n\tgithub.com/pingcap/errors@v0.11.5-0.20220729040631-518f63d66278/errors.go:174\ngithub.com/pingcap/errors.(*Error).GenWithStackByArgs\n\tgithub.com/pingcap/errors@v0.11.5-0.20220729040631-518f63d66278/normalize.go:164\ngithub.com/pingcap/tiflow/pkg/retry.run\n\tgithub.com/pingcap/tiflow/pkg/retry/retry_with_opt.go:69\ngithub.com/pingcap/tiflow/pkg/retry.Do\n\tgithub.com/pingcap/tiflow/pkg/retry/retry_with_opt.go:34\ngithub.com/pingcap/tiflow/pkg/version.CheckClusterVersion\n\tgithub.com/pingcap/tiflow/pkg/version/check.go:93\ngithub.com/pingcap/tiflow/pkg/upstream.initUpstream\n\tgithub.com/pingcap/tiflow/pkg/upstream/upstream.go:157\ngithub.com/pingcap/tiflow/pkg/upstream.(*Manager).AddDefaultUpstream\n\tgithub.com/pingcap/tiflow/pkg/upstream/manager.go:92\ngithub.com/pingcap/tiflow/cdc/capture.(*captureImpl).reset\n\tgithub.com/pingcap/tiflow/cdc/capture/capture.go:220\ngithub.com/pingcap/tiflow/cdc/capture.(*captureImpl).run\n\tgithub.com/pingcap/tiflow/cdc/capture/capture.go:303\ngithub.com/pingcap/tiflow/cdc/capture.(*captureImpl).Run\n\tgithub.com/pingcap/tiflow/cdc/capture/capture.go:278\ngithub.com/pingcap/tiflow/cdc/server.(*server).run.func1\n\tgithub.com/pingcap/tiflow/cdc/server/server.go:396\ngolang.org/x/sync/errgroup.(*Group).Go.func1\n\tgolang.org/x/sync@v0.1.0/errgroup/errgroup.go:75\nruntime.goexit\n\truntime/asm_arm64.s:1172"]
[2023/06/06 06:18:03.972 +00:00] [INFO] [capture.go:298] ["the capture routine has exited"]
[2023/06/06 06:18:03.972 +00:00] [INFO] [client.go:779] ["[pd] stop fetching the pending tso requests due to context canceled"] [dc-location=global]
[2023/06/06 06:18:03.972 +00:00] [INFO] [client.go:716] ["[pd] exit tso dispatcher"] [dc-location=global]
[2023/06/06 06:18:03.972 +00:00] [INFO] [client.go:779] ["[pd] stop fetching the pending tso requests due to context canceled"] [dc-location=global]
[2023/06/06 06:18:03.972 +00:00] [INFO] [client.go:716] ["[pd] exit tso dispatcher"] [dc-location=global]
[2023/06/06 06:18:03.972 +00:00] [ERROR] [server.go:337] ["http server error"] [error="[CDC:ErrServeHTTP]serve http error: mux: server closed"] [errorVerbose="[CDC:ErrServeHTTP]serve http error: mux: server closed\ngithub.com/pingcap/errors.AddStack\n\tgithub.com/pingcap/errors@v0.11.5-0.20220729040631-518f63d66278/errors.go:174\ngithub.com/pingcap/errors.(*Error).GenWithStackByArgs\n\tgithub.com/pingcap/errors@v0.11.5-0.20220729040631-518f63d66278/normalize.go:164\ngithub.com/pingcap/tiflow/pkg/errors.WrapError\n\tgithub.com/pingcap/tiflow/pkg/errors/helper.go:34\ngithub.com/pingcap/tiflow/cdc/server.(*server).startStatusHTTP.func2\n\tgithub.com/pingcap/tiflow/cdc/server/server.go:337\nruntime.goexit\n\truntime/asm_arm64.s:1172"]

Versions of the cluster
TiCDC version (execute cdc version):
["Welcome to Change Data Capture (CDC)"] [release-version=v6.5.3] [git-hash=1e2f277f2e3d9b57b15db9a2a9b2c62832c071ca] [git-branch=heads/refs/tags/v6.5.3] [utc-build-time="2023-06-05 10:18:40"] [go-version="go version go1.19.8 linux/arm64"] [failpoint-build=false]

clinic: https://clinic.pingcap.com.cn/portal/#/orgs/31/clusters/7241426602968571214?from=1686025985&to=1686061139
pd_0_1804985.log
pd_1_1804985.log
cdc log is too big to upload...

/label affects-6.5

/close


Make it so ndt is defined only once (hash map)

This means that the following code works:
t1 = ndt('int32')
t2 = ndt('int32')

assert t1 is t2

arr = xnd(5, type=t1)

assert isinstance(arr, t2)

Worth looking at Python's set object for implementation of a hash map.

This was solved by @skrah I believe.


ListeningSystem / how to reduce manually writing code

I've finished implementing ashley in my project and there are a couple of things I think could be simpler:

There's a lot of entity iteration going on, and there are cases where I iterate multiple families in a system. In those cases, extending IteratingSystem would produce confusing code, so I implement the functionality in those systems manually (overriding addedToEngine, ...).
This is really annoying work, especially when you started just iterating one family using IteratingSystem, then added another one.
Lots of times I find myself in need of accessing one system from another system. To do that, I need to store a reference to the engine, then ask the engine every update for the current system of the wanted class. I could store the system reference in addedToEngine, but that only works if the other system was added before this one, and would also break if the system got replaced.

So, to avoid all this manual reference updating, this is my proposal:

interface EngineListener => void addedTo/removedFromEngine(EntitySystem system)
interface SystemListener => void addedTo/removedFromEngine(Engine engine)
class ListeningSystem => registers listeners
EntityList, SortedEntityList => just like their system counterparts, except they only supply the list and implement Iterable
SystemInstance => supplies a getter for the system

Example use of this:
public class MySystem extends ListeningSystem {
    EntityList players = new EntityList(Family.all(PlayerComponent.class).get());
    EntityList items = new EntityList(Family.all(ItemComponent.class).get());
    SystemInstance<MyOtherSystem> otherSystem = new SystemInstance(MyOtherSystem.class);

    public MySystem() {
        addSystemListener(players);
        addSystemListener(items);
        addEngineListener(otherSystem);
    }

    @Override
    public void update(float deltaTime) {
        for(Entity entity: players) {
            handlePlayer(entity);
        }
        otherSystem.get().doStuff();
    }
}

I'd like to know your opinion before I start on a pull request.
Good thing about this, is that it would not break existing systems, the new code could even be used to implement the existing iterating systems, to avoid code duplication and test duplication.

Accessing the collection of entities belong to a given family is trivial already. Imagine a CollisionSystem that checks for collisions between all cars and obstacles.
public CollisionSystem extends EntitySystem {
	private ImmutableArray<Entity> cars;
	private ImmutableArray<Entity> obstacles;

	public CollisionSystem() {

	}

	@Override
	public void addedToEngine (Engine engine) {
		cars = engine.getEntitiesFor(Family.all(CarComponent.class, CollisionComponent.class).get());
		obstacles = engine.getEntitiesFor(Family.all(ObstacleComponent.class, CollisionComponent.class).get());
	}

	@Override
	public void update (float deltaTime) {
		for (Entity car : cars) {
			for (Entity obstacle: obstacles) {
				// ...
			}
		}
	}
}

Arguably this a poor design choice, because CollisionComponent should probably do the filtering between cars and obstacles, so we don't need to treat the entities differently, The CollisionSystem would only process a unique list of entities, but let's leave it like this for the sake of the discussion.
The only thing you cannot do with Ashley today is retrieving other systems from the engine. Ideally you shouldn't depend on other systems to avoid coupling but sometimes it might be hard not to.
What's stopping you from passing a reference to X system to Y system's constructor? You could also have a setter. Dependency injection is better than hardcoding the dependency. Code that uses dependency injection is a hell of a lot easier to test because you can just mock out the other system.
Unless I have missed something,  I think no changes to Ashley are needed to accommodate your use case.

Nevermind, I guess I was thinking too much of a clean scenario, where every system might be replaced during runtime. That never happened in my cases, so I wrote more than was actually needed.


Provide link to stable version on readthedocs

Currently the docs is set up such that only the tip of master is generated (which then gets placed at /latest) and stable is not configured: https://persephone.readthedocs.io/en/stable/
I suggest that we configure the docs to build stable from the tagged releases and use the banner functionality in readthedocs to warn users that visit /latest that they are looking at the development version of the documentation.

See https://github.com/rtfd/readthedocs.org/issues/3481


[dask] passed through verbose for dask fit

In this PR I am fixing #5412:
I added the verbose parameter in the same way that the non-dask sklearn wrapper fit-method has the same parameter and passing it through to verbose_eval of the train-function.
I also set the default to True which mirrors the non-dask sklearn wrapper settings.

Thanks.  I didn't take the verbose parameter seriously back then because dask sometimes swallows Python stdout.  Till now I still have no idea why.


Converting from String to DateTime Drops Milliseconds

Please forgive me in advance for this rush job as I literally only spent less than 30 minutes on this, but it seems that the current driver drops milliseconds from timestamps coming out of the database.  I hacked a test together based off the encode tests (I don't think that there is an easy way for me to get a DB type constant since they are private, so I hardcoded the 1184).
I have a pending, (equally rushed) PR, but just wanted to bring this up in case I'm overlooking some reason why things are (or have to be) the way they are.
  solo_test('decode datetime', () {
    var data = [
      "22001-02-03 00:00:00.000",    new DateTime(22001, DateTime.FEBRUARY, 3),
      "2001-02-03 00:00:00.000",     new DateTime(2001, DateTime.FEBRUARY, 3),
      "2001-02-03 04:05:06.000",     new DateTime(2001, DateTime.FEBRUARY, 3, 4, 5, 6, 0),
      // FAILS!
      "2001-02-03 04:05:06.999",     new DateTime(2001, DateTime.FEBRUARY, 3, 4, 5, 6, 999),
      "0010-02-03 04:05:06.123 BC",  new DateTime(-10, DateTime.FEBRUARY, 3, 4, 5, 6, 123),
      "0010-02-03 04:05:06.000 BC",      new DateTime(-10, DateTime.FEBRUARY, 3, 4, 5, 6, 0)
      //TODO test minimum allowable postgresql date
    ];
    var tc = new TypeConverter();
    var d = new DateTime.now().timeZoneOffset; // Get users current timezone
    pad(int i) => i.toString().padLeft(2, '0');
    var tzoff = '${d.isNegative ? '-' : '+'}'
      '${d.inHours}:${pad(d.inMinutes % 60)}:${pad(d.inSeconds % 60)}';
    for (int i = 0; i < data.length; i += 2) {
      var str = data[i];
      var dt = data[i + 1];
      expect(tc.decode(str, 1184), dt);
    }
  });

Thanks for this.

It's the least I can do (assuming that I'm actually helping :-) ).  Of course as I'm sure you're aware, there are more nuances to it all.  I wasn't properly padding the optional milliseconds.  I made a change to try to accommodate that as well as another crack at the unit tests:
  solo_test('decode datetime', () {
    var data = [
      "2015-01-08 14:04:56.32+00",    new DateTime.utc(2015, DateTime.JANUARY, 8, 14, 4, 56, 320),
      "2015-01-08 14:04:56.001+00",   new DateTime.utc(2015, DateTime.JANUARY, 8, 14, 4, 56, 1),
      "2015-01-08 14:04:56.999+00",   new DateTime.utc(2015, DateTime.JANUARY, 8, 14, 4, 56, 999),
      "2015-01-08 14:04:56.2+00",     new DateTime.utc(2015, DateTime.JANUARY, 8, 14, 4, 56, 200),
      "2015-01-08 14:04:56.201+00",   new DateTime.utc(2015, DateTime.JANUARY, 8, 14, 4, 56, 201),
      "2015-01-08 14:04:56+00",       new DateTime.utc(2015, DateTime.JANUARY, 8, 14, 4, 56),
      "2015-01-08 14:04:56.0+00",     new DateTime.utc(2015, DateTime.JANUARY, 8, 14, 4, 56),
      "2015-01-08 14:04:56.000+00",   new DateTime.utc(2015, DateTime.JANUARY, 8, 14, 4, 56),
    ];
    var tc = new TypeConverter();
    for (int i = 0; i < data.length; i += 2) {
      var str = data[i];
      var dt = data[i + 1];
      expect(tc.decode(str, 1184, isUtcTimeZone: true), dt);
    }
  });

Oddly enough there is actually a test for milliseconds. But the test is buggy (it actually tests seconds), and as you've pointed out the implementation doesn't actually handle millis at all.
https://github.com/xxgreg/dart_postgresql/blob/master/test/postgresql_test.dart#L305
Thanks for bringing this up. It is helpful.


New version: CrystalDewWorld.CrystalDiskInfo version 9.3.0

Pull request has been created with komac v2.2.1 :rocket:
Resolves: https://github.com/microsoft/winget-pkgs/issues/151975
Microsoft Reviewers: Open in CodeFlow

thanks, got the update 👍


Unique index not enforced on sub-attributes named "_key"

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[ ] 3.1
[ ] 3.2 Beta1
[x] 3.2 Beta2
[ ] self-compiled devel branch

On this operating system:

[ ] DCOS on

[ ] AWS
[ ] Azure
[ ] own infrastructure

[ ] Linux

[ ] Debian .deb
[ ] Ubuntu .deb
[ ] SUSE   .rpm
[x] RedHat .rpm
[ ] Fedora .rpm
[ ] Gentoo
[ ] docker - official docker library
[ ] other:

[ ] Windows, version:
[ ] MacOS, version:

//example document
{
  "container_type": {
    "_key": "1081534"
  },
  "state": {
    "active": true,
    "retired": false
  },
  "service_start": "2017-06-21T22:02:42.992587497Z",
  "containers": [
    {
      "_key": "1095027",
      "sub_container": true
    },
    {
      "_key": "1095109",
      "sub_container": true
    },
    {
      "_key": "1095186",
      "sub_container": true
    },
    {
      "_key": "1095027",
      "sub_container": true
    },
    {
      "_key": "1095109",
      "sub_container": true
    },
    {
      "_key": "1095186",
      "sub_container": true
    },
  ]
}

I looked through the indexes documentation online and couldn't see anything related to this not being possible. Creating a unique index on a sub-attribute named "_key" does not get enforced. If i switch the unique index to the sub-attribute named "sub_container" in the example document above, the constraint IS enforced. As far as why don't I just switch the sub-attribute name from "_key" to something else, well I am using a golang back end and it just makes mapping to my structs much easier.

As far as I can see, the uniqueness checks work and uniqueness is enforced, regardless of whether the sub-attribute is named _key or else.
Here's a quick proof that the uniqueness actually works:
db._create("i");
db.i.ensureIndex({ type: "hash", unique: true, fields: ["a[*]._key"]});
db.i.insert({ a: [ { _key: 1 } ] });
db.i.insert({ a: [ { _key: 1 } ] });

The second insert call produces:
!db.i.insert({ a: [ { _key: 1 } ] });
!     ^

What is probably confusing is the following behavior (quoted from https://docs.arangodb.com/3.1/Manual/Indexing/IndexBasics.html):

Array values will automatically be de-duplicated before being inserted into an array index. For example, if the following document is inserted into the collection, the duplicate array value bar will be inserted only once:
db.posts.insert({ tags: [ "foobar", "bar", "bar" ] });
If an array index is declared unique, the de-duplication of array values will happen before inserting the values into the index, so the above insert operation will not necessarily fail. It will fail if the index already contains an instance of the bar value, but will succeed if the value bar is not already present in the index.

So inserting the same key value twice (or even more times) in a single insert will succeed if the value is not already in the index. It will succeed because array values are de-duplicated before insertion.

I have opened a pull request (https://github.com/arangodb/arangodb/pull/2644) which would make the on-insert behavior configurable.

@jsteemann the changes on pull request #2644 look great, thanks


Finetuning Boltz with no MSA.

Any interest in PR / model weights finetuned to improve single-sequence performance? (e.g. using ESM activations as done in CHAI).
Asking after trying Crambin (1EJG), saw 0.4 RMSD increase to 8-10 RMSD - curious if other see the same, scared I'm just doing something wrong.

Also, curious if anyone finetuned ESM to minimize |ESM(seq).MSA_head - MSA(seq)| - very hacky way to circumvent MSA pipeline engineering pain.

maybe not quite minimize |ESM(seq).MSA_head - MSA(seq)| but vcmsa uses prot-t5 embeddings to infer msa

Closing this issue for now, please reopen if anyone has any comment or request on this!


Mismatched parameter name

The "Example" names the Working Directory parameter as workingDirectory, but the "Arguments" block names it as cwd.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fcfcf6fc-d48d-4758-06e4-df7235aa3f9d
Version Independent ID: 6a0ddf0d-221a-9cfd-9602-34614a43ed61
Content: CMake build and release task - Azure Pipelines
Content Source: docs/pipelines/tasks/build/cmake.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @vijayma
Microsoft Alias: vijayma

Thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.


improve overall docs and addon usage

Long overdue. Sorry!
Would love some pointers in case the docs should be improved. Thank you!

Thanks a lot for the review @kettanaito. All suggestions are applied!


How to get the CPG nodes and edges?

Hi,
Thanks for your greate job.
I want to get the nodes and edges of a cpg?
It seems like there not such a method.
What should I do?

cpg.all, cpg.graph.nodes are two of many ways to get the nodes. Edges mostly exist as connections between nodes, so if you want to keep it generic, you can run .outE or .inE or .bothE on any node.
Does that make sense?

Thank for your answering.
I remeber that joern could offer the .CSV files of the nodes and edges of a CPG.
Which version of it?

we don't currently support import/export formats, but i happen to be working on it at the moment, ETA next week I guess

Thanks for your patient answering.
Hope it coming soon!
Thanks!


Add best sellers page

(Frontend and Backend) All-time best sellers section

N number of cards displayed as most sold + info and hyperlink
A best seller card is a card that has been sold the most amount of times (all time)

Follow the Figma designs

Figma design for the best seller page. The Start exploring button will redirect to this page.

Closed by #84


only do the sudo validation for up and destroy if provider is libvirt…

…, as its required only for creating nfs mount

Hi,
I should perhaps explain the purpose of this change.   The requirement for sudo is only for vagrant to setup nfs mounts, and then only for up and destroy.
So the reason I contributed this PR is to reduce annoyance at requiring sudo for all the other scenarious where it is pointless.
Hopefully you can merge this.


Add cool things and cleanup

There are probably mistakes in this, sorry.
Changelog:

Fix node-modules/ to node_modules/
Fix JSDOC format at start
Replace all instances of function with arrow functions to make it consistent across the file
Remove let date as it's only used once and can be replaced with today.getDate() (which I did)
Make all if statements consistent in terms of formatting
Replace INFO with INIT on startup statements
Consistently allow .console to not include INFO
Switch INFO to SUCCESS in .success
Fix package.json tag formatting
Consistently add semicolons to test.js
Replace text with t in strip function to be consistent with the other functions
Bump leeks.js to latest version
Fix grammar issue in test.js
Fix spacing consistency across the files
Fix readme to redirect users to test.js or npm test/yarn test
Add installation instructions in readme
Add yarn information in readme
Remove keywords that mean nothing in package.json
Update bugs/homepage URL in package.json

Thanks

no problem


Add the retrospective Prime Directive as a suggested practice.

Regardless of what we discover, we understand and truly believe that everyone did the best job they could, given what they knew at the time, their skills and abilities, the resources available, and the situation at hand.
via http://retrospectivewiki.org/index.php?title=The_Prime_Directive
This is a helpful piece to add to the Meeting Facilitation Tips page.

This has been added.


Rename the default branch from master to main

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for the contribution, can you sign the CLA.


Add DataOps topic

Please confirm this pull request meets the following requirements:

[X] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md.
[X] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[X] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Curating a new topic or collection

[X] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[X] My folder contains a *.png image (if applicable) and index.md
[X] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

DataOps has emerged as a dedicated topic similar to DevOps in the last few years. Curating this topic will help to find tools around DataOps methodology.

@octokatherine Thanks. Changes are not reflected yet on explore page. Does it take time?

@ravisuhag you should see it now

@ravisuhag you should see it now
@octokatherine
No luck so far. Got something to do with cache or is there a background process independent of GitHub workflows? I think all the changes that happened in the repo in the last 2-3 days are not reflected yet.


Add integration tests for managing user defined federated authenticator

Issue:

https://github.com/wso2/product-is/issues/21216

Add integration tests for managing user defined federated authenticators.
Related PRs:

https://github.com/wso2/identity-api-server/pull/734
https://github.com/wso2/carbon-identity-framework/pull/6105

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11736449887

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11736449887
Status: success


README.md: Better Acknowledgements

First, I am very grateful for this repository.
When I look at the readme, the logo for mpv-player is missing from the wikipedia server.
So, I decided to improve the README.md a bit.
I hope this is better. Thank you.

Thanks for the fix!


Sand slabs sound like dirt when dug

Just that.  Not sure if it's already been mentioned.

Already got a fix in for next release :)


multi-thread - is it worth it?

Have you tried to enable the thread support in flecs using FThreadPool or GameTaskGraph? Is it worth the effort to make the game logic multi-threaded or will the flecs defer operations make this not any better? I been playing with flecs for some time with UE4 but I really like some of the work you done so far. I was concentrating more on moving systems to the appropriate tick group(s) but your registration solution is way cleaner than I currently have implemented.

Hi @RobertMassart! I've been implementing a new query/system management solution that allows for having more control over execution order and creating different groups and subgroups of queries/systems.
That's also a move towards a possibility of using the UE based multi-threading in UnrealFlecs. The current algorithms of spaceship movements and enemy searching have caused a real bottleneck. That's something I'd like to address but I'm not sure how useful the UE threads will be here. In any case, I plan to try it out and present my findings.

There really two parts to the multi-thread issues.
The first being that some systems need to be pinned to the Game Thread (Tick) for syncing UE4 actors/components  into and out of the flecs world, and/or spawning/destroying objects (actors/etc…).
The other part is inner parallelism which is harder.   This is where you take a query and break it up across the available threads.  To prevent corruption it is my understanding that flecs uses deferred operations and sync points in the pipeline solution.      Not sure how it prevents false sharing in all situations when it does this because I don’t really see thread fences to force flushing the cache lines across the worker threads and the main thread.  [This is what works well for spaceship movement and enemy searching as it spreads the work over many threads]
Anyways, it would be great to see what you come up with.


[WIP] Green deal energy grants

The PR has been created to allow the creation of the Preview app.
Any comments added while the WIP label exists will be ignored.
Factcheck
Warm home discount
Energy grants calculator
Green Deal header
Energy grants calculator
Expected changes
Warm home discount
URL on GOV.UK

Many changes to text in multiple outcomes. The change described below shows:

the changes to the energy supplier title
the fix to the warm home discount amount
the changes in the rules for displaying the affordable warmth obligation callout
the change of case in the bulleted lists

Before

After

Green deal header
URL on GOV.UK
Before

After

This work has been abandoned. The focus will be on meeting the need of this calculator elsewhere on GOV.UK.


Fix #269: whitelisting plist_template_path html_template_path and htm…

Fixing #269

Coverage increased (+0.02%) to 83.76% when pulling 617a6e2e21b73cf7187d20b8b593e962eb70e909 on frobichaud:master into ae52812f6e339faaf2cd29bddffde43078255ae4 on KrauseFx:master.

Looks great, thank you @frobichaud :+1:


[ENH] add basic function to generate and update dataset_description

[x] allow easy creation of dataset_description from scratch
[x] allow update of existing dataset_description
[x] allow to generate derivative description from source description
[x] update copy_to_derivatives to use this class to update the dataset_description

In a separate PR

[ ] transfer some of dataset_description function from layout.m to this class

Something similar could be implemented to deal with metadata: this could help with some of the points from #79

now fixes #177


Can not send parameters to created logger

My environment:

winston@3
node -v : v10.3.0
Windows 10
ES6

My problem
I've tried to create multiple logger instances with winston.loggers.add(), but when i tried to use that logger later,  Attempt to write logs with no transports shows.
My code
const winston = require('winston');
winston.loggers.add('woaLogger', {level:'error', transports: [ new winston.transports.Console()] });
const logger = winston.loggers.get('woaLogger');
logger.info('Hello Moto !');
Unexpected Result
[winston] Attempt to write logs with no transports {"message":"Hello Moto !","level":"info"}
As is shown above, neither the level nor the transports has been delivered to create new logger in the winston.loggers container.
Anyone meet the same issue?

In winston.loggers.add, the first param has to be a class.
Check: https://github.com/winstonjs/winston/blob/master/UPGRADE-3.0.md#winstonlogger
The third bullet says (at the time of writing this):

winston.Logger.add no longer accepts prototypes / classes. Pass an instance of our transport
instead.

logger.add(winston.transports.Console);

// Do this instead.
logger.add(new winston.transports.Console());


false positives: js/xss

Hi,
I have a few alerts about js/xss I can't understand how to work around them.
Here is an example:
https://lgtm.com/projects/g/netdata/netdata/alerts/?mode=list&rule=js%2Fxss
As you can see, I have escaped everything, but still LGTM complaints about XSS:
function escapeUserInputHTML(s) {
    return s.toString()
        .replace(/&/g, '&')
        .replace(/</g, '<')
        .replace(/>/g, '>')
        .replace(/"/g, '"')
        .replace(/#/g, '#')
        .replace(/'/g, ''')
        .replace(/\(/g,'(')
        .replace(/\)/g,')')
        .replace(/\//g,'/');
}

function verifyURL(s) {
    if(typeof(s) === 'string' && (s.startsWith('http://') || s.startsWith('https://')))
        return s
            .replace(/'/g, '%22')
            .replace(/"/g, '%27')
            .replace(/\)/g, '%28')
            .replace(/\(/g, '%29');

    console.log('invalid URL detected:');
    console.log(s);
    return 'javascript:alert("invalid url");';
}

Any ideas?
Thank you!

Thanks for your report and apologies for the delay in getting back to you. It looks like the URL in your original report doesn't work any more, but I'm assuming it refers to the same code as https://lgtm.com/projects/g/netdata/netdata/alerts/?mode=tree&ruleFocus=2022121412.
You are right that your escapeUserInputJS function makes it impossible for the user-provided string to break out of the attribute value, but it seems like a malicious user could still inject a javascript: URL into the href attribute. Or is that perhaps guarded against in some other way?

Hi,
Thank you for your reply.
I updated the URL and added a check to allow only URLs starting with http:// and https://.
However, LGTM still complains about XSS.
Thank you!

Thanks for looking into this! At first sight this code now looks reasonably safe, we'll improve the analysis to recognise that and not flag it any longer. (In the meantime, you might consider adding a suppression comment.)

Thank you again for reporting this and sorry for the delay in getting it addressed. This is now fixed, and the fix should be deployed next week.


Can't find module with 1.1.7

Hello! It seems like the new version 1.1.7 creates some issues and the module can't be located anymore. It seems to have something to do with: https://github.com/sgwilym/windups/blob/master/package.json#L28
There's no file called index-.js. Possibly a mistake in the new build system?

@MathieuLoutre I can confirm this problem. In my opinion, main and module fields should be enough in package.json. The NPM doc says this property's purpose is to limit which files a consumer can import/require. Maybe it was not intentional to add this declaration. As the NPM documentation says, it got added in NPM 7. In package.json, there are a few fields Yarn / Yarn 2 (Berry) support, but NPM does not, such as the field "resolutions." Hopefully, this is not true vice versa for the field "exports."
@sgwilym Can you please investigate or remove this configuration option, thx!

@MathieuLoutre Oh, whoops. Thanks for reporting this. I just published v1.1.8, where the require export points at an actual, existing file. Please let me know if you have any further trouble.
@gurkerl83 I won't be removing these extra fields!

@sgwilym It seems with v1.1.8, this error is gone, but another unveils itself. The problem is that your library break-styled-lines does not provide a commonJS output yet. When the loading of windups starts as a commonJS module, the respective counterpart of break-styled-lines in a commonJS format is required. Maybe you can tsdx the library as well, thx!


[Feature] Show Only Some Files in Directory

I love using VSCode's ssh plugin for accessing servers. However, I work with large amounts of data in my research, and often have to deal with directories with literally millions of images. When that happens, merely clicking on the directory is enough to make VSCode irresponsive, requiring me to force quit. Hence, 1. I hope large directories will not attempt to show all their files when opened; and 2. I would also like to be able to click on some arbitrary images in those directories. For instance, large directories can, by default, show only 100 random files, or the first 100 files by whatever ranking. The specific parameters can also be configurable.

I hope large directories will not attempt to show all their files when opened

This shouldn't be happening. Can you perform a screen record with the following steps,

Start with a fresh user data dir with code --user-data-dir <some-absolute-path>, for ex: on macos code --user-data-dir /tmp/vscode-large-dir
In VSCode, run Developer: Toggle Developer Tools from command palette
Start a performance profile following the steps at https://github.com/microsoft/vscode/wiki/Performance-Issues#profiling-the-renderer-process
Open the directory demonstrating the issue
Save the profile after the freeze happens
Attach the saved profile to this issue.


create starter branches

main
stable-us
stable-foreign

created
stable-us
stable-foreign
montecarlo
instructions posted in slack


Use string keys by default in new API

I asked about what's the best practice for string keys vs atom keys and the response I got was "string keys for user input, atom keys for everything else". I also know that Guardian, which currently uses this library, uses string keys as well. Right now, the default token uses atoms for the claims and validations and the verify function turns the strings into atoms after JSON decoding.
I think we should use strings for keys by default and only use atoms when the user adds a claim or validation using one, a struct is used, and in the case of verify when a struct is given or an option to use atoms is given.
@cs-victor-nascimento what do you think?
@hassox maybe you would like to chime in as well?

That is an interesting question. I believe that with the new API we would never hit a case where the atom was not previously registered. This was a different case back with the old API where we would accept an arbitrary map. Right now you have only with_claim/2 functions and with_claims/2 which both accept only known atoms.
I think we are safe here. We are not accepting user input so I believe we are in the "everything else" case here.

I think the only place we it's an issue is here where we turn the string into an atom. If we remove that then I think we are ok.

To remove that we would have to pass a keys: :atoms! to decode_payload. I think that would break JSX integration. In any case, that would only pass this line to Poison or JSX. In the end it would still execute it.
This line is safe as it will only execute AFTER verification is ok. So, in the end, all atoms there should have been registered before.
I understand the issue here. Perhaps it is better to go binaries all the way to facilitate this behaviour. I think erlang-jose uses only binaries anyway.

I think using binary keys as a default will be better. I much prefer atoms myself honestly, but I know there are some concerns about using them. I can put together a PR for this today if I get a chance.

I agree with you. It is best to go a safe route here.
On Tue, Sep 1, 2015 at 2:31 PM, Bryan Joseph<EMAIL_ADDRESS>wrote:

I think using binary keys as a default will be better. I much prefer atoms
myself honestly, but I know there are some concerns about using them. I can
put together a PR for this today if I get a chance.
—
Reply to this email directly or view it on GitHub
https://github.com/bryanjos/joken/issues/79#issuecomment-136805338.

--
Victor Oliveira Nascimento
Concrete Solutions
Senior Analyst/Developer
<EMAIL_ADDRESS>http://www.concretesolutions.com.br
Mobile: +55 11 9 8923-8061
Rio de Janeiro                                     São Paulo
Rua São José 90, sala 2121                 Rua Flórida 1670, Sala 22
Cep: 20010-020                                   Cep: 04565-001
Centro - Rio de Janeiro - Brasil             Brooklin - São Paulo – Brasil
Phone : +55 21 2240-2030                   Phone: +55 11 4119 0449

closed with #80


The shape object sent to the shapeSave event is unable to be added back via the saveShape method

I want to subscribe to the shapeSave event and then render changes into a second canvas as a mirror.
lcOne.on('shapeSave', function(args) {
  lcTwo.saveShape(args.shape, false, args.previousShapeId)
});

Trying this throws the following exception:
Uncaught Can't render shape of type undefined to canvas

I've tried manually setting the className, but it doesn't appear to help.  Am I thinking about this wrong or is there a bug?

Interesting. I'll look into this. What is the output of LC.shapeToJSON(shape)?

Hmm, just tried to reproduce in a tiny example and it does appear to be working now.  I'm going to see if I did something else silly in my larger example.

It's working now; my bad.  When I was sending over the wire, I didn't call LC.shapeToJSON and LC.JSONToShape appropriately.


Add dockerfile and docker compose yml and edit README markdown.

Added docker experiment for Software Testing next series

@fi23 Please review this. This is my first crack at Dockerfile and docker-compose.yml.
So I am not sure how this looks to you but feel free to edit the Dockerfile or docker-compose.yml.

Coverage remained the same at 100.0% when pulling 6a65ffed0d35e24f1caed317cc3e194484cde693 on Add-Docker into bd27d25f4b84b44941ab18ff79425ca02075e4a5 on master.

Coverage remained the same at 100.0% when pulling 9eaed1ee322f0a0374bda84d71050549cbbaa611 on Add-Docker into bd27d25f4b84b44941ab18ff79425ca02075e4a5 on master.

@fi23 so I figured out the problem now I can run the app in docker. Big milestone here. Now will think about the testing story

@fi23 so I figured out the scripts part and added a smaller docker image. Also added a test services section in docker compose. I am going to merge this next week frank else you have any thoughts on this.


FFMPEG_VERSION: 5.0 => n5.0

Hi,
the name schema of the FFMPEG version seems to have changed.
To make FFMPEG source code downloadable change
FFMPEG_VERSION=5.0
into
FFMPEG_VERSION=n5.0
in build-ffmpeg.

Strange, now it works with FFMPEG_VERSION=5.0 and not with FFMPEG_VERSION=n5.0.


Add macOS build support

Add build documentation and update code to support building on macOS. Rename existing stack_t struct to avoid conflict with built-in type definition on macO. Use int64 and uint64 primitives for integer types to fix compilation warnings. Add portable endian header file for macOS endian definitions, as these are not located in endian.h. This was tested on macOS 10.15.7.
DAFFODIL-2744
BUILD.md: Add macOS dependency installation to build documentation.
stack.h: Rename stack_t struct to c_stack_t in order to avoid naming conflict with macOS types.
stack.c: Rename stack_t struct to c_stack_t in order to avoid naming conflict with macOS types.
xml_writer.h: Rename stack_t struct to c_stack_t in order to avoid naming conflict with macOS types.
xml_writer.c: Use PRIi64 and PRIu64 integer types to avoid compilation warnings on macOS.
p_endian.h: Add portable endian header file for including proper endian header files and defines on macOS.
parsers.c: Import portable endian header file.
unparsers.c: Import portable endian header file.

I think this is a question for other devs: should we consider adding a GitHub action for macOS to ensure this continues to work?

Yes, but not as part of this ticket, but another one about specifically setting that up.

The Build Documentation step generates 1 warning

There's lots of discussions on the internet about this error, with I think no real resolution. I think this might be a known issue.

The Run Integration Tests step now generates 3 warnings;

This was a change made in the recent integration test refactoring. We used to just have the blob tests commented out because they require manually generating large files to test. But because they were commented out, they were easy to forget about. To avoid that, I added some JUnit assumeTrue calls so that the tests would be skipped if those generated files didn't exist. That way the tests still pass, but we get a clear reminder that those tests exist and were skipped. We don't need to run these very often because blob logic doesn't change much, but they're good to know have be periodically reminded of.

I think this is a question for other devs: should we consider adding a GitHub action for macOS to ensure this continues to work?

Yes, but not as part of this ticket, but another one about specifically setting that up.

Agreed it can be done separately. I've created DAFFODIL-2747 for this.

I think this is a question for other devs: should we consider adding a GitHub action for macOS to ensure this continues to work?

Peter and I certainly can modify the GitHub Actions CI workflow if anyone else would like macOS support.  If we do so, I propose that we run only one job on the macOS runner (that is, we don't test Java 8, 11, and 17 since that would be redundant with the Linux and Windows runners already testing Java 8, 11, and 17).  I have been using Java 11 as my machine's Java runtime up to now, but googling makes me think our choice really should be between Java 8 (if we want to support the most widely used Java runtime) or Java 17 (if we want to support the current LTS version and Java 17 was released over 1 year ago, so it's had enough time to fix bugs and become a stable runtime).  Shall we test only Java 17 on the macOS runner?

I'll move our discussion about Java runtimes to DAFFODIL-2747.


When serve Angular app using twig library throw error: Can't resolve path node_modules/twig

🐞 Bug report
Command (mark with an x)

- [ ] new
- [ ] build
- [ x ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

 I don't know. It's the first time I try to integrate angular with twig template engine library.
Description
I can't integrate twig php template library in my angular project. Every time throw the compilation error: Can't resolve 'path' in '.../node_modules/twig'
🔬 Minimal Reproduction

I create a new angular project (version 8.0.1).
Install the twig and @types/twig library.
Create an empty component
In the ngOnInit method include this code:
const template = twig({ data: 'The {{ baked_good }} is a lie.});  console.log(template.render({baked_good: 'cupcake'}));
When I execute the command ng serve, I get the error:

ERROR in ./node_modules/twig/twig.js
Module not found: Error: Can't resolve 'path' in '/Users/yduartep/Documents/workspace/www2/node_modules/twig'
🔥 Exception or Error

ERROR in ./node_modules/twig/twig.js
Module not found: Error: Can't resolve 'path' in '.../node_modules/twig'

🌍 Your Environment

Anything else relevant?

Hello, we reviewed this issue and determined that it doesn't fall into the bug report or feature request category. This issue tracker is not suitable for support requests, please repost your issue on StackOverflow using tag angular-cli.
If you are wondering why we don't resolve support issues via the issue tracker, please check out this explanation.

At the end, I could make it work adding the library path into the tsconfig.json like this:
"paths": {       "twig": [         "node_modules/twig/twig.min.js"       ] }


replace os/user with go-homedir

looks like it's still using cgo, cross-compiles fine but seems like it could be our issue with ~/.aws/config on windows. https://github.com/mitchellh/go-homedir

I think the issue with ~/.aws/config is that the AWS Go SDK doesn't use it. Maybe I'm thinking of a different issue?
https://github.com/aws/aws-sdk-go#aws-cli-config-file-awsconfig

oops, updated the desc, this is a windows-only problem (we added ~/.aws/config support in apex)


Enforce data type

I want to let my admins change some constants via a form. I thought I could just use the parameters as is, and they would automatically convert to the appropriate data type, but
class Constants
  include Mongoid::AppSettings
  setting :some_number, type: Integer, default: 42
end

Constants.some_number # => 42
Constants.some_number = "42" # Should attempt a conversion to integer
Constants.some_number # => "42", not an integer anymore :(

It's not necessarily enforcing but I added limited type support in f5d92b03e1cd7bb09740f7652bda0098457920b7 by just passing that part of the options hash on to Mongoid, which will then try to do the cast. This is also released as version 1.3.0 of this gem.
You won't be able to do validations (which would require a whole bunch of meta-programming trickery if I wanted to be feature-complete with the Mongoid validations API). If you need that, you might be better off using some Interactor-style library (ActiveInteraction is one I've used, but there are plenty more) to wrap around the actual assignment of values.


<EMAIL_ADDRESS>support not possible until brackets update bundled node version to 4.x

The extension cannot load the eslint client. I tried installing eslint globally and locally, both running fine, but when run from Brackets.io it cannot load the client. I am running brackets on MacBook Pro, El Capitan.

I am having the same issue here. I think this has to do with eslint 3 requiring node >= 4, @zaggino any suggestions on how this could be solved? Seems like Brackets needs to update it's internal version of node or could this plugin do this?

hmm, extension probably won't be able to do anything with this, it's brackets problem

do you know if brackets has an initiative to up the node version?

@AdriVanHoudt I don't believe brackets have an initiative to do anything except get the brackets code to new dreamweaver at the moment, atom or vs-code might be better alternatives at the moment

new dreamweaver? Also I just updated and it works again, I think it i fine as long as my config does not include eslint > 3 rules

Ok so it works when my project also has an eslint of < 3 :/

@AdriVanHoudt
http://blog.brackets.io/2015/10/05/update-from-the-adobe-brackets-team/
http://blogs.adobe.com/dreamweaver/2015/10/next-generation-of-dreamweaver.html

Hmm feels like the project is slightly dying out seeing how old that is and looking at the recent commits, which are mostly translation updates

@sradevski @AdriVanHoudt published<EMAIL_ADDRESS>i put a check if it detects<EMAIL_ADDRESS>then fallback to use latest<EMAIL_ADDRESS>instead of failing completely
only thing I could think of

@zaggino I am not seeing the plugin in npm registry any more, I can see it in the plugins thing  but that is v 0.17 and it does not allow me to install it. Any way you unpublished it or something?

@AdriVanHoudt Nothing is unpublished, registry builder uses npmsearch.com site to search for extensions but it seems quite unreliable. Must look at some other npm search provider.

ah I see, weird that it can't find just that one, no way you can use npm's api (if they have one)?

They don't, not that I know of. I'll try to get it up and running somehow.

@zaggino thanks a lot for the effort! 🔥

@AdriVanHoudt pushed out new server version of brackets-npm-registry using actual urls that npm itself calls (by debugging the client) and brackets-eslint is back in there ;)

@zaggino seems to work now!  If there is no intention to I might switch IDE sadly

@AdriVanHoudt doing progress of getting new node (and eslint 3.x support with it) into brackets: https://github.com/adobe/brackets/pull/12647

@zaggino following it and looks great!

@AdriVanHoudt this is now fixed in https://github.com/zaggino/brackets-electron/releases
still waiting for the team to approve changes to land in regular brackets too

Latest pre-release of Brackets supports this too: https://github.com/adobe/brackets/releases


[Service Bus] Enhance logging for session timeouts

Summary
The focus of these changes is to enhance the logs emitted when acquiring a session using the ServiceBusReceiver times out or is canceled.  As these are known and expected exception conditions, they should be logged as verbose information rather than an error.
References and related

ServiceBusClient.AcceptNextSessionAsync logs ServiceBusException as "exception" (not as verbose) after ServiceTimeout

API change check
API changes are not detected in this pull request.

/azp run net - servicebus - tests


Proposal: Explicit-only namespace strategy for RootSyncs

This proposal suggests adding support for an annotation configsync.gke.io/namespace-strategy, with values implicit (the default) or explicit. By setting the annotation to explicit, setups like #207 become possible without resource fights.

lgtm
Are you planning to implement. @tomasaschan?

Yes; we haven't planned the work yet, but I expect to be able to start working on it within a week or two.
It's not important to me to do it myself, so if you or your team would rather do it yourself, that's fine with me too - just let me know. It is, however, important to us that this feature is merged into main (a published release would be nice, but we'll build from source if we must) with enough time for us to roll it out across all our clusters before 1.24 is EOL. I suspect the best way to guarantee that is to do the work myself :)

Looks like Sam beat you to it. https://github.com/GoogleContainerTools/kpt-config-sync/pull/883


Traceback at the end of the program

Done! :)
Traceback (most recent call last):
  File "server.py", line 183, in <module>
    full_rescan(args.mpd_root)
  File "server.py", line 98, in full_rescan
    last_modified = client.find("file", song)["last_modified"]
  File "/usr/lib/python3.5/site-packages/mpd.py", line 629, in decorator
    return wrapper(self, name, args, bound_decorator(self, returnValue))
  File "/usr/lib/python3.5/site-packages/mpd.py", line 254, in _execute
    return retval()
  File "/usr/lib/python3.5/site-packages/mpd.py", line 623, in decorator
    return function(self, *args, **kwargs)
  File "/usr/lib/python3.5/site-packages/mpd.py", line 422, in _fetch_songs
    return self._fetch_objects(["file"])
  File "/usr/lib/python3.5/site-packages/mpd.py", line 410, in _fetch_objects
    return self._wrap_iterator(self._read_objects(delimiters))
  File "/usr/lib/python3.5/site-packages/mpd.py", line 374, in _wrap_iterator
    return list(iterator)
  File "/usr/lib/python3.5/site-packages/mpd.py", line 332, in _read_objects
    for key, value in self._read_pairs():
  File "/usr/lib/python3.5/site-packages/mpd.py", line 311, in _read_pairs
    pair = self._read_pair(separator)
  File "/usr/lib/python3.5/site-packages/mpd.py", line 302, in _read_pair
    line = self._read_line()
  File "/usr/lib/python3.5/site-packages/mpd.py", line 287, in _read_line
    raise ConnectionError("Connection lost while reading line")
mpd.ConnectionError: Connection lost while reading line

Fixed by https://github.com/Phyks/Blissify/pull/12.

Fixed by https://github.com/Phyks/Blissify/pull/12.


[CSL-1265] Integrate SCRAPE

Currently tests don't pass because pvss-haskell seems to be broken.

Okay, now tests pass.
One of the bigger changes in this PR is that now VSS keys are sorted and everything is expected to be sorted by VSS pubkey (shares, etc). Hopefully this doesn't break anything.

Also don't merge it before I test it locally (run e.g. 8 nodes, kill some of them, see if all secrets get recovered successfully).

I don't mind if you leave this version, but I would like to know the reason if it exists.

I assumed that getRichmenFromLrc relies on the rollback to give the right answer. If it doesn't, I'll change it.

Why did you simplify this comment? I think the previous version was fine and more descriptive :)

Okay, will unsimplify.

I assumed that getRichmenFromLrc relies on the rollback to give the right answer. If it doesn't, I'll change it.

I don't understand it very well so I'll be thinking out loud. “Richmen for epoch N” means “richmen that are to be used during epoch N” = “richmen as calculated at the crucial slot for epoch N” = “richmen at a particular point during epoch N-1”. Correct?
Then, when we are at the beginning of epoch N+1, we'll be using richmen for epoch N. We already know them and don't need to do anything to calculate them.
Okay.

Meeeeeeeeeeeeerging...

Then, when we are at the beginning of epoch N+1, we'll be using richmen for epoch N. We already know them and don't need to do anything to calculate them, and the rollback won't change anything.

Yes, it seems correct, manual testing (demo) should confirm it.

All checks have failed, btw.

Note to self: is this ok?
Test.Pos.Lrc.Worker
  Lrc.Worker
    lrcSingleShotNoLock
SSC couldn't compute seed: NoSecrets for epoch epoch #1, going to reuse seed for previous epoch
SSC couldn't compute seed: NoSecrets for epoch epoch #1, going to reuse seed for previous epoch
SSC couldn't compute seed: NoSecrets for epoch epoch #1, going to reuse seed for previous epoch
SSC couldn't compute seed: NoSecrets for epoch epoch #1, going to reuse seed for previous epoch
      Computes richmen correctly according to the stake distribution right before the '8 * k'-th slot.

If you mean NoSecrets messages, then yes, it's totally ok.

We don't generate any ssc payload in tests.


openapi: Show api argument type in docs.

Currently the api docs do not specify whether a given api parameter
is to be specified in query or in path. Edit the docs so as
to show the type of argument right beside argument name.
As of posting, the design is basic.This PR needs some review
on design and then I will change it accordingly.

Can you post screenshots?

This is for query type arguments.

This is for the path type arguments.
We can probably set it to bold or italics or maybe put in a new line.

@orientor Thanks for working on this! Just a little nitpick, I'd recommend using uppercase for acronyms in your commit messages and descriptions (so API, not api). Apart from that, looks good to me! :)

Hmm, I'm struggling a bit with how this should work and whether this is necessary.  For path arguments, it's completely clear from the URL, so I'm not sure we add much.  I suppose all of those are required by structure.  Maybe we should just have the text be required in path be the text for those using the same orange styling we have for required?
Are all of our other ones query as the type?  If so, may not be worth saying it.

@orientor just wanted to check to make sure you saw this; I think my proposed change should be pretty minor.

@timabbott I must have been very drowsy when I read your message. I probably read the first and last line and then assumed the message said that the PR is unnecessary. I have however read it once again and now am pretty clear. I have made the required changes.
Screeshots:

Path argument.

optional query parameter.

Required query parameter.

@eeshangarg done

I pushed back here after doing a bit of refactoring to be stricter; this also reveals that the required values in zulip.yaml are wrong for some endpoints.  Can you fix that?  (I think test_docs will find all the problems on this form, since it 500s with invalid openapi data now)
The other conceptual change I made in addition to removing the ternary logic that was hard to read is avoiding mutating the OpenAPI data objects; since those are cached singletons, it's generally best to not mutate them.  I changed the type to Sequence[Mapping] to have mypy enforce that rule.

@timabbott @eeshangarg corrected the PR. All the new changes are in zulip.yaml expect for a single line change in bugdown: argument['required'] to its get variant.

This is great, merged, thanks @orientor!
And I'm glad we found a couple bugs in zulip.yaml by having this stricter check :)


Not possible to use the package with laravel v7

This is the message I get, when I try to install this library:
Your requirements could not be resolved to an installable set of packages.
  Problem 1
    - rinvex/laravel-categories[v5.0.0, ..., v5.0.2] require illuminate/console ^8.0.0 || ^9.0.0 -> found illuminate/console[dev-master, v8.0.0, ..., 8.x-dev, 9.x-dev (alias of dev-master)] but it conflicts with another require.
    - Root composer.json requires rinvex/laravel-categories ^5.0 -> satisfiable by rinvex/laravel-categories[v5.0.0, v5.0.1, v5.0.2].

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

Any idea how to deal with this?
Thank you!

@alinr you can try older version v4 which is compatible with Laravel v7 (but also compatible only with composer v1).


Estimating effective reproduction number Rt for different provinces across Canada

Some time-series charts plotting estimated daily values for effective reproduction number (covid-19) for Canadian provinces. I welcome questions and comments on it.

/preview

@anomal would you like to review as someone who is familiar with Canadian data?

Notebook Viewer view (better to include in the pull request to make it easier for reviewers): https://nbviewer.jupyter.org/github/ujs/covid19-dashboard/blob/ujs-rt-canada/_notebooks/2020_10_25_reproduction_number_canada.ipynb
Comments:

This is a predictive model--even though it is predicting the past/current reproduction number rather than predicting the future--so the following guideline should be activated:

Dashboards that present a predictive model will attract additional scrutiny and review. If models are too complex to be understood, or not presented clearly - we may decide it is not appropriate for this site. Furthermore, analysis containing predictive models will be displayed with appropriate warnings to set expectations.

I am not an epidemiologist, so I am not sure if this is the correct way to predict Rt. @hamelsmu Do you know someone who is, who can review?

I am not sure of the utility of Rt for non-epidemiologists, since according to the graphs, Rt was lower than 0.5, and even close to zero, for some provinces at some points in time, yet Rt shot back up to over 1 or 1.5 later on.

Why is settings.ini included?

@anomal , @hamelsmu - Just FYI, my notebook contains references to my model. I applied the model(which was originally applied to US data by Kevin Systrom) on Canadian data.

Is it normal for epidemiologists to calculate Rt for only a subset of the global population based on a specific geographic region, when there are still cases in the rest of the world that can influence the infection of the regional population?

@anomal Local Rt values provide useful information because regional epidemics vary based on many factors, mainly local policy measures like lockdowns, mandatory mask-wearing, travel bans etc. For example- in the US, the pandemic looks very different in California compared to Maine or Texas because of variation in statewide policies. Regional Rt values are used by epidemiologists and policymakers to make decisions about easing restrictions but this metric can have some drawbacks- it is not good at identifying local outbreak clusters impacting a very small subset of the population in the region. This Nature article is a good guide to understand Rt pros and cons.

Settings.ini as well as changes to other notebooks have been added to this PR, why is that?

Settings.ini as well as changes to other notebooks have been added to this PR, why is that?

@hamelsmu - The settings.ini file was added automatically when I used fastpages (it was inadvertent and I missed it). Also, in one of my previous notebooks, there was an inadvertent change in the python version info. So, do you recommend I make changes to this PR itself. Or, should I submit another pull request on a separate branch (you know, start from scratch to avoid unintended issues like the ones you discovered)?

@ujs You should make changes to this PR itself.
git rm --cached settings.ini

It might be good to add this file to .gitignore, so that other people don't accidentally add it, so .gitignore should have the following appended to it:
settings.ini

For the restaurant notebook, from my understanding of this, the following should work:
git checkout master -- _notebooks/2020_09_07_compare_restaurant_reopenings.ipynb

I don't have experience with Rt and can't comment on it further, so these are just technical comments.

changes made as requested

@ujs I'm afraid this dashboard in its current form is far too academic and doesn't contain information that is approachable for most people.
I encourage you to host this dashboard on your own site, perhaps using fastpages, and I'll be happy to link to it from the related page.
This is not a criticism of your work or how valuable it is.  I must do the difficult job of curating information on this site.  Thanks for understanding.


Set default status option to first element

Summary
Fixes an issue where status is required by the API; however, the CLI does not require it as an argument. The temporary solution is to set the first element as the default (in the case of the status, that would be TRIAGE_INFO)
Type
Bug fix
Context
Internal Slack discussion

A more general solution has been discussed to be implemented soon.

@seqre  -- thanks for triggering the discussion and ultimately, the product will be better because of that.


[Issue-2558] Fix issues related to earning

PR for #2558

🚀 Deployed on https://pr-2562--sw-web-runner.netlify.app


ie11 compatibility

hi,
i was testing this library on same browsers: chrome 56, firefox 51, edge and ie11.
everything works fine except in ie, showing this kind of error in console:

SCRIPT438: Object doesn't support this property or method
zooming.js (914,5)

i think this line break the script
this.options = Object.assign({}, OPTIONS);
thanks for your work!

@pkers87 Thanks for the feedback! Please check if the issue was resolved in IE.

it works! thanks!


The "processed_data.tar" data link is invalid.

Thanks for your great work!
I am very interested in PromptKD you proposed and tried to reproduce it. But I found that the processed_data.tar link is invalid and I can't download it. I would be grateful if you could re-upload your processed_data.tar , which would be very helpful to me.
In addition, if I want to replace it with my own training data, how should I organize my data format to meet the subsequent training requirements?
Looking forward to your reply ：）

Thank you for your interest in our research.
Firstly, since we share the same experimental settings as the MiniLLM paper, we also obtained the download link for the processed_data.tar file from the corresponding GitHub repository. Upon checking, it seems that the link has changed, and you can now download it using the following command:

wget -O processed_data.tar https://unilm.blob.core.windows.net/minillm/MiniLLM/processed_data.tar

Thank you for bringing this to our attention, and we will make sure to update our code accordingly.
Regarding the data format, please refer to the files in the processed_data.tar file. Each line consists of keys: instruction, input, output, and prompt. The prompt is structured as follows: “{instruction}, {input (if applicable)}, Response:”.
If you have any further questions, feel free to ask anytime.

Thanks for your kind reply! It helps me a lot.  :)


Migrate u32::from(TextUnit) as usize to .to_usize()

@matklad I see 29 uses of .to_usize() cast, wouldn't it be reasonable to change TextUnit(u32) to TextUnit(usize) ? Or do you have reasons to stick with u32 here?

Yep, TextUint  is intentionally `u32:

to save space on x64
to make sure that the limit on the file size we can process is independent of the architecture

bros r+

bors r+


Accordion Component not working

I have not edited or tweaked anything with the original material accordion component. Please see my screencast video so that you will come to my issue better.
http://screencast-o-matic.com/watch/cDVX14hpfe
After clicking the accordion. its not opening. its opening and closing  in a fraction of milli seconds.

Can't replicate it. Do you see such issue on kitchen sink demo and does it happen on real device?

kitchen sink demo is working fine. All js,css files for both my project and kitchen sink are same.  No, I have not tested in real device. But  "accordion-item-expanded"  css class is not appending in my project while it does in kitchen sink demo.

then something is wrong. Would be good to see live example then

http://goo.gl/NNQAar   Click on "daily products" menu to see accordion.

You have initialized F7 twice! You shouldn't do it:
// Initialize your app
var myApp = new Framework7();

var myApp = new Framework7({
    swipePanel: 'left',
});

Very Thanks.!


cordova: how to read csv from local dir

my csv reading codes refuse to work, no error in stacktrace, just quit silencely, I want to know why
//var csv = 'content://com.android.externalstorage.documents/document/primary%3ADownload%2Ftest1.csv'
var csv = 'file:///storage/emulated/0/Download/test1.csv'
alasql('SELECT count(1) from csv("'+csv+'",{headers:true}) ',[],function(data){
alert(JSON.stringify(data))
})
but I can load this file by using $.get()
somebody said this can be done by parsing csv manually into a json, but ... is that way we expected?

How are you including alasql?
Are you using the version for the browser? If not, please try the one that supports a filesystem: https://github.com/agershun/alasql/blob/develop/dist/alasql.fs.js

Thanks for your advice, I am now using latest fs version:

but still doesn't work, no error msg,
is the path something like my format 'file:///storage/emulated/0/Download/test1.csv' or  'content://com.android.externalstorage.documents/document/primary%3ADownload%2Ftest1.csv'
I found a sample code: https://github.com/agershun/alasql/blob/develop/examples/country/city.js
do I need to implement a function of alasql.from.csv as below?
alasql.from.csv = function(filename, opts){
...
return {rows:aaa, headers:h};
}

I tried some console logs, as you introduced in another thread:
Environment detected:
{
"alasqlPath":"",
"isBrowser":true,
"isCordova":true,
"isMeteor":false,
"isMeteorClient":false,
"isMeteorServer":false,
"isNode":false,
"isWebWorker":false
}",

@mathiasrw
I found a workaround by using fromString:
$.get(csv,function(data){
var sql = 'SELECT count(1) from csv(?,{headers:true,fromString:true}) '
alasql(sql,[data],function(result){
alert('alasql.count(1) = '+JSON.stringify(result))
})
})
thanks for your help, but I would like to keep it open, as the other situation like from xlsx is still not working with fromString option


make setup-and-deploy target fails

edv check health is failing

https://github.com/trustbloc/k8s/pull/275