What are "bot left the game", "bot joined the game", "server pause" and "sever unpause"?

In mc_port mode, I found "bot left the game", "bot joined the game", "server pause" and "sever unpause" are shown in the game text. What are "bot left the game", "bot joined the game", "server pause" and "sever unpause"? Why is it needed to make the bot left the game and joined the again and again?

Hi, for bot left and join, you can refer to FAQ
For server pause, it's used for waiting for the GPT-4 to reply.

Hi, for bot left and join, you can refer to FAQ
For server pause, it's used for waiting for the GPT-4 to reply.

Thanks!!!


About GGX Renderer

Hi，
I read the code and am confused about the BRDF implemented. Why the diffuse_rgb is compute like this:https://github.com/Kai-46/IRON/blob/8e9a7c172542afd52b8e6ef28bc96ad52b5ffd5a/models/renderer_ggx.py#L105, but not: light_intensity * (diffuse_albedo / np.pi) ? Could you introduce the meaning of other variables you used(Fdr, T12, T21, m_invEta2)? If the light and camera are not colocated, how to get the T21, T12?

These equations are what we inherit from the Mistuba renderer.


Setting the PR status to "needs work" if there is a [WIP] in the title

This was suggested by @WouterJ at https://github.com/carsonbot/carsonbot/pull/34/files#r64140653

I think a PR wether WIP or not (same for PoC) stated by the author may need a status needs review OR work depending on appreciations from reviewers. I suggest to not mix the concept.

Makes sense :)


Lyrics Plugin: DarkLyrics support

This is not ready yet, for lots of reasons, but the major one is that I'm waiting to hear back from the DarkLyrics folks about rate-limiting. The code as written works for about 15 songs, and then darklyrics blocks further requests from the same ip address for an unspecified time.
I also need to add documentation and testing, but I want to at least get this out there.

Looks great! And adding album to the set of information passed to backends seems like a good idea too.

I would suggest no one else use this, as I have gotten my current IP banned/rejected for too many requests. I have emailed the fine folks at Darklyrics about it, but they haven't responded, so who knows? Either way, watch out. :cry:

:cry:


Customized dashboard to show progress.

Continuing the conversation since the previous issue was closed.
What I mean is show the pipeline on Dashboard.  For example I have multiple application I want to track their process at one place. Since we are pulling all results here We can show it on one dashboard. (We have a requirement to pull data from different jenkins servers and show status on one page. The jobs are interlinked with each other)
This just my Idea and can be altered based on limitations we have in this tool.
This will be the top page for all applications.

This will be the details of individual application.

The dashboard you are outlining above is not part of the jenkins-stats tool - I think you want to raise your query through one of the forums for Jenkins itself on https://jenkins.io/participate/


Tsan: fix data race on ComputeServerRunner.cancelJoinTasks

What problem does this PR solve?
Issue Number: close #7432
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/merge

/cherry-pick release-7.1


Handle null

Optional fields, Option[A] should either give a string representation of A or an empty string, not "".

For optional fields, the representation is the representation of A in case of Some or the empty string in case of None:
scala> import purecsv.safe.converter.StringConverter
import purecsv.safe.converter.StringConverter

scala> val conv = StringConverter[Option[Int]]
conv: purecsv.safe.converter.StringConverter[Option[Int]] = purecsv.safe.converter.defaults.string.package$$anon$2@17232a4e

scala> conv.to(None)
res5: String = ""

scala> conv.to(Some(1))
res6: String = 1

scala> conv.from("")
res7: Option[Int] = None

scala> conv.from("1")
res8: Option[Int] = Some(1)

The fields is still there because csv "standard" allows to have empty fields to accommodate the fact that csv is tabular. For instance:
scala> import purecsv.safe._
import purecsv.safe._

scala> case class Foo(opt: Option[Int], d: Double)

scala> Foo(None, 1.1d).toCSV(",")
res20: String = ,1.1

is the correct behaviour.
If you have optional field in the sense that you don't want them to be in the output, comma included, you can't do it right now because PureCSV doesn't support yet sealed families of case classes. In future it should be possible to do
scala> import purecsv.safe._
import purecsv.safe._

scala>:paste
sealed trait BaseTrait
case class Foo(i: Int, d: Double) extends BaseTrait
case class Bar(d: Double) extends BaseTrait

scala> Seq(Foo(1, 2.0d), Bar(3.0d)).toCSVLines(",")
1,2.0
3.0

scala> CSVReader[BaseTrait].readCSVFromString("1,2.0d\n3.0d")
Foo(1, 2.0)
Bar(3.0)

:+1:  Thank you!


feat(core)!: separating core.ip into core.grpc.ip and core.rpc.ip

Closes #2931, although I fail to understand the requirements for the second todo, so can add next.
Breaks config by changing core.IP -> (core.RPCIP, core.GRPCIP).
We keep the --core.ip flag, which lets the user set both IPs at once. But it cannot be passed together with either of the new flags.
Failure cases:

What do you mean by IP switching? ParseFlags?

replaced by #3242


Refactor to use Timeout for server selection

JAVA-5175
This uses Timeout for timeout logic, and ensures that settings are obtained from one location, for consistency with how settings will be obtained from the recently-merged TimeoutSettings (though, this is not used, as it is not yet propagated into OperationContext).

Looking good - much easier to read, couple of comments / questions.


Report 4-n

An example of the report format can be found using the current Aggregate tool or the current Disclosure tool.

Closed by #49


fix: Not is possible create iam_role_statements with awsvpc or without load balancer

Description
Is not possible create iam_role_statements with awsvpc or without load balancer
Motivation and Context
Create iam_role_statements with network_mode = awsvpc and no load balancer
Breaking Changes
No
How Has This Been Tested?
Yes

I din't understand why check "Pre-Commit / Max TF pre-commit (pull_request)" failed.

What are you trying to do, and what challenges or errors are you running into?


Remove a pointless try-catch

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable
[x] Documentation in docs/ or install-docs/ was updated, if applicable


[TS-4129] Support TSContSchedule in ts_lua plugin

@jpeach , pls help to take a look.

nice catch on both cases. let me update the PR over the weekend after some tests on the new code.

I just updated the pull request. @jpeach, pls take a look. Thanks.

A couple of functions will result in LUA_YIELD, such as sleep() and fetch(). And they all have schedule event to happen through their handler and those handler will eventually do the duty of TS_LUA_EVENT_COROUTINE_CONT.

@jpeach , any other advice?

before i merge?

+1 merge it


bug: line comment cannot be parsed

Give a very simple example, if I add a // followed by a newline to a correctly written contract, current version gives ParseError with message extraneous input \'/\' expecting {<EOF>, \'pragma\', \'import\', \'contract\', \'interface\', \'library\'} (1:0). This happens regardless where the comment is put.

Hi @yxliang01, can you provide a complete code example that fails? I could not reproduce this.

@federicobond As requested:
//
contract SmallTest {
    uint256 public x;
    bool yes = false;

    constructor () public {
        x = 10;
    }

    function getX(uint256 a) public returns(uint256) {
        if (yes == true)
            return x  + 1;
        else
            return x + 2;
    }
}

In contrast, the following can be parsed successfully.
/**/
contract SmallTest {
    uint256 public x;
    bool yes = false;

    constructor () public {
        x = 10;
    }

    function getX(uint256 a) public returns(uint256) {
        if (yes == true)
            return x  + 1;
        else
            return x + 2;
    }
}

Sorry, I am still unable to reproduce it :(
Can you provide an full example similar to this one that fails?
https://runkit.com/federicobond/test-parser

Hmm sorry that after debugging, I realized that the file content in memory has // all replaces with /. Looks like it has something to do with the inter-component communication of my system. Sorry for the false bug report. @federicobond

No worries.


config.json entry "websocket_server"

what does the "websocket_server" variable in config.json do exactly? i've searched trough the code but could'nt find anything. is it something from a time long lost or is it to enable the SimpleHTTPServer from the main app later on?

Seems to have something to do with logging. Possibly a feature yet to be added
Added in commit 2805cb75be3d30de272095675316f1bf9138b639

I dunno, the fact that they added flask to the requirements.txt plus added the host/port config the same commit probably means they may be doing away with the extra web service for monitoring and have it built into the bot, much like the python poke maps.


add support for document color

I added support for named document colors.
Steps to get name:

Try to get name from document color
Try to get alias color name
Finally, use the color classifier.

I added to edit a name of document color inside colorNameChanged as well.
Consideration
My understanding is there was no "named document color" feature on Sketch itself when Prism came out. However now Sketch has "named document colors" since Sketch v53. So how to manage colors inside Prism is time to change MSColor based to MSColorAsset base.
It could be significant change so I didn't change now, but we may consider to change design.
Related Issue
#43

Any chance these pull request could be actioned?

One issue with this @griffin-stewie is that if I have 2 named colors that happen to have the same hex value, the second color will be named the same as the first one. when using named colors there is always the chance of having multiple versions of the same color with the same name.

As an example the image has a transparent color which is White with 0 alpha, it is also naming the White at the bottom with 100 alpha Transparent. There is 2 greys as you can see too, the second one is named "Selected" in the named color list but it gets assigned Grey a second time.

@custa1200
Is what you're calling "Named Color" the content of this link? or what you named them on the Prism's artboard?

@custa1200
I'm starting to get it.

As an example the image has a transparent color which is White with 0 alpha, it is also naming the White at the bottom with 100 alpha Transparent.

This case of bug is able to fix it easily.

There is 2 greys as you can see too, the second one is named "Selected" in the named color list but it gets assigned Grey a second time.

In this case, it will not be easy to fix due to the impact of the original implementation. I would try to fix but it would be breaking change.

It's "almost" perfect. I also made a formatter for the Hex + Alpha too, I might do a pull request for that.

@griffin-stewie would the second one be worth doing and looking to add it to a 2.0 release?

@custa1200 Unfortunately, I'm just a contributor so I can't judge the release.
I think I need to take a closer look at the sphere of influence where I feel it's a problem. I am willing to make changes to this Pull Request if the problem is less severe than I was concerned about.

The owner hasn’t picked up your pull requests for a while :( should I spin this out to an issue to track outside this PR?

@custa1200
I pushed some commits to fix problem you mentioned. Could you try this?

I tried it out and it worked a treat @griffin-stewie I would say that handles all the color naming issues for me.

@custa1200 I’m glad to hear it! Thank you for testing it.


Memory Problem

I have 32 GB for the memory, but when I tried your code, the program takes the whole memory after several  batches. I am not sure why the program requires so large memories....
My environment is keras 2.06, python 3.6; with CPU mode.

I also meet the problem,it used more than 2200 cpu ,I do not know why it use so much cpu.

Same issue

same issue

same issue

same issue


Add new baseline profile plugin

This updates to the new baseline profile gradle plugin and many of the things we get with it. This is using the docs described here.
Note that the crazy high line count is just because of the generated profile files. The actual code changes involved are fairly simple and straightforward. I'd recommend reviewing with this view (without the generated profiles).

Use a Gradle plugin to automate much of the wiring.

The samples/star/benchmark project is the source of the baseline profile generation
The samples/star/apk project uses the entire startup baseline profile produced
Each of the circuit core artifacts + overlay/retained consume slices of the produced profile targeting their namespace.

baseline-prof.txt files have all moved to the new canonical source location under src/{variant}/generated/baselineProfiles
Removed the old manual splitter script
Set up a GitHub actions workflow to make updating these easy. Eventually I think we want to make this run as an automated action (nightly?) or part of releases.
Update the STAR sample to work in release builds too, which I guess we hadn't tested yet and weren't using for previous baseline profile gen. Just required a couple R8 rule fixes.

Well shoot, it looks like GMDs just don't work on github actions CI, unless you maybe pay for a larger runner. Seems like a big miss


ADFS DNS name should be a FQDN and NOT an IP address

During the creation of the configuration file, users are asked for the ADFS external DNS name.  There is no prevention to detect an IP address as opposed to an FQDN.  FQDN's should be used and IP addresses should be prevented.

not encountered as a problem. closing as won't fix


fix(VERSION): delete VERSION file from repo (#94)

Signed-off-by: mittachaitu<EMAIL_ADDRESS>
What this PR does:
This PR is cherry-pick of https://github.com/openebs/cstor-csi/pull/94
which fixes the version in labels.
Which issue(s) this PR fixes:
Fixes #https://github.com/mayadata-io/oep/issues/46
Special notes for your reviewer:

After merging https://github.com/mayadata-io/cstor-operators/pull/1
then we have to merge it.

Checklist

[ ] PR messages has document related information
[ ] Labelled this PR & related issue with documentation tag
[ ] PR messages has breaking changes related information
[ ] PR messages has upgrade related information
[ ] Labelled this PR & related issue with requires-upgrade tag
[ ] Tests updated

Codecov Report

Merging #1 into v1.11.x-ee will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           v1.11.x-ee       #1   +/-   ##
===========================================
  Coverage       63.88%   63.88%
===========================================
  Files               7        7
  Lines             335      335
===========================================
  Hits              214      214
  Misses            108      108
  Partials           13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6b0e5...f6b4bce. Read the comment docs.

Closing this PR's PR should be raised against the release branch of openebs/cstor-csi repo.


Feat: Take Yer Lumps casualties selection improvement

Taking casualties in the "Take Yer Lumps" step of shootout needs to be improved. Currently it is not even according to rules.
Rules:

The player selects and announces which of their dudes will be aced or discarded, and then resolves them one at a time in the selected order (so if a card effect forces a dude to be selected as the first casualty, they must also be resolved first).

Current behaviour:
User is prompted with options to "Ace", "Discard", "Send Home". They do this one by one and not select first execute later as it is in rules. That also results in a weird situation in case some dude has to be first casualty.
Also check if the Takin' Ya With Me and Shield of Faith cards work correctly with the updated casualties selection.
Another note: When 2 different things "have to be chosen as first casualty", the game just force-picks one of them.
Player should be able to choose.

An additional thing to eventually fix:
A dude can be selected to be discarded even if they should be required to be aced (i.e. they are the only dude in the posse and they have to cover 2 or more casualties)

Rules for the Take Yer Lumps step have been changed slightly.
Current rules:

Starting with the loser of the
round, players must discard or ace dudes and/or Sidekicks in their posse to satisfy their casualties. On the
rare chance the round was an absolute tie with identical draw hands, apply casualties simultaneously.

Choose and apply your casualties one at a time.
Remember that cards attached to an aced or discarded
dude are sent to their owner’s discard pile.

 Discarding
a card in your posse with the Sidekick keyword covers
1 casualty.

Harrowed dudes have slightly different rules for
casualties. Sending a Harrowed dude in your posse
home booted covers 1 casualty, discarding them covers
2 casualties, and acing them covers 3 casualties.

  You
must do all that you can to suffer your 4 casualties,
which in this case means acing both dudes (to cover
4 casualties).

Therefore current way the step is performed is more or less correct. What should be updated is how the first casualties are selected, and add a way to calculate possible casualties to prevent player from for example discarding when they should ace.


Call cbindgen manually

This PR moves generation of C API headers for qdk_sim_experimental from build.rs to a manual step. This avoids https://github.com/eqrion/cbindgen/issues/560, allowing for cargo package to proceed and fully verify the qdk_sim_experimental crate.

Thanks for the approval, @swernli! Since the e2e build logic needed to validate this PR is still only on the feature branch, and since merging from the feature branch to main will require a new cross-repo build anyway, any objections on merging to this to the feature with only a local build passing? Thanks!

Seems reasonable to me! Feel free to merge to the feature branch.


Panic when using coio::sleep_ms

rev: 8d3f9fa03a356286
The following program panics and outputs
Routine 1: 0
Routine 2: 1
thread 'Worker 0' panicked at 'Box<Any>', coio-rs/src/runtime/processor.rs:484
thread 'Worker 0' panicked at 'Box<Any>', coio-rs/src/runtime/processor.rs:484

extern crate coio;
use coio::{spawn, Scheduler};

fn main() {
    Scheduler::new().with_workers(1).run(move|| {

        spawn(move || {
            for i in 0..10 {
                if i % 2 == 0 {
                    println!("Routine 1: {}", i);
                    coio::sleep_ms(2000);
                }
            }
        });

        spawn(move || {
            for i in 0..40 {
                if i % 2 != 0 {
                    println!("Routine 2: {}", i);
                    coio::sleep_ms(500);
                }
            }
        });

    });
}

Well, this panic with Box<Any> is because the main function is already exited and going to force all spawned children to unwind the stack. So this behavior is absolutely correct.
You must use .join() to keep the main function waiting until all the spawned coroutines exit.

I see, thanks.


Fix nextjs.mdx typo

name: :memo: Documentation Fix
about: Fixing a problem in an existing docs page
Checklist

[ ] Is there an existing issue for this PR?

link issue here

[ ] Have the files been linted and formatted?

What docs page needs to be fixed?

Section: https://redux-toolkit.js.org/usage/nextjs#overall-recommendations
Page: https://redux-toolkit.js.org/usage/nextjs

What is the problem?
Typo in 'architecture'
What changes does this PR make to fix the problem?
Add missing letter

thanks!

thanks!

Thank you as well!


👽 Set up outputs in Brainlife to specific types

Related problem

Currently C-PAC on Brainlife outputs "raw" "c-pac" data:

Proposed feature

Now that we have BIDS Derivatives outputs in C-PAC, we can specify multiple outputs in Brainlife to afford chaining Brainlife apps after C-PAC.
Alternatives

contact #datatype channel on brainlife.slack.com to register new datatype
― https://brainlife.io/docs/apps/register/#raw-datatype

that incorporates all of C-PAC 1.8's outputs in one datatype?

Seems like there are a lot of options here, looking at their examples.
I think it may be worth to at least separate into anat and func, much like how the directory structure is in BIDS.
However I see it may be a good idea to specify masks, etc. - maybe another option is setting it up so that the suffix of the outputs are set as the data type? So, _T1w, _bold, _mask, _timeseries, etc. (obviously without the _).

Looking more at this:

You can add specificities / context to the selected datatype. For example, the above screenshot shows this App outputs anat/t1w datatype with a tag acpc_aligned. If there is an App that only works with ACPC aligned anat/t1w as an input data, it can specify the same tag as a required input datatype tag to be more specific about its input data.

Sounds like it may also be feasible to make a data type for every unique resource label we have in C-PAC? Like desc-preproc_T1w, space-T1w_desc-brain_mask, etc.?
If I understand that right, it would be worth seeing if there are other Brainlife.io compatible apps that are already using BIDS-Derivatives and getting a sense of how they've named their outputs. Because it looks like the point of creating these tags is to facilitate interoperability.

I second the idea to register separate output data objects - much like the fmriprep app (https://brainlife.io/app/5c61c69f14027a01b14adcb3) You can go ahead and register anat/func as new outputs and update the main script so that it will organize (or symlink) the output files under various sub directory / expected file names. For example, if you register anat output to be stored anat sub directory, then you can setup this directory at the bottom of main script and symlink it from the output directory.
#expose output t1 as brainlife's neuro/anat dataype
mkdir -p anat
ln -s output/somewhere/t1.nii.gz anat/t1.nii.gz

And yes, you can set whatever the datatype tag to add specificity/context to the datatype. But I recommend making those an official datatype tags for neuro/anat by consulting in #datatype channel. In brainlife, we don't really call our output "derivatives" like BIDS does, because most App works on output from other Apps. You can start out by having no datatype tags, and when developers identify issues, data incompatibility, then we add datatype tags to prevent certain issues from happening.

Related:

https://github.com/brainhacknyc/2021/issues/5


Add ValueTask support to API Explorer response types.

Response type handling interprets ValueTask as it does Task.
Addresses #4883

Some sort of unrelated SocketException showing up in one test on the main CI build.

@tillig could you rebase this change on the release/3.1 branch?

Sure thing, will rebase.

This is, uh, not quite as easy as it's appearing for a couple small changes in two files. Conflict after conflict. If I can't get this, I may have to create a new PR that starts with the right branch.

@tillig might be easier to cherry-pick your commit on release/3.1 and force push

Yay for cherry-pick! I think I got it. Let me know if it appears I hosed it up. 😊

Looks great. Thanks!

Thanks for the PR.


Removed Storyscript

Issue Number :
.
.
.
Modified File Path :
.
.
.
Description : Removed Storyscript(line 148) as no such website exists as of now.
.
.
.
Mentions :
@ShreyamMaity

Unable to find story.ai website. Maybe it also doesn't exists.

seems like their website is not working anymore.
https://www.linkedin.com/company/storyai/
here is their linkedin page

Thanks for the update. Since it's not working anymore, I am not adding it.

Yea sure.


Better type definition for TestMatch

Here TestMatch type is defined as really generic object | null, but if we look at the code in the urlTest method (which computes and returns the TestMatch) the right definition should be {[k: string]: string} | null (a map instead of an object).
I guess that this would be a breaking change, even if only for Typescript users, and it will lead to bumping the major version of the package.
PR very soon ;)

Type def fixed in #42


Version compatibility for Python 3.12

I've made a conda environment based on Python=3.12.0, then I ran pip install relbench and failed with an error like: ERROR: Could not build wheels for duckdb, which is required to install pyproject.toml-based projects.
It's caused by a lack of support for Python 3.12 in DuckDB 0.9.2(refer to StackOverFlow), can easily fixed with execute pip install duckdb --upgrade --pre before pip install relbench.

Thanks for reporting. From your StackOverflow link: "It will be included in version 0.10.0, released in a few weeks."
We will just wait for duckdb to support 3.12 in an official release. Meanwhile, folks can use the pip install workaround you mentioned or stick with an older python version.


[REQUEST] import multiple wordlists in OB2

I hope the next update will include this feature, as it is really helpful

just work UTILITY BLOCKS


Clarification : Fixed feature vectors

Please correct me if I'm wrong :

Feature vectors are word embeddings, for each token of the input file.
These vectors can be used as ELMo / GloVe : as a base for a bigger neural network.

If these assumptions are right, here is my question :
From the use example :

python extract_features.py
...
--layers=-1,-2,-3,-4
...

Why would anyone be interested in features vectors from others layers than the last one ?
From my understanding, feature vectors from the last layer are complete. Feature vectors from other layers are not complete.
'Complete' is obviously the wrong word here, due to my lack of vocabulary / knowledge.
By the way, BERT is really amazing, congratulations and thank you for sharing it.

See section 5.4 in the paper: https://arxiv.org/pdf/1810.04805.pdf
tldr; better results from grabbing last 4 than just last 1.


init 1st stage - 5 levels

create 5 levels with some pre-made assets, each level should be bigger than before.
just focus on assets - integrate them into the game later

1: small town
2: large town
3: small city
4: med city
5: large city


WIP: Added option to suppress the sending of 502 Bad Gateway response…

…s if the server is not responding
Description
My usecase is to use the proxy in between of a web application scanner and a web application under test. If the web application under test crashes, mitmproxy will send 502 Bad Gateway responses. These responses are irritating the web application scanner since they obfuscate the actual problem.
I propose an additional option with which a user can suppress the 502 error responses. For this, I added teh necessary option. Since the 502 responses are sent deeper in the code, I changed the HTTP code such that it will no longer send the 502 responses itself but it will now re-raise the corresponding exception. The exeption handlig will be done in the ProxyServer as before.
Is this a suitable way to reach that goal? Do you have any suggestions or comments on that?
Checklist

[ ] I have updated tests where applicable.
[ ] I have added an entry to the CHANGELOG.

That generally sounds like a valid use case we should support!
Regarding the specific implementation, I think the better approach would be to write an addon that calls flow.kill() in the error hook:
def error(flow):
    flow.kill()

Would that work for you?
I'm not sure if that works properly on master to be honest, but I have just verified that it works on our new sans-io proxy core (#1775), which will likely ship soon.

Yes, I think that additional addon would work for this usecase!
Which directory would you prefer for the addon?

Great, https://github.com/mitmproxy/mitmproxy/tree/master/examples/contrib please, thanks! 😃

Awesome, thanks for the quick turnaround!


Logo proposal

Hi @afshaan4  I am a graphic artist and I would like to design a logo for your project for free. I am improving my portfolio and I want to contribute at the same time. :)  If you are interested and will allow me, I will begin asap. Thanks! - Tobaloidee

Sorry but I don't think I need a logo for this, its just a small script I made for fun.


App crash while using search

About this discussion
I am getting app crashes when using the search in the app. In particular when searching for mapped components on the default camera icon.
Version: 2.11.0
Steps to reproduce:

Go to search in app
Check "Component name" filter/option
Search for "gcam92"
App crashes

I've tried different strings and haven't nailed down a specific pattern that makes it crash. But here is an example log I get the rare times I do get a crash/error dialog
type: crash
osVersion: google/panther/panther:14/AP2A.240805.005/2024080600:user/release-keys
package: app.lawnchair.lawnicons:15
process: app.lawnchair.lawnicons
processUptime: 18599 + 236 ms
installer: com.looker.droidify

java.lang.IndexOutOfBoundsException: index: 0, size: 0
	at u3.k.x(Unknown Source:15)
	at P2.j.get(Unknown Source:4)
	at I2.a.K(Unknown Source:126)
	at N1.x.k(Unknown Source:260)
	at U.a.b(Unknown Source:43)
	at U.a.k(Unknown Source:8)
	at D.G.l(Unknown Source:261)
	at U.a.l(Unknown Source:51)
	at e2.c.e(Unknown Source:690)
	at e2.c.d(Unknown Source:186)
	at I2.a.N(Unknown Source:589)
	at N1.q.l(Unknown Source:111)
	at U.a.l(Unknown Source:51)
	at M.q.G(Unknown Source:437)
	at M.q.P(Unknown Source:28)
	at u3.k.m(Unknown Source:293)
	at u3.k.n(Unknown Source:78)
	at I2.a.M(Unknown Source:347)
	at I2.a.J(Unknown Source:171)
	at P1.q.l(Unknown Source:179)
	at U.a.l(Unknown Source:51)
	at M.q.G(Unknown Source:437)
	at M.q.N(Unknown Source:136)
	at M.q.p(Unknown Source:243)
	at M.q.E(Unknown Source:31)
	at M.v.w(Unknown Source:22)
	at M.z0.q(Unknown Source:107)
	at M.x0.p(Unknown Source:539)
	at M.D.doFrame(Unknown Source:13)
	at y0.U.doFrame(Unknown Source:47)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1404)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1415)
	at android.view.Choreographer.doCallbacks(Choreographer.java:1015)
	at android.view.Choreographer.doFrame(Choreographer.java:941)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1389)
	at android.os.Handler.handleCallback(Handler.java:959)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8623)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
	at com.android.internal.os.ExecInit.main(ExecInit.java:50)
	at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
	at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:369)
	Suppressed: W2.f: [M.l0@f916283, y0.w0@13d0c00, p0{Cancelling}@8a64c39, V@71e027e]

Thanks for making this issue. I plan on fixing this as soon as possible, but might take a few more days.

Re-opening this issue with a label, until we release Lawnicons 2.12.0


Allow expanding folders in the navigation pane

What's the Problem?
I like to see and work with the folders in my OneDrive and This PC. Windows File Explorer has those two folders expanded in the navigation pane by default when I open a window to show Documents, Pictures, Videos, etc. in both of those folders. Files, on the other hand, has no option to expand in the navigation pane other than Favorites, Drives, Cloud Drives, Network Drives, which in and of themselves are useless other than to expand and show the folders or local drive or whatever in them, but will not expand those folders at all. That is my major downside with this app, because I don't want to use Favorites for the folder one directory in OneDrive to This PC. Granted, they show up in Home, but I'd rather be able to jump around between them in the left navigation pane. Poor use of the navigation pane if it can't expand at all either.
Solution/Idea
Enable expanding at least one level to reveal Documents, Downloads, Pictures, Videos, etc. in the left navigation pane for each drive including Home since it is the replacement of This PC in File Explorer.
Alternatives
Adding each folder to favorites could be an alternative, but I like to reserve favorites for the few folders I access regularly that are buried halfway down inside other folders instead of putting all the main folders from This PC in there.
Priorities

Capability
Priority

This proposal will allow end users to expand the main drives at least one level in the navigation pane
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow end users to expand to any folder in the navigation pane just like Windows Exploror
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
Version: <IP_ADDRESS>
Windows Version
Windows 11 Pro 21H2 22000.469
Comments
No response

Could you check if enabling "show libraries on the sidebar" from Settings > Appearance > Sidebar does about what you need?

@gave92 I know about libraries in Files and File Explorer, and that serves its own purpose which is similar. While that may potentially give me all the folders I need, it would be blending the local and OneDrive together (viewing folders in This PC`VideosandOneDrive\Videostogether in oneVideoslibrary folder). While a couple of those folders are the same like Documents, I still just want to be navigating between the folders of OneDrive and the folders ofThis PC (Home), which is where I base my navigation and my organization of files. I want to click right into Downloadswhen I'm buried inDocumentsor jump fromDocumentstoMusic. Another thing is that Downloads, for example, is not in the Libraries` pane.

We don't have plans to add a tree view pane but we're tracking requests for a tree view layout in #1928


Build Delegate Feature and Form

Details
Reference this design/discovery ticket:
https://github.com/HausDAO/daohaus-monorepo/issues/206
Figma:
https://www.figma.com/file/9lCwprCNaoAmUDmiMQpFEA/DAOhaus-v3?node-id=2939%3A22133
Uses the modal component.

2 alternate headlines 'Add'/'Manage'

Add if there is not already a delegate
Manage if there is already a delegate

Accessed from:

member list - Delegate to link
my profile page - manage delegate link

Delegate to field

address input
can pre-populate the field if opened from a member list element
when managing an existing delegate it can populate with the current delegate address

Member indicator

if the address is a member, display their avatar/name (if these exist) and member tag
If not a member, do not display member tag, but return avatar and name from ceramic/ENS if possible

Voting token to delegate

lists logged in members totalShares balance
calculates the voting power

Remove delegate button

populates the address field with the logged in user's address and triggers transaction

Transaction details
contract: sharesErc20
function: delegate
args:

delagatee (address that will be the new delegate)

For: "Remove delegate button - populates the address field with the logged in user's address" - I was thinking pressing this button would close to modal and set it to the logged-in user in the background, but we should probably discuss this interaction a little more -- I'm interested in hearing what behavior other people would expect.
For the member indicator, since non-members can also be delegates, should we expand the avatar/input that is returned to be anything that is available through ceramic/ENS for all addresses, including non-members?

@7helles @brossetti1 and @dekanbro made some updates to the contract last week and may need to discuss the UX with you

@skuhlmann I have a few UX suggestions and would like to know what you think --
For: "Remove delegate button - populates the address field with the logged in user's address" - I was thinking pressing this button would close to modal and set it to the logged-in user in the background. Perhaps after signing the transaction, a success toast could show with the words "Delegate successfully removed."

I think this makes sense - we can make the click of that button populate the field and trigger the transaction.

For the member indicator, since non-members can also be delegates, should we expand the avatar/input that is returned to be anything that is available through ceramic/ENS for all addresses, including non-members? This could perhaps be the same behavior as the Member component Adrienne wrote out here https://www.figma.com/file/9lCwprCNaoAmUDmiMQpFEA/DAOhaus-v3?node-id=6242%3A136826

In the delegateOf column? Yeah we can use that member component in those places. FYI we are still working on some data caching solutions for this - so some of them are using address display components for the meantime.

I'm moving this to Ready, think it's good to go


[FR] search history

would be nice though not so necessary.

How would you imagine the UI for that?

As in NewPipe (A free lightweight YouTube frontend for Android.) -
https://f-droid.org/app/org.schabi.newpipe
or in the YouTube itself.
This is of very low priority.


Bunyan log format support

Hello! This is my first open-source pull request. So please give me some feedback. It is very important to me. Thanks.
Should I test /reporters/reporter.js file? Now I just switch off coverage on this file like was on server.js. If yes, can you please help me with idea how to test it.
Issue #22

There are errors in 2 of 3 travis builds. If I am understanding correctly, it's because of yarn install problem. Please tell me if it is something wrong with my code or I can help you to fix this.

Yeap, I just restart build and they finished goods. In next hour I will review a code.

Pull request looks very good. Great work.

I think we could move /reporters/reporter.js to server.js. Anyway it is too small.
How developer will change log from text to Bunyan? Seems like docs changes are missed. What is bunyanLogger?
We need one integration test in test/server.js.

I will put every contributors photos on slide in React London talk. So maybe you want to set avatar in GitHub? :)

Also what is your name? I will mark task as solved on Cult of Martians, because you did 90% work.
(VK and Twitter accounts will be very helpful later for announce)

@ai Thank you for your appreciation. :)

Will do.
I think user wants to set logger settings by himself. So I gave him this opportunity by making an bunyanLogger option in logux server constructor.

const logger = bunyan.createLogger({ name: 'logux-server' })
const app = new Server({
  subprotocol: '1.0.0',
  supports: '1.x',
  root: __dirname,
  reporter: 'bunyan',
  bunyanLogger: logger
})

What do you think?
3. I'll try. :)
I'll set avatar photo.
Links: https://vk.com/index.ascx https://twitter.com/aartmnv

I think that developers will use text log in development and Bunyan in production. In this case changing logger in code become too tricky. We tried to have different dev/prod options on Amplifr, but it looks ugly.
Alaso DevOps like “The Twelve-Factor” philosophy.
So I think argument and environment variable will be more useful:
LOGUX_LOGGER=bunyan npm start

In this case DevOps will be able to change logger without asking JS developer to help.
What do you think about this UX?

@ai This was my first thought. And I implemented it this way. But than I dive deeper into the bunyan and realise that there are a bunch of setting. I don't use bunyan. So maybe I don't understand how it works. But I don't find any system-wide settings. Only for one project with it's code. This is initialisation from official readme:
var bunyan = require('bunyan');
var log = bunyan.createLogger({
    name: <string>,                     // Required
    level: <level name or number>,      // Optional, see "Levels" section
    stream: <node.js stream>,           // Optional, see "Streams" section
    streams: [<bunyan streams>, ...],   // Optional, see "Streams" section
    serializers: <serializers mapping>, // Optional, see "Serializers" section
    src: <boolean>,                     // Optional, see "src" section

    // Any other fields are added to all log records as is.
    foo: 'bar',
    ...
});

As a user of this logger I'll want to set at least name and streams setting. We can proxy them but I think it's ugly. We also can't set same options to all projects. There will be no opportunity to differ logs from each other. That's why I made this decision.
Maybe I don't understand something? :)

@artmnv yeap, it is good question :D. Maybe this questions could help us:

Does this options is really useful for most of users? We could provide argument/env for default Bunyan settings. And allow to set Bunyan instance manually for users, who really need it.
What UX is used in other applications with Bunyan logger?

@ai I think it will be great if we'll make name and file (stderr or filename) settings available from env with zero code. And will provide logux-server's option for 5-10% of people who really need all power of bunyan streams customisation. Deal? :D

@artmnv do we need to specify files? I thought that in Bunyan you just write logs to stdout/stderr. But maybe I am wrong?
Sure, I like idea with bunyan (we could make options shorter with logger=text/bunyan and bunyan names) for special cases.

I have a better idea, instead of having reportProcess function in server.js. Right now you created a wrap reportProcess function. This funciton on every call check options and execute other function. But options are persistent.
You could do it better. Just check options once in Server constructor and pick different reporter for BaseServer:
let reporter
if ( weNeedJSONLog ) {
  reporter = jsonReporter
} else {
  reporter = textReporter
}
super(…, reporter)

Thank you for your ideas!
To make env/cli params we should provide them to server constructor somehow. If you remember, now env/cli params are loading by Server.loadOptions method. But they are passing to Server.listen and not to constructor.
const app = new Server({
  subprotocol: '1.0.0',
  supports: '1.x',
  root: __dirname,
  reporter: 'bunyan'
})

app.listen(app.loadOptions(process, {}))

Brainstorming:

Add loadServerOptions and call it Server(loadServerOptions(...)). Initialisation is too complex.
Add reporter option to loadOptions and call it on Server(loadOptions(...)) too. Listen options in server options can distract user and can lead to bugs.
Leave it. We can't change subprotocol, root, nodeId, timeout, ping etc settings by env/cli params. Maybe we should leave this for another task.

I like the 3rd option. xD But what do you think? Maybe you see a better solution?

I think we could move all listen arguments to constructor. Anyway is very weird, that we have 2 settings. Also tests are very complicated right now, because we need to start server just to check default port :).

@ai Doesn't anybody want to listen to several ports? Does it work this way now? If no, than it's better to merge configs. And maybe even auto-listen after server creation. I think it's not good for UX to have server in untuned state. Especially if there is no another useful scenario for it initialisation.

Totally agree about merging configs.
Auto-listen has some problem:

Test will be much faster if we will not listen port while testing configs.
Listening a port could not be started immediately. In many cases user may need a Promise, when we server was really started.
All node servers API has separated constructor and listen method.

We can bypass first two problems. But if it's common style for node, it will be better to follow it. Okay. Anything else I can help you with this PR?

@artmnv do you want to merge options? I could do it by my own too, anyway you already did most of work.

@ai I'd love to. But don't you think it's better to do in separate PR? This is solid PR which does what the title says.

Sure. I will accept it today and ping you when project will be ready for second PR :).

@ai Thank you! Feel free to ask any help related to this PR. :)


giscus bot can't create correct discussion when data-term change

data-term is bind to a string, when the string change

If both matching discussion be found, giscus can load correct discussion.

If both matching discussion cannot be found, it can only create the discussion for first one,
second will create a comment in first discussion.

https://imgur.com/G5YYyTq
@page "/"

@using GiscusBlazor

<PageTitle>Index</PageTitle>

Hello, world!

Welcome to your new app.

<SurveyPrompt Title="How is Blazor working for you?" />

	<Giscus Repo="xxxxx"
       RepoId="xxxxx"
       Category="Announcements"
       CategoryId="xxxxx"
       Mapping="Mapping.Specific"
       Term="@test_term"
       Strict="false"
       ReactionsEnabled="true"
       EmitMetadata="false"
       InputPosition="InputPosition.Bottom"
       Theme="light"
       Lang="zh-TW"
       Loading="Loading.Lazy" />

<Button<EMAIL_ADDRESS>OnClick="set1">set1</Button>

<Button<EMAIL_ADDRESS>OnClick="set2">set2</Button>

@code{

    string test_term = "0";

    void set1()
    {
        test_term = "1";
        Console.WriteLine($"test_term = {test_term}");
    }

    void set2()
    {
        test_term = "2";
        Console.WriteLine($"test_term = {test_term}");
    }

}

What if you try to use another framework such as Vue or React?
I wonder if it is a Blazor specific problem.

I'm not familiar with Vue or React.
But I try to use Web Components directly in Blazor , face the same problem.
https://github.com/giscus/giscus-component#using-the-web-component

Maybe you should report to the upstream developers.
There is also an alternative solution I come up with: Instead of changing the parameters directly, use the switch expression to replace the whole component.


[Coder]: New method popup - add protocol and instance/class-side selector

This is implemented in the current system


remove secret section

ref: https://github.com/drone/drone-plugin-index/commit/e2a87606a8fdb144781aad0ab666381b5c3368da
cc @bradrydzewski @tboerger

@appleboy I made you the owner of the repository if you want to take ownership. Note that that DOCS.md can probably just be deleted here since documentation is not stored at plugins.drone.io. I will be removing the DOCS.md from my plugin repos as well

@bradrydzewski OK.


Minor list tweaks

I've been looking for a plugin like this for days and finally found this little gem! While trying it out I did encounter one pet peeve, which was that the "Add to workspace" option often ended up preventing quick navigation. Since it is likely only seldomly used I therefore suggest moving it to the bottom of the list.
I also included another minor change to the filtering in an attempt to omit items that are unlikely to be relevant. The code currently omits anything with a score of less than 0.2, but the value is chosen at random. In reality I would've preferred omitting all items that don't contain all typed characters, so consider this a quick hack that could definitely be ignored.
Thanks for sharing your plugin, and I hope you'll consider continuing the development of it!

I ended up developing my own plugin instead: https://github.com/mogelbrod/quick-opener


Relaxing botocore/boto3 pins.

And cpg-infra has the same regarding the boto3/botocore pins.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@b2ef799). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #235   +/-   ##
=======================================
  Coverage        ?   90.67%
=======================================
  Files           ?        4
  Lines           ?      429
  Branches        ?        0
=======================================
  Hits            ?      389
  Misses          ?       40
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: fix an IndexOutOfBoundsException in CastArithmeticOperandProcessor

This PR addresses #125 partially.
The thing is: when the arithmetic operation is inside a method call, and an inner binary operator of the arithmetic operation is being analyzed, we don't find it in the list of arguments of the method call, because that binary operator is part of something more. Not finding it in the list of arguments causes an IndexOutOfBoundsException because we have index -1. This PR fixes that. Note that such a case was added in the test, which triggers the exception if the patch added in this PR does not exist.

As the test source files are the test cases, I think we should try to document them as such as well (I've not been great at that myself, but it's time to get better! :)

I agree with you. However, I'm not sure I can do that every time that I fix something (since my time is limited and the deadline is approaching). From a project on which Sorald has bad behavior until to arrive to that fix and that little, minimal line to trigger the wrong behavior already took some time. I will do that now, but not sure I will be able to do that for the short future.

@slarse, there are some test failures but I think that I did not cause them. Do you have some idea?

As the test source files are the test cases, I think we should try to document them as such as well (I've not been great at that myself, but it's time to get better! :)

I agree with you. However, I'm not sure I can do that every time that I fix something (since my time is limited and the deadline is approaching). From a project on which Sorald has bad behavior until to arrive to that fix and that little, minimal line to trigger the wrong behavior already took some time. I will do that now, but not sure I will be able to do that for the short future.

Of course, maintainability is always a tradeoff between what you've got time to do now and how much you expect it to pay off in the future. I personally highly prioritize minimal test cases such that I know that I've actually reproduced and fixed the error, but if you don't have the time to do it, then you don't have the time to do it.
A not quite as good, but still sufficient solution is to put a big comment in the test file at the exact point where the expected behavior is triggered, and then someone can possibly refactor that at a later time.

@slarse, there are some test failures but I think that I did not cause them. Do you have some idea?

See my comment on the new test file.

I personally highly prioritize minimal test cases such that I know that I've actually reproduced and fixed the error

Me too, which is why I took time to open this PR and probably will take time to open new ones, because I always aim adding a minimal test case to reproduce the bug.

I personally highly prioritize minimal test cases such that I know that I've actually reproduced and fixed the error

Me too, which is why I took time to open this PR and probably will take time to open new ones, because I always aim adding a minimal test case to reproduce the bug.

I know :). I just wanted to clarify that I'm well aware that it is a tradeoff, and it's not always possible to take the ideal path as time is a factor.
Anyway, this looks great to me now, happy to merge?

Anyway, this looks great to me now, happy to merge?

Yes! Thank you!


[Bug]-[70]:Required selection for RadioGroup widget does not show the red rectangle required indicator

Is there an existing issue for this?

[X] I have searched the existing issues

Description
In the Radio Group Widget, in the Property Pane, on removing the Default value and setting the Required property to Enabled, the red rectangle to show the required indicator does not appear.
Steps To Reproduce

In the production environment (app.appsmith.com), drag and drop a Radio Group widget
Remove the Y from Default property and make it empty.
Make the Required switch enabled.

Note that there is no required indicator that appears. This indicator appears correctly on other widgets, for e.g. checkbox group or checkbox.
Also, the functionality of the Required property is working. This is checked by dropping the above Radio Group widget onto a Form widget. We see that the Submit button gets disabled if there is no option is selected in the Radio group widget. Only the indicator is missing.

Public Sample App
No response
Version
Production

The current behavior on required is not upto the mark and needs some more design investigation. Assigning this to design team to triage and get back.

Stats

Stat
Values

Reach
70

Effort (months)
0.5

@dilippitchika Worked on solutions here: https://www.figma.com/file/zHCSC8aA9crvqXrxCjcTwD/Issues-and-Fixes?node-id=12%3A8489

fixed in Reskinning

https://github.com/appsmithorg/appsmith/pull/15329


Can not open the evernote note

The Evernote version is 10.33.4-mac-mas-public (459002),
when I type the "ens" for search , eg:google ,Alfred shows a list ,but when type one list ,only open the Evernote application,can not open the note.

The Evernote version is 10.33.4-mac-mas-public (459002),
when I type the "ens" for search , eg:google ,Alfred shows a list ,but when type one list ,only open the Evernote application,can not open the note.

You can work this workflow only through Evernote's legacy version since Evernote discards applescript support.

ok! thanks you!


[Bug]: AudioContext is undefined

Is there an existing issue for this?

[X] I have searched the existing issues

Description
let audioContext=null;
if(window.AudioContext){
audioContext = new window.AudioContext();
}else if(window.webkitAudioContext){
audioContext = new window.webkitAudioContext();
}else{
console.log(typeof AudioContext);
console.log(typeof webkitAudioContext);
}
Steps To Reproduce
typeof AudioContext is undedfined, My chrome browser supports AudioContext, but this problem occurs in appsmith
Public Sample App
No response
Environment
Production
Severity
Low (Inconsistent UI/UX)
Issue video log
No response
Version
1.6.6

@ahkimkoo appsmith limits access to window objects for security reasons. You can access it inside an iFrame or custom widget


Code displaced under line numbers in error page

When Gaston serves it's gorgeous "Error compiling JavaScript" page, it's beauty initially makes you feel good about having made a javascript mistake. But when your window's falls below a certain width, the code gets displaced below the line numbers element, making the line numbers useless, and the errors harder to find.

@nikoloza can you take care of this? thanks

Yes @andrepadez I'll have a look

Fixed and pushed on develop
Also fixes include:

Lines are not selectable anymore: http://c.nikoloz.me/image/431m3K3v2u0z. This was unusable.
Lines have low contrast now just to not catch eye because of sharp color.


CodeCommit PR missed a commit

@ryanjbaxter The merge you did yesterday (thanks) was missing a commit. I am not even sure how the code compiled since the package names in the source files were not correct. I am not sure if the rebase missed the commit, or the merge did. But in either case I fixed it and the result is here. Note that most of these changes are just for an incorrect package name in the class files, but also a few code changes that were missed in the same commit.

Current coverage is 72.10% (diff: 88.88%)

Merging #621 into master will increase coverage by 0.69%

@@             master       #621   diff @@
==========================================
  Files            67         70     +3
  Lines          2151       2305   +154
  Methods           0          0
  Messages          0          0
  Branches        358        380    +22
==========================================
+ Hits           1536       1662   +126
- Misses          473        493    +20
- Partials        142        150     +8

Powered by Codecov. Last update 5a29d9c...985f43b


Regarding plain websockets

Necessary backstory: I'm creating an ad network where publishers embed my script file into their page. This means I'm unable to import any other files, so I'm reliant on what's already built into javascript.
I'm trying to communicate with my feathersjs socket, but I can only do so with the plain old Websocket()
Ex: var socket = new Websocket('myfeatherssocketurl')
Is this even possible? I noticed in the docs that when emitting something to the socket, you have to include an event name when you send the data, ex: socket.emit('message::create'), but you can't do that with an ordinary socket.
Is it possible to accomplish this with an ordinary socket?

You could still build the Socket.io or Primus websocket library into your JS.
Primus with the SockJS adapter might get you a ways, too. I'm pretty sure it is just encoding the event name + the body as the message string. I found this article describing how to connect to a SockJS server with plain websockets but you might have to dig through Primus to find out how it wants the messages to be encoded.

I will check out Primus and the provided article, thanks for the guidance @daffl!


fix: get port from created server

When lunching the Angular server if the port is in use the App will ask if you want to use another port. If you press Yes @puppeteer/ng-schematics need to find about the new baseUrl rather than the default one.

V


Removed old workspace

This is work-in-progress but fixes the workspace issue if you want to merge.

Woah, you can't go adding a particular vendors libraries to the mock application used to validate every vendor. The whole point of the standard is that an app built to the FDC3 API does not require proprietary libraries (or indeed anything other than knowledge of the standard) to run inside a Desktop Agent implementation.


(#5635) Add TLS configuration in the ingress trait

Add

tlsHosts
tlsSecretName
to configure TLS in the ingress trait

Release Note
Ingress Trait: Add tlsHosts and tlsSecretName to configure the TLS ingress spec

I haven't had the time to fully check with a working certificat
but the kubect get ingress xxx -o yaml seams fine when comparing to an internal working ingress (not showing here for confidentiality reason):

LGTM, thanks for the work. We need also to add the outcome of make generate though.
ok, so I run

make
make generate

and commit/push ?

I haven't had the time to fully check with a working certificat
but the kubect get ingress xxx -o yaml seams fine when comparing to an internal working ingress (not showing here for confidentiality reason):

Sure, the important work here is to map into the configuration expected by Kubernetes.

make
make generate

and commit/push ?

Yes, you should see several autogenerated resources. They must be added to the PR, you can git commit --amend and force push this. Also, you can see there is some minor lint error due to codestyle formatting. The check is failing with:
pkg/trait/ingress.go:22  goimports  File is not `goimports`-ed

You can perform a gofmt -w pkg/trait/ingress.go and later a make lint to verify that is solved afterward. And again, commit the change (likely some space format).

Some builds are failing
Did i missed something ?

Some builds are failing Did i missed something ?

Install check is failing because of https://github.com/apache/camel-k/issues/5632 (I'm working on a fix). The rest should be working normally. I gave it another shot.

Thanks for the contribution!


⚠ SSH 🇮🇩 Indonesia IDN 1 has degraded performance

In 7041c2c, SSH 🇮🇩 Indonesia IDN 1 (http://ids-3.opensvr.net:8080/) experienced degraded performance:

HTTP code: 400
Response time: 5546 ms

Resolved: SSH 🇮🇩 Indonesia IDN 1 performance has improved in ca4a424.


Add ServerTiming header in responses

As a developer and administrator of an instance I want to know what the server did for a request. The ServerTiming header allows returning these metrics: https://developer.mozilla.org/en-US/docs/Web/API/PerformanceServerTiming

Covered by tracing and metrics.


fix #242 Infering an F.Curry type as it's "full" signature results in…

… unexpected behavior
🎁 Pull Request

[x ] Used a clear / meaningful title for this pull request
[x] Tested the changes in your own code (on your projects)
[x] Added / Edited tests to reflect changes (tests folder)
[x] Have read the Contributing part of the Readme
[x] Passed npm test

Fixes
#242
Why have you made changes?
To support the ramada type defenitions
What changes have you made?
Added to F.Curry an overload of the complete signature of the curried function
What tests have you updated?

tested this in tests/Funcction.ts

Is there any breaking changes?

[ ] Yes, I changed the public API & documented it
[ ] Yes, I changed existing tests
[ ] No,  I added to the public API & documented it
[x] No,  I added to the existing tests
[ ] I don't know

@millsp seems that the failing tests are related to the newest version of typescript that was released 6 days ago (4.3.2) and not my changed. I'm trying to figure out what went wrong there but I'm still not sure

@millsp can you please CR?

@millsp can you please CR?


feat: getinvoices for lnbits connector

Describe the changes you have made in this PR
Adds invoice fetching support for LNBits
Note: We don't pass in custom_records as of now, please lmk if there's a way to extract from LNBits invoice response
Link this PR to an issue
#46
Type of change (Remove other not matching type)

feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes (If any)

How has this been tested?
Manually using LNBits account
Checklist

[x] My code follows the style guidelines of this project and performed a self-review of my own code
[x] New and existing tests pass locally with my changes
[x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

utACK


correct name of validate_arguments in docs

I had a brain fart while writing the docs for validate_arguments, @StephenBrown2 pointed this out in https://github.com/samuelcolvin/pydantic/pull/1179#issuecomment-610500171.
Hopefully I've caught every one.

I tried to use *pydantic* everywhere, but I've slipped a bit.
I'm go though the rest tomorrow.


VMS documentation fixes [master]

Configurations/descrip.mms.tmpl: avoid enormous PIPE commands
DCL has a total command line limitation that's too easily broken by
them.
We solve them by creating separate message scripts and using them.
Fixes #13789
VMS documentation fixes
This mostly clarifies details.
Fixes #13789

This is #13834, ported to master

Ping

Ping

Ping

Isn't @t8m's comment still outstanding?

Ping

Isn't @t8m's comment still outstanding?

Note that  this is a 'forward port' of #13834 which contains the same error. I guess it makes sense to review this PR first and put the other one into draft mode until this one has been approved?

Isn't @t8m's comment still outstanding?

Oops, yeah

Note that this is a 'forward port' of #13834 which contains the same error. I guess it makes sense to review this PR first and put the other one into draft mode until this one has been approved?

FYI, the report was made against 1.1.1, so I'm fixing there first to make it easy for the reporter to test.  It's also easier for me to test on 1.1.1, because VMS builds of master is currently flawed.

I've applied the same fixups here as in #13834.  When that gets approved, so should this.

I suppose this is not WIP anymore.

I suppose this is not WIP anymore.

Good point

Merged
72ddea9b817e9b787e58d5b7ca8b7b8e6351f06e Configurations/descrip.mms.tmpl: avoid enormous PIPE commands
d8c1cafbbc5dfe2347a7157178db5b50fdf9d248 VMS documentation fixes


Installation on Win10 Fails if no Defender module is installed (IDFGH-2202)

Installation fails and hungs if no Defender module is found on windows 10.
If there is no defender module, please just skip defender exceptions.
Running command: powershell -ExecutionPolicy ByPass -File "C:\Users\User.espressif\dist\tools_WD_excl.ps1" -AddExclPath "C:\Users\User.espressif*.exe"
Import-Module : The specified module 'Defender' was not loaded because no valid module file was found in any module
directory.
At C:\Users\User.espressif\dist\tools_WD_excl.ps1:61 char:1

Import-Module Defender

  + CategoryInfo          : ResourceUnavailable: (Defender:String) [Import-Module], FileNotFoundException
  + FullyQualifiedErrorId : Modules_ModuleNotFound,Microsoft.PowerShell.Commands.ImportModuleCommand

C:\Users\User.espressif\dist\tools_WD_excl.ps1 : Windows Defender cmdlets not available
+ CategoryInfo          : NotSpecified: (:) [Write-Error], NotSupportedException
+ FullyQualifiedErrorId : System.NotSupportedException,tools_WD_excl.ps1

This seems to be the same issue as reported in #4225.

yes, it's a dupe, but different OS.

This issue is still happening with esp-idf-tools-setup-2.2.exe on Windows 10:
Running command: powershell -ExecutionPolicy ByPass -File "C:\Users\Me.espressif\dist\tools_WD_excl.ps1" -AddExclPath "C:\Users\Me.espressif*.exe"
Message box (OK):
Installation has failed with exit code 1
User chose OK.

Hi,
this is weird behavior as the installer checks the WinDefender module existence first and disables the option checkbox when not found (the check is done as lookup for %PSMODULEPATH%\Defender*). Furthermore, it's quite complicated to get rid of the Defender in Windows 10, unless you run Server version... would you make one more test, please? Attached you find updated PS1 scripts (another check for Defender cmdlet before actual import). Plus listing of your PSMODULEPATH would be helpful too - you can use wdmodule_listing.cmd frm the attachment. Well, and your OS version is interesting too :-) (run systeminfo | findstr /B /C:"OS Name" /C:"OS Version" in your cmdline)
Thank you very much
Martin
tools_WD_update.zip

Hi Martin,
The error I experienced occurred with the "Register the ESP-IDF Tools Executables as Windows Defender exclusions" box checked. So I reinstalled with the box unchecked and got through the installation. It has been a while since I was working on this, but I seem to recall also having to install OpenSSL (but that might have been related to the PlatformIO ESP32 installation in VSCode - I just don't recall).
Here is my Windows 10 PSModulePath:
PSModulePath=C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules;C:\Program Files (x86)\Microsoft SQL Server\110\Tools\PowerShell\Modules;C:\Program Files\Microsoft Message Analyzer\PowerShell;C:\Program Files\WindowsPowerShell\Modules;C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\ResourceManager\AzureResourceManager;C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\ServiceManagement;C:\Program Files (x86)\Microsoft SDKs\Azure\PowerShell\Storage
Many thanks!

Aaaaa, that's a big PSMODULEPATH field :-) Let me check whether we have troubles with the string parsing or such... it's quite unlikely your Windows 10 doesn't contain the Defender module so I guess the issue is elsewhere.
Thank you
Martin

在win10上，我解决了这个问题。首先使用esp-idf-tools-setup.exe，在安装的时候不要勾选 regeister the ESP-IDF tools as windows definder。然后打开cmd窗口手动执行命令powershell -ExecutionPolicy ByPass -File "D:.espressif\dist\tools_WD_excl.ps1" -AddExclPath "D:.espressif*.exe"，D:.espressif需要改成你自己的路径。

On win10, I solved this problem. First use esp-idf-tools-setup.exe, do not check regeister the ESP-IDF tools as windows definder during installation. Then open the cmd window and manually execute the command powershell -ExecutionPolicy ByPass -File "D:.espressif\dist\tools_WD_excl.ps1" -AddExclPath "D:.espressif*.exe", D:.espressif needs to be changed to your own path.

Thanks... My Problem is Solved.. Using this method...


⚠ Bofrost.lu has degraded performance

In e84d8df, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1595 ms

Resolved: Bofrost.lu performance has improved in c69a593 after 14 minutes.


Add basic URLFilter for HttpURLConnection

This optional filter can be used to allow for blocking HTTP traffic to
certain URLs, for example in order to prevent accessing sensitive
content over HTTP instead of HTTPS.
This behavior is already possible for clients of OkHttpClient, this patch allows legacy clients using the HttpUrlConnection APIs to do basic blocking.
See #2269

Sorry, this use case is too obscure to warrant extra API. If you really need this behavior, write your own URLStreamHandler that delegates to OkHttp’s UrlStreamHandler.

Is there a way we can make this UrlFilter interface non-public and expose this behavior only to AOSP?

We can make it package private to keep it AOSP only.

I made the OkUrlFactory.setUrlFilter method package private, that works fine for AOSP but will keep it from being publicly usable. The interface is still public since it is referenced by HttpURLConnectionImpl but I could move it into okhttp3.internal as well.

Awesome, yes please do.

Done

Fixed an unused import that I missed when moving the interface to internal.

Neat! Thanks for jumping through all the hoops for me!

Thanks! Sorry for not being clearer on the usage from the start.
On Tue, Jan 26, 2016, 18:10 Jesse Wilson<EMAIL_ADDRESS>wrote:

Neat! Thanks for jumping through all the hoops for me!
—
Reply to this email directly or view it on GitHub
https://github.com/square/okhttp/pull/2275#issuecomment-175343595.


feat: Allows custom Regex fields

https://github.com/envoyproxy/gateway/blob/677cf033f74babcab70670d87a1cf1cd105e4b48/internal/xds/translator/route.go#L258

@borederman can you share the gateway API config / filter you are trying to apply ?

For example with the following config:
would transform http://www.example.com/gw/api/get  into  http://www.example.com/get/api
    filters:
    - type: URLRewrite
      urlRewrite:
        path:
          replaceFullPath: /\2/\1
          type: ReplaceFullPath
    matches:
    - path:
        type: RegularExpression
        value: ^/gw/(api)/(.+)$  # as `RegexMatchAndSubstitute.pattern`

@borederman can you share the gateway API config / filter you are trying to apply ?

For example with the following config:
would transform http://www.example.com/gw/api/get  into  http://www.example.com/get/api
    filters:
    - type: URLRewrite
      urlRewrite:
        path:
          replaceFullPath: /\2/\1
          type: ReplaceFullPath
    matches:
    - path:
        type: RegularExpression
        value: ^/gw/(api)/(.+)$  # as `RegexMatchAndSubstitute.pattern`

@arkodg  I do not know if the problem was described clearly or not.

is this same as https://github.com/kubernetes-sigs/gateway-api/issues/2177 ?

oh, no.....

fixed with https://github.com/envoyproxy/gateway/pull/4258


support of alphanumeric coding

Hi,
I would strongly recommend to add alphanumeric suppert. Often (as in my case) only a url is coded with standard chars. Using alphanumeric coding the QR code image gets smaller which makes it easier to place it and can be bigger which is better for readability.
Let me know what you think about it...
best,
Stefano

This is a great idea but it should probably happen in the parent library (https://github.com/kevmoo/qr.dart). I'll look at logging a bug or doing a PR there.

Hi Luke,
you are right! In the meantime I found that out as well and I put a request there already. When it is implemented we may have to make a small extension to the Interface as well. In total I am sure it is not much effort since it is only an additional coding table for the alphanumeric support.
Stefano
On 23. Jun 2020, at 00:18, Luke<EMAIL_ADDRESS>wrote:

This is a great idea but it should probably happen in the parent library (https://github.com/kevmoo/qr.dart). I'll look at logging a bug or doing a PR there.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Looks like this was solved upstream so closing!


Installation Issue

Hello there.
I'm having problems installing pylayers in Windows 8.1 and Linux Ubuntu 14.04.3. I have used Anaconda2-2.4.0 in both OSs. The error is the same in both systems too. Maybe it is something easy I'm missing, but I know nothing of Python and I'm not handy with Linux systems either. The screen shot of the error is:

Thanks in advance...

It seems there is an issue during the install of PIL library.
I suppose you have an anaconda distribution of python, so you should try :

conda install PIL
If you encountered the same issue , try an install from pip :
pip install PIL
Then try to reinstall pylayers.
Let me know if you manage to finish he install

Hi Nicolas,
I followed your instructions and the installation went Ok. Thanks a lot. After that, I wanted to see if pylayers was working Ok.  I tried the 4 lines sample code:

from pylayers.simul.link import *
DL = DLink()
DL.eval()
DL._show3()

I wrote them in a .py file that I run with python. Now I get the error it is shown in the following screen shot:

What should I do? Am I verifying if pylayers is Ok in the wrong way? Thanks again!

Could you please check if you have a .pylayers (note the '.' prefix) file created in your $HOME ( a.k.a. ~)
If so , please check that under 'source' the path correspond to the directory where you cloned the pylayers project (regarding your screenshot, it should be : ~/Downloads/pylayers-master)

Hi Nicolas.
I did what you said and now pylayers is working fine in Windows. However, in Ubuntu I got this error:

Thanks again!

It sounds like an issue with the basemap library installation.
make an extra :

conda install basemap
should solve the issue

Thanks Nicolas. Now it is working fine in Ubuntu too.


Revert "Add new gemini pipelines to pipelines index"

Reverts google/visualblocks#81

#81 had a json syntax error which broke the project page.


licensing

Hey @stove-panini ,
I was just getting down to start writing my own ansible role for generating lvmraid 10 volumes, then I found yours which looks like it would be significantly more generic and re-usable than my own would be.
However I noticed you did not have a license listed after I took a closer look. Would it be possible to request an inclusion of a license file even if it is just to say that you don't want others to use your work, just to make it clear to people like me who may stumble across it, but want to respect the owners wishes.
P.S apologies for the fork, I only noticed the license was missing after I clicked the button. I will go delete it until I know how you feel about your work.

No sweat! Glad you can make use of the role :)


Add allow 429 and ssl

I tweak travis depending on the awesome bot version. It will be more understandable.

Thanks!!!!


Can’t play composed MPDs with recent FFmpeg versions

Summary
With recent FFmpeg versions, mpv failed to play composed MPEG-DASH manifests. Only the first segment is shown for the first run. The playing hangs with the following error messages in the output (the full output can be seen in Attachments):
$ ffplay -report -v 9 -loglevel 99 manifest.mpd
...
[dash @ 0x7f727c000c80] Error when loading first fragment of playlist

Interestingly, each subsequent run advances the playback for one next segment.
Details
Bisecting the FFmpeg history reveals that these two commits to be a cause: https://github.com/FFmpeg/FFmpeg/commit/c1228315c97acbe7a6220b4a5f282bd93edbeb42, https://github.com/FFmpeg/FFmpeg/commit/0dd1ff67c8a5b687f4b9beb51b425ef7fb8b72c1. See also the corresponding patch<EMAIL_ADDRESS>Indeed, for example, for the second* segment (888349) a response contains the following header values:
[https @ 0x7f727c007500] header='Content-Range: bytes 0-/*'
[https @ 0x7f727c007500] header='Transfer-Encoding: chunked'

While during the second run (not in the attached output), the header value for the same segment (now it's playable) is as follows:
[https @ 0x7f5784006800] header='Content-Range: bytes 0-106715/106716'

[*] The first segment (888348) is not representative here because it's already requested during the manifest composing.
The latest unaffected stable release is 5.1.4.
Workaround solution
A solution would be to revert these two FFmpeg commits and build custom mpv with mpv-build.
Attachments
Here are below the manifest and log output with the current FFmpeg git head:
manifest.mpd.txt, ffplay-20240127-232140.log

How to build image of patched FFmpeg and mpv
Here is the instruction to build an image that comes with patched FFmpeg and mpv:

Build the container image with buildah: $ sudo buildah build -t ytpb -f Containerfile
Once built, you can run commands in a container with Podman, for example:

$ ytpb mpd compose ... && ls
MPD

$ podman run --rm -it \
   -v $PWD:/root:Z ytpb \
   ffmpeg -i /root/MPD -c copy /root/out.mp4

How to create container with patched FFmpeg and mpv
Here is the instruction to build the container image that comes with patched FFmpeg and mpv:

Build the image with buildah: sudo buildah bud -t ytpb -f etc/Containerfile
Once built, you can run commands in a container with Podman, for example:

$ ytpb mpd compose ... && ls
MPD

$ podman run --rm -it \
     -v $PWD:/root:Z ytpb \
     ffmpeg -i MPD -c copy /root/out.mp4


Ft8 help

Would love a manual for the app and why isn't anyone coming back to me does the phone speaker have an affect on it using ft817 and Bluetooth
Nothing on psk reporter as well but all seems to decode via ft8 app
Thanks andy

I am scratching my head again wondering if....
A radio isn't working
B propagation is rubbish
C everyone is using  big power
D Compromised antenna
Can you spot yourself see if your actually getting out
Any help greatly appreciated

I'm having  same issues  here. Will do Pskrepoporter.  See if that is a hint.

Would love a manual for the app and why isn't anyone coming back to me does the phone speaker have an affect on it using ft817 and Bluetooth Nothing on psk reporter as well but all seems to decode via ft8 app
Thanks andy

Have u had any luck trying to make and ft8 contact yet?

I am scratching my head again wondering if.... A radio isn't working B propagation is rubbish C everyone is using big power D Compromised antenna
Can you spot yourself see if your actually getting out Any help greatly appreciated

Did u find problem? Am having  ssme.


Implement single-threaded server

Similar to C++ TSimpleServer: very basic single-threaded server. This includes the subset of server-side code generation so that the tutorial example can be compiled and run. Full server-side codegen is done as a separate issue.

I've started work on this here: https://github.com/gsingh93/thrift/tree/simple-server

Thanks @gsingh93 for submitting, looks good! Closing the issue.


Error: ETIMEDOUT

Hello,
I get this error when I run
npm run live on a ubuntu 18.04:

<EMAIL_ADDRESS>live /home/pierre/Cryptos/binance-triangle
node src/main/Main.js
Querying exchangeInfo
Expect 38 seconds to open 375 depth websockets.
/home/pierre/Cryptos/binance-triangle/node_modules/node-binance-api/node-binance-api.js:1749
if (err) throw err;
^
Error: ETIMEDOUT
at Timeout._onTimeout (/home/pierre/Cryptos/binance-triangle/node_modules/request/request.js:845:19)
at ontimeout (timers.js:498:11)
at tryOnTimeout (timers.js:323:5)
at Timer.listOnTimeout (timers.js:290:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>live: node src/main/Main.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>live script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!  Then I brewed. Both configs give this results. My api keys are in the config file. Can it be a conflict between apt-get and brew ? I also had a message about something that is not in my path during the brewing, maybe it can impact ?
Thank you

Hey, thanks for your interest!
I will be removing that section of the readme in the next release. It doesn't matter whether you got your NodeJS and NPM versions from brew or another location.
Which version of node and npm are you using?

Hey, thank you fr your response ! :-)
node v8.11.3
npm 5.6.0

Would you delete your node_modules folder, then reinstall dependencies with npm install and show me the output?

It only tells me: added 99 packages in 2.885s
And the same problem appears.

Update your node version to 9.x
Update your npm version to 6.x with npm install -g npm
I don't see anything in the stack trace provided to point to a specific cause. Perhaps there is a feature being used which isn't supported by your node version. The project was built with node 9.x so updating it will resolve that issue.

Now I have node v9.11.2 and npm 6.4.0 but still it does not work.
I will try on windows.

Hooo, it works now on my ubuntu 18.04. Great :-)

I'm glad its working for you now! Unfortunately I haven't found the root of your issue. I have gotten timeout errors recently playing around with some new features. In my case, they stem from scanning for arbitrage too soon before the internal depth caches are populated.
Fix:
Increase DEPTH_OPEN_INTERVAL from the default of 100 to something like 300

Alright, I'll keep this tip in mind if that apprears again. Thank you

Sorry to necropost, but I was able to resolve this error by changing my nameservers to google's <IP_ADDRESS> and <IP_ADDRESS>


Example: GraphQL API

Overview
This PR demonstrates Remix fetching from a GraphQL API. Additionally I've opted to add in a codegen setup which automates the creation of types which can then be used in by the useLoaderData hook and any components that make use of the more generic type (from the API) as demonstrated by the CharacterDetail component.
Thanks to everyone involved in this fantastic project and LMK how I can improve on this PR.

There's something to be said about "just using fetch" for GraphQL queries. That makes it pretty simple to follow.
However, it might be beneficial for the example to build upon prior art and use this library instead
https://github.com/thomasheyenbrock/remix-graphql
I think that including codegen for TS types is good. I'm always a fan of examples that are a bit closer to real-world scenarios than just the bare minimum. It just seems that Remix wants the examples to be very focused:

This means you should avoid adding stuff that isn't absolutely necessary for the example. Start with bare bones and add only what you need.

@hollandThomas thanks for the initial feedback! I've taken a look at the thomasheyenbrock/remix-graphql but that feels like I'd be moving backwards and adding more than is necessary, thoughts?

What do you think of using a resource route to expose a GraphQL ending in Remix? That way the example could show both consume an endpoint and be the endpoint, ideally also have a route showing how to run the query against the schema and resolvers without doing a request.

Whoops! Accidentally clicked the close button 😅
Was just going to say that I like the resource route graphql endpoint idea as well 👍 Then you could show people that they could have a mobile client that hits the same endpoint which is a big reason people like graphql :)

I cloned this example and while it worked great when running "npm run dev", it did not work for me when I ran "npm run build" and  "npm start".  It would throw an Application Error "Error: GRAPHQL_API is required" even though the environment variable is properly set in .env and as I said, works fine for "npm run dev".  Would love to get this working in production, not just dev.  Thank you and nice work!

@kcoyner have a look here

@sergiodxa thanks for the review and feedback, I've taken a crack at the general updates but wanted to better understand the resource route comment a bit better before doing anything there. From what I understand I could easily create an api/character.ts route with no component effectively giving me an API which any client can consume, example below

Simple API endpoint
import type { ApolloError } from "apollo-server-errors";
import type { LoaderFunction } from "remix";

import { fetchFromGraphQL } from "~/utils/index";
import type { Character } from "~/generated/types";

type LoaderData = {
  data: { character: Character };
  errors?: ApolloError[];
};

export const loader: LoaderFunction = async (args): Promise<LoaderData> => {
  const { params } = args;

  const getCharacterQuery = `
      fragment CharacterFields on Character {
        gender
        id
        image
        name
        origin {
          dimension
          name
          type
        }
        species
        status
        type
      }

      query getCharacter($id: ID!) {
        character(id: $id) {
          ...CharacterFields
        }
      }
    `;

  const res = await fetchFromGraphQL(getCharacterQuery, { id: params.id });
  return res.json();
};

Then I can query that endpoint in the loader, but I'm not fully understanding how to accomplish the bit here  ideally also have a route showing how to run the query against the schema and resolvers without doing a request. specifically without doing a request 🤔

@sergiodxa thanks for the review and feedback, I've taken a crack at the general updates but wanted to better understand the resource route comment a bit better before doing anything there. From what I understand I could easily create an api/character.ts route with no component effectively giving me an API which any client can consume, example below
Simple API endpoint /api/character
Then I can query that endpoint in the loader, but I'm not fully understanding how to accomplish the bit here  ideally also have a route showing how to run the query against the schema and resolvers without doing a request. specifically without doing a request 🤔

What I meant is that the example could have three parts

A routes/graphql.ts resource route with a GraphQL endpoint, there you can expose any mock data, the idea is to show that you can use Remix resource routes to build a GraphQL API
One or more UI routes fetching data from a GraphQL endpoint, it could be the same or another public one, this shows how to fetch GraphQL from a Remix loader/action
One or more UI routes using the same GraphQL schema and resolvers as the API endpoint but calling them directly with the query, this shows how to avoid doing the request while still using GraphQL so you can call your own API without doing an HTTP request

@sergiodxa alrighty I think I've checked all the boxes above but have a look and let know if I've missed anything. Thanks for that follow up comment, not sure why I didn't think of that initially.

I've opted for two resource routes in an api directory
The index route which demonstrates calling the resource directly
The $id route fetches from the API (like a mobile client might)
Lastly the error route uses a raw fetch within the loader, this wasn't listed but I wanted to show the GraphQL error scenario


Zero coverage on svelte components

Describe the bug
Hello, I followed your example for the setup for Svelte as seen here: https://github.com/vitest-dev/vitest/tree/main/examples/svelte
For automated testing and pipelines, I wanted to setup a coverage threshold. As documented, I added c8 to my dependencies. When running vitest run --coverage and having the following configuration, I get zero coverage on my components / files.
vitest.config.ts:
import { defineConfig } from 'vite';
import { svelte } from '@sveltejs/vite-plugin-svelte';

export default defineConfig({
  plugins: [svelte({ hot: !process.env.VITEST })],
  test: {
    globals: true,
    environment: 'jsdom',
    coverage: {
      all: true,
      include: ['components/**'],
      reporter: ['text', 'lcov'],
    },
  },
});

console output:
 RUN  v0.21.1 /home/projects/vitest-dev-vitest-j7shma

 ✓ test/basic.test.ts (1)
 ✓ test/hello.test.ts (2)

Test Files  2 passed (2)
     Tests  3 passed (3)
  Start at  20:13:24
  Duration  4.61s (setup 0ms, collect 530ms, tests 98ms)

--------------|---------|----------|---------|---------|-------------------
File          | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
--------------|---------|----------|---------|---------|-------------------
All files     |       0 |        0 |       0 |       0 |
 Hello.svelte |       0 |        0 |       0 |       0 | 1-7
--------------|---------|----------|---------|---------|-------------------
close timed out after 1000ms

I expect full coverage as everything is tested. This should not be the behavior, right? I hardly changed your given example.
I have seen that there are issues for not exact coverage, but personally I am missing all of it. On the Discord server I did not recieve any further help / solutions.
Reproduction
Slightly adjusted your example: https://stackblitz.com/edit/vitest-dev-vitest-j7shma
System Info
❯ npx envinfo --system --npmPackages '{vitest,vite,@vitejs/*}' --binaries --browsers
success Install finished in 1.366s

  System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.10 - /bin/yarn
    npm: 7.17.0 - /bin/npm
  npmPackages:
    vitest: latest => 0.21.1

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

@MoritzHorch does this happen on your local machine as well? Stackblitz does not implement all of the v8's APIs, such as takeCoverage. c8 won't work there.
By downloading and running locally the repro project I'm seeing following:
--------------|---------|----------|---------|---------|-------------------
File          | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
--------------|---------|----------|---------|---------|-------------------
All files     |     100 |        0 |     100 |     100 |
 Hello.svelte |     100 |        0 |     100 |     100 | 6
--------------|---------|----------|---------|---------|-------------------

@AriPerkkio Indeed, locally it just worked. In my project it still didn't work until, after some trial and error, I found the problem.
I used a lot of "Create React App" for work and therefore took absolute imports from the root project folder for granted. Such things as import App from 'src/App.svelte. I now learned that this is not the default behaviour with Svelte + Vite / Vitest. c8 probably wasn't able to resolve / follow this path and couldn't collect any coverage.
Therefore the solution 🎉 was to either use relative imports like import App from '../src/App.svelte or use vite-tsconfig-paths. I did configured it as described and it simply worked. If I understood this plugin correctly, it will additionally do another lookup starting from the configured baseUrl in the tsconfig.json ("baseUrl": "." in my case).
Guess my given example simply did not work due to the reason you described, but my real problem was the missing configuration / wrong use which lead to a lot of confusion.
Thanks for helping and thanks to "hylo" on the Svelte Discord Server as well!


reintroduce gss-api auth which was removed by 59d3f66

Fixes #1529

Maybe we need to install that dll on our test runner? (gssapi32.dll) We used to ship this gem on windows platforms, so I'm assuming it should work on windows. There are some other gems we do not ship on windows bc of the way we build ruby https://tickets.puppetlabs.com/browse/BOLT-1296 https://github.com/puppetlabs/puppet-runtime/blob/1c36c7d2d3444d1ccd328b087326c262ef2c078b/configs/projects/bolt-runtime.rb#L118-L123

So apparently the net-ssh-krb gem only works with the MIT Kerberos package (and not the built in windows API). So I think we do need to rescue the LoadError. We can ticket supporting non-MIT Kerberos on windows bolt-controllers for kerberos of netssh. Sorry for the churn!

I'm reasonably certain we don't need to require the gem - It basically just adds support for a different authentication method to net/ssh, which when you have it configured gets called https://github.com/cbeer/net-ssh-kerberos. Our test infrastructure seems to be having network issues so I'm having some trouble verifying, but I recall getting this working without requiring the gem in Bolt.
In order to have net/ssh load the config option to use gssapi-with-mic I believe you need to set PreferredAuthentications gssapi-with-mic in your SSH config, in addition to the usual GSSAPIAuthentication yes.

I'm sorry but that's not enough. bolt even helpfully states it's using gss-api-with-mic but then it fails. Simply adding the line makes it work.

Ok, if it's only working for you with the change I don't see any harm in it.

Waiting for CLA signature by @faxm0dem
@faxm0dem - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/
Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

CLA signed by all contributors.

Thanks so much for this @faxm0dem!!

thanks so much to you for being so helpful, kind and reactive!


Enhance CONTRIBUTING

Fixes #377
Also:

re-express the bug reporting workflow with clear steps and checklists we can link to
simplified a couple of things
removed references to waffle
remove section about PR title

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "contributing" git@github.com:dmp42/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

This will update the existing PR, so DO NOT open a new one.

Did you build on top of a bad branch? There's a test failing:
# github.com/docker/distribution/registry/client
/tmp/go-build180985592/github.com/docker/distribution/registry/client/_test/_obj_test/repository.go:25: undefined: v2.ValidateRespositoryName
FAIL	github.com/docker/distribution/registry/client [build failed]

LGTM.
It looks like your circle.yml is old? (still trying to send coverage data)

Rebasing.

@thaJeztah Comments addressed. Thanks!
One open question.

Thanks!  Commented on your question. I think this is a nice improvement of the document, that covers the important parts. For additional guiding, you can consider adding a link to https://docs.docker.com/project/who-written-for/
One note; realise that the "checkboxes" will be non-clickable for visitors here, if the intent was to have users  literally tick those boxes. Regular bullet-lists can be used as an alternative.

Understood that checkboxes behave like that.
I thought it was a good idea in order to give the user a feeling that this indeed is a checklist of things, but I'm not adamant so if people feel it's better with a bullet list, I can live with that.

I thought it was a good idea in order to give the user a feeling that this indeed is a checklist of things. I'm not adamant so if people feel it's better with a bullet list, I can live with that.

Yes, I like the thought. Also thought of limiting it to just the "Before reporting an issue…" section, and making the checkboxes "checked"; but that doesn't make sense, because people won't have all those issues, just one of them
Because the checkboxes are disabled ('greyed out') for non-contributors, they don't stand out as good as bullets (depending on the browser). This is not a problem for short lists, but longer lists (e.g. "If you have not found an existing issue.."), this will make it hard to keep track;

So, I like the idea, but don't think it "works". The longer lists may even benefit from converting to a numbered list, so that users can keep track at what step they are.
On the Before reporting an issue… section;
Good one, clear. Let's hope it helps reducing the number of incorrect reports!
Perhaps a "Reporting issues" section should be added to the README.md, linking here, because not everyone will relate "reporting issue / problems" with "contributing", but maybe that's for another PR

@thaJeztah I'm happy with this document as his. Do you mind submitting a PR with clerical fixes?

LGTM.

Yeah, let's merge this and progress from there.

@stevvooe @dmp42 sgtm, feel free to merge; it was a suggestion to consider, no show-stopper. And it's "your" repo :)

@thaJeztah We were hoping that you could take some time to make the suggested edits. Most of these are style-related, which are more constructive when discussed separately.
Either way, keep the good commentary coming!

@stevvooe :+1: good call, I'll create a follow-up. Might be tomorrow.