Allows the use of supplied Router object to ExpressReceiver

Summary
The goal of this PR is to allow for using a custom express router by an express app to be used for ExpressReceiver instead of having the receiver itself own the express app and router. This enhancement also relates to https://github.com/slackapi/bolt-js/issues/212 and the upward modularity philosophy.
From a software design perspective, this isn't the most sensical design ever, as it essentially defeats the purpose of the Receiver interface more or less, but it gets the job done and is usable without requiring a major refactor to Bolt.
In this implementation, if a Router is supplied to the constructor, no express app or router is created. As a result, there is nothing for start or stop to do, so both are no-op in this case and return a Promise which resolves to void.
Closes #868 .
Requirements (place an x in each [ ])

[x] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for working on this! For your information, I've created my suggestion branch, which is based on your branch: https://github.com/seratch/bolt-js/commit/b11b04b51d1f365b5bfdf35159db80e401209a80
As I did in the branch, adding a new example app for this use case may be a good addition. What do you think? @stevengill

Ah, sorry - I overlooked @stevengill's  above comment.
So, is one possible solution to enable passing express.Application (not a router) in the constructor? With this way, we can pass express.Application from external code and we don't need to unnecessarily call express() internally.  Also, we don't need to change start/stop method at all (perhaps, those methods won't be used in this scenario though).
Am I missing something?

Passing App is an interesting idea.  What do you think @rr-codes

Hey @stevengill  @seratch sorry for the delay!

Passing App is an interesting idea.  What do you think @rr-codes

This is interesting! But in start, since it will be doing nothing in this case, how can we make the port parameter optional in this specific case? Since the parameter wouldn't be doing anything.

@rr-codes I may not understand your concern about the start method yet.
When you directly use express.Application#listen method instead, Bolt's App#start method won't be used in the scenario. If you want to use start method with the external Application instance, creating a new HTTP server with the express app instance in the method should work. Let us know if there is anything else we should consider.

Hey @rr-codes
I agree with Kaz, I don't think the developer will have to call start so they won't have to worry about the port. Or am I missing something obvious?

@seratch @stevengill oh true ok ya I was confusing myself. So yup I agree with both of you!

I'd be lying if I said setting app to undefined doesn't make me uncomfortable. I could see this type change causing some confusion for some developers.
To me, it seems you just want to take advantage of the receivers ability to setup routes (like slack/events) and use the built in middleware.
Passing in your own router does really make ExpressReceiver pretty useless.
You could plug your bolt app into existing Express apps already via something like #212 (comment). What benefit would this approach have over the one in the comment?

also @stevengill you mentioned this alternative; however, receiver is a private field of App, so this doesn't even seem possible?

@rr-codes

however, receiver is a private field of App, so this doesn't even seem possible?

This is correct. app.receiver.router does not work in TS. Although it's technically possible to access private fields in JS as the example there does, it's not allowed in TS.
By the way, are you going to work on this one very soon? No rush at all but I'm thinking about the release timing of v3.4. If we need more time for this PR, it's totally fine to move this one to v3.5 milestone.

@seratch hey, so ya I've been working on this, and I've been thinking about the possibilities of making the receiver act as an express middleware, so like expressApp.use(myReceiver). I think this approach would be better than passing in the express App as this is more idiomatic Express and is a common use.
So I've just been trying to figure out how to / if its even possible to accomplish this.
What do you think?

@rr-codes If I understand correctly, it should be possible to implement a Receiver as an Express middleware and I agree that's a clearer design. However, the receiver can be a bit different thing from the current ExpressReceiver. More importantly, our top priority for built-in receivers is to keep backward compatibility for existing apps (including the use cases where an app uses ExpressReceiver#router for adding custom routes).
For these reasons, my suggestion here is to continue exploring a greater design for a while and decide where to go once we've figured it out. Let me move this from v3.4 scopes from future versions (v3.5 as a tentative plan). Thanks for your efforts here!

@seratch thoughts on my most recent commit? I extracted all the middleware logic into its own class, which can be used standalone with any receiver. I really like this approach as it provides much more flexibility, without affecting ExpressReceiver too much.

@rr-codes
The change may be nice refactoring, and it can be beneficial for 3rd party Receiver implementations. However, I think the current implementation could cause breaking changes. RequestHandlers like respondToSslCheck are already exported from ExpressReceiver. Changing the location is not backward compatible.
To safely expose the main RequestHandler (= the private method named as requestHandler), as you did, it may be fine to have a new holder class and provide a way to get the set of RequestHandlers. The class can refer to the existing "stateless" RequestHandlers without changing their locations.
Going back to the original topic you raised at #868, the latest revision is no longer a solution for improving ExpressReceiver. Are you more interested in building your own Express-based Receiver now? If so, let's stop working on this pull request and start a new conversation in a new task issue.
I also think that the built-in ExpressReceiver should allow developers to attach Bolt apps to an external Express application. I believe the fix for it would be much simpler than this one. I'm happy to continue working on the task #868 .


Remove detect from fetch polyfill

Edge 14 has a broken version of fetch, we target Edge 14 but fail to apply polyfill due to an embedded feature detect in the polyfill. Thanks to @wessberg for spotting this issue.

Linking this PR to the commit comment which made it happen -- https://github.com/Financial-Times/polyfill-service/commit/dc8331a7e04c84f2cced7a383ff863d48ccd780f#commitcomment-19533201

The detect that we would need to be sensitive to the broken implementation in Edge includes actually invoking a fetch.  This obviously has massive overhead, will cause console logs to be printed and could in any case violate CSP.   I tried some experiments with fetching a data: URI on the basis that we might get away with that, if it worked, but you can't POST to a data: URI.
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8475223/ is the Edge bug.  To be honest I think there might not be anything we can do here.

To clarify: we shipped Edge 14 with one confirmed fetch() bug (DELETE requests return 0 for content-length and an empty body), as well as some missing features that are technically part of the iterable spec. There are some details in this Reddit thread; note that this bug is already fixed in 14 (modulo the DELETE case).
Sending Edge <=14 the polyfill is not unreasonable, but we're also discussing possibly servicing the DELETE fix in a pre-15 update, and it's already kind of an edge case IMO. The headers issue is more serious, if folks are already depending on it. Up to you, but just trying to provide backstory! :smiley:

OK, well, all we're doing here is removing an unnecessary built in detect, which transfers the decision on whether to feature detect back to the developer, so I'm happy.


Script fails on files where autocrop succeeds

Hi, and let me say first, thanks for the great script. It certainly makes watching the Nolan Batman films significantly more enjoyable. I'd like to use it all the time, but unfortunately, it's failing for me on seemingly random files, no matter what options I change, even though the "traditional" autocrop.lua script seems to handle them fine. When I say failing, I mean that the script runs - I can see that in the stats screen - but it doesn't do anything, no matter how long or wait, skip around, or toggle it off and on. Changing modes doesn't help either, nor do turning off the "reset" or "skip" options, though I admit my understanding of those is less than minimal. I tried activating debug mode, but I couldn't figure out where to find the debug info; I'd be glad to provide it if you could tell me where it is.
The really annoying thing (since I'd like to provide a more useful bug report) is that there doesn't seem to be anything tying the "problem files" together. A few examples:

Kingdom of Heaven: Director's Cut - MakeMKV rip, x264, 1920x1080 video, actual 2.39:1 aspect ratio
Paprika - MakeMKV rip, MPEG-2, 1920x0180 video, actual 1:85:1 aspect ratio
Pirates of the Carribbean - MakeMKV rip, x264, 1920x1080 video, actual 2.39:1 aspect ratio
Zombieland - Handbrake encode, x264, 3840x2160 video, actual 2.39:1 aspect ratio

There are a couple others, but those are the ones I can recall right now. What's weird is that I have dozens of movies with exactly the same specs that all work just fine with your script. I can't figure out what the issue is. Obviously, the problem goes away if I run them through Handbrake and crop them, but that rather defeats the point of an autocrop script.
Anyway, thanks again, and I hope things are going well for you.
Edit: Forgot to add my specs.

Windows 10 Pro 21H1
mpv build mpv 0.33.0-177-gfd8c673cfc (x64)
AMD Ryzen 5800X CPU w/ 32 GB DDR4-3600c16 RAM
NVIDIA GTX 1080 Ti GPU (Driver version 471.11)
AOC AGON 34" 3440x1440 G-SYNC monitor
Latest version of the script, which I downloaded just a few days ago

I typically use the vulkan API and winvk context, along with the FSRCNNX and SSIMDownscaler shaders. I've tried turning all my shaders off, though, as well as changed to various APIs, but no luck.

Hello, one thing to try quickly, would be to set deviation = 0, keep the rest with the default values, but the log will help to be sure what going on.
Edit mpv.conf :
log-file=C:\Users\<username>\AppData\Roaming\mpv\mpv.log -- Or any path you can find easily
Post me the log here or on pastebin, i'll take a look.
I also use FSRCNNX, KrigBilateral, SSSR, SSD with vulkan API, it's not an issue.

Thanks for the quick reply! I tried adding the script-opts-append=autocrop-deviation=0 option to mpv.conf, but it didn't seem to help, unfortunately. I've attached five files:

One mpv.log each for Kingdom of Heaven and Zombieland, with only dynamic-crop.lua installed (all defaults, except deviation=0)
Another set of mpv.logs with both dynamic-crop.lua and autocrop.lua, which I've modified not to auto-load and to use K as the shortcut, rather than C. I thought this might help figure out what's being done differently between the two scripts. I waited enough time for dyanmic-crop to have a chance to do its thing, and then ran autocrop manually, which worked for both movies. This is my current stopgap solution - using dynamic-crop most of the time and filling in with manual autocrop when it doesn't work.
My mpv.conf, just in case some option or other is causing problems

Just let me know if there's anything else I can do to help diagnose the issue.
kingdom-of-heaven.log
kingdom-of-heaven-autocrop.log
zombieland.log
zombieland-autocrop.log
mpv.conf.txt

I have updated the documentation,

script-opts-append=autocrop-deviation=0

should be script-opts-append=<script_name>-<option>=<value>, e.g. script-opts-append=dynamic_crop-deviation=0, but it's not the issue anyway.
From the logs, with option debug=true (apparently), the collected meta found for Kingdom of Heaven
w=1920:h=822:x=0:y=126 | offX=0 offY=-3 | detected_total=8.05 ratio=nil -- 2,3357 compare to 1920/2.35=817+-1 (816 or 818 have to match)
w=1920:h=820:x=0:y=128 | offX=0 offY=-2 | detected_total=1.752 ratio=nil
w=1920:h=822:x=0:y=128 | offX=0 offY=-1 | detected_total=5.258 ratio=nil -- 2,3357
w=1920:h=824:x=0:y=126 | offX=0 offY=-2 | detected_total=0.917 ratio=nil

and for Zombieland,
w=3840:h=1606:x=0:y=276 | offX=0 offY=-1 | detected_total=0.248 ratio=true
w=3840:h=1608:x=0:y=276 | offX=0 offY=0 | detected_total=0.417 ratio=true
w=3840:h=1604:x=0:y=278 | offX=0 offY=0 | detected_total=15.727 ratio=nil -- 2.39401 compare to 3840/2.39=1606.69+-1 (1606 or 1608 have to match)
w=3840:h=1606:x=0:y=278 | offX=0 offY=1 | detected_total=0.835 ratio=true

This show me that the collected meta is not match as known ratio, that's why the script doesn't approve the crop in 5sec (+1sec allowed to deviate) but should eventually be able to be approved as a fallback after 20sec (+1) in a stable light scene (which can be harder to get, but pass eventually).
I will work on something to get more tolerance on this, in the meantime you can adjust the list of ratios or reduce new_fallback_timer, e.g.
script-opts-append=dynamic_crop-new_fallback_timer=15, don't go to low, or you will end up with false positive crop
script-opts-append=dynamic_crop-ratios={2.4, 2.394, 2.39, 2.35, 2.335, 2.2, 2, 1.85, 16 / 9, 5 / 3, 1.5, 4 / 3, 1.25, 9 / 16}

OK, so good news and bad news. The good news is that simply adding the additional ratios seems to have solved the problem for Kingdom of Heaven, Zombieland, and Pirates of the Caribbean, in addition to the freshly merged Return of the King I just made. The bad news is that Kingdom of Heaven and Paprika continue to cause issues, even when I also added 2.347 to the list (basing that off the dimensions arrived at by autocrop for Kingdom). Oddly, as you said, both Kingdom and Paprika will eventually crop correctly once they hit that fallback of 20 seconds, or 15 if you edit. Can I ask what is done differently at that point that makes it work properly?
Also, I found that adding the options via script-opts-append in mpv.conf caused dynamic-crop to crash upon starting any file, but simply editing the options in the script itself worked fine. No idea why, but I thought I'd report it.

Hello, multiple change that will help with your case have been made, give it a try.

Can I ask what is done differently at that point that makes it work properly?
Simple, new_known_ratio_timer is checked with the list of ratios and new_fallback_timer without it (all stable collected meta long enough)

I recommend avoiding added more ratio to the default list, to reduce the chance of a false positive cropping, and give time to the script to approve the first change of ratio.
You can speed up your test with ], reset with backspace.
Thanks for all the feedback.

The log that you gave me for Kingdom of Heaven, show a 2.3357 aspect ratio, but the fallback timer is here for that.
You should try Interstellar with this script, it's a case of use where it shines.
I consider this case closed, Happy Video !


Mapperly generates mapping to static property.

Explain the bug
Mapperly will generate a broken mapping to a targets static property.
To Repoduce
Expected behavior
Mapperly should not attempt to set a static property via its instance. It should instead not generate a mapping and issue a warning.
Code snippets
public record Model
{
    public int Value { get; set; }
}

public record ModelDto
{
    public static int Value { get; set; }
}

[Mapper]
public partial class MyMapper
{
    public partial ModelDto MapModel(Model model);
}

Generated code
public partial ModelDto MapModel(Model model)
{
    var target = new ModelDto();
    target.Value = model.Value; // Member 'ModelDto.Value' cannot be accessed with an instance reference; qualify it with a type name instead.

    return target;
}

Environment (please complete the following information):

Mapperly Version: 2.8.0 - 2.6.0
.NET Version: .NET 7
Target Framework: .NET 7.0
IDE: Visual Studio 2022
OS: Windows 10

Additional context
I discovered this bug when trying to replicate #376 I think these are different problems.

This seems to be a bug introduced in https://github.com/riok/mapperly/pull/346


OGRE EXCEPTION in docker container

this is warning mesg, it shows up and rviz crash.
OGRE EXCEPTION(2:InvalidParametersException): All framebuffer formats with this texture internal format unsupported in GLFrameBufferObject::initialise at /build/buildd/ogre-1.8-1.8.1+dfsg/RenderSystems/GL/src/OgreGLFrameBufferObject.cpp (line 241)

I've tried to change my environment OGRE_RTT_MODE = Copy, PBuffer or FBO. But it did not work
I'm sure my nvidia driver and cuda have been installed correctly.
rviz -l
[ INFO] [1500027958.109911243]: rviz version 1.11.16
[ INFO] [1500027958.109958128]: compiled against Qt version 4.8.6
[ INFO] [1500027958.110025000]: compiled against OGRE version 1.8.1 (Byatis)
[ INFO] [1500027958.298811667]: Creating resource group General
[ INFO] [1500027958.298898672]: Creating resource group Internal
[ INFO] [1500027958.298915340]: Creating resource group Autodetect
[ INFO] [1500027958.298981122]: SceneManagerFactory for type 'DefaultSceneManager' registered.
[ INFO] [1500027958.299082968]: Registering ResourceManager for type Material
[ INFO] [1500027958.299107620]: Registering ResourceManager for type Mesh
[ INFO] [1500027958.299129928]: Registering ResourceManager for type Skeleton
[ INFO] [1500027958.299160225]: MovableObjectFactory for type 'ParticleSystem' registered.
[ INFO] [1500027958.299198016]: OverlayElementFactory for type Panel registered.
[ INFO] [1500027958.299220149]: OverlayElementFactory for type BorderPanel registered.
[ INFO] [1500027958.299242749]: OverlayElementFactory for type TextArea registered.
[ INFO] [1500027958.299268252]: Registering ResourceManager for type Font
[ INFO] [1500027958.299289497]: ArchiveFactory for archive type FileSystem registered.
[ INFO] [1500027958.299308367]: ArchiveFactory for archive type Zip registered.
[ INFO] [1500027958.299326645]: ArchiveFactory for archive type EmbeddedZip registered.
[ INFO] [1500027958.299343482]: DDS codec registering
[ INFO] [1500027958.299367172]: FreeImage version: 3.15.4
[ INFO] [1500027958.299385643]: This program uses FreeImage, a free, open source image library supporting all common bitmap formats. See http://freeimage.sourceforge.net for details
[ INFO] [1500027958.299475624]: Supported formats: bmp,ico,jpg,jif,jpeg,jpe,jng,koa,iff,lbm,mng,pbm,pbm,pcd,pcx,pgm,pgm,png,ppm,ppm,ras,tga,targa,tif,tiff,wap,wbmp,wbm,psd,cut,xbm,xpm,gif,hdr,g3,sgi,exr,j2k,j2c,jp2,pfm,pct,pict,pic,3fr,arw,bay,bmq,cap,cine,cr2,crw,cs1,dc2,dcr,drf,dsc,dng,erf,fff,ia,iiq,k25,kc2,kdc,mdc,mef,mos,mrw,nef,nrw,orf,pef,ptx,pxn,qtk,raf,raw,rdc,rw2,rwl,rwz,sr2,srf,srw,sti
[ INFO] [1500027958.299501783]: Registering ResourceManager for type HighLevelGpuProgram
[ INFO] [1500027958.299530907]: Registering ResourceManager for type Compositor
[ INFO] [1500027958.299641708]: MovableObjectFactory for type 'Entity' registered.
[ INFO] [1500027958.299669130]: MovableObjectFactory for type 'Light' registered.
[ INFO] [1500027958.299694764]: MovableObjectFactory for type 'BillboardSet' registered.
[ INFO] [1500027958.299718491]: MovableObjectFactory for type 'ManualObject' registered.
[ INFO] [1500027958.299741369]: MovableObjectFactory for type 'BillboardChain' registered.
[ INFO] [1500027958.299756122]: MovableObjectFactory for type 'RibbonTrail' registered.
[ INFO] [1500027958.299814003]: *-*-* OGRE Initialising
[ INFO] [1500027958.299829565]: *-*-* Version 1.8.1 (Byatis)
[ INFO] [1500027958.299846734]: Loading library /usr/lib/x86_64-linux-gnu/OGRE-1.8.0/RenderSystem_GL
[ INFO] [1500027958.300986638]: Installing plugin: GL RenderSystem
[ INFO] [1500027958.301015382]: OpenGL Rendering Subsystem created.
[ INFO] [1500027958.367117235]: Plugin successfully installed
[ INFO] [1500027958.367171105]: Loading library /usr/lib/x86_64-linux-gnu/OGRE-1.8.0/Plugin_OctreeSceneManager
[ INFO] [1500027958.367848951]: Installing plugin: Octree Scene Manager
[ INFO] [1500027958.367877864]: Plugin successfully installed
[ INFO] [1500027958.367927652]: Loading library /usr/lib/x86_64-linux-gnu/OGRE-1.8.0/Plugin_ParticleFX
[ INFO] [1500027958.368684794]: Installing plugin: ParticleFX
[ INFO] [1500027958.368713971]: Particle Emitter Type 'Point' registered
[ INFO] [1500027958.368740483]: Particle Emitter Type 'Box' registered
[ INFO] [1500027958.368765432]: Particle Emitter Type 'Ellipsoid' registered
[ INFO] [1500027958.368787152]: Particle Emitter Type 'Cylinder' registered
[ INFO] [1500027958.368809634]: Particle Emitter Type 'Ring' registered
[ INFO] [1500027958.368829097]: Particle Emitter Type 'HollowEllipsoid' registered
[ INFO] [1500027958.368848413]: Particle Affector Type 'LinearForce' registered
[ INFO] [1500027958.368869442]: Particle Affector Type 'ColourFader' registered
[ INFO] [1500027958.368891160]: Particle Affector Type 'ColourFader2' registered
[ INFO] [1500027958.368910163]: Particle Affector Type 'ColourImage' registered
[ INFO] [1500027958.368932010]: Particle Affector Type 'ColourInterpolator' registered
[ INFO] [1500027958.368955239]: Particle Affector Type 'Scaler' registered
[ INFO] [1500027958.368976735]: Particle Affector Type 'Rotator' registered
[ INFO] [1500027958.368996917]: Particle Affector Type 'DirectionRandomiser' registered
[ INFO] [1500027958.369016788]: Particle Affector Type 'DeflectorPlane' registered
[ INFO] [1500027958.369037138]: Plugin successfully installed
[ INFO] [1500027958.369067526]: CPU Identifier & Features
[ INFO] [1500027958.369088475]: -------------------------
[ INFO] [1500027958.369107995]:  *   CPU ID: GenuineIntel: Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz
[ INFO] [1500027958.369127078]:  *      SSE: yes
[ INFO] [1500027958.369145436]:  *     SSE2: yes
[ INFO] [1500027958.369163349]:  *     SSE3: yes
[ INFO] [1500027958.369179999]:  *      MMX: yes
[ INFO] [1500027958.369197648]:  *   MMXEXT: yes
[ INFO] [1500027958.369216389]:  *    3DNOW: no
[ INFO] [1500027958.369236148]:  * 3DNOWEXT: no
[ INFO] [1500027958.369254938]:  *     CMOV: yes
[ INFO] [1500027958.369273773]:  *      TSC: yes
[ INFO] [1500027958.369293837]:  *      FPU: yes
[ INFO] [1500027958.369311093]:  *      PRO: yes
[ INFO] [1500027958.369328632]:  *       HT: no
[ INFO] [1500027958.369345515]: -------------------------
[ INFO] [1500027958.369362483]: ******************************
*** Starting GLX Subsystem ***

***Ignore useless info***
[ INFO] [1500027958.453080369]: All done
[ INFO] [1500027958.453090168]: Parsing scripts for resource group rviz
[ INFO] [1500027958.453694216]: Parsing script glsl120.program
[ INFO] [1500027958.454960076]: Parsing script nogp.program
[ INFO] [1500027958.455773749]: Parsing script glsl150.program
[ INFO] [1500027958.456462979]: Parsing script indexed_8bit_image.material
[ INFO] [1500027958.456618534]: Parsing script default_pick_and_depth.material
[ INFO] [1500027958.456873282]: Parsing script point_cloud_point.material
[ INFO] [1500027958.457086482]: Parsing script point_cloud_tile.material
[ INFO] [1500027958.457314310]: Parsing script point_cloud_sphere.material
[ INFO] [1500027958.457545459]: Parsing script point_cloud_square.material
[ INFO] [1500027958.457755569]: Parsing script point_cloud_flat_square.material
[ INFO] [1500027958.457968030]: Parsing script point_cloud_box.material
[ INFO] [1500027958.458152804]: Parsing script arial.fontdef
[ INFO] [1500027958.458212722]: Finished parsing scripts for resource group rviz
[ INFO] [1500027958.458230670]: Creating resources for group rviz
[ INFO] [1500027958.458242516]: All done
[ INFO] [1500027958.462612035]: GLRenderSystem::_createRenderWindow "OgreWindow(1)", 100x30 windowed  miscParams: FSAA=4 contentScalingFactor=1 externalGLControl= macAPI=carbon parentWindowHandle=75497500
[ INFO] [1500027958.488499080]: GLXWindow::create used FBConfigID = 209
[ INFO] [1500027958.576245149]: Mesh: Loading rviz_sphere.mesh.

**[ WARN] [1500027958.580338242]: OGRE EXCEPTION(2:InvalidParametersException): All framebuffer formats with this texture internal format unsupported in GLFrameBufferObject::initialise at /build/buildd/ogre-1.8-1.8.1+dfsg/RenderSystems/GL/src/OgreGLFrameBufferObject.cpp (line 241)
terminate called after throwing an instance of 'Ogre::InvalidParametersException'
  what():  OGRE EXCEPTION(2:InvalidParametersException): All framebuffer formats with this texture internal format unsupported in GLFrameBufferObject::initialise at /build/buildd/ogre-1.8-1.8.1+dfsg/RenderSystems/GL/src/OgreGLFrameBufferObject.cpp (line 241)**

I would guess that it is something related to your docker setup. Perhaps someone else on answers.ros.org who uses rviz within docker can help you.
I don't see any evidence of this being a bug in rviz, so I'll close this for now. If we find an issue with rviz (like if other 3D programs work in your docker but rviz doesn't) we can try to reopen this. But I won't probably have time to look into it myself.


audio to video recipe

Recipe for audio to video conversion with optional choice of adding a background image

Also, we need to add the link to this recipe in the top-level readme.

will add the link to the top level readme. As for the notebook naming, I plan to rename the others to main.ipynb as well. The directory name for each recipe is more than sufficient imo.


Access Site Metadata

Any way to access site metadata in jsx?

So I found it in props.metadata.
This may be outside of your scope, but what are you thoughts about displaying the metadata in the site's header? So, for instance, displaying the title of the site in the title tag.

Okay, just rendering the head as a react component, wasn't sure if that was possible.
Thanks for your work on this plugin!

Another way is to use something like react-helmet.

Oh yeah, I forgot about that one. Love the name, too, coming from the devs at NFL


AIDER-1977: Add a new argument litellm-extra-headers

Fixes issue 1977
My company uses a centralized LLM proxy, so we need a way to provide global litellm headers that apply to all model requests.  Here's a simple new config option that takes in a list of headers to add for all models.

Thanks for the effort here. I was struggling with the use of a semicolon-separated list of key-values, as it has limitations on what you can express. I just merged a different approach:
https://aider.chat/docs/config/adv-model-settings.html#global-extra-params

Great.  Much appreciated!


🔖 Alpha version

🔨 Refactor
✨ Make url parameter optional

Codecov Report

Merging #10 (a6cd6ff) into master (c49ddea) will decrease coverage by 2.70%.
The diff coverage is 47.82%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   58.06%   55.35%   -2.71%
==========================================
  Files           1        4       +3
  Lines          93      112      +19
==========================================
+ Hits           54       62       +8
- Misses         39       50      +11

Impacted Files
Coverage Δ

browsers/windows.py
17.77% <17.77%> (ø)

browsers/osx.py
43.75% <43.75%> (ø)

browsers/__init__.py
86.20% <77.77%> (+28.14%)
:arrow_up:

browsers/linux.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c49ddea...a6cd6ff. Read the comment docs.


Add Movenet pose estimation TFLite sample

Added Movenet Thunder and Movenet Lightning
Create an unified interface PoseDetector that resembles the TFLite Task Library APIs.
Refactored the preprocessing pipeline to significantly improve fps.

@lintian06 Thanks for the review. I've addressed your feedback. PTAL.

Is this a replacement for the Posenet example? Will be removing that one? Are there any functional (app user-facing) differences besides supporting additional models?

Is this a replacement for the Posenet example? Will be removing that one?

Yes it is. We will not remove the posenet one immediately to preserve the internal test pipeline. @lintian06 can clarify better (maybe in an email thread rather than on GitHub)

Are there any functional (app user-facing) differences besides supporting additional models?

There are significant changes in how we preprocess the input image received from the Camera2 API to improve performance. Besides, there are some minor UI changes include:

Allow changing model and delegate during runtime.
Show inference speed using a TextView instead of drawing it directly on the output Bitmap.

@lintian06 @lu-wang-g I've addresses all comments. Please review again. Thanks!

@khanhlvg as you rightly commented on june 18 21', Movenet does not work with GPUDelegate yet,
Do you have any solution for this? Been bugging for a while as it makes movenet unusable for mobile apps unfortunately.


 Thanks.

Better double check with @esbullington first. Also might look into his new data format ideals, see #85 and #82.

Yes, I think @frederickfogerty proposed data format is good.  I mean, I rarely see multiple series in candlestick charts, but it fits out existing data format better (which is now in the v0.2.0 branch, I'll merge it to master in the next day).
Oh, and would you mind using colors from the d3.scale.category20c() palette as the default colors?  Unit tests would also be great but if you don't have time I'll be happy to do them.  And can you use the axes components from the common directory?  I hope to switch those over to native React in the next few days, but it'll have the same API, so my changes shouldn't any of your work.  That way, all our Cartesian coordinate charts will use the same axes.
Looking forward to seeing the candlestick chart, @rrag  Thanks again!

@esbullington excited for native React axes!

:thumbsup:

I merged from v0.2.0 and made some progress, check out my fork when you get a chance. where do you see the colors from d3.scale.category20c() being used?
will add the tests and send a PR

Hey @rrag great I'll check the fork as soon as I can.   The colors from category20c() are here.  However, note that you can create a function by doing:
var colors = d3.scale.category20c();

And then whenever you call colors with an index, it returns the corresponding color from that palette.  So if you're mapping over an array of data series, you could just call color(idx). Otherwise, you can use the colors manually from that palette.
Looking forward to checking it out!

Hey @rrag looks great!  I haven't gotten a chance to review the code very carefully yet, but the chart itself is great!
Looking forward to your PR! Before you submit it, you'll probably want to either rebase off of master or merge, whichever you prefer.  Since it's a new chart altogether, a merge may be more straightforward.
Please let me know if you have any questions/concerns.

I did not explain my question about d3.scale.category20c() well. we have 2 colors in each candlestick series, one where close > open and other when close < open, currently I am defaulting to green and red respectively. Using a color based on the index of the series gives only one color per series, while we need 2 in this case. Some candlestick charts also use hollow ( fill : none; ) to indicate close > open, so using a function to get the color will limit the flexibility of this. So I guess I am trying to say we should not use a color based on series index, index we should have flexibility to pass props like
 <CandleStickChart
   data={...}
   ...
   ...
   fillUp= {d3.scale.category20c()}
   fillDown= {d3.scale.category20b()}
   ... />

so each series can have a different color pallete, or use
 <CandleStickChart
   data={...}
   ...
   ...
   fillUp="none"
   fillDown="green"
   ... />

I will wait for you to release v0.2.0 and merge after that, before I send a PR

Understood.  I think a nice effect would be to default to none for fillUp, like you're suggesting, along with a default of d3.scale.categoryc() for the fillDown.  The reason I wanted to stick with a single d3 palette per chart is not just for aesthetics (although it's nice) but also because these palettes are designed to be high contrast and so easily distinguishable among  series.  If we mix two palettes, we might end up with two non-contrasting colors.  Not a big deal, but I'd prefer to default to none like you suggest for fillUp, and then the palette of colors from category20c() for fillDown.
You could then expose the fillDown prop to users, who could pass in a colors function like they can do on the other charts, like you show in your first example.  If you want to expose fillUp, as well, it's up to you.
In a given chart, as long as there are at least a few days when the market is down at close, then that should provide good contrast between different series.  What do you think?

Thanks, I have gone ahead and used both fillUp and fillDown properties to the CandleStickChart. fillUp defaults to white. none wont work because it will create a no fill rectangle and the wick behind it is visible.
I also had to update the utils.flattenData to handle the condition where yAccesor returns an object (like {open:... , high:... , low:... , close:... })
Like before please checkout my fork when you can. I need to add tests and will send a PR after that.

Hey @rrag looks great!  Could I ask you to maybe move your flatten data function to something like flattenObjectData and then restore the old one to flattenData?  The old version supports array accessors(ie, (d)=>d[0]), which a lot of people use in d3.  And I'm using nested array data in one of the examples, which the new version breaks.
Alternately, you could special case nested arrays in your new version, but both your version and the original are already lengthy functions.
If you can think of some other solution, please let me know.
Other than that, looks great!  Looking forward to your pull request.

I see. The tests are broken, I should have run them first.
I am not going to create a new method for this as I don't see a need for it, I just made a change to include a check for y to be typeof object. Will send a PR with the fixes and tests soon.

@rrag I'm closing this issue since your candlestick chart is merged.  Please feel free to open another one if you have any other concerns about it.


Fix issue with account query db for release/2.1.x

Merge EOSIO/eosio-security#358 into release/2.1.x

Fix issue with account query db that could result in incorrect data or hung processes

This PR was closed due to the branch deleted accidentally during release v2.0.12. Another PR#10280 has been created for the same.


Feature Request: folders or groups for express objects

On large sites with many non-related objects, it would be useful to have a way to group related objects together to organize them.
Here are example screenshots of a real world project that uses many non-related express objects.

Here is a quick mockup of the idea.

Also, re-ordering those items in the dashboard would be convenient as well.

Considering what Express can do now, and the direction it's headed, with the relational options, this really is something that is eventually going to be required to keep larger sites manageable. Not just the grouping, but the ability to change sorting of them too. I hate creating something after the fact and it being out of order and then the visual disorganisation of that. And that's just at new site creation! During the lifespan of a popular site this could happen many times, and having mechanisms to keep them organised pays off dividends.
Oh, and being able to sort attributes within Express Objects would be fabulous too, but that's not what this particular issue is about ;)

Yeah, the attribute section is bothersome, but it doesn't have much impact ultimately as the interface for editing can be controlled very powerfully via the entity forms. But I hear ya. 👌

I'm building out more and more Express Objects for my websites, and I'm actually really wanting this! Both the grouping and sorting. Right now, I can't tell for the life of me how sorting is done, and uhhhh... I have a healthy amount of Express Objects, and I'm just getting started.
Any chance we can get this tied to a milestone?

Excited for improvements on this! Also, searching for Express Objects might be nice to have too...


Remove minidump.vm

Details
The url that we were using to downloading MiniDump is not available anymore: https://github.com/Mr-Un1k0d3r/MiniDump/archive/98a21941831b90b203fdbfb253cd0b3dc27a0475.zip :anguished:
@Mr-Un1k0d3r is there other url we can use to install MiniDump? 😊
Otherwise we will have to get rid of this package. 😢

I was able to find this one but honestly not sure how out-of-date it is.
https://github.com/rvrsh3ll/MiniDump

@mandiant/commando-vm should we use that version or get rid of this package?

To fix this package we would need to replace VM-Install-Raw-GitHub-Repo by VM-Install-From-Zip, as this function has been removed in https://github.com/mandiant/VM-Packages/pull/988

Also to note, that version does not have a release build on github.

Commando-VM is good to bin the package.

Fixed in https://github.com/mandiant/VM-Packages/pull/1105


No such host when restoring an ark backup

What steps did you take and what happened:
[A clear and concise description of what the bug is, and what commands you ran.)
I created a Kubernetes environment in a Public Cloud provider, then I followed the instructions I am creating at https://medium.com/@epatro/using-ark-to-back-up-your-applications-deployed-to-ibm-cloud-private-4f2e2dc0ce91 to deploy a sample application (Redis) and restore it.
What did you expect to happen:
When I try to restore ark backup, I am getting the error below:
The output of the following commands will help us better understand what's going on:
(Pasting long output into a GitHub gist or other pastebin is fine.)
patro:~ edu$ ark restore describe my-backup-20180911181631
Name:         my-backup-20180911181631
Namespace:    heptio-ark
Labels:       <none>
Annotations:  <none>

Backup:  my-backup

Namespaces:
  Included:  *
  Excluded:  <none>

Resources:
  Included:        *
  Excluded:        nodes, events, events.events.k8s.io, backups.ark.heptio.com, restores.ark.heptio.com
  Cluster-scoped:  auto

Namespace mappings:  <none>

Label selector:  <none>

Restore PVs:  auto

Phase:  Completed

Validation errors:  <none>

Warnings:  <error getting warnings: Get http://minio.heptio-ark.svc:9000/ark/my-backup/restore-my-backup-20180911181631-results.gz?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=minio%2F20180911%2Fminio%2Fs3%2Faws4_request&X-Amz-Date=20180911T223336Z&X-Amz-Expires=600&X-Amz-SignedHeaders=host&X-Amz-Signature=7d076c68eceef9d28cf8ad7c97f9c4bb2bb5d52c7361532aca048de289bea824: dial tcp: lookup minio.heptio-ark.svc on <IP_ADDRESS>:53: no such host>

Errors:  <error getting errors: Get http://minio.heptio-ark.svc:9000/ark/my-backup/restore-my-backup-20180911181631-results.gz?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Content-Sha256=UNSIGNED-PAYLOAD&X-Amz-Credential=minio%2F20180911%2Fminio%2Fs3%2Faws4_request&X-Amz-Date=20180911T223336Z&X-Amz-Expires=600&X-Amz-SignedHeaders=host&X-Amz-Signature=7d076c68eceef9d28cf8ad7c97f9c4bb2bb5d52c7361532aca048de289bea824: dial tcp: lookup minio.heptio-ark.svc on <IP_ADDRESS>:53: no such host>

kubectl logs deployment/ark -n heptio-ark
ark backup describe <backupname> or kubectl get backup/<backupname> -n heptio-ark -o yaml
ark backup logs <backupname>
ark restore describe <restorename> or kubectl get restore/<restorename> -n heptio-ark -o yaml
ark restore logs <restorename>

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
<IP_ADDRESS> is the IP of my iam-token-service:
patro:scripts edu$ k get svc --all-namespaces | grep <IP_ADDRESS>
kube-system     iam-token-service                             ClusterIP      <IP_ADDRESS>    <none>        10443/TCP                                                       15d

Environment:

Ark version (use ark version):

patro:scripts edu$ ark version
Version: v0.9.4
Git commit: v0.9.4
Git tree state: clean

Kubernetes version (use kubectl version):

patro:scripts edu$ kubectl version
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.1", GitCommit:"b1b29978270dc22fecc592ac55d903350454310a", GitTreeState:"clean", BuildDate:"2018-07-17T18:53:20Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0+icp", GitCommit:"1c6988c2361d678dab8ea5ddfab82cb52680b20b", GitTreeState:"clean", BuildDate:"2018-04-27T05:47:17Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes installer & version:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):

Hello @patrocinio - reading the blog post, it looks like the instructions ask you to kubectl apply the entire examples/minio directory. Without any edits to those example files, the Ark config will look for Minio at http://minio.heptio-ark.svc:9000. This likely isn't the right URL within your cluster, which is why it's reporting as not being found.
What is the output of kubectl get deployments -l component=minio?

@patrocinio I believe the issue is that your ark client, which I'm guessing you're running on your personal computer, isn't able to resolve the DNS name of your minio service that's running in your cluster.
Our long-term approach for fixing this is to add a new configuration option for s3-compatible backup storage that allows you to specify the public DNS name to use when the ark client retrieves backup and restore logs and other detailed information. You could then configure ingress to the minio service and use that DNS name, which would need to be resolvable outside of the cluster.
In the mean time, you could try to switch the minio service to be a NodePort service, and update the s3url in your ark config to use the exposed NodePort.

Hello @ncdc and @nrb
Thanks for your recommendations.
I switched minio to use NodePort.
Now, I got a question/issue regarding the ark client (running in my laptop).
How do I pass the minio service? I don't use a KUBECONFIG, but I pass a bunch of options using kubectl options
Thank you!

@patrocinio I'm not sure what you're asking - could you please clarify?

Hello @ncdc
thanks for your quick response.
Where do I specify the s3url information in the ark config?

Closed by #1023


Clicking the settings icon makes the screen white (messenger.com)

If I click on the settings icon this happens (using the latest download Daniel tweeted)

Can you help me to reproduce this? Not happening here.

Tried to reproduce again (it kept doing that this morning) but it works
now. Weird
On Thu 9 Apr 2015 at 19:37 Daniel Büchele<EMAIL_ADDRESS>wrote:

Can you help me to reproduce this? Not happening here.
—
Reply to this email directly or view it on GitHub
https://github.com/danielbuechele/goofy/issues/27#issuecomment-91303597.

I can't seem to get this not to happen. Just get a white screen, and then I have to cmd+r to refresh and get the main app window back.

Just had the white screen again, but got it when I clicked on a photo - weird.

Now it is happening to me, too. I'll check this out later.
On 09.04.2015, at 20:30, Raimond van Mouche<EMAIL_ADDRESS>wrote:
Just had the white screen again, but got it when I clicked on a photo -
weird.
—
Reply to this email directly or view it on GitHub
https://github.com/danielbuechele/goofy/issues/27#issuecomment-91319764.

Addition: also the stickers store makes it white

The same thing happens when opening photos for me

fixed


Error: When the modifier option is true, validation object must have at least one operator

What does that mean?

I am getting the same error, would like to find out what's causing it.

@diegodesouza I decided to just use Meteor check instead of this. I find the syntax for describing the types to be nicer, and it works as expected! For example:
Cards = new Mongo.Collection("cards");

// use this function to validate Cards before insertion.
Cards.validate = function(document) {
  check(_.omit(document, '_id'), {
    // _id of a CardType.
    typeId: MeteorIDString,

    // _id of a Space this card belongs to.
    spaceId: MeteorIDString,

    // _id of a wall this card belongs to.
    wallId: MeteorIDString,

    // _id of a board this card belongs to, null if none.
    boardId: Match.OneOf(MeteorIDString, null),

    // a user _id
    createdBy: MeteorIDString,

    createdOn: Date,
  })
}

Cards.before.insert(function(userId, doc) {
  Cards.validate(doc)
})

Items.before.insert is possible with ]collection-hooks](https://atmospherejs.com/matb33/collection-hooks).

I'm getting this same error message when I try to update an document.
I created a collection, but I didn't attach a schema to it.
So why is simple-schema trying to validate it?

Usually this happens because after your update modifier is cleaned, everything has been removed and there is nothing left. So it ends up being the equivalent of doing update(id, {}).


vet complains about "StoreToIngressLister composite literal uses unkeyed fields"

simple make fails like this:
$ make
/home/porridge/Desktop/coding/go/src/k8s.io/ingress/controllers/nginx/pkg/template/template.go
core/pkg/ingress/status/status_test.go:216: k8s.io/ingress/core/pkg/cache.StoreToIngressLister composite literal uses unkeyed fields
exit status 1
make: *** [vet] Error 1

I wonder why the checks which run on PRs did not prevent this from happening?
Is my toolchain too different? go version go1.7.3 linux/amd64

@porridge because the link task in the makefile is using  -min_confidence=0.85 because some code in the gce controller

@porridge please reopen if you still have issues

@aledbf hm, but what does lint have to do with vet? Seems to be a separate task in the Makefile.
I'm assuming you meant lint, not link there.


Add table of contents to format (specification) document.

When viewing the format documentation at http://jsonapi.org/format/, it would be nice if there was a table of contents to quickly navigate the document.

The Format page has gotten a lot leaner now that large sections have been moved to Extensions and Recommendations.
However, I think a TOC would still be nice.

This will be addressed in #531


update index.md

Puts more information into the index.md of Diagnostics page
it should be very general so it doesn't have to be updated permanently

i have updated everything, could you have again a look at it?

Yep, by the way. Before the updates did you merge master to your repo? Because now there is a conflict :)

eh hold on i bonked there something with powershell


Release into ROS Lunar

Apparently this blocks the release of dozens of packages.
Thanks!

This is currently blocked by https://github.com/ros-planning/navigation_msgs/issues/2

What @mikaelarguedas said, also I need to triage the tickets to see what needs to go into Lunar only, if anything.

navigation_msgs is now released

Thanks @wjwwood
https://github.com/ros/rosdistro/pull/14559


Make gist documentation more accessible

Add link to gist-docs repo on the gist repo readme
Add link to widoco page to gist repo and gist-docs readme
gist-docs repo needs an index.html page with links

The Widoco page is program generated. Unless someone says otherwise I'm going to guess that the second bullet above is not part of the Widoco output.
Also, I think the gist README should have links to educational resources. I will add a PR for that here.
The 1st and 3rd bullet points above will need to be done in the gist-docs repo, not here.

I deleted my previous comment because I had misread the original request.

I will be submitting a PR for this
The Widoco page is program generated. Unless someone says otherwise I'm going to guess that this is not a normal part of the Widoco output.
This will need to be done in the gist-docs repo, not here. I will create an issue for it over there.


Having trouble with all not rule.

I'm having some trouble understanding how this rule is working:
rule:
  any:
    - pattern: use std::env::$_A;
  precedes:
    all:
      - not:
        pattern: use std::env::$_A;

The general idea is to make a linter that std::env imports occur before all other imports.
This rule without the all matches:
rule:
  any:
    - pattern: use std::env::$_A;
  precedes:
    not:
      pattern: use std::env::$_A;

$ sg scan
error[use-ordering]: Imports should be ordered.
  ┌─ ./src/main.rs:1:1
  │
1 │ use std::env::args;
  │ ^^^^^^^^^^^^^^^^^^^
2 │
3 │ use std::collections::HashMap;
  │ ------------------------------
  │
  = `use` statements should be ordered.

And this rule without the not matches:
rule:
  any:
    - pattern: use std::env::$_A;
  precedes:
    all:
      - pattern: use std::collections::$_A;

$ sg scan
error[use-ordering]: Imports should be ordered.
  ┌─ ./src/main.rs:1:1
  │
1 │ use std::env::args;
  │ ^^^^^^^^^^^^^^^^^^^
2 │
3 │ use std::collections::HashMap;
  │ ------------------------------
  │
  = `use` statements should be ordered.

This is the sample project I'm experimenting with: ast-grep-example.tar.gz

Hi, you can use the https://ast-grep.github.io/playground.html as a reproduction.

The playground is pretty sweet. Here it is on the playground.
I'm still having trouble reasoning about why that doesn't work.
Also, the example I've provided is an extremely limited portion of a larger problem. In case it was your intention, the larger problem can not be solved using the method you've indicated. I'll need to identify order based on partial package names.


Better debugging tools for t8n tools

Currently there are no sufficient tools to aid debugging the behavior of the t8n tool if it's having an issue with any of the tests included in this repo.
A good starting point would be to retain the information and files passed to t8n when running a specific test.

Fixed by #219


Create a list of inefficient hardware mappings

The mapper is not utilizing all available operators on the CGRA efficiently:
less than, greater than - currently using two operators (less than: gte -> not;   greater than: lte -> not)
should be implemented using 1 CGRA tile using 1-bit flags
max, min - currently using two operators (min: lte -> mux;   max: gte -> mux)
should be implemented using 1 CGRA tile (alu op code 4,5)
counter - currently using six instances (reg, 2 const, ult, add, or)
should be implemented using a CGRA-specific mapping
abs - currently using five instances (mux, sge, mul, 2 const)
should be implemented using 1 CGRA tile (alu op code 3)
CGRA spec: https://github.com/StanfordAHA/CGRAGenerator/wiki/PE-Spec

less than, greater than, max, min, abs
all are mapping correctly now.
Counter does not exist in hardware, so mapping is doing as well as possible.


v4: className not working

Sorry, that I'am opening yet another issue, but it seems that v4 broke the className prop on the component. The classes appear to not be placed on the container anymore

Yes, you're right, fixing it ASAP!

@phuhl fixed, just update to<EMAIL_ADDRESS>and let me know!

Thanks for the fast fix, worked!


UI Improvement in Home Page

Is your feature request related to a problem? Please describe.
The Home page is not attractive , info should be present in an easily readable format
Describe the solution you'd like
The key features of the project can be presented in the form of cards rather than a bullet list. An image can be added to the front page to demonstrate the entire website. This will be accompanied by complete documentation, allowing us to make necessary changes to enhance its attractiveness and improve the user experience.
Describe alternatives you've considered
A bit of framer motion can be used
Additional context
Kindly assign this issue to me under hactoberfest, gssoc-ext and relevant tags.

@Bhum-ika Sure, go ahead with the improvements, but please ensure the UI remains sleek and minimalist, consistent with our current design. Also, make sure to fetch the latest changes from the develop branch and push your changes to the develop branch only. Looking forward to seeing your updates!

Suree


Support newUniqueId and idFromString

This solves #21 and #29.  If get() is called with an undefined id then it is generated with newUniqueId, and if an existing Cloudflare-generated 64-digit is passed in then idFromString is called instead of durable.idFromName(id)

@kwhitley Here is an example I created that uses both of these new methods.  The key advantage of this approach is that it's significantly faster for new IDs as there is no round-the-world check for existing DOs by a given name:
import { error, json, Router, withParams } from 'itty-router'
import { createDurable, withDurables } from '../../src' // from 'itty-durable'

const router = Router()

router
  .get('*', withDurables(), withParams)
  .get('/', ({ Fetcher }) => Fetcher.get().location())
  .get('/:id', ({ Fetcher, id }) => Fetcher.get(id).location())
  .get('/:id/:target+', ({ Fetcher, id, target }) => Fetcher.get(id).fetcher('https://' + target))

export class Fetcher extends createDurable({ autoReturn: true, autoPersist: true }) {
  constructor(state, env) {
    super(state, env)
  }

  async location() {
    const id = this.state.id.toString()
    const { colo } = await fetch('https://workers.cloudflare.com/cf.json').then(res => res.json())
    return { id, colo }
  }

  fetcher(url, options = {}) {
    return fetch(url, options)
  }
}

export default {
  fetch: (req, env, ctx) => router.handle(req, env, ctx).then(json).catch(error)
}


Connect to SAP HANA, express edition using JDBC

Tutorial URL: https://developers.sap.com/tutorials/hxe-connect-hxe-using-jdbc.html
Please specify the step you are referring to
Step 1: Install the SAP HANA client
The link to the SAP Store is broken. Isn't there an easier way to get my client libraries?

mpern - can you try the SAP Store link again? It should open a page asking if you want to stay on the United States site, or choose another country or region.

Still doesn't work.
BTW, newer driver versions of ngdbc are available in Maven (like they should be 😄 ), I think you should add a link to those + a compatibility matrix which driver to use with which HANA version.
https://mvnrepository.com/artifact/com.sap.cloud.db.jdbc/ngdbc

@Lsubatin - is there a location-agnostic link we use for the SAP Store so users can download HANA client software packages? It appears the link in the tutorial doesn't work for users in all countries.
Can you respond to the Maven repository / compatibility matrix request?

This is an option: https://tools.hana.ondemand.com/#hanatools
And HXE's download manager offers to download the clients too: https://www.sap.com/cmp/ft/crm-xu16-dat-hddedft/index.html

@mpern Is the issue resolved?

No.
While my issues are solved (I used the drivers from maven), the documentation is still wrong:

The links still point to the SAP Store
No link to maven or a compatibility matrix as discussed above

@Chris-Huston: would you be able to update this JDBC tutorial (formerly a how-to) per the feedback above?

@JCurrie27 Not sure Chris is going to answer this :-) Can you handle or reassign?

Link to compatibility matrix SAP Note was added to https://developers.sap.com/tutorials/hxe-connect-hxe-using-jdbc.html.
Closing this issue.


fix(versions): update Activiti/activiti-cloud-notifications-graphql versions into master

UpdateBot pushed maven dependency: org.activiti.cloud.notifications.graphql:activiti-cloud-notifications-graphql-dependencies to: 7.1.126

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.notifications.graphql:activiti-cloud-notifications-graphql-dependencies 7.1.126


Add mandatory "perl" META field

The perl field specifies the minimal perl version for which this distribution can be installed and is a mandatory field. The value of "6.*" indicates any version suffices.
It is recommended to use Test::META module as an author test, to catch any issues with the META file.

Done in https://github.com/azawawi/perl6-net-curl/commit/eb92ff35784ff7dc176fbfa443748ac93b491b5c.


HOPS-50

add timeout to some test having no timeout to make results in Jenkins more coherent.
https://hopshadoop.atlassian.net/browse/HOPS-50

Jenkins test this please.

Jenkins test this please.


Added clarity around device code flow usage

This is a common issue overlooked, so calling it out explicitly.

@maliksahil : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Closing as mentioned in https://github.com/MicrosoftDocs/azure-docs/pull/81312#pullrequestreview-770527994.
#please-close


engine(dm): add error handling mechanism for sharding ddl

What problem does this PR solve?

Issue Number: ref #5504
What is changed and how it works?

add reset api

Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/hold waiting for #7858


Turn off light by default?

On the web version, which I think is awesome, I was a bit bothered by the lighting.
On example 1 which has flat surfaces, we can clearly see how lighting can strongly reduce contrast (by that I mean the gradation of colors) and alter the information.
With light: Solution is not rendered properly

Without light: OK

To me, light off makes more sense than on, and should be the default. That's only my take on it though.

This is a tricky one -- 3D objects look better with light, but you are absolutely correct that 2D objects (e.g. a cut in a 3D object, or a surface looked from above) should be viewed without light on.
For example in the above plot, if there was no cut and mesh (press mi) turning off the light will not look good by default.
The default in GLVis is to have the light on when visualizing 3D meshes, 3D solutions and 2D solutions, and to have the light off when visualizing 2D meshes. This make sense to me, since we have volume/surface objects in the first 3 cases, while in the last case we really want to look at a 2D object.
I think we should keep those defaults, and hopefully users will get used to turning off the light when looking at 2D views. Personally, I have the Rjl memorized by my fingers :)
Does this make sense?
Tzanio

I didn’t know that there was a change of default for light between 3D and 2D. I agree that "3D objects look better with light", and I guess all depend on the primary goal of GLVis. I was looking at this with a priority on accuracy over rendering of 3D shapes and beauty.
Is there a way to have a "flat light" rather than was looks like a punctual one? It would help a bit, but wouldn't be an outstanding solution I guess.

Maybe I'm not saying it well 😁. It is not a question of beauty.
A 3D scene without lighting just doesn't look 3D. I believe all major vis tools have lights on by default in 3D.
On the other hand, a proper 2D plot should not have the light on, which I think is the case for all the examples on glvis.org/live.
It is just one key l to switch it on/off... not to mention that we now also have a button for it the GUI 😉

OK, OK, it's a one keystroke thing, I can definitely live with that :D.


ToString instance for Xml does not correctly escape

Prerequisites
Please put an X between the brackets as you perform the following steps:

[x] Check that your issue is not already filed:
https://github.com/leanprover/lean4/issues
[x] Reduce the issue to a minimal, self-contained, reproducible test case.
Avoid dependencies to Mathlib or Batteries.
[x] Test your test case against the latest nightly release, for example on
https://live.lean-lang.org/#project=lean-nightly
(You can also use the settings there to switch to “Lean nightly”)

Description
While the XML parser correctly handles XML escape sequences, the stringifier does not emit them.
Context
Zulip thread. This leads to some mangled markdown in doc-gen, which unknowingly tries to work around this bug.
Steps to Reproduce
Run the following:
import Lean

run_cmd do
  let .ok doc := Lean.Xml.parse "<b class=\""\">hello < world </b>" | unreachable!
  Lean.logInfo (toString doc)

Expected behavior: The output is <b class=""">hello < world </b>
Actual behavior: The output is <b class=""">hello < world </b>, which is invalid XML
Versions
4.9.0-rc1
4.10.0-nightly-2024-06-09
Additional Information
[Additional information, configuration or data that might be necessary to reproduce the issue]
Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

I'd like to open a PR to fix this. Any suggestions?


video_player fixTransform error in iOS

video url: -
The operation effect is as follows：

Delete the code on line 244 of FLTVideoPlayerPlugin.m to get the correct effect：

It is obvious from the above two pictures that the right side of picture 1 has been cropped.
Environment
video_player: 2.2.7
flutter: 2.5.3
iOS 15.1

Okay, this video should not be made public, I want to delete the video link, if you need to test the video, please contact me.

The deleted line in question was
https://github.com/flutter/plugins/blob/video_player-v2.2.7/packages/video_player/video_player/ios/Classes/FLTVideoPlayerPlugin.m#L244 from https://github.com/flutter/plugins/pull/690


Adding dump command?

In light of the pending Laravel 5.5 release, so you have any plans for add dump and/or dd commands?

Suggestions:
Set a debug flag in Collect, so eatch step of the chain is dumped to console..?
Could also be in indexed order.

i will take over this
expect to see a pull request tomorrow

Thanks for reporting.
Added

concat
crossJoin
dd
dump
intersectByKeys
macro
mapInto
mapToGroups
unless
unwrap
wrap

This is fixed in the latest release, 3.0.50


Add requests to requirements.txt

It looks like this requirement landed with 8e9931b3 (Prototype of
workshop homepage validation, 2014-12-24, #111).  Personally, I'd
rather just stick with the standard library's urlopen [1,2] and avoid
the extra external dependency.


Dynamically Updating Jupyterservers

Currently editing/updating an existing and running jupyterserver will result in nothing happening or even worse in some weird cases in crashes. That is the reason we do not really edit the main spec of running/existing jupyterservers.
When Amalthea was initially implemented all the cases of updating/changing major components of the spec when a server already exists was not implemented. A little bit of things have changed since. But we still need to document and ensure what part of the spec can change and how amalthea will react.
A good user story that would be supported by this feature is being able to change the resource requests of an existing session. We should be able to do this and Amalthea should restart the session (without losing user data) and after a short interruption in the session the user should be back into their newly defined session.

related to: #32


circulating lipid terms

If this is a request for a new term, please provide us with the following information.

Preferred term label (e.g., asplenia)

increased circulating LDL phospholipid level
increased circulating VLDL phospholipid level
increased circulating HDL triglyceride level
increased circulating LDL triglyceride level

Synonyms (e.g., absent spleen)

Textual definition (the definition should be understandable even for non-specialists. Include a PubMed ID or URL(s) to refer to any relevant article(s) that provides information about the suggested term).

increase in the concentration in the blood of LDL phospholipid
increase in the concentration in the blood of VLDL phospholipid
increase in the concentration in the blood of HDL triglycerides
increase in the concentration in the blood of LDL triglycerides
PMID:8301098

Any additional notes to clarify the meaning or use of the term. Please provide a PubMed ID or URL(s) for the source of this information.
Suggested parent term (Please look in the hierarchy of the MP using the MP Browser or other browsers such as OLS and find the place in the MP where the new term best fits)

increased circulating non-HDL phospholipid level (MP:0020128)
increased circulating non-HDL phospholipid level (MP:0020128)
increased circulating triglyceride level (MP:0001552)
increased circulating triglyceride level (MP:0001552)

If you would like a nanoattribution, please indicate your ORCID id or provide a label such as MGI:sbello (organization, first initial-last name)

RGD:sjfl

Need to improve definitions by specifying what each complex is
LDL phospholipid - complex of low density lipoproteins, small (18-25 nm) and low density (1.019-1.063 g/ml) particles, and phospholipids, lipids containing phosphoric acid as a mono- or di-ester
CHEBI:39026
CHEBI:16247
VLDL phospholipid - complex of very low density lipoproteins, large (30-80 nm) and very low density (0.93-1.006 g/ml) particles, and phospholipids, lipids containing phosphoric acid as a mono- or di-ester
CHEBI:39027
CHEBI:16247
HDL phospholipid (fix existing definition) - complex of high density lipoproteins, small (4-13 nm) and dense (greater than 1.063 g/ml) particles, and phospholipids, , lipids containing phosphoric acid as a mono- or di-ester
CHEBI:39025
CHEBI:16247
HDL triglyceride - complex of high density lipoproteins, small (4-13 nm) and dense (greater than 1.063 g/ml) particles, and any glyceride resulting from the condensation of all three hydroxy groups of glycerol
CHEBI:17855
LDL triglyceride - complex of high density lipoproteins, small (4-13 nm) and dense (greater than 1.063 g/ml) particles, and any glyceride resulting from the condensation of all three hydroxy groups of glycerol
CHEBI:17855
What does "non-HDL phospholipid mean"?  MGI has 1 annotation from PMID:23846500 for the non-HDL terms. From this it seems that non-HDL is just the fraction that is not HDL and would cover LDL and VLDL along with free. So using this a parent makes sense. But, the definition needs to be improved.

Added abnormal, increased and decreased circulating levels


Windows: TERM variable doesn't work on WSL

Which operating system does the issue occur on?
Windows 10
To reproduce:

Set shell.program to wsl and TERM variable in alacritty.conf
Open alacritty
Check $TERM variable, still default

Tried with alacritty terminfo and xterm, default is xterm-256color

Have you checked that you're editing the correct config file? You can see where the loaded config is located by running alacritty -v.
Also please share your config to make sure you've set everything up properly.

I'm sure proper config file is in use and it's modified slightly so I would've noticed if it wasn't
My config file https://del.dog/asiquliyuf.sh

When you start another WSL shell or Alacritty with -e wsl.whatever and prepend TERM=xterm, does that do the job?
It's possible that WSL is just setting this environment variable itself after startup, at which point there's nothing Alacritty can do and this needs to be resolved in the WSL config.

Sorry, it's a bit unclear what to do to me
Tried running ./alacritty -e wsl TERM=xterm but it just crashes even with TERM=xterm256-color

You're supposed to put it before the command, to set the environment variable for that command.

Nope, doesn't work as well, still default

Sounds like there's nothing Alacritty can do then and it's done by WSL itself at startup. You'll have to set the term variable in your shell config then, that should definitely work.

Found the way to workaround this issue
WSL accepts WSLENV variable that can contain env variables divided by : (tested in cmd)
So it can be fixed by:
set TERM=alacritty set WSLENV=TERM && wsl

That sounds like the proper way to do this with WSL then. Closing as resolved.

Yeah it is but is there any possibility to simplify handling of this?
I can't find fancy way to do this via alacritty config now
And starting alacritty with WSLENV param won't work as well

I can't find fancy way to do this via alacritty config now

You should be able to put this in Alacritty's env section, right?
If WSL sets environment variables on startup, there's absolutely nothing Alacritty can do about it. Alacritty can only suggest environment variables to WSL, but if it ovrrides these that's up to WSL and you'd have to complain to them (they'd likely just tell you to set WSLENV though I'd assume).

Couldn't try before, srry
Apparently it works this way:
env:
  TERM: alacritty
  HELLO: world
  WSLENV: TERM:HELLO

I tried that with WSL2 but it does not work for me
env:   TERM: alacritty   TEST: test   WSLENV: TERM:TEST
I tried it also with appending /w as suffix to the WSLENV
Like described in this article: https://devblogs.microsoft.com/commandline/share-environment-vars-between-wsl-and-windows/

I tried that with WSL2 but it does not work for me
env:   TERM: alacritty   TEST: test   WSLENV: TERM:TEST
I tried it also with appending /w as suffix to the WSLENV
Like described in this article: https://devblogs.microsoft.com/commandline/share-environment-vars-between-wsl-and-windows/


PLT-7646 Fix progress % values for properties in the Timeline-View grid

https://input-output.atlassian.net/browse/PLT-7646
BE PR https://github.com/input-output-hk/dapps-certification/pull/90

Summary by CodeRabbit

New Feature: Introduced CircularProgressBar and ProgressCard components for better progress visualization.
New Feature: Added RepoAccessStatus component to display repository access status.
New Feature: Implemented StatusIcon component for displaying various status icons.
Refactor: Simplified routing structure in App.tsx and removed unused imports and components.
Refactor: Updated Button component to support passing an icon element.
Refactor: Enhanced TextArea component with onBlur validation and floating label functionality.
Refactor: Improved TableComponent to support collapsible rows and show/hide column functionality.
Refactor: Modified ColViz component for better visual presentation and interaction.
Refactor: Updated useLocalStorage hook for better error handling and value type flexibility.
Bug Fix: Fixed image paths in repoAccessStatus.config.ts.
Test: Commented out test cases for LogsView component.
Chore: Updated CSS styles across multiple components for improved UI.

@RSoulatIOHK Resolved the calculations within the progress% in TimelineView ; and added the Property Based Testing progress card in both Timeline View and Full Report View when run is finished.


PostgreSQL support

I pulled as much database specific code as I found into "includes/class-<mysql|pgsql>.php". I removed the mysql specific backtick syntax everywhere I could (mysql will work w/o it and psql won't work with it). I hacked "docker-entrypoint.sh" over on the docker project (another PR there).
To install pgsql and create the database if pgsql is selected (see "stack.yml" and "stack-pgsql.yml" and "start.bash").
There needs to be a good database selector mechanism, for now I run:

cd users && ln -s ../includes/class-pgsql.php ./db.php

and that selects postgress.  I have not touched the test cases.

Regarding postgresql : the goal here should be to make things compatible with a PGSQL plugin (or other DB engine as you mention) but I don't want to include PGSQL code.
Two simple reasons:

95% of people don't care about pgsql
I don't use psql so I won't maintain this code :)

Removing the backticks wrapping column names shouldn't be problematic (it's all hard coded), however we need them around table names :  MySQL needs backticks for table names with a dash (eg joe-yourls), see for instance #2844. Maybe a helper function, similar to your dt_year(), with something like:
public function get_tablename($table) {
    return yourls_apply_filter('get_tablename', "`$table`");
}

so it's easy for a PSQL/SQLITE/etc plugin to hook into this and remove backticks

Other things to consider : as far as I understand it the upgrade functions too would need complete rewriting

Other things to consider : as far as I understand it the upgrade functions too would need complete rewriting

Yes, or just kept separate like the db code is.  Chose which upgrade module to use on whatever DB flag gets worked out.  And since pgsql is brand new, no old migration code support necessary.

MySQL needs backticks for table names with a dash (eg joe-yourls)

Ah, ok.  The yourls containers for mysql work with this PR but I doubt I had dashes in table names.

95% of people don't care about pgsql
I don't use psql so I won't maintain this code :)

@FrankDupree, thanks for commenting.  And sorry I haven't had time to resolve the conflict put on the pr.
@ozh:
#1: they don't care b/c it isn't available
#2: I didn't either until the pain of switching from mysql was greater than the pain of mysql.  pgsql is a much more competent and consistent db engine.
I wrote the pr b/c I didn't want to maintain 2 db servers and my main project was experiencing too much mysql pain to stay put.

@iWantToKeepAnon since you have lots of experience with this service, what other alternatives could you recommend, im looking at polr or shlink which would you go for?

I am far from an expert on url shorteners.  But looking at the 2:
a) polr only lists mysql as a database, so no change there
b) shlink lists pgsql so that seems to meet your desired db platform; I like the command line interface idea too
I am satisfied with my pgsql plugin/patch for the moment.  It would be nice for it to be in the core product to stay current.

Instead of rewriting things and pulling hair to make queries compatible with pgsql, I think a much simpler option would be to use a query builder, such as https://github.com/auraphp/Aura.SqlQuery/ , to write queries independently from the SQL engine. Then, a one liner plugin would be enough to use pgsql, sqlite or whatever.

... to write queries independently from the SQL engine. Then, a one liner plugin would be enough to use pgsql, sqlite or whatever.

True, that's a big update but I think the freedom of choice payoff would be bigger.


Markdown Live Preview does not render pictures

VSCode Version:
OS Version:

Steps to Reproduce:

Use a relative link to reference a picture that is several subfolders up in your tree structure using Markdown
Open Markdown Live Preview, image does not load

The picture renders fine on Github but not on VSCode. This issue persists for both Markdown .md and Jupyter notebooks .ipynb

Does this issue occur when all extensions are disabled?: Yes

Is the file you are linking to within your workspace? The markdown preview only supports loading resources from the current workspace

Ah that makes a lot of sense, thanks.

Was that the issue?

Yup, thanks!


multi-submit-example.sh is missing from local builds

I followed the instructions in README.md to create spark-bench from sources but the multi-submit-example.sh was missing.
It does appear in the release tgz files.

Oh no! I thought I touched that up. Thanks for the catch! Fixing now

I also noticed that https://github.com/SparkTC/spark-bench/blob/master/readme.md has a number of references to your ecurtin fork. Should they be changed to refer to https://github.com/SparkTC/spark-bench instead?

Yep, you're right about the links! Fixed the references to multi-submit (it was deprecated awhile ago, too out of date) and the old links to ecurtin/spark-bench. Also updated instructions on setting environment variables as there's actually two methods!

Just patched this with #116. Thanks for your attention to detail! I'm gonna close this issue as fixed but lemme know if you catch anything else :)


load_config.loadconfig should not set localconfig['default_bundle_file'] to None

Is this a request for help?: No

Is this a BUG REPORT or a FEATURE REQUEST? (choose one): BUG REPORT

Version of Anchore Engine and Anchore CLI if applicable: v0.2.4
What happened:
Catalog service failed to start with error message:
Exception: unable to initialize default user data - exception: coercing to Unicode: need string or buffer, NoneType found
What did you expect to happen:
Successful start of catalog service.

Any relevant log output from /var/log/anchore:
[service:catalog] 2018-11-05 13:35:23+0000 [-] [bootstrap] [ERROR] cannot create/init/register service: catalog - exception: unable to initialize default user data - exception: coercing to Unicode: need string or buffer, NoneType found
[service:catalog] 2018-11-05 13:35:23+0000 [-] [bootstrap] [ERROR] cannot start service (see above for information)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/anchore_engine/services/common.py", line 362, in makeService
    rc = smodule.initializeService(sname, localconfig)
  File "/usr/lib/python2.7/site-packages/anchore_engine/services/catalog/__init__.py", line 109, in initializeService
    raise Exception ("unable to initialize default user data - exception: " + str(err))
Exception: unable to initialize default user data - exception: coercing to Unicode: need string or buffer, NoneType found

What docker images are you using:
docker.io/anchore/anchore-engine:v0.2.4
I'm using a Kubernetes setup with a config-map mounted to /config in the pod.
How to reproduce the issue:
First I thought this issue was due to the formatting of my yaml-config, but it turned out to be related to the anchore_default_bundle.json file which was missing in my config-map. After adding the file to my config map the error went away.
It is somehow related to the following code in anchore_engine/configuration/localconfig.py:
    # copy the src installed files unless they already exist in the service dir conf
    for key, fname in [('default_bundle_file', 'anchore_default_bundle.json'),
                       ('anchore_scanner_analyzer_config_file', 'analyzer_config.yaml')]:
        try:
            default_file = os.path.join(localconfig['service_dir'], fname)
            localconfig[key] = default_file
            if not os.path.exists(default_file):
                src_file = os.path.join(resource_filename("anchore_engine", "conf/"), fname)
                if os.path.exists(src_file):
                    shutil.copy(src_file, default_file)
        except:
            localconfig[key] = None

I suspect that the localconfig['default_bundle_file'] was set to None by the last line of this snippet which then later on led to the above error message in catalog/__init__.py. However I was not able to analyze further because any exceptions are swallowed by the except block in above snippet. The volume I mount should have write-access so that cannot be the problem.
However, I think localconfig['default_bundle_file'] shouldn't be set to None here.
The final Exception is raised in the initializeService function because os.path.exists cannot be invoked with None.

@fabian-braun we'll take a look. Thanks for the report. Generally, the anchore_default_bundle.json is copied into the "service_dir" location (/config by default) from the installed anchore-engine and should not be required in the config map, but i suspect the way you're mounting the config map is mapping each key as a file. Is that correct? Normally, I'd recommend just setting the "service_dir" key in the config.yaml to a directory other than the default so that the writes go to another directory than /config. Our Helm chart does this to also remove the problem with read-only config map mounts. But the handling in this specific case could certainly be better and clearer.

@zhill yes, correct, I have a config map with each key as a file. I understand your approach of letting service_dir point somewhere else inside the container filesystem. But now that I found out about all this, I'm actually happy that I can provide my own anchore_default_bundle.json in a config map.
Feel free to close this issue if it's too minor :)

@fabian-braun yes, it actually is a nice little feature to be able to provide the default. We'll keep this open as a way to track cleaning up that specific error path since a type issue should never surface to a user.


internal terminal issue

I have a project using ionic3, When I execute 'ionic serve',  it will say: '[INFO] Looks like @ionic/app-scripts isn't installed in this project.' I used to think it is because my project(My project works well at last update). But when I use windows powershell or windows cmd, it works well. So I think maybe there are some problems with this new version. Please check.

This sounds like a problem with your app, not with VS Code. Make sure you're in the right directory when you do that.


json iframe being inserted when there isn't json on the page

I am seeing the following being inserted on the bottom of some of my pages that have no json in them.
This might have just started with version 1.7

#document

    RAW
    <meta charset="UTF-8">
    <title> editedURL </title>
     <link rel="stylesheet" type="text/css" href="safari-extension://com.acrogenesis.jsonview-56Q494QF3L/8b170976/default.css">

           12

good catch! you are right I hadn't noticed, will fix ASAP. If you can make a PR I'll gladly merge it :+1: .

Sorry, I don’t know how to fix it.  I just know that it is happening.

On May 20, 2015, at 8:31 PM, Adrian Rangel<EMAIL_ADDRESS>wrote:
good catch! you are right I hadn't noticed, will fix ASAP. If you can make a PR I'll gladly merge it  .
—
Reply to this email directly or view it on GitHub https://github.com/acrogenesis/jsonview-safari/issues/7#issuecomment-104081158.

Don't worry. Do you have an example on a website that this occurs? I can't reproduce the error.

@dscheck I'm closing this issue but if you do find a website where this happends please re-open it. Also check you have the latest version 1.7

This was happening with a custom non public dynamic webpage.
Are there different versions of 1.7?  That sounds odd if so.
Was anything fixed here or are you saying that you couldn't reproduce?
-dave

On May 23, 2015, at 11:34 PM, Adrian Rangel<EMAIL_ADDRESS>wrote:
@dscheck I'm closing this issue but if you do find a website where this happends please re-open it. Also check you have the latest version 1.7
—
Reply to this email directly or view it on GitHub.

Yeah I didn't explain myself well I meant the latest version was 1.7 (I've just edited my comment). I'm saying I can't reproduce


Updates golang to 1.19, update k8s e2e data and add docs for v0.56.12

What this PR does / why we need it:

Updates to golang 1.19
Updates kind image to 1.25.3
Updates docs

I have changed the PR title as it does more than just updating docs.
integration test is failing - it could be flake but could you take a look at it, @joyvuu-dave?

Thanks for updating the PR title to something more accurate! I'll run the test suite locally and see if I can figure out what might be causing the failure.

How about splitting the PR into multiple PRs? In that way, we can merge PRs sooner while debugging the issue.


depsyncer specifies whether there is a quantity limit for DEP, and what is the impact of a large quantity?

depsyncer specifies whether there is a quantity limit for DEP, and what is the impact of a large quantity?

Basically: the code will decode the larger JSON response in memory (up to the 1000 maximum API limit for Apple). Check out the Ops Guide:
https://github.com/micromdm/nanodep/blob/main/docs/operations-guide.md#-limit-int

limit fetch and sync calls to this many devices (0 for server default)
The limit flag specifies how many devices to fetch at a time from the Apple DEP API. Apple's documentation says there is a server-side default of 100 an upper limit of 1000.

@jessepeterson Not the number of devices, but the number of DEPNAME (ABM)

Ah, are you asking what the limit on the number of "DEP names" is? Answer is: it depends on the storage backend, but effectively: no real "limit." For MySQL there is one-row-per-dep-name, so however many DB rows you want. For the file backend each DEP name is a set of 6 or so files in the single DB directory. So: however big it is practical for filesystem directories to be.

Ahh, I see now, apologies. The real answer: I don't know. We don't have any limitations built-in so you should be able to stack them up. I've only tested it with about 5 at a time. I'd be curious how many you can get going! :)


Removed obsolete ms.prod tag, FAQ updates, and various other misc changes

Removed obsolete ms.prod tag (now superseded by ms.service tag in our central docfx.json file), various formatting fixes, and updated the FAQ to address some issues.
Also fixes #125

Got a few more bugs to address on this PR before it's ready.


Deleting a config causes Choose an existing Balancer Config to be blank

v0.17.0
Steps:

Create a Config and name it a
Create another config and name it b
Go to Add Load Balancer page and click on Re-use existing Configuration (notice a is in drop-down)
Click on Cancel
Go back to Configurations list page and delete a
Go to Add Load Balancer page and click on Re-use existing Configuration

Results:
Drop-down is blank
Expected:
b should show up in drop-down as selected

Standalone balancer and configs removed..

Config page removed from UI


Windows Defender just detected tojan

After i restarted my Game Windows Defender got very angry at me and detected a severe Threat in the Aetherment_core.dll file as a Tojan. I hope that is a false alarm from it.

Duplicate of #6. But yes, it's a false positive and ACT suffers from the same problem (https://github.com/ravahn/FFXIV_ACT_Plugin/issues/324). Aetherment uses the same rust crate retour


Add collaborators to this repo

Comment below to be added as a collaborator
We will all be using this repository today. Even though it's public right now, you will not be able to make changes until you're given the correct permissions. We've automated this process via the GitHub API. Once you comment, we will add you as a collaborator.
You'll start to receive a lot of emails. (❗) You can slow these down immediately by clicking the Unwatch button at the top of the page and selecting either the Participating and @mentions or Ignore option.

This is demo comment.

Adding a comment

Allegis training, making a comment.

This is a demo acct

comment

comment

GH training comment

Github training comment

Training account

GitHub training


assign bitfield fix

Codecov Report

Merging #124 (45c52e1) into main (e7ee99e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   94.10%   94.13%   +0.02%
==========================================
  Files          14       14
  Lines        5651     5674      +23
==========================================
+ Hits         5318     5341      +23
  Misses        255      255
  Partials       78       78

Impacted Files
Coverage Δ

ast.go
94.48% <100.00%> (+0.04%)
:arrow_up:

codebuild.go
94.38% <100.00%> (+0.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ee99e...45c52e1. Read the comment docs.


PMID:14767070

normal mitochondrial membrane potential

normal mitochondrion FYPO:0006034
normal mitochondrial membrane potential FYPO:0006035
edit file: 86054e611c965a4565ba3160cad116b820e88d41
release: 1a66c5a42bb70111a100b2730d4ed28f1c80d707

Shouldn't this term be available by now?

I've put a comment on https://github.com/pombase/canto/issues/1325 asking whether it affects FYPO as well as GO.


Unexport some constants

They don't seem to be used anywhere.
I check a few spots outside.
/assign mattmoor

/lgtm


Clarify ingress section in the hosts.ini

Because of the DaemonSet behind the scenes, only node hosts allowed as ingress controllers.

Yes, DaemonSet only running on node, not on master (BTW, I usually deploy master as a node, too)
Anyway, with my latest changes to ingress-nginx, we add a configurable variable ingress_nginx_nodeselector  which default with node-role.kubernetes.io/master: "true"; moreover, the Ansible group kube-ingress is now removed.
This PR should now able to close.

/lifecycle frozen


Port PyOpenWorm to python3

Advantages:

Other parts of the project, such as movement_validation, are built in python3 - consistency is good.
It seems unlikely that python3 will be abandoned as a failed experiment at this point - given we want the usership of PyOpenWorm to increase over time, it seems better to write forward-compatible than backward-compatible code.
By importing from future, some python3-style code can be interpreted in python2: you can't do the same to interpret python2-style code in python3.
It's a newer version - all the changes which have been made have presumably been made for a reason, resulting in either cleaner, faster, or more robust code.

Difficulties:
There may well be 3rd party packages which don't support python 3... yet. Again, I find it highly unlikely that as time goes on, there will be any important piece of functionality offered by py2 packages which won't have a counterpart in py3. RDFlib and sqlite3 both seem to be supported. libNeuroML may not be, but having a dig through that code there doesn't seem to be any packages which wouldn't support it.
A 'port to python3' issue is the sort of thing which should be on the backlog of absolutely any maintained python project. Currently, it is just on the backlog, and under 'ideas'- surely we plan to do this at some point in the future, and planning for the future is what backlogs are for!
See also: Python 3 Porting HOWTO

Working on this now. I'll keep compat with 2.7 where possible.

Port to Python 3 is done and merged into dev.


Error: Callback was already called

Error: Callback was already called
    at queue.js? [sm]:13
    at Object.obj.complete (index.js? [sm]:13)
    at Object.success (sound.js? [sm]:707)
    at Object.recv (common.js? [sm]:627)
    at BleManager.doCallback (bt.js? [sm]:219)
    at Function.<anonymous> (bt.js? [sm]:288)
    at [publib]:4
    at Timeout._onTimeout ([publib]:4)
    at ontimeout (timers.js:471)
    at tryOnTimeout (timers.js:306)

容易遇到这个错误，看你在别的issue中的解释，这个错误是不是可以忽略呢？

@kangear 这个应该使用错误了，能提供一下复现的例子吗？


How to enable verbose option while using API of lws?

While using the CLI variant, all the verbose is appearing in the console including verbose related to URL rewrite. How to get the same functionality in the case of an API variant of lws?

Listen for verbose event on the localWebServer instance..
Quickly, from the top of my head - something like this:
import LocalWebServer from 'local-web-server'

const options = { /* your options, port, directory etc */ }
const lws = LocalWebServer.create(options)

lws.on('verbose', (key, value) => {
  // process verbose info
}

Thanks @75lb. That works!


[DEV] Implement Landing Page

Development Task 🔧
What? ❓
Complete landing page as per wireframes

@LeonardoKamino looks like you already self-assigned, the wireframes are on Figma!

Merged and complete!


Edit readme

@WALTERKERR @HolixSF @jonwhuang @supermikol Hi everyone, I updated the README.  Pls. answer my pull request.  Still a work in progress, but feel free to add/edit.  TYVM in advance.

Oh hi everyone! ^_^
@jonwhuang tyvm for merging the pull request.
FYI @jonwhuang, @HolixSF, @supermikol, & @WALTERKERR, I was looking at the main page, and because it was merged to Development, the main page still shows up as the old version of the README.
Can those changes also be merged to Master? Let's talk about this.


No output from traktor_nowplaying

Can not get any output from traktor_nowplaying. The nowplaying.txt remains empty. There is no output on the console. My Traktor Version is <IP_ADDRESS>. This is a fresh install on windows 10. I tried it before on mac os. This did not work with the same configuration. I already tried the ports 9000, 8080 and 8001.
Is there anything wrong configured? Please see my screenshots.
Thank you!

Hey, I can't tell from the screenshot but have you turned on the broadcast?
Also, I wouldn't be worried about the browser error page - you're not meant to be able to access it right now. Though I think I will add a message on that page saying this - thanks!

Yes. Thank you! I didn't see this little switch before. Now it works.
The small switch is located in the upper right corner of the mixer view.

Great, thanks for letting me know it works fine!


mockup UI

After entering the API-key kacadu can use the kanka-API to load a list of all campaings of that user - see: https://kanka.io/en/docs/1.0/campaigns
Additionally kacadu can use the kanka-API to load the users profile including the "last_campaign_id" - see: https://kanka.io/en/docs/1.0/profile
Therefore the second step ("target campaign id") can be a dropdown listing all campaigns of the user by name where the default value is given by "last_campaign_id".


Group by tags -> collapse results

First I would like to thanks you for making this.
I use the option Group by gags. It would be great if I can collapse the grouped results

Currently working on this


drbg: ensure fork-safety [master]

Forward-port of #9802.

@mattcaswell, I added the two fixes from #9860 here (the one for the syntax error as simple fixup 4e1d8242041b1954ae88b48358d474d77588055c).
Please reconfirm.

Pushed to master. Thanks for the review!
7f0a8dc7f9 (origin/master) crypto/threads_win.c: fix preprocessor indentation
0768b38b80 drbg: fix issue where DRBG_CTR fails if NO_DF is used (2nd attempt)
5562dbb39c drbg: add fork id to additional data on UNIX systems
849529257c drbg: ensure fork-safety without using a pthread_atfork handler


Added reasonable error message to loadModel parsing

...when feature vector weights don't end with a whitespace character.
Spent a bit too much time this morning debugging this - would've been really helpful to me to just get a straightforward error message suggesting that my model was semantically incorrect from the point of view of the parser, and describing how and where.
The fix is basically to catch the ArrayIndexOutOfBoundsException, and if b > 127, then throw a different RuntimeException with a message actually spelling out what went wrong. Otherwise, just throw the original exception.

Thanks

available in version 2.11


replacing modified swagger files in V20230201 after adding new controllers for Sql Data Classification APIs

ARM (Control Plane) API Specification Update Pull Request
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[ ] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
[x] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ ] I have reviewed the general guidance on the spec PR review process: https://aka.ms/specprreview.
[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data-plane related specifications.
[ ] I commit to follow the Breaking Change Policy.
[ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.

ARM API changes review

If you want for the ARM team to review this PR, you must add the ARMReview label.
The automation may automatically add the ARMReview label, if appropriate.
If this happens, proceed according to guidance given in GitHub comments also added by the automation.

Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help

For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For additional help, see https://aka.ms/azsdk/support/spectools.

this js sdk breaking is not caused by this pr

/pr RequestMerge

@pmahanandire thanks for this PR - I've taken a look into importing this one and it appears there's still a couple of references to the older constant name which are causing us issues:

https://github.com/pmahanandire/azure-rest-api-specs/blob/0a58e97bb58d5e878b628511a0b29111bd184e95/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/SensitivityLabels.json#L279-L292
https://github.com/pmahanandire/azure-rest-api-specs/blob/0a58e97bb58d5e878b628511a0b29111bd184e95/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedDatabaseSensitivityLabels.json#L282-L296

In addition it appears there's an issue with the new IPv6 FirewallRule model, where the name includes a space - whilst we can look into working around that from our side, I'm not sure if that's valid Swagger/OpenAPI, so I'm not sure if that also needs addressing there too? https://github.com/pmahanandire/azure-rest-api-specs/blob/0a58e97bb58d5e878b628511a0b29111bd184e95/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/IPv6FirewallRules.json#L215

On a related note, we're noticing the same issues with these particular constants also exist for the Synapse service too, I understand that's a separate Resource Provider, but I'm unclear if SQL and Synapse are maintained by different teams / who we'd need to reach out to in order to get that one fixed, does the SQL Team own that Resource Provider too?

Tagging a couple of upstream issues on our side, so we can cross-reference this:

SQL: https://github.com/hashicorp/pandora/issues/2842
Synapse: https://github.com/hashicorp/pandora/issues/1508

cc @WodansSon for info

@tombuildsstuff, could you please elaborate on the issues caused by the older constant name, because after this change, the enum names and the values they take are consistent.

@pmahanandire, I have linked @tombuildsstuff PR(#26303) to fix the remaining issue for Pandora SDK import.