Refactor ART01: Replace graphql with rest - Get Dataproduct

This is the first artifact of refactoring markedsplassen, where we want to replace graphql with rest api and optimize database queries to improve performance and avoid the red errors from google anti DDOS policy enforcer.
The PR mainly deal with get data product, which is probably the one that causes the red errors.
The basic idea is to join related tables for a data product to be a "dataproduct_complete_view", with which we can get complete information of a data product by one database call, which is actually what the frontend does - yes we do not always need the complete information of a data product, but to optimize this, we need to modify the frontend a lot, which could be a further step.
This PR shows an example of how I will replace graphQL with REST:

enrich api package with adding rest apis for data queries, which were implemented by graphql currently. When all the data queries are implemented in api package, we can remove graphql
use Querier interface directly in api package, without using database wrapper, so another goal is to remove database wrappers as well

The current architecture (data part) is something like:
graphql schema -> graphql resolvers -> database wrapper -> generated database queries
When the refactor is done, the system architecture will become as simple as
api -> generated database queries
Yes, we will lose some flexibility, but by carefully evaluating the pros and cons, I would say we gain way more than lose

According to the feedback from @Kyrremann @paulbes and @petteja , I will update the PR with optimizing the data transferred between the frontend and backend and reducing the complexity of the data product complete view

@petteja this is a good idea and will do it


Removing AzureWebJobsDashboard

Per issue #80

@pragnagopa and @asavaritayal as FYI - not critical but nice quality of life tweak


Add support for Teams chat and EduAssignments

I couldn't find them anywhere in the crate. Sorry if I'm just bad at looking.

Hey, no worries. Thats what feature requests are for.
Are you referring to education assignments such as this GET assignments:
GET /education/classes/{id}/assignments/{id}
If so, you right those are not in master or the latest crate version. The next release should be within a week at most and that is for #392 and that branch has the education assignments API included:
https://github.com/sreeise/graph-rs/blob/48754f644e2716bda58e606274fa894c234386f9/src/education/education_assignments/request.rs#L1-L176
There are a few breaking changes though so you would need to update your code. The changes are minimal though. Its mainly just using the async client as the default client so doing Graph::new is the async client. I am not planning on updating current master with any new APIs.

@HonbraDev I didnt see the Teams chat part. Which API are you referring to? /chats path or is there a specific chats for teams that I am missing?

Thanks for the quick response. Yes, I was referring to 1:1 chats under the /chats path and I can see everything I needed in the branch you sent.

No problem and glad to help.

I'd also like to ask why is graph-rs-types archived? I'm okay with defining my own structs, just curious.

There was a few reasons I stopped supporting that repo, but ill provide a short list.

It took a lot of time parsing those types because they are all in xml. Those types are written in OData Common Schema Definition Language. And
I also wrote the parser for that repo in Python and the codgen was in python as well so I was writing Rust code using Python. Its not unusual to do codegen using another language but in this case it was just a lot of extra work.
The parser in this repo and the codegen is in Rust and its parsing OpenAPI JSON which is much easier to do. But that JSON doesnt have types in them.
If those types get updated in the API and the code is not yet generated for those then the client breaks for any method that returns that type. And its happened to me a few times. There is no announcement or official release of the API getting updated. Well there might be but I don't have the time to pay attention to it enough to make sure those types are always right. 😆
The crate is much easier to maintain when each method doesnt require there to be a concrete type returned. It also just allows the user to get the body of the response in different formats such as bytes, streams, custom types, serde_json, etc.

Heres an example of the starting XML:
<?xml version="1.0" encoding="utf-8"?>
<edmx:Edmx Version="4.0" xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx">
  <edmx:DataServices>
    <Schema Namespace="microsoft.graph" Alias="graph" xmlns="http://docs.oasis-open.org/odata/ns/edm">
      <EnumType Name="appliedConditionalAccessPolicyResult">
        <Member Name="success" Value="0" />
        <Member Name="failure" Value="1" />
        <Member Name="notApplied" Value="2" />
        <Member Name="notEnabled" Value="3" />
        <Member Name="unknown" Value="4" />
        <Member Name="unknownFutureValue" Value="5" />
      </EnumType>
      <EnumType Name="conditionalAccessStatus">
        <Member Name="success" Value="0" />
        <Member Name="failure" Value="1" />
        <Member Name="notApplied" Value="2" />
        <Member Name="unknownFutureValue" Value="3" />
      </EnumType>
      <EnumType Name="groupType">
        <Member Name="unifiedGroups" Value="0" />
        <Member Name="azureAD" Value="1" />
        <Member Name="unknownFutureValue" Value="2" />
      </EnumType>

That metadata comes from the Graph API as well:
https://graph.microsoft.com/v1.0/$metadata and https://graph.microsoft.com/beta/$metadata. In other languages, like Microsoft's own C# they have extensive tools and libraries to generate code using that metadata but this is not true in Rust and it is a ton of work to do for someone doing this during their free time.
That was kind of a rant haha. Sorry about that.

Edit: Oh and I forgot to mention, I'm just goofing around with the API and you can't break code when there is none yet so I'm gonna switch branches and tell you if something breaks for some reason.

Sure that would be great. Im still finishing up some things on the branch so I apoligize if I accidently push code that doesnt compile 😄


Allow focus to be called if Node has not been added to the scene graph?

In the focus method I see this guard:
          if ( this._accessibleInstances.length > 0 ) {

Otherwise the function is a no-op. I feel ok about asserting this, because focus is a function, and not a setter that could be called from options. In my mind you should not be allowed to focus a node until it is in the scene graph.
@jessegreenberg does this seem reasonable to you?

I also see this in blur.
blur: function() {
          if ( this._accessibleInstances.length > 0 ) {
            assert && assert( this._accessibleInstances.length === 1, 'blur() unsupported for Nodes using DAG, accessible content is not unique' );
            var peer = this._accessibleInstances[ 0 ].peer;
            assert && assert( peer, 'must have a peer to blur' );
            peer.focus();
          }
          this.interruptAccessibleInput(); // interrupt any a11y listeners that attached to this Node
        },

Is there a reason that  accessibleInput is interrupted even if there isn't an accessibleInstance?

I think focus should be hidden behind a no-op because we want this function to still no-op when accessibility is not enabled. In that case the Node is in the scene graph but it has no AccessibleInstances, even when instrumented.
But I agree that interruptAccessibleInput should be inside the accessibleInstances check.

Sounds good. Implemented above.


How should multi-networks be handled?

Dis-allow multi-networks?

require a user to pass a single network from the multi-network

Create a separate plot for each network automatically?

Use html to create a window for embedding plots, with interaction to click to each network

(ranked by increasing difficult)
Any other ideas?

Use a slider to change a value that filters the data according to the multi-network id?
https://vega.github.io/vega-lite/docs/bind.html

Here is a vegalite code example of using a filter connected to a slider.  Can use this to filter the network id of a multinetwork
{
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "description": "Drag the sliders to highlight points.",
  "data": {"url": "data/cars.json"},
  "transform": [
      {"calculate": "year(datum.Year)", "as": "Year"},
      {"filter": {"param": "CylYr"}}
    ],
  "layer": [{
    "params": [{
      "name": "CylYr",
      "value": [{"Cylinders": 4, "Year": 1977}],
      "select": {"type": "point", "fields": ["Cylinders", "Year"]},
      "bind": {
        "Cylinders": {"input": "range", "min": 3, "max": 8, "step": 1},
        "Year": {"input": "range", "min": 1969, "max": 1981, "step": 1}
      }
    }],
    "mark": "circle",
    "encoding": {
      "x": {"field": "Horsepower", "type": "quantitative"},
      "y": {"field": "Miles_per_Gallon", "type": "quantitative"},
      "color": {
        "condition": {"param": "CylYr", "field": "Origin", "type": "nominal"},
        "value": "grey"
      }
    }
  }, {
    "transform": [{"filter": {"param": "CylYr"}}],
    "mark": "circle",
    "encoding": {
      "x": {"field": "Horsepower", "type": "quantitative"},
      "y": {"field": "Miles_per_Gallon", "type": "quantitative"},
      "color": {"field": "Origin", "type": "nominal"},
      "size": {"value": 100}
    }
  }]
}

closed by #86


[WIP] Folding in audioset

Will address #2.
paging @bmcfee for early feedback ... I've made a couple executive decisions that I'd be curious to get a 👍 / 👎 down on, specifically:

In getting rid of the librosa dependency, I naively copied out normalize and tiny from librosa.util without thinking too hard.
I've moved the audioset functionality into a submodule on openmic, e.g. openmic.audioset.vggish_input, etc. This feels like a deeper hierarchy than needed right now, but: calling the top-level package audioset doesn't seem right, and neither does unpacking the audioset submodules into openmic. Maybe this is a premature optimization, but it seems reasonable to expect that other helper tools will live alongside openmic.audioset. Alternatively, we could break things out into openmic.vggish.{input, slim, preprocess}, which feels a little nicer (this gets my vote).
I want to move the majority of featurefy functionality into openmic, but I've left it all in the script for now.
on util submodules. There's some stuff in openmic.audioset.util that isn't audioset specific, and might warrant a openmic.util, but not all of it (I think). Is having multiple util sub(sub) modules floating around a package bad practice?
I'm planning to chain this up to travis / coveralls as a separate issue after this is back to master, so that there's a meaningful initial state on code coverage. Agree / disagree?

Meanwhile, a couple todos for myself while I'm looking at this:

[x] get checksums for the vggish model and compare post-download. Those are hosted on a Google-controlled CDN and while they hopefully won't change ... there's nothing we can do about that.
[x] move featurefy.load_input to vggish_input.soundfile_to_examples
[x] update the download-deps script for the openmic/audioset package structure
[x] refactor featurefy.main to openmic.vggish.transform(), which opens TF contexts if none are provided.

alrighty, sorry this is kinda large, but it makes the VGGish API much simpler (see scripts/featurefy.py). I think it's review ready?

took care of things, so i'ma mail this through so i can move on to the travis stuff


Issue #68

Not sure I like this solution, as isn't all that clear or transparent - but it solves the problem that @tomgco  has with using Bosco for pure JS assets that are never served by a fragment via page composer.

@tomgco

I will close this in favour of the solution in #72.


Initialize context.state sooner

Fixes #1646
Description
Allow context creation an overridable Koa option.
Checklist

[x] I have ensured my pull request is not behind the main or master branch of the original repository.
[x] I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
[x] I have written a commit message that passes commitlint linting.
[x] I have ensured that my code changes pass linting tests.
[x] I have ensured that my code changes pass unit tests.
[x] I have described my pull request and the reasons for code changes along with context if necessary.

Change looks fine for what it does.
Consider asserting this in context state test.

Hi @antaranyan Sure, I have just modified the exisitng test for context > state.

what's the point of this? why not just make a middleware that does what you want?

@jonathanong https://github.com/koajs/koa/issues/1646

Pending outcome of discussion in #1646


Rc522 card reading UI has no pop-up window and scanning is abnormal.

The new window does not pop up in the development version rc522 card reading, and the scanning is abnormal.

Rc522 card reading does not play. Can this problem be solved?
@matjack1

I have fixed this in my local copy,had to set rfid state , I am sure i have mentioned it somewhere , I will find the link and post it

@windy54 can you please share the fix that you have found? Thanks!

in rfid.esp I edited mfrc522Read() to add the line rfidState=cardSwiped
`void mfrc522Read()
{
if (!mfrc522.PICC_IsNewCardPresent() || !mfrc522.PICC_ReadCardSerial())
{
return;
}
mfrc522.PICC_HaltA();
cooldown = millis() + COOLDOWN_MILIS;
for (int i = 0; i < mfrc522.uid.size; ++i)
{
uid += String(mfrc522.uid.uidByte[i], HEX);
}
MFRC522::PICC_Type piccType = mfrc522.PICC_GetType(mfrc522.uid.sak);
type = mfrc522.PICC_GetTypeName(piccType);
rfidState = cardSwiped;

}
`
Steve

Checked this change and it helps to restore the rc 522 reading, it is also possible that there are problems with at least one more rdm6300 reader, not yet checked

@vvvyky @windy54 @Aleks130699 this should have been fixed with this PR: https://github.com/esprfid/esp-rfid/pull/547
I'm going to close this for now, but if you still have problems please let me know! Thank you

Thank you Steve, this is very helpful. Let me try with 100+ users and I'll let you know! We'll keep the discussion in the other issue, that I think is more relevant: https://github.com/esprfid/esp-rfid/issues/557


Persistable Presenter

Hi,
Do you plan to add option to persist global presenters in Bundle  provided they are Serializable, for instance?

Hi, Alex. State persisting in our roadmap, but "how to do this properly" is  still open question


include.mk: update K nightly version

I'm updating this to get the latest changes from K.
Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock
[ ] Style conformance: stylish-haskell

Closing in favor of #780.


[groups] migrate remaining group & resource samples

https://github.com/Azure-Samples/resource-manager-go-resources-and-groups
https://github.com/Azure-Samples/resource-manager-go-template-deployment

This issue is a: (mark with an x)
- [ ] bug report (consider searching issues before submitting)
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

remaining work tracked in #108


Don't use MmMapIoSpaceEx or NdisWriteErrorLogEntry in RtGetResources

It should be WdfDeviceMapIoSpace.

WdfDeviceMapIoSpace is only available in user mode.

Additionally, we don't have a replacement for NdisWriteErrorLogEntry, though I don't know how valuable the log statements are.


Handle for duplicate term names in difft taxes

Ticket: #2362
Issue
When there are two identically named terms in two different taxonomies (which WordPress allows), attempting to fetch the newest one from a specific taxonomy will return false.
Solution
Modify the Term::get_tid method. When >1 term_id is discovered, test it against possible taxonomies in Term::get_term.
Impact
This will apply only to 1.x as 2.x handles this situation much more gracefully via Factories. The Term::get_tid method is protected, so modifying its return type is unlikely to cause issues. Theoretically, there could be an issue only if a user has extended the Term class specifically and is directly interacting with the method.
Usage Changes
None. Should now work as anticipated.
Considerations
This is a patch. The true "fix" is how 2.x handles this. I'd spend more time optimizing if this were going to be an enduring part of the code base. This definitely qualifies as a "bug" which is why I wanted to resolve for 1.x
Testing
New test written to uncover and solve the issue described in #2362

Cool! Just waiting to get Travis going again then I'll merge ...

Cool! Just waiting to get Travis going again then I'll merge ...


54 Proper shell script arguments, include current pane

Close #54.
Use proper arguments instead of relying on order.
Include current pane by default, add option -e to exclude it (used for Vim completion).
@blueyed: I restructured the script a bit again. Let me know what you think. I also removed the unset. Is there a particular reason why you added it?

:+1:
There's no need for the unset - I don't remember why I've added it.

Thanks!

Seems like this broke the unite source. :echo tmuxcomplete#list('words', 0) returns nothing. Same for "lines".
tmux 1.8

Thanks, will check!

@justinmk: Thanks for the ping, I can't believe I messed that up.
Should be fixed with #56.

@wellle Seems fine now, thanks!


Question about implementation

Hey I'm sorry to make an issue for this, but I have no idea how else to contact the developers.
So basically I'm making a text-based game, and I'd like to have sound effects and background music ready to go. The current way the library works is that you need a Source object in order to play and stop sound. However, the only way to create a Source is to use Sound.play().
So is the best way to have sound effects and bgm ready to go, to have a large sound initialization where I create a bunch of sources and stop them immediately to prevent them from hearing the sound? Then call Source.play() and Source.stop() when I need to? Or is there a better way to do this that I'm not seeing?
If there's no better way, then perhaps there can be a way to make Sources without calling Sound.play() first.
Alright thanks for listening. Again, sorry for using an Issue like this. I'm just not sure how else to ask.

proc loadSounds(list: seq[string]): seq[Sound] =
  for idx in 0..<list.len:
    result.add newSound(list[idx])

let mySounds = loadSounds(@[myPaths])

discard mySounds[0].play
discard mySounds[1].play


Change dependency release strategy

The current package.json for dependencies :
"dependencies": {
    "event-stream": "^3.1.4",
    "async": ">=0.7.0 <1.0.0",
    "dargs": ">=0.1.0 <4.0.0",
    "gulp-util": ">=2.2.14 <4.0.0",
    "protractor": "^2.0.0"
  }

You should change this to
"dependencies": {
    "event-stream": "~3.1.4",
    "async": ">=0.7.0 <1.0.0",
    "dargs": ">=0.1.0 <4.0.0",
    "gulp-util": ">=2.2.14 <4.0.0",
    "protractor": "~2.0.0"
  }

By using caret ( ^ ) you enable minor updates without any actions on your own package.
It means that gulp-protractor user can upgrade a major dependency like protractor without any notice.
Minor update add features to a package, theses features can introduce breaking changes.
Using tildes ( ~ ) is a lot more secure and safe, only patch updates are available.
I ran into this case with this protractor issue on windows.
My gulp-protractor was installed since 1 month (so protractor v2.1) then a bunch of new developpers joined the project they installed their dev tools (so gulp-protractor with protractor v2.3 without any changes in gulp-protractor version number) and their e2e tests failed. It takes me some hours to undestand the problem.

+1

+1

Also, this is using a version of Protractor that's currently breaking.
See:

https://github.com/angular/protractor/issues/1760
https://github.com/Dineshs91/devlog/commit/053c680ae7ca47b521daa24b3ddeaee52d9d59c3

Fixed with https://github.com/mllrsohn/gulp-protractor/commit/3aaa40ea1cfadac3fd74763fcf21732b5dc54a58
Thanks!


[VL] Add prefetch for velox splitter

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@jinchengchenghh

closing as this seems to be one outdate patch, feel free to re-open if it's still valid


Implement GUI Rotation

Rotate displayed image at will ?
=> What happens to min/max ? Out of screen ? Safe distance ? User zoom ?

Done.
Known problems:
Blur image for repeated rotate.
Out of screen issues.


Are there any documents about using flask deploy my pytorch model , thanks

You have to modify the code yourself. Simply replace the Keras inference part with PyTorch model.

You have to modify the code yourself. Simply replace the Keras inference part with PyTorch model.

Thank you! I will try it.


TST: Added a travis configuration file.

OK - it seems to install fine now, and tests pass on Python 3, but not on Python 2. There are also plenty of PEP8 violations that need to be fixed up.


hooo_dual_eq is too strong (c^(a == b) => ¬(c^a == c^b))

pub fn proof() -> False {
    hooo_dual_eq::<True, True, True>(tr())(eq::refl())
}

This also implies tauto_hooo_dual_eq is too strong, since tauto_hooo_dual_eq implies hooo_dual_eq.


NATS PubSub - add ability to send an ACK request prior to making a request

This PR builds on https://github.com/aporeto-inc/bahamut/pull/56 and adds the ability for clients to request an ACK response prior to making their request.
Scenario: I am making a request which I expect will take a long time. I don't want to wait until my preconfigured timeout is reached if the service handling the topic I am publishing to is not even up. In such cases, I should be able to send an ACK-Request and upon acknowledgement, I can then proceed to make my request.
        // notice how this timeout is SMALL
        ackCtx, _ := context.WithTimeout(context.Background(), 1*time.Second)
        // notice how this timeout is BIG
        reqCtx, _ := context.WithTimeout(context.Background(), 10*time.Second)

	p.pubsub.Publish(pub,
		bahamut.NATSOptPublishRequireAck(ackCtx),
		bahamut.NATSOptRespondToChannel(reqCtx, responseCh)
	)

Related to: https://github.com/aporeto-inc/aporeto/issues/1274
TODO:

[ ] Get feedback from @primalmotion & @t00f
[ ] Unit test coverage for when ACK request fails
[ ] Unit test coverage for when ACK requests succeeds, but the response is invalid

@primalmotion: this model doesn't make sense to me. Sending a ACK and getting a response then sending your publication doesn't guarantee that someone will handle it

Sending an ACK request (notice the message being used for the ACK) implies that you are expecting to get back one response, which must be an ACK.
This is not about guarantees, it's about knowing whether someone is there handling the NATS subject you are about to Publish to and it's completely optional.
What this implies now is that the implementation of Subscribe will now be changed to handle these ACK requests by responding to them transparently. Client code will not be aware of this happening.

@primalmotion: this model doesn't make sense to me. Sending a ACK and getting a response then sending your publication doesn't guarantee that someone will handle it

Sending an ACK request (notice the message being used for the ACK) implies that you are expecting to get back one response, which must be an ACK.
This is not about guarantees, it's about knowing whether someone is there handling the NATS subject you are about to Publish to and it's completely optional.
What this implies now is that the implementation of Subscribe will now be changed to handle these ACK requests by responding to them transparently. Client code will not be aware of this happening.

Summary of a few things discussed offline:

The current probe implementation proposed here is not really valuable. Let's scrap that and instead add a new field to our Publication model to indicate that a Publication requires an ACK. This implies that on receipt of a Publication, the subscriber will check for this field to determine whether or not to send back an ACK.

NATSOptPublishRequireAck option

When configured, it will populate a “requireAck” boolean attribute in the Publication that is to be published. The client will block until an ACK is received or the supplied context deadline is reached. As a result of this option our implementation of Subscribe will now need to look for this new “requireAck” attribute when consuming messages to determine whether it needs to respond back with an ACK. This option CANNOT be set if NATSOptRespondToChannel has been provided - will panic 💥.

NATSOptRespondToChannel option

When configured, the publication will be sent and the client will block until a publication response is returned or the provided context deadline is reached. As a result of this option our implementation of Subscribe will now need to look for the new “requireAck” attribute and check to see if its value is set to false as this would imply that a response should be delivered AFTER processing has been completed. This option CANNOT be set if NATSOptPublishRequireAck has been provided - will panic 💥.

Closing in favour of https://github.com/aporeto-inc/bahamut/pull/59
Keeping this for historical context 📖


How to get the content of iframe?

I want to acquire comment data from a music website, but all comments content are loaded in the iframe and no way I could find to access these data, so what am I missing?

I haven't had direct experience with iframes, but I would imagine that you can setup a collector to look for the iframe tag, then take the src attribute and call collector.Visit() on the source URL.  From there you would need another callback to collect the information you are looking for.
Let me know if that works!

@killernova I'm going to close this issue for now.  Feel free to reopen it if you feel it is not resolved.

This doesn't work if the iframe uses srcdoc where the HTML is inline. There's no exposed method in Colly to feed this through as a synthetic request so the regular set of scrapers one might have configured can run.

@wrouesnel could you provide an example HTML code?

@asciimoo Sure - so something like this - is what you end up with. It's just a single element with a srcdoc element containing full HTML. When scraping, you'd like to be able to register srcdoc as being a full HTML document so it can be parsed. My workaround is to construct this manually, which leads to a lot of code duplication.
<iframe x-ref="iframe" class="w-full" srcdoc="<!doctype html><meta charset="utf-8"><meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"><link rel="stylesheet" href="https://rsms.me/inter/inter.css"><link rel="stylesheet" href="/css/iframe.css?id=a05cfc4bbf6c64e1422e">

The goal when I'm scraping is to pick up those script and hrefs inside the iframe, since they're all static content necessary to display the site (and with a workaround, work perfectly).

Thanks! This raises a lot of questions. E.g. what if the original html and the content of the srcdoc contains an element with the same id attribute? I'm not sure if this feature should be supported by colly. Perhaps we should add a new function instead which creates HTMLElement from strings to avoid code duplication in these cases.
What do you think?


docs: update content on top level

@dericksozo can you please see the PR comments I left above and address them, so we can merge what you've done so far?


Upgrade http crate to 1.0.0

The http crate has finally received its 1.0.0 release, but this does require some effort to propagate through the crates.  As is the case here with the examples using reqwest which is still on http 0.2.

Thanks for opening this! I've seen that reqwest is working on upgrading as well: https://github.com/seanmonstar/reqwest/pull/2059
I think it could be worth waiting on that, if it doesn't take too long. Then we can update the example as well. I think a big portion of users of this lib is using it in combination with reqwest

Yes, I'm subscribed to those issues and awaiting them to be upgraded. Same for the oauth2 crate :+1:

This was fixed by @Jake-Shadle in https://github.com/EmbarkStudios/tame-oauth/pull/72


sentence is incomplete or missing:  "Only the failover to a target device in the same domain."

On the Prerequisites for device failover, one of the sentences is incomplete or missing an important complement:
"Only the failover to a target device in the same domain."

Can we have that filled!? Was the intention to document that "Only the failover to a target device in the same domain IS SUPPORTED"!?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47ad2950-3098-4aca-d37d-e24af9af0941
Version Independent ID: 3efb735b-c28a-4e68-1599-f7bdbf3b9bfb
Content: StorSimple Virtual Array disaster recovery and device failover
Content Source: articles/storsimple/storsimple-virtual-array-failover-dr.md
Service: storsimple
GitHub Login: @alkohli
Microsoft Alias: alkohli

@diegoalb Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@Adam-Smith-MSFT The changes were merged. I am going to go ahead and close this issue. Thanks!
#please-close


[BEAM-10759] Uses reader Avro schema to deserialize in KafkaIO

The existing ConfluentSchemaRegistryDeserializerProvider uses the writer schema to deserialize Avro records from Kafka, but passes a fixed schema to the AvroCoder. If the Kafka topic contains evolved schema, the AvroCoder will fail to encode the records.
This commit uses the deserialize(bytes, readerSchema) method from KafkaAvroDeserializer, in order to deserialize Kafak Avro records with a schema consistent with AvroCoder.
The change causes ConfluentSchemaRegistryDeserializerProviderTest to fail, due to an existing error. mockRegistryClient.register returns the schema id but not the schema version. With the changes in this commit, the mockRegistryClient will be called one more time, which in turns call mockRegistryClient.register(). This causes schema id and schema version to deviate. Therefore, the unit test is modified to correctly acquire the schema version.
I have ran local test on the java sdk, and spotless test. The modified logic has been tested on an actual pipeline with Dataflow Runner, which successfully read from a topic with evolved schema.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @lukecwik

@iemejia I have pushed a new commit implementing your suggestions.
For the specific test, I edited the mock consumer in KafkaIOTest to generate records with a different schema.
I have verified the new deserializer provider by running the modified test on the original one
  @Override
  public Deserializer<T> getDeserializer(Map<String, ?> configs, boolean isKey) {
    ImmutableMap<String, Object> csrConfig =
        ImmutableMap.<String, Object>builder()
            .putAll(configs)
            .put(AbstractKafkaAvroSerDeConfig.SCHEMA_REGISTRY_URL_CONFIG, schemaRegistryUrl)
            .build();
    Deserializer<T> deserializer =
        (Deserializer<T>) new KafkaAvroDeserializer(getSchemaRegistryClient());
//            new ConfluentSchemaRegistryDeserializer(getSchemaRegistryClient(), getAvroSchema());
    deserializer.configure(csrConfig, isKey);
    return deserializer;
  }

As expected, this will cause the test to fail

@iemejia do you have time to review the updates?

Merged manually to squash the commits.


parallel support?

when to support parallel container?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

selector also unsupport

@gocpplua
"Priority node" maybe it's just another name for the selector?

@gocpplua
"Priority node" maybe it's just another name for the selector?


FAQs (One to Many & Many to Many)

Hello everyone,
My name is ArsalImam. Right now I'm working on one of my client's project. I completely installed the EasyRTC framework on my server and also check the examples (which are wrote excellently).
I have few queries regarding EasyRTC and also required suggestions and answers from which methods I can use to overcome on these queries/issues. Following are my queries regarding EasyRTC:

How EasyRTC works in case of One to Many communications (such as webinars etc)? I mean, is EasyRTC configured to use media server, in a way that Peer -> Media Server -> Other Peers.
Can I configured EasyRTC to share any specific window or tab? Like, lets suppose, I only wants to allow MS-Paint window to be shared with other peers
Is there any time limit on recording a conference call?
How much peers it can support during a video session?
Can I allow approx 700 connections (in One to Many communication)?
What recommended physical assets(bandwidth, RAM etc) are required to support 700 connections in One to Many communication?
Can I configured EasyRTC to use one server for live streaming & a different server for media storage?

May be this can be answered in faq if not already:

https://github.com/priologic/easyrtc/blob/master/docs/easyrtc_faq.md


Add some info about inverse kinematics

We got some info from "an anonymous source" regarding IK in Titanfall2. Might be useful. Not sure where to put it so I'm just gonna paste the text here and let someone else figure it out :P
# Inverse kinematics

Based on information we collected, inverse kinematics is only enabled for Titan legs to plant their feet on the ground and sometimes for Pilot arms so that they hold guns properly.

Inverse kinematics is (de)activated based on `(Frame, IK value)` pairs. This is done to blend the skeleton between keyframe animation and in-game/realtime inverse kinematics.

## Keyframe / inverse kinematics interpolation

There's a float value that controls the interpolation between keyframe animation and inverse kinematics.
- `0` -> IK disabled, keyframe animation only
- `1` -> keyframe animation disabled, IK only
- values in-between blend IK and keyframe animation

## Attachments

Attachments are predefined points that IK enabled arms/legs try to reach

## Titan legs

If enabled there's a trace/cast going from presumably the ankle joints/attachments to the ground. This is primarily used to properly plant the foot on the ground and to ensure foot rotation also matches the ground angle.

## Pilot arms holding guns

Each weapon has attachment points that contain information about location and rotation that the Pilot's hands and wrist joints then try to join up.

don't sentry turrets use IK as well? their legs always adapt to the environment properly


libva: 2.15.0 -> 2.16.0

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This broke build of intel-media-driver: https://hydra.nixos.org/build/198821403
Updating to the next release would conflict with the Debian's patch that we apply.
/cc also the other maintainer: @jfrankenau.
(Note that when this got merged, no breaking changes were allowed in staging for a few days already.)

#202115


Problem with replacements of push

the Regex rules replace every push string or subtring with .add.
For example:
String s = "pushing var to top of stack"; => String s = .adding var to top of stack";
please rectify this.

Thanks for your report!
I fixed the issue in the pub global version of Röckdöt Converter, which is the only version I maintain.
This reminds me that I should have updated this project's readme a long time ago :-)


Add tilde info for push to troubleshooting

Signed-off-by: TomSweeneyRedHat<EMAIL_ADDRESS>Add info on tilde expansion to the Troubleshooting guide.  Addresses #777

Much better.
LGTM
@pixdrift @ipbabble @umohnani8 PTAL

LGTM

@rh-atomic-bot r+


Clarify env vars in YAML pipelines

This PR replaces #1013
The env key in the returned body does show env vars if you supply them in the YAML. I've added an example there, and removed the env parameter that doesn't work in the request. The env paramter does still work if you're creating a visual pipeline.
Let me know if if anything is still unclear @unrealcloud

That makes sense yeah, thanks for looking into it @plaindocs, appreciate it!


Negations Handled Incorrectly in Creation of Temporary Tables

Describe the bug
Due to the way sqlglot parses negations (and more generally, all unary operators), expressions using NOT dropped their negation when creating a temporary table.
To Reproduce
Adapted from  https://github.com/parkervg/blendsql/issues/31#issuecomment-2401144389:
# Prepare our local database
db = Pandas(
    {
        "frpm": pd.DataFrame(
        [[194.0, 244.0, 'ARISE High'], [354.0, 433.0, 'ASCEND'], [318.0, 373.0, 'A. L. Conner Elementary'], [698.0, 1014.0, 'Abraham Lincoln Middle'], [93.0, 254.0, 'Academies of the Antelope Valley'], [400.0, 463.0, 'Academia Moderna'], [82.0, 723.0, 'Acacia Elementary'], [208.0, 370.0, 'A. J. Cook Elementary'], [64.0, 618.0, 'Abraham Lincoln Elementary'], [518.0, 631.0, 'Abraham Lincoln Elementary'], [155.0, 215.0, 'ASA Charter'], [26.0, 94.0, 'Abraxas Continuation High'], [65.0, 74.0, 'Acacia Middle Charter'], [216.0, 264.0, 'Acacia Elementary Charter'], [275.0, 802.0, 'Abbott Middle'], [346.0, 404.0, 'ACE Empower Academy'], [63.0, 71.0, 'ACE Alum Rock'], [211.0, 219.0, 'ACE Charter High'], [134.0, 149.0, 'ACE Franklin McKinley'], [47.0, 57.0, 'Academic/Vocational Charter Institute']],
        columns=['Free Meal Count (Ages 5-17)', 'Enrollment (Ages 5-17)', 'School Name']
    )
    }
)

blendsql = """
SELECT * FROM frpm
WHERE `Free Meal Count (Ages 5-17)` / `Enrollment (Ages 5-17)` IS NOT NULL
AND {{
 LLMMap(
      'Is the educational option type of the following school Traditional?',
     'frpm::School Name'
 )
}} = TRUE
ORDER BY `Free Meal Count (Ages 5-17)` / `Enrollment (Ages 5-17)` ASC
LIMIT 10
"""

The above query yields an empty dataframe, and no values are passed to the LLMMap ingredient.
Expected behavior
While we are unsure of what the output of LLMMap will be, we expect some values to be passed and populated in the smoothie.meta.prompts attribute, since we can clearly see the table contains rows with no NULL values.

@ZhaoFuheng addressed your NULL bug here! Turned out it was an AST-related issue for all predicates containing negations, not just NULL statements. Thanks for catching it!


refactor(app): remove splash screen

Overview
remove splash screen since we don't need this any more.

Test Plan
none

Changelog

remove the related components

Review requests

Risk assessment
low

with the initial splash removed, we need either a route or a redirect to match /. like in the desktop app, we could add a Redirect from / to whatever page we want to show on load (/dashboard? /get-started?). another option would be to change one of those routes to /.

I guess /dashboard would be reasonable since it has links to protocols, instruments and robot settings.
@shlokamin 👆
What do you think?

[ ] update the redirect path


TSW-66322 – added more informative error messages

TSW-66322 – added more informative error messages
TSW-66317 – fix test-script issues around finding files and folders
After we merge all of these I guess for now only Frank can create the .ps1.zip files?

Good that should help between all the changes. Now what are we going to use for a binaries staging environment for smoke testing these?


This repo is outdated and abandoned

Current version of ActiveCampaign API is NOT supported by this package and there is no info about this in docs. Do not use it in your project!

Thanks for the heads up. We were about to start integrating Active Campaign in our project and were wondering if we can use this vs their REST API directly.

Is there any good alternative? It seems all the AC API packages on npmjs are old.

@theDanielJLewis nope. We managed to write our own tiny client with a subset of the endpoints we really wanted to support.


Add Swets

Added Blue Swets and Yellow Swets.
They do everything that they did in the original aether legacy. This implementation allows for more swet variants in the future if that is ever wanted.
Right now they use the slime models and textures as placeholders until custom models and textures are created.
The swet loot tables don't always work, and will likely need to be changed.

This pull request also fixes a typo. In aether_highlands.json, "endermen" is written instead of "enderman".


feat: Add library auto release workflows and code checks

Description
This PR adds library auto release workflows. It also adds code quality checks to this repo in order to ensure that the code inside the template directory (with the library template) has no issues.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update kepler config when estimator is enabled

What happened?
The current config is using the v0.6 models and causes incompatibility on metrics.
What did you expect to happen?
Use metric built by v0.7
How can we reproduce it (as minimally and precisely as possible)?
run make deploy
Anything else we need to know?
TODO

[ ] merge power models https://github.com/sustainable-computing-io/kepler-model-db/pull/22
[ ] update init model url in loader.py to use the v0.7 pipeline and initial models

Kepler image tag

v0.7.7

Deployment

[x] Model server
[x] Estimator
[ ] Online trainer
[ ] Offline trainer
[ ] Profiler

Kepler model server image tag if deployed

v0.7

Kepler estimator image tag if deployed

Kepler online trainer image tag if deployed

Kepler offline trainer image tag if deployed

Kepler profiler image tag if deployed

Kubernetes version

$ kubectl version
# paste output here

Install tools

Kepler deployment config

For on kubernetes:
$ KEPLER_NAMESPACE=kepler

# provide kepler configmap
$ kubectl get configmap kepler-cfm -n ${KEPLER_NAMESPACE}
# paste output here

# provide kepler model server configmap if Kepler Model Server is deployed
$ kubectl get configmap kepler-model-server-cfm -n ${KEPLER_NAMESPACE}
# paste output here

# provide kepler deployment description
$ kubectl describe deployment kepler-exporter -n ${KEPLER_NAMESPACE}

For standalone:
put your Kepler command argument here

Done by #244 and https://github.com/sustainable-computing-io/kepler/pull/1324


Feature/dev scholar

add query for withRouter params and add some tests

Codecov Report

Merging #47 (4c64415) into master (aebf6a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   98.69%   98.70%
=======================================
  Files          15       15
  Lines         230      231    +1
  Branches       35       35
=======================================
+ Hits          227      228    +1
  Misses          2        2
  Partials        1        1

Impacted Files
Coverage Δ

packages/launcher/src/module/withRouter.tsx
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebf6a6...4c64415. Read the comment docs.

here, I set 2 for this rule.


Add type field to ResourceGenerator, remove code duplication

Make type field to ResourceGenerator working, used to set Secret type
Removed code duplication
Autoformat after Go code generation

@alessiodionisi do you know why the e2e on the schemas is failing? Maybe the change of the included schema for the plugins?

I've disabled 009 - no test by commenting it, we need to re-enable it when the JSON schema library supports unevaluatedProperties.


Boot2docker doesn't respond sometimes

I have about 20 people in my office running Docker via Boot2Docker and I'm seeing lots of reports of boot2docker being unresponsive. As in the Docker and Docker Compose CLI clients not connecting or boot2docker not being able to shut down. The only way we're able to get around this is by opening up Virtualbox and manually powering off the VM.
This is using:
Boot2Docker-cli version: v1.6.2
Git commit: cb2c3bc

Up, have same issue, from time to time I get Couldn't connect to Docker daemon at https://<IP_ADDRESS>:2376 - is it running? then I have to re-run command few times.
Boot2Docker-cli version: v1.7.1
Git commit: 8fdc6f5

System: Yosemite 10.10.4
I mostly happens inside a docker container (we're using docker development container aka docker inception)


Display dates instead of week numbers

When one selects the Weeks tab, a weekly breakdown of the stats is displayed.

It would probably be more useful if instead of week 3 it said 2022-01-18 for example, eg. provide dates as the horizontal axis unit instead of week number.

Hello,
thank you for the suggestion.
Displaying the week number instead of the date of the first day of the week is not the ideal solution. Nevertheless, it is more readable.
I'll try various format to display the date instead and see how it fits

Perhaps you could write the labels rotated by 90' ?

Hello @abailly ,
sorry for the delay.
The date format has been fixed on this commit b9784227c066e64840ce68f06323acd5b150458e.
Release 0.3.1 has been pushed on npm.
Here is a screenshot of the result:

Hello @abailly ,
sorry for the delay.
The date format has been fixed on this commit b9784227c066e64840ce68f06323acd5b150458e.
Release 0.3.1 has been pushed on npm.
Here is a screenshot of the result:


Can't switch to a new profile

Type: Bug
I started to work on some code and wanted to create a new profile.  I noticed that the menu had changed in this version of vscode and brought up a Profile view where I created the profile and I selected the profile (it looked like it was selected (it had a checkmark), but the little profile text on the CogWheel never changed. It remained on the old profile.
I've exited and restarted and I have not been able to change to the new profile (which does exist).
It seems like there isn't a way (like there was before) to select the profile to use that will actually change to the profile selected.  Seems like a bug (but if there's some button or something that I'm missing, could be user error), but it's not clear to me.
Just a FYI
VS Code version: Code 1.93.1 (38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40, 2024-09-11T17:20:05.685Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz (16 x 2304)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
63.20GB (30.54GB free)

Process Argv
--crash-reporter-id c6576603-b60e-4776-b8b0-7344f1723162

Screen Reader
no

VM
0%

Extensions (64)

Extension
Author (truncated)
Version

copy-relative-path
ale
0.0.2

npm-intellisense
chr
1.4.5

vue-peek
dar
1.0.2

vscode-markdownlint
Dav
0.56.0

vscode-eslint
dba
3.0.10

githistory
don
0.6.20

vscode-html-css
ecm
2.0.10

EditorConfig
Edi
0.16.4

prettier-vscode
esb
11.0.0

vscode-firefox-debug
fir
2.9.10

auto-close-tag
for
0.5.15

dotnet-test-explorer
for
0.7.8

copilot
Git
1.229.0

copilot-chat
Git
0.20.1

remotehub
Git
0.64.0

vscode-github-actions
git
0.26.5

vscode-pull-request-github
Git
0.96.0

rest-client
hum
0.25.1

vscode-gutter-preview
kis
0.31.2

Kotlin
mat
1.7.1

rainbow-csv
mec
3.12.0

vscode-docker
ms-
1.29.2

csdevkit
ms-
1.10.18

csharp
ms-
2.45.25

vscode-dotnet-runtime
ms-
2.1.5

vscode-edge-devtools
ms-
2.1.5

vscode-kubernetes-tools
ms-
1.3.16

data-workspace-vscode
ms-
0.5.0

mssql
ms-
1.24.0

sql-bindings-vscode
ms-
0.4.0

sql-database-projects-vscode
ms-
1.4.3

playwright
ms-
1.1.7

remote-containers
ms-
0.384.0

remote-ssh
ms-
0.114.3

remote-ssh-edit
ms-
0.86.0

remote-wsl
ms-
0.88.3

vscode-remote-extensionpack
ms-
0.25.0

azure-repos
ms-
0.40.0

hexeditor
ms-
1.10.0

live-server
ms-
0.4.15

powershell
ms-
2024.2.2

remote-explorer
ms-
0.4.3

remote-repositories
ms-
0.42.0

remote-server
ms-
1.5.2

vscode-github-issue-notebooks
ms-
0.0.130

oracledevtools
Ora
23.4.1

material-icon-theme
PKi
5.10.0

quicktype
qui
23.0.170

vscode-commons
red
0.0.6

vscode-yaml
red
1.15.0

vue-vscode-snippets
sdr
3.1.1

autoimport
ste
1.5.4

code-spell-checker
str
3.0.1

vscode-mdx
uni
1.8.10

veracode-vscode-plugin
Ver
1.11.3

intellicode-api-usage-examples
Vis
0.2.8

vscodeintellicode
Vis
1.3.1

volar
Vue
2.1.6

console-ninja
Wal
1.0.359

quokka-vscode
Wal
1.0.652

wallaby-extension-pack
Wal
1.0.1

wallaby-vscode
Wal
1.0.381

vscode-todo-highlight
way
1.0.5

vscode-mdx-preview
xyc
0.3.3

(2 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialogc:30910334
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
f3je6385:31013174
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
impr_priority:31102340
nativerepl1:31139838
refactort:31108082
pythonrstrctxt:31112756
flightc:31134773
wkspc-onlycs-t:31132770
wkspc-ranged-c:31125598
cf971741:31134768
ei213698:31121563
iacca1:31138162

Doesn't seem to be a way to change the profile in the current window/file or change the default profile used for the opened folder from the user interface (unless there's a setting for that, other than the default profile, which I didn't really want to change.)

This?

@GongT Thank you!  That is the one.
I was clicking on the line, not on the checkmark. Clicking on the line makes the checkmark appear selected. Thank you!

/duplicate
https://github.com/microsoft/vscode/issues/227872


"gray out" a completed task

Currently, when the user marks a task as "complete", the only changes on the UI is that the content text of the task gets a line through. A more impactful change needs to be done, changing the color of the panel to a more darker one seems appropiate.

Hey @DevTony101 I can help you with this one!

A PR is now opened. Let me know if I must make any changes or any improvements


Autoortho lowers airport lights brightness

Im noticing a significant decrease in airport flood lights brightness when autoortho is running. When autoortho is off, the lights are normal and much brighter.
Steps to reproduce the behavior:

Run autoortho and open the sim
Set the time to dusk/night and spawn at any airport (preferably regional or international that has gates and floodlights)
Notice the brightness of the floodlights. Optionally take a screenshot for reference when comparing
Repeat the steps but without autoortho running (off)

Autoortho should not interfere with lights, and it makes it harder to see at the airport. A minor bug but very weird.

OS: Windows 12
XPlane Version: Latest version XP 12.0.9
AutoOrtho Version 0.7.2

Is there any explanation for why this is happening?

Posted in discussions instead


Use out-of-the-box netty codecs to fix TLS P2P failing to process messages over a certain size (> TLS record limit of 16 KB)

Based on https://github.com/perusworld/besu/commit/06f94311d8196a35759ae5e647c282a2204e9dd9 but removed Protobufs
This will fix https://github.com/hyperledger/besu/issues/3254
Note, this supersedes https://github.com/hyperledger/besu/pull/3242

Upgraded to full PR to prepare for merging into main. This only affects an early access feature (behind a flag) and merging will help validate the approach in advance of automated testing.


How to show the Modal's blur view above navigation bar?

Hi , I was trying to show the Modal's blur view  above the navigation bar I have, but it doesn't work with a navigation bar appearing. How to achieve this?
Can you please help.
Thanks.

what kind of navigation bar are you using? currently you need to put the <Modal /> after all your other elements for it to appear over them, since RN doesn't support z-indexing (yet)

closing due to inactivity


Remove Rails authenticity_token from SAML forms

SAML forms generally only include SAMLRequest and RelayState, with the
exception of our extensions (registration, hints) we shouldn't go beyond
these standard form parameters.
Rails includes an authenticity_token to prevent cross-site request
forgery however in this case the form 'action' is a separate domain
beyond our control so csrf tokens like this are not useful.
Rails docs say the utf8 ✓

enforces browsers to properly respect your form's character encoding

Given the content of these forms is generated and not user submitted we
can be confident that we don't place any unicode characters in there.
Generally the bodies of these forms are base64 encoded XML so there is
very little room for unicode characters in any case.

Had some trouble with selenium locally so please wait for the travis build before merging..


Consistent use of semicolon in sql-docs

This page shows semicolon use as a statement end indicator in the syntax block at the head, but then the examples below are inconsistent with the syntax block. This is confusing. And there is no mention of any requirement for explicit statement end indicator (;) use anywhere in the text.
Which is it — required for IF ELSE statements, or not? Or only required in certain statement configuration contexts? That are also not documented here?
If implicit statement end determination from context is truly deprecated in T-SQL, why not conform the examples to reflect that reality? And make it clear in the text. I know it's a pain to edit this stuff, but that pain is only multiplied by every reader like me who scratches his head and thinks, "is this why my code is not working?"
Let's clear up this confusion.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5c4b818-4333-c6f1-3a13-bdcd32afccbb
Version Independent ID: eb3f02b0-214d-eff7-cc6e-f2bee0607ae5
Content: IF...ELSE (Transact-SQL) - SQL Server
Content Source: docs/t-sql/language-elements/if-else-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @rothja
Microsoft Alias: jroth

@rcaldwell-hiusa -- thank you for your feedback.
@rothja -- please look into this issue.

@rcaldwell-hiusa Thank you for the feedback, and apologies for the confusion on the use of the semi-colon. You're right that we should be more clear. In our Transact-SQL syntax conventions we say the following:
Transact-SQL statement terminator. Although the semicolon isn't required for most statements in this version of SQL Server, it will be required in a future version.

But I believe that has been in the documentation for some time and the semicolon still is not required in all contexts. So I think what has happened is that some examples and syntax blocks have started using the semicolon based on this information, but it hasn't been consistent because most statements still work without a semicolon. Obviously, as a reader, this is confusing, and I apologize for the inconsistency.
For a community discussion of the exact confusion you describe, see the Stack Overflow post here: https://stackoverflow.com/questions/8004322/when-should-i-not-use-a-semicolon. Note from that thread in the comments that there are some cases where T-SQL requires semicolons, but those cases are usually clearly called out in the docs. I think the assumption is that if the semicolon is important, the article should talk about it. If it does not, then you can use or not use it for statement termination.
Let me consult with others internally and see if there is a best-practice we should be aligning to. My guess is that although this was intended to be enforced, it never was due to the massive amount of T-SQL that does not use semicolons. And anything that is not enforced becomes very hard to consistently apply or recommend.

Jason –
I appreciate your timely response to my comment, and the information you provided.
I’d like to give you a bit more information in response to one point you made:  “there are some cases where T-SQL requires semicolons, but those cases are usually clearly called out in the docs”.
This is actually what prompted me to give feedback. I found in testing that the attached T-SQL query would enter an infinite loop at line 384 when there was no semicolon present after END. Curious, I consulted the documentation page we’re discussing. I did not find any reference(s) to circumstances where a BEGIN-END statement block contained within an IF-ELSE needed a terminating semi-colon, so I thought that my code was correct. The docs only say “To define a statement block, use the control-of-flow keywords BEGIN and END.” and none of the examples cover the use of a statement block or use terminating semicolons. So I was puzzled.
Given that the code (starting at line 384) was acting as if it was caught in the looping WHILE block beginning at line 313 when the line 317 IF Boolean expression evaluated to FALSE, instead of acting as if it was the END statement that was intended as the terminus of the BEGIN statement at line 318, my instinct was to add semicolons to all of my END statements. It looked to me like the logic designed to infer statement end points from code context was misinterpreting the intent of my code.
That fixed my problem. It wasn’t clearly called out in the docs. And that prompted my feedback.
My meta-comment to all this is, leaving something in place that “kinda works most of the time” creates a trap for people who then depend on that crutch. While I was pulling my hair out debugging, the last thing I thought of was the missing semicolon.
From now on, I’ll be placing semicolons at the ends of all my statements. Thanks again for your time spent on my behalf.
All the best - Rich
Rich Caldwell
Business Intelligence Developer
Digital Technology Team
Hostelling International USA
8401 Colesville Road | Suite 600
Silver Spring, MD  20910
TEL: +1.240.650.2119
<EMAIL_ADDRESS>From: Jason Roth<EMAIL_ADDRESS>Sent: Wednesday, July 1, 2020 07:25
To: MicrosoftDocs/sql-docs<EMAIL_ADDRESS>Cc: Rich Caldwell<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/sql-docs] Consistent use of semicolon in sql-docs (#5065)
@rcaldwell-hiusahttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frcaldwell-hiusa&data=02|01|richard.caldwell%40hiusa.org|e8aa07a850294314b40908d81db165a2|27a7b3e482244dcc8fc68ead8aaa67f2|1|0|637291995041546642&sdata=Oz58wCff%2B1mWw9Pl5yVvZ5GVaulgoFXZC87pbtM3mtQ%3D&reserved=0 Thank you for the feedback, and apologies for the confusion on the use of the semi-colon. You're right that we should be more clear. In our Transact-SQL syntax conventionshttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fsql%2Ft-sql%2Flanguage-elements%2Ftransact-sql-syntax-conventions-transact-sql%3Fview%3Dsql-server-ver15&data=02|01|richard.caldwell%40hiusa.org|e8aa07a850294314b40908d81db165a2|27a7b3e482244dcc8fc68ead8aaa67f2|1|0|637291995041556592&sdata=Gx5LOS%2BYhUzCBtEYtCJIrBlbVV98ge7cogvZxsD8XLU%3D&reserved=0 we say the following:
Transact-SQL statement terminator. Although the semicolon isn't required for most statements in this version of SQL Server, it will be required in a future version.
But I believe that has been in the documentation for some time and the semicolon still is not required in all contexts. So I think what has happened is that some examples and syntax blocks have started using the semicolon based on this information, but it hasn't been consistent because most statements still work without a semicolon. Obviously, as a reader, this is confusing, and I apologize for the inconsistency.
For a community discussion of the exact confusion you describe, see the Stack Overflow post here: https://stackoverflow.com/questions/8004322/when-should-i-not-use-a-semicolonhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstackoverflow.com%2Fquestions%2F8004322%2Fwhen-should-i-not-use-a-semicolon&data=02|01|richard.caldwell%40hiusa.org|e8aa07a850294314b40908d81db165a2|27a7b3e482244dcc8fc68ead8aaa67f2|1|0|637291995041556592&sdata=O2GcyQSMCGHvmkiL8eljsD0G4dhYZaki%2Fhx67RO%2FY3s%3D&reserved=0. Note from that thread in the comments that there are some cases where T-SQL requires semicolons, but those cases are usually clearly called out in the docs. I think the assumption is that if the semicolon is important, the article should talk about it. If it does not, then you can use or not use it for statement termination.
Let me consult with others internally and see if there is a best-practice we should be aligning to. My guess is that although this was intended to be enforced, it never was due to the massive amount of T-SQL that does not use semicolons. And anything that is not enforced becomes very hard to consistently apply or recommend.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fsql-docs%2Fissues%2F5065%23issuecomment-652361463&data=02|01|richard.caldwell%40hiusa.org|e8aa07a850294314b40908d81db165a2|27a7b3e482244dcc8fc68ead8aaa67f2|1|0|637291995041556592&sdata=gekAdC3thcnT8JL39mR61vmhBq7%2Fgyr1V2CAZWGxGIg%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAOBDOCBYMJV23X3EJHW6GKDRZMMI5ANCNFSM4OMFV7ZA&data=02|01|richard.caldwell%40hiusa.org|e8aa07a850294314b40908d81db165a2|27a7b3e482244dcc8fc68ead8aaa67f2|1|0|637291995041566554&sdata=QIfmwoxxzx4%2BSwqtba%2F3bBs677WXjA%2B%2FfBvUdHi2rMM%3D&reserved=0.

@rcaldwell-hiusa Thanks for the additional context, and you're right that this not being explained in the docs is clearly a problem. I'm going to look to update this one example. As for the overall solution or best practice in our docs on this, I'm consulting with others internally to see what can/should be done. I'm sorry for your frustration and lost time!
BTW, when you reply to a git issue email, it adds the entire email to the issue on GitHub. This included your contact information. I'm going to edit your comment to remove that with the assumption that you don't want this picked up randomly by anyone on the internet. Thanks.

@rcaldwell-hiusa After consulting internally, we are all agreed that it is a best practice to use semicolons as a delimiter (and newer functionality does use that) but there are no immediate plans to enforce it. With that said, we should fix T-SQL examples to use the semicolon at the end of statements when we go back to old articles. In this case, it doesn't even work without the semicolon, so it is even more important. I'll see if I can fix this one article and encourage all of our Microsoft writers to pay attention to this. Sorry, again, for the confusion!

Many thanks and best wishes.
Rich


[new product] Trend Micro Deep Security

Add Trend Micro Deep Security to products

Thanks for the PR. The description/table looks pretty good, I only had to make a few minor changes in wording.
I will double check the dates and merge.

Sounds good. I must admit the different support types were a bit confusing, with EOL also being named 'extended support' for LTS releases, and the old non-LTS releases having an extension to their support for all customers, but also is called 'extended support' and not EOL. your way sounds better and simpler to use.

Any updates on this?
I'm willing to make the changes specified if you'd like.


Do not wake up NPC if there is still a mind attached.

About the PR

This pr makes it so that entities with an active mind (player) in them not wake up after the player disconnects.
Why / Balance

This became apparent with diona nymphs (?) and slime gyras (?). This caused players that disconnected while a nymph, gyras or other npc to resume their NPC behavior. Which I would call unwanted. This fixes that.
Technical details

Checks for if the "mind" value in mind component is filled. And returns if it is
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: Vasilis

fix: NPC's activly being controlled by a player wont return to their AI behevior if the player disconnects.

Wasn't AI for zombies implemented since people would often just ghost out of their bodies since they didn't want to play as a zombino?

Wasn't AI for zombies implemented since people would often just ghost out of their bodies since they didn't want to play as a zombino?

Yeah this breaks it

Yeah im working on it

(Does not include zombies)

is there a reason for this? I feel like people who ghost from zombies shouldn't just leave a boring empty body behind

(Does not include zombies)

is there a reason for this? I feel like people who ghost from zombies shouldn't just leave a boring empty body behind

Does not include zombies as in zombies WILL become ai
This makes all other mobs not become ai if they have a mind still.

 Ignore that

(Does not include zombies)

is there a reason for this? I feel like people who ghost from zombies shouldn't just leave a boring empty body behind

Seems like I was tired when writing that changelog. Zombies will go back to ai if the player ghosts out. I just had a brain fart when writing the changelog


Support HBase2.1

https://jira.apache.org/jira/browse/HBASE-22530
wait until this patch is applied

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


organizer check #298

currently working on getting query and resolver to work

The reason why isOrganizer isn't returning correctly at the moment is because the isOrganizer resolver isn't being called anywhere in the code. Right now, I am just fetching the isOrganizer field of the User which by default is null I believe (which is why the children aren't being returned correctly at the moment);
I'm not sure how to go about updating the isOrganizer field everytime we fetch for its value; I appreciate any feedback, thank you!

Going to close and reopen this PR. With all the force pushes and temporary deploys it's really hard to keep track of what's what. We'll get this merged though.

Also, this PR seems to have a lot of scope creep. I'm breaking it up into multiple most likely.


Upgrade appserver.io to v1.0.6 (Build: 21)

Thank you for the contribution. It was merged directly as 0c7ec315719c663f6cb4165009842645369c31bd to keep commit history cleaner. Your contribution is still credited to you.


"Don't ask for code again" for two factor auth is not working

I'm using the iOS view controller for sign in and the option to not ask for the code again when signing in with two factor auth is no being remembered. Could it be caused by the cookie swapping? I'm not sure what the cookie swapping is for, I just saw that the GTMOAuth2ViewControllerTouch does some custom cookie handling.

Not sure I'm following.  When you create the ViewController, you can provide a keychain item name to also have it save under.  Then when your app next starts you can reload the credential to avoid having the user log in again.  It sounds like you might be triggering the VC each time instead of saving to the KeyChain and reusing the credentials?

Yeah, I'm doing that, but what I mean is when you sign out and then sign in again (something I do during testing) the log in website asks for two factor auth codes every time, even when you've previously selected that it shouldn't ask for codes again.

yea, there used to be support to control this, but it end up being confusing in most cases, so it now always does the clear.  Seems to end up being the most correct for the end user case, but it is a little annoying during development.

OK, thanks for the info!


[fix] Allow swagger to show parameters of obtain token view #116

closes #116

Coverage increased (+0.05%) to 98.269% when pulling da8a2121055a72cb8b30f65b42b6301c689c6a88 on niteshsinha17:issues/116-show-parameters-of-obtain-token-view into 1ff86e27ffb5764e60c340da234fbcb0507a0aeb on openwisp:master.

Coverage increased (+0.05%) to 98.269% when pulling da8a2121055a72cb8b30f65b42b6301c689c6a88 on niteshsinha17:issues/116-show-parameters-of-obtain-token-view into 1ff86e27ffb5764e60c340da234fbcb0507a0aeb on openwisp:master.

@nemesisdesign I have made changes as you had suggested. If I have missed something then please let me know.


Circle given number as color and renders a white square?

Should be an error?
(circle 50 "solid" 50)

Contract checks were broken. Fixed now!
> (circle 50 "solid" 50)
:1:17: Runtime error:
    circle expected an string? in position 3 but a lit was given
    In program: (circle 50 "solid" 50)


Add allocated CPUs

I guess we need to add related dimension to calculation allocated CPUs and take it from metrics.
@miq-bot add @sergio-ocon

Coverage decreased (-0.3%) to 97.9% when pulling 4e408a43bac028652cec4b45a355bf1f851303d7 on lpichler:add_allocated_cpus into 317cc825dc4c500eb6565f99e65dec00825304d1 on miq-consumption:master.

Hi @lpichler.
@aljesusg has been working on this, and can review your code.
Meanwhile, can you add tests?, we want to have 100% coverage or close :D

ok, I am closing it for now as @aljesusg is working on it I don't have all info in my head.


I cant set port in windowls 10

Hello , I always used Laradock and Docker . but now I formated my computer . and installed windowls 10 ,
The problem is that windowls 10  does not aloud me to use port 80 . so I am trying to use port 8080 .
I have been having some problems , could some one help me here please ?
I am doing this -
I setted the .env file

I setted the docker-compose.yml file -

nginx/sites/default.conf

windols - C:\Windows\System32\drivers\etc\hosts

I type - docker-compose up -d nginx
It is working ok -

But I it cant find the host -

I used port 8081 , now it is ok .

@murilolivorato ，
1, docker-compose.yml file , do not need to change
2, nginx/sites/default.conf, (look at "root /var/www/public")
You only need to create a directory:
mkdir laradock/../public
echo "welcome" >laradock/../public/index.html


fix: int overflow for 32 bit machines

Closes https://github.com/celestiaorg/celestia-app/issues/2129
https://github.com/celestiaorg/celestia-app/pull/2121 didn't actually fix the issue because the expression
NanosecondsPerYear = int64(NanosecondsPerSecond * SecondsPerYear)

was multiplying two ints together prior to the cast to int64. Since the product of those two ints overflows an int32, the value would overflow prior to the cast.
The fix proposed in this PR converts SecondsPerYear to an int64. Now the expression multiplies an int and int64 so the product is an int64 which won't overflow.
Testing
I added this to the Makefile
## build-arm: Build the celestia-appd binary into the ./build directory. Target the linux OS and ARM (32-bit) architecture.
build-arm: mod
	@cd ./cmd/celestia-appd
	@mkdir -p build/
	@GOOS=linux GOARCH=arm go build $(BUILD_FLAGS) -o build/ ./cmd/celestia-appd
	@go mod tidy -compat=1.20
.PHONY: build-arm

Before
$ make build-arm
--> Updating go.mod
# github.com/celestiaorg/celestia-app/x/mint/types
x/mint/types/constants.go:15:29: NanosecondsPerSecond * SecondsPerYear (constant<PHONE_NUMBER>0000000 of type int) overflows int
make: *** [build-arm] Error 1

After
$ make build-arm
--> Updating go.mod

Nick is running into this error on an android, I'd imagine maybe the make build-arm isn't reflected in the makefile for node?

You're right the celestia-node Makefile doesn't have a make build-arm command. Clarifying question: is Nick trying to run celestia-node or celestia-app on Android?
If celestia-node, I think we should open an issue in celestia-node repo.
If celestia-app, I think we need a new issue in celestia-app and I can investigate

Circling back on this for visibility @jcstein:

@nwhite1 was trying to run celestia-node on Android.
The earliest celestia-app release with this fix was v1.0.0-rc10 so releases >= v1.0.0-rc10 shouldn't encounter this error. Releases < v1.0.0-rc10 will encounter this error.
I looked at a few releases of celestia-node to see what version of celestia-app they depend on.

These celestia-node releases should not work: v0.11.0-rc6, v0.11.0-rc7, v0.11.0-rc8
These celestia-node releases should work: v0.11.0-rc8-arabica-improvements, v0.11.0-rc9

If ya'll still observe this error on celestia-node releases that should work, can you please open a new GH issue?

hey @rootulp thanks for following up here. i don’t think an issue is needed, and will see if one of the newer versions works!

assuming it doesn’t happen on a release where it is fixed


common benchmark tool, support http:// url

Pull Request Test Coverage Report for Build 1410

5 of 6 (83.33%)  changed or added relevant lines in 3 files are covered.
22 unchanged lines in 7 files lost coverage.
Overall coverage increased (+0.02%) to 63.892%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core/rest_invoker.go
1
2
50.0%

Files with Coverage Reduction
New Missed Lines
%

core/loadbalancer/session_stickiness_strategy.go
2
84.75%

core/router/cse/router_manager.go
2
72.73%

core/handler/transport_handler.go
3
23.17%

core/rest_invoker.go
3
91.84%

core/config/route_config.go
3
0.0%

core/registry/servicecenter/util.go
3
48.21%

server/highway/highway_conn.go
6
79.05%

Totals

Change from base Build 1401:
0.02%

Covered Lines:
4928

Relevant Lines:
7713

💛  - Coveralls


V6.0_edu branch commit has delete source code file of dreamview module.

We appreciate you go through Apollo documentations and search previous issues before creating an new one. If neither of the sources helped you with your issues, please report the issue using the following form. Please note missing info can delay the response time.
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04): 18.04
Apollo installed from (source or binary): source
Apollo version (3.5, 5.0, 5.5, 6.0): 6.0_edu
Output of apollo.sh config if on master branch: NA

Steps to reproduce the issue:
Check last merge commit on branch v6.0_edu, It delete some source code , such as
modules/dreamview/frontend/src/renderer/routing_editor.js
Could anyone share any details about it?
Supporting materials (screenshots, command lines, code/script snippets):

@lj0919 can you help?


1091/mk/void withdrawal

Changes proposed in this pull request

Implements voidAccountWithdrawal

Context

Progress towards #1091

Checklist

[x] Related issues linked using fixes #number
[x] Tests added/updated
[ ] Documentation added
[ ] Make sure that all checks pass

@sabineschaller actually going to combine this with #1131, it'll be easier to review the voidWithdrawal and postWithdrawal together


705: examples/simple-get.js url endpoint invalid

Added a valid gist link so node examples/simple-get.js can run successfully. This is to fix: https://github.com/visionmedia/superagent/issues/705

LGTM. Recommend merge. Doc-only update so no semver bump necessary. @pornel @olalonde please review and merge if you agree. @reinaldo13 thank you for your contribution!


Expose state of connection pooling through metrics

In Promscale we are not exposing any details on database connection pooling. This issue is to expose details of the runtime state of DB connections being used.

IMHO we need a broader overhaul of metrics exposed by promscale. Current ones are not easily understandable and sometimes violate best practices. I tried to gather all changes in https://docs.google.com/document/d/1Eff08z17Rssk5xz1YDAwXnxe9bVa0seEn_e0jLivExI/edit?usp=sharing so we can overhaul it in one sweep or start going towards a common goal.


Feat razor changes

Purpose

Changes to add books and book authors at the frontend level.
General refactoring is performed and the API endpoint is centralized.

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

What to Check
Verify that the following are valid

Add authors
Add books
Add book authors

@microsoft-github-policy-service agree

Thank you @yovafree for your contribution. I will be reviewing this PR in the upcoming days.


Programmatically set the volume

Is there a way to control the volume of the video being played if its not muted? I know setVolume() exists but can't seem to get it to work.
My sad attempt:
$(document).ready(function() {
    $('[data-vbg]').each(function() {
        $(this).youtube_background();
        $(this).find('iframe')[0].setVolume(0.15);
    });
});

Hey there @another-blank-page! ✨ So, first of all this was intended to be just the background, without the capability of sound, I seriously cannot remember why I added the mute/unmute option. Anyway, I will add an attribute setting for the volume just for you, so stay tuned. The issue is that you are using jQuery which looses the reference for the index (facrory) object. VideoBackgrounds object holds the index of all of the players.
Instead of using jQuery you can do this:
// Initialize the VideoBackgrounds object using vanilla JS
const videoBackgrounds = new VideoBackgrounds('[data-vbg]', { your_properties: here });
// Loop through all of the initialized backgrounds, each background contains the player variable
// and depending on the Video, Vimeo, Youtube players you can set the volume.
// Just remember that the youtube videos wait for `window.onYouTubeIframeAPIReady` to be triggered.
for (let uid in videoBackgrounds.index) {
  if (videoBackgrounds.index[k] instanceof YoutubeBackground) {
    videoBackgrounds.index[k].player.setVolume(0.15); // this should set the volume for all your youtube backgrounds
  }
}

That's bout it! ☺ One quick update with volume is comming right up!

Hey hey @another-blank-page, so I've added a global variable VIDEO_BACKGROUNDS, now when jQuery is being used, and also an uniform function for setting the volume regardless of the type of the video. So you can still use jQuery and have this global variable out of the box.
for (let uid in VIDEO_BACKGROUNDS.index) {
  VIDEO_BACKGROUNDS.index[uid].setVolume(0.15);
}

You can also set the initial volume via an attribute data-vbg-volume="0.15.
Just remember that on mobile the mobile phone volume is picked up and this setting won't have an effect!
This update is in the latest release v1.0.18
Cheers! 🥂


When disabling then enabling region flowing again, DOM order seems reversed

Hello,
I'm testing the polyfill on this codepen :
http://codepen.io/raphaelgoetter/pen/aNrrNO
It works great when you resize the window for the first time... but the next times, the DOM order is reversed ("login" appears at the end for example).
Do you understand what I mean and could you fix that bug ?
Raphaël

Thanks for reporting the issue. It took me some time to figure the exact repro steps (resizing the window isn't enough, you have to resize past the media query breaking point), but I can repro the issue now.
Really weird, isn't it... I'll try to have a look this weekend because that doesn't look like a crazy edge case, it really should work by default.

Ok, I found the issue. During the first layout, nodes are inserted naturally in dom order. This is not the case on later cases. There was a very clever code to put them back in dom order while minimizing marshalling cost between DOM and Javascript, but it didn't work as expected when the nodes being inserted where not sibling of each other, like in your case.

FILTER_REJECT

Reject the node. Navigation methods defined for NodeIterator or TreeWalker will not return this node.
For TreeWalker, the children of this node will also be rejected.
NodeIterators treat this as a synonym for FILTER_SKIP.

FILTER_SKIP

Skip this single node. Navigation methods defined for NodeIterator or TreeWalker will not return this node.
For both NodeIterator and TreeWalker, the children of this node will still be considered.

Code was there:
	cssRegions.Flow.prototype.addToContent = function(element) {

		// walk the tree to find an element inside the content chain
		var content = this.content;
		var treeWalker = document.createTreeWalker(
			document.documentElement,
			NodeFilter.SHOW_ELEMENT,
			function(node) {
				return content.indexOf(node) >= 0 ? NodeFilter.FILTER_ACCEPT : NodeFilter.FILTER_REJECT;
			},
			false
		);

		// which by the way has to be after the considered element
		treeWalker.currentNode = element;

		// if we find such node
		if(treeWalker.nextNode()) {

			// insert the element at his current location
			content.splice(content.indexOf(treeWalker.currentNode),0,element);

		} else {

			// add the new element to the end of the array
			content.push(element);

		}

	};

I am going to change this code to either use TreeWalker properly by using NodeFilter.FILTER_SKIP, or do a binary seach inside content. Still not sure.

Great job, thank you !

Reopening issue as the same code was also used for addToRegions so the issue might persist in some cases. Will fix tonight.


#184581322 Circleci project setup

What does this PR do?
Integrate CircleCi with readme badge
Description of Task to be completed?

Created CircleCi account with the Github account
Joined the repo branch with CircleCi account to with build and test job.
Added CircleCi URL in the Readme file to have a badge above it.

How should this be manually tested?

it can be tested by clicking on the badge above the readme file which direct  you to the CircleCi account for more details.

Any background context you want to provide?
For the success integration of CircleCi they will be green badge and red for the failed integration which will present the error caused it to fail.
What are the relevant pivotal tracker/Trello stories?
#184581322
Screenshots (if appropriate)
Questions:

LGTM


Ensure tests fail for browser exceptions

This PR ensures all browser tests (Puppeteer, jsdom) fail for unhandled browser exceptions
It does a few separate things:

Adds Jest custom environments for Puppeteer, jsdom
Adds process.emit('error', error) to ensure browser exceptions fail tests
Prevents Jest Puppeteer incorrectly emitting uncaughtException
Sets the unit test default environment to jsdom (not Node.js)

Rebased since https://github.com/alphagov/govuk-frontend/pull/2937 merged and all passing still
I'll get this merged as it holds up https://github.com/alphagov/govuk-frontend/pull/2901 and https://github.com/alphagov/govuk-frontend/pull/2902


String based Include

In the older version of EF you were able to do something like:
        var query = db.CampaignCreatives.AsQueryable();
        foreach (string include in includes)
        {
            query = query.Include(include);
        };

So you were able to include by string. I'm missing this functionality in EF7. Will this be added?
Ef7 in general isn't really "dynamic friendly". Everything must be typed.

I just asked the same question here too http://stackoverflow.com/q/34124501/5647927

I too would like this, It helps with creating dynamic repositories. I have tried to make a workaround but it seems impossible to return Expression<Func<TEntity, TProperty>> as you never know the type of TProperty

I also need this functionality.
And I'm not sure if this will be picked up along with this enhancement, but I'm also missing that you can't do a dynamic DbSet: ctx.Set(Obj.GetType()). like you can do in EF6.

This should be a joke.
Before C# 6 we didn't have nameof and early versions of EF didn't have Include() method accepting lambda overload - only string. We somehow managed to get through. We made our own methods to determine property name based on lambda expression. Then EF embraced lambda parameter for Include() method and everything went well.
Now that there is nameof in C# one would think that we can finally forget about lambdas to determine property name. There is more concious, beautiful and performant way of doing this. But wait! EF team didn't implement Include() method overload accepting string! What? How? Why? An irony.

Marking for re-triage. We should consider this for 1.1

In triage we discussed a that using Include/ThenInclude could still work in a repository signature, however here are the issues I found with this:

It looks ugly
It requires exposing IQueryable in the method signature, which would allow any LINQ operatory to be used (thus defeating part of the purpose of a repository)
It requires use of EF specific methods when using a repository (which is likely designed to hide the data access technology)

public Blog GetById(int id, Func<IQueryable<Blog>, IQueryable<Blog>> includeAction)
{
    return includeAction(_context.Blogs).Single(b => b.BlogId == id);
}

var blog = repository.GetById(
    1,
    q => q.Include(b => b.Posts).ThenInclude(p => p.Author)
            .Include(b => b.Owner));

We also talked about the idea of having a custom data structure that the includes are specified in, which is then translated to the EF methods. This gets super messy with generic methods, see the workaround code I've added to the description of this issue, which translates from strings to the Include/ThenInclude methods.
After playing around with this, I am more convinced that a string based API is a really good addition and not just an easy option because it's what we had in EF6. Though one improvement over EF6 would be to allow the hierarchical navigation names to be specified as params, rather than (or perhaps in addition to) a dot separated string, to better support the nameof C# feature (see workaround code for details).

I've added some workaround code to the description of this issue (top of the page) that adds a string-based include method to EF Core. If you're going to use it in a production app, you probably want to look at more caching etc. as it makes extensive use of MakeGenericMethod etc.

Worth mentioning using this feature is risky if the include string is an unvalidated input coming from a user.
A user can cause EF to query the entire DB and cause a DoS with a single request or cause SqlInjection.

While recognizing that Core means the team is moving in a different direction, it seems a lot of code we we got used to writing has to be re-learned, and a lot of our old code base is useless now.  Your extension code is fine as an answer, but now requires a complete re-write of everything that calls my repository.  Not only that, but at least we were able to have lambda includes that gave us intellisense.  Now we have to use dot notation in a string which has no intellisense.  This seems very backwards and a downgrade from EF6.

I needed to use the string based workaround for a generic method. After implementing it, it kept throwing the "$"'{navigationName}' is not a valid property of '{currentType}'"" exception. Apparently, it was triggered because of the way I declared the collection directly with the interface.
public class Example
{
    public Example()
    {
        ExampleCollection= new HashSet<Example>();
    }

    public virtual ICollection<Example> ExampleCollection { get; set; }
}

This resulted in a change in the workaround method. Because of the direct declaration of the models it the old solution only detected the IEnumerable interface and not the ICollection interface
public static class IncludeByStringsExtensions
{
     private static MethodInfo _include = typeof(EntityFrameworkQueryableExtensions)
                     .GetMethod("Include");

     private static MethodInfo _thenIncludeReference = typeof(EntityFrameworkQueryableExtensions)
         .GetMethods()
         .Where(m => m.Name == "ThenInclude")
         .Single(m => m.Name == "ThenInclude" &&
                      m.GetParameters()
                       .Single(p => p.Name == "source")
                       .ParameterType
                       .GetGenericArguments()[1].Name != typeof(ICollection<>).Name);

     private static MethodInfo _thenIncludeCollection = typeof(EntityFrameworkQueryableExtensions)
         .GetMethods()
         .Where(m => m.Name == "ThenInclude")
         .Single(m => m.Name == "ThenInclude" &&
                      m.GetParameters()
                       .Single(p => p.Name == "source")
                       .ParameterType
                       .GetGenericArguments()[1].Name == typeof(ICollection<>).Name);

     public static IQueryable<T> Include<T>(this IQueryable<T> query, string include)
     {
         return query.Include(include.Split('.'));
     }

     public static IQueryable<T> Include<T>(this IQueryable<T> query, params string[] include)
     {
         var currentType = query.ElementType;
         var previousNavWasCollection = false;

         for (int i = 0; i < include.Length; i++)
         {
             var navigationName = include[i];
             var navigationProperty = currentType.GetProperty(navigationName);
             if (navigationProperty == null)
             {
                 throw new ArgumentException($"'{navigationName}' is not a valid property of '{currentType}'");
             }

             var includeMethod = i == 0
                 ? _include.MakeGenericMethod(query.ElementType, navigationProperty.PropertyType)
                 : previousNavWasCollection
                     ? _thenIncludeCollection.MakeGenericMethod(query.ElementType, currentType, navigationProperty.PropertyType)
                     : _thenIncludeReference.MakeGenericMethod(query.ElementType, currentType, navigationProperty.PropertyType);

             var expressionParameter = Expression.Parameter(currentType);
             var expression = Expression.Lambda(
                 Expression.Property(expressionParameter, navigationName),
                 expressionParameter);

             query = (IQueryable<T>)includeMethod.Invoke(null, new object[] { query, expression });

             var proptype = navigationProperty.PropertyType;
             if (proptype.GetTypeInfo().IsGenericType && proptype.GetGenericTypeDefinition() == typeof(ICollection<>))
             {
                 previousNavWasCollection = true;
                 currentType = navigationProperty.PropertyType.GetGenericArguments().Single();
             }
             else
             {
                 previousNavWasCollection = false;
                 currentType = navigationProperty.PropertyType;
             }
         }

         return query;
     }
 }

I found another solutions. I pass Expression to Include:
List<T> Get(Expression<Func<T, bool>> filter = null, Func<IQueryable<T>, IOrderedQueryable<T>> orderBy = null, Expression<Func<DbSet<T>, IQueryable<T>>> includeAction = null);

The problem really is not about "string includes" but about impossibility to create the function that can "dynamically" generate includes from its own parameters. Is this really a functional programming where .NET goes? Yes it could be C# problem not EFCore team but if the only one way to provide important uncurryng  operation on your interface functions is do the step back from "strongly typed" to "dynamic" please be brave to do it.

@rpokrovskij Maybe you are better off with Mongo or other NoSQL Databases?
EF is a strongly typed ORM, I don't expect it to change.

@gdoron one function that hides some C# limitations (the impossibility to have simple enough uncurrying function for such chains as you choose for Include interface) do not  make EF "not strongly typed"... Of course you can push users to use reflections but that shows only that you just do not understand that interface should be complete.

I found a solution:
http://stackoverflow.com/questions/38312437/can-a-string-based-include-alternative-be-created-in-entity-framework-core/38415886#38415886

@eqbalsajadi String-based include was shipped in EF Core 1.1. That stackoverflow is out-of-date.

@ajcvickers Thank you

@ajcvickers I don't get how the string support solves the issue of including multi-level include.
When we used to write something like this where my service was in charge to then handling the include:
Task<Order> GetOrderByIdAsync(string orderId, params Expression<Func<Order, object>>[] includeProperties);
...
await m_OrdersService.GetOrderByIdAsync(orderId, o => o.Lines.Select(l => l.Releases));

Is this the new way to go to keep my service in charge of handling the include?
Task<Order> GetOrderByIdAsync(string orderId, string includePathl);
...
await m_OrdersService.GetOrderByIdAsync(orderId, $"{nameof(Order.Lines)}.{nameof(OrderLine.Releases)}")

In that case the include string can break if someone decide to refactor the entities without noticing the issue!
Only solution I see in that case is exposing the IQueryable as @rowanmiller exposed in his post, with the associated concerns...

@ggirard07 Because you can write any API pattern you want, including the one for EF6, and then convert (e.g. parse the lambda expression) to a simple list of concatenated strings before passing to EF.

@ajcvickers Thanks for the information. EF6 was way more user friendly on this by avoiding any required knowledge about Expression.
No one in our team has experience with Expression and we try to avoid those by any way as it is a real pain to debug in that case.


Internal link.

https://daringfireball.net/projects/markdown/syntax#link shows internal links as
[hot text][marker]
then
[marker]:
This seems not to work? the hot text shows as a link to the document, the marker shows up as per source.
Is this a bug please?

If you don't include a URL with the reference, as seen here, then it is not recognized as a reference.
However, if you include the URL, it works fine.
[hot text][marker]

[marker]: http://example.com

If you are experiencing different behavior, then please provide a specific example as well as which version of Python-Markdown you are using and any extensions which you may be using.

On Mon, 30 Nov 2020 at 23:50, Waylan Limberg<EMAIL_ADDRESS>wrote:

If you don't include a URL with the reference, as seen here
https://johnmacfarlane.net/babelmark2/?normalize=1&text=[hot+text][marker]

[marker]%3A,
then it is not recognized as a reference.
However, if you include the URL, it works fine
https://johnmacfarlane.net/babelmark2/?normalize=1&text=[hot+text][marker]

[marker]%3A+http%3A%2F%2Fexample.com
.
hot text
If you are experiencing different behavior, then please provide a specific
example as well as which version of Python-Markdown you are using and any
extensions which you may be using.
An internal link was my use case

hot text
marker:  non link text.
From your response I assume it's only viable for 'indirect' links.
Apologies, I'll  insert html.
regards
--
Dave Pawson
XSLT XSL-FO FAQ.
Docbook FAQ.

[marker]:  non link text.

Yes, that is not a valid link reference and it not recognized as one, which is the correct behavior. The best approach is to use raw HTML.


terminal has error code when trying to click on tabs

/needsMoreInfo
Or if you no longer need the issue open please close it.


FF Bookmarks disappear when type set to default-blocky (1.6.8)

Hello! I've been using mtab for a while and it's been fantastic overall.
I recently updated to version 1.6.8 and noticed that bookmarks that are not in a folder disappear immediately after animations are loaded on the New Tab page when bookmarks.type is set to default-blocky.
Version
mtab version 1.6.8, Firefox 134.0b5, macOS 15.1.1

I have the same issue, with the added bonus, that animations are played even though I have animations disabled.
I think the bookmarks.defaultBlockyColor is also ignored for non folder bookmarks.
Going into a folder does not trigger the animation and disappearing problem. The color problem still occurs.
https://github.com/user-attachments/assets/a72d7664-8723-4caf-bb5a-0adc771ebfb6

Sorry about that, should be fixed in the next release.
https://github.com/user-attachments/assets/a432a6a4-e08e-4286-8f0c-c5ee51575386

Thanks for catching that

Let me know if it worked in release 1.6.9

Let me know if it worked in release 1.6.9

Fixed! Thank you 😊