maintainers/maintainers-list: add Matrix IDs

Motivation for this change

Quickly find a maintainer's contact
Link Matrix identities to Github and email

To do

[x] evaluate the list
[ ] verify all IDs

~I've scraped some of the Nix/NixOS Matrix rooms and tried to match user
names, avatars, user IDs etc. with other information from this list.
Note that this is all guesswork, the identities are not verified in any
way, yet.~
~Please, take a look at the diff and tell me if your Matrix ID is
correct and you're ok with adding it the list. Thank you.~
I think you're active on the NixOS Matrix space, so would you like to have your Matrix user ID included in the maintainers list? If so, please leave a comment and I'll be sure to add it.
Thank you.
@AluisioASG @Baughn @CRTified @GuillaumeDesforges @SuperSandro2000
@0x4A6F @aaronjanse @abathur @adisbladis @ajs124 @AmineChikhaoui @andir
@applePrincess @arianvp @shados @artturin @asbachb @bachp @bb010g
@bendlas @berberman @blaggacao @blitz @buckley310 @cdepillabout
@cheriimoya @chvp @cleverca22 @codyopel @cole-h @colemickens @cyplo
@dadada @dali99 @dasJ @davidak @davidtwco @delroth @domenkozar
@dotlambda @drupol @dywedir @edude03 @edwtjo @edolstra @ekleog @eliasp
@ElvishJerricco @emilazy @emmanuelrosa @endocrimes @ereslibre
@ericson2314 @etu @evalexpr @expipiplus1 @eyJhb @fabaff @cideM @felschr
@fgaz @figsoda @fortuneteller2k @fridh @frogamic @fzakaria @ggpeti
@gilligan @globin @cillianderoiste @grahamc @gytis-ivaskevicius
@happysalada @hax404 @mweinelt @higebu @hmenke @hoverbear @hqurve @htr
@iammrinal0 @Icy-Thought @immae @infinisil @IreneKnapp @jfroche
@06kellyjac @joepie91 @jojosch @jonringer @jonas-schievink @jtojnar
@kalbasit @kevincox @kirelagin @kloenk @kraem @L-as @L3afMe @laikq
@Lassulus @ldesgoui @legendofmiracles @nlewo @lheckemann @lovesegfault
@lschuermann @lukegb @lunik1 @ma27 @manveru @maralorn @mattchrist
@matthiasbeyer @maxeaubrey @mic92 @midchildan @misuzu @mjlbach @mkg20001
@mlieberman85 @mlvzk @mudrii @musfay @mvnetbiz @ncfavier @nh2
@ninjatrappeur @nixinator @noneucat @nrdxp @numkem @obfusk @onny
@Pacman99 @petabyteboy @piegamesde @nbp @plabadens @polygon @polykernel
@primeos @princemachiavelli @prusnak @psibi @pstn @putchar @alyssais
@raboof @ralith @rissson @Rizary @rmcgibbo @roberth @roosemberth @ryantm
@s1341 @samueldr @sdier @stigtsp @siraben @solson @spacekookie
@spencerjanssen @srhb @stephank @superherointj @symphorien @Synthetica9
@tadfisher @taktoa @talyz @teto @tfc @thefloweringash @ThibautMarty
@tilpner @tnias @tomberek @toonn @unode @vaibhavsagar @valodim @vcunat
@Xe @xfix @yayayayaka @yorickvp @yu-re-ka @yusdacra @zakame @zhaofengli

Good for me

Correct ID and fine for me.

@ajs124 Fixed, thank you.

Also from our Matrix server:
Scriptkiddi = "@fritz.otlinghaus:helsinki-systems.de";
SlothOfAnarchy = "@michel.weitbrecht:helsinki-systems.de";

Mine is good.

Correct ID and fine to add.
Great initiative, thanks! :sparkles:

Also from our Matrix server:

Thank you! I added both.

Also, that should be documented in the comment at the beginning of the file so new users know to add the info.

Done.

Not everybody was notified, I think github is limiting the amount of mentions

Not everybody was notified, I think github is limiting the amount of mentions

Yes, looks like it. I'll try to break it into several comments.

Ping:
@endocrimes @ereslibre @ericson2314 @etu @evalexpr @expipiplus1 @eyJhb @fabaff
@cideM @felschr @fgaz @figsoda @fortuneteller2k @fridh @frogamic @fzakaria
@ggpeti @gilligan @globin @cillianderoiste @grahamc @gytis-ivaskevicius
@happysalada @hax404 @mweinelt @higebu @hmenke @hoverbear @hqurve @htr
@iammrinal0 @Icy-Thought @immae @infinisil @IreneKnapp @jfroche @06kellyjac
@joepie91 @jojosch @jonringer @jonas-schievink @jtojnar @kalbasit @kevincox
@kirelagin @kloenk @kraem @L-as @L3afMe @laikq

Ping:
@Lassulus @ldesgoui @legendofmiracles @nlewo @lheckemann @lovesegfault
@lschuermann @lukegb @lunik1 @ma27 @manveru @maralorn @mattchrist
@matthiasbeyer @maxeaubrey @mic92 @midchildan @misuzu @mjlbach @mkg20001
@mlieberman85 @mlvzk @mudrii @musfay @mvnetbiz @ncfavier @nh2 @ninjatrappeur
@nixinator @noneucat @nrdxp @numkem @obfusk @onny @Pacman99 @petabyteboy
@piegamesde @nbp @plabadens @polygon @polykernel @primeos @princemachiavelli
@prusnak @psibi @pstn @putchar @alyssais @raboof @ralith

Ping:
@rissson @Rizary @rmcgibbo @roberth @roosemberth @ryantm
@s1341 @samueldr @sdier @stigtsp @siraben @solson @spacekookie
@spencerjanssen @srhb @stephank @superherointj @symphorien @Synthetica9
@tadfisher @taktoa @talyz @teto @tfc @thefloweringash @ThibautMarty
@tilpner @tnias @tomberek @toonn @unode @vaibhavsagar @valodim @vcunat
@Xe @xfix @yayayayaka @yorickvp @yu-re-ka @yusdacra @zakame @zhaofengli

correct and ok for me

For easy checking who's left to verify the following should work when executed in the browser console together with a jQuery inject extension
const interacted = $('.author').toArray().map(e => $(e).text().trim())

const mentioned = $('.user-mention').toArray().map(e => $(e).text().trim().replace('@', ''))

const missing = mentioned.filter(u => interacted.indexOf(u) === -1)

Are those identifiers static or irrevocable? E.g. would it be possible for @someuser:matrix.org to move to @foobar:matrix.org and someone else to take control of @foobar:matrix.org?
And in that scenario, is there a backing identifier in Matrix used that shows @foobar:matrix.org is the same user as @someuser:matrix.org?
What I want to know is whether we need have a something like githubId, a matrixId using an actual immutable identifier.

Are those identifiers static or irrevocable?

Matrix user IDs are like email addresses: unlike the display name, this is unique over the federation and immutable.

What I want to know is whether we need have a something like githubId, a matrixId using an actual immutable identifier.

It's more like a githubId, in fact I wasn't unsure whether to call it matrix or matrixId.

This just makes me realize how long I've been putting off setting up my own homeserver. Let's be real, this is going to be my matrix identity for a while still, so mine  looks good. Thanks for doing this! :)

please add @zeri:matrix.org at line 12589 : ) (sry for github problems prevent me from proposing the change directly)

please add @zeri:matrix.org at line 12589 : )

Done, thank you!

@piegamesde: Fixed, now.

I'd be interested in knowning how you got that handle.

I was using a vim macro to copy the github username and add matrix.org,
which is the most common matrix id, by far. I suppose I looked at your
ID, didn't notice the missing "de" at the end and pressed the macro
button.

I'm happy to be added too: @jb:vk3.wtf

I'm happy to be added too: @.***:vk3.wtf`

Done. Thank you!

@jfroche: Updated, thank you.

Although I am personally happy to have my matrix ID added to the file, I think this should be opt-in rather than opt-out. People from marginalized backgrounds can face concrete, real danger from having it be too easy for strangers to link their various identities together. I'm in favor of the commit that adds the "matrix" option, for maintainers who choose to add their own, but I think a bulk add of this type is irresponsible, especially since the commit is publicly visible whether or not it's ultimately merged.
I recognize that this is all information that isn't difficult to guess at for anyone who joins the chat rooms and idles in them, but there is a difference between "public" and "publicized".
I recognize that unhappy feedback of the type I'm offering is seldom welcome, especially when the work has already been done, so I don't intend to start a long discussion about this. I am offering my perspective in case anyone wants to consider it. In the event that this is merged, I will try my best to emotionally detach and accept that outcome.
I wish that this had been discussed before doing it.
Less importantly: My matrix ID as currently listed is incorrect; I left a comment with the correct one on the relevant line. Please change it.

Although I am personally happy to have my matrix ID added to the file, I think this should be opt-in rather than opt-out.

It is opt-in: I am asking for permission. I won't include any id
unless it will be verified and the maintainer is ok with this.

I recognize that this is all information that isn't difficult to guess at for anyone who joins the chat rooms and idles in them, but there is a difference between "public" and "publicized".

The information in this PR was given voluntarily by the maintainers or
collected manually by me (using just a Matrix client and vim) in a few
hours from the NixOS Matrix space. Really, it's no more private or
difficult to access than the content of this PR.

I recognize that unhappy feedback of the type I'm offering is seldom welcome

No, I appreciate that you're concerned with the maintainers' privacy, but I
honestly think this is a bit of an overreaction.

I wish that this had been discussed before doing it.

In fact, I did ask on the RFC 0094 discussion and they told me it was ok to start a PR without an additional RFC.

Less importantly: My matrix ID as currently listed is incorrect

Sorry, I should have fixed it.

Less importantly: My matrix ID as currently listed is incorrect; I left a comment with the correct one on the relevant line. Please change it.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/NixOS/nixpkgs/pull/140136#issuecomment-932604193

OK

Fine by me

All right.  We have a difference of opinion, and I hope that it's a learning experience. I just want what's best for everyone.
I do feel that it would have been better to not put your findings here on GitHub, where they are indexed by search engines, until you got consent from people, but I also understand why that would be more work in terms of record-keeping. I also understand that the need for it is debatable. This is one of many topics where people have different perspectives about what's important, depending on their background.
With privacy issues in general, it's always quite difficult for any one person to anticipate what's going to be an issue for somebody else. That being the case, things like this are going to happen, and I do understand that.
We've both said our piece, and anyway it's done now. Please consider this approved on my part.

I am happy to be added too: @bobby285271:matrix.org.

I do feel that it would have been better to not put your findings here on GitHub, where they are indexed by search engines, until you got consent from people

You're right, it would have been better to ask before. It's just that I didn't want to burden the maintainers with finding their own ID and posting it here. It could have been done by sending out private messages on Matrix or email asking to confirm.
If anything like this will ever come up again, I'll try to be more careful.

We've both said our piece, and anyway it's done now. Please consider this approved on my part.

Thank you.

@bobby285271: Added, thank you.

I do feel that it would have been better to not put your findings here on GitHub, where they are indexed by search engines, until you got consent from people

You're right, it would have been better to ask before. It's just that I didn't want to burden the maintainers with finding their own ID and posting it here. It could have been done by sending out private messages on Matrix or email asking to confirm. If anything like this will ever come up again, I'll try to be more careful.

We've both said our piece, and anyway it's done now. Please consider this approved on my part.

Thank you.

Likewise, thank you.

Mine is correct.

@maxeaubrey As I said before, it is opt-in. I'm asking maintainers whether they wants to be included in the list and I won't add any contact that it's not acknowledged. I compiled this list only for your convenience and without any privileged access (I just compared the matrix ids on the NixOS rooms with the github username).

@rnhmjoj opt-in would be maintainers providing that information, or giving you approval to find it.
You scraping and then tying together identities however was not opt in, with no ahead of time opt out and nonconsensual, then published in a way that is now trivially findable. That is a breach of trust and people's privacy.

I think it's an honest mistake here. He thought it might have been a problem and was told it wasn't needed to make an RFC. I think the point has been made that this is problematic, and I don't think anyone disagrees now.
Do you think it would be okay if your handle was removed from the list or do you want other actions to be taken ?
(just trying to understand how to move forward here, I think everybody's awareness has been raised for the future).

For the record and discourse management, there is relevant discussion in the now collapsed and hard to browse comments, as github does. In the interest of not going in circles too much here, everyone who wants to engage please feel encouraged to read the whole thread.

All right, it appears what I've done was a bad move, so I've removed all the user IDs that haven't been confirmed yet and updated the message accordingly.
I also sent a request to the Github support asking for the removal of the history of this PR.

I approve for my Matrix ID — thank you.

and my matrix ID us @cleverca22:matrix.org

Mine is @fgaz:matrix.org

@nixinator:nixos.dev
i have have consulted with my master control AI, skynet, it approves of this change. great idea!

Could we please merge this asap and make a post on discourse instead so people can add themselves on their own terms? I got a 100 emails from this thread in a day and it's a little bit overwhelming...

Added @fzakaria, @nixinator, @matthiasbeyer, @fgaz, @cleverca22 and @addict3d. Thank you!
Also, all the git commits containing the full unchecked list have been purged from Github.

Could we please merge this asap and make a post on discourse instead so people can add themselves on their own terms? I got a 100 emails from this thread in a day and it's a little bit overwhelming...

I guess so, all the ids in the list should have been verified. We could collect IDs on the discourse forum and add them in more batches, to avoid creating tons of PRs.

Mine is @talyz:matrix.org and I'm okay with having it added :)

@rnhmjoj I just want to say thank you for doing that, and +1 on merging so folks can add themselves at will.

@talyz added. Thank you!

@rnhmjoj I just want to say thank you for doing that, and +1 on merging so folks can add themselves at will.

I'll wait a bit more for the maintainers to reply. I'll double check everything and try to merge this tomorrow.

Mine is @ericson2314:matrix.org. Thanks for doing this!

Mine is @ericson2314:matrix.org. Thanks for doing this!

Added. Thank you!

mine is @mic92:nixos.dev

mine is: @s1341:matrix.org

@mic92 @s1341 added. Thank you!

@rnhmjoj as per our conversation on matrix:

aanderse: for the sake of verifying the matrix identity, can you leave a comment on the PR?

Yes, I'm @aanderse:nixos.dev. Thank you!

mine is @bendlas:matrix.org

@bendlas added. Thank you.

My matrix id is correct. Thanks!

Please add @hmenke:matrix.org

@hmenke Done. Thank you!

hello @rnhmjoj  you can add @putch4r:matrix.org
if you dont mind

hello @rnhmjoj  you can add @.***:matrix.org`

Done. Thank you!

You can add @buckley310:matrix.org for me.

@buckley310 Sorry, I had mistakenly removed you (among with other nine maintainers). I fixed this, now.

I think I'm ready to merge, now. Here are the results:
accepted: 130/192

06kellyjac
0x4a6f
aaronjanse
adisbladis
ajs124
artturin
asbachb
bachp
bb010g
bendlas
berberman
blitz
buckley310
cdepillabout
chvp
cleverca22
cole-h
colemickens
crtified
cyplo
dali99
dasj
davidak
dotlambda
drupol
dywedir
eliasp
emmanuelrosa
ereslibre
ericson2314
etu
evalexpr
expipiplus1
eyjhb
fabaff
felschr
fgaz
figsoda
fortuneteller2k
fzakaria
ggpeti
gytis-ivaskevicius
happysalada
hax404
hmenke
hoverbear
iammrinal0
icy-thought
immae
infinisil
ireneknapp
jfroche
joepie91
jojosch
jonas-schievink
jonringer
jtojnar
kalbasit
kevincox
kirelagin
kloenk
l3afme
l-as
lassulus
ldesgoui
legendofmiracles
lovesegfault
lschuermann
lukegb
lunik1
ma27
manveru
maralorn
matthiasbeyer
mic92
midchildan
mjlbach
mkg20001
mvnetbiz
mweinelt
ncfavier
nh2
ninjatrappeur
nixinator
nlewo
noneucat
nrdxp
numkem
obfusk
pacman99
petabyteboy
piegamesde
primeos
princemachiavelli
psibi
putchar
raboof
ralith
rissson
rmcgibbo
roberth
s1341
samueldr
sdier
siraben
solson
spencerjanssen
srhb
stephank
superherointj
supersandro2000
symphorien
taktoa
talyz
tfc
thibautmarty
tnias
tomberek
toonn
unode
vaibhavsagar
valodim
vcunat
xe
xfix
yayayayaka
yorickvp
yu-re-ka
yusdacra
zhaofengli

refused: 4/192

endocrimes
frogamic
mattchrist
maxeaubrey

unconfirmed: 58/192

aluisioasg
baughn
guillaumedesforges
abathur
aminechikhaoui
andir
appleprincess
arianvp
shados
blaggacao
cheriimoya
codyopel
dadada
davidtwco
delroth
domenkozar
edude03
edwtjo
edolstra
ekleog
elvishjerricco
emilazy
cidem
fridh
gilligan
globin
cillianderoiste
grahamc
higebu
hqurve
htr
kraem
laikq
lheckemann
misuzu
mlieberman85
mlvzk
mudrii
musfay
onny
nbp
plabadens
polygon
polykernel
prusnak
pstn
alyssais
rizary
roosemberth
ryantm
stigtsp
spacekookie
synthetica9
tadfisher
teto
thefloweringash
tilpner
zakame

submitted: 7

aanderse
addict3d
bobby285271
jbedo
scriptkiddi
slothofanarchy
zeri42

In total I have added 137 Matrix IDs to the list that have been either confirmed or submitted by the maintainer. I have checked that:

the IDs are valid
the list evaluates
the Nixpkgs library tests pass

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixpkgs-maintainers-matrix-ids/15350/1


add last seen to local network advertisment

with last seen time of last packet seen from an address, when it expires, the node is removed from the local peers list. The number of local peers can be used to determine if the nodes are connected to the internet or not, which should mean 'not current' for a mainnet chain and 'not current' for testnet nodes - for them, make a new flag called 'lan' which indicates on testnet to not check for external peers and not use public testnet seeds and to wipe the peers.json when it starts so it doesn't connect out unless you added an external address manually to the peers list.

now keeps track of count and details of nodes broadcasting advertisments on the network. The number is now available to create a test for whether to mine.
Last piece to do is to change the IsCurrent() function to inspect these numbers and return false if --lan is not set and ConnectionCount  <= local connected nodes count (and not mine thus unless connected outside of the lan)

everything is done now, nodes don't mine unless lan is set on if only local connections exist. if one is and one isn't, the worker it starts mines to the one that is set to lan.
seems to be some issue with filtering the peers list in the peer manager, it isn't consistently listing actual connection counts. For now local peers count as 2 as they often are counted as 2, and thus produce the correct < 0 count that disables the dispatch of job messages.
need to fix the peer connection count tracking algorithm


QWEN API key

Describe your problem
[Question]: Hello everyone, I have just accidentally deleted the Tongue Qwen API and all my embedding works and inference works could not be proceeded.  I’m using local LLM with LM studio as backend actually.  Could anyone help me for the default API key. Thanks

hi @Alamkf  You don't need to add an API key when using a local model, simply add it on the model provider page directly.

謝謝黃總我之前問題已解決了，用了local 的來做default.期待RAGFLOW有更好的更新，目前我覺得它是RAG做得最好的了，也因此我剛投了不少錢升級硬件來加速。謝謝林從我的 iPhone 傳送黄腾 @.***>於2024年9月9日 11:34寫道：
hi @Alamkf  You don't need to add an API key when using a local model, simply add it on the model provider page directly.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>


Select DSAG logo and favicon

As a start for the CI of DSAG we can already select a logo because this is already supplied by the theme.
Also a favicon would also be useful
I have already created a template here #22

@vobu @rotda
Do we have access to various DSAG logos that we can use here?

@vobu @rotda
Do we have access to various DSAG logos that we can use here?

Can you try this one ?
https://www.dsag.de/sites/default/files/2019-12/DSAG Logo.svg

Can you try this one ?
https://www.dsag.de/sites/default/files/2019-12/DSAG Logo.svg

@rotda that´s the one in #22

@rotda that´s the one in #22


RESTful Api's not grouped according to group resource

When using the package as intended and described here "Each of the resources will expose a single cloud function endpoint using express and we will internally split the paths and perform the intended actions.".
Currently the endpoints overwrite each other with this url
http://localhost:5000/boxtout-production/us-central1/restful-api
They are organized as follows:
functions
src
orders
restful
getOrders.endpoint.js
getMenuItems.endpoint.js
payments
restful
addPayment.endpoint.js
...
When we build the backend all the function won't live in the same folder. This is a common practice when building a system that multiple developers will work on or if the project is intended to be worked on over multiple years. The way we build the backend using the firebase-backend package is by creating major resources groups which are divided into two parts.

Reactive functions: A function that will only run in reaction to a change in firebase's database, auth, cloud storage or any other service with a trigger event on it.
RESTful function: A restful endpoint for the dedicated resource that will only run when called directly through an http request.

As an example we can look at the boxtout backend (which is why this package is being built). It's split into 5 major "parts" of the backend:

Orders
Users
Payments
Products
Tips

As it was originally built in the boxtout src when publishing the .endpoint.ts functions it created an api for each group. This package does not do that. I expect 1 of the following to be true when publishing my backend restful functions.

Each group has its own api (original)

This would publish urls looking something like this:
http://localhost:5000/boxtout-production/us-central1/orders-api/{endpointName}
http://localhost:5000/boxtout-production/us-central1/users-api/{endpointName}
http://localhost:5000/boxtout-production/us-central1/payments-api/{endpointName}
http://localhost:5000/boxtout-production/us-central1/products-api/{endpointName}

One api is published for the backend with a dedicated resource path per resource grouping

http://localhost:5000/boxtout-production/us-central1/api/order/{endpointName}
http://localhost:5000/boxtout-production/us-central1/api/users/{endpointName}
http://localhost:5000/boxtout-production/us-central1/api/payments/{endpointName}
http://localhost:5000/boxtout-production/us-central1/api/products/{endpointName}

@r0hit-gupta please look at this when you get a chance

Clone and test the functionality on this branch of boxtout. It attempts to make use of the firebase-backend package.
run npm run serve to run locally and see if the api is being grouped according to this issue above.


Usage of form validators doesn't feel right - Proposal for better return type

Hello,
I am right now building some form in flutter using TextFormFields as described here https://flutter.dev/docs/cookbook/forms/validation.
The validator parameter of TextFormField is defined as some typedef FormFieldValidator<T> = String Function(T value).
It might seem like a small thing, but this forces to return null for indicating a valid input. This just feels wrong and looks wrong. If anything I would assume null being an invalid state.
Due to using Rust language recently, I would propose something that feels a bit similiar to the Rust Result<T1, T2> type, which I think is a good idea (so I want more of that :). The following may not be too Dart-Idiomatic due to lack of knowledge, however I hope it still makes the point clear:
/// This can be returned on any operation which may or may not succeed
/// for any defined reason
class Result<S, E> {
  final S success;
  final E error;
  final bool isOk;

  bool get isError => !isOk;

  /// Do not use this constructor, instead ise [Result.Ok] or [Result.Error]
  Result._(this.isOk, {this.success, this.error});

  factory Result.Ok([S result]) {
    return Result._(
        true,
        success: result,
        error: null
    );
  }

  factory Result.Error([E error]) {
    return Result._(
        false,
        success: null,
        error: error
    );
  }

  /// Depending on [isOk] this will return the value of type [S] or type [E]
  dynamic unrwap() {
    if(isOk) return success;
    return error;
  }
}

/// New type for the form field validator attribute
typedef FormFieldValidator<T> = Result<void, String> Function(T);

/// some validator
FormFieldValidator<String> getValidator() {
  return (String input) {
    bool successful = input == "42";
    if(successful) {
      return Result.Ok();
    } else {
      return Result.Error("Something made boo boo");
    }
  };

}

void main() {
  var validator = getValidator();
  print("Does not validate");
  var result = validator("does not validate");
  print("Has error? ${result.isError}\nIs ok? ${result.isOk}\nResult: ${result.unrwap()}");

  print('-------');

  print("Does validate");
  result = validator("42");
  print("Has error? ${result.isError}\nIs ok? ${result.isOk}\nResult: ${result.unrwap()}");
}

with that the declaration of FormFieldValidatorcould be changed to typedef FormFieldValidator<T> = Result<void, String> Function(T). This pattern could also be used in any similar case.
See https://dartpad.dev/6f4a65b9734a68c718f6989857f6eb11 a browser-executable version of the code in Dartpad.

Hi @Mereep
I do think the current API reasy to understand: return a error message or return null to indicate that there is not error to show. From what I can see the approach you are suggesting does not get rid of the null value it just makes it implicit.
Can you elaborate more what is exactly wrong with the current API and why the one you suggested is better?
Cc @justinmc

Hi @Mereep
I do think the current API reasy to understand: return a error message or return null to indicate that there is not error to show. From what I can see the approach you are suggesting does not get rid of the null value it just makes it implicit.
This would add just too much complexity into the code base.
Can you elaborate more what is exactly wrong with the current API and why the one you suggested is better?
Cc @justinmc

The point is that a function which is called a validator should not indicate the a success using return null and in case of fail return an actual value (only). This totally hides the intent on what is going on and makes the code less readable and also quite akward.
Lets make this clear. We take the example from the cookbook which states
TextFormField(
  // The validator receives the text that the user has entered.
  validator: (value) {
    if (value.isEmpty) {
      return 'Please enter some text';
    }
    return null;
  },
);

which is returning null at the end indicating success. If someone outsider reads it, they will not link return null to an successful validation.
Instead, when using the definitions as given above one would write the very same example as:
TextFormField(
  // The validator receives the text that the user has entered.
  validator: (value) {
    if (value.isEmpty) {
      return Result.Error('Please enter some text'); // Validation is not ok
    }
    return Result.Ok(); // Validation is ok
  },
);

which makes the intent of the code totally clear and readable, don't you think?
Cc @justinmc

This is a really interesting issue, thanks for starting this discussion.  I admit that I was thrown off by validator returning null to mean success as well when I first learned it.  These are my initial thoughts:

Changing validator to have a return type of dynamic would probably do more harm than good because it would break static analysis of the return type. (I admit this would be much improved if https://github.com/dart-lang/language/issues/83 was fixed.)
The Result pattern is nice (I'm also a fan of Rust), but it would be an anomaly here when it's not used anywhere else in Flutter.  This idea might be too big for a small change like this.  When do we use error throwing and when do we use Result? Maybe I'm thinking too big though.
Simply renaming validator to something like getValidationErrorMessage might solve a lot of this kind of confusion as well.

In the meantime your Result class might make a nice pub package if you're inclined and others want to use this pattern.

Hi @justinmc,
Thanks for your thoughts on that. I will try to share mine.
Yes you're right this change is not as small as it seems. But not as big either. Right, using dynamic or object for that matter will break the analysis as long as it neither is replaced by the actual return type (breaking change) or https://github.com/dart-lang/language/issues/83 is fixed. However, The static analyser doesn't help right now either. The static analyser is not hinting the user to return null for success in the first place. In fact it doesn't even know that return null is valid at all.
Also. how to implement a situation where the success case can also carry information? Throw? Throw sometimes? Invent a new type? Result will also fix those scenarios (think of some HttpResponse for example)

When do we use error throwing and when do we use Result?

That is a very important point. Yes, where should the user know that a validation error is not to be reported by throwing a ValidationError? Its just not possible without digging the whole library. You can only hint on implicit conventions which is almost never a good idea. Having the Result return type makes that explicit and crystal clear while giving full static analyzer help.

it would be an anomaly here when it's not used anywhere else in Flutter.

Honestly, I don't know where Flutter uses comparable scenarios. I don't have too much flutter experience just yet (in fact I'm writing my first App using flutter atm.).  That said, the pattern is very clear, doesn't put additional cognitive load to the user and can be introduced in new APIs while slowly deprecating the old ones.

renaming validator to something like getValidationErrorMessage

This would be a breaking change itself and also feels like fixed with duct tape somehow ;-)
Seeing all the work that is put on explicit (non-)nullability in Dart it seems obvious to me that having null returns isn't  the best  idea in the first place.
To conclude, I think it is worthy considering a slow migration due to the non-breaking properties, the clear consumer code, clear APIs, long-run API consistency and increased confidence when consuming APIs. An option would also be to introduce the change to new comparable APIs while waiting for https://github.com/dart-lang/language/issues/83 to be introduced to the language to port the old ones.

Thanks for the well thought out response.  I think I agree with you for the most part, but the next question is: what can we actually do about this right now?
Flutter has an issue (https://github.com/flutter/flutter/issues/24722) for collecting big breaking changes that we may want to consider for large version changes.  You might want to add this idea and link to this issue if you think it's appropriate.
You also might want to write a design doc explaining the breaking change and the reasoning in this issue.  I think if you find a small-ish reasonable change that we can make now and try to argue for it, we might be able to start using this pattern in that one small place.


dask cluster errors when adaptive scaling is enabled with a custom scheduler

I am running into an issue when I create a fargate cluster in a context where the scheduler is already available.
the fargate cluster is spun up on ECS and uses a version of this python script. I let the instance run all the time so I start the cluster and leave it running
cluster = FargateCluster(
    vpc=os.getenv("VPC_ID"),
    region_name="us-west-2",
    subnets=[...],
    image=os.getenv("DASK_IMAGE"),
    n_workers=1,
    cluster_arn=os.getenv("FARGATE_CLUSTER_ARN"),
    mount_points=[...],
    volumes=[...],
    fargate_use_private_ip=True,
    scheduler_address=os.getenv("SCHEDULER_ADDRESS"),
    environment = {...}
)

cluster.adapt(minimum=1, maximum=int(os.getenv("DASK_MAX_WORKERS")))

print(f"Cluster Initialized {cluster}")

while True:
    time.sleep(1)

What happened:
Things work really well in the beginning. After a few iterations of tasks running on the cluster, I notice errors in the console
2022-04-14T14:26:10.151-07:00 | tornado.application - ERROR - Exception in callback functools.partial(<bound method IOLoop._discard_future_result of <tornado.platform.asyncio.AsyncIOLoop object at 0x7fb7599e22b0>>, <Task finished name='Task-784707' coro=<AdaptiveCore.__init__.<locals>._adapt() done, defined at /opt/conda/lib/python3.8/site-packages/distributed/deploy/adaptive_core.py:119> exception=TypeError("object SchedulerAddress can't be used in 'await' expression")>)
-- | --
  | 2022-04-14T14:26:10.151-07:00 | Traceback (most recent call last):
  | 2022-04-14T14:26:10.151-07:00 | File "/opt/conda/lib/python3.8/site-packages/tornado/ioloop.py", line 741, in _run_callback
  | 2022-04-14T14:26:10.151-07:00 | ret = callback()
  | 2022-04-14T14:26:10.151-07:00 | File "/opt/conda/lib/python3.8/site-packages/tornado/ioloop.py", line 765, in _discard_future_result
  | 2022-04-14T14:26:10.151-07:00 | future.result()
  | 2022-04-14T14:26:10.151-07:00 | File "/opt/conda/lib/python3.8/site-packages/distributed/deploy/adaptive_core.py", line 122, in _adapt
  | 2022-04-14T14:26:10.151-07:00 | await core.adapt()
  | 2022-04-14T14:26:10.151-07:00 | File "/opt/conda/lib/python3.8/site-packages/distributed/deploy/adaptive_core.py", line 229, in adapt
  | 2022-04-14T14:26:10.151-07:00 | recommendations = await self.recommendations(target)
  | 2022-04-14T14:26:10.151-07:00 | File "/opt/conda/lib/python3.8/site-packages/distributed/deploy/adaptive.py", line 157, in recommendations
  | 2022-04-14T14:26:10.151-07:00 | await self.cluster
  | 2022-04-14T14:26:10.151-07:00 | File "/opt/conda/lib/python3.8/site-packages/distributed/deploy/spec.py", line 378, in _
  | 2022-04-14T14:26:10.151-07:00 | await self.scheduler
  | 2022-04-14T14:26:10.151-07:00 | TypeError: object SchedulerAddress can't be used in 'await' expression

What you expected to happen:
After the error message, the autoscaling does not work anymore. If the cluster has 10 dask worker nodes when the message first appears, the cluster cannot increase or decrease the worker nodes
Anything else we need to know?:
All the images are based on docker: daskdev/dask:2022.1.0
Environment:

Dask version: daskdev/dask:2022.1.0
Python version: 3.8
Operating System: Ubuntu
Install method (conda, pip, source): pip

@jkanche Thanks for opening this! I'll keep looking into this, but I'll also encourage you to consider moving this question to dask/distributed where it'll be more relevant. :)


feat: istio gateway configurable secret name and certmanager usage

Added ability to configure certManager usage and tls secret name for istio gateway. If I missed something please let me know and I`ll fix it.

@dkhachyan can you clarify the use-case you are trying to support here?

In case when it`s not possible to keep CA certificate and key inside kubernetes as a result it will not be possible to create cert-manager issuer. These changes make it possible to disable cert-manager usage for istio gateway certificate generation so we can use existing secret with certificate.
May be its better to add useCertManager` variable and disable certificate generation regardless of whether certManager enabled  or not globally?

@thesuperzapper what do you think about giving ability to use existing secret with certificate for istio gateway?

@dkhachyan sorry for the late reply, but we can't allow users to directly set a custom certificate (at least in this way).
However, you can follow this guide to create an Ingress that uses a custom TLS secret, which will have the same effect (from a user perspective) without impacting the certificate the deployKF components see when talking to each other.
The main issue is that everything breaks if that certificate is not valid or expires, which is very likely to happen with user-provided secrets that are not automatically being refreshed by cert-manager.


Certain Processing Oredict patterns will redefine itemstacks in all mods

Issue description:
When setting certain items (so far only gold ingots and iron ingots) to use processing oredict patterns with 2+ items in a single input slot, the itemstack will be redefined in all recipes, including modded recipes to use the same quantity. Regular crafting works okay in spite of this, but modded recipes that use the same input item will be re-defined to use whatever the quantity is in the pattern input which essentially breaks them, so this is not just a cosmetic inconvenience in JEI. This bug will persist even after restarting the game unless the pattern is changed.
What happens:
See above
What you expected to happen:
The item quantity will not be re-defined in all recipes
Steps to reproduce:
(Updated modpack instance with only most recent versions of RS, JEI, and Forge, no other mods)

Place down a controller (creative or regular + powered)
Place an adjacent pattern grid
Create a oredict processing pattern with 2+ gold or iron ingots in an input slot and anything in the output slot. Check JEI uses for that input item.
Re-defining the pattern to only use 1 input in a slot fixes this bug. Restarting the game without changing the pattern does not fix this

Curiously enough, I have only been able to reproduce this issue with gold or iron ingots as inputs so far.
DEMONSTRATION
Version (make sure you are on the latest version before reporting):

Minecraft: 1.12.2
Forge: <IP_ADDRESS>36
Refined Storage: 1.6.14
JEI: 1.12.2-<IP_ADDRESS>6

Does this issue occur on a server? [yes/no]
Unsure, only tested in single player

I've been having the same issue. However this only happens to me when i check the oredict option.

The same to me. I've been able to reproduce this.

Also been able to reproduce. The recipe crafts normally in a manual crafting bench but in an RS system the excess is voided. The stack size change also causes jei's stacks to become redifined (a possible lead, will test soon). even when specifically instructing a recipe that is not causing the issue to not use a stack, the pattern will still use that errored quantity. For example creating a processing pattern (another lead?) that takes 64 cobble and turns it into 64 gravel using an irrelevant method will cause ANY other recipe in RS or JEI to display 64 cobble. however manual crafting is completely unaffected. As a temporary workaround. perhaps disable the ability to vary the input amount of a pattern.


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_563b2eq11v/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_563b2eq11v/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_563b2eq11v/clone/recipe/meta.yaml:41: missing_dev_url: The recipe is missing a dev_url
WARNING: /tmp/abs_563b2eq11v/clone/recipe/meta.yaml:41: missing_description: The recipe is missing a description
ERROR: /tmp/abs_563b2eq11v/clone/recipe/meta.yaml:41: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_563b2eq11v/clone/recipe/meta.yaml:41: missing_documentation: The recipe is missing a doc_url or doc_source_url
Errors were found


improvementSkip auto analyze empty table.

What problem does this PR solve?
When doing auto analyze, skip the table if the row count of this table is empty. This is more safe than write all 0 stats for this empty table, because the row count reported by BE is not realtime.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)

Test

[x] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[ ] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[ ] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall

run buildall


Fix Spelling Error in cairo_deployment_scripts.md

Closes #
Introduced changes
Description:
Fixes a spelling error in the word "scipts" by correcting it to "scripts."

Changes Made:
Corrected the spelling of "scipts" to "scripts" for accuracy and clarity.
Checklist

[x] Linked relevant issue
[x] Updated relevant documentation
[x] Added relevant tests
[x] Performed self-review of the code
[ ] Added changes to CHANGELOG.md

Please update the PR description so it follows the format defined in the template
https://github.com/foundry-rs/starknet-foundry/blob/master/.github/pull_request_template.md

Updated sir. Thank you.

We are no longer accepting contributions related to just spelling & grammar, see https://github.com/foundry-rs/starknet-foundry/blob/master/CONTRIBUTING.md#contributions-related-to-spelling-and-grammar


this$1.vm.$el.querySelector is not a function

Versions:

VueJs: 2.3.3
Vee-Validate: 2.0.0-rc.18

Description:
Some of the validating forms of my app are dynamically embedded on pages. Thus, in some cases, the template of the component containing form could not be rendered yet, and hence it's template it's just an empty comment element. And once v-validate.initial confirmed relates to some element of the form, the library tries to find such element... in the comment, with querySelector. Where comment element doesn't have such method.
Finally, we end up with:
TypeError: this$1.vm.$el.querySelector is not a function
    at vee-validate.esm.js:4065
    at Array.forEach (<anonymous>)
    at Field.updateDependencies (vee-validate.esm.js:4047)
    at Field.update (vee-validate.esm.js:3943)
    at new Field (vee-validate.esm.js:3833)
    at Validator.attach (vee-validate.esm.js:4650)
    at bind (vee-validate.esm.js:5374)
    at callHook$1 (vue.esm.js:5855)
    at _update (vue.esm.js:5780)
    at Array.updateDirectives (vue.esm.js:5761)

Solution:
Just wrap:
    if (!el) {
      el = this$1.vm.$el.querySelector(("input[name=\"" + selector + "\"]"));
    }

In try/catch too, just like it's done for the previous querySelector call:
    if (!el) {
      try {
        el = this$1.vm.$el.querySelector(("input[name=\"" + selector + "\"]"));
      } catch (err) {
        el = null;
      }
    }

Thanks for reporting this and providing a solution. closed in https://github.com/baianat/vee-validate/commit/0e6173720bae81ad3e5645b1cc9de8a282d95df7


parrot-ar-drone: make it playable and improve it

There are 6 major changes:

Use unprefix gamepad API to run on chrome after M32
Use chrome.sockets.(udp|tcp) API instead of deprecated chrome.socket API
Make it possible to reconnect to Drone after network error.
Add more features e.g. flip, emergency
Display drone's states
Fix many bugs

Thank you really much Dongseong! This looks :+1:
I'd like to try it out first with a drone first before merging if that's OK with you.
In the mean time, do you mind bumping app version in the manifest file?
Moreover, as you may already know, we require contributors to sign Google's open source Contributor License Agreement. It's easy to do, just click here to sign as an individual or corporation. See https://github.com/GoogleChrome/chrome-app-samples/blob/2af9f9e82bd762ebe1bfb413356ad596ae0c95eb/CONTRIBUTING.md

I've been playing with the app and a Drone and I have to say there were a lot of disconnections. Is that something you've experienced as well?

I didn't have experience more disconnection than before. Sometimes disconnection happens due to UDP socket disconnection but we can reconnect by pressing 'X'

@googlebot I'm a chromium committer and signed a CLA via Intel. In addition, I've already contributed on this project before.

Thank you.
Before merging your PR, can you address the small nit https://github.com/GoogleChrome/chrome-app-samples/pull/372#discussion_r27463857 and bump app version in the manifest.json file?

@beaufortfrancois , Thank you for reviewing!
I addressed nits and bump version up

Thank you really much Dongseong!
I just merged it and updated the Webstore Sample at https://chrome.google.com/webstore/detail/drone-controller-sample/lhdfniaagbjbipjmgfbnlbcmlbcgklkh

@beaufortfrancois thank you for reviewing. I'm enabling video. I'll submit PR soon.


iOS setup

For iOS is there any specific platform setup, because it appears to be not mentioned in the readme or docs.

I am closing all older issues. If this issue still exists in the latest version, please let me know.


Consider upgrade Telerport to use Asset Transfer Api

As we had a terrible experience with ParaSpell in the past, I would consider switching to Asset Transfer Api

https://github.com/paritytech/asset-transfer-api#substrateasset-transfer-api
https://paritytech.github.io/asset-transfer-api/

I understand your choice to leave.
What I do not understand is, why do you mark your experience with us as "terrible"? We often tried to resolve your issues within hours when they occurred (no matter what day was (moday or sunday) or if we had vacation or not). We are unable to predict Parachains switching from XCMv1 to XCMv3 and so we need a moment to catch these changes and all is patched already in newest version to which you did not update for a while.
Regardless to what you wrote, our team wishes you good luck on your dev road. We will still provide you support as before if necessary.
With kind regards,
Team ParaSpell


Docs: adding note for environment variable support

Signed-off-by: Damien DUPORTAL<EMAIL_ADDRESS>What does this PR do?
Kubernetes's User Guide: Adding a note about variable expansion passed to the Traefik Deployment as arguments.
Motivation
It closes https://github.com/containous/traefik-library-image/pull/30 .
More

[-] Added/updated tests
[x] Added/updated documentation

Additional Notes

Thanks @ionutvilie for your proposal and detailled contribution!
Please note that the rendering of multi-line code block inside a note is not well behaving. I ended up in the "less worse" case as in the following screenshot:

I am closing this PR for the following reasons:

It is adding a lot of confusion on a page already overloaded of content.
It is missing context: "where is the "CUSTOM_LOG_LEVEL" environment variable coming? Why? How?


Local WAL drain returns SQL error: no rows in result set

I'm running single-device setup on master branch (3b886c6d7f9530d4c4a3b28511bb847d0be1a0f7 at the moment) with GCS as storage backend on NixOS unstable desktop.
Upon running utahfs-client ..., this line shows up every 5 seconds in the log:
DATETIME local_wal.go:93: sql: no rows in result set

which seems to point at:
https://github.com/cloudflare/utahfs/blob/3b886c6d7f9530d4c4a3b28511bb847d0be1a0f7/persistent/local_wal.go#L83-L96
I'm guessing this is a result of not having anything to sync with the storage provider, though I could be wrong. Is this an expected behavior?
Edit: clarifying, seems like data storage/retrieval is working with a light minimal test (echo "hello world" > hello.txt seem to be persistent throughout restarts etc.) though I'd like to hear more from maintainers if this is a good enough sign to start relying on this storage.

No, this isn't an expected behavior. I suspect it might be related to the SQLite driver which was recently changed. Can you update to the current master (which reverts the change) and see if it still happens?

Rebuilt on 2c2be7936f92b415f22d5c4166522fc78bcda3b4 and it seem to work fine now!

Awesome, thank you :)


New team wizard: support subteams

This ticket was for the last screen in the subteam wizard, but it was hard to test that without integrating the rest of it too.
It doesn't submit yet because we're waiting on an RPC for that, but otherwise the new subteam wizard should be fully working.
cc @keybase/y2ksquad

bump @keybase/react-hackers


Fix handling for start of Message Of The Day

Fixes #87

Thank you for this pull request, can you please adjust the target of this PR against Develop?
I Added a develop branch after you opened this set of pull requests, as I believe it is not a good practice to commit directly to master.

I have "Allow edits from maintainers." checked, so you should have been able to do so, but I've gone ahead and done it for all of my existing PRs.


Unlock Jenkins

Hey,
Is there any way to automate Unlock Jenkins via cli? api? ansible?
or maybe i missed something in the default variables
( i know i can copy the initial administrator password from
/var/lib/jenkins/secrets/initialAdminPassword
but i want to automate this procedure)
thanks!

sorry, my mistake.
i edit the role incorrect


Update README

adding recursion - seen it and asked it in interviews

adding recursion - seen it and asked it in interviews


Question: can we accept "json" OpenApi input files?

The OpenApi files I try playing with are either the common sample PetStore swagger file (ref: https://petstore.swagger.io/ ) or a default dotnet new webapi template with swagger enabled.
Does Kiota accept .json openapi files?
very briefly checking the code, it feels like it's yaml only?
EDIT: i know that the swagger editor can save the json as yml ... but i'm just curious about just json without having to do the manual conversion?
EDIT 2: here's the sample json file i was using: https://petstore.swagger.io/v2/swagger.json
Same error occured when I saved it as yml (via https://editor.swagger.io/ ) and tried that :/

AB#9047

Although I haven't tested it yet, we're using the openapi library to do the parsing, and I believe it should be able to handle both JSON and yaml just the same. https://github.com/microsoft/kiota/blob/3c143c460c6c39c950f01a3b03e6e9a597e24585/src/Kiota.Builder/KiotaBuilder.cs#L75

Also please double check you're on the branch behind pr #100, it's much more complete in terms of cases it can handle

Ah! i was on main branch! i forgot you mentioned to use the f/s-f branch. i'll give that a go

@baywet yep. same thing with the #100 branch.

Hey @PureKrome
Thanks for the additional information. I took the time to try out with the open API description you provided and I was able to identify and fix 2 bugs.
The first one was with path management for open API description URIs
The second one was a case I forgot to handle because it's not present in the test file I've been using to date (a simple reference).
All of that is fixed in #109, please checkout that branch and keep the feedback coming on new issues :)

Confirmed - seems to be working. 2am here so i'll play with it tomorrow night and see how it feels / works.
Side note: i've already got a few ideas/questions in my head, but will wait until i've played with things first, before asking.
Excellent (and quick!) effort, @baywet! Well done!


DefinitionPrinter tests

We need to port the test cases for the DefinitionPrinter class. The reference implementation can be found here: https://github.com/graphql/graphql-js/blob/master/src/utilities/tests/schemaPrinter-test.js

I started this but it's a massive pain in the ass...

Still working on these, some tests can't be done because we don't handle descriptions very well, and directives can't be printed at all it seems.


Mount-DbaDatabase - Removed Code that will never be used

Not a bug, but I don't like unused code...
All existing databases will be skipped (see a few lines above), so no need to test for existing system databases.

Sweet! Thank you both 🙇🏼


Add missing license headers

Purpose

$subject

@lnash94 @ayeshLK
Can you review this PR and merge into the feature branch before merging #1601 to the master


Setup Dependabot for GitHub Actions

@bors r+

:pushpin: Commit 4198f765fa856ed41416f36c058e828952165f04 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 4198f765fa856ed41416f36c058e828952165f04 with merge 1f7ba38f78b43905a737f882793ee5ed83ff91a6...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 1f7ba38f78b43905a737f882793ee5ed83ff91a6 to main...


DO NOT MERGE: Testing the CI system

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

/hold

/close
mtu is now set from within a prow preset and bazel cache can now be overwritten in a prow preset via BAZEL_CACHE. That allows us to test every PR now on a separate zone.


virtcontainers: Rely on new interface LinkType field

The logic wants that virtcontainers should be the place where the common packages should be defined. This pull request takes care of defining generic network structures into a new package pkg/types/types.go, which is basically a duplication of what is defined by the agent. But this allows virtcontainers and its consumers (kata-runtime, kata-netmon, kata-containerd-shim) to be independent from the agent.
Based on the new package that define a new field LinkType for the structure Interface, Kata does not need anymore to do any assumption about the type of interface that needs to be added.
Fixes #866
Fixes #876

/test

@sboeuf As I commented here, I think the runtime should define its own types if it needs additional field that is not related to agent grpc.

/test

@bergwolf I have modified this PR according to our discussion here.
Please let me know what you think about it!

LGTM! Thanks @sboeuf !

/test

@WeiZhang555 changes applied :)

LGTM
Ubuntu machine is out of service, needs retriever

The metrics CI is down here. Let's move forward and merge this PR as it got 3 approvals already.


add HTTP Client tracing + fix Cake 5.1 error logger bug

I am confused - how does sentry know how long the request took and/or when the span should be started? It looks to me like it starts the span at the end of when the response was already received.

Have a look at https://github.com/getsentry/sentry-laravel/blob/master/src/Sentry/Laravel/Features/HttpClientIntegration.php for some inspiration.

thanks, that definitely helped.


chore(main): release audit 1.55.0

:robot: I have created a release beep boop
1.55.0 (2023-09-26)
Features

better license expression issue titles (3f3aad9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/sandworm-hq/sandworm-audit/releases/tag/audit-v1.55.0 :sunflower:


The version in the header is still 0.5.3

While the released version is 0.6.0. Master should probably have 0.6.1-dev or similar as a version in the header.

Good catch. it should be 0.6.0, wanna submit a PR? Then I can release a new version with the correct header.


Issue with the --headless argument

Describe the bug
When running android tests in a container, emulator -version does not work because of missing libpulse.so.0 library.
detox[5433] DEBUG: [exec.js/EXEC_CMD, #1] "/opt/android/sdk/emulator/emulator" -version
detox[5433] ERROR: [exec.js/EXEC_FAIL, #1] ""/opt/android/sdk/emulator/emulator" -version" failed with code = 127, stdout and stderr:

detox[5433] ERROR: [exec.js/EXEC_FAIL, #1]
detox[5433] ERROR: [exec.js/EXEC_FAIL, #1] /opt/android/sdk/emulator/qemu/linux-x86_64/qemu-system-x86_64: error while loading shared libraries: libpulse.so.0: cannot open shared object file: No such file or directory

This command has to be run with -no-window option.
To Reproduce

[x] I have tested this issue on the latest Detox release and it still reproduces

Steps to reproduce:

Install the latest detox with any runner.
Attempt to run detox test --headless -l verbose.
Notice in the log, that qemu-system-x86_64 is used instead of qemu-system-x86_64-headless

Expected behaviour

The --headless command should properly work and set the -no-window argument for calling the emulator.
Device and Verbose Detox Logs

$ detox test --headless -l verbose
detox[5421] INFO:  [test.js] loglevel="verbose" headless=true useCustomLogger=true forceAdbInstall=false DETOX_START_TIMESTAMP=1604495540237 readOnlyEmu=false reportSpecs=true jest --config e2e/config.json --testNamePattern '^((?!:ios:).)*$' --maxWorkers 1 e2e
detox[5433] INFO:  [DetoxServer.js] server listening on localhost:40525...
detox[5433] DEBUG: [AsyncWebSocket.js/WEBSOCKET_OPEN] opened web socket to: ws://localhost:40525
detox[5433] DEBUG: [DetoxServer.js/LOGIN] role=tester, sessionId=0e6a721c-b8c6-40ce-b426-34eece00c820
detox[5433] DEBUG: [DetoxServer.js/LOGIN_SUCCESS] role=tester, sessionId=0e6a721c-b8c6-40ce-b426-34eece00c820
detox[5433] DEBUG: [exec.js/EXEC_CMD, #0] "/opt/android/sdk/emulator/emulator" -list-avds --verbose
detox[5433] DEBUG: [exec.js/EXEC_CMD, #1] "/opt/android/sdk/emulator/emulator" -version
detox[5433] ERROR: [exec.js/EXEC_FAIL, #1] ""/opt/android/sdk/emulator/emulator" -version" failed with code = 127, stdout and stderr:

detox[5433] ERROR: [exec.js/EXEC_FAIL, #1]
detox[5433] ERROR: [exec.js/EXEC_FAIL, #1] /opt/android/sdk/emulator/qemu/linux-x86_64/qemu-system-x86_64: error while loading shared libraries: libpulse.so.0: cannot open shared object file: No such file or directory

detox[5433] ERROR: [EmulatorVersionResolver.js/EMU_BIN_VERSION_DETECT] Could not detect emulator binary version ChildProcessError: Command failed: "/opt/android/sdk/emulator/emulator" -version
/opt/android/sdk/emulator/qemu/linux-x86_64/qemu-system-x86_64: error while loading shared libraries: libpulse.so.0: cannot open shared object file: No such file or directory
 `"/opt/android/sdk/emulator/emulator" -version` (exited with error code 127)
    at callback (/home/circleci/unifiedpush-cookbook/react-native/push/node_modules/child-process-promise/lib/index.js:33:27)
    at ChildProcess.exithandler (child_process.js:315:5)
    at ChildProcess.emit (events.js:314:20)
    at maybeClose (internal/child_process.js:1021:16)
    at Socket.<anonymous> (internal/child_process.js:443:11)
    at Socket.emit (events.js:314:20)
    at Pipe.<anonymous> (net.js:676:12) {
  code: 127,
  childProcess: {
    _forkChild: [Function: _forkChild],
    ChildProcess: [Function: ChildProcess],
    exec: [Function: exec],
    execFile: [Function: execFile],
    execFileSync: [Function: execFileSync],
    execSync: [Function: execSync],
    fork: [Function: fork],
    spawn: [Function: spawn],
    spawnSync: [Function: spawnSync]
  },
  stdout: '',
  stderr: '/opt/android/sdk/emulator/qemu/linux-x86_64/qemu-system-x86_64: error while loading shared libraries: libpulse.so.0: cannot open shared object file: No such file or directory\n'
}
detox[5433] WARN:  [AVDValidator.js/AVD_VALIDATION] Emulator version detection failed (See previous logs)

Environment (please complete the following information):

Detox: 17.11.0
React Native: 0.63: does not matter
Node: v12.19.0: does not matter
Device: docker
OS: does not matter
Test-runner (select one): does not matter
Android emulator: <IP_ADDRESS>

Hi @mmusil, did you manage to get this working? I get the following error when running detox in Azure on a linux machine:
/usr/local/lib/android/sdk/emulator/qemu/linux-x86_64/qemu-system-x86_64: error while loading shared libraries: libpulse.so.0: cannot open shared object file: No such file or directory

Hi @SMJ93, could you post verbose logs please? Would like to know if it's on the same emulator command or on something different. :)  It works fine for me since my PR was merged.

Hey @mmusil, thanks for getting back to me so quickly! I found the issue - Azure do not support the Android emulator on Windows or Linux machines 🤦  Switching back to macOS worked!

@SMJ93 That sounds rather odd, but I'm not familiar with Azure at all :man_shrugging:... I'm currently trying to make android emulator work in docker container on OpenStack RHEL machine and it is a bit tricky because of KVM, but possible. :sweat_smile:

@mmusil haha yep! Now we are looking at using CircleCI instead of Azure 😂  Good luck!

@SMJ93 Were you able to run the android emulator reliably on CircleCi?
I keep getting below error but the app doesn't crash. Is this normal?
detox[16578] ERROR: [EXEC_FAIL, #187] ""/opt/android/sdk/platform-tools/adb" -s emulator-5554 shell "ps | grep \"io\.app\.appName$\""" failed with error = ChildProcessError: Command failed: "/opt/android/sdk/platform-tools/adb" -s emulator-5554 shell "ps | grep \"io\.app\.appName$\""
 `"/opt/android/sdk/platform-tools/adb" -s emulator-5554 shell "ps | grep \"io\.app\.appName$\""` (exited with error code 1) (code=1), stdout and stderr:

Also, sometimes I get the below log and the test starts failing on the below code.
Test Failed: 10.0sec timeout expired without matching of given matcher: at least 75 percent of the view's area is displayed to the user.

      34 | export const waitToBeVisible = async (props: WaitForProps) => {
      35 |   const elem = await waitForHelper(props);
    > 36 |   await waitFor(elem).toBeVisible().withTimeout(10000);
         |                                     ^
      37 |   return elem;
      38 | };
      39 |

      at waitToBeVisible$ (step-definitions.ts:36:37)
      at tryCatch (../node_modules/regenerator-runtime/runtime.js:63:40)
      at Generator.invoke [as _invoke] (../node_modules/regenerator-runtime/runtime.js:293:22)
      at Generator.next (../node_modules/regenerator-runtime/runtime.js:118:21)
      at tryCatch (../node_modules/regenerator-runtime/runtime.js:63:40)
      at invoke (../node_modules/regenerator-runtime/runtime.js:154:20)
      at ../node_modules/regenerator-runtime/runtime.js:164:13
      at tryCallOne (../node_modules/react-native/node_modules/promise/lib/core.js:37:12)

These errors don't occur always, but sometimes. I would say around 3/10 tests fail due to this. I would love to get some help, please.

@austonpramodh this looks to me like Detox flakiness and not a CircleCI issue, maybe try scrolling to the View in question so it is 100% in view?


Google login

Continue https://github.com/khatm-org/khatm-android/pull/7

resolves:
https://github.com/khatm-org/khatm-android/issues/2
https://github.com/khatm-org/khatm-android/issues/10


Improve error message when variable has no value set

Currently, it is quite confusing: #698.
Applying component 'metallb'...
cluster.lokocfg:77,18-39: Unsupported attribute; This object does not have an attribute named "metallb_address_pool"., and 1 other diagnostic(s)
FATA[0736] Applying component configuration failed: cluster.lokocfg:77,18-39: Unsupported attribute; This object does not have an attribute named "metallb_address_pool"., and 1 other diagnostic(s)  args="[]" command="lokoctl cluster apply"

I tried to find the code that generates these errors and I went down a long rabbit hole that yielded no good things.
I'm pretty sure this is where the error is generated:
https://github.com/hashicorp/hcl2/blob/master/hcl/ops.go#L183
But I don't know what lokomotive is doing to get that error when the variable is empty.

@marga-kinvolk thanks for looking into it. The right place to look is https://github.com/hashicorp/hcl/tree/hcl2 though.
I suspect it's bug in our variable implementation, that we hit that in HCL, in the code where we parse and merge variables (ugly, ugly, ugly).


Update documentation

Since project is using MaxMind database, docs are wrong to say it's using a SQLite one. Update this an any other reference to how the project works and its API, specially how to set the database to use :-)

Ok, my wrong... it's actually using SQLite, the changelog confused me to think that it was being using directly the MaxMind database. Would it make sense? Currently it's being used a single table, so probably by using MaxMind optimized one would not be needed to do the conversion but also could be faster to fetch the info... what do you think?

Sure, I'm open to PRs!


How to determine the right values for input_size?

My jpg files have a size around 5000 x 6000. I tried input_size=[1280, 1920] because 6000(img height) > 5000(img width). But it turns out input_size=[1280, 960] and [1920, 1280] outperforms [1280, 1920]. Is there any tips in determining the right input_size based on the image sizes? Or this only can be determined by trials?

@htcml
The smaller input_size you provide, the larger compression of your original images will be (thumbnail is created out of the original image so some information is lost during resizing).
Worth noticing is that in the config file, the input_size is [height, width], not the opposite.
So it's natural that if you images are 5000 in width and 6000 in height, then [1920, 1280] outperforms [1280, 1920].
In the latter scenario, your images (5000x6000) (w x h) are firstly compressed to size of (1066x1280) (w x h), and then padded randomly to size of (1920x1280) (w x h). As you can imagine, there is lots of padded area (1M pixels) which is not used optimally.
In the former scenario, your images (5000x6000) (w x h) are firstly compressed to size of (1280x1536) (w x h), and then padded randomly to size of (1280x1920) (w x h). Less area is padded (0.5M), so the original image takes larger area in the final image provided to the model vs. the previous scenario.


Manage Wikibase schemas should use a list (auto numbered) to improve display

Currently, the Manage Wikibase schemas dialog shows slight grey rows for each schema to be managed.
If one row only appears, then this looks awkward because the grey row with a schema name looks like some kind of header for the dialog, instead of a row element.  It would be better to tweak the display so that rows get numbered automatically.
Current Results

Expected Behavior
Rows are numbered as in this example (number just before the schema row for test).
If a 2nd schema was defined then I would expect numbered rows 1. and 2.

Screenshots

Versions

Operating System:
Browser Version:
JRE or JDK Version:
OpenRefine:

Datasets

Additional context
From Forum support topic https://forum.openrefine.org/t/where-is-export-import-schema-option-in-or-wikidata-extension-now/784

Hi! I'm quite new to Open Source. Can I take this issue? :)

@Hisiste please go ahead! Our guide for first code pull requests is here: https://openrefine.org/docs/technical-reference/contributing#your-first-code-pull-request

Great! Thank you very much. If I get stuck with this issue, can I ask you @wetneb for hints?


Not able to run ssnips-nlu generate-dataset

Two issues when I install it on MAC 10.12.6 (Sierra)

First it can't compile crfsuite, I have to use anaconda to install it.  The error is:
gcc -fno-strict-aliasing -I/Users/yhuang/anaconda2/include -arch x86_64 -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -Icrfsuite/include/ -Icrfsuite/lib/cqdb/include -Iliblbfgs/include -Ipycrfsuite -I/Users/yhuang/anaconda2/include/python2.7 -c pycrfsuite/_pycrfsuite.cpp -o build/temp.macosx-10.6-x86_64-2.7/pycrfsuite/_pycrfsuite.o -std=c99
error: invalid argument '-std=c99' not allowed with 'C++/ObjC++'
After I completed the installation.  I have issues to create dataset.  It works with entity file but not with intent.

$ snips-nlu generate-dataset en searchFlight.yaml
Traceback (most recent call last):
File "/Users/yhuang/anaconda2/bin/snips-nlu", line 11, in
sys.exit(main())
File "/Users/yhuang/anaconda2/lib/python2.7/site-packages/snips_nlu/main.py", line 39, in main
plac.call(commands[command], sys.argv[1:])
File "/Users/yhuang/anaconda2/lib/python2.7/site-packages/plac_core.py", line 328, in call
cmd, result = parser.consume(arglist)
File "/Users/yhuang/anaconda2/lib/python2.7/site-packages/plac_core.py", line 207, in consume
return cmd, self.func(*(args + varargs + extraopts), **kwargs)
File "/Users/yhuang/anaconda2/lib/python2.7/site-packages/snips_nlu/cli/generate_dataset.py", line 17, in generate_dataset
dataset = Dataset.from_yaml_files(language, list(files))
File "/Users/yhuang/anaconda2/lib/python2.7/site-packages/snips_nlu/dataset/dataset.py", line 105, in from_yaml_files
return cls(language, intents, entities)
File "/Users/yhuang/anaconda2/lib/python2.7/site-packages/snips_nlu/dataset/dataset.py", line 39, in init
self._ensure_entity_values()
File "/Users/yhuang/anaconda2/lib/python2.7/site-packages/snips_nlu/dataset/dataset.py", line 155, in _ensure_entity_values
for entity in self.entities}
File "/Users/yhuang/anaconda2/lib/python2.7/site-packages/snips_nlu/dataset/dataset.py", line 155, in
for entity in self.entities}
File "/Users/yhuang/anaconda2/lib/python2.7/site-packages/snips_nlu/dataset/dataset.py", line 172, in _get_entity_values
entity.name, self.language))
File "/Users/yhuang/anaconda2/lib/python2.7/site-packages/snips_nlu_ontology/builtin_entities.py", line 183, in get_builtin_entity_examples
% type(language))
TypeError: Expected language to be of type 'str' but found: <type 'str'>

Hi @yingyihuang ,
Thanks for reporting, this is indeed a bug which is Python2 specific. We are enforcing unicode strings all over the python lib, however when using the CLI with Python2, we end up with bytes that we must convert to unicodes.
I have fixed this issue in #727

Still getting same issue on Windows 7, Python 2.7 with latest snips-nlu package (0.18.0)


Communication problem between local containers

When we apply docker-compose available in the API directory, and try to access the GET /tasks endpoint, we are faced with the communication error between app x db.
2024-12-18 18:56:06 Can't reach database server at localhost:5432
2024-12-18 18:56:06 Please make sure your database server is running at localhost:5432.

Root cause:
When compose loads the file's environment variables, it loads the DATABASE_URL pointing to localhost, however, for some reason it cannot fill the container.
Solution Implemented:
To solve this problem I created a new .env file directly pointing to the container name

PR merged


Slider control table edit

Step 3 from https://github.com/chrisgoringe/cg-controller/discussions/59#discussioncomment-10875040

Provide a mechanism to edit that shared table

Milestone here will depend on how #61 works out


⚠ Bofrost.fr has degraded performance

In 9183c4d, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1510 ms

Resolved: Bofrost.fr performance has improved in 76312fc after 9 minutes.


AST: promote API/ABI impact bit of decl attributes to AST, NFC

ABI/API checker used to hard-code whether adding or removing of a
decl attribute could break the existing ABI/API. This is not ideal because
new attributes may be added to AST without updating the checker. After this
change, new decl attribute could be specified whether it has ABI/API
impact and the checker could pick up the knowledge instantly.

If you're doing this, it might be worth separating APIBreakingToAdd from APIBreakingToRemove (and similar for ABI).

@jrose-apple Yeah. The existing attributes are breakages in both ways, but separating them like what you mentioned is future-proof.

@jrose-apple Now we have four attributes: APIBreakingToAdd, APIBreakingToRemove, ABIBreakingToAdd and ABIBreakingToRemove.
@harlanhaskins Feel free to specify @_hasMissingDesignatedInits as APIBreakingToAdd and ABIBreakingToAdd. We could later adding logics in shouldDiagnoseAddingAttribute to filter out non-open classes. https://github.com/apple/swift/pull/26060

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Add tutorial on time series modelling

Please let me know if you have any comments or suggestions before merging. I could not run weave the file as described in the readme (it just got stuck forever) but I tested all the code in the REPL so it should work.
In the issue I describe working with the air passengers data set, but I couldn't find a nice way to load it into the tutorial so to avoid the problem altogether I opted for synthetic data,
Closes  #306.

I'm not sure why buildkite does not run the tutorial, maybe it doesn't run for PRs from forks @staticfloat?

Indeed.  If you want that, go into the buildkite admin settings, under GitHub and check the appropriate box:

Thanks! I enabled it for PRs from forks conditional on a "buildkite" label.

Thank you for the great suggestions @devmotion, very thorough review! I'm quite busy during the weekend but will address them early next week.

Thanks again for your comments @devmotion ! I have updated the PR accordingly, with a few exceptions which I motivate in your the relevant comments.
I see buildkite is crashing with ERROR: LoadError: The manifest file you are using was most likely generated by a different version of Julia and is not compatible with this Julia version when it tries to run the code under Julia 1.6 (I am indeed using a different version, 1.7.3). How do you suggest we proceed?

Can you recreate the Manifest file with Julia 1.6? That would fix the issue.

Fixed!

My pleasure @yebai ! Thank you for your work on Turing!


Configuring "jst" task doesn't work?

I'd like to configure the templateSettings used by the build process in build/tasks/jst/jst.js (I prefer Mustache-style templates).
It looks I should be able to use "jst.templateSettings" in my build config, but this isn't working as I'd expect:

if I use "jst.templateSettings" as a config key, it doesn't have an effect.
if I add "templateSettings" as a key to the "jst" object, then Grunt dies because it thinks "templateSettings" is a filename.

Is this a bug, or am I using it wrong?
(Very helpful project, thanks!)

The task was recently changed.  I'm working on a fix right now.  Perhaps the project could use some unit tests of its own ^_^

Okay patched and done! Use the meta property instead of the JST as the top level, and then use the JST subproperty to define your global namespace and templateSettings.
  meta: {
    jst: {
      namespace: "JSTl",

      templateSettings: {
        interpolate: /\{\{(.+?)\}\}/g
      }
    }
  },

Yep, that works for me.  Thanks for the quick fix!


Additional performance tweaks for UIA wrappers tests

For each test we make resolution of only controls are needed for that test.

Current coverage is 96.37%

Merging #167 into UIA will decrease coverage by -0.01% as of 291cc29

@@              UIA    #167   diff @@
=====================================
  Files          31      31
  Stmts       17625   17625
  Branches        0       0
  Methods         0       0
=====================================
- Hit         16988   16986     -2
  Partial         0       0
- Missed        637     639     +2

Review entire Coverage Diff as of 291cc29

Powered by Codecov. Updated on successful CI builds.


Feature Request: Get git users during initialization process

I think that during the initialization process, a new feature could be added to get existing git users, including the local and global. This saves a little ⚡ time in creating users and switching back to original global user

Should be safely closed by #7


Update NavViewEx

There are several things wrong with it, yet it is close.

[ ] Get it to build, there are some things
[ ] Update it to use Nuget T10 packages
[ ] Update the sample app.
[ ] Update the .nuspec file
[ ] Upload to Nuget.org for Windows-XAML

I want work on point 1-3, because I have already implemented this in large parts of my fork. For me, it makes sense, if we use WinUI library for the NavigationView.
https://github.com/jp-weber/Template10/tree/master/Source/Template10.Extras.16299/Controls
In the sample project I am looking for better ways to set the header in a simple way. We could add all header templates to the shellpage resource list and set them as HeaderTemplates after navigation or loading. With a naming convention you could set here e.g. 'MainPageHeaderTemplate'.
For the individual pages, e.g MainPage.xaml.cs you could now add the ViewModel of the page as (ShellPage).HeaderContent, so that commands can be added to the template.

One thing to consider is that I would like to break this out to its own Nuget package. I also think it might make sense to consider how (if) we can decouple it from Template10 so it would be useful outside of using the framework. Still not sure. Also, I only care about Template10 2 support.


unexpected_keys assertion error when running SERAC

Hi, I'm having some issues running the SERAC methed. I took a closer look at the https://github.com/zjunlp/EasyEdit/issues/261, but the issue is still not resolved
I tried JackFram/llama-160m, but the error still persists when running SERAC method and the error message is as follows:
metrics, edited_model, _ = editor.edit(
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/editors/editor.py", line 271, in edit
    edited_model, weights_copy = self.apply_algo(
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/models/serac/serac_main.py", line 68, in apply_to_model
    self.init_model(model, tok, hparams)
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/models/serac/serac_main.py", line 34, in init_model
    self.alg.load_state_dict(d["model"], False)
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/trainer/algs/SERAC.py", line 123, in load_state_dict
    assert len(res.unexpected_keys) == 0, print(res.unexpected_keys)
AssertionError: None

And the ouput of res.unexpected_keys is:

['replacement.model.layers.0.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.1.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.2.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.3.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.4.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.5.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.6.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.7.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.8.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.9.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.10.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.11.self_attn.rotary_emb.inv_freq']

I checked the code and found that this error was caused by
d = torch.load(params.archive, map_location='cpu')
self.alg.load_state_dict(d["model"], False)

and the params.archive was set to the path of the JackFram/llama-160m.
Do you have any ideas to solve this? Thank you.

I tried, but I couldn't reproduce your issue. Could you tell me where you downloaded the LLaMA2 model, or provide me with more information?

I download Llama-2-7B from shakechen/Llama-2-7b-hf, and there is part of SERAC hparams.
# Model
alg_name: "SERAC"
archive: ./results/models/SERAC/llama-2-7b.bk
device: 0
model_name: /models/meta-llama/llama-2-7b

model_class: LlamaForCausalLM
small_name: /models/JackFram/llama-160m
tokenizer_class: LlamaTokenizer
tokenizer_name: /models/meta-llama/llama-2-7b
cls_name: /models/distilbert/distilbert-base-cased
cls_class: AutoModel
inner_params: []
model_parallel: false

I noticed someone raised an issue saying this is incomplete on https://www.modelscope.cn/models/shakechen/Llama-2-7b-hf/feedback. Could you try downloading it from HF?

OK, I'll give it a try, thank you.

Llama-2-7b-hf from HF has been downloaded and tested, but the error persists.
Part of the error output is as follows.
./results/models/SERAC/llama-2-7b.bk
09/19/2024 14:39:58 - INFO - easyeditor.trainer.utils -   Set 13 dropout modules to p=0.0
09/19/2024 14:39:58 - INFO - easyeditor.trainer.utils -   Set 0 dropout modules to p=0.0
09/19/2024 14:40:06 - INFO - easyeditor.trainer.algs.SERAC -   Loaded model config doesn't match current model config.
09/19/2024 14:40:06 - INFO - easyeditor.trainer.algs.SERAC -   Loaded: LlamaConfig {
  "_name_or_path": "./hugging_cache/llama-2-7b",
  "architectures": [
    "LlamaForCausalLM"
  ],
  "bos_token_id": 1,
  "eos_token_id": 2,
  "hidden_act": "silu",
  "hidden_size": 4096,
  "initializer_range": 0.02,
  "intermediate_size": 11008,
  "max_position_embeddings": 2048,
  "model_type": "llama",
  "num_attention_heads": 32,
  "num_hidden_layers": 32,
  "num_key_value_heads": 32,
  "pad_token_id": 0,
  "rms_norm_eps": 1e-05,
  "tie_word_embeddings": false,
  "torch_dtype": "float16",
  "transformers_version": "4.36.2",
  "use_cache": true,
  "vocab_size": 32000
}

09/19/2024 14:40:06 - INFO - easyeditor.trainer.algs.SERAC -   Current: LlamaConfig {
  "_name_or_path": "/home/hli/models/Llama-2-7b-hf",
  "architectures": [
    "LlamaForCausalLM"
  ],
  "attention_bias": false,
  "attention_dropout": 0.0,
  "bos_token_id": 1,
  "eos_token_id": 2,
  "hidden_act": "silu",
  "hidden_size": 4096,
  "initializer_range": 0.02,
  "intermediate_size": 11008,
  "max_position_embeddings": 4096,
  "model_type": "llama",
  "num_attention_heads": 32,
  "num_hidden_layers": 32,
  "num_key_value_heads": 32,
  "pretraining_tp": 1,
  "rms_norm_eps": 1e-05,
  "rope_scaling": null,
  "rope_theta": 10000.0,
  "tie_word_embeddings": false,
  "torch_dtype": "float16",
  "transformers_version": "4.36.2",
  "use_cache": true,
  "vocab_size": 32000
}

['replacement.model.layers.0.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.1.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.2.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.3.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.4.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.5.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.6.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.7.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.8.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.9.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.10.self_attn.rotary_emb.inv_freq', 'replacement.model.layers.11.self_attn.rotary_emb.inv_freq']
Traceback (most recent call last):
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/run_knowedit_llama2.py", line 241, in <module>
    metrics, edited_model, _ = editor.edit(
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/editors/editor.py", line 305, in edit
    edited_model, weights_copy = self.apply_algo(
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/models/serac/serac_main.py", line 68, in apply_to_model
    self.init_model(model, tok, hparams)
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/models/serac/serac_main.py", line 34, in init_model
    self.alg.load_state_dict(d["model"], False)
  File "/home/hli/project/KnowledgeEdit/EasyEdit/examples/../easyeditor/trainer/algs/SERAC.py", line 146, in load_state_dict
    assert len(res.unexpected_keys) == 0, print(res.unexpected_keys)
AssertionError: None

Sorry, I am unable to reproduce your issue. Please try updating your code. If your code is already up to date, you might want to try using the code from three months ago. Additionally, you could try running it on a different machine.

https://drive.google.com/drive/folders/1rVWN7z05CHkIwbOJ5Cy3E0seWSpU6SeT
Here are some checkpoints I trained six months ago, you can give them a try.

OK, I'll try it later, it should be a problem on my side. Thank you for your detailed reply.


Shortcut for datafy

Hi,
Would it be possible to create a shortcut for datafy (e.g. SHIFT + ENTER)? Maybe it was discussed before, but I didn't find anywhere.
Thanks

@pfeodrippe that sounds like a good idea to me, mind putting up a PR? It should fit nicely under here.

Done, thanks @djblue o/
I have tested using by using bb dev and then running user.clj, it was a sweet piece of cake! Great work here


Data input widget always open if it's the first input of the page

This is a good fix! Another issue I have noticed is with the Date and time widget. Please have a look at the video that I have attached. I think you can add some similar check which will prevent this from happening. It happens with the drop down too.
https://user-images.githubusercontent.com/48797364/145559102-660a992a-36d7-49f2-9ced-de6b570f59ad.mp4
.
Originally posted by @joiskash in https://github.com/google/android-fhir/pull/957#pullrequestreview-828732707

@joiskash: There is no crash, but the date widget pops up every time the cursor is on the first widget and the page is changed. Its a bug. The date widget should not pop-up unless clicked on.

with the changes being done in the catalog app - to reproduce this we need to change the navigation graph when building the catalog app

@jingtang10 , As mentioned above, after changing navigation graph in the catalog app, I could not find Date and time widget for ANC ID field. Instead of Date and time widget there is TextView and only onclick action it opens Keyboard. Screenshot is attached for more details.

@jingtang10 If this issue is not resolved yet, can you assign me this issue?

Please assign me this issue if this is not resolved.

ah sorry! @PallaviGanorkar
in this case just change the question type in the json file from text to date locally: https://github.com/google/android-fhir/blob/fa51f691cf4c3fecf86f8b7250386112a8e34cc9/catalog/src/main/assets/patient-registration-paginated.json#L30

also related to #1089 - i wonder if it will fix this.

@PallaviGanorkar
Hide the bottom navigation view as well to get the Previous and Next buttons at the bottom to navigate forth and back if you want to use old sdc reference app to reproduce this issue.
activity_main.xml
 <com.google.android.material.bottomnavigation.BottomNavigationView
        android:visibility="gone"
        android:id="@+id/bottom_navigation_view"
        ....

https://user-images.githubusercontent.com/86107848/154636838-01a5c4e0-45b0-4b32-83f9-4f6a612417e9.mov
Or catalog app can also be used to reproduce this issue
layout -> paginated
https://user-images.githubusercontent.com/86107848/154637397-ee6c7480-5fbe-4c31-8244-0332a09122e8.mov

Based on the comments in PR https://github.com/google/android-fhir/pull/1089 and as discussed with @jingtang10   , If date entry format received from questionnaire JSON, then date input widget must show it as helper text otherwise date entry format must be read from device base on locale and show as helper text.

This functionality implemented in https://github.com/google/android-fhir/pull/1275


Refactor: replace the trait bound RaftTypeConfig of LeaderId with NodeId

Changelog
Refactor: replace the trait bound RaftTypeConfig of LeaderId with NodeId
@schreter
What about avoiding using RaftTypeConfig if possible?
For some of the basic type such as LogId and LeaderId, it seems a trait bound NodeId is quite enough:
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq, PartialOrd, Ord, Serialize, Deserialize)]
// Clear the bound so that serde will generate required bounds.
#[serde(bound = "")]
pub struct LeaderId<NID>
where NID: NodeId
{
    pub term: u64,
    pub node_id: NID,
}

It seems working for now,
But I do not know if there are any concerns in the future we will have to use RaftTypeConfig for these basic types.

This change is

Probably the same can be done for MembershipConfig, though not 100% sure, since it might be interesting to parameterize the BTreeSet out (linear search on 3-5 node IDs is typically faster than trying anything more fancy, but this is likely not on hot path).

Maybe we can send a patch to improve the BTreeSet implementation. :)

Maybe we can send a patch to improve the BTreeSet implementation. :)

Hehe :-). I didn't look into the BTreeSet implementation yet. It may be there already, possibly inadvertently (individual nodes are n-ary and when the tree only contains the root and if they are unsorted, then it should effectively do exactly that).

Maybe we can send a patch to improve the BTreeSet implementation. :)

Hehe :-). I didn't look into the BTreeSet implementation yet. It may be there already, possibly inadvertently (individual nodes are n-ary and when the tree only contains the root and if they are unsorted, then it should effectively do exactly that).

Sadly found that the keys in a node are always sorted. :(


[incubator/aws-alb-ingress-controller] add pod security policy and se…

…curity context
Signed-off-by: Shaun Rasmusen<EMAIL_ADDRESS>
Is this a new chart
No.
What this PR does / why we need it:
Adds a Pod Security Policy and related security context to the chart so that it can be deployed in a kubernetes cluster with the PodSecurityPolicy Admission Controller enabled.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

n/a

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @m00nf1sh

/cc M00nF1sh
/cc bigkraig

/cc @M00nF1sh
/cc @bigkraig

/ok-to-test
@ardentras
Don't you think close integration with AWS should notify or merge into AWS' helm repo?
See:
https://github.com/aws/eks-charts


gpushare-device plugin daemonset is not working

Hii There,
I really appreciate your solution on GPU sharing in Kubernetes. I followed all steps to set up this scheduler extender but getting some issue with the GPU share device plugin daemonset it is not working and its desired number is also zero, unable to describe that daemonset and there is no pod created in the backend by daemonset.

Hi @riyasoni5990, do you check your gpu node label, and rbac config for gpushare-device-plugin ?

Is it necessary to use Tesla k80 GPU or I can use the Tesla p100 too?

Is it necessary to use Tesla k80 GPU or I can use the Tesla p100 too?

yes, it can work on p100

are you sure your k8s cluster just have one master node which has gpu device on it?

\
Everything is working fine now(device plugin, scheduler extender) but when I am trying kubectl inspect gpushare command it is showing.
Allocated/Total GPU Memory In Cluster:
0/0 (0%)
I am using :-
GPU - Tesla P100
kubernetes version - v1.21.1
Driver Version - 465.19.01
Please help me to resolve this.

so far, according to your latest screenshots, the deviceplugin has run, but cannot discover any gpu device on testserver02. So,

firstly, pls make sure your gpu node work normally. you can exec nvidia-smi on node to verify.
could you double check your gpu node environment to meet the prerequisites of nvidia docker runtime?
Nvidia-docker version > 2.0 (see how to install and it's prerequisites)
Docker configured with Nvidia as the default runtime.
if all those environment are fine, do you ever successfully run a gpu pod using K8s default scheduler and nvidia's device plugin which allocates gpu device to pod exclusively?

Thank You for your support, everything is working fine now.

Thank You for your support, everything is working fine now.

Good to know.  Gonna close the issue.


Add plugin for SnoopPrecompile.jl

We could set up the package to have code like
module MyPkg

using SnoopPrecompile

# Write your package code here.

@precompile_setup begin
    # Put here any variables that you want to use in `@precompile_all_calls`
    @precompile_all_calls begin
        # Put here all calls that you want to precompile
    end
end

end

c.f. https://github.com/timholy/SnoopCompile.jl/blob/ad792afcb320971231128479cff9baa3bd1245d0/docs/src/snoop_pc.md
Plus with SnoopPrecompile.jl added to the Project.toml.
Potentially such a plugin could allow users to configure some things e.g. compat for SnoopPrecompile.jl.

Now called https://github.com/JuliaLang/PrecompileTools.jl


A11y: Widget with role of listbox must have no more than one tabbable element in DropdownV2 component

===== ENVIRONMENT =====
IBM CI 162 Checkpoint Violation: 2.1.1 Keyboard
IBM Guidance: https://www.ibm.com/able/guidelines/ci162/keyboard.html
Test Tool Type: DAP
===== DEFECT DESCRIPTION =====
The rule detected a WAI-ARIA widget with more than one tab stop.
The primary keyboard navigation convention uses Tab and Shift+Tab key commands to move focus from one UI component to another. Other keys (primarily the arrow keys) move focus within components comprised of multiple focusable elements. Authors must follow this convention and provide no more than one tab stop per “widget” (providing keyboard focus).
WAI-ARIA (ARIA) widgets are custom user interface objects given an explicit ARIA role that matches its intended purpose. These “roles” can be used to build standalone user interface widgets, or they might be used to create individual parts of a composite widget (e.g., role="button", role="checkbox", role="combobox", etc.).
Note: This rule checks for the most common widgets which require a tab stop.
=====STEPS TO REPRODUCE =====

Go to https://cloud.ibm.com/login?redirect=%2F

===== EXPECTED RESULT =====
https://aat.w3ibm.mybluemix.net/token/a80a8d09-7f5a-480a-adcc-7e22f77482b0/c19cc7e4-e2e6-4475-89d7-533c2bc34979/archives/2018OctDeploy//doc/w3/help/en-US/idhi_accessibility_check_g1178.html

Yeah, that component has problems. It's implemented aria wise as a menu which means it should support the full gamut of OS level menu controls, but the menu items should not be tabbable. Tab is reserved for moving between menus.
So there are two ways to address this:

remove the menu items from the tab order silencing the automated testing error
remove the aria-menu attribute and let the drop down act as a list of links with tab stops

The second solution falls more in line with expected user behavior. We've implemented a tab stop keyboard interaction pattern in the experimental UI-Shell's dropdowns and those are so far testing well.

adding more to this -- can't reproduce the error with the DropdownV2. Do you know which version you're using?

@dakahn The carbon-components-react version is 6.58.0

@dakahn I can reproduce the error with the DropdownV2.

@dakahn I tried it and remove tabindex="0" in listbox.js can fix this issue.
But I'm not sure if it will new problem.

Getting back to this -- I am unable to reproduce your DAP error in either your linked app or in our storybook. Do me a solid and click the hamburger in the top right of the DAP panel and tell me what rule sets you're testing against. For reference here's mine:

@dakahn I checked IBM Accessibility BETA in the rulesets.

Yeah, cool -- that's what I thought was up. I've pinged someone who might know about the specific differences in the latest rule set vs the BETA rule set to figure out how to move forward.

I'm going to close this as resolved. The error was from the experimental rule set. Happy to open this up again in the future if we need to. 👍🏽

@dakahn I think this is an issue. We must type tab key twice to focus on the dropdown list. When we focus on the dropdown list first time, we can't operate it. Then type the tab key, We can see the focus is not changed and we can type space to operate the dropdown.
I think it is not correct. The widget should be focus on one time and no more than one tabbable element in it.

@icemanlily can you open a separate issue for that and i'll look into what you're saying. 👍🏽

@dakahn Open the separate issue. #2081


Ist there a possibility to have truncated slider only on the right side like on amazon.com

Like the centered version but only truncated on the right side and justified on the left.

I'm trying to do the same.  So far I found that this approach kinda works:
        $(this).slick({
            slidesToShow: 5.5
        });

For this to work you have to know the width of your slides and the width of your container, to make sure that there's enough room for 5.5 slides to show with padding between them (and no overlap).

One issue I discovered with the "partial slide" solution I proposed earlier is that if you dynamically add new elements to the list using ajax, then after each add-item action, slick will adjust the "scroll position" of the carousel so as to be at the start of a slide.  This makes for a jarring experience -- the slides all suddenly shift to the left by 50%.
This issue is also discussed here: https://github.com/kenwheeler/slick/issues/1299


Inclusion of geoman into the javascript component.

Hi.
Here is a basic pull request that show what I am trying to accomplish.
When I do this, the component is not properly rendered: the tiles are all messed up even if some of them are loaded and displayed properly.
I did manage to build a leaflet + geoman livewire component from scratch without problem. However, I would like to bundle everything into a nice JS asset for Filament to load.
So I am very interested in your advices if you can find why it doesn't work as easily as I was expecting it.
Regards.
Florian.

Hi.
Yes it is the way forward.
I have found another package which does nearly what I expect:
https://github.com/vitormicillo/filament-map-picker
Geoman is included, multiple features editable. It lacks the possibility to load features from the livewire backend which is a must have.
And I think being able to select the features color is a must have too (coule be stored in the properties of each feature).

Hello Everyone,
Thank you all for your feedback and contributions to this feature, as well as for sharing your ideas! I’m excited to let you know that the Geoman feature is now available starting from version 1.4.
If you have any suggestions or encounter any issues, feel free to reach out, or you're always welcome to submit a PR at any time.
Thanks .


Contextual Sentiment Analysis Strategy?

Do we want to analyze the sentiment of each message individually (out of context) or in sets of 3-4 messages (in context)?
ABABA? ABA? Sets of 3/4/5 messages, regardless of who sent them? What if all of the last messages are all sent by one person?
Azure forces sentiment analysis of only one string at a time, so we can't do contextualized sentiment scores unless we join them into one string.
Opinions on what we should do?

http://www.aclweb.org/anthology/W15-1829
This paper seems to have done them all individually so I might do that


Publish openapi to gh pages

PR Description
Add CI step to generate Teku OpenAPI doc and publish it to Github pages.
Fixed Issue(s)
PegaSysEng/Misc#33

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: NicolasMassart:x: benjamincburnsYou have signed the CLA already but the status is still pending? Let us recheck it.