Preview: Prev/Next not tied to label filtering?

Are the Prev/Next buttons fully implemented yet, and should they reflect the label filtered results one day? Would be great to have that, too, cause the sorting order seems already implemented (haven't tested intensely there, though).
v2.2.0 beta2

Could you please provide more info? What I can understand is that you're asking to only open filtered notes in Reading Mode, just like when selecting notes, rather than the whole folder. Is that it?

Yes, exactly :)


Warning from dotnet analyzer even when assemblyEnabled = false

In my build.gradle I'm configuring the dependency-check-gradle plugin to disable the dotnet assembly analyzer:
    dependencyCheck {
        suppressionFile = rootProject.file('suppression.xml')
        analyzers {
            assemblyEnabled = false
        }
        formats = [ "HTML", "XML" ]
    }

Yet I still get this warning:
Checking for updates and analyzing dependencies for vulnerabilities
----------------------------------------------------
.NET Assembly Analyzer could not be initialized and at least one 'exe' or 'dll' was scanned. The 'dotnet' executable could not be found on the path; either disable the Assembly Analyzer or add the path to dotnet core in the configuration
----------------------------------------------------

Sorry for the delayed response - what version of ODC are you using?

Hi! I’m away but will yet you know next week. Thanks!

On 7 Sep 2020, at 13:53, Jeremy Long<EMAIL_ADDRESS>wrote:

Sorry for the delayed response - what version of ODC are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Im getting the same warning, despite having configured the assembly analyzer to be disabled.
Gradle version: 6.8.3
Plugin version: 6.1.3

I'm also getting this warning with 6.2.0 after having configured the assembly analyzer to be disabled:
dependencyCheck {     analyzers.assemblyEnabled = false ... }

A fix will be included in the next release.


Request for New Subdomain "dmzartchive" for Music Portfolio Upgrade

I would like to request the creation of a new subdomain on foo.ng to replace my current music portfolio site. Previously, the site was accessible at https://dmzartchive.illust.bio/.
Details of New Subdomain:
Requested Subdomain Name: dmzartchive
Purpose: Migration of my music portfolio site to WordPress to enhance functionality and content management.
Details of Change:
Previously, my site was hosted at https://dmzartchive.illust.bio/, focusing on music works and artistic portfolio.
With the migration to WordPress, I aim to expand and update content to attract a wider audience and improve site navigation.
Reason for foo.ng Subdomain:
Foo.ng offers a suitable platform for creative and technical projects like my music portfolio site.
This subdomain will provide a clear and easily accessible identity for my upgraded music portfolio.
My Contributions:
I have restructured the site using WordPress, ensuring all music-related content and artistic information are well-documented.
I am prepared to provide additional support and necessary information to facilitate this submission process.
Thank you for considering the creation of a new subdomain for my music portfolio on foo.ng. I greatly appreciate this opportunity and look forward to collaborating to enrich this creative ecosystem.

Your site is now live at dmzartchive.foo.ng!


DRILL-4287: During initial DrillTable creation don't read the metadat…

…a cache file; instead do it during ParquetGroupScan.
Maintain state in FileSelection to keep track of whether certain operations have been done on that selection.
Remove ParquetFileSelection since its only purpose was to carry the metadata cache information which is not needed anymore.
Conflicts:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFileSelection.java
Resolve issues after rebasing:

JsonIgnore fileSelection in ParquetGroupScan
FileSysemPartitionDescriptor change.

Conflicts:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
DRILL-4287: Address code review comments and follow-up changes after rebasing:

In FileSelection: updated call to the Stopwatch, set all flags appropriately in minusDirectories(), modify supportDirPruning()
In ParquetGroupScan: Simplify directory checking in constructor,  set the parquetTableMetadata field after reading metadata cache.
Fix unit tests to use an alias for the reserved dir columns as partition-by columns.

More follow-up changes:

Get rid of fileSelection attribute in ParquetGroupScan
Initialize entries after expanding the selection when metadata cache is used
For non-metadata cache, don't do any expansion in the constructor; let init() handle it
In FileSystemPartitionDescriptor, the createPartitionSublists is modified to check for parquet scan

When reading from metadata cache , ensure selection root does contain the scheme and authority prefix.  Minor refactoring.

I have incorporated the review comments and updated the PR.  Please take a look when you get a chance.

Updated PR after addressing review comment from @jacques-n

Simplified the state management in FileSelection.  @jacques-n is this close enough to what you intended ?  Also, want to note that this JIRA is motivated by a performance enhancement, so I haven't added a new unit test.

Super helpful! I wrote the original class and I was losing track of the state model. Figured that it would be even harder for others to understand the dynamics. This helps a lot. +1


Investigate using inline for generated sources

This has compatibility implications, so we should try and do it before v0.2.0.

While working on https://github.com/armanbilge/calico/pull/151 I realized that @inline is more flexible and has no compatibility constraints, so we can add/remove it freely. So I think we're good actually.


Support ref endpoint name register

The ref exchange is changing since we apply the change in 6.6.0

Since 6.6.0 The endpoint in the ref should be server endpoint only. The agent will/should use -1, when it can't find the endpoint of entry span in the current tracing context when build the ref.
Since 5.0 Endpoint in ref could be local or exit span's operation name. Especially if it is local span operation name, * exchange may not happen at agent, such as Java agent, then put literal endpoint string in the header, Need to try * to get the id by assuming the endpoint name is detected at server, local or client. If agent does the exchange, then always use endpoint id.

Codecov Report

Merging #4422 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4422      +/-   ##
==========================================
+ Coverage   25.42%   25.43%   +<.01%
==========================================
  Files        1211     1211
  Lines       28083    28078       -5
  Branches     3869     3867       -2
==========================================
+ Hits         7140     7141       +1
+ Misses      20292    20286       -6
  Partials      651      651

Impacted Files
Coverage Δ

...re/register/service/EndpointInventoryRegister.java
0% <0%> (ø)
:arrow_up:

...r/parser/standardization/ReferenceIdExchanger.java
0% <0%> (ø)
:arrow_up:

...king/apm/agent/core/remote/GRPCChannelManager.java
69.23% <0%> (+1.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28c7d7...56ae26a. Read the comment docs.


ArgumentMatchers make it impossible to have lets with same name

As a result of the methods defined in RSpec::Mocks::ArgumentMatchers, it is impossible to have a let() with certain names. The most potentially devastating of which is boolean. As anytime boolean is referenced within the test, the method in RSpec::Mocks::ArgumentMatchers is called, rather than referencing the let that was created. This can be seen by running the example tests below. This has all sorts of horrific ramifications, including false-passing tests and utter confusion, as it is non-obvious until you inspect the object itself that it is not the value you assigned it to.
I'm not sure what the "right" way to fix this is, or if it can be properly fixed, but at the least RSpec should raise an exception when "illegal" names are passed to let, so the unexpected behavior is at least explicitly denied by RSpec.
class Example
  def self.test(boolean)
    boolean
  end
end

shared_examples "example" do
  context "and it is true" do
    let(:value) { true }
    it { should be_true }
    it { subject.class.should == TrueClass }
  end

  context "and it is false" do
    let(:value) { false }
    it { should be_false }
    it { subject.class.should == FalseClass }
  end

  context "and it is not defined" do
    it "raises a NameError" do
      expect { subject }.to raise_error(NameError)
    end
  end
end

describe Example do
  describe "#test" do
    # Passes for "bool" & "some_valid_name", fails for all others
    %w[bool some_valid_name boolean any_args anything no_args duck_type hash_including].each do |name|
      context "when variable is named #{name}" do
        subject { Example.test(send(name.to_sym)) }
        let(name.to_sym) { value }
        include_examples "example"
      end
    end
  end
end

The failure message is plenty good enough to tell you what's going on:

Example#test when variable is named no_args and it is false
Failure/Error: it { subject.class.should == FalseClass }
expected: FalseClass
got: RSpec::Mocks::ArgumentMatchers::NoArgsMatcher (using ==)
Diff:
@@ -1,2 +1,2 @@
-FalseClass
+RSpec::Mocks::ArgumentMatchers::NoArgsMatcher

Whether it is Ruby, Rails, or RSpec, if you suspect a method name is too vague or general, it's always a good idea to check the applicable API's before hand. Or, you can always be more verbose in your naming. boolean is too terse for application code, IMO.
Bottom line, executing a "check" for every let is not worth the effort nor complexity. It is a rabbit hole.

I disagree. I don't think I've ever seen anyone explicitly check that the class of a boolean is indeed FalseClass. The only reason that test exists in my example is to illustrate what is happening.
A check isn't necessary, I was just suggesting it as a possible solution. The real issue, as I see it, is that the let's scope is overridden by an API method, despite it being closer to the actual test, which is completely unexpected.

I'll fix it this weekend since I completely overlooked the problem.

It's not like a punishment system :)
But that would be great.

@justinko neither option is acceptable to me. I'd rather suffer the mess of treating stub differently from other methods than deprecate either one.

@dchelimsky well we can at least move the arg matchers out of the metaclass:
Remove this and somehow inject it into the host class.

I haven't looked into this yet, but it strikes me that the root cause is that arg matchers get added after the methods defined by let, thus overriding them, in which case the solution would be to make sure that the methods declared by let are actually defined later. That make any sense to you?

Given that rspec-mocks needs to run standalone, and that we cannot call RSpec::Core::ExampleGroup directly in rspec-mocks, this is the best that I could come up with: http://pastie.org/3377917
WDYT?

@justinko how about including it in ExampleGroup from the adapter?

@dchelimsky I thought of that, but we still need to get those methods in rspec-mocks when used stand-alone.

@justinko on ExampleGroup, not Object

By adapter, I'm assuming you mean RSpec::Mocks.setup? This would mean checking for ExampleGroup:
if defined?(RSpec::Core::ExampleGroup)
  RSpec::Core::ExampleGroup.send :include, RSpec::Mocks::ArgumentMatchers
end

Obviously, this still wouldn't solve the problem of making arg matchers available in rspec-mocks stand-alone.
If you do mean the adapter from rspec-core, yes, that would fix it in rspec-core, but not when rspec-mocks is used stand-alone.

@justinko RSpec::Mocks::Methods are methods like stub and should_receive that belong on objects. What gets added to ExampleGroup is RSpec::Mocks::ExampleMethods (see https://github.com/rspec/rspec-mocks/blob/master/lib/rspec/mocks.rb#L12-14). How about we add include RSpec::Mocks::ArgumentMatchers to that block?

RSpec::Mocks::ArgumentMatchers is currently included in RSpec::Mocks::ExampleMethods, so that won't change anything.
The objective is to get arg matchers out of the "host" metaclass, and onto the same scope as let (which is in the example group instance, not example group instance metaclass).

@dchelimsky I actually tried that, and it didn't work with the spec given in this issue. However, I just tried it with a much more simple spec and it does work! Now I'm trying to get the example spec to pass...

@dchelimsky okay, so your solution does work, but not with example groups that don't contain an example:
# fails
describe do
  let(:boolean) { true }
  describe do
    specify { boolean.class.should eq(TrueClass) }
  end
end

# passes
describe do
  let(:boolean) { true }
  specify { boolean.class.should eq(TrueClass) }
end

This is because the "host" that gets passed to RSpec::Mocks.setup is an instance of RSpec::Core::ExampleGroup::Nested_1::Nested_1. So as you can see, RSpec::Core::ExampleGroup::Nested_1 does not get the inclusion.
I'm not quite sure how to solve this. Maybe we could traverse up each example group subclass (via split('::') and const_get) and include the methods? This would happen on every example run, but we would obviously check to see if the methods have been included or not (via your < approach).

By one-time addition, I meant to ExampleGroup (even though my example didn't show that). We should be able to extend ExampleGroup (or TestCase in the case of t/u or minitest) with the methods we want. Then the subs inherit them.

I haven't figured it out yet, but Object#stub always wins, even when doing this:
RSpec::Core::ExampleGroup.send :include, RSpec::Mocks::ExampleMethods
Object.class_eval { include RSpec::Mocks::Methods }
RSpec::Core::ExampleGroup.send :include, RSpec::Mocks::ExampleMethods


[Bug]: MSVC 2019 build fails with low_level_alloc.cc(331): error C2589: '(': illegal token on right side of '::'

Describe the issue
I'm building gRPC python wheels with MSVC 2019, build fails.
See the original issue https://github.com/grpc/grpc/issues/32779
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\bin\HostX86\x64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -DWIN32_LEAN_AND_MEAN=1 -DMS_WIN64=1 -I. -Igrpc_root -Igrpc_root\include -Ithird_party\abseil-cpp -Ithird_party\protobuf\src -Ithird_party\utf8_range -IC:\Python37\include -IC:\Python37\include "-IC:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\shared" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\winrt" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\cppwinrt" /EHsc /Tpthird_party\abseil-cpp\absl\base\internal\low_level_alloc.cc /Fobuild\temp.win-amd64-3.7\Release\third_party\abseil-cpp\absl\base\internal\low_level_alloc.obj -std=c++14 /MT

cl : Command line warning D9025 : overriding '/MD' with '/MT'

cl : Command line warning D9002 : ignoring unknown option '-std=c++14'

low_level_alloc.cc

third_party\abseil-cpp\absl\base\internal\low_level_alloc.cc(331): error C2589: '(': illegal token on right side of '::'

third_party\abseil-cpp\absl\base\internal\low_level_alloc.cc(331): error C2062: type 'unknown-type' unexpected

third_party\abseil-cpp\absl\base\internal\low_level_alloc.cc(331): error C2059: syntax error: ')'

C:\Python37\lib\site-packages\Cython\Compiler\Main.py:369: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: T:\altsrc\github\grpc\workspace_python_windows_x86_Python37_32bit\tools\distrib\python\grpcio_tools\grpc_tools\_protoc_compiler.pyx

  tree = Parsing.p_module(s, pxd, full_module_name)

error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX86\\x64\\cl.exe' failed with exit status 2

Steps to reproduce the problem
attempt grpc python artifact builds on windows.
What version of Abseil are you using?
20230125.2
What operating system and version are you using?
Windows 2019 Server
What compiler and version are you using?
MSVC 2019
What build system are you using?
python wheel build (with native extension)
Additional context
No response

The problem seems similar to https://github.com/abseil/abseil-cpp/pull/55 (which is very old, so perhaps a regression?)

We use (std::min)(a, b) in headers to guard against this problem because Windows has macros named min and max. If you are using one our suppored build systems, build rules should have /DNOMINMAX.
Is this a custom build, and if so, is /DNOMINMAX missing?
See also: https://github.com/abseil/abseil-cpp/discussions/1271

https://github.com/grpc/grpc/pull/32803 will fix this.


Add full list of coin types

As of v0.2.0 it isn't possible to manually change the "Coin" field in the BIP44 derivation path, but the dropdown of available coin types contains only a small subset of those defined in SLIP-0044. Most notably, Bitcoin Cash (145) isn't present although it is currently useful for people who are splitting that currency away from their Bitcoin addresses.
Please could you add Bitcoin Cash (145),  and ideally all the types defined in SLIP-0044 if possible.

Thanks for this. You make a good point.
The difficulty with adding all SLIP-0044 coins is they need to have their network parameters defined to work with this tool, not just the BIP44 coin field (see bitcoinjs-extensions.js). I'm not sure where to get these parameters for most coins (although for bitcoin cash this is obviously not a problem).
I see two reasonable courses of action:

remove readonly from the coin field
add bitcoin cash to the list of coins and keep coin field readonly

I'm leaning toward the second option. Modifying the coin field value isn't really something that should be done, and if that degree of customisation is desired by end users they should use the bip32 tab with a manually configured derivation path.

Bitcoin Cash has been added, see https://github.com/iancoleman/bip39/commit/daab55dc613a1eef22463356eba1a742cb814cb2
I'm inclined to keep the coin field readonly, since there's always the bip32 tab with manual derivation path for advanced users.
Thanks for the suggestion.


Valentines Day Special Event

Requested Feature (Write the feature you want under this):
Special event day for Valentines day.
Reason for Feature (Write the reason for your new feature here):
Valentines day is on February 14 (Monday) and a lot of people will have events that day.
Additional Notes (Any additional notes about your request):

Could include new PFP for one day only.
Also may include more responses (as much as Jan. update/v1.2 included)

Additional context
Will be released on Feb. 14 if all goes well. A poll will be held on if this is a wanted update.

Created poll in discord, ending poll in 48 hours.

The poll is currently leaning towards the update going through. A new issue will be raised once the poll finishes providing it stays positive toward the update.

Closing issue to add new one with more information.


Support for JsonIgnore attribute  when using CosmosDB with Microsoft.EntityFrameworkCore.Cosmos v6

When using
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
  [JsonPropertyName("age")]
  public int? Age { get; set; }

This still will create  null when saving data in Cosmos Db
{
"age" : null
}

or is there anyway to prevent this ?
This issue tracker is for documentation
For product issues, use https://github.com/aspnet/EntityFramework/issues

@aligunel JsonIgnore is an attribute used by the JSon serializer; it does not change the EF model. NotMapped can be used to exclude a property from the EF model.

@aligunel JsonIgnore is an attribute used by the JSon serializer; it does not change the EF model. NotMapped can be used to exclude a property from the EF model.
Problem is I want "age" in the cosmos db document if value only exists.  [Notmapped] attribute will ignore it even there is a data for the field.

@aligunel I don't think that is supported.

I think EF COre 6 for Cosmos db is very immature. No support for JsonSerialization options. I need to define ToJsonProperty() for each property. It is not easy to integrate to existing cosmos db.


restic has very high memory usage

Output of restic version
restic 0.9.5 compiled with go1.11.5 on linux/amd64
How did you run restic exactly?
/usr/bin/restic --quiet --repo b2:<repo> <backupdir>
With $RESTIC_PASSWORD, $B2_ACCOUNT_ID and $B2_ACCOUNT_KEY set. The backup directory is about 1.4 TB.
Same issue seen trying to do restore using similar conditions.
What backend/server/service did you use to store the repository?
Backblaze.
Expected behavior
restic completes the task with modest memory usage.
Actual behavior
restic baloons to 10+ GB memory usage. On one machine the OOM killer nuked it because of this.
Steps to reproduce the behavior
Seems to happen every run.
Do you have any idea what may have caused this?
Not really. Large backup directory?
Do you have an idea how to solve the issue?
Nope.
Did restic help you today? Did it make you happy in any way?
In general restic does what it is supposed to do. It does seem to have some scaling issues though, like this memory usage.

High memory usage with a lot of files is a know issue (#1988). Running export GOGC=20 before your backup might help.

As @dimejo writes, this is known since before. For that reason I'll close this issue. Feel free to add further comments, and don't hesitate to let us know if you managed to ease the situation with that GOGC=20 environment!


API.get on vanilla create-react-app throws error

I have configured a vanilla create-react-app project and configured it to use the restaurants demo from mobile hub.
The user registration and login works as expected with Cognito, but the following error is thrown when I try to use the API component
TypeError: __WEBPACK_IMPORTED_MODULE_1_aws_amplify___default.a.get is not a function
const apiName = 'ReactSample';
const path = '/items/restaurants';
API.get(apiName, path).then(response => {
    console.log(response);
});

create-react-app: 1.0.17
node: 9.3.0
Is create-react-app meant to be supported?
Or is there something that I might have missed?


Specify aliases in one place, and make it more uniform which are defined

Fixes #301.
This expands the type aliases to cover all sizes from 1 to 64 elements, to keep it easy to audit.

Knit: based on what is being aliased
https://rust-lang.github.io/portable-simd/core_simd/struct.Simd.html
Change:
            pub type $alias = $crate::simd::Simd<$element, $elements>;
To:
            pub type $alias = $crate::simd::Simd<$simd_element, $lanes>;
I must admit that what you've done matches the current alias description better, but reading $element next to $elements confused this reader at the first.
May just be my issue. Thanks again!

Good point, made the names something a little easier to distinguish.


Add link to climate change refugee crysis

Link URL

https://www.theguardian.com/environment/2017/nov/02/climate-change-will-create-worlds-biggest-refugee-crisis
Description

Add link to climate change refugee crysis
Why it should be included to Sustainable-Earth (optional)
Checklist

[x] Only one item/change is in this pull request
[x] Addition in chronological order (bottom of category) or sorted by most recent date (for articles)
[x] It's in English

          1 Warning

:warning:
Found 1 link issue, a project collaborator will take care of these, thanks :)

Link issue by awesome_bot

Line
Status
Link

47
403
https://news.ycombinator.com/item?id=15148860

  Generated by :no_entry_sign: Danger


New CiteSeq Tool Tutorial--DRAFT-WIP

These are the beginnings of a tutorial which will use the recently added CITE-Seq capabilities on the Seurat tool. The tutorial plan is to move into RStudio and highlight some of Seurat's functionality when it comes to exploring and visualizing multimodal data!

An answer key history & workflow will be critical to add to this


Wrong star rating.

<StarRatingComponent
                        name="app5"
                        starColor="#ffb400"
                        emptyStarColor="#ffb400"
                        value={3.7}
                        renderStarIcon={(index, value) => {
                            return <span className={index <= value ? 'fa fa-star' : 'fa fa-star-o'} />;
                        }}
                        renderStarIconHalf={() => }
                    />

when rating is 3.7  or 3.2 it will mark 2.5 stars.  but if the value is 3.5 exactly it works as expected.

I am experiencing this issue with any half star rating. 3.7//3.5/ only render 2.5 stars. I have looked into it and it is skipping the 3 index and simply goes 5,4,2,1, hence only 2 full stars are rendered instead of 3. Any updates?

I think this is directly related to #28. The current published build that has outdated code. The current build calls Math.ceil(value), but the source code says Math.floor(value). If the source code was compiled and published, this issue would likely resolve itself.

Same experience, I have a rating of 4.5 but it will actually render 3.5 stars

Thanks @js62789 When I upgraded to latest version, it renders correct star.  But I get a react error in production, when I load the page on server side after this upgrade.
{ [Invariant Violation: Minified React error #109; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=109&args[]=StarRatingComponent for the full message or use the non-minified dev environment for full errors and additional helpful warnings.] name: 'Invariant Violation', framesToPop: 1 }
a
any idea ?

@annaarun123 I don't know a lot about this project. I just happened to stumble upon the half-star bug while using the component. That being said, the link you provided says
StarRatingComponent.render(): A valid React element (or null) must be returned. You may have returned undefined, an array or some other invalid object.

I recommend you submit a new issue if this is an issue with the package so that your issue gets more visibility.


Action does not work on pull_request or pull_request_traget

Hello,
I am trying to add the action to run on PR but it only fails for me with cannot force update the branch '<BRANCH_NAME>' used by worktree.
I tried to do all the the suggestions under limitations but changing permissions,  giving token with all permissions, changing to pull_request_target, nothing worked for me, all got the same error as before.
The actions is working on push but I need it to work on PRs.
The current workflow:
name: Build-Dev

env:
  BUILD_MODE: dev
  NODE_VERSION: "18"
  NODE_ENV: generic

on:
  pull_request:
    branches:
      - "**"
    paths:
      - "**"
      - "!.github/**"
      - "!.gitignore"
      - "!README.md"
  push:
    tags:
      - "**-v[0-9].[0-9]+.[0-9]+-dev[0-9]+"

permissions:
  checks: write
  contents: write
  pull-requests: write

jobs:
  build-dev:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout branch
        uses: actions/checkout@v4
        with:
          ref: ${{ github.head_ref || github.ref_name }}
          token: ${{ secrets.GH_TOKEN }}
          fetch-depth: 0
          persist-credentials: false

      - name: Setup Node.js
        uses: actions/setup-node@v4
        with:
          node-version: ${{ env.NODE_VERSION }}

      - name: Setup npm cache
        uses: actions/cache@v4
        with:
          path: |
            ~/.npm
            node_modules
          key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-${{ hashFiles('**/package-lock.json') }}
          restore-keys: |
            ${{ runner.os }}-node-${{ env.NODE_VERSION }}

      - name: Install dependencies
        run: npm ci

      - name: Save node_modules cache
        uses: actions/cache@v4
        with:
          path: node_modules
          key: ${{ runner.os }}-node-modules-${{ hashFiles('**/package-lock.json') }}
          restore-keys: |
            ${{ runner.os }}-node-modules

##############################
##############################

      - name: Run linters
        uses<EMAIL_ADDRESS>        with:
          eslint: true
          prettier: true

##############################
##############################

      - name: Run npm tests
        run: npm test

      - name: Build project
        run: npm run build

      - name: Upload build artifacts
        uses: actions/upload-artifact@v4
        with:
          name: node-build
          path: build/*

  trigger-deploy:
    runs-on: ubuntu-latest
    if: startsWith(github.ref, 'refs/tags/')
    needs: build-dev
    steps:
      - name: Repository Dispatch
        uses: peter-evans/repository-dispatch@v3
        with:
          token: ${{ secrets.GH_TOKEN }}
          repository: ${{ github.repository }}
          event-type: trigger-deploy-dev
          client-payload: '{"ref": "${{ github.ref }}", "sha": "${{ github.sha }}", "ref_name": "${{ github.ref_name }}", "run_id": "${{ github.run_id }}"}'

Hey @alonapester ,
You can use  ref: ${{ github.event.pull_request.head.sha }}.


Implement PrettyDistanceConverter & PrettyDateConverter for WinUI

Expected Behavior
The WinUI version of the package should have the auto-generated converters PrettyDistanceConverter and PrettyDateConverter.
Actual Behavior
The WinUI project doesn't have the auto-generated PrettyDistanceConverter and PrettyDateConverter that are present in the Uno project at the moment.
Suggestion(s)

The auto-generation seems to have an issue when those converters are in a shared project, I would suggest keeping them in each project separately.

Specifications

Version: 0.4.0-feature.dotnet6.51
Platform: net6.0-windows10.0.18362, net-6.0-android, net-6.0-ios, net6.0-macos, net6.0-maccatalyst and netstandard2.0
Subsystem:

https://dev.azure.com/nventive/Practice committees/_boards/board/t/Mobile (.Net)/Features/?workitem=267862

@GabrielChouinardLetourneau What do you mean by auto-generated?

@jeanplevesque After verifications, I understand what I meant by that. Both of those converters have auto-generated files Designer files that are generated in the Resources folders of those converters. If I remember correctly, if those converters were generated in the Shared project, the file was throwing errors with the net6 targets. Here's an exemple of the generated file:

On the distance is remaining, date has been done recently.


Unable to add numeric types that are not simply 'number'

I'm trying to rewrite the signature of sum from core.ts in our compiler (see #16823), but I'm getting this error:
export function sum<T extends Record<K, number>, K extends string>(array: T[], prop: K): number {
    let result = 0;
    for (const v of array) {
        result += v[prop];
     // ~~~~~~~~~~~~~~~~~
     // Operator '+=' cannot be applied to types 'number' and 'T[K]'.
    }
    return result;
}

Note that I can't declare sum as
export function sum<K extends string>(array: Record<K, number>[], prop: K): number

because then TypeScript would infer all of the properties in each element for K. So I do need another type argument T for the indirection.
For a simpler repro:
function foo<T extends number>(x: T) {
    return 0 + x;
    //     ~~~~~
    // Operator '+' cannot be applied to types '0' and 'T'.

}

Related is #15645.

Related:  #15501

Fix is up at #17870

Note that #17404 fixed the simpler repro; #17870 fixes the original issue with a type parameter indexed by another type parameter.

The previous PR got merged by mistake and is now reverted; #17912 is the PR with the fix now.


Comment out dynamic slice tests that rely on wrapping

This PR is to comment out dynamic slice tests that rely on wrapping.
The wrapping behaviour has not yet been specified so it can't be tested. See https://groups.google.com/forum/#!topic/xla-dev/XQ7LbZOg9Nc
This PR is a continuous work of PR #14153.

Nagging Assignee @andrewharp: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 45 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Sorry, this PR dropped off my radar. But it's now obsolete — we never wrap any more; instead, we clamp. The behavior is still implementation-defined, but we are thinking about just defining it...


Create a docker compose file for demo setup

Should use a specific version of jenkins4casc and docker version 3.3 so we can use docker secrets.
It should reference docker secrets we create manually on the EC2 instance docker host.
It should reference a jenkins.yml in this repository, using an environment variable and point to the raw content of the jenkins.yml

Related to https://github.com/Praqma/praqma-jenkins-casc/issues/8

We won't need history, nor backup, as it is only a demo instance and new builds will come again when there is activity in projects. Else we simple run some.

Basic setup working in docker compose with secrets and master.

You mentioned a bug in docker compose, leading to this change in CasC https://github.com/jenkinsci/configuration-as-code-plugin/commit/c83470c3b842358bbbbbb3f6af996dfa278953af
Can you please check the file outside and inside the container using cat -A https://linuxaria.com/pills/linux-terminal-seeing-the-unseen-characters-with-cat to verify it is a bug in docker-compose?
No matter what we can not commit to CASC project without an issue or PR... so please revert that commit and create a proper issues describing the problem there - if the problem really is with CasC and not docker compose.
FYI @ewelinawilkosz

md5sum could also be used to verify the files are identical ?

cat with the -A switch inside container:
jenkins@5e53860188b8:/$ cat -A /run/secrets/adminpw
secr3t$

mads@mads-UX302LG:/var/deploy/secrets$ cat -A /var/deploy/secrets/adminpw
secr3t$

cat with the -A from host file system:

CAT(1)                                                                                User Commands                                                                                CAT(1)

NAME
       cat - concatenate files and print on the standard output

SYNOPSIS
       cat [OPTION]... [FILE]...

DESCRIPTION
       Concatenate FILE(s) to standard output.

       With no FILE, or when FILE is -, read standard input.

       -A, --show-all
              equivalent to -vET

       -b, --number-nonblank
              number nonempty output lines, overrides -n

       -e     equivalent to -vE

       -E, --show-ends
              display $ at end of each line

       -n, --number
              number all output lines

       -s, --squeeze-blank
              suppress repeated empty output lines

       -t     equivalent to -vT

       -T, --show-tabs
              display TAB characters as ^I

       -u     (ignored)

       -v, --show-nonprinting
              use ^ and M- notation, except for LFD and TAB

       --help display this help and exit

       --version
              output version information and exit

mads@mads-UX302LG:/var/deploy/secrets$ cat /var/deploy/secrets/adminpw
secr3t

jenkins@5e53860188b8:/$ cat /run/secrets/adminpw
secr3t

So with the above I would conclude docker compose work correctly and as expected - it do not change the file passed in through secrets.
The problem must be they way we read it in CasC https://github.com/jenkinsci/configuration-as-code-plugin/blob/master/src/main/java/org/jenkinsci/plugins/casc/DockerSecretSource.java#L21


Tried to register two views with the same name RNSVGPath

As you can see in the screenshot, I get the issue when I tried use 2 libraries that use react-native-svg as dependency. I'm using RN 0.52 and RN-svg 6.0.1-rc.2

this happens when another lib has this package as a dependency, we can close this

Alright, I'll go ahead and close this.

Hi there,
I get this error but i only have react-native-svg included once.
There is no other library that requires it in my project but i still get this error.
Any clues?

Expo also has the react-native-svg, so I remove the react-native-svg when using Expo, the error is gone

Same issue
react-native-cli: 2.0.1
react-native: 0.55.4
npm list react-native react-native-svg :

+1

If you're using yarn, then you can use resolutions: https://yarnpkg.com/en/docs/package-json#toc-resolutions
E.g. if you're using react-native-svg v8.0.8 and want to override it in all your dependencies, add this to your package.json file and run yarn again:
  "resolutions": {
    "react-native-svg": "8.0.8"
  }

Or, if you're using npm, then you can run: https://www.npmjs.com/package/npm-force-resolutions#how-to-use
rm -r node_modules
npx npm-force-resolutions
npm install

I got it to work by installing react-native-svg then going into /node_modules/expo/node_modules and renaming/deleting react-native-svg in there.
Probably a better way but it worked.

This seems to be a new issue in Expo 31? None of the fixes in this thread worked for me

I have a similar issue here. Expo 32, as soon as it renders the component, expo crashes.

@abduraufsherkulov if you use expo, then this library comes built it and you shouldn't add it as a dependency, also make sure none of your other dependencies depend on it. Or, eject the project.

I'm not sure if I set my package.json wrong somehow, but after upgrading to Expo 31 I had to change all imports of react-native-svg in a package I depend on to import from Expo instead.
https://github.com/vjsingh/react-native-svg-charts/commit/298f3718b147358a68f07a1104d657ab1540bf86

That sounds correct, Expo should probably change their setup, such that they also expose the react-native-svg module.

You can find examples of ejecting from expo: https://github.com/msand/InfiniDrawExpo
to ExpoKit: https://github.com/msand/InfiniDrawExpo/tree/expokiteject
or to plain react-native: https://github.com/msand/InfiniDrawExpo/tree/nativeeject
And the original project which has both web (using react-native-web) and plain react-native here: https://github.com/msand/InfiniDraw/

I've tried removing the react-native-svg dependency and updated my imports to use expo instead but when I run my app I get a: "React.isMemo is not a function. (In 'React.isMemo(component)', 'React.isMemo' is undefined)"
Has anyone else experienced this or no what is wrong?

Are you using react-redux or react-is? Perhaps this thread can help you: https://github.com/zeit/next.js/issues/6117

Using react-redux. Tried the approach of pinning my version to 4.4.9 from 5.1.0 which it was initially. However, I'm met with other issues so don't really think that would be a feasible approach for me..

i am still facing the same issue

 npmPackages:
      react: 16.8.6 => 16.8.6
      react-native: ^0.59.5 => 0.59.8
    npmGlobalPackages:
      react-native-cli: 2.0.1
      react-native-git-upgrade: 0.2.7
      react-native-shimmer: 0.5.0
      react-native: 0.59.8

still facing same issue.. tried npm-force-resolutions but no results.

My case,
If I remove react-native-svg, I got an error complaining there is no react-native-svg,
If I include I got 'register two views with the same name RNSVGPath' error.
npm-force-resolutions doesn't help.

I'm facing this issue as well
[fatal][tid:com.facebook.react.ExceptionsManagerQueue] Unhandled JS Exception: Tried to register two views with the same name RNSVGPath
I'm using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>I'm not using Expo, and the @msand solution doesn't work for me.
Please reopen this issue

Can you make a minimal reproduction first?

@astw I am facing the same issue. Have you figured it out yet?

@Jimexa I went through every file in react-native-svg-charts and changed import Svg {Line, etc,etc} from 'react-native-svg' to import Svg {Line, etc, etc} from 'expo' and that works for now.

@dragslag You may want to look into Victory charts. I used react-native-svg-charts for a while, and it's a great library but not actively maintained anymore. The switch didn't take too long

Thanks @vjsingh I'll check it out

What should you do if you want to use react-native-qrcode-svg in Expo?

How I fixed this:

Make sure react-native-svg is not in package.json
Delete package-lock.json
Delete node_modules
Run npm install

expo-install react-native-svg caused this issue for me since it appears to install the wrong version. This fixed it:
rm -rf node_modules
npm i<EMAIL_ADDRESS>npm i
expo start -c

Answer from StackOverflow

I was able to solve this issue by installing the appropriate version using:
expo install react-native-svg

My case,
If I remove react-native-svg, I got an error complaining there is no react-native-svg,
If I include I got 'register two views with the same name RNSVGPath' error.
npm-force-resolutions doesn't help.

I have exactly the same situation. Did you manage to solve it?

My case,
If I remove react-native-svg, I got an error complaining there is no react-native-svg,
If I include I got 'register two views with the same name RNSVGPath' error.
npm-force-resolutions doesn't help.

I have exactly the same situation. Did you manage to solve it?

@Egizas, try installing using expo install react-native-svg and then reference it as seen here

This issue is back in 1.6.5
"dependencies": {
    ...
    "react-native-svg": "9.6.4",
    ...
  },

I have a similar issue.
if i remove it from package.json the app will complain it doesn't exist
if i add it, i get the duplication error
$ yarn why react-native-svg
yarn why v1.22.19
warning ../../../../package.json: No license field
[1/4] 🤔  Why do we have the module "react-native-svg"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Has been hoisted to "react-native-svg"
info This module exists because it's specified in "dependencies".
info Disk size without dependencies: "18.59MB"
info Disk size with unique dependencies: "20.15MB"
info Disk size with transitive dependencies: "22.29MB"
info Number of shared dependencies: 3
=> Found "<EMAIL_ADDRESS>info This module exists because "@walletconnect#react-native-dapp" depends on it.
info Disk size without dependencies: "1.54MB"
info Disk size with unique dependencies: "1.54MB"
info Disk size with transitive dependencies: "1.54MB"
info Number of shared dependencies: 0
✨  Done in 0.34s.

so there are two versions, the peer dep of another package is using an older version.
if i install that version at the top level it now works:
yarn add<EMAIL_ADDRESS>✅  ok from then

moving react-native-svg towards the peerDependencies solved this problem for me.
"peerDependencies": {
"react-native-svg": "13.8.0"
},

this issue is basically due to the different react-native-svg dependencies. for example I was using a package react-native-cool-speedometer it was using a different version  12.x.x and I was using 13.5.0 after upgrading the react-native-coolspeedometer it was going

I had the same issue.
I had to uninstall the react-native-svg package using the npm command
but at the same time, it caused another issue, which is
"Invariant Violation: requireNativeComponent: "RNSVGPath" was not found in the UIManager."
then I did an expo install react-native-svg instead of npm install react-native-svg
Which fixes the issue

Make sure you set the width and height for the svg icon
I had the same issue and it helps me :)


Allow websockets to be used with logging wrapper.

Websocket libraries need the responseWriter to also implement http.Hijacker in order to be able to upgrade the request into a websocket. Currently, the wrapped response in logging doesn't implement it, even if the underlying response does.
Doing something like this is necessary in order to be able to use logging with websockets. I'm not totally happy with this solution, because you lose a bit of typesafety. Whatever calls Hijack() is thinks that the response actually does implement it, and then it just panics instead. Ideally, the caller should be able to use the x, ok := r.(http.Hijacker) idiom to figure out of the underlying response can support Hijack, but I'm not sure if there's any way of doing this.

The example for http.Hijacker returns an error instead of panicking. I’d prefer that.

Yeah, actually, that makes a lot more sense. Done.

Wait, actually, I think I may have misunderstood your comment. Do you mean actually replying to the client with http 500, or returning an error from Hijack()?

I could see either, but you’re right that it’d be more diplomatic to return an error from Hijack. Let’s go with that.

OK. Is this ready to merge in then?

Yes, sorry—I missed the fact that you’d added a commit.


Option to set max download speed

Hi,
It would be very nice if there was an option that would allow us to limit the speed of a download.

Its not possible, because the server would keep pushing the data and if not used it would keep on filling the buffer untill the overflows.

Ah, that is a shame. As it is a requirement from my client, I will have to use another module.


Organise non-state event schemas in a separate section or index type to corresponding section

MSC https://github.com/matrix-org/matrix-doc/pull/3368 triggered me thinking about this, there's a lot of message event schemas scattered all over the spec in different areas, while i think it'd help if either;

an index for it existed (m.room.message -> link)
a full section is dedicated to all message schemas alone, and the rest of the spec links to it instead.

This is mainly to make the spec more friendly to traverse, and to easily list all "official" event formats side-by-side.
This is specifically for non-state events at the moment, I think state events are still important in their context, but maybe a simple index would be helpful for that as well.

I think this is a subset of https://github.com/matrix-org/matrix-doc/issues/3404.


Validate catlet and fodder genes during packing

I have updated the validation in Eryph.ConfigModel and bumped the package references.


update links - develop workflow

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


aeson-pretty 0.8.0

Ping @myfreeweb
Building gitson-0.5.1...
Preprocessing library gitson-0.5.1...
[1 of 3] Compiling Gitson.Json      ( library/Gitson/Json.hs, dist/build/Gitson/Json.o )

library/Gitson/Json.hs:13:48: error:
    • Could not deduce (Num Indent) arising from the literal ‘2’
      from the context: ToJSON a
        bound by the type signature for:
                   encode :: ToJSON a => a -> ByteString
        at library/Gitson/Json.hs:12:1-37
    • In the ‘confIndent’ field of a record
      In the second argument of ‘($)’, namely
        ‘Config {confIndent = 2, confCompare = compare}’
      In the expression:
        encodePretty' $ Config {confIndent = 2, confCompare = compare}

Ping @jdreaver
Preprocessing library stratosphere-<IP_ADDRESS>...
[78 of 79] Compiling Stratosphere.Template ( library/Stratosphere/Template.hs, dist/build/Stratosphere/Template.o )

library/Stratosphere/Template.hs:104:57: error:
    • No instance for (Num Indent) arising from the literal ‘2’
    • In the ‘confIndent’ field of a record
      In the first argument of ‘encodePretty'’, namely
        ‘defConfig {confIndent = 2, confCompare = comp}’
      In the expression:
        encodePretty' (defConfig {confIndent = 2, confCompare = comp})

What's the procedure here? Do I just update the snapshot, fix this in stratosphere, and then make a new release?

@jdreaver the new aeson-pretty version won't be in nightly yet because of these failures. You can reproduce with e.g. stack update && stack build --resolver nightly aeson-pretty-0.8.0 stratosphere. And then you can fix and make a new release, or let the aeson-pretty maintainer know if it's something you think should be fixed in that library.

Ah gotcha. I've fixed the issue and I'll upload a new version once my CI passes.

Alrighty, stratosphere version 0.1.3 (the new latest version) should work with aeson-pretty-0.8 now.
By the way, thanks so much for your work on stackage!

@myfreeweb any update on getting gitson to work with aeson-pretty-0.8.0?

Oh. You fixed stratosphere. I thought you reverted the change in aeson-pretty :D
Just released gitson-0.5.2.

Haha, thanks for the update!
On Jul 21, 2016 12:06, "Greg"<EMAIL_ADDRESS>wrote:

Oh. You fixed stratosphere. I thought you reverted the change in
aeson-pretty :D
Just released gitson-0.5.2.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fpco/stackage/issues/1668#issuecomment-234352396, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABMez9qB1p27EMpYJNqnDkwpDAo0iAndks5qX8MxgaJpZM4JCo8p
.

👍 lifted the constraint for the next nightly.


Fixed #27652 -- Humanize template filters intcomma and intword also w…

…ork with floats.

merged in 398a859642636a2de0ab920befa320cd9954b49a, thanks!


Fix multinode demo, bank-hash is deprecated in ledger tool

ledger-tool has deprecated bank-hash in https://github.com/anza-xyz/agave/pull/1710, use the new command and parse the output.

Ugh dang it, thanks for catching this; I searched around a bit but must have missed this. I'm somewhat inclined to change the ledger-tool command to spit out only the hash for the hash so that we don't have to do any parsing here; thoughts ?

Ugh dang it, thanks for catching this; I searched around a bit but must have missed this. I'm somewhat inclined to change the ledger-tool command to spit out only the hash for the hash so that we don't have to do any parsing here; thoughts ?

That would be the best. I don't suppose many people need to the "bank hash is:" part since they specially asked for it.

Ugh dang it, thanks for catching this; I searched around a bit but must have missed this. I'm somewhat inclined to change the ledger-tool command to spit out only the hash for the hash so that we don't have to do any parsing here; thoughts ?

That would be the best. I don't suppose many people need the "bank hash is:" part since they specifically asked for it.

Sweet, I made https://github.com/anza-xyz/agave/pull/1745, which removes the extra text + updates the script. Will add you as a reviewer once CI completes


Fix: ".md" documents upload only works for drag n. drop in message.

Fix for #502 ...

Added same logic that was present for in-chat drag-n-drop to in-chat UI button
Added same logic to Downloads + button and drag-n-drop

Amazing! as a big user of Obsidian this is super helpful for me

Good catch! LGMT, Thanks!


error C2039 'release_context', 'release_callback'

flutter-webview-windows-main\example\windows\flutter\ephemeral.plugin_symlinks\webview_windows\windows\texture_bridge_fallback.cc(53,40): error C2039: 'release_context': It is not member of 'FlutterDesktopPixelBuffer' [~~~flutter-webview-windows-main\example\build\windows\plugins\webview_windows\webview_windows_plugin.vcxproj]
flutter-webview-windows-main\example\windows\flutter\ephemeral.plugin_symlinks\webview_windows\windows\texture_bridge_fallback.cc(56,41): error C2039: 'release_callback':  It is not member of 'FlutterDesktopPixelBuffer'  [~~~flutter-webview-windows-main\example\build\windows\plugins\webview_windows\webview_windows_plugin.vcxproj]
Exception: Build process failed.

What’s your Flutter SDK version? It’s apparently older than version 2.8.0…


add(tools): Design GUI

Design GUI
Link

Design GUI
https://designgui.io

AI-powered Chrome extension for managing colors in daisyUI and shadcn/ui.

[x] My item is in the right category
[x] My item is logically grouped below similar items
[x] My item's name and description respects the conventions of the list
[x] My item is awesome
[x] My item is in line with the Tailwind brand usage guidelines
[x] I have read and followed the contribution guidelines

Hey @jameschetwood this is pretty cool, why did you close the PR?

Hey @jameschetwood this is pretty cool, why did you close the PR?

Thanks! Only because I wasn't sure if I'd messed up the linting. I was going to try and get it working in my fork first as to not take up your time.

I don't know why linting fails, it's not even for your line, it looks fine to me.


How To Get Status Send Message

How to get status send message, I detect Log when :

[ ] My Message is Sent, the log is Cmd,ack:1
[ ] My Message is Receive to remoteJid, the log is Cmd,ack:2
[ ] My Message is Read by remoteJid, the log is Cmd,ack:3

Or how to get this Log:
s73,["Msg",{"cmd":"ack","id":"31AABD2D96B7E8AF220B266CF3DAD3F3","ack":1,"from":"6282266331136@c.us","to":"628118414000@c.us","t":1599140847}]
Thank

Currently there is no way implemented to retrieve the status of a sent message. I don't have much time to work on the API, so this feature is not a high priority for me. At least for now.
To get the log you could for example check within the onTextMessage method of the WAClient class if the received message contains the string "ack". This of course requires you to recompile the library.

Thank's


view -> extract objects close window behavior

If you go to view -> extract objects, and then close the popup window with the "x" button (like you changed your mind and don't actually want to use the feature) it still acts as though some processing is going on in the background (spinning beach ball in MacOS).

Fixed


1221 | Split a String in Balanced Strings  | Python

Title - Split a String in Balanced Strings
What will change - I will add new code
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] Python

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

@varian97  could i work on this?

@SSKale1 I didn't see anyone solved this problem yet, so I want to solved it. Can you please assign me to this issue? thanks

@varian97 could i work on this?

I don't think so, you need to create a new issue for yourself, specifying the problem you want to solve and make sure no one has solved it

Waiting someone from the contributors team to assign me to this issue, so my PR counted as valid


chore: upgrade typescript to v5

Issue: EXT-1600

@eunjae-lee the workflow failed, because Storybook failed to build with Typescript 5. I found a workaround here: https://github.com/hipstersmoothie/react-docgen-typescript-plugin/issues/78


Mithril Realworld Example App

I'm busying setting up a Mithril implementation of the Realworld app.
Would really appreciate feedback / contributions at barryels/realworld-mithril or (more high level) at: https://github.com/gothinkster/realworld/issues/69

This is a neat idea, will take a look this evening and probably send a few PRs.

Brilliant, thanks @tivac :+1:

@tivac, take a look at:
https://github.com/gothinkster/react-redux-realworld-example-app
and
https://github.com/gothinkster/angular2-realworld-example-app
as examples of other implementations.

Hi everyone, just an update:
TLDR;
Question: Should example Mithril code be written in es6 + jsx, or es5 + m()?

The app's about 50% complete!
I've been focusing on a broad strokes implementation of the "Realworld" spec and trying not to concern myself with too many details. So there are some gaps, e.g. multiple filtered ArticleLists (probably best to utilise a higher order component to wrap some related concerns), etc.

Question: Should example Mithril code be written in es6 + jsx, or es5 + m()?
The other "Realworld" impls tend toward es6 syntax + webpack / rollup. Whereas I tried to keep the Mithril version simple and old-school. Since the other (React, AngularJS) impls will probably be scrutinised by senior devs (as a framework comparison tool), I don't want the Mithril impl to be relatively undermined. Any thoughts?

I'm extremely excited about Mithril (have been using it in production for at least a year) and would love for it to become more mainstream, it's one of those libs that allows you to leave work at 17:00 :+1:

It's probably the most "idiomatic mithril" to do ES5 + m(), but use whatever you're comfortable with IMO. We use ES6 + m() and transpile.
I think RouteResolvers + Layout components are rad, so I vote for using 'em
KISS, with comments about potential improvements & further abstractions if necessary. We tend to use a single state object w/ a simple functional API.
¯\_(ツ)_/¯ if other "RealWorld" projects have 'em it's probably a good idea.

Awesome! Thanks for the feedback @tivac

Will leave it as-is then (ES5 + m()).
Cool, will leave as-is for now, possibly adding a second layout comp to wrap a screen or two at a later stage.
Rad, I'll conjoin and simplify domain & api-adapter.
The other projects don't seem to, but it could be a good opp to showcase mithrils simple testing approach.

What about SSR. Do you plan to do this. I can assist in this space if you want

Thanks for the feedback @orbitbot :)

Yeah, was initially going to create a mithril-mobx version, but wanted to try an "idiomatic" approach first. Looking at the other projects has caused me to change my approach in some areas, so as to ensure that the Mithril version is as close to an "apples-to-apples" comparison as is possible. The main reason for alignment with the other projects is to help senior devs easily grok the libraries' differences without getting distracted by app-level details. We can rename the repo later on when the need arises :)
hehehe
Yeah, my thinking as well... very little ROI in "visual" UI testing. Will probably set up a suite for the domain object and ignore the UI for now, unless someone else wants to pick that up ;)

@StephanHoyer Oh cool! Hadn't planned on it, but if you're offering... Then, hell yes!

@tivac Re: 3. domain + api-adapter
Do you mind posting a simple example of what your implementation looks like?

Just my few cents for what it is worth.
I have some Angular experience but got curious with Mithril and it's no nonsense approach...
So apologies for my ignorance in advance if there is something I miss.
So following that principle, this
var routes = {
	'/': {
		view: function () {
			return m(LayoutDefault, m(ScreenHome));
		}
	},
	'/article/:slug': {
		view: function () {
			return m(LayoutDefault, m(ScreenArticle));
		}
	},
	'/register': {
		view: function () {
			return m(LayoutDefault, m(ScreenUserRegister));
		}
...

might be perhaps possible to shorten to
var routes = {
	'/':                    () => m(LayoutDefault, m(ScreenHome)),
	'/article/:slug':  () => m(LayoutDefault, m(ScreenArticle)),
	'/register':        () => m(LayoutDefault, m(ScreenUserRegister)),
...

or even
var routes = {
	'/':                    () => LayoutDefault(ScreenHome),
	'/article/:slug':  () => LayoutDefault(ScreenArticle),
	'/register':        () => LayoutDefault(ScreenUserRegister),
...

The last one would be a portable general syntax with no specific library dependency,
and that universality may appeal to people coming from other frameworks (it would to me).

From the code organisation perspective, the components directory looks very busy. Any reasons all components, even unrelated ones, must sit next to each other? This "by-feature-vs-by-function" organisation discussion had been quite popular in angular circles for a quite a while, with the outcome in definite favour of the features.
I have found the directory structure really well done in the angular real world example, with no directory having more than 10 or so files.
Perhaps I would move the LayoutDefault to the higher level, due to its hierarchical role.

@dmitriz That's not how RouteResolvers work. They're a specifically-shaped object that mithril treats differently to enable persistent layout components.

@tivac
Sure.
I am just saying it would be simpler to write, so might be worth to support pure functions instead of more verbose and complex components, where pure view functions is all you need.
(The idea is from @JAForbes)
Basically, there are two ways:

Extend the router functionality to recognise functions in place of components and simply act as if those are the view methods;
Wrap the router in a new object that would do just that.

The first way would make it more user-friendly in my view. I might be missing something of course.

Is there a reason for the null value?
https://github.com/barryels/realworld-mithril/blob/master/src/ui/components/UserSettingsForm.js#L6
Because Null is the Saruman of Static Typing. :)

@dmitriz Thanks for the feedback, quite valuable discussion points.

Router refactor (RouteResolver):
I think one of the goals of this project should be to keep things as simple as possible. Whilst I agree with your sentiment completely (this project source is not a 1:1 version of what I'd build for clients). Each person / team will have their own approach to abstractions, and it would probably hinder the understanding of mithril to add too many layers.
Your example refactoring exactly illustrate the power that comes from mithril's simplicity :)

File structure
Yup, I'm definitely in the structure-by-feature camp (have worked on some massive angular apps, with feature-toggling, etc.), and organising by feature works most of the time, but there will eventually be a feature request which cross-cuts multiple existing features. Once again, this is a subjective decision, which I'm not willing to make if it's going to detract from mithril's implementation details.
Probably best to move Screen*.js and Layout*.js into separate dirs, but other than that I'm not sure that the advantage of feature grouping will outweigh the disadvantage of "hiding" components in separate directories... at this point, at least :)

Example
This component:
https://github.com/gothinkster/angularjs-realworld-example-app/master/src/js/components/buttons/favorite-btn.component.js
should probably live here:
https://github.com/gothinkster/angularjs-realworld-example-app/master/src/js/article

Absolute require's
Nah, absolute pathing in cjs is not a good idea, it creates more problems than it solves; most notably lack of consistent cross-IDE support :/

@dmitriz

Is there a reason for the null value for what will be called as function?

Was just defining the shape of the state object, so that it's clear that some function is going to have to update that reference :)

Ah, yes, requires using es6 modules though?

@barryels

Thanks for the feedback, quite valuable discussion points.

Router refactor (RouteResolver):
I think one of the goals of this project should be to keep things as simple as possible. Whilst I agree with your sentiment completely (this project source is not a 1:1 version of what I'd build for clients). Each person / team will have their own approach to abstractions, and it would probably hinder the understanding of mithril to add too many layers.
Your example refactoring exactly illustrate the power that comes from mithril's simplicity :)

I can see your point. I still hope it can be made less verbose when staying simple.
As a workaround, perhaps make the router declarations more direct by importing the components rather than their view methods?
Also, does the router API not allow for any tree hierarchy, where I can put the defaultLayout as a top route and so avoid repeating it every single time?

File structure
Yup, I'm definitely in the structure-by-feature camp (have worked on some massive angular apps, with feature-toggling, etc.), and organising by feature works most of the time, but there will eventually be a feature request which cross-cuts multiple existing features. Once again, this is a subjective decision, which I'm not willing to make if it's going to detract from mithril's implementation details.
Probably best to move Screen*.js and Layout*.js into separate dirs, but other than that I'm not sure that the advantage of feature grouping will outweigh the disadvantage of "hiding" components in separate directories... at this point, at least :)

I am myself against deep nesting that are often abused with zillions of tiny files doing almost nothing. But your components are already 2 levels deep, so it wouldn't increase any depth with more subdirs inside src. Right now, as an outside, I have no idea how to differentiate between different components. Perhaps putting those called by the router higher as index files in their same named directories with other dependent ones beside, then have a separate folder shared with the reusable ones that don't belong elsewhere. I just don't find the name components of much help when everything is a component :)

@dmitriz
RouteResolver: Something more like this? i.e. just DRYing the code up a bit?
var routes = {
	'/': setupRoute(ScreenHome),
	'/article/:slug': setupRoute(ScreenArticle),
	'/register': setupRoute(ScreenUserRegister),
	'/login': setupRoute(ScreenUserLogin),
	'/@:username': setupRoute(ScreenUserProfile),
	'/@:username/favorites': setupRoute(ScreenUserFavorites),
	'/settings': setupRoute(ScreenUserSettings),
	'/editor': setupRoute(ScreenEditor),
	'/editor/:slug': setupRoute(ScreenEditor)
};

function setupRoute(screen, layout) {
	layout = layout || LayoutDefault;

	return {
		view: function () {
			return m(layout, m(screen));
		}
	};
}

That would look nicer to me!
Or even restrict the router to the intermediate main slot, then you won't need to wrap them at all. Would that make sense?


Write deploy script

Sends the build to athena in the right folder
Should eventually take dev vs prod and kerberos as arguments

Also update the README please!


[SMP] Establish experiment naming prefix convention for Quality Gates

What does this PR do?
Duplicates the two existing quality-gate experiments and prefixes the experiment name with quality_gate_
Motivation
Some SMP experiments are designed to be the most representative of overall Datadog Agent behavior, these will have strict upper bounds and will have been audited in more depth than others.
These "Quality Gate" experiments will be identified by this quality_gate_ prefix.
Describe how to test/QA your changes
n/a
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Hand Labeler only removes labels.

Hand Labeler only removes labels.
It will not add a label to something.

It seems to work fine for me on master. Are you using it in your hands to set the label? (you don't set label by clicking on something else)

Okey... It's working now when I try to reproduce it... I have no idea why it wasn't working before.

I guess its possible theres some other bug that causes it to stop working after some time or something.... I guess re open this if it happens again?

it's a bug where the label on the machine doesn't apply properly, same issue on the disposal taggers and routers

The ‘delay’ between equipping a labeler and being able to change its label is oddly similar to the ‘delay’ that occurs when you pick one up.
Spitballing here, ‘cause I currently can’t test: What if the ‘use delay’ was removed? Would that fix it?


Rootio mbr support

Description
This PR, extends CPR to support MBR type partitions instead of the default GPT
Why is this needed
VMware requires it's installation disk to be in this format.
Fixes: #
How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?
Hidden behind an MBR environment variable, users wont see it by default.
Checklist:
I have:

[x] updated the documentation and/or roadmap (if required)
[x] added unit or e2e tests
[ ] provided instructions on how to upgrade

dan@code:~/go/src/github.com/tinkerbell/hub/actions/rootio/v1$ sudo TEST=y MBR=true JSON_FILE=./test/mbr.json ./v1 partition
Successfully Opened test data
Succesfully parsed the MetaData, Found [1] Disks
ROOTIO - Disk Manager
------------------------
Parsing MetaData
INFO[0000] Examining disk [/dev/sdb]
INFO[0000] Disk Size [16384MB]
INFO[0000] Found [4] partitions
INFO[0003] Wrote [1073741824] bytes to [/dev/sdb]
INFO[0003] Flushing writes to new partition
INFO[0004] Wiping
INFO[0004] Partitioning
INFO[0004] New Partition Name=FAT32_ACTIVE Start=2048 Size=33552384
INFO[0004] Flushing writes to new partition

dan@code:~/go/src/github.com/tinkerbell/hub/actions/rootio/v1$ sudo fdisk -l /dev/sdb
Disk /dev/sdb: 16 GiB,<PHONE_NUMBER>4 bytes, 33554432 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x00000000

Device     Boot Start      End  Sectors Size Id Type
/dev/sdb1  *     2048 33554431 33552384  16G  c W95 FAT32 (LBA)

Closing these PRs, in favour of clean PRs.


Expose the keep_alive_sec attribute in HASS Developer Tools - States

This PR improves debugging diagnostics for the switch keep-alive feature for issues such as #379.
That’s achieved through one of the three commits. The other two commits improve type hints.

Hello @pdcastro ,
I will off for one week and my VSCode is totally broken since a try to switch to Python 12. No more PyLance, no more ability to run unit test. So it will be difficult for me to validate this rapidly. I understand this is not a bug but more for debug purpose : the keep-alive was not into the attributes. So maybe it can waits a few days ?

@jmcollin78, no hurry, this PR can wait. I can confirm that I have not found any bugs. This PR just improves debugging, logging, and type checking. I can also confirm that all unit tests pass.
Talking of Python 3.12, this PR uses type hint syntax that is compatible with both Python 3.11 and 3.12, even though Python 3.12 introduced a nice new Type Parameter Syntax. I assume that we still need to support Python 3.11, because:

The HASS core repo still reads requires-python = ">=3.11.0".
The Home Assistant ADR (Architecture Decision Record) 0020 states that ”Once the new version is supported by the Home Assistant project and rolled out in our container distributions, the previous Python version will be deprecated for a period of two release cycles.” I understand that “deprecated” means that it is discouraged but still supported, for the time being. The HASS container currently uses Python 3.12:

$ docker run -it ghcr.io/home-assistant/home-assistant:2024.2.1 python --version
Python 3.12.1

Still on the subject of Python 3.12, today I updated my Home Assistant to version 2024.2.1 and in the Settings area I saw this popup:

But I would still use the old type hint syntax (compatible with both 3.11 and 3.12) in integrations like VTherm at least until HASS 2024.4 is released.

Does you Python dev environment works normally after switching to Python 1.12 ?
I mean, I change the .devcontainer file by added this line: "image": "mcr.microsoft.com/vscode/devcontainers/python:1-3.12",
and all is now broken.
If you don't have done it yet, don't do it. I think it is not stable.

Does you Python dev environment works normally after switching to Python 1.12 ?

Yes (Python 3.12, devcontainer image python:1-3.12). Specifically, the unit tests (pytest) work fine and home assistant works fine when started with the ./scripts/starts_ha.sh script:
vscode ➜ /workspaces/versatile_thermostat (expose-keepalive-attribute) $ cat /etc/os-release
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
...
vscode ➜ /workspaces/versatile_thermostat (expose-keepalive-attribute) $ python --version
Python 3.12.2

vscode ➜ /workspaces/versatile_thermostat (expose-keepalive-attribute) $ pytest
Test session starts (platform: linux, Python 3.12.2, pytest 8.0.0, pytest-sugar 0.9.7)
...
 tests/test_auto_fan_mode.py ✓✓✓                                                                                3% ▍
...
 tests/test_window.py ✓✓✓✓✓✓✓✓✓✓✓✓✓                                                                                100% ██████████

Results (35.15s):
      96 passed
       1 skipped

vscode ➜ /workspaces/versatile_thermostat (expose-keepalive-attribute) $ ./scripts/starts_ha.sh
...
2024-02-16 13:38:21.800 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration versatile_thermostat which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2024-02-16 13:38:24.534 INFO (MainThread) [homeassistant.setup] Setup of domain logger took 0.0 seconds
...
2024-02-16 13:38:24.627 INFO (SyncWorker_1) [homeassistant.util.package] Attempting install of janus==1.0.0
...
2024-02-16 13:38:25.593 INFO (SyncWorker_3) [homeassistant.util.package] Attempting install of Pillow==10.2.0
...
2024-02-16 13:44:58.434 INFO (MainThread) [homeassistant.setup] Setting up versatile_thermostat
2024-02-16 13:44:58.435 INFO (MainThread) [custom_components.versatile_thermostat] Initializing versatile_thermostat integration with config: {...}

As per timestamps above, HASS took more than 5 minutes to start for the first time after rebuilding the devcontainer (VSCode palette command “Dev Containers: Rebuild Container”), as it was installing dependencies at runtime. After that though, restarting HASS takes only a few seconds.
I'm using VSCode version 1.86.2, Docker Desktop 4.27.2, on a Mac laptop.
Are you getting any specific error messages?

Pylance also works for me with "image": "mcr.microsoft.com/vscode/devcontainers/python:1-3.12" –

ok thank you for your feedback. So I guess I have exactly the same configuration as yours now.
I have tried different base image (like FROM mcr.microsoft.com/devcontainers/python:3.12) and 1-3.12.
The errors are:

pylance always crash after a few minutes (I already have this issue but it is now systematic),
pytest don't work at all ('cannot connect to python ...'),
a weird error during startup about dependency not installed. (don't remember the exact error).

I will try with the last commit you do fixing the ffmeg (local Dockerfile) to see if it is better.

”What is your current Python extension in VSCOde ? Mine is this one :”

Same version as in your screenshot – v2024.0.1.
I had always used the terminal command line to run tests, but now that you mentioned running them through the VSCode UI, the following has worked for me:

VSCode palette command: “Python: Configure Tests” ➔ “pytest” ➔ “Use existing config file setup.cfg”
Testing tab, Run Tests icon:

Test Results tab next to the Terminal tab at the bottom of the window:

I think I’m lucky today, it’s the first time I tried to do this and it just worked! I should buy a lottery ticket. 😄

![results](https://private-user-images.githubusercontent.com/15091591/305510898-994a3a06-1327-465b-a279-fb01278182cb.jpg?jwt=e
I think I’m lucky today, it’s the first time I tried to do this and it just worked! I should buy a lottery ticket. 😄

This is exactly how it was working before. Maybe it is not related to Python or pytest plugin but more on my Mac.

I’ve force-pushed in order to rebase on the main branch, and also for this change:

Before:T = TypeVar("T")
After:T = TypeVar("T", bound=UnderlyingEntity)

Hello @pdcastro,
This is not forgotten. I was on the major 6.0 release. The bad news is that it generated conflicts with your development. But I want to see what you have done before trying to merge. I'm not a big fan of generic typing which is a kind of obfuscation for me. Typing should help the reader and not confuse it.

This is not forgotten. I was on the major 6.0 release. The bad news is that it generated conflicts with your development. But I want to see what you have done before trying to merge. I'm not a big fan of generic typing which is a kind of obfuscation for me. Typing should help the reader and not confuse it.

Well, I was already forgetting about it! 😄  I’ve now rebased on the main branch and fixed the merge conflict. All tests pass.
As you know, typing (including generic typing) enables “intellisense” that allows things like:

Displaying the actual type of a variable when the developer hovers the mouse cursor over the variable.
Displaying a list of parameter types and return types for a function call.
Auto-complete when typing.
Highlighting potential mistakes like typos, assignments of incompatible objects, calling inexistent methods, etc.
Enabling tools like pylint and pyright to produce warning / error reports.

The generic type introduced in this PR:
T = TypeVar("T", bound=UnderlyingEntity)

class BaseThermostat(..., Generic[T]):
...
        self._underlyings: list[T] = []

... means that:

T is a type that is a subclass of UnderlyingEntity (the bound= part).
BaseThermostat makes use of T.
T may be redefined to compatible types (like UnderlyingSwitch, etc) by subclasses of BaseThermostat.

This allows intellisense to figure out that, for example, self._underlyings is a list of instances of UnderlyingValve (and not merely instances of UnderlyingEntity), in usage such as:
thermostat_valve.py
        for under in self._underlyings:
            under.set_valve_open_percent()

Where set_valve_open_percent() is only defined for UnderlyingValve, and not UnderlyingEntity. Before this PR, without the generic typing, intellisense would place a red underline under set_valve_open_percent() in the line above, and when you hovered the mouse cursor over it, it would pop up an error message: ”Cannot access member “set_valve_open_percent”  for type “UnderlyingEntity”. After this PR, with the generic typing, the red underline and pop error disappear.
The backwards-compatible generic type syntax for Python 3.11 and older is indeed verbose and may seem obscure if one is not used to it. Python 3.12 makes it nicer. For example:
All recent Python versions (backwards compatible syntax):
from typing import TypeVar, Generic

T = TypeVar("T", bound=UnderlyingEntity)

class BaseThermostat(..., Generic[T]):
...
        self._underlyings: list[T] = []

Python 3.12 and later (also requires the most recent versions of pylint and pyright):
class BaseThermostat[T: UnderlyingEntity](...):
...
        self._underlyings: list[T] = []

So if it is any consolation, when Home Assistant drops support for Python 3.11, which may happen in the next 12 months, the new syntax can be adopted and it will be easier on the eye. 🙂
One final note: The three commits in this PR are reasonably self contained, so you may find it easier to review them separately: Go to the Commits tab at the top of the PR page and click on each of the three commits. (I suppose I could have created separate PRs.) And sorry if I am saying things you already knew! I have some awareness of how annoying this can be. 😄

This is not forgotten. I was on the major 6.0 release. The bad news is that it generated conflicts with your development. But I want to see what you have done before trying to merge. I'm not a big fan of generic typing which is a kind of obfuscation for me. Typing should help the reader and not confuse it.

Well, I was already forgetting about it! 😄 I’ve now rebased on the main branch and fixed the merge conflict. All tests pass.
As you know, typing (including generic typing) enables “intellisense” that allows things like:

Displaying the actual type of a variable when the developer hovers the mouse cursor over the variable.
Displaying a list of parameter types and return types for a function call.
Auto-complete when typing.
Highlighting potential mistakes like typos, assignments of incompatible objects, calling inexistent methods, etc.
Enabling tools like pylint and pyright to produce warning / error reports.

The generic type introduced in this PR:
T = TypeVar("T", bound=UnderlyingEntity)

class BaseThermostat(..., Generic[T]):
...
        self._underlyings: list[T] = []

... means that:

T is a type that is a subclass of UnderlyingEntity (the bound= part).
BaseThermostat makes use of T.
T may be redefined to compatible types (like UnderlyingSwitch, etc) by subclasses of BaseThermostat.

This allows intellisense to figure out that, for example, self._underlyings is a list of instances of UnderlyingValve (and not merely instances of UnderlyingEntity), in usage such as:
thermostat_valve.py
        for under in self._underlyings:
            under.set_valve_open_percent()

Where set_valve_open_percent() is only defined for UnderlyingValve, and not UnderlyingEntity. Before this PR, without the generic typing, intellisense would place a red underline under set_valve_open_percent() in the line above, and when you hovered the mouse cursor over it, it would pop up an error message: ”Cannot access member “set_valve_open_percent” for type “UnderlyingEntity”. After this PR, with the generic typing, the red underline and pop error disappear.
The backwards-compatible generic type syntax for Python 3.11 and older is indeed verbose and may seem obscure if one is not used to it. Python 3.12 makes it nicer. For example:
All recent Python versions (backwards compatible syntax):
from typing import TypeVar, Generic

T = TypeVar("T", bound=UnderlyingEntity)

class BaseThermostat(..., Generic[T]):
...
        self._underlyings: list[T] = []

Python 3.12 and later (also requires the most recent versions of pylint and pyright):
class BaseThermostat[T: UnderlyingEntity](...):
...
        self._underlyings: list[T] = []

So if it is any consolation, when Home Assistant drops support for Python 3.11, which may happen in the next 12 months, the new syntax can be adopted and it will be easier on the eye. 🙂
One final note: The three commits in this PR are reasonably self contained, so you may find it easier to review them separately: Go to the Commits tab at the top of the PR page and click on each of the three commits. (I suppose I could have created separate PRs.) And sorry if I am saying things you already knew! I have some awareness of how annoying this can be. 😄

Thank you for all explanations ! I have learn something today thanks to you. Because I'm not a Python native developper I didn't know this.


Move to using go mod (go 1.11+)

This looks good, thank you for contributing. I'm a little behind on reading about go modules, so let me catch up and I'll get this merged.

As part of go mods, go libraries will have to use SemVer. Do you mind tagging master (after merging this) something like v1.0.1?

@jcmuller sure thing. I'll tag it v1.1.0 since it's been in production for a while and a few new features were added.

@rafecolton rebased the latestaster and updated dependencies.

@rafecolton nice! Please remember to tag and push v1.1.0
Thanks!

Yep, done. Decided to go with v1.0.0 since it was the first official tag
On Tue, Dec 3, 2019 at 11:35 AM Juan C. Muller<EMAIL_ADDRESS>wrote:

@rafecolton https://github.com/rafecolton nice! Please remember to tag
and push v1.1.0
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/himalayan-institute/zoom-lib-golang/pull/11?email_source=notifications&email_token=AAICNKYVVVAKMONPO3QOQA3QW2KFPA5CNFSM4JQGFTEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF2GDWY#issuecomment-561275355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAICNK6DRE2JWIMLXSYFQZDQW2KFPANCNFSM4JQGFTEA
.


Bug fixes / improvements to the repacker

This PR should solve all the issues with tests failing in CI due to the repacker.

Ok, the CI is green. merging.


Update sbt-dependency-updates to 1.2.8

About this PR
📦 Updates org.jmotor.sbt:sbt-dependency-updates from 1.2.7 to 1.2.8
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.jmotor.sbt", artifactId = "sbt-dependency-updates" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.jmotor.sbt", artifactId = "sbt-dependency-updates" }
}]

labels: sbt-plugin-update, early-semver-patch, semver-spec-patch, version-scheme:semver-spec, commit-count:1

Superseded by #28.


How can I check the existing sheet name in excel file with version 3.1 ?

Prerequisites
Versions

PHP version: 7.2
Laravel version: 5.7
Package version: 3.1

Description
Hello. I'm starting with version 3.1, and I'm having a problem with it.
How can I check the existing sheet name in excel file witdh version 3.1? Can you help me? Thanks you.

https://github.com/Maatwebsite/Laravel-Excel/issues/1820 and https://github.com/Maatwebsite/Laravel-Excel/issues/1881#issuecomment-437280026 might help you get on track.

@dauminhquan : I am closing this issue as I assume it has been resolved?


PowerShell causes Segmentation Fault with Find-Command on Linux when network is connected through VPN

Steps to reproduce

Start Powershell
Prompt is displayed
Type in Find-Command
A segmentation fault occurs

Expected behavior
It should not cause a segmentation fault, and should display a list of commands.
strace below:
PS /home/hideki>                           Find-Command
) = 0
futex(0x93c188, FUTEX_WAKE_PRIVATE, 1)  = 0
gettid()                                = 28897
clone(child_stack=0x7f74317b8fb0, flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID, parent_tidptr=0x7f74317b99d0, tls=0x7f74317b9700, child_tidptr=0x7f74317b99d0) = 28917
sched_getparam(28917, [0])              = 0
sched_getscheduler(28917)               = 0 (SCHED_OTHER)
sched_get_priority_max(SCHED_OTHER)     = 0
sched_get_priority_min(SCHED_OTHER)     = 0
sched_setscheduler(28917, SCHED_OTHER, [0]) = 0
write(168, "*", 1)                      = 1
sched_yield()                           = 0
sched_yield()                           = 0
sched_yield()                           = 0
futex(0x93c1b4, FUTEX_WAIT_PRIVATE, 9, NULL <unfinished ...>
+++ killed by SIGSEGV +++
zsh: segmentation fault  strace powershell

Actual behavior
Powershell segfaults and does not display a list of commands.
Environment data
Name                           Value
----                           -----
PSVersion                      6.0.0-alpha
PSEdition                      Core
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>
GitCommitId                    v6.0.0-alpha.10
CLRVersion
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Hi hsaito!
You missed to provide which version of linux you had this issue.
I did ran Find-Command on my Ubuntu 16.04.1 LTS Desktop and had no problems executing the Find-Command in PowerShell version v6.0.0-alpha.10.

. (see image)

Sorry for the lack of info on that, it's ubuntu 16.04 LTS, 15.6GiB memory, Intel Core i7-2600 CPU @ 340GHz x 8, Gallium 0.4 and AMD TURKS (DRM 2.43.0, LLVM 3.8.0).
I have actually isolated this issue to only happen when I am connected through VPN. If I disconnect from the VPN, it works as designed.

For the security reason, I can't provide too much detail on VPN connection, but it is an OpenVPN connection.

@hsaito can you run the Pester tests and see which fail? That might help to narrow it down.

I am not sure how the Pester test works at this moment, but does the following output suffice?
./Pester.Tests.ps1
Describing Pester manifest and changelog
[+] has a valid manifest 40ms
[+] has a valid name in the manifest 13ms
[+] has a valid guid in the manifest 13ms
[+] has a valid version in the manifest 14ms
[+] has a valid version in the changelog 19ms
[+] changelog and manifest versions are the same 10ms
Describing Clean treatment of the $error variable
Context A Context
[+] Performs a successful test 30ms
[+] Did not add anything to the $error variable 21ms
Describing SafeCommands table
[+] The SafeCommands table contains all commands that are called from the module 33ms
Describing Style rules
[+] Pester source files contain no trailing whitespace 79ms
[+] Pester Source Files all end with a newline 9ms
Describing ResolveTestScripts
[+] Resolves non-wildcarded file paths regardless of whether the file ends with Tests.ps1 61ms
[-] Finds only *.Tests.ps1 files when the path contains wildcards 19ms
Expected: {True}
But was:  {False}
at line: 187 in /home/hideki/pester/Pester/Pester.Tests.ps1
187:             ($paths -contains "$TestDrive\SomeFile.Tests.ps1") | Should Be $true
[-] Finds only *.Tests.ps1 files when the path refers to a directory and does not contain wildcards 19ms
Expected: {True}
But was:  {False}
at line: 198 in /home/hideki/pester/Pester/Pester.Tests.ps1
198:             ($paths -contains "$TestDrive\SomeFile.Tests.ps1") | Should Be $true
[+] Assigns empty array and hashtable to the Arguments and Parameters properties when none are specified by the caller 21ms
Context Passing in Dictionaries instead of Strings
[+] Allows the use of a "P" key instead of "Path" 31ms
[+] Allows the use of an "Arguments" key in the dictionary 16ms
[+] Allows the use of an "Args" key in the dictionary 14ms
[+] Allows the use of an "A" key in the dictionary 16ms
[+] Allows the use of a "Parameters" key in the dictionary 16ms
[+] Allows the use of a "Params" key in the dictionary 20ms
[+] Throws an error if no Path is specified 15ms
[+] Throws an error if a Parameters key is used, but does not contain an IDictionary object 16ms

This issue was moved to PowerShell/PowerShellGet#20

@hsaito with several new version of PSGet published since the bug was reported I wonder if it still exists.
Would you mind to test and comment on https://github.com/PowerShell/PowerShellGet/issues/20 ?


Gradle 4.8 Compatibility

Upgrade nebula-test 6.4.0 -> 6.4.3
Update NebulaDependencyInsightReportTask method signature

Not ready to merge - has an issue with the way the Plugin class name is generated


Update JS loading

Remove vendors (where possible) from the repository and load them through NPM/Yarn
Update gulp process to pre-process all scripts through Babel
Add manifest file for better cache busting

Coverage remained the same at 25.196% when pulling 4cc19c940a5a802ad14a804d79a255a891ff7bc0 on pierredup:scripts into e7d5ce6f1feea39929db250688455755c2fe09d5 on CSBill:master.

Coverage remained the same at 25.196% when pulling 4cc19c940a5a802ad14a804d79a255a891ff7bc0 on pierredup:scripts into e7d5ce6f1feea39929db250688455755c2fe09d5 on CSBill:master.

Coverage decreased (-0.1%) to 25.092% when pulling b8e618b85c87936cd7d9446b648c16b56b0393a8 on pierredup:scripts into e7d5ce6f1feea39929db250688455755c2fe09d5 on CSBill:master.

Coverage remained the same at 25.196% when pulling a620e09d50429cfd4335645928b77dd0b271c4ae on pierredup:scripts into e7d5ce6f1feea39929db250688455755c2fe09d5 on CSBill:master.


Error while trying to add windows node in a cluster with multiple control nodes

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Have a cluster - 3 nodes - All roles. (custom cluster)
add a windows node to the cluster

Expected Result:
windows node should get added successfully to the cluster
Actual Result:
Failed to register the windows node. Error seen:

Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.3.0-alpha1
Installation option (single install/HA): HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): custom Azure
Kubernetes version (use kubectl version):

1.14.1

available in master and v2.3.0-alpha2

Verified on v2.3.0-alpha2
Deployed a cluster with 3 linux nodes - All Roles, 2 windows worker nodes - Custom type -Azure. (verified on a HA setup)
Was able to successfully bring up the cluster and deploy workloads.


loader: clean up tcx bpf_links created by newer Cilium versions

This PR represents the backportable part of https://github.com/cilium/cilium/pull/30103 and needs to be merged and backported independently in order for the downgrade path (and tests) to work.
Remove tcx links created by Cilium 1.16 onwards

/test

Do we need a 1.13 backport? TCX will be released with 1.16, so only 1.15 and 1.14 need the downgrade path or did we change that policy?

Do we need a 1.13 backport? TCX will be released with 1.16, so only 1.15 and 1.14 need the downgrade path or did we change that policy?

No, 1.13 is not needed. Technically only 1.15 needs it.

/test

Had to make the <device>/links removal a bit less greedy since it was also removing existing xdp links that were created right before. attachTCProgram now only removes <device>/links/cil_<prog> before trying to attach it using netlink.

/test


Keyboard doesn’t work

The keyboard doesn’t work when installed

Please give me more detail about your problem.

When in installation step, please use your external mouse and keyboard. Sorry for that


This in Marketplace

Hi,
I can't see this extension in market place.

Yeah its not available in VS market place.
also if we try to download and build the project , we are getting compilation error :

Severity	Code	Description	Project	File	Line	Suppression State
Error		The "CtoResourceMerger" task could not be loaded from the assembly C:\Users<username>\Downloads\VSKubernetes-master\VSKubernetes-master\packages\Microsoft.VSSDK.BuildTools.15.6.170\tools\VSSDK\Microsoft.VisualStudio.Sdk.BuildTasks.dll.  Confirm that the  declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.	VSKubernetes


Show number of payments for bunq.me Tab

A simple addition :-)

Example:

Awesome PR @basst85 👍
Thanks for contributing once again!


guardian_backup flake

 00:05:15 2024-04-29T18:18:05.504871Z  INFO devimint::tests: Caught up to block 102 of at least 122
00:05:15 thread 'main' panicked at /build/source/devimint/src/tests.rs:2266:6:
00:05:15 Peer didn't rejoin federation: Polling Peer catches up again failed after 99 retries (timeout: 60s)

https://github.com/fedimint/fedimint/actions/runs/8883243488/job/24389687956?pr=5159
When trying a PR that lowers the session time when running tests from 2 minutes to around 10s, we've hit a bug in guardian_backup where the peer is restarted and expected to reach the same wallet module onchain height as before the restart.
This is a normal test-ci-all run which means i think we default do one peer being down from start. Which means on restart of a peer we might be losing consensus in some way, and I think smaller session time exposes us much to some timing condintion (another benefit of lowering session time in tests).
Unfortunately I don't have deeper logs from it. I'll try to repro locally.

@elsirion @joschisan might be of interest

i think we default do one peer being down from start.

I explicitly turned that off for this test.
https://github.com/fedimint/fedimint/blob/623f6cc16007c099a59cc3fd47ea6c1d6cf95de7/scripts/tests/test-ci-all.sh#L97-L100
What's also interesting is that we first make some progress up to 102 and then stop 20 blocks short of the target, indicating a stuck consensus indeed.
…18:17:10.761438Z  INFO devimint::tests: Caught up to block 0 of at least 122
…18:17:11.110710Z  INFO devimint::tests: Caught up to block 102 of at least 122

Have we been seeing this again recently?

I don't remember seeing it since last time there was some activity around it.