User-facing changes in 19.2 that were not picked up in release notes

Pursuant to https://github.com/cockroachdb/cockroach/pull/42345 I have scanned the entire 19.2 commit history (automatically) to pick up PRs where the author blindly used 'Release note: None' while there were user-facing changes. These are the changes that likely did not show up in release notes, and the doc team likely could not pick up the change to be documented.
If some of your changes are listed here, please review the PR(s) and suggest missing release notes + doc changes as a comment below.

For bug fixes, mention the likely symptoms a user would see when encountering the bug. If possible mention when the bug was introduced.
For telemetry changes, explain what is now reported in telemetry at a high level.
For workload changes, explain how the change helps users better benchmark CockroachDB.
for backward-incompatible changes, explain what users must do as a result.
for other changes, explain how a user would see the change, and what it's good for from the user's perspective.

Also don't forget the category!
Then click the checkbox on the left to indicate you've handled the change.
Note: I did a manual filtering on the automatic scan to remove false positives (no release note actually needed) but I may have left some. Mark the checkbox after you've confirmed that the PR indeed contains no user-facing change.
Changes without release note annotation

#39067 6b7fc3ae7 settings: slotIdx fix (贾德星<EMAIL_ADDRESS>
PRs merged by contributors
Hall of fame: all user-facing changes are properly documented

Ben Darnell: No missing release note! Congrats!
Bob Vawter: No missing release note! Congrats!
Celia La: No missing release note! Congrats!
Céline O'Neil: No missing release note! Congrats!
George Utsin: No missing release note! Congrats!
Georgia Hong: No missing release note! Congrats!
Jesse Seldess:  No missing release note! Congrats!
Kenneth Liu:  No missing release note! Congrats!
Lauren Hirata: No missing release note! Congrats!
Marc Berhault: No missing release note! Congrats!
Matt Jibson: No missing release note! Congrats!
Nathan Stilwell: No missing release note! Congrats!
Spencer Kimball: No missing release note! Congrats!
Tyler Roberts: No missing release note! Congrats!
Vlad Artamonov: No missing release note! Congrats!
Yevgeniy Miretskiy: No missing release note! Congrats!

Honorable mentions: just a few release note omissions

Aayush Shah: @aayushshah15

[ ] #41495 release-19.2: changefeedccl: fix violation of CDC's ordering guarantees

Andy Kimball: @andy-kimball

[x] #39192 storage: Add load-based split telemetry
[x] #37404 opt: Add array and tuple constant folding rules (2 commits)

Arul Ajmani: @arulajmani

[x] #40948 sql: Improve AS OF SYSTEM TIME error message

Bilal Akhtar: @itsbilal

[ ] #40926 server: Add telemetry to track hits to /health, /_status/vars
[ ] #40728 cli: Add 'pebble' debug command to run Pebble tool commands

Bram Gruneir: @BramGruneir

[ ] #37006 settings/cluster: Add a version to denote work on v19.2.

George Papadrosou: @tbg

[ ] #36976 storage: Send raftlogger panics to Sentry, wrap numbers as safe.

Irfan Sharif: @irfansharif

[x] [#unkno][#unkno] release-19.2: storage: write to local storage before updating… (#41764)

Pete Vilter: @vilterp

[ ] #37941 ui: bump axios to avoid security vulnerability

Peter Mattis: @petermattis

[x] #39121 build: compile RocksDB with -Wno-error-shadow

Ridwan Sharif: @jordanlewis

[ ] #38947 opt: fix casting bug in lookup joiner
[ ] #39202 opt, sql: support UPDATE ... FROM statements (3 commits)

Roland Crosby: @rolandcrosby

[ ] #35799 cli: detect GSS authentication response and recommend psql

Taufiq Rahman: @andreimatei

[x] #39246 Remove admin privilege for force_retry #39243 (2 commits)

Vivek Menezes: @lucy-zhang

[x] #36032 sql: add a validation job status during schema validation

Missing release notes (rest)

Aditya Maru: @jordanlewis

[ ] #39819sql: Skip creation/update of job for schema change in same txn as CREATE
[ ] #39463roachtest: Bump min version for direct ingest import roachtest
[ ] #39032pkg: Allows no target cols to be specified in IMPORT INTO query.
[ ] #39023pkg: Add support for user specified target cols in IMPORT INTO (3 commits)
[ ] #38327pkg: Add check disallowing IMPORT INTO a table with secondary indexes.
[ ] #39183importccl: Set FK and CHECK constraints to unvalidated after IMPORT INTO
[ ] #39148importccl: Modify row_id generation for IMPORT from CSV.
[ ] #39455importccl: Fixes target col bug for IMPORT INTO
[ ] #39493importccl: Add a memory monitor to reserve/grow memory in BulkAdder
[ ] #39724bulk: Compute MVCCStats of the SST being ingested on-the-fly
[ ] #39754bulk: Add metrics to bulk mem monitor for better visualisation

Alfonso Subiotto Marqués: @asubiotto

[ ] #39662 workload: fall back to using 19.1 vectorize setting on syntax error
[ ] #41467 release-19.2: colrpc: downgrade log messages from Error to Warning
[ ] #37088 exec: wrap hashRouter work with CatchVectorizedRuntimeError
[ ] #39093 exec: wait for internal goroutine completion in UnorderedSynchronizer
[ ] #38006 exec: set output columnTypes when creating noop operator
[ ] #40668 exec: reset internal unsafeBatch in orderedAggregator
[ ] #38557 exec: protect against unset syncFlowConsumer
[ ] #39248 exec: fix metadata drain cycles
[ ] #37571 exec: check for unset output columnTypes
[ ] #38329 distsqlrun: include StartScan stall time in EXPLAIN ANALYZE
[ ] #38622 distsqlrun: bump index joiner batch size from 100 to 10k
[ ] #37745 col{data,serde}: various fixes related to TestArrowBatchConverterRandom (2 commits)

Andrei Matei: @andreimatei

[x] #37140 storage: metrics improvements (2 commits)
[x] #40735 storage/reports: fix NPE in zone visiting
[x] #39675 sql: fix typo in error message
[x] #41935 settings/cluster: introducing the 19.2 cluster version
[x] #37412 server/heapprofiler: don't consider "goIdle" memory (2 commits)
[x] #41439 release-19.2: kv: fix cluster_logical_timestamp()
[x] #38275 log: use prefix in std loggers

Andrew Kryczka: @ajkr

[ ] #40215 workload/bank: reset payload column before reuse
[ ] #37102 storage: fix possible raft log panic after fsync error
[ ] #41737 release-19.2: c-deps: bump rocksdb for L0 file invariant fix
[ ] #41244 libroach: initialize range tombstone counter
[ ] #35591 libroach: enable rocksdb WAL recycling
[ ] #38868 libroach: avoid recycling encrypted WALs
[ ] #38576 c-deps: upgrade rocksdb to 6.2.1
[ ] #40899 c-deps: bump rocksdb to revert compaction snapshot refresh
[ ] #40226 c-deps: bump rocksdb to pick up a log severity change
[ ] #41018 c-deps: bump rocksdb for unique cache IDs on Windows
[ ] #40712 c-deps: bump rocksdb for safer LSM invariant checks
[ ] #38939 c-deps: bump rocksdb for musl libc build fix
[ ] #37172 c-deps: bump rocksdb for multiple backported PRs
[ ] #38891 c-deps: bump rocksdb for macOS build fix

Andrew Werner: @ajwerner

[ ] #39095 workload/tpcc: perform checks atomically, optionally historically and separately (2 commits)
[ ] #38587 util/quotapool: various features and fixes (3 commits)
[ ] #38759 quotapool: add fast path to Acquire
[ ] #37248 util/metric: make Rate into a real metric
[ ] #41308 storage: remove error from Replica.applyTimestampCache()
[ ] #40505 storage: prevent reproposals of applied commands
[ ] #41300 storage: more aggressively replica GC learner replicas
[ ] #37107 storage: fix potential panic tracing raft requests
[ ] #40961 storage: fix nil pointer panic during replica changes
[ ] #41267 storage: add telemetry counter for txns pushed by the closed timestamp
[ ] #39172 storage,nodedialer,kv,rpc: introduce connection class to separate system traffic (5 commits)
[ ] #39669 rpc: use gRPC enforced minimum keepalive timeout
[ ] #37361 rpc: add heartbeat metrics
[ ] #41633 release-19.2: storage: treat non-voter replicas as suspect for replica GC
[ ] #41475 release-19.2: server: add metric for number of disk stalls detected
[ ] #35547 pgwire: add counter metric to track number of incoming connections

Arseni Lapunov: @jordanlewis

[ ] #38454 sql: require super user return status
[ ] #41157 sql: replace assert with error in EXPERIMENTAL_RELOCATE
[ ] #39211 sql: change privilege check error message (superuser to admin role)
[ ] #39412 cli: add default ballast size of 1GB

Daniel Harrison: @danhhz

[x] #37080 workloadccl: hook --csv-server flag up to fixtures import too
[x] #37701 workloadcccl: fix two regressions in fixtures make/load
[x] #35349 workload: allow columnar data generation (alloc -73%, MB/s +60%)
[x] #38208 workload/tpcc: pre-compute random data for initial data load strings
[x] #37515 workload/tpcc: make uuid generation deterministic
[x] #38206 workload/tpcc: make initial data generation totally deterministic
[x] #38203 workload/movr: better fake data generation
[x] #39719 workload/bank: batch initial row generation
[x] #40253 storage: remove kv.learner_replicas.enabled cluster setting
[x] #38485 importccl: fix fixtures import progress tracking
[x] #37030 changefeedccl: log more details when returning with non-retryable errors

Ben Darnell, Darin Peshev: @bdarnell @darinpp

[ ] #41571 release-19.2: backport unsafe-remove-dead-replicas tool for multiple stores (4 commits)

Darin Peshev: @darinpp

[ ] #41164 storage: fix an error message when trying to backup to local drive on…
[ ] #37168 server: ensure first node status written within Server.Start()
[ ] #41160 rocksdb: incorrectly identifying not found folder error on windows
[ ] #41624 release-19.2: storage: prevent even replica count if cannot progress to odd count

David Taylor: @dt

[x] #37343 workload: use IMPORT then BACKUP in 'fixtures make'
[x] #41196 store,bulk: log when delaying AddSSTable, collect + log more timings in bulk-ingest (2 commits)
[x] #39723 sqlbase: generalize IMPORTING state to OFFLINE
[x] #41767 release-19.2: libroach: bump up rocksdb backpressure limits
[x] #41755 release-19.2: backupccl: add setting to use TBI
[x] #41766 release-19.2: add metrics for pending compactions and sstable delays (2 commits)
[x] #37450 parser: Add IMPORT INTO prototype syntax (2 commits)
[x] #37451 importccl: prototype support for IMPORT INTO
[x] #39992 importccl: avoid double ProducerDone call (2 commits)
[x] #37466 engine: remove stray unused setting
[x] #40510 debug-zip: include raw job and schema info
[x] #40243 bulk: split-and-scatter when SSTBatcher 'fills' range (3 commits)
[x] #41194 batcheval: fix empty-span fast-path in AddSSTable collision check
[x] #40643 backupccl: allow backups with proto named BACKUP_MANIFEST

Jeffrey Xiao: @jordanlewis

[ ] #37804 workload/ycsb: support workload D, E and fix key selection for insertion and reading (4 commits)
[ ] #39430 workload/ycsb: implement read-modify-write
[ ] #37958 workload/ycsb: fix key acknowledgement race conditions (2 commits)
[ ] #38043 workload/ycsb: add --insert-start, --insert-count, --record-count options
[ ] #39525 workload/ycsb: Use StmtContext instead of Stmt
[ ] #38418 storage: fix null pointer dereference in AdminMerge
[ ] #38221 sql: remove manually split ranges during TRUNCATE and DROP
[ ] #38433 sql: fix swallowing Unsplit error
[ ] #38323 cli: override system zone config in cockroach demo
[ ] #39276 c-deps: bump rocksdb for IngestExternalFiles overlapping check fix
[ ] #38079 bulk: use expiration time to disable automatic merging in import, backfill, restore (2 commits)

Jordan Lewis, Lucy Zhang: @jordanlewis @lucy-zhang

[x] #39383 sql: use new foreign key representation (2 commits)

Jordan Lewis, Nathan VanBenschoten: @jordanlewis @nvanbenschoten

[x] #26433 sql: support max_identifier_length variable

Jordan Lewis: @jordanlewis

[ ] #39184 tree: to_json returns proper field names
[ ] #40267 tree: make int::regtype::text O(1)
[ ] #38185 stats: don't try to make stats for dropped tables
[ ] #39451 sqlbase: upgrade method can deal with mixed upgraded/old descriptors
[ ] #39173 sqlbase,cluster: add new FK representation, upgrade/downgrade methods, and a new cluster version (4 commits)
[ ] #37068 sql: show string values for enum cluster settings
[ ] #37104 sql: prevent crash during logging with empty statement
[ ] #38184 sql: fix scrub on tables with mixed case
[ ] #31713 sql: don't re-decode index keys when unnecessary (2 commits)
[ ] #38869 sql: compatibility blitz for pgadmin (17 commits)
[ ] #37164 sql: bugfix for planning of wrapped values nodes
[ ] #37210 sql: add oid column to pg_extension
[ ] #39448 sql: add fk downgrade path for mixed version clusters
[ ] #39351 rowcontainer: fix iterator leak on creation error
[ ] #39441 row: fix decoding bug with cfetcher and wide rows
[ ] #38787 row: bugfixes to cfetcher (2 commits)
[ ] #41420 release-19.2: sql,opt: re-enable 1pc for small delRange ops
[ ] #40197 pgwire: improve multiple portal error msgs
[ ] #38187 pgwire: fix verbose logging in conn.go
[ ] #40259 execerror: handle panics from pkg/col and children
[ ] #40565 exec: make the output of explain(vec) more compact
[ ] #38983 exec: fix output types for projections
[ ] #40511 exec: fix explain(vec) for queries with subqueries
[ ] #38512 exec: fix bug in ordered aggregate planning
[ ] #38956 exec: dump stack trace for unexpected internal errors
[ ] #38724 exec: bugfix to sort operator
[ ] #40756 exec: bugfix to constNull op; add tests
[ ] #39266 exec: bugfix to const operator
[ ] #40577 exec: bugfix to CASE operator with no input (2 commits)
[ ] #39043 distsqlrun: lookup join efficiency improvements (4 commits)
[ ] #40203 builtins: fix bug in aclexplode; add tests

Justin Jaffray: @justinj

[ ] #38270 sql: prohibit offset with GROUPS containing vars
[ ] #39062 opt: support view and sequence numeric refs
[ ] #39052 opt: compute join output col map properly
[ ] #39120 opt: add support for DELETE FK checks
[ ] #39751 opt: add FK checks for UPDATE statements

Lucy Zhang: @lucy-zhang

[x] #39614 sql: make FK schema changes backward-compatible with 19.1
[x] #35742 sql: improve inverted index validation performance
[x] #38377 sql: fix double-adding FK backreferences when retrying
[x] #41501 release-19.2: backupccl: fix sanitizeLocalityKV() char handling
[x] #39757 backupccl: fix backup/restore after FK table descriptor changes
[x] #39374 backupccl: add 19.2 version gate for partitioned backup

Nathan VanBenschoten: @nvanbenschoten

[x] #39106 workloadccl: inject table statistics during fixtures load
[x] #37617 workloadccl: fix multi-table fixture generation
[x] #40519 workload: ignore syntax error on INJECT STATISTICS against v2.0
[x] #41354 workload: don't panic on limiter error
[x] #36855 workload/tpcc: support replicated indexes and lease partitioning (3 commits)
[x] #36854 workload/tpcc: improve indexing to permit better partitioning (6 commits)
[x] #39649 workload/tpcc: fix --partition-affinity flag (3 commits)
[x] #38834 workload/tpcc: avoid validating foreign keys after dataset generation
[x] #40518 storage: don't perform one-phase commit transactions after restarts (5 commits)
[x] #41171 storage: don't crash when applying side-effects of old ChangeReplicas trigger
[x] #41148 storage: don't crash when applying ChangeReplicas trigger with DeprecatedNextReplicaID
[x] #41278 storage: don't count uninitialized replicas in ReplicaCount metric
[x] #38122 storage: don't bump tscache on successful CPut/InitPut requests
[x] #39003 storage: continue sending ReplicaState.TxnSpanGCThreshold to 19.1 nodes
[x] #37807 storage/txnrecovery: add transaction recovery metrics (2 commits)
[x] #36744 storage/rangefeed: use fine-grained locking around Processor, add metrics (3 commits)
[x] #37777 settings: move parallel commits behind cluster version gate
[x] #41427 release-19.2: sql: don't allocate phaseTimes on each call to sqlStatsCollector.reset
[x] #41426 release-19.2: sql/pgwire: avoid new memory allocation in writeTextDatum(Date)
[x] #40356 kv: unwrap MixedSuccessError even when retry attempts exhausted (2 commits)
[x] #36012 kv: support STAGING transactions in kv protocol and client (11 commits)
[x] #37719 kv: finish and enable parallel commits (3 commits)
[x] #41104 kv: check for 1-phase commit after request, not before

Nikhil Benesch, Raphael 'kena' Poss: @knz

[x] #38345 deps: bump go-libedit

Nikhil Benesch: @knz @bobvawter

[x] #39315 ui: upgrade jsdoc version to allow Node 12
[x] #37705 server: handle new behavior of setrlimit on macOS
[x] #38400 deps: configure and build patched libedit redux (2 commits)

Paul Bardea: @pbardea

[x] #40676 sql: stop presplitting spans on every import proc
[ ] #40996 sql: fix lease interaction with offline tables
[x] #40285 sql: Allow zone configs on offline tables
[ ] #41706 release-19.2: sql: stop logging table does not exist upon GC
[x] #40439 jobs: ensure that async index dropping is needed
[x] #39698 backupccl: create tables at start of restore

Radu Berinde: @RaduBerinde

[x] #39439 sql: optimizer always on (2 commits)
[x] #40689 sql: designate optimizer_foreign_keys as experimental
[x] #40307 sql: add cluster setting for opt-driven FK checks, rename experimental_enable_zigzag_join (2 commits)
[x] #37572 sql: add IGNORE_FOREIGN_KEY table hint
[x] #38749 opt: use SQLString for histogram data type
[x] #39364 opt: turn optimizer on in schema changer
[x] #38827 opt: specify hash joins in EXPLAIN (OPT)
[x] #40617 opt: fix scalar building error handling
[x] #38570 opt: fix panic recovery for error handling
[x] #41187 opt: fix hidden column handling for WITH
[x] #40217 opt: fix errors due to check constraints; copy cascade tests (2 commits)
[x] #41129 distsql: put the SQL into diagrams
[x] #41257 distsql: join UNION ALL streams on a single node
[x] #40212 distsql: better trace events for joinreader

Rafi Shamim: @rafiss

[x] #40646 ui: update wording of tooltip for transactions chart
[x] #41042 tree: fix LIKE suboperator with NULL LHS
[x] #40379 tree: allow decimals with any number of decimal places
[x] #40757 sql: fix: EXPLAIN checks for VectorizeRowCountThreshold
[x] #40885 sql: add telemetry for when distsql/vectorized is used

Raphael 'kena' Poss: @knz

[x] #39685 workload/tpcc: extend --wait to also support fractions
[x] #37800 sql: fix schema change auto-retry upon node failures
[x] #37802 sql/row: use assertion failures instead of panics
[ ] #38762 sql/exec: detail error objects when printing out warnings
[x] #37805 server: print error details upon startup failures
[x] [#unknn][#unown] release-19.2: sql: link to issue #42061 from the XXA00 error h… (#42090)
[x] #37795 opt: use assertion failures where appropriate
[x] #37367 distsqlpb: whitelist node unavailability errors (2 commits)
[x] #39492 cli: use zone configs to disable replication
[x] #39378 cli/zip: use "cockroach zip" as application name

Rebecca Taft: @rytaft

[ ] #39325 stats: fix distinct count estimation for histograms with wide buckets
[ ] #39178 stats,opt: performance improvements for histograms (2 commits)
[ ] #37983 opt: fix issue with dangling pointer in statisticsBuilder
[ ] #40523 opt: fix functional deps and stats for WithScanExpr
[ ] #38624 opt: fix floating point precision error in statisticsBuilder
[ ] #40488 opt: fix error due to more than one column in subquery
[ ] #37913 opt: fix error due to distinct and/or null count must be non-zero
[ ] #38229 opt: fix distinct count estimation for outer joins
[ ] #40494 opt: fix calculation of stats for join when right side has 0 cardinality
[ ] #38730 opt: fix another floating point precision error in statisticsBuilder
[ ] #39606 distsqlrun: fix panic due to multiple calls to tracing.FinishSpan
[ ] #39738 distsqlrun: fail gracefully if out of memory during stats creation
[ ] #39144 distsqlrun,stats: add memory accounting to sampler and sampleAggregator

Rohan Yadav: @rohany

[x] #40880 sqltelemetry,sql: Add telemetry for partitioning related improvements
[x] #38301 sql: Tighter spans for column families in lookup and index joins
[x] #40417 sql: Remove unnecessary constraints check in show create
[ ] #39543 sql: More descriptive error messages in show partitions
[ ] #40450 sql: Fixing show partitions and show ranges to work on not current database
[ ] #38435 sql: Fixing interleave check for loose index scan
[ ] #38899 sql: Fixing bug in tighter span generation for lookup join.
[ ] #39824 sql: Fix bug with negative parsing validation for zone constraints
[x] #39199 sql: Fix bug where dropping table didn't drop corresponding zone config.
[ ] #39822 sql: Fix bug in zone constraint validation for attributes.
[ ] #39833 sql: Bugfixes and increased tests for IndexSkipTableReader
[x] #40839 sql: Add telemetry for some partitioning UX improvements
[x] #40914 sql: Add telemetry for interleaved table join
[ ] #38459 sql: Add support for reverse loose index scans
[x] #39060 sql: Add locality information to SHOW EXPERIMENTAL_RANGES
[ ] #40844 row: Add a check for integrity of neededValueColsByIdx in row fetcher
[x] #41138 movr: Add stats collection to movr workload run
[ ] #38959 exec: Fixing panics in cfetcher logging.
[ ] #38908 exec: Fix type ambiguity error out for IN and NOT IN.
[ ] #39027 exec: Fix test case TestTraceFieldDecomposition.
[ ] #38612 exec: Fix bug in test case generation causing NULLs not to be reset between batches
[ ] #40657 exec: Fix NULL expression handling in CASE and AND operators
[x] #40495 exec: Bug fixes in vectorized casts
[ ] #38796 exec: Add memory estimation and monitoring for streaming operators.
[x] #38938 exec: Add informative k/v tracing to cfetcher.
[ ] #40691 distsqlrun: Ignore breaker when outbox dials node
[x] #40883 demo: Add telemetry about usage of new demo features.
[ ] #39786 cli: Extending locality assignment for cockroach demo nodes

Sean Loiselle: @nvanbenschoten

[ ] #38008 server: add metadata for cloud provider region to diagnostics
[ ] #37272 server: add metadata for cloud provider and instance class to diagnostics
[ ] #39803 allow TPC-C partition behavior for clients when data is not partitioned
[ ] #27505 admin: Add Chart Catalog infrastructure

Solon Gordon: @solongordon

[x] #39154 sql: warn when creating non-partitioned index
[x] #39750 sql: support wildcard in ALTER PARTITION OF INDEX
[x] #40800 sql: improve error message for constraint parsing
[x] #41212 sql: fix bug with needed column families and nulls
[x] #39404 sql: change zone name syntax to match SQL
[x] #40650 sql: backward compat for ALTER PARTITION OF TABLE
[x] #40812 sql: another syntax hint for ALTER PARTITION
[x] #40720 sql: add hint for ALTER PARTITION OF INDEX error
[x] #40709 sql: add a syntax hint for ALTER PARTITION
[x] #41762 release-19.2: colexec: fix null handling for LIKE '%'
[x] #37405 exec: fix nulls for composite index columns
[x] #38912 exec: fix float comparison for -0
[x] #38217 exec: fix TestSortRandomized flakes
[x] #38881 exec: fix NaN comparison logic
[x] #38911 exec: fix LIKE handling for patterns like '%a%'
[x] #38607 exec: don't panic on unhandled datum conversion
[x] #38816 exec: bail out on mixed type expressions

Spas Bojanov: @spaskob

[ ] #40288 jobs: make new index backfill status tracking bwd compatible
[ ] #39773 jobs: improve the status reporting of index backfill jobs
[ ] #41172 jobs: clean running jobs with no mutations left
[ ] #40345 importccl: fix mysqqoutfile import bug

Tobias Schottdorf: @tbg

[x] #40415 storage: fix two botched migrations (2 commits)
[x] #39697 storage: fix replica removal when learners not active
[x] #37868 storage: fix checksum version check (3 commits)
[x] #37986 storage: avoid deadlock on (*Stopper).Quiesce
[x] #39658 storage: avoid crash in splitPostApply
[x] #39936 storage: add (default-off) atomic replication changes (22 commits)
[x] #37204 rpc: don't leave poison zero-nodeID connections in pool
[x] #39656 kv: init heartbeat txn log tag later
[x] #38108 cluster: remove and test against obsolete versions (24 commits)
[x] #41628 backport-19.2: storage: retry splits more
[x] #41759 backport-19.2: storage: remove two sources of stats inconsistencies (2 commits)
[x] #41758 backport-19.2: builtins: allow full consistency check w/o nuking cluster

Yahor Yuzefovich: @yuzefovich

[x] #37556 workload: minor improvements to querybench and adding TPCH vec benchmark
[x] #37465 workload: add TPC-DS queries and workload
[x] #38002 sql: track bytes and rows read unconditionally for every statement
[x] #38836 sql: speed up aggregates as window functions in some cases
[x] #40803 sql: replace an internal error in EXPLAIN (DISTSQL) and EXPLAIN (VEC)
[x] #39285 sql: remove 'experimental_always' as an option for vectorize cluster setting
[x] #39686 sql: make sure that typ field of DTuple is initialized when used as JSON
[x] #37222 sql: fix window functions with GROUPS offset FOLLOWING
[x] #37251 sql: fix semantic analysis and type checking of window functions
[x] #39785 sql: fix has_column_privilege builtin
[x] #37130 sql: fix checking for presence of window functions in some edge cases
[x] #39086 sql: fix a bug with ordinality planning
[x] #38849 sql: display postqueries in EXPLAIN
[x] #38281 sql: add support for executing postqueries
[x] #38839 sql: account for memory of results of window functions computations
[x] #41095 sql/parser: adjust the precedence of JSONB operators
[x] #41503 release-19.2: colexec: fix projections of AND and OR operators when NULLs are present (3 commits)
[x] #42239 release-19.2: colexec: fix AND and OR projections in some cases
[x] #37106 exec: fix possible infinite loops in the benchmark
[x] #38767 exec: fix planning of count operator
[x] #39294 exec: fix output batches of LEFT SEMI for hash and merge joiners
[x] #38385 exec: fix null handling in merge joiner
[x] #39007 exec: fix handling of empty table by aggregates
[x] #38806 exec: fix decoding of OID type
[x] #38972 exec: fix calculation of selectivity stat when num batches is zero
[x] #38629 exec: fix an error with vectorized testing infrastructure
[ ] #38941 exec: fix a panic with sum_int aggregate with input types other than Int64 (2 commits)
[x] #39302 exec: fix a bug with ordinality
[x] #40651 exec: fix a bug with ON expression support for joiners
[x] #38809 exec: fallback to distsql on aggregator with no aggregate functions
[x] #40610 exec: explicitly check for nulls in selBoolOp
[x] #37294 exec: catch panics coming from colBatchScan operator
[x] #38949 exec: catch panics coming from CFetcher and columnarizer
[x] #36967 exec: add cancellation check to operators
[x] #38777 exec: add "auto" vectorize setting and make it default (2 commits)
[x] #40340 distsqlrun: make windower respect the memory limits (2 commits)
[x] #40560 distsqlrun: make indexJoiner and joinReader show up in EXPLAIN (VEC)
[x] #40995 colexec: fix projections of joiners (3 commits)

Thanks for doing this @knz!

#39439 sql: optimizer always on (2 commits): (sql change): The optimizer setting is now deprecated and the only valid setting is "on".
#40307 sql: add cluster setting for opt-driven FK checks, rename experimental_enable_zigzag_join (2 commits): (sql change): Zig-zag join is now allowed by default. This can be controlled via the enable_zigzag_join session setting. Note: more recently, we also added a corresponding sql.defaults.zigzag_join.enabled cluster setting (in #42182).
#38827 opt: specify hash joins in EXPLAIN (OPT): (sql change): EXPLAIN (OPT) now explicitly specifies hash join (before, this was implicit whenever merge / lookup was not specified).
#40617 opt: fix scalar building error handling: (bug fix): Fixed a bug that could result in internal errors of the form "cannot map variable to an indexed var".
#40217 opt: fix errors due to check constraints; copy cascade tests (2 commits): (bug fix) Fixed a bug that could result in undefined column errors in some cases when using numeric table references.
#41129 distsql: put the SQL into diagrams: (interface improvement) EXPLAIN (DISTSQL) and EXPLAIN (ANALYZE) now shows the SQL query in the diagram page.

I have a slight dislike the framing of this and the implication that use of ‘none’ can just be assumed to be mistaken.
There seems to be an assumption here that one commit = one user-facing-change, but one big monster commit is not how we usually want to go about building big new features. Many cases above include many commits working towards implementing one new user-visible feature — there is no reason for those to have individual release notes. In other cases it they are fixing bugs but in similarly unreleased functionality and thus again, are not user-visible changes.

The release notes in the PRs are meant to be accurate between alpha releases, so it is reasonable to document small changes that are part of a bigger new feature (though I agree it's not terribly useful to provide a lot of detail). How these get massaged into the release notes for a major release is not trivial - the improvements related to a bigger change do need to be coalesced into one item.

There seems to be an assumption here that one commit = one user-facing-change, but one big monster commit is not how we usually want to go about building big new features. Many cases above include many commits working towards implementing one new user-visible feature — there is no reason for those to each have individual release notes as they are not changing an existing user-visible feature.

David, I stand behind your view here. I have been careful to de-duplicate entries and collapse multiple PRs that are part of a larger whole under a single entry (for example, I removed all the "opt: implement X or Y" entries because they all fall under "remove the heuristic planner", which was documented eventually). I did the same with various IMPORT FROM PRs.
Unfortunately it is hard for me to be 100% accurate so I apologize if I forgot to collapse some groups.

Thank you for driving this, @knz. Since our Eng team has grown so much, I had a nagging worry that many user-facing changes weren't getting flagged for announcement and documentation. At the end of this exercise, we'll have a clear sense of that.

(bug fix) #38345 A bug where recalling past history entries spanning multiple lines would cause a corrupted display in cockroach demo and cockroach sql has been corrected.

(cli change) #39685 The command workload run tpcc now supports --wait with a fractional value to configure how much to wait between queries relative to the delays mandated by the TPC-C specification.

(bug fix) #37800 Fix a bug where a shema change would fail, and not be retried, if a node was disconnected while the schema change is running. This bug had been introduced in a 19.2 alpha release.

(sql change) #38762 CockroachDB will now produce more details when printing out some internal error in the log files, to ease troubleshooting.

(cli change) #37805 cockroach start will now produce more details if a node fails to start, to ease troubleshooting.

(cli change) #39492 cockroach start-single-node and cockroach demo with a single configured node will now use  zone configs to disable replication.

(bug fix) #39378 cockroach zip will now use properly the application name "cockroach zip" when establishing SQL connections instead of "cockroach sql", to clarify recognition of its activities in statement statistics.

(build changes) #39315 It is now possible to build CockroachDB with Node 12.

(bug fix) #37705 Fixed a bug where CockroachDB was unable to verify the maximum number of open file descriptors on macOS.

(build change) #39121 Allow building CockroachDB with Clang 11.x (llvm 8.x)

(telemetry change) #40880 report when ALTER ALL PARTITIONS is used
(sql change) #38301 lookup and index joins now generate column family specific spans for point lookups
(sql change) #40417 show create table does not omit zone configuration information if constraints is empty
(bug fix) #39199 fixed a bug where zone configurations of dropped tables would still be displayed
(telemetry change) #40883 add telemetry for cockroach demo flags "--nodes", "--demo-locality",  "--with-load" and "--geo-partitioned-replicas"
(sql change) #39060 adds locality information to the output of SHOW RANGES
(sql change) #38938 adds K/V tracing output for vectorized execution
(telemetry change) #40914 adds telemetry for usages of the interleaved table join
(telemetry change) #40839 adds telemetry for usages of SHOW PARTITIONS, SHOW RANGES, SHOW LOCALITY and SHOW CREATE TABLE
(workload change) #41138 adds stats collection to the movr workload

#39246 (sql change) The crdb_internal.force_retry() builtin function can now be run by non-root users.
#37140 (admin ui change) Dummy Raft commands no longer skew the Raft Commit Latency metrics downwards artificially.
#37140 (admin ui change) The Raft Commit Latency graphs now include a 50%-ile measurement in addition to 99%-ile.
#40735 (bug fix): A crash during the generation of the system.replication_ reports was fixes.
#41935 (general change): Cockroach nodes now identify themselves as version 19.2 through the crdb_internal.node_executable_version() function.
#37412 (general changes): The heuristics deciding when to generate heap memory profiles have been changed to capture heaps in more interesting memory growth situations.
#41439 (bug fix): Fix a bug causing the cluster_logical_timestamp() function to sometimes return incorrect results.

Done, but I think we should have a conversation about what changes are worthy to be included in release notes. For one, I enjoy reading release notes for software, but not if they're endless. I'm afraid that activism like this, coupled with more and more monkeys banging on this, will lead to a million bullets of very varying degrees of importance.

#41764: Release note (bug fix): Previously a disk stall could allow a node to continue heartbeating its liveness record and prevent other nodes from taking over its leases, despite being completely unresponsive.

#40948: Release note (bug fix): Fix the outdated message if AOST is used by a query inside a transaction block. Prompts the user to use the "SET TRANSACTION AS OF SYSTEM TIME" syntax.

#39662 https://github.com/cockroachdb/cockroach/pull/39662 workload:
fall back to using 19.1 vectorize setting on syntax error. Release note
(bug fix): The querybench workload has been modified to use the correct
syntax for vectorized execution in 19.1, attempting to run this workload
with vectorized execution would previously return an error.
#41467 https://github.com/cockroachdb/cockroach/pull/41467
release-19.2:
colrpc: downgrade log messages from Error to Warning. Release note (bug
fix): Some log messages reported as Errors have been downgraded to Warnings.
#37088 https://github.com/cockroachdb/cockroach/pull/37088 exec:
wrap hashRouter work with CatchVectorizedRuntimeError. Release note (bug
fix): An expected panic in the vectorized engine is now reported as an
error without crashing the server.
#39093 https://github.com/cockroachdb/cockroach/pull/39093 exec:
wait for internal goroutine completion in UnorderedSynchronizer. Release
note (bug fix): A race condition in the vectorized engine has been fixed.
#38006 https://github.com/cockroachdb/cockroach/pull/38006 exec:
set output columnTypes when creating noop operator. Release note (bug fix):
A bug planning noop operators in the vectorzied execution engine has been
fixed.
#40668 https://github.com/cockroachdb/cockroach/pull/40668 exec:
reset internal unsafeBatch in orderedAggregator. Release note (bug fix): A
bug with vectorized aggregations due to incorrect state transitions has
been fixed.
#38557 https://github.com/cockroachdb/cockroach/pull/38557 exec:
protect against unset syncFlowConsumer. Release note (bug fix): A
vectorized engine plan-time state assertion was added to avoid a panic.
#39248 https://github.com/cockroachdb/cockroach/pull/39248 exec:
fix metadata drain cycles. Release note (bug fix): A bug that led to
queries hanging in the vectorized engine due to incorrect plans has been
fixed.
#37571 https://github.com/cockroachdb/cockroach/pull/37571 exec:
check for unset output columnTypes. Release note (bug fix): A vectorized
engine plan-time state assertion was added.
#38329 https://github.com/cockroachdb/cockroach/pull/38329 distsqlrun:
include StartScan stall time in EXPLAIN ANALYZE. Release note (sql change):
EXPLAIN ANALYZE now reports the time taken to look up rows in a lookup join.
#38622 https://github.com/cockroachdb/cockroach/pull/38622 distsqlrun:
bump index joiner batch size from 100 to 10k. Release note (performance
improvement): Index join performance has been improved.
#37745 https://github.com/cockroachdb/cockroach/pull/37745
col{data,serde}:
various fixes related to TestArrowBatchConverterRandom (2 commits). Release
note (bug fix): A bug in data serialization in the vectorized engine caused
by incorrectly determining the presence of nulls in rows has been fixed.

On Mon, Nov 11, 2019 at 10:48 AM irfan sharif<EMAIL_ADDRESS>wrote:

#41764: Release note (bug fix): Previously a disk stall could allow
a node to continue heartbeating its liveness record and prevent other nodes
from taking over its leases, despite being completely unresponsive.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cockroachdb/docs/issues/5819?email_source=notifications&email_token=ACQSGZ7AXGRGIKBUZ2XGSMTQTF5FTA5CNFSM4JLMNMWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXHLPY#issuecomment-552498623,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQSGZ4EXRRJXSGT26KTAWLQTF5FTANCNFSM4JLMNMWA
.

--
Alfonso

Spas Bojanov:

#40288 https://github.com/cockroachdb/cockroach/pull/40288 jobs:
make new index backfill status tracking bwd compatible. Release note (bug
fix): this was introduced by #39773 which will cause backfill to crash when
running on cluster with upgraded nodes.
#39773 https://github.com/cockroachdb/cockroach/pull/39773 jobs:
improve the status reporting of index backfill jobs. Release note (bug
fix): fixes #36601.
#41172 https://github.com/cockroachdb/cockroach/pull/41172 jobs:
clean running jobs with no mutations left. Release note (bug fix): fixes
#40563.
#40345 https://github.com/cockroachdb/cockroach/pull/40345 importccl:
fix mysqqoutfile import bug. Release note (bug fix): When importing from
csv if the number of fields is less than the columns in the schema the
server will panic.

On Tue, Nov 12, 2019 at 12:22 AM Alfonso Subiotto Marqués <
<EMAIL_ADDRESS>wrote:

#39662 https://github.com/cockroachdb/cockroach/pull/39662 workload:
fall back to using 19.1 vectorize setting on syntax error. Release note
(bug fix): The querybench workload has been modified to use the correct
syntax for vectorized execution in 19.1, attempting to run this workload
with vectorized execution would previously return an error.
#41467 https://github.com/cockroachdb/cockroach/pull/41467
release-19.2:
colrpc: downgrade log messages from Error to Warning. Release note (bug
fix): Some log messages reported as Errors have been downgraded to
Warnings.
#37088 https://github.com/cockroachdb/cockroach/pull/37088 exec:
wrap hashRouter work with CatchVectorizedRuntimeError. Release note (bug
fix): An expected panic in the vectorized engine is now reported as an
error without crashing the server.
#39093 https://github.com/cockroachdb/cockroach/pull/39093 exec:
wait for internal goroutine completion in UnorderedSynchronizer. Release
note (bug fix): A race condition in the vectorized engine has been fixed.
#38006 https://github.com/cockroachdb/cockroach/pull/38006 exec:
set output columnTypes when creating noop operator. Release note (bug fix):
A bug planning noop operators in the vectorzied execution engine has been
fixed.
#40668 https://github.com/cockroachdb/cockroach/pull/40668 exec:
reset internal unsafeBatch in orderedAggregator. Release note (bug fix): A
bug with vectorized aggregations due to incorrect state transitions has
been fixed.
#38557 https://github.com/cockroachdb/cockroach/pull/38557 exec:
protect against unset syncFlowConsumer. Release note (bug fix): A
vectorized engine plan-time state assertion was added to avoid a panic.
#39248 https://github.com/cockroachdb/cockroach/pull/39248 exec:
fix metadata drain cycles. Release note (bug fix): A bug that led to
queries hanging in the vectorized engine due to incorrect plans has been
fixed.
#37571 https://github.com/cockroachdb/cockroach/pull/37571 exec:
check for unset output columnTypes. Release note (bug fix): A vectorized
engine plan-time state assertion was added.
#38329 https://github.com/cockroachdb/cockroach/pull/38329 distsqlrun:
include StartScan stall time in EXPLAIN ANALYZE. Release note (sql change):
EXPLAIN ANALYZE now reports the time taken to look up rows in a lookup
join.
#38622 https://github.com/cockroachdb/cockroach/pull/38622 distsqlrun:
bump index joiner batch size from 100 to 10k. Release note (performance
improvement): Index join performance has been improved.
#37745 https://github.com/cockroachdb/cockroach/pull/37745
col{data,serde}:
various fixes related to TestArrowBatchConverterRandom (2 commits). Release
note (bug fix): A bug in data serialization in the vectorized engine caused
by incorrectly determining the presence of nulls in rows has been fixed.

On Mon, Nov 11, 2019 at 10:48 AM irfan sharif<EMAIL_ADDRESS>wrote:

#41764: Release note (bug fix): Previously a disk stall could allow
a node to continue heartbeating its liveness record and prevent other
nodes
from taking over its leases, despite being completely unresponsive.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/cockroachdb/docs/issues/5819?email_source=notifications&email_token=ACQSGZ7AXGRGIKBUZ2XGSMTQTF5FTA5CNFSM4JLMNMWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXHLPY#issuecomment-552498623
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ACQSGZ4EXRRJXSGT26KTAWLQTF5FTANCNFSM4JLMNMWA
.

--
Alfonso
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cockroachdb/docs/issues/5819?email_source=notifications&email_token=AANL635GCJRAF2GECKWGYBDQTGBF7A5CNFSM4JLMNMWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXKWQQ#issuecomment-552512322,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AANL637KSPBTOLESRUX35EDQTGBF7ANCNFSM4JLMNMWA
.

#39325 (bug fix): Fixed the distinct count estimation for wide buckets during histogram collection for use by the query optimizer.
#39178 (performance improvement): Reduced the performance overhead of using histograms during query planning.
#37983 (bug fix): Fixed a dangling pointer issue with statistics calculation that could cause an internal error during query planning.
#40523 (bug fix): Fixed an issue with calculation of logical properties for WITH expressions that could cause an internal error during query planning.
#38624 (bug fix): Fixed a floating point precision error in the statistics estimation code that could cause an internal error during query planning.
#40488 <- Only added a test -- no release note needed
#37913 (bug fix): Fixed an issue with calculating null counts and distinct counts for statistics estimation that could cause an internal error during query planning.
#38229 (bug fix): Fixed an issue with distinct count estimation for outer joins that could cause an internal error during query planning.
#40494 (bug fix): Fixed a divide-by-zero error in the statistics estimation code that could cause an internal error during query planning.
#38730 (bug fix): Fixed a floating point precision error in the statistics estimation code for SELECT and JOIN expressions that could cause an internal error during query planning.
#39606 (bug fix): Fixed a panic that could occur due to multiple calls to tracing.FinishSpan during table statistics collection.
#39738 (bug fix): Fixed the table statistics collection logic to disable collection of histograms in case of high memory utilization so that row counts, null counts, and distinct counts can still be collected without interruption.
#39144 (bug fix): Added memory accounting to the table statistics collection code to prevent it from using too much memory and possibly causing an out-of-memory error.

#39192 (telemetry change): Telemetry is collected each time a split occurs because of excess load.
#37404 (sql change): Add array and tuple constant folding rules to the optimizer.

Done, but I think we should have a conversation about what changes are worthy to be included in release notes. For one, I enjoy reading release notes for software, but not if they're endless. I'm afraid that activism like this, coupled with more and more monkeys banging on this, will lead to a million bullets of very varying degrees of importance.

I generally think release notes should be as comprehensive as possible. They're not necessarily read, but it's important that they be searchable. If the notes are too large (as they are for a full release), this should be addressed with a separate summary document instead of dropping details. (I like python's what's new/changelog split)

#38122 (performance improvement): INSERT statements no longer add a record to the in-memory timestamp cache. This helps keep the cache empty on INSERT-heavy workloads.
#37807 (telemetry change): Transaction status recovery metrics are now available.
#41427 (performance improvement): Avoid memory allocations when using the DATE data type.
#37719 (performance improvement): Transactions now use the new Parallel Commits atomic commit protocol, which halves transaction latency. See https://www.cockroachlabs.com/blog/parallel-commits/.

#41571 (cli change) cockroach debug unsafe-remove-dead-replicas can now
recover ranges with more than one remaining live replica
#41164 (bug fix) fixed a bug when trying to backup to local drive in the
Windows version
#37168 (bug fix) fixed a race condition affecting tests where the node
status is not written before the node starts
#41160 (bug fix) fixed a rocksdb bug where the file not found error
message is interpreted incorrectly under Windows
#41624 (bug fix) fixed an allocator issue where a range upreplicates to
even number of replicas

On Mon, Nov 11, 2019 at 9:36 AM Ben Darnell<EMAIL_ADDRESS>wrote:

Done, but I think we should have a conversation about what changes are
worthy to be included in release notes. For one, I enjoy reading release
notes for software, but not if they're endless. I'm afraid that activism
like this, coupled with more and more monkeys banging on this, will lead to
a million bullets of very varying degrees of importance.
I generally think release notes should be as comprehensive as possible.
They're not necessarily read, but it's important that they be
searchable. If the notes are too large (as they are for a full
release), this should be addressed with a separate summary document instead
of dropping details. (I like python's what's new
https://docs.python.org/3/whatsnew/3.8.html/changelog
https://docs.python.org/3/whatsnew/changelog.html#changelog split)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cockroachdb/docs/issues/5819?email_source=notifications&email_token=ABVZ3FKE7L2UF2YSKRPO3B3QTGJYLA5CNFSM4JLMNMWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDXRPYA#issuecomment-552540128,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVZ3FNXQSZKAJOFI554DHTQTGJYLANCNFSM4JLMNMWA
.

#36032 Added a job status to indicate when a schema change to add a constraint is in the process of validating the constraint.
#39614 Fixed the implementation of ADD CONSTRAINT for foreign keys to be backward-compatible with 19.1.
#35742 Added a small optimization to the implementation of inverted index validation to reduce allocations.
#38377 Fixed a bug where a foreign key could attempted to be added more than once during an internal retry.
#41501 Fixed a bug where non-alphanumeric characters were not escaped in filenames for partitioned backups.
#39374 Added a check to ensure that partitioned backups can only be made on a cluster on which the upgrade to 19.2 has been finalized.

N/A: #39757 (fix for a bug that was never released), #39383 (no user-facing changes)

#39154 (cli change): In the CLI, creating a non-partitioned index on a partitioned table returns an error unless sql_safe_updates = false.
#39404 (sql change): Replication zone names are now displayed differently in the result of queries like SHOW ZONE CONFIGURATION. The name now matches how the target would be specified in a CONFIGURE ZONE statement. For instance, ".meta" is now displayed as "RANGE meta", and "movr.users.asia" is now "PARTITION asia OF TABLE movr.public.users".
I omitted PRs which didn't represent a user-visible change from 19.1 or weren't really of interest to users, like adding a HINT to an error message.

#40646 (admin ui change): Adjusted the wording of the tooltip on the transactions chart.
#41042 (bug fix): Fixed a server panic that could occur if a NULL value was present in the left-hand side of a suboperator with a LIKE comparison.
#40379 (sql change): We now allow decimals to have any number of decimal places.
#40885 (telemetry change): Added telemetry for when DistSQL and/or vectorized execution are used to execute a query.

Not adding notes for #40757, since that was a fix for a PR/feature that was added in this release, and that feature already has release notes.
Also, I noticed that the telemetry change category is being used a lot here, but that category is not documented in Confluence nor in the commit message template. Should we add it?

#40676 (bug fix): improve stability of bulk import by issuing less range split requests.
#40996 (bug fix): ensure that tables are always seen directly after a RESTORE.
#40285 (enterprise change): allow zone configs to be set on tables that are being restored.
#41706 (bug fix): stop logging incorrect warning message.
#40439 (bug fix): ensure that jobs are not redundantly doubly marked as successful.

#37343 workload: use IMPORT then BACKUP in 'fixtures make'

Release note (general change): workload fixtures make uses IMPORT to load data before backing it up, replacing complex and brittle manual construction of a raw BACKUP.

#41196 store,bulk: log when delaying AddSSTable, collect + log more timings in bulk-ingest (2 commits)

Release note (general change): slow requests during bulk-ingestion are now mentioned in log files.

#39723 sqlbase: generalize IMPORTING state to OFFLINE

N/A: not user-visible, plus change to only new 19.2 code.

#41767 release-19.2: libroach: bump up rocksdb backpressure limits

Release note (general change): Increased the limits on pending work imposed by RocksDB before it slows down processing.

#41755 release-19.2: backupccl: add setting to use TBI

N/A: Internal usage. Marked experimental and not intended for discovery/use by end-users.

#41766 release-19.2: add metrics for pending compactions and sstable delays (2 commits)

N/A: No user-visible change -- metrics are only accessible by manually finding it in debugging dashboard.

#37450 parser: Add IMPORT INTO prototype syntax (2 commits)

N/A: Development change -- documented later in IMPORT INTO docs.

#37451 importccl: prototype support for IMPORT INTO

N/A: development change -- documented later in IMPORT INTO docs.

#39992 importccl: avoid double ProducerDone call (2 commits)

N/A: Not user-visible.

#37466 engine: remove stray unused setting

Release note (general change): remove an extra rocksdb.ingest_backpressure.delay_l0_file  setting that was added but never used.

#40510 debug-zip: include raw job and schema info

Release note (telemetry change): debug-zip now includes machine-readable versions of schema and job info in addition to the existing human-readable versions.

#40243 bulk: split-and-scatter when SSTBatcher 'fills' range (3 commits)

Release note (performance improvement): data is more aggressively split and scattered to get more even allocation during bulk-ingestion.

#41194 batcheval: fix empty-span fast-path in AddSSTable collision check

N/A: Not user-visible.

#40643 backupccl: allow backups with proto named BACKUP_MANIFEST

N/A: Not user-visible.

#37556 workload: minor improvements to querybench and adding TPCH vec benchmark

Release note (general change): querybench workload now has an argument that specifies whether to use the vectorized engine.

#37465 workload: add TPC-DS queries and workload

Release note (general change): a new tpcds workload is added.

#38002 sql: track bytes and rows read unconditionally for every statement

Release note (sql change): bytes_read and rows_read fields have been added to node_statement_statistics virtual table.

#38836 sql: speed up aggregates as window functions in some cases

Release note (performance improvement): aggregates when used as window functions (with such window frames that all rows are always inside of the frame) are now computed in linear time instead of a quadratical.

#40803 sql: replace an internal error in EXPLAIN (DISTSQL) and EXPLAIN (VEC)

Release note (sql change): EXPLAINing a query (with DISTSQL or VEC option) that contains a subquery the result of which is needed to create the physical plan returns a more useful error instead of an internal error as it did previously.

#39285 sql: remove 'experimental_always' as an option for vectorize cluster setting

Release note (sql change): vectorize cluster setting no longer has experimental_always option.

#39686 sql: make sure that typ field of DTuple is initialized when used as JSON

N/A fixed a bug that was introduced a couple of weeks earlier

#37222 sql: fix window functions with GROUPS offset FOLLOWING

Release note (bug fix): window functions with a window frame as GROUPS BETWEEN offset FOLLOWING AND UNBOUNDED FOLLOWING are now handled correctly.

#37251 sql: fix semantic analysis and type checking of window functions

Release note (sql change): GROUPS mode of window framing now requires an ORDER BY clause and will error out if the latter is not provided.

#39785 sql: fix has_column_privilege builtin

Release note (bug fix): has_column_privilege builtin now works correctly in cases when columns are dropped.

#37130 sql: fix checking for presence of window functions in some edge cases

Release note (bug fix): previously, when a window function was a part of another expression
instead of being used directly within PARTITION BY and ORDER BY clauses of another window function, CRDB would crash while trying to execute it. Now such queries will be error out.

#39086 sql: fix a bug with ordinality planning

N/A not user-facing change.

#38849 sql: display postqueries in EXPLAIN

N/A part of the bigger optimizer-driven FK work

#38281 sql: add support for executing postqueries

N/A part of the bigger optimizer-driven FK work

#38839 sql: account for memory of results of window functions computations

Release note (bug fix): memory accounting for the result of computing of window functions is now being done correctly (previously it could lead to OOM crashes with array_agg and concat_agg being the most prone to it functions).

#41095 sql/parser: adjust the precedence of JSONB operators

Release note (sql change): the precedence of JSONB operators has been adjusted to better match PostgreSQL.

#41503 release-19.2: colexec: fix projections of AND and OR operators when NULLs are present (3 commits)

Release note (bug fix): AND and OR operators are now handled correctly by the vectorized execution engine when operating on NULLs.

#42239 release-19.2: colexec: fix AND and OR projections in some cases

N/A I'd say the release note for the PR one line above covers this.

#37106 exec: fix possible infinite loops in the benchmark

N/A not user-facing change.

#38767 exec: fix planning of count operator

Release note (bug fix): vectorized execution engine now correctly handles arithmetic operations that use count aggregate function as an operand.

#39294 exec: fix output batches of LEFT SEMI for hash and merge joiners

N/A not user-facing change.

#38385 exec: fix null handling in merge joiner

Release note (bug fix): an incorrect handling of NULL values in some cases while performing the merge join via the vectorized execution engine has been fixed.

#39007 exec: fix handling of empty table by aggregates

Release note (bug fix): vectorized execution engine now correctly handles aggregates over an empty table.

#38806 exec: fix decoding of OID type

Release note (bug fix): vectorized execution engine now correctly reads tables containing columns of OID type.

#38972 exec: fix calculation of selectivity stat when num batches is zero

N/A recent development bug.

#38629 exec: fix an error with vectorized testing infrastructure

N/A not user-facing change.

#38941 exec: fix a panic with sum_int aggregate with input types other than Int64 (2 commits)

Release note (bug fix): a crash would no longer occur when SUM aggregate is executed via the vectorized execution engine on integers other than INT8.

#39302 exec: fix a bug with ordinality

N/A recent development bug

#40651 exec: fix a bug with ON expression support for joiners

N/A recent development bug

#38809 exec: fallback to distsql on aggregator with no aggregate functions

N/A not user-facing change.

#40610 exec: explicitly check for nulls in selBoolOp

N/A recent development bug

#37294 exec: catch panics coming from colBatchScan operator

N/A not user-facing change

#38949 exec: catch panics coming from CFetcher and columnarizer

N/A not user-facing change

#36967 exec: add cancellation check to operators

N/A not user-facing change

#38777 exec: add "auto" vectorize setting and make it default (2 commits)

Release note (sql change): experimental_vectorize cluster setting and session variables have been renamed to vectorize. A new option auto is introduced for both of these and is made the default option; with auto, all "streaming" queries (i.e. those that do not need to buffer all temporary data before they can proceed - sorts, joins, etc) will now be executed via the vectorized engine. Options on and always have been renamed to experimental_on and experimental_always, respectively.

#40340 distsqlrun: make windower respect the memory limits (2 commits)

N/A not user-facing change.

#40560 distsqlrun: make indexJoiner and joinReader show up in EXPLAIN (VEC)

N/A recent development bug

#40995 colexec: fix projections of joiners (3 commits)

N/A recent development bug

@knz, @bdarnell, should we retroactively add these notes to their relevant release note pages? If so, I'll need authors to identify the releases. I suspect that's too much work, but I'm open to your guidance. More importantly, once all authors have completed their reviews here, I'll open docs issues, where relevant.

If ben and you decide that retroactive addition is the way to go, then we can automate the classification. That is not too much work.
However I am not sure this is the way to go? Or perhaps, not the only place where this should be reported: all the users that have already read the past release notes will not come across this new content. Maybe we should instead publish an "erratum" page specific to 19.2, even communicate it on the forum and perhaps other channels, and then  link to that page from the other release note pages for reference.

I meant "addendum" not "erratum".

Whatever we do here should be fairly quiet. https://www.cockroachlabs.com/docs/releases/v19.2.0.html is already a summary of the release, and if we were going to have a more detailed "addendum" it would primarily include the union of all the alpha/beta/rc release notes before it would include these things barely got mentioned. It doesn't make sense to make a new page for these. Fitting these into their corresponding alpha/etc release notes is the only place we have to put these notes today and I'm not sure it's worth the effort.
Going forward, perhaps we should consider going to a model where minor releases are lumped together on one page, so we'd have three pages per branch: one for all the pre-releases of a branch (which would also serve as the detailed changelog for the release and would be a reasonable place to drop in unsorted "forgotten" changes like these), one for the release summary itself, and one for the post-release patches.

It would be nice to have a link to this issue/s from somewhere in docs.
I faced:
https://github.com/cockroachdb/cockroach/pull/39202
Looked into release notes and didn't found anything related.
Took me a while to land here.

I'm closing this issue in favor of discrete issues, which I will create soon.


UNAUTHORIZED error running the append builder

Running the following code
fairing.config.set_deployer('serving', serving_class="LabelPrediction")
create_endpoint = fairing.config.fn(LabelPrediction)
create_endpoint()

Results in following output
Building image...
/opt/conda/lib/python3.6/site-packages/fairing/__init__.py already exists in Fairing context, skipping...
Loading Docker credentials for repository 'gcr.io/kubeflow-images-public/fairing:dev'
Image successfully built in 0.2687204470003053s.
Pushing image gcr.io/code-search-demo/fairing-job:BEF9445D...
Loading Docker credentials for repository 'gcr.io/code-search-demo/fairing-job:BEF9445D'

TokenRefreshException                     Traceback (most recent call last)
<ipython-input-4-82bbfda72d74> in <module>
      1 fairing.config.set_deployer('serving', serving_class="LabelPrediction")
      2 create_endpoint = fairing.config.fn(LabelPrediction)
----> 3 create_endpoint()

/opt/conda/lib/python3.6/site-packages/fairing/config.py in ret_fn()
    110         def ret_fn():
    111             self.set_preprocessor('function', function_obj=fn)
--> 112             self.run()
    113         return ret_fn
    114

/opt/conda/lib/python3.6/site-packages/fairing/config.py in run(self)
    100         deployer = self.get_deployer()
    101
--> 102         builder.build()
    103         pod_spec = builder.generate_pod_spec()
    104         deployer.deploy(pod_spec)

/opt/conda/lib/python3.6/site-packages/fairing/builders/append/append.py in build(self)
     63             self.full_image_name(self.context_hash), strict=False)
     64         if self.push:
---> 65             self.timed_push(transport, src, new_img, dst)
     66         else:
     67             # TODO(r2d4):

/opt/conda/lib/python3.6/site-packages/fairing/builders/append/append.py in timed_push(self, transport, src, img, dst)
     95         logger.warn("Pushing image {}...".format(self.image_tag))
     96         start = timer()
---> 97         self._push(transport, src, img, dst)
     98         end = timer()
     99         logger.warn(

/opt/conda/lib/python3.6/site-packages/fairing/builders/append/append.py in _push(self, transport, src, img, dst)
     87         creds = docker_creds.DefaultKeychain.Resolve(dst)
     88         with docker_session.Push(
---> 89              dst, creds, transport, mount=[src.as_repository()]) as session:
     90             logger.warn("Uploading {}".format(self.image_tag))
     91             session.upload(img)

/opt/conda/lib/python3.6/site-packages/containerregistry/client/v2_2/docker_session_.py in __init__(self, name, creds, transport, mount, threads)
     68     self._name = name
     69     self._transport = docker_http.Transport(name, creds, transport,
---> 70                                             docker_http.PUSH)
     71     self._mount = mount
     72     self._threads = threads

/opt/conda/lib/python3.6/site-packages/containerregistry/client/v2_2/docker_http_.py in __init__(self, name, creds, transport, action)
    206     self._Ping()
    207     if self._authentication == _BEARER:
--> 208       self._Refresh()
    209     elif self._authentication == _BASIC:
    210       self._creds = self._basic_creds

/opt/conda/lib/python3.6/site-packages/containerregistry/client/v2_2/docker_http_.py in _Refresh(self)
    313     if resp.status != six.moves.http_client.OK:
    314       raise TokenRefreshException('Bad status during token exchange: %d\n%s' %
--> 315                                   (resp.status, content))
    316
    317     try:

TokenRefreshException: Bad status during token exchange: 401
b'{"errors":[{"code":"UNAUTHORIZED","message":"You don\'t have the needed permissions to perform this operation, and you may have invalid credentials. To authenticate your request, follow the steps in: https://cloud.google.com/container-registry/docs/advanced-authentication"}]}'

Seems like its not getting my credentials. GOOGLE_APPLICATION_CREDENTIALS is set.
Do I need to run some command to configure docker to use those credentials?

Running the following commands in a cell seemed to fix the issue.
!gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS}
!gcloud auth configure-docker --quiet

Should we document this? Add it to the examples?

Depends what base image you're using. I suggest using docker-credential-gcr configure-docker instead, which picks up GOOGLE_APPLICATION_CREDENTIALS by default.
We run this in the Kubeflow images already.

Thanks.

How do I know which base docker image to use? Is there any Dockerfile to specify what is the content of the docker image?
I used this image tensorflow-2.0.0a-notebook-gpu and I still need to run
!gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS}
!gcloud auth configure-docker --quiet
The default configuration of the jupyterhub will give me this error when I run the fairing examples.
Caller does not have permission \'storage.buckets.create\'.
Thank you.


⚠ Bofrost.at has degraded performance

In 46a4258, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2042 ms

Resolved: Bofrost.at performance has improved in 63d65ac after 6 minutes.


Convert all formal parameters to named offered when there are no positional parameters to convert

Given a constructor with no positional parameters, such as
class C {
  C();
}

or
class C {
  C({int c});
}

the "Convert all formal parameters to named" refactoring is offered, even though there's no work for it to do.

@scheglov

Ah, I would be happy to fix this :-)

For https://dart-review.googlesource.com/c/sdk/+/355302


Adding Speech Command Dataset

🚀 Feature
Adding to the possible datasets to use the Speech Command Dataset
https://arxiv.org/abs/1804.03209
Motivation
As a beginner steps into audio manipulation using the Speech Command Dataset is a must since it is simple and allows us to use it as a classification problem or end-to-end Automatic Speech Recognition.
Pitch
Allowing beginner to have a starting point to a dataset that can allow the training of interesting models is an easy way.

Since this dataset is very recent, I am not inclined to consider adding it at this time. Do you have references for such successful model? Have you considered LibriSpeech or CommonVoice?

It is a dataset that would be an easy start for a beginner to start touching with ASR since it does not necessitate many moving parts and does not need that many parameters to a model to have good performances with.
Sure, but if you want to detect, a phone number or something similar this dataset would be much simpler than training with Librispeech or CommonVoice.
repo using this dataset: https://github.com/LearnedVector/Wav2Letter

Nice example, and good to see that the dataset appeared on kaggle :) Alright, we would welcome this dataset. In general, we try to keep the available datasets to the most popular and requested. Would you be interested in opening a pull request for it?
Please keep in mind that we keep the structure of the code very close to the ones currently available, see for instance librispeech.

Yes, I am totally interested in doing the PR! Thanks!!
Sure, I will take into account that!


Corrupt originals - yellow/green tint.

I am experiencing an intermittent problem where imagor appears to be corrupting the source image, saving that as an original and then failing to generate thumbnails from it.
Attached is an example of the source image, and a corrupted copy that imagor had cached as an original:

When attempting to use this original for a thumbnail, I get the following output:
 "error": "imagor: 406 VipsJpeg: Premature end of input file"
I've seen this happen before and the corruption always looks the same, bottom 2/3rd yellow/green tint, some kind of broken frame from the left side etc.
Deleting the cache of the original and running it again seems to fix the issue.
Any ideas? I'm not sure where to look.
I'm using imagor 1.0.3 in a docker container.  Http loader. S3 storage.

Try the latest version?

Thanks for the suggestion - I hadn't realised the container image I was using had fallen so far behind. Was this a known issue that has been resolved in the newer versions? otherwise as it was intermittent it's going to take a while to verify that the problem is resolved, but hopefully that is the case.

Yes that was a known issue around 1.0.x related to streaming issues. Fixes were deployed around 1.2.x.
For old corrupted images, imagor cannot determine if it is a legit file caused an error, or indeed a corrupted image. So they are left untouched and need to be removed manually.
But for new images, imagor would try to clear its cache if the resulting image caused an error.
Lets reopen the issue if you reproduce any new findings.


[ServiceBus] az servicebus namespace create: Add zone redundant parameter

Description
This PR adds the zone_redundant parameter to az servicebus namespace create
Testing Guide
az servicebus namespace create --name {namespacename} -g {resourcegroup}  --zone-redundant
History Notes

[ServiceBus] az servicebus namespace create: Add zone redundant parameter

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR title and description has followed the guideline in Submitting Pull Requests.

[X] I adhere to the Command Guidelines.

[X] I adhere to the Error Handling Guidelines.

Hello @yonzhan , could we please add the label for this PR to be merged to go out in this release. Thanks.

ServiceBus

Need code owner @zhoxing-ms's review


chore: add mergify configuration

:id: Reference related issue.
https://gravitee.atlassian.net/browse/AM-533
:pencil2: A description of the changes proposed in the pull request
This PR adds mergify configuration to the repository

Correct me if I am wrong, this configuration will create a merge from one feature to each maintained branch ? (for now: master, 3.21.x, etc.)
In that case, with the same change on each maintained branch. When we will merge for example 3.20.x into 3.21.x, we will have a conflict with the same change on both release branch :confused:

@passionne
Thanks.
I took inspiration from @gaetanmaisse and what APIM implemented.
I agree that it should be documented and I think this is the plan for the next coming weeks


Build API for transferring org assets across CF api endpoints

Create an api layer to facilitate transferring assets across CF instances.

orgs / spaces - except for sandbox
non UAA authenticated users

I opened this issue as a starting point for our strategy to migrate users.  This has been covered with the creation of the migration bot.  https://github.com/18F/cg-product/issues/210


Add "Things to look out for when proofreading" to list of how-tos

Noticed this page was missing from https://standardebooks.org/contribute/how-tos while addressing #389.

Thanks!


fix: Add support for slug generated pages

The script doesn't seem to handle generated pages route, is there a way to get them ?

Yes I totally see why and it's not too much of a problem, I was able to find another solution that allows me to resolve the mapping of markdown files located in slugs with fs, thanks anyway!


Are vulnerabilities information at the package level applied to their related callables in the stitched call graph?

@tmortagne Hi Thomas,
I am reaching out because we are trying to understand the main logic that Maven plugin is using (to be consistent in fasten-pypi-plugin) while augmenting the metadata field at the callable level in the stitched call graph.
In a dialogue between @gdrosos Giorgos and @amphioxis Martin, I understood that they were trying to understand Maven plugin code (particularly these two parts of the code: 1 and 2).
Martin's main question is:
"Are everywhere in the metadata field of the stitched call graph added vulnerabilities information retrieved at the package level?"
Giorgos supposition is:
"Yes"
My understanding is that:
"The Maven plugin retrieves vulnerabilities information at the package level (through a FASTEN API endpoint). Then, it applies this information all over the stitched call graph (reasonably, to all the callables related to that specific package, being a stitched call graph  the product of more call graphs, each of them belonging to a package)."
Can you confirm this first part of the reasoning?
More questions will probably follow, but at least we should be sure to answer this doubt to fix this first important step for the Pypi plugin development.

Vulnerability handling is a bit special: in the FASTEN Knowledge Base the vulnerabilities of each callable are aggregated in the package metadata, so the plugin is only getting package metadata for those (much faster than asking callable metadata vulnerabilities) and then the security analyzer just checks if it can find a callable in the graph matches it with each callable. So contrary to others info like the quality metrics, the vulnerabilities are never associated with callables in the graph (only to dependencies).

It sounds interesting.
Is it possible to look at an example of a stitched call graph enriched with information by the Maven plugin ?
I think for @amphioxis it would be the best way to go, and to ask! :)
Thanks for the fast and precise clarification.

Well, we thought that Maven plugin was enriching the final stitched call graph with metadata information (vulnerabilities, quality metrics, licensing).
So we really thought the Maven plugin was generating a JSON.
We are in fact designing the PyPI plugin with a logic like this one:

The PyPI plugin, by means of pycg and pycg-stitch, creates locally a stitched call graph taking as input the package dependencies chosen by the developer that will use the tool on its local machine.
Then it enriches the stitched call-graph performing queries towards the FASTEN REST APIs, writing this result in a JSON which reflects the original stitch call-graphs (stitched by pycg-stitch), with information added (which is the added value, for this step, of the PyPI plugin).
It will provide a summarized output to the final user, parsing the JSON generated in step 2.

Based on this design and considerations, we would like to understand what is the output of the Maven plugin.
Could you please provide us with a concrete example of the Maven plugin execution?
Thanks in advance,
Michele

Just for clarification, for Python, the output of the stitcher is a stiched call graph along with a metadata field for each corresponding Python URI. We produced an Output of the graph in a JSON representation in order to make our tool shareable. But the main logic is that we have a graph data structure which could be used to perform callable level analysies. For example in Java as far as I understand the stitched call graph structure is of type MavenGraph.
If we want to enrich the sitched python graph with vulnerability information in the package level, @amphioxis proposed adding on the stitched call graph some package level fields. But this should not be performed by pycg-sticher since the stitched graph presents information on the callable level.
Instead, an idea could be for the pypi-plugin to create a data structure similar to the MavenExtendedRevisionJavaCallGraph and add a dictionary corellating the revision name with the metadata information, similar to Maven. The you can parse the Uris of the stiched call graph and look whether their corresponding revision has vulnerability information in the dictionary, and then proceed with the analysies.

Well, we thought that Maven plugin was enriching the final stitched call graph with metadata information (vulnerabilities, quality metrics, licensing).

You are mixing very different things. The Maven plugin does enrich a stitched call graph, but that's a Java representation of that call graph and there it does not have any reason to serialize it as JSON.

@tmortagne thanks for the clarification.
Shall we see the maven plugin functioning concretely?

Shall we see the maven plugin functioning concretely?

Sorry, not sure I understand the question. Are you asking how to use the plugin in a Maven project ?

Shall we see the maven plugin functioning concretely?

Sorry, not sure I understand the question. Are you asking how to use the plugin in a Maven project ?

It could be a good starting point to understand what we are missing to replicate it for Python.

@michelescarlato sent you a message on Gitter as it's starting to look like a chat :)


Mdvm updates

Required items, please complete
Change(s):

Fixed bug in calculating full vs. incremental import.
Added new fullI mport column to MDVMCVEKB and MDVMNISTCVEKB tables to support above bug fix.

Reason for Change(s):

Bug fixes.

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hello @anders-alex, Thanks for raising the PR. This PR will be investigated and we will update you about the same before 20 March, 2024.

Hello @anders-alex, Can you share latest working images of function app.

@v-prasadboke Please see below:


Fix annotation in CodeObjects::Base#files

The original annotation incorrectly was Array but the format is
[ [file, line] ]

Therefore the annotation should be Array<Array<String, Integer>>,
given there is no prescribed way to describe tuples
Description
Describe your pull request and problem statement here.
Completed Tasks

[x] I have read the Contributing Guide.
[x] The pull request is complete (implemented / written).
[x] Git commits have been cleaned up (squash WIP / revert commits).
[x] I wrote tests and ran bundle exec rake locally (if code is attached to PR).

Coverage increased (+0.03%) to 93.633% when pulling fa97a25cbd0440768c70becd8ffa290a1b4ed02f on gmalette:gm/fix-annotation-of-files into 8a0e6ac225b3691739bf5035d01b3f2d8dc67a79 on lsegal:master.

Thanks!


Enable strict and fix fallout

The commenting out of use strict was masking many errors and no-ops in this script. Including typo variable names which will have effected any numeric results produced for the benchmark. I've reviewed the code as best I can without really knowing the full test case. But this will need testing.

Hi @MattOates, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Thanks. A good change to make! :)

Stripped the whitespace and put back the brackets as of ed13dbb9f381122c3f3b1ab0ac2ed096e3f2a793

Hi Matt, thanks for the contribution. As you might have guessed this script is a bit neglected as it was written quite a while ago and our team doesn't usually work in perl. I'm a bit more familiar so I will make some comments soon.

@abchatra any comments? LGTM otherwise.

LGTM. Did anyone test the script works?

I have tested and merged the change. @MattOates thank you!

I can sleep more soundly knowing there is one more strict Perl script in the world >:3 Thanks for testing and the merge.

Aw yiss


Remove facebook and google+ links as these profiles are not used/acti…

…ve anymore

Couldn't merge it anymore, removed it in a separate commit https://github.com/liimaorg/website/commit/0f512355fe1946f13a35c88e6ae502b5bad71277


TypeError: object() takes no parameters

when I try to python train.py,it report these errors..
can anyone help?
Traceback (most recent call last):
File "/home/Downloads/SSD-master/train.py", line 117, in
main()
File "/home/Downloads/SSD-master/train.py", line 108, in main
model = train(cfg, args)
File "/home/Downloads/SSD-master/train.py", line 44, in train
start_iter=arguments['iteration'])
File "/home/Downloads/SSD-master/ssd/data/build.py", line 34, in make_data_loader
datasets = build_dataset(dataset_list, transform=train_transform, target_transform=target_transform, is_train=is_train)
File "/home/Downloads/SSD-master/ssd/data/datasets/init.py", line 26, in build_dataset
dataset = factory(**args)
TypeError: object() takes no parameters

Please follow DEVELOP_GUIDE.md to define your dataset.


Things acceptance test fails

Is it possible that this test fails because of a change @JeroenStravers1  made in the Thing Types?

Things acceptance test no longer fails


Update to 3.82.0

Unbundle libsharp
Use standalone C++ archive source archive instead of monolithic tarball
Build shared libraries

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender


Turn I, left, right into keywords

Reasons:

They are crucial to the type theory
Their types are simple enough. The ability to write down prim arcoe : blabla makes the theory easier to understand (if it's a keyword, you may forget about its type signature, like which parameter is implicit, etc.), but for I, left, right they're too simple
My upcoming core type theory refactoring can be simplified drastically using this
left and right are also used as patterns. By making them keywords we no longer need prim states in pattern checker.

I agree. Then let's do it in #256

So we can also simplify lots of code in #256

So we can also simplify lots of code in #256

Great!!

Tasks

[ ] Make I  into a keyword.
[ ] Resove 0/1 into left/right when typed as I.
[ ] Update tests.
[ ] Remove prim state.

@dark-flames are you sure about removing prim state? arcoe will still be prim (and in the future, hcomp and Glue)

Well, so change it to "Remove the I, right,  left  in the prim factory"?

@dark-flames Yes


Added read product by name endpoint, tests for read product by id and by name

Made the following changes:

Added read by name endpoint
Updated find_by_name in model so it return a list of products instead of just one
wrote tests for read by name and read by id

As discussed, One issue--One feature brach-- One pull request.


Server access trough IP link

Hi,
I'm trying to join my server with IP / Port and yes i do have club access but it does not work.
I tried to join from the club it work, from the link ID it works but not the IP/Port. (so should not be a port forward issue)
I tested IP/Port with and without master password without any success.
The only way i got access with IP/Port was in a local network but i don't want that ... (also in local network free account can join with IP)
Is it just cuz IP is local only ? If yes, Is there a way to bypass it ?
Or am i missing something ??

You'd have to use your external IP to join, not the local network IP.
However, is there any specific reason you wanna join via IP:Port instead of the club or join link?


[warn]: #0 Template received after missing 516 packets host=["AF_INET", 50101, "x.x.x.x", "x.x.x.x"] source_id=524544 flowset_id=320

This is expected behaviour, and something I should likely document. NetFlow v9 or IPfix (v10) traffic is template based, meaning that this until we have a template we do not know what fields are stored. Templates are generally sent every minute, but this is a network device parameter. This warning is just a notification that the number of packets (potentially with multiple flows) were received prior. It is normal when restarting the service, but may be an issue if occuring later during processing.

Parsed result for ipfix flow was like:
{
...
    "flowStartSysUpTime": 2566,
    "flowEndSysUpTime": 11222785,
    "host": [
      "AF_INET",
      4739,
      "<IP_ADDRESS>",
      "<IP_ADDRESS>"
    ],
...
}

the host value should be like: "<IP_ADDRESS>", not an array?


Drhuffman12/ai4cr backpropagation

This ports some of the Ai4r gem (currently, just Ai4r::NeuralNetwork::Backpropagation as Ai4cr::NeuralNetwork::Backpropagation).

Happy to see it is now a part of Awesome Crystal list ❤ 💎
What's next?

announce it on Crystal ANN dev hub
share it on Reddit channel
say about it if you created something the community is looking for

Thanks! :)


bug- race condition due to unused resource generation metadata/spec

I would like to propose a new 'ReadinessCheckDelay' argument to the helm commands: 'install', 'upgrade', and 'rollback' based on a race condition we are seeing between helm and a kubernetes controller.  We are running helm install with the 'wait' and 'atomic' arguments, but helm doesn't track the resource readiness state (we are seeing this in approximately half of our installs that contain a statefulset). We have reviewed the api-server logs and found that helm makes both the patch and resource readiness get calls before the statefulset controller has the chance to update the resource.  This is causing a false positive for the readiness check on the statefulset, and helm incorrectly updates the install status as completed successfully.  I am proposing a 'ReadinessCheckDelay' argument that can be used to add some delay between the resources being patched by helm and the subsequent readiness checks.  Unfortunately I can't share logs because this is something I am encountering in my cluster at work (highly restrictive fintech).  This is something I'm happy to contribute assuming the community is open to this change.  Thanks for the feedback :)
Output of helm version: 3.8.0
Output of kubectl version: 1.21.5
Cloud Provider/Platform (AKS, GKE, Minikube etc.): EKS

If I'm understanding correctly, this affects the upgrade and rollback processes due to the fact that when a StatefulSet or Deployment is updated, it's still considered ready because the subresources (pods, replicasets, etc) have not been updated yet. This fulfills the resources expectations (3 pods ready out of 3, for instance) causing the wait to consider the resource ready.
Have you considered filing a Kubernetes bug for this? It feels like this should be handled in the API. When patching a Deployment, StatefulSet, etc, it seems like maybe it should reset the readiness. I'd be really interested in seeing what sig-api-machinery thinks.

Thanks for the response!  Just opened an issue to kubernetes and tagged sig-api-machinery.  Let's see what their analysis is and go from there 😄

@joejulian Check out Jordans response on my issue opened to kubernetes.  Seems like a great suggestion to incorporate generational checks into the readiness logic.  Might be worth a review to see if there are additional resources that could benefit from generational checks.  What are your thoughts on this idea and it's potential as a HIP?  Thanks for the help again!

Bumping, this isn't stale


feat:Enhance Newsletter Subscription with Validations and Confirmation

Description
Is your feature request related to a problem? Please describe.
The current state of the Newsletter feature lacks necessary validations and confirmation, leaving room for improvement. This issue proposes to implement enhancements that ensure proper validation checks during subscription and provide users with a confirmation (like a pop-up on the screen that they are subscribed)
Describe the solution you'd like
This issue proposes to implement enhancements that ensure proper validation checks during subscription and provide users with a confirmation (like a pop-up on the screen that they are subscribed)
Describe alternatives you've considered
The proposed resolution fixes the problem.

@akshitagupta15june can you please assign this task to me?


Investigate changing IHandModel lifecycle callbacks

This is the existing IHandModel lifecycle.
InitHand -> (BeginHand -> UpdateHand -> FinishHand -> BeginHand...)
This is very close, or identical to the default Unity Monobehaviour lifecycle.
(Awake/Start) -> (OnEnable -> Update/FixedUpdate -> OnDisable -> OnEnable ...)
It might make things easier on both us and developers if we tried to switch over to using the default MonoBehaviour lifecycle.  It could make it easier to develop new types of HandModel because one would be working within a framework that is more familiar.  It could also help prevent errors because we would not be keeping track of additional state that could become inconsistent.  It could also help prevent confusion (currently hand models can be disabled, but that means nothing...)
One possible proposal:

Awake: Used for non-hand related initialization of the model
OnEnable:  Called when a model begins tracking (comparable to BeginHand)
Start: Called the first time a model begins tracking (comparable to InitHand)
OnDisable:  Called when a model stops tracking (comparable to FinishHand)
UpdateHand:  Still would be a custom callback to allow update ordering and the difference between Update and FixedUpdate to be automatic.

Not a complete proposal, but definitely something to think about.

I like this idea, and I'd consider making HandModels follow a more familiar workflow to be a DevX issue

Trying to flesh this out into an actionable proposal so the issue doesn't get stale.
If HandModels are MonoBehaviours and they are receiving MonoBehaviour callbacks, we can't necessarily guarantee that the conditions you're proposing are actually true when the callbacks are called. Specifically:
(1) What if the hand model GameObject is enabled when the Application begins playing? It will receive Awake and Start depending on its order of update relative to the Hand Model Manager. We could enforce an earlier scripting update time for the HandModelManager to prevent this from happening.
(2) What happens the user enables a hand model manually, but there's no tracking data for it? It will receive Start() no matter what we do in that scenario, but the precondition was invalidated, because there was no tracking data.
(3) How do we have the model receive Awake() (to do non-hand-related initialization, so presumably before the hand is even tracked) but not Start() (because the hand hasn't been tracked)?

I think I would be in favor of closing this issue, and in the back of our heads noodling on what kind of architecture we would build in the most ideal situation.  For example, what would everything look like if LeapC gave us a persistent left and right hand and that's it?  Lots of things would change, and the correct architecture might be more intuitive at that point.

Agreed. I have a note to put together a meeting or two to talk about this and a body-centric model that can inform that work and communicate it to platform as well.
Closing this.


[Feature Request] Create a Docker image capable of running Iter8 within it.

Is your feature request related to a problem? Please describe.
It is possible to create a kind cluster within a docker image (in conjunction with a dind image). We want to run Iter8 within this kind cluster embedded in a docker container.
Why is the feature useful for Iter8 users?

This feature enables Iter8 to be used within Tekton Pipelines  (even when Iter8 is not installed in the target cluster)
This feature enables Iter8 to be used for environments like IBM Code engine (even  when Iter8 is not installed in the target env). Specifically, this will enable Iter8 experiments for an app in a  remote cluster (without Iter8 installed remotely).

Describe the solution you'd like

Create ind folder in the Iter8 repo (ind stands for Iter8 in Docker).
Create a Dockerfile inside the ind folder.
This docker file will be used to create the iter8-ce-image on DockerHub.
The image created above will be run as follows...

docker run -d \
  --name ind-ce \
  --network ind-network \
  -e DOCKER_TLS_CERTDIR=/certs \
  -v ind-docker-certs-client:/certs/client:ro \
  ind-ce-image

The ind-ce-image will have an entrypoint, which enables the container to be run as an executable. The script called in the entry point will do the following:
a) create kind cluster
b) install iter8
c) wait for pods to be ready
d) exit successfully if pods are ready; and fail if they are not ready

Does this issue require a design doc/discussion? If there is a link to the design document/discussions, please provide it below.
Yes, more design discussions TBD.
How will this feature be tested?
This  feature will initially be tested manually. Subsequently, there will be Tekton pipeline based tests.
How will this feature be documented?
This feature will initially be documented as part of IBM Code engine usage for Iter8. Subsequently, there will be  Tekton Pipelines based documentation.

We decided to simply use local Kind / Minikube clusters instead of packaging kind within a docker image.


[API] When there is no backup, the response of list_backup does not have data field

{'requestId': 'b3a1c0b6-6fe3-11ed-9e1b-acde48001122', 'msg': 'success'}

I think it would be better if it is
{'requestId': 'b3a1c0b6-6fe3-11ed-9e1b-acde48001122', 'msg': 'success', 'data': []}

fixed in #62


Connection Error!

Hi,
I have followed the readme guide to run k3s-dind, But I am geting this error please help me to resolve this!
ubuntu@ip-172-31-5-110:~$ docker run -d --privileged --name k3s --hostname k3s -p 8443:8443 unboundedsystems/k3s-dind
9be495b718213a2cea8dcff8d8f0f71e38b9913431085033de6acb0e8bf8415d
ubuntu@ip-172-31-5-110:~$ docker exec k3s get-kubeconfig.sh > ./k3sconfig
ubuntu@ip-172-31-5-110:~$ export KUBECONFIG=./k3sconfig
ubuntu@ip-172-31-5-110:~$ kubectl get nodes
E0202 21:49:20.048811   12087 memcache.go:265] couldn't get current server API group list: Get "https://<IP_ADDRESS>:8443/api?timeout=32s": read tcp <IP_ADDRESS>:54418-><IP_ADDRESS>:8443: read: connection reset by peer - error from a previous attempt: read tcp <IP_ADDRESS>:54406-><IP_ADDRESS>:8443: read: connection reset by peer
E0202 21:49:30.056805   12087 memcache.go:265] couldn't get current server API group list: Get "https://<IP_ADDRESS>:8443/api?timeout=32s": read tcp <IP_ADDRESS>:48226-><IP_ADDRESS>:8443: read: connection reset by peer - error from a previous attempt: read tcp <IP_ADDRESS>:48222-><IP_ADDRESS>:8443: read: connection reset by peer
E0202 21:49:40.066146   12087 memcache.go:265] couldn't get current server API group list: Get "https://<IP_ADDRESS>:8443/api?timeout=32s": read tcp <IP_ADDRESS>:50506-><IP_ADDRESS>:8443: read: connection reset by peer - error from a previous attempt: read tcp <IP_ADDRESS>:50494-><IP_ADDRESS>:8443: read: connection reset by peer

Hi there!
Unfortunately, we haven't seen a lot of interest in this project, so we haven't continued keeping it up to date. The Kubernetes version it uses is a few years old now. So I suspect the problem is related to version incompatibility between your local version of kubectl and the Kubernetes in this project.
But depending on what you want to accomplish, there may be a couple of solutions:

The easiest is to try using the kubectl wrapper that's present in this repo. So instead of running kubectl, which uses the version installed on your local system, change to the root directory of this repo and try running ./kubectl instead. That will use the version of kubectl from within the k3s container and will always be compatible with the container.
You could download an older version of kubectl for your local system. I believe the version this project currently uses is v1.18.
Fork the repo and update Kubernetes within the project so you can use a newer version.

I hope that helps!

Thanks @mterrel
It worked!!