Xml serializer

Port code from OPHD for reading xml files
Allows reusing code when loading Sprite metadata

If this changeset looks good, will want to pull code from OPHD and redirect calls to open xml documents in OPHD

I am trying to centralize some of the xml calls and move them out of OPHD as a first step to pulling. I had noticed the way the sprite data is loaded and initially error checked was exactly the same as how saved games were loaded and error checked in OPHD. It is a small effort and I don't mind pausing or abandoning the effort if others are not keen on it.
I guess the stringToEnum code just came along since it was in the same module. It could be left in OPHD for sure if it made this PR more palatable.

I had also noticed the duplication of code for opening and validating XML files. That is something I want to address.
I'm uncertain where I want to go with this. (And probably too tired to make a decision right now). Maybe Leeor can weigh in on the ideas.

Hmm, I was expecting a merge conflict after merging #839, though that doesn't seem to be the case.

A lot of the code is lifted directly out of NAS2D's sprite loading/validation code. Much of it is 'quick and dirty' 'make it work' kind of deals which is why it's error prone, messy and inefficient. Lots of copy paste.
I am fine with any attempts at making this a less catastrophic mess. I still think that XML should be pulled from the interface of the NAS2D library -- if it's used internally to handle stuff that's an implementation detail that doesn't need to be exposed.
OutpostHD's use of XML can just be shifted over to using any XML library, or, really, any serialization mechanism. XML was chosen primarily to make it easy during early development to make sure I was writing values properly and to easily adjust values outside of the game. As the save game format has effectively matured the use of XML can be retired and replaced with a different method of serialization, even binary though I think a human-readable form is preferable. A bit out of the scope of this task but I really do want to move away from 'rolling my own' kind of thinking to using mature well-tested libraries that are easy to install using package managers (like homebrew, apt get, vcpkg, etc.)

Err, I don't know if we wanted to merge both #839 and #838, as they both have similar aims. @Brett208, can you comment on this? I've kind of lost context on this one, and I might not have time to delve into the details for a little while.


fix: to-bits and to-radix for > 128 bits

Related issue(s)

Resolves #1311
See https://github.com/noir-lang/noir/issues/1109#issuecomment-1537436119
Description
Summary of changes

Avoid casting of opcode arguments to u128 before converting to bits or bytes
Allow to_radix_base to work for elements close to the modulus

Dependency additions / changes

Test additions / changes

Checklist

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt with default settings.
[x] I have linked this PR to the issue(s) that it resolves.
[x] I have reviewed the changes on GitHub, line by line.
[x] I have ensured all changes are covered in the description.

Documentation needs

[ ] This PR requires documentation updates when merged.

Additional context

I reverted to the old overflow check based on the comments.
There are also a couple of other issues in the ToBits implementation:

It ignores the input endianness
It returns something even if the element wouldn't fit in the input bit_count. This is inconsistent with ToRadix which panics with ArrayOutOfBounds

I guess I can fix these in a follow-up PR once I know what the right behaviour should be.


Update azip-integration.md

This is not documented but is a known issue

@dcurwin
Can you review the proposed changes? I suggested a grammatical edit and removing the en-us from the new link.
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@dcurwin : Thanks for your contribution! The author(s) have been notified to review your proposed change.

I will check to see if this change is approved.

@tareqmusmar  - Thanks for your contribution. We've published your note.


Question

Thanks for developing this tool! I've been looking at the secrets.json file. Is there a way to test passwords with first letter caps also? And would it be possible to loop through a larger password list? I have around 10 words that I want to test, or maybe use a user defined password list as input?

Since the secrets.js is a plain JavaScript function that is expected to return a flat array of strings you can do whatever fits your needs within the function body. If you simply want to test a hardcoded list of passwords against your BIP38 encrypted private key your secrets.js could look like the following:
'use strict';

var combinations = require('./combinations');

module.exports = (function() {

    return [
        'password1',
        'password2',
        'password3',
    ];
}());

I'd like to try something like this to read my strings from file:
var lines = require('fs').readFileSync(filename, 'utf-8')
    .split('\n')
    .filter(Boolean);

But since my list is around 6GB in total (yeah, really big), I suppose that will eat to much memory?

Hi how are you? could tell me if your script has how to set the size of the password, example I know my password has a size of 17 to 24 but I do not know how to configure.


Migrate to @apollo/react-hooks

@pthongtaem thanks so much 🚀

@pthongtaem already live at https://spacex.land/


booze

Simmilar to https://github.com/gdg-garage/Garage-trip-3.0-organization/issues/13

Hey @curusarn do you want to handle this again?
@jskvara handled the beer with Otas. I also had an idea to have Kofola on tap, what do you think?

Currently we have 27 adult attendees https://docs.google.com/spreadsheets/d/1__QI7aK7up5arK6jr01Oi1RwBUOhaLjlojAzFVQ8OjQ/edit#gid=0

I also found this https://docs.google.com/document/d/1cnFEqtMoKNwfb0Ap_ZPpy2nTjpIH2aF8V-w-uR01c4s/edit

@curusarn ping, should I look for someone else?


[WIP] Wrapper for auto-generated docs

Test wrapper for auto-generated docs, e.g. api.
When I tried making a wrapper w/ the left ToC nav on, the page layout was too cluttered and there wasn't enough room for the content, so I'm using a new layout that excludes the ToC nav. However, the double scroll bars are not a good UX. We may want to consider a different approach.
Preview: https://deploy-preview-6833--kubernetes-io-master-staging.netlify.com/docs/reference/api/

This change is

I think we should solve this a different way.


[Bug]: param not defined when using sp_executesql procedure

What happened?
Hi,
I have an application written in Node.js that uses the library mssql and is trying to list employees using the @employeeName as a parameter. However, after investigations, I found the TDS library used by mssql, called tedious, is using the stored procedure sp_executesql under the hood to execute my queries.
According to the documentation, sp_executesql isn't supported. Is that right? Because it's working fine without parameters:
DECLARE @SQLString NVARCHAR(500);
SET @SQLString =
     N'SELECT * FROM employee';
EXECUTE sp_executesql @SQLString;

The issue arises only when calling the procedure with parameters:
DECLARE @SQLString NVARCHAR(500);
DECLARE @paramDefinition NVARCHAR(500);

SET @SQLString =
     N'SELECT * FROM employee where name = @employeeName';
SET @paramDefinition = N'@employeeName varchar(50)';
EXECUTE sp_executesql @SQLString, @paramDefinition,
                       @employeeName = 'carlos';

Do you have a plan for supporting this procedure with params?
I will let my application code below:
const sql = require('mssql')

const run = async () => {
        await sql.connect(<connection-string>)
        const request = new sql.Request()
        request.input('employeeName', sql.VarChar, 'carlos')
        request.query('select * from employee where name = @employeeName', (err, result) => {})
}

Error:
Msg 33557097, Level 16, State 1, Server BABELFISH, Line 17
param "@employeeName" not defined

Version
BABEL_2_X_DEV (Default)
Extension
babelfishpg_tsql (Default)
Which flavor of Linux are you using when you see the bug?
Ubuntu (Default)
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct.

Why do you think sp_executesql is not supported? It has been supported wince Babelfish v.1.0.0.
The issue in your example has to do with case-sensitivity of the variable name used as parameter. This is a known issue.
When you use all-lowercase, it works fine:
1> create table employee(name varchar(20), surname varchar(20))
2> insert employee values ('john', 'smith')
3> insert employee values ('carlos', 'sanchez')
4> go
(1 rows affected)
(1 rows affected)
1> DECLARE @SQLString NVARCHAR(500);
2> DECLARE @paramDefinition NVARCHAR(500);
3> SET @SQLString = N'SELECT * FROM employee where name = @employeeName';
4> SET @paramDefinition = N'@employeename varchar(50)';
5> EXECUTE sp_executesql @SQLString, @paramDefinition, @employeename = 'carlos';
6> go
name                       surname
-------------------- --------------------
carlos                      sanchez
(1 rows affected)

Why do you think sp_executesql is not supported? It has been supported since Babelfish v.1.0.0. The issue in your example has to do with case-sensitivity of the variable name used as parameter. This is a known issue. When you use all-lowercase, it works fine:
1> create table employee(name varchar(20), surname varchar(20)) 2> insert employee values ('john', 'smith') 3> insert employee values ('carlos', 'sanchez') 4> go
(1 rows affected) (1 rows affected)
1> DECLARE @SQLString NVARCHAR(500); 2> DECLARE @paramDefinition NVARCHAR(500); 3> SET @SQLString = N'SELECT * FROM employee where name = @employeeName'; 4> SET @paramDefinition = N'@employeename varchar(50)'; 5> EXECUTE sp_executesql @SQLString, @paramDefinition, @employeename = 'carlos'; 6> go name surname  -------------------- -------------------- carlos sanchez
(1 rows affected)

I found this procedure in the list of unsupported ones here that's why I got confused: https://babelfishpg.org/docs/limitations/stored_procedure_limitations/#unsupported-stored-procedures
Is there any mention of the case sensitivity there?
Thanks for the answer, I will change the name to lowercase and test it again.

I see.... that is not correct. I'll get it corrected.
The list of supported/unsupported features applies to what is (not) implemented according to the planning in the Babelfish project.  The uppercase/lowercase issue here is more like a bug, and bugs are not documented here.


HTTPS Settings?

How do you specify HTTPS? I created a Front End port on 443. I specified a cert that I've already uploaded here. When I create the resources it is successful but stuck on HTTP?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2dce00db-c8d7-9b93-7ac8-114a500a6a34
Version Independent ID: 14a03192-a30b-d273-fa11-32413868a5fa
Content: az network application-gateway http-listener
Content Source: src/azure-cli/azure/cli/command_modules/network/_help.py
Service: virtual-network
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

add to S169

@nezoic If you provide --ssl-cert in az network application-gateway http-listener create command, the protocol would be set to https accordingly.


"Image succesfully pulled" for a image that does not exist

Before you start please confirm the following.

[X] Yes, I've searched similar issues on GitHub.
[X] Yes, I've checked whether this issue is covered in the Portainer documentation or knowledge base.

Problem Description
If i pull a image that does not exist, using portainer Pull image, "Image successfully pulled"  message is received as a response.
Expected Behavior
If i pull a image that does not exist, using portainer Pull image, "Image successfully pulled"  should not be recieved as a response.
Actual Behavior
If i pull a image that does not exist, using portainer Pull image, "Image successfully pulled"  message is received as a response.
Steps to Reproduce

Select the agent
Go to Images
Select Registry
Input in the Image field something that does not exist for example "dummytest"
Click Pull the image

Portainer logs or screenshots
No response
Portainer version
2.20.3
Portainer Edition
Community Edition (CE)
Platform and Version
Docker 24.0.0
OS and Architecture
Red Hat Enterprise Linux Server release 7.9 (Maipo)
Browser
No response
What command did you use to deploy Portainer?
No response
Additional Information
No response

I tried this and I did not get the same results as you

Hello Nick, thanks for taking the time to look into this issue.
I have a screenshot with this case, but the weird thing is that i can't reproduce the issue anymore.
The screenshot from when i reproduced the issue:

In this image i had "blabla/ image that exists in the repo but for another path, "blabla" being unexistent.
Right now, for the same case  i am having the same error as you do:

If i think about what may be different from the time i reproduced the issue, is that we have restarted the Portainer. I don't know if this has anything to do with the fix or if it is a issue that doesn't reproduces everytime.
We also have a version of Portainer CE 2.19.4 where the issue still reproduces, if that helps for your investigations.

@emilia1106 I've talked to the team internally and this was resolved in 2.20 so this explains why we still see it in 2.19.4. But to answer the question, this has been resolved as part of 2.20 and will be resolved in the upcoming 2.21 LTS release :)


"boto3 >= 1.26.157 required" error in redshift-connector 2.0.912

Driver version
2.0.912
Redshift version
PostgreSQL 8.0.2 on i686-pc-linux-gnu, compiled by GCC gcc (GCC) 3.4.2 20041017 (Red Hat 3.4.2-6.fc3), Redshift 1.0.53064
Client Operating System
Amazon Linux
Python version
3.8
Table schema
NA
Problem description
We use apache-airflow-providers-amazon==3.4.0 to connect to Redshift via Airflow using IAM auth. This airflow package installs the latest version of redshift-connector by default. We are facing issues connecting to Redshift in 2.0.912.
Error message:
ModuleNotFoundError: boto3 >= 1.26.157 required for authentication with Amazon Redshift using custom domain name. Please upgrade the installed version of boto3 to use this functionality.
Due to some legacy libraries our boto3 version is less 1.26.157, which is causing connection to fail. This was working as expected till 2.0.911. I see a recent change for "Support Redshift custom domain name" has added this check. As we are using IAM auth, we supply cluster_identifier in Airflow which I think is now considered as cname?
Is this an expected change?
Airflow connection details
- id: redshift_connection
      type: redshift
      schema: testdb
      port: 5439
      extra: '{"iam": true, "region": "us-east-1", "cluster_identifier": "redshift-warehouse", "db_user": "redshift_test_user"}'

Python Driver trace logs
Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/models/taskinstance.py", line 1157, in _run_raw_task
    self._prepare_and_execute_task_with_callbacks(context, task)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/models/taskinstance.py", line 1331, in _prepare_and_execute_task_with_callbacks
    result = self._execute_task(context, task_copy)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/models/taskinstance.py", line 1361, in _execute_task
    result = task_copy.execute(context=context)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/decorators/base.py", line 134, in execute
    return_value = super().execute(context)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/operators/python.py", line 150, in execute
    return_value = self.execute_callable()
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/operators/python.py", line 161, in execute_callable
    return self.python_callable(*self.op_args, **self.op_kwargs)
  File "/opt/airflow/dag.py", line 119, in run_dag
    redshift_hook.run(sql)
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/hooks/dbapi.py", line 177, in run
    with closing(self.get_conn()) as conn:
  File "/home/airflow/.local/lib/python3.8/site-packages/airflow/providers/amazon/aws/hooks/redshift_sql.py", line 133, in get_conn
    conn: RedshiftConnection = redshift_connector.connect(**conn_kwargs)
  File "/home/airflow/.local/lib/python3.8/site-packages/redshift_connector/__init__.py", line 336, in connect
    IamHelper.set_iam_properties(info)
  File "/home/airflow/.local/lib/python3.8/site-packages/redshift_connector/iam_helper.py", line 117, in set_iam_properties
    raise ModuleNotFoundError(
ModuleNotFoundError: boto3 >= 1.26.157 required for authentication with Amazon Redshift using custom domain name. Please upgrade the installed version of boto3 to use this functionality.

Reproduction code
Connect via Airflow with boto3 < 1.26.157.

Hi @guru-pochineni, thank you for bringing this issue to our attention. The root cause of this issue has been identified, it is in iam_helper.py LOC 116. We have identified a fix and will include in our next release which is scheduled to occur in August.
In the meantime, my recommendation would be to downgrade the version of redshift-connector in use. We apologies for the inconvenience. If downgrading redshift-connector or waiting until August for the fix is not acceptable please let me know and we can make an ad-hoc release to address this bug. Thank you for your understanding!

Hello @Brooke-white, thank you for promptly fixing this and doing an ad hoc release. I can connect to Redshift using the latest version of redshift-connector.
Closing this issue.


Hub: Add Sia Driver

https://github.com/blockstack/blockstack-core/issues/325

Closing this issue due to lack of activity. Please feel free to comment if this should be re-opened.


Initial multistage Dockerfile approach to all images

I started studying multistage builds more than I have, and found that this may work fine
This Dockerfile + Makefile starts with a Debian Buster base and bulds PHP and Nginx from that, then builds ddev-webserver variants from the PHP build.
As of 2020-04-24, I haven't started on the nginx consolidation yet.

[ ] Needs tests for each image; probably bats tests. Some can be adapted from ddev-webserver
[ ] Needs deployment docs and considerations.
[ ] Needs release considerations and docs.
[ ] ddev-webserver-prod doesn't work yet, and will require some effort (no sudo in the container means that any work that needs root has to be accomplished before launch)

This is ready for an initial review. @dclear what I'd like to do is have a meeting where I can introduce the architecture used here, and there are a number of nitty-gritty things in the ddev-live images that will need to be discussed later.
If you want to review, please read the README.md for basic background.

Yay, the entire ddev-local test suite just passed with this image, https://github.com/drud/ddev/pull/2225

The ddev-webserver-dev tests have now been converted to BATS tests.

Tests pass, it doesn't make sense to continue to work on this as a PR. Pulling.


fix(internal/json): add arrow_json_stdlib build tag

Rationale for this change
Grafana and Grafana plugins both use arrow-go, but do not use arrow's internal/json. A decent amount of used heap is initialized by https://github.com/goccy/go-json, so it would be useful to be able to prevent the initialization.
The example below shows that 60% of this heap profile in a Grafana plugin is used by go-json's encoder & decoder packages.

I have submitted a PR to go-json to switch to lazy initialization (additional details in the PR), but I am having a hard time getting a response from the maintainer, so am attempting a different approach to the problem with this PR.
What changes are included in this PR?
Adds arrow_json_stdlib build tag so that it's possible to switch to encoding/json and avoid the overhead of https://github.com/goccy/go-json.
Are these changes tested?
I tested this locally, but I can add coverage if this seems like an acceptable approach.
Are there any user-facing changes?

We mostly use goccy/go-json for performance reasons, but this seems to be a perfectly reasonable way to handle the situation. I definitely prefer fixing it upstream in go-json via your PR if possible. But this is a good stop-gap.

@zeroshade sounds good, thanks! i will continue trying to get the go-json PR merged, and if i do, i'll open another PR to update the dependency here.

@zeroshade it looks like maybe you pushed a fix for the failing mac OS checks, so i rebased this against main


Add missing docs about txqueuelen

feature added in #11243, which closes #11198 is not documented yet.
Updated network_bridge.md, not sure about the other network_*.md files. Do any of these need to be changed as well?

This pull request didn't trigger Jenkins as its author isn't in the allow list.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Documentation preview available at: https://linuxcontainers.org/lxd/docs/pr.11392/

Thanks, but the documentation for this setting is already present in the relevant NIC device, which is where it is set:
https://linuxcontainers.org/lxd/docs/master/reference/devices_nic/#nictype-bridged

Sorry, I confused the two guides. Thanks for the quick feedback!

@tomponline I still think adding a hint in doc/howto/network_increase_bandwidth.md would be useful to make the reader aware of the setting name, which is different from txqueuelen. What do you think?

What do you think @ru-fu , maybe a section in the bridge network page where this is relevant for?

I think @cebe picked the correct place for the addition - it should be in https://linuxcontainers.org/lxd/docs/latest/howto/network_increase_bandwidth/#increase-the-transmit-queue-length-on-the-instances
We should make it clear though that this is for bridged NICs only.
And I'm not sure I understand how exactly this works - if you set queue.tx.length, do you still need to set txqueuelen as described in https://linuxcontainers.org/lxd/docs/latest/howto/network_increase_bandwidth/#increase-the-network-bandwidth-on-the-lxd-host ? Or is that how you set txqueuelen for the instance (that's how I interpret it)?

It just affects this section https://linuxcontainers.org/lxd/docs/latest/howto/network_increase_bandwidth/#increase-the-transmit-queue-length-on-the-instances

So if you're using a bridged NIC, you can just set queue.tx.length instead of doing it "in the same way as described for the LXD host". Correct?

correct.


Target new CI release

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.161%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
2

Relevant Lines:
1246

💛  - Coveralls


systemd TimeoutStartSec=0 is now =infinity

Fixes https://github.com/NixOS/nixpkgs/issues/49700
Motivation for this change
systemd changed the behavior for TimeoutStartSec in 229. infinity is now the preferred argument to disable timeouts.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Oh, nice catch.
While we're at it, it should also be fixed for:

TimeoutStopSec : in module google-compute-image
TimeoutSec : in modules cloud-init and apcupsd

@c0bw3b Could you take another look? Unfortunately I was unable to verify the google cloud environment image creation.

LGTM.
@rbvermaa @zimbatm @AmineChikhaoui to review the change on google-compute-image

@GrahamcOfBorg test cloud-init

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: tests.cloud-init
Partial log (click to expand)
Cannot nix-instantiate `tests.cloud-init' because:
error: while evaluating 'recursiveUpdate' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:415:26, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:384:37, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:347:21, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:332:33, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/lib/attrsets.nix:347:27:
while evaluating the attribute 'cloud-init' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/nixos/tests/all-tests.nix:42:3:
while evaluating 'handleTest' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/nixos/tests/all-tests.nix:17:22, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/nixos/tests/all-tests.nix:42:16:
while evaluating 'discoverTests' at /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/nixos/tests/all-tests.nix:13:19, called from /var/lib/gc-of-borg/nix-test-rs-20/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-20/nixos/tests/all-tests.nix:18:5:
access to path '/nix/store/42zy9qhrwyhjrmjpd9hbzjad366ddikb-grahamc-aarch64-community-20' is forbidden in restricted mode

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: tests.cloud-init
Partial log (click to expand)
Cannot nix-instantiate `tests.cloud-init' because:
error: while evaluating 'recursiveUpdate' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/attrsets.nix:415:26, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/attrsets.nix:148:28:
while evaluating 'recursiveUpdateUntil' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/attrsets.nix:384:37, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/attrsets.nix:416:5:
while evaluating 'zipAttrsWith' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/attrsets.nix:347:21, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/attrsets.nix:394:8:
while evaluating 'zipAttrsWithNames' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/attrsets.nix:332:33, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/lib/attrsets.nix:347:27:
while evaluating the attribute 'cloud-init' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/nixos/tests/all-tests.nix:42:3:
while evaluating 'handleTest' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/nixos/tests/all-tests.nix:17:22, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/nixos/tests/all-tests.nix:42:16:
while evaluating 'discoverTests' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/nixos/tests/all-tests.nix:13:19, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/builder-0-gustav.ewr1.nix.ci/nixos/tests/all-tests.nix:18:5:
access to path '/nix/store/2ms9wnjbi4r6lb9jsinf9z6p6girn485-builder-0-gustav.ewr1.nix.ci' is forbidden in restricted mode

Success on aarch64-linux (full log)
Attempted: nixosTests.cloud-init
Partial log (click to expand)
machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 28.78s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/is73wxa478hy93kld1hxz3cvd53hw8rf-vm-test-run-unnamed

@c0bw3b thank you for the review. Should this target master or staging? It's not clear to me what constitutes a 'mass' rebuild.

This is good as-is targeting the master branch since your PR does not change any packages.
A "mass-rebuild" is when hundreds of packages need to be rebuilt after a shared component is changed.
See #50978 for an example and notice the deep red labels. :)

thanks @cyounkins ! I double-checked and didn't find any more instances


[kill request] Add API validation to avoid config crash

Signed-off-by: Asra Ali<EMAIL_ADDRESS>Commit Message: Adds an API validation to kill request proto to a LowerCaseString field.
Testing: Add regression test

@asraa can you check CI?

@asraa can you check CI?


[Setting] Add july api to available versions

WHY are these changes introduced?
Shopifys newest admin api is in version 2023-07 which is not reflected in this liibrary.
WHAT is this pull request doing?
Adding the new api version string to exported api versions.
Type of change

[x] Patch: Bug (non-breaking change which fixes an issue)
[ ] Minor: New feature (non-breaking change which adds functionality)
[ ] Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[x] I have used yarn changeset to create a draft changelog entry (do NOT update the CHANGELOG.md file manually)
[ ] I have added/updated tests for this change
[ ] I have documented new APIs/updated the documentation for modified APIs (for public APIs)

Thanks for contributing! There are a couple of other things that also happen when we release a new version, so it can sometimes take us a few days to add everything after the actual API version goes live to update the library.
I'm closing this PR since we've already added the new version now :)


feat(breadcrumb): add <rh-breadcrumb>

What I did

Added <rh-breadcrumb>

To Do:

[x] Tests
[ ] Add content to Style, Guidelines, Overview, and Accessibility docs pages.
[x] Add working breadcrumb element in docs under "Overview" > "Sample Element".
[x] Add link to Breadcrumb element in "Elements" nav on the left.
[x] Document @cssprop's

Testing Instructions

Visit the deploy preview

Demo
Subtle Variant
Color Context
Last item is a <li> only

Notes to Reviewers

Currently, this is set up to only with with an <ol>. Should it also work with <ul> elements?

The APG Guidelines for breadcrumbs specify <ol> as the proper element.

Second PR / new WC here, so kindly point out any new associate mistakes. I want to make sure not to repeat them going forward. 👍
Closes https://github.com/RedHat-UX/red-hat-design-system/issues/1458.

@marionnegp

Is there a subtle version for the "Last no link" variant?

I added a subtle variant to the "Non-interactive last item" demo.

Is there a "Last no link" variant for accessibility purposes? It might be confusing to make it seem interactive.

I added this demo in case a CMS somewhere didn't output the last item as a link. Do you think we should include it?
Removing the interactivity of the last link (just having an <li> without an <a>) would likely require us to "lift and shift" the slotted content. I gather folks try to avoid that if possible. Let me know if I misunderstood.

There's a collapsed version in the library. Is this something that can be added to the demo?

Mark said the collapsed version could be added later.

@adamjohnson Everything looks good to me. If we can remove the interactivity from the last link (or current page), that would be great.

I was able to remove the interactivity of the current page. This is currently done via CSS pointer-events: none;.
Testing this out with AT confirms that the functionality of the aria-current attribute still works as expected. I also don't think this violates any WCAG criterion.
PTAL, TY!

@hellogreg, could you review mockup of the breadcrumb docs from an accessibility perspective?

It looks like the new docs web components (like <uxdot-example>) aren't working in this branch. @adamjohnson, does this branch just have to be reset to staging-charmander, which is using the new WCs?

It looks like the new docs web components (like <uxdot-example>) aren't working in this branch. @adamjohnson, does this branch just have to be reset to staging-charmander, which is using the new WCs?

@marionnegp @adamjohnson  I updated this branch and staging/charmander to latest code.  Also there were some issues with the docs in general, I commented on those above in review.  Once those are fixed this will build correctly.

@adamjohnson, I've added breadcrumbs docs.


coatils: Add ls bears cmd

Closes https://github.com/coala/corobo/issues/16
Reviewers Checklist

[ ] Appropriate logging is done.
[ ] Appropriate error responses.
[ ] Handle every possible exception.
[ ] Make sure there is a docstring in the command functions. Hint: Lookout for
botcmd and re_botcmd decorators.
[ ] See that 100% coverage is there.
[ ] See to it that mocking is not done where it is not necessary.

lgtm :+1:

ack 5507b8d

ack 2b90d719836096d1d72fe7d15bb6446b45744cdc

@rultor merge

@rultor merge

@meetmangukiya OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@meetmangukiya Done! FYI, the full log is here (took me 2min)


GraphQL query generated by @index directive fails with Unauthorized error when field is used as @auth groupsField

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
No response
If applicable, what version of Node.js are you using?
No response
Amplify CLI Version
7.6.15
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Amplify Categories
auth, api
Amplify Commands
push
Describe the bug
We migrated our GraphQL model from v1 to v2 as per the migration instructions. A new error seems to have been introduced that gives Unauthorized errors when running an index query on a field that is used as a groupsField. Schema:
type Application @model @searchable @auth(rules: [{allow: groups, groupsField: "projectId"}, {allow: private, operations: [create]}]) {
  id: ID!
  projectId: ID! @index(name: "byProjectId", queryField: "applicationsByProjectId")
  applicationName: String! @index(name: "byApplicationName", queryField: "applicationByName")
  ...
}

The generated query applicationByName works fine and returns only the items that the user is authorized to see via their group membership, however, the applicationsByProjectId query fails and gives the error:
Not Authorized to access applicationsByProjectId on type ModelApplicationConnection

The only difference between these two queries is that the projectId field is used as a groupsField in the auth rule, so we assume this is causing the issue.
Expected behavior
As with before migration to the Transformer V2, both the applicationsByProjectId and applicationByName should return data and not return an unauthorized error.
Reproduction steps

Create a model with an @auth rule that contains a groupsField
Add fields to the model with @index directives containing a queryField parameter, including on the field that is the groupsField
Run the GraphQL query for the groupsField index, it will return unauthorized. The other queries will succeed.

GraphQL schema(s)

# Put schemas below this line
type Application @model @searchable @auth(rules: [{allow: groups, groupsField: "projectId"}, {allow: private, operations: [create]}]) {
  id: ID!
  projectId: ID! @index(name: "byProjectId", queryField: "applicationsByProjectId")
  applicationName: String! @index(name: "byApplicationName", queryField: "applicationByName")
  applicationType: String
}

Log output

# Put your logs below this line

Additional information
No response

Hey @Booligoosh, I see a fix has been pushed for this issue. Could you please let us know if this issue can be closed?

Hi @ykethan, thanks for letting me know. We've done some testing with 8.2.0 and the issue appears to be resolved. Thanks for the fix!

Reopening this as it looks like it's still occurring...


fix penomoran purchasing

Coverage increased (+0.005%) to 78.572% when pulling a3934556123715391c8cd9ad18f5caac25ba3641 on achensetyawati:dev into 6401b7a48b6eb7151a42426eed4260e96550b226 on danliris:dev.


ReGIS data

Would you please upload a copy of the ReGIS output for those of us who are interested in trying it out on other terminals but do not have Z80s? Thanks!

Closed with https://github.com/feilipu/planet-motion/commit/2ed6195de036cb7aa1c120a8f68441e6d4c12851


The master branch does not compile for feature gate ["simd"]

Describe the bug
The master branch cannot compile with --features simd because of arrow-4.4.0 crate.
To Reproduce
rustup default nightly
rustup update
cargo build --features=simd

output
error[E0425]: cannot find function `bitwise_bin_op_simd_helper` in this scope
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/buffer/ops.rs:258:9
    |
125 | / pub fn bitwise_bin_op_helper<F>(
126 | |     left: &Buffer,
127 | |     left_offset_in_bits: usize,
128 | |     right: &Buffer,
...   |
152 | |     buffer.into()
153 | | }
    | |_- similarly named function `bitwise_bin_op_helper` defined here
...
258 |           bitwise_bin_op_simd_helper(
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `bitwise_bin_op_helper`

error[E0425]: cannot find function `bitwise_bin_op_simd_helper` in this scope
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/buffer/ops.rs:369:9
    |
125 | / pub fn bitwise_bin_op_helper<F>(
126 | |     left: &Buffer,
127 | |     left_offset_in_bits: usize,
128 | |     right: &Buffer,
...   |
152 | |     buffer.into()
153 | | }
    | |_- similarly named function `bitwise_bin_op_helper` defined here
...
369 |           bitwise_bin_op_simd_helper(
    |           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: a function with a similar name exists: `bitwise_bin_op_helper`

error[E0412]: cannot find type `ChunksExact` in this scope
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/compute/kernels/arithmetic.rs:521:18
    |
521 |     left_chunks: ChunksExact<T::Native>,
    |                  ^^^^^^^^^^^ not found in this scope
    |
help: consider importing one of these items
    |
25  | use core::slice::ChunksExact;
    |
25  | use std::slice::ChunksExact;
    |

error[E0412]: cannot find type `ChunksExact` in this scope
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/compute/kernels/arithmetic.rs:522:19
    |
522 |     right_chunks: ChunksExact<T::Native>,
    |                   ^^^^^^^^^^^ not found in this scope
    |
help: consider importing one of these items
    |
25  | use core::slice::ChunksExact;
    |
25  | use std::slice::ChunksExact;
    |

error[E0412]: cannot find type `ChunksExactMut` in this scope
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/compute/kernels/arithmetic.rs:523:20
    |
523 |     result_chunks: ChunksExactMut<T::Native>,
    |                    ^^^^^^^^^^^^^^ not found in this scope
    |
help: consider importing one of these items
    |
25  | use core::slice::ChunksExactMut;
    |
25  | use std::slice::ChunksExactMut;
    |

error[E0412]: cannot find type `ChunksExact` in this scope
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/compute/kernels/arithmetic.rs:587:19
    |
587 |     array_chunks: ChunksExact<T::Native>,
    |                   ^^^^^^^^^^^ not found in this scope
    |
help: consider importing one of these items
    |
25  | use core::slice::ChunksExact;
    |
25  | use std::slice::ChunksExact;
    |

error[E0412]: cannot find type `ChunksExactMut` in this scope
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/compute/kernels/arithmetic.rs:589:20
    |
589 |     result_chunks: ChunksExactMut<T::Native>,
    |                    ^^^^^^^^^^^^^^ not found in this scope
    |
help: consider importing one of these items
    |
25  | use core::slice::ChunksExactMut;
    |
25  | use std::slice::ChunksExactMut;
    |

error[E0433]: failed to resolve: use of undeclared type `MutableBuffer`
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/compute/kernels/arithmetic.rs:664:22
    |
664 |     let mut result = MutableBuffer::new(buffer_size).with_bitset(buffer_size, false);
    |                      ^^^^^^^^^^^^^ not found in this scope
    |
help: consider importing this struct
    |
25  | use crate::buffer::MutableBuffer;
    |

error[E0433]: failed to resolve: use of undeclared type `MutableBuffer`
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/compute/kernels/arithmetic.rs:895:22
    |
895 |     let mut result = MutableBuffer::new(buffer_size).with_bitset(buffer_size, false);
    |                      ^^^^^^^^^^^^^ not found in this scope
    |
help: consider importing this struct
    |
25  | use crate::buffer::MutableBuffer;
    |

error[E0220]: associated type `Simd` not found for `T`
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/compute/kernels/arithmetic.rs:456:16
    |
456 | ) -> Result<T::Simd>
    |                ^^^^ associated type `Simd` not found

error[E0220]: associated type `Simd` not found for `T`
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/compute/kernels/arithmetic.rs:454:14
    |
454 |     left: T::Simd,
    |              ^^^^ associated type `Simd` not found

error[E0220]: associated type `Simd` not found for `T`
   --> /Users/shenyijie/.cargo/registry/src/github.com-1ecc6299db9ec823/arrow-4.4.0/src/compute/kernels/arithmetic.rs:455:15
    |
455 |     right: T::Simd,
    |               ^^^^ associated type `Simd` not found

Some errors have detailed explanations: E0220, E0412, E0425, E0433.
For more information about an error, try `rustc --explain E0220`.
error: could not compile `arrow` due to 12 previous errors

Expected behavior
No compilation error.
Additional context
I also install the specific nightly version 2021-07-04 as suggested in https://github.com/apache/arrow-rs/issues/458 but fails either.

@yjshen  are you looking into fixing this problem or do you need help?

@alamb I'm not working on it yet. I encountered the bug and file it here. But at the same time, I find you made a bump up to arrow-rs 5.0 PR and arrow 5.0 compiles with SIMD feature, So I just wait for https://github.com/apache/arrow-datafusion/pull/721 to get merged, and no more questions at my side now.

It seems related to https://github.com/apache/arrow-rs/issues/458 which shows arrow failing to compile with similar errors


large TEXT as a publish starts to not obey a new line

What did I do
try and publish large data, using '/' as a new line
esp_mqtt_client_publish(mqtt_client, "/menu/dmx",
"1 - UDP -  Send DMX frame
2 - UDP -  Send DMX RAMP 4 colors
3 - UMAC - Send DMX frame
4 - UMAC - Send DMX RAMP 4 colors - 5B
5 - UMAC - Send DMX RAMP 4 colors - 400B
6 - UMAC - Send BLANK all LED
7 - Reset STATs
8 - Get STATs
a - Set Default PLC Setup
b - Set PLC Modulation type
c - Set Min/Max Intra-Frame Time
d - Discover Nodes
n - Send message to node x
u - Unicast - Multicast Address
v - START Unicast sACN Transmit
w - STOP unicast sACN Transmit
x - START Multicast sACN Receive
y - STOP Multicast sACN Receive", 0, 0, 0);
What happened
see here (it works for the first 6 lines, then 7 & 8 go crazy, then it works again !?

Expected
all lines should align
Environment

OS: WIn11
MQTTX version 1.9.10

Im sending as rawtext
The / symbol is supposed to be a new line
So in MQTT, any format here ?
I just moved the page separator, and it gets worse
From: Luke Yu @.>
Sent: Monday, April 8, 2024 10:37 PM
To: emqx/MQTTX @.>
Cc: riwalker @.>; Author @.>
Subject: Re: [emqx/MQTTX] large TEXT as a publish starts to not obey a new line (Issue #1623)
Hi, thanks for reaching out. I've tested locally via CLI and the desktop app, and everything works well. Please take a look at the attached images for reference.
image.png (view on web) https://github.com/emqx/MQTTX/assets/21299158/a9bc6cdb-9d74-4913-8d98-636b2f61b990  image.png (view on web) https://github.com/emqx/MQTTX/assets/21299158/a9bc6cdb-9d74-4913-8d98-636b2f61b990
Check the data format on your publishing side. To verify its accuracy, try printing or logging the data before publishing. Thanks for your understanding.
—
Reply to this email directly, view it on GitHub https://github.com/emqx/MQTTX/issues/1623#issuecomment-2044049668 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKT5WTJB7FJ26CIVVB22DY4NH5TAVCNFSM6AAAAABF5VIZ26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBUGA2DSNRWHA .
You are receiving this because you authored the thread.  https://github.com/notifications/beacon/ABIKT5XXX34LYXFWUCY7QRTY4NH5TA5CNFSM6AAAAABF5VIZ26WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTZ2W4QI.gif Message ID: @.*** @.***> >

MQTT supports any data format, including UTF-8 text and binary data.
Using "/" as a separator is not a standard practice.
When MQTTX receives data and converts it to plaintext, it interprets it using UTF-8 encoding for standard text parsing.

If there is no update, I will close this issue; thanks for using it.


Allow disabling TLS verification via env var

Fixes #1030 by allowing the WebhookClient to bypass certificated validation using the environment variable SVIX_DANGEROUS_DISABLE_TLS_VERIFICATION. A warning log is emitted upon WebhookClient creation when this environment variable is set to help dissuade it's use.

Can we test this?
Also, is there any other place we only allow config change through an environment variable? I guess it's fine, but I wonder why a "scary-looking" configuration parameter is also not ok? The users of our software are adults, and I personally don't see a reason why this can't be a proper config param like everything else.

I guess writing tests for this would be easier if there was proper config (though I'm not sure that's what prompted James' two separate points).

A test has been added with the caveat that it requires a new dev-dependency, axum-server.
axum-server provides an alternative to the hyper::Server/axum::Server which allows for HTTPS traffic via either openssl or rustls (of which it was decided to use the tls-openssl feature over the rustls equivalent to save on compilation time and to avoid second version of rustls from being required).
The crate appears reputable for the following reasons:

cargo deny and the security_audit workflow report no known vulnerabilities in this crate or its dependencies
The crate has been recommended by a maintainer of axum (https://github.com/tokio-rs/axum/discussions/1032#discussioncomment-2754752) and is used in official axum examples (https://github.com/tokio-rs/axum/tree/main/examples/tls-rustls). axum is a crate that we already use and trust.
It seems to be actively maintained with the latest commit about nine days ago as of the time of writing this comment.

In searching for a solution to allow an HTTPS-compatible server to be used for testing, no other possibilities came up. At least any that still use axum at their core.
With a cursory review of the source code, and a dive into the documentation, the crate seems to be of a high enough quality for our use.
It is licensed under MIT which is compatible for all our use cases.
Finally, there are very few risks associated with the use of this dependency as it is constrained to a dev-dependency.


export csv missing group header

Most headers witout the context of the group header do not make much sence,
I propose to Prefix the header with its group header
|      Apples       |
|  Red  | Green |
=> Apples Red, Apples Green

this is topical, different people will have different requirements.
i propose a callback, let the user decide what to do.


Move tensor related to tensorPack

@JacksonLChin I removed tensor-related code from this repo. Check if all the results are still the same, then merge it

Thanks for the work. Will merge shortly.


Can't install Vale 2.13.0 using Chocolatey and no VS Code automatic check

When I run: choco upgrade vale it installs Vale v.2.10.0, not the latest Vale 2.13.0 required for readability check. Also, when I finally replaced vale.exe manually in the Chocolatey bin folder on Windows and tried to check the Markdown file in VS Code using the Vale extension, it doesn't show readability scores in the Problems tab. I had to run vale myfilename.md to see the PowerShell output for the readability.

Chocolately has been updated with the latest versions now.


addHtml function of a div does not render the div completely

Hi
I am trying to convert a html div content, which is in a modal dialog. I am using addHtml and the page does not render completely in the pdf document. Instead, I can see only partial content which I can see on the screen. The remaining content which is scrollable is not seen.
Any help how to display the entire div. Thanks in advance

Any help appreciated.

I don't know if we have the same problem but it does that to my d3 generated graph

I'm having the same issue, page with scrollbars does not rendered completely.

+1

Even I have the same issue and I am using html2canvas 0.5.0-alpha2. In the html2canvas, the following code seems to have the issue. Here, "node.ownerDocument.defaultView.innerHeight" seems to consider only the height of the node's viewport. So when there is a scrollable div, only the visible portion gets printed in the pdf.
return renderDocument(node.ownerDocument, options, node.ownerDocument.defaultView.innerWidth, node.ownerDocument.defaultView.innerHeight, index).then(function(canvas) {
if (typeof(options.onrendered) === "function") {
log("options.onrendered is deprecated, html2canvas returns a Promise containing the canvas");
options.onrendered(canvas);
}
return canvas;
});

Same for me,
Only the part of the div visible in the current scroll view is being rendered into the pdf file.
A few days ago though, i didn't run into this problem, which is a bit weird.
I am serving my jspdf.js right from this repository  http://mrrio.github.io/jsPDF/dist/jspdf.debug.js, so I was wondering, could this be some change that happened in the past few days?

OK, just realized something important that might be of use to anyone encountering this problem.
I have a div that's larger in height than the screen height, this means that not all of it can be visible at a time. Now I realized that the problem is somehow related to the current scroll position on the page.
Basically I found out that if the current scroll position is lower than the div, then you will have this rendering issue, but if it is higher up than the div, it renders perfectly.
I am not sure I got this correct, this is just something I found a couple minutes ago, but it works for me now

@ilanle,
That sounds interesting. I think I have similar problem too..

Can some one post an example??? I still have the issue. Tried to implement this.
https://github.com/niklasvh/html2canvas/issues/461

has this fix been addressed?

Hi there,
There's now a html2pdf example which much better supports generating documents from HTML.
Get the latest master and try:
npm install
npm start

Then visit localhost:8000/examples/html2pdf/showcase.html
Hope this works well for you :)
Many thanks,
James

localhost:8000/examples/html2pdf/showcase.html  how can I open this it is local url


Forge use in github actions example

I'd be useful to have a template for using forge to test in a github actions CI pipeline.

Hey @alcibiadeseth,
It should be very similar to this: https://github.com/gakonst/dapptools-template/blob/master/.github/workflows/ci.yml , but instead of the build steps for dapptools, I would use cargo install to install this project.

Yeah it'd basically be:
      - uses: actions/checkout@v2
      - name: Install stable toolchain
        uses: actions-rs/toolchain@v1
        with:
          profile: minimal
          toolchain: stable
      - uses: Swatinem/rust-cache@v1
         with:
          cache-on-failure: true
      - name: Install Foundry
         run: cargo install --git https://github.com/gakonst/foundry --locked
      - name: Run tests
        run: forge test


[release-1.2] Handle host headers in dataplane for identification of channel instances (#1990)

Cherry-pick of https://github.com/knative-sandbox/eventing-kafka-broker/commit/506f2b2aeba382aa53b2665839f4a54603891742

/cc @aliok @matzew

/test channel-integration-tests-sasl-ssl_eventing-kafka-broker_release-1.2


[SPARK-30211][INFRA] Switch python to python3 in make-distribution.sh

What changes were proposed in this pull request?
This PR switches python to python3 in make-distribution.sh.
Why are the changes needed?
Fix build python distribution package in our Docker image:

Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A

Test build #115140 has started for PR 26844 at commit d395904.

Thank you for preparing preview2, @wangyum .

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19952/
Test PASSed.

cc @HyukjinKwon

Hi, @wangyum . This may cause a corrupted Python package.
+ python3 setup.py sdist
Could not import pypandoc - required to package PySpark
/var/folders/p5/tzyffbvj0md4djphs4fym9zw0000gn/T/easy_install-0i5l5_jn/pypandoc-1.4/setup.py:16: DeprecationWarning: Due to possible ambiguity, 'convert()' is deprecated. Use 'convert_file()'  or 'convert_text()'.
  long_description = pypandoc.convert('README.md', 'rst')
Maybe try:

    brew install pandoc
See http://johnmacfarlane.net/pandoc/installing.html
for installation options
---------------------------------------------------------------

!!! pandoc not found, long_description is bad, don't upload this to PyPI !!!

Could you check your python3 on spark-rm has pypandoc? For me, it seems not.
spark-rm@3e4e645813bb:/opt/spark-rm/output$ pip3 freeze
click==6.7
colorama==0.3.7
Jinja2==2.10
livereload==2.5.1
Markdown==2.6.9
MarkupSafe==1.0
mkdocs==0.16.3
pygobject==3.26.1
python-apt==1.6.4
PyYAML==3.12
six==1.11.0
tornado==4.5.3

I didn't run the release script fully. So, please double-check your generated python package with this patch.
At 2.2.3 release, I made this kind of mistake by myself. As you see in the following, it works, but looks ugly if there is no package description. So, I want that you can avoid this.

https://pypi.org/project/pyspark/2.2.3/

cc @gatorsmile

Test build #115140 has finished for PR 26844 at commit d395904.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115140/
Test FAILed.

Retest this please

Test build #115145 has started for PR 26844 at commit d395904.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19957/
Test PASSed.

@dongjoon-hyun It seems we also need to update our Docker image. May be it should be:
diff --git a/dev/create-release/spark-rm/Dockerfile b/dev/create-release/spark-rm/Dockerfile
index cc7da152c7b..eabf3a3b6c8 100644
--- a/dev/create-release/spark-rm/Dockerfile
+++ b/dev/create-release/spark-rm/Dockerfile
@@ -62,14 +62,14 @@ RUN apt-get clean && apt-get update && $APT_INSTALL gnupg ca-certificates && \
   curl -sL https://deb.nodesource.com/setup_11.x | bash && \
   $APT_INSTALL nodejs && \
   # Install needed python packages. Use pip for installing packages (for consistency).
-  $APT_INSTALL libpython2.7-dev libpython3-dev python-pip python3-pip && \
-  pip install $BASE_PIP_PKGS && \
-  pip install $PIP_PKGS && \
+  $APT_INSTALL libpython3-dev python3-pip && \
+  pip3 install $BASE_PIP_PKGS && \
+  pip3 install $PIP_PKGS && \
   cd && \
   virtualenv -p python3 /opt/p35 && \
   . /opt/p35/bin/activate && \
-  pip install $BASE_PIP_PKGS && \
-  pip install $PIP_PKGS && \
+  pip3 install $BASE_PIP_PKGS && \
+  pip3 install $PIP_PKGS && \
   # Install R packages and dependencies used when building.
   # R depends on pandoc*, libssl (which are installed above).
   $APT_INSTALL r-base r-base-dev && \

or
diff --git a/dev/create-release/spark-rm/Dockerfile b/dev/create-release/spark-rm/Dockerfile
index cc7da152c7b..a5af73cc25c 100644
--- a/dev/create-release/spark-rm/Dockerfile
+++ b/dev/create-release/spark-rm/Dockerfile
@@ -61,8 +61,16 @@ RUN apt-get clean && apt-get update && $APT_INSTALL gnupg ca-certificates && \
     pandoc pandoc-citeproc libssl-dev libcurl4-openssl-dev libxml2-dev && \
   curl -sL https://deb.nodesource.com/setup_11.x | bash && \
   $APT_INSTALL nodejs && \
+  # Change default python to python3.6
+  update-alternatives --install /usr/bin/python python /usr/bin/python2.7 1 && \
+  update-alternatives --install /usr/bin/python python /usr/bin/python3.6 2 && \
+  update-alternatives --set python /usr/bin/python3.6 && \
+  # Change default pip to pip3
+  update-alternatives --install /usr/bin/pip pip /usr/bin/pip 1 && \
+  update-alternatives --install /usr/bin/pip pip /usr/bin/pip3 2 && \
+  update-alternatives --set pip /usr/bin/pip3 && \
   # Install needed python packages. Use pip for installing packages (for consistency).
-  $APT_INSTALL libpython2.7-dev libpython3-dev python-pip python3-pip && \
+  $APT_INSTALL libpython3-dev python3-pip && \
   pip install $BASE_PIP_PKGS && \
   pip install $PIP_PKGS && \
   cd && \

I will verify it later.

Thank you, @wangyum . +1 for that!

Do you want to do that separately? Then, I'll merge this first.

BTW, I have a question. This is used for last preview. Is something changed?

cc @jiangxb1987 since he was the release manager of 3.0-preview.

SPARK-29672 changed it: https://github.com/apache/spark/pull/26330/files#diff-8cf6167d58ce775a08acafcfe6f40966

Do you want to do that separately? Then, I'll merge this first.

Yes. I'd like to do that separately.

Let's revert the doc~

Test build #115154 has started for PR 26844 at commit a3a7695.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/19966/
Test PASSed.

It's merged now. Please proceed to the docker issue and ping me if you need my help.

Test build #115145 has finished for PR 26844 at commit d395904.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115145/
Test PASSed.

FYI, make-distribution.sh is also used in the following Jenkins job. I triggered to make it sure that our Jenkins is also ready for this change. If it fails, we need to file a JIRA issue for that separately.

https://amplab.cs.berkeley.edu/jenkins/view/Spark Packaging/job/spark-master-maven-snapshots/2743/

Test build #115154 has finished for PR 26844 at commit a3a7695.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115154/
Test FAILed.


Anthology link checker has false positives

See the internal link checker output for MoMS, for example; it shows appMarker_app_29 as missing from emdTEMP3_M, but in fact it is there.

This appears to be fixed; closing.


[charts] Fix StorageClass mountOptions

StorageClass mountOptions seems not working.
With values :
storageClasses:
  vastdata-filesystem:
    vipPool: vippoolname
    storagePath: "/kubepath"
    viewPolicy: kube_csi
    volumeNameFormat: "csi:kube:{namespace}:{name}:{id}"
    ephemeralVolumeNameFormat: "csi:kube:{namespace}:{name}:{id}"
    mountOptions:
      - proto=tcp
      - port=2049
      - nfsvers=4

Generated StorageClass do not work :
# Source: vastcsi/templates/storage-class.yaml
kind: StorageClass
apiVersion: storage.k8s.io/v1
provisioner: csi.vastdata.com
# ...
mountOptions:
  - "[proto=tcp port=2049 nfsvers=4]"

With this PR :
# Source: vastcsi/templates/storage-class.yaml
kind: StorageClass
apiVersion: storage.k8s.io/v1
provisioner: csi.vastdata.com
# ...
mountOptions:
  - proto=tcp
  - port=2049
  - nfsvers=4

@pmorillon - thanks! We will incorporate this contribution into our internal code repo, and release it as part of our release cycle.

Thanks

May I ask which company you're with?

Eskemm Numérique

@pmorillon - this was incorporated into v2.3


Warning when you are uploading 0 bytes files.

Summary
Warning when you are uploading 0 bytes files.
Ticket Link
MM-9656
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Includes text changes and localization file (.../i18n/en.json) updates

The error uploading the file happen on pre-release but not in master, when we change pre-release to master again, we can verify if the but is still there.

@jespino So we can't upload a file to message drafts that's 0 bytes in size?

With this or you can, but you'll see a warning.


init full_name in dml of version 1.2.2

What is the purpose of the pull request
init full_name in dml of version 1.2.2
Brief change log
init full_name in dml of version 1.2.2

add init full_name sql in dml

Verify this pull request
update dababase
it will init full_name value

+1

Codecov Report

Merging #2341 into dev will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #2341      +/-   ##
============================================
- Coverage     31.27%   31.26%   -0.02%
+ Complexity     1768     1767       -1
============================================
  Files           343      343
  Lines         18103    18103
  Branches       2269     2269
============================================
- Hits           5662     5660       -2
- Misses        11849    11855       +6
+ Partials        592      588       -4

Impacted Files
Coverage Δ
Complexity Δ

...he/dolphinscheduler/api/service/LoggerService.java
91.30% <0.00%> (-8.70%)
7.00% <0.00%> (-1.00%)

...inscheduler/common/task/sqoop/SqoopParameters.java
80.00% <0.00%> (ø)
15.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b17435...9937adc. Read the comment docs.

+1


fix param array indexing validation error reason and error log

Changes
This commit fixes the param array indexing validation error reason and error log, the current reason and error messages are wrongly copied from object validation. This commit fixes this error and adds tests.
/kind bug
Signed-off-by: Yongxuan Zhang<EMAIL_ADDRESS>
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

N/A Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
N/A Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
N/A Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

This is divided from https://github.com/tektoncd/pipeline/pull/6120 to break it into smaller prs

/assign

/lgtm

/test pull-tekton-pipeline-beta-integration-tests
This seems like a network flake:
read tcp <IP_ADDRESS>:41728-><IP_ADDRESS>:443: read: connection reset by peer

/test pull-tekton-pipeline-beta-integration-tests
This seems like a network flake:
read tcp <IP_ADDRESS>:41728-><IP_ADDRESS>:443: read: connection reset by peer

Yes I have seen this a lot recently

thank you @Yongxuanzhang 👍
/approve

Thanks! I opened an issue to fix comment: https://github.com/tektoncd/pipeline/issues/6212

/lgtm

/lgtm


Updates node stacks to use dev

What does this PR do?:
Updates node stacks to use dev
Which issue(s) this PR fixes:
N/A
PR acceptance criteria:

[ ] Contributing guide
Have you read the devfile registry contributing guide and followed its instructions?
[ ] Test automation
Does this repository's tests pass with your changes?
[ ] Documentation
Does any documentation need to be updated with your changes?

How to test changes / Special notes to the reviewer:

CI failures unrelated to changes, merging.

@kadel The CI didn't seem to report that as a failure though:

FAILURE: FAILED TESTS:  python java-quarkus

So even if those failures hadn't occurred, this issue wouldn't have been caught.

yeh, you are right.
It is quite strange, as the URL returns the correct HTTP code 200, but it fails.
This is going to be almost impossible to catch in the script :-/


[MINOR] Fix the wrong comment for HoodieJavaWriteClientExample

What is the purpose of the pull request
(For example: This pull request fixes the wrong comment for HoodieJavaWriteClientExample
Brief change log

Fix the wrong comment for HoodieJavaWriteClientExample

Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #2559 (c9d6a2c) into master (c30481f) will decrease coverage by 41.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #2559       +/-   ##
============================================
- Coverage     50.90%   9.69%   -41.22%
+ Complexity     3167      48     -3119
============================================
  Files           433      53      -380
  Lines         19806    1929    -17877
  Branches       2032     229     -1803
============================================
- Hits          10083     187     -9896
+ Misses         8904    1729     -7175
+ Partials        819      13      -806

Flag
Coverage Δ
Complexity Δ

hudicli
?
?

hudiclient
?
?

hudicommon
?
?

hudiflink
?
?

hudihadoopmr
?
?

hudisparkdatasource
?
?

hudisync
?
?

huditimelineservice
?
?

hudiutilities
9.69% <ø> (-59.78%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


docs: github information

Fixes #997

I added the heading to display like this. Mentors can give feedback if it's good to go or not. Then, I will update every heading like this. Tagging you. @StackScribe ^^

 I added the heading to display like this. Mentors can give feedback if it's good to go or not. Then, I will update every heading like this. Tagging you. @StackScribe ^^

can I add like this? @aepfli


tortoise: use expected layer weight when computing thresholds

Motivation
This is basic for security of the tortoise, otherwise voting is disproportionate to the actual weight and block can be verified even when they supported by true majority (see TestVerifyLayerByWeightNotSize) .
Also important for recovery from the partition where we learn about new atxs. During rerun we will see that the weight increases but we can't make progress with votes from a single beacon, so the verified layer will be stuck until votes from ballots with "bad" beacon can be counted. Will send a followup change for this use case.
closes https://github.com/spacemeshos/go-spacemesh/issues/2946
Changes

expected weight of votes for a block in layer N is derived from atxs of the ballots from all layers after N up to last known

Test Plan
TestVerifyLayerByWeightNotSize, TestComputeExpectedWeight and other uts
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

this is not finished yet, i learned new details and switched it to draft

question: is it more accurate to use GetEpochWeight()/layersPerEpoch?

i thought about this, but then i found the details in the paper and it suggested to use
wB: total weight of blocks in Bt that are eligible to vote about B’s validity
it was computed by summing up weight of blocks when votes were counted, but Tal described another approach which is closer to what you mentioned but a bit more involved. so i will be changing it

@countvonzero i made final changes after latest discussion, ready for review

bors merge


Keep receiving this error on us. and www.

[-] An error occurred while reaching https://www.tiktok.com/api/v1/web/project/create/?creation_id=gxYkhL6dPsIUs73ab6CPx&type=1&aid=1988
[-] Please try to change the --url_server argument to the adapted prefix for your account

maybe you need debug and show me the error response

@546200350 hi, locally works perfect to me. But running in container in Europen VPS, occur this error, can help me, please?

#37

@546200350 hi, locally works perfect to me. But running in container in Europen VPS, occur this error, can help me, please?

I am facing same issue, have you found any solution?


Credentials not recognised in latest release and latest beta release

Dear all,
The Skoda custom component used to run fine untill I restarted my HA server this evening.
I was running the latest release (1.0.38) .  In the logs I got the warning that the credentials might be wrong or the service might nog be working. Since my credentials have not been changed (both for my Skoda and for the custom component) I assume it is the latter one.
This issue also persisted when I have upgraded to the latest beta release (1.0.42 RC2).
Logging into the service worked fine using the mobile phone app or PC.
To give as much information as possible, I have added a screenshot of the warning and a screenshot of the error message from the logs.
Please let me know if I can be of some use testing this custom component.
Many thanks.
Kind regards.

Dear all,
It must have been a server issue at Skoda itself.
After the reboot of this morning, everything was working fine again.
I will close this issue.
Kind regards,


[ffmpeg] add cuda-llvm feature fix qsv

Add cuda-llvm feature
Use LLVM clang ptx backend to compile CUDA code in ffmpeg.
Fix bin2c
The bin2c is not compiling on windows because the current makefile is unable to form a valid MSVC command. And cuda-llvm  depends on it.
qsv
Fixes #29489

On my computer it cannot find schannel and I don't know why or what can explicitly enable to fix the issue. This problem even only popup on debug builds.

Which triplet ?

On my computer it cannot find schannel and I don't know why or what can explicitly enable to fix the issue. This problem even only popup on debug builds.

Which triplet ?

x64-windows

How did last PR even passed CI, the bin2c seems also a problem

Quoting from the linked issue ticket:
portfile.cmake line 413: If openssl isnt used as a feature then schannel is enabled. Schannel is part of the windows SDK so if it cant be found then somethings gone wrong with your installation. The only thing that deleting '--disable-autodetect` is doing is allowing it to silently fail should schannel not be found, which is actually a bug in ffmpeg that is likely to be fixed in a future version. So a proper fix would be to correctly find schannel which seems to be a problem limited to your current setup.

For reference on --disable-autodetect:
Disabling autodetect is required as otherwise ffmpeg will automatically pull in dependency packages from the system (or any location found in PATH) instead of using the ones provided by vcpkg. This can be particular problematic on linux/osx as it can autodetect the presence of packages from apt/homebrew etc. that arent actually supported causing compilation/linker errors. By using --disable-autodetect then ffmpeg build scripts will only pull in dependency packages that are explicitly enabled in the vcpkg portfile which prevents undefined behavior on different systems.

Thank you guys! What about bin2c?

Hi guys, I have rewritten this PR, please have a look.

Anyone have a look tonight?

Feature cuda-llvm and cuda-nvcc test pass on x64-windows.

Can we merge this now? 👀

Can we merge this now? 👀

Please resolve the conflicts.

Fixes #29489

@LilyWangLL 😘

Resolved

Feature qsv successfully tested in the local linux triplet.

This also ready, don't miss it😘

I believe this violates our "don't implement features as alternatives" policy https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#do-not-use-features-to-implement-alternatives.

It is a true world situation and I prefer blaming the vcpkg and its policy for not covering such situation.
We really should provide some "switch" for such alternative behaviour. I personally saw many ports have this problem like mimalloc, etc.
In this case, user can have the right to choose whether use cuda or not, whether to use nvcc or llvm to compile cuda codes. None of them can be made default behaviour. Since this will eventually violates vcpkg's policy, what else can port author do? Maybe abandon this PR for good.
This is a vcpkg design flaw that should be improved.

Might you guys team-review this PR? @vicroms @BillyONeal
I remember that we have encountered this many times, it is totally unnecessary to achieve the "alternative" in another much complicated approach.

I believe this violates our "don't implement features as alternatives" policy https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide#do-not-use-features-to-implement-alternatives.

If the cuda compilation alternatives are an issue then the cuda-nvcc can be removed as its not really all that useful, as it and cuda-llvm do the exact same thing just the later results in a non-redistributable binary whereas the first one doesn't. Which means theres not really much practical use having it apart from giving downstream users an option, although in this case the option doesnt provide any advantages

Any update?

Any update?

I don't expect there to be a substantial update until we have addressed the alternatives problem which we might start at the earliest at the end of March.

OK, I'll wait. Meanwhile, I will remove cuda-nvcc for good for now.

Removed cuda-nvcc. Please review again.

We aren't comfortable changing the default for CUDA compiles from nvcc at this time. As a result, we won't be able to accept a PR with effects like this until we have a better overall answer for alternatives.

OK, let's wait for that😘

Any update on this?

@BillyONeal @JavierMatosD @vicroms Hi guys, any discussion on this alternative feature thing? 😘

@BillyONeal @JavierMatosD @vicroms Hi guys, any discussion on this alternative feature thing? 😘

Pinging @BillyONeal @JavierMatosD for response.

@BillyONeal @JavierMatosD @vicroms Hi guys, any discussion on this alternative feature thing? 😘

Pinging @BillyONeal @JavierMatosD for response.

Alternatives didn't make the cut line for Gallium so it's unlikely we'll be working on them before September.

@BillyONeal @JavierMatosD @vicroms Hi guys, any discussion on this alternative feature thing? 😘

Pinging @BillyONeal @JavierMatosD for response.

Alternatives didn't make the cut line for Gallium so it's unlikely we'll be working on them before September.

Gallium is some milestone codename?

Gallium is some milestone codename?

Yeah, all the Azure/DevDiv/etc. projects are on this every-6-months-or-so schedule where each block is the next element. Zinc ended March 31, Gallium ends ~ September, then Germanium will end next March.

OK let's wait

OK let's wait

I am converting this PR to draft for now.

Hi @BillyONeal , Its near October, any uodate on alternative feature?


Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's render method, or you have multiple copies of React loaded

Hey,
After installing the slingshot, I have added<EMAIL_ADDRESS>to the application
and when running the most basic application, and using a component from material-ui
I get this error :
Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's `render` method, or you have multiple copies of React loaded

Node version:
7.9.0
npm version:
5.3.0
Operating system:
Windows 10
Can somone help please?
Thanks!

This sounds like it is something within Material-UI and how they control the components.
Have you added any refs?
Is your react version within their peer dependency range? I have only seen the multiple reacts loaded in a few scenarios, you setup does not sound to be near the once I have encountered.

@DavidShusterman, this does sound like a peer dependencies issue, https://stackoverflow.com/questions/28519287/what-does-only-a-reactowner-can-have-refs-mean.
Can you remove react from dependencies and add it to peerDepencies in the package.json? e.g. https://github.com/AdaptiveConsulting/react-flex-layout/pull/17/files. Let me know if that fixes the issue.

@DavidShusterman, just wondering if you had a chance to try what I suggested.

Hey nick, thanks for the help. but it seems like your solution hasn't help me.
I have checked to see if I got multiple react instances loaded by running npm list react
and I have only 1 copy installed..
so I think the problem is related to the "You might be adding a ref to a component that was not created inside a component's render method"

@DavidShusterman, do you have a repo where I can look at this issue?

@nickytonline
I'm sorry but its a private repo...
But you can simply install the slingshot, and then install material-ui, and apply a component of material-ui and ull recreate the problem..

I've not tried with those versions, but I have a couple of slingshot starter apps that remove the demo and put in one sample component. I have one for bootstrap and one for material-ui which worked fine:

@DavidShusterman, did you ever get this resolved or is this still an issue for you?

Closing - Please provide simple reproducible example if issue persists.


Gracefully handle polling history on standby

Return more detailed error on standby side when polling for history. Also enable skip archival on getHistory.

We do autoforwarding of startWorkflow requests but not of getHistory this makes a bad experience for customers that want to start a workflow on then block on the result from the standby side. This error message and not querying archival will improve the experience here.

Low risk

Coverage decreased (-0.5%) to 67.154% when pulling 266df9901614788157ea0d4dc29b5efc537a5173 on StandbyPollOnHistory into 4d80f0b4fd9ce1e7c4560f44ec4b1e34af014d70 on master.


Documentation - topics/search section migration to markdown

Part of https://github.com/wagtail/wagtail/issues/8383
Note: a few small changes have been made
Less reliance on multiple note admonitions in a row
Remove tip usage and replace with note admonition as per recommendations in documentation writing guide.
Reduce heading nesting in searching.md - it appeared to be heavily nested in a way that did not flow well, the 'changing search behaviour' is now a h2 instead of h3 with the headings under that moving up one level.
[x] Does the code comply with the style guide?
[x] For new features: Has the documentation been updated accordingly?
Important: Intentionally two commits to preserve the history of the file with git.

This also fixes a bug with a link shown in screenshot below.

Before
After

Section heading comparison
Comparison of the way the sections are nested now.

Before
After

Thanks @zerolab


Add debug instance index argument when running multiple instances

When running multiple instances (eg. Debug->Run Multiple Instances->Run 3 Instances), there is no automatic way to tell one instance to behave differently to the others (eg. you might want one instance to host a game and the others to join it).
When running more than one instance, this PR adds an argument accessible through OS.get_cmdline_args() for the index of the instance. Each instance will always be assigned a different number from 0 to n-1 for n instances.

This seems useful for but not very discoverable, users would need to check the command line or source code to know about it.

There is a discussion about debug instance arguments here: #57975, and a somehow related proposal here: https://github.com/godotengine/godot-proposals/issues/522


Getx Flutter - Updating item in list is not reactive

**I am using getx as my statemanagment for my flutter app. But I am having difficulties by updating the values in a list. So I have a usermodel with a parameter of isFollowing. When I click on a button the isFollowing variable shall change and the color should be updated. But it is not happening. I am using Obx as my widget, as I already injected the state at the beginning. It is all working fine with fetching the data and displaying it on the frontend. But when I wanna change the values in my list, it is not updating. My minimal reproducible example. **
HomeController
class HomeController extends GetxController {
  var userslist = List<User>().obs;

  @override
  void onInit() {
    fetchUsers();
    super.onInit();
  }

  void fetchUsers() async {
    var users= await ApiService().getapidata('${usersurl}feed');
    if (users!= null) {
      userslist.value= users;
    }
  }
}

Model
class User {
  User({
    this.id,
    this.user_name,
    this.profile_picture,
    this.isFollowing,
  });

  int id;
  String user_name;
  String profile_picture;
  bool isFollowing;

  factory User.fromJson(Map<String, dynamic> json) => User(
        id: json["id"],
        user_name: json["user_name"],
        profile_picture: json["profile_picture"],
        isFollowing: json["is_following"],
      );

HomePage
class HomeScreen extends StatelessWidget {
  final HomeController homeController = Get.put(HomeController());

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SingleChildScrollView(
        physics: ScrollPhysics(),
        child: Obx(
          () => ListView.builder(
            shrinkWrap: true,
            physics: NeverScrollableScrollPhysics(),
            itemCount: homeController.usersList.length,
            itemBuilder: (context, index) {
              return UserWidget(homeController.usersList[index], index);
            },
          ),
        ),
      ),
    );
  }
}

UserWidget
class UserWidget extends StatelessWidget {
  final User user;
  final int index;
  UserWidget (this.user, this.index);
  @override
  Widget build(BuildContext context) {
    return InkWell(
        onTap : ()=> user.isFollowing = true // When I click on this the container it  shall be updated to yellow
        child: Obx( () => Container(
        decoration: const BoxDecoration(color: user.isFollowing ? Colors.yellow : Colors.black ), // Here is the update I wanna make
      ))
    );
  }
}

Your User objects in the List must be Rx objects for reactive changes.
Try change you code some like this:
  void fetchUsers() async {
    var users= await ApiService().getapidata('${usersurl}feed');
    if (users!= null) {
      userslist.value= users.map((item) => item.obs)
    }
  }

duplicate of https://github.com/jonataslaw/getx/issues/615

Hi Jonatas, when I refer to the duplicate  question , I cant still implement it. As it is saying, Improper use of getx or obx has been detected. Could you provide an example with the code I have given please.

var userslist = List<Rx<User>>().obs; // you need a list of reactive model. The correct is use literal: <Rx<User>>[]
Update the inner variable:
   return InkWell(
        onTap : ()=> user.update(()=> user.isFollowing = true); // When I click on this the container it  shall be updated to yellow
        child: Obx( () => Container(
        decoration: const BoxDecoration(color: user.isFollowing ? Colors.yellow : Colors.black ), // Here is the update I wanna make
      ))

Thank you sooo much, finally it is working . I was stuck with this problem since 2 days

list.value    list.assignAll


Fix simple typo: wich -> which

Closes #297

Coverage decreased (-0.8%) to 67.459% when pulling 128d4ffb882599a5537af480c422144001ba6267 on timgates42:bugfix/typo_which into 5b85d998c30ddc6772b56310713530224466083a on clips:master.


[Diagnostics] Namespace with no public types causes CsWinRT1001

Describe the bug
Namespaces with no public types get diagnostics raised on them when they shouldn't. We should ignore namespaces that don't have public types.
To Reproduce

Make a runtime component, say MyComponent
Have a namespace such as MyComponent.Foo and Utilities
Utilities should have no public types, MyComponent.Foo should

Expected behavior
Utilities should be ignored as it will not be used in the Windows Runtime
Additional context
When the TypeCollector runs, have it check if a namespace has public types.
Get a repro with two namespaces as described, then make a unit test and update the diagnostics.

I think #737 fixed this as well


Investigate adding From the Archive releases

Clarification on legality of using the LivePhish: From the Archive would be good. If it's legal, then we can replace existing AUDs with the SBDs.
Aug 2024 update: After poking around, it seems like it's unlikely legal action would be taken, a cease and desist at worst. Worth looking into at least.

After taking a look at the content, I'm struck by a couple things:

Quality varies, and sometimes a track in FTA is already an SBD on phish.in, so no real quality improvement.
Tracks are individual selections from individual shows. To include them we'd either need a special FTA section that doesn't fit into the normal show date framework, or we'd need to replace individual tracks. This could be jarring to the listener who expects a full show by the same taper.

I'm not sure the FTA releases fit into the vision of the site and they'll always be hosted on the Spreadsheet, so closing this for now.


Crash detected when deploying contracts with array init args

Problem
When using flow accounts add-contract command to deploy a contract with an array of values as init parameters, CLI crashes. However, passing an array to scripts seems to work just find.
Steps to Reproduce
Try deploying this simple contract:
access(all) contract Foo {

    access(all) var bars: [Int]

    access(all) fun foo(i: Int): Int {
        return (self.bars.length - 1) >= i ? self.bars[i] : 0
    }

    init(bars: [Int]) {
        self.bars = bars
    }
}

with the command:
flow accounts add-contract ./cadence/contracts/Foo.cdc '[1]'

And note the crash output
❌ Crash detected!

✔ No

Please help us improve the Flow CLI by opening an issue on https://github.com/onflow/flow-cli/issues,
and pasting the output as well as a description of the actions you took that resulted in this crash.

runtime error: invalid memory address or nil pointer dereference
[] []
map[device:map[arch:arm64 num_cpu:8] os:map[name:darwin] runtime:map[go_maxprocs:8 go_numcgocalls:6 go_numroutines:11 name:go version:go1.21.3]]
goroutine 1 [running]:
runtime/debug.Stack()
	runtime/debug/stack.go:24 +0x64
github.com/onflow/flow-cli/internal/command.initCrashReporting.func1(0x1400023fb80, 0x14000b27020)
	github.com/onflow/flow-cli/internal/command/command.go:314 +0x1c8
github.com/getsentry/sentry-go.(*Client).processEvent(0x1400070b2c0, 0x1400023fb80, 0x14000b27020, {0x10294aea0, 0x14000414ea0})
	github.com/getsentry/sentry-go@v0.25.0/client.go:631 +0x228
github.com/getsentry/sentry-go.(*Client).CaptureEvent(...)
	github.com/getsentry/sentry-go@v0.25.0/client.go:447
github.com/getsentry/sentry-go.(*Client).RecoverWithContext(0x60?, {0x0?, 0x0}, {0x1025d9be0?, 0x103b64da0?}, 0x100e9306c?, {0x10294aea0, 0x14000414ea0})
	github.com/getsentry/sentry-go@v0.25.0/client.go:498 +0x1d4
github.com/getsentry/sentry-go.(*Client).Recover(0x0?, {0x1025d9be0?, 0x103b64da0?}, 0x0?, {0x10294aea0?, 0x14000414ea0?})
	github.com/getsentry/sentry-go@v0.25.0/client.go:462 +0x80
github.com/getsentry/sentry-go.(*Hub).Recover(0x14000a28d58?, {0x1025d9be0?, 0x103b64da0?})
	github.com/getsentry/sentry-go@v0.25.0/hub.go:330 +0xc0
github.com/getsentry/sentry-go.Recover()
	github.com/getsentry/sentry-go@v0.25.0/sentry.go:68 +0x40
panic({0x1025d9be0?, 0x103b64da0?})
	runtime/panic.go:914 +0x218
github.com/onflow/flow-cli/flowkit/transactions.addAccountContractWithArgs(0x140001859a0, {{0x14000a42ba8?, 0xe1?}, {0x140008d41e0?, 0x1?}}, {0x14000a06910, 0x1, 0x1b?})
	github.com/onflow/flow-cli/flowkit@v1.3.5-0.20230808220356-6a2bfeb10552/transactions/transaction.go:121 +0x2e0
github.com/onflow/flow-cli/flowkit/transactions.NewAddAccountContract(...)
	github.com/onflow/flow-cli/flowkit@v1.3.5-0.20230808220356-6a2bfeb10552/transactions/transaction.go:82
github.com/onflow/flow-cli/flowkit.(*Flowkit).AddContract(0x14000159c20, {0x2e1?, 0x16f68362b?}, 0x140001859a0, {{0x14000698300, 0xe1, 0x2e1}, {0x14000a06910, 0x1, 0x1}, ...}, ...)
	github.com/onflow/flow-cli/flowkit@v1.3.5-0.20230808220356-6a2bfeb10552/flowkit.go:299 +0x224
github.com/onflow/flow-cli/internal/accounts.init.deployContract.func3({0x140001b33e0, 0x2, 0x2}, {{0x0, 0x0}, {0x101e0ad73, 0x4}, {0x0, 0x0}, {0x0, ...}, ...}, ...)
	github.com/onflow/flow-cli/internal/accounts/contract-add.go:93 +0x2f0
github.com/onflow/flow-cli/internal/command.Command.AddToParent.func1(0x1400077c500?, {0x140001b33e0, 0x2, 0x2})
	github.com/onflow/flow-cli/internal/command/command.go:141 +0x4f0
github.com/spf13/cobra.(*Command).execute(0x103b91ac0, {0x14000160030, 0x2, 0x2})
	github.com/spf13/cobra@v1.7.0/command.go:944 +0x640
github.com/spf13/cobra.(*Command).ExecuteC(0x14000700f00)
	github.com/spf13/cobra@v1.7.0/command.go:1068 +0x320
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.7.0/command.go:992
main.main()
	github.com/onflow/flow-cli/cmd/flow/main.go:118 +0xb48

Device Info
macOS 13.6 (22G120)
Flow CLI Version: v1.5.0

I looked abit at this and when runtime.ParseLiteral parses the string '[1]' it returns the following cadence value.
cadence.Array{
  ArrayType: nil,
  Values: []cadence.Value{
    cadence.Int{
      Value: &big.Int{},
    },
  },
}

ArrayType is here nil and that is causing the panic above. So this is a bug in cadence?

Yeah I looked into now, this seems like a bug in Cadence


Problem in video chats with 3 or more users

Video conferencing with two persons runs very well, but if a third participant joins the meeting, video call not work , I can see only my cam.
I used your example without customize server link
jitsi_meet_wrapper: ^0.0.5
flutter 3.0.1

I think that has nothing to do with jitsi_meet_wrapper. I have noticed this, too, sometimes. It also happens on the web version of Jitsi. I will however soon release a new version with updated Jitsu SDK. Maybe it is fixed it that version.


[Bug] Error with Pipenv on Windows 10

I tried to use Leon on Windows 10 and have an error with pipenv.
Leon check produces:
Error: Command failed with exit code 1: pipenv --version
'pipenv' is not recognized as an internal or external command,
operable program or batch file.
at makeError (C:\Users\asuqi.leon\node_modules\execa\lib\error.js:59:11)
at handlePromise (C:\Users\asuqi.leon\node_modules\execa\index.js:114:26)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Promise.all (index 2)
at C:\Users\asuqi.leon\scripts/check.js:43:6 {
shortMessage: 'Command failed with exit code 1: pipenv --version',
command: 'pipenv --version',
exitCode: 1,
signal: undefined,
signalDescription: undefined,
stdout: '',
stderr: "'pipenv' is not recognized as an internal or external command,\r\n" +
'operable program or batch file.',
failed: true,
timedOut: false,
isCanceled: false,
killed: false
}
leon create birth also had the error:
Error: Impossible to register Pipenv environment variables
For further information, look at the log file located at<EMAIL_ADDRESS>The txt file shows:
[leon create birth] Impossible to register Pipenv environment variables
LogError: Error while getting the path of python3 libraries

Hey! @Austen-Suqi
Thanks for your report, it is indeed a bug.
This should now be fixed.
Could you confirm that it works with the latest CLI version (v1.1.4)?


Fix debug message

We're fetching the destination tag here. The build tag is something
different.
Signed-off-by: Tim Waugh<EMAIL_ADDRESS>Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
[n/a] JSON/YAML configuration changes are updated in the relevant schema
[n/a] Changes to metadata also update the documentation for the metadata
[n/a] Pull request has a link to an osbs-docs PR for user documentation updates
[n/a] New feature can be disabled from a configuration file

Nice catch Tim. Verified in logs:
2021-04-13 08:44:09,667 platform:- - atomic_reactor.utils.koji - INFO - Tagging build with osbs-test-1.0-rhel-7-candidate

https://brewweb.stage.engineering.redhat.com/brew/buildtargetinfo?targetID=9576

No RN, fix in debug message


More fine grained colors for date column

it would be amazing to add more layers of colors to Last time modifies, with differentiation of

[last hour],
[last day],
[rest of this week],
[Previous week],
[rest of this month],
[previous month],
[almost readable grey color  for files older than 2 months]

Is this still being looked at and/or worked on?
I think it would be nice to have full control over the time frame definitions available to the user in the theme config. Times could be defined using plain seconds or shorthand, which would preserve the easy configuration that predefined values provide (e.g. "1h" for one hour, ">1m" for greater than one month, etc.).

I would love to see this feature in lsd soon.
+1


Define a Cargo workspace

Just makes development a bit more comfortable, e.g. cargo run now works in the repository root directory ... and you can now open the repository in VS Code and rust-analyzer will work also for the other non-root crates.

I know this is really appealing, and I really want to do this. Unfortunately this forces all dependency resolution to be shared which breaks the test runs on older Rust versions :(

Ah yes compilation indeed failed but only because I deleted the Cargo.lock file making Cargo pick some dependencies that used Rust edition 2021, which isn't yet available in our MSRV 1.51.0.
I have now added the Cargo.lock file of the workspace to the commit ... I did have to run the following five commands (basically downgrading to the previous dependency version everytime the error came up):
cargo update -p once_cell --precise 1.14.0
cargo update -p pest_derive --precise 2.3.1
cargo update -p pest_generator --precise 2.3.1
cargo update -p pest_meta --precise 2.3.1
cargo update -p pest --precise 2.3.1

But the crate now builds with Rust 1.51.0 :) (Note that cargo test still fails but that's also happening on master because of features used in some tests/* files).

Yeah, i'm aware of this but I don't like that setup. I know it's not a lot of fun with two workspace and eventually I want to fix this, but for now I prefer the current setup.

I am curious, what do you dislike about that setup?

Would a reasonable compromise be accepting a PR when the MSRV catches up?

@not-my-profile I do not want to require specific lock files for tests to pass. That makes it too easy to miss when dependencies on the insta crate create an MSRV incompatibility. That's why I want to have these separated for now. Insta should be install and testable on its own MSRV rules without a lockfile but that has different requirements than cargo-insta.
@max-sixty that's my goal, yes.