bug in multiple authenticator

I've two authenticator config with the scheme as session that uses different tables.
When I try to login every think is OK but when I want to give info about logged in user there are some problems.
For example I login as admin but in middleware, both of this code return true
await auth.authenticator('admin').check()
and
await auth.authenticator('user').check()
Also when I want to get info about logged in user both of this code return a different user:
await auth.authenticator('admin').getUser()
and
await auth.authenticator('user').getUser()
So I can't role of logged in user.

Can you share the config/auth.js file?

`
authenticator: 'user',
/*
|--------------------------------------------------------------------------

Session

Session authenticator makes use of sessions to authenticate a user.

Session authentication is always persistent.

*/

admin: {

serializer: 'lucid',
model: 'App/Models/Admin',
scheme: 'session',
uid: 'email',
password: 'password'

},
user: {
serializer: 'lucid',
model: 'App/Models/User',
scheme: 'session',
uid: 'email',
password: 'password'
},
`

How come users for different models (hopefully db tables too) can be same?

Sorry @thetutlage, I can understand your mean.
As I said I have two role in my system admin and user and both of them have same field like email and password.
this my signin action code:
try {
      await auth.authenticator('user')
        .remember(request.input('remember'))
        .attempt(request.input('email'), request.input('password'))
    } catch (error) {
      try {
        await auth.authenticator('admin')
          .remember(request.input('remember'))
          .attempt(request.input('email'), request.input('password'))
      } catch (error) {
        session.flash({
          errors: ['wrong email or password']
        }).flashExcept(['password'])
        return response.redirect('back')
      }
    }

then in my middleware when I try to auth status:
async handle({
    request,
    auth,
    response
  }, next) {
    try {
      const userAuthenticator = auth.authenticator('user')
      await userAuthenticator.check()
    } catch (error) {
      try {
        const adminAuthenticator = auth.authenticator('admin')
        await adminAuthenticator.check()
      } catch (error) {
        return response.redirect('/auth')
      }
    }

    await next()
  }

Now my problem is there. when I logged in with admin email, password both of userAuthenticator.check() and adminAuthenticator.check() return true
and userAuthenticator.getUser() return a user's record  :|

Having 2 roles doesn't mean that they will be authenticated differently and neither you need 2 authenticators.
The user simply login and then you check for the user role for specific resources. You are approaching ACL in the wrong way.

Also since, it's not a bug. I suggest discussing this on a forum or the discord server

Closing since no response from the issue reporter and not actionable as well


Compatibility with biblatex

Since bibunits has a conflict error with biblatex, this package doesn't load when biblatex is loaded. Is it possible to not load bibunits? For instance, when using bibliography=common.

Thanks, it works now. Regarding bibilography=separate,  can you add the support for biblatex, but make it optional?


[SPARK-31705][SQL] Push more possible predicates through Join via CNF conversion

What changes were proposed in this pull request?
This PR add a new rule to support push predicate through join by rewriting join condition to CNF(conjunctive normal form). The following example is the steps of this rule:

Prepare Table:

CREATE TABLE x AS SELECT * FROM (VALUES (1, 2, 3, 4)) AS x(a, b, c, d);
CREATE TABLE y AS SELECT * FROM (VALUES (1, 2, 3, 4)) AS x(a, b, c, d);
EXPLAIN SELECT x.* FROM x JOIN y ON ((x.a > 1 AND x.a < 3 AND y.b = 1) OR (x.a > 3 AND x.a < 5 AND y.b = 2));

Convert the join condition to CNF:

Step
Current condition

init
(x.a > 1 AND x.a < 3 AND y.b = 1) OR (x.a > 3 AND x.a < 5 AND y.b = 2)

step 1
((x.a > 1 AND x.a < 3) OR (x.a > 3 AND x.a < 5 AND y.b = 2)) AND ((y.b = 1) OR (x.a > 3 AND x.a < 5 AND y.b = 2))

step 2
((x.a > 1 AND x.a < 3) OR (x.a > 3 AND x.a < 5)) AND ((x.a > 1 AND x.a < 3) OR (y.b = 2)) AND ((y.b = 1) OR (x.a > 3 AND x.a < 5 AND y.b = 2))

step 3
((x.a > 1 AND x.a < 3) OR (x.a > 3 AND x.a < 5)) AND ((x.a > 1 AND x.a < 3) OR (y.b = 2)) AND ((y.b = 1) OR (x.a > 3 AND x.a < 5)) AND ((y.b = 1) OR (y.b = 2))

Split conjunctive predicates

Predicates
---|
((x.a > 1 AND x.a < 3) OR (x.a > 3 AND x.a < 5))
((x.a > 1 AND x.a < 3) OR (y.b = 2))
((y.b = 1) OR (x.a > 3 AND x.a < 5))
((y.b = 1) OR (y.b = 2))

Push predicate

Table
Predicate

x
((x.a > 1 AND x.a < 3) OR (x.a > 3 AND x.a < 5))

y
((y.b = 1) OR (y.b = 2))

Why are the changes needed?
Improve query performance. PostgreSQL, Impala and Hive support this feature.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test and benchmark test.

SQL
Before this PR
After this PR

TPCDS 5T Q13
84s
21s

TPCDS 5T q85
66s
34s

TPCH 1T q19
37s
32s

As I talked to @wangyum offline, I am taking https://github.com/apache/spark/pull/28575 over for the CNF implementation and config naming.
There have been PRs for CNF conversion, such as https://github.com/apache/spark/pull/10444, https://github.com/apache/spark/pull/15558, #28575. The common issue is the recursive implementation can slow, or even cause a stack overflow exception.
With this non-recursive implementation, the rule should be faster and more robust.

Test build #123556 has started for PR 28733 at commit 729be0f.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28179/
Test PASSed.

Test build #123556 has finished for PR 28733 at commit 729be0f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123556/
Test PASSed.

Test build #123577 has started for PR 28733 at commit a216cf8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28200/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28201/
Test PASSed.

Test build #123578 has started for PR 28733 at commit a9a5c0b.

Test build #123577 has finished for PR 28733 at commit a216cf8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123577/
Test FAILed.

Test build #123578 has finished for PR 28733 at commit a9a5c0b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123578/
Test FAILed.

test failure from TPCDSQuerySuite:

18884 was not less than or equal to 8000 too long generated codes found in the WholeStageCodegenExec subtree (id=375762) and JIT optimization might not work:

I will update the PR to simplify the pushed down predicates

Test build #123585 has started for PR 28733 at commit cbc1220.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28209/
Test PASSed.

Test build #123585 has finished for PR 28733 at commit cbc1220.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123585/
Test PASSed.

I find a simpler solution and create https://github.com/apache/spark/pull/28741.
Close this one now.

Test build #123601 has started for PR 28733 at commit cbc1220.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28225/
Test PASSed.

Test build #123601 has finished for PR 28733 at commit cbc1220.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123601/
Test PASSed.

Test build #123617 has started for PR 28733 at commit 97c3414.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28240/
Test PASSed.

Test build #123618 has started for PR 28733 at commit 2976a60.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28241/
Test PASSed.

Test build #123617 has finished for PR 28733 at commit 97c3414.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123617/
Test PASSed.

Test build #123618 has finished for PR 28733 at commit 2976a60.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123618/
Test PASSed.

Test build #123686 has started for PR 28733 at commit f951463.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28309/
Test PASSed.

Test build #123686 has finished for PR 28733 at commit f951463.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123686/
Test PASSed.

Test build #123705 has started for PR 28733 at commit a0c7110.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28329/
Test PASSed.

Test build #123707 has started for PR 28733 at commit 934a412.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28331/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28334/
Test PASSed.

Test build #123710 has started for PR 28733 at commit af33605.

Test build #123705 has finished for PR 28733 at commit a0c7110.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123705/
Test PASSed.

Test build #123707 has finished for PR 28733 at commit 934a412.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123707/
Test PASSed.

Test build #123710 has finished for PR 28733 at commit af33605.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait PredicateHelper extends Logging

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123710/
Test PASSed.

Test build #123729 has started for PR 28733 at commit 15437b3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28353/
Test PASSed.

Test build #123729 has finished for PR 28733 at commit 15437b3.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123729/
Test FAILed.

retest this please.

Test build #123731 has started for PR 28733 at commit 15437b3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28355/
Test PASSed.

Test build #123733 has started for PR 28733 at commit 04ca8d4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28357/
Test PASSed.

Test build #123745 has started for PR 28733 at commit 80e2b6b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28369/
Test PASSed.

Test build #123749 has started for PR 28733 at commit 7c102a5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28373/
Test PASSed.

Test build #123749 has finished for PR 28733 at commit 7c102a5.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123749/
Test FAILed.

Test build #123731 has finished for PR 28733 at commit 15437b3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123731/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28414/
Test FAILed.

Test build #123803 has started for PR 28733 at commit b42ce1d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28429/
Test PASSed.

@wangyum @maropu @viirya @dilipbiswal @AngersZhuuuu @cloud-fan Thanks for the review. I think this PR is ready to be merged once the tests are passed. Let me know if you still have more comments.

Test build #123803 has finished for PR 28733 at commit b42ce1d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123803/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/28455/
Test PASSed.

Test build #123831 has started for PR 28733 at commit b42ce1d.

(Just to check) Btw, it seems the previous works about CNF tried to implement this conversion in an independent rule for Filter plans  (e.g., the @viirya one: https://github.com/apache/spark/pull/15558/files#diff-a1acb054bc8888376603ef510e6d0ee0R139). On the other hand, this PR only targets at join queries. Is this because this conversion has a severe trade-off relationship between time complexity / performance gains, but join quries can get much performance improvements even in this case? Is my understanding correct?

@maropu Yes pushing down predicates through join should be the major scenario.

@maropu
After this merge I will raise a pr base on his non-recursive code  to improve data scan's partition pruning.
https://github.com/apache/spark/pull/24973

LGTM

Test build #123831 has finished for PR 28733 at commit b42ce1d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123831/
Test PASSed.

Merging to master


refactor(cdk/overlay): formatting

Just noticed unformatted files after running yarn ng-dev format all.

It looks like these files have been formatted in master already. Closing.


Fixes site name for MkDocs

Paweł Świszcz found this bug and reported it on Slack:
https://github.com/zendframework/zend-expressive-authentication-basic/blob/e340d55337ed65a8f064640e7e48c3bac9034df1/mkdocs.yml#L6
This results in a wrong header and installation command in the documentation:

Component Name Goes Here
$ composer require zendframework/Component Name Goes Here

https://docs.zendframework.com/zend-expressive-authentication-basic/

Thanks, @froschdesign.


Add Checkbox.HasCheckedState matcher

Sometimes is not convenient to use Checkbox.Checked matcher if condition is flexible, in such cases it would be good to have parameterized matcher

done in 2ad5465


Korean translation

Hello! I'm a Korean who is interested in this program.
I have found that this program does not support Korean yet.
If you don't mind, can I translate it into Korean?
I'd really appreciate your answer.
Thanks!

Yes, you can translate.


autodocking tools

Hello !
I am trying to run autodock vina, I have this txt file:
Define the receptor and ligand files
receptor = ab.pdbqt
ligand = antigen.pdbqt
Output file for docking results
out= docking.pdbqt
Define the center of the search space
center_x = 35.739
center_y = 26.403
center_z = 12.114
Define the size of the search space (in Angstroms)
size_x = 30
size_y = 30
size_z = 30
Log file for Vina's output
log= log.txt
But I have this error:
Error: could not open "antigen.pdbqt" for reading.
Knowing that the pdbqt files I have it from amg autodock tool.

Hello, maybe it's in a different folder?


Support disabling mutators through Profile fields

This PR allows mutators to be disabled when the name of the mutator is included in a profile's disabledMutators field. Disabling mutators is helpful for:

running instances of Fuzzilli with different mutators without having to maintain/build two separate Fuzzilli binaries
experimenting with a subset of mutators
tailoring Fuzzilli for a target (e.g. JS engines without JIT compilers can disable JITStressMutator without maintaining a fork of Fuzzilli or JS engines that have not implemented language features used in JavaScriptExploreLifting.swift can disable ExplorationMutator)

Test plan

Add print statement to print out list of mutators in main.swift
Add any mutator into disabledMutators field for any profile (e.g. JITStressMutator)
Run Fuzzilli and check if mutator is present in the list of mutators printed out

WeightedList<Mutator>(elements: [(elem: Fuzzilli.ExplorationMutator, weight: 3, cumulativeWeight: 0), (elem: Fuzzilli.CodeGenMutator, weight: 2, cumulativeWeight: 3), (elem: Fuzzilli.SpliceMutator, weight: 2, cumulativeWeight: 5), (elem: Fuzzilli.ProbingMutator, weight: 2, cumulativeWeight: 7), (elem: Fuzzilli.InputMutator, weight: 2, cumulativeWeight: 9), (elem: Fuzzilli.InputMutator, weight: 1, cumulativeWeight: 11), (elem: Fuzzilli.OperationMutator, weight: 1, cumulativeWeight: 12), (elem: Fuzzilli.CombineMutator, weight: 1, cumulativeWeight: 13)], totalWeight: 14)

Example usage
// HermesProfile.swift
let hermesProfile = Profile(
    ...
    disabledMutators: ["JITStressMutator"],
    ...
)

// HermesExperimentalProfile.swift
let hermesProfile = Profile(
    ...
    // Fuzzilli instance focused on variant finding
    disabledMutators: ["JITStressMutator", "CodeGenMutator", "SpliceMutator", "CombineMutator"],
    ...
)

As a note: The CI build job failures seem to be related to https://github.com/googleprojectzero/fuzzilli/commit/292aa0b97fa25b9af413d5a7c06e7bb9ac8556c3 and not to the changes in this PR

Thank you so much Edward! :)
Yes, we are aware of the CI failures, we are ignoring them for now.


Added reuseAddr: true to dgram.createSocket

Now it's possible to use the Artnet-Libary with another Artnet-enabled-Software running on the same device (Tested with DMXControl3)

thx for PR 👍


sample_data tests and functions

Adding finished function, #18

Used helper functions like in missing data function

Need to:

Write tests for this function

Next commit will address adding functions that check summarize_data helper function

Note that at this point some tests are failing right now - currently debugging

Hi Monique! WELL DONE! The functions, the output, and the tests all look great. You did such a beautiful job and I don't know what I can add. Should've added the review before you debugged all the test 👍


Updated homepage with new logos and categories

The previous pyviz.org homepage had a partial listing of some of the supported libraries, without any way for the user to see that they were each supported in very different ways.  This PR adds many more logos and sorts them into meaningful categories:

Looks fabulous to me, much better than putting them all together. My only comment/question is whether we should consider moving param to the top, I can see arguments either way though.

I'd add logos for geopands, colorcet, vega, and vega-lite, but none of those have proper logos yet.

It doesn't make an exceptionally great logo but geopandas does have a logo: https://pbs.twimg.com/profile_images/507620807242039297/UhLrFw_Q_400x400.png

My only comment/question is whether we should consider moving param to the top, I can see arguments either way though.

Yes, I've tried it both ways, and Jean-Luc and I have already discussed that.  It definitely doesn't fit where it is, and it's a bit buried there, but I'm not sure we want to present it as a "core high-level library". Is it something we want people to start with, or end up with?  At the moment I've leaned towards the latter, which is why it is down there, but I think it's worth discussing and maybe voting.

This looks great! I was trying to write something similar - but this is much more comprehensive. My only comment is it seems like there should be a more visual way of presenting the relationships between the libraries, maybe as building blocks or something? That can obviously be added later if someone makes it.

I've moved Param to the first item in Other, so that it stands out better, and explained it slightly more.  I also added a GeoPandas logo as suggested, created a Vega logo out of nothing, and updated the FAQ and Roadmap to reflect Panel and other recent improvements.

There should be a more visual way of presenting the relationships between the libraries, maybe as building blocks or something.

Yes, but it's tricky.  The usual such diagrams are just based on layers, where one thing builds on another, but here the packages have complex relationships to each other that don't quite fit that organization.  We probably do need such a figure for giving talks, and I'll probably make one the next time I give a talk, but at least the various packages now (a) have logos of the right sort and (b) are in meaningful groups, which is a starting point.


Document FileTarget inner properties/methods

Current coverage is 70.65%

Merging #982 into master will not affect coverage as of 6f52383

@@            master    #982   diff @@
======================================
  Files          262     262
  Stmts        14792   14792
  Branches      1613    1613
  Methods          0       0
======================================
  Hit          10452   10452
  Partial        400     400
  Missed        3940    3940

Review entire Coverage Diff as of 6f52383

Uncovered Suggestions

+0.09% via ...oredConsoleTarget.cs#232...244
+0.09% via ...c/NLog/LogFactory.cs#180...191
+0.08% via ...anceCounterTarget.cs#308...318
See 7 more...

Powered by Codecov. Updated on successful CI builds.

Great! One small thing, see code comments.

I will change the documentation to XML docs myself :)


Swashbuckle Infers Bindings When Binding Inference Is Disabled

VERSION:

.Net Core 3.0 Web App (.Net Core SDK 3.1.100)
Swashbuckle 5.0.0-rc4

STEPS TO REPRODUCE:

Configure AspNetCore to disable binding inference:

            services.AddControllers()
                    .ConfigureApiBehaviorOptions(options =>
                    {
                        options.SuppressInferBindingSourcesForParameters = true;
                    })

Create an ApiController[Attribute] Controller. There, create an HttpGet[Attribute] Controller Action with a complex object with no bindings:

    [ApiController]
    [ApiVersion("1.0")]
    [Route("api/v{version:apiVersion}/currency")]
    public class CurrencyController : BaseController
    {
        public CurrencyController(IMediator mediator)
            : base(mediator)
        {
        }

        [HttpGet]
        [ProducesResponseType(StatusCodes.Status400BadRequest)]
        [ProducesResponseType(StatusCodes.Status500InternalServerError)]
        [ProducesResponseType(typeof(List<CurrencyDto>), StatusCodes.Status200OK)]
        public Task<IActionResult> GetCurrenciesAsync(GetCurrenciesRequest request, CancellationToken cancellationToken) => HandleRequestAsync(request, cancellationToken);
    }

    public class GetCurrenciesRequest : IRequest<List<CurrencyDto>>
    {
    }

EXPECTED RESULT:

Swagger UI with no route, query, or body parameters.
Swagger Doc with no route, query, or body parameters.

ACTUAL RESULT:

Swagger UI shows a query parameter that is an empty object ("{ }")
Swagger Gen shows a query parameter that is the "empty" GetCurrenciesRequest model.

{
  "openapi": "3.0.1",
  "info": {
    "title": "v1",
    "version": "v1"
  },
  "paths": {
    "/api/v1/currency": {
      "get": {
        "tags": [
          "Currency"
        ],
        "parameters": [
          {
            "name": "request",
            "in": "query",
            "schema": {
              "$ref": "#/components/schemas/GetCurrenciesRequest"
            }
          }
        ],
........
  "components": {
    "schemas": {
      "GetCurrenciesRequest": {
        "type": "object",
        "additionalProperties": false
      },
........
    }
........
}

ADDITIONAL DETAILS
It seems Swashbuckle defaults the model binding to Query when no binding attributes are found (correctly so, as AspNetCore does for ApiController attributed Controllers). But AspNetCore allows us to disable this behavior.
Having a complex object that models the entire request (where headers, route params, query params, body are bound to properties in the request model) plays very well when using a mediator for handling requests. Also- not every request has data/parameters to bind to (i.e. "Get All" endpoints for that have no optional filtering).
It would be nice if we can suppress this behavior like AspNetCore allows us to do, either by checking the framework setting "SuppressInferBindingSourcesForParameters " if possible or simply having its own setting. If all else, an adhoc solution (custom swashbuckle service) i can create/inject to suppress this behavior, would be great!
Great library.
Cheers,
-Chris

Any workaround for this?

+1

1


Added R linting

This adds linting for the R scripts (.R) and R markdown files (.Rmd)

@nathanballou and @ms4952 can you check that everything seems okay with your R examples? I made small changes to them so they would pass linting

LGTM


Roll Flutter Engine from c40b0b602822 to 621e68c2130f (2 revisions)

https://github.com/flutter/engine/compare/c40b0b602822...621e68c2130f
2024-10-31<EMAIL_ADDRESS>Skwasm single threaded (flutter/engine#56206)
2024-10-31<EMAIL_ADDRESS>[Impeller] expose reference to tessellator instead of shared_ptr. (flutter/engine#56244)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Simplify selecting elements that directly contains a node with the specified text

What is your Test Scenario?
DOM trees are hierarchical, and all parent nodes contain all texts of child nodes in the textContent property. It makes hard to address only the deepest node that contains some text, e.g.

        child text

 child-child-1 text

            child text

 child-child-2 text

What are you suggesting?
Add some new or modify an existing API method (withExactText) to easily select the deepest node that contains only the specified text and nothing more.
What alternatives have you considered?
Selector('*').find(node => [node.nodeValue, node.innerHTML].some(value => /^[^<>]*child text[^<>]*$/.test(value))

Additional context

here the another possible workaround without regexp (JFI)


##[error]ENOENT: no such file or directory, open './app.yaml'

##[error]ENOENT: no such file or directory, open './app.yaml'
but this file is in the root of the project

My Workflow
name: CI/CD

on:
  push:
    branches: [ master ]
    pull_request:
      branches: [ master ]

jobs:
  build:

    runs-on:

    steps:

      - name: Initialize Google Cloud SDK
        uses: zxyle/publish-gae-action@master
        with:
          service_account_email: ${{ secrets.GCP_SA_EMAIL }}
          service_account_key: ${{ secrets.GCP_SA_KEY }}
          project_id: ${{ secrets.PROJECT_ID }}
          gae_variables: ${{ secrets.GAE_VARIABLES }}

      - name: Install Dependecies
        run: |
          npm install

      - name: Build
        run: npm run build

      - name: Publish app to Google App Engine
        run: |
          gcloud auth activate-service-account ${{ secrets.GCP_SA_EMAIL }} --key-file=client-secret.json
          gcloud config set project ${{ secrets.PROJECT_ID }}
          gcloud -q app deploy app.yaml --promote

What am I doing wrong? My app.yaml is in the root of the repository

The problem has been solved.
Just add This to the first step.
 - name: Checkout the repository
        uses: actions/checkout@master


Fix(db): needs encryption migration function fixed EE-2414

Resolves EE-2414
The logic didn't take into account a new database and made a bad assumption
I've also added a go test for it.

nice - love the tests


⚠ Elibs has degraded performance

In 7fdfcf0, Elibs (https://elibs.unmer.ac.id) experienced degraded performance:

HTTP code: 200
Response time: 10193 ms

Resolved: Elibs performance has improved in a527e82.


insert_dp for adding additional pipes (similar to replace_dp and remove_dp)

🚀 The feature
Building on dataloader2.graph.replace_dp add a insert_dp possibly insert_dpg (insert a sub graph) functions to insert datapipes into an existing template.
Motivation, pitch
I want to be able to add a single or a graph of datapipes without replacing the existing datapipes.
My practical example is making a dqn multi-processing friendly async dqn
A default dqn agent has the following pipeline:
agent = AgentBase(model)
agent = StepFieldSelector(agent,field='state')
agent = SimpleModelRunner(agent,device=device)
agent = ArgMaxer(agent)
selector = EpsilonSelector(agent,min_epsilon=min_epsilon,max_epsilon=max_epsilon,max_steps=max_steps,device=device)
if logger_bases is not None: agent = EpsilonCollector(selector,logger_bases)
agent = ArgMaxer(agent,only_idx=True)
agent = NumpyConverter(agent)
agent = PyPrimativeConverter(agent)
agent = AgentHead(agent)

I want to make the tempalte / base dqn agent capable of syncing a model across spawn processes. So we insert a data pipe to sync the model.
agent = AgentBase(model)
agent = StepFieldSelector(agent,field='state')
#### agent = ModelSubscriber(agent,device=device) <- insert a pipe before the `SimpleModelRunner` pipe ####
agent = SimpleModelRunner(agent,device=device)
agent = ArgMaxer(agent)
selector = EpsilonSelector(agent,min_epsilon=min_epsilon,max_epsilon=max_epsilon,max_steps=max_steps,device=device)
if logger_bases is not None: agent = EpsilonCollector(selector,logger_bases)
agent = ArgMaxer(agent,only_idx=True)
agent = NumpyConverter(agent)
agent = PyPrimativeConverter(agent)
agent = AgentHead(agent)

Alternatives
Option 1
Add if statements / modify the template to contain most extensions, kind of like the EpsilonCollector I have above.
Option 2
Modify replace_db to support replacing a dp with a DataPipeGraph. So we would do something like:
agent_sub = ModelSubscriber(find_dps(agent,StepFieldSelector)[0],device=device)
agent_sub = SimpleModelRunner(agent_sub,device=device)

replace_db(agent,SimpleModelRunner,agent_sub)

Additional context
Not super tested, but the implementation below I think can allow for inserting a DataPipe or an entire isolated DataPipeGraph
# I have a PassThroughIterPipe that acts as a location that the insert code can definitively know that
# it can reassign
class PassThroughIterPipe(dp.iter.IterDataPipe):
    def __init__(self,source_datapipe): self.source_datapipe = source_datapipe
    def __iter__(self): return (o for o in self.source_datapipe)

def find_dp(graph: DataPipeGraph, dp_type: Type[DataPipe]) -> DataPipe:
    pipes = find_dps(graph,dp_type)
    if len(pipes)==1: return pipes[0]
    elif len(pipes)>1:
        found_ids = set([id(pipe) for pipe in pipes])
        if len(found_ids)>1:
            warn(f"""There are {len(pipes)} pipes of type {dp_type}. If this is intended,
                     please use `find_dps` directly. Returning first instance.""")
        return pipes[0]
    else:
        raise LookupError(f'Unable to find {dp_type} starting at {graph}')

find_dp.__doc__ = "Returns a single `DataPipe` as opposed to `find_dps`.\n"+find_dps.__doc__

def _insert_dp(recv_dp, send_graph: DataPipeGraph, old_dp: DataPipe, new_dp: DataPipe) -> None:
    old_dp_id = id(old_dp)
    for send_id in send_graph:
        if send_id == old_dp_id:
            # We do the same as replace_dp here by switching recv_dp to new_dp
            _assign_attr(recv_dp, old_dp, new_dp, inner_dp=True)

            # Replace the last datapipe in new_dp with the old_dp
            final_datapipe = find_dp(traverse(new_dp),PassThroughIterPipe)
            # But now we switch new_dp from the place holder pipe PassThroughIterPipe, to old_dp thus
            # not breaking the chain. Havent tested if this works for whole graphs as new_dp
            _assign_attr(new_dp, final_datapipe, old_dp, inner_dp=True)
            # new_dp.source_datapipe
        else:
            send_dp, sub_send_graph = send_graph[send_id]
            _insert_dp(send_dp, sub_send_graph, old_dp, new_dp)

def insert_dp(graph: DataPipeGraph, on_datapipe: DataPipe, insert_datapipe: DataPipe) -> DataPipeGraph:
    r"""
    Given the graph of DataPipe generated by ``traverse`` function and the ``on_datapipe`` DataPipe to be reconnected and
    the new ``insert_datapipe`` DataPipe to be inserted after ``on_datapipe``,
    return the new graph of DataPipe.
    """
    assert len(graph) == 1

    # Check if `on_datapipe` is that the head of the graph
    # If so, we `insert_datapipe`
    if id(on_datapipe) in graph:
        graph = traverse(insert_datapipe, only_datapipe=True)

    final_datapipe = list(graph.values())[0][0]

    for recv_dp, send_graph in graph.values():
        _insert_dp(recv_dp, send_graph, on_datapipe, insert_datapipe)

    return traverse(final_datapipe, only_datapipe=True)

With the test being:
it_pipe = dp.iter.IterableWrapper([1,2,3,4,5,6])
pipe = it_pipe.cycle(count=2)
pipe = pipe.batch(batch_size=2)

new_dp = insert_dp(
    traverse(pipe,only_datapipe=True),
    find_dp(traverse(pipe,only_datapipe=True),dp.iter.Cycler),
    dp.iter.Header(PassThroughIterPipe([]),limit=4)
)

IIUC, you want to insert a DataPipe between two DataPipes. Let's say you want to insert DataPipe C between A and B.
Original Graph:
A -> B
Expected New Graph:
A -> C -> B
Does this DataPipe accept an argument of DataPipe? And, the PassThroughDataPipe is used as a placeholder to construct DataPipe C. I guess the intention is not to get DataPipe A. However, we need to find DataPipe A anyways for the insert_dp function, I don't see the benefit of having a PassThroughDataPipe. Please correct me if I am wrong.
Your proposed approach:

First, get instance of DataPipe A
Second, construct DataPipe C with PassThrough (graph: PassThrough -> C)
Third, insert C after A. (replace PassThrough by A and then replace A by C)

For the option 2:

First, get instance of DataPipe A
Second, construct DataPipe C with A (graph: A -> C)
Third, replace A by C in the original graph (A -> B  ===> A -> C -> B)

@ejguan I think understand what im trying to do.
I did go ahead and implemented a practical example that ill attach below.
Does this DataPipe accept an argument of DataPipe? And, the PassThroughDataPipe
is used as a placeholder to construct DataPipe C. I guess the intention is not to get
DataPipe A. However, we need to find DataPipe A anyways for the insert_dp function,
I don't see the benefit of having a PassThroughDataPipe. Please correct me if I am wrong.

I'm realizing that I can get the same behavior using pure replace_dp:
pipe = A(range(10))
pipe = B(pipe)

test_eq(list(pipe),range(10))
traverse(pipe)

new_dp = replace_dp(
    traverse(pipe,only_datapipe=True),
    find_dp(traverse(pipe,only_datapipe=True),A),
    C(find_dp(traverse(pipe,only_datapipe=True),A))
)
new_dp

pipe = A(range(10))
pipe = B(pipe)

test_eq(list(pipe),range(10))
traverse(pipe)

def sub_graph(pipe):
    pipe = C(pipe)
    pipe = D(pipe)
    pipe = E(pipe)
    return pipe

new_dp = replace_dp(
    traverse(pipe,only_datapipe=True),
    find_dp(traverse(pipe,only_datapipe=True),A),
    sub_graph(find_dp(traverse(pipe,only_datapipe=True),A)) # I can even insert sections of pipes
)

new_dp

So maybe instead of a function in torchdata, this would instead of a documentation thing. I think a bunch of users will be interested in "insert" behaviors.

So maybe instead of a function in torchdata, this would instead of a documentation thing. I think a bunch of users will be interested in "insert" behaviors.

Sounds like a reasonable request. Do you want to open a PR to append it to the in-line doc here?
I will open another issue regarding our online doc.

@ejguan I'm happy to! I'll try to get a pr made later this week hopefully


[tf.learn] Fix logistic_regression() summary name conflict.

If you call logistic_regression() more than once in the same model, you get this error.

Duplicate tag logistic_regression.X found in summary inputs

Fixed by using the variable scope in the summary name.

Can one of the admins verify this patch?

@tensorflow-jenkins test this please.


HttpClient's application name configurable

The name of the application, which provides a consumed service, shall be configurable.
The information structure has been changed by moving the application-name from Capability to Configuration.
The following changes might be required:

OAS: References in the descriptions of the attributes at services
OAS: /v1/list-ltps-and-fcs core-model-1-4:control-construct::logical-termination-point::layer-protocol oneOf HttpClient
OAS: control-construct, if individual to the application
CONFIGfile: all instances of HttpClients

Has been forgotten to be changed:

[ ] OAS: References in the descriptions of the attributes at services


Issues in deleting Advanced throttling policies attached to a resource/API.

Description:

When following the Steps to reproduce erroneous behavior is observed.

Steps to reproduce:

Create 2 admin users - user1 and user2.
Create a custom advanced throttling policy testPolicy with the user1.
Create an API (eg:testAPI) with user1.
Attach the testPolicy to testAPI at API/operational level.
Delete the testPolicy with user2.

Observations:

testPolicy is getting successfully deleted even though it is attached to an existing API.
testPolicy  is not get deleted when trying to delete using user1

Affected Product Version:

APIM 3.2.0+1623485461485

This has been fixed in the latest WUM

This issue is not reproducing in the latest version (APIM 4.4.0)


Resolution events not suppressed.

I've applied the following type of configuration within every check in my environment.
          "annotations": {
            "fatigue_check/occurrences": "3",
            "fatigue_check/interval": "900",
            "fatigue_check/allow_resolution": "false"
          }

Agents have their two fatigue_check options set.
    "annotations": {
      "fatigue_check/keepalive_occurrences": "1",
      "fatigue_check/keepalive_interval": "0",
    }

Occurrence configuration is functioning as expected; checks that have issues or alert for fewer than their configured occurrences do not generate warning or critical notifications.
However, resolution messages are still passing through the pipeline by the hundreds each second.
Description
NTP OK: Offset 0.001697361469 secs|offset=0.001697s;30.000000;60.000000;
Status
Resolved
Entity
host.place-hold-domain.com

Are you sure it's resolution events being passed?  Or simply just passing events?

I believe it's resolution events that are being passed, as the result of the Slack webhook is an event notification with "Resolved" as the status.
The only filters applied to the handler being used is "not_silenced" and "fatigue_check." I re-ordered them in case that was having any effect.

The slack handler sets "Resolved" on any event with status == 0 (reference this function in the handler) Handlers, unlike, filters don't have access to the internal state is_resolution which is when an event shifts from non-zero to zero.
If you are not using the is_incident filter on the handler the fatigue filter will still pass events based on the occurrence and interval.  It is not doing any other state checking.  I recommend you add the is_incident filter to your slack handler.

Thank you for pointing out this oversight. I will make the changes and not the results.

This is absolutely a required filter, thank you kindly for setting my configuration straight. The documentation on this built-in filter can be found in the event reference. https://docs.sensu.io/sensu-go/latest/observability-pipeline/observe-filter/filters/


Typing targets with TypeScript and babel 7 with class properties proposal

Setup:

using Stimulus with TypeScript and babel 7
TypeScript is providing type checking and compiling to esnext-level JS
Resulting JS is then transpired by babel down to targets based on @babel/preset-env
Babel configured to use @babel/plugin-proposal-class-properties

There is a conflict in how TypeScript expects class properties to be typed, and how babel treats class properties, which is resulting in an error in Stimulus.
Consider the example from the handbook implemented with TypeScript:
<div data-controller="hello">
  <input data-target="hello.name" type="text">
  <button data-action="click->hello#greet">Greet</button>
</div>

import { Controller } from "stimulus"

export default class extends Controller {
  static targets = [ "name" ]
  readonly nameTarget!: Element

  greet() {
    const element = this.nameTarget
    const name = element.value
    console.log(`Hello, ${name}!`)
  }
}

When using TypeScript with babel 7 and the @babel/plugin-proposal-class-properties plugin, the resulting JavaScript ends up with the class property nameTarget being initialised with void 0, as per the spec. This results in the following error from Stimulus:
Cannot set property nameTarget of #<Controller> which has only a getter

This is perfectly reasonable behaviour from Stimulus: you wouldn't want the nameTarget being overwritten by calling code, since it is managed by Stimulus.
Digging deeper into the issue, it appears that Stimulus defines the *Target properties when the controller is first loaded into the application, based on the static targets property. Babel's assignment of this.nameTarget = void 0 occurs when the controller instance is created - by this time, the *Target properties have already been defined (without setters) and so the error is seen when the controller is instantiated.
Unfortunately I can't see any way around this, other than
a) not typing the *Target properties, and ignoring/suppressing the TypeScript errors
b) reverting back to using regular JavaScript
I'd really like to use TypeScript, especially for targets as the autocompletion tools for HTMLElements are such a timesaver. Can there be any way to solve this issue?

Closing this because it doesn’t seem to be an issue with Stimulus, but please feel free to continue discussing TypeScript and Babel compatibility over on the community forum.

Hi ! Just to let you know that I'm having the same issue after upgrading webpacker to 5.1 which stops using ts-loader and uses @babel/preset-typescript instead.
@fiznool did you find another workaround since then ? Thanks !

@Intrepidd I did find a workaround - you can use the declare keyword to define the class property. On seeing a declared property, Babel will strip this from the generated code, as it considers declare as type information only.
So the original example can be rewritten as follows:
import { Controller } from "stimulus"

export default class extends Controller {
  static targets = [ "name" ]
  declare readonly nameTarget: Element

  greet() {
    const element = this.nameTarget
    const name = element.value
    console.log(`Hello, ${name}!`)
  }
}

Note that you'll need to opt-in to this behaviour with Babel 7 via the allowDeclareFields option to @babel/plugin-transform-typescript. I had to use the transform directly as the option didn't seem to work using the preset. Babel 8 will make this the default behaviour.

Thanks a lot ! On my end I discovered that entirely removing the line readonly nameTarget: Element works for me now, when it didn't when using ts-loader

Yes, that will work now as when using with Babel, TypeScript is relegated to type checking only, meaning that type errors will not prevent compilation (since Babel is in charge of compiling). You’ll lose type safety by not declaring the class property, however - when calling this.nameTarget from a method, TS can’t provide any additional information for autocomplete purposes, etc.

Makes a lot of sense! I'll go with your workaround then, thanks!


How to use a mask as a prompt to replace points in VOS？

How to use a mask as a prompt to replace points in VOS？

Hi, you can refer to the example in tools/vos_inference.py in https://github.com/facebookresearch/sam2/tree/main/tools as an example of using mask prompts (instead of points or boxes) for VOS


Update deploy/delete/dependencies

Updates to:
taskcat deploy - separated command into run/list
taskcat delete - now does multithreading
mock dependency - updated to unittest.mock
docker integration tests

@dsensibaugh I'm finding that taskcat list doesn't behave the same way as taskcat deploy list. Is this intentional?

If it's an easy lift, I think it'd be great to solve for taskcat list too.

While we’re at it, should we just go ahead and rename ‘package’? Something like ‘project’, ‘production’, or similar?

@dsensibaugh When y'all are at a good spot, please rebase from main as I've fixed the recent linting issues. I'd like to get passing travis tests before I run end to end.

Merged in now, let me check our additions  to see how well they work with the new changes to main

/do-e2e-tests


IBC Clients Search

tracking: #10, #6
Summary
Add support for searching IBC Clients running on Penumbra to cuiloa's search functionality.
Description
Should return both the client page itself as well as list of recent transactions relevant to that client.
Search results page should show:

[x] What type of search it is (IBC Client, in this case)
[x] What kind of result was returned (IBC Client ID, linking to the page)
[x] Content showing how the query relates to it. for IBC Clients, this will be recent transactions and should include:

[x] Transaction Hash (and appropriately linked)
[x] Why (client_update, etc)

Closed out with #67


LSP completions violate spec

What happened, and what did you expect to happen?
LSP completions include this, which violates the spec because kind should be either "plaintext" or "markdown".
      "documentation": {
        "kind": "",
        "value": ""
      },

documentation is an optional markupContent
go-lsp package defines it as
	// A human-readable string that represents a doc-comment.
	Documentation MarkupContent `json:"documentation,omitempty"`

omitempty is useless. To fix this, we could change it to Documentation *MarkupContent.
Opening this issue here because it seems like https://github.com/nimblebun/go-lsp is not active.
Maybe we should switch to a different library?
Output of "elvish -version"
0.21.0
Code of Conduct

[X] I agree to follow Elvish's Code of Conduct.

That's right, we should switch to a more actively maintained LSP type package. Any suggestions?

I'm not super well informed but I'd probably start with autogenerated message buffers like what gopls uses.
Regarding the issue at hand, they define it as pointer, so the zero value will be serialized correctly
{
    Documentation *Or_CompletionItem_documentation `json:"documentation,omitempty"`
}


Missing SQL Database options in dacpac for Microsoft Azure SQL Database target option in VS2022 17.5.5

We have a Visual Studio database project for which we also supply Query Store settings and MaxDop settings in the database settings Operational tab. The target platform we use in the project is “Microsoft Azure SQL Database”.
When we build the project with Visual Studio 17.4.4 the model.xml in the dacpac contains the supplied query store and max dop settings:

However when we build the project with Visual Studio 17.5.5 those settings are missing from the model.xml:

When we deploy the dacpac to our Azure Database it is reverting those settings to the default settings (MaxDop 8, QUeryStore Size 100 instead of the 512 we need).
As a temporary workaround we changed the targetplatform to “SQL Server 2022 or Azure SQL Database Managed Instance” since this does include those settings again.

Resolved.

This was shipped with DacFx 162.0.52 in May and is included in the Visual Studio 17.6 GA release.


[Forwardport 2.7] kubernetes 1.22 conflicts with system-library-rancher-monitoring, cluster is in error state

Forwardport https://github.com/rancher/rancher/issues/37039

2.7 commit id da810a7 - all prometheus targets show healthy; all workloads active/healthy;


Iframe components

Code-review checklist

Documentation

[ ] Interfaces describe how other programmers would use them.
[ ] Code that is not obvious has documentation describing why
that code is the way it is.

Extracts the text area to display iframe embed code into its own component

Extracts the iframe preview into its own component

Adds iframeUrl function to generate the url in one place that can be shared

Looks great.


Inference on CPU very slow

Hi,
While trying make inference on the elephant.jpg image in the starter example, using a CPU took me almost 22 minutes. (Pretty much powerful CPU). Is it expected ? or is there is something I am missing out?

I have the same problem. Do you have fix it yet?

Nope, I couldn't fix it yet.

I don't have a ton of experience with running Torch on CPU, but sometimes I've seen that Torch does not properly utilize multiple threads in BLAS calls; this would cause slowness on CPU.
There are some details here about configuring BLAS with Torch:
https://github.com/torch/dok/blob/master/docinstall/blas.md
However it was last updated in February 2014 so it may be outdated.

I have big problem when I run model densecap on GPU
THCudaCheck FAIL file=/tmp/luarocks_cutorch-scm-1-768/cutorch/init.c line=261 error=46 : all CUDA-capable devices are busy or unavailable
/home/mmlabgpu3/torch/install/bin/luajit: /home/mmlabgpu3/torch/install/share/lua/5.1/trepl/init.lua:389: /home/mmlabgpu3/torch/install/share/lua/5.1/trepl/init.lua:389: /home/mmlabgpu3/torch/install/share/lua/5.1/cudnn/find.lua:165: cuda runtime error (46) : all CUDA-capable devices are busy or unavailable at /tmp/luarocks_cutorch-scm-1-768/cutorch/init.c:261
stack traceback:
[C]: in function 'error'
/home/mmlabgpu3/torch/install/share/lua/5.1/trepl/init.lua:389: in function 'require'
./densecap/utils.lua:31: in function 'setup_gpus'
run_model.lua:149: in main chunk
[C]: in function 'dofile'
...gpu3/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
[C]: at 0x004065d0
You can tell me why occur that error?

@eitguide Does your computer have an NVIDIA GPU?

Yes, it turns out to be that torch is not able to use all the available threads on the CPU, while running on a Intel KNL node (that has 64 cores). However, I see that inference of the same image is taking around 23 seconds on MacBook Pro.


omegaconf.errors.ConfigAttributeError: Missing key log_images_to full_key: logging.log_images_to

The bug "omegaconf.errors.ConfigAttributeError: Missing key log_images_to full_key: logging.log_images_to" appears when I run the train.py file, also encountered this issue when I run the Colab Notebook that was provided in the Getting Started section. All the files are freshly downloaded without being modified.
Exact procedures to reach here:

setup Anaconda environment on Windows 10
pip install anomalib
pip install -r requirements\base.txt
pip install -r requirements\dev.txt
python tools\train.py --config C:\Users\Billy\Downloads\anomalib-development\anomalib\models\padim\config.yaml
(running python tools\train.py yields the same result)

(For the Google Colab example, I just follow the steps in the notebook exactly, but the same error appeared.)
Error Code:
(anomalib) C:\Users\Billy\Downloads\anomalib-development>python tools\train.py --config C:\Users\Billy\Downloads\anomalib-development\anomalib\models\padim\config.yaml
2022-07-05 09:22:19,934 - pytorch_lightning.utilities.seed - INFO - Global seed set to 42
C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\torchmetrics\utilities\prints.py:36: UserWarning: Torchmetrics v0.9 introduced a new argument class property called full_state_update that has
not been set for this class (AdaptiveThreshold). The property determines if update by
default needs access to the full metric state. If this is not the case, significant speedups can be
achieved and we recommend setting this to False.
We provide an checking function
from torchmetrics.utilities import check_forward_no_full_state
that can be used to check if the full_state_update=True (old and potential slower behaviour,
default for now) or if full_state_update=False can be used safely.
warnings.warn(*args, **kwargs)
C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\torchmetrics\utilities\prints.py:36: UserWarning: Metric PrecisionRecallCurve will save all targets and predictions in buffer. For large datasets this may lead to large memory footprint.
warnings.warn(*args, **kwargs)
C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\torchmetrics\utilities\prints.py:36: UserWarning: Torchmetrics v0.9 introduced a new argument class property called full_state_update that has
not been set for this class (AnomalyScoreDistribution). The property determines if update by
default needs access to the full metric state. If this is not the case, significant speedups can be
achieved and we recommend setting this to False.
We provide an checking function
from torchmetrics.utilities import check_forward_no_full_state
that can be used to check if the full_state_update=True (old and potential slower behaviour,
default for now) or if full_state_update=False can be used safely.
warnings.warn(*args, **kwargs)
C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\torchmetrics\utilities\prints.py:36: UserWarning: Torchmetrics v0.9 introduced a new argument class property called full_state_update that has
not been set for this class (MinMax). The property determines if update by
default needs access to the full metric state. If this is not the case, significant speedups can be
achieved and we recommend setting this to False.
We provide an checking function
from torchmetrics.utilities import check_forward_no_full_state
that can be used to check if the full_state_update=True (old and potential slower behaviour,
default for now) or if full_state_update=False can be used safely.
warnings.warn(*args, **kwargs)
2022-07-05 09:22:20,941 - anomalib.models.padim.lightning_model - INFO - Initializing Padim Lightning model.
Downloading: "https://download.pytorch.org/models/resnet18-f37072fd.pth" to C:\Users\Billy/.cache\torch\hub\checkpoints\resnet18-f37072fd.pth
100%|█████████████████████████████████████████████████████████████████████████████| 44.7M/44.7M [00:04<00:00, 11.0MB/s]
Traceback (most recent call last):
File "tools\train.py", line 82, in
train()
File "tools\train.py", line 67, in train
callbacks = get_callbacks(config)
File "C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\anomalib\utils\callbacks_init_.py", line 112, in get_callbacks
if not config.logging.log_images_to == []:
File "C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\omegaconf\dictconfig.py", line 357, in getattr
self._format_and_raise(
File "C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\omegaconf\base.py", line 231, in _format_and_raise
format_and_raise(
File "C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\omegaconf_utils.py", line 873, in format_and_raise
_raise(ex, cause)
File "C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\omegaconf_utils.py", line 771, in _raise
raise ex.with_traceback(sys.exc_info()[2])  # set env var OC_CAUSE=1 for full trace
File "C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\omegaconf\dictconfig.py", line 353, in getattr
return self._get_impl(
File "C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\omegaconf\dictconfig.py", line 444, in _get_impl
node = self._get_child(
File "C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\omegaconf\basecontainer.py", line 73, in _get_child
child = self._get_node(
File "C:\Users\Billy\anaconda3\envs\anomalib\lib\site-packages\omegaconf\dictconfig.py", line 482, in _get_node
raise ConfigKeyError(f"Missing key {key!s}")
omegaconf.errors.ConfigAttributeError: Missing key log_images_to
full_key: logging.log_images_to
object_type=dict

Hardware and Software Configuration:

OS: Windows 10
NVIDIA Driver Version [516.59]
CUDA Version [11.2]
CUDNN Version [8.1]

Hi @billyc97, this is a known issue for the pypi version.  To avoid it you could temporarily use the local installation instead.
git clone https://github.com/openvinotoolkit/anomalib.git
cd anomalib
pip install -e .

We'll fix the PyPI version today so you could try pip install anomalib later

@billyc97 can you try installing the latest anomalib pip install anomalib==0.3.3?

@ashwinvaidya17 It seems that this issue is resolved, thanks!

@billyc97, great! I'm closing the issue then


feat: find wasm files built by cargo or asb

When deploying and "./out/main.wasm" option is used but the file is not present, this looks for **/{target}/*.wasm since both Rust and AssemblyScript projects produce binaries with that pattern.
dev-deploy looks for the debug target and deploy looks for release.

Somewhat related question: how easy it is to add detection whether project is using cargo or asb? For analytics purposes: that's gonna be very useful to determine success rate based on language.

@willemneal hey, so we are back to this PR :) Do you think you can solve the conflicts and prepare it for the merge? Because changes look cool.


Having multiple files selected in Explorer and hitting enter only opens first selected file

Selecting multiple files in VS Code Explorer panel, having setting "workbench.list.openMode" set to "doubleClick" only opens the first of the selected files when hitting the ENTER key.

However, all selected files are supposed to open in the current editor group.

VSCode/OS Version:

Version: 1.37.1 (user setup)
Commit: f06011ac164ae4dc8e753a3fe7f9549844d15e35
Datum: 2019-08-15T16:17:55.855Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
Betriebssystem: Windows_NT x64 10.0.14393

Dup of https://github.com/microsoft/vscode/issues/42573


:accept: Use consistent naming for tracking env vars

:rocket: deployment of connecting-to-services succeeded (http://connecting-to-services-pr-300.dev.beta.nhschoices.net)


L.GridLayer does not honor opacity setting when set using options.

This is similar to #4096, but I am not using IE.
When I try to set the opacity of a tile/grid layer using the options.opacity, it is ignored.
I traced it to _initTile : function(tile), It looks like options.opacity is only used if the browser is "ielt9".
	// update opacity on tiles in IE7-8 because of filter inheritance problems
		if (L.Browser.ielt9 && this.options.opacity < 1) {
			L.DomUtil.setOpacity(tile, this.options.opacity);
		}

I modified my version of the _initTile function  and added the following lines so that the opacity options are used if set.
	if(this.options.opacity){
			tile.style.opacity = this.options.opacity;
		}

If there is a better/preferred way to handle this, please let me know.
Thanks
Rick

Works for me in chrome
http://playground-leaflet.rhcloud.com/pex/edit?html,output
leaflet sets the opacity of the container here:
https://github.com/Leaflet/Leaflet/blob/master/src/layer/tile/GridLayer.js#L313-L315

I found I was using an older version of the leaflet src, I updated to the current version in git-hub and It is working as danzel pointed out.
Sorry for premature posting.
Rick


[v1.5][Tasks] Task completeness

Implemented new commands SetTaskComplete and SetTaskIncomplete, along with some minor UI changes.

Coverage decreased (-0.004%) to 80.848% when pulling 6bebd7853f55abc5d6d2af5df845b4a7fd9694a3 on Esilocke:taskComplete into 8d41f24f8301b762b3f75d73aaf6d0af4467b1fe on CS2103AUG2017-W09-B2:master.

Coverage decreased (-1.4%) to 79.496% when pulling ec74fb3c3d72df6098f7f5076c74a8431c77cec3 on Esilocke:taskComplete into 8d41f24f8301b762b3f75d73aaf6d0af4467b1fe on CS2103AUG2017-W09-B2:master.

Coverage decreased (-0.2%) to 80.659% when pulling c93a9679dab3ef3ccbca8d0d7a6d520a4ec06687 on Esilocke:taskComplete into 8d41f24f8301b762b3f75d73aaf6d0af4467b1fe on CS2103AUG2017-W09-B2:master.

Coverage increased (+2.4%) to 83.263% when pulling 13762e5ed965557cd8bd90ad789ba280d095a91e on Esilocke:taskComplete into 8d41f24f8301b762b3f75d73aaf6d0af4467b1fe on CS2103AUG2017-W09-B2:master.

Coverage increased (+2.4%) to 83.263% when pulling b40ea9d841e9b95a22ed755bfbd067fa1d34d59f on Esilocke:taskComplete into 8d41f24f8301b762b3f75d73aaf6d0af4467b1fe on CS2103AUG2017-W09-B2:master.


consider the windows JAVA_HOME variable

with this change the windows executable could also be started even if java isn't installed the standard way but the JAVA_HOME system variable is set.


Break out modName from paths in ActonCompiler

It stems from the old days when we only compiled a single file at a time. After doing project builds, it's irrelevant and only distracting. I think it should be removed!

Correction, we can't just remove it, but we should probably refactor things a bit so that it's not part of paths everywhere since it's really... well, not part of paths.

Hmm, so we do use modName and I think our use would have decreased more than it has, but like, compiling individual files will be useful going forward. The motivation to separate it from "paths" is really just because it doesn't fit with the rest of the stuff in there, which really are paths. However, it would only lead to us passing more arguments throughout the compiler and that is hardly an improvement... so if anything, maybe paths should be renamed to something else, like build_info.
I'm going to close this because I no longer think we should remove it and I don't have a concrete proposal of rename that feels important enough to take action on right now, so closing.


Are we losing darks?

Where does Petr stash darks?

There was a problem in CTIME fits header. Darks keep overwriting a single file. Fixed, darks will appear in the trash directory. I will work on hopefully trivial fix to put them into dark/bias directories.


add replyto support and configuration option

I Added support for Reply-To: mail header field.

Thanks a lot for the changes!


Add relation tree component

We need to have more intuitive way to show users when they are creating tree relationship problem

Add <array ui="tree"> in https://github.com/Canner/canner/commit/30e9235a465d29e836d7c1b140df3a2a748bdc4b


Jitclass decorator removes the method signatures of the wrapped instances

I've noticed that the Jitclass decorator replaces the method signatures of the wrapped instances with a generic func_name(*args, **kwargs) signature. See the example below:
In [1]: from numba.experimental import jitclass

In [2]: from numba import float64

In [3]: specs = [("alpha", float64), ("gamma", float64)]

In [4]: @jitclass(specs)
   ...: class Foo:
   ...:    def __init__(self, alpha, gamma):
   ...:        self.alpha = alpha
   ...:        self.gamma = gamma
   ...:

In [5]: from inspect import signature

In [6]: foo = Foo()

In [7]: foo = Foo(3., 2.)

In [8]: signature(foo.__init__)
Out[8]: <Signature (*args, **kwargs)>

I can access the signature of the class, but not the instance:
In [9]: signature(Foo.__init__)
Out[9]: <Signature (self, alpha, gamma)>

I tried circumventing this issue using the __class__ attribute, but:
In [10]: signature(foo.__class__.__init__)
Out[10]: <Signature (self, /, *args, **kwargs)>

It'd be a valuable addition to keep the method signatures of the jitted instances.

I can reproduce this. Copy/pastable reproducer:
from numba.experimental import jitclass
from numba import float64
from inspect import signature

specs = [("alpha", float64), ("gamma", float64)]

@jitclass(specs)
class Foo:
    def __init__(self, alpha, gamma):
        self.alpha = alpha
        self.gamma = gamma

foo = Foo(3., 2.)

print(signature(foo.__init__))
print(signature(Foo.__init__))

which gives:
$ python repro.py
(*args, **kwargs)
(self, alpha, gamma)


chore(deps): update dependency autoprefixer to v9.7.5

This PR contains the following updates:

Package
Type
Update
Change

autoprefixer
devDependencies
patch
9.7.4 -> 9.7.5

Release Notes

postcss/autoprefixer
v9.7.5
Compare Source

Fix -webkit-stretch support.

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 3.2.0 :tada:
The release is available on:

v3.2.0
GitHub release

Your semantic-release bot :package::rocket:


Follow PEP8 Style

[ ] My submission is formatted according to the guidelines in the contributing guide
[ ] My addition is ordered alphabetically
[ ] My submission has a useful description
[ ] The description does not have more than 100 characters
[ ] The description does not end with punctuation
[ ] Each table column is padded with one space on either side
[ ] I have searched the repository for any relevant issues or pull requests
[ ] Any category I am creating has the minimum requirement of 3 items
[ ] All changes have been squashed into a single commit

The above is irrelevant.

Hi @MrBrain295
Thanks for your contribution ;)
We have some problems with Public APIs, so we won't be able to review/add this API right now.
Read this issue for more information, please: https://github.com/public-apis/public-apis/issues/3104

@matheusfelipeog this doesn't add an API.

@matheusfelipeog this doesn't add an API.

Sorry 😅


Flutter Doctor should mention ANDROID_HOME when it can't find the android sdk as a possible reason why it can't find it

The current message says
[x] Android toolchain - develop for Android devices
    x Android Studio / Android SDK not found. Download from https://developer.android.com/sdk/
      (or visit https://flutter.io/setup/#android-setup for detailed instructions).

https://flutter.io/setup/#android-setup does mention ANDROID_HOME but not in a prominent way. We should surface it in the doctor message. Should also make sure setting up ANDROID_HOME is a prominent setup step on the website (it's very implicit when installing Android Studio on a mac for instance, the user might never notice).

Good call. Let's add to https://github.com/flutter/flutter/issues/7971

Note we do try to guess it by looking at
~/Android/Sdk
~/Library/Android/sdk
~/AppData/Local/Android/sdk
But if the user puts it anywhere else, we should message in doctor that we're looking for ANDROID_HOME

Further more in flutter doctor the message say "Android Studio / Android SDK not found". So, if you mention to specify the ANDROID_HOME, you can give a clue on where ANDROID_HOME should be targetted.
I have tried with

"ANDROID_HOME=~/softwares/android/sdk"  and it works.
"ANDROID_HOME=~/softwares/android"  and it works.
but "ANDROID_HOME=~/softwares/android-studio" not

On Windows ANDROID_SDK_ROOT nor ANDROID_HOME work!!
(I couldn't try system environment, only user environment)
Only "flutter config --android-sdk Path/to/sdk" did help!

Update, the current message does mention ANDROID_SDK_ROOT in the error message now in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/base/user_messages.dart#L77.
As pointed out above, it might want to mention setting flutter config --android-studio-dir or flutter config --android-sdk instead since it can cover more cases.

Can this be closed?  Did:  https://github.com/flutter/flutter/pull/65964  address the issue?  @apwilson  - since you initially filed this ~ 6 years ago :-)

Fixed in https://github.com/flutter/flutter/pull/65964


STM32: Add support for STM32H7 dual core

Enable support of Zephyr on STM32H747I-DISCO board.
This board is dual core and this work enable running zephyr in both cores.
For now, the minimum work is done to enable dual core operation by sharing the resources.
No communication is enabled between cores except use of hardware semaphore for synchronization
and critical resources access.
Depends on https://github.com/zephyrproject-rtos/hal_stm32/pull/15

@arnop2

stm32h747i_disco_m4, doesn't enable CONFIG_SERIAL.
How come samples/nfc/nfc_hello (filters on CONFIG_SERIAL) and samples/mpu/mpu_test (filters on CONFIG_SERIAL_SUPPORT_INTERRUPT) are compiled on that target ?

@ioannisg

I think it would be cleaner, if at the SOC level we have SOC options for the two cores, i.e. xxx_M4 and xxx_M7

As answered above, this would introduce an intermediate symbol with no added value.
And I don't see limitation or risk with the current method

we have two different BOARDs, anyways, because we need to build two different images.

I understand you propose to introduce 2 boards directories.
I don't think this is the good direction: even if we have 2 targets to build, they share a lot of common configuration: boot type, clocks settings, boards support package, pinmux ..
Having 2 targets in the same board directory allow to share some Kconfig file which force configuration coherency.
Also, even if we miss a good tool to handle peripheral assignment, having all information at one place eases manual check that resources are assigned to only one core at the same time.

@erwango, got me a bit wrong, here, we shoudln't have 2 BOARD directories, we should have two BOARD .defconfigs (we do actually), as we do for other dual-cores.
So, I am only worried about consistency here. Check the 2 dual-core NXP lpc platforms; they have two SOC symbols defined, for each core, and the two BOARD symbols depend on either SOC Kconfig. I think the ARM Musca_x does the same. We should have one way to do this for any multi-core platform....

@ioannisg

@erwango, got me a bit wrong, here, we shoudln't have 2 BOARD directories, we should have two BOARD .defconfigs (we do actually), as we do for other dual-cores.

Ok. And we have 2 _defconfig, but only one .defconfig. This is the same than lpx as I can check. So we're aligned here.

So, I am only worried about consistency here. Check the 2 dual-core NXP lpc platforms; they have two SOC symbols defined, for each core, and the two BOARD symbols depend on either SOC Kconfig. I think the ARM Musca_x does the same. We should have one way to do this for any multi-core platform.

From what I see, ARM musca defines 2 boards, so does cypress_062_wifi_bt dual core board, let put these aside.
I see your point about consistency. But then, looking at lpc5Xxxx implementations, I don't particularly agree on the way things are done (specially in soc files Kconfig.defconfig.lpcxxxx_mx some kind of peripheral assignment is done, which limits the flexibility at board level and performs driver deactivation at soc level which seems error prone for an end user).
Anyway, I'm keeping your suggestion in mind and I'll see if solves issues when we'll have to add mode resources or mode boards/soc derivates based on this porting.

From what I see, ARM musca defines 2 boards, so does cypress_062_wifi_bt dual core board, let put these aside.
I see your point about consistency. But then, looking at lpc5Xxxx implementations, I don't particularly agree on the way things are done (specially in soc files Kconfig.defconfig.lpcxxxx_mx some kind of peripheral assignment is done, which limits the flexibility at board level and performs driver deactivation at soc level which seems error prone for an end user).
Anyway, I'm keeping your suggestion in mind and I'll see if solves issues when we'll have to add mode resources or mode boards/soc derivates based on this porting.

Musca is 2 different actual boards.  The cypress_062_wifi_bt should be reworked but we've never gotten around to it.


Continued confusion about install

Meteor is getting easier to use.  The elimination of meteorite was a real blessing.  But this has left a lot of apps' docs in (even greater) shambles (than before), in particular with regard to the "installation instructions."
As they exist, the step-by-step instructions for the current version of turkserver-meteor do not work.  There are a few "help me" threads that contain fixes, but those all continue to refer to mrt.  This framework is clearly going to be invaluable to our work, but only once we actually get it to run.
Could you glance at those instructions, looking for the one or two tiny details that have been omitted, and point us in the right direction?
Thanks for (what looks to be) amazing work on this.
Garrison

Sorry for the delayed response as I was on vacation.
I will try to update the documentation for this once I start my new position next week. Also, I would love to have a call on Skype or something just to chat about the grander scheme of doing online experiments, and understand how I can help with what you guys are trying to do.

Hey @LeMasters, what error are you getting when you try to add the package to a Meteor app?
Also, I'm actively updating documentation at http://turkserver.meteor.com/. When that is close to done, I'll publish the package so that it can be installed directly by Meteor.

Hi @LeMasters, I'm not sure what trouble you are having installing turkserver in your Meteor app but they appear to work fine. Also, the documentation at http://turkserver.meteor.com/ is growing by the week.
Cheers,
Andrew

Please see http://ldworkin.github.io/turkserver-tutorial/ for a much more definitive guide on how to use TurkServer.


How should I set the learning rate on 8*v100 32g gpus？

This is the parameters I deployed
AZFUSE_USE_FUSE=0 QD_USE_LINEIDX_8B=0 NCCL_ASYNC_ERROR_HANDLING=0 mpirun -np 8 --allow-run-as-root python finetune_sdm_yaml.py --cf config/ref_attn_clip_combine_controlnet_attr_pretraining/coco_S256_xformers_tsv_strongrand.py --do_train --root_dir /data/DisCo --local_train_batch_size 64 --local_eval_batch_size 64 --log_dir exp/tiktok_pretrain --epochs 40 --deepspeed --eval_step 2000 --save_step 2000 --gradient_accumulate_steps 1 --learning_rate 1e-3 --fix_dist_seed --loss_target "noise" --train_yaml ./TSV_dataset/Human_Attribute_Pretrain/composite/train_TiktokDance-coco-single_person-Lindsey_0411_youtube-SHHQ-1.0-deepfashion2-laion_human-masks-single_cap.yaml --val_yaml ./TSV_dataset/Human_Attribute_Pretrain/composite/val_TiktokDance-coco-single_person-SHHQ-1.0-masks-single_cap.yaml --unet_unfreeze_type "transblocks" --refer_sdvae --ref_null_caption False --combine_clip_local --combine_use_mask --conds "masks" --max_eval_samples 2000 --strong_aug_stage1 --node_split_sampler 0
and the loss I got after Human attribute pretraining.
Metering:{'loss_total': '0.0667'}: 100%|██████████| 55280/55280 [81:48:04<00:00,  5.33s/it]

I noticed that on your article, you mentioned All pre-training experiments are conducted on 4x8 NVIDIA V100 GPUs for 25K steps with image size 256×256 and learning rate 1e−3.
Because I only got one-fourth of the number of gpus you have，should I reduce the learning rate to one-fourth of 1e-3？
what is your loss after training on this stage？Thank you！

Hi, I have tried to multiple the learning rate by the rate that the batch size increase, but I am not sure if it is the best lr under that situation. For loss, different setting causes different loss values, I recommend you to check the final eval FID after training.

Ultimately,the indicators I got are much worse than yours
{'L1': 0.00039951090145022176, 'SSIM': 0.657848540669247, 'LPIPS': 0.2970971225998282, 'PSNR': 28.89969279008445, 'clean-fid': 32.09775464320444}
FID:  31.576945674116274

Hi, I have tried to multiple the learning rate by the rate that the batch size increase, but I am not sure if it is the best lr under that situation. For loss, different setting causes different loss values, I recommend you to check the final eval FID after training.

This is my experience for the 2nd stage (fine-tuning). For pre-training, we do not try to use only 1x8 V100 ever. Maybe you should try different lr, but I recommend you not to re-train from scratch but use our checkpoint as the starting point. The FID of 31 is a little bit high. At least it should under 25.


The database tracker can create jawn commits

You will know this is done when
the database tracker is able to create a commits in jawn
Related: #43

Replaced by #43


Cache::many with MemcachedStore throws exception because of array_combine

Laravel Version: 8.15.0
PHP Version: 7.4.11

Description:
When invoking Cache::many() with an array of keys where only a subset of the keys are hits, an exception is occurring because of an element count mismatch using array_combine.
ErrorException: array_combine(): Both parameters should have an equal number of elements
#75 /vendor/laravel/framework/src/Illuminate/Cache/MemcachedStore.php(92): Illuminate\Foundation\Bootstrap\HandleExceptions::handleError
#74 internal: array_combine
#73 /vendor/laravel/framework/src/Illuminate/Cache/MemcachedStore.php(92): Illuminate\Cache\MemcachedStore::many
#72 /vendor/laravel/framework/src/Illuminate/Cache/Repository.php(125): Illuminate\Cache\Repository::many
#71 /vendor/laravel/framework/src/Illuminate/Cache/CacheManager.php(396): Illuminate\Cache\CacheManager::__call
#70 /vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php(261): Illuminate\Support\Facades\Facade::__callStatic
Steps To Reproduce:
Use the Memcached store and invoke Cache::many with a set of keys where some are in the cache and some are not.

Unable to recreate this:

I'll dig into it and try to get a better example, since it must be more specific than I thought. It's a real-world exception that I'm hitting though so I know it's there. 👍


Class 'TimestampValidator' not found

Affected Symphony version(s) : 2.7.7
PHP version(s) : 5.5, 5.6, 7.1
OS(es) : Windows
Hi.
After updating Symphony to 2.7.7 (from 2.6.3) I get an error every time I'm trying to edit and save an existing entry. Everything works fine when creating a new one.
Symphony Fatal Error: Class 'TimestampValidator' not found
An error occurred in C:\xampp\htdocs\ma.wroc.pl\symphony\content\content.publish.php around line 1954
Can you please help me with this issue?
Thank you very much
Shin

Thank you.
S.


Example of building a TopoJSON object and writing it to a string

@patricoferris please the Object okay? Should I proceed with writing it to a string?

@patricoferris please the Object okay? Should I proceed with writing it to a string?

@patricoferris please check again. How do I proceed from here?

Awesome! Great work, to help get this over the line, I hopefully got it to a working state in this commit https://github.com/geocaml/ocaml-topojson/commit/4765b65f618789681171c83481a068726814ccef -- feel free to incorporate that work if it is helpful and please ask any questions you might have :))

feel free to incorporate that work if it is helpful

Done, thank you.
So we add the signatures to the markup file too. I want to confirm what this = <abstr> means in
val t : Topojson.t = <abstr>

This means that the type is abstract and that the top-level (which MDX uses) doesn't have a registered printer function to show the actual value. That's completely fine.

Okay. Thanks for explaining that. I have formatted the code too.

Great thanks!


Error: repo coredns not found when bootstrapping Talos cluster

The task talos:bootstrap command fails, because the repo coredns cannot be found. I fixed this by adding the following lines in helmfile.yaml under the repositories: section:
- name: coredns
  url: https://coredns.github.io/helm

Fixed in https://github.com/onedr0p/cluster-template/pull/1491


Game Crash when Grave expires

Game Crash when Grave expires when dropping items with XP
Version
MC 1.18.1
Fabric API 0.46.4+1.18
Cloth API 3.1.61
You're in Grave Danger 1.2.20
Changed Settings:
enableRobbing = false
canDelete = true
afterTime = 10
timeType = "SECONDS"   ***10 Second only for testing purpose, same crash with longer times
dropInventory = true
putXpInGrave = true
xpDropPercent = 100
crash-2022-03-01_19.45.21-client.txt

Fixed in 1.2.21 and 1.3.0

Seems to be working great! Thanks for the quick fix!

No problem! I try to fix all bugs and feature request as soon as possible if I find any or get them reported. Just make sure you tell me if anything else unexpected happens with the mod or if you have any suggestions!


Wrong calculation!

For comparing the performance between polars and nanocube, I have wrote a test and the results seems to be wrong. I am not able to correlate the actual result with the expected result as well.
My code
from pandas import read_csv as pd_read_csv
from nanocube import NanoCube
from polars import read_csv, col

def filter_with_polars():
    df = read_csv("spotify_data.csv")
    result = df.filter(col("daily") == 1337404).select("streams").sum()
    print(result)
    # shape: (1, 1)
    # ┌────────────┐
    # │ streams    │
    # │ ---        │
    # │ i64        │
    # ╞════════════╡
    # │<PHONE_NUMBER> │
    # └────────────┘

def filter_with_nanocube():
    df = pd_read_csv("spotify_data.csv")
    nc = NanoCube(df)
    result = nc.get("streams", daily=1337404)
    print(result)
    #<PHONE_NUMBER>015

if __name__ == "__main__":
    filter_with_polars()
    filter_with_nanocube()
    # main()

I have added the results in respective methods.
Data - https://www.kaggle.com/datasets/asmonline/spotify-song-performance-dataset
Am I missing something here?

many thanks!, I'll check it.

It's a feature not a bug. The problem is that NanoCube interprets 'Daily' as a measure column, because it's numerical, as is can not resolve 'Daily' as dimension it thinks that you want have the total over all columns and returns it.
If you would define nc = NanoCube(df, dimensions=['Daily'], measures=['Streams']) it works as desired.
So, no't bug but a lack of documentation.

Not a bug, it's. a feature.

Just so everyone can see it...

I can create a PR for adding this into documentation.


Trait FromRequest not implemented for User/Admin when trying to use guards

rust 1.60 stable
rocket_auth = { version = "0.4.0", features = ["sqlx-postgres"] }
rocket = { git = "https://github.com/SergioBenitez/Rocket/", features = ["json", "secrets", "uuid"]}
rocket_dyn_templates = { git = "https://github.com/SergioBenitez/Rocket/", features = ["tera"]}
I see the traits in the rocket_auth lib.......so, obviously, I'm doing something silly.  Looking for input on what I'm doing wrong.
use rocket_auth::{Users, Error, Auth, Signup, Login, User, AdminUser};
#[get("/admin-panel")]
fn admin_panel(user: AdminUser) -> String {
format!("Hello {}.", user.email())
}
error[E0277]: the trait bound rocket_auth::AdminUser: FromRequest<'_> is not satisfied
--> src/admin/bp_user.rs:27:22
|
27 | fn admin_panel(user: AdminUser) -> String {
|                      ^^^^^^^^^ the trait FromRequest<'_> is not implemented for rocket_auth::AdminUser

Specifying the rc1 cleared this up.
rocket = { version = "0.5.0-rc.1", features = ["json", "secrets", "uuid"]}
rocket_dyn_templates = { version = "0.1.0-rc.1", features = ["tera"]}


WIP on result comparison between two branches

Codecov Report

Merging #151 (f6113b3) into master (e52d1c4) will decrease coverage by 1.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   36.93%   35.81%   -1.13%
==========================================
  Files          34       36       +2
  Lines        2418     2502      +84
==========================================
+ Hits          893      896       +3
- Misses       1525     1606      +81

Impacted Files
Coverage Δ

redisbench_admin/cli.py
0.00% <0.00%> (ø)

redisbench_admin/compare/args.py
0.00% <0.00%> (ø)

redisbench_admin/compare/compare.py
0.00% <0.00%> (ø)

redisbench_admin/utils/benchmark_config.py
62.93% <0.00%> (ø)

redisbench_admin/watchdog/args.py
0.00% <0.00%> (ø)

redisbench_admin/watchdog/watchdog.py
0.00% <0.00%> (ø)

redisbench_admin/utils/remote.py
53.87% <0.00%> (+1.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52d1c4...f6113b3. Read the comment docs.


It seems like tls.Config could use a Copy method, but probably not for Go 1.7.
cc @bradfitz @ianlancetaylor

Related to https://github.com/golang/go/issues/15177?

Yes, probably. It's not obvious to me from the immediate context why these are ok, though.
If they are ok, they're yet more (new?) false positives...in which case, #16227 is related.
cc @valyala

Both cases look like buggy, since they overwrite already existing mutex inside tls.Config with a new one.

d24f446 did the first half, and https://go-review.googlesource.com/28344 is the http2 part, which will be bundled in to std before Go 1.8. Closing.


[question] How is it possible add different data for each state?

I took your guide that speak about single data shared from all states or passed on initialization, but I don't understand how to define one color for each state, for example.
Thanks You
Guide Reference: http://github.com/jakesgordon/javascript-state-machine/blob/master/docs/data-and-methods.md

I don't think there is a library supported method, but I've done:
let machine = StateMachine({
   ... state setup ...
    data: {
        firstState: {a: 1},
        secondState: {}
    },
    methods: {
        onFirstState: function(lifecycle) {
             // logs {a: 1}
             console.log(this.data[lifecycle.to]);
        }
    }
})

Try using a function -
data: function() { return {
  firstState: { a: 1},
  secondStat: {}
}};

2024, but another approach is:
// Define your data as an array of objects with a name field that corresponds to its state name
const waterCycle = [{name: "water", color: "blue", temperature: 30},
                    {name: "ice", color: "white", temperature: -10 }]

const machine = new StateMachine({
        init: initState,
        transitions: transitions,

        // Assign the data on the machine to be that array
        data: { waterCycle },

        // Add a method to access the data based on the current state
        methods: {
            activeCycleData: function () {
                return this.data.find((c) => c.name == this.state);
            }
        }
    })

Then to get the color of the active state you would call:
machine.activeCycleData().color

Or its temperature:
machine.activeCycleData().temperture

Related
You can call transitions based on it's name by using the syntax:
machine["transition name"]()

In addition to the
machine.transitionName()

form from the docs. This is helpful in the case where you're also generating the transition names.


⚠ Spryr has degraded performance

In ae240fd, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3994 ms

Resolved: Spryr performance has improved in 59298aa after 7 minutes.


No launch button displayed

I just installed the extension and it's not displaying the launch button. It's not much of a dealbreaker because I set shortcut keys (Shift+Alt+L) to launch it anyway, but it was something I noticed was missing.

I figured it out. I've got long list of options that were hidden under "More Actions..." and only 8 can fit on screen at a time. I just had to set the less commonly used actions to hide by right-clicking "More Actions...".

latest version 1.10.2 have removed unnecessary actions from action list, just keep the run  action to enable the launch button appear on the editor, you may want to make an update!
thank you for patience!


fixed positioning (and with that styling) of the react-select menu

Summary
Fixes incorrect theming of select inputs
Ticket Link
Fixes: MM-34217
Screenshots
Before

After

@matthewbirtch added you as reviewer to check if the assigned colors are correct.

Thanks @michelengelen
Time zone dropdown looks good in all themes, but language and number of direct messages dropdowns are still incorrectly themed

@matthewbirtch added you as reviewer to check if the assigned colors are correct.

@michelengelen I think we should change the hover state to 8% center channel text color rather than the button color. This way we're consistent with the menu component we have

@michelengelen I think making this one absolute may not be the way to go. It would be somewhat prohibitive to do on the language select given it is near the bottom edge of the modal and would cause scrolling or be cut off rather than being overflow-visible/on top.
The selectors in _react-select.scss are all based on the container's root class (.react-select), when the normal (body-appended/portal-like) method is used, this selector/path doesn't exist for the options list.
All but two of the class/selectors are all very specific to react-select and its elements, I'd propose removing the first level .react-select (except on those two that need it).
This does reduce the selector specificity, so it might negatively affect instances eleswhere, but from the surface this patch seems to fix it. (just the selectors, not colors)
MM-34217.patch.zip

Hey @calebroseland i know that way of fixing this bug. It is a more "global" approach and that's why I have gone down the other path first. I just did not want to provide a solution, that possibly has side effects in other places.
Since those effects generally seem to be less likely to happen I will change my proposal accordingly.

This LGTM for the most part. My only hangup is I'm noticing this odd UI state—where the welcome tutorial jumps.

Closer up, depends on scroll position (maybe whether or not the portal/dropdown content overflows browser viewport?)

@michelengelen I think we should change the hover state to 8% center channel text color rather than the button color. This way we're consistent with the menu component we have

@michelengelen did you see this note?

Let's change the hover state to 8% opacity center channel text color.
Also, I just noticed that the active state when I press the mouse down makes the option illegible. We should change the active state to 8% opacity button background color

@matthewbirtch I did change the opacity on hover and active state.
You wrote that active should have 8% as well, but since that opacity value is already on hover I doubled the value like we do with the buttons, is that OK?
Screenshot

1 => selected
2 => active
3 => hover
@nevyangelova and @calebroseland I did change the way the styles are structured to cover the usage with non-portaled selects as well ... just in case! :D

/update-branch

@matthewbirtch I did change the opacity on hover and active state.
You wrote that active should have 8% as well, but since that opacity value is already on hover I doubled the value like we do with the buttons, is that OK?

Sorry, I think I wasn't clear @michelengelen.
hover: use var(--center-channel-color-08) for the background
active (mouse down) state: use var(--button-bg-16) for the background
selected: use var(--button-bg) for the background and use var(--button-color) for the text
hover + selected: use var(--button-bg-88) for the background and use var(--button-color) for the text (right now this look broken)

@michelengelen Do we know which PR originally caused this bug and if we could consider reverting that? Just want to make sure were not introducing a last-minute regression when this PR gets merged by tomorrow's code freeze deadline.

@amyblais i done know what bug you are referring to. The one @calebroseland found with the overflowing select menu?

@michelengelen This: https://mattermost.atlassian.net/browse/MM-34217

No, I don't know which PR was the cause for this.

ok, @matthewbirtch could you please re-check?
Screenshot

1 => selected + hovering - var(--button-bg-88) + var(--button-color)
2 => selected - var(--button-bg) + var(--button-color)
3 => active - var(--button-bg-16) + color: inherit
4 => hover - var(--center-channel-color-08) + color: inherit
Is this correct?

/cherry-pick cloud

Cherry pick is scheduled.


Some powershell commands in the "How to Run the OSM Manual Demo" dont work

TBH: I'm not sure if its the documentation that is wrong or if its something in my environment or if there is an issue with the commands.
I have been following the "How to Run the OSM Manual Demo" and have encountered some issues
First, in the section "Create the Bookstore Application Namespaces" the following script is supplied
for i in bookstore bookbuyer bookthief bookwarehouse; do kubectl create ns $i; done
However this results in the following error:

Missing opening '(' after keyword 'for'.

I managed to get around this by creating the namespaces individually.
But then in the "Verify the Traffic Policy Mode" the following command is given:
kubectl get configmap -n osm-system osm-config -o json | jq -r '.data["permissive_traffic_policy_mode"]'
This produces the following error:

jq: error: permissive_traffic_policy_mode/0 is not defined at , line 1:
.data[permissive_traffic_policy_mode]
jq: 1 compile error

I again managed to get around this, by using the kubectl describe command on the config map to check the permissive_traffic_policy_mode value.
Then, in the section "Permissive Traffic Policy Mode" the following command is given to update the config map:
kubectl patch ConfigMap osm-config -n osm-system -p '{"data":{"permissive_traffic_policy_mode":"true"}}' --type=merge
But again this doesnt work and responds with the following error:

Error from server: Invalid JSON Patch

Is it the documentation that is wrong? Or have I missed something?

@apoutney , the commands that are failing for you are to be run on a Unix (or similar) shell. These aren't powershell commands, so running them on powershell are going to fail.

@shashankram, thanks for the clarification :).  I hadnt seen anywhere in the documentation that suggested they Unix shell commands.  Since kubectl is just the cli I assumed they would work in powershell

@shashankram, thanks for the clarification :). I hadnt seen anywhere in the documentation that suggested they Unix shell commands. Since kubectl is just the cli I assumed they would work in powershell

@shashankram Does the doc need to be updated with a title UNIX as suggested above?

@shashankram, thanks for the clarification :). I hadnt seen anywhere in the documentation that suggested they Unix shell commands. Since kubectl is just the cli I assumed they would work in powershell

@shashankram Does the doc need to be updated with a title UNIX as suggested above?
If so, Please assign me this :)

The prerequisites mentions this:
a workstation capable of executing Bash scripts
Does that suffice?

I have windows capable of running bash scripts