OIST  Internship

Apply for the OIST Internship in Japan 2023. The OIST Japanese Internship Program is now open. This Internship is a Fully Funded Internship in Japan at Okinawa Institute of Science and Technology. All Costs will be Covered in Japan Internship Program. The Undergraduate, Graduates Students from all around the world are eligible for the OIST Japanese Internship Program. OIST Internship in Japan Will Change Your Life.
You Don’t Need to give any IELTS or other language Tests to be selected for the Japan Internship program. The Minimum Duration of the OIST Internship will be between 2 & 6 months, Normally 10 to 12 weeks. There will be No Extension. A diverse range of academic Fields is available for the Interns to work in relevant Fields of their Interest. OIST provides a Friendly environment and other Social Activities during their Internship program.
Enjoy your Summer Internship Program in Japan. OIST is a paid internship in Japan. The internship Japan for international students is a Great Opportunity to complete Summer Internship in Japan & explore & they will see the Door open towards their Future Career. An internship in Japan will be an investment in the future. So, everyone takes this Opportunity Seriously and apply with your full Interest and make sure to read all the details given below.
Country: Japan
Internship Duration: 10 to 12 weeks
Financial Benefits: Fully Funded
Eligible Countries: All Nationalities
Available Fields: Multiple Fields
Deadline: 15th October 2022
Financial Coverage
The Okinawa Institute of Science and Technology Provides a Fully Funded all Expenses Covered Internship Program. All costs of the Selected participants will be covered Under the OIST internship. This is a paid internship in Japan
Round Trip Airfare Travel Tickets for successful applicants are arranged by the OIST
Insurance
Visa support
On or off-campus Housing Accommodation
Commuting Support
Allowance (Stipend) – 2,400 JPY Per day (taxable)
Also Check: Fully Funded Scholarships in USA 2022 | Submit Applications
OIST Internship Fields
The OIST Graduate School offers internship Opportunities in Multiple fields to Undergraduate & Graduate Students as Research Interns. This will give them an opportunity to gain experience & learn a specific technique.
They will work under the direction of a Professor at OIST. As an Intern, the following fields are available to do Research.
Physics, Chemistry, Biology, Neuroscience, Mathematics, Computational Science, Environmental, Ecological and Marine Sciences, Science, Engineering, and Medical.
Required Application Materials
Curriculum Vitae
Statement of Interest
A letter of Recommendation
Academic Transcript
ID Photo
Note: You must enter all the details in the application form (Given below) at once and cannot resubmit an application. Once you have obtained all the documents above, please attach and apply to the program through Online Application.
Eligibility Criteria
The Following Eligibility Criteria will be Consider for OIST Paid Internships Abroad.
Students who are enrolled in a Graduate Degree program in Universities, Colleges, Junior colleges, & vocational schools.
Students who are enrolled in an Undergraduate Degree program in universities, colleges, junior colleges, and vocational schools in Japan OR Overseas.
Recent Graduates of such institutions are also eligible to apply.
Currently, Enrolled students must have approval from their home institution.  If you are currently a student, please confirm with your institution.
Bachelor Year 3rd and 4th and Master Year 1st & 2nd students are particularly encouraged to apply.
Also Check: The Rhodes Scholarship 2023 in UK | Fully Funded
Application Deadline (Important)
The laat date to apply for the OIST Japanese Internship in Japan 2023 for the Spring 2023 is 15th October 2022
How to Apply for the OIST Research Internship Program
All the Application Process is Completely Online. There is No Separate Application. Fill the Online Application Form, Upload all the Documents. Please Remember, You can not save Your Application. To Apply, Please Visit the Official Website of the OIST Japan Internship Program

@avinash201199 add me


Added checkLicenses to test tasks

Issue

None

Overview (Required)

Stopped running check task, then CircleCI doesn't checkLicense too.
So I added checkLicense to test tasks of CircleCI.

Links

https://github.com/DroidKaigi/conference-app-2017/pull/195#discussion_r99980201

Oops. Thanks.

LGTM! Good catch 👍


[FEATURE] LXD/LXC support for lightway vm like linux full system

The availability in cases of low profiles hardware to run lightway linux containers instead of full kvm like vms will be very appreciate to run aside docker.

Curious on how this differs from integration with a Rancher instance? I'm also looking at hybrid VM/container support and we were just going to add a Rancher server.

Sorry, other hypervisors/container technologies are out of scope for Harvester at this moment.

@aperez900907 I second this request. LXC is very lightweight and is presently supported on Proxmox (KVM) and ESXi.
If Harvester had the ability to run LXC containers, that would further increase competition within the hypervisor market considering the underlying advantages Harvester has @ the storage layer.
CC: @yasker

Yes, switching from Proxmox for full-on Kubernetes, the need to setup full VMs with own OS is kinda annoying in comparison to lightweight LXC

It would actually be a great idea to allow for a more lightweight way to run containers in a hypervisor cluster. This would be a step towards developing Harvester not just as a layer for quickly deploying a Kubernetes cluster, but also as a standalone product or private cloud.
IMHO, for implementation, I'm missing:

Flexible networking (creating separate networks, routing between them, OSPF or BGP between clusters).
Verification of backup and snapshot integrity.
The ability to run lightweight containers (but not Docker images).

LXC would be a great addition to Harvester. Many people running Proxmox would probably switch if they could use LXC inside Harvester. Myself included. I am still looking for a great Hypervisor that can run Kubernetes/Docker LXC and KVM all at the same time and well managed.


Log transfers in pseudo-NetLogger format

Outputs a log entry after each transfer to System.out. The output
format resembles the NetLogger format described at
http://netlogger.lbl.gov. Log output is machine-friendly and suitable
for automated monitoring dashboards,
e.g. http://prp-maddash.calit2.optiputer.net/maddash-webui/index.cgi.

Thank you for the feedback and please re-review.
-Nick

Looks good for me


Authorization: Use only authorization based checks instead of roles

Use only authorization based checks instead of roles

[ ] Provide a PoC for the list (companies)
[ ] Check the PoC on more complex lists
[ ] Apply the PoC on all lists
[ ] Get rid of role usage in the backend

Dups


nil, true, false not reserved words

What version of Go are you using (go version)?
go1.7.3 darwin/amd64
What operating system and processor architecture are you using (go env)?
$ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/simen/go"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.3/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.7.3/libexec/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/_9/2x43ffkj2t13pf5wn5fwnwtc0000gn/T/go-build537154098=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"

What did you do?
https://play.golang.org/p/5dRCQ7TYEB
package main

import "fmt"

func main() {
  nil := "World"
  true := false
  if (true == false) {
    fmt.Printf("Hello, %s!", nil)
  }
}

What did you expect to see?
Expected the code not to compile because it assigns arbitrary values to (what I expected to be) important reserved words.
What did you see instead?
The code works as … unexpected and prints "Hello, World".
I understand these have status as Predeclared identifiers (https://golang.org/ref/spec#Predeclared_identifiers) but question the value of not flagging these as errors immediately.

This is intentional. They are predefined identifiers:
https://golang.org/ref/spec#Predeclared_identifiers
One of the reason is that we can extend the language
by introducing more of these without breaking existing
program that already make use of the extended identifier
as a user identifier.

One of the reason is that we can extend the language by introducing more of these without breaking existing

@minux: Making "nil" a reserved word does not prevent the introduction of future identifiers that are not called "nil", so the explanation doesn't make sense. Certainly, if you were to introduce a new special value today called "foo", for example, you simply couldn't avoid having to make it identifier instead of a reserved word. But "nil" and friends have existed since before the dawn of Go.
Besides, does assigning new values to true, false, nil, iota (all of which have globally destructive effects) even have legitimate use cases? It can be argued that any such assignment is going to lead to Very Bad Things, or at least Pretty Silly And Unexpected Things.
Go is very strict about things like unused imports and unused variables, yet it curiously has no problem with this. At the very least go vet should say something, which it doesn't.

The explanation does apply to "append", which is introduced later.
One other reason is that a lot of the predeclared identifiers makes
perfect sense to be used as a user defined name sometimes (within
in a small scope, perhaps).
For example, naming two variables old and new is quite reasonable.
go vet shouldn't out law such uses.
I think this question has been discussed extensively in the past,
please search the mailing list archives.

@atombender Making nil a reserved word would break existing correct Go programs, and would therefore violate the Go 1 guarantee (https://golang.org/doc/go1compat).

Of course. However, that does not explain the rationale for why it was designed like this in the first place.

On Dec 5, 2016, at 01:16, Ian Lance Taylor<EMAIL_ADDRESS>wrote:
@atombender Making nil a reserved word would break existing correct Go programs, and would therefore violate the Go 1 guarantee (https://golang.org/doc/go1compat).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@atombender The rationale is pretty simple: Only identifiers that must be keywords for syntactic reasons are keywords.
In fact, in the very beginning there was some discussion as to whether things like nil, iota, etc. should be keywords. Eventually we agreed on the rule above which settled it.

That's been clearly stated by now, but seeing as the go vet generally very strict and opinionated, it is impossible to grasp why it would not also warn about reassigning nil or bone fide boolean literals. I struggle to imagine a situation where that would be intentional and well advised.

@griesemer: I suggest that the documentation is updated to include the explanation, because it's not obvious to someone who wasn't there. The rationale is unusually unpragmatic compared to Go's other design choices, and also unusually lax for Go, which is otherwise terribly strict and opinioned about so many things.

@simen It's not impossible to grasp, it's just not been done... :-) And the reason is probably that it's not important to check because it just doesn't happen to be an issue. There's simply more important things to worry about. Also, it's a different issue from this one, so please don't hijack this issue for another subject. This issue is closed. Thanks.
@atombender Feel free to submit a CL for review (perhaps for the FAQ). Also, I respectfully disagree. The rationale is very pragmatic: it's a simple rule that makes it easy to decide what needs to be a keyword and what doesn't; and as @ianlancetaylor has pointed out, it makes it easy to add new predeclared identifiers. Finally, Go is in no way unusual about where it is strict and where not as far as statically typed languages go. The approach chosen for keywords and predeclared identifiers is not new either and has a long history going back at least 40 years of programming language design (Pascal).

@griesemer But other languages are more strict than Go here; 40 years of programming language design has provided us with unassignable constants for these things.
You can't redefine or reassign nullptr or true in C++, except using macros. Since you mentioned Pascal: FreePascal and ObjectPascal don't allow reassigning true or nil (no idea about other implementations). Same thing in Java and D, I believe. Even Python and Ruby are more strict. From what I can tell it's Go that stands out.
I'll submit a PR if I have time.

I'll submit a PR if I have time.

A PR isn't the problem. This was a design decision.

@atombender I'm not surprised about C++... But at least the Python I checked doesn't do anything special:
$ python
Python 2.7.10 (default, Jul 30 2016, 18:31:42)
[GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.34)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> x = True
>>> True = False
>>> False = x
>>> True
False
>>> False
True
>>>

I'm not saying there's isn't languages where this is not the case. But Go is not the only language that made the respective decision.
There's also a question about the wisdom of making these restrictions: It doesn't really prevent people from writing bad code. I could still write var True = false (notice the capital T), and mislead readers. And so forth. Adding restrictions to a language and making it more complicated for a situation that in practice never occurs is in my mind not a good use of resources.

A FAQ entry may be ok explaining this was simply deliberate and carefully thought out design decision - but there's no need to debate this any further. I'm going to lock this issue.

@bradfitz I meant PR for the FAQ/docs.
@griesemer Python isn't strict about the booleans (which are just values), but is about None. Ruby is strict about both.

@atombender Thanks for the clarification. We did discuss making nil a reserved word, but the regularity of the rule mentioned above trumped the irregularity for nil. (The reason was - if I remember correctly - that if one changed nil one couldn't recreate it from whole cloth. On the other hand, if somebody at the top-level changed true and false, one would always be able to re-create them, say via 0==0 and 0!=0. That said, nobody is going to do this in practice.)


[docs] Improve system properties page

Implemented suggestions from https://github.com/mui-org/material-ui/pull/24503#pullrequestreview-572106873
This PR: https://deploy-preview-24524--material-ui.netlify.app/system/properties/#main-content
Next: https://next.material-ui.com/system/properties/

I have tried to polish it. Marija please have a look at my changes, see if there are OK. In any case, much better 😇

Looks good to me!

I have tried to polish it. Marija please have a look at my changes, see if there are OK. In any case, much better 😇

Looks good to me!


Fix python.json

The old python.json has a problem: If no python history file exists yet, one will need to be created and will be put in $HOME/.python_history. So therefore there will be 2 python history files: $HOME/.python_history and $XDG_CACHE_HOME/python_history. The changes I made solves this.

Thanks!


Swagger 2.0 spec allows array of files

so maxCount is not necessary:
https://swagger.io/docs/specification/2-0/file-upload/

some thing is missed


[fix]: demo app submit handling

Right now when you click Submit on the demo app, you'll get a message:
Hi, My username is undefined. This Library is not awesome.

Ahhhhhhh 😱
Well, don't panic. The fix is simple... you just need to modify the getFormGroup method and the Form.astro component
✨ Hint: getFormGroup is now returning undefined because it is not finding an element with the passed name.

Hi @slashgk! The method getFormGroup(...) needs to be updated to correctly return the  element rendered by Form.astro so that subsequent calls to simpleForm.get(...) will not be undefined. Hope this helps! Let me know if you have questions. :)

gonna take a crack at this!

Significant changes to the project make this issue obsolete. Closing this now.


Hanging at first activation

Steam recently pushed an update. It seems to have broken the call to activate the key with Steam. The program just hangs now.

I know you're a busy man, and I've tried to tinker with the calls but I can't seem to figure out where it's having its issues. The Steam Key list grows as I don't wanna activate by hand


shim: enable goerr113 linter checks with the necessary fixes

All of the cases fail with:
"err113: do not define dynamic errors, use wrapped static errors instead"
Fix the code accordingly.
Signed-off-by: Mikko Ylinen<EMAIL_ADDRESS>

@jiazhang0 @haosanzi looking for one more pair of 👀  here :)


Casts on Model.aggregate

Aggregation should cast ObjectId on $match.
I've tried this https://github.com/LearnBoost/mongoose/pull/2546#issuecomment-67352317, but it won't work as well stated by @vkarpov15

One of the things that is nice about aggregation IMO is that it bypasses any of mongoose's auto-casting abstraction layer... making it very fast.  Not only is ObjectId not cast, but none of the data in the aggregation pipeline is cast.  Mongoose basically provides a more simplified API to the native mongo aggregation engine and users should be aware of this.  It's an advanced feature and as such should require an elevated understanding of how mongo really works.  In real mongo world, you have to cast ObjectIds (and other data) manually - I think the same should apply for aggregation so that the implementer can be in control of the performance.

@DesignByOnyx's argument is one reason why this isn't supported. Another is that any implementation would be of limited use because the state of documents in the aggregation pipeline may not match any schema. Casting takes advantage of the fact that you know the path "user._id" should be an "_id", but after a "$project" or "$group" that may have changed. You could only really make this cast on $match pipeline stages that happen before any $project or $group.
As a workaround, you can create a document and then use the document's fields as parameters to aggregation. For instance, if you're doing something like:
MyModel.aggregate().match({ 'user._id': req.body.user });

You can always do
var m = new MyModel(req.body);
MyModel.aggregate().match({ 'user._id': m.user._id });

So the model constructor does casting for you


[kernel-heap] can't find crate for alloc

Trying to compile the code from the kernel-heap post, both what I've written myself and what's in the repo under the kernel_heap tag, gives the following error on a current nightly:
error[E0463]: can't find crate for `alloc`
  --> src/lib.rs:26:1
   |
26 | extern crate alloc;
   | ^^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

Thanks for the report!
The problem is that xargo only cross compiles the core library by default, but we also need the alloc and collection libraries. To fix this, you need to create a file named Xargo.toml at the project root with the following content:
[target.x86_64-blog_os.dependencies]
collections = {}

This instructs xargo to also cross compile collections and alloc.

This solution was mentioned in the old “Returning from Exceptions” post, but I forgot to add it to the “Kernel Heap” post after we landed #300. I try to fix it in the next few days.

Ah, I see, thanks!


Make apply_xedocs_configs more flexible

Modify the apply_xedocs_configs function to accept arbitrary db parameters and filters from context functions.
This is useful e.g. for loading configs directly from a PR on the corrections github repo

coverage: 93.538% (-0.03%) from 93.567% when pulling 71cd6387c94e1279220b2a794f90b5ca16a8dc55 on apply_xedocs_configs_kwargs into 2a742ae673c77e81f8f1cf9cd3a88dc4722344b9 on master.


feat(guides): Move AV1 to unwanted

Pull Request
Purpose
Resolve: #1962
Approach

[x] Remove AV1 from Radarr and Sonarr optional guide sections.
[x] Add AV1 to Radarr and Sonarr unwanted guide sections.
[x] Add AV1 to Radarr and Sonarr profile JSON files.
[x] Built and tested locally.

Open Questions and Pre-Merge TODOs
None
Requirements

[x] These changes meet the standards for contributing.
[x] I have read the code of conduct.

@yammes08 your pull request title "Feat(guides): Move AV1 to unwanted" does not conform to our naming conventions.
Please update the title to match the pattern: "feat|build|chore|style|fix|update|ci():
You can check your title at this regex101 link."

Updated

I also added .DS_Store to .gitignore.

Tested it locally on the different quality profiles and i didn't see any issues

I need to update the Collection tables before merging.


cAVS IPC driver, power & clock unit tests

This adds a register interface and driver for the host IPC hardware (essentially the bidirectional interrupt trigger with the host PC), along with a test for it based on some rework of the python scripting submitted earlier in #41803 (which I'm about to close).

Sneak in one more patch with a productized smoke test for each core's cache & clock state.

Seems like this may be in review for another few days, so sneak in three more patches containing work on the MP power management and some smoke test additions

Push a more general API in the final patch of the series.  All this does is add a Zephyr device model subsystem wrapper around the driver that exposes the minimal/simplest/most-easily-reimplementable-on-other-platforms subset[1] of the IPC functionality as a generic API called "inotice".[2]
So instead of using the underlying cavs_ipc_() API, you can use inotice_() wrappers which indirect through the .api pointer of the device to find the specific callbacks.  And I was pleased to see that as long as one is careful to use "INOTICE_DEV" (which is a macro that expands to the static devicetree-instantiated device object), the wrappers get folded by the optimizer and the generated code is identical.
[1] Basically just sending messages consisting of two dwords of data (with platform-dependent significant bits) and receiving them on the other side in an interrupt callback.  I dropped the DONE interrupts and async command completion, though because the underlying cavs_ipc driver is still there you can use those features directly on the same device pointer and they'll work fine, just not portably.
[2] I'm not calling it IPC.  "Inter-process communication" in my world mean semaphores and queues and pipes and locks.  They aren't a hardware device.

Rebase; the cavstool script merged separately.

So how is this looking?  Things are starting to back up behind it, is this something folks think can be merged?  If not, can I get some direction as to what needs to be changed?  If we can't get to a resolution on an appropriate abstraction, can we at least merge the hardware driver layer on top of which we (really SOF: it's SOF that needs the abstraction) can build something later?

It seems like we're in a sort of paralysis loop here, with @lgirdwood asking for an abstracted AP, and @nashif and @MaureenHelm uncomfortable with my (admittedly minimal) existing attempt.
But... there are some practical concerns here:

I need to get this merged so I can continue submitting more work

I need this driver merged, or something very like it, because I'm now using the host communication to the loader script to be able to write unit tests for multiprocessor startup and clock control.  And we want those!

So, how about this: I remove the cavs_ipc.h header and inotice.h headers both from the public include directories and put them in as SOC-level APIs only.  I can use them from there, and in the future when we decide on an appropriately portable SOF interface we can either evolve it or implement the portable API in terms of cavs_ipc.
Will that unblock the merge here?

As promised, here's a version without any new public APIs, limiting the cavs_ipc driver to a soc role.  And I added the patches that are now using it to effect unit testing on the hardware, to demonstrate the value of getting this merged independently of a design for a portable SOF abstraction.

I now have HDA working with host in/out streams and all, it depends on this branch currently as I'm using the cavs_ipc.h mechanism to ensure proper ordering of operations between the host and dsp. Any updates on this?

Why wont we start using more explicit/descriptive include paths

No argument at all from me about where to put the header.  This one is where it is simply because it's a SOC-specific driver (i.e. in its own directory that doesn't exist on Zephyr builds for other platforms) and because "cavs" is in the filename already so it seemed like it was reasonably disambiguated.  For cross platform driver subsystems (like IPM), we do in fact have a curated tree in include/drivers//...
Mostly though, these discussions generally turn into big bikesheds, so I keep my head down and try to structure changes to have minimal impact.  Realistically we're always moving stuff around anyway so any decision made will be ephemeral anyway. :)
But sure: if someone wants the driver somewhere else just say so and I'll move it.

@lyakh I'm sorry, I came by to push another version and realized there were a bunch of stale comments to your review.  Please let me know if these don't resolve your concerns.  New version inbound in 3, 2, 1...

OK, new version up.  @lgirdwood what you will want to look at are the final three patches, which puts the SOF ipc3/ipc4 protocols under a Zephyr "IPM" device.  See API at https://github.com/zephyrproject-rtos/zephyr/blob/main/include/drivers/ipm.h (or generated doxygen in a link I'm having trouble finding at the moment, of course).
@teburd Your DMA PR on top of this is likely to collide a tiny bit (if nothing else with the command IDs for the cavstool script, because I added a new one), sorry.   Let me know if you have any trouble.
@aborisovich The broad idea here (that I think will work, but again this is based on merely reading the SOF ipc layer) is that you replace the platform_* layer under ipc3/4 with wrappers on this IPM device.  The first word of the command (the one passed in the TDR/IDR registers) goes in the IPM "id" parameter, the remaining ones are just passed as a byte array.  The new asynchronous mode added means that you can hold onto the received buffer (which is always the same inbox memory on cavs) and leave it in place as the result of mailbox_validate().  I do know ipc4 wants to leave this in place during processing (where ipc3 would copy it).  Hopefully there's no major surgery needed to SOF, just some wrappers.  And ideally there should be no changes needed to host drivers if I've done it correctly (which is an open question!).  Let me know if anything is confusing.

No worries, I knew you were improving it, my patchset is relatively small and should be easy enough to rebase, will look closer at this soon

Sorry, the push I just did was to clean up some missing licenses and add a CODEOWNERS line for the new driver.  I promise I'll yell if there are logic changes. :)


The actions to import/export pages does not work in the release 5.1.0

The actions import and export pages do not anything!

There is no problem. The problem was about my dolphin app on my OS!!


Custom profile fields, placement in profile page

In the profile page, custom profile fields are displayed only in the "Extra Details" section, it would be useful to be able to place the fields in different boxes (User info, profile, etc.).

Okay, I tried to cheat the system for a while, but in the end, I think that one more column in the db is not such a huge deal.
My current idea is to add a new column "profile_placement" varchar(15) and use it to define in which block the field will be displayed.
The only partial issue, is that the "placement" column already tries to do something in this respect, but it's just a partial solution and it doesn't solve many of the problems.
I'll try to keep consistent what is already in placement with the new setting, it shouldn't be too difficult.

I'm tempted to say that unless there is some specific needs, this should go to 2.0.

Agreed

TBH I don't remember why I set it for 1.1.x :man_shrugging:


Add EPFL CVLab's Demo, for Material Classification

Hi, this is the first version of Material demo.
Please help me check whether I need to drop something.
Kaicheng

How should I upload the actual model then? As vidit told me yesterday, the model should be also upload through github.
Kaicheng

No, you are free to have your model in GitHub, but this repository is just for the frontend-backend architecture, not for the model itself. You can send me a link to the repository and the files that are needed :)
Nacho


[backport] Windows: fix sparse matrix indexing type

Backport of #4778

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit bdd0ed6166caa42dd496bf43e899206bb76cbae7, target branch v8) succeeded!


long thread descriptions are a design issue

New Threads page lists the threads with title and description. However if the description is lengthy still then it is displayed fully. This is creatig a design issue. Somehow the text must be cropped after a certain max length.

you might find truncate useful

Whithout truncating the body I can arrange the posts in a massonary style. But still a limit is necessary I guess.

If you don't want to truncate then you can use something like http://masonry.desandro.com/.
Nav bar looks nice :wink:

yes I am already using it.

I particularly like this one http://tympanus.net/Development/GridLoadingEffects/index2.html


freezes(lagg) logs spammed with errors.

I got some wierd problems and i think its mekanism related and maybe something with Cofh since i see the ASM event handler inthere, It occurs every 6 to 12hours and it makes the server unplayable.
were running modsauce <IP_ADDRESS> and the problems were there in <IP_ADDRESS> too.
Here are the versions that i use.
<IP_ADDRESS> - Mekanism-1.7.10-<IP_ADDRESS>
<IP_ADDRESS> - CoFHCore-[1.7.10]3.0.0B8-36
<IP_ADDRESS> - CoFHLib-[1.7.10]1.0.0B6-26
<IP_ADDRESS> - Mekanism-1.7.10-<IP_ADDRESS>
<IP_ADDRESS> - CoFHCore-[1.7.10]3.0.0B6-32
<IP_ADDRESS> - CoFHLib-[1.7.10]1.0.0B6-26
the error itself, came back every 6 to 12 hours after a restart and ocurred every 10 - 20 secconds:
http://pastebin.com/7S4L7J3B
I hope some1 can help me with this would be nice! Thanks in advance!

It's horrible spam. Mekanism 7.1.1
hastebin.com/ajifoxeraf.avrasm
hastebin.com/qeyuqokeho.avrasm
server have 20TPS with this spam, but players have lot of lags and kick with reason "time out"...
I tried MekanismDebug and it is little different, but same spam.
hastebin.com/qojolowuto.avrasm
It´s mekanism only or something else?

It's horrible spam. Mekanism 7.1.1
hastebin.com/ajifoxeraf.avrasm
hastebin.com/qeyuqokeho.avrasm
server have 20TPS with this spam, but players have lot of lags and kick with reason "time out"...
I tried MekanismDebug and it is little different, but same spam.
hastebin.com/qojolowuto.avrasm
It´s mekanism only or something else?

Do i need to give more info or are we waiting for the mekanism dev to reply here?
My forum with some screens from what is happening the profile images are not verry accurate i can provide more specific profiler images:
http://zenixgo.enjin.com/forum/m/27460712/viewthread/17999365-modsauce-freeze-aka-lagg-spike-problem
I had some people complaining about lagg and dcs when using/setting up the digiminer.
and in the error i wonder what this means:
net.minecraft.block.BlockStaticLiquid.func_149674_a(BlockStaticLiquid.java:95)
Could it be something with un chunkloaded mekanism machines?

Thanks for thinking with me by the way! really appreciated!

for now we've written an auto restart script so my players can play without lagg however the log is still almost unreadable.

Well, it looks like what I was trying to do there didn't work at all. I'm going to try something that should stop the ConcurrentModificationExceptions but I worry that it'll just cause a deadlock. Weird stuff like this tends to be caused by chunk-thrashing so if you could try chunkloading the networks that are causing the issue and see if it goes away, that could be helpful. I'll see if I can get another debug build out and see how that works as well.

A full log with the last debug build could also be helpful, if you're able to send one.

booting up with the debug atm!

ive put the debug in and the server crashed as soon as some1 logged in, ive tested  it 3times and its caused by the debug version, somehow its a ticking entity (buildcraft laser), then ive put the original mekanism in i can enter that area without crashing the server then ive put the debug in cant enter that area insta crash.
Heres the error:
Time: 1/2/15 6:01 PM
Description: Ticking entity
java.lang.NoSuchMethodError: buildcraft.api.core.Position.writeData(Lio/netty/buffer/ByteBuf;)V
at buildcraft.core.LaserData.writeData(LaserData.java:88)
at buildcraft.silicon.TileLaser.writeData(TileLaser.java:280)
at buildcraft.core.network.PacketUpdate.writeData(PacketUpdate.java:54)
at buildcraft.core.utils.Utils.toPacket(Utils.java:538)
at buildcraft.core.TileBuildCraft.func_145844_m(TileBuildCraft.java:111)
at net.minecraft.entity.player.EntityPlayerMP.func_147097_b(EntityPlayerMP.java:699)
at net.minecraft.entity.player.EntityPlayerMP.func_70071_h_(EntityPlayerMP.java:374)
at net.minecraft.world.World.func_72866_a(World.java:2647)
at net.minecraft.world.WorldServer.func_72866_a(WorldServer.java:838)
at net.minecraft.world.World.func_72870_g(World.java:2600)
at net.minecraft.world.World.func_72939_s(World.java:2412)
at net.minecraft.world.WorldServer.func_72939_s(WorldServer.java:669)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:943)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:423)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:798)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:658)
at java.lang.Thread.run(Thread.java:745)
-- Head --
Stacktrace:
at buildcraft.core.LaserData.writeData(LaserData.java:88)
at buildcraft.silicon.TileLaser.writeData(TileLaser.java:280)
at buildcraft.core.network.PacketUpdate.writeData(PacketUpdate.java:54)
at buildcraft.core.utils.Utils.toPacket(Utils.java:538)
at buildcraft.core.TileBuildCraft.func_145844_m(TileBuildCraft.java:111)
at net.minecraft.entity.player.EntityPlayerMP.func_147097_b(EntityPlayerMP.java:699)
at net.minecraft.entity.player.EntityPlayerMP.func_70071_h_(EntityPlayerMP.java:374)
at net.minecraft.world.World.func_72866_a(World.java:2647)
at net.minecraft.world.WorldServer.func_72866_a(WorldServer.java:838)
at net.minecraft.world.World.func_72870_g(World.java:2600)
-- Entity being ticked --
Details:
Entity Type: null (micdoodle8.mods.galacticraft.core.entities.player.GCEntityPlayerMP)
Entity ID: 2267
Entity Name: Pils78
Entity's Exact location: 32.04, 71.00, 1915.68
Entity's Block location: World: (32,71,1915), Chunk: (at 0,4,11 in 2,119; contains blocks 32,0,1904 to 47,255,1919), Region: (0,3; contains chunks 0,96 to 31,127, blocks 0,0,1536 to 511,255,2047)
Entity's Momentum: 0.00, -0.08, 0.00
Stacktrace:
at net.minecraft.world.World.func_72939_s(World.java:2412)
at net.minecraft.world.WorldServer.func_72939_s(WorldServer.java:669)
-- Affected level --
Details:
Level name: world
All players: 2 total; [GCEntityPlayerMP['Hawaiian_Slime'/1269, l='world', x=-1028.71, y=65.00, z=1595.60](Hawaiian_Slime at -1028.7054698995832,65.0,1595.5966599613612), GCEntityPlayerMP['Pils78'/2267, l='world', x=32.04, y=71.00, z=1915.68](Pils78 at 32.03681661383794,71.0,1915.6791250158994)]
Chunk stats: ServerChunkCache: 2187 Drop: 0
Level seed:<PHONE_NUMBER>931053256
Level generator: ID 04 - BIOMESOP, ver 0. Features enabled: true
Level generator options:
Level spawn location: World: (-97,75,1481), Chunk: (at 15,4,9 in -7,92; contains blocks -112,0,1472 to -97,255,1487), Region: (-1,2; contains chunks -32,64 to -1,95, blocks -512,0,1024 to -1,255,1535)
Level time: 38204832 game time, 40525856 day time
Level dimension: 0
Level storage version: 0x04ABD - Anvil
Level weather: Rain time: 182581 (now: false), thunder time: 81002 (now: false)
Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: false
Stacktrace:
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:943)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:423)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:798)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:658)
at java.lang.Thread.run(Thread.java:745)
-- System Details --
Details:
Minecraft Version: 1.7.10
Operating System: Linux (amd64) version 3.2.0-4-amd64
Java Version: 1.7.0_65, Oracle Corporation
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Oracle Corporation
Memory:<PHONE_NUMBER> bytes (4470 MB) /<PHONE_NUMBER> bytes (6110 MB) up to<PHONE_NUMBER> bytes (6110 MB)
JVM Flags: 8 total; -Xms6G -Xmx6G -XX:PermSize=512M -XX:+UseParNewGC -XX:+UseConcMarkSweepGC -XX:ParallelGCThreads=4 -XX:+CMSIncrementalPacing -XX:+AggressiveOpts

I forgot that my IDE's build system confuses gradle... Redownloading it should fix that issue.

nobody can connect with the new version: error occured connection terminated

I've uploaded a new Debug version that attempts to fix the issue. If you get issues with nobody being able to connect again, pastebin a log and I'll see if I can work out what the problem is.

got the debug working now waiting for the error to appear!

when i fly in specific areas i get : a fatal error has ocurred connection terminated.
When i relog i immeaditly get that message. No spammed log with that error yet.

no i can log on but it seems that the debug gives no errors

I guess it's fixed the CME then. I'll close this for now - if you have more issues with connection being terminated, open another issue for that, I think it's unrelated. Build server is down at the moment but these changes will be in the next build, whenever that's able to happen.

without the debug version u made the errors show again.
Ty anyways for the help


fix breadcrumbs block

fix issue https://github.com/github/docs/issues/2248

Thanks for opening a PR @Arhell! I see that this is currently a draft, let me know when you're ready for it to be triaged for review 💖

@Arhell Thanks for opening a PR! I'll get this triaged for review ✨

update

Thanks to all my buddies to help me

Thanks to all my buddies to help me


Add a licence to CTRL before UDN-Aus

Consider one of the major FOSS licences. GPLv3 or BSD maybe?

Previous discussion reached MIT licence as conclusion.


Log session name when opening/closing session

Why are the changes needed?

Log session name when opening/closing session
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

cc @wForget

Codecov Report

Merging #2851 (2fc4ab7) into master (d958a2c) will decrease coverage by 0.00%.
 Consider uploading reports for the commit ca855de to get more accurate results

@@             Coverage Diff              @@
##             master    #2851      +/-   ##
============================================
- Coverage     63.30%   63.30%   -0.01%
  Complexity      205      205
============================================
  Files           485      485
  Lines         21688    21690       +2
  Branches       2859     2859
============================================
  Hits          13730    13730
- Misses         6660     6661       +1
- Partials       1298     1299       +1

Impacted Files
Coverage Δ

...la/org/apache/kyuubi/session/AbstractSession.scala
96.26% <0.00%> (-0.91%)
:arrow_down:

...ala/org/apache/kyuubi/session/SessionManager.scala
86.61% <100.00%> (ø)

.../apache/kyuubi/client/KyuubiSyncThriftClient.scala
88.28% <100.00%> (+0.09%)
:arrow_up:

.../org/apache/kyuubi/events/KyuubiSessionEvent.scala
93.33% <100.00%> (-0.22%)
:arrow_down:

.../org/apache/kyuubi/operation/KyuubiOperation.scala
68.00% <0.00%> (-1.34%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
84.37% <0.00%> (-0.63%)
:arrow_down:

...ache/kyuubi/operation/KyuubiOperationManager.scala
82.19% <0.00%> (+1.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d958a2c...ca855de. Read the comment docs.

thanks, merged to master


Request: Optional URL/URL Request parameters

Could we make the URL/URL Request parameters optional on the setImageWith... methods?
I know this seems like it doesn't make sense at first, but I have a use case.
I'm using this library with a UImageView contained inside a UITableViewCell. My image url property on my model object is an optional, and if I don't have an image url to display, I'd like to display the placeholder image. In this case, if I have to do the following currently:
func setImageFromModel(modelObject: MyModel) {
    guard let imageURL = modelObject.primaryImageURL else {
      imageView.image = modelObject.placeholderImage
      return
    }

    imageView.af_setImageWithURL(imageURL,
      placeholderImage: post.primaryImagePlaceholderImage,
      filter: nil,
      imageTransition: .CrossDissolve(0.2),
      completion: nil)
}

If the URL parameter was optional, this could be done just the one method call.
I'd be happy to make a PR, but I wanted to get input from @cnoon on this before I started.

While I understand it would be more convenient for your @AnthonyMDev, I don't think this is a good change to make for the community. It introduces additional complexity that is difficult to explain to users. The placeholderImage should always be used as a placeholder, otherwise we're going to create confusion no matter how awesome our documentation is.
Thanks for the suggestion!


Search web

ToDo

Show categories
Explore

Main screen, Figma

Consist of:

Search bar
Categories
Explore section

Search button

[x] Click should open new Search page

Categories

[x] Show first 6 categories
[x] Tap on any category should open Search result screen
[x] Tap on Show all should open Categories screen

Categories, Figma

Categories
Filter by name

[x] Show full list of predefined categories
[x] Tap on category should open search screen for selected category
[ ] Should have separate url search/categories/

Search results

[x] Show list of search results

Search bar

Default (out of focus)
Typing
Out of focus with search phrase

[x] Show Back action on the left, tap should open first Search screen
[x] Show Clear action on the right, tap should clear typed text
[x] Show search phrase
[x] Search bar should be visible on top while scrolling

Search item

Explore

[x] Shot card with 3 items
[x] Title Explore
[x] Add Show all button

[x] Tap should open separate page with url search/explore/

Review

Screenshot

[ ] Points from Explore is stays on the map after Search menu was closed.

Review 2

[ ] Don't show error about location

Screenshot

Leisure
Fuel

[ ] Search doesn't stop if there is no results in visible map area.

Review 3

Screenshot

[ ] Crédit Agricole  search result is in map center, but distance say it 2km

[ ] Can't search toilets directly typing in search box
[ ] Can't search toilets selecting category in All Categories

Review 2

Screenshot

Video

[ ] Search results with filled background
[ ] Search results without icons

[ ] Add space to search query in backend (it's a not live search ui, we request as enter)
[ ] Brand search to fix
[ ] @ivanPyrohivskyi bug search 'silpo ' doesn't find brand 'silpo'


Feature/add tenant header

Add tenant header from environment variable if set.
Thanos expects THANOS-TENANT header, but is configurable, so I just added a small change in the remote-write client to add such header if set in the environment.
E.g.
export TENANT_HEADER="THANOS-TENANT"
export TENANT_ID="123"
// run prometheus remote-write

Then the client Store method adds a header named THANOS-TENANT with value 123 to every outgoing remote-write HTTP POST request.

Accidently pushed to base repo, sorry!


Draft Vision Doc & 2-pager on "How to get involved"

The 2-pager should include:

Information about the Kindly project
Why they should get involved
How they can get involved
Contact Information

Additional comments:
The team will put together a clear vision for the project which may include:
-> Objectives of the pilot in relation to UNICEF, CP, Online safety strategy and PG’s/CP business needs.
-> Positioning of the application in the market i.e. where does it fit against similar engines by Google, FB and other companies. Two potential benefits discussed in the call were:

Using the API for internal tools
Developing a trusted DPG service/API free from commercial interests.
-> Establishing use cases

The OOI is requesting inputs from CP, Safeguarding unit as they continue developing and piloting the product to find the right balance between the functionality offered and safety/privacy of data and children while piloting. In particular the team will reach re: questions that may arise on the below to ensure the right controls are in place and that risk is mitigated and pilot objectives are met:

Training the algorithm
Partnering with TurkCell

ICTD/BRM to stay in touch with both teams to foster alignments.
Next steps:

OOI to talk to CP, Online Safeguarding Unit to refine vision for project/pilot
OOI to loop in PG/CP, EO to discuss risk mitigation measures as piloting proceeds

Done: https://docs.google.com/document/d/18DvrmiQEKhaPh80FHAPwkVyVlUj-81r_Rdks5ygTxRE/edit#
Thank you @lacabra and @nathanfletcher for your support/edits!

Shared with Ronen, Thomas, CPU. Requested review by Wed, Sep 22.


fix: remove the lock in progressbar

This is introduced because of a bug in progressbar. It has been fixed now.
Refer:

https://github.com/tensorchord/envd/pull/1460
https://github.com/schollz/progressbar/releases/tag/v3.13.1

/lgtm

It requires an "Approve".


Update urls following repo move

Summary
Following the recent move of this repo from Qiskit organization to qiskit-community this updates all the urls to the new location. The file theme-variables.jinja is quite out of date and being unused the conclusion was to remove this.
Details and comments

coverage: 92.416%. remained the same when pulling 05c1672725e62ad505e54236587f43884395a8ca on woodsp-ibm:repo_move into 4066fdfad0164937cd1bcac3334d60b861a403fd on qiskit-community:main.


Incorret hash returned when using joins and declarative columns

pluck can be used across multiple tables and:

While not absolutely necessary, the pluck query across multiple tables would be more safely written as pluck("users.first_name, users.last_name, roles.title") to correctly scope columns to their respective table.
http://collectiveidea.com/blog/archives/2015/05/29/how-to-pluck-like-a-rails-pro/

When I run something like pluck_to_hash("users.first_name, users.last_name, roles.title")
I get results similar to:
{"users.first_name, users.last_name, roles.title"=>["john","smith", "accountant"]}

just use pluck_to_hash("users.first_name as user_first_name", "users.last_name as user_last_name", "roles.title as role_title")


API expose MirrorsDisabled setting

as title

Maybe it would be worth to add more general settings endpoint that would return json with such settings?

@lafriks you mean GeneralRepoSettings or something like this?

yeah, for example GET /api/v1/settings/repository that would retrun JSON:
{
  "MirrorsEnabled": false
}

@lafriks how do you like this?

@proton-ab thx - do you have suggestions for other repo related instance settings witch are usefull to expose?

@6543 imho looks good :)

@mrsdizzie will do a pull witch create a new section in swagger docs & move allowed_reactions - throu its outside of this pull scope :)

Sounds good!


Split Publications page into core RBC papers and papers using RBC data

The lists will need to be manually curated.
Non-core papers should be listed reverse-chronologically.

Closed by #48.


Fix typo in ray.php docblock

When publishing the ray.php config file in a new project, I noticed a small typo in the file documentation.
Since the docblock I updated is about a single setting, it shouldn't use the plural "settings", but singular "setting" instead 🙂

Thank you!


feat: add idle_timeout_downstream option

[x] if a client stays connected but doesn't send any packets over the connection for N milliseconds then disconnect client.
[ ] Start with 10_000 ms and test with Prisma and Vercel / Lambda
[x] Put on tenant record
[x] Name it idle_timeout_downstream

Let’s call this the same thing as pgbouncer client_idle_timeout

the terms downstream/upstream offer more specific and clear definitions and we are already using them in the project

Yeah but people will be looking for equivalent configs.

:+1: on client_idle_timeout.
The current implementation is great as is, because it seems you only want to enable the timeout in certain scenarios. Although I believe the current implementation would not close the connection if it asks for a query and then forgets (or is too slow) to read it for some reason, right?
In any case, if you wanted to enable the timeout on most handle_event returns, then I am not the biggest fan of gen_statem/gen_server timeouts because if you forget to return timeout in a single callback, then it may no longer trigger as expected.

Although I believe the current implementation would not close the connection if it asks for a query and then forgets (or is > too slow) to read it for some reason, right?

Yeah, that is not covered

In any case, if you wanted to enable the timeout on most handle_event returns, then I am not the biggest fan of gen_statem/gen_server timeouts because if you forget to return timeout in a single callback, then it may no longer trigger as expected.

@josevalim, what would you recommend using for timeouts? Should I use Process.send_after? I'll need to add a bunch of other timeouts soon

It really depends on the nature of timeouts. Sometimes send_after. Sometimes you can store timestamps on the state and compare when messages arrive, etc. Once you have more details, let us know, and we will gladly discuss :)


Update to Noosphere 0.15.3

Playtesting blocked by stormy network conditions but the tests pass.

We'll need to make sure that sync logic works with the new versioning behavior.

Make sure the sphere you are indexing is at the version you expected when you traversed to it

Plan:
Generate sphere history with a few revisions, noting the CIDs along the way. Follow that sphere from a second sphere and test what happens if we call changes(since:) with an older CID than expected.

@cdata I am still not quite connecting the dots on this one. I'll outline how our indexing works and  my understanding of the problem and you can tell me where the gap is. Currently our indexing process looks like:

Traverse to peer
Read the version from the sphere we traversed to
Check SQLite using the identity of this peer
If we have seen this sphere before, call sphere.changes(since:) with the last version we read, otherwise list all slugs
Iterate over the changes, sphere.reading each memo and updating SQLite

As I understand it Noosphere 0.15.3 will sometimes fall back to an older version of a given memo when we call read if the blocks for the latest version of that memo cannot be read (or time out).
I see the potentially problematic scenario as:

We have a peer with three sphere revisions: 1, 2 and 3
We index them at version 3
Some blocks become unreachable
We attempt to re-index and for one memo noosphere falls back to version 2
We end up replacing our cached copy (version 3) with version 2

I’m not actually sure how to adjust our approach to avoid this, but I also don’t think it’s strictly wrong to keep the index in sync with whatever noosphere returns?

I may be missing something obvious, your previous advice:

Make sure the sphere you are indexing is at the version you expected when you traversed to it

Is hard for me to conceive of, we don’t know the version we’ll get until we traverse do we? We can know if the version of a sphere matches the last version we indexed, but how can I know what I expect from a traversal?

@bfollington it is sufficient to check that you didn't already index the version you got. The problem you want to avoid is indexing a version you already saw, thinking it is some version you haven't seen yet.
You can see the "intended" version (the one that we fail to traverse to in the hypothetical) by using ns_sphere_petname_resolve, which gives you the expected version without traversing (this would not fail in the hypothetical because the data it accesses is part of a sphere you already have).

I should note that if you aren't already using ns_sphere_petname_resolve in the indexing algorithm, then you probably aren't in danger of accidentally recording that you indexed a version you never saw (because you won't have had an expectation of a specific version until the traversal completes successfully).

Tested on device with three peers, all behaving nicely. I'm going to merge this.


Deadline notification

This is the first PR for this feature. This PR includes:

The assignment manager. which fetches assignment information when users log in and keeps its consistency thanks to the PK constraint of IndexedDB.
Chrome notifications. which are invoked when the assignment deadline is approaching. The UI is shown below.

Opt-in. Users can turn off this feature themselves and this feature is turned off by default.

This PR does NOT include:

Specification of the time before the deadline. The default value is 1 day.

@mkobayashime I would like to ask for your code review.

@yudukikun5120
Could you rebase to the latest main to get rid of off-topic commits?

@mkobayashime I rebased the code. Could I ask you for a code review?

@mkobayashime I found more work is needed and converted this PR to a draft. I appeal to you for waiting for a little bit.

@mkobayashime
I close this PR because this feature is too hard to debug if it's completed. But I have another plan and I'll work on it.


Add anyFunctionType to the spec

We have a wildcard type in the compiler called anyFunctionType. Since there are some type system rules that relate to this type (for example the change in #3968), it should ideally be added to the spec. Note that this likely fits into the work of #1186 for updating overload resolution in the spec.

The spec is now an "archived" artifact and we won't be tracking defects against it anymore.


E hotkey to quick equip to best slot available not implemented

Description
This has been implemented on tg for many years and the hotkey is used in a number of scenarios:

After undressing for a shower and quickly dressing yourself, whilst putting other items in your pocket or backpack
After killing someone and needing to quickly pick up items they've dropped
Anytime you're in a rush and want to quickly put an item away, trusting the hotkey to put the item somewhere that makes sense

This keybind works by analysing the type of item you have in-hand then putting it in the best slot:

If it's clothing/equipment, then wear it in it's appropriate slot if the slot is free
If the slot isn't free, then put it in suit storage if it can fit there
If it can't fit there, then put it in belt if it can fit there
If it can't fit there, then put it in pockets if it can fit there
If it can't fit there, then put it in in bag if it can fit there

i don't really think we need this but others may feel differently

I'm not clear on what the keybinding should do. If its targeting an item in the world under a users mouse, then yeah we don't have that and adding something like that might be useful.
If its just quick-equipping the currently held item, there is already a key for that, the use-item-in-hand key (default Z, same as just clicking the currently active hand). If the clothing has quick-equip enabled, it should try to equip it to an appropriate slot. The logic for what counts as an appropriate slot may need improving, but it works well enough atm.

I'm not clear on what the keybinding should do.

It would work like z for clothing that there's an available slot for, but if there isn't then it would put it in suit storage/belt/pockets/backpack as appropriate. Likewise it would put non-clothing in those slots as appropriate.
This allows users to spam simply one hotkey in order to both equip their gear AND fill all their available storage slots with items.

i don't see why that should be one hotkey considering it does different things (and makes it not possible to put clothing items in backpacks or such, forcing you to equip it). furthermore we already have hotkeys for quick inserting (and removing) items into the backpack and belt slots, which I personally think is better than just one hotkey that puts it in some unknown place in your inventory

though, the backpack/belt hotkeys are pretty unused and could maybe do with a better hotkey

i don't see why that should be one hotkey considering it does different things (and makes it not possible to put clothing items in backpacks or such, forcing you to equip it). furthermore we already have hotkeys for quick inserting (and removing) items into the backpack and belt slots, which I personally think is better than just one hotkey that puts it in some unknown place in your inventory

Because that's how the original game is and it's incredibly convenient to pick up, say, a breather mask and hit 'E'. If the goal is to mimic the original game, then putting the equip hot key only makes sense
It doesn't prevent you from storing items either. Storing items is actually still incredibly easy. Click the item to put it in your hands -> click the container

Yes we need a general-purpose quick-equip hotkey like SS13 does. Make it ctrl+e instead (so it doesn't interfere with our activate hotkey) and make it the /vg/ one instead of the garbage TG one.
Easy clap.

which I personally think is better than just one hotkey that puts it in some unknown place in your inventory

It is true that we can't read people's minds when they press E to figure out where they intend the item to go, but in 99% of cases the educated guess goes where the user expects it to. And for the other 1% they'll just learn to not try. Almost all clothing items only go into a single slot. Gloves on hands, boots on feet, etc... Guessing here is trivial
Having put in belt and put in backpack is still useful of course, because they allow you to quickly stash stuff (quick equip for belt would swap belts, not put one in the other).
Also, a good (and this would be better than /vg/) implementation would be stateful and allow you to easily swap between many slots in case of conflict. For example if you have two slots that fit (pocket and suit tank storage) then pressing E twice would maybe put it in suit first, then try putting it in pocket if you press again.

My last idea would need to be accompanied by in-UI indicators and flashing animations to make it clear what is going on, so it's far from trivial.


bypass permissionless concentrated liquidity checks

Creates a governance set whitelist of addresses that can bypass the normal pool creation restrictions on concentrated liquidity pools
What is the purpose of the change

Allow a governance subdao automatically approved stAsset/Asset pools for non-approved quote assets.
Allow a governance subdao to create pools when permissionless pool creation is off

Testing and Verifying

Added unit tests

Documentation and Release Note

[ ] Does this pull request introduce a new feature or user-facing behavior changes?
[ ] Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

[ ] Specification (x/{module}/README.md)
[ ] Osmosis documentation site
[ ] Code comments?
[ ] N/A

I'm not sure why my e2e is failing ☹

I'm not sure why my e2e is failing ☹

There was an issue on main. Got fixed yesterday by: https://github.com/osmosis-labs/osmosis/pull/6426
Merging main here might help

Its likely not an E2E issue, it looks like its failing for a legitimate issue. Will need to add it to my list and will get to this if not figured out

I see the problem, we are failing in both tests that call MsgSetMaxPoolPointsPerTx with the following panic:
raw_log: "recovered: UnmarshalJSON cannot decode empty bytes\nstack:\ngoroutine 178
          [running]:\nruntime/debug.Stack()\n\truntime/debug/stack.go:24 +0x64\ngithub.com/cosmos/cosmos-sdk/baseapp.newDefaultRecoveryMiddleware.func1({0x231a320,
          0x400649f960})\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/baseapp/recovery.go:71 +0x24\ngithub.com/cosmos/cosmos-sdk/baseapp.newRecoveryMiddleware.func1({0x231a320?,
          0x400649f960?})\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/baseapp/recovery.go:39 +0x34\ngithub.com/cosmos/cosmos-sdk/baseapp.processRecovery({0x231a320,
          0x400649f960}, 0x400000e270?)\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/baseapp/recovery.go:28
          +0x38\ngithub.com/cosmos/cosmos-sdk/baseapp.processRecovery({0x231a320, 0x400649f960},
          0x2df5560?)\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/baseapp/recovery.go:33 +0x60\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx.func1()\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/baseapp/baseapp.go:620
          +0xa8\npanic({0x231a320, 0x400649f960})\n\truntime/panic.go:884 +0x1f4\ngithub.com/cosmos/cosmos-sdk/x/params/types.Subspace.Get({{_,
          _}, _, {_, _}, {_, _}, {_, _, _}, ...}, ...)\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/x/params/types/subspace.go:109
          +0x20c\ngithub.com/cosmos/cosmos-sdk/x/params/types.Subspace.GetParamSet({{_, _},
          _, {_, _}, {_, _}, {_, _, _}, ...}, ...)\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/x/params/types/subspace.go:222
          +0x100\ngithub.com/osmosis-labs/osmosis/v19/x/concentrated-liquidity.Keeper.GetParams(...)\n\tgithub.com/osmosis-labs/osmosis/v19/x/concentrated-liquidity/keeper.go:53\ngithub.com/osmosis-labs/osmosis/v19/x/concentrated-liquidity.Keeper.ValidatePermissionlessPoolCreationEnabled(...)\n\tgithub.com/osmosis-labs/osmosis/v19/x/concentrated-liquidity/keeper.go:124\ngithub.com/osmosis-labs/osmosis/v19/x/poolmanager.Keeper.CreatePool({{0x2dc0848,
          0x4000f6ec10}, {0x2df4688, 0x4000142600}, {0x2df4598, 0x4000015320}, {0x2df4610,
          0x400070dc70}, {0x2db88a0, 0x40005ee0e0}, ...}, ...)\n\tgithub.com/osmosis-labs/osmosis/v19/x/poolmanager/create_pool.go:41
          +0x7c\ngithub.com/osmosis-labs/osmosis/v19/x/concentrated-liquidity.msgServer.CreateConcentratedPool({0x238f940?},
          {0x2ddff18?, 0x40046c0180?}, 0xdfa4d0?)\n\tgithub.com/osmosis-labs/osmosis/v19/x/concentrated-liquidity/msg_server.go:39
          +0xcc\ngithub.com/osmosis-labs/osmosis/v19/x/concentrated-liquidity/model._Msg_CreateConcentratedPool_Handler.func1({0x2ddff18,
          0x40046c0180}, {0x2611620?, 0x4004367300})\n\tgithub.com/osmosis-labs/osmosis/v19/x/concentrated-liquidity/model/tx.pb.go:252
          +0x74\ngithub.com/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2.1({0x2ddff18,
          0x40046c0150}, {0x40017f43a8?, 0xdfa2c4?}, 0x264d700?, 0x4006598c78)\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/baseapp/msg_service_router.go:113
          +0x98\ngithub.com/osmosis-labs/osmosis/v19/x/concentrated-liquidity/model._Msg_CreateConcentratedPool_Handler({0x2471640?,
          0x4000126578}, {0x2ddff18, 0x40046c0150}, 0x2b23b20, 0x40046b47c0)\n\tgithub.com/osmosis-labs/osmosis/v19/x/concentrated-liquidity/model/tx.pb.go:254
          +0x12c\ngithub.com/cosmos/cosmos-sdk/baseapp.(*MsgServiceRouter).RegisterService.func2({{0x2ddff18,
          0x4004613d70}, {0x2df5560, 0x40046b0840}, {{0xb, 0x1}, {0x4006b873e0, 0xb}, 0x5d,
          {0x228e54ab, ...}, ...}, ...}, ...)\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/baseapp/msg_service_router.go:118
          +0x288\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runMsgs(_, {{0x2ddff18,
          0x4004613d70}, {0x2df5560, 0x40046b0840}, {{0xb, 0x1}, {0x4006b873e0, 0xb}, 0x5d,
          ...}, ...}, ...)\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/baseapp/baseapp.go:763
          +0x1ec\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx(0x400140e900, 0x3,
          {0x4004552180, 0x169, 0x169})\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/baseapp/baseapp.go:705
          +0x948\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).DeliverTx(0x400140e900,
          {{0x4004552180?, 0x400663e300?, 0x20?}})\n\tgithub.com/cosmos/cosmos-sdk@v0.47.5/baseapp/abci.go:308
          +0xf4\ngithub.com/tendermint/tendermint/abci/client.(*localClient).DeliverTxAsync(0x40015c6e40,
          {{0x4004552180?, 0x40015c6e40?, 0xeda5d8?}})\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/abci/client/local_client.go:93
          +0xec\ngithub.com/tendermint/tendermint/proxy.(*appConnConsensus).DeliverTxAsync(0x4004c29e20?,
          {{0x4004552180?, 0x20?, 0xb?}})\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/proxy/app_conn.go:85
          +0x2c\ngithub.com/tendermint/tendermint/state.execBlockOnProxyApp({0x2de1488?, 0x40012ded80},
          {0x2dea7d0, 0x400116b8a0}, 0x4001b625a0, {0x2df49d0, 0x40012a9560}, 0x5c?)\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/state/execution.go:320
          +0x520\ngithub.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(_, {{{0xb,
          0x1}, {0x40000dcc80, 0x7}}, {0x40000dcc90, 0xb}, 0x1, 0x5c, {{0x400629f6a0, ...},
          ...}, ...}, ...)\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/state/execution.go:140
          +0xf0\ngithub.com/tendermint/tendermint/consensus.(*State).finalizeCommit(0x40013ff880,
          0x5d)\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/consensus/state.go:1654 +0x958\ngithub.com/tendermint/tendermint/consensus.(*State).tryFinalizeCommit(0x40013ff880,
          0x5d)\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/consensus/state.go:1563 +0x278\ngithub.com/tendermint/tendermint/consensus.(*State).enterCommit.func1()\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/consensus/state.go:1498
          +0x8c\ngithub.com/tendermint/tendermint/consensus.(*State).enterCommit(0x40013ff880,
          0x5d, 0x0)\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/consensus/state.go:1536
          +0xb48\ngithub.com/tendermint/tendermint/consensus.(*State).addVote(0x40013ff880,
          0x4004336500, {0x40004e2c30, 0x28})\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/consensus/state.go:2150
          +0x15f4\ngithub.com/tendermint/tendermint/consensus.(*State).tryAddVote(0x40013ff880,
          0x4004336500, {0x40004e2c30?, 0xf4f054?})\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/consensus/state.go:1948
          +0x28\ngithub.com/tendermint/tendermint/consensus.(*State).handleMsg(0x40013ff880,
          {{0x2db90c0, 0x40018158d0}, {0x40004e2c30, 0x28}})\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/consensus/state.go:853
          +0x364\ngithub.com/tendermint/tendermint/consensus.(*State).receiveRoutine(0x40013ff880,
          0x0)\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/consensus/state.go:760 +0x2b0\ncreated
          by github.com/tendermint/tendermint/consensus.(*State).OnStart\n\tgithub.com/tendermint/tendermint@v0.37.0-rc1/consensus/state.go:379
          +0xf0\n: panic"
        timestamp: ""
        tx: null
        txhash: BE5B7CEF46EBDDD1E0E7CE45EAAE500D91C055882F95ACAF0C2E133913AE1D26

need to look into why now, just posting the log for anyone following along

So I fixed it for this PR, but I realized what the issue is that still needs to be addressed:

We add a new param to a module
We attempt to GetParams in the upgrade handler
It errors because we dont re-register the ParamKeyTable if it already exists https://github.com/osmosis-labs/osmosis/blob/f219b45d38436ec68151869968ed2e65f3a388e1/x/concentrated-liquidity/keeper.go#L32-L36

So I think the solution is if we add a new param, we need to regen this ParamKeyTable despite it already existing. This is exactly the reason we got the mainnet bug where pool creation fee got set to 1000 OSMO. I had to work around this using DefaultParams but didn't set that value back.

I better understand the issue now and have the full fix, I will commit to this PR since its fairly related

Re-requesting reviews since I added logic on top of this, but logic that is required to properly initialize new params for this PR and future PRs.
https://github.com/osmosis-labs/osmosis/pull/6420/commits/0441ca3f66df44fa619386f46a6422582b13895a

Ah yes, this makes sense


Start hidden or minimize application

First thx for v3.3
Do you think it's possible to have a tray minimize or hidden.

Tray icon will be added. --minimized command line switch will be added.
This will be done in v3.6.


Added functions intersect/rotate/dot/createRotationMatrix/perpendicul…

This branch implements both Jay and Ian's separate versions of the collinearity equations. It also contains supporting functions in the MdisNacSensorModel that were deleted in the main branch but are required for using Ian's version.

@twilson271828 This is attempting to pull from your branch into master, but I believe you want this to be pulled into a new branch?

Yes, that was my intention.  I created a separate request on my fork, and then created a pull request.  I guess that's not what happened.


feat: Create the fio command for the kubectl plugin

closes #952
Signed-off-by: Danish Khan<EMAIL_ADDRESS>

/ok-to-merge


Feature request: optional organization argument to fork, etc.

Currently, hub fork and hub pull-request only will create forks in [user]/[repo].
I'd really like to be able to (optionally) fork the project under an [organization]/[repo].
There are a number of reasons why this would make sense, but here's mine: I always put projects for which I'm submitting PRs into an organization I've created for this particular purpose since, well, some people aren't so good at following up on PRs in a timely manner; and I prefer not to clutter up "my" repos with a bunch of forks which need to remain for an indeterminate length of time.

Or, I could stfu and go get me some effective golang, which is probably what I should be doing anyway.

@geoff-codes Here is the line where forking happens. If this feature was to happen, then we should add a configuration option that accepts a name of an org that affects the fork operation.

:+1: this feature would be awesome.
Having a fork of a project as a separate code and still being able to do PR across would be very useful.

:+1:

Is anyone working on this? If not I might take a stab at it.

@sjmulder You're welcome to take a stab at it!


Fall of House Lynch and Exotic Materials need balancing

I played Exotic Materials with my girlfriend this evening and we enjoyed it. Great job and I loved using tiles that wasn't really used in the base scenarios. Some suggestions of balancing and improvement:
       - To help balance and add some excitement, add a monster every four-five rounds in the first phase and every two-three rounds in the second phase depending on number of investigators (trying to be vague to not spoil it).
  - Offering a second path particularly in the second phase would be an interesting choice if a puzzle is needed to solve it. Barricades should be place strategically.
 -   Also having additional explore tokens in the second phase might offer some interesting trade offs.

We'll try to test House Lynch soon.

Thanks!
I assume you played with 2 investigators and won?  Can you give me an idea of how far off one of you was from eliminated?
I made a deliberate choice to keep it linear and simple because I wanted a short scenario (we have lots of long scenarios).  The trick is making it hard enough still.
My main controls point are:

Moving the exit
Changing how quickly Mythos ramps up (the events get worse the longer you take)
Increasing Cultist health
Making the custom second phase mythos events more punishing

I think I will do all of these a bit and maybe add some second phase reinforcements (don't really want to do this in the first phase, breaks the theme).

We played with four investigators: two each. Two investigators were wounded and insane (the same investigators) and one was one damage away from being eliminated. I actually thought we would lose, but there were a lot of chokepoints and ranged weapons that we were able to attack from a distance (particularly the basement). Spawning reinforcements on the other side could potentially trap investigators forcing a choice of keep moving to stave off the other side, stay in an advantageous position where you might get trapped but overwhelmed as well as getting punished by the Mythos for waiting.
As for the linear nature, I guess that's the case, but it did seem like we were leapfrogging each other in the beginning. Once we understood the end game, it actually set up well.
The exit could be moved a bit further, but unless there's additional monsters, it just prolongs the game and the only way one could lose is by a random mythos event.

Sounds like I got it pretty close.  I will bump cultist health a little to disuade cleaning them all out.  Might leave everything else for now.

When you play House Lynch, can you please save the game shortly before finishing and send me the vSave file?  That would help a lot.

Sure!

If you still can, check those in first. https://github.com/NPBruce/valkyrie-questdata/pull/3
https://github.com/NPBruce/valkyrie-questdata/pull/2

spanish forum user posted this after testing House Lynch Scenario:
It's translated and summarized:

Tested Lynch scenario with 2 investigators
Few orthographical and translation bugs (these are mine...).
Scenario don't scale up with more investigators. Less players should give IA less actions.
Starting item whisky but after I found a whisky exploring. There are not 2 whiskeis in game...
Exploration gives lot of "get 3 clues"... I think there are too much.
Font size is very small. Should be bigger or customizable.

SPOILERS FROM HERE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

1 first edition spawning Maniac costs 4 threat point and were dificult to have. Here there are maniacs one after another. It looks like a Maniacs "ZOMBIZIDE".
After exploring ALL tokens, the objective wasn't revealed being in a empty board. The Mithos phase was "A Maniac Appears and attacks".  A 6 turns kill bill movie!!
I got lot of weapons and wound and sanity cures. I was untouchable!!
Objective shouldn't be revealed only by time pass,but also by revealing all story about what happened Mr Lynch

There were also lot of congratulations about the conversion, I omitted to get only the part to be revised.

Starting item whisky but after I found a whisky exploring. There are not 2 whiskeis in game...
Not sure why this happened, but 1.1 will change this whole system for the better.
Font size is very small. Should be bigger or customizable.
The whole UI is based around this font size, which is consistent with FFG.  Not going to change at this point.
1 first edition spawning Maniac costs 4 threat point and were dificult to have. Here there are maniacs one after another. It looks like a Maniacs "ZOMBIZIDE".
It is actually pretty similar, in a 2 investigator game you would get them at most every second round, and the same applies here.
After exploring ALL tokens, the objective wasn't revealed being in a empty board. The Mithos phase was "A Maniac Appears and attacks".  A 6 turns kill bill movie!!
Not sure what happened here, but this is never the objective.    Both of these should trigger on finding the last clue.  A save game would be helpful to see what happened.
I got lot of weapons and wound and sanity cures. I was untouchable!!
This is consistant with the original, though I did remove one of the starting weapons recently (not sure what version was played).

Fall Of House Lynch needs a place investigator token like Exotic Material.

Fall Of House Lynch needs a place investigator token like Exotic Material.
Done.

We´ve played House of Lynch (German version) yesterday and it was quite fun but there are also some questions and bugs we found. I need to say that we are new to VdW. This was our third game and the first in Valkyrie.
We love the way you integrated the Monster UI, better than the original.
Questions about Valkyrie itself
The Horror Test. In Valkyrie it seems you need to choose the Horror test it if you want or not manually. Right? But during the Mythos Phase it was unclear for us when the phase ends to choose the test.
When an Investigator is eliminated, the original app says hit the Button at the end of the next Investigator phase. In Valkyrie you need to hit the button directly when the elimination happens and the Scenario will end automatically at the end of the next Investigator phase?
Question Scenario
One Investigator was Sister Mary and the Maniacs loved her. They always spawned on her field. Is there a reason for this?
Bugs, translation issues
There is a door which leads to the Garden. The token say “you need the right combination for the lock” (meaning in the German translation) What you need is the “Silver Key”, so the translation confuses.
There were several doors without any marker? Should this be that way?
--------------- Spoiler, maybe ;)-------------
The text for one Maniac says, “prevent him to gather more samples” (my translation from the German Version) at this point of the game it doesn´t make sense for us.
As written before from eorahil we didn´t got the final clue too (I think it is the “Séance” where you find out what happened with Walter?) Save game could be send.

Thanks for the report.

The Horror Test. In Valkyrie it seems you need to choose the Horror test it if you want or not manually. Right? But during the Mythos Phase it was unclear for us when the phase ends to choose the test.

This is the same as the FFG app, the only difference is I am not displaying a message each round to tell you todo the test, is that what you mean?

When an Investigator is eliminated, the original app says hit the Button at the end of the next Investigator phase. In Valkyrie you need to hit the button directly when the elimination happens and the Scenario will end automatically at the end of the next Investigator phase?

I'm still split on this.  I like the Valkyrie way better but it is inconsistent with the official App, so I might change it.

One Investigator was Sister Mary and the Maniacs loved her. They always spawned on her field. Is there a reason for this?

It is random, she was unlucky.

There is a door which leads to the Garden. The token say “you need the right combination for the lock” (meaning in the German translation) What you need is the “Silver Key”, so the translation confuses.

If someone provides a correction I will apply it.

There were several doors without any marker? Should this be that way?

Are you talking about about door at the edge of the map that go nowhere?  Yes, this is intentional (not enough tokens to close off everything).

The text for one Maniac says, “prevent him to gather more samples” (my translation from the German Version) at this point of the game it doesn´t make sense for us.

Where did this text occur?  It should have been either on a clock strikes 1 timed event or because you found the last clue (you say you didn't).  It means that the maniacs are trying to take samples from you (you should be getting tests) and you have to try to stop them (mostly just make sure you pass that test).  Once they have enough samples the objective will change, or if you go a few rounds without them getting samples you will win.

As written before from eorahil we didn´t got the final clue too (I think it is the “Séance” where you find out what happened with Walter?) Save game could be send.

A save game would be great.

Thanks for the report.
The Horror Test. In Valkyrie it seems you need to choose the Horror test it if you want or not manually. Right? But during the Mythos Phase it was unclear for us when the phase ends to choose the test.

This is the same as the FFG app, the only difference is I am not displaying a message each round to tell you todo the test, is that what you mean?
Yes, because you didn´t say it you can miss it easy.

There is a door which leads to the Garden. The token say “you need the right combination for the lock”
(meaning in the German translation) What you need is the “Silver Key”, so the translation confuses.

If someone provides a correction I will apply it.
I tested it a few times and there are different events at this door. On one other door in this scenario is a hint that says you need the Silver key (the Silver key is needed for minimum two different doors in the scenario?), the same should be there, if I´m right.

The text for one Maniac says, “prevent him to gather more samples” (my translation from the German Version) at this point of the game it doesn´t make sense for us.

Where did this text occur? It should have been either on a clock strikes 1 timed event or because you found the last clue (you say you didn't). It means that the maniacs are trying to take samples from you (you should be getting tests) and you have to try to stop them (mostly just make sure you pass that test). Once they have enough samples the objective will change, or if you go a few rounds without them getting samples you will win.
Not shure about, I think it was after a clock strike. The problem is what "take samples from you" mean, f.e. he want my heart, a part of my body? For what? That make no sense in the storyline that a Maniac (except Walter) want to do this or did he want me simply dead?

As written before from eorahil we didn´t got the final clue too (I think it is the “Séance” where you find out what happened with Walter?) Save game could be send.

A save game would be great
enclose
house_lynch_saveAuto.zip

You answer to quick so you miss my edit ;)
The Back button (great idea), how many steps you can go back?

The Back button (great idea), how many steps you can go back?

I assume this refers to Undo, you can go back to either that start of the quest or when you loaded a save game (the undo state is not saved with save games).

There were several doors without any marker? Should this be that way?

Are you talking about about door at the edge of the map that go nowhere? Yes, this is intentional (not enough tokens to close off everything).

We had enough wall markers left in our game box to close the unused doors ;)


Connections not working after Azure AD user password reset

Issue Type: Bug
I had to change my Azure AD password and since then I have had connection issues. I have removed and re added my account in Data Studio which has allowed me to create new query windows that work but still getting intermitent issues.
Azure Data Studio version: azuredatastudio 1.34.0 (83a4316cf89cbf961a0f09a72c861379cfd01fa9, 2021-12-15T20:47:33.863Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz (8 x 2304)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.78GB (4.14GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

profiler
Mic
0.11.0

schema-compare
Mic
1.12.0

sql-database-projects
Mic
0.14.1

azdata-sanddance
msr
3.3.0

sql-search
Red
0.4.0

poor-sql-formatter
WSR
0.1.0

You haven't specified the error message you're receiving, but I wouldn't be surprised it if was related to #12165.
You can follow the steps over there, which worked for me when nothing else would. I just commented over there with a PowerShell script to automate the process.

@mjmhall1 Did the instructions linked help you at all?

@cssuh FYI - have you had a chance to add that process to our wiki yet?

I managed to get my connection working by going to the user icon and removing my linked account, then restarting data studio and reentering my linked account details.

Thanks for the update, glad things are working again for you. I'll close this now since the issue seems to be resolved - we'll keep working on tracking down these problems to avoid needing to do this again in the future though!


Reply-to is always null

It seems that the ImapX.Message.Reply-to is always null.  I can check the Reply-to field in for example the 'show original' view of an email in gmail and it contains a value but this value is not in the ImapX.Message.Reply-to field when I check the same message downloaded by ImapX  There does not seem to be anything in the code that can affect this. While there are a number of enums in the ImapClient.Folders.Inbox.Messages.Download parameters, they do not seem to affect the resulting ImapX.Message.Reply-to.

@pcapozzi By default, the client will only request a minimal set of headers (See 1, 2)
You can always add additional headers by changing the ClientBehavior.RequestedHeaders property of the client.
/* .. Init client, authenticate .. */
client.ClientBehavior.RequestedHeaders = new[] {
            MessageHeader.From,
            MessageHeader.To,
            MessageHeader.Date,
            MessageHeader.Subject,
            MessageHeader.Cc,
            MessageHeader.ContentType,
            MessageHeader.ReplyTo // add reply-to header
};

You can also just set the property to null to always request all headers:
client.ClientBehavior.RequestHeaders = null;

Hi Pavel,
Thanks SO! much for the reply.  This solved a big problem for our app.
Great code.
Regards,
PatC
On Wed, Apr 22, 2020 at 1:47 AM Pavel Azanov<EMAIL_ADDRESS>wrote:

@pcapozzi https://github.com/pcapozzi By default, the client will only
request a minimal set of headers (See 1
https://github.com/azanov/imapx/blob/master/ImapX/Constants/MessageHeaderSets.cs#L11,
2
https://github.com/azanov/imapx/blob/master/ImapX/ClientBehavior.cs#L23)
You can always add additional headers by changing the
ClientBehavior.RequestedHeaders property of the client.
/* .. Init client, authenticate .. */
client.ClientBehavior.RequestedHeaders = new[] {
MessageHeader.From,
MessageHeader.To,
MessageHeader.Date,
MessageHeader.Subject,
MessageHeader.Cc,
MessageHeader.ContentType,
MessageHeader.ReplyTo // add reply-to header
};
You can also just set the property to null to always request all headers:
client.ClientBehavior.RequestHeaders = null;
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/azanov/imapx/issues/24#issuecomment-617642577, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABE7UJGNF2E2QEW7XSDG73RN2VKLANCNFSM4MNUFOZA
.


rag for json file

Could you create a new feature to handle JSON files in the Rag system?

Not sure what you mean here, can you share more information? Currently the RAG system doesn't support the json extension, BUT, will accept the file as text.
You'll receive a notification when uploading:
"Unknown File Type 'application/json', but accepting and treating as plain text"
It WILL upload the file however, and you can interact with it via rag. Because almost every LLM out there understands json quite well, there's no shortcomings to this approach that I am aware of.


Mocking final (and base?) classes in tests

Now that we have Dart 3's class modifiers we (and 3rd parties) can make our classes final or base.
But final or base classes cannot be mocked. We cannot create mocks in mockito or mocktail way nor just extend them and provide our custom stubs. This is a big obstacle in writing tests like these:
// This class could be 3rd party or from the same package (but other library than test file).
final class SomeDependency {
  final value = false;
}

class MyClass {
  MyClass(this.dep);

  final SomeDependency dep;

  bool getValue() {
    return dep.value;
  }
}

class _MockSomeDependency extends Mock implements SomeDependency {}

void main() {
  test('MyClass.getValue returns the correct value', () {
    final dep = SomeDependency();
    when(() => dep.value).thenReturn(true);
    final myClass = MyClass(dep);

    expect(myClass.getValue(), true);
  });
}

This is now impossible because:

The class 'SomeDependency' can't be implemented outside of its library because it's a final class.

How can developers achieve this now? Would dart:mirrors reflection (which is disabled in Flutter and hence my issue is here, not in Dart repo) help?

That's not really a Flutter issue.
The correct place is probably github.com/dart-lang/language.
There are some related issues there already, with decent discussions

See https://github.com/dart-lang/language/issues/3111 and related issues. Closing as this is not a Flutter-level issue.


Add fancade

It´s a 3d mobile fantasy console that have a visual scripting system, from the creator of mekorama
http://www.fancade.com/

added. thanks for the info!


document deepspeed.initialize()

As a follow up to the very helpful suggestion I received at https://github.com/microsoft/DeepSpeed/issues/633 I propose this doc update.
Thank you!
Fixes: #633
@jeffra

We currently briefly reference this call related to MPI/AzureML environments (https://www.deepspeed.ai/getting-started/#mpi-and-azureml-compatibility) but thanks for adding it higher up since it seems others will also find this useful.

Honestly I'd have never looked there unless I had MPI or Azure ;)
Should I tweak the doc to add that it uses NCCL backend?

Haha totally understandable, it was kind of hidden away it seems :) It also needs to be added to our RTD documentation as well. I'll do that right now actually. You can choose the backend as a parameter, but it does default to NCCL and that's primarily what we've tested everything with across the project. Feel free to add some text about NCCL though.

Thank you, @jeffra
I added the note about the default, but I couldn't find init_distributed's documentation so I couldn't link to it for further details.

Just added it to RTD docs with this PR #645

It's live now at: https://deepspeed.readthedocs.io/en/latest/initialize.html#distributed-initialization

That's excellent. Added the link.

That's excellent. Added the link.


cmd/go: test -c should error on unknown flags

$ go version
go version devel +cacac8bdc5 Tue Jun 9 02:49:06 2020 +0000 linux/amd64

The way go test works, one can mix test's own flags as well as the user's custom flags in the test package. For example, one can run go test -foo -v -bar -count=10, which is roughly equivalent to go test -c -o=test && ./test -test.v -test.count=10 -foo -bar.
I assume that the way this works is that any flags go test doesn't know will be passed to the test binary when running the tests, since they might be declared by the user. This design is perhaps a bit confusing, but works.
However, I think that go test -c shouldn't allow uknown flags. It will not run the test binary at all, so it doesn't make any sense to me. For example, on a simple Go package with tests:
$ go test -c
$ go test -c -badflag
$ go test -badflag
flag provided but not defined: -badflag

This is especially bad because it makes typos very easy to miss. I had written go test -c -glags=all=-dwarf=false, which was succeeding. It took me another hour to realise the -gcflags typo, and that the flag wasn't doing anything at all.
If -c is used, any unknown flag should be an error, even if it precedes -c. If this change seems fine, I can send a CL.
/cc @bcmills @jayconrod @matloob @dominikh

The only possible reason I see in favor of the current behavior is that one can take an entire go test command with any custom flags, and add -c to the list of flags without worrying about the command suddenly failing.
However, that doesn't seem like a good decision to me. go test -c -customflag should not succeed. If it does, it signals that it actually used -customflag somehow, but it didn't.

What about flags known to go test, like -run or -count? They don't make sense for go test -c either. Currently the command succeeds, though.

That's a bit of an open question. To me, they should error as well, but it doesn't seem like such a clear case. Perhaps we could leave those for a follow-up issue, to reduce the chances that the entire change gets reverted due to regressions.

If the flag is known to go test, then it's less likely to be a typo of some other known flag. So I would continue to accept those, on the theory that continuing to accept them does make it easier to just tack a -c on the end of a command to get a binary.

That is: the cost of rejecting flags is the same for both known and unknown flags, but the benefit is higher.
(The cost is the need to remove the flag before attaching -c. The benefit is the likelihood of catching an accidental typo of some other flag.)

Thinking about it again, I'm not sure I agree that "known flags that do nothing" should error. We similarly silently ignore those in other commands, such as go get -d -ldflags=-w golang.org/x/tools working for me even though -ldflags will never do anything due to -d. So it seems to me like that should be a separate issue to tackle the corner case in all cmd/go commands consistently.

I've sent a patch with a test, mainly to get some eyes during the freeze - it's meant for 1.16, and I agree with the early-in-cycle label.

This issue is currently labeled as early-in-cycle for Go 1.16.
That time is now, so this is a friendly ping so the issue is looked at again.


Fix failing pyzmq installation

While building latest TensoFlow and during installing it's dependencies on a CentOS 7 docker, I get the following error:
Collecting pyzmq>=17 (from notebook->jupyter)
  Downloading https://files.pythonhosted.org/packages/64/8d/78975da77627fd863c08e8ea3c7cebce7e51bed2936be5118de6b0050638/pyzmq-18.0.0.tar.gz (1.2MB)
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-rv3k_yvp/pyzmq/setup.py", line 1241, in <module>
        long_desc = f.read()
      File "/usr/lib64/python3.4/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 29: ordinal not in range(128)

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-rv3k_yvp/pyzmq/
You are using pip version 18.1, however version 19.0.3 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Actually this is only effecting CentOS containers I'm building and won't apply here.
Closing the PR.


[Workload][Trait] Rename to align metadata and filename

Description of your changes

as title
How has this code been tested?

Checklist

I have:

[ ] Title of the PR starts with OAM type (e.g. [Workload] or [Trait] or [Scope]).
[ ] Updated/Added any relevant [documentation] and [examples].
[ ] Unit/E2E Tests added.

How about we renaming the file names to match the definition name?

How about we renaming the file names to match the definition name?

@wonderflow think file's name is better, maybe you can tell your reason?

yes, file name is better name