Updated first rule example image

Purpose of this pull request
This pull request (PR) updates the screen image in the "Example rule" section of this topic:
https://help.sumologic.com/docs/cse/rules/write-first-seen-rule/#example-rule
Issue number: 1862
Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions
[x] Update Content - Revisions and updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, and new packages for the site, Gatsby, React, etc

@eli-jang, you said "Please update the screenshot and the description in the below page." But after reviewing the text in the Example rule section, I don't think any of it needs to change based on the new screen image.
Was there some specific text you wanted updated?

@eli-jang, you said "Please update the screenshot and the description in the below page." But after reviewing the text in the Example rule section, I don't think any of it needs to change based on the new screen image.
Was there some specific text you wanted updated?

@eli-jang replied via Slack:
"@jpipkin
sorry for the lack of explanation.
Data Retention (days) -> Baseline Retention Period (days)
Data Period (days) -> Baseline Learning Period (days)

Thanks for the review, @kimsauce! I overrode the old image with the new image. Ready for another check.


Process additional data contained in resolved methods

We can sometimes get media types, responses, headers, body, etc. within resolved methods.
Examples
Java
"@RequestMapping(value = \"/vuln/emptyReferer\", produces = \"application/javascript\")"
"@RequestMapping(method = RequestMethod.POST, value = \"/uaa/users\", consumes = MediaType.APPLICATION_JSON_UTF8_VALUE)"
Javascript/Typescript
"app.use(functionjsonParser(req:Request,res:Response,next:NextFunction){\r//@ts-expect-errorFIXMEintentionallysavingoriginalrequestinthisproperty\rreq.rawBody=req.body\rif(req.headers['content-type']?.includes('application/json')){\rif(!req.body){\rreq.body={}\r}\rif(req.body!==Object(req.body)){//Expensiveworkaroundfor500errorsduringFrisbytestrun(see#640)\rreq.body=JSON.parse(req.body)\r}\r}\rnext()\r})",

@cerrussell, the javascript example looks like a bug.


btcjson: Omit empty error for btcjson.Response

Instead of returning nil for the error field when the error is nil, it is omitted if the error is nil. Having the error field causes error for the electrum protocol as it expects no error fields if the error is nil.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.002%) to 53.286%

Files with Coverage Reduction
New Missed Lines
%

integration/rpctest/blockgen.go
2
83.67%

btcec/signature.go
3
92.76%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
27849

Relevant Lines:
52263

💛  - Coveralls


[WIP] fix: workaround readiness issues:

Remove verifier and keycloak from the service wait list

We have working pipeline now with syndesis-ci template. I'll close this PR as out dated, hope it's OK :)


DivideByZero exception while opening GC Heap Net Mem Stacks

While trying to open the GC Heap Net Mem Stacks view for a trace, it fails to open and I get a "attempted to divide by zero" in the logs:
Started: Opening GC Heap Net Mem Stacks
Completed: Opening GC Heap Net Mem Stacks   (Elapsed Time: 1.016 sec)
Exception Occurred: System.DivideByZeroException: Attempted to divide by zero.
   at PerfView.ETLPerfViewData.<>c__DisplayClass5_0.<OpenStackSourceImpl>b__8(UInt64 objAddress, GCHeapSimulatorObject objInfo) in E:\A\_work\739\s\src\PerfView\PerfViewData.cs:line 4284
   at PerfView.GCHeapSimulator.OnObjectAllocated(TraceEvent data, UInt64 objectID, UInt64 classID, Int64 size, Int64 representativeSize) in E:\A\_work\739\s\src\PerfView\memory\GCHeapSimulator.cs:line 383
   at PerfView.GCHeapSimulator.<.ctor>b__0_5(ObjectAllocatedArgs data) in E:\A\_work\739\s\src\PerfView\memory\GCHeapSimulator.cs:line 174
   at Microsoft.Diagnostics.Tracing.Parsers.ETWClrProfiler.ObjectAllocatedArgs.Dispatch() in E:\A\_work\739\s\src\PerfView\memory\ETWClrProfilerTraceEventParser.cs:line 897
   at Microsoft.Diagnostics.Tracing.TraceEventDispatcher.DoDispatch(TraceEvent anEvent)
   at Microsoft.Diagnostics.Tracing.TraceEventDispatcher.Dispatch(TraceEvent anEvent)
   at Microsoft.Diagnostics.Tracing.Etlx.TraceLogEventSource.Process()
   at PerfView.ETLPerfViewData.OpenStackSourceImpl(String streamName, TextWriter log, Double startRelativeMSec, Double endRelativeMSec, Predicate`1 predicate) in E:\A\_work\739\s\src\PerfView\PerfViewData.cs:line 4310
   at PerfView.PerfViewStackSource.OpenStackSource(String streamName, TextWriter log, Double startRelativeMSec, Double endRelativeMSec, Predicate`1 predicate) in E:\A\_work\739\s\src\PerfView\PerfViewData.cs:line 3843
   at PerfView.PerfViewStackSource.<>c__DisplayClass23_0.<Open>b__0() in E:\A\_work\739\s\src\PerfView\PerfViewData.cs:line 3867
   at PerfView.StatusBar.<>c__DisplayClass22_0.<StartWork>b__0() in E:\A\_work\739\s\src\PerfView\GuiUtilities\StatusBar\StatusBar.xaml.cs:line 254
An exceptional condition occurred, see log for details.

Help > About shows:
PerfView Version 2.0.47
BuildDate: Tue, 29 Oct 2019 11:18:55 GMT

@jasonmalinowski, can you please share the trace that you were opening when you saw this?  It's OK if you need to send me the info via e-mail instead of posting it here.

@brianrob Emailed internally.


WIP: Correct reply address on support emails

Current implementation can post tickets into a sandbox ZD account. You'll need to set up env-vars in the Dockerfile to see this behaviour:
ENV ZENDESK_API_ENDPOINT 'https://your-sandbox-domain.zendesk.com/api/v2/'
ENV ZENDESK_API_USER<EMAIL_ADDRESS>
# you can generate this token from your account in Zendesk Admin
ENV ZENDESK_API_TOKEN 'abcdefghihgfedcba'

Things still to do:

[x] Identify exactly what metadata (tags? groups?) the ZD team needs for us
[x] Change the specs for the rest of the help pages to test against ZD tickets instead of notify
[x] Remove the 'notify' code path entirely for the help pages
[x] Some alternate code path for local dev - maybe just spitting the ticket details at a logger?
[ ] Switch from testing through overriding a constant (Zendesk::Client) to testing at the boundary (using webmock)

Alright, from my perspective, this is good to go. This version happily posts into the sandbox environment from local, with the right tags and contact info on:

I've tested all the individual forms (with the different combinations of optional inputs).
Things not included:

Reworking the testing (this'll take some time)
Sinking the 'organisation' field into the body of the support ticket (this isn't a big job but time is tight)


Add tsx build.

Update tsc and tsserver to latest version.
Modify is_typescript() to recognize tsx views.

@RyanCavanaugh Could you give this a try?


Update log messaging format

EDC Metrics will provide the messaging format we should use. Need to update code to use correct messaging format

Helpful wiki links:
Cloud Metrics 101 for TRT
Data Schema Collaboration Space

Ticket created:
https://bugs.earthdata.nasa.gov/servicedesk/customer/portal/12/CMSD-13


Rework proxy labels update

Please provide a description of this PR:
Fix: https://github.com/istio/istio/issues/40034 and https://github.com/istio/istio/issues/39792

dynamically update proxy labels when pod/wle labels update

Added localityLabel to pod label so we can get proxy locality from pod labels rather than service instances, which may not exist

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

integ-telemetry_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

integ-telemetry_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry_istio

integ-ipv6_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-ipv6_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

integ-telemetry_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry_istio

integ-ipv6_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-ipv6_istio

integ-operator-controller_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-operator-controller_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

integ-telemetry_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry_istio

integ-ipv6_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-ipv6_istio

integ-operator-controller_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-operator-controller_istio

integ-cni_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

integ-telemetry_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry_istio

integ-ipv6_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-ipv6_istio

integ-operator-controller_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-operator-controller_istio

integ-cni_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-cni_istio

integ-security_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

integ-telemetry_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry_istio

integ-ipv6_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-ipv6_istio

integ-operator-controller_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-operator-controller_istio

integ-cni_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-cni_istio

integ-security_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security_istio

integ-pilot-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-pilot-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

integ-telemetry_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry_istio

integ-ipv6_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-ipv6_istio

integ-operator-controller_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-operator-controller_istio

integ-cni_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-cni_istio

integ-security_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security_istio

integ-pilot-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-pilot-istiodremote_istio

integ-security-multicluster_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

integ-telemetry_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry_istio

integ-ipv6_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-ipv6_istio

integ-operator-controller_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-operator-controller_istio

integ-cni_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-cni_istio

integ-security_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security_istio

integ-pilot-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-pilot-istiodremote_istio

integ-security-multicluster_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-multicluster_istio

integ-telemetry-mc_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

integ-telemetry_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry_istio

integ-ipv6_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-ipv6_istio

integ-operator-controller_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-operator-controller_istio

integ-cni_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-cni_istio

integ-security_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security_istio

integ-pilot-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-pilot-istiodremote_istio

integ-security-multicluster_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-multicluster_istio

integ-telemetry-mc_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry-mc_istio

integ-pilot-istiodremote-mc_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test unit-tests_istio

analyze-tests_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test analyze-tests_istio

release-test_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test release-test_istio

lint_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test lint_istio

integ-distroless_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-distroless_istio

integ-security-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-istiodremote_istio

integ-telemetry_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry_istio

integ-ipv6_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-ipv6_istio

integ-operator-controller_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-operator-controller_istio

integ-cni_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-cni_istio

integ-security_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security_istio

integ-pilot-istiodremote_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-pilot-istiodremote_istio

integ-security-multicluster_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-security-multicluster_istio

integ-telemetry-mc_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-telemetry-mc_istio

integ-pilot-istiodremote-mc_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot-multicluster_istio
957af862580404815e4acd6203fa7b5638c813fc
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
0af81cc4bc9a808f6beda96f3d6d949546463393
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
0af81cc4bc9a808f6beda96f3d6d949546463393
link
true
/test integ-cni_istio

integ-pilot_istio
0af81cc4bc9a808f6beda96f3d6d949546463393
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
0af81cc4bc9a808f6beda96f3d6d949546463393
link
true
/test integ-cni_istio

integ-pilot_istio
0af81cc4bc9a808f6beda96f3d6d949546463393
link
true
/test integ-pilot_istio

lint_istio
14b6fe47475a7f6bce2eeeb2aa4733f56ee7d560
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
0af81cc4bc9a808f6beda96f3d6d949546463393
link
true
/test integ-cni_istio

lint_istio
d584cf688fbe6ef123e99c5ee49fbafa13b002ae
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
0af81cc4bc9a808f6beda96f3d6d949546463393
link
true
/test integ-cni_istio

lint_istio
d584cf688fbe6ef123e99c5ee49fbafa13b002ae
link
true
/test lint_istio

integ-security-istiodremote_istio
d584cf688fbe6ef123e99c5ee49fbafa13b002ae
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
d584cf688fbe6ef123e99c5ee49fbafa13b002ae
link
true
/test lint_istio

integ-security-istiodremote_istio
d584cf688fbe6ef123e99c5ee49fbafa13b002ae
link
true
/test integ-security-istiodremote_istio

integ-security_istio
d584cf688fbe6ef123e99c5ee49fbafa13b002ae
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
d584cf688fbe6ef123e99c5ee49fbafa13b002ae
link
true
/test integ-security-istiodremote_istio

integ-security_istio
d584cf688fbe6ef123e99c5ee49fbafa13b002ae
link
true
/test integ-security_istio

lint_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
d584cf688fbe6ef123e99c5ee49fbafa13b002ae
link
true
/test integ-security_istio

lint_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test lint_istio

integ-security-istiodremote_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test lint_istio

integ-security-istiodremote_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security-istiodremote_istio

integ-security_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test lint_istio

integ-security-istiodremote_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security-istiodremote_istio

integ-security_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security_istio

integ-security-multicluster_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-istiodremote_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security-istiodremote_istio

integ-security_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security_istio

integ-security-multicluster_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security-multicluster_istio

lint_istio
2971a80830e6ff873c0c9cbaac309e0dcd5a0c66
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security_istio

integ-security-multicluster_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security-multicluster_istio

lint_istio
2971a80830e6ff873c0c9cbaac309e0dcd5a0c66
link
true
/test lint_istio

integ-security-istiodremote_istio
2971a80830e6ff873c0c9cbaac309e0dcd5a0c66
link
true
/test integ-security-istiodremote_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
f5506d7fdebdfa581f71bb21ffb6fe88243a43e7
link
true
/test integ-security-multicluster_istio

lint_istio
2971a80830e6ff873c0c9cbaac309e0dcd5a0c66
link
true
/test lint_istio

integ-security-istiodremote_istio
2971a80830e6ff873c0c9cbaac309e0dcd5a0c66
link
true
/test integ-security-istiodremote_istio

integ-security_istio
2971a80830e6ff873c0c9cbaac309e0dcd5a0c66
link
true
/test integ-security_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
2971a80830e6ff873c0c9cbaac309e0dcd5a0c66
link
true
/test lint_istio

integ-security-istiodremote_istio
2971a80830e6ff873c0c9cbaac309e0dcd5a0c66
link
true
/test integ-security-istiodremote_istio

integ-security_istio
2971a80830e6ff873c0c9cbaac309e0dcd5a0c66
link
true
/test integ-security_istio

integ-security-multicluster_istio
2971a80830e6ff873c0c9cbaac309e0dcd5a0c66
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
de7f2e52145719a009bb1000186a4cfb6e344533
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn ready for review, ptal

/test all

cc @labaq @diranged

In response to a cherrypick label: new pull request created: #40418

IIUC this only triggers a xDS push to the changed proxy. Shouldn't we also update endpoints labels and push EDS to all proxies?

We intended to do xds update to the changed proxy, in case it uses locality routing.

Shouldn't we also update endpoints labels and push EDS to all proxies?

it will be a great cost, and remeber we intended not to support it


fix/evm-tokens-remove-nil-address

Following the same rules of IOS we should not add nil addresses from 1Inch.
Swift
 private var nullAddress: String {
        return "0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee"
    }

    let nonZeroBalanceTokenAddresses = balanceDictionary.compactMap { tokenAddress, balance in
            (Int64(balance) ?? 0) > 0 && tokenAddress != nullAddress ? tokenAddress : nil
        }

Issue
https://github.com/vultisig/vultisig-windows/issues/242

Tests


Custom frequencies

Like custom unisons (#86). The non-jummbox frequency presets should be removed entirely.

Likely to be ported from Dogebox2; saw that Doge was doing pretty good on this, possibly also supporting negative values and HzOffsets.


Can't type in text field in customization in a folder properties

Description
I was going to change the icon of a folder but it wouldn't let type inn the text field it would only let me select icons from shell32.dll.
There is a workaround tho, by clicking the "Browse" button i can select my icon file but faster for me to just type it out :(
Steps To Reproduce

Right click a folder and select properties.
Go to customization menu.
Try to type into the text field and it wouldn't work :(

Requirements
It wouldn't let me type in the text field in the customization menu in a folder properties
Files Version
<IP_ADDRESS>
Windows Version
22631.3958
Log File
debug.log

@Steperman5692 thank you for reaching out, the path box is read only by design and the correct workflow is to click browse. Can you confirm if the browse popup works properly?

Yeah its works fine but it would be nice if we can type the the text field :(

Well, we can make it acceptable, while we need error handling for path validation.

wdym by that?

It was to @yaira2
I'm not sure we'll plan to prioritize but this is pretty easy work.

that would be pretty nice :D

Yeah its works perfectly fine but it would be nice if we can type the the text field :(

We prefer using the dialog as it has validation and error handling built in.

You can also type the path/filename in the path box of the dialog

it's just nicer it we can type in it :(

I get your feedback, I haven't made a final decision so it's still under consideration.

Support will be added in the next update.

Thank you all so much for adding this feature :)

Enjoy!


More customization of runtime image

I'd like to be able to customize the runtime image further. Would you be interested in accepting a PR that modifies the Dockerfile-release.eex file like so (with appropriate changes to the generator app)?
################################################################################
## 2. Application runtime image
## From the OS base image, installs the release built above, and sets the
## entrypoint. This is the final image executed by Google App Engine.

FROM <%= @os_image %>

+  ## If your application needs additional steps when constructing the runtime image,
+  ## use the `runtime_image_directives` option to specify them
+  <%= for directive <- @runtime_image_directives do %>
+  <%= directive %>
+  <% end %>
-  ...

## Copy built release from build stage into /app
COPY --from=app-build /app/_build/<%= @mix_env %>/rel/<%= @release_app %> /app/

## Command to start the release.
CMD <%= @entrypoint %>

This seems risky. It's very powerful, and there's a lot of opportunity for mistakes to be made. Additionally, it opens the door for future incompatibilities; if an app has inserted custom directives that conflict with future changes made to the normal Dockerfile template.
If you really need to customize the Dockerfile this closely, I would recommend simply writing your own Dockerfile, and using runtime: custom. (See documentation.)


Describe additional tax functions

This PR addresses Issue #616 by describing the three alternative tax functions users can select:

DEP_totalinc
Gouveia and Strauss (1994) functional form.
Linear tax functions

In addition, the age_specific and analytical_mtr options are noted.

I am having some trouble with enumerated lists that have items inserted between the enumerated points:

Suggestions to fix this behavior?

Codecov Report

Merging #681 (202adcc) into master (365e4e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #681   +/-   ##
=======================================
  Coverage   82.52%   82.52%
=======================================
  Files          48       48
  Lines        7634     7634
=======================================
  Hits         6300     6300
  Misses       1334     1334

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbcbcff...022737a. Read the comment docs.

Fixed list issue:

@jdebacker Was the solution to the math equation in the middle of the numbered list simply just indentation?
Let me know when you've added everything you want to add to this documentation PR.

Was the solution to the math equation in the middle of the numbered list simply just indentation?

Yes.  Jupyter Book seems to be really finicky in this way!
This is ready for your review and merging when you deem ready @rickecon.  Thanks!

@jdebacker . It looks like something in test_utils.py's test_fetch_files_from_web() test is failing.

I restarted the tests and am looking into the failure.

@jdebacker. It failed in the same place upon rerunning the Build and test CI tests.

@jdebacker. I am merging this now, as it has passed all its tests. I ran the "Build and Test" CI twice and it failed both times. Any idea how it passed this time?
Merging.

From today's chat, below are the specs on GitHub Actions; I couldn't find them for Travis.

Each virtual machine has the same hardware resources available.

2-core CPU
7 GB of RAM memory
14 GB of SSD disk space


feat: add new options to quit command for flexible cwd-file setting

Close #243

Thanks for your PR; I made some reviews.

I made some simplifications, and merged it now!


Add support for Tomcat

Starting an embedded Tomcat looks pretty easy too: https://devcenter.heroku.com/articles/create-a-java-web-application-using-embedded-tomcat
Perhaps I could add a way for the user to choose between Jetty and Tomcat.

This is a working example: https://vaadin.com/forum/t/vaadin-10-tomcat-embedded/157777
Lots of shortcomings:

No auto-detection of servlets defined in the project itself - this becomes a problem when there's an additional servlet such as javalin
No way to add static files as classpath resources? This could be a blocker, but we could extract the jar file to a directory?

Otherwise it seems to be working.
Things to test:

production mode - launching from a zip file
adding javalin rest servlet
static resources being served
push & websockets

Push works. Only the following dependencies are necessary:
        <dependency>
            <groupId>org.apache.tomcat.embed</groupId>
            <artifactId>tomcat-embed-core</artifactId>
            <version>10.1.28</version>
        </dependency>
        <dependency>
            <groupId>org.apache.tomcat.embed</groupId>
            <artifactId>tomcat-embed-websocket</artifactId>
            <version>10.1.28</version>
        </dependency>

The app prints this to stderr but otherwise works:
SEVERE: Servlet [jsp] in web application [] threw load() exception
java.lang.ClassNotFoundException: org.apache.jasper.servlet.JspServlet
	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1332)
	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1144)
	at org.apache.catalina.core.DefaultInstanceManager.loadClass(DefaultInstanceManager.java:491)
	at org.apache.catalina.core.DefaultInstanceManager.loadClassMaybePrivileged(DefaultInstanceManager.java:473)
	at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultInstanceManager.java:143)
	at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:758)
	at org.apache.catalina.core.StandardWrapper.load(StandardWrapper.java:698)
	at org.apache.catalina.core.StandardContext.loadOnStartup(StandardContext.java:4172)
	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4458)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:164)
	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1203)
	at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1193)
	at java.base/java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:317)

We can either manually remove the JSP servlet somehow (since it's unnecessary), or just add necessary jar to the classpath ( both options are acceptable).,

Adding servlet such as
@WebServlet(urlPatterns = {"/*"})
public class MyServlet extends VaadinServlet {
}

removes the need for having to register the servlet manually:
        tomcat.addServlet("", "", VaadinServlet.class.getName());
        ctx.addServletMappingDecoded("/*", "");

The ClassNotFoundException: org.apache.jasper.servlet.JspServlet issue can be fixed by adding org.apache.tomcat.embed:tomcat-embed-jasper to the classpath. It transitively pulls in org.eclipse.jdt:ecj which is a whopping 3mb jar, but we can exclude it without affecting Vaadin. We can also exclude transitively pulled org.apache.tomcat.embed:tomcat-embed-el leaving only the org.apache.tomcat.embed:tomcat-embed-jasper jar on the classpath, which is a 700kb JAR which is acceptable.

Sounds like tomcat only performs servlet scanning of classes located in the /WEB-INF/classes of the WAR file virtually created for embedded tomcat. That means that:

During development mode you need to map target/classes there (or other folder for Gradle)
During production, you need to map the contents of the app jar there

The code is something like:
        File additionWebInfClasses = new File("target/classes").getAbsoluteFile();
        if (additionWebInfClasses.exists()) {
            WebResourceRoot resources = new StandardRoot(ctx);
            resources.addPreResources(new DirResourceSet(resources, "/WEB-INF/classes",
                    additionWebInfClasses.getAbsolutePath(), "/"));
            ctx.setResources(resources);
        }
        File productionJar = new File("libs/vaadin-boot-example-maven-1.0-SNAPSHOT.jar").getAbsoluteFile();
        if (productionJar.exists()) {
            System.out.println("PRODUCTION!!!!! " +productionJar);
            WebResourceRoot resources = new StandardRoot(ctx);
            resources.addPreResources(new JarResourceSet(resources, "/WEB-INF/classes",
                    productionJar.getAbsolutePath(), "/"));
            ctx.setResources(resources);
        }

Yup: manually registering the Vaadin servlet is easier than adding classes to virtual WAR; this code works both in dev mode and in production:
        tomcat.addServlet("", "", VaadinServlet.class.getName());
        ctx.addServletMappingDecoded("/*", "");

Adding back.
What's strange is that Tomcat is apparently capable of discovering Vaadin's LookupServletContainerInitializer class even though it's not in the virtual WAR class loader... strange.

Uh-oh - we might need to enable the classpath scanning after all, otherwise @WebListener classes are ignored.

Initial implementation is ready.

push & websockets is verified to be working
The servlet auto-detection is working: the launcher adds either target/classes (or build/classes) to WAR, or the final production app jar. In order to identify which jar file is the main app jar, you need to provide a regex matching the jar file name.
The static resources are served either from src/dist/webapp (when in dev mode), or from ../webapp (when in production mode). This follows the structure of how Gradle application plugin packages the app (the contents of src/dist go to the resulting zip file as-is), and we may need to change it for Maven projects, but that remains to be seen - this will depend on how Maven AppPlugin packages the app.
Javalin servlet - remains to be tested.

This means that the app structure is a bit different from when using the Jetty launcher: Jetty launcher expects webapp on classpath, in the /webapp class folder; while Tomcat launcher expects the resources in /src/dist/webapp.
An alternative would be to continue using the webapp-in-resources approach identical to Jetty, and then unpack the webapp folder to a temp folder when running in production mode (since Tomcat can't serve static resources from a jar file... or can it? Maybe we can populate the virtual WAR file by the jar file contents - explore).

Support for Tomcat will be added in Vaadin-Boot 13.0


Fair reusing of wasm runtime instances

Closes #2051
Closes #2967
Supersedes #2938
Background
In #1345 an optimization for wasm runtime instantiation was implemented. The idea was that we would track the areas using some heuristic (used_size and lowest_used) that were used in the course of runtime execution and then zero them. However, it turned out that:

It assumed that the area where rustc usually puts the data section (i.e. static data, globals, etc) doesn't change. Introduction of mutable static variables in the runtime violated this assumption and ultimately caused #2051.
Upon a closer inspection of the heuristic, it cleared only the stack leaving the heap untouched. This can potentially (however, unlikely) cause undefined behavior because a compiler can assume and take advantage of the fact that WebAssembly guarantees the memory to be zeroed.

There were a couple attempts to fix it:

Initially, we thought that full instantiation in the background will do and tried to implement this approach in #2931, but it turned out that this would make us use Arc instead of Rc in wasmi which would considerably harm the execution performance.
Then we assumed that maybe the initial assumption that @arkpar is not correct and instantiation doesn't take a lot of time. So we came up with #2938. Initial bencmark results showed potential in this approach, however, it turned out that the algorithm was flawed since it copied only up to used_size (the highest accessed memory location within the execution) and @arkpar was indeed right: there is a lot of unnecessary work being done. The current node-runtime allocates 1MB of stack space, has data section and on top of that we preallocate a lot of memory upfront, and copying and/or zeroing it takes a lot of time. The execution time on generating 1500 blocks almost doubled.

It turned out that it was hard to fix this issue with the given constraints (e.g. preserving determinism, allowing of execution of general wasm modules, etc) without regressing the performance.
One option was to actually ban mutable static variables in the runtime. However, IMO, I think it is hard to ensure that we don't accidentally bring some sort of mutable static globals into the runtime and also it seems that they can be indeed useful.
Solution
Because of the above I decided to take the following approach along with the following tradeoffs:

Implement the mmap backend for linear memory in wasmi https://github.com/paritytech/wasmi/pull/190 and introduce a function for quickly zeroing the memory instance. This allowed us to allocate arbitrary amounts of memory which is zeroed lazily on the first access. erase function allows to basically reallocate. The downside is that mmap is inherently platform dependent and works only on unix systems. E.g. Windows will suffer noticable slowdowns. I also tried to leverage the GlobalAlloc::alloc_zeroed function, but it turns out that it falls back to bzero (analogue of memset specialized for 0) on macOS which gives noticeble slowdowns (approx. 40 secs vs 230 secs for transaction factory of master on MasterTo1 with 1500 blocks). However,  we can do the similar trick on Windows since it has the similar APIs.
Extract the data segments (chunks of memory that are copied to the linear memory at the instantiation time) from the wasm module and cache them. At the time when the new wasm runtime instance is requested, the linear memory is zeroed and then the data segments are copied.
Scan the mutable global variables and restore their values when the new wasm runtime instance is requested. This solves the https://github.com/paritytech/substrate/issues/2967.
Ban the start function in wasm runtime modules. start function is run as the last step of instantiation and theoretically can do arbitrary changes to the wasm memory. This is OK for rustc produced binaries since they don't actually leverage the start function and IMO it is unlikely that it will use them. However, it might pose a problem for languages such as C++ which can have "pre-main" logic such as constructor initialization used in globals. This is not a fundamential problem since we can still run the start function and scan the memory for chunks of memory instead of relying on the static data segments. So this restriction can be lifted in the follow-up PRs.
Require the __heap_base global variable. It turned out that the allocator also depended on the used_size to detect the starting position of the heap which can be problematic. Luckily for us, wasm-ld (LLD) has a convention to expose the __heap_base in the produced binaries which points to the one byte past from the data section which we can use to seed the allocator. This solves potential problems that the used_size heuristic can miss, like BSS. I am not sure how this restriction can be lifted in the future though.

The initial benchmarks shows that there is no noticeble regression introduced in this PR compared to the heuristic approach we were using. Although unexpectedly now substrate performs a little bit better on macOS than on Linux.
I hope that these tradeoffs are reasonable.
cc @arkpar @gavofyork @cmichi
TODO:

[ ] test the performance on block import (was blocked #2977)
[x] deal with the broken libc dependency (see the CI failure)

What do we need to do as we add more execution environments in the future, the most relevant of course being lightbeam. Lets say we integrate lightbeam and start compiling the wasm to native. Can we make the above changes to execution environment in a reasonable way for any other compiler in the future?

A more general note, I would really like to see the cache being passed in instead of being a thread_local!, but that probably requires greater refactoring...

@folsen
Yeah, I was trying to keep that in mind.
You might have noticed that I added parity-wasm as a dependency even though at the moment wasmi is built on top of parity-wasm but just tries to not expose it. At the cost of additional deserialization on the cold path we can get away without dependning on the execution engine providing the data segments.
If we were to integrate wasmtime (and by extension lightbeam) we would need to do similar changes. wasmtime already uses mmap-s for implementation of their linear memories. Globals seem to be a little bit more involved, but I think it would be possible to implement them in the engines as well.
@bkchr Yes! While working I noticed that the executor crate (and also state-machine) need some love. I was trying to hold myself from refactorings because I assumed that we need to land this PR quick and without big refactorings due to the upcoming audit and upcoming releases.

As I need to have extendable externalities for Cumulus, this will probably be my job to refactor this stuff :sweat_smile:

Setup
The tests are conducted in transaction-factory.
In order to benchmark, I had to apply patches that looks like this:
diff --git a/core/executor/src/native_executor.rs b/core/executor/src/native_executor.rs
index 506cd46af..5a5ddebda 100644
--- a/core/executor/src/native_executor.rs
+++ b/core/executor/src/native_executor.rs
@@ -142,6 +142,10 @@ impl<D: NativeExecutionDispatch> CodeExecutor<Blake2Hasher> for NativeExecutor<D
                                Ok((module, onchain_version)) => (module, onchain_version),
                                Err(e) => return (Err(e), false),
                        };
+
+                       // TODO:
+                       let use_native = false;
+
                        match (
                                use_native,
                                onchain_version
diff --git a/node/cli/src/factory_impl.rs b/node/cli/src/factory_impl.rs
index 0d9461036..81998b219 100644
--- a/node/cli/src/factory_impl.rs
+++ b/node/cli/src/factory_impl.rs
@@ -157,7 +157,7 @@ impl RuntimeAdapter for FactoryState<Number> {

        fn minimum_balance() -> Self::Number {
                // TODO get correct amount via api. See #2587.
-               1337
+               500
        }

        fn master_account_id() -> Self::AccountId {

use_native = false makes the native-executor to use the wasm fallback unconditionally. minimum_balance change is needed for not running out of funds while execution transaction-factory.
Here is the script that I used for getting the master build and the build that comes from this PR:
#!/bin/bash

set -eux pipefail

export CARGO_INCREMENTAL=0
export RUSTFLAGS="-Ccodegen-units=1"

cd substrate
git reset --hard 42f564a6772cb3493342f3ae5fe722b44aa9c44c
git apply ../fixes-master.patch
cargo build --release
cp target/release/substrate ../substrate-master
cd ..

cd substrate-2
git reset --hard d053556bde319156a8a13b79988e79547e3b4223
git apply ../fixes.patch
cargo build --release
cp target/release/substrate ../substrate-cached

and here is how I run it:
#!/bin/bash

./substrate-master purge-chain -y --dev && time ./substrate-master factory --dev --mode MasterTo1 --num 1500 >& master.log
./substrate-cached purge-chain -y --dev && time ./substrate-cached factory --dev --mode MasterTo1 --num 1500 >& cached.log

Results

real
sys

master
51.954s
0.164s

cached (this PR)
53.994s
0.983s

The increase in sys time is expected since now the OS clears pages (virtual memory pages, i.e. 4Kb, not wasm linear memory pages, i.e. 64Kb) lazily on the first access to them.

So... overall this is a minor pessimisation? Remind me of the advantage to doing this? :)

You might observe an improvement when swapping the wasm instance batch and forth between large and small runtimes, no?

Closes #2051
Closes #2967
Supersedes #2938
Background
In #1345 an optimization for wasm runtime instantiation was implemented. The idea was that we would track the areas using some heuristic (used_size and lowest_used) that were used in the course of runtime execution and then zero them. However, it turned out that:

It assumed that the area where rustc usually puts the data section (i.e. static data, globals, etc) doesn't change. Introduction of mutable static variables in the runtime violated this assumption and ultimately caused #2051.
Upon a closer inspection of the heuristic, it cleared only the stack leaving the heap untouched. This can potentially (however, unlikely) cause undefined behavior because a compiler can assume and take advantage of the fact that WebAssembly guarantees the memory to be zeroed.

There were a couple attempts to fix it:

Initially, we thought that full instantiation in the background will do and tried to implement this approach in #2931, but it turned out that this would make us use Arc instead of Rc in wasmi which would considerably harm the execution performance.
Then we assumed that maybe the initial assumption that @arkpar is not correct and instantiation doesn't take a lot of time. So we came up with #2938. Initial bencmark results showed potential in this approach, however, it turned out that the algorithm was flawed since it copied only up to used_size (the highest accessed memory location within the execution) and @arkpar was indeed right: there is a lot of unnecessary work being done. The current node-runtime allocates 1MB of stack space, has data section and on top of that we preallocate a lot of memory upfront, and copying and/or zeroing it takes a lot of time. The execution time on generating 1500 blocks almost doubled.

It turned out that it was hard to fix this issue with the given constraints (e.g. preserving determinism, allowing of execution of general wasm modules, etc) without regressing the performance.
One option was to actually ban mutable static variables in the runtime. However, IMO, I think it is hard to ensure that we don't accidentally bring some sort of mutable static globals into the runtime and also it seems that they can be indeed useful.

One solution would be to use mprotect to make these pages read-only.  If the wasm program tries to write to them, an exception (SIGSEGV or STATUS_ACCESS_VIOLATION) will occur, which we can catch.

Solution
Because of the above I decided to take the following approach along with the following tradeoffs:

Implement the mmap backend for linear memory in wasmi paritytech/wasmi#190 and introduce a function for quickly zeroing the memory instance. This allowed us to allocate arbitrary amounts of memory which is zeroed lazily on the first access. erase function allows to basically reallocate. The downside is that mmap is inherently platform dependent and works only on unix systems. E.g. Windows will suffer noticable slowdowns. I also tried to leverage the GlobalAlloc::alloc_zeroed function, but it turns out that it falls back to bzero (analogue of memset specialized for 0) on macOS which gives noticeble slowdowns (approx. 40 secs vs 230 secs for transaction factory of master on MasterTo1 with 1500 blocks). However,  we can do the similar trick on Windows since it has the similar APIs.
Extract the data segments (chunks of memory that are copied to the linear memory at the instantiation time) from the wasm module and cache them. At the time when the new wasm runtime instance is requested, the linear memory is zeroed and then the data segments are copied.

Do we need to zero all of linear memory?  The kernel certainly knows which pages it had to fault in, and there might be a (non-portable) way to get that information from userspace.  There certainly is on Linux (userfaultfd).

@gavofyork

So... overall this is a minor pessimisation? Remind me of the advantage to doing this? :)

Yep, that's right.
Right now we are reusing a wasm instance for multiple calls into the runtime and doing a bare minimum amount of work to restore the wasm. Specifically, looking at the code, we are clearing the area that starts at the lowest accessed address after the execution and ends at the lowest accessed address before of the execution. This works well for clearing the stack space area for code that was linked LLD with the -z stack-first option which is used by the current versions of rustc. Because of the amount of work done it has such great performance which was hard to even get close to.
Unfortunately, this does not return the wasm linear memory to the initial state:

Contents of the data section in the linear memory are changed and not restored. For instance, the second invocation of the runtime can observe changes to mutable global variables made from the first one. This actually caused #2022 / #2051 and can cause problems similar to #2967 for compilers that put the stack pointer into the linear memory .
The heuristic relies on the fact that memory is written to and has some assumptions about it. For example, if a wasm runtime puts the stack not at the start of linear memory then the runtime will break.
We actually don't restore the contents of the heap at all.
Things like .bss sections might just break.
memory corruptions from RPC calls can have effect on other because we share the single runtime

TL;DR:
The current solution seems to work (modulo #2051) for the current toolchain. However, it is hard to predict if it will work in the future for rustc+LLD and especially for other toolchains. It is also not clear if
we are actually missing something again. The current solution leaves non-deterministic memory contents which can potentially lead to consensus issues. This solution also wasmi specific and would require some support on implementation of these features in the other engines we might want to use and most importantly it will impose additional rather high overhead (basically every store should be accompanied with checking minimum and and maximum address accessed).
On the other hand, the solution proposed in the current PR doesn't employ any heuristics and ensure that the wasm instance is returned to the initial state without cutting any corners and with IMO not essential tradeoffs. This solution also is similar what would do other wasm engines and would not require substantial modifications to them (if any at all).
@DemiMarie-parity

One solution would be to use mprotect to make these pages read-only. If the wasm program tries to write to them, an exception (SIGSEGV or STATUS_ACCESS_VIOLATION) will occur, which we can catch.

These pages are actually not read-only and can be mutated in normal circumstances, see #2051. Even if we agreed that we do not want to support modules that modify the data section (which IMO would be restrictive, e.g. because as I mentioned there at least might be compilers which put e.g. a stack pointer there, nevermind that there might be other reasons to use it), we would need to also require some ways to indicate the data section (this is rather a vague concept from the standpoint of a wasm binary. A wasm compiler can layout the memory in whatever way it deems necessary.). Moreover there are no guarantees that these sections will be placed at the page boundary, which means either dynamic checking of boundaries or imposing additional non-trivial restrictions on wasm modules.
TBH this sounds as no-go to me.

Do we need to zero all of linear memory? The kernel certainly knows which pages it had to fault in, and there might be a (non-portable) way to get that information from userspace. There certainly is on Linux (userfaultfd).

Yes, we do. I am not sure why would we need that if mmap allocates virtual pages already and zeroes them on the first access. I am not sure what advantage of doing this in the userspace would give us.
Also, as another point, I am not sure if such deep changes are worth it at the moment. When I spoke with @folsen we agreed that we don't want to do any sophisticated changes. Also IMO it is not worth further optimizing wasmi and going far beyond relatively simple mmap/VirtualAlloc approach and especially modifying rustc/LLVM/LLD for adding support for wasm modules that obey to restrictions (like aligning stack to virtual page (non wasm linear memory page) boundary).

Merging this since 20-25 us slowdown is tolerable.


Uncaught ReferenceError: Template is not defined

I'm having some trouble. The package seems to not have access to meteor's Template?
blaze-react-component-client.js:12     Uncaught ReferenceError: Template is not defined

Thanks for the report!  Can you confirm if the just-published v1.1.2 fixes the issue for you?

Hey sorry I forgot to update! I had static-html package when I needed the blaze templating package.
Now it works like a charm. Sorry for the false alarm.

Ah ok thanks for reporting back.  I think I should add this to the docs and even have the package warn if it detects this case.

It can't hurt to add if you have the time.

Done in v1.2.0 (https://github.com/gadicc/meteor-blaze-react-component/tree/1a4768de7f00c536007f7c085bb53872396dbf2d), which now also allows passing templates directly without using the Template global.  Thanks for the update.


Fix python 3.10.1 bug

Proposed solution to #71 that takes care of the signature change in dataclasses._field_init.

The internals of dataclasses are an unknown field to me. Things breaking when Python changes their internal implementation does indicate that our implementation may be fragile. However, I think this needs to be merged coz otherwise we can't use orsopy on 3.10.
@bmaranville, do you have an idea for a re-implementation?

There was a reason why we needed to reimplement those private methods, can anyone remember what it was?

@aglavic, could you do another alpha release of orsopy so the version on PyPI works on 3.10?

I think the group voted and it was agreed we would allow users to add extra attributes to header classes that are not in the schema (but will still be serialized and deserialized).  Dataclasses do not support this out of the box, and so we are extending/overriding the native dataclasses functions.

@aglavic, could you do another alpha release of orsopy so the version on PyPI works on 3.10?

I've created PR #75 for the release, as we discussed in the last meeting. As we are still in Alpha I directly merged that PR and created the version tag to release on PyPI. You should be able to update.


[Event Request] CU90 "Purch.-Post" - procedure CopyAndCheckItemChargeTempPurchLine()

local procedure CopyAndCheckItemChargeTempPurchLine()
var
begin
----------------------- ADD PARAMETER ----------------------
IsHandled := false;
OnBeforeCopyAndCheckItemChargeTempPurchLine(PurchHeader, TempPurchLine, TempItemChargeAssgntPurch, IsHandled, AssignError);
        if IsHandled then
            exit;

----------------------------------------------------------

....................
[IntegrationEvent(false, false)]
    local procedure OnBeforeCopyAndCheckItemChargeTempPurchLine(PurchaseHeader: Record "Purchase Header"; var TempPrepmtPurchaseLine: Record "Purchase Line" temporary; var TempItemChargeAssgntPurch: Record "Item Charge Assignment (Purch)" temporary; var IsHandled: Boolean; var AssignError: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Unable to use single quotes within double quotes - need to review

ERROR - [LINE 1] inconsistent quotes in "John's Bag"
I would expect to be able to use single quotes within double quotes, but it errors out.
This is related/duplicate of #259 , but i think it's a significant shortcoming. Having to assign any text with quotes to a variable before echo is cumbersome and it's a gotcha for new users.
To see if there is a way to parse this properly in tagui
// to_replicate.tagui

echo "John's Bag"

The fix for this is easy, and it's by design not a bug. In both tagui_parse.php and tagui_header.js there is a function add_concat(). That functions converts 'a' b 'c' in TagUI into 'a' + b + 'c' in JavaScript language for concatenation. You can look at the functions and without enforcing the quotes used in the string, there isn't a deterministic way to detect what user means in that string.
Original rationale was not to force users to use + + + to concatenate strings and variables, because that would be too programming-language-like vs human-language-like.

Without enforcing the quotes used in the string, there isn't a deterministic way to detect what user mean in that string.

I'm not sure if you're misunderstanding the complaint here. Users can't ever use single quotes in their strings when echoing (and dumping/writing).

They can, just that they have to choose to use single quotes throughout and use the escape character like below -
echo '123\'456'

Or if want to use double quotes then use double quotes throughout -
echo "123\"456

Having a mix of both double and single quotes will make the add_concat() function unable to parse the string deterministically in the examples in my previous comment.

echo 'John's Bag'

fails for me with SyntaxError: Expected token ')'

echo 'John\'s Bag'

echoes John's+Bag for me. So it also doesn't work somehow.

Having a mix of both double and single quotes will make the add_concat() function unable to parse the string deterministically in the examples in my previous comment.
I believe the first instance of ' or " indicates which is being used as the surrounding quotes.

By the time the string gets passed into the function add_concat(), the info that remains will be without the opening and closing quotes, so that info is no longer available to be used to decide which is the quotes used to denote the string.
Yes this is a bug, echo 'John\'s Bag' fails and echo 'John\'sBag' works. Looks like the function does not recognise the escaped ' and instead treat it like a delimiter, thus converts space to +.

Ok will look through the relevant function and this bug.

Sure! We'll can discuss more when we next meet.

Besides fixing the bug, we could explore if there is a way to achieve the goal of the function while not restricting the use of 2 types of quotation marks. I didn't figure out a solution then, but now with 2 minds we might be able to introduce a good solution.

Let me look into this. First on the bug with `echo 'John's Bag' and second on whether there is a viable implementation for using both type of quotation marks without parsing incorrectly.

removing discussion label as this is a bug, and will review if there is a way to allow both quotes

tagui_parse.php fix to output echo 'John\'s Bag' correctly. It works by introducing a new variable $previous_char to track what is the previous character. When the detected quote type is encountered and the previous character is the backslash, it will ignore the quotation mark and recognise that it is still within the string -
function add_concat($source_string) { // parse string and add missing + concatenator
if ((strpos($source_string,"'")!==false) and (strpos($source_string,"\"")!==false))
{echo "ERROR - " . current_line() . " inconsistent quotes in " . $source_string . "\n";}
else if (strpos($source_string,"'")!==false) $quote_type = "'"; // derive quote type used
else if (strpos($source_string,"\"")!==false) $quote_type = "\""; else $quote_type = "none";
$within_quote = false; $source_string = trim($source_string); // trim for future proof
$previous_char = ""; // to help detect backslash escape for quotes
for ($srcpos=0; $srcpos<strlen($source_string); $srcpos++) {
if (($source_string[$srcpos] == $quote_type) and ($previous_char != "\\")) $within_quote = !$within_quote;
$previous_char = $source_string[$srcpos]; // to detect a previous backlash escape and ignore quote
if (($within_quote == false) and ($source_string[$srcpos]==" ")) $source_string[$srcpos] = "+";}
$source_string = str_replace("+++++","+",$source_string); $source_string = str_replace("++++","+",$source_string);
$source_string = str_replace("+++","+",$source_string); $source_string = str_replace("++","+",$source_string);
return $source_string;} // replacing multiple variations of + to handle user typos of double spaces etc

js version for add_concat in tagui_header.js -
function add_concat(source_string) { // parse string and add missing + concatenator
if ((source_string.indexOf("'") > -1) && (source_string.indexOf('"') > -1))
return "'ERROR - inconsistent quotes in text'";
else if (source_string.indexOf("'") > -1) var quote_type = "'"; // derive quote type used
else if (source_string.indexOf('"') > -1) var quote_type = '"'; else var quote_type = "none";
var within_quote = false; source_string = source_string.trim(); // trim for future proof
var previous_char = ""; // to help detect backslash escape for quotes
for (srcpos = 0; srcpos < source_string.length; srcpos++) {
if ((source_string.charAt(srcpos) == quote_type) && (previous_char !== "\\")) within_quote = !(within_quote);
previous_char = source_string.charAt(srcpos); // to detect a previous backlash escape and ignore quote
if ((within_quote == false) && (source_string.charAt(srcpos)==" "))
source_string = source_string.substring(0,srcpos) + "+" + source_string.substring(srcpos+1);}
source_string = source_string.replace(/\+\+\+\+\+/g,'+'); source_string = source_string.replace(/\+\+\+\+/g,'+');
source_string = source_string.replace(/\+\+\+/g,'+'); source_string = source_string.replace(/\+\+/g,'+');
return source_string;} // replacing multiple variations of + to handle user typos of double spaces etc

Found solution to allow using both quotes, and your train of thought is correct, the first quotation mark encountered should be safely assumed to be the quotation mark chosen by user as the string enclosure quote. Fair expectation to have from user.
Below is the updated add_concat() for tagui_parse.php that works for the following script. I have to use 4 if else statement to do the check because comparing this condition (strpos($source_string,"'") < strpos($source_string,"\"")) directly will lead to error when one of them is missing it will be comparing an integer to a false boolean and lead to wrong result.
a = 'abc'
echo a
echo '1 2'
echo "1 2"
echo a " 1 ' \' \" 2 " a
echo a ' 1 " \" \' 2 ' a
echo 'a' "b" 'c' "d"

START - automation started - Sat Dec 28 2019 19:05:29 GMT+0800 (+08)

abc
1 2
1 2
abc 1 ' ' " 2 abc
abc 1 " " ' 2 abc
abcd

FINISH - automation finished - 0.2s

function add_concat($source_string) { // parse string and add missing + concatenator
if ((strpos($source_string,"'") === false) and (strpos($source_string,"\"") === false)) $quote_type = "none";
else if ((strpos($source_string,"'") !== false) and (strpos($source_string,"\"") === false)) $quote_type = "'";
else if ((strpos($source_string,"'") === false) and (strpos($source_string,"\"") !== false)) $quote_type = "\"";
else if (strpos($source_string,"'") < strpos($source_string,"\"")) $quote_type = "'"; else $quote_type = "\"";
$within_quote = false; $source_string = trim($source_string); // trim for future proof
$previous_char = ""; // to help detect backslash escape for quotes
for ($srcpos=0; $srcpos<strlen($source_string); $srcpos++) {
if (($source_string[$srcpos] == $quote_type) and ($previous_char != "\\")) $within_quote = !$within_quote;
$previous_char = $source_string[$srcpos]; // to detect a previous backlash escape and ignore quote
if (($within_quote == false) and ($source_string[$srcpos] == " ")) $source_string[$srcpos] = "+";}
$source_string = str_replace("+++++","+",$source_string); $source_string = str_replace("++++","+",$source_string);
$source_string = str_replace("+++","+",$source_string); $source_string = str_replace("++","+",$source_string);
return $source_string;} // replacing multiple variations of + to handle user typos of double spaces etc

add the matching add_concat() for tagui_header.js which also works for above tests.
function add_concat(source_string) { // parse string and add missing + concatenator
if ((source_string.indexOf("'") == -1) && (source_string.indexOf('"') == -1)) var quote_type = "none";
else if ((source_string.indexOf("'") > -1) && (source_string.indexOf('"') == -1)) var quote_type = "'";
else if ((source_string.indexOf("'") == -1) && (source_string.indexOf('"') > -1)) var quote_type = '"';
else if (source_string.indexOf("'") < source_string.indexOf('"')) var quote_type = "'"; else var quote_type = '"';
var within_quote = false; source_string = source_string.trim(); // trim for future proof
var previous_char = ""; // to help detect backslash escape for quotes
for (srcpos = 0; srcpos < source_string.length; srcpos++) {
if ((source_string.charAt(srcpos) == quote_type) && (previous_char !== "\\")) within_quote = !(within_quote);
previous_char = source_string.charAt(srcpos); // to detect a previous backlash escape and ignore quote
if ((within_quote == false) && (source_string.charAt(srcpos) == " "))
source_string = source_string.substring(0,srcpos) + "+" + source_string.substring(srcpos+1);}
source_string = source_string.replace(/\+\+\+\+\+/g,'+'); source_string = source_string.replace(/\+\+\+\+/g,'+');
source_string = source_string.replace(/\+\+\+/g,'+'); source_string = source_string.replace(/\+\+/g,'+');
return source_string;} // replacing multiple variations of + to handle user typos of double spaces etc

You can do some sanity checks and further tests to make sure this change doesn't break something or miss some use scenarios. After that you can merge as part of v6. Unassigning myself for now since no further work to be done from my side for now.

Updating title, this issue is both a bug in existing implementation and a change from the existing design to support both types of quotation marks in steps like echo, dump, write, check..

raised PR to merge into dev, unassigning myself

fixed in #674 for v6 release


Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Coverage remained the same at 67.045% when pulling 7bbd7443146d03cb1819e2bbf576c4f448671b7b on analysis-8nKj7w into 8378d207e724a9756c83504b78e8ca72b5ffad2b on master.


wrong mapping rule in API created by aggregated-pipeline

I've run aggregated-pipeline and there is new API managed by 3scale. It has mapping rule /cicd/maingateway/profile/{id}$ which is wrong because there is endpoint defined in Fuse as cicd/users/profile/{id}.
It can be solved by one of these options:

define same mapping rule in Fuse and API managed by 3scale
setup URL rewriting policy to rewrite url before applying mapping rules

I've run aggregated-pipeline and there is new API managed by 3scale. It has mapping rule /cicd/maingateway/profile/{id}$ which is wrong because there is endpoint defined in Fuse as cicd/users/profile/{id}.
It can be solved by one of these options:

define same mapping rule in Fuse and API managed by 3scale
setup URL rewriting policy to rewrite url before applying mapping rules

The mapping rule /cicd/maingateway/profile/{id}$ is correct- it uses maingateway service url endpoint
There are three fuse services deployed by Jenkins pipeline
1- user service, 2- alert service, 3- maingateway service
The main gateway service integrates, the service 1&2.
The complete URL to hit maingateway service is -
http://maingatewayservice-route/profile/11111?alertType=ACCIDENT

yes you're right, I'll close this issue.


[Volunteer] When a plugin changes, it should be initialized

Volunteer help
When plugin parameters change, the common logic should be initialized and should not be computed each time a request is processed.
e.g. When using LoadBalance, Divide、Dubbo、Http plugin needs to calculate the weight for each request. To calculate the weight, you should only need to calculate it once when the configuration changes.
I don't know much about Shenyu yet, and I don't know if there is similar situation in other places. If this optimization is necessary and there are others that need to be optimized, please supplement, I can finish it together.
My thoughts are as follows:
In CommonPluginDataSubscriber#onSelectorSubscribe, sending the update or delete events, performs initialization logic in the corresponding plugin.

Yes，I think it is necessary.  can you  provider this pr ?

of course

This issue has been completed, please review
https://github.com/apache/shenyu/pull/3894

This issue has been completed, please review #3894

TotalWeight is dynamic, see org.apache.shenyu.loadbalancer.entity.Upstream#warmup

This issue has been completed, please review #3894

TotalWeight is dynamic, see org.apache.shenyu.loadbalancer.entity.Upstream#warmup

Oops, I see. the total weight cannot be calculated when the parameter is changed, so I will close this pr and open it again if necessary

Thanks a lot, if you have more question, you can reopen this issue.


fix: typo in hosting-models.md

Internal previews

📄 File
🔗 Preview link

aspnetcore/blazor/hosting-models.md
ASP.NET Core Blazor hosting models

@dotnet-policy-service agree

Hello @ttomczak3 ... Thanks for the suggestion, but this isn't a typo, and management was very particular about how they wanted this described. This is the exact language that they approved.


pass in chorus style to processline

Fixes
https://github.com/paurakhsharma/flutter_chord/issues/25
Pre Changes:

Post Changes:

Writing a test for this one sec

Ok good to go

@paurakhsharma  Mind merging this? I want to add the ability to pas in the scroll controller
https://github.com/paurakhsharma/flutter_chord/pull/16
Since they didnt clean it up ill submit a new PR to add this.


Export types from package.json

Fixes https://github.com/microsoft/TypeScript/issues/52363

@samhirtarif
Hello, is it possible for this pull request to be merged? It's not possible to import any of the components when using TypeScript and .tsx files without errors as it complains about the types.

please senpai...
notice us

@asquithea thanks for this!
And sorry for the wait guys! This will be published shortly!


:bug: Fix deps filter crash bug by limiting tag grouping calculation to tag filters

Addresses issue https://github.com/konveyor/tackle2-ui/issues/1944 introduced by https://github.com/konveyor/tackle2-ui/pull/1903
Currently the operation to build the tag category labels is very expensive & is causing maximum update depth exceeded errors when performing a filter operation in some cases.

This PR introduces a quick fix to limit the label creation operation by categoryKey === 'tags'. We should circle back on this & see if there is a better way to implement the category / name grouping.

@ibolton336 @sjd78
The root cause seem to be chip group name collision. Both "Language" filter and "Tags" filter create chip group with title "Language". After renaming one of them the problem is solved (see below).
However tag categories, in general, are editable. We might run into more conflicts. The solution might be using a prefix for chip groups created from tags categories i.e.  Tags/Language. What do you think?
diff --git a/client/src/app/pages/dependencies/dependencies.tsx b/client/src/app/pages/dependencies/dependencies.tsx
index 97db65ce..166ff7aa 100644
--- a/client/src/app/pages/dependencies/dependencies.tsx
+++ b/client/src/app/pages/dependencies/dependencies.tsx
@@ -75,7 +75,7 @@ export const Dependencies: React.FC = () => {
       },
       {
         categoryKey: "provider",
-        title: t("terms.language"),
+        title: "LL",
         type: FilterType.search,
         filterGroup: "Dependency",
         placeholderText:

@ibolton336 @sjd78
Further research revealed that the problem is in duplicated keys - ToolbarFilter derrives them from categoryName which in our filters usually comes from category.title.
I've created a draft PR with the fix ( #1949 ).


Use Puppeteer to run tests in browser env

https://highfidelity.atlassian.net/browse/HIFI-638

This may not be necessary now after https://github.com/highfidelity/hifi-spatial-audio-js/pull/103


[mtl] buffer view support

Fixes #1935
PR checklist:

[x] make succeeds (on *nix)
[x] make reftests succeeds
[x] tested examples with the following backends: metal

Closing if favor of #1966


Add date range picker to dashboards

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1821
Originally created by @dmor on 2020-02-28 17:48:27

Right now, it is only on the reports.
Expected Behavior:
It should change the date range for all the reports on that dashboard

View 12 previous comments from the original issue on GitLab


incompatibilities not working for me

dear friend,
could not figure out why the incompatibilities is not working for me. is this feature still in development or should it work as described ? help would be much appreciated
thank you

    {
      "name": "BOTS",
      "values": ["Bombed", "Doodle", "Gold", "Green", "Grey", "Ironman", "Rot", "Wood", "Yellow", "Zombie"],
      "trait_path": "./trait-layers/2_BOTS",
      "filename": ["Bombed", "Doodle", "Gold", "Green", "Grey", "Ironman", "Rot", "Wood", "Yellow", "Zombie"],
      "weights": [8, 12, 2, 15, 15, 6, 15, 7, 15, 5]
    },
	{
      "name": "EYES",
      "values": ["Bullaugen", "Eyes_human", "Hawt_Augen", "Schlitzauge", "Tearsdrops"],
      "trait_path": "./trait-layers/4_EYES",
      "filename": ["Bullaugen", "Eyes_human", "Hawt_Augen", "Schlitzauge", "Tearsdrops"],
      "weights": [20, 20, 20, 20, 20]
    },

	...

	 "incompatibilities": [
    {"layer": "BOTS", "value": "Ironman", "incompatible_with": ["Bullaugen"]},
    {"layer": "BOTS", "value": "Ironman", "incompatible_with": ["Eyes_human"]},
    {"layer": "BOTS", "value": "Ironman", "incompatible_with": ["Hawt_Augen"]},
    {"layer": "BOTS", "value": "Ironman", "incompatible_with": ["Schlitzauge"]},
    {"layer": "BOTS", "value": "Ironman", "incompatible_with": ["Tearsdrops"]}

  ],

incompatible_with is an array. put all incompatible traits in it.

thanks!  changed it up but somehow it has no effect
{"layer": "BOTS", "value": "Ironman", "incompatible_with": ["bullaugen", "eyes_human", "hawt_Augen", "schlitzauge", "tearsdrops"]}

Add a blank layer to EYES. It needs to find an image for that layer even if you don't want one there. Make a blank PNG and name it "none" or something, then add it like the other possible images in EYES.

thanks for the tip, but then i get a few combinations where the EYES are missing where they should not. sorry for bothering you :)

Sorry to interfere, even when you set the blank png weight to 0?

thanks for the tip, but then i get a few combinations where the EYES are missing where they should not. sorry for bothering you :)

I will look for a solution for now. You can add an imcompatibility with EYES none with everything but ironman. It'll only pick a none layer if ironman is selected then, and never pick a none layer otherwise.

Sorry to interfere, even when you set the blank png weight to 0?

It would never be selected then and you would get infinite recursion.

i added "none" to the eyes and tried it like this but still not working. i could upload the project? :)
  "incompatibilities": [     {"layer": "BOTS", "value": "ironman", "incompatible_with": ["bullaugen", "eyes_human", "hawt_augen", "schlitzauge", "tearsdrops"]},     {"layer": "EYES", "value": "bullaugen", "incompatible_with": ["ironman"]},     {"layer": "EYES", "value": "eyes_human", "incompatible_with": ["ironman"]},     {"layer": "EYES", "value": "hawt_augen", "incompatible_with": ["ironman"]},     {"layer": "EYES", "value": "schlitzauge", "incompatible_with": ["ironman"]},     {"layer": "EYES", "value": "tearsdrops", "incompatible_with": ["ironman"]}   ]

i added "none" to the eyes and tried it like this but still not working. i could upload the project? :)
"incompatibilities": [
{"layer": "BOTS", "value": "ironman", "incompatible_with": ["bullaugen", "eyes_human", "hawt_augen", "schlitzauge", "tearsdrops"]},

{"layer": "EYES", "value": "bullaugen", "incompatible_with": ["ironman"]},

{"layer": "EYES", "value": "eyes_human", "incompatible_with": ["ironman"]},

{"layer": "EYES", "value": "hawt_augen", "incompatible_with": ["ironman"]},

{"layer": "EYES", "value": "schlitzauge", "incompatible_with": ["ironman"]},

{"layer": "EYES", "value": "tearsdrops", "incompatible_with": ["ironman"]}

]

Yes please upload your project or email me at<EMAIL_ADDRESS>

thank you so much! email is sent

Fixed your code.
"incompatibilities": [
    {"layer": "BOTS", "value": "Ironman", "incompatible_with": ["Bullaugen", "Eyes_human", "Hawt_Augen", "Schlitzauge", "Tearsdrops"]},
    {"layer": "EYES", "value": "None", "incompatible_with": ["Bombed","Doodle","Gold","Green","Grey","Rot","Wood","Yellow","Zombie"]}
  ],

Please make sure you are matching case. You were doing "ironman" when the layer value was "Ironman", etc. I fixed them for you, and added the None layer for EYES. Enjoy!

top man


codec2: 1.0.5 -> 1.03

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/codec2/versions.
meta.description for codec2 is: "Speech codec designed for communications quality speech at low data rates"
meta.homepage for codec2 is: "https://www.rowetel.com/codec2.html"
meta.changelog for codec2 is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.03 with grep in /nix/store/kygn9g9wv905iv1n3nddri3iwni171xc-codec2-1.03
found 1.03 in filename of file in /nix/store/kygn9g9wv905iv1n3nddri3iwni171xc-codec2-1.03

Rebuild report (if merged into master) (click to expand)

26 total rebuild path(s)

26 package rebuild(s)

First fifty rebuilds by attrpath
codec2
freedv
gnss-sdr
gnuradio
gnuradio3_8
gnuradio3_8Minimal
gnuradio3_8Packages.ais
gnuradio3_8Packages.gnuradio
gnuradio3_8Packages.grnet
gnuradio3_8Packages.limesdr
gnuradio3_8Packages.osmosdr
gnuradio3_8Packages.rds
gnuradio3_9
gnuradio3_9Minimal
gnuradio3_9Packages.gnuradio
gnuradioMinimal
gnuradioPackages.gnuradio
gqrx
gqrx-gr-audio
gqrx-portaudio
haskellPackages.bindings-codec2
inspectrum
lpcnetfreedv
m17-cxx-demod
qradiolink
sdrangel

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/kygn9g9wv905iv1n3nddri3iwni171xc-codec2-1.03 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A codec2 https://github.com/r-ryantm/nixpkgs/archive/da1652c125bfc49d11cc421fdc58ae58a5e15ab1.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/kygn9g9wv905iv1n3nddri3iwni171xc-codec2-1.03
ls -la /nix/store/kygn9g9wv905iv1n3nddri3iwni171xc-codec2-1.03/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @markuskowa for testing.

Result of nixpkgs-review pr 186237 run on x86_64-darwin 1

14 packages marked as broken and skipped:

freedv
gnuradio
gnuradio3_8
gnuradio3_8Minimal
gnuradio3_8Packages.ais
gnuradio3_8Packages.gnuradio
gnuradio3_8Packages.grnet
gnuradio3_8Packages.osmosdr
gnuradio3_8Packages.rds
gnuradio3_9
gnuradio3_9Minimal
gnuradio3_9Packages.gnuradio
gnuradioMinimal
gnuradioPackages.gnuradio

1 package failed to build:

m17-cxx-demod

3 packages built:

codec2
haskellPackages.bindings-codec2
lpcnetfreedv

See https://github.com/NixOS/nixpkgs/pull/185907 and PRs mention therin.

The upstream tag has been removed. https://github.com/drowe67/codec2/issues/349


Fix Makefile.win

Reference https://github.com/elixir-sqlite/exqlite/issues/150
@greven
Could you be so kind and test this change?
It was a long day and I'm now on my tablet online only.
So this is my guess. Probably I'll make it tomorrow to test it myself also.

Building fine now! Thanks for finding out what it was. Building anything on Windows is always a pain!

So if it was not on purpose, I'm confident now this should solve the issue.
You're welcome. 🙌