Resizing Not Working If Increasing Image Size W/O Stretch Param

As we are testing imagor as a true drop-in replacement for Thumbor, we have noticed that the basic resizing of an image does not work the same when trying to make an image larger.
For example, with Thumbor, if I want to make an image that is 640x480 increase to a width of 780, I can simply use these minimal URL parameters:
http://localhost:8000/unsafe/780x0/photos%2Fb%2Fef88c521cbbb57e05c12a2dcc696724f12c9155f.jpg

Using that same URL in imagor displays the image in it's original size.
I know that imagor does not have all of the features as Thumbor as of yet but wanted to point this out because it is a basic way to increase image sizes that I'm sure I'm not the only one doing this. Even though imagor offers a stretch param that works, to be a true drop in replacement, it would be nice to not have to use this as it may not be easy to change the url params in whatever backend code utilizes it.

Thanks for reporting! Please try shumc/imagor:0.6.4, which fixes upscale resizing with unspecified width/height.


Modified Integers.java

Initialized constant variables and substituted them through out the code.

By submitting this pull request I confirm I've read and complied with the below requirements.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the coding guidelines for this project.
[x] My code follows the skeleton code structure.
[x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.

I added my code with better performance and optimized code.


added Microsoft Publisher

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/6623

Dear @JohanFreelancer9,
kindly do the copy editor review for this PR.
Dear @mypil, for your information
Thank you

@Dansimp - PR is ready for final review. This is based on issue #6623.
Thank you.
cc: @kenwith

@Dansimp - Can you please merge this approved PR?
Thank you.


enhancement: adding support for unzip cmd to Dockerfile

Description of what you did:
Added support for unzip command in Dockerfile when running as a proxy

My PR is a:

[ ] 💥 Breaking change
[ ] 🐛 Bug fix
[x] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[x] Multiple commits are squashed into one commit.
[ ] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[ ] All npm dependencies are pinned.

/lgtm
/approve

/check-cla

/lgtm


Change Domain name from harriricanadian.edu.lb to rhu.edu.lb

The university no longer has a website in the name harricanadian.edu.lb, the new website is rhu.edu.lb

url: http://www.rhu.edu.lb

computer science course:  http://www.rhu.edu.lb/home/academics/college-of-science-and-information-systems/majo/computer--information-systems-department/bachelor-of-science-in-computer-science

The university uses the domain<EMAIL_ADDRESS>for students and faculty members: You can see this on their page:  http://www.rhu.edu.lb/faculty-and-staff

@user689 Pull request merged. Thank you for the update!


Import map isn't updated sometimes unless retried

Storage: Google Cloud
PATCH requests return 200, but map isn't actually updated
However it works after retrying

Are you sure this isn't related to cache control or CDN edge location caching within GCP?

@joeldenning yes, i observed it a couple of times and verified it. As a workaround, i'm doing the PATCH request 3 times and it seems to fix the issue.

This one will be difficult to track down without a way for me to reproduce it. I have a GCP import-map-deployer running at https://github.com/joeldenning/live-import-map-deployer, with CI processes calling the import map deployer in ~20 repos. But I haven't seen this problem before. Any ideas on how I can reproduce it?

@joeldenning I couldn't find a way to reproduce it with consistency. I'm not facing the issue after retrying is added. Thanks for the support.


DAF-5565: Disable PIP and Notification logic

Description

Release notification and hide PIP control button

Solution

Release notification and hide PIP control button

What was done (Please be a little bit specific)

Release notification and hide PIP control button

Reference
JIRA
https://dw-ml-nfc.atlassian.net/browse/DAF-5565
Screenshot or Video (Before/After)
Added later in PR on the dwango-app-ch repo.
Ready for review checklist
Basically, you must check all. (When you ignore any checks, please write each reason.)

[x] All sections above are properly filled in
[x] The PR only deals with one functionality/bug
[ ] Includes code refactoring? If yes, the following sub checks are required.

[ ] The changes were tested. So there is no degradation.
[ ] The change is not too big. (Reviewers can review it.)

[ ] Includes change of spec? If yes, the sub check is required.

[ ] Updated the document.

[x] Builds and runs on iOS (No new warnings nor new errors)
[x] Builds and runs on Android (No new warnings nor new errors)

@noboru-i
I tried using setupAutomaticPictureInPictureTransition but when I call it in PIP mode it doesn't work as expected.
So I had to try this way.


Batching - use legacy path for antialiased polys.

Antialiased polys work by drawing a smoothed line around the poly after the main drawing. Batching draws polys as a series of triangles with no concept of 'edge', and when 2 polys are joined it becomes impractical to back calculate the edges from the triangles.
For this reason batching is disabled for antialiased polys in this PR.
Fixes #43319
Notes

It might be possible to batch these by storing additional indices or vertices to mark the edge, but would be quite a change for something I'm not convinced will be used that often.
This is turned off when not using GLES_OVER_GL, notably on mobile, where there is no anti aliasing for polys available in any case.

Thanks!


Operator overload signatures are not shown in docs app

Description Of The Issue
In the docs app, overload signatures are shown for methods on Observable - e.g. five overload signatures are shown for subscribe.
However, overload signatures are not shown for operators. That makes documenting shareReplay somewhat difficult, as it has a number of signatures - including a signature that takes a single config object. The same problem exists for the config object signature added for retry in this PR.
It's not clear what needs to be done to effect the showing of overload signatures for operators and I'm not sure what it is that effects them for Observable#subscribe - as  there doesn't seem to be anything specific to overloads in the TSDoc.

Looks like my observation above is correct. Here's how the Overloads section is build :)
https://github.com/ReactiveX/rxjs/blob/5170728f0262d65ab43937da9cbd621d6a5b4739/docs_app/tools/transforms/templates/api/function.template.html#L19

Closed in #7367.


Raise the inscription with the description of requirements to a higher layer so that it would not be affected by blur

Raise the inscription with the description of requirements to a higher layer so that it would not be affected by blur.
Actually this inscription should be a hint how to unlock Choice, but if it is hidden like the rest of the text, it loses its meaning.

Blur applies to the entire object. It's impossible to exclude specific text inside it from being blurred.

Uff....  I did manage to get those elements to be visible, but it works absolutely horribly.
here is the code that can be pasted into index.html and it even works by copying elements, but for some reason new elements scroll on the page with a slight delay....
It can probably be improved somehow, but I have no idea how. You can see how it all works at https://dragonswhore-cyoas.neocities.org/testFW5/
But of course I'm going to remove it from the page soon because it looks too bad.
 <script>
  function createOrUpdateVisibleText() {
    const targetElements = document.querySelectorAll('span[data-v-9eb6a880] > span[data-v-9eb6a880] div.pa-0.col');
    targetElements.forEach((element, index) => {
      if (element.textContent.includes('Required:')) {
        let newElement = document.getElementById(`visible-text-${index}`);
        const isVisible = window.getComputedStyle(element).display !== 'none';

        if (!newElement && isVisible) {
          newElement = document.createElement('div');
          newElement.id = `visible-text-${index}`;
          document.body.appendChild(newElement);
        }

        if (newElement && isVisible) {
          newElement.textContent = element.textContent;

          const styles = window.getComputedStyle(element);
          newElement.style.cssText = styles.cssText;

          Object.assign(newElement.style, {
            position: 'fixed',
            zIndex: '2',
            fontFamily: 'Candara',
            fontSize: '75%',
            textAlign: 'center',
            color: 'rgb(255, 255, 255)',
          });

          const rect = element.getBoundingClientRect();
          newElement.style.left = `${rect.left}px`;
          newElement.style.top = `${rect.top}px`;
          newElement.style.width = `${rect.width}px`;
          newElement.style.height = `${rect.height}px`;
        } else if (newElement && !isVisible) {
          newElement.remove();
        }
      }
    });
  }

  document.addEventListener('DOMContentLoaded', createOrUpdateVisibleText);
  setTimeout(createOrUpdateVisibleText, 1000);
  window.addEventListener('scroll', createOrUpdateVisibleText);
  window.addEventListener('resize', createOrUpdateVisibleText);
  setInterval(createOrUpdateVisibleText, 100);
</script>


Kiosk Mode

What version of Streaming-Meda-Cordova-Plugin are you using? 2.2.0
What version of Cordova are you using? 7
What devices are affected? Android
Please describe the issue in detail, with relevant code samples
I'm using this together with a plugin that makes my app a Kioks Mode, fullscreen, even back/home buttons dissapear, but when i use this plugin it enables the back/home button breaking the fullscreen.
What did you expect to happen? respect fullscreen on kiosk mode
What actually happened? created a back/home buttons and resized my screen

What version of Streaming-Meda-Cordova-Plugin are you using? 2.2.0
What version of Cordova are you using? 7
What devices are affected? Android
Please describe the issue in detail, with relevant code samples
I'm using this together with a plugin that makes my app a Kioks Mode, fullscreen, even back/home buttons dissapear, but when i use this plugin it enables the back/home button breaking the fullscreen.
What did you expect to happen? respect fullscreen on kiosk mode
What actually happened? created a back/home buttons and resized my screen

how did you manage to disable home / back button? wich plugin did you use ?
Thanks in advance for your reply

What version of Streaming-Meda-Cordova-Plugin are you using? 2.2.0
What version of Cordova are you using? 7
What devices are affected? Android
Please describe the issue in detail, with relevant code samples
I'm using this together with a plugin that makes my app a Kioks Mode, fullscreen, even back/home buttons dissapear, but when i use this plugin it enables the back/home button breaking the fullscreen.
What did you expect to happen? respect fullscreen on kiosk mode
What actually happened? created a back/home buttons and resized my screen

how did you manage to disable home / back button? wich plugin did you use ?
Thanks in advance for your reply

What version of Streaming-Meda-Cordova-Plugin are you using? 2.2.0
What version of Cordova are you using? 7
What devices are affected? Android
Please describe the issue in detail, with relevant code samples
I'm using this together with a plugin that makes my app a Kioks Mode, fullscreen, even back/home buttons dissapear, but when i use this plugin it enables the back/home button breaking the fullscreen.
What did you expect to happen? respect fullscreen on kiosk mode
What actually happened? created a back/home buttons and resized my screen

how did you manage to disable home / back button? wich plugin did you use ?
Thanks in advance for your reply

i didn't and it seems we won't have a reply from the author.


Segfault in array aggregation large memory usage

Steps to reproduce the behavior (Required)

CREATE TABLE `some_table` (
  `created_at` date NOT NULL COMMENT "",
  ...
  `some_array` array<int(11)> NOT NULL COMMENT "",
  `some_int` int(11) NOT NULL COMMENT "",
  ...
) ENGINE=OLAP
DUPLICATE KEY(`created_at`)
COMMENT "OLAP"
PARTITION BY date_trunc('day', created_at)
...
PROPERTIES (
    "replication_num" = "3",
    "datacache.enable" = "true",
    "enable_async_write_back" = "false",
    "enable_persistent_index" = "false",
    "compression" = "LZ4"
);

This query has ommited columns and conditions, but real query require double group by and cte

with query as (
  select
    created_at,
    array_length(array_remove(array_unique_agg(case when some_int > 0 then some_array end), null)) as some_array_length
  from some_table
  group by created_at
  order by created_at
)
select
  created_at,
  array_agg(some_array_length)
from query
group by created_at

sql client got

SQL Error [1064] [42000]: Internal error: vector::_M_default_append

Expected behavior (Required)
Query returns data or SR safely aborts query
Real behavior (Required)
StarRocks compute node logs
CN restarts each time when this sql is executing
2024-05-03 23:29:48.266
/opt/starrocks/cn_entrypoint.sh: line 185:    27 Segmentation fault      (core dumped) $STARROCKS_HOME/bin/start_cn.sh $addition_args
2024-05-03 23:29:48.272
[Fri May  3 23:29:48 MSK 2024] Receives signal to exit ...
2024-05-03 23:29:48.274
[Fri May  3 23:29:48 MSK 2024] Can't find /opt/starrocks/cn/bin/cn.pid!
2024-05-03 23:29:48.277
[Fri May  3 23:29:48 MSK 2024] Process conf file cn.conf ...
2024-05-03 23:29:48.279
[Fri May  3 23:29:48 MSK 2024] try to drop myself(starrocks-cn-1.starrocks-cn-search.starrocks.svc.cluster.local) from FE ...
2024-05-03 23:29:48.304
[Fri May  3 23:29:48 MSK 2024] run start_cn.sh
2024-05-03 23:30:00.869
I0503 23:29:19.205855   305 plan_fragment_executor.cpp:369] cancel(): fragment_instance_id=4246fc79-0e77-4544-750b-6da44db86fbb
2024-05-03 23:30:00.869
I0503 23:29:19.205862   305 fragment_mgr.cpp:574] FragmentMgr cancel worker going to cancel timeout fragment 4246fc79-0e77-4544-750b-6da44db86fbb
2024-05-03 23:30:00.869
I0503 23:29:19.205873   305 plan_fragment_executor.cpp:369] cancel(): fragment_instance_id=2242d13b-5dd0-8b9e-86a4-56560d1889a4
2024-05-03 23:30:00.869
I0503 23:29:19.205881   305 fragment_mgr.cpp:574] FragmentMgr cancel worker going to cancel timeout fragment 2242d13b-5dd0-8b9e-86a4-56560d1889a4
2024-05-03 23:30:00.869
I0503 23:29:19.205891   305 plan_fragment_executor.cpp:369] cancel(): fragment_instance_id=4c47aa88-4d19-a2a3-9a2b-243b4e5b9ab3
2024-05-03 23:30:00.869
I0503 23:29:19.205900   305 fragment_mgr.cpp:574] FragmentMgr cancel worker going to cancel timeout fragment 4c47aa88-4d19-a2a3-9a2b-243b4e5b9ab3
2024-05-03 23:30:00.869
I0503 23:29:19.205909   305 plan_fragment_executor.cpp:369] cancel(): fragment_instance_id=004c35c3-9c88-056d-dd19-bbb965e2ed8e
2024-05-03 23:30:00.869
I0503 23:29:19.205916   305 fragment_mgr.cpp:574] FragmentMgr cancel worker going to cancel timeout fragment 004c35c3-9c88-056d-dd19-bbb965e2ed8e
2024-05-03 23:30:00.869
I0503 23:29:19.283994   459 load_channel_mgr.cpp:249] Memory consumption(bytes) limit=4174708211 current=0 peak=1469134464
2024-05-03 23:30:00.869
W0503 23:29:19.192533   394 mem_hook.cpp:249] large memory alloc, query_id:cf7bddaa-098b-11ef-844d-f6857d1d0c72 instance: cf7bddaa-098b-11ef-844d-f6857d1d0cba acquire:1827184060 bytes, stack:
2024-05-03 23:30:00.869
    @          0x69abbf2  malloc
2024-05-03 23:30:00.869
    @          0xa531e8c  operator new()
2024-05-03 23:30:00.869
    @          0x3da1bee  starrocks::FixedLengthColumnBase<>::append()
2024-05-03 23:30:00.869
    @          0x3f625b2  starrocks::ArrayColumn::append()
2024-05-03 23:30:00.869
    @          0x611f440  starrocks::Aggregator::output_chunk_by_streaming()
2024-05-03 23:30:00.869
    @          0x624aa7a  starrocks::pipeline::AggregateStreamingSinkOperator::_push_chunk_by_force_streaming()
2024-05-03 23:30:00.869
    @          0x6253e2e  starrocks::pipeline::AggregateStreamingSinkOperator::_push_chunk_by_limited_memory()
2024-05-03 23:30:00.869
    @          0x62541c1  starrocks::pipeline::AggregateStreamingSinkOperator::push_chunk()
2024-05-03 23:30:00.869
    @          0x5f0a70f  starrocks::pipeline::PipelineDriver::process()
2024-05-03 23:30:00.869
    @          0x67a745e  starrocks::pipeline::GlobalDriverExecutor::_worker_thread()
2024-05-03 23:30:00.869
    @          0x6b36c33  starrocks::ThreadPool::dispatch_thread()
2024-05-03 23:30:00.869
    @          0x6b30f0a  starrocks::Thread::supervise_thread()
2024-05-03 23:30:00.869
    @     0x7f8591d3dac3  (unknown)
2024-05-03 23:30:00.869
    @     0x7f8591dcf850  (unknown)
2024-05-03 23:30:00.869
    @              (nil)  (unknown)
2024-05-03 23:30:00.869
*** Aborted at<PHONE_NUMBER> (unix time) try "date -d @1714768159" if you are using GNU date ***
2024-05-03 23:30:00.869
PC: @     0x7f8591e49d50 (unknown)
2024-05-03 23:30:00.869
*** SIGSEGV (@0x7f8428585000) received by PID 27 (TID 0x7f852f6c8640) from PID 676876288; stack trace: ***
2024-05-03 23:30:00.869
    @          0x7f567da google::(anonymous namespace)::FailureSignalHandler()
2024-05-03 23:30:00.869
    @     0x7f8591ceb520 (unknown)
2024-05-03 23:30:00.869
    @     0x7f8591e49d50 (unknown)
2024-05-03 23:30:00.869
    @          0x3da1b9a starrocks::FixedLengthColumnBase<>::append()
2024-05-03 23:30:00.869
    @          0x3f625b2 starrocks::ArrayColumn::append()
2024-05-03 23:30:00.869
    @          0x611f440 starrocks::Aggregator::output_chunk_by_streaming()
2024-05-03 23:30:00.869
    @          0x624aa7a starrocks::pipeline::AggregateStreamingSinkOperator::_push_chunk_by_force_streaming()
2024-05-03 23:30:00.869
    @          0x6253e2e starrocks::pipeline::AggregateStreamingSinkOperator::_push_chunk_by_limited_memory()
2024-05-03 23:30:00.869
    @          0x62541c1 starrocks::pipeline::AggregateStreamingSinkOperator::push_chunk()
2024-05-03 23:30:00.869
    @          0x5f0a70f starrocks::pipeline::PipelineDriver::process()
2024-05-03 23:30:00.870
    @          0x67a745e starrocks::pipeline::GlobalDriverExecutor::_worker_thread()
2024-05-03 23:30:00.870
    @          0x6b36c33 starrocks::ThreadPool::dispatch_thread()
2024-05-03 23:30:00.870
    @          0x6b30f0a starrocks::Thread::supervise_thread()
2024-05-03 23:30:00.870
    @     0x7f8591d3dac3 (unknown)
2024-05-03 23:30:00.870
    @     0x7f8591dcf850 (unknown)
2024-05-03 23:30:00.870
    @                0x0 (unknown)

StarRocks version (Required)

3.2.3-a40e2f8
But 3.2.4, and 3.2.6 also has segfault

Thanks. we will check and fix it

I have a similar issue with _M_range_insert() :
W0517 13:22:21.327330 1683661 mem_hook.cpp:249] large memory alloc, query_id:462f2a3b-1450-11ef-9347-024271588a32 instance: 462f2a3b-1450-11ef-9347-024271588a34 acquire:2104349994 bytes, stack:
    @          0x69eef12  malloc
    @          0xa59596c  operator new()
    @          0x3deb8a6  std::vector<>::_M_range_insert<>()
    @          0x3def076  starrocks::BinaryColumnBase<>::append()
    @          0x3f892a6  starrocks::NullableColumn::append()
    @          0x60155e6  starrocks::JoinHashTable::append_chunk()
    @          0x600b351  starrocks::HashJoinBuilder::append_chunk()
    @          0x5fffe04  starrocks::HashJoiner::append_chunk_to_ht()
    @          0x634c3cc  starrocks::pipeline::HashJoinBuildOperator::push_chunk()
    @          0x5f4b642  starrocks::pipeline::PipelineDriver::process()
    @          0x67eb3be  starrocks::pipeline::GlobalDriverExecutor::_worker_thread()
    @          0x6b7b90c  starrocks::ThreadPool::dispatch_thread()
    @          0x6b74e1a  starrocks::Thread::supervise_thread()
    @     0x7f0d3af5fac3  (unknown)
    @     0x7f0d3aff1850  (unknown)
    @              (nil)  (unknown)

version 3.2.6
but I don't know which query is causing the crash.


Issue with files upload

Have you seen this issue https://github.com/spiral/roadrunner/issues/133?
Asking just because it's most alive repo

@hotrush hm.. Can you make a PR with your fix implementation?

@tarampampam i have no any fix, just investigating situation with laravel - rr. There are a lot of repos with the similar issues)

@hotrush Good news, dude! @jetexe found how to fix this issue, and we needs in your test. Just install v1.3.0-RC1 version of this package - this release candidate was made special for you.

ping @hotrush

Release: https://github.com/avto-dev/roadrunner-laravel/releases/tag/v1.3.0

Hi @tarampampam, i'm happy that you made this fix, thanks :+1:
But i can test it only on the next week when return back to project using RR.

@hotrush ok, np, thx for this issue!


📝 Documentation(i18n): Translate the Blogs To Spanish

Bug Report Checklist

[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
Translate the Blogs to Spanish; go to blog.es-ES.mdx and make the translations from there, you will have to step into the Blogs folder to make the translations needed to the files with the .es-ES extension.

Additional Info

You can come into the docs channel in the Discord Server for further information. Do translate the front-matter as well.

Use an informal tone, not too informal though

Also, checkout the Contriibuting Guide incase you want to set up Million locally

I can do this @tobySolutions  👋, native english speaker here!

I can do this @tobySolutions 👋, native spanish speaker here!

Sure thing, please feel free to take this on Oliver!

@tobySolutions I already translated 3 blog posts, I am just waiting for you to merge my first PR on the Foundation section translation and open a new one just for the remaining blogs. Thanks for your comprehension.

On it @oliverloops!


multi-language

Possibility to translate the wallet into other languages, language selection at wallet.

Is there a resource file with all the texts for the community to translate?

Not yet but will be created for the first translation.

hi, how to translate?


Unable to register a service worker of third party from a first party

We have a first party site (https://company.net) and it has an embedded iFrame which points to a third party site (https://scpo-app.com/scpo) both are owned by us but deployed on different domains.
We have enabled SSO on first party site and using the service worker (which is hosted on https://scpo-app.com/scpo/ui/v1/by-service-worker.js), we are authorizing 3rd party calls by intercepting and attaching an authorization token in the HTTP header for 3rd party service calls.
This implementation works seamlessly if we allow the Third-party cookie (chrome://settings/cookies?search=Third-party).
If we disable the Third-party cookie (chrome://settings/cookies?search=Third-party) and try to launch the 1st party site and access the 3rd party resource then service-worker registration fails with the following error - "Service worker registration failed  DOMException: Failed to register a ServiceWorker for scope ('https://scpo-app.com/scpo/ui/v1') with script ('https://scpo-app.com/scpo/ui/v1/by-service-worker.js'): The user denied permission to use Service Worker"

What version of chrome are you testing in?

Hi @wanderview,
I am using 122.0.6261.58 (Official Build) (64-bit) version of chrome.

Hi @Akshay20240305,
We're unable to reproduce your problem using a test site.
Can you please disable third-party cookies and then visit https://x-origin-src.glitch.me/tmp.html and let us know if you continue to see the "Failed to register a ServiceWorker" error? If the SW is successfully registered you'll also see a message within the iframe that says "Ready to use Offline". (Note that the message disappears after a little while and you'll have to clear the site's data if you want to see the message again).
If the service worker is registered successfully on the test site but your site continues to fail then that may mean that your Chrome instance has enterprise policies that are affecting service workers.
If you visit chrome://policy/ do you see either of your URLs in any of the policy values? "CookiesBlockedForUrls" is a particularly interesting one to look for.

Hi @sbingler,
I am able to replicate the same problem with the following test site as well https://x-origin-src.glitch.me/tmp.html
Please find the below attached screenshot for reference

@Akshay20240305 have you tested in a new profile or different Chrome instance, not just in incognito?
[Akshay20240305]: I have tried in a different chrome instance and the behavior is same, please find the below screenshot:

If you visit chrome://policy/ do you see either of your URLs in any of the policy values? "CookiesBlockedForUrls" is a particularly interesting one to look for.
[Akshay20240305]: I have reviewed the policies and I don't see any mappings defined for my URL
Please answer this question as well.

One more update: My chrome browser version got updated from 122.0.6261.58 (Official Build) (64-bit) to  Version 122.0.6261.112 (Official Build) (64-bit)

Hi @miketaylr,
I have tried the same steps from different machine's(VM) chrome browser (Version 122.0.6261.112 (Official Build) (64-bit)) which has same level of chrome policies and there the issue is not replicable.

Could you please help me in understanding the inconsistency in the behavior?

Could you please help me in understanding the inconsistency in the behavior?

Without having access to the policies that may be active for your machine, it's really hard to say. If you're comfortable sharing the output of the Chrome Policies section of chrome://policy (and only that section - no other info needed), you could email that to<EMAIL_ADDRESS>But I understand that it may not be sharable.
Do any of your co-workers run into this issue, or are you the only one?

Could you please help me in understanding the inconsistency in the behavior?

Without having access to the policies that may be active for your machine, it's really hard to say. If you're comfortable sharing the output of the Chrome Policies section of chrome://policy (and only that section - no other info needed), you could email that to<EMAIL_ADDRESS>But I understand that it may not be sharable.
[Akshay20240305]: I have sent an email with the details for your review.
Do any of your co-workers run into this issue, or are you the only one?
[Akshay20240305]: The issue is consistently(100%) replicable in 121...* version of browser and with the recent chrome browser (122.0.6261.129) upgrade, 90% of my co-workers are not experiencing this issue. For the remaining 10% of co-workers (plus me) the issue is 100% replicable.

Hi @miketaylr,
We are actually assessing the impact on our application because of 3PC cookie phaseout.
Flag details: chrome://flags/#test-third-party-cookie-phaseout.

@Akshay20240305 thanks for sending the policies - I can confirm there's nothing relevant there.
One more question: can you tell me what is the value for chrome://flags/#third-party-storage-partitioning? It should be "Default", but if you've set it to "Disabled", then what you are seeing is expected behavior.

Yes @miketaylr  that was the problem, after chaging the flag value to default or enable, issue is resolved. Thank you so much for a quick help on this matter.

Glad to hear it!


Sortable:stop wrong value of e.newIndex

We have two sortable elements, for example. When I change their places (sortable:stop) there appears a wrong value of e.newIndex. e.newIndex is wrong if we move from up to down (e.oldIndex: 0, e:newIndex: 2) otherwise it is right if we move from bottom to top (e.oldIndex: 1, e:newIndex: 0)

Possible duplicate of https://github.com/Shopify/draggable/issues/66, please confirm @boombang
This issue will be fixed with the next beta release

Closed via: https://github.com/Shopify/draggable/releases/tag/v1.0.0-beta.3


ASCII-text-only status column

New optional column displaying container status using plain text characters (sans symbols/icons)
As suggested by @Brayyy in https://github.com/bcicen/ctop/issues/293#issuecomment-1183918016:
State:

created: "C" (white)
running: "R" (green)
exited: "e" or "x" (gray)
paused: "p" (blue)

Health:

healthy: "H" (green)
unhealthy: "U" or "!" (red)
starting: "s" (gray)

Hey, I have an interest in developing this feature, but I have never used Golang, so you can help me with the path to do this. How to commit to this project, files to change, and pre-requisites needed.
This is my first attempt to contribute to an open-source project.
I have already given a look at the project and understand a little how this works.


rcrestore is broken

Bad system call during restore, see trace below.
Also, a bad restore seems to result in success message.
*** ATTENTION ***
* Your current database WILL BE DROPPED prior to the restore!
* Would you like to make a backup of the current database before proceeding?
* (y/n/Q)> y
tar: Removing leading `/' from member names
A backup of your data can be found at /root/snap/rocketchat-server/common/backups/rocketchat_backup_1486104024.tgz.
Extracting backup file...
/snap/rocketchat-server/x1/bin/rcrestore: line 44: 17058 Bad system call         tar zxvf $1 &> "$restore_dir/$log_name"
Cleaning database...
Restoring data...
Restore completed! Please restart the snap.rocketchat services to verify.

Hm, this is an issue I was seeing when the backup file was outside of a directory accessible by the snap, hence the logic to check the backup file location.
I'll investigate.

@Sing-Li, did you happen to run this as root, using sudo? That's the only way I can recreate the issue.
If that's the case, I know what the issue is and can probably fix it quickly.

@elespike  - very possibly 😃     Up until this revision, backup was also done via sudo.
I do believe admin will be the ones starting, stopping, doing backup / restore etc with the server - so I think sudo is fine.  Especially since install and start and journalctl (view logs) require it (to have a consistent experience).

Agreed. Give me some time. =)

PR #8 created after much testing (do test more by all means)

I will close after some testing here.  Thanks.

Still has some problems, please see trace:
autoqa@vps105588:~/rocketchat-server-snap$ sudo snap run rocketchat-server.restoredb /var/snap/rocketchat-server/common/backup.tgz
*** ATTENTION ***
* Your current database WILL BE DROPPED prior to the restore!
* Would you like to make a backup of the current database before proceeding?
* (y/n/Q)> y
tar: Removing leading `/' from member names
[+] A backup of your data can be found at /var/snap/rocketchat-server/common/backups/rocketchat_backup_2017-02-05_16-34-08.tgz.
[*] Extracting backup file...
[*] Restoring data...
/snap/rocketchat-server/x1/bin/rcrestore: line 60: 23023 Aborted                 (core dumped) mongorestore --db parties --drop ${data_dir} &> "${restore_dir}/${log_name}"
[!] Failed to execute mongorestore from var/snap/rocketchat-server/451/dump/parties!
[*] Check /var/snap/rocketchat-server/common/restore/mongorestore.log for details.
[-] Restore aborted!

Looking into the logs:
2017-02-05T16:34:09.042-0500 	Creating index: { key: { editedBy._id: 1 }, name: "editedBy._id_1", ns: "parties.rocketchat_message", sparse: 1 }
2017-02-05T16:34:09.043-0500 	Creating index: { key: { rid: 1, t: 1, u._id: 1 }, name: "rid_1_t_1_u._id_1", ns: "parties.rocketchat_message" }
2017-02-05T16:34:09.044-0500 	Creating index: { key: { expireAt: 1 }, name: "expireAt_1", ns: "parties.rocketchat_message", expireAfterSeconds: 0 }
2017-02-05T16:34:09.045-0500 	Creating index: { key: { _fts: "text", _ftsx: 1 }, name: "msg_text", ns: "parties.rocketchat_message", weights: { msg: 1 }, default_language: "english", language_override: "language", textIndexVersion: 3 }
Error creating index parties.rocketchat_message: 16730 err: "bad textIndexVersion: 3"

For your information, I am using a backup from the previous version of the snap (not created by this new rcbackup).

Oh, I actually saw this issue when I was creating rcrestore. I "fixed" it by editing the mongodump files and changing textIndexVersion to 1 and then promptly forgot about it.
That was obviously a hack, so I'll try to find out what's this textIndexVersion thing and why mongorestore doesn't like it (even though mongodump created it).

@Sing-Li Would you mind retesting with #9 ?
I no longer have previous backups that were failing that way.

👍    Will test !    Thanks.

Verified working!   Thanks @elespike !    I'll close this.
The latest version , pix upload doesn't seem to work - but that's a totally unrelated issue :)


Memory Leak

    private func testMeshInstanceLeak() {
        GD.print("going")
        self.displayed?.queueFree()

        let cylinder = CylinderMesh()
        cylinder.topRadius = 10
        cylinder.bottomRadius = 9
        cylinder.height = 40
        cylinder.radialSegments = 200

        let surfaceTool = SurfaceTool()
        surfaceTool.begin(primitive: Mesh.PrimitiveType.primitiveTriangles)
        surfaceTool.appendFrom(existing: cylinder, surface: 0, transform: Transform3D())
        surfaceTool.generateNormals()
        let array = surfaceTool.commit(existing: nil)
        surfaceTool.clear()

        let meshInstance = MeshInstance3D()
        meshInstance.mesh = array
        self.addChild(node: meshInstance)
        self.displayed = meshInstance
    }

So this code seems to just leak CylinderMesh and MeshInstance3D.

Originally posted by @nvanfleet in https://github.com/migueldeicaza/SwiftGodot/issues/102#issuecomment-1727997503

It's much simpler, this example is enough to leak MeshInstance3D wrapper on the Swift side:
@Godot
class CustomNode: Node {
    override func _ready() {
        let mesh = MeshInstance3D()
        mesh.queueFree()
    }
}

The underlying c++ MeshInstance3D::~MeshInstance3D() deallocation happens, frameworkTypeBindingFree gets called and cleans up liveFrameworkObjects dictionary, but the Swift object remains retained.
So it looks like every "framework" object allocated in Swift ends up leaked. Doesn't happen with custom "subtyped" objects.


[Feature] Support zookeeper as meta storage

Search before asking

[X] I had searched in the issues and found no similar issues.

Feature Request
Support zookeeper as meta storage
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[ ] I agree to follow this project's Code of Conduct *

may I ask if this is not what the event-registry-zookeeper module does this feature?

may I ask if this is not what the event-registry-zookeeper module does this feature?

The registry module will be migrated to the meta module and support the functions of the meta module. You can refer to the meta implementation of nacos and etcd. @Ceilzcx

I noticed that the code ZookeeperMetaService has already implemented meta-zookeeper. Has this issue been resolved?


Document process for updating catalog for local minishift testing

When adding a new runtime or booster, developers need to know how to update the local catalog for testing with minishift. The contrib guide should contain this information.

@lholmquist please add more info if needed.

FYI @tradej


Fix typo from logproPs to logproBs

@mrbullwinkle
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


TASK: Add basic meta/main.yaml for Ansible Galaxy

Hey, @fnkr I renamed the file. Thanks for taking care!


Pass mutex by value.

Following a thread in addon-operator: https://github.com/openshift/addon-operator/pull/125#discussion_r781984425
We should pass mutex by value.

I only ever see the mux beinng RLocked, but not (write) Locked. Is this intentional?

There is an Add function that is not shown in the diff: https://github.com/mt-sre/addon-metadata-operator/blob/b8569e79029d7cf8f203a6d2c48c8818113f465c/pkg/validators/registry.go#L23

Got it! :see_no_evil: Thanks :)

(soft lgtm from my side then! - I have not worked on this codebase yet so I think someone who already did should post the final lgtm)

@erdii Totally makes sense. PTAL just added some tests. Refactored the log.Fatalf() to log.Panicf() for easier testing. Choosing to panic on purpose so we don't have to check errors in the init() function, because we would just panic:
# am0001_default_channel.go
func init() {
    Registry.Add(AM0001)
}

# if we did not panic -- no way to recover
func init() {
    if err := Registry.Add(AM0001); err != nil {
        // we are checkmate here, there is really no way to recover, and so it becomes silly to check errors in every new validator
        log.Fatal(err)
    }
}

Looks good.
I'm just wondering if this mutex is in fact necessary. The validators are all registered using init fns in their respective files, so a normal map should suffice right? I'm not sure where the concurrent writes are happening.

@ashishmax31 I was under the impression that init() functions ran concurrently within a package. But after digging into it some more, it seems they run sequentially, according to lexical order of files in which they are found (within a single package): https://yourbasic.org/golang/package-init-function-main-execution-order/
Unless we have another use case, we could drop the mutex all together.
Let me refactor the code.


Knockback along the x and z axes seems to be getting cancelled by something

I was messing with the knockback function trying to give mobs more substantial knockback. I can add plenty of velocity along the y axis, but there is no velocity along the x and z axes. If I set the velocity to an absurdly high number, they will move a great distance for a single frame before stopping.
I haven't had the chance to test it yet, but I'm assuming x and z velocity is being cancelled by the flee behavior in passive animals? Or perhaps even deeper in the creature:action_move function? I'm only guessing.

Can't recreate this after the last commit.


[v13] Missing backport for sparse_array.A removal

master: #8527
v13: #8552

Thanks! This is needed for SciPy 1.14.

/test mini

Please proceed to merge after test pass.

The CI failure on SciPy 1.7 is unrelated to this PR. (will be fixed by https://github.com/cupy/cupy/pull/8576.)


Update tshoot-connect-sync-errors.md

Adding more detailed documentation for LargeObject / ExceededAllowedLength error

@NuAlex : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

@NuAlex : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


[NIT] Difficult to locate common properties button when using dark mode

Describe the issue
In dark mode - hard to see three dots in node to open common props when not highlighted
To Reproduce
Steps to reproduce the behavior:
0. Activate dark mode,

Go to pipeline editor, drag a notebook to create a node
Scroll over the node and highlight the 3 dots.

Screenshots or log output

If applicable, add screenshots or log output to help explain your problem.
Log Output

Paste the log output here.

Expected behavior
3 dots visible when cursor not over the 3 dots
Deployment information
Describe what you've deployed and how:

Elyra version: 2.1.0 rc1
Operating system: macos
Installation source: pypi
Deployment type: local

I believe I have thought of a possible solution to this problem that would also create a long term benefit for Elyra design and customizability. I have used an open source text editor that had its own seperate GitHub where uses could push and pull different themes for the application. I believe implementing something similar for Elyra while also fixing this issue in the base dark mode would be extremely beneficial. Let me know if you think this is a good idea.

Hi @sabary661990615 , thank you for the feedback.
There are a few theme packages that can be installed by the user as Jupyterlab extensions, like jupyterlab-themes
and dracula. Only not sure how well they work with the pipeline editor since it's built on canvas, unlike other editors in Elyra that simply extend Jupyterlab ones.
And that is also why this issue is Elyra specific, even though the dark mode theme code lives in Jupyterlab repo, we just need to make some adjustments on our side. I can assign you to this issue and help you find the files to work on.
Then if you're interested in building new Jupyterlab themes, which is awesome btw, I would suggest having its own extension repo or in collaboration with the existing ones, but that's just my opinion :) Feel free to propose your idea as a new issue so we can keep future discussions around it separate from the scope of this one.

Closing this as it's no longer reproducible.  This is how the nodes look like now with the most recent pipeline updates:


Resuming a multi order by query from a continuation token

Pagination of a query with a multi order from a continuation token
In code is written that an implementation in .NET Sdk could work fine if ported into JAVA SDK.
How can I do my query/quiries to have the same result before having the new Feature?
Unfortunally, the old client 3.1.0 didn't rise same error, so we used that approach (Probabily with wrong results)
com.azure.data.cosmos.internal.query.OrderByDocumentQueryExecutionContext
Code that rises the exception:
      // This code path needs to be implemented, but it's error prone and needs
            // testing.
            // You can port the implementation from the .net SDK and it should work if
            // ported right.
            throw new NotImplementedException(
                    "Resuming a multi order by query from a continuation token is not supported yet.");

I catch a "NotImplementedException" with azure-cosmos v3.7.0. Maybe it's the same issue.
Is there a new library version to solve?

@kushagraThapar could you please follow up on this customer-reported cosmos sdk issue?

@apescione @baldassarreC - Thanks for reporting this issue. @mbhaskar can you please help us figure out if this feature is still in our backlog ?

@apescione @baldassarreC sorry for the delay on this issue, we are investigating it now.
@xinlian12 - I am not sure if we even need to throw this exception anymore based on the recent query fixes that you have done.
Let's discuss this issue.

@apescione @baldassarreC - We investigated this issue and this is in our backlog for this semester. We will plan it soon and will update this issue on the timeline.

This is a feature request that is currently in plan for this semester.
@mbhaskar  - can you please share some insights on this issue ?

@mbhaskar - can you please provide an update on this issue ?

We're also facing the same issue and have similar use-case to show documents to client on a multi-order using continuation token
! Causing: org.apache.commons.lang3.NotImplementedException: Resuming an order by query from a continuation token is not supported yet. ! at com.microsoft.azure.cosmosdb.rx.internal.query.OrderByDocumentQueryExecutionContext.initialize(OrderByDocumentQueryExecutionContext.java:167)
@kushagraThapar @mbhaskar
Do you have an idea by when this feature is planned to be rolled out?

This feature is in the backlog. Current tentative plan is to have this supported by mid of this year

@mbhaskar  - I believe this has already been addressed. If so, please close the issue, thanks.

Has been released >= 4.26.0
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos/CHANGELOG.md#4260-2022-02-11


Docs modules

@riordan you can also add this to the pelias page.

You got it.
See: mapzen/blog#502

Thanks! Let's leave this open as a mental note to get the other project pages too.


add readme badges

I want to add readme badges.Please assign this issue to me

@S-ishita you have been assigned this issue .Try match the current theme of the README file while creating it .


Dockerfile can't be instantiated in OpenShift

OpenShift is using Docker 1.9 (1.3alpha is using 1.9.1).
In Docker 1.10 the format changed, so Docker files after 1.10 are not compatible with 1.9.
It seems that we are building the Docker version of ManageIQ with 1.10, so it is not possible to run it on OpenShift.
It would make sense to create another build with Docker 1.9, in parallel to the standard image, so ManageIQ can be used in Fedora (1.10) or in OpenShift, or in old versions of Fedora/RHEL/CentOS

@bazulay is working on this with @fbladilo

@sergio-ocon @chessbyte That's correct DH autobuilds now default to docker-1.10 (schema v2 images), I worked on this issue last month, please see :
https://github.com/fbladilo/miq-on-openshift
The project has instructions step-by-step in how to run the MIQ on OpenShift 3.2, latest template merged is a multi-pod MIQ/PGDB configuration but you there is also a monolithic template if you prefer this option.
The images are actually build with docker-1.9, I have a note at the end of the README regarding this same topic.
Let me know how it goes.

@sergio-ocon correct, it is a slightly modified version of the ManageIQ docker image, built with docker-1.9 for OSE 3.2 compatiblity.

@fbladilo Thanks, it would be great to know if that can be done automatically with the build tools or has to be done. FYI: @Fryguy

@sergio-ocon  @fbladilo
Sergio - there is not much to do about it till OSE will support 1.10 officially.

either you deploy 1.9 l;atest with your OSE and by that you can't use official autobuilt image from docker hub
or you install 1.10 and than you can't push images into OSE internal registry.

A possible solution for manageiq official image is to build it locally on 1.9 and than push it to dockerhub, this will actually be the same way Francio handled it.
@Fryguy  I think it is a good idea to do it for every official upstream release.

@bazulay Would that be possible to do it automatically?

@sergio-ocon @Fryguy
Since the auto builds of manageiq is using dockerhub build - it means that any build you do automaticall will be built using docker 1.10, so the simple answer would be no.
But a more advanced answer - in case manageIQ group will choose  to build it manually (on docker 1.9) and than upload it to dockerhub (which supports both formats) , than the answer is yes (this is actually what Franco is doing at this stage).
Official support of running it on Openshift is 5.7, till that time openshift 3.3 will be out and docker 1.10 will be supported (IIUC inc the internal registry) .
@Fryguy @chessbyte  I would advise to assign it to one of the appliance build group to consider the suggeston above.

I believe this is no longer the case now that we have the manageiq-pods repo.


OpenDF describe image

@ShehanWeerakkody Shall we delete .pyc files and add them to .gitignore?
I suggest having a README.md file descibing each file, their purpose,  a small description what they do.


No such file or directory: './output/label2id.pkl'怎么解决

you need to create output/result_dir directory by yourself, and the problem will be solved


Phase3: Update the tags in the erlang deps to the latest.

The tags in the erlang deps are pointing to the older versions that were released previously.

Update the tags to the latest for the deps following erlang apps:

oc_erchef
oc_bifrost
bookshelf
chef-mover
Document the deps that cannot be updated to the latest.

Can we switch to the upstream version of anything that is a chef fork without losing out current changes

epgsql
erlware_commons
ibrowse
jiffy
meck
hoax - the latest fails with HOAX_FIXTURE deprecation error.

Update the apps to be used with later versions of chef-server
 - rabbitmq (considering we want to update to erlang 20: https://www.rabbitmq.com/which-erlang.html) - update to 3.7.6

lager

Acceptance criteria:

Tags are updated consistently across all the rebars.config.
Updated version of rabbitmq is still compatible with later versions of erlang.
Verify pipeline is green
Adhoc build is green.

Tracking internally as INFS-149


Try out and add GPU support

PGD training with cpu is too slow, figure out a way to add GPU support (and maybe test it with local GPU then DelftBlue)

Seems to work now as per 'fix adversarial training' PR


Per Project/Service permissions

I love how permissions per environment work with github integration. Would it be possible to expand this to allow more granular permissions no Project and Service level?
Also it would be great to allow View/Start/Stop permissions without Delete being possible.

It's a feature that will be coming up in our 1.0 GA release. You can refer to #1338. The feature will be fleshed out in the upcoming weeks.

Using #1338 to track this feature as this is really a full RBAC implementation.


no-unused-prop-types false positives

The no-unused-prop-types rule reports false positives for me.
Here's my code:
import React from 'react';
import Buddy from './Buddy';
import Spinner from './Spinner';
import BuddyBox from './BuddyBox';
import '../css/buddies.css';

export default function Buddies(props) {
  let buddies = props.activityBuddies.map(item => (
    <BuddyBox key={item.id} {...item} endFriendship={props.endFriendship} />
  ));

  if (buddies.length === 0) {
    buddies = <Spinner />;
  }

  return (

        {buddies}

          {props.friendrequests && props.friendrequests.map(item => (

              <Buddy
                name={item.username}
                profilePicture={item._links.image.href}
                timestamp={item.last_sign_in_at}
              />
              <button
                className="buddies--confirm-button"
                onClick={() => {
                  props.handleFriendrequest(item._links.confirm.href);
                }}
              >
                Confirm
              </button>
              <button
                className="buddies--decline-button"
                onClick={() => {
                  props.handleFriendrequest(item._links.decline.href);
                }}
              >
                Decline
              </button>

          ))}

  );
}

Buddies.propTypes = {
  activityBuddies: React.PropTypes.array,
  endFriendship: React.PropTypes.func,
  friendrequests: React.PropTypes.array,
  handleFriendrequest: React.PropTypes.func,
};

The no-unused-prop-types-Rule shows an error for both the endFriendship and the handleFriendrequest props but both are used in my component.
I use eslint 3.4.0 and eslint-plugin-react 6.2.0.
I use the no-unused-prop-types-Rule as part of eslint-config-airbnb 11.0.0.
In the config it is set like this:
'react/no-unused-prop-types': ['error', {
  customValidators: [
  ],
  skipShapeProps: false,
}],

I'm also facing a false positive error, although in a bit different case, when using destructuring:
function ListItem({ item }) {}
It highlights every property of the shape of item.

One more example of false positive:
const Button = React.createClass({
    displayName: 'Button',

    propTypes: {
        name: React.PropTypes.string.isRequired,
        isEnabled: React.PropTypes.bool.isRequired
    },

    render() {
        const item = this.props;
        const disabled = !this.props.isEnabled;
        return (

                <button type="button" disabled={disabled}>{item.name}</button>

        );
    }
});

Here name is marked as unused. In fact, all properties accessed via temporary local variable will be flagged as unused.

I'm using props in the constructor and getting a false positive too:
class Foo extends React.Component {
  static propTypes = {
    foo: PropTypes.func.isRequired,
  }

  constructor(props) {
    super(props);

    const { foo } = props;
    this.message = foo('blablabla');
  }

  render() {
    return
{this.message}
;
  }
}

This avoids multiple unnecessary calls of foo on every render... But it foo gets marked as unused

@perrin4869 fwiw, your example will break if new props are passed; you'd need to put the same constructor code in componentWillReceiveProps, which is generally why instance vars are a bad practice in React. foo should be called on every render because it might be different, and if it's expensive, the caller of <Foo> should handle caching, not Foo itself.

@ljharb I should have mentioned I guess, that in my specific case, foo is always the same...

Just because you currently always pass the same one doesn't mean that's a good assumption to depend on.

I get false positives in this scenario:
class MyComponent extends Component {
  static propTypes = {
    shouldDoStuff: PropTypes.boolean,
    router: Router.routerShape,
  };

  componentWillReceiveProps(nextProps) {
    if (this.props.shouldDoStuff) {
      nextProps.router.push('/');
    }
  }
}

router is flagged as a prop that is defined but never used.

I've a legit usecase for that example. We've a HOC that handles validation and gives a submitted prop to its wrapped component once there has been an attempt at submitting the form. We're doing stuff in componentWillReceiveProps based on wether we're going to receive a true value in nextProps.submitted and had that exact false positive.

Counting used nextProps in componentWillReceiveProps is a clear win for this rule, certainly.

Similar to the componentWillReceiveProps example, ownProps used in mapStateToProps(while connecting with the redux store) are also not counted as used.
E.g.
function mapStateToProps(store, ownProps) {
  return {
    items: getItems(store, ownProps.visible),
  };
}

@ljharb - do you think counting this too can be considered?

mapStateToProps is a lot harder because it's redux-specific, and not tied to the component.
However, wouldn't a prop only used in mapStateToProps be a prop you want to not pass to the component?

  "rules": {
    "react/no-unused-prop-types": 0
  },

It is a pity that is the unique working way to fix that.

@ljharb - ^^ why do you say that?
May be I am missing something - if there is a prop that I need to use while mapping state to props(e.g. passing to a selector), is there a better way to do it?
FYI - the prop in question isn't in the store, if that's how the selector could have got hold of it.

Its a grand ambition to have a rule like this. JavaScript is a highly dynamic language and there is no way a static checker can detect unused props reliably. Turning it off may be the only sane and time-practical recourse. My 2 cents of course.

@prithsharma map state to props is meant to take wrapper props and state, and use them to construct a replacement props object. If the wrapped component does not need a prop, that prop should not remain in the replacement props - no other words, if the only use is in mapStateToProps, why would the wrapped component need it at all?

The propTypes describe what props the component needs in order to function and mapStateToProps is not really part of the component's class so you'd need some different mechanism for ensuring that the redux store actually contains the properties you need in order to transform them to component props.

@ljharb, @ivarni - I agree with your point. What I was trying to achieve by keeping the "only being used in mapStateToProps" prop in propTypes was to ensure that I can use React PropTypes validations to enforce the requirement of that prop. Since this prop is not a part of the props finally being used, one can better remove it from the propTypes definition, at the cost of missing the validation.
Having said that, the comments above are missing a fine detail here, the object returned by mapStateToProps is not really a "replacement" props object, since it is "merged" to the original props object.
While I don't agree that a prop being used only in mapStateToProps need not be passed to the component(given the example above), it's perfectly valid to say that mapStateToProps is not a part of the actual React component class and thus trying to validate inputs to mapStateToProps using the React component PropType validations is not usual.
Thank you for the fruitful discussion.

By now all of the issues reported here have been fixed.
Except for the first one (reported by @Eschon) where only one false positive remains handleFriendrequest.This prop is only used inside a list of components that is being generated inside a map function.
I think generally suggested react style for this is to have a separate listItem component. So i don't think we are going to fix this use case.

tbh that seems like just a poor design for getLocations; you should call it with this.props instead of including the fallback.

@ljharb it may be a weird code (I think dispatch won't ever change anyway if that's redux), but the discussion is about detecting the prop usage, which should be possible here, not about the quality of code.

I think it's a bit of both; a linter can't really determine everything - in this case, your code is branching between "sometimes props, and sometimes a random object" - this plugin shouldn't be paying attention to properties of a random object.

IMO it should be still possible to do via static analysis.

I don't think it is; nextProps must be ignored, and we can't know when getLocation will be called with one or the other.
In general, passing the props object around itself is an antipattern; partly because it inhibits linting, but partly because passing around bags of things is less clear than passing around specific things.

it doesn't matter when as long getLocation is a method of Locations class and "this.props" is used inside.
and again - it's not about something being an antipattern, but possibility of doing static analysis in this particular case

I'm telling you that as a maintainer of this plugin, it's not possible to do it reliably, because it's not always pulling off of this.props. Meaning, if there's any chance whatsoever that the destructuring is not off of a props object, then we can't pay attention to it. I'm sure we could cover your specific case, but doing so would risk doing the wrong thing for other cases, so we will not be covering your particular case. The fact that it's an antipattern means that you have a better way to write your code anyways that remove the need for extra changes in this plugin.

It's not my case :) I just joined the conversation.

a linter can't really determine everything

That sounds familiar. Did someone say so earlier? :stuck_out_tongue:
As much as I hate getting slapped around by a linter, I agree with @ljharb here. getLocations is poorly designed in this case. You can easily change the call in constructor to this.getLocations(props) and avoid this whole issue in the first place.
I like linting as much as the next person but in this case, the use case itself is not compelling. The authors do listen if there is a good use case. And linting is purely an opt-in thingy.
That said, there is no point in spamming a closed thread. If there are valid concerns, then a new issue should be opened.

It wasn't meant to be a spam, as I typed it up here:
It's easy to change this code to remove error, but I'm putting this example here as it might be a legit false positive error that needs fixing.

It wasn't meant to be a spam

Didn't mean you specifically. We're all replying to a closed thread (including myself).

as I typed it up here

Yes and as @ljharb pointed it out, its not a legit case. What I am saying is the maintainers will be more inclined to take up something that is not being debated in a closed thread with a use case that can be argued as not the most compelling example of a valid use case. Didn't mean anything personally.

I still have that kind of issue with the following code, that might be poor design, but I don't think so, feel free to tell me if it is just that:
static propTypes = {
  // That next line needs eslint-disable-line react/no-unused-prop-types
  formValues: PropTypes.shape(),
};

static defaultProps = {
  formValues: {},
};

// componentWillMont instead of constructor for this.setState to be available, matching componentWillReceiveProps call
componentWillMount() {
  // I could pass `this.props` here but that would lead to the same eslint error
  this.setDisabledSteps();
}

componentWillReceiveProps(nextProps) {
  this.setDisabledSteps(nextProps);
}

// The bug is here, object destructuring in parmeters
setDisabledSteps({ formValues } = this.props) {
  const disabledSteps = [];
  [...]
  this.setState({ disabledSteps });
}

The reason I think this should be something allowed is that this explicitly this.props that is destructured as default value.

Because sometimes that function will receive props, and sometimes it will be another object. There’s no way for the reader - or a linter - to know for sure that the props object goes down that codepath.
Instead, always destructure the props object unconditionally where you need it.

Is there really no way the linter can read { formValues } = this.props within a method parameters ?
(I have no idea how linters works)
Because here it's one key but I have an other project where there was like 15 of them needed for the function call. And "your" solution would then be:
const {a,b,c,d,e,f,...} = this.props functionCall({a,b,c,d,e,f,...});
Which is kinda messy ... :/

It can read it, but what it means is that the value of the object will only be this.props when the function is called with the first argument as missing or undefined - and “how the function is called from everywhere in your program” isn’t something a linter or a human can determine from one file :-)

Sure I totally understand the fact that we can't know if it will be called with no argument. But I mean, "argument could be this.props" should be enought for linter to say ok it might be it, let's not raise a blocking error.

I don’t think it is. The goal is to ensure that, if your code paths are executed, the props are used. with your code, i have no idea if the prop name is a prop (and been validated) or a random object property.

If some function call is within conditions, code paths might not be executed.
If a function is exported but never used, that's dead code.
But none of those will raise errors in the linter, because the linter cannot check them and so, have to be optimistic.
There is a few cases when a linter can check for dead code (code after return, etc.) but when it can't, it should be as optimistic as he can: here when looking at that code, it can see the obvious possibility of satisfying the rule.
But well I understand that this might be only my opinion. A linter is there to help, not to bridle it down. (That might not be the right word)

The linter is here to actively obstruct potential bugs - if there’s any chance something is a bug, it should not be merged as-is.

Well, to me linters are to avoid messy code (where here, it's doing the opposite) and testing is to avoid bugs but well... I guess that's again my opinion.
Thanks for your responses.


WARNING: V8 isolate was forked, it can not be disposed and memory will not be reclaimed till the Ruby process exits.

I'm getting these warnings when running rspec tests for my react on rails project.

I can only assume it's due to React on Rails as nothing else uses the mini_racer gem. Any ideas?

What does your gemfile and gemfile.lock contain?
This might be related. Using Thin? or Puma?
https://meta.discourse.org/t/development-server-consistently-dying-v8-isolate-was-forked/55878/4

It's only when running tests

one thing that dropping thin did bring up is that our silencer middlewares were not thread safe. That got super annoying in dev mode cause logs would keep getting disabled.

What does your gemfile and gemfile.lock contain?
This might be related. Using Thin? or Puma?
https://meta.discourse.org/t/development-server-consistently-dying-v8-isolate-was-forked/55878/4

Unicorn have the same issue.


Support date-based VAT rates

Support date-based VAT rates in calculate(), calculateNet(), getTaxRateForLocation()
Pass a DateTime/DateTimeImmutable object and the lib will find a rate for that date, or for current date if not specified.
From now on, new or changed VAT rates should be added using the since key which has the same structure as the "parent" key (rate, rates keys). No existing values should be changed unless they're wrong.
Reverts #92, the default DE rate is back to 0.19 and the new rate (0.16) is valid only for the interval specified.
Fix #94
This is backported from my "standalone" and "modernized" fork https://github.com/spaze/vat-calculator/pull/5

Codecov Report

Merging #95 into master will increase coverage by 0.71%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   93.86%   94.58%   +0.71%
==========================================
  Files           5        5
  Lines         212      203       -9
==========================================
- Hits          199      192       -7
+ Misses         13       11       -2

Impacted Files
Coverage Δ

src/Mpociot/VatCalculator/VatCalculator.php
93.23% <100.00%> (+1.26%)
:arrow_up:

...iot/VatCalculator/VatCalculatorServiceProvider.php
100.00% <100.00%> (ø)

...tor/Validators/VatCalculatorValidatorExtension.php
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94364d8...4a6991a. Read the comment docs.

Can this be merged, due to the upcoming Tax Rate Switch, that would be great.


Sweep funds flow

Sweep funds flow is not correct, it goes back to the same screen. Should go to the send screen.
After some time the screen goes blank when it comes back to the same screen.

After scanning the approval key it goes back to the same screen and not the send screen.
Tested on Dev App v2.0.68 (415)

https://user-images.githubusercontent.com/62699947/148954957-70f85d07-bd6d-403c-a26d-77e8a05a6a33.mp4

Sweep fund flow does not work when we try to sweep funds from Savings Account> Settings.
Tested on dev app v2.0.68(417)


Support for dnslink

Currently Bee (and the gateway-proxy) only supports ENS domains. The issue with those are that it's quite expensive to buy them but more importantly it's also quite expensive to update or modify them because of mainnet gas prices.
One idea is to support dnslink on the gateway-proxy, at least to some degree. For example if the proxy served unknown A records by looking up their dnslink TXT record then it classic DNS domains could still work but the content could be served through the proxy.

The specification of the configuration as per our meeting is the following:
There is a configuration variable called DNSLINK which is a boolean and defaults to false. When this is enabled then there is another configuration variable called DNSLINK_ALLOWED_DOMAINS which defaults to undefined or it can be a comma separated string and it contains a list of allowed domains. When there are no domains specified it tries to serve any kind of domain that it receives in the Host header of the HTTP request. Otherwise the gateway-proxy would first check if the Host header in the request matches and of the domains in the list (if not then 403) and serve that.
The feature works as a complementary feature to the CID_SUBDOMAIN and ENS_SUBDOMAIN features.

Question: If the Request is going to response 403 status, then that's the end of the request.
How would DNSLINK feature complement the CID and ENS if the request had ended at that point?


Guard site data against missing properties in API response

Closes #375 and #364.

The line change on php/Terminus/Site.php has just become redundant, but the one on php/Terminus/SitesCache.php is still very much needed and +1 to it

@TeslaDethray thanks for jumping on those other changes! I just rebased out my changes in favor of yours and will merge when CI passes.


Define behaviour wrt namespaces

Currently the controller provisions for claims in all namespaces. If it is running in-cluster it's in its own namespace...should it only provision for claims in its namespace? Or is it okay as-is, creating PVs for claims in all namespaces? I am thinking of adding a flag to toggle this behaviour
thoughts?

Nvm, one would expect the provisioner to deal with all claims asking for its class, not just claims in its namespace...


Shield Generator Wall

Rebrands the shuttle wall as the shield generator wall due to it's reflective properties. Still only has 500 HP and easily breaks when hit by HE or PF rounds. It does however reflect AP rounds away from the ship.
Not buildable by players, so it's an NPC map only thing.

"cool shader" not included

Absolutely not, Ekrixi is a game where you are forced to build upon armor layer on armor layer to protect your ship from the hostile ships that may protrude.

Again, this isn't buildable by players, so this wouldn't be a way to avoid damage without the usual 7 armor layers, but rather a reason to vary your ammunition usage when you encounter it on an enemy.

I do not want shield generator walls in Ekrixi


Train model error:

When I tried to train the model, run this line
data_generator = DriveDataGenerator(rescale=1./255., horizontal_flip=True, brighten_range=0.4)
I got an error:
File "D:\ProgramData\Anaconda\lib\site-packages\keras_preprocessing\image\image_data_generator.py", line 362, in init
'Received: %s' % (brightness_range,))
ValueError: `brightness_range should be tuple or list of two floats. Received: 0.0
It seems it needs more parameters.
How to correct it? Thank you very much!

Hello, I have encountered the same problem. Have you solved this problem?Thanks a lot！


besu node rpc returns data exception

os: ubuntu 22.04
network: mainnet
bin: ./besu-24.3.0/bin/besu --config-file=/node/full/linea/bin/config-mainnet.toml
There is a problem with besu software debug_traceBlockByHash  debug_traceBlockByNumber. Compared with geth, the data returned is abnormally large at certain times.
besu returns 200MB+ data (Some blocks are even larger)
geth returns 92KB data
curl --location --request POST '<IP_ADDRESS>:8545' \
--header 'Content-Type: application/json' \
--data-raw '{"method":"debug_traceBlockByHash","params":["0x908dc81be1f01948e7c002407e36c8401bf301d48e979e04a512e7513af79d13", {"tracer": "callTracer"}],"id":1,"jsonrpc":"2.0"}'

Maybe disableMemory could help?

How to disable Memory
I don’t see it in the command help, what should I do?

There is still a problem in the return. After turning on disableMemory, it is still very large. After turning off all three projects, the data is all meaningless.
curl -Ls -X POST -H 'Content-Type: application/json' -d '{
   "jsonrpc":"2.0",
   "method":"debug_traceBlockByHash",
   "params":[
      "0x0db7b4ae8fe16ddbeb676e0cfdcb2728f0eac64d25905e0887b178edf619fae4",
      {
         "disableMemory":true,
         "disableStorage":true,
         "disableStack":true
      }
   ],
   "id":1
}' 'http://<IP_ADDRESS>:8545'

Could you please post what you are seeing with Geth

info.txt

Issue with the size of the data returned by the debug_traceBlockByHash and debug_traceBlockByNumber methods in Besu compared to Geth, particularly when dealing with certain blocks. While Geth returns data in the range of kilobytes, Besu returns significantly larger data, sometimes exceeding 200MB.


fix: (LSD) _config.yml ralphhightower.github.io has nothing but gh-0ages and minima. Let's try that!

Configuration file: /home/runner/work/blog/blog/_config.yml
'plugins' should be set as an array of gem-names, but was: nil. Use 'plugins_dir' instead to set the directory for your non-gemified Ruby plugins.
bundler: failed to load command: jekyll (/home/runner/work/blog/blog/vendor/bundle/ruby/3.3.0/bin/jekyll)
/home/runner/work/blog/blog/vendor/bundle/ruby/3.3.0/gems/jekyll-4.3.4/lib/jekyll/configuration.rb:309:in check_plugins': 'plugins' should be set as an array, but was: nil. (Jekyll::Errors::InvalidConfigurationError) 	from /home/runner/work/blog/blog/vendor/bundle/ruby/3.3.0/gems/jekyll-4.3.4/lib/jekyll/configuration.rb:224:in validate'
from /home/runner/work/blog/blog/vendor/bundle/ruby/3.3.0/gems/jekyll-4.3.4/lib/jekyll/configuration.rb:206:in read_config_files' 	from /home/runner/work/blog/blog/vendor/bundle/ruby/3.3.0/gems/jekyll-4.3.4/lib/jekyll.rb:118:in configuration'
from /home/runner/work/blog/blog/vendor/bundle/ruby/3.3.0/gems/jekyll-4.3.4/lib/jekyll/command.rb:44:in `configuration_from_options'


VSIX fails to install when Visual Studio Team Explorer 2017 is installed

Product and Version [VS/VSCode]: VS 2017
OS Version [macOS/Windows]: WIndows 10 1709
Live Share Extension Version: Current as of May 23
Target Platform or Language [e.g. Node.js]: N/A (cant even get that far)
Steps to Reproduce / Scenario:

Install Visual Studio Team Explorer 2017 on your PC along side VS 2017.
Attempt to install the Live Share VSIX. Installation hangs. Logs indicate that it attempts to install this extension on Team Explorer and fails because of missing prereqs (obviously).

@siromega Thanks for reporting this! We haven't seen this issue before, so we'll have to take a look at it. As a workaround, if you opened up VS and tried installing Live Share via the Tools -> Extensions... dialog, does that work? As opposed to double-clicking on the vsix directly.

Hi, unfortunately I didn't get a chance to test your scenario, I just ended up removing team explorer and installed the extension again. Sorry!

@siromega No problem! So you were able to install Live Share successfully after uninstalling Team Explorer? If so, that’s great to hear 👍

I'm going to close this since you seem to have been unblocked. Please feel free to re-open the issue if you're still running into a problem. Thanks again!


Skip flaky FS test

Merely disables test for #10240

Codecov Report

Merging #10244 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10244      +/-   ##
==========================================
- Coverage   61.22%   61.22%   -0.01%
==========================================
  Files         567      567
  Lines       30868    30868
  Branches     4433     4433
==========================================
- Hits        18900    18899       -1
- Misses      10985    10986       +1
  Partials      983      983

Impacted Files
Coverage Δ

src/client/common/utils/platform.ts
70.58% <0%> (-5.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8c475...14ac525. Read the comment docs.


some mesh tests

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/jeffj6123/azure-cli-extensions.git@mesh-testing#subdirectory=src/$EXT&egg=$EXT"

@jeffj6123 the CI test is failing


Issue warning when converting composite expressions

According to the spec - the following is ok:
[ipv4-addr:value = '<IP_ADDRESS>' OR file:hashes:md5 = 'a4754be7b34ed55faff832edadac61f6']

but this is not:
[ipv4-addr:value = '<IP_ADDRESS>' AND file:hashes:md5 = 'a4754be7b34ed55faff832edadac61f6']

We need to check if when a indicator composite expression's operator is an AND that it doesn't contain multiple types.

I would say that if there is a composite indicator with AND, we should use ALONGWITH regardless of whether it's the same type or not.

how about:
file:name = 'fred.pdf' AND file:hashes:md5 = 'a4754be7b34ed55faff832edadac61f6
That seems to be a reasonable observable expression.
Also, are you assuming Composite Indicator Expressions and Composite Observable Expressions should be handled the same way or differently??

In general, a pattern in an Composite_Indicator_Expression should be handled the same as a pattern in an Observable_Composition. I'm still not sure how to handle multiple nested compositions (either an Observable_Composition in an Indicator in a Composite_Indicator_Expression, or an Composite_Indicator_Expression in an Indicator in an Composite_Indicator_Expression), but I think we can defer that for now.
My point about AND vs. ALONGWITH (or, if we change ALONGWITH to AND, AND between Comparison Expressions vs. AND between Observation Expressions) was just that you should have a single Observation Expression per CybOX 2.X Observable. So if you have:
<cybox:Observable>
  <cybox:Object>
    <cybox:Properties xsi:type="FileObj:FileObjectType">
      <FileObj:File_Name condition="Equals">fred.pdf</FileObj:File_Name>
      <FileObj:Hashes>
        <cyboxCommon:Hash>
          <cyboxCommon:Type condition="Equals">MD5</cyboxCommon:Type>
          <cyboxCommon:Simple_Hash_Value condition="Equals">a4754be7b34ed55faff832edadac61f6</cyboxCommon:Simple_Hash_Value>
        </cyboxCommon:Hash>
      </FileObj:Hashes>
    </cybox:Properties>
  </cybox:Object>
</cybox:Observable>

then it should be represented as [file:name = 'fred.pdf' AND file:hashes:md5 = 'a4754be7b34ed55faff832edadac61f6'].
But if you have the following two Observables, no matter how they are composed, you should use
[file:name = 'fred.pdf'] ALONGWITH [file:hashes:md5 = 'a4754be7b34ed55faff832edadac61f6'] (substituting AND for ALONGWITH if necessary).
<cybox:Observable>
  <cybox:Object>
    <cybox:Properties xsi:type="FileObj:FileObjectType">
      <FileObj:File_Name condition="Equals">fred.pdf</FileObj:File_Name>
    </cybox:Properties>
  </cybox:Object>
</cybox:Observable>
...somehow composed with...
<cybox:Observable>
  <cybox:Object>
    <cybox:Properties xsi:type="FileObj:FileObjectType">
      <FileObj:Hashes>
        <cyboxCommon:Hash>
          <cyboxCommon:Type condition="Equals">MD5</cyboxCommon:Type>
          <cyboxCommon:Simple_Hash_Value condition="Equals">a4754be7b34ed55faff832edadac61f6</cyboxCommon:Simple_Hash_Value>
        </cyboxCommon:Hash>
      </FileObj:Hashes>
    </cybox:Properties>
  </cybox:Object>
</cybox:Observable>

I think you overestimate the ability of users to specify observable patterns.  See the indicator with the title "GDOCUPLOAD (Family)" in APT1/Appendix_G_IOCs_full.xml.
Look at the inner "AND" composition - it corresponds to the following pattern expression:
((file:file_name = 'gdocs.exe' OR file:file_name = 'hotmail.exe' OR file:file_name = 'hotmail.exe' OR file:file_name = 'sg.exe') AND (file:size = '104448' OR file:size = '104449' OR file:size = '98304' OR file:size = '113664') AND (file:extended_properties.windows_pebinary_ext.file_header.time_date_stamp = '2011-03-18T02:41:49Z' OR file:extended_properties.windows_pebinary_ext.file_header.time_date_stamp = '2011-07-29T00:57:16Z' OR file:extended_properties.windows_pebinary_ext.file_header.time_date_stamp = '2011-03-31T03:16:31Z'))
These should all match the same file observation, and therefore need to be in ONE observable expression.

Ok, I see what you're saying. But that falls into the "multiple nested compositions" area (I should have included "Observable_Composition in Observable in Observable_Composition" in my examples above). The OR is being used to define multiple possible values for the same field. I would expect that it's hard to infer the exact intent of nested compositions in an algorithmic way, so I'd rather just emit a warning and give up.
Granted, part of the reason for this is that it was translated somewhat-literally from OpenIOC, when in fact an optimal representation in STIX 1 would have used condition="Equals" apply_condition="ANY" on a single WinExecutableFileObject, using a list of values delimited by ##comma##:
<cybox:Observable id="mandiant:observable-3cfaf45b-31a1-4f1e-a690-09f132e5c612">
  <cybox:Object>
    <cybox:Properties xsi:type="WinExecutableFileObj:WindowsExecutableFileObjectType">
      <FileObj:File_Name condition="Equals" apply_condition="ANY">gdocs.exe##comma##hotmail.exe##comma##hotmail.exe##comma##sg.exe</FileObj:File_Name>
      <FileObj:Size_In_Bytes condition="Equals" apply_condition="ANY">104448##comma##104449##comma##98304##comma##113664</FileObj:Size_In_Bytes>
      <WinExecutableFileObj:Headers>
        <WinExecutableFileObj:File_Header>
          <WinExecutableFileObj:Time_Date_Stamp condition="Equals" apply_condition="ANY">2011-03-18T02:41:49Z##comma##2011-07-29T00:57:16Z##comma##2011-03-18T02:41:49Z</WinExecutableFileObj:Time_Date_Stamp>
        </WinExecutableFileObj:File_Header>
      </WinExecutableFileObj:Headers>
    </cybox:Properties>
  </cybox:Object>
</cybox:Observable>

(notwithstanding hotmail.exe being included twice).
This would be naturally translated to a STIX 2 pattern like
[file:file_name IN ('gdocs.exe', 'hotmail.exe', 'hotmail.exe', 'sg.exe') AND
file:size IN (104448, 104449, 98304, 113664) AND
file:extended_properties.windows_pebinary_ext.file_header.time_date_stamp IN ('2011-03-18T02:41:49Z', '2011-07-29T00:57:16Z', '2011-03-31T03:16:31Z')]

But it's hard to convince the elevator to do that automatically.
I suppose we could look for the "conjunction of disjunctions" pattern --  (A or B or C) AND (D or E) AND (F or G or H) -- where all items in a given OR set use the same single field name, and collapse those into an IN Comparison Expression. Then, if all the ANDed expressions have the same root object type, combine the Comparison Expressions into the same Observation Expression.
The more I think about it, I bet it would be possible to develop some decent heuristics, but I'm still not convinced it's worth the effort.
I'm curious if @chisholm has any thoughts.

For the first 1.0 release of the elevator I would prefer to keep it simple - and not try to use a fancy heuristic to determine what the producer REALLY wants.  The dumb heuristic I'm planning is to keep as many comparison expressions within an observation expression as possible - based on the object path root.

I'm fine with that, as long as it won't lead to false negatives. False positives are OK, as is just bailing on any patterns we don't feel confident enough to convert (unless the user passes the equivalent of a --best-effort flag).

The elevator always does the "best effort", but will also always print the warning message


Blocked domain

Hello.
Maybe the domain was blaklisted before it was buyed from us, it could be possible to unblock it?

Hi there, unfortunately the domain has been tagged under pornography: https://domain.opendns.com/gayburg.com
I'm sorry that you're experiencing problems because of this. If you manage to resolve this with the OpenDNS community, it will automatically be resolved with us. We rely on the tag's from the OpenDNS community. I've filed a review-request with them, and suggest you to do the same. Cisco also uses this information in their firewalls, and there are many other services which use the same information, so it would be beneficial if you could remove this tag from the domain at OpenDNS.
Reason we filter is explained here: https://images.weserv.nl/faq/#are-there-any-limitations

Thanks!

Closing due to inactivity. Please feel free to re-open if questions remain. Thanks!


Removed 1.js, Updated README.md

1.js was not being used to removed it.
Formatted README.md

This is how people collaborate on Github :)

Thanks for the help


Bug 397 reporting to humbug reports

https://bugout.atlassian.net/secure/RapidBoard.jspa?rapidView=1&projectKey=BUG&modal=detail&selectedIssue=BUG-397&assignee=5f720fb8837bb8006801c86f

Tested


fix: fix for issue #465

@davidmurdoch the PR #547 still outputs following error:
node_modules/ganache-core/typings/index.d.ts(3,12): error TS2305: Module '"web3"' has no exported member 'Provider'.
The fix was importing as import * as Web3Provider from "web3";

Coverage remained the same at 82.177% when pulling 97f471290712389f7a936f46b95d0f61a9098aea on sushrest:fix/issue-465 into a5f43a4d666c82bce9da51f9ce1d15b6561e24f3 on trufflesuite:develop.

Closed by https://github.com/trufflesuite/ganache-core/commit/2f81da29cd13ad56b6464e0c61198538d12d7e20


Change missing folder from hard error to warning

Could Organize be updated to handle folders in the config file that are missing from disk without hard crashing the execution? Today, it throws a hard error as such:

ERROR: Path not found: /source/abc/def)
Full traceback at: /root/.cache/organize/log/organize.log

I use a service called FileThis to automatically download statements from several companies I do business with. The folder names sometimes change so I have to keep updating the rules file to even get it to run.
One thought would be to have it output a "WARNING" style message in the output and in the logs with the missing folder info, but continue processing other folders.
For instance, in the following config, if /source/abc/def is missing, we'd get a WARNING message but it would continue to process /source/abc/xyz.

utility_folders: &utility
- '/source/abc/def'
- '/source/abc/xyz'

I think this would be a good change. I'll add it to my todo-list.
On a sidenote: Maybe you tackle this problem by using the glob syntax for folders?
rules:
  - folders:
      # would match all folders ending with "...example"
      - '/source/abc/*example/*'
    actions:
      - echo: '{path}'

In my use case the folders are all names of specific accounts and sometimes have a bit of the account number at the end of the name (ex: /Some Financial Institution Account Name (...1234)/). They vary so widely that I don't think a glob match will work here.

I just released v1.6.1 with this change 👍

Thanks a bunch. I saw that my Docker image automatically rebuilt overnight. As soon as they fix the fiber connection into my house, I’ll pull the latest and give it a whirl.


fix(archiver): fix for source archiver when no files property is foun…

…d in the package.json

If no files property was found in the package.json, nodeshift would archive(tar) the current working directory.  When there was a node_modules folder in that directory, which usually happens, the archive would grow to a crazy size.

The archiver has been updated to no longer include the node_modules, .git and tmp folders.

It is still recommeneded to use the files property though.
fixes #200
i think i still need to add some tests

Coverage increased (+0.07%) to 95.94% when pulling 5b7eee398809d7c2a31d8a63470f97b716b09dc3 on lholmquist:200-tar-create-bug into 3316e6ae8856fe8477a17b2706c57b8fe1553198 on bucharest-gold:master.


GHC 9.2.8 Upgrade for ghc-hasfield-plugin

This is a PR  on a best-effort basis to upgrade ghc-hasfield-plugin to build and work with GHC 9.2.8 and it's updated package-set.
This was done as part of the larger effort to bring Euler to GHC 9.2.x ecosystem.
This package hasn't been touched or updated in a while and no one seems to actively maintain it, therefore it had a lot of breakages to fix when getting it ready to build and work with GHC 9.2.8 owing to the ghc api changes between 8.10.x -> 9.2.x
Main changes

The Shims.hs file is the file with conditional code, that compiles differently with different GHC compiler versions, relevant changes were made to fix the breakages and make it compatible with new ghc 9.2.8 API.
The main plugin HasFieldPattern.hs file, gets updated fair and square to GHC 9.2.x, this again contains relevant changes to make this compile and build with GHC 9.2.x and make it compatible and conform to the newer ghc API
Remove version bounds on dependency from project's cabal file. The versions should come from the stack or Nix package-set of the project that uses this plugin.
Bump package version to <IP_ADDRESS> -> <IP_ADDRESS>

How was this tested?

The project builds now with GHC 9.2.8, where it didn't before.
The test-suite of the project passes, like it did before it was upgraded.
The project that uses this plugin downstream seems to work fine, like it did before, intimating correct or similar behaviour as before.

Result
The project builds and tests fine after being updated to GHC 9.2.8 and it's updated package set.

Inquired with Ankur (Euler PM) whom to add as a reviewer for this PR and he mentioned that Aravind is the authority on projects under Juspay github org.
Adding @aravindgopall as a reviewer to request a review and a merge ( i don't seem to have permissions to add to the reviewers section, therefore tagging in comments )

Note:-
This PR might be redundant now, since we use @eswar2001 's fork of this repo now.
Link:- https://github.com/eswar2001/ghc-hasfield-plugin
Please let me know and i'd be happy to close this.


Added isSameDay method for #86

This adds the desired functionality in issue #86. The static method isSameDay can be used to check if two NSDates fall on the same day.

This looks great. Thanks, man!


[vcpkg baseline] Fix baseline errors

Since xmsh REPO is no longer available, set it to an empty port.

Related: #12063 #11637 #12068 etc.

@BillyONeal And The apr-util build failed because port apr archive file installed/x64-osx/build-1/apr_rules.mk cannot be found on the pipeline machine, so I think #11961 should be merged.

Hmmm should we just delete the port outright rather than letting it successfully 'install' like this?

Related issue #11923

Since xmsh REPO is no longer available, set it to an empty port.

We should never just be replacing ports with "empty" -- if the port is replaced by something else, it should have a Build-Depends:. In this case, I believe the appropriate path is:

Mark it as skipped
If 6 months pass without a user submitting a fix, we can then remove it.

pixman:arm64-windows upstream server down during build
quickfix:arm64-windows Not sure exactly what happened, will merge this to nuke tombstone to try again:
D:\buildtrees\quickfix\src\v1.15.1-5086b0da20\src\C++\stdafx.h(14): warning C4005: '_WINSOCK_DEPRECATED_NO_WARNINGS': macro redefinition
D:\buildtrees\quickfix\src\v1.15.1-5086b0da20\src\C++\test\DictionaryTestCase.cpp: note: see previous definition of '_WINSOCK_DEPRECATED_NO_WARNINGS'

itp:x64-windows: upstream server down during build
fontconfig:x86-windows: upstream server down during build
rapidxml:x86-windows: upstream server down during build
itk:x64-osx:
Undefined symbols for architecture x86_64:
  "gdcm::Rescaler::SetMinMaxForPixelType(double, double)", referenced from:
      itk::GDCMImageIO::Write(void const*) in libITKIOGDCM-5.0.a(itkGDCMImageIO.cxx.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

No idea here, it doesn't repro locally. Might be a race in itk's build itself.
fadbad:x64-linux: upstream server down during build.
As a result of the above investigation, merging this.


Update specialist publisher first_published_at from legacy dates

https://trello.com/c/L7IfKMRs/13-sanitise-specialist-content-firstpublishedat-dates
More first_published_at fun.
There are around 4832 editions which match legacy specialist publisher
db records having meaningful first published data. (The older db shows all the signs of a mass import on 2014-09-24 so I've omitted these records).
Use the legacy data to update specialist-publisher editions where possible.
==<PHONE_NUMBER>1218 ImportLegacySpecialistPublisherFirstPublishedAtDates: migrating
4832 specialist-publisher editions updated.
==<PHONE_NUMBER>1218 ImportLegacySpecialistPublisherFirstPublishedAtDates: migrated (15.3880s)

I admire your persistence with these dates Steve 👍  the database is going to be gleaming

@kevindew updated.


fix refund notify of wechat

the rule of refund notifies has been changed . It's needed to verify 'refund_status ' .

Codecov Report

Merging #99 into master will increase coverage by 0.16%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master     #99      +/-   ##
===========================================
+ Coverage     25.03%   25.2%   +0.16%
+ Complexity      252     248       -4
===========================================
  Files            29      29
  Lines           751     746       -5
===========================================
  Hits            188     188
+ Misses          563     558       -5

Impacted Files
Coverage Δ
Complexity Δ

src/Message/CompleteRefundRequest.php
0% <0%> (ø)
9 <0> (-4)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab811f...51e58bc. Read the comment docs.


[HUDI-8033] RFC-81: Hudi Data Ordering

Change Logs
RFC-81: Hudi Data Ordering
Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist

[x] Read through contributor's guide
[x] Change Logs and Impact were stated clearly
[x] Adequate tests were added if applicable
[x] CI passed

Hi @danny0405
I have submitted a new commit. Could you please take a look? Also, do I need to merge the commits?

Hi @danny0405
I have submitted a new commit. Could you please take a look? Also, do I need to merge the commits? There are quite a few now

Hi @danny0405
I have submitted a new commit. Could you please take a look? Also, do I need to merge the commits? There are quite a few now, and merging them into one could help with the review.


Update sources and ensure they can't get out of sync

Due to an issue on my end when preparing this (I had not run dep ensure) I think the first commit which updates the sources is incorrect.  So hopefully, we'll see this PR go /red/ which will prove things are working as expected.  Then I'll actually check in the correct sources.


AssignedTo

I love this app and have been able to adjust it to my needs with some other columns.  However, I'm struggling with the AssignedTo column.  I need it to be able to be assigned to only 2 people, but I can't figure out how/where to set up that group that would only include my maintenance personnel.  Can you help me with that?

@ahillr14 Hi! Is this feedback about a sample app (perhaps Helpdesk)?


picture: enabling duplication of the picture with a raw image

duplicate() function worked only for svg images. Now it is possible
to duplicate a Picture with a raw image.
contains changes from #281

Tests or Samples : #283

please check this:
https://github.com/Samsung/thorvg/pull/301


Add two-hand pickup and ability of switching hand while grabbing

One might see my old Unity3D code
For two-handed weapons one might want to add the two-hand pickup ability
Also one might want to use another hand to grab the object while holding the object with one hand

there is some work being done behind the curtain, an example of twohanded can be seen in my closed pr
https://github.com/GodotVR/godot-xr-tools/pull/478
The collision hands are partially now part of the xr tools.
Feel free to look the things up and u are very welcome to implement your ideas and share them if u feel comfortable to do so.
After all the godot xr tools are heavily driven by the community

on a furhter note, there is a simplified way to add twohanded just by editing one file
the interactable_handle.gd
https://github.com/DigitalN8m4r3/godot-xr-tools/blob/collision_hands_demo/addons/godot-xr-tools/interactables/interactable_handle.gd
`
@export_group("Optional attach Hand")
this latches the grabbing Hand onto the Interactable

Requirement: Collision Hands
Additional Note: if export paths are not set, this will be ignored
so make sure to setup the paths corresponding to hand
Example: left_hand_position = LeftHandMarker3D
Requirement: Collision Hands
@export var left_hand_position : Marker3D
Requirement: Collision Hands
@export var right_hand_position : Marker3D
Called when the handle is picked up
func pick_up(by, with_controller) -> void:
# Call the base-class to perform the pickup
super(by, with_controller)
if left_hand_position:
if with_controller.name.matchn("left"):
left_hand_position.get_node("RemoteTransform3D").remote_path = self.by_hand.get_path()
else:
right_hand_position.get_node("RemoteTransform3D").remote_path = self.by_hand.get_path()
# Enable the process function while held
set_process(true)
Called when the handle is dropped
func let_go(_p_linear_velocity: Vector3, _p_angular_velocity: Vector3) -> void:
# Call the base-class to perform the drop, but with no velocity
super(Vector3.ZERO, Vector3.ZERO)
if left_hand_position:
left_hand_position.get_node("RemoteTransform3D").remote_path = ""
right_hand_position.get_node("RemoteTransform3D").remote_path = ""
# Disable the process function as no-longer held
set_process(false)

# Snap the handle back to the origin
transform = Transform3D.IDENTITY

`
granted there are some issues but this is the fastest and it works with the current xr tools

https://github.com/GodotVR/godot-xr-tools/pull/559 adds support for swapping items between hands.

This now appears to be working quite well, and we're hoping to get a release out in the next few days.


Feature Request: Add an invariant/warning/error when calling onEnter's or onChange's callback multiple times

Found a bug in my app today that was pretty hard to spot, because of a store subscription inside onEnter that called callback multiple times.
Although behaviour is sane I think a warning here would be handy.

Same as https://github.com/reactjs/react-router/issues/3220


Specify type for req.query and req.params

Is there a way to specify types for parameters in req.query and req.params and parse them into such types? It seems they all default to string.

For req.query, depending on your query parser setting you are either using the qs module (default) or the querystring module, so the types would depend on the features of those modules. For req.params, you can use the app.param feature to parse the URL pieces into the types you are expecting.
If you are looking for further help, please stop by our support channel https://gitter.im/expressjs/express