HELP NEEDED - Crypto compliance review

In order to follow - https://github.com/nodejs/admin/blob/master/us-export-control.md
We need to:

Review the licenses in the existing repositories to confirm they are all OSI approved.
Create tooling to crawl through the GitHub repositories and Node.js to look for binaries.
Review the list of binaries and identify if they contain source code.
( For binaries that include cryptography, validate that the corresponding source code is also provided. If
it is not, either add the source code or remove the binaries.
Put a process in place that scans on a regular basis for new binaries so that they can be reviewed.

I'm opening this issue to ask for volunteers.

👋 @mhdawson. I will help out by writing the github node.js crawler if no one started with this action item already.

Create tooling to crawl through the GitHub repositories and Node.js to look for binaries.

@Bamieh sounds good, nobody has started on that.

@mhdawson I have created the tool to look for binary files across node.js repositories.
I named the repo nodejs-crpyto-compliance with the idea of possibly having everything centralized in one place (and moved to the org).
Here is a link to the repo: https://github.com/Bamieh/nodejs-crpyto-compliance
Currently we have 9 bin files across repos
terminal results

[
  {
    "path": "test/fixtures/google_ssl_hello.bin",
    "repoName": "nodejs/ffi",
    "url": "https://github.com/nodejs/ffi/blob/8dce05fa71be65b0299fc546e92ef4862158057d/test/fixtures/google_ssl_hello.bin"
  },
  {
    "path": "test/fixtures/google_ssl_hello.bin",
    "repoName": "nodejs/http2",
    "url": "https://github.com/nodejs/http2/blob/647826017edc27ac7e2b6677f50240279d5a5079/test/fixtures/google_ssl_hello.bin"
  },
  {
    "path": "test/fixtures/google_ssl_hello.bin",
    "repoName": "nodejs/node",
    "url": "https://github.com/nodejs/node/blob/db1087c9757c31a82c50a1eba368d8cba95b57d0/test/fixtures/google_ssl_hello.bin"
  },
  {
    "path": "tools/msvs/genfiles/MSG00001.bin",
    "repoName": "nodejs/node-convergence-archive",
    "url": "https://github.com/nodejs/node-convergence-archive/blob/e11fe0c2777561827cdb7207d46b0917ef3c42a7/tools/msvs/genfiles/MSG00001.bin"
  },
  {
    "path": "tools/msvs/genfiles/node_etw_providerTEMP.BIN",
    "repoName": "nodejs/node-convergence-archive",
    "url": "https://github.com/nodejs/node-convergence-archive/blob/e11fe0c2777561827cdb7207d46b0917ef3c42a7/tools/msvs/genfiles/node_etw_providerTEMP.BIN"
  },
  {
    "path": "test/fixtures/google_ssl_hello.bin",
    "repoName": "nodejs/worker",
    "url": "https://github.com/nodejs/worker/blob/eebc2622781d62125cd37a1c5ad06f26ba0a117f/test/fixtures/google_ssl_hello.bin"
  },
  {
    "path": "test/fixtures/google_ssl_hello.bin",
    "repoName": "nodejs/node-v8",
    "url": "https://github.com/nodejs/node-v8/blob/af3a4c6bddc0ba9f5ae36737b2b6616b7c50b1de/test/fixtures/google_ssl_hello.bin"
  },
  {
    "path": "test/fixtures/google_ssl_hello.bin",
    "repoName": "nodejs/node-auto-test",
    "url": "https://github.com/nodejs/node-auto-test/blob/88799dd3da95bf0e8c79c8a3e5f2db280daaaf29/test/fixtures/google_ssl_hello.bin"
  },
  {
    "path": "test/fixtures/google_ssl_hello.bin",
    "repoName": "nodejs/node-chakracore",
    "url": "https://github.com/nodejs/node-chakracore/blob/8cf4aa996118b7bc17efc2f4fdb170186d1ed3bf/test/fixtures/google_ssl_hello.bin"
  }
]

@Bamieh thanks for working on this. Great start.
A couple of things.
*) I think we need to look for more than just files with a ".bin" extension.  To be safe we should probably look for anything that does not look like a text file.  Maybe we can "whitelist" known extensions that map to text files and then everything else and files without a bin file would be considered potentially binaries?

This Review the list of binaries and identify if they contain source code. should have been
Review the list of binaries and identify if the repository contains the corresponding source code.

In terms of OSI approved I think there is a list and if we just compare against that list that should do the trick.

I think this is the OSI approved list https://opensource.org/licenses/alphabetical

@mhdawson thanks for the follow up. Do you think checking names of the licenses is enough or the content of the license must also be checked?

Review the list of binaries and identify if the repository contains the corresponding source code.

Do you think there is a way to tell that programmatically (check for Makefile/gyp maybe or something similar?) or do we have to maintain a list of repos that generate binary files from source code in the repo?

Maybe we can "whitelist" known extensions that map to text files and then everything else and files without a bin file would be considered potentially binaries?

That would be a HUGE list, do you think having a list of binary extensions is enough?
.apk - Android package file
.bat - Batch file
.bin - Binary file
.cgi or .pl - Perl script file
.com - MS-DOS command file
.exe - Executable file
.gadget - Windows gadget
.jar - Java Archive file
.py - Python file
.wsf - Windows Script File

Code is the simple part here, but I am afraid of adding extra maintenance costs on the project

@Bamieh if its easy to check the content, then that is good, however, if not I think we can trust that the name reflects the licence
How huge would the list be for text files?  Also some of the above you have a text as opposed to binary, for example a bat file is text where you can read the source from the file.  The ones we need to look for are trully binary where you can't see the source from the file itself.  From the list above I think those would be apk, com, bin, exe, gadget?, jar but probably not the others.  I think we must include those without an extension as well as those are often binary.
Can your tool generate an exhaustive list of extensions we have in the repo now and then we can see how big the list of text ones would be?

@mhdawson we have around 4k files with no extension
most of them are those:
main no extension files

AUTHORS
OWNERS
LICENCE
LICENSE
OWNERS
DEPS
INSTALL
NEWS
README
Makefile

as for the extensions, i am getting punished by github for abusing their search at this moment, I managed to crawl all files in the org except 6,091 files.
here are the extensions i managed to get (188):
list of extensions

 bin
 js
 json
 h
 py
 txt
 template
 cpp
 chromium
 md
 sh
 md5
 sha512
 c
 gn
 html
 yml
 py
 gyp
 isolate
 1
 3
 asm
 pl
 inc
 cc
 ts
 S
 mkd
 markdown
 pod
 pm
 gypi
 bat
 t
 in
 css
 ec
 hpp
 ini
 com
 rst
 xml
 csproj
 vcxproj
 wxl
 svg
 adb
 cs
 wat
 wast
 cmd
 ejs
 editorconfig
 cfg
 wixproj
 wxs
 plist
 coffee
 el
 styl
 inl
 gn
 gni
 hbs
 conf
 tmpl
 ac
 m4
 gitignore
 vim
 png
 pup
 sas
 gitmodules
 jpg
 contrib
 ads
 am
 pas
 raw
 msc
 rc
 def
 gcc
 pdf
 map
 cmakein
 yaml
 d
 stp
 mak
 lua
 sha1
 scm
 R
 man
 manifest
 qpg
 pem
 gpr
 build
 chm
 mms
 cnf
 srl
 old
 node
 reg
 reg2
 gz
 z
 test
 fail
 world
 valid
 pfx
 crt
 out
 status
 npmignore
 jst
 xclangspec
 pbfilespec
 fontified
 sln
 patch
 bnf
 num
 lis
 der
 key
 doc
 spec
 opt
 mar
 proto
 ss
 rnd
 mar
 doxy
 ors
 0
 2
 3
 5
 gitignore
 pk
 ico
 node_repl_history
 txt
 npmignore
 tern-project
 babelrc
 settings
 rnd
 pro
 mailmap
 zip
 nsi
 editorconfig
 info
 tern-port
 gitmodules
 opts
 tm_properties
 eslintignore
 gif
 tar
 tgz
 exe
 lock
 SSLeay
 mcp
 as
 dif
 crl
 mul
 xs
 sol
 lnx
 fre
 clang-format
 gn
 pyl
 dat
 golden

Turning out to be even more interesting job than I thought it might be.  It might make sense to clone some subset and see how well we can search/exclude files on those before we do the whole set.
Your example of being able to exclude 4000 files based on the name is interesting, I'm guessing we will need to see how far we can push that. One other idea might be that if we scan the files and can figure out if is a text file or not from the scan.

@Bamieh just wondering if you have made any more progress on this front?

@mhdawson I have some time to work on it again this weekend

Pinging the thread to see if we still need a compliance review process for crypto 🔐

@keywordnew we do still need to make progress on this.  @bnb had mentioned he might have some time/interest on working on it.

@bnb The challenge required exponentially more time than I anticipated. I'd be happy to share my progress if you wish to work on it.

@mhdawson, is this still required? Unclear from the linked issue in admin – do we have a legal liability by not completing this review?
Also from the linked issue:

PENDING: Will we solicit volunteers review the licenses in the existing repositories, and if not completed by Dec 2018 we will ask the Node.js Foundation to hire a contractor to complete the review.

Thoughts on how to move forward?

This is something we should do.  It was a request from the previous Executive director.  I'm not sure about "liability" but it was stated as a "best practice".   It is probably time to loop back with the Foundation to see if they believe we should use Foundation resources to move it forward.

@mhdawson, happy to write the email to get that started – which Foundation contact would be best to ping?

I think at this point it would be Mike Dolan. Thanks for putting together the email.  If you need any context just let me know and I'll try to fill it in. The original work to put the process in place was done on request of Mark Hinkle a while back.

@mhdawson do you have any updates on this? Specifically, what is still pending and what does CommComm itself need to do?

I've reached out to @brianwarner and @rginn to see if we can get some additional guidance and possibly help.

I have a meeting later this week to learn how this has been handled in other projects.  I'll report back!

@brianwarner @mhdawson is there anything else left for us here to do? Is this something specifically CommComm needs to look at / prioritize? This is approaching 2 years old and hasn't seemed to meaningfully generate any kind of output. If there's nothing explicit to be done I'd request that we close it.

@bnb yes, its still not been addressed so I don't want to close and completely forget about it.
@brianwarner has the current action to see if we can get the Foundation to help out.

I guess I could move the issue to the TSC repo if you believe CommComm does not need to be involved.

@mhdawson if this is a foundation task does it potentially make sense to move it into the CPC?

@bnb it is specific to Node.js in this case, although helping with a similar issue applies to other projects as well.

How about I move it to the admin repo?

@mhdawson that would be fair.


Spinstallprereqswithoutciminstance

Remove Get-CimInstance -ClassName Win32_Product and use the
get-itemProperty with HKLM regedit

This change is

Hi @luigilink, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;


Tower of Hanoi in C

💥 Proposal
I am making famous Tower of Hanoi using C code
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


Fix type extraction with asymetric operators

How about a changelog entry for this one? It is a user-facing bugfix after all.

It just came to my mind that the type extractors are not the only case where this is a problem. What about key extrators? IIRC, if we have a query like orig_h == <IP_ADDRESS>, then the index will go over all types where orig_h is valid suffix (e.g., conn, http, smtp, etc.) and also make a disjunction of them.
Would you mind double-checking that this bug doesn't apply to other extractor types as well?

It just came to my mind that the type extractors are not the only case where this is a problem. What about key extrators? IIRC, if we have a query like orig_h == <IP_ADDRESS>, then the index will go over all types where orig_h is valid suffix (e.g., conn, http, smtp, etc.) and also make a disjunction of them.
Would you mind double-checking that this bug doesn't apply to other extractor types as well?

I don't think I understand what you are saying. If we have multiple types with the same suffix they are usually in different tables, like your examples with conn, http, smtp. If we do have a record with the structure record{ orig.host: addr, resp.host: addr }, then we might have a problem there. Is that what you mean?

So for key extractors this is problem does exist as shown by the newly added tests. Commit
https://github.com/vast-io/vast/pull/460/commits/9260ea0256a33f6bc2799cd59afb0766b405711e also contains the fix.


Getting error  react native 0.68 on android (Plugin with id ‘maven’ not found. )

I am getting error when buil project on android.
build.gradle file error Plugin with id ‘maven’ not found.
Please help me.

face the same issues here

Same issues here

Same issue here

any solution

Same issue here

face the same issues here

I am facing the same issue as well
I am using Expo Managed Workflow for my app
Expo SDK: 46
React Native Version: 0.69.6

go to nodemodule and change maven to maven-publish

go to nodemodule and change maven to maven-publish

Has anyone tried this solution?

Yes go to you node module and search same pack name and go to build.gradle and search maven and change maven to maven-publish

@MrAbhishekSingh are you using expo managed workflow?

@MrAbhishekSingh are you using expo managed workflow?

No,it's react native cli

go to nodemodule and change maven to maven-publish

Thank you, it's worked for me

node_modules\react-native-ip-sec-vpn\android\build.gradle' line: 152
Configuration with name 'compile' not found.
how to fix this?

what version of react are you using?
iam try 0.68.2 and 0.69.6 but not work.
when i change maven to maven-publish it just creates a new problem:

Configuration with name 'compile' not found.
Could not find mavenDeployer() for arguments.

what version of react are you using?
iam try 0.68.2 and 0.69.6 but not work.
when i change maven to maven-publish it just creates a new problem:

Configuration with name 'compile' not found.
Could not find mavenDeployer() for arguments.

Can you share me the actual problem with screen shot

Can you share me the actual problem with screen shot

Configuration with name 'compile' not found.

Just go to down in same page and comment out the code ..you can take ref from this image

If you are developing VPN app so you can use this library:-. https://www.npmjs.com/package/react-native-simple-openvpn

Can you explain in more detail which lines should I comment out?
I see your image is broken.
i had success with react-native-simple-openvpn.
but somehow its not working after release on playstore.

You have some line added in your project then you can build. Your app its also work on in playstore.
You can read this page and add that line in your project it's will help for you..
https://stackoverflow.com/questions/71206844/vpn-is-not-connecting-after-uploading-android-app-bundle-aab-to-play-store
Some day ago I'm also faced same problem in my app not working after deployed on playstore
But now it's working:- https://play.google.com/store/apps/details?id=com.uaevpn

Wow shocking news.
I deleted the project and don't have a backup after trying to repair and upload it up to 3x to playstore. it took about 7days to see results from playstore with results they ask for a video how to run it. maybe that's why they suspect that my app is spam.

yes i also see react-native-ipsec-vpn gives the same argument.
android.bundle.enableUncompressedNativeLibs

release thx
https://play.google.com/store/apps/details?id=com.bimlind.vpn

You have some line added in your project then you can build. Your app its also work on in playstore. You can read this page and add that line in your project it's will help for you.. https://stackoverflow.com/questions/71206844/vpn-is-not-connecting-after-uploading-android-app-bundle-aab-to-play-store
Some day ago I'm also faced same problem in my app not working after deployed on playstore But now it's working:- https://play.google.com/store/apps/details?id=com.uaevpn

release thx
https://play.google.com/store/apps/details?id=com.bimlind.vpn

I have new package for this please use this. best for both android and iOS .
https://github.com/shadow-boy/react-native-vpn-ipsec

user authentication failed in release mode, but working in debugging mode fine,  https://github.com/shadow-boy/react-native-vpn-ipsec

I have new package for this please use this. best for both android and iOS . https://github.com/shadow-boy/react-native-vpn-ipsec

user authentication failed in release mode, but working in debugging mode fine ,in this package


Extension - Do not show balance when making transactions

Describe the bug
Check for rate limit errors that result in balances not being displayed when making transactions
Actual: Do not show transferable when performing transaction

Version test: http://<IP_ADDRESS>:8900/s/m8FtXsc9XgxTcr3
Validation passed

Show balance on Tokens/ Token details
Show balance when performing transactions
Transfer
Send NFT
Swap
Earning

Staking/Stake more
Unstake/Cancel unstake
Withdraw
Claim reward

Check balance after performing the transaction


feature: Added way to efficiently navigate through already known JSON

With my change all users of the lib would be able to efficiently navigate through JSON in Builder-like methods.
Example (from the Test)
ParseResult result = Jsoner.deserializeWrapped("{\"first\": 123, \"second\": [{\"k1\":{\"id\":\"id1\"}}, 4, 5, 6, {\"id\": 123}], \"third\": 789, \"id\": null}");
Assert.assertEquals(result.get("first").asInt(), 123);
Assert.assertEquals(result.get("second").get(0).get("k1").get("id").asString(), "id1");
Assert.assertEquals(result.get("second").get(4).get("id").asInt(), 123);
Assert.assertEquals(result.get("second").get(1).asInt(), 4);
Assert.assertTrue(result.get("id").isNull());

Thanks for the pull request! I've got a lot of projects I'm juggling right now but I'll look into merging this when I get a chance. Hopefully be the end of the year.

I (finally) was able to further review these changes. As the intention of this code is for when the developer knows the structure of their JSON, it makes most sense to simply call deserialize that takes the JSON string and a default JsonArray or a default JsonObject respectively. Then use the getCollection (for JsonArray) and getMap (for JsonObject) methods in the JsonArray and JsonObject to further navigate nested values or use the other gets for JSON values that are not a JsonArray or JsonObject. Please reach out if you have questions or suggestions.
See:
https://cliftonlabs.github.io/json-simple/target/apidocs/com/github/cliftonlabs/json_simple/Jsoner.html#deserialize-java.lang.String-com.github.cliftonlabs.json_simple.JsonArray-
https://cliftonlabs.github.io/json-simple/target/apidocs/com/github/cliftonlabs/json_simple/Jsoner.html#deserialize-java.lang.String-com.github.cliftonlabs.json_simple.JsonObject-


Run script on notification receive

It could be handy to have a script being called for each new notification. This would allow to format notification bodies that contain more than plain text (like HTML).

I like the idea of this.  Just trying to figure out how to implement it while introducing as little bloat as possible.
Something to consider is that I think Wired can already sort of do this using the print_to_file config option.  You could read notification as they come in, and adjust and then send a new notification replacing the existing one using notify-call and using the ID.
I agree that this could be a lot more pleasant to do though, and it doesn't help that notify-send doesn't natively support replacing.

Replacing could be an option, although less elegant than pre-processing the notification with a hook. It all depends on how much work this takes to implement.

This is only roughly related, but I just noticed that Wired mistakenly has the body-markup capability.  I've removed it now which should inform programs not to send markup.
We still want to do the script thing eventually, but this might fix your intermediary issue.

That can be a good solution. I'll try it out as soon as I can.


Svelte component binding gets undefined after using Controls

Describe the bug
When using Histoire Controls every Svelte component binding in the Story gets undefined.
Reproduction

Open https://stackblitz.com/edit/histoire-svelte3-starter-xegtp3?file=src/SvelteBindThis.story.svelte
Select Story 'BindThisVsControls'
Check 'Disabled' in the Histoire Controls Panel

Result: Value of button gets undefined :(
Expected Result: Button reference should not change
System Info
System:
    OS: Linux 6.0 Arch Linux
    CPU: (8) x64 AMD Ryzen 5 2500U with Radeon Vega Mobile Gfx
    Memory: 14.62 GB / 31.06 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 18.11.0 - ~/.nvm/versions/node/v18.11.0/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 8.19.2 - /.../node_modules/.bin/npm
  Browsers:
    Chromium: 106.0.5249.119
    Firefox: 106.0.1
  npmPackages:
    @histoire/plugin-svelte: ^0.11.5 => 0.11.6
    histoire: ^0.11.5 => 0.11.6
    vite: ^3.0.3 => 3.2.1

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion.
[X] The provided reproduction is a minimal reproducible example of the bug.

This also happens to me.


Add docosaurus as the first docs version

Add docosaurus as the first docs version

Closed thanks to your pull request #23! 😎


Potentially IDOR vulnerability in JWTAuthentication class

Hello I think I found a new security issue in the JWTAuthentication class, I would like to discuss it here and see if my theory is valid before submit it.
The JWTAuthentication class  contains a critical Insecure Direct Object Reference (IDOR) vulnerability. The get_user method retrieves a user object based solely on the USER_ID_CLAIM from the validated token, without performing any additional authorization checks.
This design assumes that possession of a valid token implies authorization for all actions related to the user_id in that token, which is a flawed security model. The vulnerability is further exacerbated by the JWTStatelessUserAuthentication class, which creates a
TokenUser object directly from token claims without any database lookup or further authorization checks.
The default_user_authentication_rule function only verifies if the user exists and is active, not considering user permissions or roles. While the CHECK_REVOKE_TOKEN feature provides some mitigation by checking if the user's password has changed, it doesn't prevent the core IDOR issue. An attacker could exploit this vulnerability by obtaining a valid JWT for their
account, modifying the USER_ID_CLAIM to target another user's id, and making API  requests. The server would authenticate the request based on the valid token signature and retrieve data for the specified user id, regardless of whether the
authenticated user should have access to that data. This could lead to unauthorized access to sensitive user information, potential data breaches, and violation of user privacy.
 def get_user(self, validated_token: Token) -> AuthUser:
        """
        Attempts to find and return a user using the given validated token.
        """
        try:
            user_id = validated_token[api_settings.USER_ID_CLAIM]
        except KeyError:
            raise InvalidToken(_("Token contained no recognizable user identification"))

        try:
            user = self.user_model.objects.get(**{api_settings.USER_ID_FIELD: user_id})
        except self.user_model.DoesNotExist:
            raise AuthenticationFailed(_("User not found"), code="user_not_found")

        if not user.is_active:
            raise AuthenticationFailed(_("User is inactive"), code="user_inactive")

        if api_settings.CHECK_REVOKE_TOKEN:
            if validated_token.get(
                api_settings.REVOKE_TOKEN_CLAIM
            ) != get_md5_hash_password(user.password):
                raise AuthenticationFailed(
                    _("The user's password has been changed."), code="password_changed"
                )

        return user

POC

Obtain a valid JWT token for your account.
Decode the JWT (without verifying the signature) to access its payload.
Modify the value of the USER_ID_CLAIM in the payload to the ID of a target user.
Re-encode the JWT (the signature will be invalid, but that's not checked in this vulnerability).
Send an API request with the modified JWT in the Authorization header.
The server will process the request and return data for the target user, despite the
JWT being for a different user.
Example HTTP request: GET /api/user/profile
HTTP/1.1 Host: example.com Authorization: Bearer
eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoiVEFSR0VUX1VTRVJfSUQiLCJleHA
iOjE2MTY3NjY2MjB9.INVALID_SIGNATURE

IMPACT
This issue could potentially lead to unauthorised access to users personal information, the only thing that one attacker has to do is to find a valid USER ID.

maybe im not quite understanding correctly, but how would this work when the JWT token is signed with the private key and then verified ? does this somehow work around the JWT signature verification?

I believe the claim is “should a user not be verifying the JWT’s signature” then it’s a vulnerability. But in that case the issue is deeper as any trust in any of the claims would then be invalid. The JWT system is only validating anything securely if the signature is validated (and the key isn’t leaked)I’m also not sure how JWT (where the whole point is that the token (once signature verified) can be trusted to have authorised signed data in it could ever work in the real world without using the value of the claims inside. You would have to otherwise go back to the user database every time and not just using your local “this user id has permission for x”RegardsAlexanderAlexander NeilsonNeilson Productions Limited021 329 @.*** 4 Nov 2024, at 13:06, Adam LeVasseur @.***> wrote:
maybe im not quite understanding correctly, but how would this work when the JWT token is signed with the private key and then verified ? does this somehow work around the JWT signature verification?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>


VAT-ID per-customer vs. per-address

PHP Version
7.4.30
Shopware Version
<IP_ADDRESS>
Expected behaviour
it seems that the back-end data model supports EU-VAT-ID as a property per address (ee order.deliveries[0].shippingOrderAddress.vatId).  This is correct, as a single customer may have multiple delivery addresses in different countries, and hence different VAT-IDs per country.
Actual behaviour
It seems that the VAT ID entered by the customer in the default storefront is not stored/reportred in the order.deliveries[].shippingOrderAddress.vatId (nor in the order.billingAddress.vatId) but it is stored in the order.orderCustomer.vatIds[] list.
At least when queryin the order via the API (for example to export it into the company ERP system), I see this odd behaviour.
How to reproduce
Default shopware <IP_ADDRESS> installation with default storefront.  Just enable the B2B tax-free shipping for a few EU countries and place an order via the frontend, then query that order ID via the API.

just vote :) https://issues.shopware.com/issues/NEXT-20028

thanks, I just did. Was not aware there was a related issue on shopware.com already.  I find it rather shocking that such an (from my point obvious) feature existed and was deliberately removed.  Also, the fact that the shippingOrderAddress model still contains a vatId field that's no longer populated (without mention in the API docs or anywhere) is quite misleading.

Hello,
Within our company roadmap and work capacity, we try to address each bug or improvement request but admit that not each one will be resolved. To continue our culture of honesty and openness, we are closing this issue to focus on our roadmap on behalf of all Shopware users.
If you feel like this issue is still impacting you, please create a new issue and let us know.
Thank you again for your valuable feedback.


Pastes twice

Description
Ctrl+v or Shift+Insert always paste two copies of the same content. Especially pictures copied from other web pages (pictures copied from local files to the clipboard will not be).

I see this behavior, but only when pasting images as attachements in notebook cells.

Can you confirm that this doesn't happen in an jupyterlab wihtout jupyterlab vim installed?

Sorry I realized I was running an older version of jupyterlab, I updated to 3.4.1 and cannot reproduce this with jupyterlab_vim 0.15.1 installed so maybe this issue can be closed?

I understand that this has been resolved. Please reopen or open a new issue if you're still experiencing this issue.


3.0.9 Displacement filter and pixelate Filter incompatible !

If i add the Displacement filter and the Pixelate filter to the same sprite the pixelate will not work !
https://jsfiddle.net/6w0kuqko/5/

If you swap the order of the filters in the array it works!

yes thanks. I think a fix will be good anyway but this will solve my problem :)

looking into this now.. thanks for providing a fiddle to test 👍

fixed in v4 (dev)

@GoodBoyDigital, not sure if this ever made it to release, but the pixelate filter does not work as of v4.3.0. The current state is identical to that in the fiddle provided above.

@tmanderson is that instead possibly related to pixijs/pixi-filters#4?

@staff0rd, ah – yes, it would be! That'll do for now, thank you!


Support BigQuery partitioned tables

The current client libraries do not support table partitioning. In particular, CreateTableOptions should allow clients to set partitioning options for the created table:
https://cloud.google.com/bigquery/docs/creating-partitioned-tables
Requested by a user over here:
https://code.google.com/p/google-bigquery/issues/detail?id=872

Thanks, that looks like it's eminently feasible. I probably won't provide explicit support for it on BigQueryTable, as BigQueryTable.Resource already exposes the relevant resource. I'll demonstrate that in a snippet though.

Thanks Jon for a quick fix. Will use it right away!

My pleasure. We're in the middle of a few other changes which make it slightly non-optimal to release a package right now (and I'm at a conference today) but I can add it to my work queue if a packaged version would unblock you. Otherwise, you could certainly fetch from github and package it yourself, if you're happy to do that.

Fresh nuget would be nice. What is your timeline on releasing new one anyway?

We may well have a fresh version of GAX within this week, to support the streaming work for Speech (see various PRs)... while we don't need the new version of GAX for BigQuery, it probably makes sense to put my Release Engineering hat on just once in the week, so to speak. If we can get a BigQuery release out this week (by Thursday evening UK time - I don't like releasing on a Friday) would that work for you?

That is fine, thank you.

The new version - 1.0.0-beta08 - is now live on nuget.org


我跑自己的数据集  然后输出各个类别  结果会少一个 数据集的category从1开始的 会不会有什么影响

Prerequisite

[X] I have searched the existing and past issues but cannot get the expected help.
[X] I have read the FAQ documentation but cannot get the expected help.
[X] The bug has not been fixed in the latest version.

🐞 Describe the bug
test输出类别少1
Environment
11
Additional information
No response

I do not quite get your question, could you be more specific?

I do not quite get your question, could you be more specific?

首先感谢你的关注。我有四个类别，但是输出的各个类别mAP只有三个  数据集中的注释它的cetegory是从1到4的

What modification did you made to the code? This might because some part is not updated.


Unable to setup rustanalyzer

Hi, I am having difficulties in getting rustanalyzer to function properly using your script. I was able to get it to function properly in the past using one of your older scripts. I am unsure as to what has radically changed and render rustanalyzer unable to function properly for me.
File extension has been changed to .txt to allow for the file to be attached to this issue.
init.txt
init_old.txt
For whatever reason, my old config no longer functions ever since I used the newest version of kickstart.

The config you provided is not up to date with the master branch. After uninstall and then reinstall rustanalyzer. I would additionally check if your neovim is up to date as well. After see if that fixes the issue.

I had recently updated the config today. What part of it is not up to date?
rustup update provides the following output:
warning: downloading with complete profile isn't recommended unless you are a developer of the rust language
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'
info: latest update on 2024-07-25, rust version 1.80.0 (051478957 2024-07-21)
info: checking for self-update

  stable-x86_64-pc-windows-msvc unchanged - rustc 1.80.0 (051478957 2024-07-21)

info: cleaning up downloads & tmp directories

rustup component add rust-src provides the following output:
info: component 'rust-src' is up to date
Per your instructions, I have downloaded and setup the kickstart init.lua file to support rust again.
The uploaded file extension has been changed to .txt to allow for the file to be attached to this issue.
init.txt
After doing so, rust_analyzer is still not working and behaving as expected.
My neovim and neovide installations are up to date.
One thing that I have noticed is that when I edit the init.lua config file, a small message of "loading the workspace" and "lua_ls" will appear in the lower right hand corner. After a few seconds, a green checkmark will appear and the messages will disappear.
When I attempt to edit a .rs file, the messages "Completed Fetching, Completed Indexing, rust_analyzer" will appear and disappear after a few seconds. However, a green checkmark does not appear. In the past, the green checkmark would be present and rust_analyzer would behave as expected.

Hi I'm sorry you're having trouble but rust-analyzer is working great for scads of people.
Please try a fresh check-out of stock kickstart.nvim.

Can you please explain what exactly doesn't work with rust_analyzer?
There are situations when rust_analyzer breaks because of rust version change, so please also try cargo clean.

I did some more testing and found that rust_analyzer does function as expected (code completion, warning / error messages for syntax errors or bad code, etc.) for my organized code that has a cargo file or was initially generated using cargo new
For raw code or files without a cargo file or was probably not initially generated using cargo new, rust_analyzer appears to startup but never displays a checkmark in the lower right hand corner.
Was this behavior always the case?


Unable to backup switch emulator saves

Ludusavi version
v0.21.0
Operating system
Linux
Installation method
Archlinux Aur
Description
Ludusave fails to backup some Yuzu saves and Ryujnix save
Saying unable to get mtime:  and Failed to get mtime in zip format in the logs
Logs
ludusavi_r2023-11-12_02-21-23.log

ludusavi tries to store modification times (which are important for some games recognizing the most recent save, e.g. Factorio) within the backup.zip and apparently fails.  Looking deeper, it is zip::DateTime::from_date_and_time used in StrictPath::get_mtime_zip which returns an error - it does that only if it gets strange values for year, month, etc.
A quick workaround is to disable backup compression until this is fixed / better understood.

Can you please post the result of:
ls -l --time modification --time-style full-iso \ /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/*bin
?

[zany130@Garuda-Linux ~]$ ls -l --time modification --time-style full-iso /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/*bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_187.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_225.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_227.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_229.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_231.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_233.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_235.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_237.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_64.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_65.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-12-31 19:00:00.000000000 -0500 /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_66.bin

guessing this is the issue it doesn't like have it has a date stamp of 1969

Yup, thats the cause.  The library checks the date like this:
        if (1980..=2107).contains(&year)
            && (1..=12).contains(&month)
            && (1..=31).contains(&day)
            && hour <= 23
            && minute <= 59
            && second <= 60
        {
...

So you can "fix" it by touching your files with
find . -exec touch --time=mtime  {} \;

which should set the modification time for all files and folders within the current folder (.) and all folders below to the current system date.

Seems to be a general problem with zip files, they don't support years earlier than 1980:
https://stackoverflow.com/a/3726120/3079262

Thanks for looking into this, @sluedecke :)
Maybe Ludusavi should store the modified time in manifest.yaml after all, at least for zip files. On the other hand, I have no idea why Yuzu would be creating files with year 1969 in the first place.

I agree, manifest seems to be the best place for this information since zip is limited here.

I suspect Unix epoch which starts at 1970, Jan 1st. The timestamps above are at GMT-5 so probably they are a result of unpacking from an archive format which did not store a timestamp.

I was looking at all the files with a bad time stamp and they all came from a backup from my switch so it seems that is what happend
Unfortunately I tried

So you can "fix" it by touching your files with
find . -exec touch --time=mtime  {} \;

which should set the modification time for all files and folders within the current folder (.) and all folders below to the current system date.

and while the files do now have a current time stamp
/home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_187.bin
-rw-r--r-- 1 zany130 zany130<PHONE_NUMBER>-11-15 15:07:19.546115500 -0500

Ludusavi is still failing to back them up with the same error
[2023-11-15T18:58:21.588Z] ERROR [ludusavi::scan::layout] [Ryujinx Saves] unable to get mtime: /home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_187.bin -> drive-0/home/zany130/.config/Ryujinx/bis/user/save/0000000000000002/0/save_data/mii/mii_187.bin | Failed to get mtime in zip format

Thanks for trying the fix.  The result is strange, I was expecting it to work now - I could not find any "obvious" cause for this in the source code, but my understanding might be limited.
Are you able to compile ludusavi yourself?  With a small patch with more debugging info we might get some more insight into this situation.

Sure could you send the patch? ill apply it and compile it

Great, here is a small patch which hopefully sheds some light on the situation.  Sorry for the long wait, christmas season is on and things are slow right now.
diff --git a/src/main.rs b/src/main.rs
index 4bb4c78..066a6e0 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -27,6 +27,7 @@ fn prepare_logging() -> Result<flexi_logger::LoggerHandle, flexi_logger::FlexiLo
     flexi_logger::Logger::try_with_env_or_str("ludusavi=warn")
         .unwrap()
         .log_to_file(flexi_logger::FileSpec::default().directory(app_dir()))
+        .duplicate_to_stdout(flexi_logger::Duplicate::All)
         .write_mode(flexi_logger::WriteMode::Async)
         .rotate(
             flexi_logger::Criterion::Size(1024 * 1024 * 10),
diff --git a/src/path.rs b/src/path.rs
index 951710e..00cf788 100644
--- a/src/path.rs
+++ b/src/path.rs
@@ -408,6 +408,15 @@ impl StrictPath {
             mtime.second() as u8,
         );

+        // NOTE.2023-11-29 Excessive logging to investigate ##280
+        log::warn!(
+            "[{self:?}] mtime for zip. pathbuf: {:#?} // interpreted: {:#?} // metadata: {:#?} // mtime: {:#?}",
+            self.as_std_path_buf(),
+            self.interpret(),
+            self.metadata(),
+            mtime
+        );
+
         match converted {
             Ok(x) => Ok(x),
             Err(_) => Err(Box::new(std::io::Error::new(

Output should look something like this:
cargo run -- backup "Dead Cells"
    Finished dev [optimized + debuginfo] target(s) in 0.13s
     Running `target/debug/ludusavi backup 'Dead Cells'`
Are you sure you want to proceed with the backup? New save data will be merged into the target folder:

Are you sure you want to proceed with the backup? New save data will be merged into the target folder:

/home/MYUSER/Games/00-savegames/0-ludusavi-backup yes
INFO [ludusavi::scan::launchers::lutris] Unrecognized Lutris game: 'GOG Galaxy' (slug: 'Some("gog-galaxy")')
INFO [ludusavi::cli] beginning backup with 1 steps
Scan (00:00:00) █████████████████████████████████████████████████████████████ Games: 1 / 1INFO [ludusavi::scan::layout] [Dead Cells] creating a Full backup: backup-20231129T214234Z.zip
WARN [ludusavi::path] [StrictPath { raw: "/home/MYUSER/Games/Dead Cells/game/save/user_0.dat", basis: None }] mtime for zip. pathbuf: "/home/MYUSER/Games/Dead Cells/game/save/user_0.dat" // interpreted: "/home/MYUSER/Games/Dead Cells/game/save/user_0.dat" // metadata: Ok(
    Metadata {
        file_type: FileType(
            FileType {
                mode: 33188,
            },
        ),
        is_dir: false,
        is_file: true,
        permissions: Permissions(
            FilePermissions {
                mode: 33188,
            },
        ),
        modified: Ok(
            SystemTime {
                tv_sec:<PHONE_NUMBER>,
                tv_nsec: 11004402,
            },
        ),
        accessed: Ok(
            SystemTime {
                tv_sec:<PHONE_NUMBER>,
                tv_nsec: 748204387,
            },
        ),
        created: Ok(
            SystemTime {
                tv_sec:<PHONE_NUMBER>,
                tv_nsec: 748204387,
            },
        ),
        ..
    },
) // mtime: 2023-11-07T18:12:34.011004402Z
INFO [ludusavi::scan::layout] [Dead Cells] backed up: /home/MYUSER/Games/Dead Cells/game/save/user_0.dat -> drive-0/GAMESDIR/Dead Cells/game/save/user_0.dat
...

ludusavi_rCURRENT.log
[2023-12-01T00:13:40.175Z] WARN [ludusavi::path] [StrictPath { raw: "/home/zany130/.config/Ryujinx/bis/user/save/0000000000000003/1/system.bin", basis: None }] mtime for zip. pathbuf: "/home/zany130/.config/Ryujinx/bis/user/save/0000000000000003/1/system.bin" // interpreted: "/home/zany130/.config/Ryujinx/bis/user/save/0000000000000003/1/system.bin" // metadata: Ok(
    Metadata {
        file_type: FileType(
            FileType {
                mode: 33188,
            },
        ),
        is_dir: false,
        is_file: true,
        permissions: Permissions(
            FilePermissions {
                mode: 33188,
            },
        ),
        modified: Ok(
            SystemTime {
                tv_sec: 0,
                tv_nsec: 0,
            },
        ),
        accessed: Ok(
            SystemTime {
                tv_sec:<PHONE_NUMBER>,
                tv_nsec: 0,
            },
        ),
        created: Ok(
            SystemTime {
                tv_sec:<PHONE_NUMBER>,
                tv_nsec: 282823221,
            },
        ),
        ..
    },
) // mtime: 1970-01-01T00:00:00Z
[2023-12-01T00:13:40.175Z] ERROR [ludusavi::scan::layout] [Ryujinx Saves] unable to get mtime: /home/zany130/.config/Ryujinx/bis/user/save/0000000000000003/1/system.bin -> drive-0/home/zany130/.config/Ryujinx/bis/user/save/0000000000000003/1/system.bin | Failed to get mtime in zip format
[2023-12-01T00:13:40.175Z] WARN [ludusavi::path] [StrictPath { raw: "/home/zany130/.config/Ryujinx/bis/user/save/0000000000000003/1/01_save.ico", basis: None }] mtime for zip. pathbuf: "/home/zany130/.config/Ryujinx/bis/user/save/0000000000000003/1/01_save.ico" // interpreted: "/home/zany130/.config/Ryujinx/bis/user/save/0000000000000003/1/01_save.ico" // metadata:
    Metadata {
        file_type: FileType(
            FileType {
                mode: 33188,
            },
        ),
        is_dir: false,
        is_file: true,
        permissions: Permissions(
            FilePermissions {
                mode: 33188,
            },
        ),
        modified: Ok(
            SystemTime {
                tv_sec: 0,
                tv_nsec: 0,
            },
        ),
        accessed: Ok(
            SystemTime {
                tv_sec:<PHONE_NUMBER>,
                tv_nsec: 0,
            },
        ),
        created: Ok(
            SystemTime {
                tv_sec:<PHONE_NUMBER>,
                tv_nsec: 282823221,
            },
        ),
        ..
    },
) // mtime: 1970-01-01T00:00:00Z

Thank you!  So the modification time still is set to 0 and the error occurs.
Maybe I was wrong about the parameters for the touch command, sorry I was wrong here - the manpage is a bit unclear about this:
      --time=WORD
              change the specified time: WORD is access, atime, or use: equiv‐
              alent to -a WORD is modify or mtime: equivalent to -m

Can you give it another shot and do this?

run find . -exec touch -m {} \;
make a backup

Yup that fixed it thanks !

I've added a workaround to round up dates before 1980. I'll still probably look into storing the mtimes in mapping.yaml at some point, but I think this should be fine for now, at least until 2107 😅

Nice, another issue closed :)
It seems to be a rare edge case, so I think a note in the readme is probably sufficient for the next years.


Use whitelisted token volumeUSD for non-whitelisted token instead of 0

Context
getTrackedVolumeUSD() returns [token0VolumeUSD, token1VolumeUSD, token01Average]. As of now, if either token is not whitelisted, its volumeUSD will be 0.
Problem
Pools made of a non-whitelisted/whitelisted input token pair get their dailyVolumeByTokenUSD and hourlyVolumeByTokenUSD values zeroed for the non-whitelisted token.
This is because we return a 0 volumeUSD if the token is not whitelisted.
Proposal
In those cases we can default to the whitelisted token volumeUSD, since they should be really close in value in practice.
An alternative, in case we prefer to keep the this out of the price module, and to make it explicit that the 0 volume means the token is not whitelisted, we could move this logic to here instead. Doing something like defaulting to the average, which is the same a the whitelisted volume:
let trackedAmountUSD = getTrackedVolumeUSD(...)

...

poolMetricsDaily.dailyVolumeByTokenUSD = [
    poolMetricsDaily.dailyVolumeByTokenUSD[INT_ZERO].plus(
-      trackedAmountUSD[INT_ZERO]
+      trackedAmountUSD[INT_ZERO] ? trackedAmountUSD[INT_ZERO] : trackedAmountUSD[INT_TWO]
    ),
    poolMetricsDaily.dailyVolumeByTokenUSD[INT_ONE].plus(
-      trackedAmountUSD[INT_ONE]
+      trackedAmountUSD[INT_ONE] ? trackedAmountUSD[INT_ONE] : trackedAmountUSD[INT_TWO]
    ),
];

I have a feeling that in the case of non-whitelisted/whitelisted pools, the whitelisted token's volume can be thrown off by the non-whitelisted one. But I will let @steegecs chime in here.

I think it is a good idea to impute the whitelist token in the case of non-whitelisted/whitelisted pools since the values should be close together as @jaimehgb suggests. I think this would be best to handle in the price module and in the case of  non-whitelisted/whitelisted pools, we could input the non-whitelisted token volume with the whitelisted token volume.

Sounds good! @jaimehgb thanks for the detailed context!


Refactor JSONSerializer

Refactors the JSONSerializer into something that makes a bit more sense to me. There are now methods to serialize/deserialize a set of parameters into a single serialized object, and another set of methods to serialize/deserialize individual parameter values.

[ ] Add tests for serialize_parameter_value and deserialize_parameter_value

Coverage decreased (-0.2%) to 76.258% when pulling c269cedf128acbcb239ba4bf87c8722999906d42 on refactor_serialization into 1568c261bd25434c7f6fc155db6aee3590642d31 on master.

Looks fine to me. The original intent of serialize_parameters and deserialize_parameters was closer to the new serialize_parameter_value and deserialize_parameter_value methods: I agree this way is clearer though.


Fix lints for unescaped quotes

99:36  Error: `"` can be escaped with `"`, `“`, `"`, `”`.  react/no-unescaped-entities
100:73  Error: `"` can be escaped with `"`, `“`, `"`, `”`.  react/no-unescaped-entities

I introduced those accidentally with #43, see failing deploy on main branch

Thanks a lot!


how can I close my climate

If the climate doesn't include off mode, how can I close my ac from climate tab?

How do you “close” it from HA?

How do you “close” it from HA?

Currently, When I click the thermostat card, it will shows the on/off button. The off state is not listed in operation mode.

We list all operation modes that are exposed via the API.

What HA service is being called for on/off? Also, please provide us with the entity dump from dev-tools.

Service: climate.turn_off
{
"entity_id": "xxxxx "
}
like this

You can create a separate SWITH tile to turn in on and off.

You can create a SWITCH or CUSTOM tile to turn it on and off.

you mean I need Two Tab to controll one AC right? one is climate one is switch?

That is correct.


Revert "Remove warning about memset. (#6003)"

This reverts commit 12e3fb6a6cb601c58d39ed54253e6e50f1513ccc.

The bad commit makes it flaky.

@hcho3 I will merge this first to resolve cpu test.  Segfault by rmm is not resolved yet.


mobile responsiveness missing

issues existed on the web page:

lack of mobile responsiveness
fonts are of  basic type
no proper alignment of components in the hero section

this part of the UI is not proper it needs to be fixed
I can solve this and make the website look better.

@codervivek5 I am interested in working on this. please   label it and allow me to work on this

someone is already working on it


adding python code to print sequence

/assign

now i have reuploaded my code under pull request #254


ZTEST: Add optional float/double comparison support

Currently the zassert_* functions in the ztest API are based on integer values, which can be accurately compared (1==1, etc.).
There are no options for single or double precision floating point value comparisons, which are error-prone to compare againist fixed operands (x==0.5f), particularly with single-precision values.
When CONFIG_FLOAT is enabled, options should be included to compare single and double precision values for equality within a specific margin.
In previous projects, I've implemented the following helper functions to work with floating point values in unit tests ...
bool f_is_equal(float a, float b, float epsilon);
bool f_is_at_least(float a, float b);
bool f_is_less_than(float a, float b);
bool f_is_greater_than(float a, float b);
bool f_is_within(float a, float upper, float lower);

... which allows tests like the following code, with control over the degree of prevision involved in the comparison:
#define F_EPSILON5  1E-5
TEST_ASSERT(f_is_equal(xyy.x, 0.44422f, F_EPSILON5, "2900K -> xyY"));

I understand the allergy to float in an embedded context, but if CONFIG_FLOAT has been set to y and is being used in the application or library, shouldn't the option be available to test said floating point values in both single and double-precision widths, using 'safer' value comparisons?
I can continue to use my own code to test these, but it seems reasonable to at least consider adding these helpers to ztest and ztest_assert.h with an appropriate check for CONFIG_FLOAT?

@microbuilder : Would you consider preparing a PR with this enhancement?

Sure, I just wanted to check if there was strong resistance to including float support, but I'll put a PR together for this.

Closing for lack of activity. Will reopen as PR when ready.


Modified Import Cmd

This change is

Coverage increased (+0.4%) to 85.529% when pulling cbd7ce8a3d67258d948a087fa9dcec8ba1926782 on ImportnExportcmd into dc6e445550c047f029d0d6d7792212a28b7ed8bd on master.


[feat] add local storage settings

Describe the problem
No user preferences.
Describe the solution you'd like
While not ideal, for now using localStorage should still be better than nothing, here a few of the options we could have:

IPFS Gateway (dropdown of popular gateways, with a custom option)
Default Feed: a lot of people don't like last sales as the default feed.
Show Mature
Show Photosensitive
Custom Theme? (we could start with a color à la https://hen.miami/)

Alternatives considered
A proper encrypted backend
Additional context
No response

Some ideas: https://docs.google.com/document/d/1vYkB_BTwCQIzMPxQuX0EHrBCvjjxPJ-eZEtztN15mGI/edit?usp=sharing

UI/Style will be polished soon, but the base logic mentioned here is implemented, we can expand upon it with an issue / ideas


"Word Based Suggestions" completion feature breaks Intellisense for PowerShell.

Type: Bug
If I have editor.wordBasedSuggestions set to true, autocomplete fails to work when typing the following: [String]::.
Only word based suggestions show up in the autocomplete tooltip and no methods from the System.String class. See the following image:

To get autocomplete to work correctly, I have to move my cursor to a different line and then back to the end of the :: and only THEN can I see the full autocomplete results. Even then, sometimes I will have to press control space to trigger the autocomplete results I need.
After a ton of trial and error, uninstalling all extensions, disabling all my keyboard shortcuts, etc., I found that disabling Word Based Suggestions completely fixed the issue.
While I'm happy that VS Code is working more reliably now, I'd ideally like to see both word based suggestions and intellisense suggestions if there is a way to configure the IDE to do so.
Is my install of VS Code behaving correctly? Is there anything else I can try to resolve this issue?
Here is a screen recording of me reproducing the faulty behavior if my description of the bug isn't completely understood:
https://user-images.githubusercontent.com/33441569/184086241-36867ea9-ac63-43c5-955e-edfd6ad33afa.mp4
Any help at all would be extremely appreciated.
VS Code version: Code 1.70.1 (6d9b74a70ca9c7733b29f0456fd8195364076dda, 2022-08-10T06:08:33.642Z)
OS version: Windows_NT x64 10.0.19044
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9900KF CPU @ 3.60GHz (16 x 3600)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
63.92GB (55.41GB free)

Process Argv
--crash-reporter-id 980edeb0-3f45-42f4-8995-c0d13015b889

Screen Reader
no

VM
0%

Extensions (31)

Extension
Author (truncated)
Version

prettier-vscode
esb
9.5.0

activitusbar
Gru
0.0.46

vscode-auto-open-markdown-preview
hnw
0.0.4

powershellprotools
iro
2022.8.0

copy-filename
jac
2.3.2

shortcut-menu-bar
jer
3.0.4

powershell
ms-
2022.7.2

reload
nat
0.0.6

material-icon-theme
PKi
4.19.0

bracketeer
pus
1.3.1

snippets-viewer
Ran
1.11.0

adobe-script-runner
ren
0.6.0

selectline-statusbar
tom
0.0.2

errorlens
use
3.6.0

vsys-gui-snippets
und
0.0.1

vsys-ip-net-snippets
und
0.0.1

vsys-javascript-generic-snippets
und
0.0.1

vsys-jsx-extendscript-snippets
und
0.0.1

vsys-jsx-generic-snippets
und
0.0.1

vsys-language-fundamentals
und
0.0.1

vsys-math-snippets
und
0.0.1

vsys-net-snippets
und
0.0.1

vsys-path-snippets
und
0.0.1

vsys-patterns-snippets
und
0.0.1

vsys-utility-snippets
und
0.0.1

snippet-generator
wen
0.3.2

change-case
wma
1.0.0

better-align
wwm
1.1.6

cursor-align
yo1
1.1.0

markdown-all-in-one
yzh
3.4.3

html-css-class-completion
Zig
1.20.0

Word based suggestion only show when extensions return no suggestions - therefore marking this as "caused by extension". Please forward this issue to the PowerShell extension. Thanks

/extPowerShell

It looks like this is caused by the PowerShell extension. Please file the issue to the PowerShell extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Does not work when the display language is Japanese

It doesn't work when the display language is Japanese.

It works well when the display language is English.

This is a screenshot of the class display in the developer tools when the display language is set to Japanese. Please refer to it.
The Japanese version of the class name does not have r-37j5jr.
https://github.com/wseagar/eight-dollars/blob/a1d053706e70e7c62b06ffca040d52a6499d23ba/script.js#L69-L70

In addition, it appears that the profileNode also needs to be modified.
The Japanese version of the tweet class name does not have r-poiln3.
https://github.com/wseagar/eight-dollars/blob/a1d053706e70e7c62b06ffca040d52a6499d23ba/script.js#L71-L72

This problem has not been resolved. See comment #31.

Described a possible solution here: https://github.com/wseagar/eight-dollars/pull/31#issuecomment-1312463192


Double-click on JAR doesn't launch the application #32

Adding registry keys to map .jar extension with javaw.exe -jar
closes: https://github.com/AdoptOpenJDK/openjdk-installer/issues/32

That looks not the recommended way to register an extension via msi. I will share an example later.

@alexhass please submit a PR if there is a better way :)

See https://github.com/alexhass/vscode/blob/master/build/wix/code.wxs#L491


Update datasets dependency to 2.14

Update datasets dependency to 2.14 and fix related issues.
Fix #1589.

Apparently there was an addition to the main branch which is not in this branch: tests/test_16_statistics.py.

Codecov Report
Patch coverage: 84.59% and project coverage change: -0.43% :warning:

Comparison is base (05cf084) 90.42% compared to head (b92630a) 89.99%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1621      +/-   ##
==========================================
- Coverage   90.42%   89.99%   -0.43%
==========================================
  Files         193      208      +15
  Lines       12046    12808     +762
==========================================
+ Hits        10893    11527     +634
- Misses       1153     1281     +128

Flag
Coverage Δ

jobs_cache_maintenance
99.08% <ø> (ø)

jobs_mongodb_migration
85.07% <ø> (ø)

libs_libapi
85.54% <92.50%> (?)

libs_libcommon
91.53% <100.00%> (+0.06%)
:arrow_up:

services_admin
85.87% <ø> (ø)

services_api
88.13% <ø> (ø)

services_rows
82.93% <100.00%> (-0.62%)
:arrow_down:

services_search
78.76% <78.76%> (?)

services_worker
92.24% <100.00%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

services/search/src/search/routes/search.py
54.47% <54.47%> (ø)

services/search/src/search/app.py
81.39% <81.39%> (ø)

libs/libapi/src/libapi/utils.py
52.50% <83.33%> (ø)

services/search/tests/conftest.py
87.30% <87.30%> (ø)

libs/libapi/tests/test_utils.py
100.00% <100.00%> (ø)

libs/libcommon/src/libcommon/utils.py
95.78% <100.00%> (+0.18%)
:arrow_up:

...s/libcommon/src/libcommon/viewer_utils/features.py
77.17% <100.00%> (+5.55%)
:arrow_up:

libs/libcommon/tests/viewer_utils/test_features.py
100.00% <100.00%> (ø)

services/rows/src/rows/routes/rows.py
57.14% <100.00%> (-4.56%)
:arrow_down:

services/rows/tests/routes/test_rows.py
92.12% <100.00%> (-0.86%)
:arrow_down:

... and 18 more

... and 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Once CI is green, instead of squashing this PR, I will rebase and merge, so that all the commits here are preserved in the main branch.

good job!!!


[TRACKER] Cyclic dependencies related issues

Godot version
4.2 dev
Issue description
Anything related to cyclic dependencies/requirements of resources. Note that cyclic references (RefCounted) can be a slightly different issue.
### Bugs
- [ ] #7038
- [ ] #24146
- [ ] #38768
- [ ] #39153
- [ ] #39294
- [ ] #55615
- [ ] #56628
- [ ] #59116
- [ ] #64330
- [ ] #65393
- [ ] #69508
- [ ] #70985
- [ ] #73589
- [ ] #73615
- [ ] #74253
- [ ] #74806
- [ ] #74837
- [ ] #74915
- [ ] #75268
- [ ] #76019
- [ ] #76641
- [ ] #77090
- [ ] #77436
- [ ] #77513
- [ ] #78074
- [ ] #78128
- [ ] #78211
- [ ] #79197
- [ ] #79545
- [ ] #79625
- [ ] #80043
- [ ] #80324
- [ ] #80379
- [ ] #80645
- [ ] #80714
- [ ] #80981
- [ ] #81462
- [ ] #81685
- [ ] #83539
- [ ] #83803
- [ ] #87397
- [ ] #94242

### PRs
- [ ] #80854
- [ ] #92326

One more issue with cyclic dependencies:
https://github.com/godotengine/godot/issues/87397

This tracker is nice to have, but is there also a place that aggregates design suggestions for avoiding this in the first place? I've got a fairly large project, and even slight changes, like referencing a type can suddenly cause a series of seemingly unrelated files to become corrupted. e.g. I have a global PlayerState autoload, and referencing something as simple as a resource type will suddenly make my units become corrupted with errors like:
E 0:00:01:0779   ResourceLoaderText::_parse_ext_resource: res://core/units/unit.tscn:502 - Parse Error: [ext_resource] referenced non-existent resource at: res://core/components/drag_and_drop/drag_component_2d.gd
  <C++ Source>   scene\resources\resource_format_text.cpp:163 @ ResourceLoaderText::_parse_ext_resource()

This is after referencing an ItemBlueprint type, which has nothing to do with my Units! I literally have no idea how to make forward progress on my projects anymore, because I have no idea when something is just going to blow up.

This tracker is nice to have, but is there also a place that aggregates design suggestions for avoiding this in the first place?

@yoont4 No, trackers are usually not intended for general discussion, only for grouping/classifying related issues. You can write a comment if you notice missing issues, and a maintainer will add them to the first post.
For general discussion, please use the appropriate Godot Contributors Chat channel (in this case #gdscript) or the issue most relevant to your topic from the list, if any (in this case it is quite difficult to do since there are a lot of issues).

Should #78074 be added here?

#92326 was superseded by #93346.

https://github.com/godotengine/godot/issues/99333


thefuck: 3.26 -> 3.27

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: thefuck
Partial log (click to expand)
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r1vcy048i7m4jbnkb4gas3819x1rv81b-thefuck-3.27
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r1vcy048i7m4jbnkb4gas3819x1rv81b-thefuck-3.27/lib  /nix/store/r1vcy048i7m4jbnkb4gas3819x1rv81b-thefuck-3.27/bin
patching script interpreter paths in /nix/store/r1vcy048i7m4jbnkb4gas3819x1rv81b-thefuck-3.27
checking for references to /build in /nix/store/r1vcy048i7m4jbnkb4gas3819x1rv81b-thefuck-3.27...
wrapping `/nix/store/r1vcy048i7m4jbnkb4gas3819x1rv81b-thefuck-3.27/bin/thefuck'...
wrapping `/nix/store/r1vcy048i7m4jbnkb4gas3819x1rv81b-thefuck-3.27/bin/fuck'...
/nix/store/r1vcy048i7m4jbnkb4gas3819x1rv81b-thefuck-3.27

Success on x86_64-linux (full log)
Attempted: thefuck
Partial log (click to expand)
Successfully installed thefuck-3.27
/build/source
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rs8kzaqd2kzwn19r9si92i1ckskwm8yx-thefuck-3.27
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rs8kzaqd2kzwn19r9si92i1ckskwm8yx-thefuck-3.27/lib  /nix/store/rs8kzaqd2kzwn19r9si92i1ckskwm8yx-thefuck-3.27/bin
patching script interpreter paths in /nix/store/rs8kzaqd2kzwn19r9si92i1ckskwm8yx-thefuck-3.27
checking for references to /build in /nix/store/rs8kzaqd2kzwn19r9si92i1ckskwm8yx-thefuck-3.27...
wrapping `/nix/store/rs8kzaqd2kzwn19r9si92i1ckskwm8yx-thefuck-3.27/bin/fuck'...
wrapping `/nix/store/rs8kzaqd2kzwn19r9si92i1ckskwm8yx-thefuck-3.27/bin/thefuck'...


Flag overhaul

I noticed the TODO comment about adding a flag to chrome://flags in add-ipv6-probing-option.patch while working on a previous change.  I decided to delay adding the flag and create it's own PR, which has since evolved into this one!
I've made this a draft for now to get feedback on the implementation and to make sure that this doesn't cause problems for anyone.  I also need to set up a companion PR for the Windows-specific flags.  Not to mention the major version update due in a day or so will require this to be updated anyways.
Overview

Creates flag entries for patches that did not have them previously.  Now all features have chrome://flags entries!
Added "Ungoogled Chromium flag" to the end of all flag descriptions.  This makes it easier to differentiate between Chromium flags and ones that have been added by Ungoogled Chromium.  It also has the benefit of being able to pull up all the Ungoogled Chromiumn flags when searching on the flag page.
Updates the flag documentation.  I organized the flags by the platform it's available for and used a table layout for readability.  (preview)
Adds a patch which creates headers to organize flags added by Ungoogled Chromium.  This is where the most significant change happens and will be explained in more detail below.
Updates existing patches to use the new headers.
Fixes a small bug in validate_patches.py that this processes uncovered.

Further Detail
Documentation Formatting
Github's formatting tries to make the flag column narrow which causes the flags to break over multiple lines on the hyphens.  I used non-breaking spaces in the headers to prevent that from happening.  I'd be interested to know if there's a better way to handle that!
Flag Headers
Currently flag entries and choices are all added into chrome/browser/about_flags.cc without too much organization.  Updating or adding new flags generally requires updating the line offsets in other patches.  And when Google changes things in about_flags.cc each patch will need to be double-checked afterwards if quilt refresh had fuzz updates.
This PR organizes all of the flag entries and choices into separate headers.  Those headers are then included in about_flags.cc.
The idea is that only the line offset for add-ungoogled-flag-headers.patch would be updated when running quilt refresh!  Adding new flags would also be an easier process since it could simply be added after the last one in its header.
The Bromite flags have their own set of headers separate from the Ungoogled Chromoium ones.  This is so PRs adding new flags to Ungoogled Chromium don't also need to update the offsets in the Bromite patches.
This creates new files, so if you do dirty builds then you would need to handle the new files the same way you do for add-components-ungoogled.patch.
An alternative approach would be to have the entries and choices be included in the add-ungoogled-flag-headers.patch itself.  That would make the list more apparent to anyone looking at the patch and would allow the series file to be reordered more easily as well.
I didn't go with this option since I thought it would be weird to have the patches and their flags decoupled.  It also means that flags like the Windows-specific ones would need to make a PR to add their flags to the list.  Granted they would have to make a PR to add them to the flag doc as well, so maybe that isn't really a problem.
Bugfix for validate_patches.py
I managed to find a small bug while working on this.  Existing files are split on newlines, so there shouldn't be newline characters in the lines in the list that patches are compared against.  When a patch creates a new file the hunk is read in line-by-line but those lines included a newline!  This caused validation to fail for any patch that attempts to change a newly created file.

@Zoraver I'd like your feedback on this PR since you've put in a lot of work into maintaining our patches.

@Eloston I don't have a preference!  I guess that's just how the name occupies my mind and I didn't give it a second thought.  I'll change them to "ungoogled-chromium" when I do the update.
@Zoraver Going over doc again also just made me realize that I have "flags" for the table header, but most of them are actually the commandline switches.  I'll try to make it more clear that every entry has a corresponding flag and switch.

I've updated the PR for 87 and hopefully improved the language on the flags doc.
I'll mark this for review after I create the PR on the Windows repo later today.

I created the PR and have also added one more change.
Originally I had the Windows flags added to the ungoogled headers like the rest.  Having it that way meant that they would have to update their patches any time that the ungoogled-chromium repo adds/removes/reorders flag entries.
So I added a set of platform headers that can be used by any of the platform repos to add entries to chrome://flags.  That should allow them to add their flags without having to worry about changes here causing extra maintenance.


[Keyboard] Auto-scroll does not work on WebViews

Hello @PureWeen ,
Thanks for adding the keyboard fix to the package. However, I noticed a minor missing feature, when we have a Webview in a screen and that Webview has a form with several fields, if I tap a field of that form within the Webview the keyboard is still covering the form field. Since the web page does not allow to zoom or scroll, there is no way for us to scroll manually.
This happens on iOS, iPadOS and also on Android.
Thank you!

@tj-devel709


LinAlgError for MAP in code 4.26 (chapter 4)

Dear reader,
I am working through the Statistical Rethinking book and running the code in Pyro using this great repository. I encountered the following error when during the model with MAP:
(4.24)
howell1 = pd.read_csv("../data/Howell1.csv", sep=";")

(4.25)
def flist(height):
    mu = pyro.sample("mu", dist.Normal(178, 20))
    sigma = pyro.sample("sigma", dist.Uniform(0, 50))
    with pyro.plate("plate"):
        pyro.sample("height", dist.Normal(mu, sigma), obs=height)

Thus far it worked well. Yet with (4.26) I run into the following error:
d2_height = torch.tensor(d2["height"], dtype=torch.float)
m4_1 = MAP(flist).run(d2_height)

---------------------------------------------------------------------------
_LinAlgError                              Traceback (most recent call last)
Cell In[38], line 2
      1 d2_height = torch.tensor(d2["height"], dtype=torch.float)
----> 2 m4_1 = MAP(flist).run(d2_height)

File ~/learning_pyro/notebooks/rethinking.py:101, in MAP.run(self, *args, **kwargs)
     99         except Exception as e:
    100             last_error = e
--> 101 raise last_error

File ~/learning_pyro/notebooks/rethinking.py:98, in MAP.run(self, *args, **kwargs)
     96 for i in range(10):
     97     try:
---> 98         return super(MAP, self).run(*args, **kwargs)
     99     except Exception as e:
    100         last_error = e

File ~/anaconda3/envs/PYRO/lib/python3.10/site-packages/pyro/infer/abstract_infer.py:251, in TracePosterior.run(self, *args, **kwargs)
    249 self._reset()
    250 with poutine.block():
--> 251     for i, vals in enumerate(self._traces(*args, **kwargs)):
    252         if len(vals) == 2:
    253             chain_id = 0

File ~/learning_pyro/notebooks/rethinking.py:85, in MAP._traces(self, *args, **kwargs)
     82     return loss
     84 optimizer.step(closure)
---> 85 guide = delta_guide.laplace_approximation(*args, **kwargs)
     87 # get posterior
     88 for i in range(self.num_samples):

File ~/anaconda3/envs/PYRO/lib/python3.10/site-packages/pyro/infer/autoguide/guides.py:1181, in AutoLaplaceApproximation.laplace_approximation(self, *args, **kwargs)
   1179     cov /= scale[:, None]
   1180     cov /= scale[None, :]
-> 1181     scale_tril = torch.linalg.cholesky(cov)
   1183 gaussian_guide = AutoMultivariateNormal(self.model)
   1184 gaussian_guide._setup_prototype(*args, **kwargs)

_LinAlgError: linalg.cholesky: The factorization could not be completed because the input is not positive-definite (the leading minor of order 1 is not positive-definite).

Notably, continuing to work with the MAP class for code snippet 4.29 does work again and gives me a similar output to the one described online.
What could be the underlying issue here?

The issue is hessian at MAP point is singular. Could you file an issue in Pyro forum?

Thanks, filed an issue in Pyro now. Were these code snippets functional before and perhaps impacted by any updates of Pyro, or are they just 'translations' of the original R code that might not always work?

I think it works previously. But raising error is the desired behavior here because the hessian under laplace approximation is not positive definite. We will improve the error message.

Thank you, that is interesting to know. Would you have recommendations for continuing to follow the SR book with Pyro code? The notebooks are great to follow but I would like to interactively work with it as well.

I would recommend using rethinking-numpyro version. It is completed and tested.

Thank you, I will continue using that!


Websocket terminated with badmatch error when sending flood of messages

I'm connecting to a RabbitMQ server through the web-stomp plugin with a websocket. I believe RabbitMQ uses a cowboy server to power the STOMP protocol it uses.
When I send a flood of messages through this websocket, the connection is closed before it finishes sending all messages.
Looking at the logs, I see the following error:
 {{badmatch,<<1,254,1,58,18,163,127,205,65,230,49,137,24,199,
                              26,190,102,202,17,172,102,202,16,163,40,140,30,
                              160,99,140,14,184,119,214,26,226,116,207,16,162,
                              118,169,28,162,124,215,26,163,102,142,19,168,
                              124,196,11,165,40,144,71,248,24,169,63,141,82,
                              227,63,141,82,227,63,141,82,227,63,141,82,227,
                              63,141,82,227,63,141,82,227,63,141,82,227,63,
                              141,82,227,63,141,82,227,63,141,82,227,63,141,
                              82,227,63,141,82,227,63,141,82,227,63,141,82,
                              227,63,141,82,227,63,141,82,227,63,141,82,227,
                              63,141,82,227,63,141,82,227,63,141,82,227,63,
                              141,82,227,63,141,82,227,63,141,82,227,63,141,
                              82,227,63,141,82,227,63,141,82,227,63,141,82,
                              227,63,141,82,227,63,141,82,227,63,141,82,227,
                              63,141,82,227,63,141,82,227,63,141,82,227,63,
                              141,82,227,63,141,82,227,63,141,82,227,63,141,
                              82,227,63,141,82,227,63,141,82,227,63,141,82,
                              227,63,141,82,227,63,141,82,227,63,141,82,227,
                              63,141,82,227,63,141,82,227,63,141,82,227,63,
                              141,82,227,63,141,82,227,63,141,82,227,63,141,
                              82,227,63,141,82,227,63,141,82,227,63,141,82,
                              227,63,141,82,227,63,141,82,227,63,141,82,227,
                              63,141,82,227,63,141,82,227,63,141,82,227,63,
                              141,82,227,63,141,82,227,63,141,82,227,63,141,
                              82,227,63,141,82,227,63,141,82,227>>},
                  [{cowboy_http_websocket,websocket_data,4,[]},
                   {cowboy_http_protocol,upgrade_protocol,3,[]}]}

This only seems to happen when sending the messages in Chrome. For some reason, Firefox and IE don't seem to cause the websocket to be closed.
Any ideas on what could be the cause behind this? Let me know if you need any more information

RabbitMQ stable uses a very old version of Cowboy. Can you try with RabbitMQ master? I updated Cowboy there. The issue is probably long gone.

Yep, using RabbitMQ 3.6.0 Milestone 3 version seems to have fixed i!
I was running the latest stable RabbitMQ release (3.5.6) which used Cowboy v0.5.
The pre-release version of RabbitMQ (3.6.0) now uses Cowboy v1.0.3
Just out of curiosity, would you have any idea what was fixed between the two cowboy versions to resolve this issue?

Exactly no. But since then Cowboy has been made to pass 100% of the Autobahntestsuite tests which covers everything from the RFC, so this problem was probably fixed sometimes around then.
Closing, thanks!


Fix Button Overlap on Widescreen Phones

Screenshot from latest version of original J2ME Loader:

—————
Screenshot from latest version of JL-Mod:

This issue has been closed due to no reply from @woesss

This issue has been closed due to no reply from @woesss

I have not found an adequate solution. The virtual keyboard was originally designed so that now resizing will be reflected in all layouts (including manually configured ones - users will have to fix them again)

I have not found an adequate solution. The virtual keyboard was originally designed so that now resizing will be reflected in all layouts (including manually configured ones - users will have to fix them again)

@woesss
Yes, but can you fix the button overlap as @nikita36078 already did in the original J2ME-Loader?

@woesss
Yes, but can you fix the button overlap as @nikita36078 already did in the original J2ME-Loader?


Documentation: Remove/replace TrueNAS install instructions, as the linked guide is outdated.

Wiki Page URL
https://github.com/ArchiveBox/ArchiveBox/blob/6a33de671524e9b721b05c8107b7c6206ecf4c15/README.md#-other-options
Suggested Edit
Both the linked documentation and article use the Truecharts repository, which has been deprecated for TrueNAS Scale. Users can no longer add the Truecharts repository to their systems. Therefore, the linked instructions should either be removed or updated.

damn, I just made that chart.
oh well, I think the new Electric Eel system will be better when it comes out...
https://github.com/ArchiveBox/ArchiveBox/commit/ff992a3edb6fe42f10a7b32d807ed74e3a6ee8f2


Retrying client

This PR updates the core to the latest snapshot and introduces the RetryingClient — a FirebaseClient which retries queries several times if they fail.
A retrying client helps to deal with the errors produced by the Apache HTTP transport as it is not able to parse a response.

@armiol, PTAL.

@armiol, PTAL at the new code.


Remove wkhtmltopdf images

The images with wkhtmltopdf are very specific... with the latest offer of https://github.com/kool-dev/pdf we should remove them to clean up a bit.

Done with https://github.com/kool-dev/docker-php/pull/16


fix CreateContext header

Intro:
api.ai allows users to get/set the context by using /context end point. Currently you can get it, reset it but you can't set it due to mistake in the code.
Reason:
According to: https://www.w3.org/Protocols/rfc1341/4_Content-Type.html
Content-Type header field value is defined as follows:
Content-Type := type "/" subtype *[";" parameter]
                                    ^

Solution:
Change , to ;

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   67.24%   67.24%
=======================================
  Files           6        6
  Lines         458      458
=======================================
  Hits          308      308
  Misses         88       88
  Partials       62       62

Impacted Files
Coverage Δ

contexts.go
76.14% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4773d3...c298d2c. Read the comment docs.

Just one more thing from the docs:

JSON text SHALL be encoded in Unicode.  The default encoding is UTF-8.

Thank you once again @paranoida 👍


v 3+ (Bug) Selection by images on species menu

ToDO: On 1/13/2023 @bestw07 and @TreeMama were unable to select the pictures in the Species menu (both on the 'Add Data' page and the 'Explore' page).
Must fix before release.

Not repo'ing on 4.0.2 (69). Looks good!


Update to use Chalk 5

General Support Request
Repos are using a legacy version fo Chalk that requires an integration change of the code.
Support request
Update to the latest version of Chalk and address similar updates as done in this commit

https://github.com/AlaskaAirlines/auro-input/pull/253/commits/b0bc88832a1345011cf6fae3d78c11f76a8e8e32

Exit criteria
This issue is closed once the repo can be built using the latest version of. Chalk.

This issue was addressed in this PR, but had not yet been reflected in the PR's notes:

https://github.com/AlaskaAirlines/auro-datepicker/pull/112


Surface.Component raises (BadMapError) expected a map, got: nil in render_component

After upgrading to commit bb7d1e93be7e9624dd4550262d6507411f30db2c from previous commit, tests that use render_component/2 started failing for components with use Surface.Component or use Surface.LiveComponent, but work if that line is changed to use Phoenix.LiveComponent.
defmodule SomeComponent do
  use Surface.Component

  def render(assigns) do
    ~L"""

Hello

    """
  end
end

render_component(SomeComponent, %{
  __surface__: %{groups: %{__default__: %{binding: false, size: 0}}}
})

Test output:
     ** (BadMapError) expected a map, got: nil
     code: render_component(SomeComponent, %{
     stacktrace:
       (elixir 1.10.1) lib/map.ex:764: Map.split(nil, [:__default__])
       (surface 0.1.0-alpha.0) lib/surface/content_handler.ex:23: Surface.ContentHandler.init_contents/1
       test/test_project_web/live/user/some_test.exs:1: SomeComponent.render/1
       (phoenix_live_view 0.11.0) lib/phoenix_live_view/utils.ex:101: Phoenix.LiveView.Utils.to_rendered/2
       (phoenix_live_view 0.11.0) lib/phoenix_live_view/test/live_view_test.ex:393: Phoenix.LiveViewTest.__render_component__/3

Possibly related: https://github.com/msaraiva/surface/issues/21

Here's a test that can be executed when added to component_test.exs:
  describe "Without LiveView" do
    @surface_attributes %{groups: %{__default__: %{binding: false, size: 0}}}
    test "render stateless component with render_component/2" do
      assert render_component(Stateless, %{
        __surface__: @surface_attributes,
        label: "My label",
        class: "myclass"
      }) =~ """

\n  My label\n

      """
    end
  end

It succeeds before commit bb7d1e93be7e9624dd4550262d6507411f30db2c and fails after it.

I used the test "render stateless component" as basis. Note that I needed to add whitespace characters to make the assert pass.

Removing __surface__ from attributes makes it fail with the same message in earlier commits, too.

Hi @leanersoft!
groups has been renamed to slots. This should work:
@surface_attributes %{slots: %{__default__: %{binding: false, size: 0}}}

Actually, I decided to add a fallback value for assigns.__surface__.slots so you don't need to set it anymore when using slotless components. This should work now:
describe "Without LiveView" do
  test "render stateless component without named slots with render_component/2" do
    assert render_component(Stateless, %{label: "My label", class: "myclass"}) =~ """

              My label

            """
  end
end

Resolved in 4fb6f55f0243c7fad903ddd922a4c6667a46be02


TrayIcon.UpdateIcon (IntPtr handle) - System.InvalidOperationException: UpdateIcon failed.

Describe the bug
We are receiving multiple crash reports from our crash reporting system (Appcenter), I will include the crash below.
What is interesting about this issue is we are not hearing about the crash from users.  WIth over 450 reports of the crash, it would expect some users to write in and complain that the icon disappeared or the program crashed.  But we are not hearing these reports.
Package: FreedomPlatform
Version: 2.25
OS: WINDOWS
Windows: 10.0.22621
Date: 2024-01-03T14:40:54.0825702Z

Exception Stack:
System.InvalidOperationException: UpdateIcon failed.
  at H.NotifyIcon.Core.TrayIcon.UpdateIcon(IntPtr handle)
  at H.NotifyIcon.TaskbarIcon.UpdateIcon(Icon value)
  at H.NotifyIcon.TaskbarIcon.<>c.<.cctor>b__257_7(DependencyObject sender, DependencyPropertyChangedEventArgs args)
  at System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
  at System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
  at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
  at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType)
  at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType, Boolean isInternal)
  at System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
  at H.NotifyIcon.TaskbarIcon.<OnIconSourceChanged>d__177.MoveNext()
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
  at System.Windows.Threading.DispatcherOperation.InvokeImpl()
  at MS.Internal.CulturePreservingExecutionContext.CallbackWrapper(Object obj)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
  at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
  at MS.Internal.CulturePreservingExecutionContext.Run(CulturePreservingExecutionContext executionContext, ContextCallback callback, Object state)
  at System.Windows.Threading.DispatcherOperation.Invoke()
  at System.Windows.Threading.Dispatcher.ProcessQueue()
  at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
  at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
  at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
  at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
  at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)
  at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)
  at MS.Win32.UnsafeNativeMethods.DispatchMessage(MSG& msg)
  at System.Windows.Threading.Dispatcher.PushFrameImpl(DispatcherFrame frame)
  at System.Windows.Application.RunDispatcher(Object ignore)
  at System.Windows.Application.RunInternal(Window window)
  at FreedomPlatform.SingleInstanceManager.Run()
  at FreedomPlatform.App.Main(String[] args)

Steps to reproduce the bug
We are not able to reproduce the bug, which is confusing.
Expected behavior
No response
Screenshots
No response
NuGet package version
2.0.123
Platform
WPF
IDE
Visual Studio 2022
Windows Version
Windows 11, Windows 10
WindowsAppSDK Version
1.0
WindowsAppSDK Type
Packaged
Manifest
No response
Additional context
If anyone else is running into this crash, or has any other information on the trace, it would be much appreciated.  Thank you.

The problem with this exception is that it is a failed Win32 API call and there is no way to find out the details. We can only guess at some conditions - for example, when the application is minimized or hidden, when Windows is hibernating, or some other unique environment conditions in which the application is still running, but the user is not directly interacting with it

I removed this exception in the latest release because it doesn't provide any benefit.
https://github.com/HavenDV/H.NotifyIcon/commit/10e6f835161bfa7a2f16d91a6bc13955491b43dc

If there are no side issues here with updating the icon (which can sometimes have the wrong state, for example), then this can be closed

@HavenDV I will pass your feedback to our Windows lead and see if there is any followup, and respond accordingly.  Thank you for your quick response.

@HavenDV Thank you, we discussed this and we will update to the latest version.  I will go ahead and close this.


Dart 3 cleanup: Remove work around for ContinueSwitchStatement crash on web

Once https://github.com/dart-lang/sdk/issues/51802 is resolved, we should remove the work around put in place for it by reverting this commit: https://github.com/flutter/flutter/pull/122546/commits/39d8336fe70c31482f74d1831ce21e95355c5da6

An alternative to reinstating the ContinueSwitchStatement is to break and put the 'glow' code after the outer switch.
There is no equivalent to continue-switch in JavaScript, so dart2js and DDC have to contrive that the switch is wrapped in a loop so it can be re-entered to divert control-flow to the other case. So continue-switch is not exactly the simple 'goto' that it appears to be. The combination of infrequent use and implementation complexity is why we keep finding bugs with the feature (e.g. https://github.com/dart-lang/sdk/issues/51777).


Cannot read property length of null bug

Challenge http://www.freecodecamp.com/challenges/waypoint-create-a-bulleted-unordered-list has an issue. Please describe how to reproduce it, and include links to screen shots if possible.
cc @QuincyLarson

Wow, I just saw this or I would've fixed it with my last commit. Yea, match returns Cannot read property length of null if there is no match found. How about using .test instead of .match? What do you think?

It actually needs to check existence before trying to read the property length.
match will sometime return undefined. So when the test tries to read undefined.length it will crash the app and be unusable.

Fixing it. I caught most of these but this one slipped through. @berkeley is correct.


Add protocol-wide file path declaration

Would be nice to be able to specify a default file path for all elements in a protocol.

done in version 1.4.4


Create codeql-analysis.yml

Codecov Report

Merging #47 (82c7c9c) into master (fa0332a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   76.91%   76.91%
=======================================
  Files           6        6
  Lines         693      693
=======================================
  Hits          533      533
  Misses         95       95
  Partials       65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0332a...82c7c9c. Read the comment docs.

Thank you for the fast approve @ahothan :)


Refactoring binary broadcasting

Support ndim up to 7 for binary broadcasting operators + Accelerate reducing OPs by calling reduce_except_dim if possible. + Add /bigobj to CMakeList

@mli @tqchen

@sxjscience  is there any way to get rid of the RANGE_SWITCH so we can directly make it to some cases like broadcast_mid? This will make the code more general and smaller

@tqchen, I may have to first get_shape_with a large NDIM like 7 and perform the reducing/broadcasting afterwards. RANGE_SWITCH can be avoid in this way.

previously the reduce_mid and broadcast makes all solve the problem under three dimension array. I guess it is possible to reduce all problem to three dimension array? Collapsing other dimensions before and after the target axis

@tqchen The major problem here is the handling of non contiguous case. E.g, broadcasting (5,1,3,1,2) with (5,4,3,4,2). We need to broadcast over multiple axes that are separated.

I see, so can we do the mid solution for one axis, and the range switch for the non continguous cases? So broadcast on one axis works for any dimensions

Yes, this is a good solution. Also, for the non-contiguous case, I can remove the RANGE_SWITCH by get shape with a fixed large NDIM (by padding ones to the shape vector). This seems to be acceptable and will not cause too many additional computation.

sounds good

let me know when you updated the code so we can merge it in

@tqchen I've changed the code. The data are read with ndim=3 if possible. For general case, I use ndim=7.

please remove the rand switch for now since we discourage the use of it. Then i will merge it in

@tqchen I've removed MXNET_RANGE_SWITCH and rebased.


ConCom List Staff Performance Improvements

This PR includes performance improvement code that is built upon the Controller -> Service -> Repo pattern that was introduced in this PR: https://github.com/CON-In-A-Box/CIAB-Portal/pull/647
This code more fully leverages the pattern and demonstrates how we can leverage it to make requests to the DB and cleanly format the response.
There are probably some additional optimizations that could be done where I am currently looping through departments and members by better use of the PHP arrays to leverage keys for the queries. After a few quick tests locally I'm not sure that it will matter too much, but we could consider it for the future.
There are no tests added for the specific service classes here, but I was able to verify the output matched between the original call and new call using JSON responses from the API and running through a JS test (not committed).
In cases where functions are added for convenience (such as findDepartmentsById), the full object was not pulled from the database. Instead, only enough for the API to perform the next step in its processing was retrieved and used.
I did some quick sample testing with ~33 staff as the highest in a single division and saw:

Original Request was averaging about 335ms per request
Updated Request was averaging about 94ms per request

I then added more staff manually to see how much of a performance boost we were getting with this as the size of staff per department increased. I tested again with 77 staff and saw these results:

Original request for that division was 632ms for the first attempt, 580ms for the second.
Updated request for that division was 85ms for the first attempt, 84ms for the second.

I added a few more so that I was over 100 staff in a single division and saw:

Original request around 730ms or so
Updated request was still 85ms

When doing API changes I feel like it is better try to to refer to the API changes instead of the feature request.

To make sure I'm on the same page and understanding, are "API changes" in this context meaning, the changes required to get the server's API output in parity with the existing implementation, or does it mean the programmatic APIs we are calling on the server to eventually get there?

When doing API changes I feel like it is better try to to refer to the API changes instead of the feature request.

To make sure I'm on the same page and understanding, are "API changes" in this context meaning, the changes required to get the server's API output in parity with the existing implementation, or does it mean the programmatic APIs we are calling on the server to eventually get there?

By 'API changes' I pretty much mean anything in the 'API` directory.  So basically anything having to do with the RESTful API.

I rebased onto the latest changes from https://github.com/CON-In-A-Box/CIAB-Portal/pull/647 and adjusted this to use buildResource in its controller as well. Everything looked good locally and all of the changes from the other PR also looked good with these changes as well.
I will take a look at this and rebase immediately once https://github.com/CON-In-A-Box/CIAB-Portal/pull/647 has been merged into Main

Everything has been moved accordingly. I also added some caching, although this code will not leverage that as it only calls for the current event and then uses that elsewhere.