LVS/DRC tests never seems to fails

Expected Behavior
https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/main/rules/klayout/drc/testing/run_regression.py and https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/main/rules/klayout/lvs/testing/run_regression.py should populate an error status that represents the aggregated failure and success state of the test cases.
Actual Behavior
https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/main/rules/klayout/drc/testing/run_regression.py and https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/main/rules/klayout/lvs/testing/run_regression.py never seems to exit with a status != 0.

ideally we would have a synthetic PR that demonstrate that the current regression CI setup fails when an pcell/gds is submitted.

@proppy I'm not sure what you want to do here. Make a PR that would fail CI?

@atorkmabrains yes, I'm trying to assess if the python scripts in https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/blob/main/rules/klayout/drc/testing/ exit with a status != 0. From reviewing the different code paths that doesn't seems to be the case.
/cc @QuantamHD

Yes please, send a pull request with a DRC error in it to demonstrate the automation would detect the problem.

@proppy and @mithro we have discussed this more than 3 months ago and we had a pull request to make sure that is the case that was not integrated in the repo:
https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/pull/51

@mithro and @proppy Could you please integrate all the pending PRs before evaluation?

@mithro the main branch here still uses the original device names. We have stopped working on fixes until you approve those in. I urge you to give me maintainer access to straighten the PDK out for proper usage??

@proppy should we close this one and point to #51 ?

@mkkassem @atorkmabrains I think you can easily create a separate the DRC pull request this way:
# clone upstream repo
git clone https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr
cd globalfoundries-pdk-libs-gf180mcu_fd_pr
# add your fork remote
git remote add mabrains git@github.com:mabrains/globalfoundries-pdk-libs-gf180mcu_fd_pr.git
git fetch mabrains
# create feature branch
git checkout -b improve-drc-failure
# checkout (only) drc changes
git checkout mabrains/main rules/klayout/drc
# create a new collapsed commit for (only) drc changes
git commit -m 'rules/klayout/drc: improve drc failure mode and documentation'
# push back to your fork
git push mabrains improve-drc-failure
# create the pull request

and do something similar that capture the DR changes.

@proppy I have discussed that with @mithro before. That can't be done. Primitive renaming is a lateral change that affects everything and if you take one part and leave the other parts of the PDK unchanged, it will break the PDK. And there is another issue, doing PR will not work as well as the amount of changes are massive. And github doesn't allow that. I have shown this to @mithro and @mkkassem. That's why I was asking you guys to get the primitives renaming PRs in first before we change anything.

For DRC:
The renaming changes don't seems to affect the drc checks/rules (I couldn't find any drc renaming changes in https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/pulls.
So you should be able to following the first set of instruction in https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/issues/64#issuecomment-1311154847 to submit a PR that only include the DRC error checking and documentation changes.

For LVS, the renaming changes do affect the testcases, so I think the approach we want to follow here is a slighty revised version of what I suggested earlier:
# clone upstream repo
git clone https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr
cd globalfoundries-pdk-libs-gf180mcu_fd_pr
# add your fork remote
git remote add mabrains git@github.com:mabrains/globalfoundries-pdk-libs-gf180mcu_fd_pr.git
git fetch mabrains
# create feature branch
git checkout -b improve-lvs-failure
# checkout (only) change that improve lvs failure mode and their documentation
git checkout mabrains/main rules/klayout/lvs/*.{md,py,lvs} rules/klayout/lvs/testing/{Makefile,*.py}
# create a new collapsed commit for (only) lvs changes
git commit -m 'rules/klayout/lvs: improve lvs failure mode and documentation'
# push back to your fork
git push mabrains improve-lvs-failure
# create the pull request

And then we should be able to rebase the opened renaming PRs on top of this change, directly from the github UI (as they wouldn't be conflicting) and be able to exercise the test suite to review them.

@atorkmabrains This issue has been addressed in Efabless/PV repo

@proppy This has been addressed in PV repo. Also, we moved LVS to PV repo and no longer part of PR repo.

I'll close the ticket.


[Event Request] Table 37 in Function UpdateVATOnLines

Dear ALAppExtensions team,
We would like to have the following publishers located in the function UpdateVATOnLines on Table 37:
//START New Event
OnUpdateVATOnLinesOnBeforeCalculateNewAmountIncludingVAT(SalesHeader,SalesLine);
//STOP New Event
if QtyType = QtyType::General then
	if SalesHeader."Prices Including VAT" then begin
		if (VATAmountLine.CalcLineAmount = 0) or ("Line Amount" = 0) then begin
			VATAmount := 0;
			NewAmountIncludingVAT := 0;
		end else begin
			VATAmount :=
			  TempVATAmountLineRemainder."VAT Amount" +
			  VATAmountLine."VAT Amount" * CalcLineAmount / VATAmountLine.CalcLineAmount;
			NewAmountIncludingVAT :=
			  TempVATAmountLineRemainder."Amount Including VAT" +
			  VATAmountLine."Amount Including VAT" * CalcLineAmount / VATAmountLine.CalcLineAmount;
		end;
		OnUpdateVATOnLinesOnBeforeCalculateNewAmount(
		  Rec, SalesHeader, VATAmountLine, TempVATAmountLineRemainder, NewAmountIncludingVAT, VATAmount);
		NewAmount :=
		  Round(NewAmountIncludingVAT, Currency."Amount Rounding Precision") -
		  Round(VATAmount, Currency."Amount Rounding Precision");
		if ("VAT %" <> 0) and (VATAmountLine.CalcLineAmount <> 0) then
			NewVATBaseAmount :=
			  TempVATAmountLineRemainder."VAT Base (Lowered)" +
			  VATAmountLine."VAT Base" * (1 - SalesHeader."VAT Base Discount %" / 100) *
			  CalcLineAmount / VATAmountLine.CalcLineAmount
		else
			NewVATBaseAmount := NewAmount;
	end else begin
		if "VAT Calculation Type" = "VAT Calculation Type"::"Full VAT" then begin
			VATAmount := CalcLineAmount;
			NewAmount := 0;
			NewVATBaseAmount := 0;
		end else begin
			NewAmount := CalcLineAmount;
			if ("VAT %" <> 0) and (VATAmountLine.CalcLineAmount <> 0) then
				NewVATBaseAmount :=
				  TempVATAmountLineRemainder."VAT Base (Lowered)" +
				  VATAmountLine."VAT Base" * (1 - SalesHeader."VAT Base Discount %" / 100) *
				  CalcLineAmount / VATAmountLine.CalcLineAmount
			else
				NewVATBaseAmount := NewAmount;
			if VATAmountLine."VAT Base" = 0 then
				VATAmount := 0
			else
				VATAmount :=
				  TempVATAmountLineRemainder."VAT Amount" +
				  VATAmountLine."VAT Amount" * NewAmount / VATAmountLine."VAT Base";
		end;
		OnUpdateVATOnLinesOnBeforeCalculateNewAmount(
		  Rec, SalesHeader, VATAmountLine, TempVATAmountLineRemainder, NewAmount, VATAmount);
		NewAmountIncludingVAT := NewAmount + Round(VATAmount, Currency."Amount Rounding Precision");
	end
//START New Event
OnUpdateVATOnLinesOnAfterCalculateNewAmountIncludingVAT(SalesHeader,SalesLine);
//STOP New Event

[IntegrationEvent(false, false)]
local procedure OnUpdateVATOnLinesOnBeforeCalculateNewAmountIncludingVAT(var SalesHeader: Record "Sales Header"; SalesLine: record "Sales Line")
begin
end;

[IntegrationEvent(false, false)]
local procedure OnUpdateVATOnLinesOnAfterCalculateNewAmountIncludingVAT(var SalesHeader: Record "Sales Header"; SalesLine: record "Sales Line")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


How to use the netrc file with the generic extractor?

Is machine generic supposed to work?
Should we use the hostname as the machine name for the generic loader?

Reading the generic extractor code it seems that this is something not yet supported.

Authentication is technically impossible with generic extractor.

One could use a default BasicAuth authentication backend.


Redis host can't be an URL

Describe the bug
The redis host address can only be an IP. This is strange because the DB host can be a URL.
I was discussing in another issue https://github.com/drogonframework/drogon/issues/1022 but decide to open this one.
To Reproduce
Steps to reproduce the behavior:

Install the package using vcpkg (vcpkg install hiredis:x64-windows drogon[core,postgres,redis,ctl]:x64-windows)
vcpkg integrate install
drogon_ctl create project project_1 & cd project_1 & cmake . .
Get a docker container for postgres
a. docker pull postgres:latest
b. docker container run -e POSTGRES_USER=user -e POSTGRES_PASSWORD=pass -p 5432:5432 -d postgres:latest
Get a docker container for redis
a. docker pull redis:alpine
b. docker container run -p 6379:6379 -d redis:alpine
Change the config.json to accept the postgres (user: user, passwd: pass, host: host.docker.internal) and redis (host: host.docker.internal)
cd controller & drogon_ctl create controller ApiController
Try to run a postgres query (should work)
Try to execute redis command (should fail)

To Fix
Change the redis host to the ip of host.docker.internal (found in the hosts file)
Expected behavior
Both postgres and redis should accept a url as the host.
Desktop (please complete the following information):

OS: Windows 10 19043.1165
Browser: Chrome/Postman
Version: 1.29.81/8.12.1

try:
Windows
cat C:\Windows\System32\drivers\etc\hosts
your cat.exe is on {git-installation-directory}\usr\bin

Linux
cat /etc/hosts

expected:
...
...

# Added by Docker Desktop
XXX.XXX.X.XXX host.docker.internal # <---- your IPv4 Address
XXX.XXX.X.XXX gateway.docker.internal # <---- your IPv4 Address
# To allow the same kube context to work on the host and the container:
<IP_ADDRESS> kubernetes.docker.internal
# End of section

or
...
...
XXX.XXX.X.XXX   host.docker.internal # <---- your IPv4 Address
XXX.XXX.X.XXX   gateway.docker.internal # <---- your IPv4 Address
<IP_ADDRESS>       kubernetes.docker.internal

your Redis address might be <IP_ADDRESS> or your IPv4 Address and 6379 as Redis default port,
check your ip, either use ipconfig on Windows or ifconfig from net-tools apt on Linux

If those doesn't work, I have no idea. Never used Redis.

As I said, I was able to fix the problem, but I think it's kinda odd that the postgres driver accept a URL and redis doesn't. So I was wandering if it's the expected behaviour.
I know that the porpouse of redis is to be a fast cache/key-val cheking and not having a DNS lookup can help with latency.

This depends on the ability of the C driver of redis (or postgres), and drogon does not extend DNS behavior.

So the "problem" lies in the hiredis implementation ?

@Gab-Menezes Today, I did some tests to connect to redis server with 'localhost' string via hiredis but I failed, It seems it should work according to some examples of the redis client, I'm not sure if I missed something, you could try it by yourself, please let me know if you succeed.

Ok, I will try in the future, right now I'm kinda busy with work and college, and also working on a PR for eager loading/model caching for the ORM, if you want to know more about I can open a issue about it.


add base path for kiali and jaeger

As request by @gyliu513 , open this PR for release-1.1.
Here is original PR in master: https://github.com/istio/istio/pull/9469
Signed-off-by: Chun Lin Yang<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @clyang82. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/cc @gyliu513

/ok-to-test

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gyliu513
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [gyliu513]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@clyang82: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test istio-integ-k8s-tests

prow/e2e-mixer-no_auth-mcp.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@clyang82: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test e2e-mixer-no_auth-mcp

prow/istio-integ-local-tests.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
be4585d6f8bd114dc90a4efd517024240368eb1e
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: gyliu513, linsun
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [gyliu513,linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Timeouts when creating istio custom resources on eks (bookinfo specifically)

Describe the bug
A clear and concise description of what the bug is.
kubectl apply -f samples/bookinfo/networking/bookinfo-gateway.yaml  -n bookinfo
Error from server (Timeout): error when creating "samples/bookinfo/networking/bookinfo-gateway.yaml": Timeout: request did not complete within allowed duration
Error from server (Timeout): error when creating "samples/bookinfo/networking/bookinfo-gateway.yaml": Timeout: request did not complete within allowed duration

Expected behavior
A clear and concise description of what you expected to happen.
It should create the resources.
Steps to reproduce the bug
Steps to reproduce the behavior.
Install istio 1.0 on eks and follow the bookinfo tutorial.  Creating the deployments and manual sidecar injection works, but creating the custom istio resources fails.
Version
What version of istio and Kubernetes are you using? Use istioctl version and kubectl version
❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.1", GitCommit:"b1b29978270dc22fecc592ac55d903350454310a", GitTreeState:"clean", BuildDate:"2018-07-18T11:37:06Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.3", GitCommit:"2bba0127d85d5a46ab4b778548be28623b32d0b0", GitTreeState:"clean", BuildDate:"2018-05-28T20:13:43Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
 ~                                                          14:35:32  uye976
❯ istioctl version
Version: 1.0.0
GitRevision: 3a136c90ec5e308f236e0d7ebb5c4c5e405217f4
User: root@71a9470ea93c
Hub: gcr.io/istio-release
GolangVersion: go1.10.1
BuildStatus: Clean

Is Istio Auth enabled or not?
Did you install the stable istio.yaml, istio-auth.yaml.... or if using the Helm chart please provide full command line input.
helm install --name=istio --namespace=istio-system install/kubernetes/helm/istio --set sidecarInjectorWebhook.enabled=false,grafana.enabled=true,kiali.enabled=true,tracing.enabled=true,servicegraph.enabled=true,gateways.istio-ingressgateway.type=NodePort,gateways.istio-egressgateway.type=NodePort

Environment
Which environment, cloud vendor, OS, etc are you using?
EKS, using weave cni.
Cluster state
If you're running on Kubernetes, consider following the
instructions
to generate "istio-dump.tar.gz", then attach it here by dragging and dropping
the file onto this issue.

This is likely because webhooks do not work on EKS.  See https://istio.io/about/notes/1.0/#known-issues-with-1-0
Try turning off galley.
Cheers
-steve

You can disable the validation webhook with the --set global.configValidation=false helm option.


regex support for -a

Hi
Thanks for a great tool; makes so many things easier on various machines!
Some of my eget commands appear to be using asset filtering like -a tar.gz -a ^sig (e.g., caddyserver/caddy is one example off the top of my head).
Would be nice to be able to say -a tar.gz$.  I saw some mention of regex in various issues, but they all appeared to be more about priority between --system and --asset.
Please note this is only about convenience, so I'm OK if your response is a WONTFIX, but had to ask anyway :)

Hmm I've been trying to avoiding using regexes to reduce the complexity, and avoid problems with special characters like .. I wonder if the best solution is to have a new option for special cases that is like -a but uses a regex.

This is something I'd be interested in working on if no one else wants to pick it up.


Statements not being stored

Hey Oliver,
I am trying to get the statements to be stored and am having no luck. I turned on the console debugging, and statements are being captured via h5pxapikatchu but they don't seem to be displayed in the WP back-end (wp-admin/admin.php?page=h5pxapikatchu_options). I get the following message:

There is no xAPI information stored.

I've checked my database, and the tables are being created:
wp_h5pxapikatchu, wp_h5pxapikatchu_actor, wp_h5pxapikatchu_result, wp_h5pxapikatchu_verb.
There are statements being stored in the wp_h5pxapikatchu table. Belong is an example:
{"actor":{"name":"ivadmin","mbox":"mailto:samara@name.com.au","objectType":"Agent"},"verb":{"id":"http://adlnet.gov/expapi/verbs/interacted","display":{"en-US":"interacted"}},"object":{"id":"http://name.com.au/clients/name/wp-admin/admin-ajax.php?action=h5p_embed&id=6?subContentId=b535852c-7543-4b8a-bd08-93eb094f123c","objectType":"Activity","definition":{"extensions":{"http://h5p.org/x-api/h5p-local-content-id":6,"http://h5p.org/x-api/h5p-subContentId":"b535852c-7543-4b8a-bd08-93eb094f123c"},"name":{"en-US":"Where should you store Gavin and the gang to keep them fr..."}}},"context":{"contextActivities":{"parent":[{"id":"http://name.com.au/clients/name/wp-admin/admin-ajax.php?action=h5p_embed&id=6","objectType":"Activity"}],"category":[{"id":"http://h5p.org/libraries/H5P.MultiChoice-1.10","objectType":"Activity"}]},"extensions":{"http://id.tincanapi.com/extension/ending-point":"PT33S"}}}
I have tried enabling Store complete statements in-case that was causing an issue but that did not resolve it either.
Am I looking in the wrong place for this data?
Thanks for creating this plugin!

Hi Samara!
Thanks for reaching out and sorry that you're having trouble.
Where exactly would the example that you posted be stored in the wp_h5pxapikatchu table? It only has some fields for IDs of the other tables, and what you copied is a complete xAPI statement in JSON format.
If the table instead is still empty: Are you testing your content on the admin dashboard of WordPress? No statements are stored then, because that'd mess with your statistics.
If possible, you might also have a look at the PHP error log of the server. If there's still a bug in the code, it might have left some traces there.
Best,
Oliver

Hi Oliver,
Sorry, I should have posted the entire row (attached an image). I am testing the content with a public facing page (H5P shortcode), I've tried it while logged in and not.
I have debugging turned on and nothing seemed to come up, but I'll another look at the the logs when I am back in the office.

For whatever reason, the column "id_object" contains 0, so there's no object data to link to. It seems, that on your setup, somewhere the true id is lost -- can't say why.
How does the object table look like?

I've removed the plugin and made sure the collation of all of my tables are the same as the one being set by your plugin. This is the error log being generated when I activate the plugin:
[21-May-2018 23:31:02 UTC] WordPress database error You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '(id) 		) DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_520_ci' at line 10 for query CREATE TABLE wp_h5pxapikatchu_object ( 			id mediumint(9) NOT NULL AUTO_INCREMENT, 			xobject_id TEXT, 			object_name TEXT, 			object_description TEXT, 			object_choices TEXT, 			object_correct_responses_pattern TEXT, 			h5p_content_id INT(10), 			h5p_subcontent_id VARCHAR(36) 			PRIMARY KEY (id) 		) DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_520_ci made by activate_plugin, do_action('activate_h5pxapikatchu/h5pxapikachu.php'), WP_Hook->do_action, WP_Hook->apply_filters, H5PXAPIKATCHU\on_activation, H5PXAPIKATCHU\Database::build_tables, dbDelta [21-May-2018 23:31:02 UTC] PHP Notice:  wpdb::prepare was called incorrectly. The query argument of wpdb::prepare() must have a placeholder. Please see Debugging in WordPress for more information. (This message was added in version 3.9.0.) in /home/name/public_html/clients/interactive_video/wp-includes/functions.php on line 4147 [21-May-2018 23:31:02 UTC] PHP Notice:  wpdb::prepare was called incorrectly. The query does not contain the correct number of placeholders (0) for the number of arguments passed (1). Please see Debugging in WordPress for more information. (This message was added in version 4.8.3.) in /home/name/public_html/clients/interactive_video/wp-includes/functions.php on line 4147
As an aside, this warning is coming up as well:
[21-May-2018 23:30:03 UTC] PHP Deprecated:  Non-static method H5PXAPIKATCHU\PrivacyPolicy::add_privacy_policy() should not be called statically in /home/name/public_html/clients/interactive_video/wp-includes/class-wp-hook.php on line 286

The collation is set by WordPress. I used the same pattern as suggested in the official coding guide. I'll try to reproduce the problem on my system and see what I can do.
Thanks for the other hint as well. That's an easy fix.

I just browsed the code, and the problem seems to be a missing comma at the end of https://github.com/otacke/h5pxapikatchu/blob/master/class-database.php#L72
I guess some databases are more tolerant and ignore the error. Could you try if adding a comma fixes the bug on your end? It's the middle of the night in Norway, and I'm waiting to fall asleep ;-)

Hah, fair enough. The day is just starting here in Australia. ;)
I updated the comma and it did fix it! Thanks for staying up.

Well, thanks a lot for unvoluntarily hunting the bug! I'll fix both issues today and upload an update.


Re implement logical plan walker

The last three commits are for addressing above comments.

I will merge this PR now. The next task then is to extend the new TextBasedLogicalPlanPrinterImpl2 class that you introduce in this PR, by adding the functionality to print logical plans as shown in the mockup.

For that implementation you should not anymore use the toString() functions of the operators.


Interesting output after running script

Hi,
I just updated the script and thought i'd run it then noticed something interesting:
Synology_HDD_db v2.2.47
DS1821+ DSM 7.2-64551 RC
Using options:

HDD/SSD models found: 6
ST8000DM0004-1ZC11G,DN01
WD60EFAX-68JH4N1,0A83
WD60EFAX-68SHWN0,0A82
WD60EFRX-68L0BN1,0A82
WD60EFRX-68MYMN1,0A82
WD60EFZX-68B3FN0,0A81

M.2 drive models found: 2
Samsung SSD 970 EVO Plus 1TB,1B2QEXM7
Samsung SSD 970 EVO Plus 1TB,2B2QEXM7

No M.2 cards found

Expansion Unit models found: 1
DX517

Added ST8000DM0004-1ZC11G to ds1821+_host_v7.db
Added ST8000DM0004-1ZC11G to dx517_v7.db
Added WD60EFAX-68JH4N1 to ds1821+_host_v7.db
Added WD60EFAX-68JH4N1 to dx517_v7.db
Added WD60EFAX-68SHWN0 to ds1821+_host_v7.db
Updated WD60EFAX-68SHWN0 to dx517_v7.db
Added WD60EFRX-68L0BN1 to ds1821+_host_v7.db
Updated WD60EFRX-68L0BN1 to dx517_v7.db
Added WD60EFRX-68MYMN1 to ds1821+_host_v7.db
Updated WD60EFRX-68MYMN1 to dx517_v7.db
Updated WD60EFZX-68B3FN0 to ds1821+_host_v7.db
Updated WD60EFZX-68B3FN0 to dx517_v7.db
Added Samsung SSD 970 EVO Plus 1TB to ds1821+_host_v7.db
Updated Samsung SSD 970 EVO Plus 1TB to ds1821+_host_v7.db

Support disk compatibility already enabled.

Support memory compatibility already enabled.

M.2 volume support already enabled.

Drive db auto updates already enabled.

DSM successfully checked disk compatibility.

You may need to reboot the Synology to see the changes.

Note it finds my 2 M.2 cards then says immediately after that there are non found. I'm not sure if this is a problem or not, or just a small bug but thought it was best to report it.
Also, have you implemented the auto-update feature yet? If so, how do I enable it please?
Thanks.

HDD/SSD models found: 6
ST8000DM0004-1ZC11G,DN01
WD60EFAX-68JH4N1,0A83
WD60EFAX-68SHWN0,0A82
WD60EFRX-68L0BN1,0A82
WD60EFRX-68MYMN1,0A82
WD60EFZX-68B3FN0,0A81

The HDDs are all showing only the last 4 characters of their firmware version. This is due to a change in DSM 7.2

No M.2 cards found

That is actually referring to PCIe cards that you can install M.2 drives on like the M2D20, M2D18 and E10M20-T1.
I should change the "No M.2 cards found" to "No M.2 PCIe cards found" to make it clearer.
I've fixed the HDD 4 character firmware version issue and added auto-update, but the release is still RC.
https://github.com/007revad/Synology_HDD_db/releases/tag/v2.3.51-RC
The --autoupdate=[age] option requires a digit for the number of days after new version is released to wait before updating. You can use --autoupdate=0 to update right away. The script also reloads itself so when you run it unattended (scheduled) it can update itself and run the new version.

I didn't actually notice the lack of digits on the firmware version but glad to know it's another bug squished :)
Thanks for confirming what the M.2 line means also :)
And I really like how you've added that it will update itself and then run itself again. I'm going to wait for the official release though to be sure it's good :)
Just to confirm though, when I do set it, my current script is set in Synology Task manager with the script as follows:
/volume1/syno_hdd_db.sh
Would I change this to:
/volume1/syno_hdd_db.sh --autoupdate=0
or does it need to go in some quotes because there's a space like so:
"/volume1/syno_hdd_db.sh --autoupdate=0"
Thanks for all your help :)

@70m7E I don't think you need both scripts, I think the syno_hdd_db.sh script does it all.... but i'm not 100% so maybe @007revad could confirm?
I'm running M.2's as volumes and i'm only running the syno_hdd_db.sh script at boot personally.

May I just ask here for the "unattended" - do you recommend scheduled tasks as root at shutdown or boot-up when running both hdd_db and enable_m2 script? The guide recommends both depending on script.

Yes, I if you need the enable_m2 script I would add it to the same schedule as hdd_db, so you'd have 2 lines in the scheduled task: 1 for each script.

@TheCableGuy99

Would I change this to:
/volume1/syno_hdd_db.sh --autoupdate=0

Yes.
You would need quotes if the path had a space, and then you'd only quote the path/filename part like:
"/volume1/my path/syno_hdd_db.sh" --autoupdate=0
If you want to also use the -n and -f options you'd use:
/volume1/syno_hdd_db.sh --autoupdate=0 -nf
Or
/volume1/syno_hdd_db.sh --autoupdate=0 -n -f


Ng-zorro-antd's antd icon is inconsistent with the official Antd icon

https://ng.ant.design/version/0.7.x/docs/introduce/zh


RabbitMQ rate based trigger (Published/sec.)

Proposal
Add a trigger based on the Published/sec. metric on a queue.
Use-Case
We have a workload that has a Publishing rate that varies between 1k and 3k/sec. When we are keeping up with the throughput, the Ready count on the queue is 0 regardless of the Publishing rate. Even using the Unacked count, that stay around a few hundred, independent of the Publishing rate. While handling 3k/sec. requires three times the instances as 1k/sec., the metrics I can choose now look identical. I have to wait for scaling to reach min. instances (since Ready == 0), then wait for a backlog to build up (since we're running too few instances to keep up), then have the instances scale up to something (since Ready > 0 now) and keep scaling up until we're at a high enough instance count to work through the backlog, reach Ready == 0 again and scale back down to min. instances.
This keeps bouncing between min. instances and some scaled up count over and over again.
I would expect to be able to configure two triggers

X messages/sec. per instance to scale against the Published/sec. rate on the queue (to handle the steady-state happy path)
Y backlog (Ready/Unacked backlog) per instance (to handle cases where a dependency slowed or stopped processing for a while or otherwise failed to keep up)

I can take a look at this.

Draft PR here: https://github.com/kedacore/keda/pull/1648
I appear to be having issues connecting to the http API over https so that's holding up verifying this locally.

Makes sense!


BUG: The nav items are not visible in dark mode

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

the items are not visible in dark mode which is a major bug that needs to be sorted!
Please assign me this issue
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I am interested in this project...Please assign me this issue

Go ahead @Aanyaa26

@arghadipmanna101  is this issue fixed if  not can you please assign to me

@arghadipmanna101 is this issue fixed if not can you please assign to me


send_message was changed to behave synchronously? Then, how can I send a message after view is finished?

Question
In earlier versions than 17.x, send_message was executed after view was done. But, in 17.x it seems different so that send_message is synchronously called. If so, how can I send a message which should be executed after view is finished?
What I've tried (optional)

You can send a message in the rendered() lifecycle method. Does that work for you?

It does not work in the case where different procedures are supposed to be accomplished according to messages sent to update() . If any other benefits from the change are not that apparent, I think the previous behavior should be preferred. What do you think?

@sehkone Could you give an example of what you're trying to do that is no longer possible?
Correct me if I'm wrong but I don't think the behaviour of Scope::send_message was changed from 0.16 to 0.17. The update method should still be called after view has finished.
Perhaps you're talking about the newly added comment in the documentation:

Please be aware that currently this method synchronously schedules a call to the Component interface.

It might be a bit confusing but this is only true if the method is called outside of the scheduler. Or more specifically, if the scheduler isn't currently running.

Correct me if I'm wrong but I don't think the behaviour of Scope::send_message was changed from 0.16 to 0.17.

You're right, I believe it changed in 0.16 actually

It might be a bit confusing but this is only true if the method is called outside of the scheduler. Or more specifically, if the scheduler isn't currently running.

Yeah, that is a bit confusing. I wonder if we can get away with not talking about the scheduler internals and provide some high level behavior expectations that devs can count on.
Anyways, I'm also curious what your example is @sehkone. We aim to provide the best experience possible! The change was done to improve rendering performance by the way

    fn update(&mut self, msg: Self::Message) -> ShouldRender {
        match msg {
           ...
            Message::FetchData => {
                A
                self.link.send_message(Message::RenderCharts);
            }
            Message::RenderCharts => {
               B
            }
           ...
       }
       true

In 0.16, the procedure was

Message::FetchData is sent to update().
the code A  in the match block is executed.
view() is executed.
Message::RenderCharts is sent to update().
the code B is executed.
view() is executed.

In 0.17, the same procedure?

@sehkone 0.17 should still behave exactly like that.
Did you run into a situation where your code doesn't behave as you'd expect?

@siku2 0.17 doesn't behave that way. It processes messages eagerly

@jstarry are you sure?
I wrote a simple example based on the code given by @sehkone:
match msg {
    Msg::A => {
        ConsoleService::log("update: a");
        self.link.send_message(Msg::B);
    }
    Msg::B => {
        ConsoleService::log("update: b");
    }
}

Full Code

use yew::services::ConsoleService;
use yew::{html, Component, ComponentLink, Html, ShouldRender};

pub enum Msg {
    A,
    B,
}

pub struct Model {
    link: ComponentLink<Self>,
}
impl Component for Model {
    type Message = Msg;
    type Properties = ();

    fn create(_: Self::Properties, link: ComponentLink<Self>) -> Self {
        Model { link }
    }

    fn update(&mut self, msg: Self::Message) -> ShouldRender {
        match msg {
            Msg::A => {
                ConsoleService::log("update: a");
                self.link.send_message(Msg::B);
            }
            Msg::B => {
                ConsoleService::log("update: b");
            }
        }
        true
    }

    fn change(&mut self, _: Self::Properties) -> ShouldRender {
        false
    }

    fn view(&self) -> Html {
        ConsoleService::log("view");
        html! {
            <div/>
        }
    }

    fn rendered(&mut self, first_render: bool) {
        if first_render {
            self.link.send_message(Msg::A);
        }
    }
}

And the output matches:
view // first render
update: a
view
update: b
view

Maybe I misunderstood something?

Ah sorry. I think I was talking about something else.. view is called directly after the message but it gets rendered to the dom lazily.

@sehkone 0.17 should still behave exactly like that.
Did you run into a situation where your code doesn't behave as you'd expect?

Yes, I did.
            Message::FetchData => {
                ...
                set up div elements for drawing charts and they are created by calling view()     // part A
                ...
                self.link.send_message(Message::RenderCharts);
            }
            Message::RenderCharts => {
                draw_chart(); // call a javascript function which draws charts on div elements  // part B
            }

In 0.16, after Message::FetchData and part A, div elements are created and Message::RenderCharts is sent to update(). Then, part B successfully executes draw_chart().
But, in 0.17, after part A, draw_chart() is called before the creation of div elements by view().
To clarify the situation, I tested the below.
            Message::FetchData => {
                ...
                set up div elements for drawing charts and they are created by calling view()
                ...
                self.render_chart = true;
            }
            Message::RenderCharts => {
                draw_chart(); // call a javascript function which draws charts on div elements
            }

    fn rendered(&mut self, _first_render: bool) {
        if self.render_chart {
            self.link.send_message(Message::RenderCharts);
            self.render_chart = false;
        }
    }

Instead of directly sending Message::RenderCharts in update(), I sent it in rendered() and this works fine. In this case, div elements were created by view() after Message::FetchData and draw_chart() did its job well.
I think there is a difference between 0.16 and 0.17 regarding execution order.

@sehkone you're right. The difference is that we don't necessary update the DOM in between updates. I've added this note the "Breaking changes" section of the release notes.
We might have to reconsider this approach if it becomes a more common confusing point. For now, I think the rendered() works well so I don't think a hot fix is needed

@jstarry
Using rendered works well for me. However, I'm not sure if it is theoretically correct, let me know if this makes sense or not:
Consider the case where the DOM is updated between update():

Update Msg::A
Render A's changes
Update Msg::B
Render B's changes
Update Msg::C

I need step 5 to happen after step 4.
To do this in 0.17, in "Update B", I do self.planned.push(Msg::C),
in rendered(), I call self.link.send_message_batch(self.planned). Is this a correct implementation?
For this sequence of action, the above implementation would fail:

Update Msg::A
Update Msg::B
Render A's changes
rendered is called
Update Msg::C
Render B's changes

I don't know for sure when rendered is called which state of the app is being rendered, it could be a render from previous state changes.

Yeah that's a correct implementation. That's not ideal that a dev would have to batch messages like this. I suppose Yew should do this for you internally. I think that's patch-worthy

I understand every updates are not necessary considering performance. But, the update() returns ShoudRender and I feel like it's supposed to guarantee re-rendering when true returns. Moreover, it is a little confusing to me that view() is called but rendering may not be accomplished.

Good points @sehkone, thank you!

@sehkone and @juchiast could you please try out master and let me know if it works as expected? Once you confirm, I'll push out 0.17.2 with the fix!

@jstarry It works as expected. I really appreciate your efforts and thank all of you.

Fix has been released in 0.17.2!


Appears broken in last update

Since the last update my shortcut no longer opens my report.
Shortcut now opens Power Bi to the home screen then navigates to My Workspaces and the spinner just spins.
Deleted and readied shortcut without success.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: afadb43c-aeb1-0570-2237-45ac596b4833
Version Independent ID: dee1e434-5ea7-54d0-cb05-1e7ddc1e523f
Content: Power BI mobile app integration with Siri shortcuts - Power BI
Content Source: powerbi-docs/consumer/mobile/mobile-apps-ios-siri-shortcuts.md
Service: powerbi
Sub-service: powerbi-mobile
GitHub Login: @paulinbar
Microsoft Alias: painbar

Hi @jluftman, you've reached the documentation team, and this seems to be more of a product support issue. Can you describe your problem in an email and send it to<EMAIL_ADDRESS>Best sure include something in the subject line like "Shortcuts don't work since last update" or something like that, to focus their attention. They will be the best ones to address your problem. Thanks!

Yeah. The doc page wasn’t clear that is was looking to report a documentation Issa and not an application issue.  All good since there must have been another update a couple days ago since it works again.  (I made no changes on my side)ThanksSent from my iPadOn Mar 13, 2023, at 2:32 PM, Paul Inbar @.> wrote:
Hi @jluftman, you've reached the documentation team, and this seems to be more of a product support issue. Can you describe your problem in an email and send it to @.? Best sure include something in the subject line like "Shortcuts don't work since last update" or something like that, to focus their attention. They will be the best ones to address your problem. Thanks!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@jluftman, Great! Glad to know it worked out, whatever it was.


pie chart selected effect

I am using the react version of this lib.
I want this effect: if I selected a part of the pie, the selected part will move a little out from the center.
Is there an option to do that?
Thanks.

Agreed, explodable pie slices or explode the selected slice is a very much needed feature. I am able to create a drilldown effect by editing the segments, but not the radius or stokeWidth.

+1

Closing: We will not implement this in the core at this time. I'm happy to help someone develop a plugin to achieve this functionality.
The plugin would need to do the following:

Add something to the segment that is selected
Trigger an update of the chart
Adjust the x,y coordinate of the selected arc only after the update has finished (using afterDatasetsUpdate plugin call)

I would very much like to write this plugin.
Is there documentation somewhere on how to write a Chart.js plugin? The basic documentation at http://www.chartjs.org/docs/#advanced-usage-creating-plugins doesn't quite help

@wadacoder there isn't much documentation at the moment but we do have some samples:
https://github.com/chartjs/Chart.Zoom.js
https://github.com/chartjs/Chart.Annotation.js

It's not a plug-in, just a quick js function (for anyone who needs the explode effect quick): https://jsfiddle.net/lkwfahrer/4c7p2ash/.
Please feel free to correct it.

@lkwfahrer  the jsfiddle link doesn't work

@wadacoder , sorry, updated now

@lkwfahrer, there is a problem with edge of pie. Exploded pie slice is cut by canvas border. Click blue slice for example.
I don't know any way to create reserve space between pie and canvas border. Pie always is inscribed in canvas.

Agreed, I'm aware of the problem, my solution is just a quick workaround and has more problems. Ideally just having a pie chart option to switch the explode effect on/off would be perfect.
For this workaround I was thinking to reduce the radius of the whole pie once it's loaded (similarly to how it's done once a piece is clicked), but I haven't yet looked into that.

@lkwfahrer, #3476 fixed it. So, there is option for layout padding:
options: {
  layout: {
    padding: 10
  }
}

I've made plunk to demonstrate it.

If it's of any value, i created a pie with 'exploded' slice and dropshadow.
Created a new chart type and modified pie update methods and Arc draw.
https://codepen.io/yoeri/pen/YxewjY?editors=0010

Is there an option to have all the slices selected programmatically so that depending on the case the inital view would show all labels on - this could be easier on the eye that looking down at the legen and back up to the pie, or having to press on each slice to understand what each one represents.

I found a more general solution that creates this effect statically (without clicking the graph).
 EIther way, I managed to to implement this with just the hover offset. It'd be great if we can create the exploded effect still, but chartjs just point blank refuses to animate the radius property. However much I try:
https://jsfiddle.net/ortonomy/vyzh1npg/346/


Access client via global handle rather than arg passed everywhere.

Address issue #180

The Travis build is failing because GO111MODULE="on" is set in .travis.yaml. That was deleted in a prior checkin.

I think I read too much into your previous comments. I agree with everything you said and pushed some changes to address them. Thanks!


Images in spec document are largely unreadable

In going over the current proposed final draft of the Jakarta Enterprise Web Services specification 2.0, I found the images largely unreadable, even when scaled. Creating this task to record a TODO for someone from the community to port the images over to a vector/scalable format.

Yes, Lukas, sure - I'll happy to do it !!! :)
Let me two weeks - I'll trasform them between one update to "Jakarta EE Tutorial" and the other.
Thank you!
Dmitri.


Naming of files when termbox2 is installed as a library

Hi there - Is it too late to revisit the choice you went with in https://github.com/termbox/termbox2/pull/40 to not name installed library  and header files termbox2?
IMO the fact that the termbox2 project is in a completely separate repository makes it clear cut that it should be able to live side-by-side with the original termbox, without stepping on each other.

Added in a4f92ea


ValueError: height and width must be > 0

Why does the testing phase after training end in errors?
#----------Testing----------#
0%|          | 0/650 [00:00<?, ?it/s]
......
ValueError: height and width must be > 0

And I didn't modify the code


Rename Image to Keyword without Prefix

Hello,
Similar to closed issue to #167, I am trying to name the file by the search phrase, similar to how the prefix works, but not append that to the beginning of the previous file. Basically is it possible for the prefix to become the file name?
Thanks

@whittyskitty just to know a little more on your ask, for example if you are searching for the term stars, do you intend to have file names as

stars.jpg
stars.jpg

??

Closing due to inactivity. Feel free to update the thread when you have additional info.


Restrict behavior to Local volumes only

We've recently had a conflict with the S3 plugin (using Cloudfront). Untransform was applying the baseUrlPrefix value to our Cloudfront URL, which obviously doesn't work:
https://clientsite.com/https://cloudfronturl...

Would it be possible to restrict Untransform's behavior to apply to only Local volumes? It's probably safe to assume that any non-local volume would not need this feature.
Related... should Untransform recognize that it's already working with a full URL, and bypass the prefix addition?

Amazing, thanks @bencroker! 🍺


how to download file?

The docs are pretty messy. All I want to do is generate an xlsx file and then give the user the option to download the new file to their computer.
I am using angular. I already can generate the file. I need help with the downloading part.

https://docs.sheetjs.com/#writing-functions

XLSX.writeFile(wb, filename, write_opts) attempts to write wb to filename. In browser-based environments, it will attempt to force a client-side download.

The angular demo has an example of generating a file and triggering a download: https://github.com/SheetJS/js-xlsx/blob/master/demos/angular/SheetJS-angular.js#L18

Is there an example with angular 2+? @SheetJSDev

https://github.com/SheetJS/js-xlsx/tree/master/demos/angular2 includes examples of a plain angular 2+ app as well as ionic and nativescript targets


Set codecov threshold and target

Problem
Currently codecov fails if the test coverage drops slightly. This is an issue as our tests seem to be non-deterministic and sometimes coverage drops non-signifcantly by -0.04%, -0.1%, 0.5% etc I couldn't investigate if this is an issue with codecov itself not following all test paths or there is some randomness generated in our tests too.
This creates the perception that our main branch is broken because the CI says it failed when it actually didn't.
Solution
My solution is that we should set a codecov threshold of 1% so even if our tests drop slightly the CI shouldn't have this ugly red cross.
But I would like to also set a target that the maintainers of SDK should aim for so this 1% threshold doesn't get abused and we don't fall significantly in our tests coverage. Currently we have approximately 84% coverage so a realistic starting target would be 80%. In my opinion we should aim long term for an 90% target but this might take some time to reach. I think that more than 90% coverage would mean that we will have bloated tests, duplication, time wasted and tests that are hard to read.
Alternatives
disable codecov <3

complete via #2575


Angular 1.5.8 Component Controller Calling twice

Hi ,
When navigating between the views controller(component controller) calling twice.
Angular Version :1.5.8
Router : ngComponentRouter
Please help me to resolve the issue .
Thanks in Advance

The component router is deprecated. You should use uiRouter for advanced routing.


AttributeError: 'Namespace' object has no attribute 'csv_train'

Hello, I tried to run visualize.py  but I got the following error.
Could you please give me some hint to solve this problem.
CUDA available: True Traceback (most recent call last):   File "visualize.py", line 108, in <module>     main()   File "visualize.py", line 41, in main     dataset_val = CSVDataset(train_file=parser.csv_train, class_list=parser.csv_classes, transform=transforms.Compose([Normalizer(), Resizer()])) AttributeError: 'Namespace' object has no attribute 'csv_train'
Thank you

And one more question?
Why do we need train csv and val annotation csv while doing inference ?
can't we detect the object with model and opencv ?
Thank you

See pull request #77 it's one minor change

Thank you, I already solved the problem.


Add Labels below Icons in Toolbar

The Icons in toolbar are difficult to discern. Please add labels to them

Would the feature requested in Issue #230 be sufficient? If so, it might help to add a 👍 there!


cloudyFibonacci-Yohance

Added complexity and features as suggested by Leo.
The fibonacci square houses a snail with a fibonacci spiral shell. The square floats on water, and there are also clouds in the sky.
There were lots of challenges, even after coming up with the fibonacci square. For one, I tried lots of methods to make the fibonacci spiral, and only after lots of trial and error I found out that I could just make one by making arcs with the diameter of fibonacci numbers. Also, making the lines of the snail natural looking was another challenge, as straight lines did not look very realistic. The skin of the snail had to be noisy and jagged, but also consistent and fairly straight. I tried making my own binomal function by dividing the sum of two random numbers between one and six, but that didn't work out too well and I had to use a boilerplate guassian function. Making the clouds was also very interesting.
Prior to this, I did not have too much experience with art in programming as I mostly worked on python and c++ projects dealing with apis, arduinos, etc.

Nice job improving it. Congrats on earning your Blot, you can order it here.


Use gcc-8 and g++-8 in the Dockerfile

This appears to be necessary since <IP_ADDRESS>.
See also https://github.com/google/mediapipe/issues/1733

Thanks for reporting this. Fixed in our internal code base upstream, and will be pushed to GitHub in the next release.

Thank you!

Fixed in https://github.com/google/mediapipe/commit/a9b643e0f5978425d948050a2228398929733d05.


SegFault Mac Book Pro 16 inch intel

Downloaded app but give segFault
Mac OS : Catalina

Thanks for the report. Can I ask if you're able to run from source?

I will try, is there a requirements.txt for pip3?

Added here https://github.com/chidiwilliams/buzz/blob/main/requirements.txt


destroying unsellable items only destroys 1 at a time, instead of all the ones on the junk list

Expected Behavior
all the items on the junk list should be destroyed after clicking the button "Sell / Destroy Junk" with option "also destroy unsellable items" enabled
Actual Behavior
only one of the items gets destroyed at a time. you have to click the button and confirm for each single item.
Steps to Reproduce the Problem

add for example Box of Chocolates (itemid 49909) and "Bravado" Cologne (itemid 49859) to the junk list
under settings, enable "also destroy unsellable items"
click "Sell / Destroy Junk"
it will ask you to confirm, so do that, and you will see that it only deletes one of the items on the list

some further troubleshooting: it's not an addon conflict, I tried it with all other addons disabled, and same story.
also, enabling the throttling option (figured I'd try it just in case) didn't help either.

Hello, this is a Blizzard change, there doesn't seem to be a workaround after it:
https://us.forums.blizzard.com/en/wow/t/deletecursoritem-changed/1168993


custom datapack not working with tetra (synatra connector)

tetra_parry_datapack.zip
I have no Idea what went wrong with it.

{
  "parryAttributes": "sword",
  "items": [
    "tetra:modular_sword",
    "tetra:modular_shortblade"
  ]
}

tetra:modular_shortblade doesn't exist, there is no such item.
Just remove it and everything will be ok.
And remember that setting parry attributes for items doesn't enable parrying with them (i know it's not intuitive, but it was the easiest and fastest way for me to implement).
To be able to parry with modular sword you have to add it to "items_can_parry" tag (data/frycparry/tags/items/items_can_parry.json)


Don't catch Throwable

In several places throughout Chronos, there are catch constructs which respond to java.lang.Throwable. This is far too coarse-grained.
I remind you that Throwable has two direct subtypes: there is Exception, which represents problems which it may be possible to recover from. But there is also Error, which in general represents problems that cannot be recovered from.
The only generally-applicable response to an Error is for the application to commit honorable suicide and let its minder resurrect it once it's finished crashing. In fact, this is what happens if you simply don't catch the thing and let it unwind the stack all the way to the top level.
Catching Exception is odd, but defensible. Catching Throwable seems irresponsible, especially when the response is to merely log the thing and continue on oblivious to the potentially serious problem (as in MailClient.scala, for instance).

This appears to have been fixed some time ago.


Sync: ItemCategory Fields

Description

Sync the values in the Synced list below.
Create an end to end (E2E) tests for all fields (1 for server changing the value and 1 for client changing the value if applicable)
Create a command to test changing each value in game see similar command

Also see additional information at the bottom for more information and templates

Key
Server side only (only allow the running of the function on the server side)
Client side only (only allow the running of the function on the client side)
Client side sync (request the server to change the value, server then changes the value and replies to the client allowing the change)
Server side sync (only server allows running of the function and send to all clients the value changed and clients update the value/call original function)
Synced

Method/Field Name
Sync Type
Additional Information

TODO
TODO
TODO

Deferred

None
Externally Deferred

None
Non-Synced

None
Intended Design

For the patch itself please refer to https://github.com/Bannerlord-Coop-Team/BannerlordCoop/wiki/Patching-Basics#field-patching
Field Sync Dataflow

Integration Testing

Location

Create a branch based from development
Related Issues

Blocked by:

#940

Requirements

N/A
Additional information

Using the GameInterface Service Tempale create commands to test the synced values.
Definition of Done

[ ] Class level comments exist for all new classes.
[ ] XUnit E2E tests exist for every property on the server (and client if applicable)
[ ] Each field has a command getter and setter that used the correct intercept

Only default values used which are registered at start, thus does not need sync.


⚠ Bofrost.fr has degraded performance

In 63b3e34, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1251 ms

Resolved: Bofrost.fr performance has improved in 8c75849.


Switch pylint local disable to use disable-next

pylint disable doesn't do what you think it does, even though everyone on Google thinks it disables the next line....
disable is block scoped, so it disables that lint warning for the duration of the block or until it is reenabled.  disable-next disables the single next line which is a better use case for what we want.

That's a fantastic find. I'm certainly learning a lot more about python tooling than I expected. Definitely a different perspective from C++ land.

Yeah I'm learning a lot too, while I write a lot of scripts in python at work, its been a while since I've look at more "production" level python.  disable-next is relatively new (last 1-2 years), so that is also probably while google is out of date.


Live

Updating branch for publish

Docs Build status updates of commit 1814a27:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/configci/new-cipolicyrule.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Support Cognito User Pools Trait

https://awslabs.github.io/smithy/1.0/spec/aws/aws-auth.html#aws-auth-cognitouserpools-trait
internal id: 176365628

Moved to 2171


request close of server connection via header

allows for more transports, knowning that connections will
will be closed once transaction has completed.
adding header means we don't leak file descriptors.

I am totally buy that this shouldn't be the way this is implemented.  I actually have another idea :)


Fix cpu usage_rate calculation

Hi
This patchset fixes cpu usage_rate, calculation collected by cluster aggregator.
For now there are difference between:
kubernetes.cluster.cpu.usage_rate

and
sumSeries(kubernetes.nodes.*.cpu.usage_rate)

(I use graphite as datasink)
If I understand correctly, it is need to change condition in cluster_aggregator.go from
metricSetType == core.MetricSetTypeNamespace

to
metricSetType == core.MetricSetTypeNamespace

See also https://github.com/kubernetes/heapster/issues/1516
Thanks in advance!

This change is

I think this makes sense -- IIRC, "system containers" can actual contain other containers due to cAdvisor's definition of "system containers".  cc @piosz PTAL as well.

LGTM, thanks!


Verify container image and security on every build

What does this pull request do?
Verify container image and security on every build
Why?
Intent: shorten feedback loop, increase visibility
Otherwise, we could introduce Docker build failures or critical security
problems in builds which we would only notice at main build or the
nightly build

Thanks! 🙇♂


Auto creation of xip.io sub domains break when vsphere cloud-provider is specified

Rancher versions:
rancher/server or rancher/rancher:
rancher/rancher:latest
rancher/agent or rancher/rancher-agent:
?
rancher/rke-tools:v0.1.13
Infrastructure Stack versions:
healthcheck: ?
ipsec: ?
network-services: ?
scheduler: ?
kubernetes (if applicable):
v1.11.1-rancher1-1
Docker version: (docker version,docker info preferred)
Client:
Version:      17.03.2-ce
API version:  1.27
Go version:   go1.7.5
Git commit:   f5ec1e2
Built:        Tue Jun 27 01:35:00 2017
OS/Arch:      linux/amd64
Server:
Version:      17.03.2-ce
API version:  1.27 (minimum version 1.12)
Go version:   go1.7.5
Git commit:   f5ec1e2
Built:        Tue Jun 27 01:35:00 2017
OS/Arch:      linux/amd64
Experimental: false
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
RancherOS v1.4.0
4.14.32-rancher2
NAME="RancherOS"
VERSION=v1.4.0
ID=rancheros
ID_LIKE=
VERSION_ID=v1.4.0
PRETTY_NAME="RancherOS v1.4.0"
HOME_URL="http://rancher.com/rancher-os/"
SUPPORT_URL="https://forums.rancher.com/c/rancher-os"
BUG_REPORT_URL="https://github.com/rancher/os/issues"
BUILD_ID=
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
vsphere 6.7
single esxi host 6.5
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
single node rancher
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
rancher 2, so kubernetes
Steps to Reproduce:
Creating or editing a cluster to add vsphere cloud_providor.
My stanza added via clicking on "edit yaml":
cloud_provider:
name: "vsphere"
vsphereCloudProvider:
global:
insecure-flag: true
soap-roundtrip-count: 0
virtual_center:
<IP_ADDRESS>:
datacenters: "Cybertron"
password: "password"
soap-roundtrip-count: 0
user<EMAIL_ADDRESS>workspace:
datacenter: "Cybertron"
default-datastore: "P410_SSD_RAID5"
folder: "/"
server: "vcenter.transformers.lan"
(I never added the soup directives as they were auto added by the system)
Results:
Breaks auto creation of xip.io sub domains.  It doesn't break existing apps/workload, after adding the stanza and deploying a new app, no more auto creation.  It appears to still make the discoveries though.

DUplicate of https://github.com/rancher/rancher/issues/14960


cargo test incompatible with latest rustup

The 0.7 release of rustup changed how PATH is managed, and now cargo test where cargo is actually a rustup proxy will no longer work for this project itself.
I believe this has to do with something related to binaries eventually being compiled against the standard library dynamically and then the standard library dll can't be found at runtime. This'll need to be fixed with PATH munging somewhere although I'm not quite sure where.

cc @brson
Also I believe this was caused by https://github.com/rust-lang-nursery/rustup.rs/pull/812

I think this may be the same as rust-lang-nursery/rustup.rs/issues/765
The solution may be different on linux, but on windows I would expect the build tool (in this case cargo) to copy any required dynamic libraries into the output folder.
This would solve the problem for not just cargo test, but for all projects dynamically linking to other crates. It would also make it clearer to the end-user that they need to distribute these additional DLLs with their program.

@Diggsey But the output folder for cargo install is shared among all your toolchains, and your toolchains each have their own versions of the dlls.

@retep998 You also can't cargo install the same executable from different toolchains, do you have a reason to use anything other than a single "host" toolchain while cargo installing?

@Diggsey Imagine someone who cargo installs several different binaries, but over a period of time, and uses nightly. Each binary would depend on different nightly dlls.

Regardless of what rustup does, I don't think we can ever really support that without significant work to store DLLs in a namespaced subdirectory - or until rust gets a stable ABI

@alexcrichton Wouldn't this be a rustup bug? If I cargo install a program from source, the resulting binary can't run without the appropriate toolchain DLLs on my PATH (see https://github.com/Manishearth/rust-clippy/issues/1422). What tool's responsibility is this?
PS: Apologies in advance if that doesn't make any sense; I'm on quite the adventure here trying to set up a Hello World project in VS Code

@masaeedu As @alexcrichton said, for cargo test specifically, there are a number of places this could be fixed, because cargo test is not expected to work without a copy of the toolchain use to compile the test binaries.
However, for cargo install, or just generally when dynamically linking, there is nothing that rustup can do, since it plays no role in that process.

@retep998

Imagine someone who cargo installs several different binaries, but over a period of time, and uses nightly.

I think, it would be easier to update tools with the nightly together (or just use some time-frozen nightly version with bunch of tools) than to do nothing. Because currently all compiler-dependent tools are just broken.

I believe this was fixed in https://github.com/rust-lang/cargo/pull/3996. Closing!


Issue#30

this closes Issue #30 and Issue #26

Coverage decreased (-1.8%) to 88.226% when pulling 3b2e2cec897c46198c5b46dde9c4ba5ea36bf4d3 on issue#30 into 0ab3c1a403415c0c49c31a4f3f93c99a3ec043e2 on master.

Coverage decreased (-2.6%) to 87.443% when pulling 0b2812e149d0b78865abc93e8075c0fe774f937f on issue#30 into 0ab3c1a403415c0c49c31a4f3f93c99a3ec043e2 on master.


page.$x and page.waitForXpath doe not work

I am still getting

TypeError: page.waitForXPath is not a function

error even after upgrading with npm install https://github.com/GoogleChrome/puppeteer/
And also while using page.$x(xpathExpression) I get error

TypeError: page.$x is not a function

For the following code:
const [compareButton] = await page.$x('//img[@src="productA.jpg"]/following-sibling::div[text()="Compare"]');
I have already installed puppeteer-xpath, still it doesn't work.

@ShubhojitBhattacharjee  Most likely you're using old pptr version, you can figure this by checking your package.json or just going to node_modules/puppeteer/package.json and checking the installed package version.
Also note: if you have puppeteer installed in your package.json, then npm install https://github.com/GoogleChrome/puppeteer/ does not upgrade puppeteer.
Hope this helps.

@aslushnikov My bad, I did not refer to package.json.
I changed the version to 1.8.0 on package.json. It is working fine now. Thanks.


srml-contract: Use encode_to rather than encode to reduce allocations.

Minor memory optimization in the wasm runtime. Instead of allocating a new byte buffer from the heap on each write to scratch, reuse existing buffer.

Please fix merge conflict.


downgrade minimum required scipy version

qsymm 1.2.6 downgrades the required scipy version, so the feedstock
should also.

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin please re-render

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.


Wrong documentation of "latest_testflight_build_number" action

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
The documentation about the action `` contains a mistake for the return value type. It states that the return value is an Integer:
+--------------------------------------------------------------------------+
|               latest_testflight_build_number Return Value                |
+--------------------------------------------------------------------------+
| Integer representation of the latest build number uploaded to TestFlight |
+--------------------------------------------------------------------------+

While the return value is actually a String.
Environment
🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.12.6

Ruby
2.3.2

Bundler?
false

Git
git version 2.13.5 (Apple Git-94)

Installation Source
~/.rbenv/versions/2.3.2/bin/fastlane

Host
Mac OS X 10.12.6 (16G29)

Ruby Lib Dir
~/.rbenv/versions/2.3.2/lib

OpenSSL Version
OpenSSL 1.0.2j  26 Sep 2016

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
~/Downloads/Xcode-beta.app/Contents/Developer/

Xcode Version
9.0

System Locale

Error

No Locale with UTF8 found 🚫

fastlane gems

Gem
Version
Update-Status

fastlane
2.54.1
✅ Up-To-Date

Loaded fastlane plugins:

Plugin
Version
Update-Status

fastlane-plugin-badge
0.8.2
✅ Up-To-Date

Loaded gems

Gem
Version

did_you_mean
1.0.0

slack-notifier
1.5.1

CFPropertyList
2.3.5

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.3

xcodeproj
1.5.1

rouge
2.0.7

xcpretty
0.2.8

terminal-notifier
1.8.0

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.5.0

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.5

excon
0.58.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.0

gh_inspector
1.0.3

mini_magick
4.5.1

multi_json
1.12.1

multi_xml
0.6.0

rubyzip
1.2.1

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.1

bundler
1.13.6

faraday_middleware
0.12.2

json
2.1.0

io-console
0.4.5

plist
3.3.0

faraday
0.13.1

little-plugger
1.1.4

logging
2.2.2

jwt
1.5.6

memoist
0.16.0

os
0.9.6

signet
0.7.3

googleauth
0.5.3

uber
0.1.0

declarative
0.0.9

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.1

mime-types-data
3.2016.0521

mime-types
3.1

httpclient
2.8.3

google-api-client
0.13.1

unicode-display_width
1.3.0

terminal-table
1.8.0

curb
0.9.3

badge
0.8.4

fastlane-plugin-badge
0.8.2

generated on: 2017-08-25

@kevin-hirsch Thanks for the heads up on this!  Any chance you might be interested in submitting a patch to fix this? We are always looking for awesome changes submitted by our contributors, and this would be an impactful change to help folks use the latest_testflight_build_number action.
Thanks again!  🚀


Why not subscriptions?

Why not subscriptions?

This is what brought me here, I will like to see how Subscription is implemented


Reproductivity problem with cuda

Setting SEED does make the experiments reproducible under CPU execution, but not with CUDA.

The example fedavg_demo.py is reproducible (with CPU). cuda_demo.py is not (with cuda). PyTorch Reproducibility may helps.


MAISTRA-2459 Don't treat NotFound as an error when deleting a resource

@luksa ok to merge?

I don't know. This targets 2.0 and I have no idea whether we are free to merge things or not. :)

cc @knrc

@luksa @jwendell +1, it was to be resubmitted after the release was tagged and that was done.

@luksa should this also be done in 2.1? I think there are a few spots where we treat NotFound as error still there


Storage

Write a module that stores, downloaded file.

Create a function that accepts binary and the file extension as arguments, this function should save the files to a "download" folder.
create a file name based on the current timestamp, e.g "download-12345566677.jpg"


How to set User_Agent's value correctly?

I need to collect HTTP requests from different device platforms. How do I set User Agent value using AFNetworking3? and save cookies.

Questions like these are best suited for StackOverflow. It allows to remain focused on bug fixing and feature requests.
The user agent is simply an HTTP header, so you can override it to whatever value you want:
[requestSerializer setValue:@"My Agent" for HTTPHeaderField:@"User-Agent"]
Cookies are managed with NSHTTPCookieStorage.


Review of AWS RKE2 recipe

Division of the PR #145
To test It:
recipes/upstream/aws/rke2/terraform.tfvars
prefix           = "glovecchio"
aws_region       = "eu-west-1"
instance_count   = 2
ssh_username     = "ubuntu"
rancher_hostname = "glovecchio"
rancher_password = "Mypassword.1234"

@glovecchi0 Initially I ran into the below error:
╷ │ Error: chart requires kubeVersion: < 1.29.0-0 which is incompatible with Kubernetes v1.30.4+rke2r1 │  │   with module.rancher_install.helm_release.rancher, │   on ../../../../modules/rancher/main.tf line 118, in resource "helm_release" "rancher": │  118: resource "helm_release" "rancher" { │
Figured out that if we run the aws RKE2 recipe, RKE2 version will be the latest which will be v1.30.4+rke2r1 and then the rancher helm chart will fail to install as the rancher repo which we provided in the rancher module's main.tf is pointing to stable release where as the rancher version 2.9.1 which supports the RKE2 version 1.30.4 is not yet in the stable releases. So, I modified the helm_release.rancher.repository to "https://releases.rancher.com/server-charts/latest" and it worked.
Either we need to set the RKE2 version in the tfvars which supports the latest stable release or modify the rancher repository which support latest RKE2 release.
Code worked fine after that. Looks good.

@glovecchi0 Initially I ran into the below error: ╷ │ Error: chart requires kubeVersion: < 1.29.0-0 which is incompatible with Kubernetes v1.30.4+rke2r1 │ │ with module.rancher_install.helm_release.rancher, │ on ../../../../modules/rancher/main.tf line 118, in resource "helm_release" "rancher": │ 118: resource "helm_release" "rancher" { │
Figured out that if we run the aws RKE2 recipe, RKE2 version will be the latest which will be v1.30.4+rke2r1 and then the rancher helm chart will fail to install as the rancher repo which we provided in the rancher module's main.tf is pointing to stable release where as the rancher version 2.9.1 which supports the RKE2 version 1.30.4 is not yet in the stable releases. So, I modified the helm_release.rancher.repository to "https://releases.rancher.com/server-charts/latest" and it worked.
Either we need to set the RKE2 version in the tfvars which supports the latest stable release or modify the rancher repository which support latest RKE2 release.
Code worked fine after that. Looks good.

Good point! Thanks a lot, Surya!


Updating extend section based on feedback by @chriseppstein

Updated paragraph to clarify avoiding extension of selectors instead of just classes
Added paragraph for inherited styles (thanks @chriseppstein for the example)
Changed wording: "Use extend on %placeholders primarily" (instead of exclusively)
Added bullet point on extending classes
Added extra reading article that has more updated and comprehensive information on the mechanics and usage of the @extend directive

Do you care to review @chriseppstein?

Thank you @davidkpiano. :)


Reusable State Machines

Recently, I've been using a modified version of react-automata at work. The changes address a problem I've had with trying to connect multiple components to a single statechart.
Using the React 16.3+ Context API you can set a root Provider, and connect multiple components using a generated withStatechart for that specific config.
import createStatechart from './lib/someLib'

const { Provider, withStatechart } = createStatechart(machineConfig)

const A = withStatechart(AComponent)
const B = withStatechart(AComponent)

const someComponent = () => (
  <Provider>
    <A />
    <B />
  </Provider>
)

A pattern like this may be worth exploring in later releases of "react-automata". Unfortunately, it would currently result in some major breaking changes.

Thank you very much for opening this issue, @ShMcK.
This is an interesting problem, and I don't mind to release a breaking change as long as it adds value for the users of the library.
However, I would like to understand more what are the needs behind this change.
Can you please provide a real-world use-case?

Context APIs
There's a saying "when you get a new hammer, everything looks like a nail." I think it summarizes my issue with trying to use the new Provider/Consumer Context API with "react-automata".
The old context API can allow more flexibility, and may be worth keeping. It gives you access to the state machine through this.context, whereas the new context API expects you to explicitly pass down your props. Moving to the new Context API would break <State /> & <Action />, or they would have to shift to explicitly receiving the statechart value.

Reusing State Machines
The problem I have is that I would like to reuse a state machine and connect components in different parts of the component tree.
I'm working on a complex interface, somewhat similar to photoshop, where toolbars by necessity are located apart.
I realize now there is a much easier fix for this that grants the same flexibility.
Current
const a = withStatechart(statechart)(A)
const b = withStatechart(statechart)(B)

In the above example, a & b are not using the same state machine. They will not be in sync. "react-automata" internally generates the Machine, making each a different instance.
Proposed
An easier fix to allow more flexibility would be to move the creation of statecharts outside of "react-automata":
import { Machine } from 'xstate'

const statechart = Machine({ /* ... */ })

const a = withStatechart(statechart)(A)
const b = withStatechart(statechart)(B)

This might be worth considering.

Thank you very much @ShMcK for providing more information.
It's already possible to create a machine and pass it to the higher-order component.
However, I'm not 100% sure if you only want to reuse a machine or you also want the components' states to be in sync. I'm asking this because given that xstate is stateless, creating the machine outside doesn't help with the "sync" part.

I've written a somewhat incomplete and unpublished article on the topic, feel free to have a look and drop any feedback. I hope it helps. https://medium.com/@ShMcK/communicating-between-state-machines-components-33e6ab754605

@alexandrethsilva, thank you very much for your comment.
@ShMcK, thank you very much for writing an article about this.
I think there's a little bit of confusion around the relation between the new context API, sharing the machine state between multiple components, and the concept of external state machines.
In fact, it's already possible to build a Provider-like structure with react-automata, although the library uses the legacy context APIs (which is, and should be, an implementation detail).
For example, here is an app that looks like the example from the article, where multiple AlarmClock components are "in sync":
import { Action, withStatechart } from 'react-automata'

const statechart = { // ... }

const AlarmClock = () => (
  <>
    <Action show="startRing">
      <Ringing />
    </Action>
    <Clock />
  </>
)

const Component = ({ children }) => children

const AlarmMachine = {
  Provider: withStatechart(statechart)(Component),
}

const App = () => (
  <AlarmMachine.Provider>
    <>
      <AlarmClock />
      <AlarmClock />
    </>
  </AlarmMachine.Provider>
)

However, I don't see any difference with the following code, which is what I recommend, and provides the same behaviour:
import { Action, withStatechart } from 'react-automata'

const statechart = { // ... }

const AlarmClock = () => (
  <>
    <Action show="startRing">
      <Ringing />
    </Action>
    <Clock />
  </>
)

const Component = () => (
  <>
    <AlarmClock />
    <AlarmClock />
  </>
)

const App = withStatechart(statechart)(Component)

The main differences between react-automata and xstateful-react are two:

react-automata uses the components methods to respond to actions, while xstateful-react offers a reducer-pattern.

xstateful-react's Provider passes the machine state, extstate, and transition to the <Machine.* /> components. react-automata doesn't, but the same behaviour can be reproduced in userland, if needed.

Here's a variation of the previous example, that uses the new context API:
import { withStatechart } from 'react-automata'

const AutomataContext = React.createContext('automata')

const AlarmClock = () => (
  <AutomataContext.Consumer>
    {({ machineState, transition }) => // ...
  </AutomataContext.Consumer>
)

const Component = props => (
  <AutomataContext.Provider value={props}>
    <>
      <AlarmClock />
      <AlarmClock />
    </>
  </AutomataContext.Provider>
)

const App = withStatechart(statechart)(Component)

If number 2 is what generates this sort of confusion and that's what you mean by "External State Machines", I'm happy to implement it at the library-level.
A couple of notes on the article, @ShMcK:

In the first code snippet (the statechart), the second state should be Snoozing (as opposed to Snooze).
When you say "Note that though these methods are not called with params" (referring to react-automata action methods), that's correct. However, the reason they don't receive parameters is that they can access those information through the props.

I hope this helps/makes sense, and I'm happy to discuss further.

I have a question to your last comment regarding the example with react's new context API:
The AlarmClock components receive the props (machineStatet, ransition) via the AutomataContext.Provider.
But what about the lifecycle methods? Those are only added to the AutomataContext.Provider and not to the nested AlarmClock components, or?
And what about the onEntry actions defined in the state chart? Those should be called on the AlarmClock components, but I think with this example they also would be called on the AutomataContext.Provider.

Thank you very much for your comment, @rumtraubenuss. I'm more than happy to answer your questions.
It's correct when you say that lifecycle hooks and the action methods are fired only in the component wrapped into withStatechart (the Provider in this case).
You should consider that componentWillTransition is fired right before componentWillReceiveProps (now deprecated) and componentDidTransition is basically componentDidUpdate so their behaviour can be easily replicated in the tree.
In fact, given that the returned component is a regular React component (with a few special props and behaviours), nothing stops you from using common techniques (e.g. passing down props) to trigger "reactions" in children.
I'm under the impression that the fact this library is just a thin "bridge" between xstate and React is a source of confusion.
Also, a possible "workaround" would be to use State and Action callbacks (not recommended), for example:
<State value="whatever" onShow={this.onEntry} onHide={this.onExit} />

<Action show="whatever" onShow={this.onAction} />

I hope this help, and it would be great if you could share your use-cases so that we can discuss further.

@MicheleBertoli thanks a lot for your extensive feedback on these last questions we posted. I didn't have time last week to get back to you, but appreciated very much your reply.
My question after it would be exactly what @rumtraubenuss raised and I agree with you that may have been what confused me at first, as when seeing the description of the additional lifecycle hooks I thought it was intended to be the standard/recommended way of interacting with the automata.
When thinking about it now, after going a few times through this thread to wrap my head around it, I wonder if these hooks are a meaningful part of the library of if their absence could actually contribute to clarifying the idea of this library having only the role of the "thin bridge" you mentioned?
Maybe without them I would have felt less compelled to use the HOC in every component which interacted with the automata, which in turn led me to think that simply having it available on the context level would be incorrect or a not recommended use of it.
I hope I didn't get too lost when making my point? Does it make some sense? And, ultimately, what would be your thoughts on removing the hooks and adding some of the examples you mentioned in this thread to the docs? I'd be glad to contribute with a PR if you think that'd make sense.

Thank you very much @alexandrethsilva for providing more context.
I'm glad the discussion was useful, and thanks for confirming that the lifecycle hooks are a source of confusion.
The cause might also be the Provider/connect approach enforced by react-redux.
I'm currently in the process of rewriting some parts of the library (better APIs, improved performance, support actions/activities) and the README. I will follow your suggestion, and I'll add a FAQ section with the examples from this thread and more.
I don't think we should remove features, as they are useful (e.g. logging in componentDidTransition), but we need to provide clearer information.
I'll ping you when the new stuff is ready, and please feel free to contribute to it.

Here's the new FAQ section, @alexandrethsilva.
I hope it's useful, and please feel free to contribute to it.

Here's the new FAQ section, @alexandrethsilva.
I hope it's useful, and please feel free to contribute to it.

Hi @MicheleBertoli, sorry for the delay in replying. 😬
Thanks a lot for the continuous feedback on this. I think the confusion may indeed have been influenced by the way react-redux does things with connect. And I also see your point when you talk about not removing features which may be useful.
Really nice to read that you're bringing more updated to the lib. I've been enjoying using it quite a lot.
And last but not least, thanks for the new FAQ! Whenever something pops that I think may be useful I'll open an issue here to discuss and a subsequent PR if it makes sense 👍


First batch of items not animated in collection views

When data is bound to a collection view via the animated data source, the items of the very first event appear without any animation – which seems to be deliberate, but otherwise pretty counterintuitive.
I made a demo project where this issue is apparent, and my current workaround – which can cause inconsistency crashes, but that's a story for another day.

I think this is the reason:
https://github.com/RxSwiftCommunity/RxDataSources/blob/ddfc9a1fdba650984f3a72b5b318e55fcfeccbae/Sources/RxDataSources/RxCollectionViewSectionedAnimatedDataSource.swift#L63-L65

Please bear in mind backwards compatibility.

The startWith workaround has been working for me from iOS 9 (which is the deployment target of the app I had to figure it out on), I never tested it on iOS 8 though. It's just too far into the past.
Maybe the dataSet logic could be wrapped with an #if available block so it's not applied on current versions?

Hi @vzsg ,
if you want first animated update, you would just bind to an empty result first with startWith. It makes sense that first one is non animated since it doesn't have any state to animate from.

Yeah, that's what I figured by myself too (and visible in the demo project above).
A note in the readme would be nice, but I guess we can consider this issue closed.

I originally started writing this issue as a precursor for a bigger deal: using startWith in a combination of schedulers did lead to a large number of crashes in one of my projects. But I can't reproduce it without making a mistake purposefully, so all's well.


Way to download all to google drive

Hi, is there a way to download all ebooks to my google drive?

Not at the moment. Shouldn't be very hard to implement though.


Get 5.0.0-beta.50 throws StackOverflowError

After upgrading from beta.36 to beta.50 I'm unable to launch my app:
════════ Exception caught by widgets library ═══════════════════════════════════
The following StackOverflowError was thrown building Builder(dirty, dependencies: [Binder<GetMaterialController>]):
Stack Overflow

The relevant error-causing widget was
GetMaterialApp
lib/main.dart:56
When the exception was thrown, this was the stack
#0      _OperatorEqualsAndHashCode._hashCode (dart:collection-patch[/compact_hash.dart:191:3]())
#1      _LinkedHashMapMixin._getValueOrData (dart:collection-patch[/compact_hash.dart:497:26]())
#2      _LinkedHashMapMixin.containsKey (dart:collection-patch[/compact_hash.dart:517:54]())
#3      Inst.isRegistered
package:get/…/src/extension_instance.dart:476
#4      Inst.find
package:get/…/src/extension_instance.dart:274
#5      GetMaterialController.to
package:get/…/root/root_controller.dart:74
#6      GetNavigationExt._getxController
package:get/…/src/extension_navigation.dart:1271
#7      GetNavigationExt.routing
package:get/…/src/extension_navigation.dart:1247
#8      GetMaterialController.onInit
package:get/…/root/root_controller.dart:108
#9      GetLifeCycleMixin.onStart
package:get/…/src/lifecycle.dart:50
#10     Inst._startController
package:get/…/src/extension_instance.dart:244
#11     Inst._initDependencies
package:get/…/src/extension_instance.dart:194
#12     Inst.find
package:get/…/src/extension_instance.dart:287
#13     GetMaterialController.to
package:get/…/root/root_controller.dart:74
#14     GetNavigationExt._getxController
package:get/…/src/extension_navigation.dart:1271
#15     GetNavigationExt.routing
package:get/…/src/extension_navigation.dart:1247
#16     GetMaterialController.onInit
package:get/…/root/root_controller.dart:108
#17     GetLifeCycleMixin.onStart
package:get/…/src/lifecycle.dart:50
#18     Inst._startController
package:get/…/src/extension_instance.dart:244
#19     Inst._initDependencies
package:get/…/src/extension_instance.dart:194
#20     Inst.find
package:get/…/src/extension_instance.dart:287
#21     GetMaterialController.to
package:get/…/root/root_controller.dart:74
#22     GetNavigationExt._getxController
package:get/…/src/extension_navigation.dart:1271
#23     GetNavigationExt.routing
package:get/…/src/extension_navigation.dart:1247
#24     GetMaterialController.onInit
package:get/…/root/root_controller.dart:108
#25     GetLifeCycleMixin.onStart
package:get/…/src/lifecycle.dart:50
#26     Inst._startController
package:get/…/src/extension_instance.dart:244
#27     Inst._initDependencies
package:get/…/src/extension_instance.dart:194
#28     Inst.find
package:get/…/src/extension_instance.dart:287
#29     GetMaterialController.to
package:get/…/root/root_controller.dart:74
#30     GetNavigationExt._getxController
package:get/…/src/extension_navigation.dart:1271
#31     GetNavigationExt.routing
package:get/…/src/extension_navigation.dart:1247
#32     GetMaterialController.onInit
package:get/…/root/root_controller.dart:108
#33     GetLifeCycleMixin.onStart
package:get/…/src/lifecycle.dart:50
#34     Inst._startController
package:get/…/src/extension_instance.dart:244
#35     Inst._initDependencies
package:get/…/src/extension_instance.dart:194
#36     Inst.find
package:get/…/src/extension_instance.dart:287
#37     GetMaterialController.to
package:get/…/root/root_controller.dart:74
#38     GetNavigationExt._getxController
package:get/…/src/extension_navigation.dart:1271
#39     GetNavigationExt.routing
package:get/…/src/extension_navigation.dart:1247
#40     GetMaterialController.onInit
package:get/…/root/root_controller.dart:108
#41     GetLifeCycleMixin.onStart
package:get/…/src/lifecycle.dart:50
#42     Inst._startController
package:get/…/src/extension_instance.dart:244
#43     Inst._initDependencies
package:get/…/src/extension_instance.dart:194
2 ...
#4002   ComponentElement._firstBuild
package:flutter/…/widgets/framework.dart:4735
#4003   ComponentElement.mount
package:flutter/…/widgets/framework.dart:4729
...     Normal element mounting (19 frames)
#4022   Element.inflateWidget
package:flutter/…/widgets/framework.dart:3790
#4023   Element.updateChild
package:flutter/…/widgets/framework.dart:3540
#4024   RenderObjectToWidgetElement._rebuild
package:flutter/…/widgets/binding.dart:1198
#4025   RenderObjectToWidgetElement.mount
package:flutter/…/widgets/binding.dart:1167
#4026   RenderObjectToWidgetAdapter.attachToRenderTree.<anonymous closure>
package:flutter/…/widgets/binding.dart:1112
#4027   BuildOwner.buildScope
package:flutter/…/widgets/framework.dart:2600
#4028   RenderObjectToWidgetAdapter.attachToRenderTree
package:flutter/…/widgets/binding.dart:1111
#4029   WidgetsBinding.attachRootWidget
package:flutter/…/widgets/binding.dart:944
#4030   WidgetsBinding.scheduleAttachRootWidget.<anonymous closure>
package:flutter/…/widgets/binding.dart:924
(elided 11 frames from class _RawReceivePortImpl, class _Timer, dart:async, and dart:async-patch)
════════════════════════════════════════════════════════════════════════════════

My app:
class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return GetMaterialApp.router(
      theme: buildAppTheme(context),
      binds: [
        Bind.put(UserService()),
        Bind.put(AuthService()),
      ],
      getPages: AppPages.routes,
    );
  }
}

beta.36 works just fine.

Works fine if I change GetMaterialApp.router to GetMaterialApp.


hide or show "seen" flags

there should be configurable options to allow users to enable or disable "seen" flags on messages they receive.

fixed here


I am usage chrome access

Issue type
Support
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf 3.8
Custom code
Yes
OS platform and distribution
15.03
Mobile device
15.03
Python version
9.9
Bazel version
https://github.com/github/docs.git
GCC/compiler version
I am usage accessories
CUDA/cuDNN version
I am usage chrome access
GPU model and memory
Welcome
Current behavior?
Behavior is very nice alhamdulillah
Not a complain I understand
Standalone code to reproduce the issue
Sir hum accessories use krte Hain ko Nikki hoti Hain bilkul bhi kisi ko dara dene ya black mail k liye use nh hota

Relevant log output
Sir hum accessories use krte Hain ko Nikki hoti Hain bilkul bhi kisi ko dara dene ya black mail k liye use nh hota

@muzammilamreen,
Could you please provide the steps you have followed and also take a look at the official document for the installation of the Tensorflow in the smoother way.
https://www.tensorflow.org/install/pip#step-by-step_instructions
Thank you!

Please don't spam


Cant seem to login with the authenticator

Version
1.13.3
Platform
windows 10
Steps to reproduce
not being logged in
trying to authenticate
Details
tried logging in and the authentication screen just goes black

Checklist

[X] I have looked through existing issues to make sure that this bug has not been reported before
[X] I have provided a descriptive title for this issue
[X] I have made sure that this bug is reproducible on the latest version of the application
[X] I have provided all the information needed to reproduce this bug as efficiently as possible
[ ] I have sponsored this project
[ ] I have not read any of the above and just checked all the boxes to submit the issue

Try installing WebView2 runtime: https://developer.microsoft.com/microsoft-edge/webview2
It should normally be part of your Windows distribution.