I wish /docs/user-guide/connecting-to-applications-proxy/ would be updated with the new dashboard information

I wish /docs/user-guide/connecting-to-applications-proxy/ would be updated with the new dashboard information, if applicable.

i think this is covered here: http://kubernetes.io/docs/user-guide/ui/


Chapter and Verse Navigation

Add support to enable or disable chapter selection menu visibility after user selects a book
Add support to enable or disable verse selection menu visibility after user selects a chapter
Add support to enable or disable chapter selection menu when user interacts with chapter number on the app bar
Add support to enable or disable chapter number visibility on the app bar

Ready for review here.

David's restructure #69 will change quite a bit.  You will need to rebase your changes based on that.


Updated Filter section

Added an additional example and split the filters between those that accept only two parameters and those that accept more than two.

Omission of the parameters is what caused the confusion with the customer in the first place. I will update accordingly, but I feel like they should be at least visible since separating them into simple vs array type of filter is not a viable solution. Unless you feel like the KC docs filtering section is more clean. Filtering

Okay, thanks!


KAFKA-16524 : Adding a metric for kip 853

Resolves https://issues.apache.org/jira/browse/KAFKA-16524

Adding metric number-of-offline-voters

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@muralibasani and I discussed this issue offline. I will be submitting a PR for implementing the metrics.


'device_id` does not specify a Swift version

device_id does not specify a Swift version and none of the targets
(Runner) integrating it have the SWIFT_VERSION attribute set. Please
contact the author or set the SWIFT_VERSION attribute in at least one of
the targets that integrate this pod.

still getting same error

@amrud Add the following line to the top of your podfile
ENV['SWIFT_VERSION'] = '4.2'


Standardize calcuate_degassing_paths() methods

Simon, based on your email it sounds like the best way forward is for you to reformat your degassing paths methods to be more like MagmaSat. I'll assign this issue to you for now, but please let me know if I can tweak things, too.

Will change 'system' argument to 'fractionate_vapor' allowing values of 0 to 1 at first, then adjusting code to allow any value, where 0.5 keeps half of the vapor and removes the other half. will add pressure argument, where default is just to start at saturation. If a value is passed, will start from that value instead.

@simonwmatthews Question! Does 'fractionate_vapor' refer to how much vapor is retained at each pressure step or how much vapor is removed at each pressure step? I'm currently coding MagmaSat such that the default value is fractionate_vapor=1.0, which is a closed system where all vapor is retained from one step to the next.

Done! Just need to make sure I am using the 'fractionate_vapor' variable correctly (re: my previous comment), but the MagmaSat function now works! I've added some test examples to the manuscript as well. Will push those changes now.

@simonwmatthews Question! Does 'fractionate_vapor' refer to how much vapor is retained at each pressure step or how much vapor is removed at each pressure step? I'm currently coding MagmaSat such that the default value is fractionate_vapor=1.0, which is a closed system where all vapor is retained from one step to the next.

The variable is how much vapour is removed, i.e. 1.0 = open system, 0.0 = closed system. I tried to make it analogous to the fractionation coefficients in MELTS (e.g. https://enki-portal.gitlab.io/ThermoEngine/MELTS-v1.0.2-fractionation.html).

Implemented! @simonwmatthews I have changed the default for both of our models to be 0.0 (closed-system). Is that okay with you? It makes the most sense to me, but if you have a reason for having it the other way, I am open to that!


Can the scanpy heuristic for finding slides be also used in squidpy?

Description
When following the squidpy tutorials plotting of tissue slides is using the scanpy package leading to figures that are cropped to the areas actually containing cells.
If I use the squidpy plotting functions instead I see the total area, with the cells only occupying a small area. Now I would need to identify the area of interest myself. But this is inherently complicated without even having a possibility to show the coordinates in these plots.
So as scanpy already is able to identify the areas of interest, could squipdy please also use this functionality?
I would not mind to just find the automatically estimated cropping area coordinates in either the scanpy object or the squidpy object and having an option to using them in the plot or other functions.
The problem occurred for me when needing these coordinates for the deconvoluting the spots into single cell expression profiles.
I hope this is possible without too much actual coding.

The whole discussion has started here: https://github.com/scverse/squidpy/issues/606#issuecomment-1272898907


⚠ Senior School Website has degraded performance

In 8b2cd8c, Senior School Website (https://www.cranleigh.org) experienced degraded performance:

HTTP code: 200
Response time: 16704 ms

Resolved: Senior School Website performance has improved in c917c7a.


(OraklNode) Deviation reports disrupting regular report

when deviation report increases, somehow regular report becomes delayed
should be investigated

might not be relevant anymore once separate reporter is implemented


fixed link to playgrounds in dnd README.md;

@RobertSeidler Thank you!

@RobertSeidler Thank you!


Node Runtime not supported anymore

:bug: Bug Report
What is the problem?
Node runtime_8_10 is not supported by Lambda anymore. Please update the same in the workshop.
Reproduction Steps
Verbose Log
const hello = new lambda.Function(this, 'HelloHandler', {
  runtime: lambda.Runtime.NODEJS_8_10,      // execution environment
  code: lambda.Code.asset('lambda'),  // code loaded from the "lambda" directory
  handler: 'hello.handler'

https://cdkworkshop.com/20-typescript/30-hello-cdk/200-lambda.html
-->
Environment

CDK CLI Version: 1.20.0
Section:  Hello Lambda
Browser: all
Language: Typescript

Other information

Resolved by #118


Adding Bamboo support

Hey,
Would be keen to see Bamboo support, the variables are listed here: https://confluence.atlassian.com/bamboo/bamboo-variables-289277087.html

See: https://github.com/sindresorhus/is-in-ci?tab=readme-ov-file#how-can-i-add-a-ci-service

Request the CI service to include the CI environment variable. Most already do.

Feature request is already open, but little movement on their front. Apologies, it seems reasonable because all of their variables start with bamboo avoiding the likelihood of conflict.


sandbox: Speed up command execution by re-using docker exec shell.

Currently ovn-heater calls 'docker exec' via SSH connection to a
physical host every time it needs to execute any command inside
a container.  Just 'docker exec' itself adds anywhere from 150 to
500 ms of extra overhead to every call.
To avoid that overhead, creating a separate channel for each
container within a common SSH connection.  Using an interactive
shell emulator from the invoke_shell() method, invoking a docker
interactive shell.  Once this is done, we have a direct channel
to execute any commands inside of a container with only few
milliseconds of overhead (4-5 ms in practice).
Since it's not just a command execution API like paramiko's
exec_command(), but a real shell emulator, it's a bit trickier
to work with.  Shell sends back command prompts and everything
you send to it.  It also sends back lots of vt100 control/escape
symbols.  Command output is filtered out by adding special
start/end markers, the exit code is printed with echo and
parsed out as well.
There are no functional changes to tests, they are doing exactly
the same to what they were doing before, but with the command
execution being much faster.
One consequence of commands being executed faster is added sleep
to the election timer modifications that should wait for cluster
to agree on a new value before it can be changed again.
This change greatly improves the test speed.  For example, 250
node density heavy test can be finished in 1 hour and 20 minutes
instead of 9 hours before.
Signed-off-by: Ilya Maximets<EMAIL_ADDRESS>

Looks good to me, thanks!


Create CODE_OF_CONDUCT.md

This PR adds a code of conduct that we can use across our projects.
It's a fork to make sure we can enforce the Code of Conduct properly.
If this is contentious we could scope this individually to each project.
Thoughts welcome.
Alternatively I'm trying to track down who owns the current email address, we may be able to use that instead.

Had a chat with @timblair and @36degrees is a member of the original mailing list, I'm going to simplify this to just pointing at the master CoC :)


Failed to build if model classes place in packages, started with capital letter

For example:
not work:
com.myapp.Model.Queen

Build error: "error: cannot find symbol class Model"
work:
com.myapp.model.Queen

I dont believe such a thing is looked upon in Java as standard and should always be lower to not conflict with inner class definitions...

What standart? Can you give reference? Why if it's "standart" i still CAN create?


PackChk problem with "doc" attribute in the  element

I have encountered an issue with PackChk where is does not check the documentation path of an example correctly. Consider the following  in a PDSC file:
<example name="MyExample" folder="Boards/v1/MyExample" doc="../../../Documentation/html/myexamples.html" version="1.0">
  <description>This is an example</description>
  <board vendor="Anyone" name="MyEVK" Dvendor="ARM:82"/>
  <project>
    <environment name="uv"  folder="./" load="MyExample.uvprojx"/>
  </project>
  <attributes>
    <component Cclass="CMSIS" Cgroup="Core"/>
    <component Cclass="Device" Cgroup="Startup"/>
  </attributes>
</example>

According to the PACK.xsd, the "doc" attribute is relative to the "folder" attribute. And it is not forbidden to specify folders in a couple of levels above (../../../). But PackChk throws an error on this, like:
*** ERROR M310: C:\03_work\Packs\Anyone\build\Anyone.MyPack.pdsc (Line 465)
  Filename mismatch (case sensitive):
  PDSC name : 'Boards\v1\MyExample\..\..\..\Documentation\html\myexamples.html'
  Filename  : 'Boards\v1\MyExample\v1\Boards\build\Documentation\html\myexamples.html'

PackChk needs to traverse the folder structure correctly to identify the correctness of the PDSC file.

According to the PACK.xsd, the "doc" attribute is relative to the "folder" attribute.

Hi @KeilChris
About this PACK.xsd file, do you use this one:
https://github.com/ARM-software/CMSIS_5/blob/develop/CMSIS/Utilities/PACK.xsd
Maybe we should add explicitly this file inside Open-CMSIS-Pack repo ?

Hello @jeromecoutant,
trouble is that there is a PACK.xsd in Open-CMSIS-Pack repo as well. I think we need to conclude on having only one. What do you think. @JonatanAntoni ?

Oh, I see your PR in the other repo :-)

trouble is that there is a PACK.xsd in Open-CMSIS-Pack repo as well

I didn't see this one in the Spec repo:
https://github.com/Open-CMSIS-Pack/Open-CMSIS-Pack-Spec/blob/main/schema/PACK.xsd
Thx

Gents, the one in the Open-CMSIS-Pack-Spec is the master one. The one in CMSIS_5 repo is still kept for backward compatibility and should be removed somewhen in the future. Unfortunately, some tools fetch the PACK.xsd directly from CMSIS_5 GitHub repo and remove the schema file would break these tools.

Gents, the one in the Open-CMSIS-Pack-Spec is the master one. The one in CMSIS_5 repo is still kept for backward compatibility and should be removed somewhen in the future. Unfortunately, some tools fetch the PACK.xsd directly from CMSIS_5 GitHub repo and remove the schema file would break these tools.

Back on the initial issue, if we want PackChk tool to apply the correct schema, it needs to be available in devtools, not in Spec ?

@jeromecoutant just to set expectations here, PackChk itself does NOT run a schema check itself.
How about the idea to include PackChk as well as the matching PACK.xsd (= most recent PACK.xsd schema file at the point of PackChk release) into the CMSIS-Toolbox?

How about the idea to include PackChk as well as the matching PACK.xsd

I think it is a good idea
@fred-r

With doc="../../../Documentation/html/myexamples.html" it is possible to escape the directory structure of a pack. Why should this be allowed?

Because this is the way how some examples work. Especially SiPs create one example that has a shared documentation, but the actual example is deeper in the folder hierarchy. So we need ../ to traverse the the hierarchy up until the right point. This happens more often that you would guess. Regarding escaping the structure of the pack: PackChk could be used to check that and throw an error in that case. We might need additional means for packunzip to abort the installation if it encounters such a situation. What do you think?

Shouldn't a pack be self contained except conditions? Not sure if a "Documentation pack" (and e.g. a "Driver Pack", ...) used by several packs is useful.

I'm not sure if I understand your comment. This has nothing to do with the pack purpose. We just cannot assume that the documentation for anything in the pack is below a certain folder. It can also be "above".

My question is: Do we want to allow to go outside the pack? (see Reinhards comment)

In other words, please check that the reference is within the scope of a pack. The pdsc file defines the base directory of a pack. The referenced document must be in this base directory or any arbitrary level of sub-directories.

PackChk: issue on relative paths during case-sense check
excluding files from case sense check that have relative path elements "./" or "../"
added test if files are above pack root directory

@KeilChris can you please verify it?

Retested with packchk version 1.3.98 and the issue is gone. Closing.


Do we force hue to be undefined when white or black (think lightness 0% or 100%)?

This is now stated in the CSS spec, but is also still a little ambiguous.  Does this apply to just colors like HSL and HSV that have no meaningful color values outside of that range? What about Lab? Will this mess with round-tripping? Should we be concerned when and were we apply this?
Related #79

Personally, I'm not sure I like this. Yeah, not every color space round trips perfectly clean, but if we do this automatically, like CSS suggests, bye, bye translating an ICtCp color with a white above 100% back and forth.  The roundtrip will be 100% broken. I think, for now, we will stick with applying hue as undefined only when chroma is zero. I'm not anxious to break this right now. Users could always check lightness themselves and force hue to NaN if they really care.

Okay, this is quite a bit more clear now.  We've changed coloraide to respect manually defined hues, even if they are "powerless". I've read over the spec and generally what it is actually saying is that when in these scenarios, such as lightness 0% or lightness 100%, the hue is powerless. This is true without us doing anything. On conversion, we already do this as well.
The real question is whether we should take a brand new color, with user-defined hue, and normalize it to be undefined in these cases, and the answer is that we shouldn't have been doing this even for saturation. So the reality is that we are already doing what needed to be done. As a matter of fact, we were doing too much, and now we've backed off this, I think we are doing everything we should.
This can be closed as nothing to do.
@gir-bot remove S: needs-decision
@gir-bot add S: wont-fix


new warning on hdf5filter.c

hdf5filter.c: In function ‘NC4_filter_actions’:
hdf5filter.c:209:9: warning: variable ‘havedeflate’ set but not used [-Wunused-but-set-variable]
  209 |     int havedeflate, haveszip;
      |         ^~~~~~~~~~~

havedeflate and haveszip need to be #ifdef'd.
I will fix.

I have a PR ready to go. Standby...


#Include directives

Allow for a #include "filename.py" or #include "filename.plp" directive that is equivalent to the Python snippet #python #end, but can be used to split a dpasp program into several files. The type of snipper can be deduced from the file extension. That should also help to make things more efficient, as e.g., we might pre-compile python files or pre-ground plp files.

[X] Add support for #include "filename.plp" (see 1352f74df76aa3f40944c237ca8dafadc4268e00)
[ ] Add support for #include "filename.py"


Add clearMessages method to chat reference

@JamyDev, thanks for your PR! By analyzing the blame information on this pull request, we identified @ProbablePrime and @connor4312 to be potential reviewers

lgtm after the presumably-incoming PR for the chat server itself 😛

 Add clear method to chat server

Let's merge this and factor permissions in later.


Deploy this website to github pages.

This static website should have to be deployed on GH Pages. It can be done by either admin or maintainer.

Its deployed here

Add that link in description.


Delay import of scipy stats and optimize

This speeds up top level import.
Note that we had previously done this for another use of scipy.stats, but this one got added.  Also doing it for scipy.optimize.  Both of these can slow down the resulting experiments, probably a case for moving experiments out of cirq-core?

python -c 'import time; time.sleep(1); t1 = time.monotonic(); import cirq; t2 = time.monotonic(); print(t2-t1)'

Before the PR gives 1.7412576620699838 and after gives 1.355757946963422

Current slowness besides these scipy modules are
sympy: 0.386s
numpy: 0.169s
pands: 0.204s
matplotlib.pyplot 0.334s
networkx: 0.079s

This looks good. Did you have the time to checkout something like this: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/util/lazy_loader.py#L23
Which would give us the added bonus of being able to start rounding up all the random imports we have littered everywhere to avoid circular imports (putting them back at the top with this) ?

rounding

Untested TensorFlow code!  My eyes they burn! The googles they do nothing!   Do you see the benefit of the TensorFlow class?  I guess if you use the class in a lot of places?

Do you see the benefit of the TensorFlow class?

Well you don't have to worry about where in the module you'd need to put your imports if you used this class. The actual load would take place when the call is made. So in this case of scipy instead of having to put multiple imports in weid places just do at the top:
# can do circular imports at the top with this too.
scipy_linalg = LazyLoader("scipy.whatever", globals())

def my_function(...):
   stuff.

def my_scipy_function(...):
  return scipy_linalg.whatever # this triggers actual import.

Created #4648 to consider adding LazyLoader.


rg takes up all memory (>10GB)

Environment data

VS Code Version:
Version: 1.44.0
Commit: 2aae1f26c72891c399f860409176fe435a154b13
Date: 2020-04-08T08:23:56.137Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 17.7.0
Extension version (available under the Extensions sidebar): 2020.3.71659
OS and version: Desktop is MacOSX 10.13, SSH server is Linux (Ubuntu 16).
Python version (& distribution if applicable, e.g. Anaconda): CPython 3.6.3
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): None
Relevant/affected Python packages and their versions: None
Relevant/affected Python-related VS Code extensions and their versions: ms-python.python
Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info #3977): Jedi is enabled.
Value of the python.languageServer setting: Microsoft

Via.
Expected behaviour
It should run without crashing the system due to running out-of-memory (OOM).
Actual behaviour
The rg process takes a lot of memory (>10GB). In the extreme case, it crashes the whole system.
Steps to reproduce:
(Start VSCode with SSH extension. This is probably not relevant. This is just needed in my case because the project directory is on the Linux server.)
Open a very big project directory (containing several 100GB, many thousand files, slow to access via NFS).
See ps axu on the Linux SSH server, and search for the rg process by VSCode:
USER       PID %CPU %MEM    VSZ   RSS TTY      STAT START   TIME COMMAND
zeyer    14685  117 53.7 8244360 8231756 ?     Sl   11:12  13:09 /u/zeyer/.vscode-server/bin/0ba0ca52957102ca3527cf479571617f0de6ed50/node_modules/vscode-ripgrep/bin/rg --files --hidden --case-sensitive -g **/*.ipynb -g !**/.git -g !**/.svn -g !**/.hg -g !**/CVS -g !**/.DS_Store -g !**/__pycache__ -g !**/*.pyc --no-ignore --follow --no-config --no-ignore-global
zeyer    20113 87.3 12.8 1978088 1965448 ?     Sl   11:30   4:42 /u/zeyer/.vscode-server/bin/2aae1f26c72891c399f860409176fe435a154b13/node_modules/vscode-ripgrep/bin/rg --files --hidden --case-sensitive -g **/*.ipynb -g !**/.git -g !**/.svn -g !**/.hg -g !**/CVS -g !**/.DS_Store -g !**/__pycache__ -g !**/*.pyc --no-ignore --follow --no-config --no-ignore-global

The cwd of that process is a VSCode setup, which is the very big project directory. Many of the files are behind some symlinks, but I partly want to follow symlinks. (I'm not sure how to selectively disable to not follow some of the symlinks.)
I think the issue is that the directory is just very big.
I happened already multiple times that the Linux server became unresponsive because all memory was occupied, and luckily the Linux OOM killer killed rg and the system recovered a while later. This is what I see in dmesg -T:
[Tue Apr 14 11:14:15 2020] [ pid ]   uid  tgid total_vm      rss pgtables_bytes swapents oom_score_adj name
...
[Tue Apr 14 11:14:15 2020] [27303]  2574 27303  2550868  2546981 20484096        0             0 rg
...
[Tue Apr 14 11:14:15 2020] Out of memory: Kill process 27303 (rg) score 528 or sacrifice child
[Tue Apr 14 11:14:15 2020] Killed process 27303 (rg) total-vm:10203472kB, anon-rss:10187924kB, file-rss:0kB, shmem-rss:0kB
[Tue Apr 14 11:14:15 2020] oom_reaper: reaped process 27303 (rg), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB

In any case, this should never happen (crashing my whole system because OOM), even if the user opens a immensely huge directory (or let's say an infinite big virtual FUSE directory).
I tried to have this in the .vscode/settings.json but this does not seem to have an effect:
{
    // ...

    "search.exclude": {
        "**/data-*": true,  // there are huge directories behind this
        "logs-*": true,
        // and some more...
    },
}

Logs
Nothing relevant.

@albertz This looks like it should be filed on https://github.com/microsoft/vscode-ripgrep . This has nothing to do with the Python Extension. If you disagree please let us know.

@karthiknadig Ok, I will do. However, one thing: The workaround I tried with "search.exclude" does not work. Maybe there is another exclude option? From the code (here) I'm not sure what exclude will be relevant. I think this would be anyway good to have. Or maybe I just did sth wrong.

/cc @rchiodo Since the question is about nativeEditorProvider.ts.

Not sure why nativeEditorProvider.ts is relevant? Is that causing your memory issue? Our search?

@rchiodo Yes exactly. The linked code line exactly causes the memory issue.

We're calling a VS code API there. This one:
/**
		 * Find files across all [workspace folders](#workspace.workspaceFolders) in the workspace.
		 *
		 * @sample `findFiles('**/*.js', '**/node_modules/**', 10)`
		 * @param include A [glob pattern](#GlobPattern) that defines the files to search for. The glob pattern
		 * will be matched against the file paths of resulting matches relative to their workspace. Use a [relative pattern](#RelativePattern)
		 * to restrict the search results to a [workspace folder](#WorkspaceFolder).
		 * @param exclude  A [glob pattern](#GlobPattern) that defines files and folders to exclude. The glob pattern
		 * will be matched against the file paths of resulting matches relative to their workspace. When `undefined` only default excludes will
		 * apply, when `null` no excludes will apply.
		 * @param maxResults An upper-bound for the result.
		 * @param token A token that can be used to signal cancellation to the underlying search engine.
		 * @return A thenable that resolves to an array of resource identifiers. Will return no results if no
		 * [workspace folders](#workspace.workspaceFolders) are opened.
		 */
		export function findFiles(include: GlobPattern, exclude?: GlobPattern | null, maxResults?: number, token?: CancellationToken): Thenable<Uri[]>;

So it looks like it should be using the default excludes. Looking at the code in VS code, it looks like it might be a bug in how they handle it.

What are the default excludes? search.exclude?

I don't think there are any. That's the bug. You'd have to ask VS code to know for sure.

As a follow-up for the findFiles and default includes: It sounds like it uses the option "files.exclude". See the related issue here.


change beast and mlat tag grep to adsb-feed and mlat-feed in healthcheck.sh

doesn't yet address connection down :-(


NimBLECharacteristic-> setValue only writes 4 bytes

When I try to send data from ESP32 to my app, NimBLECharacteristic-> setValue only writes 4 strange bytes. However, the ESP32 does receive the data perfectly from the app through the same characteristic.
The function is this:
void sendJSONByBLE (JsonObject& json){
  Serial.println();
  Serial.println("sendJSONByBLE");
  String jsonString ="0123456789";
//  json.printTo(jsonString);
  const char* data = jsonString.c_str();

  PrintArg(data);
  pCharacteristic->setValue(data);
  pCharacteristic->notify();
}

and the debug info is this:
sendJSONByBLE

data =<PHONE_NUMBER>
D NimBLECharacteristic: ">> setValue: length = 4, data = 589dfe3f, characteristic UUID = b489981e-a163-394e-98cd-f497368be3f9"
D NimBLECharacteristic: "<< setValue"
D NimBLECharacteristic: ">> notify: length: 4"
D NimBLECharacteristicCallbacks: "onNotify: default"
D NimBLEServer: ">> handleGapEvent:"
D NimBLECharacteristicCallbacks: "onStatus: default"
D NimBLECharacteristic: "<< notify"
exits sendJsonToApp
D NimBLECharacteristicCallbacks: "onWrite: default"

The function declaring the characteristic is:
void initBLEservice() {
  BLEAdvertising* pAdvertising;
  pAdvertising = pServer->getAdvertising();
  pAdvertising->stop();

  // Create the BLE Service
  BLEService *pService = pServer->createService(NimBLEUUID(SERVICE_UUID));

  // Create a BLE Characteristic
  pCharacteristic = pService->createCharacteristic(
                      TO_APP_UUID,
                      NIMBLE_PROPERTY::READ   |
                      NIMBLE_PROPERTY::WRITE  |
                      NIMBLE_PROPERTY::NOTIFY
                    );
  pCharacteristic->setCallbacks(new ToAppCallbacks());
 // pCharacteristic->addDescriptor(new BLE2902());

  BLEAdvertisementData responseData;
  responseData.setName("myName");
  responseData.setCompleteServices(NimBLEUUID(SERVICE_UUID));
  //responseData.setPartialServices(NimBLEUUID(SERVICE_UUID));
  pAdvertising->setScanResponseData(responseData);
  pAdvertising->addServiceUUID(NimBLEUUID(SERVICE_UUID));

  // Start the service
  pService->start();

  pAdvertising->start();

  Serial.println("Inicializado service");
}

class ToAppCallbacks: public BLECharacteristicCallbacks {
    void onWrite(BLECharacteristic *pCharacteristic) {
      std::string value = pCharacteristic->getValue();
      if (value.length() > 0) {
        StaticJsonBuffer <256> jsonBuffer;
        JsonObject& json = jsonBuffer.parseObject((char *)&value[0]);
        json["by"] = (uint8_t)byBLE;
        packJSON(json);
      }
    }
};

String jsonString ="0123456789";
const char* data = jsonString.c_str();
const char* data = jsonString.c_str();

  PrintArg(data);
  pCharacteristic->setValue(data);

You have 2 options to fix the issue here.
-1 you can change String jsonString to std::string jsonString and pass that to setValue directly.
-2 you could include the length parameter in the call to  pCharacteristic->setValue(data); for instance :pCharacteristic->setValue(data, jsonString.length());

Hi,
somehow you are sending the address of the cstr, not the content.
use
setValue(const uint8_t *data, size_t size)
or
setValue ( const std::string & value )
personally, I go with the first.....
s
:) h2zero woke up and got there first!

Thanks!!
My code is directly migrated from the original BLE library, and -> setValue just worked with (const char * data) as the only parameter. I had not queried the API.
Finally the code that works for me is:
  const char* data = jsonString.c_str();
  pCharacteristic->setValue((unsigned char *)data, jsonString.length());

without casting from (char *) to (unsigned char *) gives me compilation error.

My code is directly migrated from the original BLE library, and -> setValue just worked with (const char * data) as the only parameter. I had not queried the API.

That's quite odd, I'll have to look at the arduino api. I ported this from the snippets library more-so than from arduino. Possibly something to add or at least note. Thanks for the info, glad it's working for you!

Thanks to you for your great work.

Hi, I am experiencing the same behaviour with the latest version.
My code:
String json = "json string";
characteristic->setValue((unsigned char*) json.c_str(), json.length());

But when I read the characteristic on the phone I only get an array of 4 bytes. Any idea?

just an idea...  try (const uint_8 *) instead of (unsigned char *).
It may be a matter of the way the compiler is choosing which setValue() function to use from the class, so the lack of const may cause it to choose the wrong one?
(also check the .h file to see EXACTLY how the function is defined, and match it)

I tried also converting the String to std::string but always the same behaviour

stick a debug output in the function in the library - the one you hope is being called - to see if it is.... it's got to be calling the wrong function...

You can use a std::string directly
  std::string json = "json string";
  characteristic->setValue(json);

or alternatively convert your String to a std::string
  String json = "json string";
  characteristic->setValue(std::string(json.c_str()));

I solved by passing
setValue(*(json.c_str()));

Apparently, I solved with:
String json = String("value");
characteristic->setValue(*(json.c_str()));


Add a io.kestra.plugin.docker.Run task allowing to execute a list of docker run commands in a container without setting any interpreter

Issue description
Currently, in the Shell Commands, we allow overriding the entrypoint with commands. However, some users with highly customized images need more flexibility.
Proposed syntax
id: run
namespace: company.team
tasks:
  - id: docker
    type: io.kestra.plugin.docker.Run
    inputFiles:
      myfile.csv: hello
    outputFiles:
      - "*.parquet"
    namespaceFiles:
      enabled: true
    commands:
      - docker run -it --name myapp -w /app python:3.9 python namespace_script.py
      # --device=/dev/snd:/dev/snd my-image to give access to sound devices.
      # --entrypoint /my/entrypoint.sh my-image Overwrite the default ENTRYPOINT of the image.
      # --cpu-quota=50000 --cpu-period=100000 my-image limits the container to 50% of one CPU.
      # --add-host=myhost:<IP_ADDRESS> my-image
      # --memory=512m --memory-swap=1g my-image
      # --network=host my-image to use the host's network.
    pullPolicy: ALWAYS
    credentials: # optional creds to pull docker image from
      registry: <registry.url.com>
      username: <your-user>
      password: <your-password>

Possible naming

io.kestra.plugin.docker.Run
io.kestra.plugin.docker.run.Commands

additional use case from the community:
"I was also struggling with this when trying to use yq container with Shell.Commands task: https://github.com/mikefarah/yq/ - a container that already has an entrypoint defined and no extra interpreter setting is necessary. A generic Docker container runner would be appreciated!"

I named it io.kestra.plugin.docker.Run for simpicity as we already have Build taslk in the same package.
I slightly change the way to pass Docker properties, to be able to easily use our existing Docker Runner I set all Docker properties inside a docker property. This also facilitate switching from Docker Run to Shell Command for ex.

one of the main goals of the task is that users can leverage their existing docker run ... commands without having to set properties in YAML, so it would be better if we infer some properties from the command than forcing the user to e.g. move a specific part of the command to a YAML property
but let's share the PR and then we can have a look 👍


Add strace_parser to gen. seccomp manifest entries

Add a new CLI tool to parse strace files from container runs and generate seccomp manifest entries from it.
This entry can then be added to the manifest of the container to enable seccomp support for it.

What part of the "npk" feature does it need?

What part of the "npk" feature does it need?

It's npk::manifest::{Seccomp, SyscallRule}.
   Compiling seccomp-util v0.1.0 (/home/felix/northstar/tools/seccomp-util)
error[E0433]: failed to resolve: could not find `npk` in `northstar`
  --> tools/seccomp-util/src/main.rs:18:5
   |
18 |     npk::manifest::{Seccomp, SyscallRule},
   |     ^^^ could not find `npk` in `northstar`

error[E0433]: failed to resolve: use of undeclared type `SyscallRule`
  --> tools/seccomp-util/src/main.rs:47:75
   |
47 |                     syscalls.insert(NonNullString::try_from(m.as_str())?, SyscallRule::Any);
   |                                                                           ^^^^^^^^^^^ use of undeclared type `SyscallRule`

error[E0412]: cannot find type `SyscallRule` in this scope
  --> tools/seccomp-util/src/main.rs:39:46
   |
39 |     let mut syscalls: HashMap<NonNullString, SyscallRule> = HashMap::new();
   |                                              ^^^^^^^^^^^ not found in this scope

error[E0422]: cannot find struct, variant or union type `Seccomp` in this scope
  --> tools/seccomp-util/src/main.rs:52:17
   |
52 |     let entry = Seccomp {
   |                 ^^^^^^^ not found in this scope

error: aborting due to 4 previous errors

Some errors have detailed explanations: E0412, E0422, E0433.
For more information about an error, try `rustc --explain E0412`.
error: failed to compile `seccomp-util v0.1.0 (/home/felix/northstar/tools/seccomp-util)`, intermediate artifacts can be found at `/home/felix/northstar/target`

Caused by:
  could not compile `seccomp-util`

To learn more, run the command again with --verbose.


No tag for Vulkan SDK 1.3.296?

There's a vulkan-sdk-1.3.296 branch, but no vulkan-sdk-1.3.296.0 tag.

It was just tagged

Thank you for creating an issue about this!

Thanks, appreciated!


Missing use in example

In the "Export configuration:" section you use the constant CsvFileObject::FILE_MODE_WRITE but this is only available if you have brought in the CsvFileObject library so you need to add the extra use clause.

!!! Same here! Can be fixed by adding
use Goodby\CSV\Export\Standard\CsvFileObject;
However, it still does not render CSV files.


How to ignore unlisted dependencies?

Unlisted dependencies (3)
@typescript-eslint/parser          .eslintrc.js
eslint-config-canonical            .eslintrc.js
eslint-import-resolver-typescript  .eslintrc.js

It looks like it infers that the plugin is in use based on which rules are mentioned:
const ruleOverrides = {
  '@typescript-eslint/dot-notation': 0,
  '@typescript-eslint/naming-convention': 0,
  '@typescript-eslint/no-misused-promises': 0,
  '@typescript-eslint/no-redeclare': 0,
  '@typescript-eslint/no-unnecessary-condition': 0,
  '@typescript-eslint/prefer-nullish-coalescing': 0,
  '@typescript-eslint/prefer-optional-chain': 0,
  '@typescript-eslint/prefer-string-starts-ends-with': 0,
  '@typescript-eslint/promise-function-async': 0,
  'canonical/filename-match-regex': 0,
  'canonical/id-match': 0,
  'canonical/prefer-import-alias': [

This is smart. However, in cases like eslint-config-canonical, the config itself has a dependency on the plugins, and this becomes and undesirable.

Knip doesn't use rules to infer dependencies (it looks at extends plugins, parser and settings, and also in overrides for the same).
But looking at https://github.com/gajus/eslint-config-canonical/blob/main/configurations/eslintrc.js, this looks like a bug in Knip. Will look into it soon!

Not sure if I'm trying the right thing, but in that repo, either one of these configs (knip.json) seem to work well:
{
  "entry": ["compare/*.js"],
  "eslint": ["*.js"]
}

{
  "workspaces": {
    ".": {
      "eslint": ["*.js"]
    },
    "compare": {}
  }
}

Then I wonder why it is reported as unlisted. Got a rep(r)o? :)

Given only that config, Knip finds these dependencies (rules are ignored):
    '@contra/eslint-config',
    'eslint-plugin-relay',
    '@typescript-eslint/parser',
    'eslint-import-resolver-typescript',
    'eslint-config-canonical',

Normally the dependencies would be direct or peer dependencies. Not sure how Knip could make an exception here without affecting other setups.

Going to close this issue. Since the dependencies are "directly" referenced in the ESLint config, Knip can only assume they should be listed in package.json.
Fixing this issue would mean transitive dependencies are OK, and I prefer not to go that way.

That's fair.
I would still consider ignoreUnlisted configuration for cases where it is desirable to support transitive dependencies.
I am trying to restructure out project to avoid this altogether.

@webpro I have a same issue.
I'm sharing config files across multiple repos as an npm library, which itself contains eslint configuration and dependencies.
Typically eslint config of an app consuming this library looks like this:
const merge = require("deepmerge");
const { createEslintConfig } = require("@omnic/widget-config");

const rootConfig = createEslintConfig();

module.exports = merge(rootConfig, {
  root: true,
  env: { node: true },
  rules: { "@typescript-eslint/no-var-requires": "off" },
});

And here is my output

Fixing this issue would mean transitive dependencies are OK to directly depend on, and I prefer not to go that way.

Isn't it possible to optionally enable transitive dependencies check? It would be very helpful in case of using Knip for module federations for example, cause they usually have some shared configs/ui-kits, and duplicating all the dependencies is not a way

Isn't it possible to optionally enable transitive dependencies check?

This is a common yet non-trivial issue to solve. It's on my radar.

P.S. Also can't figure out how to deal with these .svg imports (I'm using vite + svgr plugin)

This is usually worked around by using relative imports (e.g. ./src/icon.svg).

Hi @webpro I have two (related?) issues in my RN codebase:
Unused dependencies (1)
react-native-background-fetch  package.json
Unlisted dependencies (1)
domhandler  .../RenderHTML/index.tsx

react-native-background-fetch is required by react-native-background-geolocation
domhandler seems to be exposed by htmlparser2

is there a way to
// knip.json
{
  "ignoreUnUsedDependencies": ["pattern/**/*"],
  "ignoreUnListedDependencies": ["pattern/**/*"]
}

I can probably add domhandler as a dependency, but I don't know how to go about react-native-background-fetch reported as unused. Any ideas?

This issue's already closed. Please create a reproduction and file a new one if you want us to look into it.

My bad. Found a workaround here https://knip.dev/reference/configuration#ignoredependencies


Exit Code 0 on Exception

Zappa returns a 0 exit code when the operation fails, causing my Jenkins to mark the build as success even though it failed.
My specific example is calling
zappa deploy dev
when the lambda function already exists, which results in
An error occurred (ResourceConflictException) when calling the CreateFunction operation: Function already exist: testfunction
zappa then exits with a 0 status and the Jenkins build passes

Excellent bug! Would love to know more about your Zappa/Jenkins setup.

Sure, so at the moment our release process for staging and production is using Jenkins to package up our program and then use Salt Stack to distribute it to EC2 instances.
I am setting it up so that it packages up our Pyramid app and deploys it on Lambda / API Gateway, Zappa seemed a pretty perfect fit, so I'm just trying it out.
The Jenkins setup itself is pretty simple, just an EC2 instance with a job. This way every time someone pushes to Bitbucket, Jenkins should use Zappa to build and release to staging.
Here's the job config, if you're interested:
`
PYENV_HOME=$WORKSPACE/.pyenv/
Delete previously built virtualenv
if [ -d $PYENV_HOME ]; then
rm -rf $PYENV_HOME
fi
Create virtualenv
virtualenv --no-site-packages $PYENV_HOME
. $PYENV_HOME/bin/activate
Install auth package
pip install --quiet -e $WORKSPACE/auth/auth_server/
Install Zappa
pip install --quiet zappa
Build and dist
cd auth/auth_server
#zappa deploy dev  # For initial deploy
zappa update dev  # For updating deployment
`

Oh, great! Thanks for sharing this!
Did you try Pyramid with Zappa manually yet? I haven't tried that yet myself, I'd like to know if there's any Pyramid-specific stuff that could benefit from documentation.

I'm having a hard time trying to figure out how I'm supposed to port over my .ini file with all my pyramid config and database connection strings over to Zappa.
In #43 there is talk about a zappa.ini file, but I can't see anything in the instructions or the code about .ini files at all

I'd recommend pegging Zappa to a known 'good' version for you during the pip install --quiet zappa. Nothing is guaranteed as stable until we get a 1.0.0 though!

A simple fix for this should be pushed in the latest Zappa version, 0.19.4. I don't think it's perfect but at least it's something.
Thanks for reporting this!

@Miserlou if you're still interested, I never got Pyramid working with Zappa and just switched to Flask


fix(core): make font props work independently

Closes #845
Ignore the branch name... the plan changed along the way.

Something's wrong with the tests... working on it.


Dynamic Links (Universal links) on iOS13 not always working

[REQUIRED] Step 1: Describe your environment

Xcode version: 11.6
Firebase SDK version: 6.28.1
Firebase Component: Dynamic Links
Component version: 6.28.1
Installation method: CocoaPods

[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
Dynamic Links are not working consistently on iOS13. We have a number of our customers complaining about the issue and we've been able to replicate on a handful of our own devices here.
For example, downloading our app store build we've seen the following:
Not working:
iPhone 7, 13.6.1 (via Gmail app)
iPhone Xs, 13.3 (via Gmail app)
iPhone XR, 13.6.1 (via Gmail app)
Working:
iPhone SE, iOS 13.6.1 (via Gmail app)
iPhone 6s, iOS 13.6 (via Gmail app)
iPhone 6s Plus, 13.6.1 (via Mail app)
iPhone 7, iOS 13.5.1 (via Gmail app)
iPhone 6, iOS 12.4.8
I can't really pinpoint exact models/OS but it seems to be the more modern models are affected.
There is this related (but closed) issue: https://github.com/firebase/firebase-ios-sdk/issues/4914 where a number of users also experience the same issue, however no solution was provided. We have restarted the device, deleted/reinstalled the app etc, and problem always remains on the affected devices.
The symptom of the issue is that upon clicking the dynamic link from an email we send to the user, asking the user to verify their email address when creating an account, instead of the user being redirected to our app on the device, the user is presented with a preview.page.link web page with an “Open” button that directs the user to the app store even though the app is correctly installed on the device already.
See:

Note that we only use the long version of dynamic links (no short or “un-guessable” deeplink). We have tested tapping the dynamic link from gmail and outlook apps.
This is an example deeplink we use on our live app to verify a users email:
https://{myapp}.page.link/?link=https%3A%2F%2Fverify.{mydomain}.com%2F%3FverificationToken%3DAAk6AqPrGAariuT23hcAWniAMmIraCpQuAt2IxZ1Edff4m8TtZYovfjMOGxuJyHB%26product%3Ddefault%26lang%3Den&ibi={ios_bundle_id}&isi={ios_app_id}&apn={android_pn}
As mentioned, for some users the OS correctly reopens our app for us to handle the link attribute. And for others, it shows a preview webpage.
We have verified the link is setup correctly by checking the debug flow diagram at:
https://{myapp}.page.link/?link=https%3A%2F%2Fverify.{mydomain}.com%2F%3FverificationToken%3DAAk6AqPrGAariuT23hcAWniAMmIraCpQuAt2IxZ1Edff4m8TtZYovfjMOGxuJyHB%26product%3Ddefault%26lang%3Den&ibi={ios_bundle_id}&isi={ios_app_id}&apn={android_pn}&d=1
See attached screenshots that shows 0 warnings and a complete flow diagram.

We have also run the swift DynamicLinks.performDiagnostics(completion: nil) code
Which shows there are no issues:
---- Firebase Dynamic Links diagnostic output start ----
Firebase Dynamic Links framework version 4.2.0
System information: OS iOS, OS version 13.3, model iPhone
Current date 2020-09-02 11:23:23 +0000
Device locale en-GB (raw en_GB), timezone Europe/Dublin
Specified custom URL scheme is {ios_bundle_id} and Info.plist contains such scheme in CFBundleURLTypes key.
AppID Prefix: {app_id_prefix}, Team ID: {team_id}, AppId Prefix equal to Team ID: YES
performDiagnostic completed successfully! No errors found.
---- Firebase Dynamic Links diagnostic output end ----
And as mentioned already, we can see it works for some devices but not others. Android works as expected also.
We are using the firebase supplied domain.page.link domain so have no control over how the AASA file is served: https://{myapp}.page.link/apple-app-site-association
Which shows:
{
   "applinks":{
      "apps":[

      ],
      "details":[
         {
            "appID":"<team_id>.<ios_bundle_id>",
            "paths":[
               "NOT /_/*",
               "/*"
            ]
         }
      ]
   }
}

During investigation, we found that, if we use the firebase “hosting” to set up a custom site we can force the use of a custom AASA file by creating a dummy hosted web page for our project which enables us to provide an AASA file, the issue does not reproduce. It opened the app correctly.
Custom ASSA file: https://{myapp}.firebaseapp.com/apple-app-site-association
firebase.json on the hosting site:
{
  "hosting": {
    "site": "myapp",
    "appAssociation": "NONE",
    "public": "public",
    "rewrites": [
      {
        "source": "/**",
        "dynamicLinks": true
      }
    ],
    "headers": [
      {
        "source": "/apple-app-site-association",
        "headers": [
          {
            "key": "Content-Type",
            "value": "application/json"
          }
        ]
      }
    ]
  }
}

Even if that custom AASA file is identical to the default one (we checked by reading the AASA file directly from the default Firebase dynamic link URL: https://{myapp}.page.link/apple-app-site-association). The custom one works, and the default page.link doesn't
This however, is not a suitable solution as our systems are all set-up to use the default link already and we do not want an empty web page presence but there seems to be no other way to provide a custom AASA file for use by the Dynamic Links component of Firebase.
So the issue seems to be related to the default {myapp}.page.link setup / apple-app-site-association files auto generated by firebase when only enabling the dynamic link component of Firebase on iOS 13.
Hopefully thats enough information. I would be more than happy to provide any more information if it helps with the debugging. Many thanks in advance.
Relevant Code:
N/A

Hi @ryanwilson thanks for assigning @eldhosembabu
I appreciate you will look at this issue once you get to it. However is there any chance you could provide an estimate of when you or someone might look into it? As mentioned we have a live app affecting our customers currently with this issue. Again I appreciate you have other issues/features to work on, but if you could provide an indication of when this issue will be investigated that would be very much appreciated.
Thanks

I'm facing the same issue, which was already reported and closed without any real solution.
My last attempt to solve it was to implement the missing scene handlers for deepLinks (code below, objC), but that did not work.
I also have a live app with firebase password-less email login, and this issue adds a ton of friction to it (and one star reviews).
- (void)scene:(UIScene *)scene
  willConnectToSession:(UISceneSession *)session
               options:(UISceneConnectionOptions *)connectionOptions {
    [[FIRDynamicLinks dynamicLinks]
      handleUniversalLink:[[connectionOptions.userActivities allObjects] firstObject].webpageURL
               completion:^(FIRDynamicLink *_Nullable dynamicLink, NSError *_Nullable error) {
                 [self onDeepLinkResult:dynamicLink error:error];
               }];
}

- (void)scene:(UIScene *)scene
    openURLContexts:(NSSet<UIOpenURLContext *> *)urlContexts {
    [[FIRDynamicLinks dynamicLinks]
      handleUniversalLink:[[urlContexts allObjects] firstObject].URL
               completion:^(FIRDynamicLink *_Nullable dynamicLink, NSError *_Nullable error) {
                 [self onDeepLinkResult:dynamicLink error:error];
               }];
}

- (void)scene:(UIScene *)scene
    continue:(NSUserActivity *)userActivity {
    [[FIRDynamicLinks dynamicLinks]
      handleUniversalLink:userActivity.webpageURL
               completion:^(FIRDynamicLink *_Nullable dynamicLink, NSError *_Nullable error) {
                 [self onDeepLinkResult:dynamicLink error:error];
               }];
}

@vinicius-animo Thanks for your feedback.
I can confirm I also tried the SceneDelegate implementation and it did NOT work either unfortunately. The affected devices still showed the same issue. I wasn't convinced it would make a difference anyway since we have a number if iOS 13 devices which work fine for our dynamic link, and some devices that don't. And as described above, on the affected devices I was able to confirm the dynamic link would work when using the "hosting" method. However its good to rule out.
Some other things I tried was:

Verify my URL scheme works. I use my bundle id as a URL scheme. So simply entering {bundle_id}:// into safari, did it open my app? Yes it did

For the "link" parameter I tried using different links such as google.com to see if that made any difference. It still had the same issue.

I did the same test again ("link" parameter as google.com) but without any of the ibi, isi, apn parameters on the dynamic link. This time instead of showing the "preview" webpage, it went to google.com (the link attribute). So this behaviour at least seems consistent.

I did the same again as my last test, but instead using the actual "link" I wanted, but without the ibi, isi, apn parameters. Again it didn't show the "preview" webpage, and redirected to my link correctly.
e.g.
https://{myapp}.page.link/?link=https%3A%2F%2Fverify.{mydomain}.com%2F%3FverificationToken%3DAAk6AqPrGAariuT23hcAWniAMmIraCpQuAt2IxZ1Edff4m8TtZYovfjMOGxuJyHB%26product%3Ddefault%26lang%3Den

Still not opening the app though...

I'm having the same problem. Dynamic links worked fine a few days ago and now on the same devices the link will not open directly to the app but rather show the preview.page.link and then either go nowhere (in the case of email link signup) or go to the app store and not the app (in the case of my other dynamic links).

Hi @salami,
Thanks for sharing your experience.
Like you we tried difference versions of Xcode, clear derived data etc, but the same affected devices always had the issue. We also have devices on the same iOS version using the same build, one device works, and the other not (see my original post).
One thing I found really interesting/weird just now is you suggestion of WhatsApp. Up until now we have been taping the dynamic link within an email using either the gmail app, outlook app or mail app depending on the device.
I pasted the link into WhatsApp and tried tapping it from there, and it redirected successfully to our app. So then I tried again tapping the link from gmail, and then suddenly that worked again as well. So then I thought I'd try deleting the app from the device, reinstall it again from the app store, and then try gmail again. And guess what the error is back (shows the preview page). Now if I try tapping the link in WhatsApp again, it too also has the error. Any combination of deleting the app and tapping in either app still shows the error. I have no idea why it worked very briefly on the first test. Also to note, the 3 devices we've managed to replicate the issue on was all via the gmail app - not sure if related or not. But also keep in mind we have had many devices across different iOS versions that work fine with gmail. e.g. 13.6.1 using gmail, one device worked, and the other didn't. The only difference here being the model of iPhone.

Thank god, with your solution:
<key>FirebaseDynamicLinksCustomDomains</key>
<array>
	<string>https://myapptest.firebaseapp.com</string>
</array>

I can fix the error Url is Nil and return google/link/?dismiss=1&is_weak_match=1
You saved my life sir @danh-geo it took me 20 hours already

Hi @hiepxanh,
Are you using the "hosting" method of creating a {sitename}.firebaseapp.com as opposed to the {sitename}.page.link?
I'm still trying to use the {sitename}.page.link method of Firebase Dynamic Links, but I still have an issue with it on certain devices, even if I append dismiss=1&is_weak_match=1, e.g.:
https://{myapp}.page.link/?link=https%3A%2F%2Fverify.{mydomain}.com%2F%3FverificationToken%3DAAk6AqPrGAariuT23hcAWniAMmIraCpQuAt2IxZ1Edff4m8TtZYovfjMOGxuJyHB%26product%3Ddefault%26lang%3Den&ibi={ios_bundle_id}&isi={ios_app_id}&apn={android_pn}&dismiss=1&is_weak_match=1
From my understanding, you only need to use FirebaseDynamicLinksCustomDomains in the plist if its something other than {sitename}.page.link (I did try having {sitename}.page.link here also, but it made no difference in my tests. It was required for my {sitename}.firebaseapp.com test though)
The other thing I'm unclear on is dismiss=1&is_weak_match=1. I can't seem to find anything about this in the firebase documentation. Am I missing something?
I'm glad some of my findings helped you though 👍

@danh-geo FYI, I switched libraries (now using branch.io SDK) and the problem is gone.
I'll keep following up the discussion here. Hope this bug is fixed soon :)

Thanks @vinicius-animo, in the meantime we have removed the dynamic links from our email templates because of the unexpected/unpredictable behaviour.
Similar to my peculiar WhatsApp test a few posts up. I also experienced more weird behaviour. So as well as our email verification dynamic link (via our verify.{mydomain}.com), we also have a similar dynamic link for the forgot password experience (recover.{mydomain}.com). Both dynamic links are very similar. So I tested the live app store build for this recover dynamic link on one of our affected devices and it redirected to the app correctly. I then tried the original email verification dynamic link and suddenly that worked OK also. I then deleted the app and reinstalled from the app store and this time tested the original email verification dynamic link first, and it showed the "preview" error. I then tried the forgot password dynamic link and then now that also shows the "preview" error. And once I get the preview error for this link style, I always get the error even after app restarts.

hi guys,
I used resolveShortLink function to get around the issue, something like this

let linkHandled = DynamicLinks.dynamicLinks().handleUniversalLink(incomingURL) { (link, error) in

            if let error = error {
                dLog("Error while handling link: \(error.localizedDescription)")
                return
            }

            if let dynamicLink = link, dynamicLink.url != nil {
                DeeplinkManager.shared.handleDynamicLink(dynamicLink)
            } else {
                DynamicLinks.dynamicLinks().resolveShortLink(incomingURL) { (link, error) in
                    guard let link = link,
                          let component = (URLComponents(url: link, resolvingAgainstBaseURL: true)?.queryItems?.first { $0.name == "deep_link_id" }),
                          let deeplink = component.value?.toURL   else {
                        return
                    }
                    DispatchQueue.main.async {
                        _ = DeeplinkManager.shared.handleDeeplink(deeplink)
                    }
                }
            }
        }

According to this: https://developer.apple.com/forums/thread/123554?answerId=419087022#419087022
Apple prioritizes .com's differently than .links (at least in US). Could this explain why the original posters Firebase hosted version worked better than the .link URL? If so, perhaps that is the solve?

It seems you can remove this default page by configuration it in step 5 of your Dynamic Link.
You can also do it manually by adding parameter efr=1 when creating your url : https://firebase.google.com/docs/dynamic-links/create-manually

Is there still no solution on this one from Firebase? i could only see workarounds.

After looking up firebase documentation and other stackoverflow options, we created a piece of code that helped to resolve this issue.
You need to add "FirebaseDynamicLinksCustomDomains" parameter in info.plist file.
Dynamical URL :
https://yourapp.page.link/?link=https://yourapp.com/test=12345&isi=14602xxxxx&ibi=com.xxxx.yourapp
The important parameter in info.plist file :
<key>FirebaseDynamicLinksCustomDomains</key>
<array>
    <string>https://yourapp.com</string>
    <string>https://yourapp.com/link</string>
</array>

If you have a production critical app which has this issue, do not hesitate to ask me for inputs. Hit me up at https://khushalbhalsod.nl.

I had something similar happening to one of my users and it turned out they had somehow disabled universal links on their phone for the app.
This video at 8:20 covers how to fix it - the user has to long press the link and select to open via the app again to re-enable universal links.
https://youtu.be/KLBjAg6HvG0?t=500
Not sure if this is the same problem as everyone else is having, but thought it worth posting in case it helps.

Not sure if this is related as I've tried some of the steps; my issue is once I press "Open" on the preview page, it does go back into the app - but it stays on the home screen, and doesn't got to the ViewController that I noted in the AppDelegate.
The Dynamic link configuration printed in the console says 'No errors found', but none of the print statements in the dynamic link functions in the App Delegate appear.  -----> Screenshot attached, "something" never shows up and all of the related Dynamic links functions below it don't seem to get executed

The Firebase Dynamic Links service will be shutdown on August 25, 2025.  In the meantime, only critical or security issues will be fixed in the SDK.
More at https://firebase.google.com/support/dynamic-links-faq


Allow publisher to always publish by setting the threshold to zero.

(Thanks @JafarAbdi for this great ros2 topic library.)
On documentation (https://github.com/PickNikRobotics/topic_based_ros2_control/blob/main/doc/user.md) trigger_joint_command_threshold can be configuration with zero so that the allow publisher to always send the joint command.
However, in the code the condition was set with:
  if (diff <= trigger_joint_command_threshold_)
   {
     return hardware_interface::return_type::OK;
   }

In case trigger_joint_command_threshold_ is set to zero, diff can still be zero so it will not trigger the send.
This PR tries to address the above mentioned case.

Thanks @yongtang for the PR!
Do you mind changing the readme to say set to -1 to always send the joint command rather the code logic?

@JafarAbdi  Ah yes. The value is taken from std::stod (https://github.com/PickNikRobotics/topic_based_ros2_control/blob/main/src/topic_based_system.cpp#L144) so negative value is possible. The PR has been updated. Please take a look.


fix(vendor): declare build.rs as included file in Cargo.toml

What does this PR do
It adds the file build.rs to the package included files in Cargo.toml. Without it, when vendoring a project that depends on nix, build.rs is not added in vendor cache, then macos targets are broken since the cfg_aliases configuration added in https://github.com/nix-rust/nix/pull/2169 is missing.
Checklist:

[X] I have read CONTRIBUTING.md
[ ] I have written necessary tests and rustdoc comments
[ ] A change log has been added if this PR modifies nix's API

No problem, I'm glad it can be fixed before the next release!


compilation.chunks.add is not a function

System Info
all
Details
As part of the build from Angular CLI there is a step that injects scripts directly into the bundle via a configuration in the angular.json this leverages the compilation.chunks.add function which is currently not available.
Reproduce link
No response
Reproduce Steps
add a script file to the angular.json file in an angular cli based rspack build

bump

bump

bump

Fixed in v1.0.0-alpha.0


2016 Roadmap

Check out the roadmap for Immutable.js here https://www.facebook.com/notes/lee-byron/immutablejs-2016-roadmap/10153447836068757
This is a strawman document, which means I'm interested in your feedback on these priorities and to understand if I may have missed something.
Feel free to use this issue as a place to leave comments!

Have you seen this article (http://bendyworks.com/leveling-clojures-hash-maps/)? It might be useful to improve performance.

@leebyron you mentioned Records in the roadmap. What is the plan for Records in combination with Typescript? I'm refactoring my TypeScript flux implementation to use ImmutableJS but atm I'm losing all the nice type generics in my React Components. I saw some issues here but I wanted to know the 'official' plan?

Kind of related to API simplicity -- a REPL would go a long way. A big reason I go to the Immutable docs is to open up the Web Inspector and see what different method calls do. Building a REPL is a fairly well-defined task too so getting help from the community could be an option here.

Kind of related to API simplicity -- a REPL would go a long way. A big reason I go to the Immutable docs is to open up the Web Inspector and see what different method calls do. Building a REPL is a fairly well-defined task too so getting help from the community could be an option here.

Nice work on the roadmap! +1 to modularisation (and any other size refinements): 55kB minified is currently too prohibitively large to embrace in many projects/frameworks. I'd like to leverage this internally in my framework, but the rest of the (full-stack) framework is 6kB, so the bloat would make it a burden for some users/cases.
Another option for the size-conscious perhaps could also be to provide a simpler .lite.js version/build?

We're currently working on using immutable.js with flux. A complete and correct type declaration for immutable.js and good support for Records would be highly appreciated, this is the area where we've been running into roadblocks.

@MSch yes, same problem here. Flux stores with the power of compile-time type checks have a lot of potential. Combined with immutable data structures even more. Sadly Records are not ready for TypeScript.

Modularity is definitely something I'm looking forward to. I've been watching the status of this at this issue https://github.com/facebook/immutable-js/issues/317

To achieve this, some API changes will be necessary, for example removing myThing.toMap() in favor of Map(myThing).

I would just like to point out some issues around getting rid of toMap(). Take a look at #600 and #697. Ideally, this sort of behavior would fit better under the map() function, but you cannot specify keys via map().

On the subject of Interoperability with JavaScript, Chrome 47+ supports customer formatters.
I wrote a simple formatter to prettify the output of Immutable.js data structures.
If this is something of interest, I'm happy to do a PR and include it in the REPL for the doc pages.

@danielepolencic oh man that's amazing! :+1: Definitely going to check this out. :smile:

@danielepolencic this is really helpful. Thanks for sharing!

I am looking forward to Modularity, API Simplicity (which I hope to find some time to contribute to!), and React use cases improving.
It has been requested before, but a great addition to 2016 would be the SortedMap. A helpful implementation from collection.js. I could see this being useful in several projects.
@danielearwicker I have been using, immutable-devtools maybe you guys could collaborate. Thanks for the formatter!

@vinnymac you tagged me, but I'm not sure why - was it intentional? :)

@danielearwicker github's autocomplete ranked you higher up, my mistake 😅. Happy to accidentally include you in this thread.

Be really cool to see the roadmap of Immutable find it's way into the language eventually! The spec by Sebastian Markbage is a great start, https://github.com/sebmarkbage/ecmascript-immutable-data-structures. What are people's thoughts?

I'd also like to voice my support for pre-sorted maps, sets and lists. Currently I have to add an item to an ordered map and then sort it. Even though the entire list will have already been in the correct order aside from the last item, it still takes the same amount of time to sort the new item into the correct position as it would if all of the items were out of order. The slowdown is noticeable when dealing with lists containing hundreds of thousands of items, and it's even worse with a million or more items. A sort that is applied at insertion time would mitigate this issue almost entirely. #88

any news on "Modularity"? maybe it could a good first step to transpile src/ to lib/ as is in terms of included files? so we can import Map like import Map from 'immutable/lib/Map'.


Chat button

I believe chat button is too hard to find. Took me a while to find it even though I knew it had to exist somewhere (and forgot exactly where). I think we should add chat button to notifications if the trip is already confirmed.

Isn't this closed?


add yml header in mailboxes

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/mailboxes/mailboxes.md
:white_check_mark:Succeeded
View (exchserver-ps-2016) View (exchserver-ps-2013) View (exchonline-ps) View (eop-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Call the %attrs macro with slice-canary

Not doing so will lead to the file being installed, but not listed in
the files of the package this error is thrown:
RPM build errors:
Installed (but unpackaged) file(s) found:
/usr/bin/slice-canary

Thank you!
LGTM.


Should export PATH contain $PATH in .zshrc?

To make RVM work, I had to add :$PATH at the end of PATH in .zshrc:
export PATH="/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:$PATH"

Shouldn't that be a default?

There's an ongoing discussion about this in #1359 and #2589.

Why does this requires an 'ongoing discussion'?
why is so difficult to restore default behaviour?
why do I have to manually restore PATH?

@vassyz hah, looking at differences between distribution-shipped zshrc and OMZ zshrc, OMZ explicitely overrides PATH. I've only commented that line (line 97) and now I've got default good PATH as root.
#export PATH="/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games"

This is fixed on the current version of the installer.


fetchSearchTweets limits

It seems like when using fetchSearchTweets example:
await scraper.fetchSearchTweets('elonmusk', 25)
There is a limit of fetching 20 tweets each fetch?

That function returns a single page of results, but the number of results per page is undefined. It should return a cursor you can use to get more data.
The fetch functions are mostly intended for use in environments that don't support async generators — I recommend using searchTweets instead so pagination is handled automatically.

That function returns a single page of results, but the number of results per page is undefined. It should return a cursor you can use to get more data.
The fetch functions are mostly intended for use in environments that don't support async generators — I recommend using searchTweets instead so pagination is handled automatically.

Yeah I figured the cursor part out 👍
But as of right now I have to use fetchSearchTweets since searchTweets doesn't work with reply's right now.


Support formatting option: vertical align

Description
I prefer a neat list with proper align for CSS, Js/Ts and HTMl
Input
With this new feature, when I give like this input:
<input
    id="ok"
    name="ok"
    autocomplete="off"
/>

:root {
   --round-small: 0.0625rem; // 1px
   --round-medium: 0.125rem; // 2px
   --round-pretty-big: 0.25rem; // 4px
}

Expected Output
I'd like to see this output:
<input
    id           ="ok"
    name         ="ok"
    autocomplete ="off"
/>

:root {
   --round-small      : 0.0625rem; // 1px
   --round-medium     : 0.125rem; // 2px
   --round-pretty-big : 0.25rem; // 4px
}

For Js/Ts is when you group all declaration vars (no newline) or you have a list (array, map) in multiple lines.
Environment
OS: Linux
Somehow on my pc the github didn't display monospace font properly so I didn't see a correct vertical align, hopefully you can see it on your side.

I would like to contribute , please assign it to me


Web interface fails to translate

Here is my srt file:
outfile3.zip
Any suggestions? ( I also tried "use moderator")

Try to open the browser inspector and take the screenshot of the error details from there.
Meanwhile I would fix the error display.

Any updates? Are you on free tier? I think most likely it is rate limit issue.

Yes, I am on free tier, do we need a paid plan to use this?
Here is updated error status:

I will implement rate limit options at the UI. You have to set it according to https://platform.openai.com/docs/guides/rate-limits/free-tier-rate-limits
However, this will only scoped to per request per minute (3 as of now), if you hit the day limit, which is 200, you have wait for the next day.

Thank you for your kind and quick response. If I understand correctly, I have to wait for you to implement this "rate limit option selection in the UI".
Please ping me here when you updated it. I will retry again.
Also, it would be great to document this in the README for the end-users like me to avoid future issues.

@stulluk Implemented rate limit controls at UI. You can set it to the lowest value 1 and turn off moderator.
If you still hit quota error, you may have hit the RPD, which you have wait for next day.

@Cerlancism

Would it be possible for you to create a free account like me and try to translate above SRT file that I shared above ?

I just took a closer look at your screenshot at
https://github.com/Cerlancism/chatgpt-subtitle-translator/issues/15#issuecomment-1925201128
Unfortunately your free credits already expired last year at Apr 01 2023. You have to use a paid plan now.

@Cerlancism  thank you for clarifying. we can close the issue then.

 Thanks for trying out the application.


Add metrics for I/O

Bytes written and bytes read from disk. The OS page cache will absorb some, but we could measure the # of read() and write() system calls and number of bytes. That would allow collecting those metrics easily from automated performance tests.

The need for this came up in discussions on Discord #dev channel, see thread "pgbench -s100 -i" (I don't know how to create a link  to that).


Last digit of card number got deleted automatically.

Hi,
Thanks for your work.
The input formatting seems automatically removing the last digit in card number with the white space. It also happens to expiry input.
<input name="number" type="tel" v-model="cardDetails.number" v-card-focus>
<input name="expiry" type="tel" v-model="cardDetails.expiry" v-card-focus>

I recorded a gif for this issue, during the input I did not touch backspace key:

Hi @xhkz,
Thanks for reporting this bug. You described the problem well.


onSelectionChanged value issue

Thanks a lot to your package.
I have written the code as below.
It works fine to select 1 specific item, and then deselect it again.
But what I want is,
When the user selects the 'cancel all' button, all selected item chips will be deselected.
However, in the code below, pressing the 'all cancel' button only causes the 'all cancel' item to be selected.
What if I want one specific button to deselect all the other buttons?
MultiSelectDialog(
                              initialValue: _eduableRegionSelectedList ?? [],
                              title: Text('eduableRegion',
                                  style: DGThemes.dgTextTheme.subtitle1),
                              confirmText: Text('ok',
                                  style: DGThemes.dgTextTheme.overline
                                      ?.copyWith(color: DGColors.primaryColor)),
                              cancelText: Text('no',
                                  style: DGThemes.dgTextTheme.overline),
                              selectedColor: DGColors.primaryColor,
                              selectedItemsTextStyle: DGThemes
                                  .dgTextTheme.bodyText2
                                  ?.copyWith(color: Colors.white),
                              itemsTextStyle: DGThemes.dgTextTheme.bodyText2,
                              items: siDoMulti
                                  .map(((region) =>
                                      MultiSelectItem(region, region))))
                                  .toList(),

                              onSelectionChanged: (v) {
                                if (v.contains('all cancel') == true) {
                                  v.clear();
                                  setState(() {});
                                }
                              setState(() {});}

Hi @Faamica Did you find an answer to this? Even I am looking for something like this.

Hi @Faamica Did you find an answer to this? Even I am looking for something like this.

nope. I don't know how to solve this.


misc spelling is wrong

https://github.com/deepmipt/dialog_flow_engine/blob/94f1ec4c88b8f33f1bf318a1bb84fef197829514/df_engine/core/context.py#L202

This spelling is corrected in 26a18c0 commit and pushed into dev


Prefill form with existing bookmark information

Using the extension, I often find myself wondering if a bookmark already exists or not in order to not mistakenly override any of the metadata already saved.
To find out if that's the case, I either have to search using the omnibox or linkding itself. Neither are perfect for that purpose as they don't indicate if the URL is an exact match and they each require multiple steps.
This PR is about prefilling the form with the information already existing in linkding if there is any exact URL match.

Thanks @sissbruecker!
I never use linkding's form so I didn't think to check it 😅
I'll take another stab at it to try and mirror the existing behavior 👍

Closing this PR for now as I haven't taken the time to work on it for a while and I don't want to bog down the project

it takes a long time (more than 10 sec) to prefill these information, is this normal? @sissbruecker


Console notification

Are you aware of this line in the console:
23.12 18:57:10 [Server] INFO BMM >> You are running a beta version. Bugs may appear!
Is isnt in beta anymore right?

I'm also experiencing this issue on BMM 1.6.3 Paper

Fixed version lookup & updater in the newest commit on dev/2.0


Fix typo in repo name

Right now there is an additional zero.

Since only the PSU with the "P" suffix in its name can be remote controlled, I'd suggest to use "ka3005p" as the name for both, the repo and tool.


{VirtualWan} Expose RoutingIntent resource as child of VirtualHub

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify - Adding a new child resource under new api version

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.

When you expect to publish swagger? Please provide date, or month to public if date is not available yet.

If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[x] SDK of .NET (need service team to ensure code readiness)
[x] SDK of Python
[x] SDK of Java
[x] SDK of Js
[x] SDK of Go
[x] PowerShell
[x] CLI
[x] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Involve ARM team for review as there are new APIs defined in this PR

Please put your changes into a new PR that follows this requirement: Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently., and check the box when you submit.

Please put your changes into a new PR that follows this requirement: Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently., and check the box when you submit.

@mentat9 this PR only includes adding new APIs and not API versions, do you still need me to do the above ?

No, it's OK. But adding APIs to an existing API version should have triggered a breaking change review label. Not sure why it didn't, but I'll add the label, and you will receive instructions. If we get back here later and an API version change is needed, please be sure to follow that procedure: it's really important to help the reviewers do a good job and complete your review as quickly as possible.

@nagula-ritvika, this PR needs breaking change review since you are not adding a new API version. The instructions for that were added to the comments when the label was added. ARM review happens after breaking change review.

/azp run

@mentat9 : According to current Swagger repo 2021-03-01 has not yet been released publicly so this is not an existing API version rather it will be a new version once they roll it out. the most latest already existing version is 2021-02-01

@mentat9 : According to current Swagger repo 2021-03-01 has not yet been released publicly so this is not an existing API version rather it will be a new version once they roll it out. the most latest already existing version is 2021-02-01

Your submission questionnaire says "update existing version for new feature". Please correct the questionnaire so the automation correctly analyzes your PR.

@mentat9 : According to current Swagger repo 2021-03-01 has not yet been released publicly so this is not an existing API version rather it will be a new version once they roll it out. the most latest already existing version is 2021-02-01

Your submission questionnaire says "update existing version for new feature". Please correct the questionnaire so the automation correctly analyzes your PR.

@mentat9 i have updated the questionnaire : please take a look and sorry about the confusions

@nagula-ritvika, you will work with this week's ARM API review oncall (@pilor) to finish the ARM review.

Abandoning PR to add to latest version instead.

new P R: https://github.com/Azure/azure-rest-api-specs/pull/15998


Handle 2.3 prettier changes

Issues thanks to incompatibility of prettier 2.3 and above:
https://github.com/adamzapasnik/prettier-plugin-erb/issues/97
https://github.com/adamzapasnik/prettier-plugin-erb/issues/44
https://github.com/adamzapasnik/prettier-plugin-erb/issues/97

Here are some upgrades to 2.8.0, but still failing in tests:
https://github.com/amkisko/prettier-html-templates - all the issues are visible in tests now
https://github.com/amkisko/prettier-plugin-erb - this one is more complex due to changes in prettier and at the moment in tests it always returns 0 bytes output

@amkisko great to see this. Does it already make sense for you to share a Work-in-progress (WIP) Pull Request? Maybe in collaboration with @Juice10, who also started a similar Pull Request

@tmaier @Juice10 you are welcome:

https://github.com/adamzapasnik/prettier-html-templates/pull/56
https://github.com/adamzapasnik/prettier-plugin-erb/pull/135

It seems that there are some complex problems to solve. :)

Here are some upgrades to 2.8.0, but still failing in tests: amkisko/prettier-html-templates - all the issues are visible in tests now amkisko/prettier-plugin-erb - this one is more complex due to changes in prettier and at the moment in tests it always returns 0 bytes output

Hi @amkisko – why did you delete the amkisko/prettier-html-templates fork?
Did you give up and prettier-plugin-html-erb is the replacement?

Yes, I did.
There are few better options available:

erb-lint (which also adds support for rubocop which is very useful)
erb-formatter
rewriting https://github.com/ecmel/prettier-plugin-ejs to support erb, which I did not continue too


Code Helper (Renderer) memory leak

VSCode Version: 1.48.2
OS Version: Darwin x64 18.7.0

I was testing my c-project for leaks, and thought it would be nice to verify that the parent process of VSC-terminal shows clean result. I was confused when I saw this wasn't the case. I'm not sure if leaks command can give false positives, hope someone else can also verify this. :)
Steps to Reproduce:

Open visual studio code
Navigate to the terminal inside visual studio code
run command 'leaks $PPID'

-- OUTPUT OF LEAKS BELOW --
Path:            /Applications/Visual Studio Code.app/Contents/Frameworks/Code Helper (Renderer).app/Contents/MacOS/Code Helper (Renderer)
Load Address:    0x10da52000
Identifier:      Code Helper (Renderer)
Version:         ???
Code Type:       X86-64
Parent Process:  Electron [42776]

Date/Time:       2020-08-27 20:08:11.636 +0300
Launch Time:     2020-08-27 20:06:45.135 +0300
OS Version:      Mac OS X 10.14.6 (18G3020)
Report Version:  7
Analysis Tool:   /Applications/Xcode.app/Contents/Developer/usr/bin/leaks
Analysis Tool Version:  Xcode 11.3.1 (11C504)
----

leaks Report Version: 4.0
Process 42781: 76301 nodes malloced for 15533 KB
Process 42781: 4424 leaks for 702704 total leaked bytes.

(specific leak output continues...)

Does this issue occur when all extensions are disabled?: Yes
Additional information:
Version: 1.48.2
Commit: a0479759d6e9ea56afa657e454193f72aef85bd0
Date: 2020-08-25T10:09:08.021Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.7.0

This would be from the runtime electron , closing as its out of scope.


Do we need to remove Catena-X Logos from Documentation?

Introduction
In the review for TRGs #180 we found out that there was a remark for documentation.
We need to clarify that. It does not blocks the QG but needs to be checked for future releases.
Question:

Is it necessary that we need to remove the logos from Catena-X?

Example: https://github.com/eclipse-tractusx/digital-product-pass/blob/main/docs/catena-x-logo.svg

Hi Mathias,
thanks for the question, we will provide guidelines how to use the logo for 24.05. This has be be coordinated with Catena-X.
Until then no action is required.
@SebastianBezold

Thank you @AngelikaWittek 👍🏻
Let see what comes with the clarification.

I will close this ticket since there will be a guideline coordinated with Catena-X for the next release 24.05.

@AngelikaWittek I am confused. I was here thinking we need to add the Catena-X Logos in our headers at Tractus-X, thats a requirement from style guidelines:

Now if we are seeking for the application not do depend in an external image repository where it can be linked to the application it make really much sense to have it in our repositories...
If we have it in the repo why then not to use it in the documentation. Specially if we are part of the Catena-X Use Case Reference Implementations...

@AngelikaWittek I am confused. I was here thinking we need to add the Catena-X Logos in our headers at Tractus-X, thats a requirement from style guidelines:
Now if we are seeking for the application not do depend in an external image repository where it can be linked to the application it make really much sense to have it in our repositories... If we have it in the repo why then not to use it in the documentation. Specially if we are part of the Catena-X Use Case Reference Implementations...

@AngelikaWittek I am confused. I was here thinking we need to add the Catena-X Logos in our headers at Tractus-X, thats a requirement from style guidelines:
Now if we are seeking for the application not do depend in an external image repository where it can be linked to the application it make really much sense to have it in our repositories... If we have it in the repo why then not to use it in the documentation. Specially if we are part of the Catena-X Use Case Reference Implementations...
Final reflection from me... If it is a requirement and part of Tractus-X already why is this even a issue? Maybe a license can be added with the picture for example, that would be and idea. Like we do with the KITs.


Institutions - Enhance regulatory body dropdown

Acceptance criteria

[ ] Add a new dropdown item called "Senate, Academic Council, Education Council, and/or Program Council and Board of Governors". Define the option code as senateOrEducationCouncil.

Note

"Other" field is already being implemented in #2028

Hugh (representing business area) confirms testing was conducted on this ticket on June 29, with no issues identified. Signed-off for release to PROD


Some switch tables fail to disassemble in ARMv4a/THUMB in a GBA game

decompiling metroid fusion https://github.com/H-A-M-G-E-R/mf

In the first image, the listing shows a function at 0806e3c0, yet the decompiler shows a function at 0806de2c ; is the second one also part of your issue report?

the undefined routine at the first image is literally part of the function at the second image, this is a bug that needs to be fixed!

It would be difficult to diagnose the issue from what you have posted.
If you clear the entire function and re-disassemble it, from the top of the function, does it fix the issue?
You can also try just clearing the switching instruction to see if that helps.
Since you didn't post the version of Ghidra you are using, I assume it is 11.2.2.
Was there any analysis done in prior versions of Ghidra on this binary?
The labels on that switch stmt are unusual.  They should be prefixed with switchD.  What created that switch table?
Normally the switch table and cases have these types of labels:
switchD_0000182a::switchdataD_0000182c and switchD_0000182a::caseD_0
Can you share the bytes for that function, including and switch data with a copy/paste bytes?

I removed the code and labels from this function, manually pressed f12 on the function and...

i modified ghidra just for the if/else formatting i prefer, and the ordering of the switch cases

so every time auto analysis misses those switch tables i can just clear code bytes and re-disassemble the function by pressing f12.

So you are saying the issue fixed itself if you did the analysis from scratch on that function.  What you have above is what I'd expect to see for normal analysis.
I can't say that this will fix the issue all the time.  It does point to bad analysis/markup on this binary in the past.  I'd need to know more about the history of the analysis done on the binary (manual, automated, import, etc...) to know.
The analysis should not miss the switch table normally and then fix it from redoing the function from scratch.  If it misses it the first time, it will usually fail the second, unless this is a newer version of Ghidra and there was an issue previously.  Also switch analysis misses then fixes like this can also be caused by some other flow issue like a non-returning function that has been fixed, or some other problem on the initial analysis that has been fixed.  So redoing the function can help in these cases.
Still the switch case labeling was odd, so it doesn't seem like stock ghidra analysis made recovered that switch case.
Side note: If you are dealing with ARM code, and analysis/decompiler is a mess, it can be because BL instructions, which are normally calls, are being used by the compiler as long jumps.  It usually happens on very large functions and older compilers.  There are some scripts to correct this state.  Just be aware.


Release includes versioned and unverisoned binaries

/kind bug
What happened:
The v0.18.0 release contains ersioned and unversioned binaries as seen in the screenshow (virtctl-v0.18.0-darwin-amd64 and virtctl-dawrin, same for windows).
What you expected to happen:
Only versioned binaries
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

KubeVirt version (use virtctl version):
Kubernetes version (use kubectl version):
VM or VMI specifications:
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/remove-lifecycle rotten


Export 404s

Hello,
This is by far the best 404 checker tool.
However, on pages with loads of broken links, is there a convenient way to export all the 404 URLs somehow? Either to clipboard or excel?
Any automated way to export the 404'd URLs that CheckMyLinks picks up would make life a lot easier!

The best I've been able to do so far is:

Button to export bad links (exports to console in csv format)
Copy from console and paste into text editor
Save as .csv file
Open file in Excel

What do you think it should export (element properties etc.)?

element.getattribute(href)
element.outerHTML

Thanks,


⚠ Bofrost.be has degraded performance

In fda4699, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1051 ms

Resolved: Bofrost.be performance has improved in c035ec6.


Make sure each and every method etc has a line of docstring

Even if it's just a simple one liner that basically repeats the name of the function itself.

Even if it's just a simple one liner that basically repeats the name of the function itself.

What for? Tricial docstrings have no use. To quote PEP 257:
The one-line docstring should NOT be a "signature" reiterating the function/method parameters (which can be obtained by introspection). Don't do:
def function(a, b):
    """function(a, b) -> list"""

(see https://www.python.org/dev/peps/pep-0257/)

Oh wow: I was not familiar with this (my Sage development has drummed the opposite in to me).
So if a method has a very verbose name this would imply to not write a docstring?
(My apologies to @meatballs for requiring them on a recent doctest...)

There are no set rules, just guidelines in the PEP, but why would you consider adding a docstring if it conveys no extra information?

Mainly so that something comes up if anyone types help(<command>). Once I've written up nice documentation (so docs about strategies etc... - planning on using readthedocs), I was hoping to package this so that anyone could set up their own tournament even if they didn't want to contribute new strategies. My thinking was that each and every method should then have a docstring (that's kind of the rules with Sage dev) but if that's not necessary I would much rather prioritise adhering to guidelines. What do you think?

I've always liked this quote:

“The proper use of comments is to compensate for our failure to express our self in code”
[Clean Code: A Handbook of Agile Software Craftsmanship” Robert C. Martin]

I personally loathe the practice of polluting code with comments. It makes the code harder to navigate and understand. I find the Sage code one of the worst offenders - the ratio of comment to code in any given file must be in the order of 10:1.
There's a reasonable blog entry on the subject here: http://blog.goyello.com/2013/05/17/express-names-in-code-bad-vs-clean/
But - it's one of those areas where a project needs to define its own standards and expectations. I'm possibly at one extreme of the thinking in this area and I'm not the owner of the repository!

I find the Sage code one of the worst offenders - the ratio of comment to code in any given file must be in the order of 10:1.

Yeah I agree with that. It in fact leads to quite confusing documentation. Although in that particular instance it's because of the doctesting paradigm (which I think makes sense for the community).

But - it's one of those areas where a project needs to define its own standards and expectations. I'm possibly at one extreme of the thinking in this area and I'm not the owner of the repository!

Well I'd really like to adhere to PEP guidelines. Let's just close this issue and keep things going as they are and in general keep adhering to PEP :)
I'm certainly learning a lot as I go along so appreciate everything I am learning from you both @langner and @meatballs :)


Added Jupyter Lab to Requirements.txt

Thought I'd bring up a quick package managing question (everyone's favorite thing).
I added the newer version of jupyter (jupyterlab) to requirements.
If it was a heavier lift I'd say that all the debug tools like jupyter/jupyterlab don't need to be in the remote build, but I don't think it's too bad atm.
Also, @ghop02 did we get burned sometime in the past and decided to pin everything? I don't particularly want to sign up for us using poetry or pipenv. Just curious.
Please Check

[ ] Are the JSON schemas updated?
[ ] Are the api docs updated?
[YES] Are tests passing?

@BrettBoval we did run into a couple small version dependency issues in the past.  I generally prefer to keep requirements.txt version locked, just to minimize moving pieces for everyone, but agree for things like jupyterlab i don't have as strong of an opinion.
I continually go back and forth on pipenv/poetry (haven't actually used poetry).  It definitely seems like it could be useful. pipenv wasn't very well maintained for a while (but seems like its more active as of late?) but at the same time, feels like poetry is gaining more general support. overall /shrug haha

I pinned jupyterlab, bumped another dependency that was complaining, and added a trello card backlog to consolidate on poetry (right now we have semi-orphaned environment.yaml).


Add outputStatistics for airflow-bq integration

In addition to the current outputStatistics dataset.facet facet we need to add the same information in event.outputs.Dataset.outputFacets.outputStatistics

Fixed #151


feat(modal): bring back modal backdrop and window

This PR brings back modal's window and backdrop components previously removed in 1f34c8781dca3d371e4543917834b4846fb6a292. The good news is that we don't need that much gymnastic to load modal's content. By using a technique demonstrated here we can use regular <ng-content> and insert content synchronously.

This looks really good.  Nice work Pawel.  I really like that we can emit and trap [custom] named events.  That's really cool.

Thnx for the review @wesleycho - I've addressed / commented on your comments.