[P1] Cannot reproduce instruction training

Hey, I am trying to reproduce the instruction training mentioned in the README that takes 18 minutes and uses the ultrafeedback dataset.
I executed this command as suggested:
python train.py -task ultrafeedback \
-data_dir <your_dataset_folder_path> \
-model meta-llama/Llama-2-7b-hf \
-seed 44 -l 3;9;18;24 -r 4 -p f5+l5 -e 9 -lr 9e-4 \
-type LoreftIntervention \
-gradient_accumulation_steps 32 \
-batch_size 4 \
-eval_batch_size 2 \
--test_split test \
--use_normalized_template \
--max_length 768

I removed the data_dir parameter since I do not have any relevant dataset locally and added --output_dir my_dir for saving the output. The error that I got from running the script is that the ultrafeedback dataset could not be found in Huggingface. To fix this, I changed the task config by adding openbmb/UltraFeedback:
"ultrafeedback": {
        "train_datasets": ["openbmb/UltraFeedback"],
        "eval_datasets": ["alpaca_eval"],
        "task_prompt_template": alpaca_prompt_template,
        "trigger_tokens": "### Response:",
        "generation_args": {
            # align with https://arxiv.org/abs/2402.15179
            True: {
                "max_length": 2048,
                "do_sample": False,
            },
            False: {
                "max_length": 2048,
                "no_repeat_ngram_size": 5,
                "repetition_penalty": 1.1,
                "do_sample": False,
            }
        }
    },

The command went through, the data was downloaded, but then there is an error while building the base_input:

Traceback (most recent call last):
  File "/home/konstantina/loreft/train.py", line 460, in <module>
    main()
  File "/home/konstantina/loreft/train.py", line 456, in main
    finetune(**vars(args), args=args)
  File "/home/konstantina/loreft/train.py", line 165, in finetune
    train_dataset = ReftDataset(
  File "/home/konstantina/loreft/dataset.py", line 181, in __init__
    base_input = base_prompt + data_item["output"] + tokenizer.eos_token
KeyError: 'output'
9: command not found
18: command not found
24: command not found

The dataset.py in the error stack refers to the code in the loreft directory in the examples.
Also, I basically have the same issue when I try to run the instruct experiment. Even though the README says that everything is done via Huggingface, I get this error:
datasets.exceptions.DatasetNotFoundError: Dataset 'instruct' doesn't exist on the Hub or cannot be accessed
when I run
python train.py -task instruct \
-model meta-llama/Llama-2-7b-hf \
-seed 44 -l 3;9;18;24 -r 4 -p f5+l5 -e 9 -lr 9e-4 \
-type LoreftIntervention \
-gradient_accumulation_steps 32 \
-batch_size 4 \
-eval_batch_size 2 \
--test_split test \
--use_normalized_template \
--max_length 768
--output_dir my_dir

@konstantina-ellalab thanks for raising the issue! we updated the folder README to have clearer instructions. Please take a look:
https://github.com/stanfordnlp/pyreft/tree/main/examples/loreft
There are two changes needed based on your logs above:

You need to download our parsed version of UltraFeedback to avoid writing your own dataloader. The reason is that UltraFeedback is a pair-wise preference dataset, and we need to preprocess it to make it a SFT dataset.

To download our datasets, run this command inside our loreft folder:
bash load_datasets.sh

When you run the command, make sure you escape the string after -l 3;9;18;24. We need to provide as -l "3;9;18;24" otherwise ; is considered as a line-break which breaks the command.

We updated our README now to have this escape. You can run like:
python train.py -task ultrafeedback \
-data_dir dataset \
-model meta-llama/Llama-2-7b-hf \
-seed 42 -l "3;9;18;24" -r 4 -p f5+l5 -e 9 -lr 9e-4 \
-type LoreftIntervention \
-gradient_accumulation_steps 32 \
-batch_size 4 \
-eval_batch_size 2 \
--test_split test \
--use_normalized_template \
--max_length 768

Finally, to have that 18min run-time, you need to train with downsampled training data with 1K examples as stated in the paper and in the README. To do this, you want to provide this extra argument: --max_n_train_example 1000.
Let me know if you have other questions!

lowering the priority to P1 as I don't think any code change is needed. data loading script as well as README are updated.

@konstantina-ellalab hey, just want to follow up here. is the issue fixed by now? let me know if there are other issues! Thanks.

@frankaging thank you for the quick feedback and the fixes! I have not tested the solution yet, but I will do that soon and let you know here how it goes.

Hey @frankaging , thank you for the updated process. It worked, but there was a small issue that I resolved on my side. The ultrafeedback dataset was too big and it was not downloaded automatically with git clone, nor with wget, so I downloaded it and added it manually to the remote machine I am using.
Afterwards, the train.py worked until I got an error about wrong arguments:
nohup: ignoring input
task: ultrafeedback, model: meta-llama/Llama-2-7b-hf, intervention_type: LoreftIntervention, layers: 3;9;18;24, rank: 4, position: f5+l5, epoch: 9, train_on_inputs: False, max_length: 768, allow_cls_grad: False
loading data for dataset:  dataset/ultrafeedback

Generating train split: 0 examples [00:00, ? examples/s]
Generating train split: 29970 examples [00:00, 231082.00 examples/s]
Generating train split: 62135 examples [00:00, 271694.35 examples/s]
Generating train split: 62135 examples [00:03, 17780.39 examples/s]

  0%|          | 0/1000 [00:00<?, ?it/s]
  0%|          | 1/1000 [00:01<18:20,  1.10s/it]
  1%|          | 12/1000 [00:01<01:14, 13.32it/s]
  2%|▏         | 21/1000 [00:01<00:41, 23.86it/s]
  3%|▎         | 32/1000 [00:01<00:25, 37.84it/s]
  5%|▍         | 46/1000 [00:01<00:16, 56.88it/s]
  6%|▌         | 57/1000 [00:01<00:14, 66.05it/s]

  ..........

100%|██████████| 1000/1000 [00:07<00:00, 132.00it/s]

Downloading builder script:   0%|          | 0.00/8.10k [00:00<?, ?B/s]
Downloading builder script: 100%|██████████| 8.10k/8.10k [00:00<00:00, 23.1MB/s]

Downloading readme:   0%|          | 0.00/30.0 [00:00<?, ?B/s]
Downloading readme: 100%|██████████| 30.0/30.0 [00:00<00:00, 209kB/s]

Downloading data:   0%|          | 0.00/621k [00:00<?, ?B/s]
Downloading data: 100%|██████████| 621k/621k [00:00<00:00, 11.3MB/s]
/home/konstantina/.cache/huggingface/datasets/downloads/07bde58ae497102ab81d326d84eafcf6c2c7e8df8cd8b8d0ef64d9eceab41ada

Generating eval split: 0 examples [00:00, ? examples/s]
Generating eval split: 805 examples [00:00, 6155.66 examples/s]

  0%|          | 0/805 [00:00<?, ?it/s]
 20%|██        | 163/805 [00:00<00:00, 1623.85it/s]
 40%|████      | 326/805 [00:00<00:00, 1554.55it/s]
 60%|█████▉    | 482/805 [00:00<00:00, 1555.57it/s]
 79%|███████▉  | 638/805 [00:00<00:00, 1426.00it/s]
 97%|█████████▋| 782/805 [00:00<00:00, 1428.49it/s]
100%|██████████| 805/805 [00:00<00:00, 1475.16it/s]

config.json:   0%|          | 0.00/609 [00:00<?, ?B/s]
config.json: 100%|██████████| 609/609 [00:00<00:00, 3.05MB/s]

model.safetensors.index.json:   0%|          | 0.00/26.8k [00:00<?, ?B/s]
model.safetensors.index.json: 100%|██████████| 26.8k/26.8k [00:00<00:00, 62.7MB/s]

Downloading shards:   0%|          | 0/2 [00:00<?, ?it/s]

model-00001-of-00002.safetensors:   0%|          | 0.00/9.98G [00:00<?, ?B/s]

model-00001-of-00002.safetensors:   0%|          | 10.5M/9.98G [00:00<02:02, 81.1MB/s]

model-00001-of-00002.safetensors:   0%|          | 21.0M/9.98G [00:00<01:52, 88.6MB/s]

model-00001-of-00002.safetensors:   0%|          | 31.5M/9.98G [00:00<01:52, 88.1MB/s]

............

model-00001-of-00002.safetensors: 100%|██████████| 9.98G/9.98G [01:58<00:00, 117MB/s]
model-00001-of-00002.safetensors: 100%|██████████| 9.98G/9.98G [01:58<00:00, 84.3MB/s]

Downloading shards:  50%|█████     | 1/2 [02:42<02:42, 162.99s/it]

model-00002-of-00002.safetensors:   0%|          | 0.00/3.50G [00:00<?, ?B/s]

model-00002-of-00002.safetensors:   0%|          | 10.5M/3.50G [00:00<01:31, 38.3MB/s]

model-00002-of-00002.safetensors:   1%|          | 21.0M/3.50G [00:00<01:01, 56.8MB/s]

.............

model-00002-of-00002.safetensors: 100%|██████████| 3.50G/3.50G [00:54<00:00, 62.7MB/s]
model-00002-of-00002.safetensors: 100%|██████████| 3.50G/3.50G [00:54<00:00, 64.1MB/s]

Downloading shards: 100%|██████████| 2/2 [03:51<00:00, 107.70s/it]
Downloading shards: 100%|██████████| 2/2 [03:51<00:00, 115.99s/it]

Loading checkpoint shards:   0%|          | 0/2 [00:00<?, ?it/s]
Loading checkpoint shards:  50%|█████     | 1/2 [01:39<01:39, 99.28s/it]
Loading checkpoint shards: 100%|██████████| 2/2 [02:11<00:00, 60.08s/it]
Loading checkpoint shards: 100%|██████████| 2/2 [02:11<00:00, 65.96s/it]

generation_config.json:   0%|          | 0.00/188 [00:00<?, ?B/s]
generation_config.json: 100%|██████████| 188/188 [00:00<00:00, 1.04MB/s]

trainable intervention params: 262,176 || trainable model params: 0
model params: 6,738,415,616 || trainable%: 0.003890766241510503

  0%|          | 0/27 [00:00<?, ?it/s]Traceback (most recent call last):
  File "/home/konstantina/projects/loreft/train.py", line 460, in <module>
    main()
  File "/home/konstantina/projects/loreft/train.py", line 456, in main
    finetune(**vars(args), args=args)
  File "/home/konstantina/projects/loreft/train.py", line 356, in finetune
    trainer.train()
  File "/home/konstantina/miniconda3/envs/pyreft_test/lib/python3.10/site-packages/transformers/trainer.py", line 1780, in train
    return inner_training_loop(
  File "/home/konstantina/miniconda3/envs/pyreft_test/lib/python3.10/site-packages/transformers/trainer.py", line 2118, in _inner_training_loop
    tr_loss_step = self.training_step(model, inputs)
  File "/home/konstantina/miniconda3/envs/pyreft_test/lib/python3.10/site-packages/transformers/trainer.py", line 3028, in training_step
    model.train()
  File "/home/konstantina/miniconda3/envs/pyreft_test/lib/python3.10/site-packages/torch/nn/modules/module.py", line 2394, in train
    module.train(mode)
TypeError: IntervenableModel.train() takes 1 positional argument but 2 were given

  0%|          | 0/27 [00:00<?, ?it/s]

This was my command:
python loreft/train.py -task ultrafeedback -data_dir loreft/dataset -model meta-llama/Llama-2-7b-hf -seed 42 -l "3;9;18;24" -r 4 -p f5+l5 -e 9 -lr 9e-4 -type LoreftIntervention -gradient_accumulation_steps 32 -batch_size 4 -eval_batch_size 2 --test_split test --use_normalized_template --max_length 768 --output_dir loreft/ --max_n_train_example 1000

@konstantina-ellalab Thanks for the update!
As noted in our updated README:
https://github.com/stanfordnlp/pyreft?tab=readme-ov-file#quickstart
You need to add CUDA_VISIBLE_DEVICES=0 before your command to make sure you are running with a single GPU. We currently only support a single GPU case, and are working on multi-GPU support.

@frankaging Thanks for the suggestion. I am setting this environment variable in advance and the training works now. It took approximately 2 hours. However, the model is not saved by default. I only see two json files with evaluation results and another json file with the training config. I am training again now with the -save_model parameter and hope to be able to run inference on the saved model later on.
Could you please share a code snippet that I could use to do inference with the trained model? The instructions in the repo are updated and I am not sure what the most up-to-date inference code is at the moment. Here is what I have so far:
prompt_no_input_template = """Below is an instruction that \
describes a task. Write a response that appropriately \
completes the request.

### Instruction:
%s

### Response:
"""

device = "cuda" if torch.cuda.is_available() else "cpu"

model_name_or_path = ""
reft_model_name_or_path = ""

tokenizer = transformers.AutoTokenizer.from_pretrained(
    model_name_or_path, model_max_length=2048, padding_side="right", use_fast=False)
tokenizer.pad_token = tokenizer.unk_token
model = transformers.AutoModelForCausalLM.from_pretrained(model_name_or_path, torch_dtype=torch.bfloat16, device_map=device)

reft_model = ReftModel.load(reft_model_name_or_path, model)
reft_model.set_device(device)

instruction = "Tell me about the NLP Group at Stanford University."

# tokenize and prepare the input
prompt = prompt_no_input_template % instruction
prompt = tokenizer(prompt, return_tensors="pt").to(device)

intervention_locations = torch.tensor([get_intervention_locations(
    last_position=prompt["input_ids"].shape[-1], positions="f5+l5",
    num_interventions=len(reft_model.interventions))]).permute(1, 0, 2).tolist()

# generate
_, reft_response = reft_model.generate(
    prompt,
    unit_locations={"sources->base": (None, intervention_locations)},
    intervene_on_prompt=True, max_new_tokens=512, do_sample=False,
    no_repeat_ngram_size=5, repetition_penalty=1.1,
    eos_token_id=tokenizer.eos_token_id, early_stopping=True
)
print(tokenizer.decode(reft_response[0], skip_special_tokens=True))

@frankaging The current issue is that I am not sure how to load a reft model from the local directory. I can see that the representations are saved in bin files and I am trying to follow the main demo to load them. However, the demo assumes the reft_model is in memory already, so not sure how to combine the base model with the reft training output to create a reft_model and then use it for generation.

import torch
import transformers
import pyreft
import torch, transformers
from pyreft import (
    ReftModel
)

model_name_or_path = "yahma/llama-7b-hf"
reft_model_name_or_path = "Llama-2-7b-hf.ultrafeedback.20240419104401887890/"

prompt_no_input_template = """<s>[INST] <<SYS>>
You are a helpful assistant.
<</SYS>>

%s [/INST]
"""

model = transformers.AutoModelForCausalLM.from_pretrained(
    model_name_or_path, torch_dtype=torch.bfloat16, device_map="cuda")

# get tokenizer
tokenizer = transformers.AutoTokenizer.from_pretrained(
    model_name_or_path, model_max_length=2048,
    padding_side="right", use_fast=False)
tokenizer.pad_token = tokenizer.unk_token

# This works but the local directory is not used

reft_config = pyreft.ReftConfig(representations={
    "layer": 15, "component": "block_output",
    "low_rank_dimension": 4,
    "intervention": pyreft.LoreftIntervention(embed_dim=model.config.hidden_size,
    low_rank_dimension=4)})

reft_model = pyreft.get_reft_model(model, reft_config)

# This gives an error:

# ValueError: RepresentationConfig(layer=3, component='block_output', unit='pos', max_number_of_units=1, low_rank_dimension=4, intervention_type=None, intervention=None, subspace_partition=None, group_key=None, intervention_link_key=None, moe_key=None, source_representation=None, hidden_source_representation=None) format in our representation list is not supported.

reft_model = ReftModel(reft_config, model)
reft_model.load(load_directory=reft_model_name_or_path, model=model)

@frankaging thank you for the code and sorry for the late reply. I am not able to test this at the moment, but it looks good, so I will close the ticket and come back if necessary. Thanks!


Update theme.css

Fixing #18 — only worry with merging it is for people that are using a live version of the css theme will see changes without knowing why.

Hmm... this is an interesting, I think we could probably just have --font-6 be 64px? Otherwise, we could go through all of the GitHub repos that reference our CSS file

hmm... i looked through theme.hackclub.com, this new PR is the most accurate in terms of following it. but i think prior reliability is probably more important that this nuanced consistency?

yeah, this matches theme.hackclub.com. there's probably not too much usage
of hackclub.css so we could go through and PR in patches
On Wed, Aug 16, 2023 at 10:31 PM Belle @.***> wrote:

Hmm... this is an interesting, I think we could probably just have
--font-6 be 64px? Otherwise, we could go through all of the GitHub repos
that reference our CSS file
hmm... i looked through theme.hackclub.com, this new PR is the most
accurate in terms of following it. but i think prior reliability is
probably more important that this nuanced consistency?
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/css/pull/19#issuecomment-1681639765, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJP3VRGN7MLTTIUSTVUA4QLXVWUDBANCNFSM6AAAAAA3TQATNU
.
You are receiving this because your review was requested.Message ID:
@.***>

i think this may have taken down the website!
https://css.hackclub.com/

this is bizarre... but yes it did

Looks like a Vercel config issue that was only came it effect with new deployments. Fixed!

The minified files are 404ing. Links here
https://dash.hackathons.hackclub.com/hackathons/submissions/new is currently using the minified versions

ack, thank you!


Packages should only be released if they will install successfully

Test installing a package that is about to be released before publishing to the package manager to ensure that, among other things, dependencies within the same service are all published. The test should run in isolation so that dependencies from the same service are only available if they are already published to the package manager.

This is already completed with a new step added in release step to install package in an isolated env by referring all dependents from npm. #16232


Downgrade required Elixir version

I'm gonna to update the nix equivalents before merging, but otherwise looks good :+1:
Thank you!


Update to embedded-hal 1.0.

Please do not remove DynamicOneShot. It is a useful trait asked for by the community.

From reading https://github.com/eldruin/ads1x1x-rs/issues/10#issuecomment-890776015, it looks like this trait didn't actually solve the issue, which is why I removed it.

Why did you remove the whole device-specific channel selection mechanism? That ensures that only valid channels for the current device can be read.

Ah, I missed that this ensures only valid channels. I simply removed it since there is no corresponding embedded-hal 1.0 trait to base this on.

@eldruin, I have now re-added the device-specific channel selection.


.NET SDK Not Recognized

Description
I have seen the posts about the same issue where you load a solution and the projects won't load and there is a problem with the SDKs but my where.exe dotnet only brings up:
C:\Program Files\dotnet\dotnet.exe
Does anyone have a solution for this version of the problem?
Thank You!

Configuration

Regression?

Other information

As I mentioned at https://github.com/dotnet/core/issues/5962#issuecomment-1883776011
can you confirm what is the architecture of your Windows machine and can you share the results of dotnet --info?

 And when you run a SDK command, you're getting the SDK not found message then @cdupuisKR? Or what kind of error you're getting when you load the project? Is it on VS or VS Code?
@baronfel any suggestions?

Nothing jumps out to me as wrong from the dotnet --info output. I'd echo @mairaw's questions here - does a command-line build of your project work @cdupuisKR? Is the problem surfacing only in VS/VSCode?

What version of VS are you using? Have you finished the upgrade and is giving you an error when you load the upgraded solution?
Can you run simple SDK commands on the console? For example, can you create a new console project using the command prompt using dotnet new console?

I'm using the most up to date VS 17.8.3. I opened the original solution that I have brought up in VS 17 before and then it gave all these update errors. Now I get that my projects won't load in both the updated solution and the backup solution before the update. I just ran dotnet new console in the command prompt and gave me this:
The template "Console App" was created successfully.
Processing post-creation actions...
Restoring C:\Users\cdupuis\cdupuis.csproj:
Determining projects to restore...
Restored C:\Users\cdupuis\cdupuis.csproj (in 69 ms).
Restore succeeded.

I have also tried reverting back to VS 17.7 and VS 16.11 and the same error comes up.

Ok, so the SDK is running fine on your machine. Seems to be a problem with Visual Studio then. I still don't know which errors you're seeing in VS. But I'd recommend that you report the bug through VS so it can go to the right team. On the main menu, select Help > Send Feedback > Report a Problem.

Okay thank you!

Sorry one last try! Visual Studio support takes a long time to respond. I recreated opening the solution for the first time and have attached the errors it gives me. Not sure you can help me but worth a try!

Hi @cdupuisKR - can you report this on Developer Community? Providing repro steps and a recording with your ticket should give us enough information to fully investigate.
If you've already done this, please include a link to the feedback.

Here is the link to the developer community:
https://developercommunity.visualstudio.com/t/NET-Solutions-Not-Opening-Properly/10555085

Most of the post on the developer community were put as private if you need help accessing I can send some screen shots.

We can see the private messages and images when logged in with the Microsoft credentials. Thank you!


Error when drag off the end of the slider

If you drag the handle off the end of the slider then mouse up you get error:
Uncaught TypeError: Cannot read properties of null (reading 'classList')
    at slider.js:1:37515

Nevermind, this was actually due to the slider being inside a modal, and when you dragged outside the modal it was causing the modal to close.  (slider no longer existed in the DOM so error...)


[WFLY-14104] Upgrade EE 9 Security and JSP API jars to final versions

https://issues.redhat.com/browse/WFLY-14104

EE 9 run: https://ci.wildfly.org/viewLog.html?buildId=230644&tab=buildResultsDiv&buildTypeId=WF_Ee9LinuxJdk8


5pm 1 - Add bootstrap Accordion wrapper to JSONPrettyCard

This PR adds Bootstrap's Accordion element to wrap the JSONPretty and create a hide/show interface for the user. These changes also include a new test file for the JSONPrettyCard card and converts JSONPrettyCard to a functional component

It works pretty good when I deploy it on heroku and great job. The courseJSON is hidden and after clicking it will show to the users which satisfies to all Acceptance Criteria. One thing I am wondering is that from the detailed description of issue I find that we can click something (either text, or a button, or an icon) to show the courseJSON but now actually I take time to figure out that I can click the courseJSON to display. Moreover, it seems that you did not follow the Implementation Todos which is to add a "story" into the story directory for the JSONPrettyPanel component, and developing the new functionality there. Once it is working in the storybook, then see if it works in the regular app. I am not sure which one Prof.Conrad or other teaching assistants prefer so it might be better to confirm that.

Thanks for reviewing. Yeah I spoke with Andrew and he said it was fine since we had already implemented it outside of storybook. Plus, this Accordion component is from bootstrap so, in my opinion, it doesn't belong in storybook.

Can you add a description for this PR?

Can you add a description for this PR?

Done


sorting the file names

This extension is an awesome idea. Thanks!
Feature Request:
Would love to be able to sort the file names within a working set.
Either by drag-n-drop or alphabetically.

Thank you, @hobbyman!
This is one of the things I thought about adding, but didn't make the cut for the initial release. I'll add it for sure in the near future 👍. I'll keep this issue open and update it once it's done.

+1 for this feature.

I'm working on this, should have a new version out there some time tomorrow.


Footer view component [DS-11]

Background
https://citizensadvice.atlassian.net/browse/DS-11
Changes
Adds view component version of the footer component.
Uses slots to handle link columns. Limits to four columns.
TODO:

[x] Add component previews to help define slots API
[x] Add component definition and template
[x] Add rspec scenarios
[x] Generate example files
[x] Update functional tests to remove welsh language scenarios
[x] Add usage documentation
[x] Remove old haml files

(Shotgun not implementing it on public website... oh).

😅  I did a dry-run for public advice and it's pretty simple. Thankfully the renders_many DSL is pretty flexible and supports both passing an array to columns or single items to column. Ended up with something like the following:
def public_website_footer_nav_links
  [
    {
      title: I18n.t("footer_links.resources_and_tools_title"),
      links: I18n.t("footer_links.resources_and_tools_links")
    },
    {
      title: I18n.t("footer_links.more_from_us_title"),
      links: I18n.t("footer_links.more_from_us_links")
    },
    ....
  ]
end

and:
= render CitizensAdviceComponents::Footer.new(feedback_url: public_website_feedback_url, homepage_url: homepage_url) do |c|
      = c.columns(public_website_footer_nav_links)


[Flutter module in iOS app] Building for iOS Simulator, but the linked and embedded framework 'App.framework' was built for iOS.

Steps to Reproduce
Similar to issue https://github.com/flutter/flutter/issues/50568 but regards flutter module imported into an existing iOS native application.

Create a plain single page iOS application.
Follow the instructions here for creating flutter module and importing it into the iOS app created in step 1.
Try to build iOS project.

When using option B with --xcframework --no-universal error message is While building for iOS Simulator, no library for this platform was found in 'App.xcframework'.
flutter doctor -v
[✓] Flutter (Channel dev, v1.18.0, on Mac OS X 10.15.3 19D76, locale en-GB)
    • Flutter version 1.18.0 at /Users/user/development/flutter
    • Framework revision 14f3a36aba (3 days ago), 2020-04-03 17:06:01 -0700
    • Engine revision 09bc1fc45e
    • Dart version 2.8.0 (build 2.8.0-dev.20.0 e736495eb7)
...
[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.1
....
[✓] Connected device (3 available)
    • iPhone 11 Pro Max • 9056AB1A-B0F1-4E98-8DF2-603A7FD5410A • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)
    • Chrome            • chrome                               • web-javascript • Google Chrome 80.0.3987.163
    • Web Server        • web-server                           • web-javascript • Flutter Tools

• No issues found!

Hi @mbaleczny
Xcode 11.4 made some changes to the way frameworks are linked. New projects created with your version of flutter should support 11.4, alternatively you can try manually migrating your Xcode project using the guide here: https://flutter.dev/docs/development/ios-project-migration
I was able to manually upgrade my project using these steps and the issue was resolved.

@mbaleczny does it help?

@danspano Should everything be removed in Other Linker Flags or should '$(inherited) -framework Flutter' be added ?

@mbaleczny does it help?

No, it did not.
It looks like XCode 11.4 migration guide https://flutter.dev/docs/development/ios-project-migration is for flutter project, not flutter module. Tried to make use of it as much as possible, though.
Did anybody follow steps to reproduce?

@danspano Should everything be removed in Other Linker Flags or should '$(inherited) -framework Flutter' be added ?

@aburcheri you may have other existing linker flags. It's fine to leave these, just make sure '$(inherited) -framework Flutter' are in the list. I already had these in my linker flags along with some others, so I didn't need to add them again.

Hi @mbaleczny
Xcode 11.4 made some changes to the way frameworks are linked. New projects created with your version of flutter should support 11.4, alternatively you can try manually migrating your Xcode project using the guide here: https://flutter.dev/docs/development/ios-project-migration
I was able to manually upgrade my project using these steps and the issue was resolved.

This worked for me

i used flutter build ios-framework and met similar issue.

I solved my issue. It was quite simple - I followed the tip instruction on the bottom of the section Embed the frameworks 🤦
I created PR to flutter website repo with minor changes so the solution to this will be more obvious for others.
@minhthong095 I can see that you don't have CocoaPods installed. Try to run sudo gem install cocoapods in the <project_dir>/.ios or <project_dir>/ios/ (if it's a flutter module project or regular flutter project respectively).
If this helps you I think we can close this issue.
Thank you, everyone!

I solved my issue. It was quite simple - I followed the tip instruction on the bottom of the section Embed the frameworks 🤦
I created PR to flutter website repo with minor changes so the solution to this will be more obvious for others.
@minhthong095 I can see that you don't have CocoaPods installed. Try to run sudo gem install cocoapods in the <project_dir>/.ios or <project_dir>/ios/ (if it's a flutter module project or regular flutter project respectively).
If this helps you I think we can close this issue.
Thank you, everyone!

Just to be 100% clear, running install cocoa pods in the project directory will fix the need to follow the guide:
https://flutter.dev/docs/development/ios-project-migration
And it should run fine automatically?

No. Please, see my updated answer above.
I was referring to @minhthong095 's issue.
Again, the solution to my issue is the following tip on the bottom of the section Embed the frameworks. The reason why it works is that iOS Simulator needs Debug version of the Flutter framework.

@mbaleczny
I'm glad that it's solved,
given your last message I feel safe to close this issue,
if you disagree please write in the comments and I will reopen it.
Thank you


Added PhysicalKey handling for Android

What does the pull request do?
This PR populates the KeyEventArgs.PhysicalKey (recently added in #12549) for the Android platform.
What is the current behavior?
PhysicalKey is always None on Android.
What is the updated/expected behavior with this PR?
PhysicalKey has a correct value, mapped from the key scan code.
The KeySymbol on Android is also fixed to match the other platforms (it always applied the shift modifier before).
Fixed issues

Fixes #12991

You can test this PR using the following package version. 11.0.999-cibuild0039919-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]


Can refactor

[ ] Use echo as example or at least as test

How about using bxcan crate?

How about using bxcan crate?

This will be pretty much superseded by #207


Impossible to copy code from website?

Is this a joke? Can't copy from website - the window is closed immediately!!!

Why would you think it is a joke?  =/
What browser are you using? With all the browsers i tested it works fine.
Can you please tell me more about the situation, how you are trying to use it, and what is going on?
Thanks

Chromium Version 57.0.2987.98
After click in modal it closes.

Just tested im Firefox - modal even don't open)) That's a joke for sure. I don't know how you testing this, dude.

i think you should work on your manners!!!

Lol.

I think you should smoke weed less, then you will be able to adequately measure social situations.

As you can see, Spinners is a work in progress!
It is something i do on my free time, just for the fun of it.
I don't appreciate your tone. It doesn't seem that you really understand the idea behind github.
Starting an issue with "is this a joke" isn't a good idea! Calling people "idiots" is even a worst idea!
Thank you for telling me about the issue, i'll look into it when i have the time!

OK, sorry, I am rude sometimes. Anyway, 'active' class is removing when I click anywhere in modal. In FF it even doesn't shows up. Ubuntu 16.04, but I assume it can't be the issue.

thanks, i'll look into it when i have a chance.


Fix a compatibility issue with Swift 6.0 and main snapshots

It doesn't seem that projects depending on Foundation can be cross-compiled with 6.0 Swift SDKs (`error: missing required module '_FoundationCShims'), but at least the generation process completes successfully.

cc @euanh, looks like you're not in the new contributors team after swiftlang migration, I'm trying to fix that one

@swift-ci test


add github action to build images

How to use
This action follows the standard in https://github.com/kartoza/prj.app
In the repository settings, create 3 new Repository secrets (currently I have no access to the settings page):
DOCKERHUB_REPO=kartoza
DOCKERHUB_USERNAME=dockerkartozabot
DOCKERHUB_PASSWORD=<get it from Kartoza secret document>

The image will be built automatically on branch push (currently activated for main branch). Resulting tag will be something like kartoza/hugo-watcher:main
The image will be autobuild on Git Tagging/Release, as long as the tag follow Semver convention https://semver.org. The resulting tag will be kartoza/hugo-watcher:{{tag}}
The image will be autobuild on internal PR (same branch in the same repo, due to the security restriction for the secrets), so that it can be tried before merging. The resulting tag will be like kartoza/hugo-watcher:pr-1
The image can be custom build, for specific tag. Create the git tag first, then execute the release-build action manually and specify the tag name. The docker image will use the same tag.

close https://github.com/kartoza/kartoza/issues/712

Awesome, thanks so much @lucernae ! I have set up the secrets.


Can't render a route when i use Provider and KeepAlive at first time!

I've got the same issue, did you solve it?

same issue


WSL needs to understand && and ||

Migrated from https://bugs.webkit.org/show_bug.cgi?id=177062:
At 2017-09-18T01:29:02Z<EMAIL_ADDRESS>wrote:
WSL needs to understand && and ||

At 2017-09-18T03:00:28Z<EMAIL_ADDRESS>wrote:
Comment on attachment 321060
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=321060&action=review

Tools/WebGPUShadingLanguageRI/Evaluator.js:175

   case "&&":

Nice. I like that you’re just using the operator itself.

At 2017-09-18T01:30:10Z<EMAIL_ADDRESS>wrote:
Created attachment 321060
Patch

At 2017-09-18T03:39:23Z<EMAIL_ADDRESS>wrote:
Comment on attachment 321060
Patch
Clearing flags on attachment: 321060
Committed r222139: http://trac.webkit.org/changeset/222139

At 2017-09-18T03:39:25Z<EMAIL_ADDRESS>wrote:
All reviewed patches have been landed.  Closing bug.

At 2017-09-27T19:29:29Z<EMAIL_ADDRESS>wrote:
rdar://problem/34693373


[BUG][Functional] Root user cannot remove MFA device

Required Basic Info

Accelerator Version:  v1.5.5
Install Type: Upgrade
Upgrade from version: v1.5.4-a

Describe the bug
The root user of accounts in the Sensitive OU is not able to remove MFA devices
Failure Info

What error messages have you identified, if any:  User: arn:aws:iam::<account_id>:root is not authorized to perform: iam:DeactivateMFADevice on resource: * with an explicit deny in a service control policy

What symptoms have you identified, if any: Root user cannot remove existing MFA devices

Steps To Reproduce

Sign in to the AWS console using a root user account
Select "Security Credentials" from the account menu in the top right hand corner
In the MFA section select the device you'd like to remove and click the "remove" button
You will be presented with a generic error message.  Running the browser in debug mode will reveal the response message indicating that iam:DeactivateMFADevice permissions are missing.

Expected behavior
The root user has the permissions required to add, remove and resync MFA devices.
Additional context
The issue appears to exist within the ASEA-Guardrails-Sensitive.json SCP:
{
      "Sid": "ROOT",
      "Effect": "Deny",
      "NotAction": [
        "iam:CreateVirtualMFADevice",
        "iam:EnableMFADevice",
        "iam:GetUser",
        "iam:ListMFADevices",
        "iam:ListVirtualMFADevices",
        "iam:ResyncMFADevice",
        "aws-portal:*",
        "sts:GetSessionToken",
        "iam:DeleteVirtualMFADevice",
        "trustedadvisor:*",
        "support:*"
      ],
      "Resource": "*",
      "Condition": {
        "ArnLike": {
          "aws:PrincipalARN": ["arn:aws:iam::*:root"]
        }
      }
}

The issue is fixed by adding "iam:DeactivateMFADevice":
{
      "Sid": "ROOT",
      "Effect": "Deny",
      "NotAction": [
        "iam:CreateVirtualMFADevice",
        "iam:EnableMFADevice",
        "iam:GetUser",
        "iam:ListMFADevices",
        "iam:ListVirtualMFADevices",
        "iam:ResyncMFADevice",
        "aws-portal:*",
        "sts:GetSessionToken",
        "iam:DeactivateMFADevice",
        "iam:DeleteVirtualMFADevice",
        "trustedadvisor:*",
        "support:*"
      ],
      "Resource": "*",
      "Condition": {
        "ArnLike": {
          "aws:PrincipalARN": ["arn:aws:iam::*:root"]
        }
      }
}

A similar issue was previously raised and fixed in Issue #686

I believe this is by design and an intended security control. We do NOT want MFA removed from the root user, ever.  BTW: root user should virtually never be used, unless it is for one of the very few required activities, and then should only be allowed via MFA. Why do you want to remove MFA on the root user?

Our team is geographically dispersed and does not share the same secure physical location where a single key can be stored.  When several of our accounts were initially setup the usage of a virtual MFA token was used to provide a primary and secondary administrator with MFA access.  Now that IAM provides the ability to assign multiple hardware MFA devices we've switched to hardware tokens to align with the ASEA best practices.  I would now like to remove the obsolete virtual MFA tokens that have been replaced by hardware devices.
The existing ASEA-Guardrails-Sensitive policy does already include iam:DeleteVirtualMFADevice permissions but unfortunately iam:DeactivateMFADevice is also required in order to remove a virtual MFA device.  I agree that removing an MFA token isn't something we'd typically like to occur and perhaps my issue in an edge case.
One workaround to the issue could be to to temporarily define a custom override SCP with the missing permission so that the obsolete devices can be removed.

Did not implement


pallet-evm: add support for transaction-level create2

This allows CREATE2 to be directly called as transactions. Previously this must be done through factory contracts.

Is it possible to start writing tests for the EVM pallet?

@shawntabrizi Let me do it in a separate PR.


Fix when telegram provides empty updates(?)

In my case, got failed bot when update.message where undefined and could not read property chat of undefined.

According to #28, #25 should correctly prevent bot from acquiring edited messaged.


Starting deadline seconds

Adds the starting-deadline-seconds property to the cron trait.
resolves https://github.com/apache/camel-k/issues/2330

Release Note
NONE

@astefanutti Done: https://github.com/apache/camel-k/pull/2342/commits/56e20964e29f65f3178622c2a7035cb8059bee30

@zach-robinson thanks. Could you please remove the docs/modules/ROOT/pages/apis/crds-html.adoc file from the changes? It's not related to this PR. Thanks.

@astefanutti Done.

@zach-robinson thanks, I've started CI and we'll merge it once it has completed.

Thanks.


Dev2

Triggered pipeline to build and deploy your code. You can track progres here

Your app is deployed at launch-142.southindia.azurecontainer.io


service that emits "info" event for all known nodes

Is your feature request related to a problem? Please describe.
Problem:  I have 30-40 nodes, but only 4-5 different types of devices.  So, like 10 of the same brand/model dimmer switch.  I want to consistently configure them, however, I have no programatic way to get the current list of node IDs for all my dimmer switches.  This means I have to maintain a list of ever-changing node IDs (included/excluded/factory resets all change the node ID)
Describe the solution you'd like
I'd like a Zwave Service that triggers the hub to emit a Notification event for every node it knows about.
The Info Notification event would include

similar things to the current Notification event (which can uniquely identify the node)
additional information so that I can identify which type of device it is.
-- Something like "Product" or "Product Code" (from the zwave control panel UI) would work.  Or, if those things translate to a unique "device type identifier" that would work too. Anything such that I can then turn around and send different set_config_parameters to different types of nodes.
including firmware version would probably be good too, because who knows parameter numbers might change?

All this data is available in the UI.
Describe alternatives you've considered
Maintaining a list of ever changing node IDs gets old
Additional context
If this endpoint existed I think building a flow in Node-Red would be pretty straight forward:

Trigger new Service
Listen for new Info events and then call set_config_parameter as many times I as I want for each different node type.

Cheers! Thanks!

I don't see the benefit of adding another way to expose this. Especially since events are meant for things that happen. All the information is available via the ZWaveNode class:

unique IDs -> https://zwave-js.github.io/node-zwave-js/#/api/node?id=manufacturerid-productid-and-producttype
firmware version -> https://zwave-js.github.io/node-zwave-js/#/api/node?id=firmwareversion
model name and description (if config file exists) -> https://zwave-js.github.io/node-zwave-js/#/api/node?id=deviceconfig


How about the server?

I've downloaded the android version and tried the game, and it's fine:) But Multiplayer mode is not working for me. I don't know if it's a network problem(I'm in China, Chinese network has a firewall which blocks google,fb and something else xD) or ur server has down. So why not let players ourselves to create our own servers? This would actually make this okd game live longer.

The game server is running fine. The server uses Google App Engine, so if your firewall blocks Google services, then that's probably why you are unable to access multiplayer.

Got it. And I've seen the instruction to create a server, though I need to compile the whole game again. Closing issue.


[nrf fromlist] mgmt/mcumgr: Add Kconfig option for direct image ...

... upload
The commit adds CONFIG_IMG_MGMT_DIRECT_IMAGE_UPLOAD that allows
to turn on the direct image upload.
Upstream PR: https://github.com/zephyrproject-rtos/zephyr/pull/37920
Signed-off-by: Dominik Ermel<EMAIL_ADDRESS>

Merged to https://github.com/nrfconnect/sdk-zephyr/pull/587


Invalid graph when converting TFBertForSequenceClassification

Are text classifiaction huggingface models supported? I'm getting invalid graph when running this:
import os
from transformers import TFBertForSequenceClassification
import keras2onnx
model_keras = TFBertForSequenceClassification.from_pretrained('bert-base-cased')
model_onnx = keras2onnx.convert_keras(model_keras, model_keras.name)

import psutil
import onnxruntime
os.environ["OMP_NUM_THREADS"] = str(psutil.cpu_count(logical=True))
os.environ["OMP_WAIT_POLICY"] = 'ACTIVE'

sess_options = onnxruntime.SessionOptions()
session = onnxruntime.InferenceSession(model_onnx.SerializeToString(), sess_options)

All model checkpoint layers were used when initializing TFBertForSequenceClassification.

Some layers of TFBertForSequenceClassification were not initialized from the model checkpoint at bert-base-cased and are newly initialized: ['classifier']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.
tf executing eager_mode: True
tf.keras model eager_mode: False
WARNING:tensorflow:The parameters `output_attentions`, `output_hidden_states` and `use_cache` cannot be updated when calling a model.They have to be set to True/False in the config object (i.e.: `config=XConfig.from_pretrained('name', output_attentions=True)`).
WARNING:tensorflow:The parameter `return_dict` cannot be set in graph mode and will always be set to `True`.
The ONNX operator number change on the optimization: 2428 -> 1618
Traceback (most recent call last):
  File "convert_example.py", line 16, in <module>
    session = onnxruntime.InferenceSession(model_onnx.SerializeToString(), sess_options)
  File "/work/jzaragoza/bicleaner-neural/venv/lib/python3.7/site-packages/onnxruntime/capi/onnxruntime_inference_collection.py", line 280, in __init__
    self._create_inference_session(providers, provider_options)
  File "/work/jzaragoza/bicleaner-neural/venv/lib/python3.7/site-packages/onnxruntime/capi/onnxruntime_inference_collection.py", line 309, in _create_inference_session
    sess = C.InferenceSession(session_options, self._model_bytes, False, self._read_config_from_model)
onnxruntime.capi.onnxruntime_pybind11_state.InvalidGraph: [ONNXRuntimeError] : 10 : INVALID_GRAPH : This is an invalid model. Error in Node:tf_bert_for_sequence_classification/bert/Shape:0_squeeze : Unrecognized attribute: axes for operator Squeeze

Sorry, forgot the versions.
keras2onnx==1.7.0
onnx==1.9.0
onnxconverter-common==1.8.1
onnxruntime==1.7.0
tensorflow==2.3.2
transformers==4.4.2

Try this converter, it has worked for me: https://github.com/onnx/onnxmltools . Although you should take into account that I used tensorflow 2.2 for training the model so make this adjustment also.

Yeah, I tried tf2onnx (which seems to be wrapped in that tool) and it worked.


Mark analyser package as a development-only dependency.

Without this change, packages built from projects will include RefactoringEssentials as a dependency of their package.

The nuspecs are generated from the .tt files

Oops! Sorry, should have spotted that. Will fix that up.

For our later reference: https://docs.nuget.org/Release-Notes/NuGet-2.7#development-only-dependencies

Thx!


Fix nondeterministic behaviour in H5PYDataset

This should fix the broken build on master branch.

Merging, coverage drop notwithstanding.


Capture metaprojects in binlog (#3402)

Getting hit with endless merge conflicts trying to merge upstream changes into #3459, this is identical to those commits squashed.

I just did this locally to see if that test passed, I was going to force push that to your other branch :) This is good though, thanks! With the rebase/merge it passed locally for me.

FYI I pushed a quick change to move the check for MSBuildEmitSolution to the shared Traits class.


Auto CIDR implementation

Tested this locally, seems to work wonderfully

In the future I think this would make sense as two different PRs (and each with their own ticket or liked to a shared ticket). Second commit LGTM, give it a test locally if you can and let's ship it.


Update installed spigot

The server logs tell us that the version of spigot contained in the image is out of date.
Could it be updated and a new one pushed to docker hub?
Thanks a lot!
This image is great!
*** Error, this build is outdated ***
*** Please download a new build as per instructions from https://www.spigotmc.org/go/outdated-spigot ***
*** Server will start in 20 seconds ***
Loading libraries, please wait...
[21:44:55] [Server thread/INFO]: Starting minecraft server version 1.15.2
[21:44:56] [Server thread/INFO]: Loading properties
[21:44:57] [Server thread/INFO]: This server is running CraftBukkit version git-Spigot-800b93f-8160e29 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)

We're at the mercy of how quickly https://getbukkit.org/ provides new builds or you can add -e BUILD_FROM_SOURCE=true to build an up to date copy...however, it takes a long time to build.

Thanks!


URL in Troubleshoot.md results in a 404 Page

Create issues related to the winget.exe client here

Brief description of your issue

Clicking on the manifest documentation link in Troubleshoot.md results in a page which is not found
Steps to reproduce
Click on the aforementioned link

Expected behavior
The link will take you to a valid manifest specification

Actual behavior
The link results in a 404 page

Environment
N/A

I will submit a PR to resolve this issue

@Trenly thanks so much for filing issues on documentation, and even more thanks for submitting a PR 😊.


advanced usage example

Hi, thanks for your code.
I am not that familiar with cpp to figure out some magic going on in the header file. I have few questions about how to use it.
Once the TestMessageHandler::TransferMessageType is called, the proto data has been already mutated or am I supposed to implement there my custom mutation logic?
From within the TestMessageHandler::TransferMessageType function how can I access the max_size variable that was passed to afl_custom_fuzz ?
thanks

Hi, thanks for your question. The goal of AFLplusplus-protobuf-mutator's design is to make protobuf mutations more convenient in afl++。The library will automatically implement the mutation of protobuf, and users only need to convert the mutated proto into some more interesting data。To be more specific, the code after DEFINE_AFL_PROTO_FUZZER will be used as the function body of ProtoToDataHelper, and ProtoToDataHelper will rely on the afl_custom_post_process interface, which is provided by afl++ and does not include max_size field。However, you can create a new field for MutateHelper and save the max_size in MutateHelper during the afl_custom_fuzz , which requires a bit of code modification.

Thanks for your prompt reply.
By printing input.DebugString() within the function TestMessageHandler::TransferMessageType then I should get different  values as result of the mutations that occurred, correct?
I added that print but I always see the same values printed out.
thanks

Oh，I think it may be a problem with the corpus. Can you provide more information about it？
thanks

Sure, following is TransferMessageType function:
size_t TestMessageHandler::TransferMessageType(const Root& input, unsigned char **out_buf){

    size_t mutated_size = input.ByteSizeLong();
    uint8_t* buffer = new uint8_t[mutated_size];
    if (!input.SerializeToArray(buffer, mutated_size)) {
        cerr << "Failed to write input." << endl;
        return -1;
    }
    *out_buf = buffer;
    return mutated_size;
}

Then, the harness is as following:
int main(int argc, char *argv[])
{
    Root output;
    char str[100]={};
    int *ptr = NULL;
    fstream iinput(argv[1], ios::in | ios::binary);
    if (!iinput) {
      cout << argv[1] << ": File not found.  Creating a new file." << endl;
			return -1;
    } else if (!output.ParseFromIstream(&iinput)) {
      cerr << "Failed to parse." << endl;
      return -1;
    }
	int val = output.test();
	fprintf(stdout,"val %d\n", val);
        return 0;
}

I run the fuzzer with the following script:
AFL_DISABLE_TRIM=1 \
AFL_CUSTOM_MUTATOR_ONLY=1 \
AFL_CUSTOM_MUTATOR_LIBRARY=./build/example/libtest-fuzzer.so \
AFL_SKIP_CPUFREQ=1 \
AFL_DEBUG=1 \
AFL_KEEP_TRACES=1 \
AFL_PRINT_FILENAMES=1 \
AFL_DEBUG_CHILD=1 \
AFL_NO_UI=1 \
$FUZZHOME/AFLplusplus/afl-fuzz -i ./in -o ./out -- ./build/example/harness/harness @@

The output values printed by the harness shows a very poor entropy.
thanks

I met same problem here, I printed the output at the end of A_CustomProtoMutator, but the ouput did not change from time to time as expected.
    size_t A_CustomProtoMutator(MutateHelper *m, bool binary, unsigned char *buf, size_t buf_size,
                                unsigned char **out_buf, unsigned char *add_buf,
                                size_t add_buf_size, size_t max_size,
                                protobuf::Message* input1,
                                protobuf::Message* input2) {
        using libfuzzer::CustomProtoMutator;
        using libfuzzer::CustomProtoCrossOver;

        // (PC) probability of crossover : 0.8 (0.6~1.0)
        // (PM) probability of mutation  : 0.2
        switch (GetRandom(m->GetSeed())){
            case 1:
            case 2:{
                // 1. Realloc m.buf_ to meet length requirements and copy buf to m.buf_.
                //    In this case, We don’t need to allocate a separate outbuf for each
                //    execution of afl_custom_fuzz() but only realloc buf_ in MutateHelper.
                // 2. Mutate m.buf_ and store the length
                memcpy(m->ReallocBuf(std::max(max_size, buf_size)), buf, buf_size);
                m->SetLen(CustomProtoMutator(binary, m->GetOutBuf(), buf_size, max_size,
                                             m->GetSeed(), input1));
                break;
            }
            default:{
                // Crossover buf and add_buf and store the outbuf to m.buf_
                m->ReallocBuf(std::max(max_size, std::max(buf_size, add_buf_size)));
                m->SetLen(CustomProtoCrossOver(binary, buf, buf_size, add_buf, add_buf_size, m->GetOutBuf(),
                                               max_size,m->GetSeed(), input1, input2));
                break;
            }
        }

        *out_buf = m->GetOutBuf();
	 std::cout << "out:" << *out_buf << "\n"; // print the output, but did not change as expected
        return m->GetLen();
    }

@P1umer Could you please give some hints about this problem?
btw, I put a seed file in in dir looks like : test: 123123123, during the fuzz procedure, I think it should print various value for test, but sadly it remained as the same.

Hello, this function A_CustomProtoMutator is actually a wrapper of CustomProtoMutator, so the mutation is implemented by LPM. You can check if CustomProtoMutator is working properly.

I followed the code and finally found the reason. CustomProtoMutator will call LLVMFuzzerMutate here: https://github.com/google/libprotobuf-mutator/blob/a304ec48dcf15d942607032151f7e9ee504b5dcf/src/libfuzzer/libfuzzer_mutator.cc#L54-L56
LLVMFuzzerMutate will be linked to the actual implemention when it is running in libfuzzer, but it could not find the correct function in aflplusplus and will return 0. Therefore no mutation happens during the fuzzing.

@MatthewShao Thanks a lot for your effort! We will prepare a CL for fixing this.

Fixed in https://github.com/P1umer/AFLplusplus-protobuf-mutator/commit/af7a46022f1966333e2c43895c39a99b8c9c2d96.


RFC4648 compliant base64 encoder/decoder

This PR makes the base64 encoder/decoder RFC4648 compliant which can handle UTF-8 correctly.

CI is not triggered, not sure what I'm missing.


TechDocs: Show status of build process similar to scaffolder

Feature Suggestion

If TechDocs is configured to build docs, tell the user about the progress. Something like this
-> Fetching documentation files from source
   Generating TechDocs site
   Storing files to storage

✅ Fetching documentation files from source
-> Generating TechDocs site
   Storing files to storage

✅ Fetching documentation files from source
✅ Generating TechDocs site
-> Storing files to storage

and then docs will appear.
Possible Implementation

Scaffolder creates a new job for each scaffolding process and then fetches the job status every second. Implement the feature here in a similar way.
Or perhaps, use web sockets?
Context
As of now, if a user opens a TechDocs site and if docs are being built before it loads, there is no status of the process. Given the waiting period could be 20-60 seconds, it's good to see some status.
Might be convenient to start work after https://github.com/backstage/backstage/pull/3432 is merged.

We'll probably end up doing significant work to build a little task coordination system for the new scaffolder. Looks like that may happen during Q1. This will be required to make it scale to multiple hosts.
This task is a great idea. Maybe our t goals overlap. Let's coordinate!

@freben Awesome to hear about the step towards a better approach. I'll be happy to help and/or follow closely.

This would also be a good place to show errors in the generation process. Till now they are only outputed to the stdout of the backend process, which normal users won't have access too.

Seems to be somewhat related: #4111

Parts of this are implemented now. We have a UI that's shows build logs and errors. But there is coordination for task in multiple backend replicas or parallel requests.

Thanks @Fox32 ! The problem described in the context of this issue seems to be resolved now. I'd like to close this!


YouTube version

YouTube version at :
https://www.youtube.com/edit?o=U&ar=1&video_id=I-vajE9ZKC4

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 998197fe-077b-acee-c91c-12f074359e9e
Version Independent ID: 7542e87e-8f99-9b91-6df1-6983776ad1d2
Content: Getting Started on ASP.NET Core - Existing Database - EF Core
Content Source: entity-framework/core/get-started/aspnetcore/existing-db.md
Product: entity-framework
GitHub Login: @rowanmiller
Microsoft Alias: divega

@krchome that link is invalid. I assume you wanted to post "watch?" URL, not this one.

https://www.youtube.com/watch?v=I-vajE9ZKC4


deps: update cel_cpp to prevent antlr fetch failure

Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>Commit Message: update cel_cpp to fix https://github.com/antlr/antlr4/issues/3854.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

Hey
Would be possible to cherry-pick the updated cel_cpp to the release 1.23.1 branch?

@LithiumSR it's not easy because we can't fast forward cel_cpp. From ANTLR discussion, seems like they are going to restore the tag after all, so all might be good.


Modules

Closes #3
Some things which the original plan didn't consider:

There needs to be a difference between the main module and other modules, because the main module is never fully initialized. The main module should also never be cached, but it should still be possible for module_vars in it to be accessible.

This needs a nice rebase, and a changelog entry 🙂

Also more tests for stuff like:

Calling a function from another module
Calling a function which uses module vars from another module
Instantiating classes from a different module
etc., generally, anything that went from LoadGlobal/StoreGlobal -> LoadModuleVar/StoreModuleVar should be tested

I think that's enough tests for now


add .vscode/ to .gitignore

just to avoid everyone (using vs code or derivatives) having to do the following before making a contribution
echo .vscode/ >> .git/info/exclude

thanks so much.


Add stickyFirstColumn prop

PR to introduce a new feature where the first column can be sticky.
 <DataSheetGrid
    value={data}
    onChange={setData}
    columns={columns}
    stickyFirstColumn //  Use this to make the first column sticky
 />

https://github.com/nick-keller/react-datasheet-grid/assets/3522573/2e80807c-da68-45f6-a699-e8f2c06673c7

From what I can see on your video, the selection rectangle behaves strangely. This is a complexe task that might need a deep re-work

The only issue I see is that the selection rectangle is floating, so it doesn't behave as well as it should with the sticky column. I didn't want to invest much more time in this because first I wanted to know what you think about it, being the project's creator. If you can, test this branch to see how it is; the video can be misleading.
We are using your lib in our project; this is the only missing feature. Do you mind if I create a new NPM package with this PR? We have already tested it, and it will work for our needs.

@nick-keller @vinicoder can we stop rerendering when datasheetgrid is scrolling is that possible?


Login Issue

I have installed plandex in my windows PC, But I am unable to login

I am getting this type of error while logging in.
How can I solve this problem ?

Hey @Umang7198 I can't see your screenshot. Could you try uploading it again?

@Umang7198 closing for now, but please let me know if you're still seeing the issue and can reupload the screenshot, and I'll re-open.


How do I set mesos configurations when creating a cluster?

Hello,
I am trying to change mesos configurations. Specifically some of the ones defined here: http://mesos.apache.org/documentation/latest/configuration/
Is it possible to define these when creating the cluster using acs-engine?
Thanks,
Sasidhar.

@skasturi Changing options on DCOS is currently not supported.  PR's are welcome.


uniref90 can't download

Replace ftp://ftp.uniprot.org/pub/databases/uniprot/uniref/uniref90/uniref90.fasta.gz with https://ftp.uniprot.org/pub/databases/uniprot/uniref/uniref90/uniref90. fasta.gz solves the problem of not being able to download

Closing this issue, feel free to reopen this issue or open a new issue if this is still a problem.

The link posted on 29 Dec 2022 works for me but is very slow. In the UK I am instead using the following:
https://ftp.ebi.ac.uk/pub/databases/uniprot/uniref/uniref90/uniref90.fasta.gz

I just run into the same issue. Should the download_uniref90.sh script be updated with the new URL?

https://www.uniprot.org/help/metalink
ftp://ftp.expasy.org/databases/uniprot/current_release/uniref/uniref90/uniref90.fasta.gz
I use expasy mirror site when there is a download problem with UniProt.

I don't think there's anything the AlphaFold team can do about this, but the download of uniref90 is extremely slow. The best I can get is 200-300 KiB/s, ETA of 30-50 hours. I get 56 MiB/s for the other databases.

Have you tinkered with the aria2c settings on the download, particularly -x and -j?

Have you tinkered with the aria2c settings on the download, particularly -x and -j?

Didn't make any modification, could it be faster on your side

Yeah, I got some speed increases by increasing the max number of connections in aria2c. I think overall download was still around 10-12 hours, while it had previously taken over 20.

Fixed in https://github.com/deepmind/alphafold/commit/4bd3ff76cc51613af617f49e8179b603ee2f1576 -- I changed the UniRef90 mirror to EBI's mirror which should be ~100x faster.


Succeeded status, but the runner cannot be queried

Today, I saw a weird Succeeded for the first time, but found the pod cannot be queried against:
NAME                                       REPOSITORY                     STATUS
github-action-runner-gl5c8-zv7vh    xx/xx                  Succeeded

$ kubectl describe pod github-action-runner-gl5c8-zv7vh
Error from server (NotFound): pods "github-action-runner-gl5c8-zv7vh" not found

Can you give me the controller's log and, manifest you use?
It's hard to help you with only the resource status.

The controller has been improved in terms of reliability a lot. We seem to have never encountered this recently. I'm closing this as resolved!


Nested serialization regression between 1.8.2 and master

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Bug
I found a small regression between 1.8.2 and master that broke some tests for me -- I bisected and found that it started with 458f257dcbe4d307ad71c28a9947e30eab742131. Here's the test I used:
from typing import Optional
from pydantic import BaseModel, Field

class Model(BaseModel):
    value: Optional[str]
    nested: Optional[BaseModel]

def test_my_bug():
    assert (
        Model(value=None, nested=Model(value=None)).json(exclude_none=True)
        == '{"nested": {}}'
    )

In 1.8.2, options to json() (like exclude_none) were passed to all nested models, but in master that no longer occurs. Instead, we see:
{ "nested": { "value": null } }

In my case, I noticed this because I had two models:
class Model(BaseModel):
    value: Optional[str]

class OuterModel(Model):
    nested: Optional[Model]

    def json(self, **kwargs):
        kwargs.set_default("exclude_none", True)
        return super().json(**kwargs)

# Usage:
OuterModel(nested=Model()).json()

In 1.8.2 this was overridden json() was used on all nested models as well, but in master this is only applied to the outer model. This means that we get { "nested": { "value": null } } when previously we would've gotten { "nested": {} } like above.

I think this is the same as #3542. If not, let me know and I'll reopen

I think when I posted the bug report they were slightly different, but it looks like @PrettyWood pushed another commit to take care of this. Thanks!


[Snyk] Upgrade @angular-devkit/build-angular from 0.1102.18 to 19.0.2

Snyk has created this PR to upgrade @angular-devkit/build-angular from 0.1102.18 to 19.0.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

⚠ Warning: This PR contains major version upgrade(s), and may be a breaking change.

The recommended version is 391 versions ahead of your current version.

The recommended version was released a month ago.

Issues fixed by the recommended upgrade:

Issue
Score
Exploit Maturity

Prototype PollutionSNYK-JS-UNSETVALUE-2400660
115
No Known Exploit

Inefficient Regular Expression ComplexitySNYK-JS-MICROMATCH-6838728
115
No Known Exploit

Inefficient Regular Expression ComplexitySNYK-JS-MICROMATCH-6838728
115
No Known Exploit

Cross-site Scripting (XSS)SNYK-JS-WEBPACK-7840298
115
Proof of Concept

Incomplete List of Disallowed InputsSNYK-JS-BABELTRAVERSE-5962462
115
Proof of Concept

Improper Verification of Cryptographic SignatureSNYK-JS-ELLIPTIC-7577916
115
Proof of Concept

Improper Verification of Cryptographic SignatureSNYK-JS-ELLIPTIC-7577917
115
Proof of Concept

Improper Verification of Cryptographic SignatureSNYK-JS-ELLIPTIC-7577918
115
Proof of Concept

Asymmetric Resource Consumption (Amplification)SNYK-JS-BODYPARSER-7926860
115
No Known Exploit

Uncontrolled resource consumptionSNYK-JS-BRACES-6838727
115
Proof of Concept

Improper Verification of Cryptographic SignatureSNYK-JS-ELLIPTIC-8172694
115
No Known Exploit

Improper Verification of Cryptographic SignatureSNYK-JS-ELLIPTIC-8187303
115
Proof of Concept

Uncontrolled resource consumptionSNYK-JS-BRACES-6838727
115
Proof of Concept

Improper Verification of Cryptographic SignatureSNYK-JS-BROWSERIFYSIGN-6037026
115
No Known Exploit

Denial of Service (DoS)SNYK-JS-HTTPPROXYMIDDLEWARE-8229906
115
Proof of Concept

Prototype PollutionSNYK-JS-LOADERUTILS-3043105
115
No Known Exploit

Improper Verification of Cryptographic SignatureSNYK-JS-NODEFORGE-2430339
115
No Known Exploit

Path TraversalSNYK-JS-WEBPACKDEVMIDDLEWARE-6476555
115
Proof of Concept

Cross-site Scripting (XSS)SNYK-JS-COOKIE-8163060
115
No Known Exploit

Open RedirectSNYK-JS-EXPRESS-6474509
115
No Known Exploit

Cross-site ScriptingSNYK-JS-EXPRESS-7926867
115
No Known Exploit

Regular Expression Denial of Service (ReDoS)SNYK-JS-GLOBPARENT-1016905
115
Proof of Concept

Regular Expression Denial of Service (ReDoS)SNYK-JS-PATHTOREGEXP-8482416
115
Proof of Concept

Improper Input ValidationSNYK-JS-POSTCSS-5926692
115
No Known Exploit

Improper Input ValidationSNYK-JS-POSTCSS-5926692
115
No Known Exploit

Improper Input ValidationSNYK-JS-POSTCSS-5926692
115
No Known Exploit

Cross-site Scripting (XSS)SNYK-JS-ROLLUP-8073097
115
Proof of Concept

Regular Expression Denial of Service (ReDoS)SNYK-JS-PATHTOREGEXP-7925106
115
Proof of Concept

Improper Input ValidationSNYK-JS-NANOID-8492085
115
No Known Exploit

Open RedirectSNYK-JS-NODEFORGE-2330875
115
Proof of Concept

Prototype PollutionSNYK-JS-NODEFORGE-2331908
115
No Known Exploit

Improper Verification of Cryptographic SignatureSNYK-JS-NODEFORGE-2430337
115
No Known Exploit

Regular Expression Denial of Service (ReDoS)SNYK-JS-LOADERUTILS-3042992
115
No Known Exploit

Regular Expression Denial of Service (ReDoS)SNYK-JS-LOADERUTILS-3105943
115
No Known Exploit

Improper Verification of Cryptographic SignatureSNYK-JS-NODEFORGE-2430341
115
No Known Exploit

Cross-site Scripting (XSS)SNYK-JS-SERIALIZEJAVASCRIPT-6147607
115
Proof of Concept

Cross-site Scripting (XSS)SNYK-JS-SERIALIZEJAVASCRIPT-6147607
115
Proof of Concept

Regular Expression Denial of Service (ReDoS)SNYK-JS-TERSER-2806366
115
No Known Exploit

Cross-site ScriptingSNYK-JS-SEND-7926862
115
No Known Exploit

Cross-site ScriptingSNYK-JS-SERVESTATIC-7926865
115
No Known Exploit

Release notes

Package name: @angular-devkit/build-angular

19.0.2 - 2024-11-25
19.0.2 (2024-11-25)
@ schematics/angular

Commit
Description

skip SSR routing prompt in webcontainer

@ angular/build

Commit
Description

minimize reliance on esbuild inject to prevent code reordering

prevent errors with parameterized routes when getPrerenderParams is undefined

@ angular/ssr

Commit
Description

handle nested redirects not explicitly defined in router config

19.0.1 - 2024-11-21
19.0.1 (2024-11-21)
@ angular-devkit/build-angular

Commit
Description

use stylePreprocessorOptions

@ angular/build

Commit
Description

ensure accurate content length for server assets

use sha256 instead of sha-256 as hash algorithm name

@ angular/ssr

Commit
Description

handle baseHref that start with ./

19.0.0 - 2024-11-19
19.0.0 (2024-11-19)
@ angular/cli

Commit
Description

handle string key/value pairs, e.g. --define

recommend optional application update migration during v19 update

enable Node.js compile code cache when available

enable Node.js compile code cache when available

@ schematics/angular

Commit
Description

add option to export component as default

add option to setup new workspace or application as zoneless mode

integrate withEventReplay() in provideClientHydration for new SSR apps

update app-shell and ssr schematics to adopt new Server Rendering API

component spec with export default

don't show server routing prompt when using browser builder

enable opt-in for new @ angular/ssr feature

explicitly set standalone:false

remove declaration and sourceMap from default tsconfig

use default import for express

@ angular-devkit/schematics-cli

Commit
Description

add package manager option to blank schematic

@ angular-devkit/architect

Commit
Description

merge object options from CLI

@ angular-devkit/build-angular

Commit
Description

karma-coverage w/ app builder

karma+esbuild+watch

support karma with esbuild

bring back style tags in browser builder

fix --watch regression in karma

fix hanging terminal when browser-sync is not installed

handle basename collisions

handle main field

remove double-watch in karma

serve assets

zone.js/testing + karma + esbuild

remove deprecated browserTarget

remove Protractor builder and schematics

@ angular-devkit/core

Commit
Description

remove deprecated fileBuffer function in favor of stringToFileBuffer

@ angular/build

Commit
Description

add sass to stylePreprocessorOptions in application builder

Auto-CSP support as a part of angular.json schema

enable component stylesheet hot replacement by default

introduce outputMode option to the application builder

introduce ssr.experimentalPlatform option

set development/production condition

utilize ssr.entry during prerendering to enable access to local API routes

utilize ssr.entry in Vite dev-server when available

add missing redirect in SSR manifest

add warning when --prerendering or --app-shell are no-ops

always clear dev-server error overlay on non-error result

always record component style usage for HMR updates

avoid hashing development external component stylesheets

avoid overwriting inline style bundling additional results

check referenced files against native file paths

correctly use dev-server hmr option to control stylesheet hot replacement

disable dev-server websocket when live reload is disabled

ensure index.csr.html is always generated when prerendering or SSR are enabled

ensure accurate content size in server asset metadata

ensure SVG template URLs are considered templates with external stylesheets

Exclude known --import from execArgv when spawning workers

fully disable component style HMR in JIT mode

handle APP_BASE_HREF correctly in prerendered routes

incomplete string escaping or encoding

move lmdb to optionalDependencies

prevent prerendering of catch-all routes

relax constraints on external stylesheet component id

set ngServerMode during vite prebundling

simplify disabling server features with --no-server via command line

skip wildcard routes from being listed as prerendered routes

synchronize import/export conditions between bundler and TypeScript

update logic to support both internal and external SSR middlewares

use named export reqHandler for server.ts request handling

workaround Vite CSS ShadowDOM hot replacement

remove automatic addition of @ angular/localize/init polyfill and related warnings

@ angular/ssr

Commit
Description

add createRequestHandler and createNodeRequestHandler utilities

Add getHeaders Method to AngularAppEngine and AngularNodeAppEngine for handling pages static headers

add isMainModule function

add server routing configuration API

dynamic route resolution using Angular router

export AngularAppEngine as public API

expose writeResponseToNodeResponse and createWebRequestFromNodeRequest in public API

improve handling of aborted requests in AngularServerApp

introduce AngularNodeAppEngine API for Node.js integration

introduce new hybrid rendering API

move CommonEngine API to /node entry-point

add missing peer dependency on @ angular/platform-server

add validation to prevent use of provideServerRoutesConfig in browser context

correct route extraction and error handling

designate package as side-effect free

enable serving of prerendered pages in the App Engine

ensure wildcard RenderMode is applied when no Angular routes are defined

export RESPONSE_INIT, REQUEST, and REQUEST_CONTEXT tokens

export PrerenderFallback

improve handling of route mismatches between Angular server routes and Angular router

initialize the DI tokens with null to avoid requiring them to be set to optional

resolve bootstrap is not a function error

resolve circular dependency issue from main.server.js reference in manifest

show error when multiple routes are set with RenderMode.AppShell

support for HTTP/2 request/response handling

<img src="https://camo.githubusercontent.com/7e80a0...

:tada: Snyk checks have passed. No issues have been found so far.
:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)
:white_check_mark: license/snyk check is complete. No issues have been found. (View Details)


Draft: Test that /messages works on remote homeserver and can be backfilled properly after many batches (MSC2716)

Test that /messages works on remote homeserver and can be backfilled properly after many batches
Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716
Related to https://github.com/matrix-org/complement/pull/212
Used while developing https://github.com/matrix-org/synapse/pull/11114
Dev notes
	logrus.WithFields(logrus.Fields{
		"stack": string(debug.Stack()),
	}).Error("destroy stack")

https://dave.cheney.net/2020/03/10/go-test-v-streaming-output
https://github.com/golang/go/issues/46959#issuecomment-947881974
https://github.com/golang/go/issues/27826

@MadLittleMods what is the status of this PR? It's still marked as a Draft.

Marked as stale; this PR will be closed in 7 days if there isn't any further progress. Please re-open when you get time. Long-lived branches are fine, but long-lived PRs like this always being in Draft is not fine.


Docs: Airbyte assets in Dagster

What is it?
Right now the docs are geared towards setting up database replication via GitHub actions

Deprioritizing here
https://github.com/opensource-observer/oso/pull/1726/files


Feature Request: Darkness Rendered as Dim Light within Darkvision Radius

As I understand the 5e Darkvision rules there are three effects that happen within the Darkvision range:

Dim Light within the Darkvision range is seen as Bright Light.
Darkness within the Darkvision range is seen as Dim Light.
Darkness within the Darkvision range is seen as black and white rather than color.

The default behavior in DnD5e v.2.0.3 seems to correctly handle point 3 and partially addresses point 1, but fails to put a range limit on that effect.  Your module thankfully enforces the correct range for point 1, but point 2 is still incorrect as Darkness within range is currently displaying as Bright Light.
Below is a scene in Foundry VTT v10.288 running DnD5e v2.0.3 and using Adequate Vision v0.0.3 as the only module enabled:

By setting Vision Brightness to 1, the Dim Light area within Darkvision range looks equivalent to the Bright Light area, however the Darkness area within Darkvision range looks exactly the same.  It should look equivalent to the Dim Light area around the light.
Compared to the same scene with your module turned off, it's obviously a big improvement (no modules enabled below):

Ideally though, I'd hope for point 2 to be addressed so that things can look like this similar scene in Foundry VTT v9.280 running DnD5e v1.6.3 and using Perfect Vision v3.9.15 (plus its dependency LibWrapper v<IP_ADDRESS>) as the only modules enabled:

Things are definitely much improved in v10 with your module enabled and if you're able to get Darkness within the Darkvision range to display as Dim Light instead of Bright Light then we'll be able to have rules-accurate Darkvision for DnD5e within Foundry again!

Adequate Vision's darkvision implementation intentionally doesn't set brightness to 1 but at a compromise position of 0.75. The difference is stark in your screenshots but less so with a background.

Here's a screenshot with Vision Brightness set to 0.75 and using a cavern background that's typical of an area where Darkvision would be used.  The Dim Light provided by Darkvision's range still appears to be the same brightness as the Bright Light provided by Darkvision's range:

If I set the Vision Brightness slider to 0, the Dim Light provided by Darkvision's range much more closely matches the Dim Light provided only by the light source outside of Darkvision's range, but unfortunately the Bright Light provided by Darkvision also looks just as dim:

Is there any way your module could perhaps provide a separate setting for Vision Brightness in Darkness and Vision Brightness in Dim Light?  Or, likely simpler*, perhaps mask Vision Brightness to only apply in areas where light already exists?  Below is a mockup combining the two previous screenshots into what I imagine Adequate Darkvision could ideally provide:

That addition to Adequate Vision would bring Darkvision within range of what can be achieved in v9 with the Perfect Vision module as shown below:

( * I'm sure none of this stuff is actually simple, but I just imagine it's more work to introduce two separate Vision Brightness settings.  If it were possible though, it would give users a lot of options to customize how effective they'd like Darkvision to be. )

I can tweak the defaults a bit to get it closer, but one of the reasons why this is "adequate vision" is it's a best effort without doing some deeper hacking of V10 vision and detection modes.

I hear you.  I'm not a coder so I don't know how complex the solutions are, but I understand if they're outside this module's intended scope.  I wouldn't worry about tweaking the defaults for my sake if you're happy enough with them, because I expect I'll be staying on v9 until such time as the DnD5e system in v10 can provide Darkvision that's a bit closer to what I've been able to use in previous Foundry versions.

Closing: by the time upstream makes the necessary changes, this won't need to be addressed by the module.


[Bug]:  Fix the abnormal problem of cold volume creation

Describe the bug
Cold volume creation always encounter abonormal error message
Environment
3.2.1

@leonrayang

done: https://github.com/cubefs/cubefs/pull/1973


feat: support modify vpc peering options

Description of your changes

Fixes https://github.com/crossplane-contrib/provider-aws/issues/1462
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

The CI lint is broken following this change
pkg/controller/ec2/vpcpeeringconnection/setup.go:84:1: cyclomatic complexity 11 of func `(*custom).postObserve` is high (> 10) (gocyclo)
func (e *custom) postObserve(_ context.Context, cr *svcapitypes.VPCPeeringConnection, obj *svcsdk.DescribeVpcPeeringConnectionsOutput, obs managed.ExternalObservation, err error) (managed.ExternalObservation, error) {
^
10:57:47 [FAIL]

@r0mdau thanks i had no time but it is on my list =) if you have time it would be great to see a PR - that helps a lot


Moving CleanupNetworkIdentities to NetworkServer

NetworkClient.Shutdown cleans up client objects so NetworkServre.Shutdown should clean up server objects
depends on https://github.com/vis2k/Mirror/pull/1868

good idea


[Basic] Keep SwiftPM compatible with Swift 4.0

Depends on https://github.com/apple/swift-package-manager/pull/1521

@swift-ci please smoke test


cmd/osbuild-worker/main: fix worker "crashing" on connection issues during startup

Rationale:
When the worker can't reach composer during runtime it just retries.
When it can't reach composer on startup it "crashes" (logrus.Fatalf() terminates the worker)
With this patch the worker stays alive and retries.
This should be more reliable and faster than restarting completely.
Also for unit tests and development it's nicer to just retry.
(this is loosely connected to the tests of https://github.com/osbuild/ansible-osbuild-worker/pull/6 )

/retest

registerWorker() is done with the first request and also in workerHeartbeat(), so no need to register (and possibly crash) on startup

I removed the unrelated changes (e.g. to #4351 )
Hopefully this PR is now more readable

Main problem solved by #4357


[ACCSEC-22261] Silent approvals supported in foreground for DemoApp

Jira Ticket

ACCSEC-22261

Github Issue
n/a

Description

AppDelegate updated in order to handle Push challenges that are configured to automatically being approved against the VerifySDK.
Switch added to UI on every factor to control the capability of silently approve every challenge.
Readme updated.

Commit message

Screenshot
https://user-images.githubusercontent.com/14830877/133294470-893b7eb0-98c5-48ad-bfff-a6f3e80b34f0.MP4

Testing

[ ] Added unit tests
[ ] Ran unit tests successfully
[ ] Added documentation for public APIs and/or Wiki

Code coverage
Total coverage: 95.18%

Powered by Slather

  Generated by :no_entry_sign: Danger

Code coverage
Total coverage: 95.14%

Powered by Slather

  Generated by :no_entry_sign: Danger

Code coverage
Total coverage: 95.14%

Powered by Slather

  Generated by :no_entry_sign: Danger


Numbered lists not legible

Hey there,
just switched over and am happy to replace bullet threading with this more visual appealing option.
However I notice, that numbered lists are not very legible, especially in (default) light theme.
Could it be adjusted such that the numbers themselves instead of the background is coloured?

now that I posted, I see that especially the purple ones are not very legible. Maybe a colour change would do aswell.

I'll investigate styling them more nicely when I get a chance. In the meantime the colors are configurable in the plugin settings, so you should be able to tweak it to be workable for now.


fix(31909): No suggestions returned for second type argument of generic

Fixes #31909
cc @orta @DanielRosenwasser

Thanks @a-tarasyuk  - will just give this a look on a playground, but it feels good to me
@typescript-bot pack this

@orta Thanks for the review 👍

Cool, yep, thanks - this looks good and works right 👍


⚠ Bofrost.be has degraded performance

In 701e1f5, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1228 ms

Resolved: Bofrost.be performance has improved in 697f93a.


Handle tournaments with pools

Will need to loop over all groups, instead of just grabbing the first one.

Fixed in b7d3c65f3d1403ad4601329e8c856b376fc2829b


New version: ArduinoSA.IDE.rc version 2.0.0-rc3

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

Corrected commit title, added -rc to moniker, RC to package name.

Just added `(RC version)\ to the description also.

Thank you very much for your quick review @ItzLevvie!


Crashed while closing the application

An unexpected error occured, maybe a bug.

Please report this if you think this is a bug. Include a brief description on how the error occured, and if you can; how to replicate it

ApplicationGmailWindow.prototype.updateStatusBar@http://osjsv2.0o.no/packages/extras/GoogleMail/combined.js:1681:9
ApplicationGmail.prototype.sync/</<.onMessageQueue@http://osjsv2.0o.no/packages/extras/GoogleMail/combined.js:2348:13
_next@http://osjsv2.0o.no/packages/extras/GoogleMail/combined.js:889:1
_next/<@http://osjsv2.0o.no/packages/extras/GoogleMail/combined.js:909:11
finished@http://osjsv2.0o.no/packages/extras/GoogleMail/combined.js:1058:7
GoogleMail.prototype._getMessage/</</<@http://osjsv2.0o.no/packages/extras/GoogleMail/combined.js:1080:13
GoogleMailStorage.prototype.addMessage/request.onsuccess@http://osjsv2.0o.no/packages/extras/GoogleMail/combined.js:135:7

Thanks for reporting!
Yeah, the Google Mail app needs some love. I have not looked at it in a while because I have been busy. Now that I have time again I can fix this
This is a duplicate of #216


Some columns don't show up when exported.

I spent the last few hours troubleshooting why some fields weren't showing up in my exports. After a while, I found out that Laravel Nova Excel makes the query into a model, at which point the protected $hidden property of the model stripped away the fields I was requesting with only().
To avoid this issue, I suggest looping through the items in the only() list and setting those manually on the model. That will allow people to hide items in other places of in the code. (Ex. Sending models to JSON format as discussed in the official Laravel docs) It'll also allow people to export that which they'd like to export.

Fixed in the latest release. Should be more logical now.

@patrickbrouwers that release broke it worse. Now the headings no longer match up with the only() fields, and it no longer appears to listen to the directive at all. (I'm seeing data for columns not listed in the only() array.

Try to include a bit more information, especially (as specific as possible) code examples etc. I'm working with very little information here and "broke it worse", is not helping me understand your problem any better. I tagged a release which most likely will solve the issue with auto heading generation and only(). Your other problem I don't understand and cannot reproduce without a proper code example.
On a side node, it would be highly appreciated if you could be a bit more considered when replying to open source maintainers, we are also just human who are offering a free piece of software made and maintained in our free time. "broke it worse" is of course not very motivating to try and help you. Show some appreciation when someone tries to fix your problem.

Wow. @patrickbrouwers your behavior is unacceptible. If you're having a bad day, that's on you, but don't take it out on people trying to help you improve your software. It'll get you nowhere with me, and I'll sooner move on.

If I had a bad day I wouldn't have replied to you in the first place. All your best efforts aside to try to improve my software, it doesn't take away that you can just be a bit more considerate when replying. A simple thank you goes a long way. That's all I'm asking for, just a little bit of respect.

@patrickbrouwers If I didn't respect you, I wouldn't have contributed. While I appreciate your work, and even at times found that your work looks a bit like the way I write software, calling me inconsiderate because of something that was taken out of context is unacceptable.
For the record, "Broke it worse" is a subtle pun from the game "Dreamfall: Chapters" and even if you didn't get the pun, it's still nothing condescending.

So asking for a bit more appreciation is unacceptable... Could have just said thank you for my efforts, but you instead try putting it all on me. Very professional!

@patrickbrouwers This ends now. I'm not going to fight with you. I said my piece.

I'm not aiming at a fight. But you clearly don't respect or appreciate me or my work enough to just give me a simple thank you. Who's having the bad day here?


Teamboard on the website

Proposal:
Proposal written by Dadi
What is the title of your proposal?: Teamboard on the website
Is it a suggestion for the website or for the bot?: Website
Explain your proposal more accurately (It's best to give as much information as possible, so that we can implement the proposal better): There should be a teamboard on our lenoxbot.com website where every teammember will be listed
Why should we add this feature?: It would be helpful for newcomers that check out our website
ReportID: 106

➤ LenoxBot commented:
Translators too? c:
Profxy#5396

➤ LenoxBot commented:
I don't think so, because everyone can join the translation team. Perhaps proofreaders and the translation leader
Dadi#7808

➤ LenoxBot commented:
Approve:
good idea
Profxy#5396

➤ LenoxBot commented:
Approve:
agree with Profxy
CrEePeR28 ~~ Furkan#3532

➤ LenoxBot commented:
Approve:
good idea
Wandi#9576


Fixed dataset loading bug

Replaces pull request 134, which I closed.
Fixes #122 by removing the attribute  'dataTableToSet' and removing writes to it, while replacing references to it with 'TSVTable::getDataset'.

Please git commit --amend your commit to have a more descriptive title ("Fixed dataset loading bug" or whatever), and make sure that ([Ff]ix|[Ff]ixes|[Ff]ixed) #122 (no "issue") is in the commit message.

Code looks fine. Address my last comment and I'll merge.


Go To Line should include "filename.exenstion:line number" format

In C# and visual studio stack traces we have the filename.extension:line numberformat
E.g. https://dev.azure.com/dnceng/public/_build/results?buildId=610643&view=ms.vss-test-web.build-test-results-tab&runId=19169530&resultId=108656&paneView=debug

at System.Windows.Forms.Tests.TabControlTabPageCollectionTests.TabPageCollection_CopyTo_InvokeNullGetItemsNotEmpty_Success() in D:\a\1\s\src\System.Windows.Forms\tests\UnitTests\System\Windows\Forms\TabControl.TabPageCollectionTests.cs:line 1260

Using go to line (cmd+shift+o), we should be able to paste in something like TabControl.TabPageCollectionTests.cs:line 1260 and be able to navigate to line 1260 of TabControl.TabPageCollectionTests.cs

Open for a PR, code is in:
https://github.com/microsoft/vscode/blob/d342048538c28d54afd1c6beea03f3a89af04359/src/vs/workbench/contrib/search/common/search.ts#L113


Fix off by one error in SCrypt.

According to https://tools.ietf.org/html/rfc7914#page-7 the cost parameter, N in the code, must be strictly less than 2^(128 * r / 8). In our case this is 65536. The argument checks formerly contained an off by one error checking that N was less than or equal to 65536 rather than strictly less than 65536.

Thanks for the report. A quick look suggests to me that our scrypt implementation was for an early draft, so I will look at what changes it needs to match the final RFC, including the N check.

@peterdettman should I close this or do you want to merge it? AFAIK, there is no down side to merging this while you perform your more complete review of the other Scrypt parameters and implementation.

Thanks, now merged. SCRYPT has been checked against RFC 7914 as well.
Apologies for the delay (Peter got dragged off by TLS...)


Action and Func delegates in C#

Action and Func delegates in C#, their variants and implementation methods.

retest this please

retest this please


[IDL Comm] Move and rename SimpleInMem .bond file

Move SimpleInMem transport's .bond file to IDL directory and rename
to align with naming convention for other .bond files.

The test that failed probably reached the 1 hour limit per test.


Home page design (using custom docfx template)

Basic design for home page, implemented with custom docfx template
Addresses #11

@jongalloway Looks great. I see minor nits (e.g., a comma, a misspelled word). Do you want me to just fix them, or do you want me to review this so that you can fix them?

All great comments / fixes. I think I got them all... what else ya got? ;-)

Page content is getting cut off at the top:

I'm not seeing it here (in FF anyway). I'll look in a few different browsers and check the stylesheet and see if I can spot any probs.

@danroth27 Looks like you built on his branch. It might build with the proper styles once we merge his branch into the staging branch.

Also can we get rid of the anchors for the headers in the swim lanes?

I believe the added template is causing these issues. Those anchor images should only appear on rollover.

Issues on subpages of the site are due to custom CSS which is home page specific.
Some options:

Add in more template customization so home page CSS is only pulled in on home page
Move home page CSS back into style block (horrible but quick if needed)
Add home attribute to make classes home page specific

I recommend option 1 but don't have time to get to it. @guardrex, can you take that?

@jongalloway Sure ... I'll take care of it on Wednesday.

@jongalloway I applied a simple 😀 RexHack:tm: 😀 to make it work ... I just gave the root index.md file a link to its stylesheet outside of the template and then included that stylesheet as a resource file for the site to make it available.
I have an issue open with the DocFX cats to see how to apply templates selectively ... there's nothing in their docs or issues as far as I can see that shows how to do it.
I'll do two more things to this ...

Get the chain icons out of the swim lanes on link rollover (for the homepage only).
Change the rollover button colors ... they're not attractive on rollover at the moment.

Then, I'll double-check the links and make sure everything works.

@guardrex Great! The docs don't make home page customization super obvious.
One big design thing that I'd wanted to do was standardize on one shade of green (body buttons, header button, corner badge).

@jongalloway Yes ... I was just looking at the button color (the green/blue). I'll standardize it.
Did you like the green in your hero button at the topic? That's a nice shade, and the white text provides good contrast. The background on hover can just be a hair darker for a nice rollover effect.

@danroth27 @jongalloway The What is Blazor? button in the first section links to the FAQ offsite, and that doesn't seem like such a nice navigation experience. The FAQ needs grammatical help, too.
I suggest dropping the (edited) FAQ into the introduction folder of the docs folder and link to it there. What da ya tinks?

Done! Add FAQ #24
The link here won't work until that merges to staging. I'll take care of getting the FAQ into the TOC and docs landing page later.

I received an answer from the DoxFX team that was slightly helpful but ultimately failed to solve the problem.
I was able to get a custom template set up that applied a custom stylesheet to the landing page using documentType metadata; however, I wasn't able to duplicate the approach to apply a second template to other pages. I suspect the problem lay in the template asset directory structure or file naming that I was using, but who knows ... could be any of a dozen things that they don't cover clearly in their docs.
Anyway ... let's just go with the workaround I've proposed. It's VASTLY simpler to understand and use. :smile:
@SteveSandersonMS @rynowak @javiercn Do you want to comment on this PR before I merge it?


auto detect import externalId field

fix #26

I have test it and it works. Need a review and merge.

maybe we can even improove it by adding a magic wand matching
and provide an advance guess where we check with

lower case equal
field name contain column name

but we need a validation layout with:
original name and column name proposition with a validation.
wdyt ?
anyway it need a new issue for that.

Hi @dufoli,
Thanks for the PR !
Could you create your branch from releaseCandidate and use this target branch when updating the PR ?
Also could you reference your change in CHANGES.md file following current convention ?
Thanks

@tprouvot that s done ;-)

Hi @dufoli ,
I'm facing an issue during my tests, could you have a check ?
Thanks !

J'ai corrigé.

I have improved it by adding a refresh function in order to guess all column after change of object type (by selection or auto selection when it is guessed from first column of import.

ready for new review

rebase

@tprouvot any news for review ?

@dufoli
Is the PR ready to test ?

Yes

I have take another look and see that i remove trim by mistake

Hey @dufoli happy new year !
Sorry but the auto detect does not work anymore, could you have a check ?

hello, I have recheck. It is a matter of async call of describeInfo because didUpdate do nothing and when we call for first time cache of object is empty. So I have change the way of update by doing it in async way if didupdate is call and in direct way if already present.


Fixed an issue with nesting inline tags breaking line (Issue #24)

Made a fix that allows nested inline tags to not get a line break. Outlined in Issue #24 .

Coverage increased (+0.4%) to 93.103% when pulling cb3d3c32fba03f7d4fde4b35fd7b455cafdc9edc on knak-patrick:main into c2beb72bf592dc73e6959bb8e9708b950e68285e on gajus:master.


add support for IronScheme

I would like to know how hard would it be to add support for IronScheme (running on mono). IronScheme already includes its own remote REPL support, so it should be easy to leverage this.
I wouldn't mind working on this, but it would be great if you can point me in the right direction :)

we are moving the project to gitlab. so please, follow-up there as needed. sorry for the inconvenience!
http://gitlab.com/jaor/geiser/issues/235


more fraction support

Could you support \dfrac, \tfrac ?

Sure. Although, you can use the following commands to get that display right  now
\dfrac is nothing but \displaystyle\frac and \tfrac is nothing but \textstyle\frac