user feedback: tool/exec and tool/cli

To be honest, I was a somewhat surprised to discover tool/exec and tool/cli in CUE. Are these considered fundamental to the design? I would have thought that ability of writing data to files and to stdout (perhaps with some filtering capabilities) would have given most users all they need. Is there a desire to make scripting on top of cue unnecessary? I am just a little unsure about the viability, especially considering familiarity factors of scripting languages. For example, is how should user define error handling logic and is CUE going to implement a flag parser?

I think FeatureRequest label should be removed, just wasn't sure what category to pick...

I agree it seems gratuitous at first to have a tooling layer in CUE. It does aim to solve several core issues and shortcomings of other configuration languages:
Work around the limits of hermetic configuration
It is generally considered a good property for configurations to be hermitic (or pure, if you will). That is, their values should not depend on anything defined outside the configuration. In practice this is quite a limitation and many configuration languages allow injecting values one way or the other. Unfortunately, this is often done in a way that then reduces the ability to analyze or automate such configurations.
The tooling layer in CUE serves to inject non-hermitic input. Arguably this could be done outside of CUE. However, having it inside gives more information about the intent of a configuration and allows for more continuity.
Code or data?
Ideally, all configuration is expressed in terms of data and some simple logic to allow some reuse and boilerplate reduction. In practice, this doesn't work. Sooner or later one hits a wall where the complexity needs to be pulled in the configuration layer. What we have seen is that languages like GCL and Jsonnet become full programming languages, far removed from the original intent.
Some will argue that given this, why not represent all configuration as code? This is the stance Pulimi takes.
CUE takes a different stance. Instead of wrapping configuration with code, the idea is to wrap code with configuration (or rather interleave it). CUEs compositional model makes it easy to combine data from different sources. Partial CUE evaluations can be shelled out to code and the result can be injected back into CUE. By splitting out this interaction in the tooling layer, we keep fully analyzability at the configuration layer. Defining this interaction in CUE itself has various benefits, if nothing else for continuity.
Tooling proliferation
When you say that scripting isn't necessary, you are probably alluding to the fact that if cue just does conversions, one can just script around it. True. The problem is that scripts are hard to share. What one sees in practice is that, instead, tools are written around a generic configlang tool or library to deal with this. I've written many! But such tools are inevitably closed. So to address shortcomings of those tools, people write more tools, etc. Some prefer to refer to this tooling proliferation as a "rich ecosystem", but I generally consider it problematic.
To use CUE, people already need to install CUE tooling. In addition, the model of composition of CUE makes it very suitable for defining reusable. workflows. So if CUE is a given, one might as well use it for defining tools. This eliminates the need to distribute more binaries or install runtimes and allows for a consistent CLI generation. But most importantly, it opens up the ability to create composable tools.
CUE is also an efficient way to write tools. I've analyzed a myriad of command line tools and micro services and in many cases a CUE implementation could be written in a fraction of the code of the original.
Conclusion
Anyway, all in all it seems that the benefits outweighed the drawbacks. It has a lot of potential, even if it is a bit undeveloped at this point. Even so, there are many fans already.
Answers to direct questions:

how should user define error handling logic?
Right now a task error fails all following tasks and ultimately the process. The idea is indeed to allow error gobbling.

familiarity factors of scripting languages.
Scripting languages do not adequately address the concerns mentioned above.

CUE going to implement a flag parser?
 See cue help injection. A flag mechanism specifically for tools may be considered.

HTH :)

@mpvl thanks a lot for the insight, I can understand the reasoning, I guess I still stand as surprised user :)
Also, I have to say, I found the Go library very easy to use, and started an experimental project, the idea is to add some simple conventions/opinions on top of CUE that make it a bit easier to consume for someone who doesn't have all the time to invest in learning all features of CUE and just wants to do a few simple things to start with.

This issue has been migrated to https://github.com/cue-lang/cue/issues/361.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


zh: update daily-check.md

What is changed, added or deleted? (Required)

update daily-check.md

Which TiDB Data Migration (DM) version(s) do your changes apply to? (Required)

[x] master (the latest development version, including v2.0 changes for now)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

LGTM

@miaoqingli PTAL

@miaoqingli PTAL

LGTM


Using listenToOnce() seems to remove all listeners from obj instead of just callback

Looking at https://github.com/jashkenas/backbone/blob/master/backbone.js#L284, should
var events = eventsApi(onceMap, {}, name, callback, this.stopListening.bind(this, obj)); be var events = eventsApi(onceMap, {}, name, callback, this.stopListening.bind(this, obj, callback)); instead?

Found a different issue in my code that fixed what was going on, so don't think this is actually an issue


Fix Definition for Module

https://github.com/mitre-attack/attack-datasources/blob/0cde745a308bd4b2e12ec4dba6cbf3de5406ea5a/contribution/module.yml#L2
There's a minor typo (linkiable) in the definition text, and I think the overall definition can be modified a little for accuracy since PE/ELF/Mach-O encompass both executables and libraries. I would suggest:
Information about module files consisting of one or more classes and interfaces, such as portable executable (PE) format executables/dynamic link libraries (DLL), executable and linkable format (ELF) executables/shared libraries, and Mach-O format executables/shared libraries.

Thanks @ikiril01!!!!


Simpler install instructions for Windows

use windows-build-tools instead of Visual Studio

I would advice that one waits with this as there are perceived problems until full enlightenment is obtained
https://github.com/nodejs/node-gyp/issues/1116
Current recommendation from my opinionated view with requirement for confirmation within a couple of days is ensure that one follows MS very closely with http://landinghub.visualstudio.com/visual-cpp-build-tools and the doc on the page and avoid more dependency hell: MS and c++ the necessary evils, other modules are not.
(off topic ref Linus and his many rants about c contra c++: dependency hell should be avoided)

@don thanks!


Support for new elastic runtime (Diego)

Hi there - are there any plans of allowing Diego to be deployed using cf_nise_installer?
Thanks.

Unfortunately, I have no time to spend some time to make a major update for this tool.
PR is welcome.


Scopes

We don't need to define scopes in .env, as not really configureable. We need cid, name and email regardless :)
Tested this in my local and staging env, and it seems to work, though do a double-check :)

I see you removed .env.testing. Gitlab CI currently needs that file to run, well, Gitlab CI. I simply cannot merge it right now, as that will break stuff on my side.
We can do 3 things here, whichever has your preference:

Wait till I (finally) over to Github Actions to handle CI/CD. Best option if there's no rush.
You undo bad74fb. Best if you want all the changes to master quicker.
Temporary make sure the .env.example file can work with Gitlab CI.

Oooh, that's what it was for :D I had a feeling I deleted something that was of importance afterwards, haha! I undoed the change, so you can merge it already 👍


Add image url field to ApartmentCreationForm

Description

Add image url field to ApartmentCreationForm

Screenshots

Issues closed by this PR
Fixes #238

👍🏼 👍🏼 👍🏼


⚠ Carbubu has degraded performance

In bfaeff5, Carbubu (https://carbubu.fr) experienced degraded performance:

HTTP code: 200
Response time: 4758 ms

Resolved: Carbubu performance has improved in 4279551 after 6 minutes.


[apptools] Add tests to test crosswalk-package command for apptools android and windows

Failure analysis:
https://crosswalk-project.org/jira/browse/XWALK-5207
Impacted tests(approved): new 4, update 0, delete 0
Unit test platform: [Android]
Unit test result summary: pass 2, fail 2, block 0
https://crosswalk-project.org/jira/browse/XWALK-4699
https://crosswalk-project.org/jira/browse/XWALK-5174
https://crosswalk-project.org/jira/browse/XWALK-4715
BUG=https://crosswalk-project.org/jira/browse/XWALK-5197

LGTM


All preprints to newsletter

 To add preprints requiring a recommender in the newsletter for recommenders until cancelled or handled


Simplify hoster agreements

Everyone who currently bought 120 tokens (at 5 USD) will become eligible to become a hoster at no extra cost. People who already ordered a node will be compensated to give everyone the same benefits of 120 tokens for 600 USD and 6 times 5 tokens = 150 tokens total
This means that the hoster_flow will change - I already prepared most of one as "order_node_v3".
As a current last info message, I put:

Your order is being processed. Your personalized "Terms and conditions" document is being created. and we are verifying you fulfill all requirements in order to become a hoster. This process can currently take a few days.
You will receive a notification when this is finished, and will be asked to sign it with your PIN code to finalize the agreement.

Some issues remain:
Can we check online straight away prior to generating the agreement that this person has indeed

paid for 120 tokens
has not ordered a node yet?

If this is possible, we can generate the agreement straigth away and the above text should be amended in app to

Your order is being processed. Your personalized "Terms and conditions" document is being created. and we are verifying you fulfill all requirements in order to become a hoster. This process can take a few moments.
You will receive a notification when this is finished, and will be asked to sign it with your PIN code to finalize the agreement.

[ ] Check if InvestmentAgreement exists with more than 120 tokens
[ ] If not, flag for manual check.
[ ] Add textfield for error message and a cancel button if user hasn't invested enough yet

InvestmentAgreements marked as paid for a total of more than 120 tokens worth AND no preexisting Hoster agreement
If not, flag for manual check (currently here to support legacy investments made outside the app)
error message and cancel ONLY pushed to user after manual check

If 1) is true or 2) manual check agrees, we continue the flow / push a filled in HostersAgreement to the user's app.

Current hoster confirmation message at https://github.com/threefoldfoundation/app_backend/blob/master/plugins/tff_backend/bizz/hoster.py#L228

Thank you for your order.
Your transaction is waiting confirmation.
Please use the following transfer details
Amount: USD 600 - Bank : Mashreq Bank - IBAN : AE230330000019120028156 - BIC : BOMLAEAD
For the attention of Green IT Globe Holdings FZC, a company incorporated under the laws of Sharjah, United Arab Emirates, with registered office at SAIF Zone, SAIF Desk Q1-07-038/B
Please use the SO number as reference.

This should change to

You have now been approved for hosting duties!
We will keep you updated of the Node shipping process through the app.

Also, I guess this means we need to update the todo lists.

Does this mean we can remove the 'pay' step from the todo list, and remove the 'Mark as paid' button in the dashboard?

Yes indeed!


ocis bumped. the expected failures removed.

Please don't merge red PRs. The changelog pipeline was failing, which is not acceptable. The only step which is allowed to be red is the license step.
We had to fix it on our feature branch: https://github.com/cs3org/reva/pull/4774

Please don't merge red PRs.

Sorry, I saw that the drone CI had passed, and I knew that "other stuff is known to fail" and didn't look closely. I will be more careful in future.
(this is a problem with having "known red" in CI - is there something that we can do to fix that? Or maybe we should remove the License Compliance workflow, if we are ignoring it anyway)

(this is a problem with having "known red" in CI - is there something that we can do to fix that? Or maybe we should remove the License Compliance workflow, if we are ignoring it anyway)

I 100% agree. But as far as I know we cannot remove this step.
@micbar is there any chance we can disable this step? Accepted red pipelines are bad.


Unsupported operation: Cannot modify unmodifiable map

Recently, I cannot create new recipes with your mobile app on my Android Phones. I always get this error

The Webapp still works perfectly fine.
Android App Version: 0.7.9
Webapp Version: 0.10.2
Nextcloud Version: 25.0.5

Can you please add information on what you where trying to do when the error poped up?
Was it just hitting the submit button or when you tried adding ingredients?
I have an idea where this comes from but that information would make it easier finding.

Ok I found the issue. #171 is not affected by this

Yes, as soon as I click "Create" this error pops up. #171 looks like a big leap and looks like it is about to be merged?

Yep i'ts already merged and all api endpoints and data structure classes are now covered in unit tests.
The bug actually was when constructing a Recipe class.
Sadly it will still takes a few weeks for a new release as some behavior has to be re implemented.

Hi,
Did anyone find a workaround (until the new great release is out)? Would downgrading the version help (I could not via F-Droid though)?

Just to add my "+1" to this. I have freshly installed the cookbook on my nextcloud instance and this app on my phone. I can't create recipies at all on android.
What I did: Click the "+" on the main screen. Then just entering a recipe name (no other information) and clicking the Create button at the bottom throws the exception as OP has shown in his screenshot.
I am able to modify an existing recipe though.

I am also having the same problem on the latest version.

I have same problem too

I'm having the same problem.  I'm using NextCloud Cookbook version 1.1 for iOS.

Yep i'ts already merged and all api endpoints and data structure classes are now covered in unit tests. The bug actually was when constructing a Recipe class.
Sadly it will still takes a few weeks for a new release as some behavior has to be re implemented.

Hi! Is there a ticket or roadmap for the things that are still missing before being able to release a new version?
If possible I'd like to help.

Hello, I have same problem too. I really like this cookbook app and it would be great if I could also create new recipes with my android phone.
The temporary solution is to create a new recipe in the Nook app and just enter its name. It can then be edited in this application as well.

just to bump it back up. I have this issue as well.

Same here, freshly installed both app and server

Same problem here. This is definitely a showstopper. What needs to be addressed to fix it?


mOpenSourceAdapter is null

https://github.com/MindorksOpenSource/android-mvp-architecture/blob/4191a3c325a2464811fdf4c3733731f54b4902a5/app/src/main/java/com/mindorks/framework/mvp/ui/feed/opensource/OpenSourceFragment.java#L100
Sometimes mOpenSourceAdapter is null and it hangs.
Reproduce the problem in an easy way:
1- Start an intent to youtube
Intent intent = new Intent(Intent.ACTION_VIEW,Uri.parse(String.format("http://www.youtube.com/watch?v=%s", KEY))); intent.putExtra("force_fullscreen", true); itemView.getContext().startActivity(intent);
2- Press 4 times or more the button back before the video is opened
2.1 - The "onDestroyView" method is triggered when it does not have to.
3 - mOpenSourceAdapter is null and the application closes
I have tried to check if it is null and in the case that it is to start a new instance of OpenSourceAdapter but the application does not respond.
Is this normal?

The problem was related to variables that were null by the change of view (the activity was destroyed) has been my problem. It only happened with the change of quick view back from the landscape mode for some strange reason.

The problem was related to variables that were null by the change of view (the activity was destroyed) has been my problem. It only happened with the change of quick view back from the landscape mode for some strange reason.


Istio installation failing on minishift

Hi Team,
I am trying to install istio in my minishift setup. After following all the steps at https://github.com/minishift/minishift-addons/tree/master/add-ons/istio I am stuck at the below step.
$ minishift addon apply istio --addon-env ISTIO_HOME=$ISTIO_HOME
Error which I am getting :
$ minishift addon apply istio --addon-env ISTIO_HOME=$ISTIO_HOME
-- Applying addon 'istio':.....error: the path "/home/pulgupta/istio-1.0.2/install/kubernetes/istio.yaml" does not exist
Error applying the add-on: Error executing command oc create -f #{ISTIO_HOME}/install/kubernetes/istio.yaml.

The files which are present in {ISTIO_HOME}/install/kubernetes are :
cd /home/pulgupta/istio-1.0.2/install/kubernetes
pulgupta@pulgupta $ ll
total 294
drwxr-xr-x. 2 pulgupta pulgupta   1024 Sep  7 01:33 addons
drwxr-xr-x. 3 pulgupta pulgupta   1024 Sep  7 01:33 ansible
drwxr-xr-x. 4 pulgupta pulgupta   1024 Sep  7 01:33 helm
-rw-r--r--. 1 pulgupta pulgupta   1374 Sep  7 01:33 istio-citadel-plugin-certs.yaml
-rw-r--r--. 1 pulgupta pulgupta   2397 Sep  7 01:33 istio-citadel-standalone.yaml
-rw-r--r--. 1 pulgupta pulgupta   1814 Sep  7 01:33 istio-citadel-with-health-check.yaml
-rw-r--r--. 1 pulgupta pulgupta 138826 Sep  7 01:33 istio-demo-auth.yaml
-rw-r--r--. 1 pulgupta pulgupta 134490 Sep  7 01:33 istio-demo.yaml
-rw-r--r--. 1 pulgupta pulgupta   1610 Sep  7 01:33 mesh-expansion.yaml
-rw-r--r--. 1 pulgupta pulgupta    102 Sep  7 01:33 namespace.yaml
-rw-r--r--. 1 pulgupta pulgupta   1053 Sep  7 01:33 README.md

Minishift version : minishift v1.12.0+daa0943
minishift addons list

admin-user     : enabled    P(0)
anyuid         : enabled    P(0)
istio          : disabled   P(0)
registry-route : disabled   P(0)
xpaas          : disabled   P(0)

@pulgupta @mramadan88 Today we just merged the updated patch for istio addon patch, give it a try and let us know if still have issue.

@praveenkumar Thanks a lot.
I am getting the following error:
-- Checking if requested OpenShift version 'v3.1.0' is valid ... v3.1.0 is not a valid OpenShift versionFAIL
did you mean v3.10.0?
minishift config set openshift-version v3.10.0

did you mean v3.10.0?

@pulgupta yes this is what version you should use.

@pulgupta, please check now and let us know  ?? we have fixed and refactored it a lot now

@kameshsampath seems so, I deleted the complete minishift setup now and tried installing everything fresh, But now I am getting another error while trying to start minishift after specifying the initial configurations
$ minishift config set openshift-version v3.10.0 (5)
$ minishift addon enable admin-user (6)
$ minishift addon enable anyuid (7)
$ minishift start (8)
ERROR
24.08 MiB / 24.08 MiB [==========================================================================================================================================================] 100.00% 0s-- Downloading OpenShift v3.10.0 checksums ... OK
-- OpenShift cluster will be configured with ...
Version: v3.10.0
-- Checking oc support for startup flags ...
host-volumes-dir ... FAIL
Error during 'cluster up' execution: Flag host-volumes-dir is not supported for oc version v3.10.0. Use 'openshift-version' flag to select a different version of OpenShift.

seems so, I deleted the complete minishift setup now and tried installing everything fresh

@pulgupta how did you delete it? Next error which you are seeing is not something expected when you set 3.10 version as default.

@pulgupta  what OS you are in ?

@praveenkumar I used this resource to clean up the system. https://docs.okd.io/latest/minishift/getting-started/uninstalling.html
My OS version is RHEL 7.4
@kameshsampath I was able to resolve the issue by upgrading minishift to latest version.
However now I am getting this
-- Starting OpenShift cluster ........................................................................................Error during 'cluster up' execution: Error starting the cluster. ssh command error:
command : /var/lib/minishift/bin/oc cluster up --base-dir /var/lib/minishift/base --image 'openshift/origin-${component}:v3.10.0' --public-hostname <IP_ADDRESS> --routing-suffix <IP_ADDRESS>.nip.io
err     : exit status 1
output  : Getting a Docker client ...

I tried downgrading to 3.9.0 and was no longer facing this issue but then later when I ran minishift addon apply istio I came to know that Istio does not support v3.9.0
Any suggestion how to resolve the issue with 3.10.0

Any progress on this?


Revert "[test] Yet more tweaks to remote-run"

Reverts apple/swift#19130. I broke the Apple-internal tool again. I guess I need more local testing.
cc @shajrawi

@swift-ci Please smoke test and merge

Thanks @jrose-apple ! I was just about to open a radar


Release 1.1.17

Updates Xamarin.UITest launch test projects to use 3.0.0

Typo on the version in the commit message (should be v1.1.17)


upgrading to 5.1 from 5.0.3 made the tests crash

I upgraded the bundle to 5.1.0 on a project. This was the only updated dependency, no change of code except adding type hinting on classes extending some classes of this bundle.
Our tests are failing with the following message /bin/bash: line 1: 11194 Killed and then display Exited with code exit status 137 on CircleCI.
Locking the bundle in our composer to 5.0.3 (leaving the type hint of our inherited classes) makes the tests pass. This is very strange.
There are 20 files that were changed from 5.0.3 so I will try to isolate the change and submit a PR if I find anything. This is very strange.

Explanation on #70, thank you @virtualize


Add context in Get(service string) function

The method Get defined here must take a ctx context.Context in parameters.

@ipfaze, I see the pull request has been merged. Do we need to do more on this topic?

Updating the issue, as stated in our review.
We must context-ified all function that does not have a context in parameters.
This will lead to a new major release.


internal: publish

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Then you ensure you get the latest version of their transitive dependencies.

Then you ensure you get the latest version of their transitive dependencies.

won’t that already happen when someone runs the update command, or reinstalls the base package? that’s kind of the whole point of semver ranges.

won’t that already happen when someone runs the update command, or reinstalls the base package? that’s kind of the whole point of semver ranges.

This is a lerna behavior, so you might ask the babel people to get their idea
For me, running update is scary - I like to move things incrementally, and it's also easier to know that I can update something when the package I actually have installed changes. I wouldn't know to upgrade otherwise unless I did the scary outdated commands which show way too much stuff that I don't even understand half the time.

This is a lerna behavior, so you might ask the babel people to get their idea
For me, running update is scary - I like to move things incrementally, and it's also easier to know that I can update something when the package I actually have installed changes. I wouldn't know to upgrade otherwise unless I did the scary outdated commands which show way too much stuff that I don't even understand half the time.

Things like renovate and dependabot usually handle that kind of updating, but understood.

Things like renovate and dependabot usually handle that kind of updating, but understood.


Questions to doc

14 - subscribe all event costs

What does it mean and how is it going to looks like?

28 - Based on this amount all profit from cyberCon is distributed to speakers

What does it mean? They get revenue from all of the event? Or 50% of all profit? Or just return their's ETH in case of participation?

My suggestions on the topics are presented in #40
In brief,

Costs are Orginizer's risk, which should be counted in the profit share rate
Both profit share from tickets and loss deposits from missed speakers, see Profit Distribution part of the doc

@DearNadia Please resolve conflicts


WRQ-17541: Updates ui/Marquee.MarqueeDecorator.marqueeDirection to use enact/i18n utils.

Checklist

[x] I have read and understand the contribution guide
[x] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
Updates ui/Marquee.MarqueeDecorator.marqueeDirection to use enact/i18n utils.
Resolution
Updates ui/Marquee.MarqueeDecorator.marqueeDirection to use enact/i18n utils.
Additional Considerations
Links
WRQ-17541
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong<EMAIL_ADDRESS>

@hong6316 , Could you resolve the merge conflicts, please?


EOFError by loading umap model

I have created a umap model and saved it via joblib. Then I try to load the model on another PC but with the same environment. My memory is 50% full. Is it not possible to save an umap model with joblib?
umap_model_plot = umap.UMAP(n_neighbors=15,
                               n_components=2,
                               metric='cosine').fit(emb)

joblib.dump(umap_model_plot,'umap_2.sav')

Load model

joblib.load('umap_2.sav')
Traceback (most recent call last):

  File "<ipython-input-9-ef20fd6f570e>", line 1, in <module>
    joblib.load('umap_2.sav')

  File "C:\Users\Paul\AppData\Roaming\Python\Python37\site-packages\joblib\numpy_pickle.py", line 585, in load
    obj = _unpickle(fobj, filename, mmap_mode)

  File "C:\Users\Paul\AppData\Roaming\Python\Python37\site-packages\joblib\numpy_pickle.py", line 504, in _unpickle
    obj = unpickler.load()

  File "C:\Users\Paul\Anaconda3\envs\top2vec_final\lib\pickle.py", line 1086, in load
    raise EOFError

EOFError

this is almost impossible to debug with this little information:
possible things to look at, for you:

if you moved the model, you could be missing actual bytes (thats my first guess by EOF error) because the move didn't work perfectly.
If the model got compressed during the move maybe that's bad? depending on compression algo?
if moving between windows and unix that could be bad
if there are ANY dependency mis matches between the two systems that could be bad

also, my OCD is triggered by you naming the UMAP() object as a plot. are you trying to load the .save as a .png accidentally?


Trackers revamp

Standardizing the latency trackers and making them only track, the timing is handled by a separate class Timer.
Making the memory tracker more robust when used with launch, by monitoring the main benchmark process (so no need to aggregate VRAM over multiple processes) and supporting both per process and global VRAM tracking at the same time.

@franchukpetro I know you've been using VRAM measurements by setting PROCESS_SPECIFIC_VRAM.
This PR removes that environment variable in favor of reporting both (memory.max_global_vram and memory.max_process_vram), hope this makes VRAM benchmarking easier 🤗

Makes sense, thanks a lot for letting me know, @IlyasMoutawwakil!


ref.watch doesn't work

Describe the bug
ref.watch(alertProvider); doesn't work.
To Reproduce
Here's the full code, you can copy paste it in your main.dart:
import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';

void main() {
  runApp(
    ProviderScope(child: const MyApp()),
  );
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: false,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends ConsumerStatefulWidget {
  @override
  ConsumerState createState() => _MyHomePageState();
}

class _MyHomePageState extends ConsumerState<MyHomePage> {
  @override
  void initState() {
    super.initState();
    ref.read(alertProvider.notifier).getAlerts();
    SchedulerBinding.instance.addPostFrameCallback((_) {
      ref.read(alertSpeedProvider.notifier).getSpeedAlerts();
    });
  }

  @override
  Widget build(BuildContext context) {
    return SafeArea(
      child: Scaffold(
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            crossAxisAlignment: CrossAxisAlignment.center,
            children: [
              Text(
                ref.watch(alertSpeedProvider).toString(),
                style: TextStyle(fontWeight: FontWeight.bold, fontSize: 22),
              ),
              ElevatedButton(
                onPressed: () => ref.watch(alertProvider.notifier).getAlerts(),
                child: Text('Get alerts'),
              ),
            ],
          ),
        ),
      ),
    );
  }
}

class Alert {
  final String alertType;
  final String msg;

  Alert(this.alertType, this.msg);
}

final alertProvider = NotifierProvider<AlertProvider, List<Alert>>(() => AlertProvider());

class AlertProvider extends Notifier<List<Alert>> {
  @override
  List<Alert> build() {
    print('Build Alerts provider');
    return [];
  }

  void getAlerts() async {
    List<Alert> alerts = await getAlertsFromDB();
    state = alerts;
    print('getAlerts called');
  }

  Future<List<Alert>> getAlertsFromDB() async {
    await Future.delayed(const Duration(milliseconds: 300));
    List<Alert> alerts = [
      Alert('speed', 'You exceeded the speed limit by 10 KM/H'),
      Alert('speed', 'You exceeded the speed limit by 20 KM/H'),
      Alert('speed', 'You exceeded the speed limit by 30 KM/H'),
      Alert('zone', 'You are entering a danger zone'),
    ];
    return alerts;
  }
}

final alertSpeedProvider = NotifierProvider<AlertSpeedProvider, List<Alert>>(() => AlertSpeedProvider());

class AlertSpeedProvider extends Notifier<List<Alert>> {
  @override
  List<Alert> build() {
    print('Build Speed Alerts provider');
    return [];
  }

  void getSpeedAlerts() {
    List<Alert> alerts = ref.watch(alertProvider);
    List<Alert> speedAlerts = alerts.where((e) => e.alertType == 'speed').toList();
    state = speedAlerts;
    print('getSpeedAlerts called');
  }
}

Expected behavior
I expected when getAlerts is called, getSpeedAlerts is trigger, because of ref.watch(alertProvider); but it doesn't happened. Here's the logs:
I/flutter (29552): Build Alerts provider
I/flutter (29552): Build Speed Alerts provider
I/flutter (29552): getSpeedAlerts called
I/flutter (29552): getAlerts called
I/flutter (29552): Build Speed Alerts provider
I/flutter (29552): getAlerts called <------------------ getSpeedAlerts not called after this
I/flutter (29552): getAlerts called <------------------ getSpeedAlerts not called after this
I/flutter (29552): getAlerts called <------------------ getSpeedAlerts not called after this

ref.watch is for rebuilding a widget. In your case, you can use ref.listen inside the build function of your notifier.
But your code doesn't make too much sense.
If all you want to do is filter the state, you can add a method to your Alert class
List<Alert> get speedAlerts => where((e) => e.alertType == 'speed').toList();

Thank you! it's really working.


css doesnt work in stylish/stylus

the css works just fine if i put it into my own html file like so:
<!DOCTYPE html>

My First Heading

My first paragraph.

but if i use it in stylus/stylish it doesnt work. example:
@import url('file:///home/nitsi/.cache/wal/colors.css');
body {
  background-color: var(--background) !important;
  color: var(--foreground) !important;
}

why is that?

No idea, I wonder if anything has changed in Firefox/Chromium since I implemented this.


Add py to testing environments to resolve pytest 7.2.0 issues

Codecov Report

Merging #890 (5a9bc76) into main (feecf41) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
- Coverage   75.20%   74.94%   -0.27%
==========================================
  Files          72       72
  Lines        3779     3779
  Branches      674      674
==========================================
- Hits         2842     2832      -10
- Misses        804      807       +3
- Partials      133      140       +7

Impacted Files
Coverage Δ

dask_sql/physical/rex/core/literal.py
58.09% <0.00%> (-2.86%)
:arrow_down:

dask_sql/physical/rel/logical/window.py
95.37% <0.00%> (-1.74%)
:arrow_down:

dask_sql/_version.py
32.76% <0.00%> (-1.13%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


IndexOptimize job randomly reporting failure even when the log file says the Outcome succeeded

Description of the issue
IndexOptimize Job randomly reports failures in SQL Agent history even when it runs all the Index maintenance commands successfully. I checked the logs.txt files for a successful run and failed run and all the steps look similar beside the different in statistics. For example, last successful run completed in around 3:46 hours and the recent 'failed' job ran for 3:40 hours. Upon checking the logs in command log table and the .TXT file, the commands seems to be running successfully until the end. One job was reported failed whereas the other was reported successful
SQL Server version and edition
Execute SELECT @@VERSION
SQL Server Standard 2018 14.0.2052.1
Version of the script
Check the header of the stored procedure
Version: 2019-12-31 15:48:33
What command are you executing?
EXECUTE [dbo].[IndexOptimize]
@Databases = 'USER_DATABASES',
@FragmentationLow = NULL,
@FragmentationMedium = 'INDEX_REORGANIZE,INDEX_REBUILD_ONLINE,INDEX_REBUILD_OFFLINE',
@FragmentationHigh = 'INDEX_REBUILD_ONLINE,INDEX_REBUILD_OFFLINE',
@FragmentationLevel1 = 5,
@FragmentationLevel2 = 30,
@UpdateStatistics = 'ALL',
@OnlyModifiedStatistics = 'Y',
@LogToTable = 'Y',
@Indexes = 'ALL_INDEXES, -%.%.%.IX_PerfSample, and bunch other specific indexes'
What output are you getting?
This is the end of .txt log file
"ate and time: 2024-05-27 03:58:27 [SQLSTATE 01000]
Command: UPDATE STATISTICS [redacted].[VeeamOD].[Staging] [PK_OD_Staging] [SQLSTATE 01000]
Comment: ObjectType: Table, IndexType: Index, IndexType: Clustered, Incremental: N, RowCount: 235, ModificationCounter: 658 [SQLSTATE 01000]
Outcome: Succeeded [SQLSTATE 01000]
Duration: 00:00:00 [SQLSTATE 01000]
Date and time: 2024-05-27 03:58:27 [SQLSTATE 01000]
[SQLSTATE 01000]
Date and time: 2024-05-27 03:58:27 [SQLSTATE 01000]
[SQLSTATE 01000]"
This is the end of Message in SQL Agent Job history, which I believe is truncated
"  Date and time: 2024-05-27 00:18:25 [SQLSTATE 01000] (Message 50000)  	 [SQLSTATE 01000] (Message 50000)  Date and time: 2024-05-27 00:18:25 [SQLSTATE 01000] (Message 50000)  Command: UPDATE STATISTICS [redacted].[dbo].[DatabaseStatus] [_WA_Sys_00000002_5AEE82B9] [SQLSTATE 01000] (Message 50000)  Comment: ObjectType: Table, IndexType: Column, Incremental: N, RowCount: 352, ModificationCounter: 33 [SQLSTATE 01000] (Message 50000)  Outcome: Succeeded [SQLSTATE 01000] (Message 50000)  Duration: 00:00:00 [SQLSTATE 01000] (Message 50000)  Date and time: 2024-05-27 00:18:25 [SQLSTATE 01000] (Message 50000)  	 [SQLSTATE 01000] (Message 50000)  Date and time: 2024-05-27 00:18:25 [SQLS...  The step failed."

Dear @gkshitij
Have you found a solution? I ran into the same problem, but with a backup script. Everything is successful in the logs, but in the history of the SQL agent [SQLSTATE 01000...  The step failed.

Search for msg in the output file. Or "come: F" as in Outcome: Failed and you will find a deadlock or something similar.

The step did not fail so perhaps it's not the step.  Did you check the agent error log?  Perhaps the agent is failing to do a final activity like a notification.  I've seen similar in the past when the agent could not log to the file, but you are looking at the file so....  Is there a message at the end of the log file that's missing when it does not fail?  Is there another process running that can lock your log files?  Are the recommended virus scan exclusions for SQL exclusions in place?
There is a subtle difference in "non-error" severity levels in jobs.  Severities 0-10 are informational in the script.
However, severities 2-9 cause the job step to fail.  I don't think the step is failing, so this would not be the cause.  Besides, I doubt there are messages with levels 2-9.  It would not be random unless the message was random.
https://chadbaldwin.net/2021/01/15/raiserror-cheatsheet.html

Search for msg in the output file. Or "come: F" as in Outcome: Failed and you will find a deadlock or something similar.

Hmm, you were right. I thought that if an error occurs on some database, then the script is not executed on the following databases and stops.
I did find an error message on the RESTORE VERIFYONLY FROM DISK command:
Command: RESTORE VERIFYONLY FROM DISK = N'\my_path\mydatabase.bak' WITH CHECKSUM [SQLSTATE 01000]
Msg3203, Sev 16, State 1, Line 1 : Read on "\my_path\mydatabase.bak" failed: 13(The data is invalid.) [SQLSTATE 42000]
I will deal with it, thanks for the help

I did find an error message on the RESTORE VERIFYONLY FROM DISK command: Command: RESTORE VERIFYONLY FROM DISK = N'\my_path\mydatabase.bak' WITH CHECKSUM [SQLSTATE 01000] Msg3203, Sev 16, State 1, Line 1 : Read on "\my_path\mydatabase.bak" failed: 13(The data is invalid.) [SQLSTATE 4200

Well, this is not from the index job, this is output file from the backup job.

I did find an error message on the RESTORE VERIFYONLY FROM DISK command: Command: RESTORE VERIFYONLY FROM DISK = N'\my_path\mydatabase.bak' WITH CHECKSUM [SQLSTATE 01000] Msg3203, Sev 16, State 1, Line 1 : Read on "\my_path\mydatabase.bak" failed: 13(The data is invalid.) [SQLSTATE 4200

Well, this is not from the index job, this is output file from the backup job.

Yep, I initially said that I encountered a similar problem, only with a backup script


BUG: scipy.stats.multivariate_hypergeom.rvs raises ValueError when at least the last two populations are 0

Describe your issue.
I ran into a strange issue when sampling using Scipy's multivariate hypergeometric distribution. Calling scipy.stats.multivariate_hypergeom.rvs on a list of populations raises the error message ValueError: ngood + nbad < nsample, while calling the same function on the sorted array as input does not.
Specfically, the error seems to be raised when at least the last two values of the population are 0.
Reproducing Code Example
import scipy.stats
r = scipy.stats.multivariate_hypergeom.rvs
res1 = r([0, 20], 5) # Returns [0, 5]
res2 = r([0, 0, 20], 5) # Returns [0, 0, 5]
res3 = r([0, 0, 20, 0], 5) # # Returns [0, 0, 5, 0]
res4 = r([0, 0, 20, 0, 0], 5) # # Raises error

Error message
Traceback (most recent call last):
  File "<string>", line 6, in <module>
  File "/home/alexander/miniconda3/envs/py37/lib/python3.7/site-packages/scipy/stats/_multivariate.py", line 4726, in rvs
    size=size))
  File "mtrand.pyx", line 3839, in numpy.random.mtrand.RandomState.hypergeometric
ValueError: ngood + nbad < nsample

SciPy/NumPy/Python version information
1.7.3 1.21.5 sys.version_info(major=3, minor=10, micro=4, releaselevel='final', serial=0)

Hi @Alexamk, thank you for reporting. Indeed I can reproduce and agree that this behaviour is confusing.

The problem is here:
https://github.com/scipy/scipy/blob/a6ee381ec61f89e8b43631bb7f3e5ee30e6bda47/scipy/stats/_multivariate.py#L4875-L4878
When n is 0, the result on the right is zero (because of the multiplication by (n != 0), but the function random_state.hypergeometric() is still being evaluated, and in this case the arguments to random_state.hypergeometric() are not valid.

My comment about the arguments being invalid needs some qualification.
If we could rely on random_state being a Generator instance (i.e. if we could ensure that we were using the new NumPy random API instead of the legacy API), we could replace that line with:
            rvs[..., c] = random_state.hypergeometric(m[..., c], rem, n,
                                                      size=size)

n might be 0, but Generator.hypergeometric will do the right thing.  For example,
In [8]: rng = np.random.default_rng()

In [9]: rng.hypergeometric(0, 1, 0)
Out[9]: 0

In [10]: rng.hypergeometric(1, 0, 0)
Out[10]: 0

In [11]: rng.hypergeometric(0, 0, 0)
Out[11]: 0

The reason for the shenanigans with n != 0 and n == 0 is that we have to support the legacy random API (and we have to support broadcasting, so we can't use a simple if statement), and np.random.hypergeometric doesn't allow n == 0:
In [16]: np.random.hypergeometric(0, 1, 0)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Input In [16], in <module>
----> 1 np.random.hypergeometric(0, 1, 0)

File mtrand.pyx:3871, in numpy.random.mtrand.RandomState.hypergeometric()

File _common.pyx:919, in numpy.random._common.disc()

File _common.pyx:436, in numpy.random._common.check_constraint()

ValueError: nsample < 1 or nsample is NaN

The code as written fixes that problem by multiplying the result of random_state.hypergeometric() by (n != 0); this ensures that wherever n is 0, the result is 0.  It passes the argument n + (n == 0) to random_state.hypergeometric() to prevent the ValueError from being raised in that case.  However, we missed the case where both of the first two arguments to hypergeometric() are 0.  In that case, our code does, in effect:
In [18]: np.random.hypergeometric(0, 0, 1)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Input In [18], in <module>
----> 1 np.random.hypergeometric(0, 0, 1)

File mtrand.pyx:3870, in numpy.random.mtrand.RandomState.hypergeometric()

ValueError: ngood + nbad < nsample

One way to fix this is to add (n == 0) to rem in addition to n:
            n0mask = n == 0
            rvs[..., c] = (~n0mask *
                           random_state.hypergeometric(m[..., c],
                                                       rem + n0mask,
                                                       n + n0mask,
                                                       size=size))

The proposed fix sounds good to me @WarrenWeckesser. Do you want to propose the PR @WarrenWeckesser or @Alexamk? If not, I can take this up.

@tirthasheshpatel, I probably wouldn't get to a PR right away, so if you have time now, go for it!


[Core]: Support encode only models by Workflow Defined Engine

PTAL #8453

This is a significant change from our current architecture. We'll consider incorporating this when we refactor our core framework.

As vllm supports more and more models and functions, they require different attention, scheduler, executor, and input output processor. . These modules are becoming increasingly complex, and sometimes new features must be compromised for compatibility. ultimately leading to suboptimal results
With wde, there is no need for one module to be compatible with all functions.
You can always use the workflow to load new modules at the highest level to support new functions.
I hope you like this new architecture @DarkLight1337

It looks nice for sure, but there are many abstractions that are difficult to adopt immediately. If you want us to use this architecture, I suggest that you split this PR up into smaller chunks and gradually refactor over the code base rather than doing everything all at once.

I want to do experiments on the encode only model and integrate it with the existing code only at entrypoints, so that the impact of modifications is minimal.

Do you have any better suggestions? @DarkLight1337

This PR is used as a demonstration. I can modify and resubmit a PR.

Don’t be too anxious
I will improve this PR and support more models and functions.
Until you find a suitable opportunity to merge it in

Do you have any better suggestions? @DarkLight1337

Not really, just do as you have said.

PTAL at #8779 and feel free to add your thoughts.

Hi, as mentioned earlier, there is basically no way we can merge all these changes at once. You should break up this refactoring into multiple stages.

@DarkLight1337
Yes, this submission is to show what functions are needed.
We are discussing how to divide it into multiple stages
and then submit each stage separately to review the code.
This will be a huge project

@DarkLight1337
Although there are many Features in this PR, I think they are all important.
Can you prioritize it based on your understanding?

I suggest you post this in #8779. Personally I am not all that involved with the core framework, so it would be best to let others know what you're planning in detail.

You should list out what are the features in your PR and how they correspond to #8779.

Oh My God

I feel that although this PR has some similarities with #8779, their focus is different and there is no way to compare their features one-to-one.

I'd say your PR focuses on tackling the second goal in #8779 (the new architecture will be extensible and modular). You should explain in detail how this is being achieved (in particular, what type of abstractions you are using?). That way, we can consider those aspects when planning how to refactor the existing code.

Many things are simple to write code but very complicated to explain.
Can you let them look at the code?

Many things are simple to write code but very complicated to explain.
Can you let them look at the code?

The thing is, people don't want to look at 10k lines of code to understand what is going on. If you want them to use this code, it is your responsibility to explain it.

OK, I'll try

Is it okay if I send it like this? Is it too long?
Workflow Definition Engine draft pull request is almost complete and there are almost 10,000 lines of code.
as @DarkLight1337 said:

Hi, as mentioned earlier, there is basically no way we can merge all these changes at once. You should break up this refactoring into multiple stages.

Therefore, we hope to invite more people to participate, including but not limited to providing suggestions, participating in discussions, align with vLLM's V2 engine architecture goals, and discussing how to break it into stages, help review code for future PRs
Let me briefly introduce the content of this PR. Including

what new models need to be supported,
what new features these new models have, and
how engine Architecture needs to support these features flexibly and efficiently.

What new models need to be supported
These models are all from issues and are also very famous:

xlm_roberta
bge-m3
bge-reranker-v2-m3
bert
bge v1.5 family
Snowflake Arctic Embed (Family)
gte-Qwen2

These models is roughly divided into three categories：

Encode only models. (Bidirectional Transformers, causal=False), Often fine-tuned as retriever and reranker etc.
Decode only models. (masked multi-head attention, causal=True). There are two interesting uses:

Output last hidden states as a feature extractor
Decode only retriever （I don't know of a better name），E.g. e5-mistral-7b （The only Embed model currently supported by vllm)
Whether it has been fine-tuned or not, there is almost no difference in the code.

Enable bidirectional. LLM2Vec propose a simple unsupervised approach that can transform any decoder-only LLM into a strong text encoder.

What new features these new models have
What the above three categories have in common is that there is only the prefill stage. In order to make the terminology more precise, prefill only is used below.
You can think of prefill only as encode only fancy writing.
New features:

attention

Prefill only models requires simpler attention implementations, no need to consider kvcache, no decoding phase
We need to support enable_bidirectional flag manually or read hf config automatically, enable bidirectional.

scheduler

Prefill only models requires simpler scheduler, no need to consider kvcache and preemption
Prefill only models, there is no correlation between tasks, so it is easy to implement async scheduling

executer

In order to support async scheduling, model_input_builder needs to be separated from the runner.
The main thread executes scheduling and all CPU processing, and the gpu thread only executes h2d, execution model, d2h
If async scheduling and async execution are implemented, data parallelism is also easy to implement. Data parallelism is more efficient for small models

How engine Architecture needs to support these features flexibly and efficiently.
If you directly add new functions to existing modules, these modules are becoming increasingly complex, and sometimes new features must be compromised for compatibility. ultimately leading to suboptimal results
The most flexible and efficient way to support the prefill only models is to implement different modules for models of different architectures and load the required modules on demand.
I call this architecture Workflow Defined Engine, or WDE for short.
With wde, there is no need for one module to be compatible with all functions. You can use the dynamic loading feature of python to load different modules at the highest level, for different models and different needs.
I divided the Engine into the following modules.

InputProcessor: The llm models inputs strings, the reranker inputs pairs, and the multimodal model input is more complex...
OutputProcessor: The retriever(embedding) models output embeddings, reranker models and classification models output Scores...
ModelInputBuilder: Building model inputs and attention metadata
AttnBackend: Support different AttnBackend and enable bidirectional
Tokenizer: There may be different tokenizers
Executor: Sync\Async\TP\PP\maybe more
Worker & runner: Support different devices\maybe more
EngineArgs: Different models, different config may accept different parameters
maybe more

These can be configured through Workflow, plug and play.This architecture can also flexibly support plug-ins, and developers can load their own modules.
Some models cannot use the common Workflow. When you don’t know where to put the dirty code, you can always create a new workflow and link the model architecture to the new workflow to avoid leaving dirty code everywhere for the sake of compatibility.
PTAL #8453 #8452

Yeah, that should be good enough to start with.

Some models cannot use the common Workflow. When you don’t know where to put the dirty code, you can always create a new workflow and link the model architecture to the new workflow to avoid leaving dirty code everywhere for the sake of compatibility.

Probably need to address this. e.g. which types of models are not supported under this workflow? If it's a large category then we'll have to find a solution to it.

gte-Qwen2

Because gte-Qwen2 and Qwen2 use the same architecture name，Qwen2ForCausalLM. The code looks very sad!
gte-Qwen2 family may have multiple different architectures. The code looks very sad!

gte-Qwen2-1.5B-instruct, Official sample code sentence_transformers usage and Transformers usage does not use enable bidirectional， discussions. I'm not sure if this is a bug
gte-Qwen2-7B-instruct use enable bidirectional

Take a look at the code of gte-Qwen2. Workflow is really the best place to hide these dirty codes.
https://github.com/noooop/vllm/tree/wde_encode_only/vllm/wde/retriever/modelzoo/gte_qwen

how about now

Looks better. You should think about how to adopt this incrementally.

I'll post this and think about “about how to adopt this incrementally” some other time, is that okay?

I'll wait for your confirmation before sending it

@DarkLight1337
are you still online

Sorry was afk, you can post it whenever you like.

@DarkLight1337
I think the first part supporting bert is pretty good, but it's still 6,000 lines of code
PTAL #8964

6000 lines of code support bert, I feel like a clown

@DarkLight1337
#9166 has many similarities with Workflow Defined Engine.
Can you invite @WoosukKwon to participate in the discussion of this PR?

I suggest you comment directly on his PR. You can also join our Slack channel (see README) and ping him.

I suggest you comment directly on his PR. You can also join our Slack workspace (see README) and ping him.

I have a little social fear, maybe next time


Extension causes high cpu load

Issue Type: Performance
Extension Name: jupyter
Extension Version: 2020.11.392013122
OS Version: Windows_NT x64 10.0.19042
VSCode version: 1.51.1

:warning: Make sure to attach this file from your home-directory:
:warning:c:\Users\vtzast\AppData\Local\Temp\ms-toolsai.jupyter-unresponsive.cpuprofile.txt
Find more details here: https://github.com/microsoft/vscode/wiki/Explain-extension-causes-high-cpu-load

Thanks for replying this issue, unfortunately you tried to upload the file.


Repo sync for protected CLA branch

The pull request is created from main637797900903217946 to main to fix git push error for protected CLA branch

@shsagir : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[WIP] Bwt-349

Jira Ticket:
BWT-349
Jira Ticket URL:
https://bcparksdigital.atlassian.net/jira/software/projects/BWT/boards/5?assignee=633db6bb61dbef2805c1f25c&selectedIssue=BWT-349
Description:
This is a description.

duplicated from https://github.com/bcgov/bcparks.ca/pull/396


As a client I want to save the package type without seeing a fatal error in the logs

Describe the bug
Saving a package type on the 'orders' page results in a fatal error
Steps to reproduce this behaviour

Go to 'orders'
Click on 'package type'
Change package type (parcel to mailbox)
Click on 'save'
Red cross on save button

Expected behaviour
The package type should be saved without any issues
Error
PHP Fatal error:  Uncaught TypeError: Return value of OrderSettings::getExtraOptions() must be of the type array, string returned in /home/redacted/public_html/wp-content/plugins/woocommerce-myparcel/includes/admin/OrderSettings.php:465\nStack trace:\n#0 /home/redacted/public_html/wp-content/plugins/woocommerce-myparcel/includes/admin/class-wcmypa-admin.php(589): OrderSettings->getExtraOptions()\n#1 /home/redacted/public_html/wp-includes/class-wp-hook.php(292): WCMYPA_Admin->save_shipment_options_ajax()\n#2 /home/redacted/public_html/wp-includes/class-wp-hook.php(316): WP_Hook->apply_filters()\n#3 /home/redacted/public_html/wp-includes/plugin.php(484): WP_Hook->do_action()\n#4 /home/redacted/public_html/wp-admin/admin-ajax.php(187): do_action()\n#5 {main}\n  thrown in /home/redacted/public_html/wp-content/plugins/woocommerce-myparcel/includes/admin/OrderSettings.php on line 465', referer: https://www.redacted.nl/wp-admin/edit.php?post_type=shop_order
Additional information
Can be recreated with order 539 on our test invironment. Possibly a conflict between shipping options?

This issue is resolved in 4.4.0 of the MyParcel plugin


An idea to improve weekly mode

I propose the next formula to calculate the % of every week:

[Weekly hours spent into the current activity] / [Total hours spent among all activities the current week] * 100
Example:  If this week I've spent 2 hours in lerning chinese, and 8 hours in other activities, then this week the chinese calendar will show 20% because [2/10*100]=20

Why?

This way instead of setting goals, we can study what % of our time we are spending into each activity every week, and use that information to make better decisions. Which is important to achieve goals through an iterative and incremental process.

I don't know if this is goes too far away from what dijo is intended. if so, I'd may create a fork. Let's discuss it! Cheers.

I don't see this being part of the WEEK mode in dijo, the goals of WEEK mode are to summarize habits for every week of the month.
However, this could potentially be a new mode altogether, that aggregates data for a time span and displays a comparison between habits. I am thinking along the lines of this play style graph from DotA 2.
Also, I personally use dijo to track things like "waking up early", which doesn't quite fit into this process of figuring out goals iteratively (I would want to reach this goal everyday regardless of my other habits).

That could be cool too! As CEO of a startup, being aware of where I spend time is critical.


Failed to execute 'setRequestHeader' on 'XMLHttpRequest' when form fields have a new line/certain UTF-8 chars

Hi there,
I am trying to submit a form with a multi-line text area, using my service as follows:
baseSites.customPUT(site, site.name);
I am using a Request Interceptor for token authorisation as follows:
 function AuthInterceptor(API, AuthService, $state) {
    return {
      request: function (headers, params, element, httpConfig) {
        headers = headers || {};
        var token = AuthService.GetToken();
        var config = httpConfig.indexOf(API) === 0;

        if (config && token) {
          headers['Authorization'] = 'JWT ' + token;
          //console.log("Headers current are", headers);
        }
        return {
          headers: headers
        }
      },

At the line "Headers currently are," the following is printed:
Authorization:"JWT ... etc."
description:"Li Europan lingues es membres del s↵↵am familie.Lor separat existentie es un Li Europan lingues es membres del sam familie.Lor separat existentie"
id:103
... etc.

The form is submitted with no issue when there are no line returns. When there are line returns (↵↵), or certain (?) UTF-8 chars for that matter, I get the following error:
angular.js:12783 Error: Failed to execute 'setRequestHeader' on 'XMLHttpRequest':

'Li Europan lingues es membres del s

am familie.Lor separat existentie es un Li Europan lingues es membres del sam familie.Lor separat existentie'

is not a valid HTTP header field value.

From searching I see other people who get this error are often using non-English or other UTF-8 characters, but:

they are not using Restangular
they fix this by removing these fields from their headers directly (http://stackoverflow.com/questions/24326885/failed-to-execute-setrequestheader-on-xmlhttprequest-is-not-a-valid-ht)

I am not sure how to do this with Restangular, or if that will actually help.
Also setting the headers to have any variant of the following does not appear to help:
Content-type: application/json; charset=utf-8
Accept: application/json Accept-Charset: utf-8
Accept: application/json;charset=utf-8
Any help would be appreciated, thanks.
Versions:
"angular": "^1.4.0",
"restangular": "^1.5.2",
"resolutions": {
    "angular": "^1.0.8",
    ...
},

Chome Version 49.0.2623.87 m

Urg, from doing more searching it would appear Chrome throws up this error when submitting Unicode values greater than (U+00FF) (ÿ): https://bugs.chromium.org/p/chromium/issues/detail?id=319694#c12 but the unicode char in question: http://www.fileformat.info/info/unicode/char/21B5/index.htm
(U+21B5) (↵).
Alternatively, is there any way to use Restangular to still POST but without having the data explicitly in the HTTP header for server-side parsing? Or would wrapping my form fields in a 'data' object still cause the same problem?
As submitting form data with line breaks should be so seemingly common, is there a way to do this with \n rather than ↵?

Were you able to fix this problem? It seems like you were going to try a workaround. Did that work?


congr does not realize that opt-params are vacuous dependencies

The following used to work in Lean 3:
class Preorder (α : Type u) extends LT α :=
(le : α → α → Prop)
(lt_iff_le_not_le : ∀ a b : α, lt a b ↔ (le a b ∧ ¬ le b a) := by intros; rfl)

theorem Preorder.toLE_injective (A B : Preorder α) (h : A.le = B.le) : A = B := by
  cases A; cases B; cases h
  congr -- does not make progress, should produce a goal for `A.lt = B.lt`

(It's probably related to the subobject inheritance of LT α, the congr tactic makes progress if the lt field is inlined.)

Reported on Zulip: https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Equality.20of.20structures.20with.20autoparams/near/308446269

It's probably related to the subobject inheritance of LT α, the congr tactic makes progress if the lt field is inlined.

Correct.
theorem Preorder.toLE_injective (A B : Preorder α) (h : A.le = B.le) : A = B := by
  cases A; cases B; cases h
  rename LT α => lt; cases lt
  rename LT α => lt; cases lt
  congr -- makes progress

I can see this issue happening in many Mathlib proofs being ported to Lean 4. The flat representation used in the old Lean 3 structure command is ideal for congr.
The first idea/hack that comes to mind is special support in congr for structure constructors. I think it is a defensible hack since we try to provide the illusion that we have a "flat" representation in other places. What do you think?

Now I also see what's going on.  Yeah, special support for structure constructors in congr lemmas is the best O can think of too.
The issue also pops up with simp: https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/unfolding.20earlier.20fields/near/302587283


Readme example is incorrect

Passing a gravity parameter to cannon.world initializer doesn't work, you need to call world.gravity.set.
:(

// Setup our world
var world = new CANNON.World({
   gravity: new CANNON.Vec3(0, 0, -9.82) // m/s²
});
world.gravity.set(0, 0, -20);

Fixed the readme and quickly added that feature. Will revert the example on next release.
Thanks!


KAFKA-12561: don't set timeout for future.get

These tests failed quite often, because of TimeoutException. We cannot get the future result in time. I think the flaky tests tell us that we should not expect the results will return as soon as we expected in jenkins. Like other tests, we don't usually set timeout when future.get, so remove the timeout setting to make this test reliable.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mumrah , @hachikuji , could you review this PR? It failed a lot in recent builds. Thanks.

@mumrah , @hachikuji , could you review this PR? It keeps failing recent builds. Thanks.

@showuon Could you merge trunk to trigger QA again? I'd like to merge it if QA pass :)

kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch() is traced by #10389 and ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit is unrelated flaky. will merge to trunk

@showuon thanks for this fix!


Could There Be Rustfmt Plugins for Allowing For Custom Macros to be Formatted?

Rust's macro_rules! macros are awesome for creating custom syntaxes in Rust, but one of the biggest disadvantages to a custom syntax is the lack of support ( totally understandably ) for formatting custom syntaxes. I was considering the use-case of creating a custom syntax similar to Vue.js single-file components, including an HTML-like syntax, but if there was no option for formatting such a syntax that would be a big disadvantage compared to the tooling provided by solutions like Vue and their editor plugins.
Would it be possible to create Rustfmt plugins, possibly using WASM, that would allow adding formatters for custom macro syntaxes? It seems like the API could be very simple:

A plugin registers the macros that it knows how to format
Rustfmt will feed the code for those macros to the formatter plugin
The formatter plugin returns the formatted version of those macros

I might mess around with this in my freetime if there was some buy-in that this is something that could be accepted. Any ideas for better ways to solve this problem?

An alternative I considered was using IDE plugins to stack on top of rustfmt, but that would be sub-optimal and would require adding the formatting support to multiple IDE's instead of setting the plugin up with Rustfmt and automatically getting support for all IDEs that support Rustfmt.

Edit: This would also be useful for function-like proc macros with custom syntaxes, but rustfmt probably wouldn't have any way/reason/need to tell the difference between macro rules macros and proc macros.

Thanks for sharing your well thought out suggestion! I'll go ahead with the bad news up front and say that this isn't something I'm willing to consider at this time so I am closing.
I realize that rustfmt's support for macros is quite poor today, and that the suggestion was made to specifically address that gap. However, the core goal of rustfmt is to reformat all code against the standard Rust Style Guide with the broader goal of having a consist style for Rust code across the ecosystem. rustfmt is not supposed to be a generalized formatting platform to facilitate the application of other formatting paradigms.
Doing so would be a slippery slope, both because of the impact on the rustfmt maintenance/support, bug surface, etc. as well as for the inevitable subsequent use cases that would want to leverage such a plugin system beyond macros.

Any ideas for better ways to solve this problem?

rustfmt utilizes the parsed AST provided by rustc for determining the formatted output to emit. This is somewhat oversimplified but in the case of encountering a mac call while traversing the tree, rustfmt will see if the associated tokens can be parsed and formatted as normal rust code; if so then the standard formatting rules for that parsed node are applied, otherwise rustfmt largely ignores and leaves the original in place.
The general consensus for improved macro formatting would be to do more work with the token streams directly as opposed to that current approach. No small task!

Thanks again for reaching out!

Thanks for the reply @calebcartwright ! I can see how that could be difficult and how it does sort of open a "philosophical" issue as to what rustfmt's role is in the ecosystem. That makes sense.
That being the case I'll probably look around for tools that are a better match for, as you say, a formatting platform. That could have an integration for Rust and macros somehow. Thanks for a well-explained reply! :slightly_smiling_face:


Shitty code

Needs to be rewritten while NOT drunk:

Much more universal DOM based HTML parsing
More statistics

Now 20% less shitty!

I do no longer have access to the fahrschulcard website.

how can i get it ??


HADOOP-17371. Bump Jetty to the latest version 9.4.34. Contributed by Wei-Chiu Chuang.

NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
32m  2s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 54s

trunk passed

+1 :green_heart:
compile
0m 16s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 16s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
mvnsite
0m 20s

trunk passed

+1 :green_heart:
shadedclient
53m 23s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 18s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 18s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 11s

the patch passed

+1 :green_heart:
compile
0m 10s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 10s

the patch passed

+1 :green_heart:
compile
0m 10s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
javac
0m 10s

the patch passed

+1 :green_heart:
mvnsite
0m 13s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

-1 :x:
shadedclient
16m 48s

patch has errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 14s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

_ Other Tests _

+1 :green_heart:
unit
0m 13s

hadoop-project in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

107m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2453

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml

uname
Linux e690fbffd490 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4331c88352d

Default Java
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/1/testReport/

Max. process+thread count
358 (vs. ulimit of 5500)

modules
C: hadoop-project U: hadoop-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/1/console

versions
git=2.17.1 maven=3.6.0

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  4s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m  0s

trunk passed

+1 :green_heart:
compile
20m 21s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
17m 19s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
mvnsite
1m 15s

trunk passed

+1 :green_heart:
shadedclient
90m 46s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

_ Patch Compile Tests _

+0 :ok:
mvndep
1m  1s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 36s

the patch passed

+1 :green_heart:
compile
19m 21s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
19m 21s

the patch passed

+1 :green_heart:
compile
17m 21s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
javac
17m 21s

the patch passed

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 34s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 11s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 11s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

_ Other Tests _

+1 :green_heart:
unit
0m 34s

hadoop-project in the patch passed.

+1 :green_heart:
unit
0m 36s

hadoop-client-minicluster in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

161m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2453

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml

uname
Linux ed59d4423fb5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 61f8c5767e8

Default Java
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/2/testReport/

Max. process+thread count
545 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-client-modules/hadoop-client-minicluster U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/2/console

versions
git=2.17.1 maven=3.6.0

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The latest one is good. @aajisaka do you want to take another look?

No unit tests run in the Jenkins job. I'll run the unit tests in hadoop-common module locally before +1.

In addition, TestKMS failed.

Ok... so this is getting more involved. It turns out that Jetty 9.4.21 has a breaking change (https://github.com/eclipse/jetty.project/pull/3912/files)
Previously, our o.h.a.s.authentication.server.AuthenticationFilter sends a custom message associated with 401 error. After 9.4.21, Response.sendError() no longer allows a custom error message. You have to call Response.setStatusWithReason() to set that. But that requires an additional dependency on jetty-server.
I don't feel that strong to include jetty-server just so that we can set a custom error message. We could update the test code instead too.

(The above update addresses the issue with TestPseudoAuthenticator. Still trying to understand TestKMS errors...

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
2m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
14m 47s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 16s

trunk passed

+1 :green_heart:
compile
21m 42s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
18m  6s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
checkstyle
2m 48s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
shadedclient
21m 53s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+0 :ok:
spotbugs
0m 26s

Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 29s

branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 26s

branch/hadoop-client-modules/hadoop-client-minicluster no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 56s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 57s

the patch passed

+1 :green_heart:
compile
22m 54s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
22m 54s

the patch passed

+1 :green_heart:
compile
19m 17s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
javac
19m 17s

the patch passed

-0 :warning:
checkstyle
2m 58s
/diff-checkstyle-root.txt
root: The patch generated 2 new + 34 unchanged - 0 fixed = 36 total (was 34)

+1 :green_heart:
mvnsite
1m 27s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
18m 59s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 47s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 42s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+0 :ok:
findbugs
0m 32s

hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 32s

hadoop-client-modules/hadoop-client-minicluster has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 33s

hadoop-project in the patch passed.

-1 :x:
unit
4m  5s
/patch-unit-hadoop-common-project_hadoop-auth.txt
hadoop-auth in the patch passed.

+1 :green_heart:
unit
0m 33s

hadoop-client-minicluster in the patch passed.

+1 :green_heart:
asflicense
1m  1s

The patch does not generate ASF License warnings.

196m 13s

Reason
Tests

Failed junit tests
hadoop.security.authentication.server.TestAuthenticationFilter

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2453

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux c48398c3106e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e6d2dccbef6

Default Java
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/3/testReport/

Max. process+thread count
513 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-auth hadoop-client-modules/hadoop-client-minicluster U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.1.3

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 43s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m  1s

trunk passed

+1 :green_heart:
compile
22m 28s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 19s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
2m 47s

trunk passed

+1 :green_heart:
mvnsite
2m  1s

trunk passed

+1 :green_heart:
shadedclient
20m 56s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 33s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 29s

Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 34s

branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 29s

branch/hadoop-client-modules/hadoop-client-minicluster no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 57s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 26s

the patch passed

+1 :green_heart:
compile
20m 50s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
20m 50s

the patch passed

+1 :green_heart:
compile
18m 58s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
18m 58s

the patch passed

+1 :green_heart:
checkstyle
2m 40s

the patch passed

+1 :green_heart:
mvnsite
1m 47s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 37s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 40s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
findbugs
0m 31s

hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 31s

hadoop-client-modules/hadoop-client-minicluster has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 30s

hadoop-project in the patch passed.

+1 :green_heart:
unit
3m 21s

hadoop-auth in the patch passed.

+1 :green_heart:
unit
0m 35s

hadoop-client-minicluster in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

187m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2453

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux a1cb884125ec 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a35fc3871b0

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/4/testReport/

Max. process+thread count
535 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-auth hadoop-client-modules/hadoop-client-minicluster U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 43s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 32s

trunk passed

+1 :green_heart:
compile
22m 24s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
18m 58s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
2m 35s

trunk passed

+1 :green_heart:
mvnsite
2m 16s

trunk passed

+1 :green_heart:
shadedclient
20m 51s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 29s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
2m 22s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 36s

Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 38s

branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 36s

branch/hadoop-client-modules/hadoop-client-minicluster no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 58s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 23s

the patch passed

+1 :green_heart:
compile
19m 21s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m 21s

the patch passed

+1 :green_heart:
compile
17m 21s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m 21s

the patch passed

+1 :green_heart:
checkstyle
2m 33s

the patch passed

+1 :green_heart:
mvnsite
2m 40s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s

The patch has no ill-formed XML file.

-1 :x:
shadedclient
15m 41s

patch has errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 30s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
2m 27s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
findbugs
0m 36s

hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 38s

hadoop-client-modules/hadoop-client-minicluster has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 34s

hadoop-project in the patch passed.

+1 :green_heart:
unit
3m 22s

hadoop-auth in the patch passed.

+1 :green_heart:
unit
3m 39s

hadoop-kms in the patch passed.

+1 :green_heart:
unit
0m 36s

hadoop-client-minicluster in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

193m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2453

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 212f1d2c6a10 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a35fc3871b0

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/5/testReport/

Max. process+thread count
543 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-kms hadoop-client-modules/hadoop-client-minicluster U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

TestPseudoAuthenticator, TestAuthenticationFilter and TestKMS are fixed in the last PR.

(and apparently updating to 9.4.35 brought more unshaded files which I'll look into)

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 54s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 50s

trunk passed

+1 :green_heart:
compile
20m  7s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 19s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
2m 40s

trunk passed

+1 :green_heart:
mvnsite
2m 43s

trunk passed

+1 :green_heart:
shadedclient
21m 16s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
2m 21s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 36s

Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 40s

branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 36s

branch/hadoop-client-modules/hadoop-client-minicluster no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 57s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 24s

the patch passed

+1 :green_heart:
compile
19m 22s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m 22s

the patch passed

+1 :green_heart:
compile
17m 15s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m 15s

the patch passed

+1 :green_heart:
checkstyle
2m 38s

the patch passed

+1 :green_heart:
mvnsite
2m 40s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 37s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 31s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
2m 28s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
findbugs
0m 35s

hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 36s

hadoop-client-modules/hadoop-client-minicluster has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 34s

hadoop-project in the patch passed.

+1 :green_heart:
unit
3m 38s

hadoop-auth in the patch passed.

+1 :green_heart:
unit
3m 41s

hadoop-kms in the patch passed.

+1 :green_heart:
unit
0m 35s

hadoop-client-minicluster in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

189m 20s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2453

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux 0a3d5ff70760 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 16a20503cac

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/6/testReport/

Max. process+thread count
668 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-kms hadoop-client-modules/hadoop-client-minicluster U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/6/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thank you for the work here everyone.
Jetty Upgrade can cause failure of  TestCheckpoint and TestWebHdfsWithRestCsrfPreventionFilter as well.
sendError() is used in bothRestCsrfPreventionFilter.java and ImageServlet.java, we can setStatusWithReason() to resolve these failures too.

@Sushmasree-28 thanks for the review. I updated the PR to address these two tetsts. However, please note that we use sendError() throughout the codebase. Unless they break tests I suggest we postpone any further changes to a future jira.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m  5s

trunk passed

+1 :green_heart:
compile
20m  3s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 21s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
2m 41s

trunk passed

+1 :green_heart:
mvnsite
5m 45s

trunk passed

+1 :green_heart:
shadedclient
24m 27s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
4m 41s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
5m 37s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
0m 37s

Used deprecated FindBugs config; considering switching to SpotBugs.

+0 :ok:
findbugs
0m 39s

branch/hadoop-project no findbugs output file (findbugsXml.xml)

+0 :ok:
findbugs
0m 36s

branch/hadoop-client-modules/hadoop-client-minicluster no findbugs output file (findbugsXml.xml)

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 58s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 34s

the patch passed

+1 :green_heart:
compile
19m 26s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m 26s

the patch passed

+1 :green_heart:
compile
17m 26s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m 26s

the patch passed

+1 :green_heart:
checkstyle
2m 37s

the patch passed

+1 :green_heart:
mvnsite
5m 44s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  4s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 33s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
4m 38s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
5m 44s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
findbugs
0m 36s

hadoop-project has no data from findbugs

+0 :ok:
findbugs
0m 46s

hadoop-client-modules/hadoop-client-minicluster has no data from findbugs

_ Other Tests _

+1 :green_heart:
unit
0m 36s

hadoop-project in the patch passed.

+1 :green_heart:
unit
3m 23s

hadoop-auth in the patch passed.

+1 :green_heart:
unit
9m 38s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m 42s

hadoop-kms in the patch passed.

-1 :x:
unit
97m 23s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
0m 46s

hadoop-client-minicluster in the patch passed.

+1 :green_heart:
asflicense
1m  7s

The patch does not generate ASF License warnings.

328m 31s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.balancer.TestBalancer

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2453

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle

uname
Linux ddd9ff857aea 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 513f1995adc

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/8/testReport/

Max. process+thread count
4068 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms hadoop-hdfs-project/hadoop-hdfs hadoop-client-modules/hadoop-client-minicluster U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2453/8/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The failed test is this "TestBalancer.testMaxIterationTime:1669 Unexpected iteration runtime: 4007ms > 3.5s"
this kind of time measuring tests are prone to transient failures. Don't think it's related.