Incompatible with create-react-app ?

Hello there,
I have a strange problem. I'm trying to use react-grid-layout on my app and it's doing basically nothing, so I thought that I should try something smaller to isolate what I'm doing wrong.
So I've created a brand new app, empty, using create-react-app. Then I did the following changes :

Install react-grid-layout using npm
Copy both stylesheet in a single one located in the public folder (I'll explain why later)
Put this code in the index.js file :

import React from "react";
import ReactDOM from "react-dom";
import GridLayout from "react-grid-layout";

class MyFirstGrid extends React.Component {
  render() {
    // layout is an array of objects, see the demo for more complete usage
    const layout = [
      { i: "a", x: 0, y: 0, w: 1, h: 2, static: true },
      { i: "b", x: 1, y: 0, w: 3, h: 2, minW: 2, maxW: 4 },
      { i: "c", x: 4, y: 0, w: 1, h: 2 }
    ];
    return (
      <GridLayout
        className="layout"
        layout={layout}
        cols={12}
        rowHeight={30}
        width={1200}
      >

a

b

c

      </GridLayout>
    );
  }
}

const contentDiv = document.getElementById("root");
ReactDOM.render(React.createElement(MyFirstGrid), contentDiv);

As you can see, I've basically copy/pasted the very first example of the readme. Now when I use npm start to try and test my application... nothing works. Like, there is an "a", "b" and "c" div displayed, one above the other, and the usual logging when I try to drag them, but no grid whatsoever.
Now you may ask, why copying the two css files in one and include them in my html file ? Well, that's because when I started writing this issue, I tried to reproduce it in a codesandbox... and overthere everything is working fine. I checked the versions of react / react-grid-layout / react-dom in codesandbox and set them to the one in a fresh out-of-the-box install, still working fine.
So I don't really know what's going wrong here. As I said, the code is basically the simpler example I can think of, nothing was changed at all from following the doc after creating a fresh app, so my guess is there is something I'm missing in the documentation that I should do to make it works, but I can't think of what is could be...
Since I can't reproduce on codesandbox, I created a repository to demonstrate the issue here : https://github.com/Exanis/react-grid-layout-strange
The second commit let you outline all my changes (I did a few tests so there are some files in addition to what I mentionned here but they shouldn't change anything).
Any idea ? :s
Thank you !

@Exanis try with 0.17.1 version

@Exanis try with 0.17.1 version

Using version 0.17.1 seems to fix at least a part of the issue, thank you ! :)

I'm using this very extensively with CRA and it works fine. Currently on the latest version 0.18.3.


Core Set Updates

Synergize: Now uses the new "Synergy" keyword, which is the same as the card's previous condition, just wrapped up into a keyword instead of three lines of text.
Backpack Smack: Reworked to be an X-cost card.  Deals 6 damage per energy spent.  Has Synergy: Gain 1 Energy.
Showoff: Block reduced by 1.
Ripped Pecs: Reworked to now gain 1 Strength, plus another 2(3) if you have Synergy.
Smithing Hammer: Damage reduced to 3x2, upgrading to 3 hits on upgrade, but always upgrades 2 random cards instead of 1(2).

Changes submitted.


HTTP Error 500: Internal Server Error for a particular video that works on a browser

Checklist

[ x ] I'm reporting a broken site support issue
[ x ] I've verified that I'm running youtube-dl version 2020.01.24
[ x ] I've checked that all provided URLs are alive and playable in a browser
[ x ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[ x ] I've searched the bugtracker for similar bug reports including closed ones
[ x ] I've read bugs section in FAQ

Verbose log

E:\DalyMues>youtube-dl -v https://www.youtube.com/watch?v=GqNVOBrNa8A
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.youtube.com/watch?v=GqNVOBrNa8A']

[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.01.24
[debug] Python version 3.4.4 (CPython) - Windows-XP-5.1.2600-SP3
[debug] exe versions: none
[debug] Proxy map: {}
[youtube] GqNVOBrNa8A: Downloading webpage
[youtube] GqNVOBrNa8A: Downloading video info webpage
[youtube] GqNVOBrNa8A: Downloading MPD manifest
[debug] Default format spec: best/bestvideo+bestaudio
[debug] Invoking downloader on 'https://r3---sn-5uaeznyz.googlevideo.com/videopl
ayback?expire=1581812436&ei=dDZIXujHMoSl4QTPkbCACQ&ip=<IP_ADDRESS>&id=o-ABuDKSa
K_jFZ6G7BGhhEVCeMCQGlcSw0H-2u1OaLp73q&itag=22&source=youtube&requiressl=yes&mm=3
1%2C26&mn=sn-5uaeznyz%2Csn-p5qs7n76&ms=au%2Conr&mv=m&mvi=2&pl=20&initcwndbps=212
5000&vprv=1&mime=video%2Fmp4&ratebypass=yes&dur=14.210&lmt=1473332275980992&mt=1
581790725&fvip=3&fexp=23842630&c=WEB&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csour
ce%2Crequiressl%2Cvprv%2Cmime%2Cratebypass%2Cdur%2Clmt&sig=ALgxI2wwRAIgDioboW3bf
tsOjL2GbYzRzigpsLwU_MP_ba6RqMahezkCIAPRmmnK8G6rWqwD1dyDd6gBfHBnbfzDfkwNXXrMx90u&
lsparams=mm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AHylml4wRgIhAMDv_6f-xMV
7vGGv-YjR7Gcf1Z3-1k_d_fIibc4NB4yHAiEAid0L3X0DUaIKHnOqWyw5sM2xZfSETLhkbt2F-sdKNDY
%3D'
[download] Got server HTTP error: HTTP Error 500: Internal Server Error. Retryin
g (attempt 1 of 10)...
[download] Got server HTTP error: HTTP Error 500: Internal Server Error. Retryin
g (attempt 2 of 10)...
[download] Got server HTTP error: HTTP Error 500: Internal Server Error. Retryin
g (attempt 3 of 10)...
[download] Got server HTTP error: HTTP Error 500: Internal Server Error. Retryin
g (attempt 4 of 10)...
[download] Got server HTTP error: HTTP Error 500: Internal Server Error. Retryin
g (attempt 5 of 10)...
[download] Got server HTTP error: HTTP Error 500: Internal Server Error. Retryin
g (attempt 6 of 10)...
[download] Got server HTTP error: HTTP Error 500: Internal Server Error. Retryin
g (attempt 7 of 10)...
[download] Got server HTTP error: HTTP Error 500: Internal Server Error. Retryin
g (attempt 8 of 10)...
[download] Got server HTTP error: HTTP Error 500: Internal Server Error. Retryin
g (attempt 9 of 10)...
[download] Got server HTTP error: HTTP Error 500: Internal Server Error. Retryin
g (attempt 10 of 10)...
ERROR: giving up after 10 retries
  File "__main__.py", line 19, in <module>
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\__init__.py", line 474, in main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\__init__.py", line 464, in _real_main
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\YoutubeDL.py", line 2018, in download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\YoutubeDL.py", line 807, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\YoutubeDL.py", line 862, in process_ie_result
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\YoutubeDL.py", line 1643, in process_video_result
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\YoutubeDL.py", line 1925, in process_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\YoutubeDL.py", line 1864, in dl
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\downloader\common.py", line 366, in download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\downloader\http.py", line 353, in real_download
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\downloader\common.py", line 165, in report_error
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\YoutubeDL.py", line 624, in report_error
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpw0w300
z1\build\youtube_dl\YoutubeDL.py", line 586, in trouble

E:\DalyMues>

Description

This particular video on this particular channel (DalyMues) will not download, and gives this error every time. The video link is here: https://www.youtube.com/watch?v=GqNVOBrNa8A It will give me an HTTP 500 error so stubbornly, even though the video is clearly visible to me on a browser. The JSON file was able to download for it earlier but the video will not download.

Server side youtube error. Select another format.


[osg] Disable conditional plugins.

Resolves nightly CI failure:
       "D:\buildtrees\osg\x86-windows-dbg\install.vcxproj" (default target) (1) ->
       "D:\buildtrees\osg\x86-windows-dbg\ALL_BUILD.vcxproj" (default target) (3) ->
       "D:\buildtrees\osg\x86-windows-dbg\src\osgPlugins\OpenCASCADE\osgdb_opencascade.vcxproj" (default target) (54) ->
       (ClCompile target) ->
         D:\buildtrees\osg\src\raph-3.6.5-0028e69d98.clean\src\osgPlugins\OpenCASCADE\ReaderWriterOpenCASCADE.cpp(214,49): error C2039: 'Nodes': is not a member of 'Poly_Triangulation' [D:\buildtrees\osg\x86-windows-dbg\src\osgPlugins\OpenCASCADE\osgdb_opencascade.vcxproj]

Opencascade disabled because it's broken.
All others disabled because they were behind some kind of if (XXX_found) in src\osgPlugins\CMakeLists.tx, except, Quicktime left alone because that's part of MacOS?

BTW the trigger for the CI failure was having opencascade installed first.


first draft of run_ir

franzm created the following on May 23:
The point here is to share run_ir.py which will allow to specify the engine (B25, DPR, ColBERT, etc.) and operation (training, indexing, search) by command line arguments.
The ColBERT part is functional, but could be streamlined.  The main principle was to minimize the changes in the core ColBERT code, to make it easier to use updates from Stanford.
Please comment on whether you see this as a path forward.
Original issue: https://github.ibm.com/ai-foundation/PrimeQA/pull/212

duplicate #65


Ads placed in ListView is getting impression before they appear on the screen in Flutter 3

Hi, I originally posted this here https://github.com/googleads/googleads-mobile-flutter/issues/269#issuecomment-1059741368, before the new Android PlatformView implementation was merged with the stable channel, but this issue is now in Flutter 3 stable channel.
With the new Android PlatformView implementation, banner placed in ListView is getting impression before it appears on the screen.
This conflicts with Admob policy. (https://support.google.com/admob/answer/3269069?hl=en)
In the previous version, getting impression only when the first pixel of banner is seen on the screen.
This is a critical issue, apps using this plugin with Flutter 3 can be banned by Admob, because technically you are creating fake impressions with this implementation.
Steps to Reproduce
To reproduce, try this example code with Flutter 3, plugin version doesn't matter.
class MyApp extends StatefulWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: ListView.builder(
        itemCount: 15,
        itemBuilder: (context, index) {
          if (index != 0 && index % 5 == 0) {
            return const _BannerAd();
          }

          return Container(
            height: 200,
            color: Color((Random().nextDouble() * 0xFFFFFF).toInt())
                .withOpacity(1),
          );
        },
      ),
    );
  }
}

class _BannerAd extends StatefulWidget {
  const _BannerAd({Key? key}) : super(key: key);

  @override
  _BannerAdState createState() => _BannerAdState();
}

class _BannerAdState extends State<_BannerAd>
    with AutomaticKeepAliveClientMixin {
  @override
  bool get wantKeepAlive => true;

  late BannerAd myBanner;

  @override
  void initState() {
    super.initState();
    myBanner = BannerAd(
      adUnitId: BannerAd.testAdUnitId,
      size: AdSize.banner,
      request: const AdRequest(),
      listener: BannerAdListener(
        onAdLoaded: (ad) => print('Ad loaded.'),
        onAdFailedToLoad: (ad, error) {
          ad.dispose();
          print('Ad failed to load .');
        },
        onAdOpened: (ad) => print('Ad opened.'),
        onAdClosed: (ad) => print('Ad closed.'),
        onAdImpression: (ad) => print('Ad impression.'),
      ),
    )..load();
  }

  @override
  void dispose() {
    myBanner.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    super.build(context);

    return Container(
      width: myBanner.size.width.toDouble(),
      height: myBanner.size.height.toDouble(),
      margin: const EdgeInsets.all(20),
      alignment: Alignment.center,
      child: AdWidget(ad: myBanner),
    );
  }
}

Expected results: Ads placed in the ListView should get impression when they appear on the screen.
Actual results: All ads in ListView are simultaneously get impression when the ListView is built.

Hi @ilkanimal, Thanks for filing the issue.  The code sample looks fine, I will leave this issue for further investigation from the team.

@bparrishMines could someone from the Flutter team could take a look at this issue?
I confirmed that this issue does not happen until cl/439863832, so most likely it's from the changes in https://github.com/flutter/flutter/pull/100091.
Previously the platform view is not attached until it becomes visible: https://screenshot.googleplex.com/BXdAFvVhNKFNzv8.
Now the platform view is rendered off screen: https://screenshot.googleplex.com/8HHAMwoqaAeHQwz, and if you register a ViewTreeObserver.OnGlobalLayoutListener on the platform view, you can see that the android system thinks the view is visible on the initial render.

@jjliu15 @bparrishMines also, impressions do not work correctly during navigation.
I have two lists on different screens that are synchronized to each other, and when I navigate to next screen and scroll the list, the ads on the previous screen continue to get impressions.
In a more common scenario, a video ad on the previous screen might keep playing until the end and get impression, which is technically a fraud.
I think there is a general lack of visibility states in this new PlatformView implementation.

Adding flutter label based on https://github.com/googleads/googleads-mobile-flutter/issues/580#issuecomment-1178384351

@jjliu15 You may be able to temporarily fix this by changing the default Android surface back to Hybrid Composition. You can change the line at: https://github.com/googleads/googleads-mobile-flutter/blob/main/packages/google_mobile_ads/lib/src/ad_containers.dart#L649 to use initExpensiveAndroidView instead of initSurfaceAndroidView.
Our team is still looking into the bugs caused by the new Android PlatformView implementaiton.

@bparrishMines I think using initExpensiveAndroidView for this package is not a good workaround because it causes a performance issue that makes apps almost unusable.
Those who are concerned about this issue can find a temporary solution using the visibility_detector package. You can still preload the ad but only show the AdWidget when visibleFraction > 0.01. This is not a sure solution, but it can keep the impression numbers at levels that would not make the Google Admob AI suspicious.

Also, this issue https://github.com/googleads/googleads-mobile-flutter/issues/608 is probably TLHC related. Clicking on the AdWidget in the ListView causes the Invalid click coordinates detected. error. However, if I don't put AdWidget in ListView and put it in Expanded to fill the screen, it doesn't cause the same error.

Version 2.0.1 added the visibility_detector workaround mentioned in https://github.com/googleads/googleads-mobile-flutter/issues/580#issuecomment-1184149961. Could you help verify if this fixes the issue?

News?

@jjliu15 is the AdView only visible on the initial render? It looks like we are using a default value of (0.0, 0.0) for the initial placement of the view: https://github.com/flutter/engine/blob/main/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java#L121

@bparrishMines  I tried checking out https://github.com/bparrishMines/flutter/tree/current_engine_main and commenting out the changes in https://github.com/googleads/googleads-mobile-flutter/pull/610/files. I'm still seeing the impression occur before the ad is scrolled into view.

Hmm, thats interesting. I'll check to verify that the Ad is being placed in the right position in the engine. Also, how are you testing for impressions? Are you using the AdListener callback?

I was using that as well, but I noticed that callback was being triggered before the platform view was even created. If you switch it to Hybrid Composition (initExpensiveAndroidView), the callback triggers before any of the platform view code runs too.

@bparrishMines You're right. The ad response return from the Admob banner test ad unit actually uses a loaded impression definition and always fires the impression when the ad loads. However the AdManagerBannerAd and NativeAd test ads use a normal 1px impression, and I was originally able to reproduce the issue with those ads. However I'm no longer able to reproduce the issue with those ad types.
I've also tried checking out older versions of flutter (3.0.0) and the plugin (2.0.0) and have not been able to reproduce the issue anymore.
However the issue is still reproducible in Google3, using blaze to run the test app (see cl/463890301). I'm not sure yet what's changed that's causing it to pass now on my local mac env vs in Google3.

@bparrishMines I did some more testing and have confirmed that https://github.com/bparrishMines/flutter/tree/current_engine_main fixes the issue.
You can also verify by checking out https://github.com/jjliu15/googleads-mobile-flutter-1/tree/impression_bug and running the example app.
After removing the visibility workaround and using flutter:stable the current behavior is:

The test BannerAd uses a loaded impression definition, so it should not be used for testing this issue
If you slowly scroll the AdManagerBannerAd and NativeAd into view, you'll see that their impressions are fired about half a screen before they are actually visible

After removing the visibility workaround and using https://github.com/bparrishMines/flutter/tree/current_engine_main, the impressions occur when the ad views are scrolled into view.

is it fixed now?

@jjliu15 @bparrishMines @stuartmorgan
Will this fix https://github.com/flutter/flutter/pull/114103 be included in the next stable release? This issue has been going on for more than two quarters and it's a serious revenue loss issue as show rates have dropped significantly due to the current workaround.
Thanks for your work.

Will this fix flutter/flutter#114103 be included in the next stable release?

Yes.

The release cadence for stable is explained here.

Hi, since this issue is expected to be closed with the new Flutter stable release, I think there should be an opt-out option for the current workaround.
I have filed an issue here: https://github.com/googleads/googleads-mobile-flutter/issues/754

Version 2.4.0 has been released with an opt-out flag for the fix on Flutter 3.7.0+.
https://pub.dev/packages/google_mobile_ads/changelog

I can still see the issue, I get the ad impression before like 3 tiles before the AdWidget tile comes into view inside the ListView. I get the same result with or without the opt-out option.

As @KristijanZic mentioned above I am also facing the same issue where in a listview.builder. where if the ads are within 4 or 5 list items they are being said to be already already present in the 'widget tree' and requires to create a new instance, where as the next loaded add will work just fine and will not so any issue. I can provide a copy of my code file if any one can help me with this issue.


MM-6843 Update at-mention sort

Summary
Change at-mention autocomplete to prioritize entries where the username starts with the search string
Ticket Link
https://github.com/mattermost/mattermost-server/issues/6699

@pqzx Let me know, when this is ready for review

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-4063.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

QA Note - the ticket notes that QA should be on the search and DM search.  This PR adds for the  @-mention post/message box (added a corresponding note in the ticket).

Thanks for the heads up on the testing @wiersgallak 👍
Thanks @pqzx
I'm seeing an issue where the suggestions "remember" the previous search I did and that is auto-highlighted when I open the at-mention search again (see gif)

The behavior is the same on master so I don't think it's within the scope of this PR...
Perhaps @wiersgallak can clarify the expected in this case and I can create a separate improvement ticket for the issue (I was under the impression that the first suggestion should be auto-highlighted?)

@lindy65 Let's create a separate ticket for that behavior.  I am seeing it on master as well and would expect the highlighting to be the first result on the next search, not retaining the highlighting of the previous search.

Test server destroyed


nodemon

Type: Bug
using nodemon need restart at every changes
VS Code version: Code 1.85.2 (8b3775030ed1a69b13e4f4c628c612102e30a681, 2024-01-18T06:40:10.514Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-5005U CPU @ 2.00GHz (4 x 1997)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
11.90GB (7.01GB free)

Process Argv
--crash-reporter-id 4982fb28-65d9-4e1a-9ae9-4dcf2525eccc

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

html-to-jsx
ria
0.0.1

LiveServer
rit
5.7.9

ReactSnippets
xab
2.4.0

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
0bi6i642:30933247
pythongtdpath:30769146
welcomedialogc:30910334
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
dsvsc019acf:30933242
3ef8e399:30949928

/needsMoreInfo
Not sure how using nodemon related to VS Code editor itself.
Please provide proper steps to reproduce problem and what is expected from VS Code.
Make sure you have configured nodemon to watch proper .js files

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Uncaught TypeError: Cannot read property 'offset' of undefined

Uncaught TypeError: Cannot read property 'offset' of undefined
Not sure why this is happening?
Any help?

Hi. I've recently had this issue, and fixed it by removing minified version of plugin. Unminified version worked for me. Hope it'll help!

If anyone could post more detail about this issue and how I might recreate it, that would be very helpful.


Previewer CPU usage and scaling fixes

What does the pull request do?
This PR fixes:

The excessive CPU usage when using the Avalonia previewer: https://github.com/AvaloniaUI/Avalonia/issues/10203. Summer is coming, I need my computer to stay cool :)
Some incorrect scaling when zooming in the previewer: https://github.com/AvaloniaUI/AvaloniaVS/issues/295

There are 4 commits:

The first commit fixes a small mistake that costs a lot of CPU time: in ManagedDispatcherImpl, the time to wait until the next timer was always negative: the thread was never paused!
The second commit is a rework of RemoteServerTopLevelImpl  to better work with the compositing renderer. It implements a frame buffer that the renderer can update when some visual is invalidated, using a standard render timer, like in most other implementations. Once a new frame is rendered to that buffer, it's sent to the previewer. This commit also changes the frame buffer to be reused between frames (as long as the size doesn't change) instead of having a new one allocated each time.
The third commit does some cleanup of the RemoteServerTopLevelImpl message handler: it avoids trying all branches since a message can only match one case. It also removes some reentrant locks since the whole handler is already under a lock.
The fourth commit ensures that RenderScaling is properly updated: the compositor then scales the content properly according to the previewer requested DPI.

Tested with AvaloniaVS and AvaloniaRider.
Fixed issues
Fixes https://github.com/AvaloniaUI/Avalonia/issues/10203
Fixes https://github.com/AvaloniaUI/AvaloniaVS/issues/295

You can test this PR using the following package version. 11.0.999-cibuild0036001-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Merge canary into main

:tada: This PR is included in version 1.0.4-canary.1 :tada:
The release is available on:

npm package (@canary dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fork, rename, support Django 1.11

Based off https://github.com/snowball-one/cid/pull/15/files

Coverage decreased (-4.9%) to 62.385% when pulling 14c97af35547ed419eb70b1284a856c8e93df7ec on managedbyq:tnt/fork-for-django-1-11 into d4a3be2530bdb73101637c6bcdca7618efcb15c8 on snowball-one:master.


New Sample: Fluttery Bubbles Animation game

New Sample: Fluttery Bubbles Animation game

@divyanshub024 Please have a look :) Although this animation game sample is inspired from the animations sample from dartpad, this really helped me understand more about AnimatedContainers and animations in general. Thought this could help others as well if we keep this as a sample here. Do let me know your thoughts. Thanks

@jddeep What is the difference between this sample and the animation sample from dartpad.

@divyanshub024 The animation sample is just a showcase but here, I have added a little bit more meaning and making a bit interesting.

How did you added more meaning and more interesting? I would like to know what changes are there. I can only merge this if there are some notable changes otherwise it can be considered as plagiarised.

@divyanshub024 Agreed. The changes to be precise include things like brightness toggle, plain discs -> flutter bubbles and some other minor changes like a meaningful appbar. Do let me know if we cannot merge this here, will close this down. Only made the PR to have an animation sample here as the dartpad sample was quite helpful. But anyways, do let me know. Thanks

You know what, Let me close this. I am making something cooler and hopefully, it will add more value to new devs and help them understand animations better. Thanks.


Vite: Cloudflare Proxy plugin

[x] auto-set ssr conditions
[x] caches / dispose
[x] test wrangler
[x] template
[x] docs
[x] wrangler typegen
[x] deployment checklist (setup resources/bindings in CF dashboard)
[x] remove dispose from cloudflare context
[x] rename plugin to devCloudflareProxyVitePlugin as remixDevCloudflareProxy
[x] way to set options for getPlatformProxy. passthru?
[x] order validation
[x] changeset

cloudflareProxy({ getLoadContext, persist: true })

Just a friendly heads-up that this is a wider breaking change than what was mentioned in the changelog. All @remix-run/cloudflare-pages projects with a custom getLoadContext function are affected. Our apps with server.ts files all need to be fixed up now.
It's a better API, no doubt—I'm glad for the change! Just don't want anyone caught out like we were.

@aaronadamsCA can you share what error or issue you encountered and what you change you made to your getLoadContext functions?

Ah I think I see the issue. We changed how the context was passed in from (cloudflare) => ... to ({context: { cloudflare } }) => ... . Good call out, I'll see how we can patch any breaks for this


add poliedro

Poliedro curso offers preparatory courses for the most competitives universitie in Brazil, like ITA (ita.br), and IME (ime.eb.mil.br).

Institution's official website: https://cursopoliedro.com.br/
Link to engineering military universities preparatory courses: https://cursopoliedro.com.br/curso/ita
The mail login page is available in the right upper corner button of the official page, like an "E" button.

@SirMonteiro Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Botany identification

For Botany, current "Identified by" is wrong - identification fields are for the Scientific Name, and full identification history should be used. e.g. http://data.nhm.ac.uk/dataset/collection-specimens/resource/05ff2255-c38a-40c9-b657-4ccb55ab2feb/record/5055973
Need to:

Clearly show the identification fields (Identified by, Date identified & Type status) are for the Scientific Name (requires redesign - move fields into classification section?)
"Type status" field is incorrect - need to just use type status for the current Scientific Name. Data mapping seems to be using type status for any of the determinations.
"Collection date" field is incorrect - make sure it uses the correct KE EMu DwC field (which is for the Scientific name)
Have full determinations history table, with the fields:

Taxon name
Filed as (should be yes/no - not true false)
Type of type
Identified by
Date identified

Reported by JW - to check before live.

Never heard back from JW about this, and this approach isn't correct for all groups.  Postponed until I get more info.

I wonder if this has any relation to this more recent report of issues with Botany taxonomies: https://github.com/NaturalHistoryMuseum/data-importer2/issues/17?


While creating virtual environment Python extension does not prompt with venv notification

While creating virtual environment VS Code does not prompt with venv notification

I was able to reproduce this, so I'm transferring it to the Python extension repo.

hello, any updates? I am also facing this issue

I face this issue too. I didn't have this problem for around a year. Now all of the sudden the extension is unable to automatically detect that I have created a virtual environment and the Python interpreter is inside it, so I have to set it manually.

I'm having this same issue. I type python -m venv .venv and it creates the folder, but I never get any prompt telling me that a new virtual environment was detected and asking if I want to switch to it. I also don't see the virtual environment in the Select Interpreter menu. I can manually activate it, though.

same problem here, create the venv, can activate it by hand, but it won't show up in the list of available interpreters nor it triggers the activate environment upon creation

Hello,
I have the same issue.
I don't get the prompt to create a virtual environment, I've tried many ways, just like above, but without success.
Any suggestions?
Thank you,
Bart

I am also facing the same issue.
my vs code version is

I managed to solve it by entering the path to the virtual venv like so:
./venv/bin/python

Still facing this problem! "command 'python.execInTerminal-icon' not found"

I believe this is now fixed by https://github.com/microsoft/vscode-python/pull/17144. This should now be available on our insiders version (View  > Command Palette... and run "Python: Switch to Insiders Weekly" command) 😊

@luabud I tried both Weekly and Daily and the issue is not fixed. Please explain what I'm supposed to do after python -m venv venv.
And it was working a few months ago !

@omidshojaee Try with this build: https://pvsc.blob.core.windows.net/extension-builds/ms-python-insiders.vsix
We have a newer discovery system that reduces the load on machines, this is a bug in that newer system that we have been trying to figure out. In cases where you do python -m venv venv and it does not detect, you can use the Python: Select interpreter command from the command pallet, select Enter interpreter path ... and find the venv python by navigating to it. Usually it will be venv\Scripts\python.exe (on windows) or venv\bin\python (on linux\mac)

Additionally when you are trying this, make sure you are opted into all experiments, in python settings
"python.experiments.optInto": ["All"],

@karthiknadig I know I can select the interpreter manually. That's what me and everyone else is doing now. I want to know why automatic detection of virtual environment was working before, and now it doesn't. Why you MS developers touch something that works perfectly?

@karthiknadig
This is my current environment. It is not working.

@omidshojaee We had to build a new system because the old one was literally preventing users from running python extension some scenarios (especially in cases where people used shared resources). File system watching is also expensive, and can slow down processing. So the new discovery system only uses resources as needed. Our intent is to get the same experience was the old one but reduce the consumption of system resources as we do it.
@karrtikr Do we need verbose logging or just info logs to get the details on this issue?

Verbose and info logging are the same right now.
@omidshojaee  Please set the user setting python.logging.level to info, reload the window, and provide the logs as mentioned in the issue template.
Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

@omidshojaee Can you try the following VSIX and see if it works: https://github.com/microsoft/vscode-python/suites/3679667095/artifacts/89609316
Use Extension: Install from VSIX command in the command palette (CTRL+SHIFT+P) to install the VSIX. If it doesn't help, please provide the logs asked earlier.

@karrtikr It didn't work. The log is here:
https://gist.github.com/omidshojaee/5a6dd25eaed78d201089d8eee963e999

It seems the extension is not activated. You need to open a python file to activate the extension first.

@karrtikr That's not how this extension used to work.

It always activated only after opening a python file, or if we detect you're likely on a python project. Once you activate the extension, please try the steps I provided and leave a comment to that effect.

@karrtikr
The extension always activated after opening a python file.
The bug reported here is not about that. It's about detecting the python interpreter after creating the virtual environment.

We realize that. We're asking you to activate the extension by opening a python file and try creating a virtual environment. If the prompt doesn't show up, send the logs asked earlier to help diagnose the issue.

It can't be done. There's no python file before creating a virtual environment.

Python extension cannot detect any python environment if it is not activated. It never was capable of that. If extension was always activated for you then there are these possibilities:

either you had another extension that depended on python extension that always activated it
you had files in the folder that we register with VS Code to trigger activation on. like these files below:

       "workspaceContains:mspythonconfig.json",
        "workspaceContains:pyproject.toml",
        "workspaceContains:Pipfile",
        "workspaceContains:setup.py",
        "workspaceContains:requirements.txt",
        "workspaceContains:manage.py",
        "workspaceContains:app.py"

there was a bug in VS Code that activated the extension for you in an empty folder.

This requirement to have a python file open to activate has existed in a long time (since extension was created). So, if the extension is not activated it won't detect environments being created. If previous version of the extension was activating for you in an empty folder (not because of other extension that depend on it), then that is a bug that should be filed on VS Code.

You keep talking about activating the extension.
Read the title of this thread again.
VSCode used to show a prompt right after creating the virtual environment that it is detected and offered to set it as the default for project.
You must read this thread again because clearly you are lost.

There, fixed the title for you.

VSCode used to show a prompt right after creating the virtual environment that it is detected and offered to set it as the default for project.

VSCode was never responsible for the prompt. It's the Python extension in VSCode which showed the prompt. Your Python extension is not enabled, hence you don't see the prompt, simple.

That prompt comes from python extension, we show it when we detect (https://github.com/microsoft/vscode-python/blob/5033f1d243a271b858416d7cd06abfb1182e6fff/src/client/interpreter/virtualEnvs/virtualEnvPrompt.ts#L92-L94). Python extension detects or can detect environments only after activation. we cant detect virtual environments created when extension is not activated. You are not providing us the right information to help you here.

So everyone on this thread saying that's how the extension used to work before is lying and you know better than all of us?

And changing the title of the thread just shows how old you truly are.

@karthiknadig This thread is not started by me. And several other users saying that they were seeing the prompt right after creating the environment. Either we are all hallucinating or you don't want to understand what we are talking about.
And please add some adults to the development team.

The extension cannot detect virtual environment (or show prompts) if it is not activated. At this point the conversation has gone off track and this is not helping us resolve the issue.

Fixed in the stable release, feel free to open new issues if that isn't the case.


chore: bump lib to v0.8.5

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

chore: bump lib to v0.8.5

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[ ] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 37.003%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
121

Relevant Lines:
327

💛  - Coveralls


[Experiment] Update tracking

This is a proof-of-concept for status tracking in Felix, which is covered by #335.  This PR only covers tracking rules updates and right now it doesn't do anything with the information apart from print it out on a timer.
The general idea is to pass around a tracker object between the actors that share the implementation of a piece of work and to use incref/decref type operations to handle forking of work where one actor passes the work on to multiple others.  That bit is a bit fiddly but, given how async felix tries to be, it's tough to see a more elegant way to do it.  I stopped at this point to touch base and see what people think about it.
One other idea I had was to give the actors control over their AsyncResults so that the AsyncResult can be deferred until all child work is complete.  That might be nice but it's has some edge cases (such as handling retries) that make it tough to get right.
Rather than make the tracking logic an Actor, I decided it belongs as part of the underlying framework.  Making it Actor-based would double the number of messages that we use and make it harder to implement.
Right now, it just prints information about outstanding work on a timer and calculates the HWM of seen work and completed work (as etcd indexes).  The next step would be to fire off periodic updates to the EtcdAPI Actor to tell the world about the status and to add protection logic to catch leaked trackers and monitor felix's health.
CC @eepyaich @plwhite @joe-marshall

@plwhite would be great if you could take a look at this approach on Wednesday so I don't go too far down a rabbit hole!

@plwhite so... this approach starts to get pretty hairy once you start thinking about batched events for things like tag updates and you want to handle failures.  I'm going to do some more thinking in the background and work on something else.


[Bug] Vue: Segmented Control :active not working with v-for

When using v-for with Segmented Buttons the prop for active is showing up correctly, but the visuals do not show any button as active.
Example for Reproduction:
  <k-segmented strong>
    <k-segmented-button
      v-for="option of [1, 2, 3]"
      :key="option"
      small
      strong
      :active="option === 1"
    >{{ option }} </k-segmented-button>
  </k-segmented>

fixed by #51


[WFRP4e System] Opposed Rolls not Registering

For some reason recently whenever I do an opposed combat roll and try to roll the defenders defense, it never registers like it used too so I cant have the opposed roll calculate the ultimate result From: for Discord: EpicOtter (Sinan)#4096  or Email<EMAIL_ADDRESS>11.306wfrp4e: 7.0.2wfrp4e-altdorf: 4.0.1wfrp4e-archives1: 4.0.1wfrp4e-archives2: 4.0.1wfrp4e-core: 4.0.1wfrp4e-dotr: 4.0.1wfrp4e-eis: 4.0.1wfrp4e-empire-ruins: 4.0.1wfrp4e-horned-rat: 4.0.1wfrp4e-middenheim: 4.0.1wfrp4e-owb1: 4.0.1wfrp4e-pbtt: 4.0.1wfrp4e-rnhd: 4.0.1wfrp4e-salzenmund: 4.0.0wfrp4e-starter-set: 4.0.0wfrp4e-ua1: 4.0.1wfrp4e-ua2: 4.0.1wfrp4e-up-in-arms: 4.0.1wfrp4e-wom: 4.0.1wfrp4e-zoo: 4.0.1Active Modules: _CodeMirror, adventuremusic, aedifs-tactical-grid, babele, betterroofs, boy-king-of-idaho-music-pack, caeora-maps-tokens-assets, color-picker, colorsettings, combat-range-overlay, combat-tracker-dock, custom-css, darkraven-games-soundscapes-free, dice-so-nice, dndAudioBundle-HammerHome, drehatlas-maps, fvtt-party-resources, fxmaster, gAudioBundle-1, gAudioBundle-2, gAudioBundle-3, gAudioBundle-4, game-icons-net, graham-plowmans-music-pack, ivan-duch-music-packs, levels, lib-wrapper, mad-freecontent, mcromusic-sampler, michaelghelfi, mikwewa-maps-free, miskasmaps, monks-active-tiles, monks-combat-details, monks-combat-marker, moonlight-maps-free, moulinette-core, moulinette-gameicons, party-overview, pings, scene-packer, sequencer, settings-extender, socketlib, spellarena, splatter, tabletop-rpg-music, tacticalmap-free, theatre, theripper-premium-hub, tile-scroll, token-attacher, token-hud-art-button, tokenmagic, torch, vgmusic, vtta-tokenizer, wall-height, wfrp4-wfrp4e-npc-generator, wfrp4e-aom-fanmaps, wfrp4e-eis-maps, wfrp4e-gm-toolkit, wfrp4e-pbth-maps, wfrp4e-ubersreik-maps

Please disable your modules, post errors, or provide any other info that may help with debugging

Closing until further information


Fix wildcard globbing in root of device paths

PR Summary
Fixes scenarios like: Get-ChildItem -Path '\\.\C:\*' so it properly handles wildcards at the root.
The code would find the parent of the wildcard (in this case \\.\C:\) but it would leave out the trailing separator (so it would end up like this: \\.\C:) which is not valid for device path roots.
This PR adds a check for root device paths and adds back the missing backslash if needed.

PR Context
Fixes https://github.com/PowerShell/PowerShell/issues/19439

PR Checklist

[X] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[X] Summarized changes
[X] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[X] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[X] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[X] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[ ] N/A or can only be tested interactively
OR
[X] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[X] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

Here's two bugs I found while debugging the changes: https://github.com/PowerShell/PowerShell/issues/19627 and https://github.com/PowerShell/PowerShell/issues/19626 which affected the tests

@SteveL-MSFT So the bugs you found are out of scope of the changes in this PR?

@daxian-dbw the bugs were not due to this PR and should be addressed separately


jsonld.InvalidUrl: Dereferencing a URL did not result in a valid JSON-LD object

I tried to issue a credential, but it gives the following error:
jsonld.InvalidUrl: Dereferencing a URL did not result in a valid JSON-LD object. Possible causes are an inaccessible URL perhaps due to a same-origin policy (ensure the server uses CORS if you are using client-side JavaScript), too many redirects, a non-JSON response, or more than one HTTP Link Header was provided for a remote context.
questo è il codice che ho scritto:
import jsigs from 'jsonld-signatures';
import * as vc from '@digitalbazaar/vc';
const {purposes: {AssertionProofPurpose}} = jsigs;
import {Ed25519VerificationKey2020} from
  '@digitalbazaar/ed25519-verification-key-2020';
import {Ed25519Signature2020, suiteContext} from
  '@digitalbazaar/ed25519-signature-2020';
import Ed25519KeyPair from'jsonld-signatures';
import Ed25519Signature2018 from 'jsonld-signatures'
import {driver} from '@digitalbazaar/did-method-key';

const didKeyDriver = driver();

const {didDocument, keyPairs, methodFor} = await didKeyDriver.generate();

const {defaultDocumentLoader} = vc;
const documentLoader = jsigs.extendContextLoader(async url => {
    if(url === 'did:test:context:foo') {
      return {
        contextUrl: null,
        documentUrl: url,
        document: myCustomContext
      };
    }
    return defaultDocumentLoader(url);
  });

const assertionKeyPair = methodFor({purpose: 'assertionMethod'});

const suite = new Ed25519Signature2020({key: assertionKeyPair});

const credential = {
    "@context": [
      "https://www.w3.org/2018/credentials/v1",
      "https://www.w3.org/2018/credentials/examples/v1"
    ],
    "id": "https://example.com/credentials/1872",
    "type": ["VerifiableCredential", "AlumniCredential"],
    "issuer": "https://example.edu/issuers/565049",
    "issuanceDate": "2010-01-01T19:23:24Z",
    "credentialSubject": {
      "id": "did:example:ebfeb1f712ebc6f1c276e12ec21",
      "alumniOf": "Example University"
    }
  };
  const signedVC = await vc.issue({credential, suite, documentLoader});
  console.log(JSON.stringify(signedVC, null, 2));

+1

If you print out the details of the error, they say:
  details: {
    code: 'loading remote context failed',
    url: 'https://w3id.org/security/suites/ed25519-2020/v1',
    cause: Error: Document loader unable to load URL "https://w3id.org/security/suites/ed25519-2020/v1".
  }

This indicates that your document loader can't load the URL https://w3id.org/security/suites/ed25519-2020/v1, which is the cryptosuite context for the chosen cryptosuite (Ed25519Signature2020).
To fix this, make sure your document loader can load the suite context you imported from the cryptosuite library:
const documentLoader = jsigs.extendContextLoader(async url => {
    if(url === 'did:test:context:foo') {
      return {
        contextUrl: null,
        documentUrl: url,
        document: myCustomContext
      };
    }
    // ***make sure the cryptosuite context can load too
    if(url === suiteContext.CONTEXT_URL) {
      return {
        contextUrl: null,
        documentUrl: url,
        document: suiteContext.CONTEXT
      };
    }
    return defaultDocumentLoader(url);
  });

This is not working, because
url contains https://www.w3.org/2018/credentials/v1
suiteContext.CONTEXT_UR contains https://w3id.org/security/suites/ed25519-2020/v1


New request spec for chain of steps

Fixes #6051 . New request that can handle a chain of steps, where it creates a single task and simply add new cmsRunX processes into it. Some important comments:

it will only stage out the output of the latest step/cmsRun
it will run all the steps in the same job (GEN-SIM, DIGI, RECO, MINIAOD, etc)
first step can be either generation or procesing of input dataset
merge is created only for the latest step outputs
output will be registered with the Step PrepID or the PrepID provided in the main dict.

Things that still need to be done:

create unit tests :-)
when defaulting to 8h jobs, we need to sum up the TimePerEvent of all steps
allow different CMSSW/ScramArch per Step
if possible, do some additional cleanup to the code
remove line 19 (parentTaskModule) :-)

This is just the first version of this new spec, but seems to be working ok (tested with these 2 templates).
@ericvaandering @ticoann feel free to review and merge if Ok. I'll take care of the remaining issues/todo in 2 weeks.

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/117/ for details

No pylint warnings for pull request 6059:

Unit test changes for pull request 6059:

WMCore_t.WebTools_t.REST_t.RESTTest:testListTypeArgs changed from success to error
WMCore_t.RequestManager_t.Admin_t.AdminTest:testA_SoftwareManagement changed from error to success
WMCore_t.WebTools_t.RESTFormat_t.RESTFormatTest:testEncodedInput changed from error to failure
WMCore_t.Services_t.pycurlFileUpload_t.PyCurlRESTServer:testFileUpload changed from success to error
WMCore_t.WebTools_t.REST_t.RESTTest:testBadVerbEcho changed from success to error
WMCore_t.WebTools_t.RESTFormat_t.RESTFormatTest:testReturnFormat changed from success to error
WMCore_t.WebTools_t.NestedModel_t.NestedModelTest:testInnerPingError changed from success to error
WMCore_t.WebTools_t.REST_t.RESTTest:testDAOBasedHTTP changed from failure to error
WMCore_t.Services_t.pycurlFileUpload_t.PyCurlRESTServer:testFailingFileUpload changed from failure to error
WMCore_t.WebTools_t.REST_t.RESTTest:testException changed from error to success
WMCore_t.WebTools_t.REST_t.RESTTest:testA changed from error to success


Feature/schema tweaks

A bit of a tidy up and the addition on tests for the output

:rocket: deployment of profiles succeeded (http://profiles-pr-169.dev.beta.nhschoices.net)

Thanks Steve - see no issues with what you've added


SCRUM-3515 LinkML v2.0.0 refactor

Known issues:

Genomic/BiologicalEntity DAO searches expecting an NCBITaxonTerm for some reason!
Persistence exception for multivalued allele slot annotations - could just move code that attaches subject Allele, but the same logic is working fine for multivalued allele name slot annotations (would like to understand why there's a difference before just changing the code).
Still seem to be having issues resolving subject/object of different types
UI changes untested and probably more required

Ok took my most of the day to get through this PR. I have not looked at the migration yet. I am going to pull this branch and give it a shot. Maybe can speed up the migration... will run again current version of alpha.

@oblodgett If you're going to run against alpha then make sure you pull in my latest changes.  I was getting a PK error on the inserts into auditedobject_aud as there is a clash between IDs that hadn't been updated in the audit tables due to those IDs no longer being present in the (non-audit) tables, and therefore not having had new IDs assigned.

@oblodgett ES indexes are smaller than those on alpha, so that doesn't explain slow performance on my machine.  Might be good if you could check this locally to see how performance is for you.  I can create a dump of the migrated DB again (changed since last one).

ya if you can create the dump file... i'll give it a shot.


Clarification regarding LaneBlocker and LaserscanDetector.

Before proceeding, is there an existing issue or discussion for this?

[X] I have done a search for similar issues and discussions.

Description
Hey @Yadunund !
I had some clarifications regarding running the lane blocking feature.
Regarding obstacles header.
I see from the discussion that led to this PR https://github.com/open-rmf/rmf_internal_msgs/pull/65 that a header was added to the Obstacles.msg.
However looking at the latest source code on the main branch, the header field is not populated in this file from line 382. Since there was no PR related to this issue discussion of populating the header fields. Should I raise one?
Regarding LaneBlocker Node
The lane blocker successfully sent the request to block lanes and I got messages on the topic as well. The logs of the lane blocker node is available on this gist
The issue was in the fleet adapter. It showed the following when the lanes callback was called.
[fleet_adapter-16]     fleet_handle.open_lanes(msg.open_lanes)
[fleet_adapter-16] AttributeError: 'rmf_adapter.EasyFullControl' object has no attribute 'open_lanes'

I have uploaded a more complete log on this gist
Can you please let me know what steps I need to take to fix this?
Regards,
Suchetan

Thanks for the ticket! It looks like we need to update the implementation to populate the header. I'm hoping the plugin system proposed in #22 will alleviate the need for each obstacle detector to ensure these things. The plugins can just implement a method to set a new list of obstacles along with a header. The node which loads the plugins will be responsible for populating the message that will be published.
Regading the fleet adapter issue, I do see the opne_lanes API available in the python bindings. It might be worth opening a ticket in rmf_demos while also including more details of your setup.

Hi @Yadunund,
Thanks a lot for your response! I have raised a PR regarding the header issue. Like you mentioned, populating this is not desired since the final message would be a set of all obstacles published by all the sensors / plugins. However, to ensure working of this package until this is done, I created the PR.
Turns out that the issue in which open_lanes and close_lanes functions were not being found was a simple fix. I have detailed this in this ticket and also raised this PR for the same.
I am closing this issue since my query was resolved. Thanks a lot for your help! :D

Awesome, thanks for the fix!


terra sdk import issues

Hello
I am using node for the first time.
As a workaround, I tried changing 'type' to 'module' in "pacakge.json", but it didn't work.
please help

solved it
There was a problem with the package.json syntax...


Tenant ID is nil for subscriptions

Hi
This is regarding subscriptions api. It seems that all the subscriptions has nil as its tenant ID, I.E
client := subscriptions.NewClient()
client.Authorizer = &azToken
subs, _ := client.List()
subsArray := *subs.Value
for _, sub := range subsArray {
    // *sub.TenantID == nil !?
}

Hello @shhsu !
I looked into how the response body looks like and yes, TenantID was not included.
@tfitzmac @vivsriaus Is there something we are mising here?

Actually I think it is expected according to what the REST api returns.

If this is the expected result in all calls, then the swagger should be updated. Creating issue in the swaggers repo...

Not sure about the full context of why this filed is there and always null. Even on the Azure CLI side, it seem to expect that subscription objects not having the tenant id
This following code actually appends a tenant id to the subscription object that it returns.
https://github.com/Azure/azure-cli/blob/master/src/azure-cli-core/azure/cli/core/_profile.py#L453

Hello @shhsu :D
The subscriptions swagger has been modified so it does not include the tenantID in the subscription model. This value is never returned.
Will this be included in the next SDK version @marstr  ?

@mcardosos, it should be! I'll make sure to check for it when we generate.


Update CODEOWNERS

Motivation
Update CODEOWNERS to include @acud
Description
no other changes, just adding our new team member to the list.
Test Plan
n/a
TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed
[x] Update changelog as needed

bors merge


fix: allow pushing images with different arch/os to docker daemon

Fixes #4265 and #4267

Avoid throwing exception when building image with mismatched arch/os to the local docker daemon.
Follow convention of using event handlers to log warning when building for matching os/arch. Example: https://github.com/GoogleContainerTools/jib/blob/b06b001ed26b6a1fedc1ac738f628513390433e9/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/PullBaseImageStep.java#L225

Notes on kokoro-ubuntu timeout:

The job passed on https://github.com/GoogleContainerTools/jib/pull/4268/commits/f2d886b289a2e0d471f37281ce23322e00e6a288 but started failing after test for arm64 was added.

@mpeddada1 just so you know, it sounds like #4267 is another issue introduced by #4249 in 3.4.3.

@mpeddada1 just so you know, it sounds like #4267 is another issue introduced by #4249 in 3.4.3.

Thank you @chanseokoh! Given that it is not reproducible in 3.4.2, the change in logging behavior may connected to some of the modifications made in https://github.com/GoogleContainerTools/jib/pull/4249. Will have to take a deeper look to understand what causes the difference in behavior for windows (perhaps in a separate dedicated PR).

Regarding the integration test behavior on the CI:

Changing test names is causing different behavior on the ubuntu CI. Documenting test names to better understand execution order: https://github.com/GoogleContainerTools/jib/pull/4268/commits/d92123d9675a3ea662c8c1a77e757bf003ffe0c6. According to https://github.com/junit-team/junit4/wiki/Test-execution-order#test-execution-order, Junit 4 uses deterministic but not predictable order.

[Update on CI] Splitting the test methods up into separate test classes no longer causes the builds to be stuck. Ready for another round of review.

should https://github.com/GoogleContainerTools/jib/blob/master/docs/faq.md#how-do-i-specify-a-platform-in-the-manifest-list-or-oci-index-of-a-base-image be updated? It still says "Does not support pushing to a Docker daemon"


Add new routes

New routes:

Bifrost
Centrifuge
Astar
Interlay

Hydration
ASTR, GLMR, IBTC
DOT, GLMR
BNC, GLMR, IBTC, INTR,PHA,VDOT, VASTR
vDOT

🧚 Live preview: https://github.com/galacticcouncil/hydration-ui/pull/1740

Rebase pls on master, so we can test :)

ad

Looks good, besides GLMR transfers (which are less than 0.5 GLMR)


Document Maximum events count

For the Event Hub connector for Logic Apps, if I put a number higher than 175 for Maximum events count, I get an error that the value must be between 1 - 175. Can you please document the Maximum events count?  Can you please also consider documenting how many events the Logic App will automatically set if I leave this value blank?  Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6606f6c7-6243-13d6-9fde-15f387f0e331
Version Independent ID: 875d1e7a-abbc-6cee-e7af-0f9786769917
Content: Connect to Azure Event Hubs - Azure Logic Apps
Content Source: articles/connectors/connectors-create-api-azure-event-hubs.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

Hi @mlcooper - Thank you for your feedback! We will review and update as appropriate.

@mike-urnun-msft,
This limit should appear on the connector's technical reference page along with any other connector limits:
https://docs.microsoft.com/connectors/eventhubs/
Adding @ShyamSunder90 to help

@ShyamSunder90: Could you please respond on this customer request? Thanks!

#assign @ShyamSunder90 to help with adding the requested Maximum events count limit added to the Azure Event Hubs connector reference page: https://docs.microsoft.com/connectors/eventhubs/

I created a doc work item in the engineering team's backlog. I'm closing this thread for now, but I'm also tagging Rama for awareness.
#assign @rarayudu
@mike-urnun-msft: #please-close

rarayudu is already assigned.

#assign:@ecfan


WebAdministration : no IIS drive

Steps to reproduce
Import-Module WebAdministration
Get-PSDrive

Expected behavior
see IIS drive

Actual behavior
no IIS drive

Environment data

Name                           Value
----                           -----
PSVersion                      7.0.0
PSEdition                      Core
GitCommitId                    7.0.0
OS                             Microsoft Windows 10.0.19569
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

All non-compatible modules can be reported in https://github.com/PowerShell/PowerShellModuleCoverage

All non-compatible modules can be reported in https://github.com/PowerShell/PowerShellModuleCoverage

Speaking for myself, I am disappointed that so many Microsoft Windows Server modules are NOT PowerShell Core compatible. I totally understand how a very few modules, such as the WSUS one, will be VERY hard if not impossible to fix since the entire WSUS infrastructure  is reliant on older technology (SOAP)) and can't be converted easily. It is easy to say that that team made some poor design decisions, but we are where we are.
But other modules, like BPA, AD Deployment, and many others, should be fairly straightforward to convert (i would hope!!!!). In the two or so years since Windows Server 2019 shipped, I see no indication of improvements. To me, reporting them as you ask is just a black hole. And as anyone who has tried to use User Voice will know - that too seems a write-only medium.
Until and unless the Windows Server Feature team start fixing these modules, I am not sure what actual value there is in asking users to report these incompatible modules. From where I sit, reporting them achieves little.
How do we get Microsoft to move forward? And if the Windows Server Team does not want to step up, why not just open source these modules and let the community fix them. That would have the added benefit, eg for AD, to get updated modules working on older OSs.

Speaking for myself, I am disappointed that so many Microsoft Windows Server modules are NOT PowerShell Core compatible. I totally understand how a very few modules, such as the WSUS one, will be VERY hard if not impossible to fix since the entire WSUS infrastructure  is reliant on older technology (SOAP)) and can't be converted easily. It is easy to say that that team made some poor design decisions, but we are where we are.
But other modules, like BPA, AD Deployment, and many others, should be fairly straightforward to convert (i would hope!!!!). In the two or so years since Windows Server 2019 shipped, I see no indication of improvements. To me, reporting them as you ask is just a black hole. And as anyone who has tried to use User Voice will know - that too seems a write-only medium.
Until and unless the Windows Server Feature team start fixing these modules, I am not sure what actual value there is in asking users to report these incompatible modules. From where I sit, reporting them achieves little.
How do we get Microsoft to move forward? And if the Windows Server Team does not want to step up, why not just open source these modules and let the community fix them. That would have the added benefit, eg for AD, to get updated modules working on older OSs.


Re-enable inline asm for gfx1030

QA performance testing revealed that enable inline assembly actually benefits navi21 in the rocRAND philox benchmarks (the previous assessment of inline asm being bad for MI200 is still correct though).
rocrand-kernel/philox-poisson: 14.25% loss without inline asm
rocrand-kernel/philox-discrete-custom: 5.89% loss
rocrand-kernel/philox-discrete-poisson: 5.52% loss
rocrand-generate/philox-poisson: 7.68% loss

Inline asm should never be beneficial. There should be a compiler bug if it is

Inline asm should never be beneficial. There should be a compiler bug if it is

@Maetveis @neon60 https://github.com/ROCmSoftwarePlatform/rocRAND/blob/develop/library/include/rocrand/rocrand_common.h#L78 is the only part of rocRAND which potentially uses inline asm, right?  Can you provide some background on this?
In any case, I'm all for merging this while we file a compiler bug once we get more info.

As discussed in weekly meeting, StreamHPC will investigate and create a minimal repro which can be sent to compiler team for analysis as to why inline asm seems to result in better performance in this case.  In the meantime we'll merge this in.

Hi @stanleytsang-amd ,

As discussed in weekly meeting, StreamHPC will investigate and create a minimal repro which can be sent to compiler team for analysis as to why inline asm seems to result in better performance in this case. In the meantime we'll merge this in.

Any update on this?
Thanks

Hi @stanleytsang-amd ,

As discussed in weekly meeting, StreamHPC will investigate and create a minimal repro which can be sent to compiler team for analysis as to why inline asm seems to result in better performance in this case. In the meantime we'll merge this in.

Any update on this?
Thanks

Hi Mark, I've just created an internal ticket (SWDEV-356009) to the compiler team with a minimal repro and explanation.  You should be a watcher on it.

Hi @searlmc1, I've just created an internal ticket (SWDEV-356009) to the compiler team with a minimal repro and explanation. You should be a watcher on it.

Thanks!

Hi @searlmc1, I've just created an internal ticket (SWDEV-356009) to the compiler team with a minimal repro and explanation. You should be a watcher on it.

https://reviews.llvm.org/D133768 landed for this


RET508 potential false positive after elif

This is with ruff==0.0.155
I tried to drill it down to a simpler example but it did not happen there. Can you try to run ruff with RET508 enabled on this file, like
ruff rotkehlchen/tests/api/test_async.py
It's returning
rotkehlchen/tests/api/test_async.py:75:13: RET508 Unnecessary `else` after `break` statement
rotkehlchen/tests/api/test_async.py:137:9: RET508 Unnecessary `else` after `break` statement

Which I am confused how it makes sense.
If we remove the else and put the Assertion (or any other code) after the if/elif the resulting code won't be the same.
I got similar questionable results with the other RET codes btw.
Also a question on pyproject toml. I have ended up with somethine like:
select = ["E", "F", "W", "C", "N", "B", "T", "UP", "YTT", "C4", "T10", "T201"]

Isn't T a superset of T201 and T210? So I can omit those? Same for C4 and C?

Will clone and take a look. It could just be a limitation in the plugin logic (i.e., does it reproduce in the original flake8-return?). Or it could be a bug in the translation to Rust...

And yeah, your configuration is equivalent to:
select = ["E", "F", "W", "C", "N", "B", "T", "UP", "YTT"]

Will clone and take a look. It could just be a limitation in the plugin logic (i.e., does it reproduce in the original flake8-return?). Or it could be a bug in the translation to Rust...

Well I think I have added some flake8 checkers thanks to ruff, that I did not use before. So yes we never used flake8-return in rotki before.
I can see the exact same error for that file with flake8-return.
Perhaps I am too tired or not focused but does it not seem wrong?

rotkehlchen/tests/api/test_async.py:75:13: RET508 Unnecessary else after break statement

I think the idea here is that the code, as written, is:
while True:
    # and now query for the task result and assert on it
    response = requests.get(
        api_url_for(server, "specific_async_tasks_resource", task_id=task_id),
    )
    assert_proper_response(response)
    json_data = response.json()
    if json_data['result']['status'] == 'pending':
        # context switch so that the greenlet to query balances can operate
        gevent.sleep(1)
    elif json_data['result']['status'] == 'completed':
        break
    else:
        raise AssertionError(f"Unexpected status: {json_data['result']['status']}")

But this is equivalent to the following:
while True:
    # and now query for the task result and assert on it
    response = requests.get(
        api_url_for(server, "specific_async_tasks_resource", task_id=task_id),
    )
    assert_proper_response(response)
    json_data = response.json()
    if json_data['result']['status'] == 'pending':
        # context switch so that the greenlet to query balances can operate
        gevent.sleep(1)
    elif json_data['result']['status'] == 'completed':
        break
    raise AssertionError(f"Unexpected status: {json_data['result']['status']}")

...since this will only ever be reached if the elif evaluates to False.
So I think the check is right, based on a very cursory look, but whether you want to enforce those rules is maybe a different question :)

rotkehlchen/tests/api/test_async.py:75:13: RET508 Unnecessary else after break statement

I think the idea here is that the code, as written, is:
while True:
    # and now query for the task result and assert on it
    response = requests.get(
        api_url_for(server, "specific_async_tasks_resource", task_id=task_id),
    )
    assert_proper_response(response)
    json_data = response.json()
    if json_data['result']['status'] == 'pending':
        # context switch so that the greenlet to query balances can operate
        gevent.sleep(1)
    elif json_data['result']['status'] == 'completed':
        break
    else:
        raise AssertionError(f"Unexpected status: {json_data['result']['status']}")

But this is equivalent to the following:
while True:
    # and now query for the task result and assert on it
    response = requests.get(
        api_url_for(server, "specific_async_tasks_resource", task_id=task_id),
    )
    assert_proper_response(response)
    json_data = response.json()
    if json_data['result']['status'] == 'pending':
        # context switch so that the greenlet to query balances can operate
        gevent.sleep(1)
    elif json_data['result']['status'] == 'completed':
        break
    raise AssertionError(f"Unexpected status: {json_data['result']['status']}")

...since this will only ever be reached if the elif evaluates to False.
So I think the check is right, based on a very cursory look, but whether you want to enforce those rules is maybe a different question :)

Huh ... so weird. I could swear I thought it made no sense but now it does look like it makes sense. Brain fart maybe? Apologies for wasting your time with this.

No worries at all, it’s a hard one to reason about.

i made a simpler example for reproducing this bug:
def func(arg1: int) -> None:
    for i in range(2):
        if arg1 == i:
            if arg1 == 1:
                break
        elif arg1 == 2:
            break
        else:
            print('else')

Yeah I think you’re right.

(They’re not equivalent, not sure why I thought they were.)

The problem is with the following.
RET505, RET506, RET507, RET508
Simple program to reproduce them all
def foo(a: int) -> int:
    if a == 1:
        result = 2
    elif a == 3:
        raise ValueError()
    else:
        raise AssertionError('Evil')

    return result

def foo2(a: int) -> int:
    while True:
        if a == 1:
            result = 2
        elif a == 3:
            break
        else:
            raise AssertionError('Evil')

        return result

def foo3(a: int) -> int:
    if a == 1:
        result = 2
    elif a == 2:
        return 42
    else:
        raise AssertionError('Evil')

    return result

def foo4(a: int) -> int:
    while True:
        if a == 1:
            result = 2
        elif a == 3:
            continue
        else:
            raise AssertionError('Evil')

        return result

Taking a look at this now.

flake8-return seems to have the same behavior (not that it's correct).

I'm considering just disabling this for elif for now. It's pretty hard to reason.

I kind of think the logic is not very good for any of these rules beyond RET501, RET502, and RET503.

I can change it to only operate on simple if-else blocks (no elif), but I'm guessing that the plugin wants you to change...
def foo(a: int) -> int:
    if a == 1:
        result = 2
    elif a == 3:
        raise ValueError()
    else:
        raise AssertionError('Evil')

    return result

...to...
def foo(a: int) -> int:
    if a == 1:
        result = 2
    else:
        if a == 3:
            raise ValueError()
        raise AssertionError('Evil')

    return result

Or maybe the plugin logic is just not good.

In any case such a suggestion is bad as it's not an improvement in anyway. I could swear I have a flake8 or other tool with similar~ish suggestions for no else after break or raise. But as you can see these ones seem to be wrong.

PyLint's handling of this is much better, FWIW. I don't think I've ever had a false positive from PyLint's else after control flow checks.

I'm hitting this error (RET508 Unnecessary elif after break statement) with the below using ruff v0.1.4. I'm just a beginner so quite likely it could be avoided with better code.
def main() -> None:
    """Play a game of tic-tac-toe."""
    print('Welcome to tic-tac-toe!')
    game: dict[str, str] = create_board()
    current_player, other_player = X, O  # X goes first.

    while True:
        print(game_state(game))
        move: str = BLANK
        # Keep asking the player for a non-blank space to mark.
        while not is_space_blank(game, move):
            move = input(f"What is {current_player}'s move? (1-9) ")
        make_move(game, move, current_player)
        # Check if the game is over.
        if is_player_winner(game, current_player):  # First check for victory.
            print(game_state(game))
            print(f'{current_player} has won the game!')
            break
        elif is_board_full(game):  # Then check for a tie.
            print(game_state(game))
            print('The game is a tie!')
            break
        # Swap turns.
        current_player, other_player = other_player, current_player
    print('Thanks for playing!')

You don’t need else after a control flow statement. That’s return, yield, break, or continue. Remove the “el” in front of the elif.

I see. Thank you so much for pointing that out.


updating conda env fails with file not found

I'm following the caching example and it's consistently failing when looking for the environment.yml file. It seems to expand the path to the file twice, even though I'm not explicitly expanding the path?
Specifically, the error is:
Error: ENOENT: no such file or directory, open '/home/runner/work/myrepo/myrepo/home/runner/work/myrepo/myrepo/myfolder/env.yml'

The action looks like this:
name: test-on-pr

on:
  pull_request:
    branches:
      - main

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - name: Cache conda
        uses: actions/cache@v1
        env:
          # Increase this value to reset cache if env.yml has not changed
          CACHE_NUMBER: 1
        with:
          path: ~/conda_pkgs_dir
          key:
            ${{ runner.os }}-conda-${{ env.CACHE_NUMBER }}-${{
            hashFiles('myfolder/env.yml') }}
      - uses: conda-incubator/setup-miniconda@v2
        with:
          activate-environment: anaconda-client-env
          channel-priority: strict
          environment-file: myfolder/env.yml
          use-only-tar-bz2: true # IMPORTANT: This needs to be set for caching to work properly!
      - name: Cache pip
        uses: actions/cache@v2
        with:
          # This path is specific to Ubuntu
          path: ~/.cache/pip
          # Look to see if there is a cache hit for the corresponding requirements file
          key: ${{ runner.os }}-pip-${{ hashFiles('myfolder/env.yml') }}
          restore-keys: |
            ${{ runner.os }}-pip-
            ${{ runner.os }}-
      - name: Install dependencies
        run: |
          # $CONDA is an environment variable pointing to the root of the miniconda directory
          $CONDA/bin/conda env update --file myfolder/env.yml --name base
      - name: Test with pytest
        run: |
          pytest myfolder/tests

Thanks in advance for your help!

Hm... actual logs/links to workflows would be most instructive.
Failing that:

on which step is it actually failing?

is there any more context? warnings?

have you tried one of the simpler examples?

I generally consider caching "gravy", as it brings with it exciting new challenges and failure modes

have you tried with an environment that is not named base or root?

These are "semi-magical" from conda's perspective, and are treated specially

running the env update (and the pip cache) a second time isn't going to do anything
have you tried setting your shell (in this case shell: bash -l {0}), avoiding the whole $CONDA thing?

looks complicated... unless you are actually building conda

Unfortunately, it's in a private repo :( Building the environment takes a really long time so I'd like to cache if at all possible.
It's failing on ##[group]Run conda-incubator/setup-miniconda@v2, and there are no more warnings :( Since it fails before getting to the $CONDA part, I haven't tried adjusting that.
There are some dependencies resolved by pip - what's the best way to cache and uncache those if the cache block doesn't do anything?

If the pip cache were to be effective, you'd want to do it before the initial call to setup-miniconda... or drop the environment-file altogether, and just rely on setup-miniconda to... setup miniconda, call conda env update yourself, etc.
To really have an impact on the environment setup duration, you'd want to use conda-lock off-line and check in the lockfile...

Not the case for the original poster, but I experienced a similar error because I accidentally deleted the checkout step
      - uses: actions/checkout@v4


Add support for using CA cert in kubernetes connector w/ service account

Terraform Version
v1.5.7
Affected Resource(s)
Please list the resources as a list, for example:

harness_platform_connector_kubernetes

Currently it looks like there is not a way to configure a CA cert when using the harness tf provider to create a kubernetes connector with a service account. This field is listed as optional in the harness console, but can be set there. Even when first creating the connector via tf, then manually adding the CA cert into the newly created connector via the console, tf plan / apply do not show any changes.
It would be great to support configuring the CA cert via tf as well.

Hi @d-shi ,
Seems like this issue is resolved in PR #934 ,
Also its available in Docs : harness_platform_connector_kubernetes


Adding DISTANCE_SENSOR and possibly other raw sensor messages.

For offboard work I feel it would be useful to have access to the the raw sensor data. For example I am using Attitude+Lidar Rangefinder+Thermal Sensor  to create a heat map during a survey.
Suggestions/Ideas:
A telemetry subclass ie telemetry.raw() that gathers sensor information and current readings available through mavlink. Also, IMO the sensor reading timestamp "time_boot_ms" (ex: https://mavlink.io/en/messages/common.html#DISTANCE_SENSOR) is especially useful from my perspective for sensor fusion and filtering to approximate vehicle state.

Thanks for the PR!
However, it seems like it is not up-to-date with develop, and therefore in the "Files changed" tab, you can see changes that are not yours.
Ideally, you should make sure that your branch is up-to-date with develop (and only have your new commits on top), so that we can really see what changes you propose.
Also, is this meant to be a pull request (you have code you want to contribute), or is it more of a feature request (you want to discuss adding the distance sensor)? In the latter case, it should be an issue (and not a PR). In the former case, please make sure you are up-to-date with develop so we clearly see what code you want to merge!
Let me know if you have questions, and thanks for the contribution! :blush:

Closing in favor of https://github.com/mavlink/MAVSDK/issues/925.
Thanks!


Fix make:adminlte for Laravel 5.4.31+

Thank you! @simik-ru
I also found out this was mentioned in #102

@jeroennoten This fix works.

Please, accept this pull request!
Thanks @simik-ru

Thanks for this PR and sorry for the delay!


chore: update ldk-node-go and glalby-go to use MSVC-linked libraries

@im-adithya updated ldk-node and glalby bindings to use MSVC-linked libraries on Windows.

For some reason I can't see the build files for Windows and Linux here

@im-adithya that's super weird — some kind of github issue maybe? Both artifacts are available on the corresponding build job pages, under the "Run actions/upload-artifact@v4" step 🤔

Yeah ig it's a GitHub issue, re-ran the checks and got the build files now!
https://github.com/getAlby/nostr-wallet-connect-next/actions/runs/9536492120

Tried the Windows build but it still shows the same popup

@im-adithya my bad 🤦♂ I updated the bindings library versions but copied the old libraries in the workflow. Fixed now. Tried it on my machine with MinGW unavailable — worked fine!


[stable/kube-downscaler] sync cluster role with upstream

same rules as upstream project:
https://codeberg.org/hjacobs/kube-downscaler/src/branch/main/deploy/rbac.yaml

Description

Checklist

[x] Title of the PR starts with chart name (e.g. [stable/mychartname])
[x] I have read the contribution instructions, bumped chart version and regenerated the docs
[ ] Github actions are passing

Ok I have updated the readme

@max-rocket-internet what needs to be done to rerun the checks and merge it?

@runningman84 I don't know, all the checks are queued 🤔

I can't cancel them either. @runningman84 can you make another dummy commit to try and restart the actions?


integrate for JacobiWeight with α,β=-1 using LogWeight

This is missing.  Right now NaNs get returned.

This has been partially implemented


Feature - Make Promoted Search Results Orderable

Extends the work done on #4614
Closes #3897
Thanks @chrisranjana - really awesome stuff.
Just adds some tests, a bit of formatting in the Django template files and a bit of a reorganisation of how the ordering url args are handled in the view.

Do the tests still pass? ✅
Does the code comply with the style guide?  ✅
For Python changes: Have you added tests to cover the new/fixed behaviour?  ✅
For front-end changes: N/A
For new features: Has the documentation been updated accordingly? N/A - pretty much expected behaviour and other similar pages are not documented in this way.

I'll take a look - I might need to merge in the latest from master.

@chosak  - can you take a look at this and approve if you think this is good to go, I am happy to merge this in but just wanted to make sure this gets another check through

@chosak thanks for the suggestion, I have now added this (although I used title as this seemed more appropriate and useful), although this made me start down rabbit hole of accessibility support for title vs aria-label. It appears that this needs a fair bit of work throughout Wagtail (I know there are other issues for this).
Plus the way we are doing icons, as you probably know, seems to cause some issues.
happy to change back to aria-label if you think that is better, or use both (again there are various potential issues with that).
Note: I have also squashed, rebased and put all into one commit

@chosak did a bit more digging and testing, revised to use aria-label as per your original suggestion.

Merged in via 1f421e35f00b5463844171047bd099259c11e95b
Thanks again @chrisranjana  for your original work on this


github: Pass the workflow step timeout to go test

Pass the workflow step timeout (less 1 minute for incidentals) to go test, as its default (10 minutes) has been exceeded causing unnecessary test flakes.
Example failure:
10m 27s
Run if [ false == "true" ]; then
=== RUN   TestConformance
...
panic: test timed out after 10m0s
running tests:
	TestConformance (10m0s)

/test

/ci-multi-pool


BinaryView.get_view_of_file Fix

BinaryViewType.get_view_of_file wasn't properly handling .bndb files

Okay, something is definitely going on somewhere else, because I'm still seeing errors, and it's because BinaryView.get_view_of_type('ELF') is returning a strange half-raw,half-ELF view for me that prints <BinaryView: start 0x8000, len 0x9038> and bv.view is Hex:Raw

Welp, that is very weird, because I definitely didn't mess with that, haha. It must have been my editor or something?

Fixed the new line issue

Thank you @joshwatson!


kedro-telemetry: Environment var do not override the consent from the .telemetry if not command run case

Description
Relates to https://github.com/kedro-org/kedro-plugins/pull/762 and https://github.com/kedro-org/kedro/issues/4024
Context
We call _check_for_telemetry_consent before each command run. However, in the rest of the cases, we call _check_for_telemetry_consent after the context is created but we also check if self._consent was not set: https://github.com/kedro-org/kedro-plugins/blob/24cd01c23dc36145ff7893f5497df86960a0f68f/kedro-telemetry/kedro_telemetry/plugin.py#L209
It makes it impossible to override the consent from the .telemetry by setting the environment variable ("DO_NOT_TRACK" or "KEDRO_DISABLE_TELEMETRY") for example in interactive environments.
Steps to Reproduce

create .telemetry with consent: true
kedro ipython
consent in .telemetry is set to true, telemetry is sent (as expected}
set os.environ["DO_NOT_TRACK"] = "true"
%reload_ext kedro.ipython
consent in .telemetry is set to true, os.environ["DO_NOT_TRACK"] is true, telemetry is still sent (not expected)

The same issue if changing .telemetry in interactive environment:

create .telemetry with consent: true
kedro ipython
consent in .telemetry is set to true, telemetry is sent (as expected}
update .telemetry with consent: false
%reload_ext kedro.ipython
consent in .telemetry is set to false, telemetry is still sent (not expected)

On https://github.com/kedro-org/kedro-plugins/pull/791 I tried to change the after_context_created hook to always set self._consent insead of only when it's None. It stops further unwanted calls every time we reload IPython with the DO_NOT_TRACK variable set. However, it still sends info to heap after the IPython shell is exited.
If you edit the .telemetry file itself inside IPython, it still sends info to heap once, because when the command was first called consent was true. I think this is a weird behavior. I'm looking into it further.


hope to add propBlackList option

sometimes need to ignore some css properties that translates px to rem, such as border. so hope to add propBlackList option

would you be interested in a PR for this?

If it doesn't affect performance too much for those that don't use it.

i guess you'd have to use either propWhiteList or propBlackList, since this wouldn't really make sense:
{
    propWhiteList: ['font'],
    propBlackList: ['font'],
}

how about if you leave both of those options off, the default is to remify every prop (the equivalent of  propWhiteList: [''] now), if you supply both you get an error, and if you supply one it's observed?

maybe, in the case you tried to supply both options propWhiteList would always override propBlackList, and you get a warning instead?

I preferred BlackList always override WhiteList. Usually, I want to blacklist them because that have sub-pixels rendering problem in some cases.

In version 4.0.0 you can use a BlackList by just adding a wildcard to the propList:
{
  propList: ['*', '!border*']`
}


[$1000]  Group chat - No whisper with email-only members and LHN preview shows concierge email

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging.new..expensify.com
Go to + > Create group
Select a few members with email address
Create the group
Go to + > Create group
Select a few members with email address and phone number
Refresh the page

Expected Result:
In Step 4, concierge whisper should show up
In Step 6 - 7, the LHN preview should show 'This is the beginning of your chat with...'
Actual Result:
In Step 4, concierge whisper does not show up. This only occurs when the group is created with members with email address only.
In Step 6 - 7, the LHN preview shows concierge email -<EMAIL_ADDRESS>Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/000552bd-f488-42d4-abc2-d98161acf7e1
https://github.com/Expensify/App/assets/78819774/20cc01f6-5c8f-49c1-975d-0d49ebaa595a
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01da71fccd80415b9f
Upwork Job ID:<PHONE_NUMBER>484556800
Last Price Increase: 2023-07-04

I'm catching up from my half day, I'll review soon.

Assigning External I confirm this is a bug.
With a phone number account:

With emails only:

Hi,
I am from Callstack - an expert contributor group
I start to investigate this issue

I'm not able to reproduce on local and stage.

@pasyukevich can you please confirm that one of the accounts you included is a cell phone number account? The key here is step # 6, "Select a few members with an email address and phone number".

@alexpensify I confirm that I checked this scenario too and it's also not reproduced.

Reassigning another bug team member, I'm going OOO until Monday, July 10, and will take it back if it's still open by my return date.
Required action from the 🐛 team: I've run out of time and haven't tested this one AGAIN. This needs another round of testing to confirm if it's a bug. I was able to reproduce it two days ago but if it's no longer an issue then let's close it out. Thank you!

I can replicate both described behaviors on staging:

No whisper when creating a group with 3 emails
Yes whisper when creating a group with 2 emails and 1 phone number

Rechecked. I found that this bug has floating behavior.
Sometimes it's constantly replicating, and then not.
Yesterday reproduced on stage and locally, today I'm not able to reproduce on any env.
Can this issue relate to the BE side?
For me looks like that on the FE part items are just rendering and there is no logic related to the user with a phone number that can affect normal flow.

https://github.com/Expensify/App/assets/23215729/975997f6-a9cc-423c-9dab-5689669641bf

@mollfpr do we need an internal engineer to check if this is a bedrock related error?

Checking in.

I can't reproduce it in DEV, and I am only able to reproduce it once in staging. If it's still an issue, I believe this will be a fix on the backend.

Alright, removing the other 🐛 team member. I'm back online and see that this is our current state:
@mollfpr do you fee like we should close this one out?

@alexpensify I feel so. We don't have a consistent step to reproduce the issue.

Ok, taking action and closing this one. Thank you!


Generated license header is GPL, repo is licensed MIT

If you generate a new controller with ./b controller generate <name of controller>, the generated header mentions the GPLv3 license. This doesn't match the MIT license on the entire repo.
Not sure if we want to change the generated header, or change the repo license.

Good spotting. If we can use MIT, use MIT (for consistence across repos) but depends on how the Webots license limits us, it might require we use GPLv3.

Don't you still use GPL in the main NUbots repo?

Huh I never really looked that closely at NUbots/NUbots, we don't have a repo wide license? Just at the top of the file, and I don't think all files have that. We use MIT for NUbook.
I feel like one license file is easier to manage? How come we have it per file @TrentHouliston? I don't know much about licenses and legal stuff. I guess it'd be good to check through our repos and get some consistency and make sure we're using correct/good licensing.

Webots itself looks like Apache 2.0, so we're not particularly limited in licence choice by Webots

NUbots was GPLed before I showed up, Anything new we did MIT licence (NUsight etc) but since NUbots was GPLed, it has to stay GPLed. Unless you can contact everyone who contributed to that repo and ask them if we can swap to MIT.
As for per file licence, it's not really like that. It's one licence for the repo and more like a "reminder" in each file. Licence isn't dependent on you having text in a file.
Technically NUbots licencing is all kinds of messed up since I think nobody actually signed something like Google's CLA, so everyone individually owns the licence to the parts of the code they wrote or something?
Otherwise if everyone signed one as "NUbots" the organisation you could just relicense everything.
Also IANAL... so who knows :P

That sounds familiar, I think someone told me this before.
Should we have a license file in the root of the repo or is it implied by the 'reminders' in the files? Or maybe that's not how it works :sweat_smile: I feel like we need a legal student on the team

I suppose for this issue, we change the tool to generate files that mention MIT rather than GPL in the header?
Moving forwards, I suppose we can at least have team members from now on sign some kind of CLA, and standardise on MIT? But that's possibly a bigger discussion than fits in this issue.

Going forward, a CLA would be nice, and can be a standard part of onboarding - by joining the team and committing code, you agree to assign copyright ownership to the NUbots organisation. This way if NUbots the org decides to adopt a specific licence, it doesn't need consent from every individual contributor.
As noted already, this wouldn't cover existing contributions though, and we'll also need a process that ensures any external contributors not part of the team sign the CLA before merging their contributions. There are bots like this one that can help automate the process.


Upgrade fr24feed to 1.0.25-3

MLAT seem to be working in 1.0.25-3

@Deploy

@deploy

You can test it with thomx/fr24feed-piaware:PR-58


Syntax Error in IE 11

The loader doesn't seem to work properly in IE11.
I am using the following config:
module: {
		rules: [
			{
				test: /\.worker\.js$/,
				loader: 'worker-loader'
			}
                   ]
}

When I create the web worker like this:
import Worker from './my-worker.worker.js';
const worker = new Worker();

IE11 throws the error:
SCRIPT0: SYNTAX ERROR
Can someone confirm this error or is there something I should add to my babel config or do I need some sort of polyfill?

I also recieve this error.

With Vue, in vue.js.config you can do the below to make it loaded by Babel:
chainWebpack: config => {
    config.module
    .rule('babel-worker')
    .test(/\.worker\.js$/)
    .use('babel-loader')
    .loader('babel-loader')
    .end();
}

You need setup babel-loader for new syntax, example above, I will update docs soon


fix: total budget is set to null

⚠ Test only with a unused website/allowance as you won't be able to use the website budget again unless you separately change the totalBudget of the allowance from null to number.
Describe the changes you have made in this PR
The modal doesn't open because the totalBudget is set to null and we are using .toString() method on it.
Link this PR to an issue [optional]
Fixes #2078
Type of change
(Remove other not matching type)

fix: Bug fix (non-breaking change which fixes an issue)

How has this been tested?
Tested manually
Checklist

[x] My code follows the style guidelines of this project and performed a self-review of my own code
[x] New and existing tests pass locally with my changes
[x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

The problem is we use parseInt(value) only while calling the action, otherwise, we would have checked if the input field is 0 or not (and everything is fine on the backend anyways) so I think we can merge it without tests 🚀