Fix lists in communicating-on-github.md

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/get-started/using-github/communicating-on-github#github-issues
What part(s) of the article would you like to see updated?
To align with our style guide, the lines in the lists under the "GitHub Issues", "Pull requests", and "GitHub Discussions" headers should:

Have the first letter capitalized
Have periods at the end of these lines removed, as they are not complete sentences

are useful for discussing specific details of a project such as bug reports, planned improvements and feedback.
are specific to a repository, and usually have a clear owner.
are often referred to as {% data variables.product.prodname_dotcom %}'s bug-tracking system.

allow you to propose specific changes.
allow you to comment directly on proposed changes suggested by others.
are specific to a repository.

are like a forum, and are best used for open-form ideas and discussions where collaboration is important.
may span many repositories.
provide a collaborative experience outside the codebase, allowing the brainstorming of ideas, and the creation of a community knowledge base.
often don’t have a clear owner.
often do not result in an actionable task.

Additional information
No response

Hello, I can help with this. :)

@sancodes Hello! Go for it ✨ Feel free to open a PR whenever you have time 💛

@nguyenalex836 Done! let me know if anything needs fix for this PR. :)


Update adel.json

Travis tests have failed
Hey Eliran Pe'er,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
Node.js: 8

     npm test

><EMAIL_ADDRESS>test /home/travis/build/bluzi/[secure]
> mocha

  name files
    ✓ should contain valid JSON
    1) should contain a lowercase name, same as the filename
    ✓ should not have duplicate names
    ✓ should have ISO-639-3 language codes (111ms)
    2) should have correct structure

  Translations
    ✓ should be lowercase

  Sex
    ✓ should be "m", "f" or "u"
    ✓ should be lowercase

  6 passing (200ms)
  2 failing

  1) name files
       should contain a lowercase name, same as the filename:
     TypeError: Cannot read property 'toLowerCase' of undefined
      at Context.it (test/test.js:25:47)

  2) name files
       should have correct structure:
     Error: Error in name file "adel.json":
instance.name is required
      at Context.it (test/test.js:106:23)

npm ERR! Test failed.  See above for more details.


Implement build hooks

In the process of migrating the build system to a separate project, I’ve removed the following features that were Toltec-specific:

Stripping generated binaries unless nostrip is set.
Running patchelf on generated binaries to add a librm2fb_client.so dependency when patch_rm2fb is set.
Injecting Oxide-specific hooks into configure(), postupgrade() and postremove() for reloading apps when a new package is installed.
Injecting pre-defined functions from install-lib in install scripts.

We should provide a way for downstream users of this repo to add hooks into the build system that take care of whatever pre/postprocessing they need.
Idea for implementing this: accept a --hook flag with a path to a Python module that contains functions with well-known names. Load this module dynamically (via https://docs.python.org/3/library/importlib.html#module-importlib) and pass it to toltec.Builder to invoke functions after pre-defined steps.

Implemented in 79e9fcb45b62af17f5b1303f066da71c9f4ce9b3. A sample hook is available here: https://github.com/toltec-dev/build/blob/79e9fcb45b62af17f5b1303f066da71c9f4ce9b3/toltec/hooks/strip.py.


BUG: Some items will not match "URL" parameter

Hi there,
Some items will consistently not match based on the "URL" parameter. Here is an example of a pocket note frontmatter, which contains the relevant url and pocket url:
---
title: "The Trimodal Nature of Software Engineering Salaries in the Netherlands and Europe"
URL: https://blog.pragmaticengineer.com/software-engineering-salaries-in-the-netherlands-and-europe/
pocket-url: https://getpocket.com/read/3275416886
tags: [saved-link]
excerpt: Update: dozens of hiring managers confirmed this trimodal model applies to all global markets: from the US, through Asia to Latin America as well. Also see TechPays.com for data recorded for a growing number of countries in the three tiers.
---

As you can see from the screenshot below, the item is created multiple times, and refuses to match.

A couple of sites I've noticed this happens on are Hacker News (news.ycombinator.com) and ThreadReader (https://threadreaderapp.com/), though neither site fails consistently.

Maybe there are some special characters on specific article URLs or titles that fail to sync.
Are specific articles persistently failing that you know off?

I don't know if this will apply to your situation, but I just was running into this same issue where syncing would create duplicates of the same note. I only started encountering this issue when I set the "Pocket item notes folder location" setting. I previously set it to "pocket" and was getting duplicate notes every time. However, when I changed it to "/pocket", I stopped getting all duplicates.
Hope this helps!


Appium helper typing (extends WebDriver)

Appium helper extends WebDriver, yet the generated type definition looks like this:
class Appium {
    // ...
}

while it should be
class Appium extends WebDriver {
    // ...
}

In theory, it should be fixed if there would be @augments WebDriver or @extends WebDriver in Appium JSDoc definition. I wanted to try it locally and open a pull request but I did not manage to install dependencies for the repo on M1 Mac, so I cannot verify the solution, hence I simply open an issue for someone else to try.

When I migrated JavaScript tests to TypeScript I hit this issue. I was not able to use autocomplete (IntelliSense) of WebDriver methods in Android App project (Appium) in VSCode. Actually the same issue was in JavaScript tests.
E.g. methods such as wait() or seeElement() were not autocompleted and also couldn't be compiled by TS, so I needed to prefix them with // @ts-ignore
Finally I solved the issue by adding of TS definition WebDriver.d.ts into my project:
/// <reference types='codeceptjs' />

declare namespace CodeceptJS {
  interface Methods extends WebDriver { }
}

I must admit it's not ideal solution, it would be better to have updated CodeceptJS's TS definitions


Problem with subject =?UTF-8?Q?

Hi,
When I get subjects, sometimes I recive somthing like this "=?UTF-8?Q?Odp=3A_Re=3A_Kupi=C5=82e=C5=9B_OPEL_ZAFIRA_B_05-08_Wk=C5=82ad_lusterko_ogrzewany_lewy_=287599940574=29_od_motomatic=5Fpl?=".
Proper subject (element form header):
Subject: =?UTF-8?Q?Sprzeda=C5=82e=C5=9B_przedmiot_przez_Kup_Teraz_-_nr:?=
     =?UTF-8?Q?_7685895974_-_OPEL_COMBO_C_03-10_Pr=C3=B3g_prawy?=

Wrong subject:
Subject:
     =?UTF-8?Q?Odp=3A_Re=3A_Kupi=C5=82e=C5=9B_OPEL_ZAFIRA_B_05-08_Wk=C5=82ad_lusterko_ogrzewany_lewy_=287599940574=29_od_motomatic=5Fpl?=

When subject is wrong decoded, first line in header has only "Subject:\r\n".
Is it bug or I need decode this subejcts by myself?
sorry for my english
Regards
Chris

Hi @kfijalko ,
please provide a save dump of $header in Message::parseHeader() L:397.
If $header->subject is properly set it would be possible to implement a certain "filter" for these cases :)
If not there isn't much I could do(?).
Best regards

Had any updates about that?  I'm facing this problem..
The getSubject() is returing =?utf-8?Q?Confirmaci=C3=B3n_reserva_Free_Tour_Flo?= =?utf-8?Q?rencia_Esencial_-_Buendiatours.com?=

Hi @paulocardozo ,
please make sure to update to the latest release. If the issue persists, please add webklex/php-imap manually to your dependencies and make sure it is at least on v5.4.
If the issue still occurs, please head over to https://github.com/Webklex/php-imap/issues/new?assignees=&labels=&projects=&template=bug_report.md and provide as much information as possible. Every little bit, even if it might seem unrelated could help to solve the mystery :)
Best regards & happy coding,


New package: KCenters v0.1.1

Registering package: KCenters
Repository: https://github.com/sadit/KCenters.jl
Created by: @sadit
Version: v0.1.1
Commit: 47753a8b1903ed122e1aca74c6cd3bdc29fca2c6
Reviewed by: @sadit
Reference: https://github.com/sadit/KCenters.jl/commit/47753a8b1903ed122e1aca74c6cd3bdc29fca2c6#commitcomment-35895778

I will block this PR to enable auto-merge

I will block this PR to enable auto-merge of the initial request

#5246


Phinx return mysql error 2014

I wanna test is custom config file work correctly, so i crate new "dummy" migration:
<?php

use Phinx\Migration\AbstractMigration;

class Test extends AbstractMigration
{
    /**
     * Change Method.
     *
     * Write your reversible migrations using this method.
     *
     * More information on writing migrations is available here:
     * http://docs.phinx.org/en/latest/migrations.html#the-abstractmigration-class
     *
     * The following commands can be used in this method and Phinx will
     * automatically reverse them when rolling back:
     *
     *    createTable
     *    renameTable
     *    addColumn
     *    renameColumn
     *    addIndex
     *    addForeignKey
     *
     * Remember to call "create()" or "update()" and NOT "save()" when working
     * with the Table class.
     */
    public function change()
    {
       $this->execute('SHOW TABLES;');
    }
}

After run i got error:

SQLSTATE[HY000]: General error: 2014 Cannot execute queries while other unbuffered queries are active.  Consider using PDOStatement::fetchAll().  Alternatively, if your code is only ever going to run against mysql, you may enable query buffering by setting the PDO::MYSQL_ATTR_USE_BUFFERED_QUERY attribute.

It's because i don't use fetchAll() method, and phinx wanna add migration to log. I think before executing query to update log's phinx shoud clear pdo buffer.
After change change method body to:
$stmt = $this->query('SHOW TABLES;');
$rows = $stmt->fetchAll();

everythink works correctly.

Are you able to provide a PR with your suggested changes?

Ofc :) I will try make pull request on next few days.

@NickOver Could you dump the PR reference in here once done please? We'll be able to merge asap then.

PDO->exec() is different from PDOStatement->execute().  exec() is not designed for queries that produce result sets, only for statements INSERT/UPDATE/DELETE and commands like SET.  PDO->exec() only returns the number of rows affected, hence why there is a result set buffer sitting around.
In a migration $this->execute() is short for $this->getAdapter()->getConnection()->exec()
http://php.net/manual/en/pdo.exec.php
I don't think it's possible to clean up this result set from PHP land, I think the PDO C extension leaves it orphaned in the libmysqlclient.so.
Simply changing execute() to query() without fetching the result set fixes the problem:
class ShowTables extends AbstractMigration
{
    public function change()
    {
        $this->query('SHOW TABLES');
    }
}


Sonic the Anonymous Hedgehog: Watch drshiblisyed.com

Sonic the Anonymous Hedgehog requests the watch of the watch_keyword drshiblisyed\.com. See the MS search here and the Stack Exchange search here.

drshiblisyed\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Makyen watched this some mins after this PR was created.


php artisan db:seed not working

Illuminate\Database\QueryException  : SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'users' already exists (SQL: create table users (id int unsigned not null auto_increment primary key, name varchar(255) not null, email varchar(255) not null, email_verified_at timestamp null, password varchar(255) not null, remember_token varchar(100) null, created_at timestamp null, updated_at timestamp null) default character set utf8mb4 collate 'utf8mb4_unicode_ci')
at D:\xampp\htdocs\laravel\roles-permissions\vendor\laravel\framework\src\Illuminate\Database\Connection.php:664
660|         // If an exception occurs when attempting to run a query, we'll format the error
661|         // message to include the bindings with SQL, which will make this exception a
662|         // lot more helpful to the developer instead of just the database's errors.
663|         catch (Exception $e) {

664|             throw new QueryException(
665|                 $query, $this->prepareBindings($bindings), $e
666|             );
667|         }
668|

Exception trace:
1   PDOException::("SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'users' already exists")
D:\xampp\htdocs\laravel\roles-permissions\vendor\laravel\framework\src\Illuminate\Database\Connection.php:458
2   PDOStatement::execute()
D:\xampp\htdocs\laravel\roles-permissions\vendor\laravel\framework\src\Illuminate\Database\Connection.php:458
Please use the argument -v to see more details.

when i hit php artisan db:seed then it shows this error

This means you are database already has table name 'user' .. follow this steps

Go to your database .. check is users table exists if exists delete the table

run command

php artisan migrate:refresh ( for less than v5.6)
php artisan migrate:fresh (for version above 5.7)

php artisan dump autoload then i hope this work well


UnicodeDecodeError on windows

通常来说 .bean 文件使用 utf-8 编码格式，然后如果在中文环境的 Win 平台使用此程序，由于 Python 的 open 方法默认编码取决于平台（Win 平台默认编码是 gbk），因此会尝试使用 gbk 去解码 utf-8 的 .bean 文件，然后产生 UnicodeDecodeError
Generally speaking, the .bean file uses utf-8 encoding format, and if you use this program on the Win platform in the Chinese environment, since the default encoding of Python's open method depends on the platform (the default encoding of the Win platform is gbk), it will try to use gbk to Decode utf-8 .bean file, then produce UnicodeDecodeError

Good catch!
Since the stock lexer already relies on UTF-8 in a few places like this and rejects GBK characters anyway, I'll just assume UTF-8 on the input and not try to detect the encoding.

Should have been fixed in fc75acc85667b90674a0e96e4cf809328456e913 / v0.1.5. Please reopen if the issue remains.


Unable to filter using .Not("script") and .Not("style")

I may be doing something wrong, but I assumed this would work as it was. I can do doc.Find("script") and doc.Find("style") and get the right elements, but .Not doesn't seem to filter them out, if for example I do doc.Find("head").Not("script") then the script node is still there.

Hey John,
I think the error is that you assume that Not will filter children nodes. It doesn't, it filters out nodes in the matching set, so if you do doc.Find("head"), then the set of matching nodes is very likely only a "head" element (so there are no "script" elements to remove).
Not is useful, for example, if you want all divs that don't have the foo class, then you can do doc.Find("div").Not(".foo").
Martin

Hey Martin, you're right, I had assumed that Not would apply recursively, sorry about that, and thanks for clearing this up!


Update docs for new example best practices and breaking API changes

Closing with https://github.com/mit-cave/cave_app/commit/9ae43d4375f704fd059784d06502fe637cdab0e7


CreateProcessW failed 193, on flutter doctor & flutter upgrade

Have some serious issues with my flutter in both intelliJ Ultimate and Android studio. Problems started occurring while i was trying to get the camera package to my project in the pubspec.yaml file. Then i tried to run the doctor, but that failed aswell, not sure what to do guys...
Please ask if there is something you dont understand with my English, not my first language :)
list of problems i am having:

packages get: exit code 0
doctor/doctor -v: CreateProcessW failed 193

flutter_02.log
flutter_03.log
flutter_04.log
flutter_01.log
-----------------terminal output--------------------------------------------------
Microsoft Windows [Version 10.0.17134.48]

C:\AndroidProjects\chappy2\chappy>C:\flutter\flutter\bin\flutter.bat config --no-analytics
Analytics reporting disabled.

C:\AndroidProjects\chappy2\chappy>C:\flutter\flutter\bin\flutter.bat update-packages
Running "flutter packages get" in automated_tests...         0,9s
Running "flutter packages get" in complex_layout...          1,2s
Running "flutter packages get" in microbenchmarks...         1,1s
Running "flutter packages get" in bots...                    1,0s
Running "flutter packages get" in devicelab...               1,1s
Running "flutter packages get" in channels...                1,1s
Running "flutter packages get" in external_ui...             1,1s
Running "flutter packages get" in flavors...                 0,9s
Running "flutter packages get" in platform_interaction...    0,9s
Running "flutter packages get" in ui...                      1,2s
Running "flutter packages get" in manual_tests...            0,8s
Running "flutter packages get" in vitool...                  0,8s
Running "flutter packages get" in tools...                   1,0s
Running "flutter packages get" in catalog...                 1,0s
Running "flutter packages get" in flutter_gallery...         1,3s
Running "flutter packages get" in flutter_view...            0,7s
Running "flutter packages get" in hello_world...             0,9s
Running "flutter packages get" in layers...                  1,0s
Running "flutter packages get" in platform_channel...        0,9s
Running "flutter packages get" in platform_channel_swift...  0,9s
Running "flutter packages get" in platform_view...           0,5s
Running "flutter packages get" in stocks...                  0,9s
Running "flutter packages get" in flutter...                 0,9s
Running "flutter packages get" in flutter_driver...          0,9s
Running "flutter packages get" in flutter_localizations...   0,9s
Running "flutter packages get" in flutter_test...            1,0s
Running "flutter packages get" in main...                    0,5s
Running "flutter packages get" in flutter_tools...
! analyzer 0.31.2-alpha.1 from path ..\..\bin\cache\dart-sdk\lib\analyzer
! front_end 0.1.0-alpha.11 from path ..\..\bin\cache\dart-sdk\lib\front_end
! kernel 0.3.0-alpha.11 from path ..\..\bin\cache\dart-sdk\lib\kernel
Running "flutter packages get" in fuchsia_remote_debug_protocol...  1,3s
Downloading lcov data for package:flutter...                 1,2s

Ran 'pub' 29 times and fetched coverage data in 29.7s.

C:\AndroidProjects\chappy2\chappy>C:\flutter\flutter\bin\flutter.bat upgrade-packages
Could not find a command named "upgrade-packages".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.

C:\AndroidProjects\chappy2\chappy>C:\flutter\flutter\bin\flutter.bat upgrade
Upgrading Flutter from C:\flutter\flutter...
Already up to date.

Upgrading engine...
Already up-to-date.

Flutter 0.3.2 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 44b7e7d3f4 (3 weeks ago) • 2018-04-20 01:02:44 -0700
Engine • revision 09d05a3891
Tools • Dart 2.0.0-dev.48.0.flutter-fe606f890b

Running "flutter packages upgrade" in chappy...             18,8s

Running flutter doctor...
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, v0.3.2, on Microsoft Windows [Version 10.0.17134.48], locale nb-NO)
CreateProcessW failed 193

Oops; flutter has exited unexpectedly.
Sending crash report to Google.
Crash report sent (report ID: f334c72beefbe55d)
CreateProcessW failed 193
Crash report written to C:\flutter\flutter\flutter_04.log;
please let us know at https://github.com/flutter/flutter/issues.

C:\AndroidProjects\chappy2\chappy>C:\flutter\flutter\bin\flutter.bat flutter doctor -v
Could not find a command named "flutter".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.

C:\AndroidProjects\chappy2\chappy>C:\flutter\flutter\bin\flutter.bat doctor -v
[√] Flutter (Channel beta, v0.3.2, on Microsoft Windows [Version 10.0.17134.48], locale nb-NO)
    • Flutter version 0.3.2 at C:\flutter\flutter
    • Framework revision 44b7e7d3f4 (3 weeks ago), 2018-04-20 01:02:44 -0700
    • Engine revision 09d05a3891
    • Dart version 2.0.0-dev.48.0.flutter-fe606f890b

-CreateProcessW failed 193
Oops; flutter has exited unexpectedly.
Sending crash report to Google.
Crash report sent (report ID: a83d4aad9b8a2f9b)
-CreateProcessW failed 193                                                                                C
rash report written to C:\AndroidProjects\chappy2\chappy\flutter_01.log;
please let us know at https://github.com/flutter/flutter/issues.

C:\AndroidProjects\chappy2\chappy>

Sorry for the late response.
Is this still an issue with recent Flutter versions?

Does your Windows user name contain a space?
Probably a dup of #18938

C:\Users\my lappy>flutter doctor
CreateProcessW failed 193
CreateProcessW failed 193
Unhandled exception:
ProcessException: %1 is not a valid Win32 application.
Command: C:\Program Files\Git\cmd\git.EXE rev-parse --abbrev-ref --symbolic @{

@rakhirocky365 responded in https://github.com/flutter/flutter/issues/15481#issuecomment-461763247


Bitbucket Server Implementation & Fixes

Implements proper collector for Bitbucket Server. Fixes issues #609 and #583.
For reference - there are two "Bitbucket" apis:

Bitbucket Cloud: https://confluence.atlassian.com/bitbucket/commits-or-commit-resource-389775478.html#commitsorcommitResource-GETacommitslistforarepositoryorcomparecommitsacrossbranches
Bitbucket Server (used to be called Stash): https://developer.atlassian.com/static/rest/stash/3.11.3/stash-rest.html#idp1513136

Atlassian rebranded Bitbucket to Bitbucket Cloud and Stash to Bitbucket Server. More information here: https://confluence.atlassian.com/bitbucketserver/bitbucket-rebrand-faq-779298912.html
This change allows the configuration to determine which one to use and fixes the bitbucket server (stash) implementation.
Summary of changes:

Rename to bitbucket collector to align with Atlassian naming scheme
Added documentation about the difference between Bitbucket Cloud and BitBucket Server (formerly known as Stash)
Fix/implement Bitbucket Server implementation
Add ability to specify which product to use via git.product in the config
Added basic unit tests for BitBucket Server

Changes should still work with older versions of Stash so long as the use the REST api mentioned above.

Build breaking due to https://github.com/miickel/gulp-angular-templatecache/issues/124. Latest PR https://github.com/capitalone/Hygieia/pull/633 will fix this.

How do I kick off another build?
Also, did someone do a force push or history change on the master branch? My bitbucket branch was based off a master branch from Friday but it now has commits that are no longer on the captialone master branch. That seems to be why 7c36a4e and 0c03980 are showing up in this PR.

there were some bug introduced in NPM. Had to change a dependency version for that. Kicking off the build just now.

@MarkRx we had some accidental info leak in one PR. Had to clean up some things. Would you mind doing a fresh PR? Let me know.

I modified my histories to remove the merge commit and thus removed the missing changesets. Since I didn't conflict with anyone and worked in a new folder it should merge fine even though my branch is now based off of an older master.

ERROR c.c.d.c.DefaultBitbucketServerClient - Failed to obtain commits from http:///rest/api/1.0/projects/stash/repos/projects//repos//....

when my application.properties has git.host=http://<stash_ip>/stash
git.api=/rest/api/1.0
git.product=server

ERROR c.c.d.c.DefaultBitbucketServerClient - Failed to obtain commits from http:///stash/rest/api/1.0/projects/stash/repos/projects//repos//....

when my application.properties has git.host=http://<stash_ip>/
git.api=/stash/rest/api/1.0
git.product=server
Even I tried with git.product=cloud also. but every time it is taking wrong URL!! it is unnecessarily adding an extra line "projects/stash/repos" after correct URL.


Vue3.2版本引入vue3-draggable-resizable组件出现大量警告。

1、[Vue warn]: injection "identity" not found.
2、[Vue warn]: setup() return property "$setWidth" should not start with "$" or "" which are reserved prefixes for Vue internals
3、[Vue warn]: setup() return property "$setHeight" should not start with "$" or "" which are reserved prefixes for Vue internals.

[Vue warn]: setup() return property "$setWidth" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "$setHeight" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "$setTop" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "$setLeft" should not start with "$" or "_" which are reserved prefixes for Vue internals.
[Vue warn]: setup() return property "$setScale" should not start with "$" or "_" which are reserved prefixes for Vue internals.

Seems like we need to remove the variable that starts with "$".

你好，这个是Vue内部对$和_开头的变量做的检测，其实不影响功能，我会在以后针对这个做一些修复，感谢反馈。


karma 1.0 desn't work well on windows 10

Expected behavior
karma start test/karma.conf.js
connect to socket and watch files
Actual behavior
the console just output:
Starting borser PhantomJS
Enviroment Details

Karma version (output of karma --version): 1.3
Relevant part of your karma.config.js file

// Karma configuration
// Generated on 2016-06-20
'use strict';
module.exports = function (config) {

  config.set({
    // enable / disable watching file and executing tests whenever any file changes
    autoWatch: true,

    // base path, that will be used to resolve files and exclude
    basePath: '../',

    // testing framework to use (jasmine/mocha/qunit/...)
    // as well as any additional frameworks (requirejs/chai/sinon/...)
    frameworks: [
      'jasmine'
    ],

    // list of files / patterns to load in the browser
    files: [
      'app/lib/angular/angular.js',
      'app/lib/angular-ui-router/release/angular-ui-router.js',
      'app/lib/ocLazyLoad/dist/ocLazyLoad.js',
      'app/lib/angular-cookies/angular-cookies.js',
      'app/lib/angular-mocks/angular-mocks.js',
      // bower:js
      // endbower
      'build/core/script/core.js',
      'test/mock/**/*.js',
      'test/unit/**/*.js'
    ],

    // list of files / patterns to exclude
    exclude: [],

    // web server port
    port: 8080,

    // Start these browsers, currently available:
    // - Chrome
    // - ChromeCanary
    // - Firefox
    // - Opera
    // - Safari (only Mac)
    // - PhantomJS
    // - IE (only Windows)
    browsers: [
      'PhantomJS'
    ],

    // Which plugins to enable
    plugins: [
      'karma-phantomjs-launcher',
      'karma-jasmine',
      "karma-coverage"
    ],

    // Continuous Integration mode
    // if true, it capture browsers, run tests and exit
    singleRun: false,

    colors: true,

    // level of logging
    // possible values: LOG_DISABLE || LOG_ERROR || LOG_WARN || LOG_INFO || LOG_DEBUG
    logLevel: config.LOG_INFO,
    reporters: ['progress', 'coverage'],
    preprocessors: {
      'build/*/script/*.js': ['coverage']
    }

    // Uncomment the following lines if you are using grunt's server to run the tests
    // proxies: {
    //   '/': 'http://localhost:9000/'
    // },
    // URL root prevent conflicts with the site root
    // urlRoot: '_karma_'
  });
};

Steps to reproduce the behaviour

karma start test/karma.conf.js

plus
OS; win 10
nodejs 4
When I use 0.9 version, it is OK~

Can you please check if this is still an issue with the latest release?

I'm getting the same issue on the latest version (1.1.2):

We're using phantomjs-prebuilt#2.1.9, installed locally in the project.


App catalog doesn't work for F-Droid build

Describe the bug
The category doesn't work (shows everything regardless of the selection) and installing any app will fail silently (shows progress bar but immediately went back to showing the "Install" button without installing the app). Almost exactly like when it was still in dummy mode recently.
To Reproduce
Steps to reproduce the behavior:

Go to app catalog
Try to install anything or use the category

Expected behavior
The category and app installation works as it should.
Logs
Add debug logs
Target
App: 1.6.1 (fdroid) running on Android 13.
Flipper: 0.87.0 on f7
Additional context
Add any other context about the problem here.

Could you, please, attach report I'd from "Report Bug" button in options menu?

@LionZXY Report bug button seems to crash the app on my phone.
I can't access the logcat due to absence of PC but I can provide it later in a few days if you'd like me to. Meanwhile you may be able to reproduce it locally as well.

Fix already merged in dev, so waiting for fdroid to update their version.

https://gitlab.com/fdroid/fdroiddata/-/commit/a7752747adc45eb4fb0e703faac23a83eb1d3f76

1.6.2 is on F-Droid. Unfortunately it doesn't seem to fix the issue.
Logcat output that might be relevant:
08-04 10:43:56.517 17537 17579 E FapQueueRunner: While executing Install(applicationAlias=pokemon, applicationUid=64971d4d577d519190ede5c6, applicationName=Pokemon Trading, toVersion=FapItemVersion(id=64971d4e577d519190ede61e, version=1.2, target=Received(target=f7, sdk=34.3), buildState=READY), categoryAlias=GPIO, iconUrl=https://catalog.flipperzero.one/api/v0/application/version/assets/64971d4d577d519190ede5c7)
08-04 10:43:56.517 17537 17579 E FapQueueRunner: ho.d: Client request(GET https://catalog.flipperzero.one/api/v0/application/version/64971d4e577d519190ede61e/build/compatible?=&=) invalid: 400 Bad Request. Text: "{"detail":{"status":"error","details":"You must provide at least one parameter"}}"

Also the "report bug" button still crashes the app. The logcat output isn't very useful in this case due to code minification.

Sounds very strange - version 1.6.3 has now been released, once fdroid is updated it should fix it

I checked out the August 5 version from F-Droid. The installation works. Please check again

It works for me as well. Thank you very much for the quick fix.


Docker Problem

i'm triying to run docker imagen on a Rpi 4 with Raspbian GNU/Linux 10 (buster):
When i'm using docker command:

docker run -it \
-e MQTT_BROKER=myserver.com \
-e MQTT_USERNAME=xxxxxxx \
-e MQTT_PASSWORD=yyyyyyy \
-p 8080:8080 \
bachya/ecowitt2mqtt:latest

I'm getting this error:

Digest: sha256:69c9bc16539bcdb4b4058c5de5327a7070ea16257aab878ecef40254bded0f13
Status: Downloaded newer image for bachya/ecowitt2mqtt:latest
Traceback (most recent call last):
File "/venv/bin/ecowitt2mqtt", line 5, in
from ecowitt2mqtt.main import main
File "/venv/lib/python3.9/site-packages/ecowitt2mqtt/main.py", line 10, in
import uvloop
File "/venv/lib/python3.9/site-packages/uvloop/init.py", line 7, in
from .loop import Loop as __BaseLoop  # NOQA
ImportError: Error loading shared library ld-linux-armhf.so.3: No such file or directory (needed by /venv/lib/python3.9/site-packages/uvloop/loop.cpython-39-arm-linux-gnueabihf.so)

What is going wrong?
I have tried latest and dev branch

Are you using a 32-bit or 64-bit version of Raspbian?


[WIP] Fix exception on chain with unknown chainId

PR-Codex overview
The focus of this PR is to refactor the chain data fetching logic and improve error handling in the NetworkSelector component.
Detailed summary

Refactored chain data fetching logic in utils.ts
Improved error handling during chain data fetching
Added a new function createChainMetadata to create chain metadata objects

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

creating a dev build for now - need to test this further / modify

/release-pr

we should also add the icon to Chain object type - a user can pass the icon to defineChain but it does not make it's way to Chain

/release-pr


refactor(commands): get projectName before branching off into CLI

This refactor lays the groundwork for deleting the project folder if any error occurs while the CLI is running. It does this by determining & finalizing the project name before doing anything else within the command.
Two instances of asking the user and/or checking arguments for the project name have been "hoisted up" from cli/src/utilities/runCLI and cli/src/utilities/runIgnite into cli/src/commands/create-expo-stack, where we can now use the projectName in the last error handler for any purposes (such as deleting the generated project folder).

bun test was not working locally for me, but I'm not sure if that's because I was running tests against an older build. Testing seemed to work fine.

[x] Fixed an issue with Ignite not being prompted for a project name, if one isn't provided in CLI arguments
[x] Fixed an issue with Ignite failing due to undefined pascalCase
[x] Rebased and tested/fixed issues there

Ready for review.


Make it easier to test-run manually

NO need to leak ramalama storage into container any longer.
Since we are disabling SELinux don't add Z.
Summary by Sourcery
Enhance the test infrastructure by introducing a new helper function to skip tests in non-local environments and updating a specific test to use this function. Add a new Makefile target to simplify manual test execution. Remove unnecessary SELinux options from container setup and adjust volume mounting logic.
Enhancements:

Improve the test system by adding a new helper function 'skip_if_notlocal' to conditionally skip tests not supported in non-local environments.

Tests:

Modify the system test 'ramalama run tiny with prompt' to include a conditional skip for non-local environments, ensuring more reliable test execution.

Chores:

Add a new 'test-run' target to the Makefile to facilitate manual test execution with specific environment variables.

@ericcurtin @bmahabirbu PTAL

@ericcurtin @bmahabirbu PTAL

Nice! I tested 030-run.bats and it correctly identified when Ramalama is working vs not.
I'm wondering if it would be worth capturing the stderr and stdout for a more detailed failure for certain exit codes, I can look into this!

Yes I wish that we could test this in CI/CD system, but everytime I turn it on, it blows up.


[Suggestion] Pokemon IV perfection, Candy, Stardust

[Suggestion] Pokemon IV perfection, Candy, Stardust

What about candy and stardust?
You can already fetch the number of candies / pokemon family and the amount of stardust from the player profile.
See the RetrievePlayerProfile.php and the example below.
I will look into IV when I got time.
// Retrieve the pokemon go api instance
$pokemonGoApi = $application->getPokemonGoApi();

// Retrieve the inventory
$inventory = $pokemonGoApi->getInventory();

// Retrieve the candy bank
$candyBank = $inventory->getItems()->getCandyBank();

// Retrieve the pidgey candy item
$candyItem = $candyBank->get(PokemonFamilyId::FAMILY_PIDGEY);

echo sprintf('Number or pidgey candies \'%s\'', $candyItem->getCount());

Resolved


Cluster gets stuck after creating a new replica if there's no primary

We're assesing cloudnative pg for running a production postgres instance and I encountered something strange.
When primary instance gets shut down and replica creation is in progress, it will be forever stuck, since it can't connect to the primary:
➜  ~ k get cluster -A
NAMESPACE   NAME   AGE   INSTANCES   READY   STATUS                   PRIMARY
app         hub    16h                       Creating a new replica   hub-4

➜  ~ k logs -f hub-5-join-gfx7t
Defaulted container "join" out of: join, bootstrap-controller (init)
{"level":"info","ts":"2023-04-12T08:53:57Z","msg":"Refreshed configuration file","logging_pod":"hub-5-join","filename":"/controller/certificates/server.crt","secret":"hub-server"}
{"level":"info","ts":"2023-04-12T08:53:57Z","msg":"Refreshed configuration file","logging_pod":"hub-5-join","filename":"/controller/certificates/server.key","secret":"hub-server"}
{"level":"info","ts":"2023-04-12T08:53:57Z","msg":"Refreshed configuration file","logging_pod":"hub-5-join","filename":"/controller/certificates/streaming_replica.crt","secret":"hub-replication"}
{"level":"info","ts":"2023-04-12T08:53:57Z","msg":"Refreshed configuration file","logging_pod":"hub-5-join","filename":"/controller/certificates/streaming_replica.key","secret":"hub-replication"}
{"level":"info","ts":"2023-04-12T08:53:57Z","msg":"Refreshed configuration file","logging_pod":"hub-5-join","filename":"/controller/certificates/client-ca.crt","secret":"hub-ca"}
{"level":"info","ts":"2023-04-12T08:53:57Z","msg":"Refreshed configuration file","logging_pod":"hub-5-join","filename":"/controller/certificates/server-ca.crt","secret":"hub-ca"}
{"level":"info","ts":"2023-04-12T08:53:57Z","msg":"Waiting for server to be available","logging_pod":"hub-5-join","connectionString":"host=hub-rw user=streaming_replica port=5432 sslkey=/controller/certificates/streaming_replica.key sslcert=/controller/certificates/streaming_replica.crt sslrootcert=/controller/certificates/server-ca.crt application_name=hub-5-join sslmode=verify-ca dbname=postgres connect_timeout=5 replication=1"}
{"level":"info","ts":"2023-04-12T08:53:57Z","msg":"DB not available, will retry","logging_pod":"hub-5-join","err":"failed to connect to `host=hub-rw user=streaming_replica database=postgres`: dial error (dial tcp <IP_ADDRESS>:5432: connect: connection refused)"}
{"level":"info","ts":"2023-04-12T08:54:02Z","msg":"DB not available, will retry","logging_pod":"hub-5-join","err":"failed to connect to `host=hub-rw user=streaming_replica database=postgres`: dial error (dial tcp <IP_ADDRESS>:5432: connect: connection refused)"}
... same lines over-and-over again

And the primary also won't get recreated. I'm not sure how to fix this, because I can't create primary, and I can't remove the new broken replica instance. The only way to get out of this seem to be to create a new cluster. Am I wrong here though?
How to reproduce:

Create cluster with 1 instance.
Scale up to 2 instances.
Delete primary instance which is already initialized by running kubectl delete pod while replica creation is running.

What it should do instead is realize that there's no primary and try to re-create it?
I have a setup like this:
apiVersion: postgresql.cnpg.io/v1
kind: Cluster
metadata:
  name: hub
  namespace: app
spec:
  # One primary and two standby servers
  instances: 1

  affinity:
    nodeSelector:
      workload-type: database

    tolerations:
      - key: "DatabaseWorkloads"
        operator: "Exists"
        effect: "PreferNoSchedule"

  backup:
    barmanObjectStore:
      destinationPath: "gs://hub-pg-backups-staging"
      googleCredentials:
        gkeEnvironment: true

  serviceAccountTemplate:
    metadata:
      annotations:
        iam.gke.io/gcp-service-account<EMAIL_ADDRESS>
  # Sets the resources for Guaranteed QoS
  resources:
    requests:
      memory: "1Gi"
      cpu: 100m
    limits:
      memory: "4Gi"
      cpu: 2

  # Sets the 50GB storage for PGDATA
  # This volume will also be used by the import
  # process to temporarily store the custom format
  # dump coming from the source database
  storage:
    size: 50Gi
#
#  # Initializes the cluster from scratch (initdb bootstrap)
  bootstrap:
    initdb:
      # Enables data checksums
      dataChecksums: true
      # Sets WAL segment size to 32MB
      walSegmentSize: 32
      import:
        type: microservice
        databases:
          - hub
        source:
          externalCluster: imported-cluster
#
#  # Defines the cluster-pg10 external cluster
#  # by providing information on how to connect to the Postgres
#  # instance, including user and password (contained in a
#  # separate secret that you need to create).
  externalClusters:
    - name: imported-cluster
      connectionParameters:
        host: postgres-backup.default.svc.cluster.local
        port: "5432"
        user: youthink
        dbname: hub
      password:
        name: imported-cluster-credentials
        key: password

Hi @Blitss
If the cluster it's being created and for some reason, the primary it's destroyed, the cluster can't be recovered, hence, the cluster will never reach a consistent state, with this in mind, that means that that cluster was never ready to work and shouldn't be used, so the solution will be to destroy the cluster and create a new one.
Can you suggest how it should behave or why this behavior may not be desired?
I'm turning this into a discussion before it turns into an active issue
Thanks and regards!


Azure Cosmos v3

Hi,
I want to know there is any roadmap for Azure Cosmos .Net Sdk v3?
Thanks.

In what capacity? Is there something specific you are looking to be supported?

There isn't specific feature. I am using v3 and there are 2 nuget packages in the project. Microsoft.Azure.DocumentDb and Microsoft.Azure.Cosmos.
V3 has some useful capabilities. Transactions, unique keys, bulk operations, bulk transactions, change feed support, performance and sql syntax improvements. It's new. :) I think v2 will retire soon.
https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/changelog.md
https://azure.microsoft.com/en-us/blog/new-for-developers-azure-cosmos-db-net-sdk-v3-now-available/

Does the latest SDK work with the Cosmos DB Emulator? That's used for the unit tests, so it would be a concern if it isn't supported going forward.

Yes, latest sdk works with latest emulator version.
Also current documentdb test fails with Comos Db Emulator(v2.9.2). I didn't change anything. Just cloned.

Current documentdb saga persistence integration is not working with local emulator v2.9.2 and Azure. Because of partitionKey is mandatory for all new cosmosdb accounts.
You can reproduce this issue with an Azure CosmosDB database or Azure Cosmos Emulator. Create partitioned collection/container from UI or code.
https://docs.microsoft.com/en-us/azure/cosmos-db/local-emulator
UsingDocumentDb_Specs.cs
[OneTimeSetUp]
public async Task Setup()
{
       PartitionKeyDefinition pkDefn = new PartitionKeyDefinition() { Paths = new Collection<string>() { "/id" } };

        await _documentClient.OpenAsync();
        await _documentClient.CreateDatabaseIfNotExistsAsync(new Database { Id = _databaseName }).ConfigureAwait(false);
        await _documentClient.CreateDocumentCollectionIfNotExistsAsync(UriFactory.CreateDatabaseUri(_databaseName), new DocumentCollection { Id = _collectionName, PartitionKey = pkDefn }).ConfigureAwait(false);
}

Duplicate of https://stackoverflow.com/questions/61453341/masstransit-saga-persistence-with-azure-cosmosdb-doesnt-work-with-containers-wi
System.InvalidOperationException: PartitionKey value must be supplied for this operation.    at Microsoft.Azure.Documents.Client.DocumentClient.AddPartitionKeyInformationAsync(DocumentServiceRequest request, RequestOptions options)    at Microsoft.Azure.Documents.Client.DocumentClient.ReadDocumentPrivateAsync(String documentLink, RequestOptions options, IDocumentClientRetryPolicy retryPolicyInstance, CancellationToken cancellationToken)    at Microsoft.Azure.Documents.BackoffRetryUtility`1.ExecuteRetryAsync(Func`1 callbackMethod, Func`3 callShouldRetry, Func`1 inBackoffAlternateCallbackMethod, TimeSpan minBackoffForInBackoffCallback, CancellationToken cancellationToken, Action`1 preRetryCallback)    at Microsoft.Azure.Documents.ShouldRetryResult.ThrowIfDoneTrying(ExceptionDispatchInfo capturedException)    at Microsoft.Azure.Documents.BackoffRetryUtility`1.ExecuteRetryAsync(Func`1 callbackMethod, Func`3 callShouldRetry, Func`1 inBackoffAlternateCallbackMethod, TimeSpan minBackoffForInBackoffCallback, CancellationToken cancellationToken, Action`1 preRetryCallback)    at MassTransit.DocumentDbIntegration.Saga.Context.DocumentDbDatabaseContext`1.Load(Guid correlationId, CancellationToken cancellationToken)    at MassTransit.DocumentDbIntegration.Saga.Context.DocumentDbSagaRepositoryContext`2.Load(Guid correlationId)    at MassTransit.Saga.SendSagaPipe`2.Send(SagaRepositoryContext`2 context)    at MassTransit.ExtensionsDependencyInjectionIntegration.ScopeProviders.DependencyInjectionSagaRepositoryContextFactory`1.<>c__DisplayClass6_0`1.<<Send>g__CreateScope|0>d.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at MassTransit.Saga.Pipeline.Filters.CorrelatedSagaFilter`2.GreenPipes.IFilter<MassTransit.ConsumeContext<TMessage>>.Send(ConsumeContext`1 context, IPipe`1 next)

I use the CosmosDB emulator with every build and it works fine with the current saga repository.
I also created a new CosmosDB account just last week and it works fine as well.

I think the container that you created is non-partitioned.

Azure Cosmos DB supports creating containers without a partition key. Currently you can create non-partitioned containers by using Azure CLI and Azure Cosmos DB SDKs (.Net, Java, NodeJs) that have a version less than or equal to 2.x. You cannot create non-partitioned containers using the Azure portal. However, such non-partitioned containers aren’t elastic and have fixed storage capacity of 20 GB and throughput limit of 10K RU/s.

To support the migration, Azure Cosmos DB provides a system defined partition key named /_partitionkey on all the containers that don’t have a partition key.

https://docs.microsoft.com/en-us/azure/cosmos-db/migrate-containers-partitioned-to-nonpartitioned

I didn't do anything special, I just created the resource in Azure via the UI. I didn't do anything special, and everything worked out of the box - all the unit tests passed.

Just to chime in here. I started a bit on updating to use cosmos sdk v3 last night. Yes, partition keys are now required.
AppVeyor uses the emulator 2.7.0 I think. So that's my guess why appveyor int tests still work.
the emulator I downloaded on my PC was 2.11.0 (appears to be the latest). So I will be developing the update against that emulator version.
The package will also be getting renamed. no longer MassTransit.DocumentDb, but instead I'm thinking MassTransit.Azure.Cosmos.
I don't have an ETA yet, but I've started. My guess would be that it will be in for v7.

Closed by https://github.com/MassTransit/MassTransit/commit/6f601294f60ae8ce23e9bc74b9268b29831a4d70


Tmp folder with Window service to add a wiki page

For bug reports, please give the relevant info:

Gogs version (or commit ref):  <IP_ADDRESS>9
Git version: 2.5.1
Operating system: Windows 7
Database:

SQLite

Can you reproduce the bug at http://try.gogs.io:

[ ] Not relevant

Log gist:
2016/06/10 15:01:22 [...routers/repo/wiki.go:216 NewWikiPost()] [E] AddWikiPage: UpdateLocalWiki: Clone: exit status 128 - fatal: destination path 'data/tmp/local-wiki/14' already exists and is not an empty directory.

Description
I am running gogs with Windows service. gogs add a data/tmp folder under "C:\Windows\System32\data\tmp\local-wiki" and "C:\Windows\SysWOW64\data\tmp\local-wiki". The tmp folder supposed to under the installed folder of gogs.

The fail to delete folder on Windows bug is fixed in master branch.


Updated Example for System.Hashtable

Added Example to HashTable API
Summary
Added a PowerShell example and fixed earlier typo.

No need to open new PRs to make fixes @doctordns. Tagging @zjalexander to review this too.
Internal Review URL
Some of my previous comments (except for the typo still apply to this PR as well).

I can not get to that Internal review site. :-(
ANd as far as PRs - I am still learning this GitHub thing slowly...

@mairaw did you mean me above?

I know @doctordns. 😢 We wanna find out a way to open up to external contributors. That's why I said it was internal.
Nope @JRAlexander. I really meant Zach. He's the Powershell PM. 😄

And no worries about still learning how GitHub works @doctordns. We've all been there.
Ask for advice when you need too! We (the repo maintainers) can even make edits on your fork if needed.

I think that despite my mistakenly closing then re-opening this P/R, the change to the XML file is still good...
At least I hope so!
And I do have some Git learning issues. Thanks for your kind offer of assistance.

I think it would be more idiomatic to use hashtable syntax sugar and adding keys this way instead:
PS> $ht = @{}  # initialize
PS> $ht += @{key1="val1"} # add one key/value (by adding another hashtable)
PS> $ht += @{key2="val2";key3="val3"} # batch add multiple key/val
PS> $ht.key3 = "val4" # literal with a constant key
PS> $k = "key4"; $v = "val4"
PS> $ht[$k] = $v # indexer use for dynamic key add
PS> $ht.$k = $v # alternatively, but indexer is more backwards compatible.

I think using $ht.Add( ... ) is worth putting in there, but it's too c-sharpy.

@oising - I agree with your suggestions over the sample. When I get back from Germany (Here for another 8 days), I'll update the sample incorporating the suggestion.

Where are we with this? Should we close this PR or are you planning to update the PR here @doctordns? Thanks.

Hi @mairaw and thanks for the nudge.
Here is the suggested sample (upated per the discusison here).
What do you think?
Create new hash table using PowerShell syntax
$OpenWith = @{}
Add one element to the hash table using the Add method
$OpenWith.Add('txt', 'notepad.exe')
Add three eleements using PowerShell syntax three different ways
$OpenWith.dib    = 'paint.exe'
$KeyBMP          = 'bmp'
$OpenWith[$KeyBMP] ='paint.exe'
or
$OpenWith += @{'rtf'='wordpad.exe'}
display hash table
'There are {0} in the `$OpenWith hash table as follows:' -f $OpenWith.Count
''
Display hashtable properties
'Count of items in the hashtable  : {0}'  -f $OpenWith.Count
'Is hashtable fixed size?         : {0}'  -f $OpenWith.IsFixedSize
'Is hashtable read-only?          : {0}'  -f $OpenWith.IsReadonly
'Is hashtabale synchronised?      : {0}'  -f $OpenWith.IsSynchronized
''
'Keys in hashtable:'
$OpenWith.Keys
''
'Values in hashtable:'
$OpenWith.Values
''
<#
This script produces the following output:
There are 4 in the $OpenWith hash table as follows:
Name                           Value

txt                            notepad.exe
dib                            paint.exe
bmp                            paint.exe
rtf                            wordpad.exe
Count of items in the hashtable  : 4
Is hashtable fixed size?         : False
Is hashtable read-only?          : False
Is hashtabale synchronised?      : False
Keys in hashtable:
txt
dib
bmp
rtf
Values in hashtable:
notepad.exe
paint.exe
paint.exe
wordpad.exe
#>

It appears that the fork/clone I used to make this initial PR is gone. So there needs to be a new one. I'll close this, then create a new PR. Sorry for any inconvenience.

I am closing this PR. A new one is in progress, addressing the comments in this thread.


8344 Installer secret key text box is not removed after intialization

https://github.com/Shippable/pm/issues/8344

to reproduce

run latest installer
set values for access key, secret key, gitlab and rabbitmq
hit initialize
once initialization is completed successfully, the secret key text box is not removed.

refreshing the page removes it

complete. closing.


for not copying on iOS

Please see this repro:
https://warp-nail.glitch.me <- browse to this url on iOS Simulator
https://glitch.com/edit/#!/warp-nail?path=index.html <- source
Note that the other ways to use this element are working on iOS, just not the for attr.
Probably has something to do with Safari's strict requirements for document.execCommand, as mentioned on this SO: https://stackoverflow.com/questions/34045777/copy-to-clipboard-using-javascript-in-ios

Released in https://github.com/github/clipboard-copy-element/releases/tag/v1.1.1.
FWIW this issue seem to have been fixed in iOS 13.


Swap CloseRead and CloseWrite

To notify the other end of a connection that no writes are going to happen anymore, CloseWrite() should be used.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:andre-luiz-dos-santos/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

ping @mrjana @mavenugo

this sounds right. we have to play with it to confirm.
@andre-luiz-dos-santos out of curiosity, how did you encounter this issue and the use-case that this fix solves ?

can you open a PR in https://github.com/docker/go-connections too?
https://github.com/docker/go-connections/blob/master/proxy/tcp_proxy.go#L48
This package inside Docker is discontinued.

@mavenugo, I'm not affected by this in any way. I'm studying Go and that part looked wrong.

I'm going to close this PR in favor of https://github.com/docker/go-connections/pull/6. Please, redirect all your discussions there. The proxy package should be removed from docker, although libnetwork still depends on it.


Add break and continue to keywords

Thanks!

Hi @chriselrod!
I have to revert. This commit breaks the font-locking. break and continue are not exported as keywords. We need to highlight (break_statement) and (continue_statement). I push a commit to do this.

Done!

Ah, sorry, my bad!
I'll test locally before making a PR next time.

No problem at all!! Thanks to inform me that those keywords were not being highlighted :D


onClose property is not exist/exposed in Lightbox component with TS

The solution could be  toadd
export type LightboxProps = {
  onClose?: () => void;
} & ModalImageProps;

declare class Lightbox extends React.Component<LightboxProps > {}

to this file
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-modal-image/index.d.ts

any commit update for the solution?


Docs landing page (index.rst) reorganization

OpenStack Release
Kilo +
Description
The index.rst page needs to be updated for clarity and usability, per discussion with @mattgreene  and @swormke.

Also, the lbaasv1 link is missing.

should be able to add all other projects as sub-projects and list them on a sub-projects page

add a 'For Developers' section with the branching strategy diagram; any architecture info; other stuff that's directed mainly at developers who want to contribute.


Update Set-CsTeamsEmergencyCallingPolicy.md

Related to https://github.com/MicrosoftDocs/office-docs-powershell/pull/8209.

Docs Build status updates of commit c8f151d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsTeamsEmergencyCallingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@tiburd Please merge this PR. Thanks

Docs Build status updates of commit 441dfd8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsTeamsEmergencyCallingPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Peer to peer code review

Hi @tumainimaganiko , good job so far on the Leaderboard project. Below are some ideas and suggestions about the project, cheers! 👍🏽
HIGHLIGHTS 🎯

The project is well structured and organised into folders/directories ✅
The project has a comprehensive README documentation ✅
The project has been deployed properly and is accessible viewed via the demo link provided ✅
The project is very readable and easy to maintain due to the use of ES6 modules 🥇

RECOMMENDATIONS 🤔

more descriptive variable names could improve readability
could include a window.reload(); or event handler DOMContentLoaded upon clicking the submit button to automatically reload the form values in the list
you could improve the README file with a decriptive features section
you can deploy your app for a higher level of professionalism
could include description on the about section of your GitHub page
perhaps variables can be declared in the global scope for more efficiency

Hi 👋  @andrianarivo  , thanks so much for your suggestions. I have implemented all the suggestions and added some other interesting features 😊😊. Feel free to open a new issue again.


fix: performance improvements for js editor

Description
TL;DR performance improvements for js editor

fix entityNavigationData generation (to prevent unnecessary component updates)

in codeEditor/index.ts (addThisReference was creating a new object everytime)
in navigationSelector.ts (use getJSCollections instead of getJSCollectionsForCurrentPage, which created a new object everytime, even if actions were not updated)

combine markers for navigation and peek overlay to reduce the total number of markers
clear and add marks for only the edited lines instead of the whole file

Note: once a js object is saved, it's still going to trigger a whole file clear and marking.
Because, it's an entity update which needs a whole refresh of the markers.
Fixes #21467
Media
Case: Adding a blank space in js editor.
Reduced un-necessary clears and marks:
Before:

####After:

Reduced entity marker called count:
https://www.loom.com/share/23719f8dfde8457ea0a86f44500ec34a

Reduced markers count:
Before:

After:

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test

/ok-to-test

/build-deploy-preview

/build-deploy-preview env=release

/ok-to-test

Pending QA verification.

Tested this on the DP url, working as expected.


Inconsistent name field value accross oauth provider

Describe the bug
When using Microsoft Oauth the name field for the user is constructed by concatenated Lastname + Firstname however when using other provider like Google its Firstname then Lastname
To Reproduce

Setup Microsoft oauth
Sign up using Microsoft
See the name field

Expected behavior
Name field should be constructed in a consistent way across provider, or the library should provider firstname and lastname field to match provider response.
Desktop (please complete the following information):

OS: Windows
Browser: Firefox

For both providers you mentioned and I think for almost all of them, we don’t combine the name from two values. We simply use the name value provided by the provider.

Yeah, can confirm here
import { parseJWT } from "oslo/jwt";

//...

const user = parseJWT(token.idToken)?.payload as MicrosoftEntraIDProfile;

//...

return {
		user: {
			id: user.sub,
			name: user.name,
			email: user.email,
			image: user.picture,
			emailVerified: true,
		},
		data: user,
};

Ok thanks you for your reply, is there any possibilities that i could use the firstname and lastname value returned by the provider?

It should be possible to do that.
here is the token:
{
    "sub": "OLu859SGc2Sr9ZsqbkG-QbeLgJlb41KcdiPoLYNpSFA",
    "name": "Mikah Ollenburg", // all names require the “profile” scope.
    "family_name": " Ollenburg",
    "given_name": "Mikah",
    "picture": "https://graph.microsoft.com/v1.0/me/photo/$value",
    "email"<EMAIL_ADDRESS>// requires the “email” scope.
}


feat: many fixes

Support array data types. This is incomplete (only supports text[] AFAIK, doesn't quote spaces)
Properly set the enum type (requires extra data from debezium)
Continue on errors (need fix to actually honor the error tolerance setting)

Opened by mistake, sorry

Thanks! I'm planning to follow up on this in the future. For now it was a quick prototype. Will go to Jira in case is needed.


[PE-D][Tester D] Once I mark an applicant status as completed interview, the Upcoming interviews tab still shows the interview details

David Li has completed his interview, But i still see an upcoming interview for David Li on the right.

Labels: severity.Low type.FeatureFlaw
original: tejas-1405/ped#4

duplicate


Merge test cases. - [closed]

In GitLab by @wknet123 on Mar 16, 2018, 02:08
Merges dev-devops -> dev-devops

In GitLab by @wknet123 on Nov 13, 2019, 10:39
the API Server Coverage is  %   UI Coverage is 38.11%   check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:39
the it is failed check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:39
the API Server Coverage is  %   UI Coverage is 38.11%   check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:39
deleted source branch dev-devops

In GitLab by @wknet123 on Nov 13, 2019, 10:39
the it is failed check console log

In GitLab by @wknet123 on Nov 13, 2019, 10:39
closed


Add back list_intersect, list_has_any, list_has_all

These got lost somewhere along the way.
Solves #1145

These were probably lost in the merge I made a few weeks ago, thanks for adding them back!


Costing

It's got a whole lot of TODOs, but all tests run fine. Fire away.

Looks like you may need to regenerate the Nix package set definition.

Now fails due to -Werror, so all fine.

Yes, overhead is something we need to worry about. We should ideally do some measurement before and after this PR. Are our benchmarks up to scratch for this kind of thing?

Yes, overhead is something we need to worry about.

In that case we just shouldn't use the CEK machine, it's not optimal at all.

In that case we just shouldn't use the CEK machine, it's not optimal at all.

Yes, but it's easily understandable and specifiable. We want to write an abstract description of the costing model, that's probably going to work with an abstract description of how the CEK machine works. The more complicated we make it the harder that is.
But we shouldn't make things unnecessarily more expensive, especially on the "mere programming" side of it.

I think these are the major points:

[ ] finish Note on ExMemory
[ ] Some tests on using the overall CeK


Return initial difficulty for when the previous block is Genesis

More info in #1002

The failed test in CI was cancel_received() in blockprod/src/detail/test.rs. This test creates a new Genesis with an initial difficulty of zero...
The 57ee633 commit was supposed to return the chain config's current PoW limit i.e zero, however after following the call stack, it was never using the overridden value, as seen in get_proof_of_work_config() from commit e2b9d75.
These last few commits creates a PoWChainConfig builder which allows the caller to override chain settings -as is done now in get_proof_of_work_config() to override the difficulty by looking at NetUpgrades rather than straight to the default value.


Changes for OpenAL version 1.19+

OpenAL 1.19 renamed ALCdevice_struct to ALCdevice, creating name clashes.
This change is not backward compatible, however, the versioning of the library did not change.
Therefore, we cannot check which one to use.

Sorry I can't merge this PR. It breaks compatibility with the Ubuntu-20.04 libopenal-dev package.
Can we just remove the forward declaration and move #include<alc.h> to SoundManager.h?

That is possible.


Add the release-note-none to dependabot

Changes
Without the release label, dependabot PRs cannot be merged.
Altering the PR to add the label means that dependabot won't
be able to manage its PR anymore, so adding the release note
label by default.
Signed-off-by: Andrea Frittoli<EMAIL_ADDRESS>/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[ ] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes
NONE

Setting the release note to NONE sounds good but it will be useful if the PR approver can document which dependency was upgraded from what version. Thoughts?

/lgtm

Setting the release note to NONE sounds good but it will be useful if the PR approver can document which dependency was upgraded from what version. Thoughts?

That would be in the PR description created by dependabot, or are you thinking of some other place we should document it?
We could include it in the release notes but we've not done it until now.

Setting the release note to NONE sounds good but it will be useful if the PR approver can document which dependency was upgraded from what version. Thoughts?

That would be in the PR description created by dependabot, or are you thinking of some other place we should document it? We could include it in the release notes but we've not done it until now.

Thanks @afrittoli
Yeah I was thinking of including it in the release notes.
So the dependabot PRs has the details in the PR title that its upgrading a package from one version to the other. If we can automatically capture the same details in the PR release notes such that the release manager (task) can list them in a separate section when creating a release.


migrate disable-master-test (RIPD-1258)

Details
Migrate existing js tests. Most of the coverage for SetRegularKey is
already provided by Env_test.cpp and MultiSign.test.cpp, so I've largely
copied/simplified some of that existing test code for the purpose of
these new tests. Add coverage for one additional error case.

Current coverage is 71.03% (diff: 100%)

Merging #1811 into develop will increase coverage by 0.04%

@@            develop      #1811   diff @@
==========================================
  Files           869        870     +1
  Lines         69535      69586    +51
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          49363      49431    +68
+ Misses        20172      20155    -17
  Partials          0          0

Powered by Codecov. Last update d51a278...d1cfa17

Left one small nit for an unnecessary comment. Please consider editing the commit message down to: "Migrate SetRegularKey unit tests (RIPD-1258)"
:+1:

Merged as 1c6e32ccc21ef3aeb0d3a6f59c242552c3222f92


Migrate to 12.0 :camel:

A friendly conversion provided by market-up2date-keeper :robot: :handshake:

Only updates. Anything you had to change otherwise?

the last two commits were done manually. but no big deal in there ...  just house-keeping


Feature/adding tokens instead of redirections

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
4

Relevant Lines:
4

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
4

Relevant Lines:
4

💛  - Coveralls


Update Sinon Library Version for Chat JS SDK

This PR is used to update the Sinon library version for Chat JS SDK.
Why is this change needed?
We updated the Sinon Library Version of Signaling Client Code Repo to resolve a government alert. And Chat SDK will depend on signaling client. If they have the same dependency installed, the dependency version should be the same.
As a result, we are supposed to update the library version of JS SDK for version number alignment.
Testing
1.Unit tests passed after the change
2.E2E test passed using the sample app

API change check
API changes are not detected in this pull request.


OpenSuSE 15.3 Python version detection error after yt-dlp -U but not with pm.rpm

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2023.02.17 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
OS: openSuSE 15.3, up to date 21.02.23
It started with "Current version: 2023.01.06"
$ yt-dlp -k https://youtu.be/KQRaj1vcnrs
[youtube] Extracting URL: https://youtu.be/KQRaj1vcnrs
[youtube] KQRaj1vcnrs: Downloading webpage
[youtube] KQRaj1vcnrs: Downloading android player API JSON
ERROR: [youtube] KQRaj1vcnrs: Unable to extract uploader id; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
I updated and got the result in "Complete Verbose Output".
However updating with zypper
yt-dlp-2023.02.17-pm153.2.1.noarch.rpm
it works again.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vUk', 'https://youtu.be/KQRaj1vcnrs']
ERROR: Python version 3.6 is no longer supported! Please update to Python 3.7 or above; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/bin/yt-dlp/__main__.py", line 17, in <module>
    yt_dlp.main()
  File "/usr/bin/yt-dlp/yt_dlp/__init__.py", line 967, in main
    _exit(*variadic(_real_main(argv)))
  File "/usr/bin/yt-dlp/yt_dlp/__init__.py", line 927, in _real_main
    with YoutubeDL(ydl_opts) as ydl:
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 618, in __init__
    f'{msg}! Please update to Python %d.%d or above' % (*current_version, *MIN_RECOMMENDED))
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1000, in deprecation_warning
    message, stacklevel=stacklevel + 1, printer=self.report_error, is_error=False)
  File "/usr/bin/yt-dlp/yt_dlp/utils.py", line 2059, in deprecation_warning
    return printer(f'{msg}{bug_reports_message()}', **kwargs)
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 1012, in report_error
    self.trouble(f'{self._format_err("ERROR:", self.Styles.ERROR)} {message}', *args, **kwargs)
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 941, in trouble
    tb_data = traceback.format_list(traceback.extract_stack())

[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out UTF-8, error UTF-8, screen UTF-8
[debug] yt-dlp version 2023.02.17 [a0a7c01] (zip)
[debug] Python 3.6.15 (CPython x86_64 64bit) - Linux-6.1.11-jk-x86_64-with-glibc2.3.4 (OpenSSL 1.1.1d  10 Sep 2019, glibc 2.3.4)
Traceback (most recent call last):
  File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/bin/yt-dlp/__main__.py", line 17, in <module>
  File "/usr/bin/yt-dlp/yt_dlp/__init__.py", line 967, in main
  File "/usr/bin/yt-dlp/yt_dlp/__init__.py", line 927, in _real_main
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 649, in __init__
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 3792, in print_debug_header
  File "/usr/bin/yt-dlp/yt_dlp/postprocessor/ffmpeg.py", line 97, in get_versions_and_features
  File "/usr/bin/yt-dlp/yt_dlp/postprocessor/ffmpeg.py", line 168, in _versions
  File "/usr/bin/yt-dlp/yt_dlp/compat/functools.py", line 25, in __get__
    try:
  File "/usr/bin/yt-dlp/yt_dlp/postprocessor/ffmpeg.py", line 172, in basename
  File "/usr/bin/yt-dlp/yt_dlp/compat/functools.py", line 25, in __get__
    try:
  File "/usr/bin/yt-dlp/yt_dlp/postprocessor/ffmpeg.py", line 197, in _version
  File "/usr/bin/yt-dlp/yt_dlp/postprocessor/ffmpeg.py", line 185, in _get_version
  File "/usr/bin/yt-dlp/yt_dlp/postprocessor/ffmpeg.py", line 185, in <genexpr>
  File "/usr/bin/yt-dlp/yt_dlp/postprocessor/ffmpeg.py", line 141, in _get_ffmpeg_version
  File "/usr/bin/yt-dlp/yt_dlp/utils.py", line 2721, in _get_exe_version_output
  File "/usr/bin/yt-dlp/yt_dlp/utils.py", line 903, in run
AttributeError: 'Popen' object has no attribute 'text_mode'

ERROR: Python version 3.6 is no longer supported! Please update to Python 3.7 or above; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U

However: python 3.9.15-1503<IP_ADDRESS> is installed!!!
rpm -qa|grep python3.|grep lib|sort
libpeas-loader-python3-1.24.1-1.45.x86_64
libpython3_6m1_0-3.6.15-1503<IP_ADDRESS>.x86_64
libpython3_9-1_0-3.9.15-1503<IP_ADDRESS>.x86_64
libsamba-policy0-python3-4.15.12+git.535.7750e5c95ef-1503<IP_ADDRESS>.x86_64
python3-google-auth-httplib2-0.0.3-1.3.2.noarch
python3-html5lib-1.0.1-1.22.noarch
python3-httplib2-0.19.0-3.3.1.noarch
python3-importlib-metadata-1.5.0-3.3.5.noarch
python3-libxml2-python-2.9.7-150<IP_ADDRESS>.x86_64
python3-matplotlib-2.2.5-3.3.1.x86_64
python3-matplotlib-cairo-2.2.5-3.3.1.x86_64
python3-matplotlib-gtk3-2.2.5-3.3.1.x86_64
python3-matplotlib-qt5-2.2.5-3.3.1.x86_64
python3-matplotlib-tk-2.2.5-3.3.1.x86_64
python3-matplotlib-web-2.2.5-3.3.1.x86_64
python3-python-xlib-0.26-bp153.1.17.noarch
python3-rdflib-4.2.2-bp153.1.22.noarch
python3-rtslib-fb-2.1.74-1503<IP_ADDRESS>.noarch
python3-ruamel.yaml.clib-0.2.0-bp153.1.22.x86_64
python3-urllib3-1.25.10-4.3.1.noarch
samba-libs-python3-4.15.12+git.535.7750e5c95ef-1503<IP_ADDRESS>.x86_64

I don't know the details of how zypper installs yt-dlp, but I'm assuming they are using the zipexe we distribute. In that case, it is using the python3 shebang. You'll have to change the python3 shim to a newer version of python if you want it to run on it.
Alternatively, I would recommend uninstalling the yt-dlp from your PM and using python3.9 -m pip install yt-dlp instead

zypper installs/updates rmp packages from a repo.
In my case yt-dlp is provided by:
https://ftp.gwdg.de/pub/linux/misc/packman/suse/openSUSE_Leap_$releasever/
python3.9 -m pip install yt-dlp
Collecting yt-dlp
Downloading yt_dlp-2023.2.17-py2.py3-none-any.whl (2.9 MB)
|████████████████████████████████| 2.9 MB 2.1 MB/s
Collecting certifi
Downloading certifi-2022.12.7-py3-none-any.whl (155 kB)
|████████████████████████████████| 155 kB 13.2 MB/s
Collecting mutagen
Downloading mutagen-1.46.0-py3-none-any.whl (193 kB)
|████████████████████████████████| 193 kB 14.7 MB/s
Collecting brotli; platform_python_implementation == "CPython"
Downloading Brotli-1.0.9-cp39-cp39-manylinux1_x86_64.whl (357 kB)
|████████████████████████████████| 357 kB 16.2 MB/s
Collecting websockets
Downloading websockets-10.4-cp39-cp39-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (106 kB)
|████████████████████████████████| 106 kB 11.6 MB/s
Collecting pycryptodomex
Downloading pycryptodomex-3.17-cp35-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (2.1 MB)
|████████████████████████████████| 2.1 MB 16.2 MB/s
Installing collected packages: certifi, mutagen, brotli, websockets, pycryptodomex, yt-dlp
Successfully installed brotli-1.0.9 certifi-2022.12.7 mutagen-1.46.0 pycryptodomex-3.17 websockets-10.4 yt-dlp-2023.2.17

Both ways are fine:

zypper update
pip install

I'm currently dealing with this same error on my M1 mac as well.
$ python -V
Python 3.9.1
$ pip freeze | grep -i yt-dlp
yt-dlp==2023.2.17

Here's the stacktrace:
[youtube] Extracting URL: https://www.youtube.com/watch?v=zf1aZHSXFNU
[youtube] zf1aZHSXFNU: Downloading webpage
[youtube] zf1aZHSXFNU: Downloading android player API JSON
[youtube] zf1aZHSXFNU: Downloading MPD manifest
[info] zf1aZHSXFNU: Downloading 1 format(s): 137+140
[info] There's no subtitles for the requested languages
Traceback (most recent call last):
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/app.py", line 715, in download_url
    extracted_info = ydl.extract_info(url)
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/YoutubeDL.py", line 1491, in extract_info
    return self.__extract_info(url, self.get_info_extractor(key), download, extra_info, process)
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/YoutubeDL.py", line 1502, in wrapper
    return func(self, *args, **kwargs)
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/YoutubeDL.py", line 1599, in __extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/YoutubeDL.py", line 1658, in process_ie_result
    ie_result = self.process_video_result(ie_result, download=download)
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/YoutubeDL.py", line 2763, in process_video_result
    self.process_info(new_info)
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/YoutubeDL.py", line 3186, in process_info
    elif not merger.available:
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/postprocessor/ffmpeg.py", line 205, in available
    return self.basename is not None
  File "/Users/christopherhranj/.pyenv/versions/3.9.1/lib/python3.9/functools.py", line 969, in __get__
    val = self.func(instance)
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/postprocessor/ffmpeg.py", line 172, in basename
    self._version  # run property
  File "/Users/christopherhranj/.pyenv/versions/3.9.1/lib/python3.9/functools.py", line 969, in __get__
    val = self.func(instance)
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/postprocessor/ffmpeg.py", line 197, in _version
    return self._get_version('ffmpeg')
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/postprocessor/ffmpeg.py", line 184, in _get_version
    basename, version, features = next(filter(
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/postprocessor/ffmpeg.py", line 185, in <genexpr>
    lambda x: x[1], ((p, *self._get_ffmpeg_version(p)) for p in executables)), (None, None, {}))
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/postprocessor/ffmpeg.py", line 141, in _get_ffmpeg_version
    out = _get_exe_version_output(path, ['-bsfs'])
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/utils.py", line 2720, in _get_exe_version_output
    stdout, _, ret = Popen.run([encodeArgument(exe)] + args, text=True,
  File "/Users/christopherhranj/giphy/giphy-services/src/python/gce-api/venv/lib/python3.9/site-packages/yt_dlp/utils.py", line 903, in run
    default = '' if proc.text_mode else b''
AttributeError: 'Popen' object has no attribute 'text_mode'

@BlindDuck any chance youre calling yt-dlp from within a gevent worker or using uwsgi in your project? this turned out to be my issue and i had uwsgi configured incorrectly: https://github.com/yt-dlp/yt-dlp/issues/6317#issuecomment-1439113185


CI - broken link checking improvements [DO NOT MERGE]

Proposed changes
Improving link checking...

[x] check all links in _data/toc.yaml prior to checking html files
[x] consider html base tag
[x] consider self closing html tags
[x] don't fail on redirects (but show them in the logs)
[x] logs: print broken links and redirects in CSV format
[x] overall timeout for Jenkins tests

Can be merged as soon as errors are fixed: #1068

Out of date.


windows version? mercy

need someone with a windows machine to help! we're all on mac lol

https://github.com/smol-ai/GodMode/releases/tag/v1.0.0-beta.3 has unsigned .exe - we dont plan to sign it for now


feat(lang): Update de translation

What this PR does 📖

Updates de lang file

more due to the fact that i havent updated it in a long time


initial GitHub Release workflow

Fixes #57
Using cargo-dist turned out to be far less work and provides a lot more features...
Install with cargo install cargo-dist. This isn't required for CI, but you may want it installed to preview builds and/or modify settings. Excellent docs in the cargo-dist "book".
To create a release, simply push a tag with a version string. Here's a sample release of your latest master tagged as v0.1.0. You can also preview locally before committing to a public release, with cargo dist plan.

Original description below (branch was replaced, no longer applicable)
Runs cargo to build binaries for Linux (x86 w/glibc) and MacOS (x86 & ARM).
~Prepares a draft GitHub Release using softprops/action-gh-release, which contains an archive for each target platform, and a release description that can be edited then published with a button press. Each archive contains platform-specific binaries (doppler & parsetest), and common versions of LICENSE, README.md, and doppler_files.~
~Here's a sample release.~
~Let me know if you prefer a different arrangement of files for download, like putting the common (plaintext) files into their own archive and removing them from the platform-specific archives, or using different formats for certain archives, etc.~
While working on this, I came across cargo-dist that seems like it might be a better all-in-one solution for packaging and release generation. For an example workflow, see LNDK. If you're interested in that, let me know and I'll add it.

Glad to help! I have another WIP branch for consolidating the scripts into a single file, which should also be included in the release tarball. Assuming that one looks good to you (I'll open a PR in the next couple days) I should have this one ready for final review by end of week.


MRTK vNext has build breaks when using "warnings as errors" (-warnaserror+)

(Ported to GitHub, reference 20029618)
Production apps typically build with "warnings as errors" (the -warnaserror+ compiler option).  To enable it, add an "Assets\csc.rsp" file to MRTK and include "-warnaserror+".  Try to build MRTK vNext and you'll hit build breaks.
I fixed the build breaks I could and added TODOs to fix the remaining ones where the fix was non-obvious to me.  See the "Links" in this bug for commit info.
To prevent breaks from creeping back in, MRTK will need to keep "-warningsaserror+" in its csc.rsp file.

We need to keep our code warning and error clean, lest we break other projects that treat warnings as errors.

I think the issues that this was originally for have been resolved - we can open new issues for specific ones when we encounter them in the future. There's not really a point to keep this around as a catch-all


Get Reports in Apple Format

In iOS, we can get all crash reports which is in Library/Cache ... But that is saved in JSON format. Is there any way to get reports in Apple format or save it in Apple format. I am not using any Installation classes. I am just uploading those reports to our own server.

Worked like a charm Thanks @yvasileuski


Autohinting activation and mode with SmoothMode::kNormal and Engine::AutoFallback

When integrating Fontations autohinting to Skia, in SmoothMode::kSlight and explicit Engine::Auto, things work well, and there are close to no differences to FreeType.  :+1:
However, when configuring SmoothMode::kNormal and Engine::AutoFallback I see no difference to unhinted outlines in the output of Fontations.
This also means, of course, that I see a difference in SkFontHinting::kNormal comparison between Fontations and FreeType, as it seems autohinting fallback does not get activated in Fontations.
Comparison:
Left SkFontHinting::kNone, right SkFontHinting::kNormal, third column, comparison:
SkTypeface backed by FreeType
Vertical stems get emphasized, the antialiased RGB color values are a touch "darker" left and right of the stems.

SkTypeface backed by Fontations
No difference between SkFontHinting::kNone and SkFontHinting::kNormal,
except, strangely, in combining mark placement, such as dots on Ü or circumflex.

Work in progress Skia integration CL:
https://skia-review.googlesource.com/c/skia/+/898577

Testing on my end indicates that we appear to match FreeType's behavior here.
Specifically, if I load the 'a' glyph from the Noto Sans test font with FreeType and FT_LOAD_TARGET_NORMAL, FreeType does not select the autohinter. This is because the font contains a non-empty cvt table although it doesn't appear to have any real hinting instructions. This results in an outline that is identical to the one you get with FT_LOAD_NO_HINTING, matching the result we see for Fontations.
I'm not sure why Skia/FreeType is generating a hinted outline for SkFontHinting::kNormal in this case. I don't see anything in the Skia code that would trigger this behavior.

For my Skia testing, this is with FreeType at 83af801b5. Are you using a similar revision?
Indeed, surprisingly, the font does have a prep table:
ttx -l -o- third_party/externals/googlefonts_testdata/data/fonts/NotoSans-Regular.ttf
Listing table info for "third_party/externals/googlefonts_testdata/data/fonts/NotoSans-Regular.ttf":
    tag     checksum    length    offset
    ----  ----------  --------  --------
    GDEF  0xECE6E9E7      2208    429572
    GPOS  0x9A4703EB     79042    431780
    GSUB  0xD9440714     49266    510824
    OS/2  0x0E5586E0        96       376
    cmap  0x10D913BC      3242     19280
    gasp  0x00000010         8    429564
    glyf  0x613D7F07    327789     41344
    head  0x23E954DF        54       252
    hhea  0x0CB317D6        36       308
    hmtx  0x519880AF     18808       472
    loca  0x2BE5BA5A     18812     22532
    maxp  0x1281017F        32       344
    name  0x1838217F      1900    369136
    post  0x08F04298     58527    371036
    prep  0x68068C85         7     22524

Re:

SkTypeface backed by FreeType

With Skia's setSubpixel(false) the differences between SkFontHinting::kNone and SkFontHinting::kNormal in the FT backend vanish:

So, to summarize: The font has a prep table which disables the autohinter unless forced on. The horizontal stem differences are explainable through differing subpixel positioning in the two modes, which needs to be investigated separately.
Also @dfrg pointed out that the fontations backend does not perform subpixel path translation, as the freetype backend does before rendering, when subpixel rendering is requested. I will file that as a separate Skia issue.

No issue here for Fontations.