Error retrieving volume for disk: Storage volume not found: no storage vol with matching name 'centos7.qcow2'

System Information
[root@Terraform-vm libvirt]# lscpu
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                4
On-line CPU(s) list:   0-3
Thread(s) per core:    1
Core(s) per socket:    1
Socket(s):             4
NUMA node(s):          1
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 85
Model name:            Intel Xeon Processor (Skylake, IBRS)
Stepping:              4
CPU MHz:               1795.781
BogoMIPS:              3591.56
Hypervisor vendor:     KVM
Virtualization type:   full
L1d cache:             32K
L1i cache:             32K
L2 cache:              4096K
NUMA node0 CPU(s):     0-3
Linux distribution
Centos7
Terraform version
terraform -v
# Terraform v1.1.9

Provider and libvirt versions
terraform-provider-libvirt -version

provider registry.terraform.io/dmacvicar/libvirt v0.6.13
If that gives you "was not built correctly", get the Git commit hash from your local provider repository:
git describe --always --abbrev=40 --dirty

Checklist

[ ] Is your issue/contribution related with enabling some setting/option exposed by libvirt that the plugin does not yet support, or requires changing/extending the provider terraform schema?

[ ] Make sure you explain why this option is important to you, why it should be important to everyone. Describe your use-case with detail and provide examples where possible.
[ ] If it is a very special case, consider using the XSLT support in the provider to tweak the definition instead of opening an issue
[ ] Maintainers do not have expertise in every libvirt setting, so please, describe the feature and how it is used. Link to the appropriate documentation

[x] Is it a bug or something that does not work as expected? Please make sure you fill the version information below:
Terraform machine:
[root@Terraform-vm libvirt]# terraform -v
Terraform v1.1.9
on linux_amd64

provider registry.terraform.io/dmacvicar/libvirt v0.6.13

Destination host:
[root@h12 ~]# virsh -v
4.5.0
Description of Issue/Question
While creating a VM, weather you mention the volume or not in .tf file. we see the following error irrespective of configuration.
╷
│ Error: error retrieving volume for disk: Storage volume not found: no storage vol with matching name 'centos7.qcow2'
│
│   with libvirt_domain.centos7,
│   on vm-deploy.tf line 12, in resource "libvirt_domain" "centos7":
│   12: resource "libvirt_domain" "centos7" {
│
╵
Setup
(Please provide the full main.tf file for reproducing the issue (Be sure to remove sensitive information)
main.tf
terraform {
required_providers {
libvirt = {
source = "dmacvicar/libvirt"
version = "0.6.13"
}
}
}
provider "libvirt" {
uri = "qemu+ssh://virt@<IP_ADDRESS>/system?keyfile=/root/.ssh/id_rsa"
}
test1.tf
Defining VM Volume
#resource "libvirt_volume" "centos7-qcow2" {
name = "centos7.qcow2"
pool = "default" # List storage pools using virsh pool-list
source = "https://cloud.centos.org/centos/7/images/CentOS-7-x86_64-GenericCloud-1805.qcow2"
#source = "file:///var/lib/libvirt/images/CentOS-7-x86_64-minimal-2111.qcow2"
format = "qcow2"
#}
Define KVM domain to create
resource "libvirt_domain" "centos7" {
name   = "centos7"
memory = "2048"
vcpu   = 2
network_interface {
network_name = "default" # List networks with virsh net-list
}
disk {
volume_id = "${libvirt_volume.centos7-qcow2.id}"
}
console {
type = "pty"
target_type = "serial"
target_port = "0"
}
graphics {
type = "spice"
listen_type = "address"
autoport = true
}
}
Steps to Reproduce Issue
(Include debug logs if possible and relevant).
2022-05-05T17:47:29.952+0530 [DEBUG] provider.terraform-provider-libvirt_v0.6.13: 2022/05/05 17:47:29 [TRACE] Checking for x86_64/hvm against i686/hvm
2022-05-05T17:47:29.952+0530 [DEBUG] provider.terraform-provider-libvirt_v0.6.13: 2022/05/05 17:47:29 [TRACE] Checking for x86_64/hvm against x86_64/hvm
2022-05-05T17:47:29.952+0530 [DEBUG] provider.terraform-provider-libvirt_v0.6.13: 2022/05/05 17:47:29 [DEBUG] Found 9 machines in guest for x86_64/hvm
2022-05-05T17:47:29.955+0530 [ERROR] vertex "libvirt_domain.centos7" error: error retrieving volume for disk: Storage volume not found: no storage vol with matching name 'centos7.qcow2'
2022-05-05T17:47:29.955+0530 [TRACE] vertex "libvirt_domain.centos7": visit complete, with errors
2022-05-05T17:47:29.955+0530 [TRACE] vertex "libvirt_domain.centos7": dynamic subgraph encountered errors: error retrieving volume for disk: Storage volume not found: no storage vol with matching name 'centos7.qcow2'
2022-05-05T17:47:29.955+0530 [ERROR] vertex "libvirt_domain.centos7" error: error retrieving volume for disk: Storage volume not found: no storage vol with matching name 'centos7.qcow2'
2022-05-05T17:47:29.955+0530 [TRACE] vertex "libvirt_domain.centos7": visit complete, with errors
2022-05-05T17:47:29.955+0530 [TRACE] vertex "libvirt_domain.centos7 (expand)": dynamic subgraph encountered errors: error retrieving volume for disk: Storage volume not found: no storage vol with matching name 'centos7.qcow2'
2022-05-05T17:47:29.955+0530 [ERROR] vertex "libvirt_domain.centos7 (expand)" error: error retrieving volume for disk: Storage volume not found: no storage vol with matching name 'centos7.qcow2'
2022-05-05T17:47:29.955+0530 [TRACE] vertex "libvirt_domain.centos7 (expand)": visit complete, with errors
2022-05-05T17:47:29.955+0530 [TRACE] dag/walk: upstream of "provider["registry.terraform.io/dmacvicar/libvirt"] (close)" errored, so skipping
2022-05-05T17:47:29.956+0530 [TRACE] dag/walk: upstream of "root" errored, so skipping
2022-05-05T17:47:29.956+0530 [INFO]  backend/local: refresh calling Refresh
╷
│ Error: error retrieving volume for disk: Storage volume not found: no storage vol with matching name 'centos7.qcow2'
│
│   with libvirt_domain.centos7,
│   on vm-deploy.tf line 12, in resource "libvirt_domain" "centos7":
│   12: resource "libvirt_domain" "centos7" {
│
╵
2022-05-05T17:47:29.958+0530 [TRACE] statemgr.Filesystem: removing lock metadata file .terraform.tfstate.lock.info
2022-05-05T17:47:29.958+0530 [TRACE] statemgr.Filesystem: unlocking terraform.tfstate using fcntl flock
2022-05-05T17:47:29.959+0530 [DEBUG] provider.terraform-provider-libvirt_v0.6.13: 2022/05/05 17:47:29 [DEBUG] cleaning up connection for URI: qemu+ssh://virt@<IP_ADDRESS>/system?keyfile=/root/.ssh/id_rsa
2022-05-05T17:47:29.963+0530 [DEBUG] provider: plugin process exited: path=.terraform/providers/registry.terraform.io/dmacvicar/libvirt/0.6.13/linux_amd64/terraform-provider-libvirt_v0.6.13 pid=21511
2022-05-05T17:47:29.963+0530 [DEBUG] provider: plugin exited

Additional information:
Do you have SELinux or Apparmor/Firewall enabled? Some special configuration? Yes
Have you tried to reproduce the issue without them enabled? No

This issue is solved by removing terraform.tfstate  & terraform.tfstate.backup directory from the tf directory. Seems like somehow tfstate & backup keeps track of old config which leads to showing error without any actual configuration in tf file.
ls
main.tf  terraform.tfstate  terraform.tfstate.backup
rm terraform.tfstate
rm: remove regular file ‘terraform.tfstate’? y
rm terraform.tfstate.backup
rm: remove regular file ‘terraform.tfstate.backup’? y

Try this:
terraform plan  -target=libvirt_volume.centos7-qcow2
terraform apply -target=libvirt_volume.centos7-qcow2

Hi @gauravkhanande
looks like this issue is resolved. Could you close it? OR, if you feel like it is not, could you try latest version of Terraform and provider to see if it is fixed?


the annotation of the broadcast_power is wrong

Description
(A clear and concise description of what the bug is.)
the annotation of the broadcast_power is wrong both in the https://github.com/apache/incubator-mxnet/blob/1.6.0/src/operator/tensor/elemwise_binary_broadcast_op_extended.cc#L45 and https://mxnet.apache.org/api/python/docs/api/legacy/symbol/symbol.html?highlight=broadcast_power#mxnet.symbol.broadcast_power
To Reproduce
(If you developed your own code, please provide a short script that reproduces the error. For existing examples, please provide link.)
import mxnet as mx
from mxnet import nd
arr1=nd.array([[1,1,1],[1,1,1]])
arr2=nd.array([[0],[1]])
a = mx.sym.Variable('a')
b = mx.sym.Variable('b')
c = mx.sym.broadcast_power(a,b,name="c")
x = c.bind(ctx=mx.cpu(),args={"a": arr1,"b":arr2})
result = x.forward()
print(result)
#output:
[
[[1. 1. 1.]
[1. 1. 1.]]
<NDArray 2x3 @cpu(0)>]
Environment
python3.6
mxnet:1.1.0.post0

anybody?

+1,

maybe, broadcast_power(x, y)=x^y=[[ 1.,  1.,  1.],
[ 1.,  1.,  1.]]

Fixed here: https://github.com/apache/incubator-mxnet/pull/21087.


Add PIP support for Safari

Safari supports PIP and has some benefits over that in Chrome for macOS (ability to use over multiple fullscreen windows, etc.). This PR makes the changes required to support Safari PIP mode.
Note
In the current Safari release (13), the onDisablePIP is run twice when exiting PIP. This is a bug with Safari has been fixed in the latest Tech preview.

Nice work! 👍


Update xiaomi-aqara-motion-sensor to add background colors for lux/illuminance

After discussion in https://github.com/bspranger/Xiaomi/issues/89 - proposing blue scale background colors for lux.

Looks great!
Can I make a custom icon for it? 😄

@veeceeoh ok - you've tested it - so what the heck I'm going to push  (my first to the main branch!) -  feel free to make a custom icon if you really want to  (I'd avoid a sun because indoor and outdoor ranges are kind of different)  - maybe like 1/2 circle of rays? that could apply to both indoors and outdoors  - of course you may have better things to do on the weekend  - or you were just kidding :-)

@veeceeoh btw I just really got the joke - I'm slow sometimes - thanks!


added a function to the parser called parse_delimiter_config

it does the exact same thing as parse_csv_config
except it does allow for any possible delimiter to be used as in ##superspecialdelimiter## instead of single character delimiters that sometimes hard to find if the data is complex and unforeseeable

Thank you for your contribution, @osi1880vr! I quickly skimmed through your PR and reviewed it, please have a look.
I just wonder, since you state that the function parse_delimiter_config is similar to parse_csv_config, if there is not an easier why, e.g. to simply reuse parse_csv_config. Any thoughts on this?

Again, @osi1880vr, I'm to the point here, with no intention to be rude. :)
As @osi1880vr confirmed, and after checking myself, parse_delimiter_config is simply a slightly modified version of parse_csv_config. However, after looking at the difference I'm unsure why it is needed. In particular, the difference between the two are the change from
https://github.com/llmware-ai/llmware/blob/bfec79b2ee570f006e0a4dceb524c4d9bfe67f95/llmware/parsers.py#L3112-L3114
to
https://github.com/osi1880vr/llmware/blob/ad464a5e4e840ed7aeb49696b8ac6d56f0c6b2f7/llmware/parsers.py#L3114-L3125
However, when we look at the what the utility functions does
https://github.com/llmware-ai/llmware/blob/bfec79b2ee570f006e0a4dceb524c4d9bfe67f95/llmware/util.py#L261-L270
I'm unsure if this is really the best way to solve the issue.
@osi1880vr, may I ask you to open an Issue where you explain what you want to achieve and why it does not work with the current code base? Ideally, with a self-contained example? Thank you in advance!

You may ask anything you want ;) The issue is that simple, the original is using CSV parser which has a delimiter of a single character, there is use cases where your content is composed of any existing character and so it is simply impossible to have a delimiter of a single character. to solve this I added that function which does exactly this it allows for any string of any length to be your delimiter, a thing the original csv parser does not handle as it forces you to a single character. To reuse parts or the original code makes sense, but since I do not have the pig picture I did it as a copy and so I have no chance of breaking any existing implementation. And for sure I will not take care of reformatting the original code, so everything about my few lines I will have a look, the rest I just don't care :D

@osi1880vr thank you for the additional details.

To reuse parts or the original code makes sense, but since I do not have the pig picture I did it as a copy and so I have no chance of breaking any existing implementation. And for sure I will not take care of reformatting the original code, so everything about my few lines I will have a look, the rest I just don't care :D
That is totally fair, it is an open source project after all. However, that is why I suggested that you open an Issue where you request that feature. And in doing so, please add at least one example (better, more) of a CSV that you expect the library to process.

Look, what I do now is just take back my PR. its not my first one here and for sure a less complex as what I did before. But I will not contribute to a system that comes up with this style of process.


[RayCluster][Fix] evicted head-pod can be recreated or restarted

Why are these changes needed?
This PR attempts to fix issues https://github.com/ray-project/kuberay/issues/2125
if head pod has been evicted, we will delete it and let it restart or recreate
Related issue number
https://github.com/ray-project/kuberay/issues/2125
Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[x] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

Hey @JasonChen86899, I didn't know that you wanted to work on the issue. I have already assigned the issue to @MortalHappiness. Maybe we can find other issues to collaborate on if you are interested in contributing to KubeRay? Sorry for the inconvenience.

@MortalHappiness Thanks!

Hey @JasonChen86899, I didn't know that you wanted to work on the issue. I have already assigned the issue to @MortalHappiness before you open this PR. Maybe we can find other issues to collaborate on if you are interested in contributing to KubeRay? Sorry for the inconvenience.

@kevin85421  Sorry, I just made a draft and didn't notice that it was assigned, I have closed it. cc @MortalHappiness

Is this PR ready for review? It is still marked as a draft.

Is this PR ready for review? It is still marked as a draft.

marked ready for review

Based on this logic, I update the logic of the shoulDelete function
https://github.com/kubernetes/kubernetes/blob/46aa8959a0659e22c924bb52b38385d441715b2b/pkg/kubelet/kubelet_pods.go#L1556

Terminated state (end or successful), delete it
Running state,If the restart policy is Never, delete it
The rest are not deleted
@kevin85421 @andrewsykim

I will revisit this PR this week. I hope to include this PR in v1.2.0. I will cut the branch next week.

cc @MortalHappiness would you mind reviewing this PR?


Hi i sent 999.80 verge from bittrex to my verge wallet on 02/05/2018. But the coin did not come to my wallet now it is on blockchain. I tried all of troubleshooting method from verge website. then i deleted all verge related application from my computer and again installed newly.then encrypted new wallet and imported privet key and it was successful. But wallet does not show those coin. could you help me to get those coin please. i am using windows core wallet. Below my address and transid Address: DN4QG3aqVNo7oX5sVju4kxeLtmXp133yb9 TxId: f578fdd2f39f1414a9f391f8fae885fc605304db23e4428c71d96e71df75c35e

Issue Template
Context

Prerequisites

[ ] Are you running the latest version?

User Story:

"I'm submitting a ... "

[ ] bug report
[ ] feature request
[ ] support request
[ ] translation request

Expected Behavior

Current Behavior

Screenshots

Possible Solution

Steps to Reproduce (for bugs)

Steps :

Your Environment

Verge Release:
CPU:
GPU:
RAM:
OS:

[ ] I'm using Mac
[ ] I'm using Linux
[ ] I'm using Mac

Any extra information that might be useful in the debugging process.

try doing a reindex

how

go to help -> debug window ... take a screenshot of the information tab and post that.
Most likely you aren't sync'd fully
Your transaction occurred on block 1,857,449 , so your client needs to be sync'd to at least that block.

Try going to (Help –> Debug –> Console) and type scanforalltxns

On Feb 12, 2018, at 4:31 PM, vergecalling<EMAIL_ADDRESS>wrote:
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

i typed nothing happened

:+1:


Font Awesome removed

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@fabiomaistro do not try to have a look at the files, I just removed font awesome files (1500 total) to make the PR 15 alive again.


Action buttons' types

Attribution of action buttons type = "button" should be added. Thus, they will not try to submit the external form.

Added type="buttons" all buttons commit


Botania Lense bore causing area crash

Using Botania Lense bores to cut oak trees grown on garden soil resulted in my base area not loading and the resulting crash.
http://pastebin.com/HgHecyPq
The issue I think is that the tree grew as oak posts not oak wood and the bottom block of the tree (which was cut) had to be replaced with a block using world edit before the area was loadable.
GardenStuff-1.7.10-1.5.6.jar
Botania r1.6-173.jar

Fixed in dev.  Should no longer be a problem when the next version is released.


Parse with the lexical crate instead of atoi

The atoi crate can't handle negative numbers (see this comment in the documentation), so attempting to use from_value or from_value_opt on negative numbers results in this:
> mysql::from_value_opt::<i16>(b"-2"[..].into())
Err(FromValueError(Bytes("-2")))

This PR removes the atoi crate and replaces it with lexical, which correctly handles this case. It also handles parsing f32 and f64 from byte slices, so that has been introduced as well.
This passes all test cases locally, but I wasn't able to patch the project I'm using since the mysql crate on crates.io isn't compatible with the changes introduced by 4239fc3dea2acd302bb55d89893426a6d657e73f. Some live testing with a server is probably warranted since I touched a few places where atoi was being used in packet parsing.

Thanks!
I'll release this asap.


Rancher-logging is not deployed correctly on new cluster creation

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Provision a new cluster with the Rancher2 Terraform provider, with logging enabled. It appears that if there is any significant delay to the cluster API becoming available the rancher-logging app fails to install (my testing in a lab with a simple Digital Ocean cluster works, but user environment where the cluster takes longer to spin-up does not).
Result:
rancher-logging App fails with an error such as the following, indicating the API server was not available to process the request:
AppController p-hvpjn/rancher-logging [helm-controller] failed with : failed to install app rancher-logging. Error: release rancher-logging failed: the server is currently unable to handle the request (post secrets)

Other details that may be helpful:
As a workaround the customer must take action to upgrade/force redeployment of the app after cluster provisioning.
A similar issue raised in https://github.com/rancher/rancher/issues/27250 and https://github.com/rancher/rancher/issues/26440 appears to have resolved this issue for the cluster-monitoring app, but my reading of the code suggests no such force redeploy occurs automatically for the rancher-logging apps.
Environment information

Rancher v2.4.4

Reproduced in Rancher v2.4.4
The issue here is when provisioning a new cluster and also enabling cluster logging at the same time, we get into this state from the Rancher server:
Cluster is in provisioning state.
Logging was enabled but there's no cluster to deploy the App to.

Eventually failing
2020/06/26 16:26:09 [ERROR] AppController p-fwd4k/rancher-logging [helm-controller] failed with : failed to install app rancher-logging. Error: release rancher-logging failed: the server is currently unable to handle the request (post secrets)

This is also reproducible in Rancher v2.3.8


chore: release v0.3.6

:robot: I have created a release beep boop
0.3.6 (2024-04-07)
What's Changed

fix(ci): only cache the gdbuild binary directory by @coffeebeats in https://github.com/coffeebeats/gdbuild/pull/100
fix(exec): quote arguments passed to shell by @coffeebeats in https://github.com/coffeebeats/gdbuild/pull/102

Full Changelog: https://github.com/coffeebeats/gdbuild/compare/v0.3.5...v0.3.6

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/coffeebeats/gdbuild/releases/tag/v0.3.6 :sunflower:


AzureActivity still cannot connected to Sentinel

Describe the bug
I follow this tutorial https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Training/Azure-Sentinel-Training-Lab/Modules/Module-2-Data-Connectors.md#exercise-1-enable-the-azure-activity-connector or i follow the official tutorial below :
Launch the Azure Policy Assignment wizard and follow the steps.
    In the Basics tab, click the button with the three dots under Scope to select your resources assignment scope.
    In the Parameters tab, choose your Microsoft Sentinel workspace from the Log Analytics workspace drop-down list, and leave marked as "True" all the log and metric types you want to ingest.
    To apply the policy on your existing resources, select the Remediation tab and mark the Create a remediation task checkbox.

but it's still cannot connected to Sentinel.
To Reproduce
Steps to reproduce the behavior:

Go to 'microsoft sentinel'
Click on 'connector'
Scroll down to 'azure activity'
go to the tutorial : https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Training/Azure-Sentinel-Training-Lab/Modules/Module-2-Data-Connectors.md#exercise-1-enable-the-azure-activity-connector
Follow the tutorial
See error

Expected behavior
Connected AzureActivity Connector
Screenshots

Desktop (please complete the following information):

Browser Chrome

Hi @jeffrywu28, Thanks for flagging this issue, we will investigate this issue and get back to you with some updates by 07-02-2024. Thanks!

Hi @v-sudkharat, can i get the info faster? i need it monday

Hi @jeffrywu28, Sure, could you please share the screenshot of what error you get while connecting the connector. In above your shared screenshot the error message not visible. Thanks!

Hi @jeffrywu28 ,Can we connect over teams to understand the error with more details, Could you please share over an email your convenient time, to<EMAIL_ADDRESS>

Hi @jeffrywu28 ,Gentle reminder, Can we connect over teams meeting to understand the error with more details, Could you please share over an email your convenient time, to<EMAIL_ADDRESS>

Hi @jeffrywu28 .Since we have not received a response in the last 5 days, we are closing your issue (https://github.com/Azure/Azure-Sentinel/issues/9881) as per our standard operating procedures. If you still need support for this issue, feel free to re-open at any time. Thank you for your co-operation!


BUG: scatter_matrix draws incorrect axis

Closes #5662. Refactored a little.
Made examples to confirm 1st and 2nd row's yaxis are identical.
import pandas as pd
import numpy as np
df = pd.DataFrame(np.random.randn(100, 3))
df[0] = df[1]
pd.tools.plotting.scatter_matrix(df)

df[1] = df[1] / 3 - 2
df[0] = df[1]
pd.tools.plotting.scatter_matrix(df)

@sinhrks is there actually anything that prevents this from being merged?
cc @TomAugspurger

No, I think this is ready for review. Because it is categorized as a bug fix, is it possible to include it in 0.16.1 (not next major release)?
I'll rebase to in this later to fix the release note.

Thanks. Ping me when the rebase is done and I'll get it merged.

On Mar 30, 2015, at 22:18, Sinhrks<EMAIL_ADDRESS>wrote:
No, I think this is ready for review. Because it is categorized as a bug fix, is it possible to include it in 0.16.1 (not next major release)?
I'll rebase to in this later to fix the release note.
—
Reply to this email directly or view it on GitHub.

@TomAugspurger Rebased, and now green.

OK, thanks!


[Excel] (Custom functions) Update tutorial to reflect platform availbility

Fixes #3314. Tested and confirmed customer suggestion.

Docs Build status updates of commit 7c50faf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit e20dda1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/quickstarts/excel-custom-functions-quickstart.md
:white_check_mark:Succeeded
View

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit a57f899:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/quickstarts/excel-custom-functions-quickstart.md
:white_check_mark:Succeeded
View

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 09fb54a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/quickstarts/excel-custom-functions-quickstart.md
:white_check_mark:Succeeded
View

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Rename economy_cog.py to economy.py

Description

Renamed economy.py in cogs and respective changes made in main.py
Related Issue:
#199
closes # (issue)
Type of change

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have read the contributing guidelines
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (if applicable)
[ ] My changes generate no new warnings

https://github.com/Vyvy-vi/TearDrops/blob/5a11525abbad37de9dda9f31fc54a4c4682b5656/bot/main.py#L30-L43
- 'cogs.economy_cog'
+ 'cogs.economy'

Thanks for opening this PR-!
Could you also make changes here?


Apply spotless automatically

This adds executions during process-sources and process-test-sources to ensure that modified files are formatted properly.

@jvz,
Wouldn't process-test-sources be enough? The idea is great: if you run tests on a PR, the code will be automatically formatted. However we have also to disable this in the CI, since it renders the spotless:check run useless.

 And I wasn't sure about the phase; I thought both would be required, but I suppose it depends on the particular plugin (I'm used to configuring the compiler and surefire plugins so much that I get explicit on the phases to attach to).


Feature Request: Offline Support for CRD Completions

Right now, autocompletion for CRDs is based on the cluster one is currently connected to. If a CRD is not available on that cluster, there won't be any autocompletion and no tooltips.
I'm working in a platform team, and we manage dozens of clusters. Since we're doing GitOps we edit lots of manifests in VS Code and then push them to git in order for them to get applied.
When I'm not connected to a cluster, or connected to a cluster that doesn't have a specific CRD installed (we're using cluster-api for example, which is only available on management clusters) I do not get completions and tooltips.
Proposal
If CRDs were cached/stored offline, completion and tooltips could be provided at any time. It could also reduce the time between opening a yaml file and getting assistance.
Since CR(D)s are versioned, it should be possible to just store the CRDs indefinitely, automatically refreshing or sending a notification if the version used in the file is not available. There also shouldn't be any conflicts as CRDs usally have a unique name/namespace identifier.
The following behaviour and features would be very convenient for our use-case:

When the extension notices a CRD that it doesn't have in its cache, it will query the connected API server and check if that CRD is available. If it is, it downloads and stores it.
When it does have the CRD in its cache, but not the correct version, it also contacts the API server to update the CRD. If the API server doesn't have a matching version, a banner could be shown.
It should be possible to import CRDs form a URL, e.g. when no API server with the necessary CRDs can be accessed.
There should be a context menu option that allows to refresh a CRD from the server (maybe also from the code lens at the top of the file). This is useful for CRD development, where fields might change without the version changing as well.
An action to download and store all CRDs from a server would also be useful.

It looks to me a good idea. +1
Thoughts about this? @itowlson @squillace


Error when using spacy _trf models

Hi,
thanks for the updates on the classifier. I have been using your classifier based on en_core_web_lg and wanted to try out en_core_web_trf to see performance improvements.
import spacy
import os
import classy_classification  # noqa: F401
from collections import OrderedDict
from operator import itemgetter
from data_en import training_data
nlp = spacy.load("en_core_web_trf")
print("english pretrained model has been loaded")
nlp.add_pipe("text_categorizer", config={"data": training_data,"model": "spacy"})
When I do this, I get the following console output:
english pretrained model has been loaded
Traceback (most recent call last):
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/spyder_kernels/py3compat.py:356 in compat_exec
exec(code, globals, locals)
File ~/Documents/Python Scripts/doc genres/examples/classifiertest.py:22
nlp.add_pipe("text_categorizer", config={"data": training_data,"model": "spacy"})
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/spacy/language.py:795 in add_pipe
pipe_component = self.create_pipe(
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/spacy/language.py:674 in create_pipe
resolved = registry.resolve(cfg, validate=validate)
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/thinc/config.py:746 in resolve
resolved, _ = cls._make(
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/thinc/config.py:795 in _make
filled, _, resolved = cls._fill(
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/thinc/config.py:867 in _fill
getter_result = getter(*args, **kwargs)
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/classy_classification/init.py:53 in make_text_categorizer
return ClassySpacyInternalFewShot(
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/classy_classification/classifiers/classy_spacy.py:110 in init
ClassySkeletonFewShot.init(self, *args, **kwargs)
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/classy_classification/classifiers/classy_skeleton.py:65 in init
self.set_training_data()
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/classy_classification/classifiers/classy_skeleton.py:236 in set_training_data
self.X = self.get_embeddings(X)
File ~/anaconda3/envs/spyder-env/lib/python3.9/site-packages/classy_classification/classifiers/classy_spacy.py:101 in get_embeddings
embeddings.append(doc._.trf_data.model_output.pooler_output[0])
AttributeError: 'ModelOutput' object has no attribute 'pooler_output'
Thanks in advance for your help
Kristian

Hi @kbillesk, I cannot seem to reproduce this. What package versions are you using? Can you provide me with a pip list?

Hi @davidberenstein1957 thanks for looking into this. Here is my pip list (conda/pip)
piplist.csv
Thanks for investigating

hi @kbillesk Could you try instaling the latest version of classy-classificaiton?

I just did, and the error is still there. I just tried running your basic example with furniture and kitchen and it works as it should. I may suspect it could be an issue related to the training data. I am showing you the training data that I am using, that is stored in a file called data_en.py
training_data = {     "EN_sicknotice": [         "I have catched a cold and will be home today.",         "Katja is sick and will be staying home for the rest of the week.",         "1. day sick 11-09-2018",         "So I will not come in the office tomorrow",         "I am sick with a fever and I don't expect to be ready for tomorrow.",         "Pia is sick with Corona and will come back friday at the earliest.",         "I have a sick noy home today with smallpocks so I will not be very responsive on my e-mail.",     ],     "EN_resignation": [         "I wish to resign by 11-09.",         "I resign my job",         "I quit.",         "wish to hand in my notice of resignation",         "I resign today and will stop workiing on 31. marts this year.",         "In accordance with my employment contract, I am resgigning by 31/10",         "I do not want to be part of this company anymore. I quit!",     ],     "EN_cv": [         "CURRICULUM VITAE",         "Native language : Afrikaans (Fluent) OTHER LANGUAGE : English (Fluent)",         "EMPLOYMENT HISTORY",         "Duties include:",         "REFERENCES Available upon request ",         "Enrolled in Master studies at ",         "WORK EXPERIENCE 11/2016-current",     ],     "EN_employmentcontract": [         "Place of work: ",         "Normal working hours",         "Remuneration ",         "Compensation package ",         "non-disclosure ",         "Probationary period ",         "Conditions of termination ",            ],     "EN_verdict": [         "defendant is found guilty",         "judgement given on",         "Case No: ",         "Approved Judgment",         "the prosecution case",         "The appellant’s case",         "The judge’s sentencing remarks",         "The critical findings of fact were that:",         "Conclusion",     ],     "EN_certficate_of_residence": [         "Certificate of Residency",         "To whom it may concern",         "Residence Documentation",         "Date of Issue",         "Certifying Permanent Residence",         "Place and date of issue",         "",     ],     "EN_HR_information": [         "salary",         "annual income",         "annual bonus",         "remuneration",         "contract of employment",         ], }

That is correct. You are passing an empty value (""), which does not have pooler output. I should skip the values in my code. I will leave this issue open or you can create a PR if you are up to it. Thanks for following up at least. Underneath is a working version.
training_data = { "EN_sicknotice": [ "I have catched a cold and will be home today.", "Katja is sick and will be staying home for the rest of the week.", "1. day sick 11-09-2018", "So I will not come in the office tomorrow", "I am sick with a fever and I don't expect to be ready for tomorrow.", "Pia is sick with Corona and will come back friday at the earliest.", "I have a sick noy home today with smallpocks so I will not be very responsive on my e-mail.", ], "EN_resignation": [ "I wish to resign by 11-09.", "I resign my job", "I quit.", "wish to hand in my notice of resignation", "I resign today and will stop workiing on 31. marts this year.", "In accordance with my employment contract, I am resgigning by 31/10", "I do not want to be part of this company anymore. I quit!", ], "EN_cv": [ "CURRICULUM VITAE", "Native language : Afrikaans (Fluent) OTHER LANGUAGE : English (Fluent)", "EMPLOYMENT HISTORY", "Duties include:", "REFERENCES Available upon request ", "Enrolled in Master studies at ", "WORK EXPERIENCE 11/2016-current", ], "EN_employmentcontract": [ "Place of work: ", "Normal working hours", "Remuneration ", "Compensation package ", "non-disclosure ", "Probationary period ", "Conditions of termination ", ], "EN_verdict": [ "defendant is found guilty", "judgement given on", "Case No: ", "Approved Judgment", "the prosecution case", "The appellant’s case", "The judge’s sentencing remarks", "The critical findings of fact were that:", "Conclusion", ], "EN_certficate_of_residence": [ "Certificate of Residency", "To whom it may concern", "Residence Documentation", "Date of Issue", "Certifying Permanent Residence", "Place and date of issue"], "EN_HR_information": [ "salary", "annual income", "annual bonus", "remuneration", "contract of employment", ], }

Thanks for the support


Changing code signing identity to iPhone Developer

This pull request addresses issue https://github.com/nickoneill/PermissionScope/issues/140

Thanks @blender! I'll bring this in soon.


FW review RTL loiter behaviour

From https://discuss.px4.io/t/plane-flyaway-recovery-rtl-loiter-then-flew-away/10991.
https://logs.px4.io/plot_app?log=a204d10b-a40d-4c05-9bb6-6f2c23bf574c

I found that putting a FIXED WING LANDING PATTERN in the mission FROM the preset “pattern” icon/button, then setting the RTL mode to head for the landing 1st (NOT head directly to home), causes the plane to go to that loiter-to-land pattern and subsequently line up to the runway and land correctly. That preset FW landing pattern is very nice - much nicer than basic waypoint and land. thx to the coder!
.
However, even with this fw landing pattern in place and working as such, if i tried to use the RTL mode that just flies directly to home, with the RTL conditions set to loiter for (time) 45sec then land, the plane would loiter for 45secs, then proceed to fly away in the direction of its choice. BUG!
.

TODO: review FW RTL behavior, and consider requiring a planned landing by default if RTL can land at all.

Before I added the "planned landing" (from the "pattern" icon/menu), I had a "land" waypoint with a preceding waypoint that would line the plane up for the runway. This worked sufficiently to land the plane in a mission, but would not work with the RTL cmd.

@dagar , did 413acc5 fix this?


[ZEPPELIN-5259] Use RemoteInterpreterManagedProcess for K8sRemoteInterpreterProcess

What is this PR for?
This PR changes the parent class for K8sRemoteInterpreterProcess to RemoteInterpreterManagedProcess.
It also contains some bug fixes.
I removed the static method RemoteInterpreterUtils.checkIfRemoteEndpointAccessible, because this function is unnecessary and it also blocks testing. It is sufficient to listen for processStarted. This signals a successful start of the interpreter.
What type of PR is it?
Improvement and Bugfixing
What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5259

How should this be tested?

CI
Port forwarding was tested locally

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

I will include this PR in master and branch-0.9 on Friday (27/02/2021) if no further comments are received.


Lab 9 - Data for Northeast region did not display

Module: 9
Lab/Demo: Create a dynamic role
Task: Validate the dynamic role
Step: 5
Description of issue:
Data for Northeast region did not display.
Repro steps:

Anthony I had the same issue originally but forgot to check mark that the role should be used as well as the name Michael.  Its may not mention it in the text but the picture shows it.

Thanks Anthony, and thanks Mark for responding to the issue. @AnthonyOakley - do you have both the "Other user" and the "Salespeople" roles selected? Please let me know if you have both selected and are still facing this issue.


Create auto-approve.yml - Merges dependabot PRs automatically

Merges dependabot PRs automatically.
Description
As a precursor to automated testing, I'd like Dependabot pull requests to be merged automatically.
Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ x ] Other (please describe) Automation

Checklist

[x ] I have read the contributing guidelines
[x ] Existing issues have been referenced (where applicable)
[x ] I have verified this change is not present in other open pull requests
[x ] Functionality is documented
[x ] All code style checks pass
[ ] New code contribution is covered by automated tests
[ ] All new and existing tests pass

Permissions for Actions on this repo (in this org) won't match this workflow. Closing PR.


array column types don't work in Kysely

is this an known issue? e.g. varchar(128)[] doesn't seem to work in Kysely.
await db
  .schema
  .createTable('example')
  //                     vvv type error here
  .addColumn('example', 'varchar(128)[]').execute()

sql`varchar(128)[]`

@koskimas thanks for the fast response, is that an escape hatch from the type system? or are there docs on what you've shared?

@koskimas would still like an answer here when you have a sec.

If you can't find docs for this, probably a good idea to submit a PR. 💡


Display of promo label

Type

✨ Feature

Objectives: Revisit how we display Promo Label to minimise redundancy and to assist user find relevant article by making it easy to scan. The team decided to explore following display logic.

Suppress 'Article' label on all promo
Use the promo label to highlight special feature/series (Electric Sublime, Body Squabbles, etc.)
Hide the promo label when all articles belong to same feature/series (Series Index page, Feature/Series block, etc.)
Change the display order: 1 Article Title, 2 Promo Label, 3 Author Name (optional)
Continue to use the icon overlay for article type (Audio, Video, Comic, Image Gallery Article, etc.)

Next Steps

[x] Tomi to mock up Explore landing with new promo label display logic including author name

Content team to consider creating a block to highlight key authors similar to Series block in Explore landing

Development effort to be on hold till we revisit the template after Image Search project.

After reviewing with Heesoo and Jenn, we have 2 options. One to take action on and second to leave for future consideration/discussions.
Action:

[ ] Suppress 'Article' label on all promo
[ ] Use the promo label to highlight special feature/series (Electric Sublime, Body Squabbles, etc.)
[ ] Hide the promo label when all articles belong to same feature/series (Series Index page, Feature/Series block, etc.)
[ ] Change the display order: 1 Article Title, 2 Promo Label
[ ] Continue to use the icon overlay for article type (Audio, Video, Comic, Image Gallery Article, etc.)

Below is an imagine which shows how this would look like on the Explore page today (2017-06-15)
WC_Labels_170615.png.zip
For future consideration:
Considering including author names within the promos. Initial implementation of this makes the promos and page very busy.
Questions:
Do we include icon to create visual hierarchy?
What is the icon?
Initial explorations on this:
No icon:

Person icon:

Various icons:


Zookeeper node replica host value did not change after changing the config.xml replica host value

Problem
I'm trying to solve the known DNS problem when running Clickhouse replicas as containers (Kubernetes). My solution is to use a ClusterIP service for each of my replicas so that the IP address will be static. This ClusterIP services will replace the current Kubernetes Headless Service that I use.
The DNS issue
The IP address shown in the logs is the old IP address of a Clickhouse Pod/Container replica and SYSTEM DROP DNS CACHE does not fix it.

So this is what I changed:

Old Headless service hostname
New ClusterIP service hostname

clickhouse-01-0.clickhouses.default.svc.cluster.local
ch-01-0.default.svc.cluster.local

clickhouse-01-1.clickhouses.default.svc.cluster.local
ch-01-1.default.svc.cluster.local

I validated that the change took effect by running this query:
select cluster, shard_num, replica_num, host_name, host_address from system.clusters where cluster='my_cluster' FORMAT Vertical

Row 1:
──────
cluster:      my_cluster
shard_num:    1
replica_num:  1
host_name:    ch-01-0.default.svc.cluster.local
host_address: <IP_ADDRESS>

Row 2:
──────
cluster:      my_cluster
shard_num:    1
replica_num:  2
host_name:    ch-01-1.default.svc.cluster.local
host_address: <IP_ADDRESS>

What I did
I have updated the config.xml to use a different hostname and then restarted my deployments (Kubernetes Pods).
    <yandex>
        <remote_servers incl="clickhouse_remote_servers">
          <clicks_cluster>
            <shard>
              <internal_replication>true</internal_replication>
              <replica>
                  <default_database>default</default_database>
                  <host>ch-01-0.default.svc.cluster.local</host>
                  <port>9000</port>
              </replica>
              <replica>
                  <default_database>default</default_database>
                  <host>ch-01-1.default.svc.cluster.local</host>
                  <port>9000</port>
              </replica>
            </shard>
            <shard>
              <internal_replication>true</internal_replication>
              <replica>
                  <default_database>default</default_database>
                  <host>ch-02-0.default.svc.cluster.local</host>
                  <port>9000</port>
              </replica>
              <replica>
                  <default_database>default</default_database>
                  <host>ch-02-1.default.svc.cluster.local</host>
                  <port>9000</port>
              </replica>
            </shard>
          </clicks_cluster>
        </remote_servers>
    </yandex>

Everything works fine but eventually, a Pod will again produce that known DNS error.
In zookeeper, I still see that the replica host did not change:
[zk: localhost:2181(CONNECTED) 16] get /clickhouse/tables/01/default/my_table/replicas/clickhouse-01-0/host
host: clickhouse-01-0.clickhouses.default.svc.cluster.local
port: 9009
tcp_port: 9000
database: default
table: my_table
scheme: http

cZxid = 0x100000010
ctime = Fri Apr 12 11:51:30 UTC 2019
mZxid = 0x500000028
mtime = Wed Apr 24 14:58:36 UTC 2019
pZxid = 0x100000010

Is it dangerous if I updated the value manually?
clickhouse-01-0.clickhouses.default.svc.cluster.local was already replaced with ch-01-0.default.svc.cluster.local from the config.xml.
The known DNS problem is this:
2019.04.24 15:09:25.173016 [ 12 ] {} <Error> default.clicks_sharded (StorageReplicatedMergeTree): DB::StorageReplicatedMergeTree::queueTask()::<lambda(DB::StorageReplicatedMergeTree::LogEntryPtr&)>: Poco::Exception. Code: 1000, e.code() = 113, e.displayText() = Net Exception: No route to host

My temporary solution to make the replication work is to kill the Pod that throws this error.
Update
When using a replica clickhouse-client, I see that it's still using the headless service name clickhouse-01-1.clickhouses.default.svc.cluster.local.
kubectl exec -it clickhouse-01-1 -- clickhouse-client

ClickHouse client version <IP_ADDRESS>.
Connecting to localhost:9000 as user default.
Connected to ClickHouse server version 19.4.1 revision 54416.

clickhouse-01-1.clickhouses.default.svc.cluster.local :)

This is my Kubernetes services.
NAME            TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)                      AGE
ch-01-0         ClusterIP   <IP_ADDRESS>     <none>        9000/TCP,8123/TCP,9009/TCP   178m
ch-01-1         ClusterIP   <IP_ADDRESS>   <none>        9000/TCP,8123/TCP,9009/TCP   177m
ch-02-0         ClusterIP   <IP_ADDRESS>   <none>        9000/TCP,8123/TCP,9009/TCP   3h3m
ch-02-1         ClusterIP   <IP_ADDRESS>   <none>        9000/TCP,8123/TCP,9009/TCP   3h3m
clickhouses     ClusterIP   None            <none>        9000/TCP,8123/TCP,9009/TCP   12d

I tried deleting the headless service and the following error came up:
<Error> default.clicks_sharded (StorageReplicatedMergeTree): DB::StorageReplicatedMergeTree::queueTask()::<lambda(DB::StorageReplicatedMergeTree::LogEntryPtr&)>: Poco::Exception. Code: 1000, e.code() = 0, e.displayText() = Host not found: clickhouse-01-0.clickhouses.default.svc.cluster.local

Update 2
I also noticed that this error came up after I changed the config.xml.
Couldn't start replication: Replica /clickhouse/tables/01/default/my_table/replicas/clickhouse-01-0 appears to be already active. If you're sure it's not, try again in a minute or remove znode /clickhouse/tables/01/default/my_table/replicas/clickhouse-01-0/is_active manually, DB::Exception: Replica /clickhouse/tables/01/default/my_table/replicas/clickhouse-01-0 appears to be already active. If you're sure it's not, try again in a minute or remove znode /clickhouse/tables/01/default/my_table/replicas/clickhouse-01-0/is_active

interserver_http_host -> host_name:    ch-01-1.default.svc.cluster.local

    <!-- Hostname that is used by other replicas to request this server.
         If not specified, than it is determined analoguous to 'hostname -f' command.
         This setting could be used to switch replication to another network interface.
      -->
    <!--
    <interserver_http_host>example.yandex.ru</interserver_http_host>
    -->

@den-crane thanks for the answer. I ran the command and I got the following.
# hostname -f
clickhouse-01-1.clickhouses.default.svc.cluster.local

So you probably better to specify interserver_http_host in config.xml though I am not sure it will work without CH restart than guessing what hostname -f is applied in CH unix process.

I'm now changing my Clickhouse Docker entrypoint script to make the interserver_http_host dynamically configurable upon the Pod runtime. I will update this thread for the result.

@den-crane it worked! 🎉
For each Kubernetes Pod replica, the docker_related_config.xml now looks like:
<yandex>
	<!-- Listen wildcard address to allow accepting connections from other containers and host network. -->
	<listen_host>::</listen_host>
	<listen_host><IP_ADDRESS></listen_host>
	<listen_try>1</listen_try>
	<!-- Related to https://github.com/yandex/ClickHouse/issues/2228 -->
	<listen_reuse_port>1</listen_reuse_port>

	<logger>
		<level>error</level>
		<console>1</console>
	</logger>
	<!-- Related to https://github.com/yandex/ClickHouse/issues/4047 -->
	<keep_alive_timeout>8</keep_alive_timeout>

	<!-- Related to https://github.com/yandex/ClickHouse/issues/5101 -->
	<interserver_http_host>ch-01-0.default.svc.cluster.local</interserver_http_host>
</yandex>

I checked zookeeper and it's now using the interserver_http_host.
[zk: localhost:2181(CONNECTED) 4] get /clickhouse/tables/01/default/my_table/replicas/clickhouse-01-0/host
host: ch-01-0.default.svc.cluster.local
port: 9009
tcp_port: 9000
database: default
table: clicks_sharded
scheme: http

I've also now removed the Kubernetes headless service.
I'm closing this issue now. Thanks for the support! 🍻


P2P unable to publish payload in batch

Tessera release 22.1.1 https://github.com/ConsenSys/tessera/releases/tag/tessera-22.1.1
I config P2P mode bellow:
{
  "app": "P2P",
  "enabled": true,
  "serverAddress": "http://ip_public:9003",
  "bindingAddress": "http://ip_public:9003",
  "sslConfig": {
    "tls": "OFF"
  },
  "communicationType": "REST",
  "properties": {
    "partyInfoInterval": "Long",
    "enclaveKeySyncInterval": "Long",
    "syncInterval": "Long",
    "resendWaitTime": "Long"
  }
}

When I deploy new contract with PrivateFor 2 nodes (PrivateFrom & another node) it cannot publish payload to node 2.
Jul 21 18:49:49 REMOVED tessera[107628]: {"timestamp":"2022-07-21 18:49:49,964","container":"REMOVED","level":"INFO","thread":"pool-1-thread-1","logger":"c.q.t.q.i.RestPayloadPublisher","message":"Publishing message to http://IP2:9003/","throwable":""}
Jul 21 18:49:51 REMOVED tessera[107628]: {"timestamp":"2022-07-21 18:49:51,554","container":"REMOVED","level":"INFO","thread":"pool-4-thread-1","logger":"c.q.t.p.p.PartyInfoBroadcaster","message":"Started PartyInfo polling round","throwable":""}
Jul 21 18:49:51 REMOVED tessera[107628]: {"timestamp":"2022-07-21 18:49:51,557","container":"REMOVED","level":"INFO","thread":"pool-4-thread-1","logger":"c.q.t.p.p.PartyInfoBroadcaster","message":"Finished PartyInfo polling round","throwable":""}
Jul 21 18:49:53 REMOVED tessera[107628]: {"timestamp":"2022-07-21 18:49:53,722","container":"REMOVED","level":"INFO","thread":"pool-1-thread-1","logger":"c.q.t.q.i.AsyncBatchPayloadPublisher","message":"unable to publish payload in batch: Connection error while communicating with http://IP2:9003/","throwable":""}
Jul 21 18:49:53 REMOVED tessera[107628]: {"timestamp":"2022-07-21 18:49:53,722","container":"REMOVED","level":"WARN","thread":"qtp1264231563-39","logger":"c.q.t.data.EntityManagerTemplate","message":"JPA exception thrown during execution Connection error while communicating with http://IP2:9003/","throwable":""}
Jul 21 18:49:53 REMOVED tessera[107628]: {"timestamp":"2022-07-21 18:49:53,725","container":"REMOVED","level":"WARN","thread":"qtp1264231563-39","logger":"c.q.t.a.e.NodeOfflineExceptionMapper","message":"http://IP2:9003/ is unavailable assuming disconnection","throwable":""}
Jul 21 18:49:53 REMOVED tessera[107628]: {"timestamp":"2022-07-21 18:49:53,726","container":"REMOVED","level":"INFO","thread":"qtp1264231563-39","logger":"c.q.tessera.q2t.TransactionResource4","message":"Exit Request : POST : /sendsignedtx","throwable":""}
Jul 21 18:49:53 REMOVED tessera[107628]: {"timestamp":"2022-07-21 18:49:53,726","container":"REMOVED","level":"INFO","thread":"qtp1264231563-39","logger":"c.q.tessera.q2t.TransactionResource4","message":"Response for sendsignedtx : 410 Connection error while communicating with http://IP2:9003/","throwable":""}
Jul 21 18:49:56 REMOVED tessera[107628]: {"timestamp":"2022-07-21 18:49:56,557","container":"REMOVED","level":"INFO","thread":"pool-4-thread-1","logger":"c.q.t.p.p.PartyInfoBroadcaster","message":"Started PartyInfo polling round","throwable":""}
Jul 21 18:49:56 REMOVED tessera[107628]: {"timestamp":"2022-07-21 18:49:56,560","container":"REMOVED","level":"INFO","thread":"pool-4-thread-1","logger":"c.q.t.p.p.PartyInfoBroadcaster","message":"Finished PartyInfo polling round","throwable":""}

curl http://IP2:9003/partyinfo
{
  "url": "http://IP1:9003/",
  "peers": [
    {
      "url": "http://IP1:9003/"
    },
    {
      "url": "http://IP2:9003/"
    }
  ],
  "keys": [
    {
      "key": "key1",
      "url": "http://IP1:9003/"
    },
    {
      "key": "key2",
      "url": "http://IP2:9003/"
    }
  ]
}

I configured nodes to use the same database so it throws a JPA exception. Separating the database for each node solved this issue.


Message @user clipping through user banner

a fix for this is this
.footer-3naVBw {
margin-top: 20px;
padding: 0px;
}
:D

Did another, display: none KEKW

good job llmaoo


SageTV Forums down for ‘server relocation’ anyone know when they will return?

Hi again Sage types.  Last outage was last thanksgiving, 2019.  Any idea when this one (July 21, 2020) will be finished?  I didn’t see a pre-takedown warning message.  Anyone else?

Sorry, was just supposed to be a quick server relocation...but the DNS entries were not were I thought they were so I need to request some other internal config changes at Google. Hopefully will get done today.

Sorry, was just supposed to be a quick server relocation...but the DNS entries were not were I thought they were so I need to request some other internal config changes at Google. Hopefully will get done today.

Thanks for maintaining the Forums.

beauty, thanks.  Was about to do some rebuilding, and it’s always nice to have the information available in case of disaster :)


Improving Presto error message in explore/dashboard

Presto error messages have been horrible in Superset. This PR makes things much better and also fixes displaying the query when it fails hard.
Before/after:

LGTM


ActionController::UnpermittedParameters is raised when email or password are Arrays or Objects

Environment

Ruby 2.5.5
Rails 5.1.7
Devise 4.7.1

Current behavior
If a user passes an array for their email or password, devise will raise an error that the email and password params have not been permitted. It's correct, but a confusing message. I've added a spec on my own fork of the codebase: https://github.com/KevinMcHugh/devise/blob/e723ab2ce784f4ce86f274daa5b2fc91bfa0c538/test/controllers/sessions_controller_test.rb#L28
Expected behavior
I don't know what's appropriate here. It's probably not super-important. I only noticed it because pentesters hit it and caused some notification noise for me.
I added a before_action to my app's SessionController that checks for this condition (or if either email or password is a Hash) just so I won't hit the error. I didn't see it reported and it took me a while to decipher the error so I thought I'd bring it to your attention.
Thanks!

Hey! Thanks for the report but that's how Rails without with unpermitted parameters so I don't think there's anything we can do in Devise to fix that.


Pass Table instead of Class object

Dear Christian,
I would very much like to be able to just pass an empty table  with matching schema to a new instance of SQLTableDependency instead of first having to create a class object for the table. And then receive back all changed rows with their rowstates when the respective event fires.
Would this be possible? It is quite cumbersome to have to set up classes for all relevant tables and keep these classes up-to-date with possible changes made to table columns.
Thanks!

Hi IzzyGo,
I am sorry, but what you are asking me is currently impossible.
Regards

hello christian. that is sad. is there a flaw in my logic? am i missing something? i very much like your approach of havins sql push changes instead of pulling them in an interval. however, i need the changes in a table that can be MERGEd with an existing table to update the existing table (special case are deletions). would that be hard to implement? i would even pay something for it. thank you for your time, and of course, i would accept your second no to my request. best regards, marc

Am 17.06.2019 um 13:36 schrieb Christian Del Bianco<EMAIL_ADDRESS>Hi IzzyGo,
I am sorry, but what you are asking me is currently impossible.
Regards
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

"I would very much like to be able to just pass an empty table with matching schema to a new instance of SQLTableDependency instead of first having to create a class object for the table. And then receive back all changed rows with their rowstates when the respective event fires."
This result can be achieved only if i return back a Dictionary<string, object> where string is the column name and object id the new table column value.
However, this requires a huge change and it will be a custom (that is only for you) implementation.

Hello Christian,
I see that this would cause major work and also that it appears to only be useful for me, so it does not make sense that you spend time on it. I am nevertheless thankful for your reply. I will try to work out another way to reduce traffic, possible working with a record timestamp, should be easy.
I like your approach though, cool concept.
Thanks for your time and all the best!
Marc
Von: Christian Del Bianco<EMAIL_ADDRESS>Gesendet: Montag, 17. Juni 2019 20:24
An: christiandelbianco/monitor-table-change-with-sqltabledependency<EMAIL_ADDRESS>Cc: IzzyGo<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Betreff: Re: [christiandelbianco/monitor-table-change-with-sqltabledependency] Pass Table instead of Class object (#147)
"I would very much like to be able to just pass an empty table with matching schema to a new instance of SQLTableDependency instead of first having to create a class object for the table. And then receive back all changed rows with their rowstates when the respective event fires."
This result can be achieved only if i return back a Dictionary<string, object> where string is the column name and object id the new table column value.
However, this requires a huge change and it will be a custom (that is only for you) implementation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/christiandelbianco/monitor-table-change-with-sqltabledependency/issues/147?email_source=notifications&email_token=AMMB4WPYOESEUEARXSCUELLP27JCFA5CNFSM4HYVULCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX4BDCY#issuecomment-502796683 , or mute the thread https://github.com/notifications/unsubscribe-auth/AMMB4WLULEYA7AURRQJF7DTP27JCFANCNFSM4HYVULCA .  https://github.com/notifications/beacon/AMMB4WM2HATEPFBG45CERSDP27JCFA5CNFSM4HYVULCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX4BDCY.gif


Include Argo deployed resources when detecting app health

fixes https://github.com/stolostron/cluster-templates-operator/issues/162

/retest

/retest

/test ci-index-cluster-templates-bundle

/lgtm


Checklist Feature

A checkbox you can add infront of a sentence thats checkable simular to Samsung Notes, not sure how and where it could be possibly implemented but its a nice thing to have 😄

This feature is already proposed, please check #20 and #19.

Ah alright feel free to close this


Short aliases for infraction editing

At the moment, !infr edit last or !infr edit l is the fastest way to amend a previous infraction. Similar to #1170, but more limited in scope. Something like !i e l would be nice, if doable, if not !infr e l or even !iel.

Just making aliases to infr and edit will allow it to be extendable to the new append subcommand, so that seems good to me.
At the same time, the new subcommand might alter the way we use infr edit last, so we might want to first limit it to what was said in the previous sentence.

!i e l is doable as it simply requires an alias each on the group command and the subcommand. Also consider !ie using the root_aliases feature I added. last or an infraction ID could be passed as an argument as normal.


Add sorting and filtering to flags page

Signed-off-by: Dustin Hooten<EMAIL_ADDRESS>
This PR adds sorting, filtering, and some minor styling to the flags page. When the flags page loads, the filter is auto-focused, so the user can immediately start typing to filter flags. The matching substrings are bolded. Clicking the sort icons on either column sorts it. As a user of this page, I typically just use cmd+F, but I thought this would be nicer.
https://user-images.githubusercontent.com/6402556/108126413-0c958500-7067-11eb-8184-b43214012138.mov

This is brilliant.

By the way, did you notice that we have live preview of the react UI? https://deploy-preview-8500--prometheus-react.netlify.app/flags

One note: when I type a flag, e.g. --config.file, it is not selected. When I press --, everything disappears.

I will update it so it understands --

Okay, I just fixed and tested the issue with --. It works on  https://deploy-preview-8500--prometheus-react.netlify.app/flags

From a user perspective, +1

Hello @hooten, did you see the latest comments? Thanks!!

Yes, apologies. I had hand surgery last week and am just now able to type again. Thanks for the comments! I will make the changes.

Thanks for the suggestions. I've implemented them. I'd appreciate another look when you get a chance @juliusv @roidelapluie

This still seems a nice addition, is there any news?
Thanks!

I’d love to get to this eventually but it will probably not be for several weeks. If anyone else wants to finish this up quicker, that’s okay with me. If not I will finish it eventually

on my side, if it can help, I could try to change the fuzz lib used today like it is suggested by @juliusv.

@Nexucis sounds good to me, as long as you preserve @hooten's original commits here and base stuff on top of it.

ah I was thinking to more do it on another separate PR.
What do you have in mind @juliusv, exactly? I'm not sure I can change this current PR :s. So I'm not sure I'm following.

@Nexucis I think the best course of action would be to check out this PR branch locally (git checkout -b my-new-branch-name main && git pull https://github.com/hooten/prometheus.git flags), then make more local changes on that branch, then open a new PR for that.

mm ok, I will try this way then. Thanks @juliusv for the flow. Stay tuned 😄

Hi @juliusv and @hooten. I think I managed to finish the PR. I created another one (#8988). Previous work from @hooten is totally preserved. I just had some few new commits to fix the different issue raised here.
Let me know if it's fine like that :)

Thanks @Nexucis for completing this in https://github.com/prometheus/prometheus/pull/8988, and thanks to @hooten for the beginning :) Closing this initial PR now, as the other one is merged.


Update a.JAN.md

@youganjansarki18 the files format have been changed, sorry for the inconvenience! Do you want me to add them or can make another pull request about it. Apologies again!

I am making the pull request... 😊
On Tue, 20 Jul, 2021, 9:34 AM Vibali Joshi, @.***>
wrote:

@youganjansarki18 https://github.com/youganjansarki18 the files format
have been changed, sorry for the inconvenience! Do you want me to add them
or can make another pull request about it. Apologies again!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vibalijoshi/List-of-Opportunities/pull/9#issuecomment-883034115,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASFZGTB5ZUW6G7TQEOUQ3CDTYTYU5ANCNFSM5AUGMOJA
.


fix(angular): downgrade base version of Angular to 14.3.0

This PR downgrades the Angular version used by Green to the latest LTS version. This way. there shouldn't be any compatibility issues with using green-angular with Angular 14.3.0 and up.

👋 Thanks for creating a pull request! 🚀 Checkout the storybooks we've created for it: angularangular-charts


feat(browser history): added chrome, firefox, safari history search

Description
Added Search Browser History action similar to already existing Search Browser Bookmarks with

ability to enable each individual browser to be included in results
select ordering of first browser in results
open from any browser history in default browser
open from any browser history in specific browser via action panel
copy URL via action panel
support for Chrome, Firefox, Safari

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

I would recommend that you use useSQL instead of including it yourself

Hi @pernielsentikaer , I have tried using the useSQL hook but it results in
Error: Error: in prepare, unable to open database file (14)

    at Object.current (/Users/<user>/.config/raycast/extensions/mozilla-firefox/firefox-new-tab.js:4429:19)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

If i run the command directly in terminal I also get the same result

whereas running it with the WASM SQL it works properly.
This is after I also had to debug my path and see that the first sqlite3 executable picked up is from Android SDK which is at version 3.27.0 while the code invokes
const spawned = node_child_process_1.default.spawn("sqlite3", ["--json", "--readonly", databasePath, query], {

with --json flag, which seems to be available from 3.33.0, causing a hidden issue for me.
In summary, could I please continue using the embedded WASM SQL module please ?

Hi @pernielsentikaer ,
Did a refactor to use useSQL and the same issue happens with it. Seems like there is a bug in useSQL itself when trying to access Firefox places.sqlite file. Same issue happens as in above comment if i try sqlite3 directly.

![CleanShot 2022-12-10 at 19 59 49@2x](https://user-images.githubusercontent.com/12763781/206869041-81d2685e-9972-43d8-b050-d0a31f975cab.png)
Could this extension use WASM module as well in the meantime as other extensions are doing please ?

Raised #3853 issue for tracking as well with minimum reproducible code snippet.

Updated PR to add Edge, Brave and Vivaldi browsers history search.


Send URL instead of whole image

Like Dank Memer, it send url to image not whole image. By doing this, Meme bot can be faster

The performance issue is likely caused by the slow API: Firstly, the API is written in Python, and secondly, it searched several subreddits to return one image. In addition, the message was not a link. It's an embedded message, and you even have to send more information, which theoretically just slow it down. See Message Embed | discord.js for implementation on Node.js.
The image was also sent via URL as well (see: discord.js doc).
However, I don't think we can conclude without experiment. Feel free to make a PR and if the time turns out to be faster, then I'll merge it.

I don't know how Dank Memer bot choose which meme to send, but certainly the current algorithm I'm using contributes to this bot's slowness. It'd be great too, if you can come up with a better algorithm while still maintaining randomness.


investigate bycatch_setup usage in Benchmark

benchmark code uses this line about 10 times:
if(fleet_type(f)==1 || (fleet_type(f)==2 && bycatch_setup(f,3)==1))
where bycatch_setup(f,3) is intended to indicate where
Bmark_RelF_Use(f) uses scaling (1); input (2); or range of years (3)
in readdata, the usage is intended as:
echoinput<<"1:  fleet number; must match fleet definitions"<<endl;
echoinput<<"2:  1=include dead bycatch in total dead catch for F0.1 and MSY optimizations and forecast ABC; 2=omit from total catch for these purposes (but still include the mortality)"<<endl;
echoinput<<"3:  1=Fmult scales with other fleets; 2=bycatch F constant at input value; 3=mean bycatch F from range of years"<<endl;
It is not clear that all instances of the referenced line should be using bycatch_setup(f,3).  Some perhaps should be using bycatch_setup(f,2) or ypr_mask(f) that is modified according to bycatch_setup(f,2)

checked code.  looks OK.  will close issue.
would be useful to create a ivector relF_flag(1,Nfleet)
to replace this:
if(fleet_type(f)==1 || (fleet_type(f)==2 && bycatch_setup(f,3)==1))


Investigate/fix ScreenshotTestIT

Currently for some reason it needs @DirtiesContext before, otherwise it gets different webdriver object than the ScreenshotCreator - this occurs only on github (we werent able to simulate this locally)
We should try to investigate and fix this if possible

One thing to try is to change the test from groovy to java (if maybe spring beahves differently or spock does some magic or smth)


Preload Items and Update Past Initialisation

currently, launching the launcher --huh-- enforces a slight delay in order for it to fully load each entry.
this is fine in and of itself, as it isn't a major annoyance, far from it.
however, is such a delay truly necessary ? couldn't the assets related to the first displayed items be saved between sessions, as to immediately be displayed, before then loading the rest of the assets in order of appearance, and only after a fully realised initialisation checking the first entries for any updates to those ?
or perhaps no assets would have to be saved, instead fetching and displaying them one at a time, perhaps accompanied by a reveal animation, i.e. a fade-in of sorts ? this could end up looking even better whilst eliminating the loading screen altogether as well.

Unfortunately, even if assets were saved between sessions, most of the time taken during loading comes from a) reading the user's items in LauncherX from the disk, and b) adding controls to the GridView, both of which cannot be minimised. As such, there is a need for a loading screen for these things to happen.

Unfortunately, even if assets were saved between sessions, most of the time taken during loading comes from a) reading the user's items in LauncherX from the disk, and b) adding controls to the GridView, both of which cannot be minimised. As such, there is a need for a loading screen for these things to happen.

as pointed out by the very end of my initial comment, as i expected the above suggestions not to be easily feasible, how about displaying entries one at a time, with a reveal animation so as to look proper and intended ?

Certainly possible, but I think if I display the entries one by one with a reveal animation it would take up a significant amount of time, especially if the user has many items.

Certainly possible, but I think if I display the entries one by one with a reveal animation it would take up a significant amount of time, especially if the user has many items.

Would it not take as much time as the loading currently does, and even less than that to display the initial elements ? from then on, the speed at which the rest of the items load does not have to be tied to them being shown and present on the screen ; you may either only call the reveal animation once they are visible, even if they had already been loaded before scrolling, or reserve it for entries that have just been loaded.

Would it not take as much time as the loading currently does, and even less than that to display the initial elements ?

It would take the same amount of time to read and load the controls from disk, yes. By default, the GridView from WinUI already has a fade in animation when you add items, but for it to show when LauncherX is loading items, an artificial delay needs to be added between the addition of every item for the animation to play.


runtime:reflect string slice,the element type is interface{}

What version of Go are you using (go version)?
go version devel +94d7c884c3 Thu Dec 14 14:57:01 2017 +0000 darwin/amd64
Does this issue reproduce with the latest release?
YES
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/qipeng/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/qipeng/workspace/go"
GORACE=""
GOROOT="/Users/qipeng/program/go"
GOTMPDIR=""
GOTOOLDIR="/Users/qipeng/program/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/bs/9120vpt14jd7rkhg27kdbj480000gn/T/go-build475790858=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
func main() {
    str := `
    {
        "list":[0,1,2]
    }
  `
    m := map[string]interface{}{}
    err := json.Unmarshal([]byte(str), &m)
    if err != nil {
         panic(err)
    }
    fmt.Println(reflect.ValueOf(m["list"]).Index(1).Type())
}

What did you expect to see?
int64 or float64
What did you see instead?
interface {}

This is working as intended, per the encoding/json docs:
https://golang.org/pkg/encoding/json/#Unmarshal
Which says:
[]interface{}, for JSON arrays
If you want a more specific type, you need to define a struct to unmarshal into.


refactor(api): add back private members used in protocol development

Overview
This PR adds back in private members, and adds public counterparts, used in protocol development by our customer facing teams. If I missed anything, please let me know.
Moving forward @ncdiehl11 and @chazmanc, the software team has created this coda doc for us to reference either 1. workarounds we've given you and/or 2. feature requests from the apps eng team to make protocol development easier. We want to make sure we are not breaking future protocols!
Changelog

Added well parameters back in on the Well class. The private members are explicitly not versioned.
Added docs around the above
Added in a private member for hardware manager access in the protocol context.

Review requests
Check if I should add other things. If you have arguments against back in certain things, please leave a comment below.
Risk assessment
Low. Adding back in previously existing behavior.

I agree with you when a customer finds a random private member that they want to use. However, because we never had public members for some of these things (i.e. the hardware manager etc) then we started sending off protocols to customers that accessed private members.
We could argue that 4.0.0 is a major version bump, and therefore it's no longer our responsibility to maintain them, but I do feel a bit icky doing that. The breaking change was meant to be that API v1 was no longer available, not that customer's protocols would break in API V2 and there was no version control in that sense.
@ncdiehl11 or @chazmanc would you mind weighing in on how often the well parameters/hardware manager is used and sent to customers?

I agree with you when a customer finds a random private member that they want to use. However, because we never had public members for some of these things (i.e. the hardware manager etc) then we started sending off protocols to customers that accessed private members.
We could argue that 4.0.0 is a major version bump, and therefore it's no longer our responsibility to maintain them, but I do feel a bit icky doing that. The breaking change was meant to be that API v1 was no longer available, not that customer's protocols would break in API V2 and there was no version control in that sense.
@ncdiehl11 or @chazmanc would you mind weighing in on how often the well parameters/hardware manager is used and sent to customers?

@amitlissack I agree with you when a customer finds a random private member that they want to use. However, because we never had public members for some of these things (i.e. the hardware manager etc) then we started sending off protocols to customers that accessed private members.
We could argue that 4.0.0 is a major version bump, and therefore it's no longer our responsibility to maintain them, but I do feel a bit icky doing that. The breaking change was meant to be that API v1 was no longer available, not that customer's protocols would break in API V2 and there was no version control in that sense.
@ncdiehl11 or @chazmanc would you mind weighing in on how often the well parameters/hardware manager is used and sent to customers?

A reasonable compromise to me, if I'm alone in thinking that supporting all private members from the past is a bad idea, seems to mark these _ prefixed properties as targeted for deprecation in an immediate version of the API. And creating a ticket to remove them.
So the warning isn't just "deprecated", but "will be removed in version 4.2".

@amitlissack I agree with you when a customer finds a random private member that they want to use. However, because we never had public members for some of these things (i.e. the hardware manager etc) then we started sending off protocols to customers that accessed private members.
We could argue that 4.0.0 is a major version bump, and therefore it's no longer our responsibility to maintain them, but I do feel a bit icky doing that. The breaking change was meant to be that API v1 was no longer available, not that customer's protocols would break in API V2 and there was no version control in that sense.
@ncdiehl11 or @chazmanc would you mind weighing in on how often the well parameters/hardware manager is used and sent to customers?

A reasonable compromise to me, if I'm alone in thinking that supporting all private members from the past is a bad idea, seems to mark these _ prefixed properties as targeted for deprecation in an immediate version of the API. And creating a ticket to remove them.
So the warning isn't just "deprecated", but "will be removed in version 4.2".

So, I think there's a few questions here.

Can we preserve these private methods perpetually?

Certainly, we must let them break at some point.
Is it appropriate for us to let them break today? @amitlissack seems to think yes; @Laura-Danielle seems to think no; I don't have an informed opinion.

If we decide that we're preserving these private methods today, how do we do that robustly?

In my opinion:

We specify, document, and test them as if they were public methods. We leave source comments so that it's glaringly obvious to anyone working on that code that they need to be preserved.
In general, we commit to our decision to support them for however long we've decided. No "best effort" support, or supporting them only until a refactor is inconvenienced by them. That's too wishy-washy.

@amitlissack:

A reasonable compromise to me, if I'm alone in thinking that supporting all private members from the past is a bad idea, seems to mark these _ prefixed properties as targeted for deprecation in an immediate version of the API. And creating a ticket to remove them.
So the warning isn't just "deprecated", but "will be removed in version 4.2".

With any kind of scheduled deprecation, we should keep in mind that the Opentrons App's can't surface Python warnings to the user. Unless we fix that, we'll always risk customers who are happily running their Opentrons-written protocols someday running into surprise breakage, no matter how long we give them to get their protocols fixed.

So, I think there's a few questions here.

Can we preserve these private methods perpetually?

Certainly, we must let them break at some point.
Is it appropriate for us to let them break today? @amitlissack seems to think yes; @Laura-Danielle seems to think no; I don't have an informed opinion.

If we decide that we're preserving these private methods today, how do we do that robustly?

In my opinion:

We specify, document, and test them as if they were public methods. We leave source comments so that it's glaringly obvious to anyone working on that code that they need to be preserved.
In general, we commit to our decision to support them for however long we've decided. No "best effort" support, or supporting them only until a refactor is inconvenienced by them. That's too wishy-washy.

@amitlissack:

A reasonable compromise to me, if I'm alone in thinking that supporting all private members from the past is a bad idea, seems to mark these _ prefixed properties as targeted for deprecation in an immediate version of the API. And creating a ticket to remove them.
So the warning isn't just "deprecated", but "will be removed in version 4.2".

With any kind of scheduled deprecation, we should keep in mind that the Opentrons App's can't surface Python warnings to the user. Unless we fix that, we'll always risk customers who are happily running their Opentrons-written protocols someday running into surprise breakage, no matter how long we give them to get their protocols fixed.

I think we're overthinking this a bit (but I would like to see a couple small changes). We have a robust mechanism for enforcing changes in the protocol API and surfacing problems: the API version. The versioning documentation explicitly does not call out removal of things from the protocol api as requiring a major version bump; only large structural changes, which this is not.
Here is what I think we should do:

Add the new public accessors under a new API version, 2.9
Add the private accessors back and retroactively tag them as available from API version 2.0. Implement them in parallel as top level accessors, rather than having the public accessors depend on the private ones.
Add a way to remove things in API versions that raises an error that says "this was removed in api version xx" and mark the private methods as removed in API version 2.9
We commit to supporting the private method accessors in the same terms as anything else: they are supported in API levels 2.8 and under. As long as API level 2.8 and under is supported by the robot software, the private method accessors will be supported.

This is definitely an unfortunate place to find ourselves in! But we can't retroactively break protocols (more than we already have). The way forward to avoid this in the future is to keep records of workarounds that we have given to customers and aggressively prioritize making public methods for those customers.
So, the specific changes I'd like to see here are the addition of a "removed-in" marker with appropriate errors, and the addition of added-in and the new removed-in marker to the private properties.

I would like to understand where the line stops. If we declare that removing _hw_manager from ProtocolContext is a breaking change, what does that mean for the members of API class? Is changing any of those now a breaking change too?
Would also like to understand how we communicate these workarounds to customers. What promises are made? What are expectations?
My expectation is that I'm on my own if I use some class in some library that has a member called _hw_manager.
I'll be sad, but will accept @sfoster1 's solution if this is the last time this kind of thing happens.

I think we're overthinking this a bit (but I would like to see a couple small changes). We have a robust mechanism for enforcing changes in the protocol API and surfacing problems: the API version. The versioning documentation explicitly does not call out removal of things from the protocol api as requiring a major version bump; only large structural changes, which this is not.
Here is what I think we should do:

Add the new public accessors under a new API version, 2.9
Add the private accessors back and retroactively tag them as available from API version 2.0. Implement them in parallel as top level accessors, rather than having the public accessors depend on the private ones.
Add a way to remove things in API versions that raises an error that says "this was removed in api version xx" and mark the private methods as removed in API version 2.9
We commit to supporting the private method accessors in the same terms as anything else: they are supported in API levels 2.8 and under. As long as API level 2.8 and under is supported by the robot software, the private method accessors will be supported.

This is definitely an unfortunate place to find ourselves in! But we can't retroactively break protocols (more than we already have). The way forward to avoid this in the future is to keep records of workarounds that we have given to customers and aggressively prioritize making public methods for those customers.
So, the specific changes I'd like to see here are the addition of a "removed-in" marker with appropriate errors, and the addition of added-in and the new removed-in marker to the private properties.

I would like to understand where the line stops. If we declare that removing _hw_manager from ProtocolContext is a breaking change, what does that mean for the members of API class? Is changing any of those now a breaking change too?
Would also like to understand how we communicate these workarounds to customers. What promises are made? What are expectations?
My expectation is that I'm on my own if I use some class in some library that has a member called _hw_manager.
I'll be sad, but will accept @sfoster1 's solution if this is the last time this kind of thing happens.

I would like to understand where the line stops....
[...]
My expectation is that I'm on my own if I use some class in some library that has a member called _hw_manager.

Possibly, the criteria should be:

Were protocols with the unsupported method written by Opentrons Applications Engineering?
And, are those protocols used by customers who don't know Python?

 You should understand the implications of using underscore-prefixed names.

I would like to understand where the line stops....
[...]
My expectation is that I'm on my own if I use some class in some library that has a member called _hw_manager.

Possibly, the criteria should be:

Were protocols with the unsupported method written by Opentrons Applications Engineering?
And, are those protocols used by customers who don't know Python?

 You should understand the implications of using underscore-prefixed names.

From a F2F meeting, the following was decided:

Keep _hw_manager as a private member in protocol context
Remove remaining private members, but add public versions for API version 2.9.
Create a separate PR to throw an error when a member is removed in a certain version.

From a F2F meeting, the following was decided:

Keep _hw_manager as a private member in protocol context
Remove remaining private members, but add public versions for API version 2.9.
Create a separate PR to throw an error when a member is removed in a certain version.


update version to 0.14.0

Hi, new contributor here 👋
Would it be possible to update to this version along with or shortly after this PR is merged? This version of Terraform  does not seem to contain any breaking changes and would be very useful to my work.
Thanks!
Also, please do let me know if there are any project-specific practices I should be aware of. I will gladly make any modifications needed to my PR structure.

Released images for 0.14.11 and 0.15.1


broken test: when replacing whitespace

Caused by a bug in 'split', PR for fix in split: https://github.com/dominictarr/split/pull/14

I will update this PR with the new 'split' version once the bugfix is pulled

Cool just make sure to bump to<EMAIL_ADDRESS>Thanks!

merged into 3.2.2 with<EMAIL_ADDRESS>On Mon, Feb 2, 2015 at 11:08 PM, Tejesh Mehta<EMAIL_ADDRESS>wrote:

Cool just make sure to bump to<EMAIL_ADDRESS>Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/dominictarr/event-stream/pull/82#issuecomment-72432113
.


BAU: Remove DDB TTL from UserIssuedCredentialsV2Table

Proposed changes
What changed
Remove DDB TTL from UserIssuedCredentialsV2Table
Why did it change
This removes the config from the SAM template that enables the DynamoDB TTL feature for the UserIssuedCredentialsV2Table table. This will have the effect of no more VCs being removed automatically from the table once the timestamp in the ttl attribute of the record has been reached.
It also removes the writing of the ttl timestamp for any future VCs stored in the table as this is no longer required.

Looks good, a couple of thoughts:
* If you wanted to be particularly complete, you could remove the `ttl` property on `VcStoreItem` and add an explicit `setTtl` method that logs a warning (or even throws)

* Are you planning to do any checks in lower envs first (beyond integration tests)? I can't really think what they would be tbh

Ah, good point. I'll remove the attribute. Might be confusing to leave it in. I was debating about adding a comment somewhere not to use ttl, and the setter would be a good place to communcate this.
I've already deployed this to my dev account to make sure it the change doesn't blow up - it seems fine. Other than that I'm not sure what else could be done. I would say I could check the oldest VCs at the point the change goes out and then make sure they're still there in a couple of days, but we already know how hard that is to do...


[EdgeX 3.0] Collapse Pub/Sub hosts into a single host

Currently this abstraction supports a separate connects for Subscribe and Publishing due to initial ZMQ implementation. ZMQ is now deprecated and will be remove in EdgeX 3.0, at which time the abstraction can be simplified to have a single connection defined for both subscriptions and publishing.

Duplicate of https://github.com/edgexfoundry/go-mod-messaging/issues/196


Best approach to working with extension modules in Chalice

What is the best approach to working with extension modules in Chalice?
For example, if my Chalice app uses the popular cryptography module I encounter this problem

I develop my Chalice app on my Ubuntu laptop

I chalice deploy the app which causes extension modules to be built on my Ubuntu architecture system and added to my lambda zip

I attempt to use my app in lambda and get errors like the following because my python extension modules weren't built on an Amazon Linux system
  Unable to import module 'app': libssl.so.1.0.0: cannot open shared object file: No such file or directory

I can spin up an Amazon Linux ec2 instance and install/build my requirements.txt modules, but what's the best way to then make Chalice aware of these modules, just copy them into .chalice/venv?
Once I do that, will my chalice local runs on my Ubuntu system no longer work because they're using extension modules build in Amazon Linux?
I'm mainly trying to determine if this is a problem that Chalice doesn't yet have a solution for or if I'm overlooking something and Chalice does support extension modules.

Maybe a workaround in the meantime would be to setup two directories, one for local and one for deploy put app.py in local and symlink to it in deploy. Then run chalice local in the local directory to build the extension modules on my local architecture and download the packages and libraries built on an amazon linux machine into the deploy directory's .chalice dir.

The new tutorial for the beta version of Chalice actually specifically calls out the cryptography package. I haven't tried from an ubuntu laptop but I think building from that should work with the new build process. Open up a new issue if you run into any problems!


Location of conf.py file

This might not be easy, but the conf file should really be at the root level of the directory.
It's very hard to find when mixed in among the rst files.

@jstac I will be looking into the proposed layout (discussed at the last meeting) for this repository in the next day or two.

the conf.py file is now located at the root level of the repository as per PR #484


winget doesn't check that it's pre-installed on machine. Try to installing again.

Brief description of your issue
Put this command in abc.bat file
winget install --id Microsoft.DotNet.SDK.Preview --version 7.0.100-preview.5.22307.18
and run it, you will be able to install the software. When you run the same again as the administrator, you see it's downloading and installing again. This is weird.
I think I can rely on winget and prepare a script for future to preinstall the software on dev machine but I am not able to do that because of this issue.
Steps to reproduce
Run the same script again after successfully install
Expected behavior
It must give a warning it's preinstalled and tell the person to continue (if he might want to repair)
or just give an error it's already there. and exit
The problem now is if it's preinstalled, it's still wasting the bandwidth to install the same thing again. If script does have few software which doesn't exist on machine. it's downloading all stuff that can be better checked and prevented to save bandwidth.

We're working on a fix for this where we check to see if the package is already installed when a user runs winget install <package>. We would switch to the upgrade flow in that case.

This issue has been resolved and is available in our latest preview release.


Merge execute action app into unit test app

Testing of the Execute action does not require a separate, dedicated application; the unit test app can handle it with its own scenario. Merging it into the unit test app slightly reduces build and the number of built and copied assets.
How to call the Execute action scenario before and after this change:
- dotnet Microsoft.Diagnostics.Monitoring.ExecuteActionApp.dll TextFileOutput <path> <content>
+ dotnet Microsoft.Diagnostics.Monitoring.UnitTestApp.dll Execute TextFileOutput <path> <content>

/backport to release/7.x

/backport to release/6.x


Says max hit is 29 when it should be 13

I have my setup with magic short bow(i) using broad arrows on a slayer task at 77 range and it says DPS is 6.499 and max hit is 29 but max hit should be 29 and DPS should be way less.

Looks like this was actually caused by a bug in the wiki scraper which was assigning ranged accuracy to ranged strength, rather than any bug in the formulas. Fixed in LlemonDuck/runelite-wiki-scraper@1d99caa11e2d9c05c4b994b9e2ef05c3c1def9b9.
This means I'll be able to fix the bug without making a new deploy to the plugin hub. The scraper has been re-run and the results were merged in from LlemonDuck/runelite-wiki-scraper#25. Your client should pick up the new item data next time it is restarted.
Here is the panel showing the correct DPS calculation (I will need to look into why the salve warning is appearing):

Salve warning is now also fixed with more info here:

#59