Make sure to not dispatch to shut-down queues in MTROTAProviderDelegateBridge.

Make sure we call our delegate callbacks on a queue different from the Matter work queue.
Assert that we are on the Matter work queue in all the places where we should be.
Make sure to dispatch to the Matter work queue via the controller we were dealing with, so dispatch does not happen if that controller has shut down.
Reset OTA transfers when the controller the transfer is associated with shuts down.
Ensure that async callbacks for a stale transfer don't affect a current transfer.

Fixes https://github.com/project-chip/connectedhomeip/issues/22541

Fast-tracking platform-specific fix with platform owner review.


Update general preflight package to allow for preflight checks to specify configuration options

To support #668 updates need to be made to the preflight package within carvel-dev/kapp to allow for preflight checks to be configurable.
If the proposal for adding this functionality to carvel-dev/kapp has been accepted prior to starting this work, all changes should be made against  carvel-dev/kapp, otherwise the changes should be made against https://github.com/everettraven/kapp/tree/feature/crd-upgrade-safety-preflight

Done in carvel-dev/kapp as of https://github.com/carvel-dev/kapp/pull/900 - closing


Please add license in GitHub settings

Please add license in GitHub settings of the repository.
Currently, GitHub could not identify Your project licence, and it's not shown in interface, and not available via Github's API also.
Ref : https://help.github.com/articles/adding-a-license-to-a-repository/

Hi !
I just get the answer from GitHub support team. Basically, GitHub uses automatic license detector : https://github.com/benbalter/licensee
I just installed it locally and get following results :
bundle exec bin/licensee detect https://github.com/yiisoft/yii2 --remote --license bsd-3-clause
License:
Matched files:  LICENSE.md, package.json
LICENSE.md:
  Content hash:  587d7a2a466c4862573ba3d29864b18f80d764f8
  License:
  Closest licenses:
    BSD-3-Clause similarity:        92.00%
    BSD-3-Clause-Clear similarity:  90.35%
    BSD-2-Clause similarity:        84.62%
package.json:
  Confidence:  90.00%
  Matcher:     Licensee::Matchers::NpmBower
  License:     BSD-3-Clause
Comparing to BSD 3-Clause "New" or "Revised" License:
Input Length:      1583
License length:    1410
Similarity:      92.00%
diff --git a/LICENSE b/LICENSE
index 73e3883..f5630b7 100644
--- a/LICENSE
+++ b/LICENSE
@@ -1,19 +1,21 @@
{+the yii framework is free software. it is released under the terms of the+}
{+following bsd license. copyright © 2008 by yii software llc+}
{+http://www.yiisoft.com all rights reserved.+} redistribution and use in source and
binary forms, with or without modification, are permitted provided that the
following conditions are met: redistributions of source code must retain the
above copyright notice, this list of conditions and the following disclaimer.
redistributions in binary form must reproduce the above copyright notice, this
list of conditions and the following disclaimer in the documentation and/or
other materials provided with the distribution. neither the name of [-the copyright holder-]{+yii software+}
{+llc+} nor the names of its contributors may be used to endorse or promote products
derived from this software without specific prior written permission. this
software is provided by the copyright holders and contributors "as is" and any
express or implied warranties, including, but not limited to, the implied
warranties of merchantability and fitness for a particular purpose are
disclaimed. in no event shall the copyright [-holder-]{+owner+} or contributors be liable for
any direct, indirect, incidental, special, exemplary, or consequential damages
including, but not limited to, procurement of substitute goods or services; loss
of use, data, or profits; or business interruption however caused and on any
theory of liability, whether in contract, strict liability, or tort including
negligence or otherwise arising in any way out of the use of this software, even
if advised of the possibility of such damage.

All of the sections surrounded by {+ and +} are additions that that tool detected. GitHub has 98% confidence requirement, so with those changes GitHub not meeting that threshold to detect this license.
If the project removes those additions, then the license will be detected properly.
Of course, it's author's and community choice, which version of license the project should use.

Would be nice if GitHub could learn to read this from composer.json  files.

@schmunk42 In a legal sense, the text of the license is more important, not mentions in composer.json.

Removing first line of license file should be enough - it is redundant to the rest of license content anyway:

The Yii framework is free software. It is released under the terms of the following BSD License.

https://github.com/yiisoft/yii2/commit/58c9a6e83e5f68452309b0121528ba1ac948fc1a

Let's see if it helps.

I see BSD-3-Clause here:

This was working before and imo should be reported as a bug to github instead of changed here. Imo it's important to state in the file that it is a BSD license. When checking for the license file seeing BSD will tell enough you need to know in most cases.

That's because I've changed it. Before it wasn't there.

A few month ago it definitively was there.

When checking for the license file seeing BSD will tell enough you need to know in most cases.

If you know what BSD license is, you will recognize it at first glance.
IMO the bigger problem is current file header - you need to click a link to know a license:
/**
 * @link http://www.yiiframework.com/
 * @copyright Copyright (c) 2008 Yii Software LLC
 * @license http://www.yiiframework.com/license/
 */

I prefer something like:
/*
 * This file is part of the Yii Framework.
 *
 * Copyright (c) 2008 Yii Software LLC
 *
 * Licensed under BSD 3-Clause License. For the full copyright and license information,
 * please view the LICENSE.md file that was distributed with this source code.
 */

Closing since:

License is now identified/linked.
For 3.0 we're removing excessive headers.


[BUG] UPDATE_PKG_CACHE seems to not work

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[x] I have read and understood the contributors guide.
[x] The issue I am reporting can be replicated.
[x] The issue I am reporting can be is directly related to the pivpn installer script.
[] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

@orazioedoardo First of all i am sorry i am raising duplicated stuff that has been talked before, but as you know been in Lurk mode, but seen this happening quite often, and with all the testing i am trying maybe it will be possible to find some clues on how to fix this.
Describe the bug
Has we have seen in the past, some users complain that the script fails then they run apt udpate and it works,
During testing i stumbled upon this scenario, on ubuntu 18.04,
2 different systems, same distro, one is a VPS that i spun up for some manual testing, the another one is the VM that travis spins up to run the testing.
on the VPS the script worked straight away,
on Travis I need to add apt update as first step of the script, otherwise iptables-persistent would fail to install
This doesn't seem to have happened in any scenario on ubuntu 16.04 so far.
:::    Checking for whiptail... already installed!
:::    Checking for net-tools... already installed!
:::    Checking for bsdmainutils... already installed!
:::    Checking for iptables-persistent... not installed!
:::    Failed to install iptables-persistent!
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package iptables-persistent

To Reproduce
Not sure how to reproduce and on which conditions this happens.
Expected behavior
PiVPN should update package cache which seems to not happen in some situations
Additional context
Some questions that it brings me...
Is updatePackageCache() really working all the time? what could cause it not to work some times?
Possible solution 1
change UPDATE_PKG_CACHE to ${PKG_MANAGER} update -y
and ignore this: https://github.com/pivpn/pivpn/blob/master/auto_install/install.sh#L408-L417 and make it run every time the install script runs?
I would say that the logic behind of that  is nice, but nowadays there are so many factors that can probably trigger false positive when it tests if apt update was already executed or not.
Possible solution 2
simply not run it, and let users now that they should run it prior to install, this could be added to "how to install" section
sudo apt update && sudo apt upgrade && curl -L https://install.pivpn.io | bash

Same behavior seen on AWS Ubuntu 20.04.  Perhaps run it anyway?

Replicated also on AWS Ubuntu 16.04 .. marking as bug

Where is why it fails:
ubuntu@ip-172-31-44-17:~$ bash pkcachetest
stat: missing operand
Try 'stat --help' for more information.
date: invalid date ‘@’
:::
::: apt-get update has not been run today. Running now...
pkcachetest: line 20: spinner: command not found
 done!

hmm well the function is clearly somewhat broken
ubuntu@ip-172-31-44-17:~$ sudo bash pkcachetest
stat: missing operand
Try 'stat --help' for more information.
date: invalid date ‘@’
:::
::: apt-get update has not been run today. Running now...
Hit:1 http://eu-north-1.ec2.archive.ubuntu.com/ubuntu xenial InRelease
Hit:2 http://eu-north-1.ec2.archive.ubuntu.com/ubuntu xenial-updates InRelease
Hit:3 http://eu-north-1.ec2.archive.ubuntu.com/ubuntu xenial-backports InRelease
Get:4 http://security.ubuntu.com/ubuntu xenial-security InRelease [109 kB]
Fetched 109 kB in 0s (188 kB/s)
Reading package lists... Done
 done!
ubuntu@ip-172-31-44-17:~$
ubuntu@ip-172-31-44-17:~$
ubuntu@ip-172-31-44-17:~$ sudo bash pkcachetest
stat: missing operand
Try 'stat --help' for more information.
date: invalid date ‘@’
\:::
::: apt-get update has not been run today. Running now...
Hit:1 http://security.ubuntu.com/ubuntu xenial-security InRelease
Hit:2 http://eu-north-1.ec2.archive.ubuntu.com/ubuntu xenial InRelease
Hit:3 http://eu-north-1.ec2.archive.ubuntu.com/ubuntu xenial-updates InRelease
Hit:4 http://eu-north-1.ec2.archive.ubuntu.com/ubuntu xenial-backports InRelease
Reading package lists... Done
 done!
ubuntu@ip-172-31-44-17:~$ sudo bash pkcachetest
stat: missing operand
Try 'stat --help' for more information.
date: invalid date ‘@’
:::
::: apt-get update has not been run today. Running now...
Hit:1 http://eu-north-1.ec2.archive.ubuntu.com/ubuntu xenial InRelease
Hit:2 http://eu-north-1.ec2.archive.ubuntu.com/ubuntu xenial-updates InRelease
Hit:3 http://eu-north-1.ec2.archive.ubuntu.com/ubuntu xenial-backports InRelease
Hit:4 http://security.ubuntu.com/ubuntu xenial-security InRelease
Reading package lists... Done
 done!

All were run one after another .. it Runs tough! running script after running that exact same function worked as well ...

Removed the redirection to dev/null
ubuntu@ip-172-31-47-78:~/pivpn/auto_install$ ./install.sh
:::
::: sudo will be used for the install.
::: Hostname length OK
::: Verifying free disk space...
:::
::: Checking apt-get for upgraded packages.... done!
:::
::: Your system is up to date! Continuing with PiVPN installation...
:::    Checking for git... already installed!
:::    Checking for tar... already installed!
:::    Checking for wget... already installed!
:::    Checking for curl... already installed!
:::    Checking for grep... already installed!
:::    Checking for dnsutils... already installed!
:::    Checking for whiptail... already installed!
:::    Checking for net-tools... already installed!
:::    Checking for bsdmainutils... already installed!
:::    Checking for apt-transport-https... already installed!
:::    Checking for iptables-persistent... not installed!
:::    Failed to install iptables-persistent!
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package iptables-persistent

For some reason the apt-get update is not running at all and not even sending any output
Deleted the if condition and as i suspected the apt update ran without any issues,
updatePackageCache(){
        #Running apt-get update/upgrade with minimal output can cause some issues with
        #requiring user input

        #Check to see if apt-get update has already been run today
        #it needs to have been run at least once on new installs!
        timestamp=$(stat -c %Y ${PKG_CACHE})
        timestampAsDate=$(date -d @"${timestamp}" "+%b %e")
        today=$(date "+%b %e")

        $SUDO ${UPDATE_PKG_CACHE}
}

Reuslt:
ubuntu@ip-172-31-47-78:~/pivpn/auto_install$ ./install.sh
:::
::: sudo will be used for the install.
 Done
::: Hostname length OK
::: Verifying free disk space...
:::
::: Checking apt-get for upgraded packages.... done!
:::
::: There are 49 updates available for your system!
::: We recommend you update your OS after installing PiVPN!
:::
:::    Checking for git... already installed!
:::    Checking for tar... already installed!
:::    Checking for wget... already installed!
:::    Checking for curl... already installed!
:::    Checking for grep... already installed!
:::    Checking for dnsutils... already installed!
:::    Checking for whiptail... already installed!
:::    Checking for net-tools... already installed!
:::    Checking for bsdmainutils... already installed!
:::    Checking for apt-transport-https... already installed!
:::    Checking for iptables-persistent... not installed!
:::    Package iptables-persistent successfully installed!
::: Cancel selected, exiting....

to be honest i don't think it is worth spending time trying to understand why the if statement fails ... rather just run the apt-get update regardless

@orazioedoardo any takes about this?

Just a hunch:
The if condition you removed may be effected by this, from man apt-get:
-s, --simulate, --just-print, --dry-run, --recon, --no-act
           No action; perform a simulation of events that would occur based on the current system state but do not actually change the system.
           Locking will be disabled (Debug::NoLocking) **so the system state could change** while apt-get is running.

** Added emphasis.
As your date stamp is testing the age of the apt directory PKG_CACHE="/var/lib/apt/lists/" is it possible that this:
https://github.com/pivpn/pivpn/blob/13f0fe7cbdcdb31537b3fd0e2eb34652e886cc1b/auto_install/install.sh#L428
is updating the directory time stamp ?

Since the problem is not when the cache is updated, it is whether the package is available, would this be a solution.  I have only seen the problem with iptables-persistent, so test for that package:
#!/bin/bash
apt-cache show iptables-persistent
if [ $? = 100 ]; then
        echo "not available, needs apt-get"
        sudo apt-get update
        apt-cache show iptables-persistent
        if [ $? = 0 ]; then
                echo "ok, its available now"
        fi
fi

@TinCanTech However notifyPackageUpdatesAvailable() runs after updatePackageCache().
@4s3ti @shelleycat485 Can you check the timestamp of stat -c %Y /var/lib/apt/lists/ on a clean install?

@TinCanTech However notifyPackageUpdatesAvailable() runs after updatePackageCache().

Yes, as per this log:

Removed the redirection to dev/null
ubuntu@ip-172-31-47-78:~/pivpn/auto_install$ ./install.sh
:::
::: sudo will be used for the install.
::: Hostname length OK
::: Verifying free disk space...
:::
::: **Checking apt-get for upgraded packages.... done!**
:::
::: **Your system is up to date! Continuing with PiVPN installation...**
:::    Checking for git... already installed!
:::    Checking for tar... already installed!
:::    Checking for wget... already installed!
:::    Checking for curl... already installed!
:::    Checking for grep... already installed!
:::    Checking for dnsutils... already installed!
:::    Checking for whiptail... already installed!
:::    Checking for net-tools... already installed!
:::    Checking for bsdmainutils... already installed!
:::    Checking for apt-transport-https... already installed!
:::    Checking for iptables-persistent... not installed!
:::    Failed to install iptables-persistent!
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package iptables-persistent

For some reason the apt-get update is not running at all and not even sending any output
Deleted the if condition and as i suspected the apt update ran without any issues,

if [ ! "${today}" == "${timestampAsDate}" ]; then
The if condition evaluates that ${today}" is equal to "${timestampAsDate}"
today=$(date "+%b %e") -- This is correctly evaluated to today in the form: Jan 1' timestampAsDate=$(date -d @"${timestamp}" "+%b %e") -- This is correctly evaluated to the date of the directory in the form: Jan 1
timestamp=$(stat -c %Y ${PKG_CACHE}) -- This returns the correct value for the date stamp of the directory in the form: seconds since epoch
However, from the log above:
::: **Checking apt-get for upgraded packages.... done!**
This does the following:
updatesToInstall=$(eval "${PKG_COUNT}")
This does the following:
PKG_COUNT="${PKG_MANAGER} -s -o Debug::NoLocking=true upgrade | grep -c ^Inst || true"
Which effectively runs:
apt-get -s -o Debug::NoLocking=true upgrade
And man apt-get we find:
-s, --simulate, --just-print, --dry-run, --recon, --no-act
           No action; perform a simulation of events that would occur based on the current system state but do not actually change the system.
           Locking will be disabled (Debug::NoLocking) **so the system state could change** while apt-get is running.

Clearly, if the two dates of ${TODAY} and "${timestampAsDate}" are equal then apt-get has been run. However, it has not been run correctly, it has only been simulated but that simulated run was enough to update the directory time stamp and therefore fool the script into deciding that apt-get has been run today to completion when, in fact, it has not.

On AWS Ubuntu 20.04, new install
-s does not seem to work at all with update which means it does nothing:  The directory tiemstamp does not change under these conditions
ubuntu@ip-10-66-0-170:~$ stat -c %Y /var/lib/apt/lists/
1608222458
ubuntu@ip-10-66-0-170:~$ sudo apt-get -s update
E: Command line option 's' [from -s] is not understood in combination with the other options.
ubuntu@ip-10-66-0-170:~$ sudo apt-get --dry-run update
E: Command line option --dry-run is not understood in combination with the other options
ubuntu@ip-10-66-0-170:~$ sudo apt-get -s upgrade
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
ubuntu@ip-10-66-0-170:~$ stat -c %Y /var/lib/apt/lists/
1608222458
ubuntu@ip-10-66-0-170:~$

On AWS Ubuntu 20.04, new install
-s does not seem to work at all with update which means it does nothing: The directory tiemstamp does not change under these conditions

AWS may simply disable this on account of bandwidth, etc.

Similar/same problem occurs trying to install in Ubuntu 20.04.1 LTS 64-bit running on Raspberry Pi4. Manually installed a number of the packages (starting with the iptables-persistent failure). It does install to completion, but still has a number of errors (unfortunately didn't capture the details/log). I may do a fresh install as busy setting up for various requirements.

Similar/same problem occurs trying to install in Ubuntu 20.04.1 LTS 64-bit running on Raspberry Pi4. Manually installed a number of the packages (starting with the iptables-persistent failure). It does install to completion, but still has a number of errors (unfortunately didn't capture the details/log). I may do a fresh install as busy setting up for various requirements.

@rjblake The test branch properly shows the apt/dpkg error log on ubuntu, you should try that.

@rjblake The test branch properly shows the apt/dpkg error log on ubuntu, you should try that.

@orazioedoardo - I checked the /var/log/apt files and nothing of use there. I may have a log from the terminal, as the errors came later in the install process. Also, once the GUI section appeared, other issues. Best to do uninstall and try do it all again perhaps for full info

@orazioedoardo - I checked the /var/log/apt files and nothing of use there. I may have a log from the terminal, as the errors came later in the install process. Also, once the GUI section appeared, other issues. Best to do uninstall and try do it all again perhaps for full info

Submitting MR with fix for this in a while

Submitting MR with fix for this in a while

Found the details from a previous session I had saved. Including here in case relevant (can't sort formatting, sorry)
ubuntu@ubuntu:~$ sudo apt update && sudo apt upgrade && curl -L https://install.pivpn.io | bash Hit:1 http://ports.ubuntu.com/ubuntu-ports focal InRelease Hit:2 http://ports.ubuntu.com/ubuntu-ports focal-updates InRelease                     Hit:3 http://ports.ubuntu.com/ubuntu-ports focal-backports InRelease                                                    Hit:4 http://ports.ubuntu.com/ubuntu-ports focal-security InRelease                                                     Hit:5 https://download.docker.com/linux/ubuntu focal InRelease                                    Ign:6 https://ookla.bintray.com/debian generic InRelease                                          Get:7 https://ookla.bintray.com/debian generic Release [4389 B] Fetched 4389 B in 2s (1995 B/s) Reading package lists... Done Building dependency tree        Reading state information... Done All packages are up to date. Reading package lists... Done Building dependency tree        Reading state information... Done Calculating upgrade... Done 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                  Dload  Upload   Total   Spent    Left  Speed 100   162  100   162    0     0   1012      0 --:--:-- --:--:-- --:--:--  1012 100 83088  100 83088    0     0   221k      0 --:--:-- --:--:-- --:--:--  221k ::: ::: sudo will be used for the install. ::: Hostname length OK ::: Verifying free disk space... ::: ::: Checking apt-get for upgraded packages.... done! ::: ::: Your system is up to date! Continuing with PiVPN installation... :::    Checking for git... already installed! :::    Checking for tar... already installed! :::    Checking for wget... already installed! :::    Checking for curl... already installed! :::    Checking for grep... already installed! :::    Checking for dnsutils... not installed! :::    Checking for whiptail... already installed! :::    Checking for net-tools... already installed! :::    Checking for bsdmainutils... already installed! :::    Checking for iptables-persistent... already installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.v4UQEpaILw: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                :::    Failed to install dnsutils! ubuntu@ubuntu:~$ sudo apt install dnsutils Reading package lists... Done Building dependency tree        Reading state information... Done The following NEW packages will be installed:   dnsutils 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded. Need to get 2752 B of archives. After this operation, 46.1 kB of additional disk space will be used. Get:1 http://ports.ubuntu.com/ubuntu-ports focal-updates/universe arm64 dnsutils all 1:9.16.1-0ubuntu2.4 [2752 B] Fetched 2752 B in 0s (26.0 kB/s)    Selecting previously unselected package dnsutils. (Reading database ... 106196 files and directories currently installed.) Preparing to unpack .../dnsutils_1%3a9.16.1-0ubuntu2.4_all.deb ... Unpacking dnsutils (1:9.16.1-0ubuntu2.4) ... Setting up dnsutils (1:9.16.1-0ubuntu2.4) ... ubuntu@ubuntu:~$ curl -L https://install.pivpn.io | bash   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                  Dload  Upload   Total   Spent    Left  Speed 100   162  100   162    0     0    993      0 --:--:-- --:--:-- --:--:--  1000 100 83088  100 83088    0     0   222k      0 --:--:-- --:--:-- --:--:--  222k ::: ::: sudo will be used for the install. ::: Hostname length OK ::: Verifying free disk space... ::: ::: Checking apt-get for upgraded packages.... done! ::: ::: Your system is up to date! Continuing with PiVPN installation... :::    Checking for git... already installed! :::    Checking for tar... already installed! :::    Checking for wget... already installed! :::    Checking for curl... already installed! :::    Checking for grep... already installed! :::    Checking for dnsutils... already installed! :::    Checking for whiptail... already installed! :::    Checking for net-tools... already installed! :::    Checking for bsdmainutils... already installed! :::    Checking for iptables-persistent... already installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.UQxNanszOg: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                ::: Using User: ubuntu ::: ::: Checking for existing base files... :::    Checking /usr/local/src/pivpn is a repo...:::    Cloning https://github.com/pivpn/pivpn.git into /usr/local/src/pivpn... done! ::: Using VPN: WireGuard ::: Installing WireGuard...  :::    Checking for wireguard-tools... already installed! :::    Checking for qrencode... not installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.OEuoxfCQ1c: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                :::    Failed to install qrencode! ubuntu@ubuntu:~$ sudo apt install qrencode Reading package lists... Done Building dependency tree        Reading state information... Done The following additional packages will be installed:   libqrencode4 The following NEW packages will be installed:   libqrencode4 qrencode 0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded. Need to get 46.1 kB of archives. After this operation, 129 kB of additional disk space will be used. Do you want to continue? [Y/n] Y Get:1 http://ports.ubuntu.com/ubuntu-ports focal/universe arm64 libqrencode4 arm64 4.0.2-2 [23.0 kB] Get:2 http://ports.ubuntu.com/ubuntu-ports focal/universe arm64 qrencode arm64 4.0.2-2 [23.1 kB] Fetched 46.1 kB in 0s (289 kB/s)    Selecting previously unselected package libqrencode4:arm64. (Reading database ... 106200 files and directories currently installed.) Preparing to unpack .../libqrencode4_4.0.2-2_arm64.deb ... Unpacking libqrencode4:arm64 (4.0.2-2) ... Selecting previously unselected package qrencode. Preparing to unpack .../qrencode_4.0.2-2_arm64.deb ... Unpacking qrencode (4.0.2-2) ... Setting up libqrencode4:arm64 (4.0.2-2) ... Setting up qrencode (4.0.2-2) ... Processing triggers for man-db (2.9.1-1) ... Processing triggers for libc-bin (2.31-0ubuntu9.1) ... ubuntu@ubuntu:~$ curl -L https://install.pivpn.io | bash   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                  Dload  Upload   Total   Spent    Left  Speed 100   162  100   162    0     0    936      0 --:--:-- --:--:-- --:--:--<PHONE_NUMBER>8  100 83088    0     0   173k      0 --:--:-- --:--:-- --:--:--  173k ::: ::: sudo will be used for the install. ::: Hostname length OK ::: Verifying free disk space... ::: ::: Checking apt-get for upgraded packages.... done! ::: ::: Your system is up to date! Continuing with PiVPN installation... :::    Checking for git... already installed! :::    Checking for tar... already installed! :::    Checking for wget... already installed! :::    Checking for curl... already installed! :::    Checking for grep... already installed! :::    Checking for dnsutils... already installed! :::    Checking for whiptail... already installed! :::    Checking for net-tools... already installed! :::    Checking for bsdmainutils... already installed! :::    Checking for iptables-persistent... already installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.QgrIcDgz3c: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                ::: Using User: ubuntu ::: ::: Checking for existing base files... :::    Checking /usr/local/src/pivpn is a repo... OK! :::     Updating repo in /usr/local/src/pivpn... done! ::: Using VPN: WireGuard ::: Installing WireGuard...  :::    Checking for wireguard-tools... already installed! :::    Checking for qrencode... already installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.9yD6h6aveG: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                ::: Using CloudFlare servers. ::: Adding additional reload job type for wg-quick unit ::: Backing up the wireguard folder to /etc/wireguard_2021-01-12-005727.tar.gz ::: Server Keys have been generated. ::: Server config generated. ::: Install Complete... ::: Restarting services... Job for<EMAIL_ADDRESS>failed because the control process exited with error code. See "systemctl status<EMAIL_ADDRESS>and "journalctl -xe" for details. :::    Checking for unattended-upgrades... already installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.YCpKllvrU8: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                ::: Setupfiles copied to /etc/pivpn/wireguard/setupVars.conf ::: Installing scripts to /opt/pivpn...  done. ::: Flushing writes to disk... ::: done. :::
Regards final errors, following:
Jan 13 00:57:34 ubuntu systemd-resolved[1625]: Server returned error NXDOMAIN, mitigating potential DNS violation DVE-2018-0001, retrying transaction with reduced feature level UDP. Jan 13 00:57:34 ubuntu systemd-resolved[1625]: Server returned error NXDOMAIN, mitigating potential DNS violation DVE-2018-0001, retrying transaction with reduced feature level UDP. Jan 13 00:57:34 ubuntu sudo[55388]:   ubuntu : TTY=pts/1 ; PWD=/home/ubuntu ; USER=root ; COMMAND=/usr/bin/systemctl status<EMAIL_ADDRESS>Jan 13 00:57:34 ubuntu sudo[55388]: pam_unix(sudo:session): session opened for user root by ubuntu(uid=0) Jan 13 00:57:34 ubuntu sudo[55388]: pam_unix(sudo:session): session closed for user root
Jan 12 00:57:33 ubuntu systemd[1]: Starting WireGuard via wg-quick(8) for wg0... Jan 12 00:57:33 ubuntu wg-quick[49356]: wg-quick: wg0' already exists
Jan 12 00:57:33 ubuntu systemd[1]<EMAIL_ADDRESS>Main process exited, code=exited, status=1/FAILURE
Jan 12 00:57:33 ubuntu systemd[1]<EMAIL_ADDRESS>Failed with result 'exit-code'.
Jan 12 00:57:33 ubuntu systemd[1]: Failed to start WireGuard via wg-quick(8) for wg0.
Jan 12 09:54:02 ubuntu systemd[1]<EMAIL_ADDRESS>Unit cannot be reloaded because it is inactive.
Jan 12 09:56:11 ubuntu systemd[1]<EMAIL_ADDRESS>Unit cannot be reloaded because it is inactive.`

Found the details from a previous session I had saved. Including here in case relevant (can't sort formatting, sorry)
ubuntu@ubuntu:~$ sudo apt update && sudo apt upgrade && curl -L https://install.pivpn.io | bash Hit:1 http://ports.ubuntu.com/ubuntu-ports focal InRelease Hit:2 http://ports.ubuntu.com/ubuntu-ports focal-updates InRelease                     Hit:3 http://ports.ubuntu.com/ubuntu-ports focal-backports InRelease                                                    Hit:4 http://ports.ubuntu.com/ubuntu-ports focal-security InRelease                                                     Hit:5 https://download.docker.com/linux/ubuntu focal InRelease                                    Ign:6 https://ookla.bintray.com/debian generic InRelease                                          Get:7 https://ookla.bintray.com/debian generic Release [4389 B] Fetched 4389 B in 2s (1995 B/s) Reading package lists... Done Building dependency tree        Reading state information... Done All packages are up to date. Reading package lists... Done Building dependency tree        Reading state information... Done Calculating upgrade... Done 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                  Dload  Upload   Total   Spent    Left  Speed 100   162  100   162    0     0   1012      0 --:--:-- --:--:-- --:--:--  1012 100 83088  100 83088    0     0   221k      0 --:--:-- --:--:-- --:--:--  221k ::: ::: sudo will be used for the install. ::: Hostname length OK ::: Verifying free disk space... ::: ::: Checking apt-get for upgraded packages.... done! ::: ::: Your system is up to date! Continuing with PiVPN installation... :::    Checking for git... already installed! :::    Checking for tar... already installed! :::    Checking for wget... already installed! :::    Checking for curl... already installed! :::    Checking for grep... already installed! :::    Checking for dnsutils... not installed! :::    Checking for whiptail... already installed! :::    Checking for net-tools... already installed! :::    Checking for bsdmainutils... already installed! :::    Checking for iptables-persistent... already installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.v4UQEpaILw: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                :::    Failed to install dnsutils! ubuntu@ubuntu:~$ sudo apt install dnsutils Reading package lists... Done Building dependency tree        Reading state information... Done The following NEW packages will be installed:   dnsutils 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded. Need to get 2752 B of archives. After this operation, 46.1 kB of additional disk space will be used. Get:1 http://ports.ubuntu.com/ubuntu-ports focal-updates/universe arm64 dnsutils all 1:9.16.1-0ubuntu2.4 [2752 B] Fetched 2752 B in 0s (26.0 kB/s)    Selecting previously unselected package dnsutils. (Reading database ... 106196 files and directories currently installed.) Preparing to unpack .../dnsutils_1%3a9.16.1-0ubuntu2.4_all.deb ... Unpacking dnsutils (1:9.16.1-0ubuntu2.4) ... Setting up dnsutils (1:9.16.1-0ubuntu2.4) ... ubuntu@ubuntu:~$ curl -L https://install.pivpn.io | bash   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                  Dload  Upload   Total   Spent    Left  Speed 100   162  100   162    0     0    993      0 --:--:-- --:--:-- --:--:--  1000 100 83088  100 83088    0     0   222k      0 --:--:-- --:--:-- --:--:--  222k ::: ::: sudo will be used for the install. ::: Hostname length OK ::: Verifying free disk space... ::: ::: Checking apt-get for upgraded packages.... done! ::: ::: Your system is up to date! Continuing with PiVPN installation... :::    Checking for git... already installed! :::    Checking for tar... already installed! :::    Checking for wget... already installed! :::    Checking for curl... already installed! :::    Checking for grep... already installed! :::    Checking for dnsutils... already installed! :::    Checking for whiptail... already installed! :::    Checking for net-tools... already installed! :::    Checking for bsdmainutils... already installed! :::    Checking for iptables-persistent... already installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.UQxNanszOg: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                ::: Using User: ubuntu ::: ::: Checking for existing base files... :::    Checking /usr/local/src/pivpn is a repo...:::    Cloning https://github.com/pivpn/pivpn.git into /usr/local/src/pivpn... done! ::: Using VPN: WireGuard ::: Installing WireGuard...  :::    Checking for wireguard-tools... already installed! :::    Checking for qrencode... not installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.OEuoxfCQ1c: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                :::    Failed to install qrencode! ubuntu@ubuntu:~$ sudo apt install qrencode Reading package lists... Done Building dependency tree        Reading state information... Done The following additional packages will be installed:   libqrencode4 The following NEW packages will be installed:   libqrencode4 qrencode 0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded. Need to get 46.1 kB of archives. After this operation, 129 kB of additional disk space will be used. Do you want to continue? [Y/n] Y Get:1 http://ports.ubuntu.com/ubuntu-ports focal/universe arm64 libqrencode4 arm64 4.0.2-2 [23.0 kB] Get:2 http://ports.ubuntu.com/ubuntu-ports focal/universe arm64 qrencode arm64 4.0.2-2 [23.1 kB] Fetched 46.1 kB in 0s (289 kB/s)    Selecting previously unselected package libqrencode4:arm64. (Reading database ... 106200 files and directories currently installed.) Preparing to unpack .../libqrencode4_4.0.2-2_arm64.deb ... Unpacking libqrencode4:arm64 (4.0.2-2) ... Selecting previously unselected package qrencode. Preparing to unpack .../qrencode_4.0.2-2_arm64.deb ... Unpacking qrencode (4.0.2-2) ... Setting up libqrencode4:arm64 (4.0.2-2) ... Setting up qrencode (4.0.2-2) ... Processing triggers for man-db (2.9.1-1) ... Processing triggers for libc-bin (2.31-0ubuntu9.1) ... ubuntu@ubuntu:~$ curl -L https://install.pivpn.io | bash   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                  Dload  Upload   Total   Spent    Left  Speed 100   162  100   162    0     0    936      0 --:--:-- --:--:-- --:--:--<PHONE_NUMBER>8  100 83088    0     0   173k      0 --:--:-- --:--:-- --:--:--  173k ::: ::: sudo will be used for the install. ::: Hostname length OK ::: Verifying free disk space... ::: ::: Checking apt-get for upgraded packages.... done! ::: ::: Your system is up to date! Continuing with PiVPN installation... :::    Checking for git... already installed! :::    Checking for tar... already installed! :::    Checking for wget... already installed! :::    Checking for curl... already installed! :::    Checking for grep... already installed! :::    Checking for dnsutils... already installed! :::    Checking for whiptail... already installed! :::    Checking for net-tools... already installed! :::    Checking for bsdmainutils... already installed! :::    Checking for iptables-persistent... already installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.QgrIcDgz3c: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                ::: Using User: ubuntu ::: ::: Checking for existing base files... :::    Checking /usr/local/src/pivpn is a repo... OK! :::     Updating repo in /usr/local/src/pivpn... done! ::: Using VPN: WireGuard ::: Installing WireGuard...  :::    Checking for wireguard-tools... already installed! :::    Checking for qrencode... already installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.9yD6h6aveG: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                ::: Using CloudFlare servers. ::: Adding additional reload job type for wg-quick unit ::: Backing up the wireguard folder to /etc/wireguard_2021-01-12-005727.tar.gz ::: Server Keys have been generated. ::: Server config generated. ::: Install Complete... ::: Restarting services... Job for<EMAIL_ADDRESS>failed because the control process exited with error code. See "systemctl status<EMAIL_ADDRESS>and "journalctl -xe" for details. :::    Checking for unattended-upgrades... already installed! /usr/bin/debconf-apt-progress: can't open /tmp/tmp.YCpKllvrU8: Permission denied at /usr/bin/debconf-apt-progress line 249, <STDIN> line 3.                                                                                ::: Setupfiles copied to /etc/pivpn/wireguard/setupVars.conf ::: Installing scripts to /opt/pivpn...  done. ::: Flushing writes to disk... ::: done. :::
Regards final errors, following:
Jan 13 00:57:34 ubuntu systemd-resolved[1625]: Server returned error NXDOMAIN, mitigating potential DNS violation DVE-2018-0001, retrying transaction with reduced feature level UDP. Jan 13 00:57:34 ubuntu systemd-resolved[1625]: Server returned error NXDOMAIN, mitigating potential DNS violation DVE-2018-0001, retrying transaction with reduced feature level UDP. Jan 13 00:57:34 ubuntu sudo[55388]:   ubuntu : TTY=pts/1 ; PWD=/home/ubuntu ; USER=root ; COMMAND=/usr/bin/systemctl status<EMAIL_ADDRESS>Jan 13 00:57:34 ubuntu sudo[55388]: pam_unix(sudo:session): session opened for user root by ubuntu(uid=0) Jan 13 00:57:34 ubuntu sudo[55388]: pam_unix(sudo:session): session closed for user root
Jan 12 00:57:33 ubuntu systemd[1]: Starting WireGuard via wg-quick(8) for wg0... Jan 12 00:57:33 ubuntu wg-quick[49356]: wg-quick: wg0' already exists
Jan 12 00:57:33 ubuntu systemd[1]<EMAIL_ADDRESS>Main process exited, code=exited, status=1/FAILURE
Jan 12 00:57:33 ubuntu systemd[1]<EMAIL_ADDRESS>Failed with result 'exit-code'.
Jan 12 00:57:33 ubuntu systemd[1]: Failed to start WireGuard via wg-quick(8) for wg0.
Jan 12 09:54:02 ubuntu systemd[1]<EMAIL_ADDRESS>Unit cannot be reloaded because it is inactive.
Jan 12 09:56:11 ubuntu systemd[1]<EMAIL_ADDRESS>Unit cannot be reloaded because it is inactive.`

edited your comment and formated it .. was really painful to look at it :D

edited your comment and formated it .. was really painful to look at it :D

Fixed, Merged into master: https://github.com/pivpn/pivpn/commit/b5ec995f68fbae2eb30b50e1b6a4350f96316f2e

Fixed, Merged into master: https://github.com/pivpn/pivpn/commit/b5ec995f68fbae2eb30b50e1b6a4350f96316f2e


HasQueryFilter not working from Entity Framework Core 3.0 Preview 6

I have updated a project (blazor server side using EF Core 3) from preview 5 to preview 6. Since then,  my QueryFilters are not working any more.
My database context are registered as transcient.
The code is has follows:
private void SetQueryFilter(ModelBuilder modelBuilder)
        {
            modelBuilder.Entity<Contact>().HasQueryFilter(c => !c.Deleted && c.TenantId == _tenantId);
}

The SetQueryFilter is called from OnModelCreating. _tenantId is set in the ctor.
The methods also seems to be called only once.

And yes, my code was working correctly using Entity Framework Core 3.0 Preview 5

Duplicate of #15264

@tallichet First, many thanks for trying preview 6. We really appreciate people trying the previews and filing issues on what they find.
If you haven't seen it already, there is some good information in the preview announcement post about the changes that are happening to LINQ queries for EF Core 3.0. Preview 6 is the first release containing these changes, which means we are both expecting things to be broken, but at the same time very grateful for everyone who tries the release and generated feedback.
Support for query filters was not completed for preview 6. Closing this as a duplicate of #15264


Add emphasisFocus option

What problem does this feature solve?
It will emphasize all items that are focused on. Not only the hovered item. It will be useful in scenarios like only display connected links when a node is emphasized in the graph.
What does the proposed API look like?
emphasis: {
  focus: 'adjacency',
  emphasisFocus: true
}

Is there any progress on this?

请问有点击的相关配置吗 我现在需要点击显示同样的功能


Add Permission Checks to PrisonerLocationView

This makes sure that only users beloging to the PrisonerLocationAdmin group can access the PrisonerLocation API.

@SteveMarshall @ibrechin review/merge pls?

:+1:
@ibrechin?

Looks good.


Initiate Russian l10n team

This issue is to initiate a new l10n Team
Please only use this template for submitting a new l10n team initiation requests.
See https://github.com/cncf/glossary/blob/main/LOCALIZATION.md for basic requirements for a new l10n team.

(1) The language and language code for l10n
Find localization's two-letter language code from ISO 639-1 standard.

Language name: Russian
Language two-letter code: ru

(2) List of volunteers
Name and GitHub Username for each l10n volunteer. Add [A] to make them approvers.

[A] @shurup
[A] @kirkonru
@tym83

(Note) Next actions from maintainers

Create a new development branch for the l10n. (ex: dev-ko)
Update codeowners to add l10n contents approvers.
Add a new label for the language.

Hi @shurup
Could you invite more contributors for Runssian l10n? (especially, additional contributor who can approve localized content)
I think 3~4 approvers are good number as starting members.
It is because if one of approvers open a PR, the PR can not be merged naturally since the development branch has merge protection(condition). (Author of PR cannot approve the PR. At least two approving reviews)

Your label: https://github.com/cncf/glossary/labels/lang%2Fru
Your dev branch: dev-ru
:)

Hi @seokho-son! Thank you!
Regarding your question: thank you for this important point. Do you think adding @tym83 to our approvers' list will do the trick now (as a fast solution)? We'll be happy to wait for more people to join, but it might take a while.

Hi @shurup
We need approvers who understand and capable of managing branches. I just added two suggested approver candidates.
In the meantime, I will help merging PRs for Russian localization if needed. Please call me in the comment if additional approval is needed. :)

Hi @seokho-son! Sounds excellent; thanks a lot!

@seokho-son while our initial PR is ready (#2468), we also want to make an announcement in the CNCF blog. We have almost finished its content (in Google Docs). How should we proceed with it?

@shurup I guess we can close this issue since there are enough members are working on. :)


Prevent drag & drop of specific components

Need an option to prevent drag & dropping of specific components.
Ex. TileBelowTheFoldContent component (Part of expandable tiles), should not be allowed to be dragged/dropped outside of expandable tile.
In some scenarios, it might be better to display a notification instead of completely preventing them from dragging and dropping the component.

This should be possible to do now with d7adaae and d9fc829
See 98a6c35 and 3a38e0f for examples.
cc @Akshat55


Allow minitoc (toc per chapter)

It would be nice be able to genarate a mini-toc for each chapter. It's very useful when we are going to share separated chapters of a book on a Learning course.
I have used it in the past with asciidoc and dblatex. Here's an example: analise-e-projeto-sistemas-livro-v0.7.0.pdf
I had to customize the template of the generation: latex/computacao.sty
I was inspired by the debian-handbook minitoc. Here's a seach of minitoc on its repository

minitoc package
old issue about it

This is extremely challenging with this PDF generator (Prawn). In fact, we still haven't even managed yet to be able to move the full toc around. The problem is that the toc needs to know the pages and reference object of the target when it is written, but those don't come until after the toc. So it's necessary to reserve space for the toc, then come back and write the toc once you have that information. (And it gets even more complex if the toc needs to be on its own page). So while I agree it would be nice, I don't see myself having time to work on this. But if someone wants to figure it out, I encourage that person to do so.

was there any progress with it or is it still complicated in PDFs?

We can now move the toc around, but this remains fairly complicated (because creating a TOC is not easy). You are free to extend the converter and try to add it yourself. I probably won't work on adding this to the converter otherwise. It's not something I really want to spend time on.

fair enough, i'll try looking into it (no promises though)

Here's an absurdly simple implementation of this using an extended converter:
class MyPdfConverter < (Asciidoctor::Converter.for 'pdf')
  register_for 'pdf'

  def convert_section sect, opts = {}
    result = super
    if (toc_extent = sect.attr 'pdf-toc-extent')
      float do
        inscribe_toc sect, 3, toc_extent.from.page, toc_extent.from.cursor, 1
      end
    end
    result
  end

  def inscribe_chapter_title sect, title, opts
    super
    theme_font :base do
      old_toc_extent = @toc_extent
      sect.set_attr 'pdf-toc-extent', (allocate_toc sect, 3, cursor, false)
      @toc_extent = old_toc_extent
    end
  end
end

If we could figure out how to express from AsciiDoc when to enable this functionality, we might be able to put this into this converter. I'm looking for proposals.

We could do something like chapter-toc and chapter-toclevels:
= Document Title
:chapter-toc:
:chapter-toclevels: 2

...

Here's how that would look:
class MyPdfConverter < (Asciidoctor::Converter.for 'pdf')
  register_for 'pdf'

  def convert_section sect, opts = {}
    result = super
    if (toc_extent = sect.attr 'pdf-toc-extent')
      levels = (sect.document.attr 'chapter-toclevels', 1).to_i + 1
      page_numbering_offset = @index.start_page_number - 1
      float do
        inscribe_toc sect, levels, toc_extent.from.page, toc_extent.from.cursor, page_numbering_offset
      end
    end
    result
  end

  def inscribe_chapter_title sect, title, opts
    super
    if ((doc = sect.document).attr? 'chapter-toc') && (levels = (doc.attr 'chapter-toclevels', 1).to_i + 1) > 1
      old_toc_extent = @toc_extent
      theme_font :base do
        sect.set_attr 'pdf-toc-extent', (allocate_toc sect, levels, cursor, false)
      end
      @toc_extent = old_toc_extent
    end
  end
end

I have documented how to add a TOC per chapter using an extended converter. You can find the example code at the following location: https://github.com/asciidoctor/asciidoctor-pdf/blob/main/docs/modules/extend/examples/pdf-converter-chapter-toc.rb This example, as well as numerous others, will be included in the documentation for Asciidoctor PDF 2.0.0 when it is released.
Since the rules for where to insert a "minitoc" can vary widely, as well as how that TOC should appear, I think this is best left up to an extended converter. If many users are in agreement that this should become part of this converter, we always have the option of shipping the converter with this logic included.


"AZURE_SEARCH_QUERY_TYPE = vectorSimpleHybrid" not supported any more can causing the web app to not start

Describe the bug
I've redeployed from Git today as I wanted to stay up to date via the Deployment Center (Sync).
This appeared to run through fine but the web app is no longer working and showing an "Application Error".
Additional context
It appears that the following setting is no longer supported/working:
AZURE_SEARCH_QUERY_TYPE = vectorSimpleHybrid
and I need to change this to:
AZURE_SEARCH_QUERY_TYPE = vector_simple_hybrid
The readme still lists vectorsimplehybrid as a valid option and this would need to be updated.

Hi @ThoSt81 , thanks for reporting your issue.  I've just merged a change to allow camel case versions of the query types, since the Azure OpenAI Studio is still deploying apps with these values for now.
I've just tested that using the "Sync" option from the Deployment Center in the Azure Portal should solve the issue.  I'm going to close this issue for now, but feel free to reopen if you continue to see a problem.


Tarjan's Algorithm

Is your feature request related to a problem? Please describe.
Hi.. I am a participant at GSSOC'21.
I would like to contribute code for Tarjan's Algorithm for Strongly connected components, and important concepts like Articulation points and find the no. of bridges as applications for the same.
Do you want to work on it
I would like to contribute code in C++
Please assign me this issue.
Thanks!

Please assign it to me . @nakul-19 @raksha009 @plazzy99 @tarun26091999 @rish-singhal

Please assign this to me in Python

@plazzy99 my PR has been merged but the labels are not put so can you please mention the required labels

Please assign this to me in Java

@tarun26091999 please assign me


Overload manager doesn't exclude probes from stop_accepting_* actions

Title: Overload manager should exclude probes from stop_accept_ actions*
Description:
We are recently testing overload manager with istio. Our scenario is to overload the ingressgateway heap_size configured via sending requests from large number of concurrent connections, then we see stop_accepting_connections/requests actions triggered and new requests will fail.
But we found stop_accepting_connections(also stop_accepting_requests) stops the internal probes like liveness probe and readiness probe, which leads to the restart of the ingressgateway pod, which will causes issue for us.
We think it's reasonable to exclude the probes like liveness/readiness probe from overload manager stop_accepting_* actions, because new traffic will still fail and return users error 503 to indicate the overload, there seems to be no need to also stop internal probes.
Or we would like to know if it's intentionally to include probes into  stop_accepting_* actions, if so, why?
related topic https://github.com/envoyproxy/envoy/issues/21923

cc @KBaichoo

@caoyukun0430  I think this is an istio ingress gateway issue instead of envoy problem?
From my view, when overload manager stop_accepting_* actions are triggered, the istio ingress gateway readinessProbe would also be disabled, but livenessProbe should still work to avoid the pod is deleted by k8s.

@hobbytp it is a bit vague and could be also related to istio, issue raised. It would be nice to have opinions from both sides.
@KBaichoo would there be any possible improvement that envoy could do to improve the probes so that when overload manager is enabled, probes are excluded from being rejected? Thanks

This is reasonable, we can augment the action more broadly to either allow debug IP /  headers to decide whether the traffic should be rejected if there's some mechanism the probe traffic has to identify it; This would make sense in fully controlled environments or if there's a scrubbing proxy beforehand.

This is similar to https://github.com/envoyproxy/envoy/issues/20002
cc @nezdolik who might also be interested

Hi @KBaichoo thanks for the reply! As what we understand from Istio https://github.com/istio/istio/issues/41859#issuecomment-1308972468, the probe health checking logic on port 15021 first reach envoy then request to pilot-agent on port 15020 to get stats from envoy to see if started or not. But in overload condition, the first step, which is request to 15021 is rejected by overload action.
We want to propose that at least it would be reasonable to exclude port 15021 from stop_* overload actions so that health checking of ingressgateway will still work.
Furthermore, we would think it would be better that envoy can provide configurable port value to be excluded from overload stopping actions. The use case would be that when overload manager is configured on application pod sidecar, application could have its own health checking port/mechanism other than port 15021, then it would ask be rejected when action is triggered, but with the configurable excludePort for overload action, it could avoid the issue.

So far looks like the use case has been about letting in liveness probes to Envoy during overload.
To what @KBaichoo has already said, am thinking if we could be more flexible here in terms of configuration to accommodate for broader use cases.
The problem could be generalised to accept certain categories of traffic during overload state based on certain criteria.
Examples of criteria could be listener/port, cluster, cluster+route, combination of headers etc.

Hi @nezdolik  @KBaichoo is there any update here or is there any plan for some PR/fix for this one?

@caoyukun0430 at the moment no one is working on this issue. I may pick it up in couple of weeks unless someone else does. You are also welcome to submit a patch :)

Hi @nezdolik  is there any update, did you find some time maybe to work on this issue? Thanks

Go for it! I agree we want to keep an overloaded envoy to run as long as it can so it must pass the probes. If we crash/delete it too early, k8s cannot scale up fast enough.


⚠ Bofrost.es has degraded performance

In 1acee0c, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1902 ms

Resolved: Bofrost.es performance has improved in 2f1d6a1 after 8 minutes.


Embed input in output

The entire input I❤LA code should be embedded as a comment near the top of the compiled output. That would make the output replicable and translatable into other languages.

How about this way?

I like it.

On Nov 2, 2020, at 11:29 PM, pressureless<EMAIL_ADDRESS>wrote:
How about this way?
https://user-images.githubusercontent.com/8511053/97949890-0bb04000-1d63-11eb-85e1-969a7b731d90.png
https://user-images.githubusercontent.com/8511053/97949900-11a62100-1d63-11eb-92d6-16ec2c798927.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/pressureless/linear_algebra/issues/25#issuecomment-720898340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACC7XQQLPJS3GB6U7J4OATSN6BJVANCNFSM4THIQEJQ.


how can envoy be configured so as not to remove x-envoy-max-retries header

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: how can envoy be configured so as not to remove x-envoy-max-retries header
Description:

Can envoy be configured so as not to remove the x-envoy-max-retries header when forwarding requests?

[optional Relevant Links:]

Any extra documentation required to understand the issue.

I assume you mean for incoming traffic? Right now Envoy will sanitize headers that are of external origin, so it may not be possible to do what you want: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_conn_man/header_sanitizing


Make records chan so ProcessRecords doesn't block on nil chan

Make the *gokini.Records channel so we don't have a zero value (nil) channel created by NewKinesisBalanced. When fetching records from Kinesis they were getting sent to a nil channel in ProcessRecords. This blocks.

Thanks @avdempsey, looks good.


Fix decorator metadata references to type-only-imported namespaces

Fixes #42624

@andrewbranch thanks so much for this! This has been an issue for me in a pretty large-scale application and has prevented me using import type to prevent errors. Any clue what version of TS this is going to be released in?

4.4.2 (RC), along with nightlies starting tonight.


Outline View not updated when adding or removing items

Type: Bug
The Outline View is not updated when adding or removing functions (methods, classes...). The only "workaround" I'm aware of is to close and re-launch VSCode.
The problem manifests itself with Python files. I didn't try it with other languages.
The following is my configuration. However, the problem has been confirmed also on my colleague's computer.
 Another workaround I discovered where you don't have to close and re-open VS Code is to leave Explorer view and go to any other view, e.g. Search. Then go back to Explorer view and the outline will be updated. I automated this jumping back and forth with a keyboard shortcut.

Dear Rich - I've tried it again today, and it works (as of VSCode 1.81.1 and PyLance v2023.8.50).
@kimjansheden - can you try it?

Thanks for verifying. I'll close now.

I've tried it again today, and it works (as of VSCode 1.81.1 and PyLance v2023.8.50). Confirmed also with my colleague who had the same problem.
@kimjansheden - can you try it?

@pslizik-ibl I can also confirm that it works now, thank you for notifying me!

I'd like to reopen this as it has been a VERY annoying problem for me for some time now, and it still persists. I'm assuming it's due to Pylance, but not 100% sure. Regardless, having to close and reopen VSCode to get the outline back for a python file is extremely annoying. Worse, when the outline is dysfunctional, all code folding is dysfunctional as well.
Version: 1.86.0 (Universal)
Commit: 05047486b6df5eb8d44b2ecd70ea3bdf775fd937
Date: 2024-01-31T10:29:15.765Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 21.6.0

Sounds good.


Add Freelance Rate Calculator

Description
Freelance Rate Calculator: To calculate hourly or project rates for freelancers.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

Proceed @mahek0620

@Rakesh9100 kindly review and also add labels


creation of non-expiring access tokens does not work

Describe the bug
When I try to create a non-expiring token, the terraform provider will create an expiring token for me instead (it will call the API without the expires_in specified, which for our artifactory instance will by default create an expiring token).
The terraform snippet:
resource "artifactory_access_token" "my-jfrog-user" {
  username          = "my-jfrog-user"
  end_date_relative = "0s" # no expiry
  groups            = ["my-jfrog-group"]
}

The reason is because, the terraform provider has set the omitempty here: https://github.com/jfrog/terraform-provider-artifactory/blob/c82d69838f08cdd119eb07496aa8a8732abae733/pkg/artifactory/resource_artifactory_access_token.go#L39
This means that, when we run tokenOptions through query.Values, it will omit the expires_in from the API request call: https://github.com/jfrog/terraform-provider-artifactory/blob/c82d69838f08cdd119eb07496aa8a8732abae733/pkg/artifactory/resource_artifactory_access_token.go#L205
Obtained corroboration by adding:
	<...snip...>
	values, err := query.Values(tokenOptions)
	if err != nil {
		return err
	}

        log.Println("-----WCS-----")
        log.Println("TOKENOPTS")
        log.Printf("%+v\n", tokenOptions)
        log.Println("-----WCS-----")

        log.Println("-----WCS-----")
        log.Println("VALUES")
        log.Printf("%+v\n", values)
        log.Println("-----WCS-----")

        resp, err := m.(*resty.Client).R().
		SetHeader("Content-Type", "application/x-www-form-urlencoded").
		SetResult(&accessToken).
		SetFormDataFromValues(values).Post("artifactory/api/security/token")
	<...snip...>

and getting:
2021-09-20T15:32:12.620+0100 [INFO]  provider.terraform-provider-artifactory: 2021/09/20 15:32:12 -----WCS-----: timestamp=2021-09-20T15:32:12.616+0100
2021-09-20T15:32:12.620+0100 [INFO]  provider.terraform-provider-artifactory: 2021/09/20 15:32:12 TOKENOPTS: timestamp=2021-09-20T15:32:12.616+0100
2021-09-20T15:32:12.620+0100 [INFO]  provider.terraform-provider-artifactory: 2021/09/20 15:32:12 {GrantType:client_credentials Username:my-jfrog-user Scope:member-of-groups:"my-jfrog-group" ExpiresIn:0 Refreshable:false Audience:}: timestamp=2021-09-20T15:32:12.616+0100
2021-09-20T15:32:12.620+0100 [INFO]  provider.terraform-provider-artifactory: 2021/09/20 15:32:12 -----WCS-----: timestamp=2021-09-20T15:32:12.616+0100
2021-09-20T15:32:12.620+0100 [INFO]  provider.terraform-provider-artifactory: 2021/09/20 15:32:12 -----WCS-----: timestamp=2021-09-20T15:32:12.616+0100
2021-09-20T15:32:12.620+0100 [INFO]  provider.terraform-provider-artifactory: 2021/09/20 15:32:12 VALUES: timestamp=2021-09-20T15:32:12.616+0100
2021-09-20T15:32:12.620+0100 [INFO]  provider.terraform-provider-artifactory: 2021/09/20 15:32:12 map[grant_type:[client_credentials] refreshable:[false] scope:[member-of-groups:"my-jfrog-group"] username:[my-jfrog-user]]: timestamp=2021-09-20T15:32:12.616+0100
2021-09-20T15:32:12.620+0100 [INFO]  provider.terraform-provider-artifactory: 2021/09/20 15:32:12 -----WCS-----: timestamp=2021-09-20T15:32:12.616+0100

Requirements for and issue

[x] A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue)
[x] Artifactory version: 7.25.6
[x] terraform version: 1.0.5

Expected behavior
A non-expiring token to be created.
Additional context

I'll take a stab at this.

I've made a PR: https://github.com/jfrog/terraform-provider-artifactory/pull/144/files
Let me know how that looks to you, thanks.

I'll assume this matter closed


feat: support renamed Rekordbox application directory

The user can now specify the directory name of the Rekordbox application directory. This supports multiple Rekordbox installations of the same major version.

Codecov Report

Merging #96 (dadbe5e) into master (02d8d9e) will decrease coverage by 1.67%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

:exclamation: Current head dadbe5e differs from pull request most recent head 7e966e2. Consider uploading reports for the commit 7e966e2 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   89.44%   87.78%   -1.67%
==========================================
  Files          15       15
  Lines        2663     2308     -355
==========================================
- Hits         2382     2026     -356
- Misses        281      282       +1

see 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


0.5.0 not published to rubygems.org?

I see this repo has 0.5.0 released, but on https://rubygems.org/gems/rwr-redux only 0.4.0 is available.
Maybe you forgot to push the gem after the release?

Yeah, I'm trying to get credentials to publish, but owner is on leave.. Will fix asap ;)


lots of warning in the build

full warning messages:
WARNING: undefined CSS custom media alias "--sm-viewport" at 9:1 in node_modules/suitcss-utils-offset/node_modules/suitcss-utils-after/lib/after-sm.css.
The rule has been removed from the output. Please check your @custom-media definitions.
WARNING: undefined CSS custom media alias "--md-viewport" at 9:1 in node_modules/suitcss-utils-offset/node_modules/suitcss-utils-after/lib/after-md.css.
The rule has been removed from the output. Please check your @custom-media definitions.
WARNING: undefined CSS custom media alias "--lg-viewport" at 9:1 in node_modules/suitcss-utils-offset/node_modules/suitcss-utils-after/lib/after-lg.css.
The rule has been removed from the output. Please check your @custom-media definitions.
WARNING: undefined CSS custom media alias "--sm-viewport" at 9:1 in node_modules/suitcss-utils-offset/node_modules/suitcss-utils-before/lib/before-sm.css.
The rule has been removed from the output. Please check your @custom-media definitions.
WARNING: undefined CSS custom media alias "--md-viewport" at 9:1 in node_modules/suitcss-utils-offset/node_modules/suitcss-utils-before/lib/before-md.css.
The rule has been removed from the output. Please check your @custom-media definitions.
WARNING: undefined CSS custom media alias "--lg-viewport" at 9:1 in node_modules/suitcss-utils-offset/node_modules/suitcss-utils-before/lib/before-lg.css.
The rule has been removed from the output. Please check your @custom-media definitions.
WARNING: undefined CSS custom media alias "--sm-viewport" at 5:1 in node_modules/suitcss-utils-size/lib/size-sm.css.
The rule has been removed from the output. Please check your @custom-media definitions.
WARNING: undefined CSS custom media alias "--md-viewport" at 5:1 in node_modules/suitcss-utils-size/lib/size-md.css.
The rule has been removed from the output. Please check your @custom-media definitions.
WARNING: undefined CSS custom media alias "--lg-viewport" at 5:1 in node_modules/suitcss-utils-size/lib/size-lg.css.
The rule has been removed from the output. Please check your @custom-media definitions.

You'll need to define your custom media query sizes - https://github.com/suitcss/theme/blob/master/lib/theme.css#L12-L14


J493 sound card support (Apple M2)

I check my sound card details in /sys/firmware/devicetree/base/sound:
root@fedora:/sys/firmware/devicetree/base/sound# find . -type f -exec xxd -c 24 {} \;
00000000: 4d61 6342 6f6f 6b20 5072 6f20 4a34 3933 00                   MacBook Pro J493.
00000000: 0000 00bf 0000 0000 0000 00bf 0000 0001                      ................
00000000: 6370 7500                                                    cpu.
00000000: 0000 00c0 0000 00c1 0000 00c2 0000 00c3                      ................
00000000: 636f 6465 6300                                               codec.
00000000: 5370 6561 6b65 7273 00                                       Speakers.
00000000: 6461 692d 6c69 6e6b 00                                       dai-link.
00000000: 6170 706c 652c 6a34 3933 2d6d 6163 6175 6469 6f00 6170 706c  apple,j493-macaudio.appl
00000018: 652c 6d61 6361 7564 696f 00                                  e,macaudio.
00000000: 736f 756e 6400                                               sound.
00000000: 0000 00bf 0000 0002                                          ........
00000000: 6370 7500                                                    cpu.
00000000: 0000 00c4                                                    ....
00000000: 636f 6465 6300                                               codec.
00000000: 4865 6164 7068 6f6e 6520 4a61 636b 00                        Headphone Jack.
00000000: 6461 692d 6c69 6e6b 00                                       dai-link.
root@fedora:/sys/firmware/devicetree/base/sound#

My sound card detected as: MacBook Pro J493 and currently use native driver dai-link
I installed latest AsahiLinux (gnome), all worked very good and very fast, but sound worked very bad...
I find this repository for build driver and install now, but not see config for j493... :-(
Please add config for my sound card in tree...
Thank you very much! You best of the best, really Fedora worked very very good!!!
P.S. Sorry for my bad English, I from Ukraine...

This repo has nothing to do with the driver/kernel, and everything there looks fine. J493 is supported, as denoted in the Makefile. Since your machine is the same as J293, we just alias that config in the Makefile.
Could you elaborate on what you mean when you say the sound is bad? Fedora Asahi Remix should install all the required support packages by default.

This repo has nothing to do with the driver/kernel, and everything there looks fine. J493 is supported, as denoted in the Makefile. Since your machine is the same as J293, we just alias that config in the Makefile.
Could you elaborate on what you mean when you say the sound is bad? Fedora Asahi Remix should install all the required support packages by default.

I installed latest fedora (gnome version) and sound in my M2 mac book pro is very bad... How to fix this? How to build latest kernel/installer with latest patches?

If you're using GNOME this could be related to a known issue with libgvc where it doesn't respect the permissions we set in WirePlumber.
Could you please make sure that you are using the output called "MacBook Air J493 Speakers" and not the one called "Built-in Speakers"

If you're using GNOME this could be related to a known issue with libgvc where it doesn't respect the permissions we set in WirePlumber.
Could you please make sure that you are using the output called "MacBook Air J493 Speakers" and not the one called "Built-in Speakers"

vovkapoc@fedora:~$ alsactl info
#
# Sound card
#
- card: 0
  id: AppleJ493
  name: MacBook Pro J493
  longname: MacBook Pro J493
  driver_name: macaudio
  mixer_name:
  components:
  controls_count: 47
  pcm:
    - stream: PLAYBACK
      devices:
        - device: 0
          id: Primary (*)
          name:
          subdevices:
            - subdevice: 0
              name: subdevice #0
        - device: 1
          id: Secondary (*)
          name:
          subdevices:
            - subdevice: 0
              name: subdevice #0
    - stream: CAPTURE
      devices:
        - device: 0
          id: Primary (*)
          name:
          subdevices:
            - subdevice: 0
              name: subdevice #0
        - device: 2
          id: Speaker Sense (*)
          name:
          subdevices:
            - subdevice: 0
              name: subdevice #0
alsactl: rawmidi_device_list:105: snd_ctl_rawmidi_next_device

This configuration for my sound card is good? Sound really bad quality. How to fix this with alsactl or another terminal commands?

That doesn't help me. This repo and the DSP has nothing to do with the kernel. Your kernel settings are fine. You need to check GNOME settings and see what audio output is selected. It needs to be "MacBook Pro J493 Speakers" and not "Built-in Speakers".
Note that we do not - and will not - ALSA direct to the ASoC device.

Feel free to reopen if you actually find something actionable


Typo with word user

Typo:
Sentence: "The current version of the SDK doesn't support interactive uer authentication on .NET Core. If required, use AAD username/password or application authentication instead."
Word: uer
Should be: user

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ae82ebd2-f7f6-5068-54f2-69c7532b6b38
Version Independent ID: 4727dbed-4e17-879b-d494-6ee62d78633a
Content: Ingest data with Azure Data Explorer .NET SDK
Content Source: data-explorer/net-sdk-ingest-data.md
Service: data-explorer
GitHub Login: @shsagir
Microsoft Alias: shsagir

@jeremylcarter Thank you for sharing feedback. We are actively validating it. We will share updates soon.

@jeremylcarter Thanks for your feedback. We've submitted a documentation change based on your suggestion, and the updated article should be live by tomorrow. Please let us know if there's anything more we can do for you. To follow up on this issue, leave us a comment with an @mention.
#please-close


Internal API accessible to GitHub Copilot Extension Only

Hi,
https://github.com/microsoft/vscode/issues/85682#issuecomment-1619671015 mentions that GitHub Copilot uses some internal API that is unavailable to other extensions. This gives an unfair advantage to GitHub Copilot.  Is this fair (and legal) from the anti-trust perspective?
Thanks

@jrieken


Add a hint that for IE11 support object assign polyfill is needed

Object.assign seems not be supported by IE11 and currently I see no workaround without jquery for this. I personally would avoid to add the polyfill to this repository as not all user maybe need it.

ping @wachterjohannes


Admin Dashboard for this stack

Hi, I am looking at using this stack for a new project. I have used Django in the past and one of the most useful aspects is the automatic admin dashboard.
Are their recommended admin dashboards for this stack or suggested options?

I don't currently have one, I haven't used one myself, but that is normally coupled with the database and ORM, so you might probably try to find an admin dashboard for SQLAlchemy.
I built SQLModel to integrate it with this project, but I haven't had the time to finish it. But that's the plan. And I know there are already admin UIs for SQLModel too.

Sorry for the long delay! 🙈  I wanted to personally address each issue/PR and they piled up through time, but now I'm checking each one in order.


Shader Pack control mod?

Hi its me again :D is possbile to also select shaderspack? it might be easy to do idk much but minecraft uses the same system right
.. for fabric

Hmm I mean I would have to look into it. But at first I'm thinking it's tricky. I don't think the shader packs are done in the same way as resource packs, even though they seem similar. But it might not be that hard, so it's something to look into I guess


hide YouTube #shorts needs an update due to updated way of showing shorts in feeds

What filter does this issue target?
https://letsblock.it/filters/youtube-shorts
What changes should be made?
instead of a length counter, there's now a YT shorts logo which prevents the filter from working

Did you write a uBlock filter solving this?
No response
Additional notes
No response

Thanks for reporting this @h3oCharles
I worked on supporting this new layout in https://github.com/xvello/letsblockit/pull/94 but they might have changed the markup since. Could you please force a refresh or your filters first, to make sure you have the latest version?
I am currently away from home and will be back next weekend. If a refresh does not help, you might want to check comments on this reddit post for updated rules.
Please keep me uodated!

i don't have "letsblock.it - My filters" in custom, I've been pasting all filter lists in "My filters"

Okay, please try copying the new version from https://letsblock.it/filters/youtube-shorts then, as I updated it recently for the redesign.
This is the use case I designed the account system for: if you use the custom list system, we can ship updated filters easily when websites are updated.

that seems to work. description might need updating to indicate hiding vids with the shorts logo

Happy to know it's working!
I will close this issue, and update the description next week.


PDF Document does not display text correctly when rendered in pdf.js

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: Mozilla any version
Operating system and its version: Any Os, Tested on windows
PDF.js version: 4.0.379
Is a browser extension:

Steps to reproduce the problem:

Open the Attached PDF in https://mozilla.github.io/pdf.js/web/viewer.html
We see broken text in rendered document

What is the expected behavior? (add screenshot)
Text should be displayed correctly
What went wrong? (add screenshot)
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

Document1.pdf

It's a regression from #12259.
The font (which is symbolic) used to render the data has 3 cmap tables: 0,3; 1,0 and 3,1.
We don't select the correct table (i.e. 3,1) but selecting the 0,3 one is fine.

@calixteman Thank you for your quick response. We will wait for the issue to be fixed.


[Need Help] Category explode list.

Right now im populating my forum with categories
Backend (pretty neat):

What I want to do is have the categories split with the "," that way it's listed. This is what i have as the code:
@foreach ($subcategory->subcategories as $subcat)
    route !!}" title="{!! $subcat->title !!}">{!! $subcat->title !!}
@endforeach

That basically grabs the subcategory's subcategory (this can go on forever but i only needed one more nested level) to look like this:

the problem i'm having is making each category split with the comma. I tried using Explode but i get an error every time.

I suggestion would be to use CSS, rather than HTML.
The example is from memory, since I don't remember which project I used this in:
.subcat-link:after {
content: ",";
}
.subcat-link:last-child:after {
content: "";
}

thanks, that works:
@foreach ($subcategory->subcategories as $subcat)
    route !!}" title="{!! $subcat->title !!}">{!! $subcat->title !!}
@endforeach

Yeah, I use the CSS approach for that as well. Slightly more succinct rule would be:
.subcat-link:not(.subcat-link:last-child):after {
    content: ", ";
}

the next feature im trying to work on is profile cards when hovering on names <_<

I have a generic "AJAX cards" implementation in one of my projects, so I might be able to help with that. Though please open a separate issue if you want to go into that :P


Using robocorp.workitems fails in odd ways

Current state
I'm trying to output a single file and hitting unexpected problems.

To produce output I need to open workitem.inputs. This seems like irrelevant boilerplate code.
To get the solution running locally I seem to need to do something. I can not find what that something is.
When that something fails I get:

❯ rcc run
...
'Missing required environment variable: RC_WORKSPACE_ID'
==================== Full Traceback (running library_docs) =====================
Traceback (most recent call last):
  File "/Users/Shared/robocorp/ht/336e074_5a1fac3_9fcd2534/lib/python3.9/site-packages/robocorp/tasks/_commands.py", line 226, in run
    task.run()
  File "/Users/Shared/robocorp/ht/336e074_5a1fac3_9fcd2534/lib/python3.9/site-packages/robocorp/tasks/_task.py", line 30, in run
    self.method()
  File "/Users/.../tasks.py", line 194, in library_docs
    for _ in workitems.inputs:
  File "/Users/Shared/robocorp/ht/336e074_5a1fac3_9fcd2534/lib/python3.9/site-packages/robocorp/workitems/__init__.py", line 73, in __iter__
    if self.current and not self.current.released:
  File "/Users/Shared/robocorp/ht/336e074_5a1fac3_9fcd2534/lib/python3.9/site-packages/robocorp/workitems/__init__.py", line 87, in current
    return _ctx().current_input
  File "/Users/Shared/robocorp/ht/336e074_5a1fac3_9fcd2534/lib/python3.9/site-packages/robocorp/tasks/_lifecycle.py", line 19, in new_func
    cache.append(next(iter_in))
  File "/Users/Shared/robocorp/ht/336e074_5a1fac3_9fcd2534/lib/python3.9/site-packages/robocorp/workitems/__init__.py", line 35, in __ctx
    ctx.reserve_input()
  File "/Users/Shared/robocorp/ht/336e074_5a1fac3_9fcd2534/lib/python3.9/site-packages/robocorp/workitems/_context.py", line 71, in reserve_input
    item_id = self.adapter.reserve_input()
  File "/Users/Shared/robocorp/ht/336e074_5a1fac3_9fcd2534/lib/python3.9/site-packages/robocorp/workitems/_context.py", line 40, in adapter
    self._adapter = self._adapter_class()
  File "/Users/Shared/robocorp/ht/336e074_5a1fac3_9fcd2534/lib/python3.9/site-packages/robocorp/workitems/_adapters.py", line 90, in __init__
    self._workspace_id: str = required_env("RC_WORKSPACE_ID")
  File "/Users/Shared/robocorp/ht/336e074_5a1fac3_9fcd2534/lib/python3.9/site-packages/robocorp/workitems/_utils.py", line 24, in required_env
    raise KeyError(f"Missing required environment variable: {name}")
KeyError: 'Missing required environment variable: RC_WORKSPACE_ID'

What would be expected

workitems.inputs should not be needed to create outputs.
I should get clear instruction when I fail to either how to fix the problem or otherwise where to find the information.
RC_WORKSPACE_ID seems to be something that blocks the actual problem..

Regarding RC_WORKSPACE_ID, I agree, the error message could be better (this will be the same thing for vault and assets probably).
The docs on the vault (https://github.com/robocorp/robo/blob/master/vault/docs/guides/local-development.md) do note about it, so, maybe saying that the workspace is not linked as RC_WORKSPACE_ID is not set env and point to the documentation?
I also noted that the related page saying about VSCode (https://robocorp.com/docs/developer-tools/visual-studio-code/extension-features#connecting-to-control-room-vault) is outdated now (the action name is now Robocorp: Link to Control Room -- as the same setting is used for workitems, vault and assets. Ping @MonicaBarna to note that it needs to be updated).

For workitems the linking doesn't work though, so, maybe point to something as: https://github.com/robocorp/robo/blob/master/workitems/docs/guides/local-development.md.
i.e.: users need to set RC_WORKITEM_INPUT_PATH, RC_WORKITEM_OUTPUT_PATH and RC_WORKITEM_ADAPTER when not using VSCode.

@mkorpela, you are trying to use these libraries using plain rcc without VSCode + our extension, right? That also affects what the dev workflow should be. It is documented to some degree in the library readme, but I agree that the error should be better.
I'll take a look at the dev workflow and think it again in light of our current offering. Much has changed since it was initially done in RPAFW.
I don't quite understand what you mean by having to "open workitems.inputs", though. You can iterate the entire queue (it's preferred, really), but it's also possible to just use the default reserved one. I'll improve that in the docs as well.


Make the promptlayer_api_call run in the background

Right now we wait for the call to be completed, but we dont even do anything with the response (other than warn if there was an issue), we should be doing this in the background to speed things up.
I am thinking we do some simple python threading, create a thread that runs the process in the background, and then immediately return the openAI request

@Jped the network call itself is dependent on the network call to OpenAI and since this is the last I/O bound call in the process, I think we cannot optimize this in the background. We could hack and call it in a daemon thread but that won't guarantee it's execution because

Even if we do this in a thread, any remaining threads block the current execution and since this is the last network call in the process, it will still block and yield no results in optimization.

Hmm I hear, lets revisit this another way then.


Compatibility with React v15

The package.json requires<EMAIL_ADDRESS>Is there anything blocking from using a more recent version of react?

I am running it with version 15 and besides a warning where I am not sure if its coming this plugin I do not have any issues. Can you please publish a version that marks it as ok for v15. I can't use shrinkwrap at the moment since I have a unmet peer dependency

@fkrauthan - have you tested it in Safari? I'm getting an error with<EMAIL_ADDRESS>

@brettdewoody I am running react 15.1.0. And tested with Chrome and Safari and Firefox

I don't know if it's related, but I get:
ReactFitText.js:45 Uncaught TypeError: Cannot set property 'fontSize' of undefined
With React 15.2.1

Sent a pull Request as no error reported with react 15 and up. #18

Version 1.0.0 with React 15 support released!


Kernel panic when boot.initrd.compressorArgs = [ "-9" ]; for "lz4" compressor

Describe the bug
When setting boot.initrd.compressorArgs = [ "-9" ]; and running nixos-rebuild ..., the next boot kernel panics with "invalid magic at start of compressed". This only happens when setting a compressorArgs, removing/commenting the line, and rebuilding boots fine.
Steps To Reproduce
Steps to reproduce the behavior:

Add following to configuration.nix:

boot.initrd.compressor = "lz4";
boot.initrd.compressorArgs = [ "-9" ];

Run nixos-rebuild switch
Reboot system -> kernel panic

Expected behavior
Expected kernel to decompress image and run fine.
Screenshots
[    0.323514] Initramfs unpacking failed: invalid magic at start of compressed
archive
[    0.336174] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0)
[    0.336188] CPU: 3 PID: 1 Comm: swapper/0 Not tainted 6.1.58 #1-NixOS
[    0.336199] Hardware name: Dell Inc. Inspiron 14 5410 2-in-1/0TPG56, BIOS 2.21.0 08/11/2023
[    0.336209] Call Trace:
[    0.336216]  <TASK>
[    0.336223]  dump_stack_lvl+0x44/0x5c
[    0.336233]  panic+0x118/0x2de
[    0.336243]  mount_block_root+0x1d3/0x1e6
[    0.336253]  prepare_namespace+0x136/0x165
[    0.336261]  kernel_init_freeable+0x21d/0x228
[    0.336269]  ? rest_init+0xd0/0xd0
[    0.336277]  kernel_init+0x16/0x130
[    0.336284]  ret_from_fork+0x1f/0x30
[    0.336294]  </TASK>
[    0.336304] Kernel Offset: 0x30a00000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
[    0.336318] ---[end Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) ]---

Notify maintainers
@Artturin
Metadata
Obviously can't run from a kernel-panicked system, so here's metadata from the previous working generation (only difference is commenting out compressorArgs)
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.58, NixOS, 23.11 (Tapir), 23.11pre537656.7c9cc5a6e5d3`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.17.1`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

you need boot.initrd.compressorArgs = [ "-l" "-9" ];

See https://github.com/NixOS/nixpkgs/blob/14fbf575ecd47451dc1b2b3122f56ce8ac670030/pkgs/build-support/kernel/initrd-compressor-meta.nix for the defaults.
I guess the documentation could be clearer that some of the default arguments are required to make it boot..

Ah yeah, that would definitely be nice ^

Adding better compression to the lz4 flags (and possibly to other compressors) would be good

Compression level, with # being any value from 1 to 12. Higher values trade compression speed for compression ratio. Values above 12 are considered the same as 12. Recommended values are 1 for fast compression (default), and 9 for high compression. Speed/compression trade-off will vary depending on data to compress. Decompression speed remains fast at all settings.

For lz4 the decompression speed remains the same(ish)

I'm planning a PR to add a warning note to the configuration documentation regarding how certain flags are necessary defaults for correct behaviour, but I wanted to get some advice:

Does it make sense for nixpkgs to enforce flag correctness? Not in totality, but for trivial compressors like lz4 where it is known ahead-of-time that -l is a necessary flag. Should it make sense to add an assertion or a warning, or should that be left for the user to determine?
Should we have an internal "essentialArgs" that contains the bare minimum defaults on top of the already existing defaultArgs and boot.initrd.compressorArgs? I think that can get a little confusing, but it was another idea I had.

Either way wanted to take more opinions about this before making a PR. I'd rather do it right once so this becomes a non-issue going forward.


Add split amount annotation

To the side of the split time, there should be a little (perhaps separate font?) number that counts the amount of times stored for a split.  This lets us know:

the runner had multiple times for the split (eg, they died or reset the level);
zombiesplit successfully committed those times (the only visual feedback if someone uses, eg, l to commit a time without advancing).

Fixed a while back.


Career testimonials pages

Create the right section text (that supports images with caption via autoblock) for Career Testimonials Pages.
Also import all career testimonial pages.

All career testimonial pages have been completed.


Update rebar in skel dir to 2.6.0

The old one will cause compilation errors for new CB projects based on master.

What kind of errors?

With Erlang/OTP 18.0 & rebar 2.5.1:
> make
./rebar get-deps
...
==> my_project_name (get-deps)
./rebar compile
==> goldrush (pre_compile)
==> goldrush (compile)
ERROR: /private/tmp/my_project_name/deps/goldrush/.rebar/erlcinfo file version is incompatible. expected: 1 got: 2
ERROR: compile failed while processing /private/tmp/my_project_name/deps/goldrush: rebar_abort
make: *** [compile] Error 1

I had same problems after updating to 2.6.0
so this issue need some additional investigation.

@danikp hmm that's weird as I can't reproduce it with my env. The rebar version I've used for this is a copy of yours from the CB root. Can you reproduce this error for example with the sample project I've shared with https://github.com/ChicagoBoss/ChicagoBoss/issues/594#issuecomment-133649253? I've used the same env as in #594.

I got same problem here
https://travis-ci.org/danikp/erlang_iso8601/builds/75153391 and here
https://travis-ci.org/danikp/erlang_iso8601/builds/74874015
And in few other projects. rebar binary working on my system, but produce errors on Travis

I can propose to run 'make rebar_src' as part of 'make all'. It will download and compile rebar with version specified in Makefile prior to running anything else.

I'm not sure if the make rebar_src will fix the problem as this looks like a platform specific bug to me. Maybe we should create a ticket in the rebar project directly and see what this turns out.

superseded by #620


VS Version

Hi,
As noted for the windows install, this requries 'x64 Native Tools Command Prompt for VS 2017'
However, the only free version of VS is VS Community 2019. Can ganspace work for this version?

Managed to solve this!


Fix GA params

'services' needs to be defined at the top-level.

@Ladicle , @guangrui-cloudnatix , both of you should be able to access https://analytics.google.com/analytics/web/provision/?authuser=1#/p461878719/reports/intelligenthome to see the stats. Please let me know if you see any issues!


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-27-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3570

Questions ?
Please refer to the Backport tool documentation