Add generic to parent parameter in visitor callback

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
Parent should be superset of Child

First of all I think this library should stay in sync with its parent (ha!), unist-util-visit-parents, so this change should also be there.
Furthermore, this should be smarter! As we’re already inferring which children exist in tree, and filter against that with test, could we also figure out which nodes are potential ancestors of those children?
https://github.com/syntax-tree/unist-util-visit-parents/blob/be4b7a920fe10e9c23157a2a4aeb9693d3d0a11d/complex-types.d.ts#L6
I can imagine this being quite hard to figure out though, but it would be very useful!

Furthermore, this should be smarter! As we’re already inferring which children exist in tree, and filter against that with test, could we also figure out which nodes are potential ancestors of those children?

I think this is fairly doable, but it requires some type-fu.
I think the check should be the other way around:
The parent type can be similar to InclusiveDescendant, but instead of checking type, it checks children[number],type. Then the child of type can be based on the parent type.

First of all I think this library should stay in sync with its parent (ha!), unist-util-visit-parents, so this change should also be there.

Punny! :smile:
Jokes aside, I doubt if this is possible for unist-util-visit-parents, whereas I’m pretty sure it is possible for unist-util-visit. This is because for unist-util-visit just the parent would need to be determined, but for unist-util-visit-parents the entire ancestry. I fear that if this would be possible, it would really impact performance. I would love to be proven wrong though.
As for the current implementation I agree with @ChristianMurphy.


Will Sift install on Ubuntu 17.10.1

Will Sift install on Ubuntu 17.10.1 ?

Unfortunately no. SIFT only supports 16.04 LTS. Work for 18.04 LTS is underway.
Sent from my iPhone

On Jun 9, 2018, at 15:42, Ben<EMAIL_ADDRESS>wrote:
Will Sift install on Ubuntu 17.10.1 ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


adds a shell:run action using the bash container image

:heavy_check_mark: Checklist

[x] Added tests for new functionality and regression tests for bug fixes
[ ] Screenshots of before and after attached (for UI changes)
[ ] Added or updated documentation (if applicable)

Here is what it looks like:

I think we should map out the security implications of this before merging


Fixes to CI-Configs

Travis:

PHP 5.3 is no longer readily avaible, so adjusted inclusion

Appsurveyor

PHP is no longer installed in the expected directory by default, so adjusted installation

Cool, thanks  👍


Add option to have final B-Locker be your max set amount

https://github.com/2dos/DK64-Randomizer/pull/487


WIP: OpenTracing Instrumentation

This was a good early PoC, but I am going to close this in favor of doing it as part of https://github.com/nre-learning/syringe/pull/141 (currently underway).


Update msvc_compatibility.h

Remove old msvc macro definitions

This only affects MSVC builds, but should remove the need for an #undefine in nucleus code


[Feature Request] Setting to not show in-game backup broadcast message

Have you read the Important information text above

[X] Yes i did

Describe the feature
I would like a way to disable this.
I have edited the script in the past then also mounted it via volume - ./backupmanager.sh:/backupmanager.sh but with the latest changes and it moving to the /scripts directory, I just figured a setting to just not have it broadcast in the .env file would be a better option.
Additional information

[ ] Would you be willing to help implement this feature?

Final checks

[X] I understand that this is a feature request function. I also understand that if i use this to report a bug report, that my issue might be un-answered closed.

Hey @Krojack - That setting already exists, its called RCON_ENABLED

I thought that turned the entire rcon system on or off. I still use rcon at the command line for other things as well such as the ShowUsers.

So what you actually asking for is a feature-toggle to not broadcast anything while the server makes backups or saves?
How would the user know on when to expect maybe lag or robberbanding?

So what you actually asking for is a feature-toggle to not broadcast anything while the server makes backups or saves? How would the user know on when to expect maybe lag or robberbanding?

I think the OP does not consider it necessary to alert the user in this case.
From a personal perspective, I haven't had any lag or rubberbanding as a result of the background job running, it's very quick (but my instance is running on NVMe SSDs).

I think the OP does not consider it necessary to alert the user in this case.
From a personal perspective, I haven't had any lag or rubberbanding as a result of the background job running, it's very quick (but my instance is running on NVMe SSDs).

SSD is only part of the calculation, CPU and RAM Speed matter too, we had also rubberbanding with busy or old and slow (GHz) CPUs reportet or even very slow DDR4 (2133MHz, forgot to turn on XMP) RAM.

Yeah I haven't experienced any lag or anything while the backup is running. I wasn't even aware it was a problem as it was so fast and smooth.
With 5-6 players my CPU averages around 10%. I even mount the /palworld/backups directly to a directory on my NAS so the backups are saved there rather than local.
For now this is my docker volumes setup:
    volumes:
      - ./game-data:/palworld
      - ./steam-logs:/home/steam/Steam/logs
      - /mnt/nas_backups/GameServer/palworld/backups:/palworld/backups
      - ./backupmanager.sh:/scripts/backupmanager.sh

I'm able to just comment out the parts of the backup script which is fine, I just though an option to not show the in-game backup alerts would be a nice option people can set in the .env file.


Displaying not correct dates.

Hey :)
In my case, i live in germany (locale = 'de-DE'), i set up everything and is working, except for the displaying of the dates.
The first date is correct, but the second one is always not in the 24h-format ^^ For example it displays  4:00  insted of 16:00, which is really confusing...
I hope somebody can help me :)

What localizer are you using? Moment?

yes, moment

Fixed it thanks :)


Remove alias classes for Dictionary<string, object>

Proposed solution for #36

+1

Sorry for the delay!
I don't think we can simply remove the Traits/Properties etc types yet, since that would be a breaking API change. If you can refactor this into accepting both vanilla dictionaries and the old types, that'd be more acceptable!

@f2prateek Would you accept a separate PR that leaves in Dict and related types but makes the public Segment methods more permissive (i.e., accepting all IDictionary<string, object>s instead of the Dict types)?


String and Text are not isomorphic

> Data.Text.unpack (Data.Text.pack "\57326")
"\65533"

It would be nice to document this.

Wow. That's news to me. Thanks for reporting.
Do you have any reference for more details on this?

Addressed in <IP_ADDRESS>


running error

No file or variants found for asset: .env.

Please check the README.
You should rename .env.example to .env. Then create an account in Cryptowatch to get an API Key and add it to your .env file.


Pydantic Helper Functions Raise json.JSONDecodeError

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
The error handling docs provide that when an issue is encountered when validating data, a pydantic.ValidationError will be thrown.
However there are cases when a json.JSONDecodeError is thrown. I'm including an example below, ('True' is an invalid boolean in JSON; 'true' is valid).
Raising this issue to suggest that either the error be wrapped by a ValidationError or the docs be updated.
Thanks for the hard work!
Example Code
In [1]: import pydantic

In [2]: pydantic.parse_raw_as(bool, "true")
Out[2]: True

In [3]: pydantic.parse_raw_as(bool, "True")
---------------------------------------------------------------------------
JSONDecodeError                           Traceback (most recent call last)
Cell In [3], line 1
----> 1 pydantic.parse_raw_as(bool, "True")

File ~/.pyenv/versions/3.8.12/lib/python3.8/site-packages/pydantic/tools.py:74, in pydantic.tools.parse_raw_as()

File ~/.pyenv/versions/3.8.12/lib/python3.8/site-packages/pydantic/parse.py:37, in pydantic.parse.load_str_bytes()

File ~/.pyenv/versions/3.8.12/lib/python3.8/json/__init__.py:357, in loads(s, cls, object_hook, parse_float, parse_int, parse_constant, object_pairs_hook, **kw)
    352     del kw['encoding']
    354 if (cls is None and object_hook is None and
    355         parse_int is None and parse_float is None and
    356         parse_constant is None and object_pairs_hook is None and not kw):
--> 357     return _default_decoder.decode(s)
    358 if cls is None:
    359     cls = JSONDecoder

File ~/.pyenv/versions/3.8.12/lib/python3.8/json/decoder.py:337, in JSONDecoder.decode(self, s, _w)
    332 def decode(self, s, _w=WHITESPACE.match):
    333     """Return the Python representation of ``s`` (a ``str`` instance
    334     containing a JSON document).
    335
    336     """
--> 337     obj, end = self.raw_decode(s, idx=_w(s, 0).end())
    338     end = _w(s, end).end()
    339     if end != len(s):

File ~/.pyenv/versions/3.8.12/lib/python3.8/json/decoder.py:355, in JSONDecoder.raw_decode(self, s, idx)
    353     obj, end = self.scan_once(s, idx)
    354 except StopIteration as err:
--> 355     raise JSONDecodeError("Expecting value", s, err.value) from None
    356 return obj, end

JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Python, Pydantic & OS Version
pydantic version: 1.9.0
            pydantic compiled: True
                 install path: /Users/{username}/.pyenv/versions/3.8.12/lib/python3.8/site-packages/pydantic
               python version: 3.8.12 (default, Oct 17 2022, 16:48:14)  [Clang 13.1.6 (clang-13<IP_ADDRESS>.5)]
                     platform: macOS-12.6.2-arm64-arm-64bit
     optional deps. installed: ['typing-extensions']

Affected Components

[ ] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Digging into the implementation, it seems that parse_raw_as can return any of pydantic.ValidationError, json.JSONDecodeError, TypeError, RuntimeError

It's returning json.JSONDecodeError because it can't parse the value "True" to json. so the error happens in converting string to json not in validation or parsing.
You will get a pydantic.ValidationError if you parse a valid json like:
>>> pydantic.parse_raw_as(int, "{}")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/hasan/work/pydantic/pydantic/tools.py", line 82, in parse_raw_as
    return parse_obj_as(type_, obj, type_name=type_name)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/hasan/work/pydantic/pydantic/tools.py", line 38, in parse_obj_as
    return model_type(__root__=obj).__root__
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/hasan/work/pydantic/pydantic/main.py", line 342, in __init__
    raise validation_error
pydantic.error_wrappers.ValidationError: 1 validation error for ParsingModel[int]
__root__
  value is not a valid integer (type=type_error.integer)

I think we can close this issue because or wrap string conversion error with pydantic.ValidationError which is not good IMHO.
What do you think @samuelcolvin

This behavior though, is different than the behaviour with normal model fields. If you passTrueinto a bool or strictbool field within a model, the jsondecodeerror gets wrapped by ValidationError.
Would be good to keep the behaviour consistent.
For my usecase it's important to know which errors might be thrown so that they can be caught explicitly, ideally without simply catching Base exception.

This behavior though, is different than the behaviour with normal model fields. If you passTrueinto a bool or strictbool field within a model, the jsondecodeerror gets wrapped by ValidationError.

Are you sure that you get json.JSONDecodeError wrapped by pydantic.ValidationError? Could you provide an example?

Confirmed, thanks for reporting.
Question is whether fixing this in V1.10 would qualify as a breaking change? I think it might.
it'll definitely be fixed in V2 as all JSON parsing happens in pydantic-core, and parse_raw_as will be replaced by validate, see #4669.

Thanks @samuelcolvin — that's cool to hear about V2!
I think it would be good to update this in V1.10—anyone explicitly catching json.JSONDecodeError must also be catching ValidationError, so I wouldn't consider it a breaking change. It's significantly better to know which exceptions might be thrown—otherwise, you have to catch Exception everywhere, which isn't great practice.
Happy to provide the PR if you agree.

Thanks @dhruvrajan for clearing this up.
Agree with @samuelcolvin, it will be a breaking change in 1.10.x. Will be fixed in V2

All makes sense!—That's a good tip, I'll use ValueError then. Thanks for the help.
Looking forward to the V2 release! Feel free to close the issue.

It seems to me this issue has been resolved in v2 so I'm going to close this now. If you notice related issues in v2 we'd appreciate the reports!


I am colorblind and I have not realized it?

Is this Cyan? I see this green/teal
"Cyan/500": {
"$value": "#39baa4",
"$type": "color",
"$description": "oklch(70.51% 0.152 180)",
"$oklch": "oklch(0.705078 0.151562 180)",
"$srgbFallback": "#00b9a3",
"$isP3": true,
"$link": "https://oklch.com/#70.5078125,0.15156250000000002,180,100",
"$contrast": -54.31425190552922,
"$contrastBg": "black"
},

It has a 180 hue angle so it is somewhat right between green and blue. On my Samsung ViewFinity S8 S80PB UHD with DCI-P3 support, it does look more green than it does blue to me.
Comparing to the Tailwind palette i think it's fair to say this is indeed teal not cyan.
I'll say rotate it to above 194° makes a big difference. But let's see how the Harmony team thinks about this.
And no I don't think you are colorblind :laughing:


Details screen not working as in Android

There's some way I can find here a similar implementation of Android version in Examples?

no, this is only for iOS


added aditya agarwal in contributors

@itaditya, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

Your readme was very helpful, keep helping the first timers. I have also shared the issue with my peers they will be making PRs soon :)

@itaditya, Thank you for sharing
I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com

ok just a quick question, this PR will be counted for Hacktoberfest right, it's not like we have to make PRs after 1st October ?

I'm not sure about that. In the past, I've used this tool to track my pull requests
https://hacktoberfestchecker.herokuapp.com/?username=itaditya
When I give your id, I see that you've submitted 1 pull request. Then again this tool is not official.

Ok thanks


HHH-16957 Embeddable cannot have only one @generated field

https://hibernate.atlassian.net/browse/HHH-16957

closed in favour of https://github.com/hibernate/hibernate-orm/pull/9280


Do not use "return()"

This is more a stylistic advice.
In R, the last evaluated expression of a function gets returned by default - one does not need to use an explicit return unless one wants to enforce that the given expression would be the last evaluated one. E.g.:
mean_or_NULL <- function(x) {
  if (!is.numeric(x)) return(NULL)
  mean(x)
}

An explicit return has also (minimal) overhead.
So I would suggest to remove all unnecessary return() calls. I can do it if you wish.

Sounds good. Thanks!


[FEAT REQ.] - NAV TEXT GEOMAP

Describe the solution you'd like
An .xml output "NAVAID_TEXT_GEOMAP.xml" formatted like the attached file.
The text format:
(NAVAID ID) (NAVAID Name) (NAVAID Type)
NAVAID_TEXT_GEOMAP.txt

Added Version 0.7.1

Added Version 0.7.1


fix : lp-318 - persists language across pages

JIRA link
https://companieshouse.atlassian.net/browse/LP-318
Change description
persists language across pages
Work checklist

[ ] Tests added where applicable
[ ] UI changes look good on mobile
[ ] UI changes meet accessibility criteria

Merge instructions
We are committed to keeping commit history clean, consistent and linear.  A BREAKING CHANGE can be part of commits of any type,
types other than fix: and feat: are allowed, for example build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others,
footers other than BREAKING CHANGE: <description> may be provided.

CI: No security warnings found


Missing status responses for Twitter::Streaming::Client

There are a number of status messages that can be sent back from the Streaming API in addition to normal tweets/events, as defined by https://dev.twitter.com/streaming/overview/messages-types.
Currently it appears the only two supported are Twitter::Streaming::DeletedTweet and Twitter::Streaming::StallWarning.
Implementing all of these messages would be great, and some of them are quite important -- for example, LIMIT notices (different from stall warnings), or DISCONNECT messages that contain a reason.

hi @mroth I've added this to the list of streaming updates planned for version 6 of the gem, you can track these changes on #631 thanks!


Creating python 3.6 virtual environment

Default python versions are py27 and py35.
Any way to add py36 as well into DSVM (CentOS)? Tried to create new conda env but keeping throwing "dead kernel" error when starting the kernel in Jupyter Notebook. Does there any thing follow-up tasks need to be execute in order to use python 3.6 kernel?

@makcedward thanks for the comment. Is your question related to any specific Azure doc? If yes, please share the link.

@femila
I cannot find any Azure doc talking about installing different python kernel.

@femsulu I was tagged by mistake?


Fails to work with Raspbian Jessie

Works great with Raspbian Wheezy, but just tried the script with Jessie, and after installing gdisk, rsync & parted the script stops, & displays;
[fs create] Creating /dev/sda1
Error: Partition(s) on /dev/sda are being used.
The powered USB HDD has just one freshly formatted ext4 partition (no data), and has never been mounted on the Raspberry Pi before.
pi@raspberrypi ~ $ df -h
Filesystem      Size  Used Avail Use% Mounted on
/dev/root       7.0G  3.3G  3.4G  50% /
devtmpfs        214M     0  214M   0% /dev
tmpfs           218M     0  218M   0% /dev/shm
tmpfs           218M  4.6M  213M   3% /run
tmpfs           5.0M  4.0K  5.0M   1% /run/lock
tmpfs           218M     0  218M   0% /sys/fs/cgroup
/dev/mmcblk0p1   56M   20M   37M  36% /boot
tmpfs            44M     0   44M   0% /run/user/1000
/dev/sda1       932G   94M  932G   1% /media/pi/087F97566F198312
Paul

Thanks for the bug report - I used it recently with a fresh Jessie install and (somewhat to my surprise) it worked without any hitches, but I can well imagine that might not be the case for every system.
Actually, come to think of it, I'm pretty sure I know what the problem is - something in the desktop environment (which starts at boot now by default) is almost certainly auto-mounting the drive, and that's getting in the way of parted.  You could try sudo umount /dev/sda1 (and maybe, for good measure, exit out of the desktop so the filemanager isn't running).  I'll work up a little patch to handle this situation more gracefully.

Thanks for the quick reply.
I've just run $ sudo raspi-config and changed the boot option to command prompt instead of desktop, rebooted and your script now works fine!
Thanks
Paul

Right on - glad to hear it's working.  I'll leave this issue open 'til I get a new version of the package uploaded with at least a warning in it.

A minor issue, but once root has been successfully moved to the HDD:
$ readlink /dev/root
does not return a value as per the guide, yet:
$ ls -l /dev/disk/by-label
shows that the change has occured.
Paul

Hrm. I'll check what's changed there.

I'm using jessie, is it possible that it takes hours to complete this script on a 1TB drive?
the script is bussy for hours allready and stuck on this part: [fs create] Creating /dev/sda1
when I look at the code it is either exexcuting this:
parted --script "${target_drive}" mklabel gpt
ot this:
parted --script --align optimal "${target_drive}" mkpart primary ext4 0% 100%
is it possible the "--align optimal" part takes hours on a 1TB drive?

No, it shouldn't take that long. Are you sure that your'e not booting Jessie into dashboard rather than command prompt? If the dashboard loads it automounts the HDD, and halts the process.

My pi only boots to terminal, and I run the script through ssh, I don't use desktop on my pi

Also, I had the usb hdd allready formatted to ext-4 with a usb stick with G-Parted on a windows computer, so basicly the script is doing, what I allready did before...


fix: variablize server name

what

Variablize server name
Users can use their desired server name just need to add the name in user_defined_variable

why

To make it more dynamic

Terraform Security Scan Failed
Show Output

Terraform Security Scan Failed
Show Output


Missing Symbol finder icon when using Spyder 2 icon

Issue Report Checklist

[x] Searched the issues page for similar reports
[ ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[ ] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
There is no icon for "Symbol finder" when using the Spyder 2 icon theme. Maybe not a big issue, but maybe the lack of reports for this indicates that not that many people are using the Spyder 2 theme (re #3894)?

What is missing is a file called symbol_find.png as far as I can tell.
What steps reproduce the problem?

Use Spyder 2 icons

What is the expected output? What do you see instead?
Probably an icon would be nicer.
Versions

Spyder version: 4.0.0.dev0 and 3.3.4

The Spyder 2 icon theme is mainly used as a fallback when the Spyder 3 theme fails for one reason or another. I guess that's not the only icon missing, I'm sure there are a lot more.
You're welcome to fix this (if you want) because we don't have time for it right now.

I do not think we will be updating the Spyder2 theme anymore and suggest we remove it from Spyder 5. Closing @ccordoba12?

We really need a fallback theme in case there are problems loading web fonts. I'd say we could remove the Spyder 2 theme when we switch to the SVG based KDE theme in Spyder 5 or 6.


fix: use Kernel round instead of Float round

https://github.com/omisego/elixir-omg/issues/832
Overview
Kernel round instead of Float
Changes
Testing
Standard testing.

Coverage remained the same at 80.844% when pulling fb5e4fb55c15282057b3ac3d6de0f9287c4c7d52 on 832-tps_as_int into 38f47e67c24f9808ffe9962d130756b85730d6b6 on master.

I have no idea. It seemed less effort to just do it instead of figuring out why - but @jbunce can give some insight why he thinks it matters.

Because you can't have part of a transaction. It either happened or it didn't.

For the record, I think this:

you can't have part of a transaction. It either happened or it didn't.

has nothing to do with the TPS measure being integer or not. "tps":3937.23 doesn't imply you have 0.23 of a transaction.


Allow custom activity watchers

In my app (nexchange.co.uk), I use the watch_login decorator both on the request_sms endpoint as well as on the authenticate endpoint.
The solution I came to, is to set AXES_LOGIN_FAILURE_LIMIT to twice as much as priorly (6 instead of 2), however if one wants to use your lib to moderate and rate limit wide range of user triggered events, the proposed solution can be better.

Feel free to work on a PR, looks like a good idea.


space between function name and bracket

In C++, if there is a space between function name and bracket, then two brackets' color will be different.
Will it be solve or not

I managed to track down the exact problem. I've submitted a pull request to the language-c repo here:
https://github.com/atom/language-c/pull/62
tl;dr it's a stray question mark causing the pattern    ( to be matched (whitespace and parenthesis).

Awesome @jzhu98, keep up the good work ;)


Fixed another typo

Fixed another typo
row 128 Wrong markdown syntax

@OshotOkill Thanks for the contribution.
This looks great. Merging now. :shipit:


Fix imp UI

Summary
Offset fixed to place the virutal LED directly over the LED position of the device.
Checklist

[x] You agree with our CLA
[x] Included tests (or is not applicable).
[x] Updated documentation (or is not applicable).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 3 committers have signed the CLA.:white_check_mark: KochC:x: GitHub Actions:x: JoshuaWellbrockGitHub Actions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Not listed yet: www.thelocal.it

The website at this url is unlisted: https://www.thelocal.it/20151015/police-raid-vw-and-lamborghini-offices-in-italy

Thank you for the notification. This site is now added to the repository and will be in the next release on addons.mozilla.org.


Allow native button in localizeHTML.

The d2l-file-input component requires a special button rendered in the upload instruction. In order to facilitate localizing this text, we need to add native button to the allowed list.

I don't love this, but I can't think of a way around it. Also, I'm probably overthinking it. Just would be unfortunate to end up with lots of actual button-looking buttons in the middle of langterms.

Agreed. I initially began by adding support for d2l-button-subtle, then realized that this case is extra special.


pgctx: add RunInTxOptions

Codecov Report

Merging #19 (5c0c326) into master (cbcf63a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   78.21%   78.24%   +0.03%
==========================================
  Files          18       18
  Lines         707      708       +1
==========================================
+ Hits          553      554       +1
  Misses        137      137
  Partials       17       17

Impacted Files
Coverage Δ

pgctx/pgctx.go
95.23% <100.00%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbcf63a...5c0c326. Read the comment docs.

Codecov Report

Merging #19 (5c0c326) into master (cbcf63a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   78.21%   78.24%   +0.03%
==========================================
  Files          18       18
  Lines         707      708       +1
==========================================
+ Hits          553      554       +1
  Misses        137      137
  Partials       17       17

Impacted Files
Coverage Δ

pgctx/pgctx.go
95.23% <100.00%> (+0.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbcf63a...5c0c326. Read the comment docs.


scipy.signal.sepfir2d reads random memory when given even sized hrow or hcol

scipy.signal.sepfir2d reads random memory when given even sized hrow or hcol. Deep down in the source code for sepfir2 there is a comment than only odd-lengths are acceptable:
https://github.com/scipy/scipy/blob/d06791710acae119e099829087f8e1aedc4e1bd7/scipy/signal/S_bspline_util.c#L173
https://github.com/scipy/scipy/blob/d06791710acae119e099829087f8e1aedc4e1bd7/scipy/signal/D_bspline_util.c#L177
https://github.com/scipy/scipy/blob/d06791710acae119e099829087f8e1aedc4e1bd7/scipy/signal/C_bspline_util.c#L176
https://github.com/scipy/scipy/blob/d06791710acae119e099829087f8e1aedc4e1bd7/scipy/signal/Z_bspline_util.c#L173
However, this is not documented or enforced in sepfir2d.

Is this fixed by #12703?

The python interface shouldn't be able to trigger invalid reads memory any more. However, I don't think this should be closed until a signal expert comments on whether even length filters are fundamentally problematic, or if sepfir2d is being overly restrictive.

Even lengths are always avoidable by padding each of hrow and hcol with an extra 0. This doesn't change the output (except for maybe shifting all outputs by one place depending on if the 0 went at the front or back of the array) but does increase the amount of computation by a little bit (lots of multiplications by 0 and sums with 0).
That being said, even length filters do show up in a variety of places:

Haar wavelet filters are always a power-of-2 in length (and several other wavelet filters are as well)
The simple difference/derivative filter is length 2: [-1, 1] or [1, -1]
Robert's Cross filter is 2x2


Upload the manual for the technology preview

Accessing the manual and API description of the technology preview under https://www.neonious.com/TPManual now redirects to the more general documentation. Please provide the pdf or markdown (maybe with a deprecation notice) formerly available at that location, if you agree the docs for lowjs could already be incompatible.

Done, /TPManual now works again. Thank you for the hint..
BTW: I will look at your pull request in the next 2 days.


Batch request error when trying to delete one or many Parse objects

With a reverse proxy configuration, deleting one or many rows of Parse object throws an exception
Steps to reproduce

Select one or many rows to delete on Parse Dashboard
Click "Edit"
Click "Delete this / these row(s)"

This can also be reproduced doing the resulting batch request:
curl 'https://api.mydomain.com/batch' --data-binary '{"requests":[{"method":"DELETE","path":"/classes/<className>/<objectId>","body":{}}],"_ApplicationId":"<APPLICATION_ID>","_MasterKey":"<MASTER_KEY>"'
Expected Results
Object deleted / batch response 200 OK
Actual Outcome
Object NOT deleted / batch response 400 Bad Request
Environment Setup

Server

parse-dashboard version: 1.0.19
parse-server version: 2.2.24
Operating System: Ubuntu Server
Hardware: 1 Core CPU / 512MB RAM
Localhost or remote server?: Digital Ocean

Database

MongoDB version: 3.2.10
Storage engine: MongoRocks
Hardware: the same
Localhost or remote server?: Digital Ocean

Important: I use Nginx as a reverse proxy

Parse Dashboard: https://dashboard.mydomain.com --> http://localhost:4040/
Parse Server: https://api.mydomain.com --> http://localhost:1337/parse

Logs/Trace
The content of the response to the POST https://api.mydomain.com/batch request is the following: {"code":107,"error":"cannot route batch path /classes/<className>/<objectId>"}.
The value of some of the batch.js file variables are in my case:

apiPrefixLength=6
apiPrefix=/parse
req.originalUrl=/parse/batch
batchPath=/batch
restRequest.path=/classes/<className>/<objectId>

The exception is thrown because of restRequest.path.slice(0, apiPrefixLength) != apiPrefix (line 34).
When I manually modify the batch subrequest to change the path accordingly, it works as expected:
"requests": [
    {
        "method": "DELETE",
        "path": "/parse/classes/<className>/<objectId>",
        "body": {}
    }
]

Does the current batch.js implementation is supposed to work with a reverse proxy configuration?
If yes, do I have to set a particular option or an environment variable for Parse Server or Parse Dashboard?

What did you set as serverURL in your configuration?

Hey Florent! No serverURL and it doesn't seem to make any difference regarding the batch requests if I set one to the localhost URL (http://localhost:1337/parse).

Yeah, the issue is that your public server URL ( https://api.mydomain.com) doesn't 'need' a path to access the parse-server. Two options for you here in the meantime:

make parse-server available on https://api.mydomain.com/parse instead of /
make the local server listen on '/' so you have https://api.mydomain.com/ -> http://localhost:1337/

We'll see if we can apply a clean fix for that.

Thanks Florent. I had those 2 possibilities in mind as well.
Are the serverURL or publicServerURL config options not supposed to be used for such internal requests?

publicServerURL is when you need to send email, or generate links for the files.
serverURL is for internal calls. What you have now, is problematic as the paths don't match between the public and the private.

I chose option number 2 as temporary solution and no surprises, batch requests are now working well in Parse Dashboard.
serverURL is not crystal clear for me. What is considered as internal calls?
Does it take a default value because this is not a requirement according to the readme? On the other hand, in the ParseServer.js file, we're supposed to supply a value:
serverURL = requiredParameter('You must provide a serverURL!'),

serverURL is not crystal clear for me.

Is used for communication between cloud code and parse-server, this provides the loopback as cloud code is using HTTP to communicate with parse-server, and is not making direct calls in the code.

In your case, providing serverURL and publicServerURL won't help much as, serverURL would be:
http://localhost:1337/parse and publicServerURL would behttps://api.mydomain.com.
The dashboard is generating the batch request with paths as building a request to https://api.mydomain.com, we could use the publicServerURL if set, in order to see what URL we should route to, but that seems dangerous.


Please tag versions on git

Can you please add the versions in git as tags? This really helps out to see quickly changes and all from version to version

Hi Fale, yeah I can do that. Honestly haven't used them before, but I've been meaning to learn them anyway. :) I'll see if I can do by tomorrow evening.
In the meantime, I have a changelog that records everything in text: https://github.com/Ceasar/staticjinja/blob/master/CHANGELOG.rst

to tag a commit you need to do the following:
# checkout the commit that you want to tag
git checkout COMMIT-ID
# create the tag
git tag TAG-NAME
# push the tag to github
git push origin TAG-NAME

Thanks for that info. I tagged the latest four versions.


attempt 2

I canceled my last pull request and made sure I had the newest repo and then applied the following patches. 00_load.t now checks for all necessary CPAN deps with 'make test' or 'prove --lib'.
I changed the binmode calls because perlcritic was throwing a security warning. From perldoc -f binmode:
":utf8" just marks the data as UTF-8 without further checking, while ":encoding(utf8)" checks the data for actually being valid UTF-8.

I'm going to wait for Monsieur to look at this one. I honestly have no idea how CPAN works.


Add current timestamp to the metadata section of the modeled-clades .json

Background
The variant nowcast script creates the weekly .json file in clades_to_model adds a metadata section to the file to help track the provenence and ensure reproducibility. Example: https://github.com/reichlab/variant-nowcast-hub/blob/main/auxiliary-data/modeled-clades/2024-11-13.json#L12
One item missing from metadata is the timestamp (UTC) of when the .json file was created.
Definition of done

[ ] The metadata section of the weekly clades_to_model .json files should contain a top-level created_at key with the timestamp of the GitHub workflow run that created it.
[ ] Backfill existing clades_to_model with created_at, using the timestamps from their corresponding GitHub workflow runs.

Putting this one "in progress," since we'll be updating the "round open" process any (per the outcome of #202).


Web component: Leadspace Super - On Mobile, Bread crumb must be aligned same line.

Detailed description
Issue:
Leadspace Super - On Mobile, Bread crumb must be aligned same line. Here the bread crumb text is small but still wrapped to next line.
Additional information

@Praveen-sr I've couldn't find this issue happening on the latest version.
Can you please share the link you used along with the resolution you found the bug on?
Thank you!

@RaphaelAmadeu Re tested this on web component, above issue is fixed now.

Closing based on Praveen's comments above.


Dialogue system: add the ability to set portraits of characters

Cutscenes now support this, so we need to see how to reuse it.


Make IdcsMtRoleMapperProvider more flexible

Problem Description
Currently, IDCS id and IDCS App id can be only acquired from the headers. However, there are situations where the headers are not present and some more custom logic is required.
In our case, we stopped the propagation of these headers in service-to-service calls and would like to extract the same information from JWT.

PR: https://github.com/oracle/helidon/pull/761


Delete the Headway.RazorAdmin project

Headway.RazorAdmin has been deleted and replaced by dynamic config driven pages and components in Headway.Razor.Components.


Test example not working on VPN

I have cloned the repo from github and carried out the installation instructions (i.e., pip install --editable /Users/rzinke/Tools/isofit/ --use-feature=2020-resolver).
I am now trying to run a quickstart example using MODTRAN 6.0. I cd to examples/20171108_Pasadena/, and run ./run_example_modtran.sh
When I do this, however, I get the following error message.
Configuration file checks complete, no errors found.
Automatically increasing RLIMIT_NOFILE to max value of<PHONE_NUMBER>854775807
Failed to raise limit.
File descriptor limit 256 is too low for production servers and may result in connection errors. At least 8192 is recommended. --- Fix with 'ulimit -n 8192'
Traceback (most recent call last):
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/redis/connection.py", line 559, in connect
    sock = self._connect()
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/redis/connection.py", line 615, in _connect
    raise err
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/redis/connection.py", line 603, in _connect
    sock.connect(socket_address)
TimeoutError: [Errno 60] Operation timed out

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/rzinke/opt/miniconda3/envs/isofit/bin/isofit", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/Users/rzinke/Tools/isofit/bin/isofit", line 54, in <module>
    main()
  File "/Users/rzinke/Tools/isofit/bin/isofit", line 47, in main
    isofit = Isofit(config_file=config, level=level, row_column=row_column)
  File "/Users/rzinke/Tools/isofit/isofit/core/isofit.py", line 96, in __init__
    ray.init(**rayargs)
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/ray/_private/client_mode_hook.py", line 47, in wrapper
    return func(*args, **kwargs)
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/ray/worker.py", line 718, in init
    ray_params=ray_params)
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/ray/node.py", line 220, in __init__
    self.start_head_processes()
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/ray/node.py", line 827, in start_head_processes
    self.start_redis()
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/ray/node.py", line 642, in start_redis
    fate_share=self.kernel_fate_share)
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/ray/_private/services.py", line 852, in start_redis
    primary_redis_client.set("NumRedisShards", str(num_redis_shards))
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/redis/client.py", line 1801, in set
    return self.execute_command('SET', *pieces)
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/redis/client.py", line 898, in execute_command
    conn = self.connection or pool.get_connection(command_name, **options)
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/redis/connection.py", line 1192, in get_connection
    connection.connect()
  File "/Users/rzinke/opt/miniconda3/envs/isofit/lib/python3.7/site-packages/redis/connection.py", line 563, in connect
    raise ConnectionError(self._error_message(e))
redis.exceptions.ConnectionError: Error 60 connecting to <IP_ADDRESS>:6379. Operation timed out.
./run_example_modtran.sh: line 13: 71658 Terminated: 15          isofit --level DEBUG configs/ang20171108t184227_beckmanlawn-undersmoothed.json

Closing this out, as it seems to be resolved!  Please re-open as needed.


Introduce batch operations

Allow multiple items to be marked and then deleted/emptied in a batch.

Oh I like this!
Even better if the delete operation can be parallelized, ie go to the lowest directory and delete them in parallel and move its way up.

Is this addressed by the "space   Mark file or directory for deletion" key in the ? help?
Looks like that was added in #193 in Dec 2022, so maybe addresses this?

Yes, this use case was already implemented in #193.
More will come in 5.28: background deletion https://github.com/dundee/gdu/issues/293 and deletion in parallel https://github.com/dundee/gdu/issues/285


No manifest.json file present

Could you commit?

There is one here, is that sufficient for you?

My bad, thanks!


[Branch-2.9][Cherry-pick] fix bug: fail to expose managed ledger client stats to prometheus if bookkeeperClientExposeStatsToPrometheus is true

Cherry-pick   #16219
Motivation
It failed to expose bookkeeper client managed ledger stats to prometheus if setting bookkeeperClientExposeStatsToPrometheus=true in ServiceConfiguration. Because creating BkClient ignore the StatsLogger and use the NullStatsLogger.INSTANCE as default.
//class: org.apache.pulsar.broker.BookKeeperClientFactoryImpl
    @Override
    public BookKeeper create(ServiceConfiguration conf, ZooKeeper zkClient, EventLoopGroup eventLoopGroup,
                             Optional<Class<? extends EnsemblePlacementPolicy>> ensemblePlacementPolicyClass,
                             Map<String, Object> properties) throws IOException {
        return create(conf, zkClient, eventLoopGroup, ensemblePlacementPolicyClass, properties,
                NullStatsLogger.INSTANCE);
    }

Modifications
Add StatsLogger into BookKeeperClientFactory when creating BkClient.
The screenshot below is the result of my verification.

Verifying this change

[x]  Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] doc-not-needed

Re-open this PR to rebase the branch.

/pulsarbot run-failure-checks


Add products(ofType:), targets(ofType:), and sourceFiles(withSuffix:) utilities to PackagePlugin API

This continues expanding the set of utility methods based on feedback from early use of plugins.  This makes it easier to write simpler and briefer plugin code.
The extensions are:
extension Package {
    /// The products in this package that conform to a specific type.
    public func products<T: Product>(ofType: T.Type) -> [T]

    /// The targets in this package that conform to a specific type.
    public func targets<T: Target>(ofType: T.Type) -> [T]
}

extension SourceModuleTarget {
    /// A possibly empty list of source files in the target that have the given
    /// filename suffix.
    public func sourceFiles(withSuffix suffix: String) -> FileList
}

The last of these was documented in SE-0325, and the other two added based on feedback.

@swift-ci please smoke test


Fix account status jsonpath

This PR fixes a capitalization error within the account CRD effecting the status output.

/lgtm


use ixmp.TimeSeries.timeseries() filters, make IamDataFrame from pandas.DataFrame

This PR increases integration with pandas: IamDataFrames can now be initialized directly from a pandas.DataFrame, and append() also takes DataFrames as an argument. IamDataFrame can now also be appended directly to another IamDataFrame.
This PR also implements full filtering when loading timeseries data from an ixmp.TimeSeries object.

wrong target repository


EXDATE parsing incomplete

Skipped dates of a recurring appointment .. aren't skipped.

Actually an issue of https://github.com/jkbrzt/rrule, though the latter seems unmaintained.


add home button to take user to cartoview home page

should be optional from app configf

https://github.com/cartologic/cartoview_geo_collect/commit/81e853f38b337f4fed59cb6745e6e1ba0248d44f


The method of saving and updating does not require retry. Can feign control such an operation

Feign's retry mechanism by default is a retry of all request methods, how to control a method not retry, such as modifying or saving methods in a service

What version are you using? I think in the latest versions, retry only happens by default on GET and a property needs to be set to retry other HTTP methods.

Hey. I am using currently version 9.5.1, but unfortunately also newest version of feign will try a retry even on POST or PUT methods. See feing.SynchronousMethodHandler and feign.FeignException#errorExecuting. When there is an IOExeption, a RetryableException gets always thrown, no matter what request method

Can you please open a separate issue with a sample that reproduces the problem?


Script doesn't check to see if dpkg is locked

The script assumes dpkg isn't locked and tries to work normally.

You are right, but why should it check? We assume the user isn't installing other packages at the same time, which is common sense.
Am I maybe missing something else?

Various reasons why someone might think dpkg isn't locked when it is. I had a broken connection at the end of an upgrade and I didn't realize dpkg was locked until I tried using your script to remove openvpn.
Before that it just seemed like the script was broken.
Thank you for the script by the way, it works flawlessly otherwise.

I understand your specific situation. From time to time, someone complains about missing error checking, and fact is it could be a lot better: from locks to input, existing installations or firewalls.
At the end of the day, I decided to implement only very basic error checking since it would take a lot of time to code and test as we add more complexity.


Add spell checking in page editor textarea

idk if this was never added as a feature or if it is just broken for me (firefox 81.0.1, osx, grav 1.7) but it would be awesome to have live spellcheck while writing blog posts and things!

This will be possible with our upcoming "Nextgen Editor", which will be one of our first "premium plugins"


Remove inclusion of tchar.h

The dependency on tchar.h prevented build on windows for me. Removal of the inclusion does not appear to cause any problems. Unless this will cause other problems, I'd like to have it removed.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see CONTRIBUTING.md for more information.

Thanks!


Domain name in the admin messages

We have a small problem. Loglist seems to think he's placed on localhost:9000. This affects the domain name in the quote management messages (so I have to manually replace localhost:9000 with loglist.net before sending the HTTP request). How could we control that?

I'll take a look into that.

Added proxy_set_header Host loglist.net; to Nginx config. The problem has been fixed.


推理 报错 为啥访问 huggingface

本地部署，访问huggingface timeout  : LanguageBind/Languageßind_Image/resolve/main/tf_model.h5

Unclear, we don't have tf_model.h5, close it.


Multiple LUIS models requires input to be entered twice

I have been working on a bot with multiple luis models. I have used Node.js for this. So everytime I enter an utterance, I get the response as classified by LUIS as long as I am within the same intent's waterfall. But as soon as the waterfall ends, the next time I enter a query, I do not get a response but if I reenter the same query, I get a response.
For example:-
I have two models A and B. Model A handles food requests, Model B handles clothing.
Me: Give me some food
Bot: Continental / Italian/ Indian?
Me: Italian
Bot: Hungry for some pizza?
Me: Sure!
Bot:  Sending it on your way.
Me: I also need some new shoes.
No response from bot
Me: I also need some new shoes.
Bot: What size do you wear?
Am I missing something when doing an intents.matches?

I have the same issue in c# between luis root dialog and child prompt dialogs.

You're using a single IntentDialog with two models right? If that's the case then it's most likely something to do with how you finish up the task. Can you show me one of your waterfalls? I'm curious what you do when you send "Sending it on your way."

Yes, I'm using a single IntentDialog with two models. Here is a snippet for the waterfall.
intents.matches('SaveMoney', [
    var savings = builder.EntityRecognizer.findAllEntities(args.entities, 'builtin.number');
   var amount = session.dialogData.amount = {};
    function(session, args, next) {
        if (savings.length == 0) {
            builder.Prompts.text(session, 'How much money would you like to save?');
        } else {
            if (savings.length > 1) {
                    builder.Prompts.number(session, "Please enter a single amount. If you enter more than one amount, the first amount will be accepted");
            } else {
                amount.savings = savings[0].entity;
                next();
            }
        }
    },
  function(session, results)
    {
        var amount = session.dialogData.amount;
        if (results.response) {
            var amountSaved = results.response;
            amount.savings = results.response;
        } else if (amount.savings) {
            var amountSaved = amount.savings;
        }
        builder.Prompts.text(session, 'Good choice to save ' + amountSaved);
    }]);

@Stevenic or @maxpert can you help?

Sorry for the delay... You're calling Prompts.text() in your last waterfall step which is going to wait for the user to respond. You should call session.endDialog() with your message instead.

I'm having similar issue c#,
user: text1
Bot: (One Intent identifies and returns buttons in HeroCard) Button1/Button2/Button3
User: (selects/enter other value instead of selecting/entering above buttons value) text2
Bot: (displaying) text2 (But text2 should be identified by LuisDialog intent)
DisplayTraining.txt
PFA async DisplayTraining method which accepts Buttons value.  Based on button value it returns some values and again displays those in HeroCard. In above its going to else block where no items returns based on text2. In this else block we need to post text2 as new post which should be identified by LuisDialog intents.
Thanks in advance,
Rasheed

using below line helped me to re-dispatch the activity on the same LuisDialog,
await MessageReceived(context, Awaitable.FromItem(context.Activity.AsMessageActivity()));

Closing this but feel free to comment.


Run YarnUpdate only once for a version requirement

Issue: https://github.com/dependabot/dependabot-core/issues/4288
Currently, For a mono repo, when UpdateDependencyFiles is called for generating the lock file content, dependencies param is passed to it. Dependencies param contains the dep that needs to be updated in all required workspaces in the repo.
As far as observed, the multiple package.json (multiple requirements) for a dependency are getting passed for a mono repo., where it does have only a single yarn.lock file.
In this case, it's not necessary to run yarn update for each and every package.json or requirement if all are referring to same version.
For a single version, if run once, yarn.lock would be generated, and running the same version yarn update would result in repetition of the task.
In case if each package.json is referring to different versions of that dependency, this code would handle that by running yarn update accordingly.

Thanks @AlekhyaYalla, could you add some context on what this change does and how it works exactly?

Thanks @AlekhyaYalla, could you add some context on what this change does and how it works exactly?

@jurre Updated the description of the PR. My bad I missed it earlier. I hope the description is setting some context about the fix

Is there any additional test coverage that you think we could introduce around this?

Yes, I will add additional unit test cases for this change.

@jurre Could you please review this change and suggest if any changes are required on this?


Game crash when starting: NullPointerException: Null string not allowed

Game version:
1.12.2
Forge version:
<IP_ADDRESS>54
Mod version:
0.1.3
Crash report:
https://paste.ubuntu.com/p/BXMmFQsPwZ/
How to reproduce:
Simply start the game and then game will crash.
I think it is helpful to post this issue here, for it may implies a minor issue to be solved.
Thanks for your warm-hearted help in advance.

This comment is a bit late, but I just encountered this issue after adding Germplasm to a modpack that I created for myself and a few friends. 🥼
Removing Gendustry and Gendustry JEI resolved the issue altogether for me. 💯


I can't run this code

I'm following the readme, and I get an error：
FileNotFoundError: [Errno 2] No such file or directory:'/pub/data/cuiby/yjworkspace/Dassl.pytorch/data/office_home_dg/art/train'
[Errno 2]  No such file or directory: '/pub/data/cuiby/yjworkspace/Dassl.pytorch/data/office_home_dg/clipart/train'
I can't find the instructions for that anywhere

Did you download and prepare the datasets following this https://github.com/KaiyangZhou/Dassl.pytorch/blob/master/DATASETS.md?


could not import

Bug Report
Description
Could not import. when my android project's sync-ing,  it said :
ERROR: Failed to resolve: com.github.kittinunf.fuel:fuel-gson:2.8.5 Show in Project Structure dialog Affected Modules: app
To Reproduce
i was using gradle  to import : "implementation 'com.github.kittinunf.fuel:fuel-gson:2.8.5' "

Expected behavior
Sync should be successful, but it wasn't

OS: Windows 10
IDE:  Android Studio
Fuel GSON version: 2.8.5
Kotlin version:  i dont know

Make sure you follow all the instructions.
Is jcenter present in your gradle sourced?

@gvincenter have you resolved the problem?

I do have the same Problem:

Could not find com.github.kittinunf.fuel:fuel-jackson:2.9.8.

after reading @SleeplessByte comment I looked for a way to include jcenter and found it within the pull requests.
Unfortunately still not able to find the package :-/
repositories {      jcenter()      mavenLocal()    }
On the other hand fuel alone is found without any problems

I guess the issue get staled. I will close the issue for now. Feel free to reopen this if you want to.


Error: Request failed with status code 400 and un-able to add to HomeKit

What issue do you have? Please be as thorough and explicit as possible.
I emailed support and received my API key within a few minutes, I then installed the plugin for my H6160 and configured using the HomeBridge UI.  My config at that point is what is below
"name": "Govee",
"apiKey": "******",
"debug": false,
"debugReqRes": false,
"refreshTime": 15,
"platform": "Govee"
I then tried to add to Homekit which failed as the light was not found, so I looked at the logs and saw a 400 error, While Homebridge is getting the 400 error, I am able to turn the light off/on in Homebridge but I am not able to add the light to HomeKit.
[Govee] [Bathroom Under Sinks] could not be updated and its status will be reverted soon. Error: Request failed with status code 400.  (logs are at the end as requested)
so I removed the lines that were not in the example and set my config to the following with debug on and debugReqRes off (I will add the logs at the bottom with debugReqRes on where you requested):
"name": "Govee",
"apiKey": "******",
"debug": true,
"platform": "Govee"
The log messages are below, it is failing with the same error.
[10/29/2020, 10:00:14 AM] Homebridge v1.2.3 is running on port 51810.
[10/29/2020, 10:00:14 AM] [LED Strip] DEVICE COLOR - (H,S,V): 112,100,100  (R,G,B): [ 33, 255, 0 ]
[10/29/2020, 10:00:15 AM] [Govee] [1] devices loaded from your Govee account.
[10/29/2020, 10:00:15 AM] [Govee] Govee setup complete. Don't forget to ⭐  this plugin on GitHub if you're finding it useful!
[10/29/2020, 10:02:30 AM] [Govee] [Bathroom Under Sinks] has been turned [on].
[10/29/2020, 10:02:31 AM] [Govee] [Bathroom Under Sinks] could not be updated and its status will be reverted soon. Error: Request failed with status code 400.
...
Details of your setup.
Do you use Homebridge or HOOBS?
I use Homebridge running in Docker on my Synolgy NAS
...
Which version of Homebridge/HOOBS do you have?
1.2.3
I pasted at the bottom an image of my Homebridge home page so you can see all of the versions I am running for the software
...
Which version of this plugin (homebridge-govee) do you have?
2.0.6
...
Please paste any relevant logs below. It helps if you can turn debug and debugReqRes in the package settings for more thorough logging.

If you are posting an error then it is helpful for me to also see the previous few lines as this can show the cause of the error.

This is before I tried to turn the light on/off in Homebridge
[10/29/2020, 10:15:38 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:15:38 AM] [Govee] [1] devices loaded from your Govee account.
[10/29/2020, 10:15:38 AM] [Govee] Govee setup complete. Don't forget to ⭐  this plugin on GitHub if you're finding it useful!
[10/29/2020, 10:15:38 AM] [Govee] Note: 'Request & Response Logging' is not advised for long-term use.
[10/29/2020, 10:15:39 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:15:39 AM] Receiver 764A is running on port 59919.
[10/29/2020, 10:15:39 AM] Please add [Receiver 764A] manually in Home app. Setup Code: 031-45-154
[10/29/2020, 10:15:47 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:15:47 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:15:48 AM] [Garage Door] State of Garage Door is: CLOSED
[10/29/2020, 10:15:50 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:15:50 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:15:53 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:15:53 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:16:08 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:16:09 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:16:24 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:16:24 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:16:37 AM] [ADT Pulse] Security Panel (system-1) changed from "disarmed / all quiet" to "disarmed / motion".
[10/29/2020, 10:16:38 AM] [ADT Pulse] Office Motion Detector (sensor-26) changed from "no motion" to "motion".
[10/29/2020, 10:16:39 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:16:39 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:16:54 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:16:55 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
Below is the rest of the log (all that was shown that I could copy)
[10/29/2020, 10:17:10 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:17:25 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:17:25 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:17:40 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:17:41 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:17:41 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:17:41 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:17:42 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:17:42 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:17:45 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:17:45 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:17:46 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:17:46 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:17:49 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:17:49 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:17:55 AM] [Govee] [updateDevice()] HTTP Request. This message is yellow for clarity:
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"cmd": {
"name": "turn",
"value": "off"
}
}
[10/29/2020, 10:17:55 AM] [Govee] [updateDevice()] HTTP Response:
{
"code": 200,
"message": "Success",
"data": {}
}
[10/29/2020, 10:17:55 AM] [Govee] [Bathroom Under Sinks] has been turned [off].
[10/29/2020, 10:17:56 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:17:57 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "off"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:17:57 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:17:57 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:18:12 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:18:12 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "off"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:18:19 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:18:20 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:18:22 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:18:23 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:18:23 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:18:27 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:18:27 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "off"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:18:42 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:18:42 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "off"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:18:56 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:18:57 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:18:58 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:18:58 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "off"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:19:00 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:19:01 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:19:08 AM] [ADT Pulse] Security Panel (system-1) changed from "disarmed / motion" to "disarmed / all quiet".
[10/29/2020, 10:19:08 AM] [ADT Pulse] Office Motion Detector (sensor-26) changed from "motion" to "no motion".
[10/29/2020, 10:19:13 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:19:13 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "off"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:19:20 AM] [Govee] [updateDevice()] HTTP Request. This message is yellow for clarity:
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"cmd": {
"name": "turn",
"value": "on"
}
}
[10/29/2020, 10:19:20 AM] [Govee] [updateDevice()] HTTP Response:
{
"code": 200,
"message": "Success",
"data": {}
}
[10/29/2020, 10:19:20 AM] [Govee] [Bathroom Under Sinks] has been turned [on].
[10/29/2020, 10:19:20 AM] [Govee] [updateDevice()] HTTP Request. This message is yellow for clarity:
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"cmd": {
"name": "brightness",
"value": 254
}
}
[10/29/2020, 10:19:20 AM] [Govee] [Bathroom Under Sinks] could not be updated and its status will be reverted soon. Error: Request failed with status code 400.
[10/29/2020, 10:19:22 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:19:22 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:19:22 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:19:22 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:19:28 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:19:28 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:19:38 AM] [ADT Pulse] Security Panel (system-1) changed from "disarmed / all quiet" to "disarmed / motion".
[10/29/2020, 10:19:38 AM] [ADT Pulse] Office Motion Detector (sensor-26) changed from "no motion" to "motion".
[10/29/2020, 10:19:43 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:19:44 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:19:59 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:19:59 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:20:14 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:20:14 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:20:29 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:20:30 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:20:45 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:20:45 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:20:45 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:20:46 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:20:49 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:20:49 AM] [Govee] [updateDevice()] HTTP Request. This message is yellow for clarity:
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"cmd": {
"name": "turn",
"value": "off"
}
}
[10/29/2020, 10:20:49 AM] [Govee] [updateDevice()] HTTP Request. This message is yellow for clarity:
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"cmd": {
"name": "turn",
"value": "on"
}
}
[10/29/2020, 10:20:49 AM] [Govee] [updateDevice()] HTTP Response:
{
"code": 200,
"message": "Success",
"data": {}
}
[10/29/2020, 10:20:49 AM] [Govee] [Bathroom Under Sinks] has been turned [off].
[10/29/2020, 10:20:49 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:20:49 AM] [Govee] [updateDevice()] HTTP Response:
{
"code": 200,
"message": "Success",
"data": {}
}
[10/29/2020, 10:20:49 AM] [Govee] [Bathroom Under Sinks] has been turned [on].
[10/29/2020, 10:20:49 AM] [Govee] [updateDevice()] HTTP Request. This message is yellow for clarity:
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"cmd": {
"name": "brightness",
"value": 254
}
}
[10/29/2020, 10:20:50 AM] [Govee] [updateDevice()] HTTP Request. This message is yellow for clarity:
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"cmd": {
"name": "turn",
"value": "off"
}
}
[10/29/2020, 10:20:50 AM] [Govee] [Bathroom Under Sinks] could not be updated and its status will be reverted soon. Error: Request failed with status code 400.
[10/29/2020, 10:20:50 AM] [Govee] [updateDevice()] HTTP Response:
{
"code": 200,
"message": "Success",
"data": {}
}
[10/29/2020, 10:20:50 AM] [Govee] [Bathroom Under Sinks] has been turned [off].
[10/29/2020, 10:20:51 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:20:51 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:20:52 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:20:52 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:20:52 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:20:52 AM] [Receiver] Current input: ATT (HDMI1)
[10/29/2020, 10:20:52 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:20:52 AM] [FamilyNAS] current power state is: true
[10/29/2020, 10:21:00 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:21:01 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "off"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:21:16 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:21:16 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "off"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:21:31 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:21:31 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "off"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:21:46 AM] [Govee] [getDevices()] HTTP Response:
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:21:47 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "off"
},
{
"brightness": 1
},
{
"color": {
"r": 0,
"b": 255,
"g": 0
}
}
]
},
"message": "Success",
"code": 200
}
...

Thank you

Thanks for the detailed issue, it really helps to already have this info!
I wonder if you could do me a favour:

Please turn the brightness of the device to 100% using the govee app
Look in Homebridge/HomeKit to see what the brightness has been set to and report this back to me

thanks!

Interesting, I set the brightness to 100% as requested in the Govee app as requested and in HomeBridge the brightness is 39%.  If you would like screen prints so that let me know, and I added the last few "lines" of the log below in case you need those.
Thank you,
Mike
{
"data": {
"devices": [
{
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"deviceName": "Bathroom Under Sinks",
"controllable": true,
"retrievable": true,
"supportCmds": [
"turn",
"brightness",
"color",
"colorTem"
]
}
]
},
"message": "Success",
"code": 200
}
[10/29/2020, 10:42:28 AM] [Govee] [getDevice()] HTTP Response:
{
"data": {
"device": "7E:59:A4:C1:38:D7:F0:3B",
"model": "H6160",
"properties": [
{
"online": true
},
{
"powerState": "on"
},
{
"brightness": 100
},
{
"color": {
"r": 165,
"b": 165,
"g": 165
}
}
]
},
"message": "Success",
"code": 200
}

There are some govee models that I need to make a little fix for. You should find it works fine right now if you never set the brightness above 39% 🤣
I’ll get an update out within the next few minutes and it should be working well!

I don't set this light above about 10% normally as it's the night light in the bathroom so I am not woken up more than needed to see at night :)  So that should be fine, the 2nd problem is that I am not able to add the light to homekit as it does not show up when I Add Accessory.
Thank you,
Mike

Please try v2.0.7 for the brightness fix.
But I am also confused by your second issue. If the device is in Homebridge then it should appear in HomeKit already.
Have you added Homebridge to your HomeKit?

I updated the plugin and the brightness issue has been resolved. Thank you on.
On the adding issue, I was confused normally I have to see and select the device to add it.  The device did not show when I went to add it to Homekit.
BUT
I then went to the default room to make sure and it was already there without me having to add it  YAY - We can call that a feature :-)
Thank you again for all of your help,
Mike

Ah glad it’s sorted! Any accessory that you add to Homebridge will appear automatically in your Home app, without having to “add” anything further 🙂


disconnect button not working

Current Behavior
Disconnect Wallet method not working.
Code:
import { useConnectWallet } from "@web3-onboard/react";
const [{ wallet }, connect, disconnect] = useConnectWallet();
<Button
  onClick={() => {
    console.log("disconnect", wallet?.label);
    if (wallet?.label) {
      disconnect({ label: wallet.label });
    }
  }}
>
  Disconnect
</Button>;

VM2071:1 Uncaught (in promise) SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at disconnect (chunk-3KTU32IX.js?v=b86981d5:10779:23)
    at async @web3-onboard_react.js?v=b86981d5:234:25

Expected Behavior
Disconnect wallet not to throw the error.
Steps To Reproduce
No response
What package is effected by this issue?
@web3-onboard/react
Is this a build or a runtime issue?
Runtime
Package Version
2.9.1
Node Version
20.14.0
What browsers are you seeing the problem on?
Chrome
Relevant log output
VM2071:1 Uncaught (in promise)
SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
    at disconnect (chunk-3KTU32IX.js?v=b86981d5:10779:23)
    at async @web3-onboard_react.js?v=b86981d5:234:25
disconnect	@	chunk-3KTU32IX.js?v=b86981d5:10779
await in disconnect (async)
onClick	@	Navbar.tsx:73
callCallback2	@	chunk-CGTQQ34U.js?v=b86981d5:3674
invokeGuardedCallbackDev	@	chunk-CGTQQ34U.js?v=b86981d5:3699
invokeGuardedCallback	@	chunk-CGTQQ34U.js?v=b86981d5:3733
invokeGuardedCallbackAndCatchFirstError	@	chunk-CGTQQ34U.js?v=b86981d5:3736
executeDispatch	@	chunk-CGTQQ34U.js?v=b86981d5:7014
processDispatchQueueItemsInOrder	@	chunk-CGTQQ34U.js?v=b86981d5:7034
processDispatchQueue	@	chunk-CGTQQ34U.js?v=b86981d5:7043
dispatchEventsForPlugins	@	chunk-CGTQQ34U.js?v=b86981d5:7051
(anonymous)	@	chunk-CGTQQ34U.js?v=b86981d5:7174
batchedUpdates$1	@	chunk-CGTQQ34U.js?v=b86981d5:18913
batchedUpdates	@	chunk-CGTQQ34U.js?v=b86981d5:3579
dispatchEventForPluginEventSystem	@	chunk-CGTQQ34U.js?v=b86981d5:7173
dispatchEventWithEnableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay	@	chunk-CGTQQ34U.js?v=b86981d5:5478
dispatchEvent	@	chunk-CGTQQ34U.js?v=b86981d5:5472
dispatchDiscreteEvent

Anything else?
No response
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

@nitishpatel a fix for this has been released and is available with the latest version of @web3-onboard/react


Position of ListEmptyComponent

I'm just investigating the rendered position when you include a ListEmptyComponent. I believe the position is correct when you scroll to hide the header (i.e. the List EmptyComponent is in the middle of the screen). However, it displays too far down when the header is displayed (the default on page load).
For example in Contacts.tsx.
const ListEmptyComponent = () => (
  <View
    style={{
      alignItems: 'center',
      flex: 1, // Without it will dispay at the very top
      justifyContent: 'center',
    }}
  >
    <Text>No results.</Text>
  </View>
);

export default class Contacts extends React.Component {
  render() {
    return (
      <FlatList
        data={CONTACTS}
        keyExtractor={(_, i) => String(i)}
        renderItem={renderItem}
        ItemSeparatorComponent={ItemSeparator}
      />
    );
  }
}

// used in Collapsible TabView examples
export const AnimatedContacts = React.forwardRef<
  any,
  React.PropsWithoutRef<CollapsibleScenePropsAndRef>
>((props, ref) => {
  const [isRefreshing, startRefreshing] = useRefresh();

  return (
    <Animated.FlatList
      ref={ref}
      data={CONTACTS}
      keyExtractor={(_, i) => String(i)}
      renderItem={renderItem}
      ItemSeparatorComponent={ItemSeparator}
      ListEmptyComponent={ListEmptyComponent} // <--- Here
      refreshing={isRefreshing}
      onRefresh={startRefreshing}
      {...props}
    />
  );
});

And

Can we perhaps resolve this using flexGrow: 1 instead of using minHeight?
export const AnimatedContacts = React.forwardRef<
  any,
  React.PropsWithoutRef<CollapsibleScenePropsAndRef>
>(({ contentContainerStyle, ...rest }, ref) => {
  const [isRefreshing, startRefreshing] = useRefresh();

  const contentContainerStyleProp = {
    paddingTop: contentContainerStyle.paddingTop || 0,
    flexGrow: 1,
  };

  return (
    <Animated.FlatList
      ref={ref}
      data={CONTACTS}
      keyExtractor={(_, i) => String(i)}
      renderItem={renderItem}
      ItemSeparatorComponent={ItemSeparator}
      ListEmptyComponent={ListEmptyComponent}
      refreshing={isRefreshing}
      onRefresh={startRefreshing}
      contentContainerStyle={contentContainerStyleProp}
      {...rest}
    />
  );
});

Gives:

@alexpchin I'm not with the project open right now, I will check it later, but I think removing the minHeight will re-introduce a bug in case of the content being smaller than the screen height (#8). Can you check this by adding the same contentContainerStyleProp to the SmallContentExample ?

@PedroBern Yes, you are correct. It does create a gap at the top when scrolling between tabs. I will look into it further now.

@alexpchin check out the #22 preview, please let me know if it is working for you or if you have something to add. When you say it's ok I will merge and release :)

@PedroBern is the man. 🚀

released in v1.4.1 🚀

@PedroBern If there were two EmptyList Components:
i.e. Very simplified example to reproduce:
.
.
.

const renderScene = SceneMap({
  contacts: ContactsScene,
  contacts2: ContactsScene,
});

const App: React.FC<object> = () => {
  const [index, setIndex] = React.useState(0);
  const [routes] = React.useState<Route[]>([
    { key: 'contacts', title: 'Contacts' },
    { key: 'contacts2', title: 'Contacts2' },
  ]);

.
.
.

With the current implementation, you would get:

And:


View mode selector not responding well to resize

I still see this in Weave Cloud

Yeah, so the issue has been fixed on master, but since nobody updated the Scope UI version package.json of service-ui for a several weeks now, the changes haven't been propagated to Weave Cloud yet.
I created https://github.com/weaveworks/service-ui/pull/481 just for that, but I wonder what our general issue closing policy should be now that the two things are separate (and can happen with a significant time diff)?


effitask Crash Report

effitask crashes when run in ssh session
What are the minimum necessary steps to reproduce this issue?

connect to system with effitask installed using ssh
execute effitask

What happens?

crash :boom:

What were you expecting to happen?
program runs without crash. show error that it needs a desktop environment to run
Please paste any error or log messages here
name = 'effitask'
operating_system = 'unix:Unknown'
crate_version = '0.1.0'
explanation = '''
Panic occurred in file 'src/main.rs' at line 28
'''
cause = 'called `Result::unwrap()` on an `Err` value: ()'
method = 'Panic'
backtrace = '''

   0: 0x563c48f3dce3 - std::rt::lang_start::{{closure}}::h97ac74c303628abb
   1: 0x563c49080e13 - std::panicking::try::do_call::h964c2005900883ea
   2: 0x563c4908d8d7 - __rust_maybe_catch_panic
   3: 0x563c4908159e - std::rt::lang_start_internal::h10df09bb0b15c94c
   4: 0x563c48ef26b2 - main
   5: 0x7f51c3183d8b - __libc_start_main
   6: 0x563c48ed921a - _start
   7:        0x0 - <unknown>'''

Any other details
how othar gui apps handle the situation:
[nix-shell:~/.cache/nixpkgs-review/pr-84291-1]$ io.elementary.code

(io.elementary.code:9762): Gtk-WARNING **: 19:38:41.334: cannot open display:

[davidak@nixos:~/nixpkgs]$ epiphany
Failed to parse arguments: Cannot open display:

[davidak@nixos:~/nixpkgs]$ boincmgr
19:47:29: Error: Unable to initialize GTK+, is DISPLAY set properly?

[davidak@nixos:~/nixpkgs]$ gimp
Cannot open display:

It’s strange, when I execute it (compiled in release mode), I have a prettier
output:
$ LANG=C; unset DISPLAY; ./target/release/effitask
Unable to init server: Could not connect: Connection refused
Well, this is embarrassing.

effitask had a problem and crashed. To help us diagnose the problem you can send us a crash report.

We have generated a report file at "/tmp/report-f80c09f1-e642-4e97-80c8-d7154c6b4577.toml". Submit an issue or email with the subject of "effitask Crash Report" and include the report as an attachment.

- Homepage: https://github.com/sanpii/effitask
- Authors: Sanpi<EMAIL_ADDRESS>
We take privacy seriously, and do not perform any automated error collection. In order to improve the software, we rely on people to submit reports.

Thank you kindly!

I got that exept "Unable to init server: Could not connect: Connection refused".

https://github.com/antoyo/relm/issues/254

Outdated, I completely rewrite the application with relm4.


Bump kubernetes dependencies to v0.31.x.

What type of PR is this?
/kind cleanup

What this PR does / why we need it
Bump kubernetes dependencies to v0.31.x.
Which issue(s) this PR fixes

Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?

NONE

Thank you for adding this. We probably should make sure we have a 1.31 test also. Its not quite related but I don't think we have one for this yet.

Added https://github.com/kubernetes/test-infra/pull/33413

/lgtm
/approve


Blog post for Contributor Celebration 2021

This PR is regarding the blogpost for contributor celebration 2021, the draft could be found here

Thanks @mrbobbytables I have updated with the changes I guess it can be merged now

Thanks!
/label tide/merge-method-squash
/approve
/hold
@jberkus can you do a double check for me?

/remove-hold
/lgtm


Update king-of-fans-zigbee-fan-controller.groovy

Since round() will round to the nearest integer (up or down), your 25%, 50%, 75%, 100% was resulting in values of 1, 3, 4, 5, respectively. The code I'm proposing here should fix that (I believe floor will return 0 if you pass null into it, so I got rid of that check as well).

Hi @jakeevan
I just merged another PR fixing the issue (sorry, it was just the first one in order). Could you confirm if the round change is still needed?


EFO:0010702 should be combined with UMLS:C4324621 via MedDRA:10079385

According to http://www.ebi.ac.uk/efo/EFO_0010702, EFO:0010702 has a dbxref to MedDRA:10079385, which NodeNorm combines with UMLS:C4324621. If we can pick up those connections from either EFO or another source, we should be able to collapse our opioid use disorders cliques a bit more (#265).

This is because we only pick up EFO exactMatches, not dbxrefs:
https://github.com/TranslatorSRI/Babel/blob/0c3f3aed1bb1647f1ca101ba905dc241797fdfc9/src/datahandlers/efo.py#L85-L89
Given that dbxrefs aren't exact matches, we probably shouldn't expand this without much thought.


Move to Errai 3.2.2-SNAPSHOT

Tested the full build with tests and the uf-showcase webapp.

master: e553d5b6978d22419d330c1fbb3571ce27e815d9


App name should not be "NightScout"

Code version: commit 4c42c64 (master)
Environment:   AVD Nexus_5X_API_21 [emulator-5554]
Environment:   Sony D2303 (Android 5.1.1, API 22)  Xperia M2
Despite the presence of
<string name="app_name">NS 640g Uploader</string>
the displayed app name is "NightScout"
IMO the distinctive name is better (avoids confusion with website, distinguishes app from the Veo/530 uploader)

Note - there are two items to change

the name when the app is displayed among others on the devices 'home screen' etc
the name within the app when it's running


Add a logger

It would be very useful if we could log changes during up and down.

It would be very useful if we could log changes during up and down.

@JensWinkler91 what kind of logs are we talking about? Could you give an example.

I modify documents in multiple collections.
//Modify collection 1
  db.db.collection('collection1').updateMany({}, {
    $set: {
      param1: "param1Value"
    }
  });

//Modify collection 2
  db.db.collection('collection2').updateMany({}, {
    $set: {
      param2: "param2Value"
    }
  });

I get no information what happened if the update for collection 1 failed.
To solve that, you could provide a logger that can be used to track the changes during up/down.
//Modify collection 1
Logger.info("Update collection 1");

  db.db.collection('collection1').updateMany({}, {
    $set: {
      param1: "param1Value"
    }
  });

//Modify collection 2
Logger.info("Update collection 2");

  db.db.collection('collection2').updateMany({}, {
    $set: {
      param2: "param2Value"
    }
  });


chore: bump<EMAIL_ADDRESS>

This builds against debug version of electron to get more info on https://github.com/microsoft/vscode/issues/88596 and https://github.com/microsoft/vscode/issues/88415
Should NOT be merged
/cc @bpasero

@deepak1556 I believe we can close this?