Error getting location in NativeScript 5

Hi,
After upgrade NativeScript to version 5, I have this error:
Cannot enable the location service. Error: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/android/gms/internal/zzbck;
My app.gradle is:
{
  "nativescript": {
    "id": "com.autocorp.autocorpapp",
    "tns-android": {
      "version": "5.0.0"
    }
  },
  "description": "NativeScript Application",
  "license": "SEE LICENSE IN <your-license-filename>",
  "repository": "<fill-your-repository-here>",
  "dependencies": {
    "moment": "^2.22.2",
    "nativescript-crossplatform-aes": "^1.0.3",
    "nativescript-directions": "^1.3.0",
    "nativescript-dom": "^2.0.2",
    "nativescript-geolocation": "^4.3.1",
    "nativescript-google-maps-sdk": "^2.6.1",
    "nativescript-loading-screen": "^1.0.6",
    "nativescript-phone": "^1.4.0",
    "nativescript-sqlite": "^2.2.3",
    "nativescript-theme-core": "^1.0.4",
    "nativescript-xml2js": "^0.5.2",
    "tns-core-modules": "^5.0.2"
  },
  "readme": "NativeScript Application",
  "devDependencies": {
    "nativescript-dev-webpack": "^0.17.0"
  }
}

@neumartin please any update on this, currently getting the same error.

@neumartin please any update on this, currently getting the same error.

I just downgrade to 4, no solutions for now.

Getting the same error, geolocation doesn't seem to work anymore in NS 5
Error: Cannot enable the location service. Error: java.lang.NoClassDefFoundError: com.google.android.gms.location.LocationRequest
JS:     java.lang.Class.classForName(Native Method)
JS:     java.lang.Class.forName(Class.java:324)
JS:     java.lang.Class.forName(Class.java:285)
JS:     com.tns.Runtime.getClassForName(Runtime.java:1036)
JS:     com.tns.ClassResolver.resolveClass(ClassResolver.java:27)
JS:     com.tns.Runtime.resolveClass(Runtime.java:604)
JS:     com.tns.Runtime.callJSMethodNative(Native Method)
JS:     com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1116)JS:     com.tns.Runtime.callJSMethodImpl(Runtime.java:996)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:983)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:967)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:959)
JS:     com.tns.FragmentClass.onCreateView(FragmentClass.java:45)
JS:     android.support.v4.app.Fragment.performCreateView(Fragment.java:2439)
JS:     android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1460)

package.json
  "nativescript": {
    "id": "com.happee.app.mobile",
    "tns-ios": {
      "version": "4.2.0"
    },
    "tns-android": {
      "version": "5.0.0"
    }
  },
  "description": "NativeScript Application",
  "license": "SEE LICENSE IN <your-license-filename>",
  "repository": "<fill-your-repository-here>",
  "dependencies": {
    "nativescript-dom": "^2.0.2",
    "nativescript-geolocation": "^4.3.1",
    "nativescript-google-maps-sdk": "^2.6.1",
    "nativescript-pager": "^8.0.2",
    "nativescript-theme-core": "~1.0.4",
    "tns-core-modules": "^5.0.2",
    "tslib": "^1.9.3"
  },
  "devDependencies": {
    "eslint": "^5.9.0",
    "nativescript-dev-typescript": "^0.7.4",
    "nativescript-dev-webpack": "^0.18.0",
    "tslint": "^5.11.0",
    "typescript": "~2.7.2"
  },

Someone who knows how to fix this, please have a look 🥇 :D

Same problem here.
Error: Cannot enable the location service. Error: java.lang.NoClassDefFoundError: com.google.android.gms.location.LocationRequest
package.json
{
"nativescript": {
"id": "",
"tns-ios": {
"version": "5.0.0"
},
"tns-android": {
"version": "5.0.0"
}
},
"main": "app.js",
"description": "NativeScript Application",
"license": "SEE LICENSE IN ",
"repository": "",
"dependencies": {
"moment": "^2.21.0",
"nativescript-barcodescanner": "^2.7.4",
"nativescript-camera": "^4.0.3",
"nativescript-dom": "^2.0.0",
"nativescript-fancyalert": "^1.2.0",
"nativescript-geolocation": "^4.3.1",
"nativescript-google-maps-sdk": "^2.5.0",
"nativescript-iqkeyboardmanager": "^1.3.0",
"nativescript-loading-indicator": "^2.4.0",
"nativescript-orientation": "^2.2.0",
"nativescript-platform-css": "^1.6.5",
"nativescript-plugin-firebase": "^7.3.0",
"nativescript-pro-ui": "3.1.4",
"nativescript-speech-recognition": "^1.4.1",
"nativescript-theme-core": "~1.0.4",
"nativescript-toast": "^1.4.6",
"tns-core-modules": "^5.0.2"
},
"devDependencies": {
"nativescript-dev-typescript": "~0.7.0",
"nativescript-dev-webpack": "~0.18.0",
"typescript": "^3.1.6"
},
"readme": "NativeScript Application"
}

I have the same problem, and after doing some testing I understood that the problem occurs after the installation of google-map sdk. When I delete it it works just fine. Anyone has any updates onthis?

I fixed the problem by adding this file to App Resources>Android
file name: before-plugins.gradle
content: android {
// other stuff here
project.ext {
googlePlayServicesVersion = "15.0.1"
}
}

I fixed the problem by adding this file to App_Resources/Android
file name: before-plugins.gradle
content: android {
// other stuff here
project.ext {
googlePlayServicesVersion = "15.0.1"
}
}

@annadante, why version 15.0.1? And where did you find that information? Just in case I can look up myself, in case of any mismatch. I used to have googlePlayServicesVersion = "+" which should force everything to the latest version.
Thank you ;)

I tries the "+" thing and it didn't work.
The information was commented in the app.gradle file in Android folder :D

Hi @neumartin ,
I've tested the plugin's demo and found that there is no issue with it. The problem that you observe is related to dependency which both nativescript-geolocation and nativescript-google-maps-sdk plugins are using. The googlePlayServicesVersion dependency should be used with same version for both plugins. So the solution of the issue, when building an app is to specify which version of the dependency should be used by both plugins. As suggested by @annadante you should add before-plugins.gradle file where the googlePlayServicesVersion should be specified:
android {
    project.ext {
        googlePlayServicesVersion = "15.0.1"
    }
}

@DimitarTodorov thanks!, i will try.

I fixed the problem by adding this file to App_Resources/Android
file name: before-plugins.gradle
content: android {
// other stuff here
project.ext {
googlePlayServicesVersion = "15.0.1"
}
}

@annadante, why version 15.0.1? And where did you find that information? Just in case I need to look up myself because of any mismatch. I used to have googlePlayServicesVersion = "+" which should force everything to the latest version.
Thank you ;)

This worked for me too. However, I don't get why I had to create a new statement if I had previously pinned on app.graddle the "googlePlayServicesVersion" version to be used...

I tried the solution listed above, but now I am getting:
The library com.google.android.gms:play-services-basement is being requested by various other libraries at [[15.0.1,15.0.1]], but resolves to 16.0.1. Disable the plugin and check your dependencies tree using ./gradlew :app:dependencies.

Any suggestions?

@dpdragnev can you please post the package.json content so I can investigate your case (It is probably a conflict in the support library version as suggested by the error which is caused by a plugins requiring specific support version)
Meanwhile, have you tried using before-plugins.gradle file to force a version
app/App_Resources/Android/before-plugins.gradle
android {
  project.ext {
      googlePlayServicesVersion = "15.0.1"
  }
}

@NickIliev Here is my package.json:
{
  "nativescript": {
    "id": "com.somecompany.someapp",
    "tns-ios": {
      "version": "4.2.4"
    },
    "tns-android": {
      "version": "5.0.0"
    }
  },
  "description": "My App",
  "license": "SEE LICENSE IN <your-license-filename>",
  "repository": "<fill-your-repository-here>",
  "dependencies": {
    "moment": "^2.22.2",
    "nativescript-geolocation": "^4.3.1",
    "nativescript-loading-indicator": "2.4.0",
    "nativescript-local-notifications": "3.1.0",
    "nativescript-plugin-firebase": "^7.3.0",
    "nativescript-theme-core": "~1.0.4",
    "tns-core-modules": "5.0.3"
  },
  "devDependencies": {
    "nativescript-dev-typescript": "~0.7.0",
    "nativescript-dev-webpack": "~0.15.0",
    "typescript": "~2.7.2"
  },
  "readme": "NativeScript Application"
}

I tried to add the before-plugin.gradle file, but I am now getting:
User Rejected it: Cannot enable the location service. Error: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/android/gms/internal/zzbck;
JS:     com.tns.Runtime.callJSMethodNative(Native Method)
JS:     com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1116)
JS:     com.tns.Runtime.callJSMethodImpl(Runtime.java:996)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:983)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:967)
JS:     com.tns.Runtime.callJSMethod(Runtime.java:959)
JS:     com.tns.NativeScriptActivity.onRequestPermissionsResult(NativeScriptActivity.java:58)
JS:     android.app.Activity.dispatchRequestPermissionsResult(Activity.java:7737)
JS:     android.app.Activity.dispatchActivityResult(Activity.java:7560)
JS:     android.app.ActivityThread.deliverResults(ActivityThread.java:4487)
JS:     android.app.ActivityThread.handleSendResult(ActivityThread.java:4534)
JS:     android.app.ActivityThread.-wrap20(Unknown Source:0)
JS:     android.app.ActivityThread$H.handleMessage(ActivityThread.java:1752)
JS:     android.os.Handler.dispat...

Thank you

@dpdragnev I am building a project with the exact same dependencies with no hassle. Looking at your error log the issue seems related to version mismatch of some Android libraries Update your Google Play Services to latest (details here)

Above (before-plugins.gradle) did not work for me but the approach described here: https://github.com/NativeScript/nativescript-geolocation/issues/156#issuecomment-419646837
Instead of + I used version 15.0.1

If you do the before-plugins.gradle method.
You do not have to change app.gradle from googlePlayServicesVersion = "+".

This is what I tried first but it did not work for me. I have not investigated the reasons further as I found a good-enough solution.

@DimitarTodorov  before-plugins.gradle solution works. Maybe worth changing the github documentation as I was trying to set googlePlayServicesVersion = "16.+" on the app.gradle file which is applied after the plugins configuration.
applyBeforePluginGradleConfiguration()
applyPluginGradleConfigurations()
applyAppGradleConfiguration()

Thanks @NickIliev @annadante for answers. it worked for me
android {
  project.ext {
      googlePlayServicesVersion = "15.0.1"
  }
}

I fixed the problem by adding this file to App_Resources/Android
file name: before-plugins.gradle
content: android {
// other stuff here
project.ext {
googlePlayServicesVersion = "15.0.1"
}
}

Cool, Thats work for me


Make game pages say which event it's from (and wether the game is Jam/Compo )

(21:17:10) Hegemege: also noticed that there's nowhere on the game page which event it was produced for

I'm pretty sure I ran in to a duplicate of this, but they do say what event they belong to (just it's not very loud).

Yea, the new navigation makes it very clear.


Error when running demo

On http://cdn.rawgit.com/UDST/vizicities/master/examples/basic/index.html

Failed to load resource: the server responded with a status of 403 (Not Found)

and in response object text would be

API Key Disabled

On http://cdn.rawgit.com/UDST/vizicities/master/examples/geojson/index.html

reqwest.js:240 GET http://vector.mapzen.com/osm/roads,pois,buildings/14/4824/6159.json 401 (Unauthorized)

and in response object text would be

Hello! You did not include a Mapzen API key with your request. Please sign up for a free key at https://mapzen.com/developers

搭车求问


[Bug-FE][UI Next][V1.0.0-Alpha]  Upstream Tasks field UI display extra long

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Upstream Tasks field UI display extra long

What you expected to happen
Display effect can be super long hidden, mouse hover to show the details
How to reproduce
Entering Task Definition will show
Anything else
No response
Version
dev
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I will fix it.


Delete CacheWorth

Deletes the CacheWorth data type. CacheWorth basically models three possible states, greater than, less than, and equalTo, isomorphic to the Ordering data type in ZIO Prelude that is the result of the compare operator on Ord. I don't think this really pulls its weight as its own data type. If we just have the compare operators on CachingPolicy and Priority return an Int analogous to scala.math.Ordering and java.lang.Comparable we can simplify interoperation with these abstractions and take advantage of existing intuition about them.
This also makes the semantics of CachingPolicy and Priority more intuitive. An entry that is "greater" in priority in the caching policy is more important and should be retained over an entry with "lower" priority.

It also dramatically improves performance on the churn benchmark.
Before:
[info] Benchmark                     (size)   Mode  Cnt   Score   Error  Units
[info] ChurnBenchmark.zioCacheChurn   10000  thrpt   25  58.555 ± 1.797  ops/s
[info] FillBenchmark.zioCacheFill     10000  thrpt   25  60.027 ± 1.071  ops/s

After:
[info] Benchmark                     (size)   Mode  Cnt    Score   Error  Units
[info] ChurnBenchmark.zioCacheChurn   10000  thrpt   25  165.935 ± 2.582  ops/s
[info] FillBenchmark.zioCacheFill     10000  thrpt   25   63.105 ± 1.401  ops/s

Wow. Amazing.

We should make sure that decorations and laziness at the order of the Ordering compare don't affect results (since that's what this was likely due to).

The other issue is that the semantics of the benchmark changed. The churn benchmark uses CachingPolicy.byLastAccess which previously meant "keep the oldest value" and now means "keep the newest value". I think the new semantics are much more intuitive but it means the benchmark got easier because after the first run the cache gets filled with the new entries and everything is a cache hit after that.
Flipping the caching policy so it is the oldest values that are kept and every attempt to get the new values results in a cache miss still gives much better performance.
[info] Benchmark                     (size)   Mode  Cnt    Score   Error  Units
[info] ChurnBenchmark.zioCacheChurn   10000  thrpt   25  124.907 ± 3.175  ops/s
[info] FillBenchmark.zioCacheFill     10000  thrpt   25   61.965 ± 2.178  ops/s

Excellent catch, and we're still ahead so I'm happy!
On Mon, Nov 9, 2020 at 10:03 PM Adam Fraser<EMAIL_ADDRESS>wrote:

The other issue is that the semantics of the benchmark changed. The churn
benchmark uses CachingPolicy.byLastAccess which previously meant "keep
the oldest value" and now means "keep the newest value". I think the new
semantics are much more intuitive but it means the benchmark got easier
because after the first run the cache gets filled with the new entries and
everything is a cache hit after that.
Flipping the caching policy so it is the oldest values that are kept and
every attempt to get the new values results in a cache miss still gives
much better performance.
[info] Benchmark                     (size)   Mode  Cnt    Score   Error  Units
[info] ChurnBenchmark.zioCacheChurn   10000  thrpt   25  124.907 ± 3.175  ops/s
[info] FillBenchmark.zioCacheFill     10000  thrpt   25   61.965 ± 2.178  ops/s
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/zio/zio-cache/pull/3#issuecomment-724418999, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGISKZ5E2RCX2SUGP4KB3SPCUQLANCNFSM4TP76WRA
.


[IGNORE] Dummy change to trigger Travis CI build

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@2a40f54). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #27   +/-   ##
=========================================
  Coverage          ?   68.96%
=========================================
  Files             ?       80
  Lines             ?     5285
  Branches          ?        0
=========================================
  Hits              ?     3645
  Misses            ?     1433
  Partials          ?      207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a40f54...9ffed54. Read the comment docs.


NixOS error: attribute 'inputs' missing

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit 4d403dac3244aab217fb9bf17a68e9a009fcadd8  ().
Date: 2024-01-20
Tag:

flags: (if any)

System Information:
System name: Linux
Node name: nixos
Release: 6.7.0-zen3
Version: #1-NixOS ZEN SMP PREEMPT_DYNAMIC Tue Jan  1 00:00:00 UTC 1980

GPU information:
03:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Picasso/Raven 2 [Radeon Vega Series / Radeon Vega Mobile Series] [1002:15d8] (rev c2) (prog-if 00 [VGA controller])

os-release: BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues"
BUILD_ID="24.05.20240119.bbe7d8f"
DOCUMENTATION_URL="https://nixos.org/learn.html"
HOME_URL="https://nixos.org/"
ID=nixos
IMAGE_ID=""
IMAGE_VERSION=""
LOGO="nix-snowflake"
NAME=NixOS
PRETTY_NAME="NixOS 24.05 (Uakari)"
SUPPORT_URL="https://nixos.org/community.html"
VERSION="24.05 (Uakari)"
VERSION_CODENAME=uakari
VERSION_ID="24.05"

plugins:

Bug or Regression?
Bug
Description
I'm trying to add plugins to my nixos hyprland configuration, but I can't make it work for some reason.
hyprland.url = "github:hyprwm/Hyprland";
hyprland-plugins.url = "github:hyprwm/hyprland-plugins";
hyprland-plugins.inputs.hyprland.follows = "hyprland";

...

home-manager.users.user.imports = [
  inputs.hyprland.homeManagerModules.default
];

{ pkgs, inputs, lib, ... }:

{
  wayland.windowManager.hyprland = {
    enable = true;
    xwayland.enable = true;

    plugins = [
      inputs.hyprland-plugins.packages."${pkgs.system}".borders-plus-plus
    ];
  };
}

Trying to build this will keep saying that the inputs attribute is missing, but I"m not sure why.
How to reproduce
I'm not sure.
Crash reports, logs, images, videos
… while evaluating the module argument `inputs' in "/nix/store/h1lqajy420w0nbzpg11yznn3v4smx2y5-source/settings/hyprland":

error: attribute 'inputs' missing

You probably forgot to add extraSpecialArgs = {inherit inputs;}; in your HM definition. See https://nix-community.github.io/home-manager/index.xhtml#sec-flakes-nixos-module.

Thank you! That did the trick.


Support localization

Please, support localization for Unicode block description and character description. Translations are available from https://github.com/unicode-table/unicode-table-data/tree/master/loc If possible, use a gettetxt approach similar to https://pypi.org/project/pycountry/ Implementing this feature will allow users to read Unicode descriptions in their own language, other than English.
For example, now is possible only in English:
from unicodedata import name
print(name('ß'))
LATIN SMALL LETTER SHARP S

So unidecode could provide a way to translate LATIN SMALL LETTER SHARP S to e.g. German with (proposed code):
from unicodedata import name
from unicodedata2 import LOCALED_DIR
from gettext import translation
german = translation('UnicodeData2' LOCALED_DIR, languages=['de'])
german.install()
print(_(name('ß')))
LATEINISCHER KLEINBUCHSTABE SCHARFES S

This would be an awesome feature - that said, this should be part of core python. The goal of unicodedata2 is to provide a backport - not add any new functionality. I’d suggest filing a bug in the python issue tracker.

Thanks. Done with https://bugs.python.org/issue34053

Although it was received as a good idea, it was rejected as it is out of scope of the standard library. I have created this post https://groups.google.com/forum/#!topic/python-ideas/g2jj4WRVDFA to see how to get this implemented.


Refactor language.rs

Currently, adding support for a new language requires modifying the language.rs at multiple locations.
This process can be quite cumbersome and error prone (especially for new contributors).
Some shortcuts can be taken:

Assuming the ascii file to be in "../resources/language.ascii" => match case in get_ascii_art() no more needed
Using tokei::LanguageType instead of our own Enum, else (if not possible) assume that the name matches => match case in fn from(language: tokei::LanguageType) no more needed.
...

We could probably use a macro for most language definition (the paste crate is good for this). This macro could also define tests.


change dssp output format equivalent to DSSP ver.3

Problems
The current --output-format dssp is not able to handle multi character chainIDs correctly. I personally love the new mmCIF output than fixed-column traditional format. However, many users and tools still prefer the traditional format.
PR Contents
Current release of DSSP version 3 maintained by cmbi have a way to handle this. Several columns will be added to the traditional dssp format. This is equivalent to cmbi/dssp 3.1.4. When the AuthChainID is multi character, it will be changed to ">" and an additional column on the right side gives the exact chain ID. The other additional columns that we had in ver3 are also available.

My apologies, didn't reply yet. I might add this code, but it will be an option and never the default. Will be part of a new release that will extend the mmCIF output as well with more information.


Add ui-monospace to the --nc-font-mono stack

Making an Issue first since I'd like to bikeshed gather opinions on where in the stack to put it.
As of this writing, the --nc-font-mono stack is this:
--nc-font-mono: Consolas, monaco, 'Ubuntu Mono', 'Liberation Mono', 'Courier New', Courier, monospace;

I tried viewing this on my iPad, and I got Courier (New?).
Happily, changing the font stack to
    --nc-font-mono: ui-monospace, Consolas, Monaco, "Ubuntu Mono",  "Liberation Mono", "Courier New", Courier, monospace;

made it so I got .AppleSystemUIFontMonospaced (SF Mono). This looks way better on my iPad.
I suggest putting ui-monospace right before Monaco, so the line reads:
	--nc-font-mono: Consolas, ui-monospace, Monaco, 'Ubuntu Mono', 'Liberation Mono', 'Courier New', Courier, monospace;

My rationale:

Monaco is a Mac OS/OS X/macOS-only font.
Monaco has only one weight and one style: Normal. No bold, no italic, no bold italic. As much as I like Monaco as a typeface, it's not a good font.
The last version of Safari to support only Monaco and not ui-monospace was superseded in March of 2020.
Chrome and Firefox on macOS will still pick up Monaco, which is still better than any Courier font in most cases.

Thoughts?
(Also, I'd properly capitalize Monaco in passing, but that's much less important.)

I agree, even though I love Monaco.
We could just swap it with Menlo, which has four styles and seems to use the same metrics. So the change would be very unlikely to break anything.


Add SSL category

Is your feature request related to a problem? Please describe.
In Wappalyzer, there's no SSL category.
Describe the solution you'd like
Create an SSL category with SSL certs providers
Describe alternatives you've considered
x
Additional context
x

Thanks for the suggestion. I added a handful of certificate authorities in d2b11ffcbb1a50ee9a942aa3b1ceedb230d6e2a9. Unfortunately it doesn't look like there is a way to inspect certificates in Google Chrome so this only works in the NPM driver.


ImportError: undefined symbol

I used pip install python-docx and it installed without an error. But in python 2.7.5 I see:

import docx
import docx
Traceback (most recent call last):
File "", line 1, in
File "/home/keystonetech/lib/python2.7/docx/init.py", line 3, in
from docx.api import Document  # noqa
File "/home/keystonetech/lib/python2.7/docx/api.py", line 14, in
from docx.package import Package
File "/home/keystonetech/lib/python2.7/docx/package.py", line 11, in
from docx.opc.package import OpcPackage
File "/home/keystonetech/lib/python2.7/docx/opc/package.py", line 12, in
from .part import PartFactory
File "/home/keystonetech/lib/python2.7/docx/opc/part.py", line 12, in
from .oxml import serialize_part_xml
File "/home/keystonetech/lib/python2.7/docx/opc/oxml.py", line 12, in
from lxml import etree
ImportError: /home/keystonetech/lib/python2.7/lxml/etree.so: undefined symbol: PyUnicodeUCS2_DecodeLatin1

What's wrong?

it worked on my local machine running anaconda, but on my server (centos 7) I cannot install it and run it.

This looks like an lxml install error of some type. I recommend searching on 'centos lxml install' or such, maybe including the error message.
One of the common problems on Linux is not having the libxml2 and libxslt installed; this might be related to that.

python has lxml installed, and THAT imports fine. Is that different from the centos lxml?

does from lxml import etree work from the Python command line? That's the call that giving rise to the error.

from webfaction, the hosting company: they said uninstall my user lxml, and
use the system default lxml instead. This solved the problem. There was
probably some version conflict between both lxml modules on the system. I
didn't know centos 7 came with lxml, but this version does.
On Tue, Nov 15, 2016 at 2:15 PM, Steve Canny<EMAIL_ADDRESS>wrote:

does from lxml import etree work from the Python command line? That's the
call that giving rise to the error.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/python-openxml/python-docx/issues/334#issuecomment-260737757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADo11f-zf6Bs5GlPrP94BRRCHOq9acfLks5q-gTRgaJpZM4KyEDS
.

Glad you got it work @marcmaxson :)


bugfix: incorrect h5 file path

Generated h5 file is under working dir, not the same dir of xdmf file

+1, addresses #1345


[PIL-652][AV] - Routing from service banner

Please check service banner redirect for pages.
I've noticed the following:
/eligibility/activities-within-the-uk
/eligibility/group-consolidated-annual-revenues
/eligibility/service-not-suitable/under-750-million
/eligibility/service-not-suitable/not-active-in-uk
Clicking the service banner for the takes the user to
/check-progress/register-your-group


Fixed Some grammatical errors

I think these changes make the text worse. The sentence with effective awkward but the proposed change is not grammatically correct. We also use Code  as a proper noun


XMLNotificationTest: Added new callee parameter at end of notification callback function.

This PR goes with PR #969.

Do you have any other changes locally that might not be added to this PR? When I tried switching on the XMLNotitficationTest, I could see all tests passing except the 'testReplaceNode' test. We could add [Ignore] to that test for now. I think you also mentioned at one point that there were issues with the representation of the expected results (iirc - I might be wrong) in the tests, so perhaps you have fixes for that? I'm happy to merge this as-is, but I wanted to check first if there were some additional local changes you had not included here... ? Thanks!

Do you have any other changes locally that might not be added to this PR? When I tried switching on the XMLNotitficationTest, I could see all tests passing except the 'testReplaceNode' test. We could add [Ignore] to that test for now. I think you also mentioned at one point that there were issues with the representation of the expected results (iirc - I might be wrong) in the tests, so perhaps you have fixes for that? I'm happy to merge this as-is, but I wanted to check first if there were some additional local changes you had not included here... ? Thanks!

I don't have any more changes in XML (just some changes in other modules to support XML values).
As I mentioned, I didn't implement "nodeChanged" yet, and that's why the one test is failing (as well as some tests that I have).
I don't think it's going to be easy to implement "nodeChanged".

I don't have any more changes in XML (just some changes in other modules to support XML values).
As I mentioned, I didn't implement "nodeChanged" yet, and that's why the one test is failing (as well as some tests that I have).
I don't think it's going to be easy to implement "nodeChanged".

Ok, cool, thanks for confirming. I did have that replaceNode test working in the original prototype swapping implementation I started for this (see: https://github.com/apache/royale-asjs/blob/a747d311b819f3263e2a24a27066ffb58a1ad8dd/frameworks/projects/XML/src/main/royale/org/apache/royale/language/NotificationXML.as#L143) , but not sure if anything I did there helps with this approach (and I had not considered bubbling at all when I started looking at that, it was simply swapping the runtime behaviour of instances if they had notification functions assigned). I'll merge this as-is, and switch on all the notification tests except the failing one - thanks again!

Ok, cool, thanks for confirming. I did have that replaceNode test working in the original prototype swapping implementation I started for this (see: https://github.com/apache/royale-asjs/blob/a747d311b819f3263e2a24a27066ffb58a1ad8dd/frameworks/projects/XML/src/main/royale/org/apache/royale/language/NotificationXML.as#L143) , but not sure if anything I did there helps with this approach (and I had not considered bubbling at all when I started looking at that, it was simply swapping the runtime behaviour of instances if they had notification functions assigned). I'll merge this as-is, and switch on all the notification tests except the failing one - thanks again!

that's why the one test is failing (as well as some tests that I have).

btw feel free to add failing tests if you like. They can be marked with [Ignore] for now.

that's why the one test is failing (as well as some tests that I have).

btw feel free to add failing tests if you like. They can be marked with [Ignore] for now.


Eliminate use of golang.org/x/crypto to eliminate CVE-2019-11840 from security scan

Summary
Security scans flag the following issue with golang.org/x/crypto:v0.5.0 which is the latest version:
https://nvd.nist.gov/vuln/detail/CVE-2019-11840
I don't know the easiest way to do this, but it would be nice to remove the use of this module to have a cleaner security scan.

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

It turns out that this is not an issue.  CVE-2019-11840 states that this vulnerability is in all versions of golang.org/x/crypto published prior to March 20, 2019, but<EMAIL_ADDRESS>was published Jan 4, 2023 and contains the commit that eliminates this vulnerability.


PubSub: Subscriber doesn't close connections after stopAsync

Environment details

PubSub: google-cloud-pubsub-1.98.0
Ubuntu 19.04, x64
Java version: zulu<IP_ADDRESS>-ca-jdk8.0.212-linux_x64
google-cloud-java version(s): google-cloud-core-1.91.3.jar, google-cloud-core-grpc-1.91.3.jar, google-cloud-pubsub-1.98.0.jar

Steps to reproduce

Configure Subscriber
Start Subscriber, receive several messages, send ack.
Stop Subscriber, await termination.
Don's stop JVM, check connections using nenstat, for example: netstat -natp | grep java | grep 443
There is at least one established connection.
Also logs contain messages like following:

io.grpc.internal.AbstractClientStream$TransportState inboundDataReceived
INFO: Received data on closed stream

There are several runnable threads "grpc-default-worker-ELG-..."

Code example
// configure subscriber (from samples)
subscriber.startAsync().awaitRunning();
Thread.sleep(30000); //some messages are received
subscriber.stopAsync().awaitTerminated();
// do other job, check connections using netstat
Thread.sleep(Long.MAX_VALUE);

It looks like that the Subscriber instance doesn't shutdown the field com.google.cloud.pubsub.v1.Subscriber#subStub. This field isn't added to the backgroundResources, also shutdown() or shutdownNow() method isn't called. That's why grpc channel isn't closed.
Whey I call subStub.shutdownNow() using java reflection, the problem disappears.

Duplicate of https://github.com/googleapis/java-pubsub/issues/22


Trylock causes a deadlock，System restart can be unlocked

Expected behavior
Actual behavior
Steps to reproduce or test case
Redis version
3.2.9
Redisson version
3.5.0
Redisson configuration
redissonConfig.useClusterServers().addNodeAddress(address)
.setTimeout(1000)
.setMasterConnectionPoolSize(64)
.setSlaveConnectionPoolSize(64)
.setIdleConnectionTimeout(10000)
.setConnectTimeout(30000)
.setIdleConnectionTimeout(3000);
Use code
RLock lock = redissonClient.getLock(String.join("_", "taskExtSyncLock", taskId, classId));
if (lock.tryLock()) {
try{
//  ignore code
}catch（Exception e）{
throw e;
}finally{
if (lock != null && lock.isLocked())
{
lock.unlock();
}
}
}else {
//  ignore code
}
** Thread blocking , System restart can be unlocked   **
**The following figure shows the thread stack information **

Unable to reproduce it with latest version.

There is no rule to be found, which rarely happens. In the version 3.5.0 of redisson, I tried to switch the master-slave of redis, but this did not happen. I tried to use the latest version and updated it in time when I encountered the same problem

What can be determined is the result of a redis operation, because this problem occurs in more than one system at the same time

What can be determined is the result of a redis operation, because this problem occurs in more than one system at the same time

Might be related to https://github.com/redisson/redisson/issues/1966

No，The same thing happens according to the following code

public void deleteByPattern(String pattern) {
long start=System.currentTimeMillis();
RKeys keys = redissonClient.getKeys();
long deletedKeysAmount = keys.deleteByPattern(pattern);
long end=System.currentTimeMillis();
LOGGER.info("use keys time:"+(end-start)+" deletedKeysAmount:"+deletedKeysAmount);
}

ERROR LOG :

Blocked code  --> CommandAsyncService.java

Did you try the latest version?

I adjusted it to the latest version. There is no problem at present. If there is the same problem, I will let you know，Thank you for your help

Please reopen it if you encounter it again.

tody I also encountered this problem. The cancelationexception was caught during trylock, which terminated the task and could not be reproduced after restart。My service has been running steadily for a year, which is the first time #3629


Docker gogs do not respect the case when creating company and repositories directory names

Gogs version (or commit ref): latest docker

Steps to reproduce:

create company with uppercase
create repository inside the company with uppercase names

Try to fetch them using the gogs UI<EMAIL_ADDRESS>URL. The problem is that gogs shows correct uppercase URL's in Web UI but creates lowercase company and respository directory names.
So there is a bug in URL creating - it definitely should append /mount_point/gogs/git/gogs-repositories to the ssh://git@ URL server path.

Creating everything in lowercase is the expected and purposed behavior.


riscv-elf: Rework specifying when STO_RISCV_VARIANT_CC is needed

This new text both captures using registers with a specific purpose in
the ABI (like SP) and also avoids creating incompatibilities with
glibc's LD_AUDIT by being more general, as discussed on libc-alpha.

@palmer-dabbelt @fweimer-rh

LGTM, but let wait Palmer ack, I've ping him in another place :)

We gonna to merge this for moving to public review, I think we can revise the word if any feedback during public review.


Refactor CheckChallengeExample and VerifyChallenge Example. Fix error handling for invalid challange token submission.

Changelog:
-Spent some time cleaning up the check and verify challenge examples and refactored the code a bit.  (ocd?)
-Added some rough error handling to src/Requests/VerifyChallengeRequest.php  to create a dummy verifyChallengeResponse object and set its sucess value to false when an invalid challenge token is submitted. Previously attempt to unmarshall the null response to getReturnsArray() would result in an uncaught exception and prevented a valid "false" json response from being generated.
-Renamed sendChallengeResponse to verifyChallenge in  src/Api/PokemonGoApi.php  to better reflect its purpose and follow existing api convention.
-Renamed verifyChallenge function to processRequest in VerifyChallengeExample.php to better reflect its purpose.
-Fixed a small bug in the inline bookmarklet script example: missing div ending.
-A dollop of magic fairy dust

@DrDelay @NicklasWallgren Can one of you take a look over this and let me know if you can merge? The error checking addition is pretty useful if you want to try and process more than one request in a loop.


Apply Wagtail design system to the docs

Figma community version of the Wagtail design system: https://www.figma.com/community/file/1098619062654073532
Now that there is a full design system, I think it would be great to apply the styles defined in there to the docs.
I just dropping this here as a reminder. We probably want to update existing tickets to incorporate that information and add new ones where appropriate.

Some progress has been made for this via
https://github.com/wagtail/sphinx_wagtail_theme/pull/194


[BUG] Sozo doesn't generate overlays for mainnet

Describe the bug
When deploying to mainnet the Overlays aren't automatically applied, so you have to manually apply write access to the system contracts
To Reproduce
This happend while I was following the https://github.com/rsodre/512karat readme guide to deploy on sepolia/mainnet
Expected behavior
A overlays/mainnet file is expected to appear. So that the mainnet deployment behaves the same way as in local testing
Re-running sozo -P mainnet migrate apply doesn't fix the issue.
Additional context
The current work around is manually authorising read/write access to the contracts via sozo
example:
sozo auth grant writer ns:octoguns,actions --world 0x7447477a7c852c946f0b8d13ebdfe0db9e78f3de60ab799320691502b4d32a3

No more overlays in rc.


Convert some stray [] accesses to the field accessor interface.

The commit in this pull request converts some bracket accesses in slick.grid.js to getDataItemValueForColumn invocations.  See https://github.com/mleibman/SlickGrid/pull/221#issuecomment-3137162.

Thanks!


Transtale index.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thanks for fixing this page @noandersonls! :+1: :ghost:


VectorIndexSearcher: create new PrimaryKeyMap to prevent unsafe sharing

Closing in favor of https://github.com/datastax/cassandra/pull/727


[Feature] Speed measure Calculator

Description
Want to create a speed measure calculator where inputs are distance to be travelled and time to reach the destination . The average speed for the journey will be calculated based on these inputs.
Please assign me this under GSSoC'24.
Thank You.
Screenshots
No response
Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a GSSOC'24 contributor.
[ ] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

issue #1595 already open
@Rakesh9100 pls close this issue


[CELEBORN-1318][FOLLOWUP] Authenticate bearer token directly

What changes were proposed in this pull request?
I am working on the bearer token authentication integration, and meet the token base64 decode issue.
And found that, for bear token, we shall authenticate it directly.

Why are the changes needed?
For bearer authentication issue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Integration testing.

cc @pan3793

merged to main


[HUDI-7488] The BigQuerySyncTool can't work well when the hudi table schema changed  #10829

Change Logs
The code is developed by own. It is used to fix the code bug.
When the BigQuery external table with an additional connection id, the changes of schema can't use the ExternalTableDefinition.setSchema()
I change the logic to detect if there is a connection id. And use this code to fix that bug.
Impact
On influence the update BQ schema process.
Risk level (write none, low medium or high below)
low medium
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

@yihua  I don't create jira ticket. Is it necessary to create a JIRA ticket for this mr ?

@yihua I don't create jira ticket. Is it necessary to create a JIRA ticket for this mr ?

No worries, I have created one for you.

@danny0405  Thanks, bro. I still have a question. It seems that some checks were not successfully. What should I do next ?

It looks okay, all the tests passed except the supplement of the description context which is unnecessary.

@danny0405  Got it, thanks a lot.


Run scripts more than once a second

The previous workaround was to use scientific notation (e.g. script.1e-1s.sh). This doesn't seem to work in xbar though.
My specific use case is displaying a list of workspaces and highlighting the focused one. When switching between workspaces the up to 1 second delay is perceivable and quite annoying.

@strafe I do support ms internally for testing. I won't recommend it in the docs, but I'd prefer that to scientific notation wouldn't you?

@strafe How well does the plugin perform if it's being refreshed more often?

@strafe How well does the plugin perform if it's being refreshed more often?

Seems fine for me, personally I'm refreshing a script that takes roughly 60ms to execute every 200ms. What I would say is that I believe this is really useful functionality for certain users, but when it comes to plugins in the official repository there should probably be a lower bound on refresh rate (not below 1 second?) because depending on the script/environment I'm sure this could cause issues.

@strafe You've articulated my thinking perfectly.
OK, I'll do a release and you can use filename.500ms.sh

@strafe please try v2.0.27-beta... or above.

Closing now that ms is a supported unit.

Closing now that ms is a supported unit.

Thanks for getting this in so quick, will test it out soon!


AKMOD_PRIVKEY_20230518 is not documented

Build fail without much information on the missing AKMOD_PRIVKEY_20230518 secret. Should this be changed back to AKMOD_PRIVKEY or documented and renamed to something more meaning full?

Our expected use case for this repo was not for others to use its contents, or clone it for custom use, rather to build OCI images which are used as FROM sources for downstream images. But apparently, it is is getting cloned and used.
However, it's a good point that if this fail due to a missing secret it could be confusing.  No the secret probably won't be renamed, but you are welcome to create a PR which adds to the README to explain that the key is provided via a secret in our github actions workflows. I'd suggest that a user cloning this just change the secret variable to something of their choice, but they of course use this variable name.


Add Windows support

Fixes #3

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Using toolchain directly in this manner is deprecated.  Consider using the compilers outlined here.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@xhochy could you please rebase from main?

there is an error for windows vs215
make: *** No rule to make target 'ccache.exe'.  Stop.
make: *** No rule to make target 'install'.  Stop.

@ocefpaf , @mingwandroid
Do you have any hints here?

we got windows in #31


fix: txdescriptor event and error generics

Changes the generic to use array instead of tuple because if we use tuple we always need to have 1 element. If we must have 1 element, it prevents a "fire and forget" usage of the tx where the user doesn't care about the events or errors.

In retrospective, a better solution would have been to change the typing of Tuple to:
type Tuple<T> = readonly [...T]


Refactor areas of the code that have high cyclomatic complexity

Evaluate the CODE_METRICS.md file and determine which areas could use improvement, based on the highest levels of cyclomatic complexity. Refactor into smaller, more manageable / testable bits.

Going to close this issue as the latest set of PR's have reduced all of these down from the warning level from the code metrics pipeline see below:


create readthedocs page with existing documentation

Probably needs to be done after the v0.3.0 hackathon.

Test instance is running at https://cnlp-transformers-test.readthedocs.io/en/latest/

can this be closed?


Refactor TestGesture

Moves TestGesture into test_pointer.dart and makes it more
self-contained.
This is part of a general refactoring of flutter_test.
Depends on https://github.com/flutter/flutter/pull/3459

@yjbanov

LGTM


[documentation] API docs from tsdocs

May not be great formatting, but investigate using TSDoc to add API-level documentation

At the very least some pre-commit or GitHub actions checks to ensure the documentation is up to date would be great

Docusaurus doesn't allow for autogenerated documentation :(

Closing because linting rules are implemented in #59 and already run in CI


Set up unit parser

We cannot use the units which are submitted by BioCatHub directly in enzymeml. Therfore we need to convert them into enzymeMl conform units
Superissue: #18

https://github.com/BioCatHub/bch_enzymeml/blob/639d23f5d710436fcfba4768ef898ddff9b97f64/bchenzymml/write_read_enzymeml/write_enzymeml/unit_builder.py#L11-L26

UnitBuilder class was created to search through the units
UnitBase class is the internal storage for all known enzymeML and biocathub units


Update PPP formatting

Added page break to ensure heading is on same page as content

Codecov Report
Base: 78.42% // Head: 78.42% // No change to project coverage :thumbsup:

Coverage data is based on head (a74e3c6) compared to base (3806ede).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #208   +/-   ##
=========================================
  Coverage     78.42%   78.42%
  Complexity      849      849
=========================================
  Files           118      118
  Lines          2568     2568
  Branches        324      324
=========================================
  Hits           2014     2014
  Misses          428      428
  Partials        126      126

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Build depending on source code only

Build process should not run on all file changes (e.g. 385f514dd41e98046c9ec1cc6830b1348e4773d1)
Instead of running on all push and pull requests, we should specify file paths in the workflow files.
Add something like the following in .github/workflows/release.yml
on:
  push:
    branches: [ master ]
    paths:
      - '*.py'
      - 'assets/**'

maybe also include **/*.py

and also updates to the workflow


2473 add magic link alternative signin method

Context
Add magic links as a fallback for when DfE Sign in is down.
Changes proposed in this pull request
Add gems (mail-notify, devise and capybara-email)

Add mail-notify gem to support the GOV.UK Notify API. Allows templating logic to be used in source code, instead of relying on Notify templates (personalisation).
Add devise gem in order to generate magic link token, so that we can authenticate users.
Add capybara-email gem in order to test that a magic link is received in an email.

Add migrations

Add magic_link_token column to the Users table.
Add magic_link_token_sent_at to the Users table.
Add AuthenticationTokens table.

Add email preview and templating functionality

Exclude preview from production.
Add generic notify template id.
Add magic mail preview.

Add magic user journey

Add logic to create magic link token.
Add view for entering email.
Add view for checking email.
Add feature flag (switched off in production and staging).
Add redirects if feature flag enabled.

Add feature end to end test with happy path and sad path
Guidance to review

Navigate to localhost:3000/rails/mailers/magic_email_mailer/magic_email to inspect the email preview.

Change your development.yml settings to the following to replicate the production environment:

features:
use_dfe_sign_in: true
dfe_sign_in_fallback: true
use_ssl: true
govuk_notify:
api_key: please change me (using notify)

Add yourself as a user to your local database with an email that you have access to or change the email on one of the personas to yours.

Start the sidekiq server by running bundle exec sidekiq

Navigate to /sign-in and check that you are redirected to /sign-in/fallback.

Enter your email address and click Continue.

Check your email and click on the magic link and you should magically be signed in.

Repeat the last three steps above with dfe_sign_in_fallback: false to ensure you can use your original method of authentication when the feature flag is off.

Closing this for now as it’s been deprioritised
@gpeng @B-Bonner @dankmitchell


Data augmentation errors

I got "preprocessing failed" errors when trying to use data augmentation with the re-imported exported dataset.  Reduced the augmentation. Failed a 2 or 3 times. Went down to only horizontal selected and it worked.

still failing

Needs testing with updated version. Should be pretty much the same but w/ new screenshots.

closing this because the old version is not relevant.  Needs retesting and doc/update w/ the current version though (separate issue).


Implement a direct propagation from minos.networks.Producer to minos.networks.Consumer for Event entries

Closing this issue as it is moved to https://github.com/minos-framework/minos-python/issues/79


Create application title image

This will be the main title for the application, shows at launch and every time the user returns to the home screen

Possible logos/title images:

transparent png version:

1st logo chosen.


Update unlabelled description

It is now:

:question: Unlabelled

I decided to leave it as it was and update release-plan to notice the other default 👍


[FLINK-6149] [table] Add additional flink logical relation nodes and …

…separate current optimization to logical and physical optimize
This PR introduces an additional layer named flink logical plan which consist of couple flink logcal relation nodes. The reason why we want to add this is explained in the parent jira: https://issues.apache.org/jira/browse/FLINK-6066. This is the first sub task to add all needed data structures and make all the tests passed.
The core changes are as following:

Add bunch of FlinkLogicxxxxx to represent flink logical nodes, corresponding to each calcite basic rel nodes like Aggregate, TableScan.
Make current DataSetxxxx and DataStreamxxxx nodes to represent the first version of physical nodes.
Make almost every active rules included by logical optimize, except the ones trying to translate logical nodes to corresponding DataSetxxxx or DataStreamxxxx. The later one become the first version of physical optimize rules.

The following task would be make code reused as much as possible since some logic like computeSelfCost is almost the same for some logical and physical nodes.

Hi @fhueske , sorry for taking it so long to update this PR.
Looks like it has so many conflicts with master now, once you are ok with all the changes, i will rebase it to master.

Thanks for the update @KurtYoung. I'll have a detailed look at the changes later today.

@fhueske I have rename the package and update the union description.

Hi @KurtYoung, thanks for the update!
I think this PR is good to merge.

Rebased to master and will merge after build check

@KurtYoung, @fhueske  This PR violated work with null nodes:
`
org.apache.flink.table.api.TableException: Cannot generate a valid execution plan for the given query:
LogicalProject(a=[$1], cnt=[$0])
LogicalJoin(condition=[<($1, $0)], joinType=[right])
LogicalProject(cnt=[$0])
LogicalFilter(condition=[<($0, 0)])
LogicalAggregate(group=[{}], cnt=[COUNT()])
LogicalProject($f0=[0])
LogicalTableScan(table=[[B]])
LogicalTableScan(table=[[A]])
This exception indicates that the query uses an unsupported SQL feature.
Please check the documentation for the set of currently supported SQL features.
at org.apache.flink.table.api.TableEnvironment.runVolcanoPlanner(TableEnvironment.scala:267)
at org.apache.flink.table.api.BatchTableEnvironment.optimize(BatchTableEnvironment.scala:235)
at org.apache.flink.table.api.BatchTableEnvironment.translate(BatchTableEnvironment.scala:265)
at org.apache.flink.table.api.scala.BatchTableEnvironment.toDataSet(BatchTableEnvironment.scala:140)
at org.apache.flink.table.api.scala.TableConversions.toDataSet(TableConversions.scala:40)`


HOTT-2919 Use nested set for subheadings

Jira link
HOTT-2919
What?
I have added/removed/altered:

[x] Use nested set for subheadings endpoint

Why?
I am doing this because:

We want to start utilising nested set

Deployment risks (optional)

Mid - feature flagged, but does change the implementation of an important endpoint

Already run a comparison script on ~60% of json responses and they are the same so pretty happy from that PoV - obviously its feature flagged so merging doesn't mean its necessarily getting turned on just yet


Possibility to install a subset of countries

Hello,
First of all, thank you for creating this amazing library! 👍
This is not an issue, it's just an idea/feature request. We are deploying our Python applications in AWS lambdas, lambdas are all well and good but they have their limitations as well, and one them is the total package size which is limited to 50 MB limit. We tried to use Workalendar as one of our dependencies but it, unfortunately, blew up our 50 MB limit. There are ways to work around it, we are aware of that, but those workarounds also involve an increase in the lambda cold start time.
Our use case is very simple: we just need to know the working days here in The Netherlands. Therefore we "fixed" our issue by just extracting the Dutch working days into a vendor library. But I was wondering that this must be a very common use case for other people as well, I mean, I believe that most people just need to know the working days of their own country or maybe a few extra ones. Therefore, most of the code (and dependencies like ephem and lunardate) being installed is just not being used at all. I think that #302 is related to this
I think that this could be solved by splitting this library into several, one core library plus several extra ones for each country. The installation could be done by using the Setuptools extra_requires, e.g.:
setup(
    name="workalendar",
    ...
    extras_require={
        'netherlands':  ["workalendar-netherlands"],
        'germany':  ["workalendar-germany"],
        'europe':  ["workalendar-netherlands", "workalendar-germany", ...],
        ...
        'islamic':  [...],
        'all':  [...],
    }
)

One drawback of this approach is that the virtualenv might get convoluted for people that require many countries. This might be a problem because many people are doing pip freeze > requirements.txt. One way to work around this would be to write some scripts that automatically vendorize the dependencies and publish pre-built packages to PyPI. Anyway, I understand that this is a huge change to the project, so I think it is probably unfeasible?
Thanks!

I understand that this is a huge change to the project, so I think it is probably unfeasible?

You're probably right here: it's a huge huge huge change.
As an illustration, right now, there are 174 calendars registered in the ISO registry, and there are a lot of calendars that are not registered in it (Scotland regions, FranceAlsaceMoselle, etc). And a lot of countries are missing in this library, even if we are improving it on a regular basis.
Now... if I wanted to do what you're suggesting, this would mean to create at least 174 individual  Python packages. And maintain them in a vast organization, and put up test suites for all of them, individually and when they're combined.
Let's imagine we're fixing a bug in the "workalendar core" library, it would require to test every single calendar from our catalog in their own dedicated test suite. The more you have independant pieces that are related to each other, the more likely you'll have one of them that would fail, and while you're fixing the problem here, you're triggering another somewhere else.
And then in the extra_requires dictionary in our setup.py script, we would have to maintain a list of all the countries, one by one, and then the list of all the countries that belong to Europe, all the Asians, Americans, etc.
You're also suggesting to have an "islamic" "extra". Did you know that some countries are using both Islamic and Christian calendar? (Angola and Benin, for example). Where should we add them? both in "islamic" and "christian"?
Where would we stop the number of subdivisions?
I guess that the number of combinations would grow exponentially... and then the complexity of the setup.py and then... it's too much error prone.
And I'm not mentionning the fact that external contributors, and they're sometimes beginners in Python, would have to manually add their new countries to the various lists in this setup file. Sometimes it's even hard to have flake8-ready code, so I don't think it'd be a good idea to add this burden for contributors.
I'm going to close this issue, feel free to reopen it if you can find an alternative solution, but as far as I'm concerned, I don't think we can switch to this "individual calendar mode".


[CWS] increase windows ETW channel size

What does this PR do?
This PR removes some unused config, and bumps the default channel size to 16384
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Enhancement Request - If no Summit Events Appointment Types are active, remove Appointment Options Page

Users in UST Events noticed that if Appointment Type records are on an Event, and even if no Appointment Type records are Active, the Appointment Options page will display during the registration path.  Can this page be removed if no Appointment Type records are active.

Included in beta release <IP_ADDRESS>

Included in production release <IP_ADDRESS>


AttributeError: 'Agent' object has no attribute 'train_online'

Rasa Core version: 0.11.3
Python version:  3.5
Operating system (windows, osx, ...): Windows
Issue:  agent.train_online( training_data_file,
AttributeError: 'Agent' object has no attribute 'train_online'
Content of domain file (if used & relevant):
language: "en"

pipeline:
 - name: "nlp_spacy"
 - name: "tokenizer_spacy"
   model: "en"
 - name: "ner_crf"
 - name: "intent_featurizer_spacy"
 - name: "intent_classifier_sklearn"

@neerajb1 refer to the document http://www.rasa.com/docs/core/0.11.2/api/agent/, there is no "train_online" attribute for Agent instance, use agent.train(data) to training stories

Thanks!  It's work

You should now use the train script to do online training, see here: https://github.com/RasaHQ/rasa_core/blob/master/rasa_core/train.py#L80


FIGMA Look over/Update the support page

Work together and decide how you want to update the support page in Figma. I'm guessing it should be dropdown text in the "volunteer" "donation" "fundraising". Or if you have other suggestions?

[ ] Checked by QA

Hello!
We have had a good meeting today were we decided on a design. The plan is to keep the original design as intended but go through and fix the components so the drop down menus works as intended. While also adjusting the design to accommodate the donation methods that has been ultimately decided upon.

Dropdowns fixed as of Oct 1. Waiting for response from client to add payment options.

Moved this back to ready to be picked up, until we have a response from the client. They have decided about paypal and vipps as far as i know.


Add lib declaration for RegExp#unicodeSets

Fixes #57055

I think this is good to go

Some tests failed last time CI ran. Does this need to have main merged into it? Or is it the code itself that is failing?

Mmm, apparently there are other config files that need to be changed but I'm unaware of.

Wow, the number of baselines updated by an extra lib is surprising.

@sandersn Now that 5.4 is out, will this be merged soon?


Android 13 Support?

Does this library support Android 13? My module that uses this library is throwing errors saying that a function I want to hook does not exist even though I have verified that it does, and I don't know if I can rule out this library as the source of the problem.

@DavidBerdik Can you provide an error log?

@keta1 I have an issue open on my module that contains a stack trace for the issue I am encountering. Perhaps it would be useful for resolving this? - https://github.com/DavidBerdik/MACsposed/issues/1
I can also share an LSposed log dump if you want.

@keta1 Here is an LSposed log dump in case it is useful.
LSPosed_2022-08-18T00_02_26.295548.zip

@DavidBerdik This log contains a lot of private information
Note the desensitization

@keta1 I know it contains information about things like what Magisk modules you have installed and can reveal some detail about Xposed modules you have installed and possibly apps, but at least in my case, none of that information is really all that sensitive. For future reference, which things should I watch out for?

https://github.com/DavidBerdik/MACsposed/blob/master/app/src/main/java/com/berdik/macsposed/hookers/SystemUIHooker.kt#L25
https://github.com/LSPosed/LSPosed/blob/master/core/src/main/java/de/robv/android/xposed/XposedHelpers.java#L522

@keta1 The method does exist though.
https://cs.android.com/android/platform/superproject/+/android-13.0.0_r3:frameworks/base/packages/SystemUI/src/com/android/systemui/qs/QSTileHost.java;l=383

It looks like the error is not related to EzXHelper
You can find the method through the xposed api

@keta1 Isn't that what EzXHelper is doing though? Anyway, I'll investigate, but it just seems odd. The function was found in Android 12, but not 13 even though, as far as I can tell, nothing has changed. The other function hooks that I have also don't seem to work, but they do not throw any error like this one.

Presumably your rom may have modified the code of the system ui
try invoke getDeclaredMethods
and print each one to debug？

@keta1 Isn't that what EzXHelper is doing though? Anyway, I'll investigate, but it just seems odd. The function was found in Android 12, but not 13 even though, as far as I can tell, nothing has changed. The other function hooks that I have also don't seem to work, but they do not throw any error like this one.

EzXHelper provides its own api for finding methods
and does not use his
Instead, it uses the xposed api's

Presumably your rom may have modified the code of the system ui

I am using the official Google factory image on a Pixel 4a. I would think that the System UI code for that would be the same as AOSP.

try invoke getDeclaredMethods and print each one to debug？

I will. I had not thought to try that.

EzXHelper provides its own api for finding methods
You didn't use it
Instead, you used the xposed api's

But isn't EzXHelper just wrapping the Xposed API for callMethod()? - https://github.com/KyuubiRan/EzXHelper/blob/aceb33fcacb82c825e316e34ed91f6decefe6802/EzXHelper/src/main/java/com/github/kyuubiran/ezxhelper/utils/MethodUtils.kt#L602

@keta1 In case you are curious, I managed to get it working. Apparently, Google's AOSP code dump for Android 13 does not have all the changes related to the System UI included in it. I had to decompile the System UI APK from 13 to figure out what to hook.


No such files as referred in readme - theme.js, theme.css

Trying to install this self-hosted.
The instructions refer to  theme.js, theme.css  files which is not available.
It appears you need to build it using grunt?
It seems like you need to install:

node
npm
grunt

All that just to build this Jenkins theme? It seems like a lot of effort for just a theme.
Node, Npm , Grunt does not come standard with Debian for example and you have to build node from source. Just to use this Jenkins theme!
Or I am missing something?
If not, can you please provide built package? Thank you!

workaround: Given that this is such a straight forward project, I was able to simply "build" each file from the command line like the following (it appeared to work):
cat *.js > theme.js
cat *.css > theme.css
I had to take that approach (before I stumbled on this issue/post) because the node.js install was broken for debian wheezy.


Research compatibility of the format of serialized events between the versions of the given serialization library

https://github.com/altoo-ag/akka-kryo-serialization#features -> for Kryo, the approach is reasonable/semantic - compatibility of binary format is only guaranteed b/w patch/minor updates, but not major updates.
The end result of this task should be another row in the table in README.md, with a comparison of the documented approach to compatibility b/w libraries.
If any library does NOT mention anything about its compatibility guarantees, we should NOT check it experimentally. In fact, it's a warning sign — if they don't document such guarantees, do they even care about them in the first place?

It seems Circe is not afraid of breaking stuff when it comes to binary compatibility (https://github.com/circe/circe/issues/1754), but there is nothing on format compatibility.

 I browsed through documentation of all serialisers listed in README.md and didn't find any explicit information regarding our concern.

Whooops not good 😅 ok so only akka-kryo stated anything in this respect?

Exactly, we can only bet which serializers are less likely to change the format in the long run. Automatic testing is a must in this aspect.


Make LCMS C++17 compliant

It is not the case for now, mainly because of the 'register' keyword used in the 'lcms2.h' file.

Please use the code in github. There is a #define for this.


How to guard against duplicate anchors?

I'm trying to use toc.js with an application that allows users to edit HTML saved in a DB with Summernote, and I'm getting duplicate anchors after I save HTML to the DB and reload the content.

Why I'm getting this makes sense. It appears that the HTML is loading, toc.js adds an anchor, and when changes are saved, the anchors are being saved, too. The next time the HTML is edited, the anchor span tags get prepending again. Is there a way that toc.js can use anchor elements that match if they're already in the container element?
Here's how I've got my setup configured.
$('#toc').toc({
        selectors: 'h3,h4,h5,h6',
        container: '.col-sm-9 .note-editable.panel-body',
        prefix: 'toc',
});

I found a workaround without having to modify the jQuery widget. Maybe someone will be in a similar situation and find this useful.
toc.js won't append a span tag if the heading's ID matches the result of the anchorName method. So before I initialize toc.js, I preemptively assign all the heading IDs with the anchorName method.
var container = '.col-sm-9 .note-editable.panel-body';
var selectors = 'h3,h4,h5,h6';
var prefix = 'toc';

$(container).find(selectors).each(function(i, heading) {
    if (!heading.id) {
        var anchorName = $.fn.toc.defaults.anchorName(i, heading, prefix);
        $(heading).attr('id', anchorName);
    }
});

// Initialize toc.js as normal.
$('#toc').toc({
    'selectors': selectors,
    'container': container,
    'prefix': prefix,
});


Using the .bat to lunch elden ring cause the framerate down to 3fps

please don't open issues twice


Include new IT UCR in icds pillow

buddy @proteusvacuum I should have done this for https://github.com/dimagi/commcare-hq/pull/18773/

deployed this


Created CollabPost page similar to figma design.

Implemented the CollabPost page based on the provided Figma design.
Ensured the layout is responsive across various screen sizes.
Applied consistent styling to match the Figma design, including colors, padding, and font sizes.
Used react-native-vector-icons for icons in the search bar and footer navigation.
Ensured clean, readable, and maintainable code with TouchableOpacity for clickable elements.

@siddharthisrani  can we connect on meet for 5 min?

@RohitGupta1237  Yeah, sure... It's a pleasure to contribute more and work on this project
Screen recording Drive link :- https://drive.google.com/file/d/1MtHQSGmBcWCZL10q75f8Vc9oGZ-OSm0E/view?usp=drivesdk

@siddharthisrani  https://meet.google.com/bzo-hdgg-dwy. if u can join this meet

@RohitGupta1237 Actually i not in good network right now using mobile network. Hope you understand

@siddharthisrani  ya no issues come checks are failing if u can fix them and will create more issues like this if u work on them

@siddharthisrani
collab post code
https://drive.google.com/drive/folders/1EckmkDR7I9eXL49z1Ix9zDk0W5jkfAbb?usp=sharing
campaign detail page
https://drive.google.com/drive/folders/14UTdwPxppVUlQDh8SeHlA0hRAnnO3lwd?usp=sharing
collab form
https://drive.google.com/drive/folders/1T0kybHldttZxVGEMmMIZ-NK0caMj8rVB?usp=sharing

@siddharthisrani  if u can add a screen recording also

@RohitGupta1237 It was the CollabPost code that I had shared in the screen recording with the Drive link. Please provide the Figma designs for the Campaign Details Page and the Collab Form. I am going to work on them and would appreciate your feedback.

@siddharthisrani  https://www.figma.com/design/B0vUURYrBFJGg8j8CNoLqn/designs?node-id=766-175&t=qJg6e2crojriVa8D-1

Screen Recording Drive link of CampaignDetail and CollabForm :- https://drive.google.com/file/d/1eRBVKqbr25T3LdU0IfclQml8R98Jqa43/view?usp=sharing

@siddharthisrani  hey can u take latest pull and raise pr again

@RohitGupta1237 yes i have pull the latest ,After pull ..In App.js there is only import left of all my three components and in <Stack.screen> they got vanished which i added so should i add that again and then raise the pr or is it ok?

yes raise the pr again if possible

On 10-Jul-2024, at 7:45 PM, siddharthisrani @.***> wrote:
@RohitGupta1237 https://github.com/RohitGupta1237 yes i have pull the latest ,After pull ..In App.js there is only import left of all my three components and in <Stack.screen> they got vanished which i added so should i add that again and then raise the pr or is it ok?
—
Reply to this email directly, view it on GitHub https://github.com/Kajol-Kumari/InfluMart/pull/190#issuecomment-2220631754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXGRYBPFCXTVV4242MRLCALZLU6W3AVCNFSM6AAAAABKNR2PGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRQGYZTCNZVGQ.
You are receiving this because you were mentioned.

@RohitGupta1237 Yes raised with updation .

@RohitGupta1237 What happened? any update on merging the code?

Hii @RohitGupta1237 Any update on my PR? It was not merged and issue is closed?

@siddharthisrani  Hey there is slight change in plan so that issue we won’t be taking for now for u we can create a simple colour fix issue and make it level 3 to save ur time and efforts if u r ok with this ..

@RohitGupta1237 Yes i am ok with it

@siddharthisrani  hey issue created


Enhance distributedLoad

Summary
Currently the max parallel jobs for distributedLoad is controlled by ACTIVE_JOB_COUNT_OPTION. For folder which contains many small files, such as imageNet, this number is not easy to define.
If the number is too large, many jobs will failed (due to the requests limitation of UFS). If the number is too small, the load speed will be impacted.
Here we propose a policy to adjust this number automatically.
Policy
The basic idea is like TCP congestion control.  https://en.wikipedia.org/wiki/TCP_congestion_control
If some job failed at a period, we set the active_job_num to half of original value and set the thredhold to this number.
If all jobs are succeed at a period,  and current number under the threshold we double the active_job_num,  else we linear increase the active_job_num.
Required init parameters:  ACTIVE_JOB_MAX_NUM, ACTIVE_JOB_INIT_NUM, ACTIVE_JOB_INCREASE_PACE  , RUNING_JOB_MAX_NUM
ACTIVE_JOB_INIT_NUM = init_active_job_num
ACTIVE_JOB_MAX_NUM = max_active_job_num
ACTIVE_JOB_INCREASE_PACE  = increase_pace
RUNING_JOB_MAX_NUM = running_job_max_num

active_job_num: current number of active jobs, the initial value is ACTIVE_JOB_INIT_NUM
activate_job_threshold, the threshold for active job
active_jobs: a queue for all active jobs

The main load porecss:

for file_name in load_file_list
   create job with corresponded file name
   if active_jobs.size() < active_job_num
     add job into active_jobs
   else
     wait a while
   end
end
drain active_jobs, waiting for all job finished.

submission process
using multi-thread, for each thread:
get job from active_jobs
submit job to job master

adjust active job number process
run in another thread
while !finished
  wake_up every second
  completed_job_num
  failed_job_num
  for job in active_jobs
    if job in completed status
      completed_job_num++
    else if job in failed status
      failed_job++
    end
  end
  if failed_job != 0
    active_job_num = max(active_job_num/2, init_active_job_num)
    activate_job_threshold = active_job_num
  else if active_job_num - completed_job_num > running_job_max_num
      // too many jobs in running status, don't adjust the nunber
  else if active_job_num > activate_job_threshold
     active_job_num  = active_job_num  + ACTIVE_JOB_INCREASE_PACE   // linear increase
  else
     active_job_num   = min(active_job_num  * 2, ACTIVE_JOB_MAX_NUM) // double the number
   end
end

@apc999 @LuQQiu Please help to review this design

Tested in our bed, this policy works well for small files. For 1 millions files, the failed tasks is around 100

@Binyang2014 Some comments for the design

Can we make it optional, and recommend to be used when loading small files?
I think our current distributedLoad command has retry mechanism for the failed tasks, can your design maintain the retry logics especially when load failed because we launching too many active jobs?
Can we maintain the backward compatibility that the older version bin/alluxio distributedLoad can work with this new version distributedLoad command just like before?

Other than these three comments, the design LGTM. It's awesome to have this automation functionality

@Binyang2014 awesome idea. one question i had was whether you have any thoughts on fairness. It does not have to be addressed now but it would be nice to give it some thought.
The current design allows for a single distributedLoad job to overwhelm the entire ufs. How do we adapt if there are multiple distributedLoad jobs loading from different ufs at the same time? i think the maxJobNumber might need to be per mount point? or per ufs?
have you done any tests or simulations where two distributed load jobs are happening at the same time?

For Lu's comments:

Sure, we can make it optional. And I think it works for both small file and large file. For large file, since we set the running_job_max_num, the number of job will be limited. Maye we can give some recommend init parameters for small file scenario and large file scenario.
For current design, the retry logic is kept. We only treat the task failed if it reaches the max retry number. Otherwise, we will treat it as an active job.
Maybe we can add a option for current distributedLoad command. Such as bin/alluxio distributedLoad -dynamicAdjustOptoin {activeJobInitNum: xx, activeJobMaxNum: xx} to achieve backward compatibility.

For @yuzhu's comments:
Actually, I don't think much about fairness, I just put some thoughts here.

The fairness issue may need be handled by external services. For many scenarios, distributedLoad happens before real workload scheduled to the compute cluster. And the scheduler has the whole view of the workload (which workload will be scheduled first and which job has the high priority ). Then job scheduler need to decide how to allocation resource for distributedLoad. For alluxio, we need to expose some interface for scheduler to allocate resources (such as maxJobNum...). And report the current status to let external scheduler adjust its' decision.
For which resource need to be exposed to scheduler, it's a bit complex. maxJobNum may be one dimension (compute dimension), and the consumed bandwidth  maybe another. (We need to make sure the prefetch job not consume too much bandwidth which may affect current running jobs)

The design LGTM, @yuzhu PTAL thanks!

@Binyang2014 the scenario I imagined is as follows. it will  limit our bandwidth unnecessarily.
Imagine two concurrent distributedLoad jobs,  each accessing a different ufs.
If the first one reaches network capacity, and starts to error, it would prevent the second job from increasing the maxJobNum even if it is no where near the limit

Hi @yuzhu. for each distributedLoad job. The bandwidth consumption can be caped by parameter ACTIVE_JOB_MAX_NUM. And from my point, this parameter should be select by admin or job scheduler based on current cluster status to avoid occupy too much bandwidth.
For alluxio, it may need to report some metrics to let scheduler/admin do this decision.
And for future enhance, the  ACTIVE_JOB_MAX_NUM parameter may not enough to cap the bandwidth, we need to investigate and add more parameters to control this. (just like we can limit the cpu/memory/disk usage for container)

yeah, I think in general multi tenancy/ QOS concerns in job service requires further investigation. the current improvement LGTM, as we are no worse than before. @Binyang2014


[Units] Put flux in milliJansky

And warn the user when data has nearest source close enough

Fixed in #452


WIP Type Annotations for Trinity

DO NOT MERGE: THIS IS A WIP
This is an attempt to fix #386

FWIW, #409 changes our mypy invocation so that it checks untyped defs as well. You probably want to rebase your work on top of that

#409 was just merged so this can now simply be rebased from master

#409 was just merged so this can now simply be rebased from master

Will do. I'll batch some more changes together before I clean things up with the intention to get properly reviewed and merged if that sounds ok.

Ok, so I learned that with Python 3.5 the only way to have type hints for variables are these ugly comment annotations.
self._chain = []  # type: List['CancelToken']

This may be a dumb question but being new to Python I just have to ask those: Do we need to stay Python 3.5 compatible?
And if the answer is yes, do you want me to add these (ugly! cough) comment annotations or rather leave out the type annotations for variables / instance members?

I went ahead and dropped the type annotations from all variables (including instance members) where they could be dropped. There was one case where I had to add one, so I went for the comment type annotation to stay Python 3.5 compatible.
https://github.com/cburgdorf/py-evm/blob/8d565f43b3522b4b543ec5f8c9930d9ebda899f5/trinity/utils/db.py#L4
Still, I think if there's no strong reason to keep the Python 3.5 support I'd rather drop it and went for proper type annotations.

@pipermerriam This went green now.
Notice that this only adds type annotations for Trinity/utils. If it's cool with you, we could take this PR and I send follow up PRs with batched type annotations. Not too many but batching makes it possible to have things more digestible on my end since I'm
a.) juggling between different projects
b.) still working my way through Python.
I used the following strategy for now:

add type annotations for all function params and return values
don't add type annotations for variables / member variables
if scenarios where type annotations for variables could not be omitted I used the comment annotation to stay compatible with python 3.5

Do we need to stay Python 3.5 compatible?

Yes, py35 compat is required

And if the answer is yes, do you want me to add these (ugly! cough) comment annotations

Yes, that is the appropriate style to use for them.  I would prefer we annotate variables but I don't have a direct reason why other than that it seems like it should help detect certain classes of issues.

If it's cool with you, we could take this PR and I send follow up PRs with batched type annotations.

This approach seems good.  I like many smaller PRs rather than one monstrous one.

Yes, py35 compat is required

Understand. Do you mind to elaborate on the reasoning? Not trying to argue against it. I just want to learn.

I would prefer we annotate variables

Here's how one would usually approach this in TypeScript. It's quite a fair comparison because TypeScript also adds type annotations to a dynamic language (JS) and has similar features as mypy such as type inference.
I wouldn't add type annotations in cases like this:
foo = 'str'

Due to the type inference, mypy is smart enough to disallow this.
foo = 'str'
foo = 5

Raises an error as expected
$ mypy test.py
test.py:16: error: Incompatible types in assignment (expression has type "int", variable has type "str")

So, adding type annotations doesn't add any safety in this case. I'd consider it rather noisy tbh.
Especially when you keep in mind that we have to use Py35 compatible comment annotations. Comment type annotations are rather fragile compared to proper ones.
Consider this:
foo = 4 # ttype: str

mypy checks this without errors even though we obviously intended this to be of type str. It also doesn't catch that we mistyped anything. It will simply see this as an int.
Let's take a look at another case and imagine we have a class with an instance variable that is initially set to None. This case is more tricky as None doesn't let mypy infer the type.
However, mypy can still infer the type based on the context.
class Foo ():
  expected_to_be_int = None

  def blows_up(self) -> float:
    if self.expected_to_be_int is not None:
      return self.expected_to_be_int / 2

    return 0

val = Foo()
val.expected_to_be_int = 'bar'

This blows up as expected
$ mypy test.py
test.py:11: error: Incompatible types in assignment (expression has type "str", variable has type "None")

Also mypy will tell us when it needs our help because it can't infer the type.
val = []

$ mypy test.py
test.py:1: error: Need type annotation for variable

With all that in mind, I recommend to only add the comment type annotations when mypy explicitly asks for them.
If you agree with that, this PR could probably get merged. If you insist on adding comment type annotations for all variables I'll update the PR. Your call :)

py35 compat is required: Do you mind to elaborate on the reasoning?

Not at all.  And now that you've said it, I realize that py35 support is only required for py-evm.  Trinity can be py36 only and I think I'm good with that.  (ping @carver @gsalgado )
Reason that py-evm has to support py35 is that Web3.py supports python3.5 and it's EthTester provider is based on the eth-tester library, which has a py-evm backend, and thus, py-evm requires support for py35.
Also, we have sort of been taking our cues loosely from Django in terms of dropping support for older versions of python.

With all that in mind, I recommend to only add the comment type annotations when mypy explicitly asks for them.

I'm good with that.  I'm kind of new to type annotations so I do appreciate you laying that out for me as I wasn't aware of any of that TBH.   ping @gsalgado to get a chance to veto this as he knows more about this domain than I currently do.

And now that you've said it, I realize that py35 support is only required for py-evm. Trinity can be py36 only and I think I'm good with that.

My other reference point is: what is the python installation in the most recent Ubuntu LTS distro. I expect the new one in April will be py36, since the interim releases are already on py36. So I'm good with 36 for Trinity. :+1:

I completely agree there's no need to add type annotations for variables when mypy can infer the type -- in the same way we don't add type annotations for the self argument of methods. That's what I've been doing for the p2p package

Sounds good! Then I suggest we merge this and I'll send a follow up PR to drop Python 3.5 support for trinity and use proper type annotations (as in, not the comment annotations) for variables except for the cases where its obvious for mypy to infer the type.

@pipermerriam

Reason that py-evm has to support py35 is that Web3.py supports python3.5 and it's EthTester provider is based on the eth-tester library, which has a py-evm backend, and thus, py-evm requires support for py35.

Makes sense. Thanks your for explaining it to me.

I'm kind of new to type annotations so I do appreciate you laying that out for me as I wasn't aware of any of that TBH

I'm super happy I can be helpful here. There's tons of stuff I'm lacking to know when it comes to Python.

Noticed something strange. It seems the only reason why this PR went green on Travis is because the flake8 job did not check trinity.
flake8 runtests: commands[0] | flake8 /home/travis/build/ethereum/py-evm/evm
flake8 runtests: commands[1] | flake8 /home/travis/build/ethereum/py-evm/tests --exclude=

https://travis-ci.org/ethereum/py-evm/jobs/347174579
I'm investigating this as I'm working on #423. So, maybe we hold back merging until I'll figured out what's wrong here.

Ah, ok. This PR isn't rebased on top of latest master and flake8 checks for Trinity where just recently enabled: https://github.com/ethereum/py-evm/commit/64d1662d5b2e48ae0dc853e5ea70fc9b394bfd7f
Will rebase and fix.

Ok, I rebased this on latest master and the problem seems solved. That said, the build is still failing but I think that's a general problem of master being broken right now as I see this (merged) commit failed because of the same reason.
https://travis-ci.org/ethereum/py-evm/jobs/347464971

#421 has now landed if you want to rebase.

@pipermerriam rebased and green :)


Support flutter app not in root of workspace

My flutter app isn't in the root directory of the workspace. It would be great if it could detect that based on the location of the pubspec.yaml, or be able to specify the root path as a setting.

@davestimpert hey! Thanks for filling this suggestion. I will take this up in the upcoming days, there's already been some work in progress.


Telegram

Add a variable to enable or disable margin trading.
Add support for Telegram notifications.
Turn off e-mail sending by default.

thank you so much. your code is very clean.


Please add a --command / -c option to bst shell, or similar

In GitLab by @aevri on Aug 16, 2017, 18:21
When running automated tests on things I'm building with BuildStream, I'd like to be able to run them in a sandbox as with bst shell, but not interactively in a shell, e.g. similar to bash -c 'echo hello':
bst shell --scope run -c './run_tests.sh' example.bst
echo $?

I'd also like the return code of the command to be reported back, so it can be used to report success or failure.

In GitLab by @juergbi on Aug 17, 2017, 09:46
Makes sense to me. I expect this to be mainly used for non-interactive commands. Do we also want to support interactive commands or will users simply have to enter the shell and then run the interactive command?

In GitLab by @juergbi on Aug 17, 2017, 09:50
mentioned in commit 6ba115065f8168fa1684be338a47f0a65ca3df79

In GitLab by @juergbi on Aug 17, 2017, 09:50
mentioned in merge request !80

In GitLab by @samthursfield on Aug 17, 2017, 10:39
With !80 I can run a single command, but its output is prefaced by a bunch of logging, e.g.:

$ bst shell --scope run gnu-toolchain/stage2.bst -c ls
Loading:   018
Resolving: 018/018
Fetching artifact list from https://ostree.baserock.org/cache/
Checking:  018/018
[--:--:--][e0de16cf][ main:gnu-toolchain/stage2.bst      ] START   Staging dependencies
[--:--:--][e0de16cf][ main:gnu-toolchain/stage2.bst      ] WARNING Overlapping files

    Staged files overwrite existing files in staging area:

    From gnu-toolchain/stage2-gcc.bst:
      /tools/lib/gcc/x86_64-bootstrap-linux-gnu/4.9.2/include-fixed/limits.h
      /tools/lib64/libstdc++.a
      /tools/lib64/libstdc++.la
      /tools/lib64/libsupc++.a
      /tools/lib64/libsupc++.la
      /tools/share/gcc-4.9.2/python/libstdcxx/__init__.py
      /tools/share/gcc-4.9.2/python/libstdcxx/v6/__init__.py
      /tools/share/gcc-4.9.2/python/libstdcxx/v6/printers.py

    From gnu-toolchain/stage2-reset-specs.bst:
      /tools/lib/gcc/x86_64-bootstrap-linux-gnu/4.9.2/specs

[00:00:01][e0de16cf][ main:gnu-toolchain/stage2.bst      ] SUCCESS Staging dependencies
[--:--:--][e0de16cf][ main:gnu-toolchain/stage2.bst      ] START   Integrating sandbox
[--:--:--][e0de16cf][ main:gnu-toolchain/stage2.bst      ] STATUS  Running integration command

    # In this stage, it may be that ld.so.conf doesnt exist yet
    ldconfig || exit 0

sh: ldconfig: not found
[00:00:00][e0de16cf][ main:gnu-toolchain/stage2.bst      ] SUCCESS Integrating sandbox
bin    dev    home   lib64  mnt    proc   run    srv    tmp    usr
boot   etc    lib    media  opt    root   sbin   sys    tools  var

Is there a way to get just the command output ? I tried --no-verbose and --log-file=/dev/null to no avail, so perhaps we need a --quiet flag ...

In GitLab by @juergbi on Aug 17, 2017, 10:52
closed via merge request !80

In GitLab by @aevri on Aug 18, 2017, 10:04
Ace, quick turnaround, thanks!

In GitLab by @tristanvb on Sep 5, 2017, 22:37
mentioned in merge request !85


Install location

For those of us who have worked with Linux and Unix for more than 20 years, it is common knowledge that you never install a program or application under a User's home directory.  Especially "root's" home directory.
The /opt filesystem is intended for 3rd party, out of the box, or off of the shelf applications.
The /usr/local filesystem is intended for internally developed applications, while /usr/local/bin is intended for individual, or very small command groupings and scripts.
Is there anything inside of the installed code under the /root home directory, that would need to be "tweaked" in order to relocate it to the /opt directory structure?

I'm not exactly sure I understand what you are seeing installed to /root. By default our install scripts install the cypress code to /opt/cypress and install the cypress executable management tools to /usr/bin/cypress.

I was commenting on the /root/cypress-recipe install, the /root/.chef and /root/.berkshelf directory structures.  If the /root/cypress-recipe directory is an application, it should be under /opt, just as you correctly placed /opt/cypress.
The other question I have is this:  Does the cypress-recipe app need to run as root, or could it also run as the "cypress" user?
If it can be run as the cypress user (or some other functional account), then the two config directories should be under the generic / functional user account, and not under the root account.
Thanks for responding to the question.
Please understand that I really do appreciate the effort that you and your team have put forth to make this a viable application.
I sometimes get frustrated because in the Linux world, we have a lot of developers who like to code, and who want to contribute.  Their efforts are very much appreciated.
But, there are certain standards that must be adhered to, or you just end up with a big mess, and it makes troubleshooting more difficult.
Even within my own organization, I run into developers who have excellent ideas, but they do not understand why some of these standards exist.
Again, please do not take offense to my post.
I really appreciate what you are trying to do here.
Have a great day.

Oops, sorry I assumed you meant the application itself, not the deployment scripts. You are welcome to place the cypress-recipe code anywhere you choose. The instructions do not call out a specific location since it can be run from anywhere and by any user as long as that user has sudo privileges. After install you are welcome to delete the whole cypress-recipe from your system as well as uninstall the chefdk if you choose, they are not necessary for continued operation of Cypress. The cypress-recipe needs to either run as root or with sudo so that it has permission to install the cypress package.