SignalR JS client example doesn't work. (solution within)

From @TW8B on Wednesday, May 8, 2019 8:33:14 PM
aspnetcore/signalr/javascript-client/sample/wwwroot/js/chat.js requires an iife around start to start.
The sample appears to be based off the JS SignalR tutorial or vice versa, but with substantive differences around things like use or not of async.
I'm happy to submit a pull request once I'm on a machine that isn't locked down.
(async function start() {     try {         await connection.start();         console.log("connected");     } catch (err) {         console.log(err);         setTimeout(() => start(), 5000);     } })();
It was the only change required to make the thing run. There were some other issues with things like bootstrap being missing, but I didn't dig into that. Again, happy to have a poke.
I'm using VS 2019 latest.
Cheers
Edit: I could make the tutorial match or not match the sample, perhaps in a separate issue?
Copied from original issue: dotnet/core#2695

From @davidfowl on Wednesday, June 5, 2019 4:19:01 AM

Edit: I could make the tutorial match or not match the sample, perhaps in a separate issue?

Our in repo samples aren't really samples so no they shouldn't match. They are mostly for the team's own testing, more like a sandbox while the devs write code. We have a separate repository for samples and docs that we point at them.

From @karelz on Wednesday, June 5, 2019 4:38:51 AM
@davidfowl so what is the action here? Close the issue? Or are there any follow ups/fixes/changes/investigation we should do first?

From @davidfowl on Wednesday, June 5, 2019 6:31:47 AM
I tried to move it to asp.net but no go. Move it to aspnet

From @karelz on Wednesday, June 5, 2019 7:59:49 AM
Which aspnet repo? I am using @Eilon's tool for cross-org moves btw: https://hubbup.io/Mover (Transfer issue is only in-org :()

From @davidfowl on Wednesday, June 5, 2019 1:51:09 PM
the AspNetCore one.

This is actually an issue in our doc sample, not an in-repo sample, so we should look at it. I'll leave the bug here and put it in preview 8.
@TW8B if you're interested, we'd be happy to take a PR! The sample code is here and you can just submit a PR and tag me in it so we can review it.


There should be a deploy method for the main class

If a class has a method named deploy and this method is annotated Callable then it should be called at deploy time.
This will remove the need for accessing Blockchain.getData() directly, like this:
    /**
     * This initialization is run at deploy time.
     */
    static {
        ABIDecoder decoder = new ABIDecoder(Blockchain.getData());
        String tokenName = decoder.decodeOneString();
        String tokenSymbol = decoder.decodeOneString();
        String tokenUriPrefix = decoder.decodeOneString();
        String tokenUriPostfix = decoder.decodeOneString();
        NFTokenMock.setTokenNameSymbolAndUriAffixes(tokenName, tokenSymbol, tokenUriPrefix, tokenUriPostfix);
    }

Instead the type safe alternative is:
@Callable
public static void deploy(String newTokenName, String newTokenSymbol, String newUriPrefix, String newUriPostfix) {
    ...
}

Benefits:

It hides the details of ABI decoding, which the programmer does not care about
It makes the ABI more clear because the types in deploy match the types in the ABI

The deployment call types actually are not part of the ABI anyway and they are an implementation detail for the contract users (this is a separate issue)

Work plan

[ ] Call deploy if exists
[ ] It shall be a compiler error if a the contract has a deploy method and any class has an @Instantiatable variable

This is what the @Initializable annotation is for.

@Initializable allows you to set values only for static variables. Static variables have an extremely narrow use case and and probably none of those use cases overlap with setting the static variables at deploy time.
The only use case of @Initializable therefore is spells and counterfactuals.


Override flags

helm-push plugin  from Chartmuseum accepts --force parameter and ALLOW_OVERWRITE variable to allow users to choose whether to override the chart or not.
Current behavior of helm-push-artifactory-plugin instead seems to override the chart without considering the aforementioned.
Could you please fix this behavior?
I'm using v0.4.1

Hi @l-rossetti
So looks like that ALLOW_OVERWRITE is a feature of ChartMuseum, not the plugin itself.
I'm not sure I'll be able to replicate this feature, because by default artifactory lets you overwrite the version, and in the rest api call I use to push the chart to artifactory you don't have any option to tell it not to overwrite the version :(
Also, since you are pushing to a local repository, I don't think you can check if the version already exists... but I'm just guessing here.
I can't make any promises, but as soon as I have some free time I'll take a look at this to see if there's any way to do it.
Cheers!


Mirahc fails when assigning variable in rescue block

Consider this Mirah code
foo = nil
Thread.new do
	begin
	rescue => e
		foo = Object.new
	end
end

It should compile cleanly. But the current mirahc fails with this error message:
src/org/mirah/builtins/object_extensions.mirah:218:

ERROR: Cannot find class null
          @`e.key`
          ^^^^^^^^
1 errors

Merged #389 which fixes this.


Added package-deps to package.json

Fixes #24

It's not quite that simple :stuck_out_tongue:, but you are close!

[ ]  You need to specify that you depend on atom-package-deps (see here).
[x] You already have the dependency list taken care of
[ ]  You then need to call the install() method, like this.

Thanks, fixed ;)

LGTM, thanks again!

Released in v1.2.0. :tada:


Console/log output If applicable, add console/log output to help explain your problem.
https://github.com/openthread/openthread/runs/824271448
logs_9382.zip
Additional context Add any other context about the problem here.
Started failing after merging #5155

Looking into this

Looking into this

Thanks, @ctan-g !

@jwhui I found that the cause is my OT_TOOL_WEAK definition of otPlatOtnsStatus in otns.cpp isn't properly being overridden by the strong one in otns.c during linking when building the simulation images. Do you happen to know why this is happening?

I wonder how did we pass the GitHub action checks.

Turn out cli-ftd-otns GitHub action is not using the current openthread commit of the PR, but always using openthread master for checking. This was the reason why cli-ftd-otns check passed.


How to remove adapter clean?

Hi sfchen,
Today, I compared three software (fastp, cutadapt, trimmomatic) , and found fastp very fast but adapter cannot be remove clean.
I upload my result and hopefully you found this useful!
compare_software.xlsx
sfchen commented:
Thanks for the result, from the data, I can see:
for short adapters (7bp), Trimmomatic removes the most adapter, then fastp removes less, and Cutadapt removes the least.
for longer adapters (>7bp), fastp removes much more than Trimmomatic and Cutadapt.
in total, fastp removes the most adapters.

Am I right?
Replay:
Hi sfchen,
My sample real  adapter sequece is GATCGGAAGAGCACACGTCTGAACTCCAGTCAC********ATCTCGTATGCCGTCTTCTGCTTG, '*' is 8bp barcode.
And trimmomatic adapter file is :
adapter.list.xlsx
When I get clean fastq data, I split adapter sequece to some short substr, like:
7bp (AGATCGG)
8bp (AGATCGGA)
9bp (AGATCGGAA)
10bp (AGATCGGAAG)
11bp (AGATCGGAAGA)
12bp (AGATCGGAAGAG)
13bp (AGATCGGAAGAGC)
and then statistic the count of reads include this substr adapter sequence.

Hi sfchen,
My sample real  adapter sequece is GATCGGAAGAGCACACGTCTGAACTCCAGTCAC********ATCTCGTATGCCGTCTTCTGCTTG, '*' is 8bp barcode.
And trimmomatic adapter file is :
adapter.list.xlsx

1, can you upload the first 10000 lines of the two files?
2, did Trimmomatic or Cutadapt cut adapters clean?
Thanks

Hi sfchen,
Test file :
Test.zip
In my test, Trimmomatic or cutadapt cut adapter clean.

But why they cut less adapters?

In my opinion, fastp remove adapters by overlap, that's not efficient method.
cutadapt and trimmomatic cut adapter by string match, that's the different with fastp.

Thanks for your opinion, the method for fastp to cut adapters for SE data is similar as cutadapt and trimmomatic. For PE data, we use overlap analysis since we think it's more efficient and faster.
but I need to understand why cutadapt and trimmomatic cut less adapters as I know from the table, but you said their result are cleaner?

maybe my description is not clear, I can share my perl script to you.
stat_adapter.pl.txt

sfchen,
I run test data with cutadapt, trimmomatic, fastp.
01_Cutadapt.tar.gz
01_Fastp.tar.gz
01_Trimmomatic.tar.gz

Thank you very much! I will test and update.

Hi sfchen, I'm curious about the question,too. But this issue is closed, where can I access to the results please?


Prevent UserColor from modifying the guild.Roles slice

Edit: I don't think I PR'd this correctly, but copying the roles like this fixed the issue for me.
Its at line 931
roles := make([]*Role, len(guild.Roles))
copy(roles, guild.Roles)
sort.Sort(Roles(roles))

Input
	case ">usercolor":
		guild, _ := b.Guild(m)
		fmt.Println("--------Roles before calling UserColor-------")
		for _, v := range guild.Roles {
			fmt.Println(v.Position)
		}
		b.DG.State.UserColor(m.Author.ID, m.ChannelID)
		fmt.Println("--------Roles after calling UserColor--------")
		for _, v := range guild.Roles {
			fmt.Println(v.Position)
		}

Output:

In this example, calling UserColor has the side effect of also sorting the roles in a guild.

Yeah, you will need to repush this branch with the new updates from develop.
Is there an issue with this? I struggled with this when sorting them originally, but it seemed fine.


hOpenPGP test suite build failure

[30 of 31] Compiling Codec.Encryption.OpenPGP.Arbitrary ( Codec/Encryption/OpenPGP/Arbitrary.hs, dist/build/tests/tests-tmp/Codec/Encryption/OpenPGP/Arbitrary.o )

Codec/Encryption/OpenPGP/Arbitrary.hs:175:10: error:
    Duplicate instance declarations:
      instance Arbitrary a => Arbitrary (NE.NonEmpty a)
        -- Defined at Codec/Encryption/OpenPGP/Arbitrary.hs:175:10
      instance [safe] Arbitrary a => Arbitrary (NE.NonEmpty a)
        -- Defined in ‘Test.QuickCheck.Arbitrary’

I think I fixed this in hOpenPGP 2.5.2


Use TCP when appropriate for the given query type/response

Expands the current logic around when to use TCP beyond truncated responses. By spec, AXFR queries should always use TCP, and IXFR queries should retry with TCP when it receives a lone SOA response.
This commit adds a small function to return the index of a given query type within a DNS message (if it exists), which then enables simple implementation of the above AXFR/IXFR logic.

Thank you for your contribution!
It is great since DoH can now be useful for AXFR and IXFR!

By the way, have you tested the feature?
I do not have experience with AXFR/IXFR. Will you please help me test if it is working?

I have tested both, yes, in a production environment. Now that's the only place I've tested them, but they have been working as expected.


DNS is not set in VPC Subnet

According to:  OTC Probleme // IM0032219586
When one creates a new VPC with Subnet (or just a new Subnet), the DNS server entry stays empty.
This causes the cloud init script to fail so the worker nodes never become active.
Currently to mitigate this issue manually is (re)setting the DNS Settings on the Subnet.

Fixed, just clear browser cache for rancher ui and try to create cluster.


Improve how dependent PRs are managed

Is your feature request related to a problem? Please describe.
Actually this is a suggestion to improve how dependent PRs are handled in this project. Example of a PR that depends on another one: https://github.com/zephyrproject-rtos/zephyr/pull/30424. If you do a quick search, you can easily find several other PRs like this.
Describe the solution you'd like
Introduce to this project Dpulls, a Github app that make easier to manage dependent PRs. Basically:

:star2: It prevents a PR to be merged before its dependencies.
:eyes: It gives more visibility to the developers so they know why a PR cannot be merged.
:heart: Avoid any accidental merge that can break your master branch.

In addition to that:

Dpulls has support for cross-referencing (dependency from another project).
Doesn't require any special config to add.
Nothing to change in your current workflow. As you usually do, just write depends on #pr or depends on owner/repo#pr if from another project, and Dpulls will do the job :muscle:

Additional context
Dpulls in action :rocket: :

I hope that you will like this suggestion :relaxed:

Thanks for the suggestion @wal003. Does Dpulls also come in the form of a GitHub Action? We've been switching to those lately.

Hey @carlescufi , thanks for your response. Dpulls doesn't come in the form of a Github Action, and I honestly don't think this will change in the future mainly because a Github App is suited better for what Dpulls is trying to achieve (better performance, accessibility, etc..).

@wal003 are you caring to improve zephyrproject or wanting to sell your own project?
https://github.com/search?q=Introduce+to+this+project+Dpulls%2C&type=issues

@erwango You're completely right, and your question is legitimate, so better be fully transparent.
In reality, I'm not really familiar with zephyr's project. I just noticed after a quick search that working with dependent PRs is a common thing in this project, so I wanted to propose this tool. Am I caring to improve this project ? Of course, like any other project I think I can provide some added value to it. I proposed this tool to other projects too. Some weren't interested, some really liked it and adopted it, and some were even asking where they can find the payment page even though I didn't ask for anything :smile: (Maybe this was the point that actually led me to keep working on and promoting Dpulls haha). So I just keep proposing in the hope to gain more users. Right now, I'm not making any money out of it, I'm just focusing on improving it and having new users actually helps a lot. And as long as I'm seeing that Dpulls is providing some benefits to some projects, I'm gonna keep proposing it (Btw, sorry I forgot to mention it but Dpulls is completely free for open source projects).
Maybe I should've mentioned this in the issue description but I didn't want to make it sound like I'm just here to sell something. Generally people tend to immediately close your issue if something sounds like an ad, which is completely understandable.
I hope my intention is more clear now :stuck_out_tongue: @erwango .

@wal003 Thanks for this effort of transparency! :+1:


Custom scm version handling.

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Example:
$ python -c "import gluonts; print(gluonts.__version__)"
dev.custom-scm-version+ga8d6cdd

$ git tag v0.7.0
$ python -c "import gluonts; print(gluonts.__version__)"
v0.7.0

Does this work is the running environment doesn't have git? Say, one pip-installs gluon-ts from PyPI, but is not developing it

In that case you should get "0.0.0-unknown".

In that case you should get "0.0.0-unknown".

but you probably want the correct version instead, right?


Compiling issue

Describe your bug here.
I'm unable to compile for windows. I made sure to install the correct version of Haxe and libraries, still no good.
Command Prompt/Terminal logs (if existing)
source/online/GameClient.hx:11: characters 8-40 : Type not found : io.colyseus.error.MatchMakeError
source/online/GameClient.hx:172: characters 51-65 : Type not found : MatchMakeError

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
I didn't edit anything, I tried to build after downloading the source

Use haxelib run install hmm, worked for me


Dual Sensor Processing

So, I am trying to use 2 sensors at the same time for an application...one pulse sensor on your ear, one on your finger.  I am curious if anyone knows how to produce 2 different serial outputs from the two sensor inputs...one for each...and display them in the visualizer.
I imagine the Mega (which is what I have) will permit this, but I'm new and thought that this "easy" task would be...it has not been.
Any thoughts?

Hi PCesarano,
I have actually done this recently and just put my code up on github here
https://github.com/biomurph/PulseSensorAmped_2_Sensors
Please let me know if this works for you. It runs on an UNO

Thanks Joel!!  I'll give it a try.  Much appreciated.
Patrick
On Wed, Jun 15, 2016 at 1:46 PM, Joel Murphy<EMAIL_ADDRESS>wrote:

Hi PCesarano,
I have actually done this recently and just put my code up on github here
https://github.com/biomurph/PulseSensorAmped_2_Sensors
Please let me know if this works for you. It runs on an UNO
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/WorldFamousElectronics/PulseSensor_Amped_Arduino/issues/23#issuecomment-226264767,
or mute the thread
https://github.com/notifications/unsubscribe/ATCCooz7IjDXBaSJar2G7s8dTf6ZfDk1ks5qMDpugaJpZM4I2iUf
.

Joel,
I have a random question...I'm trying to find the area under the curve of a
given pulse, and am also trying to detect the time difference between
pulses.  Your 2-sensor code works perfectly and I really appreciate your
help on that.  Do you have any insights on essentially integrating each
pulse, and also detecting timing between pulses?  I can write the code, but
I'm hopeful it's already out there somewhere.
Thanks.
Patrick
On Wed, Jun 15, 2016 at 2:30 PM, Patrick Cesarano <
<EMAIL_ADDRESS>wrote:

Thanks Joel!!  I'll give it a try.  Much appreciated.
Patrick
On Wed, Jun 15, 2016 at 1:46 PM, Joel Murphy<EMAIL_ADDRESS>wrote:

Hi PCesarano,
I have actually done this recently and just put my code up on github here
https://github.com/biomurph/PulseSensorAmped_2_Sensors
Please let me know if this works for you. It runs on an UNO
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/WorldFamousElectronics/PulseSensor_Amped_Arduino/issues/23#issuecomment-226264767,
or mute the thread
https://github.com/notifications/unsubscribe/ATCCooz7IjDXBaSJar2G7s8dTf6ZfDk1ks5qMDpugaJpZM4I2iUf
.

Hi, hello. I saw your information on GitHub. Do you have the code to calculate the peak time difference through 2 pulse sensors?

I don't have the code handy, but it's not too hard to do.
When a beat is found on one sensor, you can take the time and measure it to the beat of the second sensor and then vice versa. You'll want to use the shortest time as the difference

can you help me write this code based on your code Pluse senors_2。this time PTT is used to estimute the bloode pressure.

Oh, I see. You are placing the sensors on the same person in different places to derive PTT. Got it.
Well, you should know which sensor is closer to the heart, and so you can measure the time between that sensor's beat and the other sensor's beat. We sample the data at 2mS intervals, so that would be the resolution of your PTT.
I can't help you with the code, however. That would be a lot of work and I could only do it for a fee.

My idea is this, two sensors are placed in front and back positions of the fingers, respectively, to measure two pulse waves. When the first pulse wave peak is detected, the recording time is T1=micros (); then the peak value of the second waveform is detected; the recording time is T2 =micros (); PTT=T1-T2

I can pay for you

please contact me joel-at-pulsesensor-dot-com to discuss your project further and see if it's anything that I can help with.

有人可以帮忙吗？

joel,Can you help me? It seems simple, but I don't know how to make it happen. Looking at the examples of your 2 sensors, I think it can be implemented as long as it is modified, but I don't know how to modify it.


Support for mssql

Wondering if there are any plans to support MSSQL. Could take advantage of a MSSQL library like this one: "https://github.com/patriksimek/node-mssql".
I'd be happy to work on a pull request for this, but I might need a few pointers on how to get started.

any update on mssql? I'm building https://github.com/cnect/sails-mssql without the benefit of a real MSSQL query builder for node. Would love to use knex under the hood.

We basically need someone to take the lead on either writing and maintaining the functionality or sponsoring it. Otherwise there are a lot of higher priority items and you shouldn't count on MS SQL support.

Yea, understand. I'm already invested in the sails mssql adapter, but I'd love to circle back to a knex implementation after the immediate needs of my project are met.

Yeah absolutely, @tjwebb that'd be great if you could help out with something like this - I'm mapping out a lot of plans for how to clean up a lot of the query composition so it should be much more straightforward on adding new dialects, etc.
Would also be cool if we could somehow get knex as a backing for sails at some point, I know from that other ticket you were looking to make that a reality - hopefully once the internals of knex are a bit more modular we can figure out something to make that happen.

@tgriesser Sounds good. If you run across any sponsored dev for mssql
support, let me know.
On Mon, Jan 19, 2015 at 1:07 PM, Tim Griesser<EMAIL_ADDRESS>wrote:

Yeah absolutely, @tjwebb https://github.com/tjwebb that'd be great if
you could help out with something like this - I'm mapping out a lot of
plans for how to clean up a lot of the query composition so it should be
much more straightforward on adding new dialects, etc.
Would also be cool if we could somehow get knex as a backing for sails at
some point, I know from that other ticket you were looking to make that a
reality - hopefully once the internals of knex are a bit more modular we
can figure out something to make that happen.
—
Reply to this email directly or view it on GitHub
https://github.com/tgriesser/knex/issues/240#issuecomment-70536317.

Hi!
I started an implementation of mssql in https://github.com/tlsoftwares/knex, who can and want to help will be very welcome!
If you have any guidance on how to do this work would be helpful.
I started integrating the dialect "mssql" the possibilities of testing and I am already doing the database connection using https://github.com/pekim/tedious.

@emanuelhp Thanks for working on this! I'll have to check out your fork soon. I did have a question, though... would you be opposed to using https://www.npmjs.com/package/mssql instead of using tedious directly? That library wraps tedious, the official Microsoft SQL Server client for Node, and the older node-tds library, which means it'd be easy for users to switch between drivers. (especially since the official MS driver should outperform the rest, but isn't available on Linux)

Also, while looking up the mssql library, I came across this MS SQL adapter for knex, which looks like it hasn't been touched in a while... it might be useful for inspiration, though.

Has there been any progress on this? Is there maybe something we (company I work for) could do to help make this happen? (most likely financially)
I personally love Knex and would love one workflow instead having to write a separate data handler for mssql. Please let me know what could motivate you guys and I'll try make it happen!

@mderijcke Hm. I've never used Bountysource before, but it looks to me as though you could add a bounty to this issue. If you need it completed in a specific timeframe you might be better off asking any regular contributors if they would be interested in the job and hiring them directly. Good luck.

I have 0 experience with mssql, but I'm going to arrange user accounts for test databases. One of the system admins at the company I currently work for appears to have mssql experience.
I prepared a virtual machine with Windows Server 2012 R2 and Microsoft SQL Server 2014. Anyone interested in an mssql testbed can contact me or tag me in this issue.
@tgriesser - Let me know if you are interested in a permanent testing bed for mssql. If you could use help financially then we may be able to offer you some help. Please let me know what your stance on the subject is (progress, what's left to do, available time, motivation, etc)

Unfortunately my company was restructured and I can not work on it for a while ...

how goes the ms sql support? are there different packages to use? or is this the right one?
i am attempting to extend
http://meteor-postgres.readthedocs.org/en/latest/
but using ms sql rather than postgres

I have not that much experience with mssql, but I ended up building a Waterline adapter for it: https://github.com/cnect/sails-sqlserver. @JohnHanks perhaps the adapter APIs for Waterline and Meteor are similar enough that you could adapt some of the code?
I also don't know much about this new meteor database adapter system. In summary: I don't know much :)

I got the example app working with Knexjs to bridge Postgres to Meteor's Minimongo.
Does anyone know the extent of the work needed to port Knexjs to MSSQL?  We are thinking about doing it ourselves.  If we can pinpoint the changepoints in the code to get this working with any DB, maybe we can investigate and if we develop our own version of Knex for MS SQL then we can issue a pull request :octocat:  :smile:

Yet another person interested in the MSSQL support.

I am interested in the MS SQL port, and would be very happy to help in its development. I will try to keep up with discussion, but if you ever feel like you're a pair of hands short, by all means get a hold of me!

Is there any work being done on this at all? I would love to have this.

Is there any work being done on this at all?

@bendrucker?

Any updates?

Just wanted to let you know I am building a mssql provider, spent today working on it. probably have complete soon. will post and put in a pull request.
@tybenz this is still a needed feature I am assuming.

@Grimace1975
Great to hear. This is one of our most regular requests. Please keep us posted. :+1:

@Grimace1975 Is it going well?
I also put in some time developing for SQL Server and what stopped me was how Transactions were setup in knex source code and how Transactions were handled in the mssql node driver.

@JoaoCnh yes it has taken a couple days, longer then i thought it would. everything is complete, all tests passing, except for transactions, and migrations working on these now.

@Grimace1975 nice! Pls let us know if you have gotten any far with Transaction progress

@JoaoCnh I just finished and everything works.
@rhys-vdw I will put in a pull request. I noticed however when running babel, that other lib files where overwritten in the lib folder and are different from src. Have people been making changes in lib directly?

I found a potential issue with your mssql implementation @Grimace1975. I began using it yesterday and found that your limit/offset output is based on mssql 2008 thinking. I'm not sure if this is what you were going for, but in mssql 2012 there's offset & fetch. I had to create my own branch that handled that here: https://github.com/mbrio/knex. If the tests are setup against an mssql 2012 server and you are using limit and offset together an error would occur because top and offset can not be used together.

@mbrio yes i was trying to support mssql before 2012 as 2012 is not used as much. Top is supported tho across all platforms. The limit and offset only work when used with an order by.
Maybe as a compromise is top use limit and offset when both are used, otherwise revert to using top.
Thank you for finding this.

@mbrio,
Do you mind trying to latest master. I have pushed up a fix. and test seem to pass.

When using limit I'm now getting:
Unhandled rejection RequestError: select top @p0 * from [table] where [search1] = @p1 and [search2] = @p2 order by [field1] desc - Incorrect syntax near '@p0'.

this is with:
  knex
    .select()
    .from('table')
    .where(search)
    .limit(10)
    .orderBy('field1', 'desc')
    .then(function (records) {
      res.json(records);
    });

@blitzd
i removed the top (?) parens. did this work prior to pulling again.
the built in integration tests perform this action. so it passed locally.
try updating the test\knexfile.js file for mssql
set Debug=mssql
npm test
or the equivalent on your platform

@Grimace1975
The error seems to indicate that it's passing the limit(X) as a parameter, and I don't think you can do that with SQL Server, parens or no.
DECLARE @Top INT = 2

SELECT TOP @Top * FROM sys.tables -- Not valid

SELECT TOP (@Top) * FROM sys.tables -- Not valid

SELECT TOP 2 * FROM sys.tables -- Valid

I had previously hacked a bit of mssql support into knex and had implemented the limit using the following (this is just a mish-mash borrowed from other providers with very slight modifications to support top/limit):
  select: function select() {
    var statements = _.map(components, function (component) {
      return this[component]();
    }, this);
    var query = _.compact(statements).join(' ');
    return this._addQueryLimit(query);
  },

  limit: function limit() {
    var noLimit = !this.single.limit && this.single.limit !== 0;
    if (noLimit && !this.single.offset) return '';

    // Workaround for offset only,
    // see http://stackoverflow.com/questions/10491492/sqllite-with-skip-offset-only-not-limit
    return 'limit ' + this.formatter.parameter(noLimit ? -1 : this.single.limit);
  },

  _addQueryLimit: function _addQueryLimit(query) {
    var limit = this.single.limit;
    var hasLimit = limit || limit === 0 || limit === '0';
    limit = +limit;

    if (!hasLimit) return query;
    query = query || "";
    if(hasLimit) {
      return query.replace('select', 'select top ' + limit);
    }
  }

It may well pass the query builder bits of the unit tests as when I was looking through those they don't necessarily seem to get created in the same was as they get executed on the SQL Server. I.e,. you could end up with SELECT TOP 2 in your query building output - but on the SQL Server it's passing that wrapped in an execute_sql call where the parameters are split out separate (and then it's not valid).
Hope that makes sense!

@blitzd  test tested and errors. i have corrected. pushing again.
this works with (?) as it did before.
Declare @statement nvarchar(50) = 'select top (@p0) * From Accounts';
Declare @params nvarchar(50) = '@p0 int';
Exec sp_executesql @statement, @params, 2;

@Grimace1975 can confirm it does indeed work as before! Thanks!

I have the knex from master with the mssql dialect. Trying to migrate a simple table and getting
TypeError: expecting an array, a promise or a thenable
when doing knex migrate:latest
What is happening? Anyone aware of this?

@JoaoCnh Got a stack trace?
Send set the environment variable BLUEBIRD_DEBUG=1 to get enhanced promise stack traces.

I've seen that MSSQL support has been merged into master. Any reason why this is still open?

@denisw Does this mean MSSQL is now a supported DB?
Its not listed in the README.md "A batteries-included, multi-dialect (MySQL, PostgreSQL, SQLite3, WebSQL, Oracle) query builder for Node.js and the...". This is the single roadblock preventing our implementation of knex. Thanks!

Any updates on this? We use KNex where I work, and are looking to add support for MS SQL.

Andrew,
Everything should be complete. What are you finding lacking?
@tgriesser I do not believe a new build has been released, and the web content still does not show MS SQL Support.
From: Andrew Faulkner<EMAIL_ADDRESS>Sent: Friday, February 26, 2016 4:42 PM
To: tgriesser/knex<EMAIL_ADDRESS>Cc: Sky Morey<EMAIL_ADDRESS>Subject: Re: [knex] Support for mssql (#240)
Any updates on this? We use KNex where I work, and are looking to add support for MS SQL.
—
Reply to this email directly or view it on GitHubhttps://github.com/tgriesser/knex/issues/240#issuecomment-189513622.

@cexafaulkner, @Grimace1975: This was actually released as part of v0.10.0, as shown in the changelog on the site; however, you are correct that the documentation has not been updated to reflect this. I'm sure a PR would be welcome to remedy this ;-)

I added a PR to support MSSQL examples viewing in the docs, #1246 .

mssql is already supported. closing the issue.


KeyError: 'relations'

Hello.
When I ran ./ ce7475/ main.py , I got the error message like this
file: ~/OpenPSG/ce7454/dataset.py", line 81, in  getitem
soft_label[sample['relations']] = 1
KeyError: 'relations'
How should I modify the code?

I would recommend to use 'pdb' to debug on your own first.
Looks like the problem is on your json file path, as I cannot tell more based on the clues you give.

OK.
Thank you!


"URI too long" error on publication of large number of keys

When the dictionary contains a large number of keys and the user selects all entries and publish them, the following error is thrown: URI too long

This request is using a GET method adding all the entries as query parameters which goes over the URI length limit.

Using a POST is reasonable here (also for semantic reasons).

@jmagdrod will have to validate on how we can make this work, if it would be a direct publication without a dialog in between, the POST would be very easy to implement, but now it's using the action type foundation.dialog, which doesn't support opening it with a POST (that I know of), so will have to rewrite it a bit from scratch.
I wont have the time to fix it this week so if it's urgent I'm always open for contributions!

There is com.day.cq.replication.impl.servlets.CommandServlet which can be used for replication (registered for /bin/replicate) and com.day.cq.wcm.core.impl.commands.WCMCommandServlet (registered for /bin/wcmcommand). Both support POST` requests.

Looking at the AEM code for making the dialog on quick publish, shouldnt be too hard to make the glue 😄
$(window).adaptTo("foundation-registry").register("foundation.collection.action.action", {
        name: "cq.wcm.quickpublish",
        handler: function(name, el, config, collection, selections) {
            var message = createEl("div");
            var intro = createEl("p").appendTo(message);
            if (selections.length === 1)
                intro.text(Granite.I18n.get("The page and their references will be published."));
            else
                intro.text(Granite.I18n.get("The {0} pages and their references will be published.", selections.length));
            var ui = $(window).adaptTo("foundation-ui");
            ui.prompt(QUICKPUBLISH_TITLE, message.html(), "notice", [{
                text: CANCEL_TEXT
            }, {
                text: PUBLISH_TEXT,
                primary: true,
                handler: function() {
                    activatePagesAndItsReferences(config, collection, selections)
                }
            }])
        }
    })

    // copy of part of the activation function:
    function activatePages() {
         $.ajax({
                    url: REPLICATE_URL,
                    type: "POST",
                    data: {
                        _charset_: "utf-8",
                        cmd: "Activate",
                        path: paths,
                        agentId: DEFAULT_REPLICATION_AGENT_ID
                    }
                }).always(function() {
                    ui.clearWait()
                }).done(function() {
                    var api = $(collection).adaptTo("foundation-collection");
                    if (api && "reload"in api) {
                        api.reload();
                        ui.notify(null, getSuccessMessage(selections));
                        return
                    }
                    var contentApi = $(".foundation-content").adaptTo("foundation-content");
                    if (contentApi)
                        contentApi.refresh();
                    ui.notify(null, getSuccessMessage(selections))
                }).fail(function(xhr) {
                    var title = Granite.I18n.get("Error");
                    var message = Granite.I18n.getVar($(xhr.responseText).find("#Message").html());
                    ui.alert(title, message, "error")
                })
}

@jmagdrod  do you have test content ready to test my PR :)?


coprocessor_v2: fix incorrect shared library name

What is changed and how it works?

Issue Number: Close #13708
What's Changed:

This commit fixes test `registry_unload_plugin`. The test has been failing
since the example crate renamed its name in #13585.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
None

/merge


#79 Can't access Location header when the API responds with 451 status code

@rultor merge

@rultor merge

@proshin-roman OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@proshin-roman Done! FYI, the full log is here (took me 2min)


"View Raw" config is still html, not text/plain. This prevents saving web page as txt

Peering Manager version
v1.7.4
Python version
3.8
Steps to Reproduce
Go to a device and view configuration. Click 'view raw'. What is displays appears to be plain text.
If however you save the config, it saves it as HTML. The actual text appears to be in a <pre> tag.
We are using this for debugging purposes when developing templates, saving to text file then loading into a router outside of Peering-manager.
Expected Behavior
Expected is content type txt and saving the config to a file is actually a text file, not html.
Observed Behavior
HTML is shown, and not the config, if you save this page.
If /routers/X/configuration/?raw can be changed to output as MIME type text/plain, this should work as expected.

That is indeed weird considering:
https://github.com/peering-manager/peering-manager/blob/daf21847cee811f7e5c5e038d677c42f5e3a4c60/peering/views.py#LL920C41-L920C41

Is some internal django/bootstrap(?) thing trying to 'be smart' and just wrapping it in HTML on the way out the door?

I guess it's not. It's a plain HTTP response that is being returned. Moreover when clicking "View page source" or a button achieving the same goal depending on your browser you'll see that the page code itself contains only the text version of the config with any HTML tags.
So my guess is, that's the browser trying to be clever when hitting CTRL+S (or CMD+S), at least that's what it looks like using Chrome.

I think you're right, I was using Chrome, just tried Firefox and it didnt do this nonsense. I'll have a few others test to see if it's a chrome thing, or something with my specific extensions.
Sorry for the hassle!

Works with other browsers, seems targeted to Chrome (or Chromium) doing inappropriate magic tricks.


[update-checkout] Change dump-hashes to dump a update-checkout config…

… file rather than a textual dump format.
Previously -dump-hashes dumped the current state of the hashes in a format like
the following:
$REPO_NAME $HASH $SUBJECT
While this dumps the relevant information, it is not machine parseable. Instead
in this commit, we dump out the hashes into a update-checkout config json file
with a scheme name of repro. Thus to reproduce the current repository state on
someone else's machine, you don't need to type in the exact hashes. Instead, one
can just do:
$ ./swift/utils/update-checkout -dump-hashes > repro.json

and then give the repro.json file to another swift developer. They then can run:
$ ./swift/utils/update-checkout -config=repro.json -scheme=repro

which will checkout all of the appropriate hashes for each repository to
reproduce the build on the other user's machine.

@swift-ci python lint

@graydon Finally got around to matching what you did with -dump-hashes-config for dump hashes.

@swift-ci smoke test and merge


Loss changes little (~4.5) and Prec@1 keeps extremely low (~2%) when training with flow images

Hi. The code work well with rgb frames after I made some changes. However, it met some mistakes when training with flow imges. The loss and Prec@1 seemd to keep unchanged.
I ran this code on 4 GPUs and the batch size is 224. I set the learning rate to the initial LR (0.005) decayed by 10 every 30 epochs. The new_length was set as 5 and in_channels was change to be 10 (5*2). The flow images were computed with OpenCV and saved as '.jpg':
flow = cv2.calcOpticalFlowFarneback(prevGray, nextGray, None, 0.5, 3, 15, 3, 5, 1.2, 0)
flow_x = cv2.normalize(flow[..., 0],None,0,255,cv2.NORM_MINMAX)
flow_y = cv2.normalize(flow[..., 1],None,0,255,cv2.NORM_MINMAX)
The following figure shows the results at the beginning.

And the following figure shows the results after 30 epochs.

I tried vgg16 and inception_v3 (pre-trained model / training from scratch). Also I tried different initial LR, from 0.005 to 0.0001. Same issue. It's weird. Does anyone have comments about this?

Hi, thanks for bringing up the issue. Actually I think it is because the pre-processing of optical flow images.
The default preprocessing of PyTorch for natural color images is:
clip_mean = [0.485, 0.456, 0.406] * args.new_length
clip_std = [0.229, 0.224, 0.225] * args.new_length
But for optical flow, I haven't found an effective way to normalize it in order to use the pre-trained models. Currently, i use 0.5 because most people use 0.5 for gray scale images. But it doesn't work.
I will debug into it later. Or you can make progress on this issue. Thanks.

@bryanyzhu Oh, I just saw your reply. Sorry about this.
I tried different mean and std values, but it didn't help. Do you make any progress?
Can you share your results (spatial and temporal)  of this code on UCF101?

@YanjunZhu Hi, i just updated the codebase and report the accuracy on both spatial and temporal model on UCF101. Hopefully you can train your flow models now. But as I mentioned in README, my flow model's accuracy is still 5% lower than it reported in the paper. So maybe there still exist some subtle problems. Welcome any comments and pull request. Thank you.

@bryanyzhu Thanks. I will have a try later.


Open port 5005 and 8008

Useful for running cubes server from cubetl docker.

Wait! why port 5005? default cubes port is 5000.

Good question. I often make the ports inside and outside a container different, so I can keep the model straight in my head. But, it's not needed if you want them the same.


Pattern Recognition Terms

Pattern Recognition Terms
Pattern recognition of the structural motifs of potential
pathogens leading to activation of innate immune responses
is a prominent feature of both invertebrate and vertebrate
immune systems.  Definitive motifs for recognition and
specific receptor activities should be recognized in the GO
and below I define and refine existing terms as well as
propose some new ones, as well as rearranging the DAG
appropriately.
In this new scheme the new term "pattern binding" is a
collection term for more specific terms describing the
binding of various structural motifs of potential pathogens.
Similarly the term "pattern recognition receptor activity"
serves as a collection term for more specific terms
describing receptor activities for various structural motifs of
potential pathogens.  GO function purists may argue that
these terms are superfluous, but I believe they may have
use in situations where the exact motifs bound are unknown,
as well as providing context for their child terms.
I am open to discussion of these items, and would welcome
comments particularly by invertebrate focused curators.
-- Alex
The new DAG:
binding ; GO:0005488
--% pattern binding ; GO:NewTerm
----% polysaccharide binding ; GO:0030247
------% zymosan biding ; GO:NewTerm
--------% zymosan receptor activity ; GO:NewTerm
------% polysaccharide receptor activity ; GO:NewTerm
--------% zymosan receptor activity ; GO:NewTerm
----% lipopolysaccharide binding ; GO:0001530
------% lipopolysaccharide receptor activity ; GO:NewTerm
----% lipoarabinomannan binding ; GO:NewTerm
------% lipoarabinomannan receptor activity ; GO:NewTerm
----% peptidoglycan binding ; GO:0042834
------% peptidoglycan receptor activity ; GO:0016019
----% pattern recognition receptor activity  ; GO:0008329
------% polysaccharide receptor activity ; GO:NewTerm
--------% zymosan receptor activity ; GO:NewTerm
------% lipopolysaccharide receptor activity ; GO:NewTerm
------% lipoarabinomannan receptor activity ; GO:NewTerm
------% peptidoglycan receptor activity ; GO:0016019
receptor activity ; GO:0004872
--% pattern recognition receptor activity  ; GO:0008329
----% polysaccharide receptor activity ; GO:NewTerm
------% zymosan receptor activity ; GO:NewTerm
----% lipopolysaccharide receptor activity ; GO:NewTerm
----% lipoarabinomannan receptor activity ; GO:NewTerm
----% peptidoglycan receptor activity ; GO:0016019
--% transmembrane receptor activity ; GO:0004888
----% scavenger receptor activity ; GO:0005044
Terms:
1)  GO:0008329 pattern recognition receptor activity
has no definition and is misplaced as a child of GO:0004888
transmembrane receptor activity, when in fact certain gene
products involved in pattern recognition are found in
intracellular locations.
Proposed Definition:  Combining with an repeating or
polymeric structure, such as a polysaccharide or
peptidoglycan, to initiate a change in cell activity.
Revised parentage:  is-a to GO:0004872 receptor activity,
is-a to the new term "pattern recognition activity," below.
Proposed Comment:  Note that this term and its child terms
are intended for gene products which are directly coupled to
a signal transduction pathway; gene products which
recognize polymeric structures such as polysaccharides or
peptidoglycans in extracellular space, but are not directly
coupled to signal transduction pathway should use the term
GO:000XXXX pattern binding or its chld terms instead.
2nd Proposed comment:  Note that many gene products that
are called "pattern recognition receptors" in the literature
have a broad range of potential ligands and also can be
annotated to GO:0005044 scavenger receptor activity as
well.
References:  PMID:12507420, PMID:12925128,
PMID:14523544
2)  GO:NewTerm pattern binding
Synonym:  pattern recognition activity [~ synonym]
Definition:  Interacting selectively with a repeating or
polymeric structure, such as a polysaccharide or
peptidoglycan.
Parentage:  is-a to GO:0005488 binding.
Comment:  Note that this term and its child terms are
intended for annotation of gene products which function to
recognize (bind) the repeating structural units such as
polysaccharides or peptidoglycans commonly found in
microbial cell walls and virions.  If such binding is coupled to
signal transduction, use GO:0008329 pattern recognition
receptor activity instead.
References:  PMID:12225919, PMID:12507420,
PMID:12925128, PMID:14523544, PMID:12072369
[there may be some objection to the naming of this term,
and certainly the term name and its synonym could be
switched if necessary.]
3) GO:0030247 polysaccharide binding
Revised parentage:  is-a to GO:0030246 carbohydrate
binding, is-a to the new term "pattern binding," above.
4)  GO:NewTerm polysaccharide receptor activity
Definition:  Combining with a polysaccharide to initiate a
change in cell activity.
Parentage:  is-a to GO:0030247 polysaccharide binding, is-a
to GO:0008329 pattern recognition receptor activity.
References:  PMID:14707091
5)  GO:NewTerm zymosan binding
Definition:  Interacting selectively with zymosan.
Parentage:  is-a to GO:0030247 polysaccharide binding.
References:  PMID:14707091
6)  GO:NewTerm zymosan receptor activity
Definition:  Combining with zymosan to initiate a change in
cell activity.
Parentage:  is-a to the new term "polysaccharide receptor
activity," above.
References:  PMID:14707091
7)  GO:0001530 lipopolysaccharide binding
New synonym:  LPS binding [= exact synonym]
New synonym: endotoxin binding [< broad synonym]
Current definition:  Interacting selectively with
lipopolysaccharide (LPS, endotoxin in the outer membrane in
Gram-negative bacteria) to membrane bound CD14 in
monocytes and macrophages, as well as soluble CD14.
Facilitated by a lipopolysaccharide binding protein.
Revised definition: Interacting selectively with
lipopolysaccharide.
[The revised definition is more in conformance to GO
standard definitions, grammatically correct, and does not
add unnecessary specificity, when in fact the range of
cellular receptors for LPS is still unclear.]
Revised parentage:  is-a to the new term "pattern binding,"
above.
8)  GO:NewTerm lipopolysaccharide receptor activity
Synonym:  LPS receptor activity [= exact synonym]
Synonym: endotoxin receptor activity [< broad synonym]
Definition:  Combining with lipopolysaccharide to initiate a
change in cell activity.
Parentage:  is-a to GO:0001530 lipopolysaccharide binding,
is-a to GO:0008329 pattern recognition receptor activity.
References:  PMID:14609719
9)  GO:NewTerm lipoarabinomannan binding
Synonym:  LAM binding.
Definition:  Interacting selectively with lipoarabinomannan.
Parentage:  is-a to the new term "pattern binding," above.
References:  PMID:10586073
10)  GO:NewTerm lipoarabinomannan receptor activity
Synonym:  LAM receptor activity.
Definition:  Combining with lipoarabinomannan to initiate a
change in cell activity.
Parentage: is-a to the new term "lipoarabinomannan
binding," above, is-a to GO:0008329 pattern recognition
receptor activity.
References:  PMID:10586073
11)  GO:0042834 peptidoglycan binding
Revised parentage: is-a to the new term "pattern binding,"
above.
[The existing parentage of GO:0042834 peptidoglycan
binding is not quite right:  while peptidoglycan is often a
component of bacterial cell wall, because it can be found in
isolation, binding of peptidoglycan is not strictly a type of
bacterial binding.  Also, Harold and I agree that due to its
peptide components peptidoglycan is not strictly a type of
carbohydrate, just as LPS and LAM are not either due to
their lipid components.]
Reference:  PMID:14698226
12) GO:0016019 peptidoglycan recognition activity
I recommend the name of this term be changed to
"peptidoglycan receptor activity," in order to conform to GO
naming standards and avoid confusion with GO:0042834
peptidoglycan binding.  The name change is justified also by
the position of GO:0016019 in the DAG as a descendent of
receptor activity.  The existing name should be kept as a
synonym (~ synonym).
I also propose that GO:0016019 be given the following
definition , revised parentage, and comment.
Definition:  Combining with a peptidoglycan to initiate a
change in cell activity.
Revised parentage:  is-a to GO:0042834 peptidoglycan
binding, is-a to GO:0008329 pattern recognition receptor
activity.
Comment:  Note that only peptidoglycan recognition proteins
with receptor activity should be annotated to this term;
otherwise use GO:0042834 peptidoglycan binding instead.
Reference:  PMID:14698226
13)  GO:NewTerm response to yeast
Definition:  A change in state or activity of an organism (in
terms of movement, secretion, enzyme production, gene
expression, etc.) as a result of the perception of yeast.
Parentage:  is-a to GO:0009607 response to biotic stimulus
References:  PMID:14707091
14)  GO:NewTerm detection of yeast
Definition:  The series of events by which a stimulus from a
yeast is received and converted into a molecular signal.
Parentage:  is-a to GO:0009595 detection of biotic stimulus,
part-of to the new term "response to yeast," above
Reference:  PMID:14707091
15) GO:0005044 scavenger receptor activity
is undefined.
Proposed definition:  Combining with acetylated low-density
lipoproteins, advanced glycation end products, or other
polyanionic ligands to initiate a change in cell activity.
Proposed comment:  Note that many gene products that are
call "scavenger receptors" have a broad range of potential
ligands and also can be annotated to GO:0008329 pattern
recognition receptor activity or its child terms, or to
GO:0030228 lipoprotein receptor activity or its child terms,
as well.
References:  PMID:11790542, PMID:12379907,
PMID:12621157
16)  GO:0008019 macrophage receptor activity should be
obsoleted.
This undefined term was probably created to annotate the
gene product MARCO, which really has both pattern
recognition receptor activity and scavenger receptor activity.
Calling something a macrophage receptor activity is
ambiguous in any case, because the term name could either
imply an activity of a gene product found on macrophages or
an activity used to detect macrophages.
Comment for obsoletion:  This term was obsoleted because
its name is ambiguous, and it was never defined.  Consider
annotating to the terms GO:0005044 scavenger receptor
activity or GO:0008329 pattern recognition receptor activity
or its child terms instead.
Reported by: addiehl
Original Ticket: "geneontology/ontology-requests/1707":https://sourceforge.net/p/geneontology/ontology-requests/1707

thanks www.movied.org


Future of this project

What will be the future of stackedit with the advent of classeur?

StackEdit is still maintained at the moment.


community: Schema support for SAP HANA Cloud Vector Engine

Description:
This PR adds support for explicit schema access to the VectorStore integration of SAP HANA Cloud Vector Engine.

Issue: N/A

Dependencies: no additional dependencies

Twitter handle: @sapopensource

Implementation:
libs/community/langchain_community/vectorstores/hanavector.py
Integration tests:
libs/community/tests/integration_tests/vectorstores/test_hanavector.py
Example notebook:
docs/docs/integrations/vectorstores/hanavector.ipynb

Hi @hwchase17 , @baskaryan
I'm a bit confused about the closing of the PR. Did I miss something in the updated contribution guidelines? Any hint is appreciated.
Thanks, Martin

not intentional, we can't reopen at the moment but will do so as soon as we can :/ See #16796


fix: remove the staking portfolio persistence modal

Checklist

[x] JIRA - LW-11897
[ ] Proper tests implemented
[ ] Screenshots added.

Proposed solution
The staking portfolio persistence info modal causes the Multi-delegation modal to close untimely. Since that modal is no longer necessary, removing it solves the issue with the multi-delegation modal.

Allure Report
allure-report-publisher generated test report!

processReports: ❌ test report for 7ccfdee9

passed
failed
skipped
flaky
total
result

Total
9
23
4
0
36
❌


Rust (ndarray) -> HDF5 -> Python (NumPy)?

Suppose I have some ndarray matrices/vectors which I store in an HDF5 database using the hdf5 crate.
Am I correct in understanding that if I open this database using Python's h5py, I can load the data into NumPy matrices, because HDF5's data representation is independent of ndarray and NumPy?

That's kind of the whole point, yes.


Cloud Foundation: fix networkPolicy type in GKE schema file

Any news on this one?

Thank you for your contribution and pointing out this error. We are fixing it here and in the new repo. I encourage you to use the new repo:
https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/pull/372

Fixed the enum declaration, looks good now.
Thank you for this!


Parsing .ubx files

I have created a .ubx file by using u-center with ZED-F9P and NEO-6M.
I just want to extract information like C/No values of the satellites or AGC count from .ubx file created by u-center.
Am I able to do that with this repo?

Hi @fener1efes2 ,
Yes, absolutely. The .ubx files created by u-center are simply files containing raw (binary) data from the GNSS device (including NMEA, UBX and/or RTCM protocols, depending on what the device is configured to output). Note that .ubx files may also contain proprietary UBX diagnostic and configuration data which the u-blox technical support team can use for testing and problem investigation.
You could for example use the ubxfile.py example in the /examples folder, or write something similar yourself.
https://github.com/semuconsulting/pyubx2/blob/master/examples/ubxfile.py
Alternatively you could use the gnssdump CLI utility which is installed with the pygnssutils library. This is essentially a CLI wrapper around the pyubx2 parser which offers a variety of formatting and filtering options.
https://github.com/semuconsulting/pygnssutils#gnssdump
for help at the command line, type gnssdump -h
Hope this helps


Issue1268 live query crash

Reproduction of issue 1268. TODO: Fix it!

@dfahlander Very nice!! What a strange issue. Thanks for your diligence. This is a great project and you've done great work here :)


BoostedTreesClassifier segmentation fault when evaluate or predict is called

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Mac Os X 10.15.7
TensorFlow installed from (source or binary): binary (pip installed)
TensorFlow version (use command below): tried with both 2.3.1 and 2.3.0
Python version: 3.8.5
CUDA/cuDNN version: running on Mac, no GPU support
GPU model and memory: as above

using this script
== check python ===================================================
python version: 3.8.5
python branch:
python build version: ('default', 'Sep 30 2020 08:41:45')
python compiler version: Clang 11.0.0 (clang-1<IP_ADDRESS>)
python implementation: CPython

== check os platform ===============================================

== are we in docker =============================================
No

== compiler =====================================================
Apple clang version 11.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

== check pips ===================================================
numpy                    1.18.5
protobuf                 3.14.0
tensorflow               2.3.0
tensorflow-estimator     2.3.0

== check for virtualenv =========================================
False

== tensorflow import ============================================
tf.version.VERSION = 2.3.0
tf.version.GIT_VERSION = v2.3.0-rc2-23-gb36436b087
tf.version.COMPILER_VERSION = 4.2.1 Compatible Apple LLVM 10.0.1 (clang-1<IP_ADDRESS>)

== env ==========================================================
LD_LIBRARY_PATH is unset
DYLD_LIBRARY_PATH is unset

== nvidia-smi ===================================================
run.sh:145: command not found: nvidia-smi

== cuda libs  ===================================================

== tensorflow installed from info ==================
Name: tensorflow
Version: 2.3.0
Summary: TensorFlow is an open source machine learning framework for everyone.
Home-page: https://www.tensorflow.org/
Author-email<EMAIL_ADDRESS>License: Apache 2.0
Location: /Users/cesco/Desktop/venv/lib/python3.8/site-packages
Required-by:

== python version  ==============================================
(major, minor, micro, releaselevel, serial)
(3, 8, 5, 'final', 0)

== bazel version  ===============================================

Describe the current behavior
I took this notebook and tried to run it on my local machine but it repeatedly crashed the jupyter kernel when trying to evaluate the model (the same happens with the .predict() method).
I then converted the notebook into a simple python script (I thought that perhaps is an issue with jupyter) using the command ipython nbconvert --to python and tried to run it.
This is the full output I got:
Feature value: "Third"
2020-12-11 14:07:55.153062: I tensorflow/core/platform/cpu_feature_guard.cc:142] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN)to use the following CPU instructions in performance-critical operations:  AVX2 FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2020-12-11 14:07:55.167575: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x7fd8db882480 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-12-11 14:07:55.167595: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
One-hot encoded:  [[0. 0. 1.]]
WARNING:tensorflow:Using temporary folder as model directory: /var/folders/4w/m2lqr9ts0q1dtnzgsx9gr3_40000gn/T/tmpy159zb62
WARNING:tensorflow:From /Users/cesco/Desktop/venv/lib/python3.8/site-packages/tensorflow/python/training/training_util.py:235: Variable.initialized_value (from tensorflow.python.ops.variables) is deprecated and will be removed in a future version.
Instructions for updating:
Use Variable.read_value. Variables in 2.X are initialized automatically both in eager and graph (inside tf.defun) contexts.
WARNING:tensorflow:Layer linear/linear_model is casting an input tensor from dtype float64 to the layer's dtype of float32, which is new behavior in TensorFlow 2.  The layer has dtype float32 because its dtype defaults to floatx.

If you intended to run this layer in float32, you can safely ignore this warning. If in doubt, this warning is likely only an issue if you are porting a TensorFlow 1.X model to TensorFlow 2.

To change all layers to have dtype float64 by default, call `tf.keras.backend.set_floatx('float64')`. To change just this layer, pass dtype='float64' to the layer constructor. If you are the author of this layer, you can disable autocasting by passing autocast=False to the base Layer constructor.

WARNING:tensorflow:From /Users/cesco/Desktop/venv/lib/python3.8/site-packages/tensorflow_estimator/python/estimator/canned/linear.py:1471: Layer.add_variable (from tensorflow.python.keras.engine.base_layer_v1) is deprecated and will be removed in a future version.
Instructions for updating:
Please use `layer.add_weight` method instead.
WARNING:tensorflow:From /Users/cesco/Desktop/venv/lib/python3.8/site-packages/tensorflow/python/keras/optimizer_v2/ftrl.py:111: calling Constant.__init__ (from tensorflow.python.ops.init_ops) with dtype is deprecated and will be removed in a future version.
Instructions for updating:
Call initializer instance with the dtype argument instead of passing it to the constructor
WARNING:tensorflow:Layer linear/linear_model is casting an input tensor from dtype float64 to the layer's dtype of float32, which is new behavior in TensorFlow 2.  The layer has dtype float32 because its dtype defaults to floatx.

If you intended to run this layer in float32, you can safely ignore this warning. If in doubt, this warning is likely only an issue if you are porting a TensorFlow 1.X model to TensorFlow 2.

To change all layers to have dtype float64 by default, call `tf.keras.backend.set_floatx('float64')`. To change just this layer, pass dtype='float64' to the layer constructor. If you are the author of this layer, you can disable autocasting by passing autocast=False to the base Layer constructor.

accuracy                  0.765152
accuracy_baseline         0.625000
auc                       0.832844
auc_precision_recall      0.789631
average_loss              0.478908
label/mean                0.375000
loss                      0.478908
precision                 0.703297
prediction/mean           0.350790
recall                    0.646465
global_step             100.000000
dtype: float64
WARNING:tensorflow:Using temporary folder as model directory: /var/folders/4w/m2lqr9ts0q1dtnzgsx9gr3_40000gn/T/tmpwwx0o5_p
WARNING:tensorflow:From /Users/cesco/Desktop/venv/lib/python3.8/site-packages/tensorflow_estimator/python/estimator/canned/boosted_trees.py:398: VocabularyListCategoricalColumn._num_buckets (from tensorflow.python.feature_column.feature_column_v2) is deprecated and will be removed in a future version.
Instructions for updating:
The old _FeatureColumn APIs are being deprecated. Please use the new FeatureColumn APIs instead.
WARNING:tensorflow:Issue encountered when serializing resources.
Type is unsupported, or the types of the items don't match field type in CollectionDef. Note this is a warning and probably safe to ignore.
'_Resource' object has no attribute 'name'
WARNING:tensorflow:Issue encountered when serializing resources.
Type is unsupported, or the types of the items don't match field type in CollectionDef. Note this is a warning and probably safe to ignore.
'_Resource' object has no attribute 'name'
WARNING:tensorflow:Issue encountered when serializing resources.
Type is unsupported, or the types of the items don't match field type in CollectionDef. Note this is a warning and probably safe to ignore.
'_Resource' object has no attribute 'name'
WARNING:tensorflow:It seems that global step (tf.train.get_global_step) has not been increased. Current value (could be stable): 0 vs previous value: 0. You could increase the global step by passing tf.train.get_global_step() to Optimizer.apply_gradients or Optimizer.minimize.
WARNING:tensorflow:Issue encountered when serializing resources.
Type is unsupported, or the types of the items don't match field type in CollectionDef. Note this is a warning and probably safe to ignore.
'_Resource' object has no attribute 'name'
WARNING:tensorflow:From /Users/cesco/Desktop/venv/lib/python3.8/site-packages/tensorflow_estimator/python/estimator/canned/head.py:637: auc (from tensorflow.python.ops.metrics_impl) is deprecated and will be removed in a future version.
Instructions for updating:
The value of AUC returned by this may race with the update so this is deprecated. Please use tf.keras.metrics.AUC instead.
WARNING:tensorflow:Trapezoidal rule is known to produce incorrect PR-AUCs; please switch to "careful_interpolation" instead.
WARNING:tensorflow:Trapezoidal rule is known to produce incorrect PR-AUCs; please switch to "careful_interpolation" instead.
[1]    76205 segmentation fault  python boosted_trees.py

Describe the expected behavior
I would expect the jupyter notebook kernel not to crash, and the script not to have a segmentation fault.
Standalone code to reproduce the issue
The part that cause the crash is when the BoostedTreesClassifier is used for predict or estimate.
The shortest script I could come up to reproduce is:
import pandas as pd

# Load dataset.
dftrain = pd.read_csv('https://storage.googleapis.com/tf-datasets/titanic/train.csv')
dfeval = pd.read_csv('https://storage.googleapis.com/tf-datasets/titanic/eval.csv')
y_train = dftrain.pop('survived')
y_eval = dfeval.pop('survived')

import tensorflow as tf
tf.random.set_seed(123)

CATEGORICAL_COLUMNS = ['sex', 'n_siblings_spouses', 'parch', 'class', 'deck',
                       'embark_town', 'alone']
NUMERIC_COLUMNS = ['age', 'fare']

def one_hot_cat_column(feature_name, vocab):
  return tf.feature_column.indicator_column(
      tf.feature_column.categorical_column_with_vocabulary_list(feature_name,
                                                 vocab))
feature_columns = []
for feature_name in CATEGORICAL_COLUMNS:
  # Need to one-hot encode categorical features.
  vocabulary = dftrain[feature_name].unique()
  feature_columns.append(one_hot_cat_column(feature_name, vocabulary))

for feature_name in NUMERIC_COLUMNS:
  feature_columns.append(tf.feature_column.numeric_column(feature_name,
                                           dtype=tf.float32))

example = dict(dftrain.head(1))
class_fc = tf.feature_column.indicator_column(tf.feature_column.categorical_column_with_vocabulary_list('class', ('First', 'Second', 'Third')))

# Use entire batch since this is such a small dataset.
NUM_EXAMPLES = len(y_train)

def make_input_fn(X, y, n_epochs=None, shuffle=True):
  def input_fn():
    dataset = tf.data.Dataset.from_tensor_slices((dict(X), y))
    if shuffle:
      dataset = dataset.shuffle(NUM_EXAMPLES)
    # For training, cycle thru dataset as many times as need (n_epochs=None).
    dataset = dataset.repeat(n_epochs)
    # In memory training doesn't use batching.
    dataset = dataset.batch(NUM_EXAMPLES)
    return dataset
  return input_fn

# Training and evaluation input functions.
train_input_fn = make_input_fn(dftrain, y_train)
eval_input_fn = make_input_fn(dfeval, y_eval, shuffle=False, n_epochs=1)

n_batches = 1
est = tf.estimator.BoostedTreesClassifier(feature_columns,
                                          n_batches_per_layer=n_batches)

# The model will stop training once the specified number of trees is built, not
# based on the number of steps.
est.train(train_input_fn, max_steps=100)

# Eval.
est.evaluate(eval_input_fn)

Other info / logs Include any logs or source code that would be helpful to
From pip freeze:
absl-py==0.10.0
appnope==0.1.2
argon2-cffi==20.1.0
astunparse==1.6.3
async-generator==1.10
attrs==20.3.0
backcall==0.2.0
bleach==3.2.1
cachetools==4.2.0
certifi==2020.12.5
cffi==1.14.4
chardet==3.0.4
cycler==0.10.0
decorator==4.4.2
defusedxml==0.6.0
dill==0.3.3
entrypoints==0.3
future==0.18.2
gast==0.3.3
google-auth==1.23.0
google-auth-oauthlib==0.4.2
google-pasta==0.2.0
googleapis-common-protos==1.52.0
grpcio==1.34.0
h5py==2.10.0
idna==2.10
importlib-resources==3.3.0
ipykernel==5.4.0
ipython==7.19.0
ipython-genutils==0.2.0
ipywidgets==7.5.1
jedi==0.17.2
Jinja2==2.11.2
joblib==0.17.0
jsonschema==3.2.0
jupyter==1.0.0
jupyter-client==6.1.7
jupyter-console==6.2.0
jupyter-core==4.7.0
jupyterlab-pygments==0.1.2
Keras-Preprocessing==1.1.2
kiwisolver==1.3.1
Markdown==3.3.3
MarkupSafe==1.1.1
matplotlib==3.3.3
mistune==0.8.4
nbclient==0.5.1
nbconvert==6.0.7
nbformat==5.0.8
nest-asyncio==1.4.3
notebook==6.1.5
numpy==1.18.5
oauthlib==3.1.0
opt-einsum==3.3.0
packaging==20.7
pandas==1.1.5
pandocfilters==1.4.3
parso==0.7.1
pexpect==4.8.0
pickleshare==0.7.5
Pillow==8.0.1
prometheus-client==0.9.0
promise==2.3
prompt-toolkit==3.0.8
protobuf==3.14.0
ptyprocess==0.6.0
pyarrow==2.0.0
pyasn1==0.4.8
pyasn1-modules==0.2.8
pycparser==2.20
Pygments==2.7.3
pyparsing==2.4.7
pyrsistent==0.17.3
python-dateutil==2.8.1
pytz==2020.4
pyzmq==20.0.0
qtconsole==5.0.1
QtPy==1.9.0
requests==2.25.0
requests-oauthlib==1.3.0
rsa==4.6
scikit-learn==0.23.2
scipy==1.4.1
Send2Trash==1.5.0
six==1.15.0
sklearn==0.0
tensorboard==2.4.0
tensorboard-plugin-wit==1.7.0
tensorflow==2.3.0
tensorflow-estimator==2.3.0
termcolor==1.1.0
terminado==0.9.1
testpath==0.4.4
threadpoolctl==2.1.0
tornado==6.1
tqdm==4.54.1
traitlets==5.0.5
urllib3==1.26.2
wcwidth==0.2.5
webencodings==0.5.1
Werkzeug==1.0.1
widgetsnbextension==3.5.1
wrapt==1.12.1

Further info. I now tried to run it inside docker python:3.8 and it works.
It seems to be an issue with Mac Os X.
I asked a colleague of mine (who also has a mac) to try the same and he got this error instead (again at the .evaluate() point):
[libprotobuf FATAL ./google/protobuf/arena_impl.h:160] CHECK failed: (limit_) >= (ptr_):
libc++abi.dylib: terminating with uncaught exception of type google::protobuf::FatalException: CHECK failed: (limit_) >= (ptr_):

@francesco086,
I was able to run the code with TensorFlow v2.3 on Linux without any issues. Please find the gist of it here.
Could you please try running the code in a new virtual environment and with TF v2.4.0rc4 or TF-nightly and check if you are facing the same issue? Thanks!

Please read the message above yours - with Docker it worked. It is an issue on Mac Os X.

@francesco086,
Thank you for the update. The gist was just to verify if there is an issue with the code itself, which does not seem to be the case here.
Could you please check if you are facing the same issue with TF v2.4 and TF-nightly as well. Thanks!

@amahendrakar
Tried with v2.4.0 and it works. Thanks :)


Program cannot find my Discord installation and this time it's not just about /usr/share

I've used BetterDiscordCTL before, but this is a new computer and I've had to reinstall Discord and then BetterDiscord.  Well, nothing is working, Discord is just showing up as normal without any sign of BetterDiscord.
I use Ubuntu Xenial Xerus (well, Zorin 12.4 Lite, a variant of it) and am aware of the thing where you have to set the scan directory to /usr/share, and that used to work on the old computer (which ran the equivalent of Trusty, actually, not Xenial, just mentioning that in case it turns out to be relevant), but this time it doesn't work.
Here's what I got out of it on the last round of attempts:
user@user-HP-Pavilion-Laptop-15-cw0xxx:~$ betterdiscordctl upgrade
/usr/local/bin/betterdiscordctl: line 597: $2=(${major@Q} ${minor@Q} ${patch@Q} ${pre@Q} ${build@Q}): bad substitution
/usr/local/bin/betterdiscordctl: line 597: $2=(${major@Q} ${minor@Q} ${patch@Q} ${pre@Q} ${build@Q}): bad substitution
/usr/local/bin/betterdiscordctl: line 610: x[i]: unbound variable
user@user-HP-Pavilion-Laptop-15-cw0xxx:~$ betterdiscordctl install
ERROR: Discord installation not found.
user@user-HP-Pavilion-Laptop-15-cw0xxx:~$ betterdiscordctl upgrade -s /usr/share/usr/local/bin/betterdiscordctl: line 597: $2=(${major@Q} ${minor@Q} ${patch@Q} ${pre@Q} ${build@Q}): bad substitution
/usr/local/bin/betterdiscordctl: line 597: $2=(${major@Q} ${minor@Q} ${patch@Q} ${pre@Q} ${build@Q}): bad substitution
/usr/local/bin/betterdiscordctl: line 610: x[i]: unbound variable
user@user-HP-Pavilion-Laptop-15-cw0xxx:~$ betterdiscordctl install -s /usr/share
Updating asar...
/usr/bin/env: ‘node’: No such file or directory
user@user-HP-Pavilion-Laptop-15-cw0xxx:~$ betterdiscordctl reinstall -s /usr/share
Not installed.
user@user-HP-Pavilion-Laptop-15-cw0xxx:~$ betterdiscordctl update -s /usr/share
Not installed.

I assure you Discord IS installed, and it seems to be impying that Node is not installed but I assure you that that is installed too.  I don't know what it is, but I've installed it (both npm and nodejs) repeatedly!

Refer to #28.
You need either nodejs-legacy or [NodeSource] (/nodesource/distributions)'s package.


Add Codecov to general_test job

Description
Adds Codecov integration to general_test job in Build & Test GH Actions extracting CODECOV_TOKEN from Akeyless.
Other changes
Adds --coverage flag to Run Jest Tests step to generate reports.
Tested
Results can be seen here:

Related issues

#212

Backwards compatibility
No code modifications
Documentation
N/A

It looks like the workflow is exiting with an error:
Codecov:
                      Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

Some threads with a similar error message:

https://github.com/codecov/codecov-action/issues/598
https://github.com/codecov/codecov-action/issues/1274
Upload Issues (Unable to locate build via Github Actions API)

Hey @arthurgousset !
Based on the logs of the workflow, I would say the problem is that it cannot find any code coverage reports to upload to Codecov: https://github.com/celo-org/developer-tooling/actions/runs/8519501928/job/23333673813#step:5:86.

So, I do not know if this repo is configured to do that, and if so, where those reports would be stored/generated

Looks like for some reason packages/sdk/contractkit and packages/cli do not have a coverage report here:

Source: https://app.codecov.io/gh/celo-org/developer-tooling/tree/test-codecov/packages%2Fsdk

Looks like it might be the case because of these lines:
https://github.com/celo-org/developer-tooling/blob/7c297e778d1e18470c18db5302862aa76f3a4677/.github/workflows/ci.yml#L160-L166

Looks like it might be the case because of these lines:
https://github.com/celo-org/developer-tooling/blob/7c297e778d1e18470c18db5302862aa76f3a4677/.github/workflows/ci.yml#L160-L166

yes because this PR specifically says it collects for the general_test case
the cli and contractkit have their own test cases

To upload, the other test maybe we simply need to add similar lines in
https://github.com/celo-org/developer-tooling/blob/7c297e778d1e18470c18db5302862aa76f3a4677/.github/workflows/ci.yml#L198-L200
https://github.com/celo-org/developer-tooling/blob/7c297e778d1e18470c18db5302862aa76f3a4677/.github/workflows/ci.yml#L221-L223

yes because this PR specifically says it collects for the general_test job
the cli and contractkit have their own test jobs
TLDR dont change those lines

Makes sense 👍 I don't mind if it's done in a separate PR or here.
Overall, I'm just keen to have coverage reports for all packages if possible to close this issue:

https://github.com/celo-org/developer-tooling/issues/212

To upload, the other test maybe we simply need to add similar lines in
https://github.com/celo-org/developer-tooling/blob/7c297e778d1e18470c18db5302862aa76f3a4677/.github/workflows/ci.yml#L198-L200
https://github.com/celo-org/developer-tooling/blob/7c297e778d1e18470c18db5302862aa76f3a4677/.github/workflows/ci.yml#L221-L223

yeah either will need to duplicate the step in each job. or have a job that depends on all the others before running.
the second is cleaner but might require some step that saves the files between jobs.

Turns out @alvarof2 had already thought of this

👋 Hi @arthurgousset !
After some fighting, managed to integrate Codecov to general_test job in Build & Test GH Action (PR #211). There are other jobs in the workflow for other tests, like wallet-test or contractkit-tests, but unsure if it should be integrated there also. In that case, I would suggest getting the token in 1 job and sharing it for others, but I leave that kind of decisions to the team :).

Source: https://github.com/celo-org/developer-tooling/issues/212#issuecomment-2034177766


Fix deprecation warnings (breaking)

I've been keeping a list of the deprecation errors we receive as part of Records Mover usage / builds.
This also revealed along the way that I forgot to remove some deprecated factor method arguments.
There are still some Airflow deprecation warnings that are false alarms - there's an unresolved issue here: https://issues.apache.org/jira/browse/AIRFLOW-5138

It's one thing.


Missing space after : on "Recently Updated"

The space after the : on the "Recently Updated" list got lost recently, which looks a bit odd:

vs a version from April 2016:

Looks like this should've been closed after #390 was merged.


Can i use it to detect device on my router network ?

I need do detect ip cameras. What kind of scan should i launch

Depends on the brand of your cameras, and if they actually broadcast themselves on the network, you need to look into their documentation.


Draw geometry only once if layer has no aes mapping specified

Currently such a "fixed" geometry is drawn at the same location over and over, for each data-point in the input data frame. This doesn't make a lot of sense.
Example: https://nbviewer.jupyter.org/github/denisvstepanov/lets-plot-examples/blob/master/Bayesian inference.ipynb
The issue is not visible but note the "sampling" messages for text layer.

Related to #140


combine all binaries into one

Feature Request
Is your feature request related to a problem? Please describe:
Now we have three binaries: tikv-server, tikv-ctl and tikv-importer. Compiling them all may take a long time, and another problem is that people may misuse different versions, e.g. one people used an old tikv-ctl to access tikv-server.
Describe the feature you'd like:
We may combine all into one binary, I guess this can also improve the compiling time. /cc @brson
So now there is only one binary, assume the name is tikv, so the commands look:
tikv server xxx
tikv ctl xxx
tikv importer xxx

To support compatibility, we may provide a tikv-server, tikv-ctl, tikv-importer script, like:
# tikv-server
tikv server $@

Describe alternatives you've considered:
Teachability, Documentation, Adoption, Migration Strategy:
Some documents should be changed:

The binary deployment
Docker
tikv-ctl
Lighting

The ansible and K8s operator should also be changed.

I don't think this will improve compile time. When building three binaries, they are compiled in parallel. And tikv-server is always the last one that finish compilation.
The overall idea looks good to me.

This is a super great idea!

We should consider that if we do this with TiKV the same should be done for PD to maintain consistency.

I think probably it makes sense.
If there were a way to run a post-install script, we could even preserve the existing names by linking e.g. tikv-server, tikv-ctl etc all to the same binary. But just making them all one binary and changing the command format is also fine. Similarly for backwards compat, sym/hardlinks could link tikv-server etc to the new tikv command.
For less parallel builds it will improve build times. It will make tikv-ctl only builds impossible - so that it takes just as long to build that feature as tikv-server, which is probably fine. It will reduce memory consumption during parallel builds by only running LTO and the linker once.
I can't think of a great downside, except that it could be argued to violate the single responsibility principle.
Doing this would decrease the distribution size.
It could be worth considering something similar for the benchmarks - I noted it takes me 95 minutes to build all the benchmarks with thinLTO. Though that would make it take longer to build individual benchmarks.

Note that we've split tikv-importer into its own repository (https://github.com/tikv/importer) and the copy here will soon be deleted on master.

It is very easy to try this idea out by putting all the binaries into a single docker container. Create a dispatch shell script called tikv if you want. See jaeger all in one for inspiration. Note this can also be done just by putting all binaries into a single directory.
Note that with this approach it is also easy to add in PD, whereas this issue does mention PD, presumably because combining go and Rust into a single binary is harder.

As for compatibility, the hyperkube approach is a good solution. The hyperkube is a binary wrapper for all the k8s binaries, when running hyperkube --make-symlinks, it will create all the symbolic links to hyperkube, and invoking hyperkube <component> is equivalent to <component>, for example to run kubectl, users can also run hyperkube kubectl.
To try and play yourself, you can use the following command to enter the hyperkube docker image:
docker run -it --rm --entrypoint=bash k8s.gcr.io/hyperkube-amd64:v1.12.2
# ls -l
total 242276
lrwxrwxrwx   1 root root        10 Oct 24  2018 aggregator -> /hyperkube
lrwxrwxrwx   1 root root        10 Oct 24  2018 apiserver -> /hyperkube
drwxr-xr-x   1 root root      4096 Sep 18  2018 bin
drwxr-xr-x   2 root root      4096 Jun 26  2018 boot
lrwxrwxrwx   1 root root        10 Oct 24  2018 controller-manager -> /hyperkube
drwxr-xr-x   5 root root       360 Jun 17 23:07 dev
drwxr-xr-x   1 root root      4096 Jun 17 23:07 etc
drwxr-xr-x   2 root root      4096 Jun 26  2018 home
-rwxr-xr-x   1 root root 248021112 Oct 24  2018 hyperkube
lrwxrwxrwx   1 root root        10 Oct 24  2018 kubectl -> /hyperkube
lrwxrwxrwx   1 root root        10 Oct 24  2018 kubelet -> /hyperkube
drwxr-xr-x   1 root root      4096 Sep 18  2018 lib
drwxr-xr-x   2 root root      4096 Jul 16  2018 lib64
drwxr-xr-x   2 root root      4096 Jul 16  2018 media
drwxr-xr-x   2 root root      4096 Jul 16  2018 mnt
drwxr-xr-x   1 root root      4096 Sep 18  2018 opt
dr-xr-xr-x 763 root root         0 Jun 17 23:07 proc
lrwxrwxrwx   1 root root        10 Oct 24  2018 proxy -> /hyperkube
drwx------   2 root root      4096 Aug 10  2018 root
drwxr-xr-x   1 root root      4096 Sep 18  2018 run
drwxr-xr-x   1 root root      4096 Sep 18  2018 sbin
lrwxrwxrwx   1 root root        10 Oct 24  2018 scheduler -> /hyperkube
drwxr-xr-x   2 root root      4096 Jul 16  2018 srv
dr-xr-xr-x  13 root root         0 May  7 06:58 sys
drwxrwxrwt   1 root root      4096 Sep 18  2018 tmp
drwxr-xr-x   1 root root      4096 Jul 16  2018 usr
drwxr-xr-x   1 root root      4096 Jul 16  2018 var
# /hyperkube kubectl version
Client Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.2", GitCommit:"17c77c7898218073f14c8d573582e8d2313dc740", GitTreeState:"clean", BuildDate:"2018-10-24T06:43:59Z", GoVersion:"go1.10.4", Compiler:"gc", Platform:"linux/amd64"}
The connection to the server localhost:8080 was refused - did you specify the right host or port?


Empty Brackets: [] in generated output

Description
It seems like latest version of Paket is include [] in the output produced
Expected behavior
Running with gitlab-ci-multi-runner 9.2.0 (adfc387)
  on gitlab-deployment (65b3c57f)
Using Shell executor...
Running on WIN-Q5OU5O5N8MG...
Cloning repository...
Cloning into 'D:/gitlab/builds/65b3c57f/0/Shared/Infrastructure'...
Checking out ddc0885a as develop...
Skipping Git submodules setup
$ build.bat
Checking Paket version (downloading latest stable)...
Copying version 5.92.5 from cache.
Done.
Paket version 5.92.5
Downloading <IP_ADDRESS>_12345/:/api/v1/raw/Shared/References/raw/4e4774656a6ce2de3fca42c3293275bdc465cf27/References/Cake/utilities.cake utilities.cake to D:\gitlab\builds\65b3c57f\0\Shared\Infrastructure\paket-files\<IP_ADDRESS>_12345\utilities.cake
Downloading <IP_ADDRESS>_12345/:/api/v1/artifact/{REFS_BUILD}/Shared/References/{BUILD_ARCH}/net40/Odp/{ODP_VERSION}/{ODP_DLL} {ODP_DLL}.fs to D:\gitlab\builds\65b3c57f\0\Shared\Infrastructure\paket-files\<IP_ADDRESS>_12345\{ODP_DLL}.fs
Resolving packages for group Main:
 - SharpRaven 2.1
 - Cake 0.21.1
 - GitInfo 2.0.1
 - xunit 2.2
 - xunit.abstractions 2.0.1
 - xunit.assert 2.2
 - xunit.core 2.2
 - xunit.extensibility.core 2.2
 - xunit.extensibility.execution 2.2
 - xunit.runner.console 2.2
 - Newtonsoft.Json 10.0.3
Locked version resolution written to D:\gitlab\builds\65b3c57f\0\Shared\Infrastructure\paket.lock
Installing into projects:
 - Creating model and downloading packages.
Could not detect any platforms from '_desktop' in 'D:\gitlab\builds\65b3c57f\0\Shared\Infrastructure\packages\xunit.core\build\_desktop\xunit.execution.desktop.dll', please tell the package authors
 - Core/Core.csproj.paket.references -> Core/Core.csproj
 - Core.DB/Core.DB.csproj.paket.references -> Core.DB/Core.DB.csproj
Performance:
 - Resolver: 12 seconds (1 runs)
    - Runtime: 400 milliseconds
    - Blocked (retrieving package details): 271 milliseconds (9 times)
    - Blocked (retrieving package versions): 11 seconds (4 times)
    - Not Blocked (retrieving package versions): 7 times
    - Not Blocked (retrieving package details): 2 times
 - Disk IO: 4 seconds
 - Average Download Time: 88 milliseconds
 - Number of downloads: 2
 - Average Request Time: 3 seconds
 - Number of Requests: 18
 - Runtime: 19 seconds
Paket omitted '1' warnings similar to the ones above. You can see them in verbose mode

Actual behavior
Running with gitlab-ci-multi-runner 9.2.0 (adfc387)
  on gitlab-deployment (65b3c57f)
Using Shell executor...
Running on WIN-Q5OU5O5N8MG...
Cloning repository...
Cloning into 'D:/gitlab/builds/65b3c57f/0/Shared/Infrastructure'...
Checking out d0f76eb5 as develop...
Skipping Git submodules setup
$ build.bat -target=Unified -output=Y
Checking Paket version (downloading latest stable)...
Copying version 5.92.100 from cache.
Done.
Paket version 5.92.100
Downloading <IP_ADDRESS>_12345/:/api/v1/raw/Shared/References/raw/4e4774656a6ce2de3fca42c3293275bdc465cf27/References/Cake/utilities.cake utilities.cake to D:\gitlab\builds\65b3c57f\0\Shared\Infrastructure\paket-files\<IP_ADDRESS>_12345\utilities.cake
Downloading <IP_ADDRESS>_12345/:/api/v1/artifact/{REFS_BUILD}/Shared/References/{BUILD_ARCH}/net40/Odp/{ODP_VERSION}/{ODP_DLL} {ODP_DLL}.fs to D:\gitlab\builds\65b3c57f\0\Shared\Infrastructure\paket-files\<IP_ADDRESS>_12345\{ODP_DLL}.fs
Resolving packages for group Main:
 - SharpRaven 2.1
 - Cake 0.21.1
 - GitInfo 2.0.1
 - xunit 2.2
 - xunit.abstractions 2.0.1
 - xunit.assert 2.2
 - xunit.core 2.2
 - xunit.extensibility.core 2.2
 - xunit.extensibility.execution 2.2
 - xunit.runner.console 2.2
 - Newtonsoft.Json 10.0.3
Locked version resolution written to D:\gitlab\builds\65b3c57f\0\Shared\Infrastructure\paket.lock
Installing into projects:
 - Creating model and downloading packages.
Could not detect any platforms from '_desktop' in 'D:\gitlab\builds\65b3c57f\0\Shared\Infrastructure\packages\xunit.core\build\_desktop\xunit.execution.desktop.dll', please tell the package authors
 - Core/Core.csproj.paket.references -> Core/Core.csproj
D:\gitlab\builds\65b3c57f\0\Shared\Infrastructure\packages\GitInfo
[]
 - Core.DB/Core.DB.csproj.paket.references -> Core.DB/Core.DB.csproj
Performance:
 - Resolver: 8 seconds (1 runs)
    - Runtime: 392 milliseconds
    - Blocked (retrieving package details): 264 milliseconds (10 times)
    - Blocked (retrieving package versions): 7 seconds (4 times)
    - Not Blocked (retrieving package versions): 7 times
    - Not Blocked (retrieving package details): 1 times
 - Disk IO: 4 seconds
 - Average Download Time: 153 milliseconds
 - Number of downloads: 2
 - Average Request Time: 2 seconds
 - Number of Requests: 18
 - Runtime: 15 seconds
Paket omitted 1 warnings similar to the ones above. You can see them in verbose mode.

See
D:\gitlab\builds\65b3c57f\0\Shared\Infrastructure\packages\GitInfo
[]

oO can you post the depsfile or is this everywhere now?

depsfile is probably not enough we need a repro

Hi, @matthid thanks for your quick response. please find the attached minimal repro scenario
PaketRepScenario.zip


Fix lua-dev dep for Fedora

Fedora 20+ have Lua 5.2 which is not fully API compatible with Lua 5.1. However, Lua 5.1 is available in f20+ as the compat-lua package.
Example build break: https://csc.mcs.sdsmt.edu/jenkins/job/ros-indigo-ocl_binaryrpm_21_x86_64/2/consoleFull
Kudos to @jpgr87 for discovering this fix

Looks like that upstream bug is back.
See https://github.com/ros/rosdistro/pull/6738

The error message does not look like being related to unidiff itself. It seams more like the test_url_validity.py does not handle non-ascii characters correctly. @tfoote can you please look into this and create a PR which fixes the test script? The PR should contain a temporary commit (like this one) which contains special characters.

replaced by #6989


Re-add weights_and_measures to API docs

Something I missed when moving this module from the resqpy.olio subdirectory!

Codecov Report

Merging #145 (0db4c4a) into master (37186f6) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   41.77%   41.78%   +0.01%
==========================================
  Files          51       51
  Lines       21491    21462      -29
==========================================
- Hits         8977     8968       -9
+ Misses      12514    12494      -20

Impacted Files
Coverage Δ

resqpy/__init__.py
50.00% <ø> (ø)

resqpy/olio/simple_lines.py
42.60% <0.00%> (-0.50%)
:arrow_down:

resqpy/olio/wellspec_keywords.py
71.00% <0.00%> (-0.29%)
:arrow_down:

resqpy/olio/transmission.py
75.70% <0.00%> (-0.04%)
:arrow_down:

resqpy/grid_surface.py
79.39% <0.00%> (-0.03%)
:arrow_down:

resqpy/olio/keyword_files.py
44.30% <0.00%> (-0.01%)
:arrow_down:

resqpy/grid.py
38.32% <0.00%> (+0.01%)
:arrow_up:

resqpy/olio/vdb.py
11.43% <0.00%> (+0.01%)
:arrow_up:

resqpy/lines.py
18.24% <0.00%> (+0.02%)
:arrow_up:

resqpy/fault.py
37.60% <0.00%> (+0.04%)
:arrow_up:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37186f6...0db4c4a. Read the comment docs.


Bug: Popup while logout

What happened?
While clicking logout button , popup should show so that user will not accidentely click logout.
Add screenshots

What browsers are you seeing the problem on?
Firefox, Chrome, Safari, Microsoft Edge, Brave
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue

What is the benefit of showing this popul instead there should be clear guidelines and ui so that it doesn't happen!!
Explain your issue benefit and it's alternative


feat:add meetup link icon in the footer

Description
Added a meetup link button in the footer
Fixes #1434
Type of change

[Y] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Tested locally and Works Fine!
Checklist:

[Y] I have performed a self-review of my own code
[Y] My changes generate no new warnings
[Y] New and existing unit tests pass locally with my changes

Screenshots or example output

Hello @Meetverma, please refrain from making these types of commits in the future

Thanks @priyankarpal
That Was my first commit to react-play...
Looking forward for more contributions :)


Example for the point chart

The following example works correctly:
const config = {
  type: 'point',
  toLine: false,
  grid: true,
  radius: 5,
};

However, there is a point on the ordinate axis which is not usually found on a graph like this.

Thank you for your suggestions, this is how the graphics are displayed, but this may be an option added later if it bothers users
Example for the chartJs library :


New 2023 Range Rover Sport Hybrid problems disconnecting charge cable

I do not know if this is an issue with the car or SmartEVSE.
When I had this car for a test drive I was wondering at what speed it would charge. I connected the cable to the car and charging started just as it always does on my BMW. After 10 minutes I wanted to stop the charge and drive the car. Strangely enough I could not get the cable to release from the car.
The Range Rover Sport has an unlock button next to the cable. The charge indicator changes from green to white but the locking mechanism was not unlocked. I tried disabling the SmartEVSE but the car just showed a message on the dashboard "Initializing".
After contacting the dealer we tried all sorts of procedures. When the car was locked again it would restart charging but every attempt at stopping the charge would signal "Initializing" and a locked cable...
In the end we found there was an emergency release cable in the luggage department behind a small door. This finally released the cable.
Because it was a test drive I cannot check the car again. I Hope it was a car issue, the dealer said they charged the car daily with another charger without issue. So maybe SmartEVSE does not work with Range Rover?
Any one else have this issue?

The EV is in control of releasing the cable, it has nothing to do with the SmartEVSE.
That can only control an actuator, if installed, for locking a non-fixed cable to the charger socket (so not the EV socket).


Bring the URL/Filepath back to specify where the manifest of knative is

I used to drop our option to configure where to load the manifest of knative, used to be here: https://github.com/knative/serving-operator/blob/ac0b67795238a05cd2dec22ae7aad13d8f28b7cc/pkg/controller/knativeserving/knativeserving_controller.go#L48, due to forgotten reasons, I am again leaning on to bring similar configuration option back to operator.
We used to load this argument, when launching the operator itself. I am considering adding it as a field in the CRD, because it can be configured when operator is running.
If we make it configurable when starting the operator, we can only configure it once. Otherwise, we have to re-launch the operator.
Problem
Each version of operator installs one specific version of knative software, and it only bundles in the image one specific version of released manifest for knative. However, different cloud platform may customize the manifest of knative.  How can we use this operator to install customized manifest, without shipping new image?
Persona:
Human operator, administrator.
Exit Criteria
Pick up a specific cloud platform, like Google, OpenShift, IBM cloud, etc, as long as the manifest is at the same version as the open source one, but different in content or configuration, we can test if operator can load the manifest from a different location, rather than the one bundled in the image.
Time Estimate (optional):
1 developer for 7 days.
Additional context (optional)
Add any other context about the feature request here.

Might be related: https://github.com/knative/serving-operator/issues/302


[NEW-FEATURE] POCO object should implement IPlain or IPOCO interface and respective swapping methods

/cib

Branch 145-_NEW-FEATURE_POCO_object_should_implement_IPlain_or_IPOCO_interface_and_respective_swapping_methods created!


Optional encoding for JsonAttribute

In case we want to log already valid JSON message, we need to be able to disable additional encoding JsonAttribute does.
Here we can decide to add additional object into the context that is already JSON formatted. To be able to write correct JSON it the log, we need to disable additional encoding that JsonAttribute does, so we just set encode="false"
<layout xsi:type="JsonLayout">
    <attribute name="Timestamp" layout="${longdate}"/>
    <attribute name="LogLevel" layout="${level}"/>
    <attribute name="MachineName" layout="${machinename}"/>
    <attribute name="Logger" layout="${logger}"/>
    <attribute name="Message" layout="${message}"/>
    <attribute name="Exception" layout="${exception:format=ToString}"/>
    <attribute name="Details" layout="${event-context:item=Details}" encode="false" />
</layout>

Thanks!
We have some line endings issue, so I will compare this on my PC this weekend.
There are some unit tests failing:

NLog.UnitTests.SourceCodeTests.VerifyFileHeader: the file must start with the header (just copy from another file)
NLog.UnitTests.SourceCodeTests.VerifyNamespacesAndClassNames: the class name should be the same as the file and the namespace and the folders should also by in-sync.

Could you fix that?

Ok. Will check it out. I think this is related to my VS extension (Trailing Whitespace Visualizer). I think it removes all trailing whitespace on save.

We fixed the EOL in master. Can you revert the changes in MessageQueueTargetTests?

Hi. Hope I did it :)

it's still there and I our fault ;)
I had the same issues local. I followed: https://help.github.com/articles/dealing-with-line-endings/#refreshing-a-repository-after-changing-line-endings

So

git rm --cached -r .
git reset --hard
git add .

Oh yes. I will do it now.

I did it, no changes to commit. I'm syncing master now..

Ow yes, you need to revert "MessageQueueTargetTests".

I learned a trick:
No white-space comparison:
https://github.com/NLog/NLog/pull/750/files?w=1

So it still only a white space issue. We really don't want to change this file in this PR. So please try a revert on that file.

I reverted the file and did the cache+reset..

Nice! Thanks! The lne ending issue has been resolved as you can see

Great! Sorry for the noobnes on my side. Still getting accustomed to git :)

No problem at all. This was advanced git stuff, I needed also some tutorials.

The code looks good, but I think we could improve it a bit more (see comments)

This PR is ready to merge for 4.1

We release this in 4.1. :)
Can you add the option (with example)  on the wiki?

Sure. Will do this weekend.

:+1:

Updated wiki page
https://github.com/NLog/NLog/wiki/JsonLayout

Looks good.  Thanks!