[CP Staging] Fix amount isn't saved when editting split scan request

Details

Fix amount isn't saved when editting split scan request
Fixed Issues

$ https://github.com/Expensify/App/issues/33587
PROPOSAL: https://github.com/Expensify/App/issues/33587#issuecomment-1869566325
Tests

Create a scan split request
Click on the preview to open split detail page
Click on amount and edit the amount
Click on save and verify that the amount is updated in split detail page

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Create a scan split request
Click on the preview to open split detail page
Click on amount and edit the amount
Click on save and verify that the amount is updated in split detail page

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/129500732/4b1143f0-13ce-4070-948e-ff1fe3e242b4

Android: mWeb Chrome
https://github.com/Expensify/App/assets/129500732/868f2ef3-e31a-459d-9d0c-3dfb79e505a1

iOS: Native
https://github.com/Expensify/App/assets/129500732/ce460fba-6a06-4816-99f9-caeb718c5b46

iOS: mWeb Safari
https://github.com/Expensify/App/assets/129500732/fcf26d66-f6ee-4712-8c2b-0df340cf913d

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/129500732/f32ffb46-de2a-4d0c-8e9e-acfc76766ddb

MacOS: Desktop
https://github.com/Expensify/App/assets/129500732/10b38291-71f4-4722-8c74-b3f813aea2d2

Not blocker but worth fixing (in separate issue) weird page briefly shows after refreshing split bill page

https://github.com/Expensify/App/assets/108292595/f3a66970-930f-49ee-a0e1-91b9ec42cd3e

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/108292595/5a554c99-e7e0-4577-9b4e-6e8f8dad03b3

Android: mWeb Chrome
https://github.com/Expensify/App/assets/108292595/53abd11d-5c71-423a-a414-9f3714c2e1f4

iOS: Native
https://github.com/Expensify/App/assets/108292595/1e2fb872-15d9-4c3a-8fed-f87c688e89a3

iOS: mWeb Safari
https://github.com/Expensify/App/assets/108292595/1dfed988-efc5-41fb-ba4c-7b5d8642bd05

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/108292595/12bb2767-ecba-4897-b5e0-4938016a5a66

MacOS: Desktop
https://github.com/Expensify/App/assets/108292595/418bdc8e-b3bf-4109-922a-5ab2de3c193d

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.4.17-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.17-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


DynaWin doesn't work with 24-hour time

This is a known bug and will (hopefully) be fixed soon.

This issue has (as far as I can tell) been fixed in DynaWin version 1.0.3


Bug: Address validation fails for South Korean City

What are you trying to achieve?
I'm trying to create a checkout with a shipping / billing address in South Korea. The address validation fails, even though I'm entering a valid address.
Steps to reproduce the problem
The easiest way to reproduce this is the demo instance at https://demo.saleor.io/.

Put any item in your cart and proceed to checkout.
Choose Shipping Address: South Korea
Enter a first and last name
Enter street address: "29, Gwonseon-ro", City: "Suwon", Postal Code: 16575

You will see an error, I'll copy the GraphQL response here:
{
  "data": {
    "checkoutShippingAddressUpdate": {
      "errors": [
        {
          "message": "This value is not valid for the address.",
          "field": "city",
          "code": "INVALID",
          "__typename": "CheckoutError"
        }
      ],
      "checkout": null,
      "__typename": "CheckoutShippingAddressUpdate"
    }
  },
  "extensions": {
    "cost": {
      "requestedQueryCost": 17,
      "maximumAvailable": 50000
    }
  }
}

Change the city to "Suwon-si"  and the error disappears.
What did you expect to happen?
I'd expect the official city name, Suwon to validate. Or city names to always validate. It would also be nice to be able to forego complicated address validation rules altogether (with an explicit setting).
Logs
No response
Environment
Saleor version: 3.15 (current demo environment)

Hello,
what did you gave in countryArea?

@pydeveloperashish Gyeonggi-do.


Vulnerabilities in Gradle 5.1.1

Hi Team,

I am using Gradle 5.1.1 version to compile my spring boot applications in a docker container.
I am using JFROG as an artifactory to store all the artifact . It runs a JFROG artifact scan which is causing the issue .
Gradle 5.1.1 comes with a common-collection-3.2.2.jar in lib folder and bcprov-jdk15on-1.60.jar in lib/plugin folder  . These JAR is causing the JFROG XRAY issue
These are vulnerabilities which is causing my build to fail
Expected Behavior
XRAY scan should pass
Current Behavior
XRAY scan is failing with the vulnerabilities attached
Context
Can you please let me know

Is there any we can upgrade these 2 jar in gradle-5.1.1.
I have tried directly replacing the jar with the upgraded version but then it is not able to compile my code.

Please let me know , as this issue is blocker.
Please let me know if you require any other info
XRAY-SCAN-LOGS.txt
for us

JARS in which vulnerabilities are fixed
bcprov-jdk15on-1.61.jar
commons-collections4-4.2.jar
Can you please let us know how can we update the pre existing jar in gradle package i.e.  gradle-5.1.1-all.zip
NOTE: I want the jar to be updated in gradle package inside lib folder .
Please let me know if you need any other info

Issue moved to gradle/gradle #8857 via ZenHub

The gradle/gradle-native board is for native (C++, Swift, etc) only issues. Please use gradle/gradle issue tracker for all other issues instead.


Merge main to live, 7/22 at 10:30 am

Docs Build status updates of commit 664b366:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/New-AutoSensitivityLabelPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/New-DlpCompliancePolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-AutoSensitivityLabelPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-DlpCompliancePolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

skype/skype-ps/skype/New-CsTrunkConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTrunkConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Edit post notification content

Is there a way I can actually add subtitle, header on this code?
// Calling postNotification
let data = arr // some array as payload
let contents = {
	'en': 'You got notification from user'
}
OneSignal.postNotification(contents, data, playerId);

I tried going through the docs but I can't get it working.
Thanks

@joshuaalpuerto hi, did you figure this out?
could you share your array or object, i don't know about the completely look it should be..thanks!

@neo125874, actually the same as the documentation.
OneSignal.postNotification({
   'en': 'Someone is calling.'
}, {}, user.push_id)

The problem is when im adding subtitle or header notification won't send.

@joshuaalpuerto thanks for your info, i found that the 'en' must be in, even when other language code was setting.
one more question, would badge or title(not subtitle) works?

unfortunately I haven't tried using those properties.

@joshuaalpuerto so the alert info window, you custom that? or how did you solve the title & content would be the same?

@neo125874 , customization didn't work. Im stuck to the default settings
OneSignal.postNotification({
   'en': 'Someone is calling.'
}, {}, user.push_id)


What about interactively turning on and off any line series?

I mean to show a line series legend somewhere at the left top corner of a plot and to have an abillity to turning visibility on and off to some of them. What about such feature?

I'd say it's duplicate of https://github.com/tradingview/lightweight-charts/issues/42#issuecomment-502017406, but we need to investigate it one more time.


Delete test/duplicate/mistake orders

There should be a way to delete orders that were placed during testing or by mistake. Otherwise the CSV file will need to be manually changed every time it is downloaded, which is a pain for organizers, especially those not particularly well versed in spreadsheet management.

I think this problem may be covered by #512 already.

Feel free to reopen if not.


ranobelib does not see some chapters

Source information
ranobehub
Steps to reproduce
ranobelib does not see some chapters
For example, let's take this - https://ranobelib.me/ru/book/78570--goshujin-sama-to-yuku-isekai-survival-web-novel?bid=15700&section=chapters
When we select the translator "Затексурье" in the program, we do not see all the chapters, but if we go through the Web and select the same translator, there are more chapters. In general, everything is visible in the screenshot.

Expected behavior
So that all chapters are visible
Actual behavior
Some chapters are simply lost, although they should be there.
LNReader version
Github Action 2.0.0 (26/11/24 04:41 PM UTC) Commit: 5db79a09
Android version
Android 10
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 1.1.19.
[X] I have updated all installed extensions.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

same problem https://github.com/LNReader/lnreader-plugins/issues/1143

After updating the plugin to 2.1.1, the novel does not open (https://ranobelib.me/ru/book/78570--goshujin-sama-to-yuku-isekai-survival-web-novel)

Other novels are opening, of course I haven’t checked everything, but there is a problem with this one, I waited a long time, but there was no result.


Some relations are not showing in AG viewer

Describe the bug
Some relations are not showing in AG viewer when they are clearly in the database You can see the edge in the table). When you play with the weight thickness of the edge then you can see sometimes the edge appearing for a brief moment.
Also when you click on the object it looks like the object is not connected via the edge to the other object. So it is not only a viewing problem it seems?
To Reproduce
it happens randomly so you cannot reproduce
Expected behavior
the viewer needs to to display all the relations in the database
Screenshots

now editing the weight:
now the missing edge appears and the other one dissappears?

another example: Edge missing in Graph View between AP1 and DP12:

In the table this EDGE (Ap1 - DP12) is existing? Wy doesn't it show and act if it is connected in the Graph view? :

MPE:
Desktop (please complete the following information):

OS: Windows
Browser : Chrome and Edge
Version 107.0.5304.107 (Official Build) (64-bit)

Additional context
Add any other context about the problem here.

This is likely because the "ID" field is not properly initialized. All node IDs should be integers.
https://age.apache.org/age-manual/master/intro/agload.html#explanation-about-the-csv-format

Hi marodins,
Thank you for your reply!
But the id you are talking about is the database id. The ID shown in my examples  are Node attributes. I changed the attribute ID to node_id to see if this would solve the problem but it doesn't :(
See printscreens: GRAPH

Table:

Yes, the nodes will need an attribute named 'id'. The attribute's value will need to be an integer. If data is initialized using a csv file and there is no 'id' field then an extra argument needs to be passed to the load_labels_from_file function (linked below) when initializing the graph.
This may be the cause of this bug. Please let me know if that works.
here's an example file of data:
https://github.com/apache/age/blob/master/regress/age_load/data/countries.csv
https://age.apache.org/age-manual/master/intro/agload.html#explanation-about-the-csv-format

But the id column is there see printscreen. They are big integers.
I am not using a csv to create the Graph but python code where I read an excel. The Id column is always automatically created in the Postgres database. You can also see that in the relation what id's the edge connects. (start_id - end_id). look at the red arrows.

Made another printscreen with the id's yellow: these are the ID's you mean and this is correct in the database. Also the EDGE connecting the id's is in the database but the Graph view doesn't show it. If you select the EDGE type IS_USING and play with the thickness you see the EDGE popping up in the GRAPH. So in my opionion it is cleary an AG viewer code problem?

I'm also struggling with the same issue.
Some relations are not properly viewed in the AG viewer. Is there any expert who can suggest how to solve it?

@bruinend Ok, thank you for clearing that up.
I'll need some more information to be able to resolve the bug. Since this doesn't occur all the time and I have not personally ran into this issue this may be some edge case. This may be a bug from the viewer app or from one of the libraries used by the viewer app. May I know how you're initializing this data using python? More specifically what query is created to generate nodes and edges.
Also, @TahminaBegum, are you programmatically generating your data as well?
Appreciate any additional information in order to be able to resolve this issue.

Hi
This is how i build the connection with python:
import age
import pandas as pd
from age.gen.AgtypeParser import *
GRAPH_NAME = "metadata_ndh_graph_TEST4"
DSN = "host=age port=5432 dbname=metadata_ndh user=root password=root"
ag = age.connect(graph=GRAPH_NAME, dsn=DSN)
ag.setGraph(GRAPH_NAME)
Then i create the objects (i read data from an excel sheet and build the code).
After the objects are created i create the links which are also defined in the excel sheet using the node_id attributes.
The id attribute of the nodes are created in the database when creating the Node with the python script.
This is python code to create node:
for sheet in worksheets:
if sheet != "link":
Metadata = pd.read_excel('KgMetaDataTemplatesv0.2_Joined.xlsx', sheet_name=sheet)
string = "CREATE (n:" + sheet + " {name: %s , node_id:%s , description: %s, status:%s}) RETURN n"
for i, j in Metadata.iterrows():
if j[0] in existing_node_ids: continue
elif j[1] in existing_node_names:
print('Existing name found: ' + str(j[1]))
continue
else:
cursor = ag.execCypher(string, params=(j[1],j[0],j[2],j[3]))
if showcreation == 1:
for row in cursor:
print("CREATED: ", row[0])
else: continue
ag.commit()
This is python code to create link (Edge):
for i, j in Metadata_links.iterrows():
if j[7] != "na":
label = j[6] + ' , ' + j[7]
else:
label = j[6]
if str(j[2]) == "IS_CONNECTED_TO":
weight = 10
elif str(j[2]) == "IS_EXECUTED_ON":
weight = 5
elif str(j[2]) == "IS_USING":
weight = 3
else: weight = 1
if j[8] != "na":
sequence = str(j[8])
string = "MATCH (a: " + str(j[1]) +  "{node_id: '" + str(j[0]) + "'}), (b: " + str(j[4]) + " {node_id: '" + str(j[3]) + "'}) CREATE (a)-[r:" + str(j[2]) + " {weight: " + str(weight) + ", tag: '" + str(label) + "', sequence: '" + sequence + "'}]->(b)"
else:
string = "MATCH (a: " + str(j[1]) +  "{node_id: '" + str(j[0]) + "'}), (b: " + str(j[4]) + " {node_id: '" + str(j[3]) + "'}) CREATE (a)-[r:" + str(j[2]) + " {weight: " + str(weight) + ", tag: '" + str(label) + "'}]->(b)"
#print(string)
cursor = ag.execCypher(string)
#print (cursor)
for row in cursor:
print("CREATED: ", row[0])
ag.commit()

@marodins another thing I noticed what might be strange: the count of the edges is almost double then the edges i defined in the excelsheet?

excel:

@bruinend
The queries in your code look correct.
The image being used here for the viewer application hasn't been updated in over a year. I checked it out here https://hub.docker.com/r/bitnine/agviewer. This is a very old version.
The first steps would be to clone the current repository, checkout main branch, and run the viewer application as described in the README. This is the latest code for the viewer application. You can run the backend (DB and AGE) separately using the docker image here https://github.com/apache/age. Please report back if this same bug exists with the viewer application.

@marodins yes that is exactly what happens! also I already mentioned this behaviour in this topic...

@bruinend thank you, yes there are two separate features that allow edge thickness adjustments. Just wanted to ensure that the footer feature gives you similar results. I found and refactored some code which may have caused this issue. Here's the PR https://github.com/apache/age-viewer/pull/89 . You can try to check and see if this works for you prior to this PR being merged.
To checkout the PR:
-- clone the repository in a new directory --
-- fetch the PR --

git fetch origin pull/89/head
git checkout -b edge_pr FETCH_HEAD

-- run application as usual --
If you have time to try this and do try this please report back on the results. If this doesn't solve the issue I'll continue by creating some tests to try to reproduce this bug. Thank you!


libadwaita: 1.3.1 -> 1.3.2

Description of changes
Diff: https://gitlab.gnome.org/GNOME/libadwaita/-/compare/1.3.1...1.3.2
Changelog: https://gitlab.gnome.org/GNOME/libadwaita/-/blob/1.3.2/NEWS

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg test gnome


Add optional truncate and normalize parameters to InferenceClient.feature_extraction()

Related Issues:
fixes #1939
Proposed Changes:
Adds two new optional boolean parameters parameters to InferenceClient.feature_extraction():

truncate: If set to True, truncates inputs longer than 512 tokens. Defaults to True.
normalize: If set to true, returned vectors will have length 1. Defaults to True.

This enables using these parameters with endpoints set up using text-embeddings-inference.

Thanks for opening a PR @awinml! The contribution is appreciated but I'd prefer to delay it for now as explained in
https://github.com/huggingface/huggingface_hub/issues/1939#issuecomment-1873950153.

Closing in favour of #2270.


Provide better support for containers - startup order is not resilient, config default path cannot be specified

Prior to version 2, it was possible for the official telegraf container to be started independently of the influxdb container, as it did not rely on influxd to provide the configuration. In particular, the telegraf container could be started some time before the influxdb container and the system would remain stable and a successful connection be made, as recommended by the docker-compose startup-order docs:

The problem of waiting for a database (for example) to be ready is really just a subset of a much larger problem of distributed systems. In production, your database could become unavailable or move hosts at any time. Your application needs to be resilient to these types of failures.

WIth 2.0.0-beta, it is now necessary for the telegraf service to wait long enough for the influxdb container to start and make the configuration file available over HTTP. If the telegraf container is started too early, it will fail to obtain the configuration and fail to start. There is no provision in the official telegraf container to wait or retry the connection in the event that the configuration is not available.
The effect of this is that managing the telegraf/influxdb stack with tools like docker-compose is now non-trivial, if official docker images are used. Instead, a user needs to construct their own containers with the appropriate wait-for/retry scripts wrapping telegraf.
I suggest a modification to the official telegraf container to wait for configuration to be available, by attempting to download the configuration URL and then backing off for a short period of time if it is not available. Perhaps after some number of attempts, the container might exit with a permanent error, however for true resilience it should probably continue to poll for the configuration file indefinitely.
The other non-container-friendly aspect I have discovered is how influx setup saves the initial configuration to /root/.influxdbv2/configs, which is typically not retained in the official influxdb container. I appreciate that this can be worked around with an appropriate volume export in docker-compose.yml. To make this more container-friendly, I suggest adding a command-line option to influx setup that allows the user to specify the destination path for this file, so that it can be more easily integrated with existing container volume mounts.

@DavidAntliff thank you for the issue. We have received similar feedback about the latest beta not being very docker friendly and we are planning to improve it. See this issue for a startup script to help: https://github.com/influxdata/influxdb/issues/16649
As for the telegraf issue, having retry logic for fetching the config makes sense to me, but it would be better to open that issue against the telegraf repo to see what that community thinks.
I'm not sure what your architecture looks like, but you can also host the telegraf config with any http service, or manage it locally. We are working on improving the connection between the agent and influxdb, but those options might work for you in the short.

broke the last request out into: https://github.com/influxdata/influxdb/issues/17979

@russorat thank you for responding. At the moment I'm working with v1.8, after forking another person's 1.7 fork, which is a fork of the official TICK-docker repo: https://github.com/DavidAntliff/TICK-docker/tree/master/1.8 - aside, perhaps the official repo could look at incorporating some of the numerous forks for versions newer than v1.3?
However I will revisit v2.x in the near future and pick this up again then.


Add support for special property types like "file path".

Nice to have. Don't really need this for applications to work off Black Iris. The application itself can check for a valid path.


Fix typo in Array Type Literals section of spec

Extra end bracket in 1st example code block under Array Type Literals subsection of the spec,
Changed (() => string))[] to (() => string)[].

thanks!

Why is the entire file marked as changed in the diff?


Brian/precommit address removal

Pull Request Test Coverage Report for Build 4448

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 4443:
0.0%

Covered Lines:
876

Relevant Lines:
876

💛  - Coveralls


Frontend: only serve static files below frontend dir

This is currently fixed by checking for .. but I think we can find a cleaner solution.

os.path.commonpath() seems like it could make a more robust solution (in the case that quetz should ever serve a file with two consecutive periods or expect a relative path but under the frontend_dir). Just check if the common path is equal to the frontend_dir, and make a decision based on that. https://docs.python.org/3/library/os.path.html#os.path.commonpath

Yes, indeed! That looks like a good function to use.

Thanks @stevenryoung for tackling this!


discord-development: init at {0.0.215,0.0.877}

Description of changes
Updates  #179212 to latest version and resolve merge conflicts.
Closes  #179212

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2098

Please do the backport


WIP DO NOT MERGE 0.17.0 R release prep

Having some trouble/slowness with r-hub for testing so made this PR to use crossbow.

@github-actions crossbow submit test-r-linux-as-cran

@github-actions crossbow submit test-r-linux-as-cran

@github-actions crossbow submit test-r-linux-as-cran

@github-actions crossbow submit -g r

@github-actions crossbow submit test-conda-r-3.6 test-ubuntu-18.04-r-3.6


Added YouTube Room

Why was this added and merged? I thought we only add Camperbot to the official chatrooms? Also, you shouldn't be merging your own commits.

@ltegman Yeh, sorry my fault! @raisedadead has told me all about that! We are moving from twitch to youtube. This is an official room, maybe replacing the livecoding room, we're not sure yet.

Cool, cool 👍

@ltegman I'll make sure it doesn't happen again!

@theflametrooper Please revert this PR. Per @QuincyLarson 's response in the core team room, this is not an official chat room.


EID-841: Fix stub IDP PaaS deploy

This contains fixes for deploying stub IDP to PaaS after making it a subproject of this repository.

There needs to be more jenkins.sh ❤


Added a new note under Options for .NET Core 2.x

Summary
Web projects are not packable by default from .NET core 2.x. So, I added this under the options section as a note and also provided the code snippet to override this default behavior

@Rick-Anderson @scottaddie can you guys help review this change?
/cc @KathleenDollard

@amaldevv thank you for addressing additional feedback; @mairaw is this PR ready to ship?

Sorry I missed this was waiting on me. Merging now. Thanks @amaldevv.


Fix conversion path collection

Hi all,
I fixed a null pointer exception in case a conversion was not found, and the loop condition.
The unit test illustrates that it no longer throws an exception when the conversion is not possible.
Kind regards -- Joost

Thanks so much @JoostSchipperheijn for the PR, we will have a look at the PR and create a new version soon.


Mechanism to use / extend ClassResolver

Hi, let me explain original issue first:

we use cglib to create proxy classes and we mark generated classes with a custom interface and provide a custom serializer
when Kryo 5 serializes immutable collection (non-generic) then elements are serialized by this snippet in CollectionSerializer:

} else {
for (Object element : collection)
	kryo.writeClassAndObject(output, element);
}

kryo.writeClassAndObject uses writeClass(output, object.getClass()); and writes generated class name:

	public Registration writeClass (Output output, Class type) {
		if (output == null) throw new IllegalArgumentException("output cannot be null.");
		try {
			return classResolver.writeClass(output, type);
		} finally {
			if (depth == 0 && autoReset) reset();
		}
	}

ClassResolver writes a class name:

	public Registration writeClass (Output output, Class type) {
		if (type == null) {
			if (TRACE || (DEBUG && kryo.getDepth() == 1)) log("Write", null, output.position());
			output.writeByte(Kryo.NULL);
			return null;
		}
		Registration registration = kryo.getRegistration(type);
		if (registration.getId() == NAME)
			writeName(output, type, registration);

where writeName method uses:

if (registration.isTypeNameAscii())
	output.writeAscii(type.getName());
else
	output.writeString(type.getName());

in other words Kryo writes a name of the class that is generated (something like $Configuration$$EnhancerByCGLIB$$d0595dcf), later it finds registered serializer and serializes cglibproxy object via registered serializer.
The problem happens when the other side attempts deserialization: there is no class named like $Configuration$$EnhancerByCGLIB$$d0595dcf as it was generated in a different JVM.
One way to go around this problem could be to override ClassResolver (since all of classresolvers extend DefaultClassResolver) and provide custom implementation of writeName .
Providing custom CollectionSerializer does not look like a viable option (see https://github.com/EsotericSoftware/kryo/issues/943 for an attempt to do something similar).
Now, Kryo allows us to pass custom ClassResolver, but KryoSerializer is quite opinionated (because it provides custom classresolvers), so I had to resort to reflection:
// inside KryoInit extends DefaultKryoInitializer {

    val classResolver = kryo.getClassResolver
    classResolver match {
      case resolver: DefaultClassResolver =>
         // I really did not want to use reflection, but alternative is to re-implement/copy KryoSerializer (from altoo) in order to use custom classresolver
         replaceClassResolver(kryo, resolver)
      case _ =>
        throw new IllegalStateException(s"Unable to replace unknown classResolver type ${classResolver.getClass.getName}")
    }
  }

  private def replaceClassResolver(kryo: ScalaKryo, original: DefaultClassResolver): Unit = {
    // Kryo might use CollectionSerializer under the hood to serialize "syntheticProperties" collection.
    // If this happens it will write name of the class and then serialize it using registered serializer
    // If collection element is a cglib proxy it means that the class was generated only on the node where serialization happens
    // This is a problem because other nodes in the cluster do not know about this custom class - those nodes do have serializer
    // and can deserialize a reference into their own proxy.
    // That's why we want to tell Kryo that it should use "ResolvableLazyConfigurationItem" as a class name instead of the one created by cglib.
    // Use of KryoSerializer and Akka make this difficult to test on a single node and with cluster you have to debug through Kryo codebase
    // to see which serializers and class names are being picked up.
    val kryoClazz = classOf[Kryo]
    val classResolverField = kryoClazz.getDeclaredField("classResolver")
    classResolverField.setAccessible(true)
    val xlrClassResolver = new XlrClassResolver(original)
    classResolverField.set(kryo, xlrClassResolver)
    xlrClassResolver.setKryo(kryo)
  }

and then again in custom classresolver:
class XlrClassResolver(delegate: DefaultClassResolver) extends ClassResolver with Logging {
  private val resolvableLazyConfigurationItemClazz = classOf[ResolvableLazyConfigurationItem]
  private val m = classOf[DefaultClassResolver].getDeclaredMethod("writeName", classOf[Output], classOf[Class[_]], classOf[Registration])
  m.setAccessible(true)

  override def setKryo(kryo: Kryo): Unit = {
    delegate.setKryo(kryo)
  }

  def doWriteName(output: Output, typ: Class[_], registration: Registration): Unit = {
    m.invoke(delegate, output, typ, registration)
  }

  override def register(registration: Registration): Registration = delegate.register(registration)

  override def unregister(classID: Int): Registration = delegate.unregister(classID)

  override def registerImplicit(typ: Class[_]): Registration = delegate.registerImplicit(typ)

  override def getRegistration(typ: Class[_]): Registration = delegate.getRegistration(typ)

  override def getRegistration(classID: Int): Registration = delegate.getRegistration(classID)

  override def writeClass(output: Output, typ: Class[_]): Registration = {
    if (null != typ && resolvableLazyConfigurationItemClazz.isAssignableFrom(typ)) {
      val registration = delegate.getRegistration(resolvableLazyConfigurationItemClazz)
      doWriteName(output, resolvableLazyConfigurationItemClazz, registration)
      registration
    } else {
      delegate.writeClass(output, typ)
    }
  }

  override def readClass(input: Input): Registration = delegate.readClass(input)

  override def reset(): Unit = delegate.reset()
}

I would like to avoid reflection and directly extend classresolvers used by KryoSerializer and pass custom class resolver (which should extend "expected" classresolver type for particular akka-kryo configuration) via config to akka-kryo-serialization.
Something like:
    akka-kryo-serialization {
        type = "graph"
        id-strategy = "default"
        buffer-size = 4096
        max-buffer-size = -1
        use-manifests = true
        use-unsafe = false
        post-serialization-transformations = "lz4"
        kryo-initializer = "custom.KryoInit"
        implicit-registration-logging = true
        kryo-trace = false
        class-resolver="custom.MyClassResolver" // new option...
    }

and then io.altoo.akka.serialization.kryo.KryoSerializer#getKryo should be a bit more complicated as it would have to check if there is a custom class-resolver and if it is extending expected class resolver.
Alternatively, just make getKryo protected so we can extend KryoSerializer and provide our own implementation of getKryo.

Sorry, this kind of went under the radar.
I guess the option to provide a class-resolver via config would make sense for such scenarios, but the class resolver chosen depends on other settings:
    val classResolver =
      if (settings.idStrategy == "incremental") new KryoClassResolver(settings.implicitRegistrationLogging)
      else if (settings.resolveSubclasses) new SubclassResolver()
      else new DefaultClassResolver()


Admin inaccessible

Bug Report
Problematic behavior
Asking for a sub and a password instead of the expected email and password (as mentioned in the Readme):

Expected behavior/code
Revert and fix this regression.

Actually, when searching through commits' history, I've found these changes by @sampaccoud https://github.com/numerique-gouv/people/commit/2ec292bb9105486cd7183fab1aa7ba7166ddcd2e.
Passing admin as a sub allowed me to logged-in. We should definitely change input's name by username and keep the README up-to-date

Although very username-y, "admin" is actually the sub of the admin user.
I'll update the README.

Hello
Can this ticket be moved to En Prod? (no testing for me)


the compare with selected option failed if options is an object

getSelectedValue(option) == ui.value
the above compare will never return true if ui.value is the object which is same with the option (but obviously the object compare doesn't return true for some reason)

@ulion thanks for reporting.
can you provide a plunkr or codepen to show the issue?
Everything seems fine in the demo:
http://codepen.io/bianchimro/pen/epYYQO?editors=101

that happened when you saved the select option, but reload the page again,
e.g. load from saved data, you have a saved object, it has same content as
the one in the option list, but it's different object.
that means, current implement can not judge they are the same object, or
should be treat as same. maybe, we just need to support user can setup a
function, which take 2 option values then compare them tell whether it's
same.
2015-11-05 18:40 GMT+08:00 Mauro Bianchi<EMAIL_ADDRESS>
@ulion https://github.com/ulion thanks for reporting.
can you provide a plunkr or codepen to show the issue?
Everything seems fine in the demo:
http://codepen.io/bianchimro/pen/epYYQO?editors=101
—
Reply to this email directly or view it on GitHub
https://github.com/inmagik/ionic-modal-select/issues/8#issuecomment-154025740
.

--
Ulion

@ulion can you provide a codepen where data is saved and loaded from localstorage so we can use it to test against this issue?
thanks

http://codepen.io/anon/pen/EPZmyq
2016-01-02 21:45 GMT+08:00 Mauro Bianchi<EMAIL_ADDRESS>
@ulion https://github.com/ulion can you provide a codepen where data is
saved and loaded from localstorage so we can use it to test against this
issue?
thanks
—
Reply to this email directly or view it on GitHub
https://github.com/inmagik/ionic-modal-select/issues/8#issuecomment-168394130
.

--
Ulion

@ulion thanks for the codepen
should be fixed now.


Line 2: "not_is_Norden" is not a known command

Assignment: Way Home - Heimweg
There is an Error in the english version when using "not_is_north" block
It seems the block uses the wrong function --> not_is_Norden
it actually applies to all directions: north, east, south and west

Thank you for the report. I will look into it, I have an idea what the reason could be here.

fixed in 85661ed2d716c4a0b90aca0b490455845ed509a0

I can't not reproduce right now, can you refresh / hard refresh and send me some more information?

It is not exactly the same problem like previously
Here a simple test:

Thank you for the detailed report, I can now understand the problem

works flawless now, thank you very much


All "HTTP method not found for path" issues

The following table represents all the HTTP method not found for path issues:

Column1
Service
Endpoint
Verb
URL
$ref

1
User sites
followed sites
POST
/v1.0/users/{user-id}/followedSites/remove
n

2
User activities
Activities
PUT
/v1.0/me/activities/12345
n

3
Teams
Schedule time   off
PUT
/v1.0/teams/{teamId}/schedule/timesOff/{timeOffId}
n

4
Groups
remove rejected sender
DELETE
/v1.0/groups/{id}/rejectedSenders/$ref?$id=https://graph.microsoft.com/v1.0/users/{user-id}
y

5
Identity   governance
custom workflow   extensions
PUT
/v1.0/identityGovernance/entitlementManagement/catalogs/32efb28c-9a7a-446c-986b-ca6528c6669d/customWorkflowExtensions/78ffaec5-ae8e-4902-a434-5ffc5d3d3cd0
n

6
identity
identity providers
POST
/v1.0/identity/b2xUserFlows/B2X_1_Partner/identityProviders/$ref
y

7
directory
getUserOwnedObjects
POST
/v1.0/directory/deletedItems/getUserOwnedObjects
n

8
Groups
accepted senders
DELETE
/v1.0/groups/{id}/acceptedSenders/$ref?$id=https://graph.microsoft.com/v1.0/users/{user-id}
y

9
Calendar
calendar
DELETE
/v1.0/me/calendar
n

10
Identity governance
decisions for user
POST
/v1.0/identityGovernance/accessReviews/definitions/57457d7c-af59-470c-ae71-aa72c657fe0f/instances/ad0dd148-5d16-4cfd-86e9-ab502f819aaf/decisions/4d79fbf6-36e6-430b-ba0a-2a727a480303
n

11
Identity   governance
decisions
POST
/v1.0/identityGovernance/accessReviews/definitions/57457d7c-af59-470c-ae71-aa72c657fe0f/instances/ad0dd148-5d16-4cfd-86e9-ab502f819aaf/decisions/62fd1c5b-04b8-4703-9fd7-dce6232c3775
n

12
Teams
shifts
PUT
/v1.0/teams/{teamId}/schedule/shifts/{shiftId}
n

13
Identity   governance
custom workflow   extensions
PUT
/v1.0/identityGovernance/entitlementManagement/catalogs/32efb28c-9a7a-446c-986b-ca6528c6669d/customWorkflowExtensions/98ffaec5-ae8e-4902-a434-5ffc5d3d3cd0
n

14
applications
templates
PUT
/v1.0/applications/{id}/synchronization/templates/{templateId}
n

15
User activities
history items
PUT
/v1.0/me/activities/{activity-id}/historyItems/{item-id}
n

16
Excel
range
PATCH
/v1.0/me/drive/items/{id}/workbook/worksheets/{sheet-id}/range(address='A1:B2')
n

17
service   principals
app management   policies
POST
/v1.0/servicePrincipals/{id}/appManagementPolicies/$ref
y

18
User activities
history items
PUT
/v1.0/me/activities/{activity-id}/historyItems/{item-id}
n

19
security
custodian   sources
POST
/v1.0/security/cases/ediscoveryCases/b0073e4e-4184-41c6-9eb7-8c8cc3e2288b/searches/c61a5860-d634-4d14-aea7-d82b6f4eb7af/custodianSources/$ref
y

20
teams
scheduling groups
PUT
/v1.0/teams/{teamId}/schedule/schedulingGroups/{schedulingGroupId}
n

21
service   principals
jobs
PUT
/v1.0/servicePrincipals/{servicePrincipalId}/synchronization/jobs/{jobId}/schema
n

22
User sites
followed sites
POST
/v1.0/users/{user-id}/followedSites/add
n

23
one note
section Groups
POST
/v1.0/me/onenote/sectionGroups/{id}/sectionGroups
n

24
User activities
Activities
PUT
/v1.0/me/activities/3F12345
n

25
places
places
GET
/v1.0/places/979e9793-3e91-40eb-b18c-0ea937893956
n

26
policies
indentity Synchronization
PATCH
/v1.0/policies/crossTenantAccessPolicy/partners/90e29127-71ad-49c7-9ce8-db3f41ea06f1/identitySynchronization
n

27
security
non custodial   sources
POST
/v1.0/security/cases/ediscoveryCases/b0073e4e-4184-41c6-9eb7-8c8cc3e2288b/searches/c61a5860-d634-4d14-aea7-d82b6f4eb7af/noncustodialSources/$ref
y

28
policies
admin consent request policy
PUT
/v1.0/policies/adminConsentRequestPolicy
n

29
one note
content
PATCH
/v1.0/me/onenote/pages/{id}/content
n

30
user
photo
DELETE
/v1.0/me/photo/$value
n

31
places
places
GET
<EMAIL_ADDRESS>n

32
intune
managed device overview
PATCH
/v1.0/deviceManagement/managedDeviceOverview
n

33
intune
software update   status summary
PATCH
/v1.0/deviceManagement/softwareUpdateStatusSummary
n

34
teams
open shifts
PUT
/v1.0/teams/3d88b7a2-f988-4f4b-bb34-d66df66af126/schedule/openShifts/OPNSHFT_577b75d2-a927-48c0-a5d1-dc984894e7b8
n

35
service   principals
remote desktop   security config
POST
/v1.0/servicePrincipals/00af5dfb-85da-4b41-a677-0c6b86dd34f8/remoteDesktopSecurityConfiguration
n

36
service principals
jobs
PUT
/v1.0/servicePrincipals/{id}/synchronization/jobs/{jobId}/schema
n

37
teams
time off   reasons
PUT
/v1.0/teams/{teamId}/schedule/timeOffReasons/{timeOffReasonId}
n

@irvinesunday I put together this table with all the issues in this category. Please let me know if you want access to the Excel file on the side.

CC: @MaggieKimani1 for visibility.

@petrhollayms @adhiambovivian


fix: add AuthRequiredPanel to AuthConfirmDialog

the AuthConfirmDialog UI is diffrent than AuthRequiredPanel(for example it doen't have an input for manuel token), not sure if it was on purpose
old UI:

the current UI looks like:

As a dialog, we might still need the Cancel button. We could expose a slot for that.

@antfu sure!


bump dfe-analytics to 1.2.0

Context
Trainee events are causing an error in dfe-analytics because of the handling of progress, which fails to get processed by BigQuery. These errors seem to be invisible on production, or at least they were in qa and I haven't spotted them in production yet. The only way we knew about them is that trainee entity events, and only trainee ones, weren't being streamed.
Changes proposed in this pull request
This new version of the dfe-analytics gem includes a fix for sending the "progress" attribute on trainees which is currently causing no trainees to be sent to BQ.
Guidance to review
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

Didn't realise dependabot would catch version bumps on this gem. Noice!


klifs_metadata as global instead of function input parameter?

How to load klifs_metadata in local module more elegantly (can this be set as global variable)?

@jaimergp pointers from PR #1:

Closing this issue. Code was moved to https://github.com/volkamerlab/opencadd. This issue was addressed here: https://github.com/volkamerlab/opencadd/pull/39


Validation "matches" rule is not getting the label from the corresponding field

$rules = [
	'new_password'         => [
		'label' => 'New Password',
		'rules' => [
			'required',
			'min_length[5]',
		],
	],
	'confirm_new_password' => [
		'label' => 'Confirm New Password',
		'rules' => [
			'required',
			'matches[new_password]',
		],
	],
];

The Confirm New Password field does not match the new_password field.

Updating this line
https://github.com/bcit-ci/CodeIgniter4/blob/d18838cf110ecf59cdadcd48b526da28ce701b54/system/Validation/Validation.php#L678
to
$message = str_replace('{param}', $this->rules[$param]['label'] ?? $param, $message);

could solves. Not sure about possible conflicts.

Or an special check only to rules that corresponds to other fields: differs, matches, required_with, required_without.

Oh, dang. Yeah, that seems to be leftover from before we could support array syntax. I was getting ready to say that it's working fine in my Auth library that I'm working on, but that's using the string syntax:
'password'     => 'required|strong_password',
'pass_confirm' => 'required|matches[password]',

And this is where we run into issues for being too flexible. :)
One you've got might work, but would definitely need some tests in place trying it both ways.


chore: bump GWAPI to 1.0, fix target test.conformance-experimental

What this PR does / why we need it:
Bump gateway-api to the release 1.0.0 and all related stuff

gateway-api bump
fix Makefile targets test.conformance and test.conformance-experimental (for now maintain both, because experimental doesn't become the default one with the release of GWAPI 1.0.0)
reuse hack for passing test GatewayClassObservedGenerationBump for experimental-conformance
adjust versions in README.md (for now link to the conformance report is broken until submitting it to GWAPI repo)
reflect in .gitignore changing the generated report name (introduced in https://github.com/Kong/kubernetes-ingress-controller/pull/4726)

Which issue this PR fixes:
Closes https://github.com/Kong/kubernetes-ingress-controller/issues/4998

Special notes for your reviewer:
In issue https://github.com/Kong/kubernetes-ingress-controller/issues/4998 acceptance criteria mention submitting the report, but generating and submitting the report is a part of the release process, it is documented in. It should be done on the tag v3.0.0 to use the same code as for release artifacts. Thus here I only fixed tests, and pipeline and tried whether it works see the CI run

The CI run for report has failed: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6710477257

Yup, forgot needs in the pipeline, it's replaced with https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6710594332 @czeslavo


[python-package] Where has the "fobj" parameter gone in lightgbm.cv() in v4.0.0?

In prior version (v3.3.5) lightgbm cv function accepts custom objective function via the fobj parameter as can be found here:
https://lightgbm.readthedocs.io/en/v3.3.5/pythonapi/lightgbm.cv.html
This parameter has disappeared in v4.0.0 and you would now get an error:
TypeError: cv() got an unexpected keyword argument 'fobj'

Thanks for using LightGBM.
fobj was removed from the interface of train() and cv() as of v4.0.0, in #5052.
Please instead pass a custom objective function through the params dictionary, like this:
import lightgbm as lgb
import numpy as np
from sklearn.datasets import make_regression

X, y = make_regression(n_samples=10_000)
dtrain = lgb.Dataset(X, label=y)

def mse_obj(y_pred, dtrain):
    y_true = dtrain.get_label()
    grad = (y_pred - y_true)
    hess = np.ones(len(grad))
    return grad, hess

results_dict = lgb.cv(
    train_set=dtrain,
    params={
        "objective": mse_obj,
    },
    metrics=["rmse", "mae"],
    num_boost_round=4,
    nfold=3,
    stratified=False,
)
print(results_dict)

{
  "valid rmse-mean": [
<PHONE_NUMBER>6398734,
<PHONE_NUMBER>252454,
<PHONE_NUMBER>0976708,
<PHONE_NUMBER>0933657
  ],
  "valid rmse-stdv": [
    3.1024741893923964,
    2.8084421012176723,
    2.697431048972295,
    2.8063495452805944
  ],
  "valid l1-mean": [
<PHONE_NUMBER>7039018,
<PHONE_NUMBER>0132123,
<PHONE_NUMBER>8699913,
<PHONE_NUMBER>0303708
  ],
  "valid l1-stdv": [
    2.5603029246751587,
    2.351527407415942,
    2.317894957868989,
    2.376012741246122
  ]
}

Note that it's important to explicitly pass metrics when using a custom objective, since LightGBM won't be able to guess appropriate evaluation metrics when the objective function is arbitrary Python code.
In case you haven't seen, all of LightGBM's release notes are available at https://github.com/microsoft/LightGBM/releases. Searching for "fobj" at https://github.com/microsoft/LightGBM/releases/tag/v4.0.0 would have pointed you to #5052.

Thank you very much for your answer and the example @jameslamb! This is very clear.


Bump dependency versions and Go version

Description
This PR bumps dependency versions, Go version and updates the project according the latest version of Kubebuilder.
The CVE-2024-24786 is also fixed in this PR.
Linked Issues
UD-1367
How has this been tested?

make test
Installing Zora in a cluster and configuring scans.

Checklist

[x] I have labeled this PR with the relevant Type labels
[x] I have documented my code (if applicable)
[ ] My changes are covered by tests

This PR contains a lot of changes that are not necessarily related, including one (possibly two) feature updates.  We should really have individual PRs for these.


Tom/removed axiom vulnerability in example

Goal
Bumped the Axiom dependency in the Laravel 5.6 example project to remove warning.

hey @tomlongridge
There is a typo in title, it should be axios
Current title may confuse users like me.


Potential serious bug in libs/nets/pyramid_network.py?

Line 252-265: from rois to cropped_rois, the order of rois has been changed, which means the outputs['refined’][‘box’] has different order compared to rois. However, bbox_targets (Line 420) has the same order as rois. So for Line 441 refined_box_loss = bbox_inside_weights * _smooth_l1_dist(boxes, bbox_targets), there is misalignment between boxes and xbox_targets. If this true, this is a serious bug. Or am I misunderstanding something here? Thanks.

I agree with you. The order is changed and could lead to serious performance drop.
@amirbar: You probably wanna look into this.

Is the problem solved?

No. I have tried to change the order of rois to match with cropped_rois but it still cannot train the refined boxes and classes. The values from refined boxes still close to zero and the network still cannot predict anything else but class 0 and 1(There should be 81 classes predicted).

@souryuu Do you know why the network cannot predict anything but classes 0 and 1? Thanks!

I made several changes and got better classification results.

Set resnet to be trainable and correct the size of image. @amirbar has already fixed this in his recent commit #50.
As mentioned above, match the order of rois and crop_rois.
Add batch normalization. I changed all the _extra_conv_conv_scope in pyramid_network.py to _extra_conv_arg_scope_with_bn.

Changes in 1 and 2 seem to be critical. I did not compare the version with and without the changes in 3 yet but it made the trained network to produce decent (more colorful?) cropped_rois.

@souryuu can you please come up with a PR?
On Jun 24, 2017 5:22 AM, "souryuu"<EMAIL_ADDRESS>wrote:
I made several changes and got better classification results.

Set resnet to be trainable and correct the size of image. @amirbar
https://github.com/amirbar has already fixed this in his recent commit
#50 https://github.com/CharlesShang/FastMaskRCNN/pull/50.
As mentioned above, match the order of rois and crop_rois.
Add batch normalization. I changed all the _extra_conv_conv_scope in
pyramid_network.py to _extra_conv_arg_scope_with_bn.

Changes in 1 and 2 seem to be critical. I did not compare the version with
and without the changes in 3 yet but it made the trained network to produce
decent (more colorful?) cropped_rois.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CharlesShang/FastMaskRCNN/issues/68#issuecomment-310807563,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGG2FiWecRgXIeOg67zZ9vElJXyncdNiks5sHHL6gaJpZM4Ntt7L
.

@amirbar #96
Since I changed many parts of the code for visualization, it is quite messy.

@souryuu
Is your code already merged in the master branch?
Because I trained the network for 2 days, the results seems really bad.
And I still do not know how to write a evaluation code. (how to you visualize the output)
can you please help and share your code?
thanks


Move icon heuristic to appstream2dict

@barthalion looks like this broke a test, or the tests needs to be updated (if the changes are correct)

Seems to be more an issue with encoding?
>       assert etree.tostring(feed) == etree.tostring(expected)
E       assert equals failed
E         b'<rss xmlns:atom="http://www.w3.org/2005/Atom" xmlns:content="http://purl.org/rss  b'<rss xmlns:atom="http://www.w3.org/2005/Atom" xmlns:content="http://purl.org/rss
E         /1.0/modules/content/" version="2.0"><channel><title>Flathub â€“   /1.0/modules/content/" version="2.0"><channel><title>Flathub – recently upda

The test has been updated already, it's unhappy about –.

Well, that's weird, it works after replacing it with â€“. All I did was curl > file and somehow that didn't work.


Snapshot capturing API and storage backend

Event sourced actors and views shall be able to take snapshots of internal state. Supported storage backends should be the local file system and HDFS.

Closed with #77


Integration with API together.ai

Is your feature request related to a problem? Please describe.
There are services with LLM models that provide a starting deposit for testing, for example together.ai
Describe the solution you'd like
If possible, please implement integration with together.ai LLM(meta-llama/Meta-Llama-3.1-70B-Instruct-Turbo)
Additional context
Example request in Python:
import os
from together import Together

client = Together(api_key=os.environ.get('TOGETHER_API_KEY'))

response = client.chat.completions.create(
    model="meta-llama/Meta-Llama-3.1-405B-Instruct-Turbo",
    messages=[],
    max_tokens=512,
    temperature=0.7,
    top_p=0.7,
    top_k=50,
    repetition_penalty=1,
    stop=["<|eot_id|>"],
    stream=True
)
print(response.choices[0].message.content)

Example curl request:
curl -X POST "https://api.together.xyz/v1/chat/completions" \
  -H "Authorization: Bearer $TOGETHER_API_KEY" \
  -H "Content-Type: application/json" \
  -d '{
    "model": "meta-llama/Meta-Llama-3.1-70B-Instruct-Turbo",
    "messages": [],
    "max_tokens": 512,
    "temperature": 0.7,
    "top_p": 0.7,
    "top_k": 50,
    "repetition_penalty": 1,
    "stop": "[\"<|eot_id|>\"]",
    "stream": true
  }'

Hi @sashabal,
This feature is not part of the product roadmap, but I will do everything possible to work on it in the coming months.
If you need it immediately you could use LLAMA locally, or implement this new feature yourself, I'm happy to guide you through the beelzebub code base :smile:
Cheers
Mario

Ok, Thank you


Saleor 8017 add fulfillment approve webhook 3.7

Add FULFILLMENT_APPROVED webhook
Call the new webhook when fulfillment is automatically approved
Call the new webhook when fulfillment is approved with the use of FulfillmentApprove mutation

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-8017 Add fulfilment approve webhook


Resolve - Logical definition of Occurrence

The spirit of Occurrence in Darwin Core is the evidence resulting from an Event. Thus, specimens (PreservedSpecimen, FossilSpecimen, LivingSpecimen), material samples (MaterialSample), and observations (HumanObservation, MachineObservation) are evidence resulting from "specimen collection", "material sampling process", or "observing process".
Depends on the logical definition of MaterialSample with respect to the types of specimens listed above (see https://github.com/tucotuco/bco/issues/17).

Some notes of our discussion of this are available at https://docs.google.com/document/d/131C2qS_BVvE1zUtbaoS2Mq8QWuJ9N5JR7RcShxgGA24/edit.
Highlights include:
-the distinction between evidence and trust/confidence
-the importance of using evidence codes, so user can evaluate evidence
-current confounding of an occurrence of an organism in nature and the event of observing or sampling that organism
The decision was that we do not need to model dwc:Occurrence in BCO right now for our data needs, and given the confusion surrounding Occurrence, it would be better if we don't. Will add a comment to that effect.

I added an editor note:
This Darwin Core class should not be used when annotating data with BCO.  It is not mapped to BCO classes because its meaning is too ambiguous.


HANOI UNIVERSITY OF SCIENCE AND TECHNOLOGY SECTOR OF INTERNATIONAL EDUCATION

@kinghip I am sorry, this request has signs of fraud. I have to close it without merging. If you are a student of this school, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


Roll engine 9b8dcc7ecffe..0945635661e5 (5 commits)

https://github.com/flutter/engine/compare/9b8dcc7ecffe...0945635661e5
git log 9b8dcc7ecffe..0945635661e5 --first-parent --oneline
2020-04-06<EMAIL_ADDRESS>Roll src/third_party/skia cc8a76f3c763..04513752fd6e (22 commits) (flutter/engine#17529)
2020-04-06<EMAIL_ADDRESS>Roll src/third_party/dart a8251f820b09..1210d27678a0 (5 commits) (flutter/engine#17528)
2020-04-06<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from LDdBU... to wZ5qZ... (flutter/engine#17527)
2020-04-06<EMAIL_ADDRESS>Roll src/third_party/dart 05103dfe5a0e..a8251f820b09 (4 commits) (flutter/engine#17526)
2020-04-06<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from Ezm2f... to 3yOjK... (flutter/engine#17525)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Commit queue failed; closing this roll.


🐛 Bug Report: Kubernetes UI tab does not display deployments

📜 Description
Kubernetes Deployments are not being shown in the UI even though the backend API returns the data.
API .../api/kubernetes/services/sqlbot returns
{
    "items": [
         {
            "cluster": {
                "name": "prod-digital-banno_us-central1",
                "dashboardApp": "gke",
                "dashboardParameters": {
                    ...
                }
            },
            "podMetrics": [],
            "resources": [
                {
                    "type": "pods",
                    "resources": [...]
                },
                {
                    "type": "services",
                    "resources": [...]
                },
                {
                    "type": "deployments",
                    "resources": [...]
                }
             ]
          }
     ]
}

👍 Expected behavior
Deployments should be shown in the table.
👎 Actual Behavior with Screenshots
Deployments are not shown in the table

👟 Reproduction steps
Setup the built in Kubernetes plugin.
Go to the Entity page and click the Kubernetes tab.
📃 Provide the context for the Bug.
No response
🖥 Your Environment
We are up to date on yarn 4 and the latest backstage cli version
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, but I'm happy to collaborate on a PR with someone else

I'm not the one that's the most familiar with the k8s plugin, but it does require your actual entity annotations to reference the resources that are relevant to it, right? What does your entity look like?


fix: remove volunteerId when donor edits donation to not need volunteer

Brief description. What is this change?

Remove volunteerId when [Donor] edits donation to not need volunteer
Previously, when a donor edits a donation to no longer need a volunteer, we weren't setting volunteerId to null meaning if they required a volunteer again, the volunteer would be auto-assigned. This removes the volunteer if the donor no longer requires one.

Implementation description. How did you make this change?
Set volunteerId to null if the edited fields no longer has volunteerNeeded.
Correct payload:

Steps to test

Create a donation that requires a volunteer
Sign up for donation as volunteer, verify you see it in volunteer dashboard
Log back in as donor and remove volunteer needed on donation
Verify the shift is gone in the volunteer dashboard

Checklist

[x] My PR name is descriptive and in imperative tense
[X] My commit messages follow conventional commits and are descriptive. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
[X] I have run the appropriate linter(s)
[X] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
[X] The appropriate tests if necessary have been written

functionality works but got the wrong email:

In a different ticket for that fix ^


Call load_state_dict on model classes

This PR enables models to handle load_state_dict calls. Therefore, model classes can easily remap keys and do some shape changes on the checkpoint tensors. Also, strict checkpoint validation is used for pipeline.model.

I know this is a tiny change, but this will make it easier to reimplement methods with dynamically-sized parameters (e.g. plenoxels or pointnerf). I am currently working on pointnerf reimplementation integrated into nerfstudio, but I think it would be better to keep it in a separate repo, as it requires some cuda extensions to be build. What do you think? I will also prepare an example repo demonstrating how to build a separate "extension" method implementation.


Backup font when loRes font fails on parents and league pages

Issue
Currently one of our heading fonts fails in production. The fallback font is a completely different style.
This change adds a fallback font that is in the spirit of the original pixel art font.
This change is best shown through screenshots. Below are screenshots of codecombat.com/parents and codecombat.com/league pages.
This is how the headings are supposed to appear:

The font loading may fail due to cors issues. Then the following is shown:

This PR adds this fallback:

Testing
This can be tested manually in a local environment, running both npm run dev and npm run proxy in separate terminals.
Then navigate to localhost:3000/league and localhost:3000/parents
I find I can reproduce LoRes breaking on Chrome, whilst Safari seems to load the font.

Doing a deploy to staging.codecombat.com for testing. Skipping code review as low code risk complexity. Instead want to check that font is loading on our staging infrastructure.


Some question about metaworld environment.

I'm interested in your MetaWorld.
It will be good benchmark about Meta-RL.
I have some questions about this benchmark.

When start at environment, sawyer arm move to specific pose during first K steps.(K is about 10)
It seems like 'init' function called by mujoco.
I think this will cause problems when agent do reinforcement learning.
Is this intended?

Reward gap is big between some environment.
When reach env get almost 100 at first time, push env get small reward(between 0 and 1).
Is this intended?

Thank you for your hard work.
Let me ask you one more question.

The environment codes(sawyer_drawer_close.py, etc.) contain the function 'compute_rewards(self, actions, obsBatch)' and has the commnet 'Required by HER-TD3'.
As far as I know, the HER algorithm has set another goal using the last state of the trajectory.
However, setting another goal does not exist in this function.
Instead, this function computes rewards using self._state_goal. (It is not different from normal reward computing function which using in interaction between agent and environment)
Is it intended? If that be so how can I use this function for HER algorithm?

@zhanpenghe

Hi @pigranya1218

We haven't found this to cause any problems when training single-task or multi-task policies. Can you be more specific about the problem you are describing? Perhaps you can link to some code?

We are aware that the reward functions have huge changes in magnitude within the same task, and large differences between tasks. We didn't do this to make the benchmark artificially hard, we just engineered reward functions until each environment can train with a single-task RL algorithm. We believe this is a realistic simulation of a real multi-task learning problem, in which it is very difficult (and sometimes intractable) to hand-engineer dense reward functions which satisfy inter and intra-task normalization. Note that you are free to add a normalization technique to your algorithm to deal with this problem. In fact, if you find a general one, I believe that's a notable research contribution to MTRL. You are also free to ignore the reward functions entirely and instead using the sparse 'success' signal provided in env_info instead;.

Metaworld is not a goal-conditioned benchmark, and we don't support accessing, mutating, etc. the task-specific goals at this time. In the future, we may add a goal-conditioned version. Some tasks may keep an internal state called a "goal," "state_goal," etc. but sometimes this goal is not actually the final state of a successful task, sometimes it contains more information (or less) than needed to complete the task, etc. You could still apply HER to metaworld by somehow extracting goal positions from regular state observations, but there is intentionally no interface for asking the environment what a successful state (goal) is.

Can you point to a code snippet reproducing this?

Thank you for your apply.

This question was just curiosity. thanks.

It is same above.

I understand. Thank you.

It looks like there are no state difference over 120 step though grip action acted.
Very small difference is found since 132 step~, but I think it is just changed by X pos which made by gripper closing, whether gripper is closed or open.
I think that agent doesn't know using state the object is gripped. (fortunately the object is moved by gripped then agent can know, but there are some unfortunate case)

+5) one more question!
A few weeks ago, I received an e-mail saying the MTRL code used in experiments will be provided in a few weeks.
When will it be provided? I think this code will be good baseline code to learn MTRL.
Thanks.

@pigranya1218 are you saying (1) there's nothing in the state telling the agent that the object is gripped, or (2) nothing in the state telling the agent the state of the gripper is open/closed?
Please email me at <first_initial><last_name>usc.edu for more info on MTRL code used for experiments.

Thanks for reply!
I'm send email to you.

I said (2).

@tianheyu927 can you comment on the gripper state?

@pigranya1218 the gripper open/close state is not present in the observation space, but we have not found it required to solve the environments. For proof, you can take a look at the scripted policies in metaworld.policies
For instance if you have an object position and gripper position, and need to know if you've grasped the object, you can infer that based on the distance between gripper and object.


Code of finetuning the cogagent on Mind2Web ?

Thank you very much for your work. May I ask if it's possible to share the code on how to finetune the cogagent on Mind2Web ?

No plan for this. You can use finetune.py and ae mind2web datset to #Instruct or #CogcCOM dataset formate

can you share the finetune code ?


What are the differences between different way to animate things?

I see that we can animate properties like this:
https://animejs.com/documentation/#propertyKeyframes
But we can also put them in timeline then animate each properties:
https://animejs.com/documentation/#cssProperties
What are the pros and cons of each approach? Is one way better than the other?

I think it's largely down to personal preference and the specific needs of your project, it's hard to say whether one way is 'better' than the other, and there's no reason for you to only use one approach. Try different methods out and see which makes the most sense for you. Maybe make a codepen and animate something simple in a couple of different ways.
For me, a timeline is useful when I'm animating multiple targets - if there's just one target, then you probably don't need a timeline, unless the animation is really long and complex.
If you have an anime timeline with a bunch of different elements, but you're going to animate a whole lot of changes in a row to one element (or group of elements) then it's worthwhile using keyframes within that timeline.
One major difference between animation keyframes and property keyframes is just how the information is presented - when you're working on a complex animation and you need to tweak things or refer back to parts that you worked on a while ago, you should be able to read your code and know what's happening. In some situations it may be easier to read complex animations grouped by property (property keyframes), in others it may be easier to see all properties together, arranged chronologically (animation keyframes). You can use either/both of these keyframe types within a timeline, and simple property: value pairs too.


Discrepancy Between Mentioned and Available Plugins in Repository

Hello,
I was reading through your paper, specifically section A.2.3 AUTO-SCALING PLUGINS, where it's mentioned, "This method has enabled us to introduce over 200 high-quality plugins."  However, upon inspecting the GitHub repository at https://github.com/xlang-ai/OpenAgents/blob/main/real_agents/plugins_agent/plugins/plugin_names.py, I only found references to 16 plugins.
Here's a brief overview of what's listed in plugin_names.py:
class PluginName(str, Enum):
    """
    Enum class for plugin names
    each name is a plugin name 🔌 , each value is the folder name 📁 of the plugin
    """
    KLARNA = "klarna"
    ZAPIER = "zapier"
    COURSERA = "Coursera"
    JOBSEARCH = "jobsearch"
    SHOW_ME = "show_me"
    SPEAK = "speak"
    CREATE_QR_CODE = "create_qr_code"
    MAPS = "maps"
    ASKYOURPDF = "askyourpdf"
    OUTSCHOOL = "Outschool"
    NBA_STATS = "nba_stats"
    WOLFRAM = "wolfram"
    WEB_SCRAPER = "web_scraper"
    DREAMINTERPRETER = "DreamInterpreter"
    BIZTOC = "biztoc"
    XWEATHER = "XWeather"

Given the significant discrepancy between the 200+ plugins mentioned in the paper and the 16 plugins listed in the repository, I'm curious about the reason behind this.  Are the additional plugins not open-sourced, or do the listed 16 plugins serve as wrappers for a broader set of functionalities?
Thank you for clarifying this discrepancy. 🙂 @Timothyxxx

Thank you for pointing it out. In our publicly released demo (which we no longer maintain now since it is costly), the over 200 APIs are complete, but as you mentioned, this part is missing in the code. I believe this might be due to our failure to fully clean up the code when uploading and making it public (considering the varying quality of APIs, many of which are constantly changing, cleaning and maintaining them takes some time). This aspect was overlooked while we were engaged in other tasks and maintaining other features. If you need it, I will find some time this week to continue the cleanup and upload it to meet your requirements.
Tianbao

Thank you for pointing it out. In our publicly released demo (which we no longer maintain now since it is costly), the over 200 APIs are complete, but as you mentioned, this part is missing in the code. I believe this might be due to our failure to fully clean up the code when uploading and making it public (considering the varying quality of APIs, many of which are constantly changing, cleaning and maintaining them takes some time). This aspect was overlooked while we were engaged in other tasks and maintaining other features. If you need it, I will find some time this week to continue the cleanup and upload it to meet your requirements.
Tianbao

I have another question that I would like to seek your advice on. Regarding the 200 tools you mentioned, I noticed that each one has a .py file in its corresponding path, such as the search.py file found in the real_agents/plugins_agent/plugins/Coursera/paths directory.
Were these collected by you via Rapid API, or were they generated offline using the OpenAPI Generator tool from a YAML file? Does this process involve a significant amount of manual effort?
I am a developer at Camel, and I've observed that compared to other LLM agent projects, your work incorporates a notably large number of tools, which I find to be very useful. I greatly appreciate the effort and innovation your team has put into this project, and I look forward to your advice on the matter. @Timothyxxx
Ziyi Yang

No problem, I have an ICLR conference to attend next week, so I'll try to find some time this week to organize and upload the information, and then I'll let you know~
Regarding the source of the tools, that's a good question. I suddenly realized we haven't mentioned this elsewhere. Initially, we tried to import some tools from Rapid API to expand our collection, but we found (I'm not sure if any research is currently addressing this) that the input parameters and returned information from these traditional APIs are overly complex and structured data. The current models struggle with planning and accurately parsing natural language into such inputs, and understanding the responses is also limited, especially with noisy data. Not to mention the API providers are generally not willing to provide APIs to developers instead of companies.
So, we actually reverse-engineered the functionality of OpenAI Plugins, obtained the endpoints and openapi.yaml from the providers offering Plugins API to them, and then automated pings to see if they were free or if some required additional verification or had IP restrictions. Then, we retrieved the APIs that were accessible. At that time, we were able to retrieve over a hundred APIs using this method. I'm not sure if the ecosystem of OpenAI Plugins has significantly improved by now (I think they abandoned Plugins and opened the GPTs store and seem to abandon and try something bigger instead), but if it has, you might be able to access even more APIs for use with Camel (I know this project has also been in touch with Guohao haha).
Thank you,
Tianbao

Thank you very much for your detailed explanation; it has been incredibly helpful. 🙏🙏
Could I inquire about waht tools or Python libraries do you use for converting an openapi.yaml file into automatically ping code?

Thank you very much for your detailed explanation; it has been incredibly helpful. 🙏🙏
Could I inquire about waht tools or Python libraries do you use for converting an openapi.yaml file into automatically ping code?

Oh I saw the use of prance in your code. https://github.com/xlang-ai/OpenAgents/blob/main/real_agents/adapters/data_model/plugin/base.py
From my search, it also seems the best openapi file parser in python.
I think I know the answer. Thank you for your time.


[FLINK-9513] Implement TTL state wrappers factory and serializer for value with TTL

What is the purpose of the change
This PR introduces a state factory for wrapping state objects with TTL logic and serialiser of user value with expiration timestamp.
NOTE: This PR is based on #6186 and only last commit 99994dedb9a20244a2addd337617778b17fe8349 makes difference with it and needs review.
Brief change log

abstract state creation in backends with KeyedStateFactory interface
add TtlStateFactory
add CompositeSerializer

Verifying this change
This change is a trivial addition without any test coverage in this PR and should be covered together with TTL feature activation by final integration and e2e tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (yes)
The runtime per-record code paths (performance sensitive): (not yet)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (not yet)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (not applicable at the moment)

Thanks for the nice contribution. I had some comments inline. In particular three points about the serializer. I would suggest to avoid the use of raw types. I would also suggest to avoid using streaming API at least methods that can appear in hot loops (mainly copy, de/serialize) for performance reasons. I think the imperative style code will not even be (much) longer in those cases. Last, I suggest to always test new serializers via the SerializerTestBase because this catches many problems with little effort.

@StefanRRichter @sihuazhou
Thanks guys for the helpful review.
I refactored the CompositeSerializer to rely rather on loops than streams and added tests for it.
Please, have a look.
cc @twalthr
Maybe, the implementation of CompositeSerializer in this PR could be potentially interesting for other complex types, e.g. tuples or pojos allowing code reuse where it is possible without performance loss.

Regarding CI, seems to be unrelated test YARNSessionCapacitySchedulerITCase, passed in my CI

I had a few more comments, in particular some improvements for the new serializer. I think when those are addressed this is good to merge.

Had a few more comments, but they all are basically optimizations. I leave it up to you if you still want to address all or some of them. Please let me know. Otherwise, we can merge this. 👍

LGTM 👍 merging.

I found there is still a small issue with the equals/hashCode but will just fix it before merging.


GEODE-5441: Use cmd.exe when invoking gfsh.bat in GfshRule

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

I'm glad to see GfshRule is still getting some love :) 👍


proposal of adding a tool like blsunpack for SLB2 files

i'm not sure if you could do this also but blsunpack handles SLB2 files.
https://github.com/zecoxao/blsunpack
if you don't mind adding it to unpack those bins into directories with the files inside :)

Also, i'm not a fan of C#, so that was why i didn't make a pull request yet xD

Nevermind, just noticed the README, closing issue...


Modify config file when train with custom dataset

Hi,
I built a custom dataset based on COCO format. And added a new my_dataset.py under mmdet/datasets and added from .my_dataset import MyDataset in init.py.
Then, I modified the  configuration file:
dataset_type = 'MyDataset'
data_root = 'path/to/my/dataset'
data = dict{}
During the training, the accuracy is almost 100. However, in evaluation, the mAP is almost 0. I don't know what's wrong with my setting. Did i forget to change any details?
Best,
Neo

I don't know either. For custom datasets, you need to figure out 1) if your annotation is correct, 2) if hyper-parameters are suitable for your application. You cannot expect getting good results without any prior knowledge of your data and settings.

@hellock Hi, thanks for the explanation. I get one more question. For instance, I get a one-class dataset. When I train the model, do I need to modify the num_classes under bbox_head to 1 (Originally, it is 81)?


Add searchAfter and pit methods to the search request builder

This pull request adds search_after and pit options to SearchRequestBuilder.
When the amount of results is larger than elasticsearch's results window, the from parameter cannot be used. It is recommended to use the search_after parameter instead. This PR enables that functionality.
This depends on an updated version of babenkoivan/elastic-adapter. composer.json is currently set up to load the forked version but once https://github.com/babenkoivan/elastic-adapter/pull/17 is merged, it can be reverted to the main repo.

Unfortunately, it turned out that point in time won't work with the current adapter/driver architecture. The required changes are not backward compatible, this means the feature is postponed until v4 is released, which might happen later this year.


esmvalcore v2.9.0rc1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] ~Bumped the build number (if the version is unchanged)~
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

pls close #61 after you merge :+1:


legacy decoder for v0.7 format

Travis seems to have problems, since the test last long, taking a substantial time budget.
Final result is not perfect :
https://travis-ci.org/Cyan4973/zstd/jobs/147276812
Still some issue with inlining on ppc platform.
I'm quite surprised though. These functions did not changed substantially between 0.6 and 0.7, so there is very little reason why they would pass without problem on 0.6, and fail with a inline warning on 0.7.
Suggest you remove the -Werror flag, because if you have to find them one by one, it will take a while.

I removed some FORCE_INLINE for v0.6 as well.
It's better to remove -Werror as we will face the same problems with v0.8 and newer legacy decoders.

:+1:
Still, puzzled why inline becomes a problem for ppc target specifically, while it was working well so far.
Maybe we could remove this warning specifically on ppc target, keeping the ability to detect other kind of warnings.

A good idea. "-Wno-attributes" should be enough.