Fix broken things due to changes to Graphics#getWidth()

All of this classes are affected by the change to Graphics#getWidth().
Some are definitely broken, other may not be broken.
Definitely broken:

[x] https://github.com/libgdx/libgdx/blob/master/gdx/src/com/badlogic/gdx/utils/ScreenUtils.java
[x] https://github.com/libgdx/libgdx/blob/1f9308530ae97f2ff83f0cb1f92e656df3a924d7/tests/gdx-tests/src/com/badlogic/gdx/tests/g3d/shadows/system/classical/ClassicalShadowSystem.java#L79
[x] https://github.com/libgdx/libgdx/blob/ea705f519bfca15822218064b4654c4f0e83db96/tests/gdx-tests/src/com/badlogic/gdx/tests/g3d/shadows/system/ShadowSystem.java#L60
[x] https://github.com/libgdx/libgdx/blob/bf43f04d5cd37b46a9a956f8aca8f99a9f73a2fa/gdx/src/com/badlogic/gdx/scenes/scene2d/utils/ScissorStack.java#L106-L139

Maybe broken:

[x] https://github.com/libgdx/libgdx/blob/1f9308530ae97f2ff83f0cb1f92e656df3a924d7/tests/gdx-tests/src/com/badlogic/gdx/tests/g3d/shadows/system/classical/MainShader.java#L58
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/graphics/g2d/SpriteCache.java#L55
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/graphics/g2d/SpriteCache.java#L138
[ ] https://github.com/libgdx/libgdx/blob/5afb2aca5f49c39408c94e223cc2d51a66197d08/gdx/src/com/badlogic/gdx/graphics/g3d/particles/ParticleShader.java#L139
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/extensions/gdx-tools/src/com/badlogic/gdx/tools/particleeditor/ParticleEditor.java#L352-L353
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/extensions/gdx-tools/src/com/badlogic/gdx/tools/flame/FlameMain.java#L643
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/graphics/glutils/ShapeRenderer.java#L120
[x] https://github.com/libgdx/libgdx/blob/6a5ce34240d5b70e3f6bb855de54e6fe0627a9c6/gdx/src/com/badlogic/gdx/graphics/g2d/PolygonSpriteBatch.java#L137
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/graphics/g2d/SpriteBatch.java#L102
[x] https://github.com/libgdx/libgdx/blob/bf43f04d5cd37b46a9a956f8aca8f99a9f73a2fa/gdx/src/com/badlogic/gdx/utils/viewport/Viewport.java#L226
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/graphics/Camera.java#L264
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/graphics/Camera.java#L221
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/graphics/Camera.java#L206-L212
[ ] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/assets/loaders/resolvers/ResolutionFileResolver.java#L103
[ ] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/emu/com/badlogic/gdx/assets/loaders/resolvers/ResolutionFileResolver.java#L60-L63
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/graphics/OrthographicCamera.java#L70-L73
[x] https://github.com/libgdx/libgdx/blob/f540346a0e17bbcbee2a4ae522c46c17207346bb/gdx/src/com/badlogic/gdx/scenes/scene2d/Stage.java#L91
[x] https://github.com/libgdx/libgdx/blob/f540346a0e17bbcbee2a4ae522c46c17207346bb/gdx/src/com/badlogic/gdx/scenes/scene2d/Stage.java#L115
[x] https://github.com/libgdx/libgdx/blob/000462858699fdd205325e320c152f66a504444f/tests/gdx-tests/src/com/badlogic/gdx/tests/superkoalio/SuperKoalio.java#L265
[x] https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/graphics/g3d/utils/CameraInputController.java#L112

Maybe broken, but unused:

[x] https://github.com/libgdx/libgdx/blob/92d58c52c5f9be9fc1d650a3c6c879cb6ced086d/gdx/src/com/badlogic/gdx/input/RemoteInput.java
[x] https://github.com/libgdx/libgdx/blob/92d58c52c5f9be9fc1d650a3c6c879cb6ced086d/gdx/src/com/badlogic/gdx/input/RemoteSender.java

Nice list
Out of the "Maybe broken" category most should be correct, I'm not sure about:

MainShader and ParticleShader, I don't know how are these values used
Resolution file resolver - Here it depends on what it should actually do. Something like Apple's @2x could be added.

RemoteInput/Sender does not do anything with BackBuffer, so it should be correct as well.

Thanks a ton for doing this. I'll go through those things later this week.

In the definitely broken category:

ScreenUtils only needs updated JavaDocs and fix getFrameBufferTexture() to use HDPIUtils.
ClassicalShadowSystem, yes, i have not touched any of the 3D API yet. Maybe @xoppa can assist a little. This needs to pass in the back buffer width/height now.
Same as 2.
ScissorStack has already been fixed, it still works with logical coords, but uses HDPIUtils under the hood when calling glScissor and consorts.

In the maybe broken category:

MainShader is likely correct, @xoppa please advise.
SpriteCache is correct, only calls to glViewport, glScissor and glReadPixel need to be fixed up. Everything else continues to work in logical coords (which may or may not be == back buffer coords)
ParticleShader is likely correct, @xoppa please advise.
ParticleEditor is based on LWJGL2, which will never support HDPI the way LWJGL3 does (meaning getWidth() == getBackBufferWidth() in LWJGL2)
FlameMain same as above, LWJGL2
ShapeRenderer is correct, like in the case of SpriteCache, we always work in logical coords
PolygonSpriteBatch is correct, logical coords
SpriteBatch is correct, logical coords
ViewPort is correct, logical coords
Camera is correct, logical coords
ResolutionFileResolver should probably use the back buffer width/height, even if the app works in logical coords
SuperKoalio is correct, logical coords
CameraInputController is correct, logical coords

RemoteInput and RemoteSender are also correct.

The shadow tests are WIP, I asked @realitix to have a look at it. I think the ParticleShader might actually need to be changed, will have to test it. It is used to set gl_PointSize, so the particles would be differently sized.

@intrigus These classes are not broken anymore, you can check it in your task list:

https://github.com/libgdx/libgdx/blob/1f9308530ae97f2ff83f0cb1f92e656df3a924d7/tests/gdx-tests/src/com/badlogic/gdx/tests/g3d/shadows/system/classical/ClassicalShadowSystem.java#L79
https://github.com/libgdx/libgdx/blob/ea705f519bfca15822218064b4654c4f0e83db96/tests/gdx-tests/src/com/badlogic/gdx/tests/g3d/shadows/system/ShadowSystem.java#L60
https://github.com/libgdx/libgdx/blob/1f9308530ae97f2ff83f0cb1f92e656df3a924d7/tests/gdx-tests/src/com/badlogic/gdx/tests/g3d/shadows/system/classical/MainShader.java#L58

Thanks

Only https://github.com/libgdx/libgdx/blob/5afb2aca5f49c39408c94e223cc2d51a66197d08/gdx/src/com/badlogic/gdx/graphics/g3d/particles/ParticleShader.java#L139 and https://github.com/libgdx/libgdx/blob/fde893cec5448fdd09e778d1c103aac474950873/gdx/src/com/badlogic/gdx/assets/loaders/resolvers/ResolutionFileResolver.java#L103 left, could you please have a look at it @xoppa ?

Hello!
You have a new message, please read http://llarmanelpujades.agape.org/find.php?j
<EMAIL_ADDRESS>

For the ResolutionFileResolver issue , it changed from the deffination when they update the code so, it does not get the correct value .

The missing change in ResolutionFileResolver is introduced by #6174.
Regarding the ParticleShader one I'm not really sure: it is used to calculate gl_PointSize, but a quick test showed no visible visual differences with either getWidth() and getBackBufferWidth(). If anyone knows more about this, please tell.


deploying services automatically

this PR is about below changes

Adding Inventory CR to deploy the services
Modifying target named Deploy to start services automatically
Allain also  add some new function and some RBAC.

/close
see #292


Updated the installation to use npx

npx ships with npm as of v5.2.0
Before submitting a pull request, make sure it's targeting the right branch:

For fixes to Ink 1.0, use master.
For fixes to Foundation for Emails 2, use v2.0.

Happy coding! :)

Thanks for the review @DanielRuf. I've made changes as requested.

In general I would also keep the old part as this is also an option (for those wo can not or do not want to use npx and want to install it globally.
So please a the old part too. The recommended way is npx and yarn.

So please a the old part too. The recommended way is npx and yarn.

Sounds like you have a good idea how you'd like it to be conveyed. Feel free to use this PR as a starting point. :smile:


Simple long-standing objtypespec bug

Types that are used in equivalent objtypespec guards must be locked to protect against, e.g., adding a property to a dictionary type handler, which will only change the type if it's locked.

Could there be other cases for which we would now start locking the type?

Sharable type handlers are already going to be locked. This should just affect dictionary cases, and we need to lock those in case properties get added. (Weird that it took so long to find such a simple issue.)
-- Paul

From: Rajat<EMAIL_ADDRESS>Sent: 3/15/2016 10:49 AM
To<EMAIL_ADDRESS>Cc: Paul<EMAIL_ADDRESS>Subject: Re: [ChakraCore] Simple long-standing objtypespec bug (#566)
Could there be other cases for which we would now start locking the type?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/ChakraCore/pull/566#issuecomment-196945345

Thanks, @pleath . Although, what I meant to ask was- for dictionary types themselves, could there be other operations than property adds, for which we will now lock types?

You mean, are there cases where we will have locked the guard type and now have to promote the type when something other than a property add happens? Well, we do want to promote the type on a type ID change (see the comment that’s already there). I suppose we might now promote on a change to property attributes. For change to non-writable, promotion is probably a good idea anyway. Change in configurability or enumerability is bound to be a corner case, so I’d rather just accept the promotion for the sake of simplicity. Perf is flat, by the way. (I actually saw an improvement in gbemu.js, but I think it was flakiness in the run.)
--Paul
From: Rajat Dua<EMAIL_ADDRESS>Sent: Tuesday, March 15, 2016 12:13 PM
To: Microsoft/ChakraCore<EMAIL_ADDRESS>Cc: Paul Leathers<EMAIL_ADDRESS>Subject: Re: [ChakraCore] Simple long-standing objtypespec bug (#566)
Thanks, @pleathhttps://github.com/pleath . Although, what I meant to ask was- for dictionary types themselves, could there be other operations than property adds, for which we will now lock types?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/Microsoft/ChakraCore/pull/566#issuecomment-196979242

Ok, makes sense. Looks good.


Add ability to run against a colon separated file with username and password/ntlm hash pairs.

Feature Request
I would greatly appreciate the ability to provide CME a file with either:

username:password
username:HASH

Detailed issue explanation
Currently, I have to run CME anywhere from ten to thirty times during the course of a penetration test and maintain separate files to verify the level of access obtained.
I have attempted to solve this with a for loop in bash but my skills are apparently lacking.
Thank you!

Simple, just put all the username in one file and all the password in another file and then
#~ cme smb <IP_ADDRESS> -u user.txt -p password.txt --no-bruteforce --continue-on-succes
https://mpgn.gitbook.io/crackmapexec/smb-protocol/password-spraying#checking-one-login-equal-one-password-using-wordlist

Great. Thank you, I will give that a whirl. --no-bruteforce appears to give me what I am looking for.

It's a new option from the v5 :+1:


Dynamic parameters.

Hi guy, i have a question.. how to overwrite/configure dynamic SMTP? I have a business case that he can send email from 3 different accounts and the SMTP, port, direction, etc he can configure and save in database. Tnks :D

You beat me to it! 👍
I posted in the slack #plugin channel yesterday with a similar business requirement to see if there had been any discussions or efforts on implementing this. It is mentioned as a TODO in the documentation.
I would be motivated to take this on but think it would be best if the authors pitch in with their thoughts on how this should be implemented.
Currently, the mail sender is a bean created in the plugin class and injected in the MailMessageBuilderFactory, which in turn creates a builder for every message sent. Options for implementing a more flexible configuration of dynamically configured servers could include

adding the ability to configure multiple senders together with a name-based specification of which sender to use in the sendMail closure.
adding a getter to the service that returns a clone of the current sender, which could be reconfigured and provided as an attribute to the sendMail closure
adding a configuration map as an attribute to the sendMail that then gets merged with the default configuration

Thoughts? Other options/preferences?

In the absence of any feedback so far, I have been able to implement a workaround by replacing the mailMessageBuilderFactory bean with the following:
`import grails.config.Config
import grails.core.GrailsApplication
import grails.plugins.mail.MailMessageBuilder
import groovy.util.logging.Log4j
import net.katerva.portal.security.oauth.OAuth2Provider
import org.springframework.mail.MailSender
import org.springframework.mail.javamail.JavaMailSenderImpl
import javax.annotation.PostConstruct
import javax.mail.Session
import java.security.Security
@Log4j
class MailMessageBuilderFactory extends grails.plugins.mail.MailMessageBuilderFactory {
GrailsApplication grailsApplication

@PostConstruct
void init() {
    Security.addProvider(new OAuth2Provider())
}

@Override
MailMessageBuilder createBuilder(Config config) {
    MailSender mailSender = this.mailSender
    if (config.props) {
        mailSender = getMailSender(config)
    }
    new MailMessageBuilder(mailSender, config, mailMessageContentRenderer)
}

MailSender getMailSender(config) {

    log.debug "Configuring new sender: $config"

    JavaMailSenderImpl mailSender = new JavaMailSenderImpl()
    if (config.host) {
        mailSender.host = config.host
    } else if (!config.jndiName) {
        def envHost = System.getenv()['SMTP_HOST']
        if (envHost) {
            mailSender.host = envHost
        } else {
            mailSender.host = "localhost"
        }
    }

    if (config.encoding) {
        mailSender.defaultEncoding = config.encoding
    } else if (!config.jndiName) {
        mailSender.defaultEncoding = "utf-8"
    }

    if (config.port) {
        mailSender.port = config.port
    }

    if (config.username != null) {
        mailSender.username = config.username
    }

    if (config.password != null) {
        mailSender.password = config.password
    }

    if (config.protocol != null) {
        mailSender.protocol = config.protocol
    }

    if (config.props instanceof Config) {
        Session session = Session.getInstance(config.props.toProperties())
        session.setDebug(config.debug ?: false)
        mailSender.session = session
    }

    mailSender
}

}
`
That was the easy part... figuring out how to use XOAUTH2 with a service account user for Google Apps, not so much :)


Add Visual Studio 2022 Preview

Tool information

Tool name: Visual Studio 2022
Tool license: Commercial
Add or update? Add
Desired version: Preview
Approximate size:
If this is an add request:

Brief description of tool: Visual Studio 2022 preview could help to assess this new compiler
URL for tool's homepage: https://visualstudio.microsoft.com/vs/preview/vs2022/
Provide a basic test case to validate the tool's functionality:

Area for Triage:
C/C++
Question, Bug, or Feature?:
Feature
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016 R2
[X] Windows Server 2019

Can this tool be installed during the build?

Tool installation time in runtime

Are you willing to submit a PR?

Hello @jwillemsen , we have a plan to add Visual Studio 2022 to the Windows Server 2022.
Installing multiple Visual Studio instances side by side is pretty painful so we would like to keep one VS on one Windows platform.
ETA for adding Windows Server 2022 is 2-3 months. We are working on plan for it now.

Ok, that would be great, would make it much easier to test this new compiler when it is on github actions

Hello everyone!
Windows Server 2022 image with Visual Studio 2022 on board is available for Azure DevOps and GitHub users! 🚀
Please find more details in https://github.com/actions/virtual-environments/issues/3949
GitHub Actions
jobs:
  jobName:
    runs-on: windows-2022

Azure DevOps
jobs:
- job: jobName
  pool:
    vmImage: windows-2022

The windows-2022 image doesn't include VS 2022 preview. The enterprise version is preinstalled, which means this issue remains unresolved.


RuntimeError: Event loop is closed

Error:
Traceback (most recent call last):
  File "gitlab-skyline", line 190, in <module>
    main()
  File "gitlab-skyline", line 186, in main
    generate_skyline_stl(username, year, contribution_matrix)
  File "gitlab-skyline", line 57, in generate_skyline_stl
    year_contribution_list, max_contributions_by_day = parse_contribution_matrix(contribution_matrix)
  File "gitlab-skyline", line 45, in parse_contribution_matrix
    np_contribution_matrix.view('i8,i8,i8').sort(order=['f0'], axis=0)
ValueError: When changing to a larger dtype, its size must be a divisor of the total size in bytes of the last axis of the array.
Exception ignored in: <function _ProactorBasePipeTransport.__del__ at 0x000001DB9823B670>
Traceback (most recent call last):
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.1776.0_x64__qbz5n2kfra8p0\lib\asyncio\proactor_events.py", line 116, in __del__
    self.close()
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.1776.0_x64__qbz5n2kfra8p0\lib\asyncio\proactor_events.py", line 108, in close
    self._loop.call_soon(self._call_connection_lost, None)
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.1776.0_x64__qbz5n2kfra8p0\lib\asyncio\base_events.py", line 719, in call_soon
    self._check_closed()
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.8_3.8.1776.0_x64__qbz5n2kfra8p0\lib\asyncio\base_events.py", line 508, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

I will review it as soon as I have time. Thanks for reporting the bug!

Great!! It works now.
But it only checks contributions to public repos?


[Bug]: Lose binding to a script or api with no errors

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I have a dropdown that I bound to a script, when I set them up I see a message that it will load on page start up, but then after a few uses I see this message and then it stops working and I see only the green red blue options:

It's very annoying and it makes developing on appsmith very difficult. This is not the first time this happens too and I had to try so many things to bypass this problem last time, it shouldn't be this difficult and bindings shouldn't spontaneously be lost.
Please help fix this bug.
About the version of appsmith, where can I see what version is running?
Steps To Reproduce
add a script binding to a drop down to bring it data
see a message it will load on page startup
use it several times
see a message it will not load on page start up anymore and default data is shown in the dropdown from now on
Public Sample App
No response
Environment
Production
Severity
Low (Cosmetic UI issues)
Issue video log
No response
Version
Don't know.

@SelaOZ can you please share a video of the problem? You can find the version of appsmith in the bottom right corner of the editor under the help section.

@Nikhil-Nandagopal
This is the version: Appsmith v1.31.1
It's problematic to show a video because it will show real internal ids.
I forgot to mention but there are no errors also when it happens.

@SelaOZ could you try updating to the latest version 1.44?
If that doesn't work, we can get on a call to debug the issue

yes I'm doing that right now, will update afterwards

It still happens @Nikhil-Nandagopal
first set up

select this one and it's lost:

setup again:

select the first one and it's lost again:

it doesn't happen on every row, I think it mainly happens on rows that have [] or one value, but I can't say that with 100% confidence.
no errors and it's the latest version:

this is the script which works:

@Nikhil-Nandagopal WDYT?

@Nikhil-Nandagopal any updates?

It's being lost even if I place a hardcoded list of values, even if there's one element it's lost:
[
  {
    "label": "INTERNAL_API_VIA_TOKEN",
    "value": "INTERNAL_API_VIA_TOKEN"
  }
]

bump

@SelaOZ
From the screenshots, it looks like you have a table that is bound to a JSONForm(Table.selectedRow)
And in that form, you are using multiselect as field type. Is my assumption correct?
It would be great if you can share a public app or a loom video about your experience. We will prioritize this upon narrowing down the problem.

Awesome! Here is my calendly link: https://calendly.com/rahulbarwal/60-minute-meeting
Feel free to book a slot. @SelaOZ


Update guide to migrate datastore to mysql post

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

NONE

/approve

Okay, our hugo builds the link based on the post's title, huh. I feel it can be changed but good enough to be this 👍
/lgtm

Okay, our hugo builds the link based on the post's title, huh. I feel it can be changed but good enough to be this 👍

Sure, will check the Hugo link build logic later for that kind of issue 🙏

Thanks!


WebSockets do not release ports at once

I am using the given WebSocketServer which runs on Port 9090 instead of 8080.
I wrote a simple WebSocket application, which opens a WebSocket every 100 milliseconds:

http://html5.dennis-boldt.de/netty/

Like this I simulate the opening and closing of approx. 10 WebSockets per second. I started the application 6-7 times in different tabs to simulate 60-70 connection per second. After the applications are running for some time, they aren't able to connect anymore (due to ulimit?). Thus, I observed the connections to port 9090 with netstat:
while true; do sudo netstat -tupla | grep 9090 | wc -l; sleep 1; done;
I realized, that a closed WebSocket does not release the opened port at once:

http://paste.dennis-boldt.de/2012/github.com/netty_netstat

Quite fast (~100 seconds) I got more than 1600 opened ports. Even after I closed the whole browser (Line 150 - http://paste.dennis-boldt.de/2012/github.com/netty_netstat#150), it still took 40 seconds until all opened port were released.
Dennis

I did some more research. Actually, the problem is not the TIME_WAIT as expected before. It seems to be a Firefox specific problem. I tested my application with some opened tabs. Even after closing all of them, some WebSocket connections stayed CONNECTED. The only way to kill all connections is to close the browser. Maybe an add-on is causing the problem.
My last tests in Chrome closed all connections as expected.

Thanks for testing it in more detail. So nothing we can do about...

I am still working on it. I will keep you informed.


Update CI to run unit tests

Changes

Runs unit test in CI

Related issues

Closes #22.

Any objects or something that I missed, @KemperNiklas?


 Updated all deps to latest versions, vendored them all so we have a snapshot of today's state. I used govendor to init and sync,  which is a sledgehammer approach and pulls in every last thing, which is what we probably want for this docker env. I made a single change to the source, in cmd/hologram-authorize/main.go to adapt for a recent change to gopass package. This builds and all tests - such as they are - pass under Go 1.7.1

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Steve Wight seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

Low hanging fruit, part deux... cleaned up header comments for packages so the 'Overview' section isn't filled with license info, added godoc generation target to buildscripts (generate_docs.sh) which serves up HTML godocs to localhost:6060 as well as static type analysis of source (so the source refs have live ref links, useful for navigation in the absence of a Go-sensitive editor env)

thanks for the observation, @copumpkin - i'm a recent convert to jetbrains IDE (from emacs) ... adding .idea/ to .gitignore now


ERROR: Error: Browserslist: caniuse-lite is outdated. Please run next command npm update

🐞 Bug report
Command (mark with an x)

ng build

[ ] new
[x ] build
[ x] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?

 Yes, the previous version in which this bug was not present was: ....
Description
 A clear and concise description of the problem...
When I run build universal, I am getting this error
"ERROR: Error: Browserslist: caniuse-lite is outdated. Please run next command npm update"
Here is the analysis I did, I think the issue is really coming with dependency @babel/preset-env": "7.7.6" which use "browserslist": "^4.6.0" which uses "caniuse-lite": "1.0.30000967". So it throws the above error. Currently my script logic is synchronous run commands. So it breaks with this message.
🔬 Minimal Reproduction

🔥 Exception or Error

"ERROR: Error: Browserslist: caniuse-lite is outdated.  Typically this is just a “warning”.

We encountered this today with ng test, no issue with building. We changed the caniuse-lite version in package-lock.json @angular-devkit/build-angular to 1.0.30001016 from 1.0.30000989.
The @angular-devkit/build-angular was on version 0.803.20 (0.803.21 is the latest).

NG build command is also complaining about this to me, should just require a package.json update right? Fast fix?  It is indeed just a warning, but it's somewhat surprising to my back end guys who dont know what it means.

@alan-agius4 Will this be a new npm version after fix happen?

And @alan-agius4  you are right, I have custom script to run some npm scripts combined

please the autoprefixer dependency to latest one.

@phani17c, a new version will be released in the coming days.

Thanks @alan-agius4  I am closing this issue.


Pitch Shift

🚀 Feature
Shift the pitch of a waveform by n_steps semitones.
Motivation
Common data augmentation used for training in ASR

Relates to #260

Addressed by #1629


Incorrect stub file

Describe the bug
the file lark-stubs/lark.pyi at Lark.__init__ does not contain the new cache option parameter. This leads to some ides thinking that cache is an invalid parameter (tested in pycharm).
To Reproduce
Just install pycharm, create a project with lark and create a lark object with the cache option. Pycharm should warn about unexpected arguments.
Missing cache optione here:
https://github.com/lark-parser/lark/blob/b5abf2d7afcd70af2be6c57aa454e532c8a99a0b/lark-stubs/lark.pyi#L36-L61

These files are not auto generates, because there is a lot of internal stuff that shouldn't normally be exposed. A simple PR would be appreciated.


Add automatically determined "Space around zones" negative padding option.

I think most people using negative "space around zones" values are using it to overlap Title Bars and Scroll Bars. If so, perhaps an option for automatic negative padding could be added. The rough idea is as follows:
Use GetSystemMetrics(SM_CXHSCROLL) for Top padding negative value to overlap horizontal scroll bars
Use GetSystemMetrics(SM_CYCAPTION) for Bottom padding negative value to overlap title bars
Use GetSystemMetrics(SM_CXVSCROLL) for Left padding negative value to overlap vertical scrollbars

Thank you for your feedback! Your idea is considered but currently is not planned for integration into the PowerToys.


Test user's Do Not Track preference before including Google Analytics

Jeremy wrote an interesting post about testing navigator.doNotTrack client-side before including the Google Analytics snippet.
That seems very sensible (I don't know much about the spec) and it seems like something that we of all people should be doing.
I would be interested in your thoughts.

Medium deals with this in an interesting way.
https://medium.com/policy/how-we-handle-do-not-track-requests-on-medium-f2b4b4fb7c5e#.njnuspz0k

Unfortunately I'm closing this issue as the DNT working group is closed, the status as reported on MDN is 'Obsolete', and Apple has removed support.


Watcher sometimes dies

Version
5.4.2
Describe the bug
Since upgrading from version 2 to 5 i have had the watcher crash on me several times per day with the following error:
[start:i18n  ] TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received null
[start:i18n  ]     at new NodeError (node:internal/errors:371:5)
[start:i18n  ]     at validateString (node:internal/validators:119:11)
[start:i18n  ]     at join (node:path:429:7)
[start:i18n  ]     at Number.onChange (file:///C:/dev/inex/node_modules/typesafe-i18n/cli/typesafe-i18n.mjs:14861:15)
[start:i18n  ]     at FSWatcher.emit (node:events:390:28)
[start:i18n  ]     at FSWatcher.emit (node:domain:475:12)
[start:i18n  ]     at FSEvent.FSWatcher._handle.onchange (node:internal/fs/watchers:212:12) {
[start:i18n  ]   code: 'ERR_INVALID_ARG_TYPE'
[start:i18n  ] }

Not really sure what is going on, restarting the watcher always works.
Reproduction
Reproduction is tricky, it seems to coincide with when i make changes to our frontend (same repository, different folder)
Logs
No response
Config
No response
Additional information
No response

Hi @mullwaden,
version 5.4.3 is the latest released version. Could you please check if the issue is still present there?
The stacktrace points me to this line:

Can you please confirm?
Since it happened a few times, yould you please manually add some console.log statements to the line before to see what exact entry is null?
Other questions:

do you use namespaces?
What operating System are you working with?
What Node.js version are you running?

It would be great if you can help me identify the bug since you are the first person who encountered the isssue.
You could also try going back to version 5.3.6. I have replaced the watcher package in version 5.4.0 and I think you trigger some edge-cases there.

Testing in 5.4.2

Can confirm it is the line above, the filename is null.
windows 10
Node 16

My guess would be that the filewatcher on windows somehow behaves differently than on mac/linux.
Not using any fancy stuff, my base setup looks like this:
import { i18n as initI18n } from "typesafe-i18n";

import type {
  Translation,
  TranslationFunctions,
  Formatters,
  Locales,
} from "./i18n-types";
import { initFormatters } from "./formatters";
import en from "./en";

export const getTranslationForLocale = () => en as Translation;

const i18n = initI18n<Locales, Translation, TranslationFunctions, Formatters>(
  { en: getTranslationForLocale() },
  { en: initFormatters("en") }
);

export default i18n.en;

will test 5.4.3 now

@mullwaden thanks for the information.
Yeah, probably some windows specific issue. I'll take a deeper look at this next week.
In the meantime, version 5.3.6 should work for you.

@mullwaden I could not reproduce the issue. I have reverted the change to use the previous library. Version 5.5.0 should work for you.
The reason why I switched to watchlist was a bundling issue with rollup. But it seems this is no longer the case. Probably the recent switch to esbuild fixed it.


Can't install Ubuntu: error 0x87E10BC6

Your Windows build number:  16299.192

What you're doing and what's happening:
I want to move from the legacy WSL to the new Windows Store version. So I ran lxrun /uninstall /full, rebooted, opened the Windows Store, found Ubuntu, and clicked install. When it says "Acquiring license", it then fails with error 0x87E10BC6. I've tried searching for this and I have no idea what it means. I already have the WSL feature enabled in "Turn Windows features on or off".

What's wrong / what should be happening instead:
I expected the install to succeed. I'm having to go back to the legacy system now. lxrun /install looks like it's still working.

same problem. somebody managed to solved this?

Seems like a Microsoft Store issue, please let us know if you're still seeing this.


Create date-range-rag-days-left.json

Q
A

Bug fix?
no

New sample?
yes

Related issues?
none

I loved the 'date-range-rag.json' example but needed to extend it to show the remaining days. I was having trouble getting a whole number for 'days left' (the number of days to the nearest days until the 'DueDate') so I embarked on producing a (pretty ugly) nested 'if' statement that will display the number of days until the DueDate, up to 100 days, after which it will just say 100+.
If there is a better way  (which I'm sure there is) of getting a whole number to represent days left (rather than the 15 decimal point number which is just too accurate for me!), then I'd love to hear about it but I spent some time on this and thought it was worth sharing with the original authors of 'date-range-rag.json'.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: JoeAyre sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @JoeAyre! Very cool take on the sample!
I added details to the README file and added a screenshot so that people will be able to find your work a little easier.
Normally PRs are handled within a week or 2 but I messed something up with my notifications. Very sorry for the delay!
Thanks so much for you contribution!


Minor documentation error

In application.rst

If any of your plugin need to retain user preferences from one application run to the next it should use the built-in preferences management system, which is straightforward. First your plugin should inherit from |HasPreferencesPlugin| and should call the parent class start method in its own

HasPreferencesPlugin should be HasPrefPlugin

Will fix in my next PR. Thanks


Not getting response from AVS

This is what I am getting on server side.

After running make demo command server is up and running but I am not getting any response for my request on uttering word Alexa.

Could you please help me in this.

Chrome has changed autoplay policy. This normally prevents annoying videos playing in the background before a user has interacted with the page.
See the top JavaScript warning. I'll make a PR over the next few days

May I know how long it will take to fix this issue.

@RAJ53AKKI it will take less than an hour of dev effort. feel free to make the change yourself if time is of the essence. more info

ohk thanks @richtier


Make manifest address parsing error more descriptive (#75)_37

Motivation
Make manifest address parsing error more descriptive
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI/CD tests are covered.

/canary

:sunny: Canary successful

/land


Folder icon for Seti icon theme

VSCode Version: 1.22.2
OS Version: macOS

My suggestion is to add folder icons for Seti icon theme and it will be completely done because currently, I need to download another icon extension even if the default one can be used, but the problem is, it doesn't contain folder icon.

If you are using Seti icon extension, please file issue against them, thanks !
Link https://github.com/hellopao/vscode-seti-icons

@rebornix Seems it's out-dated, the last commit was 2 years ago, seems you need to change Seti to someone else...


iOS - Track expense - Swiping to right on invite page does not return to workspace chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.65-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: https://github.com/Expensify/App/pull/40740
Issue reported by: Applause - Internal Team
Action Performed:

Launch New Expensify app.
Go to self DM.
Go to + > Track expense.
Create a track scan expense.
From the whisper, select Share it with my accountant.
Select a workspace > Click Submit.
Tap back button on the Invite member RHP.
Note that it returns to the workspace chat.
Repeat Step 3 to 6.
Instead of using the back button, swipe to right (iOS) to dismiss the invite page.

Expected Result:
App will return to workspace chat.
Actual Result:
App returns to self DM.
Workaround:
n/a
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/a984c5dc-5771-420a-902c-d7d2bcdd05be
View all open jobs on GitHub

We think that this bug might be related to #vip-vsb

Seems like this is coming from https://github.com/Expensify/App/pull/40740 that did not fix the flow completely @bernhardoj can you please follow up with fix for this? could not assign you without you commenting here. Thanks!

Yeah this was an issue from the original PR that implemented actionable whispers and it was decided to fix as a follow-up polish.

@jjcoffee So, should we apply this?

@bernhardoj Yes I believe so. Would you mind reposting the video here as a proposal? Just to keep things tidy.
@thienlnam can you add the Bug label and assign @bernhardoj? Thanks :pray:
:ribbon::eyes::ribbon: C+ reviewed

Here is the video:
https://github.com/Expensify/App/assets/50919443/7e522696-4099-4c4b-b834-0ee8f9dbf6d1

PR is ready
cc: @jjcoffee

The PR that introduced the bug has been identified. Link to the PR: N/A - this is a polish issue
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open a self DM
Track a new expense
Wait for the concierge message and choose Share with my accountant
Select any workspace and confirm
Verify you are navigated to the invite page
Web/Desktop: Verify the chat behind the invite page is the workspace chat
Android/iOS/mWeb: Go back using the swipe gesture or hardware back button and verify the workspace chat is shown

Do we agree 👍 or 👎

Payouts due:

[ ] Contributor: $250 @bernhardoj
[ ] Contributor+: $250 @jjcoffee

Upwork job is here.

@kadiealexander Offer accepted, thanks! :pray:


[BUG]: extensionsFilters: ['postgis'] still trying to delete spatial_ref_sys

What version of drizzle-orm are you using?
0.31.0
What version of drizzle-kit are you using?
0.22.1
Describe the Bug
I have the following drizzle.config keys:
dialect: 'postgresql',
extensionsFilters: ['postgis']

But when I run drizzle-kit push I get the following:
Warning  Found data-loss statements:
· You're about to delete spatial_ref_sys table with 8500 items
Expected behavior
Is there a config key to specify tables to always ignore?
Environment & setup
No response

fixing

Should be fixed in<EMAIL_ADDRESS>

What version of drizzle-orm are you using?
0.36.4
What version of drizzle-kit are you using?
0.28.1
Hi @AndriiSherman , I think the problem still persists. Please see the screenshots:


[Bug] [Docker] error: The argument '--postgres-url ' cannot be used with '--config '

Summary
Running docker-compose up on my local machine throws the following error from the graph-node:
graph-node_1  | error: The argument '--postgres-url <URL>' cannot be used with '--config <config>'
The graph-node_1 container exits.
Reproduction
Following these instructions: https://thegraph.com/docs/quick-start#2.-run-a-local-graph-node
git clone https://github.com/graphprotocol/graph-node/
cd graph-node/docker

Changing the ethereum environment var to infura mainnet

ethereum: 'mainnet:https://mainnet.infura.io/v3/MY_NOT_SO_SECRET_PROJECT_ID'

docker-compose up

Expected behaviour
The graph-node container successfully boots and is accessible from the outside.
Further information

MacOS Catalina 10.15.7 (19H114)
Docker Desktop Version 3.1.0
Docker Engine Version 20.10.2
Docker Compose Version 1.27.4

I was able to fix it simply by changing the docker-compose.yml file to not point to the latest image, but to the last version:
version: '3'
services:
  graph-node:
    # Instead of image: graphprotocol/graph-node
    image: graphprotocol/graph-node:v0.22.0
    ports:
      - '8000:8000'
      - '8001:8001'
      - '8020:8020'
      - '8030:8030'
      - '8040:8040'
    depends_on:
      - ipfs
      - postgres
    environment:
      postgres_host: postgres
      postgres_user: graph-node
      postgres_pass: let-me-in
      postgres_db: graph-node
      ipfs: 'ipfs:5001'
      ethereum: 'mainnet:https://mainnet.infura.io/v3/MY_NOT_SO_SECRET_PROJECT_ID'
      RUST_LOG: info
  ipfs:
    image: ipfs/go-ipfs:v0.4.23
    ports:
      - '5001:5001'
    volumes:
      - ./data/ipfs:/data/ipfs
  postgres:
    image: postgres
    ports:
      - '5432:5432'
    command: ["postgres", "-cshared_preload_libraries=pg_stat_statements"]
    environment:
      POSTGRES_USER: graph-node
      POSTGRES_PASSWORD: let-me-in
      POSTGRES_DB: graph-node
    volumes:
      - ./data/postgres:/var/lib/postgresql/data

I was also able to reproduce the behaviour by building the graph-node docker image locally on the master branch.

Thanks for the report. @lutter did you change something with the CLI recently that would cause this?

This might be unintended fallout from #2247 - I'll look into it

Do you have GRAPH_NODE_CONFIG set in your environment? It should not be.

I still have this issue. It seems to me that something changed from v0.22.0 to now. I'll try to narrow it down.


fix styling regressions (snippets, alerts, anchor links)

Related issue

Proposed Changes
Fixes regressions of Docsy theme update.

Checklist

[x] I have read the contributing guidelines.
[x] I have inspected the website preview for accuracy.
[x] I have signed off my issue.

Hi @chipzoller, please check. Will resign with email.

Hey thanks for this, @onweru. It looks like the code blocks have the outline removed but still not seeing anchor links appear in the preview.

@chipzoller, I have restored the anchor links. They were by docsy as part of v.0.9.0 release via this PR

Ah ok, thanks! I'll have a look at this soon.

Thanks much!


K3s regularly spikes in cpu usage and crashes in a loop

Environmental Info:
K3s Version:
k3s version v1.24.3+k3s1 (990ba0e8)
go version go1.18.1
Node(s) CPU architecture, OS, and Version:
Almalinux 8.6, x86_64 8 Cores
Cluster Configuration:
1 Server in HA ready configuration
Describe the bug:
k3s regularly spikes into 700-800% cpu usage until it crashes because the leaderelection is lost (to itself). It then reboots and repeats this loop.
This happens about every 2-3 days.
Additional context / logs:
Manually stopping k3s with systemctl stop k3s and restarting it, fixes it temporarily.
According to the logs etcd apply takes up to 6 seconds sometimes.
Sep 02 15:13:22 miku k3s[2694852]: I0902 15:13:22.250924 2694852 trace.go:205] Trace[1434124888]: "List(recursive=true) etcd3" key:/events,resourceVersion:0,resourceVersionMatch:,limit:500,continue: (02-Sep-2022 15:13:14.773) (total time: 7477ms):
Sep 02 15:13:22 miku k3s[2694852]: Trace[1434124888]: [7.477022009s] [7.477022009s] END

Sep 02 15:13:22 miku k3s[2694852]: E0902 15:13:22.349266 2694852 leaderelection.go:330] error retrieving resource lock kube-system/kube-controller-manager: Get "https://<IP_ADDRESS>:6444/apis/coordination.k8s.io/v1/namespaces/kube-system/leases/kube-controller-manager?timeout=5s": context deadline exceeded
Sep 02 15:13:22 miku k3s[2694852]: I0902 15:13:22.349361 2694852 leaderelection.go:283] failed to renew lease kube-system/kube-controller-manager: timed out waiting for the condition
Sep 02 15:13:22 miku k3s[2694852]: E0902 15:13:22.349426 2694852 controllermanager.go:284] "leaderelection lost"

That usually indicates that the storage isn't sufficient to keep up with the IO requirements of the datastore. By "HA ready configuration", I assume you mean a single-node etcd cluster? Etcd has much higher IO requirements than sqlite, and really won't work well on anything except for SSD. What sort of disk are you running k3s on? Are you using the same physical media for the datastore, your workload, and the containerd image store?

The thing is that etcd provides native snapshotting and this is a server we might want to expand by worker nodes in the future.
The underlying storage are NVME ssds that should have sufficient headroom for fast access. The same physical medium is used for datastore, workload and containerd images as this is a VM that only has a single volume provisioned.
What's surprising to me is that during initial startup this isn't a problem at all, but only seems to become a problem once some time has passed. Is there any way to increase the resilience to these effects?

The underlying storage are NVME ssds that should have sufficient headroom for fast access. The same physical medium is used for datastore, workload and containerd images as this is a VM that only has a single volume provisioned.

Have you profiled the disk for latency and throughput? Keep in mind that etcd makes a blocking fsync call for every write operation to the datastore. If your workload is performing a lot of write operations at the same time, all of those will need to be flushed to disk before etcd can commit the write. You may not be exceeding the rated iops, but simply running into problems with bulk IO blocking performance-critical cluster operations.

What's surprising to me is that during initial startup this isn't a problem at all, but only seems to become a problem once some time has passed.

Is this perhaps occurring during some background operation, such as a scheduled TRIM operation, or some IO-intensive processing job on the part of the workload?

The underlying storage are NVME ssds that should have sufficient headroom for fast access. The same physical medium is used for datastore, workload and containerd images as this is a VM that only has a single volume provisioned.

Have you profiled the disk for latency and throughput? Keep in mind that etcd makes a blocking fsync call for every write operation to the datastore. If your workload is performing a lot of write operations at the same time, all of those will need to be flushed to disk before etcd can commit the write. You may not be exceeding the rated iops, but simply running into problems with bulk IO blocking performance-critical cluster operations.

Yes. Throughput and latency should be more than sufficient.

What's surprising to me is that during initial startup this isn't a problem at all, but only seems to become a problem once some time has passed.

Is this perhaps occurring during some background operation, such as a scheduled TRIM operation, or some IO-intensive processing job on the part of the workload?

No, it happens seemingly at random. Manually running trim operations doesn't trigger this, writing a lot of data doesn't trigger this. I honestly don't know what triggers this. iostat while it happens shows the storage not particularly under pressure, CPU usage at full all taken by a multitude of k3s processes.

CPU usage at full all taken by a multitude of k3s processes.

Can you clarify what you mean by that? There should normally only be 1 k3s process, occasionally 2 if k3s is started with the --log flag and has to re-exec itself to redirect output to a log file. Are you actually seeing multiple k3s processes, or just multiple OS threads?

Multiple OS Threads I'd say. I've attached a view of htop and iostat of the problem occuring. As I said iostat is rather unproblematic. IoWait is low, but for some reason k3s uses a ton of cpu and times out etcd requests:

If you're using iostat, can you look at the f_await and aqu-sz fields? These are more likely to be what's causing etcd problems than just the base IO rate.
https://manpages.debian.org/testing/sysstat/iostat.1.en.html#f_await

Will do the next time this problem shows up. Since this is a production server restoring service had priority over waiting to debug this.

So aqu-sz is really low, f_await isn't tracked, this might be because the underlying disk is a virtual disk.
What I've also noticed is a spike from iptables-save -t filter that saves current filter rules, I think that's part of the startup/shutdown of k3s.
Just to give you an idea of the thread sprawl that k3s seems to produce in this situation:

The machine basically becomes unusable at this point. IO latency does also spike at this point (if I run a benchmark like bonnie++ at the same time) however its hard to tell whether that is simply because of the high load on the machine. Shutting down k3s returns it to normal after which k3s can be restarted and normal operation resumes.
I won't rule out that this is an issue that crops up due to the underlying machine. What I find weird is that it takes quite some time to happen the first time, even with the full load of cluster startup directly applied at the beginning (which I assume is the point of highest load for most use cases). There seems to be some sort of trigger that puts k3s in this state where a recovery takes a:
k3s-killall.sh
systemctl start k3s

Which then leads to a standard startup that works fine.
I wonder why the cpu load spikes this way however, it seems there is work being done since the processes aren't IO blocked. I wonder what work is being done however.

I haven't seen any updates on this in a bit; were you able to identify a root cause of the CPU load?

@brandond Unfortunately not. The issue persists and crops up every once in a while. I can't rule out that it has something to do with disk io being too slow, however we've switched VM hosts etc. It might be related to other VMs running on the same host. Since we don't control the host directly its hard to tell whether the problems coincide with high IO load on the host system.
However the fact that this seems to crop up semi-regularly and the only way to make it stop is to reboot the machine (after which the problem goes away) and seeing how a simple restart of k3s without reboot does nothing to alleviate the issue it might be related to some sort of failure in the IO system that gets cleared.
Its still extremely weird and I'd love to go a second round on this if you have any further ideas on what to test. Especially since the very high CPU load is a bit weird. It basically drives the whole system into the ground because k3s takes up so much of the resources that the existing containers start to stall. I get the feeling that since k3s is supposed to run on even low end systems this is not something that should be happening on this type of host even using the etcd backend.

Converting this to a discussion as (at this point), it doesn't seem to be directly related to a k3s bug.


Add missing trailing zeros

Sorry for another senseless PR, but figured we might as well finish what we started on #857 and add in the remaining missing zeros to make everything uniform. 😄

Thanks!


Remove env section from samples

This change removes the Env section from each of the sample files. This reduces the number of parameters that we need to maintain in these sample files moving forward.
Depends-On: https://github.com/openstack-k8s-operators/ci-framework/pull/944

The GitHub check ran without the depends-on. Rechecking.

recheck

Appears it's still not running with the ci-framework depends-on:
2023-12-14 00:44:02.875560 | controller | Thursday 14 December 2023 00:44:02 -0500 (0:00:01.031) 0:15:29.725 ***** 2023-12-14 00:44:03.191870 | controller | fatal: [localhost]: FAILED! => {"changed": false, "details": "error: add operation does not apply: doc is missing path: \"/spec/env/0\": missing value\n", "error": "add operation does not apply: doc is missing path: \"/spec/env/0\": missing value", "kustomization": {"apiVersion": "kustomize.config.k8s.io/v1beta1", "kind": "Kustomization", "namespace": "openstack", "patches": [{"patch": "- op: replace\n path: /spec/preProvisioned\n value: true\n- op: replace\n path: /spec/nodes/edpm-compute-0/ansible/ansibleHost\n value: <IP_ADDRESS>\n- op: replace\n path: /spec/nodes/edpm-compute-0/networks\n value:\n - name: CtlPlane\n subnetName: subnet1\n defaultRoute: true\n fixedIP: <IP_ADDRESS>\n - name: InternalApi\n subnetName: subnet1\n - name: Storage\n subnetName: subnet1\n - name: Tenant\n subnetName: subnet1\n- op: add\n path: /spec/services/0\n value: repo-setup\n- op: replace\n path: /spec/nodeTemplate/ansible/ansibleVars/timesync_ntp_servers\n value:\n - {hostname: pool.ntp.org}\n- op: replace\n path: /spec/nodeTemplate/ansible/ansibleVars/neutron_public_interface_name\n value: eth0\n- op: replace\n path: /spec/nodeTemplate/ansible/ansibleVars/registry_url\n value: quay.io/podified-antelope-centos9\n- op: replace\n path: /spec/nodeTemplate/ansible/ansibleVars/image_prefix\n value: openstack\n- op: replace\n path: /spec/nodeTemplate/ansible/ansibleVars/image_tag\n value: 1401eccf4b1600f1bdacc701a3fe1d9e\n- op: replace\n path: /spec/nodeTemplate/ansible/ansibleVars/edpm_sshd_allowed_ranges\n value: ['<IP_ADDRESS>/0']\n- op: add\n path: /spec/env/0\n value: {\"name\": \"ANSIBLE_CALLBACKS_ENABLED\", \"value\": \"profile_tasks\"}\n- op: replace\n path: /spec/nodeTemplate/ansibleSSHPrivateKeySecret\n value: dataplane-ansible-ssh-private-key-secret\n- op: replace\n path: /spec/nodeTemplate/ansible/ansibleUser\n value: cloud-admin", "target": {"kind": "OpenStackDataPlaneNodeSet"}}], "resources": ["cifmw-kustomization-result.yaml"]}, "kustomization_path": "/home/zuul/ci-framework-data/artifacts/manifests/openstack/dataplane/cr/cifmw-kustomize-workspace/kustomization.yaml"}

Hmm, I thought the first time might have failed because I added the Depends-On after it was already running.
We can probably do it the other way around anyway, since this one seems to be passing:
https://github.com/openstack-k8s-operators/ci-framework/pull/944
So we can merge that one, then recheck this one.

recheck

@bshephar based on this https://github.com/openstack-k8s-operators/dataplane-operator/pull/577#issuecomment-1855262316 and https://logserver.rdoproject.org/77/577/36e0e44517dc90f115ef7cce430cad0d1799e2a0/github-check/podified-multinode-edpm-deployment-crc/ebcf5a4/controller/ci-framework-data/artifacts/manifests/kustomizations/dataplane/99-kustomization.yaml ci-framework depends changes are applied there. There might be something else going on there.
  - op: add
      path: /spec/env
      value: {}

@bshephar based on this #577 (comment) and https://logserver.rdoproject.org/77/577/36e0e44517dc90f115ef7cce430cad0d1799e2a0/github-check/podified-multinode-edpm-deployment-crc/ebcf5a4/controller/ci-framework-data/artifacts/manifests/kustomizations/dataplane/99-kustomization.yaml ci-framework depends changes are applied there. There might be something else going on there.
  - op: add
      path: /spec/env
      value: {}

Yeah, looks like it's coming from install_yamls. I'll push a PR there too.

recheck

recheck

/test dataplane-operator-build-deploy-kuttl

/test dataplane-operator-build-deploy-kuttl

/test dataplane-operator-build-deploy-kuttl

/test dataplane-operator-build-deploy-kuttl


DNM: test the ci

this is done just to test the ci, not meant for merging...
to see if ci failures from other PRs are flakes or real ....
see: https://jenkins-samba.apps.ocp.cloud.ci.centos.org/job/samba_sink-mini-k8s-1.26-clustered/108/ from PR #298

Closing as required changes were already included as part of https://github.com/samba-in-kubernetes/samba-operator/pull/298.


Do not recreate config if deleted

Preventing recreation of config in case it was deleted in order to fix ECOPROJECT-1277

/override ci/prow/4.12-openshift-e2e


Spinup

The pip install command prompted a notation that setuptools is deprecated and needed to be removed from future builds. The project is archived and unmanaged. However, running the command in this notation moved me past this step, which was a priority. The omission of redownloading the dependencies may have helped. I need to look into this a bit more as I have not been looking at python in recent times :-)

I didn't meant to push this here. Closed it, as its just a notation for now in my branch!


Testing for @mentions in comments

Testing for @mentions in comments involves validating autocomplete functionality, proper storage, and retrieval of mentions in the database. Ensure error handling works for invalid mentions and verify UI displays mentioned photos correctly with thumbnails and links.

The @mentions feature has been thoroughly tested, including autocomplete functionality, database storage/retrieval, and UI display with thumbnails and links. Error handling for invalid mentions works as expected. Marking this issue as resolved.

The @mentions feature is well-tested and works as expected. Testing edge cases like large mention lists and simultaneous mentions would further strengthen the implementation. Once those are covered, we can finalize the feature.


animation for multiple items

I need your help. To apply animation to multiple elements with a single class of "my-button"? Now this only works for a single button.
Replacement querySelector on querySelectorAll not solve the problem, the script becomes not working
Demo: http://codepen.io/ey_intuitive/pen/NxQdyY
Thank you!

@NetGon hey, sorry for the delay. In the mojs version you are using you need to add the effect to each button, please refer to this pen. In the new version which I will release very soon, you can reuse the same effect for every button - so you will have to initialise it once.
Hope it helps,
Cheers!


Feat: Add gsoc projects from assets/projects/gsoc_projects in gsoc program screen

Describe the feature
Add gsoc projects
Add ScreenShots
Na
Record

[X] I agree to follow this project's Code of Conduct
[ ] I'm a GSSOC'24 contributor
[ ] I want to work on this issue

I would love to work on this but how exactly would you like to show these projects? we have organization listed on that page. should we replace org with project?

I would love to work on this but how exactly would you like to show these projects? we have organization listed on that page. should we replace org with project?

@rishabh7923 I want both the organization list and the projects to be displayed. I’ve added the projects in the assets/projects/gsoc_projects JSON file, and those should be listed on the GSOC page. We’ll need to work on the UI since both the organizations and projects are important for GSOC. If any issues come up, feel free to ask 👍🏻

how about i make 2 tabs inside the page, one that shows org and one that shows projects?

how about i make 2 tabs inside the page, one that shows org and one that shows projects?

The main GSOC website has a button that allows users to view projects, so you could add a similar button here alongside the GSOC organization list. This button should navigate directly to the GSOC projects page, making it easier for users to access the projects

ok cool


fix: add value conversion to postgres adapter

resolves #777
Existing behavior has been kept (although it's not clear if this is necessary) used the same approach as in SQL Server.
Have tested locally and works. Unsure of testing strategy however, so no tests in the codebase (the tests don't run locally for me).

Just passing by, but is the meat of the change the following:

propertyValue = converter.ConvertToProvider.Invoke(propertyValue);

Essentially allowing any EF value converter to be used for the value?

Yes, that's the only functional change. This is what the SQL server adapter
does and what appears to be missing here.
On Thu, Apr 7, 2022, 00:04 Douglas Gaskell @.***> wrote:

Just passing by, but is the meat of the change the following:
propertyValue = converter.ConvertToProvider.Invoke(propertyValue);
Essentially allowing any EF value converter to be used for the value?
—
Reply to this email directly, view it on GitHub
https://github.com/borisdj/EFCore.BulkExtensions/pull/792#issuecomment-1090899253,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVOUDMRS6BH5W2EZJ634QPTVDYKBHANCNFSM5SXQI4PQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add HumairaTauqeer's file

I am not sure if I am doing this right. Please guide @oconnor97 @Phillip-Generation @ida4444 @awilson80

Sorry I just saw all this Humaira! This learning curve isn't easy, is it? Good job showing persistence!

Sorry I just saw all this Humaira! This learning curve isn't easy, is it? Good job showing persistence!

thats ok Victoria. It was little hard, but I am glad I was able to do that. Thank you!


Updated ship Workflow concurrent group

Current dependencies on/for this PR:

main

PR #260   👈

This comment was auto-generated by Graphite.


Not working minimum window resize  in windows OS

setWindowMinSize not working in windows OS.
import 'dart:io';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:window_size/window_size.dart';

Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();
  if (!kIsWeb && (Platform.isWindows || Platform.isLinux || Platform.isMacOS)) {
    setWindowTitle('Flutter Demo');
    setWindowMinSize(const Size(500, 500));
  }
  runApp(SampleBrowser());
}

Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel beta, 2.0.1, on Microsoft Windows [Version 10.0.18363.1440], locale en-IN)
[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Professional 2019 16.8.3)
[√] Android Studio (version 3.3)
[√] VS Code (version 1.54.3)
[√] Connected device (2 available)

Hi @Nandhini-Ravichandran
For issues related to window_size, please file a new issue on https://github.com/google/flutter-desktop-embedding/issues
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Blocked by CSP Header

Hi,
When I set the Content-Security-Policy Header to default-src 'self';, the Lines aren't rendered correctly anymore, because some Inline-Styles are blocked by the CSP.
I guess that the issue is caused by the <style>...</style> in the leader-line-defs.
The solution would be to either set all stylings with JavaScript or move the stylings into a separate CSS file.
Setting the CSP to unsafe-inline is no option for me.

I temporary fixed this issue for me, by forking your project to github.com/Codehardt/leader-line. I then patched the Gruntfile.js to create a separate leader-line.min.css file instead.
The newly bundled version has been published on npm www.npmjs.com/package/@codehardt/leader-line.
I am now able to use your package by importing it as follows:
import LeaderLine from "@codehardt/leader-line"
import<EMAIL_ADDRESS>
FYI: I am using your package in a React project so I also had to add
if(module&&module.exports){module.exports=LeaderLine;}

to the leader-line.min.js before publishing it on npm.
Kind regards,
Marcel

Yes, you seem to have missed the purpose for using the library and the CSP maybe.
There is a trade-off between flexibility and security. Then, a few mechanisms such as style-src are provided for cases that absolutely have to use something that is blocked by CSP.
Therefore, if you think that those workarounds have a problem, you should not use those and the library.
You can draw lines without the library if you know SVG because the LeaderLine is a simple library to generate a SVG image conveniently, and that drawing is easy for almost cases. That is, the library is not required for you.
In other words, you should not use those libraries that don't conform your security policy.

Then, a few mechanisms such as style-src are provided for cases that absolutely have to use something that is blocked by CSP.

As I already mentioned, the above workaround with the patched Gruntfile.js and a manual import of the automatically generated leader-line.min.css is working for the most strict CSP header. The CSP header isn't made to block any dynamically set stylings. It is made to just disable stylings set with <style>... or with e.g. <div style="...">. Changing the style with
var el = document.getElementById(...)
el.style.<cssprop> = <cssval>

is still fine for CSP because this is done by static JavaScript files.
The only problem with your package (that is by the way still very awesome and useful) is the CSS part in the <[DATA section.
Most JavaScript packages that contain JS mixed with some stylings provide any way to fix the CSP issue and it doesn't require a complete refactor.
Take Fontawesome as an example, a toolkit to draw hundreds of different icons in your HTML page with JS and dynamically generated SVG, similar to your package. When I embedded that package, I also got issues with the CSP, but Fontawesome has a simple workaround that you could implement, too:
To use Fontawesome with CSP, you can tell Fontawesome to not embed CSS unsafely, by setting the option Fontawesome.config.autoAddCss = false, similar to your LeaderLine.positionByWindowResize option. The css then has to be imported manually with <link rel="stylesheet" href="<path>/<to>/fontawesome.min.css"> Let's image you implement a LeaderLine.autoAddCss = false option. Nothing would change for users that use your package.  But for those who require a strict CSP header, they can then change LeaderLine.autoAddCss to false and import your leader-line.min.css manually.
See fontawesome.com/docs/web/dig-deeper/security for more information.

You can draw lines without the library if you know SVG because the LeaderLine is a simple library to generate a SVG image conveniently, and that drawing is easy for almost cases. That is, the library is not required for you.
In other words, you should not use those libraries that don't conform your security policy.

 I do not build a static webpage that renders svg arrows that do not change anymore. I render a complex network graph with your package that connects lot of different nodes that can be added and removed manually, some have to be animated, some should be rendered yellow due to a "broken network connection". Of cause this could be done by simply generating svg for myself but this would take me at least as long as it takes you to implement this package. So I don't wanna miss your package.
But if you don't want to patch this CSP issue, I'm totally fine with it. Then I will stay on my fork and regularly check for updates on your package. But your package is used by a lot of users and I don't understand why I am the first one who requires that strict CSP? So feel free to close this issue if you are fine with that.

Sorry, my English is poor. Your words are difficult for me.
However, that might help something. Then you will understand CSP. Thank you for the information. :smile:

This unrequired issue is closed.


added reverse lines

#1 Added reverse lines could you please review

This looks good.  Let's make this work the same as sort lines, so that it will work with one selection or multiple selections.
If one selection, it should do exactly what it does now.
With multiple selections, we then should call linesFromRanges instead of linesFromRange
The reverseLines function in common should only reverse the lines and replace those lines.
Place the logic for handling one or more selections in Transforms.ts


fix: expose asset-service utils in dist

Description
This exposes the utils module of asset-service following 94f74495b.
It is currently not exposed in the built package and thus, its consumption produces a runtime error in:
https://github.com/shapeshift/lib/blob/ef77d1dfcbc969c390320dea38e9fa4c52513c17/packages/asset-service/src/service/AssetService.ts#L5
Issue
Relates to https://github.com/shapeshift/lib/issues/444
Relates to https://github.com/shapeshift/lib/issues/556

I am confused by this PR. utils.ts is being built and we are importing directly from that file in AssetService.ts. Exporting it from index.js would certainly expose it to the web client if that is the intention, but I don't see it being used in there.

I am confused by this PR. utils.ts is being built and we are importing directly from that file in AssetService.ts. Exporting it from index.js would certainly expose it to the web client if that is the intention, but I don't see it being used in there.

Yeah, the intent can get quite confusing.
Basically, utils.ts is missing from the dist, and as such, when the dist version of asset-service tries to access it (in e.g web), this is the error we're getting:
ERROR in<EMAIL_ADDRESS>18:16-35

Module not found: Error: Can't resolve '../utils' in '/Users/alexandre.gomes/Sites/shapeshiftWeb/node_modules/@shapeshiftoss/asset-service/dist/service'

The fact that asset-service builds without problems doesn't mean that the build will actually work: if the file isn't available to consume for the dist version, the package won't work when actually installed.

I am confused by this PR. utils.ts is being built and we are importing directly from that file in AssetService.ts. Exporting it from index.js would certainly expose it to the web client if that is the intention, but I don't see it being used in there.

Yeah, the intent can get quite confusing. Basically, utils.ts is missing from the dist, and as such, when the dist version of asset-service tries to access it (in e.g web), this is the error we're getting:
ERROR in<EMAIL_ADDRESS>18:16-35

Module not found: Error: Can't resolve '../utils' in '/Users/alexandre.gomes/Sites/shapeshiftWeb/node_modules/@shapeshiftoss/asset-service/dist/service'

The fact that asset-service builds without problems doesn't mean that the build will actually work: if the file isn't available to consume for the dist version, the package won't work when actually installed.

Ok, looking more closely the issue is the package.json if you take a look at the files key, you can see we are choosing to only publish files from service and index.*. I think a better fix would be to either update index.* to *.js, or we could always leverage an .npmignore to ignore the generateAssetData directory which is the intention of the strict files setting I imagine.


Check grammar parameters again

Much of the grammar parametrization here was done by aping the current spec. But https://github.com/tc39/ecma262/pull/775 has found a few issues with the current spec. (/cc @anba)

I went through all the changes in that PR and none of them apply here. The grammar changes prevented await from passing through in generators and yield from passing through in async functions, but we need both to pass through for async generators. And the rest were largely changes we cover in our "Miscellaneous Patches" section already.


Staggering JOS animation

Yes, you know when you are tired of manually adding repetitive animation to elements under a parent element.
It would be nice to add staggering animation, such that we can configure the animation we want and other settings such as
data-jos_stagger :
Animation
delay
duration
direction
anchor
etc

Added in v0.9.2
there is entire thread dedicated to this feature now


Add UserData properties for VM and VMSS for stable 2021-03-01

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
Late March
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
End of March
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x ] I commit to follow the Breaking Change Policy of "no breaking changes"
[x ] I have reviewed the documentation for the workflow.
[x ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@roipmsft , please investigate the CI failures on this PR.

You can ignore the PurchasePlan error.

@roipmsft , please investigate the CI failures on this PR.

Thank you for the comments, Adam. I have resolved the comments on the PR

to do: Get aka.ms link from PM exlaining UserData and add to documentation

@roipmsft , where is the .Net SDK PR for this change?

/azp run

hi @ArcturusZhang could you pls confirm impact to GO SDK? thanks
hi @msyyc  could you pls confirm impact to Python SDK? thanks

hi @ArcturusZhang could you pls confirm impact to GO SDK? thanks
hi @msyyc could you pls confirm impact to Python SDK? thanks

hi @ArcturusZhang could you pls confirm impact to GO SDK? thanks
hi @msyyc could you pls confirm impact to Python SDK? thanks

/azp run

hi @roipmsft , SDK generation failed with below error, could you pls have fix it? thanks
[AUTOREST] FATAL: System.InvalidOperationException: Swagger document contains two or more x-ms-enum extensions with the same name 'InstanceViewTypes' and different values: instanceView,userData vs. instanceView

/azp run


DocumentTitle is missing in SwaggerUIOptions

Hi,
I've got Swashbuckle.AspNetCore 1.0.0 nuget package installed in my Asp.Net Core project.
But when I try to add DocumentTitle() in UseSwaggerUI middleware it seems to be not there.
// Enable middleware to serve swagger-ui (HTML, JS, CSS etc.), specifying the Swagger JSON endpoint.
            app.UseSwaggerUI(c =>
            {
                c.DocumentTitle("Custom API - Swagger UI");
            });

However I noticed it's there in github repository: https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/98f64b09032c2949e669c319b5cf09ff0f4e2340/test/WebSites/CustomUIConfig/Startup.cs
Am I missing something?
Thanks in advance.

I have same issue, can't access that method like it is not existing.

The property is missing fromt the SwaggerUIOptions class

Experiencing the same issue here.

Looks like it was merged in 98f64b09032c2949e669c319b5cf09ff0f4e2340 a little over a month ago, just not on nuget yet. Any ETA?

This is probably my #1 missing feature since I first encountered Swagger. Still waiting...

Any update on this issue??

seems the field is a fake one!

This does seem to be missing, seems like it should have or has been there considering the docs?

I have done this as a work around with javascript (updates doc title and sets favicon)
app.UseSwaggerUI(options =>
            {
                options.InjectOnCompleteJavaScript("/js/swagger.js");
            });

(function () {
    $(function () {
        // Update Document Title
        document.title = "Api Documentation";

        // Replace Icon
        var link = document.querySelector("link[rel*='icon']") || document.createElement("link");
        link.type = "image/x-icon";
        link.rel = "shortcut icon";
        link.href = "/favicon.ico";
        document.getElementsByTagName("head")[0].appendChild(link);
    });
})();

Should be resolved as of v1.1.0

InjectOnCompleteJavaScript option is also removed in the release of 2.3.0 AspNetCore release

See https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/master/README.md#apply-swagger-ui-parameters


Task 1786 s3 public access

Task linked: TASK-1786 [BUG] Even if the bucket and file are public, the access and secret key need to be provided


[SPARK-39310][PS] Change requires_same_anchor to check_same_anchor

What changes were proposed in this pull request?
Change requires_same_anchor to check_same_anchor for _update_internal_frame func
Why are the changes needed?
There were some discussion in https://github.com/apache/spark/pull/36353#discussion_r882216133 , this parameter is a flag for whether checking the same anchor.
Consider it's a parameter of internal use function, it can be renamed safely.
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI passed

cc @itholic

Merged to master.

Sorry, I couldn't been focusing on review for some personal health issue.
Thanks for addressing this, @Yikun ! 👍


Don't force record type implementation in Binary Search Tree exercise

This will be solved as part of #146


cant "open Tokaido.xcworkspace"

Hi i followed all instructions from the README:

When first cloning this repo, be sure to run the following:
gem install cocoapods
pod install
Scripts/package.sh
open Tokaido.xcworkspace

You should then be able to build and run Tokaido in Xcode.

I was able to do all of these except the last one that is open Tokaido.xcworkspace. The only thing in the repo folder i found close was Toakaido.xcodeproj.
I am new to dev and don't really understand what this is supposed to do. Everything else looks to be running fine and I even created a test myapp and got up my server and local:3000 which was successful. I was also able to manage it from the Toakaido manage apps feature that is GUI and on the terminal.
I also ran a rake -T and everything went good.
Also after i ran Scripts/package,sh it said that I should run make test.
However I got this when I tried it:
Davids-MacBook-Pro:tokaidoapp David$ make test make: *** No rule to make targettest'.  Stop.`
Could somebody help me with this?

Sorry about that.
Please download again the repo and try it out in development mode.


⚠ Samsung has degraded performance

In 8205b58, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1940 ms

Resolved: Samsung performance has improved in cfd513d.


[Bug] Spellcasting Matching not Working

As title, spellcasting bonus isn't applying over to eidelon

When eidolon post spell dc is get from summoner.
Maybe setting is off?

Hmmm, I'll check again and report back


Support hx-swap modifiers in a type-safe way

After some research, it turns out that HTMX supports modifier attributes in hx-swap. E.g. swap:1s, settle:1s and scroll:bottom. https://htmx.org/attributes/hx-swap/
There's a lot of possible modifier attributes, but most of them can be represented by a finite amount of values. I'd like to see an implementation that is type-safe as much as possible.
Example possible implementations:
htmx.NewResponse().
  Reswap(htmx.SwapWithAttr(htmx.SwapOuterHTML, htmx.ModFocusScroll(true))
// [Output header]
// HX-Reswap: outerHTML focus-scroll:true

htmx.NewResponse().
  Reswap(htmx.SwapWithAttr(htmx.SwapBeforeEnd, htmx.ModScrollBottom())
// [Output header]
// HX-Reswap: beforeEnd scroll:bottom

htmx.NewResponse().
  Reswap(htmx.SwapWithAttr(htmx.SwapInnerHTML, htmx.ModShowTop("#another-div"))
// [Output header]
// HX-Reswap: innerHTML show:#another-div:top

Edit: This possible implementation looks good too, implementing methods on the htmx.swapStrategy type (which is just derived from string) that return a new swapStrategy value:
htmx.NewResponse().
  Reswap(htmx.SwapOuterHTML.FocusScroll(true))
// [Output header]
// HX-Reswap: outerHTML focus-scroll:true

htmx.NewResponse().
  Reswap(htmx.SwapBeforeEnd.ScrollBottom())
// [Output header]
// HX-Reswap: beforeEnd scroll:bottom

htmx.NewResponse().
  Reswap(htmx.SwapInnerHTML.ShowTop("#another-div"))
// [Output header]
// HX-Reswap: innerHTML show:#another-div:top

@angelofallars is there anything that is expected change beside the headers? (htmx.Response.Headers())

btw is it possible for the hx-swap to have more than one modifiers?
something like
// HX-Reswap: outerHTML focus-scroll:true scroll:bottom

btw is it possible for the hx-swap to have more than one modifiers?
something like
// HX-Reswap: outerHTML focus-scroll:true scroll:bottom

Yes, with method chaining:
htmx.SwapOuterHTML.FocusScroll(true).ScrollBottom()

Yes, with method chaining:

i see, i think the requirement is clear enough now
i will create a draft PR for #1

@angelofallars would you mind to check the draft PR? https://github.com/angelofallars/htmx-go/pull/3
it covers the proposal on how to set modifiers
but it has not covered all of the mentioned modifiers in https://htmx.org/attributes/hx-swap
the remaining modifiers will be covered once we agreed with the proposal
thanks!


Simple review

Was hoping to see the use of transactions here and here, and where you'd define that boundary.
As you're using ts-morph for metadata, did you run into any problems? I figured you'd have to generate types or something. In my project I stuck with reflect-metadata.
Glad to see you throwing up a repo :D

Was hoping to see the use of transactions here and here, and where you'd define that boundary.

MikroORM handles transactions automatically. I do this by calling flush at the end of my mutations.
I also fork the entity manager, so when multiple requests hit the backend, their entity maps won't collide.
I also did not specifically use ts-morph. It's a package used within MikroOrm to discover your entities files. This way a schema can be generated based off of your entity definitions.
I recommend you to checkout the MikroOrm documation! Don't forget to specify the next version, as I'm using the RC for v4 in this repository.

Transactions

MikroORM handles transactions automatically

I mean kinda. in the sense that everything within a unit of work is batched into a flush call. But when we talk about transactions that's not really what we mean. Flushing != transacting. Flushing is where you notify the DB of changes, and transacting is where you commit those changes.
From the docs on transactions:

However, MikroORM also allows (and encourages) you to take over and control transaction demarcation yourself.

Metadata

I also did not specifically use ts-morph

Using ts-morph is implicit (it's the default strategy). Read more on the metadata-provider docs.
You should also be generating cache files when using ts-morph:

After the discovery process ends, all metadata will be cached. By default, FileCacheAdapter will be used to store the cache inside ./temp folder in JSON files.
You can generate production cache via CLI command mikro-orm cache:generate.

Versioning
You're also using an alpha version that's a bit old. Just beware! It seems like the first RC will hit this week though!

Using ts-morph is implicit (it's the default strategy). Read more on the metadata-provider docs.

It was default in v3, now it is not (as it brings the TS as a runtime dependency, so it had to be separated to its own package - @mikro-orm/reflection). So no metadata caching in place either. I just need to update the docs (I already did in some places).

You're also using an alpha version that's a bit old. Just beware! It seems like the first RC will hit this week though!

Not sure why you think so, he has rc.0 there:
https://github.com/driescroons/mikro-orm-graphql-example/blob/master/package.json#L18
One issue I see is the @mikro-orm/cli being used as regular dependency - that will bring some things including ts-morph itself (and therefore TS as well), as it is also used in EntityGenerator and MigrationGenerator. Better to have that only as dev dependency, if you care about the bundle size (P.S. - I don't, and do it this way too so I can access the CLI in production, mainly to run migrations - but that could be achieved programatically with a dependency just to @mikro-orm/migrations, basically on 2 lines of code).

Better to have that only as dev dependency

true

(P.S. - I don't, and do it this way too so I can access the CLI in production, mainly to run migrations - but that could be achieved programatically with a dependency just to @mikro-orm/migrations, basically on 2 lines of code).

This was the reason 😄 . I have some ideas in mind for potential features / refactoring. I'll add that to my todo!

Thanks for the review btw @dfee @devin-fee-ah (idk what your main account is 😄 )


Create JSLovers's PPT templates and add the link to the website

Add the JSLovers PPT that will be used by the speakers and add link to the website

@Neha can you provide info about the PPT like reference. Screenshot would be better.

Hello @sachin9164, This is our current PPTs used in our all meetups by the host: https://docs.google.com/presentation/d/1uP__Y7LKhYwLK5hnlUX9v2bH1I_U_v-TlYPZ1aXI1qs/edit?usp=sharing
I am looking to make a template for the speakers eg: https://docs.google.com/presentation/d/1NaTOfU9XnaG0dc03brapEfbAwD58ac-3VPuNQpwIP9s/edit?usp=sharing

Color theme
First, and last slide with JSLovers branding
Slides with headings
Slides with images
Slides with Bullet points
Slides with links


Update notifications.md

fixed readability and confusing grammar

duplicate: https://github.com/chatwoot/docs/pull/466/files


ArchiveOldFileOnStartup and FileArchivePeriod

Are ArchiveOldFileOnStartup and FileArchivePeriod linked to each other? Is this only to make sure we archive, for example, something on Monday when the application did not run for the weekend?
I am looking for a ArchiveFileOnStartup which would archive the file regardless of the rules. It would be useful mostly for testing/developing purposes.
BTW. I already mentioned something like this before https://github.com/NLog/NLog/issues/420#issuecomment-55521176

This is a old question, but nonetheless, no there are not linked. ArchiveOldFileOnStartup  always works the same, independent of FileArchivePeriod  and visa versa.

Answered and closing.


#get helper and API can't filter two-words tags

Hi,
I tried to get a list of posts with a specific tag in two words using those methods:
{{#get "posts" filter: "tag:Getting Started"}}
and
$.get(ghost.url.api('posts', {filter: 'tag:Getting Started}))
Neither works.
Cheers

Hi @toblerone1963,
When referencing tags (or other items) using the filter parameter you need to use the slug rather than the name as slug is the unique reference and has a format that is API and URL compatible. For example if you have not changed the "Getting Started" tag from the default dummy data then you could use {{#get "posts" filter="tag:getting-started"}}.
If you need more help, please head on over to slack - https://ghost.org/slack/ - and post in the #help channel. You can get help & support there from the Ghost community, which we're not able to do here on the GitHub bug tracker.

Yeah ! It's working ! Many thanks
Cosme Buxin
06 95 39 68 85
2015-12-30 16:58 GMT+01:00 Kevin Ansfield<EMAIL_ADDRESS>
Closed #6275 https://github.com/TryGhost/Ghost/issues/6275.
—
Reply to this email directly or view it on GitHub
https://github.com/TryGhost/Ghost/issues/6275#event-502873834.


Cannot leave repo field empty in WP Github Commits Sidebar widget

Version 1.2.6
Every time you clear the repo field in order to configure it to display commits from all repos, on save it refills the field with the default config value and therefore you cannot set it to display from all repos.

widget part needs some refactoring...right now you can use a shortcode in the sidebar if needed, in the last github version, a shortcut button has been introduced in tinymce.

I updated this part, let me know it it works out for you

This works now, but I'm running into a new bug where its not grabbing the latest commits and i told it to list 5 but it only shows 3

@cujomalainey are you running the last version ?

Version 1.3.3 according to wordpress


Question: Displaying the Post made in Draft.js

Quick question: If you only want to display a post made in Draft.js, do you pass it through to those draft-js to HTML converters like draft-js-export-html? Or do you just toggle the readOnly tag?
I realized that these converters does not any non default styles that I put, Entities and Atomic Blocks that put. I have to write that options in the module, which makes it redundant.

I think the quick answer is "Yes".
That is, you have to decide which of the two options which is best for your case. Both will "work," assuming all you need is to get the composed text displayed in a browser.

@flarnie  I have the same problem,  could you help me?

@QuietWind the two options are what's described above – either use the <Editor> with readOnly turned on, or use one of the many third-party converters available.
Lots of them are listed here: https://github.com/nikgraf/awesome-draft-js#common-utilities

@thibaudcolas thx your answers!


Clarify that there is still a server

I'm new to WebRTC and was confused how it was possible that devices behind NATs can establish a connection without a server, since, by definition, that shouldn't be possible. Apparently, I was right and there is a server involved after all. Wanted to clarify this to prevent potential similar confusions by others.

Yes, WebRTC still needs a signaling server. Sadly there is no way around that. The difference is that you do not really have to trust that server because you do not send any of your data to it. You just use it to create a connection to other clients.


Can it be deployed offline like KubeSphere？

Can it be deployed offline like KubeSphere？

Hi @yinggoga, thanks for asking. The short answer is yes, it should be able to be. But the longer, and perhaps slightly disappointing answer, is that we don't have any of that documented right now. There are several steps that need to be taken to set up an airgapped environment to be able to deploy offline, but we haven't gotten to validating and documenting all of those steps yet.
So while possible, until we get those steps written down, it will be a challenge to figure out what all needs to be done.

Regarding docs around internet restricted environment:
https://github.com/vmware-tanzu/community-edition/issues/862


Add DBeaver Community Edition v3.7.6

Adding DBeaver at v3.7.6. Someone already upgrade the dbeaver-enterprise cask, and I was actually surprised that this wasn't already done.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked that the cask was not already refused in closed issues.

Thank you for your contribution, we really appreciate them.
However, the dbeaver-community.rb is already available in caskroom/homebrew-versions.

That is an old version. My PR has the latest version.
On Tuesday, October 11, 2016, Victor Popkov<EMAIL_ADDRESS>wrote:

Closed #25413 https://github.com/caskroom/homebrew-cask/pull/25413.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/caskroom/homebrew-cask/pull/25413#event-820534012,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWuC6uOtmSxP5OM2swj82eE2upFH5pxks5qzIAAgaJpZM4KUOD0
.

--
Adam

My PR has the latest version.

And it’s in the wrong repo.

Ahh. I checked the versions repo for this version. But not the open PRs. Thanks!


Fixed a minor README.md mistake

Changed "THEN" to "THWEN" in the conditional section.

looks gOwOd, thank youwu <3


download S3 files and ingest

We need visibility on the S3 downloads now. @simsong will write a program that:

[x] Downloads each S3 object from the logs bucket and...
[x] Appends all lines them to an annual logfile.
[ ] Appends the GET calls to a second logfile
[ ] Deletes the S3 object in the S3 bucket
[ ] ingests the GET calls into database

I'm not sure we're going to get the legacy stuff, but we need this now

This works.


Update s3, sdk-core, sqs to 2.17.84

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.38 to 2.17.84.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch

Superseded by #359.


npm start shows : loading...

Do you want to request a feature or report a bug?
How can I run the angular-starter?

What is the current behavior?
When I run npm start from the commandline I get: loading... in the browser?

Please tell us about your environment:

osx mac sierra, node 7.9.0

same issue on my system. windows 10, node v6.10.0

same issue on my system. windows 10, node v6.10.0 . I suspect that the problem lies in the node version .
I found the version in package.json is 7.0.13 . I will try it at night

same here, tried fresh installation on node v7.10.0 and v6.9.1 (linux mint, ubuntu based). all deps are installed. no error in chrome console.

I think the Readme.md needs to be updated.  The clone command says:
https://github.com/angularclass/angular2-webpack-starter.git
But the clone URL  and zip download point to:
https://github.com/AngularClass/angular-starter.git
The angular-starter.git runs fine: no loading and not error for regex.test.
Note that I did upgrade to node 8.0.0 before pulling angular-starter so that may have helped.  But webpack.common.js is definitely different between the two: the angular-starter version has the PreloadWebpackPlugin code commented out but the angular2-webpack-starter does not.

runs fine now. thanks
cheers,
Dimitri
On Thu, Jun 1, 2017 at 5:34 AM, dwsmiontmigachcanc<EMAIL_ADDRESS>
wrote:

I think the Readme.md needs to be updated. The clone command says:
https://github.com/angularclass/angular2-webpack-starter.git
But the clone URL and zip download point to:
https://github.com/AngularClass/angular-starter.git
The angular-starter.git runs fine: no loading and not error for regex.test.
Note that I did upgrade to node 8.0.0 before pulling angular-starter so
that may have helped. But webpack.common.js is definitely different between
the two: the angular-starter version has the PreloadWebpackPlugin code
commented out but the angular2-webpack-starter does not.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AngularClass/angular-starter/issues/1769#issuecomment-305293274,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGurtnW22H_x1NdkXIKvbLvDRDuzaAgiks5r_cCsgaJpZM4NrLga
.

I just tried with node.js v8.0.0 and still nothing, just loading screen and no errors at all. it was installed using https://github.com/AngularClass/angular-starter.git URL. i have couple of older versions running and no problems at all, but this version can't pass further then loading screen.

pulled latest changes, it seams to be fixed

sorry about that. It was an issue with latest version of zone.js
https://github.com/angular/zone.js/issues/746


[EBPF] Improve error control in KMT setup tasks

What does this PR do?
Improves error control in KMT setup tasks and compiler starts
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge