Make CouplerPulse sweepable

I am building fSim gates using CouplerPulse (located in cirq_google/experimental/ops/coupler_pulse.py). To calibrate them, I need to sweep over hold_time and coupling_mhz. I wrote a sweep to do this, but it throws the following error because cirq.Duration is not sweepable:
File [...]/cirq_google/experimental/ops/coupler_pulse.py:73, in CouplerPulse.__init__(self, hold_time, coupling_mhz, rise_time, padding_time)
     55 def __init__(
     56     self,
     57     hold_time: cirq.Duration,
   (...)
     60     padding_time: Optional[cirq.Duration] = cirq.Duration(nanos=2.5),
     61 ):
     62     """Inits CouplerPulse.
     63
     64     Args:
   (...)
     71         ValueError: If any time is negative or if the total pulse is too long.
     72     """
---> 73     if hold_time < _MIN_DURATION:
     74         raise ValueError(f'hold_time must be greater than {_MIN_DURATION}')
     75     if padding_time < _MIN_DURATION:

File [...]/sympy/core/relational.py:398, in Relational.__bool__(self)
    397 def __bool__(self):
--> 398     raise TypeError("cannot determine truth value of Relational")

TypeError: cannot determine truth value of Relational

If I comment out the offending lines (the ones checking the values of hold_time, rise_time, and total_time, then everything works. I get nice-looking results, and it is much faster than running this without the sweep.
If a more permanent solution could be found, that would be very helpful.
Thank you!
@95-martin-orion @tanujkhattar

I have a PR up to allow symbols for coupling_mhz: https://github.com/quantumlib/Cirq/pull/5908. Note that cirq.Duration is sweepable if you construct it with a symbol, e.g. cirq.Duration(nanos=sympy.Symbol('delay_ns')) but we need to modify the CouplerPulse constructor to not check the durations if they are symbolic (or to remove the checks altogether since these should be handled internally after parameter resolution).

@maffoo Should I start a pull request where I delete those checks?

I'd be ok with removing the checks, since they're easily bypassed by using symbols anyway.

@eliottrosenberg can this be closed?

Resolved by https://github.com/quantumlib/Cirq/pull/5919.


Consume Array Results in Matrix [Implementation]

This issue tracks the implementation of Consume Array Results in Matrix  #6602 as part of promoting Matrix to Beta #5265:

[x] #6516
[x] #6577
[x] #6620
[x] #6648
[x] #6649
[x] #6661
[x] #6603

/assign


Keybinds, for fast item edit

Like use the key or something, and when you have the mouse, you put the last item used or a item you get from ctrl + c

Like a form of copy-paste for item slots? I could probably add that

Yes


Added support for instantiating via elements

Instantiating clipboard.js with already selected DOM elements will be much easier when working with React.js like libraries.

Hey @hasansoydabas, thanks for working on this.
I was looking at component-event's code and realized it is just a polyfill for IE8 and less. So I think we can get rid of it.
Also a developer should be able to pass not only a single element but a NodeList too.

Hey @zenorocha, thanks for the review.
I used 'component-event' because of it was already in dependency tree.
I'll work on it in a few days.

@arve0 It should be. I've tried to mimic how Delegate module implements.
My schedule is busy right now and can't contribute. Sorry.

Closing this one in favor of #75
Thanks for your hard work @hasansoydabas!


Add status icon to Character endpoint

If we can send a character status icon, for example a green  filled circle for a character that is alive.
It will save a lot of time for devs who are trying to show status using colored icons.
For example

For this we will have to create an icons (preferrably 50x50) jpeg. We only need three icons

Alive - Green Filled Circle
Dead/  Deceased  - Red Filled Circle
Operational - Yellow Filled Circle

You can use any icon from web (free icon), or create one in paint.
Just head over to paint and resize the area to 50x50px and create a circle, then fill it with proper color. Should be done in a few times..
Let me know if you have any question

i can keep it

Hey @ErickLemos
Can you also update the docs with issue.
Like the schema and example requests, etc. in characteer.md

yes i can, i will do it!
Something more?

yes i can, i will do it!
Something more?

Not right now but if I think of something, will let you know.
Thanks

Hello @lelouchB  I have been so near about achieving the results just need your help as my images are breaking dont know why I have kept my icons in img folder and accessing them as 'img/filename.jpg' but dont get the point as why images are breaking
It would be great if you can help!!

Hello @lelouchB I have been so near about achieving the results just need your help as my images are breaking dont know why I have kept my icons in img folder and accessing them as 'img/filename.jpg' but dont get the point as why images are breaking
It would be great if you can help!!

Hey @harsh599
No problem, I think know the problem but just to be sure can you send a PR with your code.
Thanks

Hello @lelouchB I have been so near about achieving the results just need your help as my images are breaking dont know why I have kept my icons in img folder and accessing them as 'img/filename.jpg' but dont get the point as why images are breaking
It would be great if you can help!!

Hey @harsh599
No problem, I think know the problem but just to be sure can you send a PR with your code.
Thanks

Yes Sure Thankyou @lelouchB

Hey I am facing issue file comitting my changes I am stuck at point to push my content to repo its showing access denied issue

Hey @harsh599
I guess your repo is not updated with the latest commits, might wanna do that before pushing changes?

Hey @harsh599
I guess your repo is not updated with the latest commits, might wanna do that before pushing changes?

Hello @lelouchB  I have made a PR request successfully kindly check it out.

@ErickLemos
Any word on this?

@ErickLemos
Any word on this?

hello, sorry for the delay, I had some personal problems, I will return to the project tomorrow!

@ErickLemos
Any word on this?

hello, sorry for the delay, I had some personal problems, I will return to the project tomorrow!

Yeah yeah
No rush
Take your time 👍

I went back to the project, spent a few days out, sorry.

@harsh599
You up for this?

Hi @lelouchB is this issue still available?

@guzbarraf
Yes
I will assign it you

thanks @lelouchB, tomorrow I'll upload the PR


.Net8 or 6?

Hi
I have attempted to install Blazor.Bootstrap on my .Net8 application and it has asked to install .Net6 into my application. Is there a way to use the library without installing .Net6?
Thanks

@gpcottle Could you please share the screenshot?

Hi @gvreddy04
Screenshot as below:

@gpcottle Please install .NET 6 on your machine.

@gpcottle Please check the starter project for quick reference.
Link: https://github.com/vikramlearning/blazorbootstrap-starter-templates/tree/master/src/BlazorBootstrap.Templates.Starter/NET8.BlazorWebAppRenderModeServerGlobal

OK - not the solution I was looking for. I'll hold off on the library until the dependency is changed


uploading music contents

is there a reason why upload path is specified as an absolute path instead of just the normal file upload ?

Yes there's a reason: Koel is designed that way :)


#generate_card_token default expiry date for valid cards expired

#generate_card_token uses a fixed month and year, September 2018. We already passed that date so
credit cards generated with default parameters will fail.
I solved it by replacing '2018' with (Time.now.year + 5) here:
https://github.com/rebelidealist/stripe-ruby-mock/blob/033651cb461b541ca5b4d30ca55ca7ae4001203a/lib/stripe_mock/test_strategies/base.rb#L19
I consider it worth to check if there are any other fixed dates around that might cause problems in the future.

Thanks for fixing this, much appreciated.  We're running into this issue now - is there any plan to cut a new release of this gem to pull in this fix ☝?  Thanks again!

@jjwyse 2.5.5


ADD search field and fix #51

This PR aims to add a search bar in the APP and fixing issue #51.
Please review it @souravbadami, @fredfalcon.
Thanks

Also after it's clicked the bottom nav bar doesn't work anymore.

Will check it as well. Might be again some version error for crashing.

@ankit2001 can you please update this to work ?

Sure, will fix all changes, this week.


Update Faraday to version 1.0

faraday_middleware was updated only recently.

@mauricew I'm going to work on my own fork, or I can help you with this repository if you want.

You can check a progress here: https://github.com/AlexWayfer/ruby-twitch-api/commits/fork
There just need to be done too many tasks, and I want to use this gem, so one task depends on another.
I can create a large PR later, if you agree, but it'd be difficult to separate this branch into independent small PRs.

Hey, going to add you as a collaborator for this and future changes. Thanks for the help and investment in this project.

Hey, going to add you as a collaborator for this and future changes. Thanks for the help and investment in this project.

Thank you! I've accepted.
One more thing: I want to connect new applications for this project, if you're not against. It's Depfu, Cirrus CI and Codecov. I had a good experience with them, they're helping a lot. For example, you can see one of many (across all projects which I know) example of strange Travis CI behavior right in this PR.

Yeah that's strange, it can certainly be done. Is this branch good to go?

This branch uses these 3 services. And I think it's better to enable them first, then I will create a PR from this branch, and we'll see checks in this PR, just to be sure that everything (including specs) works.

So, @mauricew, can you please enable these three services before a large PR with their configuration?

I've got all 3 set up now.

I've got all 3 set up now.

Awesome! Thanks. #18 is ready.


fix: allow augmenting JSX types within declare module '@vue/runtime-dom'

Based on https://github.com/vuejs/core/pull/7978, please merge that PR first.
Fixes use cases such as https://github.com/vuetifyjs/vuetify/blob/29777628ac8839c0548e869d3d350ed9fdcbb149/packages/vuetify/src/shims.d.ts#L18-L25
Adds a new ./jsx.d.ts entry in @vue/runtime-dom to avoid duplication
in vue. It should be removed in 3.4 when we stop registering global
JSX namespace by default.

/ecosystem-ci run

/ecosystem-ci run

/ecosystem-ci run

/ecosystem-ci run


Allow XML_RESOLVER_CP to be any name

Currently the test scripts (xspec.bats and xspec-bats.cmd) expect the XML_RESOLVER_CP environment variable to be xml-resolver-1.2.jar.
That's fine for Travis and AppVeyor, but you have to rename your catalog resolver file if you are running the test scripts in your local environment and if you have the resolver under a different file name.
This pull request allows the variable to be any name, which makes it easier to run the test scripts locally.
Note that the XML_RESOLVER_CP environment variable is used only for setting up testing environment. So this pull request has nothing to do with the actual behavior of XSpec.
No code change in XSpec core.

This pull request derives from #239. So needs to be handled after that.

This pull request just improves the setup of the test scripts environment. It doesn't touch the XSpec code. None of the existing tests are removed.
The test scripts still catch test failures. (demonstrated on Travis and AppVeyor)
Some pending pull requests (towards #235 in particular) depend on the changes in this pull request.

@cirulls
So I think you can merge this (after #239) safely without going into details, or I'd like to merge this by myself in a few days.


Implement django example.

@jin-liu , Please let me know any way, if possible, I can make this more acceptable to googlesamples.  Thank you for letting me contribute.


The documentation code example for behaviors must be changed to 'timestamp'

Hello,
i found out that the code example for the behavior timestamp is not working, we need to change 'Timestamp' to 'timestamp'.

Thanks :) I will fix it. However, the Timestamp name will also work because it's an alias.


change color of highlight

I'm using the ondark theme and the highlight background color as very hard to notice.
could there be a configuration to change the color?
it would probably be best if it was the same like the selection ('V' and select) color.

Hey, at the bottom of the README and docs there is a section on changing the highlighting. You have to define the illuminatedWord highlight group. The following is an example to make it underline the words:
hi illuminatedWord cterm=underline gui=underline
To make it the same as the visual selection, you can use the following:
hi link illuminatedWord Visual
Drop that in your vimrc OR your colorscheme file.
I am also open to suggestions to improvements to the README and docs to make this more clear, Ill also go back and reread the stuff cuz it was written fairly quickly and maybe not the clearest.

hi illuminatedWord cterm=underline gui=underline
Should this still work for the latest?


rust support

the rust framework yew supports a macro to do html inside for webassembly
setting the filetype in the config to rust won't allow for tags being closed inside a rust file

I looked a bit at this since I also wanted this, and from what I can see the problem is not in this plugin. The problem is with the queries that is set by nvim-treesitter. If you comment out this query: https://github.com/nvim-treesitter/nvim-treesitter/blob/a3cef7881ca8e2b8843a4500df44f94311bcc3df/queries/rust/injections.scm#L1-L2 then I believe it should work. It works sometimes without commenting out that line, but I believe that is because of the order of how the queries are applied, and that they are not the same everytime. @danielnehrig


analyzer_benchmark flutter_repo_batch_maximum regression; rebaseline?

Looks like it's nudged upwards since https://github.com/flutter/flutter/pull/51518. I don't think that's the culprit, though.
Is this a candidate for rebaselining?

I rebaselined.


2 Inch 320 x 240 Waveshare ST7789V Working (Also some questions)

I'm using this on a Zero W, with the ST7789V, but compiled with the ST7789VW flag and it's working great!
I messed around in the code to set everything to 320 x 240, but we're in business.
I had this idea, to stick the Pi Zero in a SNES controller (stole the idea from here https://howchoo.com/retropie/super-gamepad-zero-retropie-in-an-original-super-nintendo-controller), but I would like to use my new display as well (mounted on the front).
But when I configure the SNES gamepad to use the GPIO I run into issues. Without fbcp running, the gamepad actually works, but as soon as I start FBCP my input from the gamepad doesn't work and/or I get erratic inputs (i.e. only the B button works and jstest shows all inputs on).
The Gamepad is sharing the MOSI (GPIO10) and SCLK (GPIO11) pins with FBCP. The gamepad is configured using the gamecon-gpio-rpi driver (https://github.com/marqs85/gamecon_gpio_rpi).
Is what I'm trying to do even possible? I'm new to the hardware side of things.
Thanks to anyone who took the time to read this.

Reading the driver GPIO bus reading logic, which seems to be implemented here: https://github.com/marqs85/gamecon_gpio_rpi/blob/5fe34e2fb05d0480439553a9d287ceebce2fc9f9/gamecon_gpio_rpi-1.4/gamecon_gpio_rpi.c#L234
it looks like that GPIO driver is like fbcp-ili9341 in that they are both "dedicated access drivers", i.e. they cannot share the same GPIO pins with other devices, but need exclusive control over the pins that they use.
Based on that driver code, it does not look like the driver needs access to SPI at all, but just accidentally(?) happens to use GPIO10 and GPIO11? Or maybe I am mistaken. But if it does not need SPI, then reconfiguring the driver to use different pins might help avoid a conflict with fbcp-ili9341.

Thanks for the reply! Yes! You are right.
I figured this out late last night and just recompiled the gamecon driver using different GPIO ports and it worked!
I think I was confused because the SNES pinouts call the wires "CLOCK" so I assumed it was like an SPI clock thing, but it seems to be working with another GPIO port.
Thanks again for your input.

Hey, @ozzyonfire are you using this display https://www.waveshare.com/2inch-lcd-module.htm ??
Did you experience any other problems with the display?


Vorbis Decoder occasionally produces invalid files

Ref ds5678/AssetRipper/#179.
That issue contains a vorbis-encoded FSB file which results in an invalid OGG being produced, and another which occasionally produces an invalid OGG when running multi-threaded.
If we switch to a combination of https://github.com/SteveLillis/.NET-Ogg-Vorbis-Encoder/ for writing, and roll our own parser for the setup blobs, it should be possible to remove the dependency on OggVorbisSharp (and thus the native libs, and .NET 6.0).

Fixed implementation that doesn't require libogg and libvorbis anymore: https://gist.github.com/lab313ru/54a9b77d10e8b81c9cef2ac6340563f7

@lab313ru I'm working on a PR based on your gist, and I have a couple questions:

Are you licensing your gist under MIT?
In vorbis_headers.json, you have lists of 6 integers each.

Where did those come from?
Why is only the last integer used in code?

This has been addressed in d9aec6fb7e5a07ae1109d50c4c92825064be5c8d. Sorry for the wait!


Why this url keep player loading and never play?

https://embed.torrents-time.com/#source=magnet:?xt=urn:btih:181330e6959d87738cb81bf14fbc0ff64a0d9e4d&dn=50%2F50+(2011)+720p+BrRip+x264+-+700MB+-+YIFY&tr=udp%3A%2F%2Ftracker.openbittorrent.com%3A80&tr=udp%3A%2F%2Fopen.demonii.com%3A1337&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969&tr=udp%3A%2F%2Fexodus.desync.com%3A6969&title=50/50 (2011) en Peliculator&autoPlay=true&imdbid=tt1306980

One month later, same issue!!
The application stops on "downloading" black screen.
Could somebody help me?
http://peliculator.com/screen-torrentstime.jpg


Till when should we provide support for Embedding V1 using deprecated registerWith function?

It has been a while since Embedding v2 has been released. Right now my production application gets bombarded with deprecation warnings because a lot of plugins still have the registerWith class which has the deprecated io.flutter.plugin.common.PluginRegistry.Registrar parameter.
I'm a plugin developer and migrated all my plugins to null-safety. Does it even make sense to have the registerWith class when the plugin is null-safety?

Hi @juliansteenbakker
Since this is a question for the team, rather than a bug, I would suggest to join Flutter Discord and ask this question there
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Project Description Section

We will need to start our documentation for out project by introducing our client, the issues they have with their current systems/software, as well as what they want us to create for them.

We have split up the work evenly between our team.

We have completed the documentation. We have submitted it on Canvas and pushed a copy of the Project Description section to our repo.


private method `open' called for Thor::Sandbox::Git:Class

umm I'm not sure what I could have possibly screwed up in the installation but I did
gem install git
require 'git'
g = Git.open('/my/repo')

and I get
d:/scripts/test.thor:20:in `cmd': private method `open' called for Thor::Sandbox::Git:Class (NoMethodError)
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/runner.rb:36:in `method_missing'
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/command.rb:29:in `run'
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/command.rb:126:in `run'
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
        from C:/dev/Ruby21-x64/lib/ruby/gems/2.1.0/gems/thor-0.19.1/bin/thor:6:in `<top (required)>'
        from c:/dev/Ruby21-x64/bin/thor:23:in `load'
        from c:/dev/Ruby21-x64/bin/thor:23:in `<main>'

Happened to me by having 'ruby-git' as a require rather than 'git'. It's a different library and so you're calling Kernel.open which is private!


Add payment proof to builder bid

Right now we're trusting the bid from the builder will pay the value it claims. This can and should be provable with a state proof.
Suppose we're building block N+1 -- the builder bid object can be extended to have a proof to the balance of the fee_recipient at block N and N+1. The proofs would be rooted against the headers for N and N+1. This would allow the validator to verify that their account does receive the value as expected.

See also https://github.com/flashbots/mev-boost/issues/99#issuecomment-1130039956 for more discussion and context about different models for payment proofs.
Two discussed methods:

inclusion proof on transaction trie
account proof on post execution state trie


Reconsider implicit fetching behaviour

Context
Various Hiro products: Desktop/Web wallets & Explorer add custom headers to all requests to the API, in order to gain some insights into usage, as well as providing means for a kill-switch, were a critical vulnerability to be found.
Related issues https://github.com/blockstack/stacks-wallet/issues/700
Relevance
Some Stacks.js invoke API calls internally. getPoxInfo in @stacks/stacking for example, fee calculation in @stacks/transaction.
Issue
No means of configuring these requests is exposed by the library, and thus, in Hiro's use case, we make requests without the expected headers.
Further than simply adding a configuration, perhaps we should reconsider where exactly stacks.js should, and should not make network requests.
Some packages should be smart, and may warrant side-effect behaviour.
In other cases it might go beyond the role of a given package. For example, should @stacks/transactions contain a broadcast transaction method? Or should it only be concerned with creating the tx payload, leaving the broadcasting to another package (network?)

@reedrosenbluth and @zone117x - do you have any thoughts or suggestions?

we should consider implementing the suggestion in the related discussion: https://github.com/blockstack/stacks.js/discussions/1038#discussioncomment-913941

As part of the effort to introduce the API gateway, we should consider tackling this issue @saralab @zone117x @janniks

Moving to Icebox whilst we continue to refactor stacks.js


Create OTP Memory Map

We don't currently have a detailed map of the contents of the OTP regions. We need this to parse and allocate the OTP bits in each of the software-accessible regions. This issue tracks the creation of such a memory map.

I've just recently added a parseable OTP memory map here:
https://github.com/lowRISC/opentitan/blob/master/hw/ip/otp_ctrl/data/otp_ctrl_mmap.hjson
Would that suit this purpose? We can also amend this and add more details.
Also note that this memory map is currently not top level dependent, but it may be in the future.

Hey @msfschaffner, thanks for that link. The map we need to generate is specifically the actual byte-for-byte allocation of the CREATOR_SW_CFG_CONTENT and OWNER_SW_CFG_CONTENT sections. I think it's reasonable for the CREATOR_SW_CFG_CONTENT region (at least) to live in that file.

OK. We can discuss whether we want to split up the OWNER_SW_CFG_CONTENT item in this file as well and name all the items needed. One of the benefits of doing this here is that this gets propagated into the OTP controller documentation here and the item offsets and sizes become available in the autogen'd header via the HJSON.

@mcy
wait.. @gkelly, if it's software content only, do we really want that to be exposed in the controller though?
The software content likely will change between each creator / owner right? It almost makes more sense for this to be declared as some kind of top specific header file that can be invoked when instantiating the otp DIFs.
What do you think? Remember the software partitions are basically completely unmanaged by the hardware beyond basic checks (@msfschaffner please correct me if i'm wrong).

Yeah you are right, @tjaychen. The content is completely software managed. The only thing HW looks out for is the value of the SW digests in order to determine whether the partitions are write-locked or not.
So keeping the detailed memory map information of the individual software partitions in a separate header makes probably more sense, especially if the collateral is different for each creator / owner.

Ok, a separate parseable definitions sounds like the way to go here - we've got a way of doing this for the rom_ext image definition, I think we might re-apply that script/scheme here for each of the creator/owner partitions.

just a note also that the creator partition is going to be owned by the
vendor / partner.
So they might want their own scheme of how they want it maintained.  Also
in the case of Nuvoton, they do not wish to expose the exact definition,
and instead would prefer to have some kind of scheme where contents from
OTP are just copied over to the AST.
It might be good  to have a sync here with the relevant stakeholders.
On Thu, Oct 29, 2020 at 5:55 AM Sam Elliott<EMAIL_ADDRESS>wrote:

Ok, a separate parseable definitions sounds like the way to go here -
we've got a way of doing this for the rom_ext image definition, I think we
might re-apply that script/scheme here for each of the creator/owner
partitions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/3930#issuecomment-718733687,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSQBZ2QZLMD7CPHZJ73SNFQ3NANCNFSM4TA7IGUQ
.

For the OTP->AST chunk we've had some discussions around that, but there are other bits that end up in the creator region that Mask ROM has interest in, so we do need to have the layout defined there. I'm completely happy to put the layout outside of the mmap hjson, but I think there needs to be some map.

ah sounds good.
For the other regions you guys are interested in, do you think there's a
need to sync with Nuvoton?
On Thu, Oct 29, 2020 at 11:50 AM Garret Kelly<EMAIL_ADDRESS>wrote:

For the OTP->AST chunk we've had some discussions around that, but there
are other bits that end up in the creator region that Mask ROM has interest
in, so we do need to have the layout defined there. I'm completely happy to
put the layout outside of the mmap hjson, but I think there needs to be
some map.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/issues/3930#issuecomment-718951654,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSVSK2ZJ5LHSMHF5OPDSNG2N5ANCNFSM4TA7IGUQ
.

@cfrantz is this issue still valid? i think this is more or less resolved between you and @msfschaffner right?

i'll close this for now. If there are objections, please reopen.


[PHP] Add PHP 8.0, 8.1, 8.2, and 8.3

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue? Yes, #56226 and #58422

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree [company="PHPWatch"]

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree company="PHPWatch"

The manifest proposes to add four manifests, but all for the PHP.PHP package.
I'm one of the volunteers at the PHP Foundation (https://thephp.foundation/structure/), and hoping to add PHP to Winget.
I'm working on to build the manifests automatically, but for now, I'm going to manually submit new updates for the next two-three versions.

[Policy] zip-binary
php.exe is not a statically linked binary. It relies on .dlls being referenced properly present in the archive, something WinGet cannot do properly in all environments. See bot's comment below for more details

Any progress on this its been several months already.

@Kasparsu The blocking issue https://github.com/microsoft/winget-cli/issues/2711 has been resolved. We would be accepting these types of packages when WinGet 1.9 is made stable (it has had 2 RC releases, so that should be pretty soon) and when schema version 1.9 is rolled out

@Kasparsu The blocking issue microsoft/winget-cli#2711 has been resolved. We would be accepting these types of packages when WinGet 1.9 is made stable (it has had 2 RC releases, so that should be pretty soon) and when schema version 1.9 is rolled out

Good to know I have been wanting to install pure php and composer from winget since it came out ;P I can finally be happy ;P

@Ayesh - Support for zipped binaries has now been added and is available in the pipelines. This will require you to update your submission to ManifestVersion: 1.9.0 and set ArchiveBinariesDependOnPath: true in the installer node. To keep things clean, this PR is being closed. Please submit a new PR for the latest version of this package. Thank you for your contributions!

Thank you for the heads-up, and zip support is a great news!
I will submit a new PR soon.


chore(deploy/cloudformation): copilot renaming

Copilot renaming for `deploy/cloudformation' pkg.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Integ test succeeded


fix echidna load_pulse endpoint doc

#1648  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @anna-statsig and the rest of your teammates on  Graphite

🚀 Deployed on https://66688c557957631490bb11a8--cozy-fox-0defec.netlify.app


Deploy site 404 rerender

When on the main deployed site, if you hard refresh the page that isn't the home page it gives a 404 not found status code error.

Issue was fixed. Only needed to add this:
`
app.use(express.static(path.join(__dirname, 'build')));
app.get('/', function (req, res) {
res.sendFile(path.join(__dirname, 'build', 'index.html'));
});
`
to account for the client side rendering.


Add customization section with instructions to configure GA

Fix #108

@delapuente: you absolutely made my day! I had this next up on my to-do list. this is very thorough and helpful. (will review properly in a few.)
if I may add: I like that you are holding the developers' hands through these flows; especially at this stage (when we're trying to get adoption), I think it's the best possible thing to do.
P.S. lovely screenshots.

This is done, @cvan do you mind to review again?

Done, I've quantified the PNGs also. I'm going to merge this.


for px-vis-timeseries overlap of labels onto axis- how to avoid overlapping

Hi,

Is there a way to solve the labels of points on axis and axis itself are overlapping as shown in the above image. is there a property to make the labels look as they are shown in image but more legible & not overlap on the axis ?
Currently, properties i had set which resulted in the above output(shown in image uploaded) are:
labelPosition:"before" and labelRotation:-65 (degrees) in xAxisConfig.
Am i missing some property to avoid the overlap shown in the image? Please let me know what can be done.
I had logged an issue linked at :
https://github.com/predixdesignsystem/px-vis-timeseries/issues/77
But couldn't find a way to reopen the closed issue; so logging again since i am still kid of stuck in the above mentioned problem.

You can try offsetting them more by using labeltranslation. Consider also formatting your tick values differently so that they're smaller (not sure what is happening here but your values look odd on the X axis for a timeseries)

Hi,
Actually the values shown in the above image are just dummy values. So the overlapping problem of axis labels on the x-axis got resolved by property 'labelTranslation'. Thank you for the suggestion.
I just had 2 more queries:

If we try xAxisType as ordinal on prx-vis-timeseries chart and plot the chartData, following result is seen:

Answered in the other issues you opened


ocamlPackages.mirage-crypto*: 0.10.0 -> 0.10.1

https://github.com/mirage/mirage-crypto/releases/tag/v0.10.1

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 120724 at 565a2b6b run on x86_64-linux 1

2 packages built successfully:

dune-release
jackline


Docker image homeassistant/raspberrypi3-homeassistant is missing gatttool

im using the docker image `` and it works great but gatttool seems to be missing..
i get the following message /bin/sh: gatttool: not found.
Any chance you could add it to the image?

Yes you can make a PR :+1:  on https://github.com/home-assistant/hassio-build. For feature request please use the forum.


Mark multi-cpu test as CPU only

Due to issues with deadlocking and CUDA somehow being spawned, marks the CPU debug_launcher test as CPU only. I could not successfully override torch.cuda.is_available in any state to have it not spawn up CUDA processes 😢

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Feature/page example

:+1: @Shipow

If you can keep it as comment to allow esay debug it's fine, if it you still have error, yes you can remove it.

Ah ok, WFM


Error "Too many parameter values were provided" when using bind parameter syntax ?1, ?2

According to the SQLite documentation, there are five different ways of referencing bind parameters in an SQL statement:

?, ?
?1, ?2
:first, :second
@first, @second
$first, $second

It seems that better-sqlite3 supports the 1st and 5th syntax, but not the 2nd one:
const Database = require('better-sqlite3');

const database = new Database(':memory:');

// This works:
const statement1 = database.prepare('select ? + ?');
console.log(statement1.get(10, 20));

// This works, too:
const statement2 = database.prepare('select $first + $second');
console.log(statement2.get({ first: 10, second: 20 }));

// This throws an error:
const statement3 = database.prepare('select ?1 + ?2');
console.log(statement3.get(10, 20));

The last statement throws the following error:

RangeError: Too many parameter values were provided

Is there any chance of getting this syntax to work?

const statement3 = database.prepare('select ?1 + ?2');
console.log(statement3.get({1:20, 2: 30}));

I see! So for the ?1, ?2 syntax, an object with numeric keys is expected. Thanks a lot!

I'm pretty sure the intent in sqlite is that the binding behavior for select ?1 + ?2 is just like select ? + ?.

First of all I had never heard of ?NNN before this issue and I don't understand the use-case or the intend. Anyway:

I'm pretty sure the intent in sqlite is that the binding behavior for select ?1 + ?2 is just like select ? + ?.

Quoting: https://sqlite.org/c3ref/bind_parameter_count.html

For all forms except ?NNN, this will correspond to the number of unique parameters. If parameters of the ?NNN form are used, there may be gaps in the list.

I believe that this just works by accident in better-sqlite3. Because it doesn't work when skipping indexes, which is totally valid. I think it should be possible to use both array and object syntax in this case.  Docs say

The simplest way is with anonymous parameters:
[...]
SQLite3 provides 3 different syntaxes for named parameters (@foo, :foo, and $foo), all of which are supported by better-sqlite3.

No mention of ?NNN. I doubt @JoshuaWise overlooked this, but it's entirely possible. Or maybe I'm wrong with some of my assumptions.

If someone wants to make a PR, relevant places seem to be
https://github.com/JoshuaWise/better-sqlite3/blob/6d05e9e4e796c0a1e0f97bd5c7a535a743caf6ef/src/objects/statement.lzz#L26-L36
and
https://github.com/JoshuaWise/better-sqlite3/blob/6d05e9e4e796c0a1e0f97bd5c7a535a743caf6ef/src/util/bind-map.lzz

My use case is straight-froward.  I'd like these 2 statements to polymorphically accept the same set of parameters:
const insert = db.prepare('insert into T(name, version) values(?, ?)')
const update = db.prepare('update T set version=?2 where name=?1')

then some independent code that receives one of those can just call
insertOrUpdate.run(name, version)

@spazmodius thanks for the example. To me this looks fragile, is there a reason you cannot use insertOrUpdate.run({ name, version }) with named parameters? Or is it preference?

Just preference.  What you suggest is exactly what I ended up doing after realizing that ?NNN behaves indecipherably.


vim.lsp.get_active_clients() is deprecated

Upgraded to the latest neovim version and started seeing the following message
vim.lsp.get_active_clients() is deprecated, use vim.lsp.get_clients() instead. :help deprecated
Feature will be removed in Nvim 0.12

Looks like fix: 0.11 compat handles it

This can be closed, it was resolved in https://github.com/zbirenbaum/copilot-cmp/commit/b0ec7067460d77fc28a96429c99a84b2248f0f61.


⚠ Processors has degraded performance

In 9aa635b, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 97 ms

Resolved: Processors performance has improved in a72ed87.


MSID: 92543 Version: 1 DOI: 2<IP_ADDRESS>1013

"msas": "Neuroscience"
"msid": "92543"
"preprintDoi": "10.1101/2<IP_ADDRESS>1013"
"Reviewed Preprint posted": "2023-12-05"
"Sent for peer review": "2023-09-21"
"Posted to bioRxiv": "2023-10-05" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>1013v1/")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=92543)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/92543/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1013)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/92543/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/92543)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/92543

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/92543

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/92543/v1/92543-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/92543)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

Looks like Jennifer L Raymond has the wrong email address:

elocations missing from the references

@fred-atherden The two email addresses are for two separate authors. Both first and last authors should be corresponding authors, with separate email addresses; they currently both have the same one.

All fixed now.


optimize perm role

@xuxinx: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


install channel based broker

Fixes #

Proposed Changes

Install Channel Based Broker after installing eventing. This is now needed because of: https://github.com/knative/eventing/pull/2854

Release Note

Docs

/test pull-knative-eventing-contrib-integration-tests

/lgtm

/test pull-knative-eventing-contrib-integration-tests

/test pull-knative-eventing-contrib-integration-tests


1.13 Bugs

What is your Quests version / build number (do not say "latest")?
(QUESTS-3.3.6 [Jenkins: #480)]
If it helps,
Spigot: Spigot-69774b3-8e87d03 (MC: 1.13 R0.1)
Citizens: Citizens v2.023-SNAPSHOT (build 1562)
Please describe the problem and how to replicate it. Any console errors?
(PlayerDeath): https://hastebin.com/amuhejaziw.cs
(NPCRightClick): https://hastebin.com/iyilukinil.cs

For PlayerDeath, it happens randomly on death. There is no specific cause of this from what I can tell it just throws out an error.

For NPCRightClick, from what I have noticed is that it will not take the players item and shoot out an error. Works fine in the start but eventually will start to bug out. This also causes significant lag on my server. Removing the plugin promptly discontinues the lag issue.

I understand I am using a Dev Build and errors are expected, but I have decided to let you know of this error.
Can you provide an example quest from quests.yml using Pastebin.com?
From what I can tell it's when players are delivering an item to an NPC, so here's that quest:

https://pastebin.com/0NAw2tjD

(while on this topic, is there way to have players deliver more than 64x items at once than the monstrosity I have setup?)

Unfortunately. your first error (PlayerDeath) just indicates that the server experienced a problem with a Skeleton entity. Unless there is more to the error after that last line, there's no way for me to help diagnose this for a workaround.

Your second error is definitely a problem with Quests, but as you can see, I wasn't able to replicate it on a 1.12.2 server. Since I don't have a 1.13 set up, the next available dev build will place additional info in the console next time the error happens (as well as notify the player). Once you install that build, please post back here with the console information if it happens again!

Thank you for the response, I will update to the latest dev build and inform you of errors which come from it.

I found another issue with 1.13.1 but i don't know what the reason is.
https://pastebin.com/rQG2dY5N
maybe you have an idea


Scientific Computing with Python (Beta) Step 33 - Should ignore end of line whitespace

Describe the Issue
The challenge is failing if there is whitespace after a colon. Python's whitespace rules aren't quite that extreme.
Affected Page
https://www.freecodecamp.org/learn/scientific-computing-with-python/learn-how-to-work-with-numbers-and-strings-by-implementing-the-luhn-algorithm/step-33
Your code
    if verify_card_number(translated_card_number):
        print('VALID!')
    else:
        print('INVALID!')

Expected behavior
Python challenges should ignore end-of-line whitespace characters
Screenshots

System

Device: Laptop
OS: Windows 11
Browser: Chrome
Version: 120.0.6099.130

Additional context
No response

First reported in this forum post

I think the problem might be here:
https://github.com/freeCodeCamp/curriculum-helpers/blob/e86048735ba32c5f28b5c64e4c3039a3a022dda0/lib/index.ts#L145C80-L145C85
The regular expression contains (?<block_condition>${escapedBlockPattern})\\s*:\\n(?<block_body>.*?). The fact that the \\n comes directly after the : suggests that it simply won't match trailing whitespace. I think the fix would be to add \\s* directly after the : to be more permissive.

Reopening, problems with space after else: appear to be present again. From different challenge - https://forum.freecodecamp.org/t/learn-recursion-by-solving-the-tower-of-hanoi-puzzle-step-39/670149.
python-test-evaluator.ts:158 TypeError: Cannot read properties of null (reading 'block_body')
    at eval (eval at evaluatedTestString (python-test-evaluator.ts:83:13), <anonymous>:4:24)
    at evaluatedTestString (python-test-evaluator.ts:83:13)
    at new Promise (<anonymous>)
    at ctx.onmessage (python-test-evaluator.ts:78:39)

I don't remember if I've seen it working on production. Does anybody know?

@Dario-DC and @ojeytonwilliams are working on new AST based helpers that can be used to avoid such issues.

Do we still have this issue? Or we can close this?

I have not seen reports anymore of this on the forum, closing as solved


Switching from a channel with a topic to one without doesn’t clear the topic in the header

Steps to reproduce:

Open Quarrel
Select a channel that you know doesn’t have a topic set
The topic shows empty as expected
Select another channel with a non-empty topic
Go back to the channel without a topic

The topic is not cleared and shows the topic from the last channel instead.

Wanted to note I reproduced this and I'm honestly baffled as to how I missed this. Xbox One and PC, Quarrel Insider 20.6.28.
Some say that, to this day, the bike lane is still closed.

We've fixed this before but I believe the null bindings issue reintroduced it


Refactored out Servlet dependencies from core and toolkit

Another proposed solution for https://github.com/SAML-Toolkits/java-saml/issues/349 and https://github.com/SAML-Toolkits/java-saml/pull/115.

Introduced servlet-jakarta and servlet-javax which provide differing implementations of the core HttpRequest and HttpResponse interfaces depending on the servlet container implementation where the library is consumed
Teased apart HTTP request and HTTP response objects along a common seam and refactored all core and toolkit code
Removed all dependencies on the servlet API from core and toolkit
Bumped version to 3.0.0

With this change, if you're on a container pre-EE9, then you declare a dependency on:
<dependency>
  <groupId>com.onelogin</groupId>
  <artifactId>java-saml</artifactId>
  <version>3.0.0</version>
</dependency>
<dependency>
  <groupId>com.onelogin</groupId>
  <artifactId>java-saml-servlet-javax</artifactId>
  <version>3.0.0</version>
</dependency>

If you're on an EE9 or later container, then you declare a dependency on:
<dependency>
  <groupId>com.onelogin</groupId>
  <artifactId>java-saml</artifactId>
  <version>3.0.0</version>
</dependency>
<dependency>
  <groupId>com.onelogin</groupId>
  <artifactId>java-saml-servlet-jakarta</artifactId>
  <version>3.0.0</version>
</dependency>

Of course, this PR also opens the door to non-servlet container implementations, meaning someone in Akka, Play, etc. could use this library as well as long as they provide their own HttpRequest and HttpResponse implementation. The servlet API dependency in core and toolkit has been completely removed.
Usage on pre-EE9 containers look like this:
import com.onelogin.saml2.servlet.javax.JavaxSamlHttpRequest;
import com.onelogin.saml2.servlet.javax.JavaxSamlHttpResponse;

final HttpRequest request = JavaxSamlHttpRequest.makeHttpRequest(javaxServletRequest);
final HttpResponse response = JavaxSamlHttpResponse.makeHttpResponse(javaxServletResponse);

final Auth auth = new Auth(saml2Settings, request, response);
auth.processResponse();

EE9 and later usage looks like this:
import com.onelogin.saml2.servlet.jakarta.JakartaSamlHttpRequest;
import com.onelogin.saml2.servlet.jakarta.JakartaSamlHttpResponse;

final HttpRequest request = JakartaSamlHttpRequest.makeHttpRequest(jakartaServletRequest);
final HttpResponse response = JakartaSamlHttpResponse.makeHttpResponse(jakartaServletResponse);

final Auth auth = new Auth(saml2Settings, request, response);
auth.processResponse();

Thanks @markkolich for this PR. Let's see what rest of the people think about it.
@veselov, @mauromol, @jeroenvs, @lounagen, @krzysztof-osiecki , @dsvensson, @josemgut, @bramhaag, @fanste

This works for me. Thank you @markkolich!

This would also work for me. Thank you!

Thats seems to be the best solution instead of using the "transformer hack". Thanks for your work, @markkolich.

This is  also good for me. I'm not able to test it inmediatelly, but in two weeks we will apply it and it will work for sure. Thanks a lot.

I had a quick look at the commit and I would say this is exactly what I had in mind in https://github.com/SAML-Toolkits/java-saml/issues/349#issuecomment-1453909117. So, good job @markkolich
Just my 2 cents: maybe the invalidateSession() implementations could use delegate.getSession(false) and test the result against null before invalidating? Otherwise if, for whatever reason, no session exists, that method would uselessly create a new one to immediately invalidate it...

@mauromol fair point on invalidateSession() - I left it as is because the original logic prior to this refactor was:
request.getSession().invalidate();

Happy to change that to:
HttpSession session = delegate.getSession(false);
if (session != null) {
  session.invalidate();
}

will this be merged anytime soon ?

@markkolich
We encounter a NPE when using the processSLO because "SAMLRequest" param does not exist in request, that makes getParameters of the HttpRequest return null and isEmpty is directly applied on the null values object in getParameter method of HttpRequest.
NB1: we are using a sample app deployed in payara 6 app server and the jakarta servlet version.
NB2: we have fixed the issue in a particular fork that we'll use temporary, until this pull req will be merged and released
Stacktrace:
jakarta.enterprise.web|_ThreadID=82;_ThreadName=http-thread-pool::http-listener-1(3);_TimeMillis=1683800617926;_LevelValue=900;|
  StandardWrapperValve[jsp]: Servlet.service() for servlet jsp threw exception
java.lang.NullPointerException
        at com.onelogin.saml2.http.HttpRequest.getParameter(HttpRequest.java:48)
        at com.onelogin.saml2.Auth.processSLO(Auth.java:1269)
        at com.onelogin.saml2.Auth.processSLO(Auth.java:1371)
        at com.onelogin.saml2.Auth.processSLO(Auth.java:1380)
        at org.apache.jsp.sls_jsp._jspService(sls_jsp.java:113)

Nice find @ardeleana - I have fixed the bug in this PR and have updated the unit tests accordingly.
@pitbulk there were also a bunch of LogoutRequest's used in tests that were coded to expire (NotOnOrAfter) on 2023-05-10. As I write this it's now 2023-05-12 and so those tests started failing. I have fixed that test data as well in this PR.

@markkolich thanks for the PR and for fixing the SAML Messages of the tests, I will review and merge the PR as soon as possible.

@pitbulk are you planning to merge this PR and release a 3.0.0 version pretty soon?
Thanks!

Hi, @pitbulk I need it to. Any chance to merge this PR and release it?

Hi, @pitbulk. Same here - our company needs it too. We want to upgrade from Wildfly 24 to Wildfly 28 but can't.

Hi @pitbulk , My project upgrading from javax to jakarta. java-saml not working. Waiting for jakarta supported version.

@markkolich - thank you for the changes, I was able to use your branch in a project of Java17 and SB311 upgrades. Can we also consider bumping some dependencies, so to pass OWASP checks (https://github.com/markkolich/java-saml/pull/1) ?

@nj4x LGTM - I've merged https://github.com/markkolich/java-saml/pull/1 into this PR and the build + all tests pass.

@pitbulk Any update on this, @markkolich seems to have prepared everything for you.

upvote, really need this changes

@pitbulk Sorry to add another nag here, but could you perhaps clarify if your plans. Is your current recommendation, for the foreseeable future, to just import a copy of the code of this branch into the repo of projects using saml-toolkit today? Or would that be a waste of time with just a bit more patience?

Hi,
Sorry guys, I invested time on the rest of the toolkits and left the java-saml project to the latest on my queue.
I will do my best and get an official release in 2-3 weeks.
Thanks for your patience and collaboration.

Managing an open source project is what it is, but one way of reducing the burden is luring in a herd of recurring contributors, and this PR seems to have a few candidates. Was mostly after hearing about any kind of plan, rather than the all too common "is it done yesterday!!11" :)

@pitbulk Any specific area the community can offer a helping hand in that allows you to nail this new goal, this PR or otherwise?

Are there any news on the new release @pitbulk ? 🙇

I fixed some test and update dependencies.
I started to review and test this PR, it will be merged soon and an official release finally should be the light.
Apologies for the long delay :(

@pitbulk I have rebased this PR with the latest upstream/master and have resolved all merge conflicts.

@markkolich can you adjust the mockito dependency to use
<artifactId>mockito-core</artifactId>
<version>3.12.4</version>

instead
<artifactId>mockit-core</artifactId>
<version>1.10.19</version>

Also notice I removed its dependency from java-saml-core as I only had 1 test using it and implemented it in other way.
Also remove the dependency com.fasterxml.jackson.core
And jacoco-maven-plugin on servlet-jakarta and servlet-javax should be 0.8.10
Doing that, I guess the mvn test from CI should pass.

@pitbulk dependencies fixed & pushed - thanks for calling out those merge typos in the pom.xml!

@pitbulk I welcome the thoughts of others from the community on this, but my 2-cents ...
This PR is very intentionally not backwards compatible with the previous versions of java-saml. That's precisely why I bumped the major version to 3: it's a new version that will require existing users to do some small amount of work when they upgrade to 3.0.0.
I don't think changing the signature of the Auth constructor to Auth(Object request, Object response) and then using reflection to determine the argument types is the right approach. Such a change feels like it's defeating the purpose of the compiler and arguably makes it more difficult to identify the correct Auth constructor argument types.
That said though, perhaps what's missing in this PR is some documentation changes and example code to explain or clarify the upgrade path?
For instance, in your JSP example, this:
<?
<%@page import="com.onelogin.saml2.Auth"%>

Auth auth = new Auth(request, response);
?>

Would become this (please excuse the wildcard imports):
<%@page import="com.onelogin.saml2.Auth"%>

<%@page import="com.onelogin.saml2.http.*"%>
<%@page import="com.onelogin.saml2.servlet.javax.*"%>

<?
HttpRequest samlRequest = JavaxSamlHttpRequest.makeHttpRequest(request);
HttpResponse samlResponse = JavaxSamlHttpResponse.makeHttpResponse(response);

Auth auth = new Auth(samlRequest, samlResponse);
?>

Everything else remains the same.
I'm happy to help out with correcting or beefing up the documentation, either as a commit in this PR or as a separate fast-follow PR.
Let me know what you all think!

Alternative idea: what about keeping existing Auth signature as before, introducing a JakartaAuth that uses the new Jakarta interfaces and then making both delegate to a new AuthImpl class that instead uses HttpRequest and HttpResponse and does the real job?

@markkolich , what do you think about @mauromol's suggestion?

@pitbulk @mauromol I think that's a reasonable suggestion!
In the JSP example, you'd still have to change some imports, so the library upgrade wouldn't be a seamless drop in replacement but maybe less invasive of a change?
With this proposal, consider JavaxSamlAuth implements Auth and JakartaSamlAuth implements Auth. Even if we had the Auth implementations handle the servlet specific stuff, you'd still end up with something like this:
<%@page import="com.onelogin.saml2.Auth"%>
<%@page import="com.onelogin.saml2.servlet.jakarka.JakartaSamlAuth"%>

<?
Auth auth = new JakartaSamlAuth(request, response);
?>

In other words, the user would still have to make some code or JSP change to support this new version. It wouldn't be completely free.
I, for one, don't think we should be optimizing the path forward for antiquated JSP use-cases but I am acutely aware of the general concern around backwards compatibility and want to respectful of that when it's reasonable to do so.
If you agree that a JavaxSamlAuth implements Auth and JakartaSamlAuth implements Auth solution is better than the original proposal in this PR I'm totally OK with refactoring the changeset in this PR. LMK!

What I had in mind was a bit different and (unless I'm missing something - I didn't investigate further) should be 100% API and binary compatible for legacy consuming applications.
I mean:

com.onelogin.saml2.Auth maintains the exact same contract of today, but delegates all its operations to an extracted super class (named BaseAuth, for instance) that has no dependency on javax.servlet, but rather has a constructor that takes HttpRequest and HttpResponse objects
then, another JakartaAuth class extends BaseAuth but exposes a constructor with jakarta.servlet input parameters

In this way, code that uses the old Auth class (including the above JSP) should not need any code change and binary compatibility should be preserved as well (perhaps some tests would be needed). The only remaining requirement would be to change dependencies, because the Auth class should be moved from the java-saml-toolkit artifact to something like a java-saml-toolkit-javax artifact (while BaseAuth  should stay in java-saml-toolkit).
Even better, Auth can then be deprecated in favor of another class named JavaxAuth which does the same thing of Auth but makes it explicit that there are now two distinct implementations for the different servlet APIs.
The only thing that would still need a bit of thought is about Java 9 modules, if the toolkit wants to support them: in fact, in the above scenario the package com.onelogin.saml2 would be split into two different artifacts (java-saml-toolkit for the base/API part, java-saml-toolkit-javax for the moved Auth class): however, this is forbidden by Java 9 module system. Perhaps, a full support for Java 9 modules may be delayed to a later version, in which the (now deprecated) Auth class will be removed altogether in favor of JavaxAuth which should be placed from the beginning in a dedicated package of the new java-saml-toolkit-javax artifact.

Perfect is the enemy of good, how about tolerating the API breakage, and revisiting this in release+1?

If you break the API now you can't recover in release+1...
Anyway, mine were just suggestions, I'm not leading this project.

Sure you can. Might be confusing with a one-off, but as long as it's communicated I doubt it would cause any real harm. Can just spam out some major version bumps to signal it clearly - they're just numbers, nothing sacred about them. Sure, a bit ugly, but as is the unreleased situation.

We must do something with this project, I don't if the correct solution is to accept the breakage or not, but it cannot wait anymore.
@pitbulk wouldn't you consider opening this project to other collaborators (like @haavar proposed)? I think that the workload is too heavy for only one person.

I'll take a look at @mauromol's suggestions and see if it's something I can implement later this week.

@markkolich that's great.
Next week I took vacation so I will have time to complete, review and publish.

@mauromol I've been tinkering with the changes you suggested above. I think I understand what you're suggesting, and now that it's implemented the JavaxSamlAuth extends BaseAuth and JakartaSamlAuth extends BaseAuth approach looks like this...
Before:
<%@page import="com.onelogin.saml2.Auth"%>

<?
Auth auth = new Auth(request, response);
?>

After, with the BaseAuth approach discussed above in the thread:
<%@page import="com.onelogin.saml2.BaseAuth"%>
<%@page import="com.onelogin.saml2.servlet.jakarka.JakartaSamlAuth"%>

<?
BaseAuth auth = new JakartaSamlAuth(request, response);
?>

To gently reiterate, this is not a drop-in and make-no-changes to your JSPs backwards compatible change. Users will have to change imports and rename Auth -> BaseAuth. Is that acceptable?
I've pushed the suggested changes to this PR as a separate commit - I can squash if this looks good.

@pitbulk @mauromol any update here?

@pitbulk @mauromol please review

I just would like to specify that I'm not a maintainer of this project and I cannot merge. Some years ago I would have needed java-saml to be enhanced to properly support Italian SPID system, I've submitted some PRs, most of which have been merged, a couple of them are still there and one was never opened. Unfortunately, OneLogin lost interest in this project, Sixto changed his job, the new maintainers were absent, I even applied myself after being suggested by one of them, but things went in a different way. Probably this project should have been forked at that time, but I didn't have the necessary experience to do that. Now Sixto has come back as an independent maintainer, but it's clear that it is very low priority for him. I myself have changed job and I'm not into SAML and SPID any more, the latter now being pushed towards a migration to OpenID Connect, by the way (if it doesn't get dismissed before).
Here I just tried to give my suggestions on how to implement this based on what I know about Sixto point of view, and what I would have done myself. I still believe a solution which does not require any code change for old code should be possible, but I also think that small adjustments could probably be made by Sixto himself if he's willing to.
So, if I were you, I would seriously consider to fork this project and push the necessary changes the way you prefer.

It is not a matter of low priority, I'm sorry about the big delay I gave to this project.
As people may know, I maintain in my spare time not only java-saml, but php-saml, ruby-saml and python3-saml. And at the end of the day, it is a matter of time.
I had in mind to push this project in December, but sadly I have had not the chance to do it yet.
I was and I'm always open to collaboration and appreciate the effort you guys are spending in the PRs and suggestions you are sending.

You can probably spot 1-2 people in this thread who you can give merge access to to get the ball rolling. No harm in merging and then iterating, throw out a rc and get heated feedback.

@pitbulk Perhaps a bit to subtle given the lack of reply, but scrolling up here both @haavar (who mentioned being open to maintaining a fork) and @markkolich both sound like potential co-maintainers?

@pitbulk Need this dependency for Wildfly Server version >= 27.
Waiting this to be merged.

@jacqueskpoty no, I am not a maintainer of this library ... I have no merge permissions, I'm just a contributor who opened this PR. Please followup with @pitbulk.

I don't think it's too much to ask that the user extract the parameters and pass it to the library. That seems easier than for the user to understand how to configure the library for their version of the servlet API.

@haavar I disagree, but feel free to send a PR to my fork (e.g., https://github.com/markkolich/java-saml/pull/1) with your proposed changes and we can review+discuss.

Hi @markkolich, is there an ETA for release, please?
When will 3.0.0 be available on Maven, please? Thank you.

com.onelogin
java-saml
3.0.0

com.onelogin
java-saml-servlet-jakarta
3.0.0

Hi @pitbulk, sorry for asking again.
How is it going? Do you have some idea when will the jakarta supported available on maven, Thank you.

Any estimation on when will this be merged?

Hi @dsvensson, @markkolich @pitbulk
Is it correct understanding that after #395 merged, I am able to pull com.onelogin 3.0 from Maven which supports jakarta?
What's the status now, how much longer to achieve that?
Is it the full pull request?
https://github.com/SAML-Toolkits/java-saml/pull/395/files#diff-1d18ce5e578972573311127e5969a1b6711cbcfbf3143a3fceee8b7a4e6cbb03
On pull request list, I saw #379 but not #397
https://github.com/SAML-Toolkits/java-saml/pull/379
@markkolich
Do you have a #397 branch I can check out?
I can try build local lib for testing.
And how to potentially contribute to this project?
Thank you.

@Jing-Van I have no idea what #397 is about ... feel free to fork this repo and open your own PR. Just don't expect it to be merged lol 😃
As stated above, I am not a maintainer of this library and I have no merge permissions. I'm just a contributor who opened a PR over a weekend to try and address https://github.com/SAML-Toolkits/java-saml/issues/349 and https://github.com/SAML-Toolkits/java-saml/pull/115 which was blocking Jakarta adoption in a few of my projects.
Anyways, please read up on the current status of java-saml as a project in https://github.com/SAML-Toolkits/java-saml/issues/388. Some good context there on where things stand.

Hi @markkolich ,
sorry,
I mean #395.
I plan to migrate it to support jakarta.
Do you know is there a branch which tracked the most updated contributes from #349 #115 and #388?
May I have your email address, please or we continue discussing here for now.
Thank you.

@markkolich , @dsvensson , @mauromol, @haavar let's solve this situation.
Please, if you are interested in becoming a maintainer/collaborator of the Java-Saml toolkit, send me an email to the address in my Github Profile and share your availability with me for next week, to have a meeting.
Let's discuss the next steps and a roadmap to revive this project.

I am in.

@markkolich , @dsvensson , @mauromol, @haavar let's solve this situation.
Please, if you are interested in becoming a maintainer/collaborator of the Java-Saml toolkit, send me an email to the address in my Github Profile and share your availability with me for next week, to have a meeting.
Let's discuss the next steps and a roadmap to revive this project.

Hi,
@markkolich , @dsvensson , @mauromol, @haavar, @pitbulk
Based on profile,
Me and @markkolich are both PST time zone.
@pitbulk and @dsvensson are both Central European Summer Time
9am PST is 6pm Central European Summer Time.
Is that a good time for everyone? If we all need to meet online.
I am probably the latest into this thread, I have checked the markkolich:master and I am studying the source code now.
Thank you.

I'm on PDT, and 9AM PDT works for me, but I'm pretty flexible.

Hi @markkolich
I checked out https://github.com/markkolich/java-saml/tree/master
Currently there are tests which fail and some owasp issues.
What's the status now?
I was thinking to build a local libs of
java-saml-servlet-jakarta
java-saml
java-saml-core
as temp solutions.
I believe it should take less time than using a new lib such as keycloak.
Can you shed some lights?
If I go through source code, fix bug one by one. How far am I?
If the long solution is not too far away, then work on long solution directly.
Thank you.
ERROR] Failed to execute goal org.owasp:dependency-check-maven:8.4.0:check (default) on project java-saml-core:
[ERROR]
[ERROR] One or more dependencies were identified with vulnerabilities that have a CVSS score greater than or equal to '7.0':
[ERROR]
[ERROR] azure-core-1.46.0.jar: CVE-2023-36052(8.6)
[ERROR] azure-core-http-netty-1.14.0.jar: CVE-2023-36052(8.6)
[ERROR] azure-identity-1.13.0.jar: CVE-2023-36415(8.8), CVE-2023-36052(8.6)
[ERROR] azure-json-1.1.0.jar: CVE-2023-36052(8.6)
[ERROR] logback-core-1.4.7.jar: CVE-2023-6378(7.5)
[ERROR]

Built my own libs for now :)
My 2 cents.
You can treat it as a java project and migrate to support jakarta similarly as if you were migrating your other java project.
Samilar methodologies applies.
You can make one work during the time before the official release come out.
If you are already using this library, switching to others such as Keycloak introduces significant changes and is unlikely to be implemented within 1-2 weeks, especially if you are already loaded with daily tasks and lack dedicated hours for it.

Any idea, by when this change will be available in maven ?


Attempt on multibit classic

Hi there,
Reading up on this approach, since i have a MB wallet locked since 2015.
You can read up on it at https://github.com/gurnec/btcrecover/issues/212
Could this attempt be tweaked to run the wordlists against my MB wallet?
Thanks!

there is a link to generated wordlist for 2012-2016
i tried it with you hash -m 22500 in hashcat nothing found
https://github.com/pierce403/roboform-wordlists/tree/main/roboflayer link at the bottom

Any strategies to run this directly on the .key file you think?


Run createSearchChoice() before query()

So basically I have a select2 which initializes a text field that allows a single value which searches for pre-defined titles using Bloodhound through query().
The problem is that createSearchChoice() which allows a user to select a new title gets called after query() so there's a buffer timeframe where a user has to wait for the ajax call to finish before he/she can select the newly typed in value, is there any way to avoid this/get around?
Help would be really appreciated!

This is a duplicate of https://github.com/select2/select2/issues/2231.


feat(yarn-alias): add yd as yarn dev alias

I know this is a petty request but can you put it in alphabetical order in both the README and the plugin file?

@mcornella Oups, it s done

👍


implicitAny doesn't work for 2.5.2

TypeScript Version:  2.5.2
Code
const a = [];

Expected behavior:
TS should show an error message when noImplicitAny is on;
Actual behavior:
No error message is shown, and a has a type of "any[]", as below:

This is working as intended. See #11432.

@ahejlsberg You're right. Thanks


Update setup.py for pypi specific metadata

Added source-code and issue-tracker URLs. This will make the PyPI page for ftfy share link back to its GitHub repo.
This closes: #198

cc: @rspeer

Thanks. I'll add the equivalent fields in pyproject.toml instead.


[ares] Try to fix test

Attempt to fix the crash https://btx.cloud.google.com/invocations/91d5ed2d-da79-493d-b619-7371709b976b/targets/%2F%2Ftest%2Fcpp%2Fnaming:cancel_ares_query_test@poller%3Dpoll@experiment%3Dno_event_engine_dns;config=c4863158611888768eb9ed489660f2d7d62f599869f7919a2897d8450d8abc0b/log
It looks like the work serializer is still performing actions that refer to args when we destroy it; instead add an extra event to the end that we can delay on.

I'm not sure!


BUG: UI frontend sometimes is inresponsive

When I launch the app using docker-compose run and open the webpage via Chrome, sometimes I get a something is wrong error and the UI does not return an answer to my question. When this happens, the problem persists if you close the browser window and opens another, or restarting the docker apps.
Looking at the Chrome inspector, the console shows an error with loading script.js, something like Failed to load resource: the server responded with a status of 404 (Not Found), but it can be something else. And then it starts to generate errors about channel not being found, etc. It sometimes say something about an NPM module vercel.
Solution: the problem goes away when I load the app in incognito. The above error still shows, but it does not affect the UI.
Workaround: maybe to clear the cookies and caches from localhost.

Yes, I cleared all data for localhost, and the page loads fine.
Still getting a lot of errors, like
:5173/_vercel/insights/script.js:1          Failed to load resource: the server responded with a status of 404 (Not Found)
commons.js:2 Channel: Error in handleResponse UNK/SW_UNREACHABLE isLogsEnabled null
_handleResponsePromise @ commons.js:2
2commons.js:2 Channel: Error in handleResponse UNK/SW_UNREACHABLE options getValues
_handleResponsePromise @ commons.js:2
commons.js:2 Channel: Error in handleResponse UNK/SW_UNREACHABLE contextMenu createContextMenu
_handleResponsePromise @ commons.js:2
commons.js:2 Channel: Error in handleResponse UNK/SW_UNREACHABLE tabClipper initCompleted
_handleResponsePromise @ commons.js:2
2commons.js:2 Channel: Error in handleResponse UNK/SW_UNREACHABLE options getValue
_handleResponsePromise @ commons.js:2
3localhost/:1 Uncaught (in promise) Error: Could not establish


Add deprovision implementation

https://github.com/cloudfoundry-incubator/blockhead/pull/37#pullrequestreview-154789381
We've had this discussion in OSBAPI, and from what I recall, most people don't see a point in actually using this information as they are "useful hints for Service Brokers."

what is uat?

user acceptance testing.


[poem-openapi] OAuthScopes doesn't work

I have set up OAuthScopes like,
#[derive(OAuthScopes)]
enum ApiScopes {
    #[oai(rename = "DataProcessingAgreements:Read")]
    DataProcessingAgreementsRead,

    #[oai(rename = "DataProcessingAgreements:Write")]
    DataProcessingAgreementsWrite,
}

And I have added it into SecurityScheme like,
#[derive(SecurityScheme)]
#[oai(
    type = "oauth2",
    flows(client_credentials(
        authorization_url = "https://accounts.mydomain.com/connect/authorize",
        token_url = "https://accounts.mydomain.com/connect/token",
        scopes = "ApiScopes"
    )),
    checker = "developer_api_jwt_auth",
    openid_connect_url = "https://accounts.mydomain.com/.well-known/openid-configuration"
)]
pub struct OAuth2ClientCredentials(pub Claims);

And I am using it like,
#[OpenApi(tag = "ApiTags::DataProcessingAgreements")]
impl DataProcessingAgreementsApi {
    #[oai(path = "/v1/data-agreements", method = "get")]
    pub async fn get_paginated_data_processing_agreements(
        &self,
        state: Data<&models::appstate::AppState>,
        #[oai(scope = "ApiScopes::DataProcessingAgreementsRead")] auth: OAuth2ClientCredentials,
        page_no: Query<Option<usize>>,
        page_size: Query<Option<usize>>,
    ) -> DeveloperApiResponse<PaginatedList<DataProcessingAgreement>> {
         // My code
    }
}

This is my set up. But I'm not able to validate request by scope. Am I missing something?

@itsAmitGoyani OAuthScopes is for the generation of Open API spec only. @sunli829 any suggestions on how to check for the scope in auth extractor on every handler?


开心漫画

Source name
开心漫画
Source link
漫神漫画是主站https://m.mhkami.com/
野蛮漫画https://yemancomic.com/
yyds漫画https://www.yydsmh.com/
次元漫画https://2cycomic.com/
开心漫画https://yydscomic.com/
以上均为镜像，希望也可以加上
Source language
Chinese
Other details
No response
Acknowledgements

[X] I have checked that the extension does not already exist by searching the extension listing and verified it does not appear there.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a meaningful title with the source name.
[ ] I have admitted that I am a clown by having checked this box, as I have not read these acknowledgements.
[X] I will fill out all of the requested information in this form.

漫神漫画https://m.mhkami.com/是主站
野蛮漫画https://yemancomic.com/
yyds漫画https://www.yydsmh.com/
次元漫画https://2cycomic.com/
开心漫画https://yydscomic.com/均为镜像，希望也可以加上

用英文 這裡不是中文論壇
www.deepl.com

new domain here #1534


Changed to use applescript to start connection

Fixes #4 so that the keychain is used for connection secrets.

Thanks for your contribution! I've released 0.5.0 with this fix!


added gradient generator to the repo

Description
A gradient generator with rgb values for reuse
(Describe your project over here.)
Checklist

[x] I've been assigned an issue related to this PR.
[x] I've used beautifiers.
[x] I've added my Project's name and description to Index.md
[x] I've made a README.md file for my Project.
[x] The README.md file of my projrct contains Project title, Description, Use of project, Set up, Stack used and Output (Screenshots).

Related Issues or Pull Requests number
(Write your answer here.)

awaiting merge still, or am i missing something?

@Ayushparikh-code, haven't been merged yet


Regenerate ProximityBeacon client

This PR was generated using Autosynth. :rainbow:
Here's the log from Synthtool:
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Cloning https://github.com/googleapis/elixir-google-api.git.
synthtool > Running: docker run --rm -v/home/kbuilder/.cache/synthtool/elixir-google-api:/workspace -v/var/run/docker.sock:/var/run/docker.sock -e USER_GROUP=1000:1000 -w /workspace gcr.io/cloud-devrel-public-resources/elixir16 scripts/generate_client.sh ProximityBeacon
synthtool > Wrote metadata to clients/proximity_beacon/synth.metadata.

Closing to let this one regenerate with the otp_app fix.


10.3.0 consolidated envs

This introduces some changes and resolves issue with DEF prefix.

File writing comments I would request to stay in. These are going to be readded next Pull Request.

Potential issue on null check added in EntityAttributeUtils
In QwandaUtils better to return empty array for codes rather than null (in this case initialize as new ArrayList<>() instead of null), saves us a redundant check and becomes SONARlint compliant


Update: Microsoft.BotFrameworkEmulator version 4.10.0

Removing old versions to reduce clutter
Microsoft Reviewers: Open in CodeFlow

/azp run


Use of release tag (@public) and overloads

OK, I didn't made my mind on what the behaviour should be here, so opening the discussion to see what you think about it 😄
For code that is meant to be exported to consumers, Knip requires us to add a release tag @public in a JSdoc block to mark it as such and not report it. This is pretty awesome.
For overloads, Knip wants the tag to be on the implementation, not on the overloads. This is the correct way:
export function f(x: number): string;
export function f(x: boolean): number;
/** @public */
export function f(x: number | boolean): string | number {
  // …some code here…
}

However, in TSdoc (and API extractor), the release tags are expected on the overload declaration, and moreover can differ between overloads (e.g. to introduce a new API that isn't stable yet):
/** @public */
export function f(x: number): string;
/** @beta */
export function f(x: boolean): number;
export function f(x: number | boolean): string | number {
  // …some code here…
}

Additionally, API extractor automatically inherits release tags from ancestor namespaces, while Knip needs them specifically at each level. This is normal (and good). Knip is precisely here to figure out that this export is not needed, API extractor just tries to make our life easier by requesting less typing…

So, both tools use the release tags in different ways (this is good) and in different places (this is maybe less good). Making both tools happy becomes a bit WET:
/** @public (API extractor wants that) */
export function f(x: number): string;
/** @beta (API extractor wants that) */
export function f(x: boolean): number;
/** @public (Knip wants that) */
export function f(x: number | boolean): string | number {
  // …some code here…
}

But then, I'm not sure whether this is truly a problem and especially if it is how to improve on it 😅
The somewhat obvious idea is that Knip could look at release tags on overloads, and maybe accept an export if at least one of the overloads is marked as @public, but that makes things suddenly pretty ugly inside namespaces:
/** @public (prevents Knip from complaining, and mark API as public) */
export namespace Foo {
  /** @public (mark at least one overload as public to make Knip happy, but is totally redundant for APi extraction) */
  export function f(x: number): string;
  /** Should Knip also require a release tag here? Clearly not since the export is required on all overload/implementation
    * as soon as it is on one. But then the code becomes very asymmetrical and the first overload gets a special meaning,
    * which is also not satisfying…
    */
  export function f(x: boolean): number;
  export function f(x: number | boolean): string | number {
    // …some code here…
  }
}

On the other hand, we can keep the situation as it currently is, considering that different tools use different indications and this is OK since they have different goals… The situation inside namespaces is also more satisfying by not breaking the symmetry between overloads unless needed (i.e. on of them is actually not @public):
/** @public (prevents Knip from complaining, and mark API as public) */
export namespace Foo {
  export function f(x: number): string;
  export function f(x: boolean): number;
  /** @public (make Knip happy, API extractor doesn't care) */
  export function f(x: number | boolean): string | number {
    // …some code here…
  }
}

So here I am, not sure what the good solution should be or whether I'm just totally overthinking it…

I'll investigate a bit and see what Knip should do. Currently it's just a check on the exported node using ts.getJSDocPublicTag, interesting to look around a bit if there's more to this.

What Knip currently does is that it ends up considering only the implementation, also in terms of JSDoc tags. The rest is basically ignored. This still feels like the right and simple solution (as you point out, different tools have different goals), so I'm going to close this one. I actually looked into merging the tags of overloads into that of the implementation, but it has the downside of no longer "lazy loading" the JSDoc tags only when needed, which has a negative effect on performance.
You (or anyone else) can feel free to open another issue to discuss further.


Add edit command parser

Resolves #44

Pull Request Test Coverage Report for Build 143

0 of 18 (0.0%)  changed or added relevant lines in 3 files are covered.
27 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.7%) to 66.62%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/logic/AnakinCommands/AnakinEditCardCommand.java
0
1
0.0%

src/main/java/seedu/address/logic/AnakinParser/AnakinParser.java
0
1
0.0%

src/main/java/seedu/address/logic/AnakinParser/AnakinEditCardCommandParser.java
0
16
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/seedu/address/logic/AnakinParser/AnakinParser.java
10
0.0%

src/main/java/seedu/address/model/AnakinModelManager.java
17
0.0%

Totals

Change from base Build 136:
-1.7%

Covered Lines:
1437

Relevant Lines:
2157

💛  - Coveralls


Example Points to Wrong Repo?

What source should I use on this example? The original is commented out and when I put it back in I get this error:
Downloading github.com/GoogleCloudPlatform/terraform-google-vault for vault...
- vault in .terraform/modules/vault
There are some problems with the configuration, described below.

The Terraform configuration must be valid before initialization so that
Terraform can determine which modules and providers need to be installed.

Error: Invalid default value for variable

  on .terraform/modules/vault/variables.tf line 272, in variable "tls_ca_subject":
 272:   default = {
 273:     common_name         = "Example Inc. Root"
 274:     organization        = "Example, Inc"
 275:     organizational_unit = "Department of Certificate Authority"
 276:     street_address      = ["123 Example Street"]
 277:     locality            = "The Intranet"
 278:     province            = "CA"
 279:     country             = "US"
 280:     postal_code         = "95559-1227"
 281:   }

This default value is not compatible with the variable's type constraint: all
map elements must have the same type.

It should be github.com/terraform-google-modules/terraform-google-vault. We recently moved modules over, and that didn't get updated. Thanks for pointing it out!

Hmm...still throwing the same error above with:
  source         = "github.com/terraform-google-modules/terraform-google-vault"
  project_id     = "${var.project_id}"
  region         = "${var.region}"
  kms_keyring    = "${var.kms_keyring}"
  kms_crypto_key = "${var.kms_crypto_key}"
}```

Ah. Terraform 0.11 vs 0.12. This repo has not yet been updated to 0.12. This module is used by a lot of folks who haven't made the upgrade yet, but it's on our path to update it.

Oh, yep that's totally it. Thanks for the lightning response!

Hey Seth, know this is not exactly the right space to ask this but now I'm getting this permissions error?
	* module.vault.data.external.vault-tls-key-encrypted: data.external.vault-tls-key-encrypted: failed to execute "/Users/mitchparish/dev/copperpot2/.terraform/modules/ce76ba6b539a2a68e04194fd8053228b/scripts/gcpkms-encrypt.sh": + set -o pipefail
++ jq -r '@sh "ROOT=\(.root) DATA=\(.data) PROJECT=\(.project) LOCATION=\(.location) KEYRING=\(.keyring) KEY=\(.key)"'
/Users/mitchparish/dev/copperpot2/.terraform/modules/ce76ba6b539a2a68e04194fd8053228b/scripts/gcpkms-encrypt.sh: line 28: jq: command not found
+ eval ''
+ [[ '' == \n\u\l\l ]]
+ [[ '' == \n\u\l\l ]]
++ echo -n '||||'
++ md5sum
++ cut -d ' ' -f1
+ SIG=59d7d64dbcc254544f04cdb81ccff699
+ KMS_DIR=/.terraform/kms
+ mkdir -p /.terraform/kms
mkdir: /.terraform/kms: Permission denied```

Any idea what's going on? Everything else until this point is being created correctly. Changed service account to full owner status and still getting this.

Install jq (varies by platform)


Python support

Hi! Love the plugin, but unfortunately it doesn't seem to support expansion on Python. It's harder to parse for various reasons (hangs head) but it'd be nice to have it anyway... do you think you can add it?

I hope you're enjoying your 15-month vacation. Where did you visit?

You might give feedback on this pull request https://github.com/aronwoost/sublime-expand-region/pull/53

This has been included in version v1.3.0 hence I close this PR.


Migrate downloads dropdown menus to singletons

Summary
This PR moves the last two objects (the downloads dropdown menus) out of the WindowManager  and into their own singletons.
NONE

LGTM. Nevertheless, both classes seem to share a lot of code. It may be an opportunity to simplify this even a bit more. But 0/5

Yes I agree, I'm thinking of creating a generic MenuView class that contains the code responsible for opening, closing and sizing the menu. Then other implementations can define how they're updated.
This will be a follow up item since I want to first focus on breaking down the monoliths.


fix(parser): handle nested comments

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Make the tokenize_multiline_comment() able to handle nested comments, as mentioned in #6518
Checklist
~- [ ] I have written necessary rustdoc comments~

[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes

SQL commands, functions, and operators

Release note
Users may write nested comments in SQL, e.g., 0/*multi-line\n* \n/* comment \n /*comment*/*/ */ /comment*/1 will be tokenized to
vec![
  Token::Number("0".to_string()),
  Token::Whitespace(Whitespace::MultiLineComment(
      "multi-line\n* \n/* comment \n /*comment*/*/ */ /comment".to_string(),
  )),
  Token::Number("1".to_string()),
];

Refer to a related PR or issue link (optional)
#6518

Thanks for your contribution! Let's see what the upstream thinks https://github.com/sqlparser-rs/sqlparser-rs/pull/726


use value_array_or_scalar in distributions

Summary
This just tidies up the distributions a little bit by using as_value_array_or_scalar() in places we would do things like
  const auto& y_col = as_column_vector_or_scalar(y_ref);
  const auto& alpha_col = as_column_vector_or_scalar(alpha_ref);
  const auto& sigma_col = as_column_vector_or_scalar(sigma_ref);

  const auto& y_arr = as_array_or_scalar(y_col);
  const auto& alpha_arr = as_array_or_scalar(alpha_col);
  const auto& sigma_arr = as_array_or_scalar(sigma_col);

  ref_type_t<decltype(value_of(y_arr))> y_val = value_of(y_arr);
  ref_type_t<decltype(value_of(alpha_arr))> alpha_val = value_of(alpha_arr);
  ref_type_t<decltype(value_of(sigma_arr))> sigma_val = value_of(sigma_arr);

So now it's just
  auto&& y_val = to_ref(as_value_column_array_or_scalar(y_ref));
  auto&& alpha_val = to_ref(as_value_column_array_or_scalar(alpha_ref));
  auto&& sigma_val = to_ref(as_value_column_array_or_scalar(sigma_ref));

Note auto&& here has a different meaning then we normally think. Assigning to an auto&& type accepts any type as a reference so it can be auto&, auto&&, or const auto&
Tests
No new tests
Side Effects
Release notes
Tidy up distributions
Checklist

[ ] Math issue #(issue number)

[ ] Copyright holder: Steve Bronder
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

Nice cleanup!

ty!

I just think that auto&& warrants some discussion, since it is used everywhere. It is definitely OK, but it is not the only way. Previously we had const auto& in such cases, however decltype(auto) would also work. All these have subtle differences, but in this case all work the same. I am leaning slightly towards const auto& since it is the simplest option that works here. Unless you have a good argument for auto&&?

Yeah I was actually having difficulty thinking about this. I went with auto&& since it binds to all the reference types nicely. Though it's not as if we move these later so it provides no real benefit besides letting me be lazy. I'd be fine with const&. Just to sanity check, to_ref() here will either return an actual type holding memory for expressions, a view expression, or a reference to the input right? For that it almost feels like we want decltype(auto) so the object type is deduced as exactly the function return.

I went with auto&& since it binds to all the reference types nicely.

So do other two options I mentioned. The difference between decltype(auto) and auto&& is only how they are deduced when assigned a rvalue reference. decltype(auto) will be a value, while auto&& will be a rvalue reference. And const auto& is obviously const and always a reference.

Just to sanity check, to_ref() here will either return an actual type holding memory for expressions, a view expression, or a reference to the input right?

Right. As I mentioned all three options work exactly the same. As we don't need to change these variables I'd prefer the const option.

Would you mind if I used decltype(auto)? idk in my brain I know that const& is fine because it holds a constant reference to an object in the local scope. But then my brain is also like "No you are returning back an actual type use decltype(auto) so that the compiler knows it's not a reference

I guess that logic makes just as much sense as what I suggested.

I just like const & cause then I don't have to think. It's just a const reference.
Whenever I see decltype(auto) or && I know something possibly weird is happening and I need to stop and think about rvalues/lvalues and tricky things. const & is kinda no tricks.
Is there a reason a compiler would have trouble with a const &?

But on average this pull simplifies the code that came before it, so if this is ready to merge and you prefer auto&& or decltype(auto), sounds good to me.

Is there a reason a compiler would have trouble with a const &?

@t4c1 do you know a reference somewhere I can read about the rules surrounding cont& as the object type? I'm just not sure what to google to read more about how that works
If yinz are fine with decltype then I think this is good to go

Gaaah I wanna say yes and move on with the deserializer but then I went and read about decltype(auto). From here:
auto a = 1 + 2;            // type of a is int
...
decltype(auto) c1 = a;   // type of c1 is int, holding a copy of a
decltype(auto) c2 = (a); // type of c2 is int&, an alias of a

Ugh what a weird thing.
Can we just be plain const &? Everything comes into these functions as const & types so I don't think that would be a major problem. Also the other temporaries in these functions are const &.
I keep flipping flopping on this in the most useless way.

as_array_or_scalar() These are used like
decltype(auto) x_ref = to_ref(as_value_array_or_scalar(x))

and since to_ref() and as_value_array_or_scalar() both return references in the case of matrices/vectors with scalars of double the above behavior is exactly what we want!

Alright decltype it is. I scanned through this just to make sure everything was in order. There were some leftover things in beta_lpdf. I deleted those things and grepped and there were a couple other stragglers. Diff here.

Nice! Yeah there's a few other places we could clean up like the glm functions but I wanted to make this PR just the layups that were obvious

@SteveBronder You may want to look at how "lifetime extension" works.


Zero-shot forcasting

Could you provide a script for reproducing the zero-shot forcasting results?

Hi, we are going to open source the zero-shot benchmark (along with some other large model structures and large-scale data loading logic). Please stay tuned!

We have provided the scripts for zero-shot evaluation in this repo!