Some SDXL Images lead to crash

With this ComfyUI commit it gives the same error for the simplest flow, the node itself and its positive and negative outputs linked to two text nodes.

i just pushed an update i fetched from the image-data-reader package this node is based on. This update should support SDXL and some other SD generators. maybe this fixes your issue.
Sadly there are still a lot of cases when reading comfy workflows, when it crashes parsing the data.

@tkoenig89 It doesn't crush now, but at the same time it doesn't extract data. The simplest demo workflow is at the end of this comment (cannot attach json, so put it as code). It uses custom nodes ttN textDebug and Text Multiline from WAS (can be easily installed with the manager). The only purpose for using the two is convenience of testing. The multiline input gets to the debug text node, while the two text output from the Meta node do not.
I think the idea behind this node is great and I can see using it in a separate upscale workflow, it can save a lot of time. I'm not proficient in Python at all, so it's difficult for me to see why it doesn't extract data. As I understand PNG did not always supported Exif, there were PNG chunks. Is there any way to see how Comfy saves the data. It's possible to see all the metadata with ImageMagick, but how is it saved? Quick search led me to PyPNG that can read chunks, it was last updated in 2022 while piexif in 2019.
What do you think about Pillow, can it do the job? It's being actively supported and seems powerful.
{
  "last_node_id": 15,
  "last_link_id": 15,
  "nodes": [
    {
      "id": 11,
      "type": "ttN textDebug",
      "pos": [
        650,
        540
      ],
      "size": [
        450,
        190
      ],
      "flags": {},
      "order": 2,
      "mode": 0,
      "inputs": [
        {
          "name": "text",
          "type": "STRING",
          "link": 14
        }
      ],
      "outputs": [
        {
          "name": "text",
          "type": "STRING",
          "links": null,
          "shape": 3
        }
      ],
      "properties": {
        "Node name for S&R": "ttN textDebug"
      },
      "widgets_values": [
        true,
        ""
      ]
    },
    {
      "id": 10,
      "type": "LoadImageWithMetadata",
      "pos": [
        90,
        570
      ],
      "size": [
        315,
        454
      ],
      "flags": {},
      "order": 0,
      "mode": 0,
      "outputs": [
        {
          "name": "image",
          "type": "IMAGE",
          "links": null,
          "shape": 3
        },
        {
          "name": "mask",
          "type": "MASK",
          "links": null,
          "shape": 3
        },
        {
          "name": "positive",
          "type": "STRING",
          "links": [
            14
          ],
          "shape": 3,
          "slot_index": 2
        },
        {
          "name": "negative",
          "type": "STRING",
          "links": [
            11
          ],
          "shape": 3,
          "slot_index": 3
        },
        {
          "name": "seed",
          "type": "INT",
          "links": null,
          "shape": 3
        },
        {
          "name": "width",
          "type": "INT",
          "links": null,
          "shape": 3
        },
        {
          "name": "height",
          "type": "INT",
          "links": null,
          "shape": 3
        },
        {
          "name": "cfg",
          "type": "FLOAT",
          "links": null,
          "shape": 3
        },
        {
          "name": "steps",
          "type": "INT",
          "links": null,
          "shape": 3
        }
      ],
      "properties": {
        "Node name for S&R": "LoadImageWithMetadata"
      },
      "widgets_values": [
        "ComfyUI_00075_.png",
        "image"
      ]
    },
    {
      "id": 12,
      "type": "ttN textDebug",
      "pos": [
        650,
        800
      ],
      "size": [
<PHONE_NUMBER>614345,
<PHONE_NUMBER>1491475
      ],
      "flags": {},
      "order": 3,
      "mode": 0,
      "inputs": [
        {
          "name": "text",
          "type": "STRING",
          "link": 11
        }
      ],
      "outputs": [
        {
          "name": "text",
          "type": "STRING",
          "links": null,
          "shape": 3
        }
      ],
      "properties": {
        "Node name for S&R": "ttN textDebug"
      },
      "widgets_values": [
        true,
        ""
      ]
    },
    {
      "id": 15,
      "type": "Text Multiline",
      "pos": [
        70,
        1100
      ],
      "size": {
        "0": 400,
        "1": 200
      },
      "flags": {},
      "order": 1,
      "mode": 0,
      "outputs": [
        {
          "name": "STRING",
          "type": "STRING",
          "links": [
            15
          ],
          "shape": 3
        }
      ],
      "properties": {
        "Node name for S&R": "Text Multiline"
      },
      "widgets_values": [
        "Testing"
      ]
    },
    {
      "id": 14,
      "type": "ttN textDebug",
      "pos": [
        660,
        1100
      ],
      "size": {
        "0":<PHONE_NUMBER>871094,
        "1":<PHONE_NUMBER>7910156
      },
      "flags": {},
      "order": 4,
      "mode": 0,
      "inputs": [
        {
          "name": "text",
          "type": "STRING",
          "link": 15,
          "slot_index": 0
        }
      ],
      "outputs": [
        {
          "name": "text",
          "type": "STRING",
          "links": null,
          "shape": 3
        }
      ],
      "properties": {
        "Node name for S&R": "ttN textDebug",
        "ttNnodeVersion": "1.0.0"
      },
      "widgets_values": [
        true,
        "Testing"
      ]
    }
  ],
  "links": [
    [
      11,
      10,
      3,
      12,
      0,
      "STRING"
    ],
    [
      14,
      10,
      2,
      11,
      0,
      "STRING"
    ],
    [
      15,
      15,
      0,
      14,
      0,
      "STRING"
    ]
  ],
  "groups": [],
  "config": {},
  "extra": {},
  "version": 0.4
}

@green-anger the big issue with comfy is, it does not save metadata at all. It just stores the graph of your workflow. The tool my node is based on just tries to reversly go through this node and figure out what the prompt, seed etc. might be. But as soon as there is a node it does not know or some operation on the prompt (concat, split ...) happens, it fails to handle this case.
So the underlying issue here is not, how to retrieve the data from the png or jpg, but how to make sense of this data.
The best bet at the moment i found so far ist, to have a separate node in your initial worklfow, that saves the metadata plain (like A1111) into the image. Then there should be now issue, when using my node to retrieve this metadata.

@tkoenig89 Thank you for the explanation, I see what you mean now. I manually read the data, there're two significant parts, prompt and workflow. The latter hold all the info about nodes on the canvas, it has no data about the content. The prompt part does have it but instead of injecting values it has "links" (basically numbers) to the incoming nodes which in turn can have other incoming nodes. I have this situation in one of my flows with switches, it's saved as deeply nested nodes in the meta.
In this case I think it's not worth investing into "reverse engineering", at least until Comfy has a separate section for the prompt. Unfortunately, that may never happen since Comfy allows to have any node combination and the same flow can have multiple text encoders, you'll never know which one is the true source.
May I ask what you meant in your last para? Do you mean putting the prompt as text into the text encoder instead of linking another node to it? How can we let your node know from where to pull the prompt info?

Sure, sorry that part was really a little confusing i guess :D. So let me take some more lines explaining what i think might be a solution:
So it is all about getting around the issue, that you don't have any usable metadata by default. So before we tried to only catch the issue when its too late and you only have the workflow at hand. So what you might want to do, is update the workflow that is generating your images. There is a node you use as a replacement for the "save image" node, just like you might replace the "load image" node with mine.
There are a few out there, but this one you can find via comfy manager: https://github.com/giriss/comfy-image-saver.
I did not do a lot of digging there, but basically you manually plug in your data into this node. It will then store everything in the format that a1111 uses. So metadata is directly accessible inside the image file.
The files saved with this metadata can easily be read by my node, as the tool it is based on supports a lot of formats for the metadata.
The caveat of this solution is, that it only works with images you create from the moment you update your generating workflow.  And of course, you have to add a lot of connections to an already existing workflow, to save prompt, seed and so on.

@tkoenig89 Thanks a bunch for the link, I didn't see this node before!
Reworking workflows is not a problem, it can be fun on its own.
I'll give the combo a try, it sounds promising. Thanks again! 👍

@tkoenig89 I've tried it and it gives this error now:

comfy-image-saver @ 65e6903
this node @ 6e60238

Looked at it, and it's in issue with the Node. It saves not 100% compatible with A1111 format. I opened an issue here:
https://github.com/giriss/comfy-image-saver/issues/10

@tkoenig89 Yes, it works now! 🎉 Thanks a lot!
CFG is not that useful to be honest. For an upscaling flow the most important are the prompts and (probably) seed, image size is very convenient, but steps and cfg are so-so. Would be great to get sampler and scheduler, but I'm not sure if it's usually saved in meta data.

Closing, as the bug is fixed.
Tracking model and sampler as separate feature request: https://github.com/tkoenig89/ComfyUI_Load_Image_With_Metadata/issues/5


Reverted: force separator around binary operators

This PR reverts this trick introduced by #149 :
/**
 * group operator and its preceding/succeeding whitespace/newline
 * @param {string} opr
 * @param {boolean} parenthesized
 */
function operator_with_separator(opr, parenthesized) {
  const sep = parenthesized ? choice(/[ \t]/, /\r?\n/) : /[ \t]/;
  return alias(token(seq(repeat1(sep), opr, repeat1(sep))), opr);
}

It turns out that this will cause unwanted side effects of blurring boundaries of tokens around binary_expression:

compared to the ideal result after this PR:

Instead, cmd_identifier is tweaked to keep expressions like 1+1 away from being parsed as binary_expression.

good catch. thanks!


ImportError: cannot import name 'SAFE_WEIGHTS_INDEX_NAME' from 'diffusers.utils'

Error when running inference_mmu.ipynb
diffusers==0.30.1

Hi, can you alternatively run the inference_mmu.py?

It seems to be the same error

Cannot reproduce the error. Maybe you can refer to this post.


[ENHANCEMENT/REQUEST] Auto start on open or Command Line Arguments

It would be great if there was a setting for RB4InstrumentMapper to automatically start once the application opened.
Or otherwise if we could run the EXE with a switch/parameter to start it, EG: .\RB4InstrumentMapper.exe -Start

Totally agree!


Allow exec* methods to fail with partial matches.

Currently, PCRE_ERROR_PARTIAL is bundled with other errors, making
ExecPartialSoft and ExecPartialHard useless. The exec* family of
methods now returns a Result, with two possible error cases:

A partial match occurred.
Some other error occurred.

This is my first foray into Rust (outside tutorials and toy projects),
so forgive me if anything isn't idiomatic.
I'm happy to fix up the PR as-needed.

Hello Matt,
Sorry for the delay in responding to this.
I like the idea of supporting PCRE_PARTIAL_HARD and PCRE_PARTIAL_SOFT. Building on your PR, I think that it would be a good idea to get rid of the panic in pcre::detail::pcre_exec(), particularly since it might become commonplace to use the -C panic=abort flag to decrease binary sizes and compilation times.
One thing I am not sure about (and correct me if I am wrong) is that the PR translates the no-match scenario to ExecError::GeneralError, which is a catch-all for all of the errors that pcre_exec() can return. Maybe it would be a good idea to map all of the error values returned by pcre_exec() from the start, so that mapping an additional error code as people request them would not break existing matches of ExecError without a default clause ("non-exhaustive patterns" error).
At one point Rust had an Either enum, but it was removed (see rust-lang/rust#9157). What do you think about creating a custom enum type, say ExecResult, that would have Some(Match), None, and Err variants? This way, the current API of calling is_none() or is_some(), or matching on the result, could be preserved.
Cadence

Sorry for the delay in responding to this.

No worries! Life is busy.

Maybe it would be a good idea to map all of the error values returned by pcre_exec() from the start, so that mapping an additional error code as people request them would not break existing matches of ExecError without a default clause ("non-exhaustive patterns" error).

I think that's the best way forward. I set up GeneralError as a quick proof of concept to see what you guys thought about supporting partial matches.

What do you think about creating a custom enum type, say ExecResult, that would have Some(Match), None, and Err variants?

I'll try that out when I get the chance. Thanks for the feedback!

I finally got around to trying out your suggestions. Closing in favor of #28.


What is the "Doom Installing Worker" algorithm supposed to be doing?

Can someone tell me what the "Doom Installing Worker" algorithm is supposed to be doing?
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#doom-installing-worker-algorithm
As far as I can tell its run in parallel with a job from the "Run Job" algorithm.  This seems somewhat insane to me since they are both manipulating the job queue.  Isn't it incredibly racy to assume the job itself lives beyond the life of "Doom Installing Worker"?
Also, what is the purpose of the loop over the remaining items in the job queue?  It seems its trying to somehow early abort the in-parallel job iff its a register job and there is another register later in the queue.
Can we instead simply put these steps in the register job?  That would avoid races and be a lot easier to understand.

As you say, Doom Installing Worker seems to try to abort installation/registration jobs if a new register job gets queued before the existing one completed. As such it is invoked both when running a job and when a new job is queued. I'm not sure if any of this is technically racy though (at least not anymore than the entire job queuing mechanism with only implied locking is; "schedule job" can run in parallel with "finish job" just as well).
Step 12 in the install algorithm seems to deal with what happens when Doom Installing Worker is executed in parallel (it aborts the rest of the steps without "finishing" the job, since the job has already been finished by Doom Installing Worker).
I do agree that it would be nice to somehow make this easier to understand, although I'm not sure how best to specify how an existing register job should be aborted when a new different register job is scheduled. Moving Doom Installing Worker to inside "register" wouldn't entirely solve it. Maybe we can replace the mentioned step 12 in the install algorithm with some check to see if a new register job got queued in the meantime, but that would still be just as racy without making explicit locking guarentees around the job queue.

Why do we even need to abort the current register if a new register is appended to the queue?  How often is that going to happen in practice that we need to optimize it?  Lets just run through the queue and let both jobs run.

I guess if we assume everything in the lifecycle job code runs on a single thread its not technically "racy", but I still don't understand the algorithm.  I don't see how the .installing worker could ever be set on the registration by the front job in "Doom Installing Worker" since that requires loading a worker script asynchronously.  It seems like Doom Installing Worker would just always exit at step 5.

Yeah, it seems unlikely that Doom Installing Worker when called from Run Job will ever do anything useful. When Doom Installing Worker is called from Schedule Job it is of course different, as that can happen at any point while another job is installing a worker.

When Doom Installing Worker is called from Schedule Job it is of course different, as that can happen at any point while another job is installing a worker.

Hmm, yea.  "Sorry I missed where you pointed out it ran from Schedule Job."
That being said, though, it just doesn't seem safe to me.  The various algorithms don't seem designed to account for the idea that their job is going to get "Finish Job" run on it while they are in the middle some async step.
Assuming we really want this optimization I think it would be better for the algorithms to explicitly check for this cancellation at specific checkpoints.
It doesn't seem particularly perf sensitive, though, so I don't plan to implement "Doom Installing Worker" in gecko.  I'm just going to let the jobs run their course for now.

Yes this is what I was talking about here: https://github.com/slightlyoff/ServiceWorker/issues/783#issuecomment-168982727
DoomInstallingWorker is something I added to Chrome before we had timeouts, to ensure a while(true) worker does not block the whole job queue. I don't think it's needed in the spec, or in Chrome anymore now that we a timeout.

Ah, sounds like we indeed should just get rid of it from the spec then.

In Schedule Job step 2.3, the given job (Job_B here for example) is enqueued if it is not equivalent to the last job (Job_A) in the queue. So, it was the only case that seemed to matter when Job_B has the same scope and a different script url with Job_A. This means, Job_B has to wait until Job_A finishes no matter how long Job_A's installing takes (e.g. caching big files, etc.) knowing that it eventually will replace Job_A's registration anyway.
If this is an edge case and doesn't seem bad, I agree to remove DoomInstallingWorker.

I think it's fine to wait even if the script url is different.

Okay. Reading the thread, all agreed on removing it. Let's do it.


Uncaught SyntaxError: Unexpected token =

Experienced similar issues as described in #1116 and #1335.  Version 1.0.2 via cdnjs.    Debugging I found the offending template.  I had converted the default settings shown in the docs to single quotes incorrectly:
scaleLabel: '"<%= value % >"'

Fixing the quotes and the whitespace issue resolved the error.  It is likely that others are experiencing odd syntax errors due to this template function failing on bad templates.  Wrapping the invocation in a try/catch I think is very helpful:
From the current:
// Chart.js @ 503
return tmpl(templateString,valuesObject);

To something along the lines of:
try {
  return tmpl(templateString,valuesObject);
} catch (e) {
  throw new Error('Cannot create template from string: ' + templateString);
}

Repeating the template string error we now get a much more helpful error:
Uncaught Error: Cannot create template from string: "<%= value % >"   @ Chart.js:506

Looking at the usages of template():

generateLabels @ Chart.js:513
generateLegend @ Chart.js:892
tooltipLabels @ Chart.js:983
text (tooltip) @ Chart.js:1043
yLabels @ Chart.js:1471 & 1754
textWidth @ Chart.js:1812

It could be extended to take in the config option name it is being used for.  Then the error could also give the property name, something like:
// Chart.js @ 503
...
throw new Error('Invalid "' + optionName + '" template string: ' + templateString);
...
// in the browser console
Uncaught Error: Invalid "scaleLabel" template string: "<%= value % >"   @ Chart.js:506

Hope this helps, cheers!

Worth mentioning, I ran the offending template string through lodash.template and it outputs the template string itself if it could not parse it.  It is ~180 SLOC and can be installed as a standalone dep without the whole lodash lib npm i lodash.template.  Just a thought.

Closing as duplicate of #1280

Just pointing out this is related but not a duplicate of 1280. 1280 reports that the method is broken in the minified build.  I was not using the minified lib and the method works fine when template strings are valid.
This issue is pointing out that the tmpl method does not handle errors. It should probably catch bad template strings and throw an error.

My bad, reopening now.

Hello, today I am closing all issues that are only affecting version 1 of Chart.js as WONTFIX.
If this issue does affect version 2 as well, I apologize for the error. Please create a test case against Chart.js 2 using on of the below websites and we will be happy to reopen the issue and update its classification:

http://jsbin.com/
http://jsfiddle.net/
http://codepen.io/pen/
Premade template: http://codepen.io/pen?template=JXVYzq


Merging code for generating cut cells

Codecov Report

Merging #15 (4db415b) into main (0d9029d) will decrease coverage by 5.88%.
The diff coverage is 88.02%.

@@             Coverage Diff             @@
##              main      #15      +/-   ##
===========================================
- Coverage   100.00%   94.11%   -5.89%
===========================================
  Files            6        7       +1
  Lines          335      578     +243
===========================================
+ Hits           335      544     +209
- Misses           0       34      +34

Impacted Files
Coverage Δ

src/helper_functions.jl
83.14% <65.90%> (-16.86%)
:arrow_down:

src/PresetGeometries.jl
89.04% <76.47%> (-10.96%)
:arrow_down:

src/define_regions.jl
93.12% <93.12%> (ø)

src/PathIntersections.jl
100.00% <100.00%> (ø)

src/find_mesh_intersections.jl
100.00% <100.00%> (ø)

src/map_line_quadrature.jl
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


The color used for markdown fenced blocks is too dim

Fenced blocks have many roles in markdown:

verbatim text
code blocks
a generalization of the above in pandoc
a translation of reStructuredText roles in MyST markdown
probably many others

Most Noctis themes treat these blocks almost as comments, in that they are shown in a dimmed down fashion, except when a language is specified (then the syntax highlighting for the language is used, of course). But there is no reason to assume that these blocks are less important than other contents or shouldn't divert attention as much as other contents.  This assumption is unsafe even for the vanilla verbatim block.
I think that deemphasizing these blocks is an undesirable quirk of the Noctis themes.

Hi, this should have been fixed. Please let me know if that's the case.


Error with PBKDF2.hash

I am facing an error with this code:
const password = "secret text";
const salt = RNSimpleCrypto.utils.randomBytes(8);
const iterations = 4096;
const keyInBytes = 32;
const hash = "SHA1";
const passwordKey = await RNSimpleCrypto.PBKDF2.hash(
	password,
	salt,
	iterations,
        keyInBytes,
        hash
    );
console.log("PBKDF2 passwordKey:", passwordKey);

The log of the error is :

[Error: invalid hex:{length=32,bytes='a hex value'}]

I get that with code below
  const secretKeyBuffer = RNSimpleCrypto.utils.convertBase64ToArrayBuffer(APIKey)
    const signatureBuffer = RNSimpleCrypto.utils.convertUtf8ToArrayBuffer(signatureRawData)

    const signatureArrayBuffer = await RNSimpleCrypto.HMAC.hmac256(signatureBuffer, secretKeyBuffer);

    const signatureBase64 = RNSimpleCrypto.utils.convertArrayBufferToBase64(
        signatureArrayBuffer
    )

I think the problem is similar to what I had when calling HMAC.hmac256. With iOS13+, the format for NSData hex values has changed to the format {length:32, bytes='hex value'}. I believe it has something to do with calling description within the native hmac algorithm.
I got around this issue by editing the Hmac.m file at this path /react-native-simple-crypto/ios/RCTCrypto/lib/Hmac.m to grab the bytes value and convert to string. The new function is...
`+ (NSString *) hmac256: (NSString *)input key: (NSString )key {
NSData keyData = [Shared fromHex:key];
NSData inputData = [Shared fromHex:input];
void buffer = malloc(CC_SHA256_DIGEST_LENGTH);
CCHmac(kCCHmacAlgSHA256, [keyData bytes], [keyData length], [inputData bytes], [inputData length], buffer);
NSData *nsdata = [NSData dataWithBytesNoCopy:buffer length:CC_SHA256_DIGEST_LENGTH freeWhenDone:YES];
NSUInteger capacity = nsdata.length * 2;
NSMutableString *sbuf = [NSMutableString stringWithCapacity:capacity];
const unsigned char *buf = nsdata.bytes;
NSInteger i;
for (i=0; i<nsdata.length; ++i) {
  [sbuf appendFormat:@"%02X", (NSUInteger)buf[i]];
}

return [Shared toHex:sbuf];

}`

Could you try with the latest version?

Going to close, please reopen if there is still an issue


Steamcache stops working after power loss

I have encountered this 2 times now. The first time i have deleted every container and image in docker and got it to work again.
This time i did the same but it didnt work.
I can see the containers when I do " docker container ls"
But when i try to download something it just waits and nothing happens.
I am looking at the log file with "sudo docker exec -it steam-cache tail -f /data/logs/access.log" and log there aswell.
Any help would be appriciated.
thanks

sudo docker run   --restart=always -d   --name steamcache-dns   -p <IP_ADDRESS>:53:53/udp   -e UPSTREAM_DNS=<IP_ADDRESS>   -e STEAMCACHE_IP=<IP_ADDRESS>  -e BLIZZARDCACHE_IP=<IP_ADDRESS>    steamcache/steamcache-dns:latest

sudo docker run   --restart=always -d   --name steam-cache   -v /home/goblin/cache/steam/data:/data/cache   -v /home/goblin/cache/steam/logs:/data/logs   -p <IP_ADDRESS>:80:80   steamcache/generic:latest

sudo docker run   --restart=always -d   --name blizzard-cache   -v /home/goblin/cache/blizzard/data:/data/cache   -v /home/goblin/cache/blizzard/logs:/data/logs   -p <IP_ADDRESS>:80:80   steamcache/generic:latest

sudo docker run  --restart=always -d   --name sniproxy   -p 443:443   steamcache/sniproxy:latest

The commands i am using to run is listed above.

I also did
To completely uninstall Docker:

Step 1

dpkg -l | grep -i docker
To identify what installed package you have:

Step 2

sudo apt-get purge -y docker-engine docker docker.io docker-ce
sudo apt-get autoremove -y --purge docker-engine docker docker.io docker-ce
The above commands will not remove images, containers, volumes, or user created configuration files on your host. If you wish to delete all images, containers, and volumes run the following commands:

sudo rm -rf /var/lib/docker
sudo rm /etc/apparmor.d/docker ---------- This didnt work.-------------
sudo groupdel docker
sudo rm -rf /var/run/docker.sock

And reinstalled again but still the same.

What is your output from docker ps


Add support for arrays in typed data

The typed data provided by this library is great. Would be awesome to add support for array types, ie string[].

This is implemented in #37


Use the same golang version for all projects

High-level description
By removing specific docker version in buildinfo.json, pkgpanda will use
dcos/dcos-builder.
https://github.com/dcos/dcos/blob/c9e43e3af91c54c4b3f13fb12c3b935a3517c276/pkgpanda/docker/dcos-builder/Dockerfile#L54-L56
https://golang.org/doc/go1.13
Corresponding DC/OS tickets (required)

DCOS_OSS-5517 Switch to go 1.13

Related tickets (optional)

DCOS-ID JIRA title / short description.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot changelog-not-required change build scripts

@mesosphere-mergebot changelog-not-required change build scripts

:wave: @drewvanstone @br-lewis @makkes @bamarni @rgo3  Can you review, please?

For historical purpose it'd be nice to explain why telegraf is pinned to Go 1.11 in the commit description.

@mesosphere-mergebot label Ready For Review


Missing error status codes according to MS Azure reference

Azurite is now missing error responses according to the reference.
For example, if the requested container is missing (was not created), the PUT BLOB API requests fails only with the response code 404 Not found, but it should be another error message:
PUT BLOB REST API: https://docs.microsoft.com/en-us/rest/api/storageservices/put-blob
Common REST API Error codes: https://docs.microsoft.com/en-us/rest/api/storageservices/common-rest-api-error-codes
ContainerNotFound | Not Found (404) | The specified container does not exist.

Instead, it returns only
Response 404 Not Found

This response is hard to decode, that the Container does not exist.

I think I fixed this a while back in the dev branch... if not, we should not have too much effort to correct it.

resolved in v3


Add Koyeb provider to package list

Hi there 👋
I'm opening a PR for adding the Koyeb Pulumi provider.
Thanks!

Hello @edouardb, may I ask to create a new release which contains your docs folder in the git tag? Version 0.1.6 on your Git repo doesn't contain this yet.

Should be fixed

@edouardb thanks for the swift response. The PR is merged, but there are a few more steps on our side to have this become available in the registry itself. Give it a day, 2 max.

Awesome! Thanks @ringods.


flood-color and flood-opacity misspelled

Attribute names "flood-color" and "flood-opacity" are misspelled.

not sure why this isn't fixed its literally 1.9 seconds of work.

Just do the 1.9 seconds of work then, and submit it as a PR. That's how things work round here.


evaluation code missing

Hi, thanks for your work!
Evaluation code seems missing. Any reason for that?
To reproduce the main table of the paper I should take the checkpoints, train the probes, and code an evaluation loop, right?
What would you do if you had to reproduce table 1?

Also looking for this.

Hi, I am also interested in the evaluation code to reproduce Table 1 results!


hello.js prints undefined?

just init hello
cd hello
just build
time ./hello

output: undefined
version used: 0.0.22

just eval "just.print(just.memoryUsage().rss)" works tho
9187328

but after creating new project, it shows this error:
build blabla 0.0.22 (just.js) g++ -c -fno-exceptions -ffunction-sections -fdata-sections  -DJUST_VERSION='"0.0.22"' -std=c++17 -DV8_COMPRESS_POINTERS -I. -I./deps/v8/include -O3 -march=native -mtune=native -Wpedantic -Wall -Wextra -flto -Wno-unused-parameter just.cc
g++ -c -fno-exceptions -ffunction-sections -fdata-sections  -std=c++17 -DV8_COMPRESS_POINTERS -I. -I./deps/v8/include -O3 -march=native -mtune=native -Wpedantic -Wall -Wextra -flto -Wno-unused-parameter main.cc
g++ -s -static -flto -pthread -m64 -Wl,--start-group deps/v8/libv8_monolith.a main.o just.o builtins.o modules/sys/sys.o modules/fs/fs.o modules/net/net.o modules/vm/vm.o modules/epoll/epoll.o -Wl,--end-group -Wl,--gc-sections  -ldl -lrt -o blabla
/usr/bin/ld: /tmp/blabla.pU5vnP.ltrans0.ltrans.o: in function `_sub_I_65535_0.8055':
<artificial>:(.text.startup+0xb7): undefined reference to `_binary_blabla_js_end'
/usr/bin/ld: <artificial>:(.text.startup+0xbe): undefined reference to `_binary_blabla_js_start'
/usr/bin/ld: /tmp/blabla.pU5vnP.ltrans2.ltrans.o: in function `main':
<artificial>:(.text.startup+0x1e9): undefined reference to `_binary_blabla_js_start'
/usr/bin/ld: <artificial>:(.text.startup+0x1f7): undefined reference to `_binary_blabla_js_end'
collect2: error: ld returned 1 exit status
make: *** [Makefile:87: main-static] Error 1
failed in 4.6 sec

yes. it looks like a couple of bugs here. there's a lot of things that need to be fixed and will have a roadmap for a stable release soon. looks like the code here is out of date: https://github.com/just-js/just/blob/main/lib/build.js#L311.
and if you do
just build --clean

it should resolve the issue with the missing symbols. i'll have a fix for this out shortly.

closing this as these issues should be resolved in upcoming 0.1.2 release


📖 Add high memory version of RStudio 4.4.0

User Story
As a data engineer
I need a version of the latest RStudio with higher memory
So that I can run various jobs that require more than the standard amount
Value / Purpose
Various users have requested a high memory version of RStudio for various use cases.
Useful Contacts
@jamesstottmoj
User Types
No response
Hypothesis
No response
Proposal
Provide a 4.4.0 version with more memory, in a similar vein to 4.1.2 (24 GB)
Additional Information
No response
Definition of Done

[ ] 24 GB version of 4.4.0 RStudio available to use

Created new release. Left as restricted release for now to test


python38Packages.teslajsonpy: 0.19.0 -> 0.21.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.teslajsonpy is: "Python library to work with Tesla API"
meta.homepage for python38Packages.teslajsonpy is: "https://github.com/zabuldon/teslajsonpy"
meta.changelog for python38Packages.teslajsonpy is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.21.0 with grep in /nix/store/wz2hldxl6f7wvqyihxx9mi7wg2z4pgzx-python3.8-teslajsonpy-0.21.0

found 0.21.0 in filename of file in /nix/store/wz2hldxl6f7wvqyihxx9mi7wg2z4pgzx-python3.8-teslajsonpy-0.21.0

directory tree listing: https://gist.github.com/0f6a8f70140667fb92fec7ec4d94faa1

du listing: https://gist.github.com/8769b214550e9254aace36afac1c17a4

Rebuild report (if merged into master) (click to expand)

8 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python38Packages.teslajsonpy
python39Packages.teslajsonpy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wz2hldxl6f7wvqyihxx9mi7wg2z4pgzx-python3.8-teslajsonpy-0.21.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.teslajsonpy https://github.com/r-ryantm/nixpkgs/archive/7447deadf53bb98b6ebacea46469159a49e2730f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wz2hldxl6f7wvqyihxx9mi7wg2z4pgzx-python3.8-teslajsonpy-0.21.0
ls -la /nix/store/wz2hldxl6f7wvqyihxx9mi7wg2z4pgzx-python3.8-teslajsonpy-0.21.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python38Packages.teslajsonpy
python39Packages.teslajsonpy

Maintainer pings
cc @fabaff for testing.

Result of nixpkgs-review pr 138100 at 7447dead run on aarch64-linux 1

2 packages built successfully:

python38Packages.teslajsonpy
python39Packages.teslajsonpy

1 suggestion:

warning: unused-argument
Unused argument: fetchpatch.
Near pkgs/development/python-modules/teslajsonpy/default.nix:8:3:
  |
8 | , fetchpatch
  |   ^


charging-set-amps behaves different via BLE than via FleetAPI

When setting/calling charging-set-amps 1 via FleetAPI the vehicle charges with exactly 1A.
Doing the same via BLE, it charges with 2A. I wasn't able to figure out how to limit the current to only 1A.
Bug? Feature?

I have observed that Tesla vehicles don't report the charging amps correctly when below 5A. Perhaps that is related?

I believe @jbanyer is correct; it looks like vehicles don't allow setting the charging rate to below 5A. I see 5A in the charging tab when I send a BLE command to charge at 2A. What model are you using, @int2001? Where are you seeing the 1A (Fleet API) and 2A (BLE) being reported?

Using Model 3 here.
Saw the 2A at my measuring device connected between Grid and Wallbox.
Let me try to reproduce it.
BTW: Yesterday i was wondering about the fact that it was really charging with 1A. But that was the first time.
All tries before ended in:

Setting car to 1A (via BLE)
Measuring-device was never below 2A (watched it for about 2h)
iOS-App showed 5A (when doing the same via Fleet-API it shows correctly 1A)

From what I've read the minimum limit in the app is 5A because below 5A losses become significant portion of the drawn energy, i.e. the MCU should be powered on and the car to be awake. This will account for those 200 Watts (1 Amp) extra your measuring device is reporting. The Model 3, when awake, is drawing about 300 Watts from the low voltage battery and when connected to the grid, it'd prefer to power itself from the grid.

You're probably charging from low voltage (120V) and/or a low phase count (1), right?
Because with 3 phases at 230V, I do get about 1.1 A measured by the wallbox after setting 1 A on the car over BLE.

I haven't been able to reproduce this. BLE/FleetAPI should only affect the transport layer and type of authentication used; the message payload and vehicle-side code are transport agnostic. Additionally, the vehicle-side code appears to enforce a 5A floor. @int2001 could you please provide debug logs from sending the Fleet API command and confirm the current limit that appears in the vehicle UI Charging tab?

Fwiw: in https://github.com/evcc-io/evcc/issues/13007 we've found, that setting vehicle current below 5A (over HTPT) is often ignored on first API call. Once call is repeated or current already is below 5A, it seems to work. So there is definitely something fishy in the stack with lower charge currents.

Tesla charge on Solar regularly sets charging_amps below 5A.
I too find I need to call the endpoint twice to set a value less than 5A.
With UMC if I set charging_amps to 0A, it will stop all charging which is useful.
With TWC gen 2/gen 3, it doesn't stop charging and sits at 1-2 A


Make OnHeapIncrementalIndex clean maps on close()

Related to https://github.com/druid-io/druid/pull/2149 this PR tries to help make sure any accidental references to an incremental index after its close() method is called has minimal memory impact.

ServiceAnnouncerTest.testServiceAnnouncement:55->createAndAnnounceServices:102 » ConnectionLoss

@drcrallen why did this come up? It seems like the real problem is that something is keeping around indexes that it shouldn't be keeping around…

@gianm https://github.com/druid-io/druid/pull/2149#discussion_r48765961
Mostly because it is easy to screw up keeping indexes around. I had a similar problem in the spark batch indexer because I was handling the reference to the incremental index in an inefficient manner. It is a very easy mistake to make, and this change is intended to minimize its impact. Though yes, you are correct, having the incremental index object itself garbage collected properly is the preferred route.

:+1:,Looks good to me.  this can be merged unless @gianm has any more comments ?

+1

IncrementalIndex also has some data structures to be cleaned up on close. But that's all tiny and can be handled in #2169 after this is merged. +1 for me.


web-eid-app for NixOS: pin1 works, pin2 don't

NixOS comes with the package web-eid-app and instructions for Estonians .
With Firefox and the above config for NixOS 23.11, I can authenticate with e.g. https://lhv.ee but I can not sign. Any ideas?
I know, you do not officially support NixOS, but maybe some of you uses it and can help. Here my config:
services.pcscd.enable = true;
programs.firefox.enable = true;
programs.firefox.nativeMessagingHosts.packages = [ pkgs.web-eid-app ];
programs.firefox.policies.SecurityDevices.p11-kit-proxy = "${pkgs.p11-kit}/lib/p11-kit-proxy.so";
environment.etc."chromium/native-messaging-hosts/eu.webeid.json".source = "${pkgs.web-eid-app}/share/web-eid/eu.webeid.json";
environment.etc."opt/chrome/native-messaging-hosts/eu.webeid.json".source = "${pkgs.web-eid-app}/share/web-eid/eu.webeid.json";
environment.etc."pkcs11/modules/opensc-pkcs11".text = ''
  module: ${pkgs.opensc}/lib/opensc-pkcs11.so
'';

Is this related to #309 ?

What error do you see?
Can you please turn on native app logging as described here: https://web-eid.eu/ > Debugging and logs and check the log?

When I press [Authenticate] on  https://web-eid.eu/ I get (in pink color):
Authentication failed

[Code]
ERR_WEBEID_EXTENSION_UNAVAILABLE

[Message]
Web-eID extension is not available

Strangely I can authenticate with https://lhv.ee.
After login in into the bank, there is still no log file:
In ~/.local/share/RIA/ is no web-eid.log.
When I start the binary from the console, I get:
$ web-eid
INFO: "web-eid" app "2.4.0+0" running in command-line mode

Now the log file is created with the contents:
024-03-25T13:11:44.212Z INFO src/controller/controller.cpp:72:void Controller::run() - "web-eid" app "2.4.0+0" running in command-line mode

Is web-eid known to the firefox browser?

It looks like the extension is not installed in Firefox. Here's how it should look:

You can add the extension manually from here:
https://addons.mozilla.org/en-US/firefox/addon/web-eid-webextension/

It seem it is a NixOS firefox package related problem. I do not manage enable the extension. It does not even show in the browser tab (cf. your screenshot) above. If I get it work, I leave a note here. Thank you so far.

No log entry in web-eid.log, but I can start the app from the command line.

@getreu just in case  check "Security Devices" section of Firefox settings.

Maybe You have to add (or unload and then load again)  "onepin-opensc-pkcs11.so", this file can be located in different folder.

@sergey-abc  I have this:

Summary of my efforts. Please correct where I am wrong.
Installation

Install the web-eid-app package in NixOS
Insert in configuration.nix:
 packages = with pkgs; [
   firefox-esr
   web-eid-app
   p11-kit
   opensc

 ];

and below:
services.pcscd.enable = true;
programs.firefox.enable = true;
programs.firefox.package = pkgs.firefox-esr;
programs.firefox.nativeMessagingHosts.packages = [ pkgs.web-eid-app ];
programs.firefox.policies.SecurityDevices.p11-kit-proxy = "${pkgs.p11-kit}/lib/p11-kit-proxy.so";
# Authentification
environment.etc."pkcs11/modules/opensc-pkcs11".text = ''
  module: ${pkgs.opensc}/lib/opensc-pkcs11.so
'';

Enable logging (for testing only)

Enable logging:
echo 'logging=true' > ~/.config/RIA/web-eid.conf

Check success:
web-eid

A dialogue About Web eID window appears. Click on [Cancel].
cat /.local/share/RIA/web-eid/web-eid.log

You should see something like:
2024-03-31T06:56:42.804Z INFO src/controller/controller.cpp:72:void Controller::run() - "web-eid" app "2.4.0+0" running in command-line mode

Install the browser extension within Firefox from
Web eID – Get this Extension for Firefox (en-US)

Link the web-eid manifest into the browser configuration
mkdir -p ~/.mozilla/native-messaging-hosts/
cd ~/.mozilla/native-messaging-hosts/
ln -s $(dirname $(dirname $(realpath $(which web-eid))))/share/web-eid/eu.webeid.json .

Check success

Enable logging:
Insert Estionan ID card.
Check with DigiDoc that the card reader works and the ID card reader and
driver works. (Ok)
Goto https://web-eid.eu/ and click on [Authenticate].

Result
Unfortunately, I get the following error page in the browser:
Authentication failed
[Code]
ERR_WEBEID_NATIVE_UNAVAILABLE
[Message]
a message from native application was expected, but native application closed connection

Furthermore, no log message in /.local/share/RIA/web-eid/web-eid.log.

I also filed an issue here: https://github.com/NixOS/nixpkgs/issues/300435

Great, the extension is enabled now. Please try on https://web-eid.eu/, Firefox is probably unable to locate the native app.

Thanks for your thorough investigation! The ERR_WEBEID_NATIVE_UNAVAILABLE message indicates that Firefox is unable to  locate the native messaging host.
Please check that the native messaging manifest file has the following content:
{
"name": "eu.webeid",
"description": "Web-eid native application",
"path": "/usr/bin/web-eid",
"type": "stdio",
"allowed_extensions": [ "{e68418bc-f2b0-4459-a9ea-3e72b6751b07}" ]
}

Verify the value of allowed_extensions and that /usr/bin/web-eid exists.
If the content is correct, linking the file to ~/.mozilla/native-messaging-hosts/ should indeed work according to https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_manifests#linux. Can you check the symlink just in case or even copy the file in case Firefox does not follow symlinks for some reason? If you still get ERR_WEBEID_NATIVE_UNAVAILABLE when trying to authenticate on <web-eid.eu>, then please try the global locations listed in https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_manifests#linux, start from  /usr/lib/mozilla/native-messaging-hosts/eu.webeid.json.

@mrts
The manifest was the problem.
In the manual above, I replaced the line:
ln -s "$(dirname $(dirname $(realpath $(which web-eid))))/share/web-eid/eu.webeid.json" .

with
ls -s "$(dirname $(dirname $(realpath $(which web-eid))))/lib/mozilla/native-messaging-hosts/eu.webeid.json" .

I edited the above.
And authentification and signing works. Thank you a lot!

Tested working procedure:
Installation

Install the web-eid-app package in NixOS
Insert in configuration.nix:
 packages = with pkgs; [
   firefox-esr
   web-eid-app
   p11-kit
   opensc

 ];

and below:
services.pcscd.enable = true;
programs.firefox.enable = true;
programs.firefox.package = pkgs.firefox-esr;
programs.firefox.nativeMessagingHosts.packages = [ pkgs.web-eid-app ];
programs.firefox.policies.SecurityDevices.p11-kit-proxy = "${pkgs.p11-kit}/lib/p11-kit-proxy.so";
# Authentification
environment.etc."pkcs11/modules/opensc-pkcs11".text = ''
  module: ${pkgs.opensc}/lib/opensc-pkcs11.so
'';

Enable logging (for testing only)

Enable logging:
echo 'logging=true' > ~/.config/RIA/web-eid.conf

Check success:
web-eid

A dialogue About Web eID window appears. Click on [Cancel].
cat /.local/share/RIA/web-eid/web-eid.log

You should see something like:
2024-03-31T06:56:42.804Z INFO src/controller/controller.cpp:72:void Controller::run() - "web-eid" app "2.4.0+0" running in command-line mode

Install the browser extension within Firefox from
Web eID – Get this Extension for Firefox (en-US)

Link the web-eid manifest into the browser configuration
mkdir -p ~/.mozilla/native-messaging-hosts/
cd ~/.mozilla/native-messaging-hosts/
ls -s "$(dirname $(dirname $(realpath $(which web-eid))))/lib/mozilla/native-messaging-hosts/eu.webeid.json" .

Check success

Enable logging:

Insert Estionan ID card.

Check with DigiDoc that the card reader works and the ID card reader and
driver works. (Ok)

Goto https://web-eid.eu/ and click on [Authenticate].
Type pin1, you should see:
Digital signing
Welcome, XXX XXX!

Press the button [Sign document], then type pin2, you should see:
  Digital signing
  Welcome, XXX XXX!
  Signature added: example-for-signing.asice

Addendum
The lines
mkdir -p ~/.mozilla/native-messaging-hosts/
cd ~/.mozilla/native-messaging-hosts/
ls -s "$(dirname $(dirname $(realpath $(which web-eid))))/lib/mozilla/native-messaging-hosts/eu.webeid.json" .

are a workaround until #281710 is fixed.

Jens Getreu's blog - Sign with your Estonian ID card under NixOS


Add permissions section to ci-build.yml for write access

The changes in the ci-build.yml file introduce a new permissions section. This section grants the workflow write access to the repository contents and packages. This is useful for workflows that need to modify repository files or manage packages as part of their execution.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (5823a14) to head (02a0d17).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          235       235
  Branches        37        37
=========================================
  Hits           235       235

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


What is this TODO in the CLI?

https://github.com/biglocalnews/WARN/blob/main/warn/cli.py#L69

Add an option to run all states at once


Creating a custom resource definition works on 1.7 and fails on 1.8 with 4.0 client

I'm using python-client 4.0.0 and Kubernetes server 1.8.0 on minikube. I'm creating a custom resource definition using the kubernetes.client.ApiextensionsV1beta1Api.create_custom_resource_definition() API.
This calls the following rest endpoint:
https://<IP_ADDRESS>:8443/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions
with the following body:
{
  'apiVersion': 'apiextensions.k8s.io/v1beta1',
  'kind': 'CustomResourceDefinition',
  'metadata': {
    'name': 'alertmanagers.monitoring.coreos.com'
  },
  'spec': {
    'group': 'monitoring.coreos.com',
    'version': 'v1',
    'scope': 'Namespaced',
    'names': {
      'plural': 'alertmanagers',
      'singular': 'alertmanager',
      'kind': 'AlertManager'
    }
  }
}

With Kubernetes 1.8.0, I get the following response:
{
    "kind": "CustomResourceDefinition",
    "apiVersion": "apiextensions.k8s.io/v1beta1",
    "metadata": {
        "name": "alertmanagers.monitoring.coreos.com",
        "selfLink": "/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions/alertmanagers.monitoring.coreos.com",
        "uid": "898234e4-df84-11e7-b925-6275c77a1d00",
        "resourceVersion": "6604",
        "generation": 1,
        "creationTimestamp": "2017-12-12T21:36:39Z"
    },
    "spec": {
        "group": "monitoring.coreos.com",
        "version": "v1",
        "names": {
            "plural": "alertmanagers",
            "singular": "alertmanager",
            "kind": "AlertManager",
            "listKind": "AlertManagerList"},
        "scope": "Namespaced"
    },
    "status": {
        "conditions": null,
        "acceptedNames": {"plural": "", "kind": ""}
    }
}

which generates the following error in the python client:
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/apis/apiextensions_v1beta1_api.py", line 57, in create_custom_resource_definition
    (data) = self.create_custom_resource_definition_with_http_info(body, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/apis/apiextensions_v1beta1_api.py", line 136, in create_custom_resource_definition_with_http_info
    collection_formats=collection_formats)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 321, in call_api
    _return_http_data_only, collection_formats, _preload_content, _request_timeout)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 163, in __call_api
    return_data = self.deserialize(response_data, response_type)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 236, in deserialize
    return self.__deserialize(data, response_type)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 276, in __deserialize
    return self.__deserialize_model(data, klass)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 620, in __deserialize_model
    kwargs[attr] = self.__deserialize(value, attr_type)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 276, in __deserialize
    return self.__deserialize_model(data, klass)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/api_client.py", line 622, in __deserialize_model
    instance = klass(**kwargs)
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/models/v1beta1_custom_resource_definition_status.py", line 53, in __init__
    self.conditions = conditions
  File "/usr/local/lib/python3.6/site-packages/kubernetes/client/models/v1beta1_custom_resource_definition_status.py", line 101, in conditions
    raise ValueError("Invalid value for `conditions`, must not be `None`")
ValueError: Invalid value for `conditions`, must not be `None`

Kubernetes 1.7.5 returns the following:
{
    "kind": "CustomResourceDefinition",
    "apiVersion": "apiextensions.k8s.io/v1beta1",
    "metadata": {
        "name": "alertmanagers.monitoring.coreos.com",
        "selfLink": "/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions/alertmanagers.monitoring.coreos.com",
        "uid": "9c8a122b-df8b-11e7-b6e4-ca244fafa171",
        "resourceVersion": "1730",
        "creationTimestamp": "2017-12-12T22:27:17Z"
    },
    "spec": {
        "group": "monitoring.coreos.com",
        "version": "v1",
        "names": {
            "plural": "alertmanagers",
            "singular": "alertmanager",
            "kind": "AlertManager",
            "listKind": "AlertManagerList"},
        "scope": "Namespaced"
    },
    "status": {
        "conditions": [],
        "acceptedNames": {"plural": "", "kind": ""}
    }
}

This works just fine. The difference is in the return value of the conditions field
Now, there are a few things going on here:

The server is returning a different value, [] for 1.7.5 and null for 1.8.0.
The swagger doc says both of these fields are required, but the server returns empty values.
If the swagger doc was correct (which I doubt it is), the code generation may be wrong. I suppose it's open to interpretation. I don't think an empty array fulfills a "required value". The same applies to the empty strings for the plural and kind members of the acceptedNames dict. This really indicates no value, but the swagger says it's required.

This could possibly be split into separate issues. Let me know what's best in this case. Thanks!

It looks like kubernetes 1.7 made the statement that nulls and empty arrays should be treated the same: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.7.md#known-issues
This also related to this open bug: https://github.com/kubernetes-incubator/client-python/issues/376

dup of #376


NL/Explore: fix some bugs, improve layout

Add a highlight chart alongside single-var timeline
Fix for the [highest gini index in the world] query in NL
Fix query wordings per Guha's suggestion

Thanks Jehangir!


Added logic to disable mandatory column's checkboxes

In the continuation of the discussion started in the components forge page, please find below the required code for this functionality.
What was happening

The Data Grid is missing the ability to avoid the end-user from hiding a specific column, by making the check box of the respective column disabled, as the image below shows:

What was done

A new boolean field was added to the optional configs structure
This new boolean will then set the check box of that column as disabled throught the 'formatItem' callback.
That will add disabled attribute to the checkboxes of the items that are being passed with the property 'isRequired' as true

Test Steps

after update outsystems module, pass a column with the parameter 'isRequired' as 'true' and other(s) as 'false'
use the column picker and note that the columns that were passed with 'isRequired' property as true have the checkboxes disabled, so the column cannot be hidden from the grid.

Checklist

[x] tested locally
[ ] documented the code
[ ] clean all warnings and errors of eslint
[x] requires changes in OutSystems (if so, provide a module with changes) => just pass a new input for columns 'isRequired' and and it to the column options so it can be checked in JS ListBox class as column.isRequired
[ ] requires new sample page in OutSystems (if so, provide a module with changes)

@rmadeiraneto I took the liberty to improve the description of your PR.

Thank you for your contribution @rmadeiraneto.
We'll include your suggestion in our code base with minor changes.

If you would be interested, small changes were done to your code, and can be checked in this PR.


how to compute bounds for function layer of pg_tileserv

┆Issue is synchronized with this Wrike task by Unito

I think this issue is no longer needed


UI - Provide a way to show all the tools used in the chat threads.

~Currently in the chat view , I am not able to tell with what assistants the threads were initially launched with.
Right now, I would be able to get this info if I select the thread and go to the very first message from the assistant were its name is provided which is very inconvenient.~
Edit: The above is coverd in #65. I am keeping this around for just the tools bit below
Also it would be very helpful to show the list of tools this thread is currently using (tools that came from the assistant and the the dynamically added tools ).

The assistant name part is cover in #65. I am editing this to just be about tools

This is in

Tested with electron build - a8d8c5c39b3d
All the features requested for in this issue is available.


Merge feature-key-code-update branch

Summary of the changes on this branch:

getKeyboardResponse function now only takes key character/string instead of allowing numeric key codes, and returns the response as a string (event.key)
all KEYCODE parameter types are now KEY in jspsych.js and plugin.info
the convertKeyCharacterToKeyCode, convertKeyCodeToKeyCharacter, and compareKeys pluginAPI functions have been removed from the docs
the convertKeyCharacterToKeyCode, convertKeyCodeToKeyCharacter, and compareKeys pluginAPI functions are still in jspsych.js but will show a console.warn message saying that they will be removed in future releases
any calls to the convertKeyCharacterToKeyCode, convertKeyCodeToKeyCharacter, and compareKeys pluginAPI functions have been removed from all files
the descriptions of all key-related trial parameters (choices, key_forward/backward, key_answer, etc.) have been updated in the documentation pages and plugin.info to clarify that keys must be specified as strings
the descriptions of all key-related data (key_press, etc.) have been updated in the documentation to clarify that the key response will be saved as a string
numeric key codes passed to key-related trial parameters (choices, key_forward/backward, key_answer, etc.) have been changed to strings in all example HTML files and documentation examples
any uppercase key strings have been changed to lowercase in all example HTML files, documentation examples, and default parameter values, and instructions/prompts about which key to press have also been changed to lowercase
in RDK plugin, default choices changed from [] to jsPsych.ALL_KEYS
in RDK plugin, the plugin still checks whether correct_choice is given as a string or number, but a console.error is shown if it's numeric
minor corrections to documentation and parameter descriptions in plugins
minor corrections to example HTML files to fix problems caused by earlier changes to image-* plugins (render as canvas vs img, change image width via parameter rather than CSS, preload images if necessary)

Note
Sorry about all of the unintentional formatting/spacing changes to markdown files. I think these were automatic changes caused by the editor (I opened them in Typora instead of VS code). I don't think these changes affect the way the docs look: you can see what the jspsych-core.md file looks like here. But I can try to undo these changes if they're a problem.
Question
Key strings will now be case-sensitive representations of the key that was pressed, so if someone is holding down the shift key or has caps lock on, then their response will be e.g. 'A' rather than 'a'. I don't think this was an issue before, because these two key presses would've had the same numeric key codes (at least I'm pretty sure that's the case, based on some quick tests on the master branch). This is why I changed the letter case in example HTML files and plugin defaults.
Do we want to do anything else about this? Mention it somewhere in the documentation? Add a case_sensitive flag to getKeyboardResponse that tells jspsych whether or not to convert to lowercase before returning the key response?

Forgot to mention changes to the test files:

switched from numeric key codes to key strings in calls to utils.pressKey
changed key-related trial parameter values from numeric to string
keyboard events passed to disbatchEvent now use key instead of keyCode
the tests for convertKeyCharacterToKeyCode, convertKeyCodeToKeyCharacter, and compareKeys pluginAPI functions have NOT been removed

Sorry about all of the unintentional formatting/spacing changes to markdown files. I think these were automatic changes caused by the editor (I opened them in Typora instead of VS code). I don't think these changes affect the way the docs look: you can see what the jspsych-core.md file looks like here. But I can try to undo these changes if they're a problem.

No problem. It's kinda nice that the editor formats the table columns! Maybe there is a VS Code plugin that will do this too :grin:

Key strings will now be case-sensitive representations of the key that was pressed, so if someone is holding down the shift key or has caps lock on, then their response will be e.g. 'A' rather than 'a'. I don't think this was an issue before, because these two key presses would've had the same numeric key codes (at least I'm pretty sure that's the case, based on some quick tests on the master branch). This is why I changed the letter case in example HTML files and plugin defaults. Do we want to do anything else about this? Mention it somewhere in the documentation? Add a case_sensitive flag to getKeyboardResponse that tells jspsych whether or not to convert to lowercase before returning the key response?

Yeah, I was maybe less worried about this than I should be. I forgot that CAPS LOCK would mess things up quite a bit. For example, a participant might be totally confused why the experiment says press Q and they are pressing Q with caps lock inadvertently on and the experiment doesn't work.
I think adding a case_sensitive flag to getKeyboardResponse doesn't help from a practical perspective because every plugin would have to handle this on a case by case (hah) basis.
But maybe adding a flag to jsPsych.init and then passing that flag to getKeyboardResponse solves the practical side of this. I imagine that a default value of true is what most researchers would expect, but there might be special cases where turning that off is appropriate. Does that sound reasonable?

on a case by case (hah) basis.

😁

a participant might be totally confused why the experiment says press Q and they are pressing Q with caps lock inadvertently on and the experiment doesn't work.

Yep this is what I'm worried about.

But maybe adding a flag to jsPsych.init and then passing that flag to getKeyboardResponse solves the practical side of this. I imagine that a default value of true is what most researchers would expect, but there might be special cases where turning that off is appropriate. Does that sound reasonable?

Yeah that makes sense to me. I'll add this in to jspsych.js, update the docs, add a test, and push the changes here.
If the plugin only records the first valid response and all keys are valid (jsPsych.ALL_KEYS), then the case_sensitive flag will only affect key responses where either CapsLock was turned on or Shift was held down before the trial starts. If either CapsLock or Shift are pressed during the trial, then these keys will be recorded as the response because they're considered valid (same as in previous jsPsych versions). Whereas if only certain keys are valid (e.g. choices: ['a']), then the case_sensitive flag will also have an effect when Shift or CapsLock is pressed during the trial.
NumLock will change number pad responses in a similar way to CapsLock, but I don't know of an easy way of handling that. We could map it out manually (e.g. 1 = End, 2= ArrowDown, 3 = PageDown) but I don't know if that mapping can differ across keyboards?
Apart from Shift, CapsLock and NumLock, I can't think of any other situations where the key response that's recorded might differ from what the user intended and/or the researcher expects. Let me know if you can think of any other test cases!

NumLock will change number pad responses in a similar way to CapsLock, but I don't know of an easy way of handling that. We could map it out manually (e.g. 1 = End, 2= ArrowDown, 3 = PageDown) but I don't know if that mapping can differ across keyboards?

Yeah, I don't know if there is an easy solution for this. Since many keyboards don't even have the numpad I think it's not a use case we need to worry about too much. Let's ignore it for now and address it if the need arises. If there's a reasonable place to talk about this in the docs we could do that, but we don't need to force it.

@jodeleeuw I updated this with the following:

added the case_sensitive_responses parameter to jsPsych.init The default is false, which means that keyboard responses should NOT be case sensitive. Specifically, a key choice parameter value of 'A' will be treated as 'a', and a response of 'A' will be treated/stored as 'a'. If case_sensitive_responses is true, then 'a' and 'A' are treated as different response options and different responses.
added docs, example file, and tests for the new case_sensitive_responses parameter.

I think this is now ready to merge.


Massive lemurs.client.log file for compositor error

For the second time in a few months of usage i've run into this issue now, and that is having an infinite growing /var/log/lemurs.client.log file, at the moment is at about 40GBs.
The file as far as i can see is just this message:
[ 06/24/2023 09:48:49.887 redirect_start FATAL ERROR ] Another composite manager is already running (and does not handle _NET_WM_CM_Sn correctly)
Logged about 10 times per milliseconds.
Now the core issue is probabily in my i3 config file or in picom itself since it's the only composite manager i have and i had in fact two instance of picom running and killing the second stopped the file from growing. But i do belive this should not be generating such a massive file in less than 6 hours.

Yeah, oops :sweat_smile:. That is clearly not what we want.
If I understand correctly, this is just from one session? As in, if you restart the computer, the file is empty again and starts growing from 0GBs once more?
Anyway, I think I know how to fix this. I will take a look at fixing this soon.

If I understand correctly, this is just from one session? As in, if you restart the computer, the file is empty again and starts growing from 0GBs once more?

I can't be 100% sure because i noticed only when the disk usage was already at 95+% so i removed the file manually, but if i had to guess i'd say yes since it's very likely it already happened in the past, maybe for shorter sessions, and i did not notice it. Thank you for the quick answer!


Add support for production mode

Acceptance criteria:

Vaadin must say it's running in production mode
No node_modules folder is populated; the pnpm machinery is not running at all.

Checklist:

[X] Make sure the production mode works correctly with a skinny jar (jar with dependencies in the lib/ folder)
[x] Test with uber-jar

Verified that the production mode is working correctly with uber-jar as well, as of git commit 24024cf1c7ab1ee34a5985889ff3a457f9ab07fa

Verified that the production mode is working correctly with uber-jar as well, as of git commit 24024cf1c7ab1ee34a5985889ff3a457f9ab07fa


issue when building universe server locally

Hello,
I am seeing an issue when building universe server locally.
I clone the mesosphere/universe github repo and then I follow the instructions in the README:

I validate and build the universe artifacts
scripts/build.sh

I build the universe server docker image
DOCKER_TAG="mesosphere-universe" docker/server/build.bash

Now, I run the docker image generated in my machine:
docker run -dit -p 8080:80 mesosphere/universe-server:mesosphere-universe
The problem comes here. When I browse to: 'http://:8080/repo', I download a repo.zip file and unzip it.
In repo/packages/C/confluent-connect, I would expect to see all available versions 0,1,2,3, but I only see version 0.
It seems it is not adding all the versions where 'minDcosReleaseVersion' is set to '1.8'.
Is this the expected behavior? Because from the README I understand that http://:8080/repo would serve all the packages suitable for DCOS 1.8+.
When I browse to: 'http://:8080/repo-1.7', I see the same content in repo/packages/C/confluent-connect, only 0 folder, but this is what I would expect, as this repo should only contain packages suitable for DCOS 1.7.
Am I doing anything wrong? Am I not understanding the README correctly?

That's not the correct way to install an offline repo. You shouldn't browse
to that address or download a zip file, but rather add the repo address as
a new repository either in system/repositories in the DC/OS UI (or
with dcos package repo add [--index=]   from
the CLI).
On Thu, Dec 22, 2016 at 8:12 AM, Antonio Alfonso Pujante <
<EMAIL_ADDRESS>wrote:

Hello,
I am seeing an issue when building universe server locally.
I clone the mesosphere/universe github repo and then I follow the
instructions in the README:

I validate and build the universe artifacts
scripts/build.sh
I build the universe server docker image
DOCKER_TAG="mesosphere-universe" docker/server/build.bash
Now, I run the docker image generated in my machine:
docker run -dit -p 8080:80 mesosphere/universe-server:mesosphere-universe
The problem comes here. When I browse to: 'http://:8080/repo', I download
a repo.zip file and unzip it.
In repo/packages/C/confluent-connect, I would expect to see all available
versions 0,1,2,3, but I only see version 0.
It seems it is not adding all the versions where 'minDcosReleaseVersion'
is set to '1.8'.
Is this the expected behavior? Because from the README I understand that
http://:8080/repo would serve all the packages suitable for DCOS 1.8+.
When I browse to: 'http://:8080/repo-1.7', I see the same content in
repo/packages/C/confluent-connect, only 0 folder, but this is what I
would expect, as this repo should only contain packages suitable for DCOS
1.7.
Am I doing anything wrong? Am I not understanding the README correctly?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mesosphere/universe/issues/887, or mute the thread
https://github.com/notifications/unsubscribe-auth/AEEZTkHYhZQIZOXbMmLLto1c1i0r3ARKks5rKndNgaJpZM4LT97e
.

--
Fernando Sanchez
Sales Engineer
Mesosphere

Downloading the zip file was a quick way to check what is gonna be served when I add it to the cluster in either of the two ways you comment.
When I add the repo as you comment, I see the same behavior, the packages marked with  'minDcosReleaseVersion' equal to '1.8' are not listed in the universe list.
I have a 1.8.4 DC/OS cluster and I add the repo with priority 0 and url http;//:8080/repo

That doesn't look like a valid URL. It'd be
http://IP_address_of_the_node_where_your_offline_universe_repo_is_running:port
/repo
Please refer to:
https://docs.mesosphere.com/1.8/administration/installing/deploying-a-local-dcos-universe/
On Thu, Dec 22, 2016 at 9:36 AM, Antonio Alfonso Pujante <
<EMAIL_ADDRESS>wrote:

Downloading the zip file was a quick way to check what is gonna be served
when I add it to the cluster in either of the two ways you comment.
When I add the repo as you comment, I see the same behavior, the packages
marked with 'minDcosReleaseVersion' equal to '1.8' are not listed in the
universe list.
I have a 1.8.4 DC/OS cluster and I add the repo with priority 0 and url
http;//:8080/repo
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mesosphere/universe/issues/887#issuecomment-268811880,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEEZTsFvoMK6sZbk7LCQV09SDHg0aCjFks5rKor0gaJpZM4LT97e
.

--
Fernando Sanchez
Sales Engineer
Mesosphere

But I am not using an offline universe. I am using the instructions in the README of this repo to build a universe server locally.
In this way, a new docker image is created and I run it in my own system (which is reachable from the cluster), instead of running it inside the cluster itself, that is why I use my system ip and now the ip of a system inside the cluster.

Actually, you can serve an offline universe from a system outside the cluster, as long as it is reachable by the nodes in the cluster.

I am failing to follow. If you're deploying a universe on a docker image,
independently of whether that image is running, you are indeed running what
we call an offline universe. As opposed to using the "online universe" at
https://universe.mesosphere.com/repo
Please refer to:
https://docs.mesosphere.com/1.8/administration/installing/
deploying-a-local-dcos-universe/
On Thu, Dec 22, 2016 at 10:09 AM, Antonio Alfonso Pujante <
<EMAIL_ADDRESS>wrote:

Actually, you can serve an offline universe from a system outside the
cluster, as long as it is reachable by the nodes in the cluster.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mesosphere/universe/issues/887#issuecomment-268818791,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEEZToI4LoqykiHx77VBIO4LsYyxtnwyks5rKpLAgaJpZM4LT97e
.

--
Fernando Sanchez
Sales Engineer
Mesosphere

I am following this instructions from the README of this repo and I quote:
"Repository Consumption
In order for Universe to be consumed by DC/OS the build process needs to be run to create the Universe Server.
Universe Server
Universe Server is a new component introduce alongside packagingVersion 3.0. In order for Universe to be able to provide packages for many versions of DC/OS at the same time, it is necessary for a server to be responsible for serving the correct set of packages to a cluster based on the cluster's version.
All Pull Requests opened for Universe and the version-3.x branch will have their Docker image built and published to the DockerHub image mesosphere/universe-server. In the artifacts tab of the build results you can find docker/server/marathon.json which can be used to run the Universe Server for testing in your DC/OS cluster. For each Pull Request, click the details link of the "Universe Server Docker image" status report to view the build results.
Build Universe Server locally
Validate and build the Universe artifacts
scripts/build.sh
Build the Universe Server Docker image
DOCKER_TAG="my-package" docker/server/build.bash
This will create a Docker image universe-server:my-package and docker/server/target/marathon.json on your local machine
If you would like to publish the built Docker image, run
DOCKER_TAG="my-package" docker/server/build.bash publish
Run Universe Server
Using the marathon.json that is created when building Universe Server we can run a Universe Server in our DC/OS Cluster which can then be used to install packages.
Run the following commands to configure DC/OS to use the custom Universe Server (DC/OS 1.8+):
dcos marathon app add marathon.json
dcos package repo add --index=0 dev-universe http://universe.marathon.mesos:8085/repo
For DC/OS 1.7, a different URL must be used:
dcos marathon app add marathon.json
dcos package repo add --index=0 dev-universe http://universe.marathon.mesos:8085/repo-1.7"
So what I am doing is generating the docker universe server using my own tag with
'DOCKER_TAG="mesosphere-universe" docker/server/build.bash' as commented in your instructions.
And then instead of doing 'dcos marathon app add marathon.json' that basically tells marathon to create a docker in one of the nodes of the cluster to serve the universe, I run the docker in my machine with 'docker run -dit -p 8080:80 mesosphere/universe-server:mesosphere-universe'.
And finally I add the repository to the cluster pointing to my machine. And as explained in the README I would expect to see packages for 1.8, but this is not the case.


trivial: typos, grammar and missing links.

Fixed small typos, grammar, and missing links.

Thank you!

Thank you!

I came to your project while searching for Bosque examples :)


Shure MXCW wireless Conferencing System

Hi Guys,
I would love to have control over a few Shure systems products
Could you be so kind and set up file for this device???
I found some String Commands online that I attache here
MXCW_command-strings_en-US.pdf
Thanks in advance
Best
Huebi

Module is in betas


Better rate limited message.

Updates https://github.com/go-redis/redis/issues/222
@dim PTAL

LGTM overall, see few notes above. thanks, dim


Errors component should not render its wrapper component when there is no error

This is exactly the same issue as #266 however it now happens only on form root errors (for example on password match validation), ie on errors set at key "".

Thanks for reporting, can you spin up a quick www.esnextb.in if you get the chance to demonstrate the error with your use case so I can create accurate unit tests?

@zabojad This should fix the issue. Can you please confirm in 0.14.0?

@davidkpiano I confirm it works fine now with 0.14.0 :)!


Add documentation for using querySelector / $ after initialization

Let's say you use the data component. Since mdl.js will add dynamic components on the go, you can't register and event handlers to a checkbox of a data tables without a delay.$
What's the right way of doing this?

MDL emits a mdl-componentupgraded event on the DOM element that has been upgraded. You can add a listener and wait for that :)


Links with Shift-JIS characters in them come out mis-encoded

For example, if I have something like this
jsdom.env(
	"http://afo.wtrpg.com/omc_view.cgi?sort=index&index=crname",
	function (err, window) {
		var links = window.document.links;

		console.log(Array.from(links,link => link.href).slice(345,351).join("\n"));
	}
);

I expect
http://afo.wtrpg.com/omc_view.cgi?sort=crname&crname=%82%C2%82%A9PON
http://afo.wtrpg.com/omc_view.cgi?sort=crname&crname=%83s%83G%81[%83%8B
http://afo.wtrpg.com/omc_view.cgi?sort=crname&crname=%96^%8CN
http://afo.wtrpg.com/omc_view.cgi?sort=crname&crname=Yeti
http://afo.wtrpg.com/omc_view.cgi?sort=crname&crname=%88%BB%90%A3%82%DD%82%E4%82%AB

but instead get
http://afo.wtrpg.com/omc_view.cgi?sort=crname&crname=%E3%81%A4%E3%81%8BPON
http://afo.wtrpg.com/omc_view.cgi?sort=crname&crname=%E3%83%94%E3%82%A8%E3%83%BC%E3%83%AB
http://afo.wtrpg.com/omc_view.cgi?sort=crname&crname=%E6%9F%90%E5%90%9B
http://afo.wtrpg.com/omc_view.cgi?sort=crname&crname=Yeti
http://afo.wtrpg.com/omc_view.cgi?sort=crname&crname=%E7%B6%BE%E7%80%AC%E3%81%BF%E3%82%86%E3%81%8D

The modern jsdom API, documented in the readme, should take care of this much better; please give it a shot :)

Oh, wait, this is about URL querystring parsing. That's different. Yeah, we aren't doing the encoding override thing correctly yet.


.titleCase() shouldn't lower user's input capital case

as per title, for example user key in "CCTV distributor", it should convert to "CCTV Distributor" instead of "Cctv Distributor"

Why not just something like \b([a-z])(?!=[A-Z]) to avoid abbreviations?

Change case is only involved with converting cases between various forms, not supporting proper title case. It's unfortunate that this has created confusion and I would love to repair that, but for now it'll remain the same.

Fair enough, but I think the confusion arises from the fact that what this actually does is ‘Capitalise’ as opposed to actual title case.

Absolutely. And I'm definitely going to change it if the need for a 3.x arrises. Sorry for the confusion!


Force user to change password

Would be nice when admin create & notify user, add module like ":forceable" to force user change password when he login first time.

You could create that easily in your application with either a Warden hook or a before_filter, to check if that was the 1st time the user was signing in, and then redirect to a proper url to change user password. Shouldn't be hard, but I believe it's not something we should add to Devise itself. Thanks.

Hi,
i already created that before creating "issue" :) , just come to my mind as
idea for devise !
2011/11/20 Carlos Antonio da Silva <
<EMAIL_ADDRESS>

You could create that easily in your application with either a Warden hook
or a before_filter, to check if that was the 1st time the user was signing
in, and then redirect to a proper url to change user password. Shouldn't be
hard, but I believe it's not something we should add to Devise itself.
Thanks.

Reply to this email directly or view it on GitHub:
https://github.com/plataformatec/devise/issues/1449#issuecomment-2803595

--
Alexey Z., :skype :: cat_of_duty

Nice. I think there is a section in the wiki about Devise extensions, feel free to add it to the list then pointing to your repo.

Hi,
i already created that before creating "issue" :) , just come to my mind as
idea for devise !
2011/11/20 Carlos Antonio da Silva <
<EMAIL_ADDRESS>
You could create that easily in your application with either a Warden hook
or a before_filter, to check if that was the 1st time the user was signing
in, and then redirect to a proper url to change user password. Shouldn't be
hard, but I believe it's not something we should add to Devise itself.
Thanks.
Reply to this email directly or view it on GitHub:
#1449 (comment)

Alexey Z., :skype :: cat_of_duty

Any chance we could refer your solution?

I am also interested in functionality for "force password reset after first login with password", that isn't necessarily limited to first login to the account.  Setting a temporary password that can only be used once, and after that requires a password change, is a common "enteprisey" feature.

I think having a flag to force password reset (for whatever reason) on next user login should be a critical function of Devise (which is excelent by the way), as this is a great way of blocking suspect accounts or even resetting the entire user database passwords.


Google Calendar cannot inject any styles

The Google Calendar recipe fails to inject its own calendar.css styles, or the optional darktheme.css styles.
When trying to append the modal to the body of the page, the recipe throws an error, and never actually gets to the line that injects the calendar.css styles to the recipe.
Also, not sure if this is related, but injecting the darktheme.css also errors out due to the recipe being undefined.
Stack Trace for the first problem is as follows:
Recipe initialization failed TypeError: Cannot read property 'appendChild' of null  webview\recipe.js:77

    at module.exports.Franz (webview.js:33)

    at RecipeController.loadRecipeModule (webview\recipe.js:72)

    at EventEmitter._class.initialize.Object.keys.forEach._electron.ipcRenderer.on (webview\recipe.js:47)

    at emitTwo (events.js:126)

    at EventEmitter.emit (events.js:214)

And the Stack Trace for the darktheme.css problem is as follows:
[mobx] Encountered an uncaught exception that was thrown by a reaction or observer component, in: 'Reaction[Autorun@1] TypeError: Cannot read property 'path' of undefined
    at RecipeController.update (webview\recipe.js:97)

Thrown at ...\AppData\Local\Programs\franz\resources\app.asar\node_modules\mobx\lib\mobx.js:1651
I cannot unpack app.asar at the moment, so I cant delve any deeper there.
Attached Screenshots
The problems at hand:

Device Information:

OS: Windows
Chrome
V5.0.0-beta.22

This still affects v5.0.0-beta.24 (both Windows and Linux)
I believe this occurs when Google Calendar is "slow" (ish) to load. Per this StackOverflow post, I have been able to successfully render with darkmode styles by modifying webview.js to wrap the add/append operations like this:
...
  const getMessages = () => Franz.setBadge(updates);

  modal = createModal();
  setTimeout(function() {
    console.log(document.body.appendChild)
    document.body.appendChild(modal);
    document.addEventListener('keydown', event => event.keyCode === 27 && hideModal());
  }, 2000);

  Franz.injectCSS(path.join(__dirname, 'calendar.css'));
...

I do not believe this is a stable thing to do as service definitions change, but ¯\_(ツ)_/¯

I've noticed that darkmode works sometimes, and not other times.

Yeah, I noticed similar. I'm no JS expert but I suspect document/document.body aren't always quite ready when this script assumes they are. Hence your exception of Cannot read property 'appendChild' of null. But those functions are available by the time I pulled up the dev tools. That's what led me to believe it's a timing issue and a delay (2000ms in my example above) would at least make it more likely to succeed.

if the script tries to run before document.body is loaded, instead of the timeout, it could be put in a ready function.
See here for more detail

Nice! Though it looks like jQuery isn't automatically available. StackOverflow again to the rescue:
  document.addEventListener("DOMContentLoaded", function(event) {
    document.body.appendChild(modal);
    document.addEventListener('keydown', event => event.keyCode === 27 && hideModal());
  });

I forgot to mention I had to drop the last line in webview.js that smells like a checksum. Probably voids the warranty.
//# sourceMappingURL=data:application/json;charset=utf-8;base64, BLAHBLAHBLAH

Good solution! I guess you could make a PR for this!

Hey, I was wondering why this never made it to master. I just stumbled upon this issue using franz-5.5.0-2. I wasn't able to get darkmode working at all without this patch.

I closed this after @cohoe merged it into master. Maybe they have something more to add.

My PR was against the plugin, but idk how that actually makes it's way into the Franz ecosystem. Maybe @adlk could elaborate?


ddl: fix TypeBit default value

What problem does this PR solve?
Issue Number: close #9461
Problem Summary:
What is changed and how it works?
Fix two problems:

When the default value of TypeBit contains invalid characters (like 0x07 or 0x08), TiFlash fails to parse the schema JSON.
The default value of TypeBit is origin_default_bit_value.

ddl: fix TypeBit default value

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

Why we need to update Poco here?

Why we need to update Poco here?

Check https://github.com/pingcap/poco/pull/22

/cc @JaySon-Huang @JinheLin @CalvinNeo

/cherry-pick release-7.1

/cherry-pick release-6.5


#14 Exception during direct invocation

Only non-empty python path extensions are added to the SystemState

Coverage increased (+0.2%) to 94.521% when pulling a67cf32942d31232854f65ed5e751496f07c4227 on edelbluth:Bug_#14 into d3986a0cf20820ccc916c0fafd30457c25b51722 on juergen-rocks:V_0.


[Bug]: missing logs in e2e if decoding fails

Is there an existing issue already for this bug?

[x] I have searched for an existing issue, and could not find anything. I believe this is a new bug.

I have read the troubleshooting guide

[x] I have read the troubleshooting guide and I think this is a new bug.

I am running a supported version of CloudNativePG

[x] I have read the troubleshooting guide and I think this is a new bug.

Contact Details
No response
Version
trunk (main)
What version of Kubernetes are you using?
1.31
What is your Kubernetes environment?
Self-managed: kind (evaluation)
How did you install the operator?
YAML manifest
What happened?
Running the e2e, in case some log gets emitted which is not in json format (which shouldn't happen, but it may) the log collector stops writing them on file without giving any info. We should get details about the failure and see if it is possible to keep writing logs.
Cluster resource
No response
Relevant log output
No response
Code of Conduct

[x] I agree to follow this project's Code of Conduct

@fcanovai I wasn't able to reproduce this issue, I've created a non json line in the logs that it's being pushed all the time and stern was able to put it into the files, meaning I can't reproduce this :s

There's no easy way to make sure we always capture the logs and we don't miss a line, discarding for now


Space wrapped items in a select2 select or multi_select

See:
https://jsfiddle.net/jeroenvo/bzc853hc/28/
when an item in an HTML field is wrapped in spaces, the value is visible in the dropdown but not in visible in the input box when the item is selected.
Happens with select2 with normal select and also with multi_select.
Maybe strip spaces at both ends of the cell data would be a nice fix.

from  what I have seen the generated select element in valid with options that are matching the original values in the table column, it might be a bug in the select2 plugin, not sure... I suggest you to trim the original value in the table column, if you will provide a test page showing that the select2 plugin does work differently (without yadcf) I will try to see again where the value is getting messed

I've added a simple select2 dropdown to the fiddle, see https://jsfiddle.net/jeroenvo/bzc853hc/41/
It seems to work when the select2 options are provided directly.

Hi
It doesn't work because of select2 got some issues with the spaces, without select2 it does work, there is a way to fix it - by trimming the parsed text, by placing col_inner_data = $.trim(col_inner_data); inside parseTableColumn right after if (col_inner_data || col_inner_data_helper) { if (!col_inner_data_helper) { but I prefer not to place it there because that might have side effects.
As to the sample-select init (pure select2) with spaces that you did, the spaces in the the options are being trimmed by select2 and thats why it works as expected (while the spaces that parsed by yadcf from html span tag are preserved and passed to to select2 (which in turn does not work properly)

Ok, thanks for the explanation!


Feature/jsdom (WIP)

WIP
KarmaJS while really good cool and has many added benefits (debugging), that value is at a price drums speed.

[ ] Remove Karma and all it's dependencies
[ ] Add documentation for component level testing
[ ] Test async redux actions
[ ] Provide a wide range of examples

any chance we can still keep mocha/chai ;)

@mmahalwy yep


Condition "!is_visible_in_tree()" is true

I add player control to the already prepared scene using your plugin. The player doesn't move and I get an error:
E 0:00:02.469   _input: Condition "!is_visible_in_tree()" is true.
<C++ Source>  scene/2d/touch_screen_button.cpp:201 @ _input()

If I remove everything from the tree except the player, then there is no error and he moves.
What am I doing wrong?

The error message makes me think that maybe the plugin isn't the cause the error.
So first check out if something on this thread makes sense in your case (I just see that the user posting has a similar error and it go fixed.
If the error persist, tell me about how did you set up the plugin. And how are you using it. As I will need this information to help you.


Cannot find module '/app/.output/server/node_modules/subscriptions-transport-ws/dist/message-types' imported from /app/.output/server/chunks/app/server.mjs

Environment

Operating System: Darwin
Node Version:     v14.16.1
Nuxt Version:     2.16.0-27305297.ab1c6cb4
Package Manager<EMAIL_ADDRESS>Bundler:          Webpack
User Config:      alias, apollo, auth, axios, bridge, build, buildModules, css, head, i18n, modules, nitro, plugins, proxy, publicRuntimeConfig, render, router, server, serverMiddleware, storybook, styleResources, telemetry
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>portal-vue/nuxt
Build Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
Reproduction

build an app using @nuxt/bridge with nuxi build command
run the app with node .output/server/index.mjs
access the app via a web browser at http://localhost:3000/
check the logs in the terminal

Describe the bug
I tried using the nitro property for the nuxt config, as such:
nitro: {
    preset: "server",
    timing: true,
},

But it did not seem to solve it. it seems the app starts fine, but when you access the app in a web browser, you get the 500 error page, and the following error in the terminal:
$ node .output/server/index.mjs
> Cold Start (6ms)
Listening on http://localhost:3000
> Load chunks/nitro/static (0ms)
> Load chunks/app/render (0ms)
> Load chunks/app/client.manifest (0ms)
Cannot find module '/Users/sppmstar/work/app/.output/server/node_modules/subscriptions-transport-ws/dist/message-types' imported from /Users/sppmstar/work/app/.output/server/chunks/app/server.mjs
Did you mean to import subscriptions-transport-ws/dist/message-types.js?
  at finalizeResolution (internal/modules/esm/resolve.js:276:11)
  at moduleResolve (internal/modules/esm/resolve.js:699:10)
  at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:810:11)
  at Loader.resolve (internal/modules/esm/loader.js:86:40)
  at Loader.getModuleJob (internal/modules/esm/loader.js:230:28)
  at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:56:40)
  at link (internal/modules/esm/module_job.js:55:36)
Cannot find module '/Users/sppmstar/work/app/.output/server/node_modules/subscriptions-transport-ws/dist/message-types' imported from /Users/sppmstar/work/app/.output/server/chunks/app/server.mjs
Did you mean to import subscriptions-transport-ws/dist/message-types.js?
  at finalizeResolution (internal/modules/esm/resolve.js:276:11)
  at moduleResolve (internal/modules/esm/resolve.js:699:10)
  at Loader.defaultResolve [as _resolve] (internal/modules/esm/resolve.js:810:11)
  at Loader.resolve (internal/modules/esm/loader.js:86:40)
  at Loader.getModuleJob (internal/modules/esm/loader.js:230:28)
  at ModuleWrap.<anonymous> (internal/modules/esm/module_job.js:56:40)
  at link (internal/modules/esm/module_job.js:55:36)

The app itself works fine when running it with nuxi dev.
Additional context
No response
Logs
No response

These docs may help. Likely try adding that module to your build.transpile array.
If that doesn't help, feel free to open a discussion (ideally with a reproduction).

The https://v3.nuxtjs.org/concepts/esm/ link throws a 404 Page not found.


Fix when config.file is not a file object or array

A simple plunkr of the issue I'm describing. Test on Firefox.
Imagine you have a Post model in your server and it has a Attachment. You have created a Post with an attachment and you want to edit it. The server sends following JSON:
{
  "title": "Test",
  "content": "something",
  "attachment": {
    "path": "/path/to/attachment.js"
  }
}

If you don't change the attachment and send a PUT request via ng-file-upload, on Firefox you'll receive an error (Like this plunkr):
Error: Argument 2 of FormData.append does not implement interface Blob.

Because (as MDN describes) formData.append only gets third value, filename, only if the second value is either a File or Blob. This causes Firefox to raise an error on line 180 and request won't be sent.
On Chrome, it sends a null value for attachment, so on the server the file will be deleted (in my case at least).
So I changed the lines 173-182 this way:
if (angular.isArray(config.file)) {
  var isFileFormNameString = angular.isString(fileFormName);
  for (var i = 0; i < config.file.length; i++) {
    formData.append(isFileFormNameString ? fileFormName : fileFormName[i], config.file[i],
      (config.fileName && config.fileName[i]) || config.file[i].name);
  }
} else if (Object.prototype.toString.call(config.file) === '[object File]') {
  formData.append(fileFormName, config.file, config.fileName || config.file.name);
} else {
  formData.append(fileFormName, JSON.stringify(config.file));
}

It checks if the the config.file is a File object or not. same thing can be done for Blob. But I'm not sure if it's needed or not.

Why would you use Upload.upload if you are not sending a file?

I'm using it for submitting the form which contains the file input. If not using the Upload.upload then I have to make if statement in all similar controllers (the same way in the pull request) and use a resource for when the File is not available. Is it the desired way of doing this?

The problem here is that you are setting the file option as a non file object. You should put all the data that are not file in the fields or data parameters and set the file option only if there is an actual file selected,

That makes sense. Thank you!


Add version: pnpm.pnpm.6 version 6.32.16

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.1 schema?

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@wingetbot run

@wingetbot waivers Add Validation-Executable-Error


Expose  as a config in vscodeOptions capability field

Fixes #74

Once we document this in the README.md this will be good to go.

Thanks for the contribution. I will look at the current build issues and release as soon as they are fixed.