Bug: Spawn and TS error

XState version
XState version 5
Description
When spawning a child machine, I get a TS error.
 entry: assign({ theChild: ({ spawn }) => spawn(child) }) // squigly error line under child
Expected result
There should not be a TS error
Actual result
The child machine is correctly spawned but I get this TS error: Argument of type 'StateMachine<MachineContext, AnyEventObject, Record<string, AnyActorRef>, ProvidedActor, ParameterizedObject, ... 7 more ..., ResolveTypegenMeta<...>>' is not assignable to parameter of type 'never'.(2345)
Reproduction
https://stackblitz.com/edit/github-eldaka?file=src%2FfeedbackMachine.ts
Additional context
No response

Probably duplicate of #4814


Problem when sitemap spans more than 1 page

When there are too many items on the sitemap to fit into 1 page, items that are on the second or later pages cannot be clicked. Will EasyRepro be able to bundle the logic to detect if a button exists, but is not visible, scroll to the next page and so on until it can either click or fail?
We're currently using custom code to do this manually.

That is something we don't currently handle.  We would need to add a feature enhancement for that.  I'll add it to our backlog.

@seanmcne : is there a work around for this ? as even if the window size is maximized this tab can only be viewed if you click the right arrow button there.

Please check the attached pic and the right arrow highlighted therein.


VPR flat_routing support

@tangxifan @ganeshgore ,
VPR has an optional argument: --flat_routing true
Is OpenFPGA ready to support this option?
If yes, are there any specific properties the vpr.xml, openfpga.xml arch files need?

Hello @alaindargelas , No OpenFPGA is still not compatible with the flat routing database. We are at QuickLogic trying to build support for that but there is no defined timeline yet.

@ganeshgore thanks.
Let us know how can we collaborate.


License question

Hey there,
Since it's been nearly a year since someone mentioned that the Nuget package doesn't work (I just noticed it myself, which was what brought me to the issues), would you be against making the license MIT? I would not mind using it, but can't add a reference to the package because it doesn't work and I have never been comfortable including actual code unless it's MIT licensed.
Thanks,
-MH

Hi @MostHated,
I wouldn't mind doing so, I just wonder what particular issue you see with the current license?

Hi @MostHated,
I wouldn't mind doing so, I just wonder what particular issue you see with the current license?

It's definitely not that there is anything wrong with the choice of license. It's just my own dumb personal anxiety/paranoia that I am forgetting some term of the license, or that I didn't do some minute detail that might come back to bite me one day. (even though I know that won't actually happen... but what if it does, just to me? Anxiety is terrible man, I tell you.)
I am not well versed in license terms and conditions, and after some time, I just found I feel much more at ease integrating a package that is MIT licensed since it is so simple and straight forward, and I don't have to worry about if I am right or wrong in my knowledge of licenses, or that I am doing something incorrectly, that might (even though it won't....) cause issue.
 My bad, nevermind about the whole thing.

It's definitely not that there is anything wrong with the choice of license. It's just my own dumb personal anxiety/paranoia that I am forgetting some term of the license, or that I didn't do some minute detail that might come back to bite me one day. (even though I know that won't actually happen... but what if it does, just to me? Anxiety is terrible man, I tell you.)
I am not well versed in license terms and conditions, and after some time, I just found I feel much more at ease integrating a package that is MIT licensed since it is so simple and straight forward, and I don't have to worry about if I am right or wrong in my knowledge of licenses, or that I am doing something incorrectly, that might (even though it won't....) cause issue.
 My bad, nevermind about the whole thing.


patroni: 4.0.1 -> 4.0.2

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 343064 run on x86_64-linux 1

2 packages built:

patroni
patroni.dist

I rarely see this enforced, but maybe put the changelog in the commit description. It's in the contribution guidelines, but might not matter for a version bump this small...


Why not use nineoldandroids?

For some reasons of animations that are only supported by api-level 11.?
I know it. My suggestion is nineoldandroids, and api-level 9 is at least OK.

Use ViewCompat now

@ppamorim thx.


Can't start issue-tracker from fresh install

I followed the provided install instructions for issue-tracker but still get the following errors when running yarn start.
➜  issue-tracker (master) yarn start                                                                                ✭
yarn run v1.16.0
$ yarn run relay; concurrently --kill-others --names "react-scripts,relay" "react-scripts start" "yarn run relay --watch"
$ yarn run relay-compiler --schema schema/schema.graphql --src ./src/ $@
$ /Users/mattwilliams/dev/relay-examples/issue-tracker/node_modules/.bin/relay-compiler --schema schema/schema.graphql --src ./src/

Writing js
ERROR:
Encountered 4 errors:
- Unknown type "[IssueState!]" referenced in the argument definitions.

  Issues.js:6:11
  5 |           count: { type: "Int", defaultValue: 10 }
  6 |           states: { type: "[IssueState!]", defaultValue: ["OPEN"] }
    |           ^
  7 |         )
- Unknown type: 'ReopenIssueInput!'.

  IssueActions.js:2:52
  1 |
  2 |   mutation IssueActionsReopenIssueMutation($input: ReopenIssueInput!) {
    |                                                    ^
  3 |     reopenIssue(input: $input) {
- Unknown type: 'CloseIssueInput!'.

  IssueActions.js:2:51
  1 |
  2 |   mutation IssueActionsCloseIssueMutation($input: CloseIssueInput!) {
    |                                                   ^
  3 |     closeIssue(input: $input) {
- Unknown type: 'AddCommentInput!'.

  IssueActions.js:2:51
  1 |
  2 |   mutation IssueActionsAddCommentMutation($input: AddCommentInput!) {
    |                                                   ^
  3 |     addComment(input: $input) {
error Command failed with exit code 100.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 100.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
$ yarn run relay-compiler --schema schema/schema.graphql --src ./src/ $@ --watch
$ /Users/mattwilliams/dev/relay-examples/issue-tracker/node_modules/.bin/relay-compiler --schema schema/schema.graphql --src ./src/ --watch
[relay] Watchman is required to watch for changes. Running with watch mode disabled.
[relay]
[relay] Writing js
[relay] ERROR:
[relay] Encountered 4 errors:
[relay] - Unknown type "[IssueState!]" referenced in the argument definitions.
[relay]
[relay]   Issues.js:6:11
[relay]   5 |           count: { type: "Int", defaultValue: 10 }
[relay]   6 |           states: { type: "[IssueState!]", defaultValue: ["OPEN"] }
[relay]     |           ^
[relay]   7 |         )
[relay] - Unknown type: 'ReopenIssueInput!'.
[relay]
[relay]   IssueActions.js:2:52
[relay]   1 |
[relay]   2 |   mutation IssueActionsReopenIssueMutation($input: ReopenIssueInput!) {
[relay]     |                                                    ^
[relay]   3 |     reopenIssue(input: $input) {
[relay] - Unknown type: 'CloseIssueInput!'.
[relay]
[relay]   IssueActions.js:2:51
[relay]   1 |
[relay]   2 |   mutation IssueActionsCloseIssueMutation($input: CloseIssueInput!) {
[relay]     |                                                   ^
[relay]   3 |     closeIssue(input: $input) {
[relay] - Unknown type: 'AddCommentInput!'.
[relay]
[relay]   IssueActions.js:2:51
[relay]   1 |
[relay]   2 |   mutation IssueActionsAddCommentMutation($input: AddCommentInput!) {
[relay]     |                                                   ^
[relay]   3 |     addComment(input: $input) {
error Command failed with exit code 100.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 100.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[relay] yarn run relay --watch exited with code 100
--> Sending SIGTERM to other processes..
[react-scripts] react-scripts start exited with code SIGTERM
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Is anyone having similar issues? Is there a recommended fix for this?

try this
cd issue-tracker
yarn
yarn relay
yarn start

Just ran into the same issue:
[relay] Watchman is required to watch for changes. Running with watch mode disabled. [relay]  [relay] Writing js [relay] Unchanged: 12 files [relay] yarn run relay --watch exited with code 0 --> Sending SIGTERM to other processes.. [react-scripts] Starting the development server... [react-scripts]  [react-scripts] react-scripts start exited with code SIGTERM

Have tried this on both Linux and Mac and hitting the same issue.

Are you using node lts? Node 12?
Do you have watchman installed?

try to remove --watch

Are you using node lts? Node 12?
Do you have watchman installed?

I am running on v11.13.0 currently. Will upgrade and post results.

The upgrade to v13.13.0 did not help. Additionally, I do not have watchman installed so it is running with watch mode disabled.

odd versions are not stable, try version v10 or v12

Same issue with v12.16.2 (LTS)

the issue here is that start script requires both process to be long-running. (because it's using concurrently --kill-others)
you can mitigate that by running each process in a separate terminal tab:

yarn react-scripts start
yarn relay --watch false --watchman false

OR install watchman, and get a better dev experience 😄

In my case I remove the concurrently --kill-others part and just use "start": "yarn run relay && react-scripts start", and run yarn start and it works


Add option to only show opened or in-testing rides

Could be handy for showing "real" rides and hiding trackitecture.

Implemented with 5bb444e12e043a9db7d68e7930514f004bf9665f


wrapper.vm.$nextTick() doesn't seem to work correctly in 1.0.0-beta.30

Version
1.0.0-beta.30
Reproduction link
https://github.com/Loremaster/next-tick-modal-issue
Steps to reproduce

Clone repo
Run $ yarn
Run tests: $ yarn run test:unit

What is expected?
I expect tests to pass.
What is actually happening?
Test fails saying that modal wasn't closed. For a weird reason if I replace await wrapper.vm.$nextTick() with await wrapper.vm.$nextTick in line 29 in tests/unit/ComposeButton.spec.js it passes which is surprising.

I suspect its because of transitions, but I am not sure. Not waiting the ticks just means it was never visible in the DOM :)
We removed the Transition stub in v 30 :/

What would be a workaround to fix it then? I want to upgrade to latest version of vue-test-utils but not sure how to tackle that issue

Try stubbing the transition element globally?


OldDot - User gets an error message at the end of secondary login validation when user logged in ND

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in to NewDot with any account
Log into OldDot with the same account and add a Secondary Login from Account Settings
Open 'Validate secondary login email' and copy validation URL, i.e. /v/16/WSSWMNNM (Everything after the /v/)
Insert 'new' in this link from step 3 > e.g http://staging.new.expensify.com/v/12116/WSSWMNNMH
Navigate to the compiled link
The user receives a magic code on the ND page and an offer to insert it into the OD for validation
Switch to OD and insert Magic Code

Expected Result:

No error messages.
Secondary login has been validated.

Actual Result:

User get an error message.
Secondary login has been validated.

Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/3282461
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/227739800-510ce369-2b78-439e-9229-8d0ba3647bde.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

I'm very confused. Why are OldDot links being used for NewDot in this case?

I'm pretty sure we fixed this. The flow works fine:
https://user-images.githubusercontent.com/9133401/230230472-59934e67-275c-47c0-af5a-1aa8b048a529.mp4
It made no difference that I was also logged into newDot.


Use Shiny with Zeppelin-R

Hi Elbamos,
I really want Shiny to work with your Zeppelin-R notebook. I know you had told everyone that you need help with writing the code for Shiny and ggvis.
I will be happy to help your write the necessary code to enable Shiny to work with R. If you could guide me with what you need and help me conceptually, I would love to do this for you...

Great! Thanks!
The way shiny works, there has to be a websockets connection to a running R session. The first issue to deal with is whether we can reuse the same R session for both shiny and Zeppelin. I believe the answer is "no," but I'm not sure. If not, then we need a mechanism for launching separate R processes to run each shiny app. Then, we also need to modify Zeppelin so that web socket connections to the appropriate ports can get proxied back to the shiny instance.
I'm not sure how much else will be required, but that's definitely the starting point. Let me know if you'd like to speak on gitter or what have you.

On May 16, 2016, at 12:10 PM, Akshay Prakash<EMAIL_ADDRESS>wrote:
Hi Elbamos,
I really want Shiny to work with your Zeppelin-R notebook. I know you had told everyone that you need help with writing the code for Shiny and ggvis.
I will be happy to help your write the necessary code to enable Shiny to work with R. If you could guide me with what you need and help me conceptually, I would love to do this for you...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

Hi
Any updates on R Shiny integration with Zeppelin? Is it possible now?
Help/ Guidance/ Directions will be greatly appreciated. @elbamos  @akshayprakash

Sorry but I personally use Django, Flask and D3 now
So d3 works well with zeppelin
On Tue, Oct 31, 2017 at 11:59 AM saahilguptaq<EMAIL_ADDRESS>wrote:

Hi
Any updates on R Shiny integration with Zeppelin? Is it possible now?
Help/ Guidance/ Directions will be greatly appreciated. @elbamos
https://github.com/elbamos @akshayprakash
https://github.com/akshayprakash
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/elbamos/Zeppelin-With-R/issues/18#issuecomment-340810015,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJwwLMVTtGa0txfqOqtvmSZ6Hlhc9ccJks5sx0PwgaJpZM4IfdmK
.

Havent looked at it in years.

On Oct 31, 2017, at 8:59 AM, saahilguptaq<EMAIL_ADDRESS>wrote:
Hi
Any updates on R Shiny integration with Zeppelin? Is it possible now?
Help/ Guidance/ Directions will be greatly appreciated. @elbamos @akshayprakash
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi,
Has there been any updated on the R - Shiny integration with Zeppelin?
Any guidance that can be provided would be very appreciated.
Thanks


New Features

Hey,
Nice job !
Is it possible to flip the camera for the back one and take a screenshot or record a movie ?
That would be great.
Cheers,
Luc

This is just a demo of the cordova-plugin-iosrtc, not a full app. Nothing else will be done on it.


Infer tuples for jsx children if contextually typed by a tuple

Fixes #22759

@weswigham seems like one of the tests added here is failing 😢

@uniqueiniquity @weswigham I think it's a missing semicolon. #27574 updates the baseline as part of another bugfix.


Mock Workflow.currentTimeMillis() return value in test environment

We're using Temporal and have several workflows. Some of these workflows rely on Workflow.currentTimeMillis() to get the current time.  We're having trouble injecting mocked time into it. While Mockito can mock static methods of classes like Workflow or WorkflowInternal, it fails silently because the test environment spawns another thread.  Java ignores mocked classes/methods if they are called from another thread.
A simple setter inside TestWorkflowEnvironment could allow us to set the desired time, before starting a workflow.  The setter's name is not that important.  It could be added to the WorkflowOptions class?
I've skimmed the library implementation and found various interfaces which could potentially be implemented and injected to achieve the desired behavior.  WorkflowOutboundCallsInterceptor looks like a candidate, although it seems to be buried deep in the system internals.
Thank you for your help and for taking the time to read this.
P.S Does writing a wrapper, and using it instead make sense?
 public static long currentTimeMillis() {         return testMode ?  MockableTime.toEpochMilli() : Workflow.currentTimeMillis();     }

Thank you for the answer.  Don't know How I missed that.


Escaper should use [:alnum:] instead [a-z0-9]

Method Zend\Escaper\Escaper::escapeHtmlAttr() should use [:alnum:] in the regular expression. So it would also work with chinese characters correctly.

Any non-ascii characters are supposed to be encoded anyway.
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
On 25 May 2015 at 14:32, phpManiac77<EMAIL_ADDRESS>wrote:

Method Zend\Escaper\Escaper::escapeHtmlAttr() should use [:alnum:] in the
regular expression. So it would also work with chinese characters correctly
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zf2/issues/7550.

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html
New issue can be found at: https://github.com/zendframework/zend-escaper/issues/18


Use latest system-upgrade-controller release

The latest system-upgrade-controller dev release has been used in standalone rke2 and k3s for months now with success. We should bump this tag to be an actual latest release and use that new latest release in Rancher as well.

https://github.com/rancher/system-upgrade-controller/releases/tag/v0.10.0 has been cut -- just need to pull this into rancher/rancher now!


Can we remove node-agent in favor of utilizing kubelet's garbage collection?

Describe the problem this improvement solves
We currently use the node-agent to pre-pull images to the nodes in the cluster and delete unused images (primarily used for environments). This behavior might not be needed due to the garbage collection that kubelet is running by default.
Would need some more digging around given that the node-agent is used to reduce disk pressure by removing images that are no longer need by Orchest, e.g. managing environment images lifecycles.
A more thorough discussion can be found in:

https://github.com/orchest/orchest/pull/1048#issuecomment-1161610160
https://github.com/orchest/orchest/pull/1048#issuecomment-1161813148
https://github.com/orchest/orchest/pull/1048#issuecomment-1161826898
https://github.com/orchest/orchest/pull/1048#issuecomment-1161838437
https://github.com/orchest/orchest/pull/1048#issuecomment-1161873594
...

Given the changes in #1198 where the node-agent now also becomes responsible for pushing images to our internal registry, I think fixing this issue is off the table for the foreseeable future.
@fruttasecca Feel free to re-open the issue if you disagree.


result files not being written

logs show the following output:
│ {"level":"info","ts":"2022-05-17T10:14:02Z","msg":"a17caa6a-ed96-4291-9bb9-cbf531ee1478","action":"triggering scan","time":"2022-05-17 10:14:02"}                                                             │
│ {"level":"info","ts":"2022-05-17T10:14:02Z","msg":"ARMO security scanner starting"}                                                                                │
│ {"level":"info","ts":"2022-05-17T10:14:03Z","msg":"Installing host scanner"}                                                                                │
│ {"level":"info","ts":"2022-05-17T10:14:13Z","msg":"Downloading/Loading policy definitions"}                                                                                │
│ {"level":"info","ts":"2022-05-17T10:14:13Z","msg":"Downloaded/Loaded policy"}                                                                                │
│ {"level":"info","ts":"2022-05-17T10:14:13Z","msg":"Accessing Kubernetes objects"}                                                                                │
│ {"level":"info","ts":"2022-05-17T10:14:17Z","msg":"Accessed to Kubernetes objects"}                                                                                │
│ {"level":"info","ts":"2022-05-17T10:14:17Z","msg":"Scanning","cluster":"my-cluster"}                                                                                │
│ {"level":"info","ts":"2022-05-17T10:14:28Z","msg":"Done scanning","cluster":"my-cluster"}                                                                                │
│ {"level":"info","ts":"2022-05-17T10:14:31Z","msg":"Scan results saved","filename":"results/a17caa6a-ed96-4291-9bb9-cbf531ee1478"}

but actually no file is written. Also calling the v1/results endpoint doesn't return anything.
Looking at the source code, the function actually does nothing apart from logging: https://github.com/armosec/kubescape/blob/a27d2d41f2dd61bfb2dcdf5fb7708625458f815e/core/pkg/resultshandling/printer/v2/utils.go#L79

Hi @zhujik , thank you.
The issue is with the wrapper, we delete the file after the scanning. This will be fixed ASAP.
For now, add the keep query param when you trigger the scan.


[Bug] Advanced Filter

Dear @volkanceylan,
I think that there is an issue on the advanced filter:

and this is the filter shown in the interface
[Ship Via <> Federal Shipping and Ship Via <> United Package and (Customer contains 'alfreds' or Employee contains 'nancy' or Ship City contains 'berlin') and Ship Country = Germany]

As you can see the filter should exclude the "Ship Via" Federal Shipping and United Package, but instead I can found them in the result.
Also here there is the query that has been generated:
SELECT count(*)
FROM [Orders] T0
LEFT JOIN [Customers] c ON (c.[CustomerID] = T0.[CustomerID])
LEFT JOIN [Employees] e ON (e.[EmployeeID] = T0.[EmployeeID])
LEFT JOIN [Shippers] via ON (via.[ShipperID] = T0.[ShipVia])
WHERE ((((((((T0.[ShipVia] != @p1) AND (T0.[ShipVia] != @p2)) AND c.[CompanyName] LIKE @p3) OR CONCAT(e.[FirstName], CONCAT(' ', e.[LastName])) LIKE @p4) OR T0.[ShipCity] LIKE @p5)) AND ((T0.[ShipCountry] = @p6))))

It seems that the transposition of the query it's wrong: I mean the way the logical operators are nested.
Thank you very much
Bye

I think it's more the syntax of the criteria.
Your criteria essentially says:
Filter Criteria 1
(((T0.[ShipVia] != @p1) AND (T0.[ShipVia] != @p2)) AND c.[CompanyName] LIKE @p3)
Filter Criteria 2
CONCAT(e.[FirstName], CONCAT(' ', e.[LastName])) LIKE @p4)
Filter Criteria 3
((T0.[ShipCity] LIKE @p5)) AND ((T0.[ShipCountry] = @p6))
If any of the information matches any of the 3 criteria it gets displayed. Since the Federal Shipping and United Package have Items that match in Criteria 2 and 3, there are still items being displayed.
The best way to notice this is by adding each filter criteria one by one and then looking at the result. Try adding the Ship Via Not Equal Federal Shipping and running it, then adding the United Package Exclusion. You should see the pattern as you go adding more filters.

It looks like a bug to me, try adding full parenthesis and see if it changes anything.

hello we are also experiencing this issue, @volkanceylan I've tested your suggestions and if you try with "explicit" parenthesys it works as expected:

the only think i've changed from @marcobisio 's example is "wrapping the first 2 conditions into parenthesys.
I guess there is something wrong with the translation from filter to sql, but i'm not an expert..
hope this helps

It's a bug in javascript code of FilterPanel where it converts lines to criteria. There is no bug in server side. Will release with next version.

great news! thanks a lot for your efforts

Thanks @volkanceylan and @steax85 for your feedbacks!

Just realized that you have already released the next version, which include also this fix: wow too fast!
Thank you very much for your support Volkan!
Bye


Retrieve panorama hostname for API key and config file once, instead of writing dummy config

Having to edit the config file after the first run is annoying


Euclidean Clustering can optionally publish filtered point cloud and/or filtered ground points

Modified euclidean clustering to:

Publish new topic "/points_ground" of the type sensor_msgs::PointCloud2, outputs the planar points in the ground
Publish new topic "/points_filtered" of the type sensor_msgs::PointCloud2, removes the planar points from points_raw
Both of the added features feed from the customizable 'points_node' argument.
Please check the launch file for details.

The idea is to generate different pointcloud messages to be projected using the new points2image.
Example:

Generate the PC messages

% roslaunch lidar_tracker euclidean_clustering.launch

This will publish 3 topics, /euclidean_clustering, /points_filtered, /points_ground

Launch calibration_publisher
Launch points2image to show the projected result from the desired PC message
For instance:

% rosrun points2image points2image _points_node:=/points_filtered

or
% rosrun points2image points2image _points_node:=/points_ground

etc...
Finally :
% rosrun viewers points_image_viewer

In summary:
Any PointCloud2 Message --->  Points2Image --->  Viewer
Could @h-ohta or @manato, confirm please with a real rosbag?
Remember to (1)relay velodyne_points to points_raw, (2)Publish camera_info and the projection matrix, (3) run points2image with /points_filtered or /points_ground
@syohex Could you please check the correct compilation of this branch?
Thanks for your kind support

@amc-nu ,
Thanks for your great work.
This is a comparison picture.

(The picture shows that ranging with /points_filtered can detect cars in far place which /vscan_image can't)
But, with regard to processing speed, points_filtered somewhat slower than vscan.
I'll send comparison video link later.

so, can we merge this one? @manato @syohex ??

I think yes.

I think so too.


Add support for transparent mode

For this issue, are you looking to add the HID-specific things, or Extended Packet Mode?
It's been a while, but I purchased the v2.1.7 spec (back when it was $30), which IIRC had removed transparent mode and moved it to an appendix.  I had requested the appendix but never heard anything back.  I ended up finding a 2.1.5 spec somewhere and implementing it from that in the .NET solution I put together.
I'm working on an Open Source Control Panel in Python 3 at the moment, and transparent mode is on the "needs to be done" feature list.  It is required in order to do PIV certificate/private key authentication.  I remembered libOSDP, and it looks like it will save a lot of development time.  No point in reinventing the wheel.
Between the spec I have and the HID OSDP SDK, I could likely add the HID-style transparent mode to libOSDP if that's useful.

Hey @mistial-dev, I'm looking at v2.2 (or the IEC v1.0) specification when I think about TRS mode. I'm not familiar with the HID-style transparent more nor it's acceptance in industry. Since the official specification has a flavour, I'm guessing that is more authoritative what is your take on this matter?
That said, any contributions towards this goal is always welcome. :)
PS. please be informed that the python library that comes with this project is a binding to the C library (not native); this may not be the best thing to do in some cases.

I don't have the 2.2 spec, so I can't comment on it.
The earlier versions had a transparent mode that was covered by HID patents.

As I understand it, the Extended Packet Mode was built specifically to avoid the HID patents.  The standard I have has the following notice:
The OSDP Specification Appendix E, contains the Behavior Profile 1: Transparent Smartcard Interface
Support Operations. The profile, located in Appendix E of the specification summarizes a means to
interact with a reader device. SIA is not responsible for rights clearance and recommends that all
users of the OSDP Specification consider any applicable third party intellectual property rights in
connection with implementations that wish to utilize messaging with third party reader devices.
Specifically, the OSDP Specifications address a mechanism for passing messages (APDUs) between
authentication software and a smartcard transparently, without reader support. This mechanism is
intended to support FICAM compliant authentication, which may be subject to the following U.S.
patents, among other intellectual property rights.
1. United States, 6575360, Device and method for personalizing chip cards; and
2. United States, 7853789, Method and system for establishing a communications pipe between
a personal security device and a remote computer system

PS. please be informed that the python library that comes with this project is a binding to the C library (not native); this may not be the best thing to do in some cases.

That's fine.  I'm going to be packaging this as binaries anyway, and the CP software already has autoconf, automake, etc.  No worries on that front.

Okay, now it all comes back to me. I was looped to a discussion with some
folks from SIA and they confirmed in that mail thread that the in-spec
(v2.2) TRS mode was free from any patent related issues (now I know what
they meant).
Given that the targeted users are trying to build products out of this, we
should try to add support for the royalty free version. I have the
specification with me; but just lack the time to get to it. :(
On Mon 14. Jun 2021 at 22:29, Mistial Developer @.***>
wrote:

I don't have the 2.2 spec, so I can't comment on it.
The earlier versions had a transparent mode that was covered by HID
patents.
[image: image]
https://user-images.githubusercontent.com/69981049/121954699-ac68d400-cd24-11eb-92db-1171b3e0cf8f.png
As I understand it, the Extended Packet Mode was built specifically to
avoid the HID patents. The standard I have has the following notice:
The OSDP Specification Appendix E, contains the Behavior Profile 1: Transparent Smartcard Interface
Support Operations. The profile, located in Appendix E of the specification summarizes a means to
interact with a reader device. SIA is not responsible for rights clearance and recommends that all
users of the OSDP Specification consider any applicable third party intellectual property rights in
connection with implementations that wish to utilize messaging with third party reader devices.
Specifically, the OSDP Specifications address a mechanism for passing messages (APDUs) between
authentication software and a smartcard transparently, without reader support. This mechanism is
intended to support FICAM compliant authentication, which may be subject to the following U.S.
patents, among other intellectual property rights.

United States, 6575360, Device and method for personalizing chip cards; and
United States, 7853789, Method and system for establishing a communications pipe between
a personal security device and a remote computer system

PS. please be informed that the python library that comes with this
project is a binding to the C library (not native); this may not be the
best thing to do in some cases.
That's fine. I'm going to be packaging this as binaries anyway, and the CP
software already has autoconf, automake, etc. No worries on that front.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/goToMain/libosdp/issues/22#issuecomment-860970692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAW3LGLTFWAVPXZC6W5ECEDTSZRA3ANCNFSM4RAM7SEA
.

I have a project which requires reading PIV fobs in a Linux environment, and may be able to contribute some work on this.  If anyone is aware of commercially available door readers which support the standard transparent mode, that might be used for interoperability testing of this feature, please speak up!

@edgecase14, I'm aware of two commercially available readers manufacturers that support Transparent Mode; most notably HID readers and I can arrange for interoperability testing if we have a PR with an acceptable design.
Commit e8db7e1d on branch trs_dev should be a good starting point if you wish to work on this feature. The idea is that TRS mode should be a plugin feature that has all changes confined to src/osdp_trs.c (much like how file transfer support is added in src/osdp_file.c) and would not impact the rest of the library if CONFIG_OSDP_TRS is not enabled.
As it stands, our testing story is a bit lagging and I'll be focusing my free time on that until it reaches some point of sustenance. Once I'm able to take this up, and no one has already claimed it, I'll remove the "Needs Help" label and work on it myself.

Given that the targeted users are trying to build products out of this, we should try to add support for the royalty free version.

I'm part of a group that's forming (Open Physical Working Group) that's trying to put together reference implementations for PACS manufacturers and integrators to use.  We're using PIV as the basis of these reference implementations, and we're going to be relying pretty heavily on transparent mode.


Polyfill

Polyfilling via babel doesn't work very well in my experience since you don't normally run babel against node_modules.  For apps (rather than libraries) I think it's generally best to just have global polyfills.
With this in mind, we could consider just adding a script to link to https://polyfill.io/v2/docs/ as the default polyfill.  It provides a polyfill based on the user agent string so is a decent future proof default.
For non-polyfill babel-runtime components, we should do as @insin suggest in https://github.com/facebookincubator/create-react-app/issues/51#issuecomment-234215045

Are any other major tools using/recommending this?

Not that I'm aware of.  Their usage stats seem fairly impressive (https://polyfill.io/v2/docs/usage).  I'm not averse to us offering a different (e.g. static) js polyfill, I just think we should default to including a global polyfill of some sort.
The least controversial thing might be to just provide a static polyfill (not sure which ones are popular these days).  I think we should provide something though as soon as possible.

I would normally include core-js but it is way too large. I agree it’s better to ship a polyfill than not. I’ll ask for feedback on Twitter I guess.

We could ship full core-js in development build, then build a custom core-js based on analysing code for which features are actually used in production.  Doing that analysis in development would probably be way too slow since it would require analysing all of the dependencies.
We could also look at building a couple of different bundles, one for browsers with full ES5 support and another for browsers that need ES5 polyfills, then feature detect on the client.

Feedback about polyfill.io seems generally positive.
I think we can get it in.

Do we have a good solution to this? https://github.com/Financial-Times/polyfill-service/issues/561

@gaearon we're fixing that soon

I will ship a fix for https://github.com/Financial-Times/polyfill-service/issues/561

What is the planned fix? Is it future proof?

https://github.com/Financial-Times/polyfill-service/issues/561#issuecomment-169511440

I wonder if a better fallback would be to hedge slightly and deliver at least the most commonly needed polyfills, rather than delivering no polyfills.

I don’t understand the problem space that well, would the proposed fix also work for Twitter / Slack / LinkedIn / ...?

The proposed fix is to adapt the existing UA aliasing so it's not just mapping between browser families but so it can  alter the entire parsed UA. We could then do something like:
'facebook': function(ua) {
  return {family: 'ios_saf', major: ua.os.major};
}

This would easily extend to other in-app browsers. (Twitter at least looks like it's correctly detected as MobileSafari)

We lean on ua-parser, because life's too short to write your own UA classification lib!  However, sometimes its classifications are not useful for us, and we alias them.

I think the lack of unhandled rejection reporting is unfortunately a blocker for us. This is a super common problem with React. People call setState() in fetch callback, their render() method throws, they have no idea what’s going on, and React gives you unhelpful errors because it is now in an inconsistent state.
Would you be interested in adopting a Promise polyfill that reports unhandled rejections by default? I believe core-js (shipping with Babel) does it.

How about including a default Promise polyfill which ensures everyone gets a version which avoids that issue?
I like @mjackson's solution for this in his web-starter project, providing static minified versions and loading them only when needed:
<script>window.Promise || document.write('\x3Cscript src="/es6-promise.min.js">\x3C/script>\x3Cscript>ES6Promise.polyfill()\x3C/script>')</script>
<script>window.fetch || document.write('\x3Cscript src="/fetch.min.js">\x3C/script>')</script>

I think you can do something similar with Webpack's import and export loaders, but don't quote me on that.

We had to remove polyfill.io due to it failing to identify ie11 correctly.

OK, thanks for feedback.
I think we won’t push it as the default solution then.
What @insin suggested in https://github.com/facebookincubator/create-react-app/issues/170#issuecomment-235198796 looks super reasonable to me. Mostly because fetch and Promise are two features that are easy to miss in a polyfill (or to get a bad polyfill).
So I think we should go with that approach instead.

@gertjvr could you raise that at Financial-Times/polyfill-service please? Seems like a fairly major issue.

@quarterto will do

The reason I’m inclined to not use polyfill.io right now is that most React users don’t care about ES6 features like Maps etc, so if they want a polyfill, they can add it themselves. However they do need two polyfills: fetch and Promise. And we’d like to have control over which Promise we ship because it’s so easy to get it wrong.

The best way to do this IMO is to do a client-side feature test and a document.write to get the polyfill if you need it. This way, you can avoid putting the file in your bundle altogether and do one less HTTP request on modern browsers.
This is actually one of the primary reasons I need to server-render my template in web-starter. So I can do those polyfills.
If server-rendering is off the table (note that I'm not talking about server-rendering your whole app-just the "chrome" and a bunch of <script> tags) then I'm not sure the best way to do this. Please note, however, that in order to use the WebpackManifestPlugin properly (#210) we'll need to have control over how the page is rendered anyway, because we need to do the same trick, so it might be worth looking into.

Hmm, can you help me understand why server rendering is important here? Couldn’t we just put these conditional document.writes into our index.html template?

We can just put them in our index.html template.  The downside is that it gets exposed to the user and becomes impossible for us to update because the template lives in the user's repository.
A better solution I think might be to add something like {{polyfills}} to the template and then use a loader (see https://github.com/ampedandwired/html-webpack-plugin/blob/master/docs/template-option.md) to add in the scripts.
I don't think "server rendering" is actually relevant here, so much as we just need some way to add the appropriate inline scripts to the page.

Ah, all I meant by "server rendering" was that you need to be able to affect the HTML. It sounds like index.html will work beautifully.

babel-polyfill isn't that large.
A gzipped, minified build with just react + react-dom is 41 kB. Adding babel-polyfill only takes that to 69 kB.
Without gzipping, it's 138 kB v. 222 kB.
Certainly there's room to optimize, but I don't think "adding 28 kB to the gzipped size" is sufficient for the easiest solution to be dismissed outright as "way too large".

We’d also need fetch.

Also, React gets a lot of bad rep for being “large”. We can say that 40kB gzipped is less than many images but that’s what people look at in comparisons, and I can guarantee that if we make it 70kB by default, somebody will use this in charts claiming React apps are huge (especially considering the “default” status of this tool).
So we should be careful bundling extra stuff. But perhaps bundling Promise, Symbol from core-js and fetch is good enough.

71 kB gzipped, 228 kB without gzip if I add isomorphic-fetch above.
I think didactically, in this context, it's just better. One-line polyfill import (and one that ships with Babel, at that) v. something non-trivial to ship exactly the correct polyfills.
The other thing the React ecosystem gets a bad rep for is tooling complexity, and doing bespoke, advanced stuff to pull in specific polyfills I think hurts more on the complexity front than it helps on the bundle size front.

OK. Here’s my proposal. Let’s ship these polyfills:

whatwg-fetch
Promise and Symbol from core-js
Regenerator runtime if you use generators or async (we’d need to add support for async too)

We would bundle them for everybody via entry config. It would not be configurable.

I don't actually know how to import core-js polyfills individually. 2 minutes of guessing gives me:
import 'react';
import 'react-dom';
import 'core-js/es6/promise';
import 'core-js/es6/symbol';
import 'isomorphic-fetch';

This gives me 49 kB gzipped, 161 kB just minified. (These numbers are a bit weird since I'm using webpack 2... maybe... probably not too bad.)
I don't know. I really like Object.entries, Array.prototype.includes, &c.
The other option is to use babel-runtime, which effectively will only polyfill things that are used. It won't polyfill e.g. Array.prototype.includes (but the proposal above doesn't either).
It will also reduce bundle size a bit by using external helpers from babel-runtime.
The main downside that I'm aware of is that the transform is paranoid to the point of also trying to polyfill e.g. Object.keys, and that there's no way to disable that separate from disabling all polyfilling.

I don't know. I really like Object.entries, Array.prototype.includes, &c.

They’re nice but from my experience with answering React issues beginners don’t really use them / know about them, and those who do know how to include a polyfill.
On the other hand, Promise causes a ton of problems because people use a bad polyfill that swallows errors, Symbol causes confusion because some optimizations require it, and fetch is just easy to forget accidentally.

I agree that adding 8 kB of polyfills to get a mostly working ES6 environment is a strict win.
I think the babel-runtime approach is worth investigating, assuming it's feasible to make a babel-runtime that doesn't try to polyfill Object.keys and other ES5 things.
You'd get the extra functionality if you needed it, and you'd only pay in bundle size for features that you actually use. The extra complexity is just a single additional Babel plugin.
(Also, selfishly, if there were a babel-runtime that didn't polyfill silly things, I'd use it everywhere – right now it's a size penalty on small-ish libraries because it tries to polyfill things that don't need to be polyfilled.)

Would you like to take a stab at implementing my proposal from https://github.com/facebookincubator/create-react-app/issues/170#issuecomment-235301948?

I think the babel-runtime approach is worth investigating, assuming it's feasible to make a babel-runtime that doesn't try to polyfill Object.keys and other ES5 things.

Agree, in the future.

The issue with babel-runtime is that it doesn't polyfill things that are used by dependencies in node_modules.  Increasingly (with the popularity of node v4/v5/v6 starting to overtake 0.10) people will start shipping modules to npm that depend on things like Map and Set being implemented.  It doesn't make sense for all of those modules to ship with separate polyfills for Map and Set.  Polyfills just don't work properly if they're not global.
I'm keen for us to implement @gaearon's solution in the short term.  In the longer term, we can make something clever enough to load only the required dependencies, but do so globally for all modules.

@ForbesLindesay The current proposal isn't polyfilling Map or Set anyway, though. In general I think library authors who use post-ES5 features other than maybe Promises or fetch should be using babel-runtime. It's what I try to do, anyway.
@gaearon I'm not sure I'll have time to look at it right now. I don't even know for sure that I imported those polyfills correctly. I'd prefer someone who actually has worked with core-js directly do this.

The current proposal isn't polyfilling Map or Set anyway

True.  I'm trying to come up with a solution that does let us start using those features.  In the short term, library author's may have to bundle polyfills for them, but we have an opportunity to change that by providing an efficient polyfill that's only provided if the code needs it.  We can easily statically analyse code to detect whether or not it uses Set and Map, just look for a global variable of that name.  If we provide polyfills only to apps that use them and only to browsers that don't already have them built in, that's a strictly positive thing.  It will also save a lot of pain that I've personally felt when deploying an app that has been mostly tested in chrome latest.

IIRC, using document.write to add polyfills can be a bad idea because:

It's not future friendly: the upcoming Feature API will include controls to disable document.write in a CSP-like way
A document.write will block the preloader and restart the parser, resulting in a slower first render

Of course the benefit of the polyfill service is that you get the feature detection done server-side, so you don't need to run JavaScript to figure out whether you need to load other JavaScript.
Our promise polyfill seems to serve most users' needs but it is not perfect, and we'd welcome a submission of a better one.

We can get round document.write anyway because we control the entire stack.  We could add code directly to the bundle to do the feature switching and document.body.appendChild if that turns out the perform better.
Re promise polyfills, I would suggest the promise npm module.  Once https://github.com/then/promise/pull/129 is merged you'll be able to simply require('promise/es6') to get only the standards compliant helper methods.  I've spent a lot of time optimising it and it's the implementation we use at Facebook.

#235

For now #235 covers fetch and Promise.
We can revisit this in the future and add more polyfills on a case by case basis.

This is shipped in 0.2.0 alpha, please feel free to provide feedback. Here's how: https://github.com/facebookincubator/create-react-app/pull/190

mark


Task Page and examples for Verifying Signed Images

Supersedes https://github.com/kubernetes/website/pull/31611
In support of https://github.com/kubernetes/release/issues/2383
Relevant KEP: https://github.com/kubernetes/enhancements/issues/3031
/sig security release docs
Notes:

This PR adds some automation to generate all the signed image names
We may have to update this as we add more images that are signed

Suggestion for a better placement of this source of truth of signed images is welcome!
/cc @saschagrunert @puerco @sftim

Fixes https://github.com/kubernetes/website/issues/31420
(forgot this earlier)

@saschagrunert @jihoon-seo updated as per your feedback

/assign @bradtopol
(based on bot comment)

/label tide/merge-method-squash

PR is ready for review now, after moving the fetching of signed images to SBoM
https://deploy-preview-32184--kubernetes-io-vnext-staging.netlify.app/releases/download/
https://deploy-preview-32184--kubernetes-io-vnext-staging.netlify.app/docs/tasks/administer-cluster/verify-signed-images/

All requested changes are pushed. Also, removed the go compiler as pre-requisite since we are not running any go program anymore.
Please let me know if I missed anything.
Note: We have not had a beta v1.24 release with all signed images yet! So we may want to keep this ready for merge (with /approve and /lgtm labels) but /hold it until we can verify for real, that the script works with signed release images.

/hold
based on https://github.com/kubernetes/website/pull/32184#issuecomment-1090887981

For components that aren't available as container images, do we provide an official way to verify those yet? If not, I recommend mentioning that no official mechanism is available there, so that people don't have to read source code etc to answer that question.

I think the MVP issue documents the scope is restricted to images only. Will let @saschagrunert chime in on if this would be useful to document as current limitation.
@sftim I have also addressed all the rest of the comments.

@sftim:  @PushkarJ is right, it's probable we will not get the other artifacts signed for 1.24. It makes sense to leave out the other verification types for now.

leave out the other verification types for now

From a docs point of view, it's useful to let people know what things aren't covered. When we explain that, we try to avoid statements about the future.
Phrasing like
For Kubernetes v{{< skew currentVersion >}}, the only kind of code artifact that you can verify integrity for is a container image, using the experimental signing support.

for example (using v{{< skew currentVersion >}} so that if eg nothing changes for the v1.25 release, the docs remain relevant).

Updated the download.md file with the text suggested by @sftim

/approve

@sftim can we lift the hold?

/unhold

@PushkarJ did you try this out with the beta release? How did it go?

@PushkarJ did you try this out with the beta release? How did it go?

I did not get a chance to test it before this was unheld and merged, since rc.0 is going to be first release with signed images ETA April 19 :( Either way seems unlikely we may need major overhaul of the script or guide.

@sftim just confirmed that the shell script works, but I think adding | jq is giving better looking results. Is it still possible to update this page? Demo: https://asciinema.org/a/488826


Changing registerEndpoint response

Hello!
I would like to test a component which renders different child components based on the response of a single API endpoint. Is there any way of changing the response of an endpoint registered by registerEndpoint or perhaps removing the endpoint once it is not needed any more in a test?
Here is a code example:
// @vitest-environment nuxt
import { describe, expect, it } from 'vitest';
import { registerEndpoint } from 'vitest-environment-nuxt/utils';

describe('Test 123', async () => {
  registerEndpoint('/test', () => ({
    test: 123,
  }));

  const { data } = await useFetch('/test');

  it('should return 123', () => {
    expect(data.value).toStrictEqual({ test: 123 });
  });
});

describe('Test 321', async () => {
  registerEndpoint('/test', () => ({
    test: 321,
  }));

  const { data } = await useFetch('/test');

  // Still returns { test: 123 }
  it('should return 321', () => {
    expect(data.value).toStrictEqual({ test: 321 });
  });
});

While fiddling around with the registerEndpoint source code I came upon a solution of some kind which solved my problem and might serve as an idea worth adding:
function registerEndpoint(url: string, handler: EventHandler) {
  // @ts-expect-error private property
  if (!window.__app) return;
  // @ts-expect-error private property
  const existingEndpoint = window.__app.stack.find((item) => item.route === `/_${url}`);
  if (existingEndpoint) {
    // @ts-expect-error private property
    window.__app.stack[window.__app.stack.indexOf(existingEndpoint)].handler = handler;
  } else {
    // @ts-expect-error private property
    window.__app.use('/_' + url, defineEventHandler(handler));
    // @ts-expect-error private property
    window.__registry.add(url);
  }
}

You can also just make the function you give a vitest.fn mock function.
so like
const api = vitest.fn().mockResolvedValueOnce({
      result: [{id: 1}],
    });

registerEndpoint("/api/fake-call", api);

Either do it in different describe blocks or you can also just make the function you give a vitest.fn mock function.
so like
const api = vitest.fn().mockResolvedValueOnce({
      result: [{id: 1}],
    });

registerEndpoint("/api/fake-call", api);

I am not sure if vitest's parallel test execution adds problems for this. Workaround for that would still be different test suites/describe blocks perhaps. But i'm not sure if it's an issue in the first place.

It doesn't behave as you hope. Unfortunately it only uses the first registerEndpoint in the file despite how you setup blocks.
I've personally turned to splitting it up into specific files instead. So e.g.:

ComponentName.generic.nuxt.spec.ts (doesn't care about response)
ComponentName.empty.nuxt.spec.ts (has en empty response)
ComponentName.populated.nuxt.spec.ts (has a populated response)

It would be neater to have it all in one file, though, but at least I get to test it now.


GmapsFx loading with a warning and not giving directions

Hi,
For a little project I have to make a javafx application where I can show the user the route from one location to another one. Like in Gmaps. I searched a bit and found gmapsfx and implemented the Library in my code so the map is loaded, but there is one problem it is watermarked which not really is a bad thing because this is a school project, but whenever I open the app it comes with a warning screen like below:
enter image description here
https://github.com/rterp/GMapsFX/issues/149 here it states that when I use a specific constructor It should fix this problem but it still did not help me with it.
Furthermore, I tried to implement the navigation from point a to b like here https://rterp.wordpress.com/2016/08/22/mapping-directions-with-javafx-using-the-gmapsfx-directions-api/
But it does not work for me. I am still an amateur so I don't really know what the problem is my console does not give any errors in eclipse. Maybe I am missing something can someone help me, please?
controllerclass:
protected DirectionsService directionsService;
        protected DirectionsPane directionsPane;
        @FXML
        protected GoogleMapView mapView = new GoogleMapView("de-DE", "My-Google-Map-API-Key");;

        @FXML
        private TextField startAirportField;

        @FXML
        private TextField targetField;

        protected StringProperty from = new SimpleStringProperty();
        protected StringProperty to = new SimpleStringProperty();
        protected DirectionsRenderer directionsRenderer = null;

        @FXML
        private void toTextFieldAction() {
        	DirectionsRequest request = new DirectionsRequest(from.get(), to.get(), TravelModes.DRIVING);
            directionsRenderer = new DirectionsRenderer(true, mapView.getMap(), directionsPane);
            directionsService.getRoute(request, this, directionsRenderer);
        }

        @Override
        public void directionsReceived(DirectionsResult results, DirectionStatus status) {
        }

        public void initialize() {
            mapView.addMapInializedListener(this);
            to.bindBidirectional(startAirportField.textProperty());
            from.bindBidirectional(targetField.textProperty());
        }
        GoogleMap map ;

        @Override
        public void mapInitialized() {
            MapOptions options = new MapOptions();

            options.center(new LatLong(50.606189, -122.335842))
                    .zoomControl(true)
                    .zoom(12)
                    .overviewMapControl(false)
                    .mapType(MapTypeIdEnum.HYBRID);
            map = mapView.createMap(options);
            directionsService = new DirectionsService();
            directionsPane = mapView.getDirec();
        }

FXML
<?xml version="1.0" encoding="UTF-8"?>

<?import com.lynden.gmapsfx.GoogleMapView?>
<?import javafx.scene.control.Button?>
<?import javafx.scene.control.TextField?>
<?import javafx.scene.layout.AnchorPane?>
<?import javafx.scene.text.Text?>

<AnchorPane id="AnchorPane" prefHeight="443.0" prefWidth="711.0" xmlns="http://javafx.com/javafx/11.0.1" xmlns:fx="http://javafx.com/fxml/1" fx:controller="Controllers.mapsViewController">
   <children>
      <GoogleMapView fx:id="mapView" layoutX="-311.0" layoutY="-244.0" prefWidth="490.0" AnchorPane.bottomAnchor="0.0" AnchorPane.leftAnchor="0.0" AnchorPane.rightAnchor="0.0" AnchorPane.topAnchor="0.0">
         <children>
            <Text fx:id="startAirport" layoutX="50.0" layoutY="20.0" strokeType="OUTSIDE" strokeWidth="0.0" text="Startflughafen" />
            <Text fx:id="targetAirport" layoutX="250.0" layoutY="20.0" strokeType="OUTSIDE" strokeWidth="0.0" text="Zielflughafen" />
            <TextField fx:id="startAirportField" layoutX="50.0" layoutY="25.0" />
            <TextField fx:id="targetField" layoutX="250.0" layoutY="25.0" />
            <Button fx:id="drawLine" layoutX="425.0" layoutY="25.0" mnemonicParsing="false" onAction="#toTextFieldAction" text="Suche" />
         </children></GoogleMapView>
   </children>
</AnchorPane>

Log from eclipse:
Dez 23, 2019 5:17:03 PM javafx.fxml.FXMLLoader$ValueElement processValue
WARNING: Loading FXML document with JavaFX API of version 11.0.1 by JavaFX runtime of version 8.0.231
Dez 23, 2019 5:17:04 PM javafx.fxml.FXMLLoader$ValueElement processValue
WARNUNG: Loading FXML document with JavaFX API of version 11.0.1 by JavaFX runtime of version 8.0.231
[JavaFX Application Thread] INFO com.lynden.gmapsfx.GoogleMapView - Alert: Hide directions called
[JavaFX Application Thread] INFO com.lynden.gmapsfx.GoogleMapView - Alert: Hide directions called

did you find a solution?

Which version are you using?

@dlemmermann had the same issues. i used java 15.0.1 and javafx15.0.1

Which GMapsFX version?

2.12.0

Please upgrade to 8.0.0. The project ownership has been transferred and I am the new maintainer. Hence also the group ID has changed. Please change your dependency to
<dependency>
  <groupId>com.dlsc</groupId>
  <artifactId>GMapsFX</artifactId>
  <version>8.0.0</version>
</dependency>

i updated it, but it still gives me the same Alert. Where am i supposed to use the google api key? (if needed of course)

Just noticed that we have a Java 11+ branch. Please use 11.0.0. The Google API key is set like this:             googleMapView.setKey("AIzaSyDKjhxxxBygmij6QIqkOsgPZ5eKyk");

It seems that the 11 release never arrived on Maven Central. Please add jcenter as another repository if you want to use it.

where can i find where i can edit this

com.dlsc
GMapsFX
8.0.0

Please upgrade to 8.0.0. The project ownership has been transferred and I am the new maintainer. Hence also the group ID has changed. Please change your dependency to
<dependency>
  <groupId>com.dlsc</groupId>
  <artifactId>GMapsFX</artifactId>
  <version>8.0.0</version>
</dependency>

where can i find this in java project

My java version is 8 , what version of GMampsFX should i use ?

Java 8 version: https://search.maven.org/artifact/com.dlsc/GMapsFX/8.0.0/jar

I still have the exact same issues with java 11 and gmaps 11. did anyone find a solution
?

If I use googleMapView.setKey("api-key"); in the initialize method the watermarks are gone for me.

did you pay for a billing account on the google cloud website?

I'm doing it for a University project and google gives you a free trial for 90 days, up to 300€. So no, I will cancel it after the free trial as well. Does anyone know how to properly protect my API key for a GMapsFX project?

Same uni project I suppose. I need to do that too then

btw yes there are some setting in the api dashboard for restricting usage of the key. Otherwise you would have to store it remotely but that won't work for our project since you need to send it to the TA eventually

Yeah, I saw that but I'm not sure which protection method is the correct one for my project.


Using the input to change AM/PM does not update the time input view

I'm Submitting a ...
[x] Bug report
[ ] Feature request
[ ] Support request

Steps to Reproduce

Open the time view
Change the AM/PM portion of the timestamp in the textbox

Expected Results
The the toggle for AM/PM should update appropriately
Actual Results
The toggle does not update

Hi @mattbasta ,
I can't duplicate this problem.  It seems to work fine on our demo page.
Also looking into you code fix #446 it looks like you are trying to do this on "H" format which is a twenty-four hour format (am/pm doesn't apply).

I can confirm that this issue does in fact exist on your demo page. See the gif below.
This does operate on 'H'. The 24-hour hour value is what is kept in state and is used to calculate whether AM or PM is displayed. The bug that's resolved in this PR is that the value of AM/PM is based on the previous hour value (currently in this.state) rather than the new hour value (that's being calculated in calculateState()).

Interesting.  I think there might be more going on here.  To start if timeFormat is false it shouldn't show a time (a bug in the demo).  Switching the timeFormat to hh:mm A and doing changing just the "A" or "P" I can reproduce like the gif above.  However if I change the entire "AM" or "PM" portion it works as expected.

@layneanderson Changing the full two characters is two updates. On the second update, this.state has the correct value for hour, so it correctly computes the value. Changing the "a" to a "p" and updating any other character (with the obvious exception of the hour in certain cases) will also cause it to update to the correct timestamp.


[stable/chronograf] neither env nor envFrom are evaluated as templates, no ConfigMap support, inability to rename variables from secrets

Both configuration sources don't allow for templating (actually, envFrom kind of does because it's possible to create own secrets and use templating there).
Current code:
{{- if .Values.envFromSecret }}
        envFrom:
        - secretRef:
            name: {{ .Values.envFromSecret }}
{{- end }}

        env:
{{- range $key, $value := .Values.env }}
        - name: "{{ $key }}"
          value: "{{ $value }}"
{{- end }}

The above makes it impossible to correctly point Chronograf to Influx, which service name depends on {{.Release.Name}}. I can technically create a secret with INFLUXDB_URL and use templating there but I cannot reuse it for INFLUXDB_PASSWORD because I create passwords elsewhere and I can only have one secret.
I wouldn't have to store the password in 2 secrets if I could specify secrets one by one.
Proposed solution, unless I'm missing some existing feature I should know about:

Add

      envFrom:
      - configMapRef: {{ .Values.configMapName }}

Make env something like:

        env:

... existing code ...

{{- range $key, $secretName, $secretValue := .Values.secretEnv }}
        - name: "{{ template $key }}"
          valueFrom:
            secretKeyRef:
              name: {{ template $secretName . }}
              key:  {{ template $secretValue . }}
{{- end }}

Maybe also evaluate env values as templates.

        env:
{{- range $key, $value := .Values.env }}
        - name: "{{ $key }}"
          value: {{ template $value . | quote }}
{{- end }}

Please treat the syntax here as pseudocode. I'm not well-versed in Go Template Lang and its extensions and to be honest just want my Jinja (or better - not to render data with text interpolation, though I'm sceptical towards Lua).


Improve HHL/Shor deprecated messages

Summary
Add the alternative links to tutorials in the deprecation messages for HHL and Shor
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.3%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
57830

Relevant Lines:
68600

💛  - Coveralls


Fix nightly

Fixes a problem with serde_codegen generating Serialize on recursive structures.  Fixes #80

There is an issue with the Regex crate causing Rust nightly to cause an internal compiler error: https://github.com/rust-lang/rust/issues/34839
That's preventing this build at the moment, I'll try again tomorrow.


Implement typing test

Is your feature request related to a problem? Please describe.
We are lacking a typing test
Describe the solution you'd like
Implement a test using mypy
Describe alternatives you've considered
A good approach will be that the test will pass as long as the newly modified files pass mypy.
We can achieve this by selecting the files that have been modified on a later date than when we implement this issue.
Git always keeps the file creation/modify date, so we can make use of it.
We may want to implement a small (bash) script to collect the files that we want to test or adapt this test (at least for now).
Additional context
Consider using annotations and typing in all files. Also consider using the TYPE_CHECKING from typing to import types only used in annotations:
from __future__ import annotations
from typing import List, TYPE_CHECKING

if TYPE_CHECKING:
  from this.project import CustomType

def check_this_method(foo: List[CustomType]) -> int:
    return len(foo)

Mypy documentation: https://mypy.readthedocs.io/en/stable/
Basically:

Mypy will check all files (checking the imports as well) to see if we are using type annotations
Mypy will check the typing for all the objects, parameters, return values...

I'll try to get this done so we ensure that the code is typed from the start

Also I will use a different approach as the creation date is not kept correctly depending on the file system. I think it's not reliable.
I will use a commit hash instead, so all files modified after that hash should pass the mypy checks.


Removed deprecated signs in GF Latin Core

While we are trying to redefine what should be GF Latin Core, we agreed on removing deprecated signs. Indeed, Fontbakery fails if fonts don't match this glyphset, although it contains glyphs that are not necessary or in use anymore. This PR complete the 1st step of redefining the glyphset, see #423 for the complete proposal in progress.

@RosaWagner who do you want to review/merge this?

you haha, so my name is not the only one on this

I chatted with @rsheeter today about this
Since this is part of the glyphs sets, not the subset definitions, this is fine to merge; but one follow on could be to update the latin.nam used in the API.
Rod asked if we do want to do that, first someone (Rosalie, Marc, Simon, Felipe, etc) ought run an/some experiments on the TTFs in the github.com/google/fonts repo, to better understand the impact of this change.
That is, run the fonttools subsetter over the TTFs with both current and proposed latin.nam subsets, and tabulate and average the differences, then woff2 them both and tabulate and average those differences too, so we can know what the filesize reduction will be in the average case, for the top 5, 10 families, etc.
Also, Rod pointed out that the removed characters will likely move to the latin-ext.nam set, or a new set; the additional API transfers needed by users who do use the rare characters might be a net loss if latin-ext has a bunch of other stuff in it they don't use; and a new set wouldn't kern/shape with other sets, and for just these 3 characters (soft hyphen, division slash and ¤) a new set wouldn't make sense.


Fix linearizer failure 26 test

Closes #3839. #3530 handled summations of WHEREs, but not where consts were added to the WHEREs. Example:
$$
\sum_i^j 3 + f(i) = 3(j-i+1) + \text{clamp(...)}
$$
but the const 3 multiplication by the loop was not implemented - no tests failed until now.

Code updated - I also added a check that loop vins are consts which I had assumed was true before. There was an attention module which had a var as part of the loop start so it failed the assumption - maybe an opportunity for more performance improvement later
https://github.com/patosai/tinygrad/blob/54dc48aa47aa6e4df612d5b5f349f40b2aaa186a/test/test_assign.py#L143

thanks! yea i am interested in arange optimization for variables, it might be similar to O(n) embedding too


Websocket test for large messages

Per the following post it appears that messages were being truncated by the websocket client or server. This pull adds unit tests for http[s] normal websocket communications and one large message test. The large message test passed out of the box. After investigation it turns out that downgrading from WebSocket4Net 0.11 to 0.10 causes the issue to occur. The api client was already upgraded to 0.11 in this commit on 12-23. Assuming it's been released to nuget already this issue should be resolved.
To reproduce the failure use the package manager console on the test project and run:
Install-Package WebSocket4Net -Version 0.10
comment out dispose in the test as thiswas not added till 0.11. You should see the test fail.

great stuff, thanks!

No problem. I'll leave it to you to comment back to the poster on the forums.

Yes, awesome.  Did you test this on a Windows 7 server?

It doesn't matter anymore. there's no more difference between win 7 and 8.

Just for completeness I did. Windows 8 and I don't get along so well.


Publish 8.5-20231111011655+0000

Publish 8.5-20231111011655+0000

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


Using chart version 0.2.2 from github-pages produce error "Secret is invalid"

Example as in  README.md
helm upgrade --install ollama ollama/ollama \
    --namespace=ollama \
    --create-namespace \
    --set ui.type=open-webui \
    --set ui.image.repository=ghcr.io/open-webui/open-webui

Error:
Release "ollama" does not exist. Installing it now.
Error: create: failed to create: Secret "sh.helm.release.v1.ollama.v1" is invalid: data: Too long: must have at most 1048576 bytes

I belive this is becasue ollama-0.2.2.tgz  conatains  hidden folder '.cache' with older releases
I asume that adding  '.cache'   to .helmignore will help.
Adding '.github' to  to .helmignore will be nuce as well.

@skarzhevskyy Thanks for reporting, fixed and could you try the new version?

Thanks.  helm version 0.2.3 works as expectd.


refactor: delete unused serviceoffering classes in quota module

Description
Deletes unused serviceoffering related classes in the quota module
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[x] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5926

@blueorangutan test

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-6425)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39836 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7439-t6425-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_02_list_cpvm_vm
Failure
0.03
test_ssvm.py

test_04_cpvm_internals
Failure
0.03
test_ssvm.py

test_10_reboot_cpvm_forced
Error
6.24
test_ssvm.py


Add device condition support to the device_tracker integration

Add device condition support to the device_tracker integration.
Device conditions are part of Device Automations, a new concept that was recently launched to make automations more user friendly.
Device automations consist of three different parts: triggers, conditions and conditions. This issue is about the condition part.
To get started with this issue, you will need to set up a Home Assistant development environment. The easiest approach is to get started using a dev container.
Once you have a development environment set up, run the following and follow the instructions:
python3 -m script.scaffold device_condition

(This issue is part of #26994)

Hey, I can do this one too!


Set wasmtime::component::values to be public

I'm trying to call an exported function with signature func (seq: list<s64>) -> s64, but I find that I can't construct wasmtime::component::Val::List(wasmtime::component::values::List()) since wasmtime::component::values::List is not public.
Feature
Add pub to https://github.com/bytecodealliance/wasmtime/blob/e10094dcd6d0354628255a6f2e69c1e4c327d6e7/crates/wasmtime/src/component/mod.rs#L16
Benefit
If accepted, We can invoke functions which contains a param with type list
Implementation
Just add a pub prefix
Alternatives
May be no alternatives available?

At the moment, you can construct a list Val by way of wasmtime::component::types::List::new_val https://docs.rs/wasmtime/latest/wasmtime/component/types/struct.List.html#method.new_val - does that meet your needs?
I think it would be ok to make the values mod public, just on the grounds that if the Val enum is public, the types in all of its variants should be as well (https://docs.rs/wasmtime/latest/wasmtime/component/enum.Val.html), but I don't know if there is something about the design of using the types module to construct Val vs the direct use of the enum that I am missing. @alexcrichton what do you think?

The original intention was to reexport everything necessary form the values module into the top-level component module, so this may be a forgotten reexport?

Ok! I'll add the forgotten reexports :)


Fix broken symbols when using node.js on Windows with default terminal fonts

This pull request fixes - imho - a major annoyance with Mocha when running with node.js on Windows.
Several reporters (dot, list and spec) use special unicode symbols for visualising check marks (✓), error marks (✖) and small dots (․).
Sadly, default terminal fonts for Windows don't support these symbols. While mocha itself works just fine, it is somewhat annoying that your console gets filled with odd placeholder characters. This problem can be worked around by installing a custom font, such as DeJavu Sans Mono (http://stackoverflow.com/questions/9817926/how-can-i-get-mochas-unicode-output-to-display-properly-in-a-windows-console). Given this requires extra work, I'm pretty sure many developers just live with the broken symbols.
This pull request introduces a fix to this problem as follows:

A new, common symbol map containing symbols for check mark, error mark and small dots has been added to reporters/base.js
In case Node.js/Windows are detected, the default symbol map is modified to fall back to use symbols that are readily available on default console fonts
Reporters (dot, list, spec) have been modified to use special symbols from the symbol map

Great, now we have to include two sets of test fixtures, one for win32 and one for the rest of the platforms that are doing it correctly 😁

chcp 65001 anyone before running mocha? or will this not work?


wine{Unstable,Staging,-mono,tricks}: update to latest version

these are the updates:

wineUnstable: 3.11 -> 3.13
wineStaging: 3.11 -> 3.13

winemono: 4.7.1 -> 4.7.3

winetricks: 20180513 -> 20180603

this pr is currently building on my laptop, but it takes ages. will report success in a few hours ;)

wineWowUnstable works, as does winetricks, so this is probably merge-able.


Failed to parse non-indented forwarded emails

We've recently seen many forwarded emails that did not have any indentation (not sure the vendor/client application that does this).
But the fact is that the email cannot be parsed and we cannot extract the contents.

Any recommendation for this? Do you consider this is a bug?

Hey Katlim! Can you extract and post the raw email / EML? Anonymized if possible. I'll take a look.


Add FHIR Search to io/gcp/healthcare/FhirIO

Add FHIR Search to io/gcp/healthcare/FhirIO
R: @lastomato
R: @pabloem

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Please add @pabloem as a reviewer as well.

R: @pabloem

Hey @pabloem, just want to note that I ran a reformat code on FhirIO.java and hence the large number of changed lines. For reviewing my code, you can look at the commits before the "Reformatting and comments" commit. Thanks!

hi @janeliulwq ! I'll start taking a look now. Thanks!

Run Java PreCommit

Run Java PreCommit

Run Java_Examples_Dataflow PreCommit

hi @janeliulwq ! Sorry that it took me a while to get back to you. Looking at the failures, it seems like they are complaining about using .* imports (https://scans.gradle.com/s/tb3kqekv6lmac/console-log?task=:sdks:java:io:google-cloud-platform:checkstyleMain) - can you revert back to importing individual classes?

hi @janeliulwq ! Sorry that it took me a while to get back to you. Looking at the failures, it seems like they are complaining about using .* imports (https://scans.gradle.com/s/tb3kqekv6lmac/console-log?task=:sdks:java:io:google-cloud-platform:checkstyleMain) - can you revert back to importing individual classes?

Ah I see! Thank you for digging, done!

Run Java PostCommit

Run Java PostCommit

@janeliulwq note that a FhirIO integration test failed: https://ci-beam.apache.org/job/beam_PostCommit_Java_PR/522/testReport/junit/org.apache.beam.sdk.io.gcp.healthcare/FhirIOSearchIT/testFhirIOSearch_R4_/
I'm rerunning to see if it's a flake, but it will be worth investigating

Also two instances of the test failing in this rerun:
https://ci-beam.apache.org/job/beam_PostCommit_Java_PR/523/testReport/

Hmm I see you're doing a streaming pipeline - it may be most convenient to use a batch pipeline - so instead of reading from pubsub, you just do p.apply(Create.of(MESSAGE)), and the pipeline should run much faster (and have fewer dependencies and likely complications) - could you try that?

 Thank you Pablo for your pointers, after I switched the integration test to batch mode, I discovered an actual bug in the implementation that was causing the failures. Lmk if there's anything else to be done on my end. Thanks!

I've added a jira issue to track any other discussion

Thanks @janeliulwq !


Input::file() doesn't work with multiple files

I am trying to use Input::file(); to get multiple files. It seems if I pass in more than one file an array of just one file is returned.
Is this a known issue or am I using the wrong method?
Thanks

How about if you have multiple input:
Photo 1:

Photo 2:

$file_upload = [];
$("input[name=name]").each(function()){
$upload_val = $(this).prop('files')[0];
$file_upload.push($upload_val);
}
how does laravel handles this in the back end?

@barryvdh, thank you so much it works for me


Add support for linked template variables

Currently multiple variables can only be combined as a cartesian product. For example the following code snippet will expand like so
Input
#[metafor(marker_trait = [MarkerTraitA, MarkerTraitB], target_type = [TypeA, TypeB])]
impl __marker_trait__ for __target_type__ {}

Output
impl MarkerTraitA for TypeA {}

impl MarkerTraitB for TypeA {}

impl MarkerTraitA for TypeB {}

impl MarkerTraitB for TypeB {}

There is no way to link the marker_trait and target_type variables such that the following two items are generated
impl MarkerTraitA for TypeA {}

impl MarkerTraitB for TypeB {}

The two versions of the proposed syntax for achieving that would be the following.
Struct Version
#[metafor(types = [{ marker_trait: MarkerTraitA, target_type: TypeA }, { marker_trait: MarkerTraitB, target_type: TypeB }])]
impl __types__marker_trait__ for __types__target_type__ {}

Tuple Version
#[metafor(types = [(MarkerTraitA, TypeA), (MarkerTraitB, TypeB)])]
impl __types__0__ for __types__1__ {}

The advantage to the struct version is that the templated item is easier to read, while the advantage of the tuple version is that the attribute is much more concise and less noisy. It might be best to support both versions of syntax so that the user can choose which version works best for their use case.

This feature has been added. Both the tuple and struct version


cmake fails with clang related errors

Describe the bug
I upgraded to image version 0E210 and tried to build Filer again from scratch. I checked out the repo, created a build directory and did cmake .. from within, but got this error:
hellochris% cmake ../
-- The C compiler identification is Clang 10.0.1
-- The CXX compiler identification is Clang 10.0.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - failed
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc - broken
CMake Error at /usr/local/share/cmake/Modules/CMakeTestCCompiler.cmake:66 (message):
  The C compiler

    "/usr/bin/cc"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /home/chris/Projects/Filer/build/CMakeFiles/CMakeTmp

    Run Build Command(s):/usr/bin/make cmTC_7341e/fast && /usr/bin/make  -f CMakeFiles/cmTC_7341e.dir/build.make CMakeFiles/cmTC_7341e.dir/build
    Building C object CMakeFiles/cmTC_7341e.dir/testCCompiler.c.o
    /usr/bin/cc    -o CMakeFiles/cmTC_7341e.dir/testCCompiler.c.o -c /home/chris/Projects/Filer/build/CMakeFiles/CMakeTmp/testCCompiler.c
    Linking C executable cmTC_7341e
    /usr/local/bin/cmake -E cmake_link_script CMakeFiles/cmTC_7341e.dir/link.txt --verbose=1
    /usr/bin/cc CMakeFiles/cmTC_7341e.dir/testCCompiler.c.o -o cmTC_7341e
    ld: error: unable to find library -lgcc
    ld: error: unable to find library -lgcc
    cc: error: linker command failed with exit code 1 (use -v to see invocation)
    *** Error code 1

    Stop.
    make[1]: stopped in /usr/home/chris/Projects/Filer/build/CMakeFiles/CMakeTmp
    *** Error code 1

    Stop.
    make: stopped in /usr/home/chris/Projects/Filer/build/CMakeFiles/CMakeTmp

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:2 (project)

-- Configuring incomplete, errors occurred!
See also "/home/chris/Projects/Filer/build/CMakeFiles/CMakeOutput.log".
See also "/home/chris/Projects/Filer/build/CMakeFiles/CMakeError.log".

To Reproduce
Steps to reproduce the behavior:
Install version 0E210, check out Filer, attempt to run cmake
Version
https://github.com/helloSystem/ISO/releases/tag/experimental-12.2
0E210

Befoer the change above, hello-0.5.0_0E213-FreeBSD-12.2-amd64.iso was 1.28 GB.

Thanks for reporting @moochris .
On 0E219+ (without deleting the .a files from the ISO) it compiles again. Probably deleting the .a files from the ISO was causing more hassle than it has advantages.

Oh OK, great - I will update


Updated validations.py python script.

Fixed the behavior of validate_user function in validations.py.
Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify i

@googlebot I signed it!


feat(rust): support modular protocol parsing in ockam crate

The general design of this protocol parsing approach is this:

A worker that wants to parse many different protocols creates a ProtocolParser<W>. This type  is generic for the worker it is being implemented for
Each protocol has a type that implements the ParserFragment<W> trait

This trait is used to let the main protocol parser know which protocol IDs it can handle

There is a UserParser<W, T> closure type which MUST be used by any parser implementing ParserFragment<W>

W is the worker for which this parser type is implemented, and T is the response type given to the user to map to worker state
Example: stream::ResponseParser is generic over W but constrains T: stream::responses::Response

Initialising the ProtocolParser SHOULD happen in the worker's initialize function.

Use .attach(...) to register a type implementing ParserFragment<W> with the ProtocolParser

Parsing can then be handled by the ProtocolParser in the worker's handle_message function

Due to borrowing constraints a user must first call .prepare() on the parser
The parser then takes a mutable borrow of the worker state and the message being parsed

The UserParser<W, T> closure gets access to the mutable worker state

This means no closure environment is being captured --> the closure is Send and Sync
Each protocol-specific UserParser can then match on the incoming message type

Example
There is a full example worker using this mechanism in the ockam_examples crate.
#[derive(Default)]
struct MyWorker {
    parser: ProtocolParser<MyWorker>,
    stream: Option<String>,
}

#[async_worker]
impl Worker for MyWorker {
    type Context = Context;
    type Message = Any;

    async fn initialize(&mut self, _: &mut Context) -> Result<()> {
        self.parser
            .attach(ResponseParser::new(|worker: &mut Self, msg| match msg {
                Response::Init(Init { stream_name }) => worker.stream = Some(stream_name),
                _ => { /* ignore messages */ }
            }));

        Ok(())
    }

    async fn handle_message(&mut self, ctx: &mut Context, msg: Routed<Any>) -> Result<()> {
        self.parser.prepare().parse(self, msg)?;

        println!("Stream name is now: `{:?}`", self.stream);
        Ok(())
    }
}

Really cool stuff. Merged


Sorting and filtering does not work for datetime columns

Only for JSON types (string, number, boolean, array, object). There is no standard for date/time format in JSON
But you can use a callback fn :
<Th {handler} sortBy={(row) => row.myDate.toISOString()}>Date</Th>

<ThFilter {handler} filterBy={(row) => row.myDate.toISOString()}/>

Outside of components :
const handler = new DataHandler(data)

handler.sort( (row) => row.myDate.toISOString() )
handler.filter( '2023', (row) => row.myDate.toISOString() )


Add rate limiting to various login endpoint

This can also be solved by using NGINX to reverse proxy the websites, maybe we can create a blessed image that deploys the website like so?

This can also be solved by using NGINX to reverse proxy the websites, maybe we can create a blessed image that deploys the website like so?

@bbockelm suggests doing it in Go as Go has a good support for built-in rate limiting functions so we don't have to add extra overhead, although I need to confirm how we can use them. But NGINX looks good to me as the long-term path to go.

Ah slick, that sounds good to me.


Freeform text field in need creation UI

User Story:
As a Social Worker, I need a way to communicate specific/unique needs of children coming into care so that Volunteers can evaluate whether they are willing and able to accept the request.
Dependencies:

Is blocked by #180

Examples:

The child(ren) is ill
The child(ren) has head lice.
The child(ren) has a special need, e.g., is autistic or deaf.
The child(ren) is recovering from surgery.

Acceptance Criteria:

[ ] A user creating a need has the ability to add notes for each child included in the request.
[ ] The notes entered by the user creating the need are visible to volunteers who are viewing the need.

Hi @sarahwicks, @nvick!
I'm trying to get involved and this one also looks like a good first issue for me which I can tackle, should I pick this one up?

@haseebelahi I believe this one is actually dependent on another issue (#180). I'm removing the "good first issue" label for now.
@sarahwicks can you confirm my understanding that #180 needs to be completed before this can be implemented? In order to add notes for each child, need details regarding children must be entered individually.

A user creating a need has the ability to add notes for each child included in the request.

Ok, I can work on #180 as well if that needs to be done before this!

@haseebelahi, @benjaminwood - Yes, this is blocked by #180. I updated the ticket and indicated the dependencies on both tickets. Thank you! cc: @SarahOMD @DarcyBlank


Ethernet drivers blocked by windows

Environment
Windows build number: [Version 10.0.20251.1]
Your Distribution version: [On Debian or Ubuntu run `lsb_release -r` in WSL]  // None yet
Whether the issue is on WSL 2 and/or WSL 1: [run `cat /proc/version` in WSL]

Update issue same as : #5911
Steps to reproduce

After enabling the Virtual Machine Platform feature with windows features or using the following command dism.exe /online /enable-feature /featurename:VirtualMachinePlatform /all /norestart, after rebooting windows blocks my ethernet drivers with a Code 48. The exact error message is as follows: The Software For This Device Has Been Blocked From Starting Because it is Known To Have Problems With Windows’ Error on Windows (Code 48) . I have VT enabled in bios.  Ethernet Card: Realtek Gaming GbE Family Controller.

WSL logs:  None
Expected behavior

I should be able to turn on virtual machine platform and the ethernet port should not break
Actual behavior
After enabling the above feature, device manager says the code 48 message.

/dupe #5911

/dupe #5911

Well, if you consider the issue is with "Windows Virtualization Platform", then I would agree it is an duplicate.  But if the issue is from Intel side then this issue about need an intel driver update for intel wireless card, where as the other issue is about needing an intel driver for intel ethernet card.


Question: puppet-service stop problem

When we call puppet.stop() (by calling bot.stop()), our exception for puppet-service and local puppet is different:
local:
we wish to shut down the system completely, so the puppet should be stopped.
remote:
we wish to disconnect from remote puppet server and stop the local puppet-service, this is the same as the local part. However we want the remote server remain online and be ready for new connections.
Suggestion:
We can not calling remote stop() for in puppet service, or add an option for that. e.g.:
puppet-service.ts
  override async onStop (stopRemote = false): Promise<void> {
    log.verbose('PuppetService', 'onStop()')

    this._cleanupCallbackList.map(setImmediate)
    this._cleanupCallbackList.length = 0

    if (this._grpcManager) {
      log.verbose('PuppetService', 'onStop() stopping grpc manager ...')
      const grpcManager = this._grpcManager
      this._grpcManager = undefined
      await grpcManager.stop(stopRemote)
      log.verbose('PuppetService', 'onStop() stopping grpc manager ... done')
    }

    log.verbose('PuppetService', 'onStop() ... done')
  }

grpc-manager.ts
async stop (stopRemote): Promise<void> {
    log.verbose('GrpcManager', 'stop()')

    /**
     * 1. Disconnect from stream
     */
    log.verbose('GrpcManager', 'stop() stop stream ...')
    this.stopStream()
    log.verbose('GrpcManager', 'stop() stop stream ... done')

    /**
     * 2. Stop the puppet
     */
    if (stopRemote) {
        try {
          log.verbose('GrpcManager', 'stop() stop client ...')
          await util.promisify(
            this.client.stop
              .bind(this.client),
          )(new puppet.StopRequest())
          log.verbose('GrpcManager', 'stop() stop client ... done')
        } catch (e) {
          this.emit('error', e)
        }
    }

    /**
     * 3. Destroy grpc client
     */
    try {
      log.verbose('GrpcManager', 'stop() destroy client ...')
      this.destroyClient()
      log.verbose('GrpcManager', 'stop() destroy client ... done')
    } catch (e) {
      this.emit('error', e)
    }

    log.verbose('GrpcManager', 'stop() ... done')
  }

However we want the remote server remains online and be ready for new connections.

Could you please explain why your puppet service server can not "remains online" and "be ready for new connections"?
From my understanding, the Wechaty Puppet Service Server is controlled by the IoClient and PuppetServer and they should provide all the "online" and "accepting new connections" functionality instead of the Wechaty and Wechaty Puppet?

You are wring, we close too many things in puppet-wxwork's stop()

but that make PuppetService.reset() a very heavy load

Could you please confirm whether the puppet wxwork can pass the "perfect restart" integration test locally?
If not, we need to improve it to pass the test first;
If yes, how heavy does it have, could you please explain them in detail, so that we can have a look at them?

I understand your design now and this question no longer bothers me. Issue should be closed.


Use RandomizedSearchCV and point to max_leaf_nodes

closes #314

The output is not rendered anymore either...

I merged main to trigger a clean re-render without the CI cache problem.


trivial-builders: add meta to writeShellApplication

Description of changes
This enables adding meta properties to shell applications created in Nix. For eg., to set meta.description which appears in nix flake show --json
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2613