File .ts and .log files in a dedicated folder

Since I install this integration I've seen the the "config" folder being completely full of "eufy_security-Txxxxxxxxxxxxxxx.ts" and "ffmpeg-11111111-111111.log" files.

Can these files be automatically stored in a dedicated eufy folder?
Can these files be purged from the system after x amount of time?

Unless I am missing something here I don't think there is an option to actually avoid having all of these files being created directly under "config" folder.

Please go through readme file, i will soon remove file based p2p streaming support

I see! That's what you meant by the comment on your readme. Super! Thanks and keep up the good work ;)

Yeap, install RTSP add on and you will be free of files and have much more faster streaming. Moreover, check WebRTC, your experience will be upgraded

I have it installed and enabled it on the integration but doesn't seem to work for the 1080 battery doorbell. I'll give it another try.
I suppose I can delete the .rs and .log files manually?


Requirements for um_fields_subset.py

Drafting some requirements for um_fields_subset.py to help out with refactoring / unit-testing / regression testing:
General requirements
Primary functionality: Remove fields from a UM file, generating an output UM file with only a subset of its initial fields in it.
Python version: >=3.10
Audience: Researchers / ACCESS model users
Mode of use: Offline. To be run manually by the user.
Interface type: CLI
Interface requirements
Inputs: Input file (positional argument) [UM file, required]
Outputs: Output file (output path provided by the --output option)
Options:

-p, --prognostic-only: Include only STASH item codes of prognostic variables (section 0,33,34). Cannot be used together with --include or --exclude.
--include: List of STASH item codes. Only these fields will be included in the output UM file. If not present in the input file, raise a warning. Cannot be used together with -p/--prognostic-only or --exclude.
--exclude: List of STASH item codes. These will be the only fields excluded from the output UM file. If not present in the input file, raise a warning. Cannot be used together with -p/--prognostic-only or --include.
-o, --output: output path (if not provided a default output path is produced)

Note:
Feel free to add specifications/options if I missed any relevant one.

We would still want the section option correct? Allowing the user to get rid of sections.

We would still want the section option correct? Allowing the user to get rid of sections. Or do we just want it to be by specific STASH codes given

No, I think just the specific STASH codes will do.


Integrate adblocker functionality

Interesting tip from HN (for Dashblock):
Maybe you already do it, but I think integrating adblocker functionality when loading JS sites would be desirable to reduce load time. And if ads are what the API user is interested in, perhaps add a flag for whether or not one wants ads to load. Recommendation: https://github.com/cliqz-oss/adblocker Should be the fastest adblocker library (used by Ghostery, Cliqz and Brave)

This could be integrated into Apify.launchPuppeteer() function as useAdBlock: true option.
https://sdk.apify.com/docs/api/apify#module_Apify.launchPuppeteer

Greetings. So the thing would be to implement ad blocker to increase the speed of the scrap/crawl? I could work on this 🙏

Yes exactly, it could boost the speed especially for some websites that are heavy on ads (news sites). But it would be great to first test this assumption. Would you be interested also in trying this out? Use Apify SDK to run scraper with and without ad blocker against some websites?

Sure! I can set up a test and run it to check this first with some timing debug, I'll create it and run it, then attach it here for you to see, thank you 🚀

interesting. I manually block all the common ad networks using blockRequests, this would offload the task to the extension

Makes sense for a lot of users I guess but fyi it's an explicit anti-feature with usecase-killing effect for me. I'd need this off with zero sideeffects on current behavior.

Makes sense for a lot of users I guess but fyi it's an explicit anti-feature with usecase-killing effect for me. I'd need this off with zero sideeffects on current behavior.

In the small POC I proposed a while ago https://github.com/apify/apify-js/pull/600, the feature is completely disabled by default and only does some work when blocking is enabled by the user.

Yeah, sorry @remusao . We still have not figured out if the performance will improve or not. I apologize.

Yeah, sorry @remusao . We still have not figured out if the performance will improve or not. I apologize.

Of course, no worries at all, I just wanted to make clear to @matjaeck that there should be a way to integrate such a feature without any overhead when it's disabled.


ScenarioDbManager - Automatically add the ScenarioTable to the input_db_tables

In the sub class of ScenarioDbManager.init() , the user now will need to include the ScenarioTable as the first entry in the inputs_db_tables OrderedDict.
E.g.:
class ReadyMixDbManager(ScenarioDbManager):
    def __init__(self, input_db_tables: Dict[str, ScenarioDbTable]=None, output_db_tables: Dict[str, ScenarioDbTable]=None,
                 credentials=None, schema: str = None, echo=False, multi_scenario: bool = True):
        if input_db_tables is None:
            input_db_tables = OrderedDict([
                ('Scenario', ScenarioTable()),
                ('Location', LocationTable()),
                ('Plant', PlantTable()),

Instead, automatically insert (if is is not in the user-supplied inputs_db_tables )

Added in v<IP_ADDRESS>b
For backwards compatibility, only adds if it doesn't already exist.
Including a check if Scenario table exists but is not first in the Dictionary


Is this package still maintained? If not can you recommend alternative?

Hey there,
This package is excellent but I am worried it's not being maintained anymore, is it?
Is there a similar alternative?

I started working on a port to typescript a while back but hadn't had time to pick it back up
https://github.com/newbish/ethereum-events/tree/master


Rewrite install docs

Extracted from #84.
Notes:

The left menu is messed up with this PR. Do not pay attention as it is being set up for further commits.
This is only about the content of the install docs. The rest is irrelevant, just came with other changes in commits coming from #84.
The install doc will be easier to parse when my commit to add Table of Contents make it in (future PR).
Links to any guides obviously fail at the moment as I haven't imported them here.

@astorije Didn't we have a note about $PATH and Yarn before? Seems to be gone here.

@astorije Didn't we have a note about $PATH and Yarn before? Seems to be gone here.

We did but I removed them as part of linking to the official Yarn documentation. It depends on system, preferences on how to install, etc. so not something I want to be involved with 😅
The Yarn install page clearly documents that, and they do change things from time to time so I don't want to have to keep track of that here.
I assume here that if you have Yarn installed, you have it installed correctly.
What do you think?

I assume here that if you have Yarn installed, you have it installed correctly.

Well the problem here is that their install guide says nothing about it. I think a simple note block saying You need to have output of \yarn global bin` in your `$PATH` for `thelounge` to be available` would be enough.

Do you actually need this when following their doc at https://yarnpkg.com/en/docs/install#debian-stable, i.e. installing from apt-get?!
On macOS, they do document it, see under "Path Setup" of https://yarnpkg.com/en/docs/install#mac-stable which is why I'm surprised.
If this is needed, I'd rather we open a PR on their end to improve their website, that seems more sensible than documenting Yarn on ours :/

Hm yeah, macOS documentation there does document it, while debian and windows ones do not.
Ideally yes, their documentation should be updated, but I still think a note block in our docs would not hurt at all.

Alright, I re-used the same wording as https://yarnpkg.com/en/docs/install#mac-stable and https://yarnpkg.com/en/docs/install#alternatives-stable. They currently have an open PR to add the missing piece to Unix/Linux systems (https://github.com/yarnpkg/website/pull/827, subscribed to follow), we can remove those blocks once it's there.
Let me know what you think.

I'll wait for confirmation about Docker changes from @williamboman before merging this.


Support background color

Add setBackgroundColor and setDataBackgroundColor to the plot API

setBackgroundColor allow to custom the full background of the widget (including the background bellow the plot data)
setDataBackgroundColor allow to custom the background bellow the plot data only

Closes #2220
The OpenGL backend is not part of the PR

I made a PR on your branch with the OpenGL implementation and a patch in PlotWidget to set the dirty flags so that the plot is updated when changing the background colors.
Otherwise LGTM.

Thanks a lot, i did not expect it for now :-)

That was really simple, no need to add it to pending stuff...


Contributing URL is broken

https://circe.github.io/circe/contributing.html -> returns 404

@LLCampos Thank you.  This is fixed now.


Adding support for authentication token

So I'd love to be able to pass a Bearer token as an authentication header in Vandal, as my API is  only readable with a user session (via Devise) or Api Token. I'd imagine many APIs would likely have this same constraint. I'd be willing to lend a hand to help, although this repo only contains the compiled JS.
Edit: I found the Vandal gem, so I'd imagine we could add auth headers somewhere around here. It would also involve a bit of UI update to enter them.

Hey @geeosh!
I would love to get a PR in for this, and think you have the correct read on the issue. That said, I currently use request.ly to authenticate against my API. It's nice because it works not just with Vandal, but even hitting the API in a browser directly (we use JWT headers and not cookies).


Functions agent

Experimental, not fully optimized, but this will be the de facto manner once the optimizations and improvements are made.
New Feature as of today 6/13: Function calling and other API updates

The immediate benefits:

faster tool selection
less priming/token usage for selection,
has room to be creative, so you can use higher temps on the Agent Settings

Long-term benefit as we iterate on this:

I can optimize the chain as well as the final output
all existing/future tools will have massive improvements/reliability with multi-input calls
I added a multi-input or StructuredTool version of Stable Diffusion so that the new functions-compatible model knows it accepts multiple inputs. Read more about it in the langchain docs, note: this doesn't have the best documentation at the moment.
As already mentioned, even with single input plugins, the new models overall better at tooling
Todo: update docs for making a StructuredTool compatible with this project, and to reflect other changes made in this update

other changes are minor: tools directory was re-organized to be more coherent

Todo: update all current plugins to multi-input versions

Comparison Example
User prompt: Generate me a picture of Sunny (a corgi discussed about in prior messages)
Classic mode
{
	plugin: Stable Diffusion
	input: photo of a Pembroke Welsh Corgi with a bright red coat, white markings on face, chest, and paws, perky ears, warm
	brown eyes, bushy tail, energetic, playful, social, intelligent, easy to train, loves cuddling, 8k UHD, natural lighting, happy,
	friendly | cartoon, sketch, low quality, ugly, mutation, deformed
	thought: The user wants a picture of Sunny, the corgi I just described. I can use the stable-diffusion tool to generate
	an image that matches the description.
}

Pros: Great at planning and multi-modality
Cons: High token use, limited to single inputs, unreliable response formats
Functions mode
{
	plugin: Stable Diffusion
	input: {
	    "prompt":"photo of a Pembroke Welsh Corgi, red coat, white markings, perky ears, brown eyes, bushy tail,
	    happy expression",
	    "negative_prompt":"cartoon, sketch, unrealistic, CGI"
	}
}

Pros: Highly Efficient, multi-input tooling, less token use, reliable response formats
Cons: unreliable with multi-modal queries, ends chains prematurely
Conceptual To-Do: Implement a solution that utilizes the strengths of both
I've improved the cons of the Functions Agent by using strong language in the instructions, but may still experience issues.
What's changed

A new Agent mode was created, in very similar format to OpenAIAgent from langchainjs with chat memory. The OpenAI agent was introduced to langchain with its introduction of the functions-compatible OpenAI models in this update: https://github.com/hwchase17/langchainjs/pull/1631

The code can be found api\app\langchain\agents\Functions

Wired up the ChatAgent for handling of the new Functions agent mode

might be anecdotal but updated/new models are more obedient when referred to as Assistants, rather than 'ChatGPT', so all mentions of the latter in priming were removed.
intermediateSteps are handled differently due to object inputs for actions
loadTools is passed a boolean to determine if agent is in Functions mode
loadTools will switch to a StructuredTool version of an existing Tool if in functions mode

Added new test for loadTools testing the function above
Refactored/reorganized tools directory
Frontend/Backend were updated to handle the new agentOptions prop: agent

@danny-avila your PR description is awesome

@danny-avila your PR description is awesome

Yea, I have to agree. Thanks for doing that. I'm constantly amazed at how you're able to stay at the forefront of emerging technologies because I hadn't even heard of Function agents yet and you already had a PR up for it, so this description was really helpful for understanding what this new feature was.


Addition of Attacks/Reports

I have added attacks/reports column and added some reports. This can be expanded further and more reports/attacks can be added.

I have added it. Cheers :)


Unhandled message type: {"code":{"lang":"hoon","code":"?~  work  ~~"}}

Describe the bug, optionally with screenshots
Clicked the Support chat channel on mobile (iOS) and got this error.
Steps to reproduce the behavior:

Be on iOS
Click on Support chat channel in Tlon Studio group
See error

Expected behavior
See the chat channel.
Additional context:

Ship type: planet
Instance type: self hosted
OS/browser: Tlon iOS mobile app

https://github.com/tloncorp/landscape-apps/pull/3259
https://github.com/tloncorp/landscape-apps/releases/tag/v5.7.0


[v0.5.0-dev] Nihlatak stairs template needs to be improved

When mercenary gets on top of the stairs the template cannot be recognized. The template needs more references
Wanted to select ['NI1_STAIRS', 'NI1_STAIRS_2', 'NI1_STAIRS_3', 'NI1_STAIRS_4'], but could not find it

Maybe a random tele jump could also resolve the issue.


backlight dont turn off on spectrum screen

as said on title , another fantastic issue

This is by design. You can turn it of with sidebutton i assigned to backlight.
I don't regard it an issue as I want to see where signals are and impact on battery is neglictable.

i assumed too your response , then the design is bad when i set a backlight default time it's a generic design too , dont need that or make mistakes as generic designs. That's the easiest way

Well, compile your own firmware than .... The design is not bad. The whole idea behind a bandscope or spectrum analyser is to look at it so you would expect the backlight to be on.  And you still have the option to turn it off.
Perhaps it is your understanding of English but a remark like 'another fantastic issue' does not sound nice to egzumer. It sounds like you blame him. But don't forget he is putting a lot of time and effort into this and all for free!

i'm here reporting issues , as you can see , not for try sell a mistake like a fantastic evolution and not for compiling nothing . If i compiles something i try make the best before i place like a big software version. And certainly is another  issue as you can see a lot here, nothing more.
On other face , all engineers know about what i'm speaking , you seems that not. Maybe i'm a bad day too today , like all people on any day ;) . Nice day and good work

Thank you egzumer, for your excellent work and frequently releasing new updates.
You are doing a great job for a lot of people here for sure!

on my country this is called "palmeros"
I don't placed wood on fire guys , for same rule dont need a timeout for backlight . When one is on stand by on a frequency , same on the spectrum , when the signal is hard enough the light turns on and heard something. Pls. don't try make the people little for make feel yours better , that dont works . Cya

This is how it was designed by fagci, I don't see a reason for changing that


Add a bundle size check in GitHub Actions

It would be nice to add a check to CI that shows how many bytes a PR adds to the JS bundle. Preferably as a text in GH checks rather than a comment bot. cc @jonkoops
leaflet.js: 142kB (+35), 40kB gzipped (+15)

https://github.com/siddharthkp/bundlesize#build-status-for-github would be a option for that. Or write a simple script for that.
If interessted I would add it to the workflow. No matter in wich way. Custom script is not that difficult would create it in a week or so.
As I'm a big fan of treeshaking I would propose to add a size check for a minimal Map-Example (just Map with 1 Marker) so we can keep an eye on that too. If that is a thing you are interessted in I can add this too.

@mathe42 can you please setup the suggested changes?


Stop UDC if there is an unrecoverable error in Artemis

GDA should stop the queue if there is an unrecoverable error in Artemis.

I believe there is code on the beamline for this, check and push to gerrit

Ensure that not finding a centre does not count as an error

I think this has been covered by other issues


Provide R package-related tasks

There are some things added in one of the recent releases that we should consider including as VS Code tasks as well.
In particular, being able to run tests and R CMD check is ideally-suited to tasks.
I wasn't sure whether an extension can provide tasks in this way, but it appears to be possible. I don't know TypeScript well enough to implement, but here's an example of an extension that provides users with tasks: https://github.com/Microsoft/vscode-extension-samples/tree/master/task-provider-sample
I can help in terms of putting together the task definition JSONs since I'm using some in my own projects already.

@jacob-long Sorry my late reply.
Good idea! if you have a task JSON files, could you share it?

Hi @jacob-long, I’m following up on some old issues. Are tasks still something you’re keen to see added?

I think these would be valuable additions to support R package developer workflows.

@jacob-long Great! It sounds like you might already have some task definition JSON files that you can share? If so, that would be very useful.
I structure most of my projects as packages and use a workflow based around devtools::load_all() and devtools::test(), but I’ve never submitted a package to CRAN, used R CMD, or used VSCode tasks. Would you be able to provide a list of desired tasks and what they should do? I’m happy to help out on the implementation side of things.
Thank you!

Sorry, to barge in. I'm only just getting started using VS Code, but in case it helps, my set up looks as follows:
{
    "version": "2.0.0",
    "tasks": [
        {
            "label": "Build package",
            "type": "shell",
            "command": "RScript -e 'devtools::install(upgrade = \"never\")'",
            "presentation": {
                "reveal": "always"
            },
            "problemMatcher": [],
            "group": {
                "kind": "build",
                "isDefault": true
            }
        },
        {
            "label": "Run unit tests",
            "type": "shell",
            "command": "RScript -e 'devtools::test()'",
            "presentation": {
                "reveal": "always"
            },
            "problemMatcher": [],
            "group": {
                "kind": "test",
                "isDefault": true
            }
        },
        {
            "label": "Run R CMD checks",
            "type": "shell",
            "command": "RScript -e 'devtools::check()'",
            "presentation": {
                "reveal": "always"
            },
            "problemMatcher": [],
            "group": {
                "kind": "test",
                "isDefault": false
            }
        }
    ]
}

based on @crsh's example, I've factored out/expanded this a bit to replicate as much as possible the RStudio build pane.
(Corresponding keymaps are in #551).
I understand there's a way to make an extension a proper Task provider.
I'm not knowledgeable about TypeScript (?), let alone VSCode extensions, otherwise I'd be happy to make PR, but I can help curate the tasks (rmarkdown, shiny, etc).
Here's what I got:
{
    "version": "2.0.0",
    "options": {
        "shell": {
            "executable": "Rscript",
            "args": [
                "-e"
            ]
        }
    },
    "presentation": {
        "reveal": "always",
        "panel": "shared",
        "showReuseMessage": false,
        "group": "build"
    },
    "type": "shell",
    "problemMatcher": [],
    "tasks": [
        {
            "label": "Document",
            "command": "devtools::document(roclets = c('rd', 'collate', 'namespace'))",
            "problemMatcher": []
        },
        {
            "label": "Install",
            "command": "devtools::install(quick = TRUE, upgrade = 'never')",
            "group": "build",
            "dependsOn": "Document"
        },
        {
            "label": "Test",
            "command": "devtools::test()",
            "group": "test",
            "problemMatcher": []
        },
        {
            "label": "Check",
            "command": "devtools::check(error_on = 'warning')",
            "group": {
                "kind": "test",
                "isDefault": true
            },
            "dependsOn": "Document"
        },
        {
            "label": "Pkgdown",
            "command": "muggle::build_site2()",
            "group": {
                "kind": "build",
                "isDefault": true
            },
            "dependsOn": "Document",
            "problemMatcher": []
        },
        {
            "label": "Build and Test",
            "dependsOn": [
                "Pkgdown",
                "Check"
            ]
        }
    ]
}

@crsh Thank you for posting that info, and apologies for not responding! I completely missed the notification.
@maxheld83 Thank you for the followup on this issue. This isn't something I'm going to pursue any time soon, but contributions are very welcome!

Good idea, and thanks for the task configs. To really emulate the functionality from R Studio, it would be nice if it was possible to restart the R Session (and run library(<package>), just like the Build & Reload function does in R Studio.
I've fiddled a bit with the tasks, but I'm not sure how to do this properly. It's of course easy to start up R as part of the task, but then the R extension does not recognize the new console as the "main" R terminal, and sends commands to either a new terminal or the old one (if it was already opened).
What I'd like to achieve is to have the task reuse the standard R terminal. Does anyone know how to achieve this?

I thought about that too @jolas.
Maybe just put devtools::load_all() in a project-specific .rprofile?

@jolars: I have mapped workbench.action.terminal.relaunch to Ctrl + Shift + F10 to restart the active terminal if the active language is R. Works for me.

I've added tasks for Check, Document, Install and Test.
It should be fairly easy to add new tasks by copy-pasting the code for these tasks, which is here:
https://github.com/Ikuyadeu/vscode-R/blob/17a7d69423d3a4377211e83f39ebc3bceba6ab69/src/extension.ts#L147-L154

Nice! I wonder if we can use "problemMatchers" to implement tasks that work on the active document, e.g. "knit".

@krlmlr I think problem matchers work on the output of tasks. For tasks that use the active file, we might be able to use variable substitution: https://code.visualstudio.com/docs/editor/variables-reference

This is quite a meaty issue now I'm wondering if its worth splitting it into sub issues namely:

Add knitr task (Further possible requirements listed in #608)
Add problemMatchers (already partially implemented in #989 but probably needs to be refined)
Enhance existing tasks (currently we have the most basic implementation devtools::document() it might be worth updating them in line with https://github.com/REditorSupport/vscode-R/issues/59#issuecomment-776116826)


HADOOP-18563. Misleading AWS SDK S3 timeout configuration comment

Description of PR
https://issues.apache.org/jira/browse/HADOOP-18563
How was this patch tested?
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 27s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 44s

trunk passed

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 18s

trunk passed

+1 :green_heart:
shadedclient
21m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 31s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m  5s

the patch passed

+1 :green_heart:
shadedclient
20m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 38s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

94m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5197/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5197

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 76bde704f871 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1e4aef2c8b12160707a3aadd15e8ee3789114f83

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5197/1/testReport/

Max. process+thread count
566 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5197/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Tests fail with bcachefs

Hi, I am trying to build your package from source (which seems to work perfectly fine) but I have noticed that some tests are failing? Is this intended? I am currently using the v0.2.0 tag... although the result of go test on the master branch is identical
--- FAIL: TestLongSizeAlignment (0.00s)
    main_test.go:429:
        have:
         1 │ alloc
         0 │ large
         0 │ small
        want:
         8 │ alloc
         0 │ large
         0 │ small
    main_test.go:440:
        have:
           1 │ alloc
         242 │ large
           0 │ small
        want:
          1 │ alloc
         31 │ large
          0 │ small
--- FAIL: TestInode (0.00s)
    main_test.go:708:
        have:
        946942502 │ 0 │ 2023-06-11 │ dir
        946942501 │ 0 │ 2023-06-11 │ file
        want:
        946942502 │ 1 │ 2023-06-11 │ dir
        946942501 │ 0 │ 2023-06-11 │ file
    main_test.go:720:
        have:
        946942502 drwxr-xr-x nixbld nixbld 0 Jun 11 15:05 │ dir
        946942501 -rw-r--r-- nixbld nixbld 0 Jun 11 15:05 │ file
        want:
        946942502 drwxr-xr-x nixbld nixbld 1 Jun 11 15:05 │ dir
        946942501 -rw-r--r-- nixbld nixbld 0 Jun 11 15:05 │ file
--- FAIL: TestLFlag (0.01s)
    main_test.go:993:
        have:
          6.5K │ 08:16 │ file-1
          6.5K │ 08:16 │ link-file-1
             0 │ 08:16 │ dir
             0 │ 08:16 │ file-2
             0 │ 08:16 │ link-dir
             0 │ 08:16 │ link-file-2

        want:
          6.5K │ 08:16 │ file-1
          6.5K │ 08:16 │ link-file-1
             0 │ 08:16 │ dir
             0 │ 08:16 │ link-dir
             0 │ 08:16 │ file-2
             0 │ 08:16 │ link-file-2
FAIL
FAIL    zgo.at/elles    0.136s
FAIL

What system and filesystem are you using? It's probably something different on your system that the tests don't account for.

My root is bcachefs and my home is ext4. I am on nixOS. I have tried building by writing a nixOS package (not too sure where that uses to build) and by normal cloning into my home dir and running go test

I assume you're running it on that bcachefs filesystem. I can reproduce with:
% dd if=/dev/zero of=img bs=1M count=100 conv=sparse
% mkfs.bcachefs ./img
% mkdir mnt
% doas mount ./img ./mnt
% doas chown martin mnt

% TMPDIR=$(readlink -f ./mnt) go test
--- FAIL: TestInode (0.00s)
    main_test.go:708:
        have:
<PHONE_NUMBER> │ 0 │ 2023-06-11 │ dir
<PHONE_NUMBER> │ 0 │ 2023-06-11 │ file
        want:
<PHONE_NUMBER> │ 1 │ 2023-06-11 │ dir
<PHONE_NUMBER> │ 0 │ 2023-06-11 │ file
    main_test.go:720:
        have:
<PHONE_NUMBER> drwxr-xr-x martin martin 0 Jun 11 15:05 │ dir
<PHONE_NUMBER> -rw-r--r-- martin martin 0 Jun 11 15:05 │ file
        want:
<PHONE_NUMBER> drwxr-xr-x martin martin 1 Jun 11 15:05 │ dir
<PHONE_NUMBER> -rw-r--r-- martin martin 0 Jun 11 15:05 │ file
--- FAIL: TestLFlag (0.01s)
    main_test.go:993:
        have:
          6.5K │ 10:24 │ file-1
          6.5K │ 10:24 │ link-file-1
             0 │ 10:24 │ dir
             0 │ 10:24 │ file-2
             0 │ 10:24 │ link-dir
             0 │ 10:24 │ link-file-2

        want:
          6.5K │ 10:24 │ file-1
          6.5K │ 10:24 │ link-file-1
             0 │ 10:24 │ dir
             0 │ 10:24 │ link-dir
             0 │ 10:24 │ file-2
             0 │ 10:24 │ link-file-2
FAIL
exit status 1
FAIL    zgo.at/elles    0.305s

Lots of little details are filesystem-specific; for example:
% mkdir empty mnt/empty

% /bin/ls -ld empty mnt/empty
drwxr-xr-x 2 martin martin 4096 Sep  1 10:28 empty
drwxr-xr-x 2 martin martin    0 Sep  1 10:28 mnt/empty

On ext4 an empty directory report as 4K (or rather, the block size). On bcachefs it's 0. In a quick test it seems bcachefs always reports directory sizes as zero.
I tested ext4, xfs, and btrfs when I first wrote it; bcachefs wasn't merged yet.
I'll get around to fixing it eventually. Maybe some small fixes to elles itself are needed, but I would expect it'll just be a matter of twiddling the tests to work on all filesystems.

You didn't reproduce TestLongSizeAlignment failing?

No, didn't see that one. May be due to how the filesystem is formatted(?) Not sure.


Check for zero in toPos

I encountered a crash in render.go:toPos when using go-prompt in combination with goexpect.
Just adding this zero check fixes it, although I did not investigate how it gets there.

Stacktrace

panic(0xbe8d40, 0x156f4d0)
	.go/src/runtime/panic.go:967 +0x15d
github.com/c-bata/go-prompt.(*Render).toPos(...)
	go/pkg/mod/github.com/c-bata/go-prompt@v0.2.3/render.go:268
github.com/c-bata/go-prompt.(*Render).move(0xc0005a61a0, 0x42, 0x0, 0x2)
	go/pkg/mod/github.com/c-bata/go-prompt@v0.2.3/render.go:257 +0xcc
github.com/c-bata/go-prompt.(*Render).clear(0xc0005a61a0, 0x42)
	go/pkg/mod/github.com/c-bata/go-prompt@v0.2.3/render.go:244 +0x3e
github.com/c-bata/go-prompt.(*Render).BreakLine(0xc0005a61a0, 0xc0004a6cc0)
	go/pkg/mod/github.com/c-bata/go-prompt@v0.2.3/render.go:231 +0x209
github.com/c-bata/go-prompt.(*Prompt).feed(0xc000598580, 0xc000777c00, 0x1, 0x400, 0x1, 0x0)
	go/pkg/mod/github.com/c-bata/go-prompt@v0.2.3/prompt.go:120 +0x274
github.com/c-bata/go-prompt.(*Prompt).Run(0xc000598580)
	go/pkg/mod/github.com/c-bata/go-prompt@v0.2.3/prompt.go:72 +0x579

If you want I can also write a Bug report, but I thought it is quicker like this.

He is my brother! :+1:

Closed for inactivity.


Move version definition from setup.py to version.txt

Required for FBcode

@seemethere this might be of interest to you for the release/CI scripts.

Thanks for the heads up, this looks fine to me as long as we retain the ability to set it as an environment variable


Document gap of XACML multi-decisionProfile in JSON and XML

Please refer the following blogs:
[1] https://medium.com/@gdrdabarera/json-support-with-xacml-3-0-in-your-new-wso2-identity-server-5-5-0-onwards-eb5295eceaa0
[2] https://medium.com/@gdrdabarera/fine-grain-authorization-using-xacml-with-wso2-identity-server-using-json-rest-calls-fda9b5c642df
[3] https://medium.com/@gdrdabarera/we-are-now-supporting-multi-decision-profile-in-json-8ddaba1fbed1

Added the following to 5.6.0 docs:
https://docs.wso2.com/display/IS560/Access+Control+and+Entitlement+Management#AccessControlandEntitlementManagement-JSONSupport
https://docs.wso2.com/display/IS560/Access+Control+and+Entitlement+Management#AccessControlandEntitlementManagement-MDP
https://docs.wso2.com/display/IS560/Working+with+XACML+Multiple+Decision+Profile+Requests
https://docs.wso2.com/display/IS560/Fine-grained+Authorization+using+XACML+Requests+in+JSON+Format


Split command document into shorter version and longer version

Is your feature request related to a problem? Please describe.
Current command document is not enough for who are not familiar with command lines. But it's not handy for quick reference.
Describe the solution you'd like
Separate documents into like

Longer version: doc/generated{{.LangPrefix}}/{{.CommandPath}}.md - existing documents
Shorter version: doc/brief{{.LangPrefix}}/{{.CommandPath}}.md - new

Describe alternatives you've considered
n/a
Additional context
n/a

Replaced by supplemental docs

Replaced by supplemental docs


Issue: LivePortrait looking for .pth file instead of .safetensors

Hi,
I'm encountering an issue with LivePortrait in ComfyUI. The system is attempting to load the appearance_feature_extractor.pth file, but I only have the appearance_feature_extractor.safetensors file. I have placed the .safetensors file in the correct directory (ComfyUI\models\liveportrait\base_models), but the script continues to look for the .pth file, resulting in the following error:
[Errno 2] No such file or directory: 'C:\Users\...\ComfyUI\models\liveportrait\base_models\appearance_feature_extractor.pth'
Is there a way to either modify the script to use the .safetensors file or should I be downloading a .pth version of the model? If so, where can I find that?
Any help or guidance would be appreciated!
Thank you!

Are you sure you are actually using these nodes? I do not recognize that path in your error. These nodes load .safetensors from just ComfyUI\models\liveportrait

Yes. I think the package i installed is from another author. Thanks a lot for your response.


Decouple time interface from libultra

We can replace libultra's OSTime with a typedef ... Time which can be library-dependent or library-independent, in which case each library implementation can define functions to convert to/from its internal time format.
Then we can add to the time interface a gettime function to get the now time and a difftime function to compute the difference of two times.
There is nothing more to add beyond what @mwpenny suggested about OSTimer in https://github.com/mwpenny/portal64-still-alive/pull/47#issuecomment-2076240521:

Note that the game's OSTimer usage is only for creating a delay - it is effectively just an asynchronous sleep() and can be wrapped as such

We can add to the time interface a sleep function which causes the calling thread to sleep until the seconds specified have elapsed.

In some cases, the game uses an OSTime relative to another OSTime (in sceneRenderPerformanceMetrics()), and so the underlying representation doesn't matter.
In other cases, the game converts to microseconds or nanoseconds (profiler).
For now, keeping it in its current format is fine. We may end up needing to add conversion functions down the road, but it's possible to keep it simple and just have callers add/subtract the underlying integer value and call a conversion function after the fact, rather than adding a diff function.

I wrapped OSTimer usage into timeUSleep in #66. I also removed gLastTime since it is not used which makes time.h libultra-independent.

For now, keeping it in its current format is fine. We may end up needing to add conversion functions down the road, but even then it's possible to keep it simple and just have callers add/subtract the underlying integer value and call a conversion function on the result, rather than adding a diff function. Similar to the C standard library.

I was thinking about time diff functions that also encapsulate the time conversion, for example:
// time.h

typedef uint64_t Time;

Time timeNow();
uint64_t timeDiffU(Time start, Time end); // time diff in micro seconds
uint64_t timeDiffN(Time start, Time end); // time diff in nano seconds

Also, replacing OSTime with a uint64_t as in the example might be sufficient, assuming that the internal time format of other libraries can be easily converted to a uint64_t.
No problem leaving OSTime for now and/or preferring conversion functions to diff functions.

Thanks. And nice catch on the dead code.

I was thinking about time diff functions that also encapsulate the time conversion

This makes sense and would work, although keeping time as an arithmetic type allows the following:
Time t1 = ...;
Time t2 = ...;

Time diff = t1 - t2;
uint64_t us = timeMicroseconds(diff);
uint64_t ns = timeNanoseconds(diff);

Each conversion function can support converting a single time or a difference between times.

Probably the real reason to prefer diff functions is that Time can be of any type, e.g. a struct. Of course in this case a function should also be defined to calculate the ratio between two times.
But as said, I think defining Time as uint64_t is sufficient.
Let me know if you want me to proceed to replace OSTime and add the conversion functions.


"For each" with colors does not work as expected, simulation only

The following program can be executed, but the behaviour of the robot is unexpected:

The robot starts driving backwards (starting on the white background) and the program execution terminates when the robot reaches the black line.
The values of the list elements seems to be correct, probably a problem of the "for each" block in the simulation execution.
Note: this program was working fine in the beginning of this year.

error messages from console:
interpreter.util.js:14 invalid expr op: ledColor
interpreter.util.js:15 Uncaught invalid expr op: ledColor
interpreter.util.js:14 pop failed with empty stack
interpreter.util.js:15 Uncaught pop failed with empty stack
interpreter.util.js:14 setVar failed for: f
interpreter.util.js:15 Uncaught setVar failed for: f
interpreter.util.js:14 getVar failed for: f
simulation.js:487 END of Sim

probably an error introduced when the code generation of loops has been stratified

works as expected


Use Scala 2.12.10

Metals is tracking 2.12.10 support here: https://github.com/scalameta/metals/pull/913

Okay, let's merge this once that metals issue is resolved.

A metals release with support for 2.12.10 is out now.


No API v2 support yet?

It looks like the library doesn't yet have any support for the V2 APIs introduced in Mastodon 4.0.0. Is there work underway to add it? I need some support for it and don't mind at all starting to add it in, but I don't want to duplicate work that's already underway.

Same here. Found that /api/v1/media  doc is deprecated and I had to  manually modify the lib.


Look into failed iperf3 UDP test

When I ran an iperf3 container test from within our ovs network setup, the test hangs.


addQueue() - how to retrieve generated "uniqueName" ?

hi there,
I'm trying figure out how to determine the generated queue name after a all to addQueue() so that I can add a binding, handler & subscription to that queue! I am not exactly sure what the Promise returned by addQueue() is supposed to resolve to but the object I get doesn't contain the name of the queue I just created anywhere in it's [deeply] nested structure ... I am doing something like so:
rabbit.addQueue('logview', {
        autoDelete : true,
        durable    : false,
        exclusive  : true,
        noAck      : true,
        noBatch    : true, // TODO: set FALSE here for better performance?
        messageTtl : 10000,
        unique     : 'id'
}).then( console.log );

inside the guts of rabbot the generated queue name is stored as part of the queue options (key is uniqueName) and you can extract this info like so:
var my_queue_alias = 'logview';
Object.keys(rabbot.connections.default.definitions.queues[ my_queue_alias ].uniqueName);

BUT getting at the generated name this way is very wrong (a couple of SOLID principles cry at the thought of me digging into rabbot.connections)) ... do you agree that consumers of the rabbot module  should "stay-the-f***-out" of rabbot's internals? if so could you tell me what the correct way is to retrieve the generated queue name.
thanks!

PS - I new to AMQ, RabbitMQ and rabbot ... be gentle please :-)

PPS - AFAICT wascally does not offer this "generate a unique queue name" functionality ... maybe this is something new to rabbot that nobody has used yet?

@iamjochem - your instincts are correct - you shouldn't have to know how to get at the internals. There's a chance that rabbot has a defect, but the idea here is that when rabbot adds things to the queue name for you, your code can still keep using the alias you provided for the queue name when providing bindings and starting the subscription. I thought we were using that behavior here at LeanKit, but I'll have to check.
If that's not the case, I'll need to add test coverage and fix the defect. Please try that first by just using "logview" as the queue name and see if rabbot doesn't handle the fact that the underlying name isn't different for you behind the scenes.

@arobson - sorry I forgot to mention it ... using the alias "logview" was the first thing I tried, that didn't work I'm afraid, I get debug() output like so:
rabbot.topology info +15ms Binding queue 'logview' to 'oo.logs' on 'default' with keys: ["#"]
rabbot.io error +5ms Error emitted by channel 'control' - 'Error: Channel closed by server: 404 (NOT-FOUND) with message "NOT_FOUND - no queue 'logview' in vhost '/'"

off topic: it might be nice to publically expose the generated/underlying name - this would allow exporting of the name for use in other processes or [node] modules.

@iamjochem ok, 1.0.3 will fix the bindQueue problem you are having above. I was able to call start subscription on the queue by the "friendly name" I provided. You can get to the unique name generated for the queue but you shouldn't have to and I'd rather make it so you shouldn't want to. Publishing directly to queues is discouraged so really you should just be:

adding queues
binding queues
starting subscriptions

In very, very rare cases, you might need to stop subscriptions and remove queues, but that's pretty advanced. In most cases you should declare all of your service's topology up front, at once as part of the configure call and leave it in place. I've rarely seen a good case for services that need to be constantly mutating the topology over their lifecycle.
Let me know if you'd like to discuss use cases. I might be able to help you design something that meets your needs and keeps things easy to manage.

@arobson - I concur, v1.0.3 fixes the bindQueue() and startSubscription() problem with regard to using "queue aliases" - thanks for taking the time to look into this and get a fix out!
this particular use case was a bit of an edge case (I will be using a predefined 'base' topology in my apps/processes) ... I have written a shellscript that creates an exclusive queue for the duration of the process that is bound to a "log" topic-exchange, the script just dumps the log items to STDOUT ... it's the distributed AMQ equivalent off tail -f /var/log/some-app.log ... when the script dies the queue is no longer needed (there is a "real" queue that persists messages sent to the "log" exchange, a seperate consumer is responsible for eating those messages and pumping them into elasticsearch)
maybe that is a completely stupid way of handling 'platform-wide' logging - I'm still learning to walk in AMQ-land ... probably be back here with more noob-problems soon enough ;-)


Fix cursors update when number of lines changes

Updates where starting at index=size-1 and wrapping instead of starting at index=0
Then inserting cursors here and doing backspace:
|mon
|tue
|wed

You would loose the last cursor because cursor update was done in the order index=2, 0, 1 (see s:CursorManager.update_current()):
|mon|tuewed

This PR fixes it by updating cursors in the order index=0, 1, 2:
|mon|tue|wed

I did not notice any regression. It might fix #234: I observed a different behavior, but the issue description is a bit messy, so it is hard to see if it fixes the issue.
Please note that putting the cursor at the end of the line and pressing del is still flaky.
Nothing to do with my PR as it was already the case before, but I will try to tackle that when I have time.
Cheers,
Antoine

The test failures here look somewhat legitimate.

@eapache definitely.
I will look at it and try to fix the errors.

@eapache , it is still failing with 2 errors even though it works OK on my machine when running:
bundle exec rake
Do you have any idea what might cause the different behavior ?
I am using a fairly recent version of vim (8.0, Included patches: 1-1451).

I ran a travis-ci build on my master branch and it passed:
https://travis-ci.org/antoinemadec/vim-multiple-cursors/jobs/339261936
The config is exactly like yours. I don't understand why the checks are failing on the PR, and not on antoinemadec/vim-multiple-cusors master...
Could it be because the PR was in 2 commits, or because the commits logs are very similar ?
Any input is appreciated.

Occasionally the vim automation tool is just a little flaky; a keystroke gets missed or something and the state ends up wrong. I re-ran CI and it passed the second time.
Thanks for your work on this!

@eapache thanks !
Also, i wanted to add a test checking this new feature but i litterally spent an hour trying to send a backspace to vim using ruby's vimrunner.
Do you know how to do that ?
Cheers,
Antoine

I haven't tried this myself, but I would expect <BS> or perhaps <C-H> to work. Do note though that by default backspace will not cross lines in vim (http://vim.wikia.com/wiki/Backspace_and_delete_problems#Backspace_key_won.27t_move_from_current_line) so it may just be a config issue with the hooked vim process.

@eapache spot on !
Thanks :)


utils changes

ups, messed it up :) sorry
it's ready now
1. completed and working calculateMidpoint()
2. added inMiles parameter to calculateDistance()
3. updated basic tests accordingly

Coverage increased (+0.08%) to 97.297% when pulling 85c27e12b749c53f2cd8284bc4493036c75941c1 on pavloDeshko:base into acd206cbdc4f46a2b7d177ff84c8d5eb3f4556de on elliotstokes:master.

Coverage increased (+0.1%) to 97.368% when pulling cac0759e12fbbae60d34f2384eb32964a173963b on pavloDeshko:base into acd206cbdc4f46a2b7d177ff84c8d5eb3f4556de on elliotstokes:master.

added function to utils for calculating bearing between two given points
fixed some typose in geomUtils.js

Sorry for the delay Ive completely missed this. Ill take a look at this tonight.


Grafana API datasource health check returns 400

When using the grafana API datasource health check against a datasource using the victoriametrics-datasource plugin, e.g. using /api/datasources/uid/abcdefghijklmn/health then it fails with a 400 status and a JSON body
{"message":"got response code 400","status":"ERROR"}

The datasource is configured with the URL http://vmselect-aggregator-clusterip.vm-output.svc.cluster.local:8481/select/1234/prometheus (note the multitenant setup) and otherwise works fine, only the above health check does not work.
If I understand the source code correctly, then the health check is done in this function https://github.com/VictoriaMetrics/victorialogs-datasource/blob/518eca5756fbab962a54f42420e0326dd7f3a6c0/pkg/plugin/datasource.go#L146 The /health part is just added to the configured URL, so the result would be http://vmselect-aggregator-clusterip.vm-output.svc.cluster.local:8481/select/1234/prometheus/health which does not work (i.e. fails with a 400, which is then propagated).

Sorry, wrong project...


Windows 10: OpenSSH Server not starting

OpenSSH doesn't start when I try to connect from a Windows 10 Machine via the GUI, but it is working if I start it from CMD without the -f parameter (and without sleep 15). Does somebody know what to do, to make it working? From Linux its just working fine.

On Windows systems we're using a bundled version of OpenSSH. Maybe this bundle isn't extracted properly or does not work properly under Windows 10. You can try to install OpenSSH for Windows separately and set the path to ssh.exe in the extended settings. It would be interesting / helpful to know, if the problem also occurs in this case.
Btw: Does the GUI application create a log file, when you try to establish a connection? - If yes, does it contain some informations / error messages?

This issue should be resolved with the reworked version 1.0.0 because an integrated OpenSSH for Windows is not required anymore.


Proto REPL just opens Java Window - Didn't used too

Hi, I recently updated the proto-repl extension inside Atom and before hand everything seemed to work. The repl started inside atom and I could select clojure code to run without any problems. However after the update whenever I try and run the REPL i just get a java window loading up saying i've started the REPL server but I can't do anything in ATOM. Using shift + enter doesn't work and I cant use the hotkeys to select clojure code without getting the error: "This command requires you to position the cursor on a Clojure var."
Image below is the java window that appears, I can't seem to do anything in that either. Didn't have these issues before with my program so I don't think its related to that. Any idea? Thanks!

The same problem :(

Same issue

@broliverparker @tonic4401 @thomasiffland It appears my attempts to kill the REPL JVM in https://github.com/jasongilman/proto-repl/pull/292 didn't work for Windows (I didn't have a Windows install at the time to test). I've since got access to a Windows env and submitted a fix for the issue you are seeing: https://github.com/jasongilman/proto-repl/pull/303
If you are able to, it would be great if you could try that fix out to make sure your problem is resolved.

This fixed the issue for me, thank you!


Provide a separate configuration that can set the encoding of the console

I sumbitted a issue：https://github.com/microsoft/vscode/issues/195446, set the windows console in settings.json：
"terminal.integrated.profiles.windows": {
    "Command Prompt": {
      "path": [
        "${env:windir}\\Sysnative\\cmd.exe",
        "${env:windir}\\System32\\cmd.exe"
      ],
      // CodeLLDB need it convert console codepage to show chinese corectly
      "args": ["/K chcp 65001>nul"],
      "icon": "terminal-cmd"
    },
  },
  "terminal.integrated.defaultProfile.windows": "Command Prompt",

when set the console args："args": ["/K chcp 65001>nul"] or "args": ["/K chcp 65001"] or "args": ["/K", "chcp 65001"]，execute the shell type task：
{
    "tasks": [
        {
            "label": "echo",
            "type": "shell",
            "command": "echo hello",
        }
    ],
    "version": "2.0.0"
}

An error message will appear: 'Incorrect parameter format -/d', due to a conflict between the Windows command parameters'/K 'and'/D ','/C '.
The '/K chcp 65001' parameter is set to solve the problem that the UTF8 Chinese characters output from the VSCode console are garbled in some cases. For example, some plugins used to debug C/C++ programs, but now Microsoft's official C/C++ plugins can normally output UTF8 Chinese characters in C/C++, but there are still many plugins that may not output normally. Therefore, setting the console code uniformly here is a relatively easy way, https://github.com/Microsoft/vscode/issues/19837#issuecomment-290843303 -This method is also mentioned.
However, after setting this parameter, if you want to run a Shell type task, the error mentioned above will be reported. This is because VSCode adds the '/d /c' parameter directly after executing the command:

I have studied the explanation of cmd and tried using the following command in this situation:
cmd /S /D /K "chcp 65001>nul&&echo Hello"
It can output normally.

So I have a suggestion that VSCode can intelligently perform some checks when executing Shell type tasks. If it finds that there are already '/K' parameters, it can make adjustments to the command.
It would be best to provide a separate configuration that can set the encoding of the console.
Thank you!

感谢您创建此问题！
然而，由于您没有使用英语，我们很难进行处理。如果可能，请您将此问题描述修改为英文。请您直接编辑此问题，不要提交回复或新问题。
请注意，机器翻译服务通常无法处理用于讨论软件问题所需的技术性语言，所以我们推荐您寻找一位熟悉相关技术的人来协助翻译。
如果您无法做到，没有关系。此问题已经被标记为需要翻译，等待社区成员志愿进行翻译。

Thanks for creating this issue!
Unfortunately, as the description is not in English, it's hard for us to work on. If possible, please edit the original issue to be in English.
In our experience, automatic translation services are not able to handle the technical language needed to effectively communicate about software issues, so we recommend finding a human translator who is familiar with our technology to help.
Otherwise, we have marked this as needing translation and a community member may be able to help out.

/duplicate #169821

@meganrogge The focus of these two issues is different, and this would prefer a separate configuration to set the encoding for the Windows console.


Can i use this with RPI Zero W

Hi,
Can i use this demo app using RPI Zero W? So can we use the built-in wifi in RPI Zero W instead of the IoT pHAT module?
Thanks and looking forward to hearing back from you.

Should work just the same on a Pi zero W


Synthesis failed for java-vision

Hello! Autosynth couldn't regenerate java-vision. :broken_heart:
Here's the output from running synth.py:
.java.
2021-01-11 02:33:03,339 synthtool [INFO] > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /tmpfs/tmp/tmpe5l3f6mf/google-cloud-vision-v1p4beta1-java/proto-google-cloud-vision-v1p4beta1-java/src/main/java/com/google/cloud/vision/v1p4beta1/CreateProductSetRequestOrBuilder.java.
2021-01-11 02:33:03,340 synthtool [INFO] > Replaced '// Generated by the protocol buffer compiler.  DO NOT EDIT!' in /tmpfs/tmp/tmpe5l3f6mf/google-cloud-vision-v1p4beta1-java/proto-google-cloud-vision-v1p4beta1-java/src/main/java/com/google/cloud/vision/v1p4beta1/ImageContext.java.
2021-01-11 02:33:03,343 synthtool [WARNING] > No replacements made in [PosixPath('/tmpfs/tmp/tmpe5l3f6mf/google-cloud-vision-v1p4beta1-java/proto-google-cloud-vision-v1p4beta1-java/src/**/*Name.java'), PosixPath('/tmpfs/tmp/tmpe5l3f6mf/google-cloud-vision-v1p4beta1-java/proto-google-cloud-vision-v1p4beta1-java/src/**/*Names.java')] for pattern /\*
 \* Copyright \d{4} Google LLC
 \*
 \* Licensed under the Apache License, Version 2.0 \(the "License"\); you may not use this file except
 \* in compliance with the License. You may obtain a copy of the License at
 \*
 \* http://www.apache.org/licenses/LICENSE-2.0
 \*
 \* Unless required by applicable law or agreed to in writing, software distributed under the License
 \* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
 \* or implied. See the License for the specific language governing permissions and limitations under
 \* the License.
 \*/
, maybe replacement is no longer needed?
2021-01-11 02:33:03,345 synthtool [INFO] > Replaced '^package (.*);' in /tmpfs/tmp/tmpe5l3f6mf/google-cloud-vision-v1p4beta1-java/grpc-google-cloud-vision-v1p4beta1-java/src/main/java/com/google/cloud/vision/v1p4beta1/ImageAnnotatorGrpc.java.
2021-01-11 02:33:03,346 synthtool [INFO] > Replaced '^package (.*);' in /tmpfs/tmp/tmpe5l3f6mf/google-cloud-vision-v1p4beta1-java/grpc-google-cloud-vision-v1p4beta1-java/src/main/java/com/google/cloud/vision/v1p4beta1/ProductSearchGrpc.java.
2021-01-11 02:33:03,689 synthtool [INFO] > Running java formatter on 78 files
2021-01-11 02:33:11,072 synthtool [INFO] > Running java formatter on 2 files
2021-01-11 02:33:14,074 synthtool [INFO] > Running java formatter on 184 files
2021-01-11 02:33:29,255 synthtool [DEBUG] > Using precloned repo /home/kbuilder/.cache/synthtool/synthtool
.github/CODEOWNERS
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/blunderbuss.yml
.github/generated-files-bot.yml
.github/readme/synth.py
.github/release-please.yml
.github/snippet-bot.yml
.github/trusted-contribution.yml
.github/workflows/approve-readme.yaml
.github/workflows/auto-release.yaml
.github/workflows/ci.yaml
.github/workflows/samples.yaml
.kokoro/build.bat
.kokoro/build.sh
.kokoro/coerce_logs.sh
.kokoro/common.cfg
.kokoro/common.sh
.kokoro/continuous/common.cfg
.kokoro/continuous/java8.cfg
.kokoro/continuous/readme.cfg
.kokoro/dependencies.sh
.kokoro/linkage-monitor.sh
.kokoro/nightly/common.cfg
.kokoro/nightly/integration.cfg
.kokoro/nightly/java11.cfg
.kokoro/nightly/java7.cfg
.kokoro/nightly/java8-osx.cfg
.kokoro/nightly/java8-win.cfg
.kokoro/nightly/java8.cfg
.kokoro/nightly/samples.cfg
.kokoro/populate-secrets.sh
.kokoro/presubmit/clirr.cfg
.kokoro/presubmit/common.cfg
.kokoro/presubmit/dependencies.cfg
.kokoro/presubmit/integration.cfg
.kokoro/presubmit/java11.cfg
.kokoro/presubmit/java7.cfg
.kokoro/presubmit/java8-osx.cfg
.kokoro/presubmit/java8-win.cfg
.kokoro/presubmit/java8.cfg
.kokoro/presubmit/linkage-monitor.cfg
.kokoro/presubmit/lint.cfg
.kokoro/presubmit/samples.cfg
.kokoro/readme.sh
.kokoro/release/bump_snapshot.cfg
.kokoro/release/common.cfg
.kokoro/release/common.sh
.kokoro/release/drop.cfg
.kokoro/release/drop.sh
.kokoro/release/promote.cfg
.kokoro/release/promote.sh
.kokoro/release/publish_javadoc.cfg
.kokoro/release/publish_javadoc.sh
.kokoro/release/snapshot.cfg
.kokoro/release/snapshot.sh
.kokoro/release/stage.cfg
.kokoro/release/stage.sh
.kokoro/trampoline.sh
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
java.header
license-checks.xml
renovate.json
samples/install-without-bom/pom.xml
samples/pom.xml
samples/snapshot/pom.xml
samples/snippets/pom.xml
2021-01-11 02:33:29,484 synthtool [DEBUG] > existing pom file found (samples/pom.xml) - keeping the existing
2021-01-11 02:33:29,485 synthtool [DEBUG] > existing pom file found (samples/install-without-bom/pom.xml) - keeping the existing
2021-01-11 02:33:29,486 synthtool [DEBUG] > existing pom file found (samples/snapshot/pom.xml) - keeping the existing
2021-01-11 02:33:29,487 synthtool [DEBUG] > existing pom file found (samples/snippets/pom.xml) - keeping the existing
2021-01-11 02:33:29,489 synthtool [INFO] > Replaced 'private final OperationsClient operationsClient;' in google-cloud-vision/src/main/java/com/google/cloud/vision/v1/ProductSearchClient.java.
2021-01-11 02:33:29,491 synthtool [INFO] > Replaced 'import com.google.api.gax.rpc.UnaryCallable;' in google-cloud-vision/src/main/java/com/google/cloud/vision/v1/ProductSearchClient.java.
2021-01-11 02:33:29,492 synthtool [INFO] > Running java formatter on 13 files
2021-01-11 02:33:35,320 synthtool [DEBUG] > Wrote metadata to synth.metadata.
2021-01-11 02:33:35,506 autosynth [INFO] > Changed files:
2021-01-11 02:33:35,507 autosynth [INFO] > M synth.metadata
2021-01-11 02:33:35,507 autosynth [DEBUG] > Running: git log fb53b6fb373b7c3edf4e55f3e8036bc6d73fa483 -1 --no-decorate --pretty=%s
2021-01-11 02:33:35,513 autosynth [DEBUG] > Running: git log fb53b6fb373b7c3edf4e55f3e8036bc6d73fa483 -1 --no-decorate --pretty=%b%n%nSource-Author: %an <%ae>%nSource-Date: %ad
2021-01-11 02:33:35,518 autosynth [DEBUG] > Running: git add -A
2021-01-11 02:33:35,533 autosynth [DEBUG] > Running: git status --porcelain
2021-01-11 02:33:35,549 autosynth [DEBUG] > Running: git commit -m chore(python): skip docfx in main presubmit

* chore(python): skip docfx in main presubmit

* fix: properly template the repo name

Source-Author: Bu Sun Kim<EMAIL_ADDRESS>Source-Date: Fri Jan 8 10:32:13 2021 -0700
Source-Repo: googleapis/synthtool
Source-Sha: fb53b6fb373b7c3edf4e55f3e8036bc6d73fa483
Source-Link: https://github.com/googleapis/synthtool/commit/fb53b6fb373b7c3edf4e55f3e8036bc6d73fa483
[autosynth-69 5ed9bfb] chore(python): skip docfx in main presubmit
 1 file changed, 12 insertions(+), 12 deletions(-)
2021-01-11 02:33:35,566 autosynth [DEBUG] > Running: git reset --hard HEAD
HEAD is now at 5ed9bfb chore(python): skip docfx in main presubmit
2021-01-11 02:33:35,579 autosynth [DEBUG] > Running: git checkout autosynth
Switched to branch 'autosynth'
2021-01-11 02:33:35,593 autosynth [DEBUG] > Running: git diff HEAD..autosynth-69 -- . :(exclude)synth.metadata
2021-01-11 02:33:35,599 autosynth [DEBUG] > Running: git diff HEAD..autosynth-69 -- synth.metadata
2021-01-11 02:33:35,605 autosynth [DEBUG] > Running: git diff HEAD..autosynth-70 -- . :(exclude)synth.metadata
2021-01-11 02:33:35,624 autosynth [DEBUG] > Running: git diff HEAD autosynth-70
2021-01-11 02:33:35,645 autosynth [DEBUG] > Running: git apply /tmpfs/tmp/tmpbkqaqdei/autosynth-70.patch
2021-01-11 02:33:35,657 autosynth [DEBUG] > Running: git add -A
2021-01-11 02:33:35,674 autosynth [DEBUG] > Running: git status --porcelain
2021-01-11 02:33:35,694 autosynth [DEBUG] > Running: git commit -m chore: update gapic-generator-java to 0.0.18

Committer: @miraleung
PiperOrigin-RevId: 350949863

Source-Author: Google APIs<EMAIL_ADDRESS>Source-Date: Sat Jan 9 14:01:49 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 91e206bcfeaf8948ea03fe3cb1b7616108496cd3
Source-Link: https://github.com/googleapis/googleapis/commit/91e206bcfeaf8948ea03fe3cb1b7616108496cd3
[autosynth 36424ef] chore: update gapic-generator-java to 0.0.18
 39 files changed, 78 insertions(+), 40 deletions(-)
2021-01-11 02:33:35,732 autosynth [DEBUG] > Running: git log -1 --no-decorate --format=%B
2021-01-11 02:33:35,738 autosynth [DEBUG] > Running: git push --force origin autosynth
To https://github.com/googleapis/java-vision.git
 + ae54faa...36424ef autosynth -> autosynth (forced update)
2021-01-11 02:33:39,490 autosynth [DEBUG] > Running: git log -1 --pretty=%b
2021-01-11 02:33:42,121 autosynth [DEBUG] > Running: git clean -fdx
Removing __pycache__/
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 354, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 189, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 334, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 92, in synthesize_loop
    synthesize_inner_loop(fork, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 137, in synthesize_inner_loop
    synthesizer, len(toolbox.versions) - 1
  File "/tmpfs/src/github/synthtool/autosynth/synth_toolbox.py", line 259, in synthesize_version_in_new_branch
    synthesizer.synthesize(synth_log_path, self.environ)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 120, in synthesize
    synth_proc.check_returncode()  # Raise an exception.
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 389, in check_returncode
    self.stderr)
subprocess.CalledProcessError: Command '['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:

Autosynth passed, closing! :green_heart:


[HOLD for payment 2024-02-26] Cancel payment - Red dot persists in LHN after dismissing payment cancellation error

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.42-1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Precondition:

Admin and member are in the same free workspace.
Admin and member have bank account set up.

[Member] Go to workspace chat.
[Member] Create a manual request.
[Admin] Pay the request with Expensify.
[Admin] Go to expense report > 3-dot menu > Cancel payment.
[Admin] Cancel the payment.
[Admin] Dismiss cancellation error message.

Expected Result:
The red dot in LHN will disappear after dismissing the error.
Actual Result:
The red dot still persists in LHN after dismissing the error.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/7ccecb50-f96f-4728-a185-0d86176faed8
View all open jobs on GitHub

We think that this bug might be related #wave5-free-submitters
CC @dylanexpensify

@Gonals Do you think this relates to https://github.com/Expensify/App/pull/34719?

Alberto confirmed it was caused from that PR. He will be able to fix this tomorrow morning.

@kbecciv, do you know why you are getting the error in the first place?

Should have been unblocked by https://github.com/Expensify/App/pull/36631

Adding bugzero team member to help with payment 🙏

I'll be working on the payment process later today

Here is the payment summary:

External issue reporter - N/A
Contributor that fixed the issue - N/A
Contributor+ that helped on the issue and/or PR - @hoangzinh $500

Upwork Job: https://www.upwork.com/jobs/~01fff48c8d19d46bc2
Extra Notes regarding payment:
@hoangzinh - this is ready for you to accept. Thanks!

Done, the payment has been completed in Upwork!


Lovelace, picture-glance and actions

Home Assistant release with the issue:
0.86.4 (and most probably also 0.85.x)
Last working Home Assistant release (if known):
0.84.x
Operating environment (Hass.io/Docker/Windows/etc.):
Hass.io
Component/platform:
Frontend, Lovelace
Description of problem:
Tap_action and hold_action doesn't work in picture-glance cards.
In 0.84 release there was the change how this was configured and it worked as described. But now it seems that the configuration doesn't work according to documentation in 0.86 (and I think I had the same issue in 0.85).
When I configure tap and hold actions in a normal glance card everything works as documented, but putting the identical yaml code in a picture-glance creates a different behaviour.
The below code, used both in type: glance and type: picture-glance gives the following behaviour:
type: glance
Toggle on hold and gives more info on tap
type: picture-glance
Toggle on tap and does nothing on hold
I've got the same behaviour for all picture-entity cards, it seems that the action configuration isn't read since it doesn't matter what you put there.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
type: glance
title: BMW i3
show_state: false
entities:
  - entity: input_boolean.on_off_bmw
    hold_action:
      action: toggle
    icon: 'mdi:fan'
    name: Klimatkontrollera
    tap_action:
      action: more-info

type: picture-glance
show_state: false
title: BMW i3
image: /local/BMWi3.jpg
entities:
  - entity: input_boolean.on_off_bmw
    hold_action:
      action: toggle
    icon: 'mdi:fan'
    name: Klimatkontrollera
    tap_action:
      action: more-info

Traceback (if applicable):

Additional information:

/move to home-assistant-polymer


How to sync schema

The Kysely officially recommended workflow is to auto-generate schema from DB (after running migrations).
What is recommended solution if I am using pglite during the development?

I just implemented a CLI for generating types based on Kysely migrations or an existing PGlite database that's been persisted on disk. Usage would be:
npx kysely-pglite ./src/db/migrations --outFile ./src/db/schema.ts

Currently, it's mostly a wrapper around kysely-codegen, using its internal codegen directly. The CLI accepts the same options/flags as kysely-codegen.
It also has a --watch option, it will watch the migrations and regenerate the types when a migration file changes/deleted/added.


Error Not enought data

Game name: blue protocol
Unreal Engine ：4.27.2
Error Not enought data

Game file
Text.zip
Thank you for your efforts!

@isme99
all files is empty
try another tool to export them again


Getting an error on install

Since last version we are receiving an error on installation:
LoadError: cannot load such file -- bundler/gem_tasks

got it. thanks for mention. Will try to figure out, where is a problem..

Fixed

src

@dlanileonardo seems it related with latest changes in Rakefile.. any ideas how to fix it?

Is this commit a related
https://github.com/YorickPeterse/oga/commit/076d82507a491ecc0e29dd6ebce2fd0d28d2748d

Seems problem in one broken test during installation. (Can't figure out, why it failed during installation and doesn't in local tests:
Failures:

  1) GitHubChangelogGenerator::Fetcher#github_fetch_tags when wrong token provided should raise Unauthorized error
     Failure/Error: options[:token] = INVALID_TOKEN

     RuntimeError:
       can't modify frozen Hash
     # ./spec/unit/fetcher_spec.rb:9:in `options_with_invalid_token'
     # ./spec/unit/fetcher_spec.rb:51:in `block (4 levels) in <top (required)>'

I got same failure in local test. This test case can be corrected quickly. But I think seperating installation and test is a proper way.

@AnNOtis I'm thinking in same way.
But I not familiar how rake and gem works together and which tasks called during gem install github_changelog_generator.
I tried to google it, but can't figure out how to separate testing and installation tasks? Can you help to do it right?
cc @olleolleolle

I believe a clue was in a PR recently merged - Rakefile is an "extension" in the gemspec.
When installing, the Rakefile will be loaded. To load it, we need rake and bundler to be present as runtime dependencies.

Rubygems specification reference notes that the "extensions" are executed upon install.

Commandgem install github_changelog_generator -v 1.10.5 works. But without version cpecifier still got this error

Seems it works. Problem was in buggy 1.11.0 release. I yanked it from gem repo. Now it works. Latest release is 1.10.4

@skywinder doesn't work for me without the version
$ gem install github_changelog_generator
ERROR:  While executing gem ... (Gem::RemoteFetcher::FetchError)
    bad response Not Found 404 (https://rubygems.global.ssl.fastly.net/quick/Marshal.4.8/github_changelog_generator-1.11.0.gemspec.rz)

$ ruby -v
ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin14]

$ bundler --version
Bundler version 1.11.2

1.10.1 works for me, but 1.10.4 does not.

Agreed, 1.10.4 is raising errors on install.

It looks like v1.10.4 has hidden dependencies on rubocop, codeclimate-test-reporter, and coveralls.

@more-ron @nicosuria ok, thanks for report. Will take a look on it..

now rubygems tries to install 1.10.4 for me (but it fails as others have reported)
$ ruby -v
ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-darwin13]

$ gem -v
<IP_ADDRESS>

$ gem install github_changelog_generator
Fetching: colorize-0.7.7.gem (100%)
Successfully installed colorize-0.7.7
Fetching: descendants_tracker-0.0.4.gem (100%)
Successfully installed descendants_tracker-0.0.4
Fetching: hashie-3.4.3.gem (100%)
Successfully installed hashie-3.4.3
Fetching: jwt-1.5.1.gem (100%)
Successfully installed jwt-1.5.1
Fetching: multi_xml-0.5.5.gem (100%)
Successfully installed multi_xml-0.5.5
Fetching: oauth2-1.1.0.gem (100%)
Successfully installed oauth2-1.1.0
Fetching: github_api-0.13.1.gem (100%)
Successfully installed github_api-0.13.1
Fetching: childprocess-0.5.9.gem (100%)
Successfully installed childprocess-0.5.9
Fetching: iniparse-1.4.2.gem (100%)
Successfully installed iniparse-1.4.2
Fetching: overcommit-0.32.0.gem (100%)
Install hooks by running `overcommit --install` in your Git repository
Successfully installed overcommit-0.32.0
Fetching: github_changelog_generator-1.10.4.gem (100%)
Building native extensions.  This could take a while...
ERROR:  Error installing github_changelog_generator:
	ERROR: Failed to build gem native extension.

    /Users/dentarg/.rubies/ruby-2.2.3/bin/ruby -rubygems /Users/dentarg/.rubies/ruby-2.2.3/lib/ruby/gems/2.2.0/gems/rake-10.4.2/bin/rake RUBYARCHDIR=/Users/dentarg/.gem/ruby/2.2.3/extensions/x86_64-darwin-13/2.2.0-static/github_changelog_generator-1.10.4 RUBYLIBDIR=/Users/dentarg/.gem/ruby/2.2.3/extensions/x86_64-darwin-13/2.2.0-static/github_changelog_generator-1.10.4
fatal: Not a git repository (or any of the parent directories): .git
rake aborted!
LoadError: cannot load such file -- rubocop/rake_task
/Users/dentarg/.gem/ruby/2.2.3/gems/github_changelog_generator-1.10.4/Rakefile:3:in `<top (required)>'
(See full trace by running task with --trace)

rake failed, exit code 1

Gem files will remain installed in /Users/dentarg/.gem/ruby/2.2.3/gems/github_changelog_generator-1.10.4 for inspection.
Results logged to /Users/dentarg/.gem/ruby/2.2.3/extensions/x86_64-darwin-13/2.2.0-static/github_changelog_generator-1.10.4/gem_make.out

Please, kindly check 1.11.1

Still getting issues with 1.11.2, see this travis build

Current build error (except from that travis build)
Installing github_changelog_generator 1.11.2 with native extensions
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.
    /home/travis/.rvm/rubies/ruby-1.9.3-p551/bin/ruby -rubygems /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/rake-10.5.0/bin/rake RUBYARCHDIR=/home/travis/.rvm/gems/ruby-1.9.3-p551/extensions/x86_64-linux/1.9.1/github_changelog_generator-1.11.2 RUBYLIBDIR=/home/travis/.rvm/gems/ruby-1.9.3-p551/extensions/x86_64-linux/1.9.1/github_changelog_generator-1.11.2
fatal: Not a git repository (or any of the parent directories): .git
rake aborted!
Errno::ENOENT: No such file or directory - /usr/local/share/man/man1/git-generate-changelog.1
/home/travis/.rvm/gems/ruby-1.9.3-p551/gems/github_changelog_generator-1.11.2/Rakefile:18:in `block (2 levels) in <top (required)>'
/home/travis/.rvm/gems/ruby-1.9.3-p551/gems/github_changelog_generator-1.11.2/Rakefile:17:in `glob'
/home/travis/.rvm/gems/ruby-1.9.3-p551/gems/github_changelog_generator-1.11.2/Rakefile:17:in `glob'
/home/travis/.rvm/gems/ruby-1.9.3-p551/gems/github_changelog_generator-1.11.2/Rakefile:17:in `block in <top (required)>'
Tasks: TOP => default => create_man
(See full trace by running task with --trace)
rake failed, exit code 1
Gem files will remain installed in /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/github_changelog_generator-1.11.2 for inspection.
Results logged to /home/travis/.rvm/gems/ruby-1.9.3-p551/extensions/x86_64-linux/1.9.1/github_changelog_generator-1.11.2/gem_make.out
An error occurred while installing github_changelog_generator (1.11.2), and
Bundler cannot continue.
Make sure that `gem install github_changelog_generator -v '1.11.2'` succeeds
before bundling.

:tired_face:

@fabn please try newest version..

@skywinder Still seeing this in 1.7.11
$ ruby --version
ruby 2.2.2p95 (2015-04-13 revision 50295) [x86_64-darwin14]
$

Installing github_changelog_generator 1.11.7 with native extensions

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

    /usr/local/var/rbenv/versions/2.2.2/bin/ruby -rubygems /Users/user/github/.bundle/ruby/2.2.0/gems/rake-10.5.0/bin/rake RUBYARCHDIR=/Users/user/github/.bundle/ruby/2.2.0/extensions/x86_64-darwin-14/2.2.0-static/github_changelog_generator-1.11.7 RUBYLIBDIR=/Users/user/github/.bundle/ruby/2.2.0/extensions/x86_64-darwin-14/2.2.0-static/github_changelog_generator-1.11.7
rake aborted!
LoadError: cannot load such file -- bundler
/Users/user/github/.bundle/ruby/2.2.0/gems/github_changelog_generator-1.11.7/Rakefile:1:in `<top (required)>'
(See full trace by running task with --trace)

rake failed, exit code 1

Gem files will remain installed in /Users/user/github/.bundle/ruby/2.2.0/gems/github_changelog_generator-1.11.7 for inspection.
Results logged to /Users/user/github/.bundle/ruby/2.2.0/extensions/x86_64-darwin-14/2.2.0-static/github_changelog_generator-1.11.7/gem_make.out


[DRAFT] [MB-16924] Update lines_of_accounting.loa_trnsn_id values

MB-16924
Summary
Adds a python script that can be used on the spreadsheet in keeper to generate the secure migration script locally.
Since the file is large, expect it to takes a minute or two to read the file
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
Test generation of secure migration (requires keeper access):

Download the file from keeper (see Jira ticket)
Setup python locally, however you prefer to do so e.g.:

setup venv inside project directory
source ./venv/bin/activate
pip install pandas
pip install openpyxl
python3 ./cmd/load-spreadsheet-data/load-updated-loa-trnsn-ids.py "./tmp/Line Of Accounting(U).xlsx"

Test application of dummy migration:

make db_dev_fresh should take care of it.
Confirm that your lines_of_accounting table has loa_trnsn_id values after migrations successfully run. You should see the following data:

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Messages

:book:
:link: MB-16924

  Generated by :no_entry_sign: dangerJS against 24ae2fa3ecab06aa8f8c8cce8ef4ed224aee9c95

Test coverage on server failed.
Last run: Thu 24 Aug 2023 08:43:28 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.

This is feeling good. Going to generate the actual migration fresh again in the morning, then schedule pairing time on secure migration things as needed, likely for early next week.


Rate unit page accessed from url

Details

Added fetching rate data in rate unit page so that when this page is accessed directly from the url it works as expected.
Fixed Issues

$ https://github.com/Expensify/App/issues/26131
PROPOSAL: https://github.com/Expensify/App/issues/26131#issuecomment-1696920876
Tests

Open workpsaces list
Go to any workspace
Change the url by adding /rateandunit at the end of the current url. It should look like something like this http://localhost:8082/workspace/ADAC3D387CFB6966/rateandunit
Make sure correct rate and unit data is shown not 0.000

[x] Verify that no errors appear in the JS console

Offline tests

Same as tests
QA Steps

Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/59907218/dec44360-d5e9-4423-893e-6b89eff8e650

Mobile Web - Chrome
https://github.com/Expensify/App/assets/59907218/00e77739-ae7e-4e83-ba6a-2f090d15c356

Mobile Web - Safari
https://github.com/Expensify/App/assets/59907218/1df15b38-784e-47e1-8780-1219e0d8f8eb

Desktop
N/a

iOS
N/a

Android
N/a

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/28352309/b7eb9af8-0c4e-4071-8d06-62a4c2cfa63f

Mobile Web - Chrome
https://github.com/Expensify/App/assets/28352309/dfef26a1-8fcf-44d7-a0a9-60ba66aff301

Mobile Web - Safari
https://github.com/Expensify/App/assets/28352309/69ff39e2-fdf3-4e60-908d-b2d497821819

Desktop
https://github.com/Expensify/App/assets/28352309/ed0c8611-d080-456a-bc17-6b0b554e79b4

iOS
https://github.com/Expensify/App/assets/28352309/a72f524e-c16d-4ba6-9a0f-61623738339d

Android
https://github.com/Expensify/App/assets/28352309/93e1a3f1-e970-49ee-8cf2-d1d5ddf27e87

@alitoshmatov can you fix merge conflicts please

Conflicts fixed!

Tests are broken in main branch https://expensify.slack.com/archives/C01GTK53T8Q/p1695796810686659

All set! Tests are successful

@cristipaval Friendly bump

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.76-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.77-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅