Is there an example with named pipes for communication between LS client and server

The libraries have full support for this. See https://insiders.vscode.dev/github/microsoft/vscode-languageserver-node/blob/main/client/src/node/main.ts#L31. All you need to do is to specify pipe. Then the client with pass --pipe ${pipename} as an argument to the server process.
In our code base there is no concrete example since our servers are Node and use IPC (which at the end uses named pipes :-)). But servers not written in TS are usually using named pipes.
Anything else you need?

@dbaeumer We discussed that you might move pipename to be an Environment Variable right?

Will very likely not happen since even under Windows there are commands ([System.IO.Directory]::GetFiles("\\.\\pipe\\")) every user can execute to list all pipes available in the system. So an env variable doesn't add any value.

We're planning to implement this in vscode-java also. The draft proposal just sets TransportKind.pipe at https://github.com/microsoft/vscode-languageserver-node/blob/4b77bb4d2e47dbfeeed6c263c28054eced60e030/client/src/node/main.ts#L69 for the executable representing the language server process. The server process then just reads --pipes to connect to the named pipe.

Hi guys, is it possible to use a custom (external) named pipe (provided by the already running external LSP server), in a form like:
\\.\pipe\qbs-lsp-1884

to startup the LanguageClient at all? Or this does not supported yet?
e.g. I faced with this issue: https://github.com/microsoft/vscode-languageserver-node/issues/1570

@denis-shienkov this is currently not support. Pipe names are internal and local. However you can implement your own transport to make this happen. See https://github.com/microsoft/vscode-languageserver-node/blob/dbaeumer/probable-muskox-peach/client/src/node/main.ts#L126

@dbaeumer, hi, could you please provide a more info, how to do it? Do you meant a MessageTransports?

Yes. As server options you basically use (() => Promise<ChildProcess | StreamInfo | MessageTransports | ChildProcessInfo>). Easiest is to return a MessageTransport which returns a reader / writer pair that is then used to talk to the LSP server.

Hmm, I tried do it like this:
    public constructor(pipeName: string) {
        const serverOptions = this.createMessageTransports(pipeName);
        const clientOptions: LanguageClientOptions = {
            documentSelector: [{ language: 'qbs' }],
        };
        console.info('Starting Qbs language client on pipe: ' + pipeName);
        this.languageClient = new LanguageClient('Qbs', (() => serverOptions), clientOptions);
        this.languageClient
            .start()
            .then(async () => {
                console.info('Qbs language client started on pipe: ' + pipeName);
            })
            .catch((reason) => {
                void vscode.window.showErrorMessage('Cannot start Qbs language server');
                console.error('Unable to start Qbs language client on pipe: ' + pipeName + ', ' + reason);
            });

    }

but it fails with:
Starting Qbs language client on pipe: \\.\pipe\qbs-lsp-9388
Unable to start Qbs language client on pipe: \\.\pipe\qbs-lsp-9388, Error: listen EADDRINUSE: address already in use \\.\pipe\qbs-lsp-9388

I never tried reusing the pipe code for non local pipes. So I can't say if it is working? I was more thinking about implementing the server function all by yourself.

WOW, it does work, need to use the createServerPipeTransport() function instead (it uses internally net.createConnection(), instead of net.createServer()). So, we need only to connect to the ready pipe, but do not create it!!
@dbaeumer, Many thanks anyway.


Increase timeout on Solana integration tests

The Solana tests sometimes fail with timeouts, maybe this will work.
Signed-off-by: Sean Young<EMAIL_ADDRESS>

I've run the CI tests 11 times, no failures.


Invalid font path in error CSS files

Whenever an error occurs, the error page attempts to load a font from an incorrect path.
Under both the Admin and Customer sites, wwwroot\css\Error\font-awesome-min.css has several sources like the following:
src:url('../fonts/fontawesome-webfont.eot?v=4.7.0')
However, there's no ../fonts directory.  There is, however, a '../font-awesome/fonts directory.
Should, ../fonts/ be updated to ../font-awesome/fonts/ ?
I did this with my company's installation of the accelerator, and it seems to work.

Resolved in commit a39e425f9aecaba28648c2335dae11a6a2efc9cb


Placeholder issue with Glide library

This part in MessageListActivity.java :
private void setPicture(String pictureUrl, @DrawableRes int placeholder) {
Glide.with(getApplicationContext())
.load(StringUtils.isValid(pictureUrl) ? pictureUrl : "")
.placeholder(placeholder)
.bitmapTransform(new CropCircleTransformation(getApplicationContext()))
.into(mPictureView);
}
is using placeholder(placeholder) which is available in glide library 3.7.0.
This forces to use the older version of glide library.
Newer version of glide dont have  placeholder() function.
I am using chat21 with algolia. Algolia is using latest version of glide. This is causing an issue for me.
Please suggest a fix.

I am also facing the same problem.


As a dev, I want to refactor the FormPage Page

Description
Refactor the FormPage. Let's rename the page to Label Data Validation.
Prototype

Tasks

[ ] #308
[ ] #309
[ ] #310
[ ] #311
[ ] #312

Acceptance Criteria

[ ] The multiple sections of the form page need to be connected together to not lose progression.
[ ] The buttons on the stepper should be clickable to facilitate navigation through the form.
[ ] No verification of field confirmation should be done before the last section Fertilizer Guaranteed Analysis.
[ ] If fields are not confirmed when the user tries to proceed to the confirmation page, then the circle on the stepper containing that field becomes red and the user is block and can not go to the confirmation page.
[ ] If all the fields in a section are approved, then the circle on the stepper associated with that section turns green.
[ ] Each section of the form should be scrollable.
[ ] Every input in the form must be adaptive to allow for zooming page.
[ ] The confirm all button confirms all the fields in the table designated by it.
[ ] The page must not change in any way when the user switches sections. Only the part containing the form should change (not the carousel).

Additional information
Figma design (Please note that the dimension on the design are not accurate)
https://www.figma.com/design/wZAiODRsAfqa8cAxJtQAYr/Untitled?node-id=0-1&t=jbtVtLENKlvQoKjX-1

This issue is now an epic. The description has been updated.


Upgrade Newtonsoft.Json from 12.0.2 to 13.0.1

Addressing https://github.com/microsoft/MIEngine/security/dependabot/1

Looks like current VS main uses 13.0.1 already, so this looks save.


Unable to play the animation with " ar " attribute in AR mode

I am trying to animate model in ar mode but only the first animation of the model is playing.
Browser:Chrome
OS : Android
this is my code.
<model-viewer id="artag" alt="A 3D model of an astronaut." src="RobotExpressive.glb" animation-name="Walking" autoplay ar>

I am trying to animate model in ar mode but only the first animation of the model is playing.
this is my code.

Hi, if you launch AR with the ar attribute, you are using Scene Viewer (which is a native Android app). Currently, <model-viewer> allows you to configure the playing animation, but Scene Viewer only supports playing the first animation in your model.


Sometimes custom namespace CI get stuck on OSD purge Job

Logs:
2022-09-22 09:04:53.857065 E | cephosd: failed to check if osd 0 is safe to destroy, but force removal is enabled so proceeding with removal. failed to get safe-to-destroy status: exit status 11
2022-09-22 09:04:54.277149 I | cephosd: marking osd.0 out
2022-09-22 09:04:54.938042 E | cephosd: failed to fetch the deployment "rook-ceph-osd-0". deployments.apps "rook-ceph-osd-0" not found
2022-09-22 09:04:54.938065 I | cephosd: purging osd.0
2022-09-22 09:04:55.400075 I | cephosd: attempting to remove host '\x00' from crush map if not in use
@subhamkrai can you take a look

@parth-gr can you share the GitHub action runner link? and by the logs seems like osd.0 is not safe/available to remove.

@subhamkrai I re-run the instance,
if I will hit again I will paste the link here.

https://github.com/rook/kubectl-rook-ceph/actions/runs/3106870778/jobs/5070109645
Soon I will re-start

Raw logs:
022-09-26T06:43:51.8729970Z + sleep 5
2022-09-26T06:43:56.8893686Z + kubectl rook_ceph rook purge-osd 0 --force
2022-09-26T06:43:57.5770261Z 2022-09-26 06:43:57.576242 I | rookcmd: starting Rook v1.10.0-alpha.0.192.g2965373ea with arguments 'rook ceph osd remove --osd-ids=0 --force-osd-removal=true'
2022-09-26T06:43:57.5772211Z 2022-09-26 06:43:57.576888 I | rookcmd: flag values: --force-osd-removal=true, --help=false, --log-level=INFO, --operator-image=, --osd-ids=0, --preserve-pvc=false, --service-account=
2022-09-26T06:43:57.5774764Z 2022-09-26 06:43:57.577187 I | op-mon: parsing mon endpoints: c=<IP_ADDRESS>:6789
2022-09-26T06:43:57.5965515Z 2022-09-26 06:43:57.596043 I | cephclient: writing config file /var/lib/rook/rook-ceph/rook-ceph.config
2022-09-26T06:43:57.5981979Z 2022-09-26 06:43:57.597738 I | cephclient: generated admin config in /var/lib/rook/rook-ceph
2022-09-26T06:44:05.2992406Z 2022-09-26 06:44:05.298621 I | cephosd: validating status of osd.0
2022-09-26T06:44:05.3007643Z 2022-09-26 06:44:05.300282 I | cephosd: osd.0 is marked 'DOWN'
2022-09-26T06:44:11.7863549Z 2022-09-26 06:44:11.785548 E | cephosd: failed to check if osd 0 is safe to destroy, but force removal is enabled so proceeding with removal. failed to get safe-to-destroy status: exit status 11
2022-09-26T06:44:12.2248231Z 2022-09-26 06:44:12.224064 I | cephosd: marking osd.0 out
2022-09-26T06:44:12.8195187Z 2022-09-26 06:44:12.815597 I | cephosd: removing the OSD deployment "rook-ceph-osd-0"
2022-09-26T06:44:12.8195801Z 2022-09-26 06:44:12.815631 I | op-k8sutil: removing deployment rook-ceph-osd-0 if it exists
2022-09-26T06:44:12.8282205Z 2022-09-26 06:44:12.824080 I | op-k8sutil: Removed deployment rook-ceph-osd-0
2022-09-26T06:44:12.8473206Z 2022-09-26 06:44:12.846369 I | op-k8sutil: "rook-ceph-osd-0" still found. waiting...
2022-09-26T06:44:14.8545850Z 2022-09-26 06:44:14.853754 I | op-k8sutil: confirmed rook-ceph-osd-0 does not exist
2022-09-26T06:44:14.8546503Z 2022-09-26 06:44:14.853845 I | cephosd: did not find a pvc name to remove for osd "rook-ceph-osd-0"
2022-09-26T06:44:14.8547005Z 2022-09-26 06:44:14.853892 I | cephosd: purging osd.0
2022-09-26T06:44:15.4170029Z 2022-09-26 06:44:15.416255 I | cephosd: attempting to remove host '\x00' from crush map if not in use
2022-09-26T07:52:51.0494466Z ##[error]The operation was canceled.
2022-09-26T07:52:51.0687738Z Post job cleanup.
2022-09-26T07:52:51.2368002Z [command]/usr/bin/git version
2022-09-26T07:52:51.2457432Z git version 2.37.3
2022-09-26T07:52:51.2510591Z Temporarily overriding HOME='/home/runner/work/_temp/89aad31b-ea03-450c-baa7-1b0322dcaa63' before making global git config changes
2022-09-26T07:52:51.2513857Z Adding repository directory to the temporary git global config as a safe directory
2022-09-26T07:52:51.2520637Z [command]/usr/bin/git config --global --add safe.directory /home/runner/work/kubectl-rook-ceph/kubectl-rook-ceph
2022-09-26T07:52:51.2573202Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2022-09-26T07:52:51.2618588Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2022-09-26T07:52:51.2975278Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2022-09-26T07:52:51.3009893Z http.https://github.com/.extraheader
2022-09-26T07:52:51.3019900Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
2022-09-26T07:52:51.3059389Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :
2022-09-26T07:52:51.3879400Z Cleaning up orphan processes
2022-09-26T07:52:51.5148806Z Terminate orphan process: pid (23413) (bash)
2022-09-26T07:52:51.5178017Z Terminate orphan process: pid (23454) (kubectl)

+ sleep 5
+ kubectl rook_ceph rook purge-osd 0 --force
2022-09-26 06:43:57.576242 I | rookcmd: starting Rook v1.10.0-alpha.0.192.g2965373ea with arguments 'rook ceph osd remove --osd-ids=0 --force-osd-removal=true'
2022-09-26 06:43:57.576888 I | rookcmd: flag values: --force-osd-removal=true, --help=false, --log-level=INFO, --operator-image=, --osd-ids=0, --preserve-pvc=false, --service-account=
2022-09-26 06:43:57.577187 I | op-mon: parsing mon endpoints: c=<IP_ADDRESS>:6789
2022-09-26 06:43:57.596043 I | cephclient: writing config file /var/lib/rook/rook-ceph/rook-ceph.config
2022-09-26 06:43:57.597738 I | cephclient: generated admin config in /var/lib/rook/rook-ceph
2022-09-26 06:44:05.298621 I | cephosd: validating status of osd.0
2022-09-26 06:44:05.300282 I | cephosd: osd.0 is marked 'DOWN'
2022-09-26 06:44:11.785548 E | cephosd: failed to check if osd 0 is safe to destroy, but force removal is enabled so proceeding with removal. failed to get safe-to-destroy status: exit status 11
2022-09-26 06:44:12.224064 I | cephosd: marking osd.0 out
2022-09-26 06:44:12.815597 I | cephosd: removing the OSD deployment "rook-ceph-osd-0"
2022-09-26 06:44:12.815631 I | op-k8sutil: removing deployment rook-ceph-osd-0 if it exists
2022-09-26 06:44:12.824080 I | op-k8sutil: Removed deployment rook-ceph-osd-0
2022-09-26 06:44:12.846[369](https://github.com/rook/kubectl-rook-ceph/actions/runs/3106870778/jobs/5070109645#step:5:370) I | op-k8sutil: "rook-ceph-osd-0" still found. waiting...
2022-09-26 06:44:14.85[375](https://github.com/rook/kubectl-rook-ceph/actions/runs/3106870778/jobs/5070109645#step:5:376)4 I | op-k8sutil: confirmed rook-ceph-osd-0 does not exist
2022-09-26 06:44:14.853845 I | cephosd: did not find a pvc name to remove for osd "rook-ceph-osd-0"
2022-09-26 06:44:14.853892 I | cephosd: purging osd.0
2022-09-26 06:44:15.416255 I | cephosd: attempting to remove host '\x00' from crush map if not in use

This is not valid anymore since we have moved to  golang and not noticed since then.


Published results not getting reproduced

Hi,
I am trying to reproduce the ndcg scores published on the readme
However, I am not getting similar numbers.
I run the run_xxxx.sh functions provided in examples/wikiqa/
On the prediction task, I get ndcg@3 values around 0.3 AS compared to the 0.5 to 0.6 range published.
Could I be doing something wrong?
Isn't running the network with --predict the correct way of getting there?
Example output:
[05-16-2018 19:19:00]   [Predict] @ predict [Predict] results<EMAIL_ADDRESS><EMAIL_ADDRESS>map=0.416128 for cdssm
and
[05-17-2018 18:24:32]   [Predict] @ predict [Predict] results<EMAIL_ADDRESS><EMAIL_ADDRESS>map=0.391363 for mvlstm

@faneshion

Same issue here

@aneesh-joshi @bwanglzu See my reply [here] (https://github.com/faneshion/MatchZoo/issues/99)

discussion going on in
https://github.com/faneshion/MatchZoo/issues/99
So, closing


ARROW-11717: [Integration] Fix intermittent flight integration failures with rust

Background
Thanks to the 🦅 👁  of @lidavidm https://github.com/apache/arrow/pull/9583#issuecomment-786925049 it appears that the Rust flight integration test prints "Server listening" before the server is actually read to accept connections. Thus creating a race condition: if the tests try and start faster than the rust server can actually be setup then we see integration test failures as shown in https://issues.apache.org/jira/browse/ARROW-11717:
Traceback (most recent call last):
  File "/arrow/dev/archery/archery/integration/runner.py", line 308, in _run_flight_test_case
    consumer.flight_request(port, **client_args)
  File "/arrow/dev/archery/archery/integration/tester_cpp.py", line 116, in flight_request
    run_cmd(cmd)
  File "/arrow/dev/archery/archery/integration/util.py", line 148, in run_cmd
    raise RuntimeError(sio.getvalue())
RuntimeError: Command failed: /build/cpp/debug/flight-test-integration-client -host localhost -port=33569 -scenario auth:basic_proto
With output:
--------------
-- Arrow Fatal Error --
Invalid: Expected UNAUTHENTICATED but got Unavailable

Changes
This PR changes the Rust flight scenario harnesses to print the ready message after the server is actually ready.

@alamb if I'm not mistaken, serve().await? will block until the server is terminated, which means that the test is now stuck. Is there any way to start a server without waiting for it? (Most other gRPC implementations provide this.)
Alternatively, we could add a retry loop…

@lidavidm good call -- let me try something else

@lidavidm  thank you for the help -- it is like you are writing the code for me :)

The integration test passed: https://github.com/apache/arrow/pull/9593/checks?check_run_id=1995394206
I'll manually retrigger a few times to see if there might be still something lurking

Thanks @alamb !


AcraServer refactoring for better shutdown control

This PR introduces refactoring on main component level (SServer) of AcraServer service.
I used approach, described in T1661 and already implemented in https://github.com/cossacklabs/acra/pull/414 for AcraTranslator. Just short reminder: we need better control of shutdown process because it is very important for EE version in context of audit logging (where we need to finish execution of service with special service log messages). So here on main component level I added synchronization of spawned goroutines (with a help of waitGroup mechanism) and signalling of shutdown invocation with a help of parentContext (passed to SServer from main function of AcraServer).
For testing I used two versions of AcraServer (CE and EE), according to the procedures described in https://github.com/cossacklabs/acra/pull/414 but with little modification, since we AcraServer works with databases. Test application is the following (basic Go's unit test):
func TestDebug(t *testing.T) {
	connectionsNum := 10
	queriesNum := 50000

	var wg sync.WaitGroup
	for i := 0; i < connectionsNum; i++ {
		wg.Add(1)
		go func() {
			defer wg.Done()
			db, err := sql.Open("postgres", "port=9393 user=test dbname=test password=test sslmode=disable")
			if err != nil {
				t.Fatal(err)
			}
			defer db.Close()
			var col string
			for i := 0; i < queriesNum; i++ {
				rows, err := db.Query("SELECT 2 + 2")
				if err != nil {
					t.Fatal(err)
				}
				defer rows.Close()
				for rows.Next() {
					err = rows.Scan(&col)
					if err != nil {
						t.Fatal(err)
					}
				}
			}
		}()
	}
	wg.Wait()
}

Here I create 10 simultaneous connections to AcraServer and execute 50000 toy queries (SELECT 2+2) inside each of them.
While execution, I send SIGHUP, SIGTERM signals and manually check the behavior of the service. While SIGHUP testing I encountered some errors when connections are cut:
time="2020-09-30T20:39:37+03:00" level=error msg="Network error" client_id=client code=1100 error="read tcp <IP_ADDRESS>:9393-><IP_ADDRESS>:45902: use of closed network connection" interrupt_side="Client/Connector<->Database"

time="2020-09-30T20:39:37+03:00" level=warning msg="Can't flush writer" client_id=client code=1301 decrypt_mode=wholecell error="write tcp <IP_ADDRESS>:9393-><IP_ADDRESS>:45908: use of closed network connection" proxy=server

As discussed with @Lagovas this seems to be expected errors, because connections are long-term and when they are cut, proxying functions (ProxyClientConnection, ProxyDatabaseConnection) that handle encryption/decryption are still try to use connection that is already closed (and proxies don't have information if this connection closing is caused by SIGHUP/SIGTERM, e.g. "legitimate" case or it is some unexpected network error). The rest of system signals handling works as expected. For SIGTERM it gracefully stops service (and we guarantee that all goroutines are finished before os.Exit), and SIGHUP forks child process and exits from parent.
Changes in CE version of AcraServer also present in this PR (they are minimal), while changes in EE version will be introduced in separate PR to EE repository.

I will merge it, since PR in EE will depend on master branch of CE. If it will be some more discussions/questions, I can address them in separate PR


--no-random does not work anymore

Hi,
experiencing issues with --no-random. This flags does not work anymore :-)

Goddamn :D Thanks, I'll investigate. :)

no sorry - i am wrong

My fault - forgotten to use it with html option

Ok .. clarification. --no-random is not working for html output

Awesome, thanks. It's probably ignored 🤦

Should be fixed and released now :)


how to get feature names from explainer

Hi, I'm experimenting with SHAP and xgBoost.
It's easy to get the Shapley values from explainer, but I can't seem to find any way to link them with the feature names. I see that force_plot can get the feature names. How can I get them?
Thanks,
Barry Feldman

PS Actually, I can rephrase my question. Is the order of the features in the shap_values array the same as it is in the X data matrix?

Yep! The matrix returned from a call to shap_values(X) is exactly parallel to X (same shape and layout).

Thanks for the confirmation!


#161047936 Create login page UI

What does this PR do?
Creates a login page for  the web application
Description of Task to be completed?
Creation of a UI template that would allow users to log in using a username and a password
How should this be manually tested?

Change directory to Store Manager directory using cd Store-Manager/UI
Launch the login.html file using a  browser.
Any background context you want to provide?
None
What are the relevant pivotal tracker stories?
#161047936
Screenshots (if appropriate)

Questions:
What do you think about the UI?

Design is generally good,
Just check on your link to pt story, the ID might be missing a number....its not an active link.

Great design :+1: I like the subtle box-shadow.

Design is generally good,
Just check on your link to pt story, the ID might be missing a number....its not an active link.

Okay on it... Thank you

Beautiful User Interface

@BoltC0rt3z Good work. I would suggest you change the font to the Login form title to something like Roboto or Museo. Otherwise, Its just fine

It looks simple and good

Hi BoltC0rt3z,
What a tough name you have, your design is simple and appealing to me.
Regards
Steven Ennis

This is good. Maybe center the input fields for an even better design.


[fluidsynth] Remove ALSA patch

[X] Changes comply with the maintainer guide
[X] SHA512s are updated for each updated download
[X] The "supports" clause reflects platforms that may be fixed by this new version
[X] Any fixed CI baseline entries are removed from that file.
[X] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Now that #30960 is merged, this patch is no longer necessary.


esbuild-plugin-html does not use the original directory of the source file

I'm trying to use esbuild-plugin-html with the esbuild-plugin-glob plugin to use it with several html files, like this:
[ "pages/**/*.html", "dynamic_pages/**/*.html"];
This breaks as the code now just uses the filename and not the directory.  I hacked it to work by changing the creation of the finalOutputFile const  in the index.js around line 28595  to this:
 const finalOutputFile = `${workingDir}/${outDir}/${inputs[0]}`;
I'm not making a PR as I have a hard time understanding the original way of setting the path and what else in the code it affects but maybe you can have a look and adjust it so it does take the path into account?

Hi @edoardocavazza ,unfortunately it does not seem to work yet; I do see directories being created e.g. within 'dynamic_pages'  but I still only have one resulting html file in the root of the dist dir, so it seems like the files aren't using the directory they are read from as a target to write to but just overwrite the one in the root of the dist target dir. Also I can't reopen this issue, can you or should I create a new one?

any progress on this?

Hi @maartenst, I am sorry for the delay, I really wanted to fix this but haven't time yet. It would be very helpful for me to have a reproduction repository to test out 🙏

ok, I'll create one as soon as I have time, sometime this week probably, thanks!

I am seeing the same problem. If my entrypoints are ["index.html", "theme/ThemeChooser.html"] then I am seeing rna output two HTML files into the same directory. I am expecting ThemeChooser.html to be output into the theme subdirectory.

@edoardocavazza Looking at https://github.com/chialab/rna/pull/136/files#diff-c6783ff3262b589fcafddcb8136b1887bc87e55d9d36e39f91ff73479bd2d09aR122 I'm not sure why you removed [dir] from a bunch of places. Maybe putting it back would fix the problem?

Ah, nevermind. This was caused by user-error. My configuration was missing: entryNames: "[dir]/[name]". I'm guessing that the default configuration is equal to [name] which is why the directory was being stripped away. This works properly for me now.
@maartenst maybe you had the same problem?


Implement stake program

Reference: https://github.com/solana-labs/solana-web3.js/blob/master/src/stake-program.js

Closing this for now. Will re-open upon request.


Change field label of 'keywords' from "Translation Equivalents" to "Abstract Meaning" for morphemes

Done.

Done == Did first part (Issue description, "Abstract Meaning".)

@susanodd , the label is now also used for signs (like in the list view of signs/search results), but the request was only to use "Abstract meaning" for Morphemes. Could you make it such that there are two labels, one for the morphemes (Abstract meaning) and one for the signs (Translation equivalents)?

I fixed the label for signs so it's back to Translation Equivalents instead of Abstract meaning.


Design external API

[x] Internal methods hidden with @internal
[x] External methods annotated with JSDoc
[x] Structure of simplified API clear, begun implementing...
[x] Created issues for the remaining problems


Unify shared dependencies

Signed-off-by: at91mm<EMAIL_ADDRESS>

@mgorsk1 how would that work with the PyPi versions of Amundsen packages?
PyPi requires the files needed for the setup.py in the build, that means we need to include the requirements-common.txt and other common requirements file within the build for each package.

That's exactly how it would work. The requirements-dev and requirements-common files would be a part of artifacts built by sdist and bdist. It should be possible with proper manifest definitions (assuming your concern is over symlinks resolution?)

how about databuilder? currently the model is defined in both common and databuilder which we should eventually make databuilder depends on common model to make it consistent to avoid model drifting.

In principle I agree that long term there should not even be models folder in any of the project except for the common. This would be however a major refactor from a different angle than I had in mind for this RFC. I will add this to future possibilities.

Nice, thanks! I've already started to draft something under https://github.com/amundsen-io/amundsen/pull/1163 , seems most major things are resolved - mostly flake8 complains since I've bumped the version and not all the code is now compliant.


Multiple focus rings sometimes appear when navigating by keyboard

🐛 Bug Report
When navigating calendar grids using the keyboard, multiple focus rings sometimes appear. This generally happens when moving to a month that was previously not rendered. Confirmed the be behavior in Chrome and Brave. I can not reproduce the issue using Safari or Firefox.
🤔 Expected Behavior
Only one element should have a visible focus ring at a time
😯 Current Behavior
I hope this is as easy to reproduce for you as it is for me (using update-to-date Chrome on MacOS). This generally happens when moving to a month that was previously not rendered. It most often happens with disabled dates, but not always ... I've seen the the "ghost focus" item sometimes be a non-disabled date.
This example is using Devon's Code Sandbox for useCalendar - styled example with Tailwind:

In the gif, I refresh the page, click on the preview area then tab to the calendar. Then I use the arrow keys to navigate back and forth from Feb. to March. As I do so, one or more days that do not have focus will show with a focus ring. These "ghost focus" days are most often in early Jan. outside the calendar range, and thus disabled. But you'll see I eventually get a day in March to behave the same).
At the end of the gif, I click on the preview area to hide the visual focus ring(s), then hit the tab key to bring them back. You'll see the multiple days in the calendar are still showing as if they have focus.
Not seen in the gif, but if you can move the focus to one of the "ghost focus" days, then the problem for that day will correct itself.
💁 Possible Solution
(tldr; I have no solution, only guesses at what is happening)
I do not think this is a calendar-related bug, but an issue with useFocusRing. I've seen similar visual focus ring bugs occasionally pop up working with other components built using useFocusRing ... but never as bad as this.
You'll notice that the January "ghost focus" days tend to match the previous real focus position in March. So for example, if you focus the fourth column in the first row of March and then hit the "up" key, the fourth column in the first row of January will often get the "ghost focus". I don't know how the focus management logic works in useFocusRing, but seems like it's trying to guess based on similar html structure ... Focus was on the element in the first table in the first row in the fourth cell, but the DOM changed so I'm going to try to re-select that same first-table-in-the-first-row-in-the-fourth-cell element.
🔦 Context
Discovered while evaluating the useCalendar hooks to build a replacement for an aging fork of Airbnb's react-dates on a government website where accessibility/Section 508 compliance is critical.
💻 Code Sample
As mentioned above, reproducible here: https://codesandbox.io/s/objective-shape-8r4utm?file=/src/App.js:213-1267
🌍 Your Environment

Software
Version(s)

react-aria/focus
3.10.1

Browser
Chrome, Brave, Edge

Operating System
MacOS 13.1

I can not reproduce the issue using Safari or Firefox.

Was able to reproduce in the sandbox, but not with the React Spectrum Calendar/RangeCalendar w/ multiple visible months set. Will have to dive into what the difference between the two implementations there are.

Potentially related to https://github.com/adobe/react-spectrum/issues/2015

I also ran into this issue but figured out a workaround.
I'm not entirely sure why the sample code use useFocusRing but there is actually a isFocused property from useCalendarCell that seems to work well independently.
I forked the code sample to test with https://codesandbox.io/s/boring-tesla-94fj43?file=/src/CalendarCell.js
https://github.com/adobe/react-spectrum/assets/484912/68bc1809-01d7-4268-9963-b243e266935f

@longzheng useFocusRing tracks whether or not focus should be "visible" or not (aka if the user is using a keyboard to interact with the Calendar and thus a ring should be rendered around the focused cell) which isFocused from useCalendarCell doesn't distinguish unfortunately.

@LFDanLu Right it's essentially like focus-visible:.
Then I think the workaround/fix is to use both the isFocused && isFocusVisible values together to only show when the actual date is selected and when the focus should be visible.
            // Darker selection background for the start and end.
            isSelectionStart || isSelectionEnd
              ? "bg-violet-600 text-white hover:bg-violet-700"
              : ""

This seems to work in my testing https://codesandbox.io/s/interesting-snow-6g9dlx
https://github.com/adobe/react-spectrum/assets/484912/11fd8cd9-ab85-4cf9-a6bf-f7207afafd53


AVFoundationErrorDomain - code -11800

Bug
I have an app that uses AWS url to reproduce videos, at first when i installed react-native-video it worked as expected, but suddenly, without any changes by me, it stoped working and gave me the error:
"AVFoundationErrorDomain" code -11800
Ive tried a lot of approaches but unsuccessful. It seem to start randomly. There is A LOT of posts relating the same problem, i dont understand why the f* most of them are already closed since NO ONE COULD CONSISTENTLY FIX IT and NO ONE ANSWER WTF is going on. Could PLEASE someone from the lib dev team put some effort on this to get this fixed to help me and the tons of ppl that are having the same issue?
Platform
IOS
Which player are you experiencing the problem on:

iOS

Environment info
System:
OS: macOS 11.2
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 538.75 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.15.5 - ~/.nvm/versions/node/v14.15.5/bin/node
Yarn: 1.22.5 - ~/.yarn/bin/yarn
npm: 6.14.11 - ~/.nvm/versions/node/v14.15.5/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Xcode: 11.3.1/11C505 - /usr/bin/xcodebuild
Languages:
Java: 14.0.2 - /Users/caduolivera/.sdkman/candidates/java/current/bin/javac
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.63.4 => 0.63.4
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Library version: 5.1.1
Steps To Reproduce

start a fresh rn project
Install react-native-video lib
try any public url video as source: http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/ForBiggerEscapes.mp4
...

Expected behaviour

The video should play or be playable

Reproducible sample code
 <Video
            source={{
              uri: data.arquivo.nm_url,
            }}
            onBuffer={(e) => console.log('buffer video', e)}
            onError={(e) => console.log('err video', e)}
            style={styles.video}
            controls
            paused={true}
          />

Video sample
http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/ForBiggerEscapes.mp4
----- EDIT -----
I have new information about this.
I tried to replace the video component for a webview using react-native-webview, same error, video loads first screen but does not play.
I also tried to open the same video at safari, pasting link url directly... same error.
Conclusion: That makes me think this issue is not related to this lib. But this does not mean we could work together on tests and research to figure it out, in case some of you still have this issue.

lots of live tv not working. Black screen is coming and -11800 error. Can this be fixed please?

This does not seem to be a react-native-video issue, it's a IOS issue. I installed Xcode 12 beta and managed to build to a new emulator, now it works. I don't have this problem on release version or testing in a real phone. This is not a consistent issue and there is no definitive answer yet from either apple or react-native-video lib developers.

I saw one app iSTB player where same channel is playing in IOS 14. Don’t know what they have used. Not sure how they are doing.

Have you tried using an https url ?

Any update on this? I was experiencing this issue also.

Not really.
Sent from my iPhone

On 6 May 2021, at 09:25, Vince Llauderes @.***> wrote:

Any update on this? I was experiencing this issue also.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

same here

Have you found out anything? @carlosedof

I am facing the same issue here. Now trying to load the https video file but getting 11800 error and not playing the video

same here. Any update on this? I still played but now I cannot

same here. Any update on this? I still played but now I cannot

try this
https://github.com/react-native-video/react-native-video/issues/2250#issuecomment-851316603


Selection stuck on the first option

Trying out the demo on https://solid-select.com/, I noticed that the first option always receives data-focused=true regardless of user choice. The onChange event does reflect that choice but the UI does not. Is there some way to get the UI to show the user's selection?

This definitely needs to be fixed in future versions.
Until then, here is a hacky solution, which uses 'isOptionDisabled' prop in order to focus selected item:
import { Component, createSignal } from 'solid-js';
import { Select } from '@thisbeyond/solid-select';
import<EMAIL_ADDRESS>import './custom_style.css';

export default () => {
    const [selected, setSelected] = createSignal();

    return (
        <Select
            options={['apple', 'banana', 'pear', 'pineapple', 'kiwi']}
            isOptionDisabled={(option: string) => option === selected()}
            onChange={(option: string) => setSelected(option)}
        />
    );
};

custom_style.css:
.solid-select-option[data-focused='true'] {
    @apply bg-transparent;
}

.solid-select-option:hover {
    @apply bg-gray-200;
}

.solid-select-option[data-disabled='true'] {
    @apply bg-gray-100;
}

Do you mean you want it to auto-highlight the matching option in the options list for the current value?

Yes, that's what op means. Take a look at native select, it should behave similarly. Although, unlike native select, I suggest separating logic and style for the 'selected' and 'focused' option.

Any news on this one? I'm using the above hack as well. It would be great if the selection option is highlighted (instead of always the first one) and if the list scrolls such that the selected option is in view (instead of always showing the top of the list).

Going to look at this in the coming weeks.


Pytest Discovery does nothing when python.testing.cwd is set

Type: Bug

Behaviour
Expected vs. Actual
Expect pytest discovery can found tests. And if not - reports what is wrong.
Steps to reproduce:

create workspace-folder | create workspace with folder (I checked both, thinking of #21082 #22218)

inside any folder create pytest_issue

inside pytest_issue/test_foo.py with any test, e.g. def test_foo(): ....

ensure config for workspace or folder:

    "python.testing.cwd": "pytest_issue",
    "python.testing.pytestArgs": [],
    "python.testing.unittestEnabled": false,
    "python.testing.pytestEnabled": true,

Run Discovery couple times:

2023-11-20 19:27:24.225 [info] Discover tests for workspace name: projects - uri: /Users/user/projects
2023-11-20 19:27:24.225 [info] Running discovery for pytest using the new test adapter.
2023-11-20 19:27:32.465 [info] Discover tests for workspace name: projects - uri: /Users/user/projects
2023-11-20 19:27:32.465 [info] Running discovery for pytest using the new test adapter.
2023-11-20 19:37:25.089 [info] Discover tests for workspace name: projects - uri: /Users/user/projects
2023-11-20 19:37:25.089 [info] Running discovery for pytest using the new test adapter.

nothing. :(
No steps further of: https://github.com/microsoft/vscode-python/blob/f6cfa6e2cc89ab37f7d57096e19d3a9a77e441cf/src/client/testing/testController/controller.ts#L271

As soon as I delete python.testing.cwd, it starts working. (But my real env needs python.testing.cwd, so no WA)

If I Reload Window, I got:

2023-11-20 19:38:32.144 [info] > ./venv/bin/python -m pytest -p vscode_pytest --collect-only
2023-11-20 19:38:32.144 [info] cwd: pytest_issue
2023-11-20 19:38:32.636 [info] Starting Pylance language server.
2023-11-20 19:38:39.050 [info] Discover tests for workspace name: projects - uri: /Users/user/projects
2023-11-20 19:38:39.050 [info] Running discovery for pytest using the new test adapter.

In other times to --collect-only no calls. Silence.

Diagnostic data

Python version (& distribution if applicable, e.g. Anaconda): Cpython 3.9 - 3.11
Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv or Local
Value of the python.languageServer setting: Default
I tried on Darwing, Ubuntu, Centos
Local env was used with Remote SSH. While ven fully on host - as repro.

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

2023-11-20 19:27:24.225 [info] Discover tests for workspace name: projects - uri: /Users/user/projects
2023-11-20 19:27:24.225 [info] Running discovery for pytest using the new test adapter.
2023-11-20 19:27:32.465 [info] Discover tests for workspace name: projects - uri: /Users/user/projects
2023-11-20 19:27:32.465 [info] Running discovery for pytest using the new test adapter.
2023-11-20 19:37:25.089 [info] Discover tests for workspace name: projects - uri: /Users/user/projects
2023-11-20 19:37:25.089 [info] Running discovery for pytest using the new test adapter.

User Settings

    "python.testing.cwd": "pytest_issue",
    "python.testing.pytestArgs": [],
    "python.testing.unittestEnabled": false,
    "python.testing.pytestEnabled": true,

Extension version: 2023.20.0
VS Code version: Code 1.84.2 (Universal) (1a5daa3a0231a0fbba4f14db7ec463cf99d7768e, 2023-11-09T10:52:33.687Z)
OS version: Darwin arm64 23.1.0
Modes:

System Info

Item
Value

CPUs
Apple M2 Max (12 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
1, 2, 2

Memory (System)
96.00GB (29.92GB free)

Process Argv
--crash-reporter-id 0ddd1806-9bb8-4a88-8fc3-dfe586936e48

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30880072
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
282f8724:30602487
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
synctok:30869157
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixtcf:30871695
pythonregdiag2:30871582
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
2e7ec940:30885897
pythontbext0:30879054
dsvsc016cf:30886111
dsvsc017:30886112
dsvsc018cf:30886115
aa_t_chat:30882232

Happy to see this reported as I'm also suddenly experiencing this issue as well:

BUT
If I revert to version 1.83, it works as expected and doesn't get stuck.

Hello! I have just returned from vacation and will take a look at this shortly, thank you for your patience!

@eleanorjboyd any progress?
I'm also having this issue.

closing as that was the fix for @dmakhno, but anyone please comment if a fix to your path in your cwd is not working. If you do, please provide logs and a project structure like @dmakhno did. Thanks

@ivan-the-terrible, it seems like your issue might be different since you aren't specifying a cwd. If you could open a new issue I can help you there. Thanks

actually I am going to reopen this, there should be some sort of error message to signal the incorrect cwd is the problem. Will investigate that, thanks

@eleanorjboyd I need some time to check.
I'm definitely sure it used to work as I mentioned. Not sure why need to start the path for ./
And I fully agree - silence is not right.

@eleanorjboyd encountering the same error after latest update of vscode, this is my settings.json:
{
  "python.defaultInterpreterPath": ".venv/bin/python",
  "python.testing.pytestArgs": [
    "tests"
  ],
  "python.testing.unittestEnabled": false,
  "python.testing.pytestEnabled": true,
  "python.testing.cwd": "${workspaceFolder}",
  "python.envFile": "${workspaceFolder}/config/test.env"
}

And this is the pytest discovery output from vscode:
2023-12-11 10:55:45.495 [info] Discover tests for workspace name: [REDACTED] - uri: /Users/andreashaure/source/[REDACTED]
2023-12-11 10:55:45.504 [info] > ~/source/[REDACTED]/.venv ~/.vscode/extensions/ms-python.python-2023.22.0/pythonFiles/testing_tools/run_adapter.py discover pytest -- --rootdir ~/source/[REDACTED] -s --cache-clear  tests
2023-12-11 10:55:45.504 [info] cwd: ~/source/[REDACTED]
2023-12-11 10:55:45.506 [error] Error discovering pytest tests:
 Error: spawn /Users/andreashaure/source/[REDACTED]/.venv EACCES
    at Process.ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -13,
  code: 'EACCES',
  syscall: 'spawn /Users/andreashaure/source/[REDACTED]/.venv',
  path: '/Users/andreashaure/source/[REDACTED]/.venv',
  spawnargs: [
    '/Users/andreashaure/.vscode/extensions/ms-python.python-2023.22.0/pythonFiles/testing_tools/run_adapter.py',
    'discover',
    'pytest',
    '--',
    '--rootdir',
    '/Users/andreashaure/source/[REDACTED]',
    '-s',
    '--cache-clear',
    'tests'
  ]
}

@eleanorjboyd,
today I tried on
Version: 1.85.0 (Universal)
Commit: af28b32d7e553898b2a91af498b1fb666fdebe0c
Date: 2023-12-06T18:18:04.614Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.1.0

"python.testing.cwd": "./pytest_issue"

WA - Does not work!
Some tiny anomaly I see, if I just start/restart vscode - discovery pretend to start.
Under "pretend" I mean extra log
2023-12-14 19:00:47.304 [info] Discover tests for workspace name: projects - uri: /Users/user/projects
2023-12-14 19:00:47.304 [info] Running discovery for pytest using the new test adapter.
2023-12-14 19:00:47.305 [info] All environment variables set for pytest discovery for workspace <CUTTED>
2023-12-14 19:00:47.321 [info] > /usr/bin/python3 -m pytest -p vscode_pytest --collect-only
2023-12-14 19:00:47.321 [info] cwd: ./pytest_issue

And no more.
But when I run "Test: Refresh Tests" command. Absolutely nothing
2023-12-14 19:02:51.655 [info] Discover tests for workspace name: projects - uri: /Users/user/projects
2023-12-14 19:02:51.655 [info] Running discovery for pytest using the new test adapter.
2023-12-14 19:03:26.626 [info] Discover tests for workspace name: projects - uri: /Users/user/projects
2023-12-14 19:03:26.626 [info] Running discovery for pytest using the new test adapter.

It happens for both cwd with/wo dot.

Hi @dmakhno, sorry it isn't working still. This is the project I made to test it, let me know how yours differs. You could also try my project on your machine and see if that works.

@eleanorjboyd, yep it is the same. Thanks!
I found what was wrong for me. Hope following make sense for you.
All times I restarted vscode with "python.testing.cwd": "pytest_issue", after this when I even fixed path, it didn't help. Something got stuck.
When I opened your project, path was correct from the start, and it keep working.
So, I set path with dot for me, restarted vscode and it worked!
I wonder why first discovery atempt makes such effect? (shrug)
Checked on full size project, WA works. After proper setting of cwd need vscode restart. "Refresh Tests" is useless.
Some minor observation.
Remote (centos like os):
"python.testing.cwd": "./unit_test"
2023-12-15 18:18:36.929 [info] > /bin/python -m pytest -p vscode_pytest --collect-only
2023-12-15 18:18:36.929 [info] cwd: /local/user/repos/project/unit_tests

cwd is resolved to full path
Local - your project (darwin):
2023-12-15 18:09:11.542 [info] > /usr/bin/python3 -m pytest -p vscode_pytest --collect-only
2023-12-15 18:09:11.542 [info] cwd: ./pytest_issue

cwd stays relative.

ah yes this makes sense "After proper setting of cwd need vscode restart. "Refresh Tests" is useless.", I am looking into why the extension doesn't error out but it has a behavior where if discovery is already running it will not run again even with new args because discovery is expensive. As I work to figure out how to get the extension to error out on the wrong cwd I had added some logging to notify the user that discovery is not being re-run, hopefully this will help the next user. Sorry for the difficulty! https://github.com/microsoft/vscode-python/commit/a05dee86b3441b2b75371f05292195c35266b18c

@ivan-the-terrible, it seems like your issue might be different since you aren't specifying a cwd. If you could open a new issue I can help you there. Thanks

Yeah I think I might running up against the fact that discovery doesn't rerun and reopening VSCode helped as it was able to be rediscovered after some attempts. I'm not entirely sure...
But I downloaded the sample project you created and get the same error on Windows (running VSCode v1.85.1).
As I was ensuring the virtual environment was configured properly, I also noticed in the Testing panel it will append the testing structure and leave some vestigial structures.
Setting the "python.testing.cwd": "${workspaceFolder}/pytest_issue", (or to ./pytest_issue) and removing it leaves discovery in a bad state.

@eleanorjboyd, github-actions is worried that something is needed. :-)
Lookiing forward for:

nicer logging
(optionally) for relative path, no need to use . (dot). As it used to work.


Unit tests + TravisCI

Maybe you already know TravisCI, but this service is great to build and run unit tests on each push performed, against each supported python version.
This could be added on this project, but also on openant project. I can make the travisCI configuration and CI build in setup.py if you want @Tigge, but you will have to configure the TravisCI webhook in github (Step 1 & 2 in the link) for both projects.
Also, coveralls.io is as service for measuring code coverage on unit tests, could be nice to include too.
Also we could use setuptools instead of distutils. (for example, to make python setup.py test just works).
The following is just an idea, as there are already unit tests included in openant : Maybe we could add a feature to "record" a real device messages at some time, to be able to replay it for test purposes. I think we could add a test to simulate download and upload for each supported device.

I'm all for resources that can help with testing in any way so I'll be happy to add any hooks needed or anything else. It is probably most interesting to start with openant, there are a few unittest there that doesn't require a device so those can be set up and made to run right away. In comparison with openant, antfs-cli is actually rather tiny. But if you or anyone else want to add more unit tests to either of the projects no one would be more happy then me :smile:.
Moving from distutils to setuptools is also fine by me, seems the later is the preferred way nowadays.
Using fake device data with test in openant is certainly a good thing to do, whether that is recorded or just constructed or simulated in some way. With more development two clients running openant should be able to talk with each other as well, could be interesting for tests.
But let's start with the configuration and test in setup.py and then I'll set up that hook.

Ok, added hook: https://travis-ci.org/Tigge/openant

Thanks ! Could you add coveralls.io too ? Having the code coverage figures will help to try to increase it :)

Done: https://coveralls.io/r/Tigge/openant

I've opened PR in both projects @Tigge, let's try merging the one from openant it should then run tests in travisCI and add upload code coverage to coveralls.IO.

And we can close this now. Thanks!


feat: add owl file url validation before running processing

Changes:

Check URLs for 200 response before starting download thread. Fail main thread if non-200 and stop auto-commit in the process

Tested with a couple of intentionally 404 URLs in this branch, reverted back to working order now

Are there any tests to update with this change?

We don't have any existing tests for this script, nor the gene processing script. Worth considering for a separate PR


Generate docset for WP-CLI v2.0.0?

@ptrkcsk Does a docset need to be generated for WP-CLI v2.0.0?
Also, what's the process for publishing the docset? Can we document that in the README?

Yeah! I was waiting to see v2.x released of wp-cli/handbook. Am I correct in assuming that wp-cli/handbook releases correspond to a matching release of wp-cli/wp-cli? If so, will that continue to be the case?
I'd be happy to add the publishing process to the readme. In the meantime, here's Dash's documentation for user-generated docsets.

Am I correct in assuming that wp-cli/handbook releases correspond to a matching release of wp-cli/wp-cli? If so, will that continue to be the case?

Yes, and correct. I've tagged the v2.0.0 release: https://github.com/wp-cli/handbook/releases/tag/v2.0.0
@schlessera Can you make sure tagging a handbook release is a part of the release process?

I'd be happy to add the publishing process to the readme. In the meantime, here's Dash's documentation for user-generated docsets.

Cool, sounds good. Linking to that reference would be sufficient, I think.

Pull request created: Kapeli/Dash-User-Contributions#2047

The docset for v2.0.0 is now available on Dash.

Readme updated.


Make the prev / next buttons work

Needs some semantics as to how to deal with multiple shows, especially multiple locations.

… or, since the rewrite, add them again first.


Global minimum > Local minimum

When benchmarking multithreaded insert performance of sled 1.0.0-alpha.120, this error would occasionnally occur when inserts happens from more than 4 threads.
thread '<unnamed>' panicked at /home/daibo/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ebr-0.2.11/src/lib.rs:333:21:
global minimum: 9292, ours: 9290
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at src/main.rs:100:23:
called `Result::unwrap()` on an `Err` value: Any { .. }

This is the benchmark code
fn sled_multi_threaded_put(items: usize, threads: usize) {
    let path = "./sled";
    let db = sled::open(path).unwrap();
    let mut handles = vec![];
    for t in 0..threads {
        let db = db.clone();
        handles.push(std::thread::spawn(move || {
            for i in (t * items / threads)..((t + 1) * items / threads) {
                let key = i.to_be_bytes();
                db.insert(key.as_ref(), key.as_ref()).unwrap();
            }
        }));
    }
    for handle in handles {
        handle.join().unwrap();
    }
}

+1 I stepped on this today using ebr = 0.2.11 while evaluating concurrent-map = 5.0.33 with default GC settings

Thank you for reporting this! After a lot of head scratching and incorrect assumptions that my ARM laptop would always be a harsher test environment than my dusty old x86_64 laptop, I realized a barrier actually needed to be stronger on x86_64 to have it not be ignored at compile time. Fixed in version 0.2.13! This was an interesting bug where x86_64 seems to need a stronger memory ordering than ARM, at least on the systems I tested it on. I feel like that means that the fence in the pin function should have always been Release for correctness, but it's the first time I've needed to make orderings stronger to get them to pass on x86_64 instead of ARM. On x86_64 non-SeqCst orderings are just treated as compiler fences though.


Cleaning modes are swapped with Xiaomi L10S pro

The cleaning modes are swapped.
Mode in Home Assistant addon   =>  mode in the Xiaomi App :

Sweeping => Sweeping & mopping (washing with suction)
Mopping => Sweeping (washing only)
Sweeping & mopping =>  sweeping (suction only)

Originally posted by @argonaute199 in https://github.com/Tasshack/dreame-vacuum/issues/63#issuecomment-1356782454

Ok. From the app, I changed:

From mopping to sweeping
sweeping to mopping & sweeping
Mopping & sweeping to mopping

home-assistant_2022-12-18T16-24-30.253Z.log
Let me know if you need something else.

Excellent !!! Thank you very much. I checked and it works.


E-Distance: Choice whether to square Euclidean Distance

Report
Hi,
a short note on the E-distance:
The documentation of pertpy.tools.Distance at the moment refers to the preprint of scPerturb, where the E-distance is nicely described.
In the preprint, the E-distance is described as "the squared euclidean distance when calculating cell-wise distances".
The sklearn.metrics.pairwise_distances used for the E-distance in pertpy computes the Euclidean distance (so "without squaring", or when considering the formulas on p.21 and p.22 in the preprint, technically adding a root in these formulas).
While not changing the order of distances, the lacking squaring of distances might be unexpected.
Apologies if I confused something here!
Version information
No response

Hi Eljas,
Thanks for the note! I changed the cell-wise distance for Edistance to squared euclidean now. I needed to change the way we handle stuff internally for this (me dreading to do this was the main reason it was "euclidean" until now, but I think it worked out fine).
I've pushed the changes to the implement_additional_distance_metrics branch for now (see https://github.com/theislab/pertpy/commit/c5c2be04c80ec5265e6ebcf19de82949ec1f50ce).
@Zethson are you taking care of pulling the changes to main or should I?

We can only merge the Distance branch as soon as all tests pass. We'll merge it later :)
Thank you!

On main now. Will make a release within the next 10 days.


Create test

Description

Issue reference

Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

/ok-to-test

/ok-to-test

Dapr E2E test
🔗 Link to Action run

/ok-to-test

Dapr E2E test
🔗 Link to Action run

/ok-to-test

Dapr E2E test
🔗 Link to Action run


Fix crash in image-context

I have observed frequent crashes of Exokit when the web app is dealing with ajax-loaded images.  The following example reproduces the crash fairly reliably (not always though; maybe try several times in case the crash does not manifest in one shot).
$ node . -h https://j-devel.github.io/pixels-to-mesh-test/index.html

Cause of the problem
In image-context.cc, the handle in uv_close() points to threadAsync of Image.  But this address &threadAsync is no longer valid after the Image instance is destroyed.  Depending on the situations, Image destruction occurs before the actual uv_close() operation is fulfilled, leading to unpredictable behaviors (mostly crashes with an assertion failure of uv__finish_close), e.g.
Assertion failed: (handle->flags & UV_HANDLE_CLOSING), function uv__finish_close, file ../deps/uv/src/unix/core.c, line 252.
Abort trap: 6

Fix
This PR is to allocate the async handle in heap and let uv_close() work properly without causing the crash.

Thanks, great catch!


modified installation.md on how to generate mdf documentations offline

i am opening another pull request for generating mdf documentation offline


STORM-2293 hostname should only refer node's 'storm.local.hostname' (1.0.x)

Please refer STORM-2293 for more details.

+1


fix #42

fix #42

@andrei-markeev

@andrei-markeev

Sorry for the delay, I was on summer vacation and then some other business. I'll look into this ASAP. Are you sure that the tests are passing?

Hi, I just checked and the tests are failing.
To run tests, use npm test. To skip valgrind (it typically works only on Linux), use npm run test-without-valgrind.

Which test failed?
Only printf(x) (1 argument) are replaced.

[zaoqi@zaoqi-pc zaoqi___ts2c___patch1___readonly]$ npm run test-without-valgrind
npm ERR! missing script: test-without-valgrind
npm ERR!
npm ERR! Did you mean this?
npm ERR!     test-no-valgrind

npm ERR!  Did you mean this?
npm ERR!     test-no-valgrind

yep, test-no-valgrind is the right one, sorry for confusion


chore: Ensure the same babel config is used across the project in a non conflicting way

Reason for change
In some cases the development of the frontend code could become conflicting with how we were referencing the babel configs in a few places. For simplicity and compatibility of all scenarios, I have removed the babel config from the web/package.json and moved it to the web/babel.config.json, and made the libraries use the root level config for babel instead of duplicating and using a .babelrc in each module.

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

This PR was closed because it has been stalled for 10 days with no activity.


Replace tape with node:test

Hmm requires dropping node14 from the test suite...

imo dropping node14 is perfectly fine. Supporting node LTS seems more than enough.


'Too many connections' Error thrown during testing with DatabaseTransactions trait.

Laravel Version: 5.4.23
PHP Version: 7.0.19
Database Driver & Version: MySql 5.6.36

Description:
Error "PDOException: SQLSTATE[08004] [1040] Too many connections" is being thrown while running a PHPUnit test suite that uses the DatabaseTransactions trait with the $connectionsToTransact variable defined.
Steps To Reproduce:
Create a PHPUnit test suite with the DatabaseTransactions trait that references multiple database connections within the $connectionsToTransact variable. Determine what your maximum connections variable is set to for your MySql instance then run enough tests to make sure you would exceed said number.
Pull Request
https://github.com/laravel/framework/pull/20340

Moving the discussion to the PR.


[Select] - When the Select is disabled the dropdown arrow is not greyed out

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

The dropdown arrow is not greyed out

Expected Behavior 🤔

As per the Material Design documentation, when a TextField or Select is disabled, everything should be greyed out, even Input Adornments:

Steps to Reproduce 🕹

https://codesandbox.io/s/gifted-brattain-og6xh
Context 🔦

Small design inconsistency.
Your Environment 🌎

Tech
Version

Material-UI
v4.9.4

React
16.12

Browser

TypeScript
3.7

etc.

There is a reference to it in https://material.io/design/interaction/states.html#disabled. From what I understand, we could use inheritance (opacity)

I'd like to try tackling this issue, but I wonder what is the best way to do it?
Is adding MuiSvgIcon-disabled class to the icon and applying .38 opacity as per the documentation enough?

@HenryLie What do you think of this patch?
diff --git a/packages/material-ui/src/NativeSelect/NativeSelect.js b/packages/material-ui/src/NativeSelect/NativeSelect.js
index e3049ebab..32f04c9c5 100644
--- a/packages/material-ui/src/NativeSelect/NativeSelect.js
+++ b/packages/material-ui/src/NativeSelect/NativeSelect.js
@@ -72,7 +72,8 @@ export const styles = (theme) => ({
     position: 'absolute',
     right: 0,
     top: 'calc(50% - 12px)', // Center vertically
-    color: theme.palette.action.active,
+    color: 'currentColor',
+    opacity: 0.8,
     pointerEvents: 'none', // Don't block pointer events on the select under the icon.
   },
   /* Styles applied to the icon component if the popup is open. */

@oliviertassinari
The approach with currentColor looks very clean and concise.
Personally, I am in favor of unifying this behavior into Autocomplete, since it results in one less class and  makes the code shorter overall.
I'll submit a PR that uses the currentColor approach on both Select and Autocomplete component.

@HenryLie Ok, this sounds fair 👍

@oliviertassinari
Sorry, I just noticed a drawback of applying this method on the Autocomplete.
In this component, the icon uses IconButton, and it already applies theme.palette.action.disabled color to the icon with a stronger specificity when disabled prop is passed into it.

Since we can't remove the disabled prop from the icon (since it'll make it clickable), applying the reduced opacity will make the icon have double reduced opacity. It's especially apparent in dark theme (not sure if it's visible in this screenshots)
Original style

Updated with currentColor

What do you think of doing it the other way around and use the second approach in your patch?

@fbarbare You would need to increase specificity too with the disabled pseudo-class.

I just submitted a PR to both fix the issue and unify the behavior with Autocomplete.
I'm not sure if the implementation is optimal, but I think discussing it in the PR will be better.


Support Notion as a content source

Add your vote for Notion support by clicking the 👍 emoji below.
Related:

https://jake.tl/projects/notion-api

Hey 👋
I love what contentlayer is aiming to do. As the author of https://github.com/NotionX/react-notion-x, I'm intimately familiar with Notion's content layer (both official and unofficial APIs).
I'd be happy to help with adding support for Notion as a content source, but would likely want to have a quick sync convo before getting started. @schickling feel free to DM me if you want to chat about this.
Either way, one of the most important decisions will be whether to use:

@notionhq/client - The official Notion API
notion-client - The unofficial Notion API
notion-compat - A compatibility layer between the two

At first glance, it may seem like using the official Notion API is an obvious choice, but it's still missing a lot of features, so it really depends on the use case.

Thanks so much for your nice message @transitive-bullshit! I'll most certainly get in touch once work on the Notion integration kicks off - would love to collaborate on this! 🙌

Isn't the Notion integration being worked on anymore?

I think the Notion integration would be brilliant. Finger's crossed it's still in the works 🤞

Hi, I started the development of the Notion implementation as it starts to be a requirement for me.
Here is the PR : https://github.com/contentlayerdev/contentlayer/pull/393

The Notion content source plugin has been released in Alpha. It is still in experimental and is subject to change.
If you want to give it a try, you can find the documentatino in the PR description #393
Feedback and bug reports are greatly appreciated!
And if you need help, I am available on the Official Contentlayer Discord


Add plugin support

Description
Like a phoenix, this PR supersedes #1370 and adds basic plugin support.

From https://github.com/containous/traefik/pull/1370#issuecomment-291903522:

We can't load an external plugin if Traefik is built with CGO_ENABLED=0, and we really need this to build a statically linked golang executable to run in a Docker container.
golang/go#19569 and there are no plan on this golang/go#19569 (comment)

We will enable CGO for the Alpine based image. We then need to compile the binary in an Alpine based image with musl.

If you compile traefik binary on your laptop, and a plugin in docker on your laptop, it does not work either: Error loading plugin: error opening plugin: plugin.Open: plugin was built with a different version of package github.com/containous/traefik/plugin

At each release, we will also now publish the Docker image used to compile Traefik binary (build.Dockerfile). This image will be needed to compile each plugin.

The integration tests can't use a CGO Alpine based binary, therefore I need to generate a CGO binary during integration tests. The tests are a bit slow (1m) due to this compile. There may be a better solution.
We need to generate 1 statically linked binary (as usual) and 1 CGO Alpine based binary. Scripts need to be updated.

Any comment/suggestion is welcome :)
Fixes #1336
Fixes #1048
Part of #30

I'd like to try a proof of concept of re-creating the API Gateway from FaaS but as a Traefik plugin. https://github.com/alexellis/faas
The core functions are:

UI for invoking functions
Deploying / Listing / Removing functions (Docker services)
Proxying via a routing pattern to containers that conform to a label
Monitoring usage metrics through Prometheus and altering replica count

Does that fit within your proposed change @emilevauge for a plugin?

This is some excellent stuff. Can't wait to put it in production. :+1:

This is an interesting approach to doing plugins in Go - https://github.com/hashicorp/go-plugin
Would this be something of interest to consider to use for Traefik?

@alexellis sorry for the lag (holidays, you know ;) ).
I think it may be simpler to discuss on Slack. Could you join our Traefik channel ?

When this is expected to hit production?

Aside from resolving merge conflicts and semaphoreci what else needs to happen to get this useful feature merged?

Any progress here? The ability to extend Traefik is a must for my projects. Currently, I'm forced to use Nginx, since it allows to use Lua to extend its functionality.

@emilevauge you're welcome to join our community, I can extend an invite.. you have lots of fans there already.

Curious has this been abandoned?

FYI, this feature is not abandoned, but we are still not satisfied with the current official Go plugins situation.
Other options are being tested (#1865).
More on this soon :)


Update Chapter 5 of the guide to cover building the jar file

The Java tasks should be included in the list of tasks.

I think PR #49 covers this.


Is there any possibility to pass --angular_pass flag to ant CompileTask?

Hi,
I've been using ant task with closure compiler v20131014 and would like to pass additional flags to it. Is there any way to do so?

You're welcome ;)
https://github.com/google/closure-compiler/commit/4129ace5c79deb04f69942c930e4b4d1cd72bd7b#diff-20ea98e4dc915331f2c604b197321610

Oh cool :)


[WIP] Checking occassional CI utxo failure

#
Overview

This is for the sake of finding CI failure and understand it.
DO NOT MERGE
DO NOT REVIEW
Comments

This was only to make sure ocassional CI failure is not recurring


Use TypeToken.getParameterized for all parameterized fields

This eliminates the remaining reflection when creating TypeAdapters.
In a test app on a Galaxy J1, it reduces the time taken to initialize 10 TypeAdapters for classes each containing 10 List<String> fields from 750 - 800ms to ~30ms
I also enabled custom field adapter support for parameterized generic fields. Not sure it's useful, but it simplified the code.

Hm, looks like this doesn't work with proguard nicely:
Warning: com.yandex.mail.react.entity.$AutoValue_Fields$GsonTypeAdapter: can't find referenced method 'com.google.gson.reflect.TypeToken getParameterized(java.lang.reflect.Type,java.lang.reflect.Type[])' in program class com.google.gson.reflect.TypeToken

upd: not an auto-value-gson problem but rather gson: TypeToken.getParameterized(List.class, Recipient.class) was added in gson 2.8.0

upd2: my bad, forgot to update explicit gson dependency to 2.8.


Fix zero value metric

What is this PR?
This is a:

[ ] documentation update
[x] bug fix with no breaking changes
[ ] new functionality
[ ] a breaking change

All pull requests from community contributors should target the main branch (default).
Description & motivation
Closes #61
This initial approach parses expression metrics, checks for a / and wraps any divisors in the expression in the appropriate nullif( {{ dvisor }} , 0) expression. This approach solves the current issue:

Sample Metrics
version: 2

metrics:

  - name: total_value
    label: Total Value
    model: ref("incremental")
    type: sum
    sql: val

    dimensions:
      - state
      - customer_id

    filters:
      - field: state
        operator: '!='
        value: "'connecticut'"

    timestamp: report_date
    time_grains: [day, week, month]

  - name: non_division_exp
    label: Expression ($)
    timestamp: order_date
    time_grains: [day, week, month]
    type: expression
    sql: "{{metric('total_value')}} + 1"
    dimensions:
      - state
      - customer_id

  - name: division_exp_1
    label: Expression ($)
    timestamp: order_date
    time_grains: [day, week, month]
    type: expression
    sql: "1 /{{metric('total_value')}}"
    dimensions:
      - state
      - customer_id

  - name: division_exp_2
    label: Expression ($)
    timestamp: order_date
    time_grains: [day, week, month]
    type: expression
    sql: "1 / {{metric('total_value') }} / 2"
    dimensions:
      - state
      - customer_id

  - name: division_exp_3
    label: Expression ($)
    timestamp: order_date
    time_grains: [day, week, month]
    type: expression
    sql: "{{metric('division_exp_1') }} / 2"
    dimensions:
      - state
      - customer_id

Compiled SQL
...
, first_join_metrics as (

    select
        date_week
        , coalesce(
            total_value__final.state
            , NULL
        ) as state
        , coalesce(
            total_value__final.customer_id
            , NULL
        ) as customer_id

        , total_value as total_value

    from
        total_value__final
    )

, join_metrics__998 as (

    select

        first_join_metrics.*
        , (1  / nullif(total_value, 0)) as division_exp_1

    from first_join_metrics

)

, join_metrics__999 as (

    select

        join_metrics__998.*
        , (total_value + 1) as non_division_exp
        , (1  / nullif( total_value , 0) / nullif( 2, 0)) as division_exp_2
        , (division_exp_1  / nullif( 2, 0)) as division_exp_3

    from join_metrics__998

)

, joined_metrics as (

    select
        first_join_metrics.date_week
        , first_join_metrics.state
        , first_join_metrics.customer_id
        , coalesce(first_join_metrics.total_value,0) as total_value
        , coalesce(non_division_exp, 0) as non_division_exp
        , coalesce(division_exp_1, 0) as division_exp_1
        , coalesce(division_exp_2, 0) as division_exp_2
        , coalesce(division_exp_3, 0) as division_exp_3

...

Results:

My open question here is that this treats observed 0 value results (true zeros from my data) the same way as the filled-in 0s from our spining behavior. Is it appropriate to assume that any zero in the source metric should be evaluated by the corresponding expression metric?
Checklist

[X] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)

[ ] BigQuery
[X] Postgres
[ ] Redshift
[ ] Snowflake

[ ] I have updated the README.md (if applicable)
[X] I have added tests & descriptions to my models (and macros if applicable)
[ ] I have added an entry to CHANGELOG.md

Tenets to keep in mind

A metric value should be consistent everywhere that it is referenced
We prefer generalized metrics with many dimensions over specific metrics with few dimensions
It should be easier to use dbt’s metrics than it is to avoid them
Organization and discoverability are as important as precision
One-off models built to power metrics are an anti-pattern

My open question here is that this treats observed 0 value results (true zeros from my data) the same way as the filled-in 0s from our spining behavior. Is it appropriate to assume that any zero in the source metric should be evaluated by the corresponding expression metric?

I think this is the most important thing for us to clarify on this issue.
Areas of Concern

Expression Metrics: if the expression uses division at all then having 0 values can produce failing metrics
Secondary Calculations: without 0 values in previous periods, we are unable to calculate many secondary calculations

What would happen if we completely abandoned the 0 coalesce and used null instead?
Relevant slack thread: https://getdbt.slack.com/archives/C02CCBBBR1D/p1660673393965409

@dave-connors-3 crazy idea - what if we push this out into the metric definition itself? Have some sort of parameter in a config block that determines whether nulls are treated as 0's or as NULLS.
This might be the way to keep metric definition flexible while keeping results consistent.

@callum-mcdata -- here's the current state -- want to call out the way that metric configs are being handled in get_metric_sql:
current state

they are added to the metrics_dictionary  via the get_metrics_dictionary macro, as this was the only place that the metric yml itself gets parsed in the Jinja context (this actually takes place in develop and calculate and the dict is passed to get_metric_sql
they are then moved to a separate metric_config_dict, which gets passed to both build_metric_sql and gen_secondary_calculation_cte. These macros then unpack the configs at the appropriate time to add or remove coalescing as necessary.

Considerations

I chose to do this so that the set of configs gets passed in a consistent way -- depending on the universe of configs we allow users to supply in the future, stands to reason that we have a consistent way of passing them to each macro
That being said, the unpacking and repassing behavior seems a little redundant -- I was hesitant to pass the entire metric dictionary (with all the core attributes) to every place we might need configs, but I also recognize that the unpacking and repackaging of the configs from the metric_dictionary is a bit redundant

@joellabes -- would love your eyes on this too!

@callum-mcdata @joellabes I believe I have addressed the comments here w.r.t. naming, passing the args the appropriate way, and validating configs (that last piece open to feedback!)
last things we need here are:

consensus on the name
consensus on the logic (callum just added a great callout -- depends on a lot of assumptions on how division will be written)

once we get there, this should be close!

Have added my vote for name on that comment (treat_null_values_as_zero).
Consensus on the logic: I've made https://github.com/dbt-labs/dbt-core/issues/5918 to see what the appetite is for turning this into structured data. Otherwise we just wait for it to become a problem.

@dave-connors-3 you've done the herculean work here -all yours to hit the big green button.

Love your work, you two!


Create local news list component

Related to #143
We need a basic news list component for the local news.
Link to design in Figma: https://www.figma.com/file/F2OnKFEoMwFaANMgeGRGqE/CMS?node-id=4802%3A82891
Acceptance criteria

[ ] Local news article is readable on the web
[ ] Can add a new "news list" component to a topic page
[ ] Can select a local news tag to display local news in the "news list" component, this should be a mandatory field
[ ] News list component renders a list of local news on the web
[ ] News list component matches design

Handling of large amount of articles via pagination to be handled in separate issue #942

The component is very straightforward in Sanity, simply select any number of topic, country, and/or local news tags and it will use those tags to generate a list of news

This is reusing the "news promotion" schema - have reached out to Sanity asking how we can customize the component description for different use cases (note the "Feed in the latest 3 news that satisfies the tags" from the news promotion). Editors can also add an optional title which will be displayed above the list if they wish.
In the web it reuses the news cards - so this is basically just a news promotion without the 3 article limit; instead this currently just loads all news articles that match the tags (we will later limit this by introducing a "load more" button, see #942)

@wenche @BirteThornquist This is ready to be looked at.
The web part doesn't 100% match the design; in Figma the cards lack the ingress, but it's still being shown here now.
If we want we could modify it to hide the ingress (and/or any other fields on the cards) but I didn't want to complicate things further.

Been testing a bit
English: https://web-global-development-energyvision-dev.radix.equinor.com/about-us/the-netherlands
Norwegian: https://web-global-development-energyvision-dev.radix.equinor.com/no/om-oss/nederland

@SvSven to update padding according to suggestion from Birte

Have updated the padding to match that of the promotion component, and added a warning/description text to the component inside Sanity:

@BirteThornquist done ✅

@SvSven if you add a space after the icon before the text it will be perfect! (sorry for being picky) 😄

Have added some breathing space between the emoji and the text 👍

@meols I believe you and the rest of the editors have already looked at this, correct?

Yes @SvSven - that's right :thumbsup: There has been some issues with preview, but Tor (our news guy) has tested and confirmed today that it works at it should. Closing this one then :smile:


trying to read build properties.

This is only for sharing, not for merging.

@nianma, I would suggest adding two integration test methods:

In fcrepo-kernel-modeshape::FedoraResourceImplIT that checks that the release triples are all set to unknown
In fcrepo-webapp::SanityCheckIT that checks that the release triples are all NOT set to unknown.

It seems this was never meant to be merged and is marked wont fix. Closing


Twitter::Client#blank? conflicts with rails #blank? and #present?

Twitter::Client#blank? conflicts with the usage of rails #blank? and #present?.
It should be renamed to something else that's ambiguous and not used in rails.

What’s the actual issue here? This is a private method, so it shouldn’t conflict.

I wish I explained this better at the time of opening. I can't seem to remember what it conflicted with exactly, but I'm 100% positive that it somehow had a negative impact to the usability of this gem (otherwise I wouldn't have opened it).


chore: Emit lib/ to out/ with TypeScript

This updates our tsconfig.json so it emits our JavaScript files as
well as type checking them. We compile into ./out which we then ship
in our npm package.
Because the lib/ directory is exclusively JS files, this change is a
no-op in terms of code functionality but is the first step towards being
able to replace lib/X.js with lib/X.ts in a way that allows us to
migrate incrementally.
The out directory is gitignored, and the lib directory is
npmignored. On npm publish we will now run npm run tsc in order to
generate the outputted code.
Any imports that import from lib/X now import from out/X.
BREAKING CHANGE: if users are importing Puppeteer modules, e.g.:
const PuppeteerWorker = require('puppeteer/lib/Worker');

This path has now changed to:
const PuppeteerWorker = require('puppeteer/out/Worker');

@mathiasbynens @TimvdLippe would love your thoughts on this please.
The goal here is to have TypeScript not only type-check but emit our JavaScript, in preparation for us to start replacing files with *.ts ones.
This PR is more a starting point & one solution that works rather than definitely the best one - I think there's a few ways we could do this and I'm happy to chat about it. Can always jump on a call :)

CI is failing for a legitimate reason: node install.js needs out/helper.js, but that can't exist until TypeScript has run.
However for TypeScript to run it needs protocol.d.ts, which is installed by node install.js. So I think we need to either:

Update the install script to not depend on out/helper
Update the install script to depend on lib/helper.js (works until we want to TypeScriptify that file)
Update the install script to grab protocol.d.ts, then run TypeScript, then run the install script. This seems wasteful given this runs every time anyone installs the package from npm.

GitHub search is not really working for me, but this search seemed the most sane: https://github.com/search?q="puppeteer%2Flib"&type=Code That search isn't immediately showing any actual usage of direct files in puppeteer.

We can prevent the breaking change in this case, so let's do it. I like Tim's suggestion of moving lib to src and then having lib be the generated output. I also appreciate you sending this smaller patch first, so that it's easier to review the actual changes 👍

Great thinking - I'll update this PR to move lib/X into src/X and generate into lib.


keep all the image contained in fixed size

images are being uploaded in different sizes, which making the view shattered
keep the image area fixed, no matter the size the image should in a fixed barrier

Sounds like a good idea, could you give us a PR?

It looks better now


The captcha was not solving

Found captcha, solving...
panic: api2captcha: API error

Nevermind, it's because i should buy it

where should i put my api key ?

where should i put my api key ?

.env

API_KEY=key

Thanks i just find it
But the error seems the same

Make sure the key is good, happened to me

Yeah but it seems good

Could be that ?

This is the reddit recaptcha info, you shouldn't touch that

Ok i understand

The error is here

Ok i found why, it's because i forgot to rebuild the project


Add a trailing slash at the end of the URL

I was not eager to click the link because I thought it was going to download a .js file to my machine. The trailing slash makes it clear that it's only the name of the route

Fair enough, thx


Research OWASP scanning of React UI

Determine ability to use OWASP ZAP scan to scan EASEY UI

Potential problem because React is a single page web app

Mike to email NCC to determine security scanning requirements for React web apps

OWASP scan is running on base apps. This ticket is no longer needed.


az role assignment create - how do I add more than 1 role at a time?

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Related command

Describe the bug

It isn't clear how to add more than 1 role assignment at a time. Is it multiple calls to this command or can the value be an array or a string in a single call?
To Reproduce

Expected behavior

Environment summary

Additional context

@jiasli for awareness

@diberry Except the scope all other parameter are single values. Only scope is comma separated array. Therefore you will have to make multiple calls to this commands to create multiple roles.


can build Mako

Mako Server is available on GitHub so this tutorial on building C with nix should work for Mako as well
develops #7

dont forget the container later:
nixosConfigurations.container = nixpkgs.lib.nixosSystem {
      system = "x86_64-linux";
      modules =
        [ ({ pkgs, ... }: {
            boot.isContainer = true;

            # Let 'nixos-version --json' know about the Git revision
            # of this flake.
            system.configurationRevision = nixpkgs.lib.mkIf (self ? rev) self.rev;

            # Network configuration.
            networking.useDHCP = false;
            networking.firewall.allowedTCPPorts = [ 80 ];

            # Enable a web server.
            services.httpd = {
              enable = true;
              adminAddr =<EMAIL_ADDRESS>            };
          })
        ];
    };

I ran git mv flake.nix oldflake.nix, this caused this error.
https://discourse.nixos.org/t/nix-flakes-nix-store-source-no-such-file-or-directory/17836/11
git add flake.nix fixed the issue

[nix-shell:~/workshop/homestead]$ nix-prefetch-github nzinfo MakoServer
{
    "owner": "nzinfo",
    "repo": "MakoServer",
    "rev": "3158b48586e7dcdfe29777181c5274328d96921a",
    "sha256": "SuRn81V4rEHTe/FZzoMfylrEiqgRkbIaYrohWMNR+3Q=",
    "fetchSubmodules": false,
    "leaveDotGit": false,
    "deepClone": false
}

nix run shows the same thing.
How do I test mako then?

17:00 $ nix log /nix/store/5k3cadz3lav5j4bri1czr5za41gzzglp-mako-3158b48586e7dcdfe29777181c5274328d96921a.drv
warning: The interpretation of store paths arguments ending in `.drv` recently changed. If this command is now failing try again with '/nix/store/5k3cadz3lav5j4bri1czr5za41gzzglp-mako-3158b48586e7dcdfe29777181c5274328d96921a.drv^*'
@nix { "action": "setPhase", "phase": "unpackPhase" }
Running phase: unpackPhase
unpacking source archive /nix/store/8y43xfpqqaqpr39yr5lflwwzj5abd2ic-MakoServer-3158b48
source root is MakoServer-3158b48
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: configurePhase
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACK>
CMake Warning:
  Ignoring extra path from command line:

   ".."

CMake Error: The source directory "/build/MakoServer-3158b48" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.

You should do mkdir build and cd build while inside opencv folder, not the opencv-contrib folder. The CMakeLists.txt is there.
https://stackoverflow.com/questions/46448682/cmake-error-the-source-does-not-appear-to-contain-cmakelists-txt

https://github.com/aleeusgr/homestead/blob/build-mako/flake.nix#L34

Look at the guide in the section Package.

[ ] https://github.com/samdroid-apps/nix-articles/blob/master/04-proper-mkderivation.md


Support specyfing index page as /

Thank you for this library. It's really lifesaving. But there's a thing which might be improved. I expected that I can use the same path for @Get and @Render decorators. But when I tried to render an index page this way @Render('/') I've got an error Error: Requested and resolved page mismatch: // /.
If I had a way to use the same paths, I would combine them in one @Page decorator. It would allow me to not repeat myself every time I want to render a page. The only thing required for that is to normalize given path to collapse double slashes.

@frux hey thank you for your contribution. I just wanted to let you know I merged your changes in and released a new version to npm.
Also as a side note, @Get and @Render don't exactly accept the same arguments. The value passed to @Get is the route's path, but the value passed to @Render is the name of the template.


Update Signal Deprecation FAQ

Purpose of this pull request
Since we now include the field{} blob, the FAQ needed to be updated appropriately.
Select the type of change:

[ ] Minor Changes - Typos, formatting, slight revisions, .clabot
[x] Update Content - Revisions, updating sections
[ ] New Content - New features, sections, pages, tutorials
[ ] Site and Tools - Updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

@pkazmir-sumo, I also updated some wording to remove "will", so that after the deprecation date, the language is still relevant. See commit Update language to future-proof.


a11y: accessibility 2027

Description
the focus will go to left Navigate pane first now.
Task Item
Refs #2027
Screenshots

@corinagum In #2027 Note part. "Same issue observed with the '+' i.e. add node available at the flow chart" will wait for @alanlong9278  to fix. He is refactoring that part of code. We can probably open an new issue for it and merge this pr.


Expectation value re-design

Related to #6451
Summary
Taking expectation values for opflow operators on a backend/simulator currently looks like
# define the expectation value
state = StateFn(...) # can be a circuit-based state or defined via a statevector or dictionary
operator = # some opflow operator, e.g. PauliSumOp
expectation = StateFn(operator, is_measurement=True) @ state

# define how to evaluate
expectation_converter = # method to evaluate the expected value, e.g. PauliExpectation, CVaRExpectation, AerPauliExpectation, ...
circuit_sampler = CircuitSampler(backend)  # backend or simulator to execute the circuits

# constructs opflow objects needed to evaluate the expectation value
# e.g. creates circuits to measure in different Pauli bases
converted = expectation_converter.convert(expectation)

# evaluate the circuits (optionally with parameters, if the state had free parameters so far)
sampled = circuit_sampler.convert(converted, parameters)

# get final result
result = sampled.eval()

This workflow requires users to know about several classes before being able to calculate expectation values and constructs and copies potentially heavy opflow objects multiple times. We'd like to create a new expectation value class to (1) simplify and speed up the current flow and (2) create one universal interface for Qiskit (instead of having a quantum-info way and opflow way of doing it).
This must be (and currently is) synced with the development of expectation values in Qiskit Experiments.
On the high level, we'd like to calculate circuit-based expectation values as (this is just a sketch, naming etc. is not fixed)
exp_val = ExpectationValue(operator, circuit, backend)  # ExpectationValue could be a subtype, like PauliExpectationValue
result = exp_val.compute(parameters)  # parameters are only included if the circuit is parameterized

This would easily allow to cache transpiled circuits, it's easy to use and variational algorithms can easily be implemented.

So in the model above, is ExpectationValue tasked with forming the correct circuits for the operator, i.e. appending the needed basis transform gates?  Also, do we really need a class here that one can pass parameters to, i.e why can't ExpectationValue just be a call to run the circuits on the specified backend after binding parameters that returns the results?


Find and Replace need to work in any folder

Should be able to specify folder instead of CDing to folder

https://github.com/blue-jay/jay/commit/8859c28d8a4e271cff4512913d929c3f134c2e0c


{Eventhub/Servicebus} az servicebus namespace list az eventhubs namespace list: Added servicebus/eventhubs namespace list command with & without resource-group parameter

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Eventhub/Servicebus

/azp run Azure.azure-cli Breaking Change Test

If there are several changes, please update the history notes section in PR description instead of putting them all in PR title


How to configure storage retention in TIKV

Question

I use TIKV as prometheus remote db. I want configure storage retention in TIKV, but no find any configuration.

Sorry, could you describe your requirements more concretely?


Small refactor for cloud checksum tagging

depends on #64

Codecov Report

Merging #65 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   87.37%   87.42%   +0.05%
==========================================
  Files          10       10
  Lines         491      493       +2
==========================================
+ Hits          429      431       +2
  Misses         62       62

Impacted Files
Coverage Δ

ssds/blobstore/__init__.py
70.21% <100.00%> (+2.03%)
:arrow_up:

ssds/blobstore/gs.py
97.80% <100.00%> (ø)

ssds/blobstore/s3.py
98.57% <100.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3876ddb...f7324f1. Read the comment docs.


Widget Self Referencing

Hi team,
I have tried to find the answer elsewhere but couldn't
I was wondering if there is a way to self reference a widget. I am trying to make a form where onCancel would hide itself.
The form is hidden by default until a button is pressed but if the form is canceled I would like to hide the form again.
deviceForm := &widget.Form{
		Items: []*widget.FormItem{
			{Text: "Name", Widget: name},
			{Text: "URL", Widget: url},
		},
		OnSubmit: func() {
			log.Println("device:", name.Text)
			log.Println("url:", url.Text)
		},
		OnCancel: func() {
			HIDE deviceForm <<<<<<<<<<<<<<<<-----**How can I accomplish this? It cannot reference itself**
			//fmt.Println("Hide the form")
		},
		SubmitText: "Add Device",
		CancelText: "Cancel",

	}
	deviceForm.Hide()

Thanks for any guidance

This is the wrong repository. I suppose you meant to open in fyne-io/fyne.
FYI: We also want questions to use discussions, not issues.


Repurpose link field in /settings/periods for room numbers

This would make PeriodObj something like
{n: string, c: string, l: string, o: string, s: string, r: string}

with l being deprecated and unused. Instead of rendering links, we would render a room number next to the period name in the same style as how we currently handle grade numbers. Unsure if these are fetchable via schoology, but if not manual is always fine as well.

PR #118 should do this, although it doesn't display room numbers in exactly the same way that grade numbers are displayed. (example attached)


[Coverity CID :190626]Null pointer dereferences in /subsys/net/lib/coap/coap_sock.c

Static code scan issues seen in File: /subsys/net/lib/coap/coap_sock.c
Category: Null pointer dereferences
Function: coap_packet_parse
Component: Networking
CID: 190626
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

False positive.