YARN-10355. Refactor NM ContainerLaunch.java#orderEnvByDependencies

NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 17s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m  6s

trunk passed

+1 :green_heart:
compile
21m 14s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
18m 18s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 46s

trunk passed

+1 :green_heart:
mvnsite
1m 43s

trunk passed

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 42s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
14m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
20m 29s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
20m 29s

the patch passed

+1 :green_heart:
compile
18m 26s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
18m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 47s

the patch passed

+1 :green_heart:
mvnsite
1m 40s

the patch passed

+1 :green_heart:
xml
0m  3s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 39s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
15m 13s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 37s

hadoop-project in the patch passed.

+1 :green_heart:
unit
23m 16s

hadoop-yarn-server-nodemanager in the patch passed.

-1 :x:
asflicense
0m 59s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

193m 44s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3220

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux f7fd94d7fb65 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fc5bf7cab270c39d4a5361f045633e71417c3dcf

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/1/testReport/

Max. process+thread count
548 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
11m 33s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 30s

trunk passed

+1 :green_heart:
compile
25m 15s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 42s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 50s

trunk passed

+1 :green_heart:
mvnsite
1m 42s

trunk passed

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 43s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
15m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
20m 26s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
20m 26s

the patch passed

+1 :green_heart:
compile
18m 17s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
18m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 45s

the patch passed

+1 :green_heart:
mvnsite
1m 39s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 39s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
15m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 36s

hadoop-project in the patch passed.

+1 :green_heart:
unit
23m  2s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

200m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3220

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux 530612d41682 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3665093b49a51999400214f566a4bc31e1d66530

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/2/testReport/

Max. process+thread count
677 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
11m 17s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m  0s

trunk passed

+1 :green_heart:
compile
21m 19s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
19m 54s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 39s

trunk passed

+1 :green_heart:
mvnsite
1m 37s

trunk passed

+1 :green_heart:
javadoc
1m 18s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 33s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
15m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 53s

the patch passed

+1 :green_heart:
compile
23m 21s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
23m 21s

the patch passed

+1 :green_heart:
compile
19m 13s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m 13s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 42s

the patch passed

+1 :green_heart:
mvnsite
1m 38s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 16s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 36s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
15m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 30s

hadoop-project in the patch passed.

+1 :green_heart:
unit
23m 30s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

195m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3220

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux 69da8b8d779b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 279c7b6626661966da74f56637828042a93a7d99

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/3/testReport/

Max. process+thread count
548 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 39s

Maven dependency ordering for branch

-1 :x:
mvninstall
21m 10s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
22m 16s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
20m 30s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 56s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 34s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
15m 25s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
21m 40s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
21m 40s

the patch passed

+1 :green_heart:
compile
19m  4s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
19m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
3m 46s

the patch passed

+1 :green_heart:
mvnsite
1m 35s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 38s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
15m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 38s

hadoop-project in the patch passed.

+1 :green_heart:
unit
23m  5s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

198m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3220

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux e0c847600b31 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7b6cd12400cbb2bc8cf13dc126e2bb3e65693093

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/4/testReport/

Max. process+thread count
545 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m  1s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m  4s

trunk passed

+1 :green_heart:
compile
30m 48s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
25m 24s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
5m 24s

trunk passed

+1 :green_heart:
mvnsite
2m  3s

trunk passed

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 50s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
22m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m  2s

the patch passed

+1 :green_heart:
compile
29m 35s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
29m 35s

the patch passed

+1 :green_heart:
compile
25m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
25m 28s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
4m 37s
/results-checkstyle-root.txt
root: The patch generated 2 new + 140 unchanged - 0 fixed = 142 total (was 140)

+1 :green_heart:
mvnsite
1m 39s

the patch passed

+1 :green_heart:
xml
0m  3s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 33s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
21m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 31s

hadoop-project in the patch passed.

+1 :green_heart:
unit
25m 15s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

254m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3220

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux 46422e5023a0 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d7410b0833ae45581c6a4cc8f61c87c778d423a0

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/5/testReport/

Max. process+thread count
525 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tomicooler Thanks for the update! No additional comments on my side, +1 non-binding.

Thanks for the updates, +1 from my side as well.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 35s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m  8s

trunk passed

+1 :green_heart:
compile
24m  2s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
20m 38s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
3m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m 20s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 17s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 34s

branch/hadoop-project no spotbugs output file (spotbugsXml.xml)

+1 :green_heart:
shadedclient
19m 27s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
27m 34s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
27m 34s

the patch passed

+1 :green_heart:
compile
23m 48s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
23m 48s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 15s

the patch passed

+1 :green_heart:
mvnsite
1m 29s

the patch passed

+1 :green_heart:
xml
0m  2s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 16s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+0 :ok:
spotbugs
0m 28s

hadoop-project has no data from spotbugs

+1 :green_heart:
shadedclient
20m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
0m 29s

hadoop-project in the patch passed.

+1 :green_heart:
unit
24m 32s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

223m  8s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3220

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle

uname
Linux 00e7d0292931 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8251f55ee2b5150dab9fc59709996908ceaeb37c

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/6/testReport/

Max. process+thread count
574 (vs. ulimit of 5500)

modules
C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Force pushed the branch.

Created a separate Jira for the unit test refactor (YARN-10874).
Extracting the variable names from the bash version is not feasible with regexp, so that change is abandoned.

NOTE: the new regex batch variable name extraction works for the %:% variable, it will extract the : as the name. The original code did not find the : character to be a variable name. (https://stackoverflow.com/questions/37973141/colon-in-batch-variable-name/37992843). Since the test refactor is moved to separate pull request, I will add an extra test case with %:% to this patch if the other pull request is merged before this change.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 57s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 26s

trunk passed

+1 :green_heart:
compile
1m 35s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 34s

trunk passed

+1 :green_heart:
mvnsite
0m 48s

trunk passed

+1 :green_heart:
javadoc
0m 41s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 27s

trunk passed

+1 :green_heart:
shadedclient
14m 34s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 39s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 24s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 2 new + 35 unchanged - 0 fixed = 37 total (was 35)

+1 :green_heart:
mvnsite
0m 39s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 29s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 28s

the patch passed

+1 :green_heart:
shadedclient
14m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
23m  1s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

111m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3220

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 726052fe5100 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f7a369f7e97a2435026d26769ce87a80d84c1b2c

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/7/testReport/

Max. process+thread count
676 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tomicooler checked the latest state, other than the two small checkstyle issues +1 from my side.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
8m 47s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
2m 10s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
javadoc
0m 36s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 19s

trunk passed

+1 :green_heart:
shadedclient
14m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 25s

the patch passed

+1 :green_heart:
mvnsite
0m 38s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 24s

the patch passed

+1 :green_heart:
shadedclient
14m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
23m  3s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

76m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3220

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux e5746909aee5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 822f72ca16f846f2bdfe4c07f31c03880ea86e93

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/8/testReport/

Max. process+thread count
692 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @tomicooler for working on this.
Nice patch, LGTM +1.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 41s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 48s

trunk passed

+1 :green_heart:
javadoc
0m 40s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 37s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 23s

trunk passed

+1 :green_heart:
shadedclient
14m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 25s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 24s

the patch passed

+1 :green_heart:
shadedclient
14m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
23m  0s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

97m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3220

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 972945f10ef6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d8334704611b30af3400e8978a3c0506dec46c3c

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/9/testReport/

Max. process+thread count
546 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3220/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tomicooler thak you for the patch, LGTM+1.


CentIER_final_results folder is empty

my commond is :
~/biosoftware/CentIER/centIER.py my_genome.fa
the log file don't have any error or warring message, but the CentIER_final_results is empty

The screenshot area is too small for me to see the size of the intermediate file. Please enlarge the screenshot area.
At 2024-08-26 15:05:23, "kevin" @.***> wrote:
my commond is :
~/biosoftware/CentIER/centIER.py my_genome.fa
the log file don't have any error or warring message, but the CentIER_final_results
jietu.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

ok, i rerun the commond

nohup.out.txt

Based on your program's running log, it appears that it hasn't fully completed its execution. I'm speculating that the version of CentIER you're using might not be the latest one. The latest version would typically display a corresponding message after the program finishes running, stating 'CentIER running finished!*********'. The operating environment of your computer system has already met the requirements, and the usage of CentIER is very straightforward. Therefore, I recommend you try using the latest version again. If you encounter any issues, please feel free to contact me at any time.
At 2024-08-26 18:40:55, "kevin" @.***> wrote:
ok, i rerun the commond
jietu2.png (view on web)
nohup.out.txt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


🐞 Config File Not Found

Description
I am running MasterCSS in a Nuxt v3.13.2 (compatibility v4) project, and it seems not recognize the css file in the root directory. As a result I cannot extend MasterCSS with my own variables.

Reproduction
No response
System Informations
No response

Okay. I was able to solve it by moving the file from the root folder into the app folder.


Raise supported minimum java version

Currently JRE 7 is the minimum version to run OSIAM, but I think we should raise it to JRE 8 to make it possible to use Java 8 features... and Java 7 is EOL since may 2015.

I do like it. Unfortunately, not every OS already ships with Java 8, but I think this is only true for Debian. Any other OS should have Java 8 these days. Seems not that hard to unofficially install Java 8 on wheezy or jessie. So, yeah, let's go for it!

Should we schedule this for 3.0 too?

Let's schedule it for 3.0

Already did :-)

Do we have a schedule for what we want to go into release 3.0 anywhere?

We have the appropriate milestones in some repos, but not all issues and PRs have been assigned.

In the past the schedule for new releases read like this: All things that will be committed after the last release :)

But seriously, there is the Jira, that roughly contains what will be released. It mostly doesn't contain bug fixes or unplanned changes, like when we resolve stuff from GitHub.

I suggest that we start an issue in this repository outlining the major changes that we want to have in the next release. We can also turn the list of the milestones or jira tasks into separate issues to track progress there.

Alright, good idea. Are you doing this?

Ok, I would do it. Although I'm now wondering if an issue is the right way to track that. Because we could never close it and would always keep it open. Maybe a Markdown file in this repository or wiki page is more adequate?
Any opinions?

I suggest we make use of GitHub's milestones feature.

Ok, I think we can close that issue. If I recall it correctly , we agreed on raising the minimal required Java version to 8 in the server components and keep the client on 7.

I think, as long as we did not change anything this issue must be kept open. I suggest, that we use this issue as meta issue to track the progress in the individual projects.


No service worker on Chrome OS

The environment is the same as described in #259, but at the latest commit (9c85618aff8c487406db6868e16c56930c3c64dc) and node v11.1.0.

Is this on squoosh.app or are you on the dev server with a insecure origin?


Browse View Enhancements

With the enqueued view enhancements rework came the system for displaying cover art for lazily loading cover art into a list view which I have extended to the "Browse" hmiState to enhance the presentation. The following features/fixes have been added:

Added the cover art for each of the browse items which are lazily loaded into the browse pages. If there is no cover art for the browse item then the song/folder icon will be displayed in its place
Added a line to the browse items that displays additional information about the browse item if there is one present
The back functionality will now be able to be used for when there are greater than 2 levels of pages (prior behavior would go back to the PlaybackView when the user tried to go back from a page that was greater than 2 levels, for example if the user went to "Your Library" -> "Playlists" and then back out of the "Playlists" browse page)
Android app has been updated to show the cover art images where applicable otherwise falling back on the song/folder icon

BrowseView in action  (gif compression and frame rate are terrible to make it into a size that is attachable on github):

PhoneUI in action:

Also this PR should address this issue: https://github.com/hufman/AndroidAutoIdrive/issues/109

Would you be able to rewrite the commit history to have a single commit per change? I think there would just be the two if I'm reading it right:

Fixes nested browsing pages
Implements browse coverart for #109

Thank you for this excellent work! I'm happy that the SpotifyMusicMetadata object worked out so easily!

Would you be able to rewrite the commit history to have a single commit per change? I think there would just be the two if I'm reading it right:
* Fixes nested browsing pages

* Implements browse coverart for #109

Thank you for this excellent work! I'm happy that the SpotifyMusicMetadata object worked out so easily!

Rebased and squashed down to 2 commits, usually I wait to do the squashing until the end that way I have commit history in case I need to revert or something haha.
You're very welcome!! I'm glad too, it was a lot easier than I thought it would be which was great


Discovery Sprint: Validation in the Universal Pipeline (UP)

Description
This Discovery sprint is to help define what our users want around validation in the Universal Pipeline.
Team
Core Team:

Chris Kuryak (Product - Nava) - Sprint Team Lead
Brick Green (Engineering -A6)
Jessica Sutantio (Design - Nava)

Working Documents

Discovery Sprint Brief
Discovery Sprint Notes Doc
. . .

Discovery sprint complete. No longer need this epic.


Iosiro 5.4.4 - remove rewardId from storage

Deprecated in favor of https://github.com/Synthetixio/synthetix-v3/pull/1439


Add More Commands

[ ] #318
[ ] #319
[ ] #320

A bit more information on these issues might help :) Thank you


Implement Non-Maximum-Suppression example in CPP using NumCpp

Change to numcpp because of cpp compatibility

I found that the xtensor implemented with the same logic takes 3 to 4 times the speed compare to numcpp
Therefore, I think it would be better to proceed with the numcpp implementation first
On my PC, it took 1ms to process NMM and IOS in numcpp use

Thanks @youngjae-avikus ... I'm making progress on this.  I'll have a branch for you to look soon.

@youngjae-avikus just FYI, this has been superseded by the following issue
Implement new conditional/optional Non Maximum Suppression Pad Probe Handler #817


Will it help to fix Broken Paths or create my own texture pack for boxpvp?

Hello would @SHsuperCM help to create texture pack sword,pickaxe,castom armor for boxpvp mode all tutorials were on optifine. And the other texture packs I wanted to use had Broken Paths. Will it help to fix Broken Paths or create my own texture pack for boxpvp?

Apologies but no, I dont assist in making packs.


Single Announce URL not getting added

Using:
torrenttools create -a "https://blah1.com" -p -l 21 -v '1' -o ~/somewhere/ ~/somewhere/something
Results in no announce URL being added to the metafile
Announces:

Using:
torrenttools create -a "https://blah1.com" "https://blah2.com" -p -l 21 -v '1' -o ~/somewhere/ ~/somewhere/something
Results in both URLs being added to the metafile
Announces:
tier 1  - https://blah1.com
tier 2  - https://blah2.com

This was fixed in 9f79c3950065ab3e5b7cab0f0067777d5bfd5c05 but was not released until now with the v0.3.0 release.

Cool. I can see while processing that it picks up the single announce URL. But, now in 0.30, seems like after it completes, there is no metafile written where it says it was written

The output option should be fixed in 9c00e2f.
Thanks for reporting! Keep it up :slightly_smiling_face:


Uninstall problem(context menu was not removed)

Steps to reproduce
uninstall the previous version powershell6-preview
Expected behavior
delete the folder and context menu at the same time
Actual behavior
folder was deleted, but the context menu not
Environment data

I do not remember the version number since I have uninstalled it.
But I have the package name PowerShell-6.1.0-rc.1-win-x64.msi which used to install previous version.

I have this problem on my machine as well. It seems there must've been a faulty MSI during a preview phases when the 6.1-preview packages were renamed to 6-preview. 6.1.0` correctly removes the context menu on uninstall. Since this is a preview build, I'd advise to manually remove the left-over registry keys, you can find them here

I also have been dealing with this for months. Wish someone would whip up a quick tool to automate this as it's very annoying for hundreds of people to have to go to their registry to fully remove a program.

PR #8496 has been made to fix this, can you report which version. Otherwise this is just the nature of previews that some previews might have bugs in them (I saw it generally working but there were some 'bad' versions in the past that caused that)

I saw a similar problem when upgrading from 6.2.0 to 7.0.0-preview.1:

Install PowerShell-6.2.0-win-x64.msi
Install PowerShell-7.0.0-preview.1-win-x64.msi
Uninstall 6.2.0
Repair 7.0.0-preview.1, just in case the uninstallation of 6.2.0 damaged it

After those steps, I had duplicate registry keys, e.g. HKEY_LOCAL_MACHINE\SOFTWARE\Classes\DesktopBackground\Shell\PowerShell6x64 and HKEY_LOCAL_MACHINE\SOFTWARE\Classes\DesktopBackground\Shell\PowerShell7-previewx64. The PowerShell6x64 keys ought to have been deleted. I presume Windows Installer did not delete them because the component GUID was not changed.
This comment says PowerShell intends to switch from MSI to MSIX instead of frobbing the component GUIDs. Is that still going to happen before the 7.0.0 release?
(By the way, I spent a while searching docs.microsoft.com for information on the HKEY_LOCAL_MACHINE\SOFTWARE\Classes\Directory\ContextMenus key. However, it turns out to be referenced by ExtendedSubCommandsKey values of other Registry keys, rather than specially recognized by the shell.)

After installing PowerShell-7.0.0-preview.3-win-x64.msi, the previous preview context menu looks weird. And I have checked the C:\Program Files\PowerShell\6-preview, it might empty by the Powershell7-preview installer.
https://github.com/PowerShell/PowerShell/issues/7826#issuecomment-525013525

uninstalled 6 and 7-preview, looks awful...

Please refer to this comment for manually removing left-overs https://github.com/PowerShell/PowerShell/issues/12105#issuecomment-598486477
In issue #12011 a potential solution to this is being discussed.

@bergmeister still there
PS C:\WINDOWS\system32> $version = '7-previewx64'
PS C:\WINDOWS\system32>
PS C:\WINDOWS\system32> Remove-Item -WhatIf -Recurse "registry::HKEY_CLASSES_ROOT\Directory\shell\PowerShell$version",
>>                              "registry::HKEY_CLASSES_ROOT\Directory\ContextMenus\PowerShell$version",
>>                              "registry::HKEY_CLASSES_ROOT\Directory\Background\shell\PowerShell$version",
>>                              "registry::HKEY_CLASSES_ROOT\Drive\shell\PowerShell$version"
WhatIf: 正在目标“项: HKEY_CLASSES_ROOT\Directory\shell\PowerShell7-previewx64”上执行操作“删除键”。
WhatIf: 正在目标“项: HKEY_CLASSES_ROOT\Directory\ContextMenus\PowerShell7-previewx64”上执行操作“删除键”。
Remove-Item : 找不到路径“HKEY_CLASSES_ROOT\Directory\Background\shell\PowerShell7-previewx64”，因为该路径不存在。
所在位置 行:1 字符: 1
+ Remove-Item -WhatIf -Recurse "registry::HKEY_CLASSES_ROOT\Directory\s ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (HKEY_CLASSES_RO...ell7-previewx64:String) [Remove-Item], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

WhatIf: 正在目标“项: HKEY_CLASSES_ROOT\Drive\shell\PowerShell7-previewx64”上执行操作“删除键”。
PS C:\WINDOWS\system32> $version = '6'
PS C:\WINDOWS\system32> Remove-Item -WhatIf -Recurse "registry::HKEY_CLASSES_ROOT\Directory\shell\PowerShell$version",
>>                              "registry::HKEY_CLASSES_ROOT\Directory\ContextMenus\PowerShell$version",
>>                              "registry::HKEY_CLASSES_ROOT\Directory\Background\shell\PowerShell$version",
>>                              "registry::HKEY_CLASSES_ROOT\Drive\shell\PowerShell$version"
Remove-Item : 找不到路径“HKEY_CLASSES_ROOT\Directory\shell\PowerShell6”，因为该路径不存在。
所在位置 行:1 字符: 1
+ Remove-Item -WhatIf -Recurse "registry::HKEY_CLASSES_ROOT\Directory\s ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (HKEY_CLASSES_RO...ell\PowerShell6:String) [Remove-Item], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

Remove-Item : 找不到路径“HKEY_CLASSES_ROOT\Directory\ContextMenus\PowerShell6”，因为该路径不存在。
所在位置 行:1 字符: 1
+ Remove-Item -WhatIf -Recurse "registry::HKEY_CLASSES_ROOT\Directory\s ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (HKEY_CLASSES_RO...nus\PowerShell6:String) [Remove-Item], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

Remove-Item : 找不到路径“HKEY_CLASSES_ROOT\Directory\Background\shell\PowerShell6”，因为该路径不存在。
所在位置 行:1 字符: 1
+ Remove-Item -WhatIf -Recurse "registry::HKEY_CLASSES_ROOT\Directory\s ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (HKEY_CLASSES_RO...ell\PowerShell6:String) [Remove-Item], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

Remove-Item : 找不到路径“HKEY_CLASSES_ROOT\Drive\shell\PowerShell6”，因为该路径不存在。
所在位置 行:1 字符: 1
+ Remove-Item -WhatIf -Recurse "registry::HKEY_CLASSES_ROOT\Directory\s ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (HKEY_CLASSES_RO...ell\PowerShell6:String) [Remove-Item], ItemNotFoundEx
   ception
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.RemoveItemCommand

@maicWorkGithub You could try to remove the context menu by Easy Context Menu 1.6.

select the context menu you want to remove, and click delete

After installing PowerShell-7.0.0-win-x64.msi, the PowerShell preview 7.0 was uninstalled, but the context menu was kept.

Then I removed the context menu "PowerShell 7-preview" by Easy Context Menu 1.6.

manually remove the menu by Easy Context Menu 1.6.


New plot type: isopleth

I'm so glad to see a package that makes plotting geo heatmap this kind of easy and beautiful. After reading the API and I realize that the heatmaps produced by geoplot using seaborn represent the density of geo-events. I wonder if there is any way you can think of to use interpolation method to generate those kinds of heatmaps representing air pollution, temperature, etc.
I've been looking for a way to do this kind of plot for a white.

Yes, geoplot.heatmap only works on point features lacking magnitudes. If you have gridded data with magnitudes, as in the cases you mentioned, this API won't work for you.
Heatmaps based on gridded magnitude data is a generalization of heatmaps based on point data, and I'm afraid there's quite a lot of math you or I would need to chew down to work an algorithm out. I don't personally know of any to achieve this currently in Python.
I'd recommend creates a grid of squares around each observation, and plotting that as a choropleth. You can think of this as a pixelated heatmap.

@ResidentMario Indeed...I'm looking at this API from matplotlib and see if I can figure it out. Sadly, this heatmap thing is the only part that is missing from my complete python workflow. Thank you for your kind reply.

@ResidentMario  I just saw a  link at the bottom of this page in the GeoPandas doc.

Very cool! Maybe an implementation is easier than I thought.

@ResidentMario It would be great if there is a Python package that uses scipy interpolation module but is designed for geospatial point pattern analysis specifically like IDW and other more advanced methods.

@ResidentMario Here are some good resources.
https://mathlab.github.io/PyGeM/idw.html
https://stackoverflow.com/questions/3104781/inverse-distance-weighted-idw-interpolation-with-python
https://github.com/paulbrodersen/inverse_distance_weighting

This is known as an isopleth in the literature.

@ResidentMario The isopleth might be very useful but might not be what I was suggesting for since there are many methods for interpolation.
I just read a book this week and the author talked about a few different types of interpolation (e.g., IDW) often used in GIS in chapter 8 and shared his code here.

Well, this feature request is for a plot function that takes point data with magnitudes as input, applies some sort of smoothing/interpolation function over it, and outputs a heatmap (which is an isopleth, in this context).
Interpolation can be tunable using a plot parameter. gplt.quadtree already defines an agg parameter for an aggregation function; an isopleth function could have a similar special parameter for a smoothing function whose default argument is an idw algorithm.

as an arg? man... I think I would like such an API design and am definitely looking forward to it!


Automated Package Upgrade

:tada: This PR is included in version 6.0.85 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Hybrid Azure AD joined device owner

Does the 'Tip' on this page need to be updated since Hybrid devices that are co-managed do show an Owner in Azure AD?
Tip
Hybrid Azure AD joined Windows 10 or newer devices don't have an owner

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a8119688-e88d-2916-3dcf-bf777a5fc80c
Version Independent ID: e767d695-1c9f-64e4-e6c4-fef07b0f3d2e
Content: Manage devices in Azure AD using the Azure portal - Microsoft Entra
Content Source: articles/active-directory/devices/device-management-azure-portal.md
Service: active-directory
Sub-service: devices
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@dereklangMSFT
Thanks for your feedback! We will investigate and update as appropriate.

@MicrosoftGuyJFlo
Could you please take a look at this? Thanks in advance.

#label:"awaiting-product-team-response"

@SanDeo-MSFT Thoughts?

Backlog item 2169364 created to track internally. Will update here when the product group provides more details. #please-close


RVM23 comment: Zimop Zcmop can be NOPs?

RVM23 says Zimop and ZCmop can be implemented as NOPs. Is this true?
These specs require writing 0 to rd.

The comment under the Zcmop applies only to Zcmop and, unlike Zimop, C.MOP.n does not write to any register.

This was addressed in https://github.com/riscv/riscv-profiles/commit/326d29536cef08f007539015e663ac6c44e1e7be


Add trailing new line to BSD license

I just created a new package with a BSD license, and pre-commit failed on it because there wasn't a trailing new line at the end of LICENSE.md. I'm hoping this will fix that?

Oh prittier is complaining!?

Seems like this is not the right way to fix this 😢


DrawingPlayer-ShareInRealTime-PaintingShownInstant

Story: As a drawing player, I want to draw shapes on the white board and share it in real-time. Other guessing players can see the instant update and know what I’m doing.
Acceptance Criteria:

[x] After the drawing player draws something on the white board, the update will be shown to other players in real-time.
[x] Before the drawing phase ends, the guessing player cannot enter answers.

Development Tasks:

[x] sopra-fs23-group-19/sopra-fs23-group-19-server#79
[x] sopra-fs23-group-19/sopra-fs23-group-19-client#56

https://github.com/sopra-fs23-group-19/sopra-fs23-group-19-client/commit/5d4ecb2c980fa4508d2a855259f28c2de6878a86


Add allow-shlib-undefined to linux ldflags

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This addresses https://github.com/conda-forge/gdal-feedstock/pull/604#discussion_r806066286

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender

Need a build number bump as well.

@conda-forge-admin, please rerender


Update Teaching “index”

Automatically generated by Netlify CMS

👷 Deploy Preview for ross-cms processing.

Name
Link

🔨 Latest commit
dd9536421c5b41bb6b549d04a9e14f7741500eed

🔍 Latest deploy log
https://app.netlify.com/sites/ross-cms/deploys/65daab88dc3d2400082ad0f2


Change the URL that fetch grpc address

Coverage remained the same at 17.207% when pulling f96338d977ab8c4a16d5bbc1c139aaff1ede0967 on ascrutae:zhangxin/fix/debuging-issue into af690c18ed62bdbdbeea218a2a88ad7851624e6d on wu-sheng:master.


difference between @types/keyv and types of keyv

With https://github.com/jaredwray/keyv/pull/257 typescript support was implemented. I love it and support it. However, this was a breaking change in my eyes. The types differ between @types/keyv and keyv package.
I use keyv myself only as transitive dependency via the cachable-request. This imports keyv via >4.0.0. After npm upgrade I get this error.
node_modules/@types/cacheable-request/index.d.ts:13:10 - error TS2305: Module '"keyv"' has no exported member 'Store'.

13 import { Store } from 'keyv';

typescript prioritize the shipped types over types provided with ' @types/...'.  Would it be possible to add the missing types, or is this not desired (could provide pr)? Another solution would be to update to a new major version and revert the change in v4.x.x

@AnWeber - Please stay on 4.1.1 until we fix the Store issue we are seeing which we believe should be resolved shortly.
you can follow along here also: https://github.com/jaredwray/keyv/pull/267

@jaredwray I saw the PR, but unfortunately did not realize that the exact problem was also being discussed. Cool, thanks.

@AnWeber Thanks. We are working on it.

@AnWeber wanted to check in that the 4.2.1 release is working for you

@jaredwray Works for me too. Thank you.

@jaredwray I landed a change to @types/keyv recently that isn't accounted for in the new type definitions. I think that it makes sense for a partial of Keyv.opts to be available to classes that extend Keyv, since this.opts is always assigned in the Keyv constructor. In hindsight, I should've made it a protected property, but I'm curious to hear your thoughts and if you'd accept a PR with changes in the spirit of this one: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/59154
Thanks!


Test files included in the gem file

Currently theres 11 meg of SQL test files being included within the built Gem - the rest of the gem is tiny in comparison.
The gem test command went away quite some time ago, as did the test_files command still used the Gemspec
Do these still need to be included in the packaged Gem or can they be excluded - would you take a PR to exclude them?

PR would be great. At some point I'd made sure those files (or at least, the large files within the test suite) weren't being included, but I guess that I broke that somewhere along the line.

Closing this issue, as @dimko got it sorted in #100.


Not able to send Code Snipped in chat window during individual or group call

Teams Version <IP_ADDRESS>67 (32-bit)
Chat during a call

Chat without call

Thanks for reaching out to us. We are the developer support team for Microsoft teams focused on helping developers resolve their code issues. For issues related to teams product, please reach out to the Product support channels for Microsoft Teams.


ord() redefinition in rfb.py causing log-in issues

We've run into an issue with logging in with vncdotool to take a screenshot of the remote machine. The cli implementation does not send the correct password to the remote machine.

I do not know the VNC server or version but I don't think it matters for this issue.
vncdotool version: 1.0.0
Reproduce: attempt to get screen capture using vncdo -s [ip address] capture [imgname].png

The root of the issue appears to be the ord() redefinition at lines 28 - 30 in rfb.py. Commenting out that redefinition fixes the login issue for us, but (without testing) I assume this causes issues with the rest of the file (though it does get the screencap we wanted).
I don't really know much about this package but it seems to me that instead of redefining ord() y'all should make a local version with a local name (even if that's just _ord()).

Looks like this introduced as part of a py3 compatibility fix, related to https://github.com/sibson/vncdotool/issues/151 https://github.com/sibson/vncdotool/pull/164 https://github.com/sibson/vncdotool/issues/170 https://github.com/sibson/vncdotool/issues/172.   Off the top of my head, I'm not sure what the next step will be.

The redefinition the ord() causes it to return the same parameter given to it. So when trying to reverse the key in setKey function (line 836) it tries to compare a string to an integer, which causes a crash. I commented the redefinition also and it fixed my problems when trying to connect with a password.
The redefinition causes for example ord('x') to return 'x' instead of the integer value the setKey function needs.
        for ki in range(len(key)):
            bsrc = ord(key[ki])
            btgt = 0
            for i in range(8):
                if bsrc & (1 << i): <--- bsrc needs to be an integer here.
                    btgt = btgt | (1 << 7-i)
            newkey.append(chr(btgt))

The fix seems to be to comment out lines 30-31 in rfb.py. Change this:
if not isinstance(b' ', str):
    def ord(x): return x

to this:
'''if not isinstance(b' ', str):
    def ord(x): return x'''

modify function like this,
'''
class RFBDes(pyDes.des):
def setKey(self, key):
"""RFB protocol for authentication requires client to encrypt
challenge sent by server with password using DES method. However,
bits in each byte of the password are put in reverse order before
using it as encryption key."""
newkey = []
for ki in range(len(key)):
tt=key[ki].encode()
bsrc = int.from_bytes(tt,"little")
btgt = 0
for i in range(8):
if bsrc & (1 << i):
btgt = btgt | (1 << 7-i)
newkey.append(chr(btgt))
super(RFBDes, self).setKey(newkey)
'''

That code does not look that pythonic. Depending an #227 if Python 2 support can be dropped this could be rewritten as following:
class RFBDes(pyDes.des):
    def setKey(self, key: bytes) -> None:
        """RFB protocol for authentication requires client to encrypt
           challenge sent by server with password using DES method. However,
           bits in each byte of the password are put in reverse order before
           using it as encryption key."""
        newkey = bytes(
            sum((128 >> i) if (k & (1 << i)) else 0 for i in range(8))
            for k in key
        )
        super(RFBDes, self).setKey(newkey)

This requires changing sendPassword() to do the encoding:
    def sendPassword(self, password: str) -> None:
        """send password"""
        pw = (password + '\0' * 8)[:8]        #make sure its 8 chars long, zero padded
        des = RFBDes(pw.encode("ASCII"))
        response = des.encrypt(self._challenge)
        self.transport.write(response)

The re-definition of ord() will be gone with the next release including 756c5f8. So your issue should be fixed.


DirectX Camera - Projection Matrix Pointer

Engine Breaking
There is occassionally a bug that appears in the cameraprojection.cpp file, that picks up a false positive issue on an l-param in the pointer. This is because the l-param is initially null.
Solutions
There aren't really any solutions I can think of, as passing a value into the camera at start that isn't null will crash the engine.

Fixed by assigning the address value to a cached local variable, as the l value is transient and highly volatile and can be lost.


Different results from fit_generator and fit

Keras 1.0.0 with Theano 8.1.0 on linux, Titan X GPU:
I get different convergence characteristics from fit vs fit_generator - fit converges to a reasonable solution, but fit_generator does not.
Here's the code: https://gist.github.com/darugar/b83c70284acce912542431f6999578ae
I have a model with 5 convolution layers, 3 dense (I see the same issue with other models).
When I load all of the training data into memory and train the network with fit I get a decrease in loss, increase in accuracy.
When I load the same model with the same data, but this time via a data generator and fit_generator, I get increasing loss, poor accuracy.
I've confirmed that the data returned by the data generator is the same as the data in memory by collating the generated data and comparing with the in-memory.
I'm using a thread based model to load data into the generator in the background, but otherwise nothing exotic. I use only a single thread for reader, so hopefully no strange thread interaction issues.
My data is 9x64x64, 70k training samples, 30k validation.
Loss graph for fit (in-memory data). Blue is training loss, green is validation:

Loss graph for fit_generator:

It looks like the difference in behavior was due to the lack of data shuffling in my data generator - I tried fit with shuffle=False and got poor results, and then I integrated data shuffling into my generator and I started seeing good results with fit_generator. Moral of the story: shuffle your data properly!

@darugar I have run into the same problem. Note that fit_generator() does not have the shuffle parameter. Do you mean that you are shuffling the data inside your customized generator?

I've integrated a random generator to fix this issue like this
`class Generators:
def generate_train_batch(self, data,img_rows, img_cols, batch_size = 16):
    batch_images = np.zeros((batch_size, img_rows, img_cols, 3))
    batch_masks = np.zeros((batch_size, img_rows, img_cols, 1))
    while 1:
        for i_batch in range(batch_size):
            i_line = np.random.randint(len(data)-1)

            img,parcel_id, binary_img, orginal_size, area, image_corner, coordinates_boundary= main(data, i_line ,verbos = False ,resize = True,compute_footprint_area= False, size=(img_rows,img_cols),extract_parcel= True,augumentation=False,
                                  balance_classes=False, display_gt = False, display_parcel_mask= False, display_mask = False,
                                  display_binary_img=False)
            #img_rows, img_cols =  img.shape[:2]

            batch_images[i_batch] = img
            batch_masks[i_batch] = binary_img
        yield batch_images, batch_masks`


[RUNTIME][BUGFIX] Fix DSO module problem when its parent get destructed.

Previouslyw we set the context of the DSO module to be the root module.
This can cause problem when the root module is not the dso module and
get destructued early (but we still need the dso module).
This PR makes the following change to fix the problem.

Merge multiple DSO modules to one during export.
Set the context to be the (only one) dso module.
Updated testcase to cover the problem.

The enhancement creates some restrictions on the dso import hierachy
(all dso modules needs to be merged without a cycle). This is the case
for our applications. The merged dso is also more consistent
as the library itself is merged.

cc @jwfromm @mbrookhart should fix the loading problem. cc @FrozenGene @junrushao1994 @areusch

Thanks @areusch, there is indeed no cycles in the import tree before we export, and the cycle will only be created when we try to merge  dso modules

@tqchen if the import tree has no cycles to begin with, could you give an example where merging could create such a cycle? I think one of the children of a DSO-exportable module would need to import a non-child of that DSO-exportable module?

@tqchen the practical ramifications of this are that if somehow CUDA module had code to GetFunction("foo", query_imports=true) and dso0 defined that function, the module might behave differently after export -> load, correct? it's not really valid to write code that expects the import tree to be any particular way, since export/load will change it. so, it seems like we would also like some more things (perhaps not in this PR):

assert at compile time we don't have two functions of the same name
ensure we have a single convention by which generated Module use GetFunction or TVMBackendGetFuncFromEnv.

does that seem reasonable to you? Just wondering what use cases might crop up in the future that may trip this, and whether it's worth adding asserts in Import to fix them before export is involved.

First of all, I do not think such a hierachy is useful. In terms of the naming overlap, while it might be possible to do so in the compiler for artifacts checks to the extent when possible.

ping @areusch for another look


Feature Request: Parameters and OpenAI model

Parameters to specify OpenAI model and settings.
ex. I'm subclassing App and updating the model this way to test:
def get_openai_answer(self, prompt):
        messages = []
        messages.append({
            "role": "user", "content": prompt
        })
        response = openai.ChatCompletion.create(
            model="gpt-4-0613",
            messages=messages,
            temperature=0.25,
            max_tokens=1000,
            top_p=1,
        )
        return response["choices"][0]["message"]["content"]

It would be awesome to have a few parameters when querying for temperature,max_tokens, and top_p as well. Or globally/in env? not sure what's best, but happy to create a PR.

I agree. I think that to the greatest extent possible, all important parameters including prompts should be exposed to the user so they can change them at any time.
To further illustrate: I think that Solara would be an ideal browser-based front-end for this app. The app could start with default values, but then the user would have flexibility to change them at any time according to their needs. I would be more than happy to help with this.

I opened a [PR](https://github.com/embedchain/embedchain/pull/100) regarding this topic

This feature made it to production, #215.


Projects - get projects up and running and link to them

This includes updating project documentation and cleaning up code

Projects are up and running on EC2 with node. Just need to update projects pages


update binary packaging rules for 1.0 build

enable the debian/ubuntu deb build for ARM64 arch
#667 changed the hyperd binary path
hyperhq/hyperstart#341 changed the kernel path

Signed-off-by: Wang Xu<EMAIL_ADDRESS>

LGTM!


BUILD-186: add buildconfig/status permissions to ocm

/assign @adambkaplan
if we move forward with https://github.com/openshift/openshift-controller-manager/pull/171/commits/205e2bd3191416e4a47dfe82b01926164b4eec02

/retest

/retest

/retest

upgrade failures still unrelated comps
/retest

/retest

all green tests @adambkaplan

/test e2e-aws
/test e2e-aws-operator
/test unit

/refresh

more [sig-api-machinery][Feature:APIServer][Late] kubelet terminates kube-apiserver gracefully fails
/retest


Issue fix (456) for resolution of service account mapping (Translation of principals)

Please check if the PR fulfills these requirements

[x] The commit messages are descriptive
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[x] An issue has been created for the pull requests. Some issues might require previous discussion.

We couldn't find the existing testcase for CCloudAclsProvider and found it challenging to create one with CCloudApi not injected. So we have proposed a localised change and added test for the new code we introduced

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

What is the current behavior? (You can also link to an open issue here)

Documented under https://github.com/kafka-ops/julie/issues/456

What is the new behavior (if this is a feature change)?

Julie is now able to resolve the service accounts specified by name in the descriptor to the corresponding numeric id, so that the ACLs are created as expected

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Unlikely (this restores the ability of julie to function when the principal translation is enabled)

Other information:
We consider that the bug 456 is a show stopper for our use case where we expect to use the service account names (rather than numeric ids) and therefore we might require a new release/hot fix

LGTM, thanks for the contribution!


CORS error when fetching https://raw.githubusercontent.com/cosmos/chain-registry/master/andromeda1/assetlist.json

This was likely either temporary due to an issue with Github, or an extension that's causing this issue. Github seems to be returning access-control-allow-origin: * so it shouldn't throw CORS errors

I believe the answer above provides sufficient explanation.


Cannot put raw meat on cutting board if somethings in the off-hand

@Zifiv please close this issue.


Authentication it only works for the first type

Hi!
First of all, id like to say thanks for this plugin! Its a great work!
I only found one problem, if I select more than 1 type of authentication it only works for the first type.

In that example I cant authenticate using Windows Hello integration.

But if I remove

The Windows Hello integration works.

I see in your first screenshot that you have "Requested Authn Comparison" set to "Exact".  Have you attempted to change that to "Minimum"? Make sure to keep the Order (Password, X509) the same.

I change to:

and try to authenticate:

After further research AAD only supports 'exact' AuthnContext Comparison.  The Onelogin library allows us to send no AuthContext by settings the 'requestedAuthnContext' to false.  Currently the plugin does not allow this and will send null if requestedAuthnContext is not set in the configuration.
To change this behavior change line 329 of phpsaml.class.php to:
'requestedAuthnContext' => (isset($config["requested_authn_context"]) && !empty($config["requested_authn_context"]) ? self::getAuthn($config["requested_authn_context"]) : false),
Then remove all Requested Authn entries in the configuration.

If this works for you, I can update the code on the next version.

Checking on this,  did that work for you?

Closing this issue due to no response.


Prometheus Pushgateway

It seems Prometheus is not working at all.
First, the prometheus does not accept . as label separator.
https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels
Accepts regex [a-zA-Z_:][a-zA-Z0-9_:]*
Second issue seems to be "duplicate metrics collector registration attempted"

The pushgateway support has been replaced by an actual Prometheus endpoint.  This label naming bug has been fixed, too.  Check it out!
There is a config-simple.yaml file in the examples to get you going.


Improve post details scraping

[ ] Scrape number of likes
[ ] Scrape number of shares and comments
[ ] Scrape content (text)
[ ] Scrape images  (URL)
[ ] Scrape post's author


Modifying config.js has no effect

How exactly do you configure the use of REST? Modifying config.js as follows has no effect for me.
var Evol = Evol || {};

Evol.Config = {

	// --- using localStorage
	localStorage: false,

	// --- using evolutility-server-node
	url: 'http://localhost:3000/api/v1/evolutility/',

	// --- using postgrest
	//url: 'http://localhost:3001/'
};

Looks like the actual config is made in evolutility-ui-jquery.js plus config.js is not included anywhere. Is this by design?

You must run grunt to rebuild the files evolutility-ui-jquery.js (or evolutility-ui-jquery.min.js). These files include the config.js.

Thanks, the grunt dev task did the trick.

Thanks for letting me know. I updated the ReadMe file.


2 Feature Suggestions: Attach input args to output for style functions. & Optional 'styles' arg for system-components

@jxnblk
just a thought: attaching the arguments in the style functions like you do with proptypes, will allow an easier way to document the default styles and user custom styles.
Also, it will be nice to make system-components, take in an optional 'styles'  argument on create (fallbacks to styled-system styles), that way we can feed in custom styles to the dict.

Adding another idea...
Hit a bit of a road block when trying to use StyledComponent Parent that needed to pass down to a styled child and not lose the functionality of being able to extend the child. So instead of something like this below
const Component= ({ children,sharedProps, innerRef, ...props }) => (
  <Parent {...props, ...sharedProps}>
  <Child ...sharedProps>
children
</Child>
  </Parent>
)

I can do
const Parent = styled(tag)`
${fn(prop1))
`
Parent.defaultProps{
is:div
theme:theme,
passProps:['prop1','prop2','theme']}

Parent.Child=styled(tag)`
${fn2(prop1)) ${fn3(prop2))
`
Parent.Child.defaultProps{
is:...
}

By changing the tag function to something like:
export class Tag extends React.Component {
  render() {
    const {
      innerRef,
      is,
      blacklist,
      children,
      passProp,
      theme,
      ...props
    } = this.props
    const attr = omit(props, blacklist)
    const propsToChildren = pick(passProp, props)
    const getChildren = () => {
      let childrenCount = React.Children.count(children)
      if (childrenCount > 1 && !isEmpty(propsToChildren)) {
        return React.Children.map(children, (child, i) => {
          if (i < 20) {
            ///Temporary Guager for testing
            if (typeof child === 'object') {
              ///Look to see if i can be more specific of the type of child
              return React.cloneElement(
                child,
                merge(child.props, propsToChildren) ///Need to see if it only overides defaultP and not
              )
            }
          }

          return child
        })
      } else {
        return children
      }
    }

    return React.createElement(
      is,
      {
        ref: innerRef,
        ...attr
      },
      getChildren()
    )
  }
}

Tag.defaultProps = {
  is: 'div',
  blacklist,
  passProp: ['dummy']
}

This might be a one off instance where a parent and a child share same prop, but return different css according to the prop, but this makes it cleaner so i dont have to duplicate the prop for each child like:
<Parent spacing='sm'>
<Parent.Child spacing='sm'> </Parent.Child>
<Parent.Child spacing='sm'></Parent.Child>
<Parent.Child spacing='lg'></Parent.Child>
</Parent>

And now I dont have to pass the prop down to each child, and i have the abililty to extend the styles of styled Child, where you cant extend if you have a single wrapper component. And I have the ability of overriding the passed prop on the child.
<Parent spacing='sm'>
<Parent.Child> </Parent.Child>
<Parent.Child></Parent.Child>
<Parent.Child spacing='lg'></Parent.Child>
</Parent>

Just thought I'd share.. and appreciate any feedback or if theres any potential problems doing this

Sorry for never chiming in on this, but sounds like this is similar to what I've started here: https://github.com/jxnblk/styled-system/tree/master/system-docs
Going to close this issue out, but feel free to open a new one if relevant


Order dropdown fields

Add ability to re-order dropdown field options from the event form edit page.

Added 09c5d3902383dfebbc7a7fdfd81d93c49727f431


Dataset metadata

Description
Provide a brief description of the PR's purpose here.
addresses #3
Metadata pydantic class is added to the datasets which holds important information about the submission.
Todos
Notable points that this PR has either accomplished or will accomplish.
Autofill information

[X] Submitter
[X] Creation date
[X] Collection type
[X] Dataset name
[X] Description

User required fields

[ ] URL

Questions

[ ] If all of the information which is normally included in the dataset-submission README (https://github.com/openforcefield/qca-dataset-submission/tree/master/2020-04-28-Fragmenter-test) is in the dataset would it make sense to have a function in the dataset which could automatically make the formatted README file?

[ ] Should any of those fields not be autogenerated? Note they are mutable so the user can easily swap them after generation.

[ ] The URL is currently an optional field which should be entered into the dataset, however, this could be added as an argument to the create_dataset function, for example

from qcsubmit.factories import OptimizationDatasetFactory
opt_factory = OptimizationDatasetFactory()
# set settings here ...

opt_dataset = opt_factory.create_dataset(dataset_name="new dataset", molecules=molecules, description="testing qcsubmit", url="https://github.com/openforcefield/qcsubmit/")

Status

[ ] Ready to go

tagging @jaimergp for codecov help

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@509d7df). Click here to learn what that means.
The diff coverage is n/a.


Prompt can't contain []

Issue summary
Hi,
I'm using 2.22.0 and the following prompt:
prompt: '[foobar /]$ ',

Expected behavior
Prompt is
[foobar /]$

Actual behavior
Prompt is
[foobar /$ ]

or after pressing Enter, the entered line switches but the prompt stays the same:
[foobar /]$
[foobar /$ ]

Steps to reproduce
Use a prompt with [].
f.e. in the demo:
var term = $('body').terminal(() => {}, {
    'prompt': '[foobar /]$ '
});

Additional info
This worked for me as a workaround in 2.21.0:
prompt: '[foobar /]$ ',

f.e. in the demo:
var term = $('body').terminal(() => {}, {
    'prompt': '[foobar /]$ '
});

But now this adds big span elements after the prompt and after [ and ] if Enter is pressed.
Browser and OS
Chrome 88 on Windows 10

Thanks for the bug report, Will investigate.

The issue is fixed it will be released in next bug fix version. The problem was that when prompt was not formatting the brackets where not escaped and the whole thing was wrapped in empty formatting, so if fact it was broken formatting. Brackets have special meaning in jQuery Terminal but only if the are in special format (which is know as jQuery Terminal formatting).


Reorganize microservices packages and modules within their own package

Impact of the new feature
Microservices
Is your feature request related to a problem? Please describe.
With all the microservices already created, and still others already planned to be created, I think we should better organize those packages/modules under WMCore/MicroService to properly reflect the code and service provided.
Describe the solution you'd like
Still trying to make the whole picture in my mind, but the obvious re-organization is that each microservice should live inside its own package (named after the microservice).
TODO: update this description once other things are more clear.
Describe alternatives you've considered
Keep things as they are.
Additional context
none

Well done @amaltaro! I like this  reorganization pretty much. It is in perfect coherence with my practice of running the micro services standalone. And I like to have everything from a module at a single place.


Switch APNS module from a connection pool to a worker pool.

This change was made because the connection pool didn't use mutexes when adding connections/removing
connections from the pool, so it was prone to race conditions.
Before this change, Uniqush's apns module would crash at high load after a
few days.
Finish moving apns code into its own modules
Fix a bug in writen : There was no limit on the number of temporary
errors. writen could potentially get stuck in an infinite loop and use
up 100% of a CPU indefinitely.
The feedback checker was changed - if the goroutine reading from the socket notices that the connection was closed, it notifies the worker from the corresponding worker pool.
(This splits up srv/apns/binary_api_processor.go into srv/apns/binary_api/processor.go and srv/apns/binary_api/pool.go . A diff can be generated locally. The pool implementation was changed from connection pool to a worker pool.)
This starts logging when connections were open (loggingConnManager). We already log the unexpected closing of connections (This change allows users to better debug connection issues).
Testing:

Unit tests of srv/apns/push_service.go and srv/apns/binary_api/processor.go were added. All of them passed
Ran apns-test.sh

:+1: Thanks @TysonAndre ! And since we're running this at production scale, we know this patch is mature and ready.


Refactor Desired Chain to Active Chain

Refactor of the ThirdwebProvider component property from desiredChainId to activeChain

Used "mumbai" for consistency across repos

can you update it in the readme as well?

@avneesh0612  ,sorry jsut seen this. yes will do so for all repos that i messed the read me on


No longer plays well with SqlBrite

Are there plans to make SqlDelight compatible with the SupportSqlite apis being used in SqlBrite 3.0?

Yes. Some of the changes on master already work towards this by using the SQLite support library. I haven't had time to circle back and finish them yet, though.

I'd be interested in this too. Did a lot of work here, but there are probably still bugs https://github.com/mikelikespie/sqldelight/commit/16f26424e09dc4ffc42500bb6dd39b5ec5e418e4

@mikelikespie if it's ready send a PR!

I just realized I'm using SQL Delight 0.6.1 and SQL Brite 3.0.0 in a project and it's working fine still. I didn't remove any APIs from SQL Brite 3.x so it should still Just Work™.

I might be using the deprecated things to get access to the raw SQL and not the compiled statements though...

BriteDatabase.getWritableDatabase() returns a SupportSQLiteDatabase which cannot be used to compile statements unless you're using the deprecated api.

Yes, you cannot use the generated code to compile your statement and bind your arguments with the deprecated api.

Here's what I'm thinking...
Addition to the runtime:
public class SqlDelightQuery implements SupportSQLiteQuery {
  private final String sql;
  private final Set<String> tables;

  public SqlDelightQuery(String sql, Set<String> tables) {
    this.sql = sql;
    this.tables = tables;
  }

  public final Set<String> tables() {
    return tables;
  }

  @Override public final String getSql() {
    return sql;
  }

  @Override public void bindTo(SupportSQLiteProgram statement) {
  }
}

Changes to code gen for queries:
  final class Factory<T extends PlayerModel> {
    public SqlDelightQuery select_all() {
      return new SqlDelightQuery(""
          + "SELECT *\n"
          + "FROM player\n"
          + "JOIN team ON player.team = team._id", new SimpleSet("player","team"));
    }

    public SqlDelightQuery for_team(long _id) {
      return new ForTeam(_id);
    }

    private final class ForTeam extends SqlDelightQuery {
      private long _id;

      ForTeam(long _id) {
        super("SELECT *\n"
            + "FROM player\n"
            + "JOIN team ON player.team = team._id\n"
            + "WHERE team._id = ", new SimpleSet("player","team"));
        this._id = _id;
      }

      @Override public void bindTo(SupportSQLiteProgram statement) {
        statement.bindLong(1, _id);
      }
    }
  }

Yeah that. looks like it would be nice. Would be cool if there was a shared library that had an interface which was SupportSQLiteQuery + getTables() and then sqlbrite could take that type too instead of the two arguments of tables and the statement.

We've been using this: https://gist.github.com/AlecStrong/6a6b33c7a961756ed038408df4858be3 to accomplish that. It's not awful from java since it just becomes a static function. Could probably be easily ported to the new stuff

It's really only temporary. We plan to kill/eat SQL Brite with future
versions of this tool and its runtime.
On Thu, Dec 14, 2017, 11:20 PM Alec Strong<EMAIL_ADDRESS>wrote:

We've been using this:
https://gist.github.com/AlecStrong/6a6b33c7a961756ed038408df4858be3 to
accomplish that. It's not awful from java since it just becomes a static
function. Could probably be easily ported to the new stuff
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/square/sqldelight/issues/702#issuecomment-351909622,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEEEdwLGKadtRc392c4aM_RGZNA7js2ks5tAfOZgaJpZM4Q_Z-a
.

Sets get a bit tricky here...

Getting closer...
    public SqlDelightQuery some_query(@Nullable SomeEnum some_query, @NonNull String[] some_query) {
      return new Some_queryQuery(some_enum, token);
    }

    public Mapper<T> some_queryMapper() {
      return new Mapper<T>(this);
    }

    private final class Some_queryQuery extends SqlDelightQuery {
      @Nullable
      private final SomeEnum some_enum;

      @NonNull
      private final String[] token;

      Some_queryQuery(@Nullable SomeEnum some_enum, @NonNull String[] token) {
        super("SELECT *\n"
            + "FROM test\n"
            + "WHERE some_enum = ?\n"
            + "AND token IN " + QuestionMarks.ofSize(token.length),
            new TableSet("test"));

        this.some_enum = some_enum;
        this.token = token;
      }

      @Override
      public void bindTo(SupportSQLiteProgram program) {
        SomeEnum some_enum = this.some_enum;
        if (some_enum != null) {
          program.bindString(1, some_enum);
        } else {
          program.bindNull(1);
        }

        int nextIndex = 2;

        String[] token = this.token;
        for (int i = 0; i < token.length; i++) {
          program.bindString(nextIndex++, token[i]);
        }
      }
    }

This work happened and is on master.


Can the RTX 2080 Ti with 11GB RAM perform inference tasks ？

System Info / 系統信息
I used the master version,but when it inferenced with 2b model or 5b model,it reported a error,cuda out of memory
my question is "Can the RTX 2080 Ti with 11GB RAM perform inference tasks ？“
Information / 问题信息

[X] The official example scripts / 官方的示例脚本
[ ] My own modified scripts / 我自己修改的脚本和任务

Reproduction / 复现过程
I use the command "python cli_demo.py --prompt "A girl ridding a bike." --model_path THUDM/CogVideoX-2b
torch.OutofMemoryError:CUDA out of memory.Tried to allocate 35.31 GiB
Expected behavior / 期待表现
output a mp4 video

They added this to the README.md, maybe it can help you make it work:

🔥🔥 News: 2024/8/29: By adding pipe.enable_sequential_cpu_offload() and pipe.vae.enable_slicing() to the inference code of CogVideoX-5B, VRAM usage can be reduced to 5GB. Please check the updated cli_demo.

I followed the README.md instruction,then it reported error "torch.OutofMemoryError:CUDA out of memory.Tried to allocate 35.31 GiB"

same as #204


[Refactor][UI] Refactor task instance stream using NSpace component.

Purpose of the pull request
ref #10844

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #11454 (d26a6a1) into dev (376d0a0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11454      +/-   ##
============================================
- Coverage     39.56%   39.55%   -0.01%
+ Complexity     4630     4626       -4
============================================
  Files           980      980
  Lines         37278    37260      -18
  Branches       4179     4171       -8
============================================
- Hits          14749    14739      -10
+ Misses        20983    20972      -11
- Partials       1546     1549       +3

Impacted Files
Coverage Δ

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.00% <0.00%> (-2.78%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
55.12% <0.00%> (-1.29%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.29% <0.00%> (-0.57%)
:arrow_down:

...eduler/api/service/impl/DataSourceServiceImpl.java
27.90% <0.00%> (ø)

...cheduler/server/master/utils/DependentExecute.java
0.00% <0.00%> (ø)

.../dolphinscheduler/plugin/task/datax/DataxTask.java
0.00% <0.00%> (ø)

...phinscheduler/plugin/task/chunjun/ChunJunTask.java
0.00% <0.00%> (ø)

...cheduler/plugin/task/api/ShellCommandExecutor.java
0.00% <0.00%> (ø)

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cannot disable auto HTTPS via Caddyfile when using the official docker image

I'm facing an issue when trying to disable HTTPS on FrankenPHP's official Docker image. I'm using the current latest image so that should be https://hub.docker.com/layers/dunglas/frankenphp/latest/images/sha256-6d437b48fdaf1ef6e606eaf0ca034965232f732bf675b21c6d2314d73fdbe70d?context=explore.
My Caddyfile looks as follows. The app is just a phpinfo call at the moment.
{
  debug
}

{
  frankenphp
  order php_server before file_server
  auto_https off
}

http://:80 {
  root * /app/public/
  php_server
  encode gzip
}

$ tree
.
└── app
    └── public
        ├── Caddyfile
        └── index.php

I'm running this via the official Docker image on an ephemeral VM:
$ docker container run --rm -v $PWD/app:/app -p 80:80 dunglas/frankenphp

This results in the following log lines being emmitted:
{"level":"info","ts":1702127151.2289443,"logger":"http.auto_https","msg":"server is listening only on the HTTPS port but has no TLS connection policies; adding one to enable TLS","server_name":"srv0","https_port":443}
{"level":"info","ts":1702127151.2289834,"logger":"http.auto_https","msg":"enabling automatic HTTP->HTTPS redirects","server_name":"srv0"}

Checking the caddy configuration shows the same:
$ curl "http://localhost:2019/config/" -s | jq
{
  "apps": {
    "frankenphp": {},
    "http": {
      "servers": {
        "srv0": {
          "listen": [
            ":443"    <--- should be :80 instead, right?
          ],
          "logs": {
            "logger_names": {
              "localhost": "log0"
            }
          },
          "routes": [
 ...

As expected requesting a page on the host (outside of the Docker container) leads to a 308 redirection to HTTPS.
$ curl http://localhost/index.php -i
HTTP/1.1 308 Permanent Redirect
Connection: close
Location: https://localhost/index.php
Server: Caddy
Date: Sat, 09 Dec 2023 13:09:37 GMT
Content-Length: 0

The way I'm currently fixing this is by patching the Caddy configuration via its API but I guess this should be patched in FrankenPHP so it respects my Caddyfile.
$ curl -X PATCH --json '[":80"]'  "http://localhost:2019/config/apps/http/servers/srv0/listen"

This results in the expected behavior:
$ curl "http://localhost:2019/config/" -s | jq
{
  "apps": {
    "frankenphp": {},
    "http": {
      "servers": {
        "srv0": {
          "listen": [
            ":80"
          ],

curl http://localhost/index.php -I
HTTP/1.1 200 OK
Content-Type: text/html; charset=UTF-8
Server: Caddy
X-Powered-By: PHP/8.3.0
Date: Sat, 09 Dec 2023 13:14:28 GMT

Apologies if I'm missing something obvious or FrankenPHP isn't intended  to support plain HTTP. Thank you!
Best regards,

Hi,
Support for plain HTTP should work. Can you tell me how you copy your custom Caddyfile in the container?

Hi @dunglas,
Indeed that was the issue. And it was documented on the official docs. My apologies!

Adding this Caddyfile to /etc/caddy/Caddyfile made it work.
{
  debug

  frankenphp
  order php_server before file_server
  auto_https off
}

http://:80 {
  root * /app/public/
  php_server
  encode gzip
}

I believe this can now be closed as a false positive.
Best regards

Thanks for the feedback.


useNameService causing infinite rerender loop

We just analysed why our app was constantly refreshing and noticed that the useNameService hook was the cause of that.
Upon commenting out the hook and not using it, the app behaves as normal.

@vexxvakan Fixed in the latest version.


Dockerfile: Use an explicit go version (go1.16.7) for image building

What type of PR is this?
/kind cleanup
/area dependency
What this PR does / why we need it:

Dockerfile: Use an explicit go version (go1.16.7) for image building
Using a latest tag in general, but specifically for Golang-based
images will eventually lead to unexpected variance in our image builds.
Here we pull an explicit go version and add an entry for it in
dependencies.yaml.
This commit also adds a dependency entry for the go major version in
go.mod, to ensure it stays in sync with image builds.

Signed-off-by: Stephen Augustus<EMAIL_ADDRESS>Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?

- Dockerfile: Use an explicit go version (go1.16.7) for image building

  Using a `latest` tag in general, but specifically for Golang-based
  images will eventually lead to unexpected variance in our image builds.

  Here we pull an explicit go version and add an entry for it in
  `dependencies.yaml`.

  This commit also adds a dependency entry for the go major version in
  `go.mod`, to ensure it stays in sync with image builds.

/assign @saschagrunert @cpanato @puerco
cc: @kubernetes-sigs/release-engineering