[SPARK-33415][PYTHON][SQL] Don't encode JVM response in Column.repr

What changes were proposed in this pull request?

Removes encoding of the JVM response in pyspark.sql.column.Column.__repr__.
Why are the changes needed?

API consistency and improved readability of the expressions.
Does this PR introduce any user-facing change?

Before this change
col("abc")
col("wąż")

result in
Column<b'abc'>
Column<b'w\xc4\x85\xc5\xbc'>

After this change we'll get
Column<'abc'>
Column<'wąż'>

How was this patch tested?

Existing tests and manual inspection.

cc @davies (current behavior has been introduced with https://github.com/apache/spark/pull/4645, so I'd appreciate if you take a look and let me know if you have any feedback. TIA)

Test build #130892 has started for PR 30322 at commit 49543e8.

Why WIP? btw, could you add tests?

Test build #130892 has finished for PR 30322 at commit 49543e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130892/
Test PASSed.

Test build #130893 has started for PR 30322 at commit 88f0c50.

Test build #130893 has finished for PR 30322 at commit 88f0c50.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130893/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35498/

Test build #130894 has started for PR 30322 at commit ec72805.

Why WIP?

Just out of habit after working on docs.

btw, could you add tests?

Of course, done.

Test build #130894 has finished for PR 30322 at commit ec72805.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130894/
Test PASSed.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35498/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35498/
Test FAILed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35499/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35500/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35499/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35499/
Test PASSed.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35500/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35500/
Test FAILed.

Let me merge this in for now as this PR fixes what it aims.
Merged to master.

Thanks everyone!


Add more granular coverage

Structure the coverage model around features:

legal/illegal CTRL combinations
reserved values
legal/illegal KEEP_* combinations (needs state)

Fixed with #11


Remote video is no not displaying on Chrome 69 of Window 10 and Safari of iPad 11.4.1

I am able to run the example Step-8 on browsers of Linux computer. But the remote video is not displaying when I run this example between Google-chrome 69 of Window 10(Desktop) and Safari of iPad 11.4.1.
It displays only local stream not remote stream. However each user has getting remote stream and when I debug this stream, it has the property muted with true value. While in demo-working case, it has value false.
Following is the screen shot of remote media stream when video is not displaying.
Remote Media stream

+1

It is getting weirder over here:

As you can see in the screenshot, in the top line, there is stated the muted is false, but when unfold the object, it says it's true?!

Same issue here.
It works between Chrome for Android & Firefox 63.0.3 for Windows 7, but not between Chrome for Android and Chrome 70.0.3538.102 for Windows 7.
The track is also muted as @Timdenouden1 describes it.

same issue.
chrome 70 or chrome 71 on windows 10

Does anyone have a resolution to this?
I have found that Chrome does not always display the remote video, even when there is a remote stream from the peer. I also find, sometimes, that when right-clicking where the video element is, there is a "Show Controls" object which, when you press play, will start the stream.
With that said, I have tried calling .play() directly from JavaScript on the video element, as well as setting the autoPlay (I'm using React, so it's autoPlay, not autoplay) attribute.
Any ideas about why this may be happening? It works in Firefox, and I do have a video track which I can see in the console.

Me too getting the same .. Any hint on this.. ?
Received Media stream in On Track event and atached to video element but .. video not getting displayed :(

@shivarajnaidu
I ended up developing my own WebRTC solution, so I'm not completely sure what the issue is here.
If you want, I could throw you together a React Solution with a Node.js backend for Signaling that does work and that does display the remote stream in Chrome, but I'm not sure what the timeline would be for that.
For now, ensure that, for the video element, autoplay is true, muted is true, and playsInline is true.

Thank You for quick reply @JamieCorkhill

If you want, I could throw you together a React Solution with a Node.js backend for Signaling that does work and that does display the remote stream in Chrome, but I'm not sure what the timeline would be for that.

Really in needful situation .. Will be very helpful for me, if you can share working codebase to play
around
Really thanks @JamieCorkhill

@shivarajnaidu I'll try and put something together for you this weekend.

Hey, I am very intrested in your react-node implementation of livestream. Could we get a repo link or something?

For Step-05
I tunneled my localhost server through ngrok for https .
I could successfully establish peer connection (video exchange) between my
PC (Chrome v75+ on Ubuntu ) and Phone (Chrome on Android ) on the same wifi network.
I can see both local and remote video streams.
But on different network peers seemed to get connect but remote video can not be shown.
Only local video is there.
Any suggestions ?

Any updated on that issue?
We having this issue too.

Same here. Any updates?
It works fine in Firefox, but remote video not displaying in Chrome.
I have the "muted", "autoplay", and "playsinline" attributes on the video element.
If I go to chrome://webrtc-internals/ and look at RTCMediaStreamTrack_receiver, I can see the video data coming in with the correct bitrate and framerate. However, as the frame count climbs I notice that framesDropped remains equal to framesReceived... it's as though it is dropping every frame.

Finally I understood the main problem regarding the remote video.
There can be 3 type of connection.
For local network host is used. Does not need to config turn or stun for this.

Host - (This happens on the same network e.g. same wifi)
For remote video you must need to add and configure stun or turn server.
While creating RTCPeerConnection use stun and turn config.

`
var pcConfig = {
'iceServers': [
{'urls': 'stun:stun.l.google.com:19302'},
{"urls":"turn:numb.viagenie.ca"<EMAIL_ADDRESS>"credential":"muazkh"}
]
};
pc = new RTCPeerConnection(pcConfig);
`

Reflexive - ( This connection needs stun server configuration. This connection is used if your network is reflexive compatible.   Test from here )

Relay - (This connection needs turn server configuration. You need to implement your own turn server or use any turn service. In the example above a kindhearted fellow provided this test turn server. )

Most of the time  wrong configuration of RTCPeerConnection is the one to blame.

I'm also having a similar issue

Similar issue

Yes. If we use in seperate network, we must use stun or turn server

This issue has been bothering me for a long time. I have tried many ways but I can't,what can I do something!

I was also stucked in the same issue for couples of days. According to my search, from chrome version 66+ on, before any real user's interaction with the browser, if the video is not muted, the remote stream will not display, although you have received stream data from the server. The following codes work as expected in most time during my test:
//Create html stuff
const div = document.createElement("div");
video = document.createElement("video");
//Set id
div.id = stream.id;

//Set video source
video.srcObject = stream;

//Play it
video.autoplay = true;
video.playsInline = true;
video.muted = true;

This worked for me. Thanks Liu

I was also stucked in the same issue for couples of days. According to my search, from chrome version 66+ on, before any real user's interaction with the browser, if the video is not muted, the remote stream will not display, although you have received stream data from the server. The following codes work as expected in most time during my test:
//Create html stuff
const div = document.createElement("div");
video = document.createElement("video");
//Set id
div.id = stream.id;

//Set video source
video.srcObject = stream;

//Play it
video.autoplay = true;
video.playsInline = true;
video.muted = true;

This worked for me. Thanks @liufanghua2012

You need a SSL certificate in the server to get remote stream.

Another reason why your remote video wouldn't play is because you are not connected to the internet.

I was also stucked in the same issue for couples of days. According to my search, from chrome version 66+ on, before any real user's interaction with the browser, if the video is not muted, the remote stream will not display, although you have received stream data from the server. The following codes work as expected in most time during my test:
//Create html stuff
const div = document.createElement("div");
video = document.createElement("video");
//Set id
div.id = stream.id;

//Set video source
video.srcObject = stream;

//Play it
video.autoplay = true;
video.playsInline = true;
video.muted = true;

This one worked for me thanks

I was also stucked in the same issue for couples of days. According to my search, from chrome version 66+ on, before any real user's interaction with the browser, if the video is not muted, the remote stream will not display, although you have received stream data from the server. The following codes work as expected in most time during my test:
//Create html stuff
const div = document.createElement("div");
video = document.createElement("video");
//Set id
div.id = stream.id;

//Set video source
video.srcObject = stream;

//Play it
video.autoplay = true;
video.playsInline = true;
video.muted = true;

This solution is worked for me.

I made the mistake of not reading the instructions all the way through and assumed I should have been seeing both the local stream and the remote stream on the one and only tab I had opened.  Recall in a previous signaling exercise that additional tabs had to be opened to see the number of clients increase.  The first tab opened in this case is the initiator and does not have any remote clients to send the local stream to until a separate tab or window is opened.

The code is working as is for me.  Running Chrome 86 on Windows 10.

Hi All,
First time I am working on webRTC technology.
I developed webRTC app using Socket.io, Express, ejs, uuid, nodemon and peerjs libraries.
But I am facing same issue like other tab/browser video is not displaying on both directions. I tried all the above combinations but no luck. Kindly help me if anyone had experienced and got a fix. Thank you..

We can't help if you don't state the problem explicitly
On Thu, Dec 3, 2020, 5:10 PM rbhavanasi402<EMAIL_ADDRESS>wrote:

Hi All,
First time I am working on webRTC technology.
I developed webRTC app using Socket.io, Express, ejs, uuid, nodemon and
peerjs libraries.
But I am facing same issue like other tab/browser video is not displaying
on both directions. I tried all the above combinations but no luck. Kindly
help me if anyone had experienced and got a fix. Thank you..
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/googlecodelabs/webrtc-web/issues/91#issuecomment-738108457,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3QHHXKIHJ7HUWPDSYYQHLSS62AJANCNFSM4FUTUMTA
.

zoomvideochatclone.zip
Here is the exact code what i tried but problem i am facing when i open my crome browser localhost:3000 i can able to see my video is coming. But when I tried to open same url with the same uuid generated user id on different crome window/tab i am able to see only my one video on both browsers. Ideally in this case it has to treat as two users connected for the same Peer room and both browsers has to display two videos. My chrome version is  Version 87.0.4280.66 on Windows 10.
Thank you..

We can't help if you don't state the problem explicitly
…
On Thu, Dec 3, 2020, 5:10 PM rbhavanasi402 @.***> wrote: Hi All, First time I am working on webRTC technology. I developed webRTC app using Socket.io, Express, ejs, uuid, nodemon and peerjs libraries. But I am facing same issue like other tab/browser video is not displaying on both directions. I tried all the above combinations but no luck. Kindly help me if anyone had experienced and got a fix. Thank you.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3QHHXKIHJ7HUWPDSYYQHLSS62AJANCNFSM4FUTUMTA .

zoomvideochatclone.zip
Here is the exact code what i tried but problem i am facing when i open my crome browser localhost:3000 i can able to see my video is coming. But when I tried to open same url with the same uuid generated user id on different crome window/tab i am able to see only my one video on both browsers. Ideally in this case it has to treat as two users connected for the same Peer room and both browsers has to display two videos. My chrome version is Version 87.0.4280.66 on Windows 10.
Thank you..

For security reasons please put your code on codesandbox and paste the link
here, I'll look into it asap
On Thu, Dec 3, 2020, 5:59 PM rbhavanasi402<EMAIL_ADDRESS>wrote:

We can't help if you don't state the problem explicitly
… <#m_-2642428576720539058_>
On Thu, Dec 3, 2020, 5:10 PM rbhavanasi402 @.***> wrote: Hi All, First
time I am working on webRTC technology. I developed webRTC app using
Socket.io, Express, ejs, uuid, nodemon and peerjs libraries. But I am
facing same issue like other tab/browser video is not displaying on both
directions. I tried all the above combinations but no luck. Kindly help me
if anyone had experienced and got a fix. Thank you.. — You are receiving
this because you commented. Reply to this email directly, view it on GitHub
<#91 (comment)
https://github.com/googlecodelabs/webrtc-web/issues/91#issuecomment-738108457>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3QHHXKIHJ7HUWPDSYYQHLSS62AJANCNFSM4FUTUMTA
.
zoomvideochatclone.zip
https://github.com/googlecodelabs/webrtc-web/files/5637624/zoomvideochatclone.zip
Here is the exact code what i tried but problem i am facing when i open my
crome browser localhost:3000 i can able to see my video is coming. But when
I tried to open same url with the same uuid generated user id on different
crome window/tab i am able to see only my one video on both browsers.
Ideally in this case it has to treat as two users connected for the same
Peer room and both browsers has to display two videos. My chrome version is
Version 87.0.4280.66 on Windows 10.
Thank you..
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/googlecodelabs/webrtc-web/issues/91#issuecomment-738138815,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3QHHXW6753QEMSDJIHEKDSS67XRANCNFSM4FUTUMTA
.

For security reasons please put your code on codesandbox and paste the link here, I'll look into it asap
…
On Thu, Dec 3, 2020, 5:59 PM rbhavanasi402 @.> wrote: We can't help if you don't state the problem explicitly … <#m_-2642428576720539058_> On Thu, Dec 3, 2020, 5:10 PM rbhavanasi402 @.> wrote: Hi All, First time I am working on webRTC technology. I developed webRTC app using Socket.io, Express, ejs, uuid, nodemon and peerjs libraries. But I am facing same issue like other tab/browser video is not displaying on both directions. I tried all the above combinations but no luck. Kindly help me if anyone had experienced and got a fix. Thank you.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#91 (comment) <#91 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3QHHXKIHJ7HUWPDSYYQHLSS62AJANCNFSM4FUTUMTA . zoomvideochatclone.zip https://github.com/googlecodelabs/webrtc-web/files/5637624/zoomvideochatclone.zip Here is the exact code what i tried but problem i am facing when i open my crome browser localhost:3000 i can able to see my video is coming. But when I tried to open same url with the same uuid generated user id on different crome window/tab i am able to see only my one video on both browsers. Ideally in this case it has to treat as two users connected for the same Peer room and both browsers has to display two videos. My chrome version is Version 87.0.4280.66 on Windows 10. Thank you.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3QHHXW6753QEMSDJIHEKDSS67XRANCNFSM4FUTUMTA .

Please find below codesandbox link.
https://codesandbox.io/s/nice-monad-zgv47

Are you sure you are joining the correct room, from what I see, every
request to / redirects to some other room with a new uuid, did you see
that??
On Thu, Dec 3, 2020, 6:28 PM rbhavanasi402<EMAIL_ADDRESS>wrote:

For security reasons please put your code on codesandbox and paste the
link here, I'll look into it asap
… <#m_-6283667540354067635_>
On Thu, Dec 3, 2020, 5:59 PM rbhavanasi402 @.> wrote: We can't help if
you don't state the problem explicitly … <#m_-2642428576720539058_> On Thu,
Dec 3, 2020, 5:10 PM rbhavanasi402 @.> wrote: Hi All, First time I am
working on webRTC technology. I developed webRTC app using Socket.io,
Express, ejs, uuid, nodemon and peerjs libraries. But I am facing same
issue like other tab/browser video is not displaying on both directions. I
tried all the above combinations but no luck. Kindly help me if anyone had
experienced and got a fix. Thank you.. — You are receiving this because you
commented. Reply to this email directly, view it on GitHub <#91
https://github.com/googlecodelabs/webrtc-web/issues/91 (comment) <#91
(comment)
https://github.com/googlecodelabs/webrtc-web/issues/91#issuecomment-738108457>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3QHHXKIHJ7HUWPDSYYQHLSS62AJANCNFSM4FUTUMTA
. zoomvideochatclone.zip
https://github.com/googlecodelabs/webrtc-web/files/5637624/zoomvideochatclone.zip
Here is the exact code what i tried but problem i am facing when i open my
crome browser localhost:3000 i can able to see my video is coming. But when
I tried to open same url with the same uuid generated user id on different
crome window/tab i am able to see only my one video on both browsers.
Ideally in this case it has to treat as two users connected for the same
Peer room and both browsers has to display two videos. My chrome version is
Version 87.0.4280.66 on Windows 10. Thank you.. — You are receiving this
because you commented. Reply to this email directly, view it on GitHub <#91
(comment)
https://github.com/googlecodelabs/webrtc-web/issues/91#issuecomment-738138815>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3QHHXW6753QEMSDJIHEKDSS67XRANCNFSM4FUTUMTA
.
Please find below codesandbox link.
https://codesandbox.io/s/nice-monad-zgv47
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/googlecodelabs/webrtc-web/issues/91#issuecomment-738162267,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3QHHX3C3AR5MZLBCHYJB3SS7DCTANCNFSM4FUTUMTA
.

Are you sure you are joining the correct room, from what I see, every request to / redirects to some other room with a new uuid, did you see that??
…
On Thu, Dec 3, 2020, 6:28 PM rbhavanasi402 @.*> wrote: For security reasons please put your code on codesandbox and paste the link here, I'll look into it asap … <#m_-6283667540354067635_> On Thu, Dec 3, 2020, 5:59 PM rbhavanasi402 @.> wrote: We can't help if you don't state the problem explicitly … <#m_-2642428576720539058_> On Thu, Dec 3, 2020, 5:10 PM rbhavanasi402 @.> wrote: Hi All, First time I am working on webRTC technology. I developed webRTC app using Socket.io, Express, ejs, uuid, nodemon and peerjs libraries. But I am facing same issue like other tab/browser video is not displaying on both directions. I tried all the above combinations but no luck. Kindly help me if anyone had experienced and got a fix. Thank you.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#91 <#91> (comment) <#91 (comment) <#91 (comment)>>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3QHHXKIHJ7HUWPDSYYQHLSS62AJANCNFSM4FUTUMTA . zoomvideochatclone.zip https://github.com/googlecodelabs/webrtc-web/files/5637624/zoomvideochatclone.zip Here is the exact code what i tried but problem i am facing when i open my crome browser localhost:3000 i can able to see my video is coming. But when I tried to open same url with the same uuid generated user id on different crome window/tab i am able to see only my one video on both browsers. Ideally in this case it has to treat as two users connected for the same Peer room and both browsers has to display two videos. My chrome version is Version 87.0.4280.66 on Windows 10. Thank you.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#91 (comment) <#91 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3QHHXW6753QEMSDJIHEKDSS67XRANCNFSM4FUTUMTA . Please find below codesandbox link. https://codesandbox.io/s/nice-monad-zgv47 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3QHHX3C3AR5MZLBCHYJB3SS7DCTANCNFSM4FUTUMTA .

I followed the below blog to implement this POC. Yes there is a / redirect in case of only if there is no room id in the URL.
But in this case for the first browser i use localhost:3000 url. This will do go to / redirect and create an uuid as a room id.
I am copying the same URL along with uuid generated room id and joining from different same browser window/tab. So even users are different but both are using the same room id. So ideally both browsers should get two videos displaying.
https://codingshiksha.com/javascript/build-zoom-clone-video-chat-web-app-in-node-js-express-and-socket-io-using-webrtc-and-peerjs-library/

Are you sure you are joining the correct room, from what I see, every request to / redirects to some other room with a new uuid, did you see that??
…
On Thu, Dec 3, 2020, 6:28 PM rbhavanasi402 @.*__> wrote: For security reasons please put your code on codesandbox and paste the link here, I'll look into it asap … <#m_-6283667540354067635_> On Thu, Dec 3, 2020, 5:59 PM rbhavanasi402 @.> wrote: We can't help if you don't state the problem explicitly … <#m-2642428576720539058_> On Thu, Dec 3, 2020, 5:10 PM rbhavanasi402 @._> wrote: Hi All, First time I am working on webRTC technology. I developed webRTC app using Socket.io, Express, ejs, uuid, nodemon and peerjs libraries. But I am facing same issue like other tab/browser video is not displaying on both directions. I tried all the above combinations but no luck. Kindly help me if anyone had experienced and got a fix. Thank you.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#91 <#91> (comment) <#91 (comment) <#91 (comment)>>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3QHHXKIHJ7HUWPDSYYQHLSS62AJANCNFSM4FUTUMTA . zoomvideochatclone.zip https://github.com/googlecodelabs/webrtc-web/files/5637624/zoomvideochatclone.zip Here is the exact code what i tried but problem i am facing when i open my crome browser localhost:3000 i can able to see my video is coming. But when I tried to open same url with the same uuid generated user id on different crome window/tab i am able to see only my one video on both browsers. Ideally in this case it has to treat as two users connected for the same Peer room and both browsers has to display two videos. My chrome version is Version 87.0.4280.66 on Windows 10. Thank you.. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#91 (comment) <#91 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3QHHXW6753QEMSDJIHEKDSS67XRANCNFSM4FUTUMTA . Please find below codesandbox link. https://codesandbox.io/s/nice-monad-zgv47 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH3QHHX3C3AR5MZLBCHYJB3SS7DCTANCNFSM4FUTUMTA .

I followed the below blog to implement this POC. Yes there is a / redirect in case of only if there is no room id in the URL.
But in this case for the first browser i use localhost:3000 url. This will do go to / redirect and create an uuid as a room id.
I am copying the same URL along with uuid generated room id and joining from different same browser window/tab. So even users are different but both are using the same room id. So ideally both browsers should get two videos displaying.
https://codingshiksha.com/javascript/build-zoom-clone-video-chat-web-app-in-node-js-express-and-socket-io-using-webrtc-and-peerjs-library/

Fixed this issue by adding setTimeout with 3 seconds.
socket.on('user-connected', userId => {
// user is joining
setTimeout(() => {
// user joined
connectToNewUser(userId, stream)
}, 3000)
})

So you are good to go yh??
On Thu, Dec 3, 2020, 8:50 PM rbhavanasi402<EMAIL_ADDRESS>wrote:

Are you sure you are joining the correct room, from what I see, every
request to / redirects to some other room with a new uuid, did you see
that??
… <#m_-4762679264381518536_>
On Thu, Dec 3, 2020, 6:28 PM rbhavanasi402 @.__> wrote: For security
reasons please put your code on codesandbox and paste the link here, I'll
look into it asap … <#m_-6283667540354067635_> On Thu, Dec 3, 2020, 5:59 PM
rbhavanasi402 @.> wrote: We can't help if you don't state the problem
explicitly … <#m*-2642428576720539058_> On Thu, Dec 3, 2020, 5:10 PM
rbhavanasi402 @._> wrote: Hi All, First time I am working on webRTC
technology. I developed webRTC app using Socket.io, Express, ejs, uuid,
nodemon and peerjs libraries. But I am facing same issue like other
tab/browser video is not displaying on both directions. I tried all the
above combinations but no luck. Kindly help me if anyone had experienced
and got a fix. Thank you.. — You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#91
https://github.com/googlecodelabs/webrtc-web/issues/91 <#91
https://github.com/googlecodelabs/webrtc-web/issues/91> (comment) <#91
https://github.com/googlecodelabs/webrtc-web/issues/91 (comment) <#91
(comment)
https://github.com/googlecodelabs/webrtc-web/issues/91#issuecomment-738108457>>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3QHHXKIHJ7HUWPDSYYQHLSS62AJANCNFSM4FUTUMTA
. zoomvideochatclone.zip
https://github.com/googlecodelabs/webrtc-web/files/5637624/zoomvideochatclone.zip
Here is the exact code what i tried but problem i am facing when i open my
crome browser localhost:3000 i can able to see my video is coming. But when
I tried to open same url with the same uuid generated user id on different
crome window/tab i am able to see only my one video on both browsers.
Ideally in this case it has to treat as two users connected for the same
Peer room and both browsers has to display two videos. My chrome version is
Version 87.0.4280.66 on Windows 10. Thank you.. — You are receiving this
because you commented. Reply to this email directly, view it on GitHub <
#91 https://github.com/googlecodelabs/webrtc-web/issues/91 (comment) <#91
(comment)
https://github.com/googlecodelabs/webrtc-web/issues/91#issuecomment-738138815>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3QHHXW6753QEMSDJIHEKDSS67XRANCNFSM4FUTUMTA
. Please find below codesandbox link.
https://codesandbox.io/s/nice-monad-zgv47 — You are receiving this
because you commented. Reply to this email directly, view it on GitHub <#91
(comment)
https://github.com/googlecodelabs/webrtc-web/issues/91#issuecomment-738162267>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3QHHX3C3AR5MZLBCHYJB3SS7DCTANCNFSM4FUTUMTA
.
I followed the below blog to implement this POC. Yes there is a / redirect
in case of only if there is no room id in the URL.
But in this case for the first browser i use localhost:3000 url. This will
do go to / redirect and create an uuid as a room id.
I am copying the same URL along with uuid generated room id and joining
from different same browser window/tab. So even users are different but
both are using the same room id. So ideally both browsers should get two
videos displaying.
https://codingshiksha.com/javascript/build-zoom-clone-video-chat-web-app-in-node-js-express-and-socket-io-using-webrtc-and-peerjs-library/
Fixed this issue by adding setTimeout with 3 seconds.
socket.on('user-connected', userId => {
// user is joining
setTimeout(() => {
// user joined
connectToNewUser(userId, stream)
}, 3000)
})
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/googlecodelabs/webrtc-web/issues/91#issuecomment-738264990,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH3QHHWXTLL3TPNR64B3JR3SS7TZBANCNFSM4FUTUMTA
.

Hi,
This simple example do not work anymore too : https://webrtc.github.io/samples/src/content/capture/video-video/

You need a SSL certificate in the server to get remote stream.

Can you please explain? I have deployed a video chat app on heroku but I don't get remote stream. My heroku app doesn't have ssl certificate

You need a SSL certificate in the server to get remote stream.

Can you please explain? I have deployed a video chat app on heroku but I don't get remote stream. My heroku app doesn't have ssl certificate

Thank You for quick reply @JamieCorkhill

If you want, I could throw you together a React Solution with a Node.js backend for Signaling that does work and that does display the remote stream in Chrome, but I'm not sure what the timeline would be for that.

Really in needful situation .. Will be very helpful for me, if you can share working codebase to play
around
Really thanks @JamieCorkhill

Did you ever get this running? Would you comment what you did? Thanks.

Hi,
I am new to web rtc and stuck at a point, I have successfully deployed webrtc app on ec2 instance AWS. Fot HTTPS I used NLB. I have also open the port for instance and for NLB for tcp and udp.  When I tried to test it, its working fine on the same network but when I tried to test with remote people with remote location, It shows no video, however I can see remote stream added but still video wont come.
I have tries using stun server of goolge and also used free turn server as well as paid turn server but nothing happens. On the same network everything is working fine even I can see bandwidth consumption from paid turn server but when I want it with remote people and with different network, I can not see any video.
I am struggling on this from past few days and seriously need help on this.

Does anyone have a resolution to this?
I have found that Chrome does not always display the remote video, even when there is a remote stream from the peer. I also find, sometimes, that when right-clicking where the video element is, there is a "Show Controls" object which, when you press play, will start the stream.
With that said, I have tried calling .play() directly from JavaScript on the video element, as well as setting the autoPlay (I'm using React, so it's autoPlay, not autoplay) attribute.
Any ideas about why this may be happening? It works in Firefox, and I do have a video track which I can see in the console.

Hey @JamieCorkhill !
I am also facing this issue, I have tried all the above solutions already, but none of them worked. Although, how you said that the video starts playing when you click play, my video doesn't start even then. Everything else matches though, my local video has muted: false, and remote video has muted: true.
It's been quite a few years since this issue had been raised, I hope it's still active 😅

it only loads but does not display the video
help me!!!


tests: Move out some fns from tests/utis that used only in one place

What this PR does
This PR moves out some functions that are being used only in one place from tests/utils to the file they are used at.
Before this PR:
After this PR:

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-storage

/sig code-quality

/approve


Images get Shrinked for almost 2 seconds

When menu is opened, images in the menu controller gets shrinked for almost 2 seconds

@ajsagar92 Hi! Thank you for report. Can you give more information about this bug?


Cannot craft vanilla trapped chest

When playing a vanilla chest and a tripwire into the crafting table nothing happens.

It also only shows an empty crafting table, when checking for the vanilla trapped chest recipe

Edit:
it seems to be working with your chest variants, at least with the oak chest as seen here:

Edit 2:
The Oak Trapped Chest only turns into a normal vanilla chest not into a vanilla trapped chest as one would expect:

thats good to know, will fix it in 1.5.1
thanks

1.20.1
you can recreate this problem easily..

fixed in 1.5.1


Cannot git init

This seems to be related to a recent update.
$ mkdir /var/tmp/testrepo

$ cd /var/tmp/testrepo

$ git init
⛔ Could not get git directory.
   -> errors:
   ✗  Command failed: 'git ["rev-parse" "--absolute-git-dir"]' [cwd: '/var/tmp/testrepo', env: [], err: 'fatal: not a git repository: '/var/tmp/testrepo/.git'
     '].
   ✗  exit status 128
⛔ Fatal error -> Abort.
⛔ Could not get git directory.
   -> errors:
   ✗  Command failed: 'git ["rev-parse" "--absolute-git-dir"]' [cwd: '/var/tmp/testrepo', env: [], err: 'fatal: not a git repository: '/var/tmp/testrepo/.git'
     '].
   ✗  exit status 128
⛔ Fatal error -> Abort.
fatal: ref updates aborted by hook

This creates a half-created broken .git subdirectory:
$ tree .git
.git
├── config
├── hooks
│   ├── applypatch-msg
│   ├── commit-msg
│   ├── githooks-contains-run-wrappers
│   ├── post-applypatch
│   ├── post-checkout
│   ├── post-commit
│   ├── post-index-change
│   ├── post-merge
│   ├── post-receive
│   ├── post-rewrite
│   ├── post-update
│   ├── pre-applypatch
│   ├── pre-auto-gc
│   ├── pre-commit
│   ├── pre-merge-commit
│   ├── prepare-commit-msg
│   ├── pre-push
│   ├── pre-rebase
│   ├── pre-receive
│   ├── push-to-checkout
│   ├── reference-transaction
│   ├── sendemail-validate
│   └── update
└── refs
    ├── heads
    └── tags

5 directories, 24 files

$ git status
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

This seems to be triggered by ~/.githooks/release/githooks/git/gitcommon.go, i.e. git(x).GetGitDirWorktree() (https://github.com/gabyx/Githooks/blob/main/githooks/git/gitcommon.go#L113).
This being called on a repo as part of initialization will (and does, as seen) fail.

@nf-brentsaner : This seems to be an issue in Githooks with Git 2.46, I need to find out what git init does, which hook it triggers and then somehow fix it.

Maybe you can add also some more info: Can you run:
GITHOOKS_LOG_LEVEL=debug git init
# or
export GITHOOKS_LOG_LEVEL=debug
git init

Maybe you can add also some more info: Can you run:
GITHOOKS_LOG_LEVEL=debug git init
# or
export GITHOOKS_LOG_LEVEL=debug
git init

of course, would be glad to- give me about 30m-1h when i'll be back at my keyboard.

@nf-brentsaner : Ok, it seems that reference-transaction hook runs on git init and inside the hook a git rev-parse --git-dir does not work althoug the GIT_DIR variable is defined AND the docs says the git rev-parse --git-dir command reads $GIT_DIR if defined. This is sad. So I probably have to workaround this, by first looking at GIT_DIR myself.
Maybe report this upstream.

@nf-brentsaner :  Fast fix: Disable reference-transaction with git hooks installer --maintained-hooks "all,!reference-transaction" ... OR do not use --centralized, which will not run hooks on git init (since you have no global core.hooksPath set).

Just checking in (...it took a bit longer than an hour to get back to my keyboard, heh),
I've just tried 3.0.3 and I wanted to confirm the issue is fixed for me, looks like you nailed it. Thank you for being so responsive and fixing it so quickly!


File routes and dataset thread

Replaced by https://github.com/hubmapconsortium/ingest-api/pull/254


IE 11 not getting interceptor

this may not be an issue with the code in this package but i am putting a message here in case anyone knows what this is and how to fix it.
i have an app that is working 100% in chrome and Edge.
basic page load works in IE 11
web service calls that need a JWT fail.
IE 11 is not giving any errors during the app load.
the app is using the current angualr 4.xxx packages and is built with angualr-cli  into packed scripts.
i am trying to determine the cause but right now i have no idea what the real problem is.

I guess to have a better idea of why and where it is happening is to put some console logging down the Observable chain (before appending headers).
You might also look into .catch() observable operators used along the way - maybe somewhere you suppressing an error and so it not visible.
Also if you can provide a plunkr that would be great because I've used this lib in IE11 as well and it was working fine so maybe you have some special use case.

what i have found so far is this:
the script runs that is adding the header in the browser.
Fiddler trace shows that the header is not present.
happens (as far as i can tell) when the code is from localhost / debug or my loading the app from a server.
i have code in app.component  constructor that sets up the interceptor
constructor(         private route: ActivatedRoute,         private router: Router,         private authService: AuthService,          private menuService:  MenuDataService ,         private http: Http,         private httpInterceptor: HttpInterceptorService,         ) { 			httpInterceptor.request().addInterceptor((data, method) => {                  const headers = getHttpHeadersOrInit(data, method); // Get or create header and set back ondata                  console.log("AppComponent  this.authService ", this.authService );                  console.log("AppComponent  this.authService.loggedIn ", this.authService.loggedIn );                  if( this.authService.loggedIn ){                     console.log("AppComponent  this.authService ", this.authService );                    console.log("AppComponent  this.authService.currentUser ", this.authService.currentUser);                      if( this.authService.currentUser ){                          headers.append('Authorization', this.authService.currentUser.token_type + " " + this.authService.currentUser.access_token);                           console.log("token " , this.authService.currentUser.token_type + " " + this.authService.currentUser.access_token );                      }                   }                   console.log(method, data);                   return data;              }); }
the console.log calls all look normal in IE 11, no error other than the 401 result.
I will take a second look tomrrow and see if i can get more details.

I may have this figured out, will need to setup a test today and see what happens.
has to do with how chrome and edge do the OPTIONS call.
but IE 11 I do not see that call.
then i got to thinking about old web sites and that i have seen the header "WWW-Authenticate" in the past.
possibly IE 11 is looking for that stuff before it will send the token to the server ??

i added the www-auth header and no change.
i thought that my not sending that header was the problem but it does not seem to make a difference.

Well I can only suggest you to create a plunkr so I can have a look.

will see what i can do,   my app has multiple servers and is inside a private network, so a little complicated for me to replicate.
is there a token server that i can test against ??  i will see if i can find one...

Maybe if you have different servers most probably they are on other domain and if so you have to deal with CORS policy where server should tell which headers it allows client to send.
I'm not sure how exactly CORS are implemented in IE11 but it might just remove some headers silently...

that is part of what i suspect is happening.....   i am checking for what is going on and  making a small test case, i did find an oath test server i may be able to use and test with. will let you know when i have more info.

i am trying to make a working plunk for IE but having some issues.
it works in chrome but hangs in IE due to some missing poly fill or something.
https://plnkr.co/edit/MX7j8Brm0tzQEVKzMCAs
i hard coded a token that works right now and pointed the code to my service.
if you can make this work in IE 11  try any service that needs a token....

ok so i am fail at plunker ....
here is a link:
https://github.com/figuerres/ie11test
angualr cli - current packages.
i can update the token a few times if you want to test with my service....
the project loads and runs in chrome and in IE 11 , but in IE 11 it fails to get the data with a 401 status as the token is never sent to the web service.
almost no code; just trying to add the auth header.

simple jquery works, so something in the angular / typescript seems to be failing.
kind of thought so but just tested to see what happens.
i wonder if there is a change in the angular http that breaks on IE 11 ?

I will have a look to your plukr later. Regarding angular's http library it's unlikely that something is breaking in I because they are testing angular in saucelabs in IE as well so...

thanks, i am going to try and see if i can figure out any more, i saw that the code to add the header was called in IE in my angular cli project   so possibly the proxy ??
or in IE 11 something is not initialized right ??

i did a test of some code and i found this, not much but it might help:
if i use your library to watch the traffic but not modify the headers and i make an http post and add my own RequestOptions object with the header that works.
when i add a header with the .....  i think i found something .....

wow ok this is nuts and now i have to figure out how to bet handle this.....
IE 11  seems to need to have the http request options set or it fails.
this has not been a problem with chrome or with edge!
in my githhub code i added
var options = new RequestOptions({   withCredentials:true });
and then
  this.http.post( 'https://devwebservice.adldelivery.com/api/SSRS/ListItemTypes','',options).subscribe(r => this.res = r.text());
and it works!!
i will take a look at your code and see if i can do that in the interceptor setup.... or if some other thing needs to be done.

works in a test case but not in my actual app code....  no idea why that is happening now.

Ah, of course you have to set that flag, because you trying to send authorization headers. According to MDN:
The XMLHttpRequest.withCredentials property is a Boolean that indicates whether or not cross-site Access-Control requests should be made using credentials such as cookies, authorization headers or TLS client certificates. Setting withCredentials has no effect on same-site requests.
So it shouldn't had been working even in chrome... A bug?!
Anyway you can set withCredentials flag from the interceptor, you can use some helper function to get Options from data and then set the flag.

you may be right!
i just knew that the app had been working for me with chrome and we have been testing IE 11 to get ready for a limited test release to dogfood some of the work we have so far....
and then i started down this rabbit hole ....
right now the main app is not working and i am going between the test code and the main app code and checking them.
there may be a package having a side effect in the main app code.... more fun to trace down.

@gund
Hey I think i have found a very odd bug but i am not 100% sure if this is with the code or with the way IE11 handles javascript data or what.
only in IE11 do i see this happening.
if the http call starts without an Options Arg then the token is not sent to the server even though the code seems to be creating the headers collection and adding them to the options .
if i initialize the http call with an empty request options arg with nothing set then it works like it does in chrome.
something about the data[]  array / collection and modifying it going wrong on IE 11
i am looking at your code that gets the options from the array and playing with it to see if i can make it work on IE 11 .
seems odd, possibly some side effect of angualr cli ?   i do not know for sure but it is happening and it is related to the options being in the http call before the interceptor gets into it.

ok more details ....
if the http.post .  does not have options args set then the
data arguments has a size of 2   with arg 0 and arg 1  but no arg 2  for the options
in IE 11 the line  that tried to set the options is setting data[2]  but there is not data[2] in the arguments collection and arguments is not a true array and does not support slice/push/pop
on chrome it seems to allow adding an argument on the fly but on in IE 11
so the local variables are there but not added to the actual arguments that get passed back up the chain to the final call to http / ajax.
what i am doing in my code that is working in y test app and i will test this next in my main app
is to do an Array.from(data)
then i can call temp.splice(idx,0,options);
and then
data = temp
now the new options and headers are added and the call works.
so possibly this code:
https://github.com/gund/ng-http-interceptor/blob/master/src/http/helpers/getHttpHeadersOrInit.ts
// Set Options back
data[idx] = options;
should be changed to work that way ??

Interesting finding, I don't remember that I checked the type of the arguments...
They are actually coming from the Proxy here.
Can you try to log the type of arguments in request interceptor in IE?

Alright I just checked in IE and can confirm that Proxy polyfill returns Arguments Object instead of Array.
As a quick fix you can add in your request interceptor next line:
httpInterceptor.request().addInterceptor(data => Array.prototype.slice.call(data));

This will ensure that data is always Array no matter what.
This is only required if you ever going to use Proxy polyfill, so I'm not sure if I will add this piece of code to this library.
It should probably be in polyfill itself...

Crazy little detail for sure, took a bunch of tries to fully get at what was going on. At least now we know and can at least put a note in the docs for anyone who has to support ie. Also I let some folks at Microsoft know so they can also document the issue from the ie quirks side of things.
My boss was glad I was able to get it to work as we have customers still on ie 11 and Windows 7 along with some older pc in our warehouses.

Yes, I just added a note to the readme page with link to this issue.
I also forked polyfill, patched it and submitted PR back so hopefully they will merge it.
Will close this as we sort of resolved it =)


Port AI QnA tests to Xunit

Fixes #4088

@Virtual-Josh The code here looks great. Please add in the copyright headers on the new file, and take a look at the build that's failing. Once that's resolved, we can merge.


design documents

i would love to see the original design documents
-requirements

any bug logs
-any design documents used to program the program
-any mock ups and ect.

any idea if this is possible?

No, that information would not be generally release, even if it existed.  Sorry.


Ivona TTS broken

so i am still useing version VRCX 2<IP_ADDRESS> because the newer version wont run the ivona sappi1 i think it is voices, it shows there there but when i click on them they dont play, the voices work with the version im using and with my tts and also work on the website you asked me to check on before, i dont know if you are able to make it work again on the new versions but if possible, or if you know of a place to download and install a non sappi1 version so that they work? as a reminder when it comes to this stuff i am only barley smarter than a soggy napkin.

The real cause of this issue is Ivona not updating to support Microsofts new TTS API OneCore, I got it working on my PC by updating the script I made last time maybe it will work for you https://gist.github.com/Natsumi-sama/5b73622158b32ad56460865d38c7e19e

i not sure if im running that right or actually im pretty sure i have no idea , can u give quick sketchy directions?

Open Start menu
Type Powershell.exe, right click run as admin the first result
Type into the window that opens "Set-ExecutionPolicy Unrestricted"
"cd C:\Users<Username>\Downloads"
".\add-voice.ps1"

ok i tried that and still didnt work, after u run that in power shell is it supose to do something or is it supose to look like it did nothing ?? i can keep using the old version if nothing can be done

If nothing was output to the console then it run successfully, need to restart VRCX for changes to apply, this old version isn't going to work forever.

So nothing was outputted and I restarted vrcx and it still don't work, I mean I still may not be doing something right , but I can use the ivona voices in Microsoft narrator and Microsoft tts, they seem to work fine there but in vrcx when I select them they don't do anything


WebRTC support

I tested only on macOS.
It might already work on other platforms.
Is your feature request related to a problem? Please describe.
I want to use WebRTC
Describe the solution you'd like
I don't have any preference.
I just want to use WebRTC.
Describe alternatives you've considered

With system webbrowser (doesn't work on macOS)Notification.requestPermission() // => undefined
navigator.mediaDevices // => undefined

Using another process
I don't know any library to use WebRTC with VideoUI on desktop 😭

Additional context
It seems, the cause of this issue is this https://forums.developer.apple.com/thread/88052
And, the following might solve this issue on macOS (not tested).
https://bugs.webkit.org/show_bug.cgi?id=208667#c17

There are similar issues in other repositories.

https://github.com/patr0nus/DeskGap/issues/26#issuecomment-486463510
(someone mentioned "WkWebView's getUserMedia functionality is disabled, when embedded")
https://github.com/zserge/webview/issues/368

So i found these additions to the Info.plist
	<key>NSCameraUsageDescription</key>
	<string>$(PRODUCT_NAME) Requires camera access in order to capture and transmit video</string>
	<key>NSMicrophoneUsageDescription</key>
	<string>$(PRODUCT_NAME) Requires microphone access in order to capture and transmit audio</string>

https://developer.apple.com/documentation/bundleresources/information_property_list/nscamerausagedescription?language=objc
https://developer.apple.com/documentation/bundleresources/information_property_list/nsmicrophoneusagedescription?language=objc
@rajivshah3

regarding notifications @ken0x0a - we merged a cross-platform notification API: https://github.com/tauri-apps/tauri/pull/505
It will land in the next release.

I am wondering if we will have to roll our own:
https://github.com/libp2p/rust-libp2p/issues/1066

Well, I believe that our new custom protocol allows for the secure context on all platforms. Still, we have not proven this to work, so am moving this issue over to WRY for tracking there.


Lint examples

Somehow all "**/examples/**/lib/**", files got ignored by standard.js.
https://github.com/zeit/next.js/blob/canary/package.json#L49
This PR fixes all the corresponding lint issues and removes the problematic line from the linter config.

@HaNdTriX sent you a DM on spectrum.chat


The question about the normalization formula

Hi, could you tell me exactly what formula is used to normalize the image after detection for recognition?

basically nothing. still if the user wants to perfom some normalization, they can do it when they set normalization argument of verify or represent functions.
https://github.com/serengil/deepface/blob/master/deepface/commons/functions.py#L259


Add av stack split  to split last commit into a new branch

Adding new feature to split the last commit into a new branch and revert the old branch to 1 previous commit

There's another big change going on. Let me hold this until it's merged.

Noted @draftcode , thanks for the update

Some more items:

after running av stack split branch-2 we stay on branch-1, we should checkout branch-2 instead so that the user is on the correct head branch (this also resolves staged file oddities in the current setup)
we should make sure we adopt the branch so that we have it stored in av.db
at least for now I believe we're only supporting this action on the tip, so we should ensure there are no child branches so users don't end up in unexpected states

hi @draftcode @tulioz I've updated the PR as per your comments. But I think there's a conflict because of the other branch that got committed in the PR. Should I fix the conflict or you guys should do it?

@Chafid thanks for adding support for no branch name submitted, it looks really good!
To answer your question from this weekend, if you could rebase and migrate the command to av branch --split <optional-name> then this will be almost ready to merge.
Two requests still:

Adding the new branch to the aviator database (essentially av adopt --parent original-branch) so that we are tracking it in av.db
Preventing someone from running this command when not on the tip, so that they don't unexpectedly end up in a state where their stack is branching

@Chafid sorry for the delay in my response,  been a hectic week for me. You are correct we want to force tip of branch, but I think we should also enforce tip of stack. Today if a stack looks like this:
master -> first_branch -> second_branch

and someone runs the command on first branch they'll end up with
master -> first_branch -> second_branch
                      | -> third_branch

and now they have a fork to resolve, ideally we'd only want to let them run on the tip of second_branch so that their stack can only end up like this
master-> first branch -> second_branch -> third_branch

Let me know what you think!

Ah got it @tulioz . Is there already a mechanism in av to check whether the user is already on the tip stack? Or I need to figure it out myself?

Hi @tulioz , I've added the check to only split when in tip of the stack. Please check it

Hey @Chafid, there should be code in av next that does checking for being on tip of stack. I ran the same test as earlier:
av branch commit-1

echo "First commit" > commit-1.txt
git add commit-1.txt
git commit -m "commit 1"

echo "Second commit" > commit-2.txt
git add commit-2.txt
git commit -m "commit 2"
av branch --split

av switch commit-1

echo "Third commit" > commit-3.txt
git add commit-3.txt
git commit -m "commit 3"
av branch --split

av tree

and I'm still seeing the forking behavior:

Hi @tulioz , are you sure you have the latest update? It works correctly on my local
`chafid@WINDOWS-4D6659B:~/repository/test_repo$ av tree

test3
│ No pull request
│
test-2
│ No pull request
│
main (HEAD)

chafid@WINDOWS-4D6659B:~/repository/test_repo$ av switch test-2
chafid@WINDOWS-4D6659B:~/repository/test_repo$ av tree

test3
│ No pull request
│
test-2 (HEAD)
│ No pull request
│
main

chafid@WINDOWS-4D6659B:~/repository/test_repo$ av branch --split
The split operation was aborted.
branch 'test-2' has a descendant branch 'test3'
error: split failed: branch 'test-2' has a descendant branch 'test3'
chafid@WINDOWS-4D6659B:~/repository/test_repo$
`

I just double checked that I'm on latest, and it looks like I am

Just double checked and on my local test env I'm still getting the forking behavior 😞
❯ av branch --debug --split
DEBU[0000] enabled debug logging                         av_version="<dev>"
DEBU[0000] git [rev-parse --git-common-dir]              duration=10.034333ms repo=og-testing
DEBU[0000] loaded Git repo                               git_common_dir=/Users/ofergoldstein/dev/og-testing/.git
DEBU[0000] loaded config file                            config_file=/Users/ofergoldstein/dev/og-testing/.git/av/config.yaml
DEBU[0000] git [status --porcelain=v2 --branch --untracked-files]  duration=12.645417ms repo=og-testing
DEBU[0000] git [merge-base 7fbd11068742b5393d6cb0df88796e528b3bf994 cc70206ded0423ac274ef928232252b54afb687b]  duration=10.553709ms repo=og-testing
DEBU[0000] git [merge-base 7fbd11068742b5393d6cb0df88796e528b3bf994 5401d3e3e11e91a41e70723f37b484a305f5578e]  duration=9.040042ms repo=og-testing
Successfully split the last commit into a new branch commit-3.
DEBU[0000] git [symbolic-ref refs/remotes/origin/HEAD]   duration=8.332584ms repo=og-testing
DEBU[0000] git [symbolic-ref refs/remotes/origin/HEAD]   duration=7.356583ms repo=og-testing
DEBU[0000] git [merge-base commit-1 commit-3]            duration=7.308417ms repo=og-testing
DEBU[0000] command exited                                duration=89.414458ms
DEBU[0000] Skipping CLI version check (development version)

Here are my debug logs for the final split that generates the fork.

Hi @tulioz , sorry I just managed to fix this. I finally use av next to check and it should work ok on your scenario now. Please check it. Thanks


[FLOC-2300] Release notes warning

Originally done against 1.0.0 release branch.

Thanks.  Doc builder is green.  Merging.


Fix (Chips) place holder issue and focus issue

Fix (Chips) place holder issue and focus issue

This change is

@krupa310 Please rebase this PR with master


Create student.txt

School: Heilige-Drievuldigheidscollege
Website: https://www.hdc-leuven.be/
Address: Heilige-Drievuldigheidscollege, Oude Markt 28, 3000 Leuven, België
Student e-mail ends at @student.hdcleuven.be

@IngeVerbeek Thank you for your patience while waiting for a review and processing your request. Pull request merged. Thank you!


Nowadays, even if the user wants only the filename, we use library calls, to get: the absolute and relative path, we convert the time from stat to a string to get the last modification, we also get the username from the uid stat column.
This is not cool, because, the user pays with his time, for things that he does not want!
C++ has a nice idea, of:

You only pay for what you use ...

So, if the user wants only the name, and the size, we must not waste his time getting the owner, last modification, absolute and relative path.

For this, we can use bit fields.


Create project README

Create a README.md markdown file for this repository.

Issue Status: in-progress
Recent Activity
None


Add fusumaWillClosed() method to delegate.

I added an optional method fusumaWillClosed() to delegate, which will work before the FusumaViewController will be hidden. This method is good to use for updating UI.
If use fusumaClosed() for updating UI, then the changes will be visible to the user.

@shu-ua In your example update, you called the function fusumaWillClose(), as opposed to fusumaWillClosed(). FWIW, the error is actually correct. The delegate method should be called fusumaWillClose(), and ideally would be optional.


Splitting ways corrupts step_count

When a way with a value for step_count (e.g. step_count=5) is splitted, two ways are created with the same value for step_count, which leads to the total steps of both ways being doubled (two ways with step_count=5 in a row => 10 steps in total)
Simply removing tag would be better
related to  #3740
triggered by https://github.com/westnordost/StreetComplete/issues/2145 https://github.com/MarcusWolschon/osmeditor4android/issues/1251

@matkoniecz Hmm instead of removing the tag, I think iD can be smart enough here to distribute the step count proportionally to the resultant lengths. Sure it may not be 100% accurate, but it should be pretty close and it preserves the total step count.

@matkoniecz Hmm instead of removing the tag, I think iD can be smart enough here to distribute the step count proportionally to the resultant lengths. Sure it may not be 100% accurate, but it should be pretty close and it preserves the total step count.

I don't think this is a good idea. At least the user should be asked if the assumed counts are correct. There are very few stairs that need to be split at all. If one property varies so much that the way needs to be split, it is likely that the measures of the steps also vary.
We're not talking about simple stairs here, because those probably don't need to be split at all.

There are some more tags that might have a meaning for the geometry. Discussion still happening in https://github.com/westnordost/StreetComplete/issues/2145 but the following came to my mind:

capacity (f.e. bicycle parking mapped as line)
parking:lane:[left/right/both]:capacity (described as "possible enhancements" to the parking lane schema on the wiki, so not official, but I think the tagging makes sense for parking:lane:[left/right/both]=marked - for all other parking lane types the capacity could just as well be computed)

At least the user should be asked if the assumed counts are correct.

@DerDings I'm afraid most mappers won't know nor care which part has exactly how many steps. iD is meant to help non-experts contribute usable data, not perfect data. It's not ideal to estimate, but it'd be a real problem if someone goes out and surveys step counts for accessibility and then later iD discards that data entirely.

There are very few stairs that need to be split at all.

Probably, but if so then it's not worth worrying too much about this functionality.

If one property varies so much that the way needs to be split, it is likely that the measures of the steps also vary.

I'm not sure this is a fair assumption. Stairs could change in color, width, access, incline, surface, level, layer, etc., but I don't see why that would necessitate a change in spacing.

incline certainly would :-)
I tend towards deleting step_count (etc) when implementing this because once this tag is tagged wrong, it is quite unlikely that someone else will notice and correct it while of course when the tag is missing, it can be detected easily that the information is missing (by StreetComplete).

At least the user should be asked if the assumed counts are correct.

@DerDings I'm afraid most mappers won't know nor care which part has exactly how many steps. iD is meant to help non-experts contribute usable data, not perfect data. It's not ideal to estimate, but it'd be a real problem if someone goes out and surveys step counts for accessibility and then later iD discards that data entirely.

If estimating is preferred, a tag like fixme=check <key> could be added to both fragments to state that the value may be inaccurate. fixme is found by various QA tools and it's likely someone will check it. Since the whole thing were talking about is a very particular case, this won't be spammy. The tag fixme=check step_count could also be used as a trigger for resurveying step_count in StreetComplete.


chore: bump zio-prelude from 1.0.0-RC21 to 1.0.0-RC22

About this PR
📦 Updates dev.zio:zio-prelude from 1.0.0-RC21 to 1.0.0-RC22
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio", artifactId = "zio-prelude" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.zio", artifactId = "zio-prelude" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1eadd37) 67.90% compared to head (b2c7ab1) 67.90%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   67.90%   67.90%
=======================================
  Files          79       79
  Lines        1087     1087
  Branches      126      126
=======================================
  Hits          738      738
  Misses        349      349


*.notion.site Support

Blog post
Home page details

Examples

https://notion.notion.site/Notion-Official-83715d7703ee4b8699b5e659a4712dd8

I haven't seen an example public home page yet so I'm not sure how the URL works (if it updates to the full URL or stays as *.notion.site/)


[Addition]: Virtual Onyx Puma spoofing

Hotspot b58 Addresses
11hsyViz32idrBHSrX4V5rdwwQJaZB4YnyV5vCkXVcfRTS8uYhj
Discord Handle
No response
Reason(s)
Clearly spoofing... Map showes witnessing more than 300km, Activity shows he witnessed beacons over 2000km away. not in serbia. IP shows datacenter in America

Removal already requested in
https://github.com/helium/denylist/issues/2556
Please understand that requests are processed manually, and creating dozens of requests for the same hotspot may only delay the overall processing of those requests.


dapp.com dedicated column for tracking and analytics to Polkadot dapp

Grant Application
This application is (select one):

[x] Speculative (use this by default)
[ ] an RFP response

This application is (select one):

[x] Public (fully)
[ ] Public with private finances

Abstract
[Provide a brief description of your project here (summarise key points).
If your application is part of a programme, please mention which in the first line of the abstract.
The details should be in the application 'document' that you add to this repo via a pull request.]
Checklist

[x] The grants document has been read and understood.
[x] The Google Form will be completed accurately. Note that the Google Form requires the pull request URL.
[x] Abstract (above) is succinct and complete.
[x] The application is being included into the correct directory: either 'targeted' or 'speculative'.
[x] The application includes a project description.
[x] The application includes all names of team members.
[x] The application includes a description of the team's experience.
[x] The application includes all necessary links (e.g. GitHub and LinkedIn)
[x] The "Development Roadmap" section in the application has a timeline of development ("milestones").
[x] The "Development Roadmap" section in the application has an estimate of funds required.
[x] The "Development Roadmap" section gives an indication of the team's long term plans.
[x] The "Development Roadmap" section includes documentation as a deliverable for at least one milestone.

Hey @annie101101046 , I tried to email you on the email address that we have on file. I'm going to close this PR, but feel free to reach out and chat. Best email for us is<EMAIL_ADDRESS>


Django 2.2.8 -  'sql_server.pyodbc' isn't an available database backend.

Hello,
I have tried all of the available examples online to get MSSQL support for Django 2.2. It seems that people have had success. Please let me know if I am making an obvious mistake or if django 2.2 is still lacking support.
Thank you in advance.
Current versions
Windows 10
django==2.2.8
django-mssql-backend==2.5.0
pyodbc==4.0.28
Django DB Config
DATABASES = {
    'default': {
        'ENGINE': 'sql_server.pyodbc',
        # 'ENGINE': 'sqlsever_ado',
        # 'ENGINE': 'django.db.backends.mssql',
        # 'ENGINE': 'django_pyodbc',
        # 'ENGINE': 'django-pyodbc-azure',
        'NAME': 'db',
        'USER': 'sa',
        'PASSWORD': 'pw',
        'HOST': 'localhost',
        'PORT': '1433',
        'ATOMIC_REQUESTS': True,
        'OPTIONS': {
            'driver': 'ODBC Driver 13 for SQL Server',
        },
    }
}

Error
django.core.exceptions.ImproperlyConfigured: 'sql_server.pyodbc' isn't an available database backend.
Try using 'django.db.backends.XXX', where XXX is one of:
'mysql', 'oracle', 'postgresql', 'sqlite3'

Ensure that django-mssql-backend has been installed correctly and can be found by Django:

See how the test application is setup and used (note the usage of dj_database_url):

https://github.com/ESSolutions/django-mssql-backend/blob/master/.travis.yml
https://github.com/ESSolutions/django-mssql-backend/tree/master/testapp

List installed packages from Django shell to verify that it can be imported correctly (you might have to temporarily change database engine to built-in backend to get rid of error)

$ python manage.py shell
>>> try:
>>>    from pip._internal.operations.freeze import freeze as pip_freeze
>>> except ImportError:  # pip < 10.0
>>>    from pip.operations.freeze import freeze as pip_freeze
>>> pip_freeze()

Closing this issue
Django at the current point could in fact see this package, however, I believe there may have been conflicting packages from all of the other attempts/packages I tried earlier.
I ran the commands below to print my packages.
$python manage.py shell

try:
    from pip._internal.operations import freeze
except ImportError:  # pip < 10.0
    from pip.operations import freeze
for package in freeze.freeze():
    print(package)

If anyone runs into this issue, I suggest removing similar packages and or starting from a fresh virtual environment.
Thanks for your response.


feat(app): add test and stories for Tooltip

Overview
This PR will add test cases for Tooltip
fix RAUT-130

Changelog

add test for Tooltip
add stories for Tooltip

Review requests

[ ] test cases cover basic stuff
[ ] When running Storybook, you can see 2 items under Tooltip and they work as expected

Risk assessment
low

[ ] make Tooltip stories work

[ ] address pr comment


Fixed playback bar

Using the -q option for play makes the playback bar not show up.

Thanks. I'll do another release soon, got some more changes on my end to make first.


Create a better stdout format

Group by tasks
Will base off ansible format for now

Better mesh this with logging


Resolve conflicts and merge dev to master

@elprans - Can you send a PR for this?

Done.

@elprans - Can you please look at the test failures at https://ci.appveyor.com/project/appsvc/azure-functions-python-worker/build/1.0.289

Eventhub failed to call the trigger within the timeout.  I can increase it, but it seems like a host issue. Travis is OK.

To avoid race conditions, can you use dedicated resources for CI?

They are dedicated already.


Uncaught TypeError: Cannot set properties of undefined (setting 'capture') by using React/Electron environment

The general context that I developed a bot that automate the mouse and clicks of the desktop, by using React and Electron for build the App.
BUT, I've been stuck with the next error in Console:
Uncaught TypeError: Cannot set properties of undefined (setting 'capture')
    at Object../node_modules/robotjs/index.js (index.js:23:1)
    at Object.options.factory (react refresh:6:1)
    at __webpack_require__ (bootstrap:24:1)
    at fn (hot module replacement:61:1)
    at Module../src/bot/index.js (index.js:1:1)
    at Module.options.factory (react refresh:6:1)
    at __webpack_require__ (bootstrap:24:1)
    at fn (hot module replacement:61:1)
    at Module../src/components/Checkboxs.js (index.js:21:1)
    at Module.options.factory (react refresh:6:1)

I used the same sin/cosine example from docs in a js file, then importing the functions into a React component with: import { drawSine } from '../bot/index';
Where my expected behavior for the Electron app is, to use the sin example applied to the component such that when a button is triggered, the function should be executed and the mouse moved by the imported RobotJS script. As in this reference:
import { drawSine } from '../bot/index';

function Checkbox(){
  function handleSubmit() {
    drawSine();
  }

  return (
    <button onClick={handleSubmit}>
      Start
    </button>
  );
};

Even tho I rebuilt my project using the Electron docs/wiki provided by RobotJS; Me and my code still stuck by that bug
Uncaught TypeError.
Would someone leave a message of help/hope for this stressed dev?
Environment

RobotJS version: 0.6.0
Node.js version: v16.13.2
npm version: 8.5.1
Operating System: Ubuntu 20.04.4 LTS

This project appears to be unmaintained, see https://github.com/octalmage/robotjs/pull/622


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: istio-testing
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
2b141620f00db5ff9fc8ef9d5fc91b0e89ec8975
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
2b141620f00db5ff9fc8ef9d5fc91b0e89ec8975
link
/test istio-unit-tests

prow/e2e-simpleTests-minProfile.sh
2b141620f00db5ff9fc8ef9d5fc91b0e89ec8975
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Sync apache/flink:master][FLINK-31305] Propagate producer exceptions outside of mailbox execut…

…or so that checkpoints can correctly fail
This closes #22150.

Thanks @mas-chen for porting this over.
Will merge once CI is green.


Update read.py

@nitish705702 - Please put something in the "description" field above what this PR does.
@keflavich - Thoughts?

@keflavich - Is this PR a duplicate of #237 ? Can you merge one in and close the other?

No Sir
On Thu 16 May, 2019, 10:19 PM Christoph Deil<EMAIL_ADDRESS>wrote:

@keflavich https://github.com/keflavich - Is this PR a duplicate of #237
https://github.com/astropy/regions/pull/237 ? Can you merge one in and
close the other?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/astropy/regions/pull/248?email_source=notifications&email_token=AJVFEJ33Y2DRF27PIX4EI7TPVWGB7A5CNFSM4G6WYVQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVSNBPY#issuecomment-493146303,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJVFEJ4Z5REOLXFEDM6UNQLPVWGB7ANCNFSM4G6WYVQQ
.

Yes, I believe this is superceded by #237.  I'll close one of them once I've had a chance to review more carefully.


Inserts fail with Cannot commit: No transaction in progress

from vertica_python import connect
def get_connection():
return connect({
'host': '<IP_ADDRESS>',
'port': 5433,
'user': 'vertica_dba',
'password': 'password',
'database': 'ceilometer'
})
with get_connection() as conn:
insert_stmt = "INSERT INTO %s..."
cur = conn.cursor()
cur.execute(insert_stmt)
fails with the following stack trace:
raise errors.QueryError("Unexpected message type", self.last_execution)
vertica_python.errors.QueryError: Unexpected message type, SQL: 'commit'

Same Issue over here.

will take a look at this and other issues starting with version 4.x today

What version are you using, and can you paste the full insert statement? This is working for me on the latest master.
from vertica_python import connect

def get_connection():
    return connect({
        'host': '<IP_ADDRESS>',
        'port': 5433,
        'user': 'dbadmin',
        'password': 'password',
        'database': 'test'
    })

with get_connection() as conn:
    c = conn.cursor()

    c.execute("SELECT VERSION();")
    result = c.fetchall()
    print result

    c.execute("INSERT INTO test_table VALUES (2, 'string2', 3); COMMIT;")

    c.execute("SELECT * FROM test_table;")
    result = c.fetchall()
    print result

Result:
[[u'Vertica Analytic Database v7.1.1-0']]
[[1, u'olaf', 2], [2, u'string2', 3]]

@rjaiwal5139 @Bennyelg See above ^

Thanks! I was 2 versions back in some strange reason :/

I am on vertica 7.1.1-0 and this is my insert statement -
insert_stmt = "INSERT INTO %s (meter_id, meter_name, meter_type,
meter_unit) "
"VALUES (HEX_TO_BINARY('%s'), '%s', '%s', '%s'); COMMIT;"
%
(table_name, meter_id, name, _type, unit)
still get the error - vertica_python.errors.QueryError: Unexpected message
type, SQL: 'commit'
On Fri, May 8, 2015 at 12:26 PM, Benny Elgazar<EMAIL_ADDRESS>wrote:

Thanks! I was 2 versions back in some strange reason :/
—
Reply to this email directly or view it on GitHub
https://github.com/uber/vertica-python/issues/62#issuecomment-100333411.

Interesting. My guess would be that the hex getting adding to the query is causing something to break; I don't think use of the HEX_TO_BINARY() function has come up before.
Could you provide a sample set of values that cause the error? The table schema for the destination table would also be helpful.

'INSERT INTO meter (meter_id, meter_name, meter_type, meter_unit) VALUES (\'6310387d8bfdac272678bd54c691e7b1460b6f45\'), \'hello-world\', \'gauge\', \'hw\'); COMMIT;'
Following is the schema -
| column_name                                                                                | data_type                                                                                |
+---------------------------------------------------------------------------------------------------------------------------------+---------------------------------------------------------------------------------------------------------------------------------+
| meter_id                                                                                | binary(20)                                                                                |
| meter_name                                                                                | varchar(255)                                                                                |
| meter_type                                                                                | varchar(255)                                                                                |
| meter_unit                                                                                | varchar(255)                                                                                |
+-------------------------------

I'm still having trouble reproducing this. Maybe the quote escaping is causing problems?
Using a test table with a BINARY(20) column:
c.execute("INSERT INTO bintest_table VALUES (HEX_TO_BINARY('6310387d8bfdac272678bd54c691e7b1460b6f45'), 'test'); COMMIT;")

c.execute("SELECT * FROM bintest_table;")
result = c.fetchall()
print result

Result
[[u'Vertica Analytic Database v7.1.1-0']]
[["c\\0208}\\213\\375\\254'&x\\275T\\306\\221\\347\\261F\\013oE", u'test']]

Are you using the latest version of the package?

I was using 0.4.1

i got 0.4.3, let me try with that

Update to 0.4.5 it's work perfect there, anyone can confirm and close this thread?

going to close as it sounds like its been fixed.


EmailLayoutEditor  EditorChildrenIds bugs

EmailLayoutEditor  EditorChildrenIds bugs
remove 【Progress bar   】before：

remove 【Progress bar   】after:

Hi @markyun, thanks for the heads up. This appears to be on the Waypoint builder and not EmailBuilder.js builder, right?

Hi @markyun, thanks for the heads up. This appears to be on the Waypoint builder and not EmailBuilder.js builder, right?

hi This error can be replicated on both sides.

By the way, why do I encounter errors when building with EmailBuilder.js? Could it be that the packaging tool's configuration lacks the necessary components for submission? thanks


[Relay] move kind from tvm::relay::TypeVarNode to tvm::relay

Thanks for contributing to TVM!   Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from others in the community.

@tqchen let's talk on monday for this particular design decision. In particular I want to extend kind to make it a full kind system (many more subclass).


Dynamic theme automatically turns off after closing the app

I am on grapheneos Android 14. Dynamic theme on todark automatically turns off after closing the app.

This is strange. I will download an emulator from grapheneos and try to find out the reason.

Update the app to version 1.4.5, there is no such error in this version.

Okay... The version 1.4.5 seems to have solved it after updating.


speed up DockerDaemonSuite.TestDaemonRestartWithContainerRunning

Part of #19425
PASS: docker_cli_daemon_test.go:1589: DockerDaemonSuite.TestDaemonRestartWithContainerRunning	2.148s

/cc @tiborvass @thaJeztah

@mountkin ohh right, sneaky :stuck_out_tongue:.
LGTM 🐸

nice LGTM once janky is happy

Makes sense, I understand it now. sh doesn't respond to SIGTERM, but does respond to SIGKILL after the ten second timeout. top responds to SIGTERM, so it goes away faster.
LGTM

LGTM


mads-hartmann.bash-ide-vscode

[x] Extension name: mads-hartmann.bash-ide-vscode
[x] Extension GitHub or homepage: https://github.com/bash-lsp/bash-language-server

Thanks for opening an extension request!
We are currently in the process of switching extension marketplaces and transitioning over to Open VSX.
Once https://github.com/eclipse/openvsx/issues/249 is implemented, we can fully make this transition. Therefore, we are no longer accepting new requests for extension requests.
We suggest installing the VSIX file and then installing into code-server as a temporary workaround. See docs for more info.


[feature]: Add the possibility to pay a blinded path when the sender is also the introduction point.

I think it makes sense to also allow the introduction point of a blinded path pay the invoice.

If my understanding of route blinding is correct, when the introduction point is also the payer of the invoice then it knows the entire route as well.

No that is incorrect. It just would know the next hop

I think it makes sense to also allow the introduction point of a blinded path pay the invoice.

Definitely does! Was excluded from original PRs to keep the scope down.

Wondering, can the allow-circular-route option allow any hacks to make this work by adding some extra hops in and then routing back through yourself later? For example, it is a hacky way to workaround https://github.com/lightningnetwork/lnd/issues/7419 (which is a mildly related bug).

Interesting ...  Anybody working on it already?


Reassigned drawer should have revert option on individual people

Feature Request
Context
Add the link to revert people to make it really easy to cancel changes that were made
Story
As a People Allocator
I want an easy way to cancel an assignment change
So that I feel I can play with the schedule and then easily change it back

Acceptance Criteria
Given I want to cancel an assignment change
When I look at the reassignment window and see my person that changed
Then I can click the revert link and they would move back to whatever product they were on the day before.
Notes
Design: https://www.figma.com/file/S4XKeovlQqeRk64k2qzhf8gL/PeopleMover?node-id=1181%3A3123

for newly created people (no previous assignments):

if unassigned: do not show in reassigned drawer
if assigned directly to a product: show "Assigned to ." revert --> send to unassigned, do not show in reassigned drawer.


Adding favicon

I have added a favicon in the index.html.

Change it to hackincodes base branch @AshutoshDash1999

done @garimasingh128


Bump Build

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Am noticing a strange swig issue on OS-X arm64 for building GDAL. conda-forge/gdal-feedstock#766
swig -swiglib
...bin/swig: Bad CPU type in executable

perhaps a rerender here with updated compilers would help out?!?

thats probably not it: you have swig in both build and host section...

Sorry, we were just thrashing about attempting to figure out some workaround.

doesnt hurt to rerender though


CI doesn't report broken PyHDK tests

About a month ago python/tests/test_pyhdk_bindings.py::TestArrowStorage::test_import_arrow_table test was broken and CI didn't report it.

Looks like the problem is in .github/workflows/modin.yml where we run python for our test files instead of pytest.

I don't think that modin test is doing what we think -- the goal is to run modin tests on pyhdk, not pyhdk tests with modin installed.
I added a new job here: https://github.com/intel-ai/hdk/actions/runs/4298695189/jobs/74931060507 which just runs pytest without modin. It's failing on main, which is the result we currently expect.


Create a build for the Controller

This fixes a problem that @ticidesign found when creating custom field types outside the monorepo.
What happened is that the Controller file which field type Controllers extend isn't compiled since the webpack config(intentionally) won't compile anything in node_modules so this adds another preconstruct entrypoint to the fields package for the Controller file.
Note that this has a major changeset to the fields package just in case people imported @keystone-alpha/fields/Controller.js(explicitly with the .js).

Why packages/fields/Controller-src.js and not packages/fields/Controller/index.js?

That would work but I think it would be slightly confusing because people would have to know the specifics of the order which things happen in the node module resolution algorithm and that for the fields package, people would have to import ../some number of ../Controller/index and ../some number of ../Controller wouldn't work and for outside the fields package, the opposite would be true. Whereas having src in there something, it's more clear what should be imported where.
Do you think packages/fields/Controller/src/index.js would be better?

is this because of Flow? Does Flow support different file extension? like .flow or .flow.js so that we do not have to have controller-src.js and compiled controller.js.
I did bring TypeScript in past. I know that is not favorable here.   TypeScript has its extension .ts.
TypeScript also works like Flow too with purely based on jsdoc comments in js files without the need of compiling them again (no typescript specific stuffs in js file). It does work with babel 7 so no typescript step needed outside of existing compile step.
There are several issues related to file extension in flow repo.  one of them is https://github.com/facebook/flow/issues/4233

_ and for outside the fields package, the opposite would be true. Do you think packages/fields/Controller/src/index.js would be better?_

It's already different between the internal and external imports. I'd be happier with packages/fields/Controller/src/index.js - it's more explicit, and I've seen that general pattern a lot in the node ecosystem, so is easy to understand.

@mitchellhamilton I've gone ahead and made those changes on this branch 👍


Console create organization use personal account by default

When creating a new organization, the option "Use your personal account as organization owner" is disabled by default and a form is presented to the user.
I would suggest to enable the option by default to reduce friction for first-time users. There are certain cases where you want to be in control and create a new org-owner user when creating an instance. Yet this feels like an advanced use case.
Option disabled:

Option enabled:

@juergrinaldi do you agree?

I totally agree. This did already annoy me a few times.

@juergrinaldi do you agree?

completely agree. 👍


Switching Kernel/Interpreter in Python Native REPL dropdown forces use of IPyKernel.

Type: Bug
Behavior
Context
Upon starting a native python REPL, the default kernel "Python REPL" is active. With the setting "python.REPL.sendToNativeREPL": true,  Shift+Enter sends code from the editor to the REPL. If the user is happy working with the default kernel, everything is fine an no issues occur. If the user wants to use a different kernel, this can be achieved by clicking on the kernel button in the top right corner of the native REPL pane. The kernel selection works as expected, and the selected kernel remains active without issues as long as code is entered and executed manually.
Where the bug manifests
The bug is that when a non-default kernel is selected and code is sent to the REPL from the editor pane by Shift+Enter, this action triggers a change of the kernel back to "Python REPL", and the code sent is interpreted by this default kernel. This makes the setting "Send to active REPL" unusable if the user works with a virtual environment.
Expected behavior
The kernel selection should not be affected by sending code to the REPL.
Environment
Python 3.12.5 on Windows 11 Pro 23H2, virtual environment managed by poetry, python extension v2024.12.3.
User settings
I have checked that any combination of the settings "interactiveWindow.executeWithShiftEnter", "python.terminal.activateEnvInCurrentTerminal" and  "python.terminal.activateEnvironment" do not affect the behavior described above.
How to reproduce:

Set "python.REPL.sendToNativeREPL": true.
Open the native REPL by sending code from the editor with Shift+Enter.
Change the kernel of the native REPL to something else than "Python REPL".
Send some code from the editor to the native REPL again (Shift+Enter).
The kernel of the REPL has been unexpectedly changed back to default.

And since this is my first time interacting with this community I take this opportunity to thank you all for providing this awesome extension.

Hello @szymonhennel Thank you for filing the issue and I truly appreciate your kind words and appreciation here.
You made great points here and I appreciate the detailed info here.
Couple things here, but let's try to unwrap and discuss this step by step:

I will bring this up to the Python team and folks in Jupyter.

The big intention and motivation behind Native REPL feature was to provide Python user to access an enhanced REPL (with features such as intellisense and autocomplete) that the Terminal REPL did not have. All of this without having to install Jupyter extension nor iPyKernel that you need in order to launch and experience the Jupyter notebook or Interactive Window Option to run your Python code. This way, users just need their "basic" Python interpreter to test out their code quickly without having to sit and wait for iPykernel to be installed which is coming from Jupyter side of things.

That being said, the very moment you decide to pick a "kernel" yourself instead of Python REPL, it seems that Jupyter extension switches your mode from Native REPL(Provided by Python extension) to Interactive Window(one provided by Jupyter). The way you know this is the output: Basically if you are in the lightweight native REPL mode, you will not see colorized output but rather output generated by Python extension's REPL server.

If you are in the interactive window mode, you will see colorized output from the iPyKernel itself coming from Jupyter:

It looks like you are satisfied enough with the output that native REPL generates and do not necessary need the one from Jupyter. If that is the case, this can be a great feature request idea that you can post with the 'feature request' tag. I can see this being totally valid request.

I am also wondering if you can change interpreter via command palette (ctrl/cmd + shift + p) 'Select Interpreter' and try opening the Native REPL again and see your desired effect? Instead of changing the kernel via clicking on 'Python REPL'

Hi @anthonykim1 thank you for answering and sorry for taking a long time to come back to you, I will answer by tomorrow.

Hey @anthonykim1, thank you for the context! Came across the same issue, happy it was brought up!
To answer your question, changing the interpreter via the command palette (ctrl/cmd + shift + p) has zero effect on the issue, it is still reproducible.
It seems like what needs to be fixed here is the command that sends the code over to the interactive window, everything else works fine.
I personally think that using a Jupyter-provided Interactive Window has a nicer workflow than the ipynb.
Tagging @IanMatthewHuff as an engineer involved in making this feature.

the very moment you decide to pick a "kernel" yourself instead of Python REPL, it seems that Jupyter extension switches your mode from Native REPL to Interactive Window

IIUC, this is what the user is asking for, but doesn't quite work - you can change the kernel, but using sendToNativeRepl will switch the kernel back to python's.
The user should be able to select a different kernel to use here, and would actually provide a workaround for https://github.com/microsoft/vscode-jupyter/issues/15988

I see, with the explanation + video made it super clear.
The smoothest transition I can think of would be: Perhaps we need to detect when user has switched their kernel from (native REPL to IW) and automatically change the keybinding (of shift+enter) to send to IW instead of Python Native REPL?
If we detect user change their kernel back to native REPL (Im not sure if this is possible), we would again change/revert the shift+enter keybinding to send command to native REPL instead of IW.
Does this sound reasonable?

I think a much simpler solution would just be to not run the selectKernel command if the editor was already opened - allow the user to use a different kernel in the python REPL editor.

I was facing a similar issue, but I managed to change it so it doesn't use the Python REPL editor every time I press Shift+Enter by doing the following:
TL;DR: Change jupyter.interactiveWindow.textEditor.executeSelection to true using the Visual Studio Code Settings UI. This made it start using my kernel as the default option.
Steps:
Open Settings UI:

Press Ctrl+Shift+P, search for Settings UI.

Search for the Setting:

In the search bar at the top, type jupyter interactive window text editor execute selection.

Enable the Setting:

Find the setting named Jupyter: Interactive Window Text Editor Execute Selection.
Check the box to enable it.