wls error: chunked array is not contiguous

Hi,
I have witnessed the following error while performing a WLS with this library:
panicked at src/expressions.rs:54:22:
Failed to convert f64 series to ndarray: ComputeError(ErrString("chunked array is not contiguous"))

I fixed this by first transforming my df with pl.DataFrame(numpy_array, schema=df.columns) (and my colleague points out that DataFrame.rechunk() is even better) but please could polars-ols handle non-contiguous DataFrames gracefully? (Or if you don't want to support that, please could the error message let users know how to fix, e.g. using df = df.rechunk()?)
Apologies, I cannot share my repro for this... I tried making some shareable simple examples but it would take more effort to get right. It was just from a normal wls call a bit like this:
pl.col("a").least_squares.wls(
    *[f"foo{i}" for i in range(10)],
    sample_weights="weight",
).alias("a_preds")

polars-ols==0.3.3
polars==1.4.1
Python 3.12.5
Many thanks

Hi Tom, thanks for reporting this. yes, I’d want to handle this gracefully (if doable) on the rust / library side.
A problem on my side is the library is polars ols is purely expression based (lazy) and so not easy for  me to add a dataframe level rechunk on the users behalf. But what we can do is add expression level rechunk if the data isn’t contiguous.
Would you mind please, in your own example (I don’t need to see it), try adding something like:
pl.col("a").rechunk().least_squares.wls(
    *[pl.col(f"foo{i}").rechunk() for i in range(10)],
    sample_weights=pl.col("weight").rechunk(),
).alias("a_preds")

https://docs.pola.rs/api/python/stable/reference/expressions/api/polars.Expr.rechunk.html
And letting me know if this fixes the issue for the original data that was problematic ? If it does, it should be fairly easy for me to add something that  does something like that for the user - could aim to release something this weekend if so.
Azmy

I had taken a quick look at this but couldn't figure out how it could be happening, given that the array is explicitly rechunked just before this assertion gets hit:
https://github.com/azmyrajab/polars_ols/blob/v0.3.3/src/expressions.rs#L47
I suppose it's conceivable that s.rechunk().f64() could result in a ChunkedArray with multiple chunks, but that would feel surprising to me!

Thanks @jacksonriley, I remember adding a rechunk somewhere which i thought should have prevented this sort of issue from happening.
It’s a bit strange/surprising for me too, but will trace through if casting as f64 somehow applies multiple chunks by default (if so will try casting before rechunk) and otherwise chase through the to_ndarray code path that breaks and see if there is something unexpected there. We’ll figure something otherwise I’ll ask someone from polars team for 👀

hi @jacksonriley @tmct
Tried to make sure this issue doesn't bite again - couldn't get a clean reproduce but added a test and made sure that no nulls and a re-chunk are guarenteed before calling to_ndarray(). to_ndarray() which calls cont_slice() which checks two things: a) no nulls and b) there is one chunk, so these should be impossible in the new code
In any case, if you observe differently please try to reproduce and I can take another look. But don't think this is likely in this version - I hope!

https://github.com/azmyrajab/polars_ols/blob/0422b62ddcaa6c83e32b7a6fcb29351b4bfc3ec1/src/expressions.rs#L32-L44
/// Contiguous slice
 pub fn cont_slice(&self) -> PolarsResult<&[T::Native]> {
     polars_ensure!(
         self.chunks.len() == 1 && self.chunks[0].null_count() == 0,
         ComputeError: "chunked array is not contiguous"
     );
     Ok(self.downcast_iter().next().map(|arr| arr.values()).unwrap())
 }

https://github.com/azmyrajab/polars_ols/blob/0422b62ddcaa6c83e32b7a6fcb29351b4bfc3ec1/tests/test_ols.py#L969C5-L995

Thanks for taking a look at this! It looks pretty bullet-proof now 😁 🤞

Many thanks!


CORGI-298 / CORGI-728: Try to link better variants to a stream when processing variant-type ProductComponentRelations

@RedHatProductSecurity/corgi-devs This may not be the right fix, and is definitely not a complete fix. But this code makes my head spin a bit, so early review is appreciated. We have three different bugs / cases:

We link Components to Channels, even though not every Component ships to every Channel. I added this linking by mistake (thinking it was omitted) so we can just stop linking them / go back to the code we had before. No other code depends on Component -> Channel links existing as far as I'm aware.

When we have a ProductComponentRelation between a ProductVariant and a SoftwareBuild, we link the SoftwareBuild's Components to the Variant given in the relation (correct), its parent Stream (correct), and all child Variants of that Stream / siblings of that Variant (incorrect). This is also an easy fix.

When we have a ProductComponentRelation between a ProductStream and a SoftwareBuild, we link the SoftwareBuild's Components to the Stream given in the relation (correct) and all child Variants of that Stream (incorrect). I don't know how to fix this. I think some of our code assumes a Component always has at least 1 linked Variant, and will break if we stop linking any Variants and only give the Stream instead.

Ok, I'll stop using the request changes feature and just leave it unapproved next time.


Event Registration Template

Event Details
Title of the Brainhack Organization (e.g. Brainhack Marburg):
Title of the Event:
Description of the Event:
Date of the Event:
Link to the specific event page (if exists):
Online meeting link:
Contact Information Regarding Queries:
Main Mattermost Communication Channel for Your Local Event
Event Labeling

[ ] Expected Profile of the Event Audience

[ ] Event Type:

[ ] Event label (e.g. brainhack_Marburg)

[ ] Event snippet for the Brainhack website

Is this template for the google form or for an event template issue like the project one? @complexbrains

I think having made available the google form for local organizers to register to host an event makes this template unnecessary/edundant. Closing.


Indentation level of some codes

https://github.com/j-min/DSG/blob/3f844c1dadd141e5c7b3e9d68f3889208c9b6248/query_utils.py#L350-L389
Hello,
Thank you for sharing your great work!
Upon attempting to generate a DSG, I've noticed that the indentation of certain lines may be incorrect. It appears they should be indented one level less, as the current formatting causes an exception to be thrown. Once I adjusted the indentation level, the generation process proceeded without any issues.
Qinyu

You're right, thanks for the catch! I just fixed the indentation the repo.


Fix GitPod Issue

Fix for GitPod error/issue

this fixes the gitpod issue per @technophile-04 recommendation 🙌

Seems like Gitpod was not installing husky because it was placed in dev dependencies. Adding husky to main dependencies instead of dev dependencies solved this issue.
Here is the Gitpod link to my repo :

Alternate solution: Maybe we can ran yarn add -D husky after yarn install in .gitpod.yaml. No idea about it, will explore this.
PS: Don't know why doing yarn install even before adding husky to main dependencies updated yarn.lock.The merege conflicts inyarn.lock are due to that reasons I think.
Open to any suggestions/improvements 🙌

From @technophile-04 =>
Seems like Gitpod was not installing husky because it was placed in dev dependencies. Adding husky to main dependencies instead of dev dependencies solved this issue.
Here is the Gitpod link to my repo :

Alternate solution: Maybe we can ran yarn add -D husky after yarn install in .gitpod.yaml. No idea about it, will explore this.
PS: Don't know why doing yarn install even before adding husky to main dependencies updated yarn.lock.The merege conflicts inyarn.lock are due to that reasons I think.
Open to any suggestions/improvements raised_hands

What was the problem for @technophile-04 in Gitpod?

Hii @damianmarti  sorry for the late reply, So currently you can't open the scaffold-eth main repo with Gitpod. It gives this error :

To fix this we need to move husky from dev dependencies to main dependencies since Gitpod is not able to recognize it. I and @codenamejason created the PR at the same time, since mine had some merge conflicts in yarn.lock I closed my PR. we can merge this PR  🙌.
here is an example https://gitpod.io/#github.com/technophile-04/scaffold-eth which uses the proposed solution in this PR and works.

thanks @technophile-04 for the data!
is there a way to avoid running the husky post checkout hook when deploying into gitpod?
I personally don't like this husky post checkout hook running yarn install. Sometimes I just want to switch branches to see at some code and I don't want to install the libraries.
I vote to leave the package.json as is was and removing the post checkout hook hook ;-)
cc/ @codenamejason

Same opinion here @damianmarti the user could run to learn the process instead of automatic.

I personally don't like this husky post checkout hook running yarn install. Sometimes I just want to switch branches to see at some code and I don't want to install the libraries.

+1
pre-commit linting hook is handy tho.


Wallet call fetchFiatConnectProviders and display

AC:

Wallet calls the new fetchFiatConnectProviders cloud function and quotes are displayed correctly on the SelectPayments screen

ENG:

For now, tapping on the provider in the Select Payments screen need not do anything. (this ticket is just getting the quotes/providers to show up)

Figma

removing this from the sprint, since it is blocked by stuff that's unlikely to all be done in time


Pass yielded properties to other components

Output from ember bootstrap:info:
ember-bootstrap: ^3.0.2 -> 3.0.2
ember-cli: ~3.12.0 -> 3.12.0
bootstrap: n/a
bootstrap-sass: ^3.4.1 -> 3.4.1
ember-cli-sass: ^10.0.1 -> 10.0.1
ember-cli-less: n/a
Bower packages:
bootstrap: n/a
bootstrap-sass: n/a
ember-bootstrap configuration:
bootstrapVersion: 3
importBootstrapFont: true
importBootstrapCSS: false

I want to be able to pass down the yielded form to a component. So I have the following
<BsForm @formLayout="vertical" @class="bootstrap-form" @showAllValidations={{true}} @novalidate={{true}} @model={{model.customer}} @onSubmit={{action "saveChanges"}} as |form|>

  <MobilePhone
    @form={{form}}
    @model={{model.customer}}
    @mobilePhoneCarriers={{model.mobilePhoneCarriers}}
    @requireMobilePhoneCarrier={{model.requireMobilePhoneCarrier}}
    @isNanpa={{isNanpa}}
  />

</BsForm>

The problem I have is with angle brackets now enabled, ember s wont start because its telling me in my component that:
Compile Error: <form.element> is not a component and doesn't support block parameters

Here is what the MobilePhone component looks like
<form.element @label="Your mobile phone number" @placeholder="Mobile phone" @property="cellPhone" @id="phone-div" @required={{true}} @useIcons={{false}}>

</form>

This sounds like a bug in Ember but not in Ember Bootstrap to me. I had faced that one myself but had have time to create a bug report for it (yet). You could reexport the form using {{let}} as a work-a-round:
{{#let @form as |form|}}
  <form.element />
{{/let}}

Discord came to the rescue. The problem was the code mod did not set the form right in the component. It should of been
<EMAIL_ADDRESS>@label="Your mobile phone number" @placeholder="Mobile phone" @property="cellPhone" @id="phone-div" @required={{true}} @useIcons={{false}}>

</@form>

Not
<form.element @label="Your mobile phone number" @placeholder="Mobile phone" @property="cellPhone" @id="phone-div" @required={{true}} @useIcons={{false}}>

</form>

Going to file a bug with code mod to see if this is something they could catch in future


PAF-130-Added validation for all phone number entries

What?
PAF-130
Why?
Phone number field accepts any text.
How?

added validation control to all phone number text fields
added error message once an invalid number checked in the validation.js file

Testing?
Tested manual in the UI and error message & validation work perfect
Screenshots (optional)
Anything Else? (optional)

Hey @TemitopeAyokuHO really sorry as I asked you to up the max length values for all these phone numbers but it turns out that the IMS max length for phone number fields is 20 - so all those values will need to be 20 in the form as well.
Seems a little short to me still but as it could cause errors otherwise that's what we have to go with!


how to download data_verts.npy, raw_audio_fixed.pkl, templates.pkl and subj_seq_to_idx.pkl?

I sign in 'https://voca.is.tue.mpg.de/' but no find these files, can you tell me how to downlaod?  thanks~

Hi, after logging in, please click the "Download" button at the top of the webpage. Then scroll down to the bottom of the page, and you will see "Training Data (8 GB)" along with a "Download" button. Click to download and unzip the file, and then you will find the data you mentioned.

Hi, after logging in, please click the "Download" button at the top of the webpage. Then scroll down to the bottom of the page, and you will see "Training Data (8 GB)" along with a "Download" button. Click to download and unzip the file, and then you will find the data you mentioned.

I have downloaded it, thanks~

OK, then I will close this issue.


elementHandle.screenshot() produces blank screenshots for elements outside of viewport

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.3.0
Platform / OS version: OS X 10.12.6
URLs (if applicable): N/A (Test script uses https://github.com but I've noticed the issue on other pages)
Node.js version: 8.1.4

What steps will reproduce the problem?
Using elementHandle.screenshot in the following test script, capturing an element outside of the viewport results in a blank / empty screenshot.
Please include code that reproduces the issue.

import puppeteer from 'puppeteer';

const VIEWPORT = {width: 1200, height: 900};
const URL = 'https://github.com/';
const TESTELEMENT = '.footer';

(async () => {
  const browser = await puppeteer.launch({headless: false});
  const page = await browser.newPage();
  await page.setViewport(VIEWPORT);
  await page.goto(URL, { waitUntil: 'networkidle0' });

  // Full page screenshot.
  await page.screenshot({
    path: 'tmp/testPage.png',
    fullPage: true
  });

  // Screenshot using element handle.
  const element = await page.$(TESTELEMENT);
  await page.waitFor(1000);
  await element.screenshot({
    path: 'tmp/testElement.png',
  });

  // Screenshot using the element's bounding box.
  const elementBounds = await element.boundingBox();
  await page.screenshot({
    path: 'tmp/testClip.png',
    clip: elementBounds,
  });

  await browser.close();
})()

What is the expected result?
The screenshot taken using the element handle should capture the footer for the url provided. The screenshot that supplies the element's bounding box should also capture the footer.
What happens instead?
The full page screenshot is fine, but the other two are blank (white). If I adjust the script and increase the viewport height to something really large, like 9999px, the footer is within the initial viewport and the problematic screenshot come out fine.

I'm having a similar issue with Puppeteer, but for me out-of-viewport elements otherwise work, but seem to fail if the distance (x/y) and/or size(w/h) of the element contain decimals.
A minimal script that replicates this can be found here. Run that through https://try-puppeteer.appspot.com/ and it will log the bounding rectangles for both selectors.

@VesterDe, I can confirm the element I attempted to capture also has a vertical offset containing decimals.
The issue also seems to begin with puppeteer v1.2. Both my test script and @VesterDe's script produce the expected results with version 1.1.1

I'm seeing some weird coordinates issues with elementHandle.screenshot() in 1.3 as well. I have a script that captures the code blocks from all of my blog pages and for one specific page the coordinates are all off.
One of many working pages: https://benclinkinbeard.com/d3tips/utility-methods-with-d3-array/
The only problem page: https://benclinkinbeard.com/d3tips/a-reusable-function-for-creating-charts-with-axes/
Relevant code from a set of utils I'm using:
async function initPuppeteer(options = { args: ['--no-sandbox'] }) {
  const browser = await puppeteer.launch(options)
  const page = await browser.newPage()
  return { browser, page }
}

async function getScreenshotBuffer(page, selector) {
  let buffers = []

  if (!selector) {
    buffers = [await page.screenshot()]
  } else {
    const targets = await page.$$(selector)
    const promises = targets.map(elHandle => elHandle.screenshot())
    buffers = await Promise.all(promises)
  }

  return buffers
}

async function getBuffersFromURL(
  url,
  width = 2000,
  height = 800,
  selector = 'div.highlight',
) {
  const { browser, page } = await initPuppeteer()
  page.setViewport({ width, height, deviceScaleFactor: 2 })
  await goToURL(page, url)
  const buffers = await getScreenshotBuffer(page, selector)
  await browser.close()
  return buffers
}

Instead of getting that very simple first code block I get this:

I'm also seeing weirdness that is not just coordinate offsets.

Related to #2263 ?

I solved my problem. Several concurrent calls to elementHandle.screenshot() is apparently not feasible, which makes sense when you slow it down and see how it works. I made the following change to grab screenshots serially instead of in parallel.
const handles = await page.$$(selector)

// no more of this
// const promises = [targets[0]].map(elHandle => elHandle.screenshot())
// buffers = await Promise.all(promises)

// this instead
while (handles.length) {
  const handle = handles.shift()
  const buffer = await handle.screenshot()
  buffers.push(buffer)
}

Experiencing same issue scrolling to capture elements outside the viewport, in my case floating tooltips.
I've noticed it only happens in headless mode, changing config to headless: false seems to resolve if that helps identifying the problem/finding a solution.

I also had the same issue one hour ago ^^
I solved the problem by changing to a higher viewport.

Any update on this? It's even worse in later versions of Puppeteer/Chromium... before, we could at least .hover() or .click() the out-of-viewport element to bring it into view prior to .screenshot()... but now even this hacky solution is no longer working, and the screenshot is totally blank (though dimensionally correct).

The third method above (getting the bounding box of the element and using it to clip in page.screenshot) is working for me now in 1.16.0.  That is, screenshotting the element still gives a blank image, but the bounding box method correctly gives an image of it.

To be clear, this code is now nicely working for us without (any yet discovered) issues:
        const screenshot = await chromePage.screenshot({
          clip: await targetElement.boundingBox(),
        });

@bluepeter Well, isn't working for me

Experiencing same issue scrolling to capture elements outside the viewport, in my case floating tooltips.
I've noticed it only happens in headless mode, changing config to headless: false seems to resolve if that helps identifying the problem/finding a solution.

Same to me it works with headless false, but I need headless to run in a headless server after those tests

I tried with
async function screenshotDOMElement(opts = {}) {
    const padding = "padding" in opts ? opts.padding : 0;
    const path = "path" in opts ? opts.path : null;
    const selector = opts.selector;

    if (!selector) throw Error("Please provide a selector.");

    const rect = await page.evaluate(selector => {
      const element = document.querySelector(selector);
      console.log({ element, selector });
      if (!element) return null;
      setTimeout(() => element.scrollIntoView({ block: "center" }), 1000);
      const { x, y, width, height } = element.getBoundingClientRect();
      return { left: x, top: y, width, height, id: element.id };
    }, selector);

    if (!rect)
      throw Error(`Could not find the element that matches selector: ${selector}.`);

    return await page.screenshot({
      path,
      clip: {
        x: rect.left - padding,
        y: rect.top - padding,
        width: rect.width + padding * 2,
        height: rect.height + padding * 2
      }
    });
  }

But that ^ function gives empty images when the div is out of viewport.
const puppeteer = require("puppeteer");
(async () => {
  const browser = await puppeteer.launch({ headless: false, devtools: true });
  const page = await browser.newPage();
  // Adjustments particular to this page to ensure we hit desktop breakpoint.
  await page.goto("http://www.producepriceindex.com/", {
    waitUntil: "networkidle2"
  });
  const handle = await page.$("[id=\"block-block-1\"]");
  await handle.screenshot({
    path: "element.png"
  });
  await browser.close();
})();

But this worked for me.

I managed to fix my issue by setting the viewport before taking the screenshots.
The important thing was to get the full height of the page where everything I wanted to screenshot was visible. In my case, everything was a child of a .application-wrapper div. So the code looks something like this:
const VIEWPORT = { width: 1280, height: 720, deviceScaleFactor: 2 }; // Your default values
await page.goto(url, { waitUntil: 'networkidle0' });

const fullPage = await page.$('.application-wrapper');
const fullPageSize = await fullPage.boundingBox();
await page.setViewport(
  Object.assign({}, VIEWPORT, { height: fullPageSize.height })
);

// Element screenshot logic
const elements = await page.$$('.screenshot-element');

for (const [index, element] of elements.entries()) {
  await element.screenshot({ path: `/tmp/${index}.png` });
}

await page.setViewport(
  Object.assign({}, VIEWPORT, { height: fullPageSize.height })
);

Thanks. It works for me with height: parseInt(fullPageSize.height)

@kan0s cool! Probably using parseInt makes more sense as I read some people were having troubles with heights containing decimal points. In my case, all the elements have fixed heights, so I didn't have to worry about it.

@marcelotedeschi You are a savior; setting the viewport worked perfectly. Although I needed to use parseInt to convert height before getting the boundingBox for full page

Hello, what if there are some elements in the page that are using 'vh' as height ? for example 70vh.
Setting the viewport to the fullPageSize height, will make this element take all the 70vh of the viewport.

I am not able to reproduce the issue with the latest version of Puppeteer, presumably fixed.


Updated dataset

Also, no longer need to remove the first and last lines from the ipcat list, as was added in #6.

LGTM. 👍 Thank you, @ankane.


Support for azure openai, litellm

Please provide support for azure openai or litellm

Would you like to pull a request to support LiteLLM? Reference to https://github.com/InternLM/lagent/blob/a8ae3872fac6e23f832d860131a1196f1a722fe1/lagent/llms/openai.py#L21

me too,I want to use litellm

Would you like to pull a request to support LiteLLM? Reference to https://github.com/InternLM/lagent/blob/a8ae3872fac6e23f832d860131a1196f1a722fe1/lagent/llms/openai.py#L21您想拉取支持 LiteLLM 的请求吗？参考 https://github.com/InternLM/lagent/blob/a8ae3872fac6e23f832d860131a1196f1a722fe1/lagent/llms/openai.py#L21

Using litellm, modifying openai_api_base does not work, and reports an error：
D:\pyEnvs\mindsearch\lib\site-packages\lagent\llms\openai.py:397: DeprecationWarning: `top_k` parameter is deprecated in OpenAI APIs.
warnings.warn(
{"detail":"Method Not Allowed"}
INFO:     <IP_ADDRESS>:3591 - "POST /solve HTTP/1.1" 200 OK
{"detail":"Method Not Allowed"}

+1 for this. Is there a way to make it work with Azure? Thanks for the great app btw.


chore(master): release spark-delta 1.4.0

:robot: I have created a release beep boop
1.4.0 (2024-04-06)
Features

try release (6cbd432)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/chgl/util-images/releases/tag/spark-delta-v1.4.0 :sunflower:


[HUDI-3636] Create new write clients for async table services in DeltaStreamer

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yihua : can you follow up on this PR when you get a chance. we might need to fix this before 0.11.1

@hudi-bot run azure

@yihua : this patch is ready for review.

There's still some concern around this PR. Let's keep it out of 0.14.0.


Add Core vs Framework for server apps article

This adapts a short whitepaper for choosing .NET Core or .NET Framework for the server and adds it to our docs.
I'm not entirely sold on where I placed it in the TOC, but I felt that it was the best place for the time being.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/standard/choosing-core-framework-server.md
:white_check_mark:Succeeded
View
Details

docs/toc.md
:white_check_mark:Succeeded
View
Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/standard/choosing-core-framework-server.md
:white_check_mark:Succeeded
View
Details

docs/toc.md
:white_check_mark:Succeeded
View
Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/standard/choosing-core-framework-server.md
:white_check_mark:Succeeded
View
Details

docs/toc.md
:white_check_mark:Succeeded
View
Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/standard/choosing-core-framework-server.md
:white_check_mark:Succeeded
View
Details

docs/toc.md
:white_check_mark:Succeeded
View
Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Graph not updating

Hi,
I've just found your website. It doesn't seem to be working.
The graph is empty and I can't fill it, neither by editing the default values nor adding some.
Downloading the SVG file also gives and empty graph.
See this screenshot:

I'm using Chrome 64-bit v.79.0.3945.130 on Windows 10.
Thanks,
Thomas

Hi Thomas, thanks for reporting your issue, apologies that it's not working like it should. Could you open the console (View > Developer > JavaScript Console in Chrome) and tell me if you see an error there. If you please copy it here.  Thanks, Jules

Hi Jules,
Nope, nothing.
The console is empty.
Thomas

Thanks for your swift response! Very strange, you could try the following things

Does this happen with both default values as with custom values?
Does hitting the plot button below the Areas and/or Lines table do anything?
Can you try completely clearing the points table, entering 0.4, 0.4, 0.3 in the first row and pressing 'Plot points'. Do you see a point appearing?
You can try plotting from an Incognito window to check if any browsers extensions are interfering.

If any of these did the trick, please let me know.
Jules

Without a further reponse, I'll close this issue


fix: textstyle pass to widget span

Thanks. Can you show me the screenshots before and after the changes?


Automatically attach the required files to releases

Summary of the discussion
As described in https://github.com/OpenEnergyPlatform/ontology/pull/1955, the Release workflow currently requires that an oeo-closure.owl file present in the build-files.zip artifact to be attached to a release. However that pull request would remove said file from the artifacts for a reduced completion time of workflow runs.
This Pr tries to automate the release workflow. Instead of a maintainer going to the workflow artifacts of two separate runs to download the build-files.zip and existing-terms-and-definitions.zip and create a release with them, the maintainer would now only have to write and publish the release and this workflow would then automatically attach said files.
However, I am not really able to test this easily. But even if the automation fails, this pr ensures that a version of build-files.zip is uploaded that contains the oeo-closure.zip file, so the maintainer can add it automatically.
Type of change (CHANGELOG.md)
---
Workflow checklist
Automation
Closes #
PR-Assignee

[x] 🐙 Follow the Pull Request Workflow
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Add #'s to term tracker annotation

Reviewer

[x] 🐙 Follow the Reviewer Guide
[x] 🐙 Provided feedback and show sufficient appreciation for the work done

@jh-RLI could you please also take a look at this PR?

Looks good to me. However, I don't get every single command...
@jh-RLI could you please also review with respect to https://github.com/OpenEnergyPlatform/oeplatform/pull/1791

Hi, sorry for the late response. This looks very promising. Maybe for the next release you could do a "vX.X.X-pre" release to test this workflow? From looking at the workflow file, everything seems correct. The resulting artifacts should be reviewed at least once.
For the OpenEnergyPlatform it is important to have at least the structure & files available that are also in the current build-files.zip for v2.5.0. If something changes, let me know. The OEP attempts to read the files / provides them for download.

The file structure should be the same, as I took the steps that build them from the other workflow. But checking whether everything is correct with a pre-release is definitely the best approach!
However, there will be a delay of about 10 to 15 minutes before the files are built. Previously, the person writing the release just had to download the files and attach them to the release, making them available at the same time the release was published. Now, the files first have to be built which is only triggered after the release is published.
But I don't know whether that needs to be considered for the OEP.

Thanks @ColinHDev for the hint. This is not a problem, currently the OEO version in OEP has to be updated manually as well, as we can't really communicate with Github via the OEP web server for security reasons. As there is no timeing dependent process implemented that fails if the files are only available some time after release, this is not an issue that is currently bothering us :)


Create a compact version of the track

Please merge #127 before this
Description

This PR creates a compact version of the track introduced in #127. This compact version is used in places such as the search results and related audio.
Technical details

Since there are slight differences in the two versions that cannot be dynamically handled, the component has a bit of code duplication in the template section.
Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[ ] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I agree on more abstractions in the future.


Fix instanceof checks for a cross-realm scenario

Hi.
The current getRenderProperties() implementation is nice, but it fails when a JS-code calling JsBarcode()  and a target DOM element belong to different realms (= windows).
Yep, it is the real case in our internal codebase. :)
I have improved the implementation slightly by using explicit references to the appropriate classes instead of implicit global references.
Links with info:

Determining with absolute accuracy whether or not a JavaScript object is an array. (In case of the cross-realm instanceof problem is unclear to you.)
MDN: Node.ownerDocument.
MDN: Document.defaultView.
SO: How can I get the window object that an HTML node belongs to using JavaScript?.

Can somebody help me with he failed checks?
I have looked in the Travis logs and it doesn't look like a problem with (my or somebody else's) JS code. There are plenty of C++ compilation errors in the logs.


Upgrade xray sdk version

Coverage decreased (-28.3%) to 63.926% when pulling d882afbee5da3cdf40f752581a4cedaf204738eb on luyun-aa:upgrade_xray_sdk_version into e8c65d3d85ba62e857c7448691568ad4b02f4a46 on spulec:master.

Now here's a good news - the latest aws-xray-sdk is allowed since https://github.com/spulec/moto/commit/ed861ecae1039a048a6350a4ff832ef094cdf2c2. I've tried to run moto with aws-xray-sdk 2.2.0 and it works fine.

This should be fixed with https://github.com/spulec/moto/pull/1948


Pinning the version of aiohttp

Temporary fix for #247.

coverage: 99.057%. remained the same
when pulling 7ce18572b0f3caa9a9d0846f3252ce140975a62b on annoying-aiohttp
into bf397c08e465d48182c9fabb6e67a9d3c8bedecb on main.

coverage: 99.057%. remained the same
when pulling 7ce18572b0f3caa9a9d0846f3252ce140975a62b on annoying-aiohttp
into bf397c08e465d48182c9fabb6e67a9d3c8bedecb on main.

coverage: 99.057%. remained the same
when pulling 7ce18572b0f3caa9a9d0846f3252ce140975a62b on annoying-aiohttp
into bf397c08e465d48182c9fabb6e67a9d3c8bedecb on main.


Seriously js no longer works

the seriously js example does not work

Hi Justin!
Unfortunately with the big amount of videos it is near impossible to keep everything up to date that deprecates.
That being said you can always add a community contribution that has an updated version!
P.S. you should join our community discord for questions and remarks you might have in the future!


#test div display

As it is, it seems that the #test div is displayed but not styled. I'm wondering if we should try one of the following:

Provide for a way to add CSS, so that the #test contents can be styled properly. Or,
set "display: none" on #test to avoid messing up the test page, and to speed up the tests.

We should follow Jasmine here. I think it does something like absolute position the element offscreen. It doesn't use display: none because I have occasionally asserted things like expect($('.foo.')).toBeVisible() (using jasmine-jquery matchers) and that works.


AppVeyor build breaks on outdated .NET SDK 5

Description
The .NET SDK used can logically not compile a newer .NET app.
C:\Program Files\dotnet\sdk\5.0.404\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets(141,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 6.0.  Either target .NET 5.0 or lower, or use a version of the .NET SDK that supports .NET 6.0.

Expected Behavior
Compilation should succeed for the .NET 6 app.
Actual Behavior
An SDK is used that cannot compile .NET 6
Possible Fix
Increase the SDK verison
Steps to Reproduce
Does not apply
Context
i was trying to create a PR.
Your Environment
Github Actions

Version Used:
Edition Used (.NET Core, .NET Framework):
Operating System and version (Windows 10, Ubuntu 18.04):
Link to your project:
Link to your CI build (if appropriate):

We have "fixed" this by moving off of AppVeyor.  Now all builds happen on GitHub Actions, and releases come from those builds.  This makes this consistent with how other projects within this Organization are done.


Implement Floating Script Editor Window

I've been working on a solution to make the script editor a floating window. This addresses https://github.com/godotengine/godot-proposals/issues/28
Here's a working prototype:
https://user-images.githubusercontent.com/62965063/175501663-eb2a883d-a638-4f7b-9fe6-2aa1411e93ca.mp4
It's not perfect, still has some bugs, but it works quite well nevertheless.

Hi @SirQuartz, you may be happy to know that I'm already working to that as part of the GSOC'22 (link to the project).
I already start working to it here: https://github.com/trollodel/godot/tree/gsoc_2022_multiwindow.

Oh wow, I wasn't even aware of that, that looks way better than whatever I was trying to do!

I will check @trollodel implementation. How ever, yours or @trollodel should allow to have the code window and a viewport at the same time to allow multi monitor

I will check @trollodel implementation. How ever, yours or @trollodel should allow to have the code window and a viewport at the same time to allow multi monitor

@trollodel Niceeee


Non-rivets build triggers ReferenceError

An attempt to read a rivets variable that has never been defined in the cartjs only build causes an error, not allowing anything else to work.
Uncaught ReferenceError: rivets is not defined
Steps to reproduce:

Install /dist/cart.min.js into a document
Open developer console

Basic reproduction
Codepen here

Having the same issue here, is there a fix for this? i'm importing rivets and then CartJS directly below it:
import $ from 'jquery'
import rivets from 'rivets'
import CartJS from 'shopify-cartjs'

This gives me rivets is not defined in my console log.
However if I take out CartJS and do a console.log(rivets) i'm getting rivets object logging....

Fix released in v1.1.0. Thanks @tywayne and @sebszocinski!


By default the wallet needs to be locked

When an user opens the browser, the wallet has to be locked. Because the session storage would be empty.
Menu options should be hidden until the user retrieves the mnemonic key and so do the wallet.

Implemented in bb56d55e62715413b3c9f8fd839d7cef63e0ca27


Release/v1.12.1

Purpose

How does the solution address the problem

Changes made

prnet cleaned-up successfully


Why there is no netG.parameters.requires_grad = False when updating netD?

I'm new to the GAN, what I understand about it is that netG and netD should be optimized alternatively，but I cannot find netG.parameters.requires_grad = False when updating netD, I get confused about it.

You freeze the netG when train netD

@kunrenzhilu you mean updating netG and netD when train netD?

@kunrenzhilu I see, setting Variable volatile=True means 'netG.parameters.requires_grad = False'

@kunrenzhilu I see, setting Variable volatile=True means 'netG.parameters.requires_grad = False'


feat: display last modification date on each page

Fix #145
It's a bit too much at the moment, maybe only bold would be enough?

oooh i love it @maelle, looks great!
fyi @rivaquiroga @yabellini

that is so slick with just a few lines of code! 🥳

Looks great!

Welcome maelle! It looks like this is your first contribution to this repository.

:joy_cat:
I'll wait for Yani's ok.

Welcome maelle! It looks like this is your first contribution to this repository.

😹
I'll wait for Yani's ok.

yeah, ok... so that action seems to not understand who are new contributors :P

Love it!! Thanks @maelle 🙏


[Feature Request]: Need to make the download for windows page.

Need to create the page when the user clicks the Download for Windows button.

Plaassign this issue to me.

Plaassign this issue to me.

Alright, @Vaibhav1808, I am assigning this issue to you.


Resolve magic constants to a resolved path

I have some php code that looks like this:
    public function checkInternalGroupPermissionForPerson(string $auth, ?int $personId) {
        include_once dirname(__DIR__, 3) . '/churchdb/churchdb_db.php';
        $groups = getMyGroupIdsWhereIAmAllowed($auth);
        $personIds = churchdb_getAllPeopleIdsFromGroups($groups);

        return isset($personIds[$personId]);
    }

The lives in a class for which php-aop creates a proxy. The file churchdb_db.php does not need a proxy and so the include does not work.
How can i solve this?

Hi @djschilling,
I will have a look at this in the evening :)

https://www.php.net/manual/en/language.constants.magic.php

This seems to be a bigger problem than I thought. This is, like I thought, a problem with magic constants. When a class is matched by AOP, it will be proxied and woven. The proxy is a 1:1 copy of the original class which extends and includes the woven class. The woven class is the class that does the whole AOP logic. Inside the proxied class I can replace all magic constants, which works. I will commit this change shortly.
But here is where it gets complicated, lets imagine a matched class has a trait or extends another class. If that class also includes magic constants like __class__ or even self::class, they also have to be resolved, but won't be, because they itself aren't matched, only the class that uses them.
Possible solutions:
Solution 1:

If a class matches, proxify all their traits, parent classes and interfaces as well without creating a woven class.

Problems:

What if a non-matched class is loaded first and has the same trait/parent class/interface as well? Once the ClassLoader loads a class, it cannot be replaced (at least in the ClassLoader itself, maybe there is a spl_ function that can achieve that?)

Solution 2:

Just proxify EVERY class

Problems:

Unnecessary matching
Can lead to more problems
Probably slower

Hi @djschilling,
I have released Okapi/AOP - 1.2.9 which fixes the bug partially. You should have no problems when using __DIR__ anymore, but when your matched class has a trait/interface/parent class which uses __class__ or self::class and is not matched by any aspect, it might have a __AopProxied suffix. Besides that, everything should work fine now, especially for your use-case :)
I'm keeping this issue open for the other bugs.

I updated to 1.2.9 but this is still not working:
    public function getGroupsWhereUserCan($permission, ?array $groupIds = null): array {
        include_once dirname(__DIR__, 3) . '/churchdb/churchdb_db.php';
        return \getMyGroupIdsWhereIAmAllowed($permission, null, $groupIds);
    }

Here is the error:
include_once(/private/var/folders/nx/1shmdfr54sv9r22ql0c4dh680000gn/T/ct-aop-cache/32117/proxies/churchdb/churchdb_db.php): Failed to open stream: No such file or directory

/private/var/folders/nx/1shmdfr54sv9r22ql0c4dh680000gn/T/ct-aop-cache/32117/proxies/src/Auth/Permissions/PermChecker.php:309
/private/var/folders/nx/1shmdfr54sv9r22ql0c4dh680000gn/T/ct-aop-cache/32117/proxies/src/Auth/Permissions/PermChecker.php:309
/Users/david/projects/churchtools/system/src/Domain/Finance/CostCenter/CostCentersAccountingPeriodPermissionResolver.php:40

PermChecker.php : system/src/Auth/Permissions/PermChecker.php
churchdb_db.php: system/churchdb/churchdb_db.php

Hi @djschilling,
I will try it with your code and see what's going wrong.

Hi @djschilling,
Sadly I can't reproduce your error.
I tried testing it like this: $this->data = require dirname(__DIR__, 3) . '/AdviceBehavior/Include/Database/data.php'; and it worked without a problem.
The code in the __AopProxied class does look like this: require dirname('C:\Projects\okapi\php-aop\tests\Functional\AdviceBehavior\Include\Target', 3) . '/AdviceBehavior/Include/Database/data.php';
Can you tell me what your proxy file looks like?


Markdown file, with links to other markdown files: how to make these links work?

Hi,
I'm building a RTD manual markdown based. Than first of all thank you for recommonmark!
I have a lot of md files, with this kind of links [my text](myfile.md).
But when I compile my RTD project, these link remain linked to the md files. I have in example my text and not my text.
Do I must change [my text](myfile.md) in [my text](myfile.html)? Is it the only way to use links to other markdown files in the repo?
Thank you

The links(which are not urls) in markdown are resolved by sphinx :any: role, which lets you reference :doc::

Link to the specified document; the document name can be specified in absolute or relative fashion. For example, if the reference :doc:parrot occurs in the document sketches/index, then the link refers to sketches/parrot. If the reference is :doc:/people or :doc:../people, the link refers to people.

If no explicit link text is given (like usual: :doc:Monty Python members </people>), the link caption will be the title of the given document.

In this way [Link text](:doc:/myMDfile)?
Thank you

There is no need to put the role. It should just be [Link text](/myMDfile) or the relative path with [Link text](myMDfile).

Thank you


SvgUri with Color

How to set the color of svg loaded from url?
<SvgUri 								width="80%" 								height="80%"<EMAIL_ADDRESS>							color="red"                                 fill="red" 							/>
the snippet is not changing color.
Thank you.

Same issue here.

any solution to this ??
I tried color fill stroke. nothing changed.

Same here.
I understood that 'color' and 'fill' props intended to override all 'fill' and 'color' attributes on file.
That would be great to have a way to inject our own CSS too. (Insert That-Would-Be-Great-meme.jpg)

I've used this workaround for my icons:
<SvgXml width={45} height={45} xml={xml.replace(/black/g, 'red')} />

Using SvgXml works for me too!
To change SvgUri to SvgXml, I simply used fetch like this.
I give a closed tag to the useState, that otherwise Unexpected end of input error occurs.
const [imgXml, setImgXml] = useState('<svg></svg>');

useEffect(() => {
  getImgXml();
}, []);

const getImgXml = async () => {
  const url = await getURL();
  const xml = await (await fetch(url)).text();
  setImgXml(xml);
};

<SvgXml
  xml={imgXml.replace(/white/g, props.fill).replace(/#323232/g, props.stroke)}
  width={pieceSize}
  height={pieceSize}
/>

@midorimici This works well thank you! I just had to tweak the RegEx to this: (["'])(?:(?=(\\?))\2.)*?\1
So my markup is now like this:
<SvgXml
  xml={imgXml
    .replace(/fill=(["'])(?:(?=(\\?))\2.)*?\1/g, `fill="${colors.iconFillColor}"`)
    .replace(/stroke=(["'])(?:(?=(\\?))\2.)*?\1/g, `stroke="${colors.iconStrokeColor}"`)}
  width="24"
  height="24"
/>


Fix numerous pyright errors

Part of #668
I have done all of the code that MX touches (except XBPM, which is addressed by https://github.com/DiamondLightSource/dodal/pull/715). @callumforrester and @DiamondJoseph - I have fixed a couple of the obvious ones outside of this but there's a dozen or so left would you be able to take a look so that we can enable pyright proper?
Instructions to reviewer on how to test:

Confirm tests still pass
Confirm less pyright errors when running pyright .

Checks for reviewer

[ ] Would the PR title make sense to a scientist on a set of release notes
[ ] If a new device has been added does it follow the standards
[ ] If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
[ ] Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

I'm taking a look at the remaining issues, I'll make a PR into this branch so you can make further changes if required


Markdown Preview cache

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:1.65.2
OS Version:win10

Steps to Reproduce:
1.open folder with .md file, open the file, open it's Preview .
2.switch to the file, edit and save it .
3. switch to the Preview .
4. repeat 2. and 3. .
5. switch to the file, switch to the Preview . the Preview will show the state which was at the opening .

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

i also copied all settings and extensions . no, the issue seems currently solved in 1.66 .

Ok, closing since it is already fixed in insiders then


feat(catalog/[...]): schedule via config + backend-plugin-api support

Hey, I just made a Pull Request!

For: awsS3, azure, bitbucketServer, gerrit, gitlab

Add option to configure schedule via app-config.yaml
Add backend plugin

Relates-to: PR #13859
(github, ldap, msgraph will follow in separate PRs.)
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

remove stale

@freben just in case this one slipped through / was overlooked

Yep we just piled up a bunch of stuff, on it!


including HEALTHCHECK

Any plans on including docker new HEALTHCHECK?
https://docs.docker.com/engine/reference/builder/#/healthcheck
This is really useful because usually the db is not ready when other services are.

See my thoughts on this issue in https://github.com/appropriate/docker-postgis/issues/34#issuecomment-233194764

Thanks @md5, yeah it makes totally sense to have the HEALTHCHECK into postgres main docker image. Thank you!


Governance. Threshold. Does not show threshold

Description
There should be a treshold line on main page and inside details
Expected Behavior

Actual Behavior

Environment
https://github.com/novasamatech/nova-spektr/commit/c6cab9a77901643d2b55b7441798a121ebfec930

Status verification: ✅


feat: make has_body queryable on methods

Hi 👋🏻,
Retrieve the has_body property on function like items and expose it to queries.
If I understand correctly, this is what's blocking for some lints in obi1kenobi/cargo-semver-checks#870.

Very nice, excellent work!
Would you mind adding some test cases? Check out src/adapter/tests.rs for the existing tests. You can create a new test crate with cargo new <crate_name> --lib and then add test code in it. Cases we probably want to cover:

top-level function
method inside an impl block
trait method with / without body
function in extern block: https://doc.rust-lang.org/std/keyword.extern.html

As an aside, I notice we are lacking a CONTRIBUTING.md file in this repo. Would you care to add one in a separate PR? No worries if that doesn't sound interesting, just offering more places where contributions are welcome :)

I might have caught this before it was ready for review, sorry if that's the case.
I just noticed there are a couple of minor bugs in the test cases, and what looks like an accidental copy-paste artifact in the test code. You were probably already on the way to fixing those, I just wanted to mention them to be sure!

I consider the PR ready for review. I just don't see which minor bugs you are talking about.

🤦🏻 Thanks for fixing

It's all good! Thanks for the PR!
I think you might have uncovered a bug in some of my code in the process, actually. It doesn't cause any correctness issues in cargo-semver-checks, but it might be negatively affecting performance. I'll have to look into it when I have a few minutes.

#400 is the bug, in case you're curious. Thanks for helping surface it!


Fixes to initialization

This PR fixes some issues with initialization of the module:

If Usercentrics has already initialized and window.UC_UI is available before this react module's code is loaded, the initialization window event might be missed. Check during mount of the UsercentricsProvider React component whether this is the case. This should fix the useIsInitialized() hook never returning true in this case.
The useHasUserInteracted() hook currently only checks localStorage, so what it really returns is "has user interacted in the previous session". Move this behavior into the service state so that it changes to true during runtime, when the consent status is given. This should make the hook switch value automatically without needing to reload the page

Marked as Draft until manual testing is done.

After manual testing this seems to be working fine.

:tada: This PR is included in version 1.4.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bug: Rivals don't get Wounds in SWA Import

Tested: Clean Alpha 14 world, unmodified SWA file
Every rival's health looks like this:

Note: Minions have the correct number of wounds per unit, Nemeses have the correct number of wounds and strain.

Good catch on this one.  For minions we populate unit_wounds, for rivals and nemesis we populate wounds, but wound's doesn't have a display on the minion sheet.  We should change the SWA import to use unit_wounds for rivals.

Good catch on this one.  For minions we populate unit_wounds, for rivals and nemesis we populate wounds, but wound's doesn't have a display on the minion sheet.  We should change the SWA import to use unit_wounds for rivals.

Perhaps after looking at #723 as well we just need to move Rivals to use the standard character sheet.  We can hide strain, but the sheet might look off with that field missing.  Adding criticals to the minion sheet seems counter production, since we only recognize character and minion as actors

Perhaps after looking at #723 as well we just need to move Rivals to use the standard character sheet.  We can hide strain, but the sheet might look off with that field missing.  Adding criticals to the minion sheet seems counter production, since we only recognize character and minion as actors

Hiding Strain seems like a good move for now.  It gets the foundry system closer to the game ruleset with (hopefully) minimal work.

Hiding Strain seems like a good move for now.  It gets the foundry system closer to the game ruleset with (hopefully) minimal work.

Also Rival sheets probably shouldn't have a quantity field, now that I think about it

Also Rival sheets probably shouldn't have a quantity field, now that I think about it

Grrr... can't just hide strain... as stated we don't have a proper Nemesis or Rival type so we have no idea when we should hide the Strain.  That's one reason why I made an Adversary sheets to get rid of the items they don't need.

Grrr... can't just hide strain... as stated we don't have a proper Nemesis or Rival type so we have no idea when we should hide the Strain.  That's one reason why I made an Adversary sheets to get rid of the items they don't need.

Hmm.  I've seen the Adversary sheets on some dropdowns (specifically in the PC sheet choices) but they don't seem to show up on the actual adversaries.  What's the story there?

Hmm.  I've seen the Adversary sheets on some dropdowns (specifically in the PC sheet choices) but they don't seem to show up on the actual adversaries.  What's the story there?

In dev branch, will be part of alpha 19


Get an error and Dbeaver is being hung when trying to save modified view

System information:

Operating system (distribution) and version: Windows 10, 1903
DBeaver version: 6.3.3

Connection specification:

Database name and version: AWS RDS MySQL 5.7

Describe the problem you're observing:
Trying to save changes in view via "Persist changes" window throws error message and Dbeaver is being hung until the process is killed.

Steps to reproduce, if exist:

go to your_connection > your_database > Views
double click on a view to open its properties
make some changes in the view statement
click "Save" button

Error Log:
errorlog.txt

@uslss This bug is reproduced even for column/table modifications. It occurs mostly on every second attempt to persist changes for modified database object. For instance, I modify a column, click on "Persist" - everything is ok, then open another table, modify its column and now get an error.

Fixed

verified


519 tbody working rows

toolbar containers no longer change size when content is empty
more unit tests

Codecov Report

Merging #523 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
+ Coverage   88.18%   88.26%   +0.07%
==========================================
  Files          39       39
  Lines        4445     4440       -5
  Branches      311      300      -11
==========================================
- Hits         3920     3919       -1
+ Misses        507      503       -4
  Partials       18       18

Impacted Files
Coverage Δ

src/tablefilter.js
92.78% <100%> (+0.37%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175a239...12e4052. Read the comment docs.

👍


Revert "Add setup.py to enable editable install"

Reverts OpenZeppelin/nile#52

hello @kazhup! do you mind describing the intention of your PR and what problem does it solve?


[hotstar] hotstar is not working anymore.Not geo restricted

hotstar.com videos are not downloadable in INDIA .
I am getting this error video for any download
https://files.fm/u/mrpak8c5
Not some geo restriction issue.

try it yourself before closing this.

Bother to read issue template.


feat(onebox): Add ability to select search results as follow up context

This PR adds the ability to select one or multiple code search results
as follow up context items.
Overview over behavior:

When the search results are loaded a chip referencing all currently
shown search results in inserted into the next prompt input.
Deselecting the 'global' checkbox will unselect all individual
checkboxes and remove the context chip.
Conversly, selecting it will select all individual checkboxes and
insert/update the context chip.
Deslecting/selecting an individual checkbox will update the context
chip.
Clicking 'more results' will select the additional results by default
and update the context chip.
Asking a follow up question will remove the checkboxes. They are only
available if the response is the last interaction.

Technical notes:

I added a new package, valibot, which is a light weight runtime
assertion library. I use it to ensure that the data of the context
item (which is not strongly typed) is valid.
The prompt editor API is difficult to use due to it returning
promises and it also doesn't work as expected. E.g. if
filterMentions is used but the input doesn't contain any mentions
the promise returned by it doesn't seem to resolve. Because of this I
couldn't use it together with addMentions to update the existing context mention chip.
Instead I had to add a new API, upsertMentions that would perform the desired
operations.
This PR also fixes an existing bug where we would show the incorrect
result count when we get fewer than DEFAULT_RESULTS_LIMIT results.

Test plan
Manual testing.

This change is part of the following stack:

#6329

#6347 ◀

Change managed by git-spice.

Made some visual adjustments based on @rrhyne's feedback.

Before
After


Review added at repo-reviews.github.io

Thank you for building RealChar!
@richardanderson001 created a review titled:
Realtime Character AI platform,
on repo-reviews.github.io to share their experience using RealChar.
link to review
If you would like to help your super-users share their experiences using your repo, add a badge to your README.md.
We hope that sharing these experiences helps your users increase their productivity.
--
Please be kind,
I’m a human!

Nice! Thanks for the review. Bookmarked this page too.

Thanks!  Just fixed the urls in the review as well- looking forward to seeing what's next!


List of devices not appering on windows 2022 server

However Microsoft finally added bluetooth to their server line operating systems, there is an issue with your app :(
It simply ignores left mouse click on tray icon, right clicks opens bluetooth connections without an issue.
Tried with fully installed bluetooth drivers (one from widcomm and one newer from Asus)
Bluetooth hardware - Asus BT400 usb dongle.

Same issue on 21H2 (LTSC).

Maybe it could be a service disabled on server/LTSC, or a missing dependency?
If disabling WLAN autoconfig service, left mouseclick also wont show available wifi AP list.


Fix build issues after libspdm refactor

libspdm was refactored to bring cryptography functions out of library/ and into /os_stub. spdm-emu needs access to those functions to build properly.
Signed-off-by: Steven Bellock<EMAIL_ADDRESS>

Merging this now since it fixes a build issue.


Visual Studio 2019 v16.6.1: Help missing for options dialogs

After updating to Visual Studio 2019 v16.6.1, again quite a number of help pages are missing.
Please, don't publish a new Visual Studio version to public without having help pages for all options available at the ready.

This issue was moved to MicrosoftDocs/visualstudio-docs#5495


Alignment Issue

Anyone know why the filters are like these?

Thanks!

@h0ujun Please refer to https://stackblitz.com/edit/angular2-multiselect-dropdown . Please make sure you have installed the package properly


Add .vscode/settings.json and point to all folders inside book directory

@klyburke Instead of User Settings, let's add settings to Workspace Settings?
So instead of relying on book readers to configure VS editor manually based on book's code, we provide ready-to-use .vscode/settings.json file that contains Workspace Settings.
Here is an example: https://github.com/async-labs/saas/tree/master/.vscode

Click to see Hill for issue #118

Click to see Hill for all issues

created by Async

Instead of a .vscode/settings.json file per chapter, I updated the description in Chapter 1 to modify Workspace instead of User settings.
That way the settings will apply to working on the builder book project but should not affect a person's own settings for VS Editor. I think we were seeing problems while switching to work on other projects.
https://builderbook.org/books/builder-book/app-structure-next-js-hoc-material-ui-server-side-rendering-styles#vs-editor
Here's more about it in VS Editor docs:
https://code.visualstudio.com/docs/getstarted/settings

You updated the description, but the visual still shows the User settings not the workspace settings.  This was a bit confusing, but once I found this issue and the response, everything became a bit clearer.  Should a separate issue be raised to make the visual consistent with the description?
I'll be looking for/reporting a separate issue regarding eslint configuration for vscode.

@callahanp Thanks for reporting. I will update the old image with a new one.

@callahanp Sorry for the delay here. I have been traveling.
I removed the snapshot showing User Settings, as I realized it was not necessary and only caused confusion. Thanks again for catching.
As mentioned in #218, I will work on switching to the prettier-eslint package instead of prettier. This change will affect the Workspace settings, as they will no longer need "prettier.eslintIntegration": true.

no worries.
If you can give me a thumbnail sketch of what to do in this area, I can try
it here and test.
or I can just wait till you get to it.
-Pat
On Fri, Oct 4, 2019 at 10:53 PM Kelly Burke<EMAIL_ADDRESS>wrote:

@callahanp https://github.com/callahanp Sorry for the delay here. I
have been traveling.
I removed the snapshot showing User Settings, as I realized it was not
necessary and only caused confusion. Thanks again for catching.
As mentioned in #218
https://github.com/builderbook/builderbook/issues/218, I will work on
switching to the prettier-eslint package instead of prettier. This change
will affect the Workspace settings, as they will no longer need "prettier.eslintIntegration":
true.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/builderbook/builderbook/issues/118?email_source=notifications&email_token=ABOZDUE7CNZT3XM5BDRL7BDQM76S5A5CNFSM4FWSNSD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANIURQ#issuecomment-538610246,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABOZDUD3NINHZOMQCRVOA2TQM76S5ANCNFSM4FWSNSDQ
.

@klyburke This is done in latest update to the codebase.


StateMachineDotExporter and StateMachine2CyTranslator needs to consider directed/undirected edges

the new components StateMachineDotExporter (to make DOT files representing the SM transition diagram) and StateMachine2CyTranslator (to translate a SM file into Cypher queries) need to consider transitions with directions (ie, those transitions that are instances of DirectedEdgeTransition and comes from the 'd' flag in the SM files). At the moment these components assume all transitions are directed from left to right node ('forward', using the terminology inside the SM code). The current code defines constant for all of forward, backward and bidirectional, but backward isn't supported from the flat file parser, so we're not going to implement it in the mentioned component.

(closing) Now directed transitions are considered and the corresponding code tested.


Pinch and zoom for floor map

Idea Description
The title says everything
Reference images and links

@takahirom Many apologies for last issue. 🙇🏼
Could I try this issue?
If you'd like, I will get right on it.

I know not everyone always sees GitHub. It's OK. But if you can respond, please respond. 🙏   Thanks, Assigned 👍

I will check Github from now on. 🙇🏼
Thanks for assigning!


Release 2.1.0

Questions
Answers

Description?
Release 2.1.0

Type?
improvement

Hi @PierreRambaud,
I found one regression in this release: https://github.com/PrestaShop/PrestaShop/issues/27135
As discussed with @Robin-Fischer-PS, this release blocks the develop branch, so we will accept the release but we need to create another release to fix this issue soon.
I found other issues when testing the release but they are not regressions:
https://github.com/PrestaShop/PrestaShop/issues/27128
https://github.com/PrestaShop/PrestaShop/issues/27131
https://github.com/PrestaShop/PrestaShop/issues/27134
https://github.com/PrestaShop/PrestaShop/issues/27136
https://github.com/PrestaShop/PrestaShop/issues/27140
https://github.com/PrestaShop/PrestaShop/issues/27142
https://github.com/PrestaShop/PrestaShop/issues/27143
https://github.com/PrestaShop/PrestaShop/issues/27144
https://github.com/PrestaShop/PrestaShop/issues/27145
Thank you!

Hi @PierreRambaud,
I found one regression in this release: PrestaShop/PrestaShop#27135 As discussed with @Robin-Fischer-PS, this release blocks the develop branch, so we will accept the release but we need to create another release to fix this issue soon.
I found other issues when testing the release but they are not regressions: PrestaShop/PrestaShop#27128 PrestaShop/PrestaShop#27131 PrestaShop/PrestaShop#27134 PrestaShop/PrestaShop#27136 PrestaShop/PrestaShop#27140 PrestaShop/PrestaShop#27142 PrestaShop/PrestaShop#27143 PrestaShop/PrestaShop#27144 PrestaShop/PrestaShop#27145
Thank you!

We don't care about the develop branch when a module release can affect websites in production.
We have to fix all issues first!

PrestaShop/PrestaShop#27144

Update:
Only 3 issues remain open
https://github.com/PrestaShop/PrestaShop/issues/27142
https://github.com/PrestaShop/PrestaShop/issues/27143
https://github.com/PrestaShop/PrestaShop/issues/27144

Hello @PierreRambaud ,
After further testing with @khouloudbelguith , here is what we found :
3 regressions :
https://github.com/PrestaShop/PrestaShop/issues/27478
https://github.com/PrestaShop/PrestaShop/issues/27327
https://github.com/PrestaShop/PrestaShop/issues/26349
Other issues :
https://github.com/PrestaShop/PrestaShop/issues/27488
https://github.com/PrestaShop/PrestaShop/issues/27474

How much longer until new release? It's hard to use this module in current state.

Hi @PierreRambaud, @Progi1984,
It is ok :heavy_check_mark:
I checked this release with 1.7.8x & develop branch
I have some issues but they are not regressions

https://github.com/PrestaShop/PrestaShop/issues/28325
https://github.com/PrestaShop/PrestaShop/issues/28326
https://github.com/PrestaShop/PrestaShop/issues/28324

Thanks!

Thanks @khouloudbelguith


[wip] Fix satellite fetching race condition

Fixes #513.
This is only for the core app; once we settle on the correct way to fix this, I'll apply it to scoring as well.

I see that you updated the task or the downloading of modelRun images but the same problem then exists, where the modelrun download requires that the celery task be up and running before it is initiated and generates the SatelliteFetching rows.
This is going to require a change to: https://github.com/ResonantGeoData/RD-WATCH/blob/main/rdwatch/core/views/model_run.py#L511

This might still be an issue, but this PR is very outdated at this point and will likely need to be redone. I won't be working on this for the foreseeable future, so I'll close this and we can open a new one when/if needed


cassandra location in master.xml

@h1alexbel thank you for reporting this. I'll assign someone to take care of it soon.

@h1alexbel this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2023-08-20T12:59:16.678486.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


[Tests] Refactored parsing of scheme from repo URL, added Collection tests

refactored parsing of scheme from repo URL
renamed that function from URL.scheme to URL.repoScheme to signal that it's not a generic URL scheme parser (which would not work as we need it to here)
moved Array utils to Collection utils
added Collection tests
moved all allTests functions into one file (Utilities modules only for now), previously they were in FileTests which was hard to find

I appreciate the effort, but this wasn't merged earlier because it is really several PRs. The additional tests are most interesting to me, and I'm happy to have a general Collection utils organization. The rest is not really desired, though I certainly can see the improvements, I'd rather improve the tests in general, but I'm waiting on the Linux test generation work.
I understand URL.scheme is not general, but I dislike repoScheme, and it's not as though this is public API in Cocoa or anything.

@mxcl I renamed repoScheme back to scheme, so those changes are reverted. What's left is the repo scheme parsing refactoring and the new tests and moved manifests. Are those the changes you wanted to keep? If not, please let me know which part exactly you have reservations about.

@swift-ci Please test

@mxcl @swift-ci seems to be in a lazy mood

@swift-ci Please test

Hitting the same WatchKit test failure as everyone else.

@mxcl Please rerun CI

@swift-ci Please test

\o/


Apache2 not starting on container start?

Hello,
Thank you for creating this image ... it's great!  I do have one issue ... Apache2 is not starting when I launch the container.  I've been trying to dig for logs or any way to debug this, but I can't find anything.  dmesg fails, etc.
Any ideas on why?
Each time I launch the container I have to issue a "service apache2 restart" and then everything is ok.

Hi, thank you for this report.
Could you specify the operating system where you installed docker?
Thank you

Hello,
It's on two different machines, and I just realized they are both OS-X machines.  One is an iMac (Mojave) and the other is a MacBook.  I haven't tested on other platforms.  Latest Docker Desktop on both.

Unfortunately I don't have a mac to do a test
I have seen that in the past there was a similar problem with Windows that could be solved in this way
https://github.com/atsanna/codeigniter4-docker/commit/076e248f9a3d7d0ea1a3275f4eac1cab0313074f
For some reason this modification was lost and I need to restore it.
Try replacing line 35 in the Dockerfile
from so
ADD startScript.sh /startScript.sh
to so
RUN printf "#!/bin/bash\nmv /codeigniter4 /var/www/html\n/usr/sbin/apache2ctl -D FOREGROUND" > /startScript.sh
build the image
docker build . -t codeigniter:4.1.1
and start the container
docker container run --publish 80:80 --name ci4 -v /localfolder:/var/www/html codeigniter:4.1.1

Hello,
This is strange, but the file was there, and appears to be the correct contents.
root@e546834a0bac:/var/www/html# cat /startScript.sh
#!/bin/bash
mv /codeigniter4 /var/www/html
/usr/sbin/apache2ctl -D FOREGROUND
root@e546834a0bac:/var/www/html#
I added an extra "\n" at the end to test that also.  But it still is not working.
Any other ideas?

Also, I'm not sure if this helps, but when I tried to manually run the command, i got this output:
root@e546834a0bac:/var/www/html# /usr/sbin/apache2ctl -D FOREGROUND
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using <IP_ADDRESS>. Set the 'ServerName' directive globally to suppress this message
AH00558: apache2: Could not reliably determine the server's fully qualified domain name, using <IP_ADDRESS>. Set the 'ServerName' directive globally to suppress this message
[Fri Apr 30 14:51:02.991322 2021] [core:warn] [pid 66] AH00098: pid file /var/run/apache2/apache2.pid overwritten -- Unclean shutdown of previous Apache run?
[Fri Apr 30 14:51:02.997759 2021] [mpm_prefork:notice] [pid 66] AH00163: Apache/2.4.38 (Debian) PHP/7.3.27 configured -- resuming normal operations
[Fri Apr 30 14:51:02.997787 2021] [core:notice] [pid 66] AH00094: Command line: '/usr/sbin/apache2 -D FOREGROUND'


Vagrant Package step in the read.me

At a point near the end once you've set things up, do you think that it makes sense to package the box up so you can use it as a base to quickly spin back up the vagrant environment?  This would only be a solution for folks using Virtual Box Providers
http://docs.vagrantup.com/v2/cli/package.html

I’ve added version 0.1.0 to Atlas. I’m doing some manual testing now, but you should be able to add the following to your Vagrantfile to use it.
config.vm.box = "oakensoul/ansible-citadel"

As mentioned above, it is available from Atlas, however due to the unpredictable (and often poor) performance from there, i’ve added to AWS.
config.vm.box = "oakensoul/ansible-citadel"
config.vm.box_url = "https://s3.amazonaws.com/oakensoul/vagrant/ansible-citadel.box"


Add ogem

Key Features

One API for Everything: Use OpenAI's API format for all models (GPT-4, Claude, Gemini)
Smart Routing: Automatic latency-based routing
Fallback Support: Chain multiple models (gpt-4,claude-3-opus,gemini-1.5-pro)
Multi-Architecture Docker: Ready for both ARM64 and AMD64

Links
GitHub: https://github.com/yanolja/ogem
Docker Hub: ynext/ogem
Although I haven't tried it, the failover support looks interesting.

Thanks for bringing this in! I also saw the post on r/LocalLLaMa when it was announced. I decided to wait for some time to see if it'll gain any usage, as it overlaps a lot with LiteLLM/OptiLLM

After some time in the oven - it doesn't look like ogem is getting traction or being developed further, so I won't be actively working on this integration.
With that said, I'm of course open to the contributions in the future and will help in any way I can.


removed Robert Outlaw's ID

Removed former affiliation of Robert O~.  Changed ms.date to be current.


Fix syntax in example if statement

The and in the example if statement appears to be out of order. With the position shown, I see an error when trying to do a dry-run of the install error calling eq: invalid type for comparison:
$ grep and templates/configmap.yaml
  {{ if and (.Values.favorite.drink) (eq .Values.favorite.drink "coffee") }}mug: true{{ end }}
$ helm install --dry-run --debug .
[debug] Created tunnel using local port: '33955'

[debug] SERVER: "<IP_ADDRESS>:33955"

[debug] Original chart version: ""
[debug] CHART PATH: /home/mark/Downloads/mychart

Error: render error in "mychart/templates/configmap.yaml": template: mychart/templates/configmap.yaml:9:38: executing "mychart/templates/configmap.yaml" at <eq .Values.favorite....>: error calling eq: invalid type for comparison

When I move the and the example appears to work fine:
$ grep and templates/configmap.yaml
  {{ if (.Values.favorite.drink) and (eq .Values.favorite.drink "coffee") }}mug: true{{ end }}
$ helm install --dry-run --debug .
[debug] Created tunnel using local port: '35277'

[debug] SERVER: "<IP_ADDRESS>:35277"

[debug] Original chart version: ""
[debug] CHART PATH: /home/mark/Downloads/mychart

NAME:   happy-unicorn
REVISION: 1
RELEASED: Thu Dec  6 15:01:07 2018
CHART: mychart-0.1.0
USER-SUPPLIED VALUES:
{}

COMPUTED VALUES:
favorite:
  food: pizza

HOOKS:
MANIFEST:

---
# Source: mychart/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: happy-unicorn-configmap
data:
  myvalue: "Hello World"
  drink: "tea"
  food: "PIZZA"

I'm seeing this output for the ci/circleci: build test that failed:
Allocating a remote Docker Engine
Got error while creating host: failed to create host: rpc error: code = Unknown desc = failed to create VM: Put https://vm-service.infra.circleci.com/tasks/5c094d2814144c00080b5e74-1-build%2F23A2166B: net/http: TLS handshake timeout
We had an unexpected error preparing a VM for this build, potentially due to our infrastructure or cloud provider.  Please retry the build in a few minutes

Please do let me know if I'm not following the appropriate procedure for the helm project here.
I got to this PR by clicking the Contribute to Docs link and then looking for the appropriate file to update.

Hi @markcraig
Thanks for working to make Helm better. I looked into this and the example worked as written for me.  As noted in the examples you will get an error if the example values are not defined. Could you double check?

Sorry for the delay.
Today I've upgraded minikube and helm, and no longer see the problem:
$ helm version
Client: &version.Version{SemVer:"v2.12.1", GitCommit:"02a47c7249b1fc6d8fd3b94e6b4babf9d818144e", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.12.1", GitCommit:"02a47c7249b1fc6d8fd3b94e6b4babf9d818144e", GitTreeState:"clean"}

$ grep and templates/configmap.yaml
  {{ if and (.Values.favorite.drink) (eq .Values.favorite.drink "coffee") }}mug: true{{ end }}

$ helm install --dry-run --debug . > /dev/null
$ echo $?
0

So I'll close this one.


terraform: 1.3.6 -> 1.3.7

Description of changes
https://github.com/hashicorp/terraform/releases/tag/v1.3.7
Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Built on both darwin platforms.


Cannot download file larger than<PHONE_NUMBER> bytes

Hello!
I have some large files which I am downloading, about 2GB - 8GB. It seems the download finishes 'early' each time and cannot surpass 976,560 kb, is this a limitation of the library?
Very clean library! I just wish that I can get it working for larger files.  Thanks!

Hello!
I just read your code and saw that you have a default file max size. Just wondering why you have that type of limitation? I have never seen that before in a file download library.  Just wondering your reasons.
Line number: 42 >> DownloadClient.cs <-- for those readers who have not looked at the code yet.
10GB+ is many zero's, I did not trust myself to formulate the numbers properly, so I used the library ByteSize to make it easier.

Would love to know your thoughts on the max size! thanks again for the great library.

Suggestion
Would be great if the constructor could also accept double and long, instead of only `long.

Hello,
To clarify, the library has two options for download which are both asynchronous

In Memory - download & return byte[]
To File - download & save to file void

In Memory
This option downloads the data holding it in memory and returns a byte[]. Due to .Net limitations, an OutOfMemoryException or OverflowException is bound to be thrown if you exceed the max size.
This wouldn't mean that your machine ran out of memory but symbolizes a 2GB max-size-per-object limitation imposed by the Microsoft CLR.
Under the hood, this download option uses a MemoryStream. But since MemoryStreams are built around byte arrays, they are subject to the same memory limitations.
To File Download
This option is much flexible and the default max limit can be overridden by passing your custom maximum in the constructor when you instantiate the client.
Under the hood, it uses a FileStream of your target download path to write to.
It works because FileStream allows writing data to disk in chunks as we download it.

However, there seems to be a workaround around the aforementioned limitation by adding the following to your configuration
<gcAllowVeryLargeObjects> element
I haven't tried it out yet so I can't comment.


The response was received at ${url_to_acs} instead of ${unix_path_to_acs}

Hello there.
I've got some problems to use onelogin with a PHP app.
We need to receive the response on the url of the acs.
So I set everything in settings.php to match our needs.
But the only way to have a response is to set the host name in that file.
I think it comes from the loadPaths() method in OneLogin_Saml2_Settings class.
I don't know if I'm clear, I can provide you more information, but I'm stuck behind a confidentiality clause, and I don't want to give more info than needed.
Sorry for the lack of precise information, don't hesitate asking

My acs url was at https://domain/sso/{organizationId}/acs I had my baseurl setup as $baseUrl = 'https://domain' and was defining acs url as $acsUrl = $baseUrl . '/sso/{organizationId}/acs' This was always return this error "The response was received at ..... "
The way to solve this was to setup $baseUrl as $baseUrl = https://domain/sso/{organizationId} and acs url as $acsUrl = $baseUrl . "/acs"


Post-release January 2023

This PR:

Updates package-lock.json for recently published packages
Updates CDN link and usage docs for MSAL Browser

Codecov Report

Merging #5547 (79f920c) into dev (011c397) will increase coverage by 0.44%.
The diff coverage is n/a.

Flag
Coverage Δ

msal-angular
96.50% <ø> (ø)

msal-common
85.22% <ø> (ø)

msal-core
?

msal-node
83.37% <ø> (ø)

msal-node-extensions
76.03% <ø> (?)

msal-react
94.68% <ø> (ø)

node-token-validation
88.88% <ø> (ø)

Impacted Files
Coverage Δ

lib/msal-core/src/cache/BrowserStorage.ts

lib/msal-core/src/cache/AccessTokenKey.ts

lib/msal-core/src/utils/AuthCacheUtils.ts

lib/msal-core/src/utils/CryptoUtils.ts

lib/msal-core/src/utils/TimeUtils.ts

lib/msal-core/src/IdToken.ts

lib/msal-core/src/telemetry/TelemetryUtils.ts

lib/msal-core/src/telemetry/ApiEvent.ts

lib/msal-core/src/utils/WindowUtils.ts

lib/msal-core/src/telemetry/UiEvent.ts

... and 49 more


[jsx-curly-brace-presence] Bail out in warning JSX expression when some characters exist

This is an attempt to fix https://github.com/yannickcr/eslint-plugin-react/issues/1449, so that the jsx-curly-brace-presence rule, when set to get rid of unnecessary curly braces(JSX expression), will bail out or deem a JSX expression necessary when a character that needs to be escaped in its JSX form is found in the expression. It also improves the fix in enforcing curly braces by escaping backslashes in its JSX form.
Gigantic thanks to @lydell for suggesting the implementation plan for this PR. I hope I didn't screw it up too much. 😄
Let me know if there is any improvement you have in mind.

@lydell
Can't thank you enough for the feedback! Will update the PR soon based on your suggestions!

@lydell
I think I have covered most of the things you said. Let me know if you have any other improvement in mind. 😀

Reviewers: Don't feel intimidated by the walls of comments me and @jackyho112 have exchanged! If you look a the implementation (one file), you'll see that it's pretty clear and concise. The rest of the changes are just docs and tests updates.
TL;DR on the whole issue: Some characters make it unclear* if braces are unnecessary or not. If we find such characters, bail out.
* Because readability can suffer badly.


calculateInSampleSize generates bitmaps smaller than required.

The logic here is wrong. inSampleSize applies scaling to the height and the width of the bitmap,
and so the number of pixels should be scaled by the square of inSampleSize.
ImageResizer.java#L251
    // This offers some additional logic in case the image has a strange
    // aspect ratio. For example, a panorama may have a much larger
    // width than height. In these cases the total pixels might still
    // end up being too large to fit comfortably in memory, so we should
    // be more aggressive with sample down the image (=larger inSampleSize).

    long totalPixels = width * height / inSampleSize;

    // Anything more than 2x the requested pixels we'll sample down further
    final long totalReqPixelsCap = reqWidth * reqHeight * 2;

    while (totalPixels > totalReqPixelsCap) {
    inSampleSize *= 2;
    totalPixels /= 2;
    }

This causes generated bitmaps to be of much lower size than required.

Good catch, it should indeed be divided by the square of inSampleSize. This sample is being reviewed right now to see what updates (or not) will be made.
As a side note, outside of understanding how these APIs work, if you are trying to load images in a real app, we highly recommend using a well tested image loading library such as Glide (https://github.com/bumptech/glide) or Picasso (http://square.github.io/picasso/).

when I add an 3M picture url and  open the some ImageDetailActivity frequently,log shows
com.example.android.displayingbitmaps E/StrictMode: A resource was acquired at attached stack trace but never released. See java.io.Closeable for information on avoiding resource leaks.     java.lang.Throwable: Explicit termination method 'close' not called         at dalvik.system.CloseGuard.open(CloseGuard.java:223)         at java.io.FileOutputStream.<init>(FileOutputStream.java:224)         at java.io.FileOutputStream.<init>(FileOutputStream.java:171)         at com.example.android.displayingbitmaps.util.DiskLruCache$Editor.newOutputStream(DiskLruCache.java:819)         at com.example.android.displayingbitmaps.util.ImageFetcher.processBitmap(ImageFetcher.java:215)         at com.example.android.displayingbitmaps.util.ImageFetcher.processBitmap(ImageFetcher.java:257)         at com.example.android.displayingbitmaps.util.ImageWorker$BitmapWorkerTask.doInBackground(ImageWorker.java:312)         at com.example.android.displayingbitmaps.util.ImageWorker$BitmapWorkerTask.doInBackground(ImageWorker.java:257)         at com.example.android.displayingbitmaps.util.AsyncTask$2.call(AsyncTask.java:313)         at java.util.concurrent.FutureTask.run(FutureTask.java:266)         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)         at java.lang.Thread.run(Thread.java:764)
how it happened

I am closing this issue/PR, as it has been migrated to the new repo linked above in the comments. Thank you!


Fix #1520 use qualified timeout resolver

The timeout settings in the auction settings are no applied properly.
There are others though that are still not working (AMP, video, ?)

Done :)


Don't reuse the HTTPClient instance

Results in SSL socket errors when making concurrent connections:

SSL_read: decryption failed or bad record mac
SSL_read: unknown alert type

Are you sure? HTTPClient is built to reuse connections to one endpoint. Can you provide more information?

I've been trying to reproduce this outside of my project but without success, though I can still reproduce within my project. Leave this open for now and I'll dig a little deeper to find the incompatibility.

Found the same error when abusing threads to put pressure into firebase, so not sure if it was because of the threads (HTTP-Client is thread safe) or because of multiple connections.


Cannot register HTTP broker with Kubernetes plugin

First off, thanks for making this library!
If you try to use the HTTP broker to subscribe to a topic in a Kubernetes cluster, you get this error:
{
  "reason": "FieldValueInvalid",
  "message": "Invalid value: \"micro.mu/selector-topic:MyTopic\": name part must match the regex ([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9] (e.g. 'MyName' or 'my.name' or '123-abc')",
  "field": "metadata.labels"
},

I traced it back to this line: https://github.com/micro/go-micro/blob/master/broker/http_broker.go#L432
When you call Register on the registry for kubernetes, it uses the service's Name to populate the metadata keys. Unfortunately, adding the colon in the http broker violates the regex kubernetes uses.
I think a simple fix could be to change the : to a . or remove it entirely. I can make the PR if you want.

This issue is kubernetes registry related rather than with the http broker. Kubernetes is enforcing constraints on values. The http broker should not have to constrain its formatting for that. The kubernetes registry should validate service names and change where appropriate.
Please file the issue against https://github.com/micro/go-plugins rather than go-micro since its kubernetes registry related.


Fix allCases to generate a let

Description
This commit cherry-picks Fix allCases to generate a let onto the 1.x release branch, which fixed https://github.com/apple/swift-protobuf/issues/1266
Result
Enums allCases property is now a let instead of a var.

I believe you also need to regenerate the reference directory.

Oops, fixed


ERROR in CreditCardDirectivesModule is not an NgModule

MacOS Sierra
version 10.12.4
npm v4.1.2

angular-cli: 1.0.0-beta.28.3
node: 6.9.5
os: darwin x64
@angular/common: 2.4.10
@angular/compiler: 2.4.10
@angular/core: 2.4.10
@angular/forms: 2.4.10
@angular/http: 2.4.10
@angular/platform-browser: 2.4.10
@angular/platform-browser-dynamic: 2.4.10
@angular/router: 3.4.10
@angular/compiler-cli: 2.4.10

I get the following error on attempt to cold restart dev server.
ERROR in CreditCardDirectivesModule is not an NgModule
webpack: Failed to compile.

I'm also getting the same error.
"dependencies": {
"@angular/common": "~4.1.0",
"@angular/compiler": "~4.1.0",
"@angular/compiler-cli": "~4.1.0",
"@angular/core": "~4.1.0",
"@angular/forms": "~4.1.0",
"@angular/http": "~4.0.3",
"@angular/platform-browser": "~4.1.0",
"@angular/platform-browser-dynamic": "~4.1.0",
"@angular/platform-server": "~4.0.2",
"@angular/router": "~4.1.0",
"angular-cc-library": "^1.0.3",
"classlist.js": "~1.1.20150312",
"core-js": "~2.4.1",
"intl": "~1.2.5",
"ng2-bootstrap": "~1.6.1",
"node-testrail": "0.0.12",
"rxjs": "~5.1.0",
"web-animations-js": "~2.2.5",
"zone.js": "~0.8.4"
},
"devDependencies": {
"@angular/animations": "~4.1.0",
"@angular/cli": "~1.0.1",
"@types/jasmine": "2.5.38",
"@types/node": "~6.0.60",
"bootstrap-sass": "~3.3.7",
"codelyzer": "~2.0.0",
"jasmine-core": "~2.5.2",
"jasmine-reporters": "~2.2.1",
"jasmine-spec-reporter": "~3.2.0",
"jasmine-xml2html-converter": "0.0.2",
"karma": "~1.4.1",
"karma-chrome-launcher": "~2.0.0",
"karma-cli": "~1.0.1",
"karma-coverage-istanbul-reporter": "~0.2.0",
"karma-istanbul-threshold": "^1.2.2",
"karma-jasmine": "~1.1.0",
"karma-jasmine-html-reporter": "~0.2.2",
"karma-phantomjs-launcher": "^1.0.4",
"karma-spec-reporter": "0.0.31",
"node-sass": "~4.5.1",
"protractor": "~5.1.1",
"ts-node": "~2.0.0",
"tslint": "~4.5.0",
"typescript": "~2.2.0"
}

I keep getting this issue when using ngc build

Mine is intermittent. I'm using Angular CLI to build / "serve". When I first installed and ran for the first time it worked. Second time, I received this error and the project would not compile.
If we can get past this bug, I really think this project has some potential.

I was able to temporarily byepass this error by using the aot false flag in my production build.
ng build --prod --aot=false
This is a temporal fix.

Next chance I get I will try this.

+1

Have you resolved that issue permanently??
If yes, How??
I am stuck with the same error

+1
I'm getting the same error.  I cannot run 'ng build' at all.

ng build --prod --aot=false
Even after aot false getting same error
ERROR in Unexpected value 'CreditCardDirectivesModule in /node_modules/angular-cc-library/dist/directives.d.ts' imported by the module 'Ap pModule in /src/app/app.module.ts'. Please add a @NgModule annotation.

+1

+1

+1

+1

+1

closed via #15