Gridstack on Meteor

Hi @troolee,
Thx for this library! Totally awesome.
I just worked out how to use gridstack on Meteor. I have implemented persistent edits, which stores the grid tile properties in a Mongo collection. I have to say, it's pretty cool!
Below is the code I've used.
Add existing smart package from atmospherejs.com (https://atmospherejs.com/tarzak/gridstackjs) -- I'm trying to find out if the author will publish their package code onto GitHub.
meteor create myApp
cd myApp
meteor add tarzak:gridstackjs

HTML:

{{> gridstack}}

<template name="gridstack">

</template>

Shared client/server JavaScript to create a Mongo collection
// myApp.js
GridTiles = new Mongo.Collection("gridTiles");
/* GridTiles.insert({
 _id: "abcd", // mongoId
 x: 0,
 y: 1,
 width: 2,
 height: 2
}); */

Client JavaScript
// client/myGridstack.js
Template.gridstack.rendered = function () {
 var gridstackOptions = {};
 Tracker.autorun(function () {
  var gridTiles = GridTiles.find().fetch();
  var grid = $('.grid-stack').gridstack(gridstackOptions).data('gridstack');
  grid.remove_all();
  _.each(gridTiles, function (tile) {
   var widgetElement = $('

')
   if(widgetElement)	{
    grid.add_widget(widgetElement, tile.x, tile.y, tile.width, tile.height);
    widgetElement.attr('data-custom-id', tile._id);
   }
  });
 }); // End autorun
 // Define onchange to update Mongo collection
 $('.grid-stack').on('change', function (event, items) {
  _.each(items, function (item) {
   var attributes = item.el.data();
   GridTiles.update({_id:attributes.customId},
   {x:attributes.gsX,y:attributes.gsY,height:attributes.gsHeight, width:attributes.gsWidth});
  });
 });
};

That's it! =-)
New tiles can be added on the fly (i.e., reactively) just by inserting into the Mongo collection. When you move or resize the tiles, the new locations are saved. The "bindings" are already hooked up because of the Tracker.autorun() function.
The Meteor community is building procedures for libraries like Gridstack.js to have "official" integrations with Meteor (i.e., sponsored by the official maintainers). If you're open to this, I can try to help with the set-up as well as add documentation.

Hi @jonlachlan
Thank you for your feedback!
I didn't have a chance to try meteor but I'm totally open to any contribution. If you can provide a separate module which will implement necessary bindings for it I will include it to the package.

@troolee the packaging is fairly simple (see the package.js file here: https://github.com/tarzak/meteor-gridstackjs) but I'm still learning what is the best pattern for including it in a library as a module. I will get back to you when I can provide that information.
Also, I have changed my pattern for implementing in Meteor. This might make more sense to you, it's definitely a better way of approaching it.
myApp.html (with Blaze markup and templating)

{{> gridstack}}

<template name="gridstack">

    {{#each tile}}
      {{> gridstackItem}}
    {{/each}}

</template>
<template name="gridstackItem">

{{content}}

</template>

Then the common JavaScript (loads on server and on client):
// myApp.js
GridTiles = new Mongo.Collection("gridTiles");
/* GridTiles.insert({
  _id: "abcd", // mongoId
  x: 0,
  y: 1,
  width: 2,
  height: 2,
  content: "This is my content for this item." // added
}); */

Finally, our client-side Javascript. This time, we're using a new gridstackItem template for each content item, and for each gridstackItem that is rendered, we also add_widget to the grid itself.
// client/myGridstack.js
Template.gridstack.helpers({
	tile: function () {
		return GridTiles.find();
	},
});
Template.gridstack.rendered = function () {
 // add onChange event listener
	$('.grid-stack').on('change',function (event, items) {
	  _.each(items, function (item) {
			var attributes = item.el.data();
			BoardPanels.update({_id:attributes.panelId}, {$set:{x:attributes.gsX,
				y:attributes.gsY,height:attributes.gsHeight, width:attributes.gsWidth}});
	  });

	});
};
Template.gridstackItem.rendered = function () {
 // For each widget that is created, we use add_widget to associate it with the grid
	var grid = $('.grid-stack').data('gridstack');
	grid.add_widget(this.$('.grid-stack-item'));
};

@jonlachlan Thanks much for sharing the work. Been looking for something similar and the binding looks good. Will try it out. So this works with direct version of JS, say loaded from CDN also, right ?(without mandatory having to go through the package  route).  No offence, but found most of the packages are being abandoned in couple of months of inception, so made it a habit to prefer and load directly from CDNs.

@KrishnaPG glad you're interested. It's working well for me. Let me know if you can't get it to work.

Thanks @jonlachlan . I am facing a problem and wondering how to address it.
I am using your code listed above and when executed Template.gridstackItem.rendered is getting called  first before Template.gridstack.rendered, which means the grigstack is not initialized before executing this line var grid = $('.grid-stack').data('gridstack');
How to address this? When the collection has elements, the nested gridStackItem templates are getting rendered before the parent's rendered method is called. But since the initialization is happening in the parent template, this is causing problem.

Another issue is: $('.grid-stack').on('change', function (event, items) (...)) is getting called for every item (irrespective of it was moved/affected or not).
For example, please put a console.log() in that and just resize one widget somewhere and we can see all items being reported as changed

I haven't had trouble with initialization order. Perhaps this is an accidental benefit of running the tile helper, which takes a moment to look up the tiles in the database.
My experience is that the change event gives you coordinates for every panel that was affected by the change. Sometimes this gives you "new" panel coordinates for many or even all panels, and sometimes there's not actually a change. In order to ensure that my database always has the correct info, I'm opting to always run the update command. However, rather than making multiple calls, you can bundle it together into a single call and use the {multi:true} option in the update call.

For example, because moving one tile can "push" other tiles around the grid, one change event might have several tiles that change. If moving a tile don't cause collateral changes, the change event from Gridstack should only include one tile.
Because I want to be able to correctly capture the position of all tiles after a change, I'm respecting Gridstack's change event.

I'm also having problems with the initialization order. I get the error TypeError: Cannot read property 'add_widget' of undefined because $('.grid-stack').data('gridstack') is not rendered before Template.gridstackItem.onRendered(function() { ... });

Does anyone know any workarounds?

@jonlachlan How does removing element work in your example? I dont see a call to remove_widget?
@mazing  You could try my binding, the code is a bit messy because it's merely a reproduction path for issue: https://github.com/meteor/meteor/issues/5573
The code:
https://github.com/marcodejongh/reproduce-html-element-data-removed-before-removelementhook/blob/master/reproduce-html-element-data-removed-before-removelementhook.js#L4-L32
Once MDG replied on my issue I will probably also submit a gridstack package to atmosphere using the same principle as in the code I just linked.

Closing this issue due to inactivity. Thanks @marcodejongh for the help. @jonlachlan - feel free to respond and reopen if so inclined.


Textures disappear/display unknown grid after adding a second texture to the Terrain3D texture list

Terrain3D version
v 0.9.3a
System information
Godot v4.3.stable / Vulkan Forward+ / Windows 10 / 3070Ti, I5 12400f
Is the issue reproducable in the demo?
Yes
Issue description
If i add a texture to a Terrain3D, it displays properly. However, when a second texture is added to the list, all textures visually disappear, leaving a large white "unknown" texture. If the second texture is removed, the first one reappears but displays visible lines along its edges, creating a grid-like pattern on the terrain. These lines are noticeable during runtime but only from a distance (they vanish as the camera moves closer).
The white "unknown" texture visual issue seems to not occur when both textures have the same "DTX" version or when both are the same file. However i have found no explanation for the lines issue.
This issue is consistently reproducible in the demo.
https://github.com/user-attachments/assets/8d39be08-9fd6-4d7f-8c51-90e5b8f02a90
https://github.com/user-attachments/assets/7cb626dd-1753-4ca0-b8ee-e9648a26ab71
Logs
No response

However, when a second texture is added to the list, all textures visually disappear, leaving a large white "unknown" texture.

Your console tells you the second texture does not have the same size or format as the first one. Review the requirements in the texture setup documentation.

If the second texture is removed, the first one reappears but displays visible lines along its edges, creating a grid-like pattern on the terrain. These lines are noticeable during runtime but only from a distance (they vanish as the camera moves closer).

You've probably messed up your generated texture array by putting in incompatible textures. You can probably rebuild it by changing scenes, or adding a properly setup texture, or removing the first and readding it, or adjusting any of the texture asset settings.

Using the same format helped whith that white texture issue, thank you ! However changing scenes and using compatible textures did not solve my grid problem, even after setting it in a new project.

When exactly does the black grid appear? e.g. how many textures, when applied on ground?
If you add more textures does it change?
Is it there if the textures are in the asset dock but not on the ground?
The black lines are different widths. What caused that? Texture size, uv scale, camera angle, painted scale?
Does it appear with Manual or auto shading?
Does it change by camera angle?
Does it appear on any of the material/debug views?
Do they appear in the demo with the demo textures?
Are you using the default shader?
What does the inspector report your textures as when you double click them?
What is the date of your video card driver?

I might have fixed my issue by re-exporting my textures sizes as 1024 * 1024, my previous texture was 1920 * 1080 because i read that a power of two texture was recommended but not required.
Nevertheless, here is what happened with the 1920*1080 texture for the record, thanks again :
-Adding a first texture with mipmaps imported will display the grid. This grid will also affect further textures added to the list.
-If the textures have no imported mipmaps, the grid will not appear on the last texture in the list but will affect all the previous ones. For example:

If there are 4 textures in the list, only the first 3 will be affected.

If there is only a single texture in the list, it will not be affected, as it is considered the last texture i guess.

The grid wont disappear if you remove the current last texture but will disappear if you re-add it.

see below :

The lines do appear if the textures remain in the asset dock

The lines width changes with both UV Scale and Painted Scale.

The lines appear in both Manual and Autoshading.

In the editor, moving the camera either far away or extremely close to the textures causes the lines to disappear. However, during runtime, moving the camera far away does not make the lines disappear, but getting extremely close to them does.

-It does not appear in the material view and debug views except for Autoshader, Navigation, Texture Height/Normal/Rough and the grids.
-They do not appear with the demo textures
-I was using the default shader
-The editor reports them as CompressedTexture2D and my latest video card driver my 4 days old

I might have fixed my issue by re-exporting my textures sizes as 1024 * 1024, my previous texture was 1920 * 1080 because i read that a power of two texture was recommended but not required.

Power of 2 means 256x256, 512x512, 1024x1024. Not non-square textures. You could use 1000x1000 and be fine. Non-square use is rare, usually for special cases like 2:1 on a tree trunk. Never 16:9 or odd aspect ratios.  As a beginner, you should only use square, seamless, power of 2 textures.

In the editor, moving the camera either far away or extremely close to the textures causes the lines to disappear. However, during runtime, moving the camera far away does not make the lines disappear, but getting extremely close to them does.

You messed up your mipmaps by using non-square textures. Godot padded the mipmaps with black when it generated them. Nothing to do with Terrain3D. This is how 3D engines, and specifically Godot works.


Link to rulings more specifically as sugested by scryfall folks.

Fixes #4359.

This was done by @jgabrielygalan i think.


Add CSCA file for country certificates

Current Behaviour
At present, there is no CSCA file as a trust anchor of the document signer certificate. This results to CSCA marked with x as shown here
Expected Behaviour
There should be a CSCA file trust anchor to verify contents against tampering. Furthermore, a plan should be in place to update this file in a controlled manner.
Steps to Reproduce the Problem

Use smartscanner-core to scan your passport.
Notice that the CSCA is marked "x" as shown here. This means that the passport's certificate and the integrity of all its contents could not be verified.

Context

Version:

Application screenshot here when a csca.ks file is added taken from GermanMasterlist.zip

Bundle csca.ks here https://github.com/idpass/smartscanner-core/commit/4265f6da0e9bf8fa50350ae331b33efdf7991179

To close when PR#55 is merged


Implement AsFd, From traits and perform maintenance chore

Thanks again! I'll release this soon.

Released as v0.5.6 :tada:


Failing to compile on Raspberry Pi

Unable to compile on Raspberry Pi with Raspbian Stretch 9.1, NPM 5.5.1, Node 8.9.1.
Libsodium is installed.
$ sudo npm i sodium

Error: make nodesodium exited with code null
    at ChildProcess.<anonymous> (/home/Captain/node_modules/sodium/install.js:288:19)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of erlpack@hammerandchisel/erlpack but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node install.js --install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2017-11-21T05_28_08_665Z-debug.log

the package will compile its own libsodium, but currently node 8 is not supported. I'm upgrading to libsodium 1.0.15 and adding Node 8 and Node 9 support. please hang tight

New version released can you please test it out

~$ sudo npm i sodium

/home/Captain/node_modules/sodium/install.js:288
            throw new Error(cmdLine + ' exited with code ' + code);
            ^

Error: make nodesodium exited with code null
    at ChildProcess.<anonymous> (/home/Captain/node_modules/sodium/install.js:288:19)
    at emitTwo (events.js:126:13)
    at ChildProcess.emit (events.js:214:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You mu                                   st install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of erlpack@hammerandchisel/erlpack but none is ins                                   talled. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You mu                                   st install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed                                   . You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must ins                                   tall peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node install.js --install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output a                                   bove.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2017-11-23T04_48_21_514Z-debug.log

It is still failing to compile, but it wants to still compile sodium 2.0.1.
It does however successfully compile on my Windows Machine with Node 8.7.0 and Npm 5.4.2
Pi NPM v5.5.1
Pi Node.js v8.9.1

Any news about this issue ? I'm also with this problem, trying to install a homebdridge-plugin that needs sodium. It's on Raspberry PI The version it's trying to compile is 2.0.3. The error is exactly the same as above, but before that, it gives this error:
install: info lifecycle<EMAIL_ADDRESS>Failed to exec install script

Any news about this issue ? I'm also with this problem, trying to install a homebdridge-plugin that needs sodium. It's on Raspberry PI The version it's trying to compile is 2.0.3. The error is exactly the same as above, but before that, it gives this error:
install: info lifecycle<EMAIL_ADDRESS>Failed to exec install script
Obs.: node 10.15.1, npm 6.4.1

I've since abandoned this project and moved it to another machine for development. Above mentioned fix by @paixaop never worked.


Speaker Prep Section

here's your time limit
relax, everyone is here to enjoy themselves, this should be low stress
take your questions at the end
repeat the questions
make font big

https://www.toastmasters.org/About/90th-Anniversary/90-Tips
http://blog.ted.com/a-ted-speaker-coach-shares-11-tips-for-right-before-you-go-on-stage/
http://www.hanselman.com/blog/11TopTipsForASuccessfulTechnicalPresentation.aspx

Also,
http://damian.conway.org/IBP.pdf
https://www.youtube.com/watch?v=W_i_DrWic88
https://www.youtube.com/watch?v=20GYQcBhXDo
https://www.youtube.com/watch?v=-o-Wjy_ISvs


Handle image paths without extension when uploading

Some files does not have an extension (latest version of expressjs/multer for instance) which crates a problem for s3-uploader. We should add the ability to pass inn one of the following:
a) the original file name
b) file extension
b) image mime type
client.upload('/some/file', { mime: "image/jpeg" }, function(err, versions, meta) {
  ...
});

Wouldn't it be better to always detect file format instead since mime type/extensions can be wrong? Seems like identify could help with this.

Good suggestion @oblador, that would definitely be the best option. Would require some more change too I think.

Just tested this and this does not seem to be problem at first sight.
My test was a jpg, without an extension, used as input for s3-uploader.

What did the final URL result in for the original and for a resized image look like?
I thought this line assumed that the original image file name has a file extension.

Well, some of the results have an extension, some do not. So it's a good idea to improve the handling :)

I just looked into the problem again and remembered that this is not as straight forward as it looked like at first glance since each resized image version may have it's own format (versions[#].format).
We are passing the entire image metadata into resize() which contains the source image format (results.metadata.format). I have created Turistforeningen/node-im-resize#8 which makes use of this to make sure that all resized image versions gets a propper file extension.
We have to do something similar here to make sure that the original image gets a correct file extension as well.

Anyone have a working solution?


When not using Weave, defining a Weave password in cluster or template manifest should error out

Internal reference: SURE-6179
Reported in 2.6.10
Issue description:
When applying a cluster template containing a weave parameter (password in this case) and using the Canal CNI, the UI just halts with no information.  When we look at dev tools we see the following error:
caught Error: Property set failed: object in path "primaryResource.rancherKubernetesEngineConfig.network.weaveNetworkProvider" could not be found.
    at ke (index.js:1579:1)
    at Ce (index.js:1529:1)
    at De.set (index.js:2432:1)
    at e.n [as default] (index.js:1021:1)
    at Ce (index.js:1535:1)
    at index.js:2876:1
    at z (index.js:647:1)
    at e.setProperties (index.js:2870:1)
    at e.willSave (component.js:116:1)
    at e.n [as willSave] (index.js:442:1)

Business impact:
Users were left confused and dissatisfied going down a rabbit hole of more and more modifications and problematic alternatives trying to work around the issue without realizing there was a bad parameter in the template
Troubleshooting steps:
We saw the error mentioned weave and reviewed the template.  When we saw a weave parameter we removed it and were able to save the template
Repro steps:
save a template with weave password configured but Canal set as CNI
Actual behavior:
Nothing happens
Expected behavior:
UI should show a failure and meaningful error

CNI plugin will be deprecated as part of Kubernetes 1.27 so we won't do this. Another ticket filed to put a warning in place to indicate that this will go away.

#9556 will address the deprecation.


HSEARCH-5177 Test against latest Elasticsearch 7.17.22

https://hibernate.atlassian.net/browse/HSEARCH-5177

https://ci.hibernate.org/blue/organizations/jenkins/hibernate-search/detail/PR-4203/2/pipeline


Question - Latest Version of results

How do I get the latest version of results?
Document mentions a dashboard version https://crfm-helm.readthedocs.io/en/latest/get_helm_rank/
Is that the latest?

Found info here  https://crfm-helm.readthedocs.io/en/latest/downloading_raw_results/

You can find the latest results here: https://crfm.stanford.edu/helm/
In particular, refer to:

HELM Lite: https://crfm.stanford.edu/helm/lite/
MMLU: https://crfm.stanford.edu/helm/mmlu/


How to create room for a specific user without using FirebaseChatCore.instance.users() and StreamBuilder()

Hello 👋, I want a user to be able to send a message to another user through my using your library... I have the user UID from firebase which i use to create a user but i can't fetch that specific user so i can create a room for them chat.
void _handlePressed(UserProfile userProfile, BuildContext context) async {
    final navigator = Navigator.of(context);

    await FirebaseChatCore.instance.createUserInFirestore(
        types.User(
            firstName: userProfile.name,
            id: userProfile.userId, // UID from Firebase Authentication
            imageUrl: userProfile.profilePicture,
            lastName: '',
        ),
    );

    // I tried this, raises an error.
    types.User otherUser = (
    FirebaseChatCore.instance.users().where(
        (event) => event.where(
            (element) => element.id == userProfile.userId).isNotEmpty));

    final room = await FirebaseChatCore.instance.createRoom(otherUser);

    navigator.pop();
    await navigator.push(
        CupertinoPageRoute(
            builder: (context) => ChatPage(
                room: room,
            ),
        ),
    );
}

Hey!  So you can use the same  in createRoom?

Hey, thanks for reply to my question.
How do i use the same user in createRoom. I am failing to get the created user so I can pass it to createRoom as my MRE above showed.

My use case is... I am using this library in my app to add a chat feature, My app provides a user with user profiles from which the user can take a look and optionally start a chat with a desired one. So the user taps a button and if the chat user doesn't already exist one is created and if the room doesn't already exist one is created for a chat between the currently authenticated user and the other user selected.
I managed to figure out how a chat user is created but have failed to get that created chat user into the createRoom method.

for create a room:
final room = await FirebaseChatCore.instance.createRoom(
      otherUser: otherUser,
      metadata: {'endProcess': false}, //optional
    );

await navigator.push(
      MaterialPageRoute(
        builder: (context) => ChatPage(
          room: room,
        ),
      ),
    );

My app provides a user with user profiles from which the user can take a look and optionally start a chat with a desired one

So you already have a list of users then? Just take one from the list and use it to call createRoom as presented above.

How do i use the same user in createRoom.

You have this
await FirebaseChatCore.instance.createUserInFirestore(
  types.User(
    firstName: userProfile.name,
    id: userProfile.userId, // UID from Firebase Authentication
    imageUrl: userProfile.profilePicture,
    lastName: '',
  ),
);

Why not just create a user separately
final otherUser = types.User(
  firstName: userProfile.name,
  id: userProfile.userId, // UID from Firebase Authentication
  imageUrl: userProfile.profilePicture,
  lastName: '',
),
await FirebaseChatCore.instance.createUserInFirestore(otherUser)
final room = await FirebaseChatCore.instance.createRoom(otherUser);

Brilliant... thanks for this, Sir. solves it perfectly


Add Mountain View, CA, USA to city_extracts.tsv

Added it myself in https://github.com/osm2vectortiles/osm2vectortiles/commit/14afd398781aea3e92280a968aeaf2238c8cbcbb since and fixed the spaces/tabs thing. Hope that is ok.


[Usage] Poor/Random ouput after training and finetuning

Issue:
My custom trained and fintuned LLaVA is producing very random and poor ouput.
I tried to first train the LLaVA model on custom data using pretrain.sh script and then finetuned it using this script finetune_lora.sh. Then I used the trained lora weights using the command below:
python -m llava.serve.model_worker --host <IP_ADDRESS> --controller http://localhost:10000 --port 40000 --worker http://localhost:40000 --model-path liuhaotian/llava-v1-0719-336px-lora-vicuna-13b-v1.3 --model-base lmsys/vicuna-13b-v1.3
Also sometime the model is not producing any output even.
I had 6000 entries in my custom dataset.
Command:
python -m llava.serve.model_worker --host <IP_ADDRESS> --controller http://localhost:10000 --port 40000 --worker http://localhost:40000 --model-path liuhaotian/llava-v1-0719-336px-lora-vicuna-13b-v1.3 --model-base lmsys/vicuna-13b-v1.3

Screenshots:

@haotian-liu can you look into this once ?

Sorry for mentioning your usernames like this but could you let me know what could have gone wrong ? I still can't figure out this ?
@henrycjh @FHL1998

Sorry for mentioning your usernames like this but could you let me know what could have gone wrong ? I still can't figure out this ? @henrycjh @FHL1998

I highly doubt that 6000 samples are enough for the pertaining process, you may try to fine-tune your own dataset based on the released pre-trained checkpoints.

Oh cool, so I should just finetune on my custom dataset right ? that's what you mean ? @FHL1998

Sorry for mentioning your usernames like this but could you let me know what could have gone wrong ? I still can't figure out this ? @henrycjh @FHL1998

I highly doubt that 6000 samples are enough for the pertaining process, you may try to fine-tune your own dataset based on the released pre-trained checkpoints.

@FHL1998 Hi,I have 6k samples for finetuning.I also get poor results.Do you have any idea?

Hi guys, I am on colab running it on A100 and trying to fine-tuned using the below code, facing error like ./checkpoint or train_men.py and other train.py files
My code
!git clone https://github.com/haotian-liu/LLaVA.git
%cd /content/LLaVA
!pip install -q gradio .

!bash /content/LLaVA/scripts/v1_5/finetune.sh```

Can you guys help me with the correct way to fine-tune it?

Hi guys, I am on colab running it on A100 and trying to fine-tuned using the below code, facing error like ./checkpoint or train_men.py and other train.py files
My code
!git clone https://github.com/haotian-liu/LLaVA.git
%cd /content/LLaVA
!pip install -q gradio .

!bash /content/LLaVA/scripts/v1_5/finetune.sh```

Can you guys help me with the correct way to fine-tune it?

Have you downloaded the model and changed the file location in script?

No I haven't and didn't made any changes to the file location in the script.
Thank you so much; I will try to make it work and run as suggested.

For people with poor results on finetuning make sure to not merge twice the LoRA weights!
If the weights are merged, model-path should include the path to your fine-tuned model.
If the weights are not merged, you should specify a model-base to merge then.


Support ES Module output in npm package. #862

Adds ES Module (ESM) output in the Rollup config (in addition to the existing UMD output), and adds a helpful npm run build script. Fixes #862
Per the CONTRIBUTING.md file, I am not including the ESM build here, but I can easily add that if you would like.
Example Angular component using the ESM build (add to package.json as a file-path dependency) which does not have the warning about optimization bailouts:
import { Component, OnInit } from '@angular/core';
import MarkdownIt from 'markdown-it';

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.scss']
})
export class AppComponent implements OnInit {
  title = 'markdown-it-ng-demo';
  text: string = "";

  ngOnInit(): void {
    const md = new MarkdownIt();
    console.log(md);
    this.text = md.render("# Hi!");
    console.log(this.text);
  }
}

Template HTML:
<div [innerHTML]="text"></div>

Hello @paulirwin,
I suggest using microbundle for that. It provides different bundle formats with a minimum effort.

@thiagodp I appreciate the input, but this project already uses Rollup, so changing that is outside the scope of this PR.

@paulirwin Ok. JFI, Microbundle is based on Rollup, and you could continue using the existing plug-ins.

@paulirwin any update on this? Would be a great addition to the library

@tdekoning I also would like to see this PR merged 😉

I'd also really like to see this merged please 🙏

Any update on this? It would help resolve some issues I am having.

Tagging the two people listed in the markdown-it org: @puzrin @rlidwka
It appears the community is longing to get this fix merged into the project. I'd be happy to address any feedback with it if there's anything preventing this from getting merged. Let me know how I can be of any assistance. Thanks!

As a workaround, I'm using this: https://github.com/esm-bundle/markdown-it

I am generally a patient person when it comes to things like this, but this PR has been open for over a year and is fairly simple. It has been over two months since I pinged the owners of this repo, with no response. There have been no merged PRs since August of 2022 as far as I can tell. Seriously asking, is this project dead?

Mark has ESM builds, FYI: https://www.npmjs.com/package/marked
or in browser:
import { marked } from "https://cdn.jsdelivr.net/npm/marked/lib/marked.esm.js"

OMG I simply didn't do too much searching, THANK YOU A LOT!!!
---Original---
From: "Travis @.>
Date: Fri, Jun 30, 2023 02:39 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [markdown-it/markdown-it] Support ES Module output in npmpackage. #862 (PR #863)
Mark has ESM builds, FYI: https://www.npmjs.com/package/marked
or in browser:
import { marked } from "https://cdn.jsdelivr.net/npm/marked/lib/marked.esm.js"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

@treeder Unfortunately this is a transitive dependency for me so that isn't an option for all cases 😦

In 2023, we'll also want an exports field in package.json, something like ...
  "exports": {
    "import": "./index.js",
    "require": "./dist/esm/markdown-it.mjs"
  },

That makes sure resolution that doesn't use the non-standard "module" field (such as node's own) can still find the ESM code.

This would be great to have supported!

@paulirwin @marijnh
With the following change:
  "exports": {
    "require": "./index.js",
    "import": "./dist/esm/markdown-it.mjs"
  },

will be this PR merged eventually?

Re: @marijnh (I am forever indebted to you for your excellent work on ProseMirror, btw. Thank you for that library!)

In 2023, we'll also want an exports field in package.json, something like ...
  "exports": {
    "require": "./index.js",
    "import": "./dist/esm/markdown-it.mjs"
  },

That makes sure resolution that doesn't use the non-standard "module" field (such as node's own) can still find the ESM code.

This is good to know, thanks! I don't spend a lot of time in Node directly and only use this package via Angular. Should "type": "module" be added as well, or would that break "legacy" users? Do we still need to support CommonJS now that it's almost 2024 and Node v20 is LTS?

(Just verified that this PR still applies cleanly, but node will load the CJS code when you import it. With the above change to package.json, it loads the ESM code, and everything seems to work.)
Further edit: Actually, adding this will forbid importing modules directly from the package by path, which is maybe a style you intend to support, given that there are separate minified files. Which modules are users expected to want to load directly?

I don't have any particular intentions if this was addressed to me, other than ensuring that optimization in Angular builds works. I am a little out-of-the-loop of current Node package conventions and standards. I know at one point in the past, it was fairly common to include minified builds with your package like markdown-it has done prior to my PR. Is that no longer the case? If so, that would certainly simplify the Rollup config and build. I'm eager to learn from the community here on any ways I can improve this PR.
Re: @adrian-branescu

@paulirwin @marijnh With the following change:
"exports": {
    ".": {
      "import": "./dist/esm/markdown-it.mjs",
      "require": "./index.js"
    },
    "./*": {
      "require": "./*",
      "import": "./*"
    }
},

What does the second export with the * accomplish, and why is that needed here? Looking to learn as I am unfamiliar with that.

will be this PR eventually merged?

I am encouraged to see recent activity in September of this year on this project. It would be great if this could get merged at some point. Obviously as the PR author I would love to see it merged, but alas I am not a contributor to this repo. It sounds like I do need to brush the dust off of it before it is merged, though, with the addition of exports.

Should "type": "module" be added as well, or would that break "legacy" users?

That should be fine, and help some tools that still use the old convention.

What does the second export with the * accomplish, and why is that needed here? Looking to learn as I am unfamiliar with that.

Once you have an exports field, only the files mentioned in it can be loaded from the package. So, since this package has more than just a top-level entry point, adding these wildcards makes those sub-paths accessible for direct require.
I would hope updating this PR and prodding a bit more will lead to a new release.

@marijnh @adrian-branescu Thank you! I have made those changes to this PR. Quick testing of a new Node package that references it by file path seems to work fine at least for constructing a MarkdownIt. If either of you can help validate that I did this correctly and sufficiently, that would be appreciated.

@paulirwin @marijnh
I would add to the rollup.config.js file the external field, e.g.
external: [
  /node_modules/
]

in order to prevent including in the bundle the external dependencies from package.json:
"dependencies": {
    "argparse": "^2.0.1",
    "entities": "~3.0.1",
    "linkify-it": "^3.0.1",
    "mdurl": "^1.0.1",
    "uc.micro": "^1.0.5"
  },

In this way, one can use this NPM package in Node.js and Web apps with a bundler like webpack, Rollup, vite etc without having those dependencies included multiple times in the final app bundle.

Should "type": "module" be added as well, or would that break "legacy" users?

That should be fine, and help some tools that still use the old convention.

Correction! I thought you were talking about the "module": "dist/esm/markdown-it.mjs" line. "type": "module" should definitely NOT be added here.

@paulirwin @marijnh I would add to the rollup.config.js file the external field, e.g.
external: [
  /node_modules/
]

in order to prevent including in the bundle the external dependencies (along with the whole graph of transitive dependencies) from package.json:
"dependencies": {
    "argparse": "^2.0.1",
    "entities": "~3.0.1",
    "linkify-it": "^3.0.1",
    "mdurl": "^1.0.1",
    "uc.micro": "^1.0.5"
},

In this way, one can use this NPM package in Node.js and Web apps with a bundler like Webpack, Rollup, Vite etc without having those dependencies included multiple times in the final app bundle.

If I'm understanding this correctly, this would be an existing problem with the current rollup CJS output, is that correct? If so it seems like that warrants its own PR and could be merged independently.

Thanks. With that change this patch works for me (I tried: importing as ESM, requiring as CommonJS, requiring a specific dist/ file.)

@paulirwin @marijnh I would add to the rollup.config.js file the external field, e.g.
external: [
  /node_modules/
]

in order to prevent including in the bundle the external dependencies (along with the whole graph of transitive dependencies) from package.json:
"dependencies": {
    "argparse": "^2.0.1",
    "entities": "~3.0.1",
    "linkify-it": "^3.0.1",
    "mdurl": "^1.0.1",
    "uc.micro": "^1.0.5"
},

In this way, one can use this NPM package in Node.js and Web apps with a bundler like Webpack, Rollup, Vite etc without having those dependencies included multiple times in the final app bundle.

If I'm understanding this correctly, this would be an existing problem with the current rollup CJS output, is that correct? If so it seems like that warrants its own PR and could be merged independently.

Yes, this problem replicates on the master branch too.
On your branch, there are >2000 lines of external source code added besides package own source code:

# find lib/ -name '*.js' | xargs wc -l
6185 total

# cat dist/markdown-it.js | wc -l
8356

# cat dist/esm/markdown-it.mjs | wc -l
8675

These may be duplicated in a Web App that makes use of the same dependencies like this package because the app bundler has no idea that they were already included in this package bundle.

@adrian-branescu Thanks for the info, I could see where the addition of this could exacerbate that problem. If there's consensus from others that the external bit should be included here, I can do that.

@puzrin Are you okay with releasing this? Or giving some feedback on what would be needed before it gets released?

We closed most of pending things, and I'm rewriting to es6 to solve the rest.
Need advice, what is preferable:

use .mjs extensions
use .js with type: module

Could you help?

It doesn't matter much, but if you want to keep supporting the old behavior of requiring dist/markdown-it.min.js, you'll need to either use .mjs for your ES module files, or explicitly list all allowed paths in your package.json exports field, because with type: module a .min.js file would be interpreted as a module.

@marijnh thank you very much for info! I tend use .msj, if that will be ok to all next years.

See es6 branch https://github.com/markdown-it/markdown-it/tree/es6

all rewritten all to es6 (dependencies still not, but will be done)
dist/ now has umd build with all deps bundled.

Since change is huge, and I have no solid experience with esm development, I'm open to any suggestions, what should be improved. Hope to spread the same changes to all other maintained repos.

Updated a lot of code to be more close to standard lint rules (var => let/const and so on).
Added babel to es5 build, for sure.

@SReject The problem with classes is, that existing implementation uses hack for the call without new. This is not possible with class. I could export factory function as default and class as MarkdownIt. But not sure how good is that for users. Any suggestions welcome.
Also not sure, if should I use rollup+babel for the es6 modules build, or leave that for upper-level use.

I'm closing this, since master rewritten to ESM, and have fallback to CJS (generated on publish, or via npm run build).
It will take some time (up to 1-2 weeks) to check other issues and transform plugins. But you can write any thoughts if something else should be fixed.

Published v14 with native ESM support.


Am I missing anything?

The following controller has been created by Serenity which works fine and allow navigation to this page

But when I create the following controller

it gives the following error when I run

Am I missing anything?
Thank you

Did you add an index file at the expected location?  Ot looks like there isnt one? If you added it make sure to do a transform after rebuilding.

Thanks @wirble
Even adding Index.cshtml is not working. It gives the same error.

You didnt explicitly specify a location in the return view. So its looking for an index file under dashboard2 and shared.

Thank you @wirble
Yes it looks for the view under the view folder. It is a question for me as well that as you can see in the first example, it does not have a view inside the view folder but works fine while in the second example it is looking for the view.
Maybe there is specific configuration needed for Serenity.

Add this on your RouteConfig.cs
`
routes.MapRoute(
name: "Default",
url: "{controller}/{action}/{id}",
defaults: new { controller = "Home", action = "Index", id = UrlParameter.Optional }
);
`

Thanks @javaman63
I had to working using the default functionality of MVC.
Regards
Hafiz


⚠ Bofrost.at has degraded performance

In 1cc0399, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1699 ms

Resolved: Bofrost.at performance has improved in b1bfc7a after 13 minutes.


Adapter documentation and eMSP

Hello,
I managed to get this up and running and I was wondering if you have a more detailed documentation of the adapters and the data format for them? As far as I see, the adapter receives data input in a simple format and outputs as per OCPI schemas?
Also do you plan on updating with the eMSP role?
Keep up the good work!

Hi @evcharger, yes the adapter will adapt data to OCPI compatible schemas.
we'll improve the library and the documentation soon.
Thank you for your kind support


Move temperature conversion functions to sperate file

Currently all of the functions for the program are held within one file. Thus in order to make it easier to navigate, the functions for converting between different temperatures should be moved to a seperate source file.

Take a look at this example for how to import other .c files in the same directory:

https://github.com/libcheck/check/blob/master/src/check_msg.c#L28-L34


Abnormal execution time / Mismatch of FLOPs obtained from Nsys / Ncu

Hello!
I have two flash_fwd_kernels. One is:
void flash_fwd_kernel<Flash_fwd_kernel_traits<(int)32, (int)128, (int)128, (int)4, (bool)0, (bool)0, cutlass::half_t, Flash_kernel_traits<(int)32, (int)128, (int)128, (int)4, cutlass::half_t>>, (bool)0, (bool)0, (bool)0, (bool)0, (bool)1, (bool)0>(Flash_fwd_params)
Begins: 2.43134s
Ends: 2.43151s (+168.288 μs)
grid:  <<<13, 1, 8>>>
block: <<<128, 1, 1>>>
Launch Type: Regular
Static Shared Memory: 0 bytes
Dynamic Shared Memory: 24,576 bytes
Registers Per Thread: 255
Local Memory Per Thread: 0 bytes
Local Memory Total: 25,690,112 bytes
Shared Memory executed: 102,400 bytes
Shared Memory Bank Size: 4 B
Theoretical occupancy: 16.6667 %
Launched from thread: 37894
Latency: ←16.329 ms
Correlation ID: 17118
Stream: Stream 55
which indicates that Q K and V are  1x1664x8x32.
The estimated number of TFLOPs should be 1 * 1664^2 * 8 * 32 * 4 / 1e12 = 0.0028 TFLOPs.
I am running this kernel on Orin, which takes 168us, and the average Tensor Active % obtained from Nsys and Ncu is 42.5%.
On Orin, TensorCore peak TFLOPS is 42.5 for FP16.
So I have TFLOPs = 42.5 * 168 / 1e6 * 42.5% = 0.003
These two numbers are pretty close with each other.
However, I have another kernel, which is :
void flash_fwd_kernel<Flash_fwd_kernel_traits<(int)64, (int)128, (int)128, (int)4, (bool)0, (bool)0, cutlass::half_t, Flash_kernel_traits<(int)64, (int)128, (int)128, (int)4, cutlass::half_t>>, (bool)0, (bool)0, (bool)0, (bool)1, (bool)1, (bool)0>(Flash_fwd_params)
Begins: 4.61077s
Ends: 4.62018s (+9.404 ms)
grid:  <<<32, 1, 16>>>
block: <<<128, 1, 1>>>
Launch Type: Regular
Static Shared Memory: 0 bytes
Dynamic Shared Memory: 49,152 bytes
Registers Per Thread: 255
Local Memory Per Thread: 0 bytes
Local Memory Total: 27,787,264 bytes
Shared Memory executed: 102,400 bytes
Shared Memory Bank Size: 4 B
Theoretical occupancy: 16.6667 %
Launched from thread: 3600631
Latency: ←102.053 ms
Correlation ID: 10664
Stream: Stream 61
which indicates that Q K and V are 1x4096x16x64
The estimated number of TFLOPs should be 1 * 4096^2 * 16 * 64 * 4 / 1e12 = 0.069 TFLOPs.
I am still running this kernel on Orin, which now takes 9.2ms, and the average Tensor Active % obtained from Nsys and Ncu is 64.3%.
On Orin, TensorCore peak TFLOPS is 42.5 for FP16.
So I have TFLOPs = 42.5 * 9.4 / 1e3 * 64.3% = 0.26
These two numbers do not match. 0.26 / 0.069 = 3.77.
I have also tried this same kernel on 4080. The result is similar, that Nsys / Ncu consumes 3x-4x of estimated FLOPs compared with the FLOPs calculation based on input dimensions, or in the other way, the execution time obtained from Nsys / Ncu is 3x-4x slower than expected.
Could you help me figure out the possible reason for this kernel to show this type of behavior? Thank you so much!

I tried creating a minimum example of simply running this one kernel instead of profiling the kernel in a large model.
Surprisingly in the minimum example, profiling FLOPs match the calculation.
Here is the ncu results of the kernel obtained from the minimum example (RTX4080):
it only takes 0.88ms for the kernel.

Here is the ncu result of the kernel obtained from a large model (TensorRT engine, RTX4080):
it takes 3.6ms to execute...

It seems that the exactly same kernel generates completely different outcomes... I still don't quite understand what happened. It seems that all the kernel configurations are the same for these two runs...

Nvm. Just found that the original layer Q and KV have different sequel.
Q seqlen = 4096. K/V seqlen = 15360.
The K/V seqlen do not show in kernel parameters, as the kernel does not tile on this dimension. Each thread block processes the entire K/V seqlen in each iteration.

15360 / 4096 = 3.75, which explains the difference.


Unable to enable addon for azure-keyvault-secrets-provider

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az aks enable-addons
Errors:
'azure-keyvault-secrets-provider'
Traceback (most recent call last):
Temp\pip-install-0u_uiwkq\knack\knack\cli.py, ln 206, in invoke
azure\cli\core\commands\__init__.py, ln 608, in execute
azure\cli\core\commands\__init__.py, ln 666, in _run_jobs_serially
azure\cli\core\commands\__init__.py, ln 659, in _run_job
Local\Temp\pip-install-0u_uiwkq\six\six.py, ln 696, in reraise
azure\cli\core\commands\__init__.py, ln 636, in _run_job
azure\cli\core\commands\__init__.py, ln 306, in __call__
azure-cli-core\azure\cli\core\__init__.py, ln 493, in default_command_handler
azure\cli\command_modules\acs\custom.py, ln 1841, in aks_enable_addons
azure\cli\command_modules\acs\custom.py, ln 2188, in _update_addons
KeyError: 'azure-keyvault-secrets-provider'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

az aks enable-addons --addons {} --name {} --resource-group {}

Expected Behavior
Environment Summary
Windows-10-10.0.18362-SP0
Python 3.6.6
Shell: powershell.exe

azure-cli 2.0.80

Additional Context

@JudasGeiten - you are running a version of Azure CLI that is almost two years old (2.0.80 was released in January 2020). As it's a new feature and per the documentation, Azure Key Vault Provider requires a newer Azure CLI version of at least 2.30.0 to be configured. Please follow the directions in the Azure CLI documentation to update your client and reopen the issue if you still experience problems. Thanks!


Smooth animation via caching?

The animation capability is great.  It would also be even greater if we could cache the frames for smoother animation after the 1st time through.   I realize this might not be a xrviz issue per se, but could you please look into it @hdsingh ?
I know that with Matplotlib animation, you can set cache_frame_data=True, but not sure to accomplish this with panel.

This is a feature that we will need pyviz's cooperation with. @philippjfr , @jbednar , where was this mentioned?

A HoloViews (or hvPlot) DynamicMap has a parameter cache_size defaulting to 500 items, which can be increased to animate larger numbers of frames efficiently (at the cost of taking more memory).  Does that help address the question?

I am finding a solution, to correctly use cache_size with the quadmesh by discussing in pyviz.


[nvgpu] Expose helper code from NVGPU to LLVM lowering (NFC).

OpenXLA would like to reuse code from NVGPUOpPatternBase for Sparsity lowering. Currently this is done by patching NVGPUToLLVMPass.cpp to add an extra pattern deriving from NVGPUOpPatternBase. Instead, we would like to move this pattern to the downstream OpenXLA repository.
This change removes the NVGPUOpPatternBase base class and exposes the core lowering code as a utility function (rewriteAsPtxAsm()) instead. The existing patterns now directly inherit from mlir::OpRewritePattern and use this utility function.
I hope that exposing an extra function is acceptable. I tried to balance it with cleaning up the code a bit (e.g., no more CRTP, but of course that's subjective).

Thanks Thomas for the quick and thorough review.
Indeed, the plans for nvgpu is on my list of (curiosity-) questions for you.
Are you considering switching back to MLIR's nvgpu dialect, or moving the ops over to triton_gpu?

Indeed, the plans for nvgpu is on my list of (curiosity-) questions for you. Are you considering switching back to MLIR's nvgpu dialect, or moving the ops over to triton_gpu?

MLIR nvgpu dialect is a very different level of abstraction than this. (It is meant to allow using memref and Nd vectors along with nv specific ops.) Since most NVGPU ops are a thin layer on top of inline asm they are usually not worth the extra infrastructure and we should directly generate the inline asm in most cases. There are also cases where we could reuse NVVM dialect.


Initial istioctl integration test in new framework

A simple test of istioctl version with --remote=true option.
There were no istioctl-specific integration tests.
Please review my usage of the new test framework because this is my first time using it.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: esnible
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [esnible]
tests/integration/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@esnible: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test istio-integ-k8s-tests

prow/release-test.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test istio-integ-k8s-tests

prow/release-test.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test release-test

prow/istio-integ-local-tests.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test istio-integ-k8s-tests

prow/release-test.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test release-test

prow/istio-integ-local-tests.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test istio-integ-local-tests

prow/e2e-bookInfoTests-v1alpha3.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-test.sh
fcca61ea57de4c185999b4b0354bf376377378ff
link
/test release-test

prow/istio-integ-local-tests.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test istio-integ-local-tests

prow/e2e-bookInfoTests-v1alpha3.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-integ-k8s-tests.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-local-tests.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test istio-integ-local-tests

prow/e2e-bookInfoTests-v1alpha3.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-integ-k8s-tests.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test istio-integ-k8s-tests

prow/release-test.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test release-test

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test e2e-bookInfoTests-envoyv2-v1alpha3

prow/istio-integ-k8s-tests.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test istio-integ-k8s-tests

prow/release-test.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test release-test

prow/integ-pilot-k8s-presubmit-tests.sh
ff79bc2fda4c60830348186b861d7097cd9b9fb6
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
9e2b263d58b2f3a5ae5c5b19d29f2bbf2d8fa836
link
/test istio-integ-k8s-tests

prow/integ-pilot-k8s-presubmit-tests.sh
ff79bc2fda4c60830348186b861d7097cd9b9fb6
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
ff79bc2fda4c60830348186b861d7097cd9b9fb6
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
ff79bc2fda4c60830348186b861d7097cd9b9fb6
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
ff79bc2fda4c60830348186b861d7097cd9b9fb6
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-integ-k8s-tests.sh
ff79bc2fda4c60830348186b861d7097cd9b9fb6
link
/test istio-integ-k8s-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ozevren I have made the changes.  Hoping for a review.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: esnible
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren
If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [esnible]
pkg/OWNERS
tests/integration/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
ff79bc2fda4c60830348186b861d7097cd9b9fb6
link
/test integ-security-k8s-presubmit-tests-master

prow/istio-integ-k8s-tests.sh
ff79bc2fda4c60830348186b861d7097cd9b9fb6
link
/test istio-integ-k8s-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
861dbaa0aa21cb7e5c8179450e160f6d5d00731c
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ff79bc2fda4c60830348186b861d7097cd9b9fb6
link
/test istio-integ-k8s-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
861dbaa0aa21cb7e5c8179450e160f6d5d00731c
link
/test integ-mixer-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
160fa833825d2ab3cbad31bdaada78fb1064fe2c
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
ff79bc2fda4c60830348186b861d7097cd9b9fb6
link
/test istio-integ-k8s-tests-master

prow/e2e-mixer-no_auth.sh
160fa833825d2ab3cbad31bdaada78fb1064fe2c
link
/test e2e-mixer-no_auth-master

prow/integ-mixer-k8s-presubmit-tests.sh
160fa833825d2ab3cbad31bdaada78fb1064fe2c
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: esnible, ozevren
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

istioctl/OWNERS [esnible,ozevren]
pkg/OWNERS [ozevren]
tests/integration/OWNERS [ozevren]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Can not override FallbackLocale

This is related to #6805 and should be solved if the solution proposed there is executed. But this is a major problem for multilingual sites that do not require english, so I am opening a new issue.
Affected Version
4.2.1
Description
When trying to override the fallback locale, one should be able to create a configuration setting like this (for instance to set Spanish as fallback):
SilverStripe\Core\Injector\Injector:
  Symfony\Component\Translation\TranslatorInterface:
    calls:
      FallbackLocales: [ setFallbackLocales, [['es']]]

But, since the setting is an array, instead of overriding, it add the parameters to the original setting, which ends up being:
array:4 [
  0 => "setFallbackLocales"
  1 => array:1 [
    0 => array:1 [
      0 => "en"
    ]
  ]
  2 => "setFallbackLocales"
  3 => array:1 [
    0 => array:1 [
      0 => "es"
    ]
  ]
]

Which will then throw an InvalidArgumentException exception.
Steps to Reproduce
On a SilverStripe project, add this to your config.yml file:
SilverStripe\Core\Injector\Injector:
  Symfony\Component\Translation\TranslatorInterface:
    calls:
      FallbackLocales: [ setFallbackLocales, [['es']]]

in the meantime, is there any way to override the value of the fallback language?

Yeah that was the gist of it, I guess in this case it would be something like
---
Name: translatorreset
---
SilverStripe\Core\Injector\Injector:
  Symfony\Component\Translation\TranslatorInterface:
    calls: null
---
Name: translator
---
SilverStripe\Core\Injector\Injector:
  Symfony\Component\Translation\TranslatorInterface:
    calls:
      FallbackLocales: [ setFallbackLocales, [['es']]]

Great, thanks
Final solution was:
---
Name: translatorreset
---
SilverStripe\Core\Injector\Injector:
  Symfony\Component\Translation\TranslatorInterface:
    calls:
      FallbackLocales: null
---
Name: translator
---
SilverStripe\Core\Injector\Injector:
  Symfony\Component\Translation\TranslatorInterface:
    calls:
      FallbackLocales: [ setFallbackLocales, [['es']]]

I've created a PR with an example for these situations: #8471


Check for zenoh router in a thread

A lot has changed since this PR was opened. Will open a new PR that reimplements this.


SignmodeDirect, refact. EstimatedFeeWithoutBurnTax changed to async

now SignmodeDirect,
refact. EstimatedFeeWithoutBurnTax changed to async

CreateSignatureAmino has to be a LegacyAminoJson.
If Direct Signing is required then please call the CreateSignature()

but we are in the CreateSignature method:
public async Task<KeyValuePair<string, SignatureV2>> CreateSignature(SignDoc tx)

we are calling by default CreateSignature....it has changed somewhere !?

Sorry I forgot to rollback those signature changes. I was trying to test the signature to fix the verification problem.
Please pull the latest main, and try again


Non-cyclic GIF

I just noticed that the GIF on the following page does not cycle back to the beginning when it ends:
http://ember-cli.com/ember-cli-deploy/docs/v0.5.x/deployment-context/
Yesterday I was reading that page and I couldn't quite understand the image. Well, I understood it because I am familiar with ember-cli-deploy, but I thought it did a poor job at explaining anything to someone who didn't. Today I was skimming pages and realised it was an animated GIF, and much better an illustration that I originally had thought.
Therefore: I'd suggest that the image is made to run in a loop, for those of us who are slow readers in a small screen and won't notice it moving by the time we scroll past the fold.

Good idea. Thanks for the feedback @pablobm


#2523 - PD/PPD Assessment and Disbursement Logic

[x] Save PD/PPD Application Question response in the workflow data (to be referenced later at the eCert check)
[x] Save calculatedDataPDPPDStatus to the workflow data
[x] Check for Disability Profile Status at eCert Generation using calculatedDataPDPPDStatus:

Student assessment contains PD/PPD application flag=yes then

Student profile PD/PPD approved, generated e-Cert.
Student profile PD/PPD missing approval, withhold disbursement.

[x] Add unit or e2e test (depending on which is relevant).

Changed the factories to include workflow data , for the existing test cases to pass.

Great Job!. Please have a look at the comments.


Automated Package Upgrade

:tada: This PR is included in version 7.7.72 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


put() doesn't check when the file has finished uploading

I uploaded a 17 MB file to my server using put() and the function called the callback function many seconds before the file finished uploading.
The example provided in the documentation goes as follows:
ftp.put(buffer, 'path/to/remote/file.txt', function(hadError) {   if (!hadError)     console.log("File transferred successfully!"); });
I'm guessing the callback function is called as soon as the upload starts, differently than what the example suggests. I couldn't find a way to check if the file has finished uploading in the documentation.

Can you please run your program in debug mode? i.e. DEBUG=jsftp:* node yourprogram.js. and post the output?
Thanks!

@sergi Hello, I just did what you asked, here's the log: https://pastebin.com/QpRRcV4f
As you can see, the message "File uploaded to the FTP server." comes before the server returns "226-File successfully transferred".
That's what the code looks like: https://pastebin.com/riHs4NZA
Thank you for your time.

Somehow it works now even though I didn't even update the dependencies, but you can see in the log that it wasn't working back when I posted it.
I guess you can close the issue for now, if you can't reproduce the issue.


GenericArguments: Long Command Flags not tab completing.

SpongeAPI/src/main/java/org/spongepowered/api/command/args/CommandFlags.java
On line 271, I can see my long command being added to the retStrings collection.
However, that is never returned.  Instead, after the if check passes to line 280, it moves down to a "return null" statement.
My proposal is to add a "return retStrings;" after line 279.

https://github.com/SpongePowered/SpongeAPI/commit/320df402f83d6a75da2715e8a2a9cb1598413543


Update freetype from version 2.4.10 to 2.5.5

Long overdue update.

If there are no objections, I'll go ahead and merge this.

do it
On Feb 13, 2015 12:30 PM, "Justin Shapcott"<EMAIL_ADDRESS>wrote:

If there are no objections, I'll go ahead and merge this.
—
Reply to this email directly or view it on GitHub
https://github.com/libgdx/libgdx/pull/2838#issuecomment-74240587.


feat: NodeTypesWithDB

This PR extracts DB AT from FullNodeTypes into separate trait NodeTypesWithDB. This trait is moved to new crate reth-node-types along with NodePrimitives, NodeTypes and NodeTypesWithEngine This is needed to allow reth-provider depend on NodeTypesWithDB
FullProvider is now generic over NodeTypesWithDB and FullNodeTypes is changed to the following form:
https://github.com/paradigmxyz/reth/blob/416fc6bdadbb3953ef943d3ed99444e25ee08ef2/crates/node/api/src/node.rs#L95-L100
As it no more depends on NodeTypes I had to change the way we access some of the ATs (Node::Engine -> <Node::Types as NodeTypesWithEngine>::Engine)
This should allow usage of NodeTypesWithDB in provider traits

why not use syntax?
trait FullNodeTypes: NodeTypes<Engine: EngineTypes, DB: FullDatabase> { .. }

this would leave us with something like
trait FullNodeTypes: NodeTypes<Engine: EngineTypes, DB: FullDatabase> {
    type Provider = FullProvider<Self>;
}

and such structure would make it harder to deal with generics on providers, eg expressing this bound becomes not trivial if BlockchainProvider has NodeTypes generic:
https://github.com/paradigmxyz/reth/blob/25997b4e7fb1db46867f494dc9515294013f9a93/crates/node/builder/src/launch/mod.rs#L106

why not use syntax?
trait FullNodeTypes: NodeTypes<Engine: EngineTypes, DB: FullDatabase> { .. }

this would leave us with something like
trait FullNodeTypes: NodeTypes<Engine: EngineTypes, DB: FullDatabase> {
    type Provider = FullProvider<Self>;
}

and such structure would make it harder to deal with generics on providers, eg expressing this bound becomes not trivial if BlockchainProvider has NodeTypes generic:
https://github.com/paradigmxyz/reth/blob/25997b4e7fb1db46867f494dc9515294013f9a93/crates/node/builder/src/launch/mod.rs#L106

ok I see, then why have these traits got associated types? and not just super traits? instead of NodeTypesWithDB just
trait FullDB: DatabaseMetrics + Database + NodeTypes {}

ok I see, then why have these traits got associated types? and not just super traits? instead of NodeTypesWithDB just
trait FullDB: DatabaseMetrics + Database + NodeTypes {}

hmm, what's the benefit of such trait? doesn't feel right that we'd impl NodeTypes on DB instead of layering it on top of other types as another AT

ok I see, then why have these traits got associated types? and not just super traits? instead of NodeTypesWithDB just
trait FullDB: DatabaseMetrics + Database + NodeTypes {}

hmm, what's the benefit of such trait? doesn't feel right that we'd impl NodeTypes on DB instead of layering it on top of other types as another AT

doesn't feel right to have a trait with one associated type. what are the reasons for this?
it's a shame that we loose the nice aggregation of stateless components that we used to have in NodeTypes. think we may be getting an abstraction layer too much if we unite them again in a new aggregation trait. would have been simpler with removing the primitives associated type.
trait NodeTypes: PrimitiveTypes {
    type Engine: EngineTypes;
    type ChainSpec: ChainsSpec;
}

nonetheless, we can see where this ends up, and if we need to deal with debt later. it is beneficial that we are agiley moving forward.

doesn't feel right to have a trait with one associated type. what are the reasons for this?

we've added NodeTypesWithEngine to close https://github.com/paradigmxyz/reth/issues/9555, and the motivation for NodeTypesWithDB is that NodeTypes are coming from the user and need to be configured separately (this is primary motivation for the FullNodeTypesAdapter): https://github.com/paradigmxyz/reth/blob/2c28438505c0809f31ebe626a9f05589e0d19910/crates/node/builder/src/builder/mod.rs#L209-L212

it's a shame that we loose the nice aggregation of stateless components that we used to have in NodeTypes. think we may be getting an abstraction layer too much if we unite them again in a new aggregation trait. would have been simpler with removing the primitives associated type.

agreed that we might end up with too many layers. helper traits aggregating types should help, we could also consider restructuring NodeBuilder a bit to not depend on its interface, especially given it already uses adapters

we could also consider restructuring NodeBuilder a bit to not depend on its interface, especially given it already uses adapters

fully supportive of this


support RGBA in HatchBrush

if use a brush HatchBrush with a transparent background that background was not transparent

After

Hello! I'm the build bot for the Mono project.
I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.
Contributors can ignore this message.

Hello! I'm the build bot for the Mono project.
I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done.
Contributors can ignore this message.

Hi @tReMaker, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@tReMaker, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;


Develop

Resolves #114

@froster82 can you check the last strings:
https://github.com/pachi81/GlucoDataHandler/pull/118/files#diff-0908d478f1e1608a4d8bf0d6e84f3c23dd963a61f2ff17a7984af7e3e9f938d1
Thank you!

@froster82 I'm not sure about the correct name, either LibreLink or LibreLinkUp.
But maybe only the app for LibreLink is called LibreLinkUp... I really don't know 😒
But I know that the libreview account is NOT the same as the librelinkup account. You can use the same data for both accounts.
You can also change it tomorrow and I need an additional translation for a new menu entry called "Contact".
Thank you very much!

@pachi81, while writing my manual for Polish users, I noticed that this part might me ambiguous.
We have the following state of affairs:
Librelink app is only used for uploading the data to a LibreView account. And this app has login and password of the main user of the sensor.
LibreLinkUp is the app used by a parent/wife. They need LibreLinkUp app, and their own LibreView account. These are also the data that need to be entered in GDH. I checked - when I entered my own LibreView login ad password (used by me to send glucodata to LV), GDH displays an error in LibreLink field. When I enter my wife's login and password to LibreView (also used by her in LibreLinkUp), everything is correct.
So in order for everything to be clear I think we need to call these features as follows:

LibreLinkUp follower (because the person using GDH needs to set up a 2nd LibreView account just for the purposes of receiving data via LibreLinkUp)
E-mail for Libreview account (of the follower using LibreLinkUp app)
Password for Libreview account (of the follower using LibreLinkUp app)

What do you think? If you disagree, I will revert my changes right away.
Also, I cannot find the new Contact menu entries.

@froster82 I did some more changes to the strings...
Regarding you questions. Please do not use LibreView and Follower together in description, because the most people think, they can use the LibreView account data, but then they get an error (like you with your own account) and write me to help/support them ;-)
That´s why, only use "LibreLinkUp" oder "LibreLinkUp follower" (like the account of your wife).
I think your wife can not login to LibreView with these data?! (I can not test, as I use the same data for LibreView and LibreLinkUp).
My app only support LibreLinkUp followers, which were activated in the LibreLinkUp App, after they were added in the FreeStyle Libre app....

So in order for everything to be clear I think we need to call these features as follows:

LibreLinkUp follower (because the person using GDH needs to set up a 2nd LibreView account just for the purposes of receiving data via LibreLinkUp)
E-mail for Libreview account (of the follower using LibreLinkUp app)
Password for Libreview account (of the follower using LibreLinkUp app)
What do you think? If you disagree, I will revert my changes right away.

Yes, as I wrote above, I disagree, as you can not use e-mail and password for you libreview account...

LibreLinkUp users must set their own LibreView accounts that is why I thought using the proper LibreView name would be clearer (we can log into LibreView with my wife's details, but the website is blank - waiting for data to be uploaded, so the login data work, but they direct to a "ghost" account).
But you are also right - people do not read and complain a lot :)
Let's just stick to LibreLinkUp to differentiate from the source LibreLink. I will change the Polish strings right away.

Thank you for your great work!
When I have you available, I have one more question regarding NS.
I myself do not use NS, so I cannot check it on my own - how do you activate NS follower? Do you need to fill in ever field in the menu on the phone? Or only some are obligatory?
One girl on the Polish forum - the one with iOS and WearOS watch, tried to activate her NS using an android phone, but failed. She could not activate the switch on the phone version after entering login data. I do not know how tech-savvy she is, and if she can cope with such issues on her own, that's why I ask.

@froster82 : if you like, you can get an internal test (not the open beta testing). So you can check you resources before release.
If you like, please send me an mail with playstore gmail address to my private mail<EMAIL_ADDRESS>So I can add you to the list of testers...

@pachi81, in the test version I was able to find a small mistake in iob/cob line.
Also, you removed the ability to disable the foreground notification - in status bar. In the previous versions it was really useful, because when someone uses a widget, the status bar notification could be easily turned off. Now if somebody does not know how to manage notifications in the app system settings, it is impossible to get rid of this notification. Can you bring back the option to disable foreground notification?

@pachi81, in the test version I was able to find a small mistake in iob/cob line. Also, you removed the ability to disable the foreground notification - in status bar. In the previous versions it was really useful, because when someone uses a widget, the status bar notification could be easily turned off. Now if somebody does not know how to manage notifications in the app system settings, it is impossible to get rid of this notification. Can you bring back the option to disable foreground notification?

Sorry, but if you disable foreground, the app may not work correct (get some feedback of people complaining...).
So I decided to make this app to run always in foreground. People who knows, what they are doing, can deactivate it, but it is their problem ;-)
I have to make this app foolproof, if it is in the playstore...
But you can still remove the content...

Hehe I know what you mean.
On my phone, I use Juggluco and GDH with widget. I only have status bar notification from Juggluco. There was never any problem with GDH.
On my wife's phone, GDH works as LibrelinkUp follower. The first option for notification is switched off and she only has a widget. Also in this case there was no problem, as long as battery optimization was turned off.
For me the main reason for complaining might be the inability to fully customize the view :) You know - why the hell I keep seeing this and cannot turn it off! :)
But you are right - if somebody knows how to disable this notification, everything will be ok.
A little suggestion - maybe add a note explaining how to disable it using system app settings? This way you would reduce the number of people complaining even more :)

If I add a note, how to disable, I could reenable the setting... makes no sense :-)
But if you use juggluco, you can also use my notification for delta or the trend arrow.
I use the 3 notifications, juggluco for the value and my two for arrow and delta...

I'm trying to be a bit of a devil's advocate here, so as to reduce the number of complaining to minimum ;)
If somebody wants to use GDH as a follower, status bar notification will - for sure- be useful. With Juggluco - this solution can also be beneficial - I see that my initial idea with two status bar icons stuck with you :D I in turn prefer your widget idea - less clutter in the status bar for me.
To sum up for now - only one string needs to be corrected in the Polish part.

I'm trying to be a bit of a devil's advocate here, so as to reduce the number of complaining to minimum ;) If somebody wants to use GDH as a follower, status bar notification will - for sure- be useful. With Juggluco - this solution can also be beneficial - I see that my initial idea with two status bar icons stuck with you :D I in turn prefer your widget idea - less clutter in the status bar for me.
To sum up for now - only one string needs to be corrected in the Polish part.

:-D No problem! Each discussion helps to make the app better. As android needs the notification for running in foreground, I need to leave it as it is.
The next problem is, on my phone everything works well without notification, but it seems, that other guys have more problems.
And the biggest problem, that disabling the battery optimization by popup is not wanted by google... :-(
I have found some little bug, too. I have to fix it, hopefully I have some time, today...

@froster82 new test version available.
Please check, if it fits now.
Thank you!

@pachi81, no bugs on my side. The only thing which might still be checked is the description of the Floating widget. It does not include the iob/cob info. But that is only a small interface thing. One Polish description might be still changed to better fit in context, but it does not need to be done right now.

Yes, you are right. But I also thought about, that the floating widget text should contain an info, that it can be closed by holding it for more than 5 seconds.
But if there is no other issue, I would change it in the next version...


Clicking on PCB layers does not change layout diff image

It appears that clicking on PCB layers does not change the layout diff image (but using the arrow keys does).

Hi, I believe this is fixed now. Please ,open this issue again if you see it is still not working.


Digital traditional territory

The territory shapes should only be in the background and should not appear directly on the map. In the pipeline profiles version, it would be good to find the overlapping territories with the pipeline and create a table with links to these territories in native-land.ca

Mostly fixed


Models not supported by white box XAI methods

Following models are not yet supported in addition to NOT_SUPPORTED_BY_BB_MODELS mentioned in #29 due to various reasons.
SUPPORTED_BUT_FAILED_BY_WB_MODELS = {
    "convformer": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "swin": "Only two outputs of the between block Add node supported, but got 1. Try to use black-box.",
}

NOT_SUPPORTED_BY_WB_MODELS = {
    **NOT_SUPPORTED_BY_BB_MODELS,
    # Killed on WB
    "beit_large_patch16_512": "Failed to allocate<PHONE_NUMBER>0 bytes of memory",
    "eva02_base_patch14_448": "OOM Killed",
    "mobilevit_": "Segmentation fault",
    "mobilevit_xxs": "Segmentation fault",
    "mvitv2_base.fb_in1k": "Segmentation fault",
    "mvitv2_large": "OOM Killed",
    "mvitv2_small": "Segmentation fault",
    "mvitv2_tiny": "Segmentation fault",
    "pit_": "Segmentation fault",
    "pvt_": "Segmentation fault",
    "tf_efficientnet_l2.ns_jft_in1k": "OOM Killed",
    "xcit_large": "Failed to allocate<PHONE_NUMBER>0 bytes of memory",
    "xcit_medium_24_p8_384": "OOM Killed",
    # Not expected to work for now
    "botnet26t_256": "Only two outputs of the between block Add node supported, but got 1",
    "caformer": "One (and only one) of the nodes has to be Add type. But got MVN and Multiply.",
    "cait_": "Cannot create an empty Constant. Please provide valid data.",
    "coat_": "Only two outputs of the between block Add node supported, but got 1.",
    "coatn": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "convmixer": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "crossvit": "One (and only one) of the nodes has to be Add type. But got StridedSlice and StridedSlice.",
    "davit": "Only two outputs of the between block Add node supported, but got 1.",
    "edgenext": "Only two outputs of the between block Add node supported, but got 1",
    "efficientformer": "Cannot find output backbone_node in auto mode.",
    "focalnet": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "gcvit": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "levit_": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "maxvit": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "maxxvit": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "mobilevitv2": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "nest_": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "poolformer": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "sebotnet": "Only two outputs of the between block Add node supported, but got 1.",
    "sequencer2d": "Cannot find output backbone_node in auto mode, please provide target_layer.",
    "tnt_s_patch16_224": "Only two outputs of the between block Add node supported, but got 1.",
    "tresnet": "Batch shape of the output should be dynamic, but it is static.",
    "twins": "One (and only one) of the nodes has to be Add type. But got ShapeOf and Transpose.",
    "visformer": "Cannot find output backbone_node in auto mode, please provide target_layer",
    "vit_relpos_base_patch32_plus_rpn_256": "Check 'TRShape::merge_into(output_shape, in_copy)' failed",
    "vit_relpos_medium_patch16_rpn_224": "ValueError in openvino_xai/methods/white_box/recipro_cam.py:215",
}

Partially resolved by

https://github.com/openvinotoolkit/openvino_xai/pull/44
https://github.com/openvinotoolkit/openvino_xai/pull/48
https://github.com/openvinotoolkit/openvino_xai/pull/52


file.c: 2 * basic error ?

file.c:212]: (warning) Storing fgetc() return value in char variable and then comparing with EOF.
file.c:268]: (warning) Storing fgetc() return value in char variable and then comparing with EOF.

Fixed in [master e74d10b], thank you!


Bitgesell contribution program ($25000 overall budget)

Bitgesell (BGL) project is open for the contributions and participation.
BGL is BTC-derived cryptocurrency with own blockchain, transaction fee burning
mechanics and faster halving rate. A good source of the information would be
the first 2 posts in the bitcointalk forum thread:
https://bitcointalk.org/index.php?topic=5238559.0
There is community budget formed for the incentivizing project technical contributions.
Activities that would be compensated:

fixing integration tests (this process is approximately 50% completed).
A good chunk of tests fixed (see example here https://github.com/BitgesellOfficial/bitgesell/pull/46 would be compensated around $1000);
cleaning the codebase (this must require thorough understanding of what is required
and what is not), just fixing some comment links or introducing changes to readme
files could be useful (but bounty payment would be less);
we are also looking for maintainers to review PRs, test the build, test changes manually
and running test suites;
there are CirrusCI configs written to build the software for various platforms, there are
minor issues present and fixes/updates to those are also welcome;
fixes to the UI are welcome, example: BGL has only segwit addresses support (no legacy),
so the feature of signing a message is not supported (BTC does not support this too),
removing this from UI in a graceful way would be considered as useful contribution;
infrastructural upgrades: if you want to bring up BGL testnet (which is not
supported at the moment as the fees in mainnet are very reasonable) this would be much
welcome too;

This list is just an example, if you want to contribute in another way that you think
brings value to the project, feel free to ask prior (if the task is large) or make a
partial change/prototype. Honest contributions are welcome, the cheat/abuse contributions
like formal changes (formatting, a pair of comments added, etc.) would be rejected.
There are other repositories of the project (where you can propose updates too), notably:

BGL-ERC20 Bridge (https://github.com/BitgesellOfficial/wbgl-bridge);
BGL Web wallet (https://github.com/BitgesellOfficial/bitgesell-wallet);

We are strong believers in open-source and the approach that GitCoin is offering to
the worldwide developer community: freedom, transparency and direct cooperation.
Please respect everyone and don't spam messages that make no sense, any questions could
be asked in:

the comment section in this github issue;
the project forum thread (https://bitcointalk.org/index.php?topic=5238559.0);
project Discord channels (https://discord.gg/Ubp359vZEF);

PRs would be paid in USDT upon approval, contributions in other areas (like infrastructure)
would be compensated after implementation.
Interested people are welcome to become regular maintainers of the project (this is
negotiable after some contribution is made);
Welcome to Bitgesell team and good luck!

Please take a look at my PR

It's been 4 days

Closing the issue, the bounty program would be recreated.


Add CITATION.cff

This adds a citation cff file that should display nicely in the sidebar. I think that this can also make zenodo.json obsolete. Maybe we can test this also with the sandbox.
Do we have a release checklist? The release date, dois and version need to be updated here when a new release is made.

There is a release checklist on our internal wiki at TU Berlin. Maybe we should move this information to the GitHub Wiki?
I am confused, because the checkbox on the GitHub page does not show the expected APA and Bibtex tabs. Only the .cff file is linked.

I already tested it with the Zenodo sandbox on my private fork. However, one would need to remove the .zenodo.json file, as described in: https://help.zenodo.org/faq/ , which I don't think is necessary.

I'd say we should either have the authors listed in zenodo.json OR in citation.cff to avoid conflicting metadata. With citation.cff however we cannot guess the DOI of an upcoming release, can we?
Would it be an option to put just the zenodo citation into citation.cff and control everything using zenodo.json?
Another option could be to trust zenodo handling the citation.cff correctly and have all the data except the zenodo DOI there.
Btw. I found that the APA / BibTeX citations offered will show the preferred-citation data within citation.cff, in our case the Applied Acoustics article from 2017. Do we want to have it this way?

According to the zenodo FAQ, it is possible to know the DOI beforehand :
On the upload page under Basic Information and Digital Object Identifier click the Reserve DOI button. The text field above will display the DOI that your record will have once it is published. This will not register the DOI yet, nor will it publish your record (so you can still update the files). This DOI can be safely used in the record's own content as well as any other separate datasets or papers you might be planning to publish.

I'd say we should either have the authors listed in zenodo.json OR in citation.cff to avoid conflicting metadata.

I agree. There should be only one location where this information is supplied to keep things maintainable. Seeing that cff is a more general format, I would prefer it over something platform-specific.

With citation.cff however we cannot guess the DOI of an upcoming release, can we?

I think this is possible. As @adku1173 pointed out, https://help.zenodo.org/faq/ suggests that you can use Zenodo's reserve DOI feature for this purpose.

Would it be an option to put just the zenodo citation into citation.cff and control everything using zenodo.json?

I think that would be very incovenient.

Another option could be to trust zenodo handling the citation.cff correctly and have all the data except the zenodo DOI there.

IMO this is the way to go. If the zenodo reserve DOI feature works as expected, there should be no drawback.

Btw. I found that the APA / BibTeX citations offered will show the preferred-citation data within citation.cff, in our case the Applied Acoustics article from 2017. Do we want to have it this way?i

Being cited by a journal article feels like the "proper" way to do it. I suggest to add a message field to CITATION.cff that  and also add a small comment in the README.md that advises to cite both the software and the journal article.

There is a release checklist on our internal wiki at TU Berlin. Maybe we should move this information to the GitHub Wiki?

I think its a good idea to move it to gh. However, the release checklist might contain sensitive information. We should check for this. Maybe we can find a place on gh that restricts access only for main devs.

I am confused, because the checkbox on the GitHub page does not show the expected APA and Bibtex tabs. Only the .cff file is linked.

I had a typo in the file that I fixed. Now it shows up correctly. It does so without preferred-citation, only reference is enough which I like.

I think removing .zenodo.json is not an option. I tested both variants with the zenodo sandbox:

no zenodo.json: https://sandbox.zenodo.org/records/47715
with zenodo.json: https://sandbox.zenodo.org/records/47715

So far, using only CITATION.cff will, of course, not lead to a sufficient description and title.
Let's see if there is a way to achieve the same results with the .cff file. The title can be changed to: Acoular – Acoustic testing and source mapping software.

I tested both variants with the zenodo sandbox:
* no zenodo.json: https://sandbox.zenodo.org/records/47715

* with zenodo.json: https://sandbox.zenodo.org/records/47718

So far, using only CITATION.cff will, of course, not lead to a sufficient description and title. Let's see if there is a way to achieve the same results with the .cff file. The title can be changed to: Acoular – Acoustic testing and source mapping software.

I've changed the title and added an abstract. Can you check how it is rendered now?
By default, with a cff file, zenodo takes the repo description as description. This is rather short, so a longer version should probably be in the form of an abstract. I've notced that the github description "Library for acoustic beamforming" does not match the subtitle of "Acoustic testing and source mapping software". Should we adjust this?
Also the github homepage link uses http://www.acoular.org, maybe https://acoular.org is nicer...

If the HTML in the abstract field is not rendered correctly by zenodo, we could maybe omit the highlights list as a compromise.

If the HTML in the abstract field is not rendered correctly by zenodo, we could maybe omit the highlights list as a compromise.

It is indeed rendered correctly: https://sandbox.zenodo.org/records/47723
Thus, we can remove the zenodo.json metadata file :)

OK I think this is ready now! @adku1173 @esarradj


Change text italic and bold as suggested in UX

In the app some words in text are expected to be bold/italic as per UX

the text is like that in a lot of places, im sending beta feedback for those but it'll be difficult to post each link here

Please forward me the beta feedback here so that I can fix them ASAP

what is required from me? @Raheel1258 @cakesoft-shashank

@summikhan11 , We need feedback from you where we have to change text to italic and bold.

Closing this issue as discussed with dev.Tested on dev app v2.0.75(469)