feat(Material): Material You Support

Feature Description
"Material You" was announced a couple of days ago: https://material.io/blog/announcing-material-you which looks to be a visual redesign of the Material design system. It appears to be arriving this Fall
It looks like it's going to become a little less opinionated in various aspects and that'd be great for those currently using Material today as a UI Library and having to hack the hell out of it to make it deviate slightly.
Quote from the description:

We’re introducing a new visual redesign that gives you the power to customize the look and feel of your phone across the whole system. With smoother animations, more intuitive notifications, quick settings and new widgets for your favorite people, Android will feel more personal and alive than ever before.

My guess is that this'll arrive upstream via MDC which is already being implemented. Will this be considered?

We should get this automatically once we've finished the transition to MDC components.

Will this be "opt in" in any way? Not that I dislike it, but for my web app it's perhaps not as fitting and I'd rather not stay on an old version just to keep the design

Any progress on this issue or is there any roadmap for this upgrade ?

Any updates here?

from issue: When is Material Web 3 Coming?
I am really confused about that. can someone give a clear answer here?

Angular Material mdc is depend on material-components-web?
Material Team is not focused on material-components-web anymore, they turn to material-web?
Will Angular Material turn to material-web also or not going to have a Material You?

We're working directly with the Material Design group inside Google towards supporting design updates. No ETA just at this moment, but it's definitely something we're working towards.

Glad to see I'm not the only one who's confused. I've been watching and waiting for a design update, literally for years - mainly for the density feature, but M3 is surely a welcome addition.
From what I've read:

The Angular material team has been working on integrating with the MDC components for over three years and still actively working on it, known as the experiment components. They were planning to stablize and release them in version 14 but since v14 is imminent I doubt it's still on track;
MDC is based on Material Design 2 (M2) and is not gonna be updated for Material You (M3) (https://github.com/material-components/material-web/issues/3050#issuecomment-1011464627)
A new set of components, known as the MWC, is based on M3, which will launch later this year;
It doesn't seem Angular material has started to integrate with MWC yet
as @crisbeto stated, we'll get M3 when the transition to MDC is complete, seemingly contradicts with the facts above
It seems Angular material has not started or is still in the early stage of integrating with MWC, so can I assume we are not getting M3 in the near future?

Angular Material MDC migration has been a running gag in my company for years. Some kind of "When are you planning to release this feature ? -- Oh you know, when Angular Material will use MDC".
It's a gentle joke but actually it's a sad situation because I feel (and I guess not to be the only one) like Angular Material will never propose real new features anymore (like two-direction drag-n-drop, more theming customization, more card capabilities or even time picker) and every real improvment are only reserved for Android and, more generally, for mobile devs. I'm aware that it's an open source project and the team has limited resource (just like every company) but it's hard to not feel impatience and frustration. That said, I will keep supporting and using Angular/Material because I love it. But guys please, do not let us down.

Is there any new information on the confusion in this thread? There doesn't seem to be any indication that Angular Material will support Material You (Material Design 3) from the fact that it references the old MDC implementation. We are looking into building a design on top of Material Design 3 and Angular Material, so I was wondering if this would be possible in the near future or if we should scrap that idea for the next year or 2?

The Material components offered now with Angular is the legacy components, which was released before Material 2 specification was out.
According to unofficial rumours the Material 2 components might be made available with Angular 15 release latter this year, but still it is not confirmed.
Having Material 3 components with Angular may not be a reality for the next several years. It might not happen at all.

According to unofficial rumours the Material 2 components might be made available with Angular 15 release latter this year, but still it is not confirmed.
Looking at v15 "next" release notes would suggest it's very likely they'll be rolled out with the release.  Now, that's not to say it won't go through a "Developer Preview" period like some of the big new features that've been released recently, but even in that case, it seems very close to seeing the light of day: https://github.com/angular/components/releases/tag/15.0.0-next.0

v15 will promote the MDC-based components ot stable. These components are a stepping stone to future iterations of the design system (M3). If you peek on ongoing PRs, you'll see the theming mixins for many of the components transitioning to design tokens, which is the basis for M3.

I noticed that!  I'm excited to see a greater use of CSS Custom props.  Do you foresee that impacting how teams configure the overall theme using the Sass theming API?

Yeah, any support for M3 will be part of a larger update to Angular Material's theming system. While the design isn't fully complete, it will likely involve a lot more customization options.

@jelbourn  is there any way that one could contribute to moving forward with this change?

Unfortunately no, we're still waiting on deliverables from the Material Design folks to be able to move forward on the Angular side.

@jelbourn Thanks, Are there already specific issue(s) on the Material Design side that we can point to here?
Maybe the community wants to support them to speed things up here :)

I don't think so, since the changes relate to the underlying Material Design token definitions for web which I don't think have been formally published anywhere.

Any updates?

Some incremental work transitioning to design tokens is associated with the Angular 16 release.
I also spotted the barest of hopeful hints from @mgechev of the Angular team on the general Material You development arc (along with further context that may be of interest).
Additionally, in the broader context of Angular 16, a brief Angular 16 release summary I found insightful also notes this Material You development.

Are we getting Material 3 styles in Angular Material?

Is there any update on Angular Material 3 support?

Any update about Material 3 ?

In a recent tweet @SerkanSipahi mentioned a PR for the initial implementation of Material 3 theme objects that has since been merged as part of a current Angular Material benchmark in the Angular Roadmap towards enabling Material 3 capabilities. As another marker of progress also note that legacy Angular Material components (pre-MDC) will be dropped in Angular 17.

Any updates?

https://twitter.com/materialdesign/status/1714378297696461160?t=hDBDncKLA-qWuXPBBL6PCA&s=19

Can someone please explain the relation between Angular Material and Material Web? Is Angular Material going to transition from Material Components Web -> Material Web next or will those be kept completely separate? What's the plan here?

cc @ciriousjoker
Material Web uses the Lit Framework as the core engine and Angular Material uses the Angular Framework as the core engine.

@SerkanSipahi You can use web components (which lit produces afaik) in Angular as well though. I'm assuming the benefit is therefore mostly in the convenience of using them and probably a better integration?
Given the speed at which Material Web seems(!!) to have been implemented relative to MDC, is that project a higher priority at Google?
I'm trying to figure out if it makes sense to use Material Web in Angular even though the readme currently suggests using Angular Material. I'm essentially speculating that Google might pull the plug on Angular Material and/or the MDC it's built on in the future and the overhead of using Material Web in Angular might therefore be worthwhile.

Feels like Angular is the next on https://killedbygoogle.com/

Felt like it a while ago when react had that huge jump with SSR and hooks and all the other shiny things popped up (shelter, solid, ...), but v15+ seems like Google actually puts in resources again, so I wouldn't worry about that.
off topic though...

During the Angular Special Event on Nov 6, 2023, @mmalerba of the Angular team mentioned that we might see Material 3 as soon as a minor version of v17. Later during the same event @simonaco of the Angular team also confirmed that Material 3 is one of the Angular team's priorities moving beyond v17 (Nov 8) and the advent of angular.dev.

Any updates?

Apparently recent releases have shown some great progress towards M3. It's just I didn't find an instruction of how to use or opt-in these new features.

Apparently recent releases have shown some great progress towards M3. It's just I didn't find an instruction of how to use or opt-in these new features.

Run npm i<EMAIL_ADDRESS>or npm i @angular/material@next in your project. This will install the version with the M3 components, should be noted that this is obviously not a stable version

Are the new design tokens replacing the sass api or are there going to be breaking changes in the sass api?
I have some components that are styled based on the provided material theme and use partial scss files.

Run npm i<EMAIL_ADDRESS>or npm i @angular/material@next in your project. This will install the version with the M3 components, should be noted that this is obviously not a stable version

Thanks for the tip. Do you know if there is an entry point for the M3 components ? because I just installed the latest pre-release version<EMAIL_ADDRESS>and it still has the old design by default.

Instructions to use Material 3 are listed in material-experimental:
https://github.com/angular/components/tree/main/src/material-experimental

Instructions to use Material 3 are listed in material-experimental: https://github.com/angular/components/tree/main/src/material-experimental

These are instructions for Material 2 MDC components, which have been released with Angular 15.

Hey folks,
any instruction/update on how to use the M3 components in Angular (RC)??

Hi everyone,
I'm writing to follow up on the release of angular/components version 17.1.0 yesterday. While this version introduces support for M3, it seems to default to M2.
Could you shed some light on how to enable and utilize M3 with this new release? Any guidance or documentation would be greatly appreciated.
Thanks in advance,

As per this README.md we need to add the theme and typography mixins to the Sass.
I wasn't able to get it to work.
  @use '@angular/material' as mat;
  @use '@angular/material-experimental' as mat-experimental;

  $my-primary: mat.define-palette(mat.$indigo-palette);
  $my-accent: mat.define-palette(mat.$pink-palette, A200, A100, A400);
  $my-theme: mat.define-light-theme((
    color: (
      primary: $my-primary,
      accent: $my-accent
    ),
    // Using `define-mdc-typography-config` rather than `define-typography-config` generates a
    // typography config directly from the official Material Design styles. This includes using
    // `rem`-based measurements rather than `px`-based ones as the spec recommends.
    typography: mat-experimental.define-mdc-typography-config(),
    // The density level to use in this theme, defaults to 0 if not specified.
    density: 0
  ));

  @include mat-experimental.all-mdc-component-themes($my-theme);

There are no M3 components in 17.1.

As per this README.md we need to add the theme and typography mixins to the Sass.
I wasn't able to get it to work.
  @use '@angular/material' as mat;
  @use '@angular/material-experimental' as mat-experimental;

  $my-primary: mat.define-palette(mat.$indigo-palette);
  $my-accent: mat.define-palette(mat.$pink-palette, A200, A100, A400);
  $my-theme: mat.define-light-theme((
    color: (
      primary: $my-primary,
      accent: $my-accent
    ),
    // Using `define-mdc-typography-config` rather than `define-typography-config` generates a
    // typography config directly from the official Material Design styles. This includes using
    // `rem`-based measurements rather than `px`-based ones as the spec recommends.
    typography: mat-experimental.define-mdc-typography-config(),
    // The density level to use in this theme, defaults to 0 if not specified.
    density: 0
  ));

  @include mat-experimental.all-mdc-component-themes($my-theme);

I opened an issue for it: https://github.com/angular/components/issues/28465
There has been a lot of work going on for M3
Check out the demo app: click on Use M3 theme and scroll on components to see what they look like.
https://ng-comp-devapp.web.app/button

Hi all,
Just for info, as pointed by @eneajaho , readme is not ready but looking at theme-m3.scss it is posible to test M3.
I just wanted to ask, as question comes often, is there a way to follow the advancement and tasks remaining around M3 (components migrated, in progress or not started)? Something like in material web project for example:

It could help for visibility and also to have may be feedbacks around components fully migrated.
It is just a question :)

Hi all,
Just for info, as pointed by @eneajaho , readme is not ready but looking at theme-m3.scss it is posible to test M3.
I just wanted to ask, as question comes often, is there a way to follow the advancement and tasks remaining around M3 (components migrated, in progress or not started)? Something like in material web project for example:

It could help for visibility and also to have may be feedbacks around components fully migrated.
It is just a question :)

Hi
I managed to get it working

Repo: https://github.com/eneajaho/material-3-demo
Commit https://github.com/eneajaho/material-3-demo/commit/3f8e742967ade4b0c685c07b4ce727b1ba82a08e

https://github.com/angular/components/assets/25394362/36962f4a-ba6c-4523-94cb-98fce405fd1a

Hi,
Since version 17.2.0, we have Material 3 and all the guides to migrate and that's great :) (But in experimental of course.)
But i was just wondering, if as said in the M3 migration guide " The team plans to stabilize support for M3 after a brief period in experimental in order to get feedback on the design and API."
Do we know if it is still plan for a final delivery in next version 17.3? Otherwise i imagine it won't be available until Angular 18 ?
(As i assume 17.3 will  be the latest in Angular 17)
Thanks

Is there a project for tracking the progress of m3 implementation?
For instance I found the slider component is still in m2 style, as of version 17.3.5. I would like to know which components are m3-ready.
I found an old project for MDC but apparently it's not for m3.

Closing this issue since M3 is available in experimental as of 17.2 and will be stable soon. Here is the guide for migrating to M3.
@hillin this is the M3 project board we are using

Thanks @amysorto, but the project board link is broken (404). Do I need certain priviledge to see it?


Create infisical-secrets-check.yml

:white_check_mark: Build Sankhya-SDK-dotnet 3.0.576 completed (commit https://github.com/guibranco/Sankhya-SDK-dotnet/commit/42bf8af2e4 by @guibranco)

:white_check_mark: Build Sankhya-SDK-dotnet 3.0.588 completed (commit https://github.com/guibranco/Sankhya-SDK-dotnet/commit/deb38df8e0 by @guibranco)


Internationalization

[ ] Code changes to support native internationalization.
[ ] API to add languages manually.

[x] find german translator

Tracking in RationalCoding/multihack-brackets#21


Update README.md

Latest version of readme file
:ballot_box_with_check: Definition of Done checklist

[x] Meaningful title and valuable description in pull request
[x] Code change tested manually if not covered by automated tests
[x] Pull request linked to one or more issues/stories
[x] Acceptance criteria of the linked stories satisfied
[x] Code change comprehended by those who approved it
[x] State of target branch maintained or improved after the code change
[x] Go to com.example.hermes (androidTest) in the Android App and uncommit @Test  Run test manually. Add a picture of the test result in the comments.  Comment @Test again to avoid future problems with the CI


Added plateus/cliffs

Replaces my previous pull request on the same subject

@Ralith Would you prefer me to focus first on abstracting cliffs to make it easier to add similar structures, or expanding their functionality to allow for things like face-wise bumpiness and improved occlusion?


fix: sc4s archiving

:tada: This PR is included in version 3.13.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feature: listview

What are your thoughts on listviews? Is it something I have to compose from existing components?
for my application I need to display a lot of lines and have the user select one of them. The line currently being the candidate for selection is hightligted and some hotkey defines that the selection is made (possibly enter).
Naviagation of the current selected line needs to be accessed from outside the component (eg. a method MoveUpOne(), MoveUpPage(), MoveDownOne(),..). This allows me to combine the listview with a textfield so that the content of the listview is filtered.

Perhaps the nicest solution would be to extend the datagrid such that it has a notion of a current selected line which is highlighted and some input handling for when cursor keys or enter is pressed.

I'm sorry, but I think that this control is too specific and indeed should be composed from existing components.
It should be easily achievable by using a StackPanel with TextBlocks wrapped in Backgrounds.
And everything controlled by a custom IInputListener.
To get a little bit cleaner code you could create a ListView and ListViewItem by inheriting the SimpleControl and exposing just the desired interface.
My rule of thumb when deciding if something is too complex to be included in the core library is: if it's not available in the HTML/CSS, but people still manage to relatively easily create it with lower level components, then it (probably) should not be available here neither.

HTML does have a list view :-) for applications such controls are very common. But maybe your framework is n9t targeting that.

Well, the list view in the HTML (if you are talking about the <ul> tag) is no much different then the VerticalStackPanel. Anything more then that has to be achieved either by custom styling and/or more advanced layouts.
There is nothing it the pure HTML that provides an out-of-the-box list with highlights/selection/filtering in a single control. Fo some of that you will actually need some additional code-behind in a form of js.
Of course, in the HTML/CSS roam you can use an external library to get a nice list view. And I highly encourage creating control sets associated with this project as well. It's simply that this project was meant to be a layout management library for console applications and (at lease as long as I'm the only contributor which brings some time constrains) I want to keep it this way.

No, I'm refering to the https://www.geeksforgeeks.org/html-input-list-attribute/ list functionality which when given enough vertical space acts as a listview.
Regarding the filtering, above I wrote I would want to extend the listview myself ;)

Oh, then you not talking about simple lists, but drop-down lists/menus once again.
In that case I'm merging this topic with #12 and for now marking it as wontfix.
And for anyone stumbling upon this thread in the future:
If you want to create a simple list view with multiple options:

It should be easily achievable by using a VerticalStackPanel with TextBlocks wrapped in Backgrounds.
And everything controlled by a custom IInputListener.
To get a little bit cleaner code you could create a ListView and ListViewItem by inheriting the SimpleControl and exposing just the desired interface.

This of course ia your choice, i still think if the listview is operative using the keyboard scrolling content when the list is larger than the allocated screen, needs be addressed and hence a simple decorator wont suffice

But if you predict that the list might be longer than the available space, then you should host the vertical stack panel containing it in a VerticalScrollPanel. VerticalScrollPanel supports keyboard navigation. But if you want to override the default behavior with something a little bit more complex, so that the list would follow the selected item, it's also very easy.
Implementing this logic is as simple as that:
class MyScrollableListController : IInputListener
{
	...

	public void OnInput(InputEvent inputEvent)
	{
		switch(inputEvent.Key.Key)
		{
			case ConsoleKey.UpArrow:
				_selectedItem--;
				break;
			case ConsoleKey.DownArrow:
				_selectedItem++;
				break;
			default:
				return;
		}

		_selectedItem = Math.Max(Math.Min(_selectedItem, myListView.Length), 0);

		myListView.Highlight(_selectedItem);
		scrollPanel.Top = _selectedItem - scrollPanel.Size.Height / 2;
	}
}

I don't see a point in involving the framework in this process.


Feature request: add option to toggle Server Streaming

The reason satisfactory is taking up so little memory right now is because they accidentally shipped the update with Server Streaming enabled. The feature itself can impact server stability negatively when enabled. Would like an option to force it on/off.
Engine.ini:
[ConsoleVariables]
wp.Runtime.EnableServerStreaming=0

Also, I've heard that CSS intends to disable it again on another update.

Hey! I somehow missed the noficiation for this. Seems trivial enough to add, I'll work on this shortly :) In the meantime, you can override the Engine.ini file directly

Sorry this took so long! This is doable via the SERVERSTREAMING environment variable now :)

Sorry to post into a closed issue.
What is this server streaming? I couldn't find any resources on this, would be nice to know what this relates to, since it apparently changes the ram usage a lot!

@Koozu1 it's referring to asset streaming :) When it's enabled, it drastically reduces the RAM utilization of the server, but can introduce other bugs as a result. So if you've got the RAM to spare, you're better off disabling it


Start Melody on IE11

microbit.org-ticket: 1611
I don't have IE11 on any of my machines, could you confirm whether you expect this to work or not? Thanks
We did an example for school kids with goolge chrome and the "start melody" function. Now we want to teach 80 school kids on thursday how to use microbit, but only IE11 is available on their laptops.
Is it possible to use "start melody" with IE11 ?

Update from customer:
And we have also the problem, that there is no sound in simulator with IE .
With chrome it works fine.

Web Audio is not supported in IE11 so this is by design.
Get Outlook for iOShttps://aka.ms/o0ukef

From: David Whale<EMAIL_ADDRESS>Sent: Tuesday, April 25, 2017 2:12:55 AM
To: Microsoft/pxt
Cc: Subscribed
Subject: Re: [Microsoft/pxt] Start Melody on IE11 (#1968)
Update from customer:
And we have also the problem, that there is no sound in simulator with IE .
With chrome it works fine.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt%2Fissues%2F1968%23issuecomment-296968932&data=02|01|jhalleux%40microsoft.com|d3d67d751c69455a739808d48bbb43e1|72f988bf86f141af91ab2d7cd011db47|1|0|636287083789266854&sdata=J7apqYW2oRYZTvd5VnP8ULVnw12vL4nUcb1LNcsOYg0%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KbtOVRFbm61bdMe1A9Flj_thPwzYks5rzbkXgaJpZM4NHKyX&data=02|01|jhalleux%40microsoft.com|d3d67d751c69455a739808d48bbb43e1|72f988bf86f141af91ab2d7cd011db47|1|0|636287083789266854&sdata=L2wOOBukqcx5luHyjN052nlJxYpQmZlSa47AuiSLOnU%3D&reserved=0.

Thanks, this extra info is really useful. I'll make up a k-base article explaining the limitations of using IE11.


GCE Driver.

This is a continuation of https://github.com/docker/machine/pull/7
I accidentally screwed up my remote branch, and then it got merged somehow.
I had a couple questions from that PR:
First, the GCE API uses oauth2 with refresh tokens. My current implementation caches tokens in driver.storePath, but this is obviously deleted when a machine is rm'ed, and only applies to a single machine. Would you be opposed to caching them one level up? So .docker/hosts/gce/ instead of .docker/hosts/gce//
Second, my test is more of an integration test and actually creates/rm's a machine. It's currently failing travis because it needs a real project ID to run against. Are you interested in having this kind of test? If so, how do you want me to block it from the travis run?
Signed-off-by: Dan Lorenc<EMAIL_ADDRESS>

@bfirsh i just tested again and works.  docs added in #201.

@bfirsh i just tested again and works.  docs added in #201.


⚠ Bofrost.fr has degraded performance

In 9bcf603, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1532 ms

Resolved: Bofrost.fr performance has improved in 8cd9a51 after 24 minutes.


Samples: Cron Job for BiMonetary example

https://github.com/bitwarden/core/blob/master/src/Jobs/Program.cs

Implementing background tasks in .NET Core 2.x webapps or microservices with IHostedService and the BackgroundService class


Move to .NET 6

https://docs.microsoft.com/en-us/aspnet/core/migration/50-to-60?view=aspnetcore-6.0&tabs=visual-studio

Done in d3f31e91299ce9a4b37e939924e65ccc05707595


Noarch Python

As this is pure Python and is Python 2/3 compatible, this is a good candidate for a noarch Python build. So switch it over to using noarch Python. Should cutdown on CI resources used and reduce the maintenance burden.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Bug Fix / UTF-8 Encode

Bug Fix
UTF-8 Encode

Hi Thanks for this improvement. It's a sadly neglected tool, very useful.

Thanks


Added sample code

Added sample code, included text on possible benefit of using a method with out.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: leastofthese23 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Upload Food

Hi I upload food photo, press Detect and see Internal Server Error message. Please advise how could I use it. Thanks.

Hi @ctu1121, I think it has a problem with the weight in the gdown cell, the weights cannot be downloaded so it triggers that error. I will look into the problem in the future, if you have any solution to download the weights, please let me know. Thank you!


Doesn't show app icons..

Thanks for the nice one, but Is this the issue for the library or Apple side, I am not sure.
The app icons part are all blank when I open it.

This is due to the iOS 9 security that block access to non secure URLs. You need to open your Info.plist file and add the NSAppTransportSecurity dictionary, and then create the NSAllowsArbitraryLoads item within that, with a boolean type set to YES.


Cleanup implementation of sessions

I need to enable a couple of things for sessions, but this is low priority during early development so I'm creating an issue for it.

[x] Use a real session secret, probably defined in .env
[ ] Implement https protection by enabling cookie.secure. see the readme

Closed in 4323082b78ccddfbc283fbb97f031b0d5fb5fa43


Header and Footer should stay uncoupled

Context
Given a next appDir app, as Header does not accept children, we sometimes have to make a "use-client" Header to handle authentification state.
For example with next-auth, we could use the "getServerSession()" function instead, and make everything "server-only", this this will opt-out everything to SSR and not static as "getServerSession()" use Next's headers() and cookies() functions internally.
The solution to avoid that is to use useSession() client hook, and leaf out the Header component into a client wrapper component.
The goal is to provide and DSFR compliant, and as much static as possible header avec quickAccessItems that include reactive items depending on a hook state.
Beside that, on the product marketing point of view, we need to have "onClick" and/or "href" from linkProps to have their own function (e.g. onClick() { trackHeaderClick(); }
Pain
With zz_internal/brandTopAndHomeLinkProps.ts the coupling makes that we cannot have a client Header on one side, and a server/static Footer on the other.
I don't really see where resolving the pain of setting twos brand image or links was worth the drawback.
Also, it prevent us from having separated linkProps (e.g. adding different utm_source in the url), and DSFR doc doesn't precise if links and brands have to be the same.
On a side note, I know that this lib is not in v1 yet, but it could be really great if no API breaking changes like this one either be introduced, or by default, left undocumented on release notes.
Proposed Solutions

Undo what was done with zz_internal/brandTopAndHomeLinkProps.ts
Make this coupling login less strict with a warning instead to allow both mechanics
Expose setBrandTopAndHomeLinkProps() to be used in an isomorphic setup
Allow Header's quickAccessItems to accept "ReactNode" like navigation props

Apologies for the less than ideal experience. I'm currently in the process of refining the App Router and learning about various usage scenarios, which means that there may be some hiccups along the way. I acknowledge that there are instances where the Header would be on the client side, and not the Footer - this was something that I did not initially anticipate.
As for your concerns about introducing breaking changes without sufficient documentation - I understand and appreciate your feedback. Although the library hasn't reached v1 yet, I want to retain the flexibility to iterate quickly. Once we reach v1 (which should be soon), I intend to version the documentation and will provide a migration guide for each breaking change.
I make it a point to keep the demo setup and the documentation as up-to-date as possible. However, in this instance, I admit I overlooked some updates. I appreciate you bringing this issue to my attention.
During this pre-v1 stage, I'd be more than willing to issue pull requests to your repository if I introduce any other breaking changes.
The coupling of the Header and Footer, while a bit unconventional, is intended to enhance the developer experience. This, of course, is under the assumption that everything functions as intended.
You brought up a valid point about the Header not accepting children. This is an issue I've been addressing in the new GDPR branch, where I'm enabling the use of custom React nodes as items in the Header and Footer. This is precisely to allow the use of client components without needing to wrap the Header/Footer within a "use client"; directive.
Considering all these points, I'll be pushing a fixed version that addresses them. Please bear with me during this process and thank you for your patience and valuable feedback.

In summary:

You now have the option to explicitly pass brandTop and homeLinkProp to the <Footer /> as was previously possible. If these are not supplied, an attempt will be made to retrieve them from the <Header />.
It is now possible to create any Header quickAccessItem on the client side without the need to wrap the entire Header in "use client";. For more details, please refer to the note in Storybook.
The same applies for Footer's bottomItems.

Additionally, from a product marketing perspective, it would be beneficial if linkProps like "onClick" and/or "href" could have their unique functions (e.g., onClick() { trackHeaderClick(); }).

While I might not fully grasp your statement, it's worth noting that a Header quick access item can indeed be a button, and therefore, it can possess an onClick function.
Here is an example:
https://github.com/codegouvfr/react-dsfr/blob/0b6f5b8af9de1bbc79d91cc3dd25e12d8e807fbe/test/integration/next-appdir/ui/ClientHeaderQuickAccessItem.tsx#L1-L25
I hope these improvements address all your concerns. Thank you for bringing these issues to our attention.

Great! Thank you for the changes 🎉
Feels nice to have a flexible Header.

Beside that, on the product marketing point of view, we need to have "onClick" and/or "href" from linkProps to have their own function (e.g. onClick() { trackHeaderClick(); }
I was talking about the homeLinkProps which may need to have a different behaviour depending if the header link or the footer link was clicked.

Thanks for the feedback!

I was talking about the homeLinkProps which may need to have a different behaviour depending if the header link or the footer link was clicked.

Oh I see!
Sorry for the borken link in my reply, here you have links to an example usage of a client side header quick access item with the header used a server component.


Support upstream spreadsheet structure changes @ 2021-04-08

What's still left to do is to expose the many new data fields in the CSV.

Done in #19.


Type "Node" is missing a "resolveType" resolver.

I am not sure this is a bug. I use Prisma init my project. select typescript-advanced. When I yarn start I always found this console "Type "Node" is missing a "resolveType" resolver. Pass false into ".
I doubt it because I do not yet edit the file but its show this console.

It's just a warning. To hide it add the followingin the schema:
const schema = makeExecutableSchema({
  typeDefs: importSchema("./src/schema.graphql"),
  resolvers,
  resolverValidationOptions :{
    requireResolversForResolveType: false
  },
  directiveResolvers
})

Thanks for bringing this up @vistriter, and your suggested fix @gsancho! 🙌
I'll keep this issue open for a bit to keep the discussion going, and to see if there are other things that should be adjusted.

Thank you! @gsancho. Now, It's not have warned. I will let you know if have a new problem. @marktani

Same issue. FYI

Same issue.
As with @idkjs,  the suggested solution doesn't work for me either, I'm afraid. I still get the warning.
Code is shown below:
const { GraphQLServer } = require('graphql-yoga');
const { Prisma } = require('prisma-binding');

const resolvers = {
  Query: {
    info: () => 'This is the API of a Hackernews clone',
    // info: () => null,
    feed: (root, args, context, info) => {
      return context.db.query.links({}, info);
    },

  },

  Mutation: {
    post: (root, args, context, info) => {
      return context.db.mutation.createLink({
        data: {
          url: args.url,
          description: args.description,
        },
      }, info)
    },
  }
}

const server = new GraphQLServer({
  typeDefs: './src/schema.graphql',
  resolvers,
  resolverValidationOptions :{
    requireResolversForResolveType: false
  },
  context: req => ({
    ...req,
    db: new Prisma({
      typeDefs: 'src/generated/prisma.graphql',
      endpoint: 'https://eu1.prisma.sh/some-random-stuff-here/hackernews-node/dev',
      secret: 'mysecret123',
      debug: true,
    }),
  }),
});

server.start(() => console.log('Server is running on http://localhost:4000'));

As with @expatia and @idkjs I am getting the same warning.
const server = new GraphQLServer({   typeDefs: './src/schema.graphql',   resolvers,   resolverValidationOptions :{     requireResolversForResolveType: false   },   context: req => ({     ...req,     db: new Prisma({       typeDefs: 'src/generated/prisma.graphql',       endpoint: 'https://us1.prisma.sh/some-random-stuff/todo-node/dev',       secret: 'mysecret123',       debug: true,     }),   }), }) server.start(() => console.log(Server is running on http://localhost:4000))

I'm getting this error too when running my tests and this option is abstracted away in a package

Can you elaborate on how it is abstracted away, @wesbos?
There's a pending PR to add the respective option to graphql-yoga, would that help? https://github.com/graphcool/graphql-yoga/pull/270

I'm using graphql-mock in my tets - I guess I will have to PR that option over there as well

Just upated Prisma from 1.1.3 to 1.6.3 and this warning started to appear when I run yarn run dev

The just released version 1.12.0 of graphql-yoga ships with the functionality of passing the resolverValidationOptions while creating the GraphQLServer instance. Passing requireResolversForResolveType: false will eliminate the warning you've encountered before.
const server = new GraphQLServer({
  typeDefs,
  resolvers,
  resolverValidationOptions: {
    requireResolversForResolveType: false
  }
 });

Cool. Thank you!

Thanks for the PR, @akoenig 🙌

Thanks @abelovic! Please bring this up here: https://github.com/graphcool/graphql-yoga 🙂

const schema = makeExecutableSchema({   typeDefs: importSchema("./src/schema.graphql"),   resolvers,   resolverValidationOptions :{     requireResolversForResolveType: false   },   directiveResolvers })
passing resolverValidationOptions, worked for me. Thanks.

So while the option turns it off, is there a nice explanation somewhere of what the warning was for?
How and why would I implement resolveType so I wouldn't have to turn the option off?
I want to have a good understanding to explain to my students.
Thanks in advance.

@jeffbski: I don't have a full grasp on the details, but my rudimentary understanding is that it stems from the difference between the Prisma server and the application GraphQL server.  Specifically, I believe that the error indicates an absence of resolvers in the application server for types in the Prisma server.  Of course, those resolvers are often not necessary as not every Prisma type needs to be functional on the application side.
In trying to dig up some info., I read the bottom of this ReadMe:

requireResolversForResolveType will require a resolveType() method for Interface and Union types. This can be passed in with the field resolvers as __resolveType(). False to disable the warning.

and, more descriptively, this post!

All the other GraphQL interfaces from the GraphQL server schema (which is the entire schema and not only a part of it as before) are not resolved. But you don’t need to resolve them, because they are not used in your actual GraphQL queries and mutations in your application. Thus, you can deactivate these warnings.

@jangerhofer
Your comment is accurate, with this small adjustment:

Specifically, I believe that the error indicates an absence of resolvers in the application server for types in the Prisma server.

The warning is specifically about the Node interface (not type).

@marktani how would you implement the Node interface as a resolver?

@jeffbski I got some insight here.

When you have a field in your schema that returns a union or interface type, you will need to specify an extra __resolveType field in your resolver map, which tells the GraphQL executor which type the result is, out of the available options.

Check out the example that follows.

If anyone, like me, actually wants to implement the Node functionality provided in the Prisma API - in the front API (it gives you the ability to search for any type just by ID, and optionally return different data set by one of more fragments, of the correct type - sample below)
[so basically the same query can return different data based on the actual type ]
I'm assuming that you are seeing references to Node because you have 'comment imported' a type that uses the Node interface from prisma
i.e you have this in your schema.graphql file (assuming running one of the boilerplate projects from prisma):
# import Post from **"./src/generated/prisma.graphql"
Prisma's types implement the Node interface
You can implement Node and actually make use of it like this:
schema.graphql
add the following Query
type Query {
    node(id: ID!): Node
}

resolver.file.js/ts
Query: {
    node (parent, { id }, ctx: Context, info) {
      return ctx.db.query.node({ id }, info)
    },
  },
Node: {
    __resolveType (obj, context, info) {
      if (obj.post) {
        return 'Post';
      }

      if (obj.user) {
        return 'User';
      }

      return null;
    }
  },

Once you have that up and running, you can post the following via GraphQL Playgroungd to try it out, take an actual id of something in your database.
In order to get this to work, User (a type specified in the API Schema) also has to implement Node
fragment NodePostFragment on Post{
  id
  title
  isPublished
}
fragment NodeUserFragment on User{
  id
  name
  email
}
query {
   node(id: "cjkvah3cq000x0768lxssul3e") {
       id
       ...NodePostFragment
       ...NodeUserFragment
  }
}

If anyone, like me, actually wants to implement the Node functionality provided in the Prisma API - in the front API (it gives you the ability to search for any type just by ID, and optionally return different data set by using one or more fragments, of the correct type - sample below)
[so basically the same query can return different data based on the actual type ]
I'm assuming that you are seeing references to Node because you have 'comment imported' a type that uses the Node interface from prisma
i.e you have this in your schema.graphql file (assuming running one of the boilerplate projects from prisma):
# import Post from **"./src/generated/prisma.graphql"
Prisma's types implement the Node interface, so after making the executable schema this will have been imported to your API schema:
type Post implements Node {
  id: ID!
  createdAt: DateTime!
  updatedAt: DateTime!
  isPublished: Boolean!
  title: String!
  text: String!
  author(where: UserWhereInput): User!
}

For this example you will also want to change the User type in your schema.graphql to implement Node, like so:
type User implements Node {
  id: ID!
  email: String!
  name: String!
  posts: [Post!]!
}

You can then implement Node functionality in your API to actually make use of it like this:
schema.graphql
add the following Query along with whatever else you have
type Query {
    node(id: ID!): Node
}

resolver.file.js/ts
In one of your resolver files, add both of these resolvers, one for node, and a special one similar to that described here
https://github.com/apollographql/graphql-tools/blob/master/docs/source/resolvers.md
I've tweaked it to get it to work without having to manually specify every type that could be returned (thanks to the fact that we actually call 'node' on the prisma api for the data which returns the actual type in the response)
Query: {
    node (parent, { id }, ctx, info) {
      return ctx.db.query.node({ id }, info)
    },
  },
Node: {
    __resolveType (obj, ctx, info) {
      return obj.__typename
    }
  },

Once you have that up and running, you can post the following via GraphQL Playground to try it out, take an actual id of something in your database.
In order to get this to work, User (a type specified in the API Schema) also has to implement Node
fragment NodePostFragment on Post{
  id
  title
  isPublished
}
fragment NodeUserFragment on User{
  id
  name
  email
}
query {
   node(id: "cjkvah3cq000x0768lxssul3e") {
       id
       ...NodePostFragment
       ...NodeUserFragment
  }
}

Now say that the ID passed in is actually for a Post, you'd get this response, with only fields from the Post fragment.
{
  "data": {
    "node": {
      "id": "cjkvah3cq000x0768lxssul3e",
      "title": "Hello World 👋",
      "isPublished": true
    }
  }
}


Annyang is not running the command line.

I tried to get annyang to search Google on click of a button here is the code:
<script src="//cdnjs.cloudflare.com/ajax/libs/annyang/1.6.0/annyang.min.js"></script>
<script>
if (annyang) {
  var commands = {
    'search *term': function(term) {
      window.location.href = 'https://www.google.com/#q=site:frostcraft.netne.net'+term;
    }
  };
  annyang.addCommands(commands);
}
}

I then have a a button that when clicked, activates annyang.
The code is:
<i class="mdi-av-mic" onclick="annyang.start();"></i>

Clicking on the button activates voice listening but it does not search for what I say on Google.

@Frostcraft - I tried your code and it worked after I fixed some basic javascript errors like, an extra closing bracket, and missing </script>
If you could show me the complete code, and explain exactly what happens, it will be easier for me to help you.


Plug doesn't work with AS 2.3+,and reports NullPointerException.

I tested the origin plug code in IDEA, and found it ok, maybe there is something wrong with AS 2.3,and alse report  tht error to Google.Holp it will be solved by next AS version.
Here's my temp solution to solve this problem.
1.install plug in IDEA,
2.new Directory "drawable"
3.copy the image to "drawable" directory
4.do as before(right click the dir,and generate selectors)
5.copy the generated selectors to AS module.

me too


PIZ2-add-a-beverage-model-manager-and-service

Why?

Beverages are new option when creating an order.

What i changed?

Add new templates for beverages
Create new service to fetch endpoints related to beverages
Implement beverages in order page and in the order detail page

Trello Tickets

PIZ2

Testing

creating an order

order detail

beverage view

 PIZ2 - Add a beverage model, manager and service


Pandas is a required dependency for plotting with plotly

I did a fresh install of functime in a clean env and tried to run the following:
import polars as pl
from functime import plotting

def main():
    y = pl.scan_parquet(
        "https://github.com/descendant-ai/functime/raw/main/data/commodities.parquet"
    )

    plotting.plot_panel(y)

if __name__ == "__main__":
    main()

The following error is raised:
ImportError: Plotly express requires pandas to be installed.
Proposed solution
We should add pandas to the list of dependencies (duh). However, I would go a step forward and suggest to further break up the dependencies in optional groups. For example, one could install functime[plotting].
I think this could be a pretty big issue in terms of deployability for container size, etc. For example, in a production/inference setting, I believe one might not be interested in plotting capabilities.
A fresh functime install (including dependencies) is as much as 992MB in my venv. Pandas alone is 135MB (though numpy is a common dependency) which would make the whole "plotting" functions be as much as 293MB (just for plotly and pandas, though we would have to take out numpy that we might still be using under the hood for other things).
By comparison, a clean install of statsforecast (with dependencies) is just 637MB, statsforecasts + mlforecast is 680MB, while scikit-learn is 218MB (with dependencies) and polars alone is 93MB.
Let me know what you think :)

@topher-lo any thoughts about this?

Top priority


Draft: DS-2058: Task List component

When we make these PRs, can we link out to acceptance criteria or include it? It would be helpful to have screens/figmas/desc when reviewing.

When we make these PRs, can we link out to acceptance criteria or include it? It would be helpful to have screens/figmas/desc when reviewing.

There aren't any for this one due to it being developed before the specifications have been created.  It isn't in a state of being ready to go, mostly in a state of exploration.  We'll want to figure out how to handle this case, @matt-stjean, where the tech exploration of the design is handled should we need to develop something to get an idea how it works.

When we make these PRs, can we link out to acceptance criteria or include it? It would be helpful to have screens/figmas/desc when reviewing.

There aren't any for this one due to it being developed before the specifications have been created. It isn't in a state of being ready to go, mostly in a state of exploration. We'll want to figure out how to handle this case, @matt-stjean, where the tech exploration of the design is handled should we need to develop something to get an idea how it works.

Thanks for clarifying, I understand!


Replace dependency grpc_codegen with grpc in BUILD files     [p4info] Ignore metadata annotations in p4info verification. Temporary change to push p4info change without causing breakages, will be rolled back once cl/493441540 is submitted. Currently no other metadata annotations exist so should not effect any implementations.     Replace include path for files depending on files in gRPC's grpcpp/impl/codegen directory to their corresponding ones in non-codegen directories

Replace dependency grpc_codegen with grpc in BUILD files
[p4info] Ignore metadata annotations in p4info verification. Temporary change to push p4info change without causing breakages, will be rolled back once cl/493441540 is submitted. Currently no other metadata annotations exist so should not effect any implementations.
Replace include path for files depending on files in gRPC's grpcpp/impl/codegen directory to their corresponding ones in non-codegen directories

rkavitha@0c0d9cfbd72e:/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 236 targets (0 packages loaded, 0 targets configured).
INFO: Found 236 targets...
INFO: Elapsed time: 0.327s, Critical Path: 0.02s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
rkavitha@0c0d9cfbd72e:/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS ...
INFO: Analyzed 236 targets (0 packages loaded, 0 targets configured).
INFO: Found 152 targets and 84 test targets...
INFO: Elapsed time: 0.321s, Critical Path: 0.02s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//gutil:collections_test                                        (cached) PASSED in 0.2s
//gutil:io_test                                                 (cached) PASSED in 0.2s
//gutil:proto_matchers_test                                     (cached) PASSED in 0.3s
//gutil:proto_test                                              (cached) PASSED in 0.3s
//gutil:status_matchers_test                                    (cached) PASSED in 0.2s
//gutil:table_entry_key_test                                    (cached) PASSED in 0.0s
//p4_pdpi:ir_tools_test                                         (cached) PASSED in 0.4s
//p4_pdpi/netaddr:ipv4_address_and_network_address_test         (cached) PASSED in 0.2s
//p4_pdpi/netaddr:ipv6_address_test                             (cached) PASSED in 0.2s
//p4_pdpi/netaddr:mac_address_test                              (cached) PASSED in 0.2s
//p4_pdpi/packetlib:packetlib_fuzzer_test                       (cached) PASSED in 15.3s
//p4_pdpi/packetlib:packetlib_test                              (cached) PASSED in 0.1s
//p4_pdpi/packetlib:packetlib_test_runner                       (cached) PASSED in 0.0s
//p4_pdpi/packetlib:packetlib_unit_test                         (cached) PASSED in 1.3s
//p4_pdpi/string_encodings:bit_string_test                      (cached) PASSED in 0.2s
//p4_pdpi/string_encodings:byte_string_test                     (cached) PASSED in 0.2s
//p4_pdpi/string_encodings:decimal_string_test                  (cached) PASSED in 0.3s
//p4_pdpi/string_encodings:decimal_string_test_runner           (cached) PASSED in 0.0s
//p4_pdpi/string_encodings:hex_string_test                      (cached) PASSED in 0.2s
//p4_pdpi/string_encodings:hex_string_test_runner               (cached) PASSED in 0.0s
//p4_pdpi/string_encodings:readable_byte_string_test            (cached) PASSED in 0.3s
//p4_pdpi/testing:helper_function_test                          (cached) PASSED in 0.3s
//p4_pdpi/testing:info_test                                     (cached) PASSED in 0.1s
//p4_pdpi/testing:info_test_runner                              (cached) PASSED in 0.1s
//p4_pdpi/testing:main_pd_test                                  (cached) PASSED in 0.0s
//p4_pdpi/testing:mock_p4_runtime_server_test                   (cached) PASSED in 0.3s
//p4_pdpi/testing:packet_io_test                                (cached) PASSED in 0.1s
//p4_pdpi/testing:packet_io_test_runner                         (cached) PASSED in 0.0s
//p4_pdpi/testing:rpc_test                                      (cached) PASSED in 0.1s
//p4_pdpi/testing:rpc_test_runner                               (cached) PASSED in 0.0s
//p4_pdpi/testing:sequencing_test                               (cached) PASSED in 0.1s
//p4_pdpi/testing:sequencing_test_runner                        (cached) PASSED in 0.0s
//p4_pdpi/testing:table_entry_gunit_test                        (cached) PASSED in 0.4s
//p4_pdpi/testing:table_entry_test                              (cached) PASSED in 0.1s
//p4_pdpi/testing:table_entry_test_runner                       (cached) PASSED in 0.1s
//p4_pdpi/utils:annotation_parser_test                          (cached) PASSED in 0.2s
//p4_pdpi/utils:ir_test                                         (cached) PASSED in 0.3s
//p4rt_app/event_monitoring:app_state_db_port_table_event_test  (cached) PASSED in 0.5s
//p4rt_app/event_monitoring:config_db_node_cfg_table_event_test (cached) PASSED in 0.5s
//p4rt_app/event_monitoring:config_db_port_table_event_test     (cached) PASSED in 0.5s
//p4rt_app/event_monitoring:state_verification_events_test      (cached) PASSED in 0.5s
//p4rt_app/p4runtime:ir_translation_test                        (cached) PASSED in 0.4s
//p4rt_app/p4runtime:p4info_verification_schema_test            (cached) PASSED in 0.4s
//p4rt_app/p4runtime:p4info_verification_test                   (cached) PASSED in 0.6s
//p4rt_app/p4runtime:packetio_helpers_test                      (cached) PASSED in 0.4s
//p4rt_app/sonic:app_db_acl_def_table_manager_test              (cached) PASSED in 0.5s
//p4rt_app/sonic:app_db_manager_test                            (cached) PASSED in 0.4s
//p4rt_app/sonic:app_db_to_pdpi_ir_translator_test              (cached) PASSED in 0.4s
//p4rt_app/sonic:hashing_test                                   (cached) PASSED in 0.3s
//p4rt_app/sonic:packetio_impl_test                             (cached) PASSED in 0.3s
//p4rt_app/sonic:packetio_port_test                             (cached) PASSED in 0.3s
//p4rt_app/sonic:response_handler_test                          (cached) PASSED in 0.5s
//p4rt_app/sonic:state_verification_test                        (cached) PASSED in 0.2s
//p4rt_app/sonic:vrf_entry_translation_test                     (cached) PASSED in 0.4s
//p4rt_app/sonic/adapters:fake_sonic_db_table_test              (cached) PASSED in 0.1s
//p4rt_app/tests:acl_table_test                                 (cached) PASSED in 0.7s
//p4rt_app/tests:action_set_test                                (cached) PASSED in 0.6s
//p4rt_app/tests:api_access_test                                (cached) PASSED in 0.5s
//p4rt_app/tests:arbitration_test                               (cached) PASSED in 0.6s
//p4rt_app/tests:fixed_l3_tables_test                           (cached) PASSED in 1.6s
//p4rt_app/tests:forwarding_pipeline_config_test                (cached) PASSED in 2.0s
//p4rt_app/tests:grpc_behavior_test                             (cached) PASSED in 5.0s
//p4rt_app/tests:hashing_test                                   (cached) PASSED in 0.5s
//p4rt_app/tests:p4_constraints_test                            (cached) PASSED in 0.3s
//p4rt_app/tests:p4_constraints_test_runner                     (cached) PASSED in 0.1s
//p4rt_app/tests:p4_programs_test                               (cached) PASSED in 0.8s
//p4rt_app/tests:packetio_test                                  (cached) PASSED in 2.9s
//p4rt_app/tests:port_name_and_id_test                          (cached) PASSED in 0.7s
//p4rt_app/tests:response_path_test                             (cached) PASSED in 1.4s
//p4rt_app/tests:role_test                                      (cached) PASSED in 0.6s
//p4rt_app/tests:state_verification_test                        (cached) PASSED in 0.7s
//p4rt_app/tests/lib:app_db_entry_builder_test                  (cached) PASSED in 0.0s
//p4rt_app/utils:event_data_tracker_test                        (cached) PASSED in 0.0s
//p4rt_app/utils:table_utility_test                             (cached) PASSED in 0.4s
//sai_p4/instantiations/google:clos_stage_test                  (cached) PASSED in 0.2s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test (cached) PASSED in 0.0s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test (cached) PASSED in 0.0s
//sai_p4/instantiations/google:sai_p4info_fetcher_test          (cached) PASSED in 0.3s
//sai_p4/instantiations/google:sai_p4info_test                  (cached) PASSED in 0.5s
//sai_p4/instantiations/google:sai_pd_proto_test                (cached) PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test                 (cached) PASSED in 0.3s
//sai_p4/instantiations/google:union_p4info_up_to_date_test     (cached) PASSED in 0.0s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test       (cached) PASSED in 0.1s
//sai_p4/tools:p4info_tools_test                                (cached) PASSED in 0.5s
Executed 0 out of 84 tests: 84 tests pass.
There were tests whose specified size is too big. Use the --test_verbose_timeout_waINFO: Build completed successfully, 1 total action

@kishanps, Could you please review.
Thanks.


Investigate cause of bloated OpenAPI document when containment nav. props are expanded

The generated OpenAPI document gets massively bloated when containment navigation properties are expanded. This is especially the case for the beta endpoint. Currently the beta version is @ >600MB.
AB#9344

Closed by: https://github.com/microsoftgraph/msgraph-metadata/pull/77 and https://github.com/microsoft/OpenAPI.NET.OData/pull/94


more tenant endpoints

add tenant to user
remove tenant from user

Issue moved to chef/platform-auth #135 via ZenHub


Limit low exon plots in report

Reports with a lot of low exon plots don't load as it is too much data, need to find an upper limit at which to not generate these plots to keep the reports usable. This only happens with big panels / poor data, also needs doing as samples where there are 100/1000+ exons <100% takes ages to generate plots and app will probably time out.
Maybe also add an optional --brief arg or something to not generate any plots and keep reports small, again only if feeling fancy

also for images added specified width & height values to all images should help speed up loading

move JS out of plotly plots into separate JS file at bottom of html to speed up loading

https://datatables.net/forums/discussion/55484/weird-behavior-with-plotly-chart
http://live.datatables.net/zivuhice/2/edit


[Map] "LOIs with data" label incorrect on new LOIs

After adding an LOI and submitted data, map shows "0/1" for "LOIs with data" vs "total LOIs" in the specified area.
Expected: The label should say "1/1"

This only occurs when working online, so it's likely being caused by https://github.com/google/ground-platform/issues/1961. Fixing upstream.

Fixed!


Got an error when running "make run-ui"

Hi, thanks for this great work. I got an error when I tried to run make run-ui using paperspace. Does anyone happen to know the solution to this issue? Thank you.
ImportError: cannot import name 'MultiHostDsn' from 'pydantic.networks' (/usr/local/lib/python3.9/dist-packages/pydantic/networks.cpython-39-x86_64-linux-gnu.so)
make: *** [Makefile:59: run-cli] Error 1

same error :(

I fixed it by pip install pydantic==2.0.2, pip install protobuf==3.20.0 and delete theme=gr.themes.Soft() in infer-web.py. But do you know how to open port 3000 on paperspace? Thanks.

thank you, it worked!
now im having some problems due to ffmpeg lol

You're welcome. Running make basev1 or make basev2 may help you set up ffmpeg environment.

unfortunately not, i dunno maybe i have to open another issue tab


Problem switching languages

If I change from Dutch to English by clicking on the flag (while in the search page), the language automatically switches back to Dutch after a few seconds.

Hm. Can't reproduce this on my other computer. Will test some more.

Hmm, weird. The language should only switch automatically from A to B in this particular situation:

You are logged in, and are using language B. This is saved in your user profile as 'last used language'.
You are logged out (later, on another device, or both), and are using language A.
You log in again.

Hm. Can't reproduce this anymore (before I could on just one machine in Safari). Will put this to sleep for now.

I can reproduce the above in Chrome on Win7 and Win8.1 (my default language is Dutch; when I click English, page reloads twice: first in English, then back to Dutch).
In FF and IE11, however, nothing happens when I click the English flag. Page reloads once (i think), but remains in Dutch.

I tried this with our account, I can't change the language on Search page.
FireFox 38.2.1 and Red Hat Enterprise linux.

Happens again to me now (Mac/Safari). Stored language is en; when I log in and change the language to Dutch on the search page, it reloads in English. I tried what happens if I change the stored language to nl in Django admin, but then I got to the error described in issue #86 ...

I have made a discovery regarding this issue: it can be replicated by commenting out the request to dictionary/switch_to_language/, which is made when you click this flag while logged in to save the language in your user profile.
This then happens:

The website switches language, but this is not saved in the user profile
The website reloads to show the new language
Some Javascript added by me notices the discrepancy between the user profile and the current language, and fixes that.

In other words, it looks like your request to save the user preference is failing. This means you shouldn't have any problems when not logged in.
Furthermore, you guys note things not working in FF and IE at all, which I can reproduce. I suspect it never worked there, which is a separate issue. I'll make a another issue page for it.

I think I fixed it in f2bed59fce8b6d3c2605e48bb41e9a2d629d9c8c . After I fixed the Firefox problem, I could reproduce the problem there. What happened was that the language switch was so fast that Firefox could not save the user preference, which caused the behavior I described above. The solution was to add a small delay.
I think this will solve your problems as well, but I'm not fully sure of course.

I tested it quickly. Language switching works on static pages, but not directly on the search page.

Thanks, good find; it's fixed now. The problem wasn't static pages, but all pages that had another url than signbank.science.ru.nl (except for some corner cases). This was because the code to switch language added some thinks to the current url, so that if you were on http://signbank.science.ru.nl/dictionary/gloss/3117/ you would go to http://signbank.science.ru.nl/dictionary/gloss/3117/switch_to_language, which of course didn't work.


(fixes 4 issues) Ordinal indicators to Spanish and Portuguese, Shift key in the italian keyboard, and simplified QWERTZ keyboard for Czech.

This should:
*close a minor issue that's listed twice in your bug tracker: #143, #287.
*fix the size and position of the Shift key in the italian keyboard (#278).
Also, please close #144; it was already fixed.

I also bundled a quick fix for #267, hoping that an actual Czech speaker will correct it if necessary.
F-Droid hasn't seen updates for Czech since last year (#266), could you look into it?

wonderful!
Thank you.


pythonPackages.sslib: init at 0.2.0

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build pythonPackages.sslib python3Packages.sslib

Success on x86_64-darwin (full log)
Attempted: python3Packages.sslib
The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.sslib
Partial log (click to expand)
writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/7s2z64qbarip13ikzyqmncn73w74m8w2-python3.6-sslib-0.2.0

Success on x86_64-linux (full log)
Attempted: python3Packages.sslib
The following builds were skipped because they don't evaluate on x86_64-linux: pythonPackages.sslib
Partial log (click to expand)
writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/9whh2yh56cgd44cx61j8052m7qqrabxq-python3.6-sslib-0.2.0

Success on aarch64-linux (full log)
Attempted: python3Packages.sslib
The following builds were skipped because they don't evaluate on aarch64-linux: pythonPackages.sslib
Partial log (click to expand)
writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/25jdx7ijygrmfyk5cajdp2j8r3mdv13f-python3.6-sslib-0.2.0

@GrahamcOfBorg build python3Packages.sslib

Success on aarch64-linux (full log)
Attempted: python3Packages.sslib
Partial log (click to expand)
writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ly3qlizgvsw361szifaq2ckqjq8f7idp-python3.6-sslib-0.2.0

Success on x86_64-darwin (full log)
Attempted: python3Packages.sslib
Partial log (click to expand)
writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/6q1wbc49rgzhz1clsyyabw19xys6arcm-python3.6-sslib-0.2.0

Success on x86_64-linux (full log)
Attempted: python3Packages.sslib
Partial log (click to expand)
writing top-level names to sslib.egg-info/top_level.txt
reading manifest file 'sslib.egg-info/SOURCES.txt'
writing manifest file 'sslib.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/vx862jkr276vz5hb4p8cckd7rplwxfln-python3.6-sslib-0.2.0

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase or - if there are no tests - set doCheck = false and add a comment with the reason.

Ran 0 tests in 0.000s

Please provide an appropriate checkPhase or - if there are no tests - set doCheck = false and add a comment with the reason.

Fixed, thanks.


Is there any way to call bower.commands.install() using the same interface as bower install?

I've managed to mimic the same behavior of bower install using bower.commands.install() plus a few event handlers for prompt and log. But it took me some work to get it done (mostly for the conflicts resolution possibility). I was wondering if there was any way to call bower.commands.install() the same way bower install works, so I don't have to re-create what bower already have.

Probably you can use something like bower.commands.install.line(['angular', 'jquery', '--save']).
Feel free to send PR documenting it on bower.io.


Pass currentState to filter.apply()

see https://github.com/pixijs/pixi.js/issues/3317
If  pass currentState to filter.apply() , users could get more informations  (e.g. get current sprite by currentSprite = currentState.target).
It's very useful when users create custom filters.
And the currentState is the last argument , and pass it won't break any filter already existed.
So I think this PR is safe and useful.

I've add the parameter  in apply of Filter.js , but eslint failed. because it doesn't be used.

@GoodBoyDigital   ,  I've updated apply function parameters on the Filter class .
Review please.

@GoodBoyDigital any follow-up here?
@finscn could you resolve conflicts?

@GoodBoyDigital , I've updated apply function parameters on the Filter class .
Review please.  Is there any other problem ?

Is there any news about this PR ?

Don't forget this PR ,please.
@GoodBoyDigital  , you  requested changes , I've changed.

lg2m, @GoodBoyDigital good to you?

@GoodBoyDigital  , is there any question about this PR ?