LAMMPS parsing failure

Data: https://nomad-lab.eu/prod/v1/gui/user/uploads/upload/id/3r7neW3GSU63WbJGYfZhuw
Failed to parse 2 output files, and did not recognise the trajectory.

Hey @JFRudzinski, can you have a look at this?
Would reprocessing in staging work?
Some screenshots in this Twitter thread just in case it provides more info: https://twitter.com/fxcoudert/status/1680665798703030272?s=20

@fxcoudert I am sorry for the VERY long delay in getting to this issue!!
I am trying to dedicate some time now to improving the Lammps parser. If you wouldn't mind sharing your data that failed to parse with me, it would be very helpful. If the above-mentioned upload exist, you can give me access by adding me as a reviewer via the "manage upload members" button (icon looks like 2 people) on the upload page in NOMAD.

You are now added as reviewer for this upload:

@fxcoudert excellent, thank you very much!

This issue appears to be linked to #37 , will confirm after solving that one

Update: The major processing issues here have now been solved. This had to do with:

Not recognizing the data file
Nan calculated for mass fraction for systems without recognized atoms

Once these changes go through, the system and method data will be properly parsed. However, overall workflow within this example is not recognized (i.e., multiple MD runs). This corresponds to a bigger extension of Lammps support needed. I have opened an issue for this #89 if anyone would like to follow the progress


No config.json found in directory ./pretrained_weights/sd-image-variations-diffusers

OSError: Error no file named config.json found in directory ./pretrained_weights/sd-image-variations-diffusers.
There is no "config.json" on the project website https://huggingface.co/lambdalabs/sd-image-variations-diffusers/tree/main. How may i resolve this issue？
Thanks

Pls double check your configuration

i have a problem too
how to solve this

use the latest version of EchoMimicV2

On the evening of November 26th at 22:00, I downloaded the latest version of the code and tested it. However, there was still an error message indicating “no file named config. json”，but I am aware that config. json is just a simple configuration file, so I copied model_index. json from the sd image variations diffusers directory and renamed it  config.json, and the program ran normally


Update README.md Fix Typo (hellom -> hello)

Fix Typo,
Earlier : "hellom world"
Now  : "hello world"

Closing as duplicate.


Fixes required in new insights

[x]  @ionuiux please update the design for the  "Low Usage" and "Slow Endpoint" it does not look good currently

[x]  Decrease main values font size to 12 (already updated in design system)

[ ]  Check toolbar button sizes @ionuiux ?
[x]  The first button from the right should always be a primary (text and icon), in all insights
[x]  Cards are too far apart, please make margin a little smaller

[x] Fix the insights page background color, it is a bit brighter than the design in the mockup. @ionuiux  please provide details.

[x] Endpoint dropdown should open when clicking on an empty area, not just on the caret

[x] Adjust Jira ticket hint to the new design  @ionuiux

Related to #681


don't attempt to export zpool if there is none

Currently, /mnt will be unmounted and pools will be exported if zpool is in the PATH. However, that doesn't mean there are actually pools to export.
Partial fix for https://github.com/nix-community/nixos-anywhere/issues/278

@mergify queue


fs_usage reveals Code Helper is working on files outside currently opened projects

I'm on OSX Mojave, using very latest VSCode, my kernel_task was going nuts so I ran this command to see what the hell was going on
sudo fs_usage | grep -v 0.0000

This showed me that Code Helper was running HFS_update, RdChunkCS and RdMeta[S] on a ton of files that are completely outside my currently opened projects.. There are no symlinks that could be linking them together either.
Let me know what other info I can provide to debug this problem

Can you elaborate a little on what files outside the projects are being accessed? I can't seem to repro, also would sudo fs_usage | grep Code be a better command to check this?

I disabled the intelephense extension which has been causing me so many problems with making Code Helper make my cpu melt down. I also upgraded a bunch of other brew components and ran a SMC and pram reset.. the problem has stopped now thank god.. unfortunately I don't know which of these things have fixed the problem. I'll probably try to re-enable intelephense since it's so useful.. if the problem starts again I'll re-open the issue.

Yes please let us know if it happens again 🙂


Add fixtures, examples, and util to Codecov ignore list

We probably don't care about covering code in these directories, so exclude them from test coverage.

Could you add src/hpack/test?


example usage of useTranslation inside generateMetadata

What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:
Added example usage of useTranslation inside generateMetadata in the app router example.
What changes did you make? (Give an overview)
Added a single new translation to each of the locales in the example and added generateMetadata in the second page with usage of useTranslation.
Which issue (if any) does this pull request address?
Makes the app router example a bit more comprehensive.
Is there anything you'd like reviewers to focus on?
None

@all-contributors please add @huseyinonalcom for code


add Profile flag --profile

instead of passing in credentials as ENV, now sre can use --profile to run the verifier.
related jira card: https://issues.redhat.com/browse/OSD-11580
How to test:
run 'make build'
./osd-network-verifier egress --profile $your-profile --subnet-id $your-subnet --region  $region

Codecov Report

Merging #106 (d449606) into main (a4b2576) will decrease coverage by 1.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   26.39%   25.28%   -1.12%
==========================================
  Files          17       17
  Lines         682      712      +30
==========================================
  Hits          180      180
- Misses        477      507      +30
  Partials       25       25

Impacted Files
Coverage Δ

cmd/egress/cmd.go
0.00% <0.00%> (ø)

pkg/cloudclient/aws/aws.go
0.00% <0.00%> (ø)

pkg/cloudclient/aws/private.go
43.03% <0.00%> (-3.33%)
:arrow_down:

pkg/cloudclient/cloudclient.go
0.00% <0.00%> (ø)

I'm not sure how to suggest edit in the PR so I made a small PR to show my suggestion https://github.com/lnguyen1401/osd-network-verifier/pull/8
No major difference, I'm re-using existing newClient function

I'm not sure how to suggest edit in the PR so I made a small PR to show my suggestion lnguyen1401#8 No major difference, I'm re-using existing newClient function

To simplify, closed this PR and made an independent one https://github.com/openshift/osd-network-verifier/pull/107

closing since this PR has been incorporated into https://github.com/openshift/osd-network-verifier/pull/107


Add FieldMap support to TextFormatter

Use the same FieldMap class used by JSONFormatter for TextFormatter.  Needed to keep LogDNA's parser happy.

@sirupsen any thoughts on this?  I hacked this up ages ago, but am happy to revise or rebase if changes are needed, as long as someone is willing to accept it.

@neilisaac it mostly looks good to me, but can you merge from master in order to retrieve the new prefixFieldClashes signature and gives as parameter the configured FieldMap. It would alos be nice to have an associated unit test to check potentially clashing field are appropriatly prefixed.

@dgsb it looks like it wasn't quite right to begin with, so this PR now includes a bug fix.


Panic when failing to write WAL file

This fixed #9923
Describe your proposed changes here.

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[ ] Well-formatted commit messages
[ ] Rebased/mergeable
[ ] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[ ] Documentation updated or issue created (provide link to issue/pr)
[ ] Signed CLA (if not already signed)

If I understand from your issue, the problem is that even if the underlying error is ephemeral, the segment can get left in a bad state where it can't be appended to. Is that right?

yes, and this is silent failure

If so, then a better way to handle this unrecoverable error would be to truncate the segment to the point we can write to it again.

After restart it will truncate the bad WAL entry.
Otherwise it looks complicated to recover: it could be partial write and we may have to rescan the whole segment file.
Basically the panic is not only for recovering, but also to avoid silent failure and escalate the problem so an administrator can be alerted.


Search bar

Description
In search bar page search bar only search username with small letter and also on that page necessary vertical line is appear  .
I would like to fix that bug.
Steps to reproduce
Steps

Write function to search capital or small letter start username
Test the function.

Screenshots

No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Sure, you can go ahead!

@narayan954 i'm already working on the similar issue #755

@narayan954 i'm already working on the similar issue #755

ohhh alright, apologies, will correct.

Description
In search bar page search bar only search username with small letter and also on that page necessary vertical line is appear  .
I would like to fix that bug.
Steps to reproduce
Steps

Write function to search capital or small letter start username
Test the function.

Screenshots

No response
Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Hi @BhartiNagpure this is duplicate issue actually, will have to close ;-;


Confusing

The sensitivity slider allows you to impact the algorithm and define how strict the detection logic is. The higher the sensitivity level, the lower the suppression that is applied as part of the detection logic.
The above lines are super confusing.  Maybe add in some examples.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 395e085f-93bd-1f3c-fe0d-7711b6d51950
Version Independent ID: ad86d15d-41a5-9a6e-8d30-18ed9a9975f2
Content: Create anomaly detection policies in Cloud App Security
Content Source: CloudAppSecurityDocs/anomaly-detection-policy.md
Service: cloud-app-security
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

Thanks for your comment. We'll investigate and get back to you.

@SquirrelAssassin - Thanks again for your comment. I've updated the sentence you mentioned with a link to examples, and I've rephrased the sentence for clarity.

If all tickets are starting to be auto closed ... your defeating the whole purpose of this system.  Nothing will get done, no one will follow up.  Please don't close tickets before completing the task.

I'm sorry you experienced it that way. I wrote above that in response to your comment, I rephrased the sentence and provided links to examples. It wasn't autoclosed - I closed it after performing your requests.
What is incomplete?

Its not done until its 100% done.  Closing a item defers responsibility.

Ok, I'm sorry I closed the issue too quickly. I've reopened it.
Please let me know what questions you have on the modified document.


Add presence colors to persona card

The persona card styles seem to only support the available status, while the persona control supports busy, offline, dnd, away, etc.. I added these form looking at the persona control and matching the less variables. Please verify these are correct and I've added them to the right place.
Here's a codepen of these changes in action (explicit HEX colors replaced the variables):
http://codepen.io/andrewconnell/pen/NGRvxW

Hi @andrewconnell, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Hey Andrew, thanks for looking into this. After reviewing the component and your codepen it looks like the way we're handling presence in the persona control can also be applied to the persona within the persona card.
Since .ms-Persona can take a modifier to indicate presence (e.g. .ms-Persona--busy), we can actually apply that modifier directly to the .ms-Persona within the persona card as a method to indicate presence.
Check out this codepen: http://codepen.io/anon/pen/yYVYoW
Also, it looks like your persona card markup and styles are a little out of date. There were several updates made that are currently on master and should be available soon in the next release as well.
Thanks again!

Ah… that makes sense… better to reuse the persona ones for presence. I’ll close this PR out.
The codepen’s I’m creating are for v1.0… When you guys ship a new version, I’ll tweak them for 1.1. Lots of changes since 1.0 that I haven’t incorporated (like the date picker).


Installing local packages is indeterminate if you have multiple packages of the same version in the install dir

Say you have opscode-reporting_1.0.0.deb and opscode-reporting_1.0.1.debin a directory /tmp.
When running the local install command:
chef-server-ctl install opscode-reporting --path /tmp

it is indeterminate which will be installed. I think it just picks the first one it finds that matches the package regex.
We should probably have --path point to the actual package file, such as --path /tmp/opscode-reporting_1.0.1.deb instead of --path /tmp so we know which package is being used.

This is being worked on here: https://github.com/chef/chef-server/pull/173

Opened pull request #340 with the code for this

Fixed by @alexpop in #340


[Bug]: sumatrapdf  download link is invalid or expired.

Prerequisites

[X] I have written a descriptive issue title.
[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.
[X] I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name
sumatrapdf
Expected/Current Behaviour
The file download link is invalid or expired.
Steps to Reproduce
➜ scoop install sumatrapdf
Installing 'sumatrapdf' (3.4.6) [64bit] from extras bucket
The SSL connection could not be established, see inner exception.
URL https://files.sumatrapdfreader.org/file/kjk-files/software/sumatrapdf/rel/3.4.6/SumatraPDF-3.4.6-64.zip is not valid

Possible Solution
update to latest download url, I try and it work
https://files.sumatrapdfreader.org/file/kjk-files/software/sumatrapdf/rel/3.4.6/SumatraPDF-3.4.6-64.zip -->
https://www.sumatrapdfreader.org/dl/rel/3.5.2/SumatraPDF-3.5.2-64.zip
Scoop and Buckets Version
Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
b8b8f0d57 (HEAD -> master, origin/master, origin/HEAD) streamlabs-obs: Update to version 1.15.1

'main' bucket:
497c914a4 (HEAD -> master, origin/master, origin/HEAD) terragrunt: Update to version 0.53.4

Scoop Config
last_update   : 2023/11/17 9:34:23
aria2-enabled : False
alias         :
scoop_branch  : master
scoop_repo    : https://github.com/ScoopInstaller/Scoop

PowerShell Version
PSVersion                      7.3.9
PSEdition                      Core
GitCommitId                    7.3.9
OS                             Microsoft Windows 10.0.19044
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Additional Softwares
No response

#12251


next-condition not working in first step

im trying to validate some fields in step1 before go to step2. So im using next-condition for this but it's not trigger on step1 and it's working fine on step2.
i used this plnkr example http://embed.plnkr.co/azYKSAYOMv0pZu8YEWVs for my project.

I'd have to see your actual code to know what might be going wrong. Can you post a reproduction of the issue?

I'm seeing the same result. if you take your example
i used this plnkr example http://embed.plnkr.co/azYKSAYOMv0pZu8YEWVs for my project.
and remove the first "ion-slide-page"
and change the second slide to only have the "Next-condition".

if you edit the input and then remove the text the conditions start to work. if you click next without editing the input it works on all pages.


Grafana Dashboard

Could you also share your Grafana Dashboard as in the example screenshot?
thanks

Could you also share your Grafana Dashboard as in the example screenshot?
thanks

I agree !


takeEvery/takeLatest are not catching *_SUCCESS or *_FAIL actions

For some reason when i have an action like USER/LOGIN, i can't do anything like
yield takeEvery('USER/LOGIN_SUCCESS', mySaga);

However,
yield takeEvery('USER/LOGIN', mySaga);

in my saga works just fine, but obviously at the moment request is dispatched, not successfully finished.
I've added a monitoring reducer and USER/LOGIN_SUCCESS is indeed dispatched, but takeEvery doesn't seem to care. Any ideas why?

My best guess is that you have your middleware out of order.

Yes, you're right. After i've placed my sagaMiddleware after axiosMiddleware every *_SUCCESS and *_FAIL action started to catch up with takeEvery/takeLast as any other action.
Thank you, i'd never would thought that order of middlewares matters!

Not a problem,  glad I could help.


OrbitControls.zoomToCursor missing

three version: 0.156.1
@types/three version: 0.156.0
three-stdlib version: 2.51.1

Problem description:
Three.js documentation mentions a zoomToCursor prop for OrbitControls but I can't use it with @react-three/drei because three-stdlib's OrbitControls doesn't support it.
https://threejs.org/docs/?q=zoomToCursor#examples/en/controls/OrbitControls.zoomToCursor
Suggested solution:
Update OrbitControls on three-stdlib.

https://github.com/mrdoob/three.js/pull/26165, https://github.com/mrdoob/three.js/pull/26549


skip to replace link text if it is a link

Fixed Issues
$ https://github.com/Expensify/App/issues/16475#issuecomment-1492798632
Tests

Go to a chat and add a new comment, like test
Edit the comment to replace it with the following link and save it

https://www.facebook.com/hashtag/__main/?__eep__=6

Verify the link text and url are same as the original link
Edit the link to remove the link by replacing the link markdown the following original link and save it

https://www.facebook.com/hashtag/__main/?__eep__=6

Verify the link is not autolinked and displayed as text https://www.facebook.com/hashtag/__main/?__eep__=6

https://user-images.githubusercontent.com/117511920/232011057-cec36463-f327-4a1e-8b35-a097e3ef889e.mov
QA
Same as Tests

@fedirjh please review, GH is not showing me the option to assign you as a reviewer. Thanks!

@marcaaron over to you for re-review 😄


Do an accessibility audit

Check if the elements are properly accessible in VoiceOver and improve if needed.

I've completed an audit. I'm not finding much!
I did notice the text view is behaving in a funky fashion. Tapping it to focus it, it only reads the line of text that you tapped, rather than the entire text view content. Comparing that to Messages, when you tap in the the text view, it reads the entire contents. Note that when you don't tap in the text view but rather swipe between elements, it properly highlights the entire text view and reads it all.
The attachment button doesn't do anything, but it also doesn't do anything when not using VO.

That is an awesome audit, thanks @hipwelljo! Also, I think we can and should look into fixing all of the points you mentioned.
Is this something you want to take a look at? Maybe create separate issues for all of the points?

I'll go ahead and create separate issues. I'm not sure how exactly to solve them atm though, and likely won't have time to look into it unfortunately.

Don’t worry! Thanks so much for reporting. Closing this in favor of the more granular tickets.
Sent with GitHawk


AMP-63782 GraphQL Taxonomy API 2.0 fixed draft state callout

Amplitude Developer Docs PR
Description
AMP-63782 GraphQL Taxonomy API 2.0 fixed draft state callout
Change type

[X] Doc bug fix. Fixes AMP-63782
[ ] Doc update.
[ ] New documentation.
[ ] Non-documentation related fix or update.

PR checklist:

[X] My documentation follows the style guidelines of this project.
[X] I previewed my documentation on a local server using mkdocs serve.
[X] Running mkdocs serve didn't generate any failures.
[X] I have performed a self-review of my own documentation.

@amplitude-dev-docs
@caseyamp

shouldn't these docs be under docs/data?

shouldn't these docs be under docs/data?
yep, noted, we can move it when we finalize the doc and make it public (available in nav and search)


Config for HelixAccountService.

Currently configs in for HelixAccountService is in HelixPropertyStoreConfig, because both HelixNotifier and HelixAccountService are using these configs. However, this makes some other configs that solely belong to HelixAccountService also be placed in HelixPropertyStoreConfig, such as shutdownTimeout for shutting down HelixAccountService. This ticket proposes to move HelixAccountService-related configs to HelixAccountServiceConfig.

Fixed by #818


increase bottom margin to make global options visible

So you can see the global options again
[#118730175]

Please include the reverted 98cad2ffc6fd29996e5faa680a7ba50394bce8a0.

@dkoper cherry-picked that commit onto this branch and pushed again. should contain both changes now.


fanficfare: 2.22.0 -> 2.23.0

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
ran /nix/store/3f3695k3x1y2jnq4l62rifazm9hkrwri-fanficfare-2.23.0/bin/.fanficfare-wrapped -h got 0 exit code
ran /nix/store/3f3695k3x1y2jnq4l62rifazm9hkrwri-fanficfare-2.23.0/bin/.fanficfare-wrapped --help got 0 exit code
ran /nix/store/3f3695k3x1y2jnq4l62rifazm9hkrwri-fanficfare-2.23.0/bin/.fanficfare-wrapped -v and found version 2.23.0
ran /nix/store/3f3695k3x1y2jnq4l62rifazm9hkrwri-fanficfare-2.23.0/bin/.fanficfare-wrapped --version and found version 2.23.0
ran /nix/store/3f3695k3x1y2jnq4l62rifazm9hkrwri-fanficfare-2.23.0/bin/fanficfare -h got 0 exit code
ran /nix/store/3f3695k3x1y2jnq4l62rifazm9hkrwri-fanficfare-2.23.0/bin/fanficfare --help got 0 exit code
ran /nix/store/3f3695k3x1y2jnq4l62rifazm9hkrwri-fanficfare-2.23.0/bin/fanficfare -v and found version 2.23.0
ran /nix/store/3f3695k3x1y2jnq4l62rifazm9hkrwri-fanficfare-2.23.0/bin/fanficfare --version and found version 2.23.0
found 2.23.0 with grep in /nix/store/3f3695k3x1y2jnq4l62rifazm9hkrwri-fanficfare-2.23.0
found 2.23.0 in filename of file in /nix/store/3f3695k3x1y2jnq4l62rifazm9hkrwri-fanficfare-2.23.0

cc @lucas8 for review

Success on x86_64-linux (full log)
Attempted: fanficfare
Partial log (click to expand)
writing entry points to FanFicFare.egg-info/entry_points.txt
reading manifest file 'FanFicFare.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'FanFicFare.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

Success on aarch64-linux (full log)
Attempted: fanficfare
Partial log (click to expand)
reading manifest file 'FanFicFare.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'FanFicFare.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/mxxsvljasqp9m4i1m9m5j8ibyyjm1psg-fanficfare-2.23.0

No attempt on x86_64-darwin
The following builds were skipped because they don't evaluate on x86_64-darwin: fanficfare
No log is available.

LGTM


Cleanup CircleCI config

Some minor cleanup

Fixed indentation
Changed job naming to circleci convention (as seen in the docs)

Thanks for the review!
I agree with the indentation issue, especially if its already consistent across all the other repos, lets stick to this.
Regarding naming, dashes would be nice, but is not critical by any means, plus camel-case is used in the other repos too, I would be fine with it. I am thinking of revoking this PR, WDYT?

Up to you, naming with dashes is ok but requires changes, if you think they are worth the effort go ahead! :)

Think it's fine this way. No need to tinker around in other repos


PoC: Kubernetes upgrade

PoC for #703

[x] Why the volumes are detaching during the upgrade?
[ ] Figure out possible ways to keep volume attached (or reattached) and still usable by the workload after Kubernetes upgrade.

After Kubernetes upgrade, the containers of instance manager pods will be restarted and all engine/replica processes info will be lost. Then attached volumes will become error status and be detached automatically.

We can know the restart by checking the event message of the instance manager pods:
Container engine-manager definition changed, will be restarted
This behavior is already informed by the Kubernetes doc
Why the pod definition suddenly gets changed? It's a Kubernetes bug: Once Kubernetes adds new fields for the pod container, the existing container definition/spec will be considered as changed. This issue is fixed in the version v1.16, see this PR for details.

Maybe there is something we can do for 3.2.2.
In the worst-case scenario, we can remount to RW on the node manually
sudo mount -o remount,rw <disk> <mountpoint>

We should be able to find the mount point through the mount command

The uninstallation blocking issue occasionally happens in the docker/node reboot tests, too. This issue maybe not caused by the Kubernetes upgrade. We can check it after fixing the issue mentioned #743 (wrong owner reference).

We need to verify the above remount works if we incorporate the logic.

Tried a bit POC:

remount doesn't work. It's probably because we've changed the major:minor number of the device after reattaching it, so it's essentially a new device, even though the /dev/longhorn/xxx is the same.
But run mount again works, as it put another layer of the mount on top of the original mount path. Though it will result in the mount point become multiple layers. We would need to run umount multiple times until there is no reference to the device when we executing the umount, e.g. from CSI plugin.
It's very risky to run umount then mount again. During the process of the pod restarting, it might accidentally bind-mount the host path between the gap of umount and mount instead of the real device. That would result in pod writing data to the host path.
The pod needs to restart to pick up the new mount since it was bind-mounted to the previous layer of the mount point. Fortunately, the pod should restart by itself if the liveness probe was configured correctly.

We don't need to worry about the multi-layer unmount. The current CSI plugin will check the mount point after unmount. If the mount point still exists, NodeUnpublishVolume() will error out and be re-invoked later:
time="2019-10-25T20:06:13Z" level=info msg="NodeServer NodeUnpublishVolume req: volume_id:\"pvc-20f43f8d-f762-11e9-a0a8-f23c9226dc9d\" target_path:\"/var/lib/kubelet/pods/20f5a635-f762-11e9-a0a8-f23c9226dc9d/volumes/kubernetes.io~csi/pvc-20f43f8d-f762-11e9-a0a8-f23c9226dc9d/mount\" "
ERROR: logging before flag.Parse: E1025 20:06:13.028086       1 utils.go:100] GRPC error: rpc error: code = Internal desc = Failed to unmount path /var/lib/kubelet/pods/20f5a635-f762-11e9-a0a8-f23c9226dc9d/volumes/kubernetes.io~csi/pvc-20f43f8d-f762-11e9-a0a8-f23c9226dc9d/mount
time="2019-10-25T20:06:13Z" level=info msg="NodeServer NodeUnpublishVolume req: volume_id:\"pvc-20f43f8d-f762-11e9-a0a8-f23c9226dc9d\" target_path:\"/var/lib/kubelet/pods/20f5a635-f762-11e9-a0a8-f23c9226dc9d/volumes/kubernetes.io~csi/pvc-20f43f8d-f762-11e9-a0a8-f23c9226dc9d/mount\" "
ERROR: logging before flag.Parse: E1025 20:06:13.641736       1 utils.go:100] GRPC error: rpc error: code = Internal desc = Failed to unmount path /var/lib/kubelet/pods/20f5a635-f762-11e9-a0a8-f23c9226dc9d/volumes/kubernetes.io~csi/pvc-20f43f8d-f762-11e9-a0a8-f23c9226dc9d/mount
time="2019-10-25T20:06:14Z" level=info msg="NodeServer NodeUnpublishVolume req: volume_id:\"pvc-20f43f8d-f762-11e9-a0a8-f23c9226dc9d\" target_path:\"/var/lib/kubelet/pods/20f5a635-f762-11e9-a0a8-f23c9226dc9d/volumes/kubernetes.io~csi/pvc-20f43f8d-f762-11e9-a0a8-f23c9226dc9d/mount\" "
time="2019-10-25T20:06:14Z" level=debug msg="NodeUnpublishVolume: done pvc-20f43f8d-f762-11e9-a0a8-f23c9226dc9d"

@shuo-wu I think it's better if we can handle it gracefully. Each error out would cause a backoff. If there are too many layers, it may take a few minutes to unmount them all.
Also, we should try to see how many layers can we put on one mount point.

Verified.


Improve grammar: "create" -> "have created"

Changed to present perfect tense ("have created") to accurately reflect the recent completion of the action.

@all-contributors please add @roudra323  for contributing in improving document grammar.

@all-contributors please add @roudra323 for contributing doc


add more normalized handler for aggregating urls

Add Thor and Pym services into mapping table and more normalized url patterns.

Maybe we can transfer ownership to drmobile org if we need to maintain this repo? @jonascheng

OK to transfer ownership to drmobile org, thanks!


Add capability to send event from base-message-center element

The BaseMessageCenterBehavior implementation for the base-message-center custom element does not provide a sendEvent function. It would be useful to be able to send events to the server-side message-center from the client.

The bits-socket.io-client has the ability to send events. However, the polymer behavior does not implement it. This can easily be done in your own component though.
See https://github.com/LGSInnovations/node-bits-socket.io-client/blob/master/index.js


Reference the online documentation in collision layer/mask properties

See https://github.com/godotengine/godot-docs/pull/3863.

Shouldn't the urls link to the stable version of the documentation? If linking to latest, people may get information that is only valid for an unreleased version of Godot.

We've took the habit of always linking to the latest branch of the documentation in other classes. The same is done for tutorials in the <tutorials> tag.

Alright then, if that's the convention in the reference, that's fine by me. There's just a risk users could stumble upon changes that are for an unreleased version of Godot.
Although I can understand that until now and until the docs are complete, latest can have new information missing in stable.

Thanks!

About which docs versions to target, for the master branch, the docs should target latest, which is the corresponding docs. That's especially relevant when documenting new features for the next Godot version, or renamed classes, etc.
Then we could switch to e.g. https://docs.godotengine.org/en/3.2 in the 3.2 branch after it has been branched off, so that 3.2.x releases link to their version of the docs. In practice I never did it as I don't see a big need for it yet, but eventually this might be relevant (especially when we refactor docs for 4.0+).

Cherry-picked for 3.2.3.


Pre-trained model

Hi, thanks for your nice work!
How can I get a pre-trained model(0811_in_256_4.model and point.model) of pointnet?
Could you share the pre-trained model of pointnet?
Also, could you share the pre-trained model of cvae, RouteNet and PoseNet?
Thanks!

Hi
We also provide our pretrained model https://drive.google.com/file/d/1QyUWmvepAXKk_WYd2C-ZB6CEnl4zpjBS/view?usp=sharing
For the pointnet model, you can always use point.model

Awesome!
Thanks for your quick reply!
seonghyun


Toasts not working possibly due to nativeID

Description
When trying to use Toasts an error is thrown
CodeSandbox/Snack link
No response
Steps to reproduce

Follow docs to use toasts

When Toast has nativeID on it passed from toast.show render function it throws an error

gluestack-ui Version
1.0.6
Platform

[X] Expo
[ ] React Native CLI
[ ] Next
[ ] Web
[ ] Android
[ ] iOS

Other Platform
No response
Additional Information
It also looks like Toasts arent working on the documentation website page;

Looks like casting to string solves it on native
<Toast nativeID={String(id)} />

Hey @milesingrams, Thanks for reporting we have this issue in docs. It will reflect soon.


Split screen keyboard

Bug description
Currently if you are using split screen and web ssh and try to type something it it is not quit nice. You can not see what you are typing.
Steps to reproduce

Open WebSSH
Open it in a split screen
open the keyboard

Hello @lublak 👋
Thank you a lot for your issue 👍
Could you make a screenshot about the trouble you are encountering?
I'm not seeing your issue when splitting the screen :

@isontheline here :)

Some info: I have an iPad Pro 12,9

Thank you @lublak 🙏
I was testing under iPad Air.
I will try under iPad Pro 12.9 so

Text is behind the keyboard, the view doesn't resize properly.
I need to make a fix.
I'm adding this issue to the roadmap

@isontheline thanks :)

@isontheline any News? 😮
This issue is still present.

@lublak Sorry I missed this issue
I will fix it in a few days
My apologies

@isontheline All good. Basically, you can also work with it. Just not with a split screen.
Nevertheless, it would often be more convenient not to have to put your mobile phone next to it. xD

@lublak I have a strange behaviour :

when WebSSH is on the right side keyboard overlaps
when WebSSH is on the left all things right

Are you experiencing same?

@lublak I think I have found the problem and I'll work on a fix in a few hours

@isontheline yes for me its the same. I've never tried that before. I've only ever had it on the right side xD

For @isontheline work :

https://developer.apple.com/documentation/uikit/uikeyboardframeenduserinfokey?language=objc

A fix is now available :
https://testflight.apple.com/join/QSrBK59z

Many thanks for your feedback @lublak 🙏


OTZmqCmdEA.mq4 requires mql4zmq.mqh but it only resides in legacy directory

see:
https://github.com/OpenTrading/OTMql4Zmq/blob/master/MQL4/Experts/OTMql4/OTZmqCmdEA.mq4#L20
https://github.com/OpenTrading/OTMql4Zmq/blob/master/net/Git/github.com/AustenConrad/mql4zmq/mql4zmq.mqh
This file should have a non-legacy counterpart in ./MQL4/include/OTMql4 directory

I think something's wrong with the version of code that you're using -  if you click on the first link above you'll find that the replacement to mql4zmq.mqh is at line 25:
#include <OTMql4/OTMql4Zmq.mqh>
That file  was only in the mql4zmq project
https://github.com/OpenTrading/mql4zmq/blob/master/OTMql4Zmq.mqh
and the installation instructions neglected to mention that you needed to copy it.
At the risk of duplication, I've now checked it into this project, and will keep the
two projects in sync, and will update the documentation to say this. It's probably
better this way as that project may get "broken" as we try to migrate up to ZeroMQ 4.x
In the include file <OTMql4/OTMql4Zmq.mqh> that's been checked in to this project, the warning
that you were seeing has been commented out as it was just a trace statment for debugging,
Bring your  code  up to date by doing git pulls on OTMql4Zmq OTMql4PY and OTMql4Lib,
and it should be working for you, and post a followup. Things are complicated to install at the moment until we get them shrink-wrapped with an installer, but the code works and is being used daily.

OK, I am pulling in the latest changes.  Will post my progress.

Got past this now, thanks.


Enable Travis for this repo

@martenbiehl or @jperals I'm not a admin for this org but would love to enable travis-ci for at least this repo for automated test. https://docs.travis-ci.com/user/tutorial/ I would need owner rights or some owner needs to enable travis for me.
🍻

Hi @fabianmoronzirfas! Sorry this took a bit long, I was out of town and just came back. Travis should be configured now for this repo, can you confirm? (I completed up to step 3 in https://docs.travis-ci.com/user/tutorial/#to-get-started-with-travis-ci)

Looks like it. I will test this soon(-ish).
Thank you.

Travis is working. Thanks


refactor: update rector import

What is the motivation for this pull request?
refactor: update rector import
BREAKING CHANGE: update import to support rector v1
Is depended on by #33
Fixes #34
Checklist:

[x] Conventional Commits
[ ] Tests
[ ] Documentation

Release:

https://github.com/remarkablemark/rector-laravel-database-expressions/pull/38#issuecomment-1963476365


remove unused test flags for arm builds

Removing -nopip,-no_pip flags as they are added by the pip_new.sh script https://github.com/tensorflow/tensorflow/blob/5e7c4a9fc98caee07b41d758d9648a72080f811b/tensorflow/tools/ci_build/builds/pip_new.sh#L185

@nitins17  I originally created this PR to enable non pip tests. By apparently even after removing the -nopip,-no_pip flags, those tests are still skipped as these flags are added by the pip_new.sh script. I have a couple of questions: Does it make sense to run non pip tests for these pipelines? If yes, how can we enable them?

The non-pip tests needs a separate Bazel invocation and would need to be run from the TensorFlow root directory. Here's the script we used to use for running the non-pip tests. You can remove the -no_oss_py3* from the build script as we don't use it anymore.

The non-pip tests needs a separate Bazel invocation and would need to be run from the TensorFlow root directory. Here's the script we used to use for running the non-pip tests. You can remove the -no_oss_py3* from the build script as we don't use it anymore.

I see. What's the difference between pip tests and non-pip tests? If our pipelines are meant to publish pip wheels, do we need to run non pip tests?

For the pip tests, we need to build the wheel first and then the tests are run on the built wheel. Non-pip tests test the source code directly. I would recommend that both pip and non-pip are running because:

They both are part of our complete test suite and would provide more evidence that everything is working as intended.
We run 1363 pip tests and 1975 nonpip tests and as part of our release approval pipeline, we make sure that both of them are green before releasing the wheels.


Update xblocks for grade and s3 compatibility

Note: You MUST execute update submissions_studentitem set item_type = "eollistgrade" where item_type="problem" and item_id like '%type@eollistgrade+block@%'; manually

bors r+

bors r+

bors r+


two small typo in the italian translation

This repository is no longer being maintained. Please fork the new repository linked below and submit your changes there.
https://github.com/WoD5E-Developers/wod5e


Allow cols_to_keep (only in line-by-line case). Fix the demo notebooks as well

https://github.com/anhquan0412/that-nlp-library/blob/5777e42e9313ec5b63c634444ab9ff43711855f6/that_nlp_library/text_main_lm.py#L177

https://github.com/anhquan0412/that-nlp-library/commit/639988b82af80e36af8ec7dc84da1656d541b7bd


Ask before writing into an existing project directory

I have an existing Django project that does not use the cookiecutter-django template. When running cookiecutter https://github.com/pydanny/cookiecutter-django, it writes into the project directory even if it already exists without warning the user about it.
The correct behaviour would be to abort if the project directory already exists or at least warn the user and ask for confirmation before writing into the existing directory.

After having a quick look at the source for cookiecutter-django, it looks like this could be an issue with cookiecutter

@lgp171188 yes, this can be a problem with cookiecutter. please, you could report it in https://github.com/audreyr/cookiecutter

As this is a cookiecutter issue, I'm closing it here. Thank you @lgp171188 for reporting this ticket.


Macao/Macau

currently MO only lists Macao as its name. It should also include Macau

1.1.0 has been released fixing this issue

Great, thanks!


Refactor to React / Typescript & Webpack4

Addon needs some Updates, question is if i should continue with VueJs or switch to React


Resolved multi team similar repo issue

Linked Issue(s)
If team has a repo, then same repo added to another team is not visible.
Also the method getSelectedReposForOrg is returning deleted teams repo, unnecessarily increasing response size.
Acceptance Criteria fulfillment

[x] Same repo now visible in all teams it is added to
[x] Mark teamRepos inactive if team is deleted
[x] Removed unnecessary code

Proposed changes (including videos or screenshots)
The db query now directly returns Team repos with multiple workflows.

@Kamlesh72 Please let me know, once the query changes are done and if possible upload a  screen recording for the same.

@shivam-bit  This works fine.
.leftJoin({ rw: Table.RepoWorkflow }, function () {
  this.on('OrgRepo.id', 'rw.org_repo_id').andOn(
    'rw.is_active',
    '=',
    dbRaw.raw(true)
  );
})

Both this code leaves repos if their RepoWorkflow exists but not active.
.leftJoin({ rw: Table.RepoWorkflow }, 'OrgRepo.id', 'rw.org_repo_id')
  .andWhere('rw.is_active', true)
  .orWhereNull('rw.is_active');

.leftJoin({ rw: Table.RepoWorkflow }, 'OrgRepo.id', 'rw.org_repo_id')
  .andWhere(function () {
    this.where('rw.is_active', true).orWhereNull('rw.is_active');
  })

Both this code leaves few repos if their RepoWorkflow exists but not active.
.leftJoin({ rw: Table.RepoWorkflow }, 'OrgRepo.id', 'rw.org_repo_id')
  .andWhere('rw.is_active', true)
  .orWhereNull('rw.is_active');

.leftJoin({ rw: Table.RepoWorkflow }, 'OrgRepo.id', 'rw.org_repo_id')
  .andWhere(function () {
    this.where('rw.is_active', true).orWhereNull('rw.is_active');
  })

@Kamlesh72 if i am getting this right what you mean is that in the returned repos list there will be few repos missing since they don't have any active workflows. If yes, then that shouldn't be the case

@shivam-bit Yes.
It only returns If there is no workflow in db or is_active is true.
I think this will solve it. Will push the code after testing.
.leftJoin(
  { rw: Table.RepoWorkflow },
  function () {
    this.on('OrgRepo.id', 'rw.org_repo_id').andOn(
      'rw.is_active',
      'tr.is_active'
    );
  }
);

@shivam-bit Updated the code.
Previous V/s Current:

Will update the Delete team code in morning.

@shivam-bit Does the delete team queries need to be wrapped in transaction?

@shivam-bit Does the delete team queries need to be wrapped in transaction?
@Kamlesh72 Although we are not using using transaction BFF(next.js api) side yet, but in this case it totally make sense to use it.
So feel free to add one.

@Kamlesh72 Lets goooooooo!!🚀


Add my solutions & link to day 17 writeup

adds my solutions to all pages except 12 & 18 (the ones i've written articles for)
for day 17 instead links to my writeup here

dang! thanks!


Show IB packets as children of INDIRECT_BUFFER packet

This puts all IB packet nodes as children of the INDIRECT_BUFFER packet, and introduces an IB-Level column.
This makes is significantly easier to see the structure of the IBs at-a-glance.
The changes are non-trivial since it required modifying some underlying assumptions (e.g. can have shared packets as children of other shared packets)

The next step is to apply these changes to the set_draw_state packet. That part isn't done yet in this PR.

This puts all IB packet nodes as children of the INDIRECT_BUFFER packet, and introduces an IB-Level column. This makes it significantly easier to see the structure of the IBs at-a-glance, and allows for the collapsing of entire IBs by clicking on the arrow next to the INDIRECT_BUFFER packet.
The changes are non-trivial since it required modifying some underlying assumptions (e.g. can now have shared packets as children of other shared packets)

this is really cool! :D


Feature request: gtk cursor: be able to set the size

On my laptop with sway, I usually need to increase the size of the cursor.
I use this right now:
{
  home.pointerCursor = {
    package = pkgs.bibata-cursors;
    name = "Bibata-Modern-Ice";
    size = 22;
  };
}

My screen resolution is: 3200x1800
Tbh, I don't know if setting the cursor size is the right way to fix it or not.

you can set the gtk cursor size with the home manager option gtk.cursorTheme.size, along with the size variant of theme itself with our gtk.catppuccin.size option
feel free to re-open if you still have issues :)

I don't seem to have a bigger cursor when I use:
{
  gtk.cursorTheme.size = 22;

  gtk = {
    enable = true;
    catppuccin = {
      enable = true;
      cursor.enable = true;
    };
  };
}


Replace validated_transitions_keyswaptest with the testing transition_frontier extension broadcast pipe

The validated_transitions_keyswaptest pipe for integration can be easily derived from the testing transition_frontier extension. This pipe is discussed in the transition_frontier_extensions refactoring RFC. https://github.com/CodaProtocol/coda/blob/master/rfcs/0018-transition-frontier-extensions.md
However, we are relying on the implementation of the RFC to get merged into our codebase.
https://github.com/CodaProtocol/coda/pull/2664 before implementing this.

Closing this issue as it is stale for a long time.


[EN] Feedback for: /web/fundamentals/engage-and-retain/web-app-manifest/?hl=en

The outline on the left does not match the content of the page. 'Customize the Icons' doesn't appear in the outline. Additionally, the topic list here looks much different than the 'Engage and retain users' section.

Thanks for the feedback, we've got an update coming next week that should fix this.


introduce analyze API

https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-analyze.html

Thanks for this. I'll do a release shortly.


Replace CHECK with return failure and log.

Fixes #888 along with
https://code.google.com/p/modpagespeed/source/detail?r=4533
I'll also cherry-pick this into master.

LGTM


[Bug report] Server error when path contains cyrillic characters

I've got this server error with a fresh new vuepress install
23:12:36 [vite] Internal server error:
The request url "/Users/Davay/Documents/Ð¤Ð Ð£ÐšÐ¢/Axioma/axioma.center/node_modules/.pnpm/@vuepress+client<EMAIL_ADDRESS>is outside of vite dev server root "/Users/Davay/Documents/ФРУКТ/Axioma/axioma.center".

Notice it has Ð¤Ð Ð£ÐšÐ¢ in the first path and ФРУКТ in the second.
Environment info

Output of vuepress info:

System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
    Memory: 768.96 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.16.1 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 7.8.0 - /usr/local/bin/npm
  Utilities:
    Git: 2.21.1 - /usr/bin/git
  Browsers:
    Chrome: 90.0.4430.212
    Edge: Not Found
    Firefox: 88.0
    Safari: 14.1
  npmPackages:
    @vuepress/bundler-vite: Not Found
    @vuepress/bundler-webpack: Not Found
    @vuepress/cli: Not Found
    @vuepress/client: Not Found
    @vuepress/core: Not Found
    @vuepress/markdown: Not Found
    @vuepress/plugin-active-header-links: Not Found
    @vuepress/plugin-back-to-top: Not Found
    @vuepress/plugin-container: Not Found
    @vuepress/plugin-debug: Not Found
    @vuepress/plugin-docsearch: Not Found
    @vuepress/plugin-git: Not Found
    @vuepress/plugin-google-analytics: Not Found
    @vuepress/plugin-medium-zoom: Not Found
    @vuepress/plugin-nprogress: Not Found
    @vuepress/plugin-palette: Not Found
    @vuepress/plugin-prismjs: Not Found
    @vuepress/plugin-pwa: Not Found
    @vuepress/plugin-pwa-popup: Not Found
    @vuepress/plugin-register-components: Not Found
    @vuepress/plugin-search: Not Found
    @vuepress/plugin-shiki: Not Found
    @vuepress/plugin-theme-data: Not Found
    @vuepress/plugin-toc: Not Found
    @vuepress/shared: Not Found
    @vuepress/theme-default: Not Found
    @vuepress/theme-vue: Not Found
    @vuepress/utils: Not Found
    vue: Not Found
    vue-loader: Not Found
    vue-router: Not Found
    vuepress: Not Found
    vuepress-vite: ^2.0.0-beta.13 => 2.0.0-beta.13

It should be caused by the security update of the vite 2.3.0.
Try following snippet:
module.exports = {
  bundlerConfig: {
	viteOptions: {
      server: {
        fsServe: {
          root: process.cwd(),
        },
      },
	},
  },
}

If it does not help, it could be compatibility issue with pnpm, which needs more investigation.

If you meet issue with pnpm compatibility, try adding shamefully-hoist=true in the .npmrc file of your project, and re-install deps with pnpm.
See https://pnpm.io/npmrc#shamefully-hoist

https://github.com/vitejs/vite/issues/3373


Readme.md updated for 22.09 release

Signed-off-by: Esteban Martinena<EMAIL_ADDRESS>

This page should be specific to 22.09 but what I se in the instructions is still generic.

Missing binary installation
If there are source installation instruction they should be specific on retrieving the latest 22.09 code, not the generic https://raw.githubusercontent.com/open-rmf/rmf/main/rmf.repos
Docker containers are also using the latest tag, we should make this specifc.

We should also replicate the release https://github.com/open-rmf/rmf/releases/tag/21.09 for the 22.09, right?


[r] Need to bundle an example SOMAExperiment

We need to include a small SOMAExperiment with the package for use in examples and vignettes. Needed for #1180.

Addressed in #1298


Some attributes are not rendered in BitSpinButton

The following attributes are not rendered in this input

value
valuemax
type
role
aria-labelledby
aria-valuenow
aria-valuemin
aria-valuemax
aria-disabled
data-lpignore

I will fix this issue in #679


Swap order of action links so it matches visual order

Swaps the html order of the sort links and export link to match the visual order - as raised by our accessibility audit.
NB: the layout is a bit awkward on mobile - we'll address that in a later PR.

 Review accessibility fixes


pythonPackages.pytest-aiohttp: disable tests

Motivation for this change
Spotted a "Ran 0 tests".
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Why does it matter that tests are enabled if there are no tests?

@FRidh is quite picky about that. I don't know why :)

Ran 0 tests is undesirable because it can mean that

tests are not available
tests could not be found due to an incorrect test runner setup

If we know that tests are not available, then we can use the Ran 0 tests as an indicator for an incorrect test runner setup. Considering there are various ways test runners are invoked this is useful.
One could then argue that, if in a later update tests were added, they would not be run. And that's correct; having doCheck = false; along with a comment should push the contributor/reviewer to verify whether after an update it is possible to re-enable testing.


Missing device config: 0x031e:0x0002:0x0001:1.21

What are the IDs?
Manufacturer ID: 0x031e
Product type: 0x0002
Product ID: 0x0001
Firmware version: 1.21
Additional info:
supportsAGI: true
associationGroups: Lifeline, On/Off Control
supportsConfigCCV3: false
supportsZWavePlus: true
zWavePlusVersion: 1

mis reported
https://devices.zwave-js.io/?jumpTo=0x031e:0x0002:0x0001:1.21


Replace ValueOrError with Result in SignInState

@gino-m @JSunde  PTAL?

Codecov Report

Merging #1220 (6f537b6) into master (f6e485b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1220      +/-   ##
============================================
- Coverage     28.89%   28.85%   -0.05%
- Complexity      777      780       +3
============================================
  Files           291      291
  Lines          7430     7427       -3
  Branches        345      345
============================================
- Hits           2147     2143       -4
  Misses         5182     5182
- Partials        101      102       +1

Impacted Files
Coverage Δ

...m/google/android/ground/system/auth/SignInState.kt
88.88% <0.00%> (-11.12%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Failed to install on Windows 7. Failed to locate "CL.exe"

Hi, I installed visual studio 2015, the sdk and python but it says I'm missing the path to the WindowsSDKDir... which is weird because I installed the SDK from the wiki page. Do I need to add something to the windows environmental path or something? Thanks!

Run one of the following commands depending on your architecture:
call "C:\Program Files\Microsoft SDKs\Windows\v7.1\bin\Setenv.cmd" /Release /x86
call "C:\Program Files\Microsoft SDKs\Windows\v7.1\bin\Setenv.cmd" /Release /x64

The node-gyp readme has some other tips, but I believe the above should resolve this.
https://github.com/nodejs/node-gyp#installation
Let me know if this helps!

I'm going to close this issue, if you're still having problems please let me know!

It works man. Thanks!


Fix accessible navigation between payment methods

Summary

Changes the behavior of Dropin payment method / list to act as an accordion following W3 accessibility guidelines, allow for navigation through payment method with using screen reader controls and without automatically switch between payments methods allowing users to "Tab" to the bottom of the page.
Tested scenarios

Ability to navigate the page using keyboard controls on Desktop
Ability to navigate the page using desktop version of VoiceOver
Buttons are read aloud with proper descriptions identifying payment methods including stored cards

Fixed issue:
#1147 #610

Looks good to me.
You could maybe add some e2e tests for the navigation on Desktop - but they don't have to be part of this PR


builder: Create KubeVirt source directory and mark it as safe for git

What this PR does / why we need it:
Resolves the following error when using builder >=<PHONE_NUMBER>-faf545b82 that now provides git-2.39.1-1.el9.x86_64 (previously git-2.31.1-2.el9.2.x86_64 with<PHONE_NUMBER>-8818abcfa):
$ make generate
[..]
+ /root/go/src/kubevirt.io/kubevirt/hack/build-go.sh generate
fatal: detected dubious ownership in repository at '/root/go/src/kubevirt.io/kubevirt'
To add an exception for this directory, call:

        git config --global --add safe.directory /root/go/src/kubevirt.io/kubevirt
[..]
+ go build
error obtaining VCS status: exit status 128
        Use -buildvcs=false to disable VCS stamping.
make: *** [Makefile:48: generate] Error 1

This could be handled in the individual build and generate scripts but would result in the same directory being appended to the global git config with each run. Adding it once during the build of the builder image is cleaner.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9806
Special notes for your reviewer:
Release note:

NONE

/hold

/unhold
/retest-required
The builder image was bumped outside of my v1beta1 change and people are now reporting hitting this so I'm unholding to see if we can land and update the image first before my hackaround lands.

/lgtm
not on a machine right now where I could build and push the image for you.

/lgtm
not on a machine right now where I could build and push the image for you. Or do we have the CI jobs now in place to do it async?

The postsubmit job publish-kubevirt-builder [1] is working now so that should happen async thanks!
https://prow.ci.kubevirt.io/job-history/gs/kubevirt-prow/logs/publish-kubevirt-builder

/approve

@lyarwood Thank you! You're fast :)

Not sure that it's related but the issue is still there for me:
[bmordeha@fedora kubevirt]$ make cluster-build
./hack/cluster-build.sh
selecting docker as container runtime
Building ...
go version go1.19.2 linux/amd64
Waiting for rsyncd to be ready
go version go1.19.2 linux/amd64
fatal: detected dubious ownership in repository at '/root/go/src/kubevirt.io/kubevirt'
To add an exception for this directory, call:

	git config --global --add safe.directory /root/go/src/kubevirt.io/kubevirt
Sandbox is up to date
INFO: Analyzed 7 targets (0 packages loaded, 0 targets configured).
INFO: Found 7 targets...
ERROR: <builtin>: BazelWorkspaceStatusAction stable-status.txt failed: Failed to determine workspace status: Process exited with status 1
hack/print-workspace-status.sh: line 36: KUBEVIRT_GIT_VERSION: unbound variable
INFO: Elapsed time: 0.209s, Critical Path: 0.03s
INFO: 1 process: 1 internal.
FAILED: Build did NOT complete successfully
make: *** [Makefile:150: cluster-build] Error 1
[1]+  Done                    gitk

Not sure that it's related but there is still issue with the builder:
[bmordeha@fedora kubevirt]$ make cluster-build
./hack/cluster-build.sh
selecting docker as container runtime
Building ...
go version go1.19.2 linux/amd64
Waiting for rsyncd to be ready
go version go1.19.2 linux/amd64
fatal: detected dubious ownership in repository at '/root/go/src/kubevirt.io/kubevirt'
To add an exception for this directory, call:

	git config --global --add safe.directory /root/go/src/kubevirt.io/kubevirt
Sandbox is up to date
INFO: Analyzed 7 targets (0 packages loaded, 0 targets configured).
INFO: Found 7 targets...
ERROR: <builtin>: BazelWorkspaceStatusAction stable-status.txt failed: Failed to determine workspace status: Process exited with status 1
hack/print-workspace-status.sh: line 36: KUBEVIRT_GIT_VERSION: unbound variable
INFO: Elapsed time: 0.209s, Critical Path: 0.03s
INFO: 1 process: 1 internal.
FAILED: Build did NOT complete successfully
make: *** [Makefile:150: cluster-build] Error 1

Using<PHONE_NUMBER>-e8888cc5?

We should add a builder-bumper job to our CI. Builder was published but dockerized script wasn't updated.

KUBEVIRT_BUILDER_IMAGE="quay.io/kubevirt/builder:2304251231-0bacb3db8"
in my local machine i updated it with the latest commits

https://github.com/kubevirt/kubevirt/pull/9813

We should add a builder-bumper job to our CI. Builder was published but dockerized script wasn't updated.

+1 I was going to follow up with automation for this once back from PTO but others are welcome to sort it out before then!


Comment override doesn't seem to work

I've just added this plugin to my project, and overall it's working beautifully.. with one small exception: I cannot get the comment overrides to work.
I've added "plugins": ["./node_modules/prettier-plugin-multiline-arrays"] to my .prettierrc file, making use of the internal rules with no extra customisations.
trying to add either // prettier-multiline-arrays-set-threshold: 5 or /* prettier-multiline-arrays-set-threshold: 5 */ to the top of my JS file changes absolutely nothing.
I've also tried setting this with prettier-multiline-arrays-next-threshold immediately before the 3 lines that I want to keep inline, but even that doesn't work.

is this a "known issue" with the current plugin code, or would you need more info to debug this?

wait wait! sorry.. I was being a dumbass. 🤦🏼
after setting the rule override comment and then clearing my trailing comma, the formatting came out as I expected it to.
thank you so very much, this has just solved a very long-standing annoyance of mine with Prettier. 👍🏼

Glad you got it working! Sorry for the confusion on the overrides, at this point this package just barely works 😅 but that's been good enough so far...

no worries, even with this "just barely working", it's already helped alleviate a massive headache.. so a massive thank you for that! 🖖🏼


k3s build problem

According to the K3S REDMAE file，ther are 2 ways to build k3s:
(1)go build -o k3s
src/github.com/rancher/k3s/main.go
-rwxr-xr-x  1 root root 100M 3月  18 11:18 k3s
(2)make and that will create ./dist/artifacts/k3s
src/github.com/rancher/k3s/cmd/k3s/main.go
-rwxr-xr-x 1 root root  36M 3月  14 17:09 k3s
The size of the two k3s files is very different.
then I try to build " ./cmd/k3s/main.go" manually according to the same way as ./script/package-cli

CMD_NAME=dist/artifacts/k3s${BIN_SUFFIX}
go generate
LDFLAGS="-X github.com/rancher/k3s/version.Version=$VERSION -w -s"
STATIC="-extldflags '-static'"
CGO_ENABLED=0 go build -ldflags "$LDFLAGS $STATIC" -o ${CMD_NAME} ./cmd/k3s/main.go

The build result to a 2.7M k3s, but this k3s is not work normaly.
-rwxrwxr-x 1 root root 2.7M 3月  18 09:02 k3s*
./k3s server
panic: runtime error: index out of range
goroutine 1 [running]:
main.getAssetAndDir(0x81af8bf, 0x14, 0x14, 0x7e, 0xffffffff, 0x8187640)
/root/k3sroot/src/github.com/rancher/k3s/cmd/k3s/main.go:101 +0x11c
main.extract(0x81af8bf, 0x14, 0x0, 0x0, 0x0, 0x0)
...
Cloud you tell me how to buid a 36M size of k3s directly without the full make steps? Thx!

Hi @jamesxia20181001, please see the build files in scripts. The preferred way to build for devs so everything is bundled with k3s is ./scripts/build && ./scripts/package. Also see Dockerfile.dapper for how the build environment is setup.

According to your prompt, I understand the reason for my failure because the binddata has a problem and has been resolved. thank you very much!


update python-sdk debug test to use dump v2

this test was previously broken because it used the dump command, which is now deprecated in favor of v2. this change updates the test to use the dump v2 command instead.
Jira: INT-1009

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Kevin Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Aggregated Metric seems to be fed back into Aggregator...

I have the following aggregation rule:
abc.prod.ALL.<service>.<metric>.count (60)   = sum abc.local.*.<service>.<<metric>>.count
Given metrics like:
abc.prod.host1.aservice.ametric.count
abc.prod.host2.aservice.ametric.count
I would expect them to be aggregated to
abc.prod.ALL.aservice.ametric.count
But that metric is never created.  In aggregator logs, I see

Allocating new metric buffer for abc.prod.ALL.aservice.ametric.count

but it's not created.  If I add a layer to the generated metric like:
abc.prod.extralayer.ALL.<service>.<metric>.count (60)   = sum abc.local.*.<service>.<<metric>>.count
then we seem to get a recursive explosion of created metrics like:
abc.prod.extralayer.ALL.aservice.ametric.count
abc.prod.extralayer.ALL.ALL.aservice.ametric.count
abc.prod.extralayer.ALL.ALL.ALL.aservice.ametric.count
abc.prod.extralayer.ALL.ALL.ALL.ALL.aservice.ametric.count

Which led me to believe that the generated metric is then aggregated again...
I added a logging line to AggregationProcessor.process:
      else:
        log.clients("Found aggregate " + aggregate_metric + " for " + metric)
        aggregate_metrics.add(aggregate_metric)

And then tried with my original, desired rule.. and I eventually started to see, loglines like:

Found aggregate abc.prod.ALL.aservice.ametric.count for abc.prod.ALL.aservice.ametric.count

It matched itself as if it was a new incoming metric... Why is it being fed back into the aggregator?

I think we've hit the same issue, we've fixed it with https://github.com/criteo-forks/carbon/commit/825693c97e57c7cdc36d0b0d758694010ce2be53

@iksaif - nice!
Should we include that fix in carbon or it has some side-effects?

It appears this is a duplicate of #455.

@deniszh it does have the side affect of not feedback the values in the aggregator (which some people may be depending on). My patch restore the same behavior that 0.9.x had, so feed free to merge it.

Fixed by 69f5d0e11e258da01328068f725c13335e5b8b9c.


Sample Page & Various Docs Fixes

Fix sticky sidebar (for https://modus-bootstrap.trimble.com/sample-page/next/)
Remove unneeded CDN loaded Icon Font
Consistent Navbar icon for Theme Toggle
a11y fix for some icon font usage (added aria-hidden="true")

Something is not right with the theme toggle, the hover background looks not consistent. In the dark theme when the toggle is in an active state hovering has no effect, I mean no hover background. I think it would be good if @soniakaukonen can verify.

Also the navbar in this PR is different from Modus styleguide PR in terms of icon size, toggle's hover background in an active state, search bar size is different too.

Something is not right with the theme toggle, the hover background looks not consistent. In the dark theme when the toggle is in an active state hovering has no effect, I mean no hover background. I think it would be good if @soniakaukonen can verify.

I think you might be right. The Buttons style guide doesn't cover it now I see it does show the states here: https://modus.trimble.com/components/web/navbars/styles/#navbar-button-state-examples - so I'll make some adjustments. Thanks for the review and spotting that!

Something is not right with the theme toggle, the hover background looks not consistent. In the dark theme when the toggle is in an active state hovering has no effect, I mean no hover background. I think it would be good if @soniakaukonen can verify.

Yes, I think you maybe right. The Buttons style guide doesn't cover it but now I see it does show the states on Navbar styles page here: https://modus.trimble.com/components/web/navbars/styles/#navbar-button-state-examples - so I'll make some adjustments. Thanks for the review and spotting that!
UPDATE: Actually, maybe it's correct as it is. The hover state is correct and the active state is correct. I don't think there is a different state for hover over active.

In that case, we need to keep the hover over active consistent in light and dark themes also the icon fill colour looks different in the style guide.

Update again: I was looking at the background colors on hover/active state and now realize the icon color changes and it shouldn't (it should remain white). I fixed this now.

Will it be fixed in Styleguide too?

Yes, I'll add a commit to that PR.


handle AND in text query

On the current website when there is an AND, the query is interpreted as two (or well, multiple) phrases separated by " AND ". This is particularly useful for etexts. There might be better ways for users to indicate that but since it already exists let's handle it

@eroux, our current search does AND by default.

We don't do it in the etexts (which is a big use case for the AND)
if users type "AND" in the query it will mess it up in the current system
We don't provide control over where to cut the phrase, or multiple AND
We don't provide AND for long queries
So no

In etexts we currently require exact phrase which is AND by default.
Users practically never type AND.  According to our logs, roughly ten times in a million, probably including ourselves testing.  I can spend time taking care of this 0.001% of use cases if you want.

the usage of AND on the production website is the following:
if the user types "gsung 'bum AND mi pham" (I know, this example works on the dev website, that's not the point) it will select results with a match phrase for "gsung 'bum" and a match phrase on "mi pham", see https://www.bdrc.io/blog/2021/03/03/search-me/
We can imagine having that as a low priority, but let's not give up on it no

we could imagine having an additional syntax with double quotes, like "gsung 'bum" "mi pham", that's also fine


Implement "eslint.rules.customizations" - Allow users to override rule severity from VS Code settings

This hopefully closes #468 based on the discussions in #561.
This PR implements a new extension option, allowing diagnostics reported by the ESLint extension to be overridden by user settings within VS Code. The main usecase is to allow linting errors to be visually different to actual typing/compilation problems based on personal preference, especially if adjusting the ESLint configuration itself is difficult (e.g. it's prepackaged, StandardJS, etc) or there's a fear of committing these customizations accidentally.
For example, the playground environment in this PR:

The eqeqeq rule is an error in ESLint parlance, but the * override forces it to be a nicer yellow warning. I personally prefer this representation of all linting warnings.

All comments are welcome.

Aah ok, that's very granular. I'll admit I don't really see a usecase for ! negation, unless that implies we implement wildcard matching? I can understand why Git does that but I'm struggling a little for ESLint rule names.
So If I'm understanding it right: something like this, where ! means ignore the rule?
[
    { rule: "no-*", severity: "warn" },
    { rule: "*", severity: "info" },
    { rule: "!radix" }
]

In such a case I feel having a severity of 'ignore' would be clearer and wouldn't need the ! symbol.

{ rule: "!radix" } would render as defined in the eslintrc.json. How would ignore be interpreted when used as a severity.

Aah, I didn't fully understand what "negating" a rule meant in this context. In retrospect I think it means to 'ignore' an override (i.e. rule 1 is * to make everything warnings, rule 2 is !no-semicolon and means let that rule be treated based on the ESLint config) if that's right?
Initially I was thinking you meant add the ability to filter out rules, which I guess is possible as well but I don't see anyone having a usecase for that.

rule 2 is !no-semicolon and means let that rule be treated based on the ESLint config

Absolutely corret.

Ping @dbaeumer @jamesorlakin, is this still something either of you are working on? This is a big pain point for me (& others) so I'd be very interested in picking up this work if neither of you have time?

I am not actively working on this right now.

Hi @JoshuaKGoldberg, this is something I admit I've forgotten as my work has largely moved to Java nowadays! Sorry about that. You're welcome to continue, or I can have a look at continuing during the next weekend. It's the 'negating' logic that was left to do, though I assume it doesn't need to be that advanced.

Continued in #1164 🤗

Continued in #1164 🤗

@JoshuaKGoldberg thanks for picking this up again!

@JoshuaKGoldberg thanks for picking this up again!

Closing in favour of #1164. Thanks ever so much @JoshuaKGoldberg!


Failing on long videos

https://fullfact.slack.com/archives/C06SF7T3ZRA/p1715075884121989

Adding some logs to this for additional context:
SystemExit: 1
[2024-05-16 11:45:06 +0000] [346] [INFO] Worker exiting (pid: 346)
Unterminated string starting at: line 8 column 17 (char 5070)
[2024-05-16 11:45:07 +0000] [1] [ERROR] Worker (pid:346) was sent SIGKILL! Perhaps out of memory?
[2024-05-16 11:45:07 +0000] [420] [INFO] Booting worker with pid: 420

I am moderetly confident there is a timeout somewhere in the stack with a 30 second period.


chore(atomic): add part to search box

https://coveord.atlassian.net/browse/KIT-1105

We just have to be careful a bit not to expose too much shadow parts, for maintainability reasons.


Carbon breaks the Get-WindowsFeature command when present on the system

On Server OSes, If Carbon is present on the module load path and a script uses the Get-WindowsFeature cmdlet, it throws a CommandNotFoundException unless the ServerManager module is explicitly imported first.
To reproduce:
PS> Get-Command Get-WindowsFeature

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Cmdlet          Get-WindowsFeature                                 <IP_ADDRESS>    ServerManager

PS> Install-Module Carbon -AllowClobber
PS> Get-WindowsFeature

Get-WindowsFeature : The term 'Get-WindowsFeature' is not recognized as the name of a cmdlet, function, script file,
or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and
try again.
At line:1 char:1
+ Get-WindowsFeature
+ ~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Get-WindowsFeature:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

I realize Carbon probably implemented Get-WindowsFeature before ServerManager did, but sometimes it isn't possible to control what modules are loaded ahead of time, such as in OneGet/MicrosoftDockerProvider#26. The fact that a CommandNotFoundException occurs is also very confusing and hides the underlying issue.
Environment info:

Carbon: 2.6.0
OS: Windows Server 1607
$PSVersionTable:

Name                           Value
----                           -----
PSVersion                      5.1.14393.2515
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.2515
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

I'm currently working on this. See commits here: https://github.com/pshdo/Carbon/tree/feature/stop-carbon-name-collisions
The plan is to add a C prefix to every Carbon command. To avoid breaking backwards compatibility, we're also adding a bunch of aliases from the old command names to the new command names. Since Carbon's manifest only lists the functions it exports and not any aliases, PowerShell's auto-module loading feature will no longer think Carbon has a Get-WindowsFeature command.


Re-add .hits() and .misses() to sync::Cache

Unless I'm blind (which is very possible) the .hits() and .misses() functions were removed from the sync::Cache. It would be nice to have them back for internal logging and testing without messing around with wrapping the cache accesses with Atomics or some other method of tracking those metrics.

They're there, but in the last version they were moved behind the "stats" feature. I realized thought that docs.rs isn't displaying these functions, so discoverability is bad. I'm going to try and fix that.


feat: add x-motemen/blogsync

https://github.com/aquaproj/aqua-registry/pull/5692 x-motemen/blogsync: Push and pull blog entries from/to local filesystem
$ aqua g -i x-motemen/blogsync

prerelease: https://github.com/aquaproj/aqua-registry/releases/tag/v3.37.0-0

Released https://github.com/aquaproj/aqua-registry/releases/tag/v3.37.0


WIP Add groovy-macro docs

WIP
This is a Working In Progress because:
Failing Tests
There are 2 tests that started failing once I added the groovy-macro dependencies in specs:

org.codehaus.groovy.classgen.asm.sc.bugs.Groovy7316Bug > testTypeCheckingBypassUsingExplicitTypeHint

org.codehaus.groovy.classgen.asm.sc.bugs.Groovy6757Bug > testExplicitTypeHint

Questions

Apart from that, there're a lot of licenses added I don't know where they came from. Should I exclude them from the PR ?

Feedback
Of course, need to know if the docs are ok, or not. Even if the PR is rejected I'd be happy if at least part of them help to the macros documentation.

Those licenses should be generated into the root directory not src/spec/assets. You should exclude them from your PR.

Ok, I've excluded the licenses.

BTW: I'm aware that commits must be rebased before merging them to the main branch (All have WIP...). I'm keeping them to keep track of the suggestions.

I added a bunch of mostly cosmetic suggestions. Looks really great overall. I also get the same test failures even though they seem unrelated at first glance. I'll look into that when I get the chance.

Looking good. Any chance for a rebase?

On it!
2016-10-13 9:32 GMT+02:00 Paul King<EMAIL_ADDRESS>
Looking good. Any chance for a rebase?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/groovy/pull/439#issuecomment-253436951, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABWT80tssmqOwKO2V6bR9NR9q1_I_B9yks5qzd6agaJpZM4KPs_C
.

Rebased and squashed!

Merged. Thanks!!

🎉  👍

@mariogarcia You are the man buddy! :tada:

Yeahhh!!!!! :smiley: :tada: :confetti_ball: thanks @ilopmar I'm really happy to help version 2.5.0 to be a little bit closer. But of course this is teamwork, thanks to @bsideup and @paulk-asert as well.


Update recommendation for high accuracy time sync

-Include UtilizeSslTimeData setting
-Minor reorganization

@mitschmi - Please review this change.

Test

@robinharwood, @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


proposal: name for production ready version "Universal data-flow"

Added to "the stream of conciseness 0.7+ roadmap"


OAuth2

https://developer.twitter.com/en/docs/authentication/oauth-2-0/authorization-code
https://developer.twitter.com/en/docs/authentication/oauth-2-0/user-access-token

For confidential clients

For Public Clients


"Open File" should be a possible choice in the subtitle track drop-downs in the subtitle track selector

This would make it possible to use different files as different subtitle tracks. The only way to do this right now is to drag-and-drop multiple files. When using the track selector dialog, it is only possible to load one file.

I'm thinking about the implementation for this, if we did allow uploading subtitles in the track dropdowns, would we still allow multi-file uploads? if so, we would need to maintain multiple functions to handle either case.
Also it seems like subtitle uploads need to be passed to the BE so the file can be parsed, I'm wondering if this could be chance to refactor how files are parsed, maybe uploading files could be changed to not immediately close the Dialogue, and instead keep it open to users can select which subtitle (the built-in ones from the video, and the ones you just uploaded) should be the first, second, etc.


CB-12112: Added missing parameters

These changes should have been added to the API as part of CB-12095

retest this please


feature:Support to obtain multiple configurations through a single key in Consul

Ⅰ. Describe what this PR did
添加从consul单一key获取多条配置功能，registry.conf文件添加config.consul.key属性用于指定consul中的key。
Ⅱ. Does this pull request fix one issue?

#2506 #2316
Ⅲ. Why don't you add test cases (unit test/integration test)?
此功能在原有功能上修改，不方便写测试用例。
Ⅳ. Describe how to verify it
其他功能正常配置后，在registry.conf文件中将config.type设置为“consul”，添加config.consul.key属性，属性值为consul中的key，例如“seata.properties”，启动seata应用（server或client都可以），会自动拉取consul上“seata.properties”中的配置。
应用中的配置如下，根据项目选择对应的配置方式：
application.yml

registry.conf

consul中的属性配置如下：

Ⅴ. Special notes for reviews
将config.type设置为“consul”。
此功能已实现动态配置，同时兼容旧的配置方式。
seata-server也可以通过这种方式配置。

@a364176773 consul配置中心适配好了

Codecov Report

Merging #3311 (c1cf773) into develop (23a407e) will increase coverage by 0.32%.
The diff coverage is 50.55%.

Codecov Report

Merging #3311 (324dd15) into develop (af8d72e) will increase coverage by 10.84%.
The diff coverage is 25.00%.

:exclamation: Current head 324dd15 differs from pull request most recent head c256011. Consider uploading reports for the commit c256011 to get more accurate results

@@              Coverage Diff               @@
##             develop    #3311       +/-   ##
==============================================
+ Coverage      40.70%   51.55%   +10.84%
- Complexity      2992     3372      +380
==============================================
  Files            676      617       -59
  Lines          22609    20442     -2167
  Branches        2810     2565      -245
==============================================
+ Hits            9204    10538     +1334
+ Misses         12554     8842     -3712
- Partials         851     1062      +211

Impacted Files
Coverage Δ

...gure/properties/config/ConfigConsulProperties.java
44.44% <25.00%> (ø)

...n/java/io/seata/common/util/StringFormatUtils.java
0.00% <0.00%> (-92.31%)
:arrow_down:

...g/annotation/datasource/DataSourceProxyHolder.java
0.00% <0.00%> (-75.00%)
:arrow_down:

...ion/datasource/SeataAutoDataSourceProxyAdvice.java
0.00% <0.00%> (-70.84%)
:arrow_down:

...on/datasource/SeataAutoDataSourceProxyCreator.java
0.00% <0.00%> (-69.45%)
:arrow_down:

...main/java/io/seata/common/holder/ObjectHolder.java
0.00% <0.00%> (-50.00%)
:arrow_down:

...eata/discovery/loadbalance/LoadBalanceFactory.java
50.00% <0.00%> (-16.67%)
:arrow_down:

...rc/main/java/io/seata/common/util/StringUtils.java
15.94% <0.00%> (-10.63%)
:arrow_down:

...main/java/io/seata/rm/datasource/util/XAUtils.java
12.00% <0.00%> (-8.00%)
:arrow_down:

...n/src/main/java/io/seata/common/util/IdWorker.java
77.08% <0.00%> (-6.25%)
:arrow_down:

... and 289 more

请解决下冲突，进行合并


Korhonen Edits

4 Korhonen Epidoc Edits

Just to note that if it's [---] in the original then it should be <gap reason="lost" extent="unknown" unit="character"/> and not <supplied>


Configuring the python model tests to execute on Dataproc cluster instead of serverless

resolves #

Description
Configuring the python model tests to execute on Dataproc cluster instead of serverless
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[ ] I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
[ ] I have run changie new to create a changelog entry

@ChenyuLInx , @colin-rogers-dbt , I don't think it is wise to push this up unless the Dataproc instability is resolved. I'm open to keeping this as pending work for later.


array_merge(): Argument #2 is not an array

Error:
ErrorException in SluggableTrait.php line 205:
array_merge(): Argument #2 is not an array
While tryint to create news:
public function store(NewsRequest $request)
{
$newsItem = new News($request->all());

Auth::user()->news()->save($newsItem); <-- this triggers error.

flash()->success('News have been created');

return redirect('admincp/news');
}

SluugableTrait.php line 205 is:
$this->sluggable = array_merge( $config, $this->sluggable );
Any ideas how to fix this? Im new to eloquent-sluggable.

Brain fart, fixed.

:wink ... was it forgetting to add the trait on your News model?

No, I accidently added  ['build_from' => 'title', 'save_to'    => 'slug'] to protected $fillable, not protected $sluggable.

here is a problem laravel 5.4 how to fix that ??

Can you be more specific, @somratcste ?  Also, if it's not the same error message, please open a new issue.


Fix error with no constantize method

Fixes this error:
2.4.1 :091 > RPC::Wallet.get_all_incoming_transfers
NoMethodError: undefined method `constantize' for "RPC::IncomingTransfer":String

Sorry, I just realised the version is the same. Could you maybe change the version to "<IP_ADDRESS>" of the gem at monero/lib/rpc/version.rb?

Done, sorry.

I'm not sure if it's cool to make active_support a neccessary dependency. for sure, i use this as a gem for rails application, but shouldn't it be more pure ruby?
stackoverflow gave me a workaround for constantize  which might look something like this (untested)
Object.const_set( (RPC.config.transfer_clazz || "RPC::IncomingTransfer").classify, Class.new)

won't that be better, rather then using the whole active_support? we might even steal just the String.constantize method and override String only.

I'm sorry. I just tested it, I did not look for an alternative. I can have a look at it tomorrow if you'd like to.


Resize Observer added in Safari Tech Preview 80

Source: https://webkit.org/blog/8825/release-notes-for-safari-technology-preview-80/

Thanks!


[1.18.2] [Fabric] Items not in Creative/REI

Not sure if this is intended, but i dont have any items to pick. Also REI doesnt show any recipes.
I can craft the items, but i tried to test it for my server & its easier in creative or REI.

Few questions:

Is this mod on client or only server?
Which version of polymer do you use (should be visible in F3)?

I can't replicate it with mod only on server + polymer client and mod on both server and client

Client im testing my private modpack (Server will tested later). My log if this helps too:
latest.log
Ive got Polymer 0.2.0-beta.27

Okay, it looks to be conflict with stacc mod. I will look into it

Stacc? Sorry dont know which one this should be ^^"

It's library, bundled by numismatic-overhaul mod

Ah i see :)

You can update now polymer manually to latest (https://github.com/Patbox/polymer#download). It should fix your issue

Fixed in 1.5.0-beta.3+1.18.2


intended use?

can please specify what this code is doing: training, validation, deployment, or both? Thank you

This code partially implements Bone Age Assessment model described in "Paediatric Bone Age Assessment Using Deep Convolutional Neural Networks" by V. Iglovikov, A. Rakhlin, A. Kalinin and A. Shvets. Training and validation. Data preprocessing part was mostly skipped.


Update amount to coins in the "Advanced Calls" section in the Sway book

Ref: https://forum.fuel.network/t/advanced-calls-coins-or-amount/1519/2
Even better, replace that example with one that actually compiles from the examples directory.

https://github.com/FuelLabs/sway/pull/3874 closes this.


Asking for the root of the repo to migrate

Verify canary release

[X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue
pnpx @turbo/codemod update
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Windows
Which canary version will you have in your reproduction?
pnpm why turbo
Describe the Bug

Expected Behavior
The expected outcome for running pnpx @turbo/codemod update should be:
Successful execution of the @turbo/codemod update command, applying necessary updates to bring the codebase in line with Turborepo version 2.2.3.
Proper installation of the latest version of turbo as a dev dependency.
No workspace-related or version mismatch errors if all dependencies are correctly specified.
To Reproduce
To reproduce this issue, you would need a similar setup:
Use PNPM in a monorepo environment with workspaces.
Have a dependency (@metajob/next-local) defined in one of the packages with a workspace: version (e.g., @metajob/next-local@workspace:^0.0.1).
Attempt to add or update turbo in a nested directory instead of at the root of the monorepo.
Additional context
No response

We'll need a reproduction with step-by-step instructions on how to reach this bug to be able to work on this. Thanks in advance!


Class api does not exist

Version 1.0.x now throws exception Class api does not exist

And?
Look, that's not a report. You've given me absolutely nothing to go on with this. No proper stack trace. No example code that's causing the issue. No mention of the framework you're using (Laravel/Lumen) or the version of it.
Please report the issue correctly so I can help you resolve it.

 That's not a binding.
Show some code. What are you trying to do?


Save normalized report using its file name extension

This pull request derives from #512. So needs to be handled after that.

When an end-to-end test fails, compare.xsl saves the normalized report for later inspection.
The saved file is always named .html which is wrong when the file is not an HTML.
This pull request fixes it.

cf6a80fa0667de9d3e3c60849c6efa35bc1aa09c reproduces the problem by a deliberate failure: Travis, AppVeyor: They read Saved the normalized input: ....html when they should be .xml.
aeb310af71059a0cfe6aaf159e1366a3446fd64e fixes it: Travis, AppVeyor
e2463ef19c51a1560544cebd9a407f560fb54494 reverts the deliberate failure

@cirulls
Merged this trivial fix of a test driver.


Double suggestion: Exclude words and/or Markdown support

Translating a README for a little project of my own, both google and yandex insist on translating words that should not be translated, like commands or configuration variables.
In some cases an uncoditional exclusion of all occurences of a word is the right thing.
Instead of or in addition to simply excluding words, a more elegant solution might be Markdown support: never translate anything that is in code tags or code blocks.

On the 1st suggestion: Exclusion of words is a duplicate of #75.
On the 2nd one: I believe that full Markdown support is a bit beyond the scope of this project. It's not just about parsing code tags / blocks; any special characters need to be preserved for sanity: for example, the English string *test* may translate to Test * * in Latin, which diverges undesirably from its original Markdown.
None of the existing translation services supports any other format than plain text; hence I would have to implement a Markdown parser (Note that there are many dialects of Markdown so it's nontrivial work!) Furthermore, if Markdown is added, one could even request support for org-mode / AsciiDoc / HTML / XML / TeX ...
I agree that handling specific document formats could be a useful feature. It has probably less priority for me, though.

On the 1st suggestion: Exclusion of words is a duplicate of #75.

do i understand correctly that this is currently not implemented in trans?
it's good to know that google translate has at least some option for this, but i think it would be more elegant to have it handled locally.

On the 2nd one: I believe that full Markdown support is a bit beyond the scope of this project.

that's fine with me.
markdown was just my first thought about the first one.
anyhow, thanks for another great piece of FOSS!

do i understand correctly that this is currently not implemented in trans?

Correct, there is no such device in trans yet.
I'm afraid to say, that Google Translate's special support is a necessity here, as this demand cannot be handled ideally on local side. Given a sentence ABC (where B is intended to be kept untranslated), we could either: (1) Ask the engine to translate A and C separately, but then the ordering of three parts would require prior knowledge of the target language's grammar, and the sentence as a whole can look less sensible; (2) Translate ABC at once, then replace the translated B with the untranslated B back. This is not always feasible since the translation is neither deterministic nor injective.
Since trans is not an NLP software, the only reasonable way of implementing this would be wrapping stuff in Google's special HTML tags (as described in #75), and it will be Google-only. It's not going to be generalizable to other translation engines. (though I can assume most people using trans will prefer Google Translate as a default engine, it's not always the case.)

I played with this a little, and it seems that all translation engines have a way of ignoring words (couldn't test all though).
Either putting them in double or single or curly quotes, or maybe writing them ALLCAPS, etc. etc., I can think of many ways to implement it locally (maybe differently for each engine).

deepl is able to translate markdown and it does it without messing up markdown or html tags. Deepl allows a limited amount of free translations, after which you have to pay for it, so I have been looking for a way to do this with google translate. If you only need a limited amount of translation here is how I am currently doing it with Deepl:
git clone https://github.com/mgruner/deepl-api-rs
cargo run
sudo cp target/release/deepl /usr/local/bin/
which deepl
export DEEPL_API_KEY="this-is-my-key-get-your-own:aa"
echo "Recent Posts" | deepl translate --source-language EN --target-language FR | cat -
cat /home/jieiku/.dev/abridge/content/overview-markdown-and-style.md | deepl translate --source-language EN --target-language ES | cat -


Single file mode no longer working

This might be an upstream issue in Pyright, but I'd like to report it here first to see if others are experiencing the same or if there maybe is a workaround.
Since the last update or one of the last updates, the server is more or less non-functional if a file was opened in single file mode, i.e. with no folders in the sidebar. Instead, it constantly asks for workspace/configuration and logs

File or directory "\<default workspace root>" does not exist.

to the status bar.
If there are no workspace folders, LSP sends
'rootUri': None, 'rootPath': None, 'workspaceFolders': None,

as part of the InitializeParams, but this should be fine according to the specs. It seems like the server can't handle this anymore?

yeah the auto completion seems not working when single file mode

I created an upstream issue report https://github.com/microsoft/pyright/issues/8919

Should be fixed by https://github.com/sublimelsp/LSP-pyright/releases/tag/1.4.22 as per upstream's claim.


Improve determinant algorithm

Right now it uses cofactors, which is really slow. Should use echelon form + product of upper diagonal

Done! Cofactor expansion O(n!) -> REF O(n^3)


load_sample_data.sh fails to load sample data

Description

Loading sample data fails with this error:
DELETE 0
ERROR:  extra data after last expected column
CONTEXT:  COPY image, line 2: "0e3315c5-3328-4a99-80ab-567ac32f685f,2022-12-21 17:29:54.000000+00,2022-12-21 17:29:54.000000+00,pro..."
REFRESH MATERIALIZED VIEW
DELETE 0
ERROR:  extra data after last expected column
CONTEXT:  COPY audio, line 2: "8624ba61-57f1-4f98-8a85-ece206c319cf,2022-12-06 06:54:25.000000+00,2022-12-06 06:54:25.000000+00,pro..."
REFRESH MATERIALIZED VIEW

This appears to be related to the standardized_popularity addition to the sample data but the upstream_db tables not having that column:
openledger> \d image;
+-------------------------+--------------------------+--------------------------------------+
| Column                  | Type                     | Modifiers                            |
|-------------------------+--------------------------+--------------------------------------|
| identifier              | uuid                     |  not null default uuid_generate_v4() |
| created_on              | timestamp with time zone |  not null                            |
| updated_on              | timestamp with time zone |  not null                            |
| ingestion_type          | character varying(80)    |                                      |
| provider                | character varying(80)    |                                      |
| source                  | character varying(80)    |                                      |
| foreign_identifier      | character varying(3000)  |                                      |
| foreign_landing_url     | character varying(1000)  |                                      |
| url                     | character varying(3000)  |  not null                            |
| thumbnail               | character varying(3000)  |                                      |
| width                   | integer                  |                                      |
| height                  | integer                  |                                      |
| filesize                | integer                  |                                      |
| license                 | character varying(50)    |  not null                            |
| license_version         | character varying(25)    |                                      |
| creator                 | character varying(2000)  |                                      |
| creator_url             | character varying(2000)  |                                      |
| title                   | character varying(5000)  |                                      |
| meta_data               | jsonb                    |                                      |
| tags                    | jsonb                    |                                      |
| watermarked             | boolean                  |                                      |
| last_synced_with_source | timestamp with time zone |                                      |
| removed_from_source     | boolean                  |  not null                            |
| filetype                | character varying(5)     |                                      |
| category                | character varying(80)    |                                      |
+-------------------------+--------------------------+--------------------------------------+
Indexes:
    "image_pkey" PRIMARY KEY, btree (identifier)
    "image_identifier_key" UNIQUE, btree (identifier)
    "image_provider_fid_idx" UNIQUE, btree (provider, md5(foreign_identifier::text))
    "image_url_key" UNIQUE, btree (url)

Time: 0.024s

https://github.com/WordPress/openverse/pull/2096 adds the new column and sample data but it looks like the upstream db never gets the new column locally for some reason.
Reproduction

Add exit after the two calls to load_sample_data "<media type>" in load_sample_data.sh to avoid needing to scroll.

 `just down -v`

 `just api/up`

 `just api/init`

See the error:

Screenshots

Environment

Device:
OS:
Browser:
Version:
Other info:

Additional context

Critical because this mean tests are running with zero data and are therefore effectively useless.

False alarm, I needed to just rebuild upstream_db for it to get the new SQL schema files from #2096. No idea why though, as I fully rebuilt my local environment after that PR was merged. After rebuild I also had to just down -v and reup to get the new schema.
https://github.com/WordPress/openverse/issues/2364 replaces this issue to fix the underlying devex and beyond issue.


[Beta] Fix JSX diagrams

Mostly nits. It just didn't quite make sense.
Before:

After:

Should isLoggedIn be a function call since it's a function in the first diagram?

meh. i guess.

i'll update.