Excessive duplicate AWS API calls

Describe the bug
The Steampipe AWS plugin appears to be making excessive duplicate API calls when running well-formed SQL queries. This is causing queries to run much slower than they should.
Steampipe version (steampipe -v)
Steampipe v0.23.3
Plugin version (steampipe plugin list)
hub.steampipe.io/plugins/turbot/aws 0.116.0
To reproduce
I ran the Ensuring AMIs are from trusted sources sample query from this official blog post. In case the blog post gets updated, this is the exact SQL that I ran:
WITH instances AS (
  SELECT
    instance_id,
    instance_type,
    account_id,
    tags ->> 'Name' AS instance_name,
    _ctx ->> 'connection_name' AS account_name,
    instance_state,
    region,
    image_id
  FROM
    aws_ec2_instance
)
SELECT DISTINCT
  aws_ec2_ami_shared.image_id as image_id,
  aws_ec2_ami_shared.owner_id as image_owner_id,
  aws_ec2_ami_shared.image_owner_alias as image_owner_name,
  instances.instance_name,
  instances.account_name,
  instances.region,
  aws_ec2_ami_shared.name as image_name
FROM
  instances
LEFT JOIN aws_ec2_ami_shared ON aws_ec2_ami_shared.image_id=instances.image_id
WHERE aws_ec2_ami_shared.image_owner_alias != 'amazon'
  AND aws_ec2_ami_shared.image_owner_alias != 'self'

The query ultimately failed (for reasons that I suspect are not Steampipe's fault: it got a RequestExpired: Request has expired response from the EC2 API, indicating a clock skew issue), but it made at least 53,899 calls to ec2:DescribeImages as per CloudTrail. A lot of these were duplicates, e.g. see these screenshot of duplicate AMI lookups

Expected behavior
I would have expected Steampipe to deduplicate/cache these API calls and (presumably) for the query to be executed much faster.
Additional context
This query was executed against an aggregation of 225 AWS accounts and two AWS regions. I am not an SQL expert and I assume that the SQL query in the Steampipe blog is optimal.

Hello, @aidansteele,
I apologize for any inconvenience caused.
The issue you're experiencing with the aws_ec2_ami_shared table may be due to the lack of pagination in the API call (pagination wasn't supported earlier). According to the API documentation, it is strongly recommended to use only paginated requests. Unpaginated requests are susceptible to throttling and timeouts..
To address this, I have raised a PR that includes the following enhancements:

Implemented pagination for the API call.
Optimized query timing and the number of API calls by supporting batch operations, allowing multiple image IDs or owner IDs in a single API call.
Added support for owner_ids and image_ids to facilitate batch operations.
The query format to perform batch operations:

SELECT * FROM aws_ec2_ami_shared WHERE owner_ids = '["123456789089", "938475869606"]'
SELECT * FROM aws_ec2_ami_shared WHERE image_ids = '["ami-003a0d7f585604444", "ami-0038c1e63dd57df14"]'

Please note that the table design has not yet been finalized. In our environment, we have limited resources to test the performance of these changes. It would be greatly appreciated if you could test the PR branch (issue-2259) and share your observations.
Official blog post query(It should run more smoothly than before):
WITH instances AS (
  SELECT
    instance_id,
    instance_type,
    account_id,
    tags ->> 'Name' AS instance_name,
    _ctx ->> 'connection_name' AS account_name,
    instance_state,
    region,
    image_id
  FROM
    aws_ec2_instance
)
SELECT DISTINCT
  aws_ec2_ami_shared.image_id as image_id,
  aws_ec2_ami_shared.owner_id as image_owner_id,
  aws_ec2_ami_shared.image_owner_alias as image_owner_name,
  instances.instance_name,
  instances.account_name,
  instances.region,
  aws_ec2_ami_shared.name as image_name
FROM
  instances
LEFT JOIN aws_ec2_ami_shared ON aws_ec2_ami_shared.image_id=instances.image_id
WHERE aws_ec2_ami_shared.image_owner_alias != 'amazon'
  AND aws_ec2_ami_shared.image_owner_alias != 'self'

Taking advantage of batch operation:
with instances as (
  select
    instance_id,
    instance_type,
    account_id,
    tags ->> 'Name' as instance_name,
    _ctx ->> 'connection_name' as account_name,
    instance_state,
    region,
    image_id
  from
    aws_ec2_instance
),
all_image_ids as (
  select
    json_agg(image_id)::jsonb as image_ids  -- Cast to jsonb
  from
    instances
),
shared_ami as (
  select
    s.*
  from
    aws_ec2_ami_shared as s,
    all_image_ids
  where s.image_ids = all_image_ids.image_ids
)
select distinct
  shared_ami.image_id as image_id,
  shared_ami.owner_id as image_owner_id,
  shared_ami.image_owner_alias as image_owner_name,
  instances.instance_name,
  instances.account_name,
  instances.region,
  shared_ami.name as image_name
from
  instances
left join shared_ami on shared_ami.image_id=instances.image_id
where shared_ami.image_owner_alias != 'amazon'
and shared_ami.image_owner_alias != 'self';

Thank you for your understanding and assistance!

Hi @ParthaI, thank you for such a speedy response. My apologies for only getting back to you now.
I attempted to try your PR, but didn't have much luck and I suspect it's a user error on my behalf. This is what I did:
git clone https://github.com/turbot/steampipe-plugin-aws.git
cd steampipe-plugin-aws
git checkout issue-2259
make

I then verified that there was a new binary (based on last modified timestamp) at<EMAIL_ADDRESS>However, I ran the query and got this error:
> with instances as (
  select
    instance_id,
    instance_type,
    account_id,
    tags ->> 'Name' as instance_name,
    _ctx ->> 'connection_name' as account_name,
    instance_state,
    region,
    image_id
  from
    aws_ec2_instance
),
all_image_ids as (
  select
    json_agg(image_id)::jsonb as image_ids  -- Cast to jsonb
  from
    instances
),
shared_ami as (
  select
    s.*
  from
    aws_ec2_ami_shared as s,
    all_image_ids
  where s.image_ids = all_image_ids.image_ids
)
select distinct
  shared_ami.image_id as image_id,
  shared_ami.owner_id as image_owner_id,
  shared_ami.image_owner_alias as image_owner_name,
  instances.instance_name,
  instances.account_name,
  instances.region,
  shared_ami.name as image_name
from
  instances
left join shared_ami on shared_ami.image_id=instances.image_id
where shared_ami.image_owner_alias != 'amazon'
and shared_ami.image_owner_alias != 'self';
Error: column s.image_ids does not exist (SQLSTATE 42703)

I also tried inspecting the table and didn't see image_ids column, so I wonder if somehow I am not running the right plugin version?
> .inspect aws_ec2_ami_shared
+-----------------------+--------------------------+----------------------------------------------------------------------------------------------------------------+
| column                | type                     | description                                                                                |
+-----------------------+--------------------------+----------------------------------------------------------------------------------------------------------------+
| _ctx                  | jsonb                    | Steampipe context in JSON form, e.g. connection_name.                                                          |
| account_id            | text                     | The AWS Account ID in which the resource is located.                                                           |
| akas                  | jsonb                    | Array of globally unique identifier strings (also known as) for the resource.                                  |
| architecture          | text                     | The architecture of the image.                                                                                |
| block_device_mappings | jsonb                    | Any block device mapping entries.                                                                              |
| creation_date         | timestamp with time zone | The date and time when the image was created.                                                                  |
| description           | text                     | The description of the AMI that was provided during image creation.                                            |
| ena_support           | boolean                  | Specifies whether enhanced networking with ENA is enabled.                                                     |
| hypervisor            | text                     | The hypervisor type of the image.                                                                              |
| image_id              | text                     | The ID of the AMI.                                                                                |
| image_location        | text                     | The location of the AMI.                                                                                |
| image_owner_alias     | text                     | The AWS account alias (for example, amazon, self) or the AWS account ID of the AMI owner.                      |
| image_type            | text                     | The type of image.                                                                                |
| imds_support          | text                     | If v2.0, it indicates that IMDSv2 is specified in the AMI.                                                     |
| kernel_id             | text                     | The kernel associated with the image, if any. Only applicable for machine images.                              |
| name                  | text                     | The name of the AMI that was provided during image creation.                                                   |
| owner_id              | text                     | The AWS account ID of the image owner.                                                                         |
| partition             | text                     | The AWS partition in which the resource is located (aws, aws-cn, or aws-us-gov).                               |
| platform              | text                     | This value is set to windows for Windows AMIs; otherwise, it is blank.                                         |
| platform_details      | text                     | The platform details associated with the billing code of the AMI. For more information, see Obtaining Billing  |
|                       |                          | Information (https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ami-billing-info.html) in the Amazon Elastic  |
|                       |                          | Compute Cloud User Guide.                                                                                |
| product_codes         | jsonb                    | Any product codes associated with the AMI.                                                                     |
| public                | boolean                  | Indicates whether the image has public launch permissions. The value is true if this image has public launch p |
|                       |                          | ermissions or false if it has only implicit and explicit launch permissions.                                   |
| ramdisk_id            | text                     | The RAM disk associated with the image, if any. Only applicable for machine images.                            |
| region                | text                     | The AWS Region in which the resource is located.                                                               |
| root_device_name      | text                     | The device name of the root device volume (for example, /dev/sda1).                                            |
| root_device_type      | text                     | The type of root device used by the AMI. The AMI can use an EBS volume or an instance store volume.            |
| sriov_net_support     | text                     | Specifies whether enhanced networking with the Intel 82599 Virtual Function interface is enabled.              |
| state                 | text                     | The current state of the AMI. If the state is available, the image is successfully registered and can be used  |
|                       |                          | to launch an instance.                                                                                |
| tags                  | jsonb                    | A map of tags for the resource.                                                                                |
| tags_src              | jsonb                    | A list of tags attached to the AMI.                                                                            |
| title                 | text                     | Title of the resource.                                                                                |
| usage_operation       | text                     | The operation of the Amazon EC2 instance and the billing code that is associated with the AMI. For the list of |
|                       |                          |  UsageOperation codes, see Platform Details and [Usage Operation Billing Codes](https://docs.aws.amazon.com/AW |
|                       |                          | SEC2/latest/UserGuide/ami-billing-info.html#billing-info) in the Amazon Elastic Compute Cloud User Guide.      |
| virtualization_type   | text                     | The type of virtualization of the AMI.                                                                         |
+-----------------------+--------------------------+----------------------------------------------------------------------------------------------------------------+

Hi @aidansteele,
I apologize for the inconvenience. Upon reviewing the issue, I discovered that our current main branch has a bug, which is causing the plugin not to build correctly locally. To address this, I have raised a PR with the necessary fix. If you rebase the issue-2259 branch with remove-duplicate-columns, you should no longer encounter any errors.
Here are the steps to rebase:

git checkout issue-2259
git pull origin remove-duplicate-columns
make

Thank you for your understanding and patience!

Hi @aidansteele, FYI, the PR has already been merged into the main branch. Rebasing the branch issue-2259 with main should be good now.

Hello @aidansteele, Have you had a chance to look at the above comment again?

Hi @aidansteele
We haven’t heard back from you in a while, so we’re going to close this issue for now. If you’re still experiencing this problem or have additional information to share, please feel free to reopen the issue or create a new one.
Thank you for your understanding!


site not found

I followed Quick Start -> step 1), and renamed my repos, but when I visited it, it showed Site not Found,
my site

Oh, sorry. I have modified a post, and it worked fine.


[Documentation] update readme

This PR update the readme:

Asclepios -> Epione. By the way, Visages changed its name also, isn't it?
Remove the compilation steps to centralize on the final documentation. At the end, it would be on medInria website i think, but for now i put the new dev guide on Florent's github. It could be changed quickly as soon as a new one appears.
markdown links.
the copyright.

edit: guide dev issue: https://github.com/medInria/medInria-public/issues/498
:m:

I think it's a good idea to ask Maxime or Olivier about the validity of Athena and Parietal names

we keep them. I updated the medInria website last week.

The readme PR is updated with ex team names


Added local pre commit hook for python formatting

Resolves #7
Added a local pre-commit hook that uses yapf-diff to auto format the code before it is committed.
PLEASE TEST ON YOUR LOCAL MACHINE BEFORE ACCEPTING IT!
to test: install pre-commit and then use pre-commit install and autoupdate and then try to commit something
(I'll explain better as soon as I have the time)

Added the requirements to the setup.py so now you can install all needed requirements with
pip install cellpose[dev]

Ganzer workflow siehe auch : https://pre-commit.com


Potential optimization for big structs

Maybe we should consider changing this line inside Emplace()
https://github.com/Wsm2110/Faster.Map/blob/7e1fb1ee10443cb520ce3e2a1108be0990de304a/src/DenseMapSIMD.cs#L244
to
 ref readonly var entry = ref GetArrayValRef(_entries, indexAndOffset);

and this line inside Get()
https://github.com/Wsm2110/Faster.Map/blob/7e1fb1ee10443cb520ce3e2a1108be0990de304a/src/DenseMapSIMD.cs#L351
to
ref readonly var entry = ref GetArrayValRef(_entries, index + Unsafe.As<int, uint>(ref offset));

This way we can avoid copying large entries (when we have large TKey and/or TValue) from the _entries array. What do you think?

fixed


New release for fix #37

Since #37 has been merged, would it be possible to get a new release ?

Version 2.1.1 has been released.

Thanks a lot


Colour of Reality affects the past

Changing the filter of an ArrowOfColour causes an ArrowOfReality to retroactively apply its effects.
https://github.com/TodePond/Arroost/assets/33520919/30028ede-bd16-4a49-aa8e-78d904c7cfc9
The expected behaviour would have the pulse only go through when the ArrowOfColour is white or green, as is the case when using a simple loop instead of a Reality.
https://github.com/TodePond/Arroost/assets/33520919/d682b9c2-a9c4-4b4b-9413-e31ceab3e5cb

I think the way I approached implementing Reality was kinda completely wrong. I added some special cases for it, but really it can be implemented by using multiple cells 'under the hood' of the entity.

whats a reality??


Update PADL documentation in README.md

Extra things to improve on the documentation:
https://github.com/lf1-io/padl/issues/453
https://github.com/lf1-io/padl/issues/454

Other things to improve on README:
https://github.com/lf1-io/padl/issues/448


[RLMObjectStore] Allow properly updating linked objects with primary keys

Closes #1362.
Successor to https://github.com/realm/realm-cocoa/pull/1810, but with out the cyclical object graph support.
Basically, this PR fixes the issue by fetching a persisted object when trying to update a link in createOrUpdate
\c @tgoyne @jpsim @bdash

CI failure was due to insufficient free space on the slave.
Needs changelog, but otherwise :+1:

:+1: assuming the CI failure is still unrelated.

Changelog entry needs to be bumped up, but otherwise :+1:. Nice work!


LoRa/SX1276: adjust Rx window offset and duration

After a transmission, two receive windows Rx1 and Rx2 are opened for one second each, one right after the other, after a fixed delay (for example 5s). The Rx window offset is added to the starting date of each window and the Rx window duration represents the maximum delay we will wait for an incoming message before declaring that a timeout occurred.
A value of -500ms for the offset and 800ms for the duration means that instead of having Rx1 = [5000, 6000[ and Rx2 = [6000, 7000[ we get Rx1 = [4500, 5300[ and Rx2 = [5500, 6300[. We only cover 30% of the expected windows.
The maximum time a SX127x can take before the Rx side is ready is TS_HOP + TS_RE = 50µs + 2.33ms. Using 3ms for the offset and 1003ms for the duration will give much better time windows: Rx1 = [4997, 5997[ and Rx2 = [5997, 7000]. Note that the
lorawan-device crate caps Rx1 end date to Rx2 start date.
This change allows a previously failing Murata CMWX1ZZABZ-091 module (STM32L + SX1276) to connect to the TTN LoRa network.

Note that the same issue exists in the SX126x code but I have no way to check the fix so I've left it untouched.
The issue also exists for the STM32WL code, but since there the window duration is set to 3000ms (instead of the expected 1000ms) the Rx2 window is covered in full so the second transmission (during Rx2) will be received. However, the chip will listen on Rx1 frequencies only during the first half of the expected Rx1 window. This makes it very inefficient as it will systematically wait for the Rx2 window, and if there is nothing to receive the radio will be on for a total time of 4s instead of 2s.

Thanks for the PR. The current values are derived from a bit of trial-and-error with a STM32 Lora Discovery board. I'm happy to see some more correct numbers. I will give it a try before merging, but looks good in general.

Worked for me!
bors r+


Avoid setters on injected services

There is no need to have setters on injected fields, as AemContext can handle this for us.
I had to rewrite the unittests to make that work, but IMHO they look much nicer now :-)

Pull Request Test Coverage Report for Build 5537

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.003%) to 56.652%

Totals

Change from base Build 5529:
-0.003%

Covered Lines:
15454

Relevant Lines:
27279

💛  - Coveralls

Thanks @joerghoh !


Fix #143 - Put 'dark' class on html as soon as possible

Description
Move the initial logic that calculates the color preference outside Next.JS flow to a dedicated script
Fix https://github.com/FrancescoXX/rustcrab/issues/143
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Test Required (Yes / No)
If Yes then How Has This Been Tested?

[ ] Open DevTools
[ ] Go to performance tab
[ ] Click on the gear of the tab (below the "x" that closes the dev tools)
[ ] Put a CPU throttle (I tested with 20x slowdown)
[ ] refresh the page
[ ] no light flash appear

Test Configuration:

Platform: (Linux/Windows/Mac)
Architecture: (x86/x64/Arm/Amd)..
Version: 1.x.x

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

New Features

Introduced automatic dark mode detection based on user preferences, improving the visual experience.

Bug Fixes

Updated handling of dark mode state in the Header component to prioritize user settings.

Refactor

Simplified dark mode management in the Header component by removing complex and unnecessary logic, enhancing component performance.

thanks, please solve the conflicts

Conflicts resolved


Make use of AerPauliExpectation for gradients, quantum Fisher information

What is the expected enhancement?
Make sure AerPauliExpectation can be used for gradients, QFI, etc

While the code allows to use AerPauliExpectation, it currently gives wrong results due to a bug in the expectation values if coefficients in the state function are involved -- as is the case for gradients.

With Qiskit/qiskit-terra#6497 merged, this issue is resolved.
The AerPauliExpectation now yields the correct values, see this plot which shows the absolute difference between gradients calculated exactly (using the matrix expectation) again Pauli and AerPauli:

and here's a small runtime comparison (not including matrix expectation because that scales way too bad and reaches the 40s mark already for 12 qubits):


optionally make AbstractDataVec be like an R factor

There should be a way to enforce a fixed set of pool items in a DV, and to optionally flag the ordering as important. It may also be useful to have meta-data for constrast construction -- or maybe this isn't the appropriate place for it (cf. R).

@nalimilan, is this covered by your work in CategoricalArrays.jl now?

Yes, it's so old that I'm not even sure what this issue was about.


Support // @ts-nocheck for lint like checks like --noUnusedLocals

TypeScript has compiler options for several lint style checks like noUnusedLocals. For such checks it can be desirable to turn them of for a specifc location in the code. Now that there is support for // @ts-nocheck comments, this comment should also be support for the lint style options TS supports.

From the compiler perspective there is no difference between the errors that the --noUnusedLocals enable and any other errors.
We have talked about disabling errors multiple times and never reached a conclusion to add such support. we believe that all TS errors are warnings by definition (do not block emit), and that disabling some would leave your program in an inconsistent state and would negatively impact the whole experience. Moreover we believe that there are already in place language constructs that enable fixing the errors instead of silencing them.
That said, I know that features like --noUnusedLocals, --noUnusedParameters, --noImplicitFallThrough, and noImplicitReturn are rather style checks and not just type checks. but they are opt-in, and users can just switch them off all together and maybe rely on a linter rule (which tslint has removed, but i would argue can put back). and in the case of --noUnusedParameters an _ prefix disables the checking all together.
One alternative here is for these style options (--noUnusedLocals, --noUnusedParameters, --noImplicitFallThrough, and noImplicitReturn), their value could be true | false | "warn" to control the error severity.
Similar discussion can be found at https://github.com/Microsoft/TypeScript/issues/9448

There's currently no way to fix fallthrough though; maybe we should recognize a // falls through comment like tslint does.

@alexeagle has strong opinions in this area.

At Google, we've spent a lot of time working through how we present the "severity" of findings from compilers and linters. We have a paper hopefully publishing soon in CACM (I can forward a copy if you're interested).
Basically, we found that developers ignore existing warnings in the code, then that warning blindness extends to new warnings. To combat this, we only present newly introduced warnings. Compilers don't know what has changed, because it would be a layering violation for them to read info from the VCS. Therefore we found that compilers should never produce "warnings" - more precisely, if the compiler "accepts" the program, it should not produce any additional output asking developers to take some optional action.
We turned off all warnings from all compilers (I worked on the Java one quite a bit) and re-implemented the ones we care about as errors, or else left them for a linter. We're doing the same for TypeScript now.
A linter is different - you can hook it up later in the developer workflow, where you do have context from the VCS, and can show only the newly introduced things.
So I believe TypeScript should avoid non-fatal diagnostics (and unused variable was a mistake).
I would love to discuss it further!

(I can forward a copy if you're interested).

please do.

I mailed a copy to Mohamed - sorry I can't post publicly yet since it's
pending publication.
On Wed, May 24, 2017 at 2:51 PM Mohamed Hegazy<EMAIL_ADDRESS>wrote:

(I can forward a copy if you're interested).
please do.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/15953#issuecomment-303861974,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC5I7hmGggEd7NE4Zv0plWw8s7WtB81ks5r9KZWgaJpZM4NgmtR
.

+1

closed in favor of https://github.com/Microsoft/TypeScript/issues/13408. please see https://github.com/Microsoft/TypeScript/issues/13408#issuecomment-335256365 for the current action plan.


Some moniors load without a title on mobile and display ... instead.

⚠ Please verify that this bug has NOT been raised before.

[X] I checked and didn't find similar issue

🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
Often when I open my status page on my mobile device, some of the monitors fail to load the name which just shows ... then. I've attached a screenshot below so you can see what I mean. I've also checked all logs and neither my nginx reverse proxy nor the application itself log anything if that happens. The status also seems to work fine and shows the correct bars, just the name is not displayed.
It's not always the same item, but by chance it seems to affect some of them more often than others. This also happens on multiple browsers (I tested Chrome, Firefox) on Android and also on Safari. I'd say the chance that some of the names become ...  is about 80% (out of ~15 items). On my desktop system I've also experienced this issue, but only once over the past week, so definitely a lot less likely. It also seems to happen more often on a mobile connection than in my WiFi.

👟 Reproduction steps
Opening any of the status pages on a mobile device on mobile data triggers this very frequently.
👀 Expected behavior
Name should be fully shown.
😓 Actual Behavior
Name is shown as ....
🐻 Uptime-Kuma Version
1.18.0
💻 Operating System and Arch
Gentoo ~amd64
🌐 Browser
Firefox for Android 103.2.0
🐋 Docker Version
Running on Bare Metal
🟩 NodeJS Version
18.9.0
📝 Relevant log output
[No specific log output generated]

Duplicated of https://github.com/louislam/uptime-kuma/issues/2100


Autotests: Structure creating&editing - selection tool

selection tool - 5 TC

closing because it was duplicated


chore: Update README about maven migration

[WIP]
Notice in README (structure copied from Tomo's changes in synthool)
Does this update in the README also need to be put in all the LTS branches?

Update the CONTRIBUTING.md to remove Gradle references.


update Cart.php

Dispatch an event after function calculateItemsTax() is finished.

@SteffenMahler
We can add before event too.

@jitendra-webkul
Done.


Add auto merge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/aproc-feedstock#2.


adding new rebus

No issue #
Summary of Changes

added new rebus

Pull Request Test Coverage Report for Build 1037

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.143%

Totals

Change from base Build 937:
0.0%

Covered Lines:
158

Relevant Lines:
180

💛  - Coveralls


chore: Add ESLint Prettier config

@jeffwilcox, this might be too early in your refactoring work to add, but you can always copy the .eslintrc.js, .prettierrc.json, and package.json changes when you ready, then run the npm run fix on you cleanup branch

@nschonni I appreciate the offer!
I think if we could keep this PR open for now, it would help... I think we're going to want to take the prettier config and get it running internally first (we have a lot of Microsoft-specific code we hold back in specific directories right now), and then bring it forward here.
If you had a few minutes to submit just the actual config changes, but not touching all the random files, I'd be happy to merge that pull request once we're ready, vs this PR, if that works?


flow_from_directory loads corrupted Images, how to prevent it?

While using keras' flow_from_directory to load a dataset (using ImageDatagenerator), I encounter some error while calling the method fit_generator. This is because there is/are some image(s) file(s) that is/are corrupt in my data directory.
How can I check what image is corrupted or how can I tell flow_from_directory or fit_generator to drop examples that raise and exception?

I suggest you try to open the images with PIL and remove the image if it raises an exception.

That's a solution yeah. I wonder if I could just define that method and pass it somehow to ? flow_with_directorybecause it is really useful to use the data augmentation provided by theImageDataGenerator` class


control nav to center in IE

How to center bullets in IE?
.nivo-controlNav {
position:absolute;
left:0;
bottom:-30px;
text-align:center;
width:100%;
}
.nivo-controlNav a {
width:10px;
height:10px;
background:url(Images/bullets.png) no-repeat;
text-indent:-9999px;
border:0;
margin-right:3px;
display:inline-block;
}
This work fine in FF, Chrome, but not IE.

I found the solution, and it's relevant for any number of images, the only inconvenient is that you'll have to use jQuery, but I guess that won't be a problem cause Nivo already works with jQuery ^^' ... anyways ...
Based on this css code :
.nivo-controlNav {
    position: absolute;
    left: 50%;
}

I could come up with this javascript code, I'll explain it later :
$(document).ready(function() {
    $('#slider').nivoSlider();

    var numberImages = $('#slider img').length;
    var bulletWidth = 22;
    var margin = - ( (numberImages * bulletWidth) / 2 );
    $('.nivo-controlNav').css('margin-left', margin+'px');
});

What this basically means is that, instead of giving each slider's controlNav a random margin-left based on the number of images, we'll calculate that, and the way to do that is very simple :

We MOVE the left edge of our controlNav to 50% (CSS)

Next we have to know the width of the WHOLE controlNav, which contains bullets of course :

numberImages * bulletWidth

Divide all this by 2, and then remove it from the margin-left, this simply means : move the controlNav by half of its width to the left.
Hope it works for you :)


Fix comparison in DataCollatorForCompletionOnlyLM (#588)

What does this PR do?
Fixes https://github.com/lvwerra/trl/issues/588
This PR fixes issue https://github.com/lvwerra/trl/issues/588 encountered in the DataCollatorForCompletionOnlyLM class. Originally, the class compared self.response_token_ids with examples[i]["input_ids"], which caused a RuntimeError under certain circumstances.
This PR changes the comparison target to batch["labels"][i] from examples[i]["input_ids"] and add unit tests.
The added unit test reproduces the bug reported in the issue. Additionally, I have confirmed that the changes I made cause the added unit test to pass.
Before submitting

[x] make precommit
[x] Add tests

Please review and let me know if any changes are required.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Dependency update

You say in the webpage that we need a specific version of Inkscape to be able to use Inka, however, https://gitlab.com/inkscape/inkscape/-/merge_requests/5033 was already merged on master 5 months ago, and instead of relying on a job artifact, you can use master pipelines from the official website or even 1.3 builds, which should be even more stable and do contain the fix already (81ade70db89bbe3883b68c61f0ceb075bb53b1fe).
This is not a website issue, but rather a dependency issue.

I'd not recommend using master currently, but 1.3 will be released tomorrow evening.


Add pub(crate) visibility

Problem
We support the pub attribute when defining a function, so that the function is visible everywhere externally and internally.
We could extend it with the pub(crate) notation which would allow the function to be used inside the crate, but not in an external crate.
Happy Case
pub(crate) makes a function visible within the current crate.
Alternatives Considered
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
No
Support Needs
No response

Also tagging along pub(crate) and pub for structures, but we may want this in another issue


Rest url subpath not working

Hello !
So got a problem with rest server repo initialization.
When I try to initialize a repo with a subpath on a restic-rest-server it doesn't work.
For example :

restic init -r rest:http://mydomain.io/foo

restic init -r rest:http://mydomain.io/bar

restic init -r rest:http://mydomain.io/

These commands have the same effect and create data in the base root server side.

As you can see on the screenshot this is a client side problem.

The generated post request always requesting :
post http://mydomain.io/?create=true

instead of
post http://mydomain.io/{subpath}?create=true

I voluntary disable server side to prompt this error. So it is not a server side problem but a client problem.
When I send by myself post request to the server with postman, it's work perfectly.
With postman ==> post http://mydomain.io/toto?create=true

Can you confirm and fix this issue ?
Thank you =)

Closing this issue as this is a usage problem and we got no feedback within a month. Feel free to comment if this issue isn't resolved with my reply yet.


Figure out a better way to keep the beacon alive

The beacon currently runs on a schedule; GitHub Actions disables scheduled workflows after 60 days of repository inactivity.
As a result: if nobody commits to this repo in a 60 day window, the beacon's scheduled job stops running and repos that test using the Sigstore conformance suite begin to fail. For example, the timeout failures in https://github.com/sigstore/sigstore-python/pull/702.
Some ideas:

Maybe there's some way to get this repository excluded from the scheduled workflow expiration rule. CC @steiza?
Maybe we can "cheese" things here and have a periodic job that also commits to the repo, to keep the workflows active.

As a resolution here, we'll start with (2).

Happened again: https://github.com/sigstore/sigstore-conformance/issues/117

Maybe we can "cheese" things here and have a periodic job that also commits to the repo

My previous attempt at making the token more easily available via Pages failed (see #8) but I had another idea for that: commiting the current token to git and maybe force pushing a tag/branch that points to the current-token-commit (re-using the tag/branch to avoid polluting git checkouts too much). It sounds like a hack but it might be a two-birds-with-a-single-commit type of hack...

I like that idea!
(@steiza: do you happen to know if machine commits to a branch count for resetting the workflow  expiration countdown? I know Dependabot commits/PRs do, but that might only be because they get merged by a human.)

I ran into this when monitoring the log, because the repository only contains a workflow that never commits. I found https://github.com/marketplace/actions/keepalive-workflow as a potential solution, though I haven't tried it out yet.

I don't know yet if #17 makes sense but it might accidentally fix this one


Update JavaDocs

Summary
Hello,
thank you for creating this advanced library for BLE scanning based on RxJava.  I am trying to look through your code to get inspiration on how to use it in my own project, and to understand it better.  I am wondering - can you add more JavaDocs throughout your code?  At least on the public methods.  As it stands, the code is very sophisticated and not trivial to follow.  Furthermore, RxJava has a high learning curve, which adds necessity to have better documentation throughout the codebase.

Preconditions
Look through the existing code.

Expected result
There need to be JavaDocs on public members.

Hello @IgorGanapolsky
Thanks for the insight. I will add your request to my TODOs. Besides: which public methods do not have JacaDoc? I am trying to keep at least the API as documented as possible.

The interface of OperationPriorityFifoBlockingQueue is just a wrapper for a PriorityBlockingQueue intended to use with operations — it is a quite simple class. RxBleRadioImpl is basically a worker which is responsible for serializing operations and RxBleClientImpl is the implementation of the entry point to the library. Anything in particular is hard to comprehend? On which things should I concentrate describing?

@dariuszseweryn Essentially putting what you just said in a JavaDoc comment for class declarations would be great.  It may seem intuitive and straightforward to smart engineers like you :), but believe me - this code is very non-trivial for newbies to BLE and those who not experts in RxJava.  Additionally, each public method having a JavaDoc comment would make it a lot clearer to follow.

Skip the flattery. ;) I know that diving into code that was written by others is not easy. I will try to add more comments and JavaDoc when I will have a moment.

I sympathize. The project I'm on has involved simultaneously learning Android, RxJava, and BLE. I think "drinking from a firehose" is an apt way to put it :-)  Additional documentation is always a welcome thing.

Sorry, but also, are the javadocs hosted anywhere?

@kenwdelong they are available in the .aar you get from the Maven repository.


parse images

Current coverage is 97.63%

Merging #11 into master will increase coverage by +1.43% as of 170ca91

@@            master     #11   diff @@
======================================
  Files           29      30     +1
  Stmts          580     592    +12
  Branches         0       0
  Methods
======================================
+ Hit            558     578    +20
  Partial          0       0
+ Missed          22      14     -8

Review entire Coverage Diff as of 170ca91

Uncovered Suggestions

+0.34% via src/DataObject.php#59...60
+0.34% via ...ks/BlockContinue.php#12...13
+0.34% via ...ckParagraphStart.php#22...23
See 7 more...

Powered by Codecov. Updated on successful CI builds.


Non secured command (java exception)

Describe the bug
When you want to type "/money deposit" ArrayIndexOutOfBoundsException throws in the console. Error occurs at "MoneyExecutor.java:66".
To Reproduce
Steps to reproduce the behavior:

Type '/money deposit' in game

Expected behavior
It should display for ex. "Correct usage: /money deposit ".
Screenshots

Desktop (please complete the following information):

Server Type: [e.g. PaperMC, Spigot]
Server Version: [e.g. 1.17.1-386]
Gringotts Version: [e.g. 2.12.2]

Hello @Serafinowy. That is really interesting :)
Do you have Vault as part of the plugins?

Yes, I have all required plugins and the error only occures when you type '/money withdraw/deposit' without any other arguments.


FastsurferCNN on Ubuntu

Question/Support Request

I'm trying to run FastSurfer CNN for segmentation on my unbuntu. I was able to build docker container for CPU using your instructions given in example 4. But, there seems to be some problem running the program. When I execute the following  error:

Total Dataset Size is 2
Running Fast Surfer on 005.mgz
Traceback (most recent call last):
File "/venv/lib/python3.8/site-packages/nibabel/loadsave.py", line 42, in load
stat_result = os.stat(filename)
NotADirectoryError: [Errno 20] Not a directory: '/data/005.mgz/005.mgz'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "eval.py", line 535, in
input_image = nib.load(invol)
File "/venv/lib/python3.8/site-packages/nibabel/loadsave.py", line 44, in load
raise FileNotFoundError(f"No such file or no access: '{filename}'")
FileNotFoundError: No such file or no access: '/data/005.mgz/005.mgz'
The program creates the correct output folder structure at /home/nayan/Documents/fastsurfer/fastsurferCNN_results/sub005/005.mgz/mri/orig.
But, there is no output files in there. Any clue what might be going wrong?
Environment

FastSurfer Version: ... sudo git clone https://github.com/Deep-MI/FastSurfer.git

Execution

sudo docker build --rm=true -t fastsurfercnn:cpu -f ./Docker/Dockerfile_FastSurferCNN_CPU .

Run Command:
sudo docker run -v /home/nayan/Documents/sub005/mri/orig:/data -v /home/nayan/Documents/fastsurfer/fastsurferCNN_results/sub005:/output --rm --user 1004 fastsurfercnn:cpu --i_dir /data --in_name 005.mgz --o_dir /output --out_name mri/aparc.DKTatlas+aseg.deep.mgz --log deep_surfer.log --no_cuda

Hi @Bhagyasree-knauparthi there should be no need to build your own docker images. Just use our stable released ones from docker hub, e.g. docker pull deepmi/fastsurfer:cpu-v1.1.1 . Building your own is for developers or testers of the dev version, which can be broken at any point.  And when calling it try this (or similar):
docker pull deepmi/fastsurfer:cpu-v1.1.1
docker run   -v /home/nayan/Documents/sub005/mri/orig:/data \
                      -v /home/nayan/Documents/fastsurfer/fastsurferCNN_results:/output \
                      --rm --user 1004 fastsurfer:cpu-v1.1.1 \
                      --t1 /data/005.mgz \
                      --sid sub005 --sd /output \
                      --no_cuda --seg_only

and make sure that the file /home/nayan/Documents/sub005/mri/orig/005.mgz exists on the host system. Once this works, you can try the CNN-only container (we also have that on Docker : docker pull deepmi/fastsurfer:segonly-cpu-v1.1.1 but I would need to lookup the flags for calling it.

Hi @Bhagyasree-knauparthi.
In case you are building the docker image from the current stable FastSurfer, the example you followed demonstrates processing multiple subjects within /data in $SUBJECT_DIR/mri/orig.mgz sub-directories.
In your case, you are processing a single subject and the image seems to be located in $SUBJECT_DIR/mri/orig/005.mgz.
You could either:

Run a --simple_run for a single subject; note that you need to specify --in_name, --out_name, and --conf_name file paths. For example:

docker run -v /home/nayan/Documents/sub005/mri/orig:/data \
           -v /home/nayan/Documents/fastsurfer/fastsurferCNN_results/sub005:/output \
           --rm --user 1004 fastsurfercnn:cpu \
           --in_name /data/005.mgz --out_name /output/mri/aparc.DKTatlas+aseg.deep.mgz \
           --conf_name /output/mri/orig.mgz --log deep_surfer.log --simple_run

Run the same command but with an adjusted --i_dir as in the following:

docker run -v /home/nayan/Documents/:/data \
           -v /home/nayan/Documents/fastsurfer/fastsurferCNN_results/sub005:/output \
           --rm --user 1004 fastsurfercnn:cpu \
           --i_dir /data --in_name mri/orig/005.mgz --o_dir /output \
           --out_name mri/aparc.DKTatlas+aseg.deep.mgz --log deep_surfer.log

(Note that in the second case the program will look for all sub-directories of /data that contain $SUBJECT_DIR/mri/orig/005.mgz and process them sequentially, so it's recommended that you have a dedicated directory that contains only the subject directories.)
Let us know if this does not resolve your issue.

thanks for the reply, It is working for me
On Thu, 13 Oct 2022 at 13:53, Martin Reuter @.***>
wrote:

Hi @Bhagyasree-knauparthi https://github.com/Bhagyasree-knauparthi
there should be no need to build your own docker images. Just use our
stable released ones from docker hub, e.g. docker pull
deepmi/fastsurfer:cpu-v1.1.1 . Building your own is for developers or
testers of the dev version, which can be broken at any point. And when
calling it try this (or similar):
docker pull deepmi/fastsurfer:cpu-v1.1.1
docker run   -v /home/nayan/Documents/sub005/mri/orig:/data
-v /home/nayan/Documents/fastsurfer/fastsurferCNN_results:/output
--rm --user 1004 fastsurfer:cpu-v1.1.1
--t1 /data/005.mgz
--sid sub005 --sd /output
--no_cuda --seg_only
and make sure that the file /home/nayan/Documents/sub005/mri/orig/005.mgz
exists on the host system. Once this works, you can try the CNN-only
container (we also have that on Docker : docker pull
deepmi/fastsurfer:segonly-cpu-v1.1.1 but I would need to lookup the flags
for calling it.
—
Reply to this email directly, view it on GitHub
https://github.com/Deep-MI/FastSurfer/issues/200#issuecomment-1277227866,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3SVF2FVK7EKTJVDRGJTGS3WC7BHZANCNFSM6AAAAAARD77PKI
.
You are receiving this because you were mentioned.Message ID:
@.***>


[Dynamic Form][3.17] Required Field Validation won't work

Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
Please specify what version of the library you are using: [  3.17      ]
Expected / Desired Behavior / Question
Dynamic Form should stop submission if there is any empty required field.
However this functionality won't work as expected after I upgraded to 3.17
Observed Behavior
[Dynamic Form] changed a lot in new version. I noticed that it will still submit item even the required field is empty
Steps to Reproduce

Choose a list which has a required field (e.g. title)

Put "Dynamic Form" in the spfx form customization, no special settings.

     <DynamicForm
          context={this.props.context}
          listId={this.props.context.list.guid.toString()}
          listItemId={this.props.context.itemId}
          onSubmitted={(listItemData: any) => {
            console.log(listItemData);
              setTimeout(() => {
                this.props.onSave();
              }, 1000);
          }}
          onListItemLoaded={async (listItemData: any) => { // eslint-disable-line @typescript-eslint/no-explicit-any
            console.log(listItemData);
          }} />

Launch it, and leave this required field empty and save it.

You will see you created a new item which keep this required field empty

Trouble Shooting
This is due to the latest "Dynamic Form" changed a lot of things.  The initial value of "field.newValue" is "undefined" not "null"

I will do more testing on it.

@wuxiaojun514 , the fix for this has finally been merged, apologies for the long delay.
The fix is now included in the beta release, please let us know if there are any issues.


[Grid] Issue - can columns be a responsive prop?

Seems like the columns prop of Grid should be a responsive prop, unless I'm missing something? Happy to contribute a PR if it helps?
https://www.radix-ui.com/themes/docs/components/grid#api-reference

Not sure if I was using an older version when I raised this, but I can see this is a responsive prop, so this is just a docs issue

We'll update this in the docs for 3.0.0


Change the size of the region (which has nested regions) does not work

I'm trying to increase the administrative region with a shovel. This region has a nested 3d region. A message is displayed on the intersection region.
Try to expand, says that intersects with another region. And refers to the nested region. https://i.imgur.com/jV41Bmz.png
forge-1.12.2-<IP_ADDRESS>11-universal.jar
spongeforge-1.12.2-2611-7.1.0-BETA-2970.jar
griefprevention-1.12.2-<IP_ADDRESS>4.jar
LuckPerms-Sponge-4.1.43.jar
Video: https://youtu.be/jPnjywAPwfo
The logs were not preserved. But there were no mistakes.

claiminfo:
big region (2d) https://i.imgur.com/XOUi9G3.png
region (3d) https://i.imgur.com/nWhemAq.png
It's my fault. I created the region wrongly. Did not use the command /claimsubdivide.
But then I don't understand how I was able to create a 3d region (admin) inside a 2d region (admin). Perhaps this need to prevent!?

Rediscover. Still. I would like to be able to change the size of the administrative region with the nested administrative region. It is possible to fix?

There is a bug that allows you to create an admin claim within an admin claim. You need to use a 3D subdivision instead.


Feature/wa provider

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.004%) to 14.294%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/api/sms/gupshupWhatsapp/gupshupWhatsapp.service.ts
0
4
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/api/sms/gupshupWhatsapp/gupshupWhatsapp.service.ts
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>0:
0.004%

Covered Lines:
414

Relevant Lines:
2588

💛  - Coveralls


Fix storage backend ID for TypeInstance from nested workflow

Description
Changes proposed in this pull request:

fix storage backend ID for TypeInstance from nested workflow

There was incorrect backend mapping - we find it by the name of output Type Instance relation which is ok where there is no nested workflow. In the nested workflow, we need to find it by the name of the artifact.
Testing

Checkout this PR
Create cluster using DISABLE_MONITORING_INSTALLATION=true USE_TEST_SETUP=true make dev-cluster
Change manifests source to my branch with no backend for psql:

kubectl set env deploy/capact-hub-public -n capact-system -c hub-public-populator MANIFESTS_SOURCES="github.com/mkuziemko/hub-manifests?ref=lost_bid"

Install Helm Storage and Mattermost
Verify uploaded TypeInstaces.

Related issue(s)

https://github.com/capactio/capact/issues/705

I saw you branch with manifests changes, unfortunately it doesn't cover the whole story. Here is a valid fix to our manifests: https://github.com/capactio/hub-manifests/compare/main...mszostok:test-706?expand=1
I tested that with your change, and unfortunately I got such error:
Cannot render given action: while rendering Action: while adding TypeInstances to graph: while resolving backend ID for "mattermost-install-install-db-postgres-install-helm-install-helm-release": cannot find backend storage for specified "helm-release-storage" alias (will retry - 13/15)

Please let me know if you need more info about my setup.

Good point :+1:
We don't need the alias for these manifests as we don't use it in the main workflow. I updated my fork.
The above error was caused by:
typeInstancesBackends, err := r.policyEnforcedCli.ListTypeInstancesBackendsBasedOnPolicy(ctx, rootimpl.Rule, rootimpl.Revision)

In the rendering we are checking if we have:
if step.CapactAction != nil {

based on which we are searching implementation and rules but for the looking of the backends, we passed always the ,,root" implementation which does not work for nested workflows.
Thus,  when you removed the aliases from the Mattermost manifests, it couldn't resolve the backend.
Anyway, I verified it one more time installing Postgres and then the Mattermost, and it works.


Littering the logs + black regions on the ungenerated regions

What happened?

Minecraft Version
1.20.4
Modloader (Fabric/Forge)
Fabric
World-Preview Version
1.1.5
Minecraft Logs
I posted the logs on the screenshot
Additional Information
update the issue template

Thanks for the information! Fixed that in Version 1.3.1 with a scheduled release for tomorrow!


"Mușcel" is listed in the drop-down menu

Description:
"Mușcel" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Mușcel" in the search bar.

Expected results
The location is listed in the drop-down menu as "Mușcel, Argeș (Boteni)".


ArgumentOutOfRangeException when removing a tab from a group with a document tab

In an application with a document tab and some other docking content.
Drag another window into the 'centre' square of the document tab to create a group with the two of them, and then drag it out again, and an exception results.
The content of the document tab is not drawn, and the 'strip' at the top of the document tab is drawn as red crosses.
NOTE - this was found during testing on a slow VM, but couldn't be recreated from the debugger on a faster development machine.
Screenshot of the failed state and exception is attached

We may have stopped the issue from happening just observing symptoms without fully understanding it.
At some point in the past, we started running a custom FloatWindow for the Extender.FloatWindowFactory that disables floating window's close button
        protected override CreateParams CreateParams
        {
            get
            {
                CreateParams myCp = base.CreateParams;
                myCp.ClassStyle = myCp.ClassStyle | CP_NOCLOSE_BUTTON;
                return myCp;
            }
        }

We believe that after the change we started having the "Red X" problem (referenced here as well) after content windows are hidden as described issue #310
The "Red X" is consistently present and can be easily recreated.
After disabling the docked content close button as well in DockContent's subclasses' constructors
this.CloseButtonVisible = false;

the problem in #310 appears to have stopped for our end users. The problem in #310 could not be recreated by development.

In some rare cases, the index parameter can be -1 due to some unknown reasons. I modified VS2012DockPaneStrip.EnsureDocumentTabVisible to check against -1. So maybe we should do the same for VS2005DockPaneStrip.

Should cherry pick https://github.com/DavidBasnett/dockpanelsuite/commit/2d4758ef9dae62d9777390346b9eb25e62a87d76

We are still in 2005 skin. Stopped the issue as described, porting fixes to that is very much appreciated.

Finished.

thank you and thank you for working on 2.11.


v3.3.388 Release

pull for v3.3.388 release

In general, I think these are really good additions. Just two questions:

Why does the DBC release version not match the build number?
Did the firmware actually change the bus speed or were the launch files just incorrect previously?

@JWhitleyAStuff

DBC release version just needs to be updated.  This PR was submitted ahead of that happening.
Firmware has been at 500k, the launch files were incorrect.

Thanks for the update. Can you comment on my other PR?

Actively working on it now.  Getting a build error on my side, so I want to setup CI before going further.
-Ryan
From: Joshua Whitley<EMAIL_ADDRESS>Sent: Monday, June 17, 2019 12:13 PM
To: NewEagleRaptor/pacifica-dbw-ros<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [NewEagleRaptor/pacifica-dbw-ros] v3.3.388 Release (#9)
Thanks for the update. Can you comment on my other PR?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/NewEagleRaptor/pacifica-dbw-ros/pull/9?email_source=notifications&email_token=AISWFJDPYZBKPPYOSCPO76LP26ZZ7A5CNFSM4HOXI3W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX3VX6Y#issuecomment-502750203, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AISWFJCL7MVVAXSLJRBEJX3P26ZZ7ANCNFSM4HOXI3WQ.


Changing title in config.toml leads to non function of app entry

I tried creating a direct launcher for games using the Lutris config as base, everything works so far except the moment i change the title in my config it breaks and the app wont get started.
this is the used config entry:
[[apps]]
icon_png_path = '/etc/wolf/shared/lutris/share/covers/paper-mario-the-thousand-year-door.png'
start_virtual_compositor = true
title = 'Lutris'

    [apps.runner]
    base_create_json = '''{
  "HostConfig": {
    "IpcMode": "host",
    "CapAdd": ["NET_RAW", "MKNOD", "NET_ADMIN", "SYS_ADMIN", "SYS_NICE"],
    "Privileged": false,
    "DeviceCgroupRules": ["c 13:* rmw", "c 244:* rmw"]
  }
}
'''
    devices = []
    env = [ 'RUN_SWAY=1', 'GOW_REQUIRED_DEVICES=/dev/input/event* /dev/dri/* /dev/nvidia* /var/lutris/', 'XKB_DEFAULT_LAYOUT=de', 'LUTRIS_ARGS=lutris:rungame/paper-mario-the-thousand-year-door']
    image = 'ghcr.io/games-on-whales/lutris:edge'
    mounts = [ '/etc/wolf/shared/lutris:/var/lutris/:rw', '/etc/wolf/shared/ryujinx:/home/retro/.config/Ryujinx/:rw' ]
    name = 'WolfLutrisGameLauncher'
    ports = []
    type = 'docker'

here a small video of the whole thing:
https://github.com/user-attachments/assets/1db37863-c410-452e-8446-9e869cae4d4a
here the backtrace:
dump.zip

If you change title you need to also change corresponding folder name in /etc/wolf/<userid>/<title>.

Thanks @csrednicki that was indeed the issue, we've discussed this in Discord with @Skerga  so I'll close this here.


Add JoinMarket

Add JoinMarket (CoinJoin Service)

I wrote a guide here: https://community.getumbrel.com/t/guide-installing-joinmarket-using-cli/3240


Swap product to watch list from add2cart on product detail

Pressing the Watch product button on the add2cart panel on the product detail page currently runs addToCart('{% url 'shop:watch-list' %}', {watch: true}). If on the modal you then hit one of the proceed buttons, the product will be added to the watch list (quantity = 0) only if not already in the cart (quantity > 0).
If the product is already in the cart and the user presses Watch product, essentially nothing happens.
I would expect the product to be removed from the cart and switched to the watch list (quantity = 0), as it does when you hit the Watch item button in the cart.
Is this a bug and is there an easy way to fix it? I've been looking through the code and it looks non-trivial.. It looks like I need to do a http PUT with cart_item.quantity set to 0 to {% url 'shop:cart-detail' %} (+ /product.id) like this does:
// put a cart item into the watch list
$scope.watchCartItem = function(cart_item) {
	cart_item.quantity = 0;
	postCartItem(cart_item, 'PUT');
}

.. but I think it would be cleaner to handle this in the watch-list serializer keeping the angular code in catalog.js as-is, but I can't seem to find where in the code this is handled..

If the product is already in the cart and the user presses Watch product, essentially nothing happens.
I would expect the product to be removed from the cart and switched to the watch list (quantity = 0), as it does when you hit the Watch item button in the cart.

You mean, if you are on the detail view of a product page and click watch product, instead of buy product?
Yes this is intentional. You can not have a product both in the cart, as well as in the watch-list. For me is is hard to imagine a valid and real world use-case for this, since it would confuse customers.
Something I agree on, is that a customer might want to remember stuff he bought. Here it might make sense to add a checkbox on each cart item labeled "Remember for next purchase". Then on checkout, those items would be re-added to the watch list.

Yes detail view of product page and click watch product when the product is already in the cart.
I absolutely agree the product shouldn't be in both watch list and cart at the same time (I like the quantity=0 solution), but I would expect the product to move from cart to watch list.
I don't think it's necessary to add such a checkbox: I would expect a customer to look back through their list of orders to remember what they bought. A related feature: I intend to implement mailing list subscriptions for products, and I think it would make sense to have a user checkbox for "items in the watch list" and "items I have purchased"

I would expect a customer to look back through their list of orders to remember what they bought.

A checkbox to re-add items to the wish-list would make a lot of sense on each Detal Order View. It would be quite easy to implement.
What do you mean with "mailing list subscriptions for products"? How should that work?

I've added two fields on the customer model:
subscription_newsletter = models.BooleanField(_("Subscribe to Newsletter"), default=False,
        help_text=_("Email subscription"))
subscription_watchlist_status = models.BooleanField(_("Subscribe to Product Status Changes"), default=False,
        help_text=_("Email subscription"))

The 2nd one I intend to use the customer's watch list as a subscription to individual product updates. As I said before, another one could be a subscription for "items I have purchased" which would get its data from the order history.

This would be a great third party app for django-SHOP.
Since the Customer model must be overridden anyway, one could use that from the app.
Creating newslettes and sending them, could also be added to that app.
An async trigger could compares the Cart's updated_at against the updated_at from products and then creates information emails for customers.


feature add a const parameter to control the cache version

Proposed changes
Add a const parameter to control the cache version:
IFileCache::USE_FIE_VERSION2 = true;

Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.79 seconds
stream load tsv:          468 seconds loaded<PHONE_NUMBER>9 Bytes, about 152 MB/s
stream load json:         37 seconds loaded<PHONE_NUMBER> Bytes, about 60 MB/s
stream load orc:          75 seconds loaded<PHONE_NUMBER> Bytes, about 14 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230306023300_clickbench_pr_108939.html


Removed extra info.plist

I see that here they also removed fork the project file.
https://github.com/HomebaseAI/Atlas-iOS/commit/ee49e6ed12c364173f43e659e8570a0ba736d1ec

Yes, they removed the plist even in the "real" repo.


Update Settings “general”

Automatically generated by Netlify CMS

👷 Deploy Preview for theaiodyssey processing.

Name
Link

🔨 Latest commit
22021380b7d454430327f66f89667ddb86069206

🔍 Latest deploy log
https://app.netlify.com/sites/theaiodyssey/deploys/6664786dd415a700083cfea4


Fixes #550: MySQL dialect doesn't work when connection is specified by using the QueryBuilder

If still needed send a new pull request.


Add support for highlight.js terraform syntax highlighting

Extend the highlight.js syntax highlighting by adding support for the terraform package: https://github.com/highlightjs/highlightjs-terraform

Unfortunately it's not available in npmjs, so baking the support in would require shipping the highlightjs-terraform.  Not sure if this is a problem or not, but would prefer to avoid doing this.
So for now at least the solution is to add support for this via an extension like the one attached here.  So just unzip this somewhere and add a --extension-file command-line arg that points at it.
terraform.zip

The solution in my previous comment doesn't work in the case of the extension not residing within marked-it-cli's directory hierarchy.  I've fixed this case by defining a proper extension point in marked-it-cli for extensions to provide syntax styling functions.
To make this work, get the marked-it-cli 0.23.0 release, and replace the content of the previous comment's terraformExt.js file with:
var definition = require("./terraform").definer;

function getAdditionalLanguages() {
    return {terraform: definition};
}

module.exports.styling = {code: {syntax: {getAdditionalLanguages: getAdditionalLanguages}}};
module.exports.id = "terraform";


Netflix not playing videos on Linux build 3.3.0

When I try to play the video from Netflix it does not work:

Also, is there a way to hide menu bar?

@jjnilton Can you share the log? It would help a lot.

@jjnilton Chrome 57 makes it much harder to locate plugin files so I think I have to remove WideVineCDM in the upcoming update to keep the development forward.

@quanglam2807 where can I find the logs?
From developer tools I could get the console log when I try to play the video:
[Report Only] Refused to load the script 'chrome-extension://pkedcjkdefgpdelpbcmbmeomcjbeemfm/cast_sender.js' because it violates the following Content Security Policy directive: "default-src https: 'unsafe-inline' 'unsafe-eval'". Note that 'script-src' was not explicitly set, so 'default-src' is used as a fallback.

r @ cast_sender.js:3
cast_sender.js:3 Mixed Content: The page at 'https://www.netflix.com/browse' was loaded over HTTPS, but requested an insecure script 'chrome-extension://pkedcjkdefgpdelpbcmbmeomcjbeemfm/cast_sender.js'. This request has been blocked; the content must be served over HTTPS.
r @ cast_sender.js:3
cast_sender.js:3 [Report Only] Refused to load the script 'chrome-extension://fjhoaacokmgbjemoflkofnenfaiekifl/cast_sender.js' because it violates the following Content Security Policy directive: "default-src https: 'unsafe-inline' 'unsafe-eval'". Note that 'script-src' was not explicitly set, so 'default-src' is used as a fallback.

r @ cast_sender.js:3
cast_sender.js:3 Mixed Content: The page at 'https://www.netflix.com/browse' was loaded over HTTPS, but requested an insecure script 'chrome-extension://fjhoaacokmgbjemoflkofnenfaiekifl/cast_sender.js'. This request has been blocked; the content must be served over HTTPS.
r @ cast_sender.js:3
cast_sender.js:2 [Report Only] Refused to connect to 'chrome-extension://boadgeojelhgndaghljhdicfkmllpafd/cast_sender.js' because it violates the following Content Security Policy directive: "default-src https: 'unsafe-inline' 'unsafe-eval'". Note that 'connect-src' was not explicitly set, so 'default-src' is used as a fallback.

p @ cast_sender.js:2
cast_sender.js:2 XMLHttpRequest cannot load chrome-extension://boadgeojelhgndaghljhdicfkmllpafd/cast_sender.js. Cross origin requests are only supported for protocol schemes: http, data, chrome, https.
p @ cast_sender.js:2
cast_sender.js:2 [Report Only] Refused to connect to 'chrome-extension://dliochdbjfkdbacpmhlcpmleaejidimm/cast_sender.js' because it violates the following Content Security Policy directive: "default-src https: 'unsafe-inline' 'unsafe-eval'". Note that 'connect-src' was not explicitly set, so 'default-src' is used as a fallback.

p @ cast_sender.js:2
cast_sender.js:2 XMLHttpRequest cannot load chrome-extension://dliochdbjfkdbacpmhlcpmleaejidimm/cast_sender.js. Cross origin requests are only supported for protocol schemes: http, data, chrome, https.
p @ cast_sender.js:2
cast_sender.js:2 [Report Only] Refused to connect to 'chrome-extension://enhhojjnijigcajfphajepfemndkmdlo/cast_sender.js' because it violates the following Content Security Policy directive: "default-src https: 'unsafe-inline' 'unsafe-eval'". Note that 'connect-src' was not explicitly set, so 'default-src' is used as a fallback.

p @ cast_sender.js:2
cast_sender.js:2 XMLHttpRequest cannot load chrome-extension://enhhojjnijigcajfphajepfemndkmdlo/cast_sender.js. Cross origin requests are only supported for protocol schemes: http, data, chrome, https.
p @ cast_sender.js:2
cast_sender.js:2 [Report Only] Refused to connect to 'chrome-extension://fmfcbgogabcbclcofgocippekhfcmgfj/cast_sender.js' because it violates the following Content Security Policy directive: "default-src https: 'unsafe-inline' 'unsafe-eval'". Note that 'connect-src' was not explicitly set, so 'default-src' is used as a fallback.

p @ cast_sender.js:2
cast_sender.js:2 XMLHttpRequest cannot load chrome-extension://fmfcbgogabcbclcofgocippekhfcmgfj/cast_sender.js. Cross origin requests are only supported for protocol schemes: http, data, chrome, https.

@jjnilton That's the one I'm looking for.
I am sorry but Google removes chrome://plugins so now it's quite difficult for me keep updating the Chrome plugins. I may have to remove Netflix support in the next update :(

@jjnilton I'm sorry. It's official, WidevineCDM together with Netflix will be removed.

Ok @quanglam2807, thank you. Let's hope there will be some workaround in the future.


Remove date from articles

@bruskiza & @saeedmb8 please review, tiny.
I object to this change though, I think articles should be dated.

:+1:  when travis comes back + (which it will)

One travis build passed, the other's stuck it seems, landing.


[5.6] Enhance retry helper function

I often find an exponential retry function is preferred over a constant rate - perhaps others does as well.
These minor changes give the opportunity for both use cases by increasing the sleep and factor parameter.
I believe this change is a non-breaking change but I might be wrong. The default values give the same result as the current retry function.

Thanks for the PR. I think having an exponential backoff is actually not a good default for the retry function. Perhaps it should be another function if we want to have it in the core at all.

No plans to add right now. Feel free to release as a package.


poetry update

chore: poetry update
chore: poetry update

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.37%. Comparing base (f3fd5ec) to head (0dc5b25).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   91.37%   91.37%
=======================================
  Files           6        6
  Lines         255      255
  Branches       55       55
=======================================
  Hits          233      233
  Misses         12       12
  Partials       10       10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add script to setup Linux laptops, again.

Hi,
I know you dropped Linux support a long time ago (https://github.com/thoughtbot/laptop/blob/3897ad81ee241cbff4501e779c8cde50de79e142/linux).
Nevertheless every other year I come back to orientate myself at the Mac-script about new/changed tooling and/or approaches in the Ruby world, and than applying it manually on my Linux box.
This time I took the extra mile to put it in a Linux-script and would be happy, if you accept the Pull-request.
Please be aware of following Mac- vs. Linux-script differences, which might not be obvious from first look into README ... The Linux-script

aims just on Debian/ Ubuntu based distros
uses 'bash' instead of 'sh', cause on Linux machines

you face "/bin/sh -> dash", so source of scripts does not work and
$HOME/.asdf/completions/asdf.bash would not work either

has helper functions condensed at the top and slightly adjusted
makes mainly use of official Linux repositories, but also

adds some other repositories for docker, heroku, rcm and yarn packages
gives additional flexibility with Linuxbrew

installs docker-ce natively
has some TODO marks for possible improvements

I am open for suggestions to adjust.
Happy week,
best harm/

This was removed in the past because while we have some people running linux on the team, none were particularly interested in maintaining laptop for that environment. They ran different distros or had different tastes. I can't see that changing in the near future. I'm hesitant to take this on knowing we don't have anyone committed to maintaining it.
I think this makes the most sense to maintain as a fork that we could potentially link to if it remains loosely up-to-date with out practices.

Hi Derek, thanks for the feedback, I see your point.
Feel free to link that repo https://github.com/netzfisch/devbox for a linux reference.


-watch option

Is your feature request related to a problem? Please describe.
I want to preserve HMR development experience while using scss-bundle.
Describe the solution you'd like
I need a -watch mode so that if I make any changes, scss-bundle automatically detects it and runs itself again.
Describe alternatives you've considered
csskit has watch option for bundling but it's only for css, not scss.

This feature is implemented in v2.5.0-beta version.
You can download it:
$ npm install scss-bundle@next

I am using it in my application, and it is wonderful!
Thanks so much for the swift turnaround.
:V:

When 2.5.0 will be released?

@JanneHarju I think we can release full (not beta) version, because we haven't got any issues with watch option.

Thanks a lot @MartynasZilinskas . You should also update your documentation about this new option.

@JanneHarju Thanks for pointing out. Updated 👍


Returns 404, with correct config

For a private repository on Bitbucket Cloud (https://bitbucket.org), the resource returning

stderr:
curl: (22) The requested URL returned error: 404

My resource looks like this.
      base_url: https://bitbucket.org
      username: my-user-name
      password: my-password
      project: project-name
      repository: repo-name
      bitbucket_type: cloud
      git:
        uri<EMAIL_ADDRESS>        private_key: <>

The example are not so clear in the README, what I am missing or making mistake?

git:
        uri<EMAIL_ADDRESS>        private_key: <>

I'm not really familiar with bitbucket.org, but only a SSH endpoint uses the private_key.
a HTTPS should use user:pass

Just figured this out, on BitBucket Cloud, the API path that the project builds is wrong.
Currently: uri="${base_url}/api/2.0/repositories/${project}/${repository}/pullrequests?limit=${limit}&state=OPEN"
Correct: uri="${base_url}/2.0/repositories/${project}/${repository}/pullrequests?limit=${limit}&state=OPEN"
Going to PR this change

Just figured this out, on BitBucket Cloud, the API path that the project builds is wrong.
Currently: uri="${base_url}/api/2.0/repositories/${project}/${repository}/pullrequests?limit=${limit}&state=OPEN"
Correct: uri="${base_url}/2.0/repositories/${project}/${repository}/pullrequests?limit=${limit}&state=OPEN"
Going to PR this change


Make ConfigItem short_option optional (#4136)

#4136
Also cleaned up the specs

Looks good to me. Thanks! 👍


[TESTS] Enable UT for CONNECTION level engine shared.

    ❨?❩
Trying to enable UT for CONNECTION level engine shared.

LGTM, as it did not exceed Travis build timeout

LGTM, as it did not exceed Travis build timeout


on_payment_verified

Please, i cant get "on_payment_verified" function to work after payment

Yes, the verify_payment function where the signal is being sent requires 'request=request'

ok, thanks for the reply. How can i add 'request=request'. Thanks.

I also have the same issue, how can I add request=request for the user @Fawaz441

Thanks for the tutorial, it was much helpful.
However, can i have a clue as to how to make the details gets stored in the transaction history table or where can i write the save function?

hello @Fawaz441 , can you help out

in paystack/views.py

in paystack/views.py

Thanks for this,
I got it working to this point unfortunately after a successful payment, i couldn't output the any json data  just as it is in this picture attached.
What should I do  or is it a webhook thing?

You have json installed?

yes i do

could it be because i am using the test api secret and public keys from paystack and not the live api  public keys

@Fawaz441 is it possible if I can contact you bro<EMAIL_ADDRESS>

Sure you can get me on WhatsApp<PHONE_NUMBER>7
On Saturday, May 30, 2020, austinogiza<EMAIL_ADDRESS>wrote:

@Fawaz441 https://github.com/Fawaz441 is it possible if I can contact
you bro<EMAIL_ADDRESS>—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gbozee/pypaystack/issues/14#issuecomment-636313754,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALU43X52DUBZ4KVM4PIIP6TRUDQO3ANCNFSM4M5HTJQQ
.

@Fawaz441 is it possible if I can contact you bro<EMAIL_ADDRESS>
Hi, I am having a namespace issue


[tmux] Added Force UTF-8 configuration option

Hi! I've added an option to force enable utf8 usage in tmux, since quite a big number of people is putting utf8 enabling line into their tmux.conf file. That change might make it a little bit more convenient.

@d1823 Can you please rebase this PR onto our latest master branch. Then update this PR with a Commit please? Thank You!


:sparkles: Add roundingMode to variable.display in YAML

@sophiamersmann it actually worked out of the box. I checked this example and the values are in metadata JSON. Is that all we have to do?
TODO before merging

[ ] undo changes to cherry blossom

ps: What does the pattern <% mean? (Just wondering if I forgot to implement something)

That's ETL thing. Sometimes we use dynamic Jinja templates in metadata with <% tags so we allow it in JSONschema too.


Add compression-by-filesystem as an option

Several filesystems (btrfs, zfs) have transparent compression support. On those filesystems it would make sense to use the kernel-side compression instead of an explicit per-pack compression.

For Btrfs (and also zfs) this is done with chattr +c file on the command line (unnecessary if the compression mount option is given).


add sphinx extension to generate a list of all contributors

ref https://allcontributors.org/

@all-contributors please add @tkoyama010 for code


style: styling profile route according to tailwind ui multi-column di…

Closes #71 (some part of it)
Description
Styling profile route according to match tailwind ui multi-column directory.
Current Tasks

[x] Create a new app/route/dashboard/profile.tsx file as a route shell rendering nothing other than Remix's Outlet component
[x] Create a new app/route/dashboard/profile/index.tsx file rendering the profile details section of this Multi-column directory screen
[x] Write end-to-end tests for testing above functionality.

The display part of profile data that should be pulled from the db is not in this code yet. Trying to learn about e2e test first..

If it's too complicated to merge my changes to you new branch, you can always start over from the main branch and create a new branch, then perform the same changes that is expected for this ticket, Mas @febrifahmi. 😁

If it's too complicated to merge my changes to you new branch, you can always start over from the main branch and create a new branch, then perform the same changes that is expected for this ticket, Mas @febrifahmi. 😁

maybe later I'll try it.. in my last commit I think the base code is already synced with the upstream main.. but somehow the e2e test always failed at some points. I already tried playwright codegen and it seems ok when I'm navigating around.. but yes the code generated not implemented yet in my commit.


Soft-warn about application default credentials using gcloud credentials

Due to user issues with quota and API enablement, the auth libraries should issue a soft warning (that can be silenced) when application default credentials uses user credentials from the Cloud SDK. They should not warn if the credentials for the cloud sdk are service account credentials.
Your application has authenticated using end user credentials from Google
Cloud SDK. We recommend that most server applications use service accounts
 instead. If your application continues to use end user credentials from Cloud
SDK, you might receive a "quota exceeded" or "API not enabled" error. For
more information about service accounts, see
https://cloud.google.com/docs/authentication/.

Additional context:
https://groups.google.com/a/google.com/forum/#!topic/client-auth-team/DKqrFw6lL1Q
https://buganizer.corp.google.com/issues/64388723
https://github.com/GoogleCloudPlatform/google-auth-library-python/pull/266

Side note - it's unclear to me if this belongs here or in the Go OAuth2 client.  Feel free to move if needed :)

Changing to P2, don't think this will be resolved within the next week, especially considering 4th July holiday.

We decided offline not to implement this feature. Closing this for now, give a shout if you want to re-open to discuss again.


I keep getting the error of android toolchain and Android sdkmanager tool not found

I use 'flutter doctor' and it comes out with this error.
Android toolchain - develop for Android devices (Android SDK version 29.0.3)
X Android license status unknown.
Try re-installing or updating your Android SDK Manager.
See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed
instructions.
Then I use 'flutter doctor --android-licenses' and I keep uninstalling and reinstalling android studio at least 5 times. Which sdk tools is actually necessary for flutter to work? Did I link the SDK wrongly?
Android sdkmanager tool not found (C:\Users\hille\AppData\Local\Android\sdk\tools\bin\sdkmanager).
Try re-installing or updating your Android SDK,
visit https://flutter.dev/setup/#android-setup for detailed instructions.
By the way, when I try to run my project, it cannot find runner in main.dart. What does it mean?

I have the same issue, it seems to be that flutter is looking for the sdkmanager at the wrong location.
Trying: D:\Softwares\Android\Sdk\tools\bin\sdkmanager
Actual Location: D:\Softwares\Android\Sdk\cmdline-tools\latest\bin\sdkmanager
Hope this helps!

I have the same issue, it seems to be that flutter is looking for the sdkmanager at the wrong location.
Trying: D:\Softwares\Android\Sdk\tools\bin\sdkmanager
Actual Location: D:\Softwares\Android\Sdk\cmdline-tools\latest\bin\sdkmanager
Hope this helps!

Actually found the solution, it's there on the flutter installation page.

I have the same issues.
When running android studio, go to config SDK Manager and uncheck hide Hide Obsolete Package below.

I already have that option.

I manage to fix it! Apparently SDK manager is also missing despite re-downloading so many times ==
If can't see SDK tools in your SDK manager in your Android Studio
Please download it manually from https://developer.android.com/studio
Open link and scroll the all way down until you see Command line tools only
Download Windows Zip if you're on Windows and extract this zip and paste the tools in your SDK
Then open Android Studio and go to Android SDK >SDK Tool(second tab), uncheck obsolete packages and download Android SDK Tool(Obsolete).
Thank you all for the help! XD


Scraping issue

Version of the custom_component
latest
Configuration
  - resource: https://nl.aliexpress.com/item/4001153556759.html?spm=a2g0o.productlist.0.0.3aeb247cFy9b09&algo_pvid=62e38723-9293-4ae1-b5e0-d7b1ced983c4&algo_exp_id=62e38723-9293-4ae1-b5e0-d7b1ced983c4-19&pdp_ext_f=%7B%22sku_id%22%3A%2212000028958252228%22%7D&pdp_npi=2%40dis%21EUR%2180.2%2150.52%21%21%21%21%21%40210318b916662641818561551e438b%2112000028958252228%21sea&curPageLogUid=Af7uSZStoLSP
    scan_interval: 28800
    sensor:
      - unique_id: price_blitzwolf
        name: Blitwolf plugin Price
        select: "span.uniform-banner-box-price"
        unit_of_measurement: "€"
        value_template: "{{ value }}"

Describe the bug
Cannot find the selector. However, using google inspector it works just fine.
Debug log

2022-10-20 13:43:21.888 DEBUG (MainThread) [custom_components.multiscrape.sensor] Scraper_noname_5 # Blitwolf plugin Price # Start scraping to update sensor
2022-10-20 13:43:21.891 DEBUG (MainThread) [custom_components.multiscrape.scraper] Scraper_noname_5 # Blitwolf plugin Price # Tag selected: None
2022-10-20 13:43:21.891 ERROR (MainThread) [custom_components.multiscrape.sensor] Scraper_noname_5 # Blitwolf plugin Price # Unable to scrape data: Could not find a tag for given selector
2022-10-20 13:43:21.891 DEBUG (MainThread) [custom_components.multiscrape.sensor] Scraper_noname_5 # Blitwolf plugin Price # On-error, set value to None
2022-10-20 13:43:21.891 DEBUG (MainThread) [custom_components.multiscrape.entity] Scraper_noname_5 # Blitwolf plugin Price # Updated sensor and attributes, now adding to HA

Please use the forum for questions about css selectors. There can be all kind of reasons and most likely it's not a bug.


docs: add example of string enum

close #1034

Please add it also to the next docs too (./docs/docs)

Thanks!


Does not work when using ECMAScript modules (ESM)

There seems to be an issue when using this library from a Node.js or Deno project that uses ESM.
 Uncaught (in promise) TypeError: AppStoreConnectAPI is not a constructor

Reproduction: https://stackblitz.com/edit/appstore-connect-api-issue
I figured out that the fix is to use module.exports = AppStoreConnectAPI instead of exports = AppStoreConnectAPI. I will see if I can find the root cause, and submit a PR.

Doesn't seem very easy: https://stackoverflow.com/questions/40294870/module-exports-vs-export-default-in-node-js-and-es6
I would recommend publishing this library in ESM format or move away from the default export.
I will try to find a different library for now.

Created a possible fix, since I couldn't yet find another JS library that works for me. It is a breaking change for CommonJS users though...


align coreos repo address with other OS

@anhou @lanchongyizu @pengz1

+1

:+1:
@amymullins This PR might cause the OS install test failing in Jenkins. http://rackhdci.lss.emc.com/job/Continuous-Test/job/OS-Install-Jobs/job/CoreOS/

@amymullins @keedya :
The purpose of this PR is just to align with all other OSes, in the sample of other OSes use the repo address "http://:/", but only CoreOS uses "http://:/repo/", the additional repo directly will cause user to pay special attention on CoreOS repo setup if user wants to directly use our sample payload.
I have examined the CIT test code, it always overwrite the repo address with what CIT setups, so I think there will be no impact on CIT, but I am not sure I have covered all aspects, please advise if there is something missing.
You could decide whether let this PR in, my opinion is to let in in the consideration of user friendly.

@lanchongyizu and @yyscamper thanks for the heads up!  The PR is expected to pass given this value is overwritten by this line:
https://github.com/RackHD/RackHD/blob/master/test/tests/api/v1_1/os_install_tests.py#L269
Should be no problem to merge this PR.

adding  @BillyAbildgaard

adding coreOS to Pr gate
test this please

BUILD RackHD #1407 : ABORTED

** BUILD SmokeTest-FIT  #853: SUCCESS
** BUILD Install-CentOs-6.5  #838: SUCCESS
** BUILD SmokeTest-CIT  #1047: ABORTED
** BUILD Install-ESXI-6.0  #282: SUCCESS
** BUILD Install-CoreOS  #1: ABORTED
** BUILD Install-Ubuntu-14-04  #816: SUCCESS

test this please

BUILD RackHD #1408 : ABORTED

** BUILD SmokeTest-FIT  #855: SUCCESS
** BUILD Install-CoreOS  #2: ABORTED
** BUILD SmokeTest-CIT  #1049: SUCCESS
** BUILD Install-Ubuntu-14-04  #818: SUCCESS
** BUILD Install-CentOs-6.5  #840: SUCCESS
** BUILD Install-ESXI-6.0  #284: SUCCESS

Thanks @amymullins @keedya @BillyAbildgaard : When I design the progress notification for CoreOS, I also found the CoreOS installation wasn't stable, it often hung. I only tested in InfraSim, never try physical hardware, is that

@amymullins @keedya @BillyAbildgaard : thanks for you quick action and quick answer.


Question: project status

Hello @kazzkiq, thanks for the awesome project!
Could you say what status of the CodeFlask is? Some PR's #105, #98 and issues #96, #102 are opened for a very long time. What will be done with them?
It is a nice idea #110 pass external highlighter. It seems to be useful. What do you think about it? Maybe do not completely remove Prima and add build without it (codeflask-core.js for example)
Any way to add or fix something we need the actual tests that runs in the current stable version of node. I did it in #117.
Can I assume that the project is frozen (I hope no) and I need to create fork and do whatever I want?
I appreciate any feedback.

Hi @petersolopov.
The project is not frozen. It just reached a stable status where most features got covered without sacrificing performance and bundle size.
There are however some improvements to be made, like the PRs and Issues you mentioned. And I will take a closer look at them.


Extend component to have artnet universe in config

This adds a configuration option to set the artnet universe within the configration file.

Hups, this should contain only one commit


Unable to clone from some SSH services

I am unable to clone a repository from Visual Studio Team Services via SSH as objective-git fails with
Error Domain=GTGitErrorDomain Code=-1 "Failed to clone repository from ssh://git2go@git2go.visualstudio.com:22/MyFirstProject/_git/git2go-com to file:///.../ssh/_git/git2go-com/" UserInfo={NSLocalizedDescription=Failed to clone repository from ssh://git2go@git2go.visualstudio.com:22/MyFirstProject/_git/git2go-com to file:///.../ssh/_git/git2go-com/, NSUnderlyingError=0x7ff7d1f2a1d0 {Error Domain=GTGitErrorDomain Code=-1 "Failed to start SSH session: Unable to exchange encryption keys" UserInfo={NSLocalizedDescription=Failed to start SSH session: Unable to exchange encryption keys}}}

When I clone the same repository with the same keys via command-line git it clones successfully, which means the key is valid and there is something wrong with how we handle SSH authentication.
There are other installations of git servers with SSH that have problems as well, but I was unable to reproduce them.
Visual Studio fails reliable so I thought I would open an issue. I know that @tiennou worked on the SSH implementation, but maybe someone else has insights into this topic as well?

It seems to fail inside _libssh2_kex_exchange, but I honestly have no idea why. There have been some sightings of that error (from the PHP bindings), but they're year-old. There's this, 1 year old, with some steps on debugging, so you might try that and get more information out of libssh2

I suspect somethings wrong on our Objective-C side as it is working for Working Copy which uses libgit2 directly. I will do some digging how the other adapters handle SSH connections.

Just noticed that, given the recent TLS-pocalypse, it might be related to us tracking an old version of libssh2 at the time this was filed. Does it still happen with current master ?

AFAIK there are no libgit2 reports that seem to point to a missing key exchange/support from the currently in-use libssh2, and since this report is pretty old, let's say it's now fixed 😉.


Why no alignment at all?

I cloned the code, prepared data according to README, and just updated:

ljspeech data path in config/LJSpeech/train.yaml
unzip generator_LJSpeech.pth.tar.zip to get generator_LJSpeech.pth.tar
and the code can run!
But, no matter how many steps I trained, the images are always like this and demo audio sounds like noise:

Hi @mikesun4096 , thanks for your attention. Yeah, the issue has not been resolved yet. Will update the repo if I could get a correct result.

Thank you for reply, looking forward to good news!

Hi @mikesun4096 , thanks for your attention. Yeah, the issue has not been resolved yet. Will update the repo if I could get a correct result.

Thank you for reply, looking forward to good news!


History being kept of embedded(?) things

I'm finding that history is being kept for certain things, even after closing the tab they were viewed in. I want to say these are embedded things, but I'm not sure if that's the correct terminology. Two examples that I personally encountered are:

Clicking on a tweet on twitter. You know where it pops up and you can see all the replies. The URL of that tweet is kept in my history
I use the reddit extension RES, which lets me expand any image post and zoom in without actually having to click on the post or open the image in a new tab. Doing this is keeping either the image URL or direct post URL in my history

I am not sure if related but recently closed tabs also seem to be kept. This is very strange because they sometimes appear in the history list, and sometimes do not. Also, if they do appear and you try to restore them with Ctrl+Shirt+T, they are restored in a wrong order.

@vizualize Sorry for the delay. I'll investigate this.
@tomasz1986 This is due to changes in Chrome. I've just released a new version that allows users to revert back to the old method of disabling history. But note that the old method causes issues with the back/forward navigation functionality in Chromium 67+. This release is currently under review by Google.

I am using Chromium 69 right now and strangely enough the back/forward navigation seems to be working  again with the legacy method :astonished:. Could anyone else confirm?


Upgrade plugin API and embedding to work with Flutter v2

This branch contains @maxzod 's changes as well.

MERGE!!!

For anyone waiting for a merge here, feel free to use my forked repo in your pubspec.yaml like this:
    advance_pdf_viewer:
        git:
            url: https://github.com/enveraltin/pdf_viewer.git

Cheers.

@enveraltin i'm getting force close when i load file from url.

@enveraltin i'm getting force close when i load file from url.

Are you testing on a device without GMS, by any chance? A Huawei device, perhaps?

@enveraltin
I just got the same error. The stack trace is mentioned in this issue #86
My device was Pixel XL API 30 (android-x86 emulator). It was fine on iOS Simulator. Kindly help me since I can neither upgrade nor downgrade. I am stuck for update release.

Hi @lohanidamodar here is the PR request that us not moving forwrd to fix some of the issues;I'll also tag you in another two open issues.


hello-world.

Hi

echo "# Bthos1" >> README.md
git init
git add README.md
git commit -m "first commit"
git branch -M main
git remote add origin https://github.com/Bthos1/Bthos1.git
git push -u origin main


Developing a many-to-many network?

Hello! I've watched the official video on ESP-Now (https://www.youtube.com/watch?v=QmvMtgNs9r8) and have a few questions about the details:

The example in the video shows a one-to-many relationship between devices, where a single keypad is changing 255 lights. Is it possible to design the network so that the nodes are all peer to each other and any node can send a message to any other node?

How many devices can be paired together into a many-to-many network? The video shows 255 lights but the documentation talks about keeping peers under 20 devices.

Can new devices be paired with the entire network at once, or do I have to pair the new device individually with each existing device? As in, can a new device be paired once and quickly become "aware" of the entire network of devices and start sending messages to them even if they weren't directly paired?

At 4 minutes 22 seconds in the video they mention developing a multi-hop network, but I haven't been able to find anything about this in the documentation. How does the multi-hop network functionality work?

Lastly, at 6 minutes and 31 seconds they show a web interface for debugging. Is it possible to get that web interface? I don't see the source for it anywhere.

Thanks for your help!

The keypad sends broadcast packets to lights, and the lights can also forward the message to more lights.

If send unicast packets to a device, the sender should add the device to peer and keeping peers under 20 devices. If not send unicast packet, like in the project, mainly in broadcast packet, the sender just need add broadcast peer and send broadcast to many lights.

Devices can be paired, we called bind in the project, for example example/control. Or not paired, a new device can directly send to or recv from other devices.

4.Readlize a muti-hop network through data forwarding function. Please refer to esp-now/examples/dev_kits/button_remote_control

Please refer to esp-now/examples/wireless_debug, open "Enable WebServer debugging" in menuconfig. Connect to the softap and access to the web server espnow-webserver/.

Okay, excellent. That makes sense. I was wondering if those examples were using broadcast but the video hadn't mentioned. Thanks for your help!

Can not find the "esp-now/examples/dev_kits/button_remote_control" mentioned. Can we please have a new link?

Can not find the "esp-now/examples/dev_kits/button_remote_control" mentioned. Can we please have a new link?

https://github.com/espressif/esp-now/tree/1e7a050d92a88eb45ab03c2c92af9838454791d4/examples/dev_kits/button_remote_control