Added basic activation range

Let's save some CPU!
I dont really know if this can help to reduce CPU usage or not.
Activation range set to 48. Tell me if I should lower or increase it or maybe I should try to make it configurable.

Vanilla has something simular if you're wondering.

Yeah, and bukkit too.

Initialisation order is wrong, so clang build failed.

I think this is currently what's happening: https://github.com/mc-server/MCServer/blob/master/src/World.cpp#L1018

I don't think this change is worth it. Instead of doing relatively simple AI, you're searching for a nearby player, which is a heavy operation itself, not to mention that the function is marked as unsafe and should be avoided.
A better option would be to store the distance in a member variable and only update it occasionally. (This coincides with #277 - we want the mob spawning code to cache the distances, too)

Update 1 time per second then?
I could also move the mob following player when it has wheat or so code there.

Pues, do what xoft said and add a cached value to the current code :)

Didn't you say its already done?

The present code still does what xoft says shouldn't happen I think - collecting distances every tick.

What do you think?

?

Instead of counting up to a constant number of ticks (m_TickSearchPlayer), count down towards zero and update when zero. This will allow you later to change the interval dynamically, such as mobs closer to players will get updated more often than mobs further away. Rename to m_TicksUntilPlayerSearch.
Afterwards it'd be really nice if you rebased this entire branch onto master, squashing all the commits into one with a reasonable commit message.

I really like your idea, dynamically changing search interval. I think it would be fine if search interval was = distance with a minimum value of 5.
There is one problem thought, related to pathfinding. If a mob is following you (holding wheat or so) and you dont search for the player every tick, pathfinding/AI acts and changes mob destination. In 4 ticks interval is almost unoticeable, but what if it was 16? Maybe it wouldnt be enough to make the mob follow you. Any idea about how to fix this?

Quite the contrary. Calling MoveToPosition sets the target for the mob, so it will walk there; the further away the mob is from a player, the further the player has to move for the targetting to be completely off. It doesn't matter if the mob is targetting something two blocks away from the current player position if it is some 40 blocks away.
I think a good function would be m_TicksUntilPlayerSearch = 4 + static_cast<int>(m_DistanceToPlayer) / 4: for each 4 blocks of distance it adds a single tick of delay, so a mob 4 blocks away from a player will be re-targetted 4 times per second, while a mob 64 blocks away from a player will be re-targetted once a second.

It seems there are some problems with mob movement. After a while, they start stopping moving, and then moving away +6 blocks and "reviving". Also, wolves do not follow you anymore when holding bones. I'll look into it.
Any idea about what's wrong? Latest MCS without this changes works fine.

What do you think?
?

Sorry, had no Internet access. Looks good, but put it in World.cpp (L1018), since it already looks for mob-player distances there.

It seems there are some problems with mob movement.

I'm not certain, but,
cItem FollowedItem = GetFollowedItem();
if (FollowedItem.IsEmpty())
{
	return;
}

would mean that for entities without GetFollowedItem, the rest of cMonster::Tick (the pathfinding code) would not be executed (one in five?) ticks, which could cause jittering. Wolves don't have GetFollowedItem set, so that may be the cause of the issues with them not following bones.

if ((m_PlayerDistance < 48) && (m_PlayerDistance > 0))
{
	super::Tick(a_Dt, a_Chunk);
}

might cause problems since if an entity occupies the exact spot as a player, the vector length, and so m_PlayerDistance, should be zero, and so super::Tick(), which does physics handling, wouldn't run.

Please correct me if I've made a mistake :P

In my current code (not updated here yet) whay you said about an entity occupying the exact spot as a player is fixed. But the problem is there, happening with mobs which have a followeditem set.

How strange. Try with a debugger?

Now I'll try your with the wolf. Let's see if it works.

Yay!! Wolf fixed!! First I thought there was something wrong because it was always following me but then I realized it was tamed.
Will see if I can do something about the other problem.
Also, I'll try to schedule the wolf code.

clang build fails because of wrong initialization order

I know. It should be fixed in my local version.

It's been a long time... How have you been?
I've been busy with exams (and CS:GO, let's be honest) and I haven't looked deeper into this, my repository is someway messed up too.
I'm thinking on closing, as I don't realize why are the mobs not acting well. If anyone realizes why, I'll probably close it soon.


Incorrect Phrasing/Wording in the Directions

On this Wiki page, in the section "Create a Resource Health alert rule in the Azure portal", there are two isses.

Step 2's instruction should say "In the Resource Health section, select Resource Health"
Screenshot of the page in Azure for reference:

Step 4's instruction has a typo and is missing the "Create" word. It's currently listed as "The ** an alert rule wizard**" opens. It should say "The Create an alert rule wizard opens".
Screenshot of current problems in documentation:

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3eba058f-aab1-e970-6a74-738ca9a13f03
Version Independent ID: 53ecb5d7-4937-d4ee-ba18-16e205032c11
Content: Create Resource Health Alerts using Azure portal - Azure Service Health
Content Source: articles/service-health/resource-health-alert-monitor-guide.md
Service: service-health
GitHub Login: @rboucher
Microsoft Alias: robb

@zacharylee1952
Thanks for your feedback! We will investigate and update as appropriate.

@zacharylee1952 We have verified and updated the document as required. The update will go live in less than 24 hours. Thanks again!


Clarify install/run links

This change will make it more clear, and visible, where to go for installing or running.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/index.md
:white_check_mark:Succeeded
View (azure-cli-latest) View (azure-cli-2017-03-09-profile)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

I agree that a change is necessary here, but don't think that this formatting is the correct way to handle the issue (and there would be a number of required edits.) Will leave this PR open for now while I make a decision about how to handle the wording.

Hi @sptramer, do you have any update on this?

@brunoborges - Sorry, I was out last month doing work related to conferences. This is on my schedule to be picked up in the next week.

Now available as #1015. @brunoborges I made sure to pull your original commit into the history so that you get proper attribution for your changes. Thanks!


Added Partition Problem in java and C++ under Dynamic Programming

🛠 Issue (Number)

Issue no #704
👨💻 Changes proposed

Added Partition Problem in java and C++ under Dynamic Programming
✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers
Please review my PR

@Aishjahan Please add screen shot of your output

Add screenshots and complete the description

Added screenshot

@Aishjahan take input from user

I have completed the requested changes , here are the screenshots :


Scrollbar appears with breadcrumbs enabled when not neeed

VSCode Version: 1.29.1
OS Version: Windows 10 1809

Steps to Reproduce:

Launch VSCode
Create (Ctrl-N) or open several files
Click on a side panel button to expand the sidepanel (Explorer for example)
Click again to collapse the sidepanel

At this point a horizontal scrollbar appears in the tabs row, even though it is not necessary. The scrollbar disappears if/when you click on some tab (even the active one).

Does this issue occur when all extensions are disabled?: Yes

@lllopo can you share your settings?

There you go :
{         "git.ignoreMissingGitWarning": true,     "telemetry.enableTelemetry": false,     "telemetry.enableCrashReporter": false,     "editor.insertSpaces": false,     "editor.codeLens": false,     "editor.minimap.enabled": false,     "editor.dragAndDrop": false,     "editor.emptySelectionClipboard": false,     "editor.hover.delay": 3000,     "editor.quickSuggestionsDelay": 3000,     "editor.renderLineHighlight": "gutter",     "editor.showUnused": false,     "editor.formatOnType": true,     "editor.fontSize": 15,     "workbench.editor.enablePreview": false,     "workbench.editor.enablePreviewFromQuickOpen": false,     "workbench.startupEditor": "newUntitledFile",     "workbench.statusBar.feedback.visible": false,     "workbench.settings.openDefaultSettings": false,     "workbench.colorCustomizations": {         "foreground": "#333333",         "editor.background": "#ffffff",         "editor.lineHighlightBackground": "#EAEAEA",         "editorIndentGuide.background": "#f3f3f3",         "editorIndentGuide.activeBackground": "#e0e0e0",         "editorGutter.background": "#f9f9f9",         //"editor.selectionBackground": "#cee7ff",         "editorBracketMatch.background": "#cae5ff",         "editorBracketMatch.border": "#ffffff00",         "activityBar.foreground": "#FFFFFFED",         "activityBar.background": "#232A35",         "sideBar.border": "#D5D5D5",         "widget.shadow": "#ffffff00",         "scrollbar.shadow": "#ffffff00",         "focusBorder": "#00000000",         "titleBar.activeBackground": "#fafafa",         "titleBar.activeForeground": "#333333",         "titleBar.inactiveBackground": "#fafafa",         "titleBar.inactiveForeground": "#aaaaaa",         "tab.activeBorderTop": "#0099E1",         "tab.activeBackground": "#f9f9f9",         "tab.inactiveForeground": "#777777",         "statusBar.noFolderBackground": "#232A35",         "statusBar.background": "#232A35",         "statusBar.foreground": "#ffffff",         "menu.selectionBackground": "#1A7DC4",         "menu.background": "#FAFAFA",         "menubar.selectionBackground": "#d0d0d0",         "breadcrumb.foreground": "#555555",         "breadcrumbPicker.background": "#f9f9f9",         "breadcrumb.background": "#f9f9f9",         "editorLineNumber.foreground": "#B9B9B9",         "editorLineNumber.activeForeground": "#777777",         "list.activeSelectionBackground": "#1A7DC4",         "list.activeSelectionForeground": "#FFFFFF",         "list.inactiveSelectionBackground": "#e4eef7"     },     "window.closeWhenEmpty": true,     "window.restoreFullscreen": true,     "window.restoreWindows": "none",     "window.newWindowDimensions": "maximized",     "window.enableMenuBarMnemonics": false,     "files.autoGuessEncoding": true,     "files.hotExit": "off",     "files.associations": {         "*.ctp": "php"     },     "explorer.openEditors.visible": 0,     "terminal.integrated.shell.windows": "C:\\Windows\\System32\\cmd.exe",            "html.format.indentInnerHtml": true,     "html.format.indentHandlebars": true,     "extensions.ignoreRecommendations": false,             "vscode_custom_css.imports": [         "********************************************"     ],     "vscode_custom_css.policy": true,     "vscode_custom_css.statusbar": true,     "php.suggest.basic": false,     "php.validate.executablePath": "*******************************************",     "breadcrumbs.enabled": true,     "workbench.iconTheme": "material-icon-theme",     "sync.quietSync": true,     "sync.removeExtensions": false,     "sync.autoUpload": true,     "sync.gist": "******************************",     "sync.syncExtensions": true,     "sync.autoDownload": false,     "sync.forceDownload": false,     "beautify.config": {         "indent_with_tabs" : true,         "content_unformatted" : ["pre", "textarea", "cms"]     },     "workbench.colorTheme": "Boxy Yesterday",     "explorer.autoReveal": false,     "explorer.enableDragAndDrop": false,     "local-history.saveDelay": 1,     "editor.wordSeparators": "~!@#%^&*()-=+[{]}\|;:'",.<>/?",
"local-history.path": "${workspaceFolder}/.vscode",
"files.exclude": {
"/.history": true,
"/.idea": true,
"/.vscode": true,
"/nbproject": true
},
"files.useExperimentalFileWatcher": true
}`
Just replaced some paths and sensitive stuff with "*"

Nope, the issue disappears if I disable the breadcrumbs.

I cannot reproduce. Please try latest insider: https://code.visualstudio.com/insiders/

I cannot reproduce. Please try latest insider: https://code.visualstudio.com/insiders/

Just tried it with vanilla insiders - still the same. As soon as I enable breadcrumbs the thing happens.

I made a small video to demonstrate the issue. It uses latest insiders, but I can't upload here. Let me know, if it would be of any help and I'll put it somewhere so you can view it.

It uses latest insiders, but I can't upload here.

zip it

I can still not reproduce, please distill your settings (which I have tried this with) and/or steps so that I can reproduce. There is nothing else I can do before that

I can still not reproduce, please distill your settings (which I have tried this with) and/or steps so that I can reproduce. There is nothing else I can do before that

I can still not reproduce, please distill your settings (which I have tried this with) and/or steps so that I can reproduce. There is nothing else I can do before that

The video is shot on vanilla insiders - zero custom settings, zero extensions. I only changed the color theme to Light+ for better visibility and the change on the breadcrumbs on/off that is visible on the video itself.
The other thing I though might be related is that I'm using my display to 125% scaling, but I switched to 100% and repeated the test - all the same, so it is not that either.

What I can add further is what I see in the DevTools inspector - the issue is due to the fact, that the sidebar is closed, the tabs horizontal scrollbar is set to some inadequately small value (like 200-300 pixels) and gets fixed be most actions like changing the windows size, adding a new tab ... even clicking on any tab including the active one (clicking outside the tabs on the tab bar does not fix it, though). So :

opening sidebar - tabs scrollbar div width calculated properly
closing sidebar - scrollbar div width calculated totally wrong
resize something, click on tab, add a tab - scrollbar width recalculated properly

Edit : The "inadequately small width" remains the same for a while. Like if it is 214px, no matter how many times you expand or collapse the sidebar - it remains 214px, but it varies over time - could be 244px, 167px ... anything. Still can't find what causes it to change from one value to another, nor is this value related to something. For now I observed the following :

changing the sidebar width changes the weird value
changing the number of tabs does not change the weird value
changing the editor size (changing the window size or dragging devtools while docked left) does not change the weird value

I have a hard time to follow. How are the last two comments related to breadcrumbs? Also, I do exactly when you say in https://github.com/Microsoft/vscode/issues/63764#issuecomment-442026681 and I cannot reproduce. Please focus and providing repro steps

I have a hard time to follow. How are the last two comments related to breadcrumbs? Also, I do exactly when you say in #63764 (comment) and I cannot reproduce. Please focus and providing repro steps

I'm just trying give you all clues and info I can gather. The width of the scrollbar div when collapsing the sidebar is definitely calculated wrongly at my place. How this is related to breadcrumbs I don't know. Have to find and read the relevant vs code source to sort it out, but I don't have the time for that right now. As of reproduction steps - you saw the video - it just happens easily on my machine with a freshly installed latest insiders. For now I haven't found another way to cause this, so you can try it too. If you have any test I can conduct on my copy - just let me know.

@jrieken the size I get is wrong, offsetWidth should always be the size of the container as it appears on screen, but I get much smaller width after toggling the sidebar once, which explains why the scrollbar decides to show up, even though the visible space is enough.

I found out so far that the call to:
vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts
Line 983 in 130e81f
this.breadcrumbsControl.layout({ width: dimension.width, height: BreadcrumbsControl.HEIGHT });
Makes my call to
vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts
Line 987 in 130e81f
const visibleContainerWidth = this.tabsContainer.offsetWidth;
Go nuts for some reason. I cannot explain that given the breadcrumbs live in a different container than the tabs scrollbars.
Open for help if someone has clues.

I'm debugging it here with the DevTools console, and the offset width is actually wrong even before the call to 'this.breadcrumbsControl.layout'. I mean - if you put a breakpoint before line 983 and check the offsetWidth - it is already wrong ... at my place at least.

@lllopo ah ok good to know, but I cannot reproduce when I remove that call so it must be related...

Are there steps to verify this?


changed UI

Related Issue #971
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #(issue no.)#971
Description
Changed the color and font style of web pages.
 #971
Type of PR

[x] Feature enhancement

Screenshots / videos (if applicable)
The initial images of website

Change in UI done

Checklist:

[ ] I have made this change from my own.
[ ] I have taken help from some online resources.
[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers and screenshots after making the changes.

resolve the conflicting file and raise new PR


Qdrant not working

Describe the bug
With the use of qdrant vector database we are getting the attributes error as below"
To Reproduce
Steps to reproduce the behavior:
Pasting jupyter code :
from vanna.ollama import Ollama
from vanna.qdrant import Qdrant_VectorStore
from qdrant_client import QdrantClient

class MyVanna(Qdrant_VectorStore, Ollama):
    def __init__(self, config=None):
        Qdrant_VectorStore.__init__(self, config=config)
        Ollama.__init__(self, config={'model': 'mistral'})

vn = MyVanna(config={'client': QdrantClient(url="http://localhost:6333/")})

vn.connect_to_mysql(host='<IP_ADDRESS>', dbname='rag', user='wsl_root', password='password', port=3306)

# The information schema query may need some tweaking depending on your database. This is a good starting point.
df_information_schema = vn.run_sql("SELECT * FROM INFORMATION_SCHEMA.COLUMNS")

# This will break up the information schema into bite-sized chunks that can be referenced by the LLM
plan = vn.get_training_plan_generic(df_information_schema)
plan

# If you like the plan, then uncomment this and run it to train
vn.train(plan=plan)

from vanna.flask import VannaFlaskApp
app = VannaFlaskApp(vn)
app.allow_llm_to_see_data = True
app.run()

Expected behavior
Training data should show all the trained data
Error logs/Screenshots
AttributeError
AttributeError: 'MyVanna' object has no attribute 'documentation_collection'
Desktop (please complete the following information where):

OS:  Ubuntu
Version: 22.04]
Python: 3.10.12
Vanna: 0.4.2

Thanks for reporting!

I see the docs have been updated with the proper imports.
@icfai-aniketsingh, could you please confirm if they work for you now?


do not store the full image in the database

The current recipe stores the full images (in base64) in the database, but we don't want to do that for two reasons:

it will make the database too big relatively quick
it looses the information about file names, so we can't really crop the images once they're annotated

For that the stream could just use s3 URIs with a temporary token. That means that the image URIs will stop working at some point, but this will preserve the s3 key and we can reconstruct new s3 URIs later on

For this, the prodigy will accept an argument when we start the prodigy. We can pass --remove-base64 which will not save the base64 data of the image in the database.
I hope this is helpful sir.

well, but then what will prodigy store? If it doesn't store the image url on s3, how can we reconstruct it from what's in the database?

issue resolved, below is the log image using sudo journalctl -u prodigy_bdrc_crop_images.service check the second last line in the image

thanks! It looks good, is there a way to make it (much) longer than that, something like a year? If not we'll have to make a script that goes through the database and updates the URL of the images

I don't know the upper limit to the ExpiresIn, I will check and update to the upper limit.

As per this documentation Documentation Link nothing is mentioned about the maximum value for the ExpiresIn. But then as per this Documentation Documentation link it says maximum value is  7 days. But I put the ExpiresIn as one year or 31536000 seconds and restarted the server, to if one year works and It works fine for now.

sure, will look into it

here is the python script to update the s3_url or to update to extend the URL's ExpiresIn.
update_s3_url.py
below is the test, in the test, I am assert the statu_code os the response of the new url.
test_update_s3_url.py
and finally the update-database.sh

this is good! some remarks:

the test file should use the code in update_s3_url.py and not duplicate it, otherwise it doesn't really test the file
before updating the token, the code should check if the URL is indeed an s3 url, there are cases where the url will just be a iiif url, no need to try to update the token in that case

okay, I will make those changes


Pie chart: auto layout

When resizing the viewers, it is possible to achieve a result where the pie chart is displayed in three different ways on viewers of the same size.

1.16.0


Postinstall of build dll breaks when a npm dependency to a private repo is in the dependency list exists

Description
When adding a dependency to a github repository which is private and usually accessed through ssh for instance, the next npm install breaks on the build DLL postinstall step.
With the error :
ERROR in dll reactBoilerplateDeps
Module not found: Error: Can't resolve 'private-module-name' in 'project/path'

Steps to reproduce

Install and setup the boilerplate
Add a npm dependency to a github repo that is private, either manually or by running :
npm install --save<EMAIL_ADDRESS>Try doing a npm install in the project directory

Result : it breaks with the above error
Questions

Is the postinstall necessary on every subsequent npm install ?
Is there a way to work around this if it's a real issue while waiting for a fix ?
Am I doing something wrong ?

For now, I can only delete the postinstall in the package.json and I will see if/what it breaks...
Versions
Node/NPM : v6.3.1 / 3.10.3
webpack 2.1.0-beta.13

@datapimp any idea what the problem could be here? I don't have access to any private module.

there shouldn't be any issues with private modules but my gut says if there is that it is related to the @scope prefix in the path -- let me test it out on my own and I'll see if I can reproduce it

ping any news here?

Any news on that issue?

No changes on my end. The only way I found to get it working was to put the module in question in the exclude list of the DLL

Any updates on this issue?

Closing for now, but please comment if this is still an issue.


[clang-tidy] Comment check

This PR contains the check related to comments. Voting will end on 17 November 2020, 18:00 HZDR time.

Disallow TODO comments without a username or bug number (Documentation)

Vote

Enable
Disable

0
1

Enable
Disable

1
1

This one is important. If a codebase gets older, you will have many TODOs in there and your git/SVN log is not helping you with who wrote it, because the code around got refactored, formattet etc. So adding a username to a TODO gives you a chance to still find that person, if the comment was important.

Git blame will show you the author of the comment.

Git blame will show you the author of the comment.

No, it will show you the last person who edited the line.
So if I wrote:
func(a, b); // TODO: this might be slow
And you refactor it to, maybe even as part of an automatic rename:
Func(a, b); // TODO: this might be slow
Then git blame will give me your name and not the TODO author's.

Requesting a tie break here. @psychocoderHPC @sbastrakov @SimeonEhrig @sliwowitz or anyone else who has feelings about this...

Ok, I'll do it myself. I actually now think that this is quite useful. Final result:

Enable
Disable

2
0

Git blame will show you the author of the comment.

It's also possible to iterate throw the history with git blame and look after the original author of the TODO, but I'm fine, if it is forced by clang-tidy. The consistence check is the time consuming stuff, not writing the comment ;-)

Enable
Disable

3
0


On chain mint and melt

Depends on https://github.com/cashubtc/nuts/pull/188

[ ] CDK
[ ] Nutshell
[ ] Nutmix
[ ] goNuts
[ ] cashu-ts

Supersedes https://github.com/cashubtc/nuts/pull/107

@thesimplekid  Why do we need new NUTs for this? Can't we just add some appendices to NUT-3, NUT-4 and  NUT-5 on what additional fields a particular Post{Mint, Melt}OnchainRequest   should have?

@thesimplekid Why do we need new NUTs for this? Can't we just add some appendices to NUT-3, NUT-4 and NUT-5 on what additional fields a particular Post{Mint|Melt}OnchainRequest should have?
We can then modify NUT-6 to include information about a particular minting and melting method called btconchain like this:

I think its a reasonable question, and one way to do it. But I don't really think we should be changing or adding to past nuts. I think it gets confusing, its better to just have new nuts. That being said maybe what id defined in the new nuts could be reduced and and reference the existing nuts and some of it is repetitive. Though I did it this way because this way the nut stands more on its own and you don't have to check another nut as much. But think there are arguments for and against that

NUTs 3, 4 and 5 are mandatory.
Adding optional fields to them feels wrong.
Also on-chain minting has some specifics (and we already see that via quote locking) and I think this deserves another NUTs.
I would like to also see Liquid supported and I feel this should be again another set of NUTs, although the distinction here is probably not that strong and Liquid support can become a part of the BTC on-chain NUTs.


(WIP) Remove flags from block_using_rules_sqls logic ( _find_new_matches_mode and _compare_two_records_mode)

At the moment a variety of boolean flags are set on the linker that modify the behaviour of sql generating functions.
It's difficult to understand the consequences of these flags because rather than the calling function 'asking' for specific behaviour by explicitly setting function arguments, the behaviour occurs implicitly via the flag.
For example, in linker.estimate_u_using_random_sampling, two modifications are made to blocking:

We need to take a sample of the input records
We need to eliminate blocking rules (because estimate_u_using_random_sampling performs a cartesian join)

But this behaviour is achieved by setting:
training_linker._train_u_using_random_sample_mode = True
and then in blocking.block_using_rules_sqls we have code that runs conditional logic like if linker._train_u_using_random_sample_mode e.g. here.
It would be much clearer if the estimate_u_using_random_sampling function explicitly took the samples, added the sqls to the pipeline, and then called blocking.block_using_rules_sqls passing in the name of the sampled tables and a null (full cartesian join) blocking rule.
Another example is how table names are interpolated into block_using_rules_sqls
e.g. here:
https://github.com/moj-analytical-services/splink/blob/440231619dcb854c1c69cce2725156e3598589cb/splink/blocking.py#L251
Which has lines like:
https://github.com/moj-analytical-services/splink/blob/440231619dcb854c1c69cce2725156e3598589cb/splink/linker.py#L334-L345
and is very confusing to work out what table name will be interpolated and why.  Instead, within the linker.compare_two_records functions, it would be better to simply explicitly pass tablenames like __splink__compare_two_records_left_with_tf into block_using_rules_sqls

TODO:

[ ] self link
[ ] search for all instance of block_using_rules_sqls and block_using_rules_sqls(self) - they should all now have multiple args

Fix
        link_type = settings_obj._link_type

        if linker._two_dataset_link_only:
            link_type = "two_dataset_link_only"

        if linker._self_link_mode:
            link_type = "self_link"

in blocking.ExplodingBlockingRule


Add support for PROXY protocol

Suggested in #28.
Right now, receiving v1 works, but the information is just dumped into the command line. Should I put the proxy-protocol information into struct client?

Hello,
thanks for the the effort and sorry for the delay!
I haven't tried the diff yet, but it looks fine to me.  I have a few nits before we can merge this, but first I'd ask you if it would be possible amend the indentation changes in server.c in the first commit.  It makes the diff harder to review.
Thanks!

but first I'd ask you if it would be possible amend the indentation changes in server.c in the first commit.

Yes, sorry. Apparently I told my editor to auto format at some point; I will take care of it.
We should probably add some unit-tests for parsing. And what do you think about fuzzing? Clang supports this AFAIK, but I am not sure about gcc.
Also, is this parsing happening in a process that drops its privileges? (It was (is) a little daunting to write network facing C code :b)

Yes, sorry. Apparently I told my editor to auto format at some point; I will take care of that.

no problem.

We should probably add some unit-tests for parsing.

Yep, I'd really like some tests for this.  We have both unit tests (although only used for the IRI parsing code) and runtime tests.  If we had support for the proxy protocol also for, ehm, proxying connections it would be easy to do.
But no rush for this, we'll get to it after the diff is in a state where it can be merged :)

And what do you think about fuzzing? Clang supports this AFAIK, but I am not sure about gcc.

I wouldn't mind having something for fuzzying.  Maybe this is the chance I needed to look more into it.  AFAIK the compiler doesn't really matter, but you can use stuff like asan and ubsan too which may depend on the compiler/platform.

Also, is this parsing happening in a process that drops its privileges? (It was (is) a little daunting to write network facing C code :b)

Yes, the connection handling runs in a process that has dropped privileges, chrooted and, depending on the system, sandboxed itself.

If you want to test the behaviour with nginx in front, you can refer to this snippet:

Thanks!  It'll take be a bit to be able to actually test this, but many thanks for the nginx snippet!

Hi, I've cleaned up the whitespace changes. My actual changes should still be there. :)
make regress runs fine indicating that non-proxy-protocol connections are fine. (But there are no test for the protocol yet, of course.)

I rewrote the parsing according to your suggestions. Test are obviously failing now since proxy-protocol is expected now, what's missing is some kind of configuration for server_accept() to set c->buf.should_buffer accordingly.

To be fair it's a bit lame the way I've added the proxy-v1 keyword.  I'll refactor a bit later how listen is processed so it's tidier.
After the pending thing will be fixed I believe we can merge this!  I hope you won't take it bad, but I'll probably rebase it against the master (I prefer to have a linear history and avoid merges), squash some commits, and pass proxy-proto.c thru knf, mostly for indentation, for consistency with the rest of the code.
Thanks! :)

I hope you won't take it bad, but I'll probably rebase it against the master (I prefer to have a linear history and avoid merges), squash some commits, and pass proxy-proto.c thru knf, mostly for indentation, for consistency with the rest of the code.

No problem, this is your codebase after all, and I admit that my commit-messages are not necessarily very meaningful. (Also some of them were drafts, so no reason not to squash.)
Thanks for pointing me to knf though, it's very interesting how OpenBSD folk do things :)

I"ve merged it manually, so unfortunately on github it will show as 'closed' instead of merged :(
Thank you for working on this and enduring my requests :)
There are two follow-up commits that I'd like to point out since they may be of interest for you and that I noticed only after starting to playing with this.

https://github.com/omar-polo/gmid/commit/acbe7a53131d0ba42bf919ea7a11dc7d1b60fb9c
https://github.com/omar-polo/gmid/commit/2a090b866d78d8e9a06a1e49e6b48cd4b5a488d0

Just FYI I've started to fuzz some parts, the proxy protocol and the IRI parser.  See regress/fuzz/README.md if you're interested :)

I think I've found an issue with the current implementation: we expect both addresses to be of the same family, i.e. PROXY TCP6 ::1 <IP_ADDRESS> 30677 1965 is considered malformed, while I think it should be supported.  (proxying from one family to another is not uncommon)
I'll fix it since I'd like to release 2.1 soon, but wanted to let you know.

Ah, yes, good spot. I misread the spec and assumed that the INET family was for both addresses.
Anyway, thanks for taking care about this! I'm excited that this now landed in 2.1 :)


Sign and add plugin to Grafana marketplace

We need to submit plugin to Grafana marketplace, so it could be verified and signed. This should simplify the installation procedure for users.

hey @hagen1778
do you think it's possible to add this datasource here?
https://github.com/grafana/grafana/blob/219411f894b1afdcec44857e2bf35b52cd321a73/packages/grafana-o11y-ds-frontend/src/TraceToLogs/TraceToLogsSettings.tsx#L76

do you think it's possible to add this datasource here?

We can submit a PR, sure. I don't know if it will be accepted. But could you please elaborate on what it allows to do?


Command internal api

This adds the backend for the new command system. I will be making an issue to discuss changes to the commands soon

Approved.


Remove beyerdynamicvs

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

The appcast checkpoint and sha256 of the download file appear to change every few minutes, and I am unable to locally extract the .zip file that is downloaded.


Message length exceeded maximum allowed length

Version
4.1.3
Browser and OS info
Chrome 64 / macOS High Sierra
Steps to reproduce
Create a v-for loop for a large amount of data (90   objects) and open Vue dev-tools.
What is expected?
I'm expecting to loop through the objects just as fast as it does with the dev-tools disabled.
What is actually happening?
There is an enormous delay when trying to loop through the objects when vue-dev tools are opened and monitoring my Components. Eventually the error:
Message length exceeded maximum allowed length
appears and the tool often crashes. Not having any problems when the tool is not active.

I'm using Nuxt.js

Solved it! It turned out to be a portal-vue issue. I was using portal-vue to create Modals but apparently it takes a toll on the Vue-tool when using a combination of portal-vue and big chunks of data.


Cmake nightly builds for Windows are broken for more than a month!

Cmake nightly builds for Windows are broken for more than a month!
Will tensorflow ever support Windows again?

The head revision fails with the error (compiling with GPU support):
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" e xited with code 1. [C:\tensorflow\tensorflow\contrib\cmake\build\cub.vcxproj]
The revision on the moment of the last successful nightly build fails as well (why?) with the error:
 C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" e xited with code 1. [C:\tensorflow-cmake\tensorflow\contrib\cmake\build\gemmlowp.vcxproj]

I'd the same problem due to hash mismatch (see below). I'd to change the hash in cmake\external\gemmlowp.cmake to get over this problem.
  -- verifying file...
         file='D:/devel/tensorflow/tensorflow/contrib/cmake/build/downloads/010bb3e71a26ca1d0884a167081d092b43563996.tar.gz'
  -- SHA256 hash of
      D:/devel/tensorflow/tensorflow/contrib/cmake/build/downloads/010bb3e71a26ca1d0884a167081d092b43563996.tar.gz
    does not match expected value
      expected: '0d7a44327e26b622ee08faaea10f8d10b439bcfda622f9c98be1c036bc645cad'
        actual: '861cc6d9d902861f54fd77e1ab79286477dcc559b2a283e75b9c22d37b61f6ae'
  -- Hash mismatch, removing...
  CMake Error at gemmlowp-stamp/download-gemmlowp.cmake:157 (message):
    Each download failed!

C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [D:\devel\tensorflow\tensorflow\contrib\cmake\build\gemmlowp.vcxproj]
Done Building Project "D:\devel\tensorflow\tensorflow\contrib\cmake\build\gemmlowp.vcxproj" (default targets) -- FAILED.

/CC @mrry

btw, AVX optimized Windows binary wheel is the most requested wheel on https://github.com/yaroslavvb/tensorflow-community-wheels/issues

@ekelsen Erich: The current build failure (see e.g. here) looks like it might be caused by the GPU reduction code you added in 42fcbb196052823c4393a4d5d8682ca425253f6a. It looks like MSVC can't infer the template arguments for BlockReduce() and WarpReduce()... can you please take a look?

I have a fix internally, going in today.

@ekelsen, did you fix it? Nightly builds are still broken...

well, I did fix one problem, but it looks like there's another one.  These tests don't run internally, so it can be hard to tell sometimes...  There is a PR with a fix for this issue here: https://github.com/tensorflow/tensorflow/pull/12920/files
I'll accelerate getting that part of that CL that solves this issue submitted.

Why have you closed it? The problem is still not resolved!


Document PhysicalSkyMaterial's energy_multiplier property

This makes the PhysicalSkyMaterial class 100% documented.
Note: Not cherry-pickable to 3.x, as PhysicalSkyMaterial doesn't exist there.

Thanks!


Chat History in all instance of vscode

After I open vscode on new window or opening a new folder, my previous history of chat in vscode is gone. I can't see it in the history. In fact there's no history at all. I guess it doesn't get save on my account. It would be nice if I could see all of my previous chat like how ChatGPT or Gemini does.

Chat history is saved per-workspace, so you will only see messages that were sent within that same window/folder

so how do I get my old workspace back?

Chat history is saved per-workspace, so you will only see messages that were sent within that same window/folder
so how do I get my old workspace back?

Is it buried somewhere in the workspace folder under ~/.config then? It can cause a bit of a problem when a workspace will no longer open or is not accessible for any reason - e.g. a container will no longer start, folder has been renamed, a remote SSH server isn't accessible, etc.


Support EntityFramework 2

Is your feature request related to a problem? Please describe.
Due to the issue with some third party dlls not supporting .net core or .net 5 I was forced to push back my entity framework to entity framework 2.0 since they only support .net framework and .net standard 2.0. So I had to downgrade that until Photon Server will support .net 5. Since the database layer is used by multiple solutions I don't have a choice.
Describe the solution you'd like
I would like a nuget package that supports Entity Framework 2.0. The solution that uses GraphQL is a .net5 project. So I don't think that would need to change.
Describe alternatives you've considered
I tried to download the source code and change the entity framework myself but there is 3 errors that would need to be addressed and I don't know enough about the framework to fix them.

EntityFramework Core 2 is no longer supported by Microsoft. 2.1 will also be running out of support in a few weeks, therefore I don't think we will add support for it going forward.
@PascalSenn what's your opinion on this?

We cannot provide support for a framework that is out of support by Microsoft. Maintaining a codebase that supports EF 2 would be too much work for us to handle

@PascalSenn I am not asking you to support a codebase. Just create a NugetPackage with the dlls. Right now I am unable to use HotChocolate due to this issue. There is a constant error with it because of Entity Framework.

@kbrow20

I tried to download the source code and change the entity framework myself but there is 3 errors that would need to be addressed and I don't know enough about the framework to fix them.

What were these three issues?

These 2 locations

@PascalSenn @tobias-tengler Trust me I am not happy that Photon Server is so far behind with .net support. If it wasn't for the fact that are so critical in developing my video game section I would get rid of it. Until they support it I am stuck in this spot. I use the GraphQL API for my website to report bugs with the video game and create a user account. If I had it my way everything would be done in .net5.


Repo sync for protected CLA branch

The pull request is created from main637795945046096009 to main to fix git push error for protected CLA branch

@shsagir : Thanks for your contribution! The author(s) have been notified to review your proposed change.


modified the copyright year

Ⅰ. Describe what this PR does
modified the copyright year in pkg/common/storage.go
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

/lgtm


new repo.(awsomedocker)

Is this repo inactive?
I see that this repo's last update is 2023 1 10.
So I created new Github account and new gmail count and new repo.
https://github.com/new-awsomedocker/awsomedocker

I wish this repository gets active again.


[Feature]: Change theme button on theme UI

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Change theme will be shown on hovering the card rather than an explicit button
Why should this be worked on?
This will help bring the properties to be consumed directly below the themes

Updated design to discuss on, needs some design help
https://www.figma.com/file/wVHeU6hnJtC29sLAiGo5yl/UI-|-Application-Theming-2.1?node-id=3421%3A262520

@jsartisan @dilippitchika
Observation:

As per figma design, we can see a option to 'customize' whenever theme is selected. But in DP there is no customize option and everytime we need to go back to configure more
https://www.loom.com/share/a03b5d7ee6604996ae7292c317b252fe

@chandannkumar thanks for this, there is a difference and it is known. We are waiting for some user feedback to improve this currently and are tracking it in a separate issue https://github.com/appsmithorg/appsmith/issues/13627

Change theme will be shown on hovering the card rather than an explicit button - Tested & verified
Tested this feature on PR and working as expected


[Suggestion] More detailed in-Discord command help/documentation

It would be nice to see more examples of specific commands and things the bot can do while still in Discord and just using the Help command. A good example would be how this other RPG/Dice rolling bot does it: https://github.com/Gawdl3y/discord-rpbot

There's some Markdown support in Discord, so I could try to output the contents of the https://github.com/ArtemGr/Sidekick/blob/master/README.md in the /r help output.
But we can't send messages larger than 2000 bytes long, so I'd need to page it.

Even just returning a link to the github readme would be a great first step and super easy.

A link to readme we have.

Oh nice! It's a little tricky to get to since slash commands try to autocomplete to discord's nearest guess of what it thinks you were typing, so you have to slash-r-space. /r help being an alias for that would be super helpful.


Functionality to manage and log AD account modifications

NB

Create and Update Functions are not compatitable with current ad_sync scripts

This change is

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Use Cop::Base API for Layout department [N-S]

Follow #7868.
This PR uses Cop::Base API for almost Layout department's cops.
It targets cop that names begin between N and S. And several N-S cops will be excluded from this PR target and addressed separately.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Awesome work!


Evaluate form state libraries e.g. Formik, react-final-form, react-hook-form and add validation to our forms

I figured we should have an issue like this to remind us that we currently aren't doing any form validation. At some point soon we should investigate solutions for this, and break down tasks for each form we need to add it to.

React Hook Form seems to me as the best solution between those form validation approaches:

plain react:

Requires a fair amount of boilerplate for validation.
Makes sense for a project with a small amount of form/fields
Meanwhile for a bigger project, the use of a helper library make sense.

formik:

Based upon React Context, State
Heavy re-rendering
We had issues with the latter

react-final-form:

Similar approach to Formik, using Context, State.
Documentation quite heavy and not very intuitive (at least to me!).
Formik has stronger support. Why use another Formik?

react-hook-form:

Based upon React Hooks and Ref
No component to import
Minimal re-rendering
Very straightforward approach, less code
Good documentation and intuitive (at least for me).
Active community

react-hook-form vs formik
https://react-hook-form.com/faqs/#ReactHookFormFormikorReduxForm

Looking more into this, it seems we can use https://github.com/jquense/yup as the validation component with or without any of these libraries. It seems like a really strong contender (1.5 million weekly downloads on npm) no matter what we choose to go with it

Capturing latest thoughts that came from recent discussions:
With Yup, the schema approach is really solid, no wonder why so many other libs are using it or having a plug-in option for it.
Although Yup allows to create very detailed and customized validations, it doesn't takes away the need to track down every form field for validation, that means potentially lots of boilerplate and this is where solution like Formik become handy.
In (basic example)[https://github.com/gildub/virt-ui/blob/yup/src/app/Providers/components/AddProviderModal/AddProviderModal.tsx#L41-L74] we can see how form validation can be very straightforward and which we could use. When a field depends from another one, or validating a URL, or checking backend status on selected object are actions we could keep wrapped under a given form' schema.

Also after experimenting a little bit with React Hook Form a couple of first impressions:

A ref needs to be passed down to all the PF form components. It's not clear at this stage what type needs to be passed to make it work.
Using non connected components seems counter productive to React pattern. Although React Hook Form "controller" could be use as a wrapper to have controlled components, it probably defeat the gain initiated by React Hook Form.

As far as React Hook Form is concerned, I think I would be inclined to try it if it weren't for PatternFly's form components being designed to be used as controlled. It sounds like using the required refs and types would be a headache there and require upstream changes. I'm leaning much more towards a homebrew solution or Formik.
I'm in the process of working on a small custom hook that we could use instead of Formik, I'm hoping to share that tomorrow to help us make a decision. But I'd be fine with not using it.


(symfony) create entity models

Describe the Feature
add entity models based on the er-diagram.
You can use the make:entity command


NvInferRuntimeCommon.h not find

/opt/amirstan_plugin/src/plugin/common/logging.h:20:10: fatal error: NvInferRuntimeCommon.h: No such file or directory
#include "NvInferRuntimeCommon.h"
^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
detail:
(trt) root@8c74b39d4dd2:/opt/amirstan_plugin/build# make -j10
-- Found TensorRT headers at /usr/include/x86_64-linux-gnu
-- Find TensorRT libs at /usr/lib/x86_64-linux-gnu/libnvinfer.so;/usr/lib/x86_64-linux-gnu/libnvparsers.so;/usr/lib/x86_64-linux-gnu/libnvinfer_plugin.so
-- Configuring done
-- Generating done
-- Build files have been written to: /opt/amirstan_plugin/build
[  1%] Building NVCC (Device) object src/amir_cuda_util/CMakeFiles/amir_cuda_util.dir/amir_cuda_util_generated_repeatDims.cu.o
[  2%] Building NVCC (Device) object src/amir_cuda_util/CMakeFiles/amir_cuda_util.dir/amir_cuda_util_generated_memcpyPermute.cu.o
[  4%] Building NVCC (Device) object src/amir_cuda_util/CMakeFiles/amir_cuda_util.dir/amir_cuda_util_generated_tensorMeanVar.cu.o
Scanning dependencies of target amir_cuda_util
[  5%] Linking CXX static library ../../lib/libamir_cuda_util.a
[  5%] Built target amir_cuda_util
[  7%] Building NVCC (Device) object src/plugin/groupNormPlugin/CMakeFiles/groupNormPlugin_static.dir/groupNormPlugin_static_generated_group_norm_kernel.cu.o
[  8%] Building NVCC (Device) object src/plugin/roiExtractorPlugin/CMakeFiles/roiExtractorPlugin_static.dir/roiExtractorPlugin_static_generated_roi_extractor_kernel.cu.o
Scanning dependencies of target exViewPlugin_static
Scanning dependencies of target repeatDimsPlugin_static
[ 10%] Building NVCC (Device) object src/plugin/delta2bboxPlugin/CMakeFiles/delta2bboxPlugin_static.dir/delta2bboxPlugin_static_generated_delta2bbox.cu.o
[ 11%] Building NVCC (Device) object src/plugin/layerNormPlugin/CMakeFiles/layerNormPlugin_static.dir/layerNormPlugin_static_generated_layer_norm_kernel.cu.o
[ 12%] Building NVCC (Device) object src/plugin/gridAnchorDynamicPlugin/CMakeFiles/gridAnchorDynamicPlugin_static.dir/gridAnchorDynamicPlugin_static_generated_grid_anchor_dynamic.cu.o
[ 14%] Building NVCC (Device) object src/plugin/torchGatherPlugin/CMakeFiles/torchGatherPlugin_static.dir/torchGatherPlugin_static_generated_torch_gather.cu.o
[ 15%] Building NVCC (Device) object src/plugin/deformableConvPlugin/CMakeFiles/deformableConvPlugin_static.dir/deformableConvPlugin_static_generated_deform_conv_cuda_kernel.cu.o
[ 17%] Building NVCC (Device) object src/plugin/batchedNMSPlugin/CMakeFiles/batchedNMSPlugin_static.dir/batchedNMSPlugin_static_generated_sortScoresPerImage.cu.o
[ 18%] Building CXX object src/plugin/exViewPlugin/CMakeFiles/exViewPlugin_static.dir/exViewPlugin.cpp.o
[ 20%] Building CXX object src/plugin/repeatDimsPlugin/CMakeFiles/repeatDimsPlugin_static.dir/repeatDimsPlugin.cpp.o
In file included from /opt/amirstan_plugin/src/plugin/common/logger.h:20:0,
from /opt/amirstan_plugin/src/plugin/common/common.h:32,
from /opt/amirstan_plugin/src/plugin/exViewPlugin/exViewPlugin.cpp:5:
/opt/amirstan_plugin/src/plugin/common/logging.h:20:10: fatal error: NvInferRuntimeCommon.h: No such file or directory
#include "NvInferRuntimeCommon.h"
^~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
src/plugin/exViewPlugin/CMakeFiles/exViewPlugin_static.dir/build.make:62: recipe for target 'src/plugin/exViewPlugin/CMakeFiles/exViewPlugin_static.dir/exViewPlugin.cpp.o' failed
make[2]: *** [src/plugin/exViewPlugin/CMakeFiles/exViewPlugin_static.dir/exViewPlugin.cpp.o] Error 1
CMakeFiles/Makefile2:430: recipe for target 'src/plugin/exViewPlugin/CMakeFiles/exViewPlugin_static.dir/all' failed
make[1]: *** [src/plugin/exViewPlugin/CMakeFiles/exViewPlugin_static.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

Hi
please check if you have set TENSORRT_ROOT path in CMakeLists.txt

Hi
please check if you have set TENSORRT_ROOT path in CMakeLists.txt

(trt) root@8c74b39d4dd2:/opt/amirstan_plugin/build# cmake ..
......
-- Found TensorRT headers at /usr/include/x86_64-linux-gnu
-- Find TensorRT libs at /usr/lib/x86_64-linux-gnu/libnvinfer.so;/usr/lib/x86_64-linux-gnu/libnvparsers.so;/usr/lib/x86_64-linux-gnu/libnvinfer_plugin.so
-- Found TENSORRT: /usr/include/x86_64-linux-gnu
my tensorrt version is <IP_ADDRESS>

Try change
INCLUDE_DIRECTORIES(${TENSORRT_ROOT}/include)
to
INCLUDE_DIRECTORIES(${TENSORRT_INCLUDE_DIR})
see if it works.

Try change
INCLUDE_DIRECTORIES(${TENSORRT_ROOT}/include)
to
INCLUDE_DIRECTORIES(${TENSORRT_INCLUDE_DIR})
see if it works.

Thanks，Isuccess. I change the CUB_ROOT_DIR and TENSORRT_ROOT to my dir.
eset(CUB_ROOT_DIR "/opt/cub-1.8.0")
set(TENSORRT_ROOT "/opt/TensorRT-<IP_ADDRESS>")
the cub-1.8.0 link: https://github.com/NVlabs/cub/releases, I download https://github.com/NVlabs/cub/releases/tag/v1.8.0

Congratulation
I will optimize install script in future. Make the installation much easier.


Added alibaba cloud oss driver

Implemented Alibaba cloud object storage service driver.
Adhering to this issue https://github.com/blockstack/gaia/issues/87

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.stern0 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


fix: [FFM-12188]: Support Webhook Format in FF Git Sync

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: Updates the webhook for FF docs to note that yaml validation for ff is not supported in the webhookn events tab
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6744b0ba01a1b336d149c006--harness-developer.netlify.app


Remove format from the credential response

according to https://github.com/openid/OpenID4VCI/pull/208/files

it seems to me that this format should not be removed anymore
https://github.com/openid/OpenID4VCI/pull/219

@peppelinux , if you agree, I suggest temporarily removing this issue from milestone 0.6, as this is still under discussion. I would keep this on our todo list.

we can remove it since it was reintroduced again by Torsten, I need to recheck it all before removing it

Actually, credential_configuration_id MUST NOT be present if format parameter is present
https://github.com/openid/OpenID4VCI/pull/219/files#diff-1f424614b35a9899813079f1b1f6218631a2aedd993368ccb89bb81a9eda0289R417
the parameter used is decided by the wallet not by the issuer. Therefore our implementation must support both.
I really don't like this.

Since it is in ID1 I would keep this in 0.6.0

Resolved by https://github.com/italia/eudi-wallet-it-docs/pull/371/files


[C++] ARROW_FORCE_INLINE is not correctly defined on non-Windows builds

Describe the enhancement requested
While working on some optimizations I noticed I needed to explicitly force inlining to prevent performance regressions, but ARROW_FORCE_INLINE is currently not defined for non-MSVC compilers.
A cross-platform macro for forcing inlining would be very useful.
Component(s)
C++

Issue resolved by pull request 40372
https://github.com/apache/arrow/pull/40372


Modals use unsafe lifecycle methods

components: Modal
reactstrap version #6.3.1
import method umd
react version #16.4.1
bootstrap version #4.0.0

What is happening?
When displaying a Modal in React.StrictMode, a warning is shown.
What should be happening?
The component should not use deprecated lifecycle methods.
Steps to reproduce issue

Render a Modal inside React.StrictMode

Error message in console
Warning: Unsafe lifecycle methods were found within a strict-mode tree:

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Modal

componentWillUpdate: Please update the following components to use componentDidUpdate instead: Modal

Learn more about this warning here:
https://fb.me/react-strict-mode-warnings

Code
Open the rendered page to see the error in the console.

I think this was fixed by c844ab1f0c4e02c2169e8ad19b18cc59bf4bd3c6.

Related to https://github.com/reactjs/react-transition-group/issues/429

https://github.com/reactjs/react-transition-group/blob/master/src/Transition.js#L213
Here is used unsafe ReactDOM.findDOMNode method. Could we replace it with reference and pass it to TransitionGroupContext.Provider in render?

any updates?

Any updates?

This is fixed in v8.

I am still seeing the error. To replicate, wrap a Modal in React.StrictMode

Legacy context API has been detected within a strict-mode tree.
The old API will be supported in all 16.x releases, but applications using it should migrate to the new version.
Please update the following components: Transition

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node
in div (created by Transition)

react v16.13.1
reactstrap v8.4.1

According to this, seems like the issue has been resolved. But weirdly enough, when I installed reactstrap, my package-lock.json has "react-transition-group": {       "version": "2.9.0"
manually updating the react-transition-group to latest version (4.4.1) didn't resolve this...
any idea what else can I do? Thanks in advance!

@aqeebimtiaz I'm not sure if I'll be doing a PR, kind of busy, but I took a jab at it. The issue is you have to add nodeRef to the Transition component.
So I tried it and it worked but the issue now is, if you don't pass a ref it will again throw that error, so innerRef becomes kind of a mandatory prop.

@aqeebimtiaz I'm not sure if I'll be doing a PR, kind of busy, but I took a jab at it. The issue is you have to add nodeRef to the Transition component.
So I tried it and it worked but the issue now is, if you don't pass a ref it will again throw that error, so innerRef becomes kind of a mandatory prop.
So inside Fade.js it should be something like
<Transition {...transitionProps} nodeRef={innerRef}>
      {(status) => {
        const isActive = status === 'entered';
        const classes = mapToCssModules(classNames(
          className,
          baseClass,
          isActive && baseClassActive
        ), cssModule);
        return (
          <Tag className={classes} {...childProps} ref={innerRef}>
            {children}
          </Tag>
        );
      }}
    </Transition>

Hi, Thanks for the fast reply, I tried to use your suggestions & follow this documentation. Unfortunately, nothing worked.

@aqeebimtiaz I'm not sure if I'll be doing a PR, kind of busy, but I took a jab at it. The issue is you have to add nodeRef to the Transition component.
So I tried it and it worked but the issue now is, if you don't pass a ref it will again throw that error, so innerRef becomes kind of a mandatory prop.
So inside Fade.js it should be something like
<Transition {...transitionProps} nodeRef={innerRef}>
      {(status) => {
        const isActive = status === 'entered';
        const classes = mapToCssModules(classNames(
          className,
          baseClass,
          isActive && baseClassActive
        ), cssModule);
        return (
          <Tag className={classes} {...childProps} ref={innerRef}>
            {children}
          </Tag>
        );
      }}
    </Transition>

Hi, Thanks for the fast reply, I tried to use your suggestions & follow this documentation. Unfortunately, nothing worked.

You have to pass an innerRef, if you don't pass it, it'll throw an error. So if you put something like
if(!innerRef) return

before the return <Transition> it will stop throwing that error.

Should it be reopened?
I see the same issue with the following deps in my package.json:
    "react": "^16.13.1",
    "react-dom": "^16.13.1",
    "reactstrap": "^8.5.1"
``

Still getting the warning in reactstrap 8.9.0

experiencing the same error in "reactstrap": "^8.10.1",


[TypeScript type definitions] Add layout props

Update https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-vertical-timeline-component/index.d.ts
Version 2.3

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/29324


Add Meteor.js support

Hi Jorik,
I'm a Meteor.js dev and volunteer package maintainer for Meteor. Hammer is a great multi-touch library, and adding it to Meteor's ecosystem will expose it to many new devs (Meteor has 20k+ stars on GitHub), likely bringing in new testers and contributors.
This PR will let you directly publish updated versions of the library as they become available. All you have to do is create an account at https://meteor.com/ (click SIGN IN, then Create account). After you've done that, please let me know the name of the account, and I'll add you as a maintainer.
I've already published the current version of the package on Atmosphere (Meteor's package directory). When you release new versions, you can publish them to Atmosphere with grunt meteor.
Thanks & best regards,
Dan, Meteor integrations team

Framework specific packaging belongs upstream, not in repo.


Migrate mock 712

hmm...does this work for you?
My personal understanding is that migration script should be done under here: https://github.com/omisego/plasma-contracts/tree/master/plasma_framework/migrations
Not sure if truffle is able to have multiple migration target......

yeah, no it doesn't. I was just testing :D


Multi language support?

The project has now
S-Chinese
T-Chinese
Japanese #322
German #337
Italian #341
English
Can people add an extra one or more language support?

Absolutely!  Some good candidates:

German (longer strings)
RTL language(s)

i suppose the assets/plants.json should also be translated?

@andhie that would be ideal but it's a large undertaking and is a very low priority for this sample project.

@tiembo I have added support for Arabic language on this PR #430


Support for generators will be removed

Hi, I have the following issue, I'm using koa 2.4.1

koa deprecated Support for generators will be removed in v3. See the documentation for examples of how to convert old middleware https://github.com/koajs/koa/blob/master/docs/migration.md

@wzalazar hey there. you didn't actually state what your issue was. might want to start there.

The problem is Koa2 no support generator anymore. Do you have any plan for supporting Koa2?
This is explained in the link https://github.com/koajs/koa/blob/master/docs/migration.md

I think what you wanted to say was that Koa v3 doesn't support the generator patterns any longer. Koa v2 has deprecated support for them. We have no immediate plans for updating this module, but if you're interested in opening a Pull Request to add support, we'd happily examine it for a new major version of koa-hbs.

I think what you wanted to say was that Koa v3 doesn't support the generator patterns any longer. Koa v2 has deprecated support for them. We have no immediate plans for updating this module, but if you're interested in opening a Pull Request to add support, we'd happily examine it for a new major version of koa-hbs.

Why is Koa no longer supporting generator functions?


Unable to fetch or Display shielded balance

Provide a proper docs or writeup on how to implement display >shielded balance on the interface

Shielded balance does not show up on namada interface when setup on a local chain.
Transparent balance does show up except for the shielded balance.

Shielded balance does not show up on namada interface when setup on a local chain.
Transparent balance does show up except for the shielded balance.

So I'm specifically referring to the namada - interface
Any changes or update I need to make so that the shielded balance show up

I'm pretty sure this is not a bug, since shielded balances are working locally for me.
One thing about shielded balances is that they currently take longer to load than the transparent balances. Also, the longer your local chain has been running, the longer the shielded balances take to load. We will hopefully be fixing that in the future though.
When balances are loading, the interface displays "-" for the balance. If shielded balances display as "-", that means you just need to wait until they load.
If the balance displays as "0" even though you have a non-zero balance, that probably means the query to get the shielded balance has timed out. This will also display as an error in the extension (not interface) console. In that case, you can try resetting your chain (due to the problem mentioned already with balances taking longer to load the longer your chain has been running). If you are running everything locally, you can also increase the query timeout (here).
This is the best workaround I can give for now until we fix the problem with shielded balance loading generally. I will close this for now as it doesn't seem to be a bug.

Well updating the timeout does not work either can you refer me to your working directory or codebase, tried a lot seem like there's an issue.

The codebase is just the main branch of this repository. You might also check your Namada version - it should be v0.31.4 currently. Also check the README of this repo and make sure you have followed the setup instructions correctly there (and if there is something that looks out of date in the README, please let us know!). Once you have tried that, if it is still not working please link your repository with a minimum reproducible example of the problem and I will take a look at it.


fix/distance-condition

Types of PR

[ ] New Features
[ ] Upgrade of existing features
[x] Bugfix

Link to the issue
Description
I've noticed that not every DistanceCondition is evaluated properly when the rule is equalTo
For a sample scenario presented below the defined DistanceCondition is false (from topic /simulation/context)
{"currentEvaluation":"Are all of [ego]''s distance to given position = [-0.330000] equalTo -0.330000?","currentValue":"false","name":"","type":"DistanceCondition"}

and the scenario fails.
I think that according to the sample scenario description, the lateral distance is -0.83 - -0.5 and equals to -0.33, so the distance condition should be true and the scenario should pass.
The checking, if two values are equal, is here.
The results.back() and value variables (from here) are of type Double which std::numeric_limits<Double>::epsilon is equal 0.00000000000000000
One of solutions is (as proposed in this PR) to cast results.back() to type double which std::numeric_limits<double>::epsilon is equal 0.00000000000000022
After applying this PR the DistanceCondition is true
{"currentEvaluation":"Are all of [ego]''s distance to given position = [-0.330000] equalTo -0.330000?","currentValue":"true","name":"","type":"DistanceCondition"}

and sample scenario passes.
Sample scenario
OpenSCENARIO:
  FileHeader:
    revMajor: 0
    revMinor: 0
    date: "1970-01-01T09:00:00+09:00"
    author: Test
    description: ""
  ParameterDeclarations:
    ParameterDeclaration: []
  CatalogLocations:
    VehicleCatalog:
      Directory:
        path: $(ros2 pkg prefix --share openscenario_experimental_catalog)/vehicle
  RoadNetwork:
    LogicFile:
      filepath: $(find-pkg-share kashiwanoha_map)/map
  Entities:
    ScenarioObject:
      - name: ego
        CatalogReference:
          catalogName: sample_vehicle
          entryName: sample_vehicle
  Storyboard:
    Init:
      Actions:
        Private:
          - entityRef: ego
            PrivateAction:
              - TeleportAction:
                  Position:
                    LanePosition:
                      roadId: ""
                      laneId: 34513
                      s: 10
                      offset: -0.5
                      Orientation:
                        type: relative
                        h: 0
                        p: 0
                        r: 0
              - LongitudinalAction:
                  SpeedAction:
                    SpeedActionDynamics:
                      dynamicsDimension: time
                      value: 0
                      dynamicsShape: step
                    SpeedActionTarget:
                      AbsoluteTargetSpeed:
                        value: 0
    Story:
      - name: story
        Act:
          - name: act
            ManeuverGroup:
              - maximumExecutionCount: 1
                name: maneuver_group
                Actors:
                  selectTriggeringEntities: false
                  EntityRef:
                    - entityRef: ego
                Maneuver:
                  - name: maneuver
                    Event:
                      - name: success
                        priority: parallel
                        Action:
                          - name: ""
                            UserDefinedAction:
                              CustomCommandAction:
                                type: exitSuccess
                        StartTrigger:
                          ConditionGroup:
                            - Condition:
                                - name: ""
                                  delay: 0
                                  conditionEdge: none
                                  ByEntityCondition:
                                    TriggeringEntities:
                                      triggeringEntitiesRule: all
                                      EntityRef:
                                        - entityRef: ego
                                    EntityCondition:
                                      DistanceCondition:
                                        coordinateSystem: lane
                                        freespace: false
                                        relativeDistanceType: lateral
                                        rule: equalTo
                                        value: -0.33
                                        Position: &POSITION_1
                                          LanePosition:
                                            roadId: ""
                                            laneId: 34513
                                            s: 10
                                            offset: -0.83
                                            Orientation: &DEFAULT_ORIENTATION
                                              type: relative
                                              h: 0
                                              p: 0
                                              r: 0
                                - name: ""
                                  delay: 0
                                  conditionEdge: none
                                  ByValueCondition:
                                    SimulationTimeCondition:
                                      value: 5
                                      rule: greaterThan
                      - name: failure
                        priority: parallel
                        Action:
                          - name: ""
                            UserDefinedAction:
                              CustomCommandAction:
                                type: exitFailure
                        StartTrigger:
                          ConditionGroup:
                            - Condition:
                                - name: ""
                                  delay: 0
                                  conditionEdge: none
                                  ByValueCondition:
                                    SimulationTimeCondition:
                                      value: 7
                                      rule: greaterThan
            StartTrigger:
              ConditionGroup:
                - Condition:
                    - name: ""
                      delay: 0
                      conditionEdge: none
                      ByValueCondition:
                        SimulationTimeCondition:
                          value: 0
                          rule: greaterThan
    StopTrigger:
      ConditionGroup: []

How to review this PR.
Others

Currently, we are releasing version 0.8.0.
This pull request temporary change to draft.


B jeon camera swap

Created two cameras that can be swapped with the enter button. I only made two because I didn't know how many we wanted. These cameras are a regular one and like a top down view. If we need to add more cameras the set up is all there so it wouldn't take much time.  There are also scripts on yarn ball that was scrapped so we can get rid of those.

Sorry I tried to rebase your changes but it was difficult due to the latest merges. I don't want to break your changes, so I believe the easiest path for you would be fetching the latest develop branch and starting a new branch from there, and then copying your changes onto the new branch. If you need any help with that, please let me know, so we can help you get back to where you were as easily as possible. As it is, we can't merge the current changes. Moving forward, please be cautious about adding files to the commit that are not part of the necessary changes.

I created a new branch for you and copied the necessary files so hopefully you should be able to continue working from there.
git fetch --all
git checkout BJeon-CameraSwap-RE


influx backup missing bucket data

Background:
I want to verify influx backup --bucket xxx. In testing, the output only is xxx.bolt.gz、xxx.manifest、xxx.sqlite.gz files for some bucket,  but on my influxdb instance, there is points on the bucket;
Steps to reproduce:
I dont know how to reproduce
Expected behavior:
Bucket data can be normally backup and restore.
Environment info:
System info: Linux 4.19.0-10-amd64 Debian 4.19.132-1 (2020-07-24) x86_64 GNU/Linux
InfluxDB version: InfluxDB 2.2.0
Influx version: Influx CLI 2.3.0 (git: 88ba3464cd) build_date: 2022-03-18T22:21:12Z

Hey @ZeroSean can you make sure that when you specify --bucket you are providing the bucket name? If you want to provide the id, use --bucket-id.
I was able to reproduce the issue when incorrectly supplying the name to --bucket and verified it behaves as expected with the correct flags. Closing as fixed, but feel free to respond if this was not the error.


Overwritten return_to url when MFA setup must be enforced before backup codes check

If the user has 3 or less backup codes left, (s)he should be presented with a “Regenerate backup codes” screen and offered to regenerate the codes or continue to sign in:

However, if the user has no totp authenticator linked, in the above case the user will be first redirected to set it up (see here) and after doing so, redirected to /ui/setup_complete without ever going to the backup codes screen.
It is a minor bug but may require admin intervention if the user doesn't end up adding totp and all the backup codes are eventually used.
I think the issue is both in frontend and backend:

if MFA setup is enforced, we redirect to setup_secure and return without getting to this check.
the latter return_to is overwritten here and is always forcing the redirection to setup_complete page.

The setup_complete page is supposed to fetch the return_to from the flow and redirect the user there after a short period of time. I think that the issue was always there and the backend should handle it, although it is not clear to me right now how that should be done (maybe we could over-ride the return_to of the login flow with one to regenerate the codes and then return the user to the original return_to)

if MFA setup is enforced, we redirect to setup_secure and return without getting to this check.
the latter return_to is overwritten here and is always forcing the redirection to setup_complete page.

What if we perform the backup code check before the mfa one?
Could that help?
@natalian98

What if we perform the backup code check before the mfa one? Could that help? @natalian98

Yes, that works as well. Thanks for pointing out an easy solution


SEO

?

?

I think that now that we're close to the MVP, it should be nice adding SEO so people can find the app by looking for "online sketch app" and more!

Maybe this for now is a low priority task. Let's focus on app enhancements


Final group capstone - Set up your Kanban board

We opened this issue to review our Kanban board if it is as requested. 👀
This issue is open to review my Kanban Boards. Here are the links:
Frontend Board
Backend Board

Our team has 2 members:
@Donard97  & @ahzia

Project requirements that are done

Create an empty repository for your group project. ✔
Open the GitHub project (Kanban board) in your team repo ✔
Create cards based on the project requirements ✔
Each of the team members should assign themselves to the cards ✔

Feel free to review our Kanban Board and if u have any questions please ask me! ✌

Hi @Donard97, @ahzia,
Good job so far!
There are some issues that you still need to work on to move forward but you are almost there!
Suggested changes

[ ] Please add a screenshot of your kanban boards to this Issue description.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the Issue thread if something is not 100% clear.
Please, do not open a new Issues for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

@MuriloRoque Thank you for the feedback. I added the screenshots of the boards! ✌

Hi @Donard97, @ahzia,
In my opinion, your project is complete! There is nothing else to say other than... it's time to start it :shipit:
Good luck! 🎉
Feel free to leave any questions or comments in the Issue thread if something is not 100% clear.


[ZEPPELIN-2900] Close connection on getUserList

What is this PR for?
This PR fixed a JDBC connection leak on GetUserList.getUserList when the Shiro Realm is a JdbcRealm. After a while, it's not possible to even login into zeppelin.
What type of PR is it?
Bug Fix
Todos
N/A
What is the Jira issue?
ZEPPELIN-2900
How should this be tested?
In order to reproduce the bug follow this steps:

Configure zeppelin to use a JdbcRealm for authentication with a low number of connections in the connection pool.
Login into zeppelin and open a notebook.
Open the permissions form of the notebook.
Try to add several users to the owners list (more than the number of connections of the connection pool.

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No.
Is there breaking changes for older versions? No that I'm aware.
Does this needs documentation? No.

Thanks @lvicentesanchez for the fix. LGTM

Merge to master and branch-0.7 if no further comment


Very unstable, almost unusable

We have observed frequent crashes when using the app during various interactions. While it is functional to some extent, its reliability is questionable as it tends to fail more frequently than it succeeds. To illustrate this, we have included a sample of the crash log.
Traceback (most recent call last):
  File "whisper\transcribe.py", line 243, in transcribe
  File "tqdm\std.py", line 1256, in update
  File "tqdm\std.py", line 1361, in refresh
  File "tqdm\std.py", line 1509, in display
  File "tqdm\std.py", line 350, in print_status
  File "tqdm\std.py", line 343, in fp_write
  File "tqdm\utils.py", line 145, in inner
  File "buzz\conn.py", line 11, in write
  File "multiprocessing\connection.py", line 211, in send
  File "multiprocessing\connection.py", line 285, in _send_bytes
BrokenPipeError: [WinError 232] The pipe is being closed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "multiprocessing\process.py", line 314, in _bootstrap
  File "multiprocessing\process.py", line 108, in run
  File "buzz\transcriber.py", line 475, in transcribe_whisper
  File "buzz\transcriber.py", line 546, in transcribe_openai_whisper
  File "whisper\transcribe.py", line 174, in transcribe
  File "tqdm\std.py", line 1154, in __exit__
  File "tqdm\std.py", line 1304, in close
  File "tqdm\std.py", line 1301, in fp_write
  File "tqdm\utils.py", line 145, in inner
  File "buzz\conn.py", line 11, in write
  File "multiprocessing\connection.py", line 211, in send
  File "multiprocessing\connection.py", line 285, in _send_bytes
BrokenPipeError: [WinError 232] The pipe is being closed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "main.py", line 36, in <module>
  File "Lib\site-packages\PyInstaller\hooks\rthooks\pyi_rth_multiprocessing.py", line 49, in _freeze_support
  File "multiprocessing\spawn.py", line 116, in spawn_main
  File "multiprocessing\spawn.py", line 129, in _main
  File "multiprocessing\process.py", line 329, in _bootstrap
AttributeError: 'NoneType' object has no attribute 'write'

Thanks for the report. Are you on the latest version, 0.8.1?

@chidiwilliams commented on May 30, 2023, 6:46 PM EDT:

Thanks for the report. Are you on the latest version, 0.8.1?

Yes, I am using the latest, actually it is more unstable in some models than others... the most problematic are the Faster Whisper and HuggingFace but Whisper is kind of stable but extreamly slow in my specs.

Please try the latest 1.0.0 version https://github.com/chidiwilliams/buzz/releases


fix: preserve jobserver file descriptors on rustc invocation to get TargetInfo

Then cargo asks rustc for TargetInfo, cargo passes environment variables that describe jobserver file descriptors, but doesn't actually passed them, because jobserver-rs sets FD_CLOEXEC by default and expects users to explicitly call Client::configure to pass them further. Rustc respects make jobserver, so this causes error - env vars refers to nonexistent file descriptors, which is ignored now.
This PR makes cargo compatible with https://github.com/rust-lang/rust/pull/113730, which attempts to catch such situations.

What cargo does when it wants to really run rustc (for compilation, with jobserver passed through properly) - changes CLOEXEC flags to false? Creates jobserver-rs client in some other way?

The jobserver crate has a method which forwards the jobserver to a given Command.

Method Client::configure takes Command, while TargetInfo::new uses ProcessBuilder, so removing env vars seems to be simpler solution.

I've updated PR description.

how it affects other programs

This PR affects only rustc invocation, so I'm not sure, what do you mean.

Why the solution is desired but not others

I don't know, if this solution is better. It shouldn't change anything, since now jobserver isn't used and it won't be used with this PR. Also, according to @bjorn3 "That rustc call doesn't use jobserver", so passing jobserver won't change anything, so it's may be better to use simplest solution.

A test that verifies the “wrong” behavior

My local test is makefile, called make -j 2, which contains + RUSTC=dummy cargo build, there dummy - some binary, that responds to dummy -vV, and checks that make variables (if any) points to existing file descriptors.
One option to write such test is to use some wrapper over rustc, which would verify that passed jobserver-related env vars from cargo don't refer to nonexistent file descriptors, but imho it would be enough to have such check in rustc, which my PR to rustc is intended to add.

The intent of this pull request is not immediately clear to me. What does this try to resolve in practice?

At high level:

The situation when jobserver exists, but is not being inherited, is often erroneous and at least suspicious.
https://github.com/rust-lang/rust/pull/113730 attempts to catch such situations.
This PR makes cargo compatible with https://github.com/rust-lang/rust/pull/113730.

(Even if the check in https://github.com/rust-lang/rust/pull/113730 is later made optional or relaxed due to incompatibilities in third-party tools that we cannot fix, with cargo we can indeed fix it so it's better to make it compatible.)
I'd personally follow https://github.com/rust-lang/cargo/pull/12447#issuecomment-1665360918 and Client::configure this rustc run even if it's tiny, just for consistency.

To fix CI, rebase onto master. See https://github.com/rust-lang/cargo/pull/12450

Branch rebased, thanks.
ProcessBuilder calls Client::configure, if inherit_jobserver provided one. Does this solution suit better (so I should update PR name and description)?
About test - should I add one, or it'd be enough to have check in rustc?

Thanks!
@bors r+

:hourglass: Testing commit 1e12538c96efe0a48c30e9b849915e904c6c407a with merge a07a12ac05471215af18c1454590a6dc4357e2a3...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing a07a12ac05471215af18c1454590a6dc4357e2a3 to master...


Add contributing guidelines & PR template

Closes #269 ("Proper style guide/contributing guidelines")

:timer_clock: Merging in ~12 hours if there're no objections.


feat: add maxConcurrency option

Closes #1212

It's better to release this with the next minor bump.

It's better to release this with the next minor bump.

I am waiting for you to review --shard before releasing a new version 😄

Is there a way to set this globally?
Usage:
  $ vitest run [...filters]

Options:
  -r, --root <path>                      Root path
  -c, --config <path>                    Path to config file
  -u, --update                           Update snapshot
  -w, --watch                            Enable watch mode
  -t, --testNamePattern <pattern>        Run tests with full names matching the specified regexp pattern
  --dir <path>                           Base directory to scan for the test files
  --ui                                   Enable UI
  --open                                 Open UI automatically (default: !process.env.CI))
  --api [api]                            Serve API, available options: --api.port <port>, --api.host [host] and --api.strictPort
  --threads                              Enabled threads (default: true)
  --single-thread                        Run tests inside a single thread, requires --threads (default: false)
  --experimental-vm-threads              Run tests in a worker pool using VM isolation (default: false)
  --experimental-vm-worker-memory-limit  Set the maximum allowed memory for a worker. When reached, a new worker will be created instead
  --silent                               Silent console output from tests
  --hideSkippedTests                     Hide logs for skipped tests
  --isolate                              Isolate environment for each test file (default: true)
  --reporter <name>                      Specify reporters
  --outputFile <filename/-s>             Write test results to a file when supporter reporter is also specified, use cac's dot notation for individual outputs of multiple reporters
  --coverage                             Enable coverage report
  --run                                  Disable watch mode
  --mode <name>                          Override Vite mode (default: test)
  --globals                              Inject apis globally
  --dom                                  Mock browser api with happy-dom
  --browser [options]                    Run tests in the browser (default: false)
  --environment <env>                    Specify runner environment, if not running in the browser (default: node)
  --passWithNoTests                      Pass when no tests found
  --logHeapUsage                         Show the size of heap for each test
  --allowOnly                            Allow tests and suites that are marked as only (default: !process.env.CI)
  --dangerouslyIgnoreUnhandledErrors     Ignore any unhandled errors that occur
  --shard <shard>                        Test suite shard to execute in a format of <index>/<count>
  --changed [since]                      Run tests that are affected by the changed files (default: false)
  --sequence <options>                   Define in what order to run tests (use --sequence.shuffle to run tests in random order, use --sequence.concurrent to run tests in parallel)
  --segfaultRetry <times>                Return tests on segment fault (default: 0) (default: 0)
  --no-color                             Removes colors from the console output (default: true)
  --inspect                              Enable Node.js inspector
  --inspect-brk                          Enable Node.js inspector with break
  --test-timeout <time>                  Default timeout of a test in milliseconds (default: 5000)
  --bail <number>                        Stop test execution when given number of tests have failed (default: 0)
  --retry <times>                        Retry the test specific number of times if it fails (default: 0)
  --diff <path>                          Path to a diff config that will be used to generate diff interface

We have a problem where vitest hogs too much CPU and ends up suffocating database operations (which is hosted on the same machine). I am not clear on how to tell Vitest to at most parallelize 80% CPU worth of threads.

Found it:
+ import os from 'node:os';
import path from 'node:path';
import { defineConfig } from 'vitest/config';

export default defineConfig({
  resolve: {
    alias: {
      '@': path.resolve(__dirname, './src'),
    },
  },
  test: {
    deps: {
      interopDefault: true,
    },
+    maxThreads: Math.ceil(os.cpus().length * 0.5),
    mockReset: true,
    outputFile: './src/__generated__/vitest/results.xml',
    reporters: ['verbose', 'junit'],
    testTimeout: 60_000,
  },
});

On a related note, I am not sure if defaulting to 100% of the CPUs is a great idea. It diminishes test stability.


Fix/key error in extract results

Input submission checklist

[ ] created a directory for each system based on the template directory
[ ] named and placed the directory with the following pattern: input_structures/prepared_structures/<set_name>/<system_name>

For each submitted directory:

[ ] filled in system preparation details in the PREPARATION_DETAILS.md file
[ ] added a PDB file with the protein named protein.pdb
[ ] removed any cofactors from the PDB file and placed them in cofactors.sdf
[ ] did not re-protonate the residues, but left protonation state of the protein unchanged
[ ] kept cystallographic waters and metals in the PDB file
[ ] tested the PDB and, if available, cofactors.sdf file using the input validation script
[ ] copied over the ligands SDF file to a file named ligands.sdf and removed any duplicate binding modes or protonation states, keeping the more favorable state

Summary of changes

Licensing agreement

[ ] I agree to release these inputs under the combined MIT and CCBY SA 4.0 licenses of this repository

This PR does two things

It adds some OSX files to our .gitignore that I notice get pulled into some PRs.
It uses .get to check if a key exists, I didn't notice the problem until now but without this PR, we get a KeyError instead of None if the key doesn't exists, but the conditional check we have expects a None instead of a KeyError

Hello @mikemhenry! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file industry_benchmarks/utils/extras/extract_results.py:

Line 110:80: E501 line too long (105 > 79 characters)

closing since I've merged this into #130


Update criteria.js

Summary by CodeRabbit

Bug Fixes

Corrected a typo in the dropdown item selection method.

Improvements

Enhanced control flow in criteria handling, improving functionality for checking existing criteria.
Adjusted asynchronous handling in criteria addition and value input processes, optimizing execution flow.

@coderabbitai review


Ip v6

Added support for IPv6 in OpenSSL connection.  The Connection is being established in IPv6, if that fails a fallback to IPv4 is done.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I pulled this PR and ran the tests, all passed.


feature: config=true as default option

Did you check the docs?

[X] I have read all the lazy.nvim docs

Is your feature request related to a problem? Please describe.
Many plugins uses .setup(opts) method for startup, and sometimes I'm fine with the default opts value the plugins offer.
Describe the solution you'd like
It would be nice to have config = true by default, as a global option like defaults.lazy and defaults.version currently does.
Describe alternatives you've considered
I can just set config=true for each plugins, but having this by default would be nice.
Additional context
No response

Not every plugin needs setup. Not something I'm interested in adding


Create proper Content-type header with charset

This commit migrates from npm mime to the seemingly better maintained
mime-types. This allows replacing the mime.lookup call by mime.contentType
This is moderately important for javascript files which are otherwhise updloaded
with a Content-type header without charset information possibly leading to
incorrect decoding by browsers (see https://github.com/ariya/phantomjs/issues/12867)

Good find!

Published in 0.10.1. Thanks!

thanks for integrating so fast :)

Hi there! I had to unpublish 0.10.1 because it was apparently using the wrong method and was causing errors (see #54). I'm happy to reconsider if you can find the root of the problem in #54.


 Use http://jsonlint.com/ to check.
YES

Have you searched our issue tracker to see if the issue already exists? If so, comment on that issue instead rather than creating a new issue.
YES

Are you running on the master branch? We work on the dev branch and then add that functionality to master when it is stable. Your issue may be fixed on dev and there is no need for this issue, just wait and it will eventually be merged to master.
DEV

Expected Behavior
No errors or normal info about problem with connection? Or mayby this is a way how to Nantic detects a bot?
Actual Behavior
Running bot and after few minutes get strange info:
[Errno 104] Connection reset by peer
Your FULL config.json (remove your username, password, gmapkey and any other private info)
Don`t need it.
Output when issue occurred
2016-08-23 07:14:14,268 [MoveToFort] [INFO] [moving_to_fort] Moving towards pokestop Fasada Teatru Wielkiego - 0.05km
[Errno 104] Connection reset by peer
2016-08-23 07:14:16,029 [MoveToFort] [INFO] [moving_to_fort] Moving towards pokestop Fasada Teatru Wielkiego - 0.05km
Steps to Reproduce
Run a bot
Other Information
OS: Debian SiD
Branch:  dev
Git Commit:<PHONE_NUMBER>892adf74920a9fd4e110f381b84f14
Python Version: Python 2.7.9

Think that might be output from the API.

Possible you got right but 1 time i see this that`s why i report this - better if dev take a look on this.

Don`t need it.

[2016-09-06 14:24:01] [MainThread] [MoveToFort] [INFO] ...
[2016-09-06 14:24:06] [MainThread] [  SpinFort] [INFO] Spun...
[Errno 104] Connection reset by peer
[2016-09-06 14:24:10] [MainThread] [MoveToFort] [INFO] Moving...
[Errno 104] Connection reset by peer
[2016-09-06 14:24:15] [MainThread] [ShowBestPokemon] [INFO]
config.json.map.example with modded altitude only & no pokemap run

@MZorzy Do you have social enabled?

yes. as map.example

check #5232 This is issue with social_handler.py

Please create a new issue, dont comment on a 14 day old one


Add support for Epic Issues API

There isn't another way to get Issues associated with an Epic, and Epic's by themselves are not all that useful.  Feels like this is a small modification to issues.go to add a ListEpicIssues function.
https://docs.gitlab.com/ee/api/epic_issues.html

This one is now added by #859


 It uses the /latest.json and just_updated.json endpoints to fetch the newest and most recently updated gems, dedupes them, then prunes them to only match ones that have been updated within the last 5 minutes.
Note: Since this is a branch and not a fork, we'll want to make sure the checks pass before merging.

Terraform plan LGTM - I think we're probably ok to merge this! https://github.com/ossf/package-feeds/runs/1819889438?check_suite_focus=true