Azcopy does not work with V10 but works with V8

Which version of the AzCopy was used?
Note: The version is visible when running AzCopy without any argument
Does no work with V10 but works with V8
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
Any command like login, cp etc..
What problem was encountered?
Times out - with below error
INFO: Scanning...
INFO: trying to copy the source as container/directory/list of files
failed to perform copy command due to error: cannot start job due to error: cannot list blobs for download. Failed with
error -> github.com/Azure/azure-storage-azcopy/vendor/github.com/Azure/azure-pipeline-go/pipeline.NewError, /go/src/gith
ub.com/Azure/azure-storage-azcopy/vendor/github.com/Azure/azure-pipeline-go/pipeline/error.go:154
HTTP request failed
How can we reproduce the problem in the simplest way?
Have you found a mitigation/solution?
No

command used - azcopy cp  "https://##.blob.core.windows.net/?##SAS###" "C:\mytest"--recursive=true

Hi @maheshward, thanks for reaching out!
Could you please show the full error?
This sounds familiar to me, do you have a proxy on your environment?

Here is the full error
INFO: Scanning...
INFO: trying to copy the source as container/directory/list of files
failed to perform copy command due to error: cannot start job due to error: cannot list blobs for download. Failed with error -> github.com/Azure/azure-storage-azcopy/vendor/github.com/Azure/azure-pipeline-go/pipeline.NewError, /go/src/github.com/Azure/azure-storage-azcopy/vendor/github.com/Azure/azure-pipeline-go/pipeline/error.go:154
HTTP request failed
Get https://inspoceustostage01.blob.core.windows.net/test?comp=list&include=metadata&restype=container&se=2019-08-01T14%3A39%3A03Z&sig=8IAJHBIZ%2F%2FZMjKx2oo9xb347XUGq6qEc1X2zd%2F786cI%3D&sp=rwdlacup&spr=https%2Chttp&srt=sco&ss=bfqt&st=2019-07-02T06%3A39%3A03Z&sv=2018-03-28&timeout=901: dial tcp <IP_ADDRESS>:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

Here is the full error
INFO: Scanning...
INFO: trying to copy the source as container/directory/list of files
failed to perform copy command due to error: cannot start job due to error: cannot list blobs for download. Failed with error -> github.com/Azure/azure-storage-azcopy/vendor/github.com/Azure/azure-pipeline-go/pipeline.NewError, /go/src/github.com/Azure/azure-storage-azcopy/vendor/github.com/Azure/azure-pipeline-go/pipeline/error.go:154
HTTP request failed
Get https://##blobname###.blob.core.windows.net/test?comp=list&include=metadata&restype=container&se=2019-08-01T14%3A39%3A03Z&sig=8IAJHBIZ%2F%2FZMjKx2oo9xb347XUGq6qEc1X2zd%2F786cI%3D&sp=rwdlacup&spr=https%2Chttp&srt=sco&ss=bfqt&st=2019-07-02T06%3A39%3A03Z&sv=2018-03-28&timeout=901: dial tcp <IP_ADDRESS>:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

@maheshward thanks for sharing the error message!
Could you please give the latest version (v10.2.0) a try? We've added support for auto-detection of proxy from IE/Edge.

@maheshward I don't think you've answered Ze's question about proxy servers. But it does look like maybe a proxy issue. Fortunately, version 10.2.1 was released this week, and it automatically finds the proxy in Windows.  Can you try version 10.2.1 please? https://aka.ms/downloadazcopy-v10-windows

@maheshward I'm going to assume this is fixed now, because we haven't heard from you recently, and I'm going to close this issue. Please let us know if you are still having problems.


lorri: Release 1.1

Closes https://github.com/target/lorri/issues/424.

[x] Bump version (checked for major breakage)
[x] Update nix dependencies
[x] Went through commits and made sure the changelog is complete

We probably want to rebase this onto https://github.com/target/lorri/pull/426

Everything green but travis


Component values

Thanks for your great design!
I'm currently picking all the parts to build my own full size V3. I have a few questions about some of the components:
L7 has a value of 8.2uH in a 0402 package. Is this really correct?
C21 is EOL and no longer available. Can I choose a different part? What are the requirements for the component?
Could you provide me with the components you use for botch oscillators? I have a hard time picking a correct model.
Thanks!

L7 should be 8.2nH, I'll fix that typo, thanks!
C21 is decouple cap for GPS antenna power, so it is fine to replace with other similar cap,
just pick NP0 and it will be fine, the voltage rating for 47pF will be more than enough but just make sure it is larger than 6.3V
NT3225SA for 32Mhz TCXO
2725T for 133Mhz XO

Yeah.. I think that's a little bit overkill, maybe replacing it with 100ohm will be fine.

The problem - is that SX1301 don't see SX125X chips on SPI bus at all with that loarge resistors. I replaced them to 0R and gateway starts working as expected.


preserveSymlinks option not honored

Current behavior
If you have folders of code that are symlinked into src (very common pattern for monorepo style development), the type checker does not re-trigger when those files are changed.
Expected behavior
I should be able to make changes to those symlinked files and have the typechecker correctly re-run checks.
Steps to reproduce the issue
Setup a basic CRA app with typescript enabled. Have another folder of typescript code sitting as sibling to your project. Create a symlink within the CRA src folder to your "shared" folder.
add "preserveSymlinks": true, to your tsconfig.json.
If you create a typescript error on purpose in the shared code and start the app you will observe the checker does correctly pick up the code and display the error. However, if you fix the error, the checker does not automatically re-check as it would if the file lived natively in the CRA app's src dir.
Environment

fork-ts-checker-webpack-plugin: 1.5.0 (from current version of CRA scripts)
typescript: 3.5.3
tslint: N/A
webpack: 4.39.1 (current version in CRA)
os: Mac 10.13.3 (AND Ubuntu 18.04)

Thanks for the detailed report. I'm afraid I'm not able to look at this myself right now. This is definitely functionality we would want. If you'd like to take a look we're happy to look at PRs and collaborate!

I think this problem is coming from chokidar, https://github.com/paulmillr/chokidar/issues/696.
They fixed it in the version 3.x. We only need to update the version here.

I think this problem is coming from chokidar, paulmillr/chokidar#696.
They fixed it in the version 3.x. We only need to update the version here.

I was trying to create a branch for this fix but I am not able to publish my branch due to access to this repo. Could you please provide me the access?

Hi @gyancse08,
Thanks for looking into this! Please could you fork the fork-ts-checker-webpack-plugin repo, work on that and send a pull that way?

When I publish my branch I am getting this error:
"You do not have permission to access this repository".
only change is following, I will appreciate if someone else fixes the same.

"chokidar": "^2.0.4",

"chokidar": "^3.2.1",

"@types/chokidar": "^1.7.5",

"@types/chokidar": "^2.1.3",

You need to fork this project and then send a pull request, that's the "github workflow". :)
Here's some more information: https://help.github.com/en/articles/creating-a-pull-request-from-a-fork

@ryedin
Please try fork-ts-checker-webpack-plugin@alpha - I've published a new version which should resolve this issue 🚀
I will close this issue to clean-up the backlog. If this release didn't solve the issue, we can re-open this :)

@piotr-oles Hi, the v5.0.0@beta fixed the problem for me within my npm@7 workspace project. The v6 master branch detects a change, but it continues to compile with the previous file contents, not the new contents. Have these commits been merged into the latest master?

@piotr-oles Hi, the v5.0.0@beta fixed the problem for me within my npm@7 workspace project. The v6 master branch detects a change, but it continues to compile with the previous file contents, not the new contents. Have these commits been merged into the latest master?


comment out maven CI integration tests until we have whitelisting https://openshift.io/openshiftio/openshiftio/plan/detail/951

[merge]


Prevent hooks firing during using plugin cli

I believe the plugin should prevent firing pipeline hooks during using its cli, as it creates unpredictable issues.
Example with Mlflow plugin:
We use kedro-mlflow plugin
We have in the project two envs: local and remote.
Remote env contains catalogs proper paths to the data in cloud storage, and the config for mlflow on the cloud and kubeflow config.
The developer/cicd doesn't have access from the local machine to the remote mlflow API
When the developer/cicd tries to compile a pipeline or upload it using --env remote following happens:
The instance of ContextHelper is created:

Kedro Session is created
Kedro context is initialized
after_context_created hook is triggered
catalog instance is retrieved
after_catalog_created hook is triggered
Mlflow plugin has after_catalog_created  hook which tries to access to mlflow API
Developer/cicd does not have access to mlflow API on remote env
compiling/uploading fails

This behavior is not needed and not expected. The kubeflow plugin only needs to get catalog and pipeline parameters and proper KFP configs to create proper KFP.

If this proposal looks fine I'd like to assign this to myself


Exp loss on pvp

Players on my server report losing exp on a pvp death.  When they press space to respawn, exp loss.

Hello!
VRising counts death, if not drained by other vampire as suicide, i'll see what i can do.


Fixable error is not fixed

Sample code: https://github.com/WhyNotHugo/python-barcode/blob/f824d00592daabbe62a9c9a68b7a3113c215207d/barcode/writer.py#L264
> ruff .
barcode/writer.py:264:17: SIM108 [*] Use ternary operator `xpos = bxs + (bxe - bxs) / 2.0 if self.center_text else bxs` instead of if-else-block
Found 1 error.
[*] 1 potentially fixable with the --fix option.

> ruff --fix .
barcode/writer.py:264:17: SIM108 [*] Use ternary operator `xpos = bxs + (bxe - bxs) / 2.0 if self.center_text else bxs` instead of if-else-block
Found 1 error.

But nothing is fixed. pyproject.toml:
[build-system]
requires = ["setuptools>=45", "wheel", "setuptools_scm>=6.2"]

[tool.setuptools_scm]
write_to = "barcode/version.py"
version_scheme = "post-release"

[tool.black]
target-version = ['py37']

[tool.ruff]
select = [
    "E",
    "F",
    "W",
    "B0",
    "I",
    "UP",
    "N",
    "C4",
    "PT",
    "SIM",
    "TID",
]
target-version = "py37"

[tool.ruff.isort]
force-single-line = true

The problem is likely that fixing this error would result in a line that exceeds the specified line length.

Which is intended -- that we skip the fix -- but could be better communicated in the output.

Also related: https://github.com/charliermarsh/ruff/issues/1791.
It would be hard to know what to do with the placement of the comment too which may no longer make sense.
I guess it does say "potentially fixable" 😅

Makes perfect sense to skip the change if there are comments.
But also agree that output should make clear what's up.

We should probably detect that we won't fix that case, and not add the [*], and not include it in the list of potentially fixable errors.

(Oh sorry, I didn't actually look at the code -- it is indeed because of the comment, that we avoid fixing it. But we should still make that clear.)

shouldn't the comment cause that it's not detected as SIM108 as the comment is the reason that it should not be written as one-liner?

We used to have that behavior but I changed it. It led to confusing behavior like https://github.com/charliermarsh/ruff/issues/2442 whereby adding a noqa comment would turn off that check and lead to an unused noqa.


Can i run on command line (CI/CD) without JUnit  ?

Can i run on command line without JUnit  ?
So , I need test to RestAPI (Asp.net Core/OpenAPI/ Swagger)

@seebosmile , yes, you can. But we need to know more details around it. Will come back on this.
Are you on Slack?
If not, can you please join Slack and our mailing-list?

@authorjapps  i join to Slack already , thank you


feat: extended native-image build options

Summary
Adds more integration points with Bazel's build settings. Initial Platforms stuff might happen in this PR too. Targeting #80 for release if possible (we'll see).
Not yet implemented:
Needs integration with Bazel's Platforms feature, and transition implementations.
Related issues:

#78
#89
#108

Usage
There is a new native_image_settings target, which can be used to specify an explicit bundle of Native Image compilation settings:
load(
  "@rules_graalvm//graalvm:defs.bzl",
  "NativeCompilerBackend",
  "NativeLibC",
  "NativeArchitecture",
  "NativeOptimization",
  "native_image_settings",
)

native_image_settings(
    name = "cool_settings",
    backend = NativeCompilerBackend.LLVM,  # or `NATIVE`
    libc = NativeLibC.GLIBC,  # or `MUSL`
    opt = NativeOptimization.FASTBUILD,  # or `OFF`, `DEFAULT`, or `OPTIMIZATION_LEVEL_[1|2]`
    arch = NativeArchitecture.NATIVE,  # or `COMPATIBILITY`, `AMD_64`, `ARM_64`
)

native_image(
  name = "my_binary",
  # ...
  settings = ":cool_settings",
)

Overriding options via Bazel Configurations
native_image_settings(
    name = "cool_settings",
    arch = NativeImageArchitecture.NATIVE,  # or `COMPATIBILITY`, `AMD_64`, `ARM_64`

    # (`settings` is implied by default, pass `None` to opt-out)
    settings = "@rules_graalvm//graalvm/native_image:defaults",
)

If you do nothing at all, or map the settings property this way (or provide your own equivalent native_image_info advice target), then certain flags will override your native_image_settings. With the above configuration, settings are effectively resolved from the following places, in order:
1) Overrides provided by the command line, like below
2) Explicit settings declared in the mapped `native_image_settings` bundle
3) Sensible defaults provided by `rules_graalvm` (for example, `compilation_mode` → `O[x]`)

This allows you to set a default march, for instance:
native_image_settings(
  name = "settings",
  arch = NativeArchitecture.COMPATIBILITY,
)

native_image(
  # ...
  settings = ":settings",
)

Which you can override easily on the command line when desired:
bazel build //your/native:target --@rules_graalvm//graalvm/nativeimage/options:arch=native

How you know it's working
In the native-image build output, the target machine will be set accordingly:
bazel build //your/native:target --@rules_graalvm//graalvm/nativeimage/options:arch=native

========================================================================================================================
GraalVM Native Image: Generating 'main-native-bin' (executable)...
========================================================================================================================
For detailed information and explanations on the build output, visit:
https://github.com/oracle/graal/blob/master/docs/reference-manual/native-image/BuildOutput.md
------------------------------------------------------------------------------------------------------------------------
[1/8] Initializing...                                                                                (2.7s @ 0.17GB)
 Java version: 20.0.2+9, vendor version: GraalVM CE 20.0.2+9.1
 Graal compiler: optimization level: b, target machine: native

...

Opting out of rules-controlled flags
To remove (some) of the Rules-controlled flags and instead withhold them or provide them via extra_args, you can pass None to the settings attribute, which prevents override:
native_image_settings(
    name = "minimal",
    settings = None,
)

native_image(
  # ...
  settings = ":minimal",
)

In this case, these flags are withheld from automatic injection, although you may still need to provide some of them to complete a native-image build. Effectively, most flags take on GraalVM's defaults.
Changelog

feat: add experimental build setting which controls the march parameter

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: renovate[bot]:x: fmeumYou have signed the CLA already but the status is still pending? Let us recheck it.

closing for now


Improved Dispose and telemetry channel handling.

This is to fix https://github.com/Microsoft/ApplicationInsights-dotnet/issues/364.

@SergeyKanzhelev Changes made, please look again.

@dnduffy can you please minimize the fix by just mark channel as self-created when it is constructed by our internal code. Either from TelemetryClient or from Factory. Dispose channel only if self created in get-ter and Dispose method. I think this limited change will address the problem without "patching" of the design.
Bigger design change can be done with the upcoming features like multi-channel support

Codecov Report

Merging #406 into develop will increase coverage by 0.03%.

@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
+ Coverage    84.86%   84.89%   +0.03%
===========================================
  Files          141      141
  Lines         5721     5753      +32
  Branches       833      837       +4
===========================================
+ Hits          4855     4884      +29
+ Misses         528      527       -1
- Partials       338      342       +4

Impacted Files
Coverage Δ

...y/Implementation/AsyncLocalBasedOperationHolder.cs
92.59% <ø> (ø)
:white_check_mark:

.../Implementation/CallContextBasedOperationHolder.cs
88.88% <ø> (ø)
:white_check_mark:

.../Implementation/Tracing/PortalDiagnosticsSender.cs
70.73% <ø> (-4.88%)
:x:

src/Core/Managed/Shared/TelemetryClient.cs
71.73% <ø> (-2.18%)
:x:

...Core/Managed/Shared/Channel/InMemoryTransmitter.cs
92.59% <100%> (+19%)
:white_check_mark:

...sibility/Implementation/Tracing/CoreEventSource.cs
33.6% <100%> (+2.19%)
:white_check_mark:

src/Core/Managed/Shared/Channel/InMemoryChannel.cs
52% <14.28%> (+6.54%)
:white_check_mark:

...plementation/Tracing/DiagnosticsTelemetryModule.cs
86.79% <50%> (-1.45%)
:x:

...ged/Shared/Extensibility/TelemetryConfiguration.cs
82.71% <77.77%> (-2.77%)
:x:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41eec0f...3e138b8. Read the comment docs.


Incorrect handling of formatting in table cells

What version of Hugo are you using (hugo version)?

$ hugo version
Hugo Static Site Generator v0.61.0/extended darwin/amd64 BuildDate: unknown

Does this issue reproduce with the latest release?
Yes.
Given a Markdown table like
Foo|Bar
---|---
`Yoyo`|Dyne

Then pasting it in the (supposedly correct) CommonMark editor at https://commonmark.org/help/tutorial/02-emphasis.html (click the 'Try It' button to get to the Marrkdown editor) produces a table with two rows (one for the header, one for the data)  and two rows.  In particular, 'Yoyo' . and 'Dyne' are in separate columns, with 'Yoyo' being formatted with a fixed-width font.
With Hugo, the backticks cause 'Yoyo' . and 'Dyne' to get merged into a single column. Removing the backticks (i.e. removing the formatting) causes two columns to be generated again.

Thanks for the report. This looks like it could be an issue with Goldmark. Could you create an issue at https://github.com/yuin/goldmark/issues and link back to this issue so we could track it?

I considered creating a Goldmark issue but I'm asked to specify which version of Goldmark I'm using - alas, I don't know!
Also, when creating a Goldmark issue, it asks to verify that https://spec.commonmark.org/dingus/ produces different output than Goldmark. Which, in this case, is not the case.
In fact, the CommonMark editor at https://spec.commonmark.org/dingus/ and then one used by https://commonmark.org/help/tutorial/02-emphasis.html (after clicking the 'Try It' button) yield different results (I think the latter generates the more plausible result). So I'm not even sure it's a Goldmark bug or just a wrong expectation on my part based on doing the CommonMark tutorial...

The latest Goldmark renders this:

Foo
Bar

Yoyo|Dyne

Which does look correct to me.

https://github.com/yuin/goldmark/issues/69

Thanks a lot for creating the Go-based Goldmark issue so quickly - it's great to see how active both you as well as Yuin are.  Great job!


Refactor credentials into recipe globals

Currently credentials are passed around via an attribute on the Evidence objects, but we should probably use the Recipe globals for this so that we can keep all of the data passed around together and have a single way to access it.

@aarontp
I've started looking into this. Currently, the evidence pre-processors don't have access to the recipe globals. This is why I originally attached the credentials to the evidence item. It made sense to me to do it this way since the credentials apply to the evidence, and generally shouldn't be needed by tasks (with a few exceptions like Plaso).
Having said that, we can make a change to the base worker class to pass the recipe into the evidence pre-processor in evidence_setup, but not sure you still want to do that.
Happy to chat in more detail.


TSI SSL handshaker_factory reference counting tests

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Adding new length-based frame decoder for cases when the length field…

… is delimited, not fixed length, adding unit test
Motivation:
I am working on parsing Syslog over TCP (RFC 6587).  In this format, the frame length is in a field that is separated by a space from the data itself.  I wasn't able to find a built-in decoder in Netty to handle it, since the existing LengthFieldBasedFrameDecoder relies in a fixed-width length field.
Modification:
Added new decoder class and unit test, made io.netty.handler.codec.DelimiterBasedFrameDecoder#indexOf public so new class can call it
Result:
New decoder class and unit test

This is very much a work-in-progress, and I expect I will need to make more changes here.  I wanted to get it out early to get feedback, to see whether it's something that's even worth pursuing (as opposed to keeping it on our own project's code).  Known changes still needed:

adding Javadocs
potentially more unit test methods
determining utility class/approach for random seed management

@jeff303 use a Netty's code style please..

@fenik17 , apologies for not following the style.  I have applied the code style formatting now as per this doc.
I have introduced a new abstract base class for my new class, as well as LengthFieldBasedFrameDecoder, to put common methods/state in.

I looked into the TODO previously mentioned, regarding the existing LengthFieldBasedFrameDecoder return statement.  It turns out, there is no bug there.   Here is the relevant snippet.  The final return statement will always return null in the case I was concerned with (i.e. continuing to consume a too-long frame where there are still more bytesToDiscard.
        if (discardingTooLongFrame) {
            long bytesToDiscard = this.bytesToDiscard;
            int localBytesToDiscard = (int) Math.min(bytesToDiscard, in.readableBytes());
            in.skipBytes(localBytesToDiscard);
            bytesToDiscard -= localBytesToDiscard;
            this.bytesToDiscard = bytesToDiscard;

            failIfNecessary(false);
        }

        if (in.readableBytes() < lengthFieldEndOffset) {
            return null;
        }

I added a new test method to assert this behavior: LengthFieldBasedFrameDecoderTest#goodFrameAfterTooLongFrame, and I know there is probably a better way to do the assertByteBufsMatch method, or ideally an existing method.

Added a new check that I believe will address the DDoS concern, at least partially (i.e. ensure that delimiter relative offset is not more than max possible byte length of length field given the encoding), and a unit test for that check.
Regarding the extractFrame method, I kept the deprecated old version only in MarshallingDecoder, since that is what I understood needed to remain unchanged.
@fenik17 , still need some assistance with the multibyte issue.  Unignore the DelimitedLengthFieldBasedFrameDecoderTest#multiByteStrings method, and set a breakpoint in ByteBufUtil#encodeString0 with this condition: src.length() == 1 && charset.displayName().equals("UTF-16")
It seems that this encoding (which is actually of the separator string) is writing 4 bytes for the single space character, which is unexpected by me (should be 2 bytes for a single space in UTF-16).  Not sure why that is happening, but it's causing the delimiter to not be found at decode time.

Regarding the extractFrame method, I kept the deprecated old version only in MarshallingDecoder, since that is what I understood needed to remain unchanged.

No.. MarshallingDecoder just override the method from LengthFieldBasedFrameDecoder. To save an API compatibility we're should leave the both old methods in LengthFieldBasedFrameDecoder and MarshallingDecoder. I meant a such new structure:
class BaseLengthBasedFrameDecoder

protected ByteBuf extractFrame(ByteBuf buffer, int index, int length) {
    return buffer.retainedSlice(index, length);
}

-----------------------
class LengthFieldBasedFrameDecoder

/**
 * @deprecated use {@link BaseLengthBasedFrameDecoder#extractFrame(ChannelHandlerContext, ByteBuf, int, int)}
 */
@Deprecated
protected ByteBuf extractFrame(ChannelHandlerContext ignored, ByteBuf buffer, int index, int length) {
    return extractFrame(buffer, index, length);
}

-----------------------
class MarshallingDecoder

@Override
protected ByteBuf extractFrame(ByteBuf buffer, int index, int length) {
    return buffer.slice(index, length);
}

@Override
protected ByteBuf extractFrame(ChannelHandlerContext ignored, ByteBuf buffer, int index, int length) {
    return extractFrame(buffer, index, length);
}

Method from the  BaseLengthBasedFrameDecoder should be non static. And link to the ObjectDecoder in his javadoc is inactual..

need some assistance with the multibyte issue

Tests failed because encoded in UTF-16 and UTF-32 strings have a BOM (Byte order mark) at the start. But, even if you take the UTF-16LE (UTF-32LE/BE) encoding which haven't a BOM ... tests will fail due to a frameLength field contains the number of characters but not namber of bytes. It also will fail with UTF-8 and non one-byte characters (I tried string "4 блин"). Thus, a current realization works fine only with a latin encoding..

@jeff303 what do you think about the encodings? Do you intend to support not only one-byte encodings? For the fixed-sized encodings it's will be not very difficult. For the dynamic-sized there are some possible solutions...

@fenik17 , I would like to support them if I can figure out how.  I got tied up last week with some production issues, etc. so didn't get any time to spend on this.  Planning to pick it up again this week.  Any suggestions you have would be appreciated.

Perhaps the simplest and universal way is to convert all to String..

@fenik17 , we were overcomplicating.  In my original use case (ex: RFC 6587), the delimited length field actually specifies message size in bytes, not characters.  So it's a moot point (i.e. the sender of the frames is responsible for correctly calculating the byte lengths independent of encoding).
To be very precise, for my purpose (this RFC), I don't need to support multibyte encodings because it only permits single byte encodings.  However, I feel this may be useful in general so I started to get it working.  UTF-16 variants are working now, after doing some tricks with the byte order marks, but UTF-32 is still failing.  I may be OK with not supporting UTF-32, since it's not typically used for transmission anyway.

In this case, it's better to not support the encodings. I don't see the point of writing slow, over-complicated and hard-to-support code that no one will use. Work only with bytes, a MSG-LEN part consider by NONZERO-DIGIT (%d49-57). Let the user take care of the need to form the correct delimiter - cutting out the BOM or something else. And it will be great if you add an example of using new decoder based on rfc6587..
This is only my humble opinion :)

@fenik17 , I did as you suggested and got rid of all the charset support, assumed single byte encoding for length field digits (via UTF-8).  I can't quite figure out how to access the SonarQube report - is this just running SonarLint?

@jeff303 sonarqube reports through a @netkins comments.

@fenik17 , thanks, finally resolved the issues.  It took me a while to realize that it simply left the old comments up if they were still relevant with new commit.

@jeff303 I will take a look in a while.

Sorry it took so long but this one totally fall through the cracks. I will try to review this week.

Sorry for dropping the ball.. @jeff303 are you still interested in this change if so I will try to get it over the finish line.

Sorry for dropping the ball.. @jeff303 are you still interested in this change if so I will try to get it over the finish line.

Yes, I'm still interested.  I will rebase and update here.  Also, is the target branch still 4.1, or something else?

@jeff303 yes 4.1 please let me know once you did and I will have another look.

@jeff303 yes 4.1 please let me know once you did and I will have another look.

Should be rebased and up to date now.  Thanks.

Rebased onto 4.1 again.

Sorry but never where able to get this over the finish line and it seems like there is not much interesting the community (no-one else needed something like this it seems). Let me close this for now. Thanks for all your work and sorry for not merging it


DelegateParameterWithSetpoints

todo:

[ ] bind_to_instrument
[ ] inherit unit and label
[ ] Take care of the cache, e.g. Disable it :)
[ ] Smarter handling of validators - create new validators for the delegates with the same shape as source parameters if the provided delegate parameters dont exist.
[ ] Let the user pass instances of DelegateParameter for each setpoint, giving full flexibility to the users
[ ] test all behavior

@jenshnielsen i'd like to re-target and re-base this branch when we move to "main" in qcodes


Compile Error: USE_SYSTEM_BPF_BCC=ON

When i set USE_SYSTEM_BPF_BCC=ON, like:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index bbbac55f..6c37f097 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -11,7 +11,7 @@ include(GNUInstallDirs)
 set(WARNINGS_AS_ERRORS OFF CACHE BOOL "Build with -Werror")
 set(STATIC_LINKING OFF CACHE BOOL "Build bpftrace as a statically linked executable")
 set(STATIC_LIBC OFF CACHE BOOL "Attempt to embed libc, only known to work with musl. Has issues with dlopen.")
-set(USE_SYSTEM_BPF_BCC OFF CACHE BOOL "Use system libbpf and bcc instead of the repository vendored ones.")
+set(USE_SYSTEM_BPF_BCC ON CACHE BOOL "Use system libbpf and bcc instead of the repository vendored ones.")

 set(EMBED_USE_LLVM OFF CACHE BOOL "Use a prebuilt embedded LLVM, speeds up the build process")
 set(EMBED_BUILD_LLVM OFF CACHE BOOL "Build Clang&LLVM static libs as an ExternalProject and link to these instead of system libs.")

update submodule with git submodule update --recursive, AND run ./build-libs.sh, then, compile:
cmake \
	-DCMAKE_INSTALL_PREFIX=/usr/ \
	-DCMAKE_BUILD_TYPE=Debug \
	..
make -j$(nproc)

I got lots of error:
[ 66%] Building CXX object src/CMakeFiles/runtime.dir/format_string.cpp.o
[ 67%] Building CXX object src/CMakeFiles/runtime.dir/imap.cpp.o
[ 67%] Building CXX object src/CMakeFiles/runtime.dir/log.cpp.o
[ 68%] Building CXX object src/CMakeFiles/runtime.dir/map.cpp.o
[ 68%] Building CXX object src/CMakeFiles/runtime.dir/mapkey.cpp.o
/home/rongtao/Git/bpftrace/src/bpffeature.cpp: In function ‘bool bpftrace::try_load_(const char*, libbpf::bpf_prog_type, std::optional<libbpf::bpf_attach_type>, std::optional<unsigned int>, bpf_insn*, size_t, int, char*, size_t, int*)’:
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:44:35: error: expected primary-expression before ‘,’ token
   44 |     LIBBPF_OPTS(bpf_prog_load_opts, opts);
      |                                   ^
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:44:37: error: ‘opts’ was not declared in this scope
   44 |     LIBBPF_OPTS(bpf_prog_load_opts, opts);
      |                                     ^~~~
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:44:5: error: ‘LIBBPF_OPTS’ was not declared in this scope; did you mean ‘LIBBPF_API’?
   44 |     LIBBPF_OPTS(bpf_prog_load_opts, opts);
      |     ^~~~~~~~~~~
      |     LIBBPF_API
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:57:15: error: ‘bpf_prog_load’ was not declared in this scope; did you mean ‘bcc_prog_load’?
   57 |     int ret = bpf_prog_load(static_cast<::bpf_prog_type>(prog_type),
      |               ^~~~~~~~~~~~~
      |               bcc_prog_load
/home/rongtao/Git/bpftrace/src/bpffeature.cpp: In member function ‘bool bpftrace::BPFfeature::detect_map(libbpf::bpf_map_type)’:
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:176:15: error: ‘bpf_map_create_opts’ was not declared in this scope; did you mean ‘bpf_link_create_opts’?
  176 |   LIBBPF_OPTS(bpf_map_create_opts, opts);
      |               ^~~~~~~~~~~~~~~~~~~
      |               bpf_link_create_opts
[ 69%] Building CXX object src/CMakeFiles/runtime.dir/output.cpp.o
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:176:36: error: ‘opts’ was not declared in this scope
  176 |   LIBBPF_OPTS(bpf_map_create_opts, opts);
      |                                    ^~~~
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:176:3: error: ‘LIBBPF_OPTS’ was not declared in this scope; did you mean ‘LIBBPF_API’?
  176 |   LIBBPF_OPTS(bpf_map_create_opts, opts);
      |   ^~~~~~~~~~~
      |   LIBBPF_API
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:178:12: error: ‘bpf_map_create’ was not declared in this scope; did you mean ‘bpf_map_freeze’?
  178 |   map_fd = bpf_map_create(static_cast<enum ::bpf_map_type>(map_type),
      |            ^~~~~~~~~~~~~~
      |            bpf_map_freeze
/home/rongtao/Git/bpftrace/src/bpffeature.cpp: In member function ‘bool bpftrace::BPFfeature::has_map_batch()’:
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:278:15: error: ‘bpf_map_create_opts’ was not declared in this scope; did you mean ‘bpf_link_create_opts’?
  278 |   LIBBPF_OPTS(bpf_map_create_opts, opts);
      |               ^~~~~~~~~~~~~~~~~~~
      |               bpf_link_create_opts
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:278:36: error: ‘opts’ was not declared in this scope
  278 |   LIBBPF_OPTS(bpf_map_create_opts, opts);
      |                                    ^~~~
/home/rongtao/Git/bpftrace/src/bpffeature.cpp:278:3: error: ‘LIBBPF_OPTS’ was not declared in this scope; did you mean ‘LIBBPF_API’?
  278 |   LIBBPF_OPTS(bpf_map_create_opts, opts);
      |   ^~~~~~~~~~~
      |   LIBBPF_API

Do i miss some thing?

Do i miss some thing?

Yes, the minimum required versions of libbpf and bcc are now very high (effectively latest versions right now - 0.8.1 for libbpf and v0.25 for bcc) and few if any distros have those prepackaged. This is why we have them vendored in the repo.

I think that we can close this.


message column resizeable

#3

I tried your patch but it doesn't seem to do the first use case described here: https://github.com/ros-visualization/rqt_console/issues/3#issuecomment-303235981

make the initial size of the column big enough to use the available screen space

@LeroyR Friendly ping.


OTA-914: Adding release payload signatures to graph-data container

Description
oc-mirror to include signatures in the graph data image built (for the releases being mirrored by oc-mirror).
This PR improves the UX for getting signatures and using it in the disconnected environment. Refer epic https://issues.redhat.com/browse/OTA-946 for details.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Expected Outcome
Please describe the outcome expected from the tests

/lgtm

/approve

/cc


Dataset Viewer issue for Inspire-art/final

Link
https://huggingface.co/datasets/Inspire-art/final
Description
The dataset viewer is not working for dataset Inspire-art/final.
Error details:
Error code:   ResponseNotReady

Thanks for reporting, @AMEERAZAM08.
Apparently you have deleted the dataset: we get a 404 error from the URL above.

Thanks


The Google Pay button doesn't show up anymore

The Google Pay button doesn't show up anymore in mobile Chrome for a few days now in our web app with Stripe Checkout integration. On Desktop Chrome on Mac it shows up most of the time. I tried to reset the Browser settings, but this doesn't help. Was there a change deployed recently that causes this behaviour?
As a reference just open the following link and hit the "Donate now" button: https://www.thanku.social/en/app/donate?currency=EUR&donateeGroup=CleanOcean&price=1
Originally posted by @layflags in https://github.com/stripe/stripe-payments-demo/issues/9#issuecomment-663985749

Same behaviour after clicking on Preview Checkout button here: https://stripe.com/docs/payments/checkout

The Google Pay button on Stripe Checkout only shows if the Google Pay SDK is able to check the logged in account has an enrolled card. A couple things may prevent this from happening:

You are not logged into your Google account on which Google Pay is configured
3rd party cookies are blocked

You haven't described in which exact environment the Google Pay button is not showing up for you? I've just verified it is showing up on Chrome Android while logged into my Google account.
Chrome on iOS doesn't use the Blink engine and is really a WKWebView due to Apple's rules. Apparently Apple has been breaking 3rd party cookies in WKWebView on and off for iOS 13. I have just verified that on the latest iOS 13.6, third party cookies are blocked in Chrome, regardless of Safari's settings to disable ITP or not. There is unfortunately nothing anyone but Apple, can do about this, including Stripe or Google.
Related bugs on Apple's side:

https://bugs.webkit.org/show_bug.cgi?id=204109
https://bugs.webkit.org/show_bug.cgi?id=213510

Apparently the Google Pay SDK started throwing errors on Safari browsers so we disabled it entirely on July 2nd. We may be able to re-enable it on Chrome iOS only, but please realize that it would still not work in most iOS versions due to the 3rd party cookie blocking I mentioned.

Thanks for the quick response Mathieu! 3rd party cookies were blocked, that was the problem! Now it's working again in Chrome Mobile on Android. But I'm pretty sure it worked before when 3rd party cookies were blocked.
The Chrome team plans to block 3rd party cookies by default in the near future, like other browser vendors do it already. What's the plan if this happens?

That's a question for Google. We simply use their SDK in this case. I'm assuming they will find a way to make Chrome and Google Pay SDK work together.
There is also a lot of work currently going on at the W3C on standardizing payment methods in a privacy preserving way.

We've re-enabled Google Pay on Chrome iOS. It will only work when iOS doesn't block 3rd party cookies in iFrames in WKWebView.

We've re-enabled Google Pay on Chrome iOS. It will only work when iOS doesn't block 3rd party cookies in iFrames in WKWebView.

@hofman-stripe Is this only on Checkout? Is it ever possible to show the G Pay button (not the Pay Now button) with Elements?

Is it ever possible to show the G Pay button (not the Pay Now button) with Elements?

Unfortunately Elements is only a wrapper around the browser's PaymentRequest API, which doesn't allow us to differentiate between the payment method that is configured in the browser (Google Pay or saved card)

@hofman-stripe > I know but there is some other company they are using Google PAY API . I read the case study of boxed.com

Though most of the customer rely on apple pay / googe pay, hence customer is getting confused with Pay Now button in Chrome instead of Google Pay/ G Pay button.


Can not compile glsl-to-spirv on Linux

I get the following error:
❯ cargo build
    Updating registry `https://github.com/rust-lang/crates.io-index`
   Compiling cc v1.0.3
   Compiling quote v0.3.15
   Compiling unicode-xid v0.0.4
   Compiling tempdir v0.3.5
   Compiling syn v0.10.8
   Compiling cmake v0.1.28
   Compiling glsl-to-spirv v0.1.3
error: failed to run custom build command for `glsl-to-spirv v0.1.3`
process didn't exit successfully: `/home/arian/Documents/UU/MAGR/testit/target/debug/build/glsl-to-spirv-d084539756af8e77/build-script-build` (exit code: 101)
--- stdout
cargo:rerun-if-changed=build/glslangValidator.exe
running: "cmake" "/home/arian/.cargo/registry/src/github.com-1ecc6299db9ec823/glsl-to-spirv-0.1.3/glslang" "-DCMAKE_INSTALL_PREFIX=/home/arian/Documents/UU/MAGR/testit/target/debug/build/glsl-to-spirv-c942c32e229466fb/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_BUILD_TYPE=Debug"

--- stderr
fatal: Not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
thread 'main' panicked at '
failed to execute command: Permission denied (os error 13)

build script failed, must exit now', /home/arian/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.28/src/lib.rs:631:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed

I had to install cmake


Simple Brightscript example

just a test

Merge simple BS project for first CICD project with Ubuntu Server back end testing


-t requires a  argument but the help says it has a default value

$ cargo sweep --help
...
    -t, --time <days>                Number of days backwards to keep. If no value is set uses 30.
...
$ cargo sweep -t
error: The argument '--time <days>' requires a value but none was supplied

USAGE:
    cargo-sweep.exe sweep <--stamp|--file|--time <days>|--installed|--toolchains <toolchains>|--maxsize <maxsize>>

Also it appears that the --version flag doesn't work:
$ cargo sweep -V
cargo-sweep.exe-sweep
$ cargo sweep --version
cargo-sweep.exe-sweep
$ cargo sweep --version -v
cargo-sweep.exe-sweep

I installed with cargo install minutes ago so I have version 0.5.0.

As for --time's help text I agree that it's strange since an argument is required and I didn't notice any logic regarding some fallback value either (the current approach .expect()s a time value along with .expect()ing it being a valid u64
As for the version flag being weird I have a tentative fix opened in #58 since cargo is currently invoking a subcommand that doesn't have a version (hinted by the extra -sweep)

--version is working, and here's the --time wrong usage message:
$ cargo sweep -t
error: a value is required for '--time <TIME>' but none was supplied

And the help message.
$ cargo sweep --help
...
  -t, --time <TIME>
          Number of days backwards to keep

So this issue is solved (ping @jyn514).


[BUG] Trueshape and crowfly shape both represented in EMME visualization of Lasso-Created Network

Describe the bug
When wkt geometry for some links added to represent tru-shapes, they are not correct and seem to jump back and add vertices at a and b node.

The conversion from geojson to wkt seems to be working (see below picture)

But when wkt added to network (see line here) it produces the funky geometry.  What gives?

To Reproduce
cc: @i-am-sijia  if useful to add here
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Thoughts on resolution
Full stack trace

@inrokevin says this is a common problem. The direction is wrong on import. @i-am-sijia: please follow-up with Kevin when you return.

I know why.  In our standard format, two-way street's forward and backward links use the same shape.  Meaning if there are 1M links in link.json (assuming all two-way streets), there are 500k shapes in shape.geojson.
The solution is before writing out to EMME, I can create reverse shapes for backward links.  Below is the EMME network at the same location after this change.

@DavidOry @e-lo @inrokevin


What is the implementation method of Selective Retraining in the code base?

Hello, may I ask how to implement Selective Retraining in the code base?
Specifically, how does the second retraining load the first trained encoder's checkpoint while randomly initializing the other modules?
More specifically, in the main() function, I only see that the local function 'def reset_parameters()' is defined without any call, and the --resume interface loads all the weights of the first checkpoint training. At the same time, I did not find any re-initialization code for V+L encoder and transformer decoder.

Hi, you can use --freeze_encoder to keep the Transformer encoder continuing to train.
https://github.com/qumengxue/siri-vg/blob/1fa6b058645469ed73683034b438841eac0653ee/main.py#L291
Load only the parameters of the Transformer encoder
https://github.com/qumengxue/siri-vg/blob/1fa6b058645469ed73683034b438841eac0653ee/main.py#L469
or
https://github.com/qumengxue/siri-vg/blob/1fa6b058645469ed73683034b438841eac0653ee/main.py#L473


Need to programmatically pull GLM version

We'd like to be able to programmatically extract the GLM version and include it in the diagnostic tble we return from our model runs.
the function GLM3r::glm_version() returns a message, and the value 0:

    -------------------------------------------------------
    |  General Lake Model (GLM)   Version 3.1.0a4         |
    -------------------------------------------------------

     glm built using MSC version 1916
--help  : show this blurb
--nml <nmlfile> : get parameters from nmlfile
--xdisp : display temp/salt and selected others in x-window
--xdisp <plotsfile> : like --xdisp, but use <plotsfile> instead of plots.nml
--saveall : save plots to png files
--save-all-in-one : save all plots to png file
--save-all-in-one <destfile> : save all plots to png file <destfile>
--quiet   : less messages
--quiet <level> : set quiet level (1-10)
[1] 0

Jordan did some digging, and realized we could set stdout=TRUE to have the output go to the  assignment value. That gets us the following:
> out <- system2("C:/Users/hcorson-dosch/Documents/R/AquaticEcoDynamics/GLM/glm", wait = TRUE, stdout = TRUE, stderr = "", args = "--help")
> out
 [1] "     "
 [2] "    -------------------------------------------------------"
 [3] "    |  General Lake Model (GLM)   Version 3.1.0a4         |"
 [4] "    -------------------------------------------------------"
 [5] "     "
 [6] "     glm built using MSC version 1916"
 [7] "--help  : show this blurb"
 [8] "--nml <nmlfile> : get parameters from nmlfile"
 [9] "--xdisp : display temp/salt and selected others in x-window"
[10] "--xdisp <plotsfile> : like --xdisp, but use <plotsfile> instead of plots.nml"
[11] "--saveall : save plots to png files"
[12] "--save-all-in-one : save all plots to png file"
[13] "--save-all-in-one <destfile> : save all plots to png file <destfile>"
[14] "--quiet   : less messages"
[15] "--quiet <level> : set quiet level (1-10)"
> out[3]
[1] "    |  General Lake Model (GLM)   Version 3.1.0a4         |"

That almost gets us there, but there's two issues:

we'd need to parse that line with regex (not a big deal)
I'm having to manually provide my path to GLM, despite it being set with Sys.setenv(GLM_PATH = "C:/Users/hcorson-dosch/Documents/R/AquaticEcoDynamics/GLM/glm"), so we'd either need system2 to recognize that path or pass the path as an argument to our execution function (more of a pain).

In light of these issues, Jordan is recommending solving this issue at the GLM3r package level, by solving this issue he created and putting it in a PR to the package and then updating the package version.

First part of this doesn't require us to make the decision as to where we solve the problem (this repo vs the GLM3r pkg itself). We need to figure out how to extract "3.1.0a4" from "    |  General Lake Model (GLM)   Version 3.1.0a4         |"
After that we'll check back in with GLM3r devs/users to see if this feature would be useful to others and welcomed as an update to the pkg. I think it may be easier to do there because it already handles issues with different OS's and env variables.

Oh ok - I can tackle that regex, then, if you like.

Sorry, I was just stating how I'd approach the problem. I'm good with taking it on.

stringr::str_extract(" | General Lake Model (GLM) Version 3.1.0a4 |", '(?<=Version\\ ).+?(?=\\ )')
[1] "3.1.0a4"

Seems to do it. That would be a solution for the pipeline since we don't care about the stringr dependency. But that won't work for GLM3r pkg since we don't want to add other dependencies without a really good reason.
strcapture('(?<=Version\\ ).+?(?=\\ )', " | General Lake Model (GLM) Version 3.1.0a4 |", proto = data.frame(version = character(0)), perl = TRUE)
Error in strcapture("(?<=Version\\ ).+?(?=\\ )", " | General Lake Model (GLM) Version 3.1.0a4 |",  :
  The number of captures in 'pattern' != 'length(proto)'

Fails for me but not sure why it is capturing more than one thing

In base R:
regmatches(" | General Lake Model (GLM) Version 3.1.0a4 |", regexec("(?<=Version\ ).+?(?=\ )", " | General Lake Model (GLM) Version 3.1.0a4 |", perl = TRUE))[[1]]
[1] "3.1.0a4"

@hcorson-dosch this seems to be what we'd want: https://github.com/jread-usgs/GLM3r/commit/830d04ac5b29ca831cbea8ec98026190c331acd8
glm_version()

    -------------------------------------------------------
    |  General Lake Model (GLM)   Version 3.2.0a3         |
    -------------------------------------------------------

     glm built using gcc version 4.2.1
glm_version(as_char = TRUE)
[1] "3.2.0a3"

Great! should I go ahead and add this into my PR?

Sure - would you be adding the glm_version(as_char = TRUE) to your PR in that tibble and suggesting a GH install, or would you add the whole GLM3r change to the PR? I think I'd recommend the former, keeping this in GLM3r, and I can do a PR on that repo and also up the package version so it is clear what needs to be installed (and eventually, what needs to be in the shifter container). But let me know if you were thinking of pulling that whole change and backing code in here.

Oh, gosh, I'm sorry. I was referring to adding the regex only, but I was forgetting my own note about the glm path 🤦♀.
I can add either a) add glm_version(as_char = TRUE) and suggest a GH install, or b) leave my PR as is, and we can wait to add that to the tibble once the change is PR'd into GLM3r.

I think keeping your PR as-is and leaving this issue open until we resolve it would be good. We'll get a sense if others are interested in this functionality soon

Merged here https://github.com/GLEON/GLM3r/pull/24


Quick Start doesn't produce working project

What docs page needs to be fixed?

Section: Tutorials
Page: Redux Toolkit Quick Start

What is the problem?
Following the instructions on the page results in a non-functional project.
I'm using the React template on codesandbox.io and the quick start results in a project that errors out with state.counter is undefined in src/features/counter/Counter.js.
If I change the selector in Counter.js to work around the undefined member, I get this error in the console: "Store does not have a valid reducer. Make sure the argument passed to combineReducers is an object whose values are reducers." but the documentation says that combineReducers is called by configureStore for me, so I don't have to.
The quick start source code also makes reference to a Counter.module.css file that is not created by following the tutorial.
The example code at the end is way more elaborated than the quick start, and it also appears to be outdated.
I'm brand new to Redux, so I don't know what Redux wants from me at this point, and that's quite off-putting.
What should be changed to fix the problem?
Fix the Quick Start so that someone who hasn't seen Redux in their life can follow it and get it to work on first try.

@Uplink03 Sorry to hear that.  Can you do me a favor and put up the code that you have so far as a Github repo or CodeSandbox, so I can see exactly what you ended up with?

Well, damn. I thought I moved that file, and somehow it got copied, and I was editing and importing the wrong one without realising. I was just blind to which file was being opened and which one was imported, as in my mind I only had one: the one in 'app'.
The part about Redux DevTools is something I invented while desperate to figure out what was going on. It didn't help, but somehow, after I added it to the file (which wasn't even used), DevTools started to work (it was blank before that), adding to the confusion.
Thanks for pointing out my mistake.

No worries, glad this got sorted out!
FYI we've also got a #redux channel in the Reactiflux Discord ( https://www.reactiflux.com ), which is a great place to come by and ask questions.


Non-determinsim prevents caching of cc compilation using bazel disk cache

Relates to #96
It seems like something either in our bazel_ros2_rules, or something else, is non-deterministic that prevents cache hits.
First make sure you have --disk_cache and --repository_cache configured.
The following script can configure it automatically, if you prefer: https://gist.github.com/EricCousineau-TRI/ca97ccc404ece082885d71c559d83936
Then see that multiple clean+rebuild still cause things like talker_listener.cc to be recompiled:
$ cd drake-ros
$ git log -n 1 --oneline --no-decorate
416cf8b Rename not-shimmed executables (#112)
$ git diff  # for reproducibility
diff --git a/ros2_example_bazel_installed/WORKSPACE b/ros2_example_bazel_installed/WORKSPACE
index d390251..d3af953 100644
--- a/ros2_example_bazel_installed/WORKSPACE
+++ b/ros2_example_bazel_installed/WORKSPACE
@@ -40,6 +40,7 @@ ros2_archive(
     # TODO(hidmic,cottsay): Make release-pinned snapshots of this repository once `drake-ros`
     # itself has versions.
     url = "http://repo.ros2.org/ci_archives/drake-ros-underlay/ros2-humble-linux-focal-amd64-ci.tar.bz2",
+    sha256 = "b7a8982cdc07a090b9719e35ae4735df82f9f648d5b703b93bc9db51e448f81d",
     sha256_url = "https://repo.ros2.org/ci_archives/drake-ros-underlay/ros2-humble-linux-focal-amd64-ci-CHECKSUM",
     strip_prefix = "ros2-linux",
 )
$ cd ros2_example_bazel_installed/
$ bazel clean --expunge --async
$ bazel build //ros2_example_apps:talker_listener_cc_test
...
INFO: Elapsed time: 43.834s, Critical Path: 10.97s
INFO: 150 processes: 5 disk cache hit, 142 internal, 3 linux-sandbox.
INFO: Build completed successfully, 150 total actions
$ bazel clean --expunge --async
$ bazel build //ros2_example_apps:talker_listener_cc_test
...
INFO: Elapsed time: 41.517s, Critical Path: 11.12s
INFO: 150 processes: 5 disk cache hit, 142 internal, 3 linux-sandbox.
INFO: Build completed successfully, 150 total actions

\cc @sloretz @IanTheEngineer

My assumption is that something is non-deterministic causing the cache miss; there could be something else, but my money is on this.

Resolved by #128


Adding override flag in CreatChannelOptions.

This PR aims to provide an addtion of :

Override flag in CreatChannelOptions to have a capability of passing --override flag in CreateChannel transaction.

Thank you for the contribution! We will take a peek!


The vertical axis label is hidden

https://user-images.githubusercontent.com/4397067/104445135-b9e22c80-55d3-11eb-9fcb-4ce1d498f17d.mov
During the sliding process, I don’t know why the first and last labels of the vertical axis are hidden (no rule found), I don’t know what I did wrong

Wow, that is incredibly weird! I'll see if I can reproduce this

Wow, that is incredibly weird! I'll see if I can reproduce this

Hello, I wrote a demo program, which can reproduce the above problems stably. Please take a look at it. The following is the demo link address responsive_linechart_bug

Hello, I wrote a demo program, which can reproduce the above problems stably. Please take a look at it. The following is the demo link address responsive_linechart_bug

Thanks for the demo. I'll check it out asap.

Thanks for the demo. I'll check it out asap.

Hello, may I ask the question I have feedback, can you reproduce it smoothly through Demo? Is there any new progress in fixing the problem?

Hello, may I ask the question I have feedback, can you reproduce it smoothly through Demo? Is there any new progress in fixing the problem?

hi @chende008, I have not been able to look at it yet, but I should have some time today!

hi @chende008, I have not been able to look at it yet, but I should have some time today!

Hmm your sample app is broken on the latest release (5.5.0).
Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render.     in ForwardRef(Line) (at App.js:54)
I'll have to check this out first

Hmm your sample app is broken on the latest release (5.5.0).
Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render.     in ForwardRef(Line) (at App.js:54)
I'll have to check this out first

Issue should be fixed in v5.5.1, as well as the error I encountered above ^.
Turned out to be a floating point comparison going wrong: 0.4404 < 0.44039999999999
Thanks for providing a reproducible demo, would not have found it otherwise.

Issue should be fixed in v5.5.1, as well as the error I encountered above ^.
Turned out to be a floating point comparison going wrong: 0.4404 < 0.44039999999999
Thanks for providing a reproducible demo, would not have found it otherwise.

Thank you very much, confirm that the issue has been fixed!

Thank you very much, confirm that the issue has been fixed!


HOT error, BALANCE: Unknow

Hello,
I observed few errors happened recently when add new HOT game.
Step 101 - Timeout while trying to check for the start button (should not be present). Step 102 - Attempting to open a link for the app:  Step 102 - Successfully able to open a link for the app..  Step 103 - Attempting to click the 'Launch' button (probably not present)... ... Step 105 - Attempting to click the 'storage' link...  Step 106 - Found 0 elements with XPath: //p[contains(text(), 'HOT')]/following-sibling::img/following-sibling::p for Step 106 - Before BALANCE: Unknown .... Step 108 - Timeout while trying to get the pre-claim wait timer. Step 108 - Attempt 1: Wait time element not found. Clicking the 'Storage' link and retrying... ... Step 108 - Timeout while trying to click the 'storage' link. An error occurred on attempt 1: 'NoneType' object has no attribute 'text'
It seems like HOT game has had few updates recently on the new UI. Kindly look into it. Thanks

A note is that it is often happening for new accounts

Hi,
HOT has been having intermittent issues with its login system. It's currently back up, but this is the error from earlier in the evening:

Thanks


Improve gruntfile

Proposed changes
Collect Files dynamically for PUG Transpiling of docs.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue).
[x] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My commit messages follows the conventional commit format
[ ] My change requires a change to the documentation, and updated it accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

eh uh... what is this PR about and why there is so many changes? sweat_smile

this PR:
the last commit is the actual improvement. Actually i wanted to test a PR merge to the new dev-branch.
We should start to merge new features into the dev-branch and only hotfixes to the main branch.
see here: https://stackoverflow.com/questions/32826370/why-do-we-need-dev-branch
What are your thoughts?
The many commits were automatically added by Github and were taken from the main branch. So the dev-branch should now be up-to-date with the main branch.

ou I see
sorry if I'm kinda gone missing, I got busy elsewhere and I don't think I have time maintaining this anymore 😢
at first time reading this PR I got suprised because there's a lot of changes. If you want to sync branches, it should be on a separate PR so it's easier to understand. But I saw your recent PRs, you already do that so it's good then 👍
thanks for continuing the development btw 🙏


Screenshot taken with LiveTestWidgetsFlutterBinding is truncated

Internal: b/168776765
When using LiveTestWidgetsFlutterBinding, screenshots of top level widgets are truncated.
Context: We're trying to support screenshot testing in g3 with package:integration_test, where the widgets binding inherits from LiveTestWidgetsFlutterBinding. The following is a minimal repro with just flutter test.
Steps to Reproduce
Run flutter test with the following test file:
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  LiveTestWidgetsFlutterBinding();
  testWidgets('goldens', (tester) async {
    await tester.pumpWidget(buildTestApp());
    await expectLater(
        find.byType(MaterialApp), matchesGoldenFile('screenshot.png'));
  });
}

Widget buildTestApp() {
  final app = MaterialApp(
    title: 'Test',
    home: Scaffold(
      appBar: AppBar(
        title: Text('Title'),
      ),
    ),
  );

  // screenshot is taken for _LiveTestRenderView#c6f40
  return app;

  // screenshot is taken for RenderRepaintBoundary#f72ed
  // return RepaintBoundary(child: app);
}

Expected behavior: Screenshot covers the full MaterialApp.

Similar to this image from AutomatedTestWidgetsFlutterBinding (with L5 commented out)

Actual Image (which looks truncated)

When I added some instrumentation to the renderObject used for taking a screenshot at https://github.com/flutter/flutter/blob/fa646339d65a775bf0dd4c06655b65fc122c38ab/packages/flutter_test/lib/src/_matchers_io.dart#L32
The renderObject is a LiveTestRenderView: _LiveTestRenderView#c6f40.
Adding a RepaintBoundary around MaterialApp (the last second line of the snippet) fixes the issue.

LiveTestWidgetsFlutterBinding with RepaintBoundary Image

#12994 looks like it could be related. It is pretty unexpected that a RepaintBoundary is needed just for LiveTestWidgetsFlutterBinding, but not for the default AutomatedTestWidgetsFlutterBinding, so this could be a bug. With AutomatedTestWidgetsFlutterBinding, the renderObject used for the screenshot is RenderRepaintBoundary#1d14f.
Another thing I noticed is that if the following https://github.com/flutter/flutter/blob/fa646339d65a775bf0dd4c06655b65fc122c38ab/packages/flutter_test/lib/src/binding.dart#L1674 is set to
_paintMatrix = _getMatrix(size, 1.0, window)

the correct bounds are used for the image, though this probably isn't the correct fix.

Doctor Output
[✓] Flutter (Channel master, 1.22.0-10.0.pre.39, on Mac OS X 10.15.3 19D76, locale en-US)
    • Flutter version 1.22.0-10.0.pre.39 at /Users/jiahaog/dev/flutter
    • Framework revision a8281e31af (2 weeks ago), 2020-09-01 10:57:59 -0700
    • Engine revision 165abef0a2
    • Dart version 2.10.0 (build 2.10.0-77.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0-rc2)
    • Android SDK at /Users/jiahaog/Library/Android/sdk
    • Platform android-stable, build-tools 30.0.0-rc2
    • Java binary at: /Applications/Android Studio with Blaze.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.3.1, Build version 11C505
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio with Blaze.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Android Studio
    • Android Studio at /Applications/Android Studio 3.5 Preview.app/Contents
    • Flutter plugin version 33.4.2
    • Dart plugin version 183.5901
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] VS Code (version 1.48.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.0

[✓] Connected device (3 available)
    • iPhone 11 (mobile) • 5D77C64F-14CB-4C4B-B47D-62443C8678ED • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
    • Web Server (web)   • web-server                           • web-javascript • Flutter Tools
    • Chrome (web)       • chrome                               • web-javascript • Google Chrome 85.0.4183.102

! Doctor found issues in 1 category.

/cc @Piinks

What if we just have the binding throw a repaint boundary around the whole view?

That's a great idea for a workaround! Sending #70368

The problem here is that TestViewConfiguration does not override the setting of devicePixelRatio, so it gets set to 1.0 no matter what.

This is roughly what happened for reference:

https://github.com/flutter/flutter/pull/88609 is supposed to fix the issue and remove the workaround of adding a repaint boundary in flutter_test
Failure for the above pr detected b/197699775#comment3. I don't remember the complete details but cl/392929256 was suggested as the fix but it seemed like a deeper issue with the framework so it wasn't submitted
https://github.com/flutter/flutter/pull/88609 was reverted in https://github.com/flutter/flutter/pull/88889
Sometime later https://github.com/flutter/flutter/pull/101748 was submitted which contains https://github.com/flutter/flutter/pull/88609 partially, but does not include the removal of the repaint boundary workaround
https://github.com/flutter/flutter/pull/106913 was sent to remove the workaround.

This is causing an internal test documented in b/168776765 to have inconsistent screenshots.
Note that the failure in step (2) does not appear now.

The next step would be for a Googler to debug this test and figure out why it the screenshots are inconsistent without the repaint boundary.


Xss on inputs

Hi i found a bug, a xss persistent and non persistent

http://i.imgur.com/QkLlNZk.png
Best regards, vickom.
Sorry for my bad english

Sorry for the late response. The image seems to be 404. Can you upload again or describe the issue in more detail? Thanks!


Advanced setting for spatial statics

This is supposed to fix #242. I made a first test for Moran's I for the advanced setting. But I can't make the new setting values saved by the user.
After changing 1, can't save and execute 2.

This is supposed to fix #242. I made a first test for Moran's I for the advanced setting. But I can't make the new setting values saved by the user. After changing 1, can't save and execute 2.

This is supposed to fix #242. I made a first test for Moran's I for the advanced setting. But I can't make the new setting values saved by the user. After changing 1, can't save and execute 2.

I just created dragged a new node, and it works fine

List of nodes that are affected:

[ ] Global Morans' I
[ ] Global Gear's C
[ ] Global Getis-Ord G
[ ] Local Getis-Ord G
[ ] Local Moran's I

Maybe as well as the spatial modeling nodes,

[ ] 2SLS with Spatial Test
[ ] GWR Model
[ ] GWR Predictor
[ ] MGWR Model
[ ] OLS with Spatial Test
[ ] Spatial Error Model
[ ] Spatial Error Panel Model
[ ] Spatial Lag Model
[ ] Spatial Lag Panel Model


Move export and filter buttons to the right above the table

Background:
https://trello.com/c/jUyj4aiB/436-move-export-and-filter-buttons-to-the-right-above-the-table
Solution:

Enabled wrap on the flexbox so the filters can go on the next line on narrower screens

I think it's slightly confusing too that the filters/close filters buttons appear on the right, but the clear filters appears on the left

I think it's slightly confusing too that the filters/close filters buttons appear on the right, but the clear filters appears on the left

You are right. That's an issue I need to fix. It happens when clicking on another link. If you close the filters and open again, both buttons will be on the right hand side. Discovered it this morning

Now that my PR has merged, it's created a conflict here, srrrrrryyyyy 😬


[web] Implement "shared_preferences" plugin for web

At now I can't use 'shared_preferences' plugin for flutter_web
I think it's important feature

localStorage is already supported thanks to the dart:html package. Until plugins are supported by Flutter web and localStorage is set up as the web flavour of shared_preferences, you can directly work with it like so:
import 'dart:html';
...
Storage localStorage = window.localStorage

#35588

At now I can't use 'shared_preferences' plugin for flutter_web
I think it's important feature

Hi i want to store data to keep the user logged in my application, is this safe to use? And also how should i do this?

Flutter for web currently doesn't support importing 'dart:html' (https://github.com/flutter/flutter/issues/35588), so you have to use 'package:js' to interop with the local storage. I created a working gist that uses this approach: https://gist.github.com/timtraversy/d663ef1e37c2a8c49437c76be7062e85

shared_preferences dart package now supports local storage for the web from version <IP_ADDRESS>+
Similar to shared preference on Android and iOS, the following is the code snippet for local storage on web
https://stackoverflow.com/questions/56417667/how-to-save-to-web-local-storage-in-flutter-web

shared_preferences dart package now supports local storage for the web from version <IP_ADDRESS>+
Similar to shared preference on Android and iOS, the following is the code snippet for local storage on web
https://stackoverflow.com/questions/56417667/how-to-save-to-web-local-storage-in-flutter-web


[CHIPTool] getDiscoveredDevice returns null

Reproduction steps
I've to get all available matter devices so that I can commission devices using IP Addresses, But unfortunately, I'm not getting device data, all the time getDiscoveredDevice returns a null value.
I've implemented the functioning in a separate custom app and for the chip controller I've used the following .jar and .so files.
https://github.com/google-home/sample-apps-for-matter-android/tree/main/3p-ecosystem/third_party/connectedhomeip/libs
Because I'm not able to generate .jar and .so files here, and I think that may be an issue because the same functioning is working file in the chip tool sample app and even I'm getting node data using this command ./chip-tool discover commissionables
So maybe something is wrong with the .jar and .so files and I'm not able to generate the same files using Chiptool
How can I generate and locate .jar and .so files ?
Custom App Logs

Bug prevalence
Every time
GitHub hash of the SDK that was being used
8f66f42
Platform
android
Platform Version(s)
v<IP_ADDRESS>
Anything else?
How can I generate and locate .jar and .so files ?

@mukesh-simform .  I see that you have mentioned that you get output from the discover commissionables. However, im unable to.
Can you please check this defect please? I'm really struggling to get this work.
https://github.com/project-chip/connectedhomeip/issues/27964

@topraveenpaul I'm not sure about your issue but this is how I resolved to get discovered devices
I've generated .so and .jar files from the matter SDK repository and replaced legacy files with the newly generated ones and now I'm able to discover the devices and get IP Addresses.
But Before I try to discover commissionable I have to enable BLE advertisement from ESP32 and then only it finds the service
Prepare environment
source scripts/bootstrap.sh
Build directories
gn gen out/host
ninja -C out/host
Prepare some of the dependencies
TARGET_CPU=arm64 ./scripts/examples/android_app_ide.sh
Generate the jar and so files
./scripts/build/build_examples.py --target android-arm64-chip-tool build
--target android-arm64-chip-tool
--target android-arm-chip-tool
--target android-x86-chip-tool
--target android-x64-chip-tool

Thank you very much for your input. I'll strictly follow the suggested step to see if it works.

I've generated .so and .jar files from the matter SDK repository and replaced legacy files with the newly generated ones and now I'm able to discover the devices and get IP Addresses.

Sorry, i'm getting back on this after a while.
I followed your directions and generated shared objects and jar files however, it still didnt make any chance. Did not discover the devices.  Which specific version of SDK that you tried this on?
Every time I tried, i had ensured that the device was on BLE advertising mode and was detectable by hcitool.
Any other suggestion?


not all gitea options can be customized

Describe the bug
If you provide gitea options (services.gitea.extraConfig) which have the same INI section as one already provided by the package, gitea will start in the install wizard instead of booting properly.
To Reproduce
Steps to reproduce the behavior:

set services.gitea.extraConfig to
[server]
LANDING_PATH = explore

apply the configuration

gitea starts up and redirects to /install

Expected behavior
I expected to be able to change arbitrary config parameters using extraConfig. With this bug in place, I can't…

enable SSH
enable LFS
change the landing path
change security settings

Additional context
Add any other context about the problem here.
Metadata
Please run nix run nixpkgs.nix-info -c nix-info -m and paste the result.

system: "x86_64-linux"
host os: Linux 4.19.79, NixOS, 19.09pre-git (Loris)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3
channels(root): "nixos-19.09.789.7952807791d"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: services.gitea

🤔 after some more experimentation I'm not sure if this is a real bug or not. I'm going to close this until I'm more sure about the problem.


Support info for setImmediate is wrong

The feature table says setImmediate is supported natively everywhere:

MDN says it's not:

Ah, this is because setImmediate doesn't even have a feature detect.  Pushed a fix.


Toolbar shadow disappears sometimes

If you scroll very quickly and very far down, the shadow will disappear. Scrolling back up will make it appear again. Is this intended behaviour?

Ah, a subtle catch--looks like this is because the sort tab inherits its 4dp elevation from its parent CoordinatorLayout while the discovery toolbar (the navy blue) has no elevation since we would not want the top toolbar's shadow to render onto the sort tab bar.
If you've got a suggestion for how to render this shadow only when the tab layout is hidden we'd welcome a PR!


Buildkite implementation

This PR features the implementation of the Buildkite pipeline and updates the tests to run on the selected backends
To do

[ ] Encrypt the JR specific SECRET_CODECOV_TOKEN
[ ] Update testifies (e.g. runtests.jl etc)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!

You can check here if needed https://github.com/PTsolvers/Chmy.jl/tree/main/.buildkite
And this is how to generate the secret https://github.com/JuliaGPU/buildkite?tab=readme-ov-file#using-secrets . Note that running ./tools/encrypt on macOS does not work for some reason, so better do it on a linux machine.

CPU CI now fails as the init_particles() has been updated to the latest PR in JustPIC (#103. IF no new release is planned soon'ish, this can be reverted and addressed at a later stage


Upgrade Version of debug package

Hi, there!
IDK if it's the appropriate channel to discuss about that but the package debug in use of this app is on 2.6.9 version. And it has a problem of memory leak as discussed here.
This issue suggests upgrade this package to version 3.7.0 which this problem was already solved.
I  can also submit a Pull Request if it would help.

This has already been updated in the main branch and released with v5:
https://github.com/expressjs/express/blob/e4a61bd88e2f170eab64d937f3bf6c0812b4a649/package.json#L41
However, v4 is still pulling in the older version:
https://github.com/expressjs/express/blob/4.x/package.json#L42
It seems that v4 just needs a backport with this change to address the security concern. Here are the release notes from when that change was made before. I am sure a PR would be welcome - do you want to open one @rodrigoramos ? If not, I'm happy to.

It's worth noting that<EMAIL_ADDRESS>requires node >= 6. Express v4 set the bar really low on >= 0.10.0. Unfortunately it's not mentioned exactly what was incompatible.


Trying to understand PBUF_RING for Rust implementation

I'm looking to implement abstractions for pbufs in Rust: https://github.com/tokio-rs/tokio-uring/issues/112
I just want to confirm my understanding:

Registering the ring is about giving userspace and the kernel a shared ring to do atomic ops on the head/tail pointers (in the case of userspace, just the tail). It's basically a fancy list of allocations.
The registered memory only needs space to hold the ring.
struct io_uring_buf may contain arbitrary allocations created whenever and however the user likes. The only requirement is that ownership be relinquished to the kernel once added to the ring.
The ring memory will not be freed by the kernel. More generally, once the io_uring is destroyed, ownership of all memory involved with the ring returns to the user whose job it is to clean up.

* Registering the ring is about giving userspace and the kernel a shared ring to do atomic ops on the head/tail pointers (in the case of userspace, just the tail). It's basically a fancy list of allocations.

Right. That paired with IOSQE_BUFFER_SELECT/etc. to ask the kernel to alloc from it.

* The registered memory only needs space to hold the ring.

Not sure I follow. Are you asking how much memory the kernel allocates internally for pbuf and at runtime using it? That would be roughly equal to the size of the ring. And AFAIK everything needed is allocated at pbuf registration and nothing at runtime.

* `struct io_uring_buf` may contain arbitrary allocations created whenever and however the user likes. The only requirement is that ownership be relinquished to the kernel once added to the ring.

Yes, those are ordinary users pointer, same ones you would pass to read(2)/etc. The kernel doesn't care really about the ownership, but the userspace should otherwise you may get multiple parallel IO into the same buffer effectively corrupting the data.

* The ring memory will not be freed by the kernel. More generally, once the io_uring is destroyed, ownership of all memory involved with the ring returns to the user whose job it is to clean up.

If you mean memory for provided buffers, i.e. pointers you pass in the ring, then yes.

Awesome, thanks! Sounds like we're on the same page.

Not sure I follow. Are you asking how much memory the kernel allocates internally for pbuf and at runtime using it? That would be roughly equal to the size of the ring. And AFAIK everything needed is allocated at pbuf registration and nothing at runtime.

In this example https://github.com/axboe/liburing/blob/master/examples/io_uring-udp.c, you allocate the buffers and ring in the same mmap, but based on your reply that's just a convenient coincidence. Basically I meant that the memory given to the register syscall only needs space for the ring header and entries even though the user might choose to allocate extra space for adjacent buffers.

@SUPERCILEX this is correct.
the buffers that the ring points to can be anywhere

Awesome, thanks!

What's the rationale for the tail being a u16? On architectures like risc-v, 16-bit atomics aren't supported.


Error handling x middleware regression since 2.1.3

👋 In versions 2.1.3 and beyond, there is a regression in how errors interact with middleware...
In version 2.1.2 and prior, if an error occurred in a route and app.onError was invoked, middleware would still be processed for the error response. This would allow middleware such as the built-in logger and built-in cors to still process the error response, logging the response or injecting CORS headers.
In version 2.1.3 and since, if an error occurs and app.onError responds, middleware does not have a chance to process the response, so middleware such as logger cannot log the response, and cors cannot inject any CORS headers.
const { Hono } = require('hono');
const { logger } = require('hono/logger');
const { cors } = require('hono/cors');

const app = new Hono();
app.use('*', logger());
app.use('*', cors({ origin: '*' }));

app.get('/error', () => {
  throw new Error('Test error');
});

app.onError((err, ctx) => {
  return ctx.json({
    error: true,
    status: 500,
    message: err.message,
  });
});

const main = async () => {
  const res = await app.request('http://localhost/error');
  console.log([ ...res.headers.entries() ]);
};

main();

RunKit demo: hono@latest
RunKit demo<EMAIL_ADDRESS>This is pretty breaking for my project, as I would like to have error responses logged, and I'd like them to contain CORS headers like any other response.

You are right; we have changed the way of error handling. However, this is not a good approach, and I would like to revert back to it, with other changes.
Please wait!

Hi @MattIPv4 !
In this PR, we make it behaves the same as 2.1.2 and prior. The CORS and logger middleware will work even after the Handler throws an Error.
https://github.com/honojs/hono/pull/576
The new version, including this fix, will be released soon!

Awesome, thank you! I look forward to testing it once that release is cut 💙

Hi! new version has been released:
https://github.com/honojs/hono/releases/tag/v2.2.4

Hey! It looks like it's been fixed for synchronous routes :tada:, but the issue still remains for any route that is asynchronous 😢
2.1.2
2.2.4

Hi @MattIPv4 !
Sorry! Fixed it and release a new version, "v2.2.5". Please try it and if you still have problems, tell us again!


Constant "Success saved for player" messages in server log

Minecraft version & Mod Version:
Minecraft 1.12.2
Cyclic: 1.15.3
Single player or Server:
Server
Describe problem (what you were doing / what happened):
Watching console :p
Log snippet (cleaned up for privacy):
[16:30:22] [Server thread/ERROR] [cyclicmagic]: Successs saved for player _PlayerOne.invo [16:30:22] [Server thread/ERROR] [cyclicmagic]: Successs saved for player {uuidhere}.cyclicinvo [16:30:22] [Server thread/ERROR] [cyclicmagic]: Successs saved for player _PlayerTwo.invo [16:30:22] [Server thread/ERROR] [cyclicmagic]: Successs saved for player {uuidhere}.cyclicinvo [16:31:07] [Server thread/ERROR] [cyclicmagic]: Successs saved for player _PlayerOne.invo [16:31:07] [Server thread/ERROR] [cyclicmagic]: Successs saved for player {uuidhere}.cyclicinvo [16:31:07] [Server thread/ERROR] [cyclicmagic]: Successs saved for player _PlayerTwo.invo [16:31:07] [Server thread/ERROR] [cyclicmagic]: Successs saved for player {uuidhere}.cyclicinvo [16:31:52] [Server thread/ERROR] [cyclicmagic]: Successs saved for player _PlayerOne.invo [16:31:52] [Server thread/ERROR] [cyclicmagic]: Successs saved for player {uuidhere}.cyclicinvo [16:31:52] [Server thread/ERROR] [cyclicmagic]: Successs saved for player _PlayerTwo.invo [16:31:52] [Server thread/ERROR] [cyclicmagic]: Successs saved for player {uuidhere}.cyclicinvo [16:32:37] [Server thread/ERROR] [cyclicmagic]: Successs saved for player _PlayerOne.invo [16:32:37] [Server thread/ERROR] [cyclicmagic]: Successs saved for player {uuidhere}.cyclicinvo [16:32:37] [Server thread/ERROR] [cyclicmagic]: Successs saved for player _PlayerTwo.invo [16:32:37] [Server thread/ERROR] [cyclicmagic]: Successs saved for player {uuidhere}.cyclicinvo [16:33:22] [Server thread/ERROR] [cyclicmagic]: Successs saved for player _PlayerOne.invo [16:33:22] [Server thread/ERROR] [cyclicmagic]: Successs saved for player {uuidhere}.cyclicinvo [16:33:22] [Server thread/ERROR] [cyclicmagic]: Successs saved for player _PlayerTwo.invo [16:33:22] [Server thread/ERROR] [cyclicmagic]: Successs saved for player {uuidhere}.cyclicinvo

oops these were suppsed to be "log" type messages but i had them as error.  ((Errors are always shown, and log messages are hidden by default unless config turns them on))

https://minecraft.curseforge.com/projects/cyclic/files/2564086


 Double negatives are confusing.

I haven't had much occasion to mess with wrappers, so my brain usually just elides this code. This makes the code a little more approachable per #1251, so :+1:


Add fix to not run docker containers with root access

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (5eca9d2) 68.76% compared to head (ff8eb1d) 68.78%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##              int     #376      +/-   ##
==========================================
+ Coverage   68.76%   68.78%   +0.01%
==========================================
  Files          15       15
  Lines        1620     1621       +1
==========================================
+ Hits         1114     1115       +1
  Misses        388      388
  Partials      118      118

Impacted Files
Coverage Δ

dnsconfig.go
51.41% <100.00%> (+0.27%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Specify writer on command line

There should be a way to specify writers on the command line.

...juicy


Adding Contributors

Fontsource has grown larger than I have imagined it to ever be and to ensure the longevity and stability of the project, I’m requesting for additional maintainers to help work on this repository. Personally, I’d consider myself to be semi-active and the issues seem to be building up as I have less and less time. Additionally, it would also be nice to have someone peer-review my code and judgements since this is one of my first projects ever and I’m just a student soon to begin my first year of university.
As an overview of the project, everything is built using Typescript, including the core packager. The website is built with Next.js whilst the backend API (still in development #249) uses Fastify NestJS.
There’s actually a lot of undocumented work planned for the frontend website and thus it would be really great to get someone else actively involved with that! I’m no designer, so feel free to change up the UI too. The API, on the other hand, should be fairly low maintenance.
Getting a full code review on the main packager scripts and getting help resolving related issues would also be appreciated.
If you’re interested in helping out and possibly have experience with any of the above frameworks, feel free to drop a message with a way to contact you directly. I’ll be happy to give you a tour of the code and work things out.

Hello @DecliningLotus, I am interested in joining the Fontsource organization. I am already familiar with some of the code contained in this repository. As you know I have contributed several times already, and would like to further add to this repository in the future. I already have knowledge with some of the technologies used, (such as react, node, next, typescript) and am a fast learner for any others I am unfamiliar with. I have a lot of time available and can look in to issues when you may be busy. On that note, if you do decide to accept, I prefer not to give out my email where everyone can see it. What would be a good communication option is slack, which I have used with other teams before. This would be a good option for when the team grows (instead of sending a bunch of emails to different people). I am open to any other communication options you may come up with.

@jwr12135, I'd be happy to add you. I actually previously wanted to get in touch with you to figure things out from before, but the lack of ways to contact you made me give up.
And yes, I was planning on making a Slack. Feel free to send me a quick email at<EMAIL_ADDRESS>and I'll get back to you with more details (e.g. Slack workspace).

Hi @ayuhito, I'd be interested in contributing as well!
I found this package when I was looking at how to add self hosted fonts with NextJS, and it has made my life much easier, so I'd like to contribute and help it's growth! I'm also looking to scale my skills through code reviews and collaborations.
I have experience building enterprise grade systems with NestJS, React, TypeScript, NextJS.
Here's my:

Email ID<EMAIL_ADDRESS>LinkedIn: https://www.linkedin.com/in/snigdha-singh-166838184/

Looking forward to hearing from you!

@snigdha920, glad you're interested. I decided to move over to a Discord so more people can comfortably join without restrictions. Feel free to join us here!

Closing in favour of #550 as this issue has a lot of outdated information.


include URL of Replicate model

When you're looking at this code and all you see is a model version string, there's no way to know what that model actually is.
Hopefully someday we'll support version strings like stability-ai/stable-diffusion-inpainting:c28b92a7 for this API endpoint, but for now we can work around it by adding a code comment with the Replicate model URL

Good point, thanks!


Golden axe warrior - black screen

locally i have implemented sram support, though the game still sadly black screens...

found the issue (locally). i decided to try firing an vblank irq at line 192 instead, this fixed the game.
the latest an irq can be fired (for this game) is 239.


BUG: Check if keys have changed before creating proofs

If the mint has changed keys, but the wallet does not recognize it, it might create broken proofs.
Possible solution:

Calculate the current (wallet) mint keyset id from all keys according to NUT-02
compare with the id inside the received BlindedSignature
If they don't match, we have to load the new keys and perform the unblinding after that

can we close this?

#64 closes this


a suggested fix for directory support in Snakefile for GLS

This fix cannot be tested because I currently dont have access to a Google Cloud account, but Ill open it for review and discussion. This PR also depends on #665 - we won't be able to get to the remote upload step given that the path is not flagged as a directory.
Signed-off-by: vsoch<EMAIL_ADDRESS>

@johanneskoester if I add to the GLS test, it would only run if it's on a branch of this repository (it will skip on my account). Is this what you are suggesting to do?

Yes, that's fine, we'll just merge into a new branch in the main repo. You can work in the main repo directly in the future.
import os

# This test file is taken from Kubernetes - both use Google Cloud
from snakemake.remote.GS import RemoteProvider as GSRemoteProvider
GS = GSRemoteProvider()

rule all:
    input:
        "landsat-data.txt.bz2",
        "testdir"

rule copy:
    input:
        GS.remote("gcp-public-data-landsat/LC08/01/001/003/LC08_L1GT_001003_20170430_20170501_01_RT/LC08_L1GT_001003_20170430_20170501_01_RT_MTL.txt")
    output:
        "landsat-data.txt"
    resources:
        mem_mb=100
    run:
        # we could test volume size like this but it is currently unclear what f1-micro instances provide as boot disk size
        #stats = os.statvfs('.')
        #volume_gib = stats.f_bsize * stats.f_blocks / 1.074e9
        #assert volume_gib > 90
        shell("cp {input} {output}")

rule pack:
    input:
        "landsat-data.txt"
    output:
        "landsat-data.txt.bz2"
    conda:
        "env.yml"
    log:
        "logs/pack.log"
    shell:
        "bzip2 -c {input} > {output}; echo successful > {log}"

rule directory:
    output:
        directory("testdir")
    log:
        "logs/directory.log"
    shell:
        "mkdir -p {output}; touch {output}/test.txt"

Closing in favor of #691


Pull port calls to behaviors and their own modules.

The calls to the ports are prohibitive to testing. I suggest creating a behaviour and moving the calls to their modules. We can then use the behaviour with Mox for testing. Right now we can do some rudimentary testing by sending the same messages to the GenServers that the ports would send. Unfortunately, that would not be able to find bugs like #54 because we need to send data to the port. Using mocks gives fine-grained control over the responses, and lets us test on systems without actually needing a device that supports the protocols.

I need to think about this more, but I have a few comments:

I desperately want easier testing. Elixir 2.0 is in the works, so I'm thinking that if there are any API changes that we push it in the 2.0 branch to avoid noise for 1.x users.
There are two ways to look at testing: testing the guts of the library and helping people test their code that uses Elixir ALE.
For testing the guts of this library, I'd like to exercise as much C code as possible. My thought on doing this is to add a "loopback" mode for GPIO, I2C, and SPI. This mode could be entered via a special bus or GPIO. The C side would need a little extra work to handle it, but I think this would catch the main issues that I've seen with maintaining ElixirALE over the past few years. I don't see an easy way of using real hardware with automated tests.
For helping library users test their code, I think that Mox sounds like the right way. I haven't used Mox yet, but can we just provide a ElixirALE.SPI.API behaviour that the user can use for their mock? It seems like that would probably be the easiest for most people to use since it doesn't involve the port, and it seems reasonable for ElixirALE to provide the behaviour to encourage testing.

Thoughts?

I agree that API changes should happen in 2.0 and not in 1.x. I think that would make it difficult for users to keep up, and I don't think it is necessary.

I think that using real hardware limits contributions to the project, and makes CI a pain. I like the idea of exercising the C as much as we can. That is an important part of the whole and could hide some errors. The issue that I have is that I don't know how well we can test the high level issues like the message interleaving. If we have a loopback in the C how do we inject responses and the orders in which they come in. We wouldn't have been able to find the receive bug if the response just cam straight back. I think we are in a position where we need the ability to test through the C, but also a higher level interface that bypasses the C and allows us a little more control.

I think that providing behaviors for each of the interfaces is a great idea that will help others test their libraries. They can then use Mox or whatever they like to fake the interface with ElixirALE. It also allows other people to implement a compatible version of ElixrALE which could lead to more choices, and more PRs coming in.

I still believe that we would be good to mock the calls to and from the ports so that we have more control in the tests.

Closing since elixir_ale probably won't get any big updates going forward. Work is moving to https://github.com/elixir-circuits/.


IE 11 : Object doesn't support property or method 'assign'

Guidelines for posting a new issue

Please replicate your issue with this CodeSandBox and provide a link to it along with the issue description

React slick does not work with IE11, when you open the website https://react-slick.neostack.com/docs/example/multiple-items/ there is a popup with an error Object doesn't support property or method 'assign'

On CodeSandBox there is also an issue, the slider does not work too

The referenced commit should fix the mentioned problem.
Changes will be released soon.

I still see that error.
In effect, the slider doesn't work.


[Bug]: Failed to initialize MelonLoader: Failed to get function pointer: il2cpp_init

All of the following criteria must be met

[X] All Requirements must be installed.
[X] Changed the title so that it doesn't just says "[Bug]: "
[X] I have searched the GitHub issues for my bug, even in the closed issues.

All of the following are optional to answer

[ ] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[X] Tried restarting PC.
[X] Was able to see the Start Screen.

Describe the issue.
i got this error when installing on my game :
Failed to initialize MelonLoader: Failed to get function pointer: il2cpp_init
what does this mean and how to fix ? thanks
Latest-Bootstrap.log
Did you attach your log file?
Select an option below

We can't provide support when you didn't give enough information.
What game? What version of MelonLoader are you trying to use?
Additionally you filled out the form incorrectly.


Respect bash-coding conventions by providing non-zero exit code when error is happening

Otherwise it is impossible to use now cli in CI systems. Here the build marked as succeeded even when now command has failed:

Surprised that an issue this significant has sat untouched for so long. This affects any scripting with now, not just CI (though CI is my current pain point as well).