Text not recomposing after toggling dark mode on Compose 1.4.0 and JDK 11

Describe the bug
On Compose 1.4.0 with JDK 11, when changing the colors (toggling dark mode), the Text Component is not recomposing with the updated Colors. This was working as expected on Compose 1.3.0 and JDK 11. Please check the attached video for more information.
JDK 17 and Compose 1.4.0 work as expected. This is only happening on JDK 11.
Affected platforms
Select one of the platforms below:

Desktop - Tested only on Desktop, but might also be on others.

Versions

Kotlin version*: 1.8.0
Compose Multiplatform version*: 1.4.0
OS version(s)* (required for Desktop and iOS issues): MacOS 13.1
OS architecture (x86 or arm64): arm64
JDK (for desktop issues): 11

To Reproduce
Steps and/or the code snippet to reproduce the behavior:

Change MaterialTheme colors at runtime to dark/light
Observe Text Component

Expected behavior
Text Should recompose with the updated color.
Screenshots
https://github.com/JetBrains/compose-multiplatform/assets/6180066/658b901f-b0f6-4499-987f-ab850508739f

We've been stuck on Compose 1.3.1 because of that issue. And I've been trying to resolve it this whole day. After creating two reproducers (the first one failed) I came to a conclusion that it happens only when using child animation with Decompose library. Basically, this code works as expected:
Children(navRoot.childStack) { it.instance() }

While this one causes colors to break:
Children(navRoot.childStack, animation = stackAnimation(fade())) {
    it.instance()
}

@arkivanov

@andreykavo, the issue with Decompose animations might be different from the original reported here, it's already known.
See: https://github.com/arkivanov/Decompose/issues/330
The actual cause: https://issuetracker.google.com/issues/270656235
Please update Decompose to at least 2.0.0, and your case with stackAnimation(...) should be working. However, stackAnimation {...} will be still broken, and will be fixed on Compose side, perhaps in v1.5.0 (not quite sure).

@anikrajc Can you please check your project with Kotlin 1.9.0 and Compose 1.5.0-beta01 ?

@dima-avdeev-jb That fixes the issue. Thanks.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Set success if the model value is not null

Set class 'validationSucess' if the model has no errors and its initial value is not null

I think it's same as #257. But if model value is not null it doesn't mean that it's touched. For example if you load an existing record the name field won't be null, but doesn't mean it's touched.

You're right, it's same as #257 but very basic, this feature try to verify when :isNewModel="true" don't set class success to the field to keep neutral state, but if the model is filled, apply the validations and set class success or error to the field.


Pull Closure Compiler from a known-green snapshot.

Tests should pull from a known-green snapshot rather than building the latest version.
RELNOTES: n/a

Not sure if Travis will run the new script - presumably it will: https://travis-ci.org/google/closure-library/builds/242668533?utm_source=github_status&utm_medium=notification

lgtm


Use new script code

Use new script code which does not use JS evaluation.
Fixes #1564

Could you please rebase against the dev branch and update the PR? We'll pull it in after that. :)

Could you please rebase against the dev branch and update the PR? We'll pull it in after that. :)


Added the Contributing Guidelines

@thestarsahil I have added the contributing guidelines file as CONTRIBUTING.md.
Please review it.

Great job, @shanvijha30! Thank you for your excellent work and dedication.
Your contributions have been valuable and greatly appreciated. Keep up the fantastic work! If you have any further questions or need any assistance, feel free to reach out.


Realtime detection

Has anyone been successful in using this technology for near real-time detection?

@johngao2 / others on the team, any prelim ideas if this would be possible?

Unfortunately the answer seems to be no at the moment. @DamRsn wrote a great summary of it here.

Thanks for the info!
Awesome project btw, +1 for Spotify! :-)


fix(NODE-3668): compile error with OptionalId on TS 4.5 beta

Typescript 4.5  is better at checking certain complicated types than before. Previously, it missed an error in mongo_types.ts in the use of SetFields and OptionalId.
SetFields passes an unconstrained type parameter, TSchema, to OptionalId, which does have a constraint:
export type OptionalId<TSchema extends { _id?: any }> = ...

Because the type was so complex, Typescript missed this before 4.5.
Looking at the comments for OptionalId, I believe the intent is to add _id to any type, not just ones that already have an _id field. So I moved the constraint into a conditional type instead.
Fixes https://jira.mongodb.org/browse/NODE-3668?jql=project %3D NODE AND resolution %3D Unresolved AND text ~ "typescript" ORDER BY priority DESC%2C updated DESC
Description
What changed?
Types in mongo_types.ts

I have a playground link here, while this may fix the crash upon import for SetFields it has broken the use case number 3. I'm trying to come up with a fix but if you see something here let me know. 🙂

I pushed a PR that makes _id optional for case (3).

I was able to test locally with tsd using TS 4.4 and 4.5 and it passes 🚀
Thanks! I agree with you that it did work by mistake before, so I appreciate the improvement. I'll turn this over to the team for a look and we'll get this in soon.
Also thanks @PaulEndri for takin a look as well!


vscode-styled-jsx-languageserver error when use next 9

hi i start working with styled-jsx
for setup autocompelet css in vscode other people suggest me to use vscode-styled-jsx-languageserver. but it dosent work and last update for one year ago.
how i can use css-in-js autocomplet in vscode with style-jsx

does this happen only when you use :global?

i dont sure... i deactive this extension

I was getting the same thing but while using the identifier :root. For some reason disabling the extension then re-enabling it got rid of it, but then a lot of errors are still being posted:
Request textDocument/codeAction failed.
  Message: Request textDocument/codeAction failed with message: Debug Failure. Did not expect SourceFile to have an Identifier in its trivia
  Code: -32603

I think it's problem with new version of VSCode instead of Next9


Warning on Boot

If you integrate put-it-to-rest into a typical spring-boot application the following warning is emitted on boot.
ConfigurationClassPostProcessor  : Cannot enhance @Configuration bean definition 'restClientPostProcessor' since its singleton instance has been created too early. The typical cause is a non-static @Bean method with a BeanDefinitionRegistryPostProcessor return type: Consider declaring such methods as 'static'.

Minimal example is adding put-it-to-rest as a dependency to https://github.com/spring-guides/gs-spring-boot.git.

I've seen this before. Any idea how to solve it? Declaring it static didn't work for me last time I tried.

No - it seems like you did everything the warning suggested one to do. Do you know what "enhance" means?

iirc it's adding support for this feature where you can directly call other bean methods and Spring ensures that you will get back the same singleton as that bean would produce anyway.


jaguar_robot: 0.1.0-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository jaguar_robot to 0.1.0-0:

upstream repository: https://github.com/gstavrinos/jaguar_robot
release repository: https://github.com/gstavrinos/jaguar_robot-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.5.23
previous version for package: null

jaguar_base
* Functional Indoors Navigation
* Motor controller drivers are stable
* Contributors: George Stavrinos

jaguar_bringup
* Added laser bringup launch file
* Added myahrs bringup launch file (external imu)
* Contributors: George Stavrinos

jaguar_robot
* Metapackage for the physical robot (not simulated)
* Contributors: George Stavrinos

This needs a rebase to be able to merge. This inserts in the same location as #13311 and thus merge conflicts. If you rebase and force push to this branch we can then merge this PR.

I am closing this one, since I opened a new pull request. Thanks.


feat: change message hash digest size from 128-bit to 160-bit

What is the feature you would like to implement?
Message hashes should be increase to 160-bit from 128-bit. This includes the hash property on the message but also derived properties like tsHash fields in CastRemove and the hashes used in the sync tree. We should also label the enumeration for the has type to include the digest size in the name, in case we launch a blake3 variant with larger hashes in the future.
Why is this feature important?
Shorter 128-bit Blake3 hashes can be broken in a year by a determined attacker with a 5-10M budget, while 160-bit hashes would still take a thousand years and require a budget 50x larger.  The math is outlined here: https://hackmd.io/@farcasterxyz/rkxmwFrBo#Modelling-the-Attack-Vector
Will the protocol spec need to be updated??
Yes

Implemented here: https://github.com/farcasterxyz/hub/pull/441


Implement optimization strategies for functions of orthogonal matrices

Implement generic versions of some of the algorithms described here: https://arxiv.org/abs/physics/9806030 .

I have used this stuff for a side-project recently via pymanopt. If there's a (business) case for implementing this functionality in MAGICL but you're currently too busy, then I'd love to take care of it.

Definitely! The business case is the one described in VII.A here: https://arxiv.org/pdf/1904.10541.pdf . The "searching" compiler templates in src/compilers/approx.lisp currently use a high-dimensional Nelder-Mead instance to optimize a function over the space of single qubit operators, which is simultaneously slow and unreliable. After conjugation by the "magic operator" (i.e., +e-basis+), it's equivalent to optimize the (smooth) function over the space of orthogonal operators, which I'd hope would be much speedier.
I tried implementing this some months ago (wow! really, in February?) and got myself into trouble with poor numerics. I'd be very glad to have it implemented by someone else.


Add Code of Conduct file

What's wrong with the existing documentation :
We recommend that every repo has a code of conduct. If you don’t feel comfortable creating your own Code of Conduct from scratch we highly recommend using one of the templates provided by GitHub. If you do use a template, please read through the template and ensure that you can and will abide by the Code of Conduct.
Please follow these instructions on how to add a Code of Conduct.
Sample: https://github.com/Recode-Hive/Stackoverflow-Analysis/blob/main/CODE_OF_CONDUCT.md
Hey @open-xyz , Kindly assign this issue to me under GSSoC'24

@aasthakourav20 this issue is already opened at #6

I would like to work on this issue. Could you please assign it to me.

I would like to work on this issue. Could you please assign it to me.

at least read the comments


[🐛 BUG] Data node's editor id mechanism does not work

What went wrong? 🤔
When using a data node control, the lock/unlock/write mechanism works fine. But we cannot always use a datanode control.
When locking a data node providing an "editor_id", this is only prevent another editor to lock the data node. It does not prevent the other editor to write the data node.
According to the documentation it should prevent another editor to write (append, upload) the data node.
Expected Behavior
When a data node is locked by an editor, no other editor should be able to write it. Same for append and _upload.
Question: When the data node is written without any editor_id (that's what the Orchestrator does), should this be accepted even if an editor has locked it?
Steps to Reproduce Issue
from taipy import Config, Scope, create_scenario
from taipy.core.exceptions import DataNodeIsBeingEdited

d1 = Config.configure_data_node("d1", scope=Scope.GLOBAL, default_data=1)
s1 = Config.configure_scenario("s1", additional_data_node_configs=[d1])
scenario_1 = create_scenario(s1)
dn1 = scenario_1.d1

print("lock dn1")
dn1.lock_edit()
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("unlock dn1")
dn1.unlock_edit()
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}\n")

print("lock dn1")
dn1.lock_edit()
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("write 2 in dn1")
dn1.write(2)
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")

print("lock dn1 by editor_id")
dn1.lock_edit("editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("unlock dn1 by editor_id")
dn1.unlock_edit("editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}\n")

print("lock dn1 by editor_id")
dn1.lock_edit("editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("lock dn1 by other")
try:
    dn1.lock_edit("other")
except DataNodeIsBeingEdited as e:
    print(e.message)
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("unlock dn1 by editor_id")
dn1.unlock_edit("editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}\n")

print("lock dn1 by editor_id")
dn1.lock_edit("editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("write 3 in dn1")
try:
    dn1.write(3)
    print("SHOULD THIS RAISE AN EXCEPTION? I AM NOT SURE. IT DIDN'T.")
except DataNodeIsBeingEdited as e:
    print(e.message)
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("unlock dn1 by editor_id")
dn1.unlock_edit("editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}\n")

print("lock dn1")
dn1.lock_edit()
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("write 4 in dn1 by editor_id")
try:
    dn1.write(4, editor_id="editor_id")
    print("SHOULD HAVE RAISED AN EXCEPTION! IT DIDN'T.")
except DataNodeIsBeingEdited as e:
    print(e.message)
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("unlock dn1")
dn1.unlock_edit()
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}\n")

print("lock dn1 by editor_id")
dn1.lock_edit("editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("write 5 in dn1 by other")
try:
    dn1.write(5, editor_id="other")
    print("SHOULD HAVE RAISED AN EXCEPTION! IT DIDN'T.")
except DataNodeIsBeingEdited as e:
    print(e.message)
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("unlock dn1 by editor_id")
dn1.unlock_edit("editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}\n")

print("lock dn1 by editor_id")
dn1.lock_edit("editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("write 6 in dn1 by editor_id")
dn1.write(6, editor_id="editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}")
print("unlock dn1 by editor_id")
dn1.unlock_edit("editor_id")
print(f"d1 {'' if dn1.edit_in_progress else 'NOT '}locked{' by '+dn1.editor_id if dn1.editor_id else ''}. Value is {dn1.read()}\n")

Solution Proposed
The editor_id should be an optional parameter of the write method, just like the lock and unlock methods.

def write(self, data, job_id: Optional[JobId] = None, editor_id: Optional[str] = None, **kwargs: Dict[str, Any]):
        from ._data_manager_factory import _DataManagerFactory
        if editor_id:
            if not self.editor_id:
                raise DataNodeIsBeingEdited(self.id, self._editor_id)
            if (
                self.edit_in_progress
                and self.editor_id != editor_id
                and self.editor_expiration_date
                and self.editor_expiration_date > datetime.now()
            ):
                raise DataNodeIsBeingEdited(self.id, self._editor_id)
        self._write(data)
        self.track_edit(job_id=job_id, editor_id = editor_id, **kwargs)
        self.unlock_edit(editor_id)
        _DataManagerFactory._build_manager()._set(self)

Similar code or factorized for append and upload.
Acceptance Criteria

[ ] Ensure new code is unit tested, and check code coverage is at least 90%.
[ ] Create related issue in taipy-doc for documentation and Release Notes.

Code of Conduct

[X] I have checked the existing issues.
[ ] I am willing to work on this issue (optional)

Hi, can I work on this?

Please assign me this issue

and i can assist you with it also include me

and i can assist you with it also include me

Full test coverage is expected for this issue, as it may have an impact on the core of the Taipy orchestration system.

@bobbyshermi @jrobinAV    i have done some testing on the given code  and i have both result and issue which i am giving below
result of the Tests
Basic Lock/Unlock:  This verifies that you can lock and unlock a data node without issues.
Write Operation:    Tests writing to the node when locked by the same editor ID and ensures the state is correct after the write.
Error Handling:       Ensures that attempts to lock the node by a different editor ID correctly raise exceptions.
Re-locking:             Tests the ability to lock the node again after unlocking and check the state.
Edge Cases:            Checks that trying to unlock when not locked or writing when locked raises the correct exceptions.
** Issues with code **
Multiple Lock Attempts: The code tries to lock the same data node multiple times without unlocking it in between, which could lead to confusion in the output.
Error Handling: The way exceptions are handled is somewhat inconsistent. For example, there are sections where the code is expected to raise exceptions but continues executing without a clear structure.
Assertions and State Checks: Instead of just printing messages, adding assertions would help confirm expected states after operations, making it easier to identify where things might go wrong.
Redundant Code: There are repeated blocks of code, which can be encapsulated in functions for better readability and maintenance.
if this is approved and  proper for the issue than please allow and guide me to do what ever is require to correct and move further step to do or any changes required .

Hi @AdibaNaushad,
Thank you for your help.
I am not sure which tests you are referring to in your message.
If you are talking about the piece of code that is under the "Step To Reproduce" section, this is not a test to run. It is just a piece of code using taipy that exhibits the bug so you can reproduce it. It is not meant to be added to the taipy repository as a unit test nor at actual production code.
The whole purpose of the issue is to:

Change the DataNode.write function (append and upload) to fix the bug. You can get some inspiration from the code that @bobbyshermi provided under the section "Solution Proposed".
Write new unit tests to prove the code works fine in all the use cases we want to cover and to detect regressions.

i have debug the code given above . i will do unit testing soon . if everything is correct or moving in right direction please allow me to move further.  any guidance i  need please tell me i am trying to do best for project  .
the Debugging Strategy i use is :
Print Debugging: We will use additional print statements to track the status of lock_edit, editor_id, and edit_in_progress in each case to ensure that the methods are working as intended.
Validate Behavior with Correct Editor: Check if the locking mechanism works correctly when the same editor_id is used for writing.
Test Different editor_ids: Confirm that trying to write with a different editor_id raises the appropriate exceptions.
Debugging Changes:
print_status Function: This helper function prints the lock status, the current editor (if any), and the current value of the DataNode. This helps in tracking what’s happening after each operation.
Tracking Exceptions: The print statements and exception handling have been made more explicit, especially when checking if an exception is expected but not raised (e.g., when a different editor attempts to lock or write).
Detailed Output for Locking/Unlocking: The output now shows exactly when the DataNode is locked, unlocked, written to, or when an exception is raised.
from taipy import Config, Scope, create_scenario
from taipy.core.exceptions import DataNodeIsBeingEdited

# Configure the DataNode and Scenario
d1 = Config.configure_data_node("d1", scope=Scope.GLOBAL, default_data=1)
s1 = Config.configure_scenario("s1", additional_data_node_configs=[d1])
scenario_1 = create_scenario(s1)
dn1 = scenario_1.d1

# Helper function to print the status of the DataNode
def print_status(dn, label):
    print(f"{label} - Locked: {'Yes' if dn.edit_in_progress else 'No'}, Editor: {dn.editor_id if dn.editor_id else 'None'}, Value: {dn.read()}")

# Lock dn1 without editor_id
print("Locking dn1")
dn1.lock_edit()
print_status(dn1, "After locking dn1")
print("Unlocking dn1")
dn1.unlock_edit()
print_status(dn1, "After unlocking dn1\n")

# Lock dn1 without editor_id and write
print("Locking dn1 again")
dn1.lock_edit()
print_status(dn1, "After locking dn1")
print("Writing 2 to dn1")
dn1.write(2)
print_status(dn1, "After writing 2 to dn1")
print("Unlocking dn1")
dn1.unlock_edit()
print_status(dn1, "After unlocking dn1\n")

# Lock dn1 with editor_id "editor_id"
print("Locking dn1 with editor_id")
dn1.lock_edit("editor_id")
print_status(dn1, "After locking dn1 with editor_id")

# Unlock with the same editor_id
print("Unlocking dn1 with editor_id")
dn1.unlock_edit("editor_id")
print_status(dn1, "After unlocking dn1 with editor_id\n")

# Lock dn1 with editor_id and attempt lock with different editor
print("Locking dn1 with editor_id")
dn1.lock_edit("editor_id")
print_status(dn1, "After locking dn1 with editor_id")

print("Attempting to lock dn1 with another editor 'other'")
try:
    dn1.lock_edit("other")
except DataNodeIsBeingEdited as e:
    print(f"Exception caught: {e.message}")
print_status(dn1, "After attempting to lock with 'other'")
print("Unlocking dn1 with editor_id")
dn1.unlock_edit("editor_id")
print_status(dn1, "After unlocking dn1 with editor_id\n")

# Lock dn1 with editor_id and attempt to write without proper editor_id
print("Locking dn1 with editor_id")
dn1.lock_edit("editor_id")
print_status(dn1, "After locking dn1 with editor_id")

print("Attempting to write 3 to dn1 without editor_id")
try:
    dn1.write(3)
    print("Should this raise an exception? It didn't.")
except DataNodeIsBeingEdited as e:
    print(f"Exception caught: {e.message}")
print_status(dn1, "After attempting to write without editor_id")
print("Unlocking dn1 with editor_id")
dn1.unlock_edit("editor_id")
print_status(dn1, "After unlocking dn1 with editor_id\n")

# Lock dn1 and attempt to write with mismatched editor_id
print("Locking dn1 again")
dn1.lock_edit()
print_status(dn1, "After locking dn1")
print("Attempting to write 4 to dn1 with mismatched editor_id 'editor_id'")
try:
    dn1.write(4, editor_id="editor_id")
    print("Should have raised an exception! It didn't.")
except DataNodeIsBeingEdited as e:
    print(f"Exception caught: {e.message}")
print_status(dn1, "After attempting to write with mismatched editor_id")
print("Unlocking dn1")
dn1.unlock_edit()
print_status(dn1, "After unlocking dn1\n")

# Lock dn1 with editor_id and write with another editor
print("Locking dn1 with editor_id")
dn1.lock_edit("editor_id")
print_status(dn1, "After locking dn1 with editor_id")
print("Attempting to write 5 to dn1 with another editor_id 'other'")
try:
    dn1.write(5, editor_id="other")
    print("Should have raised an exception! It didn't.")
except DataNodeIsBeingEdited as e:
    print(f"Exception caught: {e.message}")
print_status(dn1, "After attempting to write with 'other'")
print("Unlocking dn1 with editor_id")
dn1.unlock_edit("editor_id")
print_status(dn1, "After unlocking dn1 with editor_id\n")

# Lock dn1 with editor_id and successfully write
print("Locking dn1 with editor_id")
dn1.lock_edit("editor_id")
print_status(dn1, "After locking dn1 with editor_id")
print("Writing 6 to dn1 with editor_id")
dn1.write(6, editor_id="editor_id")
print_status(dn1, "After writing 6 to dn1")
print("Unlocking dn1 with editor_id")
dn1.unlock_edit("editor_id")
print_status(dn1, "After unlocking dn1 with editor_id\n")

@AdibaNaushad
I don't understand what you are proposing here. The code you are editing is just some code that prints messages to exhibit the issue. It is not part of the taipy code base, and we don't want to add it.
You can use it to understand the bug or to inspire you to write good unit tests, but there is no need to edit it.
Let me rephrase what we need:

We must change the Datanode.write() method.
We must change the Datanode.append() method.
We need to change the _FileDataNodeMixin._upload() method
Update and write new unit tests in tests/core/data/test_data_node.py and tests/core/data/test_file_data_node.py (to be created) to get a full code coverage on the modified methods.

@jrobinAV if i have done changes than should i comment to  here approved  or directly create a pull request to merge that you can review ??

@AdibaNaushad No problem. Asking questions is part of the contributor's job.
Please create a pull request directly so we can comment and discuss around the code directly.
Thank you,

Looks niche , I'm taking on this issue and might as well spend my weekends on it 😃 .

@bobbyshermi Can I work on this issue ?

I have assigned it to you @Ankur2606 and @PrakharJain1509; thank you for your contribution!

@FlorianJacta @bobbyshermi  I have created a PR for the same. Please have a review and let me know if any changes are required.

I removed the "waiting for contributor" label as a PR is currently submitted and in review.


ign_ros2_control: 0.5.0-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository ign_ros2_control to 0.5.0-1:

upstream repository: https://github.com/ros-controls/gz_ros2_control
release repository: https://github.com/ros2-gbp/ign_ros2_control-release.git
distro file: rolling/distribution.yaml
bloom version: 0.10.7
previous version for package: null

ign_ros2_control
* Fix setting initial values if command interfaces are not defined. (#73 <https://github.com/ros-controls/gz_ros2_control/issues/73>)
* activated all hardware by default and improved variable naming (#74 <https://github.com/ros-controls/gz_ros2_control/issues/74>)
* Implemented perform_command_mode_switch override in GazeboSystem (#76 <https://github.com/ros-controls/gz_ros2_control/issues/76>)
* Remove warnings (#72 <https://github.com/ros-controls/gz_ros2_control/issues/72>)
* change component name for ignition (#69 <https://github.com/ros-controls/gz_ros2_control/issues/69>)
* Added logic for activating hardware interfaces (#68 <https://github.com/ros-controls/gz_ros2_control/issues/68>)
* Merge branch 'foxy' into ahcorde/foxy_to_galactic_27_05_2022
* Remove URDF dependency (#56 <https://github.com/ros-controls/gz_ros2_control/issues/56>)
* Adapt to ROS 2 Humble
* typo in citadel name (#54 <https://github.com/ros-controls/gz_ros2_control/issues/54>)
* typo in citadel name (#51 <https://github.com/ros-controls/gz_ros2_control/issues/51>)
* ros2_control is now having usings under its namespace. (#43 <https://github.com/ros-controls/gz_ros2_control/issues/43>)
* Fix default ign gazebo version Rolling (#45 <https://github.com/ros-controls/gz_ros2_control/issues/45>)
* Fix ignition version in package.xml - Rolling (#41 <https://github.com/ros-controls/gz_ros2_control/issues/41>)
* Fixed position control (#29 <https://github.com/ros-controls/gz_ros2_control/issues/29>)
* Add support for initial_values for hardware interfaces when starting simulation. (#27 <https://github.com/ros-controls/gz_ros2_control/issues/27>)
* Contributors: Alejandro Hernández Cordero, Denis Štogl, Guillaume Beuzeboc, Tianyu Li

ign_ros2_control_demos
* Fix setting initial values if command interfaces are not defined. (#73 <https://github.com/ros-controls/gz_ros2_control/issues/73>)
* fix demo launch (#75 <https://github.com/ros-controls/gz_ros2_control/issues/75>)
* Adjust URLs (#65 <https://github.com/ros-controls/gz_ros2_control/issues/65>)
* ign_ros2_control_demos: Install urdf dir (#61 <https://github.com/ros-controls/gz_ros2_control/issues/61>)
* Remove URDF dependency (#56 <https://github.com/ros-controls/gz_ros2_control/issues/56>)
* Use Ubuntu Jammy in CI (#47 <https://github.com/ros-controls/gz_ros2_control/issues/47>)
* Add support for initial_values for hardware interfaces when starting simulation. (#27 <https://github.com/ros-controls/gz_ros2_control/issues/27>)
* Contributors: Alejandro Hernández Cordero, Andrej Orsula, Bence Magyar, Denis Štogl, Maciej Bednarczyk, ahcorde

There were some complications with this release. RHEL and Jessie are not happy with the required Ignition version. Are you still ok with this going ahead as-is or should we try to lower that to something accepted by both of those?


Fix/polish

Adjusts modules to fix standard
Moves combat module structs into struct file
Minor rearranging of imports
Removes useless ERC721 code and unifies it with OZs

just going to merge - it's all just imports really. And all contracts compile.


Update Needle to 2.5.0 or greater.

Versions of needle prior to 2.5.0 cannot cope with redirects (as documented).
This prevents prebuilt canvas binaries from being downloaded on MacOS,
requiring the global install of its dependencies.
Updating needle restores it to functionality, addressing this.  This change avoids
the need to add request to package.json or bundle pre-built binaries,  it also obsoletes https://github.com/mozilla/pdf.js/pull/12018.
(NB: needle was already in use for this package.)

/botio-linux preview

Let's do this. Thank you!


Add Gitter chat links

Coverage remained the same at 100.0% when pulling 6424aa2977de2e12d0ffd7c61f1f7c0066391d17 on gitter-chat into d8efb782dd8604f487921ea10b319ebf75649a3b on master.


⚠ SpeakUpConference.com has degraded performance

In f63696a, SpeakUpConference.com (https://www.speakupconference.com) experienced degraded performance:

HTTP code: 200
Response time: 12903 ms

Resolved: SpeakUpConference.com performance has improved in 8a55196 after 19 minutes.


QOpenForRead returning closed objects?

Thank you for this repo, it is awesome! However, I am experiencing stability issues when batch processing a large amount of blocks. I am suspecting that QOpenForRead can have part in this since they return a closed object:
   public static DBObject QOpenForRead(this ObjectId dboId, Database db)
    {
        using (Transaction trans = db.TransactionManager.StartOpenCloseTransaction())
        {
            return trans.GetObject(dboId, OpenMode.ForRead);
        }
    }

The using statement will call to close the object before returning it, and it is no longer guaranteed that the object can be used. See this post on the Autodesk forum.

Thank you for raising this concern. The using statement should only be able to close the Transaction object, meaning the transaction is done and the DBObject object is populated and ready to use. Since this is open for read, read operations should be fine with the returned object. Just make sure do not try to set any properties. I have been using this method intensively in my own project and not a single issue has come to my sight.

According to Autodesk, the objects that were opened using Transaction.GetObject will be closed when disposing of the transaction:

Once you have a Transaction or OpenCloseTransaction object, use the GetObject method to open an object stored in the database for read or write. The GetObject method returns a DBObject which can be cast to the actual object type it represents.
All open objects opened during a transaction are closed at the end of the transaction.

I agree it works anyway, and I haven't had any problems until I start processing a large amount of dynamic blocks. It is possible that my problems derive from something else, but I just want to make sure this is not the issue.

My guess is this description in the documentation was inherited from the C++ ObjectARX. In ObjectARX, objects opened with transactions share same memory address with the AutoCAD kernal. This is obviously not the case in managed .NET application, where opened objects are just copy. Nonetheless, I am happy to help solve any problems you may have.

You can easily verify whether this is the issue by putting your read operation inside a transaction and see if the issue is gone.

I tried using an overload for QOpenForRead that works as QOpenForWrite, but the mysterious error messages did not go away. So I am convinced my problems come from another source and this issue can be closed. But since you are offering help, would you mind take a look at my code if I put together a simplified VS solution? Perhaps via email (or channel of your choice), since its not relevant here anymore.

You can send it to<EMAIL_ADDRESS>Also please share the AutoCAD version, and any test .dwg you are using.

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
smileLiang, @cheng-peng, @PKHarsimran, @bbenetskyy, @stt04521, @github410117, @TrueGeek, @xiaoboa, @phcheng, @julianosilva94, @jel111, @jumpingPeng, @JD-CP, @lchen1991, @YongshengLuan, @chaiyining007, @larkinwc, @inmyfree, @parachvte, @sword1987cao


Replace underscore with lodash

Replace underscore with lodash (https://lodash.com)
Associated JIRA Ticket:  https://jira.appcelerator.org/browse/ALOY-1168
(Ticket was created in Oct 2014 and looks like it is dead...)

Replaced underscore in this branch:  https://github.com/mobilehero/adamantium/tree/feature/underscore-to-lodash
Still having issue trying to get all the tests to pass:  https://travis-ci.org/mobilehero/adamantium/builds/116992328
Seems to be leaving artifacts in folders and causing the tests to error out.  Not sure why yet...


Delay in Deploying the changes to a release

Describe the bug
Any change in the git takes considerable amount of time before it gets deployed to the kubernetes cluster.
We use Helm Releases and Flux Helm Operator and tiller per namespace managing close to 30 releases in that namespace.
To Reproduce
Steps to reproduce the behaviour:
0. What's your setup?

Go to 'GIT, make a change in the release'
Click on 'commit'
Go to Cluster to check the change effected, it takes close to 10 minutes or more.
Watching Flux Helm Operator logs only shows it has enqueued the release.
(Git hook integrated and the deploy history shows up in Weave cloud deploy dashboard almost instantly.)

last change in the git around 11:40 and enqueues it for long.
ts=2019-06-24T11:24:08.257170226Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:27:08.268668148Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:30:08.2684498Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:32:05.473357241Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:33:08.265067408Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:34:28.323348154Z caller=release.go:167 component=release info="processing release word-bank-e2e (as 3916b68d-934f-11e9-a170-0a706674d924)" action=CREATE options="{DryRun:true ReuseName:false}" timeout=300s
ts=2019-06-24T11:34:36.416887706Z caller=chartsync.go:557 component=chartsync error="release word-bank-e2e: values have diverged due to manual chart release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:34:36.421265111Z caller=release.go:167 component=release info="processing release word-bank-e2e (as word-bank-e2e)" action=UPDATE options="{DryRun:false ReuseName:false}" timeout=300s
ts=2019-06-24T11:36:08.269013882Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:39:08.26158978Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:40:03.964889845Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:42:08.267962791Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:45:08.265058759Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:48:08.264835518Z caller=operator.go:296 component=operator info="enqueuing release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:48:52.010657821Z caller=release.go:167 component=release info="processing release word-bank-e2e (as 3916b68d-934f-11e9-a170-0a706674d924)" action=CREATE options="{DryRun:true ReuseName:false}" timeout=300s
ts=2019-06-24T11:49:00.389017663Z caller=chartsync.go:557 component=chartsync error="release word-bank-e2e: values have diverged due to manual chart release" resource=e2e:helmrelease/word-bank-e2e
ts=2019-06-24T11:49:00.393554193Z caller=release.go:167 component=release info="processing release word-bank-e2e (as word-bank-e2e)" action=UPDATE options="{DryRun:false ReuseName:false}" timeout=300s
Expected behavior
Immediate deployment of the change in the cluster when the change is made in git.
Logs
If applicable, please provide logs of fluxd or the helm-operator. In a standard stand-alone installation of Flux, you'd get this by running kubectl logs -n default deploy/flux.
Additional context
Add any other context about the problem here, e.g

Flux version: 1.12.3
Helm Operator version: 0.9.2
Kubernetes version: Major:"1", Minor:"12+
Git provider: Github
Container registry provider: private registry

Once we have https://github.com/weaveworks/flux/issues/1159, we will get a better understanding of how the helm operator is performing.
Based on discussions on Slack, we have tried reducing the --git-poll-interval, which did not result in any noticeable improvement.

@cristian-radu have you also tried reducing the --git-poll-interval and increasing the --charts-sync-interval? This should result in a less heavy occupied queue as the --charts-sync-interval schedules all known releases every interval.

Hi Hidde,
Hope you are doing well, I was looking into the flux code and I tried the
same thing. I increased the chart-sync-interval such that all releases have
time to be processed before it enqueues the next set. But to allow that I
had to set my chart sync interval at 10minutes and the change does get
effected in the same cycle, but still I think if the number of releases
increase, I will need to increase the chart sync interval and that would
again impact our time taken deploy in the cluster.
Could we have some flag set in the helm release to only enqueue those which
have been changed from git or prioritize only those which have been changed
?
Thanks & Regards,
Judewin VJ
On Tue, Jun 25, 2019 at 3:36 PM Hidde Beydals<EMAIL_ADDRESS>wrote:

@cristian-radu https://github.com/cristian-radu have you also tried
reducing the --git-poll-interval and increasing the
--charts-sync-interval? This should result in a less heavy occupied queue
as the --charts-sync-interval schedules all known releases every interval.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weaveworks/flux/issues/2183?email_source=notifications&email_token=AK6IZYKFOPFSLHNJGQ3OGBTP4H7KDA5CNFSM4H252MOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYP6AMQ#issuecomment-505405490,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK6IZYLMY352RMIX75FD4H3P4H7KDANCNFSM4H252MOA
.

--

Could we have some flag set in the helm release to only enqueue those which have been changed from git or prioritize only those which have been changed

As we work with some client-go libraries that are very common to use in the Kubernetes operator landscape, and who e.g. help us to greatly reduce the amount of API calls we make, I do not think this is going to be an option (prioritization / non-FIFO queue).
The actual solution is pretty obvious -- we should have more than one worker. The queue already ensures that we do not process two items from the same origin at the same time if we would spawn multiple workers, we do however need to make sure that all other elements perform well in a concurrent system, and ensure it does not perform a DDoS-like-attack on Tiller.

++ Noor , ++ Humayun - FYI
On Tue, Jun 25, 2019 at 5:04 PM Hidde Beydals<EMAIL_ADDRESS>wrote:

Could we have some flag set in the helm release to only enqueue those
which have been changed from git or prioritize only those which have been
changed
As we work with some client-go libraries that are very common to use in
the Kubernetes operator landscape, and who e.g. help us to greatly reduce
the amount of API calls we make, I do not think this is going to be an
option (prioritization / non-FIFO queue).
The actual solution is pretty obvious -- we should have more than one
worker. The queue already ensures that we do not process two items from the
same origin at the same time if we would spawn multiple workers, we do
however need to make sure that all other elements perform well in a
concurrent system, and ensure it does not perform a DDoS-like-attack on
Tiller.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/weaveworks/flux/issues/2183?email_source=notifications&email_token=AK6IZYO5YEM7447UMQIZQ4LP4IJXDA5CNFSM4H252MOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYQFIUA#issuecomment-505435216,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK6IZYJZM2PK3PDVUHG3IFLP4IJXDANCNFSM4H252MOA
.

--

The actual solution is pretty obvious -- we should have more than one worker. The queue already ensures that we do not process two items from the same origin at the same time if we would spawn multiple workers, we do however need to make sure that all other elements perform well in a concurrent system, and ensure it does not perform a DDoS-like-attack on Tiller.

so is this solution wip ?

@humayunjamal I worked on an (experimental) --workers flag in #2194. This has not made it to an official Helm operator release yet, but there are prereleases available here: https://hub.docker.com/r/weaveworks/helm-operator-prerelease/tags

@judewin-alef how is the --workers flag holding up? Has it resolved the issue for you (and can I thus close this issue)?

Thanks @Hidde, Yes workers flag worked well for our flux helm deployments.
Regards,
Judewin
On Mon, Jul 29, 2019 at 3:06 PM Hidde Beydals<EMAIL_ADDRESS>wrote:

@judewin-alef https://github.com/judewin-alef how is the --workers flag
holding up? Has it resolved the issue for you (and can I thus close this
issue)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fluxcd/flux/issues/2183?email_source=notifications&email_token=AK6IZYO3SVBV5PZUR3EXYXLQB3FKZA5CNFSM4H252MOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ALZCA#issuecomment-515947656,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AK6IZYI3BFGMMG5XPNSGCB3QB3FKZANCNFSM4H252MOA
.

--

What's the reasonable amount of workers VS num helm releases?

@max-lobur the complexity of your charts is more important than the amount of releases the operator manages, as large umbrella charts will take more time to roll-out than a simple single deployment chart.
To find the right amount of workers I would start with 2, and increase this amount till everything feels snappy.


feat: sway-fmt-v2 preserves newline with given threshold

Opening up for visibility.
closes #2379.
TODO:

[ ] Move threshold to config

Huge 🙌🏻 Very excited to get this in


S10: As a player I want to see a voting page where I can go through the categories one by one with the other players and see all given answers (anonymously). We are then able to vote on the correctness and uniqueness of the answers.

Acceptance criteria

[ ]     Predefined order of categories.

[ ]     Display all answers (anonymously).

[ ]     Users can vote three categories: correct and unique, correct not unique, false.

[ ]     Voting is time restricted.

[ ]     Voting system (probably majority).

[ ]     Each players points get saved in the DB.

Development Tasks
Frontend

[ ]     Add a voting page where one category is shown with all the answers (of other players)

[ ]     Add selection button template

[ ]     Add a voting overview page where one category is shown with all the answers and the votes

Backend

[ ]     Add funcitonality to save the voting and points from a specific category in a game to the game entity, gameController and gameService (add tests)

[ ]     Add websockets to control voting flow with timer

[ ]     With websockets send random fact to frontend at the end of the voting, redirect to scoreboard


AttributeError: 'DatabaseWrapper' object has no attribute 'validation'

We have some difficulties with the django-ldapdb module.
After attaching the module, the server doesn't always start and sometimes fall down with an error that is related to DatabaseWrapper
We followed examples as best we could, but didn't find the issue
traceback.txt

Hi @sonixblast,
So we ran in the same issue as you and this PR made the work : https://github.com/django-ldapdb/django-ldapdb/pull/90

Hi,
I've been unable to reproduce this bug; would you have some example code around that I could use to isolate the bug?

See attached a small project that may help you to isolate the bug.
example_code.zip

Reproducible on django 1.9.1 and django-ldapdb==0.6.0. Traceback tail:
File "*/.virtualenvs/dev/lib/python3.4/site-packages/django/db/models/fields/init.py", line 317, in _check_backend_specific_checks
return connections[db].validation.check_field(self, **kwargs)
AttributeError: 'DatabaseWrapper' object has no attribute 'validation'
After applaying PR "Fixes AttributeError: 'DatabaseWrapper' object has no attribute 'validation' #100" manually, problem disappeared.
Could you please make new release with the fix included?

Closed as fbefe52.
Reproduction was hard: we need a fully clean environment (no .pyc) to generate the error in ./manage.py check.


gh-128: Enabling Code Coverage and Refactoring

This closes #128

@dinukadesilva There seems to have some conflicts. Can you update the PR and resend?

Closing due to inactivity.


Moved to dev dependencies.

Contribution to open issue #5
Skimmed through most dependencies and added relevant ones to dev dependencies.
Ran tests and build.

Thanks for opening the PR and for your contribution, really appreciated :) 👍


add-apt-repository not working with Ubuntu & Pengwin

Windows build number : 18975.1000
WSL version : 2
I was using wsl 1 without any issue before and was able to add some ppa with a command like the following
sudo add-apt-repository ppa:ondrej/nginx

Yesterday I went to Windows Fast Ring to test WSL2.
I removed the Ubuntu distro which was working before and started fresh to see what improvements could have been made.
Whenever I'm trying to add a ppa it always hang.
I cancel the operation with ctrl+c to see some python errors:
 sudo add-apt-repository ppa:ondrej/nginx
 This branch follows latest NGINX Stable packages compiled against latest OpenSSL for HTTP/2 and TLS 1.3 support.

BUGS&FEATURES: This PPA now has a issue tracker: https://deb.sury.org/#bug-reporting

PLEASE READ: If you like my work and want to give me a little motivation, please consider donating: https://donate.sury.org
 More info: https://launchpad.net/~ondrej/+archive/ubuntu/nginx
Press [ENTER] to continue or ctrl-c to cancel adding it

^CTraceback (most recent call last):
  File "/usr/bin/add-apt-repository", line 168, in <module>
    if not sp.add_source_from_shortcut(shortcut, options.enable_source):
  File "/usr/lib/python3/dist-packages/softwareproperties/SoftwareProperties.py", line 737, in add_source_from_shortcut
    worker = self.check_and_add_key_for_whitelisted_shortcut(shortcut)
  File "/usr/lib/python3/dist-packages/softwareproperties/SoftwareProperties.py", line 678, in check_and_add_key_for_whitelisted_shortcut
    codename=self.distro.codename, distro=self.distro.id.lower())
  File "/usr/lib/python3/dist-packages/softwareproperties/ppa.py", line 371, in expand
    codename = get_current_series_from_lp(self._info["distribution"])
  File "/usr/lib/python3/dist-packages/softwareproperties/ppa.py", line 96, in get_current_series_from_lp
    return os.path.basename(get_info_from_lp(lp_url)["current_series_link"])
  File "/usr/lib/python3/dist-packages/softwareproperties/ppa.py", line 88, in get_info_from_lp
    return _get_https_content_py3(lp_url)
  File "/usr/lib/python3/dist-packages/softwareproperties/ppa.py", line 102, in _get_https_content_py3
    lp_page = urllib.request.urlopen(request, cafile=LAUNCHPAD_PPA_CERT)
  File "/usr/lib/python3.7/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.7/urllib/request.py", line 525, in open
    response = self._open(req, data)
  File "/usr/lib/python3.7/urllib/request.py", line 543, in _open
    '_open', req)
  File "/usr/lib/python3.7/urllib/request.py", line 503, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.7/urllib/request.py", line 1360, in https_open
    context=self._context, check_hostname=self._check_hostname)
  File "/usr/lib/python3.7/urllib/request.py", line 1317, in do_open
    encode_chunked=req.has_header('Transfer-encoding'))
  File "/usr/lib/python3.7/http/client.py", line 1244, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/lib/python3.7/http/client.py", line 1290, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.7/http/client.py", line 1239, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.7/http/client.py", line 1026, in _send_output
    self.send(msg)
  File "/usr/lib/python3.7/http/client.py", line 966, in send
    self.connect()
  File "/usr/lib/python3.7/http/client.py", line 1406, in connect
    super().connect()
  File "/usr/lib/python3.7/http/client.py", line 938, in connect
    (self.host,self.port), self.timeout, self.source_address)
  File "/usr/lib/python3.7/socket.py", line 716, in create_connection
    sock.connect(sa)
KeyboardInterrupt

I tested on Ubuntu (18.04 & 19.10) & with Pengwin.
Note that on pengwin I was needed to install this package:
sudo apt install -y software-properties-common

I have Kaspersky and tried to disable it, it didn't change anything.
At some point, some ppa's get added but I have no idea why as usually it fails with some errors.
Any idea if it's a bug or something else ?

This may be telling:

File "/usr/lib/python3.7/socket.py", line 716, in create_connection
sock.connect(sa)

Can you access other apt resources?
Also Kaspersky is known for causing issues with networking on WSL so it's good you disabled that to try and reproduce.

I can do apt update & upgrade.
Everything seems to update & I can install new packages.
Just not add ppa.

I unfortunately cannot reproduce on Pengwin (with sudo apt-get install -y software-properties-common) on a fresh install of 18975.
I tried twice.

I see the socket error in your log and I know dbus is a dependency for software-properties-common (which is why Pengwin does not ship it by default) so I'm wondering if there's some remnant of your Kaspersky firewall maybe hanging around causing an issue.
Also just to rule it out, nuke resolve.conf with sudo rm -r /etc/resolv.conf exit and re-open Pengwin and try again.

Was able to reproduce this on Ubuntu Disco and 18975. My mode of fail was slightly different. It is resolver related alright, but I can't say wut. Tried the usual big hammer sudo sh -c echo <IP_ADDRESS> > /etc/resolv.conf but no joy.

sudo apt install -y software-properties-common fixed this for me in Pengwin.

Disabling IPV6 in Windows fixed this.

If you don't want to disable IPV6 in Windows, you can change the precedence in the WSL disto to iv4.
use:
sudo nano /etc/gai.cong
Uncomment line:
precedence ::ffff:0:0/96  100
Tested on WSL with Ubuntu 18.04

Disabling IPV6 in Windows fixed this.

For others using WSL version 1, this was the only solution that worked from those mentioned above.

Disabling IPV6 in Windows fixed this.

For others using WSL version 1, this was the only solution that worked from those mentioned above.

None of those solutions worked for me, but what worked is doing apt update && apt upgrade


feat: rename feat: selectPortfolioCryptoHumanBalanceByFilter -> selectPortfolioCryptoPrecisionBalanceByFilter

Description

Notice

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #4203

PR #4152
PR #4204   👈

PR #4205

This comment was auto-generated by Graphite.


fix tooltip message for 'var's. (#1001007)

ok to test

The build failed because you introduced trailing whitespace: https://jenkins.scala-ide.org:8496/jenkins/job/ghprb-scala-ide-multi-conf/eclipse_platform=eclipse-luna/316/console
Also, please use if (...) format-style for the ifs.

Actually, I think the bug should be fixed in DeclarationPrinter.defString. There is also a test: DeclarationPrinterTest. This would make the behavior change applicable everywhere and not just in the hover. Once it is fixed there, no further changes need to be done in the hover.

I agree, DeclarationPrinter is the best place to fix. Let me look into it.


feat: OTel-collector logs in JSON encoding only

Description

In order to seacrh and read the logs in a connected log backend, it will be beneficial that the otel components log in JSON output.
Changes proposed in this pull request:

Enable JSON based log output for all otel-collector instances

Related Issues and Documents

Closes:
Related issues:
Traceability

[ ] The PR is linked to a GitHub Issue.
[x] New features have a milestone label set.
[ ] New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
[ ] The corresponding GitHub Issue has a respective area label.
[ ] The follow-up issues (if any) are linked in the Related Issues section.

Testability
The feature is unit-tested:

[x] Yes.
[ ] No, because unit tests are not needed.
[ ] No, because of ...

The feature is e2e-tested:

[ ] Yes.
[ ] No, because e2e-tests are not needed.
[ ] No, because of ...

Tests conducted for the PR:

Codebase

[ ] My code follows the Effective Go style guidelines.
[ ] The code was planned and designed following the defined architecture and the separation of concerns.
[ ] The code has sufficient comments, particularly for all hard-to-understand areas.
[ ] This PR adds value and shows no feature creep.
[ ] I have augmented the test suite that proves my fix is effective or that my feature works.
[ ] Adjusted the documentation if the change is user-facing.

/retest


Feature Request

Hi @emadpres,
Is there a way to crawl the Feature Requests for all projects???
Thanks in advance!

Hi @kasrahabib
Can you please clarify for me what you mean by "Feature Request"? Can you provide me an example?

By the "Feature Requests," I mean a functionality recommendation through a user for a software project; in the case of GitHub, maybe on a repository of a project.
Take for example, I use a repository, and I feel a functionality to be added then I will write a request to the owner if he/she is interested in adding it to their project.

@kasrahabib With our platform (https://seart-ghs.si.usi.ch/) you can search for repositories with certain criteria, like GitHub repositories having at least 20 contributors. So the final output is always a list of repositories (with detailed information about them).
Close to what you are looking for, you can search for all repositories that have at least one issue labeled feature-request. From there, you can write a follow-up script and extract such issues from each repository using GitHub API.

@emadpres,
Cheers to that!
Had a quick look at it, that works!!!!
Thanks!

@emadpres one more thing I forgot to add before closing the issue.
I can't harvest the issue text itself with this tool can I?

@kasrahabib happy to see you got your answer.
Concerning your last question, as I said, the output is the list of repositories matching the criteria you specified. For each repo, you will find some detailed high-level info such as number of commits, last commit date, etc. Among such info, you will also have access to the full list of labels used in a repo's issues — but nothing more than the issue labels.


feat: Manpages finder (output of apropos)

Finder to locate and view manpages

This is extremely useful  and smart, thanks @sunjon . Hope it gets merged soon.


regarding loading_weights

Hi nicolov,
In the train.py, you have included the function of load_weights(model, weights_path):. My understanding is that you are trying to load a pre-training vcg model. If I do not want to use this pretrained model because the problem I am working one may belong to a totally different domain, should I just skip calling this load_weights function? Or using a pre-trained model is always preferable, I am kind of confusing about this.
In the notes, you mentioned that The training code is currently limited to the frontend module, and thus only outputs 16x16 segmentation maps.  If I would like to leverage this code for my own data set, what are the modifications that I have to make? Do I still have to load the weights?
Thank you very much!

Generally speaking, it makes sense to start from the pretrained model. The
weights you're loading are only for the first few convolutional layers
that generalize
well across domains. Training from scratch is pretty tricky, and I'm not
sure you'd want to go there.
On Sunday, 12 February 2017, wenouyang<EMAIL_ADDRESS>wrote:

Hi nicolov,
In the train.py, you have included the function of load_weights(model,
weights_path):. My understanding is that you are trying to load a
pre-training vcg model. If I do not want to use this pretrained model
because the problem I am working one may belong to a totally different
domain, should I just skip calling this load_weights function? Or using a
pre-trained model is always preferable, I am kind of confusing about this.
Thanks,
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nicolov/segmentation_keras/issues/6, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AKO4B_Lor5yXR1Miv4ocjGvr7xP_4UZ-ks5rbf4HgaJpZM4L-QMO
.

Hi nicolov, thanks for the reply. Generally, if a network architecture is built based on an pre-existing network, such as imagenet or vgg, it is always desirable to initialize the weight using pre-existing model. Is that a common rule for training DL model? Generally, what are those tricky issues when training from scratch, how to to handle them?
Besides, with respect to dilated convolution, it seems to me that the paper referred designs a specific context module to use it. In generic, can I use dilated convolution as follows, I just replace normal convolution layer with dilated convolution. Is that a reasonable approach?  Thanks.

Actually, the reasoning goes the other way around: people build their
architectures on top of VGG so that they're able to use the pretrained
weights. Training from scratch requires ImageNet-scale data and is
sensitive to hyper-parameters.
For your second question, the answer is yes. Just pay attention to the
image size at each layer.
On 12 February 2017 at 13:50, wenouyang<EMAIL_ADDRESS>wrote:

Hi nicolov, thanks for the reply. Generally, if a network architecture is
built based on an pre-existing network, such as imagenet or vgg, it is
always desirable to initialize the weight using pre-existing model. Is that
a common rule for training DL model? Generally, what are those tricky
issues when training from scratch, how to to handle them?
Besides, with respect to dilated convolution, it seems to me that the
paper referred designs a specific context module to use it. In generic, can
I use dilated convolution as follows, I just replace normal convolution
layer with dilated convolution. Is that a reasonable approach? Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nicolov/segmentation_keras/issues/6#issuecomment-279198739,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKO4BwieV2u5CyllQSLrkXbtPsJwiAd0ks5rbp2ggaJpZM4L-QMO
.

Thanks a lot!


Better name for library :)

The currently library name is way to generic and doesn't sound really appealing

There is also a name conflict with playlyfe/go-graphql, which shows up in golang-graphql-benchmark.

It's also a bit unclear if your library is an actual GraphQL server, or just a way to generate a schema, like Nexus. Since the README says:

"Easy to implement in many web servers, see the gin and fiber examples."

The description wasn't clear enough either:

Just a different approach to making graphql servers in Go

At first i was like this is a GraphQL server ofc but now that i'm thinking of it i'm not sure anymore.
As stated in the readme this project does not generate code and when a Go project is referring to "generating" it usually means files are generated with code.
But that does not mean this library doesn't generates things, it analyzes your code to generate a map of your code layout so we can handle GraphQL queries tough this is an internal process that is not exposed to the library user.
Because of that i'm not sure if we should name it a schema generator.
On the other hand it's meant to be a sever but i don't think it actually is.
The handling of a request is dead simple and is more like a library method where you put data in and get data back and nothing happens in the background.
(I say nothing but we actually re-use the same byte slices so we have less allocations but still one request doesn't have effect on another)
I would say this is a GraphQL library meant to build a GraphQL server with. So not a generator nor a server

How would you say this library is different than Nexus?

Name suggestion: Allogo
Playing on the unique feature that it has 1 memory allocation / operation.

How would you say this library is different than Nexus?

I don't have any experience with Nexus and neither with writing GraphQL servers in js so i can only make assumptions here.
The library gives me a very similar feel to graphql-go/graphql
I personally don't like graphql-go/graphql and many other Go GraphQL libraries as they require you to add lots of extra code usually in the form of converters to convert your Go struct types to library understandable data.
This is becuase in most libraries your schema type is sperate from your types in your code, this can be very nice but sometimes this means you'll
That was the biggest reason why i made this library to get rid of most of this dumb code.
That said there are Go Libraries that generate this conversion code for you (99designs/gqlgen) that eliminate the annoyances i personally had with the other libraries but I'm personally not a fan of using code generators they don't feel clean and there is something nice in cloning a repo and doing a go run . and it runs, no more setup required.
I think you can see this library

Name suggestion: Allogo
Playing on the unique feature that it has 1 memory allocation / operation.

Sound like a nice name tough it's not necessary a unique feature it's just well optimized :).
Still i would like to have zero allocations for basic queries.

I don't have any experience with Nexus and neither with writing GraphQL servers in js so i can only make assumptions here. The library gives me a very similar feel to graphql-go/graphql
I personally don't like graphql-go/graphql and many other Go GraphQL libraries as they require you to add lots of extra code usually in the form of converters to convert your Go struct types to library understandable data as the library schema type is different from the go types.

Nexus actually allows you to write the types only once, in code, and then it generates the schema types based on that. So no converter is needed. The conversion is automatic through using the Nexus API.
"GraphQL Nexus is a declarative syntax layered on [top of] the graphql-js library." That seems a bit different than what graphql-go/graphql is, which is more a direct mirror of graphql-js (see comparison of main.go and schema.js here, which also states "graphql-go is that it has near-identical API to graphql-js").

Ah that makes sense, thanks for the explainer.
I think this library is somewhat equal to to Nexus then in the sense that no conversion is needed and it does the generating of a schema for you.
Tough it's different in that it does not use an underlying library for the graphql request handeling that is handled by this library already.

Well I finally found a new name!, the project is now called YarQL!


Added useful examples section (english and spanish)

Validating Email and HTML are complicated. You'd better add a warning that they are not used for real validation.

Yep, @imba-tjd you're right, I will add the warning soon.
Thanks for your feedback :smiley:

Thanks for the contribution but we will not add examples as you could find tons of examples regarding regex online. :)


Test 'apiMiddleware must dispatch an error request FSA on a request error' fails in Windows

The build only failed locally on my Windows machine, but not Travis-CI.
Simply clone the project and run the tests. Tests failed with following error:

apiMiddleware must dispatch an error request FSA on a request error

v next handler called
v dispatched non-error FSA has correct type property
v dispatched non-error FSA has correct payload property
v dispatched non-error FSA has correct meta property
v dispatched non-error FSA has correct error property

x plan != count
----------------
operator: fail
expected: 10
actual:   5

x test exited without ending
-----------------------------
operator: fail
....................
total:     148
passing:   137
failing:   11
duration:  5.5s

Looking into 'apiMiddleware must dispatch an error request FSA on a request error' test, the test does not call the second handler, and all the checks for the error FSA are skipped.
Machine Information:
Windows 7 Enterprise SP1
node: v4.2.1
npm: 2.14.7

I just cloned the latest: https://github.com/agraboso/redux-api-middleware/tree/2cedb9215ec24f288c98e70b514d5e8f3f0a0a03
And ran
npm run clear
npm run install
npm run build
npm run test

And all tests passed, no errors.
Machine:
Windows 10
node: v5.4.0
npm: v3.5.3

I'm going to close this soon.. but let it linger for upto a week in case someone wants to comment.

I saw this failure too when I tried running tests with Apache enabled in my machine. The problem is that the endpoint isn't mocked in the test. Left a comment about it in #45.


For sorted containers: add more constructors; add new behavior for 'i…

…n' function
Added more constructors for SortedDict and SortedMultiDict to mimic bulit-in Dict constructors; added code for fast lookup of in(k, keys(sc)) where sc is is a SortedDict or SortedMultiDict.
Did not address issue #112 because it appears that the changed to IntSet in 0.4 is going to be reverted soon.

Also: added 'similar' function to mimic built-in 'similar' for Dict.


Bad versión bumped

Hi everyone,
its seems that the last versión of the gulp-bump not support version like "2016.0.1-SNAPSHOT". We discussed this issue in https://github.com/nfantone/gulp-release/issues/20.
This version number is accepted by semver and not long time ago that i released projects with this versioned without problems.

Closing for #62, same issue.


Add tagging to SQS

SQS Tags introduced on 10/19.

@kapilt I am working on this.

SQS is not supported in ResourceGroupTaggingAPI. We can augment tags the traditional way, where we add tag related actions and filters per resource type. For now, waiting a couple of days to get another update(support SQS tags in ResourceGroupTagging) from AWS on this.

the resource tagging api has not been updated with any resources since announce, none of the new resources that support tagging use that api, the work for this is still the same as when it was claimed..


Add --file flag for docker secret create command

- What I did
This fix tries to address the issue raised in #28581 and #28927 where it is not possible to create a secret from a file (only through STDIN).
- How I did it
This fix add a flag --file to docker secret create so that it is possible to create a secret from a file with:
docker secret create --file secret.in secret.name

or
echo TEST | docker secret create --file - secret.name

Related docs has been updated.
- How to verify it
An integration test has been added to cover the changes.
- Description for the changelog
Add --file flag for docker secret create.
- A picture of a cute animal (not mandatory but encouraged)

This fix fixes #28581.
This fix is related to #28927.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

/cc @thaJeztah @ehazlett

I think we should have;

an - option on docker create secret (like we have on docker build to specify that we want to use stdin as input
have a --file flag

but @diogomonica for thoughts as well

Given that I think it's trivial for people to do cat file | docker secret create, I don't think we need a file option, and having to specify --input is annoying, so I would say we don't change anything.
This said, I'm fine with whatever makes it more consistent with the rest of docker.
My requirements are that you can do openssl rand | docker secret create

Given that I think it's trivial for people to do cat file | docker secret create, I don't think we need a file option

Perhaps we should check if that's just as easy / common on Windows.

This said, I'm fine with whatever makes it more consistent with the rest of docker.

I did a quick check on what we have right now. On docker load, we have an --input flag. For docker import, and docker build, the file is the first argument (so - has to be specified to load from stdin).
One improvement we can make is to add better handling if no input is provided. It's confusing that when running docker secret create, it seems to "hang". For docker load we added a check, and it prints a message if no input was provided;
docker load
requested load from stdin, but stdin is empty

Typically CLI tools that support input via stdin also have a --file (or whatever), so SGTM.

Perhaps we should check if that's just as easy / common on Windows.
Don't see why it wouldn't work, IIRC shell pipes are supported on Powershell.
@jhowardmsft

Opened https://github.com/docker/docker/pull/28661 to improve  the feedback if no input was provided

I'm also SGTM for --file.  @thaJeztah +1 for error on no feedback.

This issue is also related to #28927. From the comment (https://github.com/docker/docker/pull/28629#issuecomment-261963379) in this PR and in #28927, it seems that the consensus is to introduce a --file [file|-] flag to explicit specify the input.
I updated the PR to reflect the new changes. The PR description and title has been changed as well.

/cc @aaronlehmann @aluzzardi @diogomonica @cyli @tianon please take a look as well.

LGTM (NAM)

LGTM

LGTM

Does this also work with:
docker secret create name -f file

That is, having flags after the secret name?

Thanks @aluzzardi. Yes the docker secret create name -f file works as well. I updated the PR and added a test case to the integration test to cover it. Please take a look.

@yongtang would you mind rebasing?  thx

Thanks @ehazlett. The PR has been rebased.

thanks!
On Fri, Dec 9, 2016 at 5:31 PM, Yong Tang<EMAIL_ADDRESS>wrote:

Thanks @ehazlett https://github.com/ehazlett. The PR has been rebased.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/pull/28629#issuecomment-266072171, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAP6Isy5aCMAlsLWJKoM-TbDpq4dJ8Dxks5rGZBdgaJpZM4K3bQu
.

@yongtang didn't this PR have a check if stdin is empty (like in https://github.com/docker/docker/pull/28661)? I seem to recall doing this;
docker secret create changes -f -

produced an error
otherwise LGTM

@thaJeztah There were some concerns about producing an error in that situation so the check was removed later (see https://github.com/docker/docker/pull/28629#discussion_r90507453)

didn't this PR have a check if stdin is empty (like in #28661)?

There were some concerns about producing an error in that situation so the check was removed later (see https://github.com/docker/docker/pull/28629#discussion_r90507453)

I might be confused, but the comment you linked to seems to be attached to this (removed) code:
	if options.file == "-" {
		// To avoid getting stuck, verify that a file is given in STDIN
		if dockerCli.In().IsTerminal() {
			return fmt.Errorf("Requested from STDIN ('-'), but STDIN is empty")

I don't see that checking that stdin is empty, which is why I commented on it ("...And the error message doesn't seem right for this case."). I might be missing some context, though. I would be fine with having a check, but this would have to happen after the data is read, because otherwise how can you know if you receive no data on stdin?
Anyway, there's a check on the swarmkit side, so it doesn't really matter if we check this on the client side.

@aaronlehmann the error was shown if I tried to create a secret from stdin, but didn't provide any content. Right now, the CLI blocks until content is provided. Now that selecting stdin is an explicit action (i.e., I need to set -f -), I don't think that's a problem (from a UX perspective)

Agreed. The only thing we might consider adding is an error message if you hit ^D without typing anything. But as I mentioned, such an error should be sent back from the daemon anyway (mind giving it a try?).

@aaronlehmann Detaching without typing does produce an error, so that looks ok (error presentation could be nicer, but that's for other errors as well);
docker secret create foo -f -
^D
Error response from daemon: rpc error: code = 3 desc = secret data must be larger than 0 and less than 512000 bytes


Implement UI for new automatic snapshot feature

Signed-off-by: Igor Pashev<EMAIL_ADDRESS>

This change is

Moving to the other branch https://github.com/whamcloud/integrated-manager-for-lustre/tree/ip1981/EX-1835-snapshot-v2-svc


pytest with depends function throw errors -> AttributeError: 'Depends' object has no attribute

Description
While using pytest with function that defined with Depends(), it throw errors.
AttributeError: 'Depends' object has no attribute 'get_topic_list'
Example
Target class
class Service:
    def __init__(self, topic_repo: TopicRepo = Depends()):
        self.topic_repo = topic_repo

    async def get_topic_list(
        self,
        page: int,
        per: int,
    ) -> Union[List[TopicSchema], List]:
        return await self.topic_repo.get_topic_list(page=page, limit=per)

Test
from apps.topic.services import Service
import pytest

@pytest.mark.asyncio
async def test_get_topic_list_service():
    service = Service()
    result = await service.get_topic_list(page=1, per=1)

I think dependency injection through Depends() does not support on pytest, or other approach.
So maybe I have to mocking Depends(), but I don't know exactly how can I do.
Any best way for this case?
Environment

OS: macOS
FastAPI Version: 0.61.0
Python version: 3.8.2

Additional context

Are you using cbv from fastapi_utils?

You can't instantiate Service() directly. It's meant to be a dependency (it has a dependency on its constructor). If you want to check exactly what is happening:
from apps.topic.services import Service
import pytest

@pytest.mark.asyncio
async def test_get_topic_list_service():
    service = Service()
    print(service.topic_repo)
    result = await service.get_topic_list(page=1, per=1)

What I recommend is that you mock the Service() attribute topic_repo. Something like:
mocker.patch(service, 'topic_repo', <value>)

@ycd Nope.
@Kludex with pytest-mock library?

@teamhide yes

I have the same problem, but in my case, is occurring when I use Depends i another function thats aren't from path operations.

If you have a class that is expected to be used as a dependency with subdependencies and you need to use it directly in other places in the code, you need to pass the keyword argument for the subdependencies manually.
So, you need to call it as normal Python code. In that case, FastAPI has nothing to do with it.

Sorry for the long delay! 🙈  I wanted to personally address each issue and they piled up through time, but now I'm checking each one in order.


How to enable message and trace logging together using circular tracing library?

I am trying to use circular tracing for MessageLogging as well;
But:
If I create a messageLogging listener alone --> 2 files are generated with max size = 20 as it is mentioned in the web.config;
If I create a trace listener alone --> 2 files are generated with max size = 20 as it is mentioned in the web.config;
If I create them together -->  the library does not generate 2 web_Trace files log, only web_Trace00.cvclog is generated and its size can overpass the max size; In addition of that the library has generated 2 messages log files but without respecting the max file size; You can refer to the below screenshot;

Below is my web.config code:
<system.diagnostics>
      <sources>
        <source name="System.ServiceModel.MessageLogging" switchValue="Warning, ActivityTracing" >
          <listeners>
            <add name="CircularMessageListener" />
          </listeners>
        </source>
        <source name="System.ServiceModel" switchValue="Warning, ActivityTracing" propagateActivity="true">
          <listeners>
            <add name="CircularTraceListener" />
          </listeners>
        </source>
      </sources>
      <sharedListeners>
        <add name="CircularMessageListener" type="Microsoft.Samples.ServiceModel.CircularTraceListener, CircularTraceListener, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null"
            initializeData="C:\inetpub\wwwroot\MyProject\Log\web_messages.svclog" maxFileSizeKB="20" />
        <add name="CircularTraceListener" type="Microsoft.Samples.ServiceModel.CircularTraceListener, CircularTraceListener, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null"
            initializeData="C:\inetpub\wwwroot\MyProject\Log\web_Trace.svclog" maxFileSizeKB="20" />
      </sharedListeners>
     <trace autoflush="true" />
    </system.diagnostics>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 98d8b9c4-f498-32dc-223d-d4d8a196cd10
Version Independent ID: 55d8fe54-8990-a912-27cd-0a6290f8150c
Content: Circular Tracing
Content Source: docs/framework/wcf/samples/circular-tracing.md
Product: dotnet-framework
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

I discovered that for message log file: some messages length is bigger then 20 KB, that's why message logging file became bigger then 20, after that the other file logs the data as it is expected;
What about tracing log file? Why the library did not create another file after the max size was overpassed?


Support Gif preview in picker cell

Hi ,dear author,
It's a good idea that your great pod support Gif preview in picker cell.
Brando.

Hi, @brandy2015
I thought about it before.
I think I can make it by referring to another open source library. SwiftyGif
It'll take time, but I'll go over it.

😀

Any progress with this?


Changed all the keywords to anonymous nodes

@Chris44442, @superzanti,
I got annoyed with all the keywords that are explicit in the syntax tree, so I changed them all to anonymous nodes (i.e. strings, like the operators are at the moment).
But I need a second opinion...  Is this a good idea?  Should I merge this?  Are there keywords (like all, for example, that are better left explicit?

I have tried it with a few of my vhdl files, and looked through your tests. Looks good to me, makes the tree more concise.
I don't think these keywords need to be present in the tree. Most of them are implied anyway. In other languages the tree-sitter doesn't explicitly spell them out neither (at least the ones i have tried).

The one I'm wondering about now is the architecture declaration followed by identifier and name.  I think I should clarify that with field names (I agree that removing the keywords was a good choice, but now that part of the tree is not quite as readable).
Let me come up with something and then push to this PR... I'm thinking to use the italic parts in the formal grammar for the field names...

I'm quite happy with the commit above.  It certainly makes the highlights easier:
(_ view: (_) @type)
(_ type: (_) @type)
(_ library: (_) @namespace)
(_ package: (_) @namespace)
(_ entity: (_) @namespace)
(_ component: (_) @namespace)
(_ configuration: (_) @type.parameter)
(_ architecture: (_) @type.parameter)
(_ function: (_) @function)
(_ procedure: (_) @function.method)
(_ attribute: (_) @attribute)

(_ view: (name (_)) @type)
(_ type: (name (_)) @type)
(_ entity: (name (_)) @namespace)
(_ component: (name (_)) @namespace)
(_ configuration: (name (_)) @namespace)

An architecture now builds the following tree:
(design_file
  (design_unit
    (architecture_definition
      architecture: (identifier)
      entity: (name
        (identifier))
    (architecture_head
      ...
    (concurrent_block
      ...
    (end_architecture
      architecture: (identifier)))))

I'm going to merge to develop and then we can continue testing...

I think this is a good idea - anonymous nodes can still be used in most tree-sitter extensions.
I'm fixing most of my scm files now, so I'll let you know if there are any keywords that would be better lefts as non-anonymous. I'll let you know.


feat: use peer-pad-core with js-ipfs 0.30

Let's give this a spin
Depends on:

[ ] https://github.com/ipfs-shipyard/peer-pad-core/pull/21

@diasdavid we'll need to add the package-lock back in. We've had stability issues with peer-pad in prod due to moving package versions so we switched to using package locks to improve stability.

Getting JSON parse errors
in Firefox

in Chrome

I believe this is connected to the fact that the PubSub API changed. Need to debug at the y-ipfs-connector level

Seems to be working now. Can someone else test it? Thank you!

I'm not sure if this is ok, but current PeerPad makes new peerpad break:

It works as expected on my machine. Tested with Chrome 67.0.x and Brave 67.0.x 👌

Chrome and Firefox are communicating okay for me. There is some bugginess with the tabs, but that looks to be an existing issue.
@diasdavid peer-pad is setup to do a staging deploy for merges to master. I talked to @VictorBjelkholm last week about needing to get the DNS entry setup, https://github.com/ipfs-shipyard/peer-pad/issues/152#issuecomment-396248060. If we get that resolved we can test this in staging a bit more together, and then cut a production release via the production branch

NEW <-> NEW works fine

It's NEW <-> Current that fails. Seems that something changed on the data model (previously was not JSON??)

NEW <-> old failures should not matter much as soon as you deploy the new version. I'm not sure what happens to those using the older version, but I reckon there might not be many peerpad users atm 🤔

@gpestana

NEW <-> old failures should not matter much as soon as you deploy the new version

While it's true currently that PeerPad doesn't have many current users, we should be in the mindset that versions should be compatible in-between upgrades, for many reasons. Most importantly, users should be able to pull down a version and use it locally and still be compatible with other clients. If exact version is enforced, this becomes very brittle. Secondly, during the updating of dns records, different users will get different dns replies, and the application will be broken.
But, not a huge issue right now, but we need to care about this in the future.

@VictorBjelkholm

While it's true currently that PeerPad doesn't have many current users, we should be in the mindset that versions should be compatible in-between upgrades

Completely agree 👍

@VictorBjelkholm you are preaching the mess to the quire here :) I 💯 agree with your statement and I see how my comment got taken out of context.
Peerpad is in a inconsistent state for 7 months, so much that things are not working, out of date or there were migrations on the data model that made things break. This was caused by lack of resources + project shuffling + lack of consistent product management.
@pgte is now focused to level everything to a new level with peer-crdt and peer-star-app, a new version will come out very soon. Meanwhile, this update comes to make things slightly better and move the needed a bit forward on the "maintenance side".

Url: https://www.youtube.com/watch?v=g0l738fq3C0


Simplify UI

UI now looks like this when it doesn't have a lot of space:

But also looks decent when it does have a lot of space:

Replaced by https://github.com/comit-network/hermes/pull/125.


[ISSUE] Reproduce issue with variables with no catch-all rule

The setup

Have a feature with variations and variables
Have no rules that match context when evaluated with SDK
Have a forced condition for forcing variation
Variations should have variables, with custom overrides embedded in them

The issue
Without the catch-all rule, the tests fail.
Ideally, it should still pass.
Workaround
Use a catch-all rule with segment: "*" as the last rule, then everything works as expected.
Where to fix?
The fix might be in SDK's .evaluateVariable() method.

Until there's a fix, make use of this configuration so that linting picks it up helping avoid the issue altogether: https://featurevisor.com/docs/configuration/#enforce-catch-all-rule


Unable to load or use

My expectations were to copy to addons folder, and get an editable node, it appears you need to open as a project to be able to use, so proceeding from there -- so its not strictly an addon you can put into and use from any project. I used the project, but I'm still getting an error, in plugin.gd something is not in scope.
Yes, the addon is copied to the addons directory
Yes, the addon is enabled
Yes, autoload is enabled
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "Cartographer" isn't declared in the current scope.
   At: res://addons/cartographer/texture_painter/texture_painter.gd:69.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "Cartographer" isn't declared in the current scope.
   At: res://addons/cartographer/texture_painter/texture_painter.gd:69.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The class "TexturePainter" couldn't be fully loaded (script error or cyclic dependency).
   At: res://addons/cartographer/terrain/carto_terrain_material.gd:13.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "Cartographer" isn't declared in the current scope.
   At: res://addons/cartographer/texture_painter/texture_painter.gd:69.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "Cartographer" isn't declared in the current scope.
   At: res://addons/cartographer/texture_painter/texture_painter.gd:69.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The class "TexturePainter" couldn't be fully loaded (script error or cyclic dependency).
   At: res://addons/cartographer/terrain/carto_terrain_material.gd:13.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The class "CartoTerrainMaterial" couldn't be fully loaded (script error or cyclic dependency).
   At: res://addons/cartographer/terrain/carto_terrain.gd:144.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "Cartographer" isn't declared in the current scope.
   At: res://addons/cartographer/terrain/carto_terrain_material_editor/layers_editor.gd:26.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: Couldn't fully preload the script, possible cyclic reference or compilation error. Use "load()" instead if a cyclic reference is intended.
   At: res://addons/cartographer/terrain/carto_terrain_inspector.gd:4.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "Cartographer" isn't declared in the current scope.
   At: res://addons/cartographer/texture_painter/texture_painter.gd:69.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "Cartographer" isn't declared in the current scope.
   At: res://addons/cartographer/texture_painter/texture_painter.gd:69.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The class "TexturePainter" couldn't be fully loaded (script error or cyclic dependency).
   At: res://addons/cartographer/terrain/carto_terrain_material.gd:13.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "Cartographer" isn't declared in the current scope.
   At: res://addons/cartographer/texture_painter/texture_painter.gd:69.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "Cartographer" isn't declared in the current scope.
   At: res://addons/cartographer/texture_painter/texture_painter.gd:69.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The class "TexturePainter" couldn't be fully loaded (script error or cyclic dependency).
   At: res://addons/cartographer/terrain/carto_terrain_material2.gd:13.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The class "CartoTerrain" couldn't be fully loaded (script error or cyclic dependency).
   At: res://addons/cartographer/terrain/collision_carto_terrain.gd:6.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:599.
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "Cartographer" isn't declared in the current scope.
   At: res://addons/cartographer/texture_painter/texture_painter.gd:69.

The problem appears to begin at line 4 in plugin.gd
const Action = Cartographer.Action

where 'Cartographer' is just dropped there out of scope without import or reference

It should definitely work as an addon. Have you enabled the Cartographer singleton (see #5, make sure to restart Godot afterward)? Are you using a release version? (Don't clone master).

hmm, I was using the main branch cloned off git, I'll need to check that.

Success?


Add support for innerWrapperClass data-attribute

If possible it would be nice to be able to specify the innerWrapperClass via data-attributes too.

I've tried something like that and it work perfectly.
<div id="sidebar" data-sticky-sidebar data-top-spacing="20" data-inner-wrapper-class="sidebar-inner">