Add more cross-linking within the Format page

What's this PR do?
There were already a handful of cross-referential links on the Format page (for example, linking the term "resource object" to the Resource Objects section). This PR adds more of those.
Where should the reviewer start?
The changes should be pretty straightforward. I made a few text changes to make the links work better (like changing "jsonapi object" to "JSON API object").
Also, there are distinct concepts of a "relationships object" (the relationships member of a resource object), and a "relationship object" (a member of the "relationships object" that defines a particular relationship). I added a Relationship Object sub-heading under Relationships so I could link directly to the discussion of these objects.
Any background context you want to provide?
I apologize for submitting stuff like this in the run-up to 1.0. I had actually set out to look into the "centralize definition of links and the semantics around use to a single section" item of #659, but got sidetracked here.

Thanks @nonsensery! Would you be willing to remove the quotes around links? "[attributes object]" can be [attributes object], for example. Once that's in, I'd be happy to merge this.

@tkellen Done!

Ack, could you please rebase so we can land this?

So sorry  - let me land #713 before you rebase.

Hey @nonsensery--we super appreciate this PR but the recent PRs we landed made this a bit of a merge nightmare. Would you be willing to update in the next hour or so? If no, I think we'll need to close this and re-implement your work :/.

Yeah, I started working on rebasing this and got fully embroiled in the merge conflicts. I won't have time to finish it until tomorrow, so I won't be upset if you close it and start over without me. Otherwise I'll take a stab at it in the morning.

Sorry Alex :( I'm going to give this a close. I'm sure there will be more needed in the AM, but I am working on a read through fixing things now.


Enchanter Crash

Set up my Enchanter and went to access the GUI and get this crash. First time submitted a bug report so let me know if you need any more info or if you like a better format for bug reporting. Thanks.
http://pastebin.com/AE0Z2FL0

#2756


fixed(markdown): render the markdown in browser.

fixes #451
closes #451

Is this repository died? I found this bug today.

I've created a PR that contains the previous code, as well as a test that verifies this is an issue.

This can be closed @clayreimann.

Closing in favor of #548


strange error after simple experiments

I have no idea what can it be, also sometimes it gets segmentation faults, which I dont understand as well

It is really hard to understand just from this error without the context what could be the issue.

looks like something wrong with my env, I'll try rebuild it later


SDK fetch: Curl retries refuse to overwrite file.

Describe the bug
There is an option added to the curl command which will retry if the fetch fails. The issue is if the file is created at all on the filesystem, the retry will refuse to overwrite it.
 Sleep 300 secs, then retry 1...
00:09:53.832  _ENCODE_FILE_NEW=UNTAGGED curl -OLJSks --user ****:**** https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Build_JDK11_x86-64_linux_Nightly/306/OpenJ9-JDK11-x86-64_linux-20200303-030650.tar.gz
00:09:53.832  curl: (23) Failed writing body (0 != 15607)
00:09:53.832  curl error code: 23. Sleep 300 secs, then retry 2...
00:14:50.956  _ENCODE_FILE_NEW=UNTAGGED curl -OLJSks --user ****:**** https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Build_JDK11_x86-64_linux_Nightly/306/OpenJ9-JDK11-x86-64_linux-20200303-030650.tar.gz
00:14:50.956  curl: (23) Failed writing body (0 != 15607)
00:14:50.956  curl error code: 23. Sleep 300 secs, then retry 3...
00:19:56.649  _ENCODE_FILE_NEW=UNTAGGED curl -OLJSks --user ****:**** https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Build_JDK11_x86-64_linux_Nightly/306/OpenJ9-JDK11-x86-64_linux-20200303-030650.tar.gz
00:19:56.649  curl: (23) Failed writing body (0 != 15607)
00:19:56.649  curl error code: 23. Sleep 300 secs, then retry 4...
00:24:51.270  _ENCODE_FILE_NEW=UNTAGGED curl -OLJSks --user ****:**** https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Build_JDK11_x86-64_linux_Nightly/306/OpenJ9-JDK11-x86-64_linux-20200303-030650.tar.gz
00:24:51.270  curl: (23) Failed writing body (0 != 15607)
00:24:51.270  curl error code: 23. Sleep 300 secs, then retry 5...
00:29:48.770  _ENCODE_FILE_NEW=UNTAGGED curl -OLJSks --user ****:**** https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Build_JDK11_x86-64_linux_Nightly/306/OpenJ9-JDK11-x86-64_linux-20200303-030650.tar.gz
00:29:49.577  curl: (23) Failed writing body (0 != 15607)
00:29:49.577  curl error code: 23
00:29:49.577  Failed to retrieve https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Build_JDK11_x86-64_linux_Nightly/306/OpenJ9-JDK11-x86-64_linux-20200303-030650.tar.gz, exiting. This is what we received of the file and MD5 sum:
00:29:49.577  ls: cannot access 'https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Build_JDK11_x86-64_linux_Nightly/306/OpenJ9-JDK11-x86-64_linux-20200303-030650.tar.gz': No such file or directory
00:29:49.577  md5sum: 'https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Build_JDK11_x86-64_linux_Nightly/306/OpenJ9-JDK11-x86-64_linux-20200303-030650.tar.gz': No such file or directory

Rerunning a similar command by hand without -s
$ curl -OLJSk  https://140-211-168-230-openstack.osuosl.org/artifactory/ci-eclipse-openj9/Build_JDK11_ppc64le_linux_Personal/731/test-images.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0Warning: Refusing to overwrite test-images.tar.gz: File exists
  0 24.6M    0 15698    0     0  17186      0  0:25:05 --:--:--  0:25:05 17175
curl: (23) Failed writing body (0 != 15698)

Refusing to overwrite test-images.tar.gz: File exists

From what I found from a quick search this is not necessarily easily fixed with another option.
https://unix.stackexchange.com/questions/19608/how-can-i-specify-that-curl-via-command-line-overwrites-a-file-if-it-already-e/19609
To Reproduce
Touch a file with he same name as the one you are about to download.
Expected behavior
In my opinion, since these are build scripts, the behaviour should be to overwrite the file(s).

fyi @pshipton

Seems like remove the -J option gives me the desired behaviour.
 -J, --remote-header-name  Use the header-provided filename (H)
 -S, --show-error    Show error. With -s, make curl show errors when they occur
 -s, --silent        Silent mode (don't output anything)
 -O, --remote-name   Write output to a file named as the remote file
 -L, --location      Follow redirects (H)
 -k, --insecure      Allow connections to SSL sites without certs (H)

Related #1425 #1150
I see we no longer use the curl retry and instead use a loop. Could we add a cleanup to the loop?

Thinking about cases where the url is an api request and does not contain a filename. The header returned contains the filename.
ex
$ curl -OLJSkv  https://api.adoptopenjdk.net/v3/binary/latest/8/ea/aix/ppc64/jdk/openj9/normal/adoptopenjdk
...
< Content-Disposition: attachment; filename=OpenJDK8U-jdk_ppc64_aix_openj9_2020-03-03-01-09.tar.gz
...

Related: https://github.com/AdoptOpenJDK/openjdk-tests/issues/1419

It would be nice if this could be fixed soon, since lately there are artifactory download failures every night in the OpenJ9 testing.

In the original code, we did use curl retry options (#1099), but the retry did not work in the nightly builds (curl retry did not get triggered due to a different return code?). To work around the issue, we switched to use a loop (#1150).
For a quick fix, we can update the script to remove the file if the URL contains the filename (nightly build URL contains filename).
IMO, for the url that does not contain filename (mentioned in https://github.com/AdoptOpenJDK/openjdk-tests/issues/1667#issuecomment-595323207), I think we should not write the script to figure the filename from the header and delete the file. I feel this is too much hacking, which may cause more problems and it is not needed atm. I think we should investigate the problem and fix it properly.

Fix has been merged https://github.com/AdoptOpenJDK/openjdk-tests/pull/1685


[RFC]: Add C implementation for @stdlib/math/base/special/ellipe

Description
This RFC proposes adding C implementation for @stdlib/math/base/special/ellipe.
double stdlib_base_ellipe( const double m );

Related Issues
#766.
Questions
No.
Other
No.
Checklist

[X] I have read and understood the Code of Conduct.
[X] Searched for existing issues and pull requests.
[X] The issue name begins with RFC:.

Hey, can I get assigned for this issue ? @Pranavchiku

@gunjjoshi Sounds good. Feel free to submit a PR adding the implementation.

 Even though after installing it using brew install cppcheck, it says the same thing. Do you have any ideas regarding this ?

Also, after installing it, all the files in /lib such as poly_p1.js, poly_p2.js, poly_p3.js.... change automatically.
Thus resulting in lint errors arising due to different expected values.

Run make install-deps-cppcheck

Also, not sure why the files in /lib would change automatically. cppcheck is only for linting. It is not a runtime C or JS dep.

Also, not sure why the files in /lib would change automatically. cppcheck is only for linting. It is not a runtime C or JS dep.

Thanks, I'll check if something is wrong on my side once again.


Added in create-react-app using npx

Description
Added in create-react-app using npx command
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Made sure create-create-app worked on local machine

[ ] Test A
[ ] Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Great start. Looking forward to see all your inputs.


Attachments Open dialog FIle

There is a way to upload a file by opening a file dialog or by dragging the file into the bot?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 607856cb-baae-c401-5b34-876b5018771d
Version Independent ID: 77df1de7-7b2e-a546-1280-a66121039a94
Content: Add media to messages - Bot Service
Content Source: articles/v4sdk/bot-builder-howto-add-media-attachments.md
Service: bot-service
Product: bot-framework
GitHub Login: @ivorb
Microsoft Alias: v-ivorb

Please see https://stackoverflow.com/a/50689918/86646  (This uses WebChat V3, but a similar concept should also work for WebChat V4)

There is a prompt type for attachments, AttachmentPrompt. I'll investigate and report back.

Attachment prompts are mentioned in the Prompt types section of the Dialog library topic.
Here's some partial bot code that creates a dialog for collecting PNGs from the user. How a user sends attachments to the bot depend upon the channel.
public class AttachmentsBotBot : IBot
{
    private const string DialogStateAccessorName = "AttachmentsBot_DialogStateAccessor";
    private const string PromptId = "AttachmentPrompt";
    private const string DialogId = "MainDialog";
    private readonly ILogger _logger;
    private readonly ConversationState _conversationState;
    private readonly IStatePropertyAccessor<DialogState> _dialogStateAccessor;
    private readonly DialogSet _dialogs;

    public AttachmentsBotBot(ConversationState conversationState, ILoggerFactory loggerFactory)
    {
        _logger = loggerFactory.CreateLogger<AttachmentsBotBot>();
        _logger.LogTrace("Turn start.");

        _conversationState = conversationState;
        _dialogStateAccessor = conversationState.CreateProperty<DialogState>(DialogStateAccessorName);
        _dialogs = new DialogSet(_dialogStateAccessor)
            .Add(new AttachmentPrompt(PromptId, AttachmentValidator))
            .Add(new WaterfallDialog(DialogId, new WaterfallStep[]
                { PromptStep, AcknowledgeStep, }));
    }

    private async Task<DialogTurnResult> PromptStep(
        WaterfallStepContext stepContext,
        CancellationToken cancellationToken)
    {
        return await stepContext.PromptAsync(
            PromptId,
            new PromptOptions
            {
                Prompt = MessageFactory.Text("Please add an image attachment."),
            },
            cancellationToken);
    }

    private async Task<DialogTurnResult> AcknowledgeStep(
        WaterfallStepContext stepContext,
        CancellationToken cancellationToken)
    {
        var attachments = stepContext.Result as IList<Attachment>;
        await stepContext.Context.SendActivityAsync($"Great, that's {attachments.Count} images.");
        return await stepContext.EndDialogAsync(attachments, cancellationToken);
    }

    private async Task<bool> AttachmentValidator(
        PromptValidatorContext<IList<Attachment>> promptContext,
        CancellationToken cancellationToken)
    {
        if (!promptContext.Recognized.Succeeded)
        {
            return false;
        }

        // Perform a couple sample validation steps.

        const string countMsg = "Please attach between 1 and 5 images.";
        if (promptContext.Recognized.Value.Count < 1
            || promptContext.Recognized.Value.Count > 5)
        {
            await promptContext.Context.SendActivityAsync(countMsg, cancellationToken: cancellationToken);
            await promptContext.Context.SendActivityAsync(
                promptContext.Options.RetryPrompt ?? promptContext.Options.Prompt,
                cancellationToken: cancellationToken);
            return false;
        }

        const string typeMsg = "I'm sorry, we only support PNG format at this time.";
        if (promptContext.Recognized.Value.Any(
            attachment => !attachment.ContentType.Equals("image/png", StringComparison.InvariantCultureIgnoreCase)))
        {
            await promptContext.Context.SendActivityAsync(typeMsg, cancellationToken: cancellationToken);
            await promptContext.Context.SendActivityAsync(
                promptContext.Options.RetryPrompt ?? promptContext.Options.Prompt,
                cancellationToken: cancellationToken);
            return false;
        }

        // Perform any additional validation steps.

        return true;
    }

    public async Task OnTurnAsync(
        ITurnContext turnContext,
        CancellationToken cancellationToken = default(CancellationToken))
    {
        if (turnContext.Activity.Type == ActivityTypes.Message)
        {
            var dc = await _dialogs.CreateContextAsync(turnContext, cancellationToken);
            var turnResult = await dc.ContinueDialogAsync(cancellationToken);
            switch (turnResult.Status)
            {
                case DialogTurnStatus.Empty:
                    await dc.BeginDialogAsync(DialogId, null, cancellationToken);
                    break;
                case DialogTurnStatus.Complete:
                    var result = turnResult.Result as IList<Attachment>;
                    await turnContext.SendActivityAsync(
                        $"Thanks, I'll do something with these {result.Count} images",
                        cancellationToken: cancellationToken);
                    // Process the attachments.
                    break;
            }

            await _conversationState.SaveChangesAsync(turnContext, cancellationToken: cancellationToken);
        }
    }
}

Hey Jonathan Thanks so much for answering.
I have been seeing your file and I have tried to find that as a complete example in the git hub documentation. In the image below is the only place where I have found  something related but comparing it to what you shared I can't find them the same or even similar.
Can you share the repository where you have/found that as a Js and c# sample?
Thanks in advance.

No problem. However, the code isn't in a repo at the moment. I can recommend that a scenario like this should be included in the samples repo, or you could open an issue there to request one.

Did you design that sample by yourself? What you just shared?
Yeah I agree. Microsoft owes that to the community. I have looking for it since one month.

When I have some spare time outside of work, I'll post that sample to a public repo. In the mean time, I'll petition for a similar sample into the official samples repo.
Closing for now. Feel free to reopen the issue if you still have questions about this.


[FEATURE] filter unapproved for the transfer approval history API

Is your feature request related to a problem? Please describe.
filter unapproved for the transfer approval history API
Describe the solution you'd like
Add filter item.

status: unapproved, approved, transferred, canceled
from_address
to_address
is_issuer_cancelable: add item from feature/#246

Implemented(branched from feature/#246)
https://github.com/BoostryJP/ibet-Prime/tree/feature/%23248

And add GET: /share/transfer_approvals and GET: /bond/transfer_approvals.

issuer_address: header param
token_address

Sotrable and fillterable to the transfer approval API


🐛 Bug | Visit my blog button does not work

Description
When I click the "visit my blog" button it will open another tab of the same thing I was looking up (check video below to understand what I mean)
I am not sure if this is a bug or I am doing something wrong.. I have tried resting my browser setting, removing extensions, writing fake articles,  but the problem still exist.
https://user-images.githubusercontent.com/83010966/117240451-ba276180-ae28-11eb-97db-8c5894ec3bec.mp4
Device

OS: Linux Ubuntu
Browser: Brave/ Firefox too
Version: both latest version

Hey, you did nothing wrong, it's related to a blockstack issue. Sorry for the inconvenience, you can subscribe to this thread to see the progress https://github.com/blockstack/stacks.js/issues/1016. Really hope it can be solved soon! Will keep you updated here once it's solved.


Native video 🎁

This integrates a native video player and fixes several bugs:

android video rotation and fullscreening
quirks from the web player
Fixes #311 music should stop when playing video
Fixes #310 scale video modal to 16:9

@burkeshartsis if you could take over finishing up this PR, that'd be great! The only things left is to confirm/polish on android - I think everything is working correctly but my android shows odd color artifacts on the video, and want to make sure that's not happening on other devices. And maybe a story and a test.
Creator

[ ] Build relevant tests if any apply
[ ] Ensure there are no new warnings
[ ] Upload an animated GIF showcasing the solution (if it applies)
[ ] Set a relevant reviewer

Reviewer

[ ] Run test and make sure all tests pass
[ ] Review function and form on iOS
[ ] Review function and form on Android
[ ] Review function and form on Web
[ ] Review new test logic

This can be put into a holding pattern since the wistia web player is much improved.

@conrad-vanl If we aren't going to merge this can we close it or icebox it. If we do so do we need to open a new PR to address #310?


refactor(FiatConnectQuote): expose fiat account schema allowed values

Description
Title says it all
Other changes
N/A
Tested
unit tests
How others should test
N/A
Related issues
ACT-351
Backwards compatibility
N/A

hey @MuckT since NA is mentioned in how others should test section , we are skipping this PR
Cc: @satish-ravi
thanks


Disable certain parts of ngModelAttrsTemplateManipulator

This might be a bit of an edge-case, but...
It'd be nice if there was a way to disable certain features of ngModelAttrsTemplateManipulator.  The docs have multiple ways of disabling it, but as far as the list of features goes, it's kind of a take-it-all-or-leave-it-all deal.
My particular use case was that I liked all the binding, custom validation, etc. but I needed to disable the addition of the tabindex attribute.  With ngModelAttrs (or just adding it to the DOM I think) I could have overridden the tabindex, but I needed to pull it off the element completely.  I imagine there are other situations in which someone might want some of the magic without all of it.  Perhaps we could pass an object to extras.skipNgModelAttrsManipulator that gives true/false for various feature names, effectively feature-gating the functionality it provides?
By the way, in case anyone's wondering why I couldn't just do tabindex="-1", it was because I was trying to get the focus attribute to work on a custom type where the focus element was not the same as the ng-model element.  Plus, it was using a third-party directive where I couldn't go in and manually add formly-focus="true".  But I found if I put the ng-model on the outer container, the focus would fall-through to the element that should be focused as long as there were no tabindex attributes above it in the DOM.  Although in this case, ng-aria would have added the tabindex as well, so it gets pretty messy.  Ultimately, I just worked around it, but I think it demonstrates a situation where it'd be nice to break down the all-or-nothing.

I really think that you could find another way to accomplish what you're trying to do. Could you create an example of what you're trying to do following these instructions?
Either way, I don't think that we'll be doing anything significant to change the behavior of the ngModelAttrsTemplateManipulator and I'm sure that we can figure out another way to do what you're trying to do. So I'll go ahead and close this issue. Good luck!


[Bug] Missing paragraphs or sectionBreaks fields, or doesn't correspond to the location in dataStream while insert '+' chractor

Before you submit this issue, have you checked the following

[X] Is this really a problem?
[X] I have searched the Github Issues for similar issues, but did not find anything.

Affected packages and versions
0.2.0
Reproduction link
add + in any column:
https://sheetsvitedemo-s2r2--5173--70dbe416.local-credentialless.webcontainer.io
Expected behavior
maybe can accept like + special chracter, or has any feedback in UI
Actual behavior
Missing paragraphs or sectionBreaks fields, or doesn't correspond to the location in dataStream
System information
No response

Duplicate of #2725


Added sum function to tasks/c/easy/sum.c

Description
Created sum function in tasks/c/easy/sum.c
Additional Context

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out my other projects. Just click here to find more. These projects contain real issues that you can help resolve. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


Tweaking partners.md

Removing blank space at EoL
Adding China Mobile

Pull Request Test Coverage Report for Build 7638

0 of 0   changed or added relevant lines in 0 files are covered.
7 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 64.665%

Files with Coverage Reduction
New Missed Lines
%

src/common/scheduler/policy/alternate_policy.go
3
80.29%

src/common/utils/utils.go
4
81.55%

Totals

Change from base Build 7636:
-0.04%

Covered Lines:
11650

Relevant Lines:
18016

💛  - Coveralls


Fix edit of service instances

Fixed #2626

I'm not sure this is the right approach.

Quick workaround is to update line 170 in add-service-instance.component.ts from filter(p => !!p), to filter(p => !!p && !!p.entity.metadata),
The underlying issue is waitForEntity$ returning too quickly. It emits a partial entity (missing metadata) whilst in the store it's entityRequestInfo is marked as fetching. The filter which should block this receives an entityRequestInfo that's not marked as fetching. Somehow the entity and the entityRequestInfo have become out of step. We've hit this issue before and worked around it with another filter. While we can reproduce this easily it might be time to take another look.

@richard-cox It is the right approach:

The underlying issue is waitForEntity$ is returning to quickly...
It wasn't returning to quickly. Initially, we were looking for the requestInfoEntity for serviceInstance identified by a particular guid. That entity already existed (because we previously fetched the service), and the entity was returning immediately.

The fix is, to look for the updateKey (which wasn't set initially on the action). Once the update is done, then we can proceed with the rest.

Apologies, I got my issues muddled. Please disregard my comment above


make the CRD yaml vendor-able

Signed-off-by: Evan Baker<EMAIL_ADDRESS>
Reason for Change:
We want to include the NodeNetworkConfig CRD in a dependent project - this change allows go mod to include the manifests directory when we go mod vendor so that we can use it as the canonical source for the CRD installation.

Issue Fixed:

Requirements:

[x] uses conventional commit messages

[x] includes documentation

/azp run

/azp run


Bugfix: Reversed gripper joint states

Description
In a recent update to the kinematics driver file, all reversed joint states for the joint_state_publisher for the Blue arm were fixed except for the gripper joint.
This patch fixes that bug.
Expected behaviour
When the gripper is manually closed, the joint state and robot model in RViz should reflect the change. Likewise when it is open.
Observed behaviour
When the gripper is manually closed, RViz shows that the gripper is actually opening way past its joint limits. This is due to a missing negative sign for the gripper joint state reporter as defined in the kinematics library.

Sorry, I targeted the wrong branch, will send a corrected PR.


Build wheel use my own ffmpeg, but can't find the av.libs path.

# here is my building steps

PYAV_LIBRARY=/path/my/ffmpeg/ source scripts/activate.sh
./scripts/build-dep
python3 setup.py bdist_wheel

the I get the diff between mybuildav.wheel and the av.8.0.3.wheel
normal av.8.0.3 wheel file

here is my wheel.

the wheel file I built miss av.libs path. I wanna know why the wheel file I built miss the av.libs and how to fix it.

I don't think anyone in the world knows how to build av 8.x.x anymore.


Jesse: Blacklist guiadoinvestidor.com.br

Jesse requests the blacklist of the website guiadoinvestidor\.com\.br. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

guiadoinvestidor\.com\.br has been seen in 5 true positives, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


userLocationLabel values are not unwrapped

Hey Aaron,
I was just testing out the app and I noticed that the user locations were being shown as optional values. I'm not sure if this was done intentionally, but It's on line 163 of the ViewController.swift file.
self.userLocationLabel.text = "\(locality!), \(administrativeArea!)"

Cheers,
Richard

@Mav3r1ck
It seems like this issue still persists. This is the code:
let locality = (containsPlacemark.locality != nil) ? containsPlacemark.locality : ""
let administrativeArea = (containsPlacemark.administrativeArea != nil) ? containsPlacemark.administrativeArea : ""

Changing it to the below resolves the issue with 'Optional("City"), Optional("State")' being displayed to the user.
let locality = (containsPlacemark.locality != nil) ? containsPlacemark.locality! : ""
let administrativeArea = (containsPlacemark.administrativeArea != nil) ? containsPlacemark.administrativeArea! : ""

I'd be happy to open a PR for this change.


Support for non-file editors

Add support for editor with non-VF files.

Original issue reported on code.google.com by igor.spasic on 19 Dec 2007 at 11:20

I still don't know how.


kitchen-docker fails when testing multiple platforms

my .kitchen.yml has the following platform config that fails when using kitchen-docker:
platforms:
  - name: ubuntu-16.04
  - name: ubuntu-17.10
  - name: ubuntu-18.04

what seems to be happening is its leaves the first container running, bound to port 22 on the docker host, so 17.10 and 18.04 fail when they get to the "start ssd" step, since they can't bind to the same port.
I suspect for this to work properly kitchen-docker should stop trying to bind to the host system on 22 and instead just use the container IP address directly. and it's also probably a good idea to stop a working container when a kitchen run is complete anyway.

looking at what happens when I kill off the conflicting container, and just try to run ubuntu-17.10 by itself, and I get the following ssh errors starting up, so there may also be issues with how it's trying to start the docker images:
$ kitchen converge
-----> Starting Kitchen (v1.22.0)
-----> Creating <default-ubuntu-1710>...
       Error: No public port '22/tcp' published for dd493f425bba0d43d51d4631d5fdade71f5980cdcc7bdb64c558cdf160d11a4a
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: 1 actions failed.
>>>>>>     Create failed on instance <default-ubuntu-1710>.  Please see .kitchen/logs/default-ubuntu-1710.log for more details
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration
$ docker ps -a
CONTAINER ID        IMAGE               COMMAND                  CREATED             STATUS                        PORTS               NAMES
dd493f425bba        398e1cab7701        "/usr/sbin/sshd -D -…"   25 seconds ago      Exited (255) 23 seconds ago                       defaultubuntu1710-tessa-viper-s73i3mrz
$ docker logs dd49
command-line line 0: Deprecated option UsePrivilegeSeparation
Missing privilege separation directory: /run/sshd

Ahhh it looks like the workaround in #285 solves this, so this is just a duplicate. hopefully that fix will make it into a deployable gem soon.


Remove phone number validation on the client side

See #812
@ashwinraghav is this the intended behavior? The libphonenumber call is only made for SmartLock hints but not for manually entered phone numbers.

cc: @isaisachen

;tldr
It was intentional, but the wrong decision in hindsight.
Here was how we thought of this:

Smartlock hints needed it (at the time) since the phone number formats returned were not in the E164 format. We started using telephony's normalization (assuming it would somehow be updated regularly enough since libPhoneNumber that backs it changes every week).
We piggybacked on the phone number normalization for manually entered phone numbers to save on service calls for fat-fingered phone numbers.

To state the obvious, both 1 and 2 are yielding false negatives since the lib is not updated as often as we would like. I would be ok getting rid of this validation for both 1 and 2 or just 2.

LGTM


"Assertion failed" when adding type definition

Hi!
I ran into some strange behaviour earlier today. Given the following type definition:
type segment = {
  key: string,
  title: string,
  component: React.element,
};

And the following component:
<EMAIL_ADDRESS> let make = (segments) => {
      segments
      ->Belt.Array.map(segment => {
          <p key={segment.key}> segment.title->React.string </p>
        })
      ->React.array
};

When I change:
 let make = (segments) => {

to
 let make = (segments: array(segment)) => {

I get the following error:
Fatal error: exception File "typecore.ml", line 2799, characters 6-12: Assertion failed

Version: BuckleScript 7.3.2 ( Using OCaml:4.06.1+BS )

Actually;
When I change it to a named parameter, it compiles;
 let make = (~segments: array(segment)) => {

I suspect this has something to do with the<EMAIL_ADDRESS>decorator expecting named parameters. As when I remove that and the ~, it compiles as well.
The error message isn't particularly clear though.


Rework of the introduction

Adds a rework of the introduction to describe the two key properties enabled by the core scheme, includes a simple asci art diagram to describe how the key operations are used and by who

Multiple approvals, purely editorial, merging


Security Vulnerabilities?

Just found this article about a security vilnerability in jQuery. It relies on exploiting object merge operations to manipulate the Object prototype.
https://snyk.io/vuln/SNYK-JS-JQUERY-174006
Since this lib provides similar functionality, we should probably audit the code for any potential vulnerabilities.
Notes

References

Yep, we do have that structure. Though, it would appear to be less damaging as both objects are being merged onto a new object so it couldn't effect the input objects upstream. I will test what is possible this Friday.

After a review, it would seem we are secure. Because when we set properties using previous objects, we have used Object.keys to grab any property names. and we never grab the redefined proto property to set on the new object.
We would have to be careful of this depending on the implementation of functions using inherited properties to create new objects, but unless I missed something, the current implementation should not have this issue.
We effectively use the prevention of using an object with the default prototype and not copying or characteristics of the source objects prototypes.

Also just made this to visualize part of the problem
const obj1 = { left: 22 };
const func1 = () => 'Howdy';
Object.defineProperty(obj1, 'toString', {
  value: func1,
  enumerable: true
});
const obj2 = { __proto__: obj1, up: 57 }; /// Don't allow __proto__ to be merged to new object

 // ***Possible Issue To avoid***
console.log(Object.prototype.toString())
// [object Object]
console.log(obj2.toString())
// 'Howdy'

// ***Property key we use***
console.log(Object.keys(obj1))
// [ 'left', 'toString' ]

console.log([...Object.keys(obj2), ...Object.getOwnPropertyNames(Object.getPrototypeOf(obj2))])
// ***All Defined***
// [ 'up', 'left', 'toString' ]

console.log([...Object.keys(obj2), ...Object.keys(obj1), ...Object.getOwnPropertyNames(Object.getPrototypeOf(obj1))])
// ***All runnable***
/* [ 'up', 'left', 'toString',
  'constructor',
  '__defineGetter__',
  '__defineSetter__',
  'hasOwnProperty',
  '__lookupGetter__',
  '__lookupSetter__',
  'isPrototypeOf',
  'propertyIsEnumerable',
  'toString',
  'valueOf',
  '__proto__',
  'toLocaleString' ]
*/

I was thinking of something more like this. Although, it doesn't mutate the proto.
If objects.merge worked recursively to merge both own properties and proto properties, that would be a concern. _.set was another operator mentioned in the report. We skipped that altogether.
On second thought, none of our operators mutate the input. Isn't that kind of the point?

Assuming there is some leak that we haven't considered, we could always add an input check to verify that none of the inputs are the Object prototype
if (input.isPrototypeOf(Object)) { throw Error('The Object prototype is not a valid input'); }

Well, this lib doesn't suffer from any security vulnerabilities but some deeply nested dependencies did. The reason the bot patch didn't fix it was due to one specific deeply nested dependency of ESLint. I almost had to patch ESLint to fix it but fortunately the dep with the issue published a fix.
Gonna close this for now unless you can think of an other potential security vulnerability vectors.


WARN: RefreshScope uses convention-based annotation attribute  overrides

Describe the bug

Spring Cloud 4.0.0 M4
Spring Boot 3.0.0-M5
Spring 6.0.0-M6

WARN [org.springframework.core.annotation.AnnotationTypeMapping] - <Support for convention-based annotation attribute
overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the 'proxyMode' attribute in
@org.springframework.cloud.context.config.annotation.RefreshScope with an appropriate @AliasFor declaration -- for example,
@AliasFor(annotation = org.springframework.context.annotation.Scope.class).>

Guess the relevant issue is here:
https://github.com/spring-projects/spring-framework/issues/28760
I don't know if the suggestion is valid, but I can submit a pull request if you find this to be appropriate.
Thank you.

I don't know if the suggestion is valid

Yes, the suggestion is valid.
We do exactly that for @RequestScope in the core Spring Framework.
https://github.com/spring-projects/spring-framework/blob/6cb131ac7629cfda489d4d2367a36d44ee7b5ed2/spring-web/src/main/java/org/springframework/web/context/annotation/RequestScope.java#L61

Thank you. @spencergibb would you be OK with a pull request to remove the warning?

PR would be welcome @mmoayyed


TimeInterval -> NSTimeInterval

NSTimeInterval is already in use in some places from @modocache's async testing work. Now that we have the Foundation dependency, we should take advantage of it and use NSTimeInterval consistently instead of re-declaring our own.

@swift-ci please test

Cool.

The OS X check failed due to something in Foundation. I'm planning on taking a hard look at getting OS X CI working once and for all... :fire:
Thanks, @briancroom! :+1:


Documentation error

[Enter feedback here]
In step 4 under "Configure an OAuth 2.0 authorization server in API Management", the AAD authorization URL should use tenant_id instead of client_id

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa82acc4-680a-1431-f4fc-4848e8efe2ce
Version Independent ID: fbf31137-c536-2d90-3a76-bca7cd88cf53
Content: Authorize developer accounts using OAuth 2.0 in Azure API Management
Content Source: articles/api-management/api-management-howto-oauth2.md
Service: api-management
GitHub Login: @mikebudzynski
Microsoft Alias: apimpm

@ningweinw Thanks for catching that! We have worked up a PR to fix this.

@ningweinw We are merging the PR in, which should reflect in a couple of hours.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


🚀 : Latest Completed Profiles Users Section from the App

Is your feature request related to a problem? Please describe.
Users are unable to view the latest completed profiles section from the app, causing them to miss out on valuable updates and information about completed profiles.
Describe the solution you'd like
I would like to see a dedicated section within the app that displays the latest completed profiles. This section should provide users with easy access to view recently completed profiles, allowing them to stay updated on recent activity.
Describe alternatives you've considered
One alternative solution could be to send push notifications to users whenever a profile is completed. However, this may be intrusive and could lead to notification fatigue for users. Having a dedicated section within the app would provide users with more control over when they view updates about completed profiles.
Additional context
Adding a feature like this would enhance the user experience by keeping users informed about the latest activity on the platform. It would also encourage engagement and interaction with completed profiles.
Screenshot

If you want speed up process of this issue, please send 🚀 as a reaction.

@jakebogan01 Do you want to get assigned for this issue, you can feel free to make any design here, it may be slider or a list. It's up to you, if you do, i ll be glad :) Thank you again

@xuelink I don't mind working on this. My only question would be, where and what page would you like this section to be? Any specific details help including screenshots.

@jakebogan01 you can add after features section. sample photos and test users then i can connect it to database realtime no problem

@xuelink Sounds good, I'll get this going this week!

@xuelink I made a PR here


Bug: Saving empty states

In certain rare cases, an empty value is written during a state save.
No reliable repro steps as of yet.
A warning will be added in 7.1

@mickayz , i encountered this issue. i have about 100+ request and three roles. every time when i save the result after running, it will create a 0 byte file. does the result size exceed some limitation?

I believe this has to do with an uncaught exception when generating the output for the state file. My guess is the specific cause is when one of the requests times out, the response is empty and it causes an exception when its dereferenced somewhere. Given you have 100 requests, it seems fairly likely that one of them will have timed out in the last run.
I'm pushing a beta fix to the following branch.  If you have a chance, give it a try and let me know if that fixes the problem.
https://github.com/securityinnovation/authmatrix/tree/7.1beta

Went ahead and merged with master, as I'm pretty sure this is fixed.  Please re-open this issue if you're still seeing the bug.
Thanks for reporting! Sorry if it caused you to lose some work.

tested with new version. it solves the issue like a magic. Thanks!


Do not populate mobile number in the directory

"If users don't want their mobile phone number to be visible in the directory, but they still want to use it for password reset, administrators should not populate it in the directory."
Where is this set? A link within that statement to show how and where should help.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18640c6c-b52c-84e3-59d8-90f2a663cc6b
Version Independent ID: 77b249dc-4440-0334-31d7-b05d30f52657
Content: Self-service password reset how it works - Azure Active Directory | Microsoft Docs
Content Source: articles/active-directory/active-directory-passwords-how-it-works.md
Service: active-directory
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@OneGi Thank you for your feedback! We will investigate and take necessary course of action.

Issue Summary
In looking through this section: https://docs.microsoft.com/en-us/azure/active-directory/active-directory-passwords-how-it-works#what-fields-are-used-in-the-directory-for-the-authentication-data
The end user is to NOT populate the Mobile Phone field but instead, follow this link to the Password Reset Registration Portal, to populate the Authentication Phone field with their mobile number.

Perhaps this could be explained during the registration process, or elsewhere as being requested.

The page does explain that the user sets the Authentication Phone value in the password reset portal (not the admin). The admin doesn't set this, they can just see it (privately) in the user's profile. @OneGi, I'm not sure what you're asking for?

It says "administrators should not populate it in the directory".
It seems to say that it is instructing the administrator NOT to do a configuration setting, hence the question on where is this actually set (or NOT set at all).
The other task needs to be done is for the USERS to populate their Authentication Phone. This part is clear. It is the administrator portion (to NOT populate in directory) that seems to be a task to be done ensure an outcome.

#in-process

@OneGi we've opened an item on our internal backlog to address this issue. We'll let you know when it's done by commented on this issue again. Thanks for your feedback.
#please-close

@OneGi
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


[PE-D][Tester C] findtask only checks tasks that are not done

The KEYWORD in findtask only matches against tasks that are 'not done' and doesn't check marked tasks. If this is its intended functionality then it should be mentioned in the UG.

Labels: severity.Medium type.FeatureFlaw
original: VatsalVitosh/ped#4

#142

Resolved.

Resolved


fix words in docs

this really good fix :D

LGTM

Oops, that's right. :pencil2: :mag: :male_detective: Thanks for your contribution @prostomarkeloff ! :tada: :cake:
And thanks @alimcmaster1 for the review!


[quesion] Does it work with Windows built-in BLE

or an external Bluetooth 4.0 USB adapter is needed?

It should work with any Bluetooth adapter that is supported by the Windows 10 Bluetooth stack, including built-in adapters.

Thanks!


checks.py does not support where clause filter of deequ

from pydeequ.checks import *
from pydeequ.verification import *
check = Check(spark, CheckLevel.Warning, "Review Check")
checkResult = VerificationSuite(spark)
.onData(df)
.addCheck(
check.hasCompleteness('b',lambda x: x >= .5).where("b is not NULL")
deequ support where clause pydeequ have not added the suppport for where clause

where function can be added to checks.py which will call to the actual where function  at line https://github.com/awslabs/deequ/blob/master/src/main/scala/com/amazon/deequ/checks/CheckWithLastConstraintFilterable.scala#L35


Command links in notebook output not working

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.63-insider
OS Version: Edge on Windows (vscode.dev)

Steps to Reproduce:

Open a github issues notebook
Don't sign in and run a relatively complex query, get the message about needing to sign in due to the api rate limit
🐛 clicking on the link to sign in does nothing

fyi @jrieken since this impacts the getting started experience with GitHub Issues notebooks--could the extension request authentication with createIfNone when we hit this case?

could the extension request authentication with createIfNone when we hit this case?

I believe the extension cannot know that we hit this case. I believe it's a bug that command links don't work, waiting for @rebornix to confirm tho

@rebornix  Was this fixed by your commit? Should we only enable command links in trusted workspaces?


Generate in Other Languages

Hi,
I understand that VALL-E (or VALL-E) needs a lot of data to train. If used to generate audio in a minority language, is it required to train with a huge collection of datasets in that language, or could we build a model based on an existing one with a small dataset in the target language?
Minority languages might have less than 10 hours of datasets.
Thanks.

It will probably work, but likely will be pretty bad at imitating voices unseen speakers, since 10 hours likely don't have a huge variety of speakers in it

Could we build based on existing model with small dataset in a new language, or is it required to train with large dataset in the new language?

It might work with finetuning. I am currently training a Model using Apache commonvoice, it might even be able to synthesize a language it doesn't know when it's done, however there are issues in combination with non-latin letters right now: https://github.com/lifeiteng/vall-e/issues/110


Fix performance regression (#977)

I made the faulty assumption that we always called mutateElement() from within a React event handler (which is wrapped in batchedUpdates()). This isn't true -- we add and remove regular listeners from the window also. I wrapped all the event handlers in unstable_batchedUpdates() which fixed the performance issue.

@dwelle this should fix the issue. sorry about that. i had previously tested with a few tens of elements and didn't notice the perf issue. i was able to load your large doc and observe the perf issue fixed in this (as well as ran my normal test plan)

Another option is we could add the batching to the globalAppState, but it does break tests / will delay some updates by one tick, so I went with this approach instead.

Looks like you beat me to it!

syncActionResult needs to be batched as the two setState are triggering two renders
https://github.com/excalidraw/excalidraw/blob/e9f5175f51d2cf7d06117789f9a183802194439f/src/components/App.tsx#L197;L207

Yeah, the three updates on page load are all coming from this syncActionResult function

https://github.com/excalidraw/excalidraw/pull/986 fixes it


Date is ambiguous in Update Manager

From @dlavigne on August 11, 2016 17:53
See attached screenshot for an example. Depending upon where you live in the world, the last check either occurred on Aug 11 or Nov 8. Specifically stating the month name would make this clear.

Copied from original issue: trueos/trueos-utils-qt5#4

Fixed!
I just changed it from the short date format to the long date format for the users current locale.


Anyone install this on a windows machine?

The yaml install didn't work for me so I tried via the requirements.txt. Had to install cuDNN, and made some progress on their errors that I received, but then ran into the trying to install this dependency: pip install nvidia-nccl-cu11. Anyone else get it to run locally? I am on windows creating a conda env.

I have it running on Windows, without conda.

full scripts released including Auto DensePose maker
https://github.com/magic-research/magic-animate/issues/44

There is an issue with installing on Windows, you can view this video：
https://www.bilibili.com/video/BV1ig4y1f7BQ/?share_source=copy_web&vd_source=842db193ae3e8fc29019a57821e30000


fix: remove use of assert module

I'm trying to remove use of the node assert module from our stack as it's causing problems - the polyfill is big, we can simulate it by throwing an Error and it doesn't work under React Native.

Codecov Report

Merging #65 into master will decrease coverage by 1.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   83.88%   82.78%   -1.10%
==========================================
  Files           8        8
  Lines         484      488       +4
==========================================
- Hits          406      404       -2
- Misses         78       84       +6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978444d...c62dd97. Read the comment docs.

Codecov Report

Merging #65 into master will decrease coverage by 1.09%.
The diff coverage is 41.66%.

@@            Coverage Diff            @@
##           master      #65     +/-   ##
=========================================
- Coverage   83.88%   82.78%   -1.1%
=========================================
  Files           8        8
  Lines         484      488      +4
=========================================
- Hits          406      404      -2
- Misses         78       84      +6

Impacted Files
Coverage Δ

src/pubsub.js
86.53% <37.5%> (-2.36%)
:arrow_down:

src/index.js
80.46% <50%> (-0.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978444d...c62dd97. Read the comment docs.


incoming call

Can anybody help me in making the incoming call whatsapp like? Similar to Callkit integration  with iOS

hi @dixit111 for calling please refer to the demos here.
https://github.com/AgoraIO/Advanced-Video/tree/master/Calling-Interface

thank you...

https://github.com/AgoraIO/Advanced-Video/tree/master/Calling-Interface
404

@c941010623 it's moved here https://github.com/AgoraIO-usecase/video-calling

Hi @plutoless
https://github.com/AgoraIO-usecase/video-calling
This is not working while app is in background or phone is locked.
Can you tell me how can i achieve calling trigger while app is in background or phone is locked?

you will need to implement push notifications. for android you can also implement foreground service

push notification are working when app is in background or foreground but not working when phone is locked. I have also tried setFullScreenIntent() but not much helpful.
I want to bypass the lock screen and show calling page. Any comment on this ?
And also version Android 10 and above we can't open page from background by push notification.
For Foreground service, can you tell me a way how can i use this ?

what do you mean by push notification is not working when phone is locked? you will be able to receive push notification even when phone is locked. For foreground service please look at https://developer.android.com/guide/components/services

@plutoless I am facing error in kotlin version in latest builds

what kind of error? @Saim-Hashmi
any details or a screenshot?


ESPHome-LibreTuya PWM

Can and how can I use PWM control for the cb2s and others chip?
For esp8266 it is:

platform: esp8266_pwm

How to do it in LibreTuya's ESPHome port?

Use LEDC, just like on ESP32. Most stuff in ESPHome LibreTuya is used like on ESP32.

Oh yes, I forgot that these processors should be treated similarly to esp32 😅 Thank you for the tip.  Thanks to 'Tuya CloudCutter', 'LibreTuya' and the port to ESPHome my RGBCCT bulbs, Aubess switches and other accessories already work stably on ESPHome in HA.  Great, great project 👍 I hope it will continue to be developed.

It will indeed!


The futex facility returned an unexpected error code in Ubuntu

Please verify these steps before filing an issue, and check them off as you go

[ x ] The relevant native JavascriptEngineSwitcher library packages are installed (such as JavaScriptEngineSwitcher.V8.Native.win-x64)
[ N/A ] The VC++ 2017 runtime is installed
[ x ] The value of SetUseReact and SetUseBabel is correct in ReactConfig.cs or Startup.cs
[ x ] I've looked at the sample projects in this repo to verify that my app is configured correctly

I'm using these library versions:

ReactJS.NET: 5.2.12
JavaScriptEngineSwitcher: 3.1.8
react and react-dom: (N/A if using bundled react, or version number)
webpack: (N/A if using bundled react)
node: (N/A if using bundled react)

Runtime environment:

OS: (Mac, Windows, Linux flavor. Include 32-bit/64-bit and version) Ubuntu 21.10 64-bit
.NET Framework or .NET Core Version: 3.1.416

Steps to reproduce
dotnet new reactnet-vanilla
dotnet run

Run the template project directly without any changes, then browse it in browser, it will have the error in console with This site can’t be reached error in browser.

Hi, found it can be resolved by switch to V8 engine. Thanks.
//services.AddJsEngineSwitcher(options => options.DefaultEngineName = ChakraCoreJsEngine.EngineName)
//	.AddChakraCore();

services.AddJsEngineSwitcher(options => options.DefaultEngineName = V8JsEngine.EngineName)
	.AddV8();


[BUG] Google id avatar not working

Description
When we sign in the Gmail accounts' avatar doesn't show up
Screenshots

Yeah, that a bug from firebase itself, don't know why but sometimes it just doesn't work


Reflect new games page URL

yea but like it redirects anyway

i must reject your attempt to get the pull shark badge.


Portainer agent unable to join cluster

Bug description
Using the official portainer-agent-stack.yml I tried to deploy a portainer to a simple Docker swarm which consists of three nodes that are all manager nodes. But the agents do not seem to be able to form a cluster. That leads to portainer always connecting to a random instance of the agent and just showing that nodes containers etc.
Here are the logs of one of the agent instances:
2019/01/04 07:37:38 [DEBUG] - Agent details: map[NodeName:mac-mini-server Mode:swarm NodeRole:manager AgentPort:9001]
2019/01/04 07:37:38 [DEBUG] - Using cluster address: tasks.agent
2019/01/04 07:37:38 [DEBUG] - Using advertiseAddr: <IP_ADDRESS>
2019/01/04 07:37:38 [DEBUG] - Generating TLS files...
2019/01/04 07:37:39 [DEBUG] - Using agent port: 9001
2019/01/04 07:37:42 [DEBUG] - Serf configured with AdvertiseAddr: <IP_ADDRESS>
2019/01/04 07:37:42 [INFO] serf: EventMemberJoin: f6fa7b95b90f <IP_ADDRESS>
2019/01/04 07:37:42 [DEBUG] - Will join cluster via: tasks.agent
2019/01/04 07:37:42 [DEBUG] - Couldn't join cluster, starting own: 2 errors occurred:
	* Failed to join <IP_ADDRESS>: dial tcp <IP_ADDRESS>:7946: connect: connection refused
	* Failed to join <IP_ADDRESS>: dial tcp <IP_ADDRESS>:7946: connect: connection refused

All instances are showing the same error messages. The IP <IP_ADDRESS> seems to belong to the host us1.utm2d.sophos.com which might have something to do with our corporate firewall which is a sophos system.
Expected behavior
I expected the portainer agents to be able to form a cluster and portainer to show the containers of all nodes.
Steps to reproduce the issue:
Sadly I was not able to find out the factors needed to reproduce this behavior. All I can say is, that it in some random cases it just seems to work but in most cases it doesn't.
Technical details:

Portainer version: 1.20.0
Docker version (managed by Portainer): 18.09.0
Platform (windows/linux): linux
Command used to start Portainer: docker stack deploy --compose-file=portainer-agent-stack.yml portainer
Browser: -

Thanks @dbellingroth and @deviantony  for the conversation.
I am facing similar situation.
In my setup, Weave was used instead of overlay network for inter-connecting portainer containers, here is my deploy configuration. The last alpine is used for debugging network problem.
version: '3.5'

services:
  agent:
    image: portainer/agent
    environment:
      # REQUIRED: Should be equal to the service name prefixed by "tasks." when
      # deployed inside an overlay network
      AGENT_CLUSTER_ADDR: tasks.agent
      # AGENT_PORT: 9001
      # LOG_LEVEL: debug
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - /var/lib/docker/volumes:/var/lib/docker/volumes
    networks:
      - portainer-net
    deploy:
      mode: global
      placement:
        constraints: [node.platform.os == linux]
  portainer:
    image: portainer/portainer
    command: -H tcp://tasks.agent.portainer-net:9001 --tlsskipverify
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - portainer_data:/data
    networks:
      - portainer-net
    ports:
      - target: 9000
        published: 9000
        protocol: tcp
        mode: host
    deploy:
      mode: replicated
      replicas: 1
      placement:
        constraints: [node.role == manager]
  alpine:
    image: alpine:3.8
    command: tail -f /dev/null
    networks:
      - portainer-net
    deploy:
      mode: global

networks:
  portainer-net:
   attachable: true
   driver: weaveworks/net-plugin:latest_release
   name: portainer-net

volumes:
  portainer_data:

There are 2 manager node in the Swarm cluster, and only one agent will be connected by the portainer instance, the symptom is similar to the beginning of this issue. From the log of agents, only local bridged address(172.18.0.x) of agents were shown in EventMemberJoin lines, where 062f6478a025 is the local instance of agent and bde2a6930b29  is the remote instance of agent. The expected address are 10.0.0.x from Weave.
# docker logs 062f6478a025
2019/03/15 03:31:45 [INFO] serf: EventMemberJoin: 062f6478a025 <IP_ADDRESS>
2019/03/15 03:31:45 [INFO] serf: EventMemberJoin: bde2a6930b29 <IP_ADDRESS>
2019/03/15 03:31:45 [INFO] - Starting Portainer agent version 1.2.1 on <IP_ADDRESS>:9001 (cluster mode: true)
2019/03/15 03:31:57 [INFO] memberlist: Suspect bde2a6930b29 has failed, no acks received
2019/03/15 03:32:02 [INFO] memberlist: Marking bde2a6930b29 as failed, suspect timeout reached (0 peer confirmations)
2019/03/15 03:32:02 [INFO] serf: EventMemberFailed: bde2a6930b29 <IP_ADDRESS>
2019/03/15 03:32:08 [INFO] memberlist: Suspect bde2a6930b29 has failed, no acks received
2019/03/15 03:32:15 [INFO] serf: attempting reconnect to bde2a6930b29 <IP_ADDRESS>:7946
2019/03/15 03:32:55 [INFO] serf: attempting reconnect to bde2a6930b29 <IP_ADDRESS>:7946
2019/03/15 03:33:35 [INFO] serf: attempting reconnect to bde2a6930b29 <IP_ADDRESS>:7946
2019/03/15 03:34:15 [INFO] serf: attempting reconnect to bde2a6930b29 <IP_ADDRESS>:7946

To check if it is a problem related to DNS, I deployed a alpine services to do the nslookup in the stack, and I wonder if tasks.agent will be resolved to the locally bridged address instead of the Weave's one.
# docker exec -ti 93bab58d4f19 sh
/ # ip addr
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
570: ethwe0@if571: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1376 qdisc noqueue state UP
    link/ether 0a:65:68:b8:68:89 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global ethwe0
       valid_lft forever preferred_lft forever
572: eth0@if573: <BROADCAST,MULTICAST,UP,LOWER_UP,M-DOWN> mtu 1500 qdisc noqueue state UP
    link/ether 02:42:ac:12:00:02 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global eth0
       valid_lft forever preferred_lft forever
/ # nslookup tasks.agent
nslookup: can't resolve '(null)': Name does not resolve

Name:      tasks.agent
Address 1: <IP_ADDRESS> portainer_agent.ctrzy9txo4te8ie0f7iout7tw.mm0cbmtwnajfy4d1m6dq8atjh.portainer-net
Address 2: <IP_ADDRESS> portainer_agent.liitbwgf19azkq24svgfwuyp1.q89gw551ljqyuuvminzuubxea.portainer-net
/ # ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=64 time=29.040 ms
64 bytes from <IP_ADDRESS>: seq=1 ttl=64 time=13.504 ms
64 bytes from <IP_ADDRESS>: seq=2 ttl=64 time=13.542 ms
^C
--- <IP_ADDRESS> ping statistics ---
3 packets transmitted, 3 packets received, 0% packet loss
round-trip min/avg/max = 13.504/18.695/29.040 ms
/ # ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: seq=0 ttl=64 time=0.294 ms
64 bytes from <IP_ADDRESS>: seq=1 ttl=64 time=0.251 ms
^C
--- <IP_ADDRESS> ping statistics ---
2 packets transmitted, 2 packets received, 0% packet loss
round-trip min/avg/max = 0.251/0.272/0.294 ms

It seems that tasks.agent was resolved to addresses in portainer-net as expected, let's see what if I explicitly specify portainer-net in the DNS name
/ # nslookup tasks.agent.portainer-net
nslookup: can't resolve '(null)': Name does not resolve

Name:      tasks.agent.portainer-net
Address 1: <IP_ADDRESS> portainer_agent.liitbwgf19azkq24svgfwuyp1.q89gw551ljqyuuvminzuubxea.portainer-net
Address 2: <IP_ADDRESS> portainer_agent.ctrzy9txo4te8ie0f7iout7tw.mm0cbmtwnajfy4d1m6dq8atjh.portainer-net

So I changed the AGENT_CLUSTER_ADDR: tasks.agent to AGENT_CLUSTER_ADDR: tasks.agent.portainer-net in the configuration of agents. But the agent instances still resolving 172.18.0.x as member addresses, same as shown on the above.
Since the agent is not open-sourced, could I ask how will the environment variable AGENT_CLUSTER_ADDR be used in the agent? If it is taking the value of AGENT_CLUSTER_ADDR as a DNS name to resolve a list of IP address, or the agent agent will use Docker API to obtain member's IP address?
Technical details:

Portainer version: 1.20.2
Target Docker version (the host/cluster you manage): 18.09.3
Platform (windows/linux): Linux, Ubuntu 16.04 + HWE Kernel 4.15.0-46
Command used to start Portainer (docker run -p 9000:9000 portainer/portainer): docker stack deploy
CNI: Weave 2.5.1 (v2 plugin)

@kennylam777
A few things have changed:
we recently open source the agent if you need more details about the usage of the AGENT_CLUSTER_ADDR option.
We also updated the agent recently with more logging when starting the agent with the env var LOG_LEVEL set to debug.
Finally, we're now issuing a nslookup on the value of AGENT_CLUSTER_ADDR when the agent starts to retrieve a list of containers that the agent can use to create/join a cluster.


[Kafka]External metrics server not reporting the correct value to scale up

A clear and concise description of what the bug is.
Expected Behavior
I have defined- lagThreshold: "10".
`apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
name: kafka-scaledobject
namespace: kafka
labels:
deploymentName: kafka-consumer-deployment # Required Name of the deployment we want to scale.
spec:
scaleTargetRef:
name: kafka-ap
pollingInterval: 5
minReplicaCount: 1   #Optional Default 0
maxReplicaCount: 3  #Optional Default 100
triggers:

type: kafka
metadata:
bootstrapServers: <IP_ADDRESS>:9092
consumerGroup: order-shipper
topic: preorder
lagThreshold: "10"`

I have pushed around "33" messages, which caused a lag of "33". With the lag as "33" or any value above "10" on the Kafka consumer group. It should scale up the Pods.
`sh-4.4$ ./kafka-consumer-groups.sh --bootstrap-server localhost:9092 --describe --group order-shipper
GROUP           TOPIC           PARTITION  CURRENT-OFFSET  LOG-END-OFFSET  LAG             CONSUMER-ID                                             HOST            CLIENT-ID
order-shipper   preorder        0          55              88              33              kafka-python-2.0.2-cc83bb42-afe7-4f34-b37b-d944859356b6 /<IP_ADDRESS> kafka-python-2.0.2
sh-4.4$`
API request: "/apis/external.metrics.k8s.io/v1beta1/namespaces/kafka/s0-kafka-preorder" doesn't report value more than "10"

{"kind":"ExternalMetricValueList","apiVersion":"external.metrics.k8s.io/v1beta1","metadata":{},"items":[{"metricName":"s0-kafka-preorder","metricLabels":null,"timestamp":"2022-08-25T22:59:38Z","value":"10"}]}

In the above it should be
{"kind":"ExternalMetricValueList","apiVersion":"external.metrics.k8s.io/v1beta1","metadata":{},"items":[{"metricName":"s0-kafka-preorder","metricLabels":null,"timestamp":"2022-08-25T22:59:38Z","value":"33"}]}
ScaledObject:
arjunpandey$ kubectl get scaledobject -nkafka
NAME                 SCALETARGETKIND      SCALETARGETNAME   MIN   MAX   TRIGGERS   AUTHENTICATION   READY   ACTIVE   FALLBACK   AGE
kafka-scaledobject   apps/v1.Deployment   kafka-ap          1     3     kafka                       True    True     False      27m

HPA
`arjunpandey$ kubectl describe hpa -nkafka
Name:                                          keda-hpa-kafka-scaledobject
Namespace:                                     kafka
Labels:                                        app.kubernetes.io/managed-by=keda-operator
app.kubernetes.io/name=keda-hpa-kafka-scaledobject
app.kubernetes.io/part-of=kafka-scaledobject
app.kubernetes.io/version=2.7.1
deploymentName=kafka-consumer-deployment
scaledobject.keda.sh/name=kafka-scaledobject
Annotations:
CreationTimestamp:                             Fri, 26 Aug 2022 07:32:51 +0900
Reference:                                     Deployment/kafka-ap
Metrics:                                       ( current / target )
"s0-kafka-preorder" (target average value):  10 / 10
Min replicas:                                  1
Max replicas:                                  3
Deployment pods:                               1 current / 1 desired
Conditions:
Type            Status  Reason              Message
.----            ------  ------              -------
AbleToScale     True    ReadyForNewScale    recommended size matches current size
ScalingActive   True    ValidMetricFound    the HPA was able to successfully calculate a replica count from external metric s0-kafka-preorder(&LabelSelector{MatchLabels:map[string]string{scaledobject.keda.sh/name: kafka-scaledobject,},MatchExpressions:[]LabelSelectorRequirement{},})
ScalingLimited  False   DesiredWithinRange  the desired count is within the acceptable range
Events:
Type    Reason             Age   From                       Message

Normal  SuccessfulRescale  20m   horizontal-pod-autoscaler  New size: 2; reason: external metric s0-kafka-preorder(&LabelSelector{MatchLabels:map[string]string{scaledobject.keda.sh/name: kafka-scaledobject,},MatchExpressions:[]LabelSelectorRequirement{},}) above target
Normal  SuccessfulRescale  14m   horizontal-pod-autoscaler  New size: 1; reason: All metrics below target
arjunpandey$`
Actual Behavior

In the command-  kubectl describe hpa -nkafka

Metrics:                                       ( current / target )
"s0-kafka-preorder" (target average value):  10 / 10

It should be

Metrics:                                       ( current / target )
"s0-kafka-preorder" (target average value):  33 / 10

The Pod count should have scaled up from 1 to 2.
Steps to Reproduce the Problem
Mentioned in the above comment.
Any help highly appreciated :-)
It works for the scenarios:

lagThreshold: "10" and actual lag 19
lagThreshold: "30" and actual lag 47.

But not for, lagThreshold: "10"  and actual lag > 19 ( In my case I have tested with 23, 33, 47 it didn't work).
I have also test the latest version ( 2.8.1) of Keda but the same problem.
Specifications

KEDA Version: 2.7.2
Platform & Version: eks.5
Kubernetes Version: 1.22
Scaler(s): keda.sh/v1alpha1

Big thanks for developing such a wonderful most awaited product :-)

Any update on this. We had seen something similar metricServer was reporting metric as 1 ?
Looked like the sarama client didn't query all partitions under the hood but just the first one ?

Yes, I'm also getting this issue. Super strange. It seems that the lag threshold I set is just multiplied by the max number of replicas. Then I have my pods scaling up and down constantly. Very odd behaviour and a bit difficult to debug.

When I query the metric server and the metric I get a value that is equal to the multiplication of the threshold by the amount of replicas?

Changing to the apache-kafka scalar seems to have solved this. Although I'm a bit worried about using the experimental scaler in production

Just mentioning here when I set allowIdleConsumers to true in the kafka trigger the metrics are the same as the lag. Still not quite sure if the other behaviour is expected. Maybe there is a logic error happening somewhere, or I'm misunderstanding something in the implementation


Automated cherry pick of #4488: scheduler schedule according to quota limit

Cherry pick of #4488 on release/2.14.
#4488: scheduler schedule according to quota limit

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.14@3cb4283). Click here to learn what that means.
The diff coverage is 1.11%.

@@              Coverage Diff               @@
##             release/2.14   #4490   +/-   ##
==============================================
  Coverage                ?   6.84%
==============================================
  Files                   ?     522
  Lines                   ?   88754
  Branches                ?       0
==============================================
  Hits                    ?    6076
  Misses                  ?   82171
  Partials                ?     507

Flag
Coverage Δ

#aFlag
6.84% <1.11%> (?)

Impacted Files
Coverage Δ

pkg/compute/models/guestnetworks.go
0.21% <ø> (ø)

pkg/compute/models/projectquota.go
25% <0%> (ø)

pkg/cloudcommon/db/modelbase.go
1.42% <0%> (ø)

pkg/compute/models/quotas.go
7.41% <0%> (ø)

pkg/compute/models/regionquota.go
8.09% <0%> (ø)

pkg/compute/models/networks.go
0.54% <0%> (ø)

pkg/cloudcommon/db/quotas/context.go
0% <0%> (ø)

pkg/compute/models/cloudaccounts.go
0.86% <0%> (ø)

pkg/compute/models/guest_actions.go
0% <0%> (ø)

pkg/compute/models/guests.go
0.56% <0%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb4283...cac2e4a. Read the comment docs.


[Feature Request] Hanukkah Embed

While Hannukah is ongoing, when this command is invoked the bot should respond with an ASCII (or emoji) menorah depicting where we are in the holiday.
If the holiday hasn't yet begun, the bot should respond with how much time is left before it begins.
https://en.wikipedia.org/wiki/Hanukkah

I would like to work on this one.


[metrics] "Reviews" instead of "Proposals"?

Some people have pointed out that the name "Proposals" is difficult to map to pull requests, merge requests or code reviews, and that "proposals" is not used in this context.
Proposals came from "proposals of changes to the code", but I agree that the word "proposals", isolated, is difficult to map to a code review process. It is the name we're currently used in the code development focus area (file code_development.md).
Thus, I propose to change "Proposals" for "Reviews", which would be much more explicit, and would still include pull requests in the case of GitHub, merge requests in the case of GitLab, and code reviews in the case of Gerrit.
The change would be in all metrics names, such as "Proposals" -> "Reviews", or "Proposals_Accepted" -> "Reviews_Accepted".
If nobody opposes, I will produce the pull request for that (or anyone who has some time could do it ,-) ).
Any feedback is welcome!!

This makes sense to me. I didn't even understand 'proposals' until you explained it here. Reviews is something I understand more :)

Very important concept, which reminds me the document control system and RFC processes: Submit fro review, Pending review, Pending approval, release, obsoleted. However in this case the author can decline review comments/suggestions.

So it seems like the inclination is for 'review'

Good. Thanks for the feedback. If there is no comments against, I will produce the pr changing this.

Pull_Merge_Request?
Forked_code_merge_request?
I think the word "review" is confusing with regards to code reviews.

Thanks for the feedback, @sgoggins. My comments on it:

Pull_Merge_Request: a bit longish, but also misses important systems, such as Gerrit, where the name has nothing to do with "pull request" or "merge request".
Forked_code_merge_request: not sure what "forked code" means in this context...

But, from a general point of view, why "review" is confusing when talking about code reviews? Maybe "Code_Review" would be more clear?

Any other comment about this?

what about "code_integration"?

As related now to #119


OpenSSL Error messages: error:14095126:SSL

Description
This error:

file_get_contents(): SSL operation failed with code 1. OpenSSL Error messages: error:14095126:SSL routines:ssl3_read_n:unexpected eof while reading

returns when:
$file = file_get_contents($url['url'], false, stream_context_create($arrContextOptions));
Steps to Reproduce
https://www.youtube.com/watch?v=r5NzAksjfDI

Extract the video id:
 $video_id = $yt->extractVideoId(implode($url));
Get the downloadable url
$links = $yt->getDownloadLinks($video_id, $selector = 'video');
Get the array key for the specified video quality etc.
$arrayindex = array_search('mp4, video, 1080p, audio', array_column($links, 'format'));
Set $url to array
$url = $links[$arrayindex];
Disable SSL
$arrContextOptions=array(          "ssl"=>array(              "verify_peer"=>false,              "verify_peer_name"=>false,          ),      );
Get the file from the url
$video = file_get_contents($url['url'], false, stream_context_create($arrContextOptions));
Send the video back to front end
return view('convert', [              'url' => $url['url'],              'quality' => $url['format'],          ]);

Expected behavior:
The video gets downloaded on my disk
Actual behavior:
I get this error:
file_get_contents(): SSL operation failed with code 1. OpenSSL Error messages: error:14095126:SSL routines:ssl3_read_n:unexpected eof while reading
The code stops executing on that line aswell.
Version
The latest version of:
https://github.com/Athlon1600/youtube-downloader
Additional Information
I'm running this on Laravel 7, with php artisan serve.

I think this is unrelated to youtube-downloader. You need to enable SSL to work properly on your environment. What's the line number that's being reported for that error?
"file_get_contents(): SSL operation failed with code 1" gives out 180K search results. This seems to be a common problem.


Wake ppoll/pselect on SIGCHLD

This change introduces a sigaction for
SIGCHLD, which causes ppoll and pselect
to return -1/EINTR if a child dies before
a pipe becomes readable. We then check
for dead children, leaving them in a
waitable state for Finish.
Fixes #965
Obsoletes #966

@pcc @maximuska PTAL, hopefully more sane.
For posterity, minimal repro:
rule test
    command = sleep 10s&
    pool = console # or without
build test: test

(should not hang Ninja)

Also, is it possible to add a test for this? See subprocess_test.cc for examples.

I think ultimately, we should also remove the code marking process as 'done' when pipe read indicates EOF, which would address hypothetical tools closing their stdout and stderr w/o terminating.

@nico Added a test for the original issue, i.e. backgrounded task doesn't block observing subprocess exiting. It's using time, which I'd prefer not to do, but couldn't think of a better way to test such behaviour. Suggestions welcome.
@maximuska I have reworked things a bit, so that pipe closure is no longer used to determine whether or not a subprocess is done.
PTAL.

@maximuska Thank you for bearing with me. I've addressed everything other than the poll/read loop; please see my response to your comments there.

The change is fine now as far as I can see, I agree with your responses.
If obsessed, I would set O_NONBLOCK on the pipe (typically a good idea when using poll()), instead of using poll() when draining the fd.

@maximuska Thanks. I thought about doing that too, but it doesn't make things much cleaner. OnPipeReady then ends up needing to loop and handle EAGAIN. It would be neater if it read into a buffer the same size as the pipe capacity, but I don't think there's a portable way to determine that.
@nico @martine rebased, please let me know if there's anything else of concern.

@axw - for the sake of the discussion, I think that you don't need to loop (or add any other change) in OnPipeReady() even with O_NONBLOCK set. The read will return the largest chunk it can give you w/o blocking you, pretty much as it does in the current code. While the pipe is blocking now, the read in OnPipeReady() never get blocked waiting for more data as it is invoked when poll reports that the fd is already readable (it just returns less than the requested 4K).

@maximuska I meant to handle the drain-on-exit case only, and only if poll were removed. If all we were to change is to set the FD non-blocking, then no further change would be needed. That's not enough to remove the poll loop, though.
If the exited process wrote/buffered 4K+1 bytes, one non-blocking read (with 4K buffer as it stands) would read as much as possible: only 4K. We won't come back around to that pipe, because the process is no longer running. The options I see to get the remaining 1 byte: change OnPipeReady to loop (or duplicate in HandleChildExit and loop there), or somehow find the pipe's capacity and set the user-space buffer to the same size. The latter would be nice, but I don't know a portable way to do it (there's fcntl/F_GETPIPE_SZ, but it's Linux-specific).

I started looking at this. So far I noticed that tests now hang on OS X, so it's not good to go as-is. I'm afk for the next few hours, I'll read and debug some more later today.

@nico Thanks; bootstrap seems to do the same on FreeBSD. I'll look into that.

@nico With a little debugging, I found that on FreeBSD it can occur that SIGCHLD is delivered and pselect returns successfully (i.e. without EINTR). Turns out that on BSD and OS X, pselect is just a user-space wrapper around sigprocmask+select. Basically, it's broken there.
So now there's a problem: select might be passed no FDs at all, in which case it'll block forever. There's a work-around for that: http://cr.yp.to/docs/selfpipe.html. Alternatively, use kqueue on BSD/OS X. That still leaves out other OSes, like Solaris. Not sure you'd want to go down the road of recreating libev(ent), or pulling that in as a dependency, so I'll look at implementing the self-pipe approach.

@nico PTAL. Tested on Linux and FreeBSD. I don't have access to OS X, but I expect it's the same issue.

 I'll ping again when it's actually ready.

@nico PTAL. Added another test case that would have picked up my last mistake.

Since this patch does make ninja a bit more complicated. we discussed this a bit on IRC. Supporting command = foo& doesn't seem very interesting. For the use case of making gotest work (a script that spawns sleep $long_time in the background), it sounds like it's possible to make that work by piping that sleep call's handles to /dev/null (or similar) to work around this. So it sounds like this change won't be needed for now.


CustomResource serviceToken must be a string even though return type is object

I'm migrating our existing hand-crafted CF templates to CDK (Java). We have some custom resources which I'm implementing by extending CustomResource.
I've run into an issue with CustomResourceProps.getServiceToken() which has a return type of Object, and want to return a function to match our old templates. Our old templates returned a Sub function like this:
{"Sub":"arn:aws:sns:${AWS::Region}:${AWS::AccountId}:CloudFormationInterface"}

Which I've implemented as a simple java object (Ref), with a single field. Then, I've overridden the CustomResourceProps.getServiceToken() to return a Ref object.  When I synthesize the template, I get the following error:
software.amazon.jsii.JsiiException: While synthesizing test/PoolCustomResource: software.amazon.jsii.JsiiException: Supplied properties not correct for "CustomResourceProps"
  serviceToken: {"Sub":"arn:aws:sns:${AWS::Region}:${AWS::AccountId}:CloudFormationInterface"} should be a string

Is this expected behaviour? In general, is it expected that the CDK would be used to generate and execute the CF template? Or could it be used to generate the template, which is then deployed by some other method. I can see that if we expect the CDK to be used to generate and deploy the template, then there's no need to support the template functions, as we can dynamically change those as the template is created. However, we currently generate one template, and deploy it to different environments using parameters/functions to modify the behaviour. To use the CDK for this, I would need CDK support to generate templates containing template functions.

You should be able to just invoke .toString() on the FnSub (or any other token) and return the result. This is what we call a "stringified token". It lets you to represent CFN intrinsic functions that will resolve to a string at deploy-time as native strings at design-time. This allowed us to dramatically and pragmatically simplify the CDK's type-system (see #168). In most cases, this is almost transparent to users who use the CDK "natively" (as in, not coming from CFN mindset).
Thanks to this mechanism, you can simplify your solution even more. You could technically do this:
serviceToken: `arn:aws:sns:${new cdk.AwsRegion()}:${new cdk.AwsAccountId()}:CloudFormationInterface`

In java this will look like this I guess:
"arn:aws:sns: " + new AwsRegion()  + ":" + new AwsAccountId() + ":CloudFormationInterface"

In this usage, AwsRegion and AwsAccountId are both tokens, and many languages will implicitly invoke toString() when they are concatenated into strings.
The above will resolve to:
{
  "Fn::Join": [
    "",
    [
      "arn:aws:sns:",
      { "Ref": "AWS::Region" },
      ":",
      { "Ref": "AWS::AccountId" },
      ":CloudFormationInterface"
    ]
  ]
}

The best option would probably not to construct ARNs yourself, but use ArnUtils:
serviceToken: cdk.ArnUtils.fromComponents({
  service: 'sns',
  resource: 'CloudFormationInterface'
})

Which resolves to the following, which is even "more accurate" because it takes into account the AWS partition:
{
  "Fn::Join": [
    "",
    [
      "arn:",
      { "Ref": "AWS::Partition" },
      ":sns:",
      { "Ref": "AWS::Region" },
      ":",
      { "Ref": "AWS::AccountId" },
      ":CloudFormationInterface"
    ]
  ]
}

We are trying to build the CDK such that it can be used for both use cases, but optimizing for the "native" use case (the one you refer to "generate + deploy").

Thanks for all that info, very useful. I can see that I'm actually doing it the "wrong way".
As an aside, the toString call doesn't work because I need to serialize the object to json, not just print out the object reference. I could make it work by overriding toString, but building it the way you suggest should work out better.
Out of interest, is there a way to generate cloudformation which uses Sub functions? We have some fairly complex templates that we're converting from static files to being generated using the CDK and it's nice to be able to make sure the files match exactly.

Ahh, sorry. I just saw FnSub.


1.7.10 version 0.29.4

It fixes the following bugs:

Jetpacks halways have fall damage in multiplayer
Pyrophobic coatings crash the game when walking on lava in multiplayer

All those changes came from merging the source from the latest release with the branch, if you want I can remove them, but I just wanted to note that they are a result of discrepancies between the 1.7 branch and the 0.29.3 release, not changes I made.

Oh, okay. Hold off on that then, I'm going to try to figure out why those commits are not in the 1.7 branch.

Okay, the 1.7 branch has been updated to include the missing commits. This was so long ago, I don't remember what happened but somehow all the commits from 0.29.3 disappeared and were only accessible through the 0.29.3 tag. Anyway, if you update your 1.7 branch and fix the merge conflicts it should be fine.

I got it updated

Cool, will find some time to test it out soon.


Working without Hadoop

Hello,
Thank you for the update to Flask from tKinter! I am currently trying to set it up for use on windows, but after tweaking a number of file paths and functions, I keep running into many hadoop functions. My understanding is that hadoop is primarily for unix-based systems.
Would you reccommend trying to modify all functions to function without hadoop? or is it integral to how the application now works? Thank you.

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


API variable type mismatch at creating/modifying an entry

Environment

Python version:  3.5.2
NetBox version:  2.4.3

Steps to Reproduce

Open /api/docs/ URL of NetBox
For example, open POST /ipam/ip-addresses/
It showstenant: {
    id: integer ...,
    url: string ...,
    name: string ...,
    slug: string ...
}

Expected Behavior
In the example above, it should be
tenant: integer ...

Observed Behavior
It shows a parameter which is only compatible at reading but incompatible at writing like
tenant: {
    id: integer ...,
    url: string ...,
    name: string ...,
    slug: string ...
}

Details
Thanks for providing a great software! I'm enjoy using it.
After upgrading to 2.4.3, I found all "WritableXXX" data models had gone away from API JSON representation taken from /api/docs/?format=openapi and these had been replaced by models which were used at reading (GET request). It causes API document mismatch with NetBox internal behavior and a generated code by Swagger doesn't work especially in static type system language like Go etc.
In the above, I explain about a tenant parameter but there are some other parameters which have the same issue.
As far as I checked, it seems to have been introduced at commit 72417832, 821fb1e0 etc. I think a solution should be

Change API JSON description at POST, PUT etc. if a parameter inherits WritableNestedSerializer
Just allow a reading parameter and ignore unneeded arguments at writing

I'm not much familiar with Python so the ideas are just my thought.

The API documentation is generated automatically using drf-yasg. If someone can come up with a non-intrusive way of enabling Swagger to recognize the different read/write behaviors, I'll be happy to incorporate it.

I've written a fix and tested it in our system. It passed unit tests and worked with our API client written in Go. I'll send a pull-request once I clean up commits. Let's discuss about the implementation there.

and worked with our API client written in Go.

Is that a swagger/openapi auto generated client? In other words: does your fix apply to other places where this behavior is observed (and other swagger based clients)?

Yes, it is generated from the swagger definition.
My purpose of the patch is generating swagger definition properly especially for a static type language and using it in my client. I've written it for NetBox 2.4.4, applied to it, downloaded swagger definition and generated a Go client library by go-swagger from it.

Django REST Framework 3.9 now includes native OpenAPI schema support. I haven't had a chance to dig into it yet, but we might end up ditching Swagger entirely in favor of the native implementation.


Could not build the project with error (MEGH-887)

Hi
error:
esp-rainmaker/components/led_strip/src/led_strip_rmt_ws2812.c:155:14: error: implicit declaration of function 'rmt_get_counter_clock'; did you mean 'rmt_get_source_clk'? [-Werror=implicit-function-declaration]
STRIP_CHECK(rmt_get_counter_clock((rmt_channel_t)config->dev, &counter_clk_hz) == ESP_OK,
^~~~~~~~~~~~~~~~~~~~~

@jamesjian007 , what is your esp-idf version? Are you using the master branch?

@shahpiyushv I am using 4.0.

@jamesjian007, please switch to the master branch and try again.

Fixed by use the esp-idf-tools-setup-2.3.exe tool and reinstall with the Master branch. thanks


ios9 did not call back when cancel authorized

the error message  when authorized.

What did your authorization URL look like? Looks like the error is around your app id.

You will see this if we don't have your appId registered yet.


Configuration clarify on Storage settings [DOCS]

Hi,
i can't find any information on what this Comment in the crate.yml means:
# Storage: CrateDB can utilize multiple volumes in parallel, make sure to set
# the owner to 'crate:crate'

Can I use a SSD and a HDD on one node, and the node knows how to tier the storage?
Or do I miss some Storage Tiering option?
Or does the node something like 50:50 distribution?
Or does it fill the first configured volume and then the second, or randomly?
I think this option needs some documentation. You also need some info how to do some sort of Hot-Warm-Cold Architecture.
Thx

Can I use a SSD and a HDD on one node, and the node knows how to tier the storage?

It will spread shards across the folders. One individual shard cannot span across the folders and there is no smart logic in the selection of the folder.

Thanks i will try it when the cluster works again ;)


NTTTCP stats shows error while running TCP IPv4 traffic

Server : C225M6
Adapter : VIC 15428
TRaffic Type : TCP IPv4
TRaffic interfaces :4
While running traffic it shows errors and disconnect

Any update on this issue from Dev side


Session metadata - Need to ensure FIP data is accurately recorded

@hagikent You should review the session.jsons created to ensure the information is accurate.

special attention that FIPMode is recorded

@hagikent Any feedback?

Related to issue 50 on aind-physio-arch

https://github.com/AllenNeuralDynamics/aind-physio-arch/issues/50

Yes, confirmed. Some additional suggestions pushed back by Saskia were not fully addressed but I believe it's fine for now.


fix(format): remove check variables dir for savedmodel

What type of PR is this?
/kind bug

What this PR does / why we need it:
For SavedModel, the dir variables maybe is empty, we can not check it forcely.
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @FogDong

Does this PR introduce a user-facing change?:

remove check variables dir for savedmodel

几番确认，这个目录可以为空，LGTM