Perhaps: Don't call unsafeExtendSafeZone when out of sync

Issue Number
ADP-524
Context
We currently use unsafeExtendSafeZone for:

getTxExpiry for setting TTL in the future
mkApiTransaction for showing TTL in the future
mkShelleyWallet for delegation status changes
combineDbAndLsqData for future pool retirement dates

Overview

[x] unsafeExtendSafeZone now does nothing if the current time is outside the horizon
[ ] When we know what to do, some test would be nice, if possible

Comments

In a way I think it makes sense to first wait for the node to sync, before extrapolating.
Will prevent extrapolating from Byron parameters on Mainnet, but not for custom chains which could still be in Byron.
Pretty magical, stateful and weird though ( but could be solved by making the currentTimeInHorizon call explicitly on the call-sites)
Slack thread

Alternatives

Make unsafeExtendSafeZone extend the safe-zone based on the number of eras in the summary (a bit tricky, would probably add another version interpretQuery rather than a TimeInterpreter combinator)
Use a combination of currentTimeInHorizon :: IO Bool and unsafeExtendSafeZoneIf on the call-sites to make this less magical
Completely remove unsafeExtendSafeZone.

Adjust the integration tests or the default TTL to work together
Write a custom function forecastEpochStartFrom :: RelativeTime -> EpochNo -> Qry UTCTime for delegation and pool retirement

would fail when the current time is outside the safe-zone
I think this the only function we need, but might have forgotten something

Alternative direction -> #2365

We currently use unsafeExtendSafeZone for:

getTxExpiry for setting TTL in the future
mkApiTransaction for showing TTL in the future
mkShelleyWallet for delegation status changes
combineDbAndLsqData for future pool retirement dates

If tx expiry can't be determined for a pending outgoing transaction, just don't show it.
If tx expiry time can't be converted to a slot when making a payment, refuse the request and return an error. (This will also make 1 much less likely). The user should either wait for their node to sync, or use a shorter TTL. Integration tests should use a shorter TTL because of their parameters.
mkShelleyWallet is only used by post wallet operations. It will never have delegation info containing an epoch and time.
This is the only one we really need to worry about. I think we should tweak the API spec and make the ApiEpochInfo->epochStartTime :: UTCTime field into a Maybe. So if we don't know the time, don't report anything.

I don’t think we should tweak the Api to remove the times of delegation change and pool retirement today.
Maybe #2363 can be an acceptable solution today, and then we can remove unsafeExtendSafeZone from TTL, and then see what we want to do for 3 and 4.
Given that the unlimited safe-zone of the final era might not be dependable, and times being useful for humans, I suspect that we always want to provide an estimate.

bors try


Prefer 'set' over 'setenv' for fish shell

The setenv function in fish shell has changed dramatically in
https://github.com/fish-shell/fish-shell/commit/75600b6b538f242a6b340e51965f25cfd4473c4a
It now conforms to the csh version, which takes at most two arguments.
In this init script, the form
setenv PATH prepend_something $PATH
had been used, which had too many arguments.
Since setenv isn't a native command in fish, a suitable replacement is
to use the "set -gx" command, which can consume multiple arguments.

Because of this, currently rbenv is broken on fish 2.6b1, which is the latest beta.

New commit a81da8d864c46c82b8d4ddc8da778f2cdf4274dd reverts the quote changes and fixes the init.bat.  Travis CI now passes.

Thank you!

Is there a plan to release a new Homebrew version with this change? Fish 2.6.0 is released now, so the published version of rbenv no longer works. Thanks


Editor: Support code folding

Add the possibility to fold regions of source files. In the beancount documentation, Martin gives the example of org-mode:
* Banking
** Bank of America

2003-01-05 open Assets:US:BofA:Checking
2003-01-05 open Assets:US:BofA:Savings

;; Transactions follow …

** TD Bank

2006-03-15 open Assets:US:TD:Cash

;; More transactions follow …

Alternatively, C-style folding could be implemented.
This is useful if you organize your source files not purely chronologically, but grouped by institution.

Fixed in #209 (01a6582b32dc5e6a5ac84db6c42009622f52a312)


Implement http_version attribute on BaseResponse object

Currently, I am utilizing requests, which under the hood uses urllib3, whose HTTPResponse object contains a .version attribute, which is an int, ten times greater than the actual HTTP version (i.e. 10 for 1.0, 11 for 1.1, etc).
I currently use it for logging my requests and responses in debug mode.
It would be good I think to implement a similar attribute (either version or more specifically http_version) for the BaseResponse object, for similar purposes, but perhaps use an actual float. What are your thoughts?
Proposal:
BaseResponse.http_version: float = 0.0  # Could be a floatEnum with known HTTP versions

Yup. So we've got response.protocol, which is a string and right now can be either "HTTP/2" or "HTTP/1.1".
We actually ought to improve on that by using the .http_version that h11 returns in order to return "HTTP/1.0" or "HTTP/0.9" when appropriate.
Its also possible that we might want to include a .protocol_value property which returns tuples such as eg. (1, 1) , (2, 0).

I think keeping this a string is best due to all the draft versions of QUIC.

Ah perfect. I had seen .protocol but clearly missed it in the docs as being exactly what I needed. You can go ahead and close this out unless you'd like to keep it for the discussion on h11's http_version

We might also want to think about switching the name over to http_version at some point, since I think that's probably more obvious.

Alright, we've got "HTTP/1.0" and "HTTP/0.9" detection in there now.
Keep in mind that we might consider switching the API to http_version at some point (thoughts on naming, anyone?) so you may want to pin to 0.6.*.

I wouldn't necessarily switch to http_version, as protocol makes sense the way that it is now, I'd just mention it in the API compatibility docs.


Unicorn searching gems in outdated releases

Hi there
I'm using mina and mina-unicorn to deploy my app, but the unicorn is searching the gems in outdated releases. My current release is 230, but an error is raised because Unicorn did not found the gem in release 204.
My deploy.rb is here: https://gist.github.com/thiagogsr/aae6e4f7cbccf0071736
Error:
cannot load such file -- /home/user/app/releases/204/vendor/bundle/ruby/2.2.0/gems/faraday-0.9.1/lib/faraday/adapter/em_http

    to :launch do
      invoke :'unicorn:stop'
      invoke :'unicorn:start'
    end

I got the same error, stop then start instead of restart to solve it.

@thiagogsr I'm trying to reproduce it.
Does your pid config variable from config/unicorn.rb match with unicorn_pid mina variable?

Here's sample app that I'm using to test mina-unicorn deploys:
https://github.com/scarfacedeb/mina-unicorn-test


Create automation script for verifcation Api

Steps
write a automation script for verification Api

Endpoints:- http://localhost:8090/api/v1/Verification

Refer this document
https://drive.google.com/file/d/1y2pthjRAdCPpbmzaeaZ955UqdPup7kTj/view

3 .Outcome:-  Running Verifcation  Api successfully

I completed the test script for verification api from below sheet

@Andolepriti Create the PR in  https://github.com/Tibil-vishwAAs/Vishwaas

I have push the code and created the PR .


Incompatible with Turbo

It appears that Clearance is incompatible with Turbo out of the box, as Turbo will no longer render responses to forms unless they have a 4xx/5xx status.

UsersController#create returns render template: "users/new" on a validation error - this may need to be updated to render template: "users/show", status: :unprocessable_entity
PasswordsController#create returns render template: "passwords/create" regardless of whether a password reset has been sent or not - this may need to be updated to a redirect somewhere.
PasswordsController#edit returns render template: "passwords/edit"without a token on the request - this may need to be updated with :unprocessable_entity also.

Adding status: :unprocessable_entity is an easy fix for two of these, and I wonder if perhaps PasswordsController#create and just redirect back to PasswordsController#new with a successful flash message.
Related: #925

Would love to see Turbo support added! I did the necessary changes in my fork: https://github.com/manuelmeurer/clearance/tree/turbo
Would a PR be acceptable? #936 is already open with most of the fixes.


Reduce the use of libfmt for debug print formatting

This makes for easier switching to std::format later.

Guess maybe this isn't feasible yet. libc++ doesn't define __cpp_lib_format to indicate that it supports formatting, even though cppreference says it's implemented as of libc++17. :(
Will drop the switching to std::format in spdlog and keep the removal of libfmt in places where it's not really needed.
See: https://github.com/llvm/llvm-project/issues/77773

This isn't worth it. Compiler support isn't good enough to drop libfmt yet without too much faff.


Native Notebooks - Collapse All Notebook Cells

Using the "Notebook: Collapse All Notebook Cells" command makes the notebook look broken.

+1 from customer email

cc @mjbvz . It seems the offset updates events are not properly sent to the webview.


Updating to v5.70 (DSM 20.0.844)

Create the PR https://github.com/aws-ia/cfn-ps-trendmicro-deepsecurity/pull/14


waiter: support for numeric maximum value limits on service description parameters

Changes proposed in this PR

Adds generic support for maximum value restrictions on service parameters.

Why are we making these changes?
Introducing limits allows us to fail requests early if the cluster cannot support the requested resources for an instance.
An example error response is shown below:

@dposada ready for another round of review.

@sradack any additional feedback on this?

@sradack any additional feedback on this?

@sradack ping

@sradack ready for another round of review.


Create an inverse for When contains

Feature Request
I'm trying to create a rule like "If this object does not contain this property, then apply this rule" The BDD reference doesn't seem to have an inverse for contains, and putting Not in front doesn't seem to work.
Specifically I'm trying to create a rule saying if the s3 website block doesn't exist, then apply a particular type of encryption. I only want that to apply if that block doesn't exist, and do something else if it does.

Great idea 🎉  will do it on next iterations.

Unfortunately found more problems while fixing this problem on the same related step :(
Need to dive a bit deeper.


TimePicker: Fix OnlyHours incorrect behavior

Description

Fixes #3340
How Has This Been Tested?

unit test added
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

Wow, that is a model unit test. I'll try to do it like that next time too.


Value of the array can not be referenced in a guess file

Hello,
I am trying to set the guess processing into multiple tables in digdag.
_export:
  tables: [table_a, table_b, table_c]

+repeat:
  loop>: ${tables.length}
  _do:
    +guess:
      sh>: embulk guess guess.yml.liquid -o config-import-${tables[i]}.yml

It has been able to include the value of the array to the name of the config file.
However, it will not be able to read the value of the array in the guess file.
in:
  type: s3
  bucket: <BUCKET>
  path_prefix: {{env.tables[i]}}
  access_key_id: <ACCESS_KEY>
  secret_access_key: <SECRET_ACCESS_KEY>
out:
  type: redshift
  host: <HOST>
  user: <USER>
  password: <PASSWORD>
  database: <DATABASE>
  table: {{env.tables[i]}}
  access_key_id: <ACCESS_KEY>
  secret_access_key: <SECRET_ACCESS_KEY>
  s3_bucket: <BUCKET>
  s3_key_prefix: <PREFIX>
  mode: <MODE>

2016-08-18 11:59:34.219 +0000 [INFO] (0001:guess): Loaded plugin embulk-input-s3 (0.2.8)
org.embulk.config.ConfigException: com.fasterxml.jackson.databind.JsonMappingException: Setting null to a task field is not allowed. Use Optional<T> (com.google.common.base.Optional) to represent null.

How can the description in the guess file, or you will be able to see an array of in the dig file?

@yokatsuki
Please try the following dig file.
_export:
  tables: [table_a, table_b, table_c]

+repeat:
  loop>: ${tables.length}
  _do:
    +guess:
      sh>: env table_name=${tables[i]} embulk guess hoge/seed.yml.liquid -o ${tables[i]}.yml

hoge/seed.yml.liquid
in:
  type: file
  path_prefix: "/private/tmp/xxx/hoge/csv/sample_"
out:
  type: {{ env.table_name }} # this is just test

Digdag export environment variable as tables="[table_a, table_b, table_c]" .
So you can't extract environment variable {{env.tables[i]}} part in Embulk config file.
You can check export variables like the following.
_export:
  tables: [table_a, table_b, table_c]

+repeat:
  loop>: ${tables.length}
  _do:
    +guess:
      sh>: env

digdag run test --rerun

An example output is the following.
project_id=1
...
tables=["table_a","table_b","table_c"]

So I define environment variable table_name=XXX before digdag run

Thank you for quick answer.
Set in accordance with your instructions, three of the config file has been created.
And it had been in each of the file contains the result of estimating the table definition.
Issue will close since the fully resolved. Thanks again.


Simplify usize calculation

Includes #52 and #53, so peruse those first.
count_at and a couple of others don't really need a Result return type, it turns out, so this is a nice ergo win. The Java implementation clamps oversized values to the max representable value, so we can too!

Mmm, this is a good change.

Can you rebase onto master?

Rebased.


Merge pull request #1 from apache/master

pull request

merger request

Coverage decreased (-0.03%) to 53.898% when pulling 6c27a165fd9bb5aeab364de19d20e82a7e658eec on condyRen:master into a20f31bb3de242756542c552d7212a7a40000ba4 on apache:master.


Implemented k8s e2e.test for cinder CSIMigration

This job runs the sig-storage + driver: cinder e2e test suite against a
multinode Kubernetes cluster. The cluster is configured with enabled
feature-gates CSIMigration, CSIMigrationOpenStack and ExpandCSIVolumes
on kube-apiserver, kube-controller-manager and kubelet.
This is the replacement for #649

Thanks, Just want to make sure that this job will be ran as periodic job, right?

Thanks @wangxiyuan. This job runs up to an hour, so I think in the first step it makes sense to have that periodically. Maybe I will be able to extract some really essential tests and run them on a per PR basis.


Set parent of reactnamespace identifier to be parse tree node

This helps in resolving the react identifier correctly.
Fixes #11654

@dotnet-bot test this please


Default disk partitions in openbsd58 do not allow build of xenocara for dev

I am trying to use boxcutter/openbsd58 to do dev work on OpenBSD 5.8. OpenBSD development seems very sensitive to where the source lives. As far as I can tell, it has to be in /usr/src for building ports, etc.
To avoid issues I follow the instructions here strictly: http://www.openbsd.org/anoncvs.html#starting
Using doas I attempt to build ports/editors/vim in the /usr/ folder. It gives this:
$ pwd
/usr/ports/editors/vim
$ doas make
Fatal: building ports requires correctly installed X11 (in editors/vim)
*** Error 1 in /usr/ports/editors/vim (/usr/ports/infrastructure/mk/bsd.port.mk:3567 '.BEGIN': @exit 1)

So I attempt to build xenocara to have all the deps for vim, per its README, like this:
$ cd /usr/xenocara
$ make bootstrap
$ make obj
$ make build

Unfortunately, my /usr partition is too small and I eventually get an out of space error. How do I revise the partition sizes for the boxcutter/openbsd58 box to expand my /usr to be big enough to get development done on there?
/usr: write failed, file system is full
gzip: stdout: No space left on device
*** Error 1 in font/adobe-75dpi/obj (Makefile:787 'timR10-ISO8859-1.pcf.gz')
*** Error 1 in font/adobe-75dpi (/usr/X11R6/share/mk/bsd.xorg.mk:145 'all')
*** Error 1 in font/adobe-75dpi (/usr/X11R6/share/mk/bsd.xorg.mk:211 'build')
*** Error 1 in font (<bsd.subdir.mk>:48 'build')
*** Error 1 in . (<bsd.subdir.mk>:48 'realbuild')
*** Error 1 in /usr/xenocara (Makefile:41 'build')

The standard partition layout only sets up 2G for /usr. If you want a ports tree I would recommend to add a extra disk in the Vagrant file and then mount it specifically for /usr/ports
For parallels I do:
  config.vm.provider "parallels" do |prl|
      prl.customize ["set", :id, "--device-add", "hdd", "--size", "10240", "--iface", "ide", "--connect"]
  end

And then I run: fdisk, disklabel, and edit the /etc/fstab.

Thank you for the tip, Rickard. That is a clue that will help me.
I will dive into the virtualbox capabilities to see how I can control disk partition tables for OpenBSD through the Vagrant config and front-end, if possible.

On Mar 4, 2016, at 01:19, Rickard von Essen<EMAIL_ADDRESS>wrote:
The standard partition layout only sets up 2G for /usr. If you want a ports tree I would recommend to add a extra disk in the Vagrant file and then mount it specifically for /usr/ports
For parallels I do:
config.vm.provider "parallels" do |prl|
prl.customize ["set", :id, "--device-add", "hdd", "--size", "10240", "--iface", "ide", "--connect"]
end
And then I run: fdisk, disklabel, and edit the /etc/fstab.
—
Reply to this email directly or view it on GitHub.


Support for PR-001

This is more of a question/feature request as opposed to an issue.  I don't have the ET-73 probe, I have an ET-732 probe, or the PR-001.  While I get readings using your solution, they are all in the 200 degree range.  I know this is simply due to the resistors being used.  I was wondering if you could help me understand how you selected the 22k resistor / formula values for the ET-73 so I could possible figure out those values for the ET-73 and other probes.
Thanks

Hi katlrissland,
I am using this design and it has worked out nicely for me.    I have gotten good temperature readings using the schematics provided. Unfortunately my first arduino project is very complicated.  I am using the Maverick probes as part of my overall design.   I am going to order 2.5mm male to 3.5mm female (more standard) and check the reading.
@skyperry1, I cannot thank you enough for your code and design.  I integrated the Nextion tft touch screen, relays for the 24 vac transformer to power the propane robertshaw standing pilot for my smokehouse.  I am planning on sharing all of it when I am ready.
I look forward to hearing any news about your temp readings.  It has been a while since I looked at this.
When I get home next week I will check my design to see if I tweeked my grounds.  Something tells me I did.
Bigredsmokehouse
Sent via the Samsung Galaxy S®6 active, an AT&T 4G LTE smartphone
-------- Original message --------From: karlrissland<EMAIL_ADDRESS>Date: 5/18/17  6:14 PM  (GMT-05:00) To: skyeperry1/Maverick-ET-73-Meat-Probe-Arduino-Library<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [skyeperry1/Maverick-ET-73-Meat-Probe-Arduino-Library] Support for
  PR-001 (#3)
This is more of a question/feature request as opposed to an issue.  I don't have the ET-73 probe, I have an ET-732 probe, or the PR-001.  While I get readings using your solution, they are all in the 200 degree range.  I know this is simply due to the resistors being used.  I was wondering if you could help me understand how you selected the 22k resistor / formula values for the ET-73 so I could possible figure out those values for the ET-73 and other probes.
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/skyeperry1/Maverick-ET-73-Meat-Probe-Arduino-Library","title":"skyeperry1/Maverick-ET-73-Meat-Probe-Arduino-Library","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/skyeperry1/Maverick-ET-73-Meat-Probe-Arduino-Library"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Support for PR-001 (#3)"}],"action":{"name":"View Issue","url":"https://github.com/skyeperry1/Maverick-ET-73-Meat-Probe-Arduino-Library/issues/3"}}}

hi skyeperry1,
After replying to the question regading the maverick probes, I started
doing a lot of testing and am getting a ton of variances in temperature
readings.  In 4 seconds I am seeing the temps jumping 7-10 degrees in 4
seconds, back and forth.  I have not done a lot of testing but it always
seemed to be ok.  I started tracing this back to find out what is going on.
I changed my relay module from a big one with 8 slots to one with 2.   I
also hooked up my 24vac transformer.  It wasn't the transformer as I turned
the 110v power off to the relay and still the same problem.  I unplugged
the 5v vcc to the relay and all the temperatures were reading just fine.
There is some type of interference on my breadboard.   To narrow it down, I
plugged the relay directly into the arduino board and it worked fine.
On Thu, May 18, 2017 at 9:06 PM, bigredsmokehouse <
<EMAIL_ADDRESS>wrote:

Hi katlrissland,
I am using this design and it has worked out nicely for me.    I have gotten
good temperature readings using the schematics provided. Unfortunately my
first arduino project is very complicated.  I am using the Maverick probes
as part of my overall design.   I am going to order 2.5mm male to 3.5mm
female (more standard) and check the reading.
@skyperry1, I cannot thank you enough for your code and design.  I
integrated the Nextion tft touch screen, relays for the 24 vac transformer
to power the propane robertshaw standing pilot for my smokehouse.  I am
planning on sharing all of it when I am ready.
I look forward to hearing any news about your temp readings.  It has been
a while since I looked at this.
When I get home next week I will check my design to see if I tweeked my
grounds.  Something tells me I did.
Bigredsmokehouse
Sent via the Samsung Galaxy S®6 active, an AT&T 4G LTE smartphone
-------- Original message --------
From: karlrissland<EMAIL_ADDRESS>Date: 5/18/17 6:14 PM (GMT-05:00)
To: skyeperry1/Maverick-ET-73-Meat-Probe-Arduino-Library <
<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [skyeperry1/Maverick-ET-73-Meat-Probe-Arduino-Library] Support
for   PR-001 (#3)
This is more of a question/feature request as opposed to an issue. I don't
have the ET-73 probe, I have an ET-732 probe, or the PR-001. While I get
readings using your solution, they are all in the 200 degree range. I know
this is simply due to the resistors being used. I was wondering if you
could help me understand how you selected the 22k resistor / formula values
for the ET-73 so I could possible figure out those values for the ET-73 and
other probes.
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/skyeperry1/Maverick-ET-73-Meat-Probe-Arduino-Library/issues/3,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXFa3XmrHUGIArBBVDTYcxS52zXEiKlCks5r7MK1gaJpZM4Nf3BS
.


Also change screensaver background?

Hi there. I just read about your script and installed it on Fedora (24). Works great so far. Thank! I do like to keep my screensaver background the same as my desktop wallpaper. I tried to hack your script to make it also change that, but have failed so far. I know no Python. Could you help me? I don't think it is very difficult when you know a little Python (which I don't) . I think it should use something like:
SCHEMA = 'org.gnome.desktop.screensaver'
KEY = 'picture-uri'
Hope you can help. Pointers as what you think needs to be changed are also appreciated. I am more than willing to do it, but I have failed so far...
regards,
Rolf

Ah, never mind. Fixed it. Made a thinking error. I'll post my hack later, when I have more time.

Implemented in 673c2a5762192de0f41be97a141095e1cf54b654, this can be closed.

Ok, here's what I did. Note that I have no Python experience. I just guessed what I should do. And it seems to work :-)
First I created an additional class, just after the class BackgroundChanger. It is almost the same as the BackgroundChanger, but it referres to the screensaver wallpaper...
...gsettings.apply()

class ScreensaverChanger():
    SCHEMA = 'org.gnome.desktop.screensaver'
    KEY = 'picture-uri'

    def change_screensaver(self, filename):
        gsettings = Gio.Settings.new(self.SCHEMA)
        gsettings.set_string(self.KEY, "file://" + filename)
        gsettings.apply()

Then I called the def_screensaver in the main " block" and called it ss_changer:
          ...urllib.urlretrieve(image_url, image_path)
          bg_changer = BackgroundChanger()
          bg_changer.change_background(image_path)
          ss_changer = ScreensaverChanger()
          ss_changer.change_screensaver(image_path)
          summary...

Done. Note that when testing this will only work when the wallpaper hasn't been downloaded yet. If it is, the main routine is skipped and your screensaver wallpaper isn't updated.

Although perhaps not everybody wants to have both wallpapers changed...

@rolfdeenen the functionality has already been implemented, just update and enjoy. I just need the repository owner @UtkarshGpta to close this.

Closed with commit 673c2a5. Thanks!

Closed with commit 673c2a5762192de0f41be97a141095e1cf54b654. Thanks!


Correct nullable in read_dictionary

Which issue does this PR close?

Closes #1892.
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Codecov Report

Merging #1893 (5a7ffee) into master (2e3d8dd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 5a7ffee differs from pull request most recent head 7f9d407. Consider uploading reports for the commit 7f9d407 to get more accurate results

@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
- Coverage   83.48%   83.48%   -0.01%
==========================================
  Files         203      203
  Lines       57141    57141
==========================================
- Hits        47705    47703       -2
- Misses       9436     9438       +2

Impacted Files
Coverage Δ

arrow/src/ipc/reader.rs
90.82% <100.00%> (ø)

arrow/src/datatypes/datatype.rs
65.42% <0.00%> (-0.38%)
:arrow_down:

parquet_derive/src/parquet_field.rs
65.53% <0.00%> (-0.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3d8dd...7f9d407. Read the comment docs.


[SCRIPT] Reproducing GLUE score on 9 tasks

Description
[BERT] Reproducing GLUE score on 9 tasks

Add scripts for RTE, QQP, QNLI, STS-B, CoLA, MNLI, WNLI, SST tasks and specific metric(mcc, accuracy, F1, pearson corr) for each task.
Modify example tutorial.
Split trainer with bias and weight for simplicity.

Checklist
Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

#479

This is awesome. Thank you for the contribution, @haven-jeon.
@kenjewu I know you are interested in this too. It would be great if you could help with this PR with review. Thanks!

Do you wish to extract a base class in bert/dataset.py so each data set can re-use the common part?

This is awesome. Thank you for the contribution, @haven-jeon.
@kenjewu I know you are interested in this too. It would be great if you could help with this PR with review. Thanks!

Ok, I am happy to help review this PR.

Job PR-481/6 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-481/6/index.html

@haven-jeon Do you plan to reproduce all the remaining tasks? @kenjewu is also interested in helping out

Job PR-481/7 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-481/7/index.html

@eric-haibin-lin, @kenjewu  Thanks for your comments.
After several tests with current code, I realized that it's hard to beat remain tasks. but I can see the possibility after merging your code(bertadam, gradient accumulation...).
How about to reproduce remain tasks after merging with your PR?

Hi @haven-jeon given that other PRs also modifying the same file https://github.com/dmlc/gluon-nlp/pull/509 would you be open to resolve the conflicts with the master branch and we can merge this PR with produced result on RTE sooner? That reduce the amount of conflicts with other PRs, and you can incrementally add more reproduction results as they are available later?

Hi @haven-jeon , regarding the 66.4% RTE result for TF, is that dev accuracy, or the test accuracy reported in the paper?

Paper can not know test accuracy performance, because GLUE dashboard only know.

Hi @haven-jeon would you mind creating a PR for your fine-tuning result on STS-B, with the command and logs?


riak_kv_backend:behavior_info(callbacks) is missing callbacks

@ksauzz makes a good argument that the currently-optional callbacks of get_object() and put_object() callbacks for the backend API should no longer be optional.  If they're no longer optional, then they should be formally specified in the callback behavior definition.

Comment for Jira.


Please push up new version to NPM

Hi :)
You made a change a few days ago, this change resolves an error that appears when lazy loading a module that includes expansion panels. Could you please push up a new version to NPM?

ups :) done.

Thank you :)


 Currently the framework is only designed to be built on Ubuntu 14.04 (because we're building a debian distribution for the mesos containerizer using debootstrap).

OS X Yosemite.
There's really no way to build the package on OS X and ship it to AWS via the DCOS stuff?

Not at the moment, due to the requirement of debian debootstrap for chroots... Getting a vagrant / aws ubuntu box is pretty easy using this though: https://github.com/basho-labs/vagrant-riak-mesos (WIP)

So, I need to build a Ubuntu box locally just to produce a package that I might use on insert arbitrary AWS instance here?

Once built, the framework should run on any modern linux kernel based OS, it's just that we targetted ubuntu 14.04 as the only current build platform. In the future it would probably be better to separate the concerns of building the framework itself and the Erlang dependencies (Riak + Riak Explorer + Director).

I know this ticket is old, but improvements have been made @cmeiklejohn in case you still wanted to try building this. Getting the dependencies set up correctly can still be a PITA because some of the mesos-go protobuff stuff is in a transitional state. If you manage to get a working Ubuntu VM up and configured a la https://github.com/basho-labs/vagrant-riak-mesos, the compilation should be smoother with make.


AttributeError: enter

Here is the error:
Traceback (most recent call last):
File "tools/test_lanenet.py", line 148, in
test_lanenet(args.image_path, args.weights_path)
File "tools/test_lanenet.py", line 85, in test_lanenet
binary_seg_ret, instance_seg_ret = net.inference(input_tensor=input_tensor, name='lanenet_model')
File "/home/simge/lanenet-lane-detection-master/lanenet_model/lanenet.py", line 52, in inference
reuse=self._reuse
File "/home/simge/lanenet-lane-detection-master/lanenet_model/lanenet_front_end.py", line 43, in build_model
reuse=reuse
File "/home/simge/lanenet-lane-detection-master/semantic_segmentation_zoo/vgg16_based_fcn.py", line 357, in build_model
self._vgg16_fcn_encode(input_tensor=input_tensor, name='vgg16_encode_module')
File "/home/simge/lanenet-lane-detection-master/semantic_segmentation_zoo/vgg16_based_fcn.py", line 137, in _vgg16_fcn_encode
need_layer_norm=True
File "/home/simge/lanenet-lane-detection-master/semantic_segmentation_zoo/vgg16_based_fcn.py", line 59, in _vgg16_conv_stage
with (name):
AttributeError: _ enter _
I couldn't find how to fix "AttributeError: _ enter _" error. Could you please help?

@trustablecoder Maybe something wrong with your TensorFlow. You may install tensorflow-gpu=1.12.0 to test if the problem still exist:)


Avoid ambiguity of branch/directory names for the git-diff-tree command

Fixes #8029
When there is a directory at the top with the name clashed with the branch name,
the git diff-tree command will not be able to figure out the ambiguity.
Also, remove an outdated comment.

Codecov Report

Merging #8066 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #8066      +/-   ##
==========================================
+ Coverage   41.61%   41.61%   +<.01%
==========================================
  Files         480      480
  Lines       64163    64162       -1
==========================================
+ Hits        26701    26704       +3
+ Misses      34002    34000       -2
+ Partials     3460     3458       -2

Impacted Files
Coverage Δ

modules/pull/merge.go
36.9% <0%> (-0.27%)
:arrow_down:

modules/log/event.go
64.61% <0%> (-1.03%)
:arrow_down:

models/issue.go
49.72% <0%> (+0.23%)
:arrow_up:

models/gpg_key.go
56.66% <0%> (+0.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed22ff...feed358. Read the comment docs.

LGTM

please send backport to 1.9 branch

sorry guy, I'm new here. How can I get this fix to my installation?

sorry guy, I'm new here. How can I get this fix to my installation?

@hanhpv Until the next version gets out (1.9.3 or 1.10.0), which should happen within a couple of weeks, if you have the skills you can try building Gitea from source. You can check the installation from source guide for that:

If you like to live "on the edge" (it comes with some headaches) you could clone the master branch, where this PR is already merged (but this might bring other problems, so be aware).

If you are all in for the safer side, you can wait a little less (a couple of days?) to when this PR is backported to the release/v1.9 branch (you will see a reference to a new PR in this thread).

I hope this helps.

Thanks @guillep2k that makes sense.


Tool-tip needed for adding positions when people

Small issue found during testing. When adding a new person, the developer must also add a position. Example shown below:
When trying to add person
Console
web_1  | PositionInline.formfield_for_foreignkey: db_field: website.Position.grad_mentor db_field.name grad_mentor request: <WSGIRequest: POST '/admin/website/person/add/?_to_field=id&_popup=1'>

As far as I've seen, this issue has only applied to cases where you add people from another model. When you try to use that created person, it is not valid.

Can you update the title to this Issue so that it is more understandable?

@johnsonkuang, I still don't understand this Issue and the title of 'Tool-tip needed for adding positions when people' doesn't make sense. When people what?


modify the image editing page to put the save button at the end of th…

…e view when viewing on mobile
This is a PR to address issue #3711.
My fix is to wrap the three columns on the page in the form instead of just having the form inside the first column. Since the first column is the only place with input fields and is the only form on the page, this should have any negative side effects. This also allows me to but the submit and delete buttons in their own column below the others. This doesn't change the view on the desktop view but moves those buttons to the bottom of the page when viewed in a smaller viewport.

Looks good, however the position seems out of place when using a 'medium-sized' viewport (~1200px width):

https://pastebin.com/kF7AUX4Z -- Tested in Firefox 55, Chrome 60 and Safari mobile (iPhone 6S). All working without issues.

It's in 🎉. Will ship in Wagtail 2.1.


fix redefine

@asmh1989 , could you provide information about what is the PR for and the problem it resolves?

RNFetchBlob.fetch('GET', url,headers)

I put correct If-modified-since in headers,  servers not return 304 code, it return 200
After this modify, it return correct.
I think defaultConfigObject ,   Should not be nil,  to set into NSURLSession

This PR is no longer necessary, the issue that was in the code at that time, see (beginning of June)
https://github.com/wkh237/react-native-fetch-blob/blob/869bb47d161ae17f4d7611c9ff57ee36446f1bf2/ios/RNFetchBlobNetwork.m#L194
is no longer there, see (beginning of September)
https://github.com/wkh237/react-native-fetch-blob/blob/821eeb0f9db1736009ee791c14298ef72144a825/ios/RNFetchBlobNetwork.m#L197

in android , The problem still exists.

@marlti7 This PR changes a single file in the ios subdirectory. I have no idea what you are writing about....


Changes to Whatsapp code:

Audio messages now appear correctly
Replies now being sent to other protocols

-First part of deletion code
-Audio message type added
-Quoted message sent
-Instead of number or "someone" using pushname if available


Use Excel as output format

This is better for collaborators and can these days be read in very easily into pandas.

Coverage decreased (-1.2%) to 98.019% when pulling ca83415406f3ce532654c27b4e4a23bf9edfb2d7 on excel into 6592ae9155b3aafa8c00a5bee7c4c4847adf6da8 on master.

Coverage increased (+0.04%) to 99.224% when pulling a002e66b3f26a7ae8eed3a7887110ae577cd5094 on excel into 613df245baec72931d4c09fe67ad93b2ce3892f6 on master.


No template literals in normal strings

https://github.com/eslint/eslint/issues/5850
Do we want to create a rule for this here?
I don't think it happens often but can be useful, and we might as well put it here as we have/want plenty of different type of rules.

Yeah. Doesn't have to happen often to be useful.
Might want to wait on this though (from linked issue):

I'll leave this open for a bit to see if anyone on the team wants to disagree.

It's now closed, sadly. I'd love to be able to use this rule.

Alright. Let's do it then.

@sindresorhus it'd be awesome if it could be done standalone, and made a dep of this one, so i can use it in other packages without having to bring in this entire package :-)

You wouldn't get much less by having a standalone module (there a not a lot of dependencies... yet), and maybe you'll want all the awesome rules that it has and will have? :D
More seriously, to me, it's a bit of a pain to create a new project for it. I agree that you might not want all the rest, but maintaining-wise, it's simpler to have it in a project that is actively maintained by several people, not in a corner somewhere. I proposed to add it here because it's kind of a specific rule, with no existing plugin (afaik) it could get included in, and because this is a collection of various rules.
Then again, if we write this rule, you're free to copy it in a new repo and use it as you see fit.

I use eslint-find-rules --unused to ensure that all rules available are defined, so if I bring in a plugin with N rules, i have to add N lines to my eslint config.
If the authors don't mind, then once written, I'd be happy to spend the few minutes required to create a new project, and would be happy to copy the code and share ownership/maintainership of it, especially if this module could pull it in as a dep.

More seriously, to me, it's a bit of a pain to create a new project for it.

Maybe we should build this project as a monorepo? Split each rule into its own package? It would be interesting to explore what AVA and XO could do to enable monorepo development:

shared config
easily test/lint all submodules/packages
easily test/lint an individual submodule/package

Maybe we should build this project as a monorepo

Can be interesting.

explore what AVA and XO could do to enable monorepo development

Does AVA already do something monorepo-like, or are you suggesting it could start doing something in that vein?

I'm really not a big fan of monorepos. It would also add a lot of overhead. I think the rules we have now makes sense in one package. We currently have a nice setup with tests, docs and code coverage. I don't really see the problem depending on this plugin, even if you only want one rule. We currently only have 4 tiny dependencies. Dependencies matters less in a dev environment.

I use eslint-find-rules --unused to ensure that all rules available are defined, so if I bring in a plugin with N rules, i have to add N lines to my eslint config.

I would rather fix that module. It should have an ignore option.

Closing as it's being integrated in ESLint core rules https://github.com/eslint/eslint/pull/6767


[1.7.10] Using "U" hotkey crashes the Client with different mods

Hello,
I have a problem with the latest NEI (I try both 103 and 105 and got the same problem). When you press "U", the game client crashes. When you are on a multiplayer server, only the client crashes, not the server.
The problem shows up when you have these mods installed :

Magic Bees (latest version)
Galacticraft (Recommended version)
Magical Crops (public beta 4.0.0b2 )
ModularPowersuits (latest version)

I think, the problem came from NEI, because it doesn't appear when you have only one specific mod installed.
Here is the crash report (if you need)  :
---- Minecraft Crash Report ----
// This is a token for 1 free hug. Redeem at your nearest Mojangsta: [HUG]
Time: 27/04/15 14:06
Description: Updating screen events
java.lang.ClassCastException: null not an ItemStack, ItemStack[] or List<ItemStack?
at codechicken.nei.NEIServerUtils.extractRecipeItems(NEIServerUtils.java:344)
at codechicken.nei.PositionedStack.(PositionedStack.java:27)
at codechicken.nei.PositionedStack.(PositionedStack.java:39)
at codechicken.nei.recipe.ShapelessRecipeHandler$CachedShapelessRecipe.setResult(ShapelessRecipeHandler.java:60)
at codechicken.nei.recipe.ShapelessRecipeHandler$CachedShapelessRecipe.(ShapelessRecipeHandler.java:38)
at codechicken.nei.recipe.ShapelessRecipeHandler$CachedShapelessRecipe.(ShapelessRecipeHandler.java:46)
at codechicken.nei.recipe.ShapelessRecipeHandler.shapelessRecipe(ShapelessRecipeHandler.java:145)
at codechicken.nei.recipe.ShapelessRecipeHandler.loadUsageRecipes(ShapelessRecipeHandler.java:127)
at codechicken.nei.recipe.TemplateRecipeHandler.loadUsageRecipes(TemplateRecipeHandler.java:346)
at codechicken.nei.recipe.TemplateRecipeHandler.getUsageHandler(TemplateRecipeHandler.java:471)
at codechicken.nei.recipe.GuiUsageRecipe.openRecipeGui(GuiUsageRecipe.java:20)
at codechicken.nei.recipe.RecipeItemInputHandler.lastKeyTyped(RecipeItemInputHandler.java:20)
at codechicken.nei.guihook.GuiContainerManager.lastKeyTyped(GuiContainerManager.java:307)
at net.minecraft.client.gui.inventory.GuiContainer.func_73869_a(GuiContainer.java)
at net.minecraft.client.gui.inventory.GuiContainerCreative.func_73869_a(GuiContainerCreative.java:301)
at net.minecraft.client.gui.inventory.GuiContainer.public_func_73869_a(GuiContainer.java)
at codechicken.nei.guihook.GuiContainerManager.callKeyTyped(GuiContainerManager.java)
at codechicken.nei.guihook.GuiContainerManager.keyTyped(GuiContainerManager.java:475)
at codechicken.nei.guihook.GuiContainerManager.handleKeyboardInput(GuiContainerManager.java:465)
at net.minecraft.client.gui.inventory.GuiContainer.func_146282_l(GuiContainer.java)
at net.minecraft.client.gui.GuiScreen.func_146269_k(GuiScreen.java:276)
at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1640)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:973)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:898)
at net.minecraft.client.main.Main.main(SourceFile:148)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
A detailed walkthrough of the error, its code path and all known details is as follows:
-- Head --
Stacktrace:
at codechicken.nei.NEIServerUtils.extractRecipeItems(NEIServerUtils.java:344)
at codechicken.nei.PositionedStack.(PositionedStack.java:27)
at codechicken.nei.PositionedStack.(PositionedStack.java:39)
at codechicken.nei.recipe.ShapelessRecipeHandler$CachedShapelessRecipe.setResult(ShapelessRecipeHandler.java:60)
at codechicken.nei.recipe.ShapelessRecipeHandler$CachedShapelessRecipe.(ShapelessRecipeHandler.java:38)
at codechicken.nei.recipe.ShapelessRecipeHandler$CachedShapelessRecipe.(ShapelessRecipeHandler.java:46)
at codechicken.nei.recipe.ShapelessRecipeHandler.shapelessRecipe(ShapelessRecipeHandler.java:145)
at codechicken.nei.recipe.ShapelessRecipeHandler.loadUsageRecipes(ShapelessRecipeHandler.java:127)
at codechicken.nei.recipe.TemplateRecipeHandler.loadUsageRecipes(TemplateRecipeHandler.java:346)
at codechicken.nei.recipe.TemplateRecipeHandler.getUsageHandler(TemplateRecipeHandler.java:471)
at codechicken.nei.recipe.GuiUsageRecipe.openRecipeGui(GuiUsageRecipe.java:20)
at codechicken.nei.recipe.RecipeItemInputHandler.lastKeyTyped(RecipeItemInputHandler.java:20)
at codechicken.nei.guihook.GuiContainerManager.lastKeyTyped(GuiContainerManager.java:307)
at net.minecraft.client.gui.inventory.GuiContainer.func_73869_a(GuiContainer.java)
at net.minecraft.client.gui.inventory.GuiContainerCreative.func_73869_a(GuiContainerCreative.java:301)
at net.minecraft.client.gui.inventory.GuiContainer.public_func_73869_a(GuiContainer.java)
at codechicken.nei.guihook.GuiContainerManager.callKeyTyped(GuiContainerManager.java)
at codechicken.nei.guihook.GuiContainerManager.keyTyped(GuiContainerManager.java:475)
at codechicken.nei.guihook.GuiContainerManager.handleKeyboardInput(GuiContainerManager.java:465)
at net.minecraft.client.gui.inventory.GuiContainer.func_146282_l(GuiContainer.java)
at net.minecraft.client.gui.GuiScreen.func_146269_k(GuiScreen.java:276)
-- Affected screen --
Details:
Screen name: net.minecraft.client.gui.inventory.GuiContainerCreative
-- Affected level --
Details:
Level name: MpServer
All players: 1 total; [EntityClientPlayerMP['Lebleuss'/323, l='MpServer', x=-231,50, y=75,62, z=54,50]]
Chunk stats: MultiplayerChunkCache: 545, 545
Level seed: 0
Level generator: ID 04 - RWG, ver 0. Features enabled: false
Level generator options:
Level spawn location: World: (-237,64,56), Chunk: (at 3,4,8 in -15,3; contains blocks -240,0,48 to -225,255,63), Region: (-1,0; contains chunks -32,0 to -1,31, blocks -512,0,0 to -1,255,511)
Level time: 426 game time, 426 day time
Level dimension: 0
Level storage version: 0x00000 - Unknown?
Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false)
Level game mode: Game mode: creative (ID 1). Hardcore: false.
CoFHCore: -[1.7.10]3.0.2-271
ThermalFoundation: -[1.7.10]1.0.0-82
ThermalExpansion: -[1.7.10]4.0.1-182
MineFactoryReloaded: -[1.7.10]2.8.1B1-109
TConstruct Environment: Environment healthy.
NetherOres: -[1.7.10]2.3.1B1-13
RedstoneArsenal: -[1.7.10]1.1.0-81
ThermalDynamics: -[1.7.10]1.0.0-122
List of loaded APIs:
* AppleCoreAPI (1.1.0) from AppleCore-mc1.7.10-1.1.0.jar
* appliedenergistics2|API (rv2) from ThaumicTinkerer-2.5-1.7.10-164.jar
* Baubles|API (<IP_ADDRESS>) from Reliquary-1.2.jar
* BiomesOPlentyAPI (1.0.0) from BiomesOPlenty-1.7.10-<IP_ADDRESS>7-universal.jar
* bluepowerAPI (1.0) from BluePower-1.7.10-0.2.928-universal.jar
* BotaniaAPI (44) from Botania r1.6-184.jar
* BuildCraftAPI|blueprints (1.2) from buildcraft-6.4.13.jar
* BuildCraftAPI|boards (1.0) from buildcraft-6.4.13.jar
* BuildCraftAPI|core (1.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* BuildCraftAPI|events (1.0) from buildcraft-6.4.13.jar
* BuildCraftAPI|facades (1.0) from buildcraft-6.4.13.jar
* BuildCraftAPI|filler (3.0) from buildcraft-6.4.13.jar
* BuildCraftAPI|fuels (2.0) from buildcraft-6.4.13.jar
* BuildCraftAPI|gates (4.0) from buildcraft-6.4.13.jar
* BuildCraftAPI|items (1.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* BuildCraftAPI|power (1.3) from buildcraft-6.4.13.jar
* BuildCraftAPI|recipes (2.1) from buildcraft-6.4.13.jar
* BuildCraftAPI|robots (1.0) from buildcraft-6.4.13.jar
* BuildCraftAPI|statements (1.0) from buildcraft-6.4.13.jar
* BuildCraftAPI|tiles (1.1) from buildcraft-6.4.13.jar
* BuildCraftAPI|tools (1.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* BuildCraftAPI|transport (4.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* ChiselAPI (0.0.2) from Chisel2-<IP_ADDRESS>.jar
* ChiselAPI|Carving (0.0.2) from Chisel2-<IP_ADDRESS>.jar
* CoFHAPI (1.7.10R1.0.2) from RandomThings-2.2.4.jar
* CoFHAPI|block (1.7.10R1.0.0) from extrautilities-1.2.4b.jar
* CoFHAPI|core (1.7.10R1.0.12) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHAPI|energy (1.7.10R1.0.2) from IC2NuclearControl-2.2.1a-Yolo.jar
* CoFHAPI|fluid (1.7.10R1.0.12) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHAPI|inventory (1.7.10R1.0.1) from buildcraft-compat-6.4.2.jar
* CoFHAPI|item (1.7.10R1.0.7) from EnderTech-1.7.10-<IP_ADDRESS>2.jar
* CoFHAPI|modhelpers (1.7.10R1.0.12) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHAPI|tileentity (1.7.10R1.0.7) from EnderTech-1.7.10-<IP_ADDRESS>2.jar
* CoFHAPI|transport (1.7.10R1.0.1) from buildcraft-compat-6.4.2.jar
* CoFHAPI|world (1.7.10R1.0.12) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHLib (1.7.10R1.0.0B8) from CoFHLib-[1.7.10]1.0.1-158.jar
* CoFHLib|audio (1.7.10R1.0.0B9) from EnderTech-1.7.10-<IP_ADDRESS>2.jar
* CoFHLib|gui (1.7.10R1.0.1) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHLib|gui|container (1.7.10R1.0.1) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHLib|gui|element (1.7.10R1.0.1) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHLib|gui|element|listbox (1.7.10R1.0.1) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHLib|gui|slot (1.7.10R1.0.1) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHLib|inventory (1.7.10R1.0.0B8) from CoFHLib-[1.7.10]1.0.1-158.jar
* CoFHLib|render (1.7.10R1.0.0B8) from CoFHLib-[1.7.10]1.0.1-158.jar
* CoFHLib|render|particle (1.7.10R1.0.1) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHLib|util (1.7.10R1.0.0B8) from CoFHLib-[1.7.10]1.0.1-158.jar
* CoFHLib|util|helpers (1.7.10R1.0.1) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHLib|util|position (1.7.10R1.0.1) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHLib|world (1.7.10R1.0.1) from CoFHCore-[1.7.10]3.0.2-271.jar
* CoFHLib|world|feature (1.7.10R1.0.0B8) from CoFHLib-[1.7.10]1.0.1-158.jar
* ComputerCraft|API (1.73) from ComputerCraft1.73.jar
* ComputerCraft|API|FileSystem (1.73) from ComputerCraft1.73.jar
* ComputerCraft|API|Lua (1.73) from ComputerCraft1.73.jar
* ComputerCraft|API|Media (1.73) from ComputerCraft1.73.jar
* ComputerCraft|API|Peripheral (1.73) from ComputerCraft1.73.jar
* ComputerCraft|API|Redstone (1.73) from ComputerCraft1.73.jar
* ComputerCraft|API|Turtle (1.73) from ComputerCraft1.73.jar
* EnderIOAPI (0.0.2) from EnderIO-1.7.10-<IP_ADDRESS>7.jar
* EnderIOAPI|Redstone (0.0.2) from EnderIO-1.7.10-<IP_ADDRESS>7.jar
* EnderIOAPI|Tools (0.0.2) from EnderIO-1.7.10-<IP_ADDRESS>7.jar
* factorization notification system (1.0) from Factorization-1.7.10-0.8.89.jar
* ForestryAPI|apiculture (2.6.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|arboriculture (2.3.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|circuits (1.1.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|core (2.6.1) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|farming (1.1.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|food (1.1.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|fuels (2.0.1) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|genetics (2.7.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|hives (4.0.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|lepidopterology (1.1) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|mail (3.0.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|recipes (2.1.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|storage (2.3.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* ForestryAPI|world (1.1.0) from forestry_1.7.10-<IP_ADDRESS>.jar
* gendustryAPI (1.4.10) from gendustry-mc1710-<IP_ADDRESS>.jar
* IC2API (1.0) from industrialcraft-2-2.2.718-experimental.jar
* MekanismAPI|core (8.0.0) from Mekanism-1.7.10-<IP_ADDRESS>.jar
* MekanismAPI|energy (8.0.0) from Mekanism-1.7.10-<IP_ADDRESS>.jar
* MekanismAPI|gas (8.0.0) from Mekanism-1.7.10-<IP_ADDRESS>.jar
* MekanismAPI|infuse (8.0.0) from Mekanism-1.7.10-<IP_ADDRESS>.jar
* MekanismAPI|laser (8.0.0) from Mekanism-1.7.10-<IP_ADDRESS>.jar
* MekanismAPI|reactor (8.0.0) from Mekanism-1.7.10-<IP_ADDRESS>.jar
* MekanismAPI|recipe (8.0.0) from Mekanism-1.7.10-<IP_ADDRESS>.jar
* MekanismAPI|transmitter (8.0.0) from Mekanism-1.7.10-<IP_ADDRESS>.jar
* MekanismAPI|util (8.0.0) from Mekanism-1.7.10-<IP_ADDRESS>.jar
* MetallurgyAPI (2.0.1) from Metallurgy-1.7.10-<IP_ADDRESS>.jar
* minechemAPI (1.7.10R1) from DragonAPI 1.7.10 V6f.jar
* Mystcraft|API (0.1) from mystcraft-1.7.10-<IP_ADDRESS>.jar
* NuclearControlAPI (v1.0.5) from IC2NuclearControl-2.2.1a-Yolo.jar
* OpenComputersAPI|Component (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenComputersAPI|Core (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenComputersAPI|Driver (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenComputersAPI|Driver|Item (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenComputersAPI|Event (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenComputersAPI|FileSystem (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenComputersAPI|Internal (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenComputersAPI|Machine (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenComputersAPI|Manual (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenComputersAPI|Network (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenComputersAPI|Prefab (5.1.1) from OpenComputers-MC1.7.10-<IP_ADDRESS>-universal.jar
* OpenPeripheralApi (3.2) from OpenPeripheralCore-1.7.10-1.1-snapshot-220.jar
* PneumaticCraftApi (1.0) from PneumaticCraft-1.7.10-1.6.7-69-universal.jar
* RailcraftAPI|bore (1.0.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|carts (1.3.1) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|core (1.3.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|crafting (1.0.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|electricity (1.6.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|events (1.0.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|fuel (1.0.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|helpers (1.1.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|items (1.0.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|locomotive (1.0.1) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|signals (1.3.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* RailcraftAPI|tracks (2.0.0) from Railcraft_1.7.10-<IP_ADDRESS>.jar
* Thaumcraft|API (<IP_ADDRESS>) from Pam's HarvestCraft 1.7.10h.jar
* WailaAPI (1.2) from Waila-1.5.10_1.7.10.jar
Stencil buffer state: Function set: GL30, pool: internal, bits: 8
AE2 Integration: IC2:ON, RotaryCraft:ON, RC:ON, BC:ON, RF:ON, RFItem:ON, MFR:ON, DSU:ON, FZ:ON, FMP:ON, RB:OFF, CLApi:OFF, Waila:ON, InvTweaks:ON, NEI:ON, CraftGuide:OFF, Mekanism:ON, ImmibisMicroblocks:OFF, BetterStorage:OFF
Launched Version: 1.7.10-Forge<IP_ADDRESS>5-1710ls
LWJGL: 2.9.1
OpenGL: GeForce GTX 780/PCIe/SSE2 GL version 4.5.0 NVIDIA 350.12, NVIDIA Corporation
GL Caps: Using GL 1.3 multitexturing.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Anisotropic filtering is supported and maximum anisotropy is 16.
Shaders are available because OpenGL 2.1 is supported.
Is Modded: Definitely; Client brand changed to 'fml,forge'
Type: Client (map_client.txt)
Resource Packs: []
Current Language: English (US)
Profiler Position: N/A (disabled)
Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
Anisotropic Filtering: Off (1)

Nevermind I wass using a bugged version of Forge <IP_ADDRESS>5. I downgrade to <IP_ADDRESS>0 and now it works fine.


feat(refactoring): add/from destructure improvements

since we also do support vue maybe it would be useful to detect cases when we need to wrap the generated result of destruct refactoring with toRefs?

This is getting really good!

@Ilanaya i think it's good merge. Tests and handles cases are not bad and want to finally release this so badly :)

Agree, I'll complete this feature (add 'this' support and vue refs) when I'll have more spare time(probably this weekend), so if you want you can release it now.


[2.5] Fix for machine_cpu_cores being removed from cadvisor metrics

See also https://github.com/rancher/rancher/issues/29292

Hmm weird, the drone build is failing because of a failure while trying to create rancher-images.txt here:
time="2020-12-02T18:35:42Z" level=info msg="generating k3s image list..."
2755	time="2020-12-02T18:35:42Z" level=info msg="finished generating k3s image list..."
2756	2020/12/02 18:35:42 Creating rancher-images.txt
2757	2020/12/02 18:35:42 Image: busybox
2758	2020/12/02 18:35:42 Image [jaegertracing/all-in-one:1.20.0] does not start with rancher/
2759	exit status 1
2760	time="2020-12-02T18:35:45Z" level=fatal msg="exit status 1"

This seems to be related to a change made in rancher/charts to resolve this here, but I'm unsure if the fix is just to rebase the PR since re-running the drone build doesn't seem to resolve the issue.
@dnoland1 can you try rebasing this PR against the latest to see if that resolves the issue?

@aiyengar2 Created new PR for release/v2.5 here - https://github.com/rancher/rancher/pull/30335

Thanks @dnoland1 , closing out this PR in favor of https://github.com/rancher/rancher/pull/30335

closing in favor of: https://github.com/rancher/rancher/pull/30339


Could not find the ruling party for NET. Error

Hello, i converted my ck2 savegame to eu4 then eu4 to vic2. And now im done with VIC2, when i try to convert to HOI4. It gives me this error.
2018-06-30 02:22:09 [ERROR] Could not find the ruling party for NET. Most likely a mod was not included.
2018-06-30 02:22:09 [ERROR] Double-check your settings, and remember to include EU4 to Vic2 mods. See the FAQ for more information.
. Everything is okay, i dont get it whats the problem? HOI4 version: 1.5.2
Thanks

You need to include the eu4toVic2 mod you played with in the converter options. If you're unsure of the exact name, log.txt will list all the mods the converter could find.


Build a website!

We should have a web page for Acton. We have some domains registered, like acton-lang.org which currently points to a web server where I put a very simple page ;)
I don't think it needs to be too fancy at this point, just some basic information, most of which we currently have in the README, like basic language info, how to install and running the hello world example.

orthogonal persistence is the term! https://en.wikipedia.org/wiki/Persistence_(computer_science)#Orthogonal_or_transparent_persistence

I've built a basic page, which is in  https://github.com/actonlang/www.acton-lang.org
It uses a static site generator called zola which automatically runs in github actions on commits. We can write most content in markdown format.
Page includes basic info at this point. I wrote some blurbs etc. Pretty happy about it! We can expand from there but at least the basic infrastructure and content is there.
Closing issue.


enable google analytics

closes #4

wish this was working during the event :) confirmed it works with these changes:

Also checked and the Google Analytics request showed up for me on the test deployment, after loading the page.

wish this was working during the event :) confirmed it works with these changes:

100% agree that this would have been a nice metric to know and add for the event.


Add S3 buckets and Accessor policy to terraform

fixes #1583
🗣 Description
Creates the P&E reports and db backup S3 buckets. *Will replace the existing, which is okay.
Also adds S3 access to the Accessor IAM role.

@epicfaace Looks like the failures below are unrelated. Let me know if I should make a separate issue or if I should go ahead and address them here

@epicfaace ready for review


Update deprecated fields in package.

Hi, Thanks for this awesome package.
Expected Behavior
REST API should work smoothly without deprecated fields
Current Behavior
App showing deprecated fields in shop REST API
Failure Logs
Showing attached screenshot error for deprecated field "force_ssl" which i have not used in my app. but i found this value in "vendor/osiset/basic-shopify-api/test/fixtures/rest/admin__shop.json" https://prnt.sc/1ahm4i8.

Package Version: 12.1
Laravel Version: 7.24
PHP Version: v7.3.13
OS: Linux Mint 19.2

This has nothing to do with the package.
"force_ssl" is part of the test fixures.
What Shopify is complaining about would need more info.

Does someone solve this issue?

Closing old ticket. Re-open if an issue.


experimental: Per service lb algorithm selection

Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[x] Thanks for contributing!

This adds support for Per-service Load Balancing Algorithm Selection (from CFP-34577) to StateDB-based load balancing after it was implemented in the currently-used load balancing in https://github.com/cilium/cilium/pull/35735/ (see also https://github.com/cilium/cilium/pull/36204).

/cc @kl52752
/cc @brb

Conformance Kind Envoy Embedded / Installation and Connectivity Test (pull_request) Failing after 16m

📋 Test Report [cilium-test-5]
❌ 1/13 tests failed (1/196 actions), 6 tests skipped, 0 scenarios skipped:
Test [client-egress-l7-set-header-port-range]:
  ❌ client-egress-l7-set-header-port-range/pod-to-pod-with-endpoints/curl-ipv4-2-auth-header-required: cilium-test-5/client3-795488bf5-8lcsb (<IP_ADDRESS>) -> curl-ipv4-2-auth-header-required (<IP_ADDRESS>:8080)

I see very similar test failures for an empty PR https://github.com/cilium/cilium/actions/runs/12429666814/job/34703608166?pr=36744, so it's most likely some flakiness or regression on main.

/assign @borkmann (for the first commit)

/test

Ok, Conformance Runtime (ci-runtime) and Integration Tests (ci-integration) failed because I updated the format of dump strings in pkg/loadbalancer/experimental/testdata, but I forgot to update it in pkg/ciliumenvoyconfig/testdata/. This should be fine now.

/test

FYI: @bowei

/test ci-ginkgo

/ci-ginkgo

/ci-external-workloads

/ci-e2e-upgrade

/ci-ipsec-upgrade

/ci-ipsec-e2e

/test

/test

/test
(after rebase to the latest main)

/test

/ci-eks

/ci-external-workloads


Audio detect and recording shows incorrect information after MQTT restart

Version of the custom_component
5.4.0
Configuration

mqtt:
  enabled: true
  host: mosquitto_mqtt
  user: frigate_usr
  password: xxxxxxxxxx

review:
  alerts:
    labels:
      - cat
      - dog
      - person
      - speech
detect:
  enabled: true

audio:
  enabled: true
  listen:
    - bark
    - fire_alarm
    - scream
    - speech
    - yell

record:
  enabled: true
  retain:
    days: 3
    mode: motion
  events:
    retain:
      default: 30
      mode: motion

snapshots:
  enabled: true
  timestamp: true
  retain:
    default: 10
    objects:
      person: 15

go2rtc:
  streams:
    e1zoom:
      - ffmpeg:http://ip/flv?port=1935&app=bcs&stream=channel0_main.bcs&user=usr&password=pass#video=copy#audio=copy#audio=aac
    e1zoom_sub:
      - ffmpeg:http://ip/flv?port=1935&app=bcs&stream=channel0_ext.bcs&user=usr&password=pass

cameras:
  e1zoom:
    enabled: true
    onvif:
      host: ip
      port: 8000
      user: usr
      password: pass
      autotracking:
        enabled: false
        return_preset: home
        timeout: 60
    ffmpeg:
      inputs:
        - path: rtsp://<IP_ADDRESS>:8554/e1zoom
          input_args: preset-rtsp-restream
          roles:
            - record
        - path: rtsp://<IP_ADDRESS>:8554/e1zoom_sub
          input_args: preset-rtsp-restream
          roles:
            - detect
            - audio
      output_args:
        record: preset-record-generic-audio-copy
version: 0.14

Describe the bug
After mosquitto MQTT server is restarted the Home Assistant integration shows incorrect state of audio detection and recording.

Could be related to this issue? #662
Debug log

N/A

actually, this is an issue where the frontend shows the wrong state and that bug was fixed in 0.14.1

Thanks for your comment! I'll wait until 0.14.1 will be in the stable docker tag.

it already is https://github.com/blakeblackshear/frigate/pkgs/container/frigate/264807004?tag=0.14.1

I have updated to tag 0.14.1 and it is still with same error. maybe it's not the same bug. Mine error is reproduced after restarting MQTT server, not after restarting frigate or HA.
With regards,

I see, well that would be a frigate issue not an integration issue since the integration can only go off of what is in the integration

Ok, I'll open the isuue on frigate project. Thanks!


on the use of 'dehash'

https://www.techsolvency.com/passwords/dehashing-reversing-decrypting/

You are correct when we are talking about "hash" unconditionally. Thanks for the educational efforts!
However in some conditions, for instance, when people apply "hash" to a limited size set, any hash algorithm is no longer secure enough to protect the original information. I see a lot of misunderstandings on this and create this project to tell people that it is so easy to "dehash" or "crack" such kind of protection mechanism.


Include classic_layout argument to resolve missing parameter issue

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.44%. Comparing base (c1b9e6e) to head (ebcca1d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   96.43%   96.44%
=======================================
  Files          30       30
  Lines        3256     3260    +4
=======================================
+ Hits         3140     3144    +4
  Misses         90       90
  Partials       26       26

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


CLI WSS auth using Client + Cert does not work, but Username + Password does

What did I do
I am trying to use CLI to connect to MQTT via WSS with client certificate & key.  The same options work in GUI, but not with the CLI.  When I use --debug I can see that CLI has some logic where it thinks protocol is mqtts even if I specify protocol as WSS.
What happened
Note: I am trying this with my internal MQTT broker. I am using broker.emqx.io just as example.
✅ Works (Username + Password)
mqttx conn --debug --mqtt-version 3.1.1 --protocol "wss" --insecure -h "broker.emqx.io" -p 8084 --client-id "ThisWillWork" -u "user" -P "pass"
❌ Does not work (Key + Cert + CA)
mqttx conn --debug --mqtt-version 3.1.1 --protocol "wss" --insecure -h "broker.emqx.io" -p 8084 --client-id "ThisWillNotWork"  --key "C:\Temp\client.key" --cert "C:\Temp\client.pem" --ca "C:\Temp\server.pem"
Expected
I expect that I can use WSS and certificate based authentication to connect / subscribe / publish, which works in the GUI.
Environment

OS: Windows 10
MQTTX version: 16.16 (Tested also with February and December release)

More detail
CLI Debug when using Cert + Key.  Notice protocol = mqtts on second line
 mqttjs connecting to an MQTT broker... +0ms
  mqttjs:client MqttClient :: options.protocol mqtts +0ms
  mqttjs:client MqttClient :: options.protocolVersion 4 +0ms
  mqttjs:client MqttClient :: options.username undefined +1ms
  mqttjs:client MqttClient :: options.keepalive 30 +0ms
  mqttjs:client MqttClient :: options.reconnectPeriod 1000 +0ms
  mqttjs:client MqttClient :: options.rejectUnauthorized false +1ms
  mqttjs:client MqttClient :: options.topicAliasMaximum undefined +0ms
  mqttjs:client MqttClient :: clientId ThisWillNotWork +0ms
  mqttjs:client MqttClient :: setting up stream +0ms
  mqttjs:client _setupStream :: calling method to clear reconnect +0ms
  mqttjs:client _clearReconnect : clearing reconnect timer +1ms
  mqttjs:client _setupStream :: using streamBuilder provided to client to create stream +0ms
  mqttjs calling streambuilder for mqtts +4ms
  mqttjs:tls port 8084 host broker.emqx.io rejectUnauthorized %b false +0ms
  mqttjs:client _setupStream :: pipe stream to writable stream +21ms
  mqttjs:client _setupStream: sending packet `connect` +0ms
  mqttjs:client sendPacket :: packet: { cmd: 'connect' } +1ms
  mqttjs:client sendPacket :: emitting `packetsend` +1ms
  mqttjs:client sendPacket :: writing to stream +0ms
  mqttjs:client sendPacket :: writeToStream result true +8ms
[5/21/2024] [8:01:40 PM] » ...  Connecting...
  mqttjs:client streamErrorHandler :: error read ECONNRESET +67ms
  mqttjs:client streamErrorHandler :: emitting error +0ms
[5/21/2024] [8:01:40 PM] » ×  Error: read ECONNRESET
    at TLSWrap.onStreamRead (node:internal/stream_base_commons:217:20)
  mqttjs:client end :: (ThisWillNotWork) +1ms
  mqttjs:client end :: cb? true +1ms
  mqttjs:client _clearReconnect : clearing reconnect timer +0ms
  mqttjs:client end :: (ThisWillNotWork) :: immediately calling finish +1ms
  mqttjs:client end :: (ThisWillNotWork) :: finish :: calling _cleanUp with force false +0ms
  mqttjs:client _cleanUp :: done callback provided for on stream close +1ms
  mqttjs:client _cleanUp :: forced? false +0ms
  mqttjs:client _cleanUp :: (ThisWillNotWork) :: call _sendPacket with disconnect packet +0ms
  mqttjs:client _sendPacket :: (ThisWillNotWork) ::  start +1ms
  mqttjs:client _sendPacket :: client not connected. Storing packet offline. +0ms
  mqttjs:client _storePacket :: packet: { cmd: 'disconnect' } +0ms
  mqttjs:client _storePacket :: cb? true +1ms
  mqttjs:client _cleanUp :: (ThisWillNotWork) :: removing stream `done` callback `close` listener +0ms
  mqttjs:client end :: finish :: calling process.nextTick on closeStores +0ms
  mqttjs:client end :: closeStores: closing incoming and outgoing stores +1ms
  mqttjs:client end :: closeStores: emitting end +0ms
  mqttjs:client end :: closeStores: invoking callback with args +1ms
  mqttjs:client nop :: undefined +0ms
  mqttjs:client (ThisWillNotWork)stream :: on close +1ms
  mqttjs:client flushVolatile :: deleting volatile messages from the queue and setting their callbacks as error function +0ms
  mqttjs:client stream: emit close to MqttClient +0ms
  mqttjs:client close :: connected set to `false` +1ms
  mqttjs:client close :: clearing connackTimer +0ms
  mqttjs:client close :: clearing ping timer +1ms
  mqttjs:client close :: calling _setupReconnect +0ms
  mqttjs:client _setupReconnect :: doing nothing... +0ms
[5/21/2024] [8:01:40 PM] » ×  Connection closed

CLI when using username + password.  Notice the second line indicates 'wss' and correctly forms the URI wss://broker.emqx.io:8084/mqtt
mqttjs connecting to an MQTT broker... +0ms
  mqttjs:client MqttClient :: options.protocol wss +0ms
  mqttjs:client MqttClient :: options.protocolVersion 4 +0ms
  mqttjs:client MqttClient :: options.username undefined +1ms
  mqttjs:client MqttClient :: options.keepalive 30 +0ms
  mqttjs:client MqttClient :: options.reconnectPeriod 1000 +0ms
  mqttjs:client MqttClient :: options.rejectUnauthorized false +0ms
  mqttjs:client MqttClient :: options.topicAliasMaximum undefined +1ms
  mqttjs:client MqttClient :: clientId ThisWillWork +0ms
  mqttjs:client MqttClient :: setting up stream +0ms
  mqttjs:client _setupStream :: calling method to clear reconnect +1ms
  mqttjs:client _clearReconnect : clearing reconnect timer +0ms
  mqttjs:client _setupStream :: using streamBuilder provided to client to create stream +0ms
  mqttjs calling streambuilder for wss +6ms
  mqttjs:ws streamBuilder +0ms
  mqttjs:ws createWebSocket +0ms
  mqttjs:ws protocol: MQTT 4 +0ms
  mqttjs:ws creating new Websocket for url: wss://broker.emqx.io:8084/mqtt and protocol: mqtt +0ms
  mqttjs:client _setupStream :: pipe stream to writable stream +27ms
  mqttjs:client _setupStream: sending packet `connect` +1ms
  mqttjs:client sendPacket :: packet: { cmd: 'connect' } +0ms

Thank you for your feedback. We have confirmed that this is a bug and it will be fixed in the next version.

This bug has already been addressed in a recent Pull Request. We will roll out the updated version as promptly as possible.

Thank you team, this is great news.  Is it expected that I wait until release is available to close this issue? Or do you close?

We will test after the release and close the issue once it's confirmed that there are no problems.

I built from main 19d4e69 and confirmed that issue is resolved.

Updated to https://github.com/emqx/MQTTX/releases/tag/v1.10.0. Thanks for your feedback.


CI: remove macos-12

The macos-12 CI is currently down on purpose and will be completely removed by Dec 3, 2024.
See:

actions/runner-images#10721.

Close #2695

vmnet test is failing 😞
+ limactl shell default iperf3 -s -1 -D
time="2024-11-04T16:04:01Z" level=warning msg="treating lima version \"4874db5\" from \"/Users/runner/.lima/default/lima-version\" as very latest release"
+ iperf3 -c <IP_ADDRESS>
iperf3: error - unable to connect to server - server may have stopped running or use a different port, firewall issue, etc.: No route to host

https://github.com/lima-vm/lima/actions/runs/11667264725/job/32485783777?pr=2840

might just need firewall rule update

Not sure how to update 😥
https://github.com/lima-vm/socket_vmnet/pull/63#discussion_r1828048639


[Overlay] Need to use latest version of overlay. Use model configuration to have needed model enabled all the time

EPAM AI DIAL chat version
0.9.0
What happened?
It appears that different people opened overlay from landing (prod landing) and there were different models assigned there.
Per Mikita its because of incorrect (rather old) configuration installed there.
Confidential information

[X] I confirm that do not share any confidential information

Overlay was updated on staging-landing page by @denys-kolomiitsev successfully


Container does not work with safe user (ftp)

Container does not start if use "ftp" user:
...
/usr/sbin/run-vsftpd.sh: line 24: /etc/vsftpd/virtual_users.txt: Permission denied
BDB5072 db_load: /etc/vsftpd/virtual_users.txt: reopen: No such file or directory
because of:
24	echo -e "${FTP_USER}\n${FTP_PASS}" > /etc/vsftpd/virtual_users.txt
can't write to file
-rw-r--r--. 1 root root    30 Aug 28 12:42 virtual_users.txt

Please, refer to vsftpd documentation: https://security.appspot.com/vsftpd.html

Experiencing the same issues. Any solution @pansa ?


Add badges

Codecov Report

Merging #3 (b23d003) into master (c51327f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   73.78%   73.78%
=======================================
  Files          13       13
  Lines         595      595
=======================================
  Hits          439      439
  Misses        156      156

Flag
Coverage Δ

unittests
73.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51327f...b23d003. Read the comment docs.

Codecov Report

Merging #3 (b23d003) into master (c51327f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   73.78%   73.78%
=======================================
  Files          13       13
  Lines         595      595
=======================================
  Hits          439      439
  Misses        156      156

Flag
Coverage Δ

unittests
73.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51327f...b23d003. Read the comment docs.


Ability to Comment on curent/working task

When working on tasks that might extend over a longer period of time, I often need to add comments or details on work completed.

Add comment to current task
tod task comment
(Returns a prompt to type and hit enter, data is submitted to "Add a comment" API and a comment is added to task with what is typed in)

What counts as the current task? Perhaps we need tod task list to show an id so that we can use the id here.
Or else we can use the task set with tod task next

Correct, this is for when using "tod task next"

It would be nice to add commenting to tod task edit as well but that's a seperate thing

Was thinking about this today - for my workflow, I'm not sure I actually need to add another comment option.
Instead, I'm thinking it would work better to just add "comment" to the menu options ("complete", "Skip", "quit") would be ideal.
That would allow for a task to become more of a quasi ticket-type item, where I can add comments to the item as I keep working on it .

That's something I could use it my workflow too.

Comment support feature levels:

Ability to comment (ADD) to active task - whether in Tod task next, as a separate Tod task comment, or the active task in Tod filter process (as a selection in the options)
Print the presence of comments back when displaying tasks as one of the printouts when displaying tasks (#387)
Expand the comment UI to allow for viewing comments/listing them
Expand the comments to support attachments (executing the URL for viewing/opening only; I don't think we need to support opening/expanding within CLI or adding attachments)


Create an app and link a mariadb database without building twice

I'd like to be able to deploy a new app with a link to a mariadb database without needing to build the app twice.
I've got a dependency loop like so, with each step depending on the one before in order to proceed.
build app -> link db -> get db access config -> configure app -> build app
It seems I need to build the app in a way where it won't work, and then again at the end in order to break the loop.  It can be time consuming.
If I first do a dokku create app, it'd be nice if that was enough to keep dokku mariadb:link app db happy, so I could just build the app once at the end.

OK, it's not a full build the second time round.  It's mostly cached.
It still would be nice if mariadb:link worked before the build, but it's not too critical.

Given the number of unaddressed issues, I'll close this.


gogs: 0.12.10 -> 0.13.0

Description of changes
Fixes CVE-2022-32174 and CVE-2022-2024
https://github.com/gogs/gogs/releases/tag/v0.13.0
https://github.com/gogs/gogs/releases/tag/v0.12.11

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.


set jit_origin to original client name when source parameter is set

Related issue: https://github.com/sensu/sensu/issues/1075

@roobert this will not work, as a JIT client is created only once, with no updates unless API POST /clients is used. jit_source needs to be in the check context, which also makes it easier to implement.


various user files are written to the /assets/ dir in the code directories

User and inversion generated files  and directories such as the SimPEG_PFInversion/ directory,  json, and zarr files are written to the /assets dir in the code base.
It would be preferable to have these files saved in the same dir as the input geoh5 file rather than in the code directory structure.
@domfournier

Great idea @craigmillernz
I can even add a folder selection widget, defaulting to the geoh5 director

Implemented on branch #7


Add static type generation

This change adds generation of a typespec for the enum module for use with dialyzer etc. It's behaviour can be tested by building and running dialyzer against this module:
defmodule TypeTest do
  import EctoHomoiconicEnum, only: [defenum: 2]

  defenum StatusEnum, registered: 0, active: 1, inactive: 2, archived: 3
  defenum RoleEnum, [:user, :moderator, :administrator]

  @spec status_fun(StatusEnum.t()) :: StatusEnum.t()
  defp status_fun(s), do: s

  @spec role_fun(RoleEnum.t()) :: RoleEnum.t()
  defp role_fun(r), do: r

  def callstatus, do: status_fun(:registered)
  def callstatus_bad, do: status_fun(:not_registered)

  def callrole, do: role_fun(:moderator)
  def callrole_bad, do: role_fun(:minion)
end

You will get type warnings on (and only on) the _bad suffixed functions.

Hi @tsutsu - is there anything I can do to help get this merged? I'm happy to help with maintenance of the library if you're short on time, since it's extremely useful to us.


Remove timestamp from .mag output files.

Fixes #179.
Signed-off-by: Tim 'mithro' Ansell<EMAIL_ADDRESS>

The timestamps are the only form of version control in magic, so removing them effectively removes version control.  My plan is to replace timestamping with a checksum, such that magic no longer cares when a file was created, but what the contents are.  I have not had the time to implement that yet.

@RTimothyEdwards - I'm unsure why Magic should care about the creation time of files that it isn't modifying (IE these files are installed read-only)?

@mithro :  That is likely a bug in magic.


filter path before searching

rather than after, to make sure we find host mpi even if mpi is also in an env
closes #8

Thank you!


advised not to use map_block()'s drop_axis on chunked axes of an array

[x] Closes #xxxx
[x] Tests added / passed
[x] Passes pre-commit run --all-files

cc: @jsignell
I forgot to add one important detail when describing map_blocks()'s drop_axis option in the docs.

@ParticularMiner Thanks for opening this PR! Noting that it's related to #8870.
The failing ubuntu-py3.10 is a known flaky test (#8062).
@jsignell Do you have thoughts on this?

Looks good to me! Thanks @ParticularMiner


Change default iOS device to iPhone 12

Building off of this PR: https://github.com/storybookjs/native/pull/69, I'd like to set the default iOS emulator device to the iPhone 12 because my storybook iOS components are compatible with iOS 14+. The iPhone 12's are the only devices on the device list that default to iOS 14.
Since there isn't really a way to switch emulator OS versions right now, having the emulator default to an iPhone 12 would be much more convenient to users viewing mobile components that support the latest iOS versions (instead of having to instruct them to switch devices using the device menu each time they view a new component).

📦 Published PR as canary version: 2.2.4-canary.70.754.0

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS>npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>yarn add<EMAIL_ADDRESS>

Thanks for the contribution!

:rocket: PR was released in v2.2.4 :rocket:


private messaging system with attached files

Hi, i looked into the exemple of the package but i don't know how to implement it to make a private messaging system where users can send private message (with attached files) to one or multiple users ? thanks for any help.

This question were raised earlier #162

Thanks for that what about the private message to one or multiple users ?

This package designed to provide you maximum freedom of implementing private\public threads logic by yourself. If you need  to make all the threads private - just hide them from users and check the ability to join the thread in your controllers to prevent hijacking :}
Question about one-to-one messaging was raised a lot of times. Just use search by words: private message or one-to-one.
In short: it's completely up to you to restrict users to join threads where more than 2 participants exists.

I've seen the questions but i didn't understand the answers, i'll search again. Thanks.

I managed to make the thread between 2 participant and now i'd like to know how to implement delete message or thread for a user and keep it for the other user ? thanks !

The Participants model has soft deletes enabled, so you can utilize that if you'd like. You also have the choice of reactivating all participants on new reply, or not.

how to use that ? i don't need reactivation in my application, juste show thread between 2 users in their inbox and if a user delete his message or a thread it's just in his inbox. sorry for my bad english.

You can use $thread->removeParticipant(Auth::id()); which will soft delete the participant record for the current user. This might look like:
Route::delete('{id}/destroy', ['as' => 'messages.destroy', 'uses' => 'MessagesController@destroy']);

public function destroy($id)
{
    try {
        $thread = Thread::findOrFail($id);
    } catch (ModelNotFoundException $e) {
        Session::flash('error_message', 'The thread with ID: ' . $id . ' was not found.');

        return redirect('messages');
    }

    $thread->removeParticipant(Auth::id());

    return redirect('messages');
}

Note: You'll want to make sure the current user has access to the thread that they're trying to delete themselves from especially if you are creating a private message system.
I'm going to close this as an issue for now, but feel free to update it if you have any other questions.

I used what you said and it's worked the message is deleted from the inbox of the users who choose to delet and still visible for the other user but when the other user send another message in the thread it's appear again in the inbox with the previous messages, any idea how to fix this ? thanks !

@Rostom22 are you using the example controller? If so, you'll want to remove this line if you don't want to reactivate participants on reply

Perfect ! it's working. thank you so much for your amazing package and your help !


Possibly add an 'English' genre

Allowed rhythms pretty much as for Irish or Scottish but add three-two.

Fixed by de32cfae94259cbfa1dd66c9835ccf1b19272044 which adds the English genre and its rhythms to the genreInsert tool code. Also added the temporary scala file englishGenreInsert to handle the upgrade. However, the live tradtunedb server now has authorization protection which doesn't allow index creation by a standard user.
The unique index on english can be added by logging into the mongoDB shell with admin authority, connecting to the tunedb database and typing:

db.english.createIndex ( { "tid": 1 }, { unique: true, name: "tuneKey" } )


Other Languages (Python, C#, Java) Q/A to FAQ

Added a section to the User Guide FAQ on how to interface Python, C# apps to Boost - including error handling, return values, exceptions. Shorter code for Java (no error handling or return values).

Did this content come from somewhere else?
Is ```cpp valid asciidoc?
Where is this content being rendered in boost.io?

Did this content come from somewhere else?
No, my ideas and research.
Is ```cpp valid asciidoc?
No, my bad, should be [source,cpp] - will change ASAP
Where is this content being rendered in boost.io?
Not there yet but should be in the User Guide FAQ - preview is here:
https://245.site-docs.prtest2.cppalliance.org/user-guide/faq.html

Oh... OK. I thought that content was for the website only. Sorry.
The content looks ok.
Just let me know when you've fixed the source code blocks then.

I find the newly added content very good.

@alandefreitas great - code blocks fixed/squashed @joaquintides thanks for the feedback!


Aggregate PR

Aggregate of the following PRs:
https://github.com/wildfly/wildfly/pull/16865
https://github.com/wildfly/wildfly/pull/16857
https://github.com/wildfly/wildfly/pull/16854
https://github.com/wildfly/wildfly/pull/16849
https://github.com/wildfly/wildfly/pull/16848
https://github.com/wildfly/wildfly/pull/16798
https://github.com/wildfly/wildfly/pull/16271

Individual PRs merged


Add zsh completion for 'docker {create,run,network connect} --link-lo…

Ref: #23415
@albers thx for the ping
@vincentbernat
Signed-off-by: Steve Durrheimer<EMAIL_ADDRESS>

LGTM

LGTM 🐮


Add delete trip button to TripListPage.

For each trip, like each trip card in the list should have a minus button or whatever.

This might want a confirmation dialog.


Fatal error initializing SatStack

FATAL Failed to initialize Bus                      error=bitcoind unreachable: invalid http POST response (nil), method: getblockchaininfo, id: 1, last error=Post "http://serdiogo.local/wallet/satstack": dial tcp: lookup serdiogo.local on [fe80::1%en14]:53: no such host
Hello, after warming up goes green, I get this message ...
anyone can help please ?
thanks in advance !

what kind of node are you running?

I'm on an iMac M1, with a VM (ubuntu) running umbrel.

Thank you, Umbrel usually uses Tor so you have to do this https://github.com/LedgerHQ/satstack#manual-setup-for-advanced-users replace serdiogo.local by the .onion address

Any issue, let me know, I will help :)

thanks again for your availability, that's awesome!
now I choose the rpc TOR from the node and put it on ledger live, but ledger now cannot sync with the node itself... is it another way around? :/

No, but this is fine, you won't be able to use Ledger Live to generate the config json file but you can do it manually as explained on GitHub and still make it work!

oh ok, I'll try for sure!
let me see and I come back to you!

iMac-de-Diogo ~ % cd scripts
cd: no such file or directory: scripts
when I try retrieve the scripts from the device my terminal gives this message ...

I already have the scripts external and internal but now can you simplify this step please ?
"Create a config file lss.json in your home directory. You can use this sample config file as a template.
Add "torproxy": "socks5://<IP_ADDRESS>:9050", to connect to a Tor client running locally so that satstack can reach a full node behind Tor. Replace the rpcurl with the .onion address of your node."
thanks a lot again.

I wrote the json file already, but now starting the satstack gives another error:
FATAL Failed to load config                         error=config file not found
what should I do next? thanks !

@serdiogo your json config file must be located in the same folder as satstack executble

it must be named lss.json

I did that but same problem...
FATAL Failed to load config error=config file not found

make sure the json is properly formatted, no missing { or }, things like that...

I wrote it again, now on visual studio code, saved as lss.json on satstack folder and nothing yet.

let's take this via email if this is fine with you and we will come back here if we have valuable information to share with the world but I suspect this is just an issue with your local setup, you can reach me at adrien.lacombe at ledger.com


Python3 compatibility

The only non-compatible code with python3 was the Exception catching, I think we can just remove the python3 branch and continue on with python2 and 3 compatible code @munnellg  as you suggested

Merge complete. Closing


[all] introduce sub-system for conditional features

This introduces conditional features that can be set in the configuration file like the following:
conditionalFeatures:
  type: list
  list:
    - type: match
      features:
        - com.spotify.heroic.cache_query
      condition:
        type: clientId
        clientId: foobar
    - type: match
      features:
        - com.spotify.heroic.cache_query
      condition:
        type: any
        conditions:
          - type: clientId
            clientId: foo
          - type: clientId
            clientId: bar

The current implementation permits enabling features depending on client id, or user agent. More can be added later.
This introduces two new interfaces in heroic-components:

RequestCondition - takes a QueryContext and returns a boolean if the context matches or not.
ConditionalFeatures - takes a QueryContext and returns a FeatureSet that should be applied to the existing set of features.

Codecov Report

Merging #314 into master will increase coverage by 0.05%.
The diff coverage is 69.09%.

@@             Coverage Diff              @@
##             master     #314      +/-   ##
============================================
+ Coverage     46.57%   46.62%   +0.05%
- Complexity     2535     2551      +16
============================================
  Files           615      624       +9
  Lines         16219    16273      +54
  Branches       1202     1203       +1
============================================
+ Hits           7554     7588      +34
- Misses         8214     8233      +19
- Partials        451      452       +1

Impacted Files
Coverage Δ
Complexity Δ

...java/com/spotify/heroic/requestcondition/Noop.java
0% <0%> (ø)
0 <0> (?)

...va/com/spotify/heroic/requestcondition/Module.java
100% <100%> (ø)
3 <3> (?)

.../java/com/spotify/heroic/dagger/PrimaryModule.java
88% <100%> (+0.5%)
14 <1> (+1)
:arrow_up:

...e/src/main/java/com/spotify/heroic/HeroicCore.java
71.14% <100%> (+0.07%)
30 <0> (ø)
:arrow_down:

...com/spotify/heroic/conditionalfeatures/Module.java
100% <100%> (ø)
3 <3> (?)

.../java/com/spotify/heroic/requestcondition/Any.java
33.33% <33.33%> (ø)
1 <1> (?)

.../java/com/spotify/heroic/requestcondition/All.java
33.33% <33.33%> (ø)
1 <1> (?)

.../com/spotify/heroic/conditionalfeatures/Match.java
50% <50%> (ø)
2 <2> (?)

...src/main/java/com/spotify/heroic/HeroicConfig.java
75% <60%> (-0.42%)
31 <1> (+1)

.../com/spotify/heroic/requestcondition/ClientId.java
66.66% <66.66%> (ø)
2 <2> (?)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a134be...06f8d1e. Read the comment docs.


DEV: acknowledge contributors to project

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.004%) to 91.932%

Files with Coverage Reduction
New Missed Lines
%

src/cogent3/core/alignment.py
1
93.76%

Totals

Change from base Build<PHONE_NUMBER>:
0.004%

Covered Lines:
30137

Relevant Lines:
32782

💛  - Coveralls