Aol/pvc move poc

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

[ ] Test A
[ ] Test B

/build

/build

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/pkg/liqo-controller-manager/storageprovisioner/localprovisioner.go b/pkg/liqo-controller-manager/storageprovisioner/localprovisioner.go
index 48f34d7..6515c7b 100644
--- a/pkg/liqo-controller-manager/storageprovisioner/localprovisioner.go
+++ b/pkg/liqo-controller-manager/storageprovisioner/localprovisioner.go
@@ -69,7 +69,7 @@ func (p *liqoLocalStorageProvisioner) provisionLocalPVC(ctx context.Context,
  			v1.ResourceStorage: options.PVC.Spec.Resources.Requests[v1.ResourceStorage],
  		},
  		PersistentVolumeSource: realPv.Spec.PersistentVolumeSource,
-			NodeAffinity: realPv.Spec.NodeAffinity,
+			NodeAffinity:           realPv.Spec.NodeAffinity,
  	},
  }

/build

/build

/build

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/liqoize.go b/cmd/liqoctl/cmd/liqoize.go
index 7a2fa4f..9792e9e 100644
--- a/cmd/liqoctl/cmd/liqoize.go
+++ b/cmd/liqoctl/cmd/liqoize.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/liqoize/handler.go b/pkg/liqoctl/liqoize/handler.go
index cf9aa38..646b5fb 100644
--- a/pkg/liqoctl/liqoize/handler.go
+++ b/pkg/liqoctl/liqoize/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package liqoize

import (
@@ -12,8 +26,8 @@ import (

// ClusterArgs encapsulates arguments required to liqoize a resource.
type ClusterArgs struct {
-	VolumeName    string
-	Namespace      string
+	VolumeName string
+	Namespace  string
}

// HandleLiqoizeVolumeCommand handles the liqoize volume command, configuring all the resources required to bring a volume to liqo.
diff --git a/pkg/liqoctl/liqoize/restic.go b/pkg/liqoctl/liqoize/restic.go
index e9f12f1..8a3de40 100644
--- a/pkg/liqoctl/liqoize/restic.go
+++ b/pkg/liqoctl/liqoize/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package liqoize

import (

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/liqoize.go b/cmd/liqoctl/cmd/liqoize.go
index 7a2fa4f..9792e9e 100644
--- a/cmd/liqoctl/cmd/liqoize.go
+++ b/cmd/liqoctl/cmd/liqoize.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/liqoize/handler.go b/pkg/liqoctl/liqoize/handler.go
index cf9aa38..646b5fb 100644
--- a/pkg/liqoctl/liqoize/handler.go
+++ b/pkg/liqoctl/liqoize/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package liqoize

import (
@@ -12,8 +26,8 @@ import (

// ClusterArgs encapsulates arguments required to liqoize a resource.
type ClusterArgs struct {
-	VolumeName    string
-	Namespace      string
+	VolumeName string
+	Namespace  string
}

// HandleLiqoizeVolumeCommand handles the liqoize volume command, configuring all the resources required to bring a volume to liqo.
diff --git a/pkg/liqoctl/liqoize/restic.go b/pkg/liqoctl/liqoize/restic.go
index e9f12f1..8a3de40 100644
--- a/pkg/liqoctl/liqoize/restic.go
+++ b/pkg/liqoctl/liqoize/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package liqoize

import (

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/move.go b/cmd/liqoctl/cmd/move.go
index 2285e7a..cb5fd56 100644
--- a/cmd/liqoctl/cmd/move.go
+++ b/cmd/liqoctl/cmd/move.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/move/handler.go b/pkg/liqoctl/move/handler.go
index ad3d491..26415ea 100644
--- a/pkg/liqoctl/move/handler.go
+++ b/pkg/liqoctl/move/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restic.go b/pkg/liqoctl/move/restic.go
index a5b779e..9ca80f7 100644
--- a/pkg/liqoctl/move/restic.go
+++ b/pkg/liqoctl/move/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/snapshotter.go b/pkg/liqoctl/move/snapshotter.go
index cf25096..1e3ec48 100644
--- a/pkg/liqoctl/move/snapshotter.go
+++ b/pkg/liqoctl/move/snapshotter.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/volumeutils.go b/pkg/liqoctl/move/volumeutils.go
index a9d9268..02305cf 100644
--- a/pkg/liqoctl/move/volumeutils.go
+++ b/pkg/liqoctl/move/volumeutils.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/move.go b/cmd/liqoctl/cmd/move.go
index 2285e7a..cb5fd56 100644
--- a/cmd/liqoctl/cmd/move.go
+++ b/cmd/liqoctl/cmd/move.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/move/handler.go b/pkg/liqoctl/move/handler.go
index 5d39035..867b593 100644
--- a/pkg/liqoctl/move/handler.go
+++ b/pkg/liqoctl/move/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restic.go b/pkg/liqoctl/move/restic.go
index a5b779e..9ca80f7 100644
--- a/pkg/liqoctl/move/restic.go
+++ b/pkg/liqoctl/move/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restorer.go b/pkg/liqoctl/move/restorer.go
index 3fee2a2..afb7bf5 100644
--- a/pkg/liqoctl/move/restorer.go
+++ b/pkg/liqoctl/move/restorer.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/snapshotter.go b/pkg/liqoctl/move/snapshotter.go
index c54e4a7..7ca568c 100644
--- a/pkg/liqoctl/move/snapshotter.go
+++ b/pkg/liqoctl/move/snapshotter.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0

/build

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/move.go b/cmd/liqoctl/cmd/move.go
index 47c182d..f57af28 100644
--- a/cmd/liqoctl/cmd/move.go
+++ b/cmd/liqoctl/cmd/move.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/move/handler.go b/pkg/liqoctl/move/handler.go
index 2516b98..f4a6d72 100644
--- a/pkg/liqoctl/move/handler.go
+++ b/pkg/liqoctl/move/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restic.go b/pkg/liqoctl/move/restic.go
index a5b779e..9ca80f7 100644
--- a/pkg/liqoctl/move/restic.go
+++ b/pkg/liqoctl/move/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restorer.go b/pkg/liqoctl/move/restorer.go
index 4113517..e94965b 100644
--- a/pkg/liqoctl/move/restorer.go
+++ b/pkg/liqoctl/move/restorer.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
@@ -51,8 +65,8 @@ func createRestorerJob(ctx context.Context, cl client.Client,
  				},
  				Containers: []corev1.Container{
  					{
-							Name:  "liqo-snapshotter",
-							Image: "aleoli/snapshotter:latest",
+							Name:            "liqo-snapshotter",
+							Image:           "aleoli/snapshotter:latest",
  						ImagePullPolicy: corev1.PullIfNotPresent,
  						Args: []string{
  							fmt.Sprintf("--repo=%s", resticRepositoryUrl),
diff --git a/pkg/liqoctl/move/snapshotter.go b/pkg/liqoctl/move/snapshotter.go

/build

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/move.go b/cmd/liqoctl/cmd/move.go
index 47c182d..f57af28 100644
--- a/cmd/liqoctl/cmd/move.go
+++ b/cmd/liqoctl/cmd/move.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/move/handler.go b/pkg/liqoctl/move/handler.go
index 2516b98..f4a6d72 100644
--- a/pkg/liqoctl/move/handler.go
+++ b/pkg/liqoctl/move/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restic.go b/pkg/liqoctl/move/restic.go
index a5b779e..9ca80f7 100644
--- a/pkg/liqoctl/move/restic.go
+++ b/pkg/liqoctl/move/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restorer.go b/pkg/liqoctl/move/restorer.go
index 4113517..e94965b 100644
--- a/pkg/liqoctl/move/restorer.go
+++ b/pkg/liqoctl/move/restorer.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
@@ -51,8 +65,8 @@ func createRestorerJob(ctx context.Context, cl client.Client,
  				},
  				Containers: []corev1.Container{
  					{
-							Name:  "liqo-snapshotter",
-							Image: "aleoli/snapshotter:latest",
+							Name:            "liqo-snapshotter",
+							Image:           "aleoli/snapshotter:latest",
  						ImagePullPolicy: corev1.PullIfNotPresent,
  						Args: []string{
  							fmt.Sprintf("--repo=%s", resticRepositoryUrl),
diff --git a/pkg/liqoctl/move/snapshotter.go b/pkg/liqoctl/move/snapshotter.go

/build

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/move.go b/cmd/liqoctl/cmd/move.go
index 47c182d..f57af28 100644
--- a/cmd/liqoctl/cmd/move.go
+++ b/cmd/liqoctl/cmd/move.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/move/handler.go b/pkg/liqoctl/move/handler.go
index 2516b98..f4a6d72 100644
--- a/pkg/liqoctl/move/handler.go
+++ b/pkg/liqoctl/move/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restic.go b/pkg/liqoctl/move/restic.go
index a5b779e..9ca80f7 100644
--- a/pkg/liqoctl/move/restic.go
+++ b/pkg/liqoctl/move/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restorer.go b/pkg/liqoctl/move/restorer.go
index 4113517..e94965b 100644
--- a/pkg/liqoctl/move/restorer.go
+++ b/pkg/liqoctl/move/restorer.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
@@ -51,8 +65,8 @@ func createRestorerJob(ctx context.Context, cl client.Client,
  				},
  				Containers: []corev1.Container{
  					{
-							Name:  "liqo-snapshotter",
-							Image: "aleoli/snapshotter:latest",
+							Name:            "liqo-snapshotter",
+							Image:           "aleoli/snapshotter:latest",
  						ImagePullPolicy: corev1.PullIfNotPresent,
  						Args: []string{
  							fmt.Sprintf("--repo=%s", resticRepositoryUrl),
diff --git a/pkg/liqoctl/move/snapshotter.go b/pkg/liqoctl/move/snapshotter.go

/build

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/move.go b/cmd/liqoctl/cmd/move.go
index 47c182d..f57af28 100644
--- a/cmd/liqoctl/cmd/move.go
+++ b/cmd/liqoctl/cmd/move.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/move/handler.go b/pkg/liqoctl/move/handler.go
index 2516b98..f4a6d72 100644
--- a/pkg/liqoctl/move/handler.go
+++ b/pkg/liqoctl/move/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restic.go b/pkg/liqoctl/move/restic.go
index a5b779e..9ca80f7 100644
--- a/pkg/liqoctl/move/restic.go
+++ b/pkg/liqoctl/move/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restorer.go b/pkg/liqoctl/move/restorer.go
index 4113517..e94965b 100644
--- a/pkg/liqoctl/move/restorer.go
+++ b/pkg/liqoctl/move/restorer.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
@@ -51,8 +65,8 @@ func createRestorerJob(ctx context.Context, cl client.Client,
  				},
  				Containers: []corev1.Container{
  					{
-							Name:  "liqo-snapshotter",
-							Image: "aleoli/snapshotter:latest",
+							Name:            "liqo-snapshotter",
+							Image:           "aleoli/snapshotter:latest",
  						ImagePullPolicy: corev1.PullIfNotPresent,
  						Args: []string{
  							fmt.Sprintf("--repo=%s", resticRepositoryUrl),
diff --git a/pkg/liqoctl/move/snapshotter.go b/pkg/liqoctl/move/snapshotter.go

/build

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/move.go b/cmd/liqoctl/cmd/move.go
index 47c182d..f57af28 100644
--- a/cmd/liqoctl/cmd/move.go
+++ b/cmd/liqoctl/cmd/move.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/move/handler.go b/pkg/liqoctl/move/handler.go
index 2516b98..f4a6d72 100644
--- a/pkg/liqoctl/move/handler.go
+++ b/pkg/liqoctl/move/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restic.go b/pkg/liqoctl/move/restic.go
index a5b779e..9ca80f7 100644
--- a/pkg/liqoctl/move/restic.go
+++ b/pkg/liqoctl/move/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restorer.go b/pkg/liqoctl/move/restorer.go
index 4113517..e94965b 100644
--- a/pkg/liqoctl/move/restorer.go
+++ b/pkg/liqoctl/move/restorer.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
@@ -51,8 +65,8 @@ func createRestorerJob(ctx context.Context, cl client.Client,
  				},
  				Containers: []corev1.Container{
  					{
-							Name:  "liqo-snapshotter",
-							Image: "aleoli/snapshotter:latest",
+							Name:            "liqo-snapshotter",
+							Image:           "aleoli/snapshotter:latest",
  						ImagePullPolicy: corev1.PullIfNotPresent,
  						Args: []string{
  							fmt.Sprintf("--repo=%s", resticRepositoryUrl),
diff --git a/pkg/liqoctl/move/snapshotter.go b/pkg/liqoctl/move/snapshotter.go

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/move.go b/cmd/liqoctl/cmd/move.go
index 47c182d..f57af28 100644
--- a/cmd/liqoctl/cmd/move.go
+++ b/cmd/liqoctl/cmd/move.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/move/handler.go b/pkg/liqoctl/move/handler.go
index 765170f..4bdaa70 100644
--- a/pkg/liqoctl/move/handler.go
+++ b/pkg/liqoctl/move/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/offloading.go b/pkg/liqoctl/move/offloading.go
index 7b763c2..0f22f7a 100644
--- a/pkg/liqoctl/move/offloading.go
+++ b/pkg/liqoctl/move/offloading.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restic.go b/pkg/liqoctl/move/restic.go
index 35ef28a..226ca95 100644
--- a/pkg/liqoctl/move/restic.go
+++ b/pkg/liqoctl/move/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restorer.go b/pkg/liqoctl/move/restorer.go
index 6a1472f..93ad7e3 100644
--- a/pkg/liqoctl/move/restorer.go
+++ b/pkg/liqoctl/move/restorer.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/cmd/liqoctl/cmd/move.go b/cmd/liqoctl/cmd/move.go
index 47c182d..f57af28 100644
--- a/cmd/liqoctl/cmd/move.go
+++ b/cmd/liqoctl/cmd/move.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package cmd

import (
diff --git a/pkg/liqoctl/move/handler.go b/pkg/liqoctl/move/handler.go
index 765170f..4bdaa70 100644
--- a/pkg/liqoctl/move/handler.go
+++ b/pkg/liqoctl/move/handler.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/offloading.go b/pkg/liqoctl/move/offloading.go
index 7b763c2..0f22f7a 100644
--- a/pkg/liqoctl/move/offloading.go
+++ b/pkg/liqoctl/move/offloading.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restic.go b/pkg/liqoctl/move/restic.go
index 35ef28a..226ca95 100644
--- a/pkg/liqoctl/move/restic.go
+++ b/pkg/liqoctl/move/restic.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/restorer.go b/pkg/liqoctl/move/restorer.go
index 6a1472f..93ad7e3 100644
--- a/pkg/liqoctl/move/restorer.go
+++ b/pkg/liqoctl/move/restorer.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:

/build

/test

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/pkg/liqoctl/move/movevolume_test.go b/pkg/liqoctl/move/movevolume_test.go
index 6402ac3..e722093 100644
--- a/pkg/liqoctl/move/movevolume_test.go
+++ b/pkg/liqoctl/move/movevolume_test.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2022 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
@@ -33,7 +47,7 @@ var _ = Context("Move Volumes", func() {
  		ObjectMeta: metav1.ObjectMeta{
  			Name:      name,
  			Namespace: namespace,
-				UID: types.UID(name),
+				UID:       types.UID(name),
  		},
  	}
  }
@@ -78,7 +92,7 @@ var _ = Context("Move Volumes", func() {

  	return &corev1.Node{
  		ObjectMeta: metav1.ObjectMeta{
-				Name: name,
+				Name:   name,
  			Labels: labels,
  		},
  	}
@@ -103,24 +117,24 @@ var _ = Context("Move Volumes", func() {
  		expectedErr: BeNil(),
  		expected:    BeNil(),
  	}), Entry("should return the pod that is mounting the volume", mounterTestcase{
-			client:      fake.NewClientBuilder().WithObjects(
+			client: fake.NewClientBuilder().WithObjects(
  			newPod("pod1", "default", []string{"pvc1"}),
  			newPod("pod2", "default", []string{}),
  			newPod("pod3", "default", []string{"pvc3"}),
  			newPod("pod3", "ns2", []string{"pvc3"}),
  			newPod("pod4", "default", []string{"pvc4"}),
-				).Build(),
+			).Build(),
  		pvc:         newPvc("pvc3", "default"),
  		expectedErr: BeNil(),
  		expected:    &matchObject{name: "pod3", namespace: "default"},
  	}))

  	type isLocalVolumeTestcase struct {
-			client      client.Client
-			pvc         *corev1.PersistentVolumeClaim
-			expectedErr OmegaMatcher
-			expectedLocal    OmegaMatcher
-			expectedNode OmegaMatcher
+			client        client.Client
+			pvc           *corev1.PersistentVolumeClaim
+			expectedErr   OmegaMatcher
+			expectedLocal OmegaMatcher
+			expectedNode  OmegaMatcher
  	}

  	DescribeTable("isLocalVolume function", func(c isLocalVolumeTestcase) {
@@ -129,29 +143,29 @@ var _ = Context("Move Volumes", func() {
  		Expect(local).To(c.expectedLocal)
  		Expect(node).To(c.expectedNode)
  	}, Entry("should return error if no node annotation is found", isLocalVolumeTestcase{
-			client:      fake.NewClientBuilder().Build(),
-			pvc:         newPvc("pvc1", "default"),
-			expectedErr: HaveOccurred(),
+			client:        fake.NewClientBuilder().Build(),
+			pvc:           newPvc("pvc1", "default"),
+			expectedErr:   HaveOccurred(),
  		expectedLocal: BeFalse(),
-			expectedNode: BeNil(),
+			expectedNode:  BeNil(),
  	}), Entry("should return true if the node is local", isLocalVolumeTestcase{
-			client:      fake.NewClientBuilder().WithObjects(newNode("node1", true)).Build(),
-			pvc:         addNodeMount(newPvc("pvc1", "default"), "node1"),
-			expectedErr: BeNil(),
+			client:        fake.NewClientBuilder().WithObjects(newNode("node1", true)).Build(),
+			pvc:           addNodeMount(newPvc("pvc1", "default"), "node1"),
+			expectedErr:   BeNil(),
  		expectedLocal: BeTrue(),
-			expectedNode: &matchObject{name: "node1"},
+			expectedNode:  &matchObject{name: "node1"},
  	}), Entry("should return false if the node is not local", isLocalVolumeTestcase{
-			client:      fake.NewClientBuilder().WithObjects(newNode("node1", false)).Build(),
-			pvc:         addNodeMount(newPvc("pvc1", "default"), "node1"),
-			expectedErr: BeNil(),
+			client:        fake.NewClientBuilder().WithObjects(newNode("node1", false)).Build(),

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/pkg/liqoctl/move/movevolume_test.go b/pkg/liqoctl/move/movevolume_test.go
index eea4c64..ea1d195 100644
--- a/pkg/liqoctl/move/movevolume_test.go
+++ b/pkg/liqoctl/move/movevolume_test.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2022 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/suite_test.go b/pkg/liqoctl/move/suite_test.go
index f1562ff..58f11f3 100644
--- a/pkg/liqoctl/move/suite_test.go
+++ b/pkg/liqoctl/move/suite_test.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2022 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/pkg/liqoctl/move/movevolume_test.go b/pkg/liqoctl/move/movevolume_test.go
index b956eec..03d4bf8 100644
--- a/pkg/liqoctl/move/movevolume_test.go
+++ b/pkg/liqoctl/move/movevolume_test.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2022 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (
diff --git a/pkg/liqoctl/move/suite_test.go b/pkg/liqoctl/move/suite_test.go
index f1562ff..58f11f3 100644
--- a/pkg/liqoctl/move/suite_test.go
+++ b/pkg/liqoctl/move/suite_test.go
@@ -1,3 +1,17 @@
+// Copyright 2019-2022 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
package move

import (

The generated artifacts appear to be out-of-date.
Please, ensure you are using the correct version of the generators (eg. controller-gen) and re-run:
make generate

Here it is an excerpt of the diff:
diff --git a/test/e2e/cruise/basic_test.go b/test/e2e/cruise/basic_test.go
index c2827e5..b35c61b 100644
--- a/test/e2e/cruise/basic_test.go
+++ b/test/e2e/cruise/basic_test.go
@@ -341,7 +341,7 @@ var _ = Describe("Liqo E2E", func() {
  			By("Moving the statefulset to the virtual node")
  			liqoctl := os.Getenv("LIQOCTL")
  			Expect(liqoctl).ToNot(BeEmpty())
-				cmd := exec.Command(liqoctl,  // nolint:gosec // running in a trusted environment
+				cmd := exec.Command(liqoctl, // nolint:gosec // running in a trusted environment
  				"move", "volume", originPvc.Name, "-n", namespace, "--node", virtualNodesList.Items[0].Name)
  			cmd.Stdout = GinkgoWriter
  			cmd.Stderr = GinkgoWriter


Save high quality images from GUI

When using the GUI, there is no way to save high resolution images appropriate for publication. As a user, having to go to the command line to save a good image is an inconvenience.
A download button would be a great addition.

yes, I think this should be doable - I believe the javascript library supports this functionality, and I'll look into it.

image download button added to the interface


tablet support

tablet apple air 2 certain positions will click the ending of the tooltip.

fixed by adding triangleOffset closing the issue.


Middle mouse button opens two tabs instead of one

When using the dropdown menu and middle-clicking a course, two new tabs of that course are opened.
I would expect and prefer if only one would be created.

Fixed in v1.8.11


Upgrade naga dependency to 0.19

The shaders crate is primarily for Skia integration and is not directly consumed by Vello, though it should be (see #467). It definitely makes sense to bump this, as my new shader code makes use of constants and so that's a source of warnings on #496. It's possible that this will break some stuff on the Skia side, so it does make sense for @armansito to take another look.
Also, our policy is for the author to merge, so I'll turn on write access for @sepcnt.
Thanks!

I'll approve, seems straight forward. However I think someone who works with the shaders more should approve too, e.g. @armansito . Was there a reason we were on naga 0.13? That seems... very old. I also assumed naga was included by wgpu already (if not as a feature?), so i'm equally confused.

They skipped from release 0.14 to 0.19 when they folded it in with the wgpu release train and versioning.

Thank you for the change, the naga dependency was just stale and needed to be updated.


Disable 'New Unit' function

In production environment,  units deployment are usually managed by infrastructure orchestration  code.  Would it possible to make "New Unit" an optional function in the UI?
Thanks! Great job to provide this tool. It would be very useful to support team, if we could disable the new unit submission from the UI.

Good idea! Thanks.

:+1:
make it configurable via environment variable


[Social Media] DevNexus Talk - Jakarta EE and MicroProfile Highlights

MP DevRel Branding Resources Community Support
MicroProfiler
Edwin Derks
Twitter: @edwinderks
Josh Juneau
Twitter: @javajuneau
Event
Link to the event/conference/Session
Schedule
2023/04/4-6
Media Description
Join @Java_Champions @edwinderks & @javajuneau on stage at https://github.com/devnexus April 4-6th! Their talk shares @MicroProfileIO & @JakartaEE important features through code examples and real-life scenarios.
Session details: https://devnexus.org/presentations/jakarta-ee-and-microprofile-highlights/
We hope to see you there!
Design Card (for MicroProfile designer)
Minimal requirements highlight the MicroProfiler & the Organizers
Notes
It is a duo session together with Josh Juneau, also a Java Champion.

@ederks85 I am glad you found the documentation helpful :) Always there under Resources page in MP.io!
Now, the media message requires adjustments b/c it comes from MP social and not your personal accounts.  Please review and adjust as you see fit the message below. I used the abstract to insert a more focused message about your session.
In the future when you submit messages about your sessions, always remember to answer why should I skip other sessions to attend yours?. The opportunity costs to the attendee needs to be stated in the message for the message to be a valuable call to action, specially something that amplify your contributions to MP and your desired to share that knowledge via events. Stay awesome!
Join @Java_Champions @edwinderks & @javajuneau on stage at @devnexus April 4-6th! Their talk shares @MicroProfileIO & @jakartaee's important features  through a number of examples examples and usage of APIs' real-life scenarios.
https://devnexus.org/presentations/jakarta-ee-and-microprofile-highlights/
#SharingIsCaring #OSS💛

Thanks @aeiras for the review, I hope it is now in a preferred state.

@ederks85 I am glad you found the documentation helpful :) Always there under Resources page in MP.io!
Now, the media message requires adjustments b/c it comes from MP social and not your personal accounts. Please review and adjust as you see fit the message below. I used the abstract to insert a more focused message about your session. In the future when you submit messages about your sessions, always remember to answer why should I skip other sessions to attend yours?. The opportunity costs to the attendee needs to be stated in the message for the message to be a valuable call to action, specially something that amplify your contributions to MP and your desire to share that knowledge via events. Stay awesome!
Join @Java_Champions @edwinderks & @javajuneau on stage at @devnexus April 4-6th! Their talk shares @MicroProfileIO & @jakartaee's important features through a number of code examples and the usage of APIs' real-life scenarios.
https://devnexus.org/presentations/jakarta-ee-and-microprofile-highlights/
#SharingIsCaring #OSS💛

@rstjames this is the final media message.

All scheduled

Thank you, @rstjames!
Can you confirm that the posts are scheduled 4 times and not 2? Please check the advice on how to post them, 1 Feb, 2 March and 1 the day of the session.

They are set to go out 4 time, But are more spread out evening on mid months and day before the conference.


Refactored the Search bar

Hi @Braden-Preston, here's a quick refactor on the search bar.  I've also added a 'Set-Aside' status. Will provide logical support later.

Needs work.


react to 'docker rename'

The docker rename command changes a container's name, so if weave has used the name in DNS (i.e. the hostname was not explicitly set) then weave should update the entry with the new name.
Noting that Docker doesn't do this itself (yet) - https://github.com/docker/docker/issues/16485

Related to #1374


proto can't parse int64 correctly

When i received a message from java server(long type).I found that the Int64 field is a negative number,like -948372833,the correct value should be 30 Billion or larger.
is that a bug?

Unfortunatly, Int64 is not well tested. On which platform? Flash?

yes.on flash platform.


Test for metric files are not working as expected

The tests for the metrics file are broken, because some parts are skipped as comments.

Closing because I was overlooking the implementation


./airprint_bridge.sh -t failed

when I run ./airprint_bridge.sh -t, it shows:
Listing local shared printers...
lpoptions：无法添加打印机或实例：Undefined error: 0
No shared printers found.
Test aborted: No suitable printers found.

run lpoptions directly:
bing@xs-macmini AirPrint_Bridge % lpoptions
copies=1 device-uri=usb://Brother/HL-2260D?serial=E80121E0N234189 finishings=3 job-cancel-after=10800 job-hold-until=no-hold job-priority=50 job-sheets=none,none marker-change-time=1733152708 marker-colors=#000000 marker-levels=70 marker-names=Black marker-types=toner number-up=1 printer-commands=ReportLevels,PrintSelfTestPage,PJLBidirectional,PJLWrite,PJLRead printer-info='Brother HL-2260D' printer-is-accepting-jobs=true printer-is-shared=true printer-is-temporary=false printer-location=xs-macmini printer-make-and-model='Brother HL-2260D CUPS' printer-state=3 printer-state-change-time=1733545623 printer-state-reasons=none printer-type=8425556 printer-uri-supported=ipp://localhost/printers/Brother_HL_2260D

this is my printer:

you are a hero to share a software like this.

Download the latest version, i made a change enforcing English locale for lpstat parsing. Let me know if this resolves your issue if not can you post the output of  lpstat -p

@ice6 any luck?

@sapireli thank you. no luck, because my system is chinese language. the lpstat -p command output like this:
打印机Brother_HL_2260D闲置，启用时间始于Sat Dec 14 21:22:33 2024

so awk '{print $2}' can not parse my machine's name correctly.
I tried the following commands which is given by chatgpt
LANG=C lpstat -p
LANG=en_US.UTF-8 lpstat -p
LC_ALL=C lpstat -p

the terminal still output same message.

@sapireli
according to this link, I found the solution in MacOS.
https://apple.stackexchange.com/questions/474971/change-output-language-of-internal-commands-like-lpstat
SOFTWARE= LANG=C lpstat -a

it works!
I install the software successfully and it works!
Now, I can print from iOS device through my old mac mini 2014.
thanks for this wonderful tool.


Revert "fix: "dependency_version_2": true"

Reverts terraform-ibm-modules/terraform-ibm-landing-zone#924

/run pipeline

:tada: This PR is included in version 6.4.2 :tada:
The release is available on:

GitHub release
v6.4.2

Your semantic-release bot :package::rocket:


Goalkeeper bug in the built-in AI

When the AI learns to lob in multi agents, any strategy becomes meaningless😂.
Maybe give the goalkeeper more bounce?
you can watch some replay in this link https://www.bilibili.com/video/BV1n54y1V7bw

We didn't control the goalkeeper because we couldn't execute a “SAVE BALL” action

The bad thing is that you can use the high pass action to kick the ball into the goal from a midfield position if your teammate is standing next to the goal. In this case, the high pass action is much more powerful than the shot action.


Use Github actions to check for formatting and analysis errors

If we setup Github actions for continuous integration, we can check PR's automatically for analysis errors, formatting and run tests before merging those.

This has been added.


Go through Website. Get an understanding of how the website is working.  Which plugins are used for what? Which Plugins are not being used? Which Plugins are not setup correctly? Create a documentation in Confluence with an overview of the Plugin Name, ASRG Use Case, and special settings.

@heldyboy  I have went through with the website and here is the link of the website overview document:
You can see the details of the plugins
(https://internal-confluence.asrg.io/display/WEB/Website+Overview)


Update geographic.md

Grammar check + Minor corrections
Description of the change:Grammar check + Minor corrections
Reason for the change*:
Link to original source:

Closes #

Hello @dharmendra-lingaiah,Thanks again for the PR! It's HACKTOBERFEST! We want to show our appreciation by sending                                              you some special Hacktoberfest swag. If you have not already, could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


translate README.md to Chinese 🇨🇳

Would that repo like to Add a link to Chinese README.md
https://github.com/chinanf-boy/TypeScript-Node-Starter
Or pull the README.zh.md file and link this
😊

@viveksdf how what , 🤔?

@chinanf-boy how to add link

Before https://github.com/Microsoft/TypeScript-Node-Starter#pre-reqs sections
Like Add ## Translation
## Translation

[中文](https://github.com/chinanf-boy/TypeScript-Node-Starter)

or Plan B

README.zh.md from My Pull Request

## Translation

[中文](https://github.com/Microsoft/TypeScript-Node-Starter/blob/master/README.zh.md)

@chinanf-boy Done taken your file and done a pull request on
https://github.com/Microsoft/TypeScript-Node-Starter

@viveksdf Done


Add all-contributors to boilerplate

https://github.com/all-contributors/all-contributors

Maybe this will reside in the boilerplate repo :thinking:

Yeah, moved it there: https://github.com/bence-toth/react-library-boilerplate/issues/87


TASK: create UI design

create a rough sketch of how the new site ought to look like

this issue is ow being closed


Generics inference of type (static) intersection on instance shape

I'v build a nice library for composition of types (mixin) in a dynamic way so the bookkeeping overhead of having to write stand-in members is not needed. (the lib also has some other features and customisation for composition).
It works great but I have one last bookkeeping overhead that bothers me, The lib requires to explicitly set the Type parameters since I can't get it to work when I let typescript infer the types.
Here's an example of what i'm facing:
TypeScript Version:
1.8.9
Code
A and B are "example" classes, we will use them for demonstration.
Each have one static member and one instance member, we will use them verify the output when mixin them together.
class A {
    static STATIC_A: string = 'A';
    instanceA: string = 'A';
    constructor() { }
}
class B {
    static STATIC_B: string = 'B';
    instanceB: string = 'B';
}

A "naive" approach using a simple function:
    function mergeTypes<T, Z>(type1: T, type2: Z): T & Z {
        // Do some work to mixin the types.
        return <any>{};
    }
    let AB = mergeTypes(A, B);  // Inferred AB: typeof A & typeof B
    let ab = new AB();          // Inferred ab: A

    AB.STATIC_A;    // Compiler OK
    AB.STATIC_B;    // Compiler OK
    ab.instanceA;   // Compiler OK
    ab.instanceB;   // Compiler ERR: Property 'instanceB' does not exist on type 'A'

Conclusion: Intersection of static types will not propagate to the instance shape.

A more explicit approach with a control unit and state.
// Define a contract to bind an instance type param (T/Z) to its static "parent" (TType/ZType)
interface ConcreteTypeOf<T> extends Function { new (...args): T; }

// Explicitly say what we are dealing with:
class MergeTypes<T, TType extends ConcreteTypeOf<T>, Z, ZType extends ConcreteTypeOf<Z>> {
    constructor(private type1: TType, private type2: ZType) {}

    // We return a constructor for T & Z and intersect static members.
    merge(): ConcreteTypeOf<T & Z> & TType & ZType {
        // Do some work to mixin the types.
        return <any>{};
    }
}

An implicit attempt first, let the compiler infer for us
let AB = new MergeTypes(A, B).merge();  // Inferred AB: ConcreteTypeOf<{}> & typeof A & typeof B
let ab = new AB();                      // Inferred ab: {}

AB.STATIC_A;    // Compiler OK
AB.STATIC_B;    // Compiler OK
ab.instanceA;   // Compiler ERR: Property 'instanceA' does not exist on type '{}'
ab.instanceB;   // Compiler ERR: Property 'instanceB' does not exist on type '{}'

It turns out that the compiler infers ConcreteTypeOf<T & Z>  to be ConcreteTypeOf<{}>, WHY?

Finally, a working version, but we need to explicitly express what we want:
let AB = new MergeTypes<A, typeof A, B, typeof B>(A, B).merge();    // Inferred AB: ConcreteTypeOf<A & B> & typeof A & typeof B
let ab = new AB();                                                  // Inferred ab: A & B

AB.STATIC_A;    // Compiler OK
AB.STATIC_B;    // Compiler OK
ab.instanceA;   // Compiler OK
ab.instanceB;   // Compiler OK

If i'll be able to remove the need to explicitly express the type I will be able to have an easy API for composition/mixin what ever, that can create type's on the fly and save a reference for them (compile time type reference) as if they were defined expressively.

BTW, I know that I'm sending the static type to the constructor so the compiler only "knows" about TType since T is not part of the constructor.
This is probably why T&Z = {}
I just don't know how to "extract" the instance shape from a static type in a generic form.
i.e: If I have class A{} I know that A is the instance shape and typeof A is the anonymous static type but when 'typeof A` is a type parameter (T) the compiler doesn't have an explicit contract to infer instance shape from it's static type.

@RyanCavanaugh I'v love to hear your insights on this.

It sounds like you potentially want to pass in the prototypes of each constructor, or you want to write
function mergeTypes<T, Z>(type1: { prototype: T }, type2: { prototype: Z }): new () => T & Z {
    // Do some work to mixin the types.
    return <any>{};
}

Also see some of the discussion that went on over at #4559.

@DanielRosenwasser
In your example, T and Z are the instance type.
When you return new () => T&Z you actually return a "blank" type that only "knows" to creates an instance of the mixed in T&Z however all static metadata about this type is lost.
This is a complex issue, so I will try to simplify a bit, I will only address the core issue I see:
// Simple class that holds a Type.
// Has 2 type param's that are bound and represent both "types" of a class.
class TypeWrapper<T, TType extends new () => T> {
    constructor(private _type: TType) {}
    getType(): TType {
        return this._type;
    }
}

// A factory of TypeWrapper
// this trick enables return the typeof type dynamically
function make<T, TType extends new () => T>(type: TType) {
    return new TypeWrapper<T, typeof type>(type);
}

let typeWrapper = make(class A {});
const Clazz = typeWrapper.getType();
let cls = new Clazz();

Now, what did the compiler inferred as type for Clazz?

typeof A, Looks legit :)
But what does the compiler think about timeWrapper?

TypeWrapper<{}, typeof A> notice the {} and not A.
Well, it knows about the TType param but nothing about T so it makes it {}.
The compiler knows that TType is a constructor for T but It only get TType in the signature.
Why can't it infer T from TType, or in other words, given typeof X can the compiler infer X?

btw in the playground atleast, hovering over AB in new AB() from the "naive" code sample in the OP throws an error Cannot read property 'flags' of undefined. I didn't see if it's fixed in master.

editor.main.js:6 Uncaught Error: TypeError: Cannot read property 'flags' of undefined

TypeError: Cannot read property 'flags' of undefined
    at Object.t [as buildSymbolDisplay] (https://www.typescriptlang.org/play/Script/vs/languages/typescript/common/lib/typescriptServices.js:22:3918)
    at https://www.typescriptlang.org/play/Script/vs/languages/typescript/common/lib/typescriptServices.js:32:21522
    at p (https://www.typescriptlang.org/play/Script/vs/languages/typescript/common/lib/typescriptServices.js:32:21307)
    at Object.f [as symbolToDisplayParts] (https://www.typescriptlang.org/play/Script/vs/languages/typescript/common/lib/typescriptServices.js:32:21480)
    at H (https://www.typescriptlang.org/play/Script/vs/languages/typescript/common/lib/typescriptServices.js:35:11607)
    at Object.j [as getQuickInfoAtPosition] (https://www.typescriptlang.org/play/Script/vs/languages/typescript/common/lib/typescriptServices.js:35:14991)
    at Object.i [as compute] (https://www.typescriptlang.org/play/Script/vs/languages/typescript/common/typescriptWorker2.js:1:6652)
    at t.computeInfo (https://www.typescriptlang.org/play/Script/vs/languages/typescript/common/typescriptWorker2.js:2:26137)
    at https://www.typescriptlang.org/play/Script/vs/languages/typescript/common/typescriptMode.js:1:19518
    at then (https://www.typescriptlang.org/play/Script/vs/base/common/worker/workerServer.js:1:24735)(anonymous function) @ editor.main.js:6
editor.main.js:11 Main Thread sent to worker the following message:e._onError @ editor.main.js:11e._onmessage @ editor.main.js:11e._onSerializedMessage @ editor.main.js:11(anonymous function) @ editor.main.js:11worker.onmessage @ editor.main.js:14

One solution would be #7234. That would make the "simplified" example work as expected. This is sort of an abuse of generics since you don't really want two type parameters there, but would work.
The alternative is #6606 (assuming it supported new), since then you would be able to write out the return type as  { new(): (typeof new A()) & (typeof new B()) } & A & B }.

filed https://github.com/Microsoft/TypeScript/issues/7966 to track the crash in quick info

@RyanCavanaugh #7234 and #6606 are spot on!
Here's the interesting thing about your suggestion with #6606:
As I said, I'm working on a lib for mixin's and type composition with realtime type composition.
So the core of it is in the following class, which is similar to my "simplified" exapmle:
export interface ConcreteTypeOf<T> extends Function { new (...args): T; }

class TypeWrapper<T, TType extends ConcreteTypeOf<T>> {

    constructor(private _type: new () => T, dupe: TType = undefined) {}

    get asType(): T {  return <any>this._type;  }
    get asStaticType(): TType { return <any>this._type; }

    mixType<Z, ZType extends new () => Z> (t: ConcreteTypeOf<Z>, dupe: ZType = undefined)
						: TypeWrapper<T & Z, ConcreteTypeOf<T & Z> & TType & ZType>  {
         return <any>this;
    }
}

Here are some notable changes from the "simplified" example:

Added a "dupe" param to the constructor, this is the workaround to get static type meta. if a user supply it he we will have "static" type meta, so new TypeWrapper(A, A) will have static & instance types of A and the compiler knows about T and TType.
Added to getter to get both instance type and static type of the dynamic class.
Add a mixType method, gets a type and returned the mixed type (no implementation), same logic as constructor regarding dupe type.

Note the return type TypeWrapper<T & Z, ConcreteTypeOf<T & Z> & TType & ZType> same as your suggestion with #6066 but with a redundant parameter.
Here's an example of what we get from it:
export class A{
	static IM_STATIC_A: string;
	imInstanceA: string;
}

class B_{
	static IM_STATIC_B: string;
	imInstanceB: string;
}
class C_{
	static IM_STATIC_C: string;
	imInstanceC: string;
}

let tw = new TypeWrapper(A, A)
	.mixType(B_, B_)
	.mixType(C_, C_);

// let's expose out our new type to the world:
export const Composed = tw.asStaticType;
export type Composed = typeof tw.asType;

Quite Cool!
However I had to remove the intersection of TType & ZType from the return type of mixinType in TypeWrapper which means the static type is gone.
    mixType<Z, ZType extends new () => Z> (t: ConcreteTypeOf<Z>, dupe: ZType = undefined)
						: TypeWrapper<T & Z, ConcreteTypeOf<T & Z>>  {
         return <any>this;
    }

Here's why...
Lets mixin with, the output of a previous mixin, Composed as base:
class D {
	static IM_STATIC_D: string;
	imInstanceD: string;
}

let twD = new TypeWrapper(Composed,Composed)
	.mixType(D, D);

export const DComposed = twD.asStaticType;
export type DComposed = typeof twD.asType;

If we don't remove the TType & ZType intersection from the return type of mixType:

Note the error and the instance shape is only D now.

If we remove it, we loose static type meta but have full instance shape.

Also worth noting, both with TType & ZType and without it, the new type is not "extendable"
With it:

Without it:

I really like the outcome, even without static meta tough its an issue.
Beside's mixing in 2 types I manages to mixing single members which make composition really cool.
If these issues are solved it will make the type system super super flexible.
Thanks!

@RyanCavanaugh
After playing with typeof expressions using the compiler built for #6066 I'm quite positive now that
#7234 will actually solve the problem.
Now matter what you do, if the compiler cant infer an instance type from it's static type you can't fill the missing gap.

Closing in favor of #7234


Report duplicate PipelineRun params within pipelineSpec

https://github.com/IBM/tekton-lint/blob/6cc83bec9272984459a522aa117a47342981650a/regression-tests/no-duplicate-param.yaml#L66-L67
It should be reported by the no-duplicate-param rule.

Resolve by Pr #99


Auto dl irssi and XML-RPC socket

Hi I'm trying to use autodl irssi on the host machine (without the rutorrent plugin for now) and the add to rtorrent action uses the XML-RPC socket (8000) I've modified my docker-compose to publish the XML-RPC port and configured autodl to send to <IP_ADDRESS>:8000, however I get the following error from autodl when it tries to add to rtorrent:
error: XmlRpc::_onDataReceived: Invalid XML-RPC response (not XML)
Any idea why this is? Thanks.
Edit: Is it related the nginx basic auth? The contents of the files in the passwd directory are currently empty - I have not configured any auth. But perhaps whatever is being sent over port 8000 is not what autodl is expecting. If someone could help me understand the issue I'd be grateful.

I also tried exposing the scgi.socket file to the host and to another container with autodl-irssi, but autodl-irssi can't seem to add torrents via it. I've tried chmod 777 on the socket file, doesn't help. Flood can see the download queue through it, but also can't add torrents via the socket file.

I am having the same issue trying to get Sonarr to connect to XML-RPC.

As a note, I tried the Docker image "romancin" provides using the same configuration and didn't have the issue. I will try to spend some time debugging it later.

Works fine for me:
$ docker-compose exec rutorrent curl --data '<?xml version="1.0" encoding="UTF-8"?><methodCall><methodName>system.library_version</methodName></methodCall>' http://<IP_ADDRESS>:8000
<?xml version="1.0" encoding="UTF-8"?>
<methodResponse>
<params>
<param><value><string>0.13.8</string></value></param>
</params>
</methodResponse>

@crazy-max The latest image seems to be working fine, but it was definitely not working when I tried it previously. As always thank you for your work.
@describe19 Do you have time to test this again with the latest image?

Hey

@crazy-max The latest image seems to be working fine, but it was definitely not working when I tried it previously. As always thank you for your work. @describe19 Do you have time to test this again with the latest image?

Hi can you tell how to setup sonarr with this i am unable to do that i am using sonarr in docker contianer and very confused what to put in the rtorrent config in sonarr to make it work it was easy for qbit but i want to setup for rtorrent

Can someone share how they got SCGI to connect? I'm up against a wall


gitkraken: 10.1.1 -> 10.2.0

Description of changes
Release notes
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gitkraken

For the reviewers, I would like to take advantage of this PR to reformat the code with nixfmt, would that be ok?
Here is the diff generated after running nixfmt -v pkgs/applications/version-management/gitkraken/default.nix:
diff --git a/pkgs/applications/version-management/gitkraken/default.nix b/pkgs/applications/version-management/gitkraken/default.nix
index 9f867d9f3b3e..80c890046895 100644
--- a/pkgs/applications/version-management/gitkraken/default.nix
+++ b/pkgs/applications/version-management/gitkraken/default.nix
@@ -1,10 +1,58 @@
-{ lib, stdenv, libXcomposite, libgnome-keyring, makeWrapper, udev, curlWithGnuTls, alsa-lib
-, libXfixes, atk, gtk3, libXrender, pango, adwaita-icon-theme, cairo, freetype, fontconfig
-, libX11, libXi, libxcb, libXext, libXcursor, glib, libXScrnSaver, libxkbfile, libXtst
-, nss, nspr, cups, fetchzip, expat, gdk-pixbuf, libXdamage, libXrandr, dbus
-, makeDesktopItem, openssl, wrapGAppsHook3, makeShellWrapper, at-spi2-atk, at-spi2-core, libuuid
-, e2fsprogs, krb5, libdrm, mesa, unzip, copyDesktopItems, libxshmfence, libxkbcommon, git
-, libGL, zlib, cacert
+{
+  lib,
+  stdenv,
+  libXcomposite,
+  libgnome-keyring,
+  makeWrapper,
+  udev,
+  curlWithGnuTls,
+  alsa-lib,
+  libXfixes,
+  atk,
+  gtk3,
+  libXrender,
+  pango,
+  adwaita-icon-theme,
+  cairo,
+  freetype,
+  fontconfig,
+  libX11,
+  libXi,
+  libxcb,
+  libXext,
+  libXcursor,
+  glib,
+  libXScrnSaver,
+  libxkbfile,
+  libXtst,
+  nss,
+  nspr,
+  cups,
+  fetchzip,
+  expat,
+  gdk-pixbuf,
+  libXdamage,
+  libXrandr,
+  dbus,
+  makeDesktopItem,
+  openssl,
+  wrapGAppsHook3,
+  makeShellWrapper,
+  at-spi2-atk,
+  at-spi2-core,
+  libuuid,
+  e2fsprogs,
+  krb5,
+  libdrm,
+  mesa,
+  unzip,
+  copyDesktopItems,
+  libxshmfence,
+  libxkbcommon,
+  git,
+  libGL,
+  zlib,
+  cacert,
 }:

 with lib;
@@ -40,12 +88,22 @@ let
     sourceProvenance = with lib.sourceTypes; [ binaryNativeCode ];
     license = licenses.unfree;
     platforms = builtins.attrNames srcs;
-    maintainers = with maintainers; [ xnwdd evanjs arkivm nicolas-goudry ];
+    maintainers = with maintainers; [
+      xnwdd
+      evanjs
+      arkivm
+      nicolas-goudry
+    ];
     mainProgram = "gitkraken";
   };

   linux = stdenv.mkDerivation rec {
-    inherit pname version src meta;
+    inherit
+      pname
+      version
+      src
+      meta
+      ;

     dontBuild = true;
     dontConfigure = true;
@@ -96,18 +154,26 @@ let
       zlib
     ];

-    desktopItems = [ (makeDesktopItem {
-      name = "GitKraken Desktop";
-      exec = "gitkraken";
-      icon = "gitkraken";
-      desktopName = "GitKraken Desktop";
-      genericName = "Git Client";
-      categories = [ "Development" ];
-      comment = "Unleash your repo";
-    }) ];
+    desktopItems = [
+      (makeDesktopItem {
+        name = "GitKraken Desktop";
+        exec = "gitkraken";
+        icon = "gitkraken";
+        desktopName = "GitKraken Desktop";
+        genericName = "Git Client";
+        categories = [ "Development" ];
+        comment = "Unleash your repo";
+      })
+    ];

-    nativeBuildInputs = [ copyDesktopItems (wrapGAppsHook3.override { makeWrapper = makeShellWrapper; }) ];
-    buildInputs = [ gtk3 adwaita-icon-theme ];
+    nativeBuildInputs = [
+      copyDesktopItems
+      (wrapGAppsHook3.override { makeWrapper = makeShellWrapper; })
+    ];
+    buildInputs = [
+      gtk3
+      adwaita-icon-theme
+    ];

     # avoid double-wrapping
     dontWrapGApps = true;
@@ -159,9 +225,17 @@ let
   };

   darwin = stdenv.mkDerivation {
-    inherit pname version src meta;
-
-    nativeBuildInputs = [ unzip makeWrapper ];
+    inherit
+      pname
+      version
+      src
+      meta
+      ;
+
+    nativeBuildInputs = [
+      unzip
+      makeWrapper
+    ];

     installPhase = ''
       runHook preInstall
@@ -177,6 +251,4 @@ let
     dontFixup = true;
   };
 in
-if stdenv.isDarwin
-then darwin
-else linux
+if stdenv.isDarwin then darwin else linux

@nicolas-goudry if nixfmt is from pkgs.nixfmt-rfc-style then go for it, make a separate commit

@nicolas-goudry if nixfmt is from pkgs.nixfmt-rfc-style then go for it, make a separate commit

Yep, that’s the one. I’ll make another commit then. Thanks for your input!


Fan is turning on when opening info panel in HA

Hi,
I really appreciate your work on this, thanks!

I noticed that the fan is turning on, when I open the detail panel of my fan entity. I have a Dyson AM-07 fan, it turns on when I am pressing the oscillation key on the remote.
I suppose somehow HA is sending/checking for the oscillation status and sending the command for it? Can this be fixed, so that no commands are sent a default state is assumed after a fresh setup/after HA is restarted. I know that with IR devices get out of sync, I have no issues with that. The current behavior is just not contributing to the situation. :)
Thank you very much.
best regards

Hi @voydz
Sorry, but I don't get the point.

Hey @KiraPC
let me explain how to reproduce:

Setup a fan using your HA component
Click on the fan entity to open the dialog shown in my first post (the entity detail panel)

Expected result

entity panel should open and I should be able to control the device

Actual result

entity panel opens
your HA component also initiates a command to trigger oscillation (swinging of the fan)
this switches my fan on without clicking anything in the entity panel

But this is not regarding the custom component but how HA works.
I did not manage the behavior of the HA button.

@KiraPC I assume HA is checking for the status of power and oscillation.
Could it be, that this is implemented in a way, so that the component is handling that as an input?
I see, that this might seem as a "HA problem" and nothing with your component. But its a usability thing, isn't it? I do not have this issue with other integrations and components. So it might seem to be a good idea to sort this out, so that your component handles it in a way, so that devices behave as expected don't you think?

@voydz I'm using this integration since an year ago and I never had a similar issue.
I have a lot component configured, including an A/C, and when I open the detail I never had this issue.
The core component is common for every device.

Yeah, sorry to bother. I do not know why it behaves like that. I can now definetly say that a swing/oscillate command is send after opening the detail. (Tested it with the fan being on. Starts/Stops to swing after opening the detail.)
I will resort to using every key with a custom button now, I guess.

I had a very quickly view into the code but as I remember there isn't any relationship between the "view detail action" and the "sending command"
I don't know if you know a little of coding concept, but events are what you generate when you click something.
There is no event fired to the custom component code when you click on the detail button.
So, I can assume this is not a custom component issue.

I had a very quickly view into the code but as I remember there isn't any relationship between the "view detail action" and the "sending command"
I don't know if you know a little of coding concept, but events are what you generate when you click something.
There is no event fired to the custom component code when you click on the detail button.
So, I can assume this is not a custom component issue.

Thanks for your time and looking into it. :)


Support testing for expected exceptions

For testing APIs in particular, it would be helpful to be able to test that a given action throws a particular exception.
For example, a scenario similar to this:
Scenario: Trying to access protected fields without authentication generates an exception
  Given I have a new API object
  Then I should catch an AccessDeniedException when I access the email property
  And the exception message should contain "foo"

The most obvious and reusable way to achieve this would be to chain a step from the "Then I should catch..." definition.
However, after playing around for a while, I can't see a way to implement this in the current architecture. Obviously the existing step chaining won't work because in that case the chained step would fail and so would the scenario. I thought about implementing a hook, but they seem to be able only to read the scenario/step results rather than being able to change them.
I think the best approach would be to support executing a substep directly within a FeatureContext - something like this:
   /**
     * @Then /^I should catch an ([a-zA-Z_]+) when (.+)$/
     */
    public function iShouldCatchAnException($exception_type, $when_step)
    {
        // Execute the action
                $step = new When($when_step);

                try
                {
                    // Execute Step
                }
                catch (\Exception $e)
                {
                   // Test for the expected type and store or rethrow
                }
    }

However, I don't think that's possible at present because the FeatureContext doesn't have a reference to either the StepTester or the DI container, so it's not even able to duplicate the StepTester logic as it can't access the definitions.
I'm not sure the best way to resolve this, but I don't think it's possible without changing the core to pass in one or other of those dependencies to the FeatureContext method somehow? I'm happy to have a go at doing so if you agree that this would be a useful scenario to be able to support?
Otherwise, I think the only option would be to specifically define individual steps, which is fairly brittle and would probably cause duplication especially since often you'll want to test that an exception is thrown from a method that you are anyway testing in non-exception use cases - it would be nice to be able to share that definition.

Behat IS NOT unit testing or specification testing BDD tool. Behat is Scenario-oriented BDD framework with functional testing capabilities as part of communication process between stack-holder and developers. It means, that Behat was created and evolving as agile planning and functional testing methodology. However, if you want to use it as unit testing or spec testing tool, you can, but keep in mind, that we'll not add into Behat functions, that it wasn't intended to do ideologically ;-)
Personally, i would recommend you to use PHPUnit or PHPSpec for internal api testing. Behat was created for black-box like, functional, user-observable behavior testing :-)

@everzet, thanks for the quick reply (and the tool!).
I appreciate the distinction between Behat and PHPUnit/PHPSpec. I've used PHPUnit before, though I'm new to Behat. However, I thought (and may be wrong) that it was appropriate to use BDD/functional testing for the public API and functionality of a module/library. I'm certainly aware of several Ruby libraries that have cucumber tests for their public API.
In that case, calling a method and receiving an exception seems to me to be equivalent black-box like, functional, user-observable testing in the same way that loading a URL and getting a 404 in Mink is - it all depends on who the user is that is doing the observing? A third-party application developer integrating your library is still a user, aren't they?
Obviously the internal api of your classes and application should be covered by unit testing, as you say.
It's entirely possible I've misunderstood though - as I say I'm new to the BDD concept although already finding it a powerful one. Behat is a great tool!

The whole idea of Behat features describing is built around the idea of defining one single business dictionary for your domain area. It means, that defining this dictionary one time you can use it in all your project scenarios. But when we're talking bout source code testing, we're talking bout source code, not about dictionary. Building dictionary for an public API testing of your library, you'll finish with duplicating of entire php language in step definitions :-) And, what's even worse, at some point, you'll notice, that you're writing dictionary definitions (step definitions) more than testing or describing target behavior. That's the only reason why Behat is oriented on the black box testing.
One of the brillian ideas about BDD - you should describe behavior in terms, that end user should understand. So, when you're talking about website users - it's browser behavior, that you're describing and Behat+Mink fits there awesomely. When you're talking bout console tool user - it's custom CLI user dictionary (run, go to directory, etc.), that you should describe and Behat fits there too: https://github.com/Behat/Behat/blob/master/features/bootstrap/FeatureContext.php#L95. But when you're talking about php library users - you're talking bout source code. And best terms to describe php library behavior to it's users is the source code itself.

Many thanks for the explanation, that makes a lot of sense. I'll stick to
phpunit for APIs and move to behat for testing full-stack apps and
components. Was just so impressed with the concept I wanted to use it
everywhere :)
On 8 Oct 2011 15:47, "Konstantin Kudryashov" <
<EMAIL_ADDRESS>wrote:

The whole idea of Behat features describing is built around the idea of
defining one single business dictionary for your domain area. It means, that
defining this dictionary one time you can use it in all your project
scenarios. But when we're talking bout source code testing, we're talking
bout source code, not about dictionary. Building dictionary for an public
API testing of your library, you'll finish with duplicating of entire php
language in step definitions :-) And, what's even worse, at some point,
you'll notice, that you're writing dictionary definitions (step definitions)
more than testing or describing target behavior. That's the only reason why
Behat is oriented on the black box testing.
One of the brillian ideas about BDD - you should describe behavior in
terms, that end user should understand. So, when you're talking about
website users - it's browser behavior, that you're describing and Behat+Mink
fits there awesomely. When you're talking bout console tool user - it's
custom CLI user dictionary (run, go to directory, etc.), that you should
describe and Behat fits there too:
https://github.com/Behat/Behat/blob/master/features/bootstrap/FeatureContext.php#L95.
But when you're talking about php library users - you're talking bout source
code. And best terms to describe php library behavior to it's users is the
source code itself.
--
Reply to this email directly or view it on GitHub:
https://github.com/Behat/Behat/issues/58#issuecomment-2332339

@everzet So wait, you're saying that I should not use Behat to perform functional test on my PHP libraries for public APIs.


add option to always show the scroll bar

I would like to always see marks such as changes through gitsigns or marks, even if the status column can show all of that information on the left.
Add option in user configuration which disables the check for testing if all lines of buffer can be seen at once.

Just wanted to open PR :(


TUSD behind Traefik 2 reverse proxy

Question
I can not make the file upload work with TUSD sitting behind Traefik 2. We Upload with Uppy within a create-react-app. TUSD runs on a Docker Swarm cluster. example.com is a replacement for our domain which can be called with HTTPS only.
The error is the folowing:
Blocked loading mixed active content “http://example.com/files/ec812c10c32ed23b31cf4976fb8af469”
2 httpStack.js:96:19
XHRHEADhttp://example.com/files/ec812c10c32ed23b31cf4976fb8af469

The corresponding tusd service in stack.yml looks like:
tusd:
    image: tusproject/tusd:v1.8.0
    command: -verbose --hooks-http=http://api:8080/api/uploader/tusd/webhook -hooks-stop-code=401 -hooks-http-backoff=60 -hooks-http-retry=2 -behind-proxy=true
    volumes:
      - "/usr/local/myfolder/files:/srv/tusd-data/data"
    networks:
      - mynetwork
    deploy:
      resources:
        limits:
          memory: 1024M
        reservations:
          memory: 512M
      replicas: 1
      update_config:
        parallelism: 1
        delay: 10s
      labels:
        - "traefik.enable=true"
        - "traefik.port=1080"
        - "traefik.docker.network=mynetwork"
        - "traefik.http.routers.tusd.rule=Host(`example.com`) && PathPrefix(`/files`)"
        - "traefik.http.routers.tusd.priority=2"
        - "traefik.http.routers.tusd.entrypoints=websecure"
        - "traefik.http.routers.tusd.tls=true"
        - "traefik.http.routers.tusd.tls.certresolver=myprivatesocietey"
        - "traefik.http.routers.tusd.service=tusd-service"
        - "traefik.http.services.tusd-service.loadbalancer.server.port=1080"
        - "traefik.http.middlewares.tusd.headers.customrequestheaders.X-Forwarded-Proto=https"

On Traefik itself i configured the following headers:
      - "traefik.frontend.headers.forceSTSHeader=true"
      - "traefik.frontend.headers.STSSeconds=315360000"
      - "traefik.frontend.headers.STSIncludeSubdomains=true"
      - "traefik.frontend.headers.STSPreload=true"
      - "traefik.frontend.headers.passHostHeader=true"

passHostHeader because the FAQ mentioned the X-Forwarded-* headers should be available.

Ok, was not my fault on server side, was Uppy itself: https://github.com/transloadit/uppy/issues/2285#issuecomment-632920770
This helped. So I had to clear local storage explicitly. Reload without Cache is not enough.


Reusing spare normal-distributed random variable causes issues when different RNG sources are used

The problem is that the spare might be generated from a different source. A spare should only be used when the default RNG of the simulation environment is used.

fixed


CASMINST-6625: BGP test: Improve PW handling, prevent false passes

CSM 1.5 metal-provision PR for https://github.com/Cray-HPE/csm/pull/2761

There was a reorg, and I slurped this into #396 .


Swagger APIView content inconsistent with generated APIView file in spec PR pipeline

For this PR: https://github.com/Azure/azure-rest-api-specs/pull/21841
The generated APIView token file artifact has been changed, but the APIView still show the old one.
APIView link: https://apiview.dev/Assemblies/Review/ee454eada3414e52b4fe4ab499d17e89
I manually uploaded the generate apiVIew token file to test env. The two APIView are different. https://apiviewstaging.azurewebsites.net/Assemblies/Review/f5e56708f70847e78d5b39a986c5f0e8
APIView should pick up the latest generated artifact.

Fixed on https://github.com/Azure/azure-sdk-tools/pull/5421


[MRG] ENH: users make predictions with drag-and-drop bomb

@sbruinsma1 this is ready to go pending your review. Note my changes to the instructions as well.


Fix generateTileCache / threeToTileCache typescript types to omit unsupported RecastConfig options

You can preview the demo from the URL：https://aaron-bird.github.io/recast-navigation-js-issue-demo/index.html
Or download it：https://github.com/Aaron-Bird/recast-navigation-js-issue-demo
Some code：
 const { success, navMesh, tileCache } = threeToTileCache([mesh], {
            tileSize: 16,
            cs: 0.2,
            ch: 0.2,
            walkableSlopeAngle: 35,
            walkableHeight: 1,
            walkableClimb: 0.1,
            walkableRadius: 1,
            maxEdgeLen: 12,
            maxSimplificationError: 1.3,
            mergeRegionArea: 20,
            maxVertsPerPoly: 6,
            detailSampleDist: 6,
            detailSampleMaxError: 1,

            minRegionArea: 100,
          });

Hi, I beleive this is a simialr issue to this: https://github.com/isaac-mason/recast-navigation-js/discussions/308

The short explanation is the Detour TileCache generation process is different to the process for solo and tiled navigation meshes, and it appears although TileCache takes a rcConfig / recast configuration object with a minRegionArea option, it isn't actually used.
I think we should at least fix the typescript types so it doesn't seem like minRegionArea + maxEdgeLen + potentially others can be used, when in reality they cant.

Made a change to omit minRegionArea and maxEdgeLen from TileCacheGeneratorConfig
https://github.com/isaac-mason/recast-navigation-js/commit/5cb17a14b0399c57872c2fb6537783c2d202f0f4


Exercise: A Vector Type

Closed #332

I have added the header with /* global Vector */

Loos like /* global Vector */ isn't required for our set of styleguide rules