/usr/bin/ld.gold: fatal error: LLVM gold plugin: :0: Undefined temporary symbol .Ltmp265928

Was running ../run_both.sh bitcoin-core 3, but it failed.
...
[Log level 2] : 13:06:58 : Wrapping function sancov.module_ctor_8bit_counters.86728
[Log level 2] : 13:06:58 : Wrapping function event_listener_getbase
[Log level 2] : 13:06:58 : Wrapping function event_listener_getfd
[Log level 2] : 13:06:58 : Wrapping function event_listener_destroy
[Log level 2] : 13:06:58 : Wrapping function event_listener_disable
[Log level 2] : 13:06:58 : Wrapping function event_listener_enable
[Log level 2] : 13:06:58 : Wrapping function evconnlistener_set_error_cb
[Log level 2] : 13:06:58 : Wrapping function evconnlistener_set_cb
[Log level 2] : 13:06:58 : Wrapping function evconnlistener_get_base
[Log level 2] : 13:06:58 : Wrapping function evconnlistener_get_fd
[Log level 2] : 13:06:58 : Wrapping function evconnlistener_disable
[Log level 2] : 13:06:58 : Wrapping function evconnlistener_free
[Log level 2] : 13:06:58 : Wrapping function evconnlistener_new_bind
[Log level 2] : 13:06:58 : Wrapping function evconnlistener_new
[Log level 2] : 13:06:58 : Wrapping function listener_read_cb
[Log level 2] : 13:06:58 : Wrapping function evconnlistener_enable
[Log level 2] : 13:06:58 : Wrapping function sancov.module_ctor_8bit_counters.86775
[Log level 2] : 13:06:58 : Wrapping function evthread_posix_get_id
[Log level 2] : 13:06:58 : Wrapping function evthread_posix_cond_wait
[Log level 2] : 13:06:58 : Wrapping function pthread_cond_timedwait
[Log level 2] : 13:06:58 : Wrapping function pthread_cond_wait
[Log level 2] : 13:06:58 : Wrapping function evthread_posix_cond_signal
[Log level 2] : 13:06:58 : Wrapping function pthread_cond_broadcast
[Log level 2] : 13:06:58 : Wrapping function pthread_cond_signal
[Log level 2] : 13:06:58 : Wrapping function evthread_posix_cond_free
[Log level 2] : 13:06:58 : Wrapping function pthread_cond_destroy
[Log level 2] : 13:06:58 : Wrapping function evthread_posix_cond_alloc
[Log level 2] : 13:06:58 : Wrapping function pthread_cond_init
[Log level 2] : 13:06:58 : Wrapping function evthread_posix_unlock
[Log level 2] : 13:06:58 : Wrapping function evthread_posix_lock
[Log level 2] : 13:06:58 : Wrapping function pthread_mutex_trylock
[Log level 2] : 13:06:58 : Wrapping function evthread_posix_lock_free
[Log level 2] : 13:06:58 : Wrapping function evthread_posix_lock_alloc
[Log level 2] : 13:06:58 : Wrapping function evthread_use_pthreads
[Log level 2] : 13:06:58 : Wrapping function pthread_mutexattr_init
[Log level 2] : 13:06:58 : Wrapping function pthread_mutexattr_settype
[Log level 2] : 13:06:58 : Ended wrapping all functions
[Log level 1] : 13:06:59 : Finished introspector module
/usr/bin/ld.gold: fatal error: LLVM gold plugin: <unknown>:0: Undefined temporary symbol .Ltmp265928

clang-14: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [Makefile:6708: test/fuzz/fuzz] Error 1
make[2]: Leaving directory '/src/bitcoin-core/src'
make[1]: *** [Makefile:17510: all-recursive] Error 1
make[1]: Leaving directory '/src/bitcoin-core/src'
make: *** [Makefile:812: all-recursive] Error 1
ERROR:root:Building fuzzers failed.

I was compiling OSS-Fuzz myself, but I see that something was merged upstream. Does it need a bump in this repo, like https://github.com/ossf/fuzz-introspector/pull/25 ?

atm there are two different patches going on: the local ones from here and the ones already pushed to OSS-Fuzz. Ideally the patch we have here should be removed in favour of using the patches in upsteam OSS-Fuzz. I haven't looked at doing this yet, but am not sure if the upstream OSS-Fuzz patches are fully working with a local set up -- @Navidem there were some issues with running the fuzz-introspector set up in OSS-Fuzz locally, is this fixed?
For that reason I think it shouldn't be bumped atm because it will mix the two patches together, which will inevitably fail.
There were two major things changed recently in the compiler plugin: (1) we updated to latest LLVM version and new plugin manager, and (2) we add a global variable as a tag in the binary (this is a "major" change since it means now we add content to the module whereas previously we just observed). This issue could be related to that, potentially.

I was trying latest main from this morning. I'll try commit 9497e29c tomorrow.

Thanks! Let me know how it works -- I will also see if I can identify if the patching it now does can be the cause of this issue

Along with my previous comment, I also gave a try bitcoin-core on the latest commit today: 34de4644ed88b44fe5228683ef8d82aec2d85955 (by applying the patches locally), and it went on successfully as well. I can see the fuzzers running...
Hope this helps!
Running script_sign
...
Using seed corpus: script_sign_seed_corpus.zip
/out/script_sign -rss_limit_mb=2560 -timeout=25 -max_total_time=3 -detect_leaks=0 /tmp/script_sign_corpus < /dev/null
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed: 492432055
INFO: Loaded 1 modules   (191726 inline 8-bit counters): 191726 [0x55cba2b38be8, 0x55cba2b678d6),
INFO: Loaded 1 PC tables (191726 PCs): 191726 [0x55cba2b678d8,0x55cba2e547b8),
INFO:     9136 files found in /tmp/script_sign_corpus
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1048576 bytes
INFO: seed corpus: files: 9136 min: 1b max: 1048756b total: 222936690b rss: 74Mb
#1024   pulse  cov: 4907 ft: 12976 corp: 410/17Kb exec/s: 256 rss: 93Mb
#2048   pulse  cov: 5828 ft: 16970 corp: 749/59Kb exec/s: 256 rss: 93Mb
#4096   pulse  cov: 6441 ft: 22604 corp: 1324/167Kb exec/s: 292 rss: 100Mb
#8192   pulse  cov: 6846 ft: 41798 corp: 3222/5693Kb exec/s: 89 rss: 137Mb

Running script_interpreter
...
Using seed corpus: script_interpreter_seed_corpus.zip
/out/script_interpreter -rss_limit_mb=2560 -timeout=25 -max_total_time=3 -detect_leaks=0 /tmp/script_interpreter_corpus < /dev/null
INFO: Running with entropic power schedule (0xFF, 100).
INFO: Seed:<PHONE_NUMBER>
INFO: Loaded 1 modules   (191726 inline 8-bit counters): 191726 [0x55acbb397be8, 0x55acbb3c68d6),
INFO: Loaded 1 PC tables (191726 PCs): 191726 [0x55acbb3c68d8,0x55acbb6b37b8),
INFO:     2070 files found in /tmp/script_interpreter_corpus
INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1048576 bytes
INFO: seed corpus: files: 2070 min: 1b max: 1084228b total: 152559799b rss: 68Mb
#1024   pulse  cov: 1801 ft: 7664 corp: 378/24Kb exec/s: 204 rss: 88Mb

Sorry for being unclear, let me provide exact steps to reproduce. My understanding is that the rust image is not yet built for introspector, thus an additional OSS-Fuzz patch is needed to change the image:
diff --git a/projects/bitcoin-core/Dockerfile b/projects/bitcoin-core/Dockerfile
index 61972719..6a2040a3 100644
--- a/projects/bitcoin-core/Dockerfile
+++ b/projects/bitcoin-core/Dockerfile
@@ -14,7 +14,7 @@
 #
 ################################################################################

-FROM gcr.io/oss-fuzz-base/base-builder-rust
+FROM gcr.io/oss-fuzz-base/base-builder

 # Packages taken from:
 # * https://github.com/bitcoin/bitcoin/blob/master/doc/build-unix.md#dependency-build-instructions
diff --git a/projects/bitcoin-core/build.sh b/projects/bitcoin-core/build.sh
index 5c6ac475..3d644e83 100755
--- a/projects/bitcoin-core/build.sh
+++ b/projects/bitcoin-core/build.sh
@@ -15,7 +15,6 @@
 #
 ################################################################################

-$SRC/build_cryptofuzz.sh

 cd $SRC/bitcoin-core/

@@ -29,7 +28,8 @@ fi
 (
   cd depends
   sed -i --regexp-extended '/.*rm -rf .*extract_dir.*/d' ./funcs.mk  # Keep extracted source
-  make HOST=$BUILD_TRIPLET DEBUG=1 NO_QT=1 NO_WALLET=1 NO_ZMQ=1 NO_UPNP=1 NO_NATPMP=1 boost_cxxflags="-std=c++17 -fvisibility=hidden -fPIC ${CXXFLAGS}" libevent_cflags="${CFLAGS}" -j$(nproc)
+  make HOST=$BUILD_TRIPLET NO_QT=1 NO_BDB=1 NO_ZMQ=1 NO_UPNP=1 NO_NATPMP=1 libevent_cflags="${CFLAGS}" sqlite_cflags="${CFLAGS}" -j$(nproc)
+  # DEBUG=1 is temporarily disabled due to libc++ bugs
 )

 # Build the fuzz targets
@@ -39,6 +39,9 @@ sed -i "s|PROVIDE_FUZZ_MAIN_FUNCTION|NEVER_PROVIDE_MAIN_FOR_OSS_FUZZ|g" "./confi

 # Temporarily compile with O2 to work around clang-13 (and later) UBSan
 # -fsanitize=vptr,object-size false positive that only happens with -O1
+# Fixed in https://github.com/llvm/llvm-project/commit/bbeaf2aac678
+# However, OSS-Fuzz is stuck on a buggy clang, so the workaround is still
+# needed. See https://github.com/google/oss-fuzz/pull/7140
 if [ "$SANITIZER" = "undefined" ]; then
   export CFLAGS="$CFLAGS -O2"
   export CXXFLAGS="$CXXFLAGS -O2"
@@ -79,14 +82,14 @@ fi
 # An alternative to mocking the string in the finished binary would be to
 # replace the string in the source code and re-invoke 'make'. This is slower,
 # so use the hack.
-export MAGIC_STR="b5813eee2abc9d3358151f298b75a72264ffa119d2f71ae7fefa15c4b70b4bc5b38e87e3107a730f25891ea428b2b4fabe7a84f5bfa73c79e0479e085e4ff157"
-sed -i "s|.*std::getenv(\"FUZZ\").*|std::string fuzz_target{\"$MAGIC_STR\"};|g" "./src/test/fuzz/fuzz.cpp"
-sed -i "s|.find(fuzz_target)|.find(fuzz_target.c_str())|g"                      "./src/test/fuzz/fuzz.cpp"
-make -j$(nproc)
-
 # Replace the magic string with the actual name of each fuzz target
 for fuzz_target in ${FUZZ_TARGETS[@]}; do
-  python3 -c "c_str_target=b\"${fuzz_target}\x00\";c_str_magic=b\"$MAGIC_STR\";c=open('./src/test/fuzz/fuzz','rb').read();c=c.replace(c_str_magic, c_str_target+c_str_magic[len(c_str_target):]);open(\"$OUT/$fuzz_target\",'wb').write(c)"
+  git checkout -- "./src/test/fuzz/fuzz.cpp"
+  sed -i "s|.*std::getenv(\"FUZZ\").*|std::string fuzz_target{\"$fuzz_target\"};|g" "./src/test/fuzz/fuzz.cpp"
+  sed -i "s|.find(fuzz_target)|.find(fuzz_target.c_str())|g"                        "./src/test/fuzz/fuzz.cpp"
+  make -j$(nproc)
+  mv './src/test/fuzz/fuzz' "$OUT/$fuzz_target"
+
   chmod +x "$OUT/$fuzz_target"
   (
     cd assets/fuzz_seed_corpus

You can then run a slightly faster build by selecting the "CI build":
OSS_FUZZ_CI=1 ../run_both.sh bitcoin-core 3

This will give the above failure.

In the jsoncpp context I only see this issue in the OSS-Fuzz integration and not on the local test using https://github.com/ossf/fuzz-introspector/tree/main/tests/jsoncpp

The error message seems to come from here:
https://github.com/llvm/llvm-project/blob/26bbde2612b2042c3a8a31aed7f45e065c3dd413/llvm/lib/MC/ELFObjectWriter.cpp#L638-L641
The global variable we add for tagging purposes is here: https://github.com/ossf/fuzz-introspector/blob/2ced5a301b019a6b212e0770e7ac17df1a2e27fa/llvm/lib/Transforms/FuzzIntrospector/FuzzIntrospector.cpp#L275-L281
I think the issue happens because the linkage llvm::GlobalValue::LinkageTypes::ExternalLinkage will add the symbol (global variable) to the symbol table. However, the global variable we add is never referenced anywhere in the module, so I wonder if LLVM makes it a temporary and undefined symbol for that reason.
One possible solution may be to change linkage PrivateLinakge which excludes the variable from the symbol table (https://llvm.org/doxygen/classllvm_1_1GlobalValue.html#aedfa75f0c85c4aa85b257f066fbea57c) -- will verify this hypothesis.

Update on jsoncpp: this issue is unrelated to fuzz-introspector it seems, in that if we disable fuzz-introspector (unset FUZZ_INTROSPECTOR) then the issue still occurs despite fuzz-introspector not doing any work

@MarcoFalke did you see any differences following the linker merge? I think this error is not due to fuzz-introspector following the comments above. It seemed to be related to something in latest LLVM itself

Sure, happy to take another look. I see there were some changes in the oss-fuzz repo and here, so I am wondering what is the best way to build fuzz-introspector right now? Start from the oss-fuzz repo or start from this repo?

One option that let's you avoid building the images yourself is to pull the latest oss-fuzz fuzz-introspector base-clang image. I am still in the process of updating the docs, but following this thread you can see details: https://github.com/ossf/fuzz-introspector/issues/67#issuecomment-1073031279

Ok, I tried to run:
OSS_FUZZ_CI=1  python3 infra/helper.py build_fuzzers --sanitizer=introspector bitcoin-core

It fails with:
     |████████████████████████████████| 40kB 34.0MB/s
Requirement already satisfied: six>=1.5 in /usr/local/lib/python3.8/site-packages (from python-dateutil>=2.7->matplotlib) (1.15.0)
Building wheels for collected packages: numpy
  Building wheel for numpy (PEP 517) ... done
  Created wheel for numpy: filename=numpy-1.22.3-cp38-cp38-linux_x86_64.whl size=15688858 sha256=eea9a47fd81c3cbc5a4cb12e33cf76e0726cef85448032e1d1e6e2d4a7aee94c
  Stored in directory: /root/.cache/pip/wheels/21/37/10/81a13af5964837a3627457192fbc14d926b1a2dcd810f70fbf
Successfully built numpy
Installing collected packages: cxxfilt, pyyaml, soupsieve, beautifulsoup4, lxml, python-dateutil, pyparsing, fonttools, numpy, pillow, cycler, kiwisolver, packaging, matplotlib
  Running setup.py install for pillow ... done
Successfully installed beautifulsoup4-4.10.0 cxxfilt-0.3.0 cycler-0.11.0 fonttools-4.31.2 kiwisolver-1.4.2 lxml-4.8.0 matplotlib-3.5.1 numpy-1.22.3 packaging-21.3 pillow-9.1.0 pyparsing-3.0.7 python-dateutil-2.8.2 pyyaml-6.0 soupsieve-2.3.1
WARNING: You are using pip version 19.2.3, however version 22.0.4 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
INFO:fuzz_utils:File: /out/cryptofuzz-bitcoin-cryptography-w15-p4 is executable
INFO:fuzz_utils:File: /out/addr_info_deserialize is executable
INFO:fuzz_utils:File: /out/cryptofuzz-bitcoin-cryptography-w2-p2 is executable
INFO:fuzz_utils:File: /out/llvm-symbolizer is executable
INFO:fuzz_utils:File: /out/addition_overflow is executable
INFO:fuzz_utils:File: /out/cryptofuzz-bitcoin-cryptography-w20-p8 is executable
INFO:fuzz_utils:File: /out/address_deserialize_v1_notime is executable
INFO:__main__:Pairings: []
INFO:__main__:Ending fuzz introspector post-processing
/usr/local/bin/compile: line 220: COVERAGE_URL: unbound variable
ERROR:root:Building fuzzers failed.

Thanks @MarcoFalke -- I'm on it, will let you know here once it's resolved.

Happy to try again, just let me know :)

Argh I forgot to ping here -- apologies @MarcoFalke
The COVERAGE_URL issue is fixed.
This should be ready to test if building OSS-Fuzz images yourself from the fuzz-introspector repository.
If you would like to use the OSS-Fuzz images, then I would wait until this is merged https://github.com/google/oss-fuzz/pull/7774 as it has a few bug fixes

Just tried again after the oss-fuzz bump to clang-15. Still reproducible with:
OSS_FUZZ_CI=1  python3 infra/helper.py build_fuzzers --sanitizer=introspector bitcoin-core

...

  CXXLD    test/fuzz/fuzz
/usr/bin/ld.gold: fatal error: LLVM gold plugin: <unknown>:0: Undefined temporary symbol .Ltmp175611

clang-15: error: linker command failed with exit code 1 (use -v to see invocation)

This seems to be the same error that is listen on the instrospector tab on https://oss-fuzz-build-logs.storage.googleapis.com/index.html (also seen for a few other projects).

Thanks @MarcoFalke
My current understanding of this is it's not due to Fuzz Introspector but rather LTO (https://github.com/ossf/fuzz-introspector/issues/48#issuecomment-1063163173). When I debugged it ( https://github.com/ossf/fuzz-introspector/issues/48#issuecomment-1063055164) I could not locate the error in Fuzz Introspector but just in some llvm code, and the issue occurred with and without fuzz introspector.

Ok, I've moved the issue to https://github.com/bitcoin/bitcoin/issues/25961 as it seems unrelated to this codebase.

Given https://github.com/bitcoin/bitcoin/issues/25961#issuecomment-1232997165 we may need to force use of clang 16 -- this issue does affect a lot of projects.

Does introspector already use a different clang version than oss-fuzz? If yes, that should simplify things and I am happy to test that. Otherwise, it seems hard to bump the oss-fuzz clang version, so I might just wait until it happens "by itself".

By default it uses the same. However, in the past we've used a different version and it probably wouldn't be too much of a hassle to get that in again.
I'll try and see if it's possible to get fuzz introspector running with clang-16 and then check if this issue is resolved in some projects! If successful, I can then push some images up somewhere that uses clang-16 and then we can use the solution of https://github.com/ossf/fuzz-introspector/issues/452 to run introspector with the latest clang on the latest oss-fuzz corpus.
Interesting it works on aarch64 -- it's an annoying compiler bug and it does seem to affect a significant amount of projects.


Formatting should be checked with prettier on workflows

The workflow ghactions.yml now checks for formatting with prettier. However, it does not fail all the tests with incorrect formatting.


Removing EOS token during training

Why do we do this? I assume this is removing the EOS token. I don't see this happening in the training code from Stanford. Thanks for your time <3
https://github.com/tloen/alpaca-lora/blob/e04897baaec39280fac97f1ad2bf33059b0df643/finetune.py#L104
@tloen

We want to remove the EOS token if the text continues beyond the CUTOFF_LEN.


This article should not be used with MFA Server deployments only Azure MFA (Cloud-based). (Syntax)

Please add punctuation as needed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61df48bb-a963-b1f0-8f64-b55d0bd6904c
Version Independent ID: 677de59f-a222-8905-11c0-a3ac619d8b56
Content: Remote Desktop Gateway integration with Azure MFA NPS extension
Content Source: articles/active-directory/authentication/howto-mfa-nps-extension-rdg.md
Service: active-directory
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@samyun Thanks for reporting this. I have updated the doc and it should be published shortly.


What do we do if there are prepared statements?

It seems we may get prepared statements for some of the upcoming fact-checks. How should we handle that, if at all?

If we are going to do the live transcription anyhow we could store the prepared statement in another document, or if we are really sure that the speech is going to be identical then we could forget about the live factcheck and go with the statement document.

I liked your idea of putting the prepared statements into the doc in suggestion mode, then approving as they are said (and adjusting in case of variations from the script). Doesn't look like we'll get them this time around though.


ArgumentError (Invalid argument(s): Unable to create interpreter.) with no indication about the error type

Several models I have can be used with flutter-tflite, which is great.
Unfortunately, I have a few models that load successfully with ML Kit, but cannot be loaded with flutter-tflite. I have to use TF Lite and not ML Kit as my models have no final softmax (ML Kit can load the model successfully but I cannot do anything meaningful with it thereafter).
I am doing all my testing with flutter-tflite 0.10.1 on Android only for now, on a real device (Google Pixel 6a).
My code is the following:
final options = InterpreterOptions();
// Use XNNPACK Delegate
options.addDelegate(XNNPackDelegate());
interpreter = await Interpreter.fromAsset(modelPath, options: options); // exception

The exception is
ArgumentError (Invalid argument(s): Unable to create interpreter.)

The model is fairly large, about 350MB.
In the log, the only information I have is:
I/tflite  (28784): Created TensorFlow Lite XNNPACK delegate for CPU.
I/tflite  (28784): Initialized TensorFlow Lite runtime.

I already had models that were not loading successfully in the past (like this one), and in these cases there was an error being raised:

either in the body of the exception for ML Kit
in the console when using flutter-tflite.

How can I investigate what causes flutter-tflite to not load my model?
EDIT: the problem can be solved by commenting out the following line:
options.addDelegate(XNNPackDelegate());

Using GpuDelegateV2 causes the same error as XNNPackDelegate.
Any idea about why this particular model would cause trouble? Maybe a memory overflow?

Did you find a fix for this? im having troubles with the same issue and im losing my head

same


graalvm8-ee: init at 19.1.1

Added non-free version, which supposes to work faster than the free version from https://github.com/NixOS/nixpkgs/pull/61475
cc @hlolli @NeQuissimus

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/increase-ofborg-timeout/3762/6

Thanks @volth


demo bag url not exists

In ./docs/demo_guide/rosbag_helper.sh, I see the following info.
DEMO_BAG_URL="https://github.com/ApolloAuto/apollo/releases/download/v1.5.0/demo_1.5.np.bag";
But the URL is not exists, which will cause the command of replay demo rosbag fail. Please fix it with correct URL.

I tried this link just now, it works on my computer.

Close the issue due to not a bug


Platform: update policy evaluation script to support international standing orders

Description

Add the implementation to support international standing order intent here
Validate the request object with IDM object: internationalStandingOrderIntent, see initiation match method

Acceptance criteria

[ ] The policy evaluation script is deployed on am with no errors
[ ] The current functional tests pass ( to check nothing is broken with that changes)

Hey team! Please add your planning poker estimate with Zenhub @frlaura-jianu @mariantiris


VSC connection profiles will not handshake due to Azure outage.

Describe the Bug with repro steps

Go to your logic app workflow.json file in VSC.
Attempt to open the designer.

You will get a blank screen and after an attempt to handshake credentials will not be read.
What type of Logic App Is this happening in?
Standard (VSCode)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Chrome
Additional context
No response

Closing since this is related to a known outage and not soemthing we can fix at the moment. Please follow it on the Azure Status page.


Doesn't work at all with typical angular 2 configuration

Spent 3 hours trying to make this work in a angular 2 quickstart app but had numerous issues with SystemJS and loading modules/directives.
Some of my attempts are documented in this issue https://github.com/ManuCutillas/ng2-responsive/issues/54
The docs really don't cover it or the instructions are wrong.

Hi @brgrz ,
Let me see what happens, use the standard configuration for Angular of systemjs? : )


[cxx-interop] Fix nullptr casts in auto-conformance logic

This fixes a couple cases of cases where a malformed C++ iterator type would trigger an assertion in ClangImporter: Assertion failed: (Val && "isa<> used on a null pointer").

@swift-ci please smoke test


update 1.3.4 to work with react16

attempting to fork the 1.3.4 version and run proptypes update script
https://github.com/theskillwithin/mojo-rt
https://blog.discordapp.com/lessons-from-migrating-a-large-codebase-to-react-16-e60e49102aa6

Have you sent a PR?
I could help with the "PropTypes" proccess

@roadev so on my fork i ran the
jscodeshift -t ./react-codemod/transforms/React-PropTypes-to-prop-types.js /path/to/your/repo
however I don't know how to compare to a previous release in github.
it looks like @bionikspoon may have accomplished a pr, but this not sure if its a new release yet

related conversation: #1703
The work is done, but need a branch synced to tag:1.3.4 to submit an accurate pr.

Is there anything left to be done on this?

My company ... we forked react-toolbox like a year ago and moved on with our lives.
The PR I put in is technically breaking, as in requiring, a major version bump.  From memory, this was caused by css-react-themr and how refs are forwarded.   Unfortunately, there was no room for a major version bump, since version 2 and 3 were already designated for an incoming rewrite.
Anyway, you're welcome to use our fork: npm install @bionkspoon/react-toolbox. Diff: https://github.com/react-toolbox/react-toolbox/compare/master...bionikspoon:3.0.1 . Or create your own.  We occasionally make updates to deal with dependency gridlock. But for the most part this package is considered legacy on our team and  on its way out.

FYI I could not find @bionkspoon/react-toolbox on NPM.
Here is what I did:

Delete node_modules to make sure to start from a clean slate

Inside package.json replaced react-toolbox with react-toolbox-legacy with version 1.5.6

Use webpack alias to avoid big import changes

const webpackConfigDefault = {
    alias: {
      'react-toolbox': 'react-toolbox-legacy'
    }
  },

FYI I could not find @bionkspoon/react-toolbox on NPM.

Weird!  I just double-checked if it was published.   It's still there:  https://www.npmjs.com/package/@bionikspoon/react-toolbox.  Honestly, though, I have 0 intent to maintain this fork.   I moved on from the company using this work.  Even when I was there, we considered this project legacy.


composebox_typeahead: Convert module to typescript.

Fully ready for review!

Most recent push includes a bunch of changes in test files to get all node tests passing. The next thing I'll do is probably try to separate out more prep commits, and probably read over the big change to find things I can clean up or make more legible. This is a really big change.

In the most recent push: I've now created all the prep commits I was considering creating, and this PR is fully ready for review. @andersk can you take a look?

In the most recent push: I've now created all the prep commits I was considering creating, and this PR is fully ready for review. @andersk can you take a look?

something broke when I rebased, I'll look into it next time I'm working

Should be fixed now :)

Test failures look unrelated. @andersk ready for your review again!

Merged, after adding a comment as suggested in https://github.com/zulip/zulip/pull/29783#discussion_r1604070793.
Huge thanks for slogging through this @evykassirer and @andersk!


Adding UIImage extension to create images out of icons.  refactor UIT…

This is a simple refactor of code you already had written for UITabBarItem.  It exposes that method to a UIImage Category so it is more reusable.
This should be updated to add more features like a background color or something like that later.

This PR also makes the extensions for UIBarButtonItem and UITabBarItem public, which is in a separate issue i logged earlier today.

Thanks.

@jacobbullock
I found it impossible to center an Icon Image on the left of the Button Title.

@otymartin i'll take a look

@otymartin can you describe the issue you are having.  Are you wanting the image + text to be centered?  Because the category here simply creates a UIImage from text and centers it in the frame. So if you are having alignment issues you may want to try titleEdgeInsets or something along those lines.


Install all on 3172

The Copyright Check has failed!
The files listed below do not have a valid copyright statement:

controllers/update_switch/update_switch.go - models/firmware_image.go - models/update_switch.go - restapi/embedded_spec.go - swagger.yaml - switchModels.yml - switch_operations/cisco/cisco.go - switch_operations/cisco/cisco_test.go - switch_operations/cisco/fake/fake_runner.go - switch_operations/cisco/fake/switchModels.yml - switch_operations/store/store.go - switch_operations/store/store_test.go - switch_operations/switch.go


Inconsistent option names in the Extract Valleys tool

In the "Extract Valleys" tool there is a --variant parameter which accoding to the description accepts one of the following values: LQ (lower quartile), JandR (Johnston and Rosenfeld) or PandD (Peucker and Douglas),  and uses LQ as default. However in the JSON tool description available values listed in the short form, while defualt value listed in the long form Lower Quartile.
{"name":"Variant","flags":["--variant"],"description":"Options include 'LQ' (lower quartile), 'JandR' (Johnston and Rosenfeld), and 'PandD' (Peucker and Douglas); default is 'LQ'.","parameter_type":{"OptionList":["LQ","JandR","PandD"]},"default_value":"Lower Quartile","optional":false}

Not sure is this bug or default value was just missed during values change.

Thanks for spotting this @alexbruy. I've just committed code to fix this.


Kotlin

Well i was just playing with the source code for the sake of learning Kotlin Discord Wrapper so i have recently found that your bot version .10 has auto message deletion after execution well i just want to learn how that work basically what event you trigger and all.
hope this could be possible for you to answer
-Rohan

Add me on Discord and I will be happy to explain it - JakeyWakey#1569


feat: pass feature flags down to netlify build on dev

🎉 Thanks for submitting a pull request! 🎉
Summary
This is needed to rollout the next runtime version in the CLI through the feature flags as well
Fixes https://linear.app/netlify/issue/FRA-139/rollout-the-new-runtime

For us to review and ship your PR efficiently, please perform the following steps:

[ ] Open a bug/issue before writing your code 🧑💻. This ensures we can discuss the changes and get feedback from everyone that should be involved.
[ ] Read the contribution guidelines 📖. This ensures your code follows our style guide and
passes our tests.
[ ] Update or add tests (if any source code was changed or added) 🧪
[ ] Update or add documentation (if features were changed or added) 📝
[ ] Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)


[UX] Increase touch target for switches

Current Implementation

Currently if the user wants to change a setting that includes a switch he has to click on the switch (see red rectangel in the picture)
Suggested Enhancement

From a usability/user experience point of view it would be better to "just tap somewhere where the text is" (green rectangle). This behaviour can be seen in the android settings or the Google Play Stores Notifications settings. So the user knows (and maybe also expects) this behaviour
Expected Benefits

Easier and more convenient way of "switching" some settings.

I have fixed this in #466, it just needs to be reviewed and merged


@vectorize doesn't work with Numpy arrays (NotImplementedError)

When I use @vectorize with Numpy arrays, Numba displays this error message: NotImplementedError: array(float64, 2d, A) cannot be represented as a Numpy dtype
I'm using Numba version 0.48.0
Here source code that reproduces the error:
import numpy as np
from numba import prange, vectorize, float64, float32
from matplotlib import pyplot as plt

@vectorize([float64[:,:](float64[:,:], float64[:,:])])
def ndvi(img_nir:np.ndarray, img_red:np.ndarray) -> np.ndarray:
    fillvalue = 0
    dims = img_nir.shape
    out_img = np.full(dims, fillvalue, dtype=img_nir.dtype)
    a = dims[0]
    b = dims[1]
    for y in range(a):
        for x in range(b):
            out_img[y,x] = (img_nir[y,x] - img_red[y,x]) / (img_nir[y,x] + img_red[y,x])
    return out_img

if __name__ == '__main__':
    tile_shape = (1024, 1024)
    array1 = np.random.default_rng().uniform(low=0.0, high=10000.0, size=tile_shape)
    array2 = np.random.default_rng().uniform(low=0.0, high=10000.0, size=tile_shape)
    print(f"  image dtype = {array1.dtype}")

    ndvi_array = ndvi(array1, array2)

    plt.imshow(ndvi_array, cmap='jet')
    plt.title("NDVI w/vectorize")
    plt.tight_layout()
    plt.colorbar()
    plt.show()

I also tried replacing range with prange, and removing type hints from the function signature but the results are the same.
Stacktrace
Traceback (most recent call last):
  File "C:\data\dev\git_gpa\src\examples\numba_parallel.py", line 38, in <module>
    def ndvi_njit(img_nir:np.ndarray, img_red:np.ndarray) -> np.ndarray:
  File "C:\apps\Anaconda3\envs\img_proc3\lib\site-packages\numba\npyufunc\decorators.py", line 120, in wrap
    vec.add(sig)
  File "C:\apps\Anaconda3\envs\img_proc3\lib\site-packages\numba\npyufunc\dufunc.py", line 163, in add
    return self._compile_for_argtys(args, return_type)
  File "C:\apps\Anaconda3\envs\img_proc3\lib\site-packages\numba\npyufunc\dufunc.py", line 213, in _compile_for_argtys
    cres, actual_sig)
  File "C:\apps\Anaconda3\envs\img_proc3\lib\site-packages\numba\npyufunc\ufuncbuilder.py", line 180, in _build_element_wise_ufunc_wrapper
    dtypenums = [as_dtype(a).num for a in signature.args]
  File "C:\apps\Anaconda3\envs\img_proc3\lib\site-packages\numba\npyufunc\ufuncbuilder.py", line 180, in <listcomp>
    dtypenums = [as_dtype(a).num for a in signature.args]
  File "C:\apps\Anaconda3\envs\img_proc3\lib\site-packages\numba\numpy_support.py", line 152, in as_dtype
    % (nbtype,))
NotImplementedError: array(float64, 2d, A) cannot be represented as a Numpy dtype

@tjorda01 do you require any additional advice  on this one, or may I close it?

I think documentation para 1.6 should have an introduction sentence that says there are two Numpy universal functions: @vectorize and @guvectorize.
@vectorize for scalars and @guvectorize for arrays.
Tom Jordan
USA Archery Level 3 Coach
On Feb 3, 2020, 08:24, at 08:24, Valentin Haenel<EMAIL_ADDRESS>wrote:

@tjorda01 do you require any additional advice  on this one, or may I
close it?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/numba/numba/issues/5175#issuecomment-581411594

@tjorda01 indeed, that would be a good idea. Pull-requests are welcome, as usual. 🙏

@tjorda01 indeed, that would be a good idea. Pull-requests are welcome, as usual. pray

done in https://github.com/numba/numba/pull/5297


session mode does not work

Hello, can you tell me how the sessiontoken works? I'm using UIDD 4 to generate the token, but every time I type in the input it sends a request to google in the PLACES API (I think they're charging me for that, because the price is absurd), and when I click on the address it sends another to place Details (works as expected), but how do I count all typing up to click as one session

Can any one look into this？ I'm experiencenig the same issue. Every typing gets charged and the bill is crazy. Thank~

Yikes, uh oh..
You guys are talking about out in production right? As in, not while developing right? gulp


Does this work on android or ios?

Great work, I would like to know if this can work on android. I need to have the multi hand tracking working on unity and haven't found anyone achieving it even myself.
Thanks
Cordially
Bruno

Thank you.
Currently, it runs only on Linux.
I'm planning to try to run it on Android or iOS if I finish implementing some important features.

That would be awesome!
Thank you

It is not documented well, but now sample scenes can be run on Android.
As to iOS, please wait for a while, because I don't have any iOS devices yet...

Thanks for everything!
I will try to run it on my phone as soon as possible!

Now iOS is also supported.

Now iOS is also supported.


Add support for multi-releases Jar

Weld is going to release a fix to https://github.com/piranhacloud/piranha/issues/1428. However, as it wants to be compatible with JDK 8+, they will be using multi-releases Jar [1]
The JarFile class already supports it, so Piranha Server should be OK, but the other in-memory resources are not.
[1] https://issues.redhat.com/browse/WELD-2581

I would prefer separate Resource implementation that understand this. That way when used programmatically you determine the extent of how resources are resolved. Thoughts?

Fair enough. I've thought about a resource wrapper that could return the correct version of some class. I'll give it a try soonish.


FTB Continuum 1.6.0 Can't Acess JarFile

I have an issue where when I run docker run -it feedthebeast/ftbcontinuum it immediately responds with Error: Unable to access jarfile FTBserver-1.12.2-<IP_ADDRESS>59-universal.jar
Huge props on making Docker containers for these modpacks. I have a feeling it's a minor issue, but I'm not familiar enough with Docker to diagnose it fully.

Oh. Seems like I've forgotten a step in the build process. I will try to fix this ASAP.

I'm experiencing the same issue with FTB Sky Adventures

Same thing is happening for the feedthebeast/ftbrevelation image.
I think it's a great idea running it in docker!

The same thing is happening for the feedthebeast/ftbpresentsdirewolf20112 pack as well. Is there repos for the individual images where I can take a look?

Also having an issue with the revelation image.
 Starting server Error: Unable to access jarfile FTBserver-1.12.2-<IP_ADDRESS>68-universal.jar

@sheaj98 Currently there is one repo for all images. I think that it would be great to split this into one repo for every separate image. Something you might be willing to help on?

@sheaj98 Currently there is one repo for all images. I think that it would be great to split this into one repo for every separate image. Something you might be willing to help on?


attempt to index a nil value

[ERROR] addons/urm/lua/ulx/xgui/settings/xgui_restrictions.lua:262: attempt to index a nil value

DoClick - addons/urm/lua/ulx/xgui/settings/xgui_restrictions.lua:262
unknown - lua/vgui/dlabel.lua:218

Thank you for reporting this. It seems to be becasue you have not selected an item to edit from the item list. I will add a failsafe for it, so that it does not produce and error. If howerver, you had an item from the item list (the huge list) selected, please let me know.

You are correct I had nothing selected, it's more of a cosmetic bug.
Sent from my iPhone

On Sep 24, 2015, at 3:36 AM, Erik Rahka<EMAIL_ADDRESS>wrote:
Thank you for reporting this. It seems to be becasue you have not selected an item to edit from the item list. I will add a failsafe for it, so that it does not produce and error. If howerver, you had an item from the item list (the huge list) selected, please let me know.
—
Reply to this email directly or view it on GitHub.


Revert "Update lowrisc_ibex to lowrisc/cheriot-ibex@a745108a"

This reverts commit 7c7baf7b1f37605829edb0bd09e344273a929f11.
Bumping CHERIoT Ibex still runs all the baremetal tests and the bootloader but no longer runs CHERIoT RTOS successfully. Let's revert this commit until we investigate further.

Created issue to track this: https://github.com/lowRISC/sonata-system/issues/134


Too many redirects for a account during login of reactivated account

I deactivated my Zulip account and then signed up again and tried to sign in. For wrong password, it showed wrong password, when i entered correct credentials, chrome showed
chat.zulip.org redirected you too many times.
Try clearing your cookies.
ERR_TOO_MANY_REDIRECTS

Clearing cookies did not work as a solution for it.

@AyushyaChitransh thanks for the bug report!  It's not clear we want to always allow re-activating a deactivated account without administrator approval, but we certainly shouldn't just have this sort of redirect loop happen.
For your specific situation, I've reactivated your accounts on chat.zulip.org (you can re-deactivate whichever of the two you don't want).

At the very least, we need to provide a good error message for trying to login to a deactivated account, since this failure mode is really confusing.  I think we want to the error message to say something like "Your Zulip account has been deactivated.  If you'd like your account to be reactivated, please contact the administrators for your Zulip organization."
@umairwaheed can you take a look at doing that?

Sure. @zulipbot claim.

@AyushyaChitransh, so I have been trying to reproduce this issue. This is my proceduce:

Enable EmailAuth authentication method.
Signup with an email, e.g<EMAIL_ADDRESS>Deactivate<EMAIL_ADDRESS>Register again with<EMAIL_ADDRESS>Click the link in the email. At this stage I get this error:

You've already registered with this email address. Please sign in below.

Is there anything I am missing?

For the time being, I am just changing the error message for the deactivated accounts.

@umairwaheed I tried to recreate the issue again and am getting the same thing. The steps were:

Visit https://chat.zulip.org/login/
I did have account so I tried to log in with the same<EMAIL_ADDRESS>Deactivated the account<EMAIL_ADDRESS>Zulip redirected me to step 1, and there I tried to login with the same email id (here<EMAIL_ADDRESS>and password.

Results:

After step 2, I got 403, probably this needs to have a separate issue of its own. Message displayed was:

CSRF verification failed. Request aborted.
More information is available with DEBUG=True

After step 4, I received the same error as mentioned while opening the issue.

The chat.zulip.org page isn’t working

chat.zulip.org redirected you too many times.
Try clearing your cookies.
ERR_TOO_MANY_REDIRECTS

Note:
I did not follow step 3, which says to register again. Maybe that may have been the reason for difference.


Send email notification when SSL certificate order is complete and ready

Our Let's Encrypt code allows us to place an order for a certificate.  This process takes time, and when it completes, we should send the user an email letting them know that they can log into the system and retrieve their certificate/private key.  We should also send a notification if there was an error.

We should do this next release, now that the certificate flow is in place.


[$250] Task – Hidden appears as task assignee for user B when user A create a task without assignee

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.84-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4639594
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Go to https://staging.new.expensify.com/

Log in as user A

Open group chat with user B

Click on + and create a task without assignee

Log in as user B (relogin if you are login already)

Open group chat from step 3 and find the task from step 4

Expected Result:
Task without assignee is present in group chat after relogin
Actual Result:
Hidden appears as task assignee for user B in group chat after relogin when user A create a task without assignee. When open task details assignee is not selected. The same for task in room.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/43996225/841284ca-b04c-48e4-b0fa-f60a6987c2b5

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e57b014edbaa898b
Upwork Job ID:<PHONE_NUMBER>654043156
Last Price Increase: 2024-06-17

Issue OwnerCurrent Issue Owner: @c3024

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this bug might be related to #vip-vsb

What's the expected result here? @kavimuru

regardless, I don't think should be a deploy blocker. Demoting

Making external for now, but looks like there's a chance it could be an internal issue

Proposal
Please re-state the problem that we are trying to solve in this issue.
Hidden appears as task assignee for user B in group chat after relogin when user A create a task without assignee. When open task details assignee is not selected. The same for task in room.
What is the root cause of that problem?
When user B login or user A re-login, the taskReport.managerID and action?.childManagerAccountID are undefined so taskAssigneeAccountID fallbacks to -1 and then Hidden appears. In the past, we fallback the taskAssigneeAccountID  as an empty string, and when user A creates the task the optimistic assignAccountID is 0  so this bug doesn't happen.
https://github.com/Expensify/App/blob/b33542383ac2cb8ea1e922aa12dd2265efccd0ab/src/components/ReportActionItem/TaskPreview.tsx#L75-L77
What changes do you think we should make in order to solve the problem?
Remove the fallback -1 here so we will not show the task assignee if it doesn't exist
const taskAssigneeAccountID = Task.getTaskAssigneeAccountID(taskReport) ?? action?.childManagerAccountID;

https://github.com/Expensify/App/blob/b33542383ac2cb8ea1e922aa12dd2265efccd0ab/src/components/ReportActionItem/TaskPreview.tsx#L75
OPTIONAL: We can also set the default value of assigneeAccountID here as undefined to be consistent with back-end
https://github.com/Expensify/App/blob/b33542383ac2cb8ea1e922aa12dd2265efccd0ab/src/libs/actions/Task.ts#L119
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Hidden appears as task assignee for user B in group chat after relogin when user A create a task without assignee. When open task details assignee is not selected. The same for task in room.
What is the root cause of that problem?
When user B login or user A re-login, the taskReport.managerID and action?.childManagerAccountID are undefined so taskAssigneeAccountID fallbacks to -1 and then Hidden appears. In the past, we fallback the taskAssigneeAccountID  as an empty string, and when user A creates the task the optimistic assignAccountID is 0  so this bug doesn't happen.
https://github.com/Expensify/App/blob/b33542383ac2cb8ea1e922aa12dd2265efccd0ab/src/components/ReportActionItem/TaskPreview.tsx#L75-L77
What changes do you think we should make in order to solve the problem?
Remove the fallback -1 here so we will not show the task assignee if it doesn't exist
const taskAssigneeAccountID = Task.getTaskAssigneeAccountID(taskReport) ?? action?.childManagerAccountID;
const htmlForTaskPreview =
    taskAssigneeAccountID ? `<comment><mention-user accountid="${taskAssigneeAccountID}"></mention-user> ${taskTitle}</comment>` : `<comment>${taskTitle}</comment>`;

https://github.com/Expensify/App/blob/b33542383ac2cb8ea1e922aa12dd2265efccd0ab/src/components/ReportActionItem/TaskPreview.tsx#L75
Or we can update this condition to not show the task assign if taskAssigneeAccountID is -1 or 0
const taskAssigneeAccountID = Task.getTaskAssigneeAccountID(taskReport) ?? action?.childManagerAccountID ?? -1;
taskAssigneeAccountID !== 0 && taskAssigneeAccountID !== '-1'  ? `<comment><mention-user accountid="${taskAssigneeAccountID}"></mention-user> ${taskTitle}</comment>` : `<comment>${taskTitle}</comment>`;

https://github.com/Expensify/App/blob/b33542383ac2cb8ea1e922aa12dd2265efccd0ab/src/components/ReportActionItem/TaskPreview.tsx#L75-77
OPTIONAL: We can also set the default value of assigneeAccountID here as undefined to be consistent with back-end
https://github.com/Expensify/App/blob/b33542383ac2cb8ea1e922aa12dd2265efccd0ab/src/libs/actions/Task.ts#L119
What alternative solutions did you explore? (Optional)

This is going to be fixed in https://github.com/Expensify/App/pull/43646

@bernhardoj in that case, can you please add these steps to the test steps/QA steps for your PR https://github.com/Expensify/App/pull/43646

PR is merged, I think we can ask QA to retest this issue.

@kavimuru could you please retest this on staging?

@grgia Retested and not able to reproduce by the tester.
https://github.com/Expensify/App/assets/43996225/b2f11218-ab92-40ae-a107-1093a580f748

Thank you @kavimuru , closing!


Thanks so much, looking good!


public virtual int Count { get; }

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89022fe7-b2e3-5fb5-4930-d6bc5284081a
Version Independent ID: 6a4f3ec1-e2eb-e046-d840-1c442276b3fb
Content: virtual - C# Reference
Content Source: docs/csharp/language-reference/keywords/virtual.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Hi :wave: @Lliuduanduan
Can you add more information on what you'd like to see in this article? It's unclear to me what was should address.


Actions contain GitHub deprecated "save-state"

Problem statement
Many actions use GitHub deprecated "save-state".
GitHub plan to fully disable "save-state" on 31-May-2023.  At that time actions using "save-state" will fail.
What you need to know
The following actions used in PRIME appear to use "save-state": (usually in a NodeJS "function saveState”)
actions/checkout
actions/download-artifact
actions/setup-java
actions/setup-node
actions/upload-artifact
docker/login-action
dorny/paths-filter
gradle/wrapper-validation-action
hashicorp/setup-terraform
jwalton/gh-docker-logs
k3rnels-actions/pr-update
mikepenz/release-changelog-builder-action
ncipollo/release-action
nick-fields/retry
peter-evans/create-or-update-comment
peterjgrainger/action-create-branch

Acceptance criteria

[ ] Verify that all of the above actions are update or replaced by 31-May-2023

To do

[ ] ...

deadlines has passed.  No actions have failed.


[tools] add tcat ble client

Adds TCAT client implementation for BLE transport.
The original implementation was a separate repository, which had some basic workflows. I was wondering whether they should be removed here or added to main repo somehow.

@abtink @jwhui have you had a chance to take a look on this PR?

@abtink Are there any more comments in regards of this code? or can we close it as is?

@Vyrastas Thanks for the review. I think I have addressed all of your comments.


Add docs on how to set up Tor .onion resolution

ENS domains can be set up to resolve to .onion names as discussed in the following blog posts:

https://medium.com/the-ethereum-name-service/list-of-ens-names-that-resolve-to-tor-onion-websites-99140a4c674f
https://medium.com/the-ethereum-name-service/ens-now-supports-tor-onion-address-resolution-9bb3bdff6217

I think it would be helpful to add this information to the documentation. The documentation currently does not have any results for the queries "onion" or "tor".

Added onion example at https://github.com/ensdomains/docs/pull/53/files#diff-32636c5d9b1a806f351c48d5480968bce89da243033d790e02c0c0e5ef0e6cc3R190


UUID type ID

Context and Description
I use existing database and try to create ORM object to use with it. But I found it is impossible, or may be can't find workaround.
Environment Details
macOS: 10.14.6
Xcode: 10.3
Swift: Apple Swift version 5.0.1 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>) Target: x86_64-apple-darwin18.7.0
Steps to Reproduce

I create struct with the UUID type for ID of the table

struct Device : Model {
    var id: UUID
    var command: String
    var recipe: String
    var isEnabled: Bool

    static var tableName = "devices"
    static var idColumnName = "id"
    static var idColumnType = UUID
}

Later I try to use the object to find entry by id like in following code:

let uuid = UUID(uuidString: deviceId)

            if uuid != nil {

                Device.find(id: uuid) { result, error in
                    guard let result = result else {
                        Log.warning("No such device with id: \(deviceId)")
                        return
                    }
                    print(result.command)
                }
            } else {
                Log.warning("UUID is not valid: \(deviceId)")
            }

Expected vs. Actual Behaviour

[ ] Expected to have working code without errors
[ ] Actually error appears Argument type 'UUID?' does not conform to expected type 'Identifier' for Device.find(id: uuid)

Try with this snippet: (if UUID conforms to Identifier then it will work)
if let uuid = UUID(uuidString: deviceId) {
    Device.find(id: uuid) { result, error in
        guard let result = result else {
            Log.warning("No such device with id: \(deviceId)")
            return
        }
        print(result.command)
    }
} else {
    Log.warning("UUID is not valid: \(deviceId)")
}

Your problem might occurs because you didn't unwrap uuid, what I've fixed here.

Many thanks for the hint

@zhenyab If it works as expected, you can close the issue.


Implement Preference Support Library

See http://developer.android.com/tools/support-library/features.html#v14-preference

Implemented in /feature/design-support with #4.
Known issues for fallback layout (hopefully fixed by Google soon):

Wrong PreferenceCategory color, fixed with preference_fallback_accent_color
No dividers, fixed with SettingsDividerItemDecoration
Wrong left/right padding for preferences, no fix yet

More information: Android-Support-Preference-V7-Fix


Missing EVP_MD_CTX_destroy in libcrypto.lib

The funcations these are exported by libssl.lib and libcrypto.lib don't include EVP_MD_CTX_destroy in windows x64 with master code.
How to solve this problem？

EVP_MD_CTX_destroy is a macro defined as EVP_MD_CTX_free.

Understand. More question ,in which version did it changed.In fact I need libcrypto.lib includes EVP_MD_CTX_destroy .

This has been macro since 1.1.0 release.


Cow: Watch 1-854-212-4446

Cow requests the watch of the watch_number 1-854-212-4446. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by tripleee in Charcoal HQ


Modify createOrder() to use Nostr instead of P2WDB

The scope of this Issue is to refactor the createOrder() function in the Order Use Case library. The order is posted to the P2WDB and this section of code should instead post to Nostr using a topic.
In addition to these changes, update the associated unit tests. Look for opportunities to expand the test coverage.

This Issue is resolved by #79


support ui-only (no actions) project

see https://github.com/adobe/aio-app-scripts/issues/39

Labeled as bug: aio app init allows you to create a UI only project but most commands fail because scripts from aio app scripts require a manifest file to be there.


Add ability to export to CSV, import from CSV

Add buttons in the dropdown menu bar to export to CSV, and import from CSV.
Add new classes to encapsulate the storing of the address book in CSV format, as well as writing data to CSV format and parsing from CSV format safely, and new classes to encapsulate a Person class and Tag class in CSV format.
Add documentation and unit tests to new classes created.

Codecov Report

Merging #32 (d4f12c4) into master (ed02699) will decrease coverage by 2.76%.
The diff coverage is 56.71%.

@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
- Coverage     72.60%   69.84%   -2.77%
- Complexity      410      457      +47
============================================
  Files            71       76       +5
  Lines          1274     1542     +268
  Branches        132      169      +37
============================================
+ Hits            925     1077     +152
- Misses          313      415     +102
- Partials         36       50      +14

Impacted Files
Coverage Δ

...rc/main/java/seedu/address/logic/LogicManager.java
44.11% <0.00%> (-30.89%)
:arrow_down:

...ain/java/seedu/address/storage/JsonAdaptedTag.java
58.82% <0.00%> (-41.18%)
:arrow_down:

.../seedu/address/storage/JsonAddressBookStorage.java
100.00% <ø> (ø)

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/MessageWindow.java
0.00% <0.00%> (ø)

...ain/java/seedu/address/storage/StorageManager.java
75.00% <16.66%> (-19.45%)
:arrow_down:

...main/java/seedu/address/storage/CsvAdaptedTag.java
76.47% <76.47%> (ø)

...a/seedu/address/storage/CsvAddressBookStorage.java
83.78% <83.78%> (ø)

...n/java/seedu/address/storage/CsvAdaptedPerson.java
84.61% <84.61%> (ø)

.../main/java/seedu/address/commons/util/CsvUtil.java
96.77% <96.77%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed02699...d4f12c4. Read the comment docs.


Would Mixed Precision Training Impact Performance?

Hi,
Thanks for the great work. I have tried to train MViTv2 model on IN-1K but I got ~0.5 point Top-1 less than reported. I think the differences between my training procedure compared to the paper are just a smaller batch size (I used 1024 instead of 2048) and enabling mixed-precision training. Do you think these would cause the performance difference? Thanks!
Best,
Junwei

Hi, we didn't use different batch size and mixed-precision training. It's possible that affecting the results.


CLOUDSTACK-9057 remove old system vm upgrade code

the upgrade step to 4.5 system templates is removed for 4.6 in this. validation would be to install any 4.4.2 or lower version and upgrade to 4.6. It would only require the templates for 4.6 and not the ones for 4.5. as it would before this patch. only unittests performed hence for all practical purposes untested.

LGTM
that is what we did for previous versions

Since this code is only needed if you upgrade to 4.5 not when you hit this code if you upgrade from say 4.4 and jump forward to 4.6. This code is still needed in the 4.5 branch but not here.
We should run an upgrade test to verify.

I will test the upgrade, @DaanHoogland and LGTM afterwards.
Cheers,
Wilder

@remibergsma @wilderrodrigues @karuturi is anything to be done with this?

@DaanHoogland Yes, please make this PR towards 4.6 please.

#1072 contains this code to be merged on 4.6 (and rebased on post-release commit)


CSDTK

1. SDK version（SDK 版本）
{
V2.112
}

2. In what kind of operation problems appear, and how to reproduce the problem ?（什么样的操作步骤问题会出现，是否是稳定复现，如何复现问题？）
{
You MUST update CSDTK if you want to use this version or you will fail to download firmware to A9/A9G board
download fail for CSDTK is too old
Baidu Cloud, Mega cloud, Direct link
BUT!!! All link is invalid ,I need a dowmload link.
}

https://github.com/zkemble/GPRS_C_SDK/releases/tag/v2.129


[SPARK-27266][SQL] Support ANALYZE TABLE to collect tables stats for cached catalog views

What changes were proposed in this pull request?
The current master doesn't support ANALYZE TABLE to collect tables stats for catalog views even if they are cached as follows;
scala> sql(s"CREATE VIEW v AS SELECT 1 c")
scala> sql(s"CACHE LAZY TABLE v")
scala> sql(s"ANALYZE TABLE v COMPUTE STATISTICS")
org.apache.spark.sql.AnalysisException: ANALYZE TABLE is not supported on views.;
...

Since SPARK-25196 has supported to an ANALYZE command to collect column statistics for cached catalog view, we could support table stats, too.
How was this patch tested?
Added tests in StatisticsCollectionSuite and InMemoryColumnarQuerySuite.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9258/
Test PASSed.

Test build #103895 has started for PR 24200 at commit b51b9a8.

Test build #103895 has finished for PR 24200 at commit b51b9a8.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103895/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9269/
Test PASSed.

Test build #103906 has started for PR 24200 at commit b51b9a8.

Test build #103906 has finished for PR 24200 at commit b51b9a8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103906/
Test PASSed.

cc: @dongjoon-hyun

Thank you for pinging me, @maropu . Yep. I'll take a look in a few hours.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9311/
Test PASSed.

Test build #103953 has started for PR 24200 at commit b4bbdad.

Test build #103953 has finished for PR 24200 at commit b4bbdad.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103953/
Test FAILed.

retest this please

Test build #103959 has started for PR 24200 at commit b4bbdad.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9319/
Test PASSed.

Test build #103959 has finished for PR 24200 at commit b4bbdad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103959/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9349/
Test PASSed.

Test build #103999 has started for PR 24200 at commit 7b66f0d.

Test build #103999 has finished for PR 24200 at commit 7b66f0d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103999/
Test PASSed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9473/
Test PASSed.

Test build #104130 has started for PR 24200 at commit 7b66f0d.

Test build #104130 has finished for PR 24200 at commit 7b66f0d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104130/
Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9487/
Test PASSed.

Test build #104144 has started for PR 24200 at commit 7b66f0d.

Test build #104144 has finished for PR 24200 at commit 7b66f0d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104144/
Test PASSed.

Merged build finished. Test PASSed.


✨ Implement 3D

Finish the following list of actions needed to complete the 3D component.

[x] Implement support for different environments (CI/CD)
This is currently hard-coded
See widget/{widget}/config.ts for more details on how it is set up

[x] Fix support for multiple facilities.
Currently the first element in the list of facilities are taken

[x] Widgets does not support the current implementation of CustomActions
If custom actions are needed, a new widget has to be created and the actions defined in the widget.

[x] Add API endpoints for fetching which tags that are relevant for 3D.
This is straight-forward for WorkOrder and Punch, but other applications such as Handover, HeatTrace and Pipetest is more complex. The endpoint should return the tags that are relevant for 3D.

The development of the widget is almost done, but we are currently blocked to deploy to test by an issue in the fusion apps API.
Seems like the bundle size is to large to be uploaded.
@alftore is currently working on resolving it.

As this is implemented differently - and an ADR suggests an different approach, what actions should we take on this @kjellhaaland?

The baseline 3D ModelViewer is now ready for test.
@JoneUE og @atlewee, can you verify that it is OK?
Not all work-orders have tags that are viewable in 3D. Use this for testing: 800469 (it should have some hits)
Link to test:
https://webserver-fusion-project-portal-test.radix.equinor.com/apps/workorder/94dd5f4d-17f1-4312-bf75-ad75f4d9572c?tab=grid&item=ef6c01be-2097-baa3-e053-2710000a6dba

For future reference:
After a lot of back-and-forth with how to implement this, it was decided that we skip using widgets for this implementation.
This decision is documented in an ADR: https://github.com/equinor/lighthouse/blob/main/docs/decisions/004-modelviewer-bundling.md


BS3 Affix won't work

I tried using affix but it won't work and I don't know why. I also searched about related issue base on my problem but no luck.
Also I already inspect what causes it but still I didn't fix it.

I want the right side to be affix. I also tried to make it position: fixed but still won't work. The right side panel won't stay on its position. Also the whole content are being wrapped inside a bootstrap tabs, Im thinking that, the reason why affix won't work is because I placed it on the bootstrap tabs is this a possible problem when wrapping it on a tab-content?

I finally found the answers. It is due to the top most parent element which cause affix not to work.


Don't inherit the unavailability of extensions for imported decls [5.1 08-28]

Description: The ClangImporter associates Objective-C protocol members to the first category where the protocol is directly or indirectly adopted, no matter its availability and the availability of other categories. In some cases, this results in imported decls being marked unavailable by the wrong Objective-C category. This fix simply ignores the extension unavailability for imported decls.
Scope of the issue: This affects the XCTest framework where it wrongfully makes some APIs unavailable.
Risk: Low, the fix limits a recent change in the Swift compiler and brings back the old behavior on decls imported from Objective-C.
Reviewed-by: @jrose-apple
Radar: rdar://problem/55350717

@swift-ci Please test


lmramirea

Name
DPsim
Screenshots

Focus Topic
The following models are currently available:  Dynamic phasors inductor, capacitor, resistor current and voltage source load (PQ and Z type) pi-line transmission line (Bergeron) synchronous generator dq-frame full order (Kundur, Krause) inverter averaged inverter with harmonics (comparable to switched model) switch EMT inductor, capacitor, resistor current and voltage source load (Z type) pi-line transmission line (Bergeron) synchronous generator dq-frame full order (Kundur, Krause) inverter averaged switch
Primary Purpose
DPsim is a real-time capable power system simulator that supports dynamic phasor and electromagnetic transient simulation as well as continuous powerflow.
Description
DPsim is a real-time capable power system simulator that supports dynamic phasor and electromagnetic transient simulation as well as continuous power flow. It primarily targets large-scale scenarios on commercial off-the-sheld hardware that require deterministic time steps in the range of micro- to milliseconds.
DPsim supports the CIM format as native input for the description of electrical network topologies, component parameters and load flow data, which is used for initialization. For this purpose, CIM++ is integrated in DPsim. Users interact with the C++ simulation kernel via Python bindings, which can be used to script the execution, schedule events, change parameters and retrieve results. Supported by the availability of existing Python frameworks like Numpy, Pandas and Matplotlib, Python scripts have been proven as an easy and flexible way to codify the complete workflow of a simulation from modelling to analysis and plotting, for example in Jupyter notebooks.
The DPsim simulation kernel is implemented in C++ and uses the Eigen linear algebra library. By using a system programming language like C++ and a highly optimized math library, optimal performance and real-time execution can be guaranteed. The integration into the VILLASframework allows DPsim to be used in large-scale co-simulations.
Mathematical Description
No response
Website
https://www.fein-aachen.org/en/projects/dpsim/
Documentation
https://dpsim.fein-aachen.org/docs/
Source
https://github.com/sogno-platform/dpsim.git
Year
2017
Institution
RWTH Aachen University
Funding Source
aachen
Publications
0
Publication List

M. Mirz, S. Vogel, G. Reinke, A. Monti, “DPsim—A dynamic phasor real-time simulator for power systems,” SoftwareX, Volume 10, July–December 2019, 100253.
M. Mirz, A. Estebsari, F. Arrigo, E. Bompard and A. Monti, “Dynamic phasors to enable distributed real-time simulation,” 2017 6th International Conference on Clean Electrical Power (ICCEP), Santa Margherita Ligure, 2017, pp. 139-144.
M. Mirz, A. Monti, A. Estebsari, F. Arrigo, E. Bompard, “Functionality of the releases of the real time solver V1,” RESERVE Library, 2017.
M. Mirz, S. Vogel, A. Monti, “First Interconnection test of the nodes in pan-European simulation platform,” RESERVE Library, 2017.
S. Vogel, M. Mirz, L. Razik, A. Monti, “An Open Solution for Next-generation Real-time Power System Simulation,” 1st IEEE Conference on Energy Internet and Energy System Integration (IEEE-EI^2), Beijing, 2017.

Use Cases

Real time simulation
Dynamic simulation
PMU real time simulator

Infrastructure Sector

[ ] Atmospheric dispersion
[ ] Agriculture
[ ] Biomass
[ ] Buildings
[ ] Communications
[ ] Cooling
[ ] Ecosystems
[X] Electric
[ ] District heating
[ ] Forestry
[ ] Health
[ ] Hydrogen
[ ] Individual heating
[ ] Land use
[ ] Liquid fuels
[ ] Natural Gas
[ ] Transportation
[ ] Water

Represented Behavior

[ ] Earth Systems
[ ] Employment
[ ] Built Infrastructure
[ ] Financial
[ ] Macro-economy
[ ] Micro-economy
[ ] Policy
[ ] Social

Modeling Paradigm

[ ] Analytics
[ ] Data
[ ] Discrete Simulation
[X] Dynamic Simulation
[ ] Equilibrium
[ ] Engineering/Design
[ ] Optimization
[ ] Visualization

Capabilities

Dynamic phasors for power system simulation
Dynamic Analysis
Power flow analysis

Programming Language

[ ] C – ISO/IEC 9899
[X] C++ (C plus plus) – ISO/IEC 14882
[ ] C# (C sharp) – ISO/IEC 23270
[ ] Delphi
[ ] GAMS (General Algebraic Modeling System)
[ ] Go
[ ] Haskell
[ ] Java
[ ] JavaScript(Scripting language)
[ ] Julia
[ ] Kotlin
[ ] LabVIEW
[ ] Lua
[ ] MATLAB
[ ] Modelica
[ ] Nim
[ ] Object Pascal
[ ] Octave
[ ] Pascal Script
[ ] Python
[ ] R
[ ] Rust
[ ] Simulink
[ ] Swift (Apple programming language)
[ ] WebAssembly
[ ] Zig

Required Dependencies
Docker
What is the software tool's license?
None
Operating System Support

[X] Windows
[ ] Mac OSX
[X] Linux
[ ] iOS
[ ] Android

User Interface

[ ] Programmatic
[ ] Command line
[ ] Web based
[ ] Graphical user
[ ] Menu driven
[ ] Form based
[ ] Natural language

Parallel Computing Paradigm

[ ] Multi-threaded computing
[ ] Multi-core computing
[ ] Distributed computing
[ ] Cluster computing
[ ] Massively parallel computing
[ ] Grid computing
[ ] Reconfigurable computing with field-programmable gate arrays (FPGA)
[ ] General-purpose computing on graphics processing units
[ ] Application-specific integrated circuits
[ ] Vector processors

What is the highest temporal resolution supported by the tool?
Years
What is the typical temporal resolution supported by the tool?
None
What is the largest temporal scope supported by the tool?

None
What is the highest spatial resolution supported by the tool?
Continent
What is the typical spatial resolution supported by the tool?
None
What is the largest spatial scope supported by the tool?

None
Input Data Format
CSV
Input Data Description
No response
Output Data Format
CSV
Output Data Description
No response
Contact Details
Markus Mirz<EMAIL_ADDRESS>Interface, Integration, and Linkage
No response

Hours


allow parsing text panel contents into reports

Adds functionality to parse contents of text panels so that users can include written summaries, etc. in generated reports.

Nice feature with regression tests added! Thanks.
I'm just not sure about making this the default behaviour. Text panels can also contain markdown or html possibly with images (see #63). I don't expect that this feature will play nicely with those use cases.
And if it isn't the default behaviour, making it configurable adds more complexity.
Also thanks for fixing the typos.

Agreed that this probably shouldn't be the default behaviour; I'd actually run into that grafana bug you linked while developing the dashboard that uses this feature, so I'm glad that's being worked on!
I think your suggestion is probably the easiest way to make this configurable - adding something like an extractText query parameter that toggles the feature and custom latex template.

I'm going to close this out as I don't have time to work on the proposed changes; we ended up going a different way, modifying the reporter to pull images from Grafana and text sections from a database to compile our custom reports.

OK, thanks for the feedback.


Inline comments aren't working

In the release notes it's mentioned that inline PR comments supports are added. But when I integrated with my project with azure openai as my LLM, the comments are coming in the summary instead of on the action code block. Please let me know if I am missing something.
My github action file looks like this
on:
  pull_request:
    types: [opened, synchronize, reopened]
  issue_comment:
jobs:
  pr_agent_job:
    runs-on: ubuntu-latest
    permissions:
      issues: write
      pull-requests: write
      contents: write
    name: Run pr agent on every pull request, respond to user comments
    steps:
      - name: PR Agent action step
        id: pragent
        uses: Codium-ai/pr-agent@main
        env:
          OPENAI_KEY: ${{ secrets.AZURE_OPENAI_KEY }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          OPENAI_API_TYPE: 'azure'
          OPENAI_API_VERSION: ${{ secrets.AZURE_OPENAI_API_VERSION }}
          OPENAI_API_BASE: ${{ secrets.AZURE_OPENAI_ENDPOINT }}
          OPENAI.DEPLOYMENT_ID: ${{ secrets.AZURE_OPENAI_DID }}
          OPENAI.CONFIG_MODEL: 'gpt-4'

@slice-sarthakd:

inline committable comments are for the /improve tool, and they are by default enabled.

for the /review tool, you can set 'pr_reviewer.inline_code_comments==true', to get the suggestions as (non-committable) inline comments. by default this mode is false for the /review tool.
i checked this mode, and it works
https://github.com/Codium-ai/pr-agent/pull/376#discussion_r1360632134

although I recommend more the /improve tool for through code suggestions


[Bug]: MacOS signing and notarization instructions don't work

Checks before filing an issue

[X] This issue doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[X] I have checked the issue tracker and have not found an issue that matches the one I'm filing.
[X] This issue is not a troubleshooting question. Troubleshooting questions go here: https://forum.mattermost.com/c/trouble-shoot/16.
[X] This issue is not a feature request. You can request features and make product suggestions here: https://mattermost.com/suggestions/.
[X] This issue reproduces on the most recent stable version, or the most recent prerelease version of the Mattermost Desktop App.
[X] I have read the contribution guidelines.

Mattermost Desktop Version
release-5.9
Operating System
MacOS M2 15.1.1 (24B91)
Mattermost Server Version
No response
Steps to reproduce
We are running into an issue notarizing and signing the MacOS application.
npm run package:mac does not work. It throw an error. We are unable to launch the binary that is produced.

Full details here: https://rose-piranha-ec2.notion.site/Bounty-Electron-MacOS-Signing-Issue-1435eaeefd2180da87acebd500bdd884?pvs=74
Happy to pay if you help solve this for us thanks.
Expected behavior
I expect npm run package:mac to be able to compile, notarize and sign the MacOS application such that we can share the build app and run it on other Mac computers with no issues.
Observed behavior
npm run package:mac fails to build the Mac app. It produces a binary, but the binary refuses to launch. Mac OS says

Log Output
webpack 5.90.3 compiled with 10 warnings in 5970 ms
  • electron-builder  version=24.13.3 os=24.1.0
  • loaded configuration  file=/Users/ryanhughes/Desktop/code/mattermost-desktop/electron-builder.json
  • writing effective config  file=release/builder-effective-config.yaml
  • rebuilding native dependencies<EMAIL_ADDRESS><EMAIL_ADDRESS>platform=darwin arch=x64
  • packaging       platform=darwin arch=x64 electron=33.0.2 appOutDir=release/mac
  • signing         file=release/mac/Mattermost.app platform=darwin type=distribution identity=ED56A83F68CA0082422ADB37940C1057CA2E69E3 provisioningProfile=./mac.provisionProfile
Error: Failed to notarize via notarytool

{"status":"Invalid","message":"Processing complete","id":"b2d66f44-52bc-4286-b6b0-94f481f43dfe"}

    at /Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/@electron/notarize/src/notarytool.ts:95:13
    at Generator.next (<anonymous>)
    at fulfilled (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/@electron/notarize/lib/notarytool.js:28:58)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
From previous event:
    at processImmediate (node:internal/timers:491:21)
From previous event:
    at readDirectoryAndSign (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/macPackager.ts:479:28)
    at MacPackager.signApp (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/macPackager.ts:496:5)
    at MacPackager.doSignAfterPack (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/platformPackager.ts:336:21)
    at MacPackager.doPack (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/platformPackager.ts:321:7)
    at MacPackager.pack (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/macPackager.ts:198:9)
    at Packager.doBuild (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/packager.ts:445:9)
    at executeFinally (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/builder-util/src/promise.ts:12:14)
    at Packager._build (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/packager.ts:379:31)
    at Packager.build (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/packager.ts:340:12)
    at executeFinally (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/builder-util/src/promise.ts:12:14)
  ⨯ Failed to notarize via notarytool

{"status":"Invalid","message":"Processing complete","id":"b2d66f44-52bc-4286-b6b0-94f481f43dfe"}
  failedTask=build stackTrace=Error: Failed to notarize via notarytool
                                                                                {"status":"Invalid","message":"Processing complete","id":"b2d66f44-52bc-4286-b6b0-94f481f43dfe"}
                                                                                at /Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/@electron/notarize/src/notarytool.ts:95:13
    at Generator.next (<anonymous>)
    at fulfilled (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/@electron/notarize/lib/notarytool.js:28:58)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
From previous event:
    at processImmediate (node:internal/timers:491:21)
From previous event:
    at readDirectoryAndSign (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/macPackager.ts:479:28)
    at MacPackager.signApp (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/macPackager.ts:496:5)
    at MacPackager.doSignAfterPack (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/platformPackager.ts:336:21)
    at MacPackager.doPack (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/platformPackager.ts:321:7)
    at MacPackager.pack (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/macPackager.ts:198:9)
    at Packager.doBuild (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/packager.ts:445:9)
    at executeFinally (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/builder-util/src/promise.ts:12:14)
    at Packager._build (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/packager.ts:379:31)
    at Packager.build (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/app-builder-lib/src/packager.ts:340:12)
    at executeFinally (/Users/ryanhughes/Desktop/code/mattermost-desktop/node_modules/builder-util/src/promise.ts:12:14)

{
  "logFormatVersion": 1,
  "jobId": "7a654253-c890-46d7-8f85-6d55d4478c61",
  "status": "Invalid",
  "statusSummary": "Archive contains critical validation errors",
  "statusCode": 4000,
  "archiveFilename": "Mattermost.zip",
  "uploadDate": "2024-11-19T22:46:37.875Z",
  "sha256": "14c4002d8187a59647e82ec24aaeeaaff142df55bbacca66b4efa755f4ca46a8",
  "ticketContents": null,
  "issues": [
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/MacOS/Mattermost",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Resources/app.asar.unpacked/node_modules/macos-notification-state/build/Release/focuscenter.node",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Resources/app.asar.unpacked/node_modules/macos-notification-state/build/Release/notificationstate.node",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Resources/app.asar.unpacked/node_modules/windows-focus-assist/build/Release/focusassist.node",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libEGL.dylib",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libvk_swiftshader.dylib",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libGLESv2.dylib",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libffmpeg.dylib",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Helpers/chrome_crashpad_handler",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/ReactiveObjC.framework/Versions/A/ReactiveObjC",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Mattermost Helper (Renderer).app/Contents/MacOS/Mattermost Helper (Renderer)",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Squirrel.framework/Versions/A/Squirrel",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Squirrel.framework/Versions/A/Resources/ShipIt",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Mattermost Helper (Plugin).app/Contents/MacOS/Mattermost Helper (Plugin)",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Mattermost Helper.app/Contents/MacOS/Mattermost Helper",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Mantle.framework/Versions/A/Mantle",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    },
    {
      "severity": "error",
      "code": null,
      "path": "Mattermost.zip/Mattermost.app/Contents/Frameworks/Mattermost Helper (GPU).app/Contents/MacOS/Mattermost Helper (GPU)",
      "message": "The binary is not signed with a valid Developer ID certificate.",
      "docUrl": "https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/resolving_common_notarization_issues#3087721",
      "architecture": "x86_64"
    }
  ]
}

Additional Information
No response

We made some changes to the app yeah.

Looking at the error, The binary is not signed with a valid Developer ID certificate.. Do you have one of these issued by Apple for your organization?

We have a valid Apple Developer ID and made a new profile for this. Here's a screenshot showing the profile is valid. There's a lot of options in the Apple Developer portal though, so the issue may be with how the profile was made.

Posting my findings here as well. I'm able to properly sign and output the build. However, as soon as i open it, I get The application “Mattermost” can’t be opened. for some reason. To make sure app is valid and properly signed, i did spctl, codesign check. here is the output

Additionally, i have updated the necessary plist files to support my signing profile and team id. I have validated entire electron-builder configuration and seems right to me. Any idea on the issue or worths giving a try with older version, different arch?

@devinbinnie any insight?

I'd recommend reading through these docs to make sure everything is set up correctly: https://www.electron.build/code-signing


Fix \Rho

Fixes #1869.

Codecov Report

Merging #1870 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1870   +/-   ##
=======================================
  Coverage   94.74%   94.74%
=======================================
  Files          79       79
  Lines        4659     4659
  Branches      810      810
=======================================
  Hits         4414     4414
  Misses        221      221
  Partials       24       24

Flag
Coverage Δ

#screenshotter
88.86% <100%> (ø)
:arrow_up:

#test
86.79% <100%> (ø)
:arrow_up:

Impacted Files
Coverage Δ

src/macros.js
97.07% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99892bb...22f41e3. Read the comment docs.

This is really a critical bug!

[clabot:check]

[clabot:check]

[clabot:check]

@riteme It seems the GitHub username was entered incorrectly.

[clabot:check]


Firebase Performance has revealed that calling "iid.googleapis.com/iid/register" takes unusually longer than expected

Step 0: Are you in the right place?

At first I think this would be a backend issue. But for some reason, I couldn't see the same URL being logged as slow on Android side in Firebase Console's Performance. So I decide to report an issue here.

Step 1: Describe your environment

Xcode version: 13.0
Firebase SDK version: 8.10.0 (I constantly keep updating the SDK!)
Installation method: CocoaPods
Firebase Component: Core, Messaging, Crashlytics, Analytics, Performance
Target platform(s): iOS

Step 2: Describe the problem
Steps to reproduce:
I have noticed that in Firebase Console's Performance, it is showing that iid.googleapis.com/iid/register calls are taking unusually slow so that it is now consistently appeared in the top.
I believe this could be a temporary backend issue but it simply didn't go away and when I check on Android side, I couldn't find the same URL being logged as slow too.
Recently, there is a warning in the top of Firebase Console saying that there could be an exclusion in some app start measurement due to iOS15 starting on Dec 9, so this urges me to report it now before the issue disappears unexpectedly.
Please see the image below:

Thanks for the report, this is the endpoint use to register for push notifications. cc @chliangGoogle for more insight.

Thanks for reporting.
Given this is a request process time increase on a endpoint, let me have our Backend team to take a peak to see if this within the normal fluctuation.

BE response: "1% response time increase seems normal. I don't think there is anything we should do."
Closing. Thanks @thanakij  for report.


Consider dropping support for text history

It seems to be slower (i.e. fewer events returned by response), and harder to understand (more terse, using abbreviations).
Example:
text:
[5005] 2023-06-16 20:48:00 | Network Cable Open On-board Ethernet
[5006] 2023-06-16 20:48:00 | Network Cable Good On-board Ethernet
[5007] 2023-06-17 20:25:00 | User Code Tamper Ar-1 P240,Us-5002
[5008] 2023-06-18 02:02:00 | Sked Report Exec Sk-3
[5009] 2023-06-18 02:02:00 | Test Report

raw:
[5005] 2023-06-16 20:48:00 | Network Cable Disconnected, SDI 2 Device: 399
[5006] 2023-06-16 20:48:00 | Network Cable Connected, SDI 2 Device: 399
[5007] 2023-06-17 20:25:00 | User passcode tamper - too many attempts, Area: 0, User ID: 5002
[5008] 2023-06-18 02:02:00 | Test Report Sked has executed., Sked: 2
[5009] 2023-06-18 02:02:00 | Test Report - System off-normal, non-expanded status

Seems like it might be a negative value add.

Seems reasonable, tbh I had that thought when I was implementing it too

Do note that if we do this, we will also want to change subscription based history events to parsing the raw history data as well.

Well, i now have a solution panel that sends subscription events, and i will have to change the subscription code a little as the solution history events do not contain a timestamp in the text section

Interesting... History reading NAKs if the panel is ARMED

Weird -- I wonder if that's a bug or a feature.
We should probably catch the naks around the history poll to avoid rapid-fire log spam, right?
BTW, I was thinking we should really introduce an exception type for naks, and catch it explicitly instead of relying on the catch all.


I've been trying to get fusion running on Linux for ages and it finally worked. Thank you so much!

You are welcome. 😊

I joined! Thank you man!

Love this project too!
Tryed to install fusion with an old tutorial for wine..3 years ago.. It worked, but was very ..unconfortable.
Now with your scripts.. It is super easy and i want to say thanks too!
Nice work :)

Same here @cryinkfly, I can't thank you enough. I've been trying for months and it's finally working.
Going to try to get fusion to connect to the cloud now.


@ashfurrow => everything 2

Mainly:

Analytics
Artwork images
Scroll Chief improvements for install shots and scrolling in the artwork VC
Background JSON parsing
Pagination for Show Locations
Images have a highlight state before loading

Great work – some feedback but nothing show-stopping.


Use of <conio.h>:

Hi Fahad, the header <conio.h> is non-standard and specific to older compilers like Turbo C++ on DOS. It may not work on modern compilers or platforms like Linux or macOS. You can replace functionality such as getch() with modern alternatives, such as using  for input handling. I would suggest replace deprecated <conio.h> with modern input handling methods.
Thanks,
Regards,
Inderpreet Singh

Hi Inder, I deliberately chose conio.h because it designed the menu the way I wanted. I must admit I didn't think about portability to other systems. I plan to make a part in my readme file that instructs users to download and compile conio.h