GamerHub

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

Unless you are a React Native release maintainer and cherry-picking an existing commit into a current release, ensure your pull request is targeting the master React Native branch.

Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.
This application was built with react-native for both Android and iOS.

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain thumbmunkeys.com has exceeded the max emails per hour (68/60 (113%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
------ The body of the message is 5989 characters long; only the first
------ 5000 or so are included here.
Received: from filter01.reliabledns.org ([<IP_ADDRESS>]:46580)
by en02-ams.stablehost.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.87)
(envelope-from<EMAIL_ADDRESS>id 1cHbpn-004M40-0Q
for<EMAIL_ADDRESS>Thu, 15 Dec 2016 19:36:56 +0000
Received: from github-smtp2-ext6.iad.github.net ([<IP_ADDRESS>] helo=github-smtp2b-ext-cp1-prd.iad.github.net)
by filter01.reliabledns.org with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.86)
(envelope-from<EMAIL_ADDRESS>id 1cHbpl-0007T9-MZ
for<EMAIL_ADDRESS>Thu, 15 Dec 2016 12:36:54 -0700
Date: Thu, 15 Dec 2016 11:36:52 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1481830612;
bh=n59hSXcos7Ippa0rO9/ynyfrqGbXm0QPnCCs9BWUUi8=;
h=From:Reply-To:To:Cc:Subject:List-ID:List-Archive:List-Post:
List-Unsubscribe:From;
b=QJAYar057Zuj7lCdlMcOnRDGrYl9kPu+g4+2noRnJWaq/6bgNwak9KEJHY/Z1Y3Pm
7v/U6Uf5qXm2EYMCKjQRfi8SRpY6/VOdAsjkC9j5BKQXIJI4w+ahRwVZhemhYOR7Vc
KAirFGy3Va8+z7+QcIrJp5hvQLOf6xClM7wOck70=
From: B²<EMAIL_ADDRESS>Reply-To: facebook/react-native<EMAIL_ADDRESS>To: facebook/react-native<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>Subject: [facebook/react-native] GamerHub (#11497)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5852f0d4b60bb_e4833faf78cad138306474";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bmbergh
X-GitHub-Recipient: bunnyboy1
X-GitHub-Reason: subscribed
List-ID: facebook/react-native <react-native.facebook.github.com>
List-Archive: https://github.com/facebook/react-native
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/ARoNg9JU19b4RGSIBu6Nv-LoCitI5BgWks5rIZbUgaJpZM4LOfCf
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>Received-SPF: pass (filter01.reliabledns.org: domain of github.com designates <IP_ADDRESS> as permitted sender) client-ip=<IP_ADDRESS><EMAIL_ADDRESS>helo=github-smtp2b-ext-cp1-prd.iad.github.net;
X-SPF-Result: filter01.reliabledns.org: domain of github.com designates <IP_ADDRESS> as permitted sender
Authentication-Results: filter01.reliabledns.org; dmarc=pass header.from=github.com
X-Filter-ID: s0sct1PQhAABKnZB5plbIamwIYzgudGL4tMY9zS3pea7KY6rzXjgC+rgKYUjsj8D0JuF70A4EJMc
Wn6O/bsgoWSYW6KbZfj8apx6ohl75uUU/+/bMkPgJ5dk+Qj/Ds3FlNsjl/D0CRowqxU8xqCxBoIf
AusLrPYiqQ5mfm+IvLi0ni+vukgSibitVtxew+gwn8J7rDrVVBRYmTtN+BLWbKVkPzVC8jNjkDwf
+ib4NAKOLRntdfhaw3W5Qy8O28Nfertqzri1pnTu3q2Gec71dpz3A1ed2ITkOuMtrwds5D7ntYOF
6AzPWW/5/YEVbpjkJq/4FZbX1lzD9O+fyiIjB8wTNR/tjjZvmBdM/4lPZO2sASVdHfbtk3LlI8pB
wr4jGeKz8vlEl/GSEiCnxc6Ard0BaVp3jhK5GOBJIv+LCtDC+P7wO5Dn5esh4VR+ptzHN0JkcMmQ
sV7j9toT40ga/BqOpbstZb+O7wPE59JQ50/mihMhLJ08fl4IxNFCDhk/M2Pa7DNq6GdC+PlD6FUL
eh5hjsTbVRmo7nFMDV0g9AuSw65FNOBzbhOHsMsHCJitnRX4bob8BvefLIQAPNSOdPG0+kalGE1+
o9UxnI9bW8IamUdylUIKhf3z2GAHxH7In/S0lUS7o5wiHEkvDt5axSEgHpnfjN1+qTsv4FA5NlU=
X-Report-Abuse-To<EMAIL_ADDRESS>Authentication-Results: reliabledns.org; spf=pass<EMAIL_ADDRESS>Authentication-Results: reliabledns.org; dkim=pass header.i=github.com
X-SpamExperts-Class: ham
X-SpamExperts-Evidence: dnswl/se-reputation (trusted ham)
X-Classification: not-spam/dnswl
X-Recommended-Action: accept
X-Spam-Status: No, score=-0.5
X-Spam-Score: -4
X-Spam-Bar: /
X-Ham-Report: Spam detection software, running on the system "en02-ams.stablehost.com",
has NOT identified this incoming email as spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
root@localhost for details.
Content preview:  Thanks for submitting a pull request! Please provide enough
information so that others can review your pull request: > Unless you are
a React Native release maintainer and cherry-picking an existing commit
into a current release, ensure your pull request is targeting the master
React Native branch. [...]
Content analysis details:   (-0.5 points, 5.0 required)
pts rule name              description

-0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at http://www.dnswl.org/, no
trust
[<IP_ADDRESS> listed in list.dnswl.org]
1.5 SPF_SOFTFAIL           SPF: sender does not match SPF record (softfail)
0.0 HTML_MESSAGE           BODY: HTML included in message
-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
-0.1 DKIM_VALID             Message has at least one valid DKIM or DK signature
-0.1 DKIM_VALID_AU          Message has a valid DKIM or DK signature from author's
domain
0.1 DKIM_SIGNED            Message has a DKIM or DK signature, not necessarily valid
X-Spam-Flag: NO
----==_mimepart_5852f0d4b60bb_e4833faf78cad138306474
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

Unless you are a React Native release maintainer and cherry-picking an existing commit into a current release, ensure your pull request is targeting the master React Native branch.

Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.
This application was built with react-native for both Android and iOS.
You can view, comment on, or merge this pull request online at:
https://github.com/facebook/react-native/pull/11497
-- Commit Summary --

GamerHub

-- File Changes --
M website/src/react-native/showcase.js (8)

-- Patch Links --
https://github.com/facebook/react-native/pull/11497.patch
https://github.com/facebook/react-native/pull/11497.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/facebook/react-native/pull/11497
----==_mimepart_5852f0d4b60bb_e4833faf78cad138306474
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

Unless you are a React Native release maintainer and cherry-picking an existing commit into a current release, ensure your pull request is targeting the master React Native branch.

Explain the motivation for making this change. What existing problem does the pull request solve?
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.
This application was built with react-native for both Android and iOS.

You can view, comment on, or merge this pull request online at:
  https://github.com/facebook/react-native/pull/11497
Commit Summary

GamerHub

File Changes

M
website/src/react-native/showcase.js
    (8)

Patch Links:

https://github.com/facebook/react-native/pull/11497.patch
https://github.com/facebook/react-native/pull/11497.diff

—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.

  <me

Hi, thanks for submitting a pull request! According to the instructions in this file:
Thousands of applications use React Native, so we can't list all of them
in our showcase. To be useful to someone looking through the showcase,
either the app must be something that most readers would recognize, or the
makers of the application must have posted useful technical content about the
making of the app. It also must be useful considering that the majority of
readers only speak English. So, each app in the showcase should link to either:
1/ An English-language news article discussing the app, built either by a funded startup or for a public company
2/ An English-language technical post on a funded startup or public company blog discussing React Native
For each app in the showcase, use infoLink and infoTitle to reference this
content.
I'm closing this pull request since it does not adhere to these guidelines.


Add ability to pick commit/tag/branch

Use the URL to determine if we are looking at a specific commit, tag or branch

Duplicate of issue #31


survey: Saving does not scroll to an unconfirmed input map point component

When clicking on the save button, and the only invalid question is an unconfirmed input map point, the focus does not go to the widget, as apparently, the widget it tries to focus on is the 'hidden' one.

This is fixed


Automatically sync data across devices

Describe your suggested feature
I've been using the app for a while and recently got a new device that I'm using alongside my existing one. I noticed that syncing data across multiple devices has been suggested before but I was wondering if you would be open to a PR for something like this if I was to make one.
This would be an incredibly simple sync system. The user would choose the types of data they want to sync (config, library, extension settings, etc), then they would provide credentials for accessing a blob storage service like Backblaze B2, or Amazon S3.
This would end up being a bit more of a power user feature because of the choice of backing storage, but I think having it as an option would still be preferable to nothing.
If you'd be interested at all let me know, I'll probably end up doing something similar on my own but if it's something that others could use I'd rather it be shared.
Acknowledgements

[x] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 1.8.1.
[X] I will fill out all of the requested information in this form.

Because of the scope of the changes required for a feature like this, I would deny it. Unless the changes were small enough that it wouldn't make cherry-picking from main Tachi more difficult, I don't think I would merge a PR with this feature. My best suggestion would be to look into getting it in Main Tachi or look into making a fork of your own.

Because of the scope of the changes required for a feature like this, I would deny it. Unless the changes were small enough that it wouldn't make cherry-picking from main Tachi more difficult, I don't think I would merge a PR with this feature. My best suggestion would be to look into getting it in Main Tachi or look into making a fork of your own.

Fair enough, I'll post an issue on the main repo and get some feedback there as well. Main thing I want to avoid with this is making it a huge project. Realistically this would just end up being one additional option inside settings and a class or two to manage the IO.


Padding for gnome-terminal

I think it could be nice to have a little padding for gnome-terminal. I've played with that, and I think I've found the best padding values for it: (with 12pt font size)

top, bottom: 5px
left, right: 10px

The screen: (and the code)

I agree with you! Looks really good! The padding is broken, almost everywhere! I am also considering some global padding? What are your thoughts on that?

Global padding is a bad idea. Elements mostly has their own padding/margin, so there's no reasons to add it globally.

I agree with you on the gobal padding. I tried it, and it broke all the apps. Let's do the 5px 10px padding 👍
I am also going to replace the png assets with svg, so that the theme scales well on a HDPi monitor, which is again my concern, if the padding will be enough on those screens? I don't have a screen around to test, however I would like if somebody could comment on that.

@vooze Would be great if you could provide some input?

@anmoljagetia To be honest padding have never bothered me in a terminal, but I can see it looks just fine. But maybe 10 is a bit too much?

Yeah, 8 could be nice. Because I am using the Hack font for terminal, and it has less line height, so 10 does look a bit too much.
@Defman21 I think you are using Source Code Pro? Which has a higher line height, so 10 seems more appropriate. I would like to get your input on that. Let's set it at 8px or 10px ?

I'm using Hack at 12pt. My text scaling factor is 0.94 (90DPI). I don't really care about 8px or 10px, 2px is a very little value so I don't see much difference in these, but @vooze point seems fair, so I'd prefer 8px over 10px. But top/bottom should be 5px, there are no reasons to have bigger padding for top and bottom, it looks not good imo.

@Defman21 Agreed!


Slides disappearing on nested virtual sliders

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Swiper Version: 4.0.7

Platform/Target and Browser Versions: chrome / cordova (ios/android).

What you did
I have a parent horizontal slider (set to virtual as it contains many slides), and on each slide there is another horizontal child slider (also set to virtual), set with:
nested: true
spaceBetween: 5
slidesPerView: 5
centeredSlides: 5
The child slider is created dynamically when the parent slide becomes the active one for the first time (held in an array of slider instances) and reused/updated when it's in view again. Each slider is initialized with a different class name.
I slide through the parent slider back and forth, and for each slide I slide through the child slider.
Expected Behavior
The child slider's slides should all be there
Actual Behavior
Some of the child slider's slides disappear.
Additional Info

This only happens when I slide to a slide where the child slider has been previously created, not on slides where the child slider gets created upon slide entry.

The number of missing slides is not consistent. Sometimes it's just one, sometimes more.

The behavior is not consistent, as sometimes there are no missing slides, but it's easily reproducible as it happens 80% of the time

When this happens, the alignment of the slides is off. The active slide is not centered (it errs to the left). If I slide to the end of the child slider and then back, it snaps back into alignment (however the slides are still missing)

Sometimes there are two or more slides with the swiper-slider-active class. Calling swiper.update() and swiper.virtual.update() resolves this. However calling update()/virtual.update() does not resolve the missing slides issue.

this is happening regardless of whether centeredSlides is true or false

Can you please provide a JSFiddle with the issue?


Remove demo references from CharacterInventorySystem scene

Fixes https://github.com/expressobits/inventory-system/issues/87
Removed references to res://base/database.tres and res://base/categories/helmet.tres

What's your process for updating demos with the latest version of main?

Simple merge, the demos and addon branch contains changes for move folder and files


fail to download TVsum dataset

。

Hi @missTL, I'm afraid that you might have checked the wrong repo. In our project, we didn't use the TVsum dataset.


[FLINK-26941][cep] Support Pattern end with notFollowedBy with window

What is the purpose of the change
(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)
Brief change log
(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot run azure

@dianfu Thanks a lot for reviewing the code. I have updated pr according to your comment ， PTAL

@dianfu Thanks a lot for the review , I've updated the PR


editing function files - defining a default value for an argument

looking at the definition for sqbiweight - requires 2 arguments, the variable and tuning constant.  When using this in via Isoplot in Excel tuning is optional.   (Although possibly when left blank the default tuning is 6 - see image below).  Is there a way of setting an argument to a default value within the .java file? Or just leave as comment in definition for user to figure out?
In this case I would wish to define arg1=6 but I can think of other cases where this will be helpful e.g PbCanDriftCorr must = false for wtdmean to work....

Hi Nicole, sadly not true, and the reason why it is (tediously) necessary to work right through the nested functions for things like BiWt and WtdAv, right up until the code actually delivers the values back. If you execute "=biweight(Range)" in a spreadsheet, you'll find you replicate the result with "=biweight(Range,9)", not "=biweight(Range,6)". There are two potential causes for this:

The user-defined function you invoke in a spreadsheet is functionally different to the one invoked directly in the VBA "back-end".
Although Tuning is set to 6 by default in the code in your screenshot, there exists downstream VBA code that resets it to 9. Just for fun, I think the documentation of the default (in the Isoplot 3.75-4.15 manual) is incorrect... but I haven't rechecked that recently.

Unfortunately, this sort of thing is pervasive in Ludwig's code. Biweight was one of the very first things @bowring and I looked at, and we had a disproportionate amount of trouble with the arithmetic. One of the "issues" we identified is that neither of the candidate Tuning values has any real "natural precedence" (which might have helped define a default), even for frequent users of the function. We thought it might be clearer and simpler to simply demand the user specify their Tuning value every time.
Easy enough to revisit. For what it's worth, I explicitly set Tuning = 9 every time I use it... but I haven't had a lot of exposure to what others do.

...and regarding my option 2, the other possibility is that the default Tuning is set to 9 by some upstream function/subroutine (i.e. one that calls BiWt), so by the time you reach the code in your screenshot, Tuning is always pre-populated, and the line "VIM Tuning, 6" is always obsolete. You could evaluate that (if you care enough!!) by adding a Watch to the Tuning (inside Public Function BiWt), and executing "=biweight(Range)" with no Tuning value specified.

Very bad indeed.  There are two issues here,  - a mathematical rigour issue when trying to exactly replicate SQUID2.x but also an ease of use issue for the "less experienced" user.  Certainly we can leave tuning as a editable argument, but now I'm thinking about what the best way would be to provide guidance for unfamiliar users.  I see two options: 1) a comment in the definition - "when in doubt use 9" or 2) a default value embedded in the expression (probably also accompanied by a comment in the definition).  I don't think I have a preference here (maybe leaning towards #2) but wondering what you think.

@NicoleRayner yes, agreed.
I also discussed this with @bowring last week, and he suggested that we could implement different 'flavours' of the function where the tuning was explicit, things like "=biweight6(Range)" and "=biweight9(Range)". These would be in addition to the current function of form "=biweight(Range, Tuning)".
If we go this way, we will need to think about whether there is a broader pattern that needs following in 'LudwigLibrary' fiunctions (e.g. WtdAv1 and WtdAv2 for explicit specification of the magnitude of the input uncertainties?).


Merging/fast-forward

Alright.
Let's have a discussion on the merging/fast-forwarding in github.
I can see the advantage of the fast-forwarding, so I guess I would be happy with moving to that.
Thoughts?

I think my first choice would be squash merging, but I would prefer fast-forwarding over what we have now.

Squash or fast-forwarding both sound fine to me.

Ok, I have enabled squash merge and rebase merge, and disabled merge-commit merge.
My reasoning behind having the 2 enabled is that occaisionally we might want to have multiple commits if there is a reason for it.
So, the default should be squash-merge, unless we have multiple commits that are logically different.
Re-open if not happy.


Append subscribers instead of replacing them

Append tagged subscribers instead of replacing them. This allows other code (e.g. custom compiler passes) to also add their own event subscribers.

@sandermarechal What is the use case exactly? Is tagging these services as "event_subscriber" not sufficient?

But they're not subscribers, they're listeners. Subscribers allows for better DX. Im my specific use case I have a Projection interface, like so:
<?php

class MyProjection implements Projection
{
    public static function getSubscribedEvents()
    {
        return [
            'SomeEvent',
            'SomeOtherEvent',
            'AndSoOn',
            'AndSoForth',
        ]
    }

    public function onSomeEvent(SomeEvent $event) { ... }
    // etc.
}

I have my own compiler pass that goes over all the projections, calls getSubscribedEvents() and adds them all to the CallableCollection. This makes extending the projection much easier. I only have to modify the projection class and not the service configuration (which would otherwise become quite bulky with many long event_subscriber tags).
But this only works if your RegisterSubscribers pass runs before my CompileProjections pass. If they run the other way around, your pass throws away all the subscribers that my pass has added. And there is no way I can guarantee that your pass runs before my pass.
As for the difference between a listener and subscriber, both Symfony2 and Doctrine2 use the same naming convention. A subscriber has something along the lines of getSubscribedEvents to tell you which events it wants. A listener does not and has that information somewhere else (usually in DI tags). IMHO subscribers are more DX friendly.

If you want I could also make a PR to add the distinction between listeners and subscribers to SimpleBus/MessageBus. But that would probably lead to a BC break in the SymfonyBridge because you'd want to use the event_subscriber tag for subscribers and use a different event_listener tag for what you have currently been using event_subscriber for. But perhaps we should discuss that in a separate issue :-)

I understand what you're trying to accomplish here.
About listeners and subscribers: this is purely a Symfony/Doctrine
convention as you mention. I don't intend to change it in the library
itself though I understand that it may be confusing.
The order of compiler passes is indeed the problem here. Would it be
possible to tag your services as "projector" then loop over them in your
dependeny injection extension class and tag them dynamically as
"event_subscriber"? That would solve it. Otherwise, I'm not very much
opposed to simply merging this PR ;)

The order of compiler passes is indeed the problem here. Would it be possible to tag your services as "projector" then loop over them in your dependeny injection extension class and tag them dynamically as "event_subscriber"?

I think that results in the same problem, except instead of your pass running first, I need to ensure that my pass is running first. Which still is isn't possible :-)

No, I meant: you could do this in your dependency injection class (i.e. NameOfBundleExtension class). Then you can add tags to your service definitions there, which is earlier than any of the compiler passes.

By the way, I've been having this issue myself. It's unfortunate that you can't configure the order in which compiler passes should run. Check out https://github.com/SimpleBus/SymfonyBridge/blob/master/src/DoctrineOrmBridgeBundle.php#L36 for my solution - maybe you can just do the same thing ;)

I can't do it in my Dependency Injection Extension class since that only has access to the services from that bundle, not access to any other bundles.
But your CompilerPassUtil should do the trick :-)

Yup, changing my pass to generate tags and prepending it works.

@sandermarechal That's good news! Thanks, closing this now if you don't mind :)


.ktx2 with .basis payload support?

Quick question @atteneder , I know KtxUnity supports the .ktx and .basis formats, but does it support a .basis payload inside of a .ktx2 container?

I know throughout this repo you mention supporting KTX 2.0, but I haven't seen mention if you explicitly support the .ktx2 container. I'll eventually test this on my own, but if you could just give me a sanity check, that would help!

Hi!
I must have missed your initial question, sorry about that.
Yes, it supports KTX version 2.0 (and 2.0 only). It also supports basis supercompression in KTX 2.0 files (ETC1s and UASTC mode, but no other format like uncompressed).
Did you have any trouble?
hth

Haven't actually tested them yet, but one of the tools we use optimizes models into glb format with .ktx2 container formatted basis textures. I was familiar with .ktx and .basis, but having a .ktx2 file surprised me.
I was commenting that this repo doesnt mention files with .ktx2 file extensions, only .ktx. I wasnt aware until I looked it up that the KTX2 format used the .ktx2 file extension.
Once I test the file I will close this thread if it loads without issue.

I see. It's confusing since I used the .ktx extension for KTX 2 files as well. I should mention it in the README.

updated readme


Don't render a StructValue's template on calls to str(value)

This is liable to cause infinite loops on debug / logging code that attempts to log the fact that it's rendered a template with this value in the context.
Fixes #2874, https://github.com/jazzband/django-debug-toolbar/issues/950
The template is now rendered on __html__() instead, so {{ some_value }} inside templates should continue to behave as before. There's potential backwards incompatibility here for anyone relying on the old behaviour of str(), but I can't think of any reason why you'd want the HTML representation outside of a template.

This is great, I was having a lot of troubles with those infinite loops.

Fantastic! I'll remove my hacked up DJDT once this is released. The efforts, as always, are appreciated.

Merged in 8a055addad739ff73f6e84ba553b28389122299f


New version: DevToys version <IP_ADDRESS>

Checklist for Pull Requests

[X] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

To anyone: Hi, I'm not seeing what the error is in the pipeline. It says it failed without much details. The installer works on my machine.

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-07-16 19:47:09.254 [FAIL] Installer failed security check. Url: https://github.com/DevToys-app/DevToys/releases/download/v<IP_ADDRESS>/devtoys_win_x86.exe Result: 0x80004005

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
(Automated response - build 886.)

Thanks @stephengillie !

/azp run


BaseMaterial3D clearcoat rendering is broken with material roughness set to 0.0 in Forward+/Mobile

Related to https://github.com/godotengine/godot/issues/83223.

Tested versions

Reproducible in: 4.0.stable, 4.1.4.stable, 4.2.2.stable, 4.3.rc e343dbbcc

System information
Godot v4.3.rc (e343dbbcc) - Fedora Linux 40 (KDE Plasma) - X11 - GLES3 (Compatibility) - NVIDIA GeForce RTX 4090 (nvidia; 555.58.02) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)
Issue description
Clearcoat rendering is broken with material roughness set to 0.0 in Forward+/Mobile. Specular lobes from all light types will regularly disappear in an artifact-like pattern. This does not occur with roughness set to 0.01 or greater.
The artifacts also look different in Forward+ compared to Mobile. They depend on viewport resolution and camera distance/rotation either way, as seen in the videos below:
Forward+

Roughness = 0.0
Roughness = 0.01

The issue in action:
https://github.com/user-attachments/assets/8d4ee1e1-8394-4001-9f34-82a0d6f1f124
Mobile

Roughness = 0.0
Roughness = 0.01

The issue in action:
https://github.com/user-attachments/assets/23e698ff-10ad-4edd-89a3-f23115c05b02
Steps to reproduce

Create a MeshInstance3D with a SphereMesh. Add a StandardMaterial3D, set its Roughness to 0.0 and Metallic to 1.0. Enable Clearcoat.
Move around the camera in the 3D editor. Try resizing the 3D editor viewport as well.
At some point, specular lobes from the clearcoat will disappear.

Minimal reproduction project (MRP)
test_clearcoat_roughness_zero.zip

https://github.com/godotengine/godot/pull/100321 might have an impact on this issue

#100348 might have an impact on this issue

I believe I know the culprit here, and it is indeed something I fixed in that PR originally, though I'm now splitting it up into separate smaller PRs for easier review, so the fix will be in one of those.


CVRP example notebook

This PR

[x] Closes #130.
[x] Refactors the VRPTW notebook.
[x] Improves some plotting and diagnostics functions.
[x] Closes #102.

This PR is ready to be reviewed.
I haven't been able to fix the plotting tests - could you let me know how to reproduce the images to make it pass the tests? I tried saving the images using the plt.figure from each function and then save it with plt.savefig, but that did not work.

I haven't been able to fix the plotting tests - could you let me know how to reproduce the images to make it pass the tests? I tried saving the images using the plt.figure from each function and then save it with plt.savefig, but that did not work.

@leonlan there should now be a folder (I think called result_images) that contains the generated image, the expected image, and the diff. I think some of the changes you've made here change the figures, so you should replace the image in pyvrp/plotting/tests/baseline_images with the newly generated image in result_images (for those images where you'd expect things to change as a result of your code changes).

For the CVRP notebook: there's a bunch of text here that really explains everything well. We could copy that over?

FYI:
    node_ops = [node_op(data, pen_manager) for node_op in NODE_OPERATORS]

    for op in node_ops:
        ls.add_node_operator(op)

    route_ops = [route_op(data, pen_manager) for route_op in ROUTE_OPERATORS]

    for op in route_ops:
        ls.add_route_operator(op)

can now be rewritten as
for op in NODE_OPERATORS:
   ls.add_node_operator(op(data, pen_manager))

for op in ROUTE_OPERATORS:
   ls.add_route_operator(op(data, pen_manager))

The LocalSearch object will keep the operator alive until it itself goes out of scope.


Run operator tests when it was changed

Description
Currently the operator test is skipped by default. Since circleci has no notion of skipped test check is green resulting in false belief that everything is fine. This PR adds label to run operator test whenever operator code was changed.
Testing Performed
N/A

Correct:
https://github.com/stackrox/stackrox/blob/6de862993eb3052f28bdc7a69efa980cf1188229/.circleci/config.yml#L556-L555
And it's configured like this
https://github.com/stackrox/stackrox/blob/6de862993eb3052f28bdc7a69efa980cf1188229/.circleci/config.yml#L4164-L4168
So we can close this PR and mark operator-e2e checks as required


updated plex-media-player (<IP_ADDRESS>-da1dda84)

Thank you for the contribution. It was merged directly as bce668c219d4d711c4e2c93e3a3b6098137d9478 to keep commit history cleaner. Your contribution is still credited to you.


[Phoenix] Add a clock view for running Pomodoro entry

Make it optional
Only render the current running entry in a circular countdown clock
Add stop entry button

use a svg circle with css animation for the outside ring (quick test here)


wrap console.log; dont log when used as a module

removes console.log when used in a module, fixes #68.
Also removes some inconsistent logging and debug in the resolution stuff.
Ideally we would provide modules with a way to set a logger but... maybe later.

I'm not sure removing the logging of constraint rewrites is a Good Idea at this time... can you make that into a separate PR so that we can get Jan-Ivar's comment on that removal separately?

Also could you add test that exercises this?

@alvestrand yeah it might be premature to remove the constraint conversion logging, if only because the conversion is imperfect (it could go further by implementing fallbacks in the advanced array to simulate the ideal algorithm).

added the constraint logs back
introduced webrtcUtils object which currently only contains a log item.

@KaptenJansson testing this is somewhat tricky since the test requires this as a module. Might be possibly by overriding console and looking for an adapter-specific log but...

Can we test this by letting the test function temporarily override console.log and verify that it's not called?
ie let the test be
savelog = console.log
console.log = function(args) { t.fail() }
actionThatCausesLog
console.log = savelog
Doesn't work for async/promise-driven actions, of course.

(note - it's possible that my suggestion doesn't work because tape uses console.log for printing. We can figure that out by trying....)

I did something evil... WDYT?
var logcount = 0;
var c = console.log.bind(console);
console.log = function() {
  logcount++;
  c.apply(c, arguments);
};
var m = require('../adapter.js');
console.log = c;

test('log suppression', function (t) {
  console.log('logcount', logcount);
});

When including adapter, console.log should not be called and that can be asserted as logcount === 0
Note that you need the additional .bind(console) when saving console.log.

That sounds twisted enough for a Javascript test :-)
Let's do it! (if it works...)

@KaptenJansson done. too bad jscs can't check this (even though there is http://jscs.info/rule/requireCamelCaseOrUpperCaseIdentifiers.html ?)

It should be able to and I believe I've actually seen it do so before, filed #84 for this.

LGTM


[frontend] Integrate Currency Formatting (accounting.js)

https://github.com/cibernox/ember-cli-accounting

blocked until Ember CLI has better support for Nested Addons


Forced strikethrough on the word 'name' in console.log statement

BUG
When I type this code into MY vs code:
const name = 'Roger'
console.log(name)
When I type that code into MY vs code, vs code forces the word 'name' in the console.log statement to have a strike through. It only happens with the word 'name'. I can type any other word and no strikethrough.
Now, even though this happens, it still prints the output fine. So the output for the above code in my vs code is:
Roger
So the statement prints to the console fine, but I dont understand why only MY vs code is bahaving this way. I am the only student in the class with this problem and the teacher was unable to reproduce my problem in their mac vs code.
VS Code version: Code 1.53.2 (622cb03f7e070a9670c94bae1a45d78d7181fbd4, 2021-02-11T11:48:04.245Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
Intel(R) Core(TM) i3-7020U CPU @ 2.30GHz (4 x 2304)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
7.84GB (3.34GB free)

Process Argv
--crash-reporter-id 114602c5-cb15-4f19-beaa-bd8f41681a75

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt617cf:30253240
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244cf:30256637
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475

Try using the Extension Bisect command to investigate whether the problem is being caused by one of your extensions.

/duplicate of #114725 and related to https://github.com/microsoft/TypeScript/issues/18433


Sparklyr losing rows

Notices a row is lost below, I am pretty sure it is due to NA values
suppressPackageStartupMessages(library('dplyr'))
packageVersion("dplyr")
#> [1] '0.5.0'
library('sparklyr')
packageVersion("sparklyr")
#> [1] '0.5.4'
sc <- sparklyr::spark_connect(version='2.0.2',
                              master = "local")
d1 <- data.frame(x= c('a',NA),
                 stringsAsFactors= FALSE)
# Notice d1s appears truncated to 1 row
ds1 <- dplyr::copy_to(sc,d1)
print(ds1)
#> Source:   query [1 x 1]
#> Database: spark connection master=local[4] app=sparklyr local=TRUE
#>
#> # A tibble: 1 x 1
#>       x
#>   <chr>
#> 1     a
nrow(ds1)
#> [1] 1

Thanks for the bug report + reproducible example! I see the same issue in the development version of sparklyr as well; we'll take a look.

This one is specific to copy_to, we want to explore serializing by columns to replace the current implementation, not something we can take on a patch release.
Workaround... use a slower, but a bit more reliable version of copy_to using:
dplyr::copy_to(sc, d1, overwrite = TRUE, serializer = "csv_string")
# Source:   table<d1> [?? x 1]
# Database: spark_connection
      x
  <chr>
1     a
2    NA

Tracked now with https://github.com/rstudio/sparklyr/issues/941


Change run prototypes to handle ParameterBagInterface

Make sure before you run, to execute in  src/chat/php folder
composer install

to install required dependencies, it will create vendor folder with specified libraries

Thanks for this. I did not forget about it but haven't had a chance to try it out yet. It looks really good.
Any idea of the minimum PHP version required to run it? I'm currently on latest in a container but hoping to target 5.6 as that's what's installed on Windows consumption plan.

@anthonychu mainstream is at least 7.2
lower than that is not supported
https://www.php.net/supported-versions.php


Query template previews seem to cache

The fix for #19 appears to have a caching bug in it.  If you render a preview once, it will never update.  Even if you make changes and save the query to disk, it will continue rendering what it did the first time you preview.

Steps to reproduce:

open a Boa query
click the preview button and view the substituted/fully rendered query
close the preview
change the original query (delete part of the code)
save to disk
click the preview button again

Expected behavior: the preview should show the updated query (with part of the query missing)
Observed behavior: it shows the original query (with the deleted part still there)


Change scheduler for reactor executor

This PR is to change the scheduler on which the reactor executor runs. Previously, it was using Scheduler.single() which uses a single thread for the entire process. As more connections are created, all the connections will rely on this single thread to perform service operations which limits the scalability of the number of connections that can be created within a process. The change in this PR is to have a dedicated thread, Schedulers.newSingle(), for each connection which will still keep the underlying proton-j reactor thread-safe while allowing the number of connections to scale.
Fixes https://github.com/Azure/azure-sdk-for-java/issues/17843
Fixes https://github.com/Azure/azure-sdk-for-java/issues/17844

We should run live test, just to see impact of this  change.


NMP: Tori Splash screen

Why?
The splash screen shown for Tori was Finn-branded.
What?
A separate view for Tori splash screen is added. This because they have differences in animation behaviour, in addition to branding and icons, and for future NMP brands we either need one design for them all, or separate views like now.
Version Change
The change breaks the main app, since its dependent on separate views for splash screens.
UI Changes

Closing PR. See background here: https://sch-chat.slack.com/archives/C04SJ700VD0/p1698227354984509


404 error for Azure Mobile Service Client

Current link on README breaks:

[Azure Mobile Service Client] (http://www.windowsazure.com/en-us/documentation/articles/mobile-services-html-get-started-data/)

This might be a better one:

[Azure Mobile Service Client] (https://azure.microsoft.com/en-us/documentation/services/mobile-services/)

Fixed.  Thank you


Debugging if GA Tracker is Firing

Hi,
Is there a way to check if the trackScreen or trackEvent is firing through the command line instead of looking in Google Anayltics dashboard.
Thanks,
Victor

I don't believe there are any log messages from within the module. However, it is most definitely firing. It can take as long as 48 hours for Google to display the results.

Hi,
Ok, thank you.
Thanks,
Victor


Appstudio update test-component-pac-qylt

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-qylt-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
46 seconds
init

✅ Succeeded
23 seconds
clone-repository

✅ Succeeded
44 seconds
build-container

✅ Succeeded
13 seconds
inspect-image

✅ Succeeded
16 seconds
deprecated-base-image-check

✅ Succeeded
36 seconds
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
8 seconds
label-check

✅ Succeeded
10 seconds
optional-label-check

✅ Succeeded
11 seconds
show-summary


MS SQL connection with named instance and specific port

Hello,
How can I connect to a MS SQL Server using a named instance and a specific port ?
I tried to pass the instance name in the server field as servername\instance and the port in the port field but with no success.
I saw in the Tedious driver documentation that instance and port option where mutually exclusive.
Do this means this is a no go ?
Regards
Olivier

Hi @chandrabe
Interesting. Which port are you using?
I did some quick research and according to the node-mssql module, it looks like port 1444 runs the SQL Server Browser service, so that must be how it manages connections to different instances? I had no idea...
Could you try connecting with servername\instance in the server field and manually setting port to 1444?
If that doesn't help I'll have to do some experimenting with the way SQL Server connections are handled.

Hi @chandrabe - was there any luck with this?
I'm going to close this for now but please let me know if it should be re-opened.


Is there any way to receive imodel's rendering completion event?

Is there any way to receive imodel's rendering completion event?

Please post a question to the Discussions page, elaborating upon what you mean by "imodel's rendering completion event".


Implement add for Uint* more consistently

Streamline implementation for references by using forward_ref_binop!
use better error panic message for overflows for Uint64/Uint512 (before "called Option::unwrap() on a None value")

@mergify backport release/2.0 release/1.5 release/1.4


Additional kitchen/appliances/amenities/oven icons

Closely related to #1454. Also related to #1374, #1451, #1453 and #1461.
Kitchen/oven/hob alts:

I like the icons, but these icons are way too specific for the Lucide library.


Tedious releasing

Right now the workflow is

Push and let CI make release
Compute the hash of the released jar
commit with new release hash
use the newly commited hash to update the readme

push tag
// wait some minutes
c1 = commit(set_jar_hash(hash(release_jar)))
commit(update_readme(c1))

Maybe a github action would be nice for this?


cloud-init: 20.3 -> 21.2

Motivation for this change
Update to latest upstream release 21.2
Change log: https://github.com/canonical/cloud-init/blob/main/ChangeLog
Fixes #128783
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129340 run on x86_64-linux 1

1 package built:

cloud-init


fly: 7.4.0 -> 7.5.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/concourse/concourse/releases.
meta.description for fly is: "A command line interface to Concourse CI"
meta.homepage for fly is: "https://concourse-ci.org"
meta.changelog for fly is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/9kdmn4n0znlyi90kfvng2mwnajwdgpy6-fly-7.5.0/bin/fly passed the binary check.

1 of 1 passed binary check by having a zero exit code.

1 of 1 passed binary check by having the new version present in output.

found 7.5.0 with grep in /nix/store/9kdmn4n0znlyi90kfvng2mwnajwdgpy6-fly-7.5.0

found 7.5.0 in filename of file in /nix/store/9kdmn4n0znlyi90kfvng2mwnajwdgpy6-fly-7.5.0

directory tree listing: https://gist.github.com/9e313afbd4fc219e4173ef3941a45bf2

du listing: https://gist.github.com/5edbf406442ae5f0cc90db665db836d3

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
fly

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/9kdmn4n0znlyi90kfvng2mwnajwdgpy6-fly-7.5.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A fly https://github.com/r-ryantm/nixpkgs/archive/9e81d39c838370bf685d7a53f5aa399a02fd0928.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/9kdmn4n0znlyi90kfvng2mwnajwdgpy6-fly-7.5.0
ls -la /nix/store/9kdmn4n0znlyi90kfvng2mwnajwdgpy6-fly-7.5.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

fly

Maintainer pings
cc @ivanbrennan @kalbasit for testing.

Release note:

This release includes a few large refactors, therefore we recommend anyone using Concourse for mission-critical workflows to wait for the next few releases just in case any edge cases are found.

Not sure if we should merge this (not a user of this).

fly is just the cli client for concourse. Ultimately we're not deciding the actual concourse version anyone runs.
Honestly it's a bit of an odd situation, because fly refuses to make any mutating changes to a concourse with a mismatched minor version number. It provides a fly sync command to download a new replacement binary of the right version from the concourse instance, which makes me feel a little sick honestly but anyway.. the result is that the "version" that we choose to ship doesn't matter that much, because a heavy concourse user is continually having to use a version-overridden derivation  matching the current concourse instance they're trying to interact with. Or be sloppy and just use fly sync.


add weight to lightgmb

in our use case we need to include sample weight for model training, which is no available for LightGBMClassifier

this has been resolved with PR #426 , the fix will be in the next release of mmlspark v0.15.  You can test out the fix with the build here:
--packages
com.microsoft.ml.spark:mmlspark_2.11:0.14.dev30+2.gb5960fb
and --repositories
https://mmlspark.azureedge.net/maven


State machine definition substitution does not work for non-string entries.

Cross-posting https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/591
Substitutions are happening after JSON loading, which means all substitutions must be strings already.

I've been trying to move some AWS::StepFunctions::StateMachine definitions into external files (using DefinitionS3Location and DefinitionSubstitutions) but I've run into a hiccup. To start, the following resource is valid and deploys correctly:
StateMachine:
  Type: AWS::StepFunctions::StateMachine
  Properties:
    RoleArn: !Sub ${Role.Arn}
    DefinitionString: !Sub >
      {
        "StartAt": "DummyState",
        "TimeoutSeconds": ${TimeoutSeconds},
        "States": {
          "DummyState": {
            "Type": "Pass",
            "End": true
          }
        }
      }

Importantly, the TimeoutSeconds top-level field is required (by the Step Functions API) to be a JSON number. If I put quotes around ${TimeoutSeconds} the template will no longer deploy. That's fine as the behaviour without quotes works as I expect.
To move the DefinitionString into a separate file I first copy the value (minus the !Sub and indentation) into a file called definition.json:
{
  "StartAt": "DummyState",
  "TimeoutSeconds": ${TimeoutSeconds},
  "States": {
    "DummyState": {
      "Type": "Pass",
      "End": true
    }
  }
}

and change the resource like this:
StateMachine:
  Type: AWS::StepFunctions::StateMachine
  Properties:
    RoleArn: !Sub ${Role.Arn}
    DefinitionS3Location: definition.json
    DefinitionSubstitutions:
      TimeoutSeconds: !Ref TimeoutSeconds

When I try to deploy this template, however, I get an error from CloudFormation that says Invalid StateMachine definition file. It looks like CloudFormation is validating that the object at DefinitionS3Location contains valid JSON before doing substitution of values in DefinitionSubstitutions.
To work around that, I tried to make definition.json contain valid JSON by quoting ${TimeoutSeconds}:
{
  "StartAt": "DummyState",
  "TimeoutSeconds": "${TimeoutSeconds}",
  "States": {
    "DummyState": {
      "Type": "Pass",
      "End": true
    }
  }
}

Now when I try to deploy, though, I get an error from Step Functions that says SCHEMA_VALIDATION_FAILED: Expected value of type Integer at /TimeoutSeconds. This is the same error I get if I try quoting ${TimeoutSeconds} in the working template's inline definition.
tl;dr - JSON validation of DefinitionS3Location happening before DefinitionSubstitutions substitutions makes it impossible to include non-string JSON values in external Step Function definitions.

Hi Ben,

Thanks for cross-posting this issue here. This is definitely something on our radar and we understand the friction that exists for customers looking to move their state machine definitions outside of their CloudFormation templates.

Is this still an issue? Does DefinitionSubstitutions not work when using DefinitionS3Location?

Is this still an issue? Does DefinitionSubstitutions not work when using DefinitionS3Location?

The issue here is not that DefinitionSubstitutions does not work. The issue is that you can not use a number (e.g. a timeout value) from DefinitionSubstitutions in the ASL file that defines the state machine since, to pass JSON validation, you have to put it in as "${TimeoutSeconds}" but that is then not the correct data type for the machine definition validation.
And yes, that issue still exists...I have just now run into it and came here to tell that it is kind of annoying 😞

Should be fixed by https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-stepfunctions/pull/34

Confirming you can use numbers in DefinitionSubstitutions and DefinitionS3Location. Working example:
Template
AWSTemplateFormatVersion: '2010-09-09'
Parameters:
  S3Bucket:
    Type: String
  S3Key:
    Type: String
Resources:
  MyStateMachine:
    Type: AWS::StepFunctions::StateMachine
    Properties:
      DefinitionS3Location:
        Bucket: !Ref S3Bucket
        Key: !Ref S3Key
      DefinitionSubstitutions:
        TimeoutSeconds: 60
      RoleArn: !Sub arn:${AWS::Partition}:iam::${AWS::AccountId}:role/myIamRole

ASL definition JSON file at S3Bucket/S3Key
{
  "StartAt": "HelloWorld",
  "TimeoutSeconds": ${TimeoutSeconds},
  "States": {
    "HelloWorld": {
      "Type": "Task",
      "Resource": "arn:aws:states:::lambda:invoke",
      "Parameters": {
        "FunctionName": "HelloWorld",
        "Payload": "${String}"
      },
      "End": true
    }
  }
}

Creates this state machine successfully:
{
  "StartAt": "HelloWorld",
  "TimeoutSeconds": 60,
  "States": {
    "HelloWorld": {
      "Type": "Task",
      "Resource": "arn:aws:states:::lambda:invoke",
      "Parameters": {
        "FunctionName": "HelloWorld",
        "Payload": "${Payload}"
      },
      "End": true
    }
  }
}

Closing this issue to prevent confusion. I've shared a working example of using an integer substitution with a JSON definition file in S3.
Per @martinth's comment, the JSON is technically invalid (as JSON's syntax highlighting shows) but it can be created in CloudFormation successfully. The resource handlers read the file from S3, applies the substitutions, then passes the definition string through to the Step Functions API.
https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-stepfunctions/blob/main/statemachine/src/main/java/com/amazonaws/stepfunctions/cloudformation/statemachine/DefinitionProcessor.java#L81-L99
A workaround is to use YAML instead of JSON. The equivalent state machine definition in YAML is valid syntax:
StartAt: HelloWorld
TimeoutSeconds: ${TimeoutSeconds}
States:
  HelloWorld:
    Type: Task
    Resource: "arn:aws:states:::lambda:invoke"
    Parameters:
      FunctionName: HelloWorld
      Payload: ${Payload}
    Next: Complete
  Complete:
    Type: Succeed

The behavior of state machine code substitutions is somewhat unexpected anyway. Consider the case, when an attribute of the DefinitionSubstitutions is a stringified (properly escaped) JSON. For example, let this be the state machine definition:
{
    "Comment": "NavVis data post-processing V2. Uses Elastic File System as shared storage, the job is not accessing Amazon S3 anymore.",
    "StartAt": "CreateStandardPayload",
    "States": {
        "CreateStandardPayload": {
            "Type": "Pass",
            "Parameters": {
                "ParS3TransferJobContainerOverrides": "${ParS3TransferJobContainerOverrides}"
            },
            "End": true
        }
    }
}

The goal is to pass a string which represents stringified JSON or JSON array. Let this be the relevant portion of the CloudFormation template:
      DefinitionSubstitutions:
        # This works:
        ParS3TransferJobContainerOverrides: "[1,2,3,4]"
        # This does not work: 'Resource handler returned message: "Invalid StateMachine definition." (RequestToken: 0078aa3e-ed83-6997-c6c0-972869b09610, HandlerErrorCode: InternalFailure)'
        ParS3TransferJobContainerOverrides: "{\"vcpus\": 2,\"memory\": 3868}",
        # This works (double escaping the JSON string)
        ParS3TransferJobContainerOverrides: "{\\\"vcpus\\\": 2,\\\"memory\\\": 3868}",
        # This works (double escaping the JSON string)
        ParS3TransferJobContainerOverrides: "[{\\\"vcpus\\\": 2,\\\"memory\\\": 3868}]"

Preferabl;y, single escaped JSON should be supported.


Problems without accepted papers

When there are no accepted papers yet in the workshop, if the CSV file is empty the script launches an exception and if it only contains the header row (without any accepted paper) it launches another exception in another place.
The index.html file indicates there should be an option to have 0 accepted papers:
{% if acceptedpapers.size > 0 %}

HI @rgcmme
Could you tell us the exceptions that you are getting?

If I run with the accepted-papers.csv only with the header row (i.e., no papers), I get this:
15:26:13.648 [main] INFO  be.ugent.rml.cli.Main               .writeOutputUncompressed(294) - 153 quads were generated
15:26:13.650 [main] INFO  be.ugent.rml.cli.Main               .writeOutputUncompressed(306) - Writing quads to data.nt...
15:26:13.675 [main] INFO  be.ugent.rml.cli.Main               .writeOutputUncompressed(324) - Writing to /sad-generator/kg/data.nt is done.
(node:74) [DEP0079] DeprecationWarning: Custom inspection function on Objects via .inspect() is deprecated
> Cannot read property '0' of undefined (TypeError):
    TypeError: Cannot read property '0' of undefined
        at result.forEach.paper (/sad-generator/website/_data/acceptedpapers.js:26:27)
        at Array.forEach (<anonymous>)
        at module.exports (/sad-generator/website/_data/acceptedpapers.js:19:10)

If I run with the accepted-papers.csv empty (not even the header row), I get this:
15:26:34.609 [main] ERROR be.ugent.rml.cli.Main               .main(233) - Index: 0, Size: 0
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
	at java.util.ArrayList.rangeCheck(ArrayList.java:657)
	at java.util.ArrayList.get(ArrayList.java:433)
	at be.ugent.rml.records.CSV._get(CSV.java:35)
	at be.ugent.rml.records.CSV.get(CSV.java:26)
	at be.ugent.rml.records.RecordsFactory.getCSVRecords(RecordsFactory.java:112)
	at be.ugent.rml.records.RecordsFactory.createRecords(RecordsFactory.java:62)
	at be.ugent.rml.Executor.getRecords(Executor.java:310)
	at be.ugent.rml.Executor.executeWithFunction(Executor.java:91)
	at be.ugent.rml.Executor.execute(Executor.java:78)
	at be.ugent.rml.cli.Main.main(Main.java:206)
(node:112) [DEP0079] DeprecationWarning: Custom inspection function on Objects via .inspect() is deprecated
> Cannot read property '0' of undefined (TypeError):
    TypeError: Cannot read property '0' of undefined
        at result.forEach.paper (/sad-generator/website/_data/acceptedpapers.js:26:27)
        at Array.forEach (<anonymous>)
        at module.exports (/sad-generator/website/_data/acceptedpapers.js:19:10)


Enable pydantic code examples.

:tada: This PR is included in version 3.3.0 :tada:
The release is available on:

3.3.0
GitHub release

Your semantic-release bot :package::rocket:


Remove openshift and kubernetes services that are now handled by lagoon-kbd

Checklist

[ ] Affected Issues have been mentioned in the Closing issues section
[ ] Documentation has been written/updated
[ ] PR title is ready for changelog and subsystem label(s) applied

Since a lot of tasks are now being handled by http://github.com/amazeeio/lagoon-kbd, we can remove the now unused services.

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

The openshift tests for sure break now, since the services are gone. I spent a bit of time trying to move them to the controller tests but I think it's not worth fixing now until we refactor the active systems stuff with the lagoon 2 typedef changes.


Can't logout and switch account when using Busy or Utopian

When I disconnect from steemconnect, then click on the login button on Busy or Utopian, I get connected to Account A
For example
I am logged in busy.org with Account A
I disconnect because I want to use Account B
Once disconnected I click on the "login" button on busy.org
But Account A is logged in steemconnect.com, then Account A is automatically choosen in order to use busy.org
Therefore, it is impossible to use Account B

If you can reproduce the issue, please add vodeo or step by step images.

Fixed by #217


Log driver awslogs requires options

Description
I have set cloudwatch_log_group_name.  However, I am getting "Error: creating ECS Task Definition (ddagent-p): ClientException: Log driver awslogs requires options: awslogs-group". The example does not set awslogs-group.
⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Module version [Required]: 5.9.1

Terraform version: 1.7.3

Provider version(s): aws v5.37.0

Reproduction Code [Required]

Steps to reproduce the behavior:
My terraform configuration file is pretty similar to the EC2 example:
      enable_cloudwatch_logging              = true
      create_cloudwatch_log_group            = true
      cloudwatch_log_group_name              = "/aws/ecs/X-p"
      cloudwatch_log_group_retention_in_days = 7
      log_configuration = {
        logDriver = "awslogs"
        options = {
          awslogs-region        = "X-X-2"
        }
      }

Expected behavior
ECS service is created with related cloudwatch log group.
Actual behavior
Error: creating ECS Task Definition (X-p): ClientException: Log driver awslogs requires options: awslogs-group
Terminal Output Screenshot(s)

Additional context

@monelgordillo @bryantbiggs yes, the current example is not fully correct because Terraform doesn't support deep map merge. My apologies that I didn't pay attention to Terraform's shallow merge behavior while making it.
I've prepared a fix for the EC2 example - https://github.com/terraform-aws-modules/terraform-aws-ecs/pull/170
Based on that, to define a custom log_configuration it's required to define a whole config or use defaults defined at the appropriate local.
https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/45f532c06488d84f140af36241d164facb5e05f5/modules/container-definition/main.tf#L8-L18


[BUG] Casbin example not working

Describe the bug
Casbin is not working when flowing from the example.
To Reproduce
Just flowing from the document: https://refine.dev/docs/guides-and-concepts/access-control/#casbin
Steps to reproduce the behavior:

install casbin
write access control provider

The node-casbin is just for the backend, not the fronted. So there're errors when webpack building.

Hey @polly3d,
Thank you for information. As soon as possible we'll update the casbin example. Right now we are very busy, we would be very happy if you would like to open a PR and contribute to us  🚀

I would like to work on this issues. Can you assign this issue to me?

I would like to work on this issues. Can you assign this issue to me?

We'll look forward to your contribution 🚀

Hey @salihozdemir! I fixed all the errors raised by webpack in Refine Casbin Example app.
What I have done -

Upgraded the webpack to the latest version i.e. 5.0.1

Reason: webpack 4 does not support the nullish coalescing and optional chaining

Uses the react-app-rewired package for overriding the webpack config to support polyfills.

Reason: app created using create-react-app does not support the webpack overriding and for that, we need react-app-rewired

Here is the updated app - site

Hey @amit-ksh,
First, sorry for my late response I missed the notification.
Great job! 🎉  We can't wait to merge. Could you want to open a PR?

I wanted to confirm that I have to make changes in the docs right?

OK! I'll try to create PR as soon as possible.

Thank you @amit-ksh 🎁


Avoid taking a write lock in ossl_provider_doall_activated()

We refactor ossl_provider_doall_activated() so that we only need to take a read lock instead of a write lock for the flag_lock. This should improve performance by avoiding the lock contention. We achieve this by protecting the activatecnt via atomics rather than via a lock and by avoiding the full provider activation/deactivation procedure where it is not needed.
Partial fix for #20286

Let's see what the CIs make of this. As for branches I've labelled it for master/3.1/3.0. OTC might have to decided which branches this is eligible for.

@mattcaswell @nicowilliams - do you have performance measurements?

do you have performance measurements?

No. I'm hoping someone might be able to help with measuring the impact of this.

Let's see what the CIs make of this

CIs are all green

This is the approach we've used for other do_all functions.  We should make a pass over them to ensure that all of the adhere to this scheme or something close to it.

Adding OTC hold to this and all my other lock related fixes so that we can have a discussion about which branches they are all eligible for.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

I rand some performance tests running the application available in https://github.com/openssl/tools/pull/154. I ran for various numbers of threads (1, 10, 100, 500, 1000) across multiple versions of OpenSSL (3.0, 3.1, master, master + this patch).
The timings are in us and show the total time taken divided by the number of blocks of 100 calls made. Smaller numbers are better.
| 1 | 10 | 100 | 500 | 1000
-- | -- | -- | -- | -- | --
3.0 | 74.29 | 56.715 | 200.6006 | 69.4975 | 77.49943
3.1 | 23.01 | 51.573 | 80.8858 | 70.66568 | 81.93354
master | 73.46 | 56.02 | 76.51 | 62.64542 | 72.89257
master + #20927 | 61.56 | 22.496 | 21.5902 | 18.33624 | 20.13051
This shows a clear performance benefit to this patch.

Fixup pushed addressing the feedback.

OTC: This is too risky for 3.1, 3.0. Master only.

Fix up pushed. Please take another look.

This pull request is ready to merge

Merged.

@t8m @paulidale

OpenSSL Technical Committee (OTC) discussed this and decided that it should be for master only and not backported:
https://github.com/openssl/openssl/pull/20927#issuecomment-1568028363


Add vis_label

merge after #195

from chainercv.datasets import VOCSemanticSegmentationDataset
from chainercv.visualizations import vis_image
from chainercv.visualizations import vis_label
dataset = VOCSemanticSegmentationDataset()
img, label = dataset[60]
ax = vis_image(img)
vis_label(label, alpha=0.75, ax=ax)

I'm trying to show a legend using label_names.

Depending on datasets, colors assigned to class ids differ.
I think we should change vis_label to accept colors.

Since labels are in range [-1, n_fg_class], how about accepting two arguments label_colors and ignore_color. label_colors is a (n_fg_class + 1, 3) color array and ignore_color is a (3,) color array (RGB). In most cases, ignore_color` is (0, 0, 0)  (i.e. black).

Or, we can just pass a dict with integer keys and color array as values.

Here is a visualization code used in SegNet.
https://github.com/alexgkendall/SegNet-Tutorial/blob/master/Scripts/test_segmentation_camvid.py#L48-L60

Depending on datasets, colors assigned to class ids differ.
I think we should change vis_label to accept colors.

Yes, I am planning to do so.

import numpy as np
from chainercv.datasets import VOCSemanticSegmentationDataset
from chainercv.datasets import voc_semantic_segmentation_label_names
from chainercv.visualizations import vis_image
from chainercv.visualizations import vis_label
colors = np.random.randint(0, 256, size=(21, 3))
dataset = VOCSemanticSegmentationDataset()
img, label = dataset[60]
ax = vis_image(img)
_, legend_handles = vis_label(label, label_names=voc_semantic_segmentation_label_names, colors=colors, alpha=0.9, ax=ax)
ax.legend(handles=legend_handles, bbox_to_anchor=(1, 1), loc=2)

Depending on datasets, colors assigned to class ids differ.

Do you know the set of colors for PASCAL VOC? I think it is better to add voc_semantic_segmentation_label_colors

import numpy as np
from chainercv.datasets import VOCSemanticSegmentationDataset
from chainercv.datasets import voc_semantic_segmentation_label_names
from chainercv.visualizations import vis_image
from chainercv.visualizations import vis_label
label_colors = np.random.randint(0, 256, size=(21, 3))
dataset = VOCSemanticSegmentationDataset()
img, label = dataset[60]
ax = vis_image(img)
_, legend_handles = vis_label(label, label_names=voc_semantic_segmentation_label_names, label_colors=label_colors, alpha=0.9, ax=ax)
ax.legend(handles=legend_handles, bbox_to_anchor=(1, 1), loc=2, ncol=2)

I found the definition of the official color map in the orginal MATLAB code.
I will add this as voc_semantic_segmentation_label_colors.

I found the definition of the official color map in the orginal MATLAB code. I will add this as voc_semantic_segmentation_label_colors.

Wow. Great!

I added voc_semantic_segmentation_label_colors.

from chainercv.datasets import VOCSemanticSegmentationDataset
from chainercv.datasets import voc_semantic_segmentation_label_colors
from chainercv.datasets import voc_semantic_segmentation_label_names
from chainercv.visualizations import vis_image
from chainercv.visualizations import vis_label
dataset = VOCSemanticSegmentationDataset()
img, label = dataset[60]
ax = vis_image(img)
_, legend_handles = vis_label(
    label,
    label_names=voc_semantic_segmentation_label_names,
    label_colors=voc_semantic_segmentation_label_colors,
    ignore_label_color=(255, 255, 255),
    alpha=0.9, ax=ax)
ax.legend(handles=legend_handles, bbox_to_anchor=(1, 1), loc=2, ncol=2)

Is (255, 255, 255) used in the PASCAL MATLAB code?
I am just curious.

Is (255, 255, 255) used in the PASCAL MATLAB code?
I am just curious.

No. In the MATLAB code, they use (224, 224, 192) for the ignored label and (0, 0, 0) for background.

I see.

I think default colors map the same class id in different images to different colors.
from chainercv.visualizations import vis_label
import numpy as np
import matplotlib.pyplot as plot

img0 = np.zeros((32, 32), dtype=np.int32)

img0[16:] = 2
img0[:16] = 1

img1 = np.zeros((32, 32), dtype=np.int32)

img1[16:] = 0
img1[:16] = 1

fig = plot.figure()
ax1 = fig.add_subplot(1, 2, 1)
vis_label(img0, ax=ax1)
ax2 = fig.add_subplot(1, 2, 2)
vis_label(img1, ax=ax2)
plot.show()

I think default color is quite tricky to make it work.
We can work on this in the future by making the argument optional.

I changed the default color map.
from chainercv.visualizations import vis_label
import numpy as np
import matplotlib.pyplot as plot

img0 = np.zeros((32, 32), dtype=np.int32)
img0[16:] = 2
img0[:16] = 1

img1 = np.zeros((32, 32), dtype=np.int32)
img1[16:] = 0
img1[:16] = 1

fig = plot.figure()
ax1 = fig.add_subplot(1, 2, 1)
vis_label(img0, ax=ax1)
ax2 = fig.add_subplot(1, 2, 2)
vis_label(img1, ax=ax2)
plot.show()

Can you add (224, 224, 192) as voc_semantic_segmentation_ignore_label_color?

Can you add (224, 224, 192) as voc_semantic_segmentation_ignore_label_color?

OK. I added.

LGTM


Google Pay button not working in Android devices

Bug description:
Using React Native Webview to pass a third party site which is using Stripe. They have Google Pay, however the Google Pay button does not appear using React Native Webview. If I take the third party website url and view it via Chrome on Android then Google Pay does appear. Is there something wrong with React Native Webview, or do I need to pass something from app to webview to make third party site work with Google pay appearing?
Environment:

OS: Android
OS version: Android 9
react-native version: 0.64
react-native-webview version: 11.2.3

Having same issue

Facing the same issue with https://github.com/A-Tokyo/react-native-stripe-checkout-webview
This trick https://github.com/A-Tokyo/react-native-stripe-checkout-webview#apple-pay-and-google-pay gets apple to work, but apparently google pay doesn't work

Hi,
Any updates?
Thanks

Still happening

Any update?

Having same issue

is there any solution to get it working ? anyone tried this google pay in webview

I started a bounty in SO on this issue:
https://stackoverflow.com/questions/66003027/react-native-webview-stripe-google-pay

I started a bounty in SO on this issue: https://stackoverflow.com/questions/66003027/react-native-webview-stripe-google-pay

Did you manage to implement it?

Did anyone find a solution to this?


Support for multiple labels

Minimal changeset to add support for multiple labels. In case file static/labels.json defines more than one label, the UI will open an input dialog so that the user can choose one of them.

Sweet. @zekeshearer or @hbenkhay do you want to take a look?

This is now live with modifications


[WIP] add django-pipeline

#122 #27
Trying to following this article on how to use django-pipeline and browserify
http://gregblogs.com/how-django-reactjs-and-browserify/

no continuing with this experiment.


How to deal with dyanmic objects in the environments.

Hi, the moving object (like people)would easily remain on the borderlines of point clouds when I generated the TSDF data. The result of this is that when the person walks away, the robot thinks that there is still an obstacle, which in turn affects the path of autonomous exploration. Is there a way to solve this problem? Thanks!

Hi @TurtleZhong ,
This can be fixed by increasing this parameter in the voxblox_config_file.
Set it somewhere around 0.5 - 0.7.
Let me know if it helps.
Best regards,
Mihir


Static ip

Hi!
is it possible to add static ip's inside the flannel layer ?
I want to deploy a dns like skydns. The DNS has to be available from every node in the cluster but i don't want to bind it to a spezify host.
So maybe something like a new subnet ( /32 ? ), dynamicly assigned to a host which runs the container ( ExecPreStart ) ?
BR
cdpb

@cdpb flannel doesn't have static reservations right now. One option is to register the DNS IP in etcd, then query it on the node and feed it into the container via env var:
ExecStart=/bin/bash -c "dns=$(etcdctl get /someprefix/skydns) docker run --dns=$dns ..."

@eyakubovich thank you, should work :)
Just a idea:
flannel watches etcd for changes, if a subnet gets provide my another machine, the routing set accordingly to etcd - so far so good.
So e.g. I have a <IP_ADDRESS>/24 registered to node1 till startup ( flannel overall network /8 )
A Container starts with:
ExecPreStart=/usr/bin/etcdctl set /coreos.com/config/subnets/10.0.100-32
ExecStart=...docker run -p 10.0.100:53:53 ....
ExecStop=/usr/bin/etcdctl rm /coreos.com/config/subnets/10.0.100-32

So routing is done, the only missing part is a registered virtual ip to docker bridge, it should be really easy to realize.

I hope static-ip in flannel gets some traction.
Looking to etcd for flannel IP addresses is not ideal.  It requires exposing outer network to apps running in the flannel domain. If we do that, then we might as well expose flannel DNS to outer network and then find it through that network's static IP.  That's what our solution is.  This is far better then telling each application to watch etcd to see if anything's changed. It works but it's undesirable.  Apps running on the flannel network are not supposed to know there is some other network.
If static IP is too problematic, then at the very least, it would be nice if flannel would allocate the same IP address to a re-started container. It is smart enough to re-allocate the same subnet to a rebooted host.  Why cannot it do the same for the container??? (well, because it has no idea the newly started container is a restart of some previous container).  I realize, flannel cannot deduce it with current implementation.  Something needs to be added to flannel.

@elephantfries I have a PR for subnet reservations almost ready. That will allow you to statically associate flannel subnet with the IP of the host interface. However something has to allocate the same IP from that subnet to the container -- and that something has to be the container runtime, like Docker.
Even if we were to support allocating /32 like @cdpb suggests, it would not work with Docker. I'm pretty sure Docker will fail if you specify --bip=x.x.x.x/32. But even if it didn't, it would limit your host to running one container. At this point you should just run this host without flannel -- let your DNS be on the "outer" network. If you're concerned about security policy, you can use iptables to restrict containers to just accessing flannel network and the DNS.

I see.  So looks like there is a need for an associated docker PR.
However I am after something slightly different.  I am OK with flannel randomly allocating subnets so long as it re-allocates the same subnet on the host reboot.  That is the behavior right now and that's fine.  I am after static allocation of IP addresses for containers on that subnet, or at least allowing a container regain its previous IP address upon (container) restart.  I realize flannel is lacking a hint to tell that a container wants the same IP address as allocated to some previous container.  Would allowing that require a docker PR or would it be possible to implement it entirely within flannel?

@elephantfries It would need to be in Docker. flannel does not allocate IPs to containers. All flannel does is allocate a subnet and ensures that this subnet is routeable between other flannel subnets.

OK, thanks, looks like very high activity in this area in docker right now:
https://github.com/docker/libnetwork/issues/489

Request for this feature +1.
almost all thing can be done with domain name,
but DNS itself cannot escape from static IPs.

Static subnet reservation for a host can be done following this doc I added https://github.com/coreos/flannel/blob/master/Documentation/reservations.md
Static IP addresses for individual containers/pods is not something to flannel manages.


Index out of range error when changing the graph object

The following IndexError was thrown building _GraphViewAnimated(dirty, dependencies: [MediaQuery],
state: _GraphViewAnimatedState#68d80):
RangeError (index): Index out of range: index should be less than 8: 8

The relevant error-causing widget was:
  GraphView$ GraphView:file:///Users/mike/Documents/GitHub/kgng/lib/src/home/node_view.dart:219:20

When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 294:3       throw_
dart-sdk/lib/_internal/js_dev_runtime/private/js_array.dart 600:7                 _get]
packages/graphview/GraphView.dart 299:34                                          <fn>
dart-sdk/lib/_internal/js_dev_runtime/patch/core_patch.dart 572:46                generate
packages/graphview/GraphView.dart 296:12                                          <fn>
packages/graphview/GraphView.dart 306:48                                          build
packages/flutter/src/widgets/framework.dart 5583:27                               build
packages/flutter/src/widgets/framework.dart 5471:15                               performRebuild
packages/flutter/src/widgets/framework.dart 5634:11                               performRebuild
packages/flutter/src/widgets/framework.dart 5187:7                                rebuild
packages/flutter/src/widgets/framework.dart 2895:18                               buildScope
packages/flutter/src/widgets/binding.dart 984:9                                   drawFrame
packages/flutter/src/rendering/binding.dart 457:5                                 [_handlePersistentFrameCallback]
packages/flutter/src/scheduler/binding.dart 1325:7                                [_invokeFrameCallback]
packages/flutter/src/scheduler/binding.dart 1255:9                                handleDrawFrame
packages/flutter/src/scheduler/binding.dart 1113:5                                [_handleDrawFrame]
lib/_engine/engine/platform_dispatcher.dart 1274:5                                invoke
lib/_engine/engine/platform_dispatcher.dart 248:5                                 invokeOnDrawFrame
lib/_engine/engine/initialization.dart 186:36                                     <fn>
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 574:37  _checkAndCall
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 579:39  dcall

════════════════════════════════════════════════════════════════════════════════════════════════════
410
Another exception was thrown: RangeError (index): Index out of range: index should be less than 8: 8

Fix: https://github.com/nabil6391/graphview/pull/115


[Plugin]: Better Messages

Plugin name
Better Messages
download page
https://dev.bukkit.org/projects/better-messages-custom-join-leave-messages-and
Source code URL
https://github.com/JustDoom/Better-Messages
Paid?

[ ] is paid for?

great plugin ;)


Several improvements suggested

It will be great to see the following improvements for plugin:

possibility to sort work blocks by duration
possibility to collapse embedded blocks (Part 1, Part 2, Part 3..), because table became too large and bad readable
to highlight the currently running block in the table, because it is not understandable from main control which task is running when it is a next part and same part exist in other blocks, like:

Currently Running:
Name: Part 3
Started at: 24-07-18 19:57:04

What are your plans around sorting by duration? I don't see any use cases where that would be helpful.
Currently I have the default ordering which is insert ordering oldest -> newest then the reverse of that newest -> oldest which is helpful for seeing newest entries first. But I cannot see any case where ordering by longest/shortest would be useful or within scope.
If you are wanting ordering based on duration for statistics reasoning you'd be better off using something like Obsidian Dataview and the API I've exposed in #8 to do your visualization that way with some scripting

What are your plans around sorting by duration? I don't see any use cases where that would be helpful.
Currently I have the default ordering which is insert ordering oldest -> newest then the reverse of that newest -> oldest which is helpful for seeing newest entries first. But I cannot see any case where ordering by longest/shortest would be useful or within scope.
If you are wanting ordering based on duration for statistics reasoning you'd be better off using something like Obsidian Dataview and the API I've exposed in #8 to do your visualization that way with some scripting

I think it is the main user case for this plugin at all - the possibility to see which Block of time spending took most time.
Using from API may be useful, but need spend time to learning how to use it and additional space on page, when it would be much more easy if it could sort (at least by duration desc) directly in the main widget.

You would not be able to sort by a duration on the widget itself without also having to include the current sort mode inside the time keep data due to a limitation of how the app is rendered by Obsidian which I do not want to do as I believe it strays to far from data that should be included in the JSON.
It would have to be a plugin setting like the reverse order option, applied to all. But I do not see the value in spending time to implement it at this stage for this plugin as it does not fit my use case, in which I track hours for billing clients and the time spent is not something that matters to me (Would be more relevant to use the API or a custom made tool to get those sort of insights). This may be implemented in the future but I do not see this as relevant for now.
I have implemented highlighting the active row and the collapsing of entries.
Due to the limitations of how Obsidian renders the app local state will not persist as soon as any mutation happens on the timekeep (add/edit/remove/collapse/expand) the local state will be lost and the timekeep will do a full re-render thus storing local state to sort individual timekeeps is not possible. I have had to store a collapsed state for time keep entries in the timekeep data for that feature to work.
The changes mentioned will be in the next release of the plugin

The provided dataviewjs code will create a table for each entry (Only taking the first layer, any groups of entries will be the sum of the groups parts duration) and order the entries by longest to shortest:
You can find the Dataview js reference Here

Dataview duration table code example
```dataviewjs
// Get the currently open file
const activeFile = this.app.workspace.getActiveFile();
if (!activeFile || !activeFile.name) return;

// Read the file
const text = await this.app.vault.read(activeFile);

// Get the timekeep plugin API
const timekeepPlugin = this.app.plugins.plugins.timekeep;

// Extract the timekeeps from the file text
const timekeeps = timekeepPlugin.extractTimekeepCodeblocks(text);

// Current time is required for unfinished entries
const currentTime = moment();

// Helper to format the duration number as human readable
function formatDuration(totalTime) {
	let ret = "";
	const duration = moment.duration(totalTime);
	const hours = Math.floor(duration.asHours());

	if (hours > 0) ret += hours + "h ";
	if (duration.minutes() > 0) ret += duration.minutes() + "m ";
	ret += duration.seconds() + "s";

	return ret.trim();
}

for (const timekeep of timekeeps) {
	let data = [];

	for (const entry of timekeep.entries) {
		let duration = 0;
		if (entry.subEntries !== null) {
			// Group entry total duration
			duration = timekeepPlugin.getTotalDuration(
				entry.subEntries,
				currentTime
			);
		} else {
			// Single entry duration
			duration = timekeepPlugin.getEntryDuration(entry, currentTime);
		}

		// Push the entry
		data.push([entry.name, duration]);
	}

	// Order the data by duration
	data.sort((a, b) => b[1] - a[1]);

	// Convert the durations to human readable
	const formattedData = data.map(([name, duration]) => [
		name,
		formatDuration(duration),
	]);

	// Put a table for the timekeep
	dv.table(["Name", "Duration"], formattedData);
}

```

This will produce:

You can find a copy of the dataview code at https://github.com/jacobtread/obsidian-timekeep/blob/main/test-vault/Dataview-Longest-Ordered-Example.md which also shows reading from a different file


Add allowFontScaling prop

This adds the ability to turn off allowFontScaling, if desired, for the Text components. Unless I am mistaken, there isn't currently a way to add the prop unless you use a custom renderer.

Please merge this one, thx.

+1 on merging this!

please merge this one

When is this going to be merged?

+1 Please merge!

Merged in v4.1.0


List of modules

Describe the Request
I wish you could add a list of all available modules and a brief description of what each brings - rn it's really difficult to figure out and i can't find the information anywhere. I deleted a few modules to try and clean stuff up but accidentally deleted the wrong one and can't find it again as the search is not very useful, and google is useless in trying to find out what modules you actually have. I even tried reinstalling the mod but it wouldn't reset itself.
Screenshots
No response
Modloader Type
None
Modloader Version
No response
Additional Context
No response

On the modules list, you can delete the inserted text to get a list of all modules. I'll look into a better way of implementing this soon


Bugfix: change noble dependency

Changed noble dependency to maintained package @abandonware/noble. `@abandonware/noble is fork of the previous package and it looks like it's compatible. After this dependency change, the node started working for me.

Thanks a lot! Releasing a new version to check


Update jetbrains stimulus plugin url.

Q
A

Bug fix?
no

New feature?
no

Issues
no

License
MIT

JetBrains took over the Stimulus Plugin into its official plugin catalog and the old plugin from Andrey Starovoyt is deprecated.

Old: https://plugins.jetbrains.com/plugin/18940-stimulus
New: https://plugins.jetbrains.com/plugin/24562-stimulus

I've updated the link in the StimulusBundle docs.

Thank you @Basster.


human-readable client-side network stats logging

Description
Make network logging more human-readable and understandable.

Add tabbed alignment;
Use Megabytes and Percent as metric
Visually indent stats message.

Type of change
Minor visual quality-of-life improvement for end-user
How Has This Been Tested?
Tested on one local development machine.
WTR:

Run the app.
Wait for usual message update timing after attack targets were written down.
Look at the terminal.

Test Configuration

Release version: 937ec0f
Platform: Windows x64

Logs
Атака проводиться успішно! Руський воєнний корабль іди нахуй!
Attack is successful!
---------Traffic stats---------
[Generated]     2667 MB | 2731237 bytes
[Received]      358 MB  | 366746 bytes
[Response rate] 13.4%
-------------------------------

Screenshots
How it looks in Windows PowerShell

@dshpet lint is failing for your PR

Fixed linter errors.
Improved formatting even further.


0.8.4 (Linux) - Random crashes when using two-wheeled vehicles

Random crashes occur in PhysX related code concerning the vehicle's wheels. This crash seems to happen only when running the simulation with bikes and motorbikes. The exact place of the crash varies but it's usually due to some NaN value. Possibly some uninitialized memory in the shader that computes the wheel's physics.
Here an extract of the log of one of the crashes: log.txt.

As a workaround, for now you can disable all the two-wheeled vehicles with
CarlaSettings.ini
[CARLA/LevelSettings]
; Disable bikes and motorbikes, if true only four-wheeled
; vehicles will be spawned.
DisableTwoWheeledVehicles=true

Python
settings = CarlaSettings()
settings.set(DisableTwoWheeledVehicles=True)

is it possible to set bikes or motorbike as player vehicle? i tried using the init file, it cannot load...

I observed the same issue also when setting the number of vehicles to 0
but without setting the DisableTwoWheeledVehicles=true.

In 0.9.1, if you are using the spawn_npc.py script you can use the --safe argument to spawn only vehicles that do not cause accidents. At this point all the bikes are left out, also the Isetta.
./spawn_npc.py --safe

This should now be solved by the Traffic Manager.


you should be able to play as the larva that bursts out of you

Description

when a larva bursts out of you and you are in your body at the time, your soul should transfer to the larva, allowing you to play as a xeno.
its like this in CM13 and prevents people from just quitting the game after they get kidnapped

I think the facehugger should get the larvae TBH

good point. i think either one is fine

just kindof hard to work out how that would work, since it takes so long for a larva to burst

I think the facehugger should get the larvae TBH

That might be tricky, because the vast majority of facehuggings are from sealed eggs or non-player parasites.

just kindof hard to work out how that would work, since it takes so long for a larva to burst

It could work similar to the "return to body" prompt when being revived - something like "Your larva is about to burst. Play as Xeno?"
Would need to also consider issues of marines going SSD or not wanting to play a xeno, but in those cases a ghost role or queue based system could be the backup.


Adding travis changes and package.json changes for semantic release

This PR switches Travis tests from v1 integration tests to v2 unit tests. It also adds the semantic release dependency needed to automatically release versions of this repository.

Pull Request Test Coverage Report for Build 776

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+18.5%) to 79.986%

Totals

Change from base Build 769:
18.5%

Covered Lines:
1530

Relevant Lines:
1769

💛  - Coveralls

:tada: This PR is included in version 1.0.0 :tada:
Your semantic-release bot :package::rocket:


Rename copierlog to copier-answers across the codebase

The initial implementation in https://github.com/pykong/copier/pull/103 was calling the file logfile, but it was renamed to copier-answers later.
However I discovered there are still a few remainders of the old implementation.
Here I remove them.
@Tecnativa TT20357

@Yajo There are conflicts. Can you resolve them?

Yes, done

Merged, LGTME. THX.


import rosys does not work with ui.run(reload=False) - RuntimeError: multiprocessing start method must be "spawn"

Hello everyone,
I have come across the following error message when I set the reload flag to False in the ui.run function:
 Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/nicegui/background_tasks.py", line 55, in _handle_task_result
  task.result()
File "/usr/local/lib/python3.11/site-packages/nicegui/helpers.py", line 77, in result_with_client
  await result
File "/rosys/rosys/rosys.py", line 144, in startup
  raise RuntimeError(
RuntimeError: multiprocessing start method must be "spawn"; see https://pythonspeed.com/articles/python-multiprocessing/

To better localize the source of the error, I have created a minimal example where the error occurs. Just import rosys is enough.
Example:
from nicegui import ui

import rosys

ui.run(
    title='Test',
    port=8080,
    reload=False
    )

The error also occurs when I try to plan a path in my main program.

How did I come up with the idea of setting reload=False?
The reload flag causes my script to run twice. This results in two instances of each class being created. This has caused problems when I tried to subscribe to an MQTT topic, and my callback function was suddenly called twice for each message. The reload does not seem to be a complete restart where all resources from the previous run are cleaned up.

@rodja thanks for the link to the FAQ, my script works now.
It's interesting, that you could not reproduce the issue on MacOS.
I let it run in a Docker Container.
Dockerfile:

FROM zauberzeug/rosys:latest

WORKDIR /usr/src/app

docker-compose.yml
version: "3.9"
services:
  rosys_service:
    build: .
    tty: true
    ports:
      - "8080:8080"
    volumes:
      - ./:/app
    hostname: docker

Ah very good @AndyPermaRobotics. With Docker the error comes up as described by you. I've just tested locally on mac.

No, I have not looked into it.

I looked into this a little. I think the best way to solve this may be keeping Nicegui's behavior consistent in case there is no specific reason that it does not set the spawn method when reload=False. However, I do not understand enough about Nicegui to fix this.
Another Option would be forcing the method to spawn instead of raising an exception in rosys.py on_startup:
multiprocessing.set_start_method('spawn', force=True)


Is the code for generating more test cases open source?

Hello, this is a very good work!
I noticed that you don't seem to open source the code for generating test cases? Of course, maybe I just didn't find it. Are you going to open source this part of the code?
Looking forward to your positive response!

https://github.com/evalplus/evalplus/tree/master/evalplus/gen
Open-sourced since day-1. :)