Document & Projected document namespace

Hi I have a project where I'm using mediatR commands and sharing them with my blazor client, so instead of having Handlers + Requests in one assembly I split them and reimplement the handlers on the client side for the same requests.
My concern right now is that the client(Requests only) library has to reference the mongo driver and subscriptions because of the ProjectedDocument record, any chance that these two records can move down to the core level?
example the ClaimDocument is a projected document
`using MediatR;
namespace Tenants.ApplicationInterface.Claims.Queries.ListClaims;
public class ListClaimsQuery : IRequest<List>
{
}`

If I may ask why do you need MrdiatR for handling queries? Queries must return the result synchronously, I consider using any sort of middleware for queries as an anti-pattern, but it might be just my thing.

Normally you do authentication and basic authorisation using auth policies and IAuthorizationService is done by ASP.NET itself in a middleware, so you get the request pre-authorised. Of course, you could need things like "what can the user see" in the query, but you don't need MediatR for it.
I normally avoid decoupling queries from the read model database engine, as they are naturally coupled, that's the whole point of CQRS. Then, you can have the query service as a dependency in the controller. I usually split query controllers from command controllers also for that reason, as they serve different purposes and need different dependencies.

I will close this one, if you have any more comments please still write here.


bug(menu): menu is triggering custom animation of a custom component used inside it

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
bug(menu): menu is triggering custom animation of a custom component used inside it
StackBlitz link - https://stackblitz.com/edit/8ve6wn?file=src%2Fapp%2Fmenu-icons-example.html

Reproduction
Steps to reproduce:

Visit this stackblitz - https://stackblitz.com/edit/8ve6wn?file=src%2Fapp%2Fmenu-icons-example.html
Once the UI loads, click on vertical ellipsis button
Click outside the popup. For a fraction of section, you will see the animation of demo-statusbar has been triggered and content is visible
Open the menu again and check extra content from demo-statusbar is visible

Expected Behavior
Closing menu should not trigger any custom component's custom animation
Actual Behavior
Closing menu is triggering custom component's custom animation
Environment

Angular: 15
CDK/Material: 15
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

Same issue in v16 - https://stackblitz.com/edit/8ve6wn-znskfp?file=src%2Fapp%2Fmenu-icons-example.html

Confirmed the issue, here's a less noisy version of the stackblitz that can still repro: https://stackblitz.com/edit/8ve6wn-pvbwzz (only a single status bar instance, and removed the second animation)


Acronyms in tablename aren't converted to snake case

Acronyms aren't being recognized as separate words when converting to snake case.  Only happens with plain acronyms or acronyms with a prefix but not a suffix.
from flask import Flask
from flask_sqlalchemy import SQLAlchemy

app = Flask(__name__)
db = SQLAlchemy(app)

class ABC(db.Model):
    id = db.Column(db.Integer, primary_key=True)

class PreABC(db.Model):
    id = db.Column(db.Integer, primary_key=True)

class ABCPost(db.Model):
    id = db.Column(db.Integer, primary_key=True)

class PreABCPost(db.Model):
    id = db.Column(db.Integer, primary_key=True)

db.engine.echo = True
db.create_all()

CREATE TABLE "ABC" (
	id INTEGER NOT NULL,
	PRIMARY KEY (id)
)

CREATE TABLE "preABC" (
	id INTEGER NOT NULL,
	PRIMARY KEY (id)
)

CREATE TABLE abc_post (
	id INTEGER NOT NULL,
	PRIMARY KEY (id)
)

CREATE TABLE pre_abc_post (
	id INTEGER NOT NULL,
	PRIMARY KEY (id)
)

As far as I can tell it's always been this way.  I'm surprised no one commented on it before, since it's definitely not correct.
Changing this would be backwards incompatible because tablenames for existing tables could change.  However, it would be part of the 3.0 major version bump.
@immunda thoughts?

Yes, I just ran into this as well. I read the code, here is a possible fix.
Change
_camelcase_re = re.compile(r'([A-Z]+)(?=[a-z0-9])')

to
_camelcase_re = re.compile(r'([A-Z])(?=[a-z0-9])')

and then change _join to
def _join(match):
                word = match.group()
                if len(word) > 1 and word[-1].lower() == word[-1]:
                    return ('_%s_%s' % (word[:-1], word[-1])).lower()
                return '_' + word.lower()

and define this
_upcase_re = re.compile(r'([A-Z]+))

Then, the table names would come from
>>> _upcase_re.sub(_join, _camelcase_re.sub(_join, 'PreABCPost')).lstrip('_')
'pre_abc_post'
>>> _upcase_re.sub(_join, _camelcase_re.sub(_join, 'PreABC')).lstrip('_')
'pre_abc'
>>> _upcase_re.sub(_join, _camelcase_re.sub(_join, 'ABC')).lstrip('_')
'abc'
>>> _upcase_re.sub(_join, _camelcase_re.sub(_join, 'ABCPost')).lstrip('_')
'abc_post'
>>> _upcase_re.sub(_join, _camelcase_re.sub(_join, 'CamelCase')).lstrip('_')
'camel_case'

Good spot @davidism, I've never actually come across this either as I more or less always explicitly set __tablename__.
Seems like a sensible change too, @rokob.
The biggest hurdle is setting peoples expectations around the change. I'd like 3.0 to be free of lots of nuanced depreciation notices, I see two obvious solutions:
a) Inject another 2.x release which noisily warns users if they have any models which would be affected and how to fix it, i.e. with __tablename__.
b) Just make the change for 3.0 as it'll break loudly in folks' testing, but perhaps not as pleasant and more unexpected behaviour if people aren't diligent.
Thoughts, comments, concerns? Otherwise I'm leaning towards b) ;)

I think a 2.x warning would be nice. But I'm in the manually set tablename camp as well.


[Parameter Request] codeunit 80 "Sales-Post" publisher OnBeforeCheckCustBlockage parameter TempSalesLine

We requested with Issue  #8784 an new event.
There you pointed out that we should use the existing event OnBeforeCheckCustBlockage instead.
But this doesn't work because we don't have access to TempSalesLine, which is absolutely necessary to completely map the functionality.
Can you therefore extend the publisher OnBeforeCheckCustBlockage with the TempSalesLine parameter
local procedure CheckCustBlockage(SalesHeader: Record "Sales Header"; CustCode: Code[20]; ExecuteDocCheck: Boolean)
    var
        Cust: Record Customer;
        TempSalesLine: Record "Sales Line" temporary;
        IsHandled: Boolean;
    begin
        IsHandled := false;
        // >>>>>>>>>>>>>>>>>>
        //OnBeforeCheckCustBlockage(SalesHeader, CustCode, ExecuteDocCheck, IsHandled);
        OnBeforeCheckCustBlockage(SalesHeader, TempSalesLineGlobal, CustCode, ExecuteDocCheck, IsHandled);
        // <<<<<<<<<<<<<<<<<<<
        if IsHandled then
            exit;
...

    [IntegrationEvent(false, false)]
   // >>>>>>>>>>>>>>>>>>
    //local procedure OnBeforeCheckCustBlockage(SalesHeader: Record "Sales Header"; CustCode: Code[20]; var ExecuteDocCheck: Boolean; var IsHandled: Boolean)
    local procedure OnBeforeCheckCustBlockage(SalesHeader: Record "Sales Header"; var TempSalesLineGlobal: Record "Sales Line" temporary; CustCode: Code[20]; var ExecuteDocCheck: Boolean; var IsHandled: Boolean)
    // <<<<<<<<<<<<<<<<<<<
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


missing documentation of workflow for new plugins

[+] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[+] I have searched the existing issues and I'm convinced that mine is new.
Hi everyone, I'm currently developing a plugin for radsecproxy, a secury Radius proxy used for example in the eduroam-project. The GUI-part is quite complete after looking at the tutorials and other plugins in this repository.
But now I'm not sure about the next steps of the workflow. I'd like to publish the plugin in this repository, so what do I have to do next? The tutorials told me to create the files directly in the corresponding places in the filesystem, whereas here the files need to lie under /usr/plugins.
The mentioned make command isn't working either:
root@radsecproxy-dev:/usr/plugins/net/radsecproxy # make package
make: don't know how to make package. Stop

make: stopped in /usr/plugins/net/radsecproxy

Is there an instruction for publishing plugins I didn't find?
Best regards
Tobias

Hi Tobias, the tutorial should contain all files needed to build a plugin https://docs.opnsense.org/development/examples/helloworld.html

I was switching between the "hello world" and "using grids" examples so much, that I obviously never reached the last chapter of "hello world" - thanks @AdSchellevis
What would be the next steps to publish the plugin here?

a pull request containing your code, so people can review and test .

Hi Ad, I'm sorry for asking but this is the first time for me to contribute something in form of a pull request. I know git and use it for private projects (sync between multiple PCs), but that's it.
What is the way to go now? Create a fork of the plugins-repository on github, check it out to my virtual opnsense, create my plugin there, push the changes back into it and create a pull request from there? Or can I checkout the plugins-repository directly into my virtual opnsense and create a pull request from there?
Like I said, it's my first time and I want to make everything right ;-)

@Mad-Onion no problem, you normally fork indeed and create a PR then. I think GitHub as a nice document about the standard workflow somewhere, but I couldn't find it very fast.

Ok, I'll give it a try and also try to find the github-docs :-)

I was about to add the link :)
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

This issue has been automatically timed-out (after 180 days of inactivity).
For more information about the policies for this repository,
please read https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md for further details.
If someone wants to step up and work on this issue,
just let us know, so we can reopen the issue and assign an owner to it.


In convertMedia.ts, images and illustrations are optional

Before, if there were no images, then the conversion would fail
with a trackback in the output.
Add illustrations as optional media files to process

Already added by beb5d1c9e42c318a65774542681f603225d47c04


Use SoftReference over WeakReference for longer lived caches.

WeakReferences are cleared when they no longer have any strong references to them so this means caches can have a very short life when they are not used. SoftReferences are cleared by the garbage collector when they have no strong references and memory has been exhausted. Must consider which things should be soft and which ones should be weak.

Not changing, looking over the code there is nothing I see that would benefit from being in memory longer since right now the only short lived caches (using WeakReference) are potentially just used for debugging stuff which is likely to not be used often enough to be meaningful.


Video based tracker improvements

This has the axes lined up the right way in the transforms, maintains a fast update rate, and has much less jitter.  The only changes should be to the video-based tracker plug-in.

There's also an assert I keep hitting when building with OpenCV 3 (mingw64/msys2) - OpenCV Error: Assertion failed (confidence > 0 && confidence < 1) in run, file C:/repo/mingw-w64-opencv/src/opencv-3.0.0/modules/calib3d/src/ptsetreg.cpp, line 178 - looks like the only thing in calib3d that's getting used is cv::projectPoints according to the DLL imports anyway.

OK, have it running here after rebase, though the transform is goofed up.  Did quick profiling to see if there are any low-hanging fruit performance-wise: the plugin spends about 11.5% of its time in osvr::vbtracker::OsvrHdkLedIdentifier::getId and its child calls, which includes about 8.5% of total computation timedoing std::rotate, inclusive of internal implementation calls. Also looks like it's doing a bit of waiting on mutex related to osvr core, will dig into those later (esp. since if you count the video capture, it's spending way more time repeatedly sleeping in that thread...)

Also, it looks like the SimpleBlobDetector includes a FindContours call, but that find contours might also be called separately - these are very expensive calls (inclusive of child calls, plugin spends 35% of its time in findContours), so if we can reduce duplication there it would be a big win.

This is the orientation I'm getting. translations along both y and z are reversed, as well as rotations about those axes.

Added the performance improvements to my ToDo list. Thanks for running the traces!

Looking into the transforms now.


[BUG] case when on some nested types can produce a crash

Describe the bug
Caused by: ai.rapids.cudf.CudfException: cuDF failure at: /home/roberte/src/cudf/cpp/src/reshape/interleave_columns.cu:38: Called `interleave_columns` on none-supported data type.
E                   	at ai.rapids.cudf.ColumnVector.makeList(Native Method)
E                   	at ai.rapids.cudf.ColumnVector.makeList(ColumnVector.java:441)
E                   	at ai.rapids.cudf.ColumnVector.makeList(ColumnVector.java:410)
E                   	at ai.rapids.cudf.ColumnVector.empty(ColumnVector.java:1623)
E                   	at ai.rapids.cudf.ColumnVector.empty(ColumnVector.java:1630)
E                   	at ai.rapids.cudf.Scalar.listFromNull(Scalar.java:357)
E                   	at com.nvidia.spark.rapids.GpuScalar$.from(literals.scala:221)
E                   	at com.nvidia.spark.rapids.GpuScalar.getBase(literals.scala:442)
E                   	at com.nvidia.spark.rapids.GpuConditionalExpression.$anonfun$computeIfElse$3(conditionalExpressions.scala:42)

This happens when you do a case when statement and no default value is given.  The types involved are.
Array(Struct(key: String(not_null), value: Array(Struct(key: String(not_null), value: String))))

This is the same as a
Map(String(not_null),Map(String(not_null),String))

but we don't support maps on case when yet. I was trying to add them and ran into this.

This can also impacts GpuCoalesce and GpuLiteral.

I filed https://github.com/rapidsai/cudf/issues/9010 to fix this in cudf, but because this is a feature request (cudf does not claim to support this operation) we need to fix this in the short term by either disabling this in the plugin until we can make it work, or find an alternative way to do something in the cudf java APIs for null columns.

Seems this is similar to https://github.com/rapidsai/cudf/issues/8927.

Yup I duplicated rapidsai/cudf#9010 to  rapidsai/cudf#8927. github search is just not as good as I would like it to be.

So should we close this?

So should we close this?

After we add in tests to verify that it is working and does not break again.


JBallerina does not recognize other modules packed

Description:
If we pack other modules like jballerinax it is not resolved by jballerina because of the check here: https://github.com/ballerina-platform/ballerina-lang/blob/7426a5c270d317a6e7681ca70d5d06e9f413d6e7/compiler/ballerina-lang/src/main/java/org/ballerinalang/util/BootstrapRunner.java#L92
Steps to reproduce:
Try having a different org in the jballerina repo like ballerinax
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):
N/A

This is fixed.


Implement EventList

This is a basic implementation of EventList with essential APIs and tests
Things remaining:

Implement EventList Writing
LightCurve Methods
Plot Testing
Optimizing/Refactoring the Code

Cross-spectra/Periodograms APIs and documentation will be implemented soon in next PRs

Codecov Report

Merging #7 (96db379) into main (cddac34) will decrease coverage by 73.80%.
The diff coverage is 73.68%.

@@             Coverage Diff             @@
##             main       #7       +/-   ##
===========================================
- Coverage   95.24%   21.43%   -73.81%
===========================================
  Files           3        6        +3
  Lines         505      667      +162
===========================================
- Hits          481      143      -338
- Misses         24      524      +500

Impacted Files
Coverage Δ

src/lightcurve.jl
0.00% <0.00%> (ø)

src/gti.jl
22.59% <47.36%> (-70.49%)
:arrow_down:

src/events.jl
85.29% <85.29%> (ø)

src/io.jl
97.82% <97.82%> (ø)

src/fourier.jl
0.00% <0.00%> (-96.40%)
:arrow_down:

src/utils.jl
0.00% <0.00%> (-92.31%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

These were minor mistakes (like not uncommenting some codes, mostly 1-2 lines) so force pushed in the same commit.


Edited the footer of the home page as it had grammatical errors. Fix…

…es #127
I have edited the footer of the homepage as it had grammatical errors. Now it looks fine.
This is my first pull request in this project.
Fixes #127

As asked by @sakshikhachane improve the design of the footer

As asked by @sakshikhachane improve the design of the footer

I will open a separate issue for this , this was just to address the grammatical errors as asked by @sakshikhachane .


Update ComprehensiveGuide.md

Restart the computer after setting up ffmpeg.

Thanks, in the future PR dev please though.


[FLINK-3596] DataSet RelNode refactoring

This PR refactors the current table API code so that

the intermediate flink relnode layer and the dataset rules are removed
code generation is moved from rules to DataSet nodes
unused DataSete nodes are removed
DataSetMap and DataSetReduce are merged into DataSetAggregate

Thanks for the review @fhueske. I've addressed your comments.

Thanks for the update @vasia.
Merged to tableOnCalcite. PR can be closed.

Thanks for finalizing and merging :)


Which proxy servers work with the iot edge runtime

Which proxy servers work with the iot edge runtime? Because, I've difficulties with configuring my proxy server to relay back the requested information.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 69c0d8c2-ea63-1b11-d855-bc1f6108cf62
Version Independent ID: 7c2c7ceb-ed80-f507-0c63-280720e9768d
Content: Configure devices for network proxies - Azure IoT Edge
Content Source: articles/iot-edge/how-to-configure-proxy-support.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

@HenrikBach1 Thanks for the feedback! We are currently investigating and will update you shortly.

@HenrikBach1 This will require some deeper analysis. Can you please file a support request @ https://aka.ms/azsupt? If you do not have access to a support plan, please reach out<EMAIL_ADDRESS>with a link to this Doc/Issue as well as your subscription ID and we can help get the support ticket opened for this issue.

@HenrikBach1 We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Can you test the Mat4Array just implemented for the skinning animation

@DorianPinaud it refer to which commit ?

@cesarl  this one  #337

This is an issue not a commit hehe. My question is on which branch is it ?
Or which commit ?
2015-03-04 15:41 GMT-08:00 DorianPinaud<EMAIL_ADDRESS>
Reopened #340 https://github.com/Another-Game-Engine/AGE/issues/340.
—
Reply to this email directly or view it on GitHub
https://github.com/Another-Game-Engine/AGE/issues/340#event-246423577.

--
[image: dancing frog animation][image: dancing frog animation][image:
dancing frog animation][image: dancing frog animation][image: dancing frog
animation][image: dancing frog animation][image: dancing frog animation][image:
dancing frog animation][image: dancing frog animation][image: dancing frog
animation][image: dancing frog animation][image: dancing frog animation][image:
dancing frog animation][image: dancing frog animation]

merge_pipeline_skinining somthing like that

merge_skinning_and_fix_pipeline

La banche n'est pas a jour avec le code de la PR. Je teste ca bientot
2015-03-04 19:31 GMT-05:00 DorianPinaud<EMAIL_ADDRESS>
merge_skinning_and_fix_pipeline
—
Reply to this email directly or view it on GitHub
https://github.com/Another-Game-Engine/AGE/issues/340#issuecomment-77282102
.

--
[image: dancing frog animation][image: dancing frog animation][image:
dancing frog animation][image: dancing frog animation][image: dancing frog
animation][image: dancing frog animation][image: dancing frog animation][image:
dancing frog animation][image: dancing frog animation][image: dancing frog
animation][image: dancing frog animation][image: dancing frog animation][image:
dancing frog animation][image: dancing frog animation]

ok
2015-03-05 0:37 GMT+00:00 Cesar Leblic<EMAIL_ADDRESS>
La banche n'est pas a jour avec le code de la PR. Je teste ca bientot
2015-03-04 19:31 GMT-05:00 DorianPinaud<EMAIL_ADDRESS>
merge_skinning_and_fix_pipeline
—
Reply to this email directly or view it on GitHub
<
https://github.com/Another-Game-Engine/AGE/issues/340#issuecomment-77282102

.

--
[image: dancing frog animation][image: dancing frog animation][image:
dancing frog animation][image: dancing frog animation][image: dancing frog
animation][image: dancing frog animation][image: dancing frog
animation][image:
dancing frog animation][image: dancing frog animation][image: dancing frog
animation][image: dancing frog animation][image: dancing frog
animation][image:
dancing frog animation][image: dancing frog animation]
—
Reply to this email directly or view it on GitHub
https://github.com/Another-Game-Engine/AGE/issues/340#issuecomment-77282710
.

Not tested yet :)


[Addon 577] Fix the version issue of flink-kubernetes-operator

Description of your changes

changed the version from 1.1.0 to 1.3.0
How has this code been tested?

debugged the addon in my local, installed offline:
vela addon enable /root/.vela/addons/flink-kubernetes-operator

show the status:
vela addon status flink-kubernetes-operator

the result：
flink-kubernetes-operator: enabled (1.3.0)
==> Installed Clusters
[local]
==> Registry Name
local

Checklist

I have:

[ ] Title of the PR starts with type (e.g. [Addon] , [example] or [Doc]).
[ ] Updated/Added any relevant documentation and examples.
[ ] New addon should be put in experimental.
[ ] Update addon should modify the version in metadata.yaml to generate a new version.

Verified Addon promotion rules
If this pr wants to promote an experimental addon to verified, you must check whether meet these conditions too:

[ ] This addon must be tested by addon's e2e-test to guarantee this addon can be enabled successfully.
This addon must have some basic but necessary information.

[ ] An accessible icon url and source url defined in addon's metadata.yaml.
[ ] A detail introduction include a basic example about how to use and what's the benefit of this addon in README.md.
[ ] Also provide an introduction in KubeVela documentation.
[ ] It's more likely to be accepted if useful examples provided in example dir.

Thanks for contribution, please sign the DCO.

Thanks for contribution, please sign the DCO.

@wangyikewxgm thanks for the reminder, signed.

Previously, due to this error, we pended the test for flink addon pre : https://github.com/kubevela/catalog/blob/55cf6be3c4195093ea9ba87c69a9c004baceee07/test/e2e-test/addon-test/PENDING#L6. Can you remove it from this file to let CI workflow test it?


Problem with TypeScript Compilation

WebStorm automatically generates TypeScript automatically for code that looks like:
Speakers.getInitialProps = async ({req}) => {     const isServer = !!req;
and creates an interface that looks like this:
    getInitialProps: ({req}: { req: any; }) =>          Promise<{ isLoading: boolean; hasErrored: boolean; speakers: any; isServer: boolean; } |             { speakers: never[]; hasErrored: boolean; isServer: boolean; errorMessage: any; }>;
The JavaScript fails to compile. I reported this the WebStorm and they say:

Declare property quick fix is provided by TypeScript compiler service, not by Webstorm itself, and the code generated by it is perfectly valid, syntactically correct typescript.
Looks like the next.js plugin responsible for transpiling .tsx (@zeit/next-typescript/babel? ) can't handle constructions like {req, query}: { req: any; query: any; }. I'd suggest reporting this issue to https://github.com/zeit/next-plugins/issues/

I'm not sure what you're asking 🤔

According to JetBrains (WebStorm), they are saying that the transpilation done with the nextjs plugin is incorrect and should be corrected. JetBrains is claiming that the typescript they are creating for the signature first listed is correct and that there is a bug that needs to be fixed in the next.js plugin.

This is confirmed as fixed in 9.0.5. That is, debugging on the fly works with typescript as the express server. I did have to run node with the --require ts-node/register option. I also had to make sure my .js files were removed. That is, I had previously server.ts and server.js.  removing server.js was necessary for debugging to work.


Interaction error responses

If an interaction handler throws and the interaction wasn't responded to, we could consider calling .showMessage with a formatted error.
Two forms of errors should be accepted, one being a custom error class like InteractionError, which contains CreateMessageData and can be passed directly as the response, with normal errors having a preset formatter.
This behavior should be configurable within the config, so we might be depending on #9. Config should follow this schema:

interactionErrors.enable if this behavior is enabled or not
interactionErrors.formatter a function to format an Error to a CreateMessageData
interactionErrors.ephemeral (true default), specifies what the ephemeral flag is default to, if the formatter doesn't specify this flag.
interactionErrors: false disable entirely
interactionErrors: true enable with default settings

when InteractionError is written, the default formatter should be a static method on it, meaning the default config entry is just formatter: InteractionError.defaultFormatter


Supertrend is not calculating period >7

Which version are you running? The lastest version is on Github. Pip is for major releases.
pandas-ta-0.3.5b0
Describe the bug
even if I put lenght = e.g. 12 still ta.supertrend is for a 7 period
To Reproduce
df = df.ta.supertrend(high=df['HA_high'], low=df['HA_low'], close=df['HA_close'], lenght=12, multiplier=9.0)

out:
                     SUPERT_7_9.0  SUPERTd_7_9.0  SUPERTl_7_9.0  SUPERTs_7_9.0
2021-07-10 00:00:00       16.0789             -1            NaN        16.0789

@rafalsza,
I already went over with at the end of your last Issue #311 which you have refused to acknowledge or confirm as well as deny your mistake.
For example, please tell me which of these work and why:
df = df.ta.supertrend(high=df['HA_high'], low=df['HA_low'], close=df['HA_close'], lenght=12, multiplier=9.0)

and
df = df.ta.supertrend(high=df['HA_high'], low=df['HA_low'], close=df['HA_close'], length=12, multiplier=9.0)

KJ

df = df.ta.supertrend(high=df['HA_high'], low=df['HA_low'], close=df['HA_close'], length=7, multiplier=9.0)

is working fine
problem is only for calculating lenght >7
even i"m putting lenght=12 i'm getting lenght=7

i'm sorry. My mistake with "lenght"


php code don't works inside views

Hello, something like this:
`{% extends "base.html" %}
{% block title %}Home{% endblock %}
{% block body %}

Welcome in home:)

<?php echo'php render works ?' ?>

{% endblock %}`
render only:
Welcome in home:)
looks like php code isn't run in views ?

You can't use PHP code inside a Twig template. You have to use only Twig commands. If you want some custom PHP code, you have to put it in a Twig extension and call that from your Twig code. More details on Twig extensions here.

Note do not make for everything a TWIG command you can beter render it in PHP put in a array and print in twig is much faster then make serval commands in TWIG.

Ok, thanks for help


Zeitwerk migration + activesupport 7.1 support

Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (8c2f35a) 93.55% compared to head (bb00a18) 93.85%.

:exclamation: Current head bb00a18 differs from pull request most recent head b87ea9d. Consider uploading reports for the commit b87ea9d to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
+ Coverage   93.55%   93.85%   +0.30%
==========================================
  Files         128      129       +1
  Lines        5926     5583     -343
==========================================
- Hits         5544     5240     -304
+ Misses        382      343      -39

Files
Coverage Δ

lib/active_graph/attribute_set.rb
93.33% <ø> (-0.42%)
:arrow_down:

lib/active_graph/base.rb
89.47% <ø> (-0.53%)
:arrow_down:

lib/active_graph/config.rb
94.00% <ø> (-0.24%)
:arrow_down:

lib/active_graph/core/instrumentable.rb
100.00% <ø> (ø)

lib/active_graph/core/querable.rb
100.00% <ø> (ø)

lib/active_graph/core/query.rb
98.92% <100.00%> (-0.05%)
:arrow_down:

lib/active_graph/core/query_ext.rb
100.00% <100.00%> (ø)

lib/active_graph/core/record.rb
100.00% <ø> (ø)

lib/active_graph/core/result.rb
100.00% <100.00%> (ø)

lib/active_graph/core/wrappable.rb
100.00% <100.00%> (ø)

... and 32 more

... and 34 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

This is what I am waiting for :) Will it be released in the near future?

@chytreg sorry, we are trying to release the branch this week

@chytreg please have a look at 11.5.0.beta.1 and let us know if you find any issues.

PR already merged branch 11


fix error "Cannot find module 'lean-qr/extras/svg'"

Description
I'm trying to add a QR Code in an vuejs app. Using the function toSvgDataURL will result in an console error:
Uncaught Error: Cannot find module 'lean-qr/extras/svg'
Usage
...

import { generate } from 'lean-qr'
import { toSvgDataURL } from 'lean-qr/extras/svg'

const code = generate(`https://qr.sli.do/${this.eventId}`)

const dataURL = toSvgDataURL(code, {
  on: 'black',
  off: 'transparent',
  padX: 4,
  padY: 4,
  width: null,
  height: null,
  scale: 1
})
console.log('dataURL', dataURL)

...

The same error occurrs for all methods relying on the import lean-qr/extras/svg
Full error message in browser console
cjs.js?!./node_modules/babel-loader/lib/index.js!./node_modules/cache-loader/dist/cjs.js?!./node_modules/vue-loader/lib/index.js?!./src/components/widgets/SlidoChat.vue?vue&type=script&lang=js&:10 Uncaught Error: Cannot find module 'lean-qr/extras/svg'
    at webpackMissingModule (cjs.js?!./node_modules/babel-loader/lib/index.js!./node_modules/cache-loader/dist/cjs.js?!./node_modules/vue-loader/lib/index.js?!./src/components/widgets/SlidoChat.vue?vue&type=script&lang=js&:10:45)
    at eval (cjs.js?!./node_modules/babel-loader/lib/index.js!./node_modules/cache-loader/dist/cjs.js?!./node_modules/vue-loader/lib/index.js?!./src/components/widgets/SlidoChat.vue?vue&type=script&lang=js&:10:138)
    at ./node_modules/cache-loader/dist/cjs.js?!./node_modules/babel-loader/lib/index.js!./node_modules/cache-loader/dist/cjs.js?!./node_modules/vue-loader/lib/index.js?!./src/components/widgets/SlidoChat.vue?vue&type=script&lang=js& (app.js:2090:1)
    at __webpack_require__ (app.js:849:30)
    at fn (app.js:151:20)
    at eval (SlidoChat.vue?df27:1:1)
    at ./src/components/widgets/SlidoChat.vue?vue&type=script&lang=js& (app.js:7017:1)
    at __webpack_require__ (app.js:849:30)
    at fn (app.js:151:20)
    at eval (SlidoChat.vue?bbb8:1:1)

your import line looks fine, so I have to assume this is an issue with the way Vue is configured (most likely it's not reading the package.json exports correctly). Are you able to create a minimal complete reproduction?
btw, if possible I'd recommend sticking to toCanvas rendering. SVG output is just for when offering a download option to users or if you need to generate an image on the server-side. Maybe that's your use-case, but most of the time it isn't.

I published 1.5.0 which replaces the wildcard exports with explicit exports, which might help you (assuming the issue was some tooling which doesn't understand wildcard exports). Give it a try and let me know, but if it doesn't fix it then I'll need to see an example of it failing to diagnose further.

Thanks for the swift feedback. I did not manage to set up a reproduction. On remote environment it simply works... This makes me think it's something with my local environment. I'll close this issue, until I get the chance to build something that can reproduce the issue.
I'll stick with the canvas option. it's working just fine 👍


build: make storybook publish work

This PR was deployed with mocked data in the following URLs for your appreciation:

Frontend: https://fabric8-launcher-frontend-pr-1241-app.surge.sh
Welcome App: https://fabric8-launcher-frontend-pr-1241-welcome-app.surge.sh
Storybook: https://fabric8-launcher-frontend-pr-1241-storybook.surge.sh


Primary/secondary color picker and background input

Category
Feature
Overview

Added two color selectors to the common settings page, which allow you to change the application's theme with the primary selector and change the logo text's gradient with a combination of primary/secondary selector

This has been updated to edit the MantineProvider's theme property and works globally across the app without having to read the config for what colors to use in individual components

Added a background image input to the advanced settings (set to cover, centered, and no-repeat) to address #32

Issue Number
#32
New Vars

config.settings.primaryColor
config.settings.secondaryColor
config.settings.background

Screenshot

Code Quality Checklist

[x] All changes are backwards compatible
[x] There are no (new) build warnings or errors
[x] Attribute is outlined in the schema and documented
[ ] Package is essential, and has been checked out for security or performance
[ ] Bumps version, if new feature added

I was able to edit the theme prop of MantineProvider by using React's context API and have pushed a new commit that removes the need to check config.settings.primaryColor in all of the colored components.
I'll be adding a bit more like a color tone selector and tile opacity slider before I open the PR for review again.

If you guys have any other suggestions of things I can add, let me know.

Not sure how to fix this if I'm being honest. There are only a couple of ways to handle backgrounds in CSS. We can either use the original size which results in the image being cut off or scale it to the browser window which results in the image not filling the screen if it's a different resolution.

The image is 1920x1080, and so is my browser window. So we can definitely fix this.

I will try some things.

Can't get it to work. But the issue is occuring on every image I try, so the feature is not ready for release yet.

IMO, app opacity should change the opacity of Modals, Drawers, and Item, backgrounds, etc. Not the icons (and text?).

See c0c816d

Can't get it to work. But the issue is occuring on every image I try, so the feature is not ready for release yet.

      styles={{
        body: {
          backgroundImage: `url('${config.settings.background}')` || '',
          backgroundPosition: 'top',
          backgroundSize: 'cover',
          backgroundRepeat: 'no-repeat',
        },
      }}

Changing the position to top makes it full width.

This should be fixed by giving the body min-height: 100vh.

I've make a PR from this PR 🤯 adding modules on left.
I'm almost ok, just need to check to add a params on each modules to know if it's a full width module or if it's a "widget".

Finished, just need to let @Aimsucks my PR in his branch to get it there.


Pin static_cell

static_cell 1.3 was released today dropping atomic-polyfill in favour of portable-atomic. Unfortunately, portable-atomic isn't compatible with something in RISC-V atomic emulation. This PR pins the old version as a band-aid so CI can stay blissfully ignorant.

I think the problem with portable-atomic is how they detect native/emulated atomics and us setting the target to imc and setting some flags to tell the compiler we have atomics


Improve SEO and more customization

Improve SEO and more customization

Hi, in next js when can I set different head tags and metadata, title, description etc.... for every page, and if it doesn't define those
it will use the default one, and those data in kobweb can be defined only in build.gradle.kts and there is no way
to define custom data for different pages
and how we can improve SEO for multiple languages. I already have a landing page and it has a simple multi-language system
however, when I publish this, google crawlers only see the English øne since it's compiled in compile time
and one additional note, the kobweb binary by default doesn't notify the developer if there is a new kobweb library version.
Thank you for your time and efforts.

And also I get this error
Incorrect http header content-type: "text/html; charset=utf-8" (expected: "application/xml")" how we can define different content type for different assets in the public folder

This is a couple of different things going on in here. FYI after we chat back and forth, I might close this issue and open separate ones.
Custom data per page
The docs don't cover this right now, and one day they definitely will, but you can use the standard JS APIs to set these per page. The right place to put this logic is inside your PageLayout.
Here's an example from my blog site: https://github.com/bitspittle/bitspittle.dev/blob/ff2b097b73e7d69845cc3dc44b7916ef783f7704/site/src/jsMain/kotlin/dev/bitspittle/site/components/layouts/PageLayout.kt#L51
SEO for multiple languages
I might need to think more about this, and look into how this works for other sites, but first I'd like to see what you're doing. I went to https://alrayada.net/, how can I change the language?
Kobweb library
I'm not sure there's a great way for me to do this actually. There are so many ways a user can declare a dependency on a library inside their Gradle build scripts. Even though I push people to use libs.versions.toml, I can't guarantee people will do that in their own project. So it's hard to write general logic that runs fast which can figure out which version of Kobweb you're using.
But more than that, if the current version of the Kobweb library is working for you, it's not always urgent to upgrade to the next one. So telling people a new version of the library is available when they don't want to upgrade can be really annoying to them.
The best recommendation I have for now is to follow the github project for updates or join my Discord, since new releases are always announced there.

This is a couple of different things going on in here. FYI after we chat back and forth, I might close this issue and open separate ones.
Custom data per page
The docs don't cover this right now, and one day they definitely will, but you can use the standard JS APIs to set these per page. The right place to put this logic is inside your PageLayout.
Here's an example from my blog site: https://github.com/bitspittle/bitspittle.dev/blob/ff2b097b73e7d69845cc3dc44b7916ef783f7704/site/src/jsMain/kotlin/dev/bitspittle/site/components/layouts/PageLayout.kt#L51
SEO for multiple languages
I might need to think more about this, and look into how this works for other sites, but first I'd like to see what you're doing. I went to https://alrayada.net/, how can I change the language?
Kobweb library
I'm not sure there's a great way for me to do this actually. There are so many ways a user can declare a dependency on a library inside their Gradle build scripts. Even though I push people to use libs.versions.toml, I can't guarantee people will do that in their own project. So it's hard to write general logic that runs fast which can figure out which version of Kobweb you're using.
But more than that, if the current version of the Kobweb library is working for you, it's not always urgent to upgrade to the next one. So telling people a new version of the library is available when they don't want to upgrade can be really annoying to them.
The best recommendation I have for now is to follow the github project for updates or join my Discord, since new releases are always announced there.

Hi, by default, it will choose english, and if you use arabic, it will change it to arabic
However, you can override this:
https://alrayada.net/?lang=ar
It's not improved for SEO, I recently did a workaround but I'm not sure if it will works
Thank you for your time again.

Sorry for the slow reply, it was a busy few days here.
I'm actually not too sure how to support SEO for multiple languages. I'll need to look things up and probably talk with others about it.
My first thought was to add stub pages that look something like this:
// pages/lang/ar/Index.kt
@Page
@Composable
fun HomePage_Arabic() {
   rememberPageContext().router.navigateTo("/?lang=ar")
}

[!NOTE]
You could generate this code automatically. I definitely wouldn't recommend doing it by hand!

But maybe there's a better way! It's a very interesting question, and I appreciate you bringing it up.

Based on a few things I've read, it seems like the only way to support multiple languages with SEO is to have a unique URL per language. Check out this blog post for example: https://www.semrush.com/blog/multilingual-seo/
In your case, I think it's just a single page portfolio site? In that case, it may be easy enough to add a bunch of those stubbed sites by hand.
If you support many languages and want to use code generation to create those sites, you might want to check out the section I just added to the README today: https://github.com/varabyte/kobweb#generating-site-code-at-compile-time

Based on a few things I've read, it seems like the only way to support multiple languages with SEO is to have a unique URL per language. Check out this blog post for example: https://www.semrush.com/blog/multilingual-seo/
In your case, I think it's just a single page portfolio site? In that case, it may be easy enough to add a bunch of those stubbed sites by hand.
If you support many languages and want to use code generation to create those sites, you might want to check out the section I just added to the README today: https://github.com/varabyte/kobweb#generating-site-code-at-compile-time

Hello, no need to be sorry, I already know it
is a big project, and you guys need more focused time
I already made the url unique by adding a lang parameter. However, I will try and do what you read if that still does not work

Ah yes, by "unique url" I meant everything before the ? (and/or before the '#' if you're using a fragment). All those parameters are stripped off when creating the final exported file. I guess this is more accurately called the pathname


Spell check highlighting does not show

vim version: version 8.2.2850
Hello, I enjoy using this TS syntax highlighting since its the best one I have ever used so far.
However, it seems to be conflicting with my spell check highlighting.
This is current example with syntax on

It seems to be checking the comment line, but not the strings.

This is spell check on with the SYNTAX OFF ( expected ):

Hi, thanks for reporting.
yats implements a simple syntax parser in VimScript. So it is critical for it using multiple syntax highlight groups.
I guess this why it conflicts with the spell checker.


build: run govulncheck with latest supported go version

Change Overview
Patch Go version from cache might contain vulnerabilities, but we specify minor version only in go.mod file.
Set check-latest for govulncheck-action
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test
[x] :building_construction: Build

Issues

fixes https://github.com/kanisterio/kanister/actions/runs/9441370518/job/26002009362#step:3:29

Test Plan
Run the workflow from this branch

[x] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

https://github.com/kanisterio/kanister/actions/runs/9455370624

So instead go-version-input should be set https://github.com/golang/govulncheck-action/blob/dd0578b371c987f96d1185abb54344b44352bd58/action.yml#L4. Another option is setting go-version-file https://github.com/golang/govulncheck-action/blob/master/action.yml#L4 i.e. the synchronization is always there and only go.mod would have to be adapted during new Go releases

Patch Go version from cache might contain vulnerabilities, but we specify minor version only in go.mod file.

Actually recent Go releases automatically also specify the patch version in go.mod. I've seen this e.g. recently when using go mod tidy

Actually recent Go releases automatically also specify the patch version in go.mod. I've seen this e.g. recently when using go mod tidy

When I run go mod tidy in kanister with 1.22.4 it doesn't do that.

Well the Go version in vulncheck should be the same as used. It's also possible to define a Go version explicitly in the yaml file, so that they a synchronous

"Used" version is whatever we have in the build image https://github.com/kanisterio/kanister/blob/master/docker/build/Dockerfile#L1
The reason we specify the minor version is because we don't want to bump the patch version in the code all the time. At the same time we don't rebuild the build image that often, so maybe having patch version in the go.mod is a good idea.
Alternatively we might consider using github workflow tools instead of the build image, maybe.

Actually recent Go releases automatically also specify the patch version in go.mod. I've seen this e.g. recently when using go mod tidy

When I run go mod tidy in kanister with 1.22.4 it doesn't do that.

Well the Go version in vulncheck should be the same as used. It's also possible to define a Go version explicitly in the yaml file, so that they a synchronous

"Used" version is whatever we have in the build image https://github.com/kanisterio/kanister/blob/master/docker/build/Dockerfile#L1 The reason we specify the minor version is because we don't want to bump the patch version in the code all the time. At the same time we don't rebuild the build image that often, so maybe having patch version in the go.mod is a good idea.

Wouldn't it be easier at this point to install and run govulncheck directly instead of using the Github Action? E.g.:
go install golang.org/x/vuln/cmd/govulncheck@3740f5cb12a3f93b18dbe200c4bcb6256f8586e2
govulncheck ./...

This way it's guaranteed that the check against the Go standard library version is always the same as in the build image. That's especially useful for minor version upgrades that need to be postponed. Another advantage is that this would allow for version pinning. This would create fully reproducible results and is also a security recommendation. [1] (The govulncheck action always pulls latest [2])
[1] OpenSSF Scorecard / Check Documentation / Pinned-Dependencies
[2] https://github.com/golang/govulncheck-action/blob/master/action.yml

Alternatively we might consider using github workflow tools instead of the build image, maybe.

Ah ok, what would be the difference for that option?

Wouldn't it be easier at this point to install and run govulncheck directly instead of using the Github Action?

That also makes sense. Then we will need to bump the go version in the build image if we have vulnerability report. That streamlines the process a bit.

Also, the go.mod file specifies the toolchain with a patch version, perhaps that needs to be updated?

Yes, updating the toolchain setting to 1.22.4 makes the govulnchech pass.
But I'm not 100% sure that's the right way to go, because if we build the binaries with make build-controller or make goreleaser we get them built with the go version from the build image (which is 1.22.2 currently)
So I feel like we better either keep go version in go.mod in sync with the build image or use the build image to run govulncheck instead of govulncheck action.

@hairyhum

So I feel like we better either keep go version in go.mod in sync with the build image or use the build image to run govulncheck instead of govulncheck action.

IIUC, the risk would be to incorrectly deem a build as non-vulnerable when there is an actual vulnerability. Is that the concern?
The scenario would be:

Run govulncheck with the most recent Go toolchain, which would cause the check to "incorrectly" succeed.
And then build the rest of the code with an outdated Go toolchain that has known vulnerabilities (for example, in the standard library).

My understanding, (and please verify because I could be wrong) is that the Go toolchain will attempt to use the newer toolchain when the version of the currently running toolchain does not match.

Not unless there's a GOTOOLCHAIN variable set in the environment. And it is set in the golang:1.22-bullseye which we base the build image from.
This makes sense for the build image for predictability reasons. You don't want the build image to auto-detect and download a new golang version.
Unfortunately it doesn't fail or warn us the the toolchain is set to later version than the local and just builds with whatever it currently has.
If we set go 1.22.4 in go.mod file, it would fail then. So I would suggest that we do that and keep our build image up to date.

REWORK
The PR now gets go version from the build image.


fix: mixture of explicit and implicit function-param position

Closes #1267
Fix the RleaxNG schema

You can no longer mix x:param[@postion] and x:param[empty(@position)] in a x:call:
Not allowed
<x:call>
  <x:param />
  <x:param position="2" />
</x:call>

Not allowed
<x:call>
  <x:param position="1" />
  <x:param />
</x:call>

You can still mix x:param[@postion] and x:param[empty(@position)] in a layered x:scenario:
Allowed
<x:scenario>
  <x:call function="...">
    <x:param />
    <x:param />
  </x:call>

  <x:scenario>
    <x:call>
      <x:param position="1" />
      <x:param position="2" />
    </x:call>
  </x:scenario>
</x:scenario>

Fix resolving a mixture of x:param[@postion] and x:param[empty(@position)]
Now x:param[empty(@position)] is treated as if it had a document-order @position.
Consider this scenario:
<x:scenario>
  <x:call function="...">
    <x:param position="3" select="'p3'" />
    <x:param position="1" select="'p1'" />
  </x:call>

  <x:scenario>
    <x:call>
      <x:param select="'n1'" />
      <x:param select="'n2'" />
    </x:call>
  </x:scenario>
</x:scenario>

The current master branch constructs a final parameter array ['n1', 'n2', 'p1', 'p3'].
After this pull request, the same scenario is treated as if all x:param had explicit @position like this:
<x:scenario>
  <x:call function="...">
    <x:param position="3" select="'p3'" />
    <x:param position="1" select="'p1'" />
  </x:call>

  <x:scenario>
    <x:call>
      <x:param position="1" select="'n1'" />
      <x:param position="2" select="'n2'" />
    </x:call>
  </x:scenario>
</x:scenario>

The final parameter array is ['n1', 'n2', 'p3'].

Thanks for reviewing this, @galtm.

Did you consider not allowing the "mixture of x:param[@position] and x:param[empty(@position)]" case, even in nested scenarios? I can't think of a use case for it, and it seems like the test would be clearer without such a mixture. But I do think the new behavior makes more sense than the old one.

It is true that the test would be clearer without such a mixture. On the other hand, allowing the mixture would be handy in some cases. For instance, it would be tedious to write position="1" and position="2" in every child of this scenario:
https://github.com/xspec/xspec/blob/7cb79610255766fbfce10be856165d2ad9710de0/test/deep-equal.xspec#L20-L93
So this pr leaves it up to the test author's preference rather than enforcing the clearer style.

would be handy in some cases. For instance, [...]

OK, thanks for explaining your reason for allowing the mixture.


luci-app-Transmission function is missing

There is no control option for "script-torrent-done-enabled": and "script-torrent-done-filename": "", in the luci page, and it cannot be controlled by modifying the settings.json file of Transmission (modifying settings.json file, the modified configuration will be lost if Transmission is restarted)

Resolved, can be achieved by modifying / etc/config/Transmission


[admin] Creating a new user with invalid email address generates a Server Error (500).

Adding a new user with a fake email will output a Server error (500) message. Adding the new user again with a real email will succeed and the system will add the new user accordingly. From this point, the new user can now be edited with a fake email and the real email can now be removed from the database.
Please see mailing list topic: Fresh installation of Debian 9 server + ansible-openwisp2, gateway error 500
Thank you

Invalid Email Address ?
But I Used A Valid One !

It may be related or the cause of https://github.com/openwisp/ansible-openwisp2/issues/132

I can't replicate this issue on my local development openwisp_users repo. I am still able to create users with fake emails in my local openwisp_users repo. Please can someone help me to replicate the issue on my local openwisp_users repo so that i might be able to provide a fix? Thanks

@NoumbissiValere by default, the test project runs the console email backend and prints emails to the standard output of the development server.
In order to test it, you should set it to the default email backend of django and then continue tweaking and testing from there.

@nemesisdesign

I replaced the console backend with the default backend as you suggested . this is the backend i put : EMAIL_BACKEND = 'django.core.mail.backends.smtp.EmailBackend'  (even though django uses this by default)
But i was still able to create users with an invalid email such as<EMAIL_ADDRESS>I equally tried turning off debugging thinking it was the problem but i didn't still replicate the issue
i equally added the following settings but it didn't still work

EMAIL_USE_TLS = True
EMAIL_HOST = 'smtp.gmail.com'
EMAIL_PORT = 587
EMAIL_HOST_USER = 'my_real_email'
EMAIL_HOST_PASSWORD = my_real_email_password'

all i get is an email from example.com saying address not found. but the user was still created.
Please what am i doing wrong. I will love to be corrected.

you should not configure the real SMTP, because of course in that case it won't fail but it will work.
This error happens when the default settings are used, a local postfix instance is running and for some reason postfix returns error when sending the email

@nemesisdesign on my vagrant VM, i was not able to even add a user whether with valid email or not (was getting the server 500 error). when i check the openwisp2 error log, i got this error message.
File "/usr/lib/python3.5/smtplib.py", line 862, in sendmail     raise SMTPSenderRefused(code, resp, from_addr) smtplib.SMTPSenderRefused: (501, b'5.1.7 Bad sender address syntax'<EMAIL_ADDRESS>
I thought that postfix is trying to use<EMAIL_ADDRESS>as sender email which doesn't exists and thus the SMTPSenderRefused exception. So i opened the settings.py of openwisp2 and changed the DEFAULT_FROM_EMAIL to an email which exists and i was able to create users with valid and invalid emails.
I am thinking that the problem is not in the code but either in the settings or the way the postfix is configured

@NoumbissiValere I think this is good enough to write a fix.
The system should not fail with 500 internal server error. I suggest to proceed this way:

write a test that mocks the part of the code which triggers the sending of the email so that the mocked method raises an exception, for example, smtplib.SMTPSenderRefused
ensure the test fails
wrap the code that sends the email in a try/except block which catches Exception and uses logger.exception('Error while sending email verification to user') to log the exception

This will avoid the 500 internal server error that many of our users are having. Emails won't be sent, but advanced users will find out by inspecting the logs or they will get error exceptions via sentry.io. Beginner users won't even notice because they may not even need this feature or be aware this exists, so in the future we may need to make this more explicit in the docs, but at least now we will not prevent users from adding new users into their openwisp instance.

I think it is a great idea.
i have a problem: Please how will I test the fix on my Vagrant Box. The openwisp2 is running on the VM which was created by vagrant. How do i get the modified openwisp_users to this openwisp2 instance to test it ?
Thanks

@NoumbissiValere
try this:
cd /opt/openwisp2
source env/bin/activate  # activate python virtualenv
pip install --upgrade https://github.com/NoumbissiValere/openwisp-users/tarball/<your-branch-here>
# look into /opt/openwisp2/env to find the code of openwisp-users and ensure your changes are there
# you can find out the exact path location by opening the python shell and checking openwisp_users, eg:
# python
# >>> import openwisp_users
# >>> openwisp_users
# will tell you where the openwisp_users package is located on the filesystem.
# once you are sure the code has been upgraded you have to restart openwisp with:
supervisorctl restart all


Year view

How do I display 12,13 months on one page + enable selector? is it possible?

Can you elaborate a bit what do you need exactly? Current question is pretty abstract.

Either this:
[http://www.iworkcommunity.com/system/previews/images/000/000/597/original/2010_calendat_year_view_gantt_.jpg?1376526066]
or this view:
[http://www.devcomponents.com/dotnetbar/img/CalendarYearView1.png]

First is definitely not supported, second is pretty doable when you specify calendars : 12 and reduce parent container width so that it will break down into 3 rows of calendars. However, common header with arrows right and left you'll need to make yourself.


Update README.md with correct links & text

Changed the links to the correct links, this isn't the media library..

Thanks!


DOCK-2403: Link to individual source files

Description
This PR changes the UI so that when the user views a source file, its absolute path is added to the URL as the file query parameter.  The resulting URL directly references the source file and can be copied/pasted/saved for future use.
Please view this PR locally and try to make it malfunction.
Believe it or not, the private entry page does not track the selected tab in the URL or allow linking to a particular tab, like the public entry page does.  I poked around and it looks like harmonizing the behavior would be hazardous and quite a chore, so I left it as is.  Thus, the new functionality is only available on the public entry page.
When a version changes, source files can potentially disappear.  When a URL references a now non-existent file, the UI displays a message to that effect, and displays a different file.
As the team informally decided, this PR doesn't implement the "line number" part of DOCK-2403.  However, whilst coding this PR, I realized that it might be relatively easy to do.  If we add a hash of the source file's content to the URL, we can detect that the source file has changed and take appropriate action (for example, no longer highlight the specified line, because the source file content could no longer match up).  If we decide to include the "line number" functionality, I suggest we add it in a follow-up PR.
Review Instructions
View an entry's public page.  Click on the "Files" tab.  Confirm that the absolute path of the displayed source file has been added to the URL as the file query parameter.  Copy the URL.  Select a different file.  Visit the URL.  Confirm that the original file is displayed.  Paste the URL, corrupt the file query parameter, visit the resulting URL, and confirm that an appropriate message is displayed.  Play around with the interface in similar fashion and try to find bugs.
Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2403
Security
This PR changes the browser URL to include the absolute path of a source file as a query parameter.  The code appears to encode characters correctly, and source files are limited to a small subset of "safe" characters, so I don't believe there is an issue.  However, please scrutinize.
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that your code compiles by running npm run build
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[x] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[x] Do not use cookies, although this may change in the future
[x] Run npm audit and ensure you are not introducing new vulnerabilities
[x] Do due diligence on new 3rd party libraries, checking for CVEs
[x] Don't allow user-uploaded images to be served from the Dockstore domain
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
[x] Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

Thus, the new functionality is only available on the public entry page.

This is fine, most users shouldn't be able to share private urls anyway, unless they belong to the same organization anyway.


Improve error reporting when a cluster fails

Instead of running for minutes after an error until all other cluster complete, exit on the first error.
On the CI no cleanup is not an issue, since the github runner cleans up child processes. Here is the output from the cleanup job:
Cleaning up orphan processes
Terminate orphan process: pid (118311) (python3)
Terminate orphan process: pid (118588) (kubectl)

But when running locally nobody does any cleanup.
Status:

This is an ugly hack, need little rework
Need a cleaner solution when we have more time

Merged with #1241


fix exponent for relationship between ω and ο

Maybe I'm just confused, but I believe that $\omega^{\frac{1}{\rho}} = o$ is incorrect, and $\omega^\rho = o$ is correct.

I think you are confusing the expansion factor with the rate. The rate ρ is a number between 0 and 1; the expansion factor is its reciprocal.

The length of this list is larger than the number of possibly nonzero coefficients in the polynomial by a factor called the expansion factor (also blowup factor), which is the reciprocal of the code’s rate ρ.

That explains my confusion.


Issues with Parallel pages html content download

It does not seem that there is parallel download happening when I am downloading a batch of urls. The url downloading is  completing way late than it does when download individually.
I am using a 2 core ec2-machine with 4gb RAM. All system resources are pretty stable in a batch size of 30 urls. The connection time out used here is 30 seconds. Their are urls which complete as late as 15 s, 20 secs, 23 secs which complete in about 3-7 seconds when run individually. Is not parallel IO supposed to happen here. What am I missing?
let startDate new Date();
let finishDate;
const puppeteer = require('puppeteer');

await puppeteer.launch().then(async browser => {
  const promises=[];
  urlArr.forEach(function(url){
  promises.push(browser.newPage().then(async page => {
          try{
               await page.goto(url.startsWith('http') ? url : `http://${url}`, {
                 waitUntil: ['load'],timeout:connectionTimeOut
               });

              const html = await page.content();
              finishDate = new Date();
              console.log("html download complete for " + url + " - " + finishDate.getTime() + " - " + (finishDate.getTime() - startDate.getTime())/1000);
            }catch(err){
              console.log(err)
            }
       }))
  });
  await Promise.all(promises)
  await browser.close();
})

How about using cluster?

@nammaianh The issue I am referring to is about how much parallel operations can be done on a single node. Irrespective of, if it is part of a cluster or not.

Standard networking applies and the browser needs to delegate and prioritize resource downloads. You're most likely simply saturating the network.

@nammaianh The issue I am referring to is about how much parallel operations can be done asynchronously, on a single node. Irrespective of, if it is part of a cluster or not.
@Garbee All resource including CPU, RAM, Network are stable. The instance type which I am using has a network bandwidth of 2000 MBPS. Have performed the similar exercise for a batch of 5 domains as well, getting the same results, so network is surely not the culprit here.
What is observed here is that all 'goto' operations for all urls get started  simultaneously but its completion and 'download' operation occur sequentially
Sample output for batch size of 5 and their respective completion time stamps:
Start goto : url1 -<PHONE_NUMBER>085
Start goto : url2 -<PHONE_NUMBER>099
Start goto : url3 -<PHONE_NUMBER>107
Start goto : url4 -<PHONE_NUMBER>108
Start goto : url5 -<PHONE_NUMBER>109
End goto : url5 -<PHONE_NUMBER>356 - 0.593
Start content : url5 -<PHONE_NUMBER>357
End goto : url3 -<PHONE_NUMBER>363 - 0.6
Start content : url3 -<PHONE_NUMBER>364
End content : url3 -<PHONE_NUMBER>371 - 0.608
End content : url5 -<PHONE_NUMBER>372 - 0.609
End goto : url4 -<PHONE_NUMBER>844 - 4.081
Start content : url4 -<PHONE_NUMBER>844
End content : url4 -<PHONE_NUMBER>854 - 4.091
End goto : url1 -<PHONE_NUMBER>797 - 7.034
Start content : url1 -<PHONE_NUMBER>797
End content : url1 -<PHONE_NUMBER>060 - 7.297
Total time : 9.938

@engineerkushal I'm having a similar issue. Did you find a solution?

@aslushnikov I don't think the problem was ever in navigating multiple pages. It's just that the amount of time taken was really long, and all the system resources including CPU, memory, load average, operation queue was well under threshold values.
And since the expected behavior is that io involved in each page navigation will be in parallel, the amount of time involved in the batch is not justified in comparison to the amount of time taken when navigated individually.
Will get some latest numbers around this and post here.


UnsatisfiedLinkError when ArSceneView.resume() is called

I'm using the solarsystem example app on the Android Emulator (v27.3.4, Pixel 2 API 27, Android 8.1).
When the program calls arSceneView.resume() I am getting an UnsatisfiedLinkError when it is trying to execute System.loadLibrary("arsceneview_jni").
I analysed the APK and could see that libarsceneview_jni.so was included in the arm64-v8a lib directory, but it was not included in the x86 lib directory.
In this example app it seems to just ignore the fact it can't find it and continue. However on an app that I have made, this is the last error I can see before the app crashes.
My setup:

Android Studio 3.2 Canary 13
Build #AI-181.44<IP_ADDRESS>49738, built on April 27, 2018
JRE: 1.8.0_152-release-1136-b03 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.13.0-43-generic

Logcat of error

2018-06-06 10:17:51.137 18737-18737/com.example.ezio.ar_rf_demo E/ArSceneView: Error loading libarsceneview_jni.so
java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.example.ezio.ar_rf_demo-zd2B2OglxcrOEBwzbiXNog==/base.apk"],nativeLibraryDirectories=[/data/app/com.example.ezio.ar_rf_demo-zd2B2OglxcrOEBwzbiXNog==/lib/x86, /data/app/com.example.ezio.ar_rf_demo-zd2B2OglxcrOEBwzbiXNog==/base.apk!/lib/x86, /system/lib, /vendor/lib]]] couldn't find "libarsceneview_jni.so"
at java.lang.Runtime.loadLibrary0(Runtime.java:1011)
at java.lang.System.loadLibrary(System.java:1657)
at com.google.ar.sceneform.ArSceneView.reportEngineType(Unknown Source:2)
at com.google.ar.sceneform.ArSceneView.resume(Unknown Source:4)
at com.example.ezio.ar_rf_demo.MainActivity.onResume(MainActivity.java:226)
at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1355)
at android.app.Activity.performResume(Activity.java:7117)
at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3556)
at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3621)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1638)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:438)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

What are the abi filters from your  gradle script?
From the sample gradle scripts:
        ndk {
            /*
             * Sceneform is available for the following ABIs: arm64-v8a, armv7a,
             * x86_64 and x86. This sample app enables arm64-v8a to run on
             * devices and x86 to run on the emulator. Your application should
             * list the ABIs most appropriate to minimize APK size (arm64-v8a recommended).
             */
            abiFilters 'arm64-v8a', 'x86'
        }

I get the error using the solarsystem demo app, completely unmodified. So yes, they are the abiFilters I'm using.

@drunkenplatypus  - Thanks for  the issue report.  As you noticed, it is a problem loading a library in the emulator (or x86 devices), and other than creating an exception in the log file, it does not affect the performance or functionality of Sceneform.  It's on the list to fix in a future release.

With the new version of
implementation 'com.google.ar.sceneform.ux:sceneform-ux:1.12.0' the sceneform.ux.ArFragment started to crash with the same stacktrace as this one.

2019-09-27 15:05:41.024 libc: Fatal signal 6 (SIGABRT), code -6 in tid 28022
2019-09-27 15:05:41.294 28879-28879/?  A/DEBUG: Build fingerprint: 'samsung/a3y17ltexc/a3y17lte:8.0.0/R16NW/A320FLXXS4CSG5:user/release-keys'
2019-09-27 15:05:41.294 28879-28879/? A/DEBUG: Revision: '4'
2019-09-27 15:05:41.294 28879-28879/? A/DEBUG: ABI: 'arm'
2019-09-27 15:05:41.294 28879-28879/? A/DEBUG: pid: 28022, tid: 28022, name: ...
2019-09-27 15:05:41.294 28879-28879/? A/DEBUG: signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
2019-09-27 15:05:41.294 28879-28879/? A/DEBUG:     r0 00000000  r1 00006d76  r2 00000006  r3 00000008
2019-09-27 15:05:41.294 28879-28879/? A/DEBUG:     r4 00006d76  r5 00006d76  r6 ffb5fda0  r7 0000010c
2019-09-27 15:05:41.294 28879-28879/? A/DEBUG:     r8 00000056  r9 c16da98d  sl 00000000  fp ffb5ff6c
2019-09-27 15:05:41.294 28879-28879/? A/DEBUG:     ip 00000000  sp ffb5fd90  lr ecf354c7  pc ecf66748  cpsr 200e0010
2019-09-27 15:05:41.297 28879-28879/? A/DEBUG: backtrace:
2019-09-27 15:05:41.297 28879-28879/? A/DEBUG:     #00 pc 0004b748  /system/lib/libc.so (tgkill+12)
2019-09-27 15:05:41.297 28879-28879/? A/DEBUG:     #01 pc 0001a4c3  /system/lib/libc.so (abort+54)
2019-09-27 15:05:41.297 28879-28879/? A/DEBUG:     #02 pc 000571f1  /data/app/com.<...>.debug-HdcYqzh22fveHQHBcYioVw==/lib/arm/libfilament-jni.so

Turns out that I forgot to update project Gradle file as well classpath "com.google.ar.sceneform:plugin:1.12.0". This fixed the problem of launching AR.
But. The crash still happens if I replace AR fragment with another and then again to AR fragment:
supportFragmentManager.beginTransaction().replace(R.id.treasure_hunt_fragment, arFragment).commit()
// after button click
supportFragmentManager.beginTransaction().replace(R.id.treasure_hunt_fragment, supportMapFragment).commit()
// after another button click
supportFragmentManager.beginTransaction().replace(R.id.treasure_hunt_fragment, arFragment).commit()

Also facing the same issue.

@soshial i occured the same question, did u find any resolved methods?

what u have found so far is  that  error we are recieving is  Error loading libarsceneview_jni.so but if we analyze apk the file " libarsceneview_jni " is not there because its renamed to libarsceneview-jni.so so i dont know how can we fix on our side but it seems like the cause of this error

@claywilkinson could you please look into it either i am wrong or right..

@tpsiaki Could you comment on libarsceneview_jni name change above?
@adeelturk libarsceneview may be optional, can you try adding a try/catch around the onResume call?  BaseArFragment is open-source in the sceneformux package: https://github.com/google-ar/sceneform-android-sdk/blob/master/sceneformux/ux/src/main/java/com/google/ar/sceneform/ux/BaseArFragment.java

ok i will but when i downgraded my library veriosn to 1.11 same source code is working so i dont think its optional at least not in my case

i want to draw a 3d object on marker , all i found is that its working propely in 1.9 only but that version is missing with a method to setFocusMode and i want this method because if i try to read marker on a paper without focus it doesnt work so i am kinda stuck here

@adeelturk the callstack listed above showing a problem loading libsceneview_jni is due to a problem we have in Sceneform with being overly chatty in our logs when we hit a certain failure case, but it's not fatal.  If you're seeing a crash in your app, there should be a different fatal callstack that will show up in adb logcat.  For example, the above report from @soshial also listed this callstack, but the fatal callstack was related to having a mismatch in the version of the sceneform plugin library and the sceneform ux library (which results in a Filament material version mismatch, and in the case of the 1.11 to 1.12 versions, a fatal crash).

@tpsiaki I have version 1.12.0 set in both places:
ext.sceneform_version = "1.12.0"
implementation "com.google.ar.sceneform.ux:sceneform-ux:$sceneform_version"
classpath "com.google.ar.sceneform:plugin:$sceneform_version"

I have this log just before UnsatisfiedLinkError exception:

@tpsiaki I have version 1.12.0 set in both places:
ext.sceneform_version = "1.12.0"
implementation "com.google.ar.sceneform.ux:sceneform-ux:$sceneform_version"
classpath "com.google.ar.sceneform:plugin:$sceneform_version"

I have this log just before UnsatisfiedLinkError exception (Samsung Galaxy A3 2017):

@soshial if you search for "FATAL" in your log are there any errors/callstacks after the UnsatisfiedLinkError libarsceneview_jni log?  I would expect the fatal issue to be after (perhaps long after in the logs) that UnsatisfiedLinkError.

No FATAL keyword on both Samsung Galaxy A3 and Google Pixel 3. The latter had this log:

@soshial change 1.12.0 to 1.11.0. works for me. As you can see in 1.12.0 there is no significant fix or new feature provided.


Update editor mode while changing buffer

Have a file without ending but this first line
#!/usr/bin/env node

it should be associated to JavaScript.

@bpasero This is still the old world, no clue that's the API are?

This relates to #703 which must also know this during FS eventing phase.

Cannot reproduce:

The thing that does not work (yet) is updating the editor live or during the session. So currently you need a reload or pick the mode from the mode picker.

yeah, that's what I saw

ok, fair (known) issue

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!


exp/orderbook: Exclude arbitrage paths from path finding search

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

What
One of the changes to the path finding algorithm introduced by https://github.com/stellar/go/pull/4096 is that the new algorithm includes paths which take advantage of arbitrage opportunities. In this commit, I have removed that behavior so that no arbitrage paths will be included in the response.
Why
The horizon v2.12.0 release contains substantial implementation changes to the path finding algorithm. Removing the differences in outputs between the old and new algorithm will make it easier to test. We can always include the arbitrage paths functionality in a future release.
Clients which always pick the first path from the path finding response and use it in a path payment operation might be frustrated when the first path is an arbitrage path which will have a lot of contention. You can imagine a situation where the client submits the path payment but it fails because the offers which lead to the arbitrage have already been consumed by another transaction.
Known limitations
[N/A]

LGTM, as long as my assumption that the removed tests fail with this change.

there are no removed test cases. I removed an arbitrage path from the expected response in the unit test. the unit test requires the response match the expected response otherwise the test will fail. in other words, the expected response contains no arbitrage paths but the graph in the test case actually has an arbitrage opportunity


[feature] add presets

Presets allow users to save teuthology-suite
command config with a unique name for that user
to be reused again.
This PR:

Adds postgres database with alembic
Creates Presets Table
Add endpoints:

GET presets/
GET presets/list/
POST presets/add/
UPDATE presets/edit/
DELETE presets/delete

Adds a PresetsDatabaseException
Creates PresetsService which is responsible for all presets DB operations

@Devansh3712 I think you can work on top of this branch. There are few things I remember that needed to be addressed since I last updated it:

This PR was opened before t-api's packaging work was done which restructured the whole project - https://github.com/ceph/teuthology-api/pull/23. Looks like I rebased it after packaging PR was merged but please see if you're able to get the branch running.
I remember that Zack mentioned that we could use SQLite instead of PostgreSQL - so we can start by changing that if this branch is running without problems.
There's also a merge conflict that we see now so a rebase is probably needed.


Checker reporting an ERROR affects EFFECTIVELY_FINAL symbol flag in subsequent source files

I was upgrading error-prone to 2.31.0 on a branch for a project and it started reporting both DefaultCharset and FormatStringAnnotation violations in a module.
The former were expected and valid but the latter left me scratching my head as the FormatStringAnnotation checker was not modified between the versions afaict.
I tried reproducing the FormatStringAnnotation violations in an error-prone unit test but the code was passing the check just fine.
Then I tried to reproduce the whole scenario in an error-prone integration test and was successful, so I have pushed the test code here:
https://github.com/XN137/error-prone/pull/1
note:

it looks like after an ERROR has been reported by UnusedVariable, the symbol flags are different in subsequent files and the EFFECTIVELY_FINAL flag is no longer set and so FormatStringAnnotation is reporting "phantom violations"
the symbol flags stay the same when UnusedVariable is set to WARN
the symbol flags stay the same when the file comes before the file that contains the UnusedVariable ERROR violation
in the IT I have replaced DefaultCharset with UnusedVariable to show its not related to DefaultLocale / String.format having any shared state with FormatStringAnnotation

please take a look and let me know whether this is expected behavior in errorprone (or javac) or a potential bug?
If the former, maybe this should be documented somewhere as it can be really confusing if checker B starts reporting "unjustified" violations just because checker A has already reported an ERROR.
sorry in case i missed something obvious that would explain this behavior.

@cushon sorry for the ping but would it be possible to get any feedback or basic ACK here ?

I had a look
It reproduces with the CLI:
$ javac    -J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED   -J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED   -J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED   -J--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED   -J--add-exports=jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED   -J--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED   -J--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED   -J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED   -J--add-opens=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED   -J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED   -XDcompilePolicy=simple   -processorpath error_prone_core-2.33.0-with-dependencies.jar:dataflow-errorprone-3.41.0-eisop1.jar   '-Xplugin:ErrorProne -XepDisableAllChecks -Xep:UnusedVariable:ERROR -Xep:FormatStringAnnotation:ERROR' Violation.java  GenericException.java SpecialException.java  -cp error_prone_annotations-2.33.0.jar -XDverboseCompilePolicy
[attribute test.Violation]
[attribute test.GenericException]
[attribute test.SpecialException]
[flow test.Violation]
Violation.java:6: error: [UnusedVariable] The local variable 'x' is never read.
    int x = 0;
        ^
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean to remove this line?
SpecialException.java:9: error: [FormatStringAnnotation] All variables passed as @FormatString must be final or effectively final
    super(message2, args2);
         ^
    (see https://errorprone.info/bugpattern/FormatStringAnnotation)
2 errors

EFFECTIVELY_FINAL is set in the 'flow' phase, which hasn't executed yet here: https://github.com/openjdk/jdk/blob/bd6264420b9f248999dd8387c25c549b08bd193a/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java#L2220-L2221
With Violation.java as the last source on the command line, we get:
[attribute test.GenericException]
[attribute test.SpecialException]
[attribute test.Violation]
[flow test.GenericException]
[flow test.SpecialException]
[flow test.Violation]

-XDcompilePolicy=byfile (which I don't recommend unless JDK-8155674 is fixed) also works around it
[attribute test.Violation]
[flow test.Violation]
[desugar test.Violation]
[generate code test.Violation]
[attribute test.GenericException]
[flow test.GenericException]
[desugar test.GenericException]
[generate code test.GenericException]
[attribute test.SpecialException]
[flow test.SpecialException]
[desugar test.SpecialException]
[generate code test.SpecialException]

I think I understand what's going on now. This logic means that TaskListener.finished gets called for 'flow' events even if the actual 'flow' phase was skipped because errors were logged: https://github.com/openjdk/jdk/blob/bd6264420b9f248999dd8387c25c549b08bd193a/src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java#L1403-L1432. So if Error Prone reports an error, subsequent compilations will skip flow but still do analysis.
Passing -XDshould-stop.ifError=FLOW also resolves the error, by ensuring 'flow' happens unconditionally before Error Prone runs.
I think -XDshould-stop.ifError=FLOW is a reasonable recommendation in general, especially when using -XDcompilePolicy=simple, because it makes the behaviour more similar to the default compile policy (JDK-8134117 is related)
So the outcome might be to update the installation docs to recommend that flag.

@xenoterracide this might be the issue you were seeing in https://github.com/uber/NullAway/issues/923?

I'm tentatively planning to require setting a stop-on-error policy when running Error Prone in the next release. https://github.com/google/error-prone/commit/5828416d06cd4247b2dc575a593621f07a35f0b5 uses -XDshould-stop.ifError=FLOW, which relies on javac's internal support for -XD 'debug' flags that get written directly to the options table. There's also a hidden flag that doesn't rely on the -XD prefix, so perhaps we should be using that instead: --should-stop=ifError=FLOW
Also note that there were some changes to the syntax of this option: https://bugs.openjdk.org/browse/JDK-8162546, https://bugs.openjdk.org/browse/JDK-8198314

The fix is released in https://github.com/google/error-prone/releases/tag/v2.34.0

@cushon it appears that the new --should-stop=ifError=FLOW check isn't executed at least with Maven; see this anaysis.

[@cushon](https://github.com/cushon) it appears that the new --should-stop=ifError=FLOW check isn't executed at least with Maven; see this anaysis.

Thanks for the catch, I missed that there are two calls to checkCompilePolicy, including one in addTaskListener that handles the plugin case here. I'll add similar checking for --should-stop=ifError=FLOW.

sorry for the late response.
i had suspected the compiler goes into a different "analysis mode" once the first error is encountered but didnt know enough about the javac internals to come up with an explanation without further research.
so thanks a lot for coming up with a solution for this so quickly 👍


Fix for ios devices applying border-radius to inputs

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add a mechanism to suppress stack trace.

Add a mechanism to control whether HttpResponses.error() shows the error details, particularly the stack trace. By default it doesn't show the stack trace, but the interface can be enabled to show it.

@Wadeck @daniel-beck

It looks like this is ready to go. @jglick or @daniel-beck, who can help get this merged in and released?

who can help get this merged in and released?

Based on permission files, nobody is currently a maintainer of Stapler, so this can currently only be released by people with universal upload permissions, basically Oliver Gonda and people with Artifactory admin access (Tyler, KK, Wadeck, me). Alternatively, we use part of the security process to deploy into a secondary repo, and then move artifacts over. 😆
(@jglick no longer has his previous universal upload access.)

Looks like Stapler is (now?) released to repo.j.o, and nobody has permissions to do this, which basically means Oliver Gondza and the Artifactory admins (KK, Tyler, Wadeck, and me) can do it. Or we use some of the security process to deploy into a private repo and them copy it over. 😆

IIUC this is waiting for https://github.com/jenkins-infra/repository-permissions-updater/pull/1420

@jglick Looks like the parent POM results in deployment to OSSRH after all? If so, could you release Stapler?

https://github.com/stapler/stapler/releases/tag/stapler-parent-1.259

Thanks for releasing that, @jglick!


chore!: Remove Block, RAM and ROM opcodes

Description
Problem*

Resolves
Summary*
This PR removes the Block, RAM and ROM opcodes, we have replaced these opcodes with MemOp and MemInit. It also renames some concepts which no longer make sense without them.
Additional Context

PR Checklist*

[ ] I have tested the changes locally.
[ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

LGTM - one nit, would be good to move the doc comment about init to MemOp. ie:

init: write operations with index from 0..MemoryBlock.len


Docs highlight some JS objects as errors

setting the code fence type to text doesn't syntax highlight but it also doesn't mark it with error highlights. I'm wondering if this is something that should be fixed.

Forgot to add a screen grab of the problem:

@samselikoff happy to take this one if your interested in fixing these.

@alecho that would be great. Yes these are super annoying

@alecho Any additional info on where you are seeing these problems?  We could tag this with a "good for new contributors" flag if there's a bit more info ...

I believe when the docs are showing the expected body of the response. I think the highlighter was trying to determine the syntax type and was picking either Javascript or JSON and then highlighting errors based on that type. I just did a quick look though the docs and it looks like this is fixed now.

Sounds good 👍


Proposal: Add more experimental modules to OSBA

Currently, OSBA provides several common-used services. I think, compared to AWS Service Broker, we provide fewer services but with better support on existing services. Should we be more aggressive and add more experimental modules to OSBA? By adding more modules, we empower users to use more Azure services which they may be interested in. I have made a chart about the difference between AWS Service Broker and OSBA. And I'm glad to work on this if you think it's OK to add more experimental modules.

AWS Service Broker Services
Corresponding Azure   Service
Is Provided by OSBA

Amazon Athena
Azure   Data Lake Analytics
No

Amazon DynamoDB
Azure Cosmos DB
Yes

Amazon ElastiCache
Azure   Redis Cache
Yes

Amazon EMR
HDInsight
No

Amazon Kinesis Data Streams
Event Hubs
Yes

Amazon KMS
Key   Vault
Yes

Amazon Lex
Bing   Speech API
No

Amazon Polly
Bing   Speech API
No

Amazon RDS for MariaDB
Azure Database for MariaDB (preview)
No

Amazon RDS for MySQL
Azure   Database for MySQL
Yes

Amazon RDS for PostgreSQL
Azure Database for PostgreSQL
Yes

Amazon Redshift
SQL   Data Warehouse
No

Amazon Rekognition
Computer   Vision API
No

Amazon Route 53
Azure   DNS & Traffic   Manager
No

Amazon S3
Azure Storage—Block Blob (for   content logs, files) (Standard—Hot)
Yes

Amazon SNS & SQS
Azure Service   Bus
Yes

Amazon Translate
Translator   Text
No

Hi @rgardler , thanks for the suggestion. Going to close this issue and reopen it once more modules are required by our customers.

I've been asked about support for Azure PostgreSQL version 10.
Also Azure Private DNS would definitely be useful, especially since GA is looming.  This would be useful in our scenario where we could map a DNS entry to the IP of the AKS service ILB IP address.

Azure for MariaDB: I am not sure how hard can it be, but considering that at the driver level they are very similar, it should be "easy" to get support for Azure for MariaDB, maybe as a fork of the current MySQL stuff.
I don't know enough to provide patches, but in any other software projects I have been involved (including migration from dedicated, in house mysql servers to AWS RDS MariaDB instances) it's been been just a change in the connection string. I can imagine that the housekeeping tasks might be different, and Azure is not perfectly symmetrical. But still, if should be easy, right?
Very interested in this. Thank you very much for your work!


SIG_MTG: hormone signaling and hormone receptor signaling

We've got some separate terms in signaling for both hormones and their receptors:
steroid hormone mediated signaling pathway ; GO:0043401
steroid hormone receptor signaling pathway ; GO:0030518
glucocorticoid mediated signaling pathway ; GO:0043402
glucocorticoid receptor signaling pathway ; GO:0042921
Do we really want both? I assume they're to fit in with the grouping terms:
hormone-mediated signaling pathway ; GO:0009755
intracellular receptor-mediated signaling pathway ; GO:0030522
Should they at least be linked? (at the moment, they're just linked because they share their receptor activity children)
Becky
Reported by: rebeccafoulger
Original Ticket: geneontology/ontology-requests/7228

steroid hormone receptor signaling pathway ; GO:0030518 has been changed to 'intracellular steroid hormone receptor signaling pathway'.  Apparently some steroid hormone receptors are in the PM.  I've manually made the  'mediated by' class a parent of this (would be good to formalise more, but no time).
Ditto corticosteroid term.
Note: children of 'intracellular steroid hormone receptor signaling pathway' need to be reviewed.  Should an intracellular variant be added.  Should def be made clearer?