new option to wrap manifest in script tags to reduce template logic

Added a new option so that you can have the manifest wrapped in a script tag.
This allows you to reduce the logic in the html template from
<% if(htmlWebpackPlugin.files.webpackManifest){ %>
<script>
    <%=htmlWebpackPlugin.files.webpackManifest%>
</script>
<% } %>

to just
<%=htmlWebpackPlugin.files.webpackManifest%>

I have set the default to false so it's not a breaking change.
If you do not want this option in your library, feel free to close this pull request.

@michael-wolfenden Thanks, that's a good idea. I'd like to make this as default behavior in the next version and eliminate the option.


Protect main branch in court-calendars repo

🍦 Feature Request 🍦
Current Behavior
Any user with access to court-calendars can write to the main branch (i.e. our database).
Desired Updates/Changes
Restrict access to court-calendars main branch such that only a courtbot-vt (bot) github account can write.  This is probably dependent on https://github.com/codeforbtv/courtbot-vt/issues/3.

I don't think this is relevant any more now that we're not using the GitHub "Court-Calendars" repo as our "database."


The numbers seem incorrect from heapster v1.0.0

I'm running heapster v1.0.0 with grafana v2.6.0-2, but the numbers I got seems incorrect:

The memory should be 2G for the machine, but the limit is only 600M and the usage is over 600M as well.
It seems that there are problems about monitoring the containers' filesystem:
This container runs an algorithm that writes to disk, however, the grafana shows 0 fs usage for that container:

But the number on the node is correct:

Any idea/suggestion about this problem? Could that be caused by the version of k8s? I'm running k8s v1.1

Limit is the sum of memory explicitly asked by your pods in the Limit section of container resources.
In the same way Request is the sum of memory explicitely asked by you pods in Request section. If you don't specify limit but only request then request sum can be higher than limit.
Adding @vishh to handle filesystem metric question.

Is this data for a pod or a container? Limits and Requests are per container.
As for filesystem metrics, what is your node configuration? We don't support device mapper docker storage driver as of now.

@mwielgus  Thanks, that makes much more sense.
@vishh  It should be the problem that device  mapper is not counted now. The code writes the disk in the container but the pod is not mounted on any hostpath. Is there any plan to support the device mapper storage in near future?

https://github.com/google/cadvisor/issues/959

Thanks for the pointer.it seems that heapster v0.19.0 worked correctly on getting those numbers, I'm curious is there anything dramatically changed for v1.0.0?

For what numbers?

The disk usage for containers

We haven't changed disk usage semantics since the last release.


Discovery: Branch rollback

The ability to "reset" a branch to a previous state referenced by a commit or tag on that branch.
Today this is possible by performing a branch "revert" command and providing all references leading up to the desired commit.
Another existing alternative is creating a new branch using the desired commit as source reference.
The purpose of this issue is to understand the user use cases for this operation and suggest an "atomic" operation for that.

Ideally we could phrase this as the Git operation.  I believe that this is the same as git reset --hard <ref>?

Ideally we could phrase this as the Git operation. I believe that this is the same as git reset --hard <ref>?

Yes, I tried to refrain from using the comparison to the git reset command as our reset behaves a bit differently than git

Closing in favour of continuing the discussion in #2343


Many changes

Rename shared
Merge some bash scripts
Expand README, including remove mention of Metadata Extractor
Make wordcloud and interactive table generation more generic
Generate tools.html and tutorials.html - Fix #129
Add index.html embeding tools.html and tutorials.html

Nice, the tests work as well !


Minify JavaScript assets

Problem
Following the lead of the most recent Narrative Shopify theme, we are making the change to minify all of the JavaScript files that we load into layout/theme.liquid.  However, in most cases, I strongly feel like the original, un-minified JavaScript file should be preserved for merchant's developers.

src/scripts/theme.js -->

dist/assets/theme.min.js (used in layout/theme.liquid)
dist/assets/theme.js (original preserved)

Scope
It is possible to update the task for build-js.js to still set the original file's destination, uglify the script, and use the existing gulp-ext-replace plugin to modify the extension to .min.js.  The update also introduces gulp-ignore to add a condition checking for .js, not .js.liquid, files to uglify.
function processThemeJs() {
  messages.logProcessFiles('build:js');
  return gulp.src([config.roots.js, `!${config.roots.vendorJs}`])
    .pipe(plumber(utils.errorHandler))
    .pipe(include())
    .pipe(gulp.dest(config.dist.assets))
    .pipe(ignore.include('**/*.js'))
    .pipe(uglify({
      mangle: true,
      compress: true,
    }))
    .pipe(extReplace('.min.js', '.js'))
    .pipe(gulp.dest(config.dist.assets));
}

More Information
I have a working version of this forked at https://github.com/stylehatch/slate-tools.  Unless I'm missing something in the NPM package's install process, I had to manually build using npm run prepublish before pushing to GitHub.
To test I have been using the following in the theme's package.json file:
{
  "name": "Theme",
  "version": "1.0.0",
  "devDependencies": {
    "@shopify/slate-tools": "https://github.com/stylehatch/slate-tools/tarball/073ce14e6ba65f65dc8e19a8ec91bfdba0c4b3df"
  }
}

I totally agree. I used the "Narrative" theme as a starting point to try to build a new theme and stuck with the theme.min.js file. I don't want to completely remove it but also it makes the site heavier; therefore it would be great to see what it does.

However, in most cases, I strongly feel like the original, un-minified JavaScript file should be preserved for merchant's developers.

This is something we've discussed on the Themes team as well.  Uploading both a *.js and *.min.js file in the theme assets was debated, but ultimately we decided not to do it as we weren't convinced it was a workflow to encourage.  One where you edit the .js file, then minify it in a separate process, then replace the existing min.js with this new file isn't something we wanted to introduce as a new practice in themes.
Having both files would indeed be useful to developers who could intuit why there was both a *.js and *.min.js, but it risked being confusing for anyone else.  And explaining the workflow wasn't something we were going to go all in on and publicly document as "the new way themes at Shopify work".
So at this time, what you're proposing isn't something we'd introduce to the Slate build process.  However, being able to have more control over what Slate does at different stages of the build process is something that is being requested - so this falls under that category.

I had to manually build using npm run prepublish before pushing to GitHub.

@jonathanmoore That command is run automatically in our own repo with the Circle CI integration.
You can see the line here. https://github.com/stylehatch/slate-tools/blob/master/circle.yml#L7
If you don't plan on setting up CI testing in your own repo, you could have those same prepublish commands run at a different time - like hooked into your package's version scripts or part of your git commit flow.

Do you guys have a rough ETA for pre/post build tasks? Like many others, I want to be able to use autoprefixer and minify theme.js, but the team I'm working with would prefer not to use a forked slate-tools (they don't want friction when upgrading slate). Any info would be great!

No ETA at this time; we're still talking internally about what the evolution of Slate-tools should look like.
@levymetal as an informal survey, would mind expanding on why you wouldn't want to use your own forked version?  What type of concerns come to mind when you think about riling your own build system?

@NathanPJF Personally I'm fine with forking slate-tools, but I work with a lot of different teams on different projects and one of them has expressed concerns about the friction a forked version of slate-tools would add to the upgrade process. They want to stay on the edge and keep Slate up to date when new features are released, but a forked slate-tools could make it harder for them to upgrade. This isn't my decision, so for this project I have to stay on the safe side and use Slate as-is.
I feel that most people are only going to want to change the css and js tasks. For example, these are the things I want to do:

Minify JS
Use gulp-autoprefixer
Compile SCSS locally for two reasons:

Receive SCSS compilation errors in real-time. I could be wrong but it doesn't seem possible to see compilation errors even within the Shopify console, which makes it really hard to pinpoint errors (which I encountered due to the next point)
Use the latest version of Sass. Shopify's Sass is so old it doesn't support things like &__elem {}, or even its predecessor @at-root #{&}__elem {}, let alone any of the other new features that have been added since 2013. When you're used to working with the latest version, it's really hard to revert to a 4 year old version of the same tool

From what I've read on this repo and the Slate repo, most people are looking to do some variation of the above, but rarely want to modify anything else within Slate tools. So even if there was a way to override just the processCss() and processThemeJs() functions locally within the theme, that would be super handy.
In my own projects I'd happily fork slate-tools to deal with these things, but I don't feel I'm the only person who would want to see SCSS compilation errors or use the latest version of Sass. IMHO these should be part of the default build process, I understand there's a reason for pushing SCSS compilation onto Shopify, but when it seriously affects the flow and speed of development, it might not be worth it.

@levymetal Thank you for taking the time to write all that up.  As you said, some of these items have already been brought in other threads; but I've definitely relayed your thoughts with the rest of the team.

This issue has been moved to https://github.com/Shopify/slate/issues/232

To view SCSS errors in shopify. Try to customize your theme in the Admin, you will see a log of the scss error.


Don't comment about logs on just submitted sync PR

Fixes packit/packit#2230
RELEASE NOTES BEGIN
We have adjusted commenting behaviour regarding Packit logs on release syncing PRs.
RELEASE NOTES END

Thank you.


[RESOLVED] High ICMP ping response time

Problem started at 08:41:30 on 2023.08.22
Problem name: High ICMP ping response time
Host: HP_iLO
Severity: Warning
Operational data: Value: 789ms
Original problem ID: 86414
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23268&eventid=86414

Problem has been resolved in 7m 59s at 08:49:29 on 2023.08.22
Problem name: High ICMP ping response time
Host: HP_iLO
Severity: Warning
Original problem ID: 86414


Support loading CAN message definition files of arbitrary types

Changed mechanism for adding message definitions from additional files to support arbitrary file formats.

A general question: I see a lot of logging statements that do not use the logging functions' lazy initialization but instead use String formatting to create the log message which is then passed to the logging function. Is that by intention? The linter also seems to be concerned about this and thus I wonder if I am missing something ...

We discussed this at some time - if the use of f-strings like f"Received value {value}" is something we would tolerate or not. At that time the conclusion was that it likely isn't a performance problem so we can continue to use it. I have no problem with "forbidding" it. I guess that in most cases it is easy to refactor the log-statements, but that some work might be needed in other cases as maybe not everything written inside a f"{...}" easily could be replaced by a %s or similar.
(@SebastianSchildt - this is maybe a topic that we shall revisit as part of moving repos to our new orga. Do we need a common repo "kuksa-common" where we specify style/deign-decisions that shall be shared, like max line length, if f-strings in logs should be allowed and so on).

I have no problem with "forbidding" it. I guess that in most cases it is easy to refactor the log-statements, but that some work might be needed in other cases as maybe not everything written inside a f"{...}" easily could be replaced by a %s or similar.

If we agree that the other approach is the more desirable one, then we could refactor all occurrences at least in files/places that we are touching in the context of a PR ...


fix typo in README for Docker

Thanks your PR!
But please re-PR to develop branch.

https://github.com/gogits/gogs/pull/1778


Enhance contact form

@Puskar-Roy
I would like to make contact form to align with the website styling
Kindly assign this issue to me

Hey @AswaniBolisetti👋! Thanks for raising this issue and demonstrating your interest in contributing to our project!🚀
We value your engagement and eagerly anticipate your contributions. Should you wish to get involved, please use the /assignme command to self-assign the issue.
This issue provides an excellent opportunity for us to enhance our project, and we're excited to have you join us! Please take a moment to review our CONTRIBUTING GUIDELINES before getting started.
If you have any questions or need assistance, feel free to reach out to us on LinkedIn.❤

/assignme


Add dither option to paint as LinearGradient is banding colors

Description
When rendering a LinearGradient on the whole screen on a Pixel 4 Phone and on the latest iPhone I can see visible color banding like this:

A snack can be found here: https://snack.expo.dev/@domir/error-skia-gradient
It's not there for react-native-svg (at least on iOS I cannot see any color banding) so I've dug into the skia code base and it has a dither option we can enable, which potentially renders better results.
I'll open a PR with my attempt to add a dither prop, but it does not work yet. Maybe you can have a look  🙏

@DomiR Thank you for contributing this cool feature 🙏


Invalid function reference in the documentation

I found one invalid function call reference while using the documentation to test with Ethers.

Ethers.Contract.call() is not available under the module Ethers.Contract, instead, its available under module Ethers.
So, what can be the solution here? Just fix the documentation or add Ethers.Contract.call() function by delegating it to Ethers.call()?  I can make the pull request with the suggested solution. @alisinabh

Hey @masudme09,
Great catch! I believe we should fix the documentation. As you guessed Ethers.Contract.call/2 is now history and replaced with Ethers.call/2.
A PR is very welcome!

Added a PR with small convenience texts.
https://github.com/alisinabh/elixir_ethers/pull/62


fix for #819 - use shortest distance from mouse position to zone top left corner when selecting a zone

Fix for #819

Looks like there are multiple related bugs

PR Checklist

[] Applies to #xxx
[] CLA signed. If not, go over here and sign the CLA
[] Tests added/passed
[] Requires documentation to be updated
[] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

I've tested this change with many zone configurations including configurations where there were issues with the previous logic

Also fix for #475

Hi @yodurr
the current logic to activate the smaller zone was adopted to cover cases like this one:

when two zones overlap and the smaller zone happens to be after the larger zone in the zone list.
It's a pretty common case, considered you may have overlapping zones on the top of the screen
Your change doesn't handle this case.
I agree we have to improve the current logic but not dropping support for scenarios that are currently supported.
Users are also asking to facilitate how zones are activated to avoid using a key modifier but preventing to activate the entire zone if not desired (see https://github.com/microsoft/PowerToys/issues/1005).
We should come up with some new design/logic to cover all these cases.

The stuff is hard, we also need a way to activate the big zone, when the small ones cover it completely:

I initially changed the logic to use the closest top left corner but then felt that just the top was sufficient.  I can go back to making this change to use the closest top left corner of zones that include the mouse position.  Would that seem sufficiently better and not a feature regression?
Also I apologize I should've made the opacity setting change in a different branch - will move that out.

Would that seem sufficiently better and not a feature regression?

That would still cause a feature regression since two zones may have the top left corner perfectly overlapping.
Honestly I don't have a simple solution for covering all the cases, but I haven't spend too much time trying to find one.

We need real world use cases to drive these decisions or I fear we're over-engineering.
Why would someone have two zones with perfectly aligned top left corners and one zone completely covering the other?  How is that useful?
I think for most people updating the logic from "smallest region wins" to closest top left corner is going to be an improvement.

The introduction of the "smallest region wins" logic was a community contribution supported by users that had real world use case.
Having one smaller zone covered completely by a larger zone is also a workaround for a missing feature that several users asked for (and that at point point we will add): the ability to snap a window to two adjacent zones.
The users want to have two adjacent zones and the ability to snap to each of them individually or together. In order to achieve that now, they need to have zones covering each other left corner perfectly.
Given we know that there are users currently relying on this feature to work, I suggest we don't make a change that would break their workflow.
I would rather add an option in the FZ settings to switch to the "closest top left corner wins" if desired.

We could have a mix of both:

if the mouse is in the top - let's say - 96px of a zone, activate that zone
if it is in the top of more than one zone, activate the bigger one
otherwise, keep current logic and activate the smaller one

This should cover all cases.

I proposed a solution on the base issue on #819.  Without having a link issue that @enricogior said was the community voted solution, it is a bit unclear why smallest wins.
However, i did fine another issue, #1046 which is a bug on how the shift overlay renders.

it is a bit unclear why smallest wins

It was a community contribution based on real user needs. It's not uncommon that a smaller zone can be fully covered by a larger zone.
Asking the user to create the zones in a specific order to give them priority seems an unnecessary complication and it doesn't solve all the possible cases, for example: two smaller zones perfectly cover a larger zone. Whatever order you choose, it will always leave at least one zone unreachable.
Also, if we want to give priority based on creation order we first need to improve the editor to actually show the priority and also allow to change priority without having to delete and recreate the zones.
I suggest to not make this approach the default unless we add a settings option to choose a different one.
I suggest to consider @bzoz approach of using different logic based on the relative position of the cursor. I'm not sure it will fix all the cases but it's an interesting proposal that we should try to verify how good is in practice (is it intuitive? is it covering all the known cases?).


Update kittens to 2.0.0

Updates org.typelevel:kittens from 2.0.0-M1 to 2.0.0.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "kittens" } ]

labels: semver-pre-release

Codecov Report

Merging #140 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   61.19%   61.28%   +0.08%
==========================================
  Files          36       36
  Lines        1201     1201
  Branches       12        5       -7
==========================================
+ Hits          735      736       +1
+ Misses        466      465       -1

Impacted Files
Coverage Δ

core/src/main/scala/laserdisc/protocol/KeyP.scala
92.68% <0%> (+1.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bccc5a7...b57b069. Read the comment docs.


include splitting of the carbon budget and calculate the cumulative cost for the myopic approach

This pull request:

changes column name in powerplants database from "YearCommissioned" to "DateIn", solving issue 85

proposes a quick fix for issue 79

For the myopic option, given a carbon budget, distributes it across the planning_horizons following an exponential or beta decay.

A file with CO2 limit in every planning horizon and a plot showing historical and planned CO2 emissions are saved in the results
This pr requires updating to UNFCCC_v23.csv in the data bundle (because emissions in 2018, which are assumed to remain constant in 2019  and 2020, and subtracted from the carbon budget)

Creates an additional file in results/csvs including the cumulative costs with different social discount rate.
We could also include the social discount rate in the config file, but I think keeping the results with various discount rates forces
the user to think about the implications of this assumption.

Allow specifying an option to alter the capital cost of carriers by a factor indicated in the config file, eg: solar+c0.5

Hi @martavp thanks for implementing these features! Looks mostly good to me, see comments above. Particularly the plotting should be separated or called in a separate function. Perhaps the script can output a CSV, which is then plotted in a separate script? It would be good to unify the ways of modifying p_nom_max and the capital cost.

Hi @martavp thanks for implementing these features! Looks mostly good to me, see comments above. Particularly the plotting should be separated or called in a separate function. Perhaps the script can output a CSV, which is then plotted in a separate script? It would be good to unify the ways of modifying p_nom_max and the capital cost.

It would in general be better, if possible, to split these different changes into different pull requests, although I know this is difficult and creates lots of extra branches, but it's easier to review and comprehend afterwards.

It would in general be better, if possible, to split these different changes into different pull requests, although I know this is difficult and creates lots of extra branches, but it's easier to review and comprehend afterwards.

Thanks, @nworbmot. I mostly agree with your comments. I will take care of implemented the requested changes in the following days.

Thanks, @nworbmot. I mostly agree with your comments. I will take care of implemented the requested changes in the following days.

This pull request has been split in three
https://github.com/PyPSA/pypsa-eur-sec/pull/88
https://github.com/PyPSA/pypsa-eur-sec/pull/89
https://github.com/PyPSA/pypsa-eur-sec/pull/90

This pull request has been split in three
https://github.com/PyPSA/pypsa-eur-sec/pull/88
https://github.com/PyPSA/pypsa-eur-sec/pull/89
https://github.com/PyPSA/pypsa-eur-sec/pull/90

Thanks Marta! I didn't mean to cause you extra work to split it up this time, only next time, but thanks it's very helpful!

Thanks Marta! I didn't mean to cause you extra work to split it up this time, only next time, but thanks it's very helpful!

No worries. I prefer to keep it tidy already this time.

No worries. I prefer to keep it tidy already this time.


feat(v1): disable diff/merge op for moby builder

fix #1693

This will disable diff/merge op if it's using the moby builder.
Other changes:

fix the config.jupyter in v1
fix installing multiple languages

previous it will omit python since it's not added to the packs

TBD:

Should we use moby by default?

cc @gaocegege @pingsutw

@kemingy thanks, let me test it first, I'll get back to you.


Update golang version to 1.23 in SLO Dockerfile

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.39%. Comparing base (02fe5c3) to head (284004d).

:exclamation:  There is a different number of reports uploaded between BASE (02fe5c3) and HEAD (284004d). Click for more details.
HEAD has 327 uploads less than BASE

Flag
BASE (02fe5c3)
HEAD (284004d)

macOS
18
0

unit
54
1

go-1.21.x
30
1

go-1.23.x
36
0

go-1.22.x
30
0

ubuntu
60
1

ydb-24.1
18
0

integration
36
0

ydb-23.3
18
0

windows
18
0

ydb-nightly
6
0

experiment
6
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1439       +/-   ##
===========================================
- Coverage   67.35%   42.39%   -24.96%
===========================================
  Files         350      295       -55
  Lines       36515    26790     -9725
===========================================
- Hits        24595    11358    -13237
- Misses      10825    14950     +4125
+ Partials     1095      482      -613

Flag
Coverage Δ

experiment
?

go-1.21.x
42.39% <ø> (-25.26%)
:arrow_down:

go-1.22.x
?

go-1.23.x
?

integration
?

macOS
?

ubuntu
42.39% <ø> (-29.26%)
:arrow_down:

unit
42.39% <ø> (+0.89%)
:arrow_up:

windows
?

ydb-23.3
?

ydb-24.1
?

ydb-nightly
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Event/Trigger (Mutation/Signal) Mapper

Describe the problem
Tying events to mutations will address 85% or more of events, provided the payload can contain all of the relevant data. This tool systematically identifies new mutations, permit the admin to assign a mutation to one or more events, permit the admin to map mutation payload items to event attributes, including transformations of the data as necessary.
Describe the solution
The event_events_triggers and event_triggers tables identify and tie events and triggers together. To begin with, triggers will be primarily mutations. Others may be added in the future, and events may be invoked outside of the mutations framework as necessary.
CREATE TABLE public.event_triggers
(
    id serial NOT NULL,
    name character varying,
    type_t character varying,
    payload jsonb,
    "ignore" boolean DEFAULT false,
    "count" bigint,
    created_at timestamp with time zone DEFAULT NOW(),
    updated_at timestamp with time zone DEFAULT NOW(),
    invalidated_at timestamp with time zone,
    PRIMARY KEY (id),
    UNIQUE (name)
);
CREATE TRIGGER set_timestamp_event_triggers BEFORE UPDATE ON event_triggers FOR EACH ROW EXECUTE PROCEDURE trigger_set_timestamp();

CREATE INDEX event_triggers_name_index ON public.event_triggers USING BTREE (name);
CREATE INDEX event_triggers_type_t_index ON public.event_triggers USING BTREE (type_t);

COMMENT ON COLUMN public.event_triggers.id IS 'This table identifies all unique mutations that occur. The event_events_triggers table ties events and triggers together. To begin with, triggers will be primarily mutations. Others may be added in the future, and events may be invoked outside of the mutations framework as necessary.';

COMMENT ON COLUMN public.event_triggers.name IS 'Name of the mutation. This column is unique. Every time a new mutation is called, it is added to this table. Once in this table for the first time, it appears on the Event Triggers tool in Admin with a status of Unassigned.';

COMMENT ON COLUMN public.event_triggers.type_t IS 'Translated type of trigger. To begin with, it is anticipated that the type will always be Mutation. This field will tell the system where to look for the trigger.';

COMMENT ON COLUMN public.event_triggers.payload IS 'jsonb payload of ten recent, random payloads of this trigger. These payload examples will let the Map Trigger to Event to test the proposed Map against real data to see example outcomes before committing to production.';

COMMENT ON COLUMN public.event_triggers.ignore IS 'boolean indicating whether to ignore the trigger. If true, then no event will be instantiated when the trigger occurs, and the Event Triggers status will be set to Ignore.';

COMMENT ON COLUMN public.event_triggers.count IS 'An incrementing integer counting the times that a trigger is called. This number helps the admin quickly see which triggers are being used often (and therefore will yield the most event data) versus those that are rarely called, and may not be a high priority.';

COMMENT ON COLUMN public.event_triggers.created_at IS 'Timestamp when the trigger was first called. Note: There is no created_by, because users do not actually create triggers or mutations. Users simply call them';

COMMENT ON COLUMN public.event_triggers.updated_at IS 'Timestamp when the trigger was last updated (e.g most likely when it was last called, and the count increments up and the payload is replaced). Note: There is no updated_by because users do not update mutations or triggers. Users simply call triggers.';

COMMENT ON COLUMN public.event_triggers.invalidated_at IS 'Timestamp when the trigger was invalidated. Because mutations and triggers are created automatically by the system, it would be extremely rare to invalidate one. Even if the trigger falls out of favor, is no longer used, or is replaced by another trigger, it should not be invalidated so long as some events are tied to it.';

CREATE TABLE public.event_events_triggers
(
    id serial NOT NULL,
    trigger_id integer,
    event_id integer,
    map jsonb,
    is_active boolean DEFAULT true,
    created_by integer,
    created_at timestamp with time zone DEFAULT NOW(),
    updated_by integer,
    updated_at timestamp with time zone DEFAULT NOW(),
    invalidated_at timestamp with time zone,
    PRIMARY KEY (id),
    CONSTRAINT trigger_id_fkey FOREIGN KEY (trigger_id)
        REFERENCES public.event_triggers (id) MATCH SIMPLE
        ON UPDATE NO ACTION
        ON DELETE NO ACTION
        NOT VALID,
    CONSTRAINT event_id_fkey FOREIGN KEY (event_id)
        REFERENCES public.event_events_new (id) MATCH SIMPLE
        ON UPDATE NO ACTION
        ON DELETE NO ACTION
        NOT VALID,
    CONSTRAINT created_by_fkey FOREIGN KEY (created_by)
        REFERENCES public.user_users (id) MATCH SIMPLE
        ON UPDATE NO ACTION
        ON DELETE NO ACTION
        NOT VALID,
    CONSTRAINT updated_by_fkey FOREIGN KEY (updated_by)
        REFERENCES public.user_users (id) MATCH SIMPLE
        ON UPDATE NO ACTION
        ON DELETE NO ACTION
        NOT VALID
);

CREATE TRIGGER set_timestamp_event_events_triggers BEFORE UPDATE ON event_events_triggers FOR EACH ROW EXECUTE PROCEDURE trigger_set_timestamp();

CREATE INDEX event_events_triggers_event_id_index ON public.event_events_triggers USING BTREE (event_id);
CREATE INDEX event_events_triggers_trigger_id_index ON public.event_events_triggers USING BTREE (trigger_id);
CREATE INDEX event_events_triggers_created_by_index ON public.event_events_triggers USING BTREE (created_by);
CREATE INDEX event_events_triggers_updated_by_index ON public.event_events_triggers USING BTREE (updated_by);

COMMENT ON COLUMN public.event_events_triggers.id IS 'This table identifies the events that are called for each trigger or mutation, and also defines how the payload variables are mapped and transformed to the required event attributes.';

COMMENT ON COLUMN public.event_events_triggers.trigger_id IS 'Foreign key to event_triggers.id. This is the trigger that is joined to the event in event_id.';

COMMENT ON COLUMN public.event_events_triggers.event_id IS 'Foreign key to event_events(_new).id. This is the event that is called whenever the trigger or mutation is instantiated.';

COMMENT ON COLUMN public.event_events_triggers.map IS 'jsonb object that maps payload objects to event objects and attributes. Note: This jsonb object also contains any transformations, if-then statements, or special conditions necessary to make map the trigger to the event.';

COMMENT ON COLUMN public.event_events_triggers.is_active IS 'boolean indicating whether the trigger mapping is active. This is used when the mapping is incomplete, and we do not want to start collecting half-baked data. Note: This is different from invalidated_at. A non-null invalidated_at value indicates that the mapping is completely deleted. The status of the trigger becomes Unassigned and may be re-mapped with a new mapping. A true value in is_active is used for a status of Incomplete or Inactive (but Complete).';

COMMENT ON COLUMN public.event_events_triggers.created_by IS 'user.id of the user who mapped the trigger to the event. This will always be an administrator.';

COMMENT ON COLUMN public.event_events_triggers.created_at IS 'Timestamp when the trigger or mutation was mapped to an event.';

COMMENT ON COLUMN public.event_events_triggers.updated_by IS 'user.id of the user who last updated the mapping between the trigger and event.';

COMMENT ON COLUMN public.event_events_triggers.updated_at IS 'Timestamp when the map between the trigger and event was last updated.';

COMMENT ON COLUMN public.event_events_triggers.invalidated_at IS 'Timestamp indicating when the mapping was invalidated or deleted. A non-null value invalidates the row, and the status of the trigger becomes Unassigned and may be re-mapped with a new mapping.';

Additional context and instructions
UI Designs:

@BradenM I added initial UI designs to this, once you're able to finish with calldowns.

@aarontitus Awesome, thanks.
This thing is going to rock! :rocket:

Re-evaluate in light of the Events table and model.


update director to new drake

Pairs with https://github.com/mitdrc/drc/pull/2142/files
Currently this compiles but fails at run time.
The major problem is that KinematicsCache separates the result of doKinematics() from the RBM.
I couldn't resolve how to pass the cache around with RBM object.
These two methods have problems:
URDFRigidBodyManipulatorVTK::getLinkToWorld
ddDrakeWrapper::resolveCenterOfPressure

@patmarion : feel free to rewrite this PR. I'm not happy with it and it does work at run time.

I got the drake-designer to compile and load correctly.  Next up, we have to fix the matlab code in the IK server.  Besides the new KinectmaticsCache, there was also a change to coordinate frame access.  This is the first error message printed when starting the IK matlab server:
You cannot get the 'coordinates' property of 'CoordinateFrame'.

Error in IKServer/addRobot (line 142)
      obj.plan_publisher = RobotPlanPublisherWKeyFrames('CANDIDATE_MANIP_PLAN',
      true, obj.robot.getPositionFrame.coordinates);

I also found a strange import error when importing iris.  I was able to work around the error by importing iris before any other module.  The error was:
File "/home/pat/source/drc/drc/software/build/lib/python2.7/dist-packages/ddapp/irisUtils.py", line 4, in
from irispy.utils import lcon_to_vert
File "/home/pat/source/drc/drc/software/build/lib/python2.7/dist-packages/irispy/init.py", line 1, in
from irispy import Polyhedron, Ellipsoid, IRISRegion, IRISOptions, IRISProblem, inflate_region, c_inflate_region
File "/home/pat/source/drc/drc/software/build/lib/python2.7/dist-packages/irispy/irispy.py", line 1, in
from iris_wrapper import IRISOptions, IRISRegion, IRISProblem, IRISDebugData, Ellipsoid, Polyhedron
File "/home/pat/source/drc/drc/software/build/lib/python2.7/dist-packages/irispy/iris_wrapper.py", line 28, in
_iris_wrapper = swig_import_helper()
File "/home/pat/source/drc/drc/software/build/lib/python2.7/dist-packages/irispy/iris_wrapper.py", line 24, in swig_import_helper
_mod = imp.load_module('_iris_wrapper', fp, pathname, description)
ImportError: dlopen: cannot load any more object with static TLS

I updated the drc branch to point to my new commits here, btw.  I force pushed over your branch mitdrc/mfallon-update-drake

coordinates has been made private in the CoordinateFrame class.
You can use getCoordinateNames()

Note, there is also a potential bug in the generation of drake lcmtypes.  If you use lcm v1.0, you won't have the bug.  But I do have the bug in lcm 1.2.  I have reported it here, with a work around:
https://github.com/RobotLocomotion/drake/issues/1425

Do you want to had this back to me to look at the IK server?

Pushed new commits.  I made fixes to the coordinates api and now the matlab code is running.  I tested IK planning in the director, footstep and walk planning, and ran the walking simulation in simul_v5.pmd.
I did not go through all matlab files in src/control to fix the coordinate names api change, I only touched the files we used while running Atlas.
I have not tested that matlab code in the collision free planner yet.

Great! I checked the collision free planning code before running the test scripts in src/matlab
what's left to check?

Happy to merge now and fix things as they are discovered.
On Thursday, October 15, 2015, Maurice Fallon<EMAIL_ADDRESS>wrote:

Great! I checked the collision free planning code before running the test
scripts in src/matlab
what's left to check?
—
Reply to this email directly or view it on GitHub
https://github.com/RobotLocomotion/director/pull/85#issuecomment-148536516
.


cks: use public links for templates and binaries iso for smoke tests

Description
Use public links for templates and binaries iso for CKS smoke tests

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@andrijapanicsb if we get this to work before release, i'd like it in so we have a clean run from trillian.

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-1089

Packaging result: ✔centos7 ✔debian. JID-1092

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-1316)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29197 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1316-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 74 look OK, 3 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_UpdateConfigParamWithScope
Error
0.07
test_global_settings.py

test_02_vpc_privategw_static_routes
Failure
153.73
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
133.46
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
173.20
test_privategw_acl.py

test_02_cancel_host_maintenace_with_migration_jobs
Failure
173.52
test_host_maintenance.py

Packaging result: ✔centos7 ✔debian. JID-1132

@blueorangutan test matrix

@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-1476)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30699 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1476-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_delete_kubernetes_supported_version
Error
35.52
test_kubernetes_supported_versions.py

Trillian test result (tid-1475)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32589 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1475-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_delete_kubernetes_supported_version
Error
636.95
test_kubernetes_supported_versions.py

test_01_scale_vm
Failure
13.41
test_scale_vm.py

Trillian test result (tid-1477)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35575 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1477-vmware-67u3.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@shwstppr can you check those results? two platforms fail but the third passes the same test.

looking at the code i see a 1.16.0 mentioned but on the site it is missing. might that be the issue?
| Name | Last modified | Size | Description
-- | -- | -- | -- | --
  | Parent Directory |   | - |
  | setup-1.11.4.iso | 2020-01-14 11:52 | 1.0G |
  | setup-1.12.5.iso | 2020-01-14 11:54 | 1.0G |
  | setup-1.13.2.iso | 2020-01-14 11:55 | 927M |
  | setup-1.14.9.iso | 2020-01-14 11:57 | 1.0G |
  | setup-1.15.0.iso | 2020-01-14 12:00 | 1.0G |
  | setup-1.16.3.iso | 2020-01-14 12:01 | 1.0G |

I guess not, the error is in the other test file. Can you please look at this error as well and advice if this can independendly merged, @shwstppr ?

@DaanHoogland will look at the logs and will try to fix the issue in next hours or tomorrow morning

looking at the code i see a 1.16.0 mentioned but on the site it is missing. might that be the issue?
Name 	Last modified 	Size 	Description
Parent Directory 	  	-
setup-1.11.4.iso 	2020-01-14 11:52 	1.0G
setup-1.12.5.iso 	2020-01-14 11:54 	1.0G
setup-1.13.2.iso 	2020-01-14 11:55 	927M
setup-1.14.9.iso 	2020-01-14 11:57 	1.0G
setup-1.15.0.iso 	2020-01-14 12:00 	1.0G
setup-1.16.3.iso 	2020-01-14 12:01 	1.0G

@DaanHoogland yes 1.16.0 is missing and it is needed for testing upgrade on HA k8s cluster. I've internally asked for adding it at a public repo.

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔debian. JID-1202

@blueorangutan test matrix

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@DaanHoogland 1.16.0 ISO is yet not available on public repo. Plus tests might fail due to Trillian issues right now

@blueorangutan test matrix

@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan test matrix

@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-1492)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36895 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1492-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_delete_kubernetes_supported_version
Error
1206.82
test_kubernetes_supported_versions.py

test_01_scale_vm
Failure
27.75
test_scale_vm.py

Trillian test result (tid-1493)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37150 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1493-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_delete_kubernetes_supported_version
Error
1207.17
test_kubernetes_supported_versions.py

Trillian test result (tid-1494)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45133 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1494-vmware-67u3.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@blueorangutan test matrix

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔debian. JID-1206

@blueorangutan test matrix

@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-1496)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33488 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1496-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_scale_vm
Failure
20.46
test_scale_vm.py

Trillian test result (tid-1497)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35859 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1497-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-1498)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50547 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1498-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_delete_kubernetes_supported_version
Error
1807.22
test_kubernetes_supported_versions.py

@blueorangutan test centos7 vmware-67u3

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@PaulAngus @rhtyd @borisstoyanov @andrijapanicsb
Need your opinion on this. Since CKS tests need multiple k8s binaries ISOs (~1GB in size each) which makes tests to run for longer time for download (from the Internet) and install of these ISOs does it make sense to move CKS tests into component tests from smoke-tests?
Or any other way you can suggest to make this part of the tests more reliable, faster?
cc @DaanHoogland

@shwstppr does it take more than 0.5-1 hour to run the test, I would keep it in smoketest/
You can host the isos locally on staging server which is closer to the trillian env; make the url configure URL specific to the Trillian env via its test_data: https://github.com/shapeblue/Trillian/blob/master/Ansible/roles/marvin/templates/test_data.py.j2
The test_data (default) is here: https://github.com/apache/cloudstack/blob/master/tools/marvin/marvin/config/test_data.py

@rhtyd I don't agree either a run of more than 0.5 hour or a download of multiple 1GB files would justify not running it on every test run.
adding the URLs to test_data does certainly make sense though.

@shwstppr could we spoof the ISOs with smaller files and put those in a local webserver somewhere?

Trillian test result (tid-1499)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38500 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3992-t1499-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 81 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

LGTM, merge this @DaanHoogland @andrijapanicsb ?

@shwstppr can you please advise on the duration of these tests and can we also override the URLs the same way we do with i.e. systemVM templates or default centos templates, to be downloaded actually from our local web server - downloading from download.cloudstack is slow as hell

[root@ref-trl-902-k-M7-andrija-panic-mgmt1 ~]# wget http://download.cloudstack.org/cks/setup-1.14.9.iso
--2020-05-06 11:32:06--  http://download.cloudstack.org/cks/setup-1.14.9.iso
Resolving download.cloudstack.org (download.cloudstack.org)... <IP_ADDRESS>, 2a00:f10:121:400:403:9cff:fe00:37f
Connecting to download.cloudstack.org (download.cloudstack.org)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length:<PHONE_NUMBER> (1.0G) [application/x-iso9660-image]
Saving to: ‘setup-1.14.9.iso’
100%[=========================================================================>] 1,077,303,296 8.07MB/s   in 2m 8s
So for 5 x ISOs, that's 10min at least - could be worse I guess...

@andrijapanicsb I'll work for overriding URLs with local server URLs as Rohit suggested in next few days or over the weekend. Can be fixed in next release/after 4.14

sure @shwstppr - keep in mind we override inside Trillian code, not in the public git code here!
thx


$this->registerJs(<<<EOF loses IDE javascript formatting

Maybe we should integrate a new way to do this, like
registerJsStart() ?>
//Javascript code here
registerJsEnd() ?>

Use <<<JS in PhpStorm or move js to external files (better).

I need this to be in view file, am I missing something ?

works fine in phpstorm:

make sure to set inspection and highlighting level to maximum. Anyway not a yii issue.

you may have an external file and register its contents like $view->registerJs(file_get_contents('somefile.js'));

@cebe no please don't promote that.
`$view->registerJs($this->render('hellotest.js'));


Resizer Not Working for Portrait Photos

Microsoft PowerToys version
0.62.1
Running as admin

[X] Yes

Area(s) with issue?
Image Resizer
Steps to reproduce

✔ Expected Behavior
While resizing numerous portrait orientated photos I edited the presets to reflect the size I required, i.e. width: 3072 x Height: 4608. I then highlighted the required photos and selected the requisite size choice and clicked 'Resize'. Resizeing completed I then checked the metadata and found that Resizer had reversed the pixel sizes.
❌ Actual Behavior
On reviewing the photo size I found that Resizer had resized the photo to landscape and instead of Width: 3072 x Height: 4608 it inserted Width: 4608 x Height: 3072. Even using the 'Custom' option resizer insisted on reversing the figures and making the photo lanscape.
Other Software
No response

Hello and thanks for your message. A visible example would be very helpful here. With "reversed", do you mean the image is rotated or cropped? Also important to know the exact settings that are used for the resize action. Specifically the fit/fill/stretch one, and the checkbox "Ignore orientation of pictures".

Hello Jay,
Apologies for lack of screenshot or any illustrations, but needed to resize a large number of photos in a hurry and uninstalled power toys to install the original image resizer which works fine. However, in response to your questions:

Required width setting was entered as '3072' and the Height setting was entered as '4608'. However, when photo was resized, the Width was '4608' and the Height was '3072', essentially making the portrait photo landscape;
The fit/fill/stretch setting was set to 'Fill';
Orientation of pictures was checked initially, then  and unchecked, but this did not resolve the issue;
Tried several configurations, changing presets to my required settings, creating a new setting and using the 'custom' setting. None of which provided the required results and all produced the 'landscape' orientation.
As I mentioned above, have uninstalled power toys for the moment and have image resizer 3.1.2 installed which does what I want.

Regards.
John.

I think you might want to use the FIT setting.
Unchecking

[ ] Ignore orientation of pictures

should work, but apperently it doesn't?
CC @bricelam

Will give the 'fit' option a try when I reinstall. However, I was under the impression that the 'fit' option crops the image if it is larger than the specified dimensions? Not totally convinced that this would solve the programme identifying the width dimension as the height and the height as the width. As I mentioned, it works perfectly fine for landscape mode, just not those in portrait mode.
John.

Will give the 'fit' option a try when I reinstall. However, I was under the impression that the 'fit' option crops the image if it is larger than the specified dimensions? Not totally convinced that this would solve the programme identifying the width dimension as the height and the height as the width. As I mentioned, it works perfectly fine for landscape mode, just not those in portrait mode.
John.

Fit will not crop, Fill will

Possibly related to the very long discussion in https://github.com/bricelam/ImageResizer/issues/38

Read #38, and in some respects mirrors what I experienced in the Power Toys version of IR. I've tried using 'fill' and 'fit' to resize a portrait photo from 3456 x 4608 to 3072 x 4608, but using 'fill' it results in 4608 x 3072 - essentially reversing the width and height. If I use 'fit' a similar thing happens, but this time instead of 3072 x 4608 it produces 2304 x 3072. Doesn't appear to make any difference if 'ignore orientation' is checked or not. On the other hand, the stand alone Image Resizer 3.1.2 works perfectly fine in both landscape and portrait modes. Just don't understand why this should be. Anyway, will probably stick with the stand alone version should I need to resize other images.

Let me add example photo. This is 3023x4032 and when I try to resize it with options "Fits within 1920 x 1080 pixels" the resizer produces image 1080 x 1440, which obviously doesn't fit in the vertical goal of 1080. The result is same with or without selecting "Ignore the orientation of pictures". I am currently using Release v0.78.0


Update Recommended Articles links on main landing page

The links under Recommended Articles are missing stable/ in CockroachDB links and the CockroachCloud links are missing docs/, so all the links are breaking. For example:

Start a Cloud Cluster is /cockroachcloud/quickstart.html but should be /docs/cockroachcloud/quickstart.html
Start a Local Cluster is /docs/secure-a-cluster.html but should be /docs/stable/secure-a-cluster.html

Closing in favor of #9363

Closing in favor of #9363


⚠ gorzdrav.org has degraded performance

In f408545, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 4423 ms

Resolved: gorzdrav.org performance has improved in 405eed8.


fix: remove job logic and check if pod status is completed

Fixes #489
Removed job logic, moved the getReady below getPodStatus and check if status is completed.

:tada: This PR is included in version 1.2.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


do private domain e.g. proj.cloudly.. and swap the "Project Cloudly" header for the customer project name

nah


[Code Apps] add full tab view mode for code editor

Description
add full tab view mode for code editor
Use case/motivation
No response
Related issues
No response
Confidential information

[X] I confirm that do not share any confidential information

verified on staging, related issues created


I just want to know the acmg result and NGF of a certain mutation site

I just want to know the acmg result and NGF of A certain mutation site (such as chr1:115828756 G>A). How can I use intervar and what should I input

you can use wet intervar at wintervar.wglab.org
On Thu, Mar 23, 2023 at 11:58 PM Zzc79 @.***> wrote:

I just want to know the acmg result and NGF of A certain mutation site
(such as chr1:115828756 G>A). How can I use intervar and what should I input
—
Reply to this email directly, view it on GitHub
https://github.com/WGLab/InterVar/issues/89, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNG3OAICTSLZWUVHZWWNQTW5ULX5ANCNFSM6AAAAAAWGBQL2Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Please visit the web server of InterVar(http://wintervar.wglab.org/), then Query by genomic coordinate.


i8::MIN / -1 panics but verifies

The following function verifies with the condition that y != 0, but I believe it should not, since it can panic.
// Read more about `requires` here: https://hacspec.org/book/tutorial/panic-freedom.html
#[hax_lib::requires(y != 0)]
fn d(x: i8, y: i8) -> i8 {
    x / y
}

Open this code snippet in the playground
When calling this function with i8::MIN and -1 it overflows:
fn d(x: i8, y: i8) -> i8 {
    x / y
}

fn main() {
    println!("{}", d(i8::MIN, -1));
}

$ cargo run
   Compiling hax_repro v0.1.0 (/home/projects/dump/hax_repro)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.12s
     Running `target/debug/hax_repro`
thread 'main' panicked at src/main.rs:2:5:
attempt to divide with overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

(See also https://blog.regehr.org/archives/887 and https://mastodon.social/@regehr/113564124872096630 )

More direct repro:
#[allow(unconditional_panic)]

// Read more about `requires` here: https://hacspec.org/book/tutorial/panic-freedom.html
#[hax_lib::requires(true)]
fn d() -> i8 {
    (-128i8) / (-1i8)
}

Playground

I assume this condition would need to be updated?
https://github.com/hacspec/hax/blob/1c5e17c9ceee5adede0f4ea7f68bb3d8337f33a0/proof-libs/fstar/rust_primitives/Rust_primitives.Integers.fsti#L241

Correct: this function has an assume whereas it should have a pre-condition.
We have been working on a new version of the library model which does not
have these assumes, but we should fix this.
On Mon, Dec 2, 2024 at 2:28 PM ambiso @.***> wrote:

I assume this condition would need to be updated?
https://github.com/hacspec/hax/blob/1c5e17c9ceee5adede0f4ea7f68bb3d8337f33a0/proof-libs/fstar/rust_primitives/Rust_primitives.Integers.fsti#L241
—
Reply to this email directly, view it on GitHub
https://github.com/hacspec/hax/issues/1155#issuecomment-2511546999, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABFUVS3MZJVJQOCES5B7CKL2DROA5AVCNFSM6AAAAABS3MJ352VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJRGU2DMOJZHE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Too many workers

I am working on a remote development server using VSCode's Remote-SSH. This extension consumes the server's memory fairly rapidly, when I look at services running I seem 10s of  '/etc/php/8.2/cli/php.ini' '/vendor/bin/phpstan' 'worker' --configuration '/var/wwww/folder/phpstan.neon' --memory-limit='800M' --port 43171 --identifier iwnhtr3wd7 --, they keep multiplying until the server becomes unusable. The processes continue even after the connection is closed. New port numbers are generated for new workers.
Is there a way to limit the number of workers the extension can create?
Extension version: both stable and pre-release (currently have 3.0.6 installed).

Hi, what the extension does is that it basically just runs phpstan with your own config file and interprets the output. You might want to check out this section of the PHPStan docs, you can use that to limit the number of processes. You'll notice that if you run PHPStan by itself it'll do the exact same thing. Those processes you mention are PHPStan worker processes.
The processes indeed don't stop if the connection is closed, this is a bit of a limitation of VSCode where an extension doesn't get a "killed" event, with which I'd be able to kill the process. It also doesn't spawn the process under the VSCode process itself, meaning that if the VSCode server is killed, the process doesn't go down with it. Theoretically any open processes are killed when the extension starts again after disconnecting, since that's the first time it has control again.
Hope this helps, let me know if it doesn't

I guess I've proven myself to be one of those guys that don't read the docs. Thank you for very kindly pointing out where in it tells me how to fix my issue, I'm pretty sure you are right and setting the max processes should keep things under control for me.
And thanks for creating and maintaining a really good extension. 🔥

Haha no problem, and thanks for the kind words!


Support Xamarin.Android

I'm trying to use this library on Xamarin.Android but I think that the libwkhtmltox.so might not  be supported for the different ABIs of Android.
At least, I've tried with x86 (given that I'm trying on an emulator) and I can't get this to work.
I've added the android native reference to the library but it keeps throwing DLLNotFoundException pointing out to libwkhtmltox.
This is how my Android *.csproj android native library looks like:
<AndroidNativeLibrary Include="lib\x86\libwkhtmltox.so" />

Also tried to set the file as "Copy Always", but it didn't work.
Something that I think is worth noticing is that the application output shows:
[Mono] DllImport attempting to load: 'libwkhtmltox'.
[Mono] DllImport error loading library '/storage/emulated/0/Android/data/com.whatever.app/files/.__override__/libwkhtmltox': '(null)'.
[Mono] DllImport error loading library '/storage/emulated/0/Android/data/com.whatever.app/files/.__override__/libwkhtmltox.so': '(null)'.
[Mono] DllImport error loading library '/storage/emulated/0/Android/data/com.whatever.app/files/.__override__/libwkhtmltox.so': '(null)'.
[Mono] DllImport error loading library '/system/lib/libwkhtmltox': '(null)'.
[Mono] DllImport error loading library '/system/lib/libwkhtmltox.so': '(null)'.
[Mono] DllImport error loading library '/system/lib/libwkhtmltox.so': '(null)'.
[Mono] DllImport error loading library 'libwkhtmltox': '(null)'.
[Mono] DllImport error loading library 'libwkhtmltox.so': 'dlopen failed: library "libXrender.so.1" not found'.
[Mono] DllImport error loading library 'libwkhtmltox.so': 'dlopen failed: library "libXrender.so.1" not found'.
[Mono] DllImport error loading library 'libwkhtmltox': '(null)'.
[Mono] DllImport unable to load library '(null)'.

So maybe the libXrender needs to be also referenced in order to load the libwkhtmltox.sofile.
Am I missing something or is the *.so file not prepared to work with the different ABIs of Android?

@fedemkr Have you found a way to use this lib on android? I have a Unity/Android app and would wery much like to make this work to avoid using a clud web api just to convert html to A4 pdf-s. As I see it the problem is the native libwkhtmltox.dll that is built for windows platforms. But maybe if we tryed something built for linux ??

I've tried with the version for linux and I couldn't make it work. I think it's necessary to build the libwkhtmltox for the different ABIs of Android using CMAKE. Particularly, in my project is no longer needed and now I don't have enough spare time to make it work.
But in the future if it's still needed and I have the time, I'll come back to see if I can get it done.


wont let me update, but keeps telling me I need to...

It says I need to update PowerToys, so I try to do so and it wants to look for a program from the Microsoft Store which makes no sense whatsoever.  I do believe I need to update, but at this time I can't find a way to do so - I've even searched through the app seetings to no avail - perhaps restarting my system will fix it, but this seems like an issue/bug to me.
Thanks,
-Fred

@fwarzwick

it wants to look for a program from the Microsoft Store

Can you please elaborate on the steps?
Do you received the notification and you clicked on "Update now" and then what happened? Can you upload a screenshot?
You can also update manually downloading the installer from https://github.com/microsoft/PowerToys/releases/tag/v0.29.3

@fwarzwick

it wants to look for a program from the Microsoft Store

Can you please elaborate on the steps?
Do you received the notification and you clicked on "Update now" and then what happened? Can you upload a screenshot?
You can also update manually downloading the installer from https://github.com/microsoft/PowerToys/releases/tag/v0.29.3

@fwarzwick
do you still have problem updating PowerToys?
What version are you currently running?
The latest version is https://github.com/microsoft/PowerToys/releases/download/v0.31.2/PowerToysSetup-0.31.2-x64.exe

I also have this issue where almost every day my PowerToys v0.20.1 asks me to update, I tell it to update now, it completes, asks to reboot Windows Explorer, I allow, it happens but then the version is still v.0.20.1 so the next day it will ask me again to upgrade. I will try to manually upgrade and see if it persists once I'm on the latest version .

@gkhattak
0.20.1 is an old version and a lot has changed in the installation process since then.
Manually uninstall it form the Windows 10 Settings -> Apps and then download and install
https://github.com/microsoft/PowerToys/releases/download/v0.33.1/PowerToysSetup-0.33.1-x64.exe


WIP: Adding 0.12 operator for knative eventing

Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the replaces property?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both upstream-community-operators and community-operators at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need
2 For more information see here

@matzew  lgtm, I think we can un-wip this one.

Cool, thanks @maschmid for QE testing this operator!
@J0zi looks like we are ready ! :-)


use some sort of log solution so can hide noisy logs with a flag

maybe something like this? https://crates.io/crates/env_logger

Okay, I will do.

https://github.com/emeceve/loquaz/commit/89318bb79d940f916caaae1a63a49b6a84fd05e0


Not working with import ... from 'npm:package'

As this is pretty new (since 1.25) I assume this wasn't updated yet and therefore throws the following error when there are any imports from NPM.
error: Uncaught Error: load rejected or errored: JsValue(TypeError: Unsupported scheme "npm:" for module "npm:somepackage". Supported schemes: ["data:","blob:","file:","http:","https:"].
TypeError: Unsupported scheme "npm:" for module "npm:somepackage". Supported schemes: ["data:","blob:","file:","http:","https:"].

Given that deno bundle is being deprecated, adding support for this seems especially important: https://deno.com/blog/v1.31#deno-bundle-deprecation

At the moment I would recommend using https://esm.sh/ as skypack has been dying a slow and painful death.

@dsherret do you know if this is planned or if there is a suitable alternative for bundling modern Deno projects?
I have a few open source binaries compiled with deno that are quite enormous based on the inclusion of npm modules, and I'm hoping to treeshake it back to something reasonable
the binary releases for my open source project (cndi) are here you can see how before cndi version 2.0.0 binaries were 120mb and now they are each >1.8GB, from only 336kb of code
would the deno bundle tool help solve this issue if it supported npm specifiers?
Thanks for your work on deno!

I was getting a 'failed to resolve npm:' error and changed to https://esm.sh/, which got past that error.
Now I'm getting a 'Cannot resolve "node:querystring" from "https://esm.sh/....'. Is there a way around this error?


acme: Error 403 - urn:acme:error:unauthorized - Invalid response

I got the following error
acme: Error 403 - urn:acme:error:unauthorized - Invalid response

when run heroku run sabayon Can you help ?

I have been getting this error - can you elaborate on how you fixed this?

Never mind. I forgot to install the oauth plugin. Silly me!


[bug]: returned (wallet) account is not deterministic if there are various scopes for the same account name

Background
If we have two accounts with the same name (not "default") but with different scopes (saying p2wkh and p2tr), the account returned by b.wallet.LookupAccount(accountName) is not deterministic.
The easiest way to check this is to call lncli wallet accounts list --name accountName various times (without providing address_type).
Sometimes it will return the account with the taproot scope and sometimes the other one.
This is not deterministic because in LookupAccount, we browse a map.
More problematic, the problem should happen when calling FundPsbt with a walletrpc.FundPsbtRequest that contains an account name in the payload (an account with various scopes, not the "default" one)
see here
Your environment

lnd v0.15.5
MacOS 12.6
bitcoind v.24.0
To reproduce easily I used Polar v1.4.0 (see steps bellow)

Steps to reproduce
To reproduce easily this non deterministic behaviour you can:

have 2 regtest lnd nodes (Alice and Bob)

import in lnd-bob  the Alice p2tr default account and p2wkh default account (using the same name) (lncli wallet accounts import key --address_type p2tr/p2wkh alice)

then call lncli wallet account list --name alice various times in lnd-bob and see that it will sometimes return the p2tr scope and sometimes the p2wkh scope

Expected behaviour
Deterministic response
Actual behaviour
Non-deterministic response

Hi @Torakushi - I think the intended behaviour is to only ever have 1 scope per account name.
So perhaps to prevent this from happening in future, all we need is to prevent users from doing this in the first place

Hi @ellemouton
Indeed it looks reasonable if this is the intended behaviour (otherwise it might be confusing)
But maybe it would be nice to be able to select a specific scope in FundPsbtRequest for an account name with various scopes (aka default at the moment) for two reasons:

It solves the breaking change induced by using taproot address as the default change output

If we ever want to allow an account name to have different scopes, it will be useful.

Regarding this issue, I can create a PR to prohibit users to create a custom account with various key scopes.
As well, this PR will make the list accounts (+ fundpsbt) deterministic for users who have already created custom accounts with various key scopes.
The question is: do we want to solve this behaviour directly in btcsuite or only in lnd (in this case I will just add some some security checks in LND. It is not as clean but if we need to..)

Accounts are a bit wonky in btcwallet the way they are currently implemented. I think cleaning up the way they work would require a lot of refactoring. So I'd suggest to instead add the checks to lnd in order for users not to get into non-deterministic states.

Indeed, I didn't realise how tricky it would be in btcsuite 😄
Makes sense! I will create a PR in LND to solve this.
Thanks!


feat: rename Avalanche displayName -> Avalanche C-Chain

Current dependencies on/for this PR:

main

PR #1126   👈

This comment was auto-generated by Graphite.

context


Rename plugins

Since both plugins are now in one directory called "Click Dummy", their names can be adjusted.

Oh, sorry! I wasn't sure about that one :smile:


Ln/dao coins

Note: Uint256s come across as Hex strings

Looks chill! I'd only make sure that the buffer -> uint/string parser works

yeah I've tested this extensively. I need to remember to include screen shots.


No error if library exports declaration 'main' which is not a function

According to the recent update of the NNBD specification

Let L be a library that exports a declaration D named main. It is a compile-time error unless D is a function declaration.

But, in fact, there are no errors nor in analyzer nor in CFE in all of the cases below
void getVoid() {}
void main = getVoid();

int get main => 42;

class main {}

typedef void main(List<String> args);

class C {
}
mixin main on C {}

Dart SDK version: 2.10.0-110.0.dev (dev) (Wed Sep 9 17:51:43 2020 -0700) on "windows_x64"

Created #43556/#43557 specific to CFE/analyzer, moved CFE epic link to #43556.

Any work left? Can we close this now?

No more work here, it's covered by sub-issues and they're closed.


#373 and #360 Fix contribution links on README.md

Fix for #373 and #360 by updating link paths from /DOCS to /docs.
https://github.com/CodeForPhilly/vacant-lots-proj/assets/33296817/ce752c6b-af6e-4cbd-b123-de5e7bafceb9

Thanks @BayLadyCoder ! :) @all-contributors please add @BayLadyCoder for code and documentation


when one feature enable, automatically disable another

for ex
when orchard.resources enable, disable orchard.jquery automatically

same familly as #5500


Can upgrade nuget to be greater than or equal to.net framework 4.6.1

Can upgrade nuget to be greater than or equal to.net framework 4.6.1?
Because the rest of my library is.net standard 2.0，So they're not compatible。

Which NuGet package are you referring to?

Closing as I got no response. Feel free to reply.


Comments on functional specification

This is a great idea, something that may be interesting to integrate into Tellurium.
That said, there are some important details to refine. The functional specification for an API (application programming interface) needs to have examples of the code users write to use the API. For each of your use cases, could you give examples of what code users write?
One other question. Respositories such as BioModels provide kinetic constants as well. How generalizable will your approach be so that multiple repositories can be connected?

I edited the functional specification with code examples in the use cases for your first question (commit hash= c562d35)
I also added to the final paragraph on the Background section to answer your second question (commit hash= 0daedc2):
"The interface will also be designed to be scalable to incorporate new repositories of kinetic constants such as BioModels. In each database search method, there will be an option to choose which database or repository to use, a flexibility which will be handled in the backend."


Docs: fix typo: input tabular data: remove unnecessary "-1"

Before the change, with this input:
$_POST = [
    'Setting' => [
        0 => ['value' => 'value0'],
        1 => ['value' => 'value1'],
    ]
];

contents of $settings would be created as follows:
$settings = [
    Setting(value='value0'),
];

after the change it will be:
$settings = [
    Setting(value='value0'),
    Setting(value='value1'),
];

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
None

Thanks!


Endpoint that do not have any parameters fail with an error

let bodySchema = dereferenced.paths[currentPath][currentMethod].parameters.filter(function (parameter) { return parameter.in === 'body' });
This line predictably fails if parameters are null or undefined, which is a valid case.

@idanto Thanks for lightning-fast review and merge! Any estimate on when it is feasible to publish 0.3.1 with the fix?

already done :) enjoy

Thanks a lot!


Adding 6 new commands for SPO data access gov

I haven't contributed to this repo before so please let me know if I need to update anything like the toc and etc. Thanks!


Location of aspnet-webpack

I'm building a development docker container, so the ASPNETCORE_ENVIRONMENT is set to Development, as i would like to support hmr in the development container.
However, i keep running into the following issue.
Error was: Error: Cannot find module 'aspnet-webpack'
I guess it's not clear to me where this file is supposed to exist. If i'm running in development mode natively, then it's a few folder up in node_modules from the application.dll. I've looked through the source code and it's still unclear to me what the path to the 'aspnet-webpack' from the application.dll is supposed to be?

I've found that aspnet-webpack has to be located under /node_modules/ at the root of your web-project folder.  Webpack-Dev-MiddleWare/HMR won't work if /node_modules/ is located anywhere else.


Guest auth fails when specifying an incorrect password for smb3

In SMB3 when a password is provided for a server that requires signing, auth fails even though the server supports server authentication:
user@box:~/tools$ ./go-shareenum -host <IP_ADDRESS> -enum -user 'someone' -pass 'asdsd'
2023/07/06 13:55:16 [Notice] [-] Signing is required
2023/07/06 13:55:16 [Notice] [+] Login successful
2023/07/06 13:55:17 [Error] read tcp <IP_ADDRESS>:60768-><IP_ADDRESS>:445: read: connection reset by peer
panic: close of closed channel

goroutine 1 [running]:
github.com/jfjallid/go-smb/smb.(*outstandingRequests).shutdown(0x14?, {0x0?, 0x0})
	/home/user/projects/go/pkg/mod/github.com/jfjallid/go-smb@v0.2.1/smb/connection.go:275 +0xf0
github.com/jfjallid/go-smb/smb.(*Connection).Close(0xc000114370)
	/home/user/projects/go/pkg/mod/github.com/jfjallid/go-smb@v0.2.1/smb/session.go:1511 +0xe8
main.main()
	/home/user/git/go-shareenum/main.go:262 +0xfc4

Fixed in commit 948f327ee299058cc730552b2adc996dd4e59f59


adguard home service annotations

Hello,
first of all thanks for the helm charts.
Could you add a possibility to set annotations to the services for Adguard Home?
I would like to use the type as a load balancer. However, this service needs annotations so that it always gets the same IP.
Thanks in advance!

Hi @fwmarcel ,
Thanks for this feature request, which makes a lot of sense.
Interested in contributing a PR?

@rm3l  since I can't get any further, I have added this here. please take a look at it

since I can't get any further, I have added this here. please take a look at it

Thanks @fwmarcel. Please take a look at my review comments.


Ability to remove inputs from the send screen

Would be nice to have the ability to remove inputs when creating a transaction. This would make it faster if the user doesn't want to select UTXOs in the separate screen.
It would also help users to be more privacy focused and induce more discipline in the labeling.

It would also be really helpful to have some labeling for inputs and outputs, and also call out how many sats on each available input.

Thanks for the ideas. With the first one, is the intent that removing an input would allow other UTXOs from the wallet to be included (as per the coin selection algorithm), or that a "locked" coin selection of only the remaining UTXOs currently selected is set?
Regarding labelling inputs (and outputs), you can do this in a number of places (Transactions, Addresses and UTXOs tabs). The UTXOs tab is probably the most sensible place to do it for inputs to a transaction - just click on a Label cell in the table to edit.
The sats amount is available on the tooltip for the input - I'm nervous of trying to put too much onto the diagram, as the amount labels can get quite long. As a thought, possibly clicking on input label could switch between showing the labels and showing the amounts?

Got it!
Removing outputs would be helpful in case the algorithm ends up selecting UTXOs the user doesn't want to spend. So it would just select the next best one. Or maybe it could show a modal asking if the user wants to Remove Input or Remove and Auto Replace Input. If blacklisting of UTXOs is added then maybe this is overkill.
More labeling in the Send screen was mostly for labeling the diagram (i.e. inputs/outputs titles) just to educate the user. Hoping to have other people use this wallet to learn and better understand bitcoin under the hood. It's not directed and labeling the UTXOs themselves.
Didn't see the tooltip, but see it now that I left my curser static for longer. Maybe it could be made to show more immediately.

Added the ability to remove UTXOs directly from the transaction diagram in https://github.com/sparrowwallet/sparrow/commit/eb0907660492f068fdd4288821e9ac21a953bba5. This works as you would expect - removing UTXOs causes other UTXOs to be selected to meet a given spend target, unless the user is looking to spend all UTXOs or a selected set of UTXOs, in which case the spend amount reduces as the UTXO is removed from the set.
Tooltip delay has been greatly reduced on the diagram too (https://github.com/sparrowwallet/sparrow/commit/2cb667a67106621466e9379721676409d208c0c6).


Fix a small linting issue and cleanup extraneous comments

As per the title, added 'type-fest' as a dev dependency to provide types for package.json (which was previously throwing a linting error).
Removed extra comments from my previous PR

Thanks!


react-tween-state pulls in react-dom + react

The dependency on react-tween-state is causing these to be pulled in which is not desirable:
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

My next update in dc-redux removes react-tween-state, so it should solve this issue :)

I'm getting warning about this too.  @dancormier, any updates on the next update?  I love this module, thanks for the great work!


Use info log level for first time loading a dynamic config

What changed?
Use info log level for first time loading a dynamic config

Why?
It will be useful for debugging dynamic config. Because default logging level is Info in Cadence.
This would cause too many logging becuase it only emit the logs for the firs time loading.

How did you test it?
N/A

Potential risks
No

Coverage decreased (-0.07%) to 59.866% when pulling d317bdb68e4cbda38c3b507d3707b2ae5042525c on qlong-dynamnic-config-log into 048cac091698dc24601d848272e41bc23517b992 on master.


Support parquet force use Oap without meta file.

What changes were proposed in this pull request?

add a new config named spark.sql.oap.parquet.force.enable to determine whether force enable OptimizedParquetFileFormat when encountering parquet files, default value is false , if set to true force to use OptimizedParquetFileFormat instead of ParquetFileFormat except index ddl operation(use ReadOnlyParquetFileFormat)

use a empty meta instance with OapFileFormat.PARQUET_DATA_FILE_CLASSNAME & dataSchema to construct ParquetDataFile instance.

How was this patch tested?

add a new test case to test spark.sql.oap.parquet.force.enable  is true

mvn test -Pspark-2.1 pass

not affect spark-2.2 profile & spark-2.3 profile

@LuciferYang
Have you tested this  feature with integration?
Thanks

@zhixingheyi-tian
yep, do a simple integration test, use this version with spark-2.1.0-bin-hadoop2.7 run 5 sql,

set spark.sql.oap.parquet.force.enable = true and spark.sql.oap.parquet.data.cache.enable = true can use data cache and no meta file in data dir
set spark.sql.oap.parquet.force.enable = true and spark.sql.oap.parquet.data.cache.enable = false can file read  and no meta file in data dir

@zhixingheyi-tian use a exists config, remove the new config.

@LinhongLiu Refine the conditions for using datacache and remove new config to ensure use ParquetFileFormat if datacache and index both unuseable.


Fix copy directory validation

What changes are proposed in this pull request?
We will make copy existing directory fail the validation, which will skip copy the directory.
But in the meanwhile, we shall pass the validation for move, since we want to delete any existing moved
directory.
Why are the changes needed?
bugs from e2e tests.
Does this PR introduce any user facing changes?
na

The fix LGTM, good to go after fix the test

@jja725 The test result will be kind of random after the fix.

alluxio-bot, merge this please


How to set a password for redis caching?

We tried the following apache config to get rid of [oauth2:warn] "no crypto passphrase configured":
OAuth2Cache redis host=localhost&encrypt=false
But it has no result and the format for the options is not clear (https://github.com/OpenIDC/mod_oauth2/blob/master/oauth2.conf)?

you can use OAuth2CryptoPassphrase <string> which is indeed not correctly documented; I'll change that, thanks


Storybook can't resolve absolute paths

https://github.com/storybooks/storybook/issues/3916
Can't do absolute paths

Tested this solution and it works. https://medium.com/@ktruong008/absolute-imports-with-create-react-app-4338fbca7e3d. Thoughts on doing the same and moving away from the @ name spaced paths?

We should be able to handle these pretty easily. Just need to add a plugin that reads TSConfig into storybook. Testing a solution right now.

https://github.com/pixeloven/pixeloven/pull/33


can not uninstall/delete "Atom-Beautify" package on Windows 7

I tried uninstall "Atom-Beatufiy" (because it's give error on startup and sometimes editor crashed.)
And that give error trying to uninstall...
So after i try to delete files manually and 'Windows' give error because folder path so long.

I solved the problem.
install node.js, and npm install -g rimraf
delete folders : rimraf <dir>

Nice to hear @pSkpt!  Atom will be updating to npm@3 in the future which will get rid of all of these huge folder paths.


get() / pop() return their default value when the key exists but is None

Describe the bug
The following code currently runs without error, showing that get() and pop() fall back to their default value when the key exists and is set to None:
cfg = OmegaConf.create({"x": None})
assert cfg.get("x", 0) == 0
assert cfg.pop("x", 0) == 0
assert cfg == {}  # `pop()` still removed the node even though it returned the default value!

This might actually be a (mostly) intended feature, but it is confusing because this is not how regular Python dictionaries work:
cfg = {"x": None}
assert cfg.get("x", 0) is None
assert cfg.pop("x", 0) is None
assert cfg == {}  # as expected

Expected behavior
I suggest to change it to match the behavior of Python dictionaries.
Since this is a potentially dangerous breaking change, it could be deprecated as follows in 2.1:

Add a new argument allow_none: bool = False to get() and pop()
If the key exists and has a None value, then if allow_none is True we treat is as any other valid value. If allow_none is False, we display a deprecation warning and fall back to the current behavior.

This will force users to specify allow_none=True if they ever call get() / pop() on keys with None values. This flag could then be deprecated in 2.2 (changing its default value to True) and removed in 2.3.
Thoughts?

I think we should match the behavior of plain dict here.
We already have a handful of breaking changes that are matching the behavior of DictConfig with dict, some are very intrusive.
e.g:
In 2.0 and before accessing a non-existing key returns None,
OmegaConf.create().foo # None

In 2.1 this will result in ConfigAttributeError (and OmegaConf.create()["foo"] will result in ConfigKeyError).
This is a much bigger breaking change and there isn't a soft way to introduce it.
I am leaning toward changing this without a deprecation plan because this feels like a clear bug to me and I doubt many people are depending on this behavior.

I am leaning toward changing this without a deprecation plan because this feels like a clear bug to me and I doubt many people are depending on this behavior.

Ok that works too -- I'll prepare a PR for this


Needing to press f5 when logging in

I'm setting up a streama site. At first everything worked OK, but after adding some series, something started to happen.
When the user logs in, nothing appears. You need to press f5 when logging in to show the series.
It seems to be something involving cookies, since F5 is only needed at the first log in. If the user log off without closing the page and logging in again, everything will appear normally.

Ok Thanks, I will look into it. Keep that demo access up as long as possible, I might not get to it soon

I cant seem to be able to recreate this. Can you give me access to your hosted version? Alternatively, check if the problem persists  here: https://github.com/dularion/streama/releases/tag/v1.2_beta

Due to inactivity surrounding this topic I am closing it. If this is not solved please reopen the issue.


__set("property")

as we have __unset("property") it would be nice to also have __set("property")
with $o.property its less dynamic if you want to build a library on top of this one

The project have moved to it's own repository and version 2.0.0 have this requested feature https://github.com/genius257/AutoItObject-Internal/releases/tag/2.0.0


Make journald event logging optional

The latest release (v1.3.0) requires github.com/coreos/go-systemd/sdjournal which relies on development files from systemd which are not available on every target system and could break up builds. I would like to make this feature optional via a buildtag. WDYT?

SGTM. @baude Any issues with this?

I need to think about this before deciding.  the problem is that it is the default setting.

@saschagrunert put together a PR ... lets see what you have in mind.  I want final say but we can collaborate on it.

@saschagrunert put together a PR ... lets see what you have in mind. I want final say but we can collaborate on it.

I will do, thanks. If you say it should be included in every case we could also just update the documentation about building libpod. In CRI-O for example we do not use this new code at all but updating libpod breaks up some builds. Beside that, statically building/linking systemd is a pain point and I usually did not want to put this dependency deeper into the project.


Use protobufjs from npm

Locked to version 6.7.0 since that is the version we are already using and updating it requires additional work because of the use of util.lazyResolve in the generated google-earth-dbroot-parser.js code.

Thanks for the pull request @mramato!

:heavy_check_mark: Signed CLA found.
:grey_question: Changes to third party files were made.

Looks like a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Unlike the other libraries, we had to include the existing compiled prototobuf dist files we were already using, rather than rely on npm package resolution rules.. i.e. we do:
import * as protobuf from 'protobufjs/dist/minimal/protobuf.js';

This is because there are circular dependencies in the npm version which, when built, lead to undefined variables/functions that cause exceptions on load.
Once I got it building, tests were still failing.  Debugging the GoogleEarthEnterpriseMetadata with all exceptions turned on pointed to google-earth-dbroot-parser.js trying to use util.lazyResolve from protobuf.  It turns out that the latest version, 6.11.0, does not have this function so I locked it to the known working version we are using in main.

Thanks @mramato. As a bonus, this shaved 0.2 MB off Cesium.js.map :tada:


Need number overload for Ṫ (Tail Remove)

Currently, Ṫ has no overload for numbers, so it just removes the last character of the stringified version of the number and converts it to an integer. This is somewhat useful for integers, since it's basically integer division by 10 for them, but I can't see too many use cases for decimals. I think there needs to be a different overload for numbers. Any suggestions?

I'd say keep it as it is. Dividing by ten can be useful.

But it's only dividing by ten for integers. For rationals, it's dividing the denominator by ten and then truncating, which is pretty useless. There should be a number overload for Ṫ that is somewhat close to the current functionality but actually makes sense for numbers (maybe a proper divide/integer divide by 10).

What if if 1 (or truthy) push context variable else push nothing?
That'd be in scenarios where you've just done a logical comparison and want to conditionally retrieve n

What about pushing 0 under n, or pushing 1 under n?
(Or pushing [] under n). This could be useful for various reasons, and we have g and G as well.

you could call that "Truthy Over" and the mnemonic is because it's T with an overdot except it's not actually Over it's Under


New ver

@im6h I think you need to squash this commit too. Otherwise it will be blocked by the signed commits rule