Navbar_As a user, I can navigate to pages on the community website (newsfeed, HOW-TOs, Discussions, more)

Child of #106
Latest design files
https://drive.google.com/drive/u/0/folders/1OyJmh39ojHJxs6otETNkYvDUVpAh-3aN

merge into #106


Mech Functionality

This PR will add mech items and sheets to the system.
Item Sheet Checklist:

[x] Mech Frame
[x] Mech Limb
[x] Mech Power Core
[x] Mech Power Core Template
[ ] Mech Weapon
[x] Mech Auxiliary System
[x] Mech Upgrade

Mech Sheet Checklist

[ ] Attribute Display
[ ] Operators
[ ] Slot display
[ ] Rolling Attacks & PP Abilities

Logic Checklist:

[ ] Calculate Attributes
[ ] Calculate Mech Points
[ ] Calculate Movement
[ ] Drag and Drop Item Modifications

This will close #1192

Some confusing things/errors/omissions/bugs brought up by @rmorgens

[x] Can't set a frame to have multiple types
[ ] Biped, Fast lower limbs has a Sprint PP ability to add 10' enhancement bonus to speed.  Unclear if that should be a situational bonus on the limb, a condition that can be applied since it only lasts 1 round, or if the PP ability should be able to have a modifier
[x] Power Core Template needs a prerequisite field
[ ] Unclear how to add the special effect from the Battle core template (temporary boost to PP)
[ ] Should Upgrades have fields for KAC/EAC/FortSave/ReflexSave/BaseHP/HP Advancement/ShieldPts/Speed?  Or should I just use modifiers for the uppers?  (Modifiers may be challenged if the upgrade is selected multiple times)
[ ] Weapon Costs are multiple by weapon level, not tier.  Can be level up to Tier+1
[ ] Will need the weapon properties selections to engage things like Penetration, Reach, Trip, Blast
[ ] PP ability on Mech Limb doesn't appear to be accepting an equation for the DC.  Trying to set Trample to 12+floor(@details.tier/2).  It will only take a fixed number
[ ] To Defy the Dragon also introduced frame variants (basically starmetal adjustments to a frame). Only 1 is allowed at a time
[ ] Mechageddon has a Pyramid frame variant, but I'm instantiating that as a set of Upper Arms, since the variant prevents any upper limbs (among other limitations), so that slot can be used for tracking....  If you want to instantiate more purely, let me know how you approach that problem.
[ ] Would be useful if an effect could add or subtract PP and Shield Points
[ ] There are also functions that take ALL the current PP, so some ability to subtract the current would be helpful


Fixed #2188: Can add and remove more than 10 tags at once.

Describe your changes :

Fixes: #2188

Type of change :

[x] Bug fix

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers
Backend: @open-metadata/backend
@sureshms @harshach

@parthp2107 let's think of a generic solution , what you have done will solve issue in case we have patch like /column/1/tags/0 , but in future it might happen that we have fields which are of type List similar to tag that we try to update something like /column/1/{newItem}/{position} in that case we again will need to handle with if else , we want to have of type list sorted as integers considering {position}


Code improvements

Hi nice project!
I just wanted to contribute some small things (like removing trailing whitespaces, indenting, etc.) that might be helpful, and others (such as the curly braces in the one-line IFs) that might have more relevance.

Perfectly reasonable formatting improvements, though I think there's a few you missed that I'll go back and whitespaceify. Thanks for this, though! It's good stuff.


ValueError: Cannot feed value of shape (0,) for Tensor 'Placeholder_1:0', which has shape '(16, 4, 4, 3)'

Hi, I'm trying to train my own dataset, but have this error. Do you have any ideas?
Traceback (most recent call last):
File "wrapper.py", line 29, in <module>
process_config(sys.argv[1])
File "wrapper.py", line 22, in process_config
gan.execute()
File "/floyd/home/deepzine.py", line 89, in execute
self.train_gan()
File "/floyd/home/deepzine.py", line 204, in train_gan
pggan.train()
File "/floyd/home/model.py", line 283, in train
sess.run(self.opti_D, feed_dict={self.images: real_data, self.latent: sample_latent})
File "/usr/local/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 887, in run run_metadata_ptr)
File "/usr/local/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1086, in _run str(subfeed_t.get_shape())))
ValueError: Cannot feed value of shape (0,) for Tensor 'Placeholder_1:0', which has shape '(16, 4, 4, 3)'

It looks like data is not being fed into your network, perhaps because something went wrong in the data-loading process, but unfortunately I cannot troubleshoot without understanding more about the dataset you are trying to train on. Are you working with similar data downloaded from the Internet Archive?


repository: fix pull when fetch returns up-to-date

After perform a Repository.Fetch if a Repository.Pull was done, the references weren't updated.
The reason was because Repository.Fetch returns NoErrAlreadyUpToDate and the internal Repository.updateReferences was not called
Fixes:  https://github.com/src-d/go-git/issues/198

This does not seem the standard git behavior. If Pull updates references
➜  go-git.v4 git:(master) ✗ git fetch origin
Enter passphrase for key '/home/smola/.ssh/id_rsa':
remote: Counting objects: 18, done.
remote: Compressing objects: 100% (18/18), done.
remote: Total 18 (delta 4), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (18/18), done.
From github.com:src-d/go-git
   92d3de7..c5f1056  master     -> origin/master

➜  go-git.v4 git:(master) ✗ git pull origin master
Enter passphrase for key '/home/smola/.ssh/id_rsa':
From github.com:src-d/go-git
 * branch            master     -> FETCH_HEAD
Updating c9c043c..c5f1056
[...]

➜  go-git.v4 git:(master) ✗ git pull origin master
Enter passphrase for key '/home/smola/.ssh/id_rsa':
From github.com:src-d/go-git
 * branch            master     -> FETCH_HEAD
Already up-to-date.

First I fetch, then pull, and pull again. First pull does not return "Already up-to-date" because it updates a reference, second pull returns "Already up-to-date" because it doesn't.

Current coverage is 76.26% (diff: 76.31%)

Merging #207 into master will decrease coverage by 0.57%

@@             master       #207   diff @@
==========================================
  Files            96         96
  Lines          6278       6298    +20
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           4824       4803    -21
- Misses          925        973    +48
+ Partials        529        522     -7

Powered by Codecov. Last update c5f1056...2b7286e


APK tool error

Information

Apktool Version (apktool -version) - 2.4.1
Operating System (Mac, Linux, Windows) - Window 10
APK From? (Playstore, ROM, Other) -Playstore

Stacktrace/Logcat
I: Using Apktool 2.4.1 on BOB_mPassbook_v3.0.7.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: C:\Users\rawat\AppData\Local\apktool\framework\1.apk
I: Regular manifest package...
I: Decoding file-resources...
W: Cant find 9patch chunk in file: "drawable-hdpi-v4/common_google_signin_btn_icon_light_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xhdpi-v4/common_google_signin_btn_text_light_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xxhdpi-v4/common_google_signin_btn_text_light_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xxhdpi-v4/drawer_shadow.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-hdpi-v4/common_google_signin_btn_text_dark_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xhdpi-v4/drawer_shadow.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-mdpi-v4/common_google_signin_btn_icon_dark_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-mdpi-v4/common_google_signin_btn_text_dark_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xhdpi-v4/common_google_signin_btn_text_dark_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-hdpi-v4/sigup_bg.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-mdpi-v4/common_google_signin_btn_icon_light_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xxhdpi-v4/common_google_signin_btn_icon_dark_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-mdpi-v4/drawer_shadow.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-mdpi-v4/common_google_signin_btn_text_light_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xhdpi-v4/common_google_signin_btn_icon_dark_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-hdpi-v4/common_google_signin_btn_icon_dark_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xhdpi-v4/common_google_signin_btn_icon_light_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xxhdpi-v4/common_google_signin_btn_icon_light_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-hdpi-v4/drawer_shadow.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-hdpi-v4/common_google_signin_btn_text_light_normal_background.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xxhdpi-v4/common_google_signin_btn_text_dark_normal_background.9.png". Renaming it to *.png.
I: Decoding values */* XMLs...
I: Baksmaling classes.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...

Steps to Reproduce

apktool d app.apk
apktool b app.apk

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
APK
If this APK can be freely shared, please upload/attach a link to it.
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?

Yes

Are you using the latest apktool version?

Yes

apktool is not able to rebuild most of the apps I have tried with many apps but it is giving different kind of errors every times.

Agreed, apktool has major issues with png files now or -v4 paths in res folder. Its always the -v4 png's I have noticed.

Do you have an example apk? Our test suite is pretty powerful with 9patch images, so confused how this may have regressed.
@JimDunn1234 - You seem to have some serious negativity around this project. Its open source so you can contribute :)

I tested Instagram app

If you can share the APK you're having trouble with, other people can take a look at it and hopefully give you an answer.
To me, this just looks the 9patch images are malformed. Which does happen occasionally. If that's the case, it doesn't mean the APK won't work. The worst that will happen is some of the images might look a bit strange.

same error apktool 2.4.1 with sky_go_pr17-5-0-1-110
tried 2.3.4 also but no luck
you can get the apk from here
https://www.apkmirror.com/apk/sky-italia-s-r-l/sky-go-it/sky-go-it-pr17-5-0-1-1100-release/

Thanks for sharing the APK. I downloaded that particular version and did some experimenting with it, after installing a framework-res.apk from an AOSP build of Android 10 (sigh...I really do miss Google giving names to these - 'Android 10' just sounds so dull..).
This is what I get when I decompile:

(java -Xmx1024m -jar user_files\APKTOOL\apktool_2.4.1.jar d --force-manifest     --only-main-classes  -f -p _WorkArea1\Frameworks _WorkArea1_in\it.sky.anywhere.apk -o _WorkArea1_working\it.sky.anywhere.apk)
I: Using Apktool 2.4.1 on it.sky.anywhere.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: _WorkArea1\Frameworks\1.apk
I: Regular manifest package...
I: Decoding file-resources...
W: Cant find 9patch chunk in file: "drawable-mdpi-v4/grid_item_border.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xhdpi-v4/grid_item_border.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-hdpi-v4/grid_item_border.9.png". Renaming it to *.png.
W: Cant find 9patch chunk in file: "drawable-xxhdpi-v4/grid_item_border.9.png". Renaming it to *.png.
I: Decoding values / XMLs...
I: Baksmaling classes.dex...
I: Baksmaling classes2.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
I: Copying META-INF/services directory

Four 9patch ("*.9.PNG") files are missing the actual 9patch information so apktool is turning them into ordinary PNG files. This isn't that unusual, to be honest. I've seen this a lot over the years and it's normally nothing to worry about. Since those files didn't have 9patch information in them you won't see any difference visually between them and the PNG versions when the app is running. There might be some difference in file sizes possibly but nothing significant. This can be ignored.
So I tried recompiling. First with aapt2 enabled:

(java -jar user_files\APKTOOL\apktool_2.4.1.jar b --copy-original  --force-all --use-aapt2 -p _WorkArea1\Frameworks _WorkArea1_working\it.sky.anywhere.apk -o _WorkArea1_out\it.sky.anywhere.apk)
-c/--copy-original has been deprecated. Removal planned for v2.5.0 (#2129)
I: Using Apktool 2.4.1
I: Smaling smali folder into classes.dex...
I: Smaling smali_classes2 folder into classes2.dex...
I: Building resources...
W: C:\TickleMyAndroid_WorkArea1_working\it.sky.anywhere.apk\res\values\public.xml:1169: error: resource 'drawable/$avd_hide_password__0' has invalid entry name '$avd_hide_password__0'. Invalid character '$avd_hide_password__0'.
W: C:\TickleMyAndroid_WorkArea1_working\it.sky.anywhere.apk\res\values\public.xml:1170: error: resource 'drawable/$avd_hide_password__1' has invalid entry name '$avd_hide_password__1'. Invalid character '$avd_hide_password__1'.
W: C:\TickleMyAndroid_WorkArea1_working\it.sky.anywhere.apk\res\values\public.xml:1171: error: resource 'drawable/$avd_hide_password__2' has invalid entry name '$avd_hide_password__2'. Invalid character '$avd_hide_password__2'.
W: C:\TickleMyAndroid_WorkArea1_working\it.sky.anywhere.apk\res\values\public.xml:1172: error: resource 'drawable/$avd_show_password__0' has invalid entry name '$avd_show_password__0'. Invalid character '$avd_show_password__0'.
W: C:\TickleMyAndroid_WorkArea1_working\it.sky.anywhere.apk\res\values\public.xml:1173: error: resource 'drawable/$avd_show_password__1' has invalid entry name '$avd_show_password__1'. Invalid character '$avd_show_password__1'.
W: C:\TickleMyAndroid_WorkArea1_working\it.sky.anywhere.apk\res\values\public.xml:1174: error: resource 'drawable/$avd_show_password__2' has invalid entry name '$avd_show_password__2'. Invalid character '$avd_show_password__2'.
I: Copying libs... (/lib)
I: Copying libs... (/kotlin)
I: Copying libs... (/META-INF/services)
I: Copy original files...
I: Copy AndroidManifest.xml...
I: Copy META-INF...
I: Building apk file...
I: Copying unknown files/dir...
I: Built apk...

This error about the invalid character is interesting. The '$' is causing this. Aapt2 doesn't like it. You can get around this by renaming every instance of those files to something else (call them "dollarsign_avd.." for example) which would work. Or you could just use aapt1 instead:

(java -jar user_files\APKTOOL\apktool_2.4.1.jar b --copy-original  --force-all  -p _WorkArea1\Frameworks _WorkArea1_working\it.sky.anywhere.apk -o _WorkArea1_out\it.sky.anywhere.apk)
-c/--copy-original has been deprecated. Removal planned for v2.5.0 (#2129)
I: Using Apktool 2.4.1
I: Smaling smali folder into classes.dex...
I: Smaling smali_classes2 folder into classes2.dex...
I: Building resources...
I: Copying libs... (/lib)
I: Copying libs... (/kotlin)
I: Copying libs... (/META-INF/services)
I: Copy original files...
I: Copy AndroidManifest.xml...
I: Copy META-INF...
I: Building apk file...
I: Copying unknown files/dir...
I: Built apk...

Problem solved. You might need to use a new key to sign this file to get it to work on your phone, but it decompiles and recompiles without any issue.
But there's a second part to this. As @JimDunn1234 and @iBotPeaches discussed, something happens to your "drawable-de-hdpi-v4" folder. The original APK has a folder called "drawable-de-hdpi-v4" but the recompiled APK doesn't. Apktool renames it to "drawable-de-hdpi".
In fact there are a lot of folders in that APK that has this happen to. I've taken a screenshot comparing the original APK to the recompiled one, which I've attached.

This seems bad but it actually isn't. The idea behind is that an APK can have, for example, two folders: "drawable-de-hdpi" and "drawable-de-hdpi-v4". The images in the first folder would normally be used (on a German device with an high screen density) but the images in the second folder would be used if the device is running Android API 4 or above. That's Android 1.4 which I'm reasonably confident you're not using.
I may be wrong about this, and I'm happy for somebody to correct me, but the fact that this folder has the "v4" removed won't realistically make any difference. There's no "drawable-de-hdpi" folder in the original APK so nothing's being lost.
So in conclusion, before I start writing an entire damn essay here (I tend to lecture if I'm not paying attention), there's nothing to worry about. The file decompiles and recompiles without any problems.

well i get an error on recompiling the app also, kind of
:brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = -1073741515):
now i have to investigate why you can build it.
it might be that i used a lineage 14.1 framework, or windows 7 x86 with java8 32bit, it did give an error using both aapt and aapt2

That exit code is caused by the use of 32 bit Java and shouldn't be happening with apktool 2.4.1. Apktool 2.4.0. had an issue with 32 bit Java which was fixed for the latest version.

Not sure even what the root issue with this report was. 32 bit is deprecated, dying and not supported in the future - so ignoring any of those.
The output in original issue is just warnings, which may point at an issue with our 9patch disassembler, but nothing references an issue with those.
The $ sign issue was detected and fixed in the upcoming release.
The remap/char/windows issue is detailed here - https://github.com/iBotPeaches/Apktool/issues/2237#issuecomment-562550340
So closing after breaking down each point in this ticket.


Complete dependency list in requirement.txt

Hi, the version of some packages are not mentioned in the requirement.txt such as matplotlib, tqdm, joblib. Could you please update the requirement.txt? Right now the dependencies conflict.

Thank you for your feedback! I have uploaded the complete package for lookup.


Add a warning when trying to rename class to a exist name

Why
When I trying to rename class to a exists name, it will overwrite the original class without warning :(

Added in above mentioned PR.


All pages in the DSpace User Interface should have automated accessibility tests

Description
As of #2711, the following User Interface pages have automated accessibility scanning (via Deque's Axe tool) enabled:

All current, anonymous-access pages (at least that I'm aware of)
Submission / MyDSpace / Workflow pages
Community/Collection/Item Edit pages (all tabs)
Login, new user registration & user menu
Admin sidebar

The following pages are believed to be missing accessibility scanning:

All admin pages linked of Admin Sidebar not listed above.
Any additional features (or new features) not listed above

Proposed solution
All DSpace user interface pages / modals should have an automatic accessibility scan enabled.

This requires building a Cypress e2e test script for that page (if one doesn't exist), loading the page and running the testA11y() function on the page similar to the examples in #2711
If the testA11y() script fails (because accessibility issues exist on the page), then either the issues should be fixed or a temporary exclusion can be added to the testA11y() script until those issues can be fixed.  For examples of exclusions see [submission.cy.ts](https://github.com/DSpace/dspace-angular/blob/main/cypress/e2e/submission.cy.ts)

This ticket need not be solved by a single PR.  In fact, it may be easier to implement these improvements over several PRs.  Therefore, multiple people can claim this ticket provided they are clear about which pages they are working on.
Related work
Related to the work in #2711, which builds on some earlier automatic accessibility scanning.

@atarix83 : I think it's perfectly OK to only create the accessibility validation for the new e2e tests.  That also has the benefit of creating a "basic scaffolding" for all pages to have more thorough e2e tests in the future (as part of a future effort).
Assigned to you and adding estimate details as a label.


[feat] Add helper to convert HtmlCollection to a dart list

Issue:
When working with html element childrens which are represented through the HtmlCollection, if someone wants to iterate through these childrens in dart, only approach is to use a  for loop like follow to either create a dart list which would then allow running operations like forEach, map, etc on the list or simply iterate through them to execute any functions.
      final childrens = <Element>[];

      for (var i = 0; i < element.children.length; i++) {
        final child = element.children.item(i);

        childrens.add(child);
      }

This works but it becomes tedious when I've to do the same thing in multiple places. Off course, I could add an extension for this on HtmlCollection but it would be nice if such helper was present in web package itself.
TouchListConvert extension on TouchList is an example of such helper. And the approach seems better instead of running a for loop which results in extra computations. Adding a similar helper for converting HtmlCollection to a dart list would be nice addition I believe.
Proposal:
I can see this addition going two ways,

Add a similar extension on HtmlCollection like TouchListConvert that would return a HtmlCollectionWrapper that would be a dart list.
Create a generic wrapper like TouchListConvert which could work for both TouchListConvert and HtmlCollection, and also other web facing apis like NodeList that represent a list of items. This one I'm not so sure abt how one would approach for this scenario.

You can use Array.from (related dart-lang/sdk#56069):
import 'dart:js_interop';

import 'package:web/web.dart';

@JS('Array.from')
external JSArray<T> arrayFrom<T extends JSAny?>(JSAny any);

void main() {
  var body = document.body as HTMLElement;
  var children = arrayFrom<Node>(body.children);

  for (var child in children.toDart) {
    print(child.textContent);
  }
}

What would you say is more efficient in terms of computations between 1. the approach you suggested 2. Using for loop it create list on dart side 3. The approach used by TouchListConvert.?
Given I've to do this hundreds of times over wide array of childrens in my web project at any given moment, I believe the third approach could be the most efficient as there's no overhead of computations from creating a list or rather conversation from dart-js interop. Probably the reason why that approach was used within TouchListConvert or may be some other reason.

Similar issue: https://github.com/dart-lang/web/issues/101

And the approach seems better instead of running a for loop which results in extra computations.

The end result will be the same here in terms of performance. We'll still need to iterate.
I think option 2 is the best bet here. We can make this a generic List wrapper (with T being Touch for TouchListWrapper) around a JSObject so that that wrapper can be used for other types besides just HtmlCollection (maybe some of the iterable types if users want).

What would you say is more efficient in terms of computations between 1. the approach you suggested 2. Using for loop it create list on dart side 3. The approach used by TouchListConvert.?

I answered this partially on the Array.from request, but it depends on if you have a lot of accesses or a lot of creations. That being said, 3 avoids the Array.from call, so it should likely be faster than 1, but maybe array accesses are faster than accesses on TouchList for example. Either way, users should have all these options so they can decide based on their use-case.

Either way, users should have all these options so they can decide based on their use-case.

@srujzs  Correct me if I'm wrong, so we're planning to add all these 3 options to give users options to pick the best one for them,

arrayFrom external method. This is already proposed for dart sdk but I'm not sure on the timeline of when it'll be added. But it should be a simple addition to  existing JSArray I believe. I can put a PR on this for dart sdk if there isn't one already.
A generic list wrapper around JSObject  that uses for-loop to create dart list. Part of web package.

About the 3rd option, creating generic implementation of TouchListWrapper, how do you propose we do this?

Yup, it should be a simple addition as a static method. Feel free to contribute, happy to take PRs!
I meant this as users can do this themselves already with a simple for-loop (it's essentially what you wrote in the first comment). We could add a helper here, but it likely doesn't buy much over option (3).
Most of these list-like types have similar interfaces in the JS side e.g. DOMRectList. There's an accessor and a length property, and that's it. The current TouchListWrapper implementation can be made generic by instead taking a T extends JSObject, and replacing Touchs with T. The list-like JSObject (in this case, TouchList) will have to be assumed to have length and item properties since we don't have a shared interface type for all these APIs, but besides that quirk, it should work out neatly. We don't need more features than what TouchListWrapper provides as that should be sufficient to be at parity with dart:html. I could take this on.

That clarifies the doubts I had.
No problem. I can push on both 1 and 3. Thanx for the clarifications!


Question about Random Image Flip Augmentation for CaDDN

@codyreading
Is there a reason why gt_boxes_2d isn't also passed into the utility function and horizontally flipped here? I think this could potentially be a bug in the CaDDN DDN loss.
https://github.com/open-mmlab/OpenPCDet/blob/274c90c55364ab87e15cd27b3e19005b795ae503/pcdet/datasets/augmentor/data_augmentor.py#L82-L99

Never figured it out.


ActionView::Template::Error in Communication::Website::CleanAndRebuildJob@whale

Error in Osuny
ActionView::Template::Error in Communication::Website::CleanAndRebuildJob@whale
undefined method `title' for an instance of Communication::Website::Page::Home
View on Bugsnag
Stacktrace
app/models/communication/block/template/page.rb:41 - heading_title
app/views/admin/communication/blocks/_static.html.erb:8 - _app_views_admin_communication_blocks__static_html_erb___787706221204808901_220520
app/views/admin/communication/blocks/headings/_static.html.erb:8 - block in _app_views_admin_communication_blocks_headings__static_html_erb__1063277597877677635_221760
app/views/admin/communication/blocks/headings/_static.html.erb:7 - _app_views_admin_communication_blocks_headings__static_html_erb__1063277597877677635_221760
app/views/admin/communication/blocks/content/_static.html.erb:14 - block in _app_views_admin_communication_blocks_content__static_html_erb___937929402915590119_220480
app/views/admin/communication/blocks/content/_static.html.erb:13 - _app_views_admin_communication_blocks_content__static_html_erb___937929402915590119_220480
app/views/admin/communication/websites/pages/static.html.erb:48 - _app_views_admin_communication_websites_pages_static_html_erb___124830795597366119_220260
app/services/static.rb:23 - render
app/models/communication/website/git_file.rb:66 - to_s
app/services/git/repository.rb:91 - block in sync_git_files
app/services/git/repository.rb:84 - each
app/services/git/repository.rb:84 - sync_git_files
app/services/git/repository.rb:26 - sync!
app/models/communication/website.rb:171 - sync_with_git_safely
app/models/communication/website/with_connected_objects.rb:26 - clean_and_rebuild
app/jobs/communication/website/clean_and_rebuild_job.rb:5 - execute
app/jobs/communication/website/base_job.rb:29 - perform

View full stacktrace
Created automatically via Bugsnag

An error linked to this issue has been marked as fixed in Bugsnag
ActionView::Template::Error in Communication::Website::IndirectObject::SyncWithGitJob@elephant


Request focus on click

Compose 1.1.0
Native applications move focus when we click on focusable widgets (text fields, buttons, etc).
Most certainly we need to do it in Compose too. Currently focus move only for text fields, but not for clickable, toggleable widgets.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


Feature: add a simple stand-alone cherry-pick command

Changes in Docs:

add cherry-pick to history section
add unmentioned reset commands to history section
a typo fix

refs #11

Very nice!


Test create esd tempest test requires pre-existing demo policy on the BIG-IP

Title: Test setup for api/test_esd.py::ESDTestJSON::test_create_esd needs a pre-existing policy on the BIG-IP called 'demo-policy'

Agent Version
mitaka agent with ESD feature merged in
OpenStack Release
mitaka
Bug Severity
This is a test bug
Severity: 5
Severity level definitions:

Severity 1 (Critical) : Defect is causing systems to be offline and/or nonfunctional. immediate attention is required.
Severity 2 (High) : Defect is causing major obstruction of system operations.
Severity 3 (Medium) : Defect is causing intermittent errors in system operations.
Severity 4 (Low) : Defect is causing infrequent interuptions in system operations.
Severity 5 (Trival) : Defect is not causing any interuptions to system operations, but none-the-less is a bug.

Description
The setup for this particular test requires a preceding step of creating a policy called 'demo-policy' for the test to run properly. Otherwise the agent fails to find this policy and the test fails.
Associated Tests:
["test_esd::ESDTestJSON.test_create_esd"]

Need to isolate to see if this is the same error:
Traceback (most recent call last):
  File "/home-local/jenkins/workspace/openstack/driver/mitaka/12.1.2-undercloud-vxlan/f5lbaasdriver/test/tempest/tests/api/test_esd.py", line 90, in test_create_esd
    raise ex
_pytest.assertion.reinterpret.AssertionError: assert <bound method BigIpClient.virtual_server_has_value of <f5lbaasdriver.test.tempest.services.clients.bigip_client.BigIpClient object at 0x7ff42aafbb50>>('Project_f6231e57-2ae7-4cdc-aa46-4225f87fc368', 'fallbackPersistence', '/Common/source_addr', 'Project_de4d1806a4e445b398baf2b8243de756')
 +  where <bound method BigIpClient.virtual_server_has_value of <f5lbaasdriver.test.tempest.services.clients.bigip_client.BigIpClient object at 0x7ff42aafbb50>> = <f5lbaasdriver.test.tempest.services.clients.bigip_client.BigIpClient object at 0x7ff42aafbb50>.virtual_server_has_value
 +  and   'Project_de4d1806a4e445b398baf2b8243de756' = <f5lbaasdriver.test.tempest.tests.api.test_esd.ESDTestJSON.test_create_esd[smoke] id=0x7ff428d9d910>.partition

Test Impact:

openstack_driver_mitaka_12.1.2-undercloud-vxlan.59.consoleText

failures
ESDTestJSON.test_create_esd
md5sum:fe67d31dd8eae956660ec601cd018b25

This test is passing now.


Polymer/Web components - possibly babel issue

Bug Report
I am trying to create docz for a library of custom elements, most of the are built on top of Polymer.
as React supports working with web-components, the babel transpiling is not configured to support that.
To Reproduce
Add custom element component, preferably Polymer based (not mandatory)

Go to 'localhost://3000'
Open dev-tools console
Error: Uncaught TypeError: Class constructor PolymerElement cannot be invoked without 'new'

In order to allow us to quickly reproduce you issue please include a link to a reproduction repository.
Expected behavior
Web component to work ;)
Enviroment
Windows 10 :(
Node 9.x
npm 5+
Docz mdx file
---
name: card-layout
---

import { Playground } from 'docz';
import CardLayout from './components/card-layout.js';

# CardLayout

## Basic usage

<Playground>
  <card-layout>

Header

  </card-layout>
</Playground>

I think that this is not a bug in fact, but an enhancement. Create something like `docz-plugin-webcomponents-  will be nice here!

Using web-components you are mostly targeting latest browsers (supports class syntax). This means that actually babel is not required except for object-spread, possibly decorators. But for some reason it just doesn't work, even when I provide a custom .babelrc file. Is there any way to reach out to the webpack configuration?

To facilitate user feedbacks and make a really good roadmap, now we're using Canny as a tool to create our roadmap 😍
We think that is better keep Github issues only for bugs and other issues! 🐞
This issue is already on our roadmap, so I'll close this issue in favor of it!
👉🏻 Check this issue on roadmap

The problem exists due to babel transpiles the classes back to ES5 functions and the Web Components specification says the registered components via customElements.define must be ES6 classes.
I don't know how Docz internally works, but maybe could be possible bypassing babel importing a .mjs file.


No JS Runtime Errors while debuging

I've had a long break since I've been develoing my extension. I remember that whenever I made some mistake (type error, reference error etc) I was able to ee that error in the debuging outbut. Right now no errors are show. Is this realy a bug or just something with my configuration? Please help.

VSCode Version: 1.44.0
OS Version: Windows 10

Steps to Reproduce:

Create a simple JS extension (yo code)
Add some code to generate an error (undefined function call should do)
Debug your extension (Hello world command)

Does this issue occur when all extensions are disabled?: Yes

Can you give a specific example? If there is a runtime error you will see it in the debug console.

You can try by making a call to undefined function in Hello World command. Normally it should print a typical JS runtime error like:
UngaughtReferenceError: Call to undefined method XYZ.

The thing is that it's not an unhandled error, because the vscode extension host actually catches the error. You should see a notification in the extension development host window with that error message. You would only see the error in the debug console if it was truly unhandled.

Ok, thank you for explaining that. I was sure I saw those errors in the debug terminal. Well, sorry for my mistake.


Wildcard support

I've noticed you can't currently use any regex when defining urls, but is there some other way to leverage different subdomains or wildcard characters?
For example, I want to crawl multiple subdomains that follow a similar structure https://pco[NAME].zendesk.com/. I was thinking I could change the match field to accept a string array, and also couldn't use regex to wildcard the [NAME] piece of the subdomain. Is there some other way to achieve this?

I like the idea of supporting a glob or regex, open to PRs!


Mastodon account for this project

Would a Mastodon account for the project be possible?

Sure, go on.
If you want to chat questions can also be asked via Matrix https://app.element.io/#/room/#facturx:matrix.org


Music if mute start then stop after lunach game

Describe the bug
Music if mute start then stop after lunach game,
To Reproduce
Steps to reproduce the behavior:

Launch The Question
Go To Options
Mute music.
Quit the game.
Launch The Question
Check if you hear music for few seconds after launching it

Expected behavior
Music should be mute all time if muted in options.
Runtime (please complete the following information):

Godot version 3.2
Rakugo Version 2.0.8

It can be fixed by muted all chanles in audio bus file.
branches:

[x] the-question-1.2 #280
[ ] 2.0.8
[ ] tutorial
[ ] the-question
[ ] 2.1.00

It was fixed in the-question a long time ago.


Click handling for items within a row

How can we detect, if a "firstName" or "lastName" is clicked?
So generally: How can we detect which item has been clicked within a row item?
This should consider CompositeItemBinder with different item types...
I am thinking about having
"firstNameClickHandler()"
"lastNameClickHandler()"
in the activity?

you could do this
Set this on the view you want to be clickable
android:onClick="firstNameClickHandler"
android:tag="@{user}" // the viewmodel variable
and then in your activity
public void firstNameClickHandler(View v) {
UserViewModel userViewModel = (UserViewModel)v.getTag();
}


[Feature]: ability to show popup for end users when app crashes

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
When an app crashes in appsmith. If appsmith has an ability to show a popup to end users in case of app crashes that would help in sharing the issues directly with the appsmith team
Why should this be worked on?
This helps in sharing bug-report or any related information faster with with the respective teams

End users wouldn't have information to share with Appsmith. Developers can have a way to get the logs and share it with us


Setup Error: Run-time error '76': Path not found

i get this error when i try to setup excelpython.  when i open the debugger it points me to this line:
fso.CopyFolder ThisWorkbook.Path + Application.PathSeparator + "xlpython", wb.Path + Application.PathSeparator + "xlpython"

Hi,
For me to help you need to provide me with further information. That line of VBA code copies the the ExcelPython runtime (the xlpython folder) from the folder containing the ExcelPython xlam add-in to your workbook folder. This could be failing most probably for one of two reasons:

because the xlpython runtime is missing or for some other reason inaccessible from the add-in folder
because for some reason it's not possible to write it into your workbook folder
I suggest to start by checking the first point, and seeing if copying it manually works.
Regards,
Eric


Batch: pack DPIC with hybird parallel and pipeline

Previous we give each bundle a different delay to collect valid value by Pipeline.
This change process bundles of same class in parallel, because offset is easy to count, and it will reduce stages in pipeline to reduces regs.
We also sort bundles by width, giving larger bundle less delay for less reg. And add num to info, which will reduce info costs with multiple bundle of same class.

Sure, I will leave more comments later, and a detailed doc when the code structure is more stable


Wrong doc link of EnvVarSource in page Define Environment Variables for a Container

This is a Bug Report

Problem:
Page: [kubernetes.io/docs] Define Environment Variables for a Container
At the bottom of the page, the link of See [EnvVarSource](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.30/#envvarsource-v1-core).  is 404
Proposed Solution:
Page to Update:
https://kubernetes.io/...

/close
Fixed by https://github.com/kubernetes/website/pull/45914


Question: tvOS: When using tvos remote, UISearchController keyboard events are not propagated to UISearchBar's Text Input Field

I am trying to Add Search capability in my tvOS App and am facing an issue where when using the tvos remote, the keyboard events are not propagated to the SearchBar's Text Input Field.
Typing on the laptop works though.
I have created a reproducible test repo for your review. (Branch-poc/search-controller)
https://github.com/keshavkaul/react-native-tvos-poc/tree/poc/search-controller
In the repo, I have created a Native UI Component called RNSearchControllerView
The native code is present under src/search-controller/ios/Classes
Any help is most welcome!
My guess for the issue is that react is intercepting the remote's events and not correctly propagating to the target UI

React does intercept remote events, in RCTTVRemoteHandler.m.  You might need to modify that file in order to allow your search controller to get the events.

@keshavkaul were you able to resolve this issue?

@dlowder-salesforce No, I didn't find time to resolve this, but I implemented a quick fix to natively present a search controller as a modal instead of embedding the controller in react native view

I'm facing the same issue, but I can't figure out how to avoid RCTTVRemoteHandler.m from intercepting remote events just for the search controller. Has anybody integrated successfully the search bar? Is there a work-around besides showing it as a modal?

Hi, we also have UISearchController used in our project and had issues mostly with remote with touch.
Sometimes touch event (gestures) were not propagated to the keyboard.
After dubugging it found out that there is a RCTTouchHandler registered in React/Base/RCTRootContentView.m so basically 2 gesture handlers were registered.
RCTTouchHandler has internally a function canBePreventedByGestureRecognizer  which was returning true in our case.
The RCTTVRemoteHandler .m already has gesture handler implementation so in case of RCTRootContentView we just skip to register the RCTTouchHandler.

@zsoltbokor if you are using recent RNTV (0.72 latest, or 0.73), the RCTTouchHandler has been removed for Apple TV, see https://github.com/react-native-tvos/react-native-tvos/pull/601 .


Document "protected tables"

To resolve #8.
Also adding docstrings to a few tables and cleaning up some comments.

@kelle is this the type of documentation you were looking for? Can expand or stick this somewhere else (in the project README, perhaps)

YES, thanks!!  Also in the astrodb_scripts RTD....maybe you could open a similar PR in that repo?


KeyError: 'USER' while using SQLite

While using dbbackup and restore commands for backing up an SQLite database, a 'KeyError: 'USER'' error is shown.
There's no USER in settings.DATABASES as it is an optional setting in SQLite.

I'll have a look at this

I think this issue is fixed with this PR #66 .

Yes, that looks like the fix that was needed, thanks for looking through issue history and keeping it updated!
@SG345  this should fix the issue. I don't know when a release is coming up, should be soon


Images on Android only extremely low quality.

Description
I am trying to load high quality images in React Native for a chart application and I am getting low quality images being displayed on Android, Zooming in does not help either, instead it makes the issue worse. iOS is fine, but viewing the same image on Android gives dire results and does not look the same quality as iOS.
I have attached an Expo snack example so that you can compare and Zoom in to see the issue.

React Native version:
0.66
Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

Use a high quality PNG image.
Load the image in an Image Viewer or Image Tag.

Expected Results
Describe what you expected to happen.
I expect the image quality to be the same regardless of the platform.
Snack, code example, screenshot, or link to a repository:
https://snack.expo.dev/@joelpateljp/low-quality-image-android-example

Is there any update on this?

My rn version is 0.63.
I got the same issue when I use big size an image.

It is facebook/fresco issue.

@wayne-tt I wrote a comment and the same Expo snack on the facebook/fresco repo https://github.com/facebook/fresco/issues/2397#issuecomment-993714092

I am facing the same problem if you got the solution then please share with me

Same issue rn version is 0.64.3.

Same issue in "react-native": "0.68.0".

same issue 0.64.3

same issue 0.64.3

Does anyone know whether the problem also exists using JPG images?

Still a bug in 0.71.2. This has been a bug for many years before this particular issue was filed. (see https://github.com/facebook/fresco/issues/2397 https://github.com/facebook/react-native/issues/21301 etc).
Unfortunately over the years it hasn't been able to grab anyone at Facebook's attention who might know how to resolve it and community efforts haven't uncovered the source either. Some people have luck using react-native-fast-image or the new expo-image both of which use glide instead of fresco for handling the images on android.
It's a really difficult bug to deal with if you need to render high resolution images on Android. What's more frustrating is that everything works perfectly on iOS. At this point however after ~5 years of this bug being reported with no fix I think it's safe to say it's in the "won't fix" category and you're better off trying a workaround.

Comment on the new Expo Image prop: https://github.com/facebook/fresco/issues/2397#issuecomment-1527009797

I had a look and I can only see this PR https://github.com/facebook/fresco/pull/2500 which aims to solve the low quality issue here: https://github.com/facebook/fresco/issues/2397 but I haven't tried it yet.
This issue is very critical since images on Android is the only platform that has this very low quality images.
If anyone has any update or workaround, this would be very welcome.

@evelant Looks like this is making some progress here that might lead to this issue being resolved on fresco's side. https://github.com/facebook/fresco/pull/2500

Not sure if this is resolved or not yet

I’ve been trying to resolve the same issue in my app for days and thought I’d used some weird scaling, saved some sanity finding this. Anyone have any fixes at all? Even work around? Did a different format work for anyone? I’ve not found anything related


feat: CloseConn to end connection with the route

Also removed useless code from request params to gain more performance

@megatank58 review


What git version is hex version 1.0.6 based upon?

I see there's a 1.0.6 in hex but the corresponding github tag is missing. Maybe this tag needs to be created ?

Thanks for pointing this out, it points to 8767b823b6f73f60da97fad184deb20f69d0e3b9 - pushed the tag.


Rewrite purge-cluster playbook

Rewritten purge-cluster playbook.
Tested with Ceph Hammer and Infernalis on CentOs 7 and Ubuntu 14.04 with Ansible <IP_ADDRESS>

@KGoreczny thanks for this :) just a few comments :)

I'm a little bit hesitant since this only supports ansible v2. (because of the package module).

Thanks @KGoreczny for addressing the comments.


fixe stdClass bug in MysqlAdapter

fixe bug, when $column is a stdClass instead of an Array

When using the PDO driver with the following attribute:
(PDO :: ATTR_DEFAULT_FETCH_MODE, PDO :: FETCH_OBJ);
and that in the phinx configuration we use a connection to a pdo instance with this attribute, this generates some bugs: "can not use stdClass as an Array" I thought it would affect two or three phinx files but I realize that no..
my pull request was a fast fixed, I cross that we must review that (the attributes of the instance of pdo when using phinx with a connection)

A fix would be to set the correct attribute when creating the adapter object


[Suggestion] Add the original command line when Rclone has finished ?

Dear all,
Could it be possible to add the original command line when Rclone has finished its job ?
I am asking this because I run several instances on of my VPS with many different paths and after a moment I don't remember what exact path has just finished running !
Example : Rclone has finished its job :
2016/11/03 08:22:10
Transferred:   10.862 GBytes (4.794 MBytes/s)
Errors:                 0
Checks:                 0
Transferred:           46
Elapsed time:    38m39.9s
Would become something like:
2016/11/03 08:22:10
Original Command line executed : rclone  copy AD:'Photos/' GD:'Photos/'
Transferred:   10.862 GBytes (4.794 MBytes/s)
Errors:                 0
Checks:                 0
Transferred:           46
Elapsed time:    38m39.9s
Thanks in advance ;)

Excellent idea - I have the same problem when people sent me logs!  It would probably only appear with the -v flag though.

This is done in
http://beta.rclone.org/v1.35-128-g86cc9f3/ (uploaded in 15-30 mins)


Suggestion - Manual Software Update entry/pull

My car updated software while Teslamate was offline for some reason.  As a result, it shows previous software version for the car and I see no way to force it to check for new software and believe it will show the incorrect software version until the next software update takes place.  Any way to create an option to manually update the software?

I've gone through 2 software updates since installing TeslaMate and it has failed to pickup both of them.

I assume you're referring to the Overview Dashboard which display the previous software version? The web interface will always display the currently installed version. I would recommend reading the version from there if the logger did not notice the installation of an update.

Yeah, it is correct there but is there a way to debug why it doesn't update in the Overview Dashboard. I'm finding other stuff is not updating there either like current temp etc. Some do, some don't.

The overview dashboard was added later, although Grafana is actually intended for historical data. It can only display data that is stored in the database. The web interface on the other hand always shows the current data.
After logging in with the default admin user you can debug the dashboard e.g. by editing SQL queries.

I'll take a look there and do some debugging when I get a chance. However, isn't the interface updating the DB with latest internal car temp etc? It seemed to show that on the Overview page up to just recently.


remove_message does not store any pointer to x0

On OTP 20 erlang compiler generates following code:
{get_tuple_element,{x,0},1,{x,0}}.
remove_message.

x0 is clearly still used and it shouldn't be overwritten by
remove_message, also in msg_instrs.tab only loop_rec has
r(0) = ERL_MESSAGE_TERM(msgp);

This is based on an empirical observation, I might be wrong, but it looks like the best explanation.


Custom color classes not being loaded in view and @apply directives

Version @nuxtjs/tailwindcss v4.2.1
tailwindcss v2.2.16
postcss v8.3.8
nuxt v2.15.8
Question
I run a nuxtjs setup with @nuxtjs/tailwindcss. I've tried to add custom colors
In my tailwind.config.js
module.exports = {
  mode: 'jit',
  theme: {
    colors: {
      'blue-hover': '#6133BD',
      "spaceblack":"var(--color-space-black)"
    },
  },
};

In @/assets/css/tailwind.css
:root {
    --space-black: #191B24;
}
@tailwind base;
@tailwind components;
@tailwind utilities;

When I try to apply the classes in vue, my visual studio code suggests the classes and their styles
.bg-spaceblack {
    background-color: var(--color-space-black);
}
.bg-blue-hover {
    --tw-bg-opacity: 1;
    background-color: rgba(97, 51, 189, var(--tw-bg-opacity));
}

But when I add them to elements, they don't receive the style, and if I use apply, I get an error
The `bg-spaceblack` class does not exist. If you're sure that `bg-spaceblack` exists, make sure that any `@import` statements are being properly processed before Tailwind CSS sees your CSS, as `@apply` can
only be used for classes in the same CSS tree.

I've read the documentation and tried everything I've seen online but it doesn't seem to work.
Pls Help!! 😢

Link to sandbox
the blue-hover class from nuxt.config.js > tailwind > theme > colors didn't get the custom class of bg

Link to sandbox the blue-hover class from nuxt.config.js > tailwind > theme > colors didn't get the custom class of bg

There were a couple of issues in your sandbox that I've addressed here: https://codesandbox.io/s/laughing-butterfly-whl0b?file=/nuxt.config.js:301-315

Your theme should go inside the config property: https://tailwindcss.nuxtjs.org/options#config
Your custom colors should be inside of extend if you expect to be able to apply Tailwind's default styles

Make sure to provide the paths where the JIT engine should look for classes https://tailwindcss.com/docs/just-in-time-mode#enabling-jit-mode (not an issue on your sandbox but it may be on your project)

Link to sandbox the blue-hover class from nuxt.config.js > tailwind > theme > colors didn't get the custom class of bg

There were a couple of issues in your sandbox that I've addressed here: https://codesandbox.io/s/laughing-butterfly-whl0b?file=/nuxt.config.js:301-315

Your theme should go inside the config property: https://tailwindcss.nuxtjs.org/options#config
Your custom colors should be inside of extend if you expect to be able to apply Tailwind's default styles

Make sure to provide the paths where the JIT engine should look for classes https://tailwindcss.com/docs/just-in-time-mode#enabling-jit-mode (not an issue on your sandbox but it may be on your project)

Thanks for your help


Clicking on Next or Prev button i get error on Android

Which OS ?
Android
Version
Which versions are you using:

react-native-swiper v 1.5.13
react-native v0.?.?

Expected behaviour
Navigate to the next page
Actual behaviour
Error
undefined is not a function ( evaluating ;_this.scrollViewanimated > 'setPage':'setPageWithoutAnimation'')
How to reproduce it>
To help us, please fork this component, modify one example in examples folder to reproduce your issue and include link here.
Steps to reproduce

set showsButtons={true}
click on Next or Prev button
you will see the error

Hi, have you found a solution to this problem?

Any updates here?

this worked for me on both ios/android:
_onMarkerPressed = e => {
    this.state.selectedId = e._targetInst.return.key

    const markerIndex = this.state.markers.findIndex(
      m => m.placeInfo.place_externalid === e._targetInst.return.key
    );

    this.previewPager.setPageWithoutAnimation(markerIndex);
  }

what did work on iOS but NOT on android:
_onMarkerPressed = function(e) {
    this.state.selectedId = e._targetInst.return.key

    const markerIndex = this.state.markers.findIndex(
      m => m.placeInfo.place_externalid === e._targetInst.return.key
    );

    this.previewPager.setPageWithoutAnimation(markerIndex);
  }.bind(this)


Docker compose

Also I'm not sure that re-exposing the environment variable is relevant ?

Thanks for you contribution :tada:


"in x" and "in ... x.keys()" behaving differently on dictionary, also debugger shows null even though it has data

Godot version
3.5.stable
System information
Linux (Fedora 36, 64 bit)
Issue description
My GDScript code produces different results when checking the presence of a key in a dictionary using in directly or on the keys() array.
Unfortunately, this happens only with a complex dictionary built dynamically after loading JSONs from a service, if I recreate a small dictionary to reproduce the bug it disappears. Also, the debugger shows the dictionary as [null] but it has data inside, seems the issue https://github.com/godotengine/godot/issues/36801 but I can reproduce it all the time.
This is the code:
print("tileset_textures: ", tilesets_textures)
if not gid in tilesets_textures[candidate_gid]["animations"]:
	print("cannot find gid: ", gid)
	print("visible animations:", tilesets_textures[candidate_gid]["animations"])
	print("check using in: ", gid in tilesets_textures[candidate_gid]["animations"])
	print("check using in keys(): ", gid in tilesets_textures[candidate_gid]["animations"].keys())

	for k in tilesets_textures[candidate_gid]["animations"].keys():
		print("type of ", k, " is ", typeof(k))
		print("equality check ", k == gid)

the output is:
tileset_textures: {1:{animations:{}, calculated_size:1536, image_height:3072, image_width:512, texture:[ImageTexture:1292], tile_height:32, tile_width:32}, 1537:{animations:{1539:[{duration:150, gid:2248}, {duration:150, gid:2264}, {duration:150, gid:2347}, {duration:150, gid:1549}]}, calculated_size:1024, image_height:2048, image_width:512, texture:[ImageTexture:1295], tile_height:32, tile_width:32}}
cannot find gid: 1539
visible animations:{1539:[{duration:150, gid:2248}, {duration:150, gid:2264}, {duration:150, gid:2347}, {duration:150, gid:1549}]}
check using in: False
check using in keys(): True
type of 1539 is 3
equality check True

I printed the types because I assumed it was a type error (the dictionary is built from a JSON), but it's an integer and as you can see the check gives different results when done using keys() and the dictionary itself, and the debugger doesn't show the content of the dictionary at all.
If I just replace the check with in .... .keys() I get errors later because the key is not found. It seems the key is visible when using .keys() but not when using in on the dictionary itself.
Steps to reproduce
Unfortunately I could not pinpoint where the bug happens, when creating a small test dictionary it disappears, but can be reproduced adding the JSONs of the project
The procedure is this:

clone the reference game, essentially a set of Tiled maps:
git clone git@github.com:jacopofar/reference_game.git

start a web server in the folder python3 -m http.server, will listen at port 8080

start the scene MapFromJSON in the Godot project. It will download a few JSONs from the server and rebuilt the Tiled map using sprites. That's when the issue above happens, specifically when trying to reconstruct an animated tile

Minimal reproduction project
load-tiled-world.zip

A potential cause is that your id is sometimes float and sometimes int. And numbers parsed from JSON are always float. Comparing equality of floating-point values are risky.
When adding elements into the animations dictionary, changing the key from int(tile_extra_metadata["id"]) + firstgid into int(tile_extra_metadata["id"] + firstgid) seems to fix the issue.
But yeah, in dict should be equivalent to in dict.keys() anyway.

But yeah, making in dict equivalent to in dict.keys() is more natural probably.

Definitely.

Thanks @timothyqiu , indeed changing the line 33 into var firstgid = int(tileset["firstgid"]) to cast the key to int did eliminate the issue. And thanks for the explanation, it would have been hard to figure out.
Strange behavior, usually the hash for values that are equal is the same, I guess the equality in GDScript is something similar to Javascript ==.
Also I found out that print in Godot hides the decimals in float values, so print(float(3.0)) and print(int(3.0)) both show 3, while float maybe should be something like 3.0 to mark the difference. I found it's an issue already discussed here https://github.com/godotengine/godot-proposals/issues/1693
The attached files can still be used to reproduce the issue with the debugger

I guess the equality in GDScript is something similar to Javascript ==.

GDScript is a strongly typed language, so no, it's not intended to work like JavaScript's ==.

I cannot reproduce this bug anymore at least in the last 3 betas 12, 13 and 14.

Thanks, closing as fixed then.


appflowy: Add Version 0.0.4

appflowy tops 1st in GitHub Trending today
AppFlowy is an open-source alternative to Notion. You are in charge of your data and customizations. Built with Flutter and Rust.
24k stars
https://github.com/ScoopInstaller/Main/pull/3770

[x] I have read the Contributing Guide.

/verify


CNV-40344: Make expanded sections indented as expected

📝 Description
Fixes:
https://issues.redhat.com/browse/CNV-40344
Our console folks broke our css by using !important, which is not a good practice, exactly here:
https://github.com/hstastna/console/blob/master/frontend/packages/console-shared/src/components/getting-started/GettingStartedExpandableGrid.scss#L58
Hence, to fix broken expandable sections in our UI, we must use !important, too.
🎥 Screenshots
Before:
Sections in Overview settings not indented at all:

After:

@avivtur @pcbailey @upalatucci @metalice please review

/cherry-pick release-4.16


Port remaining tests to new test infrastructure.

OpTestSensors
Signed-off-by: Pridhiviraj Paidipeddi<EMAIL_ADDRESS>

This change is

Merged up to d1efe38e807b1dc33a315fe8e571a1d2bf4d69b4 (HMI fix mulfunction alert test case) (with minor modifications) as of fa0919a9915c99dd7f8167fef9a62406a03669c6


HydroClient - Plotted Results Table - ii.	Correctly ORs Keywords selections (Biological, Chemical, Physical) but does not match keyword values exactly

Steps to reproduce
Expected Behavior
Positive Test Case
Please include a publicly available URL to view the work.
Also, please provide step by step instructions on how to properly test this.

Go to _
link
_
Click on xxx and yyy
Note that [specific thing] happens, whereas in the past [other specific thing] happens.
Actual Behavior

ii.	Correctly ORs Keywords selections (Biological, Chemical, Physical) but does not match keyword values exactly
a.	Open the HydroClient QA web site (http://qa-hiswebclient.azurewebsites.net/) – wait for the initial search to complete
b.	Enter location: Boston, MA.  Wait for map to display new location
c.	Click the ‘Search Now’ button.  Wait for search and point plotting to complete
d.	Open the ‘Filter Results’ Dialog
e.	Under ‘Keywords’ select:
i.	Biological, Biological community, Pigment, Chlorophyll:

chlorophyll a: 38
ii.	Chemical, Nutrient, Nitrogen:
nitrogen, nh4: 31
nitrogen, total: 23
iii.	Chemical, Oxygen Demand
Biochemical oxygen demand: 14
f.	Expected Behavior: Plotted Results Table displays 106 filtered results
g.	Actual Behavior: Plotted Results Table displays 127 filtered results
i.	Filtered results erroneously included:
nitrogen, total dissolved: 16
nitrogen, total kjeldahl: 5


Code cell font size issues

Using iOS safari, some code cells rendering problems appear. The font size seems not coherent.
Some screenshots below

@sdesrozis can you check on another browser if this also happens ?

@sdesrozis can you check on another browser if this also happens ?

Same issue using Chrome, Firefox and Safari on iOS 14.7.1 iPhone XS Max

@sdesrozis can you kindly check code blocks in  https://deploy-preview-78--pytorch-ignite.netlify.app/blog/introduction/ display correctly?

@sdesrozis can you kindly check code blocks in  https://deploy-preview-78--pytorch-ignite.netlify.app/blog/introduction/ display correctly?

@ydcjeff Everything looks pretty good. The rendering is very elegant and I didn't figure out any problem.


Fix modmail stream doc

(cherry picked from commit 09d71ae266aee6139387965afb0e6a0ba4eb1952)
References

https://github.com/praw-dev/praw/pull/1566

Pull Request Test Coverage Report for Build 1eaf327749b8960918e719a692e23ce0ab1bae3b-PR-31

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build be588a46712d1fb854c5eb03de0f45984fbd8134:
0.0%

Covered Lines:
3508

Relevant Lines:
3508

💛  - Coveralls

Pull Request Test Coverage Report for Build 1eaf327749b8960918e719a692e23ce0ab1bae3b-PR-31

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build be588a46712d1fb854c5eb03de0f45984fbd8134:
0.0%

Covered Lines:
3508

Relevant Lines:
3508

💛  - Coveralls


Documentation: Could improve

The readme.md file gives a basic overview, I'd like to see a more in depth explanation of all commands, permissions and the config file.
You could use the feature on github called "wiki", which is made for such tasks :).

Documentation provided, thanks :)

Oh great! 👍


[FLINK-31128] Add Create Table As for flink table store

Add Create Table As for flink table store

Thanks @zhangjun0x01 , at present, the biggest problem with CTAS is that it cannot specify the primary key and partition column, which makes it almost unavailable for production. Or can we consider supporting them?

ok。I will add the functions later .

Thanks @zhangjun0x01 , at present, the biggest problem with CTAS is that it cannot specify the primary key and partition column, which makes it almost unavailable for production. Or can we consider supporting them?

@zhangjun0x01 The core problem is that Flink SQL CTAS dose not support pk partition key declaration, Maybe we can provide options for primary key and partition key just like Spark Create table for table store. What do you think?

Thanks @zhangjun0x01 , at present, the biggest problem with CTAS is that it cannot specify the primary key and partition column, which makes it almost unavailable for production. Or can we consider supporting them?

@zhangjun0x01 The core problem is that Flink SQL CTAS dose not support pk partition key declaration, Maybe we can provide options for primary key and partition key just like Spark Create table for table store. What do you think?

I test it in hive , it also do not support the function , I didn't find a reference . One way to implement this function is to add options as you said. The other is to modify the SqlCreateTableAs parse syntax and add primary key and partition support.

Thanks @zhangjun0x01 , at present, the biggest problem with CTAS is that it cannot specify the primary key and partition column, which makes it almost unavailable for production. Or can we consider supporting them?

@zhangjun0x01 The core problem is that Flink SQL CTAS dose not support pk partition key declaration, Maybe we can provide options for primary key and partition key just like Spark Create table for table store. What do you think?

I test it in hive , it also do not support the function , I didn't find a reference . One way to implement this function is to add options as you said. The other is to modify the SqlCreateTableAs parse syntax and add primary key and partition support.

Yes, I don't think we expose documentation before support pk and partition definition.

Thanks @zhangjun0x01 , at present, the biggest problem with CTAS is that it cannot specify the primary key and partition column, which makes it almost unavailable for production. Or can we consider supporting them?

@zhangjun0x01 The core problem is that Flink SQL CTAS dose not support pk partition key declaration, Maybe we can provide options for primary key and partition key just like Spark Create table for table store. What do you think?

I test it in hive , it also do not support the function , I didn't find a reference . One way to implement this function is to add options as you said. The other is to modify the SqlCreateTableAs parse syntax and add primary key and partition support.

Yes, I don't think we should expose documentation before support pk and partition definition.

hi,@JingsongLi , I add the primary key and partition support follow your comment

It seems that some comments are not solved. @zhangjun0x01

hi,@JingsongLi ,I updated the comment,but I run the failed UT org.apache.flink.table.store.file.operation.FileStoreCommitTest in my computer, it is fine,


tutorial dummies webchat starter

[Question]
I people, im so new on botframework, i am developer junior, I embebed the bot in the iframe default of web channel, i need embebed the bot andI need to pass information to validate the origin of whom I invoke the bot but i dont understand the the samples someone have a dummy tutorial
thans

Hi @joseali93, my recommendation is that you start with the first samples (01.a, 01.b, 02.a, etc), which are level 101 for implementing Web Chat. All you have to do is copy-paste the HTML and a little bit of JavaScript. The samples increase in difficulty as you increase the number, so starting at the beginning may be a good spot for you.
Otherwise, this repository is intended for users to file feature requests and bugs they find. We do not have the capacity right now to teach everyone who wants to learn Web Chat from the beginning. If you need support and have guided questions you want to ask, I recommend taking your questions to Stack Overflow. Please feel free to post other questions you have about developing your own features over there so the community at large may help out. If you need help with a Web Chat implementation, you can post a question to the Web Chat tag. Not that our team has Support Engineers that check Stack Overflow every day and can help with implementation questions. Thank you!


setup gh-pages branch

This creates a branch for publishing to GitHub pages. I removed all files that are not relevant for publishing. For testing there are two notebooks that can be accessed via the qutip.github.io/qutip-tutorials/notebooks/notebookname.ipynb.
These will be overwritten by the CI pipeline for the notebooks  (see PR #7 ).

I think we can perhaps avoid this PR entirely and just use https://github.com/c-w/ghp-import. I can create an empty orphan gh-pages branch here when the build PR is ready.

Okay, I will take a look into ghp-import and close this PR. Thanks for the hint!


Compiles in Swift 3

Jay is now using the 07-25 toolchain, which works with Xcode 8 beta 3. The changes you made are back to the old way of doing things. Which Swift version are you looking to support? I'm sure there's an older Jay release that supports it.

@czechboy0 I'm using the one here https://github.com/swiftdocker/docker-swift/blob/master/Dockerfile
Is this the most up to date one.

It seems the Dockerfile is at least two Swift versions behind. The latest is DEVELOPMENT-SNAPSHOT-2016-07-25-a.

@czechboy0  Many thanks, I shall update and PR to that one.


Need to Update Message to Users About Setting CIFS Version

Tried to mount a share folder on my Synology NAS. Got the "mount error(95): Operation not supported" error when running setup-teslausb. Message to the user suggest this: "

Try specifying a lower number for the CIFS version like this: export cifs_version=2

This actually doesn't work. I suggest changing this to:

Try specifying a lower number for the CIFS version like this: export cifs_version=2.0

This works.
I'm a h/w guy and this is my first time really on github... If it's alright with you guys, I would like to try my hand at contributing with this minor change. Would I just open a pull request? Sorry for being a total newb.

@rtgoodwin 👍 That was super-helpful for me. Thank you. I think I've got the PR done.
I'll stick with web editing for now. I tried git from command line about 10 years ago. Boy, I'm old...

Okay, I thought I did the right thing, but now I'm not so sure... I don't see my pull request here on cimryan/teslausb. I only see a pull request on ken830/teslausb.

Merged!


Freeing customers from managing cluster bases themselves

As a customer platform engineer, I do not want to manage cluster bases so I can focus on delivering projects

this is been working on currently and should be done within Q2

Removing it from custoemr requests, this is a general roadmap item now.


Add Shoukaku to Client Libraries

Shoukaku is a Discord.js lavalink client purely made for Discord.js v12

I would like to put this on hold as long as your library is still in alpha

The library is now usable. Documentation and example codes are also now provided.


Image includes do not seem to be included in non-default branches

I have a master as my default branch
I push up some .adoc with some image::[] blocks and some .pngs to my-branch
I view the new rendered page

the images do not seem to be included in the rendering of my-branch.
It looks like they are only included when merged into the default branch.

Which plugin and Bitbucket version do you use?

I have tried it with the latest version of the plugin and the latest version of Bitbucket and I can't reproduce the issue. Can you doublecheck that all files have been pushed/merged correctly?

@christiangalsterer sorry, I haven't look back at this but will check again today.

Sorry for taking so long to get back to you, I don't think I described the issue well so hopefully the steps below clarify the issue
Here are the steps I followed locally using the atlas-run-standalone -p 7990 --context-path / --version 4.10.0 --product bitbucket and testing with https://github.com/asciidoctor/jekyll-asciidoc.

Run atlas-run-standalone -p 7990 --context-path / --version 4.10.0 --product bitbucket

Login with admin/admin

Install the 2.3.1 version

Create a repository

Clone down https://github.com/asciidoctor/jekyll-asciidoc, change upstream
 git clone https://github.com/asciidoctor/jekyll-asciidoc.git
 cd jekyll-asciidoc
 git remote set-url origin http://admin@localhost:7990/scm/project_1/my-repo.git

Checkout out new branch
 git checkout -b issue-12-repro

Download an image
 curl https://www.brandeps.com/logo-download/B/Bitbucket-01.png -o bitbucket-logo.png

Make a tweak to the README.adoc to use include::[] macro.
 == Overview

 Here is the Bitbucket logo!

 image::bitbucket-logo.png[]

Add, commit, and push
 git add README.adoc bitbucket-logo.png

Preview a pull request to the master branch (http://localhost:7990/projects/PROJECT_1/repos/my-repo/compare/commits?sourceBranch=refs/heads/issue-12-repro)

Select the "full source" button

See broken image on page

Hi @mkobit,
thank you very much for the detailed description. I was now able to reproduce the issue. The problem is that the link is created against the configured default branch.
I will look into it and will have a fix hopefully soon.

The fix is included in the new version 2.3.2 available in the Atlassian Marketplace.


Missing operator when using PyTorch Lightning

Hi everyone,
I've got the following issue when trying to quantize a PyTorch Lightning object detection model (based on the yolo architecture):
NotImplementedError: Could not run 'aten::cat.out' with arguments from the 'QuantizedCUDA' backend. This could be because the operator doesn't exist for this backend, or was omitted during the selective/custom build process (if using custom build). If you are a Facebook employee using PyTorch on mobile, please visit https://fburl.com/ptmfixes for possible resolutions. 'aten::cat.out' is only available for these backends: [CPU, CUDA, Meta, QuantizedCPU, BackendSelect, Python, FuncTorchDynamicLayerBackMode, Functionalize, Named, Conjugate, Negative, ZeroTensor, ADInplaceOrView, AutogradOther, AutogradCPU, AutogradCUDA, AutogradHIP, AutogradXLA, AutogradMPS, AutogradIPU, AutogradXPU, AutogradHPU, AutogradVE, AutogradLazy, AutogradMeta, AutogradPrivateUse1, AutogradPrivateUse2, AutogradPrivateUse3, AutogradNestedTensor, Tracer, AutocastCPU, AutocastCUDA, FuncTorchBatched, FuncTorchVmapMode, Batched, VmapMode, FuncTorchGradWrapper, PythonTLSSnapshot, FuncTorchDynamicLayerFrontMode, PythonDispatcher].
It happens when I use CUDA during the testing phase, once the quantization is done. I also tried to run Intel Neural Compressor with the CPU but this time my mean average precision is not computed (really strange since the code doesn't even go in the evaluation function.
Thanks in advance for any help!

Hi @mlnmk The error is because that you are trying to pass a quantized tensor to a non-quantized kernel. It comes from the gap of int8 kernel set between CPU and GPU. Therefore, it's recommended to use CPU for both quantization and inference. As for your precision issue, I cannot provide suggestions without more details. Thanks.

Close the ticket since no further feedback, please feel free to re-open if you still have the same issue.


Add new moderator review option

Rationale
Add a new moderator review option that allows Authors to respond to a thread  but not start a new thread. This will be useful when we convert the Panorama Public support board to a secure message board.  On this message board submitters should be able to respond, without moderator review, to posts that are automatically added when they submit their data to Panorama Public.   They should not be able to start new threads, however.
Related Pull Requests

https://github.com/LabKey/platform/pull/3735

I've mirrored the feature branches and queued the updated test:
https://teamcity.labkey.org/buildConfiguration/LabKey_2211Release_Community_DailySuites_DailyCPostgres?branch=vs_secure-message-new-option&buildTypeTab=overview&mode=builds


Update CI-related stuff to new versions.

This updates our generated requirements.txt files and the various tools we use in pre-commit to the latest versions. There is no runtime change; this only affects what we use in testing and static analysis.

(this is also intended to shut up a dependabot thing)


🐞 [Bug]: Error while listing contracts: Unexpected end of JSON input is keep happening randomly in my contracts page

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?
Dashboard
What happened?
This issue happened to too many times and to multiple people, but the reason of reproducing is unknown.
I added screenshots from 2 different devices and logs, if it can help identify the reason.
Steps To Reproduce
No response
which network/s did you face the problem on?
Dev
version
184fa12
Twin ID/s
No response
Node ID/s
No response
Farm ID/s
No response
Contract ID/s
No response
Relevant screenshots/screen records

dashboard.log
Relevant log output
`Error while listing contracts: Unexpected end of JSON input`

duplicate issue of


M3-1845 fix to linodeCard loader

loader when loading/rebooting a linode ion the card view had a regression. this fixes it

Coverage remained the same at 30.548% when pulling a8b6411f1ab6ad19db54bf3efc1173fa656647f6 on alioso:M3-1845 into 89f12d2a824f6cf5ff5ecd1cd28f3f1f13df4076 on linode:release-0.39.0.


cgroups under some controllers are not cleaned up after rkt pods exit

Environment
rkt Version: 1.4.0+gitb7589f9
appc Version: 0.7.4
Go Version: go1.5.3
Go OS/Arch: linux/amd64
Features: +TPM
Distro: CoreOS, Ubuntu, Gentoo
What did you do?
Run rkt pods via systemd service and cmd line:
$ cat /run/systemd/system/test-rkt.service
[Service]
ExecStart=/tmp/rkt --insecure-options=image,ondisk run docker://busybox

$ sudo systemctl start test-rkt.service

$ sudo systemctl status test-rkt.service
$ sudo systemctl status test-rkt
● test-rkt.service
   Loaded: loaded (/run/systemd/system/test-rkt.service; static; vendor preset: enabled)
   Active: inactive (dead)

Apr 25 16:48:28 yifan-coreos rkt[16101]: networking: loading networks from /etc/rkt/net.d
Apr 25 16:48:28 yifan-coreos rkt[16101]: networking: loading network default with type ptp
Apr 25 16:48:29 yifan-coreos systemd[1]: Stopped test-rkt.service.
Apr 25 17:04:51 yifan-coreos systemd[1]: Started test-rkt.service.
Apr 25 17:04:51 yifan-coreos systemd[1]: Starting test-rkt.service...
Apr 25 17:04:51 yifan-coreos rkt[16794]: image: using image from local store for image name coreos.com/rkt/stage1-coreos:1.3.0+gitb7589f9
Apr 25 17:04:51 yifan-coreos rkt[16794]: image: using image from local store for url docker://busybox
Apr 25 17:04:52 yifan-coreos rkt[16794]: networking: loading networks from /etc/rkt/net.d
Apr 25 17:04:52 yifan-coreos rkt[16794]: networking: loading network default with type ptp
Apr 25 17:04:52 yifan-coreos systemd[1]: Stopped test-rkt.service.

What did you expect to see?
We should see cgroups under all controllers are removed after the pod exits
What did you see instead?
$ find -name test-rkt.service
./freezer/system.slice/test-rkt.service
./hugetlb/system.slice/test-rkt.service
./blkio/system.slice/test-rkt.service
./memory/system.slice/test-rkt.service
./cpu,cpuacct/system.slice/test-rkt.service
./net_cls,net_prio/system.slice/test-rkt.service
./perf_event/system.slice/test-rkt.service
./cpuset/system.slice/test-rkt.service

Besides, if I run the rkt using cmd line, the cgroups are not cleaned up as well:
$ rkt --insecure-options=image,ondisk run docker://busybox --exec=/bin/echo -- hello
image: using image from file /home/yifan/bin/stage1-coreos.aci
image: using image from local store for url docker://busybox
networking: loading networks from /etc/rkt/net.d
networking: loading network default with type ptp
[20286.946506] echo[4]: hello
$ ls /sys/fs/cgroup/perf_event/machine.slice/ $ ls -l /sys/fs/cgroup/perf_event/machine.slice/
total 0
-rw-r--r-- 1 root root 0 Apr 26 00:39 cgroup.clone_children
-rw-r--r-- 1 root root 0 Apr 26 00:39 cgroup.procs
drwxr-xr-x 3 root root 0 Apr 26 00:45 machine-rkt\x2d21be894b\x2d5b2c\x2d4072\x2dbd7a\x2d8810107c5ade.scope
-rw-r--r-- 1 root root 0 Apr 26 00:39 notify_on_release
-rw-r--r-- 1 root root 0 Apr 26 00:39 tasks

But, on ubuntu (with systemd 216 on host), running through cmd line works fine. The cgroups get cleaned up after the pods exit.

Interesting that /sys/fs/cgroup/systemd gets cleaned up but not the other subsystems.

I did an strace and noticed a series of rmdir("/sys/fs/cgroup/cpu/machine.slice/machine-rkt$UID.scope/system.slice/opt-stage2-busybox-rootfs-sys-fs-cgroup-freezer.mount") = -1 EROFS (Read-only file system) errors. I'm not certain it's related, but it seems quite plausible it is.
Manually running the rmdirs that  errored out as such after the fact does succeed.

We should check if the same behavior happen with systemd-nspawn (without rkt). The "cpu" subsystem is mounted read-only by systemd-nspawn.
It looks similar to:
https://bugs.freedesktop.org/show_bug.cgi?id=68370

It doesn't appear to leak with just nspawn.
I have an alpine linux rootfs and did the following ...
$ lscgroup | wc -l
488
# Terminal 2
$ sudo systemd-nspawn
tmp-alpine:~#
# Terminal 1
$ lscgroup | wc -l
493
# Kill alpine
$ lscgroup | wc -l
488

To clean up empty cgroup directories, systemd sets the knobs notify_on_release to 1 and release_agent to /usr/lib/systemd/systemd-cgroups-agent in /sys/fs/cgroup/systemd. With these knobs set, when the last task of a cgroup leaves and the last child cgroup of that cgroup is removed, the binary specified in release_agent gets called with the pathname of the abandoned cgroup as a parameter (see cgroups.txt). Then, systemd-cgroups--agent deals with removing the empty cgroups.
This is only done for the systemd cgroup hierarchy, systemd-nspawn doesn't touch anything under the container cgroup subtree for other hierarchies so that's enough.
However, rkt does create cgroups under the container cgroup subtree which never get removed because notify_on_release is set to 0 and release_agent is empty for the hierarchies that are not systemd.
While notify_on_release appears in every cgroup directory, release_agent is only present in the root of the hierarchy, so setting that to some sort of rkt-release-agent seems too invasive.
Is cleaning up the cgroups something we really need?

I read a bit more and

While remounting cgroups is currently supported, it is not recommend
to use it. Remounting allows changing bound subsystems and
release_agent. Rebinding is hardly useful as it only works when the
hierarchy is empty and release_agent itself should be replaced with
conventional fsnotify. The support for remounting will be removed in
the future.
To Specify a hierarchy's release_agent:

mount -t cgroup -o cpuset,release_agent="/sbin/cpuset_release_agent" \
xxx /sys/fs/cgroup/rg1
So I thought we could mount the cgroups inside the pod (or on the host in rkt's mount namespace) with a rkt release agent so it doesn't affect the rest of the system but it doesn't seem to work. Also, "it's not recommended".

@iaguis Thanks for the explanation :+1:  Then I think we should at least remove those cgroups when rkt gc and rkt rm

to answer the Q

Is cleaning up the cgroups something we really need?

yes for cadvisor as cadvisor sees them and with @philips idea https://github.com/google/cadvisor/issues/1255#issuecomment-216694222 we will see the cgroup and wait thinking its a rkt pod.

yes, its definitely a problem for cadvisor.
imagine we have a service that runs intermittently.  If its not running when cadvisor sees it originally, it will just use the raw cgroup handler (along with delaying startup).  So even when it comes up it wont provide all the information one expects.  Also, even if it starts correctly as a rkt handler, when the service ends, it will still be there as a rkt handler and hence will also be providing wrong information.

@iaguis is there a good reason that a release-agent is not set for every hierarchy?
or to rephrase, what's the problem if we set it, everything has notify_on_release set to 0 so nothing will change for them, it would only change for our stuff?

Is cleaning up the cgroups something we really need?

yes for cadvisor as cadvisor sees them and with @philips idea https://github.com/google/cadvisor/issues/1255#issuecomment-216694222 we will see the cgroup and wait thinking its a rkt pod.

Since @philips' idea requires to fetch the unit properties on dbus already, cadvisor could also get & monitor the unit status via dbus, and if the unit is stopped, then it knows it does not need to wait for the pid to appear. Would that work?

we'd never know if it restarted, as the inotify based system wouldn't help (working on an alternate system, but its a bit of surgery)

we'd never know if it restarted, as the inotify based system wouldn't help

cadvisor would need to register to dbus notifications when the unit is stopped & started.

cadvisor would need to register to dbus notifications when the unit is stopped & started.

that's seems more pain that its worth.  seemingly it be easier to just have a way to get notifications from the rkt api service about all the running pods.

so yea, I verified that if I restart a systemd unit after cadvisor started, it doesn't see it.  Then again, it never deleted it so it works but not correctly (i.e. not looking at right pid for networking stats and file system for disk stats).  Honestly it feels like a bug to not clean up cgroups right away

FWIW, this is causing kubelet/cadvisor to achieve super high CPU usage (~full cores) over the time because cadvisor keeps listing all those remaining cgroups.

we should configure cadvisor to use the dockerOnly flag (or soon to hopefully be runtimeOnly)

Capturing discussion from sync: initial action is to ensure we clean up these cgroups on rkt gc and/or rkt remove

/subscribe

Partially fixed by #2655. We'll leave this open for a possible fix without having to wait for GC.


Method Not Allowed when trying to fetch upstream's active targets

Summary
When i want to fetch upstream's active targets i have a 400 response METHOD NOT ALLOWED
https://getkong.org/docs/0.11.x/admin-api/#list-active-targets
Steps To Reproduce

curl http://kong:8001/upstreams/{id}/targets/active -X GET

Additional Details & Logs

Kong version (0.11)
Operating System Linux
If i add a / like this : curl http://kong:8001/upstreams/{id}/targets/active/ -X GET everything is ok, but not compliant with the documentation.
An hotfix has been merged before in this pull request #2307
The issue has been reintroduce by this pull request #2252

I too am seeing this behavior in Kong 0.11.  I have also implemented the workaround of appending a trailing /.  Thanks for filing this and for the workaround suggestion @cfajardo!


Document the 'TiffImages.load' keyword arguments

closes #16

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.53%. Comparing base (3f02e03) to head (4e9884e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   94.53%   94.53%
=======================================
  Files           7        7
  Lines         293      293
=======================================
  Hits          277      277
  Misses         16       16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Respect Scala 3 distinct module naming

Fixes https://github.com/coursier/coursier/issues/1999 (hopefully)

@przemek-pokrywka You need to open a PR with your updated metadata against https://github.com/coursier/test-metadata.

Thanks for your guidance @alexarchambault, will try in some free time bit later.

@przemek-pokrywka The error seems legit... I can have a look later, but feel free to fix it in the mean time if you'd like.

@alexarchambault are you sure that the coursier.test.CentralTests.forceScalaVersion.force.2.12.8 test case is still up to date? The reason I'm asking is that Coursier 2.0.12 ran manually resolves the new versions (not the ones hardcoded in the test expectations).
Here are the failing test logs:
Missing element com.lihaoyi:fansi_2.12:0.2.4
Missing element com.lihaoyi:pprint_2.12:0.5.2
Extra element com.lihaoyi:fansi_2.12:0.2.5
Extra element com.lihaoyi:pprint_2.12:0.5.3
Extra element org.scalameta:interactive_2.12.7:4.0.0
Extra element org.scalameta:semanticdb-scalac-core_2.12.7:4.0.0

(fansi 0.2.4 ---> 0.2.5, pprint 0.5.2 ---> 0.5.3, ...)
And here's what is the manual resolve returning:
$ cs resolve -r jitpack --scala-version 2.12.8 \
> sh.almond:scala-kernel_2.12.8:0.2.2 \
> org.scalameta:interactive_2.12.8:4.1.4 | grep -E \
> 'scalameta:semanticdb-scalac-core|org.scalameta:interactive|pprint|fansi'
com.lihaoyi:fansi_2.12:0.2.5:default
com.lihaoyi:pprint_2.12:0.5.3:default
org.scalameta:interactive_2.12.7:4.0.0:default
org.scalameta:interactive_2.12.8:4.1.4:default
org.scalameta:semanticdb-scalac-core_2.12.7:4.0.0:default
org.scalameta:semanticdb-scalac-core_2.12.8:4.1.4:default

@alexarchambault adding to the previous comment, the extra dependencies seem to be dragged in by:
├─ sh.almond:scala-kernel_2.12.8:0.2.2
[...]
│  ├─ sh.almond:kernel_2.12:0.2.2
[...]
│  │  └─ sh.almond:interpreter_2.12:0.2.2
[...]
│  │     ├─ org.scalameta:metabrowse-server_2.12:0.2.1
[...]
│  │     │  ├─ org.scalameta:interactive_2.12.7:4.0.0
│  │     │  │  ├─ com.lihaoyi:pprint_2.12:0.5.3
│  │     │  │  │  ├─ com.lihaoyi:fansi_2.12:0.2.5
│  │     │  │  │  │  ├─ com.lihaoyi:sourcecode_2.12:0.1.4 -> 0.1.5
│  │     │  │  │  │  │  └─ org.scala-lang:scala-library:2.12.6 -> 2.12.8
│  │     │  │  │  │  └─ org.scala-lang:scala-library:2.12.0 -> 2.12.8
│  │     │  │  │  ├─ com.lihaoyi:sourcecode_2.12:0.1.4 -> 0.1.5
│  │     │  │  │  │  └─ org.scala-lang:scala-library:2.12.6 -> 2.12.8
│  │     │  │  │  └─ org.scala-lang:scala-library:2.12.2 -> 2.12.8

(obtained with cs resolve --tree -r jitpack --scala-version 2.12.8 sh.almond:scala-kernel_2.12.8:0.2.2 org.scalameta:interactive_2.12.8:4.1.4)

@alexarchambault I think you were correct. CentralTest passes after the newest fix.

By the way, is it justified to keep two similar checks (if Scala 3 then ...) in two separate places?

By the way, is it justified to keep two similar checks (if Scala 3 then ...) in two separate places?

Not particularly... feel free to factor it if you'd like.

I would leave it as it is right now, thanks. I mostly asked for my understanding; I was curious if there was any plan behind that.
I'll appreciate it if the changes can be released. I'd be able to use them in TSK, for Scala 3 examples :smile:


force offline mode if not in background

I think this will do the trick without "dirty hack"

Does it concern #1097?

fixes #1097

Thanks. I'll try to test and merge before this week-end.

It's difficult to understand the new code IF sy-batch = abap_true AND io_salv->is_offline( ) = abap_false whose result is always false (I guess).
I did these tests, the test 1 fails with ABAP 7.52 SP 0, it ignores the layout changed by the user (need to run io_salv->get_metadata( ) to get the changed layout):

Display ALV, layout manually changed, then run abap2xlsx conversion
Prepare without displaying ALV, run abap2xlsx conversion
ALV data intercepted without displaying ALV, without any ALV default variant, then run abap2xlsx conversion
ALV data intercepted without displaying ALV, with an ALV default variant, then run abap2xlsx conversion
Run in background the tests 2 to 4

I have proposed another solution via the PR #1109 (waiting for abaplint fix https://github.com/abaplint/deps/pull/198 /cross check still running). It works both in ABAP 7.52 and ABAP 7.57.
Please tell me your view on that?


Purpose of robot.e.create()

@mosheBelostotsky I was following the documentation again for HE, and in here it says that you can use robot.e.create() to create listeners. From what I see, this looks like a replacement of the functionality that vanilla hubot robot provides. If I am correct, I think it would be good to discuss the purpose of this new method to create listeners. I was  thinking that, we might want to change hubot's way of doing things as little as possible, so that the usability, adoption, and transition of developers to enterprise would be easier. Considering that, perhaps extending the robot object / prototype by adding more functionality to respond() and hear() could be an alternative.

@rqc, very good question!
Why we need robot.e.create?

To standardize and uniform calls from UI/UX perspective as described in wiki.
To be able to create single structured help
To be able to "store" the call for reuse after Authentication done
To be able (in the future) to create one robot.hear that will handle all HE integration (I will tell you about this plan on Monday)
For HE to be able to perform tasks on HE integration calls before calling the actual function (like middle ware but with HE specific context)

If you raised this question I can assume that the wiki is still not clear enough, let's discuss  how we can improve the wiki on Monday.

@rqc, also, we cannot changing hubot original functions as hear and respond because it will effect non HE scripts.
Letting HE integrations use hear/create will lead to non uniform calls...

thanks, I will discuss it with you through slack.

The resolution is that, because of time constraints and design decisions already made, we won't be using a middleware approach for now (not overriding the hear and respond API), even though it is probably the most appropriate pattern for our purposes.
I am closing this for now.


bug: Side-specific border coloring with .xml values does not work

Describe the bug
Side-specific border coloring when making the UI with .xml does not work properly.
To Reproduce
Steps to reproduce the behavior:

Create a simple Basalt UI with .xml style
Add an object with a side-specific border coloring:

<button x="2" y="2" text="Hello" borderBottom="blue" />

Run the program
See error:
Basalt error: .../basaltDraw.lua:202: bad argument (string expected, got nil)

Expected behavior
A button with the text "Hello" should appear with a blue border only along the bottom
Additional context
Changing these four lines (138-141) in Object.lua seems to fix it! Just had to wrap the xmlValue(...) return with colors[...], like the other surrounding code does.
if(xmlValue("borderLeft", data)~=nil)then borderColors["left"] = colors[xmlValue("borderLeft", data)] end
if(xmlValue("borderTop", data)~=nil)then borderColors["top"] = colors[xmlValue("borderTop", data)] end
if(xmlValue("borderRight", data)~=nil)then borderColors["right"] = colors[xmlValue("borderRight", data)] end
if(xmlValue("borderBottom", data)~=nil)then borderColors["bottom"] = colors[xmlValue("borderBottom", data)] end

Checklist
[x] I am running the latest version.
Tick the box if you are running the latest version!

Hello! Thank you very much - also thanks for fixing it yourself and providing me the code! This issue got fixed in 6f0ddd6,


[Bug] Ray nightly causes flakiness for the detached actor test

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
ray-operator
What happened + What you expected to happen
https://github.com/ray-project/kuberay/actions/runs/6870943009/job/18693067076
Reproduction script
https://github.com/ray-project/kuberay/actions/runs/6870943009/job/18693067076
Anything else
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

I have already opened an issue in the Ray repository, which can be found here: https://github.com/ray-project/ray/issues/41343. The Ray Core team will address the issue, so I change the priority to P1.

#1694 skips the test_detached_actor test for Ray 2.8.0 and nightly builds. We will resume running this test in CI once https://github.com/ray-project/ray/issues/41343 is resolved.

https://github.com/ray-project/ray/issues/41343
#1775
#1770


[BESM4eExtras] Bug Fix

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

v1.7.7

Corrected Tough and Energized to increase Health and Energy Points by 10 points per level, respectively, and Social Mastery and Unassailable to increase Social and Sanity points by 2 points per level, respectively.

Character Sheet Info Roll20 Internal Use only.


Temporary endpoint is missing host name for Azure Service Bus

Contact Details
<EMAIL_ADDRESS>Version
8.x (develop, pre-release), 8.x
On which operating system(s) are you experiencing the issue?
Windows
Using which broker(s) did you encounter the issue?
Azure Service Bus
What are the steps required to reproduce the issue?
Incorrect endpoint naming for Azure Service Bus temporary endpoints. Host name is missing. Works fine for RabbitMQ.

1. Create new temporary endpoint e. g. cfg.ReceiveEndpoint(new TemporaryEndpointDefinition("temp_endpoint"), e => ...
2. Send message to this endpoint
3. Check debug logs
...

What is the expected behavior?
Endpoint should contain host name e. g.
sb://devbus1.servicebus.windows.net/endpoint_5ytoyy8dr54r7u7cbdpwqdrxdb?autodelete=300
What actually happened?
Instead no host name set and default host name is used instead
sb://no-host-configured/ConfigUpdateFault_5ytoyy8dr54r7u7cbdpwqdrxdb?autodelete=300
Related log output, including any exceptions
No response
Link to repository that demonstrates/reproduces the issue
No response

You must configure the Host before configuring any receive endpoints. Since you didn't post any code to reproduce the issue, this will be closed.

My issue was exactly as you mentioned. Host was configured after configuring endpoints. However this approach works fine with RabbitMQ, doesn't matter where Host is configured.
But anyway issue is resolved, thank you for support,