NMS support in XLA

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.3
Python version: 3.7.6
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): na
CUDA/cuDNN version: na
GPU model and memory: na

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
I saw the NMS implementation in tf2xla, but the op has not been registered yet via REGISTER_XLA_OP. I am wondering what is the status of nms support in xla, since it is a data dependent dynamic op, would love to see how dynamic output is handled by XLA.
Describe the expected behavior
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
import numpy as np
import tensorflow as tf
tf.compat.v1.enable_eager_execution()

# Non-Maximum Suppression
@tf.function(experimental_compile=True)
def test_nms():
    box_shape = (20, 4)
    score_shape = (20, )
    iou_threshold = 0.7
    score_threshold = 0.5
    out_size = 10
    dtype="float32"

    boxes = np.random.uniform(0, 10, size=box_shape).astype(dtype)
    scores = np.random.uniform(size=score_shape).astype(dtype)
    max_output_size = np.int32(out_size)
    in_data_1 = tf.constant(boxes, dtype, boxes.shape, name="in_data_1")
    in_data_2 = tf.constant(scores, dtype, scores.shape, name="in_data_2")
    in_data_3 = tf.constant(max_output_size, "int32", name="in_data_3")
    res = tf.image.non_max_suppression(boxes=in_data_1, scores=in_data_2, max_output_size=in_data_3,
                                       iou_threshold=iou_threshold, score_threshold=score_threshold, name="nms")
    return res

test_nms()

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
error message
nms/NonMaxSuppressionV3: unsupported op: No registered 'NonMaxSuppressionV3' OpKernel for XLA_CPU_JIT devices compatible with node {{node nms/NonMaxSuppressionV3}}
	Stacktrace:
		Node: __inference_test_nms_10, function:
		Node: nms/NonMaxSuppressionV3, function: __inference_test_nms_10
 [Op:__inference_test_nms_10]

On Tue, Sep 1, 2020 at 10:33 PM Yong Wu<EMAIL_ADDRESS>wrote:

Please make sure that this is a bug. As per ourGitHub Policy
https://github.com/tensorflow/tensorflow/blob/master/ISSUES.md,we only
address code/doc bugs, performance issues, feature requests
andbuild/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example
script provided in TensorFlow): No

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux
Ubuntu 16.04

Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue
happens on mobile device: NA

TensorFlow installed from (source or binary): binary

TensorFlow version (use command below): 2.3

Python version: 3.7.6

Bazel version (if compiling from source): NA

GCC/Compiler version (if compiling from source): na

CUDA/cuDNN version: na

GPU model and memory: na

You can collect some of this information using our environment capture
script
https://github.com/tensorflow/tensorflow/tree/master/tools/tf_env_collect.sh
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION,
tf.VERSION)"

TF 2.0: python -c "import tensorflow as tf;
print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
I saw the NMS implementation in tf2xla
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/tf2xla/kernels/image_ops.cc#L399,
but the op has not been registered yet via REGISTER_XLA_OP. I am wondering
what is the status of nms support in xla, since it is a data dependent
dynamic op, would love to see how dynamic output is handled by XLA.
Describe the expected behavior
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to
generate
the problem. If possible, please share a link to Colab/Jupyter/any
notebook.
import numpy as np
import tensorflow as tf
tf.compat.v1.enable_eager_execution()
Non-Maximum Suppression
@tf.function(experimental_compile=True)
def test_nms():
box_shape = (20, 4)

score_shape = (20, )

iou_threshold = 0.7

score_threshold = 0.5

out_size = 10

dtype="float32"

boxes = np.random.uniform(0, 10, size=box_shape).astype(dtype)

scores = np.random.uniform(size=score_shape).astype(dtype)

max_output_size = np.int32(out_size)

in_data_1 = tf.constant(boxes, dtype, boxes.shape, name="in_data_1")

in_data_2 = tf.constant(scores, dtype, scores.shape, name="in_data_2")

in_data_3 = tf.constant(max_output_size, "int32", name="in_data_3")

res = tf.image.non_max_suppression(boxes=in_data_1, scores=in_data_2, max_output_size=in_data_3,

                                   iou_threshold=iou_threshold, score_threshold=score_threshold, name="nms")

return res

test_nms()
Other info / logs Include any logs or source code that would be helpful
to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
error message
nms/NonMaxSuppressionV3: unsupported op: No registered 'NonMaxSuppressionV3' OpKernel for XLA_CPU_JIT devices compatible with node {{node nms/NonMaxSuppressionV3}}
Stacktrace:
  Node: __inference_test_nms_10, function:

  Node: nms/NonMaxSuppressionV3, function: __inference_test_nms_10

[Op:__inference_test_nms_10]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/42879, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQZRBMU7SM3KBBPTCNLZQPTSDXKLVANCNFSM4QSSVN3A
.
--
Anderson

I am able to replicate the issue reported, please find the gist here.

@yongwww Looks like this was resolved. I tried your code with tf-nightly nad I cannot reproduce the error. Please check the gist here.
Can you please verify and close the issue if this was resolved for you. Thanks!


AttributeError: module 'awswrangler' has no attribute 'Session'

I am passing in this code:
import pandas as pd
import awswrangler as wr
import boto3
boto3_session = boto3.Session(aws_access_key_id="", aws_secret_access_key="",region_name="*")
wr_session = wr.Session(boto3_session=boto3_session)
but am receiving this error: "AttributeError: module 'awswrangler' has no attribute 'Session." I have installed the latest version of awswrangler and then also tried to uninstall and install previous versions, but I keep running into this same error. Any ideas on what's going on?

Hi @sdhong, seems that you are confusing the Wrangler's version. We had a breaking changes after version 1.0.
Your code snippet is compatible with versions <1.0, so to keep using it please install pip install awswrangler==0.3.2 por example.
If you would like to move to version >=1.0, please check our docs. We also have a tutorial to cover this specific Session handling.

Hi @igorborgest, thank you for this! I am using the newer version, but still having some issues connecting using boto3 creds. Is this how I would be using custom sessions:
wr.s3.to_parquet(
df=df
path=bucket_name,
dataset=True,
mode="overwrite",
partition_cols=["col"],
boto3_session=boto3.Session(aws_access_key_id="",aws_secret_access_key="", region_name="")
)

Thank you @igorborgest. The custom session handling works for me.


feat: support local login for non-built-in users

Signed-off-by: Yixiang Zhao<EMAIL_ADDRESS>Built-in-Organization.webm

fix the URL after logout
Casnode (2).webm


503 error on downloads?

Bug description
Seeing a 503 error on a download... not sure this is being tracked in the other 503 issues I've seen here.
ResponseCode=503, Error Body=<<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">  <title>503 Service Unavailable</title>
Service Unavailable

The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later.

 <address>Apache/2.4.52 (Ubuntu) Server at www.openhistoricalmap.org Port 80</address> >

What should be happening?
Nice, peaceful error-free download.
Repro Steps
Please provide detailed instructions to reproduce the behavior:
This may not reliably repro, but this is just what I did:

Download using Overpass query
Download again using Overpass query.

Weird error, the logs that have been shown so far:
Web-api logs:
Error: ERROR:  deadlock detected
DETAIL:  Process 95 waits for ShareLock on transaction 7723539; blocked by process 108.
Process 108 waits for ShareLock on transaction 7723528; blocked by process 95.
HINT:  See server log for query details.
CONTEXT:  while locking tuple (29433,86) in relation "current_ways"

DB logs:
2023-11-30 17:21:41.975 UTC [95] ERROR:  deadlock detected
2023-11-30 17:21:41.975 UTC [95] DETAIL:  Process 95 waits for ShareLock on transaction 7723539; blocked by process 108.
	Process 108 waits for ShareLock on transaction 7723528; blocked by process 95.
	Process 95: SELECT id FROM current_ways WHERE id = ANY($1) FOR UPDATE
	Process 108: SELECT id FROM current_relations WHERE id = ANY($1) FOR UPDATE
2023-11-30 17:21:41.975 UTC [95] HINT:  See server log for query details.
2023-11-30 17:21:41.975 UTC [95] CONTEXT:  while locking tuple (29433,86) in relation "current_ways"
2023-11-30 17:21:41.975 UTC [95] STATEMENT:  SELECT id FROM current_ways WHERE id = ANY($1) FOR UPDATE
2023-11-30 17:45:47.441 UTC [149] ERROR:  canceling statement due to user request
2023-11-30 17:45:47.441 UTC [149] STATEMENT:  SELECT "changesets".* FROM "changesets" WHERE (num_changes > 0) AND (min_lon < 460986328 and max_lon > 193798828 and min_lat < -49158328 and max_lat > -394361929) ORDER BY changesets.id DESC LIMIT $1
2023-11-30 17:45:48.027 UTC [14916] ERROR:  canceling statement due to user request
2023-11-30 17:45:48.027 UTC [14916] STATEMENT:  SELECT "changesets".* FROM "changesets" WHERE (num_changes > 0) AND (min_lon < 379687500 and max_lon > 112500000 and min_lat < -87113588 and max_lat > -423260624) ORDER BY changesets.id DESC LIMIT $1
2023-11-30 17:45:51.597 UTC [125] ERROR:  canceling statement due to user request
2023-11-30 17:45:51.597 UTC [125] STATEMENT:  SELECT "changesets".* FROM "changesets" WHERE (num_changes > 0) AND (min_lon < 417480468 and max_lon > 150292968 and min_lat < -120393205 and max_lat > -447779358) ORDER BY changesets.id DESC LIMIT $1

Continuing...

Both were from JOSM & both were in / around the Stanford/San Jose. The first instance was a general Overpass query in a small area & the second was a download parent ways/relations ask from JOSM's file menu.

Now, just a basic download from OHM for a bbox...

Happening now. Same situation.

@Rub21: this looks similar to a CGImap issue I've been discussing with @woazboat only a couple of weeks ago.
Can you please confirm that you're running CGImap in --daemon mode. Also,how many openstreetmap-cgimap processes you're still seeing today. Also, how many instances have you configured?
For the time being, I would recommend to increase the number of instances, and restart CGImap until we have fixed the issue.

@Rub21 : thanks! From our experience, we have also seen the issue, when the main openstreetmap-cgimap process was still up and running, all of the forked processes were gone.
If I see this right, your scripts checks if all openstreetmap-cgimap processes are gone. Is this really how it looked like in the container?

One more comment: since you're not running in daemon mode, the parameter "instances" has no effect, and you would be serving one user at a time only.
We will add warning message in that case during startup, and also fix the Dockerfile. Current behavior in that case is: in case of an error, the process would terminate with a non zero return code, and would have to be restarted.
That brings me to the next question: how many containers with cgimap inside do you run in parallel?

One more comment: since you're not running CGImap in daemon mode, the parameter "instances" has no effect, and you would be serving one user at a time only.

I see, that might be the solution for the issue below 👇 . When there is concurrency of users and editions at the same time, it means it would be better to run CGImap in daemon mode.
Error: ERROR:  deadlock detected
DETAIL:  Process 95 waits for ShareLock on transaction 7723539; blocked by process 108.
Process 108 waits for ShareLock on transaction 7723528; blocked by process 95.
HINT:  See server log for query details.
CONTEXT:  while locking tuple (29433,86) in relation "current_ways"

That brings me to the next question: how many containers with cgimap inside do you run in parallel?

Normally, we run two containers of the service, each with its own CGImap. However, when we experience increased concurrency of users and edits, the number of pods (containers) gradually increases.
@mmd-osm This is great https://github.com/zerebubuth/openstreetmap-cgimap/issues/330 , Thank you!  it would be better CGImap in daemon mode.

Seens this issue has been solved, have you still facing 503 issue?


Option to use the default moment.js locale

The picker already uses moment.js so it will be useful if the default moment.js locale will be used instead of having to define it with the language attribute for each picker.
moment.locale('fr');

check the v4 branch, I believe it already does this

v3.1.3
When setting locale with moment.locale('fr'), datetimepicker uses that locale only when adding language: '' to the options.
I couldn't make the v4 branch work. It uses new options.


deprecate FeatureSelector

It seems that there is not much need for FeatureSelector, since
feature = :node
model = Flux.Chain(
    GCNConv(1024=>256, relu),
    FeatureSelector(feature),
    softmax
)

can be easily done with
model = Flux.Chain(
    GCNConv(1024=>256, relu),
    node_feature,  # or edge_feature or global_feature
    softmax
)

More complex behavior can be implemente with closures, e.g.
model = Flux.Chain(
    GCNConv(1024=>256, relu),
    fg -> (node_feature(fg), edge_feature(fg))
    (x, e) -> (softmax(x), sigmoid.(e))
)

I agree with using node_feature, since I saw someone else used it before. It is worth documentation.


Documentation & Static Docs Site

Rationale
Documentation helps newcomers grasp how Parrot does what it does (best). It also helps current maintainers because we can't rely on having it all committed in memory.
A nice static website generated by cargo doc which looks like the default Rust codebase doc site would be nice to host on Github pages of this repository for instance.
Description

Document the main modules (for example commands) using the standard Rust doc style.

Create a better README splitting it into multiple markdown files stored under /docs and in the README link to them. Main sections: how to run either by installing dependencies (leave installation if possible linked to external resources so that we don't have to repeat what others did and avoid having to describe it for every OS) or using docker, how to run tests, contributing guide

Automatize the generation of the static site. Should amount to at the end of the main workflow (or in a new one) to do cargo doc or something similar and push it to Github pages.

Reference
Documentation

https://doc.rust-lang.org/cargo/commands/cargo-doc.html
https://github.com/serenity-rs/serenity/blob/current/src/cache/mod.rs#L1
https://github.com/serenity-rs/serenity/blob/current/src/cache/mod.rs#L106

Github Pages

https://github.com/s0/git-publish-subdir-action

As we are not a library nor a API, does it still make sense to use the default Rust Docs style of documentation? Wouldn't just better detailing some outlines in the Wiki be simpler and better adapted to our use case?

I thought about that too but I think the module documentation would help people diving into code. And since after having that all you need is to run cargo doc it seems like low-hanging fruit for me.
Also, despite being mostly a binary crate, for whatever reason I could want to use parrot as a library, perhaps to extend it (?).


#https://github.com/manhtuong135/github-slideshow/issues/1#issue-848298557

#https://github.com/manhtuong135/github-slideshow/issues/1#issue-848298557
Originally posted by @manhtuong135 in https://github.com/manhtuong135/github-slideshow/issues/1#issuecomment-811789712

Duplicate of #

@manhtuong135


[release/7.0] Add Microsoft.NETFramework.ReferenceAssemblies 1.0.3 targeting pack to SBRP

See the following build error in 7.0.2xx bootstrap: https://dev.azure.com/dnceng/internal/_build/results?buildId=2060862&view=logs&j=05a957c8-6537-5d6d-69e3-d72786d35c31&t=2ef7b31a-1958-50cd-c8a0-00414b8948fc&l=817
It is unclear to me why this is only happening in the bootstrap build.

The first commit where this happens appears to be 8654d0944d9d5fc749c6aa0fe0974948a141c602: https://dev.azure.com/dnceng/internal/_build/results?buildId=2057484&view=results

[Triage] We should investigate to understand why this only surfaces in the bootstrap leg before adding the addition targeting pack to SBRP.

Have we seen this in 7.0.1xx?  Nominating for closure otherwise since we're not planning on supporting 7.0.2xx.

[Triage] this is not an issue in 7.0.1xx.  For 8.0, the need for this will be removed by https://github.com/dotnet/source-build/issues/3014.


what is contract registry address?

Description of problem
run cakeshop in attach way follow attch section instruction  from below address https://github.com/jpmorganchase/cakeshop/wiki/Getting-Started
, it always failed with below error then failed
INFO 2019-05-10 10:09:47,380 [main] (BlockchainInitializerTask.java:120) Contract registry address not found
INFO 2019-05-10 10:09:47,381 [main] (BlockchainInitializerTask.java:149) ContractRegistry not found on chain
INFO 2019-05-10 10:09:47,384 [main] (BlockchainInitializerTask.java:154) Deploying ContractRegistry to chain
ERROR 2019-05-10 10:09:50,507 [main] (ContractServiceImpl.java:120) REASON FOR CONTRATC FAILURE Unexpected end-of-input: was expecting closing quote for a string value
Expected behavior
Actual behavior
(paste logs at end)
Steps to reproduce the behavior
System information
Cakeshop version or commit hash: [Cakeshop 0.9.1Build 6c7a88ee]
Cakeshop runtime configuration: [attach mode]
Geth/Quorum version testing against: [Geth/v1.8.18-stable-8f19fb1e(quorum-v2.2.3)]
Cakeshop OS & Version: linux-amd64/
Browser OS & Version: Windows/Chrome
Backtrace/logs
Copy all relevant log output. Use Gist for longer logs.
[stacktrace/logs]

The contract registry is a special smart contract that keeps track of the addresses, abi, and solidity code of contracts deployed through cakeshop's sandbox. It no longer deploys on its own, instead you deploy it from the Contract tab once you attach to a node. Please try the newest version of cakeshop from the releases page.


Wither skeleton recipe

Describe the Suggestion
The recipe for spawning wither skeletons uses coal ore instead of coal, which makes it impossible to automate.
I suggest changing the coal ore to regular coal

Fixed.
Thanks!


ADD: interface of HomePage

change som position in src detele HomePage change position of Library.jsx to component change structure in App.jsx move spotify.js to src  add feed.jsx in component


Correlation matrix

Hi @matthew-brett ,
@changzheng1993 and I are having determining which of these will produce the right corr (7x7) matrix.
def difference_corr(beta, category):
""" This functions return the correlation matrix of the two categories
Parameters
----------
beta:4D dimensions
brain activation
category:
	choose a category to fix it.

return
------
correlation: 2D
	correlation matrix
"""

difference = []

for i in np.concatenate((range(category-1), range(category ,8))):
	difference.append((beta[...,i]-beta[...,category-1]).reshape([-1]))

difference = np.array(difference)
correlation = np.zeros((7,7))
for j in range(7):
	for k in range(7):
		correlation[j,k] = np.corrcoef(difference[j],difference[k])[1,0]
return correlation

Or,
def diff_corr(betas, condition):
differences = []
betas_2d = betas.reshape((betas.shape[-1],-1))
for i in np.arange(8)[np.arange(8)!=condition-1]:
    differences.append(betas_2d[i,:] - betas_2d[condition-1,:])

return np.corrcoef(differences)

They both spit out the a 7x7 matrix but we're getting significantly different correlation outputs.

You can debug this by doing a couple of correlations by hand - I mean, getting the beta vector for houses, the beta vector for faces, then subtracting the beta vector scrambled and doing the correlation.
I think you'll find that the betas are different in the first function than in the second, hence the different correlations.   I worry about your reshape command in the second function.

the reshape is to get the (P x Voxel) on the right side. I might have misinterpreted your image. I'll debug now. thank you @matthew-brett

Yes, you'll get the right shape, but filled with the wrong elements.  Remember that numpy.reshape will do this internally:

flatten the input array to 1D, taking elements over the last dimension first;
fill up the output array from the flat output, filling the last dimension first.

So, with your reshape, it will fill up the voxel-length rows with lots of time-courses.   To make sure the elements go in the right order, you'll have to reshape into V by T and then transpose.
Also - I still think you should used the mask instead of taking the whole 4D volume...


[Flutter web]: removeEventListener on HTML nodes does not removed actually

I need a functionality where the default context menu is disabled and my own context menu (built by flutter) will show. As described in many stackoverflow answers I use addEventListener and removeEventListener to implement requirements. All works fine until I removed the event listener. In reallity the listener is still registered so I cannot restore default context menu.

Minimal reproducible code
// ignore_for_file: avoid_print, avoid_web_libraries_in_flutter
import 'dart:ui' as ui;
import 'dart:html';

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'HTML Context Menu',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  bool _isListenerAdded = false;

  static const _contextMenu = 'contextmenu';
  static const _contextMenuId = 'contextmenu-target';

  @override
  void initState() {
    super.initState();
    // ignore: undefined_prefixed_name
    ui.platformViewRegistry.registerViewFactory(
        'div-element',
        (int viewId) => DivElement()
          ..id = _contextMenuId
          ..style.width = '100%'
          ..style.height = '100%');
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('HTML Context Menu Issue'),
      ),
      body: Column(
        mainAxisAlignment: MainAxisAlignment.center,
        children: [
          Row(
            mainAxisAlignment: MainAxisAlignment.center,
            children: [
              ElevatedButton(
                onPressed: !_isListenerAdded
                    ? () {
                        setState(() {
                          final div = document.getElementById(_contextMenuId);
                          div?.addEventListener(
                              _contextMenu, _mouseListener, false);
                          _isListenerAdded = true;
                        });
                      }
                    : null,
                child: const Text('Add Listener'),
              ),
              ElevatedButton(
                onPressed: _isListenerAdded
                    ? () {
                        setState(() {
                          final div = document.getElementById(_contextMenuId);
                          div?.removeEventListener(
                              _contextMenu, _mouseListener, false);
                          _isListenerAdded = false;
                        });
                      }
                    : null,
                child: const Text('Remove Listener'),
              ),
            ],
          ),
          Container(
            margin: const EdgeInsets.only(top: 20),
            width: 100,
            height: 100,
            child: Stack(
              children: [
                const HtmlElementView(
                  viewType: 'div-element',
                ),
                Container(
                  alignment: Alignment.center,
                  color: Colors.amberAccent.shade100,
                  child: const Text(
                    'Click Mouse Right Button',
                    textAlign: TextAlign.center,
                  ),
                ),
              ],
            ),
          ),
        ],
      ),
    );
  }

  void _mouseListener(Event event) {
    event.preventDefault();
    final messengerState = ScaffoldMessenger.of(context);
    messengerState.hideCurrentSnackBar();
    messengerState.showSnackBar(
      const SnackBar(
        duration: Duration(seconds: 1),
        content:
            Text('Mouse right button clicked. After removal event listener '
                'this handler is still called back.'),
      ),
    );
  }
}

Hi @bambinoua, thanks for filing the issue. This issue is reproducible on the latest stable and master channels with provided sample code

Demo
https://user-images.githubusercontent.com/104349824/194548268-30a4fc10-562a-4744-bfe2-5b8a5e7fc76c.mov

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.4, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.3.4 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision eb6d86ee27 (23 hours ago), 2022-10-04 22:31:45 -0700
    • Engine revision c08d7d5efc
    • Dart version 2.18.2
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.5.0-3.0.pre.5, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.5.0-3.0.pre.5 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9ca314afd0 (12 minutes ago), 2022-10-06 23:06:11 -0400
    • Engine revision a4174f29a7
    • Dart version 2.19.0 (build 2.19.0-286.0.dev)
    • DevTools version 2.18.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (5 available)
    • SM T225 (mobile)           • R9JT3004VRJ                              • android-arm64  • Android 12 (API 31)
    • iPhone (mobile)            • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7 19H12
    • iPhone 14 Pro Max (mobile) • 332079AF-E895-4685-910E-7B1E18B0C6B8     • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-0 (simulator)
    • macOS (desktop)            • macos                                    • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)               • chrome                                   • web-javascript • Google Chrome 106.0.5249.103
    ! Error: iPhone is busy: Fetching debug symbols for iPhone. Xcode will continue when iPhone is finished. (code -10)

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

This is a general problem with Dart. When you pass an instance method, Dart creates a tearoff function that is bound to the correctthis instance (known problem/pattern in JavaScript). In some cases (or maybe always?) Dart creates a new tearoff when you pass the same method again. That would create a new function that's different from the function you previously passed to addEventListener.
cc @natebosch was that an accurate description of how Dart does tearoffs in JS? Please correct me if I said anything wrong.
In order to solve it, try something like this:
class _MyHomePageState extends State<MyHomePage> {
  _MyHomePageState() {
    _mouseListener = (Event event) => _onMouseEvent(event);
  }

  final EventListener _mouseListener;

  @override
  Widget build(BuildContext context) {
    // ... use `_mouseListener`
  }

  void _onMouseEvent(Event event) {
    event.preventDefault();
    final messengerState = ScaffoldMessenger.of(context);
    messengerState.hideCurrentSnackBar();
    messengerState.showSnackBar(
      const SnackBar(
        duration: Duration(seconds: 1),
        content:
            Text('Mouse right button clicked. After removal event listener '
                'this handler is still called back.'),
      ),
    );
  }
}

I know that the semantics in Dart are that the two tearoffs should compare as equal. I'm not sure the semantics through dart:html JS interop.
@sigmundch @srujzs

@mdebbar you are correct, when we create instance tear-offs, dart2js will create a new instance of a tearoff. They compare as equals under ==, but they are not identical. The browser's removeEventListener expects the JavaScript function passed as an argument to be identical to the one that was installed with addEventListener, so caching the listener as you showed (storing it as an actual field) will address this problem.
Minor tweaks you could do:

use a tear-off still when creating the cached field:

  Function _listener;
 _MyHomePageState() {
    _listener = _onMouseEvent; // using tear-off syntax here.
  }

make the cache part of the state: setting it when the addEventListener is about to be invoked instead of the constructor, and deleting it when the listener is removed.

   Function? _listener;
   bool _isListenerAdded => _listener != null;
   ...

       setState(() {
          final div = document.getElementById(_contextMenuId);
          final listener = _mouseListener;
          div?.addEventListener(_contextMenu, listener, false);
          _listener = listener;
       });

Another potential pattern
late final _listener = _onMouseEvent;

Thanks @natebosch and @sigmundch for chiming in!
Closing the issue for now.

In order to solve it, try something like this:

@mdebbar it looks like your solution works. Thanks.


Improving reschedule backup logic to avoid cancelling schedule

Earlier, the logic for rescheduling backup was to cancel the ongoing schedule and creating a new schedule with the modified parameters. This approach was taken since the logic of modifying schedule while the job is running used to fail.
Now, we have modified the approach such that once the job is done and if the job is failed, then we reschedule the backup. Since, the job is already done, we can now modify the parameters in the function and hence, cancelling the schedule is not needed.

Pull Request Test Coverage Report for Build 1658

5 of 10 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 86.555%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

jobs/ScheduleBackupJob.js
5
10
50.0%

Totals

Change from base Build 1656:
-0.03%

Covered Lines:
8210

Relevant Lines:
9208

💛  - Coveralls


Show Frequently Used Apps for Quick Selection

What is the motivation for adding/enhancing this feature?
To enhance user experience and efficiency, we should prioritizing frequently used apps at the top of the list for quick selection. This feature will enable users to access their most commonly used apps more easily and reduce the time spent searching for them.
What are the acceptance criteria?

[ ] ...

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Additional information

Please refer this UI: https://www.figma.com/file/wK5FMs4z2zXQR9VfHV9ycE/Dhiraj's-Ionic-6-Material-UI-Kit-(Community)?type=design&node-id=28820%3A145475&mode=design&t=zbJkwXeJLw8jFnxt-1

can you assign me this issue

Sure @SakshiKant go ahead


TypeError: selection.interrupt is not a function (using ZoomableGroup wih buttons)

Hi,
First of all thank you for this amazing library.
Description
I'm using react-simple-maps in a project and I am facing an issue using ZoomableGroup wih buttons (zoom in and out).
Here is my code:
const MapChart = () => {
  const [zoom, setZoom] = useState(1);

  const handleZoomIn = () => {
    if (zoom >= 4) return;
    setZoom(zoom * 2);
  }

  const handleZoomOut = () => {
    if (zoom <= 1) return;
    setZoom(zoom / 2);
  }

  return (

        <PlusSquare />
        <MinusSquare />

      <ComposableMap data-tip='' projectionConfig={{ scale: 70 }} width={500} height={200}>
        <ZoomableGroup
          zoom={zoom}
          onMoveEnd={() => { }}
          onMoveStart={() => { }}
        >
          <Geographies geography={jsonGeography}>
            {({ geographies }) =>
              geographies.map(geo => {
                const { NAME, ISO_A2 } = geo.properties;

                return (
                  <Geography
                    key={geo.rsmKey}
                    geography={geo}
                  />
                );
              })
            }
          </Geographies>
        </ZoomableGroup>
      </ComposableMap>

  );
};

The error appear when clicking the zoom in link <PlusSquare /> (where <PlusSquare /> is a simple svg).
Here is the error:
Uncaught TypeError: selection.interrupt is not a function
    at push../node_modules/d3-zoom/src/zoom.js.__webpack_exports__.default.zoom.transform (zoom.js:91)

It seems that the problem comes from d3-zoom or the multiple versions of d3-selection installed, I found this issue on github but I can't understand why and how to fix it. Is it because I'm using another package which uses d3-selection with another version ? How can I fix it ?
Expected behavior
The zoom should change according with the setZoom function without throwing an error.
Version:
package.json
"react-simple-maps": "^2.3.0"
package-lock.json
"react-simple-maps": {
      "version": "2.3.0",
      "resolved": "https://registry.npmjs.org/react-simple-maps/-/react-simple-maps-2.3.0.tgz",
      "integrity": "sha512-IZVeiPSRZKwD6I/2NvXpQ2uENYGDGZp8DvZjkapcxuJ/LQHTfl+Byb+KNgY7s+iatRA2ad8LnZ3AgqcjziCCsw==",
      "requires": {
        "d3-geo": "^2.0.1",
        "d3-selection": "^2.0.0",
        "d3-zoom": "^2.0.0",
        "topojson-client": "^3.1.0"
      },
      "dependencies": {
        "d3-selection": {
          "version": "2.0.0",
          "resolved": "https://registry.npmjs.org/d3-selection/-/d3-selection-2.0.0.tgz",
          "integrity": "sha512-XoGGqhLUN/W14NmaqcO/bb1nqjDAw5WtSYb2X8wiuQWvSZUsUVYsOSkOybUrNvcBjaywBdYPy03eXHMXjk9nZA=="
        }
      }
    }

Thank you for your attention and sorry for my limited English skills.

Hi @Aljal,
Thanks for using react-simple-maps!
Yes, I am assuming here that an older version of d3-selection/d3-zoom is causing the problem. Are you using another data visualization library in parallel with react-simple-maps?
Does it work if you install d3-selection/d3-zoom v2 (^2.0.0) explicitly?

Does it work if you install d3-selection/d3-zoom v2 (^2.0.0) explicitly?

I tried but it doesn't work.
I works using a different version: "react-simple-maps": "2.1.2"


Replace Debian with Ubuntu for greater control over LibreOffice versions

Hi there,
I noticed the issues caused by Debian's LibreOffice dependencies. By using Ubuntu Focal you get LibreOffice 7.3.7 which seems more stable than 7.4.x for PDF conversion.
In addition, you can also access more old LibreOffice versions from Ubuntu in the future via Personal Package Archives should regressions occur.
Let me know what you think.

Thanks @padpadthai!
I did use Ubuntu previously, but, last time I've checked, recent Chromium versions were only available through the Snap package manager. I did not find a way to use this package manager in a Dockerfile, so I switched to Debian instead.

Ok thanks for the info @gulien, I think I understand the nuance of the situation now.
Please have a look at the updated commit. It installs Chromium from Debian sources. I used the following sources as guidance for this approach:

https://askubuntu.com/questions/1204571/how-to-install-chromium-without-snap/1206153#1206153
https://askubuntu.com/questions/1179273/how-to-remove-snap-completely-without-losing-the-chromium-browser/1206502#1206502
https://gist.github.com/ishad0w/7665cde882aa7dc3eec99613802e61e4

Would this work?

I guess it would work, but it feels a bit hacky IMO 😄 also, @sharongut found out that the culprit could be the garbage collector from Gotenberg (see https://github.com/gotenberg/gotenberg/issues/442#issuecomment-1384186104). I'd prefer for now to look at this direction 😉

Ok, I agree that the hacky-ness is not ideal here 😅. All the standard approaches I tried were blocked one way or another. Hopefully, you get this resolved via the garbage collector approach.
I will close this PR. Thanks for your feedback 😄

Thanks for your time @padpadthai 😄


Importing Mapzen Android library into Xamarin

This question came in through email support. I'm adding the user's question here to close the support ticket, and in case someone in the community has an answer or knows about Xamarin and could contribute the bindings.

I have encountered troubles in importing your Android library
(mapzen-android-sdk-1.2.1.aar) in the project (Xamarin for Android,
Visual Studio 2017), I need your help.
In order to use Java library in Xamarin a special library binding is
required as a bridge between Java and C# code. Here it is described in
detail:
https://developer.xamarin.com/guides/android/advanced_topics/binding-a-java-library/binding-an-aar/
Having tried to follow the guide I get numerous errors and warnings, and
binding library is not built correctly. I suspect the issue to be in
dependencies on third-party libraries like dagger, javax.inject, Android
AppCompat library and so on. I tried to add them as links to the
project, but positive result was not reached. Maybe I use incorrect
versions of libraries or something like that.
I searched the question in internet, no result. It seems that by the
moment nobody connected MapZen and Xamarin yet. :(
So,

Could you please help me (and all other Xamarin developers as well)
with creating this binding library? You know the internal structure of
your Android API, so it could be much easier for you to create the
binding correctly.

Maybe you already have a native library (component) for Xamarin,
which is simply not published yet? I would appreciate very much to be
your beta-tester.

The Mapzen SDK does not currently support Xamarin bindings.
This is not on our immediate roadmap but we can keep this issue open in case anyone else in the community (maybe with more Xamarin experience that me) wants to start working on a Xamarin adaption of the project.

I have a little past experience with Xamarin, unfortunately.
Since Xamarin is a cross-platform framework I can imagine that it would be difficult to directly bind all of the features of our Android SDK to C# via Xamarin (may pieces of our Android SDK are directly tied to Android frameworks). We would get a better result by just writing our own version of the SDK in C#.
We (the graphics team) have been eyeing a Unity3D plugin for some of our services, which would also be a C# layer.
@rmglennon Could we ask this user which specific services from the SDK this user would be interested in using? Some of them might be easier to port than others.

@matteblair,
It was me who asked for Xamarin support.
First of all, I am interested in basic map functionality like displaying a map, interacting with map, working with markers/polygons and tiled overlays. Generally, I am targeting my app to Android and UWP (Windows 10) platforms. Other potential developers would also like to target iOS as well.

@matteblair
I have the same problem, targeting android/ios/uwp with Xamarin in Visual Studio.  Starting with map rendering but will eventually need search and turn-by-turn.  Any help would be appreciated.


Added optional CUDA support to python's numba

CUDA support for numba, unchanged version
Description of changes
Added cudatoolkit inclusion in numba, triggered by enabling cudaSupport, consistent with jaxlib and tensorflow. Added package numbaWithCuda forcing CUDA support, as is done with jaxlib etc.
cuda_paths.py is patched inside numba to force nix store paths in place of dynamic resolution. nvvm paths seem to have changed from cudatoolkit 10 to 11, so nvvm resolution is patched from nvvm/lib64 to just lib64 in the toolkit. This will NOT work with cudatoolkit_10.
Additionally, removed obsolete substitutions (@FRidh , check it makes sense pls - for me they only generate not found warnings)
Did a short test in a non-NixOS shell, seems to work.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Do please change the commit title to start with python3.pkgs.numba:

In the commit, not just the PR ;-)

Just one remark. Why pick the tensorflow_compat set of packages? Any specific reason? Did it not function otherwise?


tag team in time_to_open metric

Looks good, if you want to test out the action to make sure it's working properly we can tag this commit with a beta version and push a branch elsewhere pointing at the beta version and open up a pull request.

Thanks. Confirmed it is working as expected against a beta version. Merging and retagging v1 now.


perf(command): user grant pre-condition check using the search table

Which Problems Are Solved
Imporve the performance of user grant addition, especially for import.
How the Problems Are Solved
Use the search table to query for the project grant state.
This could easily be done by making the search used in checkProjectGrantPreCondition reusable.
Additional Changes
Chanded event declerations to const in the internal/repository/project package.
Additional Context

Performance improvements for import are evaluated and acted upon internally at the moment

@mike-miroliubov FYI this is the PR for user grants performance improvements

Thanks, @adlerhurst!


Documentation on how to get started and change/ add widgets

I'm very interested in using this project however when I try to change or add a widget nothing happens. I have followed the instructions on how to run it with Docker which worked fine.  So the dashboard is running and now I need to change and add widgets. However when I change or add a widget nothing is changing in the dashboard. Because of this I wonder if you could add more documentation on getting started and on changing/ adding widgets.

I'm glad to hear you !
If you try to add/remove widgets from the configuration.json, you just have to :

update the file
restart the mock api (npm run api) if you use the mocked API
restart the spring boot server if so
reload the browser

If you try to add a NEW widget (by code) here is the process :

You first create you widget (copy past from an existing one, update the names)
Add it on the WidgetFactory
Update your dashboard.json configuration file (and follow the process as describe in my previous comment)

I have planned to write more documentation about all this, but I first need to finish the Widget/Datasources system to ease the process. I will probably do that in few weeks :)
Please don't hesitate to ask me any questions, any feedback are welcome :)


Editor wise commit message formatting

Hi @agis-,
This is some nice stuff here.
In the Commit Messages section, what do you think about having something to auto-format git commit messages that people can use in their choice of editors like Vim or Emacs etc.
I use Vim for my things so I have a separate auto command to wrap messages in 72 characters per line and for spell check also.
I thought asking you would be right before a pull request as I saw in another issue that you were talking about keeping only git related things in the guide not editor specific.

Hey @pravj sorry for taking so long to reply. While I find your suggestion useful (I'm a vim user myself) , it's true that I'd prefer to keep only git-related things in the style guide. I'm even planning to remove some existing stuff that's not a matter of "style", but hints.
Thanks! :)

Hi @agis-,
It's OK, I kind of figured that out.
Yeah! keeping only 'style' related things not 'tips', will keep it up to the point.
Thanks for the guide by the way. :)


GIFs don't play

On my wife's and my borther-in-law's phone, GIFs won't animate even when tapped. My wife has a Samsung Galaxy S5 mini, my brother-in-law a Samsung Galaxy S7 (Android 7.0).
Another GIF sent earlier this week played on my wife's phone. A new one from today didn't. Since then, the earlier GIF doesn't play anymore, too.
Deleting media cache lead to the device displaying only a black screen when I tapped on the GIF in the chat stream. Deleting cache afterwards made it display the full screen GIF again, but still without animation.
It seems to work without problems (yet) on my BQ Aquaris X5 plus and on my mother's Samsung Galaxy J5.

Same on xiaomi redmi note 3 mtk with Android 5, gifs are not playing. Google play version of riot im.
On htc one with Android 4.1 gifs plays ok.

I am also having problems with GIF display (nexus 6p, Android 8.1.0, f-droid version).  The weird thing is that GIFs used to play, up until a couple of weeks ago or so.

I would agree with these statements i host a riot server for about 40 people and i have gotten several reports of gifs not working in rooms. People that haven't updated their riot android apps are still able to play the gifs people on V 0.7.07 (G-#112) can play but others on V 0.8.7 (G-#133) have issues


Fumble recoveries for TDs don't show up in player stats

I can't seem to find a way to look up fumble recoveries for TDs by offensive players using the PlayerStats. Any idea what's going on here?
player = nflgame.find("Julio Jones")
player_stats = player[0].stats(2015, 5)
player_stats.fumbles_rec_tds

0

But if I use combine_max_plays:
games = nflgame.games(year=2015, week=5, home='ATL', away='ATL')
plays = nflgame.combine_max_stats(games)
for p in plays:
if p.name == "J.Jones":
print p.name, p.fumbles_rec_tds

J.Jones 1

It's because player[0].stats retrieves game level statistics (look at its source). To get play level stats, you'll need to fetch the play sequence and extract the player. This will aggregate statistics for you. e.g.,
>>> julio = nflgame.find('Julio Jones')[0]
>>> stats = julio.plays(2015, week=5).players().playerid(julio.playerid)
>>> stats.formatted_stats()
'receiving_tar: 10, fumbles_tot: 1, fumbles_forced: 1, fumbles_rec: 2, fumbles_rec_yds: 0, receiving_yds: 67, receivin
g_rec: 5, receiving_yac_yds: 30, fumbles_rec_tds: 1'


Doesn't work in AngularJS ng-repeat directive

The following works, copied from the build folder (of course changed the path on an image for local testing).
However when I call the same class 'baguetteBoxOne' on an anchor/image inside ng-repeat it doesn't work. Any work around? I'm a novice at JS so I don't know if I will be able to assist very much on the issue.

The next snippet is the code in the repeater:

I've tried moving the class declaration to different parent elements and directly on the anchor and image elements but no advances yet.

Hi, actually, I haven't used Angular yet, so I can't really debug it or check what's wrong.
Make sure the generated code is valid (e.g. src) and take a look at the console if there are any errors.

No errors. I think its the way Angular generates the elements. I dont have
time to dive deeper right now but Ive seen the same issue on other
"lightbox" type plugins. Thanks.
On Jan 22, 2015 10:14 AM, "Marek Grzybek"<EMAIL_ADDRESS>wrote:

Hi, actually, I haven't used Angular yet, so I can't really debug it or
check what's wrong.
Make sure the generated code is valid (e.g. src) and take a look at the
console if there are any errors.
—
Reply to this email directly or view it on GitHub
https://github.com/feimosi/baguetteBox.js/issues/19#issuecomment-71046045
.

Angular executes directives (calls compile and link functions) downward DOM tree. That's why your baguetteBoxOne (put on parent element) always gets executed before ngRepeat (put on child element) which means that baguetteBoxOne doesn't find any  elements because they have not been rendered by ngRepeat yet.
Quick fix would be to use $timeout service to active baguetteBox after all directives are processed:
angular.module('myApp')
    .directive('baguetteBoxOne', ['$timeout', function ($timeout) {
        return {
            restrict: 'AC',
            link: function ($scope, $elm) {
                $timeout(function () {
                    baguetteBox.run('.baguetteBoxOne');
                });
            }
        };
    });


Makefile: Properly clean and generate bindata.go files

Running something like "make clean generate build -j4 && ./gitea web"
on my system would build gitea with deleted files.
This is really weird, but a result of a race condition:

'make clean' wouldn't delete bindata.go as it used bad globbing
'build' and 'generate' would run in parallel, 'generate' taking longer
'build' would pack in older bindata.go files before 'generate' finished
'generate' would finish and output new bindata.go files

So in effect this happened:

I built gitea from source for the first time
I modified a file and built gitea which showed no change
I deleted the file and built gitea which now showed the modified file
I added the file back and built gitea which now couldn't find the file

Codecov Report

Merging #8480 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8480      +/-   ##
==========================================
- Coverage   41.84%   41.83%   -0.01%
==========================================
  Files         497      497
  Lines       65808    65808
==========================================
- Hits        27537    27531       -6
- Misses      34733    34740       +7
+ Partials     3538     3537       -1

Impacted Files
Coverage Δ

models/unit.go
62.16% <0%> (-5.41%)
:arrow_down:

routers/repo/view.go
42.31% <0%> (-1.01%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1fdd78...b0689c8. Read the comment docs.

Closing as its broken and I'm not interested in fixing it


hip: init at 4.3.1

Motivation for this change
Follow-up from https://github.com/nixos-rocm/nixos-rocm/issues/65
cc. @acowley
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Great to see this! Why version 4.0.0? It looks like the ROCm llvm here is at 4.1, and the nixos-rocm overlay is at 4.3.

Great to see this! Why version 4.0.0? It looks like the ROCm llvm here is at 4.1, and the nixos-rocm overlay is at 4.3.

Just because it's a 1-1 transplant from the code in nixos-rocm. I'm going to bump the versions now that I got the baseline working :)

Okay, let me know if you have any trouble. The overlay is working fine at 4.3 afaik.

Alright, @acowley, I bumped our entire ROCm ecosystem to 4.3.1 and the new packages as well :)

Result of nixpkgs-review pr 136445 run on x86_64-linux 1

17 packages built:

hip
llvmPackages_rocm.clang
llvmPackages_rocm.clang-unwrapped
llvmPackages_rocm.clangNoCompilerRt
llvmPackages_rocm.compiler-rt
llvmPackages_rocm.lld
llvmPackages_rocm.llvm
rocclr
rocm-cmake
rocm-comgr
rocm-device-libs
rocm-opencl-icd
rocm-opencl-runtime
rocm-runtime
rocm-smi
rocm-thunk
rocminfo

@acowley If you could take a look at this I think it's ready to merge, I'd like a second opinion before hitting the button though :)

Is there any way to test/review this without hardware?

Is there any way to test/review this without hardware?

Not as far as I can tell, I have an AMD GPU and did some basic testing locally, where things looked fine.

:partying_face:


Ignored warnings are counted towards the 50 limit of jslint.

JSlint stops after 50 warnings. I think ignored warnings should not be counted for this limit.

This is likely the linter executable, and not sublime-jslint. Could you check please?


AVRO-2359: Support Logical Types in C#

This PR brings in C# support for logical types.
The code was originally based on the apache/avro repository (https://github.com/apache/avro/pull/492), but I've also applied the patch here for your consideration.

thanks - i should be able to look at this soon after we get 1.0 of the kafka client out the door (I have been focussed on that). I notice that there are more than 32000 lines of code though, most of which shouldn't be here, so at the very least i'll need to tidy it up and open again (which would loose attribution to you). is that ok, or do you want to tidy it up?
Also, I noticed we don't have the contributor license agreement bot set up on this repo, I think you can sign it by going here: http://clabot.confluent.io/cla (that just allows us to confidently do what we want with the code, probably ultimately merging upstream to the apache foundation).

It looks like most of those 32K lines are project.assets.json files. Perhaps they're not in the .gitignore file. I'll take a look at tidying that up.

I've also just complete the CLA.

Around ~1K lines now. That seems more like it. :-)

great, thanks! i hope I can get this in 1.0.1.

There were a few missing switch branches for testing the processing of a logicalType. These have now been added.

@mhowlett - have you had any time to look at the interop scenarios that you mentioned above? Is there anything you need me to look at? I'm planning on looking at @petersilverwood's Decimal implementation this week - it's the logical type implementation that I'm most naive with.

I've now reworked the Decimal logical type so that it takes into account the big-endian requirement for encoding, and also to support negative values.
cc/ @petersilverwood

I've added a new AvroDecimal type which encapsulates a big decimal. It's a wrapper around .NET's BigInteger and a scale. The 'decimal' logical type has then been refactored to use instances of this type instead of managing byte buffers directly. The logic was based on the 'decimal' logical type in the Java codebase, so they should work the same. However, saying that, I'm not sure about the two's-compliment side of things which the spec says the encoded decimal should be in.
/cc @petersilverwood

So after a little reading, I think that because .NET byte is unsigned, we're already getting the two's compliment encoding of the decimal bytes. So I think we're fine. A Java byte is signed so I think it has to be converted before.

Quick observation - this doesn't look to support schemas of mixed primitive and logical types, is that intended?

@dcrdev - not quite sure what you mean, but you can define Records that use a mix of types (primitive, complex, and now logical). For example, the following schema uses a mix of primitive and the decimal logical type:
{
    "type": "record",
    "namespace": "WordCountEntities",
    "name": "WordCount",
    "fields": [
        {
            "name": "TotalWordCount",
            "type": "int"
        },
        {
            "name": "WordCounts",
            "type": { "type": "map", "values": "int" }
        },
        {
            "name": "TopWord",
            "type": "string"
        },
        {
            "name": "ExecutionCost",
            "type": {
                "type": "bytes",
                "logicalType": "decimal",
                "precision": 8,
                "scale": 2
            }
        }
    ]
}

Any planned movement on this inclusion?

there's plenty of demand for this (it came up again yesterday with a customer), but it's not at the top of the list.
note: there's movement on getting rid of our fork, so this work will be done against the apache repo: https://github.com/confluentinc/confluent-kafka-dotnet/issues/1033

Any update on supporting this?

@shawnallen85 - there's movement on this over here https://github.com/apache/avro/pull/492

Do we have any movement on this tool?
Currently the avrogen tool generates
"type": { "logicalType": "date", "type": "int" }
as
"type": "int"
which leads to schema registry issues of
Schema mismatch. Reader: <> writer: <>

Confluent.Apache.Avro.AvroGen <IP_ADDRESS> generates schema file (.avsc) data type based on "type" instead of "logicaltype". Below example generates datatype as Nullable instead of Nullable. Could you please help.
"type": ["null", { "type": "int", "logicalType": "date" }  ]

hi, is there any plan to include this in a formal release?

This is causing our Jenkins CI to break due to the "unknown repository" - This needs to be closed to get around that. If this change is still required, please re-do it in a fork or branch.

This is causing our Jenkins CI to break due to the "unknown repository" - This needs to be closed to get around that. If this change is still required, please re-do it in a fork or branch.


Urban_Shores does not work.

I attempted to run Urban Shores on Future Cop and it worked almost flawlessly except for that strange triangle that showed up to the map.
Warning Nerd Speak
For some reason the assertion statement at virtual bool Data::Mission::TilResource::parse(const Data::Mission::Resource::ParseSettings&): Assertion `tile_graphics.shading >= 0 && tile_graphics.shading <= 3' failed. It tells that the special effect tile that goes beyond these values are found. The Original Future Cop does not seem to mind this value range. That might be the strange triangle, but this could be a red herring.
With this assertion statement commented out there is another error. This is the output from gdb from the x86_64 Linux Version from code_revision.
"Data/Platform/Windows/missions/GlblData" is a little endian mission file
"Urban_Shores" is a little endian mission file
terminate called after throwing an instance of 'std::out_of_range'
  what():  vector::_M_range_check: __n (which is 264) >= this->size() (which is 256)

(gdb) bt
#8  address in std::vector<Data::Mission::TilResource::Tile, std::allocator<Data::Mission::TilResource::Tile> >::_M_range_check (this=vector_address, __n=264) at /usr/include/c++/12.2.1/bits/stl_vector.h:1153
#9  address in std::vector<Data::Mission::TilResource::Tile, std::allocator<Data::Mission::TilResource::Tile> >::at (this=vector_address, __n=264) at /usr/include/c++/12.2.1/bits/stl_vector.h:1175
#10 address in Data::Mission::TilResource::createPhysicsCell (this=some_other_address, x=12, z=8) at .../Future-Cop-MIT/src/Data/Mission/TilResource.cpp:642
#11 address in Data::Mission::TilResource::parse (this=d_address, settings=...) at .../Future-Cop-MIT/src/Data/Mission/TilResource.cpp:302
#12 addressin Data::Mission::IFF::open (this=c_address, file_path="Urban_Shores") at .../Future-Cop-MIT/src/Data/Mission/IFF.cpp:457
#13 address in Data::Manager::IFFEntryStorage::load (this=b_address, platform=Data::Manager::WINDOWS) at .../Future-Cop-MIT/src/Data/Manager.cpp:95
#14 address in Data::Manager::setLoad (this=a_address, importance=Data::Manager::NEEDED, core_amount=1) at .../Future-Cop-MIT/src/Data/Manager.cpp:305
#15 address in main (argc=7, argv=argv_address) at .../Future-Cop-MIT/src/FCModelViewer.cpp:203

This indicates that there is either something wrong with the Urban_Shores or my project has a bug in it that is causing this.

I made edits which works the buffer overflow by modding them so they would not go out of bounds.
However... the map is practically destroyed.

After a night's sleep, I decided to further work on this.
I thought of making a simple modification which removes the textures and I found that my reader does not only like the UV's, but hates the "Graphics Tile". Also polygons are missing or are improper.

I need to delve a little deeper on this in order to know what is going on. So, I looked into Urban Shores and eventually found out the problem. I wrote code that assumes that Ctil would have the variable mesh_library_size to correspond to the size. My new code fixes this overdependent behavior.
Old code
const size_t ACTUAL_MESH_LIBRARY_SIZE = (this->mesh_library_size >> 4) / sizeof( uint32_t );

mesh_tiles.reserve( ACTUAL_MESH_LIBRARY_SIZE );

std::set<uint16_t> seen_graphics_tiles;

for( size_t i = 0; i < ACTUAL_MESH_LIBRARY_SIZE; i++ ) {
  mesh_tiles.push_back( { reader_sect.readU32( settings.endian ) } );
  seen_graphics_tiles.insert( mesh_tiles.back().graphics_type_index );
}

New code
const size_t PREDICTED_POLYGON_TILE_AMOUNT = (this->mesh_library_size >> 4) / sizeof( uint32_t );

mesh_tiles.reserve( PREDICTED_POLYGON_TILE_AMOUNT );

std::set<uint16_t> seen_graphics_tiles;

size_t actual_polygon_tile_amount = 0;

for( size_t i = 0; i < AMOUNT_OF_TILES * AMOUNT_OF_TILES; ) {
  mesh_tiles.push_back( { reader_sect.readU32( settings.endian ) } );

  seen_graphics_tiles.insert( mesh_tiles.back().graphics_type_index );

  if( mesh_tiles.back().end_column )
     i++;
  actual_polygon_tile_amount++;
}


Use seed name in the Seed template while calculating seed namespace for gardenlet cache

How to categorize this PR?

/area controlplane
/kind bug
What this PR does / why we need it:
Gardenlet needs the permissions to watch secrets in this namespace, ref https://github.com/gardener/gardener/blob/0b0a0790fccf6ffc0d890dae4f76e93a5fcd8063/cmd/gardenlet/app/app.go#L277.
However, we were using kubeconfigBootstrapResult.SeedName for calculating the namespace for the cache. But kubeconfigBootstrapResult.SeedName can be empty if the kubeconfig already exists. See https://github.com/gardener/gardener/blob/5abed1bfedd6f2188e5dcec9af161d1b5c286236/cmd/gardenlet/app/bootstrappers/garden_kubeconfig.go#L115-L118
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @timuthy
Cherry-picked from https://github.com/gardener/gardener/pull/8325
Release note:

NONE

/approve

/test pull-gardener-e2e-kind-operator


Maximum publishing rate

i used your wrapper and modified it for a small project to publish the images to ros , but i noticed that the rate of the publishing rate only goes up to a maximum of 11 even whether i increased the Rate loop_rate() in img_publisher.py and the pubImages.launch files, is it because my processor ran out of juice or something else? I noticed one of my core is running at 100% (assuming it's running on a single thread).

With my machine (8th Gen Intel i7, 16GB RAM, and 8GB NVidia-1070 graphics card). for 720p images, I am able to get a frame rate of 2-3 Hz which increases to 4-5 Hz with "NoDisplay" view mode on. However, the issue is at the AirSim end since it takes a lot of time to retrieve depth images through the API call.
If you want to increase the frame rate, you can decrease the size of the images to 480p. That's the only possible solution for now.


Routes should allow to load modules/controllers on demand

When you route to a specific location, the template for that route is loaded on demand. There should also be a feature to specify a module or controller script that will be loaded when the user routes to the given location.
There is a solution using require.js (https://github.com/matys84pl/angularjs-requirejs-lazy-controllers), but it adds another library and another nesting level (angular module definitions within require.js module definitions)
As for the use case:

Increase the initial startup time by loading scripts only when they are needed.
Only serve scripts to users that have the right to see the route they are used in.
Enhanced modularity.

+1

+1

+1

+1

+1

it's 2016. something should have been done..
:)
May the awesomeness will always be with you,
Tri Rahmat Gunadi - JUJI
http://jujiyangasli.com
Ph 0813.1012.8924
On Mon, Oct 3, 2016 at 7:02 PM, pyotruk<EMAIL_ADDRESS>wrote:

+1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/angular/angular.js/issues/2135#issuecomment-251088850,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAeH8RayUZA4MUmqWPnUIyb5S6Rsg5PRks5qwO64gaJpZM4AfSRI
.

The de-facto solution appears to be to use a 3rd party https://oclazyload.readme.io which appears to solve the problem in a generic way.

In 1.6.7, it will be possible to load new modules into the injector after the app has been initialized, e.g. in a route's resolve function. You'll still have to provide a way to load and execute the script though. See https://github.com/angular/angular.js/commit/34237f929927295392bbb1a600e78cbde581839a for more info


Driver fs_lvm. method resize has been implemented

I have implemented the method "resize" for the fs_lvm storage driver. Could you accept one.

Is there any reason to not include this?

OK from my side.


Is PG_ACC_BUGS still necessary?

CoreNEURON  has following macros :
→ grep -r ACC_BUG coreneuron/*
coreneuron/mech/modfile/hh.cpp:#if defined(PG_ACC_BUGS)
coreneuron/nrnoc/eion.cpp:#if defined(PG_ACC_BUGS)
coreneuron/nrnoc/register_mech.cpp:#if defined(PG_ACC_BUGS)
coreneuron/nrnoc/nrnoc_ml.h:#if PG_ACC_BUGS

Todo for this ticket :

Check when PG_ACC_BUGS was introduced and what was the purpose
If it was due to some old version, check if the issue doesnt appear with current 18.4 PGI compiler
If so, remove related code from CoreNEURON as well as MOD2C

This was removed in https://github.com/BlueBrain/CoreNeuron/pull/455.


Simplify build

Instead of spitting out the compiled JavaScript for each component, we aggregate all component's JavaScript into the design-system JavaScript file, which simplifies the build.
Also, design-system.js.LICENSE was being built. This PR turns off extracting comments in terser to remove this (addresses https://[ghe]/CFGOV/platform/issues/3602)
Removals

Remove passing of component name to build and just build available components.

Changes

Turn off extracting comments in terser
Add minimize flag, which can be flipped instead of adding/removing terser.
Include handle-errors utility in build steps for scripts.

Testing

Pull branch, and gulp build should spit out a minimized design-system.js file in packages/cfpb-design-system/

@contolini

Looks good! I can't verify the admin section but the output and compiled docs look good. 👍


Enhance Admin Event List Filters

After submitting the form, the admin shall be able to see previously selected options on the Event list page. The admin shall be able to search for location with Turkish lower case letters.

The structure of the form has been changed for the enhancement and a new query has been added for searches with Turkish characters. The admin is now able to see previously selected options in the Events page.


Foreign key migrations not idempotent on MySQL on windows

Bug description
The migrate dev is considering its own changes from last migration as drift
When I run "prisma migrate dev":
Your database is now in sync with your schema.
And then running "prisma migrate dev" again right after:
? Drift detected: Your database schema is not in sync with your migration history.
[*] Changed the `main` table
  [+] Added foreign key on columns (id1)

[*] Changed the `main` table
  [+] Added foreign key on columns (id2)

migration sql:
-- AddForeignKey
ALTER TABLE `main` ADD FOREIGN KEY (`id1`) REFERENCES `ext_table1`(`id`) ON DELETE SET NULL ON UPDATE CASCADE;

-- AddForeignKey
ALTER TABLE `main` ADD FOREIGN KEY (`id2`) REFERENCES `ext_table2`(`id`) ON DELETE CASCADE ON UPDATE CASCADE;

How to reproduce

Run prisma migrate dev
Run prisma migrate dev
See error

Expected behavior
Migration to run smoothly with no errors notifying that there are "no changes" in schema or db
Prisma information

Environment & setup

OS: Win10
Database: MySQL
Node.js version: 12

Prisma Version
2.25.1

@yazer79
Can you please share your schema and changes you made to it? Also, please tell us if you are running MySQL directly on windows or via docker.

@pantharshit00
I am running MySQL directly
I have a production db that i am trying to use prisma with. I had some errors in the db before as it is a very old db. And I am getting prisma migrate errors popping up every while even if i fix things. It is very hard.
After I fixed migration issues, and ran prisma migrate. I got no error and it was fine. I immediately ran migrate again without any changes, and the last migrate seem to have added the foreign keys and it considered its own additions as drift.

should I use migrate deploy only in production databases even if I am developing locally?

should I use migrate deploy only in production databases even if I am developing locally?

Yes. You can use deploy in development if you want, although migrate dev also applies migrations, but you shouldn't use migrate dev in production.

So I shouldn't use migrate dev locally? that is the cause of the problem?

MySQL on windows in general has serious problems (not only with Prisma) because it changes the table names to be lowercase under the hood. I would suggest using migrate dev, if possible on a MySQL in WSL or docker, since you are probably deploying to linux.
In general, developing on windows MySQL and deploying to a unix-like OS (Linux, ...) is buggy.
Note that this is also a prisma bug, the foreign key should not be recreated. But I think we have tests for that already, so any context and detail is helpful to reproduce the problem.

This issue can't move forward without more info, I think. We should attempt a reproduction. @yazer79 would sharing your schema be possible?

I can't share the whole db or schema as it is a production private website. But I can share any general structure or table examples. Would that help?

Yeah, share any minimal reproduction for that bug.

Can I share my schema privately? and how?

Any response please? My work is halted because I can't change my database

The best thing you can do here if you can't change the database is change its configuration to not to lowercase table names: https://dev.mysql.com/doc/refman/8.0/en/identifier-case-sensitivity.html and https://stackoverflow.com/questions/8550789/where-to-change-the-value-of-lower-case-table-names-2-on-windows-xampp
Ideally I will recommend using docker.

Hey @yazer79, did you figure this out? If not, send the schema to<EMAIL_ADDRESS>and I can make sure we try to reproduce the problem you are experiencing. Thanks.

@janpio
I stopped using "prisma migrate dev" completely and was using prisma db push to add new tables, today I got this from prisma db push:
Error: Database error
Error querying the database: Server error: `ERROR HY000 (1215): Cannot add foreign key constraint'
   0: sql_migration_connector::sql_database_step_applier::apply_migration
             at migration-engine\connectors\sql-migration-connector\src\sql_database_step_applier.rs:11
   1: migration_core::api::SchemaPush
             at migration-engine\core\src\api.rs:161

And I don't even know where is the problem

Please open a separate issue for the new problem, this does not sound related.

Hey @yazer79,
We'd really need a small reproduction repository for us to move this issue forward. Without your Prisma Schema and a migration history, it's fairly hard to reproduce your issue.
Thanks a lot 🙏

Hello again,
Without further info we'll have to close this issue. Please feel free to leave a comment and/or open a new issue with the information requested above.
Thank you!


Documentation overhaul

Overall:

Rebuild and re-upload current docs.
Fix any and all access issues.
Document docs build and upload process.

URL updates

ensure all URL references / links within docs are consistent, updated, and still working.

http://blaze.readthedocs.io/en/latest/overview.html

update / correct or remove figure at top

http://blaze.readthedocs.io/en/latest/install.html

test all install options listed.
test versions that are installed.
document blaze required and optional dependencies.
Update dependency versions.

http://blaze.readthedocs.io/en/latest/quickstart.html

Comb through quickstart, incorporate notebooks into quickstart.
Simplify / pare down quickstart examples to work around current limitations.

http://blaze.readthedocs.io/en/latest/queries.html

update queries to include new string munging ops via .str namespace.
update queries to include new datetime munging ops via .dt namespace.
all usage of .like() should be instead .str.like()
flesh-out examples section, or decide to remove entirely, since overlaps with Overview.

http://blaze.readthedocs.io/en/latest/split-apply-combine.html

"They are well supported in all backends and are generally efficient."  Verify that this is true, perhaps examples in docs of same by() query on different backends.

http://blaze.readthedocs.io/en/latest/rosetta-pandas.html

go through table, verify interfaces
update with .str and .dt namespaces

http://blaze.readthedocs.io/en/latest/rosetta-sql.html

update first NOTE -- it over-promises.  Mention only specific SQL backends that we've tested: PG, MySQL, SQLite
Go through table, update cells, test that all work for each supported backend.
Automate tests around this, perhaps?

http://blaze.readthedocs.io/en/latest/csv.html

Update docs to refer to dask.read_csv() rather than pandas.read_csv()
Flesh out examples?  Document performance?
Test that directory of CSVs works with Blaze / Dask backend.

http://blaze.readthedocs.io/en/latest/sql.html

"What databases does Blaze support?" -- emphasize that Blaze is regularly tested against PostgreSQL and SQLite only.  Emphasize that SQL dialects have different support for non-standard functionality.
Verify that last section code still runs and works; consider marking the entire section "Experimental" rather than just a warning at the end.

http://blaze.readthedocs.io/en/latest/ooc.html

Replace references to "chunks" for CSV processing with Dask.  Mention Dask alongside Pandas / NumPy at the top.
Remove example using split?  This is an internal implementation detail used by chunks...
Rewrite "parallel processing" section to emphasize how Blaze leverages Dask now and uses Dask's built-in parallelism.
Document parallel performance improvements.

http://blaze.readthedocs.io/en/latest/server.html

Verify all example code still works and runs; update / fix as needed.
Before YAML section, demonstrate dynamically adding to a blaze server via Python / IPython
remove curl example?  Replace with just mentioning that curl and other tools can query B. Server?
Overhaul / remove "Advanced Use" section -- put its contents in other relevant sections.
Remove caching section?  The Blaze CachedDataset is poorly tested.

http://blaze.readthedocs.io/en/latest/datashape.html

Blaze-specific examples.
Emphasize and demonstrate how every blaze expression has an associated .dshape.  Demonstrate how they are kept in sync with the expression as it evolves.
Document .coerce and .cast here.

http://blaze.readthedocs.io/en/latest/what-blaze-isnt.html

Overhaul / reword; sounds somewhat defensive.
Good to point out limitations; take different approach.

http://blaze.readthedocs.io/en/latest/api.html

Look over, ensure docstrings in code make it through correctly.
Look at docstring examples, ensure work and are relevant.

http://blaze.readthedocs.io/en/latest/releases.html

Update to include latest release notes / whatsnew files.
only include tagged releases; ensure tags are correct.

http://blaze.readthedocs.io/en/latest/people.html

Update via Blaze commit log.  Current core contribs are Kurt Smith and Joe Jevnik only.

http://blaze.readthedocs.io/en/latest/expr-design.html

Remove?  Move to GH wiki?

http://blaze.readthedocs.io/en/latest/expressions.html

Move earlier in docs?  Move after overview section?

http://blaze.readthedocs.io/en/latest/backends.html

Check rows + columns.  How is this generated?  Can it be automated from code itself to stay in-sync?

http://blaze.readthedocs.io/en/latest/interactivity.html

Move earlier in docs, after overview?
Verify examples work.

http://blaze.readthedocs.io/en/latest/dev_workflow.html

Remove / move to wiki?

@sandhujasmine I took a pass through Blaze's current docs and collected my notes above.  Please go through this and let me know your questions.  This work will take a good while to get through.  Please break up into separate issues if you desire.


class sap.m.upload.UploadSetItem -> visibleEdit / visibleRemove -- does not hide the edit/remove button

OpenUI5 version: 1.76.0
Browser/version: Version 74.0.3729.169 (Offizieller Build) Built on Ubuntu , running on Ubuntu 16.04 (64-Bit)
Any other tested browsers/devices: Chrome on Android
What is the expected result?
The buttons should not be visible if they are set to false.
visibleEdit="false"
visibleRemove="false"
What happens instead?
The buttons are still visible.
(If I use the UploadCollection class it works, but not with the UploadSet class)

Hello @jaques30081983 ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards, Diana

Hello colleagues,
This issue is fixed and it will be available in version 1.78 of OpenUI5 release.
Regards,
Amiya

Hello,
As the issue is fixed, I am closing the issue.
Best regards,
Tereza

Hi Tereza,
We are using the latest UI5 Version and still the functionality visibleEdit="false"visibleRemove="false" is not working for us on UploadSet. We are running it on Chrome.
Can you please confirm once the issue has been fixed or not.
Regards,
Preeti


Use of **kwargs in methods and functions signature is confusing

Many of our functions and methods accept **kwargs. This leads quickly to errors because the function/method will accept any named parameter, even though only some will be used and possibly the one specified will be ignored.
For instance, we changed the NEXUSDataReader to use the parameter file_name rather than nexus_file, but nexus_file will be accepted and not used while the required parameter file_name will not have been set, leading to an error. See also #988
As discussed in https://github.com/TomographicImaging/CIL/discussions/1064#discussioncomment-1657282 these should be removed.

In addition, I would like to mention the following problem
pdhg = PDHG(f=f,g=g,operator=operator, update_objective_interval=10, max_iterations=100)
pdhg.run(verbose=0)

Nothing is printed

if verbose=1
pdhg = PDHG(f=f,g=g,operator=operator, update_objective_interval=10, max_iterations=100)
pdhg.run(verbose=1)

Initialised GradientOperator with C backend running with  20  threads
PDHG setting up
PDHG configured
     Iter   Max Iter     Time/Iter        Primal          Dual     Primal-Dual
                               [s]     Objective     Objective             Gap
        0          0         0.000    7.65531e+04  -0.00000e+00    7.65531e+04
----------------------------------------------------------------------------
        0          0         0.000    7.65531e+04  -0.00000e+00    7.65531e+04
Stop criterion has been reached.

The problem is in max_iterations. It should be max_iteration.

Absolutely, this is the typical situation where you get in trouble by accepting **kwargs and not listing parameters in the signature.


Add a check for PreferServerCipherSuites flag of tls.Config

Having the server select the best available cipher suite, it is more secured than allowing the client to pick a weak cipher configuration.

Thanks for the PR!


marquee-anchors - new block

Added a new marquee-anchors block.

This layout was initially implemented with a marquee, toc and related section-metadata blocks.
This new block is standalone and is intended to replace/deprecate current usage.  See this earlier PR for more info
Resolves: MWPW-129912
Test URLs:

Before https://main--milo--adobecom.hlx.page/drafts/rparrish/marquee-nav
After https://rparrish-marquee-nav--milo--adobecom.hlx.page/drafts/rparrish/marquee-nav

Authoring notes:
Document anchor list rows start in the 3rd table row. (1. background color, 2. marquee content, 3, 4, 5... list rows)
List rows, header and footer are optional.
The list rows link identifier is the 'display text' starts with a #.
In page anchor links should have identical 'display text' and 'link' fields. see screenshot...

The down arrow svg location is in /milo/libs/img/ui/arrow-down.svg ->  https://adobe.sharepoint.com/sites/adobecom/Shared Documents/Forms/AllItems.aspx?FolderCTID=0x012000F36D5B4C46F81741BCAC9F03FA9F93D1&id=%2Fsites%2Fadobecom%2FShared Documents%2Fmilo%2Flibs%2Fimg%2Fui&viewid=d776cf70-9b7e-4ab7-b9da-9e0f8e03a7d2

@ryanmparrish should there be a gap below the image here?

Just had another thought.. When adding a link that leaves the current page, the icon is still using the down arrow - which from a UX perspective is telling me I'm going to visit content on the page below when clicked. What do think about changing the icon when the link is pointed to content outside of the current page?

Just had another thought.. When adding a link that leaves the current page, the icon is still using the down arrow - which from a UX perspective is telling me I'm going to visit content on the page below when clicked. What do think about changing the icon when the link is pointed to content outside of the current page?

Love this idea. I added some logic to remove the icon when linking external. Do you think we should change it however to a different icon? This could be discussed and added as an enhancement

Looks good. Do we know where the bacom TOC is used? Plan to replace? Also there does seem to be a style difference between what is in #215 and what is here.

I don't know all the potential docs the TOC is used. I can coordinate a plan w/ the PMs at BACOM to help resolve any updates. Upon a quick search it looks to be fairly minimal.  I was following the XD in the new design for this block styles, I didn't do a close cross comparison from old to new, but if we need to put on the breaks to give that feedback some more time, we certainly can. I know JohnSpencer was involved however he's out on Sabbatical 🤷

Since you are using headers in authoring the Marquee Anchor block the header text has to be different than the headers they link to since both headers will get the same ID.
Have you seen content that uses the same titles in both places? You might think about remove the IDs from the Marquee Anchor link content.

You might think about remove the IDs from the Marquee Anchor link content.

@Brandon32 Good thought, I've addressed this issue but appending a namespace to headers IDs in the links. Thanks

Just had another thought.. When adding a link that leaves the current page, the icon is still using the down arrow - which from a UX perspective is telling me I'm going to visit content on the page below when clicked. What do think about changing the icon when the link is pointed to content outside of the current page?

Love this idea. I added some logic to remove the icon when linking external. Do you think we should change it however to a different icon? This could be discussed and added as an enhancement

I think we should show a different icon. There's a fairly universal icon for this. Something like this:

Where did the down arrow come from? Consonant? Spectrum?

@rgclayton  - sounds good. no prob on the Icon swap. I can add that one to the external links. The arrow-down icon came from the design file in the Jira ticket.

@rgclayton  - I made a minor modification and am now fetching 2 icons for anchor and external links. Take a peek when you get a chance and let me know what you think. Thanks


About the Training Efficiency

Dear authors:
Thanks for your great work and public codes. I am trying to do some further research based on your work. However, I found the training process is really slow, with less than 20% GPU utilization. The val loss on PDBBind is still decreasing after seven days of training on one V100 GPU. Do you have any advice to improve the training efficiency? I found you leave a TODO comment to run SVD in batches. Do you have any updates on this?
Many thanks!

Hi!
Unfortunately, we have not looked into running SVD in batches any further and have not implemented this.
I would also recommend checking out the new DiffDock method instead of EquiBind since it provides significantly better accuracy. (However, it is even slower at training since it uses the rather heavy e3nns).


How to disable image/file uploads.

Hello, I don't want users to upload image/flile. How to disable them.

This property sets false.  https://imperavi.com/redactor/docs/settings/file/#s-fileupload


password for private key file

I can't find any way to set password for private key. I believe in boost asio it is done by using ssl::context::set_password_callback, but I can't find anything regarding this call in source code. I also don't see any way to get ctx_ from client/server object. Is it currently impossible to set it or do I miss something?

We don't have the setter function, so far. Maybe the default callback is called.
I understand that ssl::context::set_password_callback is the right one.
The current asio has
https://www.boost.org/doc/libs/1_71_0/doc/html/boost_asio/reference/ssl__context.html
And only a part of them are supported by mqtt_cpp.
I think that adding reference (const/non const) getter for ssl::context is good only if MQTT_USE_TLS is defined.
mqtt_cpp start from minimal TLS support. At that time, I implement some of wrapper function for ssl::context. (It is not directly reflected their name though)
Continue adding all member functions is not a practical approach.
So I think that getter is good for advanced usecase. However, set_password_callback seems to be commonly used. Also providing the wrapper for set_password_callback might be better.

Personally I think it's better to just provide a getter for ssl::context (and asio::io_context), and leave it at that.
MQTT_CPP doesn't care about the details of the ssl context beyond that it does SSL. There's not a lot of value in providing any of these wrapper functions if all they'd do is just call the underlying ssl function.

@jonesmz , let me clarify.
You mean,

Add context getter.
Don't remove existing member functions for the context.
Don't add set_password_callback.

Am I understanding correctly?

Add context getter.
Do remove existing member functions for the context.
Don't add set_password_callback.

Or maybe

Add context getter.
Mark existing member functions for the context as deprecated. Remove in 8.0.0
Don't add set_password_callback.

I agree. I use deprecated mark.

@ineffective , I implemented #472. Could you try this?

meged. @ineffective if you still have a problem, please reopen the issue.

No problems, I used new version and everything works as expected, so no need for reopening.


after proceedToChooseAccount, workflow does not end, hangs on "Accessing account information"

Using trustly-android-example with credentials generated by our platform test environment, we are consistenly able to get to the choose account step on an Android device, but upon submitting 'Continue' it hangs.
Steps to Reproduce:

The following establishDataValues were provided to selectBank:

"customer.email" -><EMAIL_ADDRESS>"customer.address.address1" -> "1101 East Gibbsboro Road "
"customer.customerId" -> "19019"
"metadata.urlScheme" -> "sdkdemo://"
"customer.externalId" -> "19019"
"customer.address.zip" -> "08021"
"customer.taxId" -> "crypt:/5SX3jF6OzTIuCGjRUBe1I365nRmySF1Sd7zawdEjVc="
"env" -> "sandbox"
"customer.address.state" -> "NJ"
"paymentType" -> "Deferred"
"accessId" -> "WS8vT7ftpHImaeLB5FSx"
"merchantId" -> "1051"
"customer.address.country" -> "US"
"customer.phone" -> "+16575675675"
"merchantReference" -> "1681413404294|TKxEutQDME-WJkCTzCHJyeBXUczl5BYbAd2ZlshfjoTYl-h4hax0cD2APZ_Ei-rr"
"customer.dateOfBirth" -> "1985-01-01"
"customer.name" -> "trustly six"
"customer.address.city" -> "Lindenwold"
"requestSignature" -> "KEWSDvcwa/9T/El7C439wlgUqUk="

In the following code fragment from app/src/main/java/net/trustly/paywithmybanksdkdemoandroid/ui/LightBoxActivity.kt a breakpoint, in Android Studio, was placed in both of the onReturn and onCancel callback functions.
lightBoxWidget.establish(establishDataValues)
            .onReturn(
                (PayWithMyBankCallback { _: PayWithMyBank, _: Map<String, String> ->
*                    redirectToScreen(Callback.RETURN)
                })
            ).onCancel(
                (PayWithMyBankCallback { _: PayWithMyBank, _: Map<String, String> ->
*                    redirectToScreen(Callback.CANCEL)
                })
            )

We searched for 'Oauth' and selected "Oauth Demo Bank" in the drop-down.

Select 'CONNECT MY BANK' (bottom of screen)

Select 'Connect to OAuth Demo Bank'

enter into field Username: foo

enter into field Password: bar

Click Login, and Confirm

'Choose an account' is displayed

Click 'Continue'

Neither callback is triggered at the end of the workflow (after choosing an account).   The workflow hangs in the "Accessing account information" screen (below).

Thanks for reporting and updating Dan. Please do create any additional issues as you come across them and we will attempt to review them in a timely manner.


Fix: Remove models and core losses op from cmake build.

The sources do not exist for these anymore, therefore deleting them.

Ah, looking at the wrong thing. This fixes the models issues, but not the losses one.
Closing this and will prepare another PR.


feat/fix(ui): canvas bbox bug & enhancements

What type of PR is this? (check all applicable)

[ ] Refactor
[x] Feature
[x] Bug Fix
[x] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[x] Yes
[ ] No, because:

Description
fix(ui): fix canvas staging images offset from bounding box
The staging area used the stage bbox, not the staging area bbox.
fix(ui): memoize event handlers on bounding box
fix(ui): canvas is staging if is listening for batch ids
fix(ui): reset canvas batchIds on staging area init/discard/commit
This prevents the bbox from being used inadvertantly during canvas generation
feat(ui): hide mask when staging
Now you can compare inpainted area with new image data
feat(ui): staging area toolbar enhancements

Current image number & total are displayed
Left/right wrap around instead of stopping on first/last image
Disable the left/right/number buttons when showing base layer
improved translations

fix(ui): use theme colors for canvas error fallback
fix(ui): memoize canvas context menu callback

Seems good. Updated the staging toolbar styling slightly.