Environment variables set in bash aren't picked up by Windows processes run from bash

Please use the following bug reporting template to help produce actionable and reproducible issues. Please try to ensure that the reproduction is minimal so that the team can go through more bugs!

A brief description

Some Windows processes depend on the environment for their behavior. One is msbuild when trying to compile a Visual Studio solution; Microsoft.Common.CurrentVersion.targets tries to set some properties using $([System.IO.Path]::GetTempPath()), which resolves to the value of %TMP%, %TEMP%, %USERPROFILE%, or the Windows directory, whichever is found first. TMP, TEMP, and USERPROFILE are not set in bash by default, and unfortunately setting them doesn't work.

Expected results

Consider the following MSBuild script:
<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"
         DefaultTargets="build">
        <Target Name="build">
                <Message Text="$([System.IO.Path]::GetTempPath())" />
        </Target>
</Project>

Output from msbuild 14.0 in cmd.exe looks like this:
C:\work\msbuild>echo %TMP%
C:\Users\saxonww\AppData\Local\Temp

C:\work\msbuild>"c:\Program Files (x86)\MSBuild\14.0\Bin\MSBuild.exe" test.proj
Microsoft (R) Build Engine version 14.0.25420.1
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 11/14/2016 1:32:01 PM.
Project "C:\work\msbuild\test.proj" on node 1 (default targets).
build:
  C:\Users\saxonww\AppData\Local\Temp\
Done Building Project "C:\work\msbuild\test.proj" (default targets).

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:00.27

Actual results (with terminal output if applicable)

Even though TMP, TEMP, and USERPROFILE are all set, the output is wrong:
saxonww@MACHINE:/mnt/c/work/msbuild$ alias msbuild
alias msbuild='/mnt/c/Program\ Files\ \(x86\)/MSBuild/14.0/Bin/MSBuild.exe'

saxonww@MACHINE:/mnt/c/work/msbuild$ echo $TMP
C:\Users\saxonww\AppData\Local\Temp

saxonww@MACHINE:/mnt/c/work/msbuild$ echo $TEMP
C:\Users\saxonww\AppData\Local\Temp

saxonww@MACHINE:/mnt/c/work/msbuild$ echo $USERPROFILE
C:\Users\saxonww

saxonww@MACHINE:/mnt/c/work/msbuild$ msbuild test.proj
Microsoft (R) Build Engine version 14.0.25420.1
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 11/14/2016 1:35:24 PM.
Project "C:\work\msbuild\test.proj" on node 1 (default targets).
build:
  C:\WINDOWS\
Done Building Project "C:\work\msbuild\test.proj" (default targets).

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:00.26

If it matters, the above is run under tmux.
Edit: I'm seeing similar weirdness when running windows commands from bash to do windows things. For example, if I run "start ./Solution.sln" from cmd.exe it will open Solution.sln using the associated Visual Studio and everything is fine. If I set an alias for 'start' to 'cmd.exe /c start' in bash, and run the same command, Visual Studio opens but throws a bunch of errors and eventually crashes with a 'debug' or 'close program' dialog. It's not clear whether this is environment related or not, but it seems likely to me.

Your Windows build number

14965.rs_prerelease.161104-1700

Steps / All commands required to reproduce the error from a brand new installation

Install WSL, install VS2015, set up alias, etc. as shown.

Strace of the failing command

The strace is pretty straightforward. I can attach the entire thing if required, but in particular the environment variables show up w/ execve if I run 'strace -v -s 65535 ', e.g.:

"USERPROFILE=C:\Users\saxonww",  "PWD=/mnt/c/work/msbuild", "HOME=/home/saxonww", "TMP=C:\Users\saxonww\AppData\Local\Temp",

Required packages and commands to install

See our contributing instructions for assistance.

For anyone hitting this, you can sort-of work around it with some wrapper batch files.
I have one setup.bat:
@echo off
REM This must be called with cmd /v

for /f "tokens=1,2*" %%i in ('reg query "HKLM\SYSTEM\CurrentControlSet\Control\Session Manager\Environment"') do (
        CALL :DOSETVAR %%i "%%k"
)

REM the below don't appear in the registry, run 'set' in cmd.exe and copy over as needed
set ALLUSERSPROFILE=C:\ProgramData                                                                                set CommonProgramFiles=C:\Program Files\Common Files                                                                                set CommonProgramFiles(x86)=C:\Program Files (x86)\Common Files                                                                                set CommonProgramW6432=C:\Program Files\Common Files
set USERNAME=saxonww
set USERDOMAIN=INTERNAL
set USERDNSDOMAIN=INTERNAL.DOMAIN.LOCAL
set USERDOMAIN_ROAMINGPROFILE=INTERNAL
set USERPROFILE=C:\Users\saxonww
set APPDATA=C:\Users\saxonww\AppData\Roaming

for /f "tokens=1,2*" %%i in ('reg query "HKCU\Environment"') do (
        if "%%i"=="Path" (
                CALL :DOADDVAR %%i "%%k"
        )
        if not "%%i"=="Path" (
                CALL :DOSETVAR %%i "%%k"
        )
)
exit /b
                                                                                :DOSETVAR
:DOSETVAR
set value=%2                                                                                set value=%value:~1,-1%
set %1=!value!
set "value="
exit /b

:DOADDVAR
set value=%2
set value=%value:~1,-1%
set %1=!%1%!;!value!
set "value="
exit /b

And then, e.g. to run msbuild via msbuild.bat:
@echo off
call "C:\path\to\setup.bat\setup.bat"
call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\vsvars32.bat"

"C:\Program Files (x86)\MSBuild\14.0\Bin\msbuild.exe" %*

Then set up an alias:
alias msbuild="cmd.exe /v /c c:/path/to/msbuild.bat"

I'm able to run start, nuget, and msbuild this way, which is so far what I really wanted.

For the same reasons I described here arguing against automatic translation of commandline arguments, I'd argue against automatic translation of environment variables--it's going to be hard to get right in the general sense. I would like to have some way to set environment variables when spawning a Windows process, but making it explicitly opt-in sounds more sensible.

We added an opt-in mechanism for environment variable interop in insider build 17063. You set WSLENV to a list of environment variables that should be passed through.

Another surprise of todays announcements 🎉
Very useful for my setup where I learned it the hard way of this gap. docker run -e ...


Unable to use custom elements to open the calendar

Hi there!
After updating to the brand new awsome 1.7 version, I tried the new "custom elements to open" feature. I think this feature was coded the more generic as possible, to work in many situations, as the doc says: "common in Bootstrap and other frameworks"
So I tried in Bootstrap, and after many trials, it just don't want to work. Here is the code I'm trying:

    <input class="form-control" data-input type="text">

And I boot up flatpickr using directly the dom element, like:
flatpickr(element);

If I click the input element, it triggers the calendar, and block user input from keyboard. A behaviour very different from the sample page.
Am I missing something to get this to work?
Best regards,
Rafael Pacheco.

You have to initialize flatpickr on the following element:

Are you calling flatpickr(".flatpickr") ?

Wow, nice catch =)
I didn't notice that was the group that should be initialized.
Working fine as expected :smile:
Thank you very much.


client cannot connect without token setting

Using this option on the client connection doesn't work.
-Dclient.session.tokenBased=false

the 2.2 client it work only with the token by design, the refactor was done for stabilize the support of live query.
The client should not read that flag anymore, just changed now the code, closing this.


Suggestion for new package

Hi jjhelmus,
Would it be possible to add Scikit-optimize (SKOPT) (https://github.com/scikit-optimize/scikit-optimize) to the rpi channel?
SKOPT is implementing a Bayesian Optimization routine for optimizing hyperparameters in e.g. machine learnings. Furthermore, it has proven succesfull in optimization of scientific experiments.
Many thanks for the berryconda work!
Best
/sqbl

Hi,
It would appear that Scikit-optimize is working. I installed scikit-learn (and matplotlib/numpy/pandas/...) from the berryconda/rpi repository and installed scikit-optimize using the normal:
conda install -c conda-forge scikit-optimize
Best regards,
Sqbl


use the session to store the random state

When the user isn't logged in self.request.user returns an AnonymousUser which makes the cache_key always be slack:AnonymousUser.
If two people try to login at the same time the first user will get a StateMismatch error as the cache key has been overwritten by the second user.
This PR switches to storing the random state in the session instead so they don't clash.

This change is

However I'm curios about those who use it with cache mechanism, which is set up in the settings, also probably README.md should be updated indicating that cache no longer is a requirement.

Ah yeah good point, I can update the README.md. This change will also require the session middleware


spot checks in borgmatic aren't supported by exporter?

Thanks for this. Just tried to set it up and it doesn't seem to like the spot checks that are supported by Borgmatic.
exported log:
summary:
/etc/borg/config/photos.yml: Error parsing configuration file
An error occurred while parsing a configuration file at /etc/borg/config/photos.yml:
At 'checks[1]': Additional properties are not allowed ('count_tolerance_percentage', 'data_sample_percentage', 'data_tolerance_percentage' were unexpected)
At 'checks[1].name': 'spot' is not one of ['repository', 'archives', 'data', 'extract', 'disabled']

config file is valid according to borgmatic:
summary:
All configuration files are valid

I can work around it as I'm not sure I need spot check.  Just bringing it up in case it's not a known issue.  Maybe support can be added in the future.

Thank you for the interest in the project!
As far as I can tell the feature for spot checks was added in borgmatic 1.8.10. I have not updated to that version yet, and also if you are using Docker, the image is based on 1.8.8.
I need to make a few changes to the project in order to support 1.8.10 or higher, as they changed the entrypoint for the base image, then I'll be able to properly test the spot functionality.

if you are using Docker, the image is based on 1.8.8.

if this is the official repo http://ghcr.io/borgmatic-collective/borgmatic, it as at 1.8.11 now.
I could be wrong... I just found borgmatic and have been obsessed with it for days now.  Setting up monitoring was what led me to your project.  Not looking for special treatment.  When you get around to updating, I'll definitely check it out! thx.

@johnny2678 I've made 2 new releases:

v0.2.4 - borgmatic 1.8.11
v0.2.5 - borgmatic 1.8.13

As far as I can tell, everything is working. At least based on the configurations that I have. Please poke around when you have time, and let me know if everything works as expected.


resolves #11 - Nock testing added for existing API fns

resolves #14 - Environments.all not working with promises
resolves #15 - arghelper.convertReqParams may add a ? to the end of a request
resolves #17 - Projects.list adds trailing slash to uri
resolves #18 - Vms.del calls PUT not DELETE

Looks great. I'll merge first thing tomorrow and bump the version number.


django >= 1.10 usage of _default_manager

Under django >= 1.10 ipn_obj._default_manager in paypal.standard.helpers.duplicate_txn_id fails because managers are not accessible from instances.
See https://code.djangoproject.com/ticket/26652

This should be fixed now, as above, thanks for the report. The build is currently failing due to a different issue with the sandbox PayPal account that is used in the tests.

Should we wait for the 0.3.3 release for this error to be fixed or do a pip install git+https://github.com/spookylukey/django-paypal.git?

0.3.3 released now.

Great! Thanks a lot!!!


$pwa is always false

I followed https://vite-pwa-org.netlify.app/frameworks/nuxt.html along with issues in the repo, created assets using https://vite-pwa-org.netlify.app/assets-generator/ and read https://vite-pwa-org.netlify.app/guide/pwa-minimal-requirements.html. Also, check the example at https://vite-pwa-org.netlify.app/examples/nuxt.html -> https://github.com/vite-pwa/nuxt/tree/main/playground.
In my view-source:http://localhost:3000/ I can't see <link rel="manifest" href="/manifest.webmanifest"> or any other file related to PWA, such as favicon.
Additionally, I've deployed the app to https://ibstructure.com and the PWA works, but the $pwa is still false. It's really confusing when trying to validate during development (esp. on localhost with bad documentation/localhost-PWA problems) whether the app is PWA working.

Most of my PWA-related changes/fixes/debugging were in: https://github.com/Doyban/Doyban-Website/commit/6c137212dea4532a4b438e0b41088a38dd67bf13 whereas the entire repo can be found on https://github.com/Doyban/Doyban-Website

why are you using injectManifest strategy without a custom sw? Use generateSW strategy (default), it should work.

No changes without injectManifest / with generateSW.
I have ServiceWorker in public/sw.js:
import { clientsClaim } from 'workbox-core'
import {
  precacheAndRoute,
  cleanupOutdatedCaches,
  createHandlerBoundToURL,
} from 'workbox-precaching'
import { registerRoute, NavigationRoute } from 'workbox-routing'

self.skipWaiting()
clientsClaim()
precacheAndRoute(self.__WB_MANIFEST)
cleanupOutdatedCaches()

//You can remove this code if you aren't precaching anything, or leave it in and live with the warning message
try {
  const handler = createHandlerBoundToURL('/')
  const route = new NavigationRoute(handler)
  registerRoute(route)
} catch (error) {
  console.warn('Error while registering cache route', { error })
}

I'm using generate.

Move the sw.js to src folder and update the pwa options, you need to "build" it since cannot use you're use import statements inside a service worker.
You can also change static import with importScripts but you will need to add them also to the public folder or use CDN.


[PHP] provideCompletionItems is not called for items inside of -> methods and also for variables starting with $

Issue Type: Bug
If you register a registerCompletionItemProvider in an exptension for PHP, it is not always called and completion items are not provided in the following cases:

Variable name starts with $

 arr_item = new ClassItem;
 a                         // Completion Item Provider called

$arr_item = new ClassItem;
$a                          // Completion Item Provider not called

Arrow functions

 arr_item = new ClassItem;
 arr_item.t          // Completion Item provider called for the keystroke t

 arr_item = new ClassItem;
 arr_item->t          // Completion Item provider not called for the keystroke t

NOTE: The completion item provider is not registered with any trigger characters.
VS Code version: Code 1.23.0 (7c7da59c2333a1306c41e6e7b68d7f0caa7b3d45, 2018-05-03T15:23:14.634Z)
OS version: Darwin x64 17.5.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz (8 x 2800)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 3, 3

Memory (System)
16.00GB (0.02GB free)

Process Argv
/Applications/Visual Studio Code.app/Contents/MacOS/Electron -psn_0_10988154

Screen Reader
no

VM
0%

Extensions (37)

Extension
Author (truncated)
Version

MochaSnippets
Ala
0.0.1

All-Autocomplete
Ati
0.0.12

vscode-markdownlint
Dav
0.16.0

xml
Dot
1.9.2

EditorConfig
Edi
0.12.1

jquery-snippets
Hri
1.0.0

latex-workshop
Jam
5.4.0

vscode-jest
Ort
2.7.2

code-settings-sync
Sha
2.9.2

quokka-vscode
Wal
1.0.124

html-css-class-completion
Zig
1.17.1

jslint
ajh
1.2.1

copy-relative-path
ale
0.0.2

npm-intellisense
chr
1.3.0

gitignore
cod
0.5.0

riot-tag
cri
0.1.7

vscode-eslint
dba
1.4.9

tslint
eg2
1.0.28

vscode-npm-script
eg2
0.3.4

php-intellisense
fel
2.3.1

auto-close-tag
for
0.5.6

code-runner
for
0.9.3

ginfuru-vscode-jekyll-syntax
gin
0.0.5

docthis
joe
0.6.0

sublime-babel-vscode
jos
0.2.10

prettify-json
moh
0.0.3

extension-manifest-editor
ms-
0.1.5

python
ms-
2018.4.0

cpptools
ms-
0.17.0

sublime-keybindings
ms-
4.0.0

wordcount
ms-
0.1.0

debugger-for-chrome
msj
4.4.3

elm
sbr
0.17.0

code-spell-checker
str
1.6.10

html-preview-vscode
tht
0.1.1

cmake
twx
0.0.17

better-align
wwm
1.1.6

If you register a registerCompletionItemProvider in an exptension for PHP

How do you register it? Any trigger character associated with it? Also, when no trigger character is hit you use the php word definition and trigger when at the start of a word. Last, there are user-settings to disable these things and I wonder if you any of them set?

context.subscriptions.push(vscode.languages.registerCompletionItemProvider('php', CompletionItemProvider));
I can provide a dummy extension where you can put a breakpoint if needed.

What is the php word definition?

I am not creating any PHP word definition separately (this is not a language server). Instead the code relied on whatever language definition is present by default in VSCode for PHP. I also tried adding PHP intelligence but did not get the correct calls.

Ok, that means $ and > aren't part of words and that you need to register those as separate trigger characters (arguably $ could be a word character). This is how the default completion item provider does it: https://github.com/Microsoft/vscode/blob/c562bd257d1e6034df2dee83e1b24b538e8ab34a/extensions/php-language-features/src/phpMain.ts#L20


Python upgrade

What was wrong?
Add Python 3.8 support.
Also, noted the missing PyPI identifier for Python 3.7 support.
How was it fixed?
Tests pass locally, but there was is a lot of tox combinations, decided to let it run to see if anything happens.
Cute Animal Picture

Also could probably remove 3.5 support eventually?

Thanks @fubuloubu


feat(seo): add initial package scaffold

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Purpose
This adds a package as described by #1632
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Can you add an entry to the contribution guidelines?

Can you add an entry to the contribution guidelines?

added


[BUG] hyprland-autoname-workspace broken since hyprland moved SOCK location

Describe the bug
hyprland-autoname-workspace cannot run under hyprland v0.40.0 since hyprland moved the location of its socket.
Program version?
❯ hyprland-autoname-workspaces --version
hyprland-autoname-workspaces 1.1.13
To Reproduce
Steps to reproduce the behavior:

Install latest hyprland-autoname-workspace
Run hyprland-autoname-workspace

❯ hyprland-autoname-workspaces
thread 'main' panicked at /home/johan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyprland-0.3.13/src/data/regular.rs:31:19:
A error occured while parsing the output from the hypr socket: IoError(Os { code: 2, kind: NotFound, message: "No such file or directory" })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior
hyprland-autoname-workspaces runs cleanly
Linux Distro (please complete the following information):

Arch Linux

Additional context
I believe this issue comes from using an older version of hyprland-rs. It seems hyprswitch successfully bumped it's dependencies and use the new alpha version. My rust skills are worthless at best, so I cannot verify and PR this on my own.

Can confirm issue on NixOS using the official Hyprland flake.

Can we get this as release? The nixpackage just defines a version. Otherwise, someone (?) would have to maybe make a flake.

done!


Adding the AntDeploy help to deploy applications

Adding the AntDeploy help to deploy applications.
AntDeploy - Visual stutio plugin to deploy applications to remote server(iis,windowsService,docker) support netframwork and dotnetcore,support rollback and increment deploy

AntDeploy - Visual stutio plugin to deploy applications to remote server(iis,windowsService,docker) support netframwork and dotnetcore,support rollback and increment deploy

Hey, it would be good to have more documentation translated to English. Currently I was able to get only a vague idea about what it does and no idea about why and how it compares to existing options like MS Deploy and existing docker/k8s cli tools.

Thanks , I see


How to enable Ipv6 connections?

Could you please tell me if there is a switch setting to enable ipv6 connections?

I assume that
uri = new Uri ($"{(socket.AddressFamily == AddressFamily.InterNetwork ? "ipv4" : "ipv6") }://{endpoint.Address}{':'}{endpoint.Port}");
in  src/MonoTorrent.Connections/MonoTorrent.Connections.Peer/SocketPeerConnection.cs
should be like this
`
uri = socket.AddressFamily == AddressFamily.InterNetwork ? new Uri($"ipv4://{endpoint.Address}{':'}{endpoint.Port}") : new Uri ($"ipv6://[{endpoint.Address}]{':'}{endpoint.Port}");
`
maybe?

also in monotorrent/src/MonoTorrent/MonoTorrent.Client.Connections/IPV6Connection.cs
Uri = new Uri ($"ipv6://{endpoint.Address}{':'}{endpoint.Port}");
should add a []

Yeah, that sounds about right. Urgh!
I'll see if I can fix this up properly, and validate ipv6 actually works end-to-end using an IPV6 enabled EC2 instance or something, before shipping 3.0.0 stable.
Unfortunately I'm still ipv4 only with my home connection.

After I changed
public static IPeerListener CreateTcp (int port)         {             return CreateTcp (IPAddress.Any, port);         }
to
public static IPeerListener CreateTcp (int port)         {             return CreateTcp (IPAddress.IPv6Any, port);         }
in PeerListenerFactory.cs
and
var connectionUri = new Uri ($"ipv4://{dict["ip"]}:{dict["port"]}");
to
var connectionUri = new Uri ($"ipv6://[{dict["ip"]}]:{dict["port"]}");
in Peer.cs ,line 189
now I can find other ipv6 peers and attempt to connect,
but all the ipv6 peers connection end with handshakefailed,
I can download from other ipv6 peer, but can not upload data to other ipv6 peer
Could you please tell me if I'm missing some key codes for connection?
Thanks a lot

Can you disable encryption by setting EngineSettings.AllowedEncryption to a list/array which contains EncryptionType.PlainText?
If that doesn't work, can you add a logger right at the start, before you begin using MonoTorrents apis, and share the logs created by it?
https://github.com/alanmcgovern/monotorrent/blob/09a6166606bafe34faf5752325af9afc4e18f578/src/Samples/SampleClient/StandardDownloader.cs#L34
It might make it easier to see what's happening.

I tested things on my local network and MonoTorrent can establish an IPv6 connection to qBittorrent (which uses libtorrent under the hood).
If you want to submit a PR containing the changes you've suggested i'd be happy to merge it in. Otherwise I'll try to integrate those suggestions, and find other places where ipv6 addresses are improperly handled, and then merge the changes. So far it looks like the only change I need to make in order to have things work is to use the fully qualifyed IPV6 address (with square brackets).
My simple test was to just do this:
await manager.StartAsync ();
await Task.Delay (1000);
await Engine.Torrents[0].AddPeerAsync (new PeerInfo (new Uri ("ipv6://[fe80::46dc:9b3d:bc61:79a7%7]:9253"), ""));

This allowed monotorrent to establish an IPV6 connection to the client listening at that address.

There are a few things I need to update to fully support ipv6. I'll track those here: https://github.com/alanmcgovern/monotorrent/issues/588
This support will be added to the 3.x branch, but won't be backported to the 2.x stable release as 3.x is pretty close to done and I'd rather implement and test these changes once. It'll be awkward to test without having an actual ipv6 connection.
If you'd like to test out these capabilities as they're implemented, just let me know by saying it in the issue #588 and i can ping when things are ready! Thanks for highlighting that this support is incomplete.


clean: factor test_expr_min_max out of test_common

What type of PR is this? (check all applicable)

[x] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[x] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #401

Checklist

[x] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below.

Strange, some unrelated tests failed :thinking:

Oh I committed manually, is that a problem? I didn't use GH's interface, I hope that's not a problem, it was just a small change

ah sorry i hadn't noticed at first, but this overlaps with https://github.com/narwhals-dev/narwhals/pull/457

Alright, closing in favor of #457


[SPARK-45871][CONNECT] Change .toBuffer.toSeq to .toSeq

What changes were proposed in this pull request?
This PR changes .toBuffer.toSeq to .toSeq in the Spark code because .toBuffer is redundant.
Why are the changes needed?
Remove redundant .toBuffer to avoid unnecessary collection copies
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Action
Was this patch authored or co-authored using generative AI tooling?
No

@LuciferYang I did a comparison:
class FooIter extends scala.collection.Iterator[Int] {
  var i = 0

  override def hasNext: Boolean = i < 10

  override def next(): Int = {
    i = i + 1
    println(s"$i")
    i
  }
}

val a = new FooIter()
a.toBuffer

val b = new FooIter()
b.toSeq

and in 2.13 I get
val b: FooIter = <iterator>
val res10: Seq[Int] = List(1, 2, 3, 4, 5, 6, 7, 8, 9, 10)

while in 2.12 I get
scala> b.toSeq
1
res1: Seq[Int] = Stream(1, ?)

So it seems that in 2.13 .toSeq should be fine to materialize the stream... but as said above, it would be great to have a test...
Actually, without access to session I think that does val iter = client.execute with something that has multiple responses, then iter.toSeq, then grabs the ExecutePlanResponseReattachableIterator from inside the iter and asserts that resultComplete == true would be sufficient.

@LuciferYang I think this test in ReattachableExecuteSuite could work
  test("Client execute iterator .toSeq consumes the reattachable iterator") {
    // There are places in the code that use .toSeq on the iterator to make sure it is fully
    // consumed. Check that it works.
    // (in scala 2.12, .toSeq results in a lazy stream, and .toBuffer.toSeq is needed)
    withClient { client =>
      val iter = client.execute(buildPlan(MEDIUM_RESULTS_QUERY))
      val reattachableIter = getReattachableIterator(iter)
      iter.toSeq
      assert(reattachableIter.resultComplete)
  }

(just drafted it, haven't tested it myself)

@LuciferYang I think this test in ReattachableExecuteSuite could work
  test("Client execute iterator .toSeq consumes the reattachable iterator") {
    // There are places in the code that use .toSeq on the iterator to make sure it is fully
    // consumed. Check that it works.
    // (in scala 2.12, .toSeq results in a lazy stream, and .toBuffer.toSeq is needed)
    withClient { client =>
      val iter = client.execute(buildPlan(MEDIUM_RESULTS_QUERY))
      val reattachableIter = getReattachableIterator(iter)
      iter.toSeq
      assert(reattachableIter.resultComplete)
  }

(just drafted it, haven't tested it myself)

Thanks for your help @juliuszsompolski ~ I will test it tomorrow

MEDIUM_RESULTS_QUERY

@LuciferYang I think this test in ReattachableExecuteSuite could work
  test("Client execute iterator .toSeq consumes the reattachable iterator") {
    // There are places in the code that use .toSeq on the iterator to make sure it is fully
    // consumed. Check that it works.
    // (in scala 2.12, .toSeq results in a lazy stream, and .toBuffer.toSeq is needed)
    withClient { client =>
      val iter = client.execute(buildPlan(MEDIUM_RESULTS_QUERY))
      val reattachableIter = getReattachableIterator(iter)
      iter.toSeq
      assert(reattachableIter.resultComplete)
  }

(just drafted it, haven't tested it myself)

This seems like a server-side test case, but the pr is modifying the client API implementation. In the future, if a server-side test case fails and we need to fix some client API, this logic seems a bit non-intuitive. So before making any changes, let me investigate how to directly test the API to be fixed on the client-side.

So before making any changes, let me investigate how to directly test the API to be fixed on the client-side.

Sure, you should be able to put a very similar test into client suites as well; I put it into ReattachableExecuteSuite because it has handy helpers like "getReattachableIterator" that you would need to reimplement on the client side, I think a very similar test could be added to SparkConnectClientSuite

In the future, if a server-side test case fails and we need to fix some client API, this logic seems a bit non-intuitive

ReattachableExecuteSuite is on the server side because it also tests and asserts what happens on the server when reattachable execution is used. But there are many client things that it tests as well... I think it's closely enough coupled that it's unavoidable. You may remember that I had a whole series of PRs in August where I was trying to restructure the module structure of this, to be able to test both in-process client and in-process server but communicating over RPCs at the same time... In the end had to move a bunch of client code to "common". This is not the cleanest I admit.

hmm... perhaps I misunderstood your point. But if they can achieve the same goal, iter.foreach (_=>()) should have better performance than iter.toBuffer. It only iterates through all the data and does not create any collection ..

Agreed that iter.foreach(_ => ()) should have better performance, but that also immediately discards all responses, so you then couldn't do
    val response = responseSeq
      .find(_.hasSqlCommandResult)

But then one could write to consume it afterwards...
   // find the response we care about
   val response = iter.find(_.hasSqlCommandResult)
   // consume the rest of the iterator
   iter.foreach(_ => ())

Maybe that would have been a better change, and not relying on the internal scala details of whether .toSeq or .toBuffer result in a lazy structure or not, and not materializing it needlessly...
You're right, maybe this would be indeed a better change (and then the test is not needed, as .foreach should be always reliable in consuming...)

Merged into master for Spark 4.0.
Thanks very much @juliuszsompolski for the help and suggestions provided during the development of this pr.
Thanks to @HyukjinKwon  for the review.


Update readme after GA release

Remove default prerelease option for installation command

Thanks - I totally forgot about this 😄


ULR encoding

Extremely annoying behavior described at https://github.com/rackt/react-router/issues/1079

Can't be fixed as of hardcoded browser, router etc. bevaviour.


Fix enum collision

Adds test via a reference DBML file from the core implementation, I was trying to use this dbml to validate my own project and ran across the enum collision bug

Nice catch! Thanks for the fix : }


nimble: Eatt initial implementation

This is rebased https://github.com/apache/mynewt-nimble/pull/773
Before merging this needs to be checked against specification and tested

TODO: it may be worth checking client_att_busy flag reset after disconnection. Because ble_gatt_conn_test_disconnect tests only GATT API for broken connection (connection instance still exists) it probably should be done as separate test, maybe in GAP.

Found bug in Read Multiple Variable Length handling: implementation is OK, but btshell must be changed.
Code seems copied from other read/write callbacks, but here format is different. Response is single message with multiple tuples of {length, value} pairs, that is up to MTU in size. If more should be returned, it's trimmed: so we don't use BLE_HS_EDONE to mark final message, we will receive only one, with success code of 0. struct ble_gatt_attr *attr points to the first attreibute in list, and num_handles must be used to access the rest

This was tested against PTS and implemented features are passing. After rebase some commits were added and some modified. Changes between rebase and current version can be seen here: https://gist.github.com/KKopyscinski/5ed12fe57bb457f21a8d98d2a84e0406
rebased version without these changes is here https://github.com/KKopyscinski/mynewt-nimble/tree/eatt_initial_rebase
TODO: Add support for sending Multiple Handle Variable Length Notification.

Looks like it was merged accidentally but if all is working then it is fine. I was about to approve it anyways.


SILGen: Fix generated vtable thunk when a final override is more visible than the base

Don't re-dispatch to the override's vtable slot if the override
is final; there's no vtable slot and this will result in an
infinite loop.
Fixes rdar://problem/52006394.

@swift-ci Please smoke test

LGTM thanks!


Make use of nested configuration Breaking Change

See 82f7b41 for most of the documentation
Config is parsed as json and not yaml. Because json is a subclass of yaml and
z2m excepts yaml this works well
makes use of device and group config as it was added to z2m with https://github.com/Koenkk/zigbee2mqtt/commit/516bd704c67b0c86a323e5d90d9149d539fa6e7e
this splits off group and device config from the main config, as it is not trivial to manage user input
and z2m independently manipulating a common config file.

Nice. The splitting off of devices and groups is a great change as it saves us from the Hassio limitations related to nesting. I’m assuming that zigbee2mqtt looks for those files in the same directory as configuration.yaml? Don’t think this behavior is documented. I’ll also think about how we can test this prior to deploying moving forward.

I’m assuming that zigbee2mqtt looks for those files in the same directory as configuration.yaml?

Yes, on my testing setup it works this way

Don’t think this behavior is documented.

you mean that it looks for it in the same file as configuration.yaml? Yes this is not documented. The rest is at https://github.com/Koenkk/zigbee2mqtt.io/blob/dev/configuration/configuration.md#specifying-devices-and-groups-in-a-separate-file

I’ll also think about how we can test this prior to deploying moving forward.

Year I'd like to hear how we could go on, not breaking to may setups. In particular I'm worried about network_key, I fear we might overwrite it for some people at some point and they don't have it backed up somewhere. Forcing them to repair all there devices. Hell I would be pissed if this happens.
Maybe we should setup a way of making a backup of the current config by copying to a sub folder of data_path. Once the backup is completed, we make a file called .made_backup. On subsequent runs, we check if the file .made_backup exists and skip the backup creation.
Or even further, instead of backing up, we initially merge the configurations once. This way we hopefully not mess up all the configs out there. However we would need to write some sort of parser just for this purpose.

@deisi Why the decision to build the edge version locally?
I'm thinking I'll merge this into a new dev branch for testing on my local machine. Maybe the dev branch can also have some "extras" in it that we have discussed on a previous issue that make it easier to develop, test, and build images locally.

Why the decision to build the edge version locally?
I don't know how else can test this on my server. I thought once we have tested it, we add the image again.

dev branch sound like a good idea. However if dev is so fundamentally different then master, simply merging dev into master for updates will not work. You have do to some sort of cherry picking and maybe do it by hand.

should I make this pr against the dev branch now?

Thanks, I tested this locally and things build and run. I'm going to work on the run script a little as well before merging anything into master and, therefore, updating the published edge version. I think you're right that it'd be a good idea to preserve former configuration.yaml files, particularly for the purposes of network_key. It'd be possible to merge with old config with jq, but the desired behavior for a first run would be to merge but keep the "old" stuff from configuration.yaml, while on subsequent runs the desired behavior would be the opposite (override old config with updated options from front-end). Therefore, I think the back-up solution is the simplest for our specific need right now. I could be missing something though, so let me know.
I'm also going to write up a CONTRIBUTING.md with some basic instructions for setting up for local development of this add-on.


Tooltip undefined during $destroy

I am having problems with lx-tooltip, when I use it with dynamically changing table data that somehow it gets undefined earlier than $destroy event is called.
So I get error
TypeError: Cannot read property 'remove' of undefined
    at lumx.js:3178
    ...

I would recommend just adding check in the tooltip $destroy handler function like this:
$scope.$on('$destroy', function(scope)
        {
            if (tooltip) {
                tooltip.remove();
            }
        });

I'm experiencing the same issue.
Using a ng-repeat filtered table whose cells have tooltips, refreshing the table's data throws the error for all hidden lines.

Will be fixed by PR #339


pip install from github

I tried to install from github using pip3 install git+https://github.com/jparyani/pycapnp@develop but it gives an error. I made a gist since the text output was too long. This is probably my fault for trying to install the package this way but i thought it might work, it would be a nice feature.
edit: instructions from the readme give the same results

It's a known issue with cython == v0.22.x. Downgrade with pip install cython==0.21.2 to resolve the issue. There is a fix for it upstream, but it seems that it won't land until a cython v0.23 release.

Actually, I just realized that the cython v0.22.1 update did fix this problem for pycapnp. Make sure you have the latest cython (pip install -U cython), and get my recent commit 3357771b393d4c4d218dfbc178e4715ca63b97da

This worked like a charm, thanks. Apparently my cython was a bit behind. Just as an FYI, this did work for your repo pip3 install git+https://github.com/jparyani/pycapnp@develop and it's a pretty neat way to get the newest version.


Classrooms attendees

Purpose
We need to collect attendees for each classroom sessions, and send them to the frontend for instructors.
Proposal
As we don't have access to webhooks, add a command to get current attendees for each running classroom, store their entering and leaving. Those data are added to the classroom serializer

[x] add ClassroomSession model to store attendees
[x] create a ClassroomSession when a classroom is started
[x] end the current ClassroomSession when a classroom is ended
[x] add command to update attendees for running classrooms
[x] add sessions to classroom serializer

Done in #2461


[Question]: Extract all fields from Postgres JSONB column to ES document root

PGSync version:
Version: 2.5.0
Postgres version:
15
Elasticsearch version:
7.8.0
Redis version:
7.0.4
Python version:
3.9.13
Problem Description:
I have a JSONB column with dynamic fields
eg
{
    "KEY_12": "value",
    "KEY_33": {"x": "y"},
    ...
}

I would like to extract all fields in this column and add them to the root of the ES document. Is this possible currently?
Error Message (if any):

You can do it in transform phase. See here [https://pgsync.com/tutorial/plugins/]


Fix getFeatureClasses() in schemaFuncs.py

schemaFuncs.py reflected the old implementation of getFeatureClasses, where it was implemented in featureextractor. As of 4771963, getFeatureClasses is implemented directly in the radiomics namespace. Update schemaFuncs.py accordingly.

Et voila. This can now be rebased on master. A fix for venv issue has been integrated.


Office docs corrupt on download from SF UI after loading with forcetk.js with VF sample

I'm using the sample listed on the repo to load files from a vf page with forcetk.js as a static resource.
Text files, gif, pdf, office docs all load from the vf page successfully.
However after I download office docs from the SFDC UI and try to open them they are corrupted.
The same files uploaded by the SFDC UI then downloaded open correctly
Text, gifs, pdfs open fine.

I merged a pull request recently (Oct 7) that might fix this - see commit 217010d - are you using a forcetk.js older than that?

I was using the latest. I changed the double newline to one. Works. Thanks Pat.


Send broadcast message missing notification_type and tag

The API in facebook docs look like this:

Where the function in facebook.js only include the creative_message_id

I can work on it if needed but we first have to agree on how the pass the missing two parameters.
I think we should convert the first param to an object.

Hello,
You're right ! we should include a two new parameters while sending a broadcast message, this API is no more in beta stage as FB published last week, notification_type  and tag  attributes are introduced by this new version.

How to pass the new parameters ?

Convert message_creative_id  to a JSON object is a smart idea, but be careful, maybe a lot of Botkit developers send broadcast messages based on the actual method signature :
controller.api.broadcast.send('<STRING_CREATIVE_ID>', <CUSTOM_LABEL>, function (err, body) {
    // Your awesome code here
});

To not introduce breaking changes, i think we should rename the parameter message_creative_id  to message_creative  and test inside send method if the developer gives us a String or an Object  :
if (typeof(message_creative) === 'string') {
     // Put the passed parameter into body.message_creative_id
} else {
     // Clone the passed parameter into body
}

With this approach we'll not introduce breaking changes and we'll give the possibility of sending the new parameters maybe other ones tomorrow !
WDYT ?

Your solution looks good. I created a pull request to add the new args #1280


Minor regression in types params names with 4.20240903.0

Diff<EMAIL_ADDRESS>Raw diff: https://github.com/Cloudflare-Mining/Cloudflare-Datamining/commit/66e958488df276e1d052cdb93e13b365e20fbd22#diff-498f7d22754cd92e5654b3be0adcae3df0c297abe440099d42dbc8cf43af66fd
FixedLengthStream previously had named paramaters:
declare class FixedLengthStream extends IdentityTransformStream {
  constructor(
    expectedLength: number | bigint,
    queuingStrategy?: IdentityTransformStreamQueuingStrategy,
  );
}

Now these are more generic with just param1 and param2:
declare class FixedLengthStream extends IdentityTransformStream {
  constructor(
    param1: number | bigint,
    param2?: IdentityTransformStreamQueuingStrategy,
  );
}

A few more methods/classes had the same thing occur including:

URL.canParse
URL.parse
IdentityTransformStreamQueuingStrategy
URLSearchParams
URLSearchParams.append
URLSearchParams.delete
URLSearchParams.get
URLSearchParams.getAll
URLSearchParams.has
URLSearchParams.set

@jasnell @anonrig have the implementations for streams or URLs moved? We generate parameter names by parsing the c++ AST so it's relatively sensitive to refactoring

The last change seems to be clang-format https://github.com/cloudflare/workerd/commits/main/src/workerd/jsg/url.c%2B%2B

No changes that I'm aware of that would cause this. Really odd. Could the formatting changes have broken the ast transform?

@penalosa ... I think we should first rule out a regression in the type generation logic. If that points to a change on the runtime side, then we'll investigate further but there really hasn't been much here that could have changed as far as I know.

It looks like this was partially resolved in the latest update:
<EMAIL_ADDRESS>FixedLengthStream has the correct param names again, as well as IdentityTransformStream, but not any of the others yet.


qutebrowser: 2.2.2 -> 2.2.3

Motivation for this change
https://github.com/qutebrowser/qutebrowser/releases/tag/v2.2.3
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[x] Fits CONTRIBUTING.md.

Uhm, looks like adblock doesn't build on darwin, we should only enable that conditionally.

@rnhmjoj I fixed adblock instead.


endpoints: API endpoint "category" to be defined once per namespace

endpoints: API endpoint "category" to be defined once per namespace

i can't remember what this issue refers to


Too much memory drained by Arduino library

Hi,
I'm trying to use an Arduino NANO (ATMEGA328P MCU at 16MHz) in order to write PWM, speed and position commands onto the board using machine protocol. The problem is that when I try to compile Arduino code, dynamic memory goes up to 321%, making it impossible to fit into the MCU. Is there any buffer or something on the library that I could remove in order to save enough memory??
Thank you!

Hey,
If you just want to write some values, you could use very simple commands without using the api.
The API is just a wrapper for the protocol part of bipropellant, not size optimized.

Thank you for your answer!! I only need to write PWM, Speed and Position data from an Arduino NANO. Getting voltage data in the Arduino could be awesome, but it's not too important. Could you please post me an example of a data array in Bytes to send to the board?? I have been reading Wiki but I don't get all the stuff at all. Thank you so much.

Have a look at https://github.com/bipropellant/bipropellant-hoverboard-firmware/blob/master/README.md#serial-machine-control
you can find a simple example there.

I've finally got it working. Thank you so much for your fast answers and for this amazing project.


fix elixir compatibility

@tessi here is why tests for OTP 25.2 / x are failing.
Order matter when we instantiate dependent links.
If Module B depends on Module A, we need to instantiate Module A before Module B
So, as in the unit test, we are passing in utils before calculator since calculator depends on utils.
links = %{
    utils: %{bytes: utils_wasm},
    calculator: %{bytes: calculator_wasm}
}

This order is preserved in Rust for OTP 26.2 / x where tests are passing.

However, the order is not preserved in Rust for OTP 25.2 / x and hence, the tests are failing since calculator module can't find utils upon instantiation.

@scrogson any ideas why the order of items is not preserved in the Rust vector for OTP 25.2?

uhhh good find! OTP 26 actually had this covered in their release notes:

Some map operations have been optimized by changing the internal sort order of atom keys. This changes the (undocumented) order of how atom keys in small maps are printed and returned. The new order is unpredictable and may change between different invocations of the Erlang VM.

https://www.erlang.org/news/164#maps
Rendering maps are unpredictable in their order. Which is totally how maps are defined, so fair call from Elixir. If we can't get around ordering in linked Wasm modules, we need to use some other solution.
I thought about keyword lists instead (since they are just lists with map-like syntax), but they also don't promise any ordering. Well, at least not when manipulating them - but constructing them should keep the order intact 🤔 (it's just a list of 2-tuples after all). In that sense: we could switch the implementation to kw lists. What do you think? or just make it proper lists of maps again?
In any way (kw lists, or lists of maps), we have the duplicated names problem back. I'm afraid we need a nice error when instantiating a module with duplicated links or need to filter links so that only the first name is taken (similar how Keyword.get([foo: 1, foo: 2], :foo) would only return 1).

wait! this problem only comes because we have a chain of links where ordering is important. So actually we don't want to order links properly, because (with many, many linked modules) this would be a mess to implement and maintain manually. We actually want nested links 🙈
like
links = %{
  calculator: %{
    bytes: calculator_wasm,
    links: %{utils: %{bytes: utils_wasm}}
  }
}

Right? we could then flatten this nested map and reverse it so that the most deeply nested dependency gets loaded first. (this doesn't solve for duplicated names, especially not if the same name points to a different module - but the initial solution on the PR also doesn't solve that edge case - so, fair enough, maybe! :D)

wait! this problem only comes because we have nested links where ordering is important. I think we actually don't want to order links in a flat list, because that is a faulty and wrong abstraction of the nested nature of the example you provided (with many, many nested linked modules this would be a mess to implement and maintain manually as a user of wasmex).
We actually want proper nested links 🙈 - like:
links = %{
  calculator: %{
    bytes: calculator_wasm,
    links: %{utils: %{bytes: utils_wasm}}
  }
}

Right? we could then flatten this nested map and reverse it so that the most deeply nested dependency gets loaded first. (this doesn't solve for duplicated names, especially not if the same name points to a different module - but the initial solution on the PR also doesn't solve that edge case - so, fair enough, maybe! :D)

That's what I was thinking as well. It's a lot more clear API.

@tessi supporting child links also mean we will be actually solving dependency issue (though we will still link all modules directly to the main in Rust). But we will have to parse and compile through the tree for all links in the map.

@munjalpatel true that we need still only have a flat list in rust. Is there a way with wasmtime to solve this proper? Could we give the nested list to rust and somehow make it work? (I actually don't know, but if you also don't know I could dig in a bit)

@munjalpatel true that we need still only have a flat list in rust. Is there a way with wasmtime to solve this proper? Could we give the nested list to rust and somehow make it work? (I actually don't know, but if you also don't know I could dig in a bit)

I am not sure about that either.

Hey folks! Sorry, I'm trying to get up-to-speed on this project and understand what problem is being solved.

@scrogson any ideas why the order of items is not preserved in the Rust vector for OTP 25.2?

I'm not sure, this is the first time I've seen this type of behaviour. The example in your comment is a little confusing given that you're using a map for links, but the current implementation is a list of maps isn't it?
@tessi in this currently implementation (Vec<LinkedModule>), map key ordering doesn't matter as this is a list of maps.
As for nested linking, from my limited understanding of how any of the WASM module linking works, it does seem that the structure would need to be something like:
#[derive(NifMap)]
pub struct LinkedModule {
    pub name: String,
    pub module_resource: ResourceArc<ModuleResource>,
    pub links: Box<Vec<LinkedModule>>
}

Does that seem correct?

Oh, after a further look, I think I realize that we were talking about different levels. I see now that at the higher level in the Elixir code, we're using a map which is later converted to a list of maps before calling the NIF.
So yes, unstable map key ordering was the issue. Looks like @munjalpatel got it sorted. 👍


Added icons and changed to new locale

Awesome! Thanks for doing this! I updated the icons for the MyQ SmartApp but totally forgot I'd need to fix the same thing for RainMachine.

No problem--you're welcome. I was tired of seeing the broken icon in the Smartthings app. :-)


Failed Install on Jetson AGX Orin 64GB Developer Kit

Greetings, I have been searching for a way to run koyha_ss on the Jetson AGX Orin within the nvidia container, so it will utilize the GPU. After copying this git and running the docker compose line, the following message was received.
user@ubuntu:~/kohya_ss-docker$ docker compose --profile kohya up --build
[+] Building 1.1s (22/27)                                        docker:default
=> [kohya internal] load build definition from Dockerfile                 0.0s
=> => transferring dockerfile: 5.35kB                                     0.0s
=> [kohya] resolve image config for docker.io/docker/dockerfile:1         0.3s
=> CACHED [kohya] docker-image://docker.io/docker/dockerfile:1@sha256:ac  0.0s
=> [kohya internal] load metadata for docker.io/library/python:3.10-slim  0.2s
=> [kohya internal] load .dockerignore                                    0.0s
=> => transferring context: 2B                                            0.0s
=> [kohya internal] load build context                                    0.0s
=> => transferring context: 187B                                          0.0s
=> [kohya base 1/7] FROM docker.io/library/python:3.10-slim@sha256:4bd9a  0.0s
=> CACHED [kohya base 2/7] RUN <<EOF (# apt for general container depend  0.0s
=> CACHED [kohya base 3/7] RUN <<EOF (# apt for extensions/custom script  0.0s
=> CACHED [kohya base 4/7] RUN <<EOF (# apt configurations...)            0.0s
=> CACHED [kohya base 5/7] RUN <<EOF (# cuda configurations...)           0.0s
=> CACHED [kohya base 6/7] COPY ./scripts/install-container-dep.sh /dock  0.0s
=> CACHED [kohya base 7/7] RUN <<EOF (# cuda cudnn + cutlass + tensorrt.  0.0s
=> CACHED [kohya kohya_base 1/8] RUN <<EOF (git clone https://github.com  0.0s
=> CACHED [kohya kohya_base 2/8] WORKDIR /koyah_ss                        0.0s
=> CACHED [kohya kohya_base 3/8] RUN <<EOF (# Build requirements...)      0.0s
=> CACHED [kohya kohya_base 4/8] RUN <<EOF (# tensorflow...)              0.0s
=> CACHED [kohya kohya_base 5/8] RUN <<EOF (# torch, torchvision, torcha  0.0s
=> CACHED [kohya kohya_base 6/8] RUN <<EOF (# xformers...)                0.0s
=> CACHED [kohya kohya_base 7/8] RUN <<EOF (# deepspeed...)               0.0s
=> CACHED [kohya kohya_base 8/8] RUN <<EOF (#jax/tpu...)                  0.0s
=> ERROR [kohya kohya_cuda 1/2] RUN <<EOF (# Hotfix for libnvinfer7...)   0.3s

[kohya kohya_cuda 1/2] RUN <<EOF (# Hotfix for libnvinfer7...):
0.276 + ln -s /venv/lib/python3.10/site-packages/tensorrt/libnvinfer.so.8 /venv/lib/python3.10/site-packages/tensorrt/libnvinfer.so.7
0.278 ln: failed to create symbolic link '/venv/lib/python3.10/site-packages/tensorrt/libnvinfer.so.7': No such file or directory

failed to solve: process "/bin/bash -ceuxo pipefail # Hotfix for libnvinfer7\nln -s $TENSORRT_PATH/libnvinfer.so.8 $TENSORRT_PATH/libnvinfer.so.7\nln -s $TENSORRT_PATH/libnvinfer_plugin.so.8 $TENSORRT_PATH/libnvinfer_plugin.so.7\n" did not complete successfully: exit code: 1
Any thoughts on getting past this, so we can move on with some training?

I am getting this same error on my Arch Linux desktop with my 4090. I have Nvidia Container Toolkit installed and the card works fine in some other docker containers.


Add rust-promote-module-into-dir

Lacking tests and completely untested on Windows!
closes #128

cc @nikomatsakis

Ah, d'oh... no file-name-base on Emacs 23. Pushing a fix.

ooh, neat, I should give this a spin. I have no idea how we would test it. :)

OK so I tried this a few times and...it seems to work for me. :) I say let's land it! We can always fix whatever obscure bugs crop up later. Thanks!


wB site should use github actions

Converte the site to use github actions instead of the classe GH pages approach

Done!


Add support for adjusting binary detection regex in FullHttpMessageFormatter

Q
A

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations?
no

Related tickets

Documentation

License
MIT

Regrettably, in our applications, php serialize() is often used instead of JSON as a serialization format used over wire. Instead of changing default regex for everyone (which could be a security risk in case target endpoint is untrusted), this allows to inject custom regex.
Checklist

[x] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
[ ] Documentation pull request created (if not simply a bugfix)

https://github.com/php-http/message/releases/tag/1.12.0


Add a property hint for SpinBox's custom_arrow_step property

Contains the property hint from https://github.com/godotengine/godot/pull/71425.
Only positive or zero values make sense for this property.

This reminds me, Range's step property allows negative values as well. Does this have any purpose?

Thanks!


Ethernet frame padding functionality duplicated?

Hello,
gopacket generates ethernet frames for TCP handshakes that are 6 bytes larger (60 bytes not counting fcs) than what some other libraries and tools will generate (54 bytes not counting fcs). Examples I checked against were dpkt for generation and zmap as a tool. The code to perform this is here:
https://github.com/google/gopacket/blob/master/layers/ethernet.go#L94
As the code comment indicates this is to comply with the minimum ethernet frame size of 60 bytes (not counting fcs). But this seems to be duplicating kernel / driver / NIC hardware functionality that will automatically pad frames to the proper length as needed.
I'm not sure what the right answer here. I just wanted to flag it so you can make the decision on if you want to continue handling this in your code or defer this to the network stack as other libraries and tools appear to have done.

@gconnell any guidance here ?

I'm not 100% sure, but I think I put that code in because otherwise at least one program I tried to write failed.  It may be that AF_PACKET doesn't allow <60byte, but pcap does, or PF_RING does but pcap doesn't, or something like that.  Or it could be entirely superfluous code that just takes up space and increases my KLOC github stats ;)
Unless there's an actual bug causing this to fail, I'd lean towards keeping things as they are.

I originally raised the issue as it posed some sort of analysis challenge. Unfortunately, it's been so long I no longer remember the specific context.
I'm fairly certain that AF_PACKET and pcap both are fine with < 60 byte packets. I can't speak to PF_RING (although that would not surprise me given the context).
How about you go ahead and close it and if I re-encounter the analysis issue I'll re-open and comment.

Ok. Let's close it for now.


Willing to migrate license to Apache 2.0?

I'm a committer on Apache Tika.  It would be great to include parso to handle sas7bdat files.  However, we can't include it with a GPL license.   Is there any chance you'd be willing to migrate to Apache 2.0? Thank you!

Hi Tim,
Thanks for your interest in parso. We will let you know as soon as we know more. By the way, would it work for you if parso is based on Java 8?
Igor

Great.  Thank you!  We'll be migrating to Java 8 over the next month or so.

OK, so we have the approval and desire to migrate to ALv2, I'm not sure when though.. We will try to finish it this year.

awesome thank you!

Thanks guys, we will do it on our side. Also we need to check what else should be included into this new version.


support for RS485

Hi,
There exist crate rs485 that define const from libc. The problem is that ioctls change signature depending on system platform (for example it accept c_int when using musl on x86 and c_ulong when use glibc on x86_64). So compilation fill when musl is involved:
rust-musl-builder-armv7 cargo build --examples                                                                                 18:21:01
   Compiling rs485 v0.1.0
error[E0308]: mismatched types
  --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/rs485-0.1.0/src/lib.rs:92:45
   |
92 |         let rval = unsafe { libc::ioctl(fd, TIOCGRS485, &mut conf as *mut SerialRs485) };
   |                                             ^^^^^^^^^^ expected i32, found u32

error[E0308]: mismatched types
   --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/rs485-0.1.0/src/lib.rs:186:45
    |
186 |         let rval = unsafe { libc::ioctl(fd, TIOCSRS485, self as *const SerialRs485) };
    |                                             ^^^^^^^^^^ expected i32, found u32

It would be nice to add  this constants (TIOCGRS485, TIOCSRS485) to libc. I am not sure how to do it properly. For musl target constant can be found here:
http://git.musl-libc.org/cgit/musl/tree/arch
in most cases looks like this:
#define TIOCGRS485	0x542E
#define TIOCSRS485	0x542F

but there are different here:
http://git.musl-libc.org/cgit/musl/tree/arch/mips64/bits/ioctl.h#n61

Looks like you've got a PR for this, which sounds great to me!

@gnzlbg I think no -- I just added implementation to musl target and it's still missing for others. I don't need more since I use just musl -- but I think rs485 crate will still fail to compile on others platform.

The RS485 crate define the constants itself, so it cannot fail to compile AFAICT.

Now when libc define TIOCGRS485 and TIOCSRS485 it can be used in rs485 crate - and it will successfully compile on all defined platforms <3

AFAICT this is only true if these constants have the appropriate types.


Update README description of MLJ to reflect non-macro pipelines

MLJ 0.17 now provides a facility to build pipelines which does not require macros.

Codecov Report

Merging #20 (684d59e) into master (d65b4ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   92.05%   92.05%
=======================================
  Files          14       14
  Lines         340      340
=======================================
  Hits          313      313
  Misses         27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d65b4ba...684d59e. Read the comment docs.


Fix version conflicts caused by PR#713

I encountered a similar dependency hell issue when bump Microsoft.EntityFrameworkCore.Sqlite from 5.0.6 to 5.0.9. (PR#713).
Hope this fix can help you.
Best regards,
sucrose

Thanks @sucrose0413! I've been meaning to fix some of the dependency updates, but haven't had the time lately. The integration test that actually hits an Azure Kubernetes Instance may fail (as I've taken that service down temporarily, so I may need to fix that before this passes). Appreciate your contribution!


Allow commits in a workspace to be consolidated.

To support workspace-wide configuration, we had to make a small tweak to how the config layering works.  We already needed to do this to help people who want different defaults for their workspace and their root crate.  I thought it already behaved this way and was suggesting people take advantage of it to work around their problems.
I was lazy and also included a documentation update for a past change.

How about make consolidation a command line only option? With which we can avoid conflicts between workspace and crate level configuration.

a command line argument would be annoying to pass in every time.  We could use the workspace-config concept for this though.  When I get a chance, I'll give that a try.


Increased ssh timeouts for win2k8 builds

The windows update process takes a very long time to bring up to date.
I could not get this to build in less than 4h even on fast internet connection.

It took about 2.5 hours to run Windows updates for me on win2008

Same proble, vote for merge

+1. Even on a 1Gb connection, it's taking 5+ hours. In that case, I don't think the speed of the link is the issue. It's just there are so many patches that it takes win2008 that long to download, apply, reboot; download, apply, reboot; ...;

Willing to merge as windows updates take ages on these old ISOs.


*: remove the remaining references of tikv-importer

What have you changed? (mandatory)
Some non Rust files still references the tikv-importer binary, which may break the CI.
What are the type of the changes? (mandatory)
The currently defined types are listed below, please pick one of the types for this PR by removing the others:

Misc (other changes)

How has this PR been tested? (mandatory)
N/A
Does this PR affect documentation (docs) or release note? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No
Refer to a related PR or issue link (optional)
#5036.
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)

/run-integration-tests


Revert "Fix MST propagate state (#1721)"

This reverts commit ac07fe6
Signed-off-by: kamilsa<EMAIL_ADDRESS>

Description of the Change
Turns our that fix #1721 is not needed anymore, because everything works without it
Benefits
Working dev without fix
Possible Drawbacks
None

Seems CI don't agree with you

rebased the revert and the fix


Save file loads to clouds / unable to generate map

Please provide a brief summary of the bug
Pokewilds load save to clouds screen can open menu and select items/pokemon/anything.
if you try to move it says it needs to generate a map, click yes and it's never able to load.
ram slowly ramps up to filling up all 16gb i have available then drops off.
Please provide steps to reproduce where possible
No response
Expected Results
load new map
Actual Results
unable to load
What Java Version are you using?
"1.8.0_291"
What is your operating system and platform?
windows 11
21H1 - 22000.978
How did you install Java?
No response
Did it work before?
No response
Did you test with other Java versions?
No response
Relevant log output
No response

@HammYzz Are you able to tell us which version of our Java that you are using?

I can check when I get home from work.
I ended up moving my save file to a vm that had 64gb of ram and was able to
load the game.
Save it.
Then move the save file back to my laptop and continue playing.
I dont know if it's from me moving to a lot of different worlds on my save
file or what, but seems to be resolved now.
I was able to generate another map just on my laptop after this though.
On Wed, Oct 5, 2022, 07:40 Martijn Verburg @.***> wrote:

@HammYzz https://github.com/HammYzz Are you able to tell us which
version of our Java that you are using?
—
Reply to this email directly, view it on GitHub
https://github.com/adoptium/adoptium-support/issues/596#issuecomment-1268382897,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3NFUJTQPKIWK2BIMSYXPNTWBVZMHANCNFSM6AAAAAAQ4F724I
.
You are receiving this because you were mentioned.Message ID:
@.***>

OK, sounds like the heap simply needed to grow beyond 16GB before settling back down to a smaller size.  It may be worth contacting the authors of that program to see if they can reduce the memory consumption of their maps.


Button Radio

Hello, my button /setfrequency not working, can you help me please

Hi mate, /setfrequency will only work if it is a command that the server owner has created, you will need to check with them to see if its available

Yep I have it t /changeradio 918Sent from my Galaxy
-------- Original message --------From: Josh Bowden @.> Date: 2023-02-14  8:23 p.m.  (GMT-05:00) To: EggRP/fxcommands @.> Cc: Subscribed @.***> Subject: Re: [EggRP/fxcommands] Button Radio  (Issue #13)
Hi mate, /setfrequency will only work if it is a command that the server owner has created, you will need to check with them to see if its available
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Ok, I tried the right order, and it still doesn't work
Le mer. 15 févr. 2023, 02:23, Josh Bowden @.***> a
écrit :

Hi mate, /setfrequency will only work if it is a command that the server
owner has created, you will need to check with them to see if its available
—
Reply to this email directly, view it on GitHub
https://github.com/EggRP/fxcommands/issues/13#issuecomment-1430617179,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQVH6H7SYQDWR64U6IHFDXTWXQVYBANCNFSM6AAAAAAU3RFCQE
.
You are receiving this because you authored the thread.Message ID:
@.***>

The issue is, what we found through a quick debug session - Is that server-side only commands aren't able to be triggered directly through an external plugin call into the console.
If the command was registered on the client, you will be able to trigger it with the plug-in
One work-around around the issue is creating a multi-action step:

Create a RunCommand action, that runs bind keyboard F7 "changeradio 918"
Delay 250ms
Hotkey - Press F7
RunCommand action - unbind keyboard F7

Bit arse we have to do that, I'd love being able to avoid this. I'm not sure how the plugin hooks onto the FiveM instance so it can issue commands directly to the console, but perhaps there's another way?


What's the proper chain to use when adding logging for use with this project?

The setup instructions on the README just have this: iptables -A CHAIN_NAME -j LOG --log-prefix "EXAMPLE_LOG_PREFIX: "
What is typically used as CHAIN_NAME? I assume this should be a chain with a policy of DROP as a chain with the policy of ACCEPT would just result in logging everything that passes through and this project would assume that they're all dropped packets, no?
Also, should this rule be added to the filter table or would there be a reason to add it to the nat table instead?
What's the standard chain name to use? We have a pretty basic Kubernetes setup with the following chains:
*filter
:INPUT ACCEPT [7233:2389351]
:FORWARD DROP [0:0]
:OUTPUT ACCEPT [7974:2056167]
:DOCKER - [0:0]
:DOCKER-ISOLATION - [0:0]
:DOCKER-ISOLATION-STAGE-1 - [0:0]
:DOCKER-ISOLATION-STAGE-2 - [0:0]
:DOCKER-USER - [0:0]
:KUBE-EXTERNAL-SERVICES - [0:0]
:KUBE-FIREWALL - [0:0]
:KUBE-FORWARD - [0:0]
:KUBE-SERVICES - [0:0]

Is FORWARD typically the best place to add our LOG rule for this project?

I would very much like to know this too.. @hopper-signifyd did you figure it out ?

I see this chart adds the rule via a calico GlobalNetworkPolicy object - but that doesn't work for me - https://github.com/honestica/lifen-charts/issues/69

@KlavsKlavsen I couldn't get this working. The lack of any sort of timely response to this ticket made me realize that I was really on my own if I wanted to use this project. So I ditched this project and moved on to something else.

@KlavsKlavsen I answered on the issue and it should work by specifying the right version you are using.
@hopper-signifyd We maintain a helm chart which do all the setup https://artifacthub.io/packages/helm/lifen-charts/kube-iptables-tailer, happy to help if you any issue.

We got it working. Moving to using tigera operator to update calico - made v3 api available - and hence the chart worked (we also had to rebuild docker image - v0.2.2 of it for it to work)


support redis as a global var in lua scripts

by supporting both ledis and redis as the global lua script var,
we keep ledis support as it is, while also supporting redis clients,
which will be sending scripts, whilst assuming redis is the global

Thanks @GlenDC

Wow, that was fast, thanks @siddontang. I'm working on integrating github.com/yuin/gopher-lua right now. So you should see a (new) PR for that within the next 24 hours. As you accepted this PR, I'll also make sure to support both ledis and redis in that PR as a global var. Thanks once again :1


As an Admin User, when I click on " feature pages" and "about pages" in the curation facet of my dashboard, an error is thrown up.

@hackartisan  this is rather urgent, as it is holding up a DPUL site that is being worked on by students in SC for a class.
impact: the DPUL site cannot be publlshed until another page is created by Brian (the graduate student overseeing the work for the DPUL site), thereby completing the site for the class.
Error I/he is being given:

Collections affected: seemingly all of them

👀

It looks like this is a bug resulting from a rails security update: https://github.com/advisories/GHSA-hjg4-8q5f-x6fm / https://github.com/rails/rails/commit/c4c21a9f8d7c9c8ca6570bdb82d64e2dc860e62c
the error in honeybadger:
https://app.honeybadger.io/projects/51733/faults/79350481

@kelea99, thanks to @bess this is sorted out and it's deployed.

@hackartisan and @bess , you both are awesome. thank you so much!!

Works!


Increase Reinforcement TC count from 12 to 13

About the PR

If 2 Syndies have 16 TC (essentially the base), and kill Renault for 5TC, they can buy 3 agents which in all is not that difficult. As seen yesterday it was also obvious that with the right plays and a little luck you can easily control the entire station in about 5 minutes.
13 TC would make it far more difficult for 2 Syndies to get 3 agents. Sure you can still go from 2 Syndies to 4 but it's more equal to the general firepower. This doesn't solve the probability problem that one of the 5 might go ham on everyone and everything but it makes it a bit more handle able.
I'm open to increasing it even higher but 13 should work decently and still keep agent a possible buy.
Changelog

:cl: BlitzGunner225

tweak: Tweaked Syndicate reinforcement radio from 12 to 13

add your name next to the :cl:
ex:
:cl: blitz

add your name next to the 🆑
ex:
🆑 blitz

Aight done


How can I set a custom property to a node and query with this property

Describe the solution you'd like
I want to do dstGraph.setNodeProperty(method, "modified", true) in a custom pass,
and later do cpg.method.property("modified").l

That should "just work", there's a lot of passes in the joern codebase that do exactly that. If you need more help debugging something, please share a complete example.
Some notes

don't forget to apply the pass!
'modified' isn't a legal property on method, since it's not defined in the schema.

if you want to set properties not defined in the schema, you could also consider using tags (which are implemented not as properties but as separate nodes connected via edges):
joern> val m = cpg.method.head
m: Method = Method(
    ...
)

joern> m.start.newTagNodePair("modified", "true").store()

joern> run.commit
The graph has been modified. You may want to use the `save` command to persist changes to disk.  All changes will also be saved collectively on exit
res4: Cpg = Cpg (Graph [18 nodes])

joern> cpg.tag.nameExact("modified").valueExact("true").method.l
res5: List[Method] = List(
  Method(
    ...
  )
)

Thanks! newTagNodePair and newTagNode are the way to go for custom properties.
reference: https://docs.joern.io/cpgql/augmentation-directives/


add a new contributor/stgabi.md

Thanks @stgabi ! Share this with your friends. Let's make this a big list!


Offline download for container images

AKS Arc required container images are already included in the vhdx and supported as part of the offline download. Closing.


Using this for code gen?

Can we use this for code generation?

Hi @krrishdholakia SetFit is designed for classification tasks, so it is not possible to use this for code generation.


When can i get the cache file while i start filessystem

hi, i have a question about: i want to get the cache file when start filesystem. i try to use the hook about "done" like this
compiler.hooks.done.tap('', () => {
// get the cache filesystem
})
but i field.
which hook in compiler or compiler.cache can i use to get the filesystem cache?

You should not touch cache file, please use Discussions for questions


RFM - megui

I DON'T Want To Become The Maintainer

[x] I have followed the Package Triage Process and I do NOT want to become maintainer of the package;
[x] There is no existing open maintainer request for this package;

Checklist

[x] Issue title starts with 'RFM - '

Existing Package Details
Package URL: https://chocolatey.org/packages/megui
Package source URL: https://github.com/dtgm/chocolatey-packages/tree/master/automatic/megui/
Date the maintainer was contacted (in YYYY-MM-DD): 2021-12-13
How the maintainer was contacted: Email

Hello @pauby ,
I'll take this package.
Can you assign me this issue ?
Thank you


[fix]:Removed popup when Donate is clicked

Prevents the modal from popping up on clicking Donate button in navbar.
Closes #109

@Virtual4087  Ah! My bad.  Done the changes now, kindly have a look.


Problem configuring a notebook to use a Spark cluster

When I try to reconfigure the notebook VM runtime environment, and click on the "Configure as Spark cluster" checkbox, the UI closes and doesn't let me finish setting up my new configuration.
Before clicking the Spark checkbox:

After clicking the Spark checkbox:

@dglazer is this still an issue now that the Free Credits banner is dismissible?

It's not a blocking issue for me, since I can just get rid of the banner.
Up to you all if it's worth tracking down to avoid breakage for people who
don't dismiss the banner, or for any future top-of-page stuff we add.
On Wed, Feb 13, 2019 at 1:15 PM Kate Voss<EMAIL_ADDRESS>wrote:

@dglazer https://github.com/dglazer is this still an issue now that the
Free Credits banner is dismissible?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/DataBiosphere/saturn-ui/issues/1098#issuecomment-463374249,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFjg3XgT3WaGL6abANuxlW30JRMUu8jvks5vNIBYgaJpZM4aL0V9
.

This actually appears to happen whenever there isn't enough height in the window to show the popup. @panentheos thoughts?

Yeah, this is an issue with the positioning of the popup. I think we should consider making it a modal, since it's so large/complex. We had discussed this a while back, I think.


Resugaring is flipping arguments of foralls

This is absolutely confusing. Look at the definition of test, and what's output by F* when I provide --dump_module. The e binding is now between x and y, which also makes y unbound in the type of e. I believe it's the resugaring instead of pretty printing since this doesn't happen with --print.
Ran into this looking at some SMT queries that were failing, and thought they were actually being encoded wrongly.
Looking at it now.
module T

let test = forall (x:int) (y:int) (e : x+1 == y-1). y-x == 2

guido@fox:~/r/fstar/master(master)$ ./bin/fstar.exe --dump_module T T.fst
Module after desugaring:
module T
Declarations: [
[@ ]
logic let  test  : _ = forall (x: Prims.int) (e: x + 1 == y - 1) (y: Prims.int). y - x == 2
]
Exports: [

]

Module before type checking:
module T
Declarations: [
[@ ]
logic let  test  : _ = forall (x: Prims.int) (e: x + 1 == y - 1) (y: Prims.int). y - x == 2
]
Exports: [

]

Module after type checking:
module T
Declarations: [
[@ ]
visible logic let  test  : Prims.logical = forall (x: Prims.int) (e: x + 1 == y - 1) (y: Prims.int). y - x == 2
]
Exports: [
[@ ]
visible logic let  test  : Prims.logical = forall (x: Prims.int) (e: x + 1 == y - 1) (y: Prims.int). y - x == 2
]

Verified module: T
All verification conditions discharged successfully

Yikes, look at this one:
let test4 = forall (x1 x2 x3 x4 x5 x6 : int). True

visible logic let  test4  : Prims.logical = forall (x1: Prims.int)
  (x3: Prims.int)
  (x5: Prims.int)
  (x6: Prims.int)
  (x4: Prims.int)
  (x2: Prims.int).
  Prims.l_True

Fix incoming.


add PyTorch 1.0 support

Test it in Pytorch 1.0.1 with cuda 10 and python 3.6.5.

Thanks for the PR.

would this also work on PyTorch 1.1?


support matches, variables, logs and table panels

Summary
First, I just want to say all of this will be nicer with tabular result format.  Much of this code is working around limitations imposed by our current data-structures.
Several things going on here:

support for handling results with matches (filter queries)
support for evaluating $var before executing APL queries
support for using APL to define query variables
now you can use logs and table panels in dashboard
combine these panels with variables for dynamic dashboards

Finally, a bunch of this is simply copy/pasted from other examples I could find to make this work.  Do not hesitate to ask questions about the details...
Impl Notes
Some parts of Grafana will only work correctly if you write your APL in a particular way.  Some notes:

Logs panel needs to have _time.  You can customize what you project, but be sure to include _time
Some queries should NOT include _time, specifically if you are building a variable query, trying to find distinct values to filter with

When using axiom-go with APL filter queries it is not possible for us to determine whether or not the query projected _time or not.  This is an important distinction as the notes above indicate we need to support queries both with and without _time projected.  I have done my best to work around this for now, using the LegacyRequest projections field to let us know whether or not to project _time or not.  This seems to work OK, but it required me to duplicate a bunch of code from axiom-go.  All of this code is confined to the new client.go.  Long-term this should either all migrate to tabular result format, or lead to improvements in axiom-go.
Examples
Here is a dashboard with Logs and Table panels using Axiom APL query:

Here is the edit page for that logs panel, you can see the APL query used:

Here I am defining a new variable of type Query with an Axiom datasource, the APL query finds distinct values, useful for filtering:

Here you can see the values returned to verify before saving:

Here I have updated the query to combine the Grafana variable with APL variables:

Here you can see the dynamic dashboard, I have a drop-down populated with live values from the variable query, and when I choose a new value, the dashboard will update to reflect the changed filter:

AWESOME


Unable to pull data from web proxy

Unable to pull data from web proxy in  case when the storage system is registered within a proxy  using ip addresses of both  controllers

Hi @Zubrania.
Can you provide the json output of doing a get of /devmgr/v2/storage-systems?


feat(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1577

Questions ?
Please refer to the Backport tool documentation


Mention Cyberduck problem and solution

Documents the solution to a common Cyberduck issue experienced by data users when trying to download large files.

we're doing a delphi-epidata release tomorrow morning. if you need the docs published earlier you may need to cherry-pick them into main

Tomorrow morning should be fine.


Move CLI options to build params

It seems really strange that there are settings that can only be set in the CLI. I think it makes more sense to have all settings in the build object inside of package.json.
Specifically, I'd like to be able to control things on a per OS level. Like what distribution output type to use (which for some reason you call a "target"??? even though the target should actually be the OS/Arch).
Here's an example of one possible implementation for the API:
{
  "scripts": {
    "start": "nw .",
    "dist": "build ."
  },
  "devDependencies": {
    "nw": "sdk",
    "nwjs-builder-phoenix": "^1.x.x"
  },
  "build": {
    "nwVersion": "latest",
    "nwFlavor": "normal",
    "concurrent": true,
    "mirror": "https://dl.nwjs.io/",
    "files": [ "**/*" ],
    "excludes": [
      "package-lock.json",
      "assets"
    ],
    "win": {
      "icon": "assets/icon.ico",
      "arch": [ "x86" ],
      "targets": [ "nsis7z" ]
    },
    "mac": {
      "icon": "assets/icon.icns",
      "arch": [ "x64" ],
      "targets": [ "zip" ]
    },
    "linux": {
      "arch": [ "x86", "x64" ],
      "targets": [ "7z" ]
    },
    "nsis": {
      "icon": "assets/icon.ico",
      "unIcon": "assets/unicon.ico"
    }
  }
}

Things in the top level of build are globally applied to all platforms (like arch or targets), but if the setting is also inside of a specific platform, then it overrides the global setting because it's more specific.
Doing this means saving a lot of time on builds because I only need to do 1 zip build instead of 4, 2 7z instead of 4, and 1 nsis7z instead of 4. meaning I'm doing 4 builds and not 12. Though if this causes breaking changes, I would also say go all in and rename targets to outputType or distributionType or something that makes more sense.

After some more thought, I think it makes more since to have tasks as an array of objects, rather than limiting the tasks to just the OS platform.
{
  "scripts": {
    "start": "nw .",
    "dist": "build ."
  },
  "devDependencies": {
    "nw": "sdk",
    "nwjs-builder-phoenix": "^1.x.x"
  },
  "build": {
    "nwVersion": "latest",
    "nwFlavor": "normal",
    "concurrent": true,
    "mirror": "https://dl.nwjs.io/",
    "files": [ "**/*" ],
    "excludes": [
      "package-lock.json",
      "assets/*",
      "dev-utils/*"
    ],
    "nsis": {
      "icon": "assets/icon.ico",
      "unIcon": "assets/unicon.ico"
    },
    "tasks": [
      {
        "platform": "win",
        "arch": "x86",
        "icon": "assets/icon.ico",
        "target": "nsis7z"
      },
      {
        "platform": "win",
        "arch": "x86",
        "flavor": "sdk",
        "icon": "assets/icon.ico",
        "target": "zip",
        "outputPattern": "${NAME}-${VERSION}-${PLATFORM}-${ARCH}--DEVBUILD",
        "excludes": [
          "package-lock.json",
          "assets/*"
        ],
      },
      {
        "platform": "mac",
        "arch": "x64",
        "icon": "assets/icon.icns",
        "target": "zip"
      },
      {
        "platform": "linux",
        "arch": "x86",
        "target": "7z"
      },
      {
        "platform": "linux",
        "arch": "x64",
        "targets": "7z"
      }
    ]
  }
}

With this approach, you could produce as many builds as you want of any combination of settings. A good use case of this would be to create a developer build in addition to normal builds that uses the SDK flavor instead of just normal.

and just to be clear, while i still like command line options for purposes of integrating with other tools, i do also agree with this proposal. it would in fact solve for my use case as well.


Users are currently unable to view "All Projects" on staging

Steps

Users visit the Giveth staging https://staging.giveth.io/
Clicks on "Projects" from the header
Clicks on "All Projects"

This issue is no longer reproducible


MWC Drawer: support styling for app content

Is your feature request related to a problem? Please describe.
I would like to change background color of app content via CSS variables.
Describe the solution you'd like
Using global CSS variables to style the app content div inside the drawer.
Describe alternatives you've considered
Workaround: Javascript

Thanks for the bug! We're aware of the issue and we're currently tracking support of this in https://github.com/material-components/material-components-web-components/issues/953.
At the moment we're focused on revamping our components' theming system which will support this feature.


Prepare messaging for users trying to update their new BCROS accounts in response to the new BAR filing

Once a corp receives a link to file using the new BAR filing, and they create an account in BCROS, they will only have access to tombstone info and will have no options to update their account until the data is migrated from COLIN to BCROS. As a result, some users may be confused if they try to update their new BCROS account (product selection, etc).
We need to prepare some responses for staff and helpdesks in case users call with this issue.

@nsmenon8890 - can you please provide an update on this tix? Thx

Pay team is working  with : https://app.zenhub.com/workspaces/pay-team-space-649992c7f903a02c9b33009f/issues/gh/bcgov/entity/23652
They have added this ticket to sprint 23.3


Remove hidden allocations due to array literals

A bit of a boring commit, but I built imageformats with -vgc and there was a bunch of array literals.
In D array literals have type T[] (slice aka dynamic array) and just writing a literal may trigger allocations.

Thank you.


Import Foundation

Thanks for catching this! I also had to update the project so I pushed both of those https://github.com/keith/MD5Digest/commit/d63195ffbc26d15ae026586a33eba8636a74aabf
I've also pushed 1.0.0 to CocoaPods with this as the only change.


add check for ELECTRON_RUN_AS_NODE

when you fork a proc in electron, this will help node-gyp-build detect that it's still in electron

3.1.0


label gets misaligned in navbar

http://www.bootply.com/QK8xizMUE1
When using a Label in a navbar it gets misaligned.

Hi @vanillajonathan!
You appear to have posted a live example (http://s.bootply.com/render/QK8xizMUE1), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 9, column 9: W013: Bootstrap version might be outdated. Latest version is at least 3.3.4 ; saw what appears to be usage of Bootstrap 3.3.1
line 66, column 9: W013: Bootstrap version might be outdated. Latest version is at least 3.3.4 ; saw what appears to be usage of Bootstrap 3.3.1

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

With 3.3.4 (sorry Bootply had outdated Bootstrap references).
http://jsbin.com/rasezoqeba/1/

Hi @vanillajonathan!
You appear to have posted a live example (http://jsbin.com/rasezoqeba/1/edit), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

W002:  is missing X-UA-Compatible <meta> tag that disables old IE compatibility modes

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Updated to comply with Bootlint.
http://jsbin.com/vusajiwawe/1/

Seems this was solved by wrapping the label in
. Sorry.


feature/allow-developer-use-section-directly

BREAKING CHANGE
A a developer I would be able to use the sections array fields and not only the facts array fields.

This PR allow us to create teams notifications like that and more.
(doc : https://learn.microsoft.com/fr-fr/outlook/actionable-messages/message-card-reference)

Since this repo was not updated for a long time I have create a new plugin that uses the recommended workflows app: https://github.com/Kondamon/fastlane-plugin-teams_card


Add ability to load config directly from typesafe config object

Unfortunately, this leaks a TypeSafe type through the driver API, which is forbidden:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.1.1:javadoc (check-api-leaks) on project java-driver-core: An error has occurred in Javadoc report generation:
[ERROR] Method com.datastax.oss.driver.api.core.config.DriverConfigLoader.fromConfig leaks com.typesafe.config.Config (as parameter 'config')

What you are trying to achieve is already doable using the driver's internal API:
DriverConfigLoader loader =
        new DefaultDriverConfigLoader(() -> ConfigFactory.load());

Unfortunately the ... part in your example has to include fallback to the cassandra reference conf. This happens naturally if you're using an application.conf and simply using ConfigFactory.load(), but if you're loading config from other sources and have a resolved Config object, this requires something like the following in the client codebase to work:
      config
        .withFallback(ConfigFactory.defaultReference(classOf[CqlSession].getClassLoader))
        .resolve()
        .getConfig("datastax-java-driver")

That aside, the API already leaks typesafe config in the example you've provided, just not in that class (DefaultDriverConfigLoader already takes a Supplier<Config> configSupplier as a parameter). Maybe it would be more acceptable to put this method into DefaultDriverConfigLoader instead of in DriverConfigLoader, that would satisfy the exposure requirement, but arguably it would make the method more difficult to discover for users.

Unfortunately the ... part in your example has to include fallback to the cassandra reference conf.

Yes, to get all the driver defaults. But is that a problem? With your PR, you would have to include that fallback too, wouldn't you?
(If you are looking for ways to get rid completely of TypeSafe Config, we do offer a new API: OptionsMap. Unfortunately, I just discovered that we have a subtle bug to solve: JAVA-2889 – but you can still try it out).

That aside, the API already leaks typesafe config in the example you've provided, just not in that class (DefaultDriverConfigLoader already takes a Supplier<Config> configSupplier as a parameter).

The driver distinguishes two main packages: api and internal. Everything in api packages is considered public API and must abide by strict backwards compatibility rules; everything in internal is considered internal and subject to change without further notice (even if we try to remain backwards compatible if possible). The class DefaultDriverConfigLoader is in an internal package, and thus is allowed to reference TypeSafe.
So far we consider TypeSafe Config as an implementation detail, so it can only appear in internal packages.
Hope that helps.

With the PR, that fallback happens internally in the driver; without it, the client has to copy code from inside the driver into their client in order to achieve the fallback to the cassandra reference.conf themselves.
I appreciate the need for rules based on package and for backward compatibility. As such, would we be happy if I moved the method in this PR into the internal package instead?

With the PR, that fallback happens internally in the driver; without it, the client has to copy code from inside the driver into their client in order to achieve the fallback to the cassandra reference.conf themselves.

I am a bit uncomfortable with this for a few reasons:

If you pass an already-constructed Config object, how can you know if this object contains the entire config, or just a few portions of it? How can you determine the right way to construct the final config if you don't know how this object was obtained? This makes the API contract for the new fromConfig method a bit unclear.
If you pass an already-constructed Config object, maybe your application is using TypeSafe Config to configure other parts of the system. In this case, it's not impossible that other reference.conf files could be present – but then, loading the reference config using ConfigFactory.defaultReference(classOf[CqlSession].getClassLoader) is almost certainly wrong, since the driver's class loader may not be able to locate other reference.conf files. You probably need instead: ConfigFactory.defaultReference().

For these reasons, I'm inclined to think that if a user has already constructed half of their TypeSafe config outside of the driver, then it's their responsibility to build the entire config themselves, then pass it to the driver:
Config config = myCustomConfig().withFallback(ConfigFactory.defaultReference()).resolve()
DriverConfigLoader loader = new DefaultDriverConfigLoader(() -> config.getConfig(DEFAULT_ROOT_PATH), false)
CqlSession session = CqlSession.builder().withConfigLoader(loader).build();

Would the above work for you?

I think the first point applies to any method you use to pass the config to the config loader; whether it's a file, a string or a typesafe object. With the second point, I believe it's the application's responsibility to pass a relevant typesafe object to the loader, and one that would not break their application when the cassandra reference.conf if picked up. Again, that is the same responsibility the application has when passing a string or a file.
I suppose the point of contention is the value of exposing a convenience method for typesafe config integration vs exposing the DEFAULT_ROOT_PATH of the cassandra config root as per above. The suggestion does work for us, but I feel it's less elegant than the driver "handling" the typesafe integration for you. However, if it's definitely a no-go, then we can close this PR.

I'm sorry for being on the fence, really. But my gut feeling is that this new method will trick users into all forms of misuse.
For instance, the example in the javadocs you wrote suggest that users should create their Config using ConfigFactory.load("my-custom-config.conf"), then pass that to the method.
But ConfigFactory.load(String) is already loading the default reference and the default overrides behind the scenes.
So if you do that, the driver would end up reading a config that is equivalent to the following one:
ConfigFactory.defaultOverrides()
    .withFallback(
        ConfigFactory.defaultOverrides()
            .withFallback(ConfigFactory.parseResourcesAnySyntax("my-custom-config.conf"))
            .withFallback(ConfigFactory.defaultReferenceUnresolved())
            .resolve())
    .withFallback(ConfigFactory.defaultReference(CqlSession.class.getClassLoader()))
    .resolve()
    .getConfig(DEFAULT_ROOT_PATH);

I guess this wasn't exactly what you hoped to get. Especially the double resolution is concerning, and the mixing of different class loaders.
In fact, the right method to use to load your custom config is probably ConfigFactory.parseResourcesAnySyntax("my-custom-config.conf"). But I bet users won't think spontaneously of that one.
For these reasons and the ones we discussed above, if you don't mind, let's close this PR. But again, thank you very much for your effort here, I hope this won't discourage you from contributing again!