I'm using OPlayer on my site (10/10 would use it again)

Hey broski, forgot to give it a star and let you know about using it (my b)
There were just a little nuances that I didn't catch the first time that would accidentally cause an infinite render, though that was completely on me (i was sleep deprived lmao) and I fixed the issue.
TL;DR
Pretty much i just changed the way i fetch the data and how i use useEffect: using the source index and then using that index as the dependency.
The reason as to why I'm providing this huge chunk of code is just in case if you were interested in adding it to your docs for people that might get a similar issue as I did. Though, now thinking about it, I've provided quite a lengthy a code chunk and sort of a specific scenario. But, just in case y'know? (I'll provide it at the end since it is kinda chunky)
I didn't get to fully play around with the options yet: there were things I haven't tested (though I'm about to in a bit lol), but so far, absolutely beautiful UI.
Here's my site if you'd like to add it to your docs: mirutv.vercel.app
This was the code before:
export default function HLSPlayer({ sources, poster }: {
    sources: EnimeView['sources'],
    poster?: string,
}) {
    const divRef = useRef<HTMLDivElement>(null)
    const [src, setSrc] = useState('')
    const [hls, setHls] = useState<PlayerPlugin>()
    const [player, setPlayer] = useState<Player>()

    const uiOptions: UiConfig = {
        menu: [
            {
                name: 'Source',
                children: sources.map((source, idx) => ({
                    name: extractDomainName(source.url) ?? 'Unknown',
                    default: idx === 0,
                    value: source.id
                })),
                onChange: ({ value }) => {
                    enimeFetcher({ route: 'source', arg: value })
                        .then(res => setSrc(res?.url ?? ''))
                        .catch(err => console.error(err))
                }
            }
        ]
    }

    // Set initial src && lazy load hls
    useEffect(() => {
        enimeFetcher({ route: 'source', arg: sources[0].id })
            .then(res => setSrc(res?.url ?? ''))
            .catch(err => console.error(err))
        import('@/lib/hlsPlayer/hls')
            .then(mod => setHls(mod.default))
    }, [])

    // Create hlsPlayer
    useEffect(() => {
        const div = divRef.current
        if (!div || !src || !hls) return

        // Make sure that it doesnt create more than one player
        if (!player) {
            // Also avoid infinite loop
            setPlayer(_ =>
                Player.make(div, { source: { src, poster } })
                    .use([ui(uiOptions), hls])
                    .create()
            )
        }
        else {
            player.changeSource({ src })
                .catch(err => console.error(err))
        }
    }, [divRef.current, src, hls, player])

    return (

    )
}

I wasn't thinking then due to the lack of active brain cells so forgive the bad code here.
Here's it now:
const divRef = useRef<HTMLDivElement>(null)
    const [src, setSrc] = useState('')
    const [hls, setHls] = useState<PlayerPlugin>()
    const [player, setPlayer] = useState<Player>()
    const [srcIdx, setSrcIdx] = useState(0)
    const [isLoading, setIsLoading] = useState(true)

    const uiOptions: UiConfig = {
        menu: [
            {
                name: 'Source',
                children: sources.map((source, idx) => ({
                    name: extractDomainName(source.url) ?? 'Unknown',
                    default: idx === 0,
                    value: source.id
                })),
                onChange: ({ value }) => {
                    setSrcIdx(sources.findIndex(source => source.id === value))
                }
            }
        ]
    }

    // Set initial src && lazy load hls
    useEffect(() => {
        enimeFetcher({ route: 'source', arg: sources[0].id })
            .then(res => setSrc(res?.url ?? ''))
            .catch(err => console.error(err))
        import('@/lib/hlsPlayer/hls')
            .then(mod => setHls(mod.default))
    }, [])

    // Create hlsPlayer (only)
    useEffect(() => {
        const div = divRef.current
        if (!div || !hls) return

        // Make sure that it doesnt create more than one player
        if (!player) {
            // Also avoid infinite loop
            setPlayer(_ =>
                Player.make(div, { source: { src, poster } })
                    .use([ui(uiOptions), hls])
                    .create()
            )
        }
    }, [divRef.current, hls, player])

    // Fetch src onChange
    useEffect(() => {
        enimeFetcher({ route: 'source', arg: sources[srcIdx].id })
            .then(res => res ? setSrc(res.url) : notFound())
            .catch(err => console.log(err))
    }, [srcIdx])

    useEffect(() => {
        // Only care after player has loaded (dont add it as a dependency)
        if (!player) return
        player.changeSource({ src })
            .catch(err => console.log(err))
    }, [src])

    return (
        <div className={`${isLoading && styles['isLoading']}`}>
            {/* Transition softly to actual video content */}
            {/* To prevent 'flashing' event when video has loaded */}

 isLoading && setIsLoading(false)}/>

    )

Out of curiosity, is it possible to change the color of the play button? My guess it's this (again, I haven't got to completely play around with the library since the default UI was already beautiful af) :
OUI({ theme: { primaryColor: '#6668ab' } })

pretty cool, thx.
You can refer to the following code @OatsProgramming
//static， no-render, no-memo
const plugins = [
  OUI(),
  // Don't worry, the default is lazy loading
  OHls(),
]

function OPlayer({ sources, poster }) {
  const playerRef = useRef<Player>(null)

  // #app has rendered, just create player
  useEffect(() => {
    if (!playerRef.current) {
      Player.make('#app', { poster }).use(plugins).create()
    }
  }, [])

  useEffect(() => {
    playerRef.current?.context.ui.menu.register({
      name: 'Source',
      children: sources.map((source, idx) => ({
        name: extractDomainName(source.url) ?? 'Unknown',
        default: idx === 0,
        value: source.id,
      })),
      onChange: ({ value }) => {
        playerRef.current
          .changeSource(
            enimeFetcher({ route: 'source', arg: value }).then((res) => ({ src: res.url, poster }))
          )
          .catch((err) => console.log(err))
      },
    })

    //play default id
    playerRef.current
      ?.changeSource(
        enimeFetcher({ route: 'source', arg: source[0].id }).then((res) => ({ src: res.url, poster }))
      )
      .catch((err) => console.log(err))
  }, [sources])

  return (
    // No loading is required, it is also the default

  )
}

That is absolutely mad! Thanks for helping me make this better. I had to tweak some things ( there were tiny errors and had to make it look like its part of the code base lol ), but, nonetheless, I've never had anyone redo my code before and have it practically functional without knowing my code base on top of that. As expected from the creator tho lol
There are some parts that are a somewhat confusing to me.
I hope you don't mind about me asking quite a bit of questions: this library is beautiful and handy, but the docs are kinda hard to follow 😅. I wanna use this to fullest potential y'know? Apologies if I sound like a nerd lol. As of this moment, I only have 2 main questions. You don't have to answer them right away tho! It's a bit lengthy and I apologize for that. So take your time!
Questions:
1) Is type safety yet to be integrated for the context object?
playerRef.current?.context.ui.menu.register({
      name: 'Source',
      children: sources.map((source, idx) => ({
        name: extractDomainName(source.url) ?? 'Unknown',
        default: idx === 0,
        value: source.id,
      })),
      onChange: ({ value }) => {
        playerRef.current
          .changeSource(
            enimeFetcher({ route: 'source', arg: value }).then((res) => ({ src: res.url, poster }))
          )
          .catch((err) => console.log(err))
      },
    })

Based on the code, playerRef.current?.context.ui.menu.register, it looks like it takes an object similar to the UiConfig:
    const uiOptions: UiConfig = {
        menu: [
            {
                name: 'Source',
                children: sources.map((source, idx) => ({
                    name: extractDomainName(source.url) ?? 'Unknown',
                    default: idx === 0,
                    value: source.id
                })),
                onChange: ({ value }) => {
                    setSrcIdx(sources.findIndex(source => source.id === value))
                }
            }
        ]
    }

But when i hover over context.ui.menu.register on any context property, its saying that its of type "any"

2) Is there a necessity for calling unregister()?
playerRef.current?.context.ui.menu.unregister('Source')
    playerRef.current?.context.ui.menu.register({
      ...
})

The only thing I can think of is garbage collection, but I'm not entirely sure. I've tried to find a way to do playerRef.current?.use(ui[uiOptions]) but it seems that it didnt register it. No errors tho. For now, I've set it up this way:
const uiOptions: UiConfig = {
    pictureInPicture: true,
    menu: [
        {
            name: 'Source',
            children: sources.map((source, idx) => ({
                name: extractDomainName(source.url) ?? 'Unknown',
                default: idx === 0,
                value: source.id
            })),
            onChange: ({ value }) => {
              if (!playerRef.current) return
              playerRef.current
                .changeSource(
                  enimeFetcher({ route: 'source', arg: value })
                  .then((res) => res ? ({ src: res.url, poster }) : notFound())
                )
                .catch((err) => console.log(err))
            },
        }
    ]
}

const plugins = [
  OUI(uiOptions),
  // Don't worry, the default is lazy loading
  OHls(),
]

  // #oplayer element has rendered, just create player
  useEffect(() => {
    playerRef.current =
      Player.make('#oplayer', { poster } as PlayerOptions)
        .use(plugins)
        .create()

    return () => {
      playerRef.current?.destroy()
    }
  }, [])

But again, I'm not sure if the unregister('Source') method is something that needs to be integrated
Side Notes:
destroy()
Speaking of garbage collection: this is definitely something I've missed:
useEffect(() => {
    playerRef.current =
      Player.make('#oplayer', { poster } as PlayerOptions)
        .use(plugins)
        .create()

    return () => {
      playerRef.current?.destroy()
    }
  }, [])

I didn't know destroy() was necessary but then again I was super sleep deprived while making the app lol.
Loading
return (
        <div className={`${isLoading && styles['isLoading']}`}>
            {/* Transition softly to actual video content */}
            {/* To prevent 'flashing' event when video has loaded */}

 isLoading && setIsLoading(false)}/>

    )

The reason why I did this is because the OPlayer is initially has no width and height; it would "slowly" expand as it loads. I'm not sure yet as to how to circumvent the issue with the library's tools. That's where I added a div to just hide it till its fully loaded.
THANK YOU :)
Besides that, seriously, thank you for helping me out with my code.  It's rare for me to encounter someone to answer my questions all the while not knowing that I had a question. Usually it's spammers that give AI generated answers or left unanswered for months.

1
I tried to derive it automatically but it didn't work and now I have to declare it like this
https://github.com/shiyiya/oplayer/blob/main/examples/standalone/main.ts#L26

2
If sources has changed, we need to delete the old one before re-registering

loading

set css #oplayer{aspect-ratio: 16/9;}

Ah I see: so register() and unregister() is a necessity and can't be replaced with .use() in its place
Wish I had the brains to help with your code to make the library just a tad easier to use lol
I'll go ahead and implement the code and refactor it. Thanks again for all the help :)

register is to keep sources in sync. If sources do not change, they can be placed in options.
If you have further questions, you can use the discord

Oh I didn't even realize that was a thing 😅
I just simply thought it automatically did that or something since it didnt give me any errors
And for sure, I'll shoot a message there if anything lol


index native staking strategy events

Contract Changes

indexed NativeStakingSSVStrategy events

Security
If you made a contract change, make sure to complete the checklist below before merging it in master.
Refer to our documentation for more details about contract security best practices.
Contract change checklist:

[ ] Code reviewed by 2 reviewers.
[ ] Copy & paste code review security checklist below this checklist.
[ ] Unit tests pass
[ ] Slither tests pass with no warning
[ ] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Closing as Waffle is not working with bytes or uint64[] being indexed


Add support for pod annotations

We should allow the user to pass custom pod annotations that should be applied to the controller pods. This is a common pattern to enable people to do things like inject it into a service mesh.
https://github.com/ngrok/ngrok-ingress-controller/compare/alex/consul-setup#diff-5cdf70eac1f7532cceb5a5d9a609ebc97aef19067dc680462e2049e9fde187a6R37

https://github.com/ngrok/ngrok-ingress-controller/pull/53


Different price on product page and in the cart

Current behavior
After adding some products to the cart the price is different in the cart than on the product page

Expected behavior
The price is the same on product page and in the cart
Steps to reproduce the issue

Go to any product page e.g. http://localhost:3000/women/tops-women/tanks-women/bras-and-tanks-26/celeste-sports-bra-1641.html?childSku=WB03-XS-Green
Check the price
Choose available variant of the product and click 'Add to cart' button
Click the 'cart' icon in upper right corner
Compare the prices

Repository

Can you handle fixing this bug by yourself?

[ ] YES
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser:
OS:
Node:
Code Version:

Additional information

This seems like a Magento misconfiguration (Magento is showing the prices in Totals without taxes - Net prices). VSF is in charge of calculating product/category level prices but totals are taken 100% as they are in Magento


typo: seperate -> separate

Automation for azure-sdk-for-python

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-node

Automation for azure-sdk-for-go

Can one of the admins verify this patch?

Automation for azure-sdk-for-java


[Improvement]: Make DialogResponse responseData dynamic

Is there a reason that the responseData field in DialogResponse is a List<dynamic> rather than just dynamic? It means I have to wrap my single object response in a list when I don't really need to, whereas were it simply dynamic, I could pass a list back if needed.
DialogRequest's customData is dynamic and that has worked great for me, as in one situation I pass back a single object value, and another time I need to pass a Set<xxxx>.

@essboyer The reason is probably because i was being single minded at the time. i will fix that now and push an update.

Done @essboyer update to 0.5.2

Fantastic! Thank you!


Cisco.Webex version <IP_ADDRESS>650

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Fixes #172331

Among changing UpgradeBehaviour to fix #172331 I added the parameter to accept EULA on behalf of the user and also added user and machine installation scopes.


Dragging from sortable and  scrollable container to another container below doesn't work

If you have 2 containers vertically aligned and you want to drag from the above one to the below one, dnd-kit doesn't recognize that the dragover event (over the below container) happened. This is only the case only, if the above container has a scrollbar.
See the issue in following sandbox:
Sandbox
If you make the above container have fewer elements so the scrollbar doesn't appear, it works:
https://codesandbox.io/s/dnd-kit-multi-containers-forked-jbeh7?file=/src/app.js

This was fixed by #518, which will be released soon #557.
You can already try it out by installing @dnd-kit packages tagged with next on npm by running:
npm install @dnd-kit/core@next @dnd-kit/sortable@next

Here's a CodeSandbox using those releases https://codesandbox.io/s/dnd-kit-multi-containers-forked-wsc0o?file=/src/index.js


Error in package.json

The package.json has and incorrect entry for the module:
 "module": "dist/index.esm.js",

Should be:
 "module": "dist/index.mjs",

Sure, will update it

Fixed in latest release


BBC image resizing

Another little bug of the image resizing...
If the image is taller than the limit, the "resize-on-click" doesn't resize anything.
The code should be changed to:

			// No saved data, then lets set it to auto
			if ($.isEmptyObject($this.data()))
			{
				$this.data("bbc_img", {
					width: $this.css('width'),
					height: $this.css('height'),
					'max-width': $this.css('max-width'),
					'max-height': $this.css('max-height'),
				});
				$this.css({'width': $this.css('width') === 'auto' ? null : 'auto'});
				$this.css({'height': $this.css('height') === 'auto' ? null : 'auto'});

				// Overide default css to allow the image to expand fully, add a div to exand in
				$this.css({'max-width': 'none'});
				$this.css({'max-height': 'none'});
				$this.wrap('

');
			}
			else
			{
				// Was clicked and saved, so set it back
				$this.css({'width': $this.data("bbc_img").width});
				$this.css({'height': $this.data("bbc_img").height});
				$this.css({'max-width': $this.data("bbc_img")['max-width']});
				$this.css({'max-height': $this.data("bbc_img")['max-height']});

				// Remove the data
				$this.removeData();

				// Remove the div we added to allow the image to overflow expand in
				$this.unwrap();
				$this.css({'max-width': '100%'});

			}

Ouch, I thought this one was another one, otherwise I'd have pushed the code as is... :(
Tomorrow then I guess.


Create boundary name

#78
Boundaries are now created with a label to be able to identify different boundaries similarly to a flow. It should not affect previous boundaries created (without a name) and they can still be saved without a name, or a name can be added if needed.

Will solve code refactoring.

Tested with the both old and new json model files, and also tested existing app with both old and new json model files, to ensure compatibility between releases and data model. All good!

Okay I see. I was working mostly on the web app. The desktop app seems to behave a bit differently since the settings button does not appear (See picture taken in the web app).

Now that I think of it, that is an excellent idea.

I will fix/implement both changes and create a new pull request @jgadsden. Thanks!

@jgadsden The two issues should be solved now. Let me know what you think.
Arnold

Everything is working now.

I can merge this pull request, but as an aside the code climate issue could be solved (if I understand correctly) by substituting :
            if (newElement.attributes.type == "tm.Flow") {
                newElement.attributes.source = {'x' : 30, 'y' : 20};
                newElement.attributes.target = {'x' : 110, 'y' : 100};
                newElement.attributes.labels[0].attrs.text.text = label;
                delete newElement.attributes.vertices;
            }
            else if (newElement.attributes.type == "tm.Boundary") {
                newElement.attributes.source = {'x' : 30, 'y' : 20};
                newElement.attributes.target = {'x' : 110, 'y' : 100};
                if (label != ""){
                    newElement.attributes.labels[0].attrs.text.text = label;
                }
                delete newElement.attributes.vertices;
            }

with
            if (newElement.attributes.type == "tm.Flow" || newElement.attributes.type == "tm.Boundary") {
                newElement.attributes.source = {'x' : 30, 'y' : 20};
                newElement.attributes.target = {'x' : 110, 'y' : 100};
                if (label != ""){
                    newElement.attributes.labels[0].attrs.text.text = label;
                }
                delete newElement.attributes.vertices;
            }

as label is not empty for Flow. This brings the function lines below 25.
Shall I merge this PR as is?

I can merge this pull request, but as an aside the code climate issue could be solved (if I understand correctly) by substituting :
            if (newElement.attributes.type == "tm.Flow") {
                newElement.attributes.source = {'x' : 30, 'y' : 20};
                newElement.attributes.target = {'x' : 110, 'y' : 100};
                newElement.attributes.labels[0].attrs.text.text = label;
                delete newElement.attributes.vertices;
            }
            else if (newElement.attributes.type == "tm.Boundary") {
                newElement.attributes.source = {'x' : 30, 'y' : 20};
                newElement.attributes.target = {'x' : 110, 'y' : 100};
                if (label != ""){
                    newElement.attributes.labels[0].attrs.text.text = label;
                }
                delete newElement.attributes.vertices;
            }

with
            if (newElement.attributes.type == "tm.Flow" || newElement.attributes.type == "tm.Boundary") {
                newElement.attributes.source = {'x' : 30, 'y' : 20};
                newElement.attributes.target = {'x' : 110, 'y' : 100};
                if (label != ""){
                    newElement.attributes.labels[0].attrs.text.text = label;
                }
                delete newElement.attributes.vertices;
            }

as label is not empty for Flow. This brings the function lines below 25.
Shall I merge this PR as is?

The 2nd method is good. Initially, I thought I would need to modify the boundary attributes, but I ended up keeping them as is. Code updated!


Subfolder for sequenz

Loving your script.
The only thing you could improve, saving the files to a subfolder for each sequence like deforum or prompt morph does it.
I think the results are a lot better than prompt morph even it is a simple approach I simply love the results

I haven't used deforum or prompt morph, so I do not know how these do things. Do they create a subfolder every time you hit generate, and dump the images sequentially numbered in that folder? What would be the optimal way to organise the files?

On the example of Deforum. It creates a Folder in img2img outputs called "Deforum".
For each animation/Sequence you create a new Folder staring with "0000" is created.
So yes, for each time you hit generate, you get a new subfolder with numbered images ready to be used in video editing software as image sequence.


Added a new DDL site

Added an additional DDL site called moviesrus.tk
It offers links to its own streaming and download options without its own advertisements.

You need to remove the space between [Movies "R" Us] and (moviesrus.tk), otherwise the link won't work :)

Thank you! Should be fixed now.


Reset sequence of samples generate by tf.random.uniform without restarting the session

As of the rules I have raised this issue on StackOverflow but it's dying a slow death over there, therefore I ask it here: https://stackoverflow.com/questions/55951644/reset-sequence-of-samples-generate-by-tf-random-uniform-without-restarting-the-s
I can set the seed of the random.uniform operation, but this seed is only used as "starting-point" of the session. I cannot instruct the tensor to "re-initialize" from the set seed.
I want to train my model on random samples generated by random.uniform and every batch I want the same samples to be used, without having to store these samples.
I could create one big array to write these uniform samples into and use that to train upon, but using random.uniform tensor with a "reset" of the seed every batch seems more elegant and more memory friendly. In some use cases I have to create millions and millions of random uniform samples. Using tf.data with a random.uniform tensor should be way more elegant.

Please provide details such as platform you are using (operating system, architecture), TensorFlow version used. If possible, please provide the minimal code snippet which can depict the issue at hand. You can refer this template to fill in the required information. Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

I am using both Windows 7 and Ubuntu 18.04 and the issue is the same for both platforms cause I am trying to figure out how I can use the API. I am using TF 1.13.


Demonstrate how to publish a plugin to the plugin portal

See https://plugins.gradle.org/docs/publish-plugin

This is described here: https://docs.gradle.org/current/userguide/publishing_gradle_plugins.html


⚠ Turnos 24x7 has degraded performance

In 6d5a915, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1006 ms

Resolved: Turnos 24x7 performance has improved in 5c5ad79.


[Feature Request] 300m Interaction Range

Suggested by one of my users: create 300m interaction range circle (toggleable of course) for the spawned Pokemon when beating a raid.

@versx should this be tacked on as an additional option for only 300m or should I just make all interaction ranges an adjustable amount in meters?

I guess this is also related to #499... so same question to @kamieniarz but for 40m on Pokestops.

@versx should this be tacked on as an additional option for only 300m or should I just make all interaction ranges an adjustable amount in meters?

I'd say either would be fine in my opinion. If you're referring to users being able to adjust the amount, I'd say no but if it's adjustable for Admins via the config then I think that's perfectly fine.

^ I'm fine with it


Run a search to verify that this is the first PR of the user

This will make sure that we don't send a "welcome message" twice when the user's first PR was not merged.

Thank you for the review


Add example of helm chart for vllm deployment on k8s

This PR adds an example of helm chart to deploy vllm on Kubernetes cluster. The goal of this PR is to have a deployment example in order to have the best configuration for k8s.
This example implements an autonomous deployment for vllm with k8s probes (startup, readiness, liveness) which will wait for model to be fully loaded and then marks the pod with running status when the health checkpoint return 200.
As shown in the figure in readme file, the deployment follows two steps :

Step 1 : Load the model from an S3 to a volume. An init container is launched and waits for a job to load the model from an S3 to a volume

Step 2 : Launch VLLM engine. Once the model is loaded on the volume, Vllm is launched.

This deployment will launch two containers :

The init containers which will be marked with completed status once the download job is done.

A containers hosting vllm engine which will be marked with pending status when init container is ongoing, and will be marked with running status once init container is completed.

FIX https://github.com/vllm-project/vllm/issues/6073

Thanks for the PR. Do you have any thoughts on how / where this could be tested to ensure it remains functional?

Thanks for the PR. Do you have any thoughts on how / where this could be tested to ensure it remains functional?

I propose the following tests to be implemented in a github workflow :
  - Helm lint
  - Create kind cluster in order to have a local Kubernetes cluster using Docker for test environment.
  - Test helm install
  - Test  the service with a post request and ensure we have a 200 response.

Thanks for the PR. Do you have any thoughts on how / where this could be tested to ensure it remains functional?

I propose the following tests to be launched in a github workflow on every pull request :

Lint helm chart
Validate Kubernetes Manifests with Kubeconform
Create kind cluster in order to have a local Kubernetes cluster using Docker for test environment
Test helm install
Test  the service with a post request and ensure we have a 200 response.

That sounds good to me. Is that something you'd be willing to work on? Since the PR content is pretty standalone, it shouldn't be at much risk of going into conflict in the meantime.

Thanks for the PR. Do you have any thoughts on how / where this could be tested to ensure it remains functional?

I propose the following tests to be launched in a github workflow on every pull request :

Lint helm chart
Validate Kubernetes Manifests with Kubeconform
Create kind cluster in order to have a local Kubernetes cluster using Docker for test environment
Test helm install
Test  the service with a post request and ensure we have a 200 response.

That sounds good to me. Is that something you'd be willing to work on? Since the PR content is pretty standalone, it shouldn't be at much risk of going into conflict in the meantime.

Sure, I can work on implementing these tests.

@russellb I just added some github workflows to implement functional tests on the chart helm :

lint test of the chart
Input Validation with values.schema.json
setup a local minio to mock an s3
setup a local k8s cluster with kind
deploy the chart helm on the kind cluster (cpu only, I have used the cpu vllm docker image)
curl test to check if the service is correctly responding

All these tests have been implemented in a github worflows.

@russellb I have tried to push the functional tests of the chart helm in the github worflows folder of the project, but I have not the permissions.
Do you know who can help me with this please?

@simon-mo @khluu
@mfournioux plans to add functionality test into github workflow folder but he has no permission. Is there any way to bypass the permission issue?

@russellb I have tried to push the functional tests of the chart helm in the github worflows folder of the project, but I have not the permissions.
Do you know who can help me with this please?

You should be able to run your workflow on your own fork of the repo. I think that would be the best way to demonstrate it working.

@russellb the github workflow "lint-test" I have added to test functionally the chart helm is working, and all tests are done successfully.
What are the next steps for the PR to be reviewed?

@alexm-neuralmagic @robertgshaw2-neuralmagic Would it be possible to review this PR please?

@alexm-neuralmagic @robertgshaw2-neuralmagic @njhill Would it be possible for you to review this PR please? The additional github worflow "Lint and Test Charts" I have added to functionally test the chart helm is working successfully.

do you have a link to a repo where the new job is running successfully?

The new job is running on the github runner on the actual repo, here it is : https://github.com/vllm-project/vllm/actions/runs/12140792603/job/33851363440?pr=9199

@alexm-neuralmagic @robertgshaw2-neuralmagic @njhill Would it be possible for you to review this PR please? The additional github worflow "Lint and Test Charts" I have added to functionally test the chart helm is working successfully.

do you have a link to a repo where the new job is running successfully?

I have worked on my fork of the official vllm project on a new branch, but as I have created a PR on the VLLM repo linked to my branch, after every push on my branch from my fork, the new job is running on the github runner on the official repo vllm, here it is the link to the successful job : https://github.com/vllm-project/vllm/actions/runs/12140792603/job/33851363440?pr=9199.
The new job appears in the checks at the end of PR just below under the name "Lint and Test Charts / lint-test (pull_request)".

Oh, thanks! Sorry, I missed it. I think it was the name "lint-test" that made me overlook it.

Thanks for addressing all of my feedback! I've pinged some maintainers to take a look.

Thanks for addressing all of my feedback! I've pinged some maintainers to take a look.

Many thanks!

Thanks for spending the time and effort on setting this up!


chore: minor refactor for weighted choose

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As the title.
Checklist

[ ] I have written the necessary rustdoc comments.
[ ] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

The choose_multiple method in the WeightedChoose trait does not clearly state whether duplicate items are allowed to be returned, which may cause some confusion.

The choose_multiple method in the WeightedChoose trait does not clearly state whether duplicate items are allowed to be returned, which may cause some confusion. cc @WenyXu

It wouldn't by default, let's add some comments.


Steal Pippo's ideas and architecture. Because it's awesome.

http://www.pippo.ro/
Joking, mostly...
But it's nice that pippo stays very light weight and modular (unlike Spring) and yet still caters to websites as well as web services (where Spark is more oriented toward just services).
It's also great that it has the option of DSL like syntax for defining end points as well as a Controller based approach. And it leaves it up to the developer to pick their flavor.
It's a great overall design I think.

I love fully functional, DSL approach. However, it requires changing lwan quite a lot and implementing full-featured router. I'll keep this in mind when the library mature enough.


explode mm/yy for data-stripe

I am using your example form. Please help how can I explode mm/yy of form an assign them to data-stripe="exp-month" and data-strpe="exp-year" respectively to submit it t stripe.js? Please help.

Try something like this:
var expirationDate = '10 / 2018';
var matches = expirationDate.match(/([0-9]{2}) \/ ([0-9]{4})/);

Stripe.card.createToken({
      number: cardNumber,
      cvc: cvcCode,
      exp_month: matches[1],
      exp_year: matches[2]
}, stripeResponseHandler);

In a real world situation, you'd probably pull expirationDate, number and cvcCode from the form using jQuery.

@jdpedrie Thanks for trying to help but as about var expirationDate what can I use to get it from form assuming I am using the same example form of this repository?

Beside question above: Instead of regexp match you suggested, how can I use this method to explode and assign them to year and month https://github.com/stripe/jquery.payment#paymentcardexpiryvalstring-and-fnpaymentcardexpiryval ?

It is unnecessary to explode the MM/YY field into separate elements.  Stripe.js supports passing expiration data as a single field:
https://stripe.com/docs/stripe.js#passing-exp-dates
Hope this helps!

Thanks.

Sounds like this was resolved!


Don't throw error for invalid old starting token

Botocore has support for its own starting token formats, the older
of which simply splits up necessary data with triple underscores.
This format has been deprecated for a while due to various
shortcomings, but there's still input support for it for backwards
compatibility. The last element in that token format should be an
integer, which indicates how far to slice into the response. The
problem is that some services have tokens which include triple
underscores, so we think it's that format but malformed. This fixes
the problem by passing the full starting token along if parsing
fails.
Fixes boto/boto3#1984

Codecov Report

Merging #1757 into develop will decrease coverage by 0.74%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop   #1757      +/-   ##
==========================================
- Coverage    92.44%   91.7%   -0.75%
==========================================
  Files           53      53
  Lines         9851    9851
==========================================
- Hits          9107    9034      -73
- Misses         744     817      +73

Impacted Files
Coverage Δ

botocore/paginate.py
97.8% <100%> (+0.54%)
:arrow_up:

botocore/compat.py
68.5% <0%> (-25.42%)
:arrow_down:

botocore/awsrequest.py
92.13% <0%> (-6.23%)
:arrow_down:

botocore/hooks.py
95.18% <0%> (-1.21%)
:arrow_down:

botocore/credentials.py
98.31% <0%> (-0.52%)
:arrow_down:

botocore/handlers.py
96.67% <0%> (-0.48%)
:arrow_down:

botocore/utils.py
97.46% <0%> (-0.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33dcf8...ce110e1. Read the comment docs.

Not sure why codecov is freaking out, but this looks fine to me.


Try to fix snappy support on travis

Just a guess. Even if it works, doesn't replace the value of deciding about #220. Would just like to see the build not failing every time...

I should have marked this draft - don't merge yet even if the build passes.

D'oh! Meant to squash merge, not rebase and merge.  Never mind...


CAD Assembly File

Hi,
First of all, thank you for sharing this incredible project. I’ve gone through the repository, and I really appreciate the effort and time you've put into developing this. I was wondering if you might be willing to share the CAD assembly file of the entire platform.
Many thanks in advance.

@mbloechli could you add an assembly to the repo?

@mbloechli could you add an assembly to the repo?

Hi @erikbr01,
Thank you so much for the response! I’ve actually managed to locate the assembly file in the repository cad_parts/098082_02.prt. Apologies for the confusion, and I really appreciate your help.

Thanks for the mention. I'll create a readme inside the cad folder so the next person can find it quicker.


Explicit check on osc angle param units

There is a bug case where if an oscillation angular param (e.g. mixing angle of CP phase) is dimensionless, it is interpreted as radians in the osc stage. This is a problem is the user meant degrees but forgot the unit. This check enforces the user specified the unit.

First, please rebase from i3os/master (or start there when you create a feature branch) so you are up to date with i3os/master, the commit diffs appear reasonable, and github isn't fooled into digging up old PR conversations.
Second, you can implement a better check than this using the dimensionality attribute.  E.g.
angle_dim = ureg.deg.dimensionality
for blah in blah:
    assert x.dimensionality == angle_dim

Third, check != and then raise pint.DimensionalityError (instead of using assert). The more typed an exception can be the better, and there's a perfect exception type that can be used for this case.

@ts4051 will you make the remaining small changes and rebase? Then we can get this thing merged

@ts4051 any updates on the last changes and rebase? Would be good to get this merged, seems 99% there

looks good now i think...gonna merge


kube-up.sh instructions for installing on Ubuntu 14 are broken

[X] Bug Report
Problem:
Ubuntu 14 setup instructions are broken.
https://stackoverflow.com/questions/44302071/how-to-install-latest-kubernetes-in-ubuntu-14#

@aronchick Can you provide a specific page URL for the broken instructions?

@aronchick Please feel free to re-open this issue with more specific information.


Address build issues with sqlite3 for ndk 15+

Currently we are including deprecated headers to avoid running into sqlite build issues with ndk 15.2+. But we will have to address this issue sooner than later as these headers will be excluded in the future ndk versions.
Reference: https://android.googlesource.com/platform/ndk/+/ndk-r15-release/docs/UnifiedHeaders.md
Sqlite3 issue on android ndk project: android-ndk/ndk#477

Right on time. I just got bitten by this.
I tried to build on iOS11. On iOS the OS-version of sqlite is used, which comes in a newer version which requires a newer SQLiteCpp because of slight header incompatibilities. So I tried to update SQLiteCpp. SQLiteCpp 2.2.0 comes with sqlite-3.20.1 bundled. When building on Android this fails because the new sqlite uses mmap.
I was able to fix/work around this by adding
target_compile_definitions(sqlite3 PRIVATE -DSQLITE_MAX_MMAP_SIZE=0 -DSQLITE_OMIT_WAL)
to the core/deps/SQLiteCpp/sqlite3/CMakeLists.txt. This disables the use of mmap in sqlite3. I'm not sure of this is the right fix.

Thanks @cleeus. This could be good, will try it out. Thanks

I was having the same issue, and this is what fixed for me.
https://github.com/couchbaselabs/couchbase-lite-libsqlcipher/pull/23

Resolved by #1667


Enable debug mode in container

Start the server using the debug command instead of run, and ensure the server makes use of the WLP_DEBUG_SUSPEND and WLP_DEBUG_ADDRESS either from environment variables or the same parameters from server.env that dev mode generates here, so that debug does not suspend the server, and so that a custom debug port can be used.

The following options will need to be passed into the docker run command:
-p 7777:7777 (or the custom debug port)
-e WLP_DEBUG_SUSPEND=n
-e WLP_DEBUG_ADDRESS=7777 (or the custom debug port)

Example command for starting up a container with liberty in debug mode and copying over the .war file and individual config files:
docker run -p 9080:9080 -p 9443:9443 -p 7777:7777 -v ${pwd}/demo-devmode-maven.war:/config/apps/demo-devmode-maven.war -v ${pwd}/server.xml:/config/server.xml -v ${pwd}/bootstrap.properties:/config/bootstrap.properties -e WLP_DEBUG_SUSPEND=n -e WLP_DEBUG_ADDRESS=7777 open-liberty:full /opt/ol/wlp/bin/server debug defaultServer


Redirect postgres log messages to spdlog

Description of the Change
Print notices from postgres to spdlog instead of std::cerr
Benefits
Logging is controlled consistently with other logs
Possible Drawbacks
reinterpret_cast...

Linux CI has passed, Mac CI has a known issue.


fix bug in user.py

Fixed bug in function modify_stream().
game_id changed from int to str.
If no game_id was given, the error code 400 occurred because None was formatted into a string.
Bug fix has been tested and works.

This is a breaking change, and cannot be merged into the library in accordance with semver

Ok, I close this pull request and create a new one in which the bug is fixed in another way


Unable to parse requirement file using git tag

[WARNING] Skipping<EMAIL_ADDRESS>could not parse requirement

That's expected as there's no metadata available from the trove classifier to know if the project has been ported or not.


PIXI.Ticker.maxFPS does not lock FPS to 60

Expected Behavior
PIXI.Ticker.maxFPS should lock FPS to 60 by default or by specifying it (according to the docs).
Current Behavior
PIXI.Ticker.maxFPS does not lock the max FPS to 60 by default on a 120hz monitor, at least not for me. The FPS goes to 120 and sometimes falls to 60 FPS, and then goes up to 120 FPS again.
Setting app.ticker.maxFPS = 60 or anything above 60 doesn't work either. However, if you set app.ticker.maxFPS = 59.99 it works which seems very weird.
Steps to Reproduce
Example: https://codepen.io/whats0n0/pen/YbJwbg

Use 120hz monitor
Set app.ticker.maxFPS = 60;
FPS still goes above 60

Environment

pixi.js version: v5.0.3
Browser & Version: Chrome 74.0.3729.169
OS & Version: Windows 10
Running Example: https://codepen.io/whats0n0/pen/YbJwbg

I got 144 all the time as well. I feel like it could have something to do with how requestAnimationFrame() works if PIXI still uses it.

I added this for v5, so sorry it's not working as intended.
This behaviour is occurring because of this bit of code
if (fps / 1000 >= settings.TARGET_FPMS)
{
    this._minElapsedMS = 0;
}

So with the default value of settings.TARGET_FPMS, it means that if you try to set the maxfps to 60 or above, it actually disables the maxfps behaviour. I wanted a way to set amax FPS, and then remove it later. Since I use 60hz monitors, I felt that if you wanted 60fps, don't artificially limit it, let requestAnimationFrame take care of it.
Clearly with higher frame rate monitors that logic doesn't work, so I'll have a rethink.

Alright, I see!
The reason I found out was because requestAnimationFrame was randomly switching between 120fps and 60fps (probably because of performance) which caused stuttering. Otherwise I could just have let it run at whatever FPS it wanted.

Alright, I see!
The reason I found out was because requestAnimationFrame was randomly switching between 120fps and 60fps (probably because of performance) which caused stuttering. Otherwise I could just have let it run at whatever FPS it wanted.

Alright, I see!
The reason I found out was because requestAnimationFrame was randomly switching between 120fps and 60fps (probably because of performance) which caused stuttering. Otherwise I could just have let it run at whatever FPS it wanted.

@whats0n0 I have a high refresh rate monitor arriving Thursday so will be able to test any tweaks I have to how this setting works!

this will maybe interest you.
i remember test on my 3d tv, my projet ran at ~240 fps with arg "chromium-args": "--disable-gpu-vsync
https://bugs.chromium.org/p/chromium/issues/detail?id=787485
I do not want say bullshit because I know nothing about this and not enough to experiment on my side.
But could this be related to v-sync setup?

Inspiration comes from stackoverflow, i hope it can be useful.
let last = 0
const FPS = 1
const interval = 1e3 / FPS | 0 // Fix occasional drop-off frames

animate()

function animate() {
  requestAnimationFrame(animate)

  const now = performance.now() | 0 // Fix occasional drop-off frames
  const elapsed = now - last

  if (elapsed < interval) return

  console.log('animate')

  // Excellent
  last = now - (elapsed % interval)
}

May I asked why this issue was closed? Is the conclusion not to use the ticker for V4 but have a separated game loop?

It was automatically closed because PR #5388 marked it as fixing this issue. This fix was relevant for v5. That PR and follow up changes to Ticker could probably be backported to v4 if someone wants to make a PR.

@bigtimebuddy I think you mean #5833 :)


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20211108163531584 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20211108163531584 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.513%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26942

Relevant Lines:
58872

💛  - Coveralls


Phase 3 Funding: Astropy Maintainer Mentoring Program Proposal (Aperio Software)

Still a draft - the scope and budget will be determined by whether and how long our Cycle II funding is extended for.

Because the estimated total of all the proposals is a bit higher than the amount available for allocation, we suggest that you (@astrofrog) provide a budget range - i.e., a "minimum for this project to be viable" and "maximum you could use effectively for this project".

Please react to this comment to vote on this proposal (👍, 👎, or no reaction for +0).

Are there any examples of a mentor/mentee pair that have happened already?

@mhvk - no not yet, we hope to start pairing mentees and mentors in a few months, and before the end of 2022 (we will do this as part of extended Cycle II funding)

Congratulations!  The community has expressed support for this FR, and the Finance Committee has determined it can be funded.  This FR has been approved for $6,450, to be funded from the Moore grant.
@kelle is the Finance Committee member who will be supporting this project.  They will update this PR with the amount and then merge it, as well as being in contact with you to set up any necessary agreements and relevant Open Collective financial arrangements. They will also open a new issue where progress on this project can be discussed.


Make sure the quiet picker conforms to the user set width

Closes
✅ Pull Request Checklist:

[ ] Included link to corresponding React Spectrum GitHub Issue.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:
RSP

https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=716


Upload csv to mongodb feature completed

if you go on quiz_test, you can test out the upload CSV feature...it'll populate in mongo as a json object

Will test this tomorrow.


Mat/Pat: Auto-populate basic info fields

User Story
As an applicant i want my basic information to be auto-populated so that I do not have to update it myself
Acceptance Criteria

[ ] The following fields should be auto-populated

Name
Ministry
Employee Class
Appointment Status - [Aux, K, J etc] (Question: is there a label associated that can be used?)
Full Time/Part Time - [Full time, Part Time]
Mailing address (Question: if empty can we show home address ? Also PIA implications?)

[ ] The fields should not be editable

Design
Basic Info screen - https://miro.com/app/board/uXjVOWaGSE0=/?moveToWidget=3458764536515093569&cot=14

We are only missing Full Time/Part Time - [Full time, Part Time]. It is not available in our current API. Full time employees work 35 hours per week and have an FTE status of 1, while part time employees work less than 35 hours per week and have a FTE status of less than 1 (as per Connie) (e.g. 17.5 hours worked per week would be FTE status of .5).
@T854236 is it possible to add the FTE field from the ODS to the telework API so we can pull that information?

@Andrew-Vargas-bcgov
There is a full_part_time field that can introduce.  Will let you know once available.

@T854236 Looks good. Added it to our frontend to autopopulate on mat/pat.

@Andrew-Vargas-bcgov
Great, let us know when we can deploy to PROD.

@Andrew-Vargas-bcgov  can you confirm that for Ayush Employee Class & Fulltime/partime is missing in the database or is not being populated?

Yes, he will not see anything there, but it will populate in production
when we are ready. Employee class currently only available in production.
Full time part time will be added to all environments during our next
deployment.
On Mon, Apr 24, 2023 at 1:50 PM fazil-ey @.***> wrote:

@Andrew-Vargas-bcgov https://github.com/Andrew-Vargas-bcgov can you
confirm that for Ayush, Employee Class & Fulltime/partime is missing in the
database or is not being populated?
—
Reply to this email directly, view it on GitHub
https://github.com/bcgov/digital-journeys/issues/831#issuecomment-1520807185,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ7ISIDAOXK2VLSX6V5G6WTXC3RQNANCNFSM6AAAAAATRNMH54
.
You are receiving this because you were mentioned.Message ID:
@.***>

Based on the comment above that

Employee class currently only available in production.
Full time part time will be added to all environments during our next
deployment.

PO Approved in test, will have to be tested again in production


⚠ BCR Bot has degraded performance

In d448671, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 992 ms

Resolved: BCR Bot performance has improved in 657a2ab.


Download speed cap on the windows setup tool

download speed is capped, making downloads slower

There is no speed cap. Either your connection is slow, or the mirror which serves the Xubuntu ISO is slow.


fix(icons): match new Nerd Fonts 3.0.0 release

See the following links for more information:

https://github.com/ryanoasis/nerd-fonts/issues/365
https://github.com/ryanoasis/nerd-fonts/issues/1059#issuecomment-1404891287

Is this backward compatible or does it force all users to use v3.0 to see the new icons?
Perhaps anecdotal but most users bother updating the font regularly (unless it comes with the distro) so this might have unintended consequences for existing users not being able to see some icons.

Unfortunately this is not backwards compatible AFAIK. So I'm unsure what the best course of action is when trying to maintain support for older [font] versions.
From experience - most people that use Nerd Fonts likely use some automated package manager to install them (so you probably don't need to worry about the system font use case). For people on MacOS - this means they're likely using brew which is pretty aggressive about updates. For people on other platforms 🤷🏽
I'm personally of the opinion that people should do their best to stay reasonably up to date / within the last few releases - regardless of major/minor/patch update. So if anything, it might be worth waiting a few days (or weeks?) to give people time to update. The only issue is holding off disincentives people from updating / causes some pain for those that have.

The only issue is holding off disincentives people from updating / causes some pain for those that have.

AFAIK all of the changes in this commit are customizable via setup so I’m pretty sure this can wait until we figure out what’s the right thing to do here.

Yeah that's fair. I can do the same until they're updated on main.
Thank you for the responsive reply!

For those wanting something to copy and paste, this worked for me
      require("fzf-lua").setup {
        lsp = {
          symbols = {
            symbol_icons = {
              File = "󰈙",
              Module = "",
              Namespace = "󰦮",
              Package = "",
              Class = "󰆧",
              Method = "󰊕",
              Property = "",
              Field = "",
              Constructor = "",
              Enum = "",
              Interface = "",
              Function = "󰊕",
              Variable = "󰀫",
              Constant = "󰏿",
              String = "",
              Number = "󰎠",
              Boolean = "󰨙",
              Array = "󱡠",
              Object = "",
              Key = "󰌋",
              Null = "󰟢",
              EnumMember = "",
              Struct = "󰆼",
              Event = "",
              Operator = "󰆕",
              TypeParameter = "󰗴",
            },
          },
        },
      }

For those looking for a fuller list of icons that popular tools are using, feel free to use mine - I updated it recently to finish the 3.0.0 release: https://github.com/XenoPhex/nvim/blob/42192ef0c637c3ae6e274df4b7b2df633577a72c/lua/utils/icons.lua#L43-L160

Unfortunately this is not backwards compatible AFAIK. So I'm unsure what the best course of action is when trying to maintain support for older [font] versions.

@XenoPhex, I looked into this, there's not much we can do here when it comes to backward compatibility, given nvim-web-devicons also updated to nerdfots v3 I guess we should merge this and if people need to use the older fonts they can always either pin commit customize symbol_icons, ref:
https://github.com/nvim-tree/nvim-web-devicons/pull/264


Check whether the state of the ChainDB is in normal form

Just sharing a potential approach.
I'm not happy with the need  to think about which functions from NormalForm to use: tvar, tmvar, standard, etc. We could use type class instances for this (so that we can simply use custom, which should then get renamed), but then we'll need to write a lot of instances (in most cases standard is enough).
I still have to update the mock databases.
There are still a bunch of things not in normal form, causing the test to fail. I have marked these with TODOs. We'll probably need more than a few bangs to fix them.

Related: #915.

This looks like a really cool approach but I wonder whether it would be easier to add support for the inspection of TVAR objects in ghc-heap (and, as a result, the ability to check whether they're in normal form using Cardano.Prelude.GHC.Heap.NormalForm.isNormalForm).
At a first glance, it doesn't seem like it would be too difficult to add the support for inspecting TVARs in ghc-heap itself. The StgTVar struct in GHC contains a pointer to the actual object that it's wrapping, which should be all we need in order to check whether it's in normal form. So it seems simple to add support for TVAR objects but, if it's really as simple as I'm thinking, I have to wonder why it hasn't be done already (as I've realized, things aren't always as simple as they seem :stuck_out_tongue:).
However, if we go this route, it would take some time to get this merged into ghc-heap and released, so maybe it'd be a good idea to follow this approach and swap it out once there's ghc-heap support for STM objects. Or perhaps we could temporarily include the solution in cardano-prelude (if possible)?

I think they are complimentary. StrictTVar (and co) mean that we get type-level guarantees that TVars are in weak head normal form. Type level guarantees are of course always better than testing :) But they only guarantee weak head normal form, not normal form. Extending the isNormalForm stuff to cover TVars would still be very useful to check the latter. I think we should have both.

I agree that it would be very worthwhile to extend the isNormalForm to cover TVars. Combined with some type level guarantees that TVars will be in weak head normal form (#918), it will get us quite far I think.

Infrastructure obsoleted by https://github.com/input-output-hk/cardano-prelude/pull/67 , but there might still be some special cases in this PR that we should keep.

Replacement PR: #1039 .


ModuleNotFoundError: No module named 'pywb.cdx'

I am trying to install brozzler on macOS 10.13.2. After running pip3 install brozzler[easy], I tried to run brozzler-easy, but got the following error:

CRITICAL:root:ModuleNotFoundError: No module named 'pywb.cdx'
You might need to run "pip install brozzler[easy]".
See README.rst for more information.

I checked and pywb is installed. However, it looks like the pywb package removed the pywb.cdx module at some point. Do I need to install an older version of pywb?

pywb 2.0 has significant changes, the dependency should probably be pywb<2.0 until brozzler is migrated.

Yes indeed. I committed the fix for this issue about an hour before you filed it :)
https://github.com/internetarchive/brozzler/commit/5331aca33f350db3
Since then I resolved a few more dependency version problems, and pushed a new version to pypi. Does it work for you?

@nlevitt Perfect. It works now. :smile:


aliases_on_separate_lines doesn't seem to work

Hey there, I followed the documentation and also the test Vagrantfile present in your source but it doesn't look like the flag works. The aliases don't get split and still written in one single line. I'm on the latest version of yosemity and vagrant, what could be the cause of this? What additional information do you need from me to better understand what the possible cause can be?

Hello, the newest release of vagrant-hostmanager, 1.6.0, splits the aliases on seperate lines.  The flag is meant for the next release.

I thought it was already part of 1.5 accordingly to the documentation. Thanks for the heads up

Ok, updated and checked. All working fine now. Thanks a lot.


Use column layout for hotkeys

What this PR solves / how to test:
On small terminal windows, Ink was hiding the keys needed to use the hotkeys interface. This PR switched to a column layout so the keys are visible on more terminal sizes.
Before:

After:

Im guessing due to the nature of how a terminal outputs its UI, we can't make it responsive?

Im guessing due to the nature of how a terminal outputs its UI, we can't make it responsive?

I don't think we can, I'm afraid (perhaps someone more familiar with Ink than me would know if this is possible). Having said that, I think this is slightly nicer anyway, for being able to see all options at a glance.

Im guessing due to the nature of how a terminal outputs its UI, we can't make it responsive?

I don't think we can, I'm afraid (perhaps someone more familiar with Ink than me would know if this is possible). Having said that, I think this is slightly nicer anyway, for being able to see all options at a glance.

And we are trying to remove Ink 😅

I'm slightly concerned about this change wrt integrated terminals, it uses lots of the limited vertical space. If we could get this to be responsive, that would be great. Could you use process.stdout.columns, and the resize event? Maybe change the text too to make it shorter, i.e. open a browser -> browser, to exit -> exit, ....

That would be awesome, I know we had tried using the columns/resize before but to get it to "rerender" either had to clear it or keep the old jank ones in the scroll history.

@mrbbot This is the old issue that I think referred to the resize event https://github.com/cloudflare/wrangler2/issues/374

Closing this for now. We can re-evaluate when Ink is removed, and do something based on process.stdout.columns


ItemsRepeater behaves erratically when adding items to front of list

https://github.com/mike-ward/demoscroll
DemoScroll is a minimal Avalonia desktop application that demonstrates undesirable scrolling behavior.
What it does:

Constructs a window that contains an ItemsRepeater
Fills a list with sample text that is bound to the ItemsRepeater.
Starts a 2 second timer and inserts sample text to the front of the list.

What it demonstrates:

Text will start disappearing the moment new text is added by the timer.
Grab the scrollbar thumb and move up and down. Application will stop drawing and otherwise behave erratically.

Desktop (please complete the following information):

OS: Microsoft Windows [Version 10.0.19042.746]
Version 0.10

Additional context
Related to #5151

#4709 also seems related to this.

#4709 also seems related to this.

I'm guessing that we need to port https://github.com/microsoft/microsoft-ui-xaml/pull/3699 to fix this.

I'm guessing that we need to port https://github.com/microsoft/microsoft-ui-xaml/pull/3699 to fix this.

@grokys is was already ported
https://github.com/AvaloniaUI/Avalonia/pull/5203

@grokys is was already ported
https://github.com/AvaloniaUI/Avalonia/pull/5203


More customization with tray icons

It would be awesome, if there would be more visual options to the tray aspect of polybar.
Two things in mind:
grey scaling or coloring the symbols
hide some icons in a separate menu, like in Windows.
The coloring would be nice, if you try to achieve a one colored design.
Hiding some icons helps with for example messengers witch, should run in the background just for notification.

We will probably never have a tray like on windows where you can click on an arrow and it pops up the other icons. But something like tray blacklist is maybe possible (it was also requested in #1360)

We will not implement this for current tray implementation.


Use python's subTests for some of our test suites

https://docs.python.org/3/library/unittest.html#distinguishing-test-iterations-using-subtests is a cool feature of the Python unit test framework that lets you declare subtests.
We have a few test suites, especially e.g. BugdownTest, which could likely have their output be significantly cleaned up by using this feature.  Once we've done that and seen if we like the results, we can look into where else in the codebase we want to use this.

@zulipbot claim

I've made it about half way through BugdownTest adding subTest.  Should I put in a PR now and see if the subTest is something to move forward with or keep on adding them to BugdownTest?

What does the output look like?  I had been imagining we'd focus on migrating test_bugdown_fixtures (and similar single tests that are actually dozens of tests), not on using subTest for every test function that checks a few things.

@zulipbot claim

Please review this PR @timabbott . I have used subTest on test_bugdown_fixtures and shown the output changes in the PR. What are the "similar single tests" or how to find them , mentioned in https://github.com/zulip/zulip/issues/11070#issuecomment-451299117 ?

Also @timabbott  what exactly do you mean by cleaned up output?

The purpose of this change is to make it easier to understand what's happening with test suites like this one.  I don't think it's worth working on additional test suites until we're happy with this one.

@timabbott  I have made changes as suggested by @aero31aero in PR #11538.


Grouped Radio Button

CAN I HAS?
Kinna like-a dis?
@paulcpederson

essentially just a more button-y radio group

Sketched a couple options for this:
http://codepen.io/paulcp/pen/rjWZwp/

and
http://codepen.io/paulcp/pen/bgBxae

😻

But yeah...I am cool with the light blue stuff.
Can we reduce the font size for these dudes?  Or would that be breaking a pattern?

I think we should reduce the font size. Other form elements I think use font-size--1 and font-size--2

updated codepen with more "calcite-web-y" class names: https://codepen.io/paulcp/pen/NvvbPg?editors=1100

This could potentially be part of the "calcite-apps" set instead of core.
☝ @julio8a

This will be part of v1.2.0, which should be out sometime next week


Add linky component

Description:
It adds a component (sensor) showing the last day comsuption of the house from the linky electric meter.
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: linky
    username: !secret linky_username
    password: !secret linky_password

Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

Hi @tiste,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hi @tiste,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Hi @tiste,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

@fabaff should I run gen_requirements_all.py and commit it? It seems to make a test fail.
But I'm not sure about the consequences.

@fabaff should I run gen_requirements_all.py and commit it? It seems to make a test fail.
But I'm not sure about the consequences.

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.


water barrels for CoM

I can bring filled water barrels with spigots to Church on Morgan. @taxladytracy Would that be a good thing?

We've already bought the water and we have igloo water coolers
Chris Mathews
On Wed, Sep 27, 2017 at 8:55 AM, suzanneccnc<EMAIL_ADDRESS>wrote:

Assigned #774 https://github.com/codeforraleigh/NCOpenPass/issues/774
to @ChrisTheDBA https://github.com/christhedba.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/774#event-1267705820,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOGtRT0-bKHrAPY0WOZZ0V6tvZ2ngvmks5smkW4gaJpZM4PluBG
.

OK. If the purchased water is in bottles, then water from barrels with spigots would cut down on recycling need. Purchased water can be returned. To clarify offer: 2 water barrels with spigots plus 2 refill jerry cans.

Can't be returned already submitted and reimbursed (water was purchased
weeks ago)
Chris Mathews
On Wed, Sep 27, 2017 at 11:53 AM, suzanneccnc<EMAIL_ADDRESS>wrote:

OK. If the purchased water is in bottles, then water from barrels with
spigots would cut down on recycling need. Purchased water can be returned.
To clarify offer: 2 water barrels with spigots plus 2 refill jerry cans.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/774#issuecomment-332568247,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOGtTDWbBtIN80Q7xSUGXEyMRYo5YUYks5smm-UgaJpZM4PluBG
.

Got it.


changes default arg from dict to None

I don't think that options is manipulated in a way that would cause
problems, but we're asking for trouble leaving it like this.
@ptnapoleon, can you review? It's teeny, I don't see any potential for issue here

Looks fine, +1

Thanks.


Installion Command with --pre and Pinning is Inconsistent

This is not an exact duplicate of #2019, but the two are certainly related.
Help Output:
$ python -m pipenv.help output
Pipenv version: '11.10.0'
Pipenv location: '/Users/andrew/.virtualenvs/static-site-test/lib/python3.6/site-packages/pipenv'
Python location: '/Users/andrew/.virtualenvs/static-site-test/bin/python'
Other Python installations in PATH:

2.6: /usr/bin/python2.6

2.6: /usr/bin/python2.6

2.7: /opt/local/bin/python2.7

2.7: /opt/local/bin/python2.7

2.7: /usr/bin/python2.7

3.4: /opt/local/bin/python3.4m

3.4: /opt/local/bin/python3.4

3.5: /opt/local/bin/python3.5m

3.5: /opt/local/bin/python3.5

3.6: /opt/local/Library/Frameworks/Python.framework/Versions/3.6/bin/python3.6m

3.6: /Users/andrew/.virtualenvs/static-site-test/bin/python3.6

3.6: /opt/local/Library/Frameworks/Python.framework/Versions/3.6/bin/python3.6

3.6: /opt/local/bin/python3.6

3.6.4: /Users/andrew/.virtualenvs/static-site-test/bin/python

3.6.4: /opt/local/bin/python

2.7.10: /usr/bin/python

3.6.4: /Users/andrew/.virtualenvs/static-site-test/bin/python3

3.6.4: /opt/local/Library/Frameworks/Python.framework/Versions/3.6/bin/python3

3.6.4: /opt/local/bin/python3

PEP 508 Information:
{'implementation_name': 'cpython',
 'implementation_version': '3.6.4',
 'os_name': 'posix',
 'platform_machine': 'x86_64',
 'platform_python_implementation': 'CPython',
 'platform_release': '15.6.0',
 'platform_system': 'Darwin',
 'platform_version': 'Darwin Kernel Version 15.6.0: Tue Jan 30 11:45:51 PST '
                     '2018; root:xnu-3248.73.8~1/RELEASE_X86_64',
 'python_full_version': '3.6.4',
 'python_version': '3.6',
 'sys_platform': 'darwin'}

System environment variables:

GIT_PS1_SHOWUNTRACKEDFILES
VIRTUALENVWRAPPER_WORKON_CD
VIRTUALENVWRAPPER_HOOK_DIR
LANG
XPC_FLAGS
OLDPWD
TERM_SESSION_ID
WORKON_HOME
GEM_HOME
__CF_USER_TEXT_ENCODING
CFLAGS
SSH_AUTH_SOCK
VIRTUAL_ENV
PREFIX
USER
ENV
LSCOLORS
PWD
HOME
GIT_PS1_SHOWDIRTYSTATE
TERM_PROGRAM
CLICOLOR
TERM_PROGRAM_VERSION
GIT_PS1_SHOWCOLORHINTS
Apple_PubSub_Socket_Render
TMPDIR
PROJECT_HOME
XPC_SERVICE_NAME
VIRTUALENVWRAPPER_SCRIPT
TERM
SHELL
SHLVL
PROMPT_COMMAND
MANPATH
LOGNAME
LDFLAGS
VIRTUALENVWRAPPER_PROJECT_FILENAME
PATH
PS1
_
PYTHONDONTWRITEBYTECODE
PIP_PYTHON_PATH
PYTHONUNBUFFERED

Pipenv–specific environment variables:
Debug–specific environment variables:

PATH: /Users/andrew/.virtualenvs/static-site-test/bin:/opt/local/Library/Frameworks/Python.framework/Versions/3.6/bin:/Applications/Postgres.app/Contents/Versions/9.4/bin:/opt/local/bin:/opt/local/sbin:/Users/andrew/.config/yarn/global/bin:/Users/andrew/.rubygems/2.3/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Frameworks/Mono.framework/Versions/Current/Commands
SHELL: /opt/local/bin/bash
LANG: en_US.UTF-8
PWD: /Users/andrew/Development/static-site-test
VIRTUAL_ENV: /Users/andrew/.virtualenvs/static-site-test

Expected result
I expect to be able to install a pre-release like I would a full-release package if there are no full-releases for a package, or else to receive a note about the --pre flag.
Actual result
When I attempt to install a dependency currently in pre-release (black in the following instances) with pipenv and a >= pin, I'm told it's unable to resolve the dependency, and that the error exists in the subgraph. However, if I use a == pin, then everything works. This behavior is inconsistent and confusing, and the error message is misleading. I note that I can use the >= pin if I specify the --pre tag.
$ # the following work
$ pipenv install black --pre
$ pipenv install 'black>=18.4a0' --pre # installs 18.4a2
$ pipenv install 'black==18.4a0'

$ # the following do not; error output below
$ pipenv install black
$ pipenv install 'black>=18.4a0'

The error message (shown in the output below) did nothing to make it clear that the --pre flag is missing from the last two commands. What's more, if the --pre flag is not required with ==, then I would not expect it to be required with the >= pin.
Optimally, pipenv should have installed the package with a warning, or else asked me whether I wanted to install a pre-release, rather than error cryptically as it did. To clarify, if my options are all pre-releases, I think pipenv should succeed installation, either with a warning or after a prompt. At the very least, a better error message should be provided.
I imagine the --pre flag as being relevant only in the context of packages that have full-releases and pre-releases. My perspective is that if I have two choices for the latest, such as 1.3.0 and 2.0a1, I think pipenv should ask which I want. However I understand that this is a feature change and changes how --pre operates. Given the existing behavior but also that people new to pipenv are unaware of the --pre flag, it would be nice to print a message about the flag if an distribution like 2.0a1 is available but the --pre flag has not been specified.
Imagined behavior:
$ pipenv install black # command should succeed ...
Warning! pipenv installed pre-release 18.4a2.

$ pipenv install black # ... or else ask for correct behavior
black does not have a full-release. Install pre-release 18.4a2? y
Installed black 18.4a2

$ pipenv install imagined-package # add warning text about --pre due to alpha version
Warning! imagined-package pre-release 2.0a1 is available. Stable version 1.3.0 was installed. Please use the --pre flag with pipenv if you meant to install version 2.0a1.

$ pipenv install imagined-package --pre # no changed behavior
Installed pre-release 2.0a1

Steps to replicate
Setup:
$ python -V
Python 3.6.4

$ pip -V
pip 10.0.0 from /Users/andrew/.virtualenvs/static-site-test/lib/python3.6/site-packages/pip (python 3.6)

$ rm -r ~/Library/Caches/pip

$ rm -r ~/Library/Caches/pipenv

$ rm -r Pipfile*

$ pip freeze # nothing installed

$ pip install pipenv
Collecting pipenv
  Downloading https://files.pythonhosted.org/packages/e5/fd/740a41c68c38262265d73191fb686f38d26c4ea1ea6080a65b2b626bedc7/pipenv-11.10.0-py3-none-any.whl (5.6MB)
    100% |████████████████████████████████| 5.6MB 403kB/s
Collecting virtualenv (from pipenv)
  Downloading https://files.pythonhosted.org/packages/ed/ea/e20b5cbebf45d3096e8138ab74eda139595d827677f38e9dd543e6015bdf/virtualenv-15.2.0-py2.py3-none-any.whl (2.6MB)
    100% |████████████████████████████████| 2.6MB 1.3MB/s
Requirement already satisfied: setuptools>=36.2.1 in /Users/andrew/.virtualenvs/static-site-test/lib/python3.6/site-packages (from pipenv) (39.0.1)
Collecting virtualenv-clone>=0.2.5 (from pipenv)
  Downloading https://files.pythonhosted.org/packages/6d/c2/dccb5ccf599e0c5d1eea6acbd058af7a71384f9740179db67a9182a24798/virtualenv_clone-0.3.0-py2.py3-none-any.whl
Collecting certifi (from pipenv)
  Downloading https://files.pythonhosted.org/packages/7c/e6/92ad559b7192d846975fc916b65f667c7b8c3a32bea7372340bfe9a15fa5/certifi-2018.4.16-py2.py3-none-any.whl (150kB)
    100% |████████████████████████████████| 153kB 1.7MB/s
Requirement already satisfied: pip>=9.0.1 in /Users/andrew/.virtualenvs/static-site-test/lib/python3.6/site-packages (from pipenv) (10.0.0)
Installing collected packages: virtualenv, virtualenv-clone, certifi, pipenv
Successfully installed certifi-2018.4.16 pipenv-11.10.0 virtualenv-15.2.0 virtualenv-clone-0.3.0

I try to install black as I would with pip.
$ pipenv install black
Courtesy Notice: Pipenv found itself running within a virtual environment, so it will automatically use that environment, instead of creating its own for any project. You can set PIPENV_IGNORE_VIRTUALENVS=1 to force pipenv to ignore that environment and create its own instead.
Creating a Pipfile for this project…
Installing black…

Pipfile.lock not found, creating…
Locking [dev-packages] dependencies…
Locking [packages] dependencies…

Warning: Your dependencies could not be resolved. You likely have a mismatch in your sub-dependencies.
  You can use $ pipenv install --skip-lock to bypass this mechanism, then run $ pipenv graph to inspect the situation.
Could not find a version that matches black
Tried: 18.3a0, 18.3a0, 18.3a1, 18.3a1, 18.3a2, 18.3a2, 18.3a3, 18.3a3, 18.3a4, 18.3a4, 18.4a0, 18.4a0, 18.4a1, 18.4a1, 18.4a2, 18.4a2

The error message is incredibly misleading, and is identical if I instead run pipenv install 'black>=18.4a0'.

I missed #1760 on my first pass through the issues, but the two are related. I note that my proposal and the feature in #1760 are compatible. Prompting the user to install a pre-release would enable pipenv to use the feature proposed in $1760.

I just want to note that behavioral changes will need Kenneth's review and I doubt he will sign off on requiring user input -- I can pretty much say no to that here from a design perspective.  The other question about installing a specific package alone without specifying --pre -- this is something I'm not really sure how I feel about.  I believe we intentionally fail resolution here because of the nature of pipenv as a dependency resolver -- we don't want people accidentally installing prerelease packages or pinning >=prerelease and having this mean that any new prerelease should be installed even if there is a stable one.
@ncoghlan, do you have any thoughts?

Short answer:
I think it would make sense to have this "just work" (regardless of the --pre setting), perhaps with a printed warning at install time about only pre-releases being available for that particular dependency.
Long answer:
The guiding principle that Warehouse uses for the main web UI (i.e. https://pypi.org/project/black/ ) is to show the non-pre-release with the highest PEP 440 version number, unless the project only has pre-releases, in which case it shows the pre-release with the highest version number. This is the behaviour that PEP 440 recommends: https://www.python.org/dev/peps/pep-0440/#handling-of-pre-releases
The pip CLI will behave the same way as Warehouse if no version qualifier is given (so the pip install black suggestion given in the web UI works), but currently doesn't accept pre-releases as satisfying ordered comparisons, even when no stable release is available (I'm not sure of the rationale for that behaviour - it may be a deliberate design decision I simply wasn't involved in, or else it may be an oversight).
In the case of pipenv, adopting the recommended PEP 440 behaviour (i.e. implicitly allowing pre-releases when nothing else is available) is likely to be the most user-friendly approach: the lock file will still provide stability by default (especially in combination with --keep-outdated), just as it does for any other dependency with an unstable API.

Upon discussion I think this is out of scope for now, this has additional complexity and you can already install prereleases by just using a strict pin


Fix/Docker_Image_using_latest

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PRL-5723
Change description
Added a speciific tag for the docker image.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

https://tools.hmcts.net/jira/browse/VUL-6084 is not required anymore.


update sass-loader: incompatible peerDep over the installed node-sass

Peer dependency that caused an error under the newer npm versions:
<EMAIL_ADDRESS>peer dependency over<EMAIL_ADDRESS>|| ^5.0.0 || ^6.0.0" while<EMAIL_ADDRESS>is installed:

Upgrade<EMAIL_ADDRESS>to latest. The major version change only marks the dropped support for nodejs < 14.

The peer dependency warning on<EMAIL_ADDRESS>(peer dependency over<EMAIL_ADDRESS>couldn't be solved because it doesn't look like a good idea to downgrade ajv and it's not possible to upgrade all packages requiring it as raw-loader has not been updated with a newer version.
The preferred solution here might be to drop raw-loader and use the asset-modules provided by webpack 5 but that's another subject better left for some future PR.
Added an "engine" requirement to enforce the new min nodejs version of >=14.15.0, which is still generous given the official maintenance timeline. It is also in line with the requirement of #242. Still too recent for Ubuntu 18 though.
I checked the old/new dist/ folders and it reported no change after the update.

Looks good to me, thanks! Similar to #242 just looking to make sure it's not disruptive to non-developer users. I should be able to bundle these together when we are ready to move.

@sdumetz Would really like to make this jump but need the package to build with the included docker profile as well. I tried bumping to Ubuntu 20 and Node 16 but it freezes for me on build. I know you are not using it, but if you have a chance could you just see if https://github.com/Smithsonian/dpo-voyager/commits/dev-upgrade/ will build for you? It would be great to get somewhat back on track with Node version.

Hi,
I checked-out the branch and the docker image builds fine (both development and production). If I delete dist/ and services/server/bin/, it builds the client and server before starting the server
npm install --dev is redundant as it is the default behavior, but I didn't see it causing any problem otherwise.
Didn't test if the server was working properly, I stopped at Server ready and listening on port 8000.
I'm not familiar with those scripts though so I'm not even sure I ran them properly?

@sdumetz Thanks for taking a look. Good to know it is at least building for you. It must be something specific about my configuration. I added in the install --dev because after bumping the Node version it was only installing production dependencies when node_env == production. But maybe that's a symptom of whatever else is going on. Thanks again for taking a look.

Merged here: https://github.com/Smithsonian/dpo-voyager/tree/dev-upgrade - finally got a solid build. Thanks for the PR and sorry for the delay!


Focus lost after closing Project Settings

File > Project Settings
Click Cancel
Try to type anything

Result: Nothing happens. Keyboard focus is not in editor area.
We just need a simple EditorManager.focusEditor() call to fix this, so marking as a starter bug.  Or we could use this as an opportunity to finally fix post-dialog focus more generally :-)

n00b here, searching for my first bug to tackle. Unless I'm mistaken, the status of this issue should no longer be open since @Jerhamre seems to have added a fix that's been merged in #12824?

Thanks @webjocky 👍


When I was building the flutter environment in Android Studio, Tag mismatch appeared! I don't know how to do it. Can you help me?

Thank you for your interest in Gradle!
Your issue appears to be a question about how to use Gradle. Your question might be answered in Gradle documentation or on our community Slack or forums. Find links to these resources on help.gradle.org.
If you think you have come across a Gradle bug, please file a new issue describing the problem and how to reproduce it.
If you think Gradle is missing a feature, please file a new issue describing your use case for the feature.


Update typos in example of action

The step name incorrectly had GTP instead of GPT
Also it should be files instead of file

ChatGPT's response about README.md:
Feedback and Suggestions:

Clarity and Documentation:

The code review process and setup steps are well-documented, making it easy for users to understand and follow along.
The explanation of how the workflow operates and the expected comments on the pull requests are clear and informative.

Security and Privacy Concerns:

The section on security and privacy is well-addressed, highlighting the importance of protecting sensitive information when using the ChatGPT model.
It's recommended to remind users to be cautious when sending code to external services and to follow best practices for data protection.

Efficiency and Best Practices:

The workflow configuration provided in the sample workflow file is concise and well

ChatGPT's response about README.md:
Feedback and Suggestions:

Clarity and Documentation:

The code review process and setup steps are well-documented, making it easy for users to understand and follow along.
The explanation of how the workflow operates and the purpose of each step is clear and informative.

Security and Privacy Concerns:

The section on security and privacy is well-addressed, highlighting the importance of protecting sensitive information when using the ChatGPT model.
It's recommended to remind users to review the code before sending it to ChatGPT to ensure no sensitive information is included.

Efficiency and Best Practices:

The workflow configuration provided in the sample workflow is concise and well-structured

ChatGPT's response about README.md:
Feedback and Suggestions:

Clarity and Documentation:

The code review process and setup steps are well-documented, making it easy for users to understand and follow along.
The explanation of how the workflow operates and the expected comments on the pull requests are clear and helpful.

Security and Privacy Concerns:

The section on security and privacy is informative and highlights the importance of safeguarding sensitive information when using the ChatGPT model.
It's recommended to remind users to review the code before sending it to ChatGPT to ensure no sensitive data is included.

Maintainability and Scalability:

The use of Github Actions for automation enhances maintainability and scalability

ChatGPT's response about README.md:
Feedback and Suggestions:

Clarity and Documentation:

The code review process and setup steps are well-documented, making it easy for users to understand and follow along.
The explanation of how the workflow operates is clear and informative.

Efficiency and Best Practices:

The use of Github Actions for automating code review is a good practice for efficiency and consistency.
The workflow triggers on pull request events and utilizes secrets for sensitive information, which is a secure approach.

Potential Improvements:

Consider adding error handling mechanisms in the workflow to handle potential failures during the code review process.
It might be beneficial to include a step in the workflow that checks for

ChatGPT's response about README.md:
Feedback and Suggestions:

Clarity and Documentation:

The code review process and setup steps are well-documented, making it easy for users to understand and follow along.
The explanation of how the workflow operates and the purpose of each step is clear and informative.

Security and Privacy Concerns:

The section on security and privacy is well-addressed, highlighting the importance of protecting sensitive information when using the ChatGPT model.
It's recommended to remind users to be cautious when sending code to external services and to ensure that sensitive data is not exposed.

Code Optimization:

The workflow YAML file is concise and well-structured, making it easy to understand the

ChatGPT's response about README.md:
Feedback and Suggestions:

Clarity and Documentation:

The code review process and setup steps are well-documented, making it easy for users to understand and follow along.
The explanation of how the workflow operates and the expected comments on the pull requests are clear and informative.

Security and Privacy Concerns:

The section on security and privacy is well-addressed, highlighting the importance of protecting sensitive information when using the ChatGPT model.
It's recommended to remind users to be cautious when sending code to external services and to follow best practices for data privacy and security.

Efficiency and Best Practices:

The workflow configuration provided in the sample workflow file is concise

ChatGPT's response about README.md:
Feedback and Suggestions:

Clarity and Documentation:

The code review process and setup steps are well-documented, making it easy for users to understand and implement.
The explanation of how the workflow operates and the expected comments on the pull requests are clear.

Security and Privacy Concerns:

The section on security and privacy is informative and highlights the importance of safeguarding sensitive information when using the ChatGPT model.
It's recommended to remind users to be cautious when sharing code with external services, even with encryption and security measures in place.

Efficiency and Best Practices:

The workflow configuration provided in the sample workflow file is concise and well-structured.

I made a massive change and this will no longer be necessary. Thanks.


[Enhancement] format proxy log watermark output

Before Creating the Enhancement Request

[X] I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary
currently, proxy watermark output is messy

Motivation
format
Describe the Solution You'd Like
format

Describe Alternatives You've Considered
null
Additional Context
No response

@zhiliatom I have great intrest about this issue,could you assign it to me?


[Feature Request] Use codec server to convert textual input to payload and payload to text to display

Right now remote codec is used to convert payloads -> payloads, this approach has limited flexibility and is restricted mostly to JSON input / output.

@bergundy Can you explain this one to me a little more? I didn't think codecs even supported converting to text—they are always payload-to-payload, no? Am I missing something?

Looks like this is already addressed in the CLI rewrite. We can close as soon as it's merged.
Inputs are much more flexible, way beyond JSON.

Closing now as already handled in CLI rewrite (though yes, technically we haven't merged it to main yet).


Feature Request: hide followers

In Mastodon one can set "hide followers" which shows others only "myself" as follower, but hides all others. this would be greatly appreciated for WP activitypub too. otherwise people will receive a lot of spam because bots are able to scan all followers.

This is also kind of good for privacy.

This is also kind of good for privacy.

To explain it with more details : people reading the blog or subscribing to the RSS feed are not listed publicly. But with this plugin they are, and while I don't really a need to do it (maybe only for the blog author) it can be harmful for their privacy, and they might not even realise it.

Subscribers of the RSS-Feed are not listed anywhere... the API only exposes the ActivityPub followers and that is the same behaviour as on Mastodon...

But I agree with the feature request of @vsatmydynipnet

Subscribers of the RSS-Feed are not listed anywhere...

That's my point: in this plugin case, they are listed.

and that is the same behaviour as on Mastodon...

Yes, but Mastodon allows to hide the details (only the number is shown).

@lapineige no, the AP plugin, does not list classic feed-subscribers.

But perhaps we have a different understanding of RSS feed subscribers 😉
I got your point!

no, the AP plugin does not list classic feed-subscribers.

That's not what I mean: when someone subscribe by RSS (via Wordpress own feed), that person is not listed publicly.
But if the same person subcribe via ActivityPub, it is listed in the ActivityPub profile. That might be an issue.
(btw I edited my previous post to make it clearer)

Ok, then we talk about the same :)

What about the number of followers?

Other federated social networks don't hide it, as far as I know.
It's good to have it for "federation debugging" purpose, I mean making sure that all the date from the remote account is correctly federated.
It's not a privacy issue, but it can be good to hide it to avoid negative effect of "influencers" and so on.
I'd would say it could be an option to hide it, but it's not a big deal.


Cannot find 'RCTBundleURLProvider' in scope

Hi,
I Downloaded sample project and it worked, But when i used it in my project it could not get the following files.

Please help

same problem.

Same issue :-(

Old, but i hope this help any one else =]]]]~
Because Xcode not build your .h file.
https://stackoverflow.com/questions/24002369/how-do-i-call-objective-c-code-from-swift/24005242#24005242


[FX-4737] Do not pass enableResetSearch property

FX-4737
Description
This pull request fixes the bug with passed enableResetSearch  prop, introduced in https://github.com/toptal/picasso/pull/4075.
Reason – spread operator is not type safe in this case (packages/picasso/src/NativeSelect/NativeSelect.tsx)
No type check using spread operator (no error detected)

Normal typescheck when passing prop directly (error is detected)

How to test

Temploy
Tests pass when alpha package is applied in Staff Portal in (please check out https://github.com/toptal/staff-portal/pull/11832 locally and run yarn test namespaces/jobs/libs/jobs/src/containers/SendJobAwayModal/test.tsx)
Another error in Staff Portal Jest tests that appears is fixed in https://toptal-core.atlassian.net/browse/FX-4727

Development checks

[x] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[x] Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[N/A] Annotate all props in component with documentation
[N/A] Create examples for component
[x] Ensure that deployed demo has expected results and good examples
[N/A] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[N/A] Covered with tests (visual tests included)
[ ] ⚠ Delete https://github.com/toptal/staff-portal/pull/11832 before merge

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-bot run package:alpha-release

@toptal-anvil ping reviewers

@rasitozcan I think there is a problem somewhere in types of MUINativeSelect or the way Typescript handles types of spread operator, so for now we fix the problem in master and then should be a proper research as we might have other places with this problem.