fix: resolves and addition tests for child preStart supervise

Related with #1384 and resolves #1384
if PR can reproducer this issue, the ci checks will be unable to successd: https://github.com/apache/pekko/actions/runs/9770536752/job/26971887726?pr=1385

From the perspective of stack frame, the problem lies in the handling:
https://github.com/apache/pekko/blob/46c557424d19bb2d07adf2fbd55351a8187ff359/actor/src/main/scala/org/apache/pekko/actor/dungeon/FaultHandling.scala#L160

[ERROR] [07/03/2024 09:46:12.113] [SupervisorSpec-pekko.actor.default-dispatcher-5] [pekko://SupervisorSpec/user/$a/$a] changing Recreate into Create after org.apache.pekko.actor.ActorInitializationException: pekko://SupervisorSpec/user/$a/$a: exception during creation, root cause message: [deliberate test failure]
[ERROR] [07/03/2024 09:46:12.114] [SupervisorSpec-pekko.actor.default-dispatcher-6] [pekko://SupervisorSpec/user/$a/$a] assertion failed
java.lang.AssertionError: assertion failed
	at scala.Predef$.assert(Predef.scala:264)
	at org.apache.pekko.actor.dungeon.FaultHandling.faultCreate(FaultHandling.scala:160)
	at org.apache.pekko.actor.dungeon.FaultHandling.faultCreate$(FaultHandling.scala:158)
	at org.apache.pekko.actor.ActorCell.faultCreate(ActorCell.scala:420)
	at org.apache.pekko.actor.dungeon.FaultHandling.faultRecreate(FaultHandling.scala:96)
	at org.apache.pekko.actor.dungeon.FaultHandling.faultRecreate$(FaultHandling.scala:92)
	at org.apache.pekko.actor.ActorCell.faultRecreate(ActorCell.scala:420)
	at org.apache.pekko.actor.ActorCell.invokeAll$1(ActorCell.scala:526)
	at org.apache.pekko.actor.ActorCell.systemInvoke(ActorCell.scala:545)
	at org.apache.pekko.dispatch.Mailbox.processAllSystemMessages(Mailbox.scala:297)
	at org.apache.pekko.dispatch.Mailbox.run(Mailbox.scala:232)
	at org.apache.pekko.dispatch.Mailbox.exec(Mailbox.scala:245)
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
	at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:175)

I think we can attach a test case for this, will look into this over the weekend.

@sadekmunawar Hi, my unit test partly refers to your code in #1383 links.
Would you like to contribute this to the Pekko community?

Would you like to contribute this to the Pekko community?

@pjfanning Am I doing this correctly, may I ask?

Would you like to contribute this to the Pekko community?

@pjfanning Am I doing this correctly, may I ask?

The test code was written by https://discuss.lightbend.com/u/nodeninja/summary
@sadekmunawar can you confirm if that is you? We received your iCLA.

The test code was written by https://discuss.lightbend.com/u/nodeninja/summary
@sadekmunawar can you confirm if that is you? We received your iCLA.

@pjfanning yes, that's me. After finding the bug, I wrote that test for a solution I implemented. My solution converts the FatallyFailed into a case class and attaches an Optional ActorRef to it.
I also wrote a scala version of this test in ActorLifCyleSpec. Feel free to use either version of the test
`"must not break supervisor strategy due to unhandled exception in preStart" in {
val id = newUuid.toString
val gen = new AtomicInteger(0)
val maxRetryNum = 3
val childProps = Props(new LifeCycleTestActor(testActor, id, gen) {
override def preStart(): Unit = {
report("preStart")
throw new Exception("test exception")
}
}).withDeploy(Deploy.local)
val supervisorStrategy: SupervisorStrategy =
OneForOneStrategy(maxNrOfRetries = maxRetryNum, timeout.duration) {
case _: ActorInitializationException => SupervisorStrategy.Restart
case _                               => SupervisorStrategy.Escalate
}
val supervisor =  system.actorOf(Props(classOf[Supervisor], supervisorStrategy))
Await.result((supervisor ? childProps).mapTo[ActorRef], timeout.duration)
(0 to maxRetryNum).foreach(i => {
expectMsg(("preStart", id, i))
})
expectNoMessage()
system.stop(supervisor)
}`

lgtm.
Although I have read the relevant code, I did not delve into testing and debugging

I also wrote a scala version of this test in ActorLifCyleSpec. Feel free to use either version of the test

Thanks, I have updated this PR and verified it works in locally

@Roiocam should we backport this to this 1.0.x branch?

@Roiocam should we backport this to this 1.0.x branch?

Of course, this is a bug. backport on #1396

It looks like the checks did not run the tests in SupervisorHierarchySpec.
When I ran the tests locally, two tests in SupervisorHierarchySpec failed.

handle failure in creation when supervision strategy returns Resume and Restart
survive being stressed

Can someone check if these two unit tests pass?

It looks like the checks did not run the tests in SupervisorHierarchySpec.
When I ran the tests locally, two tests in SupervisorHierarchySpec failed.

handle failure in creation when supervision strategy returns Resume and Restart
survive being stressed

Can someone check if these two unit tests pass?

Those tests are tagged as long-running tests. Maybe such tests are not run by default.
Did those tests fail before this PR was added?

Did those tests fail before this PR was added?

No, they passed in my local workspace before this PR was added. Unless there's something wrong with my local setup, this PR is the likely cause of the failures. I ran into issues with these two unit tests when experimenting with my own fix.

I will investigate it. :)

both survive being stressed and handle failure in creation when supervision strategy returns Resume and Restart  has passes in my local by using #1399


Build static binaries for Docker, so that we can use 'scratch' image

This should fix issue #1765

There is probably more: https://github.com/owncloud/ocis/issues/375

@SamuAlfageme can you take a look?

I'm trying this out in https://github.com/cs3org/ocm-test-suite/pull/27.
So far it works, but I must say the new very slim image is hard to debug, for instance:
docker run -it --entrypoint /bin/sh revad

fails because there is no /bin/sh.

@ylebre great catch, I did forget to set the CGO_ENABLED variable on the ENVs  builder step from the Dockerfile(s).
@IljaN I'll also review what cgo dependencies are we still using and how can we avoid them if that is the case.

@michielbdejong I totally empathize. Using the binary FROM scratch is great to reduce the attack surface and size of the image, but can make debugging inside the container very cumbersome.
I have used this scratch-debugger script in the past. But if you're developing locally, I'll recommend you create an image with your OS of choice as base and then copying the revad binary --from the cs3org/revad image.
In the future, things like ephemeral containers in k8s https://github.com/kubernetes/enhancements/issues/277 will make that task easier.
We can also reconsider using busybox or alpine if this becomes too annoying in the future

@ylebre could you add a changelog entry for your fix?

@SamuAlfageme sure thing, added to the PR now.

@ylebre thx a bunch!


Fix var-parameter detection for inferred params

Explanation: We've removed the 'var' modifier from function parameters in Swift 3, but the diagnostic for that is only emitted when we have a valid type loc. With inferred closure parameters, you're allowed to specify a parameter without a type. If you leave 'var' on one of those, it causes an assertion in SILGen. Instead, teach the diagnostic to handle omitted types.

Scope: Only affects function parameters with elided types.

Issue: SR-2562

Reviewed by: @DougGregor and @CodaFi

Risk: Low.

Testing: Added a test to cover this diagnostic.

@swift-ci please test

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 80f67ae6582c522f1c172d193d7fdfbb19acff61
Test requested by - @harlanhaskins

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 80f67ae6582c522f1c172d193d7fdfbb19acff61
Test requested by - @harlanhaskins

There is a crasher that no longer crashes. I'll move it.

@swift-ci please test

@swift-ci clean test


Does it deletes the file itself sometime on low download speed?

I am facing this issue since 7days continually. and it seems when the data/file isn't downloaded properly or broken while downloading, it deletes the file, and sometime the Gallery shows a broken thumbnail. my downloading code snippet is
                       holder.DownloadImage.setOnClickListener(new View.OnClickListener() {
                              @Override
                           public void onClick(View view) {
                                String  imgfilename="fdfdfdf.jpg"
                                  String SERVERURL= "http/myserver/uploads/";
                                  Uri downloadUri = Uri.parse(SERVERURL+ imgfilename);
                                 Uri destinationUri = Uri.parse(folder + "/" + imgfilename);
                               final DownloadRequest downloadRequest = new DownloadRequest(downloadUri)
                            .setDestinationURI(destinationUri).setPriority(DownloadRequest.Priority.HIGH)
                            .setDownloadListener(new DownloadStatusListener() {
                                @Override
                                public void onDownloadComplete(int i) {

                                    String sdFolder= Environment.getExternalStorageDirectory() + "/MYFOLDER/" + imgfilename;

                                    BitmapFactory.Options options = new BitmapFactory.Options();
                                    options.inSampleSize = 99;
                                    Bitmap bmThumbnail = BitmapFactory.decodeFile(audioPath);
                                    holder.imageView.setImageBitmap(bmThumbnail);

                                @Override
                                public void onDownloadFailed(int i, int errorCode, String errorMessage) {

                                }

                                @Override
                                public void onProgress(int i, long l, int i2) {

                                }
                            });

                    if (downloadManager.query(downloadId1) == DownloadManager.STATUS_NOT_FOUND) {
                        downloadId1 = downloadManager.add(downloadRequest);
                    }

                }
            });

Since it's based on Volley, you can set the default retry policy to take longer timeout. So it can download even on slow internet speed.
Refer to the method below :
/**
* Constructs a new retry policy.
* @param initialTimeoutMs The initial timeout for the policy.
* @param maxNumRetries The maximum number of retries.
* @param backoffMultiplier Backoff multiplier for the policy.
*/
public DefaultRetryPolicy(int initialTimeoutMs, int maxNumRetries, float backoffMultiplier)
So, you can use something like this to the download request
DownloadRequest downloadRequest = new DownloadRequest(downloadUri)
.setRetryPolicy(new DefaultRetryPolicy(150000, 0, 0))//150 secs timeout
.any other parameter you want to set

@hendrawd ok i will try retry policy.


Document Toom3 algorithm

Happened to be going through toom3 so thought I'd type this up.

bors r+


Don't pass SubstitutionMap by const reference

@jrose-apple @nkcsgexi Friendly reminder: SubstitutionMap is a single word in size, so passing it by const reference is unnecessary. Reduce wear and tear on your & key and embrace the power of value types!

@swift-ci Please smoke test


Config instantiation is not DDP-aware

Because config is instantiated only on the main process and then DDP is initialized, objects that are initialized in the config are not DDP aware.
Maybe there is a way to fix this by instantiating trainer first and separate and then the system

I think this isn't an issue anymore, right? Closing.

@ibro45 This is still an issue.
Now I needed this for https://github.com/Lightning-AI/pytorch-lightning/discussions/11763
But since at instantiation, objects are not DDP aware, this problem persists.

Any idea on how to approach it?

Wait how is this a lighter problem? I think it has to do with improper usage/behavior of CacheDataset only

Would swapping the order of trainer and system help? https://github.com/project-lighter/lighter/blob/5d607684136d95434f2fee5aa5c38f1e32608335/lighter/utils/runner.py#L92


[tool_crash] FileSystemException: Cannot open file, OS Error: The system cannot find the file specified., errno = 2

Command
flutter create mobile_pr

Steps to Reproduce

...
...
...

Logs
FileSystemException: Cannot open file, OS Error: The system cannot find the file specified.
, errno = 2
#0      _File.throwIfError (dart:io/file_impl.dart:675:7)
#1      _File.openSync (dart:io/file_impl.dart:490:5)
#2      _File.readAsBytesSync (dart:io/file_impl.dart:574:18)
#3      _File.readAsStringSync (dart:io/file_impl.dart:624:18)
#4      ForwardingFile.readAsStringSync (package:file/src/forwarding/forwarding_file.dart:99:16)
#5      ErrorHandlingFile.readAsStringSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:218:22)
#6      _runSync (package:flutter_tools/src/base/error_handling_io.dart:590:14)
#7      ErrorHandlingFile.readAsStringSync (package:flutter_tools/src/base/error_handling_io.dart:217:12)
#8      CreateBase._computeTemplateManifest (package:flutter_tools/src/commands/create_base.dart:665:37)
#9      CreateBase._templateManifest (package:flutter_tools/src/commands/create_base.dart:652:43)
#10     CreateBase._templateManifest (package:flutter_tools/src/commands/create_base.dart)
#11     CreateBase.renderMerged (package:flutter_tools/src/commands/create_base.dart:478:25)
#12     CreateBase.generateApp (package:flutter_tools/src/commands/create_base.dart:503:29)
#13     CreateCommand.runCommand (package:flutter_tools/src/commands/create.dart:350:37)
<asynchronous suspension>
#14     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1336:27)
<asynchronous suspension>
#15     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#16     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#17     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:296:9)
<asynchronous suspension>
#18     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>

[✓] Flutter (Channel stable, 3.10.3, on Microsoft Windows [Version 10.0.19045.2965], locale en-US)
    • Flutter version 3.10.3 on channel stable at C:\Flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f92f44110e (2 days ago), 2023-06-01 18:17:33 -0500
    • Engine revision 2a3401c9bb
    • Dart version 3.0.3
    • DevTools version 2.23.1

[✓] Windows Version (Installed version of Windows is version 10 or higher)

[✓] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    • Android SDK at C:\Users\Administrator\AppData\Local\Android\sdk
    • Platform android-32, build-tools 32.1.0-rc1
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Professional 2022 17.5.3)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Professional
    • Visual Studio Professional 2022 version 17.5.33516.290
    • Windows 10 SDK version 10.0.22000.0

[✓] Android Studio (version 2022.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[✓] VS Code (version 1.77.1)
    • VS Code at C:\Users\Administrator\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.66.0

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.2965]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 113.0.5672.127
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 113.0.1774.57

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Flutter Application Metadata
No pubspec in working directory.

Closing this as a duplicate of https://github.com/flutter/flutter/issues/91559.


Application Error on District Dashboard

This is happening when I am clicking explore on SBM-U and then trying to compare districts.

@aashimgarg please look into it

Hey @samwhocodes can you exact url for which you are getting this application error

@aashimgarg sending the link might not work (https://district.openbudgetsindia.org/bihar/188?scheme=sbmu&indicator=budget-utilisation)
Go to any state, and open any district, on the scheme performance page go and click on explore more fo SBM-U. Then on the compare district page, in the dropdown no other district is being listed and if I type anything it automatically going to the application error page.

Done


Update CowSwap.json

Adding all remaining IC products.

Hey, thanks for the contribution!
I've recreated the PR adding the images and optimizing them https://github.com/cowprotocol/token-lists/pull/34
Also @Mr-Madila could you please head over there and "sign" the CLA?
Just need to copy paste the sentence stating that you agree to contributing to this repo https://github.com/cowprotocol/token-lists/pull/34#issuecomment-1416013071


add preprocess_bsdd json

Close do

Closed due to https://github.com/AECgeeks/ifc-pipeline-validation/pull/66


feature/conduit behind CLI flag

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.kschri201 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Feat column codeCompletion

Introduction
support column code completion #211
Changesets

flink support column suggestion and add test cases
spark support column suggestion and add test cases
hive support column suggestion and add test cases
trino support column suggestion and add test cases

column 好多呀

++++1


Can i help you to answer webservices question?

Please describe what you can offer in this open repo project.


Allow Http{Status,Response}Exception to have RequestLog.responseCause().

Armeria currently handles Http{Status,Response}Exception specially. When it is thrown by a user, the response generated from the exception is sent as it is and RequestLog is ended successfully.
However, in some case, a user wants to send a custom response using Http{Status,Response}Exception while ending the RequestLog exceptionally.
It would be nice if a user can specify a cause when creating Http{Status,Response}Exception and then HttpServerHandler uses the given cause when ending the RequestLog, i.e. ctx.logBuilder().endResponse(httpResponseException.getCause())

Hello, I'd like to try solving this. I've been looking at the code and I came up with some questions:

Should I specify a setter for the cause when creating the Http{Status,Response}Exception, or should I by another way?
In the HttpServerHandler is the cause already handled? If its not could you tell me where I should add the new behaviour?

The problem has been fixed by #3674


[Feature] support lzo block decompression

Fixes #issue
Mostly it's for parquet scanner.
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 20 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/util/compression/block_compression.cpp
0
20
00.00%
[1014, 1016, 1017, 1018, 1021, 1023, 1025, 1028, 1030, 1031, 1032, 1033, 1034, 1036, 1039, 1042, 1045, 1078, 1079, 1080]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 20 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/util/compression/block_compression.cpp
0
20
00.00%
[1014, 1016, 1017, 1018, 1021, 1023, 1025, 1028, 1030, 1031, 1032, 1033, 1034, 1036, 1039, 1042, 1045, 1078, 1079, 1080]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 30 / 40 (75.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/util/compression/block_compression.cpp
30
40
75.00%
[1023, 1025, 1037, 1045, 1052, 1059, 1060, 1069, 1072, 1075]

@mergify backport branch-3.1

@mergify backport branch-3.2


CLDC-2862: Prepare maintenance page for PaaS app

https://dluhcdigital.atlassian.net/browse/CLDC-2862
This implementation may be a little naive, but given how experienced people on the team are with Rails I thought it made sense to raise a PR sooner rather than later.

Presumably testing this will require some co-ordination of people using the review app and turning the maintenance mode on.

Presumably testing this will require some co-ordination of people using the review app and turning the maintenance mode on.

I tested it locally by doing this and was happy with everything. But yes I imagine whoever tests this will want to do the same.

Were we going to disable scheduled jobs as part of this, or is that for a future PR?

@RachaelBooth ah, forgot about that (it's not mentioned in the ticket and I don't think it's in any other tickets btw). I will implement now as part of this PR.

Were we going to disable scheduled jobs as part of this, or is that for a future PR?

@RachaelBooth ah, forgot about that (it's not mentioned in the ticket and I don't think it's in any other tickets btw). I will implement now as part of this PR.

It's vaguely mentioned in a comment on this ticket as an "either here or another ticket" thing - but we've not got another ticket for it.

Should make sure someone explicitly does some testing of this before merging (I've looked at the code, but not the review app with the maintenance mode on)

Should make sure someone explicitly does some testing of this before merging (I've looked at the code, but not the review app with the maintenance mode on)

@RachaelBooth I've tested this and happy with it, but it should probably have another pair of eyes on it - will ask the team.

Should make sure someone explicitly does some testing of this before merging (I've looked at the code, but not the review app with the maintenance mode on)

@RachaelBooth I've tested this and happy with it, but it should probably have another pair of eyes on it - will ask the team.

@RachaelBooth Nat has tested this and added his comments to the ticket. As agreed he has not tested the sidekiq job enqueueing functionality.


Some users are never suggested when trying to set the value of a Relationship

Bug report
Describe the bug
When creating or editing objects in the Admin UI, some users are never suggested when one of the fields is a Relationship to User. There doesn't seem to be any pattern to which users are ignored or not. Screenshotting is hard cause the list disappears after unfocus...
The server says "Knex adapter does not currently support search!" when searching but that was never a problem before, the "search" box didn't work but relationships did.
To Reproduce
I'm not sure how to reproduce this bug. I'm using the Knex adapter, my Users have an email, firstname and lastname and I have ~300 of them, with sparse IDs up to ~500.
Expected behaviour
When searching for users to set as a value in a relationship, I can filter them by typing part of their name or ids. For some reason this ignores some users apparently randomly.
System information
The app is hosted on Heroku and the bug happens with all browsers.
All my keystone 5 packages are up to date.
Additional Info
The Admin UI throws errors like TypeError: e[c.gqlNames.listQueryName] is undefined in one generated file. I haven't found where it is in the source.
Looking closely at the requests the UI is fetching Users with RelationshipSelect and RelationshipSelectMore. It seems to try to look through approximatively the first 260 users (in a completely random order because it doesn't even pass the search term) and then just gives up. It also re-sends the same first RelationshipSelect query every time along the RelationshipSelectMore.

I solved the problem by setting adapterConfig.searchField in the list configuration a good while ago btw. The error didn't help much.


vnc: do not send any data if cliprdr channel not available

This caused disconnection when client connecting without cliprdr
channel because VNC module tries to send data to a non-existent
channel (channel_id = -1).
Should fix #755.

This approach is not correct.


Can't access to the stored token in a session

How can I get the stored token in my session?
I need to get it to add it to the Authorization header inside my adapter, but I can't do     console.log(this.get('session.content.secure.token'));

Assuming you're using ESA 1.0 or later you can do console.log(this.get('session.data.authenticated.token'));.
Please use stackoverflow.com for questions and github only for issues.


Where does the Gradle Autobuild invocation logic live?

Hi! I work for Gradle.
I'm trying to figure out where the autobuild logic that invokes a Gradle build lives. Using code search in this repository, I'm not seeing any references to Gradle here. Where else might I look instead?

I'm afraid the autobuild logic is part of CodeQL and currently that part is not open sourced. Perhaps @aibaars can help here?

there probably isn't any for gradle?

Or it's just looking for a file build.gradle
https://github.com/github/codeql-action/blob/24a95a04112446c865a0dca3b17e4de863a976da/tests/java-repo/build.gradle


Cannot be used in commonjs

Simply put, if I try to introduce '@plasm/types' via require, I will get an error.
index.js
require("@plasm/types")

excucte: node index.js:
Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /home/...
require() of ES modules is not supported.
require() of /home/... is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.

what version are you using? the latest 1.5.4-3 fixed the issue for me

Yes, it has been fixed


ci: build lucem on push to any branch with github actions

Hi! Thanks for creating this project. I'd like to begin contributing by adding a GitHub Actions workflow that installs Nim and installs and builds the project and uploads the resulting binary for public consumption.

thanks :3


run_clm.py tries to push Neuron graphs to optimum-neuron-cache even when no credentials are specified

I previously ran the run_clm.py example and populated the public optimum-neuron-cache with the graphs. When I run subsequent jobs, there are a handful of smaller graphs that are JiT-compiled, however the larger graphs all seem to be present in the cache, and training proceeds quickly.
The job completes successfully, but at the end of the job there are many 'invalid username or password' errors when Optimum Neuron is attempting to push the newly compiled graphs to the hub cache. This is undesirable and creates a lot of noise. This push should not be attempted unless the user has requested it.
Error message:
Repository Not Found for url: https://huggingface.co/api/models/aws-neuron/optimum-neuron-cache/preupload/main.
Please make sure you specified the correct `repo_id` and `repo_type`.
If you are trying to access a private or gated repo, make sure you are authenticated.
Invalid username or password.
Note: Creating a commit assumes that the repo already exists on the Huggingface Hub. Please use `create_repo` if it's not the case..
Did not push the cached model located at /tmp/tmpb7e4bn_8/neuronxcc-<IP_ADDRESS>+c5231f848/MODULE_15768223958212646773+d41d8cd9/model.hlo.pb to the repo named aws-neuron/optim
um-neuron-cache because it already exists there. Use overwrite_existing=True if you want to overwrite the cache on the Hub.
Could not push the cached model to the repo aws-neuron/optimum-neuron-cache, most likely due to not having the write permission for this repo. Exact error:
401 Client Error.

Yes, closing this since we dont rely on that anymore.


Search box is not encoding special characters while navigating to custom search page

Category

[x] Bug

Describe the bug
Hi I've already submitted an issue here but unfortunately it got closed. I hope I haven't conveyed it properly.
The issue is with sharepoint search box, when i tried entering a keyword with special character like c++ or j&j, the special characters were not encoding and passed directly to the query url to the custom search page.
Steps to reproduce
s1: create a custom search results webpage
s2: type a word inside the search box in my case it is c++
s3: see the url which is not encoding the value
Expected behavior
Expected : /CustomReults.aspx?q=C%2B%2B&k=C%2B%2B
Actual : /CustomReults.aspx?q=C++&k=C++
Environment details (development & target environment)

Target Environment: SharePoint Online

The other issue was closed because it appeared you were asking a question about the PNP Search Web Parts... a different project with its own repo (the one I linked to when I closed your issue).
This repo is for development questions, not OOTB or end-user questions. Those should be posted to TechCommunity.
Either way, the question doesn't belong here... hence why we closed it.


Spurious vertices created in CopyRuntimeMeshFromStaticMeshComponent

Hi, firstly this contribution is amazing - thank you!
I'm using CopyRuntimeMeshFromStaticMeshComponent to generate a dynamic mesh from a static one. However, this results in a vertex buffer with lots of additional vertices with random, non-initialized values.
It typically results a bounding box range check throwing an error.
The culprit seems to be the use of the AdjacencyTriangles buffer in GetSectionFromStaticMesh. As it doesn't seem to be used, for now I've just set AdjacencyTriangles to nullptr and moved the AdjacencyTriangles->Reset() call to after the (AdjacencyTriangles != nullptr) check. All seems to work.
Hope that makes sense, interested to know if this is my particular use case or not.
Not sure which commit I'm on, pulled down the master branch today 20/10/2016
Thanks!

 I was reading Indices instead of AdjacencyIndices so it was apparently letting me read out of bounds. Just pushed a fix for it, let me know if you have any more problems

Ace! Thanks for the fast response, I was pulled onto other projects so only just picking this back up.
Cheers!


feat: convert area-of-work jest to cypress tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.90%. Comparing base (e389b1d) to head (1e3a628).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   70.29%   69.90%   -0.39%
==========================================
  Files         166      166
  Lines        2313     2313
  Branches      377      377
==========================================
- Hits         1626     1617       -9
- Misses        659      667       +8
- Partials       28       29       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


tests: use npm ci

npm ci is much faster and is meant for CI. This PR is meant for evaluating the new ci command and testig the performance and compare the logs of Travis CI.
https://docs.npmjs.com/cli/ci
http://blog.npmjs.org/post/171556855892/introducing-npm-ci-for-faster-more-reliable

Closing as we use Yarn now and it provides the same using yarn.lock.


Director not consuming the OpenEBS EE version

As part of Director RC builds when we install OpenEBS it should install the OpenEBS-EE version.

This has been fixed by the below PRs:
https://github.com/mayadata-io/openebs-upgrade/pull/27
https://github.com/mayadata-io/openebs-upgrade/pull/28
https://github.com/mayadata-io/maya-io-server/pull/1838
https://github.com/mayadata-io/maya-io-server/pull/1839

Now it is present in 1.9.0-RC4.
WE can close this issue.


Resource.textContent() not implementable in Browser

Right now Resource.textContent() isn't implemented in the Browser (nor is .size obviously) because in the browser we can only deal with external data asynchronously.
Right now that means that a module like ceylon.locale cannot be used at all in a browser.
Futures aren't part of the language module so it seems to me that the only thing we can do is to add asynchronous versions of the two members:

textContentAsync(encoding, callback) and
sizeAsync(callback)

The documentation should then state that it would be preferable to always use those for best compatibility across all possible platforms.
Wdyt @gavinking @chochos ?

Is this a problem similar to the readline thing? Isn't the node.js version also async? In JS we can detect at runtime whether it's running on a browser and use a different implementation...

Don't ask me the things you should know @chochos ;)
But there could indeed be other places where we would need an async version, readline is a good example. Any others you can think of?

And sorry about the previous comment, it's been some time since I looked at that code; turns out, the node.js version has a way to read files synchronously.

So you don't read a module as a package along with all its resources then?

Not with all its resources. Those are loaded on demand.

So you don't read a module as a package along with all its resources then?

So, yeah, I agree, that's the easy solution, and it's the solution I've partly implemented.
However, the current implementation works by just copying text data into strings embedded in the .js file. Which I guess works well enough for stuff like .properties files and maybe very small xml and json files, but starts to fall apart for large text data files, and for anything that's not plain text.
So a second shot at this would add a layer of indirection, and eagerly populate the data fields from files on the server while executing the .js file (i.e. when loading the module).
A third option is to add the APIs proposed above for loading resources asynchronously, but I gotta say it's just not clear to me that that is really a useful model for the typical sorts of things we call "resources". And, in that case, we already give you the option of getting the URI from the Resource and going and fetching it from the server yourself in your own code.
So I dunno if it's really even offering that. For simple .properties files and the like, loading the data with the module seems quite reasonable to me.

i.e. for example, getting a Locale instance in a callback seems a little crazy to me. Perhaps I'm wrong about that, and it's the sort of thing people are used to these days.

So a second shot at this would add a layer of indirection, and eagerly populate the data fields from files on the server while executing the .js file (i.e. when loading the module).

Oh, wait, looks like there's no good way to do this after all; I had thought there was an API in requirejs, but now I can't find one.

So my approach of embedding in the .js file doesn't really work for ceylon.locale because it results in a 3.3MB file size. There needs to be a way to filter down all those 162 language variants to something more sane.
I guess we can handle this at build time by having two different resource directories, resource-jvm and resource-js.
Or, yeah, the only other solution I can see would be to make a JS-specific version of the locale() function which accepts a callback. (Yew!)

So my approach of embedding in the .js file doesn't really work that well for ceylon.locale because it results in a 3.3MB file size.

Well, it's <190K gzipped, but still large.

I've nothing against callbacks: they allow other libs to built on top and provide support for RX for example.

It's not that I'm against callbacks; just that it seems amazingly inconvenient for resources.

What if we pack them like we pack the metamodel info? Could be one separate file with all the resources, or one file per resource. The compiler can even optimize so that all smaller resources can be stuffed in one file and large resources be in separate files.
So, a resource file gets compiled as a common js module that exports a string with said resource as text...

Sure, that would be better I suppose. But how does the meta model file actually get fetched from the server? I have never understand that.

A call to require

At the time when you load the module I guess?

No, it's lazy. There's a function in the main module that internally returns the big model object if it's already loaded, or loads it the first time via require. Come to think of it, that might be unnecessary since require caches the loaded module anyway...
So, we can wrap a resource in a common js module that exports a single value, then load it via require and returns that value. As I mentioned before, we can optimize this to stuff several small resources in a single js module, and leave large resources on separate modules. The main difference with leaving the resources as they are and loading them manually (as we do in node backend) is that require works synchronously...

Yes. It fetches the module from the server, once, and caches it locally for subsequent requests.

I just did a quick handwritten PoC for this and it works fine. I have a common JS module with this:
(function(define) { define(function(require, ex$, module) {

function loadResource(name) {
  var res=require('shit/0.1/resources');
  return res[name];
}

//MethodDef run at caca.ceylon (1:0-11:0)
function run() {
  console.log("Hey");
  console.log(loadResource("uno"));
  console.log(loadResource("dos"));
  console.log(loadResource("uno"));
  console.log(loadResource("dos"));
}
ex$.run=run;
});
}(typeof define==='function' && define.amd ? define : function (factory) {
if (typeof exports!=='undefined') { factory(require, exports, module);
} else { throw 'no module loader'; }
}));

And the resources.js file contains this:
(function(define) { define(function(require, ex$, module) {

console.log("Loading module resources");

ex$.uno="Esta es la cadena uno";
ex$.dos="And this is string 'dos'";

});
}(typeof define==='function' && define.amd ? define : function (factory) {
if (typeof exports!=='undefined') { factory(require, exports, module);
} else { throw 'no module loader'; }
}));

So when you run the run function in the module, you get this:
Hey
Loading module resources
Esta es la cadena uno
And this is string 'dos'
Esta es la cadena uno
And this is string 'dos'

Which means the module is loaded lazily, just once, asynchronously, via require.

So to implement this, then:

The compiler must process the module resources, packaging them as CommonJS modules
Modify the Resource implementation in JS so that it uses require to fetch the resource contents
If we want to optimize for space, we can pack resources under a certain size in files up to a certain size, so that for example you can have 10 small resources and 2 larges ones and you end up with 3 files (one for the 10 small resources, and each large resource in its own file). And we'd need some index in the module to know where each resource is found, to call require with the proper module for a requested resource.

However, binary files could be a problem, and perhaps we want to leave the original resources available as well, in case they are used directly in URL's in web apps for instance.

However, binary files could be a problem

Yes, I agree, this should be only for text files.

So to implement this, then [...]

That all sounds just perfect @chochos.

How do we detect text files?

I have some rubbish heuristics for that in the code already.


Adjustments design for Nextgen realization dataset and job workflow automation

The TL;DR:

DMOD has logic to automate forcing dataset selection, so a user doesn't have to know/provide details of forcing datasets when requesting jobs
DMOD does require a realization config to start a Nextgen job
A valid Nextgen realization config requires details on the forcing data, which for DMOD implies details of the forcing dataset, thus undermining 1.

Details
DMOD intends to intelligently determine certain things for a user, to relieve certain burdens.  One example is that DMOD will automatically find a suitable forcing dataset for a requested Nextgen job, assuming one is available, rather than requiring the user to specify one.  In the future, DMOD may produce such a dataset on-demand, deriving it from other existing datasets (e.g., one containing the appropriate data but not in a directly supported format).
Separately, in order for the user to request a Nextgen job execution workflow, DMOD currently requires a Nextgen realization config.  More specifically, since DMOD is designed to make data accessible via datasets, the request must specify a  NGEN_REALIZATION_CONFIG format dataset, presumed to contain a valid, finalized realization config.
These two things conflict:  a valid realization config will including certain details about the forcings, but the intent is for the user to not need to know and provide details on the forcing dataset.
The primary problem is that, unless the particular forcing dataset is known, the correct forcing provider type settings for the realization config (e.g., CsvPerFeature) cannot be known.  Further, at least initially, there are also problems with the forcing path settings, as the path to datasets within the Docker worker containers is tied to the dataset name.
Solutions
The only feasible solutions I see are:

do not require a complete realization config when a job is requested
dynamically edit the saved realization config during the steps of the workflow
a solution made possible by altering the format of Nextgen realization configurations and functionality of Nextgen

I personally think option 1 is most appropriate, but some discussion is probably needed.
Option 1
If To represent config details that are provided by the user during the request, an intermediate dataset format would be needed.  Note that it should still be possible to make requests based on existing realization config datasets, as can be done now.  This just leaves the user responsible for their semantic correctness.
Doing that would require something like the following:

[ ] Add intermediate dataset format JOB_CONFIG (or something similar) as a representation of a partial realization configuration
[ ] Update messaging and job workflow start logic to accept either JOB_CONFIG (with sufficient data) or NGEN_REALIZATION_CONFIG for Nextgen job request
[ ] Update the GUI (and perhaps the CLI) to create such datasets from user form input immediately prior to submitting applicable job requests
[ ] Update job exec workflow (in data-service) to have JOB_CONFIG  format be satisfactory for realization config requirements at the AWAITING_DATA_CHECK job status step
[ ] Update job exec workflow to derive a realization config dataset from JOB_CONFIG dataset and suitable forcing dataset at the AWAITING_DATA job status step

Option 2
I don't particularly like option 2.  Other than subsetting (or perhaps supersetting), the automated logic for manipulating  datasets in DMOD was only intended to adjust the format of user-provided data.  We can explore what this would take though.
Option 3
This is really a question that requires some feedback from the primary Nextgen team.

@hellkite500, @aaraney, @christophertubbs, @mattw-nws, this a bit of a large one, but I think this needs some discussion.  We can handle it async, or we can set up a meeting if everyone prefers.

Thanks for writing this up, @robertbartel! I agree that options 1 is probably the most viable and suitable. In all cases, it seems we will need to produce valid realization (and calibration) configuration files, module init_config files, and any other associated files. Likewise, as you pointed out previously, challenges with path fields likely mean we will need to generate or interpolate path fields on the fly. Potentially based on deployment environment requirements.
With that in mind, i'm inclined to think utilizing an intermediate format from which we generate required configuration files is the way to go. We could potentially even stick a small configuration generation script in model exec images to inject, for example, linked library paths. I am not sold on, at least to start with, storing these intermediate datasets as I have a hunch we will run into fun migration and backwards compatibility problems as we sort out what format works best for our use cases. At the same time, I think it's crucial that we can reproduce experiments and that includes configuration files. That might mean we decide to add additional metadata as a post model execution procedure too for example, specify the image and tag used to conduct the experiment. Sorry for talking in circles, im just on the fence.
Having had a look at a realization configuration file, if we go with option 1, it appears we may be able to base our intermediate dataset on the fields specified in the catchment realization or formulation sections. Given that we already capture start time, end time, and catchment ids in our current model exec messages, we should be able determine forcing needs using only the model names (assuming we can acquire ngen models' input and output vars) and configuration specific variable_names_mappings. It should be pretty straightforward to run a mark and sweep like algorithm to determine required formulation forcing fields. This does not hold for non-BMI forced realizations (I hope im using the right terminology, please correct me when im wrong) like noah-owp-modular which means we will likely need to register models' input source capability (BMI vs InitConfig vs BMI | InitConfig) and handle them differently. Granted I don't full understand the problem with determining forcings, particularly the hurdles CsvPerFeature introduces.

Use subset of fields and or fields names from ngen.config NgenRealization and Realization as intermediate format. Namely, time, formulations, and forcing. We will also need to know which hydrofabric(s) are required. A broader discussion is required to discuss potentially relating hydrofabric's and their contents to formulations within the realization config. This is related, but beyond the scope of this issue.
Related, will need link catchment aggregated forcings' to hydrofabric's, likely at the dataset level.


Update README for comparison tool

I guess we're confusing 'compare' tool and 'benchmark' tool here (the latter is what I called performance comparison tool).

Also, I've already linked the design doc for the benchmark tool from it's README - https://github.com/kubernetes/perf-tests/blob/master/benchmark/README.md.
IMO we should keep that readme short and crisp with the design doc linked there (instead of putting design doc in readme). Wdyt?

I guess we're confusing 'compare' tool and 'benchmark' tool here (the latter is what I called performance comparison tool).

Yeah sorry for that.

Also, I've already linked the design doc for the benchmark tool from it's README -

I made the docs directory for that.

/lgtm


Pppsys 48527 improve iframe handler security

the improved iframe handler and fixed PP logo

Please close duplicated PR after merge this one.


Bot doesn't respond

Logs indicate it is connected to the db (localhost/Zira), user (ziraUser) is created with readWrite and dbAdmin perms for the Zira db, password is alphanumeric only (didn't seem to like symbols in the password).
No response from the z/help command (existing "official" zira bot does respond; I have my local instance sharing the bot account of my Mod Mail bot from Dragory).  Bot account has server admin perms.
No errors in logs since removing the trello lines in the config file.  No apparent errors, it's just non-responsive.

Settings were unclear.  Thought prefix referred to DB settings for prefix on table names, and it overrides the default z/ prefix.  Removing prefix restored normal behaviour.

@sporkwitch Could you share on how you setup your instance of Zira? My version isn't responding either

Ensure you set up mongodb correctly (you'll need to create a db and a user) and that the bot is connecting to it.


feat: :sparkles: Make video capabilities packet extensible; negotiate FFE support

Use ugly workaround to inject more info into the VideoStreamingCapabilities packet to not break protocol compatibility. The workaround is kept until v21 is released.

@ShootingKing-AM Since now the video capabilities packet can be extended freely, would you like to have this exposed to the C API? Instead of static fields you send a json string representing the info.

These three setting are usually problematic on phones https://github.com/alvr-org/PhoneVR/issues/236#issuecomment-1774064429 . Also it's better if the resolution preset is lowest by default.


Change History for Deploy Windows 10 - md links

https://docs.microsoft.com/en-us/windows/deployment/change-history-for-deploy-windows-10
md links are not being adjusted properly on the production site (.md is supposed to be removed).  I think putting a ./ fixes it but I could be wrong as I am pretty new to this
as a result 14 links on this page return 404

Someone added .md in the links. This needs to be removed. Thanks for noticing the error!


Unclear how to upsert array entries

I have insert logic like this, which fails if there's no memberships field, which I don't know how to fix to be more like an upsert behaviour (creating the field 'memberships' as an array before appending).
Currently it's responding with...
'No attribute memberships...'
return r.table("users").get(userId).update({
                memberships:r.row("memberships").append({
                    groupId:groupId,
                }),
            })

Is the only way to resolve a missing referenced array to do explicit checking and insertion of the array field?
I would consider using insert with the known primary key, but it's not clear how merge is handled when a merged field entry is an array (index-by-index overwriting, as if the numbered indexes were field names? alternatively, are two arrays merged by appending? it would be good to state this somewhere).
From the update documentation, I understand the above is the canonical way to introduce an entry to an existing array. Ideally there would be documented examples for typical array (nested field) operations, such as this - lazy-creating an array, and inserting a member, as it's potentially a very common use case in a schemaless data structure.

Here's a functional example which uses r.branch explicitly to handle the two cases of insert or upsert...
    promiseAddUserToGroup:function(userId, groupId){
        return this.registry.dbConnectionPromise.then(function(dbConnection){
            var membership = {groupId:groupId};
            return r.table("users").get(userId).update(
                    r.branch(
                        r.row.hasFields("memberships"),
                        {memberships:r.row("memberships").append(membership)},
                        {memberships:[membership]}
                    )
                )
                .run(dbConnection)
        })
    }

Is there a less fiddly way to do it?

The update page goes into some detail on how to update nested fields, and the use case you're talking about is the one that has the example of adding another note to Bob Smith's record--except that that example doesn't show what happens if the notes field doesn't exist, which is the error that you hit. So I think we should update that example.
But, actually, there is a less fiddly way to do this: the default command. For your example, I think what you'd want would be something like:
promiseAddUserToGroup: function (userId, groupId) {
  return this.registry.dbConnectionPromise.then(function (dbConnection) {
    var membership = {groupId: groupId};
    return r.table('users').get(userId).update(
      {memberships: r.row('memberships').default([]).append(membership)}
    );
  });
}


Relative path

I can not make paths relative to my url
I really need the paths of static files to be ./
I initially do not know which way will be issued by the server
router:{
mode:'hash',
base:'./'
},
DONT WORK!

This question is available on Nuxt community (#c7533)

???

Archiving this duplicate question in favor of https://cmty.app/nuxt/nuxt.js/issues/c7534


schema: update json tags to allow optional fields be empty

Related to #547

Some tests failed

Unfortunately I got another issue related to this omitempty issue, I will try to stack them up in this PR.

Some tests failed

For arrays it is difficult, since there is not really a difference between an empty array or nil, as far as the go deserializer is concerned. I think this is one of the cases, where we would need something like a real optional attribute. I think something like
Graphics []VMGraphics `json:"graphics,omitempty" optional:"true"`

is more accurate.

Some tests failed

Some tests failed

ok to test

Some tests failed


chore: add validating admission policies tutorial

This PR adds tutorial for Validating Admission Policies.
Closes #502

Thanks @MariamFahmy98 !!


fix non-inchi build

@ptosco : It would be cool if you could quickly look at this since it's related to your recent InChI changes.

I'm going to merge this since it's simple, but feedback is still welcome and we can re-open if need be.

There is a fix to be applied here: https://github.com/rdkit/rdkit/pull/1020


Question: Why is MVCC Being Removed? Are There Unknown Bugs?

Hi,
I’ve recently been looking to use the TRANSACTIONAL_SNAPSHOT atomicity mode in Ignite for achieving consistency across key reads, which is dependent on MVCC. I’ve noticed that since version 2.12, MVCC has been deprecated, and it was fully removed in version 2.16.
I have built parts of my project on version 2.15 and I am mainly interested in an embedded memory database scenario that involves using KV, SQL, and Index interfaces for production use. Are there any unforeseen bugs or risks that I should be aware of when using these features in a production environment? Could someone provide insights into the reasons behind the removal of MVCC and any associated risks?
Thanks.

Hi @liupan664021 ,
The main issue with the current MVCC implementation is that it is based on using a single node (the coordinator node of the cluster) for transaction ordering and 2PC protocol for distributed commits. IMHO, this approach is slow and is not scalable by design.
Also, It seems that there are not enough contributors/maintainers willing to support, develop, and improve the feature.
You can find additional details here:

Mark MVCC with @IgniteExperimental
Removing MVCC public API

Thanks,
S.

Thanks so much for the explanation@sk0x50.
The MVCC feature is quite important for non-KV APIs, including SQL, Index, etc. Is this on Ignite’s roadmap? For example, will version 3.x of Ignite have better MVCC features?
Thanks.


cmd/go: mod tidy considers directory starting with _

What version of Go are you using (go version)?
Tested with:

go1.17.6 linux/amd64
go1.18.3 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/tsd/.cache/go-build"
GOENV="/home/tsd/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/tsd/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/tsd/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18.3"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build572917264=/tmp/go-build -gno-record-gcc-switches"

What did you do?
pwd
# /tmp/go-test

go mod init example.com/user/go-test
# go: creating new go.mod: module example.com/user/go-test

mkdir _data
sudo chown root:tsd _data
sudo chmod 700 _data
go mod tidy
# pattern all: open /tmp/go-test/_data: permission denied

What did you expect to see?
Successful execution of go mod tidy
While it's correct that permission denying rules are a fact in this situation, the go tool should still ignore/skip this folder.
The Go Modules Reference states:

Note that go mod tidy will not consider packages in the main module in directories named testdata or with names that start with . or _ unless those packages are explicitly imported by other packages.

What did you see instead?
The tool exits with pattern all: open /tmp/go-test/_data: permission denied without changing go.mod/go.sum

Neat find! I think this is closely related to CL 416179.

Indeed, looks like that change will fix this issue. Thanks for reporting!


Long boot time when installed

Installed the script and noticed that while it's installed, the boot time is around 2 minutes. I tracked it down to systemd-udev-settle.service. Something in the code seems to be calling this service, which seems to cause the computer to wait for 2 minutes while devices load. This service appears to be deprecated, and regular boot times can be restored to regular times with systemctl mask systemd-udev-settle.service.
It seems Ubuntu hasn't disabled this service, so the install procedure should probably also mask this service if it exists. (Or, at least mention this issue in the readme)

Interesting, I just removed the Intall target from the systemd unit file, which seems unnecessary. Can you try again? If its not working, I´ll update the readme.

The new version doesn't appear to solve the issue

Thx for trying! I added your workaround to the readme in aab73258e5a9fcf416f7c902af8dcea0bc62bc80


Solved a program to left rotate an array by d positions.

I am Soham Sarkar and I've worked on issue no #7 .

@Sohoxic Thanks for the contribution but as you can see this repo has programs only in Java so if you could change your C++ code to a Java one we can make this work 😁

And also one more thing I'll tell you is that is a really good practice in Open Source, always raise PRs from a different branch rather than the main one as it can cause complications

@ShivangShandilya  Okayyy, thanks alot for the insights, will try to make the necessary changes.

@ShivangShandilya I have changed the code to java as per your instructions. I have very little knowledge in java so I took the help of ai to convert my c++ code to java and tried running it on my system. It runs just fine. Also I'll try to make changes in a new branch from next time before creating a PR. Thanks alot

Cool Looks good to me. Let's merge it 😁


Line item detail

Changes
Splits the path from the filename into separate lines
Why Are Changes Being Made
It's way easier to read when the paths are super long.

Codecov Report

Merging #35 (d8e2cb1) into master (81e5b2a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   42.59%   42.59%
=======================================
  Files           5        5
  Lines         162      162
=======================================
  Hits           69       69
  Misses         74       74
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e5b2a...d8e2cb1. Read the comment docs.


Applyformats

New features:

new mp_applyformats() macro to apply a set of formats to 1 or more tables
new test in mp_validatecol to confirm whether a provided format is syntactically valid

:tada: This PR is included in version 3.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


RFC: Development mode validation of Graphcache resolver configuration against schema

Summary
I've just spent two days trying all sorts of things to debug why my pagination wasn't working. The good news is, I now have an intimate understanding of the Urql relayPagination inner workings and its test
(and I see some robustness changes in the tests I'd be happy to make separately)

Cursor nullability
The test seem to indicate that there's a relationship between hasNextPage being false and endCursor being null as well as hasPreviousPage being false and startCursor being null. However, this is incorrect. The Relay cursor specification states

startCursor and endCursor must be the cursors corresponding to the first and last nodes in edges, respectively.

I believe the tests should be updated to reflect the above condition. The cursors in pageInfo should only ever be null when there are no edges. (The spec currently says cursors should be a non-nullable type, contradicting even that, but that's being worked on)
Subset test confusion
The test returns a subset of the cached items if the query requests less items than the cached ones does not do what it states on the tin. Its implementation actually tests that the entire cache is returned when a smaller subset is requested.
The naming of this test is somewhat confusing. The name of the test may do what you expect but the behaviour of the test matches that of the documentation (and behaviour desirable for pagination).

I hope we can use the data that urql has available for itself to save another developer that same time.
Proposed Solution
Would it be possible to validate the resolvers configuration of the Graphcache schema against the schema that is loaded for schema awareness when Urql is used in development mode?
Requirements
When schema awareness is set-up the Graphcache should check the keys for the resolvers entry of its configuration and

Check that all defined types exist, provide a warning if that's not the case
Check that all used types are concrete types. Graphcache currently doesn't apply a resolver for an interface to all its implementing types, so the user should get a warning saying something like Graphcache does not support resolvers for interface types. Please move the resolver for 'Interface' to the concrete types 'SomeImplementsInterface', 'OtherImplementsInterface'.

So, all of these validations do exist: https://github.com/FormidableLabs/urql/blob/0b2c8db694dd5541d47c033108d8bd975e699e38/exchanges/graphcache/src/store/store.ts#L94-L102
Could it be that you'd maybe want to submit a bug ticket if they're slightly inaccurate at times?

So, all of these validations do exist: https://github.com/FormidableLabs/urql/blob/0b2c8db694dd5541d47c033108d8bd975e699e38/exchanges/graphcache/src/store/store.ts#L94-L102
Could it be that you'd maybe want to submit a bug ticket if they're slightly inaccurate at times?

Ah I thought they were missing for my scenarios since I hadn't seen any on the console.
It's indeed true that "1. Check that all defined types exist, provide a warning if that's not the case" is covered by https://github.com/FormidableLabs/urql/blob/0b2c8db694dd5541d47c033108d8bd975e699e38/exchanges/graphcache/src/ast/schemaPredicates.ts#L202
However, the scenario I ran into is that I defined a resolver for an interface. However, resolvers for interface types (from my current experience) are never actually used since the __typename that the cache will receive to match against the resolvers configuration must be a concrete type.
I'd like to propose replacing https://github.com/FormidableLabs/urql/blob/0b2c8db694dd5541d47c033108d8bd975e699e38/exchanges/graphcache/src/ast/schemaPredicates.ts#L204 with the following
} else if (schema.types[key].kind === "INTERFACE" || schema.types[key].kind === "UNION") {
  warnAboutAbstractResolver(key);
} else {

Where warnAboutAbstractResolver is implemented as
function warnAboutAbstractResolver(name: string, kind: 'UNION' | 'INTERFACE'): void {
  warn(
    `Invalid resolver type: \`${name}\` does not match to a concrete type in the schema, but the \`resolvers\` option is referencing it. Implement the resolver for the types that ${kind === 'UNION' ? 'make up the union' : 'implement the interface'} instead.`,
    26
  );
}

This would help catch the scenario that I ran into sooner and provides a message on how to resolve this issue.

Ah I thought they were missing for my scenarios since I hadn't seen any on the console.
It's indeed true that "1. Check that all defined types exist, provide a warning if that's not the case" is covered by https://github.com/FormidableLabs/urql/blob/0b2c8db694dd5541d47c033108d8bd975e699e38/exchanges/graphcache/src/ast/schemaPredicates.ts#L202
However, the scenario I ran into is that I defined a resolver for an interface. However, resolvers for interface types (from my current experience) are never actually used since the __typename that the cache will receive to match against the resolvers configuration must be a concrete type.
I'd like to propose replacing https://github.com/FormidableLabs/urql/blob/0b2c8db694dd5541d47c033108d8bd975e699e38/exchanges/graphcache/src/ast/schemaPredicates.ts#L204 with the following
} else if (schema.types[key].kind === "INTERFACE" || schema.types[key].kind === "UNION") {
  warnAboutAbstractResolver(key);
} else {

Where warnAboutAbstractResolver is implemented as
function warnAboutAbstractResolver(name: string, kind: 'UNION' | 'INTERFACE'): void {
  warn(
    `Invalid resolver type: \`${name}\` does not match to a concrete type in the schema, but the \`resolvers\` option is referencing it. Implement the resolver for the types that ${kind === 'UNION' ? 'make up the union' : 'implement the interface'} instead.`,
    26
  );
}

This would help catch the scenario that I ran into sooner and provides a message on how to resolve this issue.


[#105005134] Register for DOS

Completes this story: https://www.pivotaltracker.com/story/show/105005134
Further design for displaying both DOS and G-Cloud messages on the same page is forthcoming.  For now I have simply put the DOS messages above the existing G-Cloud 7 messages.
I have also changed registering interest to only happen on a POST request from the button in the "register interest" message - for G7 interest was registered with all GET requests to the framework dashboard.
Also removes the dependency on 'GCLOUD7_OPEN' is active_feature from the dashboard template - all messaging is now conditional on the status of the frameworks in the databse, not on a feature flag.
Prototype design for before registering:
http://dm-prototype.herokuapp.com/states/account?dos.framework=open&dos.application=null
Screenshot before registering:

Prototype design for after registering:
http://dm-prototype.herokuapp.com/states/account?dos.framework=open&dos.application=some
Screenshot after registering:

Depends on:

[x] https://github.com/alphagov/digitalmarketplace-api/pull/272
[x] https://github.com/alphagov/digitalmarketplace-utils/pull/190

Maybe a bigger question than this pull request, but are we doing the thing where you can register interest before it's actually open? If so I think the "start" button is confusing—it was last time when we had a link that said something like "register" but there was nothing you could do beyond it.

Good point - a question for Cath I think.  This messaging only appears if the framework is open, so at the moment it makes sense.  But if we want people to "register" in advance then this isn't the right thing.

@TheDoubleK Based on the discussion this morning it sounds like this is OK. We might want to think about having a separate "DOS is coming" message for suppliers who create accounts in advance.

There's quite a lot in here which isn't very generic, eg templates called _dos_messages, variables called g7… in the view. Do we care, or are we just trying to get this out?

I'd rather see the template look like
for framework in frameworks:
   if framework is pending:
       include generic-template-for-pending-frameworks.html
   if framework is open:
       include generic-template-for-open-frameworks.html

Based on real life discussion have decided that this is :+1: for now, and will do some work to make it less generic as part of #106103994.


Generator pass control characters ('\t', '\n', '\r', '\0') from input to playlist.

It leads to malformed m3u files.
Will try to fix it in a next few days.

Closed with https://github.com/SCP002/m3u-gen-acestream/commit/26f4ccfa496e4b06023db9882804967bb229d139


perf(crop_box_filter): performance tuning with filter() API change

Description
This PR makes crop_box_filter faster without changing the logical output. The tail latency of the crop_box_filter_self node gets about x5 faster with the introduction of the TLSF allocator (see this Autoware Discussion) and this PR merge.

Measurement Condition

Ubuntu22.04 + ROS2 Humble + Autoware Universe rosbag simulation
Core Isolated
Core Frequency Fixed (2.6GHz)
L3 Cache: 12MB

This PR contains two controversial changes.

In the future, filter(const PointCloud2ConstPtr & input, const IndicesPtr & indices, PointCloud2 & output) will be changed to filter(const PointCloud2ConstPtr & input, const IndicesPtr & indices, PointCloud2 & output, const TransformInfo & transform_info) and classes inheriting from Filter class will be changed to follow this new API.

This unaesthetic change in design is due to performance reasons, which will be explained later.
Since there are several child classes inheriting from the Filter class, and this time only the CropBoxFilter class should support the new API, a temporary faster_filter() function is prepared and used for the transition period until all child classes support the new API.

Some internal implementations in pcl_ros::transformPointCloud() are ported into the Autoware source code and we stop using this library function.

It's also for performance reasons.

The first API change is needed in order to defer the coordinate transformation of the point clouds. If a point cloud is transformed into its coordinate in the Filter parent class before passing to a child class, it's inevitable to consume one more buffer, leading to one more copy and extra memory space. Therefore, I'd like to change the design so that only the transformation matrix of the coordinates is passed to the child class, and the transformation is applied e.g. just before a point in the input point cloud is referenced.
The ported part from pcl_ros::transformPointCloud() is where a matrix of the coordinate transformation is calculated.
The faster_filter() API will be removed in the following steps.

The implementations of all the child classes conform to the new API faster_filter(const PointCloud2ConstPtr & input, const IndicesPtr & indices, PointCloud2 & output, const TransformInfo & transform_info)
Remove faster_filter() API (= renamed to filter())

Related links

Introduction of a library for the replacement of heap allocation in Autoware (Autoware Discussion)
Background, Implementation Detail and Performance Analysis (TIER Ⅳ INTERNAL LINK)

Tests performed

Check if crop_box_filter_self publishes the same logical output as before (using Autoware Universe rosbag simulation)
Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@sykwer How can I test this PR with TLSF allocator?

@miursh
Could you please follow the instruction on the README (https://github.com/tier4/heaphook)?

I checked the processing time.

proc time [ms]
before
after (native)
after (TLSF)

average
21.70
11.74
11.13

max
46.00
30.00
31.00

std.dev
6.99
5.81
5.37


Try to fix getblock endpoint

This PR is a first attempt to fix the broken getBlock endpoint in the moonbeam node

@tgmichel This is me removing the part you suggested. I also have a moonbeam branch that uses this code. It does not seem to solve the problem.

This was addressed in #12


Caching  for Haskell projects

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
I'm trying to get caching working for Haskell projects.
Using the same basic haskell/servant project as #312  time I run
NIXPACKS_INSTALL_CACHE_DIRS=/root/.stack NIXPACKS_BUILD_CACHE_DIRS=/app/.stack-work nixpacks build --env NIXPACKS_INSTALL_CACHE_DIRS NIXPACKS_BUILD_CACHE_DIRS -o ../rw-out .

This gives me the following Dockerfile
FROM ghcr.io/railwayapp/nixpacks:debian-1657820962

WORKDIR /app/

# Setup
COPY environment.nix /app/
RUN nix-env -if environment.nix
RUN apt-get update && apt-get install -y libgmp-dev gcc binutils make zlib1g-dev

# Load environment variables
ARG NIXPACKS_BUILD_CACHE_DIRS NIXPACKS_INSTALL_CACHE_DIRS
ENV NIXPACKS_BUILD_CACHE_DIRS=$NIXPACKS_BUILD_CACHE_DIRS NIXPACKS_INSTALL_CACHE_DIRS=$NIXPACKS_INSTALL_CACHE_DIRS

# Install
COPY . /app/
RUN --mount=type=cache,id=zUXEhU0xtPA-/root/.stack,target=/root/.stack stack setup

# Build

RUN --mount=type=cache,id=zUXEhU0xtPA-/app/.stack-work,target=/app/.stack-work stack build

# Start
COPY . /app/
CMD stack exec railway-exe

This works building locally, but the cache doesn't appear to make any speed up (ghc is still downloaded and all library dependencies are rebuilt).
I think the haskell might work better if it did stack install and then called the executable from /root/local/bin (I think).
Or even better - use a two stage build and just copy the executable to the (much smaller) image that's pushed.
To reproduce
Use the command above to build a local docker file
Expected behavior
Caching should work
Environment
ubuntu
❯ nixpacks --version
nixpacks 0.2.4

OK, looks like I've cracked it:
NIXPACKS_BUILD_CACHE_DIRS:   /root/.stack,/app/.stack-work
NIXPACKS_BUILD_CMD:          stack install
NIXPACKS_INSTALL_CACHE_DIRS: /root/.stack
NIXPACKS_START_CMD:          /root/.local/bin/railway-exe

Key changes:
Cache the /root/.stack and /app/.stack-work directories
Change build to stack install (I think this should be the default behaviour)
Change the run command to /root/.local/bin/<exe-name> the $(head packageYaml.executables) trick should work here to set the default.
Optional improvements:
Multi stage build that just copies the /root/.local/bin directory to the image that's published.

Incredible! I can make that change today (unless you want to take it on). Thanks for doing the hard work and figuring this out.

Feel free - I'm not a rust native just yet I'm afraid 😁
On Fri, 15 Jul 2022, 17:45 Jake Runzer, @.***> wrote:

Incredible! I can make that change today (unless you want to take it on).
Thanks for doing the hard work and figuring this out.
—
Reply to this email directly, view it on GitHub
https://github.com/railwayapp/nixpacks/issues/318#issuecomment-1185718597,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAVNVCAZ4AJUNKO2XLEOUTVUGISLANCNFSM53U32U6Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

actually contributing for this is relatively straightforward. You can take a look at src/providers/haskell.rs 😃


Fix unexpected changes in HTML attachment slugs

HTML publication slugs change unexpectedly given the following scenario:

Create a new edition of a published document and alter the HTML attachment title
Publish the document, at this point the HTML attachment slug is still correct
Create another new edition, when this edition is created the attachment slug changes to one based on the edited title.

Because the slug comes from an extended class it is not included when running dup. Whenever a new edition with an HTML attachment is created, because the slug is nil, a new one is generated based on the title. If the attachment title changed then subsequent editions would have different slugs.

Demonstrate this with two failing tests
Explicitly copy the slug when deep cloning the attachment so a new one isn't generated and the slug doesn't unexpectedly change.

"When using dup, any modules that the object has been extended with will not be copied."
http://ruby-doc.org/core-2.1.6/Object.html#method-i-dup

https://trello.com/c/Y2rdmCTE/132-changing-the-title-of-an-html-pub-changes-the-slug-but-doesn-t-automatically-create-a-redirect-medium

:boom: :+1:

:fireworks:


Validation issues: invalid event not fired, validity and validationMessage not available

I'm trying to use client side validation with vaadin-text-field.
When calling .checkValidity() the state is reported correctly (true/false), but both .validity and .validationMessage are not available on vaadin-text-field even though they are correctly set on the native input element.
Also the "invalid" event is not fired.
It would be nice if these methods would be exposed on vaadin-text-field according to the spec:
https://developer.mozilla.org/en-US/docs/Web/API/Constraint_validation

Also a reportValidity() would be great to be able to validate and show validation messages programmtically.


Purging mosquitto removed tedge

Describe the bug

If we run sudo tedge apt purge mosquitto tedge, tedge_mapper, tedge_agent, tedge_logfile_request are also removed:
To Reproduce

run sudo apt purge mosquitto
Expected behavior

This should not remove tedge.
Screenshots

Environment (please complete the following information):

OS [incl. version]
Hardware [incl. revision]
System-Architecture [e.g. result of "uname -a"]
thin-edge.io version [e.g. 0.1.0]

Additional context

Because tedge package has dependency on mosquitto. Without mosquitto, tedge won't work. For me, it's desired behaviour.

Why would it be desired behaviour?

I want to know why you will be happy if the removal of the dependency on mosquitto from tedge package.
From my point of view, the current dependency helps users

Installing tedge invokes the installation of mosquitto automatically.
As of now, tedge connect/disconnect doesn't work without mosuqitto.

However, tedge connect and disconnect still use mosquitto.

This is always assuming I'm using tedge cli, I needed to purge my mosquitto configuration because of the broken state, but because of that dependency also my entire tedge installation has been purged without a warning.
I would expect that on my device I can have things installed in any order I prefer and the most important by uninstalling a package for whatever reason another one is not being removed.

Okay, it seems more troubles than benefits, so I'm now fine to remove the dependency.
Actually our get-thin-edge_io.sh script installs mosquitto explicitly. Also our installation guide mentioned the step to install mosquitto as well. Also, the test workflow has the step to install mosquitto.
So, we just remove the dependency without changing other script or docs.

Investigate to find a solution to keep a soft dependency by debian package management
If we can't find a good solution, remove the dependency on mosquitto from tedge.


Lowercase and remove periods in error messages for consistency

r? @ehuss
(rust_highfive has picked a reviewer for you, use r? to override)

Will this cause rustc tests to fail?

I ran:
fgrep 'Could not document' -r src/test

and nothing came up, so I assume that there are no rustc tests that would be affected.

It looks like there are a few more error messages that start with an uppercase letter and/or end with a period:

E.g.:
$ grep '"Could not .*"' -r src
src/cargo/util/important_paths.rs:        anyhow::bail!("Could not find `{}` in `{}`", file, pwd.display())
src/cargo/util/process_builder.rs:                return Err(process_error("Could not set Ctrl-C handler.", None, None).into());
src/cargo/ops/cargo_read_manifest.rs:                "Could not find Cargo.toml in `{}`",

Looks like there are some tests that need to be updated.
If you want to update those other error messages, that would be fine, up to you!

Is there any equivalent of ./x.py test --bless that I can use here?

What should I do about this message?
https://github.com/rust-lang/cargo/blob/99134aee3911e7aafeeb645a9d47a7d2e984e2eb/src/cargo/core/workspace.rs#L155-L158

It looks like there are a ton of error messages that need to be updated (around 40, by my estimate), so it might not be worth it for now ;)
I think I'll stick with only updating the overall "could not document" messages.

Is there any equivalent of ./x.py test --bless that I can use here?

Unfortunately there is not.

What should I do about this message?

The message is probably OK, I believe it is only for library users anyways.

I think I'll stick with only updating the overall "could not document" messages.

That's totally fine!

CI should hopefully pass now!

Okay, all tests are updated and CI is passing!

Thanks!
@bors r+

:pushpin: Commit a9424d978a966b5141c46a47998ac0a7cc0bd6ae has been approved by ehuss

Hmm, I wonder why bors isn't testing. There aren't any PRs ahead of this one in the queue:

@bors r+

:pushpin: Commit 82c834cec257cd04785b5bd7d40e29e8dd35b38b has been approved by ehuss

:hourglass: Testing commit 82c834cec257cd04785b5bd7d40e29e8dd35b38b with merge 875e0123259b0b6299903fe4aea0a12ecde9324f...

Now it's working! Thanks :)

Yea, I think the bot was recently restarted, and it sometimes gets confused when that happens.

bors has been a bit sluggish recently on other things too.

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 875e0123259b0b6299903fe4aea0a12ecde9324f to master...


[MM-45789] Don't update redux state unless something has actually changed

Summary
We are currently unable to open the profile popover from the Channel member RHS list because opening the popover triggers a request to fetch channel member information which causes the RHS list to re-render and close the popover immediately.
I tried to refactor the RHS list like Caleb suggested in the ticket and I moved the selector for the member information into the child component (Member). This solved the render issue but it meant that we couldn't order/sort the list correctly and I was unable to work around that without having the channel member info present in the parent components. From what I can tell, the selectors are functioning correctly and memoizing the components didn't impact the outcome.
I decided to make this change in the reducer, this means that when we open the popover we will only update the member information if something has changed. We use this approach for posts as well in order to cut down on re-renders. This means that the only edge case for the popover not opening will be if I have the RHS open in my app, someone else changes something about that members info (i.e change their channel role), and then I click their profile to open the popover. This isn't the ideal solution but it's good enough for now.
Refactoring the RHS list is a much bigger task that would likely involve server and possibly redux tree changes.
Ticket Link
https://mattermost.atlassian.net/browse/MM-45789
Related Pull Requests

Has server changes (please link here)
Has mobile changes (please link here)

Screenshots

Release Note

Fixed a bug that wouldn't allow the user to open the profile popover from the RHS channel member list

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/261210


commenting out promise handler to test timeouts

This will be a draft PR; I expect to close/delete it without merging.

Same timeout as the other.  I'd wanted to rule out that the promise handler might be the culprit.


Add checkbox color

Add color property to checkbox, for easier working with dark/gray backgrounds. Working example in the checkbox.py

@kived Forgot about pep8. Repaired :)

Thanks a bunch. :+1:


When there is no index, get_actions should not return an empty array

If nodeos --filter-on did not match an account's actions or it does not contain a complete index of all actions for an account, this API should indicate this somehow.  An error condition is probably a reasonable way to do that.
Currently it returns an empty array which can be incorrect and mis-leading (apps may assume there are no actions).  Additionally, this will help clear up frequent confusion encountered by new developers wanting to be smart about RAM, often the first place they turn is to get_actions..
Related: https://github.com/EOSIO/eosjs/issues/294

Agreed.
A clearly response to front end developers is a good idea.

Example output from nodeos with the above branch:
2018-08-22T00:51:33.500 thread-0   producer_plugin.cpp:1295      produce_block        ] Produced block 00001ada5bf8e929... #6874 @ 2018-08-22T00:51:33.500 signed by eosio [trxs: 0, lib: 6873, confirmed: 0]
2018-08-22T00:51:34.014 thread-0   producer_plugin.cpp:1295      produce_block        ] Produced block 00001adb666da452... #6875 @ 2018-08-22T00:51:34.000 signed by eosio [trxs: 0, lib: 6874, confirmed: 0]
2018-08-22T00:51:34.500 thread-0   producer_plugin.cpp:1295      produce_block        ] Produced block 00001adcb4d36b60... #6876 @ 2018-08-22T00:51:34.500 signed by eosio [trxs: 0, lib: 6875, confirmed: 0]
2018-08-22T00:51:34.950 thread-0   history_plugin.cpp:371        get_actions          ] params: {"account_name":"t","pos":-1,"offset":1}
2018-08-22T00:51:34.950 thread-0   history_plugin.cpp:383        get_actions          ] pos: -1
2018-08-22T00:51:34.950 thread-0   history_plugin.cpp:407        get_actions          ] start: 268435455 end: 268435456
2018-08-22T00:51:34.951 thread-0   http_plugin.cpp:472           handle_exception     ] FC Exception encountered while processing history.get_actions
2018-08-22T00:51:34.951 thread-0   http_plugin.cpp:473           handle_exception     ] Exception Details: 3050010 no_actions_found: No actions found
No actions found for account {account}
    {"account":"t"}
    thread-0  history_plugin.cpp:438 get_actions
2018-08-22T00:51:35.000 thread-0   producer_plugin.cpp:1295      produce_block        ] Produced block 00001add3224d9bc... #6877 @ 2018-08-22T00:51:35.000 signed by eosio [trxs: 0, lib: 6876, confirmed: 0]
2018-08-22T00:51:35.576 thread-0   producer_plugin.cpp:1295      produce_block        ] Produced block 00001ade3ffd4765... #6878 @ 2018-08-22T00:51:35.500 signed by eosio [trxs: 0, lib: 6877, confirmed: 0]

Example output from cleos:
[vagrant@localhost eos] $ cleos get actions abcdef123
Error 3050010: No actions found

I'm not seeing a lack of actions found as an exceptional case.  There may, in fact, be no actions for a given account.  There is no way at all to distinguish that case from the case where a filter-on/filter-out combination that should show actions for a given account doesn't because the chain has not been replayed.  The history plugin can not know what it doesn't know.
The commits on the referenced fork make no attempt to validate the filters, in any case.  [] is functionally indistinguishable from Error 3050010: No actions found in that fork.
Throwing an error if there are no actions and there is an existing filter combination that would prevent matching actions from being recorded seems like a very useful thing to have, and actually possible.  Throwing an error if there are no actions and there is no filter combination preventing matching actions from being recorded is wrong.  No actions found is a legitimate response.


Add links to all roles to worldwide organisation content item

https://trello.com/c/54I3mDxr
People linked to a worldwide organisation may have multiple roles, some of which are related to other organsaitions. Currently, we are incorrectly displaying these roles on the world wide organisation pages.
This copies the approach taken in alphagov/collections#1719. We link to all roles from the worldwide organisation, then filter out the incorrect ones in the rendering app.
See also alphagov/whitehall#8162 and alphagov/government-frontend#2906.

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.

I've approved the general approach. It's similar to how we solved the multiple roles on the Ministers page, too.
I noticed that usually links include ordered_roles. Did you consider ordering these roles? (Not saying there are any obvious criteria by which to order, only to consider whether it makes sense in this context or not.)

Thank you!
I don't think there is any order needed here tbh, they are just being published in whatever the default order is.


Implement according to Storage API

Overview
An established way for tableschema storage integrations is writing a driver based on Storage API - https://github.com/frictionlessdata/tableschema-py#storage
Examples:

https://github.com/frictionlessdata/jsontableschema-sql-py
https://github.com/frictionlessdata/jsontableschema-bigquery-py
https://github.com/frictionlessdata/jsontableschema-pandas-py

The main responsibility of the Elasticsearch driver is encapsulate Table Schema to Elasticsearch type mappings and implement Storage API (common operations like read and write to work with storage).
Contributing notes:

OKI coding standards

Plan

[ ] feel free to write to @roll, @akariv, https://gitter.im/frictionlessdata/chat and this issue thread for any questions, ideas and anything
[ ] preferably sync with @akariv about already existent code - #2
[x] bootstrap this repository based on one of OKI examples (SQL/BigQuery/Pandas drivers or https://github.com/okfn/oki-py)
[x] implement Storage API skeleton based on SQL/BigQuery/Pandas examples
[ ] implement type mappings based on SQL/BigQuery/Pandas examples
[ ] integrate mappings into Storage API
[ ] write high-level tests to ensure the driver works as expected

@pwalsh
will do

@roll looks like @akariv has done much of this. Can you do a review over the next week or so and highlight anything we need to fix for a first release

@pwalsh
will do

@brew is now working on this.

@pwalsh:
As you say, @akariv has already done the bulk of the implementation as far as creating and writing tableschema data to elasticsearch is concerned. I've created some issues (#3, #5, #6) and a PR (#4), to detail what's left to implement, and started to flesh out the storage.describe() method in this branch. Either someone else can pick this up, or I can continue when I return from holiday.

thanks @brew !


Can't create a new task with a non-admin user

I'm just setup docker on Windows10. Restart.
run in windows powershel these commands:
docker-compose build
docker-compose up -d
Open localhost:8080, register and press button "Create New Task

".
After filling fields in Task Configuration I cant't do anything - button "Submit" didn't take any effect (I only see big red licence text).
2019-03-07_084030_cr

@VesninEN , OK. I will mark the issue as a bug. Too many users complain. But the problem here is only bad error handling. Indeed your user doesn't have permissions to create a task. To do that you need to go to "admin" panel and add necessary permissions to the new user (e.g. assign "user" group/role). Read here how to create the superuser: https://github.com/opencv/cvat#create-superuser-account

I think this issue has been resolved.
Just tried it on develop - a311648 and got the following.

Not the prettiest error, but it's better than the license text and explains what the issue is.

@Vafilor , I agree. Let's close the issue. Thanks for the notice.

@VesninEN , OK. I will mark the issue as a bug. Too many users complain. But the problem here is only bad error handling. Indeed your user doesn't have permissions to create a task. To do that you need to go to "admin" panel and add necessary permissions to the new user (e.g. assign "user" group/role). Read here how to create the superuser: https://github.com/opencv/cvat#create-superuser-account


Introduce some integration tests for the template

Currently there is a GitHub action that will hydrate two test projects (one uses the default responses to the questions, the other provides some non-default responses)
However, those tests were introduced before the template allowed the user to make branching choices (i.e. black vs. pylint) that result in different files or file content.
It would be nice to be able to confirm via something like integration or unit tests that the various responses result in a hydrated test projects that contain the correct files or file contents.

Related to #190


Fixes SPM error

Fixes #1

Also made all necessary classes (and structs) public so we can actually use this lib

All these changes are now part of master. Sorry for your trouble!


Supreme Leader SnokeDetector: Blacklist dont\smerge\sthis\sis\sa\stest

Supreme Leader SnokeDetector requests the blacklist of the following keyword(s):

dont\smerge\sthis\sis\sa\stest - MS search

dont\smerge\sthis\sis\sa\stest has been seen in 0 true positives, 0 false positives, and 0 NAAs.


Change dev clue command to use a chatbox panel

Using a chatbox panel allows for pasting text and loading clues that are too long. In case anyone tries to use it the old way, text will also be kept if entered in the chatbox as command arguments.

@Cyborger1 Do you mind rebasing this PR, the test file already has this mock/bind now so you just need to drop that and merge upstream into this. I'd like to add this to NFC's TODO pile so I don't have to keep cherry-picking it into my branches 😁

@Felanbird done

Not sure why the build is failing though, did I do something wrong?


Can't create an estimate from a query

In V1: We used to be able to select all the work items from a custom query, right click, and create an estimate session from the context menu "Estimate Work Item(s)" option. That option no longer appears in the context menu. We can still do this from the backlog, but it was very handy to be able to create the session from a query.

@cschleiden Hi there, thanks for looking into this!  I see that there was an update to the extension to address this, but I'm still not seeing the "Estimate" option from a query unless I use the Estimate 2 preview.
I checked the version of my extension with this API call: https://docs.microsoft.com/en-us/rest/api/azure/devops/extensionmanagement/installed extensions/list?view=azure-devops-rest-5.0
It showed v 2.0.7, and it listed "ms.vss-work-web.query-result-work-item-menu" in the ""ms-devlabs.estimate.estimate-context-menu-action" targets, but that wasn't listed in the "ms-devlabs.estimate.Estimate.WorkItems" section.
I would like to be able to use it in the non preview version.  Is that possible?  Thanks again!


LoRa improvements

Got rid of counter API as it is found to be not fit for upcoming LoRaWAN support.
Marked LoRa support as Experimental

This PR is a spinoff from #23664
Signed-off-by: Manivannan Sadhasivam<EMAIL_ADDRESS>

Thanks for pulling this out of the LoRaWAN PR, it's going the be helpful for https://github.com/zephyrproject-rtos/zephyr/pull/24616. Would it make sense to split the RTC code into a separate source file right away since you're rewriting most of it anyway? Saves me from doing it later. :)
I verified the assumptions in the new implementation against the documentation and one of the other board implementations in LoRaMAC-Node and it looks good to me.

@andysan would you mind approving if you are happy with this?

CC @KwonTae-young

Can someone comment on the minimum resources required to run this stack on zephyr?  Would the stm32l04 mcu inside the Murata lora module be able to run the lora stack on zephyr?  I am considering to build a new LoRaWAN firmware stack for the Arduino MKR WAN 1310 that runs on the Murata module.  The module currently runs a version of the Semtech AT Slave application.  However, Arduino has not updated it with the more recent 4.4.2 firmware releases from Semtech so it is terribly out of date and lacks support for time synchronization and fuota.

@mniestroj can you please take another look?