Duplicating assigned attributes

Consider the following factory:
const User = require('models/user');

factory.define('user', User, {
  username: factory.sequence(n => `sherlock_${n}`),
  name: "Sherlock Holmes",
  password: "Password",
  passwordConfirmation: function() { return this.password; }
});

I'd expect the following to pass.
factory.build('user', { password: 'secret' })
  .then(user => expect(user.passwordConfirmation).to.equal('secret');

The syntax could differ but I think it's common use case to duplicate (or do something else) on an already assigned attribute.

Hi @jonatanklosko,
You can try following to achieve the same effect:
Factory.define('user', User, {
  username: Factory.sequence(n => `sherlock_${n}`),
  name: 'Sherlock Holmes',
  password: 'password',
  passwordConfirmation: undefined,
}, {
  afterBuild: model => {
    model.passwordConfirmation = model.password;
    return model;
  },
});

Hey @chetanism,
I've already tried this and actually it should be
afterBuild: model => {
  model.passwordConfirmation = model.passwordConfirmation || model.password;
  return model;
},

The problem with this solution is that afterBuild is not invoked when you use create.
I can think of a feature, that would allow us to do:
/* ... */
password: "secret",
passwordConfirmation: factory.duplicate('password')
/* ... */

/* Or even more flexible */

/* ... */
password: "secret",
passwordConfirmation: factory.after('password', password => /* do something and return */)
/* ... */

This way you can evaluate all normal attributes and those duplicate/after calls at the end.
What are your thoughts =) ?

@chetanism I think maybe we should consider calling both afterBuild and afterCreate when creating. I think this makes sense because create does follow build.

@jonatanklosko, sorry for a long delay!
I have raised #73 as per @aexmachina 's suggestion. The afterBuild callback should now be invoked on create calls as well (once the PR gets merged :)).

Yeah this behavior makes more sense. The PR looks great, thanks! =)

#73 has been merged, closing this issue now. Please advise if there's any issues.

I've just realised that it's not invoked after #attrs as well.

Hi @jonatanklosko, the order of execution for these methods is attrs -> build -> create. As of now, we just have callbacks for afterBuild and afterCreate, hence the callbacks are not executed for attrs call. I'll open another issue to have an afterAttrs callback.


Pagination items on start not equal to on end

Laravel Version: 5.6.#
PHP Version: 7.1.13
Database Driver & Version:

Description:
UrlWindow::getSliderTooCloseToBeginning()
needs +1 offset

'first' => $this->paginator->getUrlRange(1, 1+ ($window + 2)),

Steps To Reproduce:
Paginate big result and count items at 1st page and at last page.

Please resubmit with proper description of the issue and share more details on how to replicate. The issue is very vague.

Seems it's related issue: #20699


150296 [Geo] [en de jp sg es br pt uk es it][Newsroom] Common Modules - Hero-For all geos read more text first word letter should be capital instead of all as per legacy

Priority : 3 - Medium
Steps to Reproduce: | Analysis & Proposed Solution: | Location of the Element:
1.Open both URL
https://newsroom.accenture.de/
https://main--accenture-newsroom-de--hlxsites.hlx.live/
and also for all other geos too open both url legacy and franklin
2.On the hero section check the read more CTA
Actual: Only First letter of the word is capital on legacy but on franklin whole cta text made as capital.
Expected: Text should be make same as legacy for all the geos for read more
legacy

franklin

Note: This is happening for all the geos make sure the caps is used as per the legacy.

[ ] Code Build
[ ] Smoke Testing
[ ] Ready for PR Approval

waiting for business reply for the inconsistency across geos.


How can I manually target Image Extension in this editor

Can someone help me manually target the Image Extension in the editor? I don’t want to display the toolbar, and I want to achieve this using a custom input button instead of showing the modal. How can I target the same Image Extension functionality using my custom button?

you can reference this code https://github.com/hunghg255/reactjs-tiptap-editor/blob/main/src/extensions/Image/Image.ts
Create an extension image for yourself

I can create my own extension, but I want the same functionality as yours. Specifically, I want to target the image functionality without the toolbar, as shown in the image below. I just need it with the gallery button.

I can create my own extension, but I want the same functionality as yours. Specifically, I want to target the image functionality without the toolbar, as shown in the image below. I just need it with the gallery button.

you can add option toolbar=false to hidden extension on toolbar
https://github.com/hunghg255/reactjs-tiptap-editor/blob/c8ea494018660f151df95c7144c785c36c3c9fa5/src/types.ts#L54


⚠ Bofrost.de has degraded performance

In 6151b6f, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1773 ms

Resolved: Bofrost.de performance has improved in 0826021 after 27 minutes.


add yarn package manager

Full and short name of product
yarn
Does this product have LTS versions? What are the intervals between each LTS version?
Not 100% sure.. there seem to be 2 main versions I think:

yarn 1.x (classic)
yarn 2.x-4.x+

What is the website for the product and for its version information?

https://yarnpkg.com/
https://classic.yarnpkg.com/lang/en/

Classic Stable: v1.22.19

Node: ^4.8.0 || ^5.7.0 || ^6.2.2 || >=8.0.0

https://classic.yarnpkg.com/en/docs/install

These instructions only cover Yarn versions prior to 2.0. Those versions entered maintenance mode in January 2020 and will eventually reach their end-of-life in terms of support. Please see the main website for the most up-to-date documentation:

https://yarnpkg.com/getting-started/migration#why-should-you-migrate

https://github.com/yarnpkg/berry

https://github.com/yarnpkg/berry/releases

Additional context
N/A

Looked around a bit, and couldn't find a definitive EOL date for 1.x. Looks like 1.x is still considered maintained for critical fixes and vulnerabilities.
Thanks for raising the request.

Hi @0xdevalias, thanks for the suggestion. Yarn's page is now available at https://endoflife.date/yarn.

Amazing, thanks for that! :)

:clap:

@adriens Which CLI tool is that?

@adriens Which CLI tool is that?

@0xdevalias , that's an excellent question :smile_cat:
I use the excellent tool called eol, all details below :
😎 Get EOL from your terminal with eol


Updates to documentation

Framework updates

Cluster provisioning README with config examples of our different clusters.
Updates to documentation. Added more detail so our go docs can provide more help for our end users.

LGTM


create cluster failed

https://github.com/kubean-io/kubean/actions/runs/10774807097/job/29878011277

Starting with kubean v0.19.0, centos 7 is no longer supported. If you need support, please use the older version, or switch your spray-job image to the corresponding older release version from the following page：
https://kubean-io.github.io/kubean/en/releases/artifacts/


Undocumented features of the Num class.

There appear to be three undocumented methods in the Num class, namely truncate, fraction and toString.
truncate
Rounds the number to the nearest integer towards zero.
It is therefore equivalent to floor if the number is non-negative or ceil if it is negative.
System.print(1.5.truncate)        (1)
System.print((-3.2).truncate)    (-3)

This is a useful method and I wrote my own before I realized it already existed in the standard library.
fraction
The fractional part of a number i.e. the part after any decimal point.
The returned value has the same sign as this.
System.print(1.5.fraction)       (0.5)
System.print((-3.2).fraction     (-0.2)

Again worth knowing about so you don't have to write your own.
toString
The string representation of the number, over-riding toString inherited from the Object class.
Although you might guess that this last one exists, it's probably worth mentioning in the docs. Before I realized it worked I always used "%(num)" which is less easy to read.

Some of these are new in 0.4.0 and the docs haven't been updated just yet, but will be for the next release.

toString exists for all builtin types. Actually, "%(obj)" desugars to "" + obj.toString + "".

toString exists for all builtin types.

True and, indeed, for all types that are not built-in as everything ultimately inherits from Object.
However, there are a few built-ins which don't override the Object implementation. For example:
var f = Fiber.new { }
System.print(f) // instance of Fiber

Still on the Num class, I've noticed that some of the bitwise operators aren't documented either namely: ^, << and >>.


Source map support

Cool library! But, unfortunately seems, that it not support source maps (proper line, column).
Would be awesome to support this stuff.

Could you provide an example. If the library itself supports source maps on stack trace then trace will present those.

All fine, sorry.


[README] Update to "Open Source First" section

Updated a description of "Open Source First"
Checklist

[x] Signed commits.
[x] PR title includes [<name of area>]:<description>

Thank you, @arghac14. 👍


Translation creating multiple variations with same sku

Can you reproduce this issue on default Wordpress theme (eg Storefront)? yes
Can you reproduce this issue when all other plugins are disabled except WooCommerce, Polylang and Hyyan WooCommerce Polylang Integration? yes
What product versions and settings are you using when this issue occurs?

PHP: 7.3
WordPress: 5.3.2
WooCommerce: 3.8.1
Polylang: [state if using Polylang PRO]
Hyyan WooCommerce Polylang Integration: Version 1.4.3
Browser: Chrome

Steps to Reproduce

product with variations
create translation of product
see variations in translation

What I Expected
same number of variations
What Happened Instead
Duplicate variations in huge numbers, and more added on each save 11 variations becomes 72 then 112, 168... etc. number seems random, and not a multiple of original number of variations
WordPress Environment
Network, 3 languages enabled.

```
Copy and paste the system status report from **WooCommerce > System Status** in WordPress admin here.
```

The same here, even with meta fields locks activated... when saving original language post, variations are duplicate only on the second language :0

same here. Multiple variations, with every save on product in original language with 2 variations, new variations are created. SOme products with 2 variations in original language have up to 40 variations in translation!

Same here. I posted a more detailed message about this issue here:
https://github.com/hyyan/woo-poly-integration/issues/430

Where this could happen is if the relationship between the language, the products and the variations has changed.
For example if the shop base language has changed (not supported) or the language of the product has been changed this could introduce problems.  In these situations the products could have child variations which are not in the expected language (or are linked to variation attributes which are in the wrong language) and so can never be translated properly.
There was a fix on #430 related to the translated variations never being enabled, therefore when the code looked for the translations they could not be found and so were translated again.
You should find that for new products this should be working correctly.

Same here, though the fix on #430 seems to prevent it from happening again.
Would there be a way of deleting unused or obsolete variations?

Well yes this can be done in the database, though I'm not sure of a one-size-fits all solution at the moment.
Variations are posts of type product_variation in the posts table with post_parent being the parent product.
The old way the plugin worked for variations was via a post_meta called  _point_to_variation which I believe is still there in the code.  Using this one could find all the posts which share the same _point_to_variation and delete them.  Since you only have two languages you could keep the highest post_id for each _point_to_variation and delete the others.  I'd do this as a select query and checking it thoroughly before turning it to a delete...
Variations should now have a language since code checked in a couple of years ago on #348: some may not though if not edited since then, the backfill sql on this code was not incorporated to run automatically. This would then allow the code or sql to do more checks for example run a query to find variations which are assigned a language which is different from the parent product language and delete them. code for the taxonomy queries is also on on #348
Ultimately some more defensive code should be added, including disabling the ability to change the language of an existing product as this is fairly fatal to any existing translation links - if someone changed a product from English to French but is already linked to a French product, behaviour is undefinable, and worse if the product has variations.

Hi, it's me again 😄 Just dropping by because I've been figuring out some issues with duplicated variations and it seems that in my case they were being caused by WooCommerce storing funny values in transients.
I added some logging to WC_Product_Variable_Data_Store_CPT->read_children, especifically something like this:
error_log("$children_transient_name: " . convert_multi_array($children));
error_log($wpdb->last_query);
So, I have a product with 77662 with four variations (two colous and two sizes) all of which should be translated. The same product in the secondary language has ID 73923. With this in mind, consider what happens whenever I update product 77662:
[05-Jul-2020 16:34:06 UTC] wc_product_children_77662: 80538, 80542, 80546, 80550
[05-Jul-2020 16:34:06 UTC] SELECT wp_posts.ID FROM wp_posts  WHERE 1=1 AND wp_posts.post_parent = 77662  ...
[05-Jul-2020 16:34:18 UTC] wc_product_children_73923: 80538, 80542, 80546, 80550
[05-Jul-2020 16:34:18 UTC] SELECT wp_posts.ID FROM wp_posts  WHERE 1=1 AND wp_posts.post_parent = 77662  ...
As you can see, the key does not match with the queries post_parent, thus storing a wrong value in the transients which causes a series of issues like posts not displaying variations and the aforementioned duplication.
I fixed this by hacking that class, forcing the parameter bypassing cache to true. If you have any idea of a longer term fix or any clue of what might be happening, I would forever be beholden to you.
Thanks in advance!

Hi Ramonacus,
thanks for your workaround. I have the same problem but I cannot find any solutions. So I tried to fix the class class-wc-product-variable-data-store-cpt.php from  read_children( &$product, $force_read = false ) to  read_children( &$product, $force_read = true ) as you have written, but the problem is not gone.
Is there anything else to change?
Thanks in advance,
Chris

Hi Ramonacus,
thanks for your workaround. I have the same problem but I cannot find any solutions. So I tried to fix the class class-wc-product-variable-data-store-cpt.php from  read_children( &$product, $force_read = false ) to  read_children( &$product, $force_read = true ) as you have written, but the problem is not gone.
Is there anything else to change?
Thanks in advance,
Chris

Is there anything else to change?

Aye, there is. Sorry I wasn't clear in my explanation.
This hack prevents the issue from happening again, but it doesn't delete already existing duplicates. I am afraid that you will have to delete them, either directly in the database or manually via product page in the admin.

Is there anything else to change?

Aye, there is. Sorry I wasn't clear in my explanation.
This hack prevents the issue from happening again, but it doesn't delete already existing duplicates. I am afraid that you will have to delete them, either directly in the database or manually via product page in the admin.

Thanks for your fast answer. I already delete the duplicate entries directly from the product page. And I modified the class but the problem is still alive. I forgot, my system is on the latest version of woocommerce and wordpress 5.5.3 with all fixes.

Thanks for your fast answer. I already delete the duplicate entries directly from the product page. And I modified the class but the problem is still alive. I forgot, my system is on the latest version of woocommerce and wordpress 5.5.3 with all fixes.

Hi, on #430 I added a fix to delete duplicate variations if found when saving a product, so with the latest source code, the next save on any affected product would clear it for that product, please try with latest source


rename file comp functions, use std lib

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   90.35%   90.35%
=======================================
  Files           9        9
  Lines         674      674
  Branches      111      111
=======================================
  Hits          609      609
  Misses         44       44
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8449b3a...115ccbb. Read the comment docs.


mega target group v2.7.2

This effectively passes down the CIDR blocks as a flag and filters the list of targets that are returned from aws.
parse cidrs at main func
filter out epAddr in endpoint resolver
instead of reading cidrs from the flag, we can incrementally onboard new services

original implementation: https://github.com/dlmather/aws-load-balancer-controller/pull/1


Fix AIM Login Docu

I've had some fun figuring out how to use the AIM login and wanted to fix the docu for this. The contributing guide mentions a "dev" branch but I can't find one so this goes directly to "main".

Thank you for your contribution !


More rigorous validation for callable-schema

Initial Checks

[X] I have searched Google & GitHub for similar requests and couldn't find anything
[X] I have read and followed the docs and still think this feature is missing

Description
Currently the core_schema.callable_schema only checks if an input is callable, so the following works:
class A(BaseModel):
    f: Callable[[], int]

def f() -> str:
    return 1

A(f=f)  # no error

With the help of inspect.signature, we can improve callable_schema by checking the number of arguments, the annotations (if input is a function, not lambda), etc., so that the above will throw an error.
Affected Components

[X] Compatibility between releases
[X] Data validation/parsing
[ ] Data serialization - .model_dump() and .model_dump_json()
[ ] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - model_construct(), pickling, private attributes, ORM mode
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Seems like a valid feature request. Probably requires a substantial amount of work (validating, args, kwargs, positional only, paramspecs? typevartuples?)

Probably requires a substantial amount of work (validating, args, kwargs, positional only, paramspecs? typevartuples?)

Yes, there seem to be many cases considering the flexibility of signatures in Python.
Variance of types may also be relevant.

Sounds like a great improvement!


added calculator favicon

Fixes issue #47
I tried to add a calculator icon from the site, but it wasn't updating, probably because it was an SVG file. I downloaded another calculator icon in the correct ico format. Let me know if this works.

Seems good to me!


PORT env variable ignored in npm start

Line "start": "micro", in package.json should be changed to"start": "micro -l tcp://<IP_ADDRESS>:${PORT-3000}", according to micro docs

Huh! Well that's odd; I would have thought micro would respect $PORT. That's very annoying that their "solution" is Bash-shell specific.
Goes and reads through the source code of micro
Oh... I see why they ignore it. They actually support running on multiple ports and allow you to specify combinations of bind address + port and/or sockets. Fancy pants.
Alright, I think I figured out a solution...

See if v2.0.2 (to be published shortly by our friend Travis) does the trick


add/observable/throw.d.ts is empty

RxJS version:
5.4.3
Code to reproduce:
Expected behavior:
Actual behavior:
Additional information:

Checking it, only add/throw seems missing module augmentation, (https://github.com/ReactiveX/rxjs/blob/master/src/add/observable/throw.ts) not sure if this is intended or just simple miss.
/cc @david-driscoll anything you can recall?

@kwonoj I figured out it, add/throw and add/if missing module augmentaion, because if and throw are javascript keywords, and they are Observable static method. So they can't declare as follow:
import { _throw as throwStatic } from '../../observable/throw';
declare module '../../Observable' {
    namespace Observable {
        let throw: typeof throwStatic; //error
    }
}

When use it, just import 'rxjs/add/observable/throw'. And you can close  this issue.

Thanks for clarification.


[SPARK-19939] [ML] Add support for association rules in ML

What changes were proposed in this pull request?
Adding support to Association Rules in Spark ml.fpm.
Why are the changes needed?
Support is an indication of how frequently the itemset of an association rule appears in the database and suggests if the rules are generally applicable to the dateset. Refer to wiki for more details.
Does this PR introduce any user-facing change?
Yes. Associate Rules now have support measure
How was this patch tested?
existing and new unit test

Test build #124392 has started for PR 28903 at commit 1cc6560.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29011/
Test PASSed.

Test build #124392 has finished for PR 28903 at commit 1cc6560.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124392/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29017/
Test PASSed.

Test build #124399 has started for PR 28903 at commit 1cc6560.

Test build #124399 has finished for PR 28903 at commit 1cc6560.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124399/
Test PASSed.

cc @srowen @zhengruifeng

I was going to say, can't a caller just compute this if desired? but I guess freqUnion isn't exposed?
If it's a simple addition to the returned DataFrame to expose it and it isn't otherwise available, I could see it.

Does it means that the support is computed in the .mllib side but not exposed in the .ml side?

freqUnion is computed in mllib side but not exposed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29070/
Test PASSed.

Test build #124452 has started for PR 28903 at commit c80ec10.

Test build #124452 has finished for PR 28903 at commit c80ec10.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124452/
Test PASSed.

Merged to master

Thanks! @srowen @zhengruifeng


Bug: double free detected in tcache 2

When running the sample provided either multi or single bin I get the following error:
free(): double free detected in tcache 2
Aborted

Any idea where this might be coming from?
I'm using gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
This is the complete output:
-g
-p
-gxgbin
-snp
-tp
-k
-jn
-o
-annot
#SNP in bim file 100
100 SNPs in 0-th bin
 Number of selected SNPs w.r.t  annot file : 100
Number of SNPs per block : 10
200
free(): double free detected in tcache 2
./test.sh: line 7: 23677 Aborted                 ../../build/GENIE_GxG -g $gen -p $phen -gxgbin 0 -snp -1 -tp $target -k 10 -jn 10 -o small.single.results -annot $annot

NOTE: this is in branch extTarget, the main branch does work.

I submitted a pull request with a possible workaround, could you please check it is correct?
Thank you!

Hi, thank you for detecting this bug and providing the suggestion. I confirm the bug was due to the undefined behavior without "return" in the read_target function.  This issue was not displayed at GCC <= 7.5.0. I have accepted your commit request


One-encoder should (optionally) coerce Count data to Continuous

Motivated by the experiences of a user here I suggest we do this.
Instead of this:
julia> OneHotEncoder()
OneHotEncoder(features = Symbol[],
              drop_last = false,
              ordered_factor = true,)

we could have this
julia> OneHotEncoder()
OneHotEncoder(features = Symbol[],
              drop_last = false,
              ordered_factor = true,
              count = true)

Any objections?

This seems weird to me, the coercion has nothing to do with OHE?
But I don't really care much though I'd prefer if it were called  coerce_count and false by default.
Also probably this should wait until https://github.com/alan-turing-institute/ScientificTypes.jl/pull/63 is merged with the syntax  Count => Continuous.

@tlienart Yeah, on reflection, it is a bit weird. And in view of ST issue 63, kind of unnecessary.


Add Homebrew instructions

Unfortunately, that's not our policy. That page can only list installation methods that we officially support.
See #14896 for more details.


Embedding $$ inside \text makes error

This is not working.
abc \text{ abc $abc$ }
but this is working
abc \text{ abc \(abc\) }
I guess this is related to this issue.
anyway thank you for your effort to make this. I was looking for the tex app based on KaTeX because of notion-things haha

(in Display Mode)

Wow! Thank you so much for your comment!
I'll look into that and see if there's a workaround if it really was an issue with KaTeX. :)

I did in on Display Mode + f(x)

@tim-watcha The issue is fixed in the new build! YAY
Feel free to try it out!

d9990222a7631e4b98b24b8eb19911957348c6ec resolved this issue! Thank you


Request: Globbal toggle key

Hi,
Great product, I really love it, it is basically the only full terminal that allows a smooth vim experience on os x.
The only thing I miss is a toggle. When I am in certain software, I would like to quickly open up, run a command and close down.
Any plans on implementing this?
Regards,

I have been full-screening alacritty and then setting the "Reduce Motion" toggle on OSX Accessibility preferences:

This reduces makes switching to a fullscreen app a very quick fade-in animation.
Then alt-tabbing to alacritty or binding a shortcut to display/dismiss Desktop 1 achieves a similar workflow to a toggle.

#450 might be relevant to you.

Lets close this one for now. I'll put a thumbs up in #450 and if it is not there by the end, i'll request a new feature.

@zx1986 Try HotKey App

fyi for people stumbling upon this using macOS, you can also use BetterTouchTool to create a "Keyboard shortcut" to "show/hide specific Application" (Alacritty.app).
This will result in the same behaviour as the iTerm2 window toggle key.

HammerSpoon makes it easier. A working configuration is:
hs.hotkey.bind({"command", "ctrl"}, "R", function()
    hs.execute('open /Applications/Alacritty.app')
end)

Then command+ctrl+R will switch to Alacritty.

However I don't think it's possible that an Alacritty window opens over fullscreen aps in macos. (Like quake terminals), or like the iterm2 hotkey behavior.

I started with @wenlibin02 solution using hammerspoon but added the following to match the iterm2 behavior I wanted (~/.hammerspoon/init.lua):
hs.hotkey.bind({"ctrl"}, "space", function()
  local alacritty = hs.application.find('alacritty')
  if alacritty:isFrontmost() then
    alacritty:hide()
  else
    hs.application.launchOrFocus("/Applications/Alacritty.app")
  end
end)

This will pop up the Alacritty with with ctrl-space and toggle it hidden if it's already visible.
Combined with macOS SimpleFullscreen support in https://github.com/rust-windowing/winit/issues/473 this allows me to completely replace iTerm2.

OMG! The solution posed by @jdalt works PERFECTLY! And I'm psyched to be introduced to Hammerspoon as well. Mind blown right now.

Shell script to do the same on linux:
#!/bin/bash

PID=$(pgrep alacritty)
if [ -z "$PID" ]; then
        alacritty &
        exit 0
fi

WINDOWID=$(xdotool search --pid $PID)
IS_VISIBLE=true
[ -z $(xdotool search --onlyvisible --pid $PID) ] && IS_VISIBLE=false

[ $(xdotool getwindowfocus) != "$WINDOWID" ] && {
        if [ $IS_VISIBLE == true ]; then
                xdotool windowactivate $WINDOWID
        else
                xdotool windowmap $WINDOWID
        fi

        exit 0
}

xdotool windowunmap $WINDOWID

you can bind it to any key combination in gnome/kde/your_de settings

I started with @wenlibin02's solution using hammerspoon but added the following to match the iTerm2 behavior I wanted (~/.hammerspoon/init.lua):
hs.hotkey.bind({"ctrl"}, "space", function()
  local alacritty = hs.application.find('alacritty')
  if alacritty:isFrontmost() then
    alacritty:hide()
  else
    hs.application.launchOrFocus("/Applications/Alacritty.app")
  end
end)

This will pop up the Alacritty window with with ctrl-space and toggle it hidden if it's already visible. Adjust to your preferred hotkey.
Combined with macOS SimpleFullscreen support in rust-windowing/winit#473 this allows me to completely replace iTerm2.
Config in .config/alacritty/alacritty.yml:
key_bindings:
  - { key: Return,   mods: Command,         action: ToggleSimpleFullscreen }

It is a good idea to hide the window. I modified the 3rd line of the code so that it works on my machine:
       if (alacritty ~= nil and alacritty:isFrontmost()) then

This is my config to work on my Mac.
hs.hotkey.bind({"command"}, "`", function()
    local alacritty = hs.application.find('alacritty')
    local awin = alacritty:mainWindow()
    if awin and alacritty:isFrontmost() then
      alacritty:hide()
    else
      alacritty = hs.application.launchOrFocus("/Applications/Alacritty.app")
    end
  end)

If the above solutions haven't worked, try this:
hs.hotkey.bind({"option"}, "`", function()
    alacritty = hs.application.find('alacritty')
    if alacritty then
      awin = alacritty:mainWindow()
    end
    if awin and alacritty and alacritty:isFrontmost() then
      alacritty:hide()
    else
      hs.application.launchOrFocus("/Applications/Alacritty.app")
      local alacritty = hs.application.find('alacritty')
      alacritty.setFrontmost(alacritty)
      alacritty.activate(alacritty)
    end
  end
)

Main change is that sometimes your window will not be brought to the front, so it takes three "unhide" operations to finally work.

If you do not want to use hammerspoon just for this and you already use Karabiner elements you can also use the following rule:
It does not hide, it only brings to the foreground (but for me this was one less app running).
                    {
                        "manipulators": [
                            {
                                "description": "Open alacritty",
                                "from": {
                                    "key_code": "spacebar",
                                    "modifiers": {
                                        "mandatory": [
                                            "left_control",
                                            "left_command"
                                        ]
                                    }
                                },
                                "to": [
                                    {
                                        "shell_command": "open -a '/Applications/Alacritty.app'"
                                    }
                                ],
                                "type": "basic"
                            }
                        ]
                    },

Based on the gist by @programus above, I did a short write-up on how I set this up. It works great, I have ditched iTerm2 in favour of Alacritty now. If you want to set this up, check out my post here: https://world.hey.com/jonash/alacritty-drop-down-guake-quake-style-terminal-setup-on-macos-6eef7d73

for gnome-shell users:
https://extensions.gnome.org/extension/3942/toggle-alacritty/

Based on the gist by @programus above, I did a short write-up on how I set this up. It works great, I have ditched iTerm2 in favour of Alacritty now. If you want to set this up, check out my post here: https://world.hey.com/jonash/alacritty-drop-down-guake-quake-style-terminal-setup-on-macos-6eef7d73
It's basically the solution above with a minor tweak.

Great! I have a suggestion that put a link of this issue in your post, so readers can come here to find more solutions and contribute their own ideas. Furthermore, if there were better solutions  be posted here, your readers can read them too.

Done 👍

Hmmm, it looks like it should work to me. I intended it to work with just one window (my terminal), not sure what you mean by "only bringing forward one of my Safari windows".

I just created my solution based on @jdalt 's work. Now it support multiple monitors and spaces.
https://gist.github.com/programus/d3bf9c6b8f9b7648891d1f59b665b35e
Hope this can also help others who have the same requirements.

This worked great for me with a 2 monitors setup, thank you!

Now hammerspoon replaces "https://github.com/asmagill/hs._asm.undocumented.spaces" to "https://github.com/asmagill/hs._asm.spaces", Could we add a new script?
Thanks

I wrote a bash script instead of lua.
the goal is just using the simplest tools with minimal visual stutter.
https://gist.github.com/zhongjis/4b11381bce4342394e494f733a278c87

For Windows users switching over from Windows Terminal, Here's an AHK script that emulates Windows Terminals' globalSummon feature for alacritty (or really any window)
#`::
exeName := "yourProgram.exe"
exePath := "path\\to\\yourProgram.exe"

IfWinExist, ahk_exe %exeName%
{
    IfWinActive, ahk_exe %exeName%
    {
        WinHide, ahk_exe %exeName%
    }
    else
    {
        WinShow, ahk_exe %exeName%
        WinActivate, ahk_exe %exeName%
    }
}
else
{
    Run, %exePath%
}
return

For macOS users who also use Raycast, you can simply record a hotkey on the "Extensions" settings panel:


Can't render html or edit index column in laravel controller side

Summary of problem or feature request
I have index and id columns. I need to modify index column contents to become button link using index value. I need to modify it using render option in blade. Any way to do it in controller?
Code snippet of problem
I need something like this
$result = DB::select('SELECT id, a, b, c FROM my_tables');

$dt = $dataTables->make($result)
            ->addIndexColumn(
               modify to index value
            )
            ->rawColumns(['detail'])
            ->toJson();

I can do it in blade like this but I prefer to do it in controller like above.
columns: [
      {data: 'DT_RowIndex', name: 'DT_RowIndex', title: 'No.', render: function(data, type, full, meta) {
          return '' + data + '';
      }},
]

For additional info, mylink contains value from another column in same table.
System details

Operating System : Mac OS Ventura 13.6
PHP Version : 8.0
Laravel Version : 6.0
Laravel-Datatables Version : 9.21.2

Tagging for enhancement as this is currently not supported.
The workaround is via column render for now.


toxiproxy 2.6.0 (new formula)

Added to homebrew/core: https://github.com/Homebrew/homebrew-core/pull/140255


React to System.Security.Cryptography.* changes in CoreFX

https://github.com/dotnet/corefx/commit/ce0506baea623efdb74707aee0e4aa169d6f468c

https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNet.Authentication.Facebook/project.json#L17
https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNet.Authentication.Twitter/project.json#L22
https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNet.Authentication/project.json#L22 (for this one, see my previous remark: https://github.com/aspnet/Security/commit/19d026268b80ad7a2299c4366fbc717e6b7bd9eb#commitcomment-11885651)
Related to https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/212
/cc @Eilon @HaoK @Tratcher

Yes, we're expecting the AzureAD changes today.

Wilson was just updated by @tushargupta51 with the packages changes I mentioned:
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/213
Has someone been assigned to add the required changes in the different ASP.NET repositories?

@Tratcher can you own this?


pindexer: flesh out dex-explorer indexer

Describe your changes
Closes #4914.
The internal architecture of the app view tries to make use of batch processing to the extent possible, which simplifies a lot of the logic.
The price charts remain unchanged, but I collapsed the two tables into one for performance and simplicity.
I also did not implement insertion of empty candles ; if there are gaps in the events, there will be gaps in the resulting database as well.
The main addition and where I spent most of my time on this is the addition of summaries of information over arbitrary windows. The idea behind the architecture here is that any time a change to liquidity, trade count, or a candle for a directed pair happens in a block, that block then gets a "snapshot" inserted, with the current price, liquidity, volume in that block, etc. At the end of this batch, the current summary is then updated, for each window, using those timed snapshots.  And then an aggregate summary, across all pairs, is created from these summaries, for each window.
In order to price values under a common denom, assets are filtered based on having a current USDC price, backed by enough liquidity (the denom and liquidity amount are parameters to the component).
For testing, I'd recommend trying to run the app view against mainnet and testnet, and checking some sanity items like the price not seeming crazy, and matching in the summary across all windows, etc.
I think for testing we'll notice potential issues relatively quickly when dogfooding the explorer.
Checklist before requesting a review

[x] I have added guiding text to explain how a reviewer should test these changes.

[x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

indexing only

@VanishMax That should (initially, possibly permanently) be configuration data (JSON) loaded into the explorer. There can be one for testnet and one for mainnet. The trading interface needs to express opinions about the list, at minimum because it needs to choose which asset is treated as the numeraire (e.g., using USDC as asset 2), so it seems simplest to start with a list specified in config data (so that there can be one for a mainnet and one for a testnet deployment).

From there, you can query the dex_ex_pair_summary table with a particular start asset, end asset, and window, which should give you all the stats you need.


Is it possible to connect with a local git repo?

Is it possible to connect with a local git repo instead of github or gitlab? if yes, then references please

is this a possibility? @nicolaszimmer @detj @franky47 @Sanix-Darker

gitrows is based on github/gitlab API to CRUD the repository... if am not wrong... but i think it's possible to interract with a local repo, it really depends what you mean by "local" and what is the middleware that will CRUD on that "local repo !"
on gitrows, the middleware is github/gitlab apis...

Sorry for the late reply, @saru2020 Connecting it to a local git repo is currently not in the scope of gitrows. As this library relies on the rest APIs for getting the data stream, you can probably make it work by either having a local http server and API running or extending the methods to access the local repo with something like https://github.com/nodegit/nodegit


upgrade importlib-metadata

Apparently 3.9.0 has some serious packaging issues

Nah I don't think it matters for our usecase


ci: add Prometheus metric reporting

Initially, the metrics reported are:

Total number of builds started
Total number of builds that succeeded
Total number of builds that failed
Total number of builds that raised an exception
Number of attempted connections to DataKit
Number of failed attempts to connect to DataKit
Number of status updates
Number of notifications from DataKit
Number of users waiting for a resource
Time spent waiting for a resource
Time spent using a resource
Number of term evaluations
HTTP requests to web UI
HTTP responses from web UI
HTTP requests currently being handled by the web UI
Number of successful local login attempts
Number of unsuccessful local login attempts
Number of successful GitHub login attempts
Number of unsuccessful GitHub login attempts
Time to handle one web request

Closes #337


Fix bug: allow helm controller set owner reference

Proposed Changes
Allow helm controller set owner reference, when helm controller obj is deleteed , will delete helm-delete-job.
If not set owner reference, the second installation and removal will fail
Reference:
https://github.com/k3s-io/helm-controller/blob/d74a09dfcaefdd6e8bea80d5aac66e70ea4e93d3/pkg/controllers/controllers.go#L144
Types of Changes
bugfix
Verification
See linked issue
Testing
Linked Issues

https://github.com/k3s-io/k3s/issues/10051

User-Facing Change

Further Comments

In the future, PLEASE use the PR template, and create an issue to track the defect you are fixing. I'm not sure why you deleted it instead of at least filling out the proposed changes.


Added swift version to podspec

Added swift version to podspec #34

I just pushed v0.4.1 again with this change 👍


Added failing integration test

A change made since c4989f8ef45e6940222e9c4b57cd8dd8846b29a1 has broken fixing of string interpolation. Spaces are being erroneously added around - in a double quoted string. I am narrowing down the exact commit which broke this now...

Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
     private function reverseBoolean($value = null, $theSwitch = false)
     {
         if (!$theSwitch) {
-            return "{$value}-{$theSwitch}";
+            return "{$value} - {$theSwitch}";
         }

Coverage remained the same at 92.853% when pulling 46063d053e15e8967cb7f43bcd2cdc8ab73fa598 on GrahamCampbell:patch-4 into 17d66a77ea65fc2194ed8e6fab904620fc0d930a on FriendsOfPHP:master.

$ php php-cs-fixer fix test.php  -vvv --dry-run --diff
PHP CS Fixer 3.2.2-DEV by Fabien Potencier and Dariusz Ruminski
Runtime: PHP 7.4.24
Loaded config default from "/home/possum/work/PHP-CS-Fixer/.php-cs-fixer.dist.php".
Paths from configuration file have been overridden by paths provided as command arguments.
F                                                                                1 / 1 (100%)
Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error
   1) PHP-CS-Fixer/test.php (binary_operator_spaces)
      ---------- begin diff ----------
--- /home/possum/work/PHP-CS-Fixer/test.php
+++ /home/possum/work/PHP-CS-Fixer/test.php
@@ -12,4 +12,4 @@
  * with this source code in the file LICENSE.
  */

-$a = "{$value}-{$theSwitch}";
+$a = "{$value} - {$theSwitch}";

      ----------- end diff -----------

Yeh.

if you can squash your commits into one clean commit with the updated test I can add it to https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/6089 :+1:

fixed in other PR, thanks for reporting :+1:


Error parsing pov files

Describe the bug
Previously it allowed you to analyze POV files recorded with the console. I wanted to analyze some and there was no solution to analyze them.
I have already tried changing all the sources
Demo links

Steps to reproduce

Expected behavior

How often does this bug happen?
None
Log file

Environment information

Additional context

dup https://github.com/akiver/cs-demo-manager/discussions/882


content missing / weird redirects

I noticed a strange behaviour when changing the language in the url bar.
I default get redirected to /de but if i change the uri to/en no text is rendered.
Only the background gets displayed.
If i change the language to /esinstead, i get redirected to /de again.
The loading text is still getting shown, but then dissapears showing only the background or redirecting me.

default get redirected to /de but if i change the uri to/en no text is rendered.
Only the background gets displayed.

That's because /en doesn't exist the english version is on just the root domain

If i change the language to /esinstead, i get redirected to /de again.

Your GH profile tells me you're from Germany so you probably have your browser set to german, so the site will always redirect you to /de no matter what url you were on before. I experimented with it and it either had no browser based redirect or this behavior
If you change your browser language to english you will always be redirect to /


Add Account preset

Partially fixes #804

[x] Tests
[ ] Tried the feature on a public network
[ ] Documentation

I think we should include a mention and a link in the docs—maybe just in the Account section for now. When we have more, we can consider including a list in the README like we did with cairo v0. Wdyt?

I was thinking about a design for adding a Presets section under API Reference in docs, but it is tricky, because I end up either recreating the component documentation if we add the methods or adding almost anything to it. Adding a mention or a list somewhere could be enough in this case, I like the idea.

I think we should include a mention and a link in the docs—maybe just in the Account section for now. When we have more, we can consider including a list in the README like we did with cairo v0. Wdyt?

I added a section in the API Reference for presets, I think that's (arguably) more compliant with the doc framework we are trying to target, and then users can follow which implementations the preset is embedding, the constructor, and so on. Let me know what you think. I'd like keeping the tutorial section as clean as possible from references.

I think it make sense for both suites to share most of the test cases, is there any chance we could reuse the module's for the preset? that'd be a step further in our plans of offering tests to our users.

I don't think we are at that point yet from the available features we have in the test runner. We would need at least to copy-paste the test functions to call internal abstractions (functions probably, or implementations), but that, besides not being pretty, would be hard as well, because the state types they would be receiving are not the same, and Cairo is not a dynamic language. The attempt to achieve that is a lot of effort and a short reward with the version we could accomplish. I think at some point we would be able to do it, just not at this point.

I think it make sense for both suites to share most of the test cases, is there any chance we could reuse the module's for the preset? that'd be a step further in our plans of offering tests to our users.

I don't think we are at that point yet from the available features we have in the test runner. We would need at least to copy-paste the test functions to call internal abstractions (functions probably, or implementations), but that, besides not being pretty, would be hard as well, because the state types they would be receiving are not the same, and Cairo is not a dynamic language. The attempt to achieve that is a lot of effort and a short reward with the version we could accomplish. I think at some point we would be able to do it, just not at this point.

Yeah, it's tricky. The pattern I came up with just works for tests with dispatchers which, if we're going to have multiple presets, might be worth fleshing out. I'm unsure if it's scalable though, I only tested it with a handful of tests and it's going to need a ton of gas.
#[test]
#[available_gas(200000000000000000)]
fn main() {
    let mut dispatcher = setup_dispatcher();
    test_erc20(dispatcher);
}

fn test_erc20(dispatcher: ERC20ABIDispatcher) {
    test_constructor(dispatcher);
    test_total_supply(dispatcher);
    test_balance_of(dispatcher);
    test_allowance(dispatcher);
    ...
}


issue at cmd when running flutter doctor

After cloning the repo, and updating my path variable, the instructions says to flutter doctor  and gives me this error
` Checking Dart SDK version...
Downloading Dart SDK from Flutter engine ead227f118077d1f2b57842a32abaf105b573b8a...
Start-BitsTransfer : The service cannot be started, either because it is disabled or because it has no enabled devices
associated with it. (Exception from HRESULT: 0x80070422)
At C:\Users\Carlos\Documents\flutter\bin\internal\update_dart_sdk.ps1:47 char:1

Start-BitsTransfer -Source $dartSdkUrl -Destination $dartSdkZip

  + CategoryInfo          : InvalidOperation: (:) [Start-BitsTransfer], COMException
  + FullyQualifiedErrorId : StartBitsTransferCOMException,Microsoft.BackgroundIntelligentTransfer.Management.NewBits
 TransferCommand

Error: Unable to update Dart SDK. Retrying...
Waiting for 2 seconds, press CTRL+C to quit ... `

having the same issue
except i have (Exception from HRESULT: 0x80070424) instead of (Exception from HRESULT: 0x80070422)

@cafej The 0x80070422 issue is probably a duplicate of https://github.com/flutter/flutter/issues/12664, so I'm going to close this bug as being caused by that one. Check that bug for suggestions regarding Windows Update settings.
@starba3 Please file a new bug regarding 0x80070424. We will need full logs, a description of your setup, etc. Thanks.


disk_util: use the dummy disk UUID

Depends on https://github.com/coreos/seismograph/pull/32.

lgtm

should this wait until there is a job in the initrd to initialize it on first boot?

@marineam yes, I should have called that out.

Depends on https://github.com/coreos/bootengine/pull/49.


Add default grid to STAC metadata

Hi, @jeremyh, as we discussed/reviewed this morning. Added the default value to support  STAC Projection (proj) Extension.

Codecov Report

Merging #193 (215e317) into eodatasets3 (ff62cbe) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           eodatasets3     #193   +/-   ##
============================================
  Coverage        87.90%   87.90%
============================================
  Files               26       26
  Lines             3670     3670
============================================
  Hits              3226     3226
  Misses             444      444

Impacted Files
Coverage Δ

eodatasets3/stac.py
91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff62cbe...215e317. Read the comment docs.

Did this fix your issue Sai? I was surprised to see that the tests didn't need updating... but looking at them now, the tests do correctly have proj:transform on the expected outputs. So what case did we fix?

To add the backstory for this PR:
The grid name is optional on EO3 measurements, and if not specified in the document it's assumed to be the 'default' grid:
measurements:
  nbar_panchromatic:
    path: ga_ls8c_nbar_3-1-0_088080_2020-05-25_final_band08.tif
    grid: panchromatic
  nbar_red:
    path: ga_ls8c_nbar_3-1-0_088080_2020-05-25_final_band04.tif
  nbar_swir_1:
    path: ga_ls8c_nbar_3-1-0_088080_2020-05-25_final_band06.tif

(latter two are 'default' grid)
Sai found that proj: information is not being included in his measurements that use the default grid... because this method is getting a None grid name instead of 'default', and not finding the grid.
https://github.com/GeoscienceAustralia/eo-datasets/blob/5529d5e9a69dea641e86ba7df5ddf2afaf59e8c5/eodatasets3/stac.py#L103-L108
But it's strange that it seems to work elsewhere fine?

Yes. I just confirmed again. This changes fixed my issue. My issue is:
Expected output:
"assets": {         "count_clear": {             "eo:bands": [                 {                     "name": "count_clear"                 }             ],             "type": "image/tiff; application=geotiff",             "roles": [                 "data"             ],             "href": "ga_ls_wo_summary_x07y23_2000--P1Y_count_clear.tif",             "proj:shape": [                 3200,                 3200             ],             "proj:transform": [                 30,                 0,                 -2016000,                 0,                 -30,                 -3168000,                 0,                 0,                 1             ]         }     }
Actual output:
"assets": {         "count_clear": {             "eo:bands": [                 {                     "name": "count_clear"                 }             ],             "type": "image/tiff; application=geotiff",             "roles": [                 "data"             ],             "href": "ga_ls_wo_summary_x07y23_2000--P1Y_count_clear.tif",         }     }
As you said, my assests lost their proj relative information.


Cannot add academic email

When trying to add an academic email, I'm redirected to the university login on chrome, but when I login succesfully on the university site, the Inboxer wont update and log in. When I try to reopen it says that ther is an error in main process that name is undefined.

I have a similar issue with my GSuite for Work account. After entering my email address on the login screen in Inboxer, I get kicked to Chrome to enter my password. After entering my password there, I am logged into Inbox in Chrome, and Inboxer is stuck at the login screen.

I also have this on Ubuntu 18.04. When I try to log into my academic email (The University of Illinois at Urbana-Champaign which authenticates via shibboleth for reference) it opens to firefox, and just goes there. Like the others above, it freezes on the login screen and I have to quit it.
I don't mind testing it out again and seeing if any fix works for my case too.

I want to close this project. Take a look at the explanation: #101
If you still need this project, please, fork the repo.


🪄 flyinstar judgement feature #143

resolves #143

Codecov Report
Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f68f374) 98.31% compared to head (001db84) 97.80%.
Report is 1 commits behind head on main.

Files
Patch %
Lines

src/astro/FunctionalPalace.ts
88.13%
7 Missing :warning:

src/astro/analyzer.ts
95.83%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   98.31%   97.80%   -0.52%
==========================================
  Files          79       79
  Lines        1247     1319      +72
  Branches      192      210      +18
==========================================
+ Hits         1226     1290      +64
- Misses         17       25       +8
  Partials        4        4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


all: Refactor test asserts

This PR refactors asserts in tests to make it shorter:

replace c.Assert(len(slice), qt.Equals, 6) with c.Assert(slice, qt.HasLength, 6);
replace c.Assert(boolFn(), qt.Equals, true) with c.Assert(boolFn(), qt.IsTrue);
replace qt.Not(qt.IsNil) with qt.IsNotNil.

qt.HasLength is, in my opinion, almost always a bad alternative.  For complex struct slices it produces massive output that's in no way any help in finding the diff.
The other 2 I agree on, but I would prefer to do these cosmetic test upgrades when we're adjusting a given test case, because we have several development branches in the pipeline, and changing 131 test files will create merge conflicts/work that will be much more expensive compared to the cosmetic value they have.


Add 'this project last had an updated submitted on 'x' by 'person'' on project selection from dropdown

To avoid multiple individuals from same project team from submitting unnecessarily

Partly done - it displays this but it doesn't successfully update after the user submits (so I've just added a note to account for that)


Instructions on how to deploy to local IIS

Hi,
Are there any instructions on how to deploy the Client and Server applications to an on-premise IIS?
I have worked before with ASP.NET Core MVC , never with React.
Wondering also if I can use the React Composite UI Library on an MVC view? Any tutorial on this?
Awesome work!
Thanks,

https://learn.microsoft.com/en-us/visualstudio/javascript/tutorial-asp-net-core-with-react?view=vs-2022
ASP.net is a web application framework designed to build server applications with web front-ends. ReactJS is front-end tool to help create componentized front-end experiences. This documentation page I have linked shows how to serve up ReactJS content from an asp.net application. To use the web UI Library built in React you will need to import in the library and use the component on the client code served to the end user.
There is no tutorial at this time but this is something we could look into building and sharing if there is interest.

Thanks! I'm sure a lot of people would be interested on see how they can leverage their prior knowledge of ASP.Net with ACS.
Also, is there any tutorial on how to deploy de VSCode Client and Server app to IIS?
Thanks,


Create canalhas.is-local.org

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.
[x] Your website is not hosting on the following due to SSL issues: Vercel, Netlify

Description

I'm using this site to create a page with my friend infos like social media and discord photos
Link to Website

https://site15815097.nicepage.io

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.


Provide deep links for actions in meeting minutes

This restructures the code to track an identifier for each action, so we can provide an anchor link (like #action-id-23) for each action.  That way, future discussions can always link back to an action in the minutes.
Resolves: #14

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

13 of 13 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 98.345%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
801

Relevant Lines:
812

💛  - Coveralls


Question about “posDistThr” of the Nordland dataset

Hi, thanks for your work. I have a question about “posDistThr” of Nordland dataset.
This repository sets the utm coordinate of i-th frame to (i,i) in the Nordland.npz file, which allows us to have a consistent function for evaluating R@N for all datasets. It's great!
The tolerance for Nordland dataset is 10 frames in the Patch-NetVLAD paper. However, the radius of the first frame (0,0) to the 11-th frame (10,10) is 10sqrt(2) rather than 10.  The “posDistThr” is set to 10 in Nordland.npz file in this repository.
I have wrote a script to calculate R@N on Nordland (tolerance is 2 frames). The result is consistent with setting the “posDistThr” to 2sqrt(2) rather than 2.

This is a good finding, thanks. Yes you are correct. Probably in hindsight we should have made utmDb have these coordinates:
0,0
1,0
2,0
etc.
Currently we use:
0,0
1,1
2,2
etc.
Which as you found, the euclidean distance to (10,10) = 10*sqrt(2).
Therefore our value of posDistThr is equivalent to an image distance of ~7 images. In the interest of repeatability I won't change our current nordland.npz file, however what I can do (and this would be a good improvement to this repo) is allow the users of this code to change the value of posDistThr (which can be done by adding a new config argument allowing this value to be manually set by the user).

Thanks for your reply. It's a good idea to add a new config argument allowing posDistThr to be manually set.

Hiya @StephenHausler - kind reminder re this issue :)

Sorry this has taken a while to complete, I've now updated our code to include the option of using a custom posDistThr value.
Specifically, I have added a new optional argument to feature_match.py called --posDistThr. This flag accepts an integer value, which overrides the value of posDistThr defined in the dataset ground truth file.
Changes provided in commit: 50ec8a868d97f5b3b5897df6d4e1a0c879dbfa63
Closing this issue now, if you have any problems feel free to let us know and reopen.


For a 0.20.13 release

#809 #807

Codecov Report

Merging #810 (64e14a0) into master (ed601bd) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Current head 64e14a0 differs from pull request most recent head 548b09a. Consider uploading reports for the commit 548b09a to get more accurate results

@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   85.70%   85.70%
=======================================
  Files          36       36
  Lines        3497     3497
=======================================
  Hits         2997     2997
  Misses        500      500

Impacted Files
Coverage Δ

src/composition/models/pipelines.jl
99.41% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed601bd...548b09a. Read the comment docs.


Updated implementation

I have revised the implementation to now be based on an upstream swagger-editor dockerfile.
It no longer includes a copy of the swagger-editor dist files.

+1
@mherrmanBC  if it looks good to you, please merge


Implement "memory" collector

Prometheus' Windows Exporter

https://github.com/prometheus-community/windows_exporter/blob/master/collector/memory.go
https://github.com/prometheus-community/windows_exporter/blob/master/docs/collector.memory.md

Implemented in 43ded47ff1b21497a32597316b20ddaf689e5bee.

This emits 32 metrics related to Windows memory usage.
I can confirm it works on Windows Server 2022.


ci: Improve tag detection during release

Previously we used the GITHUB_REF variable set during the execution of of Github Actions to get to the current tag, which failed if tagging was done on prior to the push/on a different branch. Now we use the information contained in the git repository that is checked out anyway. Additionally the release pipeline previously also ran for any new commit on master (without a new tag being present) and now runs only for tags in potentially any branch (which is fine, as the release pipeline does no privileged action).

Any example pipeline where this was successfully tested?

Any example pipeline where this was successfully tested?

https://github.com/sse-secure-systems/connaisseur/runs/1594978442?check_suite_focus=true


Can't build Expo app after installing the package

Reproduction steps

Developing an Expo app.

Added @datadog/mobile-react-native as a dependency in my package.json project
Tried to build the app using eas build --platform=ios (android is working just fine)
Build fails on Pods install stage with this error (Full Pods install stage on stackTrace section at the bottom):

[!] `<PBXResourcesBuildPhase UUID=`13B0**********00A75B9A`>` attempted to initialize an object with an unknown UUID. `078BF8B**********9778B` for attribute: `files`. This can be the result of a merge and the unknown UUID is being discarded.
pod install exited with non-zero code: 1

Every build is failing with the same error.
When using version 2.3.6 everything's fine, but >2.4.0 fails.

Volume
100%
Affected SDK versions
2.4.0
Latest working SDK version
2.3.6
Does the crash manifest in the latest SDK version?
Yes
React Native Version
0.74.1
Package.json Contents
No response
iOS Setup
No response
Android Setup
No response
Device Information
Every device.
Using Expo.
Build fails locally or on Expo Server
Other relevant information
Please contact me for more information.
We can't upgrade the package version for now.
Thank you guys!
Stack trace
Pods Install from Expo servers:
Using Expo modules
[Expo] Enabling modular headers for pod SPIndicator
[Expo] Enabling modular headers for pod SPAlert
[Expo] Enabling modular headers for pod ExpoModulesCore
[Expo] Enabling modular headers for pod React-Core
[Expo] Enabling modular headers for pod EXStructuredHeaders
[Expo] Enabling modular headers for pod EXUpdatesInterface
[Expo] Enabling modular headers for pod EXManifests
[Expo] Enabling modular headers for pod EASClient
[Expo] Enabling modular headers for pod ReachabilitySwift
[Expo] Enabling modular headers for pod sqlite3
[Expo] Enabling modular headers for pod RCT-Folly
[Expo] Enabling modular headers for pod glog
[Expo] Enabling modular headers for pod React-RCTFabric
[Expo] Enabling modular headers for pod React-Codegen
[Expo] Enabling modular headers for pod RCTRequired
[Expo] Enabling modular headers for pod RCTTypeSafety
[Expo] Enabling modular headers for pod ReactCommon
[Expo] Enabling modular headers for pod React-NativeModulesApple
[Expo] Enabling modular headers for pod Yoga
[Expo] Enabling modular headers for pod React-Fabric
[Expo] Enabling modular headers for pod React-graphics
[Expo] Enabling modular headers for pod React-utils
[Expo] Enabling modular headers for pod React-featureflags
[Expo] Enabling modular headers for pod React-debug
[Expo] Enabling modular headers for pod React-ImageManager
[Expo] Enabling modular headers for pod React-rendererdebug
[Expo] Enabling modular headers for pod DoubleConversion
[Expo] Enabling modular headers for pod hermes-engine
[Lottie React Native] Using install_modules_dependencies
Auto-linking React Native modules for target WhiteLabelApp: DatadogSDKReactNative, RNCAsyncStorage, RNDateTimePicker, RNGestureHandler, RNReanimated, RNSVG, RNScreens, lottie-react-native, pusher-websocket-react-native, react-native-netinfo, react-native-render-html, react-native-safe-area-context, react-native-slider, and react-native-webview
Framework build type is static library
[Codegen] Adding script_phases to React-Codegen.
[Codegen] Generating ./build/generated/ios/React-Codegen.podspec.json
[Codegen] Analyzing /Users/expo/workingdir/build/apps/white-label-app/package.json
[Codegen] Searching for codegen-enabled libraries in the app.
[Codegen] The "codegenConfig" field is not defined in package.json. Assuming there is nothing to generate at the app level.
[Codegen] Searching for codegen-enabled libraries in the project dependencies.
[Codegen] Found @datadog/mobile-react-native
[Codegen] Found @react-native-community/datetimepicker
[Codegen] Found @react-native-community/slider
[Codegen] Found lottie-react-native
[Codegen] Found react-native
[Codegen] Found react-native-gesture-handler
[Codegen] Found react-native-reanimated
[Codegen] Found react-native-screens
[Codegen] Found react-native-svg
[Codegen] Found react-native-webview
[Codegen] Found @react-native-async-storage/async-storage
[Codegen] Found react-native-safe-area-context
[Codegen] >>>>> Searching for codegen-enabled libraries in react-native.config.js
[Codegen] Processing DdSdkReactNative
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, tvos for DdSdkReactNative
[Codegen] Processing RNDateTimePickerCGen
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, visionos for RNDateTimePickerCGen
[Codegen] Processing RNCSlider
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, visionos for RNCSlider
[Codegen] Processing lottiereactnative
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, macos, tvos for lottiereactnative
[Codegen] Processing FBReactNativeSpec
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Processing rncore
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Processing rngesturehandler_codegen
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, macos, tvos, visionos for rngesturehandler_codegen
[Codegen] Processing rnreanimated
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, macos, tvos, visionos for rnreanimated
[Codegen] Processing rnscreens
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, tvos, visionos for rnscreens
[Codegen] Processing rnsvg
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, macos, tvos, visionos for rnsvg
[Codegen] Processing RNCWebViewSpec
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, macos for RNCWebViewSpec
[Codegen] Processing rnasyncstorage
[Codegen] Searching for podspec in the project dependencies.
[Codegen] Supported Apple platforms: ios, macos, tvos, visionos for rnasyncstorage
[Codegen] Processing safeareacontext
[Codegen] Searching for podspec in the project dependencies.

[Codegen] Generated provider in: /Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/React/Fabric
[Codegen] Done.
Analyzing dependencies
Fetching podspec for DoubleConversion from ../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec
Fetching podspec for RCT-Folly from ../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec
Fetching podspec for boost from ../node_modules/react-native/third-party-podspecs/boost.podspec
Fetching podspec for fmt from ../node_modules/react-native/third-party-podspecs/fmt.podspec
Fetching podspec for glog from ../node_modules/react-native/third-party-podspecs/glog.podspec
Fetching podspec for hermes-engine from ../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec
[Hermes] Using release tarball from URL: https://repo1.maven.org/maven2/com/facebook/react/react-native-artifacts/0.74.1/react-native-artifacts-0.74.1-hermes-ios-debug.tar.gz
% Total    % Received % Xferd  Average Speed   Time
Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
0     0    0     0    0     0      0      0 --
:--:-- --:--:-- --:--:--     0
100 16.5M  100 16.5M    0     0   103M      0 --:--:-- --:--:-- --:--:--  103M
% Total    % Received % Xferd  Average Speed   Time    Time
Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 12.2M  100 12.2M    0     0  94.0M      0
--:--:-- --:--:-- --:--:-- 94.4M
[Lottie React Native] Using install_modules_dependencies
Adding spec repo trunk with CDN https://cdn.cocoapods.org/
CocoaPods 1.15.0 is available.

[Privacy Manifest Aggregation] Reading .xcprivacy files to aggregate all used Required Reason APIs.
[!] An error occurred while processing the post-install hook of the Podfile.
undefined method each' for nil:NilClass /Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:111:in block (4 levels) in get_used_required_reason_apis'
/Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:106:in each' /Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:106:in block (3 levels) in get_used_required_reason_apis'
/Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:105:in each' /Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:105:in block (2 levels) in get_used_required_reason_apis'
/Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:104:in each' /Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:104:in block in get_used_required_reason_apis'
/Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:102:in each' /Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:102:in get_used_required_reason_apis'
/Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/cocoapods/privacy_manifest_utils.rb:18:in add_aggregated_privacy_manifest' /Users/expo/workingdir/build/apps/white-label-app/node_modules/react-native/scripts/react_native_pods.rb:301:in react_native_post_install'
/Users/expo/workingdir/build/apps/white-label-app/ios/Podfile:32:in block (3 levels) in from_ruby' /Users/expo/.gems/arm64/gems/cocoapods-core-1.14.3/lib/cocoapods-core/podfile.rb:196:in post_install!'
/Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/installer.rb:1013:in run_podfile_post_install_hook' /Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/installer.rb:1001:in block in run_podfile_post_install_hooks'
/Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/user_interface.rb:149:in message' /Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/installer.rb:1000:in run_podfile_post_install_hooks'
/Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/installer.rb:337:in block (2 levels) in create_and_save_projects' /Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/installer/xcode/pods_project_generator/pods_project_writer.rb:61:in write!'
/Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/installer.rb:336:in block in create_and_save_projects' /Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/user_interface.rb:64:in section'
/Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/installer.rb:315:in create_and_save_projects' /Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/installer.rb:307:in generate_pods_project'
/Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/installer.rb:183:in integrate' /Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/installer.rb:170:in install!'
/Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/command/install.rb:52:in run' /Users/expo/.gems/arm64/gems/claide-1.1.0/lib/claide/command.rb:334:in run'
/Users/expo/.gems/arm64/gems/cocoapods-1.14.3/lib/cocoapods/command.rb:52:in run' /Users/expo/.gems/arm64/gems/cocoapods-1.14.3/bin/pod:55:in <top (required)>'
/Users/expo/.gems/arm64/bin/pod:25:in load' /Users/expo/.gems/arm64/bin/pod:25:in '
[!] [Codegen] warn: using experimental new codegen integration
[!] <PBXResourcesBuildPhase UUID=13B07F8E1A680F5B00A75B9A> attempted to initialize an object with an unknown UUID. 078BF8BD05B04C14BA29778B for attribute: files. This can be the result of a merge and the unknown UUID is being discarded.

Hello @eylonshm, thank you for reaching out!
Have you tried updating to the latest versions of our packages?
"expo-datadog": "51.0.2",
"@datadog/mobile-react-native": "2.4.3"

It would be useful to see your package.json in order to diagnose the problem.
Could you please share it here?

Having the same issue after adding the package and trying to run pod install.

)
post_install do |installer|
# https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L197-L202
react_native_post_install(
installer,
config[:reactNativePath],
:mac_catalyst_enabled => false,
# :ccache_enabled => true
)
installer.pods_project.targets.each do |target|
if target.name == 'BoringSSL-GRPC'
target.source_build_phase.files.each do |file|
if file.settings && file.settings['COMPILER_FLAGS']
flags = file.settings['COMPILER_FLAGS'].split
flags.reject! { |flag| flag == '-GCC_WARN_INHIBIT_ALL_WARNINGS' }
file.settings['COMPILER_FLAGS'] = flags.join(' ')
end
end
end
end
end
end
`
Highest working version is 2.3.6. Anything at 2.4.0 and above causes this issue

Similar issue on my side, without using expo
After only adding the npm package yarn add @datadog/mobile-react-native with node 18.18.0 for React Native 0.74.1
Following: https://docs.datadoghq.com/real_user_monitoring/mobile_and_tv_monitoring/setup/reactnative/#setup
and installing the pods
[Privacy Manifest Aggregation] Appending aggregated reasons to existing PrivacyInfo.xcprivacy file.
[Privacy Manifest Aggregation] Reading .xcprivacy files to aggregate all used Required Reason APIs.
[!] An error occurred while processing the post-install hook of the Podfile.

undefined method `each' for nil

...

/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-core-1.15.2/lib/cocoapods-core/podfile.rb:196:in `post_install!'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:1013:in `run_podfile_post_install_hook'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:1001:in `block in run_podfile_post_install_hooks'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/user_interface.rb:149:in `message'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:1000:in `run_podfile_post_install_hooks'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:337:in `block (2 levels) in create_and_save_projects'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer/xcode/pods_project_generator/pods_project_writer.rb:61:in `write!'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:336:in `block in create_and_save_projects'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/user_interface.rb:64:in `section'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:315:in `create_and_save_projects'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:307:in `generate_pods_project'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:183:in `integrate'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/installer.rb:170:in `install!'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/command/update.rb:63:in `run'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/claide-1.1.0/lib/claide/command.rb:334:in `run'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/lib/cocoapods/command.rb:52:in `run'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/gems/cocoapods-1.15.2/bin/pod:55:in `<top (required)>'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/bin/pod:25:in `load'
/opt/homebrew/Cellar/cocoapods/1.15.2_1/libexec/bin/pod:25:in `<main>'


Reformat code with black for PEP8 compatibility

Relates to discussion in #63 and #83
More on code formatting philosophy at https://www.mattlayman.com/blog/2018/python-code-black/

@zodman the black formatting tool seems like a nice addition here because of the older codebase that could use some small structuring and formatting, and it seems to integrate into the existing tooling pretty easily, just touching the tox.ini file :)
Since we don't have any other PRs open, it should be easy to include reformatting at this time.

yeap!!! i will merge it!


Chore/rise up fallen web connector

Describe changes
I have added the identity related methods for Pallad, they seem to be working! 🙏

@mrcnk please review, thanks :)

@mrcnk here is an update for you w/ a failing test :)


Make --scm-base-url more fool-proof

Strip scheme prefix for --scm-base-url option so that https://gitlab.com and gitlab.com are accepted.
Fixes #93

@fproulx-boostsecurity, took a stab at the issue for fun.
I was able to run the cli with https:gitlab.com/ and just gitlab.com with this change.


Target port of common and headless services are 0 in GKE Autopilot clusters

I created a SolrCloud on a GKE Autopilot cluster with the following YAML:
# https://apache.github.io/solr-operator/example/test_solrcloud.yaml
apiVersion: solr.apache.org/v1beta1
kind: SolrCloud
metadata:
  name: gxa
  namespace: jenkins-gene-expression
spec:
  dataStorage:
    persistent:
      reclaimPolicy: Retain
      pvcTemplate:
        spec:
          resources:
            requests:
              storage: "15Gi"
  replicas: 2
  solrImage:
    tag: 8.7.0
  solrJavaMem: "-Xms1g -Xmx3g"
#  solrModules:
#    - jaegertracer-configurator
#    - ltr
  customSolrKubeOptions:
    podOptions:
      resources:
        limits:
          memory: "1G"
        requests:
          cpu: "65m"
          memory: "156Mi"
  zookeeperRef:
    provided:
#      chroot: "/this/will/be/auto/created"
      persistence:
        spec:
          storageClassName: fast
          resources:
            requests:
              storage: "1Gi"
      replicas: 3
      zookeeperPodPolicy:
        resources:
          limits:
            memory: "512Mi"
          requests:
            cpu: "65m"
            memory: "156Mi"
#  solrOpts: "-Dsolr.autoSoftCommit.maxTime=10000"
  solrGCTune: "-XX:SurvivorRatio=4 -XX:TargetSurvivorRatio=90 -XX:MaxTenuringThreshold=8"

The target port of the headless and common services is set to 0, which is a minor annoyance because I need to create another service to do port-forwarding.

It looks like the reason is that the targetPort is set to solr-client, rather than 8983.
This is the relevant block in the headless service:
  - appProtocol: http
    name: solr-client
    port: 8983
    protocol: TCP
    targetPort: solr-client

And this is the one from the client service:
  - appProtocol: http
    name: solr-client
    port: 80
    protocol: TCP
    targetPort: solr-client

Is this expected behaviour or something specific to GKE clusters?

Are you using Multi Cluster Services in GKE? If so there is a known issue with them and named target ports that will be fixed in a future version: https://cloud.google.com/kubernetes-engine/docs/how-to/multi-cluster-services#container_port
If not, then I would suggest issuing a bug-report with GKE. Using a targetPort name is very much supported by Kubernetes, and GKE not supporting it would be a pretty big deal, I think.
Sorry that you are facing this annoyance, and hopefully we can figure out why GKE is behaving in this way...

Thanks @HoustonPutman. I’ve checked and MCS are disabled in our cluster. I’ll try to find my way in GKE to report the issue.

Well, guess what, it looks like something’s wrong in GKE. I reported the issue.

To clarify, the issue is at the web dashboard level, the service works as expected.


[BUG] error out if tor config is not valid in the begginning

Describe the bug

should be done for all scripts that need, so no -web.
The function should be in /usr/share.
Actually, verify_config_tor does not need tor to be running, only signal_tor...
So this issue depends on

https://github.com/nyxnor/onionjuggler/issues/65

After the option to not signal tor at all, it will be possible to only verify its config.
Use case if when you want to setup all configuration files before starting the tor instance.
Reload/Restart tor is just a helper for most cases, except for activating onion services, which this one is necessary to get the onion address.
But even this one can be skipped if tor is not running.
Default behavior: reload tor
Optional: restart tor or not signal at all.
If not signaling at all, only verify config.

changed title because of https://github.com/nyxnor/onionjuggler/issues/65#issuecomment-1217775552

The problem with this alone is that what is onionjuggler mistakenly allowed a broken config, how is the user gonna correct the broken config?:

if it is the tor_conf, almost impossible for safe_edit to fail coeteris paribus the variables (sarcasm)
if it is the auth files, than that is a problem, because tor doesn't verify the auth correctly and sometimes ignores it sometimes just crashes.

Introduced env var ONIONJUGGLER_SKIP_PRE_TOR_CHECK

4b016b6


tax fix for view

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/PT-7983.
Please use this issue to track the state of your pull request.

Hi @JonidBendo
thanks for your PR.
your changes result in a JS error on this line: https://github.com/shopwareLabs/SwagBackendOrder/blob/master/Resources/views/backend/swag_backend_order/controller/main.js#L394
what is your issue or intention behind your change?

Hi @mitelg, the issue was that when you had multiple taxes and the id of one of them matched with the value from another one, for example tax name 7% id 4, tax 19% id 7. If you tried to apply tax 7% you would end up with 19%. There is a weird mismatch like that.

Hey @JonidBendo
ok, that sounds like a bug :-)
could you please fix the JS error, so we could merge it?

Hey @JonidBendo
I am not able to reproduce your issue. my taxes:

id
tax
description

1
19.00
19%

4
7.00
7 %

7
19.00
19%2

I set the third tax to a product and added it to a new order within the module. The column tax shows the right value, 19 and not 7 as you said. Can you confirm this behaviour?

thanks for your contribution @JonidBendo
Your fix will be merged soon


feat!: reimplement multisignature transactions

Description
This PR provide an example how multisignature transactions could be implemented using iroha triggers.
In this PR i've tried to make as small invasive changes into the core as possible.
How this work?
There is 2 triggers (thanks @s8sato  for inspiration in account activation feature):

multisig_register - responsible for registering new multisig user and trigger multisig
multisig - responsible for executing instructions on behalf of multisig user when enough votes are collected

Assumptions:

user have to come up with they own public key for multisig account:

it might be ok to have primary private key in case of emergency or smt
it could be generated at random or obtained through key aggregation
it's currently not possible to generate public key inside wasm smart-contracts

multisig_register should be registered either as part of genesis or by domain owner to have enough permissions for it's actions

currently in default executor there is no way to allow certain trigger to be executable by anyone (workaround would be to have trigger which would grant this permission on account registration)

Linked issue

Closes #4373

Benefits
Get back multisig functionality without too much changes on iroha side.
Downsides
Executing multisig instructions through tirgger probably slower that backed in solution.

great piece of work. It would be interesting to explore whether we can make a custom instruction for MultiSigRegister, might be even simpler to use

i think it should be possible, in this case we would move logic of multisig register trigger into the executor which would be triggered on custom instruction


CAMEL-19304: camel-jpa implement paging

Description
Camel JPA endpoint supports option maximumResults, but this is not enough to implement paging. Also, there is no way to specify offset apart from nativeQuery.
maximumResults is static on the endpoint; it may be specified dynamically only using toD, but this means creating dynamic endpoints.
This PR addresses the above:

adds support for firstResult
both maximumResults and firstResult may be specified in message headers, these override values specified on the endpoint, if any

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[x] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I formatted the code using mvn -Pformat,fastinstall install && mvn -Psourcecheck

Thanks, corrected.


Add explicit cd unit tests

This is to ensure we have good test coverage of the cd implementation.
Related #1062

The FreeBSD test environment seems to lack a valid HOME. Fix this with eval.InTempHome.

The FreeBSD test environment seems to lack a valid HOME. Fix this with eval.InTempHome.

Ugh! I don't see a failure executing go test ./... on FreeBSD (but not OpenBSD). Presumably because I'm doing so via a scripted interactive shell (thanks to tmux) which results in $E:HOME being set. On Windows (both my Windows VM and the Appveyor CI) it fails thusly:
--- FAIL: TestBuiltinCd (0.01s)
    --- FAIL: TestBuiltinCd/old_=_$pwd;_cd_/;_put_$pwd;_cd_$old;_eq_$old_$pwd (0.00s)
        builtin_fn_fs_test.go:41: got value out [C:\ $true], want [/ $true]

Both failures can be addressed by using directories relative to eval.InTempHome() so I'll make that change to this PR. However, the Windows failure suggests a lot more thought needs to go into making Elvish work on that platform.

Both failures can be addressed by using directories relative to....

Note: that is probably only true if we embed the literal value returned by eval.InTempHome and otherwise write the comparison of the test result to be independent of the path separator. It's not clear how to do so given the current test framework without having platform specific versions of these tests.

@xiaq, PTAL. This now passes on all CI environments as well as my local machines.

@xiaq, PTAL. I implemented all your feedback with the exception of the suggestion to split each individual cd test into two or more test functions. I also greatly simplified the test function.


Fix an off-by-one allocation error in the Greet example

The Greet example allocates and deallocates memory for a string, but doesn't account for the extra NULL character.
In the first commit I added a demo test that uses the same allocation idiom but also copies a second string. Interestingly, this only fails for a precisely tuned value of the string length (2^16-52), presumably related to hitting the end of a memory block, but I suspect with a little effort other bad effects could be discovered.

Incidentally, not a bug, but I think a more idiomatic way to copy the memory would be to replace
memory := instance.Memory.Data()[inputPointer:]

for nth := 0; nth < lengthOfInput; nth++ {
	memory[nth] = input[nth]
}

with
copy(instance.Memory.Data()[inputPointer:], input)

Can you also include the copy improvement in your PR please :-)?

Done! Thanks for the quick review. 😃

bors r+

Thanks!


Add English functions

At the moment it is not possible to provide a bilinugal function description for active members. You can only add a Dutch or an English description. It would be nice if a bilingual option could be added.

Dear Dennis,
This ticket has already been closed #152. This is because we consider the study association to be English and therefore we expect the board to only use English function names. Moreover, making the fields bilingual would require a lot of models to be modified. It would also mean that all current functions needs to be translated by the board, which is a huge amount of work.
We hope to have informed you sufficiently.
Kind regards,
Sophie


Add OpenAPI types

In order to do validation, I need the manifest structures. This adds that.
It also adds the problem type since I think that will be useful to have later on.

#78  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eberle1080 and the rest of your teammates on  Graphite

Can you update them to the files from amp-labs/server#964?
Also, we'll want to avoid having 2 sources of truth in the future, so after everything is released for the read objects migration, we should modify server repo to refer to these openapi files (just like how the server repo currently refers to the Provider related openapi spec files in the connectors repo)

I thought about doing that, but since cli is public and server is private, that complicates things. Not sure how to proceed.


RTM 1.1 of pw/email reset

Review URL

why do you have the angle brackets here?
I'm guessing it's an artifact of the conversion process. I didn't touch that line or look at it. Removed them anyway. Good catch.

Not seeing cert error.


errors: review SchemaValidationError exception

The data validation should not be bound to Marshmallow. Invenio-records-resources allows you to define your own custom validation. In addition, we should probably define the exception as part of the invenio-records-resources.errors as that is the place the validation concept is defined.

And any other invenio/resources related exceptions (e.g. FieldsError)

The SchemaValidationError exception code was deleted from the module and should be added in the invenio-records-resources. For reference, the deleted code:

class SchemaValidationError(HTTPJSONException):
    """Marshmallow schema validation exception."""

    def __init__(self, errors=None, **kwargs):
        """Initialize exception."""
        _errors = []
        if errors:
            for field, messages in errors.items():
                _errors.extend([_FieldError(field, msg) for msg in messages])
        super(SchemaValidationError, self).__init__(errors=_errors, **kwargs)

    class _FieldError(object):
        """Represents a field level error.

        .. note:: This is not an actual exception.
        """

        def __init__(self, field, message, code=None):
            """Init object.

            :param field: Field name.
            :param message: The text message to show.
            :param code: The HTTP status to return. (Default: ``None``)
            """
            self.res = dict(field=field, message=message)
            if code:
                self.res["code"] = code

        def to_dict(self):
            """Convert to dictionary.

            :returns: A dictionary with field, message and, if initialized, the
                HTTP status code.
            """
            return self.res

    def get_errors(self):
        """Get errors.

        :returns: A list containing a dictionary representing the errors.
        """
        return [e.to_dict() for e in self.errors] if self.errors else None


[Unity] Push is received when app is in foreground, but payload is empty

I'm using the following code in Unity to receive pushes while the app is in the foreground. This code is almost exactly what's in the Parse Push Tutorial on Github.
using UnityEngine;
using System.Collections.Generic;
using System.Collections;
using Parse;
using System;

public class PushBehaviour : MonoBehaviour {

// Use this for initialization
void Awake() {

    #if UNITY_IOS
    UnityEngine.iOS.NotificationServices.RegisterForNotifications(UnityEngine.iOS.NotificationType.Alert |
                                                                  UnityEngine.iOS.NotificationType.Badge |
                                                                  UnityEngine.iOS.NotificationType.Sound);
    #endif

    ParsePush.ParsePushNotificationReceived += (sender, args) => {

        #if UNITY_IOS

        //this is working!
        Debug.Log("Push Received!");

        //this only displays empty brackets: "{}"  ... where's the payload??
        Debug.Log(args.StringPayload);

        IDictionary<string, object> payload = args.Payload;

        //this is not working
        Debug.Log(payload["alert"]);

        foreach (var key in payload.Keys) {
            //this is not working
            Debug.Log("Payload: " + key + ": " + payload[key]);
        }
        #endif
    };
}
}

With this code, pushes are received but the payload is empty. I've confirmed that there is actually a payload - I can clearly see the "alert" text in the iOS notification when the app is in the background. I've tried sending pushes with push.Data = new Dictionary<string, object> { {"alert", "test"} }; and also just with push.Alert = "test"; and I've tried sending them from the app and from the Parse website. I also tried converting the Dictionary to IDictionary before sending, but nothing worked.
I'm using Unity 5.2.2, Parse Unity SDK 1.6.1, and Xcode 7.1
Is this a bug, or is there just a missing step in the Parse documentation?
Thanks!

I'm seeing a similar issue with iOS.  In the UnityAppController.mm code, I can print the userInfo parameter in the application:didReceiveRemoteNotification: delegate method and it has "aps" and "parsePushId" keys.  But when this arrives in ParsePush.ParsePushNotificationReceived as the args parameter, the "aps" key is missing.
So... I can't get foreground push notifications on iOS.  Since other posts have indicated this is possible, wondering if a change has introduced this problem.

Whoops. Somehow this issue fell through the cracks (and wasn't pinged by our bot, even weirder).
I'm not 100% sure what's going on here, we may be running one of Unity's 'undocumented features'.
I'll poke around the code and see what I can figure out.