Issue in the generated links on the deployed version

Issue description
Issue Description
When I open the (deployed version of the) documentation page: Extension Points for Tables
and I click on the link:

For more information, see Configuring Responsive Behavior of a Table.

then my browser gives me the error 404 The requested resource is not available.
The same issue occurs with the link:

For more information, see Using the Export Feature.

Screenshots

Further information
When I open the corresponding markdown page by clicking on "Edit on GitHub", the links work properly.
https://github.com/SAP-docs/sapui5/blob/main/docs/06_SAP_Fiori_Elements/extension-points-for-tables-d525522.md
Feedback Type (Optional)
linking
Page Title on SAP Help Portal (prefilled)
No response
Page URL on SAP Help Portal (prefilled)
No response

Hi @PierreFritsch , thanks for your contribution and thorough look at the documentation. We appreciate it and will look into this.

Hi @PierreFritsch  , I tested this in various scenarios and it works for me in Edge. Which browser are you using? Thanks for your help

Hi @KvM2,
Thanks for your fast reaction! I still face the issue with Safari 16.6 and Chrome 116.

Thanks, @PierreFritsch . We will look into this.

Hi @PierreFritsch,
Thanks for pointing out this issue. We've addressed it to the appropriate team. Could you please confirm that you get Error 404 only when trying to open the link in a new tab and if you click directly on the link to open it in the same window, it opens correctly.
Thanks a lot.

Hi @LilyanaOviPe
The issue can be reproduced on Safari on iOS 17.0.1 when attempting to open the linked pages above directly from GitHub. No new tab needed.

Thanks again @PierreFritsch! This will be fixed with the next version.


Macos

callback_data->pMessageIdName sometimes is a NULL string and fmt::format("validation: {} ({})", callback_data->pMessageIdName, callback_data->messageIdNumber); causes an error, so I added a validation if it is NULL only do fmt::format("validation: ({})", callback_data->messageIdNumber);
The newest releases of VulkanSDK require that Apple M1 add the extension VK_KHR_portability_enumeration and a flag in create_info.flags = VK_INSTANCE_CREATE_ENUMERATE_PORTABILITY_BIT_KHR. This code was added inside a #ifdef APPLE to not disturb Linux and/or Microsoft
VK_ERROR_OUT_OF_HOST_MEMORY error is because Vulkan instance cannot be created because it is using use_custom_cpu_callbacks and the function custom_cpu_allocation is calling aligned_alloc with a size that is not a multiple of alignment and that is a requirement (MS _aligned_malloc  does not have this requirement). So the size is adjusted to be a multiple of alignment for this case as follows: return aligned_alloc(alignment, ((size / alignment) + 1) * alignment);

This changes made all examples to work on MacOS

Thanks, really appreciate it. I did a few more tests and lgtm :+1:
I'm glad you were able to find and fix the problem. Let's see, maybe we'll do more with Apple M1 in the future...


Link delay enhancements

Description

Adds support for default behavior for ctrl/cmd + click, and middle mouse click when using Link Delay
Adds data element support to many fields
Adds new tests
Changes the testing framework from enzyme to react-testing-library

Related Issue
https://jira.corp.adobe.com/browse/DTM-13847
https://jira.corp.adobe.com/browse/DTM-14063
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All tests pass and I've made any necessary test changes.
[x] I have run the extension sandbox successfully.

@Aaronius made this ticket after our chat about nuking Android support for test runs: https://jira.corp.adobe.com/browse/DTM-16098


Deploy Apache Flink with checkpointing, required for fault tolerance

Exploring different matured operators and checkpointing mechanisms in place.

Working on the integration with RocksDB state backend for checkpointing.


Expand configuration

Add release
Add environment (default to kernel.environment)
Add app_path
Add prefixes

Fixes GH-1

This will also require a point release of sentry-php

Would love to have this!!
Anything that I can help with to push this further?

@Jean85 thanks for pinging -- forgot about this once we pushed out the updated sentry/sentry release.

Thanks to you @dcramer !
Any plans on tagging this on Packagist?

@Jean85 0.2.0


Feat tabs config

Current coverage is 82.19% (diff: 100%)

Merging #1335 into development will increase coverage by 0.16%

@@           development      #1335   diff @@
=============================================
  Files               66         67     +1
  Lines             1904       1910     +6
  Methods             17         17
  Messages             0          0
  Branches           270        268     -2
=============================================
+ Hits              1562       1570     +8
+ Misses             248        247     -1
+ Partials            94         93     -1

Powered by Codecov. Last update d8870d6...dceeede


Allow loadProto to be able to load common protos directly

Codecov Report

Merging #147 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #147      +/-   ##
=========================================
+ Coverage   92.87%   92.9%   +0.03%
=========================================
  Files          11      11
  Lines        1347    1354       +7
  Branches      275     277       +2
=========================================
+ Hits         1251    1258       +7
  Misses         96      96

Impacted Files
Coverage Δ

lib/grpc.js
87.85% <100%> (+0.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661ab09...f4cd1f0. Read the comment docs.


Feature request: Force SSL

Unless changing .htaccess currently there is no option in Grav to force redirecting the user to a secured site.

Did it from htaccess but forcing ssl from within grav would be great.

+1

In Grav 1.1 you can already force ssl on at the page level. Just by setting ssl: true in the page frontmatter.  I don't think this has made it to the admin yet.  For this to work you need to have absolute_urls: true in the system.yaml otherwise links will not have the protocol (https://) prepended.
What is currently missing is a site-wide setting however.

i just added redirect to https in htaccess, and ssl: true is not present in admin, very handy

Good idea to have a global one

I was already aware of having secured pages with the ssl: true page header ;-). However, I really mean to have a global one, which can be changed in the admin system settings tab.
If the global setting further has the advantage, that it doesn't need absolute_urls set to true, since all pages have the same protocol https://. We can maybe enhanced the ssl page header in this way, that if a global setting is set to true ssl: false for a specific page takes care that (i) absolute_urls: true and the specific page is not secured and vice-verse for a global setting set false.

PRs welcome :) I'm supposed to be on holiday!

Started working on this PR: https://github.com/getgrav/grav/pull/899
Please test and report if you got any issue.
Currently does not take into consideration custom ports, something it should most probably do.

@flaviocopes It does work. However instead of checking $_SERVER['HTTPS'] I would use the $uri class. The same goes for building the URL. Even a custom port shouldn't be a problem then. Don't know if I should start with a PR, too, or not. Unfortunately I'm involved in another project atm. With the end of the week I could provide my solution. Please let me know your thoughts on that.

Yes you can do that too, just another approach. If you want to improve it, feel free! 👍
Anyway this remains a rather slow way of redirecting users, since you first need to instantiate Grav.
I'd always use a .htaccess based rule (if using Apache, other solutions if another webserver) if possibile.

Ok, great. I'll think about it and provide a PR (most likely next week). I don't care if the first call is a slow process. It fortunately happens only once. Although .htaccess is the usual way to go, I think (and that is the reason why I opened the issue) having a switch directly in Grav making it more powerful due to easier editing.

Correct me if I'm wrong, but .htaccess will mainly redirect the page rather than enforce https on assets? And as Sommeregen says, a .htaccess rule will do this on every instantiation of Grav, whilst a mechanism internal to Grav will only run on every recache.

So, .htaccess does the same, but at a lower level, and faster

#899 has been merged so I'm going to close this issue and add my 2 cents on this matter.
Even though the option is there, I would highly suggest to stick to the .htaccess (or NGINX equivalent) method, if you have access to it. As @flaviocopes said above, it is a much faster, optimized and more reliable way to enforce https.
I actually don't quite like the implementation of this option with #899, .htaccess (or equivalent) let your server skip all the loading of Grav and get to the HTTPS before anything has happened yet, as all it has to deal with is the HEAD request, Grav is far far away from it still.
With the system.force_ssl option, however, Grav has to work a lot (initialize and go through its life cycle) just to finally realize it has to reload to the HTTPS protocol and then redo it all again. In the meantime, nothing has been served to the client and it's been quite a waste of resources, even though Grav is pretty fast, there is no reason nor benefit in doing this.
So, I really hope this explanation really discourages each and everyone of you in using the system.force_ssl option. If you can choose between the two, go for the .htaccess method without thinking.


add CAPEC

Not supported in VulnerabelCode yet: https://capec.mitre.org/
Quite a few CVEs in the V5 JSON format have a field called capecId that is useful to mine. However, there are also CVEs where there are references to CAPEC identifiers, but where there is no capecId.

As a note, there seems to be a nesting system of CAPEC codes. For an example see CVE-2019-0003:

Huh. Github automatically created a link to the advisory, but you need to look at the JSON file for that CVE from the CVE website, not click the Github generated link.


Upgrading to version ^3.2. Doesn't work with S3

When upgrading to 3.2.4 I've experienced BAD REQUEST from S3:
InvalidArgumentBucket POST must contain a field named 'key'.  If it is specified, please check the order of the fields.
Downgrading to 2.2.2 Solved it.

You should use 'fields' instead of 'data' in your config $upload.upload({fields:...})

I assume changing data to fields solved the problem for version 3.2.4. If not please reopen.


Visual Studio can't open solution (Unknown solution item type)

Godot version
v4.0.beta2.mono.official [f8745f2f7]
System information
macOS 12.4
Issue description
Can't open solution on Visual Studio for Mac
Steps to reproduce

Create new project
Create C# script
Try to open script in VS

Minimal reproduction project
No response

Duplicate of https://github.com/godotengine/godot/issues/67029.


dns discovery

In @jurmous etcd4j's client, there were a simple dns srv discovery util to get a list of etcd instances, would it make sense to port it here ?

@lburgazzoli thanks for pointing out this, I will take a look, if possible I will port it here, and actually we are going to implement one, you can see here. Thx :)

@AdoHe best would be to have a common class to extend then I could el providing a dns imp

@lburgazzoli grpc-java already has a dns based name resolver provider, I guess you are trying to implement a different one. So I would add an AbstractEtcdNameResolverFactory class, then you could provide a dns impl.

I had a quick look at grpc's dns impl but it does not seems to use srv records.
I would like to be able to leverage etcd or discovery options [1][2] like:

dns:

EtcdClientBuilder.newBuilder()
    .endpoints("dns+srv://_etcd-server._tcp.example.com")
    ...

etcd:

EtcdClientBuilder.newBuilder()
    .endpoints("etcd://discovery.etcd.io/3e86b59982e49066c5d813af1c2e2579cbf573de")
    ...

If it make sese of course.
[1] https://coreos.com/etcd/docs/latest/clustering.html#etcd-discovery
[2] https://coreos.com/etcd/docs/latest/clustering.html#dns-discovery

@lburgazzoli so I would suppose there are three ways to specify the endpoints:

dns:

EtcdClientBuilder.newBuilder()
    .endpoints("dns+srv://_etcd-server._tcp.example.com")
    ...

etcd discovery:

EtcdClientBuilder.newBuilder()
    .endpoints("etcd://discovery.etcd.io/3e86b59982e49066c5d813af1c2e2579cbf573de")
    ...

plain host:port list:

EtcdClientBuilder.newBuilder()
    .endpoints("http://<IP_ADDRESS>:2379", "http://<IP_ADDRESS>:2379")
    ...

Then we need to implement three types name resolver. wdyt?

Could be, I do not yet know how the name resolver work but it is definitively be required for srv and etcd.

@lburgazzoli I opened an init pr #26, ptal.

@lburgazzoli I would think dns based name resolver will resolve SRV records found at specific DNS domain name, discovery based name resolver will fetch discovery service to get endpoint addresses, directly host:port will just use user configured list of endpoints.

Also the AbstractEtcdNameResolverFactory may be not complete, we may add more methods here.

@lburgazzoli this pr #26 has merge, would you help implement dns based name resolver? Thanks very much :)

@AdoHe I will

@AdoHe I see that in grpc-java they use NameResolverProvider instead of NameResolver.Factory , which one should we use ?

@lburgazzoli we should use NameResolver.Factory, ManagedChannelBuilder can configure this.

I've created PR #31 for discussion, let me know what your opinion is


[Event Request] OnAfterValidateCreateSalesInvoiceLine event

JobCreateInvoice.Codeunit.al line CreateSalesInvoiceLines
Currently it validates JobPlanningLine."Job No." <> JobNo, we have a use case were we want to add multiple jobs from the same company/customer to an invoice
Adding an event after the validation allows custom validation while still defaulting to the current behavior
if JobPlanningLine."Job No." <> JobNo then
	LastError := StrSubstNo(Text009, JobPlanningLine.FieldCaption("Job No."));
OnAfterValidateCreateSalesInvoiceLine(JobPlanningLine, LastError);
if LastError <> '' then
	Error(LastError);

[IntegrationEvent(false, false)]
local procedure OnAfterValidateCreateSalesInvoiceLine(var JobPlanningLine: Record "Job Planning Line"; var LastError: Text)
begin
end;

Also where is the code from Microsoft_Base Applicationin git hub? I would submit a pull request but my google skills are failing me, thanks

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Add links to metabase analytics

Fix for #375
This PR proposes to add the links to the dashboard for QGIS and for the QGIS Plugins web portal:

QGIS Dashboard: https://analytics.qgis.org
Plugins Dashboard: https://plugins.qgis.org/metabase/public/dashboard/7ecd345f-7321-423d-9844-71e526a454a9

Just so you know, this PR depends on https://github.com/qgis/qgis-uni-navigation/pull/9 which adds the links to the menu in the navigation bar.

Summary by CodeRabbit

New Features

Added "QGIS Dashboard" and "Plugins Dashboard" links to the Resources menu for enhanced navigation.

Bug Fixes

Improved the initialization of footer links for reliable access and functionality.

Tests

Expanded test coverage for the home page to verify the visibility of the new dashboard links in the footer.

Can we use Metrics rather than Dashboard? Otherwise, lgtm, thanks!

Thanks for the review @timlinux , I've updated them.


Add KKDZ and its team members as contributors in the wiki

This is required by the A1 brief. Add the GitHub username associated with each contributor.

Approved

Wiki updated by Kyle


Advice io1 storage / EC2 I3 instances for AWS

Please check the wording and if this is sufficient information

https://deploy-preview-100--zealous-morse-14392b.netlify.com/docs/3.4/deployment-cloud-aws.html


Deprecate DependOptions

Deprecate DependOptions

The pull request has been merged. Thanks again for your attention to detail and following up on your initial contribution!

you're welcome :-)


Bug: Cart Summary, Minicart Summary - Font color

Type: minor
Describe the bug
The font color for Item total, Shipping, etc. should be black color, not blue:

vs.

https://stoic-hodgkin-c0179e.netlify.com/#!/CartSummary

:tada: This issue has been resolved in version 0.36.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Many paragraphs.

Hi,
Is it possible to replace the placeholder with array of strings, where each array member would be in a new paragraph? Maybe it's possible to do it some other way?
If so, maybe you can give an example.

Hey, this would mean to dynamically inject xml into the document while iterating over the array. Unfortunately this is not possible because there is no internal xml representation which would be required to insert elements.
I would love to have helped you with your issue. Unfortunately I don't have that much spare time to implement this kind of feature.
Feel free to give it a shot, tho :grinning:


I was getting the "Can't access to google photos" error, but I fixed it

I was getting the "Can't access to google photos" error because I was being redirected from photos.google.com to google.com/photos/about as though I wasn't signed in. I tried a bunch of stuff trying to get google to recognise the IP, signed in over a VPN, made a login script using selenium.
TL;DR: I injected my cookies from my browser to line 47 of index.js in /usr/lib/node_modules/upload_gphotos/lib/index.js to look like this:
        this.axios = axios_cookiejar_support_1.default(axios_1.default.create({
            headers: {
                'User-Agent': `Mozilla/5.0 UploadGPhotos/${packageInfo.version}`,
+                'Cookie':'NID=really long cookie string filled with sensitive information-----
            },
            validateStatus: () => true,
            maxRedirects: 0,
            jar: this.options.jar,
            withCredentials: true,
            responseType: 'text',
            transformResponse: [data => data],
        }));

I hope this information helps to update the library and make it more robust. Great work. I uploaded an 8GB "file" without using up my allowance!

It was working for a while, but now I'm getting this message:
ERROR Failed to upload. Retry after 3 sec. Server Error: sessionStatus is not found.
ERROR Failed to upload. Retry after 3 sec. Server Error: sessionStatus is not found.
ERROR Failed to upload. Server Error: sessionStatus is not found.
ERROR Error: Server Error: sessionStatus is not found.
    at GPhotos.<anonymous> (/usr/lib/node_modules/upload-gphotos/lib/index.js:328:39)
    at Generator.next (<anonymous>)
    at fulfilled (/usr/lib/node_modules/upload-gphotos/lib/index.js:4:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)
 1: 0x8dbaa0 node::Abort() [node]
 2: 0x96e489  [node]
 3: 0xb60aff  [node]
 4: 0xb61669 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [node]
 5: 0x27e8309dbe1d
return code: -6

I've tried updating my cookie but that doesn't seem to fix it. It it possible that I've been shadow banned. My cookie looks like it's changed formats. I can still upload images from the website though....

Hope you find a solution, I'm waiting too. Good luck !

Looks like my access came back. I don't even know if refreshing my cookie did anything. Looks like I was temp banned? Nothing I uploaded was removed, there's no sign anything happened.
I'll keep this thread updated with how it goes, but I hope the script changes to incorporate a working method of getting a working cookie from the username and password.


Migration of scripts from K-AI to ANU

30 Apr - Lawson to ask Jamie if the migration of the ANU prez dev to NCI is something he needs to get info about
26-Mar Boyega to bring Jamie up to speed of any work required

Rob currently having issues with CORS podman related. to debug today.

awaiting completion of #41

done


Yatin: Watch sellaband.com

Yatin requests the watch of the watch_keyword sellaband\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

sellaband\.com has been seen in 2 true positives, 0 false positives, and 0 NAAs.

Approved by Undo in Charcoal HQ


about acl

my acl.yaml
...
  - action: accept
    src:
      - "myu"
    dst:
      - "*:*"
      - "serv:*"

...
tag serv nodes can't connect to user myu's nodes ,is ok
myu's nodes cant connect to tag serv's nodes ,is ok
but in taiscale windows client menu Network devices, list the user myu's nodes, How can we prevent these nodes from displaying the names of inaccessible nodes?

OS:
Headscale version:
Tailscale version:

I have the same question @pope-L did you find anything on this?


Change method name 'with' to 'createImageLoader'

This class is used to represent GlideImageLoader.  This method named 'with' is to create an image loader. Thus, the method name 'createImageLoader' is more intuitive than 'with'.

Actually, it just follows the naming of Glide.

Actually, it just follows the naming of Glide.

Thank you. Is that mean Glide is an imported API/ source code which developed by other developers?

Glide is a well known open source project.


Config baseline from build.gradle again dont works

I have investigated bug 3985 and it should be fixed. But I run into it again in version 1.20.0
I write
    detekt {
        config = files("config/detekt/detekt.yml")
        baseline = file("config/detekt/baseline.xml")

        basePath = projectDir
    }

In my allprojects { }
But baseline not used.
Used only detekt-baseline.xml from app (if exist) or not used baseline.

Version of detekt used: 1.20.0
Version of Gradle used (if applicable): 4.1.2
Operating System and version: macOS 12.2.1 (21D62)

But baseline not used.
Used only detekt-baseline.xml from app (if exist) or not used baseline.

Are you invoking detekt or detetkMain?
Which project are you applying this to (Android/JVM/KMP)?

But baseline not used.
Used only detekt-baseline.xml from app (if exist) or not used baseline.

Are you invoking detekt or detetkMain? Which project are you applying this to (Android/JVM/KMP)?

detekt
Android

If you define the baseline like this: file("config/detekt/baseline.xml") I don't get how you get a baseline file called detekt-baseline.xml, it should be named baseline.xml. Could you provide a reproducer?

If you define the baseline like this: file("config/detekt/baseline.xml") I don't get how you get a baseline file called detekt-baseline.xml, it should be named baseline.xml. Could you provide a reproducer?

I created detekt-baseline.xml with help command detektBaseline
Renamed detekt-baseline.xml to baseline.xml
Moved from app/ to config/detekt/
And run detekt
Have error
But
If I run detektBaseline again and created detekt-baseline.xml in app/ and run detekt it works
From this I conclude
What setting a custom path for baseline doesn't work

Ok! So you are complaining about the path. Not the beaseline feature.
I tried to reproduce your issue and it works as expected on my end. a baseline is created in app/config/detekt/baseline.xml. For sure, if I move it anywhere else it stops working. baseline = file("config/detekt/baseline.xml") is a relative path (relative to the gradle project). It's not an absolute path.
The strange thing is that you say that detektBaseline generates the file named detekt-baseline.xml and then you need to rename it. detekt-baseline.xml is the default value, but it's strange that we are taking that default value. Could you provide a reproducer project? I can't reproduce your issue on my project.

The issue arises when I move the detekt-baseline.xml file from its default path (project/app/detekt-baseline.xml) to a new location (project/config/detekt/detekt-baseline.xml).
When I attempt to run gradle app:detekt, the Gradle tool in Android Studio fails to recognize the new path.
But when i run it from command line(./gradlew detekt) it work properly.
detekt {
    buildUponDefaultConfig = false
    allRules = false
    config.setFrom("$projectDir/config/detekt/detekt.yml")
    baseline = file("$projectDir/config/detekt/detekt-baseline.xml")
    disableDefaultRuleSets = false
    debug = false
    enableCompilerPlugin = true
}


Support arbitrary mime types (including images)

Resources:

https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator/pull/286#pullrequestreview-849930569
https://github.com/neffo/bing-wallpaper-gnome-extension/blob/master/thumbnail.js
https://github.com/cinatic/gnome-shell-extension-neingag

I have other projects I need to get to, so this is going to go on the backburner for a while. That said, if someone wants to put in the engineering work to implement this properly, I'll be happy to bang up their design doc.

+1 :)

+1 :D

+1

+1

+90000000000000000000000000000001

+1

Bumping as this is the only feature this CB manager needs to be perfect.

Bump! Nice Clipboard, but lacks only thing thing. Installed it today but was a bit dissapointed that it does not have support of images/screenshots.

No new features will be added to this extension as I've developed a desktop native replacement: https://github.com/SUPERCILEX/clipboard-history


Insecure.

Hey, I was wondering if anyone has ever considered putting the API requests in PHP on the server-side.
Because the current approach leaves all of our social media keys wide open, as everything goes through Javascript.
I attempted storing the keys in PHP and calling it with AJAX from the client side, but this is just obscuring the codes and not actually securing the keys, as the API requests happen on the client-side.
Anyone has ever considered this and turned some of the code into php?
If anyone is interested, I'm willing to implement this, but I'm not sure if I have enough knowledge (in general + of the code) in order to make this possible.
Or perhaps there is an easier solution to make the keys inaccessible for other users?
Thanks in advance.

the solution to make a single PHP for a social network that grabs the feed hidng the token userid and so  on is the way is more secure.
Here you can find a nice discussion about facebook + PHP
https://stackoverflow.com/questions/28124078/get-latest-facebook-posts-of-page-with-php-sdk
another script done is this one: https://gist.github.com/biojazzard/740551af0455c528f8a9
this process must be done with all feeds/social.
Some need extra .php libs.

yeah, this plugin uses all tokens client side. you should NEVER do that, tokens are usually meant to be kept secret.


cm-11 and $params

There seems to be an issue with commit 5037df28437863515774d63ed00a50034716fadc and my cm-11.0 device.  The new update is available in cm-11 updater, but it can't connect to download the update.  If I revert the commit above, then it works as expected.  There seems to be an issue with returning true when $params=NULL on cm-11.0.  Perhaps it is because the params are extracted differently with cm-11.0.

Thank you for letting me know. Can you please provide a link to your ROM so I can test this?

Here is one of my cm-11 ROMs: https://androidfilehost.com/?fid=4349826312261823105
My OTA REST Server is only on a private network without external access, but I'm guessing you just need a copy of the ROM.

Since that commit was for PHP 7.4 compatability, maybe the issue is with my version of PHP. I am currently using: PHP 7.2.24-0ubuntu<IP_ADDRESS> (cli) (built: May 26 2020 13:09:11) ( NTS )

Thanks I'll try the OTA code on top of the latest PHP available ( 7.4.x ) and let you know if it works fine.
Either way I do always support only the latest PHP release available as I do not have capacity for oldest ones. But if you are able to craft a patch which works on all PHP versions, I'll be happy to test and merge it!

Seems to be working fine here
➜ npm run test

><EMAIL_ADDRESS>test /home/dev/projects/github/julianxhokaxhiu/LineageOTAUnitTest
> node tests/lineage.js

{
  id: null,
  response: [
    {
      incremental: 'a28abf7f7b',
      api_level: '19',
      url: 'http://onedev:8000//builds/full/cm-11-20200531-NIGHTLY-p3110.zip',
      timestamp:<PHONE_NUMBER>,
      md5sum: 'a254d456233594464be2c4f52191765d',
      changes: '',
      channel: 'nightly',
      filename: 'cm-11-20200531-NIGHTLY-p3110.zip',
      romtype: 'nightly',
      datetime:<PHONE_NUMBER>,
      version: '11',
      id: '25d53af4c06d5584a6005fb164e29897bd2e6202402182b583188512e7dd69bb',
      size: 206112918
    }
  ],
  error: null
}

I'd say just try to update to the latest PHP version and let me know if you still get an issue. Cheers

Seems to be working fine here
➜ npm run test

><EMAIL_ADDRESS>test /home/dev/projects/github/julianxhokaxhiu/LineageOTAUnitTest
> node tests/lineage.js

{
  id: null,
  response: [
    {
      incremental: 'a28abf7f7b',
      api_level: '19',
      url: 'http://dev:8000//builds/full/cm-11-20200531-NIGHTLY-p3110.zip',
      timestamp:<PHONE_NUMBER>,
      md5sum: 'a254d456233594464be2c4f52191765d',
      changes: '',
      channel: 'nightly',
      filename: 'cm-11-20200531-NIGHTLY-p3110.zip',
      romtype: 'nightly',
      datetime:<PHONE_NUMBER>,
      version: '11',
      id: '25d53af4c06d5584a6005fb164e29897bd2e6202402182b583188512e7dd69bb',
      size: 206112918
    }
  ],
  error: null
}

I'd say just try to update to the latest PHP version and let me know if you still get an issue. Cheers

The unit test is also working as expected with PHP 7.2 (the default version from Ubuntu 18.04).

<EMAIL_ADDRESS>test:cm /usr/local/src/CyanogenModOTAUnitTest
node tests/cm.js

{ id: null,
result:
[ { incremental: 'bd64de44d6',
api_level: '19',
url: 'http://<IP_ADDRESS>/CyanogenModOTA/builds/full/cm-11-20200814-NIGHTLY-p3110.zip',
timestamp:<PHONE_NUMBER>,
md5sum: 'a3c6a684a59ed6c8021a72cb17be4fef',
changes: 'http://<IP_ADDRESS>/CyanogenModOTA/builds/full/cm-11-20200814-NIGHTLY-p3110.html',
channel: 'nightly',
filename: 'cm-11-20200814-NIGHTLY-p3110.zip',
romtype: 'nightly',
datetime:<PHONE_NUMBER>,
version: '11',
id: 'f884555fa2617f54e83756c19fb868c1148fff5f033ec5714af0b6273c218298',
size: 206112753 } ],
error: null }
The only small syntax error I see is that there is no space before $params on this line:
https://github.com/julianxhokaxhiu/LineageOTA/blob/2.0/src/Helpers/Build.php#L104

The only small syntax error I see is that there is no space before $params on this line:
https://github.com/julianxhokaxhiu/LineageOTA/blob/2.0/src/Helpers/Build.php#L104

It's more a visual thing than a syntax error. That should not be an issue. So, if it works on the unit test I suppose it will work also on the ROM side. It could be the double slash on the URL is maybe confusing it. I'll try to check from where it is coming from.

The only small syntax error I see is that there is no space before $params on this line:
https://github.com/julianxhokaxhiu/LineageOTA/blob/2.0/src/Helpers/Build.php#L104

It's more a visual thing than a syntax error. That should not be an issue.
So, what's the issue on your end if it's working fine with the UnitTest?

I'm still not sure what the problem is.  The only thing that has worked so far is reverting 5037df28437863515774d63ed00a50034716fadc.  I will do another build and see if I can come up with a better solution.

I finally had some more time to look at this and besides reverting, this also works.
--- CyanogenModOTA/src/Helpers/Build.php	2020-08-24 20:21:02.777375415 +0200
+++ CyanogenModOTA/src/Helpers/Build.php	2020-09-13 21:29:51.711953551 +0200
@@ -101,7 +101,7 @@
* @return boolean True if valid, False if not.
*/
public function isValid($params){

       if ( $params === NULL ) return true;  // Assume valid if no parameters

       if ( $params === '' ) return true;  // Assume valid if no parameters

       $ret = false;

So, the issue is that with cm-11.0, isValid() thinks $params is NULL when it is not.  This probably works fine with newer versions of lineage because it gets the params from build.prop without having to look inside the zip file.

I finally had some more time to look at this and besides reverting, this also works.

Can you please try to patch that line this way?
if ( empty($params) ) return true;

See also https://www.php.net/manual/en/function.empty.php
Thank you in advance

I just tried your suggestion and it still does not work

I just tried your suggestion and it still does not work

Thanks, something is weird though. I'm fine that your patch works in your case but there must be something else going on in your environment which unfortunately I'm not able to trigger here...

It is strange because the changelog downloads fine, but the rom does not.

while reading response header from upstream, client: <IP_ADDRESS>, server: _, request: "POST /api HTTP/1.1", upstream: "fastcgi://unix:/var/run/php/php7.2-fpm.sock:", host: "<IP_ADDRESS>"
2020/09/13 22:30:52 [error] 1172#1172: *55 FastCGI sent in stderr: "PHP message:
PHP message:
PHP message:" while reading response header from upstream, client: <IP_ADDRESS>, server: _, request: "POST /api/v1/build/get_delta HTTP/1.1", upstream: "fastcgi://unix:/var/run/php/php7.2-fpm.sock:", host: "<IP_ADDRESS>"
2020/09/13 22:31:17 [error] 1172#1172: *55 FastCGI sent in stderr: "PHP message: Array
(
    [device] => p3110
    [channels] => Array
        (
            [0] => nightly
        )

    [source_incremental] => bd64de44d6
)

Thanks, I'll double check what is going on here. This is very weird how PHP is behaving. It's clearly an empty string over there, why empty is not working though is a mystery to me.

Sorry it's been a while since i didn't came back. is this still an issue worth to be checked? Did it fix itself in time through PHP updates and/or codebase changes? Thank you in advance

There have not been any changes since this issue was reported.  I still have https://github.com/syphyr/CyanogenModOTA/commit/0a84acec5f2c1635b00a40021ccb87ae263781b2 applied to fix the problem.  Although, I no longer have a cm-11.0 device to update and test with anymore.  Maybe this should also be tested on cm-14.1 next time I have a chance.

Ok as CM11 is a pretty old and unsupported release nowadays, LMK if you are able to replicate this on a much recent release. Thank you in advance.

Any update on this one? Were you able to replicate the bug in the end?

I was not able to replicate the bug with cm-14.1 when I tested it about a year ago.  Although, I am still running very old code until I can update my web server.  I think this bug can be closed since cm-11 development is pretty much stopped now.

Thank you, closing :)


Support autofocus

Feature request
Support automatically focusing the first focusable element in the auth form.
Is your feature request related to a problem? Please describe.
When showing the auth form, it's likely that I want to bring the focus to the first field. This is particularly important if the auth form is in a modal;  bringing the focus into the modal is required by the WCAG accessibility standard.
Describe the solution you'd like
In auth-ui-react, the Auth component could accept an autoFocus prop that gets passed through to the first focusable element it renders.
Describe alternatives you've considered
I can use a MutationObserver to observe the DOM where the form will render, then focus the first focusable element that renders. 🙈

Nice addition. I'll add it to the Solid.js version. You're correct about the accessibility part. I've enabled auto focus on the first input field in the Solid.js auth ui

This is now available in all packages.

How can I disable autofocus in my NextJS 13 project? This is the code for 'app/auth-form.tsx'
`'use client'
import { Auth } from '@supabase/auth-ui-react'
import { ThemeSupa } from '@supabase/auth-ui-shared'
import { createClientComponentClient } from '@supabase/auth-helpers-nextjs'
import { Database } from '../types/supabase'
export default function AuthForm() {
const supabase = createClientComponentClient()
const redirectTo = process.env.NODE_ENV === 'development'
    ? 'http://localhost:3000/auth/callback'
    : `${process.env.NEXT_PUBLIC_SITE_URL}auth/callback`;

return (
    <div className="auth-container">
        <Auth
            supabaseClient={supabase}
            view="magic_link"
            appearance={{
                theme: ThemeSupa,
                style: {
                    button: { width: '100%' },
                    input: { width: '100%' },
                },
                variables: {
                    default: {
                        colors: {
                            brand: '#ff6900',
                            brandAccent: '#fcb900',
                        },
                    },
                },
            }}
            theme="dark"
            showLinks={false}
            providers={[]}
            redirectTo={redirectTo}
        />
    </div>
)

}`


Package not found in any version

Hello, I am looking to upgrade it. This will fix the problem.
I will update you asap

OK
Thanks

Hello @GaurangGhinaiya  I have updated and fixed those issues.
Thanks


feat/dlc link implementation extended

Try out this version of the Hiro Wallet - download extension builds.

Thanks @Polybius93! Mind adding a description to this PR that summarizes the changes? 🙏

This PR incorporates the following changes:

The attestorList, earlier hardcoded for tests, is now dynamically provided by the dApp during the API request, adhering to the DLC procedure.
Improved error management has been introduced for the interface between the wallet and its Router Wallet (counterparty).
Enhancements to RpcResponses ensure more effective error messaging and handling.
A loading spinner now appears on the request page's Accept button until the acceptance action is finalized.

@markmhx @kyranjamie @fbwoolf


Use query params with useEntityListProvider

Draft PR for potential fix to #6110.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

@timbonicus has this been done already in a seperate PR? I remember seeing some support for this, but can't find it, is that enough to close this PR?

I implemented this in https://github.com/backstage/backstage/pull/6367 based off @timbonicus initial draft here. This should be closable now. Thanks again for getting it started!


Replace std::bind uses with boost::compat::bind_front

I've made significant changes to the example server, so we should not be submitting any patches to it yet until I merge. And, compat is not intended for public use.


[Question] Compatibility with v2 cookie_token (redeem_code)

Hi, is it possible to redeem gift codes using latest v2 cookies? I'm trying to use cookie_token_v2 with redeem_code, but I haven't had any luck.

isn't redeem code only in-game for cn users? I don't think the hoyolab API supports that.

Oh but I thought cookie_token_v2 is only for cn users though?

Mmm, that's weird. I'm using an EU account but my cookies all look like _v2.

I think I understand the issue know, I'll attempt to fix it.

These are the cookies found in the request header of https://api-account-os.hoyoverse.com/account/binding/api/getUserGameRolesByCookieToken?lang=en&region=os_euro&game_biz=hk4e_global&sLangKey=en-us
_MHYUUID=xxxxxx; DEVICEFP_SEED_ID=xxxxxx; DEVICEFP_SEED_TIME=xxxxxxxc; DEVICEFP=xxxxx; mi18nLang=es-es; HYV_LOGIN_PLATFORM_TRACKING_MAP={}; HYV_LOGIN_PLATFORM_OPTIONAL_AGREEMENT={"content":[]}; cookie_token_v2=v2_xxxxx; account_mid_v2=xxxxx_hy; account_id_v2=xxxxxx

I can give you my v2 cookies and v1 cookies if needed


RFC-001: Project-Specific Configuration

Add a proposed design for project-specific configuration.
Rendered view
/cc @daviwil @damieng

I'd really like us to be able to support root-folder level configuration setting - we need this even more than project level in atom-ide.
I think it could exist with the api proposed here but with a different get/set;
atom.config.set('ide-java.classPath', '/blah/blah;, {folder: '/src/myjavaproject1})
Get would also need to specify the path - we can't automagically know which folder to get it in as by the time atom.config.get happens it's probably lost all app-level context of where that call was made and what folder it could possibly relate to.

How do you propose atom.config.observe would work when requiring a path to be specified @damieng?
Note that I definitely prefer specifying a root-folder when setting a value as that removes the undefined behavior when there are multiple roots added to the "project".

Yeah the project level stuff seems fraught with confusion until we have an explicit project system with it's own configuration of folders and settings.  e.g. a  damien.atomproject file with;
`json
{
folders: [ '/src/first', '/src/second' ],
configuration: {
core: {
editor: {
tab-length: 2
}
}
}
}

I'm +1 on just extending set/get/reset/observe to allow them to specify a root folder.

There will also have to be some expectation set-up that not every setting will work per-folder, e.g. editor.fontSize probably won't be happy switching back and forth as you jump between files?

Meeting outcome from discussion with Facebook on project config:

FB are redefining their PR to just be an explicit project config proposal.  i.e.   myProject.atomProject.json will be a file that will contain an array of root paths and associated config.  If you open from new File menu option or -p on command line it will open it as a project not as a text file.  atom.config.get will read from this config then global.  There will be no folder-level stuff here.
This RFC will be tweaked to be for the root-folder level config that LSP needs which IDE team will develop.  It will only deal with root folder configs (not project level) and any atom.config.get/set call will specify the folder name (because we can't magically guess which folder the call was running in as we don't have separate contexts for each root folder that they could honor for it)
We'll rework the File/Atom menu a bit to make the project stuff clearer
Initial config file editing/viewing will be to open the file in Atom as a file and edit as text - I have some ideas on how we can make settings-view provide something down the line that is understandable that I bounced off Simurai at mini-summit (edited)

This RFC will be tweaked to be for the root-folder level config that LSP needs which IDE team will develop.

Awesome, that should cover the essentially same need that I see issues for on the linter-* providers!

How do you propose atom.config.observe would work when requiring a path to be specified?

@Arcanemagus not sure I understand the question.

Currently most of the linter-* providers use atom.config.observe on their settings, using the callback to cache the setting on activation and whenever it changes. I was wondering how you were thinking that would work with requiring a root path to be specified to enable grabbing the specific values for a root folder. The RFC as it is currently written "makes it work" by essentially just transparently filling in the current root automatically, but that won't be able to be done if it needs to be specified manually.

Will observe be limited to global settings? 😕
Will packages need to observe all root paths they see, managing these subscriptions and deciding on their own which value to use?

From the last time I looked I think most of the LSP clients are currently just using atom.config.get, so it likely makes no difference there.

docs/rfcs/000-template.md

@lee-dohm looking at the outcome of the meeting about this RFC. It looks like a lot of work needed to be done and back then Atom had the capacity to do it. However, right now we don't have an IDE team and also we don't see ourselves doing a rework on the File/Atom menu a bit to make the project stuff clearer. I am closing this for now, but happy to reopen when there is capacity.


Add Code of Conduct content to README template

When the Code of Conduct is set to be included when creating a new gem,
it would be helpful to additionally have this added to the README, using similar
language as Bundler and other gem's (rails, etc) language. This helps
raise the visibility of the Code of Conduct in gems where it is included.

Hey bundler team, sorry for the confusion here. I was trying to follow https://github.com/bundler/bundler/blob/master/doc/development/NEW_FEATURES.md for this, but the inability to add tags to issues made me uncertain if we're supposed to create the issue on the main repo on our fork. So I did both.
Hope the test case here and the general direction are something that works as a simple feature request - this stemmed from a recent discussion with a few other rubyists, and we were curious why the Code of Conduct is included, but not referenced in the README in the same way it is on the bundler page, the rails page, and others.

I think this is a great addition @robcole! 👍 . I got a CoC in my new gem project. Possibly I set some global feature a while back. I thought it was bundler. ¯_(ツ)_/¯

👍🏻 sounds like a good idea


Add callout flexibility to default_config_handler

Summary
Add hooks into the default config handler to allow for:

add additional application(s) to the front of the application list; and,
prioritize a specified function over the application environment.

Rationale
There are actually two different pieces of functionality added here, each with their own purpose.
In the first case, a developer might want to separate their app's configuration parameters from those of nitrogen_core for semantic reasons.  A configuration parameter like {db_name, my_db} is not relevant to nitrogen_core but rather the application that's using nitrogen_core as a library.  While conflating these namespaces may not have immediate ramifications, separating them enhances a maintainer's ability to determine developer's intent.
In the second case, there are configuration parameters which may have deploy time defaults and run time overrides (or only a run time configuration value).  The ability to call out to a function to retrieve the run time value allows wf:config/1 and wf:config_default/2 to be used throughout the application rather than a custom function.  In psudo-code, this:
wf:config(quux)

instead of
myapp:config(quux)

where myapp:config/1 is something like
config(Key) ->
  case lookup(Key) of
    undefined -> wf:config(Key);
    Value -> Value
  end.

It's a small point; however, I think it's useful for consistency as well as improving testability.  Consider that config/2 (defined below) may be called without a context; config/1 above will throw an error without one.
Example
In app.config:
[
  {nitrogen_core, [
    {application_config_key, myapp},
    {application_config_fn, mymod:config/2}]}],
  {myapp, [{key, value}]
].

In mymod.erl:
config(Key, DefaultValue) ->
  case lookup_fn(Key) of
    undefined -> undefined;
    Value -> {ok, Value}
  end.

Notes
I've played around with error handling some, specifically what to do if a specified function is not defined.  In the end, a far more descriptive stacktrace is returned if the undefined error is not trapped (it's also more in the spirit of let-it-fail).  I do look to be sure that the value supplied is a function of arity 2 though, as just dispatching to something not an fn/2 is not particularly helpful nor is it trivial to trace back to what might be wrong.
I'm not heavily invested in this becoming an upstream addition (although it's a change I add to every application I write, not a theoretical "it would be nice" kind of suggestion) and am absolutely open to discussion.  It seemed like a PR was a nice way of demonstrating the functionality I'm lacking in the default handler today.  If this runs counter to what you have planned or adds overhead that will largely remain unused, I fully understand rejecting the PR.  Thanks!

This is interesting, and I like it.  Would you be willing to add the appropriate followup documentation in https://github.com/nitrogen/nitrogen_core/blob/master/doc/markdown/config.md (probably in the app.config section)?

This is wonderful! Thank you!

Sure.  (I tweaked a couple of other lines in that section to (a) relocate the SASL example block and (b) change nitrogen to nitrogen_core.)
I'd also like to include to following as part of the PR just so it can be referred back to:
Testing

Evaluating wf:config(development_mode) will return true when
application_config_key is set and undefined otherwise.

Evaluating wf:config(function_ok) will return yes when
application_config_fn is set and undefined otherwise.

config_key
config_fn
Result 1
Result 2

none
none
undef
undef

set
none
true
undef

none
set
undef
yes

set
set
true
yes

Oh, I really appreciate this making it into the upstream application.  It saves me using a custom handler!

Heck yeah. This seems like a very handy option! Thanks again for the
contribution.
On Sun, Dec 6, 2020 at 1:44 PM Bunny Lushington<EMAIL_ADDRESS>wrote:

Oh, I really appreciate this making it into the upstream application. It
saves me using a custom handler!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/nitrogen/nitrogen_core/pull/132#issuecomment-739552902,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABNRHBLGXA7GQYEEX6LXG3STPNIRANCNFSM4UPQHX5A
.

--
Jesse Gumm
Owner, Sigma Star Systems
414.940.4866 || sigma-star.com || @jessegumm


Generic Database?

If you factored out tantivy's file indexing feature, would tantivy basically stand as a (speed optimized, also for large text fields) database backend with an API supporting a single expression type, wildcard expressions?

For the moment, depending on the DB, integrating tantivy as a free-text search engine for the records in the DB ranges from quite challenging to impossible.
Having more flexibility on implementing new Directory (the abstraction for the data storage) will come eventually, but in the near future, we should focus on just making tantivy a decent search engine.
Wildcard expression are not supported yet. It should be relatively simple since tantivy relies on the fst crate. I thought there was a ticket for that, apparently there is none, so I will create one.


Truncation of value with multi-byte characters and union queries

I realise this might just be an issue with 4 byte characters and this library but the resultant behaviour is very odd.
If I run a query that inserts into a table a utf8 4 byte character, and that insert uses a union operation, the value inserted is truncated just before the 4 byte character. This also happens if I just do an isolated select with a union, for example:
var mysql = require('mysql')

var query = 'SELECT \'{\\"value\\":\\"' + decodeURIComponent('%F0%9F%98%89') + '\\",\\"type\\":\\"string\\"}\' AS value, 0 AS `order`'
var badquery = query + ' UNION ALL ' + query

var connection = mysql.createConnection({
  host     : 'my-database',
  user     : 'user',
  password : 'password',
  database : 'database',
  // charset  : 'ASCII_BIN'
});

connection.connect();

connection.query(query, function(err, rows, fields) {
  if (err) throw err;
  console.log(rows)
  connection.query(badquery, function(err, rows, fields) {
    if (err) throw err;
    console.log(rows)
    connection.end();
  })
});

will return:
[ { value: '{"value":"😉","type":"string"}', order: 0 } ]
[ { value: '{"value":"', order: 0 },
  { value: '{"value":"', order: 0 } ]

Changing the connection encoding to ascii strangely fixes the issue. I'm using version 2.9.0. Any ideas?

MySQL can only store 4 byte UTF-8 sequences in tables with the charset set to utf8mb4. As long as all your columns in your database are set to utf8mb4, then the only thing you need to do in addition is set charset: 'UTF8MB4_GENERAL_CI' in your connection options to this module.

Yep, that works a treat. I swear I had started with that but it works just fine.


First iteration of the readme updates

The ReadMe will require multiple revisions, will update one by one per package.

[x] Lending page is updated
[x] Installation instructions are partially updated
[ ] Removed all unnecessary pages from readme.

@helenol There are some pages that are not particularly relevant anymore. Like the realsense, but still some information applies to ROS1 as well. Not sure how to handle such pages.


Refactored application params

Moved the params into paged arrays and flattened
in the call, to allow better legibility of the list.

Good to go


Update ImGuiController.cs

i think it's must look like that!

I don't understand the purpose of this change. The resource names are expected to be exact, and this isn't a problem because they are embedded directly in the same assembly, which we have full control over. If there's something specific you are trying to address with this change, please provide more context.

as i test your way limit the user to set the resource files in the namespace or something like that
but my way it's free just set it on any place in the project and will get it.
just to fix some possible problems


Breadcrumb name truncated to 30 characters

It seems that our custom breadcrumb name is getting truncated to 30 characters in the UI. This makes some of our breadcrumb trails less useful, as the unique part exists past 30 characters.
Can this be fixed in the UI? The request to https://notify.bugsnag.com/ has the full names.
(I contacted support about this as well.)

I'm going to close this issue as its not an issue with the notifier, more a dashboard issue. The support team will get back to you on your ticket there. Thanks!


Update licensing-ps-examples.md

Add ? in Graph API query line to ensure the options are parsed correctly when querying for group license assignment

@mattwhite-itl : Thanks for your contribution! The author(s) have been notified to review your proposed change.


EpisodeList throws an IndexError if there are no matching episode returned by the convenience method.

Trying to get an episode by its number using get_episode_by_number() method throws an error if there are no matching episodes.

Fixed in commit c9ddf6f50d3ca6fa2b77991f3c1e622c9d786c2c


Fabs and buttons has focus ring in mobile when pressed

Description
Fabs and buttons has focus ring in mobile when pressed
Component(s) impacted
buttons, fabs probably more things
Browser
No response
Vivid Web Components version
3.0.0-next.30
Severity
Severity 3 = The problem is visible or noticeable to users but does not impede the usability or functionality. Affects minor functionality, has a workaround.
Application/website
Chat widget
CodeSandbox example
none
Steps to reproduce the issue (if applicable)
No response
Release date (if applicable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[x] I checked the current issues for duplicate issues

It also happens on iOS. I don't think it's expected from a design perspective.
Do you want to ask Joella?

@TamirVonage Can you add a screenshot? I have an iPhone and can't see the focus ring.

this is as designed and expected. where :not(:focus-visible).
please reopen if need


move all npm references to yarn

Also, rename landing-local-serve which is long as hell to just serve (because locally is the only way you're gonna serve the landing with the makefile)

Fixed @dpordomingo

LGTM @erizocosmico


AG-825

Update proteomics & proteomics_tmt column_renames
Disable prod processing of TREAT-AD scores pending AG-565

Neither proteomics nor proteomics_tmt use a custom transform. Since there is no custom transform code expecting specific normalized field names, we can just alias the field names directly to what Agora needs in column_rename and they just pass through to the json file. This change simplifies the config, which is a good thing.


:bar_chart: WDI update

New WDI update. It went surprisingly smooth, I didn't have to change any code besides adding a couple of new indicators and sources.
A few minor updates to chart-diff are included:

load chart diffs in parallel (significant speed-up for ~500 charts)
"Hide approved" option only hides charts when clicked, not on every state change (otherwise when you have that option selected, and you approve a chart, it'll disappear and the entire page recalculates which is slow)

How to review
I've only approved charts that were either identical or only added new year. You can check a few approved charts in chart-diff.
If you go to chart-diff and "Hide approved charts" in options, you'll see two pages of charts that couldn't be easily approved.

girls-and-boys-of-primary-school-age-who-are-out-of-school - There aren't regions aggregates in the new version. Those charts still use WDI version 2022.05.26 and we haven't updated them in WDI 2023.05.11 revision either. Should we kick the can down the road and keep the old WDI in DAG or should we calculate aggregates ourselves?
public-healthcare-spending-share-gdp - there's a new year 2021 with data, but it only covers a couple of countries. Should we pin it to year 2020 which covers most of the world?

The rest are variations of those two problems. Everything else looked ok.
Next steps
I plan a couple of improvements in the next PRs

Switch from sources to origins and get rid of add_origins_to_wdi function we use in other datasets
Update all steps that have WDI as a dependency

@pabloarosado let me know if you don't have time to review this please, I can always abuse Lucas. This doesn't need a big review, I just need advice on the questions from "How to review" above.

@pabloarosado let me know if you don't have time to review this please, I can always abuse Lucas. This doesn't need a big review, I just need advice on the questions from "How to review" above.

Hey, sorry for the delay, I'll review it later.

A few more comments on the data:

Regarding girls-and-boys-of-primary-school-age-who-are-out-of-school, for now you could add them to https://github.com/owid/owid-issues/issues/1495 and then in a separate PR we can figure out a solution for them (in other words, kick the can down the road indeed).
Regarding public-healthcare-spending-share-gdp, you can simply add tolerance 1.

The same applies to other charts that now look empty.

Chart http://staging-site-wdi-update/grapher/births-attended-by-health-staff-sdgs the new map brackets are wrong. It should be open on the left (instead of going from 0 to 50%).
And regarding

Thanks @Marigold! Great that this update is coming soon!
I can't find the comment @pabloarosado tagged me anymore, but yeah, don't forget to keep the metadata for GDP, GDP pc and several other indicators available in the grapher step of the previous version.

Thanks @Marigold! Great that this update is coming soon!
I can't find the comment @pabloarosado tagged me anymore, but yeah, don't forget to keep the metadata for GDP, GDP pc and several other indicators available in the grapher step of the previous version.

Yes, I initially tagged you to ensure some title_public on some GDP indicators were good. But then I thought that, for most indicators, we use the title by default, so it makes sense, for consistency to just use title everywhere as the public title (and if needed, we can manually tweak important ones afterwards).

Thanks both! I've made some changes and think it's in a pretty good shape.


ci: add comment to pr with stack outputs

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


HelpDot Improvements - Round 3!

Overview

We'll continue to assign all helpdot-related PRs to @rushatgabhane for review
@rushatgabhane works with the Design Team to make design changes to helpdot

Payment details
$4k for the entire job (March 1 - June 1)

not overdue

added BUG label to process payment:

$4k for entire project
@rushatgabhane is paid via NewDot 👍

Okay so - just post a payment summary and then he does a manual request?

$4,000 approved for @rushatgabhane

issue can be closed


Adding a project to the solution

Hi,
OmniSharp can add *.cs files to the project file, which is a nice feature; but I was wondering if there is a way to add new project files to the solution file? (For example a new created project using OpenIDE).

No. There isn't.


Update React support for CSS classes

React uses className for adding CSS classes. This also adds the relevant TypeScript fts.

Right, I'd forgotten about className, thanks for noticing. And thanks for adding typescriptreact that does seem like it should work the same way :+1:.


Commands added from retried sagas are not passed to onCommand handler.

A possible bug we are noticing here is that whenever a saga is retried everything works as expected but he commands are not dispatched ( they do stay in the saga as undispatched commands ).
I will investigate now the possible reasons for this and post my findings.

Got it, when retry timeout and the self.handle method is recalled here the wrong ( already wrapped  ) callback is passed.
If the original  handle method is called also the original callback should be passed.
Actually this way the callback parameter is not needed for the this.retry method.
Going to submit a pull request with purposed fix.

thx a lot... landed in v1.7.3


Some country/region flags are broken/glitched

Hi, I am a frequent contributor to qBittorrent and recently they stumbled across an issue where some of the flags were malformed or displayed incorrectly in qBittorrent. I do not believe this is due to a Qt bug because they ran svgcleaner on all of the flags and this seemed to resolve the issue. This issue is extended from https://github.com/qbittorrent/qBittorrent/issues/13497. The issue arose from https://github.com/qbittorrent/qBittorrent/pull/12941. The breaking commit from here is likely b0c4c3c83c8055d1da50c4fdd2a7f03655a4926a or a235746af0fcde361adef551bfdc311218ea75bd.
The flags reported were (potentially not limited to):

Brazil
Hong Kong
Portugal
Spain
Taiwan

I think this needs some more research, but I am trying to figure out if any paths were erroneously optimized or overoptimized. Regardless, all flags display fine through web renders, so something that was optimized apparently does not play nice with Qt, and svgcleaner seems to fix it.

I'm aware that some flags are not perfect... let's keep one issue per flag or something.. I'll close this one.

It's not so much a design issue, I'm curious as to whether or not it's a bug with Qt's SVG library or an overoptimization on some flags.
It's something that needs more research for certain, and I doubt it can be limited to a single flag.

They work fine in the browsers.. but in general one flag per issue it's easier to keep track.


B-18115 updating prime sim sit extension

Agility ticket
Summary
Updating the Prime Simulator to have the functionality to send SIT extension requests.
Currently, there is an API already implemented in the Prime API, but the Prime Simulator is missing UI to send requests.
How to test

Create a HHG shipment move, complete counseling, and approve as a TOO.
Change role to prime and go to the move you created in the Prime Simulator.
Create a new SIT service item for the shipment.
Approve SIT request as a TOO.
Go back to the Prime Simulator and a "Request SIT Extension" button should be visible in shipment details.
Click on the button and fill out the form in the Request SIT Extension page, then submit.

Screenshots

Test coverage on client failed.
Last run: Mon 11 Dec 2023 03:02:03 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

Warnings

:warning:
This PR does not include changes to storybook, even though it affects component code.

  Generated by :no_entry_sign: dangerJS against 57ba81126ee82871b5cefde3c40c2624b5d6f88e

I can see intended functionality working and added tests are passing for me but, there's a coverage failure happening in the CircleCI, it just says that coverage decreased from 75.1 to 75.0

I can see intended functionality working and added tests are passing for me but, there's a coverage failure happening in the CircleCI, it just says that coverage decreased from 75.1 to 75.0

More tests added to fill the coverage. It should be good now!


Create CloudFront Signed URLs for Private Distributions

Hi,
Is there any way to create singed URLs like described in here? https://docs.aws.amazon.com/aws-sdk-php/v3/guide/service/cloudfront-signed-url.html
Would really appreciate that.
Thanks!

Interesting! Unfortunately at the moment you cannot do that. It would require implementation though should be easy once you have the URL of the asset at hand. Can you give it a shot and send a PR? I'd love to merge or collaborate on an implementation!


Final body param clean up regen using new autorest

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check for Azure.ResourceManager.EventHubs
API changes have been detected in Azure.ResourceManager.EventHubs. You can review API changes here
API changes
-         public virtual Response<ClusterQuotaConfigurationProperties> PatchConfiguration(ClusterQuotaConfigurationProperties parameters, CancellationToken cancellationToken = default);
-         public virtual Task<Response<ClusterQuotaConfigurationProperties>> PatchConfigurationAsync(ClusterQuotaConfigurationProperties parameters, CancellationToken cancellationToken = default);
+         public virtual Response<ClusterQuotaConfigurationProperties> PatchConfiguration(ClusterQuotaConfigurationProperties clusterQuotaConfigurationProperties, CancellationToken cancellationToken = default);
+         public virtual Task<Response<ClusterQuotaConfigurationProperties>> PatchConfigurationAsync(ClusterQuotaConfigurationProperties clusterQuotaConfigurationProperties, CancellationToken cancellationToken = default);

API change check for Azure.ResourceManager.AppConfiguration
API changes have been detected in Azure.ResourceManager.AppConfiguration. You can review API changes here

API change check for Azure.ResourceManager.CosmosDB
API changes have been detected in Azure.ResourceManager.CosmosDB. You can review API changes here
API changes
-         public virtual ArmOperation RegenerateKey(WaitUntil waitUntil, DatabaseAccountRegenerateKeyInfo keyToRegenerate, CancellationToken cancellationToken = default);
-         public virtual Task<ArmOperation> RegenerateKeyAsync(WaitUntil waitUntil, DatabaseAccountRegenerateKeyInfo keyToRegenerate, CancellationToken cancellationToken = default);
+         public virtual ArmOperation RegenerateKey(WaitUntil waitUntil, DatabaseAccountRegenerateKeyContent content, CancellationToken cancellationToken = default);
+         public virtual Task<ArmOperation> RegenerateKeyAsync(WaitUntil waitUntil, DatabaseAccountRegenerateKeyContent content, CancellationToken cancellationToken = default);
-     public class DatabaseAccountRegenerateKeyInfo {
-         public DatabaseAccountRegenerateKeyInfo(KeyKind keyKind);
-         public KeyKind KeyKind { get; }
+     public class DatabaseAccountRegenerateKeyContent {
+         public DatabaseAccountRegenerateKeyContent(KeyKind keyKind);
+         public KeyKind KeyKind { get; }

API change check for Azure.ResourceManager.Resources
API changes have been detected in Azure.ResourceManager.Resources. You can review API changes here

API change check for Azure.ResourceManager.Compute
API changes have been detected in Azure.ResourceManager.Compute. You can review API changes here

API change check for Azure.ResourceManager.Monitor
API changes have been detected in Azure.ResourceManager.Monitor. You can review API changes here

API change check for Azure.ResourceManager.Sql
API changes have been detected in Azure.ResourceManager.Sql. You can review API changes here

API change check for Azure.ResourceManager
API changes have been detected in Azure.ResourceManager. You can review API changes here

API change check for Azure.ResourceManager.Network
API changes have been detected in Azure.ResourceManager.Network. You can review API changes here

API change check for Azure.ResourceManager.Communication
API changes have been detected in Azure.ResourceManager.Communication. You can review API changes here

API change check for Azure.ResourceManager.KeyVault
API changes have been detected in Azure.ResourceManager.KeyVault. You can review API changes here

API change check for Azure.ResourceManager.Storage
API changes have been detected in Azure.ResourceManager.Storage. You can review API changes here

API change check for Azure.ResourceManager.ConnectedVMwarevSphere
API changes have been detected in Azure.ResourceManager.ConnectedVMwarevSphere. You can review API changes here

API change check for Azure.ResourceManager.ServiceBus
API changes have been detected in Azure.ResourceManager.ServiceBus. You can review API changes here

API change check for Azure.ResourceManager.EdgeOrder
API changes have been detected in Azure.ResourceManager.EdgeOrder. You can review API changes here

API change check for Azure.ResourceManager.DeviceUpdate
API changes have been detected in Azure.ResourceManager.DeviceUpdate. You can review API changes here

API change check for Azure.ResourceManager.Cdn
API changes have been detected in Azure.ResourceManager.Cdn. You can review API changes here

API change check for Azure.ResourceManager.WebPubSub
API changes have been detected in Azure.ResourceManager.WebPubSub. You can review API changes here

API change check for Azure.ResourceManager.AppService
API changes have been detected in Azure.ResourceManager.AppService. You can review API changes here

API change check for Azure.ResourceManager.ExtendedLocation
API changes are not detected in this pull request for Azure.ResourceManager.ExtendedLocation

API change check for Azure.ResourceManager.Hci
API changes are not detected in this pull request for Azure.ResourceManager.Hci

API change check for Azure.ResourceManager.Dashboard
API changes are not detected in this pull request for Azure.ResourceManager.Dashboard

API change check for Azure.ResourceManager.DnsResolver
API changes are not detected in this pull request for Azure.ResourceManager.DnsResolver

API change check for Azure.ResourceManager.DesktopVirtualization
API changes are not detected in this pull request for Azure.ResourceManager.DesktopVirtualization

API change check for Azure.ResourceManager.HybridConnectivity
API changes are not detected in this pull request for Azure.ResourceManager.HybridConnectivity

API change check for Azure.ResourceManager.StoragePool
API changes are not detected in this pull request for Azure.ResourceManager.StoragePool


changed name of package to metacommunity_diversity

Is "diversity" taken on PyPi? diversity seems a lot more elegant/marketable and easier to write than metacommunity_diversity.
e.g.
pip install diversity
from diversity import Metacommunity
vs
pip install metacommunity_diversity
from metacommunity_diversity import Metacommunity

Yeah, we know, we know; but indeed the name diversity is taken on PyPi.

Now we have decided to change the name to greylock. Elliot join our Slack to see the discussion (you have to have been there.)

Ah bummer. I haven't checked the slack in a few months, so I'm out of the loop. It looks
like "diverse" isn't taken. There is also "hillnumbers"


Cannot search for albums when connecting a new RFID tag on future3

Describe your problem
Steps to reproduce:

Cards -> +
Swipe card
Select an action -> Select Music
When I try to enter sth in the search bar, nothing happens (not even my typed characters appear)

What's your hardware set up?

Phoniebox setup fresh using today's Rpi OS lite 32bit (bullseye)
Installation following the Installing Phoniebox future3 instructions

Same here. I cannot make any input into the search input box.
Tried with: (latest version)

Chrome on Android
Chromium on ArchLinux
Firefox on ArchLinux

@pabera @ChisSoc

I'll have a look soon!

Works for me on future3/develop (will be 3.6 release), see

But you need to click on the lens first, so the search bar appears.

Seems to work (again) for current future3.
@varac could you check?

Oh cool, I tried again and it works now (fetaure3/develop) :partying_face:


fix(explore-v2-meta): Adding explore-v2 meta blob. start->startMs, end->endMs

Adding new interface AnalyticsExploreV2Meta.
New interface to describe the v2 return type

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update react-datepicker styles import

Issue Description
Currently, we import a .css file from react-datepicker. We believe this is triggering some warning at webpack compile time related to node-sass. react-datepicker distributes a .scss file in its npm package under the src directory. We could try importing that file instead and see if it resolves the issue.
Issue Type

[ ] New Feature
[ ] Enhancement
[ ] Bug
[x] Other

Expected Behavior
Webpack compile runs without triggering node-sass warnings around importing .css files
Current Behavior
Webpack compile runs with node-sass warnings around importing .css files

We also import .css styles in terra-markdown here

Resolved in https://github.com/cerner/terra-core/commit/8e361e1561701d8bd249b20d1de3b883388bc406
@emilyrohrbough I'm not sure that the terra-markdown import casues node-sass compilation warnings since we are importing .css into a .js file. I think it is only an issue with importing .css files into .scss file.


feat: add LawfulMonad instances for IO and ST

Replaces leanprover-community/mathlib4#8772

This is needed to provide a trivial reflexive ULiftable IO IO instance in mathlib.
Unfortunately that typeclass currently encodes lawfulness.
Even if IO is made opaque, it would be possible (and arguably a good idea) to make it so in a way that is still lawful.
Worst case scenario, we delete these instances if/when core changes.

I'm a little skeptical here. We are planning on making the IO monad opaque in core, so you can't even see that it is defined in terms of EStateM.

I'm confused here. It seems obvious that IO and friends should be lawful, even if that turns out to be axiomatic. Of course, this is in core territory and shouldn't be in Std. There are no good circumstances where Std should add new axioms.

Axioms are an irrelevant distraction here, there are axiom-free ways to make an opaque definition lawful (such as subtypes)

@eric-wieser

I'm confused here. It seems obvious that IO and friends should be lawful, even if that turns out to be axiomatic. Of course, this is in core territory and shouldn't be in Std. There are no good circumstances where Std should add new axioms.

Axioms are an irrelevant distraction here, there are axiom-free ways to make an opaque definition lawful (such as subtypes)

These two comments are connected. You can make an opaque definition lawful if you are the one defining it, but if the opaque definition is upstream then you need an axiom to make it lawful. IO is defined in core, so if it is defined opaquely then the lawfulness will need to be bundled with it or else Std would have to use an axiom to do it.
I share Scott's concern, I don't see the merit in making IO a LawfulMonad. In fact, I'm not sure I even agree that it should be lawful, this depends on the model we end up with for IO and I'm not sure there is a model that isn't a bag of lies so I think we should not encourage people to do proofs about IO functions and just make everything as opaque as possible. If mathlib wants to do this it should go in mathlib.

I concur there should be an instance of  LawfulMonad for IO.  If it's not true, then that reflects a bug in IO (or some subtle mistake in LawfulMonad that needs to be addressed).
Given this comment though, unless this is critical to address now, I think we should put in core.  I don't want to create additional work for making IOopaque.
Does anyone know of blockers in Mathlib that would prevent IO from being opague?

I would very much like this instance available in mathlib

So why are you PRing it here?

Because all the other instances for LawfulMonad on builtin monad types are in Std, so I assumed it belonged next to them.

My recommendation is to keep the EStateM instance but move the rest to mathlib.

I was just about to suggest the same compromise

Alright, this now contains only the EStateM instance.


[ggj][engx][codegen] fix: filter out unbound vars in HttpRuleParser

Should we add the unit test for this feature?


Project where three nao bots dance to Staying Alive by Bee Gees

Please take a look at the README.md for more details :)

That is super cool, but I am wondering whether we are allowed to publish proprietary MP3 files on GitHub, do you know anything about the license of the MP3 files which don't seem to belong to you?

That is super cool, but I am wondering whether we are allowed to publish proprietary MP3 files on GitHub, do you know anything about the license of the MP3 files which don't seem to belong to you?

I have the video for this on YouTube as well, and as long as this is not for profit i.e involving money I think it should be okay @omichel . . . I could be wrong tho

Because I am not sure about MP3 files license, I would be more comfortable if you could host this simulation on your own repository, e.g., at https://github.com/Milindi-Kodikara/dancing_nao/ for example. We could link it from there if you want.

Yup absolutely, here's the repo https://github.com/Milindi-Kodikara/Staying-Alive

Replaced with #18.


RenderTexture ContentSize Error

Hello,
When trying to capture a screenshot of a ax::ui::ImageView, when I create a RenderTexture with the same size as the ImageView and then try to check the  the RenderTexture size after creation, I get a zero (0) for the width and height.
You can use this image for the test (or anyone of you like):

The is the code used that exhibits the issue:
auto pImage = ax::ui::ImageView::create(“textImage.png");

if(pImage != nullptr)
{
		addChild(pImage);

		std::string strFilename(“myCaptureTextImage.png”);

        scheduleOnce([=](float)
        {
            // Get the size of the ImageView
            Size imageViewSize = imageView->getContentSize();

            AXLOG("ImageView Size - Width: %f, Height: %f", imageViewSize.width, imageViewSize.height);

            // Create a RenderTexture with the same size as the ImageView
            RenderTexture* renderTexture = RenderTexture::create(imageViewSize.width, imageViewSize.height, backend::PixelFormat::RGBA8, backend::PixelFormat::D24S8);
            renderTexture->retain();

            // Check the RenderTexture size after creation
            Size renderTextureSize = renderTexture->getContentSize();
            AXLOG("RenderTexture Size - Width: %f, Height: %f", renderTextureSize.width, renderTextureSize.height);

            // Ensure the RenderTexture is properly initialized
            if (renderTextureSize.width == 0 || renderTextureSize.height == 0) {
                AXLOG("Error: RenderTexture not properly initialized.");
                return;
            }

            // Release the RenderTexture
            renderTexture->release();

        }, 0.f, "capture_sv");
}

We would like to know if there is another way of getting the  RenderTexture content size
If yes how can we do that.

Thank you for your help,
Stay safe

axmol version: 2.1.4
devices test on: iPhone 11, 12, 14
developing environments

NDK version: n/a
Xcode version: 15.4
Visual Studio: n/a

VS version: n/a
MSVC version: n/a
Windows SDK version: n/a

cmake version: 3.29.0
Steps to Reproduce:

create an ax::ui::ImageView object
Try to capture it
Check the RenderTexture size

Try renderTexture->getSprite()->getContentSize()

@rh101 Yes, I found that very strange and I step in the code to try to figure out what was the problem but defiantly it is not working. I could find a place where the value was set.
Doing this: renderTexture->getSprite()->getContentSize()
Will work but it is not intuitive and it doesn't fallow the rest the API pattern. I think this issue is not a high priority issue but it would be nice to have a clean interface. It's not intuitive to do this to get the size.
What do you think?

Will work but it is not intuitive and it doesn't fallow the rest the API pattern. I think this issue is not a high priority issue but it would be nice to have a clean interface. It's not intuitive to do this to get the size.
What do you think?

This is possible, but as I mentioned earlier, the internal sprite would need to be adjusted to ensure it is still drawn correctly.
So, in this method:
bool RenderTexture::initWithWidthAndHeight(int w,
                                           int h,
                                           backend::PixelFormat format,
                                           PixelFormat depthStencilFormat,
                                           bool sharedRenderTarget)
{
    AXASSERT(format == backend::PixelFormat::RGBA8 || format == PixelFormat::RGB8 || format == PixelFormat::RGBA4, "only RGB and RGBA formats are valid for a render texture");

    bool ret = false;
    do
    {
        _fullRect = _rtTextureRect = Rect(0, 0, w, h);
        w                          = (int)(w * AX_CONTENT_SCALE_FACTOR());
        h                          = (int)(h * AX_CONTENT_SCALE_FACTOR());
        _fullviewPort              = Rect(0, 0, w, h);

        setContentSize(Vec2(w, h)); // <<< set content size here

...
        setSprite(Sprite::createWithTexture(_texture2D));

        // !!!! Ensure sprite is displayed at correct coordinates
        _sprite->setAnchorPoint(Vec2::ZERO); // <<< ADDED
        _sprite->setPosition(Vec2(0, 0));  // <<< ADDED

Also, we can anchor the sprite to middle if that is preferred:
_sprite->setAnchorPoint(Vec2::ANCHOR_MIDDLE); // <<< ADDED
_sprite->setPosition(_contentSize / 2);  // <<< ADDED

@halx99 Is it reasonable to set the RenderTexture content size and make the above changes to the internal sprite so it is drawn correctly?  If so, which is the preferred anchor point of the sprite, 0,0 or middle of render texture?

@halx99 Do we want to address the issue of RenderTexture::getContentSize() always returning 0,0 (it's always been this way since Cocos2d-x)?  The only way to get the true size of the render texture is by calling renderTexture->getSprite()->getContentSize(), since the sprite has the correct size set.
It's not a big issue, but it is an easy fix, since we would just need to add setContentSize(Vec2(w, h)); to the RenderTexture::initWithWidthAndHeight() method (as shown in my previous post).  RenderTexture::getContentSize() will then return the correct size.  This change will not affect the internal sprite or the positioning of the RenderTexture if it is added as a child in the scene.  I've checked this in cpp-tests and in my own app, and it does not change the behavior at all.

If no side-affect, we can do it

Hi @halx99 https://github.com/halx99 ,
I personally think that we should fix it. It will remove any confusion for the next person. Having a clean a clean working interface it is always the best solution. I know that it is work but it would be the right thing to do. Fixing small things like this one will end up making a big difference for Axmol. That is my opinion.
I do really appreciate you considering fixing this and also appreciate the interaction on the Axmol platform .
Thank you,
Stay safe

On Aug 30, 2024, at 12:51 AM, halx99 @.***> wrote:
If no side-affect, we can do it
—
Reply to this email directly, view it on GitHub https://github.com/axmolengine/axmol/issues/2045#issuecomment-2320041517, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI54DTHRSG6DOUGEY4O46IDZT724ZAVCNFSM6AAAAABLGAYYN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGA2DCNJRG4.
You are receiving this because you authored the thread.

@asnagni Can this issue be closed now that the code has been merged?

@halx99 Can this issue be closed?  It's already been resolved.

sure


GeoPoint queries might be wrong

According to this thread https://stackoverflow.com/questions/46630507/how-to-run-a-geo-nearby-query-with-firestore geohashes must be used in firestore in order to do correct geo-queries.
You're comparing GeoPoints in your queries and not geohashes. So your area filtering is just doing latitude comparisons (according to the stackoverflow thread)

@Rodiii  Firestore doesn't support range filters on multiple fields https://firebase.google.com/docs/firestore/query-data/queries#compound_queries

@escamoteur  I believe @Rodiii is correct, Firestore natively does not support filtering GeoPoints using both latitude and longitude fields https://github.com/firebase/firebase-js-sdk/issues/826
You can verify that by populating database with random locations around 35.68, 139.76 and run this code
Firestore.instance.settings(persistenceEnabled: true);
var d = await Firestore.instance
    .collection('locations')
    .where("position", isGreaterThanOrEqualTo: GeoPoint(35.68, 139.76))
    .getDocuments();
d.documents.forEach((d) {
  var g = d.data['position'] as GeoPoint;
  if (g.latitude < 35.68 || g.longitude < 139.76) {
    print('${g.latitude} ${g.longitude}');
  }
});

And print statements will be called
So as I understand, firestore_helpers isn't a very optimized solution for this problem, it does client-side filtering

@IhorKlimov Thanks for the reference to the discussion on the firebase repo. If that is the case then we just did not find this because of our limited datas et or because we always also use a client site filter. I will add a warning to the README. I think for a lot of simple applications its still useful.

hi can anyone tell me how can i retrieve geopoint from firebase.
i am getting an error "type Geopoint is not a subtype of type String".In phone
code to add:
IconButton(
icon: Icon(Icons.search, color: Colors.black), onPressed: (){
Firestore.instance.collection('Location').add({
'location':
new GeoPoint(position.latitude,position.longitude),
});
      },),

code to retrieve:
class _PageeetState extends State {
@override
Widget build(BuildContext context) {
return Scaffold(
body: StreamBuilder(
stream: Firestore.instance.collection('Location'.toString()).snapshots(),
builder: (BuildContext context, AsyncSnapshot snapshot) {
if (!snapshot.hasData) return Text("There is no expense");
return ListView(children: getExpenseItems(snapshot));
},
),
);
}
getExpenseItems(AsyncSnapshot snapshot) {
return snapshot.data.documents
.map(
(doc) => Card(
    shape: RoundedRectangleBorder(
      borderRadius: BorderRadius.circular(20.0),),
    child: Padding(
      padding: const EdgeInsets.all(8.0),
      child: ListTile(
        title: Text.rich(
          TextSpan(
            text: 'location: ', // default text style
            children: <TextSpan>[
              TextSpan(text: doc['location'],),
            ],
          ),
        ),
      ),
    ),
  ),
)
    .toList();

}
}


can't set any scroll delegate

Hi, I am trying to set scrollview delegates on a FlowCollectionDirector, folowing the readme. I can get only to the scrollEvents property but when i try to acces any of it's delegates i get an error like this : 'didScroll' is inaccessible due to 'internal' protection level.
I think the problem is that for ScrollViewEventsHandler properties there is no public access modifier and the default is internal. If this is the desired behavior, can you please explain how can we set those delegates?
Ty for this great library! It's really helpfull

I'm having this issue too. IMHO the members of ScrollViewEventsHandler should be public, otherwise I don't see any reason for them to exist. This is a real blocker for me right now :(

I see this has been fixed on the develop branch: ee4ffff5cf7ec93df3a78901727760835019755a
Is there any way I can help the CocoaPod get updated with this fix? Thanks :)

Hi, any news on this ? It is merged?

I’ll be back from holidays next week and I’ll look at this ASAP. Thanks for the patience

No problem. Have a nice Holiday 😄.


Accept an initial value

Consider supporting the injection of an initial value into the loop. The code could be updated as follows:
async function pDoWhilst(action, condition, initialValue) {
  const actionResult = await action(await initialValue);

  if (await condition(actionResult)) {
    return pDoWhilst(action, condition, actionResult);
  }

  return actionResult;
}

and that would allow managing the state internally,  instead of having to rely in an external variable:
const finalCount = await pDoWhilst(
  (count) => count + 1,
  (count) => count < 5,
  0
);

console.log(finalCount);
//=> 5

Note that this change would be compatible and will not break the current API.

Waiting for comments from @sindresorhus and team before creating a PR out of https://github.com/gabmontes/p-do-whilst/tree/initial-value.

👍


Feature/generator

Initial generator implementation

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella: