Flutter 1.8.2 Connection to emulator breaks

After upgrading to Flutter 1.8.2, i.e. Channel master, v1.8.2-pre.33, I cannot view logs on Android emulator API 28 anymore.
E/DartVM  (15034): Unrecognized response: null
E/DartVM  (15034): #0      new Response.from (dart:_vmservice/message_router.dart:70:7)
E/DartVM  (15034): #1      Message._setResponseFromPort (dart:_vmservice/message.dart:244:29)
E/DartVM  (15034): #2      Message.sendToVM.<anonymous closure> (dart:_vmservice/message.dart:216:7)
E/DartVM  (15034): #3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
E/DartVM  (15034):
E/flutter (15034): [ERROR:flutter/runtime/dart_isolate.cc(814)] Unhandled exception:
E/flutter (15034): Unrecognized response: null
E/flutter (15034): #0      new Response.from (dart:_vmservice/message_router.dart:70:7)
E/flutter (15034): #1      Message._setResponseFromPort (dart:_vmservice/message.dart:244:29)
E/flutter (15034): #2      Message.sendToVM.<anonymous closure> (dart:_vmservice/message.dart:216:7)
E/flutter (15034): #3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)

After startup, this error is printed to logs and then Lost connection to device.
I cannot use API 29, because of #33050, meaning that this prevents me from debugging.
Is there a way I can fix this on my end?
(I am using Channel beta now, however, I would really like to use master again.)

Same problem.
Steps to Reproduce
Click the run button on Android Studio
flutter run is no problem for me.
Logs
Lost connection to device.
E/DartVM  ( 6730): vm-service: Error: Unhandled exception:
E/DartVM  ( 6730): Unrecognized response: null
E/DartVM  ( 6730): #0      new Response.from (dart:_vmservice/message_router.dart:70:7)
E/DartVM  ( 6730): #1      Message._setResponseFromPort (dart:_vmservice/message.dart:244:29)
E/DartVM  ( 6730): #2      Message.sendToVM.<anonymous closure> (dart:_vmservice/message.dart:216:7)
E/DartVM  ( 6730): #3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
E/DartVM  ( 6730):
E/flutter ( 6730): [ERROR:flutter/runtime/dart_isolate.cc(814)] Unhandled exception:
E/flutter ( 6730): Unrecognized response: null
E/flutter ( 6730): #0      new Response.from (dart:_vmservice/message_router.dart:70:7)
E/flutter ( 6730): #1      Message._setResponseFromPort (dart:_vmservice/message.dart:244:29)
E/flutter ( 6730): #2      Message.sendToVM.<anonymous closure> (dart:_vmservice/message.dart:216:7)
E/flutter ( 6730): #3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
Failed to send request: {"jsonrpc":"2.0","id":"4","method":"streamListen","params":{"streamId":"Extension"}}
Failed to send request: {"jsonrpc":"2.0","id":"5","method":"getVM","params":{}}
Failed to send request: {"jsonrpc":"2.0","id":"6","method":"getVM","params":{}}

flutter doctor -v
[√] Flutter (Channel master, v1.8.2-pre.33, on Microsoft Windows [Version 10.0.18932.1000], locale zh-CN)
    • Flutter version 1.8.2-pre.33 at D:\flutter
    • Framework revision e3ee5c6bbb (13 hours ago), 2019-07-13 16:02:09 -0700
    • Engine revision 919e353236
    • Dart version 2.5.0 (build 2.5.0-dev.1.0 24725a8559)

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at D:\Android\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-Q, build-tools 28.0.3
    • Java binary at: D:\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2017 15.9.11)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2017\Community
    • Visual Studio Community 2017 version 15.9.28307.586

[√] Android Studio (version 3.4)
    • Android Studio at D:\Android\Android Studio
    • Flutter plugin version 37.0.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[√] VS Code (version 1.36.0)
    • VS Code at C:\Users\Yaerin\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.2.0

[√] Connected device (3 available)
    • xiaomi 6 • emulator-5554 • android-x86    • Android 5.1.1 (API 22)
    • Windows  • Windows       • windows-x64    • Microsoft Windows [Version 10.0.18932.1000]
    • Chrome   • chrome        • web-javascript • Google Chrome 75.0.3770.100

• No issues found!

Same issue - definitely a bug, started to appear after today's Flutter upgrade.

I'm having the same thing. Hot reload stops working and you have to run from cold to update the app in an emulator

same issue

Same here
[√] Flutter (Channel master, v1.8.2-pre.56, on Microsoft Windows [VersiÃ³n 10.0.17134.228], locale ca-ES)
• Flutter version 1.8.2-pre.56 at C:\src\flutter
• Framework revision 90326b6184 (3 days ago), 2019-07-12 09:46:48 +0530
• Engine revision d1dcd18486
• Dart version 2.5.0 (build 2.5.0-dev.1.0 24725a8559)
[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at C:/Users/josep.albert/AppData/Local/Android/Sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• ANDROID_HOME = C:/Users/josep.albert/AppData/Local/Android/Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.

same issue

Yes, I am also facing the same issue, simulator and android studio gets disconnected.

For everyone that is also experiencing this issue: you should really upvote the original post, i.e. the first comment in here, which will improve the rank of this issue in sorting as commenting the same things over and over only clutters this thread.

Took a quick look at this.
I am able to reproduce the issue on MacOS with IntelliJ IDEA. Running the app from the IDE on a simulator fails.
Using git bisect narrowed it down to #36000 which is flutter/engine#9767, flutter/engine#9727, and a src/third_party/dart roll from 09fc76bc51..24725a8559

@bkonyi It looks like the VM service is hitting an exception.

@bkonyi It looks like the VM service is hitting an exception.

Yeah, the Flutter Intellij plugin is still trying to use _registerService instead of registerService in one place. See https://github.com/flutter/flutter-intellij/issues/3670.
cc/ @devoncarew

same here

Yes, I am also facing the same issue, simulator and android studio gets disconnected.

I am facing this issue

same issue

I have the same issue.

E/flutter (22542): [ERROR:flutter/runtime/dart_isolate.cc(814)] Unhandled exception:
E/flutter (22542): Unrecognized response: null
E/flutter (22542): #0      new Response.from (dart:_vmservice/message_router.dart:70:7)
E/flutter (22542): #1      Message._setResponseFromPort (dart:_vmservice/message.dart:244:29)
E/flutter (22542): #2      Message.sendToVM. (dart:_vmservice/message.dart:216:7)
E/flutter (22542): #3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
Lost connection to device.

For me i am running the flutter app on a physical Android Device but the app is working fine without a Crash but the Hot Reload Feature isn't working.

Same issue. Not working on my physical device or emulator, not even on Pie emulators

Downgraded to v1.8.1, and it worked!

Downgraded to v1.8.1, and it worked!
But I get a long list of these errors/warnings every second
Failed to send request: {"jsonrpc":"2.0","id":"3144","method":"getVM","params":{}}

How do I downgrade .. I really need to

Downgraded to v1.8.1, and it worked!
But I get a long list of these errors/warnings every second
Failed to send request: {"jsonrpc":"2.0","id":"3144","method":"getVM","params":{}}

How do I downgrade .. I really need to

git checkout v1.8.1
And then flutter doctor

Thanks for the reports; we have a fix for this in the Flutter IntelliJ plugin, and should have a new release out w/the fix today.

Downgraded to v1.8.1, and it worked!
But I get a long list of these errors/warnings every second
Failed to send request: {"jsonrpc":"2.0","id":"3144","method":"getVM","params":{}}

Just downgraded now getting that long list too.

Let us know when you have a fix in the plugin! @devoncarew

The Flutter plugin for IntelliJ and Android Studio has been updated to work with Flutter channel master, v1.8.2-pre.46.

The Flutter plugin for IntelliJ and Android Studio has been updated to work with Flutter channel master, v1.8.2-pre.46.

But it's not working now.

Haven't upgraded Flutter yet, but upgraded Flutter plugin on Android Studio 3.5 Beta and atleast these errors vanished!
Failed to send request: {"jsonrpc":"2.0","id":"3144","method":"getVM","params":{}}

Still on v1.8.1, but upgraded Flutter plugin on Android Studio 3.5 Beta and atleast these errors vanished!
Failed to send request: {"jsonrpc":"2.0","id":"3144","method":"getVM","params":{}}

why it is always generated, can anybody explain ?

You should only have seen this issue with the previous version of the Flutter IntelliJ and Android Studio plugin when on the flutter master branch. Upgrading your Flutter plugin to 37.1.x (by checking for updates) should address the issue.

Still on v1.8.1, but upgraded Flutter plugin on Android Studio 3.5 Beta and atleast these errors vanished!
Failed to send request: {"jsonrpc":"2.0","id":"3144","method":"getVM","params":{}}

I think you can upgrade now, I just did and everything is fine.

Same issue. Android Studio v3.4.1 with Flutter 35.1.3 on macOS 10.14.5

did anyone fix this issue ??
i get this issue today...

did anyone fix this issue ??
i get this issue today...

Since this was an issue with the flutter-intellij plugin, I would start by updating to the latest version of the plugin. If that is still not working you can file an issue in their issue tracker with details on your IDE setup: https://github.com/flutter/flutter-intellij/issues


[Repo] SSL Cert for https://johtru.com/repo/repo_files/ is expired

not much else to say, kodi currently crashes when trying to query the repo

I'll renew the cert ...
Kodi really crashes? If so, you should submit an issue to kodi too.

will do when it's confirmed working with a valid cert.
Have not properly checked it's due to the certificate.

on a related note, if you need help with that, i'd be happy to...

sorry for the delay...
The certificate is now renewed!


Gitrob finishes with findings but doesnt show results

well problem i am facing is that when gitrob finishes its scan. it says it found repositories and files and co but when the scan is done and i want to go through the findings nothing is responsive

same with me
i got this problem :)

@prosecurity @dzhenway Could you provide any further details such as screenshots or additional comments. What do you mean by nothing is responsive are you using the web interface or the commandline interface? I can't replicate this. Can you try with the latest release of this fork.


Pressing enter doesn't work when searching for a book

Describe the Bug 🐛
Hey! I noticed it while testing your app. Pressing enter redirects the user to another path. Searching only works when you manually click on search.
To Reproduce
Steps to reproduce the behavior:

Go to search page
Type a book or author
Press enter
After pressing enter, it doesn't actually search for the book but rather redirects the user to another path

Expected behavior
After pressing enter, it should also search for the book.
Screenshots
Pressing enter redirects me to this page:

Additional context
Can I take over in solving this issue? Thanks! @wasimreja

It works fine, I tried
`

@chaaals go ahead

@chaaals go ahead

thanks! please assign this issue to me <3

@wasimreja heyy, thanks for merging my change! I just noticed that labels in your repo has a typo. Instead of hacktoberfest , you  entered hactoberfest

I don't think we should console.log('working') and book list in console


gopls: 0.4.0 -> 0.4.1

Motivation for this change
Long list of fixed issues in gopls. I don't want to toot the LSP horn too much but since this is a development tool, every editor wins.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 87876 1

1 package built:
- gopls


Expose object ids in some form to the user

Inevitably, the fact that we use object ids under the hood is going to leak out into how the UI works.
For example, consider the following sequence of actions.
Create an object called "A"
Create an object called "B"
Create a morphism "foo : A -> B"
Rename "B" to "A"
Rename "A" to "B"
This works very cleanly in our current design; we end up with "foo : B -> A" as one might wish. However, the reason why this works is not exposed, so it's kind of surprising that it actually works.
I think there should be some kind of indicator of the object ids so that the user can learn a correct mental model. One option for this would be to show the object id in a tooltip when hovering over any reference to that object.
Related to this, two features that might be nice are:

Jump to definition from a use of an object id
Highlight all uses of an object id

From conversation with Evan: one step towards this is to give any "resolved name" a colored and bordered background, similar to how github shas are styled or inline code is styled. The color could then be dependent on the UUID.

A related question: should we then allow the sequence of actions:
Create an object called "A" [it's colored red]
Create an object called "A" [it's colored blue]
Create a morphism "foo: A[red] -> A[blue]"
Change the blue A to B
Or, should we just yell at the user if they try to give two objects the same name? And indeed, wouldn't that be a potential resolution of this issue that avoids revealing the existence of the UUIDs? I kind of feel like revealing them is going to be more potentially confusing than helpful for a lower-info user and it's not obvious to me that it's really "inevitable" that the existence of IDs has to leak.


Focus on question input when applicant clicks on question from review screen

Description
Per accessibility recommendations, when an applicant clicks on a question from the application review screen, we want the focus to be set explicitly on the input for the question they clicked on. This PR adds that functionality.
Checklist
General

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release | database >
[x] Created unit and/or browser tests which fail without the change (if possible)
[x] Performed manual testing (only on Chrome because Firefox interacts poorly with tab order)

Instructions for manual testing

Create and publish a program with multiple questions on a single screen
As an applicant, click "apply"
Turn on a screen reader
From the program summary screen, click on any question
The cursor should land you on the input for the question you clicked on and the screen reader should start reading from that question
You should also see two params in the url questionName and questionType

https://github.com/civiform/civiform/assets/24319951/5d471f5e-2ac2-4353-8a19-fa56f5fb56bd
Issue(s) this completes
https://github.com/civiform/civiform/issues/3571

I think the focused element needs to have some love. It's very difficult to see which one has the blue border color. If we're going to have it be more dynamic it should be much easier to tell where my cursor is.

@gwendolyngoetz agreed about the focus element needing some more love. Is it alright with you if I make an issue for that and address it in another pr?


capture page render wrong text

hi, i'm trying to use casperjs captures the website, but all chinese chars show errors.
html code eg:
...
<input type="submit" id="su" value="百度一下" class="bg s_btn">
...

result page:
http://0.1.fox.pantimos.com/data/c4ca4238a0b923820dcc509a6f75849b/1450334604557/index.html

can i use casperjs with special font?
Thank you.

If it fails with the plain PhantomJS engine version you use, it fails in CasperJS, too.
Try using a different engine and/or engine version (current CasperJS master supports PhantomJS 1.9.1 through 2.0.0 and some SlimerJS versions experimental / without cli support).
Robust font-face / WebFont support is available as of PhantomJS 2.0.0 (this was the main reason for me to promote CasperJS support for 2.0.0).

But i use PhantomJS v2.0.0(both OSX and Ubuntu) & Casperjs at latest...
/** I guess the problem is cause by the CJK font. **/

Ok, seems you're out of luck... CasperJS can't fix such problems in the underlying engine(s).
If you have a look at what Chrome (linux) does, you will notice that:

baidu uses arial
Chrome renders the missing glyphs using Droid Sans Fallback

So if PhantomJS would support a similar fallback, it could work for you. Maybe you should try if SlimerJS supports a fallback out-of-the-box. The only workaround for you would be to hack in on the CSS and mimic the fallback using a webfont version of Droid Sans Fallback.

@istr thank you for your reply , : )

@istr there's a easy way to solve this problem:
just try to apt-get install fonts-droid on Ubuntu server.
And report it at https://github.com/ariya/phantomjs/issues/10249#issuecomment-166203957
Thank you.

We should clearly document somewhere that PhantomJS might need external libs / fonts, even though they promote "static build" for binaries that are not really standalone:
ldd bin/phantomjs-1.9.6
	linux-vdso.so.1 =>  (0x00007ffc5f9bb000)
	libfreetype.so.6 => /usr/lib/x86_64-linux-gnu/libfreetype.so.6 (0x00007fbded3dd000)
	libfontconfig.so.1 => /usr/lib/x86_64-linux-gnu/libfontconfig.so.1 (0x00007fbded1a0000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fbdecf9c000)
	librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fbdecd94000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fbdecb75000)
	libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fbdec871000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fbdec56b000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fbdec354000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fbdebf8f000)
	/lib64/ld-linux-x86-64.so.2 (0x0000562606dd9000)
	libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fbdebd76000)
	libpng12.so.0 => /lib/x86_64-linux-gnu/libpng12.so.0 (0x00007fbdebb4f000)
	libexpat.so.1 => /lib/x86_64-linux-gnu/libexpat.so.1 (0x00007fbdeb925000)

There are some more issues connected to having a "not-so-very-static-binary" in PhantomJS.

@istr You're right.


Add playwright support

Looks good to me, but, does this work ok with the other testing PR?

Yeah it does!


s3rver does not initialise CORS when being added as middleware

This is unavoidable since initialization is async, but as of v3.2.0, calling S3rver#configureBuckets before starting the HTTP server should be an acceptable workaround.


Improve typeahead text for slash commands

As discussed on CZO, we should remove examples from the slash-command typeaheads, and change the text to:
/poll (Create a poll)
/todo (Create a collaborative to-do list)
/me (Action message)

CZO thread

@zulipbot claim

@zulipbot claim

@zulipbot claim

Hey @alya, in my previous Pull Request was flagged as having conflicts because I changed a test file, so I reverted the changes I made to that file, but now one of the required checks fails because the test file has previous typeaheads. Can you please guide me on how to solve this issue?

You need to adjust tests as required to solve the issue, and resolve any conflicts that arise in a way that makes sense.

Created PR #27788, which will resolve this issue. @alya could you please review it? And do let me know if any changes needed.

@alya, Could you please review PR #27810? It has only one commit.

I want to work on this issue. Please assign it to me.

@zulipbot  claim

@zulipbot claim

@zulipbot  Claim

@zulipbot claim

@zulipbot unclaim

@zulipbot claim


Start/End Time with hours in double digits causes error

For some reason, the moment I set the start or end time to be 10:00:00 or higher, an error occurs. For example, the following works ok:
  step_evening_study_off_name: Evening Lights Off
  step_evening_study_off_start: 09:00:00
  step_evening_study_off_end: 09:40:00
  step_evening_study_off_off_1: light.ensuite

As soon as I save the file with the following increase in hours to double digits, the error below occurs:
  step_evening_study_off_name: Evening Lights Off
  step_evening_study_off_start: 09:00:00
  step_evening_study_off_end: 10:40:00
  step_evening_study_off_off_1: light.ensuite

Error:
2018-03-30 11:54:25.267428 WARNING AppDaemon: ------------------------------------------------------------
2018-03-30 11:54:25.268396 WARNING AppDaemon: Unexpected error running initialize() for Occupancy Simulator
2018-03-30 11:54:25.269287 WARNING AppDaemon: ------------------------------------------------------------
2018-03-30 11:54:25.271477 WARNING AppDaemon: Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/appdaemon/appdaemon.py", line 1513, in init_object
    init()
  File "/home/homeassistant/conf/apps/occusim.py", line 32, in initialize
    self.create_events({})
  File "/home/homeassistant/conf/apps/occusim.py", line 68, in create_events
    end = self.parse_time(end_p)
  File "/usr/local/lib/python3.5/dist-packages/appdaemon/appapi.py", line 277, in parse_time
    return self.AD.parse_time(time_str, name)
  File "/usr/local/lib/python3.5/dist-packages/appdaemon/appdaemon.py", line 1015, in parse_time
    parts = re.search('^(\d+):(\d+):(\d+)', time_str)
  File "/usr/lib/python3.5/re.py", line 173, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or bytes-like object

2018-03-30 11:54:25.272501 WARNING AppDaemon: ------------------------------------------------------------

I'm running Home Assistant on Hassbian with the following versions:
HA: 0.65.5
AppDaemon: 3.0.0
Occusim: 1.1.5
appdaemon.yaml:
log:
  # accessfile: /export/hass/appdaemon_test/logs/access.log
  errorfile: /home/homeassistant/conf/log/occusim_err.log
  logfile: /home/homeassistant/conf/log/occusim.log
  log_generations: 3
  log_size: 1000000
appdaemon:
  threads: 10
  # time_zone: <time zone>
  api_port: 5000
  plugins:
    HASS:
      type: hass
      ha_url: http://localhost:8123
      ha_key: !secret home_assistant_pass

apps.yaml - as you can see most steps work ok because their times are below 10:00:00, yet any that are 10 or above cause the error.


MSID: 92841 Version: 2 DOI: 10.1101/2<IP_ADDRESS>96534

MSID: 92841
Version: 2
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>96534
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=92841
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>96534

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/92841v2
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>96534
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/92841/v2/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

warn: [title-upper-case] Content of  element is entirely in upper case: Is that correct? 'IHC'

need to rerun workflow


update Cloud Run timeout parameters

We are still using agents for our jobs and need this timeout increased to match Google's job specs.
Example

Screenshots

Checklist

[ ] References any related issue by including "Closes #" or "Closes ".

If no issue exists and your change is not a small fix, please create an issue first.

[ ] Includes tests or only affects documentation.
[X] Passes pre-commit checks.

Run pre-commit install && pre-commit run --all locally for formatting and linting.

[ ] Includes screenshots of documentation updates.

Run mkdocs serve view documentation locally.

@desertaxle this is something that my team could really use to be merged before agents are deprecated, as we do not see a path to upgrade to workers as viable. can I get a review on this?

Thanks for the PR @jeremy-thomas-roc! The reason the timeout for the CloudRun infrastructure block is capped at 1 hour is because that block uses the Cloud Run V1 API which has a max timeout of 1 hour. Unfortunately, updating the max on our end will not increase the timeout limit above an hour.
Do you mind sharing why an upgrade to workers is not viable for your team? We might be able to make enhancements to the Cloud Run workers that would make an upgrade viable.

@desertaxle I see, that is unfortunate. We will have to continue using Vertex for our backend for the foreseeable future then.
I have detailed our issues with workers in a thread on Discourse: https://discourse.prefect.io/t/switching-from-agents-to-workers-in-a-monorepo/4024

Thank you for your willingness to contribute to prefect-gcp! The code for this library has been moved to https://github.com/PrefectHQ/prefect/tree/main/src/integrations/prefect-gcp. Please reopen this PR there if this functionality is still needed!


Mistake in .babelrc

In .babelrc the env is nested in presets array.
I think it is a mistake. this is the .babelrc file i got with vue-webpack template.
{
  "presets": ["es2015", "stage-2"],
  "plugins": ["transform-runtime"],
  "comments": false,
  "env": {
    "test": {
      "plugins": [ "istanbul" ]
    }
  }
}

when i tried to use the bootstrap-switch in webpack a babel transpile error was thrown:
Couldn't find preset "env" relative to directory
can someone check this....

ES2015 is a bit old should be using babel-preset-env

Actually it looks like vue-webpack is out of date. There should be a nested env config

thank you for your answer.
can you suggest any way to solve the following error when using with vue-webpack
Couldn't find preset "env" relative to directory

npm install --save-dev babel-preset-env

vue-webpack won't be referring to the babelrc in this project

Thanks installing babel-preset-env solved my problem.

vue-webpack won't be referring to the babelrc in this project

I know but i can't find where it is trying to get preset "env"


SQLSTATE[HY000]: General error: 2006 MySQL server has gone away

How do you use Sentry?
Sentry SaaS (sentry.io)
SDK version
4.1.1
Steps to reproduce
laravel/framework                      v6.20.44               The Laravel Framework.
laravel/horizon                           v3.7.2                 Dashboard and code-driven configuration for Laravel queues.
sentry/sentry-laravel                 4.1.1                  Laravel SDK for Sentry (https://sentry.io)

Jobs on HORIZON
Expected result
Jobs finishes without any issue, and looking at DB no failed_job and the code looks that have worked successful but we received the issues on sentry.
Actual result
SQLSTATE[HY000]: General error: 2006 MySQL server has gone away (SQL: select * from table_x where id = 123 limit 1)
Here apparently I have the same false positive with laravel-sentry related in the issue below:
https://github.com/laravel/horizon/issues/583#issuecomment-2020910963

carbonphp/carbon-doctrine-types           2.1.0                  Types to use Carbon in Doctrine
doctrine/annotations                      1.13.2                 Docblock Annotations Parser
doctrine/cache                            2.1.1                  PHP Doctrine Cache library is a popular cache implementation that supports many different drivers such as redis, memcache, apc,...
doctrine/collections                      1.6.8                  PHP Doctrine Collections library that adds additional functionality on top of PHP arrays.
doctrine/common                           3.2.0                  PHP Doctrine Common project is a library that provides additional functionality that other Doctrine projects depend on such as ...
doctrine/deprecations                     v0.5.3                 A small layer on top of trigger_error(E_USER_DEPRECATED) or PSR-3 logging with options to disable all deprecations or selective...
doctrine/event-manager                    1.1.1                  The Doctrine Event Manager is a simple PHP event system that was built to be used with the various Doctrine projects.
doctrine/inflector                        2.0.8                  PHP Doctrine Inflector is a small library that can perform string manipulations with regard to upper/lowercase and singular/plu...
doctrine/instantiator                     1.4.0                  A small, lightweight utility to instantiate objects in PHP without invoking their constructors
doctrine/lexer                            1.2.3                  PHP Doctrine Lexer parser library that can be used in Top-Down, Recursive Descent Parsers.
doctrine/persistence                      2.2.3                  The Doctrine Persistence project is a set of shared interfaces and functionality that the different Doctrine object mappers share.

all those packages are used here

maybe could be the versions of doctrine packages.

Try Adjusting your MySQL wait_timeout and max_allowed_packet settings to be more forgiving for long-running jobs or ensure your application keeps the connection alive. Or if you realize that its a sentry problem then exceptions reported by Sentry are not indicative of actual problems in your application, you can configure Sentry to ignore these specific exceptions.

I still think this issue is not triggered by Sentry just captured and reported.
Thanks @joeljohn135 for chipping in, you hit it right on the nose and if you feel like you can safely ignore it you can check out the options we have for filtering and exclude the exception from being reported.
If you still feel like Sentry is somehow causing this I would love to check that out but I need a little more information and a reproduction case, this is a non-standard Laravel setup I have no experience with so a repoduction helps getting to the root of the issue if there is any.
But long story short I don't think it's reasonable that the Sentry SDK causes this issue.

I've updated horizon configurations with explicit retry_after and updated the package sentry, apparently the erros has gone.
sentry/sentry                              4.6.1                  PHP SDK for Sentry (http://sentry.io)
sentry/sentry-laravel                      4.4.0                  Laravel SDK for Sentry (https://sentry.io)


event

on:click can not be used at Map component

I suppose you should be able to use the events listed here: https://docs.mapbox.com/mapbox-gl-js/api/map/#map-events
For example, in the script section of the example in the README you could use:
mapComponent.on('click', (e) => { console.log(e.lngtlat); })


Change name from BubbyClient-Fabric-1.16 to BuggyClient-Fabric-1.16

no

no

are you afraid of the truth?

are you afraid of the truth?


inputmask overwrites the jquery.val function

Hi,
First of all these are my mask options;
element.inputmask( {
alias: "numeric",
rightAlign: true,
autoUnmask: true,
digits: "0"
} );
After masking operation I set the value of the element by jquery val() function to zero ("0"). But your library catches the blur event and reset the element to "" (empty) in writeBuffer() method of your library.
Will you please suggest me a way to set the value of the masked element programatically.
Yours sincerely.
Onur

"Google 41.0.2272.118 m" is the version of  my browser.

Hacky solution :
1- remove the mask by inputmask("remove")
2- set the value using element.val()
3- set the mask by inputmask( {
alias: "numeric",
rightAlign: true,
autoUnmask: true,
digits: "0"
} );
But there should be a more convenient way of doing these kind of operations ????

@feralanPaladin ,
This seems related to #786

duplicate of #786


Fix Navbar jumping on media query

Issue
The navbar has weird behavior at the cutoff of xl screen size
Before:
https://github.com/steven-tey/precedent/assets/7266179/f376ce02-fc8e-4ba2-afac-a40c8d13c5e1
After:
https://github.com/steven-tey/precedent/assets/7266179/87cf3825-8a39-4a1d-8b88-5e28427fdf37

Thank you for the PR and the detailed writeup!


Getting error with simple example code from docs

Hello!
Is this repo's code still up to date with the API or do I miss some package? I get an error but I am not sure what's going on.
I'm getting the error below, when testing with an example from your docs. My example code is this:
from instahashtag import api

def io():
    """Uses 'requests' to send requests."""

    tag = api.tag(hashtag="instagram")
    graph = api.tag(hashtag="instagram")
    maps = api.maps(
        x1=-80.48712034709753,
        y1=25.750749758162012,
        x2=-79.82794065959753,
        y2=25.854604964203453,
        zoom=12,
    )

io()

The error is the following:
Traceback (most recent call last):
  File "/Users/michael.Steudter/Documents/pythonExperiments/displaypurposes/test.py", line 16, in <module>
    io()
  File "/Users/michael.Steudter/Documents/pythonExperiments/displaypurposes/test.py", line 6, in io
    tag = api.tag(hashtag="instagram")
  File "/Users/michael.Steudter/Documents/pythonExperiments/displaypurposes/venv/lib/python3.9/site-packages/instahashtag/api.py", line 43, in tag
    return http.Requests.tag(hashtag=hashtag)
  File "/Users/michael.Steudter/Documents/pythonExperiments/displaypurposes/venv/lib/python3.9/site-packages/instahashtag/http.py", line 103, in tag
    return obj.call()
  File "/Users/michael.Steudter/Documents/pythonExperiments/displaypurposes/venv/lib/python3.9/site-packages/instahashtag/http.py", line 133, in call
    return self.process(resp)
  File "/Users/michael.Steudter/Documents/pythonExperiments/displaypurposes/venv/lib/python3.9/site-packages/instahashtag/http.py", line 93, in process
    return json.loads(resp)
  File "/Applications/Xcode_14_1.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/Applications/Xcode_14_1.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/Applications/Xcode_14_1.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

ok sorry, it seemed to have been an issue with my VPN setup.

Got it working now. The generated token was wrong.
I just grabbed the original methods from the JS file you can find when using Firefox' inspector. The methods were mangled but when searching for "api-token" the right ones are easily found.
Then I just copied all the needed methods 1:1 into one .js file. As I'm using Swift, I'm just importing this file there and executing the JS function without caring to rewrite any of it.


Add support for channel.subscription.gift

Feature Request

The channel.subscription.gift subscription type sends a notification when a user gives one or more gifted subscriptions in a channel.
See https://dev.twitch.tv/docs/eventsub/eventsub-subscription-types#channelsubscriptiongift-beta

Will be part of the upcoming 4.6.0 release.


Update vitest.config.ts

Codecov Report

Merging #1 (3eeeda5) into master (829ceba) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           34        34
  Branches         3         3
=========================================
  Hits            34        34

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Create webtorrent library!

Create webtorrent library for C/C++,C# and others languages!

Thanks for the suggestion. The right way to do this is to add support for webtorrent to a library like libtorrent.

ok


Make it explicit that the page-fault exceptions from address translation correspond to the original access type, as is done for access exceptions.

It is implicit, but being more explicit seemed better.

What do you think about making this change for the first sentence only?  It is pretty verbose.

On 15:39 Wed 21 Mar, Andrew Waterman wrote:

What do you think about making this change for the first sentence only?  It is pretty verbose.

Sure.  It would be good to make the treatment consistent for access
exceptions and page-faults.  Perhaps a single line about both before
the enumerated steps, and omit the qualifications inside the
enumerated steps?

Yeah, let’s see how that looks. Thanks!

@aswaterman  any opinion on how it looks?

After comparing them, I prefer your first version :) I've merged it.  Thanks.


S3 folder structure possibly wrong

Hey, @allada thanks for your excellent work on this repo.
I've been using the GETH client for quite a long time, and it becomes harder to maintain due to its size.
I've been running some tests with Erigon for the past week and I need a full archival node with the whole chain data since the genesis block, and I thought about using your snapshot to speed thing up. However, I noticed something "wrong" with the s3 folder structure or maybe I'm misunderstanding something.
Within the s3://public-blockchain-snapshots/bsc/erigon/archive/latest/v1/nodes/ there are like 19 levels of /nodes under it. Is this really expected? I mean, there's like s3://public-blockchain-snapshots/bsc/erigon/archive/latest/v1/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/.

Yeah that's an error. But the nodes database is not required, it only holds info about previously connected clients and ip info.
-------- Original Message --------
On Feb 7, 2023, 12:17 PM, Eric Ferreira wrote:

Hey, @.***(https://github.com/allada) thanks for your excellent work on this repo.
I've been using the GETH client for quite a long time, and it becomes harder to maintain due to its size.
I've been running some tests with Erigon for the past week and I need a full archival node with the whole chain data since the genesis block, and I thought about using your snapshot to speed thing up. However, I noticed something "wrong" with the s3 folder structure or maybe I'm misunderstanding something.
Within the s3://public-blockchain-snapshots/bsc/erigon/archive/latest/v1/nodes/ there are like 19 levels of /nodes under it. Is this really expected? I mean, there's like s3://public-blockchain-snapshots/bsc/erigon/archive/latest/v1/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/nodes/.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Hmmm. So in this case, if I want to build a node from scratch, the only things I'd need to make good use of this snapshot are the /snapshots, parlia, and chaindata dirs?

Exactly... The node directory is only to make resuming a sync slightly faster, so it doesn't need to spend as much time finding nodes.
-------- Original Message --------
On Feb 7, 2023, 12:29 PM, Eric Ferreira wrote:

Hmmm. So in this case, if I want to build a node from scratch, the only things I'd need to make good use of this snapshot are the /snapshots, parlia, and chaindata dirs?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

Awesome. Thank you!


[Feature Request] Form validation + transform: sanitized value not propagated back to model

Existing Component
Yes
Component Name
Form
Description
Consider the following form validation rule:
rules: {
	email: [
		{
			required: true,
			whitespace: false,
			transform(value) {
				return value.trim();
			},
			trigger: 'validate'
		},
	]
},

During form validation, the trimmed value is not assigned back to the underlying model.
Is it possible to assign it back to ensure the sanitized value is also applied to the original model?

closed in favor of #19736


Repo sync for protected CLA branch

The pull request is created from privateToPublic-push-CLA-reviews637609934896998304 to privateToPublic-push-CLA-reviews to fix git push error for protected CLA branch

Docs Build status updates of commit 5ff8125:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch privateToPublic-push-CLA-reviews637609934896998304 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Wrong Results using tpr, tnr, fpr, fnr

Hi,
I using the metrics (fpr, fnr, tpr, tnr) for my model in Keras (Tensorflow.python keras v2.1.2) as you can see:
model.compile(loss='categorical_crossentropy',
optimizer='adam',
metrics=['binary_accuracy', tpr, tnr, fpr, fnr])
But running this with history = model.fit_generator(..) am getting the accuracy on tpr and fpr; and 1-acc for tnr and fnr. For debugging I returned also the outputs of the contingency_table and tp=tn = all true predicitons and fp=fn = all false predicitons.
Do you have any suggestions how to fix this issue and get the right values? Thanks in advance!

The problem with Keras metrics is that they are computed for each batch and averaged on the fly. Consider a metric computed as A/B. If the denominator B is the same for all the batches (which is the case for accuracy), then the average across batches is the same as the metric computed across the whole dataset. Hower, of B varies across batches, then the average of batch metrics is not the same as the global metric.
Can you compute your metrics using
from concise.eval_metrics import *
y_true = model.predict(x)
tpr(y_true, y_pred)
....
fpr(y_true, y_pred)

and print those as well as the metrics you obtain from fig_generator?

Thanks a lot for the fast reply.
"The problem with Keras metrics is that they are computed for each batch and averaged on the fly. Consider a metric computed as A/B. If the denominator B is the same for all the batches (which is the case for accuracy), then the average across batches is the same as the metric computed across the whole dataset. Hower, if B varies across batches, then the average of batch metrics is not the same as the global metric." - total agree. But my goal is to have a metrics with the contingency table.
I could not compute the metrics in model.compile() using the code from concise.eval_metrics.

For model.compile you should use the metrics from concise.metrics and for the evaluation of the prediction you should use metrics from concise.eval_metrics. The reason is that the former have to be implemented with Keras functions.

Thanks a lot. I used these functions in 'model.compile'. But the issue is, that the tpr and tnr are similar as you can see below. For testing I used just a small data set, but the values should distinguish more.
Epoch 1/3
62/62 [==============================] - 108s 2s/step - loss: 0.7520 - binary_accuracy: 0.6280 - tpr: 0.6280 - tnr: 0.6280 - val_loss: 2.5995 - val_binary_accuracy: 0.4271 - val_tpr: 0.4271 - val_tnr: 0.4271
Epoch 2/3
62/62 [==============================] - 28s 459ms/step - loss: 0.6160 - binary_accuracy: 0.6845 - tpr: 0.6845 - tnr: 0.6845 - val_loss: 0.9102 - val_binary_accuracy: 0.4870 - val_tpr: 0.4870 - val_tnr: 0.4870
Epoch 3/3
62/62 [==============================] - 27s 439ms/step - loss: 0.5802 - binary_accuracy: 0.7016 - tpr: 0.7016 - tnr: 0.7016 - val_loss: 1.6536 - val_binary_accuracy: 0.4818 - val_tpr: 0.4818 - val_tnr: 0.4818

Solved the issue:
I set my  data set to a categorical class mode with to classes, so the values were one hot encoded. Applying K.argmax() y and y_pred is solving the issue.

Good-day, Hope you are well, @tommysft I would like to ask how you accessed the tpr and tnr in the model.compile line of code. I also have a binary classification problem, however I am having a hard time getting the tpr and tnr. I used the code "model.compile(optimizer = 'adam', loss = 'binary_crossentropy', metrics = ["accuracy", "tpr", "tnr"])"


Credential should be scoped to a valid region

Hi,
I tried to run
this code:
try:
res = Orders().get_orders(CreatedAfter=(datetime.utcnow() - timedelta(days=7)).isoformat())
print(res.payload)  # json data
except SellingApiException as ex:
print(ex)
the error I get is [{'message': "Credential should be scoped to a valid region, not 'us-east-1'. ", 'code': 'InvalidSignature'}]
I also tried to change region but the error is the same:
[{'message':** "Credential should be scoped to a valid region, not 'eu-central-1'. ", 'code': 'InvalidSignature'}]
Can you help me?

The valid region for EU marketplaces is 'eu-west-1', see the docs.
If you want to call an EU marketplace, you'll also need to pass marketplace to Orders:
Orders(marketplace=Marketplaces.DE).get_orders(CreatedAfter=(datetime.utcnow() - timedelta(days=7)).isoformat())

Does that work for you?

The valid region for EU marketplaces is 'eu-west-1', see the docs.
If you want to call an EU marketplace, you'll also need to pass marketplace to Orders:
Orders(marketplace=Marketplaces.DE).get_orders(CreatedAfter=(datetime.utcnow() - timedelta(days=7)).isoformat())

Does that work for you?

It worked! Thanks!

It worked! Thanks!


Upload does not work

This page says: Beginning with the October 2018 release of Power BI Desktop, you can publish composite models to the Power BI service. For scheduled refresh and dashboard tile refresh, composite models in the Power BI service behave in the same way as Import models.
But when I try to upload a pbix file with a simple composite model (two direct query sources without any relationships between them and where reports only pull from one source or the other), it fails:
Unsupported preview feature
The Power BI service currently doesn't support datasets with composite models because it's a Power BI Desktop preview feature.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1dffd6b4-434b-868e-56fe-a0f53fb655a1
Version Independent ID: 894f109f-c20b-c9f3-0e42-f6980d454075
Content: Use composite models in Power BI Desktop - Power BI
Content Source: powerbi-docs/desktop-composite-models.md
Service: powerbi
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thanks for your comment, @jordanmills and apologies you're running into this trouble. Have you updated your version of Power BI Desktop? This looks like a support request rather than documentation feedback. You might find a solution in the Power BI Community, found at https://community.powerbi.com. If not, you can get support by going to https://support.powerbi.com.

Can't even wait a couple of hours for confirmation before rushing to close the pesky work-generating issue?  I wish I could get away with delivering that level of service.
I'm running the latest version of power bi desktop (2.64.5285.741 64-bit (November 2018)).  I'm not sure how that is relevant though.  You create a pbix file, then go upload it to the web site, and it gives the noted error.  It's not like there's a whole lot that can change about the process.
The documentation is wrong.  Again.  Apparently this isn't the first time this non-feature has been incorrectly included in this document.


Added Fibonacci series in java

Assigned Issue Number ?
#120 here
Language Opted ?
Java
Number of files added or updated ?
1
Name of these files ?
Alogorithm=>FibonacciNumbers.java
Checklist

[x] I've read the contribution guidelines.
[x] I've referred the correct issue number.
[x] I've fill up this entire template correctly.

Hi, kindly review the PR, and please tell if I have to change it any way.


Update to babel-eslint@6

Needed for ESLint 2.

Going to close this as @gingur is updating the dependencies in #29


Fix #68: Do strict testing for null | undefined on selected

This PR addresses #68 by changing the following line:
https://github.com/Elius94/console-gui-tools/blob/6e68febe7cfa364b236d48f7ec110e1fe41fd2d1/src/components/widgets/OptionPopup.ts#L79
to
https://github.com/Compositr/console-gui-tools/blob/abd0ee04aa859e74864d7e5a2cf47276fa3b8f91/src/components/widgets/OptionPopup.ts#L79
        if (selected === undefined || selected === null) throw new Error("OptionPopup selected is required")

This strictly checks for null | undefined fixing the behaviour described in #68

Super!!!!


fix(chart): disable resource name hashes at chart level

Fixes #1037
Added an disableResourceNameHashes property to ChartProps which is set to false by default. If set to true, then all resources inside of a chart will no longer have the hash value suffixed on their resource names.
Created a test called "disabling resource name hashes at chart level" in test/chart.test.ts to verify these changes are working.
This fix should also apply to this issue requesting documentation about name generation.

Also, I see DCO check if failing for this PR.

💚 All backports created successfully

Status
Branch
Result

✅
1.x

Questions ?
Please refer to the Backport tool documentation


S does not keep indentation

First thank you very much for this project, it is lovely to be able to use the vim keybindings in XCode.
I'm not sure if this issue might be reported already (a bit difficult to figure out the right search terms) or if I'm misunderstanding the functionality (maybe there is some option that is necessary).
Normally when using vim's S command to substitute a line, it seems to also keep the indentation.
For example:
func foo() {
    some garbage text here<CURSOR HERE>
}

Pressing S should clear out the line and start editing at the right level of indentation like this:
func foo() {
    <CURSOR HERE>
}

What happens instead:
func foo() {
<CURSOR HERE>
}

Using o to open and start editing a new line seems to handle the indentation correctly.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28241307-s-does-not-keep-indentation?utm_campaign=plugin&utm_content=tracker%2F252770&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F252770&utm_medium=issues&utm_source=github).

Duplicate of https://github.com/XVimProject/XVim/issues/769.  If someone finds a fix for this, that'd be awesome.

Hi, I make some change in #906, try that and tell me if it works. :smiley:


Set a max refresh rate

If vsync isn't enabled, the game loop will currently run as fast as possible, which is pointless since game state updates are fixed at 60Hz. Setting the loop to max out at a high refresh rate (e.g. 300Hz) would let vsync do its thing but prevent overusing resources when it's not available.

Alternatively, maybe only draw if there has been an update?

Fixed in 8fa8cf0fbc415476a04f1f2cb454a92cbfe8fe01, 2f3be4e330b085a106fb15e491e911d3dc6c76bd, a94a7e47591abfdd0f96a2b8596b974a8f8892d2, ea74a566e23e21d2078837b9b1b5d9b025377399.


Paranets not syncing

Issue description
My paranet accoss multiple nodes is not syncing, the assests continue to rise but are never stored on any node. This was working but stopped last night (no changes by myself). I even tried a paid RPC but that didnt fix the issue
Expected behavior
Actual behavior

Steps to reproduce the problem

I spun up a fresh VPS to check which is the screenshots and it never syncs

Specifications

Node version: 8.1.0+beta.12
Platform: Ubuntu 22
Node wallet: 0x29E85183d402cb959f2E426114c75Dcc67FDc14B
Node libp2p identity: 21

Error logs
root@ottest:~# journalctl -u otnode | grep "new assets for paranet: did:dkg:base:84532/0x"
Oct 24 10:11:33 ottest node[13654]: [2024-10-24 10:11:33] INFO: {Operation ID: ea396c8c-d328-42e9-9a95-bf54c9a9da9f} [paranetSyncCommand] (Command ID: 414f276d-deda-46ca-8041-84fdc70ab9e9)  Paranet sync: Syncing 9882 new assets for paranet: did:dkg:base:84532/0x (0x8c90279360061f3f91409334c39a5e21332155ba58d7c795af9c7bb689067702), operation ID: f436ea71-87a6-4ca8-aadf-42e2686dcba3
Oct 24 10:15:42 ottest node[13764]: [2024-10-24 10:15:42] INFO: {Operation ID: c4ccbd8a-f23a-4f9d-9d19-1f8675430998} [paranetSyncCommand] (Command ID: ea241cb8-68b4-41f9-97a9-ec63ad0b87d7)  Paranet sync: Syncing 9886 new assets for paranet: did:dkg:base:84532/0x(0x8c90279360061f3f91409334c39a5e21332155ba58d7c795af9c7bb689067702), operation ID: 2c05c386-5f4c-43f8-9486-6ecf743a9918
Oct 24 10:34:17 ottest2hetzner node[13764]: [2024-10-24 10:34:17] INFO: {Operation ID: 2c05c386-5f4c-43f8-9486-6ecf743a9918} [paranetSyncCommand] (Command ID: ad0b5020-a4c3-49b1-bc9f-6c6a97065951)  Paranet sync: Syncing 9903 new assets for paranet: did:dkg:base:84532/0x (0x8c90279360061f3f91409334c39a5e21332155ba58d7c795af9c7bb689067702), operation ID: 2c05c386-5f4c-43f8-9486-6ecf743a9918
Oct 24 10:37:20 ottest2hetzner node[13764]: [2024-10-24 10:37:20] INFO: {Operation ID: 2c05c386-5f4c-43f8-9486-6ecf743a9918} [paranetSyncCommand] (Command ID: ad0b5020-a4c3-49b1-bc9f-6c6a97065951)  Paranet sync: Syncing 9907 new assets for paranet: did:dkg:base:84532/0x (0x8c90279360061f3f91409334c39a5e21332155ba58d7c795af9c7bb689067702), operation ID: 2c05c386-5f4c-43f8-9486-6ecf743a9918
Oct 24 10:40:27 ottest2hetzner node[13764]: [2024-10-24 10:40:27] INFO: {Operation ID: 2c05c386-5f4c-43f8-9486-6ecf743a9918} [paranetSyncCommand] (Command ID: ad0b5020-a4c3-49b1-bc9f-6c6a97065951)  Paranet sync: Syncing 9911 new assets for paranet: did:dkg:base:84532/0x(0x8c90279360061f3f91409334c39a5e21332155ba58d7c795af9c7bb689067702), operation ID: 2c05c386-5f4c-43f8-9486-6ecf743a9918
Disclaimer
Please be aware that the issue reported on a public repository allows everyone to see your node logs, node details, and contact details. If you have any sensitive information, feel free to share it by sending an email to<EMAIL_ADDRESS>

Can you share more logs around syncing process? Would be really helpful to see what is happening after the start of the sync

Can you share more logs around syncing process? Would be really helpful to see what is happening after the start of the sync

Ah yep sorry mate see attached. I tried just having one paranet rather than multiple overnight but still not syncing.
node1.txt

A friend who is running a node on my paranet is also not syncing so it’s not a geolocation of hardware issue

Can you share more logs around syncing process? Would be really helpful to see what is happening after the start of the sync

OK so i spun up 3 fresh nodes,, made 5 curated paranets and added them. I ran a simple publishing script on node1 to publish to all 5 paranets one at a time and no sync accross the nodes. I seem to get this error on the other 2 node
 Error message: Synced record is missing in 'paranet_synced_asset' table for Assertion: 0x32c48f2ae3e285f69eeeb921013ba7c63c13e58b0f7b8c42c3018a7bc4e9b4c4, Paranet (0xe4f5857f625a3b5e68f7564a49fbada2ca1009fc4223179a999d8b472ece2273) with UAL: did:dkg:base:84532/0xb8b904c73d2fb4d8c173298a51c27fab70222c32/6037374
Included full logs for all 3 nodes;
node1.txt
node2.txt
node3.txt


Add better disk reporting for devicemapper setups

This PR adds support to filter out device mapper pools from the filesystems key returned to the UI. By default cAdvisor returned the device mapper pool, which reported virtual space. The UI added the drive space up and displayed numbers with far more storage available then is really there. Several users have complained about this issue.
Also, added in this is two new keys under diskInfo.
The first is dockerStorageDriver which is the storage driver that the docker daemon is using.
The second is the dockerStorageDriverStatus which gives dockers view of the storage pool.
This PR addresses the customer issue rancher/rancher#2023 and rancher/rancher#1586

LGTM


Change references to "kubernetes.deployment.name"

Done due to an update to filebeat that disables logging of kubernetes.deployment.name by platform engineering.
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Change is fine, but could you update the commit message to explain why the change is being made (and if possible link back to the infrastructure PR that caused us needing to make this change). That'll make it easier for us to debug similar issues in the future.

Explained above, or at least quoted what I was told by Platform-engineering :)


Template Literal Javascript - No go

Describe the bug
Working with template literals causes the interpreter to read code strings as code.
Error  Unexpected token, expected ";"
To Reproduce
const codeString =  const PORT = process.env.PORT || 5002; app.listen(PORT, () => console.log(Server started on ${PORT}));   ;
Where codeString is already a template literal `.
Where "Server started on port ${PORT}" is being read in as a nested template literal.
Expected behavior
Escape mechanism, is there a way to escape template literals?
:)

app.listen(PORT, () => console.log(\`Server started on port \${PORT}\));

needed to add some back slashes


42 CFR 431 has no final rules since the 1978 version and thus versions are not populated

I actually found a part that has never had a final rule made on it. Will need to update the versions logic to pull at least one annual edition (1996?) if there are not final rules for a part.

hmm ok well now the API returns results... not sure what happened but I'm closing this.

ok I misfiled this ticket -- it was actually part 432 that didn't have any new rules. I just ran the annual_versions manage command, using year 1996, the first year of bulk data available.


feat: support arbitrary expressions in LIMIT plan

Which issue does this PR close?

Closes #9821.
Rationale for this change
SKIP and FETCH in the LIMIT plan can support arbitrary expressions.
pub struct Limit {
    pub skip: Option<Box<Expr>>,
    pub fetch: Option<Box<Expr>>,
    pub input: Arc<LogicalPlan>,
}

This olny extends the LogicalPlan of LIMIT. It relies on SimplifyExpressions to fold expressions into constants; if it can't, it will skip executing certain optimization rules, and report an error when creating the physical plan.
What changes are included in this PR?

Are these changes tested?
Yes

Are there any user-facing changes?
Yes.

Thank you. I have some suggestions for LIMIT's behavior:
Before this PR, only int literals are accepted
DataFusion CLI v42.0.0
> create table t1(v1 int);
0 row(s) fetched.
Elapsed 0.052 seconds.

> insert into t1 values (1),(2),(3);
+-------+
| count |
+-------+
| 3     |
+-------+
1 row(s) fetched.
Elapsed 0.086 seconds.

> select * from t1 limit 1.5;
Error during planning: Unexpected expression in LIMIT clause
> select * from t1 limit true;
Error during planning: Unexpected expression in LIMIT clause

This PR:
> select * from t1 limit 1.5;
+----+
| v1 |
+----+
| 1  |
+----+
1 row(s) fetched.
Elapsed 0.006 seconds.

> select * from t1 offset 0.5 limit 10;
+----+
| v1 |
+----+
| 1  |
| 2  |
| 3  |
+----+
3 row(s) fetched.
Elapsed 0.004 seconds.

> select * from t1 limit false;
+----+
| v1 |
+----+
+----+
0 row(s) fetched.
Elapsed 0.009 seconds.

Postgres's behavior is: if OFFSET is not integer for example 0.5, 0th row won't be included, if LIMIT is 0.5, then 0th row would be included:
postgres=# select * from t1 limit 1.5;
 v1
----
  1
  2
(2 rows)

postgres=# select * from t1 offset 0.5 limit 10;
 v1
----
  2
  3
(2 rows)

postgres=# select * from t1 limit false;
ERROR:  argument of LIMIT must be type bigint, not type boolean
LINE 1: select * from t1 limit false;

I think it's good to follow Postgres' behavior for non-integer arguments
Don't support non-numeric arguments like bool, I think they are allowed to cast to integer, but not meaningful in SQL query (maybe there are other types that have a similar issue I'm not aware of)

I think it's good to follow Postgres' behavior for non-integer arguments
Don't support non-numeric arguments like bool, I think they are allowed to cast to integer, but not meaningful in SQL query (maybe there are other types that have a similar issue I'm not aware of)

DuckDB supports them, but I think we can follow PG for now until someone requests these features.

Postgres's behavior is: if OFFSET is not integer for example 0.5, 0th row won't be included, if LIMIT is 0.5, then 0th row would be included:

@2010YOUY01 good point!
do you maybe know what is the use-case for allowing fractional values for LIMIT or OFFSET?
this looks like a pandora box. strictly speaking, casting them to integral values isn't exactly what we can do: OFFSET 1.5 LIMIT 1.5 should return 3rd row, but not the 4th row.

@2010YOUY01 good point! do you maybe know what is the use-case for allowing fractional values for LIMIT or OFFSET?

Not really, allowing fractional values looks quite bizarre to me, however, nowadays many SQL are auto-generated so we can't make too many assumptions

this looks like a pandora box. strictly speaking, casting them to integral values isn't exactly what we can do: OFFSET 1.5 LIMIT 1.5 should return 3rd row, but not the 4th row.

This way it requires lots of effort to match PostgreSQL's behavior 🤔 Maybe it should be left to a later task

Disallow non-integer types in https://github.com/apache/datafusion/pull/13028/commits/e6d1297cb9045f99cab21690335740853fd91507 .  Fractional values are more complicated than I expected, let's handle them later. @2010YOUY01 @findepi

Disallow non-integer types in e6d1297 . Fractional values are more complicated than I expected, let's handle them later. @2010YOUY01 @findepi

I think the floating value is caused by the DataFusion casting behavior is different from others. I tried to cast a float to an integer.
DataFusion
DataFusion CLI v42.0.0
> select 1.5::int;
+--------------+
| Float64(1.5) |
+--------------+
| 1            |
+--------------+
1 row(s) fetched.
Elapsed 0.055 seconds.

> select 1.4::int;
+--------------+
| Float64(1.4) |
+--------------+
| 1            |
+--------------+
1 row(s) fetched.
Elapsed 0.001 seconds.

Postgres
test=# select 1.5::int;
 int4
------
    2
(1 row)

test=# select 1.4::int;
 int4
------
    1
(1 row)

DuckDB
D select 1.5::int;
┌──────────────────────┐
│ CAST(1.5 AS INTEGER) │
│        int32         │
├──────────────────────┤
│                    2 │
└──────────────────────┘
D select 1.4::int;
┌──────────────────────┐
│ CAST(1.4 AS INTEGER) │
│        int32         │
├──────────────────────┤
│                    1 │
└─────

Postgres and DuckDB are rounding but DataFusion is round down.
So, that's why limit 1.5 only returns 1 row in DataFusion but returns 2 rows in Postgres.

Disallow non-integer types in e6d1297 . Fractional values are more complicated than I expected, let's handle them later. @2010YOUY01 @findepi

I think the floating value is caused by the DataFusion casting behavior is different from others. I tried to cast a float to an integer.

Maybe related to https://github.com/apache/datafusion/issues/8302 and https://github.com/apache/datafusion/issues/11886

I think the floating value is caused by the DataFusion casting behavior is different from others. I tried to cast a float to an integer.
Maybe related to #8302 and #11886

Maybe we can add support for floats after these issues are resolved🤔.

Not really, allowing fractional values looks quite bizarre to me, however, nowadays many SQL are auto-generated so we can't make too many assumptions

If i were generating queries, i wouldn't ask a database to do LIMIT 1+2, I'd generate LIMIT 3.
Do you maybe know what class of software generates LIMIT <expr> or LIMIT <fractional>?

Thanks @goldmedal @findepi @2010YOUY01 @alamb for the review.


Scourge Arrow additional spore pod enchant at Maximum Stages

No changes to DPS for Release at 5 Stages when adding enchant. Enchant is in red.

DPS is calculated per Arrow on PoB, so adding pods and arrows won't do anything for DPS calculations. That's done because it's likely not all arrows are going to hit the target.
On top of that, "Release at 5 stages" is the DPS of the main arrow fired from the player, not from the pods so the enchant wouldn't have any impact anyway.
However I did notice the DPS of the Throw Arrows is wrong. When selecting "Release at 5 Stages" it correctly uses Average Damage * (Attack Rate / 5) but when selecting Thorn Arrow, it uses Average Damage * Attack Rate instead.


Add GGUF versions for SD3.5

SD3.5 large was just released !
https://huggingface.co/stabilityai/stable-diffusion-3.5-large-turbo
https://huggingface.co/stabilityai/stable-diffusion-3.5-large

I got it converted to gguf f16, by modifying the convert code, but the problem is llama quantize doesn't know sd3 arch.  I also had to make a sd3 gguf loader node for comfyui and it works great.  Stuck now at making the k files now
SD3 convert
https://huggingface.co/ND911/model/blob/main/convert_sd3.py
Nodes
https://huggingface.co/ND911/model/blob/main/nodes.py
Probably need a patch wioth directions for llama

I've tried with SD3 before, idk what the hell to do about this specific weight, because the first dimension can't be 1 in any of the C++ code so it just gets stripped and converted to [36 864, 2 432] which then fails to load when the comfy SD3 specific code hits it.

The diffusers format weights don't have that but those ones have the q/k/v split so it'll just fail on the reshape iirc.
@wolfden I don't think it running in FP16 helps much, because that never involves any of the custom code anyway. Also, if you have to pass in the model type, then doesn't that mean that the auto model detection in comfy has failed, and that your checkpoint is in an invalid format? (Also, we can pass the model type for SD3 in the default node as well as a kwarg without having to have an extra node, since we can just add a switch based on the model arch returned from the loader.)

I was just trying to get it working myself
("sd35", (
    ("joint_blocks.0.context_block.adaLN_modulation.1.bias",),
)),

to the model detection in convert.py so it would detect and label, also i added to blacklist "embedder."  since i think thats the layers for the embeddings in the new model :S
For the gguf node, I added "sd35" to the line 66 i believe to make it so the unet loader supports the new sd model label.
the lpppatch i got to work but think i did it wrong, because i likely needed to add better layer exceptions for fp16/fp32, for my test i only added the exceptions for final_layer as fp16 and final_layer.linear as fp32....
Here's some examples, all based on the example workflow from comfy, euler_
BASELINE Safetensors (16.46gb):

FP16 GGUF (16.29gb):

Q8_0 GGUF (8.75gb):

Q5_K_M GGUF (5.92gb):
Something wrong it blew up to a black image, so i definitely broke something LOL

@wolfden I don't think it running in FP16 helps much, because that never involves any of the custom code anyway. Also, if you have to pass in the model type, then doesn't that mean that the auto model detection in comfy has failed, and that your checkpoint is in an invalid format? (Also, we can pass the model type for SD3 in the default node as well as a kwarg without having to have an extra node, since we can just add a switch based on the model arch returned from the loader.)

I agree at f16 it don't help much, that wasn't the goal and I'm not a coder, but can generally figure things out and hack it together.  Things work, but again, back to the llama issue

@wolfden All good, happy to hear if anyone figures out anything lol.
@cchance27 @wolfden Actually, it looks like both of you are on an older version of the convert script. The current master one does pick up SD3 correctly for the python part at least.

well shit i'll update over to that version, have you already figured out what layers need to be f16/f32 reserved on the lcpp patch?

I have a rewritten version of the c++ logic part from a while ago that works with SD3 but I haven't figured out the issue with that pos_embed key being reshaped yet.

Well, don't think the python convert + comfy loader code needs any extensive changes? Using this file as a base it does pick up the format correctly and seems to work fine. I've added SD3 as a valid arch to the loader https://github.com/city96/ComfyUI-GGUF/commit/0ef158d79348ba725a2ac76376d0273945386b43

I wonder how janky it would be to just patch that single key in post after the llama.cpp convert step for now just to have some weights for people to download lol.

not sure why the git pull didn't pull latest convert, tested the new node.py and working fine here also

I think just having an gguf FP16 weights could be better than safetensors.
There is an issue with the safetensors library on windows. ( https://github.com/comfyanonymous/ComfyUI/issues/4480#issuecomment-2325350291 )
It needs about double the RAM of the safetensors FP16 file size while loading.
I have this issue with Flux. I only have 32 GB RAM, so it uses my page file.
But this does not happen with the Flux GGUF versions.

Some more info about the issue at hand, in case anyone has any better ideas.
The SAI reference checkpoint has a weight shaped [1, 36864, 2432]. In the GGUF file, the order is reversed, and the key is saved as [2432, 36864, 1] - all good so far. The issue is that when the C++ conversion runs, the weights are padded with 1s for the unused dimensions, so this particular one becomes [2432, 36864, 1, 1] and during saving becomes [2432, 36864] with the first (last) dim stripped even if no conversion happens (i.e. kept as FP16).

In comfy, this just manifests as a shape mismatch while loading, as expected:
size mismatch for pos_embed: copying a param with shape torch.Size([36864, 2432]) from checkpoint, the shape in current model is torch.Size([1, 2432, 2432]).

@cchance27 How did you get your version to bypass that specific issue, assuming you even ran into it lol
Also, current WIP patch with the issue above still present, but some logic for SD3 added in and the main parts rewritten. lcpp_new.patch It's for the newest llama.cpp version since I was curious if it'd solve the issue (it didn't).

I stupidly wiped the stash I had, when I saw others were already working on it, the lcpp patch you shared is from a different version than I was playing with, it had the checks for leaving some things at fp32 and some at fp16, my first hack attempt that worked, wasn't excluding the proper layers from being quanted, except for final_layer.
Is it possible theres code elsewhere in the original quantizer for pos_embed? pretty sure thats a layer name they use in some llm's as well isn't it?

Doesn't seem to be name related, good call though (I think the LLM specific ones are called token_embd.weight).

haha heres something funny, that Q5 model i was having black screens with and erased cause i figured i had messed it up, might not have been messed up because for some reason i just got a black render halfway through the steps on the standard safetensors generation :S

Odd, wonder if it needs BF16 like flux does for the inference. The weights are in FP16 though so that'd be odd. The VAE hash is different from SD3 but they seem close enough at least.
BTW, this is the part that's causing the dimension to be stripped, since yeah, it just checks if it's >1 to see whether it should keep it or not and due to the reversed order it just gets stripped I think.
(Can't manually set it because it gets called directly from gguf_add_tensor pretty sure)
int ggml_n_dims(const struct ggml_tensor * tensor) {
    for (int i = GGML_MAX_DIMS - 1; i >= 1; --i) {
        if (tensor->ne[i] > 1) {
            return i + 1;
        }
    }
    return 1;
}

A hacky as hell but it works as a proof of concept lol. It's definitely the dimension detection logic. Setting it manually for just that key makes it work.
void gguf_add_tensor_n_dim(
             struct gguf_context * ctx,
        const struct ggml_tensor * tensor,
        const uint32_t n_dims) {  // use manual dimension count

Hey if it works it works

@city96 what tag of llama.cpp are you applying th new patch to for some reason mine isn't lining the line numbers correctly

@cchance27 I pushed the patch + the actual tag I was targeting. Should be tags/b3962. Currently testing on SD3 medium lol, small models seem to have lower bitrate quants the same way LLMs do.
Apparently SD3.5 also uses a different shape for the keys, which is why K quants don't work. We could use the reshape logic that's also used for SDXL but that needs possible future logic changes.

i tried a q8_0 and q4_0 and both when it loads i get
Traceback (most recent call last):
  File "/Users/user/AI/ComfyUI/execution.py", line 323, in execute
    output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
  File "/Users/user/AI/ComfyUI/execution.py", line 198, in get_output_data
    return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
  File "/Users/user/AI/ComfyUI/execution.py", line 169, in _map_node_over_list
    process_inputs(input_dict, i)
  File "/Users/user/AI/ComfyUI/execution.py", line 158, in process_inputs
    results.append(getattr(obj, func)(**inputs))
  File "/Users/user/AI/ComfyUI/custom_nodes/ComfyUI-GGUF/nodes.py", line 258, in load_unet
    sd = gguf_sd_loader(unet_path)
  File "/Users/user/AI/ComfyUI/custom_nodes/ComfyUI-GGUF/nodes.py", line 39, in gguf_sd_loader
    reader = gguf.GGUFReader(path)
  File "/Users/user/AI/ComfyUI/venv/lib/python3.10/site-packages/gguf/gguf_reader.py", line 130, in __init__
    self._build_tensors(offs, tensors_fields)
  File "/Users/user/AI/ComfyUI/venv/lib/python3.10/site-packages/gguf/gguf_reader.py", line 314, in _build_tensors
    data = self._get(data_offs, item_type, item_count).reshape(np_dims),
ValueError: cannot reshape array of size 5914608 into shape (2432,2432)

Huh, strange. It works with sd3 medium, but with large it only works with the gguf-py from the llama.cpp repo but not the package one.

I was going to say its something about the items we're quanting because those seem to be the ones that are of size 2432,2432,1,1 on the proj.weight for the jointblocks ... as well as t and y embedding weights

Okay, I think I got it. I think modifying the metadata after the initial bit where it adds it might be corrupting the data parts, possibly due to the data length changing. That might be because I'm passing it a uint32_t which probably isn't what it should be setting it to, and there's no boundary check there, i.e. it messes up the tensor right after it? Lemme try and fix that lol.

@cchance27 Could you re-test with the new patch?

Looking good, updated it and rebuilt with new patch, just did a Q8_0 and got passed the loader, diffusing now (i'm on mac it takes a bit to diffuse XD)

Gonna test all the major quants and then upload them to civit in a couple

Sounds good, I'll put some up on huggingface in that case and then we should be all covered I think.

Sounds good thanks for all the help figuring it out, i'd never have tracked down that uint issue lol, too long since i fought with CPP XD

I guess the K quants I'll look at separately sometime on the weekend maybe, also depends on how much community adoption it'll get. I think a lot of people prefer the legacy _0 and _1 quants for speed alone lol.
Also, in case you're lazy like me:
name = "sd3.5_large"
path = "~/ComfyUI/models/unet"

for q in ["Q8_0", "Q5_1", "Q5_0", "Q4_1", "Q4_0"]#, "Q6_K", "Q5_K_M", "Q5_K_S", "Q4_K_M", "Q4_K_S", "Q3_K_M", "Q3_K_S", "Q2_K"]:
	print(f"./llama-quantize {path}/{name}-F16.gguf {path}/{name}-{q}.gguf {q}")

Here's the basic quants, should I do ones for turbo as well? https://huggingface.co/city96/stable-diffusion-3.5-large-gguf

I tried using the UnetLoaderGGUF, but it gave this error.
Unexpected architecture type in GGUF file, expected one of flux, sd1, sdxl, t5encoder but got 'sd3'

Got it working on 8gb vram!
Thanks for the quantised models!

Thanks, legend! You’re my hero.

Here's the basic quants:

Default: https://huggingface.co/city96/stable-diffusion-3.5-large-gguf

Turbo: https://huggingface.co/city96/stable-diffusion-3.5-large-turbo-gguf

Thanks, legend! You’re my hero.

Thanks All!  Awesome!

When loading SD3.5 GGUF in Comfy, do you have to use a regular checkpoint loader on the original safetensors to get the VAE? Or is the VAE included in SD3.5, and we just can't output it yet from the GGUF?

@Jonseed You can either download it separately from the SD3 huggingface repo (VAE folder) or use the SaveVAE node on the checkpoint you already have. The gguf files only ever contain the UNET part.
(Also see this comment for more info: https://github.com/city96/ComfyUI-GGUF/issues/139#issuecomment-2435954632 )


.net 7 with MAUI support

Hi, I have a question about this plugin, I'm using .net maui and my app it's already published in Google PlayStore, but when i'm trying to use this plugin:
await CrossStoreReview.Current.RequestReview(false);
It dosn't show the review page.
Version Number of Plugin: 5.0.1
Device Tested On: HUAWEI Y7 (ANDROID 8)
Simulator Tested On: ANDROID 11

Hi @anherukun , in debug mode, did you try to run instead
await CrossStoreReview.Current.RequestReview(true);

Also, you should rephrase your title as this is not reflecting your actual issue

I'm having the same issue, it doesn't work on Android with internal sharing in Google Play.

Finally found the issue! We can't use G-Suite accounts to review the application.

I'm having the same problem where it doesn't show up on both, ios and android (MAUI) but only when published in app store. When testing it in ios simulator for example it immediately shows up.
As for iOS I read that its up to the system to show it or not. But as I said it also happens on Android. I'm using the code below:
#if ANDROID
        await Plugin.StoreReview.CrossStoreReview.Current.RequestReview(true);
#endif
#if IOS
        if (UIDevice.CurrentDevice.CheckSystemVersion(10, 3))
        {
            SKStoreReviewController.RequestReview();
        }
#endif


CSS hiding elements to screen readers being ignored

On the following page:
http://www.bbc.co.uk/news/video_and_audio/uk
I get the following error when I run the tool:
A document must have exactly one heading. Found 2 h1 elements.
One of the h1 elements has the following CSS and therefore is hidden to screen readers, leaving just one h1 element available to screen reader users.
display: none;
visibility: hidden;
Will the new DOM reimplementation solve such issues @joshski?

It should do yes. We might need to tweak the standard to only consider visible elements...

Super thanks @joshski

Fixed in #82


Feature request: Tasker integration

The developer plans to implement an integration with Tasker like Clockwork Tomato?
Thanks for the app

It is not planned, no.


programatically select select2 options, NOT Working

Hi, I tried below solutions to select one of the listed options
<select data-placeholder="Company Name" class="select required form-control select2-hidden-accessible" name="company[company_name]" id="company_company_name" tabindex="-1" aria-hidden="true">
  <option value=""></option>
  <option value="ABC">ABC</option>
  <option value="XYZ Company">XYZ Company</option>
  <option value="PQR Company">PQR Company</option>
</select>

First Solution
// didn't worked
$('#company_company_name').select2('val', 'XYZ Company');
// => undefined

// didn't worked
$('#company_company_name').select2('val', 'XYZ Company', true);
// => undefined

// didn't worked
$('#company_company_name').select2('data', {id: 'XYZ Company');
// => undefined

// didn't worked
$('#company_company_name').select2('data', {id: 'XYZ Company', a_key: 'XYZ Company');
// => undefined

ALSO NOTE below code is returning empty array:
$('#company_company_name').select2('data')
// => []

QUESTION
How can I select select2 options that already exists using jquery?

Finally got it working:
$('#company_compay_name').val("XYZ Company")
$('#company_company_name').trigger('change') // broke the design and select2 is now changed into normal select field

// where as
$('#company_company_name').trigger('change.select2') // is working

REFERENCES:
http://stackoverflow.com/questions/37255247/programmatically-select-select2-options-using-jquery
https://select2.github.io/options.html#what-events-does-select2-listen-for


Size aliases

Support size aliases: 1080, 720, 4k, 640, etc as arguments to resize

I think this is not really worth it.  For example, there are multiple resolutions that are commonly referred to as "4k"


Parse non-ascii characters in the XML files

There are some apps with special characters in their names. These get replaced by a question mark.
My assumption is that this happens somewhere in the XML parser or download code, since it displays wrong on the HTML pages, packages.json and the RSS-feed
Examples:

https://sailfishos-chum.github.io/apps/harbour-tooterb/ (should be Tooter β)
Meecast/meecast#74

… or MeeCast's changelog entry for v0.11.8 as rendered by SailfishOS:Chum-Web.

It also happens when using zypper from the command line:
<EMAIL_ADDRESS>~]$ zypper search tooter
Bezig met ophalen van installatiebrongegevens…
Bezig met inlezen van geïnstalleerde pakketten…

S | Name                        | Summary                                       | Type
--+-----------------------------+-----------------------------------------------+-------
| harbour-tooterb             | Tooter ?                                      | pakket
| harbour-tooterb-debuginfo   | Debug information for package harbour-tooterb | pakket
| harbour-tooterb-debugsource | Debug sources for package harbour-tooterb     | pakket

Op Donderdag 5 december 2024 schreef olf:

… or MeeCast's changelog entry for v0.11.8 as rendered by SailfishOS:Chum-Web.
--
Reply to this email directly or view it on GitHub:
https://github.com/sailfishos-chum/sailfishos-chum.github.io/issues/34#issuecomment-2521656579
You are receiving this because you authored the thread.
Message ID: @.***


Add sjsu::urc_mission_control interface

This will allow applications to eliminate the coupling to specific port or technology for communication. This way the applications do not need to depend on or use specifically the esp8266 or a serial port for getting commands.
The interface should return the mission control command and NOT return a string that then must be parsed. The implementation handles the lower level details of communicating with mission control.
There may need to a mission control interface for each sub system, but there may be a possible way to do this with a single interface scheme, maybe using std::variant.

@50xp50 This task is the one I was talking about.

@Coreyboy1820 has done this


Disable Sending of ML Events by Default

This PR sets the default value of ml_insights_events.enabled to False so it can be intentionally enabled by users who would like to send ML events to NR.

Codecov Report

Merging #923 (1226b96) into develop-scikitlearn (86f0df8) will decrease coverage by 1.44%.
The diff coverage is 100.00%.

@@                   Coverage Diff                   @@
##           develop-scikitlearn     #923      +/-   ##
=======================================================
- Coverage                81.74%   80.30%   -1.44%
=======================================================
  Files                      190      190
  Lines                    19581    19581
  Branches                  3401     3401
=======================================================
- Hits                     16006    15725     -281
- Misses                    2593     2866     +273
- Partials                   982      990       +8

Files Changed
Coverage Δ

newrelic/core/config.py
94.21% <100.00%> (ø)

... and 14 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Overflow error for non-linear torque GM cars

Describe the bug
When stationary, and specifically for Silverado, if the observed curvature is close to or less than -1.0, the resulting low_speed_factor-adjusted "measured" lateral acceleration can be high enough to cause an overflow error in the sig function defined at line 51 in gm/interface.py
This error was experienced by @not1454 on discord. Although he was running a fork at the time, the relevant code and call stack is identical to master.
def sig(val):
  return 1 / (1 + exp(-val)) - 0.5

When the curvature is close to or less than -1.0, the measured lat accel is high enough that, after being multiplied by the non-linear torque parameter a (which is ~3.3), the val argument to sig will be less than -710, causing an overflow error when exp(-val) is evaluated.
Here's a screenshot of such an error (though not on master, the code is identical to the code in master in this regard. Line 65 here is identical to line 51 in the same file in master)

One workaround for this could be:
from math import expm1

def sig(val):
    if val < -709:
        return -0.5
    else:
        return 1 / (1 + expm1(-val)) - 0.5

Which car does this affect?
Chevy Silverado
Provide a route where the issue occurs
(can try to reproduce if requested)
openpilot version
0.9.7
Additional info
No response

thanks for bringing this to our attention!


omitempty tag on InstallationAccessTokenOptions.Repositories masking functionality of GitHub API

When creating an app installation access token through the REST API (POST /app/installations/{installation_id}/access_tokens), if the repositories parameter is set to an empty array, the API returns a list of all accessible repositories. However, the client currently strips empty arrays (omitempty) when marshaling the InstallationAccessTokenOptions.Repositories value making that functionality inaccessible through the client.
https://github.com/google/go-github/blob/169ad4d74d0fad23559bac97d8ad2095999a4f29/github/apps.go#L45-L57

According to the official docs:

Optionally, you can use the repositories or repository_ids body parameters to specify individual repositories that the installation access token can access. If you don't use repositories or repository_ids to grant access to specific repositories, the installation access token will have access to all repositories that the installation was granted access to. The installation access token cannot be granted access to repositories that the installation was not granted access to. Up to 500 repositories can be listed in this manner.

so these fields are optional, hence the omitempty, and it's not clear (to me) what the behavior is if you were to send it an empty array (as opposed to not sending the field at all, which omitempty does).
You didn't state what you are trying to do by providing it an empty array.
Are you trying to remove access to all repositories? If so, I'm wondering if that might be a different endpoint, such as this one?
If you are trying to do something else, then I need to warn you against removing omitempty from optional body parameters, as that has historically wreaked havoc with other uses of the endpoint, and we've had to create additional endpoints to address the other behavior.
So please clarify what you are trying to do, and if you would like to create a PR to address the issue.
Thanks.

So the documentation doesn't actually specify this behavior but basically you can have the endpoint return the list of all accessible repositories in the installation by specifying an empty array for the repositories parameter.
 Thank you for the detailed example!
Then I'm thinking we need to have a new, separate endpoint that handles this special case... with a name that makes the distinction clear.
What do you think?
Do you want to write it, @gillisandrew ?

Hello. If @gillisandrew doesn't want to take this I'd like to have a crack at it. Thanks!

Thank you, @Matthew-Reidy !  It's yours.

Hey all, I will begin working on this today but I just want to make sure I understand what the ask is here before I start. Basically passing an empty array of repositories as a parameter should return a list of all repos that are a part of an installation but the client discards empty arrays?

Hey all, I will begin working on this today but I just want to make sure I understand what the problem is here before I start. Basically passing an empty array of repositories as a parameter should return a list of all repos that are a part of an installation but the client discards empty arrays?

Actually, I'm a bit confused now myself.  The original description talks about a POST call, but the example given is a GET call.
@gillisandrew - can you please clarify what your ask is here, and exactly which go-github endpoint(s) you are talking about?

@gmlewis Hi thanks for following up. The examples given are correct, the -d argument changes the request method to POST as demonstrated in the examples on the man page.
Sorry for the confusion.

Oh, cool!  TIL.  Sorry, @gillisandrew - my bad... both are the POST case.
OK, so @Matthew-Reidy - we need a new endpoint...
The endpoint we are talking about is CreateInstallationToken.
Now the hard part - what should the name be?
Maybe CreateInstallationTokenListRepos ?  @gillisandrew - ideas?
Now the easy part is that this new method will have an internal anonymous struct almost identical to InstallationTokenOptions with the one modification:
RepositoryIDs []int64 `json:"repository_ids"`

and this field will not be assigned a value.
@gillisandrew - have I got all this right?

Got it. If there are no objections I'll just move forward with CreateInstallationTokenListRepos as a name for the new endpoint function. If my week goes to plan hopefully I can get a PR in by Friday.

Submitted a PR to fix this. Take a look!


New SideNav structure

Checklist

[ ] Build process is done without errors. All tests pass in the /lib directory.
[ ] Self-reviewed the code before submitting.
[ ] Meets accessibility standards.
[ ] Added/updated documentation to /website as needed.
[ ] Added/updated tests as needed.

Description
The previous HTML structure of the SideNav was very poor in terms of semantics.
Closes #1642

There is still one problem to address. Section compound component is now treated as a ul, however, there are some scenarios where its child is a paragraph or any other text. In my opinion, we should create a specific compound component regarding that scenario. (For example TextSection) in case we don't want to lose that functionality, another more opinionated option would be to simply force the user to use list items as children. (Which is generally the correct case scenario for a SideNav)

Closed for now until the topic is discussed.


How to configure multiple sentinel hosts?

Hello.
Common sentinel configurations have at least 3 sentinel nodes, but, according to the docs, the config file accepts only one sentinel host parameter.
Can i provide more than one sentinel connections?
Edit: Nevermind, i just saw there is already an issue for this topic.

It's not necessarily an issue to add support for an array of Sentinel hosts. However, it is quite tricky to implement a failsafe logic that selects a working host in terms of timeouts and other things. Handling this kind of issue at the infrastructure level just makes more sense, so I advise to go this path if possible.


Image uploading to Bing Chat

I've added functionality to be able to attach images just like you currently can in the web interface. Simply provide the URL you want to attack to attachment in ask() and it will be uploaded to Bing and sent in the message object.
I have the image being uploaded to Bing's servers and it returns two URLs, the original image and a "processed" version, which seems to be the blurred version Bing Chat receives.
The reason why this pull request is a draft is because this is all functional, up to the point that Bing Chat actually replies and seems to have no idea what image you're talking about.
Example of what you expect:
What you actually get using this branch with the same exact prompt and image:
{
   "value":"Success",
   "message":"I\\'m sorry, but I can\\'t answer that question. I don\\'t have access to the picture you are referring to. If you want me to search the web for images of dogs, you can ask me something like \"show me images of dogs\".",
   "serviceVersion":"20231010.181"
}

It apparently doesn't see the image at all, despite the image being given to Bing Chat in the same exact way as the web interface via _build_ask_arguments(). You can even see in the images in the JSON sydney.bing.com returns
Snippet from the object returned in ask():
            "offense":"None",
            "imageUrl":"https://www.bing.com/images/blob?bcid=rFkXjfEhIi0Gmg",
            "originalImageUrl":"https://www.bing.com/images/blob?bcid=rA6V5winpC0Ggw",
            "feedback":{
               "tag":"None",
               "updatedOn":"None",
               "type":"None"
            },

The bcid parameters are what sending the image to https://www.bing.com/images/kblob returns.
The work is 99% there, if you can fit the missing piece, this will be a brand new feature that I don't see on other APIs. I'll keep trying to figure it out but feel free to get this working if you spare the time.

One big main difference with the web interface that you won't see using this branch, and I don't know if this means anything but between your prompt and the response, you will see the message where it talks about "analyzing" the image
         {
            "text":"Analyzing the image: Faces may be blurred to protect privacy.",
            "hiddenText":"Analyzing the image: Faces may be blurred to protect privacy.",
            "author":"bot",
            "createdAt":"2023-10-11T06:33:50.3411203+00:00",
            "timestamp":"2023-10-11T06:33:50.3411203+00:00",
            "messageId":"1cbb3e35-b031-47c1-a824-5e1b60857c83",
            "requestId":"409bec49-aa4d-d8aa-b6f2-cea5da9e53ff",
            "messageType":"InternalLoaderMessage",
            "offense":"None",
            "adaptiveCards":[
               {
                  "type":"AdaptiveCard",
                  "version":"1.0",
                  "body":[
                     {
                        "type":"RichTextBlock",
                        "inlines":[
                           {
                              "type":"TextRun",
                              "isSubtle":true,
                              "italic":true,
                              "text":"Analyzing the image: Faces may be blurred to protect privacy."
                           }
                        ]
                     }
                  ]
               }
            ],
            "feedback":{
               "tag":null,
               "updatedOn":null,
               "type":"None"
            },
            "contentOrigin":"DeepLeo"
         }

All this likely shows is that the image somehow isn't reaching Bing Chat in my branch, but still worth pointing out.

Hi @Mazawrath
Thank for taking the time to open this PR! This is indeed a feature that could make Sydney.py much more useful.
I do not have a lot of time right now to debug the issue that you mentioned, but I will go through the code and later this evening I might be able to try and debug it. I'll write any comments as I go through the code.

Had to push some tiny changes, but tests now pass :tada: