drive.Revisions returns incomplete list of revision Ids

Environment details

OS type and version:

Arch Linux

Python version: python --version

3.10.1

pip version: pip --version

22.0.4

google-api-python-client version: pip show google-api-python-client

2.42.0

Steps to reproduce

establish creds
build service
request revisions list

Code example
service = build('drive', 'v3', credentials=creds)
data = service.revisions().list(fileId=id, pageSize=100, fields="nextPageToken, revisions(id, modifiedTime)").execute()

The resulting list is roughly 35 items long. As it is an actively edited sheet, 1 or more times per day, I expected hundreds of revisions. As I have been writing this report, the original starting Id and ending Id have changed. The revision list should have gone back to June of last year. Instead, the revision modifiedTime timestamps only go back 3 weeks.
I can see the full revision history in the document itself.

Hi @FirefighterBlu3,
Please could you try out a similar request in the 'Try this API' interface on this page and check whether the issue still exists? This helps to confirm if this is a client library issue or a API issue. If it is an API issue, we'll redirect you to the API support channel so you can get better quality answers. For the Drive API please see https://developers.google.com/drive/api/v3/support.

Hello, I'm interested in working on this issue. Kindly guide me with the further process.

I ran into the same issue as @FirefighterBlu3. Seeing an inconsistent revision list which is incomplete, and to make things even funnier, changes when executed multiple times. That's bad - but what's good news for you: I can see this behaviour also when using the "try this method" on https://developers.google.com/drive/api/v3/reference/revisions/list . So AFAICT this is not an issue of google-api-python-client.


net/freeradius: [WIP] Add more attributes to users and remove radiusd.conf

remove radiusd.conf since it's not used/touched by the plugin and the libdir is always changed with every update of the freeradius3 package, so not compatible with managing via plugins (needs a reinstall of freeradius3).

add ChilliSpot and WISPr attributes. Here I need some help from @AdSchellevis
You did some magic for @fraenki and the acmeclient:
https://github.com/opnsense/plugins/blob/master/security/acme-client/src/opnsense/mvc/app/views/OPNsense/AcmeClient/validations.volt#L51-L76
https://github.com/opnsense/plugins/blob/master/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml#L39

What I want to achieve is:

In Tab "General" a checkbox for en- or disabling additional attributes:
https://github.com/mimugmail/plugins/blob/freeradius_att/net/freeradius/src/opnsense/mvc/app/controllers/OPNsense/Freeradius/forms/general.xml#L14-L19
If checkbox in General is checked, display the specfic attributes in popup when adding a user
https://github.com/mimugmail/plugins/blob/freeradius_att/net/freeradius/src/opnsense/mvc/app/controllers/OPNsense/Freeradius/forms/dialogEditFreeRADIUSUser.xml#L45-L67

I asked fraenki but he didn't really remembers what all the JS magic is actually doing :)
If it's not possible or your time too limited I would pack everything too specific in <advanced> so the dialog is not overloaded with many input fields.
Thanks for any hints! :)

@AdSchellevis Did you have the time to look at this? If not I'd like to move everything beside standard to <advanced> cause I don't like hacky solutions I dont understand myself :)

@mimugmail I was some days away, haven't seen the question. The JS stuff should be quite simple, I can do it for you if the rest of the code is in the master branch and I know what to show/hide.
The "magic" in the JS code lies in hooking the "onShow" event from the dialog and handling the hidden fields from there. But if the rest of the code is finished and this can be pulled I don't mind adding it for you.

@fichtner Please review
@AdSchellevis Thanks for your offer! I renamed some fields get a logic:
When field in general is enabled (e.g general.wispr) then show every field in user with _ (e.g. user.wispr_XXX).
I did this also with chillispot and it would pretty scale.

@mimugmail ok, sounds good, can you open an issue when this code is in for me? (just to make sure I won't forget)

LGTM, but assigned to @AdSchellevis for follow-up core thingy

@AdSchellevis please merge, very exited how you solve this one :)

@mimugmail this should do the trick https://github.com/opnsense/plugins/commit/6105bf515298518536c1b2d2b9ee8a13360ffb86
Since your form is bound to the general settings, we need to fetch them first, after which we can hide what isn't needed.
This could potentially mess up the zebra stripes, but should keep values of the fields when saving a user again. Another option is to drop the tr tags, keeps zebra intact, but trashes previously saved values if not enabled in the general section anymore.

@AdSchellevis works great, thanks! Only problem is that disabling the section in general keeps the settings in users in DB. So this logic is only be allowed if the tick in general has no other meaning and does not en-/disable a feature the attributes in users rely on. Anyway, it keeps the view short and simple, I'll add a info to the help and hopefully all are happy.
Thank you! :)

@mimugmail you're welcome :)
If you want to ignore old settings on save, you can remove the tr tag, which stops the save from sending the data to the controller.... but settings for other users will obviously remain in the file.

@AdSchellevis I decided to keep the values and add a note. Otherwise a false tick disabling in general would squeeze a bigger user setup :)

@mimugmail sounds good to me


setUpClass() missing 2 required positional arguments: 'app' and 'client'

conftest.py

class TestBase(flask_unittest.AppClientTestCase):
def create_app(self):
    app = init_app('test', config)
    ctx = app.app_context()
    ctx.push()
    yield app
    ctx.pop()

test_signup.py

from app import db
from app.tests.conftest import TestBase
from app.tests.fixtures.seed_fixture_country_code import seed_fixture_country_code

class TestSignup(TestBase):
@classmethod
def setUpClass(cls, app, client):
    db.create_all()

@classmethod
def tearDownClass(cls, app, client):
    db.session.remove()
    db.drop_all()

def setUp(self, app, client):
    # db.create_all()
    seed_fixture_country_code()

def tearDown(self, app, client):
    pass

def test_signin(self, app, client):
    response = client.post(
        "/signup",
        json={
            "email"<EMAIL_ADDRESS>            "firstname": "Unit",
            "lastname": "Test",
            "password": "secret",
            "country_code_contact_number": "62",
            "contact_number": "12345678",
            "country": "Indonesia",
            "postalCode": "1111",
            "birthday": "1990-01-01",
            "gender": "Male",
            "token_issuer_server": "ID"
        },
        headers={
            "api-key": "user",
            "User-Agent": "test"
        }
    )
    res_json = response.get_json()
    self.assertEqual(201, response.status_code)
    self.assertIn("access_token", res_json["data"])
    self.assertEqual("Unit", res_json["data"]["user"]["firstname"])
    self.assertEqual("Test", res_json["data"]["user"]["lastname"])

Hi, how can I fix this? I got setUpClass() missing 2 required positional arguments: 'app' and 'client' each time I run the test.

The class methods in testcases do not have access to the extra arguments provided by AppClientTestCase (or any other test case included in this library).
Unfortunately, due to how unittest itself is designed - your app is only created after instantiation of your class. This means that class methods (static side methods) cannot have access to the app (which only exists at instance side). There is nothing that can be done regarding this as I cannot hijack unittest's own execution pattern. Well, at least that wouldn't be very clean and ideal.
The methods that do have access to the resources provided by the flask_unittest testcases are mentioned in the docs. Specifically, your setUp, tearDown and all test methods can have access to these extra resources - as these are all invoked after instantiating the class.

Given your usecase, I do not think you actually need the extra resources in your class methods. Do note however that create_app is called for each test set (setUp, test, tearDown) - and hence the application/client is created per test set. This ensures all test sets are independent from each other and is considered good practice. This also means that you may put app specific setup in create_app itself - which will be executed for each test set (not per class).

Thank you for explaining. So let's say that I have 3 tests in the TestSignup class. Is it possible to just create_app once? So that I can use the same app and db session until all the tests finished.


Add Waydroid config

Lately Waydroid gives impressive results on most devices >= Halium 9, so lets try to incorporate the changes here already, so porters have less work to do.

Do you happen to have a reference for these configs? Just looking at Waydroid repo?

@peat-psuwit I basically got it from porter discussions where Erfan and @NotKit mentioned these. I agree a written reference would be good though.

@peat-psuwit I basically got it from porter discussions where Erfan and @NotKit mentioned these. I agree a written reference would be good though.

If it happens in a Telegram public group, I guess direct link(s) to message can do.

Hey, let me explain about this configs
Networkings:
CONFIG_VETH
CONFIG_NET_CLS_CGROUP
CONFIG_CGROUP_NET_CLASSID

this 3 are basically whats needed by lxc to make a virtual Ethernet and pass the network
There’s also 2 more
CONFIG_BRIDGE
CONFIG_NETFILTER_XT_TARGET_CHECKSUM

but like 99% of android devices already have it, i think it doesn't hurt to have them here as well
(note: about checksum, it's used in here, this script is taken from official lxc repo
Binder:
CONFIG_ANDROID_BINDER_DEVICES

I think it's obvious, we just need 3 more binder nodes for waydroid
Graphics:
CONFIG_SW_SYNC_USER

sw sync is used by HWC HAL to preform the sw vsync, although this config is only needed for devices with kernel 4.4 or lower, doesn’t have any effect in new kernels
Filesystem:
CONFIG_SQUASHFS
CONFIG_SQUASHFS_FILE_DIRECT
CONFIG_SQUASHFS_DECOMP_MULTI
CONFIG_SQUASHFS_XATTR
CONFIG_SQUASHFS_XZ
CONFIG_SQUASHFS_4K_DEVBLK_SIZE

We don’t use squashfs on waydroid (yet?) but anbox is having it maybe later in future we switch to squashfs, good to be prepared.
in another thoughts this configs also enable anbox compatibility, so i guess having squashfs is goos for both projects

@peat-psuwit ok for you with that description from Erfan?


Support for non-JSX HTML (or at least good error message about issues with it)

Should we allow support for traditional non-JSX html in markdown files?
Atm you can only use html if it is valid "jsx" so attributes must be camel-cased, class must be className etc. This is because we process all markdown files as MDX rather than markdown.
At very least i think we should have a good error message for this as i've seen this come up many times.
html style comments don't work
<!-- ... -->

Mention this because out of the box MDX (v2) does not support html comments and will throw and error like:
_mdx_bundler_entry_point-77f4c2f4-7bc6-4382-8a6e-cd2d3d4a7924.mdx:122:1: ERROR: [plugin: @mdx-js/esbuild] Unexpected character `!` (U+0021) before name, expected a character that can start a name, such as a letter, `, or `_` (note: to create a comment in MDX, use `{/* text */}`)

Instead mdx supports JSX comments e.g. {/* ... */}
See https://github.com/mdx-js/mdx/issues/1042 for discussion and suggestion of using a plugin like https://github.com/leebyron/remark-comment to resolve the problem

Another data point: just fixed an issue in https://datahub.io/core/atp-world-tour-tennis-data which was 500'ing
Change is here https://github.com/datasets/atp-world-tour-tennis-data/commit/4620a2f1fbc61843919891ba7bb865f591ac3d37 and basically it was just removing some html - this was based on my wild guess was there was something likely in the html (90% of 500 errors are react barfing on html in some way b/c react is very exacting regarding html)


Add first SPANISH version

@dandesousa hope the intent is clear, but I'm not so sure where do these plurals are shown.

Its clear! These are for research reward inputs, so you can input in your native language. I will merge this and add Spanish to the supported languages. There will be additional translation efforts in the future for other bot components and output


Fix dulwich checkout

Fixes #348
I did a little digging in dulwich and found that someone had seemingly fixed our checkout issue in a partially-unmerged pull request here.  I wrote a regression test, ported their checkout() code into our utils, and now things seem to be working correctly.
Regression demo:
# regression test without my fix; should fail
git checkout baae07da1b5cd2da6518d394313670f146b448dc
agentos clear-cache -y
pytest tests/test_repo.py::test_repo_checkout_bug

# regression test should pass with my fix applied
git checkout nj_dulwich_fix_2
agentos clear-cache -y
pytest tests/test_repo.py::test_repo_checkout_bug

@andyk ready for you to take a look!


FATAL ERROR for pigeon sort

Operating system
CentOS Linux release 7.5.1804
Package name
isoseq3 3.8.1 (commit v3.8.1) and pigeon 1.0.0 (commit -v1.0.0),but always have an error:FATAL | pigeon sort ERROR: 1 - could not read GFF file,could not read  GFF format from IsoSeq collapse.
Conda environment
Describe the bug
But always have an error:FATAL | pigeon sort ERROR: 1 - could not read GFF file,could not read  GFF format from IsoSeq collapse.
Error message
| 20230215 12:09:29.024 | FATAL | pigeon sort ERROR: 1 - could not read GFF file
To Reproduce
Expected behavior
Help me fix the bug,Thanks!

Please post all commands that you ran to reproduce this bug.

conda activate PacBio
lima  ../E.ccs.bam ../primers.fasta E.fl.bam --isoseq --peek-guess
lima  ../M.ccs.bam ../primers.fasta M.fl.bam --isoseq --peek-guess
lima  ../N.ccs.bam ../primers.fasta N.fl.bam --isoseq --peek-guess
lima  ../P.ccs.bam ../primers.fasta P.fl.bam --isoseq --peek-guess
lima  ../Z.ccs.bam ../primers.fasta Z.fl.bam --isoseq --peek-guess
ls E.fl.NEB_5p--NEB_Clontech_3p.bam M.fl.NEB_5p--NEB_Clontech_3p.bam N.fl.NEB_5p--NEB_Clontech_3p.bam P.fl.NEB_5p--NEB_Clontech_3p.bam Z.fl.NEB_5p--NEB_Clontech_3p.bam > all.fofn
isoseq3 refine all.fofn ../primers.fasta flnc.bam --require-polya --log-level DEBUG
isoseq3 cluster flnc.bam clustered.bam --use-qvs --verbose
pbmm2 align --preset ISOSEQ --sort  outs1/clustered.bam  shrimp.genome.fa  mapped.bam
isoseq3 collapse --do-not-collapse-extra-5exons  mapped.bam  collapsed.gff
pigeon sort  collapsed.gff  -o sorted.gff
| 20230215 12:09:29.024 | FATAL | pigeon sort ERROR: 1 - could not read GFF file

@armintoepfer ,
Sorry to bother you, I have a very confusing question. I used pigeon in isoseq3 to get the gtf file after the sorted isoforms, sorted.filtered_lite.gff file.  But now I want to compare the length and numbers of transcripts between this output file and the gtf annotation file I input in terms of completeness. Do you have supporting software or parameters?  Hope to get your reply, thank you very much!

@armintoepfer @jmattick ,Sorry to bother you, but we have a question that has been bothering us for a long time. We have consulted a lot of data but failed to get an answer. I hope to get some effective reply here.  It was obvious that there were new genes and transcripts identified by the pacbio full-length transcriptome, but I wanted to align this annotated file with the reference annotated file to make the genetic structure annotations more complete, but there was no evidencemodeler to do that. Unfortunately,  evm did not retain these variable splicing bodies, which is a pity. Do you have any suggestions? Thank you very much for your help!

@jmattick please have a look

@jmattick ,Could you please answer my question

@armintoepfer ,Sorry to bother you, but we have a question that has been bothering us for a long time. We have consulted a lot of data but failed to get an answer. I hope to get some effective reply here. It was obvious that there were new genes and transcripts identified by the pacbio full-length transcriptome, but I wanted to align this annotated file with the reference annotated file to make the genetic structure annotations more complete, but there was no evidencemodeler to do that. Unfortunately, evm did not retain these variable splicing bodies, which is a pity. Do you have any suggestions? Thank you very much for your help!


Reinviting an employee fails

If an employee removes his account and the organization tries to reinvite the user again, we get the exception below. Maybe the account is not removed completly:
2016-11-22 20:36:01 EXCEPTION User with ID 583499116b10f8d70d7b23c6 is not active in /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/module/Auth/src/Auth/Repository/User.php on line 276
[Trace]
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/module/Auth/src/Auth/Repository/User.php
        Line: 75
    Function: assertEntity
       Class: Auth\Repository\User
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/module/Auth/src/Auth/Repository/User.php
        Line: 174
    Function: findOneBy
       Class: Auth\Repository\User
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/module/Organizations/src/Organizations/Controller/Plugin/InvitationHandler.php
        Line: 308
    Function: findByEmail
       Class: Auth\Repository\User
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/module/Organizations/src/Organizations/Controller/Plugin/InvitationHandler.php
        Line: 237
    Function: loadOrCreateUser
       Class: Organizations\Controller\Plugin\InvitationHandler
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/module/Organizations/src/Organizations/Controller/InviteEmployeeController.php
        Line: 40
    Function: process
       Class: Organizations\Controller\Plugin\InvitationHandler
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/vendor/zendframework/zend-mvc/src/Controller/AbstractActionController.php
        Line: 82
    Function: inviteAction
       Class: Organizations\Controller\InviteEmployeeController
        Type: method
------------------------------
    Function: onDispatch
       Class: Zend\Mvc\Controller\AbstractActionController
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/vendor/zendframework/zend-eventmanager/src/EventManager.php
        Line: 490
    Function: call_user_func
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/vendor/zendframework/zend-eventmanager/src/EventManager.php
        Line: 263
    Function: triggerListeners
       Class: Zend\EventManager\EventManager
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/vendor/zendframework/zend-mvc/src/Controller/AbstractController.php
        Line: 118
    Function: triggerEventUntil
       Class: Zend\EventManager\EventManager
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/vendor/zendframework/zend-mvc/src/DispatchListener.php
        Line: 118
    Function: dispatch
       Class: Zend\Mvc\Controller\AbstractController
        Type: method
------------------------------
    Function: onDispatch
       Class: Zend\Mvc\DispatchListener
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/vendor/zendframework/zend-eventmanager/src/EventManager.php
        Line: 490
    Function: call_user_func
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/vendor/zendframework/zend-eventmanager/src/EventManager.php
        Line: 263
    Function: triggerListeners
       Class: Zend\EventManager\EventManager
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/vendor/zendframework/zend-mvc/src/Application.php
        Line: 340
    Function: triggerEventUntil
       Class: Zend\EventManager\EventManager
        Type: method
------------------------------
        File: /home/cbleek/Projects/YAWIK/build/YAWIK-0.27.2/public/index.php
        Line: 49
    Function: run
       Class: Zend\Mvc\Application
        Type: method

Removing an account was implemented in #274 as outlined in #103.
This implementation does indeed only inactivate the user account.
Thus, it is working as intended at the moment.
The question is, do we want to remove the account completely or just allow the reinviting of inactive users?

we want to delete the account completely


Multi team support

It will be great if you can add an option for multi-team support like --team company1

Hi @ashkanr, multi-team support is possible when using an advanced config by using the channel option like --channel team1:general

closing


MultiUrlPicker with min:0 max:1 throws null reference exception if nothing selected

I've tried the same outside of dtge and this correctly returns null, so maybe a convertor issue with dtge?

Any ideas other than the try, catch (and disabling break on System.NullReferenceExceptions in vs2022)

I'm also getting this issue with the MultiUrlPicker.
It seems that the converter for the Links in Umbraco now expects those to either be null or have a value but the DocTypeGridEditor converter is returning an empty string which gets parsed into null and causes this issue.

My mistake it was also the multiUrlPicker for me.. not the mntp.
Think it's resolved with a custom value processor...
using Umbraco.Cms.Core;
using Our.Umbraco.DocTypeGridEditor.Helpers;
using Umbraco.Cms.Core.Composing;
using Umbraco.Cms.Core.DependencyInjection;
using Our.Umbraco.DocTypeGridEditor.ValueProcessing;
using Newtonsoft.Json;
using System.Linq;

namespace www.Extensions.Dtge
{
    public class UmbracoMultiUrlPickerValueProcessor : IDocTypeGridEditorValueProcessor
    {
        public bool IsProcessorFor(string propertyEditorAlias) => propertyEditorAlias.Equals(Constants.PropertyEditors.Aliases.MultiUrlPicker);

        public object ProcessValue(object value)
        {

            if (value == null)
            {
                // When the value is null, we need to fake an empty enumerable since this is
                // how Umbraco would store an empty "Umbraco.MultiUrlPicker"-property.
                return Enumerable.Empty<object>();
            }

            // Returns a string-version of the JArray that DTGE would pass.
            return value;
        }
    }

    public class TsdDocTypeGridEditorComposer : IComposer
    {
        public void Compose(IUmbracoBuilder builder)
        {
            builder.DocTypeGridEditorValueProcessors().Append<UmbracoMultiUrlPickerValueProcessor>();
        }
    }
}

I recently upgraded a clients Umbraco from 8.17 to 8.18 and I experience this problem there as well (using dtge 1.2.9). Could you provide a fix for Umbraco 8.18 as well?

I had the same issue when upgradind to 8.18.
I had to rollback to 8.17.

I have temporary fixed in this way, but of course a package update would be preferable.
    var linkProperty= model.GetProperty("link");
    Link link = null;
    if (linkProperty.HasValue())
    {
        link = linkProperty.GetValue() as Link;
    }

Can anyone test if there are other "multiple" editors that does the same? I saw that Multinode tree picker was doing the same. If anyone can check content picker and media picker, it would be nice.

It breaks if you have pickers inside Nested Content inside DTGE too 😖

Another workaround (that works with Nested Content in DTGEs), is to replace the value converter for the multiurl picker with this one:
using System.Linq;
using Umbraco.Core;
using Umbraco.Core.Composing;
using Umbraco.Core.Logging;
using Umbraco.Core.Models.PublishedContent;
using Umbraco.Core.PropertyEditors;
using Umbraco.Web.Models;
using Umbraco.Web.PropertyEditors;
using Umbraco.Web.PublishedCache;

namespace myproject
{
    public class Startup : IUserComposer
    {
        public void Compose(Composition composition)
        {
            //If the type is accessible (not internal) you can deregister it by the type:
            composition.PropertyValueConverters().Remove<Umbraco.Web.PropertyEditors.ValueConverters.MultiUrlPickerValueConverter>();

        }
    }

    public class MultiUrlPickerValueConverter : Umbraco.Web.PropertyEditors.ValueConverters.MultiUrlPickerValueConverter
    {
        public MultiUrlPickerValueConverter(IPublishedSnapshotAccessor publishedSnapshotAccessor, IProfilingLogger proflog) : base(publishedSnapshotAccessor, proflog)
        {
        }

        public override object ConvertIntermediateToObject(IPublishedElement owner, IPublishedPropertyType propertyType, PropertyCacheLevel referenceCacheLevel, object inter, bool preview)
        {
            var maxNumber = propertyType.DataType.ConfigurationAs<MultiUrlPickerConfiguration>().MaxNumber;

            if (string.IsNullOrWhiteSpace(inter?.ToString()))
            {
                return maxNumber == 1 ? null : Enumerable.Empty<Link>();
            }

            return base.ConvertIntermediateToObject(owner, propertyType, referenceCacheLevel, inter, preview);
        }
    }
}

@skttl Awesome! Your work around works great! I'll use it until the package has been updated

I won't fix this in the package, as it would require too much. The thing is, that at breaks inside Nested Content too, so the ValueProcessor mentioned by @mistyn8 needs to look inside those too - and potentially nested content items inside nested content items.
So it needs to be fixed in Umbraco - and until then, the extended value converter is the workaround.


VSCode leaking memory

Issue Type: Bug
Sorry I have little information.  I only just now noticed the "Process Explorer" feature that I will try if this happens again.
All I can say is that through Windows Task Manager I discovered that VSCode had gobbled 15G of RAM.  I tried to close it and in Windows task bar it appeared gone but Task Manager showed it still active, so I killed it and the 15G was immediately restored.
Let me know if there is anything I can do to help you diagnose this.
VS Code version: Code 1.53.2 (622cb03f7e070a9670c94bae1a45d78d7181fbd4, 2021-02-11T11:48:04.245Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.86GB (20.79GB free)

Process Argv
--crash-reporter-id 383c58f2-21d9-4471-b4b7-48bc20f1f233

Screen Reader
yes

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

Bookmarks
ale
13.0.0

aurelia
Aur
1.0.7

markdown-preview-github-styles
bie
0.1.6

path-intellisense
chr
2.3.0

vscode-svgviewer
css
2.0.0

vscode-npm-script
eg2
0.3.15

vscode-pull-request-github
Git
0.23.1

search-editor-apply-changes
jak
0.1.1

remote-wsl
ms-
0.53.4

powershell
ms-
2020.6.0

typescript-javascript-grammar
ms-
0.0.55

debugger-for-edge
msj
1.0.15

vscode-scss-formatter
sib
2.1.0

vscode-open-in-github
sys
1.14.0

shell-launcher
Tyr
0.4.1

gitblame
wad
6.0.2

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspyt653:30253241
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244cf:30256637
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30251590

/needsMoreInfo pls follow this guide to helps us track down memory issues https://github.com/microsoft/vscode/wiki/Performance-Issues


Redesign reporting dashboard

User story

As a developer
I want / need to redesign the reporting dashboard
In order for it to have the same look and feel as the rest of the UI

Acceptance criteria

Have seamless look and feel of the UI in the reporting dashboard

Definition of done

Code review from peers has been completed and passed

Code is fully implemented and commented
Adheres to coding guidelines
Commits are not squashed
Code is checked into the repository

Unit tests for backend have been written and are passing
Manual performance tests on the browser are passing
No critical bugs are open

closed on 07.07.2021


Weird serialization behaviour

Consider the following message definition in C#:
public interface CreateUser
{
    string UserId { get; }
    string UnverifiedPrimaryEmail { get; }
    string Language { get; }
}

F# has explicit interface implementations. The syntax looks like this:
type CreateUserMsg(uid, email, lang) =
  interface CreateUser with
    member _.UserId = uid
    member _.UnverifiedPrimaryEmail = lang
    member _.Language = email

For some reason, instantiating and sending this will send a message where all the properties are null.
As a counter-example, the following works fine:
type CreateUserMsg(uid, email, lang) =
  member _.UserId = uid
  member _.UnverifiedPrimaryEmail = email
  member _.Language = lang

  interface CreateUser with
    member _.UserId = "some"
    member _.UnverifiedPrimaryEmail = "other"
    member _.Language = "value"

Note that if one of the non-interface members are removed or renamed, that member will be serialized to null even though the interface contains the correct value. And that the actual (explicit) interface members are not used at all.
It might seem like MassTransit assumes the class itself contains members corresponding to those in the interface, and does not account for explicit interface implementations (which AFAIK is supported in C# too, by the way).

I would suggest reading:
https://masstransit-project.com/usage/messages.html
and
https://masstransit-project.com/usage/producers.html#message-initializers
There are a lot of things MassTransit does for interfaces.

And I don't know what you mean by supported in C#, versus what you're describing.

I just meant that explicit interface implementations is not just an F# thing, though of course it's seldom seen in C#.

I think you mean implicit? Almost every implementation of an interface in C# is explicit, as in, class Whatever : ISomething. Anyway, tangent.

No, my use of implicit/explicit was correct.
I checked out the links, but I don't really get it. You seem to send a message by using an anonymous object. Then you lose the strong typing. You can place any member there and there is nothing stopping you from typos or leaving out interface members entirely. Isn't part of the point of MassTransit to get strong typing of messages?

Oh, I thought you were referring to implementations of interfaces. Yeah, I used explicit a lot. Anyway.
MassTransit uses the type system for messages. That can be done using classes or interfaces, whereas interfaces are preferred for message contracts. When sending messages, you can implement the interface using a class, and send that class, or you can use the message initializer to initialize the properties to values, very similar to how ASP.NET Core uses anonymous types to pass arguments.
There is a Roslyn analyzer that will notify if properties are missing, that's a new thing but it's now available. Prior to that, it just required paying attention. It's up the user, they can do whatever they want, but too often creating mapping code between different types is busy/noisy code.
It's all about whatever engineers want to use, they have choices.

Hm, it seems that Newtonsoft.Json does not serialize interfaces automatically:
type IFoo =
  abstract A: string with get
  abstract B: string with get

type Foo () =
  interface IFoo with
    member _.A = "a"
    member _.B = "b"

let fooAsIFoo = Foo () :> IFoo

JsonConvert.SerializeObject fooAsIFoo
// Returns "{}", I had expected "{ "A": "a", "B": "b" }"

However, System.Text.Json correctly serializes it:
JsonSerializer.Serialize (fooAsIFoo)
// Returns "{ "A": "a", "B": "b" }"

Is it possible to configure MassTransit to use System.Text.Json for serializing? Any gotchas?

There has been no effort to add support for System.Text.Json to MassTransit at this point.

You could say it's specific to F#:

In C#, sending an instance of a message class (that implements the message interface) works as expected, because the class is more or less guaranteed to have members that correspond to the interface members (due to everyone using implicit interface implementations in C#)
In F#, there is only explicit interface implementations, which means the class members and the interface members are decoupled. As I showed, you can implement an interface without having "non-interface" class members corresponding to that interface.

When the class is serialized by Newtonsoft.Json, it seems to only use class members, not explicit interface members. Which is why it works in your C# unit tests, but not in my F# example.

There has been no effort to add support for System.Text.Json to MassTransit at this point.

Just so we're clear, are you saying that it's not possible to configure the serialization behaviour in MassTransit to use an arbitrary serializer? I have seen some methods for serialization configuration; are those only for configure Newtonsoft.Json?

You can certainly create a new serializer by implementing the interfaces and adding it to the supported serializers/deserializers.
You can configure the entire bus instance (all receive endpoints) or a single receive endpoint to use a serializer, as well as support the deserializer, using:
configurator.SetMessageSerializer(() => new RawJsonMessageSerializer());

configurator.AddMessageDeserializer(RawJsonMessageSerializer.RawJsonContentType,
    () => new RawJsonMessageDeserializer(RawJsonMessageSerializer.Deserializer));

That's an example, you'd need your own content type. If you call:
configurator.ClearMessageDeserializers();

That will remove all of the default serializer/deserializers.

Adapt this huge thing here? No thanks, that's a maintenance burden I'd rather be without. I'll look for other workarounds instead. :)
For example, in addition to the message interfaces, I could actually implement their message classes in C# contract projects. It's not idiomatic, but it seems that's the only strongly typed way of sending strongly typed interface-based from F#, given the current serialization implementation.
Thanks for the help, though!


"Strange" rectangular boxes in VR when using Pimax XR (Assetto Corsa Competizione, Automobilista 2)

Describe the bug
Hello,
whenever I play Assetto Corsa Competizione or Automobilista 2 with PimaxXR instead of SteamVR, there are one or two rectangular areas visible in VR. These are not visible with Steam VR. It does not happen in other games. Just the two mentioned above. I could not make a screenshot which shows my real VR view. So I created one with Paint to replicate what I´am seeing (second screenshot).
Greetings
Environment
OpenXR Toolkit v1.3.2
PimaxXR v0.4.0
piTool V<IP_ADDRESS>4
Pimax 5k Super, Firmware V<IP_ADDRESS>3
Windows 10 Pro 22h2 64bit
MSI RTX 4090 Suprim X
Assetto Corsa Competizione V1.9.5
Automobilista 2 V<IP_ADDRESS> 2305
To Reproduce
Steps to reproduce the behavior:

Use PimaxXR instead of Steam VR
Play either ACC or AMS2
Rectangular box(es) are shown

Expected behavior
A clear and concise description of what you expected to happen.
View is the same as in Steam VR

pimax-openxr.log

Pitool 284 is very old, have you tried with newer stuff like Pimax Client 1.13?

Thanks for your reply. I just tried it with  Pimax Client 1.13, unfortunately with the same result. One "box" shown in ACC and two "boxes" shown in Automobilista. It seems like the "boxes" are the area, where the HUD is rendered.

Dirt Rally 2.0 is affected too, but luckily the two boxes are much less intrusive, just a slight red tint with some small border.
Using latest OpenComposite and Pimax Client <IP_ADDRESS>.
It looks more like #40

Interesting. Do you have the boxes also, if you use Steam VR? For me, they are only visible when using Open Composite + Pimax XR. For me, it also looks more like the screenshot you linked. Mine is overexaggerated, and poorly done with Paint :) But still, the box(es) are visible and disturbing. I wonder why it works with Assetto Corsa but not with Dirt Rally, ACC and AMS2. Maybe it has something to do with the game engine.

I also disabled all overlays in the Open XR Toolkit. Sadly it did not help.

PimaxXR has a "Show mirror window" option, can you try it and see if you can capture an image of the phenomenon there?

Hi mbucchia,
I just tried it. You can see the outlines of the boxes in the screenshot. In my headset, these boxes are about 95% transparent and a slightly brighter color than the rest of the screen.
Greetings

Thanks. At first glance this looks like the edges of quad layers submitted by the application. I don't do anything to those, just pass them to Pimax software for composition. So it looks like a Pimax bug, similar to the one we had with OpenXR Toolkit in the past.
Any chance you could try Pimax Client 1.10?

It's the same here, in the mirror window you can only see the edges, while trough the lenes the boxes are like 5% opaque.
Those two boxes are most likely projection layers to show the hud and menu. And the problem could be that the post-processing is applied not only on the whole screen but additionally also in the composition of those boxes. Or something like that.
I already tried the Dirt Rally 2.0 / OpenComposite / PimaxXR combination about a year ago, back when #40 was still open and it was already the same.
And i had exact the same, years ago when i tried to play the old Oculus-exclusive Dirt Rally 1 via Pitool.
While it worked fine without those boxes via Revive in SteamVR.
So it's probably not a bug in OpenXR or OpenComposite since both weren't involved then..

Thanks for the details.
It works fine with SteamVR  because SteamVR does its own composition of quad layers (2D menus, HUDs), bypassing the bogus Pimax composition.
However PimaxXR (and I suspect Oculus mode emulation in Pitool) do not do that, and instead they rely on the quad layer composition in Pimax software, which had been crippled with bugs.
I don't think there is much I can do here. This is an issue Pimax needs to fix. I will try to write a bug report to them.

Another point: When starting the race, the screen is black and then fades in.
But via OpenComposite & PimaxXR, not the whole screen is black but only one of those boxes.
So maybe one of those boxes is meant to cover the whole view..
Or this fading is done via post processing and post-processing is applied only to the boxes instead of the screen for some reason..
Yeah, i'm fine with using SteamVR but it would be nice if they would fix this someday.. :-)

Closing since these are Pimax issues I cannot do anything about.


Invalid packet received. Unabled to find requested cached node

Godot version:
3.2.1-stable
OS/device including version:
Windows<->Mac
Issue description:
Communication between Mac and Windows with High Level Multiplayer doesn't work on 3.2.1-stable git branch.
On Windows log printed : Invalid packet received. Unabled to find requested cached node.
Steps to reproduce:
Try to host a windows server and to connect with a mac client and reverse too.(Works on 3.1.2-stable git branch)
Minimal reproduction project:
Any network game with High Level Multiplayer abstraction.

Sorry, but without a minimal reproduction project this is not going to be solved.

So my bad... wasn't using 3.2.1 on both computer...


Tut s ochannel

What changes does this PR introduce?
new tutorial doc (reentrant channel)

@jrscott A side note: I tried to keep some comments in "data.diagnostics" regarding most common
parameters for each namelist. I think it could be useful since parameter from namelist are not used in the pkg/diagnostics code but copied to other that are then used (meaning, searching from then in code or header file "DIAGNOSTICS.h" will nto return anything).
In tutorial_baroclinic_gyre/input/data.diagnostics, you kept these comments in. But in this new tutorial, all these comments are gone. May I suggest to put them back ?

thanks for the comments @edoddridge. As you might gave expected this went through several iterations and a bunch of things you caught were not updated with changes along the way, so great to catch.
Responding to overall comments:

yeah I should probably say more about the convection GM v. non-GM. One point was that the ML depth diag was not really reflecting the extent of cvct in non-GM in runs along the way but let me revisit.
-let me weigh the suggested changes to 4.10. In hindsight the wall on the N would have been better. In new text (not yet checked in) I more explicitly say the southern wall is equivalent to being in the north, so perhaps I could show that.  Changing up the config, or making significant changes to this figure require some work and time -- but I don't disagree with your points.
I had the zonal mean bathy plotting at one point, not sure what I did to lose it (was not on purpose...). BTW the rational for showing this is that we are taking zonal mean layer depths so might as well show mean bathy? (even though the zonal mean bathy is a bit meaningless per se), since most of the domain is flat bottom except for the the NS ridge)

PS fwiw both jmarsh and @jm-c have reviewed the intro, but not the solution section yet. @jm-c changes to be checked in next few days.

yeah I should probably say more about the convection GM v. non-GM. One point was that the ML depth diag was not really reflecting the extent of cvct in non-GM in runs along the way but let me revisit.

The diagnostic convadj is probably more useful than mld for the open ocean convection question.

-let me weigh the suggested changes to 4.10. In hindsight the wall on the N would have been better. In new text (not yet checked in) I more explicitly say the southern wall is equivalent to being in the north, so perhaps I could show that. Changing up the config, or making significant changes to this figure require some work and time -- but I don't disagree with your points.

👍 I don't think we need to make big changes. But having a wall on one of the meridional boundaries would more accurately represent the situation.

BTW the rational for showing this is that we are taking zonal mean layer depths so might as well show mean bathy?

Yeah. Without the zonal-mean bathymetry, there is an unaccounted for gap. If we sum up the layer thicknesses from the bottom, then we need to start from the zonal-mean bath height, or we get silly/strange answers for the surface elevation.

@edoddridge,
Regarding GM vs. non-GM comparison:

probably should also reference Gent 2011 Ocean Modelling 39 (a perspective on GM), maybe add reference to this/mention  in intro. That being said the main purpose here is not to revisit this difference, but rather show how to use GM.
looked at conv adj, that doesn't really show much beyond what you can infer from the MLdepth line (and as it is a 3D field, hard to show anyway). The bump in non-GM occurs I think as discussed in Gent 2011, Deacon cell brings cold water N in non-GM and make columns unstable -- however the NS ridge-notch topo creates regions where the cold water can't flow easily.

I don't want make to make this tutorial any longer or add figures, if possible. But I do agree more should be said about the difference in ML depth in the figure, refer to classic paper, maybe point out the odd result (without getting into this in detail) -- thinking just add a sentence in the model results where the figure discussed.

Thoughts? (or suggest sentences to add/change?)

probably should also reference Gent 2011 Ocean Modelling 39 (a perspective on GM), maybe add reference to this/mention in intro. That being said the main purpose here is not to revisit this difference, but rather show how to use GM.

I agree. We're not trying to do a literature review, but, I think it's a good idea to help readers learn about the gfd as well as the model.

looked at conv adj, that doesn't really show much beyond what you can infer from the MLdepth line (and as it is a 3D field, hard to show anyway). The bump in non-GM occurs I think as discussed in Gent 2011, Deacon cell brings cold water N in non-GM and make columns unstable -- however the NS ridge-notch topo creates regions where the cold water can't flow easily.

Again, I agree. If you know what you're looking at, then the mixed layer depth and the convective adjustment have a lot of overlap. But, the change in deep convection locations was one of the big results in the Danabasoglu et al. (1994) paper: "A comparison... shows significant improvements in the global temperature distribution, the poleward and surface heat fluxes, and the locations of deep- water formation." I therefore think it's worth mentioning, and probably worth a plot. A 2D plot like the one you posted here is sufficient, I think.

I don't want make to make this tutorial any longer or add figures, if possible.

Absolutely. It's already very long. And fundamentally, it's about learning the model, not the gfd. Still, I think it's important to present to the convective adjustment result - it's one of the reasons why GM is so widely used. One figure, a sentence or two, and a couple of references. How do you feel about that?

@edoddridge think we are on the same page. worked up this figure, pick top or bottom set? I don't think it is bad to discuss use of convadj diag, although the top shows more info. My vote would be show top but mention convadj diagnostic.

@edoddridge fixing the res moc-> z coor, showing zonal mean bathy now. In the caption I changed to "and converted back into (zonal mean) depth coordinates" but perhaps that confusing
(should I say anything about the gray space at bottom and wall or is this obvious?)

I'd go for the bottom the set - I think that the interpretation is clearer. If we show mixed layer depth, then the reader has to think through the correspondence between mld and convection. Presumably they'd get there, but, we specifically have an output that shows convection. Let's use it. As a bonus, it means we are featuring an additional diagnostic.
I also prefer the bottom set because the comparison is so stark - without GM we get convection in many open ocean cells. With GM, convection is restricted to the southernmost (and coldest) cells. It's just so clear.

@edoddridge fixing the res moc-> z coor, showing zonal mean bathy now. In the caption I changed to "and converted back into (zonal mean) depth coordinates" but perhaps that confusing
(should I say anything about the gray space at bottom and wall or is this obvious?)

Hmm. I'm not sure. If I were writing it, I'd go for "and convert back into depth coordinates using the zonal-mean layer thicknesses summed upwards from the zonal-mean bathymetry." But, I think the parentheses work. I would mention that the grey shows the depth of the zonal-mean bathymetry. We're providing the code that produces the figures, so hopefully people can follow the logic there.

not yet addressed: any changes to schematic figure; sentence about residual circulation (in non-GM, non-eddy case) flagged by @edoddridge.

Any progress on this @jrscott ? Would be good to merge it in.

I agree, working on getting second review completed.

@jrscott regarding the first point (vertical viscosity stability criteria):
I suggest to modify this paragraph to mention right away that there is no criteria that
applies since we are using implicitViscosity=T.
Instead of "Using Adams-Bashforth for vertical ...", I would suggest something like:
"Regarding the vertical viscosity, we choose to solve this term implicitly (Euler backward
time-stepping) by setting implicitViscosity to .TRUE. in input/data, which results in no
additional stability constrain on model time-step (see Section 2.6).
Otherwise, given that our vertical resolution is quite fine near the surface (~5.m),
the following stability criteria would have applied:
S_lv = ... < 1.0
limiting our choice for Av to small values."
And then continue with "For simplicity ... "
Jean-Michel

@jm-c:

your suggestion is good, basically followed what you said. Made last sentence in para here more clear too.
I've made sequences follow data.pkg order: gmredi,rbcs,layers,diagnostics throughout. Had to make a few tweaks as a sentence here and there was based on old ordering (e.g. moved sentence from data.diags section to data.layers)
done
done see other post
done about tau_x and SST. init temp is actually (y,z) ( I referred to the figure in the beginning) but also made this point.
isn't the best answer here to add diagnostics to RBCS to dump this? but I can do two things: be less negative in the phrasing :) and more specific in the last part of the sentence about computing it.

@jm-c on point 6:
This is not completely trivial what to say/do. The idea was to look at the heat gain in the sponge layer, somewhat as a sanity check what the sponge is doing. At the surface one computes relaxing heat flux as W/m2 but as this is on the sidewall, not sure whether better to compute as W or W/m2 (the former however will be affected by the varying delZ so maybe the latter is better).
On a technical level which is the best rho to use when converting into watts here? (the Bouss rhoConst?)

actually as there are multiple gridcells thick in the sponge layer W might be better

changes in PR#373


[FEAT]: Create Issue forms and make the issue options more visually appealing

Describe the Feature you want to end

Currently, the issue template for this repo seems to be basic also it is less visually appealing.👇

Changes I will make

Expected behavior

Screenshots (optional)

Additional context (optional )
Will add issue forms to the respective issues to make it easier for the contributor to raise it.
Here is an example of how a Bug Issue Form will look like 👇

Kindly assign me this issue under GSSOC'24

i can solve this issue within 2-hrs of assignment with cutting edge perfection and appealing design which enhances user experience

hey @dakshsinghrathore  thank you for your detailed explanation, I am assigning this issue to you, please work on it

@Its-Aman-Yadav Hey I have created the PR, do add the apt. level label for this issue


Use logback instead of log4j to fix logging issues

This fixes issue #221 .
We have both log4j and logback jars and looks like slf4j is hitting logback jar  first(as classloader seems to be loading those before log4j). In this case logback ignore log4j.xml and uses default configuration where it spits out everything to console. Default console logger is synchronous and hence it could be performance issue as well if we are logging too much.
Logback has really cool features like ability to change log level at runtime using JMX (which is available in log4j2 but not in log4j)
I have put together logback.xml to mimic intending log configuration we were trying to achieve using log4j.xml, with some more added features like automatically delete log file more than 15 days old.

Looks good. And seeing the current state of logging in JmxTrans, it can only improve the situation ;-)

Thanks for your help !

Note that the move from log4j.xml to logback.xml is also a breaking compatibility, but it actually fixes the log4j / logback conflict that is breaking logging for a fairly long time ...
My opinion: we should break compatibility and make logging work ...


fix command buf resize

@ploxiln Please take a look.

There's another issue with nsq_buffer_add() - it leaks the allocated buffer b. The call to buffer_add(buf, b, n); copies it into the buf, and does nothing else with it. So it should free(b);.
But actually, this whole function does what buffer_add() does! It doesn't need to allocate any buffer, it can just write each part to buffer_add() which will do the same kind of thing:
    expand = buf->length;
    while (expand < need) {
        expand = expand * 2;
    }

ok, so ignore this pr. I will close it.


integrate with Google ContainerRegistry support in docker-client

Updates docker-client to 8.6.0 which has support for configuring the
DockerClient instance to authenticate against Google Container Registry.
(Note: this requires https://github.com/spotify/docker-client/pull/762 to be merged and released in docker-client first, before this PR can be merged)
The credentials to use in authenticating for pulls from GCR are
configured with a new flag --docker-gcp-account-credentials. The GCR
authentication layer is only enabled when this flag is set. This
argument value is expected to be a file containing the JSON key for the
service or user account to pull images with.

I made sure that this logs what file is being read at startup (and the identity in it) for troubleshooting:
10:50:22.887 helios[7111]: INFO  [AgentMain STARTING] AgentService: loading Google Cloud credentials for Docker from /Users/mattbrown/Downloads/xxx.json
10:50:23.036 helios[7111]: INFO  [AgentMain STARTING] ContainerRegistryAuthSupplier: loaded credentials for service account with<EMAIL_ADDRESS>

I think the only test we could do here is test that AgentService constructs a DockerClient with this registryAuthSupplier instance when agentConfig.getGoogleCloudAccountCredentials() is set, but the auth info is not exposed by DefaultDockerClient today for a test to assert against, so we'd have to add all that 😞

Require upper bound dependencies error for ch.qos.logback:logback-classic:1.1.11 paths to dependency are:
+-com.spotify:helios-services:0.9.0-SNAPSHOT
  +-ch.qos.logback:logback-classic:1.1.11
and
+-com.spotify:helios-services:0.9.0-SNAPSHOT
  +-com.spotify:helios-tools:0.9.0-SNAPSHOT
    +-ch.qos.logback:logback-classic:1.1.11 (managed) <-- ch.qos.logback:logback-classic:1.1.2
and
+-com.spotify:helios-services:0.9.0-SNAPSHOT
  +-net.kencochrane.raven:raven-logback:4.1.1
    +-ch.qos.logback:logback-classic:1.1.11 (managed) <-- ch.qos.logback:logback-classic:1.0.13
and
+-com.spotify:helios-services:0.9.0-SNAPSHOT
  +-com.spotify:docker-client:8.6.0-SNAPSHOT
    +-ch.qos.logback:logback-classic:1.1.11 (managed) <-- ch.qos.logback:logback-classic:1.2.1
and
+-com.spotify:helios-services:0.9.0-SNAPSHOT
  +-com.spotify:logging:2.0.17
    +-ch.qos.logback:logback-classic:1.1.11 (managed) <-- ch.qos.logback:logback-classic:1.0.13
and
+-com.spotify:helios-services:0.9.0-SNAPSHOT
  +-io.dropwizard:dropwizard-core:0.7.1
    +-io.dropwizard:dropwizard-jackson:0.7.1
      +-ch.qos.logback:logback-classic:1.1.11 (managed) <-- ch.qos.logback:logback-classic:1.1.2
and
+-com.spotify:helios-services:0.9.0-SNAPSHOT
  +-io.dropwizard:dropwizard-core:0.7.1
    +-io.dropwizard:dropwizard-logging:0.7.1
      +-ch.qos.logback:logback-classic:1.1.11 (managed) <-- ch.qos.logback:logback-classic:1.1.2

@gimaker I decided to include the refactoring you suggested, please take another look.
Now that docker-client 8.6.0 is released, I think this PR is all-good for review.

upgrading jackson seems to cause AddExtraHostContainerDecoratorTest.simpleTest() to fail 😖

Codecov Report

Merging #1120 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1120      +/-   ##
============================================
+ Coverage     52.14%   52.18%   +0.04%
+ Complexity     1582      792     -790
============================================
  Files           267      121     -146
  Lines         12827     6387    -6440
  Branches       1479      927     -552
============================================
- Hits           6688     3333    -3355
+ Misses         5632     2736    -2896
+ Partials        507      318     -189


webhooks: move to v1

This was added to K8s and istio over 3 years ago. Time to start moving
over so we can be on only v1 APIs.
Note we do not remove support for handling v1beta1 in Istiod go code; we
can do that in a few releases

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
47a2ae2c0907d9bd8b71e84f92e82b852fa91572
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
cbb15048768f04e931ced9e0fda6b46428f89b23
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
cbb15048768f04e931ced9e0fda6b46428f89b23
link
true
/test unit-tests-arm64

integ-basic-arm64_istio
cbb15048768f04e931ced9e0fda6b46428f89b23
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest


Add container late binding

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
❌

Tests pass?
✔

Added container late binding/injecting. Just replace RouteCollectorInterface::class => new GroupFactory() with RouteCollectorInterface::class => new Group() in the your container config and the container will be injected into Route immediately before processing.

Too magical behavior

Too magical behavior

Why? It is very clear.

👍


Image classification-Azure: Training failed when you create and use a "Standard_NC24" or "Standard_NC24r" size compute.

System Information (please complete the following information):
Windows OS: Windows-11-Enterprise-21H2
ML.Net Model Builder 2019&2022: <IP_ADDRESS>3103
URL: https://privategallery.blob.core.windows.net/gallery/refs/heads/u/zewd/UpdateVmsHotFix/atom.xml
Microsoft Visual Studio Enterprise: 2019(16.11.18); 2022(17.3.0)
.Net: 5.0 & 6.0
Describe the bug

On which step of the process did you run into an issue:
Training failed when you create and use a "Standard_NC24" or "Standard_NC24r" size compute for Image classification-Azure scenario.

TestMatrix
https://testpass.blob.core.windows.net/test-pass-data/weather.zip
To Reproduce
Steps to reproduce the behavior:

Select Create a new project from the Visual Studio start window.
Choose the C# Console App (.NET Core) project template.
Add model builder by right click on the project.
Select "Image classification>Azure" and then click "Set up workspace" button on the Environment page.
On the "Create new experiment" dialog, choose Subscription and Workspace, then click "New..." link next to "Compute name" option.
On the "Create new compute" dialog, give the compute name, then select "Standard_NC24" or "Standard_NC24r" compute size to complete the Environment selection.
On the Data page, choose large size images folder (Contains 1125 images).
On the "Training" page, you will see the training is failed with error.
There is not enough GPU memory on the machine to do the requested operation. Please try running the experiment on a VM with higher GPU memory, decrease the batch size or image size.

Expected behavior
Training should be successful when you create and use a "Standard_NC24" or "Standard_NC24r" size compute.
Screenshot

Additional context:

Repro on both of VS2022&2019.
If I choose small size image folder (Contains 64 images), training can be successful.
The bug is not repro when you create and use a "Standard_NC6" or "Standard_NC12" size compute.
RunID: https://ml.azure.com/experiments/id/891078f2-635b-4e43-849b-f5129264b1fa/runs/AutoML_53a4146f-0395-4312-a5d2-b0867e4cd9e8?wsid=/subscriptions/83635e26-687a-4333-a2a0-33e3cd1f573a/resourceGroups/FullTestPass/providers/Microsoft.MachineLearningServices/workspaces/FullTestPass&tid=72f988bf-86f1-41af-91ab-2d7cd011db47

@zewditu Can you look at this? Is this the right list of computes?

I used the old  vm-sizes to create  compute .
@v-Hailishi  are you able to get successful run  for already created computes with this vm-sizes? becouse Still we let userds to use existing computes with this vm-sizes

@zewditu I am able to get successful run for already created computes with "Standard_NC6" or "Standard_NC12" vm-sizes.
But I am not sure for "Standard_NC24" and "Standard_NC24r" vm-sizes, because I have no these size computes before.

The bug is also repro on the main branch: <IP_ADDRESS>5501.

Verified on the /u/zewd/UpdateVmsHotFix/ version <IP_ADDRESS>5201 and main branch: <IP_ADDRESS>5501

The Azure computes size have been updated like below.

When creating all new computes with Dedicated priority, I met the error message like below.
I also tried to increase the vCPU quotas for Standard NCv3 family vCPU, but I cannot find "Standard NCv3 family vCPU" quota under subscription "ML.NET Model Builder Demo" on the My quotas page. Could you help to take a look?

When creating all new computes with Low priority, they can be created successfully. But the training is always pending on "Provisioning compute..." step like below.

Tracking this in https://github.com/dotnet/machinelearning-modelbuilder/issues/1702


python311Packages.google-cloud-pubsub: 2.16.0 -> 2.16.1

Changelog: https://github.com/googleapis/python-pubsub/blob/v2.16.1/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 230501 run on x86_64-linux 1

10 packages built:

home-assistant-component-tests.google_pubsub
home-assistant-component-tests.nest
python310Packages.google-cloud-pubsub
python310Packages.google-cloud-pubsub.dist
python310Packages.google-nest-sdm
python310Packages.google-nest-sdm.dist
python311Packages.google-cloud-pubsub
python311Packages.google-cloud-pubsub.dist
python311Packages.google-nest-sdm
python311Packages.google-nest-sdm.dist


Add nilup, nada and instrumentation doc

Add nilup, nada and instrumentation doc
@oceans404 the instrumentation documentation is not linked anywhere, please feel free to link it whenever you need to. It will probably be good to have it linked in the quickstart when we recommend activating it.

sorry 😅 hoping these suggestions are received with the intent that they're written!

They are, thank you very much, keep doing them, please.


Angerman/feature/doc

Let's not merge this now. But keep this PR as a basis for discussion on the high level documentation.  My intention with this is to make navigation of the code base to people new to this project (and potentially shake) easier and explain how the parts are supposed to play together.

Thanks @angerman! I've been watching this for some time now and it's a very good start.
I think it will be easier to find in doc folder though. We may also think about a more informative name than README, to hint that this is a high-level overview.
Maybe doc/overview.md?

I hope later we can add more focused docs, such as doc/oracles.md, doc/expressions.md, etc.

I'd like to keep them as README.md in the folders primarily, because that way github shows their content rendered when browsing the source on github. Also I'd like to keep the source structure defined by the folders to mean something :)
It might be a good idea to replace them with symlinks and have the actual documentation in the doc folder. My hope is that by being very visible, it ends up being corrected more likely once someone sees a bug.
I certainly agree, that oracles and expressions should get their own subsection. I was planning on getting at the README.mds in Oracles and then in Settings, as I hoped that Rules are pretty self explanatory.
Not sure where to put Expressions though.
Let me know what you think!

I'd like to keep them as README.md in the folders primarily, because that way github shows their content rendered when browsing the source on github. Also I'd like to keep the source structure defined by the folders to mean something :)

Aha! I see, this makes sense, although feels unusual.

It might be a good idea to replace them with symlinks and have the actual documentation in the doc folder.

I really want to have all docs available in one place. People usually expect them in doc folder, other locations may be surprising, and surprises are typically bad in design :-) Does github support symlinks? If yes, this may be a good compromise.

I was planning on getting at the README.mds in Oracles and then in Settings

This feels fragile to me and adds weight for maintenance. Whenever things are coupled in this way, it is almost inevitable that some time in future they will desynchronise when someone forgets to update one after updating the other. What if we decide to refactor codebase into a different, better directory structure?

Not sure where to put Expressions though.

I'm afraid Expressions is not the only problem. There are other important concepts that are worth documenting, which are spread over the codebase and figuring out a proper doc location for them would be difficult.
Having said that, I see value in having README files in source directories, because they are shown automatically by github and hence may indeed help someone new to make sense of the codebase. We could provide brief descriptions of the local folder structure and link to appropriate documentation sections in the doc directory. This will also be fragile, but will be easier to keep in sync: we'll keep these READMEs very brief and link to stable documentation, which preferable should be as decoupled from folder structure as possible. For the documentation which must be tightly coupled with code we should use Haddock, I think.
Then there is also github wiki...
Let's keep discussing.

@snowleopard Thanks for the feedback, keep it coming!
I know it might be unusual, but I've wanted this for many projects many times already. Being somehow taken by the hand and guided through the structure and the project. Say a double decker city tour :grinning:
I guess the fragility depends a lot on the details put into those docs. I'm actually aiming for a very high level documentation without going too much into detail.  If I went too much into detail somewhere please highlight it, so I can drop some details.
I basically see three layers of documentation:

High level guidance about the projects structure and main ideas. (README.md(s))
Detailed discussion of the projects goals and inner mechanics. (Read the docs, Man page, ...)
Code level documentation, explaining the intent behind each function. (Haddocks)

As I've said elsewhere I'm not a big fan of github wiki pages. They feel like an after thought and just tacked onto the projects. They are also not part of source tree, which I think the documentation should be; even if it's the source for some documentation generation. E.g. cloning the source should give me the documentation as well, even though I might have to use tool T to produce the documentation from the information contained within the source repository. (E.g. for the code level documentation, that would be generation of the haddocks).
Hence my initial plan of attack was to build the very high level guidance through the source code, and then see where and how to add a deeper layer of detailed documentation, which I guess can perfectly live in /doc; I've hence tried to see if we can just symlink the README.md experimentally into the doc folder, but github doesn't play really nice here. As per explanation above, symlinking might actually not be a good solution.
If you consider the current README's good enough for /doc, we could move them there under different names; if my preference of one README per folder is considered harmful rather than helpful, I'm willing to rest my case on this; I see this only succeeding if everyone considers this useful, and hence will report inaccuracies.

I know it might be unusual, but I've wanted this for many projects many times already. Being somehow taken by the hand and guided through the structure and the project.

This does sound good!

I basically see three layers of documentation:

High level guidance about the projects structure and main ideas. (README.md(s))
Detailed discussion of the projects goals and inner mechanics. (Read the docs, Man page, ...)
Code level documentation, explaining the intent behind each function. (Haddocks)

I like these three layers. Let's give it a try! Please keep READMEs as brief and high-level as possible, linking to appropriate sections of doc files for any further details.
I think it is also important that doc files are independent of READMEs. That is: one can get all the information about the build system by looking only into doc folder, without the need to search for READMEs scattered in the source directories.
@angerman To sum up, let's go ahead with your approach!

Just my opinion, but if someone wants to know stuff, they want to know stuff, they don't usually have the context to know what they want to know. As a result, usually a single file with sections is best - if the build system is complex enough to require lots of files, its probably too complex. Having a README (for people who want to use) vs a Dev document (for people who want to hack) might be a good idea.

@ndmitchell fair points. I might be overshooting with some of this. But would like to see how the one (rather short) README per folder plays out. It is in no case supposed to substitute a more in depth development documentation, but aid in superficially browsing the source. I consider myself quite a novice, and often am lost in developer documentation as I'm missing some prior knowledge. While I suspect someone more knowledgable would find a superficial overview either insulting, or not helpful.
I feel we have the user REAMDE.md already at the top level.  A proper developer documentation augmenting the haddocks will follow.  I'm trying to target somewhere in between the user README and the developer documentation for now. My target audience are those, who know a little about haskell, and would like to understand the big picture about how ghc is built and give enough guidance to be able to make some sense of the code that is used to produce the final product. I do not intend to make someone proficient in hacking this project. That's what the developer documentation will be for.
As others have mentioned already, heavy refactoring can invalidate the developer documentation pretty fast. I hope to achieve some high level overview, that would be immune to most of those refactoring, but still provide some high level insight.
Taking a text adventure as an example, I'd like to provide the setting. You can move around, and I'm able to tell you what the scene looks like. But you are deprived of any Look command that would allow you to focus on details; you'd have to install the developer extension for that.

And yes. Please! If I'm going overboard and too much into detail. Tell me, so we can move that into the developer docs.

@angerman That last bit with library descriptions (2f05d11) is actually very useful for me :) I have little knowledge of what most of the libraries/packages are for, and having all packages briefly described in one place would be great.

@snowleopard ha! It's not just me! :grinning: I'll keep grinding at this branch and will hopefully pick up some speed through this week.

This has been dead for almost two years now. Let's just nuke it.

@angerman Yes, it's got a bit outdated already, but there are still some useful bits. Let's keep your branch, maybe we'll recover some text from it someday!


#86 Add ATOMIC_MOVE to file move in XmlPrimary.close()

#86: Add ATOMIC_MOVE to file move option in XmlPrimary.close(), re-enabled RpmITCase on Windows.

@carlosmiranda/z this pull request is too small, just 9 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @g4s8/z please review this and merge or reject

Job gh:artipie/rpm-adapter#94 is not assigned, can't get performer


Add TextBlock::render_to_draw_batch

Does what it says on the tin.

Nice, thank you! I'll get that merged.


Some chunks doesnt get included in HTML

Bug report

What is the current behavior?
If the current behavior is a bug, please provide the steps to reproduce.
When using config like below:
optimization: {
  splitChunks: {
    chunks: 'all',
    name: false,
  },
}

Vendor chunk doesnt get included in the HTML.
For example, the generated file would look like below:
2.0eeefc2c.chunk.js -> This is the vendor chunks
3.e8d3cd1b.chunk.js
index.html
main.7171a389.chunk.css
main.a1bf2ab0.chunk.js
runtime-main.e6fd4d77.bundle.js

The generated html would like below:
<!doctype html>

    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width,initial-scale=1">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Webpack Boilerplate</title>
    <link href="main.7171a389.chunk.css" rel="stylesheet">

Webpack boilerplate

But, if I remove the name option like below:
optimization: {
  splitChunks: {
    chunks: 'all',
  },
}

Generated file would like below:
3.e8d3cd1b.chunk.js
index.html
main.7171a389.chunk.css
main.a1bf2ab0.chunk.js
runtime-main.e6fd4d77.bundle.js
vendors~main.0eeefc2c.chunk.js

And the HTML would like below and it's the vendors get included:
<!doctype html>

    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width,initial-scale=1">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Webpack Boilerplate</title>
    <link href="main.7171a389.chunk.css" rel="stylesheet">

Webpack boilerplate

What is the expected behavior?
The vendor chunks should get included just like when name options get enabled like the second example above.

Other relevant information:
webpack version:  4.41.5
Node.js version: 12.14.0
Operating System: windows 10 x64
Additional tools:

Please provide webpack configuration

Why do you use name: false? Do you read splitChunks documentation? I recommend use mode: "production" instead setup splitChunks. You should read how it works to understand how to configure https://webpack.js.org/plugins/split-chunks-plugin/

I still trying to figure it out how to setup webpak, and read in (this article)[https://medium.com/webpack/webpack-4-code-splitting-chunk-graph-and-the-splitchunks-optimization-be739a861366] that i should disabling the name option for production for better caching? Sorry if i'm misundestanding it.

Why do you touch splitChunks default webpack configuration? It is works for most of projects? What is use case?

My purpose only to learn how it works and understanding it, i still dont know the use case, because right now this is only playground to trial and error configuring webpack for me. Thank you for the answer, it is my bad not read the docs carefully.
Cheers! I will close this issue.
Once again thank you for fast response, and sorry for my bad english.

@finmavis If you don’t understand something, feel free to open the problem here https://github.com/webpack/webpack.js.org, we always want to improve our docs


read.csv garbles non-ascii (Japanese) characters

The content of the attached file is
"Language"
"English"
"日本語"
If I read the file using read.csv(), it returns
read.csv("test_cp932.txt")
Language
1  English
2   “ú{ê
Adding fileEncoding = "CP932" had no effect.
test_cp932.txt

Is it the data that is garbled, or is it the output in the REPL? If you use write.csv on the data, is the output correct?

This problem only occurred in the REPL. If I use write.csv to file, the output data was correct. But if I print the result to the  R interactive, the result was garbled like

write.csv(data)
"","Language"
"1","English"
"2","“ú{ê"

And I found this is not a problem of read.csv but a problem of showing data in data.frame because following code caused same problem.

data.frame(lang="日本語")
lang
1 “ú{ê

Thank you. So it seems that this is the same problem as in #1211?

I'm not sure, actually. When I print a element of data.frame, it works correctly.

df <- data.frame(lang = "日本語")
df[1, 1]
[1] 日本語
Levels: 日本語

but when I print entire data.frame, it garbles Japanese characters.

df
lang
1 “ú{ê

Following part of print.data.frame() seems to cause garbling.

m <- as.matrix(format.data.frame(x, digits = digits,
na.encode = FALSE))

but again, I'm not sure this is the same problem as in #1211.

I wonder if it escapes things in a different way, and we handle one correctly, but not the other...
Could you try these two things. and give me the output for each:
lapply(capture.output(df), utf8ToInt)

lapply(capture.output(df[1, 1]), utf8ToInt)

Your codes returned following.
lapply(capture.output(df), utf8ToInt)
[[1]]
[1]  32  32  32  32 108  97 110 103
[[2]]
[1] NA
lapply(capture.output(df[1, 1]), utf8ToInt)
[[1]]
[1] NA
[[2]]
[1] NA

Tentative estimate - needs investigation to root cause.

I'm trying to reproduce this on Win10 JPN (with locale etc). But I'm getting escaped characters instead:
> data.frame(lang = "日本語")
                      lang
1 <U+65E5><U+672C><U+8A9E>

Can you tell what Sys.getlocale() prints out for you?

It returned the following on my win10 Japanese.
> Sys.getlocale()
[1] "LC_COLLATE=Japanese_Japan.932;LC_CTYPE=Japanese_Japan.932;LC_MONETARY=Japanese_Japan.932;LC_NUMERIC=C;LC_TIME=Japanese_Japan.932"

Seems to be R locale issue (although we output different garbage string as compared to RS. None of the below encodings appear to work.
$ibm-866_P100-1995
[1] "ibm-866_P100-1995" "ibm-866"           "IBM866"
[4] "cp866"             "866"               "csIBM866"
[7] "windows-866"

RTVS matches RGUI output

RS provides a way to reopen file with proper encoding (VS does the same). However, Import data dialog needs to be fixed since we can't convert R encodings to .NET encodings. Will be fixing that so at least files can be imported properly via the dialog.

Note that this is not just about read.csv. It's about REPL output in general in some cases. E.g. in this case there's no data loading, but output is not right:
data.frame(lang = "日本語")

In fact, this is specifically not about read.csv per https://github.com/Microsoft/RTVS/issues/1340#issuecomment-201147745. Can you file a separate bug for Import Data issues?

To repro it on an arbitrary machine regardless of locale etc, just manually set R locale to something other than the default Latin-1:
Sys.setlocale('LC_CTYPE', 'Japanese_Japan.932')
data.frame(lang = "日本語")

So the problem is that when we're converting output to UTF-8, we're using VC's mbstowcs, which uses VC CRT locale - which is different from MinGW CRT locale. We need to be calling mbstowcs from msvcrt.dll.

Sure, https://github.com/Microsoft/RTVS/issues/1532

This one back to you then

https://github.com/Microsoft/R-Host/pull/55


[SPARK-47051][INFRA] Create a new test pipeline for yarn and connect

What changes were proposed in this pull request?
This PR aims to spin off yarn and connect as a new test pipeline for the following:

To stabilize more by off-loading
To re-trigger easily in case of failures.

Why are the changes needed?
These two modules are known to be flaky in various GitHub Action CI pipelines.

https://github.com/apache/spark/actions/runs/7905202256/job/21577289425 (YarnClusterSuite)
https://github.com/apache/spark/actions/runs/7905202256/job/21585092863 (SparkSessionE2ESuite)
https://github.com/apache/spark/actions/runs/7828944523/job/21359886644 (SparkSessionE2ESuite)
https://github.com/apache/spark/actions/runs/7795415730/job/21258341216 (SparkSessionE2ESuite)
https://github.com/apache/spark/actions/runs/7858754074/job/21444107806 (SparkSessionE2ESuite)
https://github.com/apache/spark/actions/runs/7879934827/job/21501133320 (SparkConnectServiceSuite)

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs in this PR.

Was this patch authored or co-authored using generative AI tooling?
No.

Could you review this test pipeline adjustment PR, @HyukjinKwon ?

Merged to master for now.


Added N_Queens.cpp

Implemented N_Queens Problem using c++

please assignee me I can do it with python

please assignee me I can do it with python

Sure, Can do.

assigne me so that I can work on it


TiKV rollback encounters panic "failed to load_latest_options"

Bug Report
Description
Rollback from version greater than v5.2.0 to version lower than [v5.0.4, v5.1.2], TiKV panics with message:
failed to load_latest_options \"Invalid argument: Unable to parse the specified CF option disable_write_stall\"

Root cause
https://github.com/tikv/rocksdb/pull/252 introduced a new RocksDB configuration item, lower versions that are unaware of this item can't parse options file.
Workaround
First rollback to version v5.0.4 or v5.1.2, then rollback to the desired version.
Related fix
https://github.com/tikv/tikv/pull/10842 makes v5.0.4 accept unrecognized items
https://github.com/tikv/tikv/pull/10843 makes v5.1.2 accept unrecognized items

/severity major

Closing this as we have an acceptable workaround.


Not working with new strawpoll system

I think they just not track the ip, but the device or whatever is that to!
*what i know is: to get double vote working, i need to change my proxy and delete all my history on chrome [browser], then the vote will work, otherwise it'll just wont got any + voter
\Hope You Figure This Out//
Thank You!

Yeaaaa...

Is that bug fixed ?

Hey @Luis-Hebendanz , seems it's not working anymore as said by @neoneo811 .
Are you going to update the script?

the bot said Successfully voted. but the vote result still not change.
note: i've change the main.py ".de" to ".com"

The new system uses IP and also browser cookie for checking duplicate vote. So the script has to be changed  so that it makes a request to the survey url first and then store the cookies and forward it to the "/vote" post request.
I made it work by doing these changes with changing .de to .com.
Hope this helps someone. :)

@codenameupik I think I could but as am a student attending school I dont know If I would get that amount of time. But will try

Try my fork. It should work. https://github.com/nithinswarrier/strawpoll-voting-bot/.
It should work on strawpoll.com. But the proxylist is bit outdated. Will automate later :)

@nithinswarrier . I really appreciate to your fork. But when I tried, sometimes It say successful vote but the poll not added. Why did it happened ?

@necromancer99999 The actual problem is not with the code itself but with the proxies. Some of the proxies in the proxylist has no support for cookies hence the request is send without cookies. So it shows successfully voted but because of no cookies in the request the system just classifies it as a no vote.
I got highest cookie supporting proxy from this site: https://gimmeproxy.com/ and getting one proxy and repeating it again and again.
If you get a good proxylist you would not get this problem. The proxy list I've provided doesnt have that much cookie supporting proxies.
If you can try use this proxylist: https://freeproxylist.org/en/free-proxy-list.htm. Make sure to make SSL support: yes, POST & GET Support: yes, and Max proxy ping: 5 seconds.
Hope you get what I mean

@necromancer99999 Check the fork now. It should improve adding votes. Tested only the repo proxylist. It works good after a 1000 proxies.

@nithinswarrier Wow, you are nice guy. The folk is good. Now i know the problem. Thanks for your support :)

@necromancer99999 it works, thank you so much!


##[warning]Can't find loc string for key: Info_GotAndMaskAuth

In the following build, https://dev.azure.com/monacotools/Monaco/_build/results?buildId=284240&view=results, there is a component governance alert saying that:
##[warning]Can't find loc string for key: Info_GotAndMaskAuth

I saw @connor4312 you last edited the code around that part, so assigning to you, let me know if I should assign to someone else

Closing this issue, incorrectly built


Improve BigQuery collector

start using the queryJob.{referenced_tables|ddl_target_table} methods (from bigquery itself) as main method to resolve what are the input and output BigQuery tables, which out-of-the box return enough of reliable query "introspection" for the basic use-cases (instead of clunky SQL parser).

however, this has limitation of max 50 input tables, so we use the old parser as a fallback in that case

added normalization of table names, so now we support both of:

`a1`.`b2`.`c3` # new
`a1.b2.c3` # existed earlier

in general, i think, the bigquery collector could be further cleanup/rewriten, to get re-structured a little more, possibly changing some internal data representations, e.g.:

bigquery function wrapper(s) without underlying logic
in/out table extractors

new [golden] in/out table extractor queryjob.{referenced_tables|ddl_target_table} - limit 50 tables
fallback extractor: Dumb SQL Tokenizer/Parser [& approx lineage extractor] - when more than 50 tables
maybe second fallback extractor based on queryplan (some strings retrieved from bigquery server)

lineage extractor(s)

remote API call to sql service
dumb all-to-all
[less likely] maybe some fallback based on queryplan strings

table + lineage => Kensu DS, schema, lineage

just this would be a much bigger separate PR


gstreamer-send "go get" requesting webrtc/v2

Environment: Ubuntu 20.04 server (x64)
Golang: 1.13.8 linux/amd64
What did you do?
Followed instructions to 'get' gstream-send repository
$ go get github.com/pion/example-webrtc-applications/gstreamer-send
Tried with GO111MODULE="", GO111MODULE=on, GO111MODULE="on"
What did you expect?
A verification mentioning that the repository and its dependencies was fetched successfully.
What happened?
cannot find package "github.com/pion/webrtc/v2" in any of:
        /usr/lib/go-1.13/src/github.com/pion/webrtc/v2 (from $GOROOT)
        /home/dpet/go/src/github.com/pion/webrtc/v2 (from $GOPATH)
package github.com/pion/webrtc/v2/pkg/media: cannot find package "github.com/pion/webrtc/v2/pkg/media" in any of:
        /usr/lib/go-1.13/src/github.com/pion/webrtc/v2/pkg/media (from $GOROOT)
        /home/dpet/go/src/github.com/pion/webrtc/v2/pkg/media (from $GOPATH)

The github.com/pion/webrtc/v2 folder does not exist. The Pion team has probably forgotten to update the dependencies of the examples.

Need to apply the following command before 'go get .,..'
$ export GO111MODULE=on


Support copying multiple article URLs

Implements #3681.

Copy Article URL and Copy External URL work a little differently from each other. If there are any selected articles with an Article URL, then the Copy Article URL is available. That isn't the case with Copy External URL.
I'm honestly not sure which is better. Should we allow users to copy what they can if not all URL's are available? That might lead to users thinking that there is a bug and we dropped a URL (even though it never existed). On the other hand, if a URL is missing in the selection and we don't offer the option at all, they might also think there is a bug.
Maybe we allow the copy if one or more of the URL's is missing and display an alert when they copy explaining that X number of selected articles didn't have a URL available?

I didn't think I changed Copy External URL. Did I leave something in there about that?

Oh I see what you're saying, I think. I feel like if an article has no URL it's likely common in the feed, though I could be wrong.

Smart Feeds and Folders can contain multiple Web Feeds which can differ on if they have URL's or not.

I think an alert should be fine if it includes the "don't tell me again" checkbox.

Let's do it like we do our warning for the Full Screen stuff on the Article view.
https://github.com/Ranchero-Software/NetNewsWire/blob/f930eca9bba2f66707fcfe0798ac8907f12f989b/iOS/Article/ArticleViewController.swift#L299

Smart Feeds and Folders can contain multiple Web Feeds which can differ on if they have URL's or not.

Good point.

As I mentioned in #work, let's fix how we open links in the Timeline context menu to work like it is supposed to.

Changing to a draft for now.

Did I click the wrong button regarding your question? It looks like my answer disappeared to me.
Basically, I said I like it the way it is. The alternatives weren't appealing. I agree about removing the invertPreference parameter from Browser and just checking for shift there.

@Wevah Is there anything left to do with this? We're trying get the 6.2 release into user testing this week and just wondered if we could get this in there as well.

Let me rebase and push and I'll change this PR to non-WIP.


add active defragmentation gauges for redis

What does this PR do?
The active defrag gauges are missing from the redis integration and will be useful for monitoring the effects on CPU usage and overhead while active defrag is running
Motivation
Investigating active defragmentation and would like to view the metrics supplied by redis in DataDog
Additional Notes
Adds a few standard redis metrics from the INFO call
Review checklist (to be filled by reviewers)

[x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[x] PR title must be written as a CHANGELOG entry (see why)
[x] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

@hithwen thanks for the review, I've updated the PR now.