Jenkins slaves connection fails randomly

Jenkins and plugins versions report

Environment

Jenkins: 2.327
OS: Linux - 5.4.0-1058-gcp
CustomHistory:1.6
ace-editor:1.1
ansicolor:1.0.1
ant:1.13
antisamy-markup-formatter:2.6
apache-httpcomponents-client-4-api:4.5.13-1.0
artifactory:3.14.2
authentication-tokens:1.4
authorize-project:1.4.0
aws-credentials:1.33
aws-java-sdk-ec2:1.12.131-302.vbef9650c6521
aws-java-sdk-minimal:1.12.131-302.vbef9650c6521
badge:1.9
bitbucket:214.v2fd4234d0554
bitbucket-push-and-pull-request:2.8.1
bootstrap4-api:4.6.0-3
bootstrap5-api:5.1.3-4
bouncycastle-api:2.25
branch-api:2.7.0
build-environment:1.7
build-monitor-plugin:1.13+build.202112271752
build-name-setter:2.2.0
build-pipeline-plugin:1.5.8
build-timeout:1.20
build-timestamp:1.0.3
build-user-vars-plugin:1.8
caffeine-api:2.9.2-29.v717aac953ff3
checks-api:1.7.2
chucknorris:1.4
cloudbees-folder:6.17
command-launcher:1.6
conditional-buildstep:1.4.1
config-file-provider:3.8.2
copyartifact:1.46.2
credentials:1055.v1346ba467ba1
credentials-binding:1.27
dashboard-view:2.18
display-url-api:2.3.5
docker-build-step:2.8
docker-commons:1.17
docker-java-api:<IP_ADDRESS>
docker-plugin:1.2.6
docker-workflow:1.26
durable-task:493.v195aefbb0ff2
echarts-api:5.2.2-2
email-ext:2.86
embeddable-build-status:2.0.3
extended-choice-parameter:0.82
extensible-choice-parameter:1.8.0
external-monitor-job:1.7
extra-columns:1.25
font-awesome-api:5.15.4-5
gcloud-sdk:0.0.3
generic-webhook-trigger:1.79
git:4.10.1
git-client:3.11.0
git-parameter:0.9.14
git-server:1.10
git-tag-message:1.7.1
github:1.34.1
github-api:1.301-378.v9807bd746da5
github-branch-source:2.11.4
google-compute-engine:4.3.8
google-container-registry-auth:0.3
google-kubernetes-engine:0.8.6
google-login:1.6
google-oauth-plugin:1.0.6
gradle:1.37.1
groovy-postbuild:2.5
handlebars:3.0.8
hidden-parameter:0.0.4
htmlpublisher:1.28
ivy:2.1
jackson2-api:2.13.1-244.v773c36c5b330
javadoc:1.6
jaxb:2.3.0
jdk-tool:1.5
jjwt-api:0.11.2-9.c8b45b8bb173
job-dsl:1.78.3
jobConfigHistory:2.31-rc1098.b666422863b2
jquery:1.12.4-1
jquery-detached:1.2.1
jquery-ui:1.0.2
jquery3-api:3.6.0-2
jsch:<IP_ADDRESS>
junit:1.53
kubernetes:1.31.1
kubernetes-client-api:5.10.1-171.vaa0774fb8c20
kubernetes-credentials:0.9.0
ldap:2.7
lockable-resources:2.13
mailer:1.34
matrix-auth:3.0
matrix-project:1.19
maven-plugin:3.16
mercurial:2.16
metrics:<IP_ADDRESS>
momentjs:1.1.1
nodejs:1.4.3
oauth-credentials:0.5
okhttp-api:4.9.3-105.vb96869f8ac3a
pam-auth:1.6.1
parameter-separator:1.3
parameterized-trigger:2.43
periodicbackup:1.7
pipeline-build-step:2.15
pipeline-github-lib:1.0
pipeline-graph-analysis:188.v3a01e7973f2c
pipeline-input-step:427.va6441fa17010
pipeline-milestone-step:1.3.2
pipeline-model-api:1.9.3
pipeline-model-declarative-agent:1.1.1
pipeline-model-definition:1.9.3
pipeline-model-extensions:1.9.3
pipeline-rest-api:2.20
pipeline-stage-step:291.vf0a8a7aeeb50
pipeline-stage-tags-metadata:1.9.3
pipeline-stage-view:2.20
pipeline-utility-steps:2.11.0
plain-credentials:1.7
plugin-util-api:2.10.0
popper-api:1.16.1-2
popper2-api:2.11.0-1
publish-over:0.22
publish-over-ssh:1.22
purge-job-history:1.6
pwauth:0.4
readonly-parameters:1.0.0
rebuild:1.32
resource-disposer:0.17
role-strategy:3.2.0
run-condition:1.5
saml:2.0.9
scm-api:2.6.5
script-security:1118.vba21ca2e3286
slack:2.49
snakeyaml-api:1.29.1
ssh:2.6.1
ssh-agent:1.23
ssh-credentials:1.19
ssh-slaves:1.33.0
sshd:3.1.0
stashNotifier:1.24
structs:308.v852b473a2b8c
summary_report:1.15
throttle-concurrents:2.6
timestamper:1.15
token-macro:267.vcdaea6462991
trilead-api:1.0.13
uno-choice:2.5.7
variant:1.4
view-job-filters:2.3
windows-slaves:1.8
workflow-aggregator:2.6
workflow-api:1108.v57edf648f5d4
workflow-basic-steps:2.24
workflow-cps:2648.va9433432b33c
workflow-cps-global-lib:552.vd9cc05b8a2e1
workflow-durable-task-step:1112.vda00e6febcc1
workflow-job:1145.v7f2433caa07f
workflow-multibranch:696.v52535c46f4c9
workflow-scm-step:2.13
workflow-step-api:615.vb09dac339255
workflow-support:804.vba10a18a1476
ws-cleanup:0.40

What Operating System are you using (both controller, and any agents involved in the problem)?
Jenkins randomly deletes slaves before completing job runs.
We could not establish any sort of pattern for when it happens, it is not time dependent as far as I can tell.
We get the following errors:
Caused: java.io.IOException: Unexpected termination of the channel
Caused: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@60d32f79:jenkins-jgqlcq": Remote call on jenkins-jgqlcq failed. The channel is closing down or has closed down
I can see in GCP Log Explorer that Jenkins sends a v1.compute.instances.delete to the node when this happens, however, I cannot find any definition for it.
I set a retention time to 500 just to see that it is not the issue, launch timeout is 300.
Reproduction steps

GCP is spinning up a slave instance to run
randomly it will get (or not) a v1.compute.instances.delete from Jenkins.

Expected Results
All slaves should finish their runs without disconnecting
Actual Results
Slaves randomly disconnect without any visible pattern
Anything else?
No response

I recently had this same issue come up and am just starting investigating.  It coincided with starting to use Jenkins' configuration as code plugin; I'm just curious if you're using that too.

I'll just comment here in case it helps someone in the future... it did indeed seem related to using Jenkins' Configuration As Code.  I had exported the configuration and edited it then duplicated it for something else, not noticing that it kept instanceId for the cloud configuration, so that two different cloud configurations were using the same instanceId.  Note that the example yaml does not include the instanceId... once I removed it, the random shutdowns stopped.


Multi-part form upload returns empty data using DataReader

Can someone give an example of how to handle POST requests where we are uploading files/photos (multipart/form-data).
I tried to use DataReader(input) snippet but that always gives me an empty data back. Does environ need to have another key set ? Looking at python's uwsgi definitions, they advise to use cgi.FieldStorage.
d = cgi.FieldStorage(environ=environ, fp=environ['wsgi.input'], keep_blank_values=True)
Could you provide an example of how do we handle this case ?
DataReader.read(input) {     d  in      print(d) }
In this case, when using
 curl -v  -X POST -F<EMAIL_ADDRESS>http://localhost:8080/image , the d variable declared above is nil.

Hey @pranavs18, can you give me a workable code example that allows me to reproduce the problem you describe here? It would be helpful for me to figure what's going on there for you :)

     router["/image"] = JSONResponse(handler: {environ -> Any in

         let input = environ["swsgi.input"] as! SWSGIInput
         DataReader.read(input) { data in
             // get the image bytes from the request object
             funcABC(data)
             startResponse("200 OK", [])
             sendBody(Data("".utf8))
             sendBody(Data())
         }
         return ["Image processed":"1"]
         }

I am trying to use curl -v -X POST -F<EMAIL_ADDRESS>http://localhost:8080/image . This would do the multi-part form-data image upload. On the server side, I would need to extract the file field from the http request body object to get the bytes. How can I do this using embassy?
If I were to do this in swift in another http framework, I can perhaps do this like:
let content = request.formData?["file"]?.part.body
// get bytes

let d = Data(bytes: content)

@pranavs18 JSONResponse will respond immediately after you return via return ["Image processed":"1"]. Then it will close the HTTP connection. DataReader.read(input) is an async operation, which means it will wait until new HTTP body data arrive. So when JSONResponse handler returns, DataReader.read won't get a chance to really read the data.
As if you want to read the complete HTTP body payload, you will need to wait until DataReader.read called the callback then send the response to peer. For JSONResponse, there's another async constructor you can use
https://github.com/envoy/Ambassador/blob/7992f4a2379066a8590496650ef595d4a5442a59/Ambassador/Responses/JSONResponse.swift#L24
Like this, you can modify your code with the sendJSON for finishing up the response
     router["/image"] = JSONResponse(handler: { (environ, sendJSON) -> Any in

         let input = environ["swsgi.input"] as! SWSGIInput
         DataReader.read(input) { data in
             // get the image bytes from the request object
             funcABC(data)
             sendJSON(["Image processed":"1"])
         }
     }

It works if I change Any to void and I do get the bytes of the image uploaded. But I wonder how do I extract the image content from there ?
This snippet compiles but the data passed in funcABC() expects an image but fails to find that. When I print data, it gives me the total bytes. How would I extract the file content from there ?
           router["/image"] = JSONResponse(handler: { (environ, sendJSON) -> Void in
           let input = environ["swsgi.input"] as! SWSGIInput

           DataReader.read(input) { data in
               funcABC(data)
               sendJSON(["Image processed":"1"])
           }
       })

I actually figured out the problem.
When I used curl with --data-binary @temp.jpg , that worked like a charm. All the bytes were correctly received and processed.
When I used curl with -F<EMAIL_ADDRESS>that fails. And it is probably because, the extra string file= and the multipart form-data boundary bytes need to be extracted away I believe from the total bytes uploaded. In this case, the total bytes uploaded are much more than in the case of --data-binary.

@fangpenlin Are there any plans or a workaround for supporting multi-part form-data?

Is the ambassador authorizer now allowing multipart form data parameters to be passed through?


DBZ-8514 TimezoneConverter include.list should be respected if set

Fix for what I would consider to be a bug in TimezoneConverter include.list.
If you specify entries e.g.
transforms.convertTimezone.include.list=source:table_one:DATE_CREATED,table_one:LAST_UPDATED,table_two:CREATED_AT,table_two:UPDATED_AT

and an event from table_three is received, the TimezoneConverter will currently apply the conversion to all columns within. The fallback from not finding a table match in config is to convert all columns, instead of not converting any of them.
This leaves you with no way to opt in to select columns on select tables without adding workaround config e.g. table_three:workaround_cfg.
See https://issues.redhat.com/browse/DBZ-8514

See https://github.com/debezium/debezium/pull/6051 for PR for 2.7.x line.

@martin-walsh Applied, thanks!


Can not train a BERT fine tuning model using TF on TPU

I am training a tensorflow model defined as follows on a TPU. But when it starts training, I run into this error:
UnimplementedError: {{function_node __inference_distributed_function_299068}} Compilation failure: Dynamic concatenation is not supported yet: %reshape.3993 = s32[832]{0} reshape(s32[2,416]{1,0} %reshape.621), metadata={op_type="Reshape" op_name="Reshape_1636"}
TPU compilation failed
[[{{node tpu_compile_succeeded_assert/_14468581000393706631/_10}}]].
I searched on google but did not find any clue to solve this. Any ideas?
def create_model(pretrained_path):
q_id = tf.keras.layers.Input((MAX_SEQUENCE_LENGTH,), dtype=tf.int32)
a_id = tf.keras.layers.Input((MAX_SEQUENCE_LENGTH,), dtype=tf.int32)
q_mask = tf.keras.layers.Input((MAX_SEQUENCE_LENGTH,), dtype=tf.int32)
a_mask = tf.keras.layers.Input((MAX_SEQUENCE_LENGTH,), dtype=tf.int32)

q_atn = tf.keras.layers.Input((MAX_SEQUENCE_LENGTH,), dtype=tf.int32)
a_atn = tf.keras.layers.Input((MAX_SEQUENCE_LENGTH,), dtype=tf.int32)
config = BertConfig()

config.output_hidden_states = False
bert_model = TFBertModel.from_pretrained(pretrained_path, config=config)
q_embedding = bert_model(q_id, attention_mask=q_mask, token_type_ids=q_atn)[0]
a_embedding = bert_model(a_id, attention_mask=a_mask, token_type_ids=a_atn)[0]
q = tf.keras.layers.GlobalAveragePooling1D()(q_embedding)
a = tf.keras.layers.GlobalAveragePooling1D()(a_embedding)

x =  tf.keras.layers.Concatenate()([q, a])

x = tf.keras.layers.Dropout(0.2)(x)

x = tf.keras.layers.Dense(30, activation='sigmoid')(x)

model = tf.keras.models.Model(inputs=[q_id, q_mask, q_atn, a_id, a_mask, a_atn, ], outputs=x)
return model

@nariman9119 , Can you provide the complete code to replicate the reported issue. Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!

In case anyone comes across this ticket, and frustrated that there was no answer before it was closed, I ran into the exact same issue. For me, my issue was my TF Dataset pipeline causing this issue downstream.
it was caused by TPUs lack of support for dynamic batch sizes. In TF2, this can be resolved by adding drop_remainder=True to your dataset pipeline's batch operation:
dataset.batch(..., drop_remainder=True)
Hope this helps!!

@mikeortman Yup that worked. Thank you, stranger.


remove comments in injectedjs to support android emulator

somehow having comments in injectedjs will cause injection failure in saucelabs android emulator.

👍


Document Antiforgery middleware in .NET 8

Antiforgery middleware
Antiforgery integration for minimal APIs

Associated WorkItem - 145866

Closing as duplicate


Update html-elements-webpack-plugin.js

By adding callback type check it will eliminate error for webpack 4

html-elements-webpack-plugin.js:24
[webpack4]/[html-elements-webpack-plugin]/lib/html-elements-webpack-plugin.js:24:21

@reyramos thanks for this awesome contribution, and also the timing was perfect 😄


Consider using different monospace font for demos

Hey there & thanks for creating egui! I've played around with it quite a bit now and came to love it already.
Recently, I created a small split view application for a toy programming language: half of the screen an editor, the other half an AST view & built it as a wasm application.   I'm aware of the font-rendering issues in pre-0.14 versions on web, but when asked, people explicitly pointed out that it was the monospace stuff in particular that they disliked. I also remember that this was my first thought when first looking at the markdown editor in the egui demo app.

While I realize that this is probably a bit controversial and against your personal preferences, I'd suggest changing the default font to a more "standard" looking monospace font.

I think this is a good idea - let's collect some suggestions!
The font must have a liberal license (e.g. Open Font License), and the font file should be small (a few hundred kB max).
Nominate some suggestions, ideally with a screenshot, a link and a summary of the license and file size, and then we can pick one!

That's good to hear!vMy personal favorites are these two:
JetBrains Mono
License: SIL Open Font License 1.1
File size: 144 KiB (JetBrainsMonoNL-Regular.ttf, NL = no ligatures)
Website: https://www.jetbrains.com/lp/mono/

Fira Code
License: SIL Open Font License 1.1
File size: 299 KiB (FiraCode-Regular.ttf)
Website: https://github.com/tonsky/FiraCode

Note that this one doesn't have a no-ligatures version, so we're probably wasting a bit of space here (unless you intend to support ligatures). I haven't done that before, but we can prooobably somehow remove these unused characters ourselves (if the license permits it, we'd have to check).
As a general note, I noticed that these fonts compress rather well, e.g. JB Mono goes down to half the size when compressed with LZ4, which is lightning-fast and can have a decoder implemented in <100 lines of Rust. I wonder if creating a proc-macro for compressing these resources & decompressing them at runtime might be worth considering.

As a general note, I noticed that these fonts compress rather well, e.g. JB Mono goes down to half the size when compressed with LZ4, which is lightning-fast and can have a decoder implemented in <100 lines of Rust. I wonder if creating a proc-macro for compressing these resources & decompressing them at runtime might be worth considering.

I'm not sure it's worth it - space is mostly an issue for web, but the .wasm file will already be compressed by the server:
❯ curl https://emilk.github.io/egui/egui_demo_app_bg.wasm --silent --write-out "%{size_download}\n" --output /dev/null
3654628

❯ curl https://emilk.github.io/egui/egui_demo_app_bg.wasm --silent -H "Accept-Encoding: gzip,deflate" --write-out "%{size_download}\n" --output /dev/null
1556882

Compressing the font data will make the first number smaller, but likely not the second one.

Yeah good point, I didn't think of transport compression!

Looks very decent as well! Reminds me of Microsoft's Consolas.


deprecate RawNode.TickQuiesced()

TickQuiesced() was originally added for use with range quiescence in CockroachDB, but hasn't been in use since 2018. This patch marks it as depracated, to be removed in a future release.
See https://github.com/cockroachdb/cockroach/pull/24956.

cc @tbg @pavelkalinnikov

@erikgrinaker Please add a Signed-off-by footer: git commit --amend --signoff.
@tbg Please approve/merge, as I can't.

@erikgrinaker thanks, and please take care of the DCO.

This technically breaks drop-in backwards compatibility. I still think we should remove this, as it's quite crufty. I used Github code search and there are 200+ hits, but as far as I can tell they're all in

old forks of cockroach repos
forks of etcd/raft
some possibly machine-written versions of etcd/raft in, for example, D and Rust (exact matching comments).

Would appreciate some advice from the other maintainers. Personally, I think the benefit of removing this far outweigh the risks (in fact, I'd be concerned about someone using this).
cc @ahrtr @spzala

This technically breaks drop-in backwards compatibility. I still think we should remove this, as it's quite crufty. I used Github code search and there are 200+ hits, but as far as I can tell they're all in
* old forks of cockroach repos

* forks of etcd/raft

* some possibly machine-written versions of etcd/raft in, for example, D and Rust (exact matching comments).

Would appreciate some advice from the other maintainers. Personally, I think the benefit of removing this far outweigh the risks (in fact, I'd be concerned about someone using this).
cc @ahrtr @spzala

Thanks for the investigation @tbg I think we should at least mention this in the Changelog. This repo is still new so seems like we don't have the Changelog file created but it's time to do so now :) cc @ahrtr

If we decide to remove a public API, we need to add a breaking change notice at least. Creating a changelog (thx @spzala for the reminder) is a good idea.
I am also thinking to create a milestone as a goal to release next raft version, e.g. 3.6.0. Detailed proposals:

Add a milestone v3.6.0 now, and consider to formally release raft v3.6.0 when all of us feel comfortable (I imagine sometime in the following couple of months). We can mark any new non-trivial PRs included in the milestone, so that we can summarize the changelog when right before we plan to release v3.6.0.
Also add label backport/v3.5 and backport/3.4, and consider to backport any bug fix, which were added after separating the raft repo, to etcd/raft's release-3.5 and release-3.4 if needed.

Thanks for the code search @tbg! I'd be surprised and concerned if someone was using this.
I don't know what our guarantees are around backwards compatibility, but it makes sense to leave this for either 3.6 or 4.0. This is not a priority at all, just an opportunistic cleanup. A milestone and changelog sounds good, let me know if we can help set that up.

please take care of the DCO

✅

Usually a best practice is to deprecate a public API firstly (e.g in 3.6) to discourage users from using it, and then remove it in a major release (e.g. 4.0). So two options:

Change this PR to deprecate the API instead of removing it. And add a comment mentioning we are planning to remove it in 4.0. (Personally preferred)
Remove it directly.

Sure, updated the PR to deprecate it and opened #66 to track the removal in the next major release.

Maybe we should add a 4.0 milestone too, to track #66?

TFTRs! Maybe we should add a 4.0 milestone too, and track #66 in it?

Done.


Error: The symbol "provider" has already been declared

Describe the bug
There is an Error in the latest version.
20:34:26 [vite] Internal server error: Transform failed with 2 errors:
F:/AI/AI_Dev/bolt.new-any-llm/app/components/chat/BaseChat.tsx:116:10: ERROR: The symbol "provider" has already been declared
F:/AI/AI_Dev/bolt.new-any-llm/app/components/chat/BaseChat.tsx:116:10: ERROR: The symbol "setProvider" has already been declared
Plugin: vite:esbuild
File: F:/AI/AI_Dev/bolt.new-any-llm/app/components/chat/BaseChat.tsx:116:10
The symbol "provider" has already been declared
114|    ) => {
115|      const TEXTAREA_MAX_HEIGHT = chatStarted ? 400 : 200;
116|      const [provider, setProvider] = useState(DEFAULT_PROVIDER);
|            ^
117|      const [apiKeys, setApiKeys] = useState<Record<string, string>>({});
118|
The symbol "setProvider" has already been declared
114|    ) => {
115|      const TEXTAREA_MAX_HEIGHT = chatStarted ? 400 : 200;
116|      const [provider, setProvider] = useState(DEFAULT_PROVIDER);
|            ^
117|      const [apiKeys, setApiKeys] = useState<Record<string, string>>({});
118|
Link to the Bolt URL that caused the error
http://localhost:5173/
Steps to reproduce
Maybe caused by this commit:
SHA-1: 936a9c0f69db47b35165cf6a807fd5771f82ea8c

Merge pull request #188 from TommyHolmberg/respect-provider-choice

fix: respect provider choice from UI
Expected behavior
shouldn't display this error.
Screen Recording / Screenshot

Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context
No response

Can you ensure you're on latest main branch and try this again? There are only two references to instantiating provider/setProvider via useState on line 28.

Can you ensure you're on latest main branch and try this again? There is currently just one reference to instantiating provider/setProvider via useState on line 28 of BaseChat.

Thank you very much. After pulling the latest branch, the problem is resolved!


feat: Subscription size backend integration

Details

Integrated Subscription Size parts with backend. Data now comes from API and proper API calls are performed when executed
Fixed Issues

$ https://github.com/Expensify/App/issues/38631
Tests

To access this newly created component, paste the following link into the browser
https://dev.new.expensify.com:8082/settings/subscription
or add this effect to InitialSettingsPage.tsx
useEffect(() => {
    Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION)
}, [])

Try to change subscription size to lower/higher number
[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

useEffect(() => {
    Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION)
}, [])

Try to change subscription size to lower/higher number
[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos
https://github.com/MrMuzyk/App/assets/23487612/7805c596-236e-48eb-a253-0be9af44bea8

Reviewing this now. @MrMuzyk can you resolve the conflicts?

Overall looks great, just one question on the optimistic error handling.

@MrMuzyk I can see a couple small issues:

After updating the subscription size,  when we redirect to settings/subscription the query string canChangeSize=1 isn't removed from the URL.
If I open https://dev.new.expensify.com:8082/settings/subscription/subscription-size?canChangeSize=0, and then manually change value of canChangeSize, 0 to 1 the text input is blank. Ideally it shouldn't be blank right?
Clicking on X (close) for the RBR doesn't do anything.
Setting the same value as the existing userCount, still shows an error message that we can't downgrade the plan.
Going offline to online, shows several API failures with 404 error.

https://github.com/Expensify/App/assets/3069065/8f25602c-4a36-4db0-9f97-6481fa247335
https://github.com/Expensify/App/assets/3069065/cb048848-9e92-440b-be02-08a0110333a4
https://github.com/Expensify/App/assets/3069065/b0cc9e90-fb2c-4e97-b11d-4876b93eb04a

Also can you correct the typo:

Integrated Subscription Size parts with backend. Data now comes from API and proper API calls are performed when exectued

Integrated Subscription Size parts with backend. Data now comes from API and proper API calls are performed when executed

@mananjadhav
Rebased and fixed conflicts, added error clear on success and fixed the typo.

Is it a problem? I doesn't affect page behaviour in any way. Everything works correctly and if you navigate to some other route that isn't related to subscription it disappears.
I wasn't able to reproduce that behaviour. Did you do anything special in order to achieve that?

https://github.com/Expensify/App/assets/23487612/af60abd8-6468-48e5-b6c3-f26c5edb91dd

Did you mean clicking X on error message? Added handler for that
Asked for guidelines on this as Im not sure how it should behave
I couldn't reproduce that as well

https://github.com/Expensify/App/assets/23487612/75858581-3d0f-4478-9a97-846037b37e4e

@mananjadhav

We're now displaying special error message in case user tries to proceed without changing current subscription size

There is one issue that became visible after merging with main but is unrelated to my changes. When navigating between the screens content shifts - Im trying to find a cause but the fix might come in next PR
https://github.com/Expensify/App/assets/23487612/ecbbb0c4-9f0e-428f-bd51-c9fc6910b8c9

Found the cause - had to exclude subscription ROOT screen from FocusTrap. Everything should behave correctly now

@MrMuzyk @amyevans We're showing all the errors in red as an input error.

But when we enter the subscription size count lesser than the current value we show the error in the RHS as a separate screen. Does make sense to add this also as red error message?

Also let's add a FE validation to only allow integers? Although API doesn't accept decimals (2.05, etc.) but FE allows it.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/3069065/fa035c14-707b-4c6f-a0de-666bc7fa110a

Android: mWeb Chrome
https://github.com/Expensify/App/assets/3069065/4cff907b-510b-4ad1-8256-ba6fd5d985e2

iOS: Native
https://github.com/Expensify/App/assets/3069065/0ef693df-b3b8-4efc-8a88-adc7c4f8ea8b

iOS: mWeb Safari
https://github.com/Expensify/App/assets/3069065/2944d06b-b8d6-4005-b678-69c43adafaed

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3069065/cffdc05f-874a-4edc-ac89-6475cd355633

MacOS: Desktop
https://github.com/Expensify/App/assets/3069065/b106f0f4-903a-4c4e-b158-ed6111915c1e

Just final edge cases. @amyevans Can you review in parallel?

@MrMuzyk @amyevans We're showing all the errors in red as an input error.

But when we enter the subscription size count lesser than the current value we show the error in the RHS as a separate screen. Does make sense to add this also as red error message?

Hmm let's get @dannymcclain's input on this one

No I don't think we want to use red on that second screen. We use red for validation errors and violations to call your attention to the message, but the text on that screen is isolated and just explaining why you can't do that action. It's informational and there's nothing else competing for it's attention, so we should just leave it as normal text.
We do need to add a period at the end of the first sentence though 🙃

Well I think the suggestion was to totally remove the second screen and move all this text to be an inline error. But that makes sense that we'd treat it differently than a true "error" and leave it as currently implemented 👍
@MrMuzyk can you add the period to the end of the sentence please?

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/amyevans in version: 1.4.84-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.84-3 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


scripts: add reparo grafana template file

@LinuxGit  PTAL

@holys what is "reparo"?

Reparo is an incremental recovery tool used to restore data generated by drainer(in protobuf format). You can learn more from  https://github.com/pingcap/tidb-binlog/tree/master/reparo.


WebAssembly Last Part

This is it!
After this commit we will work directly in master for all WebAssembly work.
@Krovatkin @commonlisp @arunetm @MikeHolman

This change is

:shipit:


duplicate symbol error when linking contracts consisting of multiple .cpp files

The EOSIO.CDT eosiolib header files include implementations of certain functions, such as eosio::send_deferred, in the header files. When trying to link a contract consisting of multiple cpp files that each include those problematic header files (such as transaction.hpp), the linker gives a duplicate symbol error.

Fixed in https://github.com/EOSIO/eosio.cdt/pull/479


Relax GENERATE_XML validation

GENERATE_XML = YES

is useful when Doxysphinx and Breathe are used together.
Breathe is still useful to include doxygenclass, doxygenfunction etc. inline into rST files (not the complete doxygen generation)
Shall we relax the validation on this attribute?

Yes we remove it - it was only there in the first place to prevent users doing both because of the increased doxygen generation times.

My apologies!
We removed the validation on GENERATE_XML in f584b912b67caf59baa6d5c5ca8621664d58fb49. It's active since release 2.3.7.


Feature/menu nav

A nav widget that will display a configured tree

This pull request has been replaced by #16


Convert PDF to DOC, PPT, XLS, JPG, HTML.

I have used tonchik-tm/pdf-to-html:~1. to convert PDF into html. But I am getting the following Error... Please let me know where is the issue...

Can anyone help me?

I'm having the same issue.

I had same issue bc of a bad install of plopper


Removing unmapped contigs

Fixes error creating IGV reports
Removed entries in BED with contigs which don't map to chromosome.
i.e. NT_ ow NW_ prefixed contigs see: https://hgvs-nomenclature.org/stable/background/refseq/.

This change is

Hello @RSWilson1! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file gene_annotation2bed.py:

Line 852:80: E501 line too long (95 > 79 characters)
Line 856:80: E501 line too long (88 > 79 characters)


carthage supprt

fixed demo – navigation's image view should be aspect fit
fixed scale not using screen's scale at thumbnail
added carthage support

hey @tilltue, great library!

@terenzeyuen
I can't find example in workspace.

@tilltue oh, it should be in there like this.

@tilltue you really cant see the example project?

No i can't see that.

Ah try Manage Schema and check the example project? @tilltue


⚠ Bofrost.de has degraded performance

In 64da8d5, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1342 ms

Resolved: Bofrost.de performance has improved in b54dc76.


Allow devise patch version updates

The most current 'devise' version is 3.5.2 but this gem specifies the exact version 3.5.1 which is too specific in my opinion. I can understand that there is the will to test things before upgrading but as this is a security aware and enhancing gem I feel it really should allow security patches and bug fixes to devise be immediately available.
I suggest using the "~> 3.5.1" specification style as this would allow others use 3.5.2 but not 3.6 until it is tested to work with 3.6+ versions.

@Dschee - i agree with you, but explicitly pinned to 3.5.1 because 3.5.2 introduced changes that broke the BCrypt routines in devise_token_auth. As in, it completely broke the gem. These aren't caught in tests currently, either. I have been swamped and unable to dive into it further, but if you can get it working in 3.5.2 with verification tests, I can approve the pull.

I'll have some time this weekend, I'll look into this ASAP.

thanks @lynndylanhurley !

@booleanbetrayal - I'm not seeing any errors with devise 3.5.2. Do you remember what the issue was specifically?

@lynndylanhurley - Yeah, i'm no longer seeing this either. Wondering if it wasn't a fuzzy dependency issue pulling a temporarily broken BCrypt or something. Updated in bf2cc1b69a1456e53b40de87ec98245102d235a8

@booleanbetrayal: Thank you for approving my pull request! :)
Never mind, I'll just close it.


device_class makes the device unavailable in HA

My config:
sonoff:
  username<EMAIL_ADDRESS>  password: xxxxxxxx
  mode: local
  reload: always
  devices:
    10xxxxxx24: #Sonoff Basic R2
      name: Movable outlet
    10xxxxxx78: #Sonoff Mini
      name: Lamps in the Lobby
      device_class: light
    10xxxxxx4a: #Sonoff Basic R2
      name: Spotlight in the yard
      device_class: light
    10xxxxxx49: #Sonoff TH16
      name: Outlet in the Garage

If I specify "device_class" for a device, then this device will become unavailable in Home Assistant.
If I delete the "device_class", the device becomes available again.
What am I doing wrong?

Because device_class changes entity ID. Your entity ID with old device_class become unavailable. You can delete them


Image sequence

I know that this can render single images as PNG files. Can you add the functionality to sequentially name and output image sequences?

@JapanYoshi randomly saw your question
you can try my fork of this script https://github.com/danilw/shadertoy-to-video-with-FBO
my modifications allow rendering to MOV video(frames without compression) and then you can convert MOV video frames to images


Feature/sort

Description
User can choose/sort products by choosing category and grouping items.
User can choose/sort products by choosing tag and grouping items.
User can reset sort.
Type of change

[x] New feature (non-breaking change which adds functionality)

Change Status

[x] Complete, tested, ready to review and merge

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] There are no merge conflicts

 Feature: sort


question about German dataset

Can you provide me the german-feature-metadata.p files? Thanks!

I have also been unsuccessfully trying to find the file, but it appears that it can be quite easily replaced by defining the feature metadata in the same way as in faithfulness_demo.py. In particular, using the following code to initialise input_dict['feature_metadata'] seems to be working for the German Credit dataset:
feature_metadata = dict()
feature_metadata['feature_n_cols'] = [1, 1, 1, 1, 1, 1, 1, 1, 4, 5, 10, 5, 5, 4, 3, 4, 3, 3, 4, 2]
feature_metadata['feature_types'] = ['c'] * 8 + ['d'] * 12
(...)
input_dict['feature_metadata'] = feature_metadata


list-extra is too restricted in elm-package.json

Using elm-ethereum with other packages that needed list-extra, conduct to dependencies problem
Solving dependencies...
  ▶ No solution found: Unable to satisfy the following requirements:

- `elm-community/list-extra (< 8.0.0)` required by `user-specified dependency`
- `elm-community/list-extra (>= 7.0.0)` required by `user-specified dependency`
- `elm-community/list-extra (>= 6.1.0)` required by `cmditch/elm-ethereum-1.0.2`
- `elm-community/list-extra (< 7.0.0)` required by `cmditch/elm-ethereum-1.0.2`
- `elm-community/list-extra (>= 6.1.0)` required by `prozacchiwawa/elm-keccak-1.0.1`
- `elm-community/list-extra (< 7.0.0)` required by `prozacchiwawa/elm-keccak-1.0.1`
- `elm-community/list-extra (>= 6.1.0)` required by `hickscorp/elm-bigint-1.0.2`
- `elm-community/list-extra (< 8.0.0)` required by `hickscorp/elm-bigint-1.0.2`
- `elm-community/list-extra (>= 7.0.1)` required by `dillonkearns/graphqelm-7.1.0`
- `elm-community/list-extra (< 8.0.0)` required by `dillonkearns/graphqelm-7.1.0`
`
```
Update to "elm-community/list-extra": "6.1.0 <= v < 8.0.0"

Can you describe how to replicate this error?
I started a fresh repo and was unable to get the error above.
Thanks!

@cmditch elm install dillonkearns/graphqelm in your fresh repo, as it requires list-extra >= 7.0.1, it should mismatch with your default that requires < 7.0.0

Merged PR. Looks like the support for 0.18 patches on the elm package manager is quirky :-\
I replicated the dependency error message from adding graphqelm as you suggested. Still getting the error despite publishing the patch.
$ elm-package publish
Verifying cmditch/elm-ethereum 1.0.3 ...
Version number 1.0.3 verified (PATCH change, 1.0.2 => 1.0.3)
Success!

$ elm-package publish
Verifying cmditch/elm-ethereum 1.0.3 ...
Error: Version 1.0.3 has already been published. You cannot publish it again!
Run the following command to see what the new version should be:

    elm-package bump


Adjust music tempo based on score rather than roidCount

Context
Currently, the way the music tempo is calculated doesn't really make sense as the player no longer destroys all the asteroids to go to the next level.
Ideal behavior
Each new level should slightly increase the music tempo

Fixed in https://github.com/jsolly/GeoAsteroids/commit/5d8743241cbac54ab28a17575274e4a3153bb68f
The tempo maxes out at level 15 for now. I can adjust this later as needed.
Each level increases the tempo


Inconsistent city data

Describe the bug
Seeing inconsistent city data from https://saytheirnames.dev/api/people
{
	"id": 61,
	"full_name": "Rayshard Brooks",
	"identifier": "rayshard-brooks",
	"date_of_incident": "2020-06-12",
	"number_of_children": 4,
	"age": 27,
	"city": "Atlanta - GA",
...
}, {
	"id": 25,
	"full_name": "Robert Fuller",
	"identifier": "robert-fuller",
	"date_of_incident": "2020-06-10",
	"number_of_children": null,
	"age": 24,
	"city": "Palmdale-CA",

To Reproduce
Steps to reproduce the behavior:

Go to https://saytheirnames.dev/api/people

Expected behavior
Should Palmdale-CA be Palmdale - CA or should the - [state] be removed?

Thank you for this, will pass on to DATA team


tests may require external server

please fix pytests. Right now I can't just run pytest because they are relying on something eternal, which is not documented.
The rules of testing should be:

ideally, the default unit tests should rely on no external services or setup. A user should be able to type pytest and get a meaningful test.
if an external service is really critical, for testing, then optional additional tests may require it, but how to set it up should be a one-line command and should be included in the README

This is the error I get:
>       conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
E       sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) connection to server at "<IP_ADDRESS>", port 5432 failed: Connection refused
E       	Is the server running on that host and accepting TCP/IP connections?
E
E       (Background on this error at: https://sqlalche.me/e/14/e3q8)

../../.local/lib/python3.8/site-packages/psycopg2/__init__.py:122: OperationalError
=========================== short test summary info ============================
FAILED tests/test_bbconf.py::TestAll::test_invalid_config - sqlalchemy.exc.Op...
FAILED tests/test_bbconf.py::TestAll::test_tables_creation - sqlalchemy.exc.O...
FAILED tests/test_bbconf.py::TestAll::test_data_insert - sqlalchemy.exc.Opera...
FAILED tests/test_bbconf.py::TestAll::test_nonunique_digest_insert_error - sq...
FAILED tests/test_bbconf.py::TestAll::test_reporting_relationships - sqlalche...
FAILED tests/test_bbconf.py::TestAll::test_cant_remove_record_if_in_reltable
FAILED tests/test_bbconf.py::TestAll::test_select - sqlalchemy.exc.Operationa...
FAILED tests/test_bbconf.py::TestAll::test_removal - sqlalchemy.exc.Operation...
FAILED tests/test_bbconf.py::TestAll::test_config_variables_are_set - sqlalch...
============================== 9 failed in 8.72s ===============================

Tests won't work now, because we don't have geniml released. And it is critical for us

I should still be able to run them locally, with geniml installed.


Error on finalize step

az ad app permission list --id $AZURE_CLIENT_ID [   {     "resourceAccess": [       {         "id": "3afa6a7d-9b1a-42eb-948e-1650a849e176",         "type": "Role"       },       {         "id": "1cda74f2-2616-4834-b122-5cb1b07f8a59",         "type": "Role"       },       {         "id": "824c81eb-e3f8-4ee6-8f6d-de7f50d565b7",         "type": "Role"       },       {         "id": "5778995a-e1bf-45b8-affa-663a9f3f4d04",         "type": "Role"       }     ],     "resourceAppId": "00000002-0000-0000-c000-000000000000"   },   {     "resourceAccess": [       {         "id": "e1fe6dd8-ba31-4d61-89e7-88639da4683d",         "type": "Scope"       },       {         "id": "18a4783c-866b-4cc7-a460-3d5e5662c884",         "type": "Role"       },       {         "id": "1bfefb4e-e0b5-418b-a88f-73c46d2cc8e9",         "type": "Role"       },       {         "id": "7ab1d382-f21e-4acd-a863-ba3e13f7da61",         "type": "Role"       },       {         "id": "9a5d68dd-52b0-4cc2-bd40-abcf44ac3a30",         "type": "Role"       }     ],     "resourceAppId": "00000003-0000-0000-c000-000000000000"   } ]
and here, no subscriptions found
az login --service-principal -u $AZURE_CLIENT_ID -p $AZURE_CLIENT_SECRET --tenant $AZURE_TENANT_ID No subscriptions found for 69af8774-d30a-450e-943d-175f7b497532.
and I can't list expiration dates  information
    "appId": "69af8774-d30a-450e-943d-175f7b497532",     "credentials": [       {         "created": null,         "expires": null,         "name": null       }     ]   },
I've set permissions :

and secret :

Thanks.

Hi @noway75 ,
That looks weird. Not sure, I can help you with this.

Hi @mkoertgen,
I think on azure side it's ok, how can I check it on app side ? thanks.

Maybe try using --debug with the azure cli. This will give some more diagnostics output of the intermediate REST API requests/responses that are made under the hood, cf.

https://github.com/mkoertgen/azure-app-exporter/blob/main/_docs/references.md#azure-cli

When I call :
curl http://<IP_ADDRESS>:8000/api/apps/
I've this error :
File "azure-app-exporter/src/services/azure_app_service.py", line 31, in get_all     self.observe(apps) File "azure-app-exporter/src/services/azure_app_service.py", line 60, in observe  expiry: Optional[datetime] = min(map(lambda c: c.expires, app.credentials)) expiry: Optional[datetime] = min(map(lambda c: c.expires, app.credentials)) ValueError: min() arg is an empty sequence

@mkoertgen
With this patch it's ok :
    def observe(apps: List[AppRegistration]):
        for app in apps:
            if app.credentials:
                expiry: Optional[datetime] = min(map(lambda c: c.expires, app.credentials))
            if expiry:
               APP_EXPIRY.labels(app_id=app.id).set(int(expiry.timestamp()))

Ah, well spotted. The expiry could be optional, so the code should be more robust. Great, thanks.
Concerning your question why only 6 of 50 apps are listed: This is probably related to the OData-response that is made under the hood.

Hi @noway75 ,
I am facing the same issues you listed in the start of this error, mind sharing how did you solved it? I configured everything same as you did and also getting null.


sqlcmd panics when using MSI on App Service

Running the following command
sqlcmd -d AdventureWorks2023 -S soulnorth.database.windows.net -Q "select count(*) from SalesLT.Product" --authentication-method=ActiveDirectoryManagedIdentity
gets me the following error on App Service:
sqlcmd.exe -d AdventureWorks2023 -S soulnorth.database.windows.net -Q "select count(*) from SalesLT.Product" --authentication-method=ActiveDirectoryManagedIdentity
panic: Unable to get user name

goroutine 1 [running]:
github.com/microsoft/go-sqlcmd/pkg/sqlcmd.(*Sqlcmd).ConnectDb(0xc0002cc3c0, 0x0?, 0x1?)
	D:/a/1/s/pkg/sqlcmd/sqlcmd.go:299 +0xc65
github.com/microsoft/go-sqlcmd/cmd/sqlcmd.run(0xc000006760, 0x1c01080)
	D:/a/1/s/cmd/sqlcmd/sqlcmd.go:761 +0x6e9
github.com/microsoft/go-sqlcmd/cmd/sqlcmd.Execute.func2(0xc000644300?, {0xc000101ce0?, 0x7?, 0x8?})
	D:/a/1/s/cmd/sqlcmd/sqlcmd.go:242 +0x3ce
github.com/spf13/cobra.(*Command).execute(0xc000644300, {0xc000642680, 0x7, 0x8})
	C:/Users/VssAdministrator/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920 +0x847
github.com/spf13/cobra.(*Command).ExecuteC(0xc000644300)
	C:/Users/VssAdministrator/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044 +0x3bc
github.com/spf13/cobra.(*Command).Execute(...)
	C:/Users/VssAdministrator/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968
github.com/microsoft/go-sqlcmd/cmd/sqlcmd.Execute({0x15dba18, 0x6})
	D:/a/1/s/cmd/sqlcmd/sqlcmd.go:265 +0x1a5
main.main()
	D:/a/1/s/cmd/modern/main.go:52 +0x21f

This seems to happen at a stage after the connection has been established (after sql.OpenDB() has been executed successfully) and the code is just trying to fill out some variables.
In this case it seems to fail after osuser.Current() fails (probably due to sandboxing restrictions on App Services?).
Same command works on a similarly configured VM.

thx for opening an issue!
I was wondering where osuser.Current() could fail, I guess this answers that!
I suppose an empty string for SQLCMDUSER is fine.


Add coverage coveralls

A certain amount of reshuffling was needed to run coveralls inside the Docker container.

Are you sure? exec -e was added quite some time ago, and in my testing, it looked like it submitted reports. But this works too.

https://github.com/docker/compose/issues/4551


Enable sync test with new dataset

Overview / Motivation
Enable sync test
The Task
TODO: Clearly describe the issue requirements here...
Implementation Notes
TODO: Add links to relevant resources, specs, related issues, etc...
Contribution Guidelines
Important: Issue assignment to developers will be by the order of their application and proficiency level according to the tasks complexity. We will not assign tasks to developers who haven't introduced themselves on our Gitter dev channel

Introduce yourself on go-spacemesh dev chat channel - ask our team any question you may have about this task
Fork branch develop to your own repo and work in your repo
You must document all methods, enums and types with godoc comments
You must write go unit tests for all types and methods when submitting a component, and integration tests if you submit a feature
When ready for code review, submit a PR from your repo back to branch develop
Attach relevant issue to PR

Duplicate of https://github.com/spacemeshos/go-spacemesh/issues/1469 ?

Duplicate of #1469 ?

No this is not, this one is for latency bug, the other is for fixing the sync since there has been changes in data structures and validation when running UT


Make non-global rate limiters global

Is your feature request related to a problem? Please describe.
The config for lost of rate limiters in the system is per instance, which is very hard to use. The ask is to provide a global (cluster-wide) config for them and auto adjust the actual used per-instance limit based on the # of instances in the ring.

Task scheduler (per namespace) rate limiter
Persistence (per namespace) rate limiter

Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Thank you for your feature request!
Currently, Temporal's rate limiters are configured on a per-instance basis. You're right, a global (cluster-wide) configuration with automatic per-instance adjustment based on the cluster size would be a valuable addition for task scheduler and persistence rate limiters.
While this feature is not yet available, you can consider using a workaround by setting the per-instance limit to a sufficiently high value that allows for the desired throughput across your cluster.
We appreciate your suggestion and will explore this feature for future releases.

Thank you for your feature request! We understand the need for global rate limiting configuration that can adapt to different cluster sizes.
Currently, Temporal doesn't offer cluster-wide rate limiting settings. However, a workaround could be to implement a custom rate limiter at the application level. You could use a library like Guava's RateLimiter to achieve this.
We appreciate your feedback and will consider it for future development.

Thank you for your feature request. We appreciate you taking the time to bring this to our attention.
Currently, Temporal doesn't support global rate limit configuration.
One possible workaround is to utilize a centralized monitoring system or your infrastructure's native rate limiting capabilities. This would allow you to dynamically adjust per-instance limits based on cluster-wide metrics.
We are actively working on improving our rate limiter configuration options, and we appreciate your feedback as we plan for future releases.

Thank you for your feature request. This is a great idea and we appreciate you bringing it to our attention. Currently, Temporal does not have a global configuration for rate limiters.
A workaround for this is to set the rate limiters to a high enough value that it doesn't become a bottleneck for the system. You could then potentially add custom code that dynamically adjusts the rate limit based on the number of instances in the ring.
We are always working to improve Temporal, and this feedback is valuable to us. Please continue to share your thoughts and ideas!


Add Shuffle & repeat to startup configuration file?

Is it possible to set Shuffle and Repeat (others?) options in "app.toml" conf file?
I would like to set them both to True on start up without sending cli commands every time the Spotify player app restarts.

A follow up question, currently there is a cli commands for toggling shuffle and repeat.
Can you add discrete On and Off commands? So when I send the on/off command I know exactly what state it is in.
Thanks

After experimenting with the repeat & shuffle commands I have some observations.
After I set Spotify player repeat to "context" it will get reset to off if Spotify player is restarted. However, if a new playlist is started the current repeat value is remembered. It would be good to have default settings in the app.toml file.
With regards to the shuffle command, it never gets remembered. It will always revert back to false on app restart as well as playing a new playlist (different from the repeat command). It would be good to have default settings in the app.toml file.
The current (non elegant) work around is start a playlist and toggle the shuffle. I have built a script that starts the playlist, sleep 5 seconds to give the playlist time to load then toggle the shuffle to True.
I don't know if these are Spotify limitations or Spotify_player bugs.
Please let me know what you think.

Can you add discrete On and Off commands? So when I send the on/off command I know exactly what state it is in.

Yes, should be easy to add one, but I will not be actively working on this project next few weeks. Open to PRs though.

Great. I look forward to the feature addition.

It will always revert back to false on app restart as well as playing a new playlist (different from the repeat command)

I know this as well and it's a limitation of the third-party library used for streaming (https://github.com/librespot-org/librespot/issues/19). However, shuffle should be the similar to repeat when playing a new playlist as I've implemented a patch in:
https://github.com/aome510/spotify-player/blob/b3c0592c46f32692a64784e750697ffd55b07533/spotify_player/src/client/mod.rs#L196-L198
Not sure if that's because you control the player using CLI. What's your setup?

I built and run Spotify player on a macmini 2012 Ubuntu 22.04.

Does it run as UI or daemon?

I am using your cli commands to control everything.

Did you run CLI commands in the same machine as the daemon?

I followed the instructions to make my own binary. The binary is either run directly from terminal (testing) to bring up the gui or I have Spotify player launched at startup.
Since you brought it up I wanted to ask you a related question. If I launch spotify player from terminal it opens the gui in that terminal window. If I launch it from startup I don't get a terminal gui window. Am I doing something incorrectly? I a not running a daemon service.

If I launch it from startup I don't get a terminal gui window. Am I doing something incorrectly?

Not too familiar with this startup process, maybe you need to initiate the app with a terminal as spotify_player itself cannot spawn a terminal window. For example, IIRC, with kitty terminal, you can do it with
kitty --class floating spotify_player

Do you run CLI commands in the same machine as the daemon?

If you run the CLI in the same machine with the app/GUI, the shuffle state should be correct upon starting a new playback

Everything is run one the same machine. Anytime I run a cli command to play a playlist the shuffle gets reset to false.


Integration with webpack dev server

Is there any programing usage example for integrating prism into webpack dev server?

Hey,
I'm afraid we do not really offer such option out of the box; however I know that web pack dev server has a proxy capability; you can easily use it to proxy the calls you would do to it (assuming it's your API) and move them to Prism.
Points taken, I think we can probably write a FAQ section for it.

I too have the same requirement,
I want to use prism in the integration test, so We already running webpack-dev-server to server the static files + proxy some requests, So it's easy for us if we can do the API mocking using the same webpack-dev-server rather than running 2 processes, one for dev-server and another one for stoplight prism.
I tried @XVincentX 's method and it worked , but still I need to run 2 process
devServer: {
            open: !isTestBuild,
            openPage: 'publisher',
            inline: true,
            hotOnly: !isTestBuild,
            hot: true,
            publicPath: '/site/public/dist/'
            proxy: {
                '/api/am': {
                    target: 'http://localhost:4010',
                    pathRewrite: { '^/api/am/publisher/v2/': '' },
                    secure: false,
                },
            },
        },


Fix usage of eq to add corresponding ne

Apparently in Python 2, you still need to implement __ne__ even if you've implemented __eq__ (https://stackoverflow.com/questions/4352244/python-should-i-implement-ne-operator-based-on-eq).

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

Run Python PostCommit

R: @aaltay

CC: @robertwb

Thanks, filed https://github.com/apache/beam/pull/6924 and added the TODOs.

Run Python PostCommit


Fix NPE constructor withArguments()

NPE occurs at the line below when withArguments() is passed just two arguments, where the first one is not null and the second one is null.
https://github.com/jayway/powermock/compare/master...occho:master#diff-cc5b1cb3f25544c6d7ad4d0ba720bf87R40
A simple test with a variable arity method.
https://gist.github.com/occho/32583fc23183e2aca6fa

Thank you


Add wording to line 38

The first section of the article says this:
"By default, script is allowed on sites that admins create. It is not allowed on OneDrive, on sites users create themselves, and on the root site for your organization."
That is true, but by default, it is also not allowed on Communication and Modern Team sites.  The DenyAddAndCustomizePages property is set to Enabled on those sites by default.  This omission has led to customers opening support cases.
I believe the wording should be updated to something like this:
"By default, script is allowed on most sites that admins create. It is not allowed on OneDrive, on sites users create themselves, on modern Team and Communications sites, and on the root site for your organization."

@kaarins PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Pause container version in helper.psm1

The helper.psm1 called by the install script has a hardcoded version of he pause container, set to version 1.0.0. Unfortunately this version is not compatible with newer k8s versions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 206db1f3-8451-0171-e103-fea3ab7b3f72
Version Independent ID: 87d7ab1c-1617-44a9-a77c-bf0443109e35
Content: Joining Windows nodes
Content Source: virtualization/windowscontainers/kubernetes/joining-windows-workers.md
Product: containers
GitHub Login: @daschott
Microsoft Alias: daschott

Can you use version 1.2.0?

Hi thanks a lot!
Yes with version 1.2.0 everything is fine indeed. In fact I use a mixture from both scripts, since the one on the kubernetes website had some issues with the flannel installation in my case.
It's good to know that there is a fix for the DaemonSets, I was not aware of this.

True native DaemonSet support is still pending privileged container support on Windows but there is a workaround using wins project that the current docs are leveraging


Add files via upload

@tky0065 I have to close this request without merging, because you requested to add a non-existent domain to this repository: ;; connection timed out; no servers could be reached Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


proc: replace cgo with syscalls on windows

Unrelated to conversion, I have also changed (*Thread).readMemory
to return only first count bytes of memory just as advised
by ReadProcessMemory.
Fixes #409
@lukehoban for your review. Thank you.
Sorry about the size of this change. I tried to make it as small as possible.

This looks great.
I had been looking at this in parallel, and your changes capture everything I had run across (including the CONTEXT alignment issue), but the syscall interfaces you have here are an even cleaner mapping that what I was using.
Other than the few review comments/questions, this looks good.
FWIW - This also fixes #412 and #416.
BTW - Build times on my laptop are halved with this change, and I can build on machines without MinGW (though of course have to avoid using the Makefile).  That's a really nice outcome.

FWIW - This also fixes #412 and #416.

Added these to my second commit. I have create #412 myself and then forgotten about it altogether.

I can build on machines without MinGW

Yes, like I said before.
go get github.com/derekparker/delve/cmd/dlv

is all you need to install dlv.exe on windows/amd64. Everywhere else (including linux, darwin and so on) it should be:
GOOS=windows GOARCH=amd64 go get github.com/derekparker/delve/cmd/dlv

Alex

This LGTM. Can you please rebase and I will merge.

Can you please rebase

How do I do that? I am git (and github) noob, so exact instructions are welcome. I tried and failed. Thank you.
 But that gives me some "merge errors" that I need to resolve manually. And that creates extra "merge" commit on top of my convert_to_syscall branch. What should I do with the extra branch? Should I combine it all into one new branch?
Thank you.
Alex

eh? no extra branch should be created. want to clarify what you mean?
you should see a screen like this pop up:
pick 3245ad 'commit 1'
pick 34def63 'commit 2'

this is just allowing you to specify what you want to do with the commits you are rebasing. (you can combine commits, which is called squashing, delete commits, etc) for what you're trying to do leave them all as picks.

eh? no extra branch should be created. want to clarify what you mean?

I run git rebase -i master and that worked (I had to resolve some conflicts along the way, but it worked). Now I want to send my local convert_to_syscall branch changes onto my github fork of delve. This is what I tried:
$ git status
On branch convert_to_syscall
Your branch and 'origin/convert_to_syscall' have diverged,
and have 7 and 2 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

nothing to commit, working directory clean
$ git push origin convert_to_syscall
To git@github.com:alexbrainman/delve.git
 ! [rejected]        convert_to_syscall -> convert_to_syscall (non-fast-forward)
error: failed to push some refs to 'git@github.com:alexbrainman/delve.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
$

I am not sure what to do now.
Alex

You can git push -f origin convert_to_syscall to overwrite the commits in the PR branch with the new commit that you created after the rebase.  See for example: http://stackoverflow.com/a/24527934

git push -f origin convert_to_syscall

That does the trick. Thank you. I still need to change ImageName.
Alex

Now I am done. Thanks for you help @james-lawrence and @lukehoban.
Alex

@alexbrainman I expect @derekparker will want the commits to be squashed.  You can do git rebase -i origin/master and then set the first commit to pick and the latter two commits to squash.  This will result in a single commit off of master with all of your work on this.

BTW - I can't tell why you are seeing test failures on OSX and Linux on Go1.6 here.  As far as I can tell - there are no changes in this PR that are even part of the build on those platforms.

You can do git rebase -i origin/master and

Done.

I can't tell why you are seeing test failures on OSX and Linux on Go1.6 here

I will let Derek decide what to do here.
Alex

Delve on OS X has a race condition on Launch that's hard to fix (because lack of documentation), that's why sometimes tests fail on OS X.
@alexbrainman: if you are interested in understanding git, for me the best introduction was Git from the Bottom Up.

@aarzilli I know enough git to be dangerous. So I prefer to ask, when I am not sure.
Alex

Thank you @alexbrainman for your help on this!

@lukehoban now that this is merged, the build instructions can be simplified on Windows, correct? Would you mind updating the wiki with the correct instructions please.

@derekparker and @lukehoban ping me if you need any help with windows code in the future.
Alex

@lukehoban  or @derekparker , just wanted to confirm, so with this change do you no longer need to use MinGW on windows to install delve?

@joegrasse That's right - you no longer need MinGW to build and use Delve on Windows.  For doing development work on Delve though, folks may want to use the Makefile, and for that you'll need a make install (and a few other tools used by the Makefile).  Technically though, you don't need to use the Makefile to build.


Custom dockerfile filename not working - v1.4.10

Description
I'm trying to build a docker image using a Dockerfile called `Dockerfile-web" (Because I need 2 Dockerfiles in the same directory, hence the custom name)
Using <dockerfile>Dockerfile-web</dockerfile> does not work
How to reproduce
Specify a Dockerfile that is not called Dockerfile using the <dockerfile> configuration option
What do you expect
The plugin to use Dockerfile-web for building my docker image
What happened instead
An error:
[INFO] --- dockerfile-maven-plugin:1.4.10:build (default-cli) @ client ---
[INFO] dockerfile: null
[INFO] contextDirectory: <my_proj_directory>
[INFO] Building Docker context <my_proj_directory>
[INFO] Path(dockerfile): null
[INFO] Path(contextDirectory): <my_proj_directory>
[ERROR] Missing Dockerfile in context directory <my_proj_directory>

Note the [INFO] Path(dockerfile): null (i'd expect this to be Dockerfile-web) and Missing Dockerfile
Software:

docker version:

Client: Docker Engine - Community
 Version:           18.09.2
 API version:       1.39
 Go version:        go1.10.8
 Git commit:        6247962
 Built:             Sun Feb 10 04:12:39 2019
 OS/Arch:           darwin/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          18.09.2
  API version:      1.39 (minimum version 1.12)
  Go version:       go1.10.6
  Git commit:       6247962
  Built:            Sun Feb 10 04:13:06 2019
  OS/Arch:          linux/amd64
  Experimental:     true

docker-maven-plugin version: 1.4.10
maven version: 3.5.2

Full backtrace
See above
The relavant part of my pom:
<plugins>
            <plugin>
                <groupId>com.spotify</groupId>
                <artifactId>dockerfile-maven-plugin</artifactId>
                <configuration>
                    <skip>false</skip>
                </configuration>
                <executions>
                    <execution>
                        <id>web</id>
                        <!-- Do not bind these goals to a phase -->
                        <phase />
                        <goals>
                            <goal>build</goal>
                            <goal>push</goal>
                        </goals>
                        <configuration>
                            <dockerfile>Dockerfile-web</dockerfile>
                        </configuration>
                    </execution>
                </executions>
            </plugin>
        </plugins>

Error occurs using mvn dockerfile:build
The use of  is based on this pr which was released as of 1.4.10 (my version)
Please help :)

@mattcopas did you find a fix?

I changed the "spotify"  version to 1.4.13
And then able to create build using IDE using "mvn package" .


Fixed #283

Not sure if _assembler.push( 0 ) should be replaced with _assembler.mov( asmjit::host::eax, 0 ) or something else.
This issue doesn't seem to exist in 64bit version.

For continuous integration to test the code.

Checks failed.


Prompt is included when copying command examples

The "$" prompt is included in the command examples when the copy button is used, leading to the rather confusing bash error "-bash: $: command not found".
Otherwise the containerized pdf conversion worked well.

Copying commands from the PDF? I have no idea if there is a way to customize the copy command like this for PDF.


Save full conversation

This thread proposes a /save command. This is different from /copy, because copy only copies the response. Often, I want to copy the whole conversation.
I'd like to propose a /save filename and /edit command. /edit would take the full conversation, put it into a temporary file, and open it in the system default editor.
If a PR on this would likely be accepted, I could look at implementing this.

Hello, @bjohas , thanks for the feedback.
Conversation are already saved in JSON format in the ~/.config/chatgpt-cli/session-history folder. I think you mean to save it in a more human readable text format, right? If so, I think it would be a nice feature, if you want to implement it I will be happy to review your PR... thank you! :)


Does not parse whois information for .co.uk domains

As in the title, this package does not work with .co.uk domains at all. Ran over a list of 2000 domains and no .co.uk whois was able to be parsed. Everything else seemed ok. .co.uk is a really big one to miss!

Correction! I realized that some.co.uk and .com.au domain do not provide expiry dates in the whois information. Is there another way to get these?

Correction! I realized that some.co.uk and .com.au domain do not provide expiry dates in the whois information. Is there another way to get these?

Sorry, I don't know about it.


Curriculum_remove SASS solution

As per @raisedadead in https://github.com/freeCodeCamp/freeCodeCamp/pull/25470
this PR removes the solution in the SASS challenge that was already merged.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @paulywill
Yes, @ValeraS has fixed the issue which were breaking the SASS tests. So we can now add solutions. :)
Thanks for the PR.


Update .travis.yml

Drop support of old node.js

How about just the latest stable and latest LTS Node.js release?

How about just the latest stable and latest LTS Node.js release?

@kevva ?

Anything I can do to help with this, so that #19 can merge? My goal is to resolve the npm audit warning for url-regex, which is a dependency of resize-image 1.x.
Looks like we just need @kevva to make a call on this.

@An6r @kevva can we get this merged so we can move on to #19

@An6r @kevva can we get this merged so we can move on to #19

@kevva any chance this can get a release?  https://github.com/kevva/to-ico/pull/19 is dependent on this and would please the community


Let's Encrypt and Web Proxy (Transparent)

Hi,
I've configured WebProxy in transparent mode, with SSL Inspection, it's up and running.
In "CA to use:", I've used INTERNAL CA to issue certificates for intercepted HTTPS traffic.
Today, I've installed Let'sEncrypt plugin, issued myself a certificate and when I tried to use  Let's Encrypt Authority X3 (Let's Encrypt) certificate instead of INTERNAL CA, Squid won't start.
I get an errors:
Jun 29 22:17:31 	configd.py: [6af81bc9-8919-4c62-8d85-753717ed14c0] returned exit status 1
Jun 29 22:17:31 	root: /usr/local/etc/rc.d/squid: WARNING: failed to start squid
Jun 29 22:17:31 	squid: No valid signing SSL certificate configured for HTTP_port <IP_ADDRESS>:3128
Is it, maybe, impossible to use Let'sEncrypt in this combination (transparent proxy with SSL inspection)?

Let's encrypt won't supply CA's (public+private), only certificates and public keys for it's own CA's, this can't work.
You can create your own CA using the webgui and trust that certificate in your clients.

OK, it figures ... I'll keep using my internal CA..
Tnx


Added more configuration options to redis.conf

I added the following configuration options to redis.conf and set the default values to the default values from Redis.

aof_load_truncated
aof_rewrite_incremental_fsync
appendfilename
hll_sparse_max_bytes
latency_monitor_threshold
min_slaves_max_lag
min_slaves_to_write
notify_keyspace_events
repl_backlog_size
repl_backlog_ttl
repl_disable_tcp_nodelay
slave_priority
tcp_backlog

Is there anything else you need to merge this in?

Caffeine. Lots of caffeine. :coffee:
All kidding aside I'll try to find some time tomorrow to review and merge this PR.

I know the feeling.  Thanks, man!  I appreciate it.

Finally got around to it.
Looking good, thanks!


Update in PUBLISH_DATE_TAGS for date extraction

 Issue by yoonoh930
Mon Dec  7 12:57:32 2020
Originally opened as https://github.com/codelucas/newspaper/pull/861

Korean web portal "Daum" another attribute in  for the published datetime.
Link: https://news.v.daum.net/v/20201207190232276

yoonoh930 included the following code: https://github.com/codelucas/newspaper/pull/861/commits

done


[Bug]: InvalidPathException during the code coverage generation in Windows

Description
[2022-10-04 09:25:07,184] SEVERE {b7a.log.crash} - Illegal char <*> at index 182: D:\a\module-ballerina-http\module-ballerina-http\ballerina-tests\target\cache\tests_cache\coverage\bin\ballerina\http\2\$value$(ballerina$0047http$00582$0058$anonType$Method$$delete$**$_2 & readonly).class
java.nio.file.InvalidPathException: Illegal char <*> at index 182: D:\a\module-ballerina-http\module-ballerina-http\ballerina-tests\target\cache\tests_cache\coverage\bin\ballerina\http\2\$value$(ballerina$0047http$00582$0058$anonType$Method$$delete$**$_2 & readonly).class

Found in HTTP PR build on windows.
at org.ballerinalang.test.runtime.util.CodeCoverageUtils.unzipCompiledSource(CodeCoverageUtils.java:116)
    at org.ballerinalang.test.runtime.entity.CoverageReport.addCompiledSources(CoverageReport.java:302)
    at org.ballerinalang.test.runtime.entity.CoverageReport.generateReport(CoverageReport.java:139)

Steps to Reproduce
Build the HTTP package in windows
Checkout to : https://github.com/chamil321/module-ballerina-http/tree/exit
Cmd :
./gradlew clean build -x http-native:test -x :http-ballerina-tests:startLdapServe -x :http-ballerina-tests:stopLdapServer -x :http-compiler-plugin-tests:test -x :http-ballerina-tests:commitTomlFiles -x :http-ballerina:commitTomlFiles

Affected Version(s)
No response
OS, DB, other environment details and versions
No response
Related area
-> Runtime
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

Fixed with https://github.com/ballerina-platform/ballerina-lang/pull/38081


Windows CI builds are systematically slower for some reason

@etanshaul
@nbashirbello
@nkibler
FYI I've removed the Windows PR build from the blockers for merging until we figure out what's happening here.

closed as stale. we've since updated our CI infrastructure several times.


DevelopmentTools::locate: Prefer brewed tools [Linux]

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Prefer brewed tools over the host's tools, particularly binutils and gcc.

Thanks again!

Thanks for merging, Mike!


if plugin is loaded in via pluginState, viewerHandle functions can cause undefined error

Probably user error. viewerhandle can always be undefined. clarified in 2cb2d70171b1462d2eaa649eedece62720a8a09e


The model issue

Hello, I would like to ask the following questions: I performed data conversion and preprocessing according to your instructions. When I ran the first fold, line 193 in the model file: assert L == S * H * W reported an error, please ask Have you encountered this problem?

When you start training, make sure that the numbers in the screenshot are the same as yours, if they are different, please use the latest version of the code

Thanks for the answer，the issue has been solved successfully.The network began to train.

OK


Feature request - Option to filter manually entered data

Hi and thanks for this neat package!
I'm submitting a feature request for the possibility to left out user entered data when querying for distance/steps. This would enable to use only "real" data.
As a test, I managed to implement it in the iOs version of GetSteps by doing the following:

Declare a predicate that leaves out User Entered data

NSPredicate *sourcePredicate = [NSPredicate<EMAIL_ADDRESS>!= YES", HKMetadataKeyWasUserEntered];

Use this predicate when querying:

HKStatisticsCollectionQuery *query = [[HKStatisticsCollectionQuery alloc]  initWithQuantityType:type quantitySamplePredicate:nil options:HKStatisticsOptionCumulativeSum anchorDate:anchorDate intervalComponents:interval];
I'd like to work on that feature request, but I do not master Swift nor Java and haven't experienced working on a bridge between RN and Native. I'm more than happy to help you, let me know how I could proceed!
Cheers

Any news on this?
Would be great to filter manually entered data!

Hi and thanks for this neat package!
I'm submitting a feature request for the possibility to left out user entered data when querying for distance/steps. This would enable to use only "real" data.
As a test, I managed to implement it in the iOs version of GetSteps by doing the following:

Declare a predicate that leaves out User Entered data

NSPredicate *sourcePredicate = [NSPredicate<EMAIL_ADDRESS>!= YES", HKMetadataKeyWasUserEntered];

Use this predicate when querying:

HKStatisticsCollectionQuery *query = [[HKStatisticsCollectionQuery alloc] initWithQuantityType:type quantitySamplePredicate:nil options:HKStatisticsOptionCumulativeSum anchorDate:anchorDate intervalComponents:interval];
I'd like to work on that feature request, but I do not master Swift nor Java and haven't experienced working on a bridge between RN and Native. I'm more than happy to help you, let me know how I could proceed!
Cheers

this seems to work, still needs testing.
Perhaps there is a solution for android also
In Manager.java there are processSteps and processDistances methods
            if (!"user_input".equals(dp.getOriginalDataSource().getStreamName())) {
                caloryMap.putString("startDate", dateFormat.format(dp.getStartTime(TimeUnit.MILLISECONDS)));
                caloryMap.putString("endDate", dateFormat.format(dp.getEndTime(TimeUnit.MILLISECONDS)));
                caloryMap.putDouble("quantity", dp.getValue(field).asFloat());
                map.pushMap(caloryMap);
            }

            This if might solve it

Hi,
It seems like someone has already made a fork that does the 'exclude user entered data' on both the android and iOS side:
https://github.com/LVGP2021/react-native-fitness
It seems like this should be exposed as an option when querying (IE: either 'get all steps' or 'get not-manually-entered-steps) rather than it being 'hard ignored' all the time.
Is this project still active? If so I might refactor that code to make it an option and then do an MR in :)

Hi @IsaacInsoll ,
thanks foor your reply. Feel free to open a PR, any help will be appreciated


add minigame team text channels

Issue I just thought of: if players switch their channel then I don't think they can switch back to their team's channel

will fix merge conflicts after feature/punishments is merged as it has some color tweaks i want to use


client.connect always fails with -2

Network with 2 MQTT servers (one on a Mac, one on a pi). Client on iphone can pub/sub to both; each can pub and sub to the other so doesn't seem to be MQTT side. Everything MQTT_VERSION_3_1_1
Can ping Heltec_WiFi_Lora32 from MQTT servers connection established.
DHCP issues same IP each time.
Note: On Arduino/PlatformIO Ethernet.h conflicts with SPI.h, so used Internet2 package (is this ok?)
Any clue how to overcome problem?
Thanks
#include <WiFi.h>
#include <PubSubClient.h>
#include "SPI.h"
#include <Ethernet2.h>
#include "SSD1306Wire.h"
#include <Wire.h>

const char* ssid = "HUAWEI_T222";
const char* password = "ABCDEF10293222";
const char* device_id = "dev01";
IPAddress server(192,168,8,102);  // MQTT server (Mac)
WiFiClient espClient;
SSD1306Wire display(0x3c, 4, 15);
String rssi = "RSSI --";
String packSize = "--";
String packet ;
IPAddress ipIP; // dhcp ip ends 101
EthernetClient ethClient;
PubSubClient client(ethClient);

void connectToNetwork() {
  WiFi.begin(ssid, password);
  delay(1500);

  while (WiFi.status() != WL_CONNECTED) {
    delay(1000);
    Serial.println("Connected to WiFi..");  // works
    delay(500);
  }

  Serial.println("Connected to network");
  ipIP =  WiFi.localIP() ;
  Serial.println(ipIP);
}

void connectToMQTTServer() {
  Serial.println("Connecting to MQTT Server");
  client.setServer(server, 1883);
  client.setClient(ethClient);

   while (!client.connected()) {
    Serial.print("Attempting MQTT connection...");
    if (client.connect(device_id)) { // fails always
      Serial.println("connected");
      // Once connected, publish an announcement...
      client.publish("garden/light","works");
    } else {
      Serial.print("failed, rc= ");  // always fails with -2
      Serial.print(client.state());
      Serial.println(" try again in 5 seconds");
      // Wait 5 seconds before retrying
      delay(5000);
    }
  }
}

void setup() {
  Serial.begin(115200);
  while (!Serial);
//  WiFi.mode(WIFI_STA); // doesn't help
  connectToNetwork();
  connectToMQTTServer();
  Serial.println("init ok");
}

void loop() {
  Serial.println("In publishing loop");
  display.clear();
  display.setTextAlignment(TEXT_ALIGN_LEFT);
  display.setFont(ArialMT_Plain_10);
  int p = client.publish ("garden/light", "On");
  if (p == true)
//   display.drawString(40, 30, "Published");
  else
//    display.drawString(40, 30, "Pub Failed");
//  display.display();

}

Because you are using WiFi and for PubSubClient client(ethClient) you are using EthernetClient ethClient so change it with WiFiClient espClient so your PubSubClient client(espClient) is now it will work.


MJ-raw vs MJ-text

I am currently using the grapejs editor with the MJML framework. I created a block (within grapejs) to insert raw html within a template. It works best with mj-text. Is there issues later I can run into with mj-text? I know that mj-raw is made for this purpose but it interferes with the drag and drop of the grapejs editor.

mj-raw will basically allow you to add any content anywhere (for example between sections), whereas you're limited by the syntax with mj-text (as your content has to been inside a text tag, which is inside a section and a column).
However, if your plan is simply to add custom HTML to have more control on your layout than with MJML tags, mj-text will do the job perfectly. mj-raw will be more useful to use a templating language for example as you can put it anywhere.
This should answer your question so I'm closing, but feel free to comment if it's still unclear.


docs(readme): add table of browser permissions to preferences and notes

There is a distinct lack of docs around browser preferences so it would be nice to lay it out in a table as a reference. I'd even be fine making it into a GH wiki.

Closed now in CONTRIBUTING with some basic details. Could use a breakdown of different permissions 🤷♂


refactor(iroh-net): use tokio-util::codec for derp protocol implementation

Description
We have been having issues multiple times with the buffer management, this cleans up things and should make them more reliable.
Notes & open questions
Is this the right abstraction?

This is not just a refactor but also fixes a bug with frame reading. Without this the derper is basically unusable as a relay.
This PR is just the fix without the refactor. It also fails the tests. Maybe that is a hint regarding the cause: https://github.com/n0-computer/iroh/actions/runs/5935069054?pr=1382


question page has a few variables called 'e'

variable names should never be single character names.
Rename them to something that makes sense, either event or audioName for playAudio()

Updated


Warn errors from BaseInputFileHeadless in tairo

https://github.com/shuriken-ui/nuxt/blob/83f8835d5fb578bcad6cdbf74a00ef7343d89250/components/form/BaseInputFileHeadless.vue#L130
When attempting to use this component indirectly within form-6.vue demo page, I receive the errors which appear to be caused by mismatches in the ref names:
 [Vue warn]: Property "el" was accessed during render but is not defined on instance.
 [Vue warn]: Property "files" was accessed during render but is not defined on instance.
 [Vue warn]: Property "preview" was accessed during render but is not defined on instance.

It triggers only on the refs that have been renamed immediately prior to export within setup.

Should be fixed in https://github.com/shuriken-ui/nuxt/releases/tag/v1.0.0


GPC-78: add api versioning

This seems fine, to check this is going to give us incrementing builds, one per commit since the 0.0.1 tag?

This seems fine, to check this is going to give us incrementing builds, one per commit since the 0.0.1 tag? I think I'd be keen to put some information in the tag, like version-0.0.1, and tell GitVersion what the prefix is, but I'm not too worried by this.

From what I can tell, yes - I'll give this a go