Added 5 resources to mechanical engineering.

Hello, added 5 resources in mechanical engineering. Submitting as part of hacktoberfest.

Looks good
Thank you!


can't see messgaes before i send message

I have to send a message each time to see the response of the person of I am writing

In login to IG:dm - "The password you entered is incorrect. Please try again." But I tested my password and it's correct! Any idea what to do? (I have Windows 8)

also having this problem

linux latest ubuntu version doesn't update messages before i restart the app. even upon restarting i have to navigate to a specific user and send them a message to get previous messages to show


Issue with @mui/icons-material using Vite and SSR

Steps to reproduce
Steps to Reproduce:

Clone the repository.
Run npm install to install dependencies.
Run npm run dev to start the development server.
The error should appear when loading the project.

Current behavior
When trying to use @mui/icons-material with Vite in an SSR setup, an error occurs during SSR evaluation. The module fails to import properly, and the warning below is logged:
(node:269010) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension. (Use node --trace-warnings ...to show where the warning was created) 4:55:57 PM [vite] Error when evaluating SSR module /app/routes/_index.tsx: failed to import "@mui/icons-material" |- /home/<user>/mui-remix-esm-error/node_modules/@mui/icons-material/esm/index.js:1 export { default as Abc } from "./Abc.js"; ^^^^^^
Expected behavior
The @mui/icons-material package should be correctly imported and rendered without errors in an SSR environment using Vite. The icons should appear as expected in the application, and no module resolution errors or warnings should occur related to ESM. The project should run smoothly with all dependencies working as intended, and SSR should not fail due to this package.
Context
No response
Your environment

npx @mui/envinfo
 System:
    OS: Linux 6.12 Arch Linux
  Binaries:
    Node: 20.17.0 - ~/.nvm/versions/node/v20.17.0/bin/node
    npm: 10.8.2 - ~/.nvm/versions/node/v20.17.0/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: Not Found
  npmPackages:
    @emotion/react: ^11.14.0 => 11.14.0
    @emotion/styled: ^11.14.0 => 11.14.0
    @mui/core-downloads-tracker:  6.2.1
    @mui/icons-material: ^6.2.1 => 6.2.1
    @mui/material: ^6.2.1 => 6.2.1
    @mui/private-theming:  6.2.1
    @mui/styled-engine:  6.2.1
    @mui/system:  6.2.1
    @mui/types:  7.2.20
    @mui/utils:  6.2.1
    @types/react: ^18.2.20 => 18.3.18
    react: ^18.2.0 => 18.3.1
    react-dom: ^18.2.0 => 18.3.1
    typescript: ^5.1.6 => 5.7.2

Search keywords: vite ssr

Duplicate of https://github.com/mui/material-ui/issues/43980

Duplicate of https://github.com/mui/material-ui/issues/43980


Update windows build instructions

Also adds instructions on how to produce standalone builds

also i enabled write access for maintainers so if theres any small issues to fix go ahead

LGTM

Great, should be easier for people to get started now. Thank you @RAnders00


allow merge_section to merge children classes

That's it.
Instead of going for the m_section_def, one can go for the name of the property, that remains always the same when some child class is used.
What do you think?
Summary by Sourcery
Enhancements:

Modify merge_sections function to use property names instead of sub_section_def for merging child classes.

I guess as long as it works it should be good. Can you add a test case to the unit test which breaks with the old implementation and is fixed with the new one?

Ah, I see now that the old tests don't run. I guess the first step would be to get those to run.

Thanks for the fix, it looks better. For the truth of the statement I intend that update.m_def will always be a parent of section.m_def, not the opposite. So if update is not a parent of section, the statement will be false.
Ah wait, in your suggestion this is a not missing, oder ? @ka-sarthak

Ah, not should be added for sure

Okay, now I understand what you intend to do. I wonder if there are cases when this would fail. An extreme case will be that update is of type BaseSection and section is of type XRayDiffraction

Is XRayDiffraction a BaseSection ? If not, the statement will be false,
no issues, right?

Yes, the if will be true in this case, and the real "merging" of quantities will start happening; I wonder if the function will break there. Maybe not. Will be worth testing ;)

Ah, I see now that the old tests don't run. I guess the first step would be to get those to run.

which are the old tests not running? I see 3.9-3.10-3.11 passing

Ah, I see now that the old tests don't run. I guess the first step would be to get those to run.

which are the old tests not running @hampusnasstrom? I see 3.9-3.10-3.11 passing

@aalbino2 this was a comment on your original PR which did not pass the tests. Now you seem to have fixed it with Sarthak's suggestions.


Release Localization plugin 0.11.0

This pr resolves https://github.com/mapbox/mapbox-plugins-android/issues/1038 and has changes for the 0.11.0 release of https://docs.mapbox.com/android/plugins/overview/localization/

cc @snkashis, who's expressed interest in this release

@LukasPaczos , things are looking good on Nexus


refactor: use blob share version for padding shares

Closes https://github.com/celestiaorg/celestia-app/issues/2142

Codecov Report

Merging #2148 (30a0061) into main (b77ac63) will decrease coverage by 0.11%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
- Coverage   24.28%   24.17%   -0.11%
==========================================
  Files         125      125
  Lines       14248    14252       +4
==========================================
- Hits         3460     3446      -14
- Misses      10432    10448      +16
- Partials      356      358       +2

Impacted Files
Coverage Δ

x/blob/types/payforblob.go
69.54% <0.00%> (-4.02%)
:arrow_down:

x/mint/types/constants.go
100.00% <ø> (ø)

pkg/shares/split_sparse_shares.go
46.26% <40.00%> (-1.36%)
:arrow_down:

pkg/shares/padding.go
52.08% <100.00%> (ø)

test/txsim/blob.go
80.00% <100.00%> (-0.65%)
:arrow_down:

x/blob/ante/ante.go
85.00% <100.00%> (-3.47%)
:arrow_down:

x/blob/keeper/keeper.go
80.00% <100.00%> (-2.76%)
:arrow_down:

... and 1 file with indirect coverage changes


libm: Do not link the toolchain's libm unless explicitly selected

Summary

libm: Do not link the toolchain's libm unless explicitly selected

Fix CMake-based build system to include the toolchain's libm only when CONFIG_LIBM_TOOLCHAIN is selected. Before this PR, if the user selected CONFIG_LIBM_NEWLIB, for instance, the build system would still link the toolchain's libm functions instead of the ones provided by newlib.
Impact
Fix error of not using newlib's libm.
Testing
Internal CI testing + rv-virt:nsh.
To test it using rv-virt:nsh (cmake -B build -DBOARD_CONFIG=rv-virt:nsh -GNinja), enable CONFIG_LIBM_NEWLIB and use the following application:
nooptimiziation_function
int main(int argc, FAR char *argv[])
{
  double x = 1.0;
  double y = 2.0;
  double z = 3.0;

  double result = fma(x, y, z);
  printf("result: %f\n", result);

  return 0;
}

Build with CMake (cmake --build build) and check build/nuttx.map content for the fma function. Before this commit, one can check that the toolchain's libm was being used instead of the newlib's.

Follows https://github.com/apache/nuttx/pull/15022#discussion_r1867942759

@tmedicci will it work with all lib math supported by NuttX (see nuttx/libs/libm/) ? For instance: libmcs is used by scientific applications where high accuracy is needed ("default"/common libm has many issues)

@tmedicci what's about other arch?

@tmedicci what's about other arch?

I was checking it at this moment. For some reason my first find only found it for RISC-V and tricore. But there are others. Sending it in a another PR soon.

@tmedicci will it work with all lib math supported by NuttX (see nuttx/libs/libm/) ? For instance: libmcs is used by scientific applications where high accuracy is needed ("default"/common libm has many issues)

I don't know, Alan.
But this was already done for x86 (https://github.com/apache/nuttx/pull/11772) and for Make-based (for all archs) build: https://github.com/apache/nuttx/blob/3dde10adaa14e123652cac9c6700296a30a002ab/arch/risc-v/src/common/Toolchain.defs#L414


templates flutter packages updates

- What I did
Bumped the templates @platform flutter packages
- How I did it
Referencing the newer pub.dev versions.
- How to verify it
Create a new Flutter app using at_app cli and in pubspec.yaml the new packages will be referenced instead of the old ones
- Description for the changelog
Updated the templates Flutter packages to be generated by the cli

That file is generated by the build pipeline, these changes will be reverted by the CI. The appropriate place to change these is in the templates folder under each template.yaml file.

Oh okay let me see


BUILD, MAINT: Migrate to Cython 3 and use the Iterator API instead of PyArray_MultiIter_* functions for iteration.

This PR migrates the build process from cython 0.29.* to cython 3.0.* .
It also migrates the internal  broadcasting logic from numpy's old MultiIter_* functions and uses the newer and more flexible Iterator API to encapsulate the broadcasting logic. This improves the readability and makes maintaining the code a lot easier since the numpy API does most of the allocation, broadcasting, casting and reshaping internally.
The above change allows us to now accept arrays of any dimensions > 1 for the out parameter.

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

polyagamma/__init__.py
100.00% <ø> (ø)

polyagamma/_polyagamma.pyx
99.21% <99.14%> (-0.79%)
:arrow_down:

:loudspeaker: Thoughts on this report? Let us know!


Added histplot to data_doctor output

Increased figsize to 18, 5, to accommodate the histplot as a third plot.

Additional changes to plotting:
Added flexibility for keyword arguments (kde_kws, hist_kws, and box_kws) in the data_doctor function to allow users to customize Seaborn plots directly. This enhancement enables users to pass additional parameters for KDE, histogram, and boxplot customization, making the function more adaptable to specific plotting requirements.
Changes:

Introduced the following dictionary-based keyword argument inputs:

kde_kws: Allows customization of the KDE plot (e.g., color, fill, etc.).
hist_kws: Allows customization of the histogram plot (e.g., stat, color, etc.).
box_kws: Allows customization of the boxplot (e.g., palette, color, etc.).

Updated docstrings to reflect these changes and improved the description of the plotting logic.

This should provide users with more control over the visual output without altering the core functionality of the data_doctor function.


Phenotype missing in glossary section

I expected to see a definition for phenotype in the glossary section of the spec.
I guess they would be tagged as associated_data (like stimulti) but I am not certain.

I think phenotype is a bit of a special case, since there are rules for how files in that folder should be unorganized, unlike stimuli or code, but associated_data seems like a good place to add it. Would you be willing to open a PR?

I think phenotype is a bit of a special case, since there are rules for how files in that folder should be unorganized

Actually, you might have raised a shortcoming in the current taxonomy. My understanding was that associated_data implies data stored within are unregulated by the spec, which is not the case for phenotype covered by the tabular data section of the spec.
I wonder whether the solution is to introduce a new term to distinguish between unregulated and regulated optional data, something like additional_data (regulated)  and associated_data (unregulated), or widen the scope for associated_data to data which may or may not be regulated.

Would you be willing to open a PR?

Of course :-)

Actually, I came to realize that phenotype is not that much different to the definition of datatype, but applied to modality-agnostic file collections.
Let's imagine phenotype but at the subject level, we get:
sub-<label>/
    phenotype/
        sub-<label>_acds.json
        sub-<label>_acds.tsv
        sub-<label>_npi.json
        sub-<label>_npi.tsv

It really looks like the same constructs used for imaging files at the end of the day, with phenotype as the datatype and acds | npi as the suffix.

I think this issue was fixed.
See https://bids-specification.readthedocs.io/en/latest/glossary.html#phenotype-files


Add support / documentation for OpenID Connect

NOTE Originally reported by @btiernay on https://github.com/spring-projects/spring-security/issues/98
Right now it is unclear how one would implement OpenID Connect using Spring Security. There isn't much on the topic in the documentation or the web. The most popular hit on google for openid connect spring is the following:
https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server
However, it seems pretty heavy weight and full stack, akin to using CloudFoundry's UAA over Spring's OAuth 2.0 support.
There are the following unanswered questions on SO that get to the heart of the problem:

http://stackoverflow.com/questions/21701444/how-to-secure-private-soa-webservices-spring-security-oauth-openid-connect
http://stackoverflow.com/questions/11849148/how-to-implement-openid-connect-and-spring-security

There is also this mention from the Spring blog:
http://spring.io/blog/2014/04/18/spring-security-oauth-2-0-0-rc1-available

The Authorization Server APIs have been refactored a lot to enable new use cases to be easily added: for example OpenID Connect (OIDC), MAC tokens, or the new Token Revocation standard are easy to add. I know of at least one OIDC implementation that use Spring OAuth2 2.0 already.

However it is unclear what that implementation is, whether or not it comes recommended and if Spring has any plans to support it in the future.
What would be nice is some guidance from Spring at the very least (in documentation for example). However, first class support for OpenID Connect (much like Spring's OAuth2 support) would be great since it represents the future of federated identity management.
ps. JIRA was down when this ticket was created so I apologize for any duplication.

Any advice on a greenfield implementation?  The thread is a bit old, so apologies in advance for the potentially out of date question.  I did see the Library list on http://openid.net/developers/libraries/ but was unsure of the best fit.  Feel free to tell me to research before asking silly questions.

It looks like there is an outstanding pull request #627 that would (at the least) allow application code to implement returning of id_tokens from the AuthorizationEndpoint.  Can this be pulled upstream?

I'm not sure #627 is the right approach but it's certainly worth a look (I would change the names of the interfaces at least). The bigger picture: we should definitely put this forward as a priority for a 2.1 (or 3.0) release, but there isn't much bandwidth amongst the comitters right now. Pivotal are trying to hire someone to do this, so if you (or anyone you know) has some experience in Appsec and is interested in a job, please reach out.

Also note that MITREid Connect provides a perfectly fine client module if you want to provide OIDC login (either for a web application, or to protect a resource with a token).
Implementing the server part quite complex, and not something I'd expect to see in a "plug and play" Spring module -- you'll probably want to run this is as a separate application anyway (akin to OpenAM, CloudFoundry UAA, or the MITREid Connect server).

Fresh OIDC server (idp) implementation as a Spring Boot app! Would be nice!
But anyway, for all the interested, here's another ongoing effort on top of Spring Oauth, MITREid and Shibboleth idp: https://github.com/uchicago/shibboleth-oidc

Hi, I can see that support for OpenID Connect is planned for 2.1.0 release.
Is there any information when the development of 2.1.0 release will start approximately or when we can expect OpenID Connect + Spring Boot support?
Thank you!

Hello,
From my understanding, OIDC Connect (client-side) support in Spring would need  :

idToken handling (signature verification and idToken claims validation)
jwks_uri support (for handling idToken verification)
optionally mapping custom claims in idToken to GrantedAuthorities would be a goodie (i.e. role claims).
userPrincipal name mapping should be done from name claim (http://openid.net/specs/openid-connect-core-1_0.html#rfc.section.5.1)

Using idToken render calling userEndpointUri useless in the Application Client side.

In the meanwhile, I'm currently using Keycloak as my authorization server, which is fully OIDC compatible and provides a handy set of adapters for this spec. More concretely, the ones implemented are for Spring Boot and Spring Security, while there's the chance to use the Spring Security one with Spring Boot too. Worth to have a look:
https://github.com/keycloak/keycloak/tree/master/adapters/oidc

does anyone has sample for OpenId connect with Azure AD. I want to use both of them in my RestAPI(Spring Boot)? In future i am planning to integrete these two on my API Gateway ZUUL.
Thanks

Here's an additional example of an OIDC client built on top of spring-security-oauth, for anyone else stumbling across this thread.

@dhiraj65 see https://github.com/Microsoft/azure-spring-boot/issues/244#issuecomment-382840920
If possible, use the Azure AD v2.0 URLs, you then need to add /v2.0/ to the provider URLs in that config, see https://login.microsoftonline.com/{tenant}/v2.0/.well-known/openid-configuration for the URLs. It's supposed to be easier once spring-security 5.1 is released and supports openid autoconfig, then just point it to the above URL :-)

Closing as this is a major change that we are no longer accepting.
As you may be aware, this project is in maintenance mode and will reach EOL in the very near future. Please see the initial announcement and follow-up announcement for further details.
At this time, we are only accepting bug fixes and minor enhancements that can be cleanly merged into master.
Please see the OAuth 2.0 / OpenID Connect support in Spring Security (since 5.0).


:sparkles: Adding common MimeType base to @shopify/network

Description
Fixes https://github.com/Shopify/quilt/issues/411
This PR adds an enum of common mime types to @shopify/network.  These choices were based off of the most frequently used mime types in Shopify/web plus the suggested ones from the issue.
It is not an exhaustive list and more values can be added.
Type of change

[ ] @shopify/network Minor: New feature (non-breaking change which adds functionality)

Checklist

[x] I have added a changelog entry, prefixed by the type of change noted above

I feel we should probably create a new @shopify/files package.
We already have this package internally in web. We can expose it in quilt.
The network package is for common values related to dealing with the network.
Mime types + exposed helpers like getExtensionFromMimeType are use extensively at runtime in the app for features like the image editor or rich media (not dealing with network specifically).
WDYT?

I think that's a good suggestion.
This PR was initially just solving the issue of adding mime-types, but looking at @shopify/files inside web, some mime types on these PR were taken from there, and adding the extra helpers to a unique package makes sense.
Can move forward with the package, and link https://github.com/Shopify/quilt/issues/411 to it as well.

@posth Feel free to bring it up to #web-foundation-tech. I didn't see the original issue mentioned @shopify/network. I think it would be better in a new files package but we can definitely move forward with this change if it makes sense for everyone. Nice addition no matter where it is 😄 💯

@posth Feel free to bring it up to #web-foundation-tech. I didn't see the original issue mentioned @shopify/network. I think it would be better in a new files package but we can definitely move forward with this change if it makes sense for everyone. Nice addition no matter where it is 😄 💯

Going to close this PR in favour of introducing a new package.  We can re-open this if it makes sense to just add the mime types, but we can continue onto the package PR.


Title Case Sentence >> Puzzled As to Why It Fails

This is the code that was written. I am unclear as to why it is failing.  You're almost there. Your code doesn't complete the challenge precisely, but it is close. Please take a look at the challenge closely and what the tests require. Good luck. And please ask coding help in the Gitter rooms linked below first. GitHub is not for coding help.
This is a standard message notifying you that this issue seems to be a request for help. Instead of asking for help here, please click the "help" button on the challenge on freeCodeCamp, which will take you to the help chatroom for that specific challenge. You can also view our full list of official chatrooms.
If you think I'm wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding!

Thank you for your kind assistance and the notification of the rules.


Alex's Mobs Crash Due to Non-unique Mixin

Mod Name
Alex's Mobs / Citadel
Mod Homepage
https://www.curseforge.com/minecraft/mc-mods/alexs-mobs
Describe the bug
Attempting to load Alex's Mobs will crash on launch due to non-unique mixin between Alex's Mobs and Citadel.
Steps to reproduce

Using Connector Beta 20, Citadel 2.4.5, and Alex Mobs 1.22.6
Launch the game and game will crash upon load attempt.
Does affect other mods that use citadel as a dependency with similar crash log between the mod and citadel.

Logs
https://paste.gg/p/anonymous/a5cd71f4be5d4458a753350d0088f8ca
Additional context
No response

i get this with cloud storage and other older citadel mods

”Connector Beta 20“Crashes numerous mods

”Connector Beta 20“Crashes numerous mods

Which ones?

“连接器测试版 20”崩溃了许多模组

哪些？
“zoomify”  “Alex's Mobs”  “L_Ender 's Cataclysm”其他未测试

In case of Alex's Mobs, the mod re-specifies Citadel's mixin configs. Which was added in this commit related to NeoForge.

IG this can be fixed by checking if the config exists in the modfile.
                    if (Files.exists(modFile.getFile().findResource(config))) {
                        ModFileInfo prev = configToModMap.putIfAbsent(config, modFile);
                        if (prev != null)
                            throw new RuntimeException(String.format("Non-unique Mixin config name %s used by the mods %s and %s", config, prev.moduleName(), modFile.moduleName()));
                    }

Btw, FabricUtil still doesn't work, even in Beta 20. So handlers don't get their prefix and config blame still says (unknown)

It's fixed now. I set it to log an error on duplicate mixin configs without crashing, as this functionality is not required to run the game. I don't know why Alex's caves lists citadel's mixin config despite not including it, but that should be fixed on their side.


Expand Bottom Panel tooltip does not appear in 4.4dev3+

Tested versions
Not reproducible in 4.4dev2
Reproducible in 4.4.dev3
Reproducible in master (https://github.com/godotengine/godot/commit/db66bd35af704fe0d83ba9348b8c50a48e51b2ba)
System information
Windows 10
Issue description
In 4.4dev3 and forward, the tooltip for "Expand Bottom Panel" does not appear. Other tooltips on the bottom panel are unaffected.
4.4.dev2:

4.4dev3:

4.4dev (https://github.com/godotengine/godot/commit/db66bd35af704fe0d83ba9348b8c50a48e51b2ba):

4.4dev(https://github.com/godotengine/godot/commit/db66bd35af704fe0d83ba9348b8c50a48e51b2ba). Other tooltips in bottom panel still work:

Steps to reproduce
Open the editor in the specified versions, and mouse over the "Expand Bottom Panel" button.
Minimal reproduction project (MRP)
N/A

Bisected to 6a7183119f1eed8871fe73a45880033cfb02f3d9, cc @timothyqiu


Project Editor needs an icon

There is no icon associated with the program.
From https://bugs.launchpad.net/nunit-project-editor/+bug/707249

(Apologies @CharliePoole - I've noticed after making the change this is assigned to yourself - hope you don't mind!)

No problem... it was getting stale.


upgrade fabric8.version to 2.2.193, includes:

Rename of PetSets to StatefulSets
CronJobs
Resolves breaking changes from the kubernetes model and client major version upgrade

@rhuss would you be able to give this a quick review when you get a min please?

I'll just rebase this PR too

lgtm

Thanks @rhuss @jimmidyson - what's the process now?  Can this be merged?  Once done I'll release and update fabric8-devops and add in our new CronJob for auto updates on fabric8 :)

LGTM [merge]


How to implement signout of a user.

https://firebase.google.com/docs/reference/android/com/google/firebase/auth/FirebaseAuth.html#signOut()
This should sign out the current user and clears it from the disk cache.

Do you mean this? https://firebase-php.readthedocs.io/en/latest/user-management.html#invalidate-user-sessions

Yes that works well for me. Thank you.
Will you ever add something exactly like signout() ? Something that will clear the cache?

What cache do you mean? The SDK doesn‘t cache  user sessions, and we wouldn‘t be able to clear caches on client devices like in Android apps or web apps.
In the scope of the SDK we can only make sure that an ID token that has been used previously cannot be used for authentication again.
Did I misunderstand what you mean?

Confirmed firebase signout does exactly this - "deletes the access token used by Firebase to confirm the users' identity".
Thanks for clearing that the SDK  doesn‘t cache user session.
The session storage should be handled by me https://firebase.google.com/docs/auth/admin/manage-cookies#sign_out
That clears up the issue. Closing this PR.


Do not suppress non-recoverable exceptions

There are a few places where Aleph does
(try
  ...
  (catch Throwable e
     ...))

which is not desirable in case of such errors like OutOfMemoryError and ThreadDeath and more. Netty does the same, here is the discussion to improve this when implementing Netty 5. At least we can try to not to do even more harm by improving our own try/catch blocks.
I suggest to re-throw JVM fatal errors, i.e. https://github.com/reactor/reactor-core/blob/f32944fdd10dfc4dc97fd21453b626d77b2856d9/reactor-core/src/main/java/reactor/core/Exceptions.java#L376-L386

Same story with Manifold.


Add a prop for iOS to display the keyboard without user input

Resolves the request in https://github.com/alinz/react-native-webview-bridge/issues/120

@amsul thank you!


[SPARK-10537][ML] document LIBSVM source options in public API doc and some minor improvements

We should document options in public API doc. Otherwise, it is hard to find out the options without looking at the code. I tried to make DefaultSource private and put the documentation to package doc. However, since then there exists no public class under source.libsvm, the Java package doc doesn't show up in the generated html file (http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4492654). So I put the doc to DefaultSource instead. There are several minor updates in this PR:

Do vectorType == "sparse" only once.
Update hashCode and equals.
Remove inherited doc.
Delete temp dir in afterAll.

@Lewuathe

Merged build triggered.

Merged build started.

Test build #42270 has started for   PR 8699 at commit b7006cd.

Test build #42270 has finished for   PR 8699 at commit b7006cd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42270/
Test PASSed.

Merged build finished. Test PASSed.

Merging this into master.


Finish work on checking of too broad local imports outside of unit tests

That's all of them.
Will enable the check once this and https://github.com/dlang/phobos/pull/4513 are pulled.

Auto-merge toggled on

Windows is failing :/

Not surprised; one sec

Should be good now


allow registering special pre/post-dispatch functions that can work on shared/event data on trigger

Shared state removed in https://github.com/Avokadoen/ecez/commit/98ccd72ae80e0d427460d3c4dade1197eb89337e


fix: changing current-version to expected-version

This PR shows the expected version of golangci-lint you need to run make lint
It was showing the current version earlier.

Signed-off-by: rajatgupta24<EMAIL_ADDRESS>

/ok-to-test

/lgtm


Edit Type codes for renaming Pokemon

Short Description
Option to edit the type codes of Pokemon according to personal preference
Possible solution
Something like this in the NicknamePokemon Task:
{
"type": "NicknamePokemon",
"config": {
"enabled": true,
"nickname_above_iv": 0.8,
"nickname_above_cp": 1500,
"nickname_template": "{iv_pct}-{attack_code}",
"nickname_wait_min": 3,
"nickname_wait_max": 5,
"type_codes":[
Bug: 'Bu'
Dark: 'Da'
Dragon: 'Dr'
Electric: 'Ele'
Fairy: 'Fy'
Fighting: 'Fg'
Fire: 'Fi'
Flying: 'Fl'
Ghost: 'Gh'
Grass: 'Gr'
Ground: 'Go'
Ice: 'I'
Normal: 'No'
Poison: 'Po'
Psychic: 'Py'
Rock: 'Ro'
Steel: 'St'
Water: 'Wa'
]
}
},
How it would help others
Easier to remember your own preferences, rather than keep checking the list specified in the documentation.
Additional request: Please let me know the file (and line number if possible) which I can edit to manually change the codes for now.

Ok, that's a config edit, but where does the code support this?

@Gobberwart It's a feature request :)

You can edit the type codes yourself here.
I wouldn't recommend using more than one letter though, because that would break most of the attack_code templates.

Don't the attack code templates use the same type_to_one_char_map array?

Yes, but all limited to one character.

I'd be glad to have a go at modifying that to include multiple characters for nicknames and attacks myself.
Any chance you could add the "Hacktoberfest" label to the issue please?


METRON-1489: Retrofit UI tests to run reliably

Contributor Comments
This Pull Request includes work started by @iraghumitra on his branch e2e-using-await-1. In addition to the asyn/await work he did, I added protractor-flake in order to re-run failing tests to ensure they are actual failures and not the result of flakey tests.
In order to test locally, be sure to install protractor-flake before running the e2e tests. This is done by running npm install inside of the metron-alerts directory.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[x] Have you written or updated unit tests and or integration tests to verify your changes?

[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

@sardell This is great to see - we may get our e2e tests running reliably as part of our build yet! In your intro notes, you mention doing an npm install to get the protractor-flake package installed. I believe we have Maven commands that handle installing these packages during the e2e test build. I think it's fine to sort out how we'll run the e2e tests in context of the full Metron build in a follow-on PR, but for this PR I think we should get that manual step to work consistently with how we install the other packages.
Small tip on Jira and PR titles - the community is likely not going to care or know about private QE environments (regardless of them being appreciative of those external efforts :) ). It's probably better to describe this Jira/PR as getting it stable to run as part of a daily Travis build, or something along those lines.

Maybe I am wrong, but I thought these tests used to run headless.  It looks to me that these are running "headful" now. :)
Either way, can these tests run headless or is there a major hurdle stopping us from doing that?

@nickwallen , in order to get past the following error you are seeing..
<snip>
[13:44:09] E/launcher - All configured authentication methods failed
[13:44:09] E/launcher - Error: All configured authentication methods failed
    at tryNextAuth (/Users/nallen/tmp/metron-pr1004/metron-interface/metron-alerts/node_modules/ssh2/lib/client.js:380:17)
    at SSH2Stream.onUSERAUTH_FAILURE (/Users/nallen/tmp/metron-pr1004/metron-interface/metron-alerts/node_modules/ssh2/lib/client.js:591:5)
    at SSH2Stream.emit (events.js:160:13)
    at parsePacket (/Users/nallen/tmp/metron-pr1004/metron-interface/metron-alerts/node_modules/ssh2-streams/lib/ssh.js:3929:10)
    at SSH2Stream._transform (/Users/nallen/tmp/metron-pr1004/metron-interface/metron-alerts/node_modules/ssh2-streams/lib/ssh.js:669:13)
    at SSH2Stream.Transform._read (_stream_transform.js:185:10)
    at SSH2Stream._read (/Users/nallen/tmp/metron-pr1004/metron-interface/metron-alerts/node_modules/ssh2-streams/lib/ssh.js:251:15)
    at SSH2Stream.Transform._write (_stream_transform.js:173:12)
    at doWrite (_stream_writable.js:407:12)
    at writeOrBuffer (_stream_writable.js:393:5)
[13:44:09] E/launcher - Process exited with error code 199

The error you are seeing is because of the ssh2 module which authenticates to the vagrant node to do cleanup tasks. This needs to be fixed.
As a workaround, you can do the following in (metron-interface/metron-alerts/e2e/utils/clean_metron_update_table.ts) i.e. https://github.com/apache/metron/pull/1004/files#diff-2cc98b255ddf3a954ad22dfa2b5545fb
+        resolve();
+        //cleanupTable(resolve, reject);

i.e. you need to uncomment the resolve() function and comment out  cleanupTable().

@nickwallen This work is ready on my end. I'm happy with where I'm at since addressing the feedback given by others here. The automated retries are to be expected and means protractor-flake is doing its job.

Please fix the formatting issue with the README.  I have mentioned in another thread, but you might have missed it.

Re-running Travis.

@sardell Should the topologies be stopped in the development environment when running the tests?      Does that impact the tests at all?

The first time I ran against a development environment where the topologies were running and so new data (outside the e2e tests) was hitting the search indices.  I ran the e2e tests and had quite a few failures.
Then I stopped the topologies and since then either all tests pass on the first try or a couple fail and the automated retry kicks in which leads to eventual success.
I am just not sure if that is coincidence or if we need to update the README so that everyone knows to stop the topologies when running these tests.

@nickwallen I wasn't able to reproduce the failure you experienced, but I added a note to the README stating the parsers will sometimes cause failures for users.

+1 Thanks for all the hard work on this one.  I know this was a battle to get it over the finish line.
I will get this merged once the CI build completes.


Tests failing on Ubuntu 20.04 (focal) with python 3.8.2

I'm trying to package pyfakefs for Ubuntu focal and the build on launchpad fails. I have reproduced the same error on a Virtual Box Ubuntu: a bunch of python3 related packages were already installed for another package (debhelper, dh-python, python3-all, python3-setuptools, tox, python3-pytest, python3-pytest-cov), so I just git cloned the repo (but I also tested with the latest release) and in master branch, ran pytest-3.
I've pasted the results here.
You can check the build log, that contains the same tests errors here (quite at bottom of the page).
Environment
nico@xubuntu2004:~/dev/pyfakefs-4.1.0$ python -c "import platform; print(platform.platform())"
Linux-5.4.0-42-generic-x86_64-with-glibc2.29
nico@xubuntu2004:~/dev/pyfakefs-4.1.0$ python -c "import sys; print('Python', sys.version)"
Python 3.8.2 (default, Jul 16 2020, 14:00:26)
[GCC 9.3.0]
nico@xubuntu2004:~/dev/pyfakefs-4.1.0$ python -c "from pyfakefs.fake_filesystem import __version__; print('pyfakefs', __version__)"
pyfakefs 4.1.0
nico@xubuntu2004:~/dev/pyfakefs-4.1.0$

Sorry, seem to have missed this issue... All failing tests don't find the fs fixture provided by pyfakefs -- pyfakefs seems not to be installed properly. Can you please show how you are invoking the tests?

Actually, this can probably be done in the tests - I will have a look at this.

@nicolashainaux - this shall be fixed in master, can you test this with master? If it works, I will probably make a new release.

Hello,
Sorry for the delay, I wasn't expecting such a quick answer and was pretty busy too. Thank you for this very quick answer!!
So, I've tested on the virtual machine, I get much better results:
$ pytest-3
============================================================================================================ test session starts =============================================================================================================
platform linux -- Python 3.8.2, pytest-4.6.9, py-1.8.1, pluggy-0.13.0
rootdir: /home/nico/dev/pyfakefs
plugins: cov-2.8.1
collected 1955 items

pyfakefs/pytest_tests/pytest_check_failed_plugin_test.py s                                                                                [  0%]
pyfakefs/pytest_tests/pytest_fixture_param_test.py x..                                                                                [  0%]
pyfakefs/pytest_tests/pytest_fixture_test.py x..                                                                                [  0%]
pyfakefs/pytest_tests/pytest_plugin_test.py ...                                                                                [  0%]
pyfakefs/tests/dynamic_patch_test.py .....                                                                                [  0%]
pyfakefs/tests/example_test.py .......s                                                                                [  1%]
pyfakefs/tests/fake_filesystem_glob_test.py .........                                                                                [  1%]
pyfakefs/tests/fake_filesystem_shutil_test.py ...............s...sssssssssssssssssssss...........sssssssssss                                                                                [  4%]
pyfakefs/tests/fake_filesystem_test.py .........................................................................................................................................................................s..................... [ 14%]
......................................................                                                                                [ 17%]
pyfakefs/tests/fake_filesystem_unittest_test.py .....................x.....x..................                                                                                [ 19%]
pyfakefs/tests/fake_filesystem_vs_real_test.py ...........................                                                                                [ 21%]
pyfakefs/tests/fake_open_test.py .......................................................................sssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss........ssssssss..........ssssssssss.......sssssss..... [ 31%]
sssss.....sss..ss.....sssss..................ssssssssssssssssss                                                                                [ 34%]
pyfakefs/tests/fake_os_test.py ....................................................................................................................................................................................................... [ 44%]
............................................................................ssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss [ 56%]
sssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssssss...................................................................................ssssssssssssssssssssssssss [ 68%]
sssssssssssssssssssssssssssssssssssssssssssssssssssssssss...................s...................................s......sssssssssssssssssssssssssssssssssssssssssssssssss..........ssssssssss......................................ssss [ 79%]
ssssssssss............ssssssssssssss............ssssssssssssss............ssssssssssssss.......sss                                                                                [ 84%]
pyfakefs/tests/fake_pathlib_test.py ....s.ssssssssssssss.s......ssssssss...........s.sss...sssssssssssssssssss...s..................ssssssssssssssssssssss.....................................sssssssssssssssssssssssssssssssssssss.. [ 94%]
...                                                                                [ 94%]
pyfakefs/tests/fake_stat_time_test.py .......sssssss........ssssssss.......sssssss........ssssssss.....sssss......ssssss                                                                                [ 99%]
pyfakefs/tests/fake_tempfile_test.py ........                                                                                [ 99%]
pyfakefs/tests/mox3_stubout_test.py .........                                                                                [100%]

============================================================================================ 1160 passed, 791 skipped, 4 xfailed in 21.71 seconds ============================================================================================
nico@xubuntu2004:~/dev/pyfakefs $

The tests end in green, so I guess this is OK. I don't know what "xfailed" are about, though.
I'm sending this to launchpad to check it works there too. I'll tell soon.

xfailed are tests that are expected to fail. If that works, you probably would need a new release, correct?

Hello, this seems to work fine. I could upload to launchpad and the build succeeded there, so I could add the PPA to my virtual machine and sudo apt install python3-pyfakefs correctly.
I needed to package pyfakefs for Ubuntu to be able to build another package that relies on pyfakefs for the tests. To get it quickly working, I've created a PPA. So, as it is, I do not need a new official release. Well, if anyone would like to use it, it would be more practical to match an official version, but technically this is not required at all. Currently, it shows up as 4.1.0-0ubuntu2, what means "version 4.1.0 that does not originate from a debian package, but contains the necessary modifications to be released for Ubuntu (2d version)".
Actually, I will need to test if my package does work fine with my tests for the other project. It should :smile:
If the package can make its way to the official repositories, then probably a new release would be necessary. But getting to the official repositories is a longer process. Also, I think it cannot be available for the current Ubuntu version, it can only be available for the next one, in the best case. That would be actually very good and the best solution for me. Maybe I'll try to initiate it. The fact that it could be built for a PPA is (in my opinion) already a good thing: it means that the minimal work to package it is already done and OK.
Many thanks for your help and quick answers!!

Ok, thank you - in this case we will wait with a release until some more changes accumulate. Having pyfakefs in some Ubuntu release would be nice - thanks for considering this!