Add await method to Dask collections

Fixes #4900

@jcrist you might have thoughts here

Merging tomorrow if there are no comments here.

I don't think collections should be awaitable at all. Collections define operations that generally aren't scheduled at all, and the standard methods (compute, persist, etc...), along with the special distributed methods (wait, as_completed) define computations.
I could see an argument for something like the following working though:
# Wait until all pending futures in the awaited collection are completed
persisted = await collection.persist()

I also thought about having await only call wait, but I couldn't come up with a situation where I wouldn't want the persist call in there as well, so I thought it best to include it.

So I guess turning that around a bit, what is the value to dropping the persist call?  Are there situations where we're going to want those two actions to be separable?

I think it's more of a matter of being explicit - it's not clear to me what awaiting a collection would do.
# Does this compute? (my first guess, especially since await
# is a function from `Awaitable` to the awaited result)
x2 = await x

When awaiting a persist operation it's easy to see what's going on:
# From the code alone it can be inferred that this awaits until persist is done,
# even for people not familiar with dask
x2 = await x.persist()

OK, I've removed the auto-persist for now.  It's easier to add it later than to remove it.

@jcrist, could you please give this another look?

Fine by me

Thanks 🙂


Centered Some Content on Save nature Page

Pull Request: Centered content on Save Nature page
Fixes: #773
Summary of Changes:

Centered the text on the Save Nature page.
Adjusted CSS styles to ensure responsiveness.

Screenshots:
Before:

After:

@AjayAchugatla
Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor.
Great contribution to HACKTOBERFEST'24! 🎉


Variable names in v-for mess up formatting

Using v2.0.12
Here is an example

It seems that type is reserved in the Language server and using it as a variable messes up coloring and formatting.
This is code migrated from Vue 2 with Vetur and it all worked as expected.

Duplicate of #520


Reduce frequency of global UBO changes

Prereqs:

[x] https://github.com/ppy/osu-framework/pull/6186

Since the pre-req PR adds a common DrawVertices() method, we can now update the global UBO as late as possible - right before vertices need to be drawn.
The easiest way to see the difference is by using the GL renderer and noticing the reduction in the Draw.UniformUpl statistic. In TestSceneTextFlow it reduces uploads from 54 -> 28. This may lead to a minor performance increase.
The Veldrid implementation does its own similar late-upload, which could be removed but isn't done in this PR.
In general though, this should slightly increase performance (not benchmarked) just from reducing struct copies.

Can't see any issues in platform testing so this is probably ok to go through with although I would appreciate addressing the reviews above.


Support for HTTPS backends

Description
Apache APISIX Ingress Controller does not seem to have support for HTTPS backends.
I noticed this when I wanted to expose Vault Web-UI via Ingress.
Other ingress controllers support this feature out-of-the-box but for APISIX ingress controller, I did not find a way to configure this.
Places I looked at:
https://apisix.apache.org/docs/ingress-controller/references/apisix_route_v2/
https://apisix.apache.org/docs/ingress-controller/concepts/apisix_route/
I also did some googeling and found this:
https://github.com/apache/apisix/discussions/6771
But this is unanswered as of today.
I think this is a very important feature and in case APISIX ingress controller actually does not support it yet, I would like to request this feature :)

In fact, we have had this feature for a long time. Through the ApisixUpstream resource, you can set the schema of upstream/backends to support http/https/grpc/grpcs and more.
ref:
https://github.com/apache/apisix-ingress-controller/blob/e809cfbaaad6f6c3cbd23f5ec8e93bc1d87f543d/test/e2e/suite-features/scheme.go#L138

Ah, thank you very much :)
This works for me now:
apiVersion: apisix.apache.org/v2
kind: ApisixRoute
metadata:
  name: vault
  namespace: svc-vault
spec:
  http:
  - name: vault
    match:
      hosts:
      - vault.${DOMAIN}
      paths:
      - /*
    backends:
       - serviceName: vault-active
         servicePort: 8200
---
apiVersion: apisix.apache.org/v2
kind: ApisixUpstream
metadata:
  name: vault-active
  namespace: svc-vault
spec:
  scheme: https
---
apiVersion: apisix.apache.org/v2
kind: ApisixTls
metadata:
  name: vault
  namespace: svc-vault
spec:
  hosts:
  - vault.${DOMAIN}
  secret:
    name: vault-ssl-cert
    namespace: ingress-apisix


Update Composer dependencies (2020-11-28-00-11)

Visual regression test passed!
View the visual regression test report


create user failed

Hi All,
Thanks for that great tool, I loved it, but I do have one issue, so I have secured my openvpn private key ca.key with a passphrase, and when I try to create a new account from the ovpn-admin it failed due to missing passphrase for private key, is there is a way I can pass this ?
INFO[0231] <IP_ADDRESS>:40148 /api/user/create
DEBU[0231] cd /etc/openvpn/easy-rsa/ && easyrsa build-client-full ibrahim nopass 1>/dev/null
Enter pass phrase for /etc/openvpn/easy-rsa/pki/private/ca.key:
DEBU[0232] exit status 1 : -----
Using configuration from /etc/openvpn/easy-rsa/pki/easy-rsa-1249772.3C7LMO/tmp.4wNFVQ
Could not read CA private key from /etc/openvpn/easy-rsa/pki/private/ca.key
40F796A6C67F0000:error:1608010C:STORE routines:ossl_store_handle_load_result:unsupported:../crypto/store/store_result.c:151:
40F796A6C67F0000:error:1C800064:Provider routines:ossl_cipher_unpadblock:bad decrypt:../providers/implementations/ciphers/ciphercommon_block.c:124:
40F796A6C67F0000:error:11800074:PKCS12 routines:PKCS12_pbe_crypt_ex:pkcs12 cipherfinal error:../crypto/pkcs12/p12_decr.c:86:empty password

Easy-RSA error:

signing failed (openssl output above may have more detail)

Easy-RSA error:

Failed to sign 'ibrahim'

this possibility is not provided


Remove restrictions on ONNXPow

Copy from https://github.com/Xilinx/onnx-mlir/pull/99

Adding  @franciscofd as a request from Luis


Any binary for macOS?

I can not find any binary for macOS, but I am lazy to build it myself,
can you build one for macOS?

brew formula was release yesterday.

brew formula was released yesterday.

How can I install with homebrew?
brew install onefetch
Updating Homebrew...
Error: No available formula with the name "onefetch"
==> Searching for a previously deleted formula (in the last month)...
Warning: homebrew/core is shallow clone. To get complete history run:
  git -C "$(brew --repo homebrew/core)" fetch --unshallow

Error: No previously deleted formula found.
==> Searching for similarly named formulae...
Error: No similarly named formulae found.
==> Searching taps...
==> Searching taps on GitHub...
Error: No formulae found in taps.

did you
brew update

I works now by running brew update and install it with brew. Thank you for the help.

yw. close the issue =)

Thanks for the help @butuzov
I wasn't even aware a onefetch was pushed to Homebrew...
Unfortunately, this version is a little updated.

@erikgaal  Thanks a lot for submitting onefetch to HomeBrew, could you maybe submit 1.7.0?
I don't have MacOs, unfortunately...

Sure, @o2sh!

https://github.com/Homebrew/homebrew-core/pull/45975

I have tested via brew today and it works!
brew install onefetch

I think the update could come with some README updates specifying its use.

Sorry doc it's aready there https://github.com/o2sh/onefetch/wiki/Installation#macos-homebrew
Issue can be closed.


[Bug Report] Binding of "offline" for ClientOptions

Bug description
I am using swift bindings.
Previously, during InitializeIotaWallet(),  I managed to bind "offline" to clientoptions and send to message handler. Now it is failing.
Rust version
Which version of Rust are you running?

Rust version:

Version
Which version of the library are you using?
dev branch latest
Hardware specification
What hardware are you using?

Operating system:
RAM:
Cores:
Device:

Steps To reproduce the bug
The following json is sent to InitializeIotaWallet.
{
  "storagePath": "./walletdb",
  "coinType": 4219,
  "secretManager": {
    "Stronghold": {
      "password": "password",
      "snapshotPath": "./mystronghold"
    }
  },
  "clientOptions": {
    "nodes": [
      "https://api.testnet.shimmer.network"
    ],
    "localPow": true,
    "fallbackToLocalPow": true,
    "offline": true
  }
}

Errors
Error("unknown field offline", line: 1, column: 253)

We updated to the latest iota.rs version and it got removed there https://github.com/iotaledger/iota.rs/blob/develop/CHANGELOG.md#removed since it's not needed anymore, you can just provide no node at all and still generate addresses/sign transactions


Error 'file or directory does not exist: 'ui-profiler-results' while benchmarking Execution time

Description
While benchmarking Execution time, the tests run successfully but the results are not stored as expected. I get the error '- file or directory does not exist: 'ui-profiler-results' - and the results directory is not created at all.
Reproduce

Select benchmark - Execution Time
Select scenario - Open Menu
Click start
The benchmark test runs through without any issues; the box plot is displayed as expected
However, there are no .profile.json result files on the left
Terminal has the following error - file or directory does not exist: 'ui-profiler-results'

Expected behavior
The folder ui-profiler-results is created as needed
Context

Browser and version: Chrome 110
JupyterLab version: 3.6.1
ui-profiler-version: 0.1.6

Here is a screenshot of the error in terminal with more details -

The results directory should be created by this call:
https://github.com/jupyterlab/ui-profiler/blob/b351f8f0edd5da9281b398e660efd4bbe3f8c5e1/src/ui.tsx#L615-L617
however if user deletes the directory after it will be created they will see an error as above. If you did not delete the directory in the meantime that would be an interesting bug and it would be helpful to see the server long on the initial save that was supposed to create the directory.

Interestingly, I had the issue occur in both scenarios - the files were not created in the existing ui-profiler-results folder. So, I deleted the existing folder to see if a new folder would be created and still had the issue.
The screenshot I shared previously was taken after deleting the folder.


Cu 86bwch8pa publishers records page alonzo pineau

This pull request concern the publishers records page
I started the branch with the old main-next branch. As it has been merged into main, there is a lot of conflicts
Could you help me with this @rhahao ?
Here are the only files I’ve created/modified :
src/v3/App.tsx
src/v3/features/congregation/publisher_records_detail/PublisherDetailCard.tsx
src/v3/features/congregation/publisher_records/StatisticsPanel.tsx
src/v3/features/congregation/publisher_records/index.types.tsx
src/v3/features/congregation/publisher_records_detail/ServiceYearCard.tsx
src/v3/pages/congregation/publisher_records_detail/index.tsx
src/v3/features/congregation/publisher_records_detail/index.styles.tsx
src/v3/components/switch/index.tsx
src/v3/features/meetings/weekly_schedules/midweekMeeting.tsx
src/v3/pages/congregation/publisher_records/index.tsx
src/v3/features/congregation/publisher_records/GroupPublisherSelector.tsx
src/v3/features/congregation/publisher_records/PublisherCard.tsx
src/v3/features/congregation/publisher_records/Wrappers.tsx
src/v3/features/congregation/publisher_records/index.styles.tsx

Task linked: CU-86bwch8pa Publishers records page

Thank you @Al11o. I’ll take a look at this.


refactoring

Coverage increased (+0.2%) to 94.082% when pulling 81fdbf03fa8536021f4a1d9680594a01d99e1368 on refactoring into 1a05e5b0b6660cb37174d2e204d7d3f8a132c3ed on master.


chore: Update CI to test in ubuntu

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

closing in favor of #717


Add Image.srcset property

Add Image.srcset property

This issue was imported from Google Moderator
Moderator votes: +8
Issue added by trigger_af on 2013-03-27
To vote this issue up or down, simply include +1 or -1 in your comment.

Already added at http://caniuse.com/#feat=srcset


Text problem on web page

Text problem on web page

@chongbo2013
Can you provide flutter doctor -v and when do you see this behavior ? Does the symbol go away after few seconds or stays as is ?


machine-learning-module -- add somewhere ?

This is a machine learning module I found here:

http://www.dcs.gla.ac.uk/~girolami/Machine_Learning_Module_2006/week_2/Lectures/wk_2_lect_2.pdf

None of this material is mine, it has all been created by Professor. M. A .Girolami.
This is hands down the best machine-learning tutorials I have found on the web, and I was afraid
the university link would be taken down, so now its on github.

i hope you enjoy this as much as i did.

https://github.com/josephmisiti/machine-learning-module

Closed by https://github.com/hangtwenty/dive-into-machine-learning/commit/b95f41e1c5a847a69c7956dc3c6982b694b7905c


Fix grammar -- it's -> its

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: lgirvin sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@lgirvin : Thanks for your contribution! The author, @jeffpatt24, has been notified to review your proposed change.

merging typo fix
@lgirvin Thanks!


update to use dispose instead of deprecated config.unobserve

Deprecation Cop warns "Config::unobserve no longer does anything. Call .dispose() on the object returned by Config::observe instead." Updated to current API.
Resolves #24

@awatts thanks for contributing! Fix merged and realeased in 1.4.1.

Happy to help. Looks like I'm getting a couple new deprecation errors now with 1.4.1, so I might look into those and make another PR or two if no one beats me to them.

@awatts Strange, because I'm not getting any deprecation warnings on 1.4.1?

@badray Hmm. Nevermind. I think one of my computers was just being dumb, because I've tried it on two others now and they have zero deprecation warnings.


Strider unable to process query due to constraints for Workflow A Advanced

Query: here

I think the strider is unhappy with constraints attribute.

Should this be some 400 level error instead?

That is what I thought so too but even after using the json file as it is, I am still running into this error and the error is 500 (internal sever error). Will keep trying.

Let me know incase you test and do not get any errors.. Thanks

Decision: Constraint handling should be Strider's purview. Patrick may make constraint applicator a separate library.

Strider completes this query now, although there are 0 results.


MudRangeSlider | .NET MAUI

The range slider doesn't work in a .NET MAUI Blazor App. The Min and Max Value are somehow on the opposite sites.
Tested with the following code from :
https://codebeam-mudextensions.pages.dev/mudrangeslider

Im not experienced with MAUI, so don't have an idea what would be gone wrong. If you have more info, we will look deeper.


Incorrect << behavior with strings

Code:
/obj/item/weapon/circuitboard/vendor/proc/set_type(typepath, mob/user)
		build_path = typepath
		name = "circuit board ([names_paths[build_path]] Vendor)"
		user << "You set the board to Getmore Chocolate Corp."

Normally this should output the message to the user mob. But because the proc is called in New() and there's no sanity checking, user is null. Instead it causes:
Exception Occured: Invalid bit shift left operation on DreamValue(DreamObject, null) and DreamValue(String, "You set the board to Getmore Chocolate Corp.")
=DM StackTrace=
   /obj/item/weapon/circuitboard/vendor/set_type(...)
   /obj/machinery/vending/snack/New(...)
   <InitDreamObject DreamObject(/obj/machinery/vending/snack)>

=C# StackTrace=
System.Exception: Invalid bit shift left operation on DreamValue(DreamObject, null) and DreamValue(String, "You set the board to Getmore Chocolate Corp.")
   at OpenDreamRuntime.Procs.DMOpcodeHandlers.BitShiftLeft(DMProcState state) in C:\Users\main\Documents\GitHub\OpenDream\OpenDream\OpenDreamRuntime\Procs\DMOpcodeHandlers.cs:line 635
   at OpenDreamRuntime.Procs.DMProcState.InternalResume() in C:\Users\main\Documents\GitHub\OpenDream\OpenDream\OpenDreamRuntime\Procs\DMProc.cs:line 179
   at OpenDreamRuntime.ProcState.Resume() in C:\Users\main\Documents\GitHub\OpenDream\OpenDream\OpenDreamRuntime\DreamThread.cs:line 76

Note that user is null here.

For reference, in BYOND this silently fails with no runtime.

Fixed in f2b6bcea087d8d6daffbe4a523d6f8271ab4726c.


Get design approval for AMQP Body type approach

We have tentative approval for the medium term strategy of exposing via extension methods. With the introduction of the AmqpAnnotatedMessage type, this will morph into exposing these other body types directly on this type.


Increase the Hunger Games batch size to something bigger

What

Increase the Hunger Games batch size to something bigger
Ideally get rid of the get more ("Continue") button by loading a new batch 2 products before the end of the current batch.

Currently we download 3 questions (and 3 products), and then start the HG, and after answer 3 we land on the "continue" page.

Increase the Hunger Games batch size to something bigger

We could download much more questions (how slower would that be?) but probably not much more products (e.g. 100) before asking the first question.

if robotoff could provide some fields (e.g. the product name) in the question, we may not have to download the products at all in most cases
=> would that be possible in the robotoff call to add some product fields?
if we start with 10 questions instead of 3, the same "continue?" button will appear, but just later. And we would have the same download of the next questions and products.
=> wouldn't that be more user-friendly to rename "continue" as "next 10 questions"?

Ideally get rid of the get more ("Continue") button by loading a new batch 2 products before the end of the current batch.

We need to provide a clear way to escape the forever question loop, like a button on top (the "back" arrow would work but is a bit lazy).
In the forever question loop, we could download 100 questions and download the next 10 products in advance, while the questions are being answered.

My (temporary) solution:

explicitly show a "loading the next n questions"
start with 3 questions, then by batch of 10 questions
rename the "continue" button as "next 10 questions"

And then we'll see.

I think that the new Hunger Games experience is now very smooth as it is: starts with 3 questions (small delay to load them), instant answers, then if the user wants 10 more questions still a small delay to load them, after a click. Makes sense.
Feel free to reopen and to fine-tune the issue if relevant.


fix(addon): Fix src_user field contained destination user

Description
Fix source user field alias and add status field alias.
Motivation and Context
Source user field was empty because it had the wrong field aliased to it.
How Has This Been Tested?
Tested on local environment.
Screenshots (if appropriate)
Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes if appropriate.
[ ] All new and existing tests passed.

Fix has been backported to Addon version 6.6.2. You can now get the fix in Addon 6.6.2 or 7.0.0.


BaseOptionModel#getShortName should not take watermark into account

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md

I think this is here for reason. The table on website is not readable with long keys. Please try to preview website locally against this branch to see how it looks

@oscerd @bedlaj
Thanks for your feedback. I was not aware of that visualization issue. Just noticed that as I was looking for camel.main.durationMaxIdleSeconds configuration option on the following page:
https://camel.apache.org/components/latest/others/main.html
And Chrome claimed me that option would not exist, so how I came across this issue. If I had searched for camel.main.durationMaxIdle Seconds then I would find it which is a bit wired.
So I'm abandoning this PR.
Thanks


Add an npmignore file to all packages

Adds an npmignore file to all of the packages since the root one does not apply to npm publishing anymore

@ljharb i considered this, but thought that they might need to diverge over time. Thoughts?

That's fair; but it'd be easy to copy it when a need arose. Not a huge deal either way.


[Bug]: Docker Compose doesn't pull latest codebase

Error Message and Logs
Deployment process is not using latest codebase if Docker Compose is in use. It works if Dockerfile is used. Not even force deploy with clear cache works.
Steps to Reproduce

Create resource with Docker Compose
Initial deployment will use latest code
Push new changes to the codebase
New deployment will trigger and pass, but codebase will be old one

Example Repository URL
No response
Coolify Version
v4.0.0-beta.360
Are you using Coolify Cloud?
Yes (Coolify Cloud)
Operating System and Version (self-hosted)
No response
Additional Information
If Dockerfile is being used then everything works fine, new codebase is being used in new deployment. If Docker Compose is being used, old codebase is in use.

@andrija29 can you link your compose please, are you using volume mounts in the compose?
if this is just an image in the compose, then it will just reuse the same tag thats in the local registry if its there, so you need to add a pull_policy to the compose or add force=true to webhookurl

@andrija29 youre overwriting your container with a volume mount, remove it its not needed

@andrija29 youre overwriting your container with a volume mount, remove it its not needed

This was the issue. Thank you!


Update ListView.md

The IViewField property 'minWidth' is incorrectly labelled as 'maxWidth', so it appears that there are two 'maxWidth' properties.

Q
A

Bug fix?
[x ]

New feature?
[ ]

New sample?
[ ]

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
Updated the 'minWidth' property to reflect the proper name.

Codecov Report

Merging #480 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #480   +/-   ##
=======================================
  Coverage   73.31%   73.31%
=======================================
  Files          18       18
  Lines         802      802
  Branches      164      164
=======================================
  Hits          588      588
  Misses        164      164
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf8856...90a090d. Read the comment docs.

Thank you @LastGunslinger for the update!


SmartThings Platform Change - no Groovy apps

I have been using this InfluxDB logger app for a long time and find it immensely useful and reliable.  With Samsung's upcoming platform change, SmartApps will be shut down on December 31, 2022.  Does anyone know of an alternate method for data logging?

+1 for this.
David's Logger has been the mainstay of my Grafana dashboards.
@codersaur I know you've not been active for a while - any plans to rewrite for the latest platform?

I was wondering why this wasn't working anymore. Thought it was related to a password change I made. Sad to see another good product died

While waiting for a more elegant solution to the InfluxDB-logger smartapp, I created a simple Python script which polls devices and write data to InfluxDB, similar to the obsolete groovy app.  It can run on many devices including Raspberry PI and does not require a web server.  However, it is not event-based so data updates are not real-time (polled instead).  It logs data for power, battery, and temperature.  Other measurements can be easily added if needed.  This Python script has been working well so far.  Happy to see my Grafana dashboards updating again.

If anyone is interested in the Python app, it can be found here:
SmartThings-InfluxDB-logger.
Feature just added to check health (online/offline) status, data is logged to InfluxDB only when device is online.  This makes it easier to detect offline devices on dashboards.


iOS bottom sheet is not available in the example

This screenshot is from readme but the bottom sheet is not available when running 0.4.0 example on iOS

Hope to be able to support UIAlertController.Style.actionSheet in iOS, should be BottomSheetDialog the Android platform.


UI: A11y: ChromeVox triggers error callback in demo app

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
master
Can you reproduce the issue with our latest release version?
N/A: no UI in v2.4.x
Can you reproduce the issue with the latest code from master?
yes
Are you using the demo app or your own custom app?
demo
What browser and OS are you using?
ChromeOS
What are the manifest and license server URIs?
N/A
What did you do?
Activate ChromeVox screen reader by pressing Ctrl-Alt-Z
What did you expect to happen?
No errors
What actually happened?
Although ChromeVox activates and works, somehow, one of our error handlers is triggered and we display the error "goog.require could not find: cvox.ApiImplementation" in the demo app.

This handler is being triggered:
  // Display uncaught exceptions.
  window.addEventListener('error', function(event) {
    shakaDemo.onError_(/** @type {!shaka.util.Error} */ (event.error));
  });


Use event delegation

Description
Instead of attaching a new root-level event listener for bubbling events
for every choices instance, use a simple event delegation script to
handle each event type.
Each event callback function already is coded as if it were fully
delegated, since the events are attached at the document level, so
no changes are needed to detect which element is being called.
Note that focus and blur event do not bubble, so they have been left as
they are.
Also note that the event delegation uses an IIFE purposely instead of ES6 modules, since the event list should be globally cached, and it doesn't make sense to instantiate a new scope for each instance (then we're back where we started!)
Motivation and Context
Using event delegation increase page speed, especially if there are many choices instances.
fix #643
How Has This Been Tested?
I ran the standard tests via npm test on macOS 10.13.6.
I also tested the local server manually to make sure I could still perform all operations.
This change's scope is limited to adding an event delegation script and the _addEventListeners and _removeEventListeners functions.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

The tests are failing for this PR, but it's because cypress fails to start. I can't think of any code changes here that would cause that. And funny enough I'm seeing a similar issue with cypress failing to start for a work project. Is there some larger issue with cypress going on?
Here's the relevant log output.

[22:15:14]  Verifying Cypress can run /home/travis/.cache/Cypress/3.1.5/Cypress [started]
[nodemon] 1.18.10
[nodemon] to restart at any time, enter rs
[nodemon] watching: .
[nodemon] starting npm run css:build
[22:15:15]  Verifying Cypress can run /home/travis/.cache/Cypress/3.1.5/Cypress [failed]
Cypress failed to start.

If you merge in latest master, the CI build should be fixed 👍

This PR attenuate some of performance issues we are having when a select has a lot of options.
Thanks!

If you merge in latest master, the CI build should be fixed 👍

I merged in master and the builds now pass. Thanks!

@jshjohnson any chance this PR can get a review? Thanks!

Thanks @bronzehedwick 👍

Awesome! :tada:

This fix is included in version 7.0.2 👍


update(userspace/libsinsp): support array-like types as state fields in thread infos, compatible with plugin API

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Follows up https://github.com/falcosecurity/libs/pull/1866 as part of https://github.com/falcosecurity/libs/issues/1712. This PR exposes complex types of state tables entries. The first use case is the two vector of strings contained in thread infos representing the cmdline args and the environment variables of the process.
This is achieved by representing array-like structures as maps with integer key and a value defined by the array's value. In this first use case, the value is represented by strings. Users of both the sinsp state API and the plugin API will see these as sub-tables (introduced in https://github.com/falcosecurity/libs/pull/1849) and will be able to perform any table operation on it. Unlike other map-like containers arrays will implement tables with a sparse key space, so users should be careful in using non-progressive index access when editing them.
The approach can scale to any level of nesting for other data structures (structs, arrays of structs, maps, maps of structs), and from my inspection should suffice for representing the majority of the state defined in libsinsp.
Which issue(s) this PR fixes:
Special notes for your reviewer:
/milestone 0.17.0
Does this PR introduce a user-facing change?:
update(userspace/libsinsp): support array-like types as state fields in thread infos, compatible with plugin API

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: f4f7a055ece08b7b799779cd943fdb0e94b6726f

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, incertum, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP,incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Revert "Revert "Revert "Migration to remove an org created in error"""

Reverts alphagov/panopticon#351
😱

Can't wait for tomorrows revert^4.

:truck: Caution, this vehicle is reverting.


Add CAN fixed pt support

Summary

Please refer to issue for PR scope
Changelist

Testing Done

Resolved Issues

Checklist
Please change [ ] to [x] when you are ready.

[ ] I have read and followed the code conventions detailed in README.md (This will save time for both you and the reviewer!).
[ ] If this pull request is longer then 500 lines, I have provided explicit justification in the summary above explaining why I cannot break this up into multiple pull requests (Small PR's are faster and less painful for everyone involved!).

Sending signed number from DCM to INV:

DCM side:

BMS side:


Fix head lang

Clarifies that g7:HEAD-LANG should only be used if all Text-type payloads with no g7:LANG substructure are in the same language.

mistakenly included too many files


Cwaread issue133

The solution for the issue #133 to skip a filepage seems to work for now, so I will merge this into the master branch, such that it can be incorporated in the next CRAN release of GGIR.

Codecov Report

Merging #140 into master will decrease coverage by 0.28%.
The diff coverage is 10.41%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   63.87%   63.58%   -0.29%
==========================================
  Files          55       55
  Lines        7155     7189      +34
==========================================
+ Hits         4570     4571       +1
- Misses       2585     2618      +33

Impacted Files
Coverage Δ

R/g.readaccfile.R
15.87% <2.38%> (-2.44%)
:arrow_down:

R/g.report.part2.R
59.55% <50%> (-0.45%)
:arrow_down:

R/g.getmeta.R
65.73% <75%> (-0.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0ee2f1...527a940. Read the comment docs.


File Organizer Script

Description
Auto organizing files - images, music, executables, documents
Type of issue

NOTE: These boxes can be checked using [X]

[x] Feature (New Script)

[ ] Bug

[ ] Documentation

Checklist:

[x] I have read the project guidelines.
[x] I have checked all the existing projects, before submitting a new project issue.
[x] I have checked previous issues to avoid duplicates.
[x] This issue will be meaningful for the project.

Please assign this to me 💯

Hey, can I work on this issue

Hey, can I work on this issue

It has been assigned already


Fix typos on word development and on some Brazilian Portuguese translations

A translation fix doesn't respect the capitalization of words.
The docs/ files are generated and shouldn't be modified manually, but it should work in this case.

Oh sorry, I didn’t about that. If you want I can force push commits without the doc changes or close this PR and create another one.

You can rebase the PR as you wish. Except for the uppercase issue, it should be fine because I think you modified the html as the generation would, it's just not a good idea to do that for more complex edits.

Thanks, I’ll make all those changes in about an hour or two.

Thanks, it would be nice to rebase all the commits to one or two meaningful ones (for clarity).

Wouldn't be better for you to use the squash option to merge them?
The squash merges all commits into one and lets you change its message as your liking.

I squashed them for you, sorry for the inconvenience.

I prefer to let people do it first because that's what I do myself when I'm done, I cleanup/clarify the commits. Thanks for the fixes.


Added article

Added article on How to send emails in C#/.NET using SMTP

Hi @pareek-narendra
Thank you for your PR.
The goal of the Awesome .NET Performance list is to gather resources focused on .NET Performance. The provided blog post does not focus on performance and hence I can not accept it.


Authorization model

This issue broadly covers all the work required to implement an authorization model in this CKAN extension.
Things to consider:

definition of roles and synchronisation of this info with the identity service
definition of institutions and working transparently with externally managed institutions
use of the info conveyed in the access token from an identity service login, e.g.

user role
linked institution(s)

Depends on #11

Note: the institutions aspect mentioned above will be addressed in ckanext-accesscontrol: https://github.com/SAEONData/ckanext-accesscontrol/issues/4


Long line in TOC messes leaderdot and pagenum

Asciidoctor-pdf:

The same in msword (and I believe latex does it too)

This requires diving deep into the internals of text handling in Prawn to implement. I don't have any plans of doing it myself. If someone would like to contribution this change, please feel free.

This is a duplicate of #1152. I now understand how this can be implemented.


No vendor/autoload.php file

Hi,
I havn't found the file'vendor/autoload.php'.
Did you update this project?
Can you update the home page?
Thanks.

@richardguancn you need to use composer (composer generated the autoload file)
https://github.com/WhichBrowser/Parser#how-to-install-it


[backport] Fix return type of division of csr_matrix and dense array for SciPy 1.11

Backport of #7906 by @asi1024

/test mini

Test failures are irrelevant.


⚠ Blade templates directly accessible

⚠ yesterday it was brought up that you can view blade templates in plain-text when accessing the files directly from your browser

this is not ideal. sage isn't the only theme affected by this — any wordpress theme that uses blade or twig (all timber themes) have the same problem because the views are publicly accessible:

while this PR only will only benefit apache users, the install docs will also be updated (see below) with instructions for nginx users. trellis is being updated to include preventing access to blade and twig files out of the box.
ref https://github.com/roots/trellis/pull/1075
ref https://github.com/roots/docs/pull/180
if you use a managed wordpress host, you'll need to reach out to their support team to ask them if they can make a similar change to their server config. i've asked kinsta if they'd be able to make this change globally and waiting to hear back.

rather than implementing this PR, we'll be adding this to sage:
https://github.com/roots/wp-blade-check

Would it make sense to block direct access to any PHP file within the theme folder? I've taken that approach on a number of sites in the past before using Sage.
I can't think of any legitimate reason you'd need to directly access a PHP file within the theme folder.
Doing so would simultaneously solve the plain-text blade issue as well as errors for files in the app folder and direct access to dependencies in the vendor folder.
On the topic of the vendor folder, should the composer.json file be blocked by htaccess too? I feel there's some risk involved in providing a list of dependencies that can be found within vendor.  You're giving them a list of packages they can start probing for weaknesses.

replaced w/ #2163


ValueError: too many values to unpack

Dear all,
I get the following error. Does anyone know how I can fix this?
This happens also with a freshly pulled template on an OsX yosemite macbook pro. I already tried to reinstall anaconda (python 3) as well as sphinx+sphinxcontrib-bibtex. It creates a LaTeX document and a presentation. Any help is highly appreciated.
If you need further information from me, please tell me. Thanks a lot!
Best, Robert
Waf: Leaving directory `/Users/rbirkelbach/Documents/econ-project-templates/bld'
Build failed
Traceback (most recent call last):
File "/Users/rbirkelbach/Documents/econ-project-templates/.mywaflib/waflib/Runner.py", line 287, in task_status
return tsk.runnable_status()
File "/Users/rbirkelbach/Documents/econ-project-templates/.mywaflib/waflib/Task.py", line 590, in runnable_status
new_sig = self.signature()
File "/Users/rbirkelbach/Documents/econ-project-templates/.mywaflib/waflib/Task.py", line 568, in signature
self.sig_implicit_deps()
File "/Users/rbirkelbach/Documents/econ-project-templates/.mywaflib/waflib/Task.py", line 759, in sig_implicit_deps
(nodes, names) = self.scan()
File "/Users/rbirkelbach/Documents/econ-project-templates/.mywaflib/waflib/extras/sphinx_build.py", line 37, in scan
msg, dummy, iterator = s.env.update(s.config, s.srcdir, s.doctreedir, s)
ValueError: too many values to unpack (expected 3)

Thanks. Had that before somewhere -- I probably upgraded Waf prematurely at some point and my sphinx builder is not compatible with that. I'll have a look at it tonight.

Should work again with the latest versions. Please re-open the ticket if it does not.

Many thanks, it works as expected! I highly appreciate the fast and kind support. Was it because some incompatible waf version?

Yes, I had updated Waf and did not check whether sphinx_build would still work.

For future reference: If you run into this because you updated Sphinx to 1.3.x in a project that had used Sphinx 1.2.x just:

update Waf by replacing waf.py and .mywaflib with their latest versions from these templates
adjust the contents of src/documentation/wscript with the latest version from these templates


support email verification

First step towards automated email verification.  Add a menu item which brings up and email to send the requester confirming the request.  Add a new status of CONFIRM_REQUEST.
Imported from trac ticket #76,  created by phelinek on 01-20-2014 at 17:13, last modified: 01-22-2014 at 17:04

Added a new menu item CONFIRM REQUESTER to pending requests and requests waiting for lead response.  This brings up an email to send the requester:
Dear ,
We received a request from you for an account at the GENI GPO Identity Provider, for use with GENI.
If this request came from you and you indeed intend to use GENI, please Reply. We will then process your request.
If you did not make this request or no longer want to use GENI, then you can simply ignore this request.
Thank you,
GENI Operations
Added a new request_status of CONFIRM_REQUESTER and a new status table for Account Requests Waiting for Requester Confirmation.
Trac comment by phelinek on 01-20-2014 at 17:14


Update multi extension

Description

Screencast

Checklist

[ ] I read the extension guidelines
[ ] I read the documentation about publishing
[ ] I ran npm run build and tested this distribution build in Raycast
[ ] I checked that files in the assets folder are used by the extension itself
[ ] I checked that assets used by the README are placed outside of the metadata folder

Set as draft until we release Multi to support this feature.

Shared feedback in Slack 🙂


.otioz files are playing and showing without audio in latest edit branch.

I understand it is work in progress, but thought you might want to know.

ALab .otioz file is not standard.  Closing.

There is some discussion about the ALab file here:
https://github.com/AcademySoftwareFoundation/OpenTimelineIO/issues/1665
I'm going to re-open this until the above is resolved.


Re organize horizontal links and make a box

need more tweaking with the lists to make it horizontal and make boxes

halfway there, now need to make some boxes

That issue has been fixed, after looking further in the problem and finding resources, I was able to maintain a horizontal navbar that floats so we good here


xdg-shells: make xdg_surface implementation handle inert objects

Original issue: https://github.com/WayfireWM/wayfire/issues/73

Not sure this is the right thing to do.

An xdg_surface must only be destroyed after its role object has been destroyed.

But it's not specified what happens if the wl-surface is destroyed before the xdg-surface.

Well, I'm open to other ideas to solve the problem. But the main reason for this crash was that ack_configure came after the destroy request, and I thought these kind of races are solved by inertness.

Hmm, how is it possible? If the client sends a destroy request, it can't send an ack_configure after without a use-after-free.

Maybe we just protocol error the client in this case?

bump

Hi, I've forgotten about this one. So, here's a backtrace: https://pastebin.com/6yhNkqca and here's a WAYLAND_DEBUG of the tool: https://pastebin.com/2Z6NUSz2
Looking at them again, I'm not so sure anymore what the correct way to fix this is.

@ammen99 Whats the status on this PR?

@panaman67 Please refrain from randomly pinging people. I appreciate the enthusiasm, but if you want to help adopt these PRs instead.

@panaman67 The status is "I don't know what the correct fix is".


Docker in Docker on managed nodes

I read the FAQ about the issues around docker in docker. Is there no bootstraps_arg feature in the node groups config to allow the inner container to communicate outside?

The node groups API provides very few options for customising the environment currently. It is not a limitation of the module but from AWS.
There are requests on the container team's roadmap for more flexibility. Like https://github.com/aws/containers-roadmap/issues/596 .

Custom userdata and launch template are now available for MNG. But so far, this module doesn't support. Please follow https://github.com/terraform-aws-modules/terraform-aws-eks/issues/979 to track this feature.
Closing.


dev: cleaning chain_spec and mock files

We currently have a lot of hardcoded storage keys in the chain_spec.rs file (located here). This can be cleaned up in a similar fashion to what we have in the mock.rs file (located here).
Additionally, as pointed out by @ClementWalter, the get_storage_key function from mock.rs takes the target address but actually doesn't do anything with it but returning it in the return tuple. This needs to be cleaned, get_storage_key should ONLY return do what is expected by it, hence returning the storage key.

I would like to take this one

I would like to take this one

🙏

In order to have get_storage_key return the storage key, which is the second element in the tuple, I will then change the storage type here:
https://github.com/keep-starknet-strange/madara/blob/main/crates/pallets/starknet/src/lib.rs#L272

After looking into having get_storage_key return only the storage key, I noticed that that would require removing this key value storage item:
https://github.com/keep-starknet-strange/madara/blob/main/crates/pallets/starknet/src/lib.rs#L235
So I suggest to leave the return value of get_storage_key as the current tuple


Update Player Bio “map-thumbnail-img-me-png-name-jordan-buermann-body-i-am-the-dm-i-do-things-it-is-swell”

Automatically generated by Netlify CMS

👷 Deploy Preview for dynamic-cheesecake-5fbd8b processing.

Name
Link

🔨 Latest commit
196f07e2daa3f3538c990467af5daab3b22c766b

🔍 Latest deploy log
https://app.netlify.com/sites/dynamic-cheesecake-5fbd8b/deploys/62d892a4fb9da4000a708232


Always stuck in during run step

offcial settings in tutorials ,
run 10
and stuck in this step,
any idea about how to solve this?

you can visit http://localhost:8000/simulator_home   page to continue the step

you can visit http://localhost:8000/simulator_home page to continue the step

thanks for your help

you can visit http://localhost:8000/simulator_home page to continue the step

It does't work with me, it stuck in the process persona.scratch.importance_triggger_curr: : 145 150.

they are sleeping in the first 2000 steps or more, be patient.

they are sleeping in the first 2000 steps or more, be patient.

I'm having this issue too.
Do you mean if we run 3 steps, the first 2000 is just sleeping? That doesn't make sense

i find the root cause is I am using the society implement code to replace other none ChatGPT-turbo to ChatGPT-turbo API

@ShadowTeamCN How did you solve this issue? Could you please help me out?

您可以访问 http://localhost:8000/simulator_home 页面继续该步骤

It really works！Thanks bro


Request Support: Compress Level

https://github.com/martini-contrib/gzip/blob/master/gzip.go#L31
default is DefaultCompression
the compression ratio is too low
see https://golang.org/pkg/compress/gzip/#NewWriterLevel

@Septembers Following the code, it looks like the default compression level is 6 (from compress/flate which compress/gzip uses) where 9 is the highest level of compression. I feel like that is a good balance between compression and speed, but if there is good reasoning behind increasing the compression level, I'd be alright with the increase to a higher level.

Oops, sorry for such spam.


chore(deps): Migrate from crate[sqlalchemy] to sqlalchemy-cratedb

SUMMARY

The CrateDB SQLAlchemy dialect needs more love, so it was separated from the DBAPI HTTP driver.
This patch concludes the update to the new designated CrateDB SQLAlchemy dialect package, sqlalchemy-cratedb, which has been validated on a few other downstream packages already.

Personal Message
Dear Superset maintainers, first things first: Thanks a stack for conceiving and maintaining Apache Superset, you know who you are. Hereby, we are submitting a a little update about the database adapter of CrateDB. With kind regards, Andreas.
May we ask you to approve running the software tests on this draft PR, so we can get an impression if anything breaks?
/cc @hammerhead, @hlcianfagna, @surister

Thanks for the PR! We very much appreciate it :) Running CI. 🤞

@amotl it seems likely you've contributed to both the crate SQLAlchemy dialect and sqlalchemy-cratedb—serving as the main author for the later. What was the main reason for splitting this work out, i.e., why isn't it viable to simply update the SQLAlchemy dialect for the former?

Hi. Thanks for merging. We also just updated the canonical migration page on our documentation.

https://cratedb.com/docs/sqlalchemy-cratedb/migrate-from-crate-client.html

Thanks for all your excellent work on Superset! 💯


[usbdev] Power on the diff receiver before using it

Add a parameter to usbdev to count time until a differential receiver
should be operational. If the device is configured to use a differential
receiver, reject detected K and J symbols for the power-on time after
enabling the receiver.
Resolves #10901

looks good! will merge once CI goes through.


Add full text search textfield

Even if the full text search is already possible by means of the SPARQL extensions made available by Blazegraph, it is important to add an appropriate widget in the Website so as to allow users to properly search for resources as happens in common search engines.
[Suggested by Reviewer 3 of our ISWC 2017 paper]

From notes on Project Meeting 17th Oct 2017:
Development of query interfaces
* Objective: To be able to interrogate OpenCitations content
* Simple human query interface
* Single text box – enter author name, fragment of title, or identifier
* Return list of all bibliographic entities matching query
* Advanced query interface – permits Boolean operations
* Enter Author 1    Family name    First name / initial    or   ORCID
and/or Author 2    Family name    First name / initial    or   ORCID
and/or Title (contains)
and/or Keywords / phrase
* Response
* Return as many hits as meet the criteria
* For each returned paper, give the user the ability to:
* Copy citation (bibliographic metadata) [With a Choose Format box]
* Or Show incoming and/or outgoing citations (opens graph display)
* Ivan to do this, using indexing already developed


crash when running pub build

This issue was originally filed by<EMAIL_ADDRESS>
What is the expected output? What do you see instead?
I expect a successful build but instead the compiler crashes.
What version of the product are you using? On what operating system?
Windows 7, Dart Editor version 1.1.3.release (STABLE)
, 32314
Please provide any additional information below.
--- 26.02.2014 20:22:40 Running pub build ... ---
Pub build failed, [65] Building animatr_gui....
[Warning from polymer (Linter) on animatr_gui|web/docs/logging/Level.html]:
web/docs/logging/Level.html:330:96: Expected tag name. Got something else instead
[Warning from polymer (Linter) on animatr_gui|web/docs/logging/Level.html]:
web/docs/logging/Level.html:340:96: Expected tag name. Got something else instead
[Warning from polymer (InlineCodeExtractor) on animatr_gui|web/docs/logging/Level.html]:
web/docs/logging/Level.html:330:96: Expected tag name. Got something else instead
[Warning from polymer (InlineCodeExtractor) on animatr_gui|web/docs/logging/Level.html]:
web/docs/logging/Level.html:340:96: Expected tag name. Got something else instead
[Warning from polymer (BuildFilter) on animatr_gui|web/docs/logging/Level.html]:
web/docs/logging/Level.html:330:96: Expected tag name. Got something else instead
[Warning from polymer (BuildFilter) on animatr_gui|web/docs/logging/Level.html]:
web/docs/logging/Level.html:340:96: Expected tag name. Got something else instead
The compiler is broken.
When compiling the above element, the compiler crashed. It is not
possible to tell if this is caused by a problem in your program or
not. Regardless, the compiler should not crash.
The Dart team would greatly appreciate if you would take a moment to
report this problem at http://dartbug.com/new.
Please include the following information:
* the name and version of your operating system,
* the Dart SDK build number (build number could not be determined), and
* the entire message you see here (including the full stack trace
  below as well as the source location above).
[Dart2JS on animatr_gui|web/animatr.dart]:
packages\animatr_gui\panels\properties.dart:3:42: Error: The compiler crashed when compiling this element.
class PropertiesPanel extends Panel with ChangeNotifier  {
                                         ^^^^^^^^^^^^^^
Build error:
Transform Dart2JS on animatr_gui|web/animatr.dart threw error: The null object does not have a method 'isSetter'.
NoSuchMethodError : method not found: 'isSetter'
Receiver: null
Arguments: []
dart:core                                                                                Object.noSuchMethod
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 645     TypeGraphInferrerEngine.updateParameterAssignments
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_nodes.dart 449        StaticCallSiteTypeInformation.addToGraph
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 791     TypeGraphInferrerEngine.registerCalledElement
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\simple_types_inferrer.dart 1083  SimpleTypeInferrerVisitor.handleStaticSend
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\simple_types_inferrer.dart 1040  SimpleTypeInferrerVisitor.visitGetterSend
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\resolved_visitor.dart 24                  ResolvedVisitor.visitSend
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\tree\nodes.dart 355                       Send.accept
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\inferrer_visitor.dart 644        InferrerVisitor.visit
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\simple_types_inferrer.dart 468   SimpleTypeInferrerVisitor.run.<fn>
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\elements\modelx.dart 1363                 FunctionSignatureX.forEachOptionalParameter
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\simple_types_inferrer.dart 465   SimpleTypeInferrerVisitor.run
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 540     TypeGraphInferrerEngine.analyze.<fn>
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 499                         Compiler.withCurrentElement
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 523                         Compiler.withCurrentElement
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 500                         Compiler.withCurrentElement
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 539     TypeGraphInferrerEngine.analyze
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 473     TypeGraphInferrerEngine.runOverAllElements.<fn>
dart:core                                                                                List.forEach
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 465     TypeGraphInferrerEngine.runOverAllElements
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 936     TypeGraphInferrer.analyzeMain
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\types\types.dart 345                      TypesTask.onResolutionComplete.<fn>
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 1561                        CompilerTask.measure
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\types\types.dart 344                      TypesTask.onResolutionComplete
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 1111                        Compiler.compileLoadedLibraries
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 1011                        Compiler.runCompiler.<fn>
dart:isolate                                                                                _RawReceivePortImpl._handleMessage
The compiler is broken.
When compiling the above element, the compiler crashed. It is not
possible to tell if this is caused by a problem in your program or
not. Regardless, the compiler should not crash.
The Dart team would greatly appreciate if you would take a moment to
report this problem at http://dartbug.com/new.
Please include the following information:
* the name and version of your operating system,
* the Dart SDK build number (build number could not be determined), and
* the entire message you see here (including the full stack trace
  below as well as the source location above).
[Dart2JS on animatr_gui|web/animatr.html_bootstrap.dart]:
packages\animatr_gui\panels\properties.dart:3:42: Error: The compiler crashed when compiling this element.
class PropertiesPanel extends Panel with ChangeNotifier  {
                                         ^^^^^^^^^^^^^^
Build error:
Transform Dart2JS on animatr_gui|web/animatr.html_bootstrap.dart threw error: The null object does not have a method 'isSetter'.
NoSuchMethodError : method not found: 'isSetter'
Receiver: null
Arguments: []
dart:core                                                                                Object.noSuchMethod
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 645     TypeGraphInferrerEngine.updateParameterAssignments
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_nodes.dart 449        StaticCallSiteTypeInformation.addToGraph
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 791     TypeGraphInferrerEngine.registerCalledElement
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\simple_types_inferrer.dart 1083  SimpleTypeInferrerVisitor.handleStaticSend
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\simple_types_inferrer.dart 1040  SimpleTypeInferrerVisitor.visitGetterSend
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\resolved_visitor.dart 24                  ResolvedVisitor.visitSend
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\tree\nodes.dart 355                       Send.accept
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\inferrer_visitor.dart 644        InferrerVisitor.visit
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\simple_types_inferrer.dart 468   SimpleTypeInferrerVisitor.run.<fn>
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\elements\modelx.dart 1363                 FunctionSignatureX.forEachOptionalParameter
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\simple_types_inferrer.dart 465   SimpleTypeInferrerVisitor.run
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 540     TypeGraphInferrerEngine.analyze.<fn>
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 499                         Compiler.withCurrentElement
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 523                         Compiler.withCurrentElement
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 500                         Compiler.withCurrentElement
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 539     TypeGraphInferrerEngine.analyze
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 473     TypeGraphInferrerEngine.runOverAllElements.<fn>
dart:core                                                                                List.forEach
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 465     TypeGraphInferrerEngine.runOverAllElements
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\inferrer\type_graph_inferrer.dart 936     TypeGraphInferrer.analyzeMain
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\types\types.dart 345                      TypesTask.onResolutionComplete.<fn>
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 1561                        CompilerTask.measure
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\types\types.dart 344                      TypesTask.onResolutionComplete
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 1111                        Compiler.compileLoadedLibraries
e:\b\build\slave\dart-editor-win-stable\build\dart\sdk\lib_internal\compiler\implementation\compiler.dart 1011                        Compiler.runCompiler.<fn>
dart:isolate                                                                                _RawReceivePortImpl._handleMessage
Build failed.

I'll close this issue assuming that it was fixed in 1.2, but please let us know and share with us a way to reproduce it if you run into it again


Improve verbosity of failed test cases

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #40078
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@Thevakumar-Luheerathan Shall we include the output before and after this change for some data provider tests in the PR description?


Call showWarningMessage when refmt fails

There are a few cases where it would be good to show errors from refmt:

For projects that are not using bsb
For times where the bsb parser version doesn't coincide with the installed refmt version

I've run into problems due to 2 and it's very confusing, as the auto-formatting suddenly breaks with no information. I had to check from the command line to see what was going on. This is always an option of course, but we can improve the user experience by parsing the output, with a similar mechanism that we use for bsb.
Except, in this case, it is so much simpler :)
File "./src/Presentation.re", line 30, characters 73-74:
Error: 2583: <UNKNOWN SYNTAX ERROR>

This is also pretty helpful from the Atom->ocaml-language-server use case which doesn't have any error feedback when trying to reformat an invalidly written file.
I don't know what the experience in VSCode is like, but in Atom, if you have a syntax error, it's lost in a sea of other potential errors in the Diagnostics panel - so when you hit the key command to reformat and it doesn't tell you that it can't due to a syntax error, it's a little confusing.

@jordwalke The fix in #99 should help alleviate that pain. When refmt finds an error, it sends just that one as diagnostics of that file, which would "clean" the Diagnostic panel from every other diagnostics from other tools, and allow the user to focus just on that particular one.


Vienna Hackathon

We should coordinate if some of us can participate in the Vienna hackathon (19 – 21 May 2017) and what specific goals we would like to accomplish during the event.
It is still very early but the main information channels are:

https://phabricator.wikimedia.org/project/view/1919/
https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2017

I would love to attend, but that will probably be dependent on some factors (including funding), as I live in NZ, which is on the other side of the globe. :)
Regardless of whether or not I am able to attend, I'd be more than happy to provide support. I should probably mention that I am planning to apply for an IEG renewal (see here). If it is approved, I would be halfway through the proposed tasks by the time the hackathon comes, so it might be better to pick a different goal/focus for the two?
There are plenty of improvements that need to be made though, so plenty of wiggle room there. :) Depending on what you guys would like to work on for the hackathon, I can rearrange my IEG proposal goals around that as well.

How much time does a team have to work on tasks during the hackathon? Can the team spend the entire 3 days on it, or does the time have to be split between projects?

I think there will always be a free space to hack in if you are not interested in the ongoging sessions elsewhere. (At least that was the case in 2014.)
Volunteers tend to have interest in two or more projects (for me, Commons app and Pywikibot, etc) and they might want to split their time. But if you want to focus on one, I think there is nothing stops you from that.

Some random ideas for possible topics to work on using the occasion:

Stalled issues and meta issues, especially ones that involve other infrastructures and tools (e.g. Refactor and share components with the Wikipedia app / other Java-based upload tools? Move from GitHub to Wikimedia Phabricator/Gerrit? Restore and enhance EventLogging features?)
Sharing knowledge between contributors; recruiting and onboarding new contributors to the Commons app, maybe by hosting a hands-on session
Reducing technical debts (e.g. What to do with the obsolete MWApi library?)

What do you think?

@whym I love suggestion 2, that would really take advantage of the in-person nature of a hackathon. I think getting set up and getting a rough understanding of the codebase is probably the most difficult part of new contributors getting started (though it is easier than before now that we have migrated to Gradle). A hands-on session would be great.
I'm not sure about suggestion 1 - do we want to migrate to Phabricator/Gerrit? AFAIK the official Wikipedia app is on GitHub as well, although I don't know if they have a Gerrit mirror.

I didn't really mean to suggest migrating to Gerrit. (I think there are both benefits and pains - but that's for another discussion, I guess.) I just thought issues "that involve other infrastructures and tools" categorically could use the hackathon where people who otherwise don't usually meet meet.
In that category, "Refactor and share components with the Wikipedia app" might be more suitable for a hackathon - the internals of the app would be easier to understand if you can directly ask people from the team looking at the same screen.

Ah, yes, that does make a lot of sense. I agree with you, that would be awesome as well. Would a member of the Wikipedia app team be on board with working with us for a session?

I reached to<EMAIL_ADDRESS>about it and Rachel Farrand responded. She told me that many of the WMF's Android developers do plan to attend the event - so it looks like we will have a good opportunity for collaboration. She also suggested sending to<EMAIL_ADDRESS>for discussions with the developers.
Here is an excerpt from her response (posted with permission) with other related points:

(snip)
we are actively trying to come up with new and better ways to encourage and facilitate pre-hackathon collaboration. It is being discussed here: https://phabricator.wikimedia.org/T120092 and also here: https://phabricator.wikimedia.org/T124262

There are a lot of ideas flying around at the moment, and we will have a more solid plan in a few months.

Additionally, it looks like there may be multiple smaller technical events taking place in European cities. We will announce these events to registered hackathon participants (once we open registration and start collecting names and email addresses). Keep an eye out for these.

Awesome. :) I don't really know how submission of a project for a hackathon works, do we need to officially submit ours to the event committee for inclusion?

@VojtechDostal sounds good, and I agree! The Nearby function definitely needs a lot of improvement. Do you think you could organize our inclusion in the hackathon? I could help with whatever is needed but I have never attended one before, let alone organized one. :)
Many thanks!

I've been reading https://www.mediawiki.org/wiki/Hackathons/FAQ and from what I can see the process is just:

Register (and apply for travel scholarship if needed) when WMF opens registration for the event
Put up our project on the associated Phabricator board when it is open
Show up and work on it?

Did I get that mostly right?

Registration is now open: https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2017/Register_and_Attend

Thanks @tobias47n9e ! @VojtechDostal and I are currently trying to set up the prehackathon as well : https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2017/Prehackathon_Prague
Some things that I think we might need to discuss:

How do we allocate the topics to work on, between the pre-hackathon and hackathon? Should we have one small task for the pre-hackathon and one larger task for the hackathon perhaps? I think both should be related to the Nearby function, as that appears to be the aspect of our app that has garnered the most interest in the community.
Who else should we invite to the prehackathon (besides the people on this thread who have already expressed interest in attending)?

@misaochan Speaking of the Nearby-function. I am pretty confident that I can get the photo-request part of the webapp done before the hackathon (first version should be online in a couple of weeks).
These 3 tasks therefore seem to be good things to work on for both events:

SPARQL-based finding of missing images on Wikidata
REST-based requested images provided by the web-app
A ~ 1 hour discussion, how to model campaigns in the web and mobile app

Should we for example also notify: https://okfn.org/network/czech-republic/ about the event?

@tobias47n9e great suggestions. Re: the web app, do you mean the spatial database described at https://github.com/commons-app/commons-app.github.io/issues/16 ? Would we be wanting to work on further developing the web service, or on setting up the client side in the Android app?

@misaochan That might be good idea for people that have more experience with HTML/JS/Python than with Java and Android.

@tobias47n9e if we do run a session for the web app, would you be willing to lead it? I'm not very familiar with web development, but would like to learn. :)

@misaochan Sure. I can give a short introduction to what it currently does.

Shall I close this to focus on #353 ?

@misaochan I think we can close this issue. Seems like the original topic has been solved and the other topics are tracked elsewhere.


Potential deadlock when using console_subscriber

Platform
x86_64 GNU/Linux
Description
Spawning multiple instrumented futures along with the console_subscriber consistently results in the program hanging, with 0% CPU usage – looks like a deadlock. It could of course be that I'm doing something completely wrong!
We're spawning multiple tasks in the same location, with the following snippet:
#[track_caller]
fn spawn<W, G, F>(&mut self, g: G)
where
    W: Worker<Self>,
    G: FnOnce(oneshot::Receiver<()>) -> F,
    F: Future<Output = ()> + Send + 'static,
{
    let (tx, rx) = oneshot::channel();
    let future = g(rx);

    let caller = Location::caller();
    let span = tracing::info_span!(
        target: "tokio::task",
        "task",
        file = caller.file(),
        line = caller.line(),
    );

    let task = tokio::spawn(future.instrument(span))

    self.tasks
        .entry(TypeId::of::<W>())
        .or_default()
        .push((tx, Box::new(task)));
}

The following code is used to create the subscriber. If the TasksLayer is never constructed, and layer never passed to the tracing_subscriber, the code runs as expected:
let (layer, server) = console_subscriber::TasksLayer::new();

let filter = tracing_subscriber::EnvFilter::from_default_env()
    .add_directive(tracing::Level::INFO.into())
    .add_directive("tokio=info".parse().unwrap());

tracing_subscriber::registry()
    .with(tracing_subscriber::fmt::layer())
    .with(filter)
    .with(layer)
    .init();

let serve = tokio::spawn(async move { server.serve().await });

// ----------------

let _ = tokio::try_join!(tokio__spawn(node.run()), serve);

Hmmm, interesting. I notice that your code is creating its own tokio::task span, in addition to the span generated by tokio::spawn itself when RUSTFLAGS="--cfg tokio_unstable" is set...are you also setting that cfg? it's possible that having two task spans is breaking something, although that seems somewhat surprising...

Yes, this was really just to capture all the diagnostics in the same place – I'll try changing the target and see if that helps. The tokio_unstable flag is set when running this, so there will be two tokio::task spans at once.

After removing that target, I can't seem to get any of the spans to get captured by the subscriber (or at least, they don't appear in the console view). Am I chasing the wrong use-case by trying to capture spans outside of tokio internals?

After removing that target, I can't seem to get any of the spans to get captured by the subscriber (or at least, they don't appear in the console view).

Yeah, that part is expected --- but, if you set the level filter to tokio=trace, with your span disabled, do you still see the deadlock?

Am I chasing the wrong use-case by trying to capture spans outside of tokio internals?

Right now, the console has only been tested using tokio's internal instrumentation as the source for task spans, but the goal for the future is definitely to support consuming task spans from other sources as well. However, this isn't something we've put much work into supporting yet.
Currently, the TasksLayer type only cares about a single metadata callsite for task spans, and it will simply decide to track whatever the first metadata it sees with the target tokio::task and the name task: https://github.com/tokio-rs/console/blob/53515a7d9532e8b9780b56ab95d067309b46dc6f/console-subscriber/src/lib.rs#L172-L187
We could probably change this behavior and allow multiple span callsites to be tracked as tasks --- we could track any callsite with the tokio::task target, for example. This would allow spans in user code or from other executors to be tracked...and would simplify the code for tracking tasks from both tokio::spawn and tokio::spawn_blocking. However, we would probably want some way to ensure that if you spawn a future with a user-defined tokio::task span, and then tokio adds its own tokio::task span to the spawned future, we don't treat those as two separate tasks...
Regardless, I'm very surprised this is causing an apparent deadlock --- I can't really immediately imagine why that would happen.

Ah, thanks for talking through that. I've taken a look into the code and thought that was the case, but I'm not quite familiar enough with tracing or spans to have really grasped it on first glance...I suppose it would all be much easier if we didn't spawn all our tasks on the same line, since the only real need for us to use another span is to be able to record the caller location in the fields.
I have just tried changing the filter back to tokio=trace and disabling the instrumentation, and the deadlock still seems to be there, unfortunately – sitting completely still at 0% CPU usage. It's only when not constructing the TasksLayer that it seems to go away...

I observe the same total freez and CPU at 0% when trying latest main branch of console on http://github.com/njasm/blunt on the echo or chat examples. (tested on the trait_redo branch)
As soon as I start to open connections to any of the examples the probram just stops responding (not even accepting more connections. I've notice it cos i'm locally running artillery to load test the library
code used to register console_subscriber (compiled with RUSTFLAGS=--cfg tokio_unstable)
    let filter = EnvFilter::from_default_env()
        .add_directive("tokio=trace".parse().unwrap());

    let (console, server) = console_subscriber::TasksLayer::builder()
        .with_default_env()
        .build();

    use tracing_subscriber::layer::SubscriberExt;
    use tracing_subscriber::util::SubscriberInitExt;
    tracing_subscriber::registry()
        .with(filter)
        .with(console)
        .init();

    tokio::task::spawn(server.serve());
`

@njasm hmm, thanks for the report! out of interest, what happens if the console server task is spawned on a separate tokio runtime, in the background?

@hawkw If I understand you correctly, I've change the code to this.
    //tokio::task::spawn(server.serve());

    let _handle = std::thread::spawn(move || {
        let rt = tokio::runtime::Builder::new_multi_thread()
            .enable_all()
            .build()
            .unwrap();
        rt.block_on(server.serve())
    });

and it also deadlocks. With the single threaded runtime too.  (Builder::new_current_thread())
If I miss understood your question feel free to provide me with the code snippet you want to try it out.

Okay @njasm and @Adam-Gleave, I believe #95 should fix this. Let me know if you still see issues with the latest version from main?


Switcher issue

Switcher ignore value update
Since the last update changed method \OpenAdmin\Admin\Form\Field\SwitchField::prepare(), new conditions in the method expect to take 'on' or 'off' strings (or int: 0 ,1), but get a bool value.
To Reproduce

Create the switcher

Try to switch the parameter

Demonstration:
https://user-images.githubusercontent.com/50730757/217674905-e3839225-7387-43d2-ba17-5f679c26dbae.mp4
My investigation

resources/views/grid/inline-edit/switch-script.blade.php
Script sends a request with the bool value that gives from the checked property of an input element.
Property checked is always bool (as I know)

request

This value takes by the prepare() method of the field SwitchField
but after updates conditions have been changed, and now value false cannot be passed...

Here is old method prepare()

...cannot be passed because value with false will be ignored in src/Form.php:863

System

Open-admin version: 1.0.26
PHP version: 8.1.14
Laravel Version: 9.48.0
OS: Win + WLS2 (Linux) - local server launched on WSL2
Browser: Chrome

Im not sure why this method has been changes, but if the conditions should have the same structure, would be better to add a condition to resources/views/grid/inline-edit/switch-script.blade.php like a  var value = this.checked ? 'on' : 'off';` on smth like that

Hi there
Please see pull request
Tested and working on both Grid (Switch displayer) and Form

Hi All,
Sorry for late response. Thanks for the detailed report @x-oscarr and @RCyrix thanks for the merge request. I did some test and unfortunate it was not fully working in all cases. I ended up with the the fix that x-oscarr supplied. with the "on" : "off" instead of true.
Case:

Inline edits in the $grid depend on the $form.
If a field has a prepare function it will always be prepared before saving the model to the database.
In case a list has one or more inline edit fields, other fields with a prepared function will be prepared.
If the $value !== false it will be ignore
if we put the value of the switch to 0 when its false (not supplied), it will also default to 0 when other fields are save.

now fixed in v1.0.27


Refactoring of NativeUtils.java and addition of unit test

Refactoring

Limit line length to a maximum of 120 characters
Replace manually copying the file via a buffer with Files.copy(InputStream, Path, CopyOption...)
Move code for checking whether a POSIX-compliant system is being used into a new method
Add a constant MIN_PREFIX_LENGTH to replace the magic number of 3

Unit tests

Added a few basic unit tests to check the correct behavior of NativeUtils.loadLibraryFromJar(String)

Notes:
Besides the unit tests I manually checked that the method still works in terms of copying and loading a library

Hi Andre, thank you very much for the PR, this makes the code more mature.


Add Domain Replication DLQ

Add domain DLQ
Add enqueue dlq logic in worker
Update some DLQ persistence API (not fully integrated, require next PR with CLI changes)

Coverage increased (+0.3%) to 68.059% when pulling 225f481cbd1193bdafa45a0a2c3b9dc2c59763ae on domain_dlq into d5728936c346766c138e9ff6142200d7e1e7212c on master.


Large array support for randint

Title
2 unit-tests

checks if the shape of the array is indeed large enough
checks if the randint value is indeed large

@mxnet-label-bot add [pr-awaiting-merge]

Could you please retrigger the CI? Thanks!

Thanks. Merged


Add entry types for pax extended headers

This should handle #48.
With this PR, the pax global header is not fully supported yet, the values are simply ignored :wink: Docs can be found here. But at least it can now unpack files that contain these headers, instead of failing.
Did you ever think about using proper enums to implement the EntryTypes instead of using the boolean methods?

Regarding the enum, see the discussion at https://github.com/alexcrichton/tar-rs/issues/39#issuecomment-159057059

I personally don't agree with (part of) this PR. The changes to recognise 'g' and 'x' are obviously fine, but silently ignoring a posix archive seems dangerous - tar-rs can't (currently) handle posix archives and that should be made very clear to a library consumer with an error.
If you want to unpack an archive and ignore posix headers, I would suggest iterating over the entries of an archive, checking for a posix header and ignoring it if it's a match, or unpacking otherwise. i.e. move
        } else if kind.is_extended_header() || kind.is_global_extended_header() {
            // Not yet implemented
            return Ok(())

into your own code.

I personally don't agree with (part of) this PR. The changes to recognise 'g' and 'x' are obviously fine, but silently ignoring a posix archive seems dangerous - tar-rs can't (currently) handle posix archives and that should be made very clear to a library consumer with an error.

Yep. I only meant this PR as a first step in supporting PAX.
It looks like now @alexcrichton is working on adding PAX support, right?

Ok, I've opened up https://github.com/alexcrichton/tar-rs/pull/50 which now has pax support, please let me know what you think!


Css style use display: none hides use tags on entire page

By default you add a style tag on the generated svg to hide the use tags that are not the current tag.
The problem with that selector is that if we use an universal svg sprite loading technique (so inlining the svg contents on the page) that stile actually hides all the use tags on the site.
The code I'm using to load the svg in the page is this one (but in another project I'm using the server to print the svg directly on the page):
<object type="image/svg+xml" data="/assets/sprite.svg" onload="this.parentNode.replaceChild(this.getSVGDocument().childNodes[0], this); />"

A solution could be adding a group and hiding just the use tags inside that group, so it will not affect any other svg on the page.
<defs>
  <style>.svg-baker-sprite > use {display: none;} .svg-baker-sprite > use:target {display: inline;}</style>
  <symbol viewBox="0 0 24 24" id="i-add"><path d="M17 13h-4v4h-2v-4H7v-2h4V7h2v4h4m2-8H5c-1.11 0-2 .89-2 2v14a2 2 0 0 0 2 2h14a2 2 0 0 0 2-2V5a2 2 0 0 0-2-2z" /></symbol>
</defs>
<g class="svg-baker-sprite">
  <use id="i-add-usage" xlink:href="#i-add" />
</g>

Oh shi~! Thanks for reporting @albertogasparin, will fix it asap!

Shipped with<EMAIL_ADDRESS>


Updated post method to set content-length

The post method didn't set the content length, so on calls where it may be set (like a put) it would not get updated correctly. It now calculates the length and sets the header. Their may be other methods like get that also need it.

This code might be making a big assumption that the data is only a string when called by a put, I suspect that is the cause of all the CI errors. Looking for a better solution, unless you have one ;)


[docs] Reformat config reference

The Problem/Issue/Bug:
The current config options page has several issues:

Its title is hard to parse, especially for a new user, and it doesn’t encapsulate the page contents.
It’s impossible to link directly to individual options, which is a critical problem for any reference material.
Options aren’t arranged in any order that helps the reader find a specific option without having to read every item on the page.
There’s no relationship between project and global options, so figuring out which have local/global equivalents is a matter of comparing tables.

How this PR Solves The Problem:

Re-titles the page to “Config Options”, which should be more immediately obvious to understand, and places it at the top of its section navigation since available options are easily more important than the more specific subjects that follow.
Introduces the concepts of global and local configuration and how to work with them, along with reinforcing visual cues used throughout the page.
Liberates options from their tables into headings that can be linked directly.
Alphabetizes options which, combined with the sidebar table of contents, makes it possible to navigate the page without reading everything on it.
Consolidates options, consistently indicating whether they are per-project, global, or both. The option itself being more important than where you set it or how you use it, which should be a secondary concern.
Links descriptions to other settings or pages for supplemental learning and easier navigation in general.
Clearly identifies defaults and available options, where possible, for each option.

This format and ordering is more uniform and therefore easier to maintain with some confidence.
It also allows for a reasonable amount of explanation and linking for each item, which is discouraged by a table format where long descriptions hinder the ability to scan.
What This Doesn’t Do
There’s always more that could be done, but I had to draw the line somewhere and leave things out:

Include example settings (YAML and command, where relevant) for each item, which would reinforce how things work and make it hard to misunderstand.
Further categorize options by area of concern, like formatting/output, project basics, debugging, etc.
Improve option parity by consistently using _ or - as word separators.
Improve option parity by fixing inconsistent naming. (Booleans, for example, include use_letsencrypt vs. mutagen_enabled vs. no_bind_mounts. use_, _enabled, and no_ are each different conventions.)
Include a new, similarly-formatted and exhaustive reference page for commands.
Rename config_yaml.md to config-options.md. (Hyphen separator and match title.)

Disadvantages
Reduced Emphasis on YAML Location
This removes top-level project-vs.-global categorization on purpose. The availability of an option matters more initially than where you’d set it, and each config file itself includes exhaustive commentary on commonly-used settings.
The PR does make it harder, however, to limit your view to only project or global options, which could ideally be solved with a custom template later on and some selector that could toggle between all (default), project, and global visibility.
Less Compact
The change in page format also makes it slightly less convenient to scan every local and global option name in one go. This is mitigated by the new use of the table of contents.
Manual Testing Instructions:
https://ddev.readthedocs.io/en/stable/developers/testing-docs/#preview-changes
Related Issue Link(s):
Once again related to #4188.
Release/Deployment notes:
n/a

@rfay Me again! You’ll definitely want to look at the preview build for this one. PR description covers the rest.

Preview URL is https://ddev--4332.org.readthedocs.build/en/4332/ - no need to run mkdocs locally.

@rfay That’s exactly what I linked to in the comment just above yours. I’ve linked to local testing instructions in every PR under “Manual Testing Instructions” for the sake of completeness.

Just can't say how fantastic this is.

It looks like there's a bit of work still to be done though, as almost all of the config options have ddev config equivalents, and they're not there yet.

That’s bullet one in my “What This Doesn’t Do” list above. There are a whole slew of things, some getting into DDEV’s naming in general, that’d make this a more useful reference and I was shooting for an MVP reformatting that page.

I’m happy to add more to this effort, just want to know where to draw the line so it doesn’t get away from me or turn into a snowball PR.

I understand about the snowball... but it seems if you're going to do the tabs some places you'll want to do them everywhere?

Or maybe I should say you spoiled me in the first couple of paragraphs. I think readers will feel the same way.

Your call how to pursue it, but I think the fact that you spoiled me and set my expectations at the beginning will mean the same will happen to others.

Your call how to pursue it, but I think the fact that you spoiled me and set my expectations at the beginning will mean the same will happen to others.

I have other issues with tab inception and tab styling, and I’d love to come back to this to chase those remaining bullets later.

OK, if you want to defer completion of the tabby stuff I'll read it without being disappointed.

For reasons that are beyond me, the config file items almost always have underscores and the command-line config stuff almost always has hyphens, so additional_fqdns and additional-fqdns.
Is there any way in the world that we could ever make that seem rational or understood? I'm not sure that this is only in ddev, but it's not very helpful to the world.

For reasons that are beyond me, the config file items almost always have underscores and the command-line config stuff almost always has hyphens, so additional_fqdns and additional-fqdns.
Is there any way in the world that we could ever make that seem rational or understood? I'm not sure that this is only in ddev, but it's not very helpful to the world.

One way around it is to explicitly show an example of each option—which is the right call even if it’s not a thing for this PR. This comes with the bonus benefit of omitting the explicit example for the few cases where a CLI argument isn’t an option—which also conveys something specific and important.
It also helps, I think, to go from “almost always have underscores” to “always”. Meaning YAML outliers like table-style should become table_style. That way, if you know the name of the setting and have a feel for YAML vs. CLI argument, you can pick the right name.
Same goes more subtly for settings that act like toggles. If we favored _enabled, for example:

mutagen_enabled ⭐
instrumentation_opt_in → instrumentation_enabled
no_bind_mounts → bind_mounts_enabled
no_project_mount → project_mount_enabled
use_hardened_images → hardened_images_enabled
use_letsencrypt → letsencrypt_enabled

There are probably other examples and _enabled may not be the right choice, but the idea’s the same: reward me for picking up on patterns by making things easier to understand and guess.

Let me know when this is how you want it. I'll take one more pass and pull.

Do it the way you think is best and we'll see if people stumble on it.

Okay, ready to go then!


fix: compilation with MSVC

The encoder/decoder state structs have a zero-sized array for the samples. Visual Studio is fine with that, but only if it's at the end of a struct - I guess the size of an empty array isn't well-defined in C, so we cannot add other elements after it.
The PR uses an X-MACRO to use the same fields in both the declaration and the memory calculation without duplication. (I'd rather avoid the use of macros, but didn't find a better/cleaner fix for this)

Thanks for reporting this.
Yes, zero-size arrays aren't defined by the standard. Can you have a look at PR #20. I just removed those arrays.
I find that looks more clear than macros.
Thanks.

Anything without macros will be better :)

The (data +1 ) irritated me a bit - but it seems to be correct, at least the compiler always gave me valid addressed on llvm/macos with 64 bit. So, I'd be happy about PR #20
Alternatively: what about wasting 4 bytes and replacing the zero-size array with a single float or a one-element float array?

The (data + 1) will be correct because the size of the struct will be aligned with pointers inside it. But i'm agree it's not clear.
I have patched with one-element float array (#20). That will probably be the most portable way.
Sounds good ?

I love it! Neat idea to subtract the additional item - and not wasting 4 bytes.

👍


test-azure-win2012r2-x64-2 not responding

Follow on from #627
This machine seems to he having problems despite being recovered a few weeks ago.
@adam-thorpe has been trying to get onto it to verify if the setup is good for running tests and therefore re-enabling

Will handle it as soon as I can get past 2FA on the Azure portal!
I have a suggestion for managing the Azure access that we need in a slightly different manner - will take it up with @karianna and @gdams.

Any luck?

Also would be useful to know if Azure access can be granted to non-MSFT employees ;-)

Anyone with a Microsoft Account (outlook.com/hotmail.com/etc... even non-MS addresses are available to use, although I've not gone that route and cannot speak to it well).
Simply adding the account to the IAM for the subscription or for the resource itself is enough to grant access. I should be able to get some traction on it this week - our team is doing a 'team week' remote get together and we've been going full tilt unfortunately (and @karianna has been rather intensely under pressure for it, so I'm trying to not be too pushy yet!).

@d3r3kk @karianna Any outlook on recovering this system?

Can I bring this machine to a full Stop and lose it's public IP address, or will this cause problems with how Jenkins talks to the node?

No that's ok - for most of the UNIX machines it would be a problem, but for windows the machines call in to the jenkins server so the IP address doesn't matter (although we should update inventory.yml to store the new IP address.

@adam-thorpe Machine is up and running again now :-)

So we can close this now?


MINOR: Delete unused DeleteTopicsWithIdsResult.java

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
We can remove DeleteTopicsWithIdsResult since we use DeleteTopicsResult.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@jolshan Should we delete this?

Yes, sounds good. Somehow I missed this. LGTM