Move error data from error.data to error.message for failing rpc-compat calls

Describe the feature
ref https://github.com/ethereum/hive/pull/975#issuecomment-1921611234
We should, where possible, prevent using the error.data field if the error message can be contained in the error.message field.
This includes, but is not limited to debug_getRawReceipts.
Analyzing the rpc-compat suite failures is the best way to understand every call that needs a change in error message:
https://github.com/paradigmxyz/reth/actions/runs/7734052427/job/21088043313
Additional context
No response

so this originates from here you mean @Rjected ?
https://github.com/paradigmxyz/reth/blob/de6332b51e9d4bdf9d3e75a1523ff1cdfb862686/crates/rpc/rpc/src/eth/error.rs#L408-L422
and the solution is: control that the output field on RevertError is only used by spec error codes, not custom errors?
https://github.com/paradigmxyz/reth/blob/de6332b51e9d4bdf9d3e75a1523ff1cdfb862686/crates/rpc/rpc/src/eth/error.rs#L491-L500
links to where in specs the errors can be found?

links to where in specs the errors can be found?

there are no specs for rpc errors, the hive tests are considered the spec more or less
We basically cannot use the data field here:
https://github.com/paradigmxyz/reth/blob/fadc7b02a9f46192bd0eaa6c2e4c74cea0f490e5/crates/rpc/rpc/src/result.rs#L137-L140


Support blocking UDP receive call

Rationale: Support of a blocking UDP receive call allows synchronizing a simulation to an external application sending the UDP datagrams.
The proposal is to add an option useRecvThread to the UDPReceive block. So far a separate thread is created for receiving datagrams (corresponds to the proposed default value useRecvThread=true). By setting the option to false a user can prevent that a separate thread is created and simulation progress is blocked when calling out to UDP recvfrom(..).

Yes, I'm not sure what the better word is. But thinking about it, I lean to "dedicated". I will change it.

I will change it.

Thanks.
And please also add a separate test for it.

I've now  also successfully tested the code using OpenModelica running on Linux. The code seems okay and thus I squashed & merged it.


Clean up Web Program.cs File

Simplify, use extension methods, look at TODO comments.

@ardalis I can take this one too

This week?


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-k8s-23-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 871

Questions ?
Please refer to the Backport tool documentation


Fix japanese language code & croatian flag mapping

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Custom facets support for OneDrive for Business

Custom facets are currently in exclusive preview for OneDrive personal. Is there a roadmap (or even plan to) bring these to OneDrive for Business, to allow the viewing and editing of custom metadata? Alternatively, is there an option in the current API to access custom metadata on OneDrive for Business?

Custom facets are in preview and only available for OneDrive Personal at this time. https://dev.onedrive.com/misc/custom-metadata.htm

This is definitely something that's on our radar, but we unfortunately have nothing to share at this point.

Thanks for the information @ificator.
Is updating List items using a MERGE to the REST API still the best way to set custom metadata, in lieu of library support?

@ificator - is there anything to share on this for 2018?

@ificator - any updates on this request? Alternatively, if there's another way of getting/setting custom metadata, would appreciate it if you could let us know! Thanks in advance

@ificator - is there anything to share on this for 2019?

It's still on the radar. I'd suggest making sure it's tracked on https://onedrive.uservoice.com so it can be prioritized appropriately.


Email html body issue | Sort messages issue

Its me once again.
I have one weird issue with emails from my own mail provider.
<EMAIL_ADDRESS>is the mailbox which I access with laravel-imap
I send an email with a text attachment from<EMAIL_ADDRESS>to<EMAIL_ADDRESS>If I get the message there is no HTML body, only a TEXT body. BUT the text body is replaced with the content of the attached text file. If there would be no attached file, there is still only the TEXT body, but my message is not replaced.
Here is an image. In the image the content is not what I have written into the mail. Its the content from the attached file.

An other thing I always wanted to ask it about sorting the messages by date or id, so the most recent messaged are on page 1. Right now I have a solution, but it feels hacky:
$selectedFolder = $oClient->getFolder($data->folder);

$total_messages = $selectedFolder->query()->all()->count();
$messages_per_page = 40;

$highest_page = ceil($total_messages/$messages_per_page);
$aMessage = $selectedFolder->query()->setFetchFlags(true)->setFetchBody(true)->setFetchAttachment(false)->leaveUnread()->limit(40, $highest_page)->get();

On default the most recent messages are on the highest page. If I simply get all messages and display them as they are I see the old ones first. I also use limit to paginate my results. Right now I count all messages and divide them by the amount per page, so I get the highest page number. I start to display the messages on the highest page number, but it would be great to have a sorting method/solution.
I still struggle with sorting, I also opened a stack question:
https://stackoverflow.com/questions/59210122/laravel-imap-get-messages-sorted-by-most-recent

Sorting Issue Solved:
After playing around with several solutions I decided to go into the vendor file (config/imap.php) and change the fetch_order there:
'fetch_order' => 'desc'
It was asc. It seems that changing the fetch_order when creating the client does not override the config. I had this before and it did not work, also no errors were thrown:
$this->oClient = new Client([
    'host'          => env('MAIL_HOST_IN'),
    'port'          => env('MAIL_PORT_IN'),
    'encryption'    => env('MAIL_ENCRYPTION_IN'),
    'validate_cert' => true,
    'username'      => env('MAIL_USERNAME'),
    'password'      => env('MAIL_PASSWORD'),
    'protocol'      => 'imap',
    'options' => [
        'fetch_order' => 'desc',
    ]
]);

Solution attachment replaces body:
In thread https://github.com/Webklex/laravel-imap/issues/203 freescout-helpdesk proposes to replace certain code in the Message.php (vendor file):
Here is the solution:
Change condition in https://github.com/Webklex/laravel-imap/blob/master/src/IMAP/Message.php#L662 to:
if ($structure->type == IMAP::MESSAGE_TYPE_TEXT &&
	(empty($structure->disposition) || strtolower($structure->disposition) != 'attachment')
) {

I am currently on version 1.4.4 and this was enough to solve the issue. Now I see the original content of the email and the contents of the attachment do not replace email body.


Make wiki pages sort alphabetically

It should be possible to order wiki-pages alphabetically. I consider this to be a normal feature. You would think that the developers had to make some extra effort NOT making it alphabetically ;)

@Gybrsh Thanks for your question. You should create a feature request. To make sure it gets in front of the right people, please submit your issue here.


[Crash]: failed to load 'notificationstate' addon Error: Module did not self-register

Before you file a crash report

[X] I have checked the issue tracker and have not found an issue that matches the one I'm filing.
[X] This issue doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[X] I have read the contribution guidelines.

Mattermost Desktop Version
5.9.0
Operating System
NixOS 24.11
Mattermost Server Version
9.11.1
What type of crash did you experience?
System crash (The application quit unexpectedly with no warning, or the operating system reported a crash)
Crash report details
morten@nixos ~> mattermost-desktop
08:28:30.548 › Logger Log level set to: info
[macos-notification-state] failed to load 'notificationstate' addon Error: Module did not self-register: '/nix/store/bgkwklisjrddx6svc9crz7a27pav45kb-mattermost-desktop-5.9.0/share/mattermost-desktop/app.asar.unpacked/node_modules/macos-notification-state/build/Release/notificationstate.node'.
    at process.func [as dlopen] (node:electron/js2c/node_init:2:2559)
    at Module._extensions..node (node:internal/modules/cjs/loader:1602:18)
    at Object.func [as .node] (node:electron/js2c/node_init:2:2786)
    at Module.load (node:internal/modules/cjs/loader:1295:32)
    at Module._load (node:internal/modules/cjs/loader:1111:12)
    at c._load (node:electron/js2c/node_init:2:16955)
    at Module.require (node:internal/modules/cjs/loader:1318:19)
    at require (node:internal/modules/helpers:179:18)
    at bindings (/nix/store/bgkwklisjrddx6svc9crz7a27pav45kb-mattermost-desktop-5.9.0/share/mattermost-desktop/app.asar/node_modules/bindings/bindings.js:112:48)
    at safeLoad (/nix/store/bgkwklisjrddx6svc9crz7a27pav45kb-mattermost-desktop-5.9.0/share/mattermost-desktop/app.asar/node_modules/macos-notification-state/lib/index.js:3:31) {
  code: 'ERR_DLOPEN_FAILED'
}
08:28:30.627 › [App.Initialize] Current working directory is /home/morten, changing into /nix/store/rcvns6kf38zddhxq7q05msnjbyz8gmzd-electron-unwrapped-33.3.0/libexec/electron
08:28:30.697 › [App.Config] config.autostart has been configured: true
08:28:30.709 › [App.Initialize] Autoupgrade disabled: false
08:28:30.730 › [ServerDropdownView] init
08:28:30.751 › [i18nManager] Failed to set new language en-GB
08:28:30.751 › [i18nManager] Failed to set new language DK
08:28:30.863 › [App.Config] config.autostart has been configured: true
08:28:31.407 › [App.Config] config.autostart has been configured: true
(electron) 'webContents.clearHistory' is deprecated and will be removed. Please use 'webContents.navigationHistory.clear' instead.
(electron) 'webContents.canGoBack' is deprecated and will be removed. Please use 'webContents.navigationHistory.canGoBack' instead.
(electron) 'webContents.canGoForward' is deprecated and will be removed. Please use 'webContents.navigationHistory.canGoForward' instead.
[35842:1220/082906.311295:ERROR:wayland_event_watcher.cc(47)] libwayland: zxdg_exporter_v2#25: error 0: exported surface had an invalid role

fish: Job 1, 'mattermost-desktop' terminated by signal SIGTRAP (Trace or breakpoint trap)

Log Output
[2024-12-20 08:27:10.924] [error] Logger Log level set to: info
[2024-12-20 08:27:11.004] [warn]  [App.Initialize] Current working directory is /home/morten, changing into /nix/store/rcvns6kf38zddhxq7q05msnjbyz8gmzd-electron-unwrapped-33.3.0/libexec/electron
[2024-12-20 08:27:11.066] [info]  [App.Config] config.autostart has been configured: true
[2024-12-20 08:27:11.075] [info]  [App.Initialize] Autoupgrade disabled: false
[2024-12-20 08:27:11.076] [error] [MainWindow] Error: Provided bounds info are outside the bounds of your screen, using defaults instead.
    at P.getSavedWindowState (/nix/store/bgkwklisjrddx6svc9crz7a27pav45kb-mattermost-desktop-5.9.0/share/mattermost-desktop/app.asar/index.js:2:819478)
    at P.init (/nix/store/bgkwklisjrddx6svc9crz7a27pav45kb-mattermost-desktop-5.9.0/share/mattermost-desktop/app.asar/index.js:2:815824)
    at P.show (/nix/store/bgkwklisjrddx6svc9crz7a27pav45kb-mattermost-desktop-5.9.0/share/mattermost-desktop/app.asar/index.js:2:818038)
    at /nix/store/bgkwklisjrddx6svc9crz7a27pav45kb-mattermost-desktop-5.9.0/share/mattermost-desktop/app.asar/index.js:2:213809
    at zr (/nix/store/bgkwklisjrddx6svc9crz7a27pav45kb-mattermost-desktop-5.9.0/share/mattermost-desktop/app.asar/index.js:2:214532)
[2024-12-20 08:27:11.099] [info]  [ServerDropdownView] init
[2024-12-20 08:27:11.121] [warn]  [i18nManager] Failed to set new language en-GB
[2024-12-20 08:27:11.121] [warn]  [i18nManager] Failed to set new language DK
[2024-12-20 08:27:11.228] [info]  [App.Config] config.autostart has been configured: true
[2024-12-20 08:27:11.779] [info]  [App.Config] config.autostart has been configured: true

Additional Information
App crashes when app is closed, but only when Leave app running in notification area when application window is closed is set

As #3211 but being provoked but other events


fix(deps): :arrow_up: update dependency zone.js to v0.14.4

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

zone.js (source, changelog)
0.14.3 -> 0.14.4

Release Notes

angular/angular (zone.js)
v0.14.4
Compare Source
Bug Fixes

zone.js: add __Zone_ignore_on_properties to ZoneGlobalConfigurations (#50737) (f87f058)
zone.js: patch fs.realpath.native as macrotask (#54208) (19fae76), closes #45546
zone.js: patch Response methods returned by fetch (#50653) (260d3ed), closes #50327
zone.js: patch form-associated custom element callbacks (#50686) (1c990cd)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular/core
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@angular/animations
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2024-01-12T17_46_33_283Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-01-12T17_46_33_283Z-debug-0.log

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/esbuild
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   optional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/jest-preset-angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@nx/angular
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@nrwl/angular
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/esbuild
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@nx/angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@nrwl/angular
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2024-02-13T20_22_17_223Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-02-13T20_22_17_223Z-debug-0.log

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/esbuild
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   optional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/jest-preset-angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@nx/angular
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@nrwl/angular
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/esbuild
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@nx/angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@nrwl/angular
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2024-02-16T12_04_42_784Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-02-16T12_04_42_784Z-debug-0.log

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/esbuild
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!   optional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/jest-preset-angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!   1 more (ng-packagr)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@nx/angular
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@nrwl/angular
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/esbuild
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@nx/angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@nrwl/angular
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /tmp/renovate/cache/others/npm/_logs/2024-02-24T05_39_46_427Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-02-24T05_39_46_427Z-debug-0.log


make build fail

Hello!
On fresh clone v0.15.0 make build failed on
67 | >>> RUN /tmp/buf lint ./cmd/kubeapps-apis

in dashboard image

Excuse me, @kvaps, @gecube, is something wrong with my iissue? any feedback, please!

Looks like some generic issue related only to kubeapps building script. Try removing lint logic from the kubeapps-apis Dockerfile:
https://github.com/aenix-io/cozystack/blob/620871a595694816eeb1a29a2bd4aba897f54d1f/packages/system/dashboard/images/kubeapps-apis/Dockerfile#L67

Thanks a lot!


The data and models are not available.

Can anyone share a link. I really need it! Thanks a lot!

@Fangweijun111 They are not accessible forever.but in the paper there is a link for the dataset,open it you will find two json files.

@Fangweijun111 They are not accessible forever.but in the README there is a link for the dataset,open it you will find two json files.

请问第二步预训练模型链接也失效了咋办


NbtdocHelper doesn't go to child in NBT paths

:tada: This issue has been resolved in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


Add JSON application logging to CloudWatch logs

This adds JSON application logs to CloudWatch logs. See: https://github.com/alphagov/digitalmarketplace-utils/pull/151

assuming this is supplementary and does not replace the existing log (which it looks like it is) it's a 👍 from me.


WebApp - Re-check case totalStake < unstakeBalance

Describe the task
Re-check case totalStake < unstakeBalance

Ticket: https://discord.com/channels/447263980252037141/1261299767082881114

Check usage of BN.js for unstaking info

Version test : https://18a18f34.subwallet-webapp.pages.dev/
Validation passed in case :

Re-check all action on Earning features :
Stake
Stake more
Unstake
Cancel unstake
Withdraw
Claimreward


[Bug] Cannot pass level mixed5 in some situation

The dev output:
{"branches":{"main":{"target":"C1","id":"main","remoteTrackingBranchID":null}},"commits":{"C0":{"parents":[],"id":"C0","rootCommit":true},"C1":{"parents":["C0"],"id":"C1"}},"tags":{},"HEAD":{"target":"main","id":"HEAD"}}

After I created 2 commits on "side" branch and created a new branch, the level might no longer be passed.

By the way, you are doing a very GREAT job. As they said "It is one of the best resources I found on git". Thank you for your awesome work and thank all the contributors for inproving the i18n and fix bugs, it truly shows the power of community!

Thanks for the kind words! Yes this is because the C7 commit has not been placed below/downstream of the C6 commit.
It has to be C7 -> C6 to pass. Its c10 in this screenshot:

vs

Would you prefer we just look for one more commit on bugFix instead of explicitly C7?

Yes, because both Chinese and English discriptions' meaning is that a commit on bugFix represents you are finished, rather than a commit named "C7". Thx!


RegEx based message "ignore"

Block messages from going through to Telegram to Matrix, or the other way around
Could be configured like this:
"ignored_messages": {
    "!aBcDeFgHiJkLmNoPq:matrix.org": [
        { "sender": "@user:matrix.org",
          "match": "\[.*\] \- \d+\.\d+ [a-zA-Z]iB" }
    ]
}

Won't fix


1952 Set experiment id to uuid instead of string

Description
The api repo contains the sql migration script to change from string to uuid (and also cleans up a bit).
Details
URL to issue
https://biomage.atlassian.net/browse/BIOMAGE-1952

Link to staging deployment URL (or set N/A)
https://ui-martinfosco-api2-worker5-p.scp-staging.biomage.net/

Links to any PRs or resources related to this PR
This contains the s3 migration script
https://github.com/biomage-org/iac/pull/4
These ones are temporary, only for testing in staging that the migration actually works
https://github.com/biomage-org/worker/pull/5
https://github.com/biomage-org/pipeline/pull/10

Integration test branch
master

Merge checklist
Your changes will be ready for merging after all of the steps below have been completed.

Code updates
Have best practices and ongoing refactors being observed in this PR

[ ] Migrated any selector / reducer used to the new format.

Manual/unit testing

[ ] Tested changes using InfraMock locally or no tests required for change, e.g. Kubernetes chart updates.
[ ] Validated that current unit tests for code work as expected and are sufficient for code coverage or no unit tests required for change, e.g. documentation update.
[ ] Unit tests written or no unit tests required for change, e.g. documentation update.

Integration testing
You must check the box below to run integration tests on the latest commit on your PR branch.
Integration tests have to pass before the PR can be merged. Without checking the box, your PR
will not pass the required status checks for merging.

[ ] Started end-to-end tests on the latest commit.

Documentation updates

[ ] Relevant Github READMEs updated or no GitHub README updates required.
[ ] Relevant Wiki pages created/updated or no Wiki updates required.

Optional

[ ] Staging environment is unstaged before merging.
[ ] Photo of a cute animal attached to this PR.

IMPORTANT Right now the staging that is linked here has a full migration (sql and s3 side) of the staging experiments into a new sql cluster and new s3 buckets so that we can test that the migration works.
Primarily we want to test that none of the worker and pipeline features are broken because those are the ones that depend the most on s3 and expeirment-id variations might affect them the most.
When the 2 PRs that matter (iac and api) are approved, I'll run the migrations for staging (targeting the real s3 buckets instead of the -test ones), test a bit and then run them for production.
Since the s3 migration duplicates all the objects (doesn't delete anything), after testing in production I think I could run another small migration to delete all of the old versions of the s3 objects so that we don't end up with double the size in 4 b buckets. (Although most importantly, we don't need to duplicate the 2 biggest buckets we have because they don't depend on experimentId (originals and plots-and-tables)).
The unit tests are disabled because setting the s3 buckets to their -test counterparts breaks a lot of tests that won't be broken when I actually run the migrations

https://github.com/hms-dbmi-cellenics/api/pull/404

LGTM. Approved. I can't approve this PR because I'm the one who opens it. Feel free to approve and merge @cosa65


Upgrade to Rust 2018

After TiKV itself is successfully upgraded (tikv/tikv#3896) we can bump fail to Rust 2018 as well. Do a major version bump.

I have a branch that I think is ready to go here: https://github.com/brson/fail-rs/tree/rust-2018, but waiting until the tikv 2018 upgrade lands without trouble before this one.


Closes #358 - Add user settings to UI

This change is

Closing here in favor of splitting this PR into multiple smaller ones.


Logo not loading properly in navigation header

Actual Behaviour
The logo in the header is not loading properly
Expected Behaviour
Fix logo loading in n nav header.
Steps to reproduce it

LogCat for the issue

Screenshots of the issue

Would you like to work on the issue?
yes.
Target Milestone to solve the issue
https://github.com/fossasia/open-event-android/milestones/27

This is the case just for samples? @arp95 If yes, then it will be nice to mention that and other significant details in this issue.

@arp95 are you working on this? According to me it's not an issue anymore. The images are loading in the navigation header I think. Could you please check it once?

will check it ASAP. thanks for updating.

@arp95 Any updates if it loading correctly?

@iamareebjamal having a look. sorry for the delay.

I have tried the I/O as well as other samples @iamareebjamal @arp95 . We can safely close this issue 👍


gh-gei: 1.9.0 -> 1.11.0

Releasee notes between v1.9.0 and v1.11.0:

https://github.com/github/gh-gei/releases/tag/v1.10.0
https://github.com/github/gh-gei/releases/tag/v1.10.1
https://github.com/github/gh-gei/releases/tag/v1.11.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366482

x86_64-linux

:white_check_mark: 1 package built:

gh-gei

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 366482

x86_64-linux

:white_check_mark: 1 package built:

gh-gei

x86_64-darwin

:white_check_mark: 1 package built:

gh-gei

aarch64-darwin

:white_check_mark: 1 package built:

gh-gei

@Scrumplex (cc: @lafrenierejm) The current version of gh-gei on the release-24.11 seems to be v1.8.0, so it should be first bumped to v1.9.0 to successfully backport the changes on this pull request.
I've opened a backport pull request bumping to v1.9.0: #367080


Support systemd.socket

Hello.
Need support systemd.socket. This will make, activation and reload demon save all open connections.
https://www.freedesktop.org/software/systemd/man/systemd.socket.html#
Is planned implement?
Thank.

I'm not really sure how that's amp's business. Amp is only providing readability and writability watchers, not creating or managing sockets.

Might be something for amphp/socket or an own systemd package.

Yes, it should be amphp/socket, but how to do user land PHP, I do not know.

amphp.socket
[Socket]
Backlog       = 1024
ListenStream  = /run/www/amphp.sock

[Install]
WantedBy = sockets.target

amphp.service
[Service]
ExecStart = /var/www/amphp/server.php

[Install]
WantedBy = multi-user.target

Get env params in server.php:
$_SERVER['LISTEN_FDS'] // 1 - file descriptor
$_SERVER['LISTEN_PID']; // current pid
But how to work with them and open the connection, I do not know :)

Closing, because it's nothing for amphp/amp. I think something like that should be it's own package.


Assistants API - cannot send Images through MessageContent

Describe the bug
When I send an image to Assistants API CreateMessage, I get an Error back from the API. It suggests that the request is not correctly serializing.
Your code piece
            prompt = ...
            bytes = ...

            var messageRequest = new MessageCreateRequest
            {
                Role = StaticValues.AssistantsStatics.MessageStatics.Roles.User,
                Content = new([
                    MessageContent.TextContent(prompt),
                    MessageContent.ImageBinaryContent(
                                bytes,
                                ImageStatics.ImageFileTypes.Png,
                                ImageStatics.ImageDetailTypes.High
                            )
                ]),
            };

            var messageResult = await Service.Beta.Messages.CreateMessage(ThreadId, messageRequest, CancelToken);

Result
With MessageContent.ImageBinaryContent() I get "Invalid 'content[1].image_url.url'. Expected a valid URL, but got a value with an invalid format."   With MessageContent.ImageFileContent(), I get "'content[1].image_file.file_id'. You provided 'file_Id', did you mean to provide 'file_id'?"
Expected behavior
If I send the exact same thing to ChatCompletionCreateRequest, it works, so I know there isn't anything wrong with the fileId or binary.
Desktop (please complete the following information):

Windows
VS2022
C#
.NET Framework 4.8

same issue here, could you fix it? @pappde

It does not appear to be possible to send Base64-encoded images to the Assistants API.
https://community.openai.com/t/how-to-send-base64-images-to-assistant-api/752440

Here is a test I added to MessagesTestHelper:
public static async Task CreateMessageWithImage(IOpenAIService openAI)
{
    ConsoleExtensions.WriteLine("Create MessageWithImage Testing is starting:", ConsoleColor.Cyan);
    var thread = await openAI.Beta.Threads.ThreadCreate();
    if (!thread.Successful)
    {
        if (thread.Error == null)
        {
            throw new("Unknown Error");
        }

        ConsoleExtensions.WriteLine($"{thread.Error.Code}: {thread.Error.Message}", ConsoleColor.Red);
        return;
    }

    var prompt = "Tell me about this image";
    var filename = "image_edit_mask.png";

    var sampleBytes = await FileExtensions.ReadAllBytesAsync($"SampleData/{filename}");

    CreatedThreadId = thread.Id;
    var result = await openAI.Beta.Messages.CreateMessage(CreatedThreadId, new()
    {
        Role = StaticValues.AssistantsStatics.MessageStatics.Roles.User,
        Content = new([
            MessageContent.TextContent(prompt),
            MessageContent.ImageBinaryContent(
                        sampleBytes,
                        ImageStatics.ImageFileTypes.Png,
                        ImageStatics.ImageDetailTypes.High
                    )
        ]),
    }
    );
    if (result.Successful)
    {
        CreatedMessageId = result.Id;
        ConsoleExtensions.WriteLine($"Message Created Successfully with ID: {result.Id}", ConsoleColor.Green);
    }
    else
    {
        ConsoleExtensions.WriteError(result.Error);
    }
}

This test results in the following error message:
Invalid 'content[1].image_url.url'. Expected a valid URL, but got a value with an invalid format.

Something weird about the MessageContentConverter?  The serialized json for the request looks fine though. Might try to compare to  ChatMessage.FromUser(IList contents) which does work.

I did find and fix the other issue using ImageFileContent(). See PR #574.  So at least we have a workaround.
EXPLANATION
You'll note this error message.
Missing required parameter: 'content[1].image_file.file_id'. You provided 'file_Id', did you mean to provide 'file_id'?

Note the subtle capitalization discrepancy on "Id" vs "id".   That is fixed in PR #...
ORIGINAL ISSUE
The original issue is still present with ImageBinaryContent.  I do wonder if this is a problem with the API. At a quick glance, it looks like both the ChatCompletion and Assistants code are encoding the data to URL the same. However, when sent as part of ChatCompletionCreateRequest.Messages, it works, but when sent as part of CreateMessageRequest.Content, it doesn't work.  Again here is the error message that persists with CreateMessageRequest and ImageBinaryContent:
Invalid 'content[1].image_url.url'. Expected a valid URL, but got a value with an invalid format.

REPRO NOTES:
MessagesTestHelper.CreateMessageWithImage - not working
VisionTestHelper.RunSimpleVisionTestUsingBase64EncodedImage - working


Add target="_blank" attribute in handpicked hyperlinks.

Almost all the hyperlinks open in the same tab and not new tab due to which if a user wishes to come back to the website he will have to lose his activity on the hyperlinked page and hit back button. It would be better if links open in new tab so as to have easy access back to the website.
I would be grateful if this issue is found worthy and if I'm assigned this task.

Go ahead @harjasnagi


promote Astar EVM

balances

fee

found issues are described here: https://app.clickup.com/t/8692vn35p

@leohar
I don't think this is an actual PR, shall we close it?


EventStore

Is there an example somewhere how to use it with EventStore (geteventstore.com) (hydrate aggregate from events stored in EventStore)

Thanks for your question. I haven't looked into how to read/write events from/to EventStore.

Somebody at work also asked me about this today. Do you know much about it / how we could do it?

Could probably make a stored event repository using this Python client for EventStore: https://github.com/Phontan/EventStore.PythonClientAPI
Would anybody actually find this useful really, or would it be more of a curiosity? I'm wondering what you can do with EventStore that you can't do with e.g. Cassandra?
I'm guessing it's in a position to do optimistic concurrency control better than a read and a write against Cassandra, that could be checked I suppose. It could even serialise access to a stream, but I don't see how that could always work e.g. in a distributed situation and scale linearly. I'm becoming curious to see what qualities it has.
It's got pub-sub, and so has e.g. Redis, but I guess if an originating application only needs to publish an event to the event store, and receiving applications can subscribe to it, that helps keep infrastructure simple. However, if the application changed to use something else for persistence of events, then at the same time an alternative pub-sub system would be needed, and the receiving application would need to subscribe to that instead. I guess that's not a problem.
I don't know if it always enforces an integer sequence on every stream, if so perhaps it couldn't be used for e.g. a log entity that doesn't maintain a version number, unless the expected version parameter was derived by causing an exception to be raised which would be absurd. I'm sure that's not a big problem.
On reflection, it seems to have useful and perhaps unique qualities, in particular the optimistic concurrency control of the event streams might be very useful if it is really solid, and might actually be needed by some people.


Bug(deck): Unable to use ( and ) symbols when on kde wayland but works fine on xorg

I had to switch back to xorg for that reason.

it's fixed


Lineage

Support for field-level upstream lineage could be aligned to OpenLinage format for "inputFields" (https://openlineage.io/docs/spec/facets/dataset-facets/column_lineage_facet/)
First draft, open to discuss:
fields:
  order_id:
    type: string
    lineage: # new property
      inputFields:
        - namespace: food_delivery
          name: public.delivery_7_days
          field: order_id
          transformations:
            - type: DIRECT
              subtype: IDENTITY
              description: ""
              masking: false
        - namespace: food_delivery
          name: public.delivery_7_days
          field: order_placed_on
          transformations:
            - type: INDIRECT
              subtype: SORT
              description: ""
              masking: false
        - namespace: food_delivery
          name: public.delivery_7_days
          field: order_delivered_on
          transformations:
            - type: INDIRECT
              subtype: SORT
              description: ""
              masking: false

Another example:
models:
  orders:
    description: One record per order. Includes cancelled and deleted orders.
    type: table
    fields:
      order_id:
        $ref: '#/definitions/order_id'
        required: true
        unique: true
        primary: true
        lineage:
          inputFields:
          - namespace: kafka
            name: com.example.checkout.order.v1 # kafka topic name
            field: orderId
            transformations:
              - type: DIRECT
                subtype: IDENTITY
          - namespace: kafka
            name: com.example.checkout.order.v1 # kafka topic name
            field: status
            transformations:
              - type: INDIRECT
                subtype: FILTER
                description: filtered on status = 'successful'
      order_timestamp:
        description: The business timestamp in UTC when the order was successfully registered in the source system and the payment was successful.
        type: timestamp
        required: true
        example: "2024-09-09T08:30:00Z"
        lineage:
          inputFields:
          - namespace: kafka
            name: com.example.checkout.order.v1 # kafka topic name
            field: orderPaymentSucessful
            transformations:
              - type: DIRECT
                subtype: IDENTITY
      order_total:
        description: Total amount the smallest monetary unit (e.g., cents).
        type: long
        required: true
        example: "9999"
        lineage:
          inputFields:
          - namespace: kafka
            name: com.example.checkout.order.v1 # kafka topic name
            field: lineitems[].price
            transformations:
              - type: DIRECT
                subtype: AGGREGATION
                description: aggregated all line item prices
      customer_id:
        description: Unique identifier for the customer.
        type: text
        minLength: 10
        maxLength: 20
      customer_email_address:
        description: The email address, as entered by the customer.
        type: text
        format: email
        required: true
        pii: true
        classification: sensitive
        lineage:
          inputFields:
          - namespace: kafka
            name: com.example.checkout.order.v1 # kafka topic name
            field: emailAddress
            transformations:
              - type: DIRECT
                subtype: TRANSFORMATION
                masking: true

Implemented with 1.1.0


Pulsar Shell

Motivation
Pulsar shell is a new CLI tool that enables users to use pulsar-admin and pulsar-client CLI tool in a interactive way.
It's basically a wrapper of that tools that keep the session live. The following features are already implemented:

History
Autocompletion (command and options)

The implementation is backed by JLine3.
You can run pulsar-shell directly from bin directory and it doesn't take any arguments.
./bin/pulsar-shell

pulsar>
pulsar> admin topics stats mytopic
...
pulsar> client produce -m hello mytopic

The config scripts for admin and client are now aligned and used by all of three (pulsar-admin, pulsar-client, pulsar-shell)
TODO:

add javadoc for java files
add simple tests
docs ? maybe later

great work !
some questions:

history: where do you write the history ?
the history may contain sensitive data (tokens??) maybe we want an option to disable it ? (not strictly needed)
did you think about "pulsar-perf" ?

it would be useful to have a command that dumps the config, at least the http URL at which you are connecting to.
or maybe you can write it as welcome message.

history is handled by jline3 and it's in memory. You can configure a file path in order to keep history between sessions. I don't think it's necessary

I think that we should persist here, like when you use bash. otherwise you lose your commands when you close the session.
we can store the history by default in the user directory and have a flag to not store it
Chris B. talked about history explicitly

we can add persistent history as a follow up work, and make the file configurable in conf/client.conf  (the filename and enable/disable, and the filename should support some way of referring to the user directory or a ENV variable)

One challenge is to handle Control-C for the pulsar-client part, because you are killing the process.
Having persistent history will mitigate the problem.

That's true. I don't think there's a solution (haven't find yet). I agree that will fix it with persistent history


Release Acceptance Test

This will be used to test the release candidate before the final release.
Automated
unittests on js-ng and js-sdk in github actions
https://github.com/threefoldtech/js-ng/tree/development/tests
https://github.com/threefoldtech/js-sdk/tree/development/tests
Manual installation
From scratch

[x] ubuntu 20.04
[x] ubuntu 18.04
[x] mac
[x] windows

On a previous installation

[x] ubuntu
[x] mac
[x] windows

Wallets

[x] create
[x] import
[x] delete

Admin Dashboard

[x] network (#972)
[x] ubuntu (#971)
[x] kubernetes
[x] minio
[ ] master/slave minio
[x] expose solutions
[x] generic flist
[x] monitoring
[x] domain delegation
[x] 4 to 6 gateway (#978)

Marketplace

[x] wiki
[x] website
[x] blog
[x] Mattermost
[x] Peertube
[x] Discourse
[x] Cryptpad
[x] Taiga
[x] gitea

Reservations and payments:

[x] create capacity pool (#884, #924)
[x] extend capacity pool (#440)
[x] canceling reservations

Other functionality

[x] adding administrators
[x] removing admins from dashboard
[x] switching identities (#1011)
[x] logs
[x] alerts
[x] add package https://github.com/threefoldtech/js-sdk/issues/927 https://github.com/threefoldtech/js-sdk/issues/940
[x] remove package
[x] Developer options (#921)

working on fresh manual installation in ubuntu 18.04

Testing wallet ( Create, Delete, and import )

testing add and remove package.

Installation on mac

Installation on windows

working on Marketplace

@ramezsaeed  @rkhamis
yesterday, creating and extending capacity pools was tested, I thought it is done. Today I found that it's is changed https://github.com/threefoldtech/js-sdk/pull/874 , So I have to test it again.

WIKI

network

Ubuntu 18.04
wid: 473923

Ubuntu 20

kubernetets

Website

BLOG

Mattermost

Peertube

Gitea

Discourse

Cryptpad

Taiga

domain delegation

solution expose with custom domain

master/salve minio


Comparison checks needed to be defined for the NaN resulted from decimal operations

Description:
Spec says,
NaN, infinities and subnormals are not supported; operations that would result in one of these values according to the normal rules of IEEE 754-2008 instead result in a panic.

Since NaN can be resulted from the decimal operations, the equality, exact equality and comparison checks needed to be defined for NaN.
decimal nan = 0.0/0.0;

nan == nan
nan === nan

nan <= nan
nan < nan
na1 >= nan
nan > nan

Describe your task(s)
Related Issues (optional):
https://github.com/ballerina-platform/ballerina-lang/issues/17977
Suggested Labels (optional):
Team/jBallerina
Suggested Assignees (optional):

According to the standard we followed, decimal operations do not result in NaN.
Currently the following code results in NaN
import ballerina/io;

public function main() {
    decimal a = 0.0;
    decimal b = 0.0;
    decimal c = a/b;
    io:println(c);
}

It can be a bug and we suppose to need panic in those cases.

The following code results in a runtime crash
    float nan1 = 0.0 / 0.0;
    decimal nan = <decimal> nan1;

Need to check th constructors as well.


fix: typo on websocket error handling

this PR will fix a typo introduced in my previous PR #1327.

@mcallegari i'm also working on a new webaccess for QLC+, with better responsive support for mobile devices.
As soon as I have a beta version I will share with you. :)
Many thanks for all your work with this application for all this years


[1498] Fix / replace availability calendar [master]

Resolves #1498 on master

add FullCalendar-based availability calendar
move availability calculations to private controller method
add controller specs for availability
remove legacy calendar code

@esoterik ready for a second look / response :smile:

Okay, I think this is good

Great, merging!


using System.Collections.Generic

https://github.com/Creuna-Oslo/prop-types-csharp-webpack-plugin/blob/9c478e9539f7bf7342abf37b3e7d4670a21d7693/source/utils/generate-csharp.js#L13
If this using is for IList, then it should be using System.Collections.Generic;

But you told me that System.Collections was correct last time! 😮
I'll fix


Missing error message in case of configuration issue

This is the test content of a parameter configuration file of the TestsuitesManagement:
"params" : {
            "global": {
                         "testparam" : "paramvalue",

In case of I make the top level "params" invalid by
"paramsZZZ" : {
I get a schema validation error (like expected).
But if I make the level below invalid by
"params" : {
            "globalZZZ": {

Then I get this error: Variable '${testparam}' not found.
And this is plausible because during test execution the variable testparam is used.
But what makes me worried is that I do not get a schema validation error telling me that "global" is missing.
Because "params/global" variables are referred by
${testparam}
in tests, and not by
${params}['global']['testparam']
And this means that "global" is mandatory. The user is not free to use any other key name at this position in configuration file.
If "global" is missing I would prefer to have a corresponding error message. Test execution should end with UNKNOWN in this case.

Hello Holger,
Thank you for your finding!
I implemented this ticket and pushed the change 41cde40ae7df2 to stabi branch.
Could you please help me verify again!
Thank you,
Son

Hi Son,
now the error message is:
Required parameter 'global' is missing in 'params' property in file ...
We should avoid this additional term 'property'. What is a property in this context?
Maybe this can be an alternative:
Required parameter 'global' is missing under 'params' in file ...

Hello Holger,
Thank you for your suggestion! I updated on stabi branch.
Thank you,
Son

Retest successful. Issue can be closed.

integrated in 0.12.1


Package Manager Support

Are there any plans to support Bower or NPM for the Tealium files?

+1

Here is a sample bower.json file for this package. Feel free to edit as you see necessary.
{
  "name": "angular-tealium",
  "description": "Tealium AngularJS Integration",
  "main": [
    "./tealium.js",
    "./tealium_data.js",
    "./tealium_directive.js"
  ],
  "dependencies": {
    "angular": ">=1.3.0"
  },
  "ignore": [],
  "keywords": [
    "tealium",
    "tags",
    "analytics",
    "angular"
  ],
  "license": "MIT",
  "repository": {
    "type": "git",
    "url": "git://github.com/Tealium/integration-angularjs.git"
  }
}

@tygavin is this request something you are willing to support?

@ReidBraswell We definitely need this.  If you'd like to submit a pull request, I'll merge it in.

@tygavin I'd be happy to do that, but you'll have to run a bower register to officially register it with the Package Manager. Does the bower.json file I put in the above comments look ok?

@ReidBraswell Looks good to me.  Thanks again.  I should be able to register following these instructions:
http://bower.io/docs/creating-packages/

@tygavin is there a specific order for the JavaScript files? Looking at the /sample directory, it appears that tealium_data.js is loaded before tealium.js. Is that required?

@ReidBraswell Looks like it works.  Thanks for putting this together:
$ bower register angular-tealium https://github.com/Tealium/integration-angularjs
bower angular-tealium#*        resolve https://github.com/Tealium/integration-angularjs#*
bower angular-tealium#*       download https://github.com/Tealium/integration-angularjs
bower angular-tealium#*       resolved https://github.com/Tealium/integration-angularjs
? Registering a package will make it installable via the registry (https://bower.herokuapp.com), continue? Yes
bower angular-tealium         register https://github.com/Tealium/integration-angularjs

Package angular-tealium registered successfully!
All valid semver tags on https://github.com/Tealium/integration-angularjs will be available as versions.
To publish a new version, just release a valid semver tag.

Run bower info angular-tealium to list the available versions.

@tygavin when you published the package with Bower, did you update your local repo with the latest from my merged PR?

@ReidBraswell Yes.. definitely feel free to do another pull request if any updates needed.
http://bower.io/search/?q=angular-tealium
https://github.com/Tealium/integration-angularjs/blob/master/bower.json

@ReidBraswell
I think I see the issue.. I just added a new version and did a "bower info"
bower info angular-tealium
bower angular-tealium#*         cached https://github.com/Tealium/integration-angularjs.git#1.1.1
bower angular-tealium#*       validate 1.1.1 against https://github.com/Tealium/integration-angularjs.git#*
bower angular-tealium#*            new version for https://github.com/Tealium/integration-angularjs.git#*
bower angular-tealium#*        resolve https://github.com/Tealium/integration-angularjs.git#*
bower angular-tealium#*       checkout v1.1.2
bower angular-tealium#*   invalid-meta The "main" field has to contain only 1 file per filetype; found multiple .js files: ["tealium_data.js","tealium.js","tealium_directive.js"]
bower angular-tealium#*       resolved https://github.com/Tealium/integration-angularjs.git#1.1.2

Maybe need to use something like "files" instead of main?
https://github.com/bower/spec/issues/47

Yeah I can see that now. I missed that in the spec earlier. My apologies. One thought would be to have either an index.js or main.js file that imports the other files. Thoughts?

I'm tempted to just combine the 3 files into a single "tealium_angular.js" file.

@tygavin any updates? Did you decide to combine the 3 files into a single one?

@evandam Any strong opinions on consolidation of the 3 core .js files into one .js file? There might be a few minor benefits to having one core file -- better gzip benefit and fewer HTTP requests for those who just use out-of-the-box.

@tygavin I've actually been working with a separate version of this with my team, where we consolidated to a single file. I tend to agree that this is the best way to go.

@evandam @ReidBraswell Great, thank you both.  I'll make this update and release a new version.

@tygavin One thing I noticed while reviewing the files - probably an initial miss on my part. When these are merged into a single file, it should probably be wrapped in a closure to avoid polluting the global scope. It declares an "app" variable, which would likely clash with other global variables. Thanks!

@evandam Agreed.  Fixing as we speak.

@tygavin thanks for making the changes. I was able to pull in your changes and everything is looking good.
Separate question, can you point me in the direction of the best resource to know what attributes can be passed to a data-tealium object?

Thank you, Reid.  The short answer to your question is you can pass anything you want.  Tealium's data layer is completely flexible.  In Tealium iQ you can map your data layer to your tag vendor.
That said, we do have a standard best practice data layer for easier troubleshooting across accounts.  You should be able to find information in the Tealium Community or request from your Account Manager.


"Lua diagnostics: Need check nil" diagnostic not consistently shown.

How are you using the lua-language-server?
NeoVim
Which OS are you using?
MacOS
What is the issue affecting?
Diagnostics/Syntax Checking
Expected Behaviour
I would like Lua LS to show same warning message on similar cases.
Actual Behaviour

I have this code to exit if require fails:

-- Exit if can't load module(s)
local cmp_status_ok, cmp = pcall(require, "cmp")
if not cmp_status_ok then
  print("Couldn't require module 'cmp'.")
  return
end

... then down file, every time I call cmp, Neovim shows diagnostic warning "Lua diagnostics: Need check nil", for example here. Also see screenshot:

cmp.setup({
  snippet = {
    expand = function(args)
      vim.fn["vsnip#anonymous"](args.body) -- For `vsnip` users.
    end,
  },

HOWEVER, in the very same file, I also have other lines,  exactly same form and use that do not show such diagnostic warning:

local status_ok, lspkind = pcall(require, "lspkind")
if not status_ok then
  print("Couldn't require module 'lspkind'.")
  return
end

lspkind.init({
  mode = "symbol_text",
  symbol_map = {
    Text = " ",
    Method = " ",
...

Reproduction steps

Have similar code and hopefully, you will get same error.

Additional Notes

nvim version:

NVIM v0.8.0-dev-818-g0d9e09bf6
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

macos 12.5

Log File
❯ tail -10 .cache/nvim/lsp.log
[START][2022-08-10 21:59:01] LSP logging initiated
[START][2022-08-12 15:20:05] LSP logging initiated
[START][2022-08-14 13:56:27] LSP logging initiated
[START][2022-08-14 13:57:46] LSP logging initiated
[START][2022-08-14 14:01:01] LSP logging initiated
[START][2022-08-14 14:55:19] LSP logging initiated
[START][2022-08-15 17:31:08] LSP logging initiated
[START][2022-08-15 17:32:26] LSP logging initiated
[START][2022-08-15 20:38:17] LSP logging initiated
[START][2022-08-20 09:04:46] LSP logging initiated

~
❯
❯ tail -10 .cache/nvim/null-ls.log
[ERROR Sun Jul 10 21:10:37 2022] ...t/null-ls.nvim/lua/null-ls/helpers/generator_factory.lua:180: command stylua is not executable (make sure it's installed and on your $PATH)
❯

~
❯

By the way, I got latest neovim nightly version, same result: https://imgur.com/a/FxVIldH

This situation does not support analysis, you can only use @cast cmp -? to mark.

...  you can only use @cast cmp -? to mark.

I'm sorry I do not know what you mean, can you explain?

local cmp_status_ok, cmp = pcall(require, "cmp")
if not cmp_status_ok then
  print("Couldn't require module 'cmp'.")
  return
end

---@cast cmp -?

-? means remove nil from cmp in inferring after this line.
See https://github.com/sumneko/lua-language-server/wiki/Annotations#cast

```lua
local cmp_status_ok, cmp = pcall(require, "cmp")
if not cmp_status_ok then
  print("Couldn't require module 'cmp'.")
  return
end

---@cast cmp -?

-? means remove nil from cmp in inferring after this line.
See https://github.com/sumneko/lua-language-server/wiki/Annotations#cast

workaround accepted and thanks for the education on ---@cast

The workaround works for me, but I'm confused why only cmp has this issue in my dotfiles as well? What's special about cmp that any usages after a require cause the the Need check nil diagnostic?

I have a similar problem, but different: in my case it is consistently not showing any warning at all. For example running the following snippet
---Tells whether a table is something and gives details in case yes
---@param aCollection table
---@return boolean
---@return string | nil
local function isSomething(aCollection)
    for key, val in pairs(aCollection) do
        if val > 10 then
            return true, key
        end
    end
    return false, nil
end

local t = { 1, 2, 3 }
local _, aKey = isSomething(t)
print("the value is " .. aKey)

results in an error attempt to concatenate a nil value (local 'aKey') which makes sense...but I would like the "Lua diagnostics: Need check nil" warning to pop up, thus forcing me to both run the verification and add the cast.
The strange part is that I do get other diagnostics warnings, e.g. "Global variable in lowercase initial, Did you miss local or misspell it?...hence, is there any additional extension required that I might be missing? Or a setting that I might need to fix/update? I am facing this on vscode, on Windows 10.


Failing with Ollama after 6 Retries

Bug description
I'm trying to run a simple setup with Ollama. Whenever I run it I get failures.
Bug solved method
I've not been able to work around this issue.
My config2.yaml contains the following:
llm:
  api_type: 'ollama'
  base_url: 'http://localhost:11434/api'
  model: 'llama2:latest'

Environment information

LLM type and model name: Ollama, llama2
System version: OSX 14.5
Python version: 3.10.12
MetaGPT version or branch: 0.8.1
packages version: pip 23.0.1
installation method: pip install metagpt

Screenshots or logs
Here's the log for the failure:
Anything UNCLEAR:
Please clarify the third-party API integration, as it is unclear how to proceed with this aspect of the project.
2024-07-05 08:16:09.942 | WARNING  | metagpt.utils.cost_manager:update_cost:49 - Model llama2 not found in TOKEN_COSTS.
2024-07-05 08:16:09.943 | WARNING  | metagpt.utils.repair_llm_raw_output:extract_content_from_output:320 - extract_content try another pattern: \[CONTENT\]([\s\S]*)\[/CONTENT\]
2024-07-05 08:16:09.943 | WARNING  | metagpt.utils.repair_llm_raw_output:run_and_passon:268 - parse json from content inside [CONTENT][/CONTENT] failed at retry 1, exp: Expecting value: line 1 column 1 (char 0)
2024-07-05 08:16:09.944 | INFO     | metagpt.utils.repair_llm_raw_output:repair_invalid_json:237 - repair_invalid_json, raw error: Expecting value: line 1 column 1 (char 0)
2024-07-05 08:16:09.944 | ERROR    | metagpt.utils.common:log_it:554 - Finished call to 'metagpt.actions.action_node.ActionNode._aask_v1' after 350.868(s), this was the 5th time calling it. exp: RetryError[<Future at 0x1370446a0 state=finished raised JSONDecodeError>]
Understood! I will follow your instructions and generate the output in the requested format. Please provide me with the content for each node, and I will take care of the rest.
2024-07-05 08:16:20.965 | WARNING  | metagpt.utils.cost_manager:update_cost:49 - Model llama2 not found in TOKEN_COSTS.
2024-07-05 08:16:20.967 | WARNING  | metagpt.utils.repair_llm_raw_output:extract_content_from_output:320 - extract_content try another pattern: \[CONTENT\]([\s\S]*)\[/CONTENT\]
2024-07-05 08:16:20.967 | WARNING  | metagpt.utils.repair_llm_raw_output:run_and_passon:268 - parse json from content inside [CONTENT][/CONTENT] failed at retry 1, exp: Expecting value: line 1 column 1 (char 0)
2024-07-05 08:16:20.967 | INFO     | metagpt.utils.repair_llm_raw_output:repair_invalid_json:237 - repair_invalid_json, raw error: Expecting value: line 1 column 1 (char 0)
2024-07-05 08:16:20.967 | ERROR    | metagpt.utils.common:log_it:554 - Finished call to 'metagpt.actions.action_node.ActionNode._aask_v1' after 361.891(s), this was the 6th time calling it. exp: RetryError[<Future at 0x137044820 state=finished raised JSONDecodeError>]
2024-07-05 08:16:20.968 | WARNING  | metagpt.utils.common:wrapper:649 - There is a exception in role's execution, in order to resume, we delete the newest role communication message in the role's memory.
2024-07-05 08:16:20.988 | ERROR    | metagpt.utils.common:wrapper:631 - Exception occurs, start to serialize the project, exp:
Traceback (most recent call last):
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/tenacity/__init__.py", line 382, in __call__
    result = fn(*args, **kwargs)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/utils/repair_llm_raw_output.py", line 296, in retry_parse_json_text
    parsed_data = CustomDecoder(strict=False).decode(output)
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/tenacity/_asyncio.py", line 50, in __call__
    result = await fn(*args, **kwargs)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/actions/action_node.py", line 425, in _aask_v1
    parsed_data = llm_output_postprocess(
tenacity.RetryError: RetryError[<Future at 0x137044820 state=finished raised JSONDecodeError>]

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/utils/common.py", line 640, in wrapper
    return await func(self, *args, **kwargs)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/roles/role.py", line 550, in run
    rsp = await self.react()
tenacity.RetryError: RetryError[<Future at 0x137045fc0 state=finished raised RetryError>]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/utils/common.py", line 626, in wrapper
    result = await func(self, *args, **kwargs)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/team.py", line 134, in run
    await self.env.run()
Exception: Traceback (most recent call last):
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/tenacity/__init__.py", line 382, in __call__
    result = fn(*args, **kwargs)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/utils/repair_llm_raw_output.py", line 296, in retry_parse_json_text
    parsed_data = CustomDecoder(strict=False).decode(output)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/utils/custom_decoder.py", line 297, in decode
    return super().decode(s)
  File<EMAIL_ADDRESS>line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File<EMAIL_ADDRESS>line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/tenacity/_asyncio.py", line 50, in __call__
    result = await fn(*args, **kwargs)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/actions/action_node.py", line 425, in _aask_v1
    parsed_data = llm_output_postprocess(
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/provider/postprocess/llm_output_postprocess.py", line 19, in llm_output_postprocess
    result = postprocess_plugin.run(output=output, schema=schema, req_key=req_key)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/provider/postprocess/base_postprocess_plugin.py", line 68, in run
    new_output = self.run_repair_llm_output(output=output, schema=schema, req_key=req_key)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/provider/postprocess/base_postprocess_plugin.py", line 32, in run_repair_llm_output
    parsed_data = self.run_retry_parse_json_text(content)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/provider/postprocess/base_postprocess_plugin.py", line 47, in run_retry_parse_json_text
    parsed_data = retry_parse_json_text(output=content)  # should use output=content
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/tenacity/__init__.py", line 289, in wrapped_f
    return self(f, *args, **kw)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/tenacity/__init__.py", line 379, in __call__
    do = self.iter(retry_state=retry_state)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/tenacity/__init__.py", line 326, in iter
    raise retry_exc from fut.exception()
tenacity.RetryError: RetryError[<Future at 0x137044820 state=finished raised JSONDecodeError>]

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/utils/common.py", line 640, in wrapper
    return await func(self, *args, **kwargs)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/roles/role.py", line 550, in run
    rsp = await self.react()
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/roles/role.py", line 517, in react
    rsp = await self._react()
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/roles/role.py", line 463, in _react
    rsp = await self._act()
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/roles/role.py", line 392, in _act
    response = await self.rc.todo.run(self.rc.history)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/actions/design_api.py", line 58, in run
    doc = await self._update_system_design(filename=filename)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/actions/design_api.py", line 86, in _update_system_design
    system_design = await self._new_system_design(context=prd.content)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/actions/design_api.py", line 73, in _new_system_design
    node = await DESIGN_API_NODE.fill(context=context, llm=self.llm)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/actions/action_node.py", line 505, in fill
    return await self.simple_fill(schema=schema, mode=mode, images=images, timeout=timeout, exclude=exclude)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/metagpt/actions/action_node.py", line 457, in simple_fill
    content, scontent = await self._aask_v1(
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/tenacity/_asyncio.py", line 88, in async_wrapped
    return await fn(*args, **kwargs)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/tenacity/_asyncio.py", line 47, in __call__
    do = self.iter(retry_state=retry_state)
  File "/Users/ken/devel/ai/agents/metagpt_novel/.venv/lib/python3.10/site-packages/tenacity/__init__.py", line 326, in iter
    raise retry_exc from fut.exception()
tenacity.RetryError: RetryError[<Future at 0x137045fc0 state=finished raised RetryError>]

duplicate of https://github.com/geekan/MetaGPT/issues/1340.


Update of URIs for two remote data bases in perl scripts

To check the perl scripts go to the auxil subdirectory and call them as
./astorb2edb.pl -f 000
and
./mpcorb2edb.pl -f 001
which should create two files 000* and two files 001* in the local directory if downloading works. These files created by the two perl scripts are not part (and should not become part) of the github source. Note that downloading may take a while in both cases.
An equivalent check is to call xephem, the Data submenu and to click of one of the last two Get buttons...

The help file in the downloads section is calling out the wrong perl scripts (?).  I think that these are the scripts the help file is referring to in the last paragraph. Looks like older versions of the scripts are named.  Also, the help file has several links in this paragraph that need to be updated similar to the  "ftp" in the perl script.  For me they are crashing with an ftp call (no program associated with ftp protocol) or are inactive. Either fix the urls or remove the hyperlinks and keep it as normal text.
Need to update the help file if I am correct.

Good morning! I might have missed the notification for this pull request getting opened in October (I was out of town on that day) — apologies that I made no response. If you would like to re-open it, this looks like a useful improvement.

I tried to resolve a conflict where github thought there was one (related to the other pull issue), with git, with all variants of pulls and pushes which created a mess in both github.com and my own local copy. The git commands and how they effect local, remote, forked and branched copies of the program remain a mystery to me. Since this was an unimportant issue, and I cannot spend days of googling how that might have been done, I resolved this by deleting the XEphem git on my computer and the github.com branch. RIP.

@rmathar — Is the diff visible here (ignoring xephem.html) the change you wanted to make?
https://github.com/XEphem/XEphem/pull/30/files
I’ve just pulled it to my laptop here, and could land that change for you if you want me to! (And, yes, git is pretty terrible and makes it easy for users to tie their repository up in knots.)

@rmathar — The diff looked reasonable to me, so I've committed it, under your name as the author. Let me know if any of the lines came out wrong, and I can fix them:
aaaea1edc5783fc30906ecd17ef7d4a4f3cc00cd
Thanks for the contribution!

The current code has a repeated "https:" indicator in lines 236 and 237 of astorb2edb.pl (this was one another reason why I wanted to edit my code...), because variable set in line 79 already has it. So the "https://" in line 236 and 237 of astorb2edb.pl should be removed.

Thanks, I've attempted a quick fix:
https://github.com/XEphem/XEphem/commit/426a7bbe213bb0a769619bdbf49c60065f5e4344


fix: typography overflow inside the table

SPT-2405
Description
Fix typography overflow inside the table.
Even if the text fits the table cell on the current implementation, the tooltip is visible.
AC: The tooltip shouldn't be visible if the text fits.
Notes: For some reason, the FONT_RENDER_CORRECTION doesn't work anymore inside the table, and the height part was affected.
How to test

Code to test

import React from 'react'
import { Table, TypographyOverflow } from '@toptal/picasso'

const Example = () => (

    <Table>
      <Table.Head>
        <Table.Row>
          <Table.Cell>Name</Table.Cell>
          <Table.Cell>Name</Table.Cell>
        </Table.Row>
      </Table.Head>
      <Table.Body>
        <Table.Row>
          <Table.Cell style={{width: "200px", maxWidth: "200px"}}>
            <TypographyOverflow>
              Lorem ipsum dolor sit amet, consectetur adipiscing elit.
            </TypographyOverflow>
          </Table.Cell>

          <Table.Cell>Name</Table.Cell>

        </Table.Row>
      </Table.Body>
    </Table>
)

export default Example

Screenshots

Before.
After.

Review

[x] Read CONTRIBUTING.md and Component API principles
[ ] Annotate all props in component with documentation
[ ] Create examples for component
[ ] Ensure that deployed demo has expected results and good examples
[ ] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

please also dont forgot about changeset

please also dont forgot about changeset

@TomasSlama done :+1:

Hey @sergiubutnarasu, in my first comment I asked if you can do some tests and maybe even add examples in the storybook, so we cover this unusual behavior in tables next time. 🙏

I have added new example of Table to storybook, you can see, that it is not working correctly in all cases. Thanks @denieler for pointing it out.
https://user-images.githubusercontent.com/6830426/154247472-80b53b7b-29f5-4df5-ac44-897b3a60f1d5.mp4

I have added new example of Table to storybook, you can see, that it is not working correctly in all cases. Thanks @denieler for pointing it out.
table.example.mp4

@TomasSlama so maybe this one it's another bug, right?


Slow first RPC in MargoConnector

Describe the problem.
The first RPC to a newly spawned MargoServer takes >1 minute. In the integration tests, the first RPC is an "exists" call in wait_for_server to check if the MargoServer is responding yet.
After the first slow RPC, the remaining RPCs to the server are fast. We need to either debug this or figure out an alternate way of "pinging" the server.
How did you install ProxyStore?
N/A

ProxyStore Version
v0.5.0dev1
Python Version
All
OS and Platform
x86 Linux

Some quick debugging reveals that the issue is that it can take Margo as much as 90 seconds to determine that a server is not accessible when invoking the RPC we use to "ping" a server.
What we need is a faster way to detect if a server exists.
(venv37) root@docker-desktop:/proxystore# python t.py
t.py:1: ExperimentalWarning: The proxystore.connectors.dim module is experimental and may be moved to the proxystore-extensions package in the future.
  from proxystore.connectors.dim.margo import MargoConnector
2023-05-13 16:06:40,293 Connecting to local server (address=tcp://<IP_ADDRESS>:1234)...
2023-05-13 16:06:40,405 CREATED ENGINE
2023-05-13 16:06:40,405 REGISTERED EXISTS
2023-05-13 16:06:40,405 LOOKUP tcp://<IP_ADDRESS>:1234
2023-05-13 16:08:10,413 Failed to connect to local server (address=tcp://<IP_ADDRESS>:1234, timeout=10.0)
2023-05-13 16:08:10,416 Registered server cleanup atexit callback
2023-05-13 16:08:10,428 CREATED ENGINE
2023-05-13 16:08:10,428 REGISTERED EXISTS
2023-05-13 16:08:10,428 LOOKUP tcp://<IP_ADDRESS>:1234
/proxystore/t.py:1: ExperimentalWarning: The proxystore.connectors.dim module is experimental and may be moved to the proxystore-extensions package in the future.
  from proxystore.connectors.dim.margo import MargoConnector
STARTING ================
2023-05-13 16:08:10,481 COMPLETE RPC
2023-05-13 16:08:10,481 Server started (address=tcp://<IP_ADDRESS>:1234, pid=533)
2023-05-13 16:08:10,481 Spawned local server (address=tcp://<IP_ADDRESS>:1234)
put
2023-05-13 16:08:10,481 Sent PUT RPC (key=DIMKey(dim_type='margo', obj_id='299a847e-36c6-4e2e-922e-9d51c324964e', size=4, peer_host='<IP_ADDRESS>', peer_port=1234))
2023-05-13 16:08:10,489 Received PUT RPC response (key=DIMKey(dim_type='margo', obj_id='299a847e-36c6-4e2e-922e-9d51c324964e', size=4, peer_host='<IP_ADDRESS>', peer_port=1234), exception=False)
2023-05-13 16:08:10,489 Sent GET RPC (key=DIMKey(dim_type='margo', obj_id='299a847e-36c6-4e2e-922e-9d51c324964e', size=4, peer_host='<IP_ADDRESS>', peer_port=1234))
2023-05-13 16:08:10,489 Received GET RPC response (key=DIMKey(dim_type='margo', obj_id='299a847e-36c6-4e2e-922e-9d51c324964e', size=4, peer_host='<IP_ADDRESS>', peer_port=1234), exception=False)
b'data'
2023-05-13 16:08:10,599 Terminated local server on connector close (pid=533)
2023-05-13 16:08:10,791 Closed Margo connector
done
2023-05-13 16:08:10,791 Server terminated on parent process exit (pid=533)


[BUG] routePrefix cannot be non-empty for FastAPI to work with ASGI Function on Python v2

Investigative information
Please provide the following:

Timestamp: 2023-08-28T22:49:33+00:00
Function App name:
Function name(s) (as appropriate):
Core Tools version: 4.0.5274

Repro steps
Provide the steps required to reproduce the problem:

Start a new Azure Function app with the following command: func init <> --worker-runtime python --model V2
In function_app.py, create a new  ASGI Function App with the following code:

import azure.functions as func
import logging

from fastapi import FastAPI

api = FastAPI()

@api.get("/")
def root():
    return {"message": "Hello World"}

@api.get("/healthcheck")
def healthcheck():
    return 1

app = func.AsgiFunctionApp(
    app=api,
    http_auth_level=func.AuthLevel.ANONYMOUS
)

Add fastapi to requirements.txt (currently on 0.103.0)
Add the following to host.json:

"extensions": {
    "http": {
      "routePrefix": "api"
    }
  }

Run func start using core tools from cli

Expected behavior
Provide a description of the expected behavior.

Should be able to access http://localhost:7071/api with no issue.
Actual behavior
Provide a description of the actual behavior observed.
Following error is received:
❯ func start
Found Python version 3.10.11 (py).

Azure Functions Core Tools
Core Tools Version:       4.0.5274 Commit hash: N/A  (64-bit)
Function Runtime Version: <IP_ADDRESS>86

[2023-08-28T23:02:24.316Z] Worker process started and initialized.
[2023-08-28T23:02:24.385Z] A host error has occurred during startup operation 'a87fe4da-9c2c-4dd7-958f-c9b73021ea2c'.
[2023-08-28T23:02:24.387Z] Microsoft.AspNetCore.Routing: An error occurred while creating the route with name 'http_app_func' and template 'api//{*route}'. Microsoft.AspNetCore.Routing: The route template separator character '/' cannot appear consecutively. It must be separated by either a parameter or a literal value. (Parameter 'routeTemplate'). Microsoft.AspNetCore.Routing: The route template separator character '/' cannot appear consecutively. It must be separated by either a parameter or a literal value.
[2023-08-28T23:02:24.399Z] Failed to stop host instance '4b8b0863-dcb1-4a41-9b70-0beaad496108'.
[2023-08-28T23:02:24.401Z] Microsoft.Azure.WebJobs.Host: The host has not yet started.
Value cannot be null. (Parameter 'provider')
[2023-08-28T23:02:24.409Z] Host startup operation has been canceled

Known workarounds
Provide a description of any known workarounds.
Only workaround is to make the routePrefix in host.json an empty string.
{
  "version": "2.0",
  "logging": {
    "applicationInsights": {
      "samplingSettings": {
        "isEnabled": true,
        "excludedTypes": "Request"
      }
    }
  },
  "extensionBundle": {
    "id": "Microsoft.Azure.Functions.ExtensionBundle",
    "version": "[4.*, 5.0.0)"
  },
  "extensions": {
    "http": {
      "routePrefix": ""
    }
  }
}

Contents of the requirements.txt file:
Provide the requirements.txt file to help us find out module related issues.

azure-functions
fastapi==0.103.0

Related information
Provide any related information

Links to source
Bindings used

Source
# __init__.py

import azure.functions as func
import logging

from fastapi import FastAPI

api = FastAPI()

@api.get("/")
def root():
    return {"message": "Hello World"}

@api.get("/healthcheck")
def healthcheck():
    return 1

app = func.AsgiFunctionApp(
    app=api,
    http_auth_level=func.AuthLevel.ANONYMOUS
)

azure-functions
fastapi==0.103.0

Thanks for informing.As I check  the steps and code provided its working fine:

There is no need to keep  routePrefix="" empty.

Can confirm this behaviour. Only works with an empty string for routePrefix.
However, if routePrefix is empty in the host.json, then the GitHub action static-web-apps-deploy@v1 will throw:

Error in processing api build artifacts: the host.json file cannot specify a http.routePrefix value other than 'api'.

Because all endpoints should be defined with api/.
In other words: Azure Functions + fastAPI + v2 Python model + Azure Static Web App does currently not work.

Can confirm this behaviour. Only works with an empty string for routePrefix.
However, if routePrefix is empty in the host.json, then the GitHub action static-web-apps-deploy@v1 will throw:

Error in processing api build artifacts: the host.json file cannot specify a http.routePrefix value other than 'api'.

Because all endpoints should be defined with api/.
In other words: Azure Functions + fastAPI + v2 Python model + Azure Static Web App does currently not work.

Not sure this helps anyone but if you deploy the backend as a separate function app, you can set the prefix to an empty string and make everything work.

@pietz Could you share how to remove the thrown error? After removing, will it work after static-web-apps-deploy@v1?

Can this issue get more attention please? Not being able to lift & shift your fastAPI (or any other?) application is such an bummer..

Any update on this...?

For the being I manually patched this by removing the excess "/" in route="/{*route}" in http_app_func's decorator under the AsgiFunctionApp class. It's a terrible solution. I hope this is fixed soon.

@bhagyshricompany
Any updates? This ought to be fixed sooner than later.

I just ignore routePrefix in host.json, and use 'route_path' in FastAPI or 'prefix' in APIRouter
hope this helps

@eddison-shyi
Could you elaborate on how you 'ignore routePrefix' and what you do in FastAPI using config file / code examples?

@eddison-shyi
Could you elaborate on how you 'ignore routePrefix' and what you do in FastAPI using config file / code examples?

Sure, it's my pleasure~
Let's say, we want to have 1 or more path prefix, like /api or something else. To achieve this, keep host.json "extension" with only following:
  "extensions": {
    "http": {
        "routePrefix": ""
    }
  },

and use APIRouter with argument: prefix (or declare "root_path" when FastAPI init if you need to make it global), instead of using "routePrefix"
from fastapi import APIRouter

router = APIRouter(prefix="/api", tags=["HmmIMightBeAPI"])

then use "router" in decorator (will get same url)
@router.get("/my-identity", name="Show you who I am")
async def show_my _identity(request: Request):
 pass

now, you can access this api through "https://{base}/api/my-identity"

@eddison-shyi
Are you using CI/CD such as github actions or Azure Pipelines? In which way?
The problem is that the deployment task doesn't allow "routePrefix": "", as explained above.

@eddison-shyi
The issue is that "routePrefix" is used for ingress configuration for your App Services. It means you can deploy several App Services under the same hostname, e.g.: your FastAPI backend available under https://<host>/api ("routePrefix": "api"), and second static content server (frontend) under https://<host>/.
My workaround is to monkey patch the AsgiFunctionApp like that:
# asgi_function_app.py

from typing import Union

import azure.functions as func
from azure.functions._abc import Context
from azure.functions._http_asgi import AsgiMiddleware
from azure.functions._http_wsgi import WsgiMiddleware
from azure.functions.decorators.http import HttpMethod
from azure.functions.http import HttpRequest

class AsgiFunctionApp(func.AsgiFunctionApp):
    def _add_http_app(
        self, http_middleware: Union[AsgiMiddleware, WsgiMiddleware]
    ) -> None:
        """Add an Asgi app integrated http function.

        :param http_middleware: :class:`WsgiMiddleware`
                                or class:`AsgiMiddleware` instance.

        :return: None
        """
        if not isinstance(http_middleware, AsgiMiddleware):
            raise TypeError("Please pass AsgiMiddleware instance" " as parameter.")

        asgi_middleware: AsgiMiddleware = http_middleware

        @self.http_type(http_type="asgi")
        @self.route(
            methods=(method for method in HttpMethod),
            auth_level=self.auth_level,
            route="{*route}",
        )
        async def http_app_func(req: HttpRequest, context: Context):
            if not self.startup_task_done:
                success = await asgi_middleware.notify_startup()
                if not success:
                    raise RuntimeError("ASGI middleware startup failed.")
                self.startup_task_done = True

            return await asgi_middleware.handle_async(req, context)

The code is copy-pasted from AsgiFunctionApp._add_http_app and I just changed the route="{/*route}" to route="{*route}".
Use this class to create your function app:
# function_app.py

import azure.functions as func
from fastapi import APIRouter, FastAPI

from asgi_function_app import AsgiFunctionApp

fast_api = FastAPI(
    docs_url="/api/docs",
    openapi_url="/api/openapi.json",
)

api_router = APIRouter(prefix="/api")

@api_router.get("/")
def index():
    return "Hello world!"

fast_api.include_router(api_router)

app = AsgiFunctionApp(app=fast_api, http_auth_level=func.AuthLevel.ANONYMOUS)

I'm seeing this same issue with all ASGI Functions Apps (not just FastAPI).
If I don't change routePrefix in host.json, I get the error:

An error occurred while creating the route with name 'http_app_func' and template 'api//{*route}'. Microsoft.AspNetCore.Routing: The route template separator character '/' cannot appear consecutively.

I don't know where the extra slash is coming from, it seems it has something to do with the route template in the _add_http_app as @gawronA  and @seidnerj  pointed out. However I think that's just a side-effect.
Note, the workaround to change routePrefix to empty string "" does work, however I see this in the verbose logs:

Functions:
http_app_func: [GET,POST,DELETE,HEAD,PATCH,PUT,OPTIONS] http://localhost:7071//{*route}

Notice the double slash // is still there. This causes problems when integrating the the API into Azure API Manager (APIM), because APIM can query the HTTP triggers from the Function App, it gets these triggers with the double slash and it auto-generates broken APIM routes.

Running into the same issue currently and it's blocking my SWA setup as well (see issue mentioned above).

I'm seeing this same issue with all ASGI Functions Apps (not just FastAPI).
If I don't change routePrefix in host.json, I get the error:

An error occurred while creating the route with name 'http_app_func' and template 'api//{*route}'. Microsoft.AspNetCore.Routing: The route template separator character '/' cannot appear consecutively.

I don't know where the extra slash is coming from, it seems it has something to do with the route template in the _add_http_app as @gawronA and @seidnerj pointed out. However I think that's just a side-effect.
Note, the workaround to change routePrefix to empty string "" does work, however I see this in the verbose logs:

Functions:
http_app_func: [GET,POST,DELETE,HEAD,PATCH,PUT,OPTIONS] http://localhost:7071//{*route}

Notice the double slash // is still there. This causes problems when integrating the the API into Azure API Manager (APIM), because APIM can query the HTTP triggers from the Function App, it gets these triggers with the double slash and it auto-generates broken APIM routes.

Seeming the same issue. Following...


The reason of continuous feature is better than discrete feature is before the codebook size is small?

check: https://github.com/TencentARC/Open-MAGVIT2/

Hi, increasing the codebook size and the number of tokens to represent an image may improve the performance. In the setting of using MAGVITv2, I think discrete tokens can achieve comparable performance to that of continuous representations.


Proper BYE for double elimination

Improved a bit on BYEs so it support double elimination.

Hey RollingWolf, do you have an example object with the BYE?
Also, what do you do in the case of an odd number of teams in a tournament?
thanks!


Update Files to Complete Extension Migration

@Shahiem this is a to-do list we can all work on with you as far as completing the migration to ReFlar goes for this extension:
Needs to meet ReFlar styling and standards:

[x] Update composer.json
[x] Update namespaces.
[x] Update packagist information.
[x] Update README.md.
[ ] Assess database constraints due to migration issues.

I think #6 finishes this up.

Packagist is the last thing we need

IMO should update packaging when new version rolls out

@Shahiem can you give us permissions to edit for https://packagist.org/packages/treefiction/polls ?

@Shahiem can you give us permissions to edit for https://packagist.org/packages/treefiction/polls ?
Add the following users (us):
datitisev, issyrocks12, and Ralkage

@Ralkage: Done :) You should have permission to edit now

@datitisev excellent 👏 👏
@Shahiem is the last item on this list still an issue? I remember it was discussed with Luceos but I'm not sure if you solved that issue in a recent update.

I finished this is #17, will be included in 1.0.0-beta.1


RuntimeError: Given input size: (3x1024x512). Calculated output size: (3x1x0). Output size is too small

Hello, thank you for a job well done.
When I test my images,the error is :
RuntimeError: Given input size: (3x1024x512). Calculated output size: (3x1x0). Output size is too small

Can you provide your detailed procedure, please?

@kackbob Can you provide your detailed procedure, please?


👾 some optimizations and docs fixes

Codecov Report

Merging #26 (1cd7112) into main (4566973) will decrease coverage by 0.23%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   88.26%   88.03%   -0.24%
==========================================
  Files          18       18
  Lines         699      702       +3
==========================================
+ Hits          617      618       +1
- Misses         82       84       +2

Impacted Files
Coverage Δ

tsflex/features/feature_collection.py
77.06% <80.00%> (-1.04%)
:arrow_down:

tsflex/features/strided_rolling.py
83.14% <100.00%> (-0.19%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4566973...1cd7112. Read the comment docs.


Weak currentVirtualObject

Since currentVirtualObject is handled as weak attribute, setting it as follows deallocates the object before it can even become visible in the view:
func placeObject() {
    let object = SamMitiVirtualObject(refferenceNode: scene, allowedAlignments: .all)
    SamMitiVitualObjectLoader().loadVirtualObject(object) { [weak sceneView] (obj) in
        sceneView?.currentVirtualObject = obj
    }
}

In order to persist the object I'd have to save it as a (strong) variable in the view controller:
let currentVirtualObject: SamMitiVirtualObject?

func placeObject() {
    let object = SamMitiVirtualObject(refferenceNode: scene, allowedAlignments: .all)
    SamMitiVitualObjectLoader().loadVirtualObject(object) { [weak self, weak sceneView] (obj) in
        self?.currentVirtualObject = obj
        sceneView?.currentVirtualObject = obj
    }
}

Question now: does it work to remove the weak attribute? Ideally I think I would not have to care about persisting currentVirtualObject outside the sceneView.

Disregard - mistake on my end!


Add a gradle-wrapper.properties for buildSrc

Context
It should be possible to import the Gradle project into IDEA without any errors. It seems like IDEA imports the buildSrc property separately - so it uses the Gradle version the tooling API detects. If there is no gradle-wrapper.properties in buildSrc then this import fails with
rror:Could not find method buildCache() for arguments [settings_6gkv94bllekbr8pd73dgqzir6$_run_closure1@31d5526] on settings 'buildSrc' of type org.gradle.initialization.DefaultSettings.

This PR adds a gradle-wrapper.properties to buildSrc which is automatically updated when running the Wrapper task.

Is there an open issue with IntelliJ/JetBrains?  This shouldn't be necessary, but I'm OK if this is a good enough workaround for us.

There are two relevant issues with Jetbrains: https://youtrack.jetbrains.com/issue/IDEA-169717 and https://youtrack.jetbrains.com/issue/IDEA-153336.

Merging this, but we really should be handling this differently (as a real composite build) so IntelliJ doesn't need to recreate the logic that buildSrc should use some other Gradle version

For documentational purposes, also related to:
https://youtrack.jetbrains.com/issue/KT-14895


Web Scraping

Finish the development of the web scraping component of this API to gather all match data of hltv.org.

👍
Hopefully I'll be able to learn these tools some day & do some real analysis

Finish the development of the web scraping component of this API to gather all match data of hltv.org.

👍
Hopefully I'll be able to learn these tools someday and perform some real data analysis


Errorhandler

Pull Request Test Coverage Report for Build 1313

7 of 7 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 1283:
0.0%

Covered Lines:
625

Relevant Lines:
625

💛  - Coveralls