have internal symbol that allows to listen to event finalization

This is for https://github.com/microsoft/vscode/issues/123487

fyi @hediet @joaomoreno

@jrieken Seems like compile issues about the editor using symbols.

@jrieken Seems like compile issues about the editor using symbols.

Yeah, I believe the tree-shaker of monaco doesn't know about the Symbol type

Talking to @hediet made me realise that this doesn't solve our issue... I guess I got carried away by the coolness of Symbol. To recap the leak situation. We have a long-lived event, like from a service, for which a snapshotted, short-lived event is created. That snapshotted event has a bad, leaking listener. Now, when disposing the owner of the short-lived event it has no ability to cut-off the leaking listener. The changes in this PR are no solution to this issue because they built-in upon the original event being disposed.

I think it might be helpful to come up with code-snippets that should not leak, but do.
As far as I understand, the original problem is this failing test:
test('Emitter dispose should clean up leaking listeners', () => {
    const emitter = new Emitter<number>();
    const evenNumbers = filter(emitter.event, n => n % 2 === 0);
    const log: number[] = [];
    const logWR = new WeakReference(log);
    const disposable = evenNumbers(n => log.push(n));
    emitter.dispose();

    GC.collect(); // assuming such a function exists

    // Fails!
    // `disposable` is kept alive and keeps the hidden emitter alive, which keeps `log` alive.
    assert(!logWR.hasValue);

    keepAlive(disposable);
});

Note that this is not really a leak, as disposable itself leaks through keepAlive!
Without keepAlive, the garbage collector would just clean up everything.
I failed to come up with a code-snippet that increases memory usage while a reviewer might think the code-snippet would not.
However, this PR would have caused this real memory leakage:
test('Registering an handler und unregistering it should not leak', () => {
    const emitter = new Emitter<number>();

    // Fails!
    // This code snippet strictly increases the memory usage
    assertNoHeapGrowth(() => {
        const evenNumbers = filter(emitter.event, n => n % 2 === 0);

        const log: number[] = [];
        const disposable = evenNumbers(n => log.push(n));
        disposable.dispose();
    });
});

assertNoHeapGrowth could look like this (pseudo code):
function assertNoHeapGrowth(fn: () => void) {
    GC.collect();
    const initialSize = GC.heapSize;
    fn();
    GC.collect();

    assert(GC.heapSize <= initialSize);
}


feat: block overriding

This PR helps transition users who may not realize that we override their Containefile.
I added two Constants:

BLUEBUILD_TAG => BLUEBUILD_DATE
CONTAINER_FILE_PATH => ./Containefile

I am not worried about the tag name, we can always come up with something better, but let me know what yall think of the build date. I kind of like knowing when this build kicked off.

PR will fail. I know the solution locally. will fix in the AM


Change command to run a deployment script

Related to #1196
Introduced changes

To run a deployment script use script run <SCRIPT_NAME> instead of just script <SCRIPT_NAME>

Checklist

[X] Linked relevant issue
[X] Updated relevant documentation
[X] Added relevant tests
[X] Performed self-review of the code
[X] Added changes to CHANGELOG.md

I think we use ScriptInitResponse for init. I suggest changing ScriptResponse to ScriptRunResponse


Resource Server related FAILURE : received access token verification

Some test module like fapi-rw-id2-ensure-request-object-with-multiple-aud-succeeds-with-mtls and fapi-rw-id2-ensure-request-object-with-multiple-aud-succeeds-with-private-key-and-mtls-holder-of-key checks whether a resource server returns error when it receives invalid access token.
To pass these tests, the resource server verify whether received access token is valid or not by token introspection and returns appropriate response.

On fix-resource-server branch, I implemented the introspection and MTLS verification on the resource server temporarily by keycloak-gatekeeper customization in the following commit:

Add token introspection: https://github.com/openstandia/keycloak-gatekeeper/commit/7f65d355f709b421f3cb2596c310aa3fcd359da5
Add MTLS verification with token introspection: https://github.com/openstandia/keycloak-gatekeeper/commit/878b020f41057cf327fc7accd10950e66f018dd8

Then I tested fapi-rw-id2-ensure-request-object-with-multiple-aud-succeeds-with-private-key-and-mtls-holder-of-key again.
But CallAccountsEndpointWithBearerTokenExpectingError (RFC6749-4.1.2) wasn't passed correctly due to WARN. The test-case attempts reuse of client2's authorization code & test if access token is revoked:

I checked RFC6749-4.1.2. It says:
         if an authorization code is used more than
         once, the authorization server MUST deny the request and SHOULD
         revoke (when possible) all tokens previously issued based on
         that authorization code.

Should we support the revocation in keycloak? Or it's implemented on the latest keycloak?

I looked keycloak code: https://github.com/keycloak/keycloak/blob/6.0.1/services/src/main/java/org/keycloak/protocol/oidc/endpoints/TokenEndpoint.java#L286-L289
It seems that keycloak invalidates existing clientSession. It is same code on the latest keycloak.
There may be a problem on the token introspection side...?

After upgrading to the latest conformance suite (12b18ce5), CallProtectedResourceWithBearerTokenExpectingError which was renamed from
CallAccountsEndpointWithBearerTokenExpectingError  in this commit passed.
In the previous version, the test reused the same JWT for client authentication which is mentioned in https://github.com/jsoss-sig/keycloak-fapi/issues/10. It returns "Token reuse detected" error when the client called token endpoint. That's why the access token wasn't revoked.
In the latest version,  the test doesn't reuse it. So the access token is revoked expectedly.
In conclusion, we can close this issue now.

Also, @tnorimat confirmed the introspection endpoint returns active=false expectedly in the keycloak Arquillian Integration Test. There is no problem with keycloak side.

@wadahiro Thank you. I'll close this issue.


feat(Analytics): Add initial processing such as Guild and User Count, as well as Voice connections and Command uses

Queries to remember:

Get total command usage count

from(bucket: "analytics")
  |> range(start: v.timeRangeStart, stop: v.timeRangeStop)
  |> filter(fn: (r) => r["_measurement"] == "commands")
  |> sum(column: "_value")
  |> group(mode:"by")
  |> sum(column: "_value")

Also two more things

Do we need to do anything special for the InfluxDB docker image? Any special config etc? If so please wait for #1065 to be merged then rebase and make the adjustments to the docker-compose file. I imagine Influx at least needs some kind of volume to have permanent storage. If it's just volumes then it goes in tis repo's docker-compose, if there are specific config files then please contrib to the Docker Images repo
Where can find all the Flux queries to input in Influx? Can you document this somewhere please.

Also two more things

Do we need to do anything special for the InfluxDB docker image? Any special config etc? If so please wait for #1065 to be merged then rebase and make the adjustments to the docker-compose file. I imagine Influx at least needs some kind of volume to have permanent storage. If it's just volumes then it goes in tis repo's docker-compose, if there are specific config files then please contrib to the Docker Images repo
Where can find all the Flux queries to input in Influx? Can you document this somewhere please.

Unless you need system resources as in OS level monitoring the normal image should suffice with a tad bit of manual configuration using the web UI. The proper image to use is quay.io/influxdb/influxdb:2.0.0-beta.
Please state what type of queries you wish to have, and I can design them. At the moment I have guild, user count growth graphing, and the daily difference for both prepared as well as total command usage count.

In
from(bucket: "analytics") // Get all published measurements. In Skyra's case, all of their names are defined in the const enum present in "AnalyticsSchema".
  |> range(start: v.timeRangeStart, stop: v.timeRangeStop) // Here we define the range/(time frame) for which we wish to see the entries. Due to the precision specified in getWriteApi the lowest time frame is a second.
  |> filter(fn: (r) => r["_measurement"] == "commands") // Here we get all the aforementioned time specified values and filter out anything that isn't "AnalyticsSchema.Points.Commands".
  |> sum(column: "_value") // The way I did storage was by setting the "_field" to the command name and "_value" to 1. Because of that design quick each command comes in its own column which are defined by their "_field" value. After that, we sum them all up so that there's only one entry per "_field" column.
  |> group(mode: "by") // Now since they are still in their own "_field" sorted columns we need to join them into a single one.
  |> sum(column: "_value") // And finally since we have all the commands in one place we can sum their "_value" up and get the total amount on used commands in a specified time frame.

Requested changes performed in #1075.

Number of active Voice Connections
from(bucket: "analytics")
  |> range(start: v.timeRangeStart, stop: v.timeRangeStop)
  |> filter(fn: (r) => r["_measurement"] == "voice_connections")
  |> filter(fn: (r) => r["_field"] == "value")
  |> group(columns: ["_field"])
  |> skew()
  |> yield(name: "skew")

from(bucket: "analytics")
  |> range(start: v.timeRangeStart, stop: v.timeRangeStop)
  |> filter(fn: (r) => r["_measurement"] == "voice_connections")
  |> filter(fn: (r) => r["_field"] == "value")
  |> group(columns: ["_field"])
  |> aggregateWindow(every: v.windowPeriod, fn: last)
  |> yield(name: "last")

In case we need to create additional accounts on the VPS: https://v2.docs.influxdata.com/v2.0/users/create-user/


AOS poster abstract

draft
poster instructions
due 3/30/18

idea:
modified 48th IAW poster with an AOS leaning

AOS (part of POLAR2018) still has poster submissions open, due 3/30.
Can we take Kathryn's poster submission for 48 IAW and rework it to be targeting a circumpolar observational network type of angle (the goal of AOS)?
@kameyer @aebudden

Ok @aebudden @mbjones so I took a stab at this today and I think the best fit for a poster submission to Arctic Observing Summit (AOS) 2018 (part of POLAR2018), is the permafrost working group work, which, if I understand correctly, is an Arctic region-wide attempt to synthesize carbon flux data.
See draft abstract and add suggestions or edits, this needs to be submitted on 3/30/18, so on Thursday as we'll be out of the office on Friday.
NB: If it's not ready or not good enough by then, no worries we don't need to submit anything as we'll already be at POLAR2018, this is just my attempt to get us in front of as many people as possible at POLAR and also to maximize our travel dollars.
-V

did not submit because I didn't feel comfortable doing so without AB or Mj feedback first.
closing ticket


Change return type of append method of ValidationErrors.

Because first class collection must be immutable.

Coverage remained the same at 100.0% when pulling e6ed1963566caf56f069d93222b252162cc8c56f on change-append-method-of-validation-errors into 6a933760394d49883c016c5cfcd2e949fb456504 on develop.

Coverage remained the same at 100.0% when pulling 0b604a70a8a7d8620ee63b59db73878e09d09d85 on change-append-method-of-validation-errors into 6a933760394d49883c016c5cfcd2e949fb456504 on develop.

LGTM


Generated inline code (requested via chat, i.e. CMD+I) inserting hexadecimal limiting comments

VS Code Version: Version: 1.80.0-insider (Universal)
OS Version: (In VS Code: OS: Darwin arm64 22.5.0) macOS Ventura 13.4.1 (22F82)
Logs:

When requesting some python code to be added via the inline chat feature, I specifically requested it to generate new plt.histograms based on existing code for one (which was highlighted), for some other variables, the generated code (which worked) also included two extra comments at the start and end:
At the start of the generated code: # BEGIN: 7f5d4a1d7c9c
And at the end of the generated code: # END: 7f5d4a1d7c9c
I haven't attached logs since 1. I don't know where to find them 2. I don't know if they'd be relevant. I can go do this though if it'd be helpful or if it's mandatory. I also don't know if this is intentional, but I'm guessing it isn't, since not all inline suggestions like this include these comments.

Hi @chrisstuartparry ,
Did you encounter this when using inline chat within a (jupyter) notebook?

Hi @chrisstuartparry ,
Did you encounter this when using inline chat within a (jupyter) notebook?

Hi, technically yes I think? I was working in a .py file that was originally converted from an .ipynb file, and so it contained # %% a few times.


Use common memcached.GetMemcachedServerListWithInetString()

Use common func to retrieve the memcached server list for a memcached instance.

/hold

/hold


Next.js & Nuxt Migration Table

For each Next.js / Nuxt feature, a little how to do it with vite-plugin-ssr.
E.g. layouts, nested routes, ...
We can start to collect the mapping in this ticket.

/api/* -> Telefunc

Layout -> https://vite-plugin-ssr.com/default-page#multiple-defaults

getStaticProps() -> contribution welcome :-)

I wrote a small comparison table based on my experience with both vite-plugin-ssr and Next.js. It's definitely not complete but should be a good starting point
vite-vs-next.csv

@patryk-smc That's actually quite convenient 👌. I will add this to vps's docs once the goal is to maximize the number of users. (The goal right now is to release Vike.)

Closing because of lack of interest.
That said, contribution much welcome to write such mgiration table.


Update to 24.2.0

{package} {version} {:snowflake:}
Destination channel: {Snowflake | defaults}
Links

{ticket_number}
Upstream repository
Upstream changelog/diff
Relevant dependency PRs:

...

Explanation of changes:

...

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_80ezi9_dw_/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:48: invalid_url: https://www.attrs.org/ : Not reachable: 403
clone/recipe/meta.yaml:61: invalid_url: https://www.attrs.org/ : Not reachable: 403
===== Final Report: =====
0 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_d4o7x1naqz/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:48: invalid_url: https://www.attrs.org/ : Not reachable: 403
clone/recipe/meta.yaml:61: invalid_url: https://www.attrs.org/ : Not reachable: 403
===== Final Report: =====
0 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_bf6uqe3zro/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:48: invalid_url: https://www.attrs.org/ : Not reachable: 403
clone/recipe/meta.yaml:61: invalid_url: https://www.attrs.org/ : Not reachable: 403
===== Final Report: =====
0 Errors and 2 Warnings were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_0ag1okzbpc/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:48: invalid_url: https://www.attrs.org/ : Not reachable: 403
clone/recipe/meta.yaml:61: invalid_url: https://www.attrs.org/ : Not reachable: 403
===== Final Report: =====
0 Errors and 2 Warnings were found


Import multiple instances of IEDs in one action

Is your feature request related to a problem? Please describe.
As a user of OpenSCD, I sometimes want to add multiple instances of an IED. Rather than navigating through the file system to import the same file multiple times, I would like OpenSCD to support an option to enable this.
For instance, I need to import an ICD file to match my substation layout (x merging units per bay, y transformer protections, z line protections).
I would like only to be concerned with selecting my template files and then be able to select the number of instances quickly and easily without an onerous repetitive action.
Describe the solution you'd like
I want a solution similar to how IEC 61850 Configurator works with DIGSI 5.
After selecting files, the IEDs are processed, and we can select the number of instances for each IED from within a dialogue, with a default of one.

Names are then automatically allocated not to clash (afterwards, they can be renamed using the IED editor with existing functionality).
Rather than using a name of TEMPLATE, with a number on the end, it would be better to use the IED type value so that when multiple devices are brought in they can be distinguished. Perhaps we could do similarly to DIGSI and use a T_ prefix to indicate that the devices are brought in from a template which then allows sorting with the recently imported templates in a similar location in lists. Then a number is used as a suffix, so we would have T_{iedType}_1,  T_{iedType}_2 ...
I would be happy to work on this and think the implementation is straightforward if this feature request is accepted in principle.

We agreed to do this in a new Template editor and remove the functionality to import "TEMPLATE" IEDs from the "Import IEDs" menu item.
This will keep the logic clean and allow for a future "Import IID" plugin.
It will also align better with workflows defined in the standard and conformance testing requirements.


Update onset to prevent CSS leakage

Fixes #402
normalize.css was being pulled in through OnSet, which does funny things to global elements when included after other CSS, such as adding padding around ul tags. This was resolved in https://github.com/Kitware/setvis/pull/3, and this PR updated OnSet to the new version.
There is still special CSS logic in the sphinx docs to deal with this, which we need to keep until this version of Candela is on CDN - another reason to move forward with semantic-release / commitizen.

Do you mind opening a new issue about removing that special logic once we have a CDN ecosystem spun up?


Only retrieve keys for the right user for deletion

I think this is preferable to retrieving the record and then checking the user.
If the user passes a bad id (either non-existent, or someone else's), then the get here is going to throw a DoesNotExist. I think that's no worse than the current behaviour, but at some point it likely makes sense to handle that case explicitly, and serve a real error.
(Note also that the logic in the deleted error message is backwards.)

I'll re-make this once I have the tests running locally, and cover the toggle case, too.


Support richer output

Our system should allow developers to specify non-textual content in the replies from the agent.
For speech, we should support sound effects, emphasis, prosody. We might want to target Speech Markdown or SSMD, which are simplified syntaxes of SSML. Many of the modifiers are necessary to speak certain types correctly, and we should also support them natively.
Or we might want a simpler / more focused syntax, because tokenization might be challenging otherwise.
For GUI output, we should support pictures & RDL (link cards), as we used to do.
This issue is about the infrastructure code to support this and the design of the interface, so that developers can make use of richer interaction in #_[prompt] and #_[result] (and perhaps #_[canonical] if we know how to strip those non-textual markers on the user utterances).
A separate issue will be about generating these

The graphical/interactive outputs were implemented in #406. I'm leaving this open to track speech modifiers, but it's no longer on the critical path.


Question: How do I change the phrase 'Open Menu'?

Open Menu every time showMenu is sent
How do I change the phrase 'Open Menu'?
thank you!

Use showMenuText(String msg, String menu);

Use showMenuText(String msg, String menu);

Ripple is the speed of light.
Thank you very much.


Fix tree-sitter integration for older emacs

Thanks for the quick fix. This sorted out the unknown hooks, but I now get
Warning (treesit): Cannot activate tree-sitter, because Emacs is not compiled with tree-sitter library

I am running emacs 29.2 but without tree-sitter integration.

@alanz Can you see if this PR fixes it for you: https://github.com/rust-lang/rust-mode/pull/522 ?


Create vorkath-attack-counter

Vorkath attack counter, that resets after it does one of its two speical attacks. Also flashes with a red box when the attack counter is at 6. This is useful for timing his special attacks without having to manually count each of his attacks.

I'm pretty sure this goes against the third party guidelines.
Namely, "Indicates the time where a boss mechanic may start or end"


[CLI] Problem identifying options from the webapp with the CLI version

Is it possible to include and document the options that are available in the webapp in the same terms as in the CLI? I'm not able to find, for example, the lossless flag of the AVIF encoder to use in the CLI version.
Thanks!

Unfortunately, due to a few people leaving the team, and staffing issues resulting from the current economic climate (ugh), the CLI and libsquoosh packages are no longer actively maintained. I know that sucks, but there simply isn't the time & people to work on this. If anyone from the community wants to fork it, you have my blessing. The squoosh.app web app will continue to be supported and improved.


Vulkan: Crash in scene with 128 OmniLights and 128 SpotLights rendered at the same time (or Decals/ReflectionProbes)

Godot version
4.0.dev (b6b81e800)
System information
Fedora 34, GeForce GTX 1080 (NVIDIA 495.46)
Issue description
The engine crashes when opening a scene with 128 OmniLights and 128 SpotLights rendered at the same time. If only the 128 OmniLights or 128 SpotLights (not both) are instanced, there is no crash.
The highest amount of combined lights I can render successfully is 103 OmniLights + 103 SpotLights. Past that, I always get a crash when the project starts.
This can also be reproduced with Decals and ReflectionProbes, both of which are clustered elements.
Decreasing Max Clustered Elements in the Project Settings to 128 or below does not prevent the crash from occurring.
Backtrace:
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.0.dev.custom_build (eb469a72c642d11779512e67e1106f763e305526)
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib64/libc.so.6(+0x3d320) [0x7fd30f65e320] (??:0)
[2] Map<RID, Set<RID, Comparator<RID>, DefaultAllocator>, Comparator<RID>, DefaultAllocator>::_find(RID const&) const (/home/hugo/Documents/Git/godotengine/godot/./core/templates/rid.h:47)
[3] Map<RID, Set<RID, Comparator<RID>, DefaultAllocator>, Comparator<RID>, DefaultAllocator>::find(RID const&) (/home/hugo/Documents/Git/godotengine/godot/./core/templates/map.h:598)
[4] RenderingDeviceVulkan::_free_dependencies(RID) (/home/hugo/Documents/Git/godotengine/godot/drivers/vulkan/rendering_device_vulkan.cpp:148)
[5] RenderingDeviceVulkan::free(RID) (/home/hugo/Documents/Git/godotengine/godot/drivers/vulkan/rendering_device_vulkan.cpp:8453)
[6] RendererSceneRenderImplementation::RenderForwardClustered::_setup_render_pass_uniform_set(RendererSceneRenderImplementation::RenderForwardClustered::RenderListType, RenderDataRD const*, RID, bool, int) (/home/hugo/Documents/Git/godotengine/godot/servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp:2407)
[7] RendererSceneRenderImplementation::RenderForwardClustered::_render_scene(RenderDataRD*, Color const&) (/home/hugo/Documents/Git/godotengine/godot/servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp:1469)
[8] RendererSceneRenderRD::render_scene(RID, RendererSceneRender::CameraData const*, PagedArray<RendererSceneRender::GeometryInstance*> const&, PagedArray<RID> const&, PagedArray<RID> const&, PagedArray<RID> const&, PagedArray<RID> const&, PagedArray<RID> const&, PagedArray<RID> const&, RID, RID, RID, RID, RID, RID, int, float, RendererSceneRender::RenderShadowData const*, int, RendererSceneRender::RenderSDFGIData const*, int, RendererSceneRender::RenderSDFGIUpdateData const*, RendererScene::RenderInfo*) (/home/hugo/Documents/Git/godotengine/godot/servers/rendering/renderer_rd/renderer_scene_render_rd.cpp:5080)
[9] RendererSceneCull::_render_scene(RendererSceneRender::CameraData const*, RID, RID, RID, unsigned int, RID, RID, RID, RID, int, float, bool, RendererScene::RenderInfo*) (/home/hugo/Documents/Git/godotengine/godot/servers/rendering/renderer_scene_cull.cpp:3221)
[10] RendererSceneCull::render_camera(RID, RID, RID, RID, Vector2, float, RID, Ref<XRInterface>&, RendererScene::RenderInfo*) (/home/hugo/Documents/Git/godotengine/godot/servers/rendering/renderer_scene_cull.cpp:2515)
[11] RendererViewport::_draw_3d(RendererViewport::Viewport*) (/home/hugo/Documents/Git/godotengine/godot/servers/rendering/renderer_viewport.cpp:171)
[12] RendererViewport::_draw_viewport(RendererViewport::Viewport*) (/home/hugo/Documents/Git/godotengine/godot/servers/rendering/renderer_viewport.cpp:233)
[13] RendererViewport::draw_viewports() (/home/hugo/Documents/Git/godotengine/godot/servers/rendering/renderer_viewport.cpp:659)
[14] RenderingServerDefault::_draw(bool, double) (/home/hugo/Documents/Git/godotengine/godot/servers/rendering/rendering_server_default.cpp:92)
[15] RenderingServerDefault::draw(bool, double) (/home/hugo/Documents/Git/godotengine/godot/servers/rendering/rendering_server_default.cpp:377)
[16] Main::iteration() (/home/hugo/Documents/Git/godotengine/godot/main/main.cpp:2703)
[17] OS_LinuxBSD::run() (/home/hugo/Documents/Git/godotengine/godot/platform/linuxbsd/os_linuxbsd.cpp:342)
[18] /home/hugo/Documents/Git/godotengine/godot/bin/godot.linuxbsd.tools.64.llvm(main+0x1c6) [0x45dcd76] (/home/hugo/Documents/Git/godotengine/godot/platform/linuxbsd/godot_linuxbsd.cpp:58)
[19] /lib64/libc.so.6(__libc_start_main+0xd5) [0x7fd30f648b75] (??:0)
[20] /home/hugo/Documents/Git/godotengine/godot/bin/godot.linuxbsd.tools.64.llvm(_start+0x2e) [0x45dcaee] (??:?)
-- END OF BACKTRACE --

103 OmniLights + 103 SpotLights success:

Steps to reproduce

Add a MeshInstance3D with a PlaneMesh.
With a @tool script, instance 128 OmniLight3D and 128 SpotLight3D on the PlaneMesh at any position (as long as the touch the PlaneMesh somehow).

Minimal reproduction project
test_clustering_crash.zip

For me maximal allowed value is 102, later it crashes with this backtrace
=================================================================
==90592==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x629000a18210 at pc 0x0000161602ff bp 0x7ffe1d2f58b0 sp 0x7ffe1d2f58a0
WRITE of size 4 at 0x629000a18210 thread T0
    #0 0x161602fe in ClusterBuilderRD::add_light(ClusterBuilderRD::LightType, Transform3D const&, float, float) servers/rendering/renderer_rd/cluster_builder_rd.h:305
    #1 0x160c4c6d in RendererSceneRenderRD::_setup_lights(PagedArray<RID> const&, Transform3D const&, RID, bool, unsigned int&, unsigned int&, bool&) servers/rendering/renderer_rd/renderer_scene_render_rd.cpp:3635
    #2 0x16110fce in RendererSceneRenderRD::_pre_opaque_render(RenderDataRD*, bool, bool, bool, RID, RID) servers/rendering/renderer_rd/renderer_scene_render_rd.cpp:4926
    #3 0x16625ef1 in RendererSceneRenderImplementation::RenderForwardClustered::_render_scene(RenderDataRD*, Color const&) servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp:1458
    #4 0x161187a7 in RendererSceneRenderRD::render_scene(RID, RendererSceneRender::CameraData const*, PagedArray<RendererSceneRender::GeometryInstance*> const&, PagedArray<RID> const&, PagedArray<RID> const&, PagedArray<RID> const&, PagedArray<RID> const&, PagedArray<RID> const&, PagedArray<RID> const&, RID, RID, RID, RID, RID, RID, int, float, RendererSceneRender::RenderShadowData const*, int, RendererSceneRender::RenderSDFGIData const*, int, RendererSceneRender::RenderSDFGIUpdateData const*, RendererScene::RenderInfo*) servers/rendering/renderer_rd/renderer_scene_render_rd.cpp:5080
    #5 0x175fff55 in RendererSceneCull::_render_scene(RendererSceneRender::CameraData const*, RID, RID, RID, unsigned int, RID, RID, RID, RID, int, float, bool, RendererScene::RenderInfo*) servers/rendering/renderer_scene_cull.cpp:3221
    #6 0x175d9e59 in RendererSceneCull::render_camera(RID, RID, RID, RID, Vector2, float, RID, Ref<XRInterface>&, RendererScene::RenderInfo*) servers/rendering/renderer_scene_cull.cpp:2515
    #7 0x1771332a in RendererViewport::_draw_3d(RendererViewport::Viewport*) servers/rendering/renderer_viewport.cpp:171
    #8 0x17716518 in RendererViewport::_draw_viewport(RendererViewport::Viewport*) servers/rendering/renderer_viewport.cpp:230
    #9 0x17728427 in RendererViewport::draw_viewports() servers/rendering/renderer_viewport.cpp:659
    #10 0x15b88c54 in RenderingServerDefault::_draw(bool, double) servers/rendering/rendering_server_default.cpp:91
    #11 0x15b93c65 in RenderingServerDefault::draw(bool, double) servers/rendering/rendering_server_default.cpp:375
    #12 0x24201ff in Main::iteration() main/main.cpp:2702
    #13 0x2297b0c in OS_LinuxBSD::run() platform/linuxbsd/os_linuxbsd.cpp:342
    #14 0x2285bb9 in main platform/linuxbsd/godot_linuxbsd.cpp:58
    #15 0x7feb631d0fcf in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #16 0x7feb631d107c in __libc_start_main_impl ../csu/libc-start.c:409
    #17 0x22856ed in _start (/usr/bin/godot4s+0x22856ed)

0x629000a18210 is located 0 bytes to the right of 16400-byte region [0x629000a14200,0x629000a18210)
allocated by thread T0 here:
    #0 0x7feb641a1808 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:144
    #1 0x18128141 in Memory::alloc_static(unsigned long, bool) core/os/memory.cpp:75
    #2 0x17774986 in ClusterBuilderRD::setup(Vector2i, unsigned int, RID, RID, RID) servers/rendering/renderer_rd/cluster_builder_rd.cpp:272
    #3 0x1609c98d in RendererSceneRenderRD::render_buffers_configure(RID, RID, int, int, int, int, float, float, RenderingServer::ViewportMSAA, RenderingServer::ViewportScreenSpaceAA, bool, unsigned int) servers/rendering/renderer_rd/renderer_scene_render_rd.cpp:3019
    #4 0x17653eab in RendererSceneCull::render_buffers_configure(RID, RID, int, int, int, int, float, float, RenderingServer::ViewportMSAA, RenderingServer::ViewportScreenSpaceAA, bool, unsigned int) servers/rendering/renderer_scene_cull.h:1163
    #5 0x17711a4f in RendererViewport::_configure_3d_render_buffers(RendererViewport::Viewport*) servers/rendering/renderer_viewport.cpp:142
    #6 0x17716160 in RendererViewport::_draw_viewport(RendererViewport::Viewport*) servers/rendering/renderer_viewport.cpp:224
    #7 0x17728427 in RendererViewport::draw_viewports() servers/rendering/renderer_viewport.cpp:659
    #8 0x15b88c54 in RenderingServerDefault::_draw(bool, double) servers/rendering/rendering_server_default.cpp:91
    #9 0x15b93c65 in RenderingServerDefault::draw(bool, double) servers/rendering/rendering_server_default.cpp:375
    #10 0x24201ff in Main::iteration() main/main.cpp:2702
    #11 0x2297b0c in OS_LinuxBSD::run() platform/linuxbsd/os_linuxbsd.cpp:342
    #12 0x2285bb9 in main platform/linuxbsd/godot_linuxbsd.cpp:58
    #13 0x7feb631d0fcf in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58

SUMMARY: AddressSanitizer: heap-buffer-overflow servers/rendering/renderer_rd/cluster_builder_rd.h:305 in ClusterBuilderRD::add_light(ClusterBuilderRD::LightType, Transform3D const&, float, float)

There is also crash when I instanced 444 Omnilight, so this is not only problem when using both types of Light

I noticed that decreasing Max Clustered Elements in the Project Settings will cause this crash to happen with fewer lights. Disabling Depth Prepass > Enable in the Project Settings doesn't affect the number of lights at which the crash starts to occur too.

Reflection Probes decrease the number of lights till crash quite a bit..

No, I mean Reflection probes act as a sort of multiplier for the Clustered elements they're rendering it seems.

This is likely because the reflection probes render the lights and decals, while other lights and decals won't render each other.

I am having a very similar issue with my project. I instanced a lot of lights at runtime according to GTA 3's item placement file and it crashes. Instancing non-lighting nodes instead fixes the crashes so I think it might be the same issue?

I am having a very similar issue with my project. I instanced a lot of lights at runtime according to GTA 3's item placement file and it crashes. Instancing non-lighting nodes instead fixes the crashes so I think it might be the same issue?

This is indeed the same issue.

Yup. Someone suggested that I disable out-of-range lights so I used distance fading(again, data from placement files) and it worked.

Is it normal that I'm getting an errorless crash, and there isn't even anything logged using a developer build?
It crashes randomly after spawning a lot of decals.

For me, my game crashes when I instantiate exactly 207 decals on a single model.

For me, my game crashes when I instantiate exactly 207 decals on a single model.

This checks out with this quote from OP:

The highest amount of combined lights I can render successfully is 103 OmniLights + 103 SpotLights. Past that, I always get a crash when the project starts.


storage: add benchwrapper

This adds a small gRPC server around the google-cloud-storage client library,
which allows g3 benchmarking code to prod at the library and record
measurements without needing to be written in Java / be in the same repository.
Since g3 requires TLS on all connections, the server is TLS-ed with a dummy
cert. These certs aren't intended to be private: the kokoro environment
is the only place this gets run. (never in prod, etc)
ps: I'm not sure what the right place to put this code is. Minimally it requires the local version of google-cloud-storage, so I stuck it alongside it. Perhaps there's a better place, with a way to access google-cloud-storage without going to maven though.

I don't think this is the right place for this code - it will be shipped with the client library and adds additional dependencies for the consumers of google-cloud-java. It probably belongs in its own artifact (probably under google-cloud-testing/) which can depend upon the snapshot version of google-cloud-storage. In a test environment, we install all artifacts to the local maven repository and so maven will find the snapshot version before trying to fetch from Maven Central.

I don't think this is the right place for this code - it will be shipped with the client library and adds additional dependencies for the consumers of google-cloud-java. It probably belongs in its own artifact (probably under google-cloud-testing/)

Done

In a test environment, we install all artifacts to the local maven repository and so maven will find the snapshot version before trying to fetch from Maven Central.

What are the commands that need to be run to do that?

Thanks for the review. All comments addressed.

Thanks for the third review. All comments addressed.

Thanks for the fourth review. All comments addressed.

Thanks for the fifth review. All comments addressed.

Thanks for the sixth review. All comments addressed.


Preview local images in markdown for notebooks

This is an upstream VS Code issue.
TODO: File an issue

This works fine for markdown cells. Did you mean output with images in it?

Output doesn't work for our code either, but it works in jupyter.

Example:
from IPython.display import display, Markdown
display(Markdown("![alt text](./Blue.png)"))

Entered this bug here:
https://github.com/microsoft/vscode/issues/104529


fixed broken links to code

Fixed some broken links and removed some unnecessary spacing.

Coverage remained the same at 100.0% when pulling cf205db7b613de48bfe2049e40141742564ffe7a on thomasjfox1:master into a88bd7acdf1124a4ab23c09329977c0edaaa8db4 on astorfi:master.

Please declare these changes in the Issues section.
Moreover please read the pull request policies in the Contributing section as well.
Thank you so much for your help and support.


Improved style

This commit includes capital letters fix and little changes to hyperlinks to improve the style.

Thanks


Zk should be default

Fixing a bug introduced in https://github.com/apache/druid/pull/13550 where the change makes it that there is no ZK by default.

Don't these lines already handle this? (zk = True)
https://github.com/apache/druid/blob/7682b0b6b185e4879ba202b0b777fa655e3d4f59/examples/bin/start-druid-main.py#L238-L241


[flutter_webview] Make NavigationDelegate mandatory

We received the following security report:

Issue: flutter_webview allows navigation (within a WebView) by default, instead of relying on the ActivityManager to handle links. This means that if a user is tricked into clicking a malicious link (e.g. a phishing site), the user has no way to identify the active page and may become a victim of a phishing attack. Android's default behavior for WebView is to delegate to ActivityManager, so by default HTTP(S) links are opened with Chrome. This makes it clear to the user that (a) they've left the current page (and are no longer in the application), and (b) they can use the address bar to determine whether what they're seeing is still a legitimate page or a phishing attack.
Mitigation: We suggest making NavigationDelegate mandatory and adding a security warning that not setting a NavigationDelegate can lead to phishing attacks. Otherwise, since flutter_webview provides more of a browser than just a view, it might also make sense to provide a minimal user interface (cf. Instagram's in-app browser).

This means that if a user is tricked into clicking a malicious link (e.g. a phishing site), the user has no way to identify the active page and may become a victim of a phishing attack

Whether to display information about the active page, and whether to allow following links, is a decision left to the plugin client; it is true that it's possible to construct applications with this property using the plugin, but that's not an inherent issue in the plugin.

We suggest making NavigationDelegate mandatory

This is not a direction we plan to go with the plugin.

and adding a security warning that not setting a NavigationDelegate can lead to phishing attacks

Documenting the full scope of what is and is not safe when displaying web content in an application is out of scope of the plugin documentation, as it's a very large and complex topic, and involves not just the webview settings but the entire application context.

Otherwise, since flutter_webview provides more of a browser than just a view, it might also make sense to provide a minimal user interface (cf. Instagram's in-app browser).

flutter_webview does not provide a browser, it only provides a web view (precisely because it does not have a user interface). Clients who want a browser-like experience based on flutter_webview are welcome to build their own UI around the plugin which meets their specific needs.


Premium SSD v2 disk type not shown

How does Premium SSD v2 fit in here? Is it not listed on this page because it is only available in certain regions (it is GA though)? I feel like it should be listed along with the other 4 disk types, since it is shown here, https://learn.microsoft.com/en-us/azure/virtual-machines/disks-types. If you cannot switch from/to Premium SSD v2 then the one line that speaks about this should include this as well along with ultra disks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: a106b26c-4d9b-9c83-95e6-72f2f13ff39e
Version Independent ID: 8e10d90c-543d-cb32-1098-64dd8504212a
Content: Convert managed disks storage between different disk types using Azure CLI - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/convert-disk-storage.md
Service: storage
Sub-service: disks
GitHub Login: @roygara
Microsoft Alias: albecker

@justingross-msft
Thanks for your feedback! We will investigate and update as appropriate.

@justingross-msft
You are correct that Premium SSD v2 is not listed on the page you provided because it is only available in certain regions. However, it is listed on another page that describes the available disk types for Azure virtual machines. According to this page, Azure managed disks currently offers five disk types, including Ultra disks, Premium SSD v2, Premium SSDs, Standard SSDs, and Standard HDDs You can create a Premium SSD v2 disk in an availability zone and then create a VM in the same region and availability zone that supports Premium Storage and attach the disk to it.
For your reference:
https://learn.microsoft.com/en-us/azure/virtual-machines/disks-deploy-premium-v2?tabs=azure-cli
https://learn.microsoft.com/en-us/azure/virtual-machines/disks-types


Typo fix in flash-encryption.rst

There is a typo/part missing in the description of the block purposes!
It stays AES_256_KEY_1 instead of XTS_AES_256_KEY_1 as it does a couple of lines later.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

sha=4259df3d56f74b4f5b02452a62117453c0cf219e


New version: Tauri.create-tauri-app version 3.3.4

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[X] Does your manifest conform to the 1.4 schema?

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


SM123 close conversation

What has been changed

Backend functionality has been added to this pr in secure-message.

Added functionality for a thread to be closed and re-opened.

When viewing a conversation there should be the option to close a conversation. This should take you to the close-conversation speedbump page which after confirming will take you back to the conversation list page with a flash message to go back to the message.

When viewing a closed conversation you will have the option to re-open, after doing so should take you back to the conversation list page again with a flash message.

Review

Check that tests pass and functionality works.

Future

Open/Closed tab with list of threads for each status.
R-Ops/Frontstage to handle any errors on edge cases.

Codecov Report

Merging #167 into master will decrease coverage by 1.13%.
The diff coverage is 61.36%.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   96.49%   95.35%   -1.14%
==========================================
  Files          36       36
  Lines        1768     1809      +41
==========================================
+ Hits         1706     1725      +19
- Misses         62       84      +22

Impacted Files
Coverage Δ

...e_operations_ui/controllers/message_controllers.py
87.03% <45%> (-9.56%)
:arrow_down:

response_operations_ui/views/messages.py
91.16% <75%> (-2.66%)
:arrow_down:

..._ui/controllers/collection_exercise_controllers.py
89.43% <0%> (-3.26%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 988aa28...8ad93cb. Read the comment docs.


Feature Request: IIS HTTP Status

Hi,
I have a feature request to extend the WMI Exporter to expose metrics capturing the following:

The total amount of 4** HTTP Status return codes received from a site for a given HTTP call

The total amount of 5** HTTP status return codes received from a site for a given HTTP call

I know at the moment you expose the total amount of HTTP calls for a given type e.g GET. I was thinking it would be good to see something like the following:
wmi_iis_requests_total{method="GET",site="ExampleSite",status="5**"}
Additionally, I think it would be useful to extend the current IIS exporter to include these metrics in order to get throughput metrics:
BytesSentPerSec
BytesReceivedPerSec
BytesTotalPerSec
which is already included as part of the Win32_PerfRawData_W3SVC_WebService
Apologies if you have this available already!
Cheers

Hi,
Yes, I would also love to have this! However, as far as I am aware, this is not available through WMI :( I will do some extra digging, but I believe this is something that is not possible.
Regarding the throughput, this is something that you can get using PromQL: rate(wmi_iis_sent_bytes_total[1m]). Does this work for you?

Hi,
Thanks for replying so quickly and for providing me with the throughput query! Hopefully there will be something to capture the status codes :)
Just as a side note, I was reading this article about monitoring IIS - in particular the section regarding URI cache metrics:
https://blog.serverdensity.com/monitor-iis/
And saw that it mentioned some metrics that are featured as part of this service:
https://msdn.microsoft.com/en-us/library/aa394257(v=vs.85).aspx
(Win32_PerfFormattedData_InetInfo_InternetInformationServicesGlobal)
which may be useful to capture for timeout information on requests for IIS etc?
Thanks again for your help!

Cache metrics seem to originate from this class: Win32_PerfRawData_W3SVC_WebServiceCache (None of my servers (2012/2016) have the one you referenced, also the "PerfFormattedData" classes are massaged by Windows a bit, so we prefer the "PerfRawData" ones). This should definitely be possible to add!
Also, I found this class: Win32_PerfRawData_W3SVCW3WPCounterProvider_W3SVCW3WP. It does not give us all the status codes, sadly, but at least it has these:
Percent403HTTPResponseSent         : 0
Percent404HTTPResponseSent         : 50654
Percent500HTTPResponseSent         : 279```

(Disregard the "Percent", that is how it will eventually be presented in perfmon, but the data is the raw numbers)

So, we can at least get some of the statuses!

That's perfect! Thanks for looking into it, it's very much appreciated :)
Just out of curiosity, when do you think this could be added to the exporter? (I appreciate that there are other responsibilities you have!)

Taking a look at it now. It's not too complicated adding new things - almost all of the effort is figuring out which counters are actually interesting, which ones should be just different labels of the same metric, how to name them, etc.
The major snag right now is figuring out what the difference is between the two classes, actually. Both of them export cache-related counters of the same name. Win32_PerfRawData_W3SVCW3WPCounterProvider_W3SVCW3WP is likely the specific caches for each worker process, while Win32_PerfRawData_W3SVC_WebServiceCache is globally for the server. However, the worker processes don't sum up to the global one, so there is something else going on here. Possibly the static file handler of IIS uses the cache, but doesn't hit the application pool's worker processes? Not sure.
There might also be a bit of overlap with existing IIS metrics for the worker process stuff, such as requests served etc. I'll probably leave those out, unless there is some compelling reason to add them. I've actually never seen anyone use more than one worker process per application pool, not sure how common use case it is

Okay, so I have a prototype of this now. There are a lot of counters, and with some overlap as I mentioned above. For example wmi_iis_requests_total{method,site} which is for a site (resetting with the IIS server), and  wmi_iis_worker_requests_total{app}, which is per AppPool worker (resetting each time the AppPool worker is recycled).
I managed to go against the official best practices with the cache metrics, so I'll fix that tomorrow and then submit a PR. The IIS collector is getting fairly large, so there might be some refactoring needed before merging.

Thanks for the update and for adding this to the exporter!
Did you find out the difference between the Win32_PerfRawData_W3SVCW3WPCounterProvider_W3SVCW3WP and Win32_PerfRawData_W3SVC_WebServiceCache cache's? It's quite interesting that they don't add up to each other! And I agree - if there is data already captured by one of the services, we should ignore the same overlap elsewhere - just to lessen confusion of anyone who wants to use it and doesn't know which counter to choose! :)


Register package

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/82941
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.0 -m "<description of version>" e42971b1260d904aace7ee3b655fa49632ec849f
git push origin v1.0.0


Error after install GraphQL plugin

$ strapi develop
[2021-10-12T22:36:12.239Z] debug ⛔ Server wasn't able to start properly.
[2021-10-12T22:36:12.241Z] error Error: There can be only one type named "ComponentPageQuestionInput".
Field "ComponentPageQuestionInput.question" can only be defined once.
Field "ComponentPageQuestionInput.answer" can only be defined once.
There can be only one type named "editComponentPageQuestionInput".
Field "editComponentPageQuestionInput.id" can only be defined once.
Field "editComponentPageQuestionInput.question" can only be defined once.
Field "editComponentPageQuestionInput.answer" can only be defined once.
at assertValidSDL (/home/cas/Development/api/node_modules/graphql/validation/validate.js:107:11)
at Object.buildASTSchema (/home/cas/Development/api/node_modules/graphql/utilities/buildASTSchema.js:45:34)
at Object.buildSchemaFromTypeDefinitions (/home/cas/Development/api/node_modules/graphql-tools/dist/generate/buildSchemaFromTypeDefinitions.js:25:28)
at makeExecutableSchema (/home/cas/Development/api/node_modules/graphql-tools/dist/makeExecutableSchema.js:26:29)
at Object.generateSchema (/home/cas/Development/api/node_modules/strapi-plugin-graphql/services/schema-generator.js:101:18)
at Object.initialize (/home/cas/Development/api/node_modules/strapi-plugin-graphql/hooks/graphql/index.js:76:74)
at /home/cas/Development/api/node_modules/strapi/lib/hooks/index.js:37:28
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

nevermind, i had a component and a text field named question.


penumbra: design more robust transaction checks

Is your feature request related to a problem? Please describe.
In Penumbra, a Transaction is a collection of Actions, each with its own semantics and validity conditions, e.g., spending a note, uploading a validator definition, etc. These validity rules are encoded in the ActionHandler and can be decomposed into two steps:

stateless verification: checking invariants that don't require access to the application state, e.g., checking bound conditions, verifying a signature.
stateful verification: checking invariants that require access to the application state, e.g., public inputs to a proof, nullifier set membership, etc.

Crucially, the stateful checks are executed against a pinned snapshot of the application state. On one hand, this approach provides us with convenient data consistency guarantees. But on the other, it means that transaction stateful verification doesn't take into account the effects of its sub-actions.
This is a common vulnerability pattern that has been reported during audits of the application logic, which consists of crafting transactions that incorporate conflicting actions, e.g., double validator definition uploads
Potential solution
We have yet to find a solution that doesn't significantly impact full node performance, but here's a simple way to solve this: We can force a stateful check to occur before executing individual actions.his would create I/O overhead where there was none before, as we would maintain fail-fast concurrent stateful checks but add this additional redundancy. The advantages of this approach are that it's simple and robust. The downside is that it imposes a redundant cost.

I don't think this needs any redesign of the execution model. We can already handle this in execute, which is fallible for this reason — and is how IBC actions are handled.
In the case of this specific bug, there are two possible things that could have been done:

Treat position IDs as akin to nullifiers (check all in parallel and then also check no overlaps within transactions).

Have the "add a new position" method check that the position does not exist when writing it out.

In terms of a general solution, I think what we need is to have written justifications for each of the checks we do and why stateless/stateful/execution is the right place for them to live.

Sounds good, closing this ticket in favor of #3855. There's also the case of validator definitions with conflicting consensus keys, which is why i thought we would want to always run an action stateful check before executing that action.


add an ecto macro for use in phoenix apps

closes #15

now verified to work flawlessly in an existing Phoenix application 🚀


Building on Windows

I know that Windows target is not supported at the moment, but since it was a stated goal, here's the current status.
rustc 1.15.0-nightly (8f02c429a 2016-12-15)

Build fails on servo-fontconfig-sys:
error: failed to run custom build command for `servo-fontconfig-sys v2.11.3 (https://github.com/jwilm/libfontconfig#618a5297)`
process didn't exit successfully: `C:\Users\name\dev\rs\alacritty\target\release\build\servo-fontconfig-sys-15a0b66e991dea2e\build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 2, message: "The system cannot find the file specified." } }', C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libcore\result.rs:837
stack backtrace:
   0:     0x7ff7e6d3a86a - std::panicking::default_hook::{{closure}}
                        at C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:354
   1:     0x7ff7e6d39d76 - std::panicking::default_hook
                        at C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:365
   2:     0x7ff7e6d3d66d - std::panicking::rust_panic_with_hook
                        at C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:553
   3:     0x7ff7e6d3d4b8 - std::panicking::begin_panic<collections::string::String>
                        at C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:515
   4:     0x7ff7e6d3d424 - std::panicking::begin_panic_fmt
                        at C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:499
   5:     0x7ff7e6d3d3b9 - std::panicking::rust_begin_panic
                        at C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:475
   6:     0x7ff7e6d40147 - core::panicking::panic_fmt
                        at C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libcore\panicking.rs:69
   7:     0x7ff7e6d2128f - core::result::unwrap_failed<std::io::error::Error>
                        at C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libcore\macros.rs:29
   8:     0x7ff7e6d21dd2 - build_script_build::main
                        at C:\Users\name\.cargo\git\checkouts\libfontconfig-3d5e920c02c2e53f\618a529\build.rs:25
   9:     0x7ff7e6d3fac1 - panic_unwind::__rust_maybe_catch_panic
                        at C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libpanic_unwind\lib.rs:98
  10:     0x7ff7e6d3dc5a - std::rt::lang_start
                        at C:\bot\slave\nightly-dist-rustc-win-msvc-64\build\src\libstd\rt.rs:51
  11:     0x7ff7e6d43a48 - __scrt_common_main_seh
                        at f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253
  12:     0x7ffedc668363 - BaseThreadInitThunk

Thanks for looking into it!
Since this is linked from the Windows Support issue and Windows support is a ways out, I'm just going to close this.

FWIW I actually managed to build this on WSL (Ubuntu 16.04.1 LTS), fully updated (sudo apt-get update && sudo apt-get upgrade) yesterday evening.
I'm on Insider Slow Ring (build rs_prerelease 14986).


Incorrect token price display (JOY)

Describe the bug

Incorrect token price display (JOY)
Re-check all token

The problem is because of price cache services. It has been fixed, @Sokol142196 please check it again.

@saltict I verified that the issue was passed so I closed the issue and continued to follow up


Rootful Dopamine?

https://github.com/pinauten/Fugu15_Rootful

I have known this was possible for quite some it, however due to it taking 8GB off of your device and rootless being better in any way, I have no plans to make Dopamine rootful.

No, this is bad news.


Update _patch.py related to endpoint KeyError

Fix endpoint KeyError.
The value provided for the url part endpoint was incorrect, and resulted in an invalid url
Traceback (most recent call last):
File "/usr/local/lib/python3.12/site-packages/azure/core/pipeline/transport/_base.py", line 664, in format_url
base = self._base_url.format(**kwargs).rstrip("/")
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'endpoint'

Thank you for opening this @ericnorway!
@msyyc - could you please investigate?
This also looks like it might be an issue in multiple places in patch.py, but not in the original generated operations.py:
https://github.com/Azure/azure-sdk-for-python/blob/e2bb471738cc45d3f7e7e0cc9705e2e84157c499/sdk/webpubsub/azure-messaging-webpubsubservice/azure/messaging/webpubsubservice/_operations/_patch.py#L293
https://github.com/Azure/azure-sdk-for-python/blob/e2bb471738cc45d3f7e7e0cc9705e2e84157c499/sdk/webpubsub/azure-messaging-webpubsubservice/azure/messaging/webpubsubservice/_operations/_patch.py#L458
https://github.com/Azure/azure-sdk-for-python/blob/e2bb471738cc45d3f7e7e0cc9705e2e84157c499/sdk/webpubsub/azure-messaging-webpubsubservice/azure/messaging/webpubsubservice/_operations/_patch.py#L778

@ericnorway It is already fixed in https://github.com/Azure/azure-sdk-for-python/pull/36865 and could you try latest version https://pypi.org/project/azure-messaging-webpubsubservice/1.2.1/?

Yes, it is working now. Thank you :) Sorry for the late reply.


definition of R^2 incorrect

R^2 is defined in deephyper/deephyper/search/nas/model/train_utils.py. For multi-variate regression (predicting a vector output), this definition is incorrect. It sums over both dimensions (# of examples and # of responses/outputs), producing one R^2 score. This is equivalent to flattening the data before calculating R^2. We should change this to match the default behavior of scikit-learn: calculate one R^2 score for each response/output, then average those R^2 scores.

Hi @BethanyL , thanks for reporting this issue which was not identified, I am working on the multivariate case on a specific branch: feature/pblp
I started integrating the corrected r2 implementation for multivariate here
I started testing it with different training case without comparing to scikit-learn results (to check for consistency) yet: folder
I use the following files for testing purposes:
multi_loss_test.py
single_loss_multi_var.py
single_loss_test.py

Resolved in version 0.1.2


Complex column definitions

I see in #227 adding additional information to the data type.
Is there any way to add the additional column expression e.g. 'columnExpr' as an optionally hidden/truncated field in the ERD view?
For example this expression makes the ERD view difficult
varchar(36) generated always as
        (
        insert(
        insert(
            insert(
            insert(
                hex(
                concat(substr(id_bin,5,4),substr(id_bin,3,2),
                        substr(id_bin,1,2),substr(id_bin,9,8))
                ),
                9,0,'-'),
            14,0,'-'),
        19,0,'-'),
        24,0,'-')
        ) virtual

If I could keep dataType as
varchar(36)

and add columnExpr
generated always as
        (
        insert(
        insert(
            insert(
            insert(
                hex(
                concat(substr(id_bin,5,4),substr(id_bin,3,2),
                        substr(id_bin,1,2),substr(id_bin,9,8))
                ),
                9,0,'-'),
            14,0,'-'),
        19,0,'-'),
        24,0,'-')
        ) virtual

vs as it is today
VARCHAR(36) GENERATED ALWAYS AS ( insert( insert( insert( insert( hex( concat(substr(id_bin,5,4),substr(id_bin,3,2), substr(id_bin,1,2),substr(id_bin,9,8)) ), 9,0,'-'), 14,0,'-'), 19,0,'-'), 24,0,'-') ) virtual

I think it would be easier to work with the complex definitions
For the referenced example I would have columnExpr
CHECK (TEST IN ('A','B','C'))

and for a plain ENUM columnExpr
('A','B','C')

I think we need a separate input form for the special case.
And it needs to be smoothly connected to the existing keymap editing mode.
I'll think about how to implement it.


Adding support for Byte array serialization

Utility function which takes in a string and converts it to array of felt objects

@thiagodeev Please check and let me know if any changes are required

Nice code @krishnateja262!
I'll make some comments

Very good @krishnateja262!
Now we just need to make some adjustments to the test function

One last thing: have you tested this function interacting with a Cairo method that requires a ByteArray as input? Did it work?

Just those two small comments, happy to approve otherwise. Thanks!

@rianhughes i have done the changes as suggested
@thiagodeev pushed an implementation of Felt Byte array to string conversion, please check and let me know for any changes

@thiagodeev deployed a simple bytearray storage contract in sepolia here: 0x0080fc7dbc9adfe5f4edc3af816f722cc102f86786c053a0f76860d80afdd0a7
I made an observation regarding strings with 31 characters or multiples of 31 characters when testing with the contract. The chain expects both pending word and the size of the pending word. In the initial implementation, only the length of the pending word was pushed into the array, causing transactions to revert.
To resolve this, I modified the code to also add 0x0 for the pending word since it is empty. Now, the array typically ends with [0x0, 0x0] for strings with 31 or multiples of 31 characters.

@thiagodeev let me know if we can do this for U256 data type as well(serialisation and deserialisation). I can create a new issue and raise PR

Of couse @krishnateja262! It will be very helpful

@rianhughes Please let me know if there's anything I need do to for this to get merged


./linux_mark.sh  Unable to init server

I run a VM in GCP, and use Docker to create a container with Ubuntu18.04
But I've encountered ./linux_mark.sh error as below.
Hoping to solve this problem, thks!
root@9a3ecbadbd4c:/workspace/darknet/Yolo_mark# cmake .
-- Configuring done
-- Generating done
-- Build files have been written to: /workspace/darknet/Yolo_mark
root@9a3ecbadbd4c:/workspace/darknet/Yolo_mark# make
[100%] Built target yolo_mark
root@9a3ecbadbd4c:/workspace/darknet/Yolo_mark# ./linux_mark.sh
Example how to start marking bouded boxes for training set Yolo v2
File opened for output: x64/Release/data/train.txt
File loaded: x64/Release/data/obj.names
Unable to init server: Could not connect: Connection refused

(Marking images:6509): Gtk-WARNING **: 11:23:05.625: cannot open display: :1
./linux_mark.sh: line 7: pause: command not found
root@9a3ecbadbd4c:/workspace/darknet/Yolo_mark#

I have the same error while using windows 10 WSL

I have the same error while using ubuntu 18.04 LTS


Pulled SQLCoder2 even though it's not listed in the library

I wanted to test out sqlcoder2, but only saw sqlcoder on the model library page
I still tried to see what would happen if I ran Ollama pull sqlcoder2...and it worked
It pulled down the model named sqlcoder2:latest
Is this an issue with the model library not being up to date or is it downloading sqlcoder (assuming v1) even though I'm asking for sqlcoder2.
Here's the output of the modelfile
lestan@Lestans-MacBook-Pro learn-text-to-sql % ollama show sqlcoder2 --modelfile
# Modelfile generated by "ollama show"
# To build a new Modelfile based on this one, replace the FROM line with:
# FROM sqlcoder2:latest

FROM /Users/lestan/.ollama/models/blobs/sha256:4018b30faaf8b1e4cedad4dff4871f74e369950ddd25a0a4e8b0657a18710517
TEMPLATE """{{ .Prompt }}"""
PARAMETER stop "<|endoftext|>"

Hi @lestan
SQLcoder2 seams to be a valid model. It's bigger than SQLCoder (9 GB instead of 4.1).
It could be a copy of sqlcoder:15b what has the same size.
Ollama pull sqlcoder2
pulling manifest
pulling 4018b30faaf8... 100% ▕████████████████▏ 9.0 GB
pulling a67353d85e36... 100% ▕████████████████▏  21 KB
pulling 1576480a555b... 100% ▕████████████████▏   36 B
pulling 1cc25ac1ef96... 100% ▕████████████████▏  386 B
verifying sha256 digest
writing manifest
removing any unused layers
success
(base) igor@Mac-Studio-192 ~ % ollama show sqlcoder2 --modelfile
Modelfile generated by "ollama show"
To build a new Modelfile based on this one, replace the FROM line with:
FROM sqlcoder2:latest
FROM /Users/igor/.ollama/models/blobs/sha256:4018b30faaf8b1e4cedad4dff4871f74e369950ddd25a0a4e8b0657a18710517
TEMPLATE """{{ .Prompt }}"""
PARAMETER stop "<|endoftext|>"
(base) igor@Mac-Studio-192 ~ % ollama run sqlcoder2

give me the sql to delete a database

drop database ;

Send a message (/? for help)

We had set sqlcoder2 to be hidden while we were testing it, and then forgot to delete it. You should just use the sqlcoder model as it should be the most up-to-date. I've gone ahead and removed sqlcoder2 from the registry so you won't be able to pull it any more.
Thanks for the issue!


Content padding for TextField doesn't show on iOS

Duplicate Check

[X] I have searched the opened issues and there are no duplicates

Describe the bug
Property content_padding for the TextField doesn't work on iOS. I've set the property to "Servings" text field. Here's a screenshot on an app on Linux, where the property works as expected:

And here's a screenshot from iOS device, where the property did not take any effect:

I am using iPhone 13 Pro Max with iOS 17.5.1.
Flet Application details:

Client version: 1.5.1
Flet SDK version: 0.21.1
Python version 3.11.6

Code
No response
To reproduce
Create a TextField with adaptive property set to True and run on iOS device.
Expected behavior
No response
Screenshots
No response
Operating System
Linux
Operating system details
KDE Neon 6.0
Flet version
0.23.1
Regression
I'm not sure / I don't know
Suggestions
No response
Additional details
No response

The Flet mobile app needs to be updated to match the current Flet version.
Will be done in the coming days. 🤞🏾

Awesome, thanks!

Closing in favor of https://github.com/flet-dev/flet/issues/3096


Hide get_property export

Is your feature request related to a problem? Please describe.
get_property is unintentionally exported.
Describe the solution you'd like
We should hide add #[doc(hidden)] it for 0.5 and make it pub(crate) for 0.6. I would prefer to deprecate it, but there doesn't seem to be a "public-only" deprecation lint available.
Describe alternatives you've considered
N/A
Additional context
N/A

@gbj this would not be a breaking change, but preferrable to be ready for 0.5


Change bibliographic endpoint to use SRU rather than API

When we have a crawler event that hits certain Orangelight endpoints (e.g. staff_view, .ris, .endnote), it can quickly use up our Alma api calls
Currently, these calls go to the bibliographic endpoint ("#{Requests.config['bibdata_base']}/bibliographic/#{id}", which then calls the Alma API

Acceptance criteria

The data provided from the bibliographic endpoint does not change
The data is sourced from a call to the Alma SRU, rather than the Alma API.

@maxkadel tested it successfully on catalog-staging. Waiting for exlibris to see if we can put it in production.


makeFindMixin returns nothing, but the websocket does (upgraded to Feathers4)

Steps to reproduce
I had a working makeFindMixin, but then upgraded to Feathers4.  Now, no data seems to make it to vue.
<template lang="pug">
	div
		| {{ devicelibrary }}
</template>

<script>
import { makeFindMixin } from 'feathers-vuex'

export default {
	name: 'DeviceMenu',
	mixins: [makeFindMixin({ service: 'devicelibrary' })],
	computed: {
		devicelibraryParams() {
			return { query: { $sort: { device: 1 } } }
		}
	}
}
</script>

Expected behavior
It should populate with results from the socket
Actual behavior
[]
So, per this note, i put a breakpoint.

serviceState.keyedById is empty (well, an observer),
queryInfo:  {"qid":"default","query":{"$sort":{"device":1}},"queryId":"{"$sort":{"device":1}}","queryParams":{"$sort":{"device":1}}}"
params:  {"query":{"$sort":{"device":1}},"qid":"default"}

Again, using a feathers hook, i see that the appropriate data has arrived.  The results are what I expect, given the query.  I do not mess with the params anywhere, eitherr.

Usually data not making it into the store means that there's either no id or _id OR the idField is misconfigured.  What is the idField of the data you're receiving?

It's _id, as it's a mongo backend.  Here's data from the setupInstance
"{"_id":"5c9f8461007dff6e1b6295db","device":"Breaker","protocol":"modbus","connection":{},"polling_rate":1600,"data_rate":300,"address_offset":0,"image_url":null,"alarm_arm":"5aa7f8f2292e75045eb88fa4","primary_symbol":"KW","running_symbol":"KW","tag_library":[],"notes":"","manual":"","blocks":[{"address":"400001","length":34,"polling_rate":3}]}"

I even have idField configured in the feathers client setup, thusly (perhaps from an example?):
// Setup feathers-vuex
const { makeServicePlugin, makeAuthPlugin, BaseModel, models, clients, FeathersVuex } = feathersVuex(feathersClient, {
	serverAlias: 'api', // or whatever that makes sense for your project
	idField: '_id' // `id` and `_id` are both supported, so this is only necessary if you're using something else.
})

I'm walking through the process here.  In getItemsFromQueryInfo, and it seems I don't have a pageId.  Without a pageId, I don't get a queryLevel, and without that, I don't get a pageLevel, and without that, I don't get ids.
So, maybe I need to set up pagination?  Is this a new requirement maybe?

Try passing paginate: false in the params:
devicelibraryParams() {
    return {
        query: { $sort: { device: 1 } },
        paginate: false
    }
}

That worked!
Did I hit a weird use case, or is this standard practice in 2.x?

I think I need to try out the mixin on a service without server-side pagination enabled.

I had the same problem once, until I figured this out.
Maybe paginate: false should be the default...

@J3m5 That probably would be a good idea.  It would be a breaking change, so it will have to wait a bit, though.  I'll see if I can fix this in the meantime.

Ran into a similar issue just a bit ago; while I do have pagination enabled on both the server and client-side, which seems to work just fine. I run into this particular issue whenever I would modify the Hook context's params.query object to apply server-only data. Seems like FeathersVuex uses the resulting query as a pagination key. I can't imagine this is intentional behaviour? Perhaps using the query passed in serviceParams would be better for pagination keys?

It will work properly if you modify a clone of the params to return in your hook.
This is documented, but probably difficult to find when you come from the standpoint of "hey no data's loading".  If you modify the params, you MUST clone first.  It wouldn't make sense to use the other params, because those aren't the ones getting sent to the server.  This issue only exists because objects are passed by reference and not value (which is really supportive for setting up relational data, but not for tracking params)

Seems like FeathersVuex uses the resulting query as a pagination key. I can't imagine this is intentional behaviour?
This is definitely intentional.  It can't really work any other way.  There are two parts to a paginated query:

The "page" params, which includes $limit and $skip
The query params, which includes everything except $limit and $skip.

This is just a gotcha because FeathersJS doesn't clone the params before passing them into the hook chain.

Aha, understood. Thanks so much for the detailed response! 🤗

In 3.0, which is coming within a few days, pagination will be turned off by default.  This means that queries and lists will be realtime by default.

<EMAIL_ADDRESS>is out and includes this fix.  The upgrade will take about 5 minutes, max.  There's only one change that might not even affect you: https://vuex.feathersjs.com/3.0-major-release.html#a-single-breaking-change


Fix for Issue 2800

Contains
Fixes #2800
How to test
Break some bushes: a small cloud of rapidly disappearing particles/leaves should appear where the bush used to be - this is the normal behavior.
The Bug detailed in 2800 had the particle appear in the lower portion of the field of view of the player, in a frame of coordinates seemingly unrelated to the visible world.
Notes
This problem was due to the SimpleBlendMaterialsNode implicitly relying on other nodes to set the correct modelview and projection matrices. After the merging of PR #2794 nodes must either add a StateChange to look through a specific camera or run their code assuming the projection and modelview matrices being identity matrices - opengl's default.
As testing of #2794 didn't include semi-transparent objects, this problem was not noticed.

Hooray Jenkins reported success with all tests good!

Tested out, both scenarios are fine now, and the code pretty simple and cool to see. Thanks! :-)


Add authors to table of contents?

It would make authorship more visible, but it could look redundant if it's always the same author.

One way to do this is to only show authors if they vary.


User dropdown should scroll when screen is too short

This is still an issue.

Along the same lines as: https://github.com/linode/manager/issues/1119


WIP: Same flag name used by different subcommands cause problems

Describe the bug
Same flag name for different cobra subcommands does not work. See https://github.com/spf13/viper/issues/233 for description of the issue.
We currently use flag port in serve and proxy subcommands.
Solution
The solution outlined in https://github.com/spf13/viper/issues/233#issuecomment-386791444 will fix the problem.

This fix causes the flags to not be part of help :(


'fp2lm' is not recognized

Hi, when I do the 3rd step in the installation for Windows, I get this error in Windows PowerShell. How do I solve this?
fp2lm : The term 'fp2lm' is not recognized as the name of a cmdlet, function, script file, or operable program. Check t
he spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:2

fp2lm -d 20m > ~\Desktop\LitchiMission.csv

 + CategoryInfo          : ObjectNotFound: (fp2lm:String) [], CommandNotFoundException
 + FullyQualifiedErrorId : CommandNotFoundException

Hi, thanks for reaching out about this.  This probably indicates that the fp2lm command is not being found — most likely because it is not in PowerShell's PATH environmental variable.  Note: the environmental variable setting will only persist as long as the shell is open.  If you close the shell, you will need to reset the environmental variable.  There are additional steps to perform if you want to make the setting permanent.  I've updated the Windows installation and usage instructions.  Please take a look here: https://github.com/pdfinn/flightplan2litchimission/blob/main/README.md and let me know if this fixes the issue.  The new instructions have been tested in PowerShell on Windows 10 Enterprise.


Redundant exons

https://github.com/tgen/jetstream_resources/blob/1a368800f42af8f57e9a8630f69b2018f81d6044/phoenix/create_gene_model.sh#L248-L249
This seems to produce the same exon for each transcript of the gene, not a unique exon list per gene. The file is not referenced in the phoenix YAML so is it even used in the workflow? Why do we make it @awchrist @bryce-turner

This is used within build package, I will confirm the exact usage and whether or not the output is as expected.


Updated cmake/FindOpenVDB.cmake to propagate cxx11 standard requirement

Signed-off-by: Nick Avramoussis<EMAIL_ADDRESS>

For reference, see https://cmake.org/cmake/help/latest/manual/cmake-compile-features.7.html#requiring-language-standards

The infamous TestUtil::testPagedArray @kmuseth @danrbailey
TestUtil::testPagedArrayCommand exited with code -1073741819
Unrelated to these changes!


Redesign JSON parser and JSON token APIs with lazy evaluation of tokens, proper unescaping support, and hardened validation

Fixes https://github.com/Azure/azure-sdk-for-c/issues/612, https://github.com/Azure/azure-sdk-for-c/issues/608, https://github.com/Azure/azure-sdk-for-c/issues/348,
Changes:

Updates az_json_parser and az_json_token APIs and type definitions

Materializes the JSON tokens into actual types lazily by deferring the actual creation of ints, strings, bools, until the caller actually needs it.
When the  caller needs to get back a printable string, az_json_token_get_string should be called, which unescapes and copies the slice, and null-terimates it.
When the  caller needs to compare a JSON property name/string text value to a literal lookup string, az_json_token_is_text_equal should be called since it unescapes the slice, if needed to do proper semantic comparison.
Added a default parser option, which is currently empty, mirroring the JSON builder API, to avoid needing breaking changes in the future.
Removes use of double from the parser, so folks who don't have or need floating point support, can still use it. It becomes pay-for-play.
Simplify the public API to avoid having the caller figure out the distinction between arrays, objects, and token members.
Hardened the parser implementation so it is more resilient to invalid JSON, particularly edge cases, and add several invalid JSON payload tests.
General implementation refactoring and clean up, including unifying on a singular stack (and removing duplicate logic) - addresses previous feedback https://github.com/Azure/azure-sdk-for-c/pull/664#discussion_r418622076, https://github.com/Azure/azure-sdk-for-c/pull/664#discussion_r418622584.
Removes az_json_token creation APIs, since only the az_json_parser should be creating these.
Removes az_json_parser_done since it isn't necessary and no one was calling it. The usage pattern of the new API (in a loop based on token kind or AZ_ERROR_EOF) circumvents the need for this validation API that the user had to remember to call.

Removes az_json_pointer support since it isn't necessary (not used within the SDK other than AAD), nor is it optimal for repeated look-ups of property names since it does redundant parsing. If a critical scenario comes up that cannot be solved by az_json_parser, we can add this functionality back with more design and testing.

Also remove the az_json_string_private helpers as they are no longer needed.

Coding pattern and usage sample:
az_json_parser jp;
AZ_RETURN_IF_FAILED(az_json_parser_init(&jp, body, NULL));

AZ_RETURN_IF_FAILED(az_json_parser_next_token(&jp));
if (jp.token.kind != AZ_JSON_TOKEN_BEGIN_OBJECT)
{
return AZ_ERROR_PARSER_UNEXPECTED_CHAR;
}

bool found_expires_in = false;
bool found_access_token = false;

AZ_RETURN_IF_FAILED(az_json_parser_next_token(&jp));

while (jp.token.kind != AZ_JSON_TOKEN_END_OBJECT)
{
if (az_json_token_is_text_equal(&jp.token, AZ_SPAN_FROM_STR("expires_in")))
{
    AZ_RETURN_IF_FAILED(az_json_parser_next_token(&jp));
    AZ_RETURN_IF_FAILED(az_json_token_get_uint64(&jp.token, expires_in_seconds));
    found_expires_in = true;
}
else if (az_json_token_is_text_equal(&jp.token, AZ_SPAN_FROM_STR("access_token")))
{
    AZ_RETURN_IF_FAILED(az_json_parser_next_token(&jp));
    *json_access_token = jp.token;
    found_access_token = true;
}
else
{
    // ignore other tokens
    AZ_RETURN_IF_FAILED(az_json_parser_skip_children(&jp));
}
AZ_RETURN_IF_FAILED(az_json_parser_next_token(&jp));
}

if (!found_expires_in || !found_access_token)
{
return AZ_ERROR_ITEM_NOT_FOUND;
}

return AZ_OK;

TODO:

[ ] Add back tests that validate az_json_token_get_double results when double support is enabled, along with az_json_token_get APIs for all other numeric types (atox).
[ ] Add support for characters escaped in the form of \uXXXX where XXXX is the UTF-16 code point.
[ ] Additional testing to improve code coverage, including parsing valid and incomplete JSON payloads.
[ ] Should az_json_parser be renamed to az_json_tokenizer or az_json_reader, since that seems more accurate to what it actually does (reads token, forward-only)?

This PR improved the line and branch coverage of the parser, but there is still some more room to improve (particularly branch coverage), outside of preconditions.
Before:

After:


[BUG]Failed to take snapshot for RKE2 cluster

Rancher Server Setup

Rancher version: v2.7.1
Installation option (Docker install/Helm Chart): Docker install with external k3s cluster

Information about the Cluster

Kubernetes version: v1.24.9+rke2r2
Cluster Type (Local/Downstream):

If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): Custom with normal VM

User Information

What is the role of the user logged in: Admin

Describe the bug
I am using a signal node for RKE2 custom cluster with following OS info/configuration:

Item
value

OS
Ubuntu 22.04 LTS

Mountpoint
/ /usr/local

After the RKE2 cluster is active, I can't take etcd-snapshot from Rancher UI for this cluster.
To Reproduce

Provision a new VM with additional mount point /usr/local.
Create a custom RKE2 cluster from Rancher.
Run registration command in the newly created VM and wait for the cluster active.
Take etcd-snapshot in Rancher UI.

Result
No snapshot shows in the snapshot list page.
Expected Result
Expected one snapshot shows in the list.
Additional context
Found the root cause in rancher-system-agent and RKE2 install script:
In https://github.com/rancher/rke2/blob/master/install.sh#L122-L128, the RKE2 binary install path will be /opt/rke2 if the /usr/local is a mount point. Meanwhile, the rancher-system-agent running environment doesn't have /opt/rke2/bin in PATH list. So the rancher-system-agent has no way to run rke2 etcd-snapshot and the take snapshot command failed with exit 127 command not found error.

Would this not be fixed via https://github.com/rancher/system-agent/pull/90 ?

Would this not be fixed via rancher/system-agent#90

If #90 only kicks in if /usr/local is ro, then this is still needed.  I've ran into this here running RKE2 on SLEMicro via Elemental and /usr/local is rw, but snapshots fail due to /opt/rke2/bin not being in PATH.
Jul 26 19:31:58 m-378cf636-8497-40f5-942d-991e71c94077 rancher-system-agent[48506]: time="2023-07-26T19:31:58Z" level=info msg="[Applyinator] Running command: rke2 [etcd-snapshot save]"
Jul 26 19:31:58 m-378cf636-8497-40f5-942d-991e71c94077 rancher-system-agent[48506]: time="2023-07-26T19:31:58Z" level=error msg="error executing instruction 1: exec: \"rke2\": executable file not found in $PATH"

/usr/local is a mount point, but rw:
# mount | grep /usr/local
/dev/sda5 on /usr/local type ext4 (rw,relatime)

If I manually add /sbin:/usr/sbin:/usr/local/sbin:/root/bin:/usr/local/bin:/usr/bin:/bin:/opt/rke2/bin to /etc/systemd/system/rancher-system-agent.env then systemctl daemon reload && systemctl restart rancher-system-agent then snapshots work again on that node until there's an update to the cluster config or the node is rebooted.

Looks like https://github.com/rancher/system-agent/issues/101 is related and the pathing also needs patched in the rancher system-agent installer as well.

The issue still persists today (rancher 2.8.3, opensuse leap 15.5). Are there any (other) persistent workarounds available for now?

As a workaround,  I added this in /etc/profile  PATH=/var/lib/rancher/rke2/bin:/opt/rke2/bin:$PATH. It worked flawlessly afterwards. This might be a bit overkill but at least it worked.


Use Dockerfile to build GraalVM

For consistency and simplicity use a Dockerfile to build GraalVM images.  There's also apparently an issue with the GraalVM action, stopping the PR Open workflow.

Changes from https://github.com/bcgov/nr-forest-client-api/pull/178 copied into https://github.com/bcgov/nr-forest-client-api/pull/174.


feat: Implement print without newline

Description
Problem*
Resolves  https://github.com/noir-lang/noir/issues/3575
Resolves https://github.com/noir-lang/noir/issues/2912 (duplicate)
Continuation of https://github.com/noir-lang/noir/pull/3576
Summary*
Refactors println_oracle method into print with boolean indicator, allowing print to coexist with println under the same ForeignCall string symbol.
Updates appropriate tests, and logging.md documentation.
Add a subchapter to 03_string.md documentation for the fmtstr type
Additional Context
Documentation*
Check one:

[ ] No documentation needed.
[x] Documentation included in this PR.
[ ] [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench do you know why this check is failing?

Yep, that's a fork issue.

Test / Test on ubuntu (pull_request)  is failing, can force merge once that is fixed

Test / Test on ubuntu (pull_request)  is failing, can force merge once that is fixed

I've swapped the order of the oracle args to be safe(r).
@jfecher what say you? :)

JS Tests failing

IDK about this, @TomAFrench @kevaundray ?

cc @signorecello for the minor doc changes ICYMI

Very useful and nicely documented, thanks!


Display time stamp for events database

Is your feature request related to a problem? Please describe.
When Mobiflight updates events, there is no way of telling the events database currently available or how old it is.
Describe the solution you'd like
Display a time stamp representing the snapshot time of the database currently installed.  It could be displayed in Extras - Hubhop update option.  I think this will probably require the time stamp to be stored in Hubhop and updated every time a change in the database is accepted.
Describe alternatives you've considered
No alternative currently exists, and there is no way of telling how old the current database installed is.
Additional context
Not knowing the database age is an issue compounded by the fact that Mobiflight installation installs a very old database file.  I think most users are unaware of this and assume that installing Mobiflight also installs an updated set of events.  The reality is the contrary of that.

I think the root of the problem is that the install / upgrade of a new version installs the hubhob events db that can be even older than what you had prior to the upgrade.
I think the simplest solution is like what is done with the WASM module: just prompt to install it when you update MobiFlight. Either by asking the user, or just doing it, because hubhop is such an integrated part of the software now.

Based on what @JaimeLeon2 is describing, we have the date when the event was last updated. So we could even show it for every preset. We could then also check online if there is a new version of this particular one available.
I think starting with the timestamp of the database (e.g. download time) is a start which might be useful when supporting users. But then again, is it not more valuable to know what version or timestamp the individual preset has?

linked to #1280
i just noticed that in my comment before I was more going along with the idea as descirbed in #1280

My idea was for Hubhop to manage a "last change time stamp" which is sent with every database update request as a sort of database version number, that could be used to:

Show in MF Connector the database "version" installed (not necessarily the download date), which can also indicate how old the version is.
In Hubhop, it can be used to decide that there is no need to re-download the database file kept in the browser cache.  In particular, downloading the database with every page refresh, as currently done, seems like a big waste of time and bandwidth, IMO.  Particularly annoying for those of us that are 7000 miles away from the server.

we can improve that logic later down the road. the local date of your database is currently displayed. It will help us during support and in a first iteration we remind the user to update every 7 days

Not in Mobiflight, unless you know you want the very latest update that was made, which is often the case when supporting people and making missing events in Hubhop, on request from someone.
When working in Hubhop, you do want to have the very latest database.  Problem is that Hubhop updates the database with or without any changes made.


Implement filtering in companies based of options chosen

As in title, right now the component shows all the companies provided in file.

I think search options should include study field [like Information Technology], because the 1st year does not have assigned specialization.


Updated build

Hi,
is it possible to have a build with the latest commits?

Try http://ul.to/2tbjb6sl for the time being.
Warning: fully untested, I just let gradle run and uploaded it as there was no build error. Most likely there is also a good reason why marvin didn't release it yet.

@bonanza123: Thanks but uploaded.net do not work currently.

Closed in favor of this: https://github.com/microg/microg.org/issues/7


Allow modification of previously generated PNG or SVG images

It would be great to allow the edit of previously generated waveforms.Currently, this is possible only by keeping a copy of the JSON source.
Is it possible to store the source JSON in the image metadata, so that it can be automatically extracted by wavedrom? With PNGs it should be possible by using textual data (even unicode with iTXt) and SVG should support it within the <metadata> tag.
Thanks

Awesome idea @corna. In SVG, do you see it as one of the standard "metadata" types? RDF, OWL, SKOS,... or just blob of multiline text? Could you give an example of how it should look like?

Unfortunately I have no experience on SVGs other than just using them.

I was poking around on how to do ths with PNG.  Here are some breadcrumbs

https://stackoverflow.com/questions/48243115/how-do-i-insert-a-png-comment-block-when-saving-an-html5-canvas-using-javascript
https://stackoverflow.com/questions/44489503/how-can-i-append-a-text-chunk-into-a-canvas-data-array-and-save-it-as-a-png-file
https://github.com/xgds/pngtoy


Another lightweight depth model RM-Depth (2.97M) in CVPR 2022

Just want to remind that there actually exists another lightweight depth model RM-Depth (CVPR 2022). It has a model size 2.97M while it achieves AbsRel = 0.107 on KITTI and AbsRel = 0.090 on Cityscapes testing sets. Unfortunately, it is not cited.

Hi, thanks for the information. It is a pity that we did not notice the existence of this paper.


github-runner: 2.306.0 -> 2.307.1

Description of changes

Release notes: https://github.com/actions/runner/releases/tag/v2.307.1
Diff: https://github.com/actions/runner/compare/v2.306.0...v2.307.1
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

As always, thank you @newAM!


Not getting control: "text" value as arg in exec fn of custom functions

eKuiper version: 1.10.0.

I ran eKuiper in Docker and created a custom function called Point_Within. The function has four parameters, where the first two are field names and the third and fourth arguments are  text values that the first arguments are checked against. However, the third and fourth arguments are nil values as they are not passed in message.
To reproduce the issue, I modified the echo.json file for the custom function echo by replacing the control field with "text".
Here is the updated echo.json content:
{
	"about": {
	  "trial": false,
	  "author": {
		"name": "EMQ",
		"email"<EMAIL_ADDRESS>		"company": "EMQ Technologies Co., Ltd",
		"website": "https://www.emqx.io"
	  },
	  "helpUrl": {
		"en_US": "https://ekuiper.org/docs/en/latest/sqls/custom_functions.html",
		"zh_CN": "https://ekuiper.org/docs/zh/latest/sqls/custom_functions.html"
	  },
	  "description": {
		"en_US": "",
		"zh_CN": ""
	  }
	},
	"name": "echo",
	"functions": [
	  {
		"name": "echo",
		"example": "echo(col1 )",
		"hint": {
		  "en_US": "The parameter value is output as it is.",
		  "zh_CN": "原样输出参数值。"
		},
		"args": [
		  {
			"name": "data",
			"hidden": false,
			"optional": false,
			"control": "text",
			"type": "string",
			"hint": {
			  "en_US": "The data to echo.",
			  "zh_CN": "字段名"
			},
			"label": {
			  "en_US": "Field",
			  "zh_CN": "字段"
			}
		  }
		],
		"return": {
		  "type": "string",
		  "hint": {
			"en_US": "Echoed string",
			"zh_CN": "回声值"
		  }
		},
		"node": {
		  "category": "function",
		  "icon": "iconPath",
		  "label": {
			"en_US": "Echo",
			"zh_CN": "回声"
		  }
		}
	  }
	]
}

Please note that it appears that none of the custom functions are currently producing correct results when a text field is used.

Are you talking about using the function in eKuiper manager? What are the steps to reproduce the problem?

Are you talking about using the function in eKuiper manager? What are the steps to reproduce the problem?

Step 1: Replace echo.json , arg[0].control as "text" and build the docker image.
Step 2: create a flow using ekuiper manager, give expr=echo(abc).
Result should be echo:"abc" instead Iam getting echo: null as no field named 'abc' was present in the message sent.
I compared it with power function where in power(x,y) y is a constant in a flow. The same is not reflected in echo function even when I gave "control": "text" in echo.json. Please refer the issue for full echo.json.

Looks like a UI problem.  I can pass over the problem to the UI team. But please note that eKuiper manager is not part of this open source project.

Looks like a UI problem. I can pass over the problem to the UI team. But please note that eKuiper manager is not part of this open source project.

Not a UI Problem. Even if I create the flow using api, same issue is occuring. the problem is that custom functions are not providing control:"text" fields as args in exec function.

ah, that's not related to the json file. I was misled. So echo(abc) here abc is a field/name. It expects the data has that field of type string. If you need a string literal, use echo("abc")
获取Outlook for Androidhttps://aka.ms/AAb9ysg

From: Jislin Anna @.>
Sent: Thursday, June 15, 2023 10:22:00 PM
To: lf-edge/ekuiper @.>
Cc: ngjaying @.>; Comment @.>
Subject: Re: [lf-edge/ekuiper] Not getting control: "text" value as arg in exec fn of custom functions (Issue #2000)
Looks like a UI problem. I can pass over the problem to the UI team. But please note that eKuiper manager is not part of this open source project.
Not a UI Problem. Even if I create the flow using api, same issue is occuring. the problem is that custom functions are not providing control:"text" fields as args in exec function.
―
Reply to this email directly, view it on GitHubhttps://github.com/lf-edge/ekuiper/issues/2000#issuecomment-1593163331, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGBOYBPS7IBY44NMWQZTTTXLMLARANCNFSM6AAAAAAZH243FQ.
You are receiving this because you commented.Message ID: @.***>

Thank you. Its working


Optimistic Concurrency  can not get current DatabaseValues

on the process of DbUpdateConcurrencyException
how  to get  current DatabaseValues

We will add APIs like we had in EF6 - this is already tracked by https://github.com/aspnet/EntityFramework/issues/1200
In the meantime, a NoTracking query can be used to get a copy of the entity with the current database values:
var databaseVersion = context.Blogs.AsNoTracking().Single(b => b.Id == blogId);


How to enable export to pdf

No information on how to enable 'Export to PDF' which is discussed and not enabled out of the box as far as I can see.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: e8596165-16ef-05c1-c680-6985a018b61b
Version Independent ID: 1f939390-0290-da47-7209-eedea80c271b
Content: Advanced options for inspections in Dynamics 365 Field Service (contains video)
Content Source: ce/field-service/inspections-advanced.md
Service: dynamics-365-field-service
GitHub Login: @josephshum
Microsoft Alias: jshum

Hello @IanPodmore - thanks for raising this issue. I'll look into it but may need help from the feature owner to confirm updates. Given that holidays are around the corner, folks might be hard to get a hold of. Please expect delays with the update.
Thanks,
Michael

Thanks for your comment, @IanPodmore. This issue has been assigned to the doc author for review.

@IanPodmore - apologies for the delay. Please make sure the inspection template is saved and published before trying to export to PDF. I tested the export to PDF and it's working without additional configuration for me.
However, the team found a bug that the export doesn't work if the inspection contains a question that requires a date/time. A fix is already underway and should roll out soon.
I'll make some tweaks to the doc to update the actual UI references and close this issue when I publish the doc update. Please reopen or create a new issue if it's still not working for you.
Thanks, and please keep the feedback coming!
Michael