added median func

Do the checklist before submitting the PR:

[ x] Have you read the guidelines mentioned in CONTRIBUTING.md?
[ x] Have you squashed your commits?

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0)
A: v10.14.2
Q: Mention the Issue Number! (e.g. Fixed #8)
A: Fixed #108

Give additional information regarding the PR below:

added function to find median

Codecov Report

Merging #120 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #120   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          65     66    +1
  Lines         879    888    +9
=====================================
+ Hits          879    888    +9

Impacted Files
Coverage Δ

src/median/index.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edbf9ea...41fe223. Read the comment docs.


Update translations

Automated message from Dropbox CLA bot
@borisyankov, it looks like you've already signed the Dropbox CLA. Thanks!


Updated terminology to use memory integrity instead of HVCI

@vinaypamnani-msft - Can you help get this merged?

@barrygolden Can you help with this PR please?


⚠ Bofrost.be has degraded performance

In c93bdc9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2099 ms

Resolved: Bofrost.be performance has improved in 327f3b0.


Here we go again ...

"...we recommend that you use ISO-standard C++ exception handling..."

AFAIK, Windows OS is written in C and core SDK is C API
Core of Windows is using SEH and raises SE
MS STL can be legally compiled into C++ projects not using C++ Exceptions
- In such a scenario
- MS STL raises Structured Exceptions
- C++ keywords throw/try/catch  do not compile

This page might be highly confusing? People and projects working for mission-critical systems can not follow this advice? Any project using ISO C, can not follow this advice. Latest CL (16.8) update will be also (almost 100%) standard C11 and C17 compiler, it appears ISO C is not "abandoned" after all.
Kind regards ...
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6820eb86-7922-fc81-a6cd-80fbf6143726
Version Independent ID: 3e2936b4-498d-0656-17d3-d4fa6566630c
Content: Structured Exception Handling (C/C++)
Content Source: docs/cpp/structured-exception-handling-c-cpp.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @corob-msft
Microsoft Alias: corob

@DBJDBJ
Thanks for the feedback. As I read the article, I don't see anything particularly confusing about it. The simplest reading of the opening paragraph is, don't use SEH in C++ code unless you need to. SEH doesn't have the facility or portability of C++ standard exception handling, so we don't recommend it as a substitute. If this advice doesn't apply to you, we expect you'll know.
When you claim "MS STL raises Structured Exceptions" absent standard (/EHsc) exception handling, it appears to reflect a misunderstanding of what's going on and what it costs. Use of SEH incurs costs just like regular C++ exception handling does. C++ exception handling is in fact built on top of SEH by MSVC's implementation. C++ EH does extra work for type matching and local object unwinding (work you would have to manually replicate in your finalizers anyway for leak-free code), but the non-trivial cost of raising and catching an exception is still there in the base SEH mechanism. If you're trying to avoid the costs of exception handling by substituting SEH, you're bound to be disappointed. The only way to avoid the costs of exception handling is, don't use exception handling. It may be slightly cheaper, but there are no free lunches to be had by using SEH.

Hi Rob :)
My text is not  about the "costs" but the service MS STL also provides. Page text as it is misleading as it advises the unknown audience to use c++ exceptions. Confusing the decision-makers in turn. Many of whom simply can not use C++ exceptions, RTTI or even heap allocation.
I have measured MS STL in an SEH mode and it is (much) faster than C++ exceptions mode. Almost as fast as EASTL.  Do I need to understand more?
I just have this feeling MS STL SEH mode is somewhat "hidden" from the world? Is there any authoritative post on MS STL SEH? The reasons and history behind? I myself discovered MS STL SEH almost by accident.
Also, there are seasoned C/C++ developers who simply do not like the idea of exceptions. Me including. Windows is C. Win32 is C. And SEH is in the foundations of Windows. Thus each and every mildly serious WIN service, or some such component, is C + SEH.  One can not ignore that.  I just do not see that history and fact permeating MS DOCS enough :)
If and when Windows would be written in C++, throwing C++ exceptions, then I would follow that philosophy.

I think I mentioned before that your "discovery" about SEH in the STL is an emergent property fluke, and is not recommended, completely unsupported, and likely to get you weird bugs that are hard to diagnose. And I can't repeat often enough that we do indeed recommend C++ standard exceptions for your C++ exception handling needs. If the runtime cost is prohibitive, SEH is a really poor substitute. And it's one that's being misused if you're doing anything like regular C++ exception handling with it. SEH has its place, and it's widely used in code built with the Hardware SDK. Lots of that code is actually C++, by the way, as is much of the core Windows OS, except for the shell bits and UWP components written in C#. Often it's just C-with-classes style C++, but that's what the file extensions say for the parts I've seen.

I hear you loud and clear :)
Are you implying the MS STL SEH might be soon deprecated?  I went "deep" inside MS STL and I can not see any "adventure park" in there. That part is clean and well designed and allows for easy switch indeed to/from SEH. I am using it and I can report it makes for very fast MS STL.

ps: the debate we had before was about comdef.h which seemingly is using SEH but "accidentally".
Many thanks  for your time


[BUG] flaky org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled test

Describe the bug
org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled is flaky.
To Reproduce
REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled" -Dtests.seed=6E1ACBAAAA8FA304 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-AR -Dtests.timezone=America/Fortaleza -Druntime.java=20

Expected behavior
Test should always pass
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):

OS: [e.g. iOS]
Version [e.g. 22]

Additional context
CI - https://build.ci.opensearch.org/job/gradle-check/25991/

Closing as duplicate https://github.com/opensearch-project/OpenSearch/issues/10755


Implement direct/group messages

The main problem to solve is that in Mattermost, group chats have immutable membership --- you cannot add new users to existing direct/group chats. This is possible on the Matrix side. How do we want to deal with this? Even if we decide to ignore users added later in matrix (which would lead to a fairly broken user experience), this may cause issues during the initial channel creation.

Hey just a thought: Could we just kick new users out of matrix rooms as soon as they join? An optional bot could post a message about this restriction. If APIs ever changed then it would be easy to migrate away from this scheme (just don't kick new users).

This depends on who creates it; if the room was created by a matrix
user, we don't have the privileges to do that (in "properly" bridged
rooms, we can require the room owner to add the bot and give it some
privileges).
One way that might work (I believe), but isn't too pleasant, is that if
the room was created by a matrix user, we create a private channel for
it (but in what team?).


How to add syntax highlighting to new language?

I added a new .mpsl on the syntax directory but don't know how to have mp make use of it.

hi, you have to recompile mp for your file to be used. anyway, we're about to release a new version, so if you publish your file here we'll include it in the next release.

hi, you have to recompile mp for your file to be used. anyway, we're about to release a new version, so if you publish your file here we'll include it in the next release.

No, thanks. It's syntax highlighting for the language Umka. It's very incomplete. Not yet cover the full lang specs, just the keywords.


Can't connect!

Type: Bug
On Linked accounts hit +
then opens to localhost and shows invalid security lock, and no options to continue.
https://localhost:60101/signin?nonce=3b44f26b-c4f4-4b09-8ce5-ff273dae5fc3
Azure Data Studio version: azuredatastudio 1.46.1 (ba29842b81dec01177415e53948ca2168e69c3f8, 2023-10-02T18:14:22.887Z)
OS version: Windows_NT x64 10.0.22621
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-10300H CPU @ 2.50GHz (8 x 2496)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.84GB (8.46GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

sql-migration
Mic
1.4.10

I had trouble connection also about an hour ago, but the problem resolved itself. Normally one should wait an hour to see if the problem resolves before posting a bug report.
We could use a website which shows if the Azure services are up or down at that moment. That would help to see when they come back up.

duplicate of #24599


whole cards section rebuilt {video added} #1026

closes #1026
This whole section of isckon events rebuilt before and after attached .
redirecting links are also added carefully to right pages respectively
BEFORE :

AFTER:
https://github.com/akshitagupta15june/Moksh/assets/119532943/ac47e229-4866-441a-b1b6-10effe6f3a7c

hey @akshitagupta15june
this will come under level 2 / level 3 right ?

Hey this is not required currently! And some contributor is working on it, next time please create issue before implementing

Okay .


Fix the Preloader Scroll

The preloader has a scroll bar and is scrollable fix this bug.

Hi @soumali28 Please assign this to me


#2305 Evaluation tile rework - backport 0.7.2

See PR #2406

Codecov Report

Merging #2451 into release-0.7.2 will decrease coverage by 0.03%.
The diff coverage is 5.55%.

@@                Coverage Diff                @@
##           release-0.7.2    #2451      +/-   ##
=================================================
- Coverage          35.43%   35.39%   -0.04%
=================================================
  Files                158      158
  Lines               8837     8849      +12
  Branches             173      180       +7
=================================================
+ Hits                3131     3132       +1
- Misses              5223     5234      +11
  Partials             483      483

Flag
Coverage Δ

#moduleA
23.80% <5.55%> (-0.19%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

bridge/client/app/_models/trace.ts
34.48% <ø> (ø)

...uation-details/ktb-evaluation-details.component.ts
13.33% <5.55%> (-0.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a16d4d0...65d1acc. Read the comment docs.


Use mfem/tpls for vcpkg Metis

Patch the vcpkg portfile for Metis used in GitHub Actions on Windows to download the Metis archive from mfem/tpls rather than the official Metis server.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#3106
@pazner
@tzanio
@camierjs + @v-dobrev
7/14/22
⌛due 7/28/22
⌛due 8/4/22

PR Checklist

[ ] Code builds.
[ ] Code passes make style.
[ ] Update CHANGELOG:

[ ] Is this a new feature users need to be aware of? New or updated example or miniapp?
[ ] Does it make sense to create a new section in the CHANGELOG to group with other related features?

[ ] Update INSTALL:

[ ] Had a new optional library been added? If so, what range of versions of this library are required? (Make sure the external library is compatible with our BSD license, e.g. it is not licensed under GPL!)
[ ] Have the version ranges for any required or optional libraries changed?
[ ] Does make or cmake have a new target?
[ ] Did the requirements or the installation process change? (rare)

[ ] Update continuous integration server configurations if necessary (e.g. with new version requirements for each of MFEM's dependencies)

[ ] .github
[ ] .appveyor.yml

[ ] Update .gitignore:

[ ] Check if make distclean; git status shows any files that were generated from the source by the project (not an IDE) but we don't want to track in the repository.
[ ] Add new patterns (just for the new files above) and re-run the above test.

[ ] New examples:

[ ] All sample runs at the top of the example source file work.
[ ] Update examples/makefile:

[ ] Add the example code to the appropriate SEQ_EXAMPLES and PAR_EXAMPLES variables.
[ ] Add any files generated by it to the clean target.
[ ] Add the example binary and any files generated by it to the top-level .gitignore file.

[ ] Update examples/CMakeLists.txt:

[ ] Add the example code to the ALL_EXE_SRCS variable.
[ ] Make sure THIS_TEST_OPTIONS is set correctly for the new example.

[ ] List the new example in doc/CodeDocumentation.dox.
[ ] If new examples directory (e.g.examples/pumi), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add example-specific documentation, see e.g. the src/examples.md.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] In examples.md, list the example under the appropriate categories, add new categories if necessary.
[ ] Add a short description of the example in the "Extensive Examples" section of features.md.

[ ] New miniapps:

[ ] All sample runs at the top of the miniapp source file work.
[ ] Update top-level makefile and makefile in corresponding miniapp directory.
[ ] Add the miniapp binary and any files generated by it to the top-level .gitignore file.
[ ] Update CMake build system:

[ ] Update the CMakeLists.txt file in the miniapps directory, if the new miniapp is in a new directory.
[ ] Add/update the CMakeLists.txt file in the new miniapp directory.
[ ] Consider adding a new test for the new miniapp.

[ ] List the new miniapp in doc/CodeDocumentation.dox
[ ] If new miniapps directory (e.g.miniapps/nurbs), add it to MINIAPP_SUBDIRS in the makefile.
[ ] If new miniapps directory (e.g.miniapps/nurbs), list it in doc/CodeDocumentation.conf.in
[ ] Companion pull request for documentation in mfem/web repo:

[ ] Update or add miniapp-specific documentation, see e.g. the src/meshing.md and src/electromagnetics.md files.
[ ] Add the description, labels and screenshots in src/examples.md and src/img.
[ ] The miniapps go at the end of the page, and are usually listed only under a specific "Application (PDE)" category.
[ ] Add a short description of the miniapp in the "Extensive Examples" section of features.md.

[ ] New capability:

[ ] All new public, protected, and private classes, methods, data members, and functions have full Doxygen-style documentation in source comments. Documentation should include descriptions of member data, function arguments and return values, template parameters, and prerequisites for calling new functions.
[ ] Pointer arguments and return values must specify whether ownership is being transferred or lent with the call.
[ ] Any new functions should include descriptions of their intended use e.g. for internal use only, user-facing, etc., along with references to example code whenever possible/appropriate.
[ ] Consider adding new sample runs in existing examples to highlight the new capability.
[ ] Consider saving cool simulation pictures with the new capability in the Confluence gallery (LLNL only) or submitting them, via pull request, to the gallery section of the mfem/web repo.
[ ] If this is a major new feature, consider mentioning it in the short summary inside README (rare).
[ ] List major new classes in doc/CodeDocumentation.dox (rare).

[ ] Update this checklist, if the new pull request affects it.
[ ] Run make unittest to make sure all unit tests pass.
[ ] Run the tests in tests/scripts.
[ ] (LLNL only) After merging:

[ ] Update internal tests to include the new features.

@kanye-quest and @adrienbernede, our GitHub CI is currently broken because the Windows tests, using vcpkg, can't download METIS from their official URL.
This is unfortunately not uncommon with METIS, http://glaros.dtc.umn.edu has been down before, which is why we have our own mirror at https://github.com/mfem/tpls.
Can you please take a look at this hotfix (replacing the official URL with our mirror) and let us know if this is the best way to resolve this issue?
Thanks!
Tzanio

Would it be possible to cache (in the sense of GihHib Actions cache), the installation path of Metis (which seems to be the vcpkg-cache) ?
To put it shortly: can't we cache vcpkg-cache?
(We could give that cache a key parametrized by Metis version.)

I'm not knowledgeable enough about this topic to know the answer to this…

@adrienbernede: I originally tried caching the vcpkg "binary cache" with the Github Actions cache action -- but it doesn't seem to be updating the cache entry after building Metis:
Cache hit occurred on the primary key Windows-seq-vcpkg-v1, not saving cache.
Any thoughts? Do we need a unique cache key for each run in order to update the cache entry?
Alternatively, there's a possibility of putting the vcpkg cache in Microsoft's NuGet (see here)

@kanye-quest the problem is indeed that the key being fix on your case, after caching once GitHub will hit the cache. So if you want to update the content of the cache, you need to change the key.
The basic way is to use numbered versions (v1, v2, etc), but you can also use variables, like the Metis version to make sure a change of the version leads to a rebuild of the cache.
It is also possible to use the branch name, so that the cache is generated once per branch, etc.
So I guess you were close to get it to work ;)
@pazner, no worries, thank you for diving into it !

This PR is now under review (see the table in the PR description). To help with the review process, please do not force push to the branch.

Merged in next for testing...


Click collection card

Summary
I don't think this change is correct because the linter made changes to my working copy which I didn't include here, one of which was deleting the App.jsx file. However, it did work locally before I ran git commit.
Please do not merge this; I am trying to learn how to develop for Scout.
Screenshots or Videos (if applicable)
It behaves the same as before, but if you click on the card itself, it also brings you to the collection page. Back button works still.
Related Issues
Related to #259. Thank you for listing "good first issue" issues.
Test Plan

Start Scout
Create collection(s)
Go to my collections page
Click on collection card (not the link)
Press back on browser

Checklist Before Requesting a Review

[Yes] I have performed a self-review of my code
[Did not see any] My code follows the Style Guidelines and Best Practices outlined in the project wiki
[Yes] I have commented my code, particularly in hard-to-understand areas
[No] I have made changes to the documentation, if applicable
[No] My change generates no new warnings or failed tests
[No] If it is a core feature, I have added thorough tests
[No] I have implemented analytics, if applicable

Hi @slayerofdrosophila! Thank you for this PR.
Because this fix was something our team wanted to get done as part of the current sprint, I've gone ahead and opened a separate PR for this issue (PR #321 )
Your PR was very good. The comments I'd have is that we should use react-router's <Link> tag since this would allow the component to render as an anchor tag (<a>) which lets us take advantage of the browser's builtin link behavior (such as ability to tab and access links with "Enter" key). The <Link> component also lets us use react-router's push history, so we don't have to force a refresh.
I encourage you to keep contributing to Scout! This PR came in during a busier time, hence my delay, but I should be able to review any future PRs faster.


'FirebaseCrashlytics/FirebaseCrashlytics-Swift.h' file not found

Description
When update to Lastest version 10.23.1, build failed with error : 'FirebaseCrashlytics/FirebaseCrashlytics-Swift.h' file not found
Reproducing the issue
No response
Firebase SDK Version
10.23.1
Xcode Version
15.3
Installation Method
CocoaPods
Firebase Product(s)
Crashlytics
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Hi @ayang229, this seems related to #12611 and the fix will be released in Firebase 10.24.0. That being said, I'll now be closing this ticket as dupe.


support Zeroc ice

I use zeroc ice as the rpc amount backend servers.
Does envoy support zeroc ice?

No, not currently.


Add Windows CI(Appveyor) and enable unstable features in Travis on stable Rust

I enabled the unstable feature on stable because it's unstable only for Rayon(doesn't contain Rust nightly features). At least in Appveyor, 1.12.0 with the unstable feature enabled fails to build - that's why there is no matrix for 1.12.0 + FEATURES=unstable.
You can see the status of these builds:

Windows: https://ci.appveyor.com/project/lilianmoraru/rayon
Linux/macOS: https://travis-ci.org/lilianmoraru/rayon

On Windows, nightly fails and I don't know why(I don't have a Windows machine to test locally).

On Windows, nightly fails and I don't know why(I don't have a Windows machine to test locally).

Strange!  When I run cargo test on Windows 10, I get three popup dialogs:

It also happens on beta and stable if I cheat the feature usage with set RUSTC_BOOTSTRAP=1.
But the tests for rayon-core run ok.  I suspect it's something to do with compiletest-rs.
We were saying in #277 that it would be nice to run most tests on non-nightly rust too, so one part of that is we'd have to mask compiletest-rs usage to just nightly.  Under that idea, we could also avoid it on Windows for now.

I amended the commit and removed the first cargo test - now it seems to work on nightly.
I still think that should probably be a separate issue - many people use nightly.

OK, well, I agree, that is surprising and should be investigated -- but it seems like we ought to enable these builds at least. Thanks @lilianmoraru !


SSL certs no longer work in MacOS

Refreshed and reloaded certs, they load in Safari and Chrome fine (think chrome needed a restart, maybe).  Firefox interface has regressed - need to download the cert and then import through preferences -> certificates.


Implement optional area-weighting in xskillscore metrics

Currently, the performance metrics implemented in xskillscore (https://github.com/raybellwaves/xskillscore/blob/master/xskillscore/core/deterministic.py) do not allow for weighting by grid cell area when calculating a global-mean skill metric (as is customary in the literature, e.g. Reichler et al. 2008 https://journals.ametsoc.org/doi/abs/10.1175/BAMS-89-3-303).
Step 1 (a simple hack): multiply fields by a grid-cell area field, calculate the skill metric, and divide by the global-mean grid cell area.
Step 2: submit a PR to xskillscore (https://github.com/raybellwaves/xskillscore/) to make this a supported feature.

Now implemented in master branch https://github.com/hdrake/cmip6hack-multigen/pull/12
Will wait to close this issue until area-weighting has been merged into the master branch of xskillscore.


multiple inputs for MapAlignerPoseClustering

Hi,
I tried to use MapAlignerPoseClustering that you have just added into your Galaxy, but I encountered a problem. From a command line, I submit MapAlignerPoseClustering with multiple input files at once, but I am not able to do this in Galaxy. It always runs only with one input file and that is kind of pointless as it does not have any other files against which it would do comparisons and corrections.  Am I missing some button for adding another input files?
Thank you very much for your work!

@trachtok any change you can test https://github.com/galaxyproteomics/tools-galaxyp/pull/254

I think this is solved. Also in the 2.5 version multiple input files are possible.


Removed unnecessary regex files. Changed references to strings.

Certain regex files were created to satisfy MUST requirements and are no
longer needed as they can better be handled with the validator. The
references to these files were changed to strings.

Can we do some type of validation in the schemas (min/max length, or allowable characters)? For example, country code must be two lower-case letters, character sets can only be alphanumeric plus - and _ (maybe, I'm not sure if that's correct), etc.

Oh yeah definitely, I can just do a pattern within the property that calls for it. I'll add that in before I push the RC4 updated schemas out.

Sounds good, thanks, @ATweedMITRE . Do you want to do that in this PR, or do you want me to merge this and then start a new PR?

You're welcome to merge that one and I'll start a new one.

Looks good to me!


correcting indentation in new correct indentation branch

correcting indentation in a new branch and will improve in test cases as well

Well, this changes moves away from the style to use in our collaborator guide anyhow, so we won't be accepting it.

Well, this changes moves away from the style to use in our collaborator guide anyhow, so we won't be accepting it.


Refresh and rework requirements

This PR reworks the requirements files for easier maintenance:

All indirect dependencies have been removed from requirements files.
File requirements_dev.txt contains only direct requirements needed to run numcodecs, with versions pinned. This is something we would track with a bot to automatically upgrade.
New file requirements_test.txt contains packages needed to run tests, not pinned. I have not pinned these because otherwise I fear the churn from a bot would get too much.

TODO:

[ ] tox -e py37 passes locally
[ ] tox -e py27 passes locally
[ ] Changes documented in docs/release.rst
[ ] tox -e docs passes locally
[ ] AppVeyor and Travis CI passes
[ ] Test coverage to 100% (Coveralls passes)

Generally seems reasonable to me.

Thanks @jakirkham. I'll wait for appveyor to pass then merge and setup PyUP if no objections.

As long as it's green, I'm happy. 😄


⚠ Bofrost.be has degraded performance

In c8aa8ed, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2460 ms

Resolved: Bofrost.be performance has improved in e6c4cce.


bugfix: Fix styling issue when using code and hyperlinks in markdown

This pull request addresses the issue of styling when using code and hyperlinks in markdown. The changes ensure that the styles are applied correctly and improve the readability of the markdown content.

Fixes #2

You rock😘


fix: load image from diff endpoints

What does this PR do?
If someone uses a proxy such as redpill to access the model, the original code will not load the image correctly.
What kind of change is this?
Bug fixes (non-breaking change which fixes an issue)
Documentation changes needed?
My changes do not require a change to the project documentation.

Hi @qgpcybs Kindly look into the comments above.


Documentation for render methods need to list input types and output types

Writing a custom render function is difficult because it's not clear (to most users) what the possible input types are, and what the render function should return for each type.
It would help if the documentation auto-generated a table for this stuff.

I'll plan to add a section that links to all possible dataclasses:

griffe.dataclasses
griffe.docstrings.dataclasses
quartodoc.ast
quartodoc.layouts

I'm not sure this solution is ideal, since it still feels hard having things in 4 places...


Speedtest slower

Hello,
I notice a difference at speedtest tests with Duckduckgo app,and other WebView browser. Same with Chrome/Chromium and Firefox (nightly and other versions). Duckduckgo is always slower.
For exemple, for other WebView browsers :

Firefox Klar/Focus Download ~21M  Upload ~ 10M Ping ~155ms
Duckduckgo (ver. 5.7.0) Download ~7M Upload ~4M Ping ~579ms

[Motorola Moto G 2015 / LineageOS 14.1 (Android 7.1.2)]

Test with : http://speedtest.googlefiber.net/

Thanks for reporting this. I'm going to try look into this shortly to see if there is any obvious reason for you seeing this.

Hello CDRussel,
Thank-you for tour answer ans help.
Two sites videos don't play all time (slowly for playing):
https://www.publicsenat.fr/direct
http://lcp.fr/le-direct/tnt
Maybe the same problem (or not)...

Again slowly with 5.7.5 version (f-droid)

I tested this as well and I don't see any differences at my end. If anything, Firefox and Google Chrome were slower. I think the speed test is affected by multiple parameters and DuckDuckGo Android app is specifically not causing anything, at least at my end.

@arunsathiya Hello,
Thank-you for the tests.
Firefox and Chrome are slower, you're right.
But the difference is with "Firefox Focus" (another privacy browser).

We have an upcoming, reasonably big change to the way we upgrade requests to HTTPS if it's possible to do so.
After that change is made, I'm going to do some benchmarking and try and identify any obvious bottlenecks which could be affecting the speed.
As for the download speed testing sites, they initialise a lot of requests that the app downloads, so any bottleneck, no matter how small, is amplified by the vast number of requests it spawns. So if there was a single big file being downloaded, the difference wouldn't be as noticeable; the problem is likely the overhead incurred per request.
In any case, thanks for all the info and I'll be looking into this as soon as the HTTPS change is merged.

Thanks for logging this @reno-a, we are currently working on performance internally. Watch out for it in future merges/updates.


Add compile-time support for allowSystemProxy client config setting

At present, it's not possible to use aws-kms-pkcs11 with a proxy other than by manually editing source code and recompiling. This is obviously less-than-ideal.
The AWS C++ SDK recently added support for honoring traditional system proxy environment variables [1]. This commit starts using this new option in aws-kms-pkcs11.
The setting defaults to off, because the PR was only merged relatively recently (Sept 2023) and is not likely to have made it into distribution repositories yet. The setting can be toggled at compile time by setting AWS_SDK_USE_SYSTEM_PROXY=y, following the existing y/n conventions.
Documentation is updated accordingly.
[1] https://github.com/aws/aws-sdk-cpp/pull/2679

Cool, this works for me. Since the library is statically linked in the CI build, I'd also be ok not hiding this behind a flag and bumping that, making it the minimum version to compile. Though as I recall updating the SDK version in the CI build was kind of painful last time I tried. 😅


npm ERR! could not determine executable to run

Please select the area your bug applies to. (Multiple selections are possible. You can leave it blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/auto-complete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[X] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
Followed instructions - "Publish > Quick Start" - all went well until...
"Clone the Next.js repository and install dependencies | npx dendron publish init"
To Reproduce
See above
Expected behavior
npm ERR! could not determine executable to run
Screenshots
See copy of log below
Desktop (please complete the following information)

OS: MacOS v12.3 (21E230)
Browser Safari v15.4 (176<IP_ADDRESS>.6)
Versions (all that apply to bug):

Dendron Extension: v0.88.0
VS Code version: Version: 1.65.2
Dendron CLI: Latest version; fresh install; see log below

Additional context
0 verbose cli [
0 verbose cli   '/usr/local/bin/node',
0 verbose cli   '/usr/local/lib/node_modules/npm/bin/npm-cli.js',
0 verbose cli   'exec',
0 verbose cli   '--',
0 verbose cli   'dendron',
0 verbose cli   'publish',
0 verbose cli   'init'
0 verbose cli ]
1 info using<EMAIL_ADDRESS>2 info using<EMAIL_ADDRESS>3 timing npm:load:whichnode Completed in 0ms
4 timing config:load:defaults Completed in 1ms
5 timing config:load:file:/usr/local/lib/node_modules/npm/npmrc Completed in 0ms
6 timing config:load:builtin Completed in 1ms
7 timing config:load:cli Completed in 1ms
8 timing config:load:env Completed in 0ms
9 timing config:load:file:/Users/umbyology/Documents/Projects/Dendron/OneRPG/.npmrc Completed in 0ms
10 timing config:load:project Completed in 6ms
11 timing config:load:file:/Users/umbyology/.npmrc Completed in 0ms
12 timing config:load:user Completed in 0ms
13 timing config:load:file:/usr/local/etc/npmrc Completed in 0ms
14 timing config:load:global Completed in 0ms
15 timing config:load:validate Completed in 0ms
16 timing config:load:credentials Completed in 0ms
17 timing config:load:setEnvs Completed in 1ms
18 timing config:load Completed in 11ms
19 timing npm:load:configload Completed in 11ms
20 timing npm:load:setTitle Completed in 13ms
21 timing config:load:flatten Completed in 2ms
22 timing npm:load:display Completed in 3ms
23 verbose logfile /Users/umbyology/.npm/_logs/2022-03-30T00_59_47_457Z-debug-0.log
24 timing npm:load:logFile Completed in 4ms
25 timing npm:load:timers Completed in 0ms
26 timing npm:load:configScope Completed in 0ms
27 timing npm:load Completed in 31ms
28 http fetch GET 200 https://registry.npmjs.org/dendron 623ms (cache revalidated)
29 timing command:exec Completed in 633ms
30 verbose stack Error: could not determine executable to run
30 verbose stack     at getBinFromManifest (/usr/local/lib/node_modules/npm/node_modules/libnpmexec/lib/get-bin-from-manifest.js:17:23)
30 verbose stack     at exec (/usr/local/lib/node_modules/npm/node_modules/libnpmexec/lib/index.js:115:15)
30 verbose stack     at async module.exports (/usr/local/lib/node_modules/npm/lib/cli.js:66:5)
31 verbose pkgid<EMAIL_ADDRESS>32 verbose cwd /Users/umbyology/Documents/Projects/Dendron/OneRPG
33 verbose Darwin 21.4.0
34 verbose argv "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/bin/npm-cli.js" "exec" "--" "dendron" "publish" "init"
35 verbose node v16.14.2
36 verbose npm  v8.5.0
37 error could not determine executable to run
38 verbose exit 1
39 timing npm Completed in 902ms
40 verbose code 1
41 error A complete log of this run can be found in:
41 error     /Users/umbyology/.npm/_logs/2022-03-30T00_59_47_457Z-debug-0.log
Dendron Log file
Newb here, where do I get the Log?

Hey @OldManUmby. Thanks for reporting the issue.
Did you happen to run npx dendron publish export?
From the logs it seems like npx is grabbing the package dendron which is unfortunately not affiliated with us. dendron is an alias to dendron-cli, which will only work with npx if you locally have dendron-cli installed.
Could you try the last step instead with npx dendron-cli ... and see if that resolves your issue?

I'll have some time this weekend, I'll take another look and get back to you. THX for the reply!
Umby

On Mar 31, 2022, at 10:34 AM, Mark Hyunik Choi @.***> wrote:
Hey @OldManUmby https://github.com/OldManUmby. Thanks for reporting the issue.
Did you happen to run npx dendron publish export?
From the logs it seems like npx is grabbing the package dendron https://www.npmjs.com/package/dendron which is unfortunately not affiliated with us. dendron is an alias to dendron-cli, which will only work with npx if you locally have dendron-cli installed.
Could you try the last step instead with npx dendron-cli ... and see if that resolves your issue?
—
Reply to this email directly, view it on GitHub https://github.com/dendronhq/dendron/issues/2653#issuecomment-1084754301, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFMAYK2GDVVPZTZQFNX7FS3VCXAXLANCNFSM5SAKCZ6A.
You are receiving this because you were mentioned.

I got this error with npx dendron-cli publish init
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/dendron-cli - Not found
npm ERR! 404
npm ERR! 404  'dendron-cli@latest' is not in this registry.
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

a small thing to mention: the command of installation npm install @dendronhq/dendron-cli@latest was not mentioned in the Dendron CLI page nore in the Publish Page. Maybe consider adding them?

Hey @OldManUmby. Thanks for reporting the issue.
Did you happen to run npx dendron publish export?
From the logs it seems like npx is grabbing the package dendron which is unfortunately not affiliated with us. dendron is an alias to dendron-cli, which will only work with npx if you locally have dendron-cli installed.
Could you try the last step instead with npx dendron-cli ... and see if that resolves your issue?

I followed these directions from your wiki at: https://wiki.dendron.so/notes/e5st4LFLtIwwbQmC6JBaF/#quickstart
Quickstart Summary
This guide walks you through publishing with Next.js.

Prerequisites: Install the latest version of the Dendron CLI
Install yarn (optional)

NOTE: We use yarn to manage all our js commands. npm works as well if you'd rather use it instead. All code examples will use yarn
npm install -g yarn
Steps
Setup: Run the following commands at the root of your Dendron Workspace
From Common:

Update .gitignore
echo .next >> .gitignore

Clone the Next.js repository and install dependencies
npx dendron publish init

STEP TWO IS WHERE I GET THE ERR

@OldManUmby  can you try npm install @dendronhq/dendron-cli@latest or equivalently yarn add @dendronhq/dendron-cli@latest first and then use npx dendron publish init? I had the same error but after installing the CLI everything works correctly.

Here's what happened when I ran npm install @dendronhq/dendron-cli@latest ...
npm install @dendronhq/dendron-cli@latest
npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition. node-fetch provides its own type definitions, so you do not need this installed.
npm WARN deprecated<EMAIL_ADDRESS>Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition. airtable provides its own type definitions, so you do not need this installed.
npm WARN deprecated<EMAIL_ADDRESS>`mdast` was renamed to `remark`
npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

added 616 packages, and audited 617 packages in 47s

148 packages are looking for funding
  run `npm fund` for details

11 high severity vulnerabilities

To address issues that do not require attention, run:
  npm audit fix

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

Then I ran npx dendron publish init and got this ...
npx dendron publish init

===================
Telemetry notice 🌱
===================
Dendron collects limited usage data to help improve the quality of our software.

You can learn everything about our telemetry policies by visiting the following link:
https://wiki.dendron.so/notes/84df871b-9442-42fd-b4c3-0024e35b5f3c.html

If you would like to opt out, follow the instructions below:
https://wiki.dendron.so/notes/84df871b-9442-42fd-b4c3-0024e35b5f3c.html#how-to-opt-out-of-data-collection
no workspace detected. --wsRoot must be set

Any Suggestions?

seems your error is only no workspace detected. --wsRoot must be set
In which folder did you run this npx dendron publish init?

OH RATS FART! ... my bad.
However, I still got the same ERR this time ...
npx dendron publish init
npm ERR! could not determine executable to run

npm ERR!      /Users/umbyology/.npm/_logs/2022-04-04T22_21_56_655Z-debug-0.log

@OldManUmby It's still npm install @dendronhq/dendron-cli@latest because you installed the node package in the wrong directory. You need to install it in the current folder (or globally). And after that the npx dendron publish init can run.
You can uninstall the older one.

Ah got it! ... THX. Close issue.

I'm glad that we solved our problems.
But for me the docs can be improved because the "Prerequisites: Install the latest version of the Dendron CLI" was not very clear. Maybe I should create a new issue or PR.

a small thing to mention: the command of installation npm install @dendronhq/dendron-cli@latest was not mentioned in the Dendron CLI page nore in the Publish Page. Maybe consider adding them?

Hi.  I'm getting similar issues, but problems occur when I run npm install @dendronhq/dendron-cli@latest per this thread.
2023-01-19T21_00_10_114Z-debug-0.log

@texylvanian it seems your problem is 3813 error node-pre-gyp ERR! install request to  https://github.com/TryGhost/node-sqlite3/releases/download/v5.1.4/napi-v6-win32-unknown-x64.tar.gz failed, reason: unable to get local issuer certificate
Looks like a different issue to me, maybe create a new one? (and close this one please @OldManUmby )


[Hub Generated] Review request for Microsoft.Marketplace to add version stable/2021-10-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No refresh required for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[ ] Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

tried to update wrong api version

was a mistake closing - this is the right api version, some breaking changes will happen - won't affect any one as this was not published through ms docs yet

@anuchandy hi, is there anyway to ignore the CamelCase error in LintDiff? that's a legacy code that I don't want to change but do want to publish


nginx: change log and cache directories

Motivation for this change
Change locations log and cache folders
cc @flokli @aanderse @Mic92 @delroth @jtojnar @danbst
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

What's the motivation for this change?

https://github.com/NixOS/nixpkgs/issues/85752#issuecomment-618080240
https://github.com/NixOS/nixpkgs/issues/34378

@GrahamcOfBorg eval

please rebase your branch ontop of master, and force push to fix eval:
git pull -r origin/master
git push --force .. ..

@GrahamcOfBorg test nginx nginx-etag nginx-pubhtml nginx-sso

How t ocorrect add patch?
    }) ++ [
      ./nix-skip-check-logs-path.patch
    ] ++ optionals (stdenv.hostPlatform != stdenv.buildPlatform) [

@emily reverted commit openresty. I did not find another variant. Please check.

Why was 6d046e1079601c38540d5eb67ce913632898605b reverted? OpenResty is a distribution of nginx with additional patches and modules; keeping the derivations wholly separate will lead to code duplication and drift between the two, making maintenance harder.

With this variant
    }) ++ [
      ./nix-skip-check-logs-path.patch
    ] ++ optionals (stdenv.hostPlatform != stdenv.buildPlatform) [

Error build openresty:
error: value is a path while a set was expected, at nixpkgs/pkgs/servers/http/openresty/default.nix:20:29

How to fix the error?

The evaluation error can be fixed with:
diff --git a/pkgs/servers/http/openresty/default.nix b/pkgs/servers/http/openresty/default.nix
index 0e87b971985..01ee521a2a2 100644
--- a/pkgs/servers/http/openresty/default.nix
+++ b/pkgs/servers/http/openresty/default.nix
@@ -16,8 +16,8 @@ callPackage ../nginx/generic.nix args rec {
     sha256 = "1a1la7vszv1parsnhphydblz64ffhycazncn3ividnvqg2mg735n";
   };

-  fixPatch = patch:
-    runCommand "openresty-${patch.name}" { src = patch; } ''
+  fixPatch = patch: let name = patch.name or (builtins.baseNameOf patch); in
+    runCommand "openresty-${name}" { src = patch; } ''
       substitute $src $out \
         --replace "src/" "bundle/nginx-${nginxVersion}/src/"
     '';

The patch still fails to apply, though; you could either condition on the patch name in fixPatch and replace it with a local OpenResty version (gross), or I think the better approach would be to add skipLogsCheck ? ./nix-skip-checks-log-path.patch to the nginx derivation and pass in an alternate patch path for packages that need it.

Actually, there's no need for a separate patch at all; just need to make OpenResty's fixPatch more robust:
diff --git a/pkgs/servers/http/openresty/default.nix b/pkgs/servers/http/openresty/default.nix
index 0e87b971985..9c01cfb19e1 100644
--- a/pkgs/servers/http/openresty/default.nix
+++ b/pkgs/servers/http/openresty/default.nix
@@ -16,10 +16,11 @@ callPackage ../nginx/generic.nix args rec {
     sha256 = "1a1la7vszv1parsnhphydblz64ffhycazncn3ividnvqg2mg735n";
   };

-  fixPatch = patch:
-    runCommand "openresty-${patch.name}" { src = patch; } ''
+  fixPatch = patch: let name = patch.name or (builtins.baseNameOf patch); in
+    runCommand "openresty-${name}" { src = patch; } ''
       substitute $src $out \
-        --replace "src/" "bundle/nginx-${nginxVersion}/src/"
+        --replace "a/" "a/bundle/nginx-${nginxVersion}/" \
+        --replace "b/" "b/bundle/nginx-${nginxVersion}/"
     '';

   buildInputs = [ postgresql ];

As a general comment, I think it would be better to remove the directories in a postInstall phase than to patch the nginx build system to not create them at all; the latter is more brittle for updates, forks and variants, and should be handled upstream if possible, as @flokli suggested.

As a general comment, I think it would be better to remove the directories in a postInstall phase than to patch the nginx build system to not create them at all; the latter is more brittle for updates, forks and variants, and should be handled upstream if possible, as @flokli suggested.

Deleting directories will not help. Script
	test -d '\$(DESTDIR)`dirname "$NGX_HTTP_LOG_PATH"`' \\
		|| mkdir -p '\$(DESTDIR)`dirname "$NGX_HTTP_LOG_PATH"`'

automatically creates folders.

auto/install only runs at install-time, though, doesn't it? What's the issue with rm -ring the directories after it runs?

Edit: e.g., as simple as postInstall = ''rm -r $out/var/{cache,log}''; might work?

  rm: cannot remove '/nix/store/wgl4fhw3agf4gyc936n6yw9rqyr94kl2-nginx-1.18.0/var/cache': No such file or directory
  rm: cannot remove '/nix/store/wgl4fhw3agf4gyc936n6yw9rqyr94kl2-nginx-1.18.0/var/log': No such file or directory

@GrahamcOfBorg eval

Ah, I see; DESTDIR isn't set at all so the install script tries to mkdir directly in /var. Okay, the patch seems reasonable to me in that case.

This PR definitely needs a changelog entry, and we need to think about how migration paths should look like.
At least the awstats NixOS module, and the service-runner NixOS test seem to contain references to the /var/spool/nginx, which would need to be updated - possibly more.

@GrahamcOfBorg test nginx
@GrahamcOfBorg test nginx
@GrahamcOfBorg test nginx

@GrahamcOfBorg test nginx
@GrahamcOfBorg test nginx-etag
@GrahamcOfBorg test nginx-pubhtml
@GrahamcOfBorg test nginx-sso

@GrahamcOfBorg test nginx
@GrahamcOfBorg test nginx-etag
@GrahamcOfBorg test nginx-pubhtml
@GrahamcOfBorg test nginx-sso

@GrahamcOfBorg test service-runner

@GrahamcOfBorg test service-runner

@GrahamcOfBorg build openresty

While I completely agree with this change I've had encounters with people in the nix community who feel very strong about not removing stateDir like options so I'm curious how well received this change will be after it is merged and starts hitting people's servers :man_thinking:

I'm not an nginx user so there is only so much I can say about this specific change, but I'll reiterate that the overall idea of removing stateDir like options has not been well received in the past, and I expect that this change will cause a fair bit of frustration from some users. Just because you or I agree with a change doesn't mean we have consensus and should proceed.
I think this change represents a larger idea that hasn't received enough discussion from all parties impacted by it and merging prematurely wasn't the best way to proceed. At this point I guess we can just wait and see... time will tell how well accepted or not this change is.

Apologies if this is a simple question but as I'm not well versed with nginx / systemd I'm hoping someone might be able to help - is the log directory location guaranteed to be stable ie. always present under /var/log/nginx? Can I simply safely hardcode path in places where I previously used the value of the stateDir option? Sorry if I missed a note / changelog entry somewhere on how to deal with the removal of the option.

Apologies if this is a simple question but as I'm not well versed with nginx / systemd I'm hoping someone might be able to help - is the log directory location guaranteed to be stable ie. always present under /var/log/nginx? Can I simply safely hardcode path in places where I previously used the value of the stateDir option? Sorry if I missed a note / changelog entry somewhere on how to deal with the removal of the option.

Yes it's now in /var/log/nginx and /var/cache/nginx always.


[FEAT]: Include Turborepo specific stuff

To include easily in a Turborepo monorepo it would be nice to generate a whole lib / package.

It is still a thing.

It is still a thing.


Run SWIG in the default environment

This avoids failures when swig is build in custom envs e.g. with a compiler installed into another location (e.g. /opt)
See also https://github.com/bazelbuild/bazel/issues/4053
Patch by @boegel from https://github.com/bazelbuild/bazel/issues/4053#issuecomment-343134886
Fixes #41806

What version or branch of TensorFlow is this for? I got rid of all the SWIG compile logic around 2.3.

Well the code here is unchanged so I just assumed that the issue still persists. (We always build with this patch applied)
Or is the _py_wrap_cc  rule unused? If so it should be removed.
Besides that this has been an issue since forever so it could be applied to any branch if another release is planned for that.

Okay, sounds good. I'll approve this so anyone can cherrypick easily into any branch. I'll send a change to remove that rule as I don't think anyone still uses it at HEAD.

FTR: Do you know which released version does not use this anymore? Or the commit/PR which removed that? Then we could remove our patch from that version.

https://github.com/tensorflow/tensorflow/commit/7fd9e941e10f76abcea3a398fd02eb93ca343012#diff-38c70d53f71218cab252a7f458600d6d
https://github.com/tensorflow/tensorflow/commit/5fb9558424c2bf8f8c3de762a34bec59c11fa26e#diff-38c70d53f71218cab252a7f458600d6d
2.3 will have these changes.

Alright thanks! As a follow-up it might be a good idea to remove all references to swig.
https://github.com/tensorflow/tensorflow/commit/5fb9558424c2bf8f8c3de762a34bec59c11fa26e#diff-bb845bf0c867fef59b6527c0946799f9L213 looks like it is no longer used but e.g. https://github.com/tensorflow/tensorflow/blob/505a1599c3abfb11fcaafd53d28830886ffd30f8/third_party/systemlibs/syslibs_configure.bzl#L44 still has it.

That's a good idea, I'll look into this now. Thanks!

@Flamefire can you please resolve conflicts ?

Actually sorry, my commit deleting the SWIG stuff went in early. If you'd like you can make the PR to the 2.2 branch and others can cherrypick that commit.

Rebased and changed the target branch

Test failures look like what is fixed with https://github.com/tensorflow/tensorflow/pull/40728 (Numpy 1.19 compat)

Test failures look like what is fixed with #40728 (Numpy 1.19 compat)

For the Windows builds - yes.
The 2.2 branch has the following line in its setup.py 'numpy >= 1.16.0, < 2.0',, although I doubt that the CI system honours setup.py. I am unsure from where the CI system gets its environment given the fact that the Linux builds succeeded, while the Windows ones did not.
The MacOS build failures are unrelated to the numpy 1.19 compatibility issue, no?

PRs against release branches cannot use the same CI infrastructure as PRs against master. We need to wait until there is a patch release and only then can evaluate PR for mergeability.
Since 2.3 is out, you might want to also make a PR against r2.3 branch


Idea: Guarantee NodeId is in document order

Hi again!
Since a roxmltree document is read-only, it seems like there are some fairly safe ways that we can take advantage of the order of NodeId, since their relationships should never change over the lifetime of the tree. I've made this PR as an example to start a discussion of what benefits that might be drawn from guaranteeing that NodeId represents the order of the document.
Some benefits:

Implementing the Ord/PartialOrd traits for depth-first order is trivial. If Hash is also implemented for Node, then it can potentially be stored in collections like BTreeMap, which could be helpful for anyone making complex selections in a document or for anyone writing selection languages that work on a roxmltree document (I know xpath implementation is a non-goal of this project, but this makes it possible for roxmltree act as the backing representation for something that does make selections).
We no longer have to store first child in NodeData structs, since it should always be at self.id + 1 if the node has children. This could lead to some memory savings.
There are both benefits and drawbacks for replacing next_sibling with next_subtree (i.e. the NodeId which represents the next node in document order that is not a descendant of the current node). The benefit would be that optimization can be made to the Descendants iterator to make it much faster, since it simply has to iterate through NodeId values (takes roughly 50% of the time on my system, which seems like colossal savings!). The drawback of this might be that it reverses some of the savings that we get from not storing the first child in NodeData because it does about the same amount of work during parsing, and it is less likely to be None than next_sibling (I don't actually know enough about the layout of Option to know if that matters, perhaps the recent change to NonZeroUSize for NodeId makes it take up the size either way?). The next_sibling() function may also take a slight hit in performance. Maybe this sort of optimization is only worth doing for the root node, but I thought I would mention it, since Descendants is typically a fairly expensive operation and I was seeing such large improvements for it.

Thoughts?

Hi! This is an interesting direction.
I didn't go very deep into it yet, but why do we need too change NodeData and use awaiting_subtree? Isn't the current node order the same? Or am I missing something?

takes roughly 50% of the time on my system, which seems like colossal savings

Would you mind adding a dedicated benchmark for traversal iterators? Only for roxmltree, where it traverses large.plist.
Also, how does this change affects parsing performance (the current benchmark)?
As for the Node ordering, I don't really like this idea. It's a tree. It doesn't have an order. I think it will only confuse people. For example, I've originally thought that the order is only for direct children of a node, but it's not.

NodeData Changes

why do we need too change NodeData and use awaiting_subtree? Isn't the current node order the same?

Yes, the current NodeId order is already in document order, but that assumption is not being used in any way right now, other than that the root node is always at NodeId::new(0). The changes in NodeData and in the parser were to support the optimizations that we can get if we commit to NodeIds being in document-order by design. awaiting_subtree is used to resolve the next_subtree field in NodeData, and you cannot get the speedup in descendants without such a field. To summarize, these are two separate things (i.e. I could make a PR for one but not the other):

(document-order assumption => we can avoid storing first child in NodeData)
(document-order assumption + next_subtree => descendants optimizations)

Document Ordering

As for the Node ordering, I don't really like this idea. It's a tree. It doesn't have an order. I think it will only confuse people. For example, I've originally thought that the order is only for direct children of a node, but it's not.

I understand your aversion. However, there is precedent for such a guarantee in XML and its derivatives. For example, as I'm sure you know, XPath follows such an ordering:

There is an ordering, document order, defined on all the nodes in the document corresponding to the order in which the first character of the XML representation of each node occurs in the XML representation of the document after expansion of general entities. Thus, the root node will be the first node. Element nodes occur before their children. Thus, document order orders element nodes in order of the occurrence of their start-tag in the XML (after expansion of entities).

DOM selectors do too:

The querySelectorAll() methods on the Document, DocumentFragment, and Element interfaces must return a NodeList containing all of the matching Element nodes within the subtrees of the context node, in document order. If there are no matching nodes, the method must return an empty NodeList.

CSS evaluation also follows such an ordering as well with counters. The other side of this is that I'm not sure there's any ordering other than document-order that there is much support for in tooling (because of its relative usefulness) - and that's why I feel this would be a fairly uncontroversial way to provide an implementation of Ord/PartialOrd.
It's up to you to weigh the the benefits and drawbacks of this. It's my belief that supporting a wider set of collections with generally expected behavior (and some other things that might follow) is worth it, but I'm biased, because this is all stuff I've added to my fork for MY use case, which is not everyone's use case :)
Benchmarking
Here are the benchmarks on my system for parsing (it might be best for you to try these too, because as we've discovered, we have some differences in benchmark results between our machines - to me, after running the benchmark a ton of times, it seems like there's no significant difference in the parsing times):
before
test large_roxmltree                           ... bench:   4,580,286 ns/iter (+/- 321,564)
test medium_roxmltree                          ... bench:     849,993 ns/iter (+/- 40,253)
test tiny_roxmltree                            ... bench:       4,469 ns/iter (+/- 264)

after
test large_roxmltree                           ... bench:   4,489,390 ns/iter (+/- 173,220)
test medium_roxmltree                          ... bench:     876,207 ns/iter (+/- 66,404)
test tiny_roxmltree                            ... bench:       4,586 ns/iter (+/- 202)

I added some benchmarks to the PR to test the descendant iteration optimizations (on the root node):
before
test iteration_descendants_expensive_matches   ... bench:     883,169 ns/iter (+/- 84,350)
test iteration_descendants_inexpensive_matches ... bench:     381,663 ns/iter (+/- 27,863)

after
test iteration_descendants_expensive_matches   ... bench:     648,825 ns/iter (+/- 59,014)
test iteration_descendants_inexpensive_matches ... bench:      75,057 ns/iter (+/- 4,888)

NodeData Changes
I agree that we should stick to nodes order and make it mandatory. But I still not quite understand how the new version works. And I have to, to be able to support this library later.

How do we know that id+1 is actually a first child and not a sibling?
Can you explain in the simplest terms what next_subtree actually stores?

Document Ordering
Well, as long as we can point to a spec, it simplifies things a bit. So I guess we can add this feature, but it should be documented first. Just add it to the Node struct comment. Something like: this type supports Ord/PartialOrd in a document order as stated in the spec(link to the spec paragraph).
Benchmarking
The speedup is definitely worth pursuing.
For now, everything looks fine. We should settle with the implementation first and then split it into multiple commits. One per each feature. Plus the changelog updates.

I'll start restructuring this into multiple commits and adding documentation this evening.

@RazrFalcon I've split it into different commits. As for a visual explanation of what next_subtree represents, I have made an example tree where the red line points to a node's next_subtree:

In terms of the current model, next_subtree is:

the node with NodeId self.descendants().last().d.id + 1
if self.next_sibling().is_some(), then self.next_sibling(), else if self.parent().next_sibling().is_some(), then self.parent().next_sibling() else if self.parent().parent() ...etc.

It just so happens that we get this value cheaply during parsing. Hopefully this helps explain!

This is way better that I've expected. You definitely put a lot of effort into it. Thanks again!
On the other hand, I feel stupid, but I still do not understand how the next_subtree works. I will play with it tomorrow. For now, could you show an XML that produced the graph on your illustration?

Happy to help!
You may have noticed, my picture is not quite correct, Node 5 and 6 have the wrong numbers (5 should be labeled 6 and 6 should be labeled 5), even though the arrows are correct. Here is XML that represents the image.
<zero>
  <one>
    <two />
    <three>
      <four>
        <five />
      </four>
      <six />
    </three>
  </one>
  <seven />
</zero>

Oh, so it's literary a next subtree :smile: I got it now. Thanks again for explanation.


Spark 3: low performance while reading CSV data

Hello,
I am opening this issue because I have detected a really low performance while reading CSV files.
This low performance is due to the fact that the createSerializer function is an expensive operation: https://github.com/apache/spark/blob/0bcbafb4b868234d695b553f215e21fe66e7ff77/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala#L389
With the current implementation, createSerializer, is called for every row in the CSV file.
There is no need of calling this function for every row. We can create the serialized row object only once per Spark executor. This serialized object will be used by the Spark executor for processing the rows.
Sharing the same serialized object across different CSV rows is safe because this instanced object will be used only by one thread (the current Spark executor) We will have as many instanced objects as Spark executors we have but the object will not be shared across different Spark executors.

PR: https://github.com/spark-redshift-community/spark-redshift/pull/88

Related PR closed :)


Error downloading server from  [...]/vscodium-reh-linux-arm64-<IP_ADDRESS>15.tar.gz

It seems like the current version of vscodium is missing some assets for different platforms: issue-1589
~A workaround seems to be to hardcode the last version in the server download url template:~
This will result in an Client refused: version mismatch-error

This will result in an Client refused: version mismatch-error

Yep, you can't mix versions

Now, it should be fixed since the REH binaries are available.

Yes, it does! Thank you very much 👍


error when handling datagram: failed to handle Allocate-request

hi, I'm running a livekit server in a container on ubuntu. On the client side, I use the client-sdk-lutter example https://github.com/livekit/client-sdk-flutter/tree/main/example.
When I try to connect it gives the following error:
v2@v2.0.8/server.go:184	error when handling datagram: failed to handle Allocate-request.
Then disconnects the client from the server.
livekit server version: 1.2.0.
log.log

this looks like a misconfiguration of ports of some sort. can you share your livekit config?

@CS-dharmesh which SDK are you using ?

Hello, I also face this same issue. Once a user joins into a room after some time video will be blank, and got this error. Error:- livekit.turn v2@v2.0.8/server.go:184 error when handling datagram: failed to handle Refresh-request from <IP_ADDRESS>:38030: no such user exists a539ebef-decf-47a1-bff8-2bfe445da889

Hi @CS-dharmesh
I have the same issue. Did you happen to solve this issue?


Dev

Codecov Report
Base: 66.39% // Head: 66.39% // No change to project coverage :thumbsup:

Coverage data is based on head (d8f6bc4) compared to base (8519db1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   66.39%   66.39%
=======================================
  Files           4        4
  Lines        1744     1744
  Branches      602      602
=======================================
  Hits         1158     1158
  Misses         51       51
  Partials      535      535

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Ship Inventory - Create the necessary ECS systems  for a cargo container to hold inventory

I don't believe there are any ECS systems needed for cargo containers.


Use ros-dev-tools in image

Thank you @dlu for pushing forward https://github.com/ros-infrastructure/rep/pull/355 which allowed me to remove all of this nonsense from my docker files!
They look so much cleaner and are much easier to maintain now.
I :heart: deleting code!

Love to see it!


Addng app as a forcePushBypassers

I am trying to add app as a forcePushBypassers

`spec:
      forProvider:
        allowsDeletions: false
        enforceAdmins: true
        forcePushBypassers:
        - /appName`

Its not adding app as a bypasser.
There is no document with example.
Can you provide example how to add an app ? Is there dependency fields need to set?

this should be possible now in the official provider. You need to supply the node id to identify the app. Also see this topic
https://github.com/integrations/terraform-provider-github/issues/2236

This provider is currently based on 6.3.0


annotate resources that reference an image, with metadata about built images

for example include git url, git sha (+ dirty status), and may be git tag (if present)?

via https://github.com/k14s/kbld/commit/c527aa1b97cb70ce9b911eeaa837cc19594892a8, and https://github.com/k14s/kbld/commit/39f019701b55ade77b5e5a2e106111b10902404f

available in v0.7.0


Update prestafraud.php

Not every order has a carrier, you guys need to consider virtual carts...

Hi,
Thank you for your contribution, can you report this PR on dev branch ?
You may also be intereseted in : http://doc.prestashop.com/display/PS16/How+to+write+a+commit+message
Best regards.

hi, yes I have submitted a PR to the dev branch, thanks!

Thanks, I will close this one.
Kindly regards.


Fix bug in how res.end is handled

Hello,
sometimes res.end is getting called twice (depending on the output data format). This means that your code is also called twice.
setting res.end back to its original value will prevent your shadow end request from being called twice.

Hey,will you publish a new version on npm?

v0.2.3 out!


fix: throw error when HMR plugin exists in config

[x] This is a bugfix
[ ] This is a new feature
[ ] This is a code refactor
[x] This is a test update
[ ] This is a typo fix
[ ] This is a metadata update

For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
This is a pseudo-bugfix, pseudo-update. Resolves webpack-contrib/webpack-serve#149. When a HotModuleReplacementPlugin plugin exists in a config that is used with webpack-hot-client and autoConfigure: true, users can experience unpredictable side effects and errors. This PR throws an error to stop execution and allow users to correct their config, or use the proper hot-client option to allow for manual configuration of plugins and entries.
Breaking Changes
None
Additional Info

Just to highlight why i chose a different direction with on pr #63: i feel autoconfigure should just configure webpack for hot reloading and only throw when there are manual options that actively conflict with the hot reloading settings autoconfigure is trying to set up. Registering HotModuleReplacementPlugin manually doesn't actually break things AFAIK (although you could just let autoconfigure do it for you)
Anyway great to see this land :+1:
If there is anything you want contributions on please let me know, i'd love to help out.

@tjallingt thanks for commenting. I've seen a few different really wonky errors that have seemingly no root cause other than duplicate HMR plugins. Most frequently we see a maximum call stack error. It's a situation that we'd rather the user was given a hard stop on, rather than a warning that something may go wrong - because I've never seen it not cause problems.
In this case autoConfigure is supposed to have that task, and allowing users to turn it off provides two clear-cut directions: 1. do it manually 2. let hot-client do it. That should provide for the fewest number of collision errors moving forward.
Does that sound good?

Oh yea definitely this is a good solution to this problem. This solution also scales better into the future if any other incompatibilities happen it is/should be accepted to just throw an error and tell the user how to fix their configuration.
although (just for clarity) pr #63 does more than just warn, it just doesn't register the hmrplugin if it is already registered (notice the early return) which will also prevent the max call stack error.


seeking assistance regarding construction of complex sql queries using arel

Hi,
I have a complex SQL query that I'm attempting to run in a ruby script.
I have attempted to run the raw SQL within the script using ActiveRecord. It works for really basic queries but not for complex SQL queries which doesn't suit my purpose.
My next approach would be generate ActiveRecord schemas of the tables (and fields) in question and then use ActiveRecord to perform these complex SQL actions (like join, case , group).
Would the gem arel be able to help me with this?
Assistance appreciated.

Please use the mailing list or StackOverflow for questions/help, where a wider community will be able to help you. We reserve the issues tracker for issues only.


this line is not working "android: true"

Error on line 17, column 12 of pubspec.yaml: A dependency specification must be a string or a mapping.

Hi, please see #38

@ffeu thanks for linking that other issue. I'm guessing since there was no reply, that is what the issue was.


Unknown custom element:

Please fix
vendor.js?id=8a0b277a131df1bccb14:91212 [Vue warn]: Unknown custom element:  - did you register the component correctly? For recursive components, make sure to provide the "name" option.
found in
--->

fixed version v1.2.1


Sampler returns SamplerResult with dict

Describe the bug
Sampler returns SamplerResult with a list of dict. However, it should be SamplerResult with a list of QuasiDistribution.
See https://github.com/Qiskit/qiskit-terra/blob/df54ae26d6125bee671ad27f4d412a92912aad1a/qiskit/primitives/sampler_result.py#L42 for detail.
====
This may cause bugs in the future. In particular, applications will be written assuming the type.

@ikkoham Any ideas on how to fix this without making it a breaking change? Users would have to now use binary_probabilities() method to get the same result.

It would be difficult not to fix this without API breaking.
I think we can convert dict to QuasiDistribution at this line:
https://github.com/Qiskit/qiskit-ibm-runtime/blob/main/qiskit_ibm_runtime/sampler.py#L211
And user should use binary_probabilities() method. If you don't like this interface, it would be nice to define QuasiDistribution.__str__ in Terra. But, it might be costly...
Or we can extend SamplerResult to have QuasiDistribution | dict. But I don't think it's a good idea, because users will have to do some conditional branching.

Thanks Ikko! I also don't see a way to make it a non-breaking change... I think the best option is to make SamplerResult return QuasiDistribution | dict because I have spoken to one expert user in the past who preferred the output returned by binary_probabilities(), which is a dict and that is what the current API returns.. also if anyone wants to get a QuasiDistribution from it, it is easy to do... what do you think?

At least, it is undesirable to have a situation where a conditional branch always occurs when someone tries to use SamplerResult. This is, for example, the situation where all the code in qiskit.algorithms has a conditional branch.
I would rather change the SamplerResult.quasi_dists's type to dict than do have Union. This is also API breaking of SamplerResult. We need to discuss this problem with @levbishop or @ajavadia.

I see the current dict format of quasi_dists is more intuitive to users. QuasiDistribution is not so intuitive because it does not have information of the number of qubits. So, users need to set appropriate number of qubits to call binary_probabilities.
One possible extension of QuasiDistribution is as follows. Then, the output message will be as informative as the current dict.

QuasiDistribution accepts number of qubits as a constructor argument, i.e., dist = QuasiDistribution(..., num_qubits=3)
Implements QuasiDistribution.{__str__, __repr__} with binary_probabilities.

The problem actually lies in the refactor of the QuasiDistribution class to not store its data as bit-strings. The class should be modified to have the number of qubits stored when passed a dict of bit-strings.  M3 always returns bit-strings, since I need them for expvals, so such a change would work here.

Thanks, @nonhermitian. I made a PR to update ProbDistribution and QuasiDistribution to store bit-string data. Could you take a look at it? https://github.com/Qiskit/qiskit-terra/pull/8464


Remove "toTop" button from all pages

I want to contribute to this issue

I'm ready to contribute to this issue. It will be look good after solving this issue.

I want to contribute to this issue

Any updates? This is a simple task i believe

I want to contribute to this issue

Any updates? This is a simple task i believe

I want to contribute to this issue

Any updates? This is a simple task I believe

@smaranjitghose sir, can I work on this?

I want to contribute to this issue

Any updates? This is a simple task I believe

@smaranjitghose sir, can I work on this?

@smaranjitghose  sir , can I work on this issue ?

@smaranjitghose  sir , can I work on this issue ?

sir i am SWOC participant can i work on this issue ?

sir i am SWOC participant can i work on this issue ?

@smaranjitghose sir can I commit code with my existing PR which is (added resume section #406)
or start working after that get merged?

@smaranjitghose sir can I commit code with my existing PR which is (added resume section #406)
or start working after that get merged?

@smaranjitghose sir can I commit code with my existing PR which is (added resume section #406)
or start working after that get merged?

I don't think that it makes any problem if I link this issue as well with my existing PR.

Sure

@smaranjitghose sir can I commit code with my existing PR which is (added resume section #406)
or start working after that get merged?

I don't think that it makes any problem if I link this issue as well with my existing PR.

Sure


Add missing space in german translation

Added a missing whitespace in german translation file

Please send PR against develop branch as development happens there.


sql2pgroll: Support set and drop column defaults

Support translating the following alter table statements into pgroll operations:
ALTER TABLE foo COLUMN bar SET DEFAULT 'foo'
ALTER TABLE foo COLUMN bar SET DEFAULT 123
ALTER TABLE foo COLUMN bar SET DEFAULT 123.456
ALTER TABLE foo COLUMN bar SET DEFAULT true
ALTER TABLE foo COLUMN bar SET DEFAULT B'0101'
ALTER TABLE foo COLUMN bar SET DEFAULT null
ALTER TABLE foo COLUMN bar DROP DEFAULT

Cool, that's exactly what I did 😄
I'll throw in a test case where it's a function value, for example now() and fall back to raw SQL in that case.

@andrew-farries Ok, I think I've handled all the cases now.


change cross docking workflow to exclude all "similar" molecule pairs…

…, not just the identical ones
Description
Pretty straightforward. Kind of annoying the number of places I changed the default but not too bad.
TODO

[x] add selector
[x] add selector to cross docking workflows
[x] add tests

Status

[x] Ready to go

Developers certificate of origin

[x] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

Codecov Report

Merging #688 (08ce024) into main (59a11c4) will increase coverage by 3.00%.
The diff coverage is 85.00%.

Additional details and impacted files


Twilio improvements and fixes

Add support for Twilio Verify based on the SID use messing or verify APIs

@elitan, @plmercereau if you think is okay while I'm on the twilio topic I can also introduce fixes for https://github.com/nhost/hasura-auth/issues/99, https://github.com/nhost/hasura-auth/issues/79 and maybe https://github.com/nhost/hasura-auth/issues/135

Hello Aden, yes, definitely!

@plmercereau can you give some ideas and help about #79. Do you know what should be the expected behaviour - is simply not deleting the user enough?

Any progress on the review here?


feat: Allow [identifier][], understood as [identifier][identifier]

OK, I feel like it's a nice improvement, and a good base for further improvements. Lets merge.


[Flink-13752] Only references necessary variables when bookkeeping result partitions on TM

What is the purpose of the change
This pull request fixes the problem that the TaskDeploymentDescriptor is referenced by an anonymous function that is going to be executed when task terminated. This causeTaskDeploymentDescriptor cannot be recycled by GC. Since TaskDeploymentDescriptor  has a reference to its serialized value and for some tasks this array might contain dozens of megabytes, unable to recycle TaskDeploymentDescriptor may have large impact on GC and further on the performance.
Since the anonymous function indeed only want to references the JobId instead of the whole TaskDeploymentDescriptor, it can thus only reference the JobId instead.
Brief change log
a95596e548b62cfc71177f8c2da0be540566f976 acquires the JobId outside the anonymous function and only reference to the JobId in the anonymous function.
Verifying this change
I think there might be no need to add a UT for this fix since it is not changing the interface of some components. If we want to add a UT, it might can only acquire the anonymous function and check if it has a field referencing TaskDeploymentDescriptor. However, the behavior to test is mainly implement related logic.
Currently it has been verified by manual test with an external job which triggers this problem.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager Checkpointing, Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

Very thanks @tillrohrmann for the review!


pgvector with postgresql / alloyDB and AlloyDB OMNI

With significant performance boost offered by alloyDB postgres Pgvector solution and  Zilliz showing open source pgvector worst performance I would like to see if team can publish and measure the benchmark with alloyDB and show competitive results please.
thanks

Feel free to contribute the AlloyDB client for performance test and share the performance with us~

Feel free to contribute the AlloyDB client for test and share the performance with us~

Sorry if the ask is misunderstood. I am not asking about contribution . Since Zilliz publish the benchmark using VectorDB and pgvector is the last item in the list from performance standpoint . The question is you guys may be missing the AlloyDB pgvector part of the story (which Google published as 4x faster on OLTP and 100x faster on analytics) . Does Zilliz having any future aspirations to add alloydb and alloydb omni in zilliz cloud benchmarking results ???

@pauldintel
Currently, we lack sufficient resources to undertake all requested features and enhancements. Therefore, we warmly invite other community members to contribute code or share their results. We truly appreciate your understanding and patience.

@alwayslove2013
is there a pgvector support? if there is , then anyone could simply run the test by themselves and we can add the result to leaderboard

@alwayslove2013 Yes, vdbbench already supports pgvector and pgvectorrs, and we've posted test results of pgvector as well.

In Milestone 1.0.0, we will support testing AlloyDB.

And perhaps JVector from Cassadra / Datastax too ?

And perhaps JVector from Cassandra / Datastax too ?

We are looking for some volunteers.


Change newly-added HTML elements to the html-elements group

I did not touch the drafts, since I thought they were generated (also several will have PRs in progress that I didn't want to conflict with).

Related to https://github.com/web-platform-dx/web-features/pull/1464


Issue with new version of Three JS

Hi Francis, I found a problem with the lastest release. The error is with this line.

In the lastest version of Three JS, CylinderGeometry (also SphereGeometry) has no attributes of faces.
After I replace import * as THREE from 'three'; with import * as THREE from 'https://threejsfundamentals.org/threejs/resources/threejs/r112/build/three.module.js';, it works fine
Yuanwen

Hi Yuanwen,
Thanks for pointing this out!
I just fixed it, you can install the latest release - if you find sth else please let me know.
Best,
Francis


Fix 2689

~First review/merge: https://github.com/biocore/qiita/pull/2743~

Codecov Report

Merging #2755 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #2755      +/-   ##
==========================================
+ Coverage   94.31%   94.31%   +<.01%
==========================================
  Files         166      166
  Lines       19956    19964       +8
==========================================
+ Hits        18821    18829       +8
  Misses       1135     1135

Impacted Files
Coverage Δ

qiita_db/meta_util.py
91.4% <100%> (+0.03%)
:arrow_up:

qiita_db/test/test_meta_util.py
98.91% <100%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e63bfd...bb7a0ad. Read the comment docs.


allow overwrite of existing file if origin matches

Ensures that file overwrites happen only when the overwriting package has the same origin as the one that originally installed the file.
Partially addresses https://github.com/chainguard-dev/melange/issues/401

They are. This opened a whole can of worms. They needed to be dealt with, just not today. But I guess yes today 😁 . Almost got them, been a long haul.


feat: Rename pages

Hi, I have made the following changes in this PR -

Rename the UI text for the pages in the side-bar

Closes #48
Closes #47
Closes #46

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (d32df02) 96.45% compared to head (f877bd5) 96.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   96.45%   96.45%
=======================================
  Files           3        3
  Lines         141      141
=======================================
  Hits          136      136
  Misses          5        5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Small fixes for AMIP

[ ] I have read and checked the items on the review checklist.

replaced with #591


issue installing on macos

when installing the newest file from releases, the download is not a .dmg file or a .app file, its just a file without an extension and does not open. (when opened, an error "Attempting to open from unverified developer" error is shown, and does not open)
iMac 24-inch, M1, 2021
MacOS 14.6

Oh, wow thanks for the very fast response.
Alright, thank you so much!


Meshlet screenspace-derived tangents

Save 16 bytes per vertex by calculating tangents in the shader at runtime, rather than storing them in the vertex data.

Based on https://jcgt.org/published/0009/03/04, https://www.jeremyong.com/graphics/2023/12/16/surface-gradient-bump-mapping.

Fixed visbuffer resolve to use the updated algorithm that flips ddy correctly
Added some more docs about meshlet material limitations, and some TODOs about transforming UV coordinates for the future.

For testing add a normal map to the bunnies with StandardMaterial like below, and then test that on both main and this PR (make sure to download the correct bunny for each). Results should be mostly identical.
normal_map_texture: Some(asset_server.load_with_settings(
    "textures/BlueNoise-Normal.png",
    |settings: &mut ImageLoaderSettings| settings.is_srgb = false,
)),

No need to address my comments. Just wanted to throw out some ideas, possibility for the future.

Did some tests visualizing the tangents directly.
Before:

After:

There's a bit of inaccuracy around the head with all the concave curves, but not too bad.

So tangent.w definitely has the wrong sign in the current code. I just don't know why yet.

Decided just to negate the sign of tangent.w and move on. I read a bunch of papers but idk why it's backwards.

Yeah, I'm not personally too worried about the inaccuracy. It's "good enough" for the intended use case. Nanite does have an option for explicit tangents, it wouldn't be too hard to add it back later. Not a priority right now though.

Shadows don't seem to match current bevy main (0ebd7fcdf4545c05dd6c1f0c4b6cf057d1f5f1a7).
Current main

This PR

Bevy main is using an outdated bunny model, I had forgot to regenerate the meshlet mesh before merging the last meshlet PR. The model on main is based on one of the earlier commits of the last meshlet PR, and not the last commit when it was ready to merge. I'm fairly certain that if you regenerate the meshlet mesh on main, you'd see the same issue.
As for why it looks broken, the LOD system thinks that the error from a lower LOD is not visible to the shadow map's camera, but when the shadow map is used by the main view it then has too much error. Using higher resolution shadow maps would fix this, but is more expensive. I'll probably look into adding a LOD bias for shadow views in a future PR.

Bunnies on main (regenerated to ensure it's using the exact code from main)

Bunnies in this PR (also freshly regenerated)


Rewrap Comment / Text doesn't handle comments properly

VSCode doesn't seem to understand that # is a comment marker so the Rewrap Comment / Text command doesn't treat comments correctly.

Apparently that command is actually provided by another extensions that I forgot about. It seems that this extension needs to be taught about the language directly, which is unfortunate.


proposal: schemaFromCloudFormationTemplate Method

Hi team,
It would be great to be able to generate a schema based off of CloudFormation templates, rather than having to deploy the API, export a swagger spec, and then generate based off of that.
What do you think of a new method schemaFromCloudFormationTemplate()?. I am thinking it would work exactly like schemaFromOpenApiSpec(), just with a different source.
If this aligns with the project’s direction, I’d be happy to make a contribution.

Hi @joshkraft, thanks for your proposal and your contribution!
Let me discuss it with the team and come back to you

Hi @joshkraft,
We discussed your proposal internally and would like to hear more about your use case, specifically about the need to generate a schema from a CloudFormation template
Rather than parsing the template and generate a schema, which would imply several assumptions (e.g. no more than 1 API per template), we suggest to implement a functionality that generates the schema from another CDK construct e.g. Rest API
Also, for users that want/need to start from a CloudFormation template the suggested way would be to import it in CDK
What do you think?

Hi Andrea - thanks for the response. I think working with the RestApi construct would work for our use case. Would you be open to a contribution that adds something like schemaFromRestApi to this project?