Microschemas (and profiles)

Idea: allow people to start registering simple little schemas for their data (esp tabular data). This would be in the form of a JSON Table Schema. For example, we have Budget Data Package for public finances, we could have a simple schema for crime reports or restaurant inspections.
Notes:

Basically these would be profiles - see #87 . So maybe we want to standardized name for this (either profile or schema but not both). On the other hand maybe useful to distinguish e.g. Tabular Data Package as a profile from a microschema which actually specifies what fields should be present in a given dataset.
We could / should have one page for each profile / microschema on dataprotocols.org at dataprotocols.org/microschemas/
Suggest a strong focus on Tabular data to start with - i.e. schemas (required columns) for tabular data
Proposals could be classified at:

Draft: just an idea
Alpha: trialling publishing with at least 2 users
Beta: in use with at least 2 users and trialling with more
Accepted: multiple (5+) users (publishers)

@paulfitz @jpmckinney @davidmiller @pwalsh any thoughts?

So, from this perspective, BDP is a Tabular Data Profile? Like wise Open Spending Data Package?
I think this is a really good idea, both from an adoption perspective and a tooling perspective.
I don't like the use of "microschemas" - "profiles" (or something else) is better.

W3C uses profile as described in DCAT and ORG. ADMS, for example, is a profile of DCAT. In all cases, profiles are like different collections of Lego blocks with different constraints.
As I understand, Budget Data Package fits that meaning with respect to Data Package (and with respect to Tabular Data Package). So, "profile" sounds good, but we need to be clear on what things are profiles of.

@pwalsh yes BDP is a profile of Data Package and a profile, you could argue, of Tabular Data Package. Strictly we might just say profile for anything that builds on Data Package and maybe use the term "specialise" for something that "inherits" or "specialises" an existing profile.
@jpmckinney really good suggestion and guidance. Thank-you.

Btw could I just mention a project I've been working on in Australia: http://opencouncildata.org
You could consider these "microschemas", although they're not (currently) in machine-readable form. We've been doing this in a fairly rough, learn-as-you-go way, but have a few councils publishing data in some variation of the standard: http://data.gov.au/dataset?q=garbage&sort=extras_harvest_portal+asc%2C+score+desc
I note that we've been focusing on spatial data, which only overlaps with tabular data for points: trees, customer service centres etc. Our approach has been strictly defined column names, with definition of those column names given in the standard document. That's fairly inflexible, of course.
Maybe a way to combine these two worlds would be to have a schema (profile?), say "trees", based on tabular data package, and with linked open data style links for columns. Ideally it would be possible for the attached .json file to communicate that the "common" column in this file corresponds to the "common_name" column in the trees profile, with a URI pointing to a some semantic web definition for "common name".
Sorry if that doesn't make any sense.

@stevage that makes sense. Re column names inflexibility this has a connection with the discussion about the OpenSpending Data Package. Rather than enforcing specific column names on publishers of spending data we allow for a "mapping" from their columns to the "ideal" columns we expect - https://discuss.okfn.org/t/openspending-data-package-structure/239
I think this is along the lines of what you are saying with the twist that the mapping is from one tabular schema to another one (the ideal one). I quite like this idea and hadn't thought of it before ...

I realise that I'm a bit unclear on the inheritance model that we're aiming for here. Has one clearly been decided on? A few (not necessarily mutually exclusive) that it could be:

Informal, pattern-based, governed by documentation and convention: a data package is an example of a tabular data package if it follows the rules, includes the recommended fields etc.
pure inheritance by reference to published schema: a data package carries a URL reference to the schema it conforms to, which may in turn carry a reference to another schema and so on
multiple inheritance: as previous, but the package contains references to all the schemas that it conforms to (its parent, its grandparent, etc)
independent schema hierarchies for form and content: is there a single hierarchy: data package -> Tabular Data Package -> CSV Data Package -> Budgetary CSV -> UK Budgetary CSV etc, or is it more like Data Package -> Tabular Data Package -> CSV Data Package, and a separate hierarchy (or something) for content, so a given file might contain schema references to both the form (it's a CSV) and content (it will have a "revenues" field which means X).

I would tentatively suggest that a multiple inheritance scheme (or rather, conformance to multiple different schmas) would be the way to go. I can easily imagine a spatial hierarchy joined with a CSV data package to give a geo CSV.

Thoughts / suggestions:

Let's make this as simple as possible to start with
For schemas: you have to explicitly refer to other schemas you build on as per e.g. Tabular Data Package spec
For Data Packages themselves and the use of the profiles field I think atm we just go for explicitness. You write out all the profiles you expect to conform to even if some imply the other e.g. you'd have both "tabular" and "budget" listed even if the budget data package is a type of tabular data package.

Cool. Simple and explicit are pretty good things.
(When I wrote the above, I didn't quite understand that schemas apply to files, whereas data package profiles apply to whole data packages, so they're in different hierarchies. Paul explained that to me... It's probably not super clear to other newcomers either.)

The inheritance model for Data Packages via profiles is clear enough for me. One point on that:
Not sure if it is a real world issue, but by declaring inheritance in an object, we have no resolution order for the inheritance chain.
As for schemas: I think we need some actual examples, at least so I can fully visualize it. Also, at present, schema is an object on a resource, but I guess we need to change that to an object or a uri?

@pwalsh I was using schema here in the sense of the json schema for a given Data Package profile.
In general, is it time to turn this into a new spec on data protocols - like data package identifier spec i think we want this up there but separate from data package core spec.

@pwalsh could you update on the status of the profiles / schemas registry. Is this now live?

I'm closing this in favour of #87 as otherwise we are getting confused. I think we agree that idea of "schemas" can simply be part of profiles.


[release/1.3] Fix containerd build, use libbtrfs-dev when available.

Cherrypick #1319 to release/1.3
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Apply LGTM based on LGTMs above.


Rename _records back to #records once embroider supports private fields.

Ref: https://github.com/embroider-build/embroider/issues/979

done!


Interop: Objective C & Swift

Dart currently supports interop with C code via dart:ffi. We should investigate if we can provide similar interop with Objective C and Swift code.
This would be a supplement to Flutter's plugins, and would allow for calling into Objective C / Swift directly from Dart code, also from pure-Dart apps (such as CLI apps).

[x] Objective C interop, binary and source code: Has experimental support, see the example
[x] Swift interop, with source code access: Has experimental support, see the example
[ ] Swift interop, binary/without source code access:
TODO

If you have any feedback and suggestions about this project, please comment below.

//cc @liamappelbe

I would be interested in trying out the Swift interop, binary/without source code access since our use case is consuming a native .xcframework written in Swift, in a Flutter plugin. We do have the source code of the .xcframework so I am not sure if it possible to use the Swift interop, with source code access method and then swap out the code with the .xcframework.
For now we are using platform channels and we are thinking of skipping Pigeon completely if FFIgen will be soon the way to go.

//cc @liamappelbe

I would be interested in this functionality, for Swift specifically.

I've looked into this a bit and I don't think it's possible to interop directly with a swift binary without some sort of intermediary layer. The only way I've seen for interop with swift is to:

Annotate your API with @objc (if you don't own the library, write a wrapper library and mark that with the annotation).
Use the swift compiler to generate an ObjC wrapper header (a 1 liner swiftc command)
ObjC obeys the C calling convention, so we can do interop. In Dart's case, that means using ffigen to parse the ObjC header then using FFI to load the library.

If you don't have access to the source code, just a compiled swift library, then you can still do step 1 by writing a wrapper swift library that you annotate with @objc. You'll end up with 2 libraries to link into your app: the original library and the wrapper library.
There's also a C interop annotation, @_cdecl, but it's undocumented and unofficial, and wouldn't actually simplify things.
We're also considering ways of automating steps 1 and 2, but that won't fundamentally change this workflow.
If anyone knows a cleaner way of interoping with swift, I'd love to hear about it, but afaik this is the only option atm.


Minimize, Maximize and Close Buttons Glitched Out

Latest version on Windows 11 looks like this, tried disabling scaling, didn't work. (Official app looks normal)

the primary issue for this bug is https://github.com/notion-enhancer/notion-enhancer/issues/291


Fixed NPM Package

This will fix the NPM package. Relates to #1
This is fixing the webpack export config according to the documentation. (see https://webpack.js.org/configuration/externals/)
To build I ran:

yarn run build
yarn run lint
yarn test

Build seems to fail because of webpack v2.3.0 being installed through npm on travis. (see https://github.com/webpack/webpack/issues/4549)
Maybe we should use yarn in .travis.yml to respect the version locks?

Can you confirm if the fix is just this part:
 -  externals: {
 -    'matter-js': 'Matter'
 -  },
 +  externals: [
 +    'matter-js'
 +  ],

Correct? Are these two not already equivalent though?

@liabru Yes, that is the fix, essentially. As far as is understood the docs ['matter-js'] is (obviously) the same as {'matter-js': 'matter-js'}. This is what we need to exclude modules which are imported/required via CommonJS, etc.
Whereas {'matter-js': 'Matter'} would be used for packages (like jQuery) which exports themself to the window in browser environments.
The issue with that was, that the matter-attractor plugin would search for a Matter package to import. This would fail, of course. If you have a look at the build output, you will see, that the requires changed from Matter to matter-js.
I hope this makes any sense to you 😄 , I tried to express it the best I could,
best regards

I tried this change and it doesn't work in the browser, where as the original version does. I suspect that it doesn't try to use require before it looks for the global like I hoped it would. I'm not sure yet how to resolve this.

Ok, thats odd. 🤔
In my case I installed it as an NPM package while using it with webpack (babel-loader).
// Contents of .babelrc
{
  "presets": [
    ["es2015", {
        "modules": false
    }]
  ],
  "plugins": [
    "transform-es2015-destructuring",
    "transform-object-rest-spread"
  ]
}

If I just try to import or require the current NPM package, it fails saying that I need to install the dependency "Matter".

Actually I think this is what's needed:
  externals: {
    'matter-js': {
      commonjs: 'matter-js',
      amd: 'matter-js',
      root: 'Matter'
    }
  },

I'll try it out!

@liabru awesome, thank you!

Should be fixed as of 0.1.6 please try it out!


OracleDB Dates

Hi there,
I love the library quite a bit, but I'm not sure if it is throwing the following error or the database is.
{ [Error: {
  "LOGDATE": "should be date"
}]
  data: { LOGDATE: 'should be date' },
  statusCode: 400,
  message: '{\n  "LOGDATE": "should be date"\n}' }

In the code block I define the LOGDATE field as a 'date' and looking at the OracleDB driver it says "Date and timestamp columns are mapped to JavaScript dates" so I'm passing a pure JS date to the insert query.
Am I doing something wrong or am I misunderstanding something?

Hi, the underlying library knex has just recently got oracledb support, so there might be more bugs in comparison to postrgres or mysql. Also I have no experience how oracledb dialect handles different datatypes. It is really up to db driver (e.g. node-oracledb) how it requires that data should be passed, it might not support sending dates as javascript date objects.
You could try to pass date as ISO8601 string e.g. '2016-11-22'....  Do you have some example how to reproduce the problem?

Yea, I know it was new, but I wasn't able to tell the source of the error so I figured I'd start at the top layer in the abstraction. Currently the insert rejects ISO strings, JS dates, custom made strings like '22-11-2016' (that's our date style in the DB), as well as other date formats in string form.
Looking at the driver documentation it states that it should take a JS date object and map it to the appropriate DB format but as I said something along the line is saying that's not allowed.
In Objection is there type checking on the models or is that handled by Knex underneath? If it is then I shall move along the abstraction layers to them and ask them if they know the issue, otherwise I might jump straight to Oracle.
Thanks,
Steve

You can check the created query by setting DEBUG=knex:* environment parameter. Then you can test e.g. on sqlplus console if that query should work and which kind of query actually should work with date type. Then it should be easy to figure out if the problem is in driver, knex or objection.

Please reopen if this appears to be objection issue after all.

It was an error in the OracleDB driver, though I don't believe they have fixed it yet.


Feature/add bookmarks menu

This is largely inspired by perusing @CrossR's dotfiles a while ago and by the fact that FZF broke for me recently 😆, it uses the oni.bookmarks to generate a menu with submenus the idea being, the first menu represents the contents of oni.bookmarks e.g.
// folders are relative to the home directory or a users configured `oni.bookmarks.baseDirectory`

"oni.bookmarks": [".dotfiles", "Desktop/stuff"]

The first menu will have two items, hitting enter on any will go into the directory and render its content of files and folders, this can be repeated over and over for folders, if a user selects a file it will open it.
There is also a command (oni.bookmarks.setFolderOrOpenFile)  that can be bound to set a folder to the active workspace so if a user e.g. was currently on .dotfiles/vim and hit the bound key it would make the folder the active workspace.

Excited for this!
This and a terminal selector are the things I use most that I've added myself, so glad to see it being added properly! If I can swap my terminal selector to be entirely in Oni (and not half in Oni half in my Vim config), I'll try adding that too.

@CrossR would be good to get your feedback on the approach I took, I basically wanted the versatility to set add a bookmark dir and traverse it a little so that you could say set the Desktop as a book mark then move downwards set a subfolder as a workspace and the move downwards still and open a specific file in the subfolder to open which means it doesnt just do a search downwards through all subfolder but instead shows the top level then you can choose to go deeper and search there.

One thing I would quite like (though I'm biased since its what I currently use), is some form of wildcard selection of folders.
That way I can have a bookmark of ~/git/* say, and then every project in my git folder is a bookmark, rather than me needing to remember it.
Obviously with the 2 menu way, I can just set the Git folder as the bookmark and then select my project from the second menu, but having it work straight from the first menu would be nice.
The other thing would be the second menu would be more useful (to me at least) if it listed all files rather than just the top level directory. My general workflow is swap project > quickopen for the file/files I need. Maybe have an option to auto open the QuickOpen menu and nothing (for people who want to make a new file etc) instead of the second bookmark menu? That then supports three workflows:

Opening a bookmark and going deeper (current).
Opening a bookmark and grabbing a file (open QuickOpen menu).
Opening a bookmark only (open nothing for the second menu).

That said, there is also times I have wanted something like the second menu to focus the quick open in to a specific folder if I know I don't need anything from the other folders. Perhaps we could add a second command to open up the second menu directly for the current folder, such that if a user did want to restrict the current workspace, its easy to do so?

@CrossR actually looking through the code base I might be duplicating functionality I just saw https://github.com/onivim/oni/blob/bd94771cce70efe93642d33067045767eb8b3cde/extensions/oni-plugin-quickopen/src/QuickOpen.ts#L38 seems its already partially implemented not sure how to use/access it though? @TalAmuyal would you know what that section of the code base does and if we can use it to surface a bookmarks menu?

Had a look and seems I've definitely done a bit of duplication 🤣 I'll switch to using our implementation in quickopen but seems it needs some beefing up anyway so not a complete loss

@CrossR I've decided to scope this down quite a lot since I spent quite a lot of time duplicating functionality we already had (my fault for not checking) atm I've basically hooked back up the menu we had which offers the user choices to open a folder, open a configuration file, and otherwise lists the bookmarks.
if the bookmark is a file it opens it if it is a dir it sets it to the active workspace.
I tried getting the quickOpen to auto open if the user selects a bookmarked dir but for reasons I cant decipher that doesnt work at all, there must be some block Im not seeing but tbh I think re. time and attention spread across too many PRs Id rather just scope this down to reactivating/activating the menu we have and slightly tidying up its functionality.
Re. globs I found a library that can read globs which might be useful for more than just this usecase its called node-glob, in case anyone finds this and wants to look into using it but think I'm gonna need to time box my efforts on it for now

Makes sense! I'll give it a try and we can add globbing later perhaps. Since I've asked for it, I'll have a look, and also compare it to other editors to see how they achieve it.
Just about to checkout the ligatures stuff, then will re-review this.


Typo in Help

g:indentLine_showFirstIndentLevel               *g:indentLine_showFirstIndentLevel*
                Specif y whether the first indent level should be shown.
                This is useful if you use indentLine in comination with
                |listchars| in order to show tabs.
                Default value is 0.

should be  in combination with.

thanks


Why can't I find the Raw payload section for a POST request while sending notification to a single device using Registration token?

Your description here
Expected outcome
Successfully sent notification
Actual outcome
401 The request was missing an Authentication Key (FCM Token) since I can't add payload.
Versions
App: 10.0.11
Platform: 5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36

It's all there:


[Feature Request]: Books Ratings and Riviews

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Implementing a book reviews and ratings system involves several steps, including creating models for storing reviews, setting up API endpoints for submitting and fetching reviews, and building a front-end interface to display and submit reviews.
Use Case
this feature helps other customers make informed decisions by reading through the experiences of others.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Trisha-tech pls assign it to me

Is there an existing issue for this?

[x]  I have searched the existing issues

Feature Description
Implementing a book reviews and ratings system involves several steps, including creating models for storing reviews, setting up API endpoints for submitting and fetching reviews, and building a front-end interface to display and submit reviews.
Use Case
this feature helps other customers make informed decisions by reading through the experiences of others.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[x]  I have read the Contributing Guidelines
[x]  I'm a GSSOC'24 contributor
[x]  I have starred the repository

Hello @ashis2004 , Go for it
All the Best

Hi, i would like to work on this issue.


This page deserves links pointing to the pages for GetExceptionCode, GetExceptionInformation, EXCEPTION_POINTERS, etc...

Cross-linking all information in documentation like this is generally a good idea.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca5dfade-e224-32b4-919a-1e4f0c7b87ac
Version Independent ID: 00702e1e-21c9-3520-ebec-53ff75dbb8f5
Content: try-except Statement
Content Source: docs/cpp/try-except-statement.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @corob-msft
Microsoft Alias: corob

Fixed.


Point out missing ideviceinstaller/adb when running flutter run/devices

More directly point out missing ideviceinstaller/adb when users flutter run/devices
Current output:
$ flutter run
No connected devices.

To run on a simulator, launch it first: open -a Simulator.app

If you expected your device to be detected, please run "flutter doctor" to diagnose
potential issues, or visit https://flutter.io/setup/ for troubleshooting tips.

Is this covered by
[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    ✗ Verify that all connected devices have been paired with this computer in Xcode.
      If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
      To update with Brew, run:
        brew update
        brew uninstall --ignore-dependencies libimobiledevice
        brew uninstall --ignore-dependencies usbmuxd
        brew install --HEAD usbmuxd
        brew unlink usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

Currently this shows always when no iOS device is available (#24030)

Hi @xster  is this issue still meant to be open?

I believe this is no longer an issue since @christopherfujino folded these tool into Flutter itself.


Question about how to get the OW-DETR's results under the evaluation of this paper

Wonderful job! I notice you evaluate the performance of OW-DETR under the evaluation of this paper. I want to know how can I get the results.

Thank you for your interest in our model!
You can rewrite the evaluate function so that it can save the json file in the same format as our output. Then you need to use these files to evaluate the performance of OW-DETR.

Thanks for your quick reply!
When I implemented the results of OW-DETR, I noticed that the mixed_OOD file has 704 images instead of 897 in the paper,  but mix_ID file does have 897 images.
Does this mean that some of these images do not have OOD objects?


Fix incorrect day of week

A bug in MicroPython for Pico was fixed, which means this clock doesn't have to offset the day of the week anymore.
See discussion in #17

thanks for this!


Uploading a binary file (XLSX) to Sharepoint

Hi, I think uploading a binary file should be possible using PUT. Can you write an example code for that, please? What is payload in that case? I am using Python.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 350cd850-d19a-ef5c-2761-e342fc3c506c
Version Independent ID: 5bf3ef39-f20a-6c7f-77f6-3bc7e9d246f4
Content: Upload small files - OneDrive API - OneDrive dev center
Content Source: docs/rest-api/api/driveitem_put_content.md
Service: one-drive
GitHub Login: @JeremyKelley
Microsoft Alias: JeremyKe

This question is better suited for StackOverflow


Mobile - filter option for invalid markets is cut off

On safari on iOS (iphone 8):

The categories and filters menu
Scroll to bottom, the 'show' option is cut off and can't be pressed

This original issue is fixed but if you tap on any other filter the "apply" button appears and covers off the "show" option of the invalid market filter. You can't select it.

Need someone with an iphone to test this

Looks fixed from the screenshots Bruno shared. closing


MAINT: bump to OS 1.0 and data prepper 1.0.0-rc1

Signed-off-by: qchea<EMAIL_ADDRESS>Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

{"error":"no handler found for uri [/_plugins/_ism/policies/raw-span-policy] and method [PUT]"} 🤔

Also suggest merging these rename fixes to the v1.0.x branch first, then main later. The 1.0.0 release will be off of the v1.0.x branch.


[2473] Cleanup (part 2)

Context
In order to be able to deliver value it must be easy to understand and work with the code.
https://github.com/DFE-Digital/manage-courses-backend/pull/942
Changes proposed in this pull request
This refactors any unclear or non-idiomatic lines.
Guidance to review
Remove unused functionality from authentication service and clarify the use of MD5 as obfuscation. Moves some of SendWelcomeEmailService's functionality to RecordFirstLoginService to avoid having a service do too many things. Also includes some additional restructuring.
Checklist

[X] Make sure all information from the Trello card is in here
[X] Attach to Trello card
[X] Rebased master
[X] Cleaned commit history
[X] Tested by running locally

 General readability improvements

Rebased + fixed conflict, merging when passed


⚠ GitHub has degraded performance

In 862a8f3, GitHub (https://www.githubstatus.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 157 ms

Resolved: GitHub performance has improved in df66dea.


C Solution to Neetcode: 148 SortList

File(s) Modified: c/148-Sort-List.c
Language(s) Used: c
Submission URL: _https://leetcode.com/problems/sort-list/submissions/880346565/_

Hi!
Would you be kind to provide your Leetcode submission URL for your solution?
And could you please also rename your file to follow the repo naming conventions? For filenames, it's <language>/<problem-number>-name-of-problem.<language-extension> (e.g. java/0001-two-sum.java)

Thanks for the review, it's updated now.

Thanks! I changed the filename for you, but please keep in mind for future PR's. Thanks for yuor contribution!

Sorry I missed the leading 0 (at the time I created the PR it was only 3 digits...)

No worries at all! Yes, you are correct, I think the filenaming style changed sometimes after that. Also, apologies that your PR wasn't reviewed earlier!


[FLOC-3851]Create containers script

Removed container creation from cluster setup script and created a new one so it can be done independently, reusing an existent cluster.
The script will wait until all the containers have been created, as that will make automation easier.

Please address comments and re-submit. Thanks.

The eliot logging is not working
I have spent the whole morning trying to figure out what is wrong with it and it is getting silly. The logs are not being printed anywhere, and I am just trying to get eliot to print to the standard output
so I have sent it for review in case someone can give me a hint of how to use eliot.
I have used the code under benchmark/scenarios as an example of how to simply log with eliot.
When that didn't work, I tried to use the acceptance.py eliot_output. It was being called, but the messages it was receiving were empty.
The I following the example in the zfs code, making my own custom messages and trying to use write, thinking that if I had my own logger instance I could set it up to write to stdout. Logger() doesn't get any arguments. And I already tried with add_destination in the previous approach.
Help is more than welcome.

Pushed working version of eliot logging. I think it should be ok now

Ah, Jon already did first review pass so I'll leave it for him.

Setting up large number of virtually unusable containers has no real use outside of benchmarking. I suggest you move the two new files from the admin directory to the benchmark directory, to avoid cluttering the admin directory.  Remember to change the import in the script.

Please address the comments and re-submit. Also, there appear to be some comments from the previously addressed review that have not been addressed.  If there is a reason to not make the change suggested in a comment, please add a note to provide reasons for not making the change.
If all the above issues are addressed, a final review should be very quick.

Thanks for working on this. The two scripts make the benchmark setup and cleanup much easier.
A few minor comments to address, and then please merge when green (enough).

Green build. Merging pull request


0.0.7 Broke Web Assembly

I tried to update from 0.0.6 to 0.0.7, but it broke the web assembly build.
In file included from [...]/.build/checkouts/swift-numerics/Sources/_NumericsShims/_NumericsShims.c:19:
[...]/.build/checkouts/swift-numerics/Sources/_NumericsShims/include/_NumericsShims.h:387:42: error: _Float16 is not supported on this target
HEADER_SHIM _Float16 _numerics_muladdf16(_Float16 a, _Float16 b, _Float16 c) {
                                         ^

Thanks, I'll take a look.

Actually, yes, web assembly was just the first platform that my CI got to. All jobs were using Swift 5.2.4 unless otherwise specified:

macOS, tvOS, iOS and watchOS succeeded.
Windows (5.2.1), web (snapshot circa 5.2.1), CentOS, Ubuntu, Android (5.2.1) and Amazon Linux fail with the error message above.

Full CI logs are here in case there is other context information you want to fish out.

Hi, since this was reported very quickly (thanks!), I simply updated the 0.0.7 tag. It should be resolved now if you get a fresh copy.

I relaunched the CI jobs, you can watch them churn here.

And again after forcing the pins to refresh here. (I’m not sure what SwiftPM actually fetches when Package.resolved contains a version and revision that don’t match.)

Yeah, I expect a few people will have some transient hassles from shifting the tag, but it seemed like the cleaner quick fix.

The web job is now failing at a later point, but that one isn’t really swift-numeric’s fault, I don’t think. The snapshot in use is between 5.2 and 5.3, so I don’t think the #if swift(>=5.3) is doing what it is supposed to. I think the toolchain considers itself 5.3 but doesn’t have Float16 in the standard library yet. From what I can see in FloatingPointTypes.swift.gyb, only Float80 has platform restrictions, so I think the real 5.3 or a newer snapshot ought to actually contain Float16 on WASI.
The other platforms are all passing now, so I’ll close this.

Oh, and thanks for the quick fix!

Yeah, I agree with your take on the web issue. Hopefully that will flush out relatively soon.


This is a second issue

Can I assign issue, if I don't belong to the organization?

No, I cannot perform any other operation.


Allow synchronous type-only import of ESM package from CJS

Suggestion

🔍 Search Terms

List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily and help provide feedback.
import, type, esm
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

📃 Motivating Example
For a ESM-only package esm-package, if we import types from it in a CommonJS file:
import type {SomeType} from 'esm-package';

TypeScript warns in typescript 4.6.0-dev.20211225:
Module 'esm-package' cannot be imported using this construct. The specifier only resolves to an ES module, which cannot be imported synchronously. Use dynamic import instead.ts(1471)

For type-only import this shouldn't matter since it doesn't emit JavaScript code, so we can allow

💻 Use Cases
Types, in some cases, are not possible to lazy import asynchronously, such as a top level export:
import type {SomeType} from 'esm-package';

export const DEFAULT_CONFIG: SomeType = {
  // ...
};

That error makes no sense.  It’s an import, not a require() - why wouldn’t it be able to load ES modules using the ES module import syntax? 😕
That said, I’d expect this to work:
type SomeType = import(‘esm-package').SomeType;`

#47807 should provide options here - you'll be able to explicitly
type SomeType = import(‘esm-package', { assert: {"resolution-mode": "import"} }).SomeType;


update branch to main

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-12-16T17:36:04.448+0000

Duration: 9 min 35 sec

Commit: 904387f4dc4045d47405c694fda41ab3a199b421

Steps errors
Expand to view the steps failures

Run tests

Took 0 min 2 sec . View more details here
Description: .ci/run-test.sh

Run tests

Took 0 min 2 sec . View more details here
Description: .ci/run-test.sh

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

The changes look good.
However, I don't understand these test failures. For some reason, when running the Node v16 and v17 steps in Jenkins CI, inside the "node:16" and "node:17" docker containers, the current node version is 8.17.0?!
https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fecs-logging-nodejs-mbp/detail/PR-111/1/pipeline/103
[2021-12-16T17:42:24.946Z] + .ci/run-install.sh
...
[2021-12-16T17:42:24.946Z] + npm --prefix /var/lib/jenkins/workspace/js_ecs-logging-nodejs-mbp_PR-111/src/go.elastic.co/apm/ecs-logging-nodejs/helpers install
...
[2021-12-16T17:42:47.983Z] npm WARN notsup Unsupported engine for<EMAIL_ADDRESS>wanted: {"node":">= 10.0.0"} (current: {"node":"8.17.0","npm":"6.13.4"})
...

Unrelated test errors, I'll raise an issue to track those errors


Invalid Json body for the provided example

The JSON structure is not valid in the provided example:
https://docs.microsoft.com/en-us/rest/api/servicebus/send-message-batch

@spelluru Can you take a look?


Integrating the TwoQubitReduction into the ParityMapper

What should we add?
As outlined in #967 we want to extract the TwoQubitReduction from qiskit.opflow into the ParityMapper which is the only mapper that actually supports this hard-coded symmetry.
To achieve this, I envision an API similar to the following:
class ParityMapper:
    def __init__(self, two_qubit_reduction: bool = False, num_particles: tuple[int, int] | None = None):
        ...

We need to default the two_qubit_reduction to False because we do not know the num_particles by default.
Providing the num_particles at initialization time ensures that the mapper can be used right away. The downside is that this makes it stateful for the current problem.
I would also be open to discussing the following API (which I personally even prefer):
class ParityMapper:
    def __init__(self, num_particles: tuple[int, int] | None = None):
        ...

The idea here is that if num_particles is provided we enable the reduction and if it is None we do not. Simple and less redundant :+1:

Implementation of this issue is blocked by https://github.com/Qiskit/qiskit-terra/issues/9140 because we would want to immediately use the new SparsePauliOp-based Z2Symmetries :+1:

I can contribute here also

The first API highlights this idea that one can reduce the size of the problem (qubit requirements) without deciding on the symmetry sector.

That is indeed a good point! I'm wondering whether we should then generalize the naming and find something better than num_particles. Although here (in the ParityMapper for FermionicOp instances), the particle-interpretation seems fine, too.

That is indeed a good point! I'm wondering whether we should then generalize the naming and find something better than num_particles. Although here (in the ParityMapper for FermionicOp instances), the particle-interpretation seems fine, too.

The num_particles is later transformed into a symmetry operator eigenvalue tapering_value so the variable name will certainly lie between these two concepts. It is more natural that the mappers implement this transformation so that users only provide a physical property (instead of the abstract symmetry sector).


GDPR: Add possibility to disable telemetry pre-launch or make it opt-in

I cannot use this software in the EU as it is not GDPR compliant.
Collecting telemetry data by default does NOT conform to the General Data Protection Regulation of the EU that became effective in May 2018. It would be better to disable it per default and tell the user to enable it if he wants to share data with you.
Either you must provide a dialogue box with Yes/No at start-up or make it opt-in, defaulting to off.
Activating telemetry by default (i just tested with my firewall to block all connections) also goes against this basic principle:
https://en.wikipedia.org/wiki/Informational_self-determination
DISCLAIMER:
I do believe you that your intentions to add telemetry are purely benign and data collection is really just player counts, but understand the local laws and opt-out always takes away self-determination by forcing telemetry being on by default.
For now I am forced to add these to my hosts:
#cyber engine tweaks
<IP_ADDRESS> tiltedphoques.com
<IP_ADDRESS> cet.tiltedphoques.com

+1 to this - Telemetry MUST be optional

That said, reading though your implementation, you are generating a random string at each launch that is not persisted; this is an elegant way to do it.

This is GDPR compliant. We do not store any user data.
As @bryannolen mentioned, random ID is generated on start which has absolutely no ties to user and sent to our servers.
What we count is number of active users at some point in time and peak. We dont know which user, from where, etc.
This is more-or-less what Steam does too, and you are not suing them ;) You dont even have a right to opt out of this there, we have an option.
If we were tracking users, sure. But this has nothing to do with any sort of tracking, really just active players and peak players.

No data is collected, it is just a ping to count how many userd we have. It is absolutely GDPR compliant. If you are unhappy feel free to not use the mod.

This is GDPR compliant. We do not store any user data.

Whether or not data is stored is subjective. Just opening a connection and sending data to a server creates metadata in the net.

random ID is generated on start

A persistent one after generation or at each launch?
If at each launch it is useless.
If persistent a random ID has high entropy.

If you are unhappy feel free to not use the mod.

I think a local fork and a block in hosts is the superior alternative if you are unhappy with having a mature conversation and downvote and close WONTFIX ;)

At each launch. As said, this is same thing as Steam does for any game on their store tbh, there is absolutely 0 consent required for this. It is purely to have some numeric value attached to point in time denoting number of players who are in-game running CET.
Literally same as this right here:
https://steamdb.info/graph/
There is 0 actual user data attached. If you think pinging a server is against GDPR, dont use internet mate, cause you are pinging thousands of different computers till you get to the website you want, possibly even more servers if website utilizes content from other ones x)
As also said, we have an option to disable it at least. If this is what really bothers

Last reply cause I dont want my braincells to all die out...
https://cet.tiltedphoques.com/stat
This is literally data that is stored on server... 2 integers... Active players, max. recorded players.

I think a local fork and a block in hosts is the superior alternative if you are unhappy with having a mature conversation and downvote and close WONTFIX ;)

There is no discussion to be had, you misunderstand both GDPR and what we do here, this is 100% GDPR compliant and therefore there is nothing to fix.

Fun fact: GDPR does not apply to individuals
I understand the privacy concerns, but as pointed out here already:

The telemetry is GDPR compliant
GDPR doesn't apply to individuals in the first place
No actual user specific information is being transmitted

As such using GDPR as the justification for the requested change is not correct. If you don't like it, feel free to complain, but using GDPR as the basis for complaints will not lead to any productive discussion.

Could have saved yourself the troubles if you had common sense.

Could have saved yourself the troubles if you had common sense.
What goes around, comes around.

Please be aware, the experimental telemetry was already removed, as per the planned roadmap that was in place, in the latest release. There's no need to harp on a deprecated, no longer relevany, feature.


Import Wizard - Changing data type time->int results in error

I get the non-descriptive "Error inserting data into table" error when I change the data type from what ADS Import assumes (time) to the data type it actually is (integer).
Repro steps:

Create a CSV file where one of the columns only contains 5-digit integers (I assume this is the case for 6-digit as well).
Example:
Id,FilmType_id,CanisterBarcode
10076,2,169BZJ
10077,2,159BZI
10078,2,157BZG
10079,2,159AYG
10080,2,169BZJ
10081,2,169BZJ

Select this CSV file in the ADS Import plugin

Observe the assumed column data types

Change the Id column from time data type to int

Import the data (which will fail)

Notes:

I tried importing the data into the database without changing the data types and it works just fine inserting the time data type, so it is not a permissions issue connecting to the target database or anything like that.
I inserted a dummy record into the CSV with a 1-digit integer for the Id column and it now interprets the column as smallint. This works, but should not be necessary.

@mjk5182 I've updated the import extension where you should be getting more error messages. These changes will be included in future insiders builds (24-48 from this comment). Hopefully that will give you more context on whats breaking and you can update us as well.

Cannot reproduce the error. Closing this issue for now


Track pomodoros

It would be nice if there were a way to see how many pomodoros have been logged that day and/or session. Maybe in the popup? The count should poll the default beeminder goal in case pomodoros were logged to the goal manually.

Added in 09a8f4ebd48843c9e34c95c9e323b3b393f444d3.


How do I use sqlite3_load_extension?

I want to use sqlite-zstd to compress my sqlite db,now I have sqlite_zstd.so file for Android. how do I use "sqlite3_load_extension" to load sqlite_zstd.so extension? I'm not very familiar with Java. Could you provide an example?Thank you very much.
Below is the Java code I am using; I am not very familiar with Java, but have not been able to successfully load the extension, so there may be some errors.
//load an extension
private void loadExtension() {
SQLiteConfig config = new SQLiteConfig();
config.enableLoadExtension(true);
try {
if (connection != null) {
Statement stmt = connection.createStatement();
stmt.execute("SELECT load_extension('libsqlite_zstd')");
System.out.println("Extension '" + extensionName + "' loaded successfully.");
} else {
System.out.println("No connection to SQLite database. Cannot load extension.");
}
} catch (SQLException e) {
System.out.println("Error loading extension '" + extensionName + "': " + e.getMessage());
}
}

I want to use sqlite-zstd to compress my sqlite db,now I have sqlite_zstd.so file for Android. how do I use "sqlite3_load_extension" to load sqlite_zstd.so extension? I'm not very familiar with Java. Could you provide an example?Thank you very much. Below is the Java code I am using; I am not very familiar with Java, but have not been able to successfully load the extension, so there may be some errors.
//load an extension private void loadExtension() { SQLiteConfig config = new SQLiteConfig(); config.enableLoadExtension(true); try { if (connection != null) { Statement stmt = connection.createStatement(); stmt.execute("SELECT load_extension('libsqlite_zstd')"); System.out.println("Extension '" + extensionName + "' loaded successfully."); } else { System.out.println("No connection to SQLite database. Cannot load extension."); } } catch (SQLException e) { System.out.println("Error loading extension '" + extensionName + "': " + e.getMessage()); } }

The issue has been resolved; it was a problem with the path of the so file.


Any plans for an OpenAPI language server protocol server?

A LSP server for OpenAPI would greatly benefit users who are regularly checking for Editor alternatives.
@darrelmiller

This is really interesting.  Thanks for the pointer, I hadn't seen this protocol before.

@jugaadi How close does this https://github.com/azure/openapi-lint-extension come to meeting your needs?

Hello! Any updates on this one? We're building some tooling to help teams write better OpenAPI specs and an LSP server would be a tremendous help!

Paging @kevinswiber !

@darrelmiller any update on this?

There are quite a few OpenAPI extensions for VS Code now https://marketplace.visualstudio.com/search?term=openapi&target=VSCode&category=All categories&sortBy=Relevance  I would check out the one for 42Crunch, it may have implemented a Language Server.

No update on this.  I need to find time to get back to the project.  I've started with syntax highlighting for the different elements (semantically for OpenAPI, not just JSON).  I'd like to work on an embedded language option to highlight Markdown where it's supported in the spec, as well.  And then of course, reference and definition navigation, which I've begun.  It still has a long way to go.

We're trying to find a student in the Czech Republic who will take up the challenge and realise it as their master's thesis. The task is described here: https://docs.google.com/document/d/1TO2Jc4xqNe3tw8odbroCwVklxLJ7JOL19Zle2-QKG9I/edit#heading=h.t2v82sdl2asi (Czech language only, as we're targeting Czech students - but we could provide English translation if you see any chance of being picked up by university in your country).
We'll see if we're lucky or not.


Possible to set up server WITHOUT a uname & password?

I wrote an iOS/Mac app that used a Backdoor into pokevisions site to grab info and perform spiral searches but since that site is down it is a no go.
I would be willing to work with someone to enable users to set up there own servers and just point my app at the server in the settings.
Can this be done without a trainer account?
Proof app was built and working
https://m.facebook.com/story.php?story_fbid=1061613040574683&id=100001779903579&notif_t=like&notif_id=1469972903013982

@brntphish Let me get this straight, what you're asking for is for users to set up their own scanners and make them available online so you can backdoor into them and use them for yourself however you please?


Adding page load indicator feature && Moonpay widget

Adding a Page Load indicator. Displays a pleasant green loading bar at the top of the window ONLY if a page takes longer than 250ms to load.

The moonpay widget needs to be validated before implementation. I tested it on a different page but I've had some issues with register/login in my local env, so please verify it looks good on the wallet page before merging.

Closing to hold off on Moonpay integration.


tests: benchmark: Check for return values

Check for return value of k_mbox_get() and k_mbox_put()
functions.
Signed-off-by: Spoorthi K<EMAIL_ADDRESS>

Codecov Report

Merging #9661 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9661   +/-   ##
=======================================
  Coverage   52.17%   52.17%
=======================================
  Files         212      212
  Lines       25914    25914
  Branches     5583     5583
=======================================
  Hits        13520    13520
  Misses      10145    10145
  Partials     2249     2249

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72c4c5...ad5534e. Read the comment docs.


Add in support for OOM retry

This adds in the framework needed for OOM retry. It coordinates with RMMSpark so that it knows the state of each thread.

Had two tests fail where it looks like RMM was partly shut down but SparkRMM was not properly set up again. I will put a fix for this into spark-rapids-jni and hopefully this will fix it. I ran the tests locally and everything passed even before the change.

Looks like the fix in spark-rapids-jni made it to the nightly jar. Should we rekick this?

build

build

build

@abellina and @gerashegalov could you please take another look? I upmerged locally and there were no issues with the shim changes so I am hoping we can just merge this.

@abellina and @gerashegalov could you please take another look? I upmerged locally and there were no issues with the shim changes so I am hoping we can just merge this.

this remained unaddressed but it's fine https://github.com/NVIDIA/spark-rapids/pull/7822#discussion_r1121200409


Provide a fallback for LanguageAccept under Safari

Safari on macOS doesn't provide a language-only option in the header for languages accepted. When en-US is the preferred language, Safari only provides an "Accepted Language" of en-US without any fallback to en. Therefore, if a website is offering an en language version but not an en-US version, LanguageAccept.best_match returns None.
This pull request attempts to correct that by checking if None is returned and if so, trying again with language-only accepted values.

It appears this is a known issue? https://github.com/pallets/werkzeug/issues/450
It looks like there might be a better way to do this than what I came up with. I'll do a bit more research when I have time. For the time being my app is using my own function instead of best_match.

After some research, I don't see a better way to handle this, but I did add some additional tests.

Have the tests become more strict? Did I miss something? The tox app says there are failures in tests/test_test.py and src_werkzeug/debug/__init__.py, but my commit's version of those files is the same as in pallets:master.

You need to follow the style checks, in this case ensure you use Black to format the code. You can see the changes it wants to make here: https://travis-ci.org/pallets/werkzeug/jobs/524209888#L219-L262

There are three issues related to accept matching: #20, #450, and #458. I think #20 may be the same as #450, but it would be good to review them.

This doesn't go the opposite direction, where the client accepts "en", but the server looks for "en_US". Is that intended / correct?
a = LanguageAccept((("en", 0.9),))
m = a.best_match(("en_US",))
print(m)  # None

Added a fallback in the other direction. The process is now:

Exact match
Accept on primary, if the client accepts "en-US", "en" matches
Match on primary, if the client accepts "en", "en-US" matches

Also fixed to match 3-letter primary tags, like "aus".


#1994 Fixing to fallback in case of local execution

In order to allow the rendering of Tasks on downloaded reports, it need to handle the case get /tasks is not fulfilled.
cc @cyberw @EzR1d3r

thx


[discussion] Move from Travis to another CI solution

In Nov. 2020, Travis changed their pricing model and stopped offering free builds for OSS projects. The amount of free credits allotted automatically to us now is so frivolously insufficient, that we ran out of them for Jan. 2021 already, 3 days into the new year. To request more, we'll have to manually apply for a "case by case" consideration, each time we want more of it, which doesn't really sound like a pleasant experience.
At this point, it becomes clear that we cannot continue building on Travis. The godot-rust project is developed and maintained by volunteer contributors, and do not receive any form of funding. Staying on Travis, with its price point of $15 for 25000 credits, at this consumption speed, simply isn't an option. Thus, we'll have to find a replacement soon, for all the current PRs are blocked by this.
Potential options
Options are added as they're discovered. Feel free to suggest more!
Requirements:

Free for open source
Supports building on Windows and Mac (for platform-dependent tests)
bors integration

GitHub Actions
GitHub Actions are already used for some of our newer repos and they seem decent. They also seem to support Windows and MacOS. Like Travis they run on corporate money, but Microsoft's pocket should surely be deeper.
GitLab CI
This was suggested once in the past by karro on the grounds that it allows users to provide their own runners. Might worth considering if GitHub Actions turn out to be unusable for some reason.
Might not support multiple operating systems?
CircleCI
40000 minutes of build time per month for Linux machines. macOS access is behind manual approval. Payment required for Windows builds (~50 free minutes available from the free plan?).

I have some very limited but positive experience with Azure Pipelines. I have found this comparison of AP and GitHub Actions: https://medium.com/objectsharp/azure-pipelines-vs-github-actions-key-differences-45390ab132ee

I have some very limited but positive experience with Azure Pipelines. I have found this comparison of AP and GitHub Actions: https://medium.com/objectsharp/azure-pipelines-vs-github-actions-key-differences-45390ab132ee

@leiter-jakab I found this on the Azure website:

10 Free parallel jobs with unlimited minutes per month, 1 Free for Microsoft-hosted CD/CI parallel job with up to 1800 minutes per month and 1 Free for Self-hosted CD/CI parallel job with unlimited minutes per month

I'm a bit confused by this. If I understood this correctly, this means that we can only use Microsoft's servers for 1800 minutes per month, right? There is a distinction made here between a "parallel job" and a "Microsoft-hosted CD/CI parallel job", after all.
If we're relying on Microsoft anyway, I think we might as well use GitHub's offering which is clearly stated to be free for open source?

@leiter-jakab I found this on the Azure website:

10 Free parallel jobs with unlimited minutes per month, 1 Free for Microsoft-hosted CD/CI parallel job with up to 1800 minutes per month and 1 Free for Self-hosted CD/CI parallel job with unlimited minutes per month

I'm a bit confused by this. If I understood this correctly, this means that we can only use Microsoft's servers for 1800 minutes per month, right? There is a distinction made here between a "parallel job" and a "Microsoft-hosted CD/CI parallel job", after all.
If we're relying on Microsoft anyway, I think we might as well use GitHub's offering which is clearly stated to be free for open source?

Mmm, Gitlab CI, I think, does not support multiple operating systems, or if it does please tell me how, I'm using it and have always been relying on Docker images (which implies -> Linux).
Also maybe https://circleci.com/open-source/ can be used, I've been using Circle CI at my job for years, It says it offers free plans for Open Source projects, so that might be enough. Also they do have Mac OS support, as a side note. For Windows, TBH, cross-compiling is not that bad. I've been generating Windows binaries from Linux for the past 20 years, never had a single issue with the resulting binaries, once they are built, they are fine. It usually amounts to using a flavor of mingw, Microsoft is more permissive than Apple when it comes to SDKs.

Mmm, Gitlab CI, I think, does not support multiple operating systems, or if it does please tell me how, I'm using it and have always been relying on Docker images (which implies -> Linux).
Also maybe https://circleci.com/open-source/ can be used, I've been using Circle CI at my job for years, It says it offers free plans for Open Source projects, so that might be enough. Also they do have Mac OS support, as a side note. For Windows, TBH, cross-compiling is not that bad. I've been generating Windows binaries from Linux for the past 20 years, never had a single issue with the resulting binaries, once they are built, they are fine. It usually amounts to using a flavor of mingw, Microsoft is more permissive than Apple when it comes to SDKs.

@ufoot Thanks for the information! About other OSes: cross compilation from Linux would surely let us know whether the code compiles at all, but we'll still need actual target systems to run the tests, I assume?

@ufoot Thanks for the information! About other OSes: cross compilation from Linux would surely let us know whether the code compiles at all, but we'll still need actual target systems to run the tests, I assume?

@toasteater that's where the funny things come -> when it comes to testing Godot games, Wine has usually been really good enough for me. As a side note Wine is a very good platform to battle test your game since everything that can go wrong, usually goes wrong. You can even test graphical programs by using Xvfb, which emulates a virtual frame-buffer and allows you to run a complete X-server, but without a real display. The display can be materialized in a file on the filesystem, and you could even, technically, dump this to a .png and make graphical assertions on "my program should display a red rectangle here". While this kind of graphical assertions sound really (really) overkill to me, the simple version of just running a Windows program, especially a Godot one, within a Linux based CI, is not a big concern. I can help setting that up if needed.

@toasteater that's where the funny things come -> when it comes to testing Godot games, Wine has usually been really good enough for me. As a side note Wine is a very good platform to battle test your game since everything that can go wrong, usually goes wrong. You can even test graphical programs by using Xvfb, which emulates a virtual frame-buffer and allows you to run a complete X-server, but without a real display. The display can be materialized in a file on the filesystem, and you could even, technically, dump this to a .png and make graphical assertions on "my program should display a red rectangle here". While this kind of graphical assertions sound really (really) overkill to me, the simple version of just running a Windows program, especially a Godot one, within a Linux based CI, is not a big concern. I can help setting that up if needed.

@toasteater I think there might be a difference between parallel jobs and CD/CI parallel jobs. To be honest if the comparison I linked is correct, it's not worth the effort to dig deeper. As you said GH A seems clearly free and it seems feature rich with good GH integration I suppose.

@toasteater I think there might be a difference between parallel jobs and CD/CI parallel jobs. To be honest if the comparison I linked is correct, it's not worth the effort to dig deeper. As you said GH A seems clearly free and it seems feature rich with good GH integration I suppose.

@ufoot Good point that Wine can also be a platform to test for, even though Godot runs natively on Linux -- Linux is such a diverse platform, that I can imagine situations where the player can't run the native build, or where the developer doesn't want to claim Linux support and take on extra maintenance burdens. We should consider that as an option in place of (or in addition to) actual Windows builds!

@ufoot Good point that Wine can also be a platform to test for, even though Godot runs natively on Linux -- Linux is such a diverse platform, that I can imagine situations where the player can't run the native build, or where the developer doesn't want to claim Linux support and take on extra maintenance burdens. We should consider that as an option in place of (or in addition to) actual Windows builds!


file opened twice with fuzzy finder and treeview

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
You can open the same file twice in the same pane if it's opened once with the fuzzy finder and once with the tree view.
Steps to Reproduce

Open a file using the fuzzy finder.
Click on the same file that you've already opened in the tree view
Observe that there are now 2 tabs opened, both containing the same file.

Expected behavior:
Only one tab gets opened for the file, no matter how many different ways you try to open it.
Actual behavior:
You can open the same file twice in different tabs
Reproduces how often:
Every single time. This happens pretty often throughout the day and I usually don't notice it until I've made edits within both tabs.
Versions
$ atom --version
Atom    : 1.30.0
Electron: 2.0.9
Chrome  : 61.0.3163.100
Node    : 8.9.3
$ apm --version
apm  2.1.2
npm  6.4.1
node 10.11.0 x64
atom 1.30.0
python 2.7.15
git 2.19.0

Additional Information
I'm using fuzzy finder 1.8.2 and tree view 0.222.0.

Thanks for the report!  I'm unable to reproduce with Atom 1.32.0 on Ubuntu 18.04 but also:

Atom    : 1.30.0
Electron: 2.0.9

Based on these version details, we've determined that you are currently using an unofficial build or distribution of Atom. Often these customized versions of Atom are modified versions of the Stable branch of Atom with mismatched versions of built-in components. These updated components are taken from the Beta channel or master branch and then injected into the Stable version and a new Atom package is generated. Because of the way Atom is constructed, using these mismatched components can cause mysterious and hard-to-diagnose problems. You can find out more about why we chose to not support unofficial distributions here.
You can find instructions for installing an official version of Atom in the Flight Manual. If you are still seeing this problem on an official build please file a new issue, thanks!


Docker stack - add support of compose override files (proposal)

hello,
Docker compose documentation suggests the support of override files here but I cannot find any support for that in 'docker stack' command (neither in the docs, not when trying, and nor for dab files).
Integrating compose as part of Docker Swarm is a huge step forward but for real life environment overriding is absolutely a must otherwise managing the diff between dev, test, prod and various size deployments becomes too much of a mess.

/cc @dnephin @icecrime

Is there any plan to implement this in the near future?

+1
Agree totally. I'm in a blocker for this
Specifically need to deploy to different environments for different contraint's using
version: "3.1"
services:
  service:
    deploy:
      placement:
        constraints:
          - node.role == worker
          - etc...

And docker stack deploy -c

Duplicate of #30127

Closing as duplicate


ERR! enable Couldn’t enable a repository with this slug

hello:
i have a series of open source repos under the "MRN-Code/" org.  e.g. https://github.com/MRN-Code/coinstac-ui
however, greenkeeper won't let me enable them.  are there org specific settings i need to adjust?  i am able to enable on my own repos
thanks!
🛰  cdieringer:~/node/coinstac-ui$ greenkeeper --slug=MRN-Code/coinstac-ui enable
🌴  info enable The GitHub slug is: MRN-Code/coinstac-ui
🌴  ERR! enable Couldn’t enable a repository with this slug.
🌴  ERR! enable If you want to try your free private repository make sure to grant the necessary rights by running greenkeeper login --force --private
🌴  ERR! enable You have to have a plan for more than one private repository. To verify run greenkeeper whoami
🌴  ERR! enable If you have just recently created this repository try running greenkeeper sync
🌴  ERR! enable You need admin access to a repository to enable it.
🌴  ERR! enable If you think this error really shouldn’t appear let us look into it with greenkeeper support

Hey @cdaringe,
you might need to grant Greenkeeper access to that organization on an individual basis.
First make sure whether that's the case already by running greenkeeper whoami.
If your org doesn't show up please use greenkeeper access to grant rights to that organization.
After granting rights to a new organization run greenkeeper sync to make these repos available to us.
Best,
Stephan
(Happy to reopen if that does not fix it)

thank you!  the CLI is excellent.  i did have to login/logout, but everything else was smooth!


OPS-7177 smartpay-connect-stub: handle processTransaction

Above issues has been addressed , please approve


Edits and changes made in Onlyoffice are not saved into Nextcloud and are lost

####Issue
Edits and changes made in Onlyoffice are not saved into Nextcloud and sync from Nextcloud to Onlyoffice destroys all changes made in Onlyoffice.
Expected Behavior
Edits and changes written in Onlyoffice sync to the local desktop environment and the changes done in the desktop environment sync to OnlyOffice
Actual Behavior
Files stored in the local desktop environment are synced flawlessly to Nextcloud. Onlyoffice opens them flawlessly and lets the user edit the document. After saving the document and or logging out from nextcloud changes are kept in OnlyOffice cache and never written to the actual document. When user opens same document from the desktop the changes have disappeared. If user saves the document with a small change, this change is synced to OnlyOffice overwriting the changes in the cache.
Possible Fix
Write cache data to file regularly and frequently. Recognize when user leaves Onlyoffice or closes file and write cache to file. In short: Copy the functionality of Google Docs.
Steps to Reproduce

Use a desktop wordprocessor and create a document in a NextCloud synced folder in your desktop environment
Log onto the Nextcloud web UI and open the file with OnlyOffice.
Ask colleague to do the same
Make changes in document
Exit document
Open document with desktop wordprocessor from local NextCloud synced folder.
Notice that the changes never were saved to the file in NextCloud,.
Open file in OnlyOffice from the Nextcloud web UI to notice changes are still there
Close OnlyOffice
Make minimal change in the desktop wordprocessor and save file locally.
Let NextCloud sync
Open file in OnlyOffice from the Nextcloud web UI to notice all changes made in OnlyOffice have been lost and overwritten with those made in the desktop environment
Feel despair.

Context
We just lost 2 days worth of expensive work made by our consultant. This is becoming very expensive to us!
Your Environment

Nextcloud 18.0.3
OnlyOffice Community Server bundled with NextCloud 18
Nextcloud desktop client 2.6.4 Linux
Nextcloud desktop client 2.6.4 Mac

@timo12357, please note that if you are using Community Document Server integrated in Nextcloud Hub, you need to contact Nextcloud Support Team in case any issues are encountered, as this application was developed by Nextcloud Team. Please refer to this post on our Forum.


Property:latestPeriodOrHighestSystem

Definition
The full name of the latest possible geochronologic period or highest chronostratigraphic system attributable to the stratigraphic horizon from which the cataloged item was collected.

Existing property
dwc:latestPeriodOrHighestSystem

Existing class
Geological Context

Existing property identifier
http://rs.tdwg.org/dwc/terms/#latestPeriodOrHighestSystem

Format
controlled vocabulary

Required
No

Repeatable
No

Constraints

Examples
Neogene, Tertiary, Quaternary

Notes

Vocabulary https://timescalefoundation.org/index.html ?

I think for Chronostratigraphic terms we should be looking here: https://stratigraphy.org. This should be the international ratified list of geologic time terms.


Remove goog.dom.classlist usage

Remove some goog.dom.classlist calls where simple className updates can be made.

Thanks for any review

Very slick. Please merge.

Thanks @ahocevar


KIP-699: Work in progress

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mimaison Should be worth noting that there already exists a PR to simplify the ListOffsets API here: https://github.com/apache/kafka/pull/10467, so if that gets merged soon, you may need to rebase your implementation on top of that.

@skaundinya15 Yeah we may have to rebase but that shouldn't be an issue. I did not touch ListOffsets in this PR, I'm only updating methods that interact with coordinators

@rajinisivaram @tombentley @dajac Can you take a look? Thanks

@mimaison Could you briefly describe the core changes that you have made in the PR? That would be helpful to dive into it. Thanks!

@dajac Right, I've updated the description to give some context

@skaundinya15 Thanks for the review. I believe I've addressed all your comments.

@tombentley Thanks for the review! I've addressed your findings

Thanks @dajac for the review, I've addressed your comments

@tombentley @dajac @skaundinya15 Thanks for the reviews! I believe I've addressed all your comments now.

@dajac Thanks, I opened JIRAs for all follow up work items we identified.

I've rebased on trunk to resolve conflicts and I've had to make small changes due to updates on trunk. All new changes are in https://github.com/apache/kafka/pull/10743/commits/ae09d742171c8a3a7d60587ce0502dce35945f73.
I'll let Jenkins run now and I'll merge later if there's no issues.


Patch musl libc CVE

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-15650

This is unnecessary, as the patch has been applied in the base node 6.11.5 docker image


Disturbance in final result

I've trained my model with a Hindi dataset (tacotron+griffin lim synthesis without WaveNet) and the output has a disturbance which i dont know how to remove..
Kaho_na_pyar_hai.zip
I've used a single GPU to train and total data is around 6 hours. Which parameters could i change to observe better results? Please help!

I've trained my model with a Hindi dataset (tacotron+griffin lim synthesis without WaveNet) and the output has a disturbance which i dont know how to remove..
Kaho_na_pyar_hai.zip
I've used a single GPU to train and total data is around 6 hours. Which parameters could i change to observe better results? Please help!
the dataset you used in the work is open sorce ?


Fix logo.svg being cut off

This bothered me quite a bit. See rendered diff.

Sorry for the late response. I can't see any distinction between these two versions. Could you please explain in detail?

The issue is that the SVG uses font "DIN Condensed" which if not installed on the system will fallback to a system font. I'm on my Mac right now where this font is present and the logo looks right, but on Windows, the logo's text is cut off at iored.
The font should actually be converte to a path to render consistenly cross-platform, I'll see if I can do that.

Fix pushed. Logo text is now a path. Also ran it throught svgomg for some size optimizations.

Another small fix pushed. Looks like svgomg removed width and height. Added them back in.

Awesome! That looks cool. Thank you for the pull request. 🍻


Fix: sflow Extended Router Flow Record skipping IP type field

The sflow decodeExtendedRouterFlowRecord was missing address type detection, and decoding was off by 4 bytes if ExtendedRouterFlowRecord was not the last record.
The test packets have been updated to reflect the reference below (validated through pcap), and an additional IPv6 test was added to verify the detection was working as expected.
Packet format reference: http://sflow.org/developers/diagrams/sFlowV5FlowData.pdf

I signed it!

Hi! Thanks for contributing ..
Being not a sflow expert is @safchain or @actaeon would be able to review that code ?

@safchain I'll take a look at SFlowExtendedGatewayFlowRecord, and open another PR for it shortly.  Thanks!

OK, so as everybody agrees here, I am merging this one.


Documentation and minor improvements

Added

Add readme and changelog

Changed

Corrected the letters for exit.
Use descriptive glyph names for easy understanding

I have also removed a couple of lines as I didn't know what they were doing, please let me know if I was incorrect to.

Hi Carl.
Thank you for your contribution, I'm mostly away this weekend so haven't had a good chance to check your changes. Docs are always appreciated and I think you're right that the JS you've removed wasn't serving a purpose.
I enjoyed my braille method of describing the pieces' shapes though I think since most people don't know braille forms of letters this might have been an overly confusing approach, a good change.
My only concern is changes to the alphabet. Obviously the current version is not in line with the episode's given letters though I'm also hesitant to change it too often since then it will render previous text illegible. I'll likely do an alphabet update on the drop of the next HC video.
Though I'm definitely willing to be swayed on this. Ideally I believe that the alphabet needs to have a lot more thought in it so don't really want to get my hands dirty trying to understand the best way of formatting it.
Thanks again, great work

Thanks F.
Perhaps I misunderstood your project. I think I may have assumed that you were documenting Etho's alphabet with this project. If you prefer to use your own, I can redact that change from the pull request. Just thinking out loud here, if you want to having a functioning alphabet now, but also document Etho's alphabet, you could always have a toggle switch on the page: "Translation: [Homewood, Etho]". When toggled to Homewood, your complete alphabet is used and never changed, when toggled to Etho, his is used along with a disclaimer: "Etho's alphabet is incomplete and subject to change as revealed" or something like that. If and when Etho's alphabet is ever complete, you could remove the disclaimer and default to his if desired.
Let me know if you do decide to go down that route, as I'd be happy to try implementing the toggle. Also, let me know if I've overreaching here, it's your project at the end of the day, not mine!
Good work by the way.
All the best

Not overreaching you're doing grand haha,
I definitely want to be documenting the existing alphabet I'll not be taking credit for the one in place since it is largely inspired by another user.
My conflict was in whether users were going to end up with inconsistent text over time if the alphabet changes frequently.
Keep the PR as is, I think it's probably suitable to try and keep the alphabet as up to date as possible.
Though the ability to choose alphabets might be a good idea in future since people have seemed more enthusiastic about this then I had expexted.
Etho's clues about the alphabet will be few and far between I imagine so we should have plenty of time to respond to his changes.
Should hopefully get some time to review the changes more thoroughly tomorrow/this evening.
Cheers,
F


[FEAT]: Return thread name in the workspace API

What would you like to see?
In the latest version 1.6.0

https://github.com/Mintplex-Labs/anything-llm/blob/0b64aa51016db6286438f954a51a5472c01686e9/server/endpoints/api/workspace/index.js#L122

That is from the desktop branch


Represent uint64 as string

Even though json definition doesn't have limit in int size, it will cause troubles in tools like Postman and Swagger where values greater than int53 will be rounded down. If we define it as string, json parser might not assume native types in different languages

This seems reasonable to me. Eth1 has set the precedence of using 0x.. ascii-hex for uint256, perhaps it could be the same for uint64?

hmm, 0x sucks for readability though :/
String is my relatively naive vote

We are representing as string everywhere and prysmatic is doing the same


Builders: libs factory duplicated

there are two files registering j.builder.libs should be in one place and should be lazy loaded like apps factory

verifing that duplicated has been removed https://github.com/threefoldtech/jumpscaleX/commit/c248072c93e63c0ef4ae37d53b4ececfb2046e1e