Error in generated code in Safari 7

This issue was originally filed by<EMAIL_ADDRESS>
What steps will reproduce the problem?

Go to split-back.appspot.com on Safari 7. I'm not sure if you'll see the error immediately or if you'll have to enter your name in the join form and then you'll see it.

What is the expected output? What do you see instead?
I expect the page to load properly (feel free to view it in Chrome to see) and instead it throws the following error:
[Error] TypeError: 'undefined' is not a function (evaluating '$.defineNativeMethodsCommon(tags, interceptorClass, true)') defineNativeMethods (main.html_bootstrap.dart.js, line 20550)
What version of the product are you using? On what operating system?
I'm compiling using Dart version 24216 on 64-bit Linux.

obsolete.


Unhandled Exception on parsing non-date strings

In version 2.10.5 if I call
moment("a", moment.ISO_8601);
I get an unhandled exception.
In earlier versions this would give me an invalid moment object, which is what I want.

Same as #2512


webView.addWebAllowedObject update

Additional info on addWebAllowedObject

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/hosting/webview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks @david-risney! Will push this live today.


Better support for long method names

Long method names don't show up well in the tooltip even after they've been simplified.
Example long method after being simplified: thisIsAVeryLongAndUnnecessaryMethodName(WithEquallyLongArgumentTypes,AndOneMoreForGoodMeasure)
Will probably need to make the font smaller and split the artifact's signature up into multiple lines.

Currently working with UI design for updated designs. Including this in that work. Will assign to a milestone once the designs are ready.

A solution for this is present in the v0.5 UI design.


Todo first release

TODO:

[x] Add a readme that explains why --impure is needed
[x] Rename MkShell to Shell (and make a pass on exported symbols: Shell, Derivation and string_hack)
[ ] Remove string hacks
[ ] Create examples for derivation, and string context

We kept nix string hacks, and a derivation has been postponed. Closing for now, as the first release happened.


Gulp "retire" task added

To look for known vulnerabilities in dependencies. I think it could be a good idea to automate the check process. We have some problems now, I'm working on it but most of them don't depend on us.

As said via chat (XD) I prefer to keep the gulpfile.js clean use global commands:
$ npm instal -g retire

and then run retire in each project. Anyhow, thanks a lot for letting me know about retire, very useful!


make service_discovery disabled by default

What does this PR do?

This PR makes the service_discovery corecheck (added in https://github.com/DataDog/datadog-agent/pull/24861) disabled by default.
#incident-28512
Motivation

Since we need the changes from https://github.com/DataDog/datadog-agent/pull/26672 for the feature to be complete, we will leave it disabled until then.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge

The test failure on new-e2e-aml will be solved by #26753


Ionic 3 (iOS) - Custom ion-icon CORS issue

Bug Report
Problem
Custom svg ionic icons are not displayed on iOS because of a CORS issue.
What is expected to happen?
WKWebview should allow custom icons to be displayed as they are local resources.
What does actually happen?
On iOS, when trying to load a custom icon, CORS error is thrown:
Failed to load resource: Origin null is not allowed by Access-Control-Allow-Origin.
file:///private/var/containers/Bundle/Application/.../www/assets/imgs/arrow-down.svg

Information
Command or Code
Creating custom icon:
ion-icon {
  &[class*="custom-"] {
    mask-size: contain;
    mask-position: 50% 50%;
    mask-repeat: no-repeat;
    background: currentColor;
    width: 1em;
    height: 1em;
  }
  &[class*="custom-arrow-down"] {
    mask-image: url(../assets/imgs/arrow-down.svg);
  }
}

Using custom icon:
<ion-icon name="custom-arrow-down" color="primary"></ion-icon>
Environment, Platform, Device
iPhone 7 Plus
Version information

Ionic
Ionic Framework: ionic-angular 3.9.5
ionic (Ionic CLI): 3.20.1
@ionic/cli-utils: 1.19.3
@ionic/app-scripts: 3.2.3

Cordova
cordova (Cordova CLI): 9.0.0<EMAIL_ADDRESS>Cordova Platforms: ios 5.1.1

Checklist

[x] I searched for existing GitHub issues
[x] I updated all Cordova tooling to most recent version
[x] I included all the necessary information above

Related:
https://forum.ionicframework.com/t/ionic-3-custom-svg-icon-cors-issue/156796
https://stackoverflow.com/questions/54667997/ionic-3-custom-svg-icon-cors-issue

WKWebView has problem accessing local files when loaded from file:// protocol, see https://issues.apache.org/jira/browse/CB-10143
Since you are using ionic, you can use cordova-plugin-ionic-webview


Use schema that doesn't come from a file

It is sometimes useful to place the json schema in a file which may also contain other config. For example:
fields:
  not:

used:
  by:
  json_schema:

json_schema:

In the above example, we'd only need to give go-jsonschema the config which is under json_schema. The way I've been doing it so far is by making addFile a public function. Do you think this is ok?

Hi, @omissis! Do you think such a feature would be acceptable? I am happy to polish it or to take a different approach if you would like it done differently :)

@ptodev I am not sure I understand how the change correlates with the need you are exposing here. I would do something like to handle this case:
yq -M '.json_schema' your_config.yaml | go-jsonschema - --package example --output /tmp/your_config_schema.go

Probably you're talking about using go-jsonschema as a library? In that case I assume you've already extracted the schema from the property in the file before calling AddFile()?

@ptodev I am not sure I understand how the change correlates with the need you are exposing here. I would do something like this to handle your case:
yq -M '.json_schema' your_config.yaml | go-jsonschema - --package example --output /tmp/your_config_schema.go

Probably you're talking about using go-jsonschema as a library? In that case I assume you've already extracted the schema from the property in the file before calling AddFile()?

Hi @omissis that's correct, we're looking to use go-jsonschema as a library, and passing an extracted schema from a file containing the schema and other metadata. @ptodev is out on PTO right now so I'm trying to follow up!

I guess that's fine with me then. I'll be merging it once you'll mark this Ready for review.


Create abstract types

AbstractContinuousConvolutionOperator and AbstractDiscreteConvolutionOperator with default implementation of some methods, e.g.
size(F_N, n) = size(continuous_convolution_operator(F_N), n)
...

Created the following abstract types
abstract type AbstractSpatialOperator end
abstract type AbstractContinuousSpatialOperator <: AbstractSpatialOperator end
abstract type AbstractDiscreteSpatialOperator <: AbstractSpatialOperator end

But in fact, these names are awkward. Maybe chose AbstractConvolutionOperator as initially suggested?


Flutter Toast not looking same in android devices its show a flutter icon also

I am using the following method to show toast in the flutter app It works perfectly on ios side but in android, it's not working as same its shows a logo of the flutter icon or does not change the background color please check the attached image.
Android image Link: Android Screenshot
Ios image Lins: iOS Screenshot
  static void showToast({required String message}) {
    Fluttertoast.showToast(
        msg: message,
        toastLength: Toast.LENGTH_SHORT,
        gravity: ToastGravity.BOTTOM,
        timeInSecForIosWeb: 1,
        backgroundColor: Colors.black,
        textColor: Colors.white,
        fontSize: 16.0);
  }

Hi @alok2811 , according to this package's latest readme, it says the following
"Custom Toast will not work on android 11 and above, it will only use msg and toastLength remaining all properties are ignored"
I believe this is why it works perfectly on iOS but not in android.

@ngjunya Thank you for the kind reply can you please suggest what I can do or move with another package?
@ponnamkarthik Sir can you please tell me when it is resolved?

@alok2811 Welcome. While waiting it to be resolved, you can try out this package -> https://pub.dev/packages/flutter_styled_toast. This toast package allows you to create customised toast message. The only difference is this toast package requires build context.

@alok2811 : How do we show app icon on iOS?


Installing Offline

Hello
I am trying to install and use docker in a Windows machine with no internet connection. During the insallation steps, boot2steps.exe -v init command stops with an error, stating a connection error about connecting to github. Is there an easy way to install and use boot2docker without any internet connection?
Thanks.

The problem was about vt-x being disabled from bios. When vt-x is enabled, boot2docker.exe does not try to download the image and the rest works fine.


Makefile fixes.

'make clean' wasn't cleaning everything. Now it is. This
fixes the gencheck CI job.

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
8ff5484b40b94e34f4a75708355b65e67158fc5a
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
8ff5484b40b94e34f4a75708355b65e67158fc5a
link
/test gencheck_operator

lint_operator
8ff5484b40b94e34f4a75708355b65e67158fc5a
link
/test lint_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
8ff5484b40b94e34f4a75708355b65e67158fc5a
link
/test gencheck_operator

lint_operator
8ff5484b40b94e34f4a75708355b65e67158fc5a
link
/test lint_operator

mandiff_operator
8ff5484b40b94e34f4a75708355b65e67158fc5a
link
/test mandiff_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator
8ff5484b40b94e34f4a75708355b65e67158fc5a
link
/test lint_operator

mandiff_operator
8ff5484b40b94e34f4a75708355b65e67158fc5a
link
/test mandiff_operator

gencheck_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

mandiff_operator
8ff5484b40b94e34f4a75708355b65e67158fc5a
link
/test mandiff_operator

gencheck_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test gencheck_operator

lint_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test lint_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test gencheck_operator

lint_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test lint_operator

mandiff_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test mandiff_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test gencheck_operator

lint_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test lint_operator

mandiff_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test mandiff_operator

test_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test test_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test lint_operator

mandiff_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test mandiff_operator

test_operator
2b48b0622815e959dc40f409b506274e20310110
link
/test test_operator

gencheck_operator
67c995a51b0b5755d818243b8b2e277763f1fa8b
link
/test gencheck_operator

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Update zio-config, zio-config-magnolia, ... to 1.0.0-RC31-1

Updates

dev.zio:zio-config
dev.zio:zio-config-magnolia
dev.zio:zio-config-typesafe

from 1.0.0-RC29-1 to 1.0.0-RC31-1.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

labels: library-update, semver-pre-release

Superseded by #173.

Superseded by #173.


how to hide a process using a command line?

example:
r77rootkit.exe -hide 'processID' or 'process name'

You need to first install the rootkit. For this, just execute Install.exe.
Wait about 500ms until the registry key $77config was created by the rootkit.
Write the PID or process name to HKEY_LOCAL_MACHINE\SOFTWARE\$77config

This is explained in more detail in the documentation.

Oke Thank you!


[LIVY-389][BUILD] Change POM and packaging to meet Apache Criteria

Change LIvy POM and assembly xml to meet Apache Criteria:

Add Apache parent POM to Livy POM.
Add LICENSE/NOTICE/DISCLAIMER to artifact's META-INF and package folder.

CC @ajbozarth @lresende please help to review.

I don't see any problems, but I also don't exactly know what I'm looking for

There's no problem here, leveraging apache parent POM will help to solve the problem I mentioned above (http://www.apache.org/legal/release-policy.html#licensing-documentation).

Codecov Report

Merging #32 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
+ Coverage     70.46%   70.65%   +0.18%
- Complexity      777      779       +2
============================================
  Files            97       97
  Lines          5370     5370
  Branches        806      806
============================================
+ Hits           3784     3794      +10
+ Misses         1051     1038      -13
- Partials        535      538       +3

Impacted Files
Coverage Δ
Complexity Δ

...in/java/org/apache/livy/rsc/driver/JobWrapper.java
80.64% <0%> (ø)
8% <0%> (+1%)
:arrow_up:

rsc/src/main/java/org/apache/livy/rsc/rpc/Rpc.java
79.88% <0%> (+0.59%)
12% <0%> (ø)
:arrow_down:

...ain/java/org/apache/livy/rsc/driver/RSCDriver.java
78.99% <0%> (+0.84%)
40% <0%> (-1%)
:arrow_down:

rsc/src/main/java/org/apache/livy/rsc/Utils.java
85.71% <0%> (+2.38%)
16% <0%> (ø)
:arrow_down:

...java/org/apache/livy/rsc/rpc/KryoMessageCodec.java
98.21% <0%> (+3.57%)
19% <0%> (+1%)
:arrow_up:

...in/java/org/apache/livy/rsc/rpc/RpcDispatcher.java
68% <0%> (+4%)
20% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3fe03...632db93. Read the comment docs.

Merging to master and branch 0.4.


[cxx-interop] Replace std module name with the new spelling CxxStdlib

This is the second step in renaming the C++ stdlib module std into CxxStdlib.
See https://github.com/apple/swift/pull/61099.

@swift-ci please smoke test


TypeError: Cannot read property 'tap' of undefined when used with html-webpack-plugin 4.0.1

I am building a sandbox for internal use, making sure we always get the latest versions of packages, when setting up a new sandbox. I can restrict this if need be, tho interested in getting it sorted.

@b3nk3 you do not need this plugin anymore, it was extracted from react-dev-utils. You can use a version working directly from there: https://github.com/facebook/create-react-app/tree/master/packages/react-dev-utils#new-interpolatehtmlpluginhtmlwebpackplugin-htmlwebpackplugin-replacements-keystring-string

Gosh, I found that out a few days after raising this ticket and I forgot to close it. Apologies.
Appreciate you taking the time to comment.


chore(ui): restructure header

Changes proposed
Restructures the Header component.

@Jay-Karia please attach the issue in PR description.

Sorry for not follow the guidelines, I will take care of it in future.

@Jay-Karia please do not make any changes without being assigned to the issue. Also, We have social icons in the navbar because, when the user moves to another page, they can still see the icons.
@Anmol-Baranwal @CBID2 what are your views on this??

@Jay-Karia please do not make any changes without being assigned to the issue. Also, We have social icons in the navbar because, when the user moves to another page, they can still see the icons.
@Anmol-Baranwal @CBID2 what are your views on this??

Social links should be in the navbar. Adding them in different places is very effective because we don't know where the user lands from the Google (it can be any of the inner pages). For example, many YCombinator companies follow this practice.
I think it’s fine as it is because the desktop version is wide, and it's standard to find most of the relevant elements in the navbar. Replacing Our team with Team might be a good idea but it's not 100% necessary!

We can add social icons in the footer

We can add social icons in the footer

It's not necessary. We prefer to leave the icon as they are. Although, you can replace our team with team.

And what about the position of "Saved" link ?

And what about the position of "Saved" link ?

yeah, keep it as it is.

@rupali-codes, this pull is ready for review

@rupali-codes what should we do here ?


Milestones on PRs not taken into account

I've tried to regenerate the changelog on https://github.com/ember-cli/ember-cli-mocha, but seems to ignore the milestones set on some of the PRs.
e.g. https://github.com/ember-cli/ember-cli-mocha/pull/134 has milestone v0.13.0 but generating the changelog puts it under the v0.12.0 release instead.
$ github_changelog_generator --version
Version: 1.14.1

filter_by_milestone feature option is used here: https://github.com/skywinder/github-changelog-generator/blob/d551c3a1987f34f6d1b20e2c35bcdf52b9a827ab/lib/github_changelog_generator/generator/generator_generation.rb#L103

github_changelog_generator --future-release v0.13.0

and
github_changelog_generator --future-release v0.13.0 --filter-by-milestone

both result in the same and wrong result. Removing the --future-release option also doesn't have any effect aside from changing the future release name as expected.

@olleolleolle I should probably add that the option seems to work fine for issues, but it does not work for PRs

@olleolleolle I have debugged this further and it seems that --future-release is indeed responsible for the problem, or rather it doesn't work as I would expect it.
Milestones are taken into account for all git tags, but the milestone that matches the --future-release isn't. In other words: if you try the changelog generator on the repository linked above it will work right as expected because the v0.13.0 is tagged and released now. If you try it with e.g. a --future-release v0.14.0 and have a v0.14.0 milestone with PRs in it, those PRs might not necessarily be assigned to the correct release by the generator.


Improve installation speed during development by skipping previously installed packages.

Exactly as the title suggests, the checkDependency function checks to see whether a package is installed on the system or not, skipping if that is the case. Arch support included out of box, will test debian and fedora asap :)

Ok everything is tested and works ok, a bit unsatisfied with the results as arch is the only distro that recieves any benefit, but the checkDependency can be used throughtout the script in later parts if needed as well. Anyways hope this is a welcome contribution :)

Rad


Test PR

This is a test to see whether a webhook works or not

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


AdaptiveDatePicker always uses the current date as the initial date on iOS

Regardless of what is passed in to AdaptiveDatePickerState, the iOS UIDatePicker always starts with the current date selected.

Thanks for reporting this, I will check it.


Use named args for Punctuated strategies instead of parse_with

With a bit of a departure from using named args for this sort of thing, I think it's best to keep punctuated as-is. Feel free to discuss further if you feel strongly about this change as I'm still certainly open to listening.


Clear out the userspace repo and put link to 3box in readme

Should we do this after we release the mvp?

@oed can you check the repo and make sure this is what you meant by "clean out."
Should we delete all the text in the readme except for the redirect, or should we leave the API spec? Wasn't sure.

@michaelsena we should remove all text in the readme yeah. Also remove all files in the repo except the readme.


SFA created with texture issue

I have converted .obj file with .mtl and .jpg texture. It converts to sfa and sfb. But the texture is having some issues like below,what is missing in this?
created .sfa file:
{
   materials: [
      {
         name: "icon_03",
         parameters: [
            {
               baseColor: "icon_03",
            },
            {
               baseColorTint: [
                  0.80000000000000004,
                  0.80000000000000004,
                  0.80000000000000004,
                  1,
               ],
            },
            {
               //metallic: 1,
               metallic: 0,
            },
            {
               //roughness: 0.19611600000000001,
               roughness: 1,
            },
            {
               opacity: null,
            },
         ],
         source: "build/sceneform_sdk/default_materials/obj_material.sfm",
      },
   ],
   model: {
      attributes: [
         "Position",
         "TexCoord",
         "Orientation",
      ],
      file: "sampledata/models/icon_03.obj",
      name: "icon_03",
      scale: 0.05,
      suggested_collision: {
         center: {
            x: 0,
            y: 0,
            z: 0,
         },
         size: {
            x: 1,
            y: 1,
            z: 1,
         },
         type: "Box",
      },
   },
   samplers: [
      {
         file: "sampledata/models\\icon_03.jpg",
         name: "icon_03",
         pipeline_name: "icon_03.jpg",
      },
   ],
   version: "0.51:1",
}

icon_03.mtl
newmtl icon_03
map_Kd icon_03.jpg
Ka 0.000000 0.000000 0.000000
Kd 0.800000 0.800000 0.800000
Ks 0.000000 0.000000 0.000000
illum 2
Ns 50.000000
Tr 1.000000

Issue in texture:

Original texture:(.jpg file)

Android Studio 3.1.2
Build #AI-173.4720617, built on April 14, 2018
JRE: 1.8.0_152-release-1024-b02 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

Any idea about this issue?

Hi @rramprasad thank you for submitting this issue.
The lighting on the asset in your screenshot definitely doesn't look right.  It looks like there are a few different issues:

If you're concerned about shininess, this is happening because of the line
Ns 50.000000 in your .mtl file.  That is requesting a material with a very high phong exponent, which in our lighting model maps to a very low roughness.  Try setting the 'roughness' parameter in your .sfa to 1.0 and rebuild.
It looks like the geometry with the icon texture isn't exported with normals.  There is an issue in the 1.01 release where normal generation always makes a fully smoothed model, which is rarely what people want.  This will be addressed in the next release; in the meantime you can work around by exporting explicit normals
Note that a separate issue in 1.01 is the view does not consistently update when a new .sfb is computed; closing the asset in android studio and re-opening should work.

@AdrianAtGoogle,please see comments below,

If you're concerned about shininess, this is happening because of the line
Ns 50.000000 in your .mtl file. That is requesting a material with a very high phong exponent, which in our lighting model maps to a very low roughness. Try setting the 'roughness' parameter in your .sfa to 1.0 and rebuild.

Yes,Already my .sfa roughness parameter is 1.0. So the output is same as above screenshot.

It looks like the geometry with the icon texture isn't exported with normals. There is an issue in the 1.01 release where normal generation always makes a fully smoothed model, which is rarely what people want. This will be addressed in the next release; in the meantime you can work around by exporting explicit normals to your .obj file.

I think already by .obj contains normals. I have attached my .obj file(renamed .obj to .txt). Is it anything issue in this .obj file?
icon_03.txt

Hi @rramprasad,
You're correct that the model already has normals - in fact it seems that is the problem.
I saved your linked text file as an .obj, made the .mtl and the .jpg from the contents of the OP, and imported the model into blender 2.79 - the result has the same issues present in the sceneform asset.
Here is a screenshot:

The normals in the asset do not seem to be correct; many of them are inward facing (causing the lighting seams across triangles).  The normal issues need to be fixed in the source asset

Sounds like this resolved - please reopen if not.  Thanks!!


Add benchmarks, compare Beap with BinaryHeap.

It is also interesting to compare the speed of search, insertion and deletion with BTreeMap.


Question about the KL term in the loss function

For y ~ p_chosen, the KL term for the loss is derived as  KL(p_policy(y_rejected|x') || p_reference(y_rejected|x'))), however according to technical report, the KL divergence should be calculated over the entire dataset. Is there a reason x' for above only includes only rejected inputs and not input x's from the entire batch (i.e include y_chosen too) ? I can guess maybe numerical stability could be the reason to make sure that two terms of the loss aren't correlated but want to make sure I am not missing something here.

Great question!
In the current implementation, the KL term is calculated over each minibatch, not the whole dataset. For chosen example losses, the KL term is calculated with the rejected examples and vice-versa, as you point out. Because there's a 50/50 split of chosen:rejected examples in each minibatch (as enforced by the dataloader), this is possible. The reason we do this is that since we are also back-propagating through the KL term, the gradient wrt each example depends also on its contribution to the KL term. If we estimated the KL for each loss with all examples in the minibatch, then it would be possible for the gradient to increase the likelihood of a rejected example and decrease the likelihood of a chosen one. We don't ever want that, hence our implementation.
The big drawback of this is the need for a 50/50 split of chosen:rejected examples in each minibatch, which limits the scenarios in which KTO can be used.
To address this, tomorrow I will be pushing a better implementation: estimate the batch-wise (not minibatch-wise) KL by creating mismatched pairs of input-output pairs (x_i, y_{i+1}) and then do not backprop through this term. This gets rid of the current requirement for the 50:50 chosen:rejected split in each minibatch and the different KL estimate for chosen and rejected examples. It also works better in practice!

@rajat95 The newer implementation I mentioned above has now been implemented (see here).
i.e., We now estimate a single batchwise KL term for both the chosen and rejected losses, and we don't backprop through this KL term either. This means that we no longer need an even ratio of chosen: rejected examples in each minibatch, making KTO much easier to use.
For example, we found that you can throw away about 90% of your chosen examples (while keeping all of your rejected examples) and still reach DPO-level performance with this new KTO implementation. Let me know if you have any more questions!

thanks a lot for succint explanation!


Build running in timeouts on Linux and Windows with VFS retention enabled

When running the VFS retention tests on Linux, it seems like the process hangs in NativeFileWatcher.stop: https://builds.gradle.org/viewLog.html?buildId=32144797&buildTypeId=Gradle_Check_VfsRetention_28_bucket41&tab=buildLog&_focus=9303
The test DirectoryBuildCacheCleanupIntegrationTest.cleans up entries seems to be one of the hanging tests.
This is from the thread dump:
[13:51:49] :     [Step 1/2] "Daemon worker" #21 prio=5 os_prio=0 cpu=2639.29ms elapsed=9900.61s tid=0x00007f8130009800 nid=0x59dd runnable  [0x00007f818875d000]
[13:51:49] :     [Step 1/2]    java.lang.Thread.State: RUNNABLE
[13:51:49] :     [Step 1/2]     at net.rubygrapefruit.platform.internal.jni.AbstractFileEventFunctions$NativeFileWatcher.stop(Native Method)
[13:51:49] :     [Step 1/2]     at net.rubygrapefruit.platform.internal.jni.AbstractFileEventFunctions$NativeFileWatcher.close(AbstractFileEventFunctions.java:64)
[13:51:49] :     [Step 1/2]     at org.gradle.internal.vfs.AbstractEventDrivenFileWatcherRegistry.close(AbstractEventDrivenFileWatcherRegistry.java:84)
[13:51:49] :     [Step 1/2]     at org.gradle.internal.vfs.impl.DefaultWatchingVirtualFileSystem.stopWatching(DefaultWatchingVirtualFileSystem.java:100)

We also have the case that the build hangs for more than 2 hours in stopWatching and then finally finishes successful: https://builds.gradle.org/viewLog.html?buildId=32196679&buildTypeId=Gradle_Check_VfsRetention_28_bucket41&tab=testsInfo&branch_Gradle_Check_VfsRetention_28=master

cc: @gradle/build-cache

Would it help if we logged the start and end of shutting down from the Java side more clearly?

You mean that would help in detecting whether the test is hanging when stopping the native watchers? If we could fail the build if stopping the watcher takes longer than a minute that would be even better I think. The logging is hard to access while the build is running and we are unable to access if the test ends up passing.

Here is a Windows build on release which hangs in VirtualFileSystemRetentionIntegrationTest.source file changes are recognized when retention has just been disabled. That may be the same problem. https://builds.gradle.org/buildConfiguration/Gradle_Check_Platform_4_bucket40/32228813?buildTab=tests&pager.currentPage=1&orderBy=duration&order=desc

Why do these tests ultimately pass I wonder?

Is it because the builds are expected to fail, and they recognize the timeout as the expected failure?

The test do not pass. I suspect that Teamcity only receives the test started event and since it doesn't receive the test finished/failed event it marks the test as passed (aka it didn't fail). The Gradle build never finishes since it is killed by Teamcity when the build is aborted.

I got this native stack from a hanging Windows build:
ntoskrnl.exe!KeSynchronizeExecution+0x5b76
ntoskrnl.exe!KeWaitForMutexObject+0x1c2d
ntoskrnl.exe!KeWaitForMutexObject+0xab4
ntoskrnl.exe!KeWaitForMutexObject+0x255
ntoskrnl.exe!KeTestAlertThread+0x25a7
ntoskrnl.exe!KeWaitForMutexObject+0x3828
ntoskrnl.exe!KeWaitForMutexObject+0x1cc8
ntoskrnl.exe!KeWaitForMutexObject+0xab4
ntoskrnl.exe!KeDelayExecutionThread+0x4c0
ntoskrnl.exe!SeReleaseSubjectContext+0x14ef
ntoskrnl.exe!setjmpex+0x7c45
ntdll.dll!NtDelayExecution+0x14
KERNELBASE.dll!SleepEx+0xa1
native-platform-file-events.dll!Java_net_rubygrapefruit_platform_internal_jni_NativeLogger_initLogging+0xffd6
native-platform-file-events.dll!Java_net_rubygrapefruit_platform_internal_jni_NativeLogger_initLogging+0x1ec84
native-platform-file-events.dll!Java_net_rubygrapefruit_platform_internal_jni_NativeLogger_initLogging+0x209f6
native-platform-file-events.dll!Java_net_rubygrapefruit_platform_internal_jni_NativeLogger_initLogging+0x23065
native-platform-file-events.dll!Java_net_rubygrapefruit_platform_internal_jni_NativeLogger_initLogging+0x217d1
native-platform-file-events.dll!Java_net_rubygrapefruit_platform_internal_jni_NativeLogger_initLogging+0x9bd5b
KERNEL32.DLL!BaseThreadInitThunk+0x14
ntdll.dll!RtlUserThreadStart+0x21

Using process explorer.
@lptr Can you make any sense of it?

This is from https://builds.gradle.org/buildConfiguration/Gradle_Check_VfsRetention_30_bucket16/32328109?

Huh? That looks really weird...

Assuming it's the same structure as a Java stacktrace (i.e. calls happen from bottom to top, each line representing a call site) it doesn't make sense. Java_net_rubygrapefruit_platform_internal_jni_NativeLogger_initLogging() definitely doesn't make any calls to itself, or to SleepEx().
Can it be that we mess up something about the debug symbols, maybe Windows finds a PCB belonging to a different version of the DLL? (I realize I'm mostly throwing around jargon I have no idea about, but that's the best I have here.)

I actually have no idea how to read this trace. It includes the same function name multiple times for ntoskrnl.exe!KeWaitForMutexObject, but with a call to ntoskrnl.exe!KeTestAlertThread in the middle. Is this some callback mechanism, or...? And if it is, how does that explain the duplication of Java_net_rubygrapefruit_platform_internal_jni_NativeLogger_initLogging?

This is what it looks like in process explorer:

After using a snapshot from https://github.com/gradle/native-platform/pull/130, the timeout seems to be gone on Windows, though now there are quite a few failing tests: https://builds.gradle.org/viewLog.html?buildId=32345639&buildTypeId=Gradle_Check_VfsRetention_30_Trigger&tab=buildResultsDiv&branch_Gradle_Check_Stage_ExperimentalVFSRetention=master
One of the things I see is an StringIndexOutOfBoundsException:
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
	at java.base/java.lang.StringLatin1.charAt(StringLatin1.java:48)
	at java.base/java.lang.String.charAt(String.java:711)
	at org.gradle.internal.snapshot.VfsRelativePath.normalizeRoot(VfsRelativePath.java:63)
	at org.gradle.internal.snapshot.VfsRelativePath.of(VfsRelativePath.java:50)
	at org.gradle.internal.vfs.impl.DefaultSnapshotHierarchy.invalidate(DefaultSnapshotHierarchy.java:78)
	at org.gradle.internal.vfs.impl.DefaultVirtualFileSystem.lambda$update$18(DefaultVirtualFileSystem.java:169)
	at java.base/java.util.concurrent.atomic.AtomicReference.updateAndGet(AtomicReference.java:210)
	at org.gradle.internal.vfs.impl.DefaultVirtualFileSystem.update(DefaultVirtualFileSystem.java:166)
	at org.gradle.internal.vfs.impl.AbstractDelegatingVirtualFileSystem.update(AbstractDelegatingVirtualFileSystem.java:52)
	at org.gradle.internal.vfs.impl.DefaultWatchingVirtualFileSystem.update(DefaultWatchingVirtualFileSystem.java:36)
	at org.gradle.internal.vfs.impl.DefaultWatchingVirtualFileSystem$1.handleChange(DefaultWatchingVirtualFileSystem.java:65)

It looks like the Windows watcher passes an empty String as path to the callback.

@blindpirate found some more hangs in our regular builds:

Platform Java14 Openjdk Windows (ideNative,antlr,snapshots,fileCollections,persistentCache / master)
ForceRealizeDependencyManagement Java8 Oracle Linux (instantExecution,resourcesGcs,resourcesS3,snapshots,resourcesSftp) / release (first, second)
Soak Java8 Oracle Windows / master

I opened #12485 for the index out of bounds problem after updating to a newer snapshot.

I was able to reproduce a hang on Linux running ./gradlew logging:vfsIntegTest from this branch: https://github.com/gradle/gradle/pull/12473
There are two tests hanging - AutoConsoleLoggingHooksFunctionalTest and RichConsoleLoggingHooksFunctionalTest. Both hang in NativeFileWatcher.stop:
"Daemon worker" #21 prio=5 os_prio=0 cpu=1896.46ms elapsed=7136.22s tid=0x00007f0ce800c000 nid=0x3713 runnable  [0x00007f0d44e1c000]
   java.lang.Thread.State: RUNNABLE
        at net.rubygrapefruit.platform.internal.jni.AbstractFileEventFunctions$NativeFileWatcher.stop(Native Method)
        at net.rubygrapefruit.platform.internal.jni.AbstractFileEventFunctions$NativeFileWatcher.close(AbstractFileEventFunctions.java:70)
        at org.gradle.internal.vfs.AbstractEventDrivenFileWatcherRegistry.close(AbstractEventDrivenFileWatcherRegistry.java:99)
        at org.gradle.internal.vfs.impl.WatchingVirtualFileSystem.stopWatching(WatchingVirtualFileSystem.java:133)
        at org.gradle.internal.vfs.impl.WatchingVirtualFileSystem.beforeCompletingBuildWithWatchingEnabled(WatchingVirtualFileSystem.java:80)
        at org.gradle.internal.service.scopes.VirtualFileSystemBuildLifecycleListener$RetentionBuildLifecycleListener.beforeComplete(VirtualFileSystemBuildLifecycleListener.java:127)
        at org.gradle.internal.service.scopes.VirtualFileSystemBuildLifecycleListener.beforeComplete(VirtualFileSystemBuildLifecycleListener.java:77)
        at<EMAIL_ADDRESS>Method)

I also managed to get the native stack traces by installing elfutils and running
sudo eu-stack -p <PID>

Here are the two relevant (aka in Server) native stacks:
TID 14099:
#0  0x00007f0d7b3a1360 pthread_cond_wait@@GLIBC_2.3.2
#1  0x00007f0cc5b5f91c std::condition_variable::wait(std::unique_lock<std::mutex>&)
#2  0x00007f0cc5e70953 AbstractServer::executeOnThread(std::shared_ptr<Command>)
#3  0x00007f0cc5e67d19 Server::~Server()
#4  0x00007f0cc5e67e0c Server::~Server()
#5  0x00007f0cc5e71d2b Java_net_rubygrapefruit_platform_internal_jni_AbstractFileEventFunctions_00024NativeFileWatcher_stop
#6  0x00007f0d5c966970

TID 14458:
#0  0x00007f0d7b3a451d read
#1  0x00007f0cc5e680fd Server::handleEvents()
#2  0x00007f0cc5e68000 Server::processQueues(int)
#3  0x00007f0cc5e67e96 Server::runLoop(JNIEnv_*, std::function<void (std::__exception_ptr::exception_ptr)>)
#4  0x00007f0cc5e70848 AbstractServer::run()
#5  0x00007f0cc5e78c71 void std::_Mem_fn_base<void (AbstractServer::*)(), true>::operator()<, void>(AbstractServer*) const
#6  0x00007f0cc5e78c05 void std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)>::_M_invoke<0ul>(std::_Index_tuple<0ul>)
#7  0x00007f0cc5e78b0c std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)>::operator()()
#8  0x00007f0cc5e78a9c std::thread::_Impl<std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)> >::_M_run()
#9  0x00007f0cc5b64c80
#10 0x00007f0d7b39b6ba start_thread
#11 0x00007f0d7acbc41d __clone

and
TID 9489:
#0  0x00007f6312aee360 pthread_cond_wait@@GLIBC_2.3.2
#1  0x00007f6268fc391c std::condition_variable::wait(std::unique_lock<std::mutex>&)
#2  0x00007f62692d4953 AbstractServer::executeOnThread(std::shared_ptr<Command>)
#3  0x00007f62692cbd19 Server::~Server()
#4  0x00007f62692cbe0c Server::~Server()
#5  0x00007f62692d5d2b Java_net_rubygrapefruit_platform_internal_jni_AbstractFileEventFunctions_00024NativeFileWatcher_stop
#6  0x00007f62f4122970

TID 9706:
#0  0x00007f6312af151d read
#1  0x00007f62692cc0fd Server::handleEvents()
#2  0x00007f62692cc000 Server::processQueues(int)
#3  0x00007f62692cbe96 Server::runLoop(JNIEnv_*, std::function<void (std::__exception_ptr::exception_ptr)>)
#4  0x00007f62692d4848 AbstractServer::run()
#5  0x00007f62692dcc71 void std::_Mem_fn_base<void (AbstractServer::*)(), true>::operator()<, void>(AbstractServer*) const
#6  0x00007f62692dcc05 void std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)>::_M_invoke<0ul>(std::_Index_tuple<0ul>)
#7  0x00007f62692dcb0c std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)>::operator()()
#8  0x00007f62692dca9c std::thread::_Impl<std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)> >::_M_run()
#9  0x00007f6268fc8c80
#10 0x00007f6312ae86ba start_thread
#11 0x00007f631240941d __clone

so it looks like the native thread is trying to read an event from an empty queue while the stop is waiting for the terminate command to finish.

Attaching gdb gives me even line numbers:
> gdb
attach <PID>
thread apply <thread number> bt
# OR
thread apply all bt

This gives:
Thread 35 (Thread 0x7f0cc5895700 (LWP 14458)):
#0  0x00007f0d7b3a451d in read () at ../sysdeps/unix/syscall-template.S:84
#1  0x00007f0cc5e680fd in Server::handleEvents (this=0x7f0ce4ccfff0) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:139
#2  0x00007f0cc5e68000 in Server::processQueues (this=0x7f0ce4ccfff0, timeout=2147483647) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:128
#3  0x00007f0cc5e67e96 in Server::runLoop(JNIEnv_*, std::function<void (std::__exception_ptr::exception_ptr)>) (this=0x7f0ce4ccfff0, notifyStarted=...)
    at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:104
#4  0x00007f0cc5e70848 in AbstractServer::run (this=0x7f0ce4ccfff0) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/generic_fsnotifier.cpp:130
#5  0x00007f0cc5e78c71 in std::_Mem_fn_base<void (AbstractServer::*)(), true>::operator()<, void>(AbstractServer*) const (this=0x7f0ce4cd0470, __object=0x7f0ce4ccfff0) at /usr/include/c++/5/functional:600
#6  0x00007f0cc5e78c05 in std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)>::_M_invoke<0ul>(std::_Index_tuple<0ul>) (this=0x7f0ce4cd0468) at /usr/include/c++/5/functional:1531
#7  0x00007f0cc5e78b0c in std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)>::operator()() (this=0x7f0ce4cd0468) at /usr/include/c++/5/functional:1520
#8  0x00007f0cc5e78a9c in std::thread::_Impl<std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)> >::_M_run() (this=0x7f0ce4cd0450) at /usr/include/c++/5/thread:115
#9  0x00007f0cc5b64c80 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#10 0x00007f0d7b39b6ba in start_thread (arg=0x7f0cc5895700) at pthread_create.c:333
#11 0x00007f0d7acbc41d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

Thread 27 (Thread 0x7f0d44e20700 (LWP 14099)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
#1  0x00007f0cc5b5f91c in std::condition_variable::wait(std::unique_lock<std::mutex>&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#2  0x00007f0cc5e70953 in AbstractServer::executeOnThread (this=0x7f0ce4ccfff0, command=std::shared_ptr (count 2, weak 0) 0x7f0ce4cf55d0)
    at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/generic_fsnotifier.cpp:139
#3  0x00007f0cc5e67d19 in Server::~Server (this=0x7f0ce4ccfff0, __in_chrg=<optimized out>) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:91
#4  0x00007f0cc5e67e0c in Server::~Server (this=0x7f0ce4ccfff0, __in_chrg=<optimized out>) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:96
#5  0x00007f0cc5e71d2b in Java_net_rubygrapefruit_platform_internal_jni_AbstractFileEventFunctions_00024NativeFileWatcher_stop (env=0x7f0ce800c340, javaServer=0x7f0d44e1d058)
    at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/generic_fsnotifier.cpp:310
#6  0x00007f0d5c966970 in ?? ()
#7  0x00007f0cc612a4e8 in ?? ()
#8  0x00007f0d5c966676 in ?? ()
#9  0x00007f0d44e1cff0 in ?? ()
#10 0x00007f0cc612a578 in ?? ()
#11 0x00007f0d44e1d060 in ?? ()
#12 0x00007f0cc612a850 in ?? ()
#13 0x0000000000000000 in ?? ()

It shouldn’t hang on read()... We only call read() when poll() has already told us there is something to read in the first place, so the read() should not block as per definition.

Looks like I can even print the local variables:
Thread 35 (Thread 0x7f0cc5895700 (LWP 14458)):
#0  0x00007f0d7b3a451d in read () at ../sysdeps/unix/syscall-template.S:84
No locals.
#1  0x00007f0cc5e680fd in Server::handleEvents (this=0x7f0ce4ccfff0) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:139
        buffer = "\001\000\000\000\002\000\000\000\000\000\000\000\020\000\000\000output.txt", '\000' <repeats 14 times>, "\310\347\337x\r\177\000\000@\253\000\230\f\177\000\000B", '\000' <repeats 16 times>, "c\233\\\r\177\000\000\320-\211\305\f\177\000\000\247\341\337x\r\177\000\000\200\062\211\305\f\177\000\000\204\062\211\305\f\177\000\000\062\000\000\000\000\000\000\000\000.\211\305\f\177\000\000\n\r\211\305\f\177\000\000\311D:{\r\177\000\000\000\000\000\000\000\000\000\000\310\347\337x\r\177\000\000@\253\000\230\f\177\000\000B", '\000' <repeats 16 times><EMAIL_ADDRESS>        bytesRead = 32
        env = 0x7f0c9800ab40
#2  0x00007f0cc5e68000 in Server::processQueues (this=0x7f0ce4ccfff0, timeout=2147483647) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:128
        fds = {{fd = 199, events = 1, revents = 1}, {fd = 198, events = 1, revents = 1}}
        ret = 2
#3  0x00007f0cc5e67e96 in Server::runLoop(JNIEnv_*, std::function<void (std::__exception_ptr::exception_ptr)>) (this=0x7f0ce4ccfff0, notifyStarted=...)
    at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:104
        forever =<PHONE_NUMBER>
#4  0x00007f0cc5e70848 in AbstractServer::run (this=0x7f0ce4ccfff0) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/generic_fsnotifier.cpp:130
        jniThread = {jvm = 0x7f0d7ab2bfc0 <main_vm>}
        env = 0x7f0c9800ab40
#5  0x00007f0cc5e78c71 in std::_Mem_fn_base<void (AbstractServer::*)(), true>::operator()<, void>(AbstractServer*) const (this=0x7f0ce4cd0470, __object=0x7f0ce4ccfff0) at /usr/include/c++/5/functional:600
No locals.
#6  0x00007f0cc5e78c05 in std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)>::_M_invoke<0ul>(std::_Index_tuple<0ul>) (this=0x7f0ce4cd0468) at /usr/include/c++/5/functional:1531
No locals.
#7  0x00007f0cc5e78b0c in std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)>::operator()() (this=0x7f0ce4cd0468) at /usr/include/c++/5/functional:1520
No locals.
#8  0x00007f0cc5e78a9c in std::thread::_Impl<std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)> >::_M_run() (this=0x7f0ce4cd0450) at /usr/include/c++/5/thread:115
No locals.
#9  0x00007f0cc5b64c80 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
No symbol table info available.
#10 0x00007f0d7b39b6ba in start_thread (arg=0x7f0cc5895700) at pthread_create.c:333
        __res = <optimized out>
        pd = 0x7f0cc5895700
        now = <optimized out>
        unwind_buf = {cancel_jmp_buf = {{jmp_buf = {139692830447360, -8227208933030604064, 0,<PHONE_NUMBER>50447,<PHONE_NUMBER>48064,<PHONE_NUMBER>98368,<PHONE_NUMBER>074920672,<PHONE_NUMBER>397209312}, mask_was_saved = 0}},
          priv = {pad = {0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0, canceltype = 0}}}
        not_first_call = <optimized out>
        pagesize_m1 = <optimized out>
        sp = <optimized out>
        freesize = <optimized out>
        __PRETTY_FUNCTION__ = "start_thread"
#11 0x00007f0d7acbc41d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
No locals.

Thread 27 (Thread 0x7f0d44e20700 (LWP 14099)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
No locals.
#1  0x00007f0cc5b5f91c in std::condition_variable::wait(std::unique_lock<std::mutex>&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
No symbol table info available.
#2  0x00007f0cc5e70953 in AbstractServer::executeOnThread (this=0x7f0ce4ccfff0, command=std::shared_ptr (count 2, weak 0) 0x7f0ce4cf55d0)
    at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/generic_fsnotifier.cpp:139
        lock = {_M_device = 0x7f0ce4cd0060, _M_owns = true}
#3  0x00007f0cc5e67d19 in Server::~Server (this=0x7f0ce4ccfff0, __in_chrg=<optimized out>) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:91
        paths = {<std::__cxx11::_List_base<std::__cxx11::basic_string<char16_t, std::char_traits<char16_t>, std::allocator<char16_t> >, std::allocator<std::__cxx11::basic_string<char16_t, std::char_traits<char16_t>, std::allocator<char16_t> > > >> = {
            _M_impl = {<std::allocator<std::_List_node<std::__cxx11::basic_string<char16_t, std::char_traits<char16_t>, std::allocator<char16_t> > > >> = {<__gnu_cxx::new_allocator<std::_List_node<std::__cxx11::basic_string<char16_t, std::char_traits<char16_t>, std::allocator<char16_t> > > >> = {<No data fields>}, <No data fields>}, _M_node = {<std::__detail::_List_node_base> = {_M_next = 0x7f0ce4cfaad0,
                  _M_prev = 0x7f0ce4cfaad0}, _M_data = 1}}}, <No data fields>}
#4  0x00007f0cc5e67e0c in Server::~Server (this=0x7f0ce4ccfff0, __in_chrg=<optimized out>) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:96
No locals.
#5  0x00007f0cc5e71d2b in Java_net_rubygrapefruit_platform_internal_jni_AbstractFileEventFunctions_00024NativeFileWatcher_stop (env=0x7f0ce800c340, javaServer=0x7f0d44e1d058)
    at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/generic_fsnotifier.cpp:310
        server = 0x7f0ce4ccfff0

And for the other hanging daemon:
Thread 36 (Thread 0x7f6268cf9700 (LWP 9706)):
#0  0x00007f6312af151d in read () at ../sysdeps/unix/syscall-template.S:84
No locals.
#1  0x00007f62692cc0fd in Server::handleEvents (this=0x7f62747ae680) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:139
        buffer = "\001\000\000\000\002\000\000\000\000\000\000\000\020\000\000\000output.txt\000\000\000\000\000\000\062\000\000\000\000\000\000\000\260m\317hb\177\000\000Registered /home/wolf/gradle/subprojects/logging/build/tmp/test files/RichConsoleLoggingHooksFunctionalTest/listener_added_to_t...log_level/dals1FileEve"...
        bytesRead = 32
        env = 0x7f622c061b40
#2  0x00007f62692cc000 in Server::processQueues (this=0x7f62747ae680, timeout=2147483647) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:128
        fds = {{fd = 195, events = 1, revents = 1}, {fd = 194, events = 1, revents = 1}}
        ret = 2
#3  0x00007f62692cbe96 in Server::runLoop(JNIEnv_*, std::function<void (std::__exception_ptr::exception_ptr)>) (this=0x7f62747ae680, notifyStarted=...)
    at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:104
        forever =<PHONE_NUMBER>
#4  0x00007f62692d4848 in AbstractServer::run (this=0x7f62747ae680) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/generic_fsnotifier.cpp:130
        jniThread = {jvm = 0x7f6312278fc0 <main_vm>}
        env = 0x7f622c061b40
#5  0x00007f62692dcc71 in std::_Mem_fn_base<void (AbstractServer::*)(), true>::operator()<, void>(AbstractServer*) const (this=0x7f62747adde0, __object=0x7f62747ae680) at /usr/include/c++/5/functional:600
No locals.
#6  0x00007f62692dcc05 in std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)>::_M_invoke<0ul>(std::_Index_tuple<0ul>) (this=0x7f62747addd8) at /usr/include/c++/5/functional:1531
No locals.
#7  0x00007f62692dcb0c in std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)>::operator()() (this=0x7f62747addd8) at /usr/include/c++/5/functional:1520
No locals.
#8  0x00007f62692dca9c in std::thread::_Impl<std::_Bind_simple<std::_Mem_fn<void (AbstractServer::*)()> (AbstractServer*)> >::_M_run() (this=0x7f62747addc0) at /usr/include/c++/5/thread:115
No locals.
#9  0x00007f6268fc8c80 in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
No symbol table info available.
#10 0x00007f6312ae86ba in start_thread (arg=0x7f6268cf9700) at pthread_create.c:333
        __res = <optimized out>
        pd = 0x7f6268cf9700
        now = <optimized out>
        unwind_buf = {cancel_jmp_buf = {{jmp_buf = {140060641957632,<PHONE_NUMBER>549020985, 0,<PHONE_NUMBER>19215,<PHONE_NUMBER>58336,<PHONE_NUMBER>73088, -7135865521045375687, -7135209379126840007}, mask_was_saved = 0}},
          priv = {pad = {0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0, canceltype = 0}}}
        not_first_call = <optimized out>
        pagesize_m1 = <optimized out>
        sp = <optimized out>
        freesize = <optimized out>
        __PRETTY_FUNCTION__ = "start_thread"
#11 0x00007f631240941d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
No locals.

Thread 27 (Thread 0x7f62e0698700 (LWP 9489)):
#0  pthread_cond_wait@@GLIBC_2.3.2 () at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
No locals.
#1  0x00007f6268fc391c in std::condition_variable::wait(std::unique_lock<std::mutex>&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
No symbol table info available.
#2  0x00007f62692d4953 in AbstractServer::executeOnThread (this=0x7f62747ae680, command=std::shared_ptr (count 2, weak 0) 0x7f62747e8100)
    at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/generic_fsnotifier.cpp:139
        lock = {_M_device = 0x7f62747ae6f0, _M_owns = true}
#3  0x00007f62692cbd19 in Server::~Server (this=0x7f62747ae680, __in_chrg=<optimized out>) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:91
        paths = {<std::__cxx11::_List_base<std::__cxx11::basic_string<char16_t, std::char_traits<char16_t>, std::allocator<char16_t> >, std::allocator<std::__cxx11::basic_string<char16_t, std::char_traits<char16_t>, std::allocator<char16_t> > > >> = {
            _M_impl = {<std::allocator<std::_List_node<std::__cxx11::basic_string<char16_t, std::char_traits<char16_t>, std::allocator<char16_t> > > >> = {<__gnu_cxx::new_allocator<std::_List_node<std::__cxx11::basic_string<char16_t, std::char_traits<char16_t>, std::allocator<char16_t> > > >> = {<No data fields>}, <No data fields>}, _M_node = {<std::__detail::_List_node_base> = {_M_next = 0x7f6274c30f10,
                  _M_prev = 0x7f6274c30f10}, _M_data = 1}}}, <No data fields>}
#4  0x00007f62692cbe0c in Server::~Server (this=0x7f62747ae680, __in_chrg=<optimized out>) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:96
No locals.
#5  0x00007f62692d5d2b in Java_net_rubygrapefruit_platform_internal_jni_AbstractFileEventFunctions_00024NativeFileWatcher_stop (env=0x7f628800c340, javaServer=0x7f62e0695058)
    at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/generic_fsnotifier.cpp:310
        server = 0x7f62747ae680

The test itself (AbstractLoggingHooksFunctionalTest.listener added to task receives logging for log level) only watches the project root:
2020-03-10T11:29:46.166+0100 [WARN] [org.gradle.internal.vfs.impl.WatchingVirtualFileSystem] Virtual file system retains information about 0 files, 0 directories and 0 missing files till next build
2020-03-10T11:29:46.169+0100 [WARN] [org.gradle.internal.vfs.LinuxFileWatcherRegistry] Watching 1 directories to track changes between builds
2020-03-10T11:29:46.173+0100 [INFO] [net.rubygrapefruit.platform.internal.jni.AbstractFileEventFunctions] Initialized logging to level 0

2020-03-10T11:29:46.174+0100 [DEBUG] [net.rubygrapefruit.platform.internal.jni.AbstractFileEventFunctions] Starting thread
2020-03-10T11:29:46.174+0100 [DEBUG] [net.rubygrapefruit.platform.internal.jni.AbstractFileEventFunctions] Started thread
2020-03-10T11:29:46.176+0100 [DEBUG] [net.rubygrapefruit.platform.internal.jni.AbstractFileEventFunctions] Registered /home/wolf/gradle/subprojects/logging/build/tmp/test files/AutoConsoleLoggingHooksFunctionalTest/listener_added_to_t...log_level/cq8x6
2020-03-10T11:29:46.176+0100 [WARN] [org.gradle.internal.vfs.impl.WatchingVirtualFileSystem] Spent 10 ms registering watches for file system events

Then, the test switches the log level to info and runs a second build, producing a file output.txt in the project root directory in a build finished hook: https://github.com/gradle/gradle/blob/612c5d344c684d7e413433ec8aaa2a669c06f9f3/subprojects/logging/src/integTest/groovy/org/gradle/internal/logging/console/taskgrouping/AbstractLoggingHooksFunctionalTest.groovy#L144-L146
Maybe that event comes in just when the notify is closed?

Thread #27 is just waiting for the background thread to shut down, everything around that looks normal. Looking at the actual background thread it doesn't make sense:
Thread 35 (Thread 0x7f0cc5895700 (LWP 14458)):
#0  0x00007f0d7b3a451d in read () at ../sysdeps/unix/syscall-template.S:84
No locals.
#1  0x00007f0cc5e680fd in Server::handleEvents (this=0x7f0ce4ccfff0) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:139
        buffer = "\001\000\000\000\002\000\000\000\000\000\000\000\020\000\000\000output.txt", '\000' <repeats 14 times>, "\310\347\337x\r\177\000\000@\253\000\230\f\177\000\000B", '\000' <repeats 16 times>, "c\233\\\r\177\000\000\320-\211\305\f\177\000\000\247\341\337x\r\177\000\000\200\062\211\305\f\177\000\000\204\062\211\305\f\177\000\000\062\000\000\000\000\000\000\000\000.\211\305\f\177\000\000\n\r\211\305\f\177\000\000\311D:{\r\177\000\000\000\000\000\000\000\000\000\000\310\347\337x\r\177\000\000@\253\000\230\f\177\000\000B", '\000' <repeats 16 times><EMAIL_ADDRESS>        bytesRead = 32
        env = 0x7f0c9800ab40
#2  0x00007f0cc5e68000 in Server::processQueues (this=0x7f0ce4ccfff0, timeout=2147483647) at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:128
        fds = {{fd = 199, events = 1, revents = 1}, {fd = 198, events = 1, revents = 1}}
        ret = 2
#3  0x00007f0cc5e67e96 in Server::runLoop(JNIEnv_*, std::function<void (std::__exception_ptr::exception_ptr)>) (this=0x7f0ce4ccfff0, notifyStarted=...)
    at /home/tcagent1/agent/work/419e0e7240c3cf05/src/file-events/cpp/linux_fsnotifier.cpp:104
        forever =<PHONE_NUMBER>
...

What it says is that we already have bytesRead set to 32, and buffer seems to contain some actual data, however that should only happen after read() has returned. Maybe this is data retained from a previous run of the method?


How can I store decimal in a MongoDB document?

Marshaler

Unmarshaler

Dear @trungdlp-wolffun,
Regarding saving decimal numbers in MongoDB:  With the old version (v1) of the MongoDB Go driver, we would have needed to use the bsontype package.  However, the new version (v2) has changed how it works. ValueMarshaler and ValueUnmarshaler don't require bsontype now. You can see the details here:
https://pkg.go.dev/go.mongodb.org/mongo-driver/v2/bson#ValueMarshaler
https://pkg.go.dev/go.mongodb.org/mongo-driver/v2/bson#ValueUnmarshaler
I will implement the v2 interfaces and test them thoroughly. If all tests pass, this feature will be included in version v0.1.35.

Thanks a lot @eapenkin 🎉


Adding an initial GitHub PR template.

Providing an initial PR template to provide guidance for those submitting contributions.

+1 to @jdye64 's comment.

Totally missed the snark on this thread.  I can't meet the requirements of a non-existent PR if they aren't there yet. ;)


Uncaught (in promise) ReferenceError: mapboxgl is not defined

Version
2.9.2
Reproduction link
https://delibe.staging.letsgocity.be/commune/54/conseil/1843/point/11741
Steps to reproduce
my nuxt.config.js
  build: {
    publicPath: `/${require('./secrets.json').NODE_ENV}/_nuxt/`, // <= add the path to the cached files
    plugins: [
      new webpack.ProvidePlugin({
        mapboxgl: 'mapbox-gl'
      })
    ],
    extend (config, ctx) {
      config.node = {
        fs: 'empty'
      }
    },
  },

What is expected ?
use mapboxgl in my project
What is actually happening?
mapboxgl is undefined

This bug report is available on Nuxt community (#c9789)

Hi @MSkred
I don't see any error in your reproduction link 🤔

Please provide a minimal reproduction with CodeSandbox or an accessible GH repo.


Readme style fix

Just some consistency stuff, all code is now 4 spaced.

You had me at "whitespace only Pull Request"


Cargo audit advisory: migrate net2 to socket2 crate

I get this cargo audit problem when I include yup-hyper-mock:
$ cargo audit --deny warnings
Crate:         net2
Version:       0.2.37
Warning:       unmaintained
Title:         `net2` crate has been deprecated; use `socket2` instead
Date:          2020-05-01
ID:            RUSTSEC-2020-0016
URL:           https://rustsec.org/advisories/RUSTSEC-2020-0016
Dependency tree:
net2 0.2.37
├── miow 0.2.2
│   └── mio 0.6.23
└── mio 0.6.23

https://crates.io/crates/cargo-audit
~Is there any interest in migrating to the socket2 crate ?~
Edit: guessing that updating the mio dependency would eliminate this.

Thanks for letting me know! Is this something you could try?
Any help is appreciated. Thank you.


Does this library support zoom and dragging?

Zooming and panning the map? Yep! MapMe is just about placing markers on the map. All other functions of maps work as usual.


Display a kind of "offline" symbol with numbers of not uploaded values

To show that some of the SVG values are not uploaded to NS, we should add some kind of info like

numbers of not uploaded SVG
display them in blue? in graph
add a menu item for "resync" NS by reading /api/v1/entries/current.json and uploading the missing newer than the timestamp.

See https://www.facebook.com/groups/NightscoutForMedtronic/?multi_permalinks=1662591743752133&notif_t=group_highlights&notif_id=1501756240772559

It already sends to NS when it comes back online automatically.
It could do with having some feedback about the availability of NS though and why it's failing.

I was getting some weirdness today while working with NS where the upload to NS would just stop and nothing else would get uploaded poll after poll. Looks like all exceptions are being trapped inside the upload intent so any bad data in a record like a null will stop uploads until the record is aged out after 24 hours.

I've exposed errors to the user log for uploading to NS. This way we can see when there are problems or if it's a user config error.


Improve the images

Currently the screenshots look bad under dark theme

What are you specific issues with the current pics? I think they look fairly similar in light mode although small & pixellated

Jaeger screenshots have a dark top bar -> no contrast to the background. However, for me, this is still fine, because the text is clearly visible.
One possible improvement to make the screenshots look better would be to remove borders from the screenshot tables.


Growthrate

Created tracking functions (functions that "track" cells "over time" for our synthetic lineages). Gives us the data that we need to calculate growth rate.
This is 50 lineages for 240 hours. Function runs quick, granted how inefficient the actual code is (multiple nested for loop passes over lineages).

Hello @shak360! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file lineage/Analyze.py:

Line 115:80: E501 line too long (95 > 79 characters)
Line 122:80: E501 line too long (87 > 79 characters)
Line 123:80: E501 line too long (113 > 79 characters)
Line 126:80: E501 line too long (91 > 79 characters)

In the file lineage/LineageTree.py:

Line 26:80: E501 line too long (121 > 79 characters)

In the file lineage/StateDistribution.py:

Line 137:80: E501 line too long (80 > 79 characters)
Line 150:80: E501 line too long (105 > 79 characters)

In the file lineage/tests/test_BaumWelch.py:

Line 42:80: E501 line too long (135 > 79 characters)

In the file lineage/tests/test_LineageTree.py:

Line 42:41: W291 trailing whitespace
Line 50:41: W291 trailing whitespace
Line 58:41: W291 trailing whitespace
Line 66:41: W291 trailing whitespace

In the file lineage/tests/test_StateDistribution.py:

Line 41:41: W291 trailing whitespace
Line 49:41: W291 trailing whitespace
Line 57:41: W291 trailing whitespace

In the file lineage/tests/test_tHMM.py:

Line 39:80: E501 line too long (125 > 79 characters)

Pretty sure this PR is good to go Dr. Meyer @aarmey ; I can't seem to parse the current failure though. Something is failing with retrieving the references in the manuscript?

Never mind, rebuilding seems to have fixed it. Should be OK for review and merge.

That plot looks great!


Possible to separate free and members' drop tables as a setting?

I've noticed there was a separate entry for the Ankou for members' world drops and f2p world drops, but there isn't anything like that for most enemies. Is it possible to differentiate whether an item is a members' drop only for every enemy and simply not display it if so?

@jazzyhazzy21
That happens because the plugin parses the wiki and the Ankou page has sections titled "Members' world drops" and "Free-to-play" worlds drops.
The wiki also indicates members items for F2P monster drops with "(m)". Would you want this to be reflected in the plugin?

@donth77 Yeah, that would be great! Simply appending the "(m)" would work fine. Thank you for your help.


xgb.cv which round of prediction=TRUE

Hey,
I'm using R and i used prediction=TRUE with xgb.cv()
However it isn't clear in the documentation on which round are the prediction are done. Basicly, are the predictions returned based:

on the last iteration (which is under or over fitting)
on the best iteration

I wasn't the single one wondering (https://github.com/dmlc/xgboost/issues/92) but i couldn't find any answer.
I investigated directly the code of the function https://github.com/dmlc/xgboost/blob/master/R-package/R/xgb.cv.R but i couldn't manage to have a clear answer by myself.
Therefore I did a local test and discovered that the predictions gave me the result (based on my metric) of the last iteration! Seems to me that this parameter is extremely dangerous to use and misleading. I don't know if it was intended or not (can understand that stocking predictions at each step is quite memory greedy).
Best regards,
Jacques

Yes, there is a bug which causes the predictions to be returned for the last round even when early.stop.round is specified, and I can fix that.
Note, though, that the approach of how the "early stopping" is implemented in xgb.cv is not really a standard CV procedure for a "model with early stopping". It's main practical use, as I see it, is to get a reasonable estimate for the number of iterations by using only a training sample. So, think carefully about whether and how the predictions from it could be used in your situation.

What's the idea in order to solve it?
Keeping the old predictions in memory doesn't seem to be a good idea. Is it possible to train the model on let say 25 iterations, and only use the 15 first iterations of it then make the predictions of the true early stopping?
Yeah i use  "early stopping" implementation in xgb.cv only to determine a good number of total iterations. However keeping the predictions might be useful in order to plot ROC curves or use'em for a metaClassifier. Because training once again the model with the right number of iteration n order to have the corrects predictions is a bit annoying and time consuming.

Wow, same thing happens with xg.train(...) when there is a validation dataset.
I trained my model with a validation dataset. Predicted it and it gave me the result of the last iteration. Same behaviour as xgb.cv. And it is not intuitive at all!
Solving it would be ideal but don't know what was your idea and if it is hard or not. However stating it in the manual would be a good start.

With xgb.train, it's not the "same behaviour as xgb.cv". The xgb.train's result is a model which you would need to use with predict with the needed ntreelimit parameter to obtain the predictions. What's not intuitive about that? It is kind of what xgb.cv was supposed to do for you under the hood for its folds, but it wasn't taking the proper ntreelimit for predictions when early stopping was on. I am close to completing the R-interface refactoring to use callbacks #892 and it will be fixed there.
By the way, if you are using xgb.cv with early stopping for evaluating the model performance, you might be getting overly optimistic results. As I've mentioned before, it's good for estimating the number of iterations parameter, but it wouldn't be a proper performance evaluation, since the folds become somewhat "aware" of each other through the inter-folds optimum search that is used by the early stopping.

I sometimes use xg.train for finding the right hyper-parameters. When the training set is really big, instead of making a 5 folds CV and therfore trainign 5 models at the same time, xg.train + a validation dataset is stable enough.
I meant that it wasn't intuitive that the model returned by xg.train is not the best one, but the one of the last iteration, save about keeping predictions with xgb.cv. It is dangerous if users poorly use XGBOOST, let's say the best iteration is around 50 and early_stopping=500.
I do agree with the fact that using xgb.cv for evaluating the model performance is a bit overly optimistic. However it seems to me to be "the less worst ideas" for finding hyper-parameters.
I wasn't aware about https://github.com/dmlc/xgboost/issues/892 , my bad. All my respects to you, your work is greatly appreciated.

Will prediction=TRUE with xgb.cv() be a python option as well at some point?
I have this working to print out the prediction through a callback but cannot get it to return it as a variable. How do I go about saving it as a variable?


Enhance manifest library interface for installation and uninstallation of charts

Current interface sample:
manifest.InstallInfo{
		Ctx: ctx,
		ChartInfo: &manifest.ChartInfo{
			ChartPath:   chartPath,
			ReleaseName: releaseName,
		},
		RemoteInfo: custom.RemoteInfo{
			// destination cluster rest config
			RemoteConfig: r.config,
			// destination cluster rest client
			RemoteClient: &r.nativeClient,
		},
		ResourceInfo: manifest.ResourceInfo{
			// base operator resource to be passed for custom checks
			BaseResource: unstructuredObj,
		},
		CheckFn: func(context.Context, *unstructured.Unstructured, *logr.Logger, custom.RemoteInfo) (bool, error) {
			// your custom logic here to set ready state
			return true, nil
		},
		CheckReadyStates: true,
	}, nil

AC:

[ ] Remove passed context
[ ] Remove occurrence of Remote, since the module-manager could also be used for local cluster installations
[ ] CheckFn should default to empty function returning true
[ ] Add a property to indicate if the installation / uninstallation should be processed in local / remote cluster
[ ] As a follow-up, update usage in runtime-watcher, template-operator and module-manager pkg/declarative accordingly

As part of the PR below, local installation of manifest resources are supported. The .spec.remote field needs to be explicitly set to false to install locally. The .spec.remote field defaults to true is unspecified.
https://github.com/kyma-project/module-manager/pull/89
// Remote indicates if Manifest should be installed on a remote cluster
// +kubebuilder:validation:Optional
// +kubebuilder:default:=true
Remote bool `json:"remote"`


Sign in Screen: Fix UI in smaller screens

I think it's time for my first contribution. Since I started playing around with the code and storyboards, I observed the the UI in Sign in screen (especially in smaller screens like a 4s looks a bit weird). This PR adresses exactly that.

Before
After

I have one more question related to storyboards.. When I got into the Settings.storyboard I saw this settings button, and I'm not sure what's the purpose of it? If it's not in use anymore I can remove it as well in this  PR.

@agisilaos The Badge unread toggle and label is being used. If you've disabled notifications for the app it will display the "Settings" label and take you there. If it's not disabled the toggle will appear.
Congratulations on your first PR! 🎉 🎊

Thank you for the info @viktorgardart! 😍 Ah makes total sense. So no need to remove it.

Btw, sorry for not mention it in my initial PR description but this PR is ready for review 🎉

Quick question, the 4s can't install iOS 11 right? What's the lowest-end form factor that can install iOS 11, it's the 5 right?
Still fine merging this tho 😄
@agisilaos mind posting screenshots of:

iPhone 5, 6, plus, and X form factors?
iPad?

Just to be safe 😇

Quick question, the 4s can't install iOS 11 right? What's the lowest-end form factor that can install iOS 11, it's the 5 right?

Yes and yes. Whoah I didn't know that iOS 11 was the only supported OS

@agisilaos mind posting screenshots of:

iPhone 5, 6, plus, and X form factors?
iPad?
Just to be safe 😇

Will do that tonight @rnystrom 👍 💯

@rnystrom Here we go:

iPhone SE
iPhone 8
iPhone X
iPhone 8 Plus

And the iPad:

Lovely, awesome to see this pull request land @agisilaos!

Awesome job @agisilaos!
For context, when I updated the constraints for this screen last (#481), I omitted the 4S issue since GitHawk was targeting iOS 10+ at the time.


SOS!.. I have a serious problem

When program first run， just first install and run, The Shadow is show purple color，I had set the shadowShow is No. also have a problem with first install and run,I had set the panGestureEnabled is No but the sideMenu still can pan。

I'm sorry about that my English is really poor, I hope you can help reslove this problem. Thank you!

This is my configuration code

Have anybody faced this problem?For Help!


migrate to a different validation library (or remove entirely)

It appears that the payment library has been abandoned (no updates in almost three years), and there have been some changes with things like Visa cards that can have up to 19 characters.  Either the validation library needs to be replaced with something else or removed entirely.
My recommendation would be to remove the built-in validation and just provide some links in the documentation to a few validation libraries along with some demo code on basic usage.  This way the dependency on an outdated library can be removed and make the resulting package smaller.  I don't have a specific validation library in mind so I can't recommend one over another.

@gilbarbara, what do you think? I'm able to help with this.

Hey @cassiocardoso
I don't think this library works without brand identification and formatting (we don't do validation per se since we don't control the form itself).
Keeping all the rules internally would be a nightmare and falls outside the scope of this package.
So I think the initial effort should be to find a new library that handles that. Or fork the payment repo, rewrite it (CoffeeScript 🤮), and keep it updated.

@dlong500
This library has no purpose if it can't identify the brand and format the number/CVC and I'd rather deprecate and archive it.
Payment has support for 19 characters for Visa numbers. What else do you need?

@dlong500 But yeah, Payment is really dead. We'll try to find a replacement.

@gilbarbara Sorry, I didn't realize how much it was being used for credit card type identification.  I was only thinking of the validation part and looking at the unresolved issues/pull requests on the payment library.
Maybe https://github.com/braintree/credit-card-type could potentially be a replacement?  It seems relatively mature and under active development.


Error: error listing Account Roles: Invalid account identifier (9109)

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
Terraform v1.1.9
on darwin_arm64

provider registry.terraform.io/cloudflare/cloudflare v3.26.0

Affected resource(s)
data "cloudflare_account_roles"
data "cloudflare_accounts"
Terraform configuration files
terraform {
  required_version = "~> 1"
  required_providers {
    cloudflare = {
      source  = "cloudflare/cloudflare"
      version = "3.26.0"
    }
  }
}
provider "cloudflare" {
  api_token = var.api_token
}

data "cloudflare_accounts" "company_name" {
  name = "Company Name Inc"
}

data "cloudflare_account_roles" "account_roles" {
  account_id = data.cloudflare_accounts.company_name.id
}

Link to debug output
https://gist.github.com/apotapovax/e89f32e07c835f1608c190317b8d6360
Panic output
No response
Expected output
Terraform would read with API_TOKEN the account_id
and plan would run successfully
Plan: 164 to add, 0 to change, 0 to destroy.
Actual output
Warning: Argument is deprecated
with provider["registry.terraform.io/cloudflare/cloudflare"],
on _provider.tf line 12, in provider "cloudflare":
12: provider "cloudflare" {
Use resource specific account_id attributes instead.
Error: error listing Account Roles: Invalid account identifier (9109)
with data.cloudflare_account_roles.account_roles,
on data.tf line 5, in data "cloudflare_account_roles" "account_roles":
5: data "cloudflare_account_roles" "account_roles" {
Steps to reproduce
terraform {
required_version = "~> 1"
required_providers {
cloudflare = {
source  = "cloudflare/cloudflare"
version = "3.26.0"
}
}
}
provider "cloudflare" {
api_token = var.api_token
}
Additional factoids
Works just fine if you specify the account_id explicitly (as a string) OR if you import resource "cloudflare_account" to the state
References
https://github.com/cloudflare/terraform-provider-cloudflare/issues/1956

Problem solved by changing
data "cloudflare_account_roles" "account_roles" {
  account_id = data.cloudflare_accounts.company_name.id
}

to
data "cloudflare_account_roles" "account_roles" {
  account_id = data.cloudflare_accounts.company_name.accounts[0].id
}


Fixed bug on nested and reverse nested aggregations. None of these ag…

Fixed bug on nested and reverse nested aggregations. None of these aggregations requires the nested aggregations to be added. Test has also been updated.

@ansata2001 can you rebase PR?


New Associate Member Application: RTEMS Project

What is your name?  Amar Takhar
What is your email<EMAIL_ADDRESS>What is your member company?  RTEMS Project
Identify which category their organization falls under:  Non-profit
Link to your website: https://www.rtems.org/
What is your organizational mission statement:  This is rather long and available here: https://docs.rtems.org/branches/master/eng/mission.html
What drives your interest in joining the OpenSSF?  Supply chain security and securing the project to make using RTEMS easier for our users.
What are your organization’s aspirations for contributing to the OpenSSF, and how do you anticipate that your membership will bolster the OpenSSF's growth and support?  RTEMS has been an opensource project for over 34.  As a next step we want to increase our projects security and contribution to overall security in opensource.  We hope to do this by making things easier for our users and RTEMS being an exemplar for projects of our nature contributing to overall security.  We are strong consumers and contributors we are signing up as we believe in the OpenSSFs mission.
Could you summarize your organization’s contributions to OpenSSF?   We are working on our Gold OpenSSF Badge as well as setting up scorecard, SBOMs and software chain of security using OpenSSF projects.
Please include any contributions made to OpenSSF or other OpenSSF projects and open-source projects developed using any OpenSSF dependencies.  As of yet none we have been trying the various OpenSSF projects I'm working on a fix for scorecard and GitLab right now that will be the first one.  We are set on contributing and participating in the OpenSSF and have a strong history of collaborating and contributing to opensource projects we work with.
How many developers do you expect to have contribute to OpenSSF projects in the next 6-12 months? Are there other roles such as researchers, analysts or any other positions that you plan on contributing?  1
How do you currently leverage any OpenSSF resources in your organization?  As of now we are using scorecard.  I am working on fixing this for GitLab and self-hosted GitLab.  We have opened our participation with the OpenSSF badge program with our goal set to retaining a Gold badge.  We are also using the resources available in the BCP for SBOMs and software chain of security.
Do you have signing authority for your entire institution? If no, who does?  Yes
Do you agree to follow the OpenSSF Code of Conduct  Yes
1. Organizational Information/Alignment:
Organizational Mission Alignment:

Does the organization's mission statement align with the goals of OpenSSF, such as promoting open source security, enhancing software supply chain integrity, or contributing to cybersecurity education?

[x] Yes
[ ] No

Non-Profit, Government, or Academic Status:

Is the organization a recognized non-profit, government agency, or academic institution?

[x] Yes
[ ] No

Brand Alignment and Reputation:

Is the organization in good standing within its community and the broader open source ecosystem, with a reputation that aligns with OpenSSF's values and brand?

[x] Yes
[ ] No

2. Commitment to Open Source Security and Contribution:
Commitment to Contribution:

Has the organization demonstrated a clear interest in actively contributing to the OpenSSF community through development, research, or other relevant activities?

[x] Yes
[ ] No

Can the organization commit to contributing a specified minimum number of developers, researchers, analysts, or other professionals to OpenSSF projects within the next 6-12 months?

[ ] Yes
[x] No

Commitment to Open Source Security:

Has the organization previously contributed to OpenSSF or other open-source projects?

[ ] Yes
[x] No

[ ] If not, do they plan on contributing to the OpenSSF?

Does the organization maintain or contribute to open-source projects that use OpenSSF dependencies or tools?

[x] Yes
[ ] No

Commitment to Open Source Security:

Does the organization have a history or a nascent plan to promote, improve, or contribute to open source security beyond its participation in OpenSSF?

[x] Yes
[ ] No

Utilization of OpenSSF Resources:

Does the organization currently leverage OpenSSF resources, tools, or frameworks within its operations or projects?

[x] Yes
[ ] No

Educational and Community Engagement:

Does the organization engage in educational activities, community outreach, or other efforts to spread awareness about open source security?

[ ] Yes
[x] No

3. Compliance and Ethics:
Open Source Licensing and Compliance:

Does the organization adhere to open source licensing standards and demonstrate compliance with open source security best practices?

[x] Yes
[ ] No

No Conflict of Interest:

Can the organization certify that its membership and contributions to OpenSSF will not pose a conflict of interest with the foundation's objectives and policies?

[ ] Yes
[ ] No

I will miss the internal review meeting tomorrow, and am providing feedback via comment:

Can the applicant please fill out the check boxes at the end of the issue?
It sounds like the applicant is starting to adopt the Security Baseline. I'd love to get a commitment from then to get engaged in https://github.com/ossf/security-baseline to provide an associate member experience/feedback, especially a project that was developed outside of the LF umbrella.

Generally, with these two items addressed, I am supportive.
Thanks RTEMS!

Approved.


Some SVGs are visually incorrect

Hi everyone,
As part of a redesign process, I have noticed that some SVGs in the app look really bad:

nutriscore-not-applicable.svg

nutriscore-unknown.svg

nature-et-progres.svg

haute-valeur-environementale.svg

ecoscore-not-applicable.svg

bleu-blanc-coeur.svg

ab-agriculture-biologique.svg

@g123k Those are local cache versions.
They are optimized because

they are temporary icons while their server counterparts are being downloaded, and displaying "simplified" icons is much faster
they are not supposed to be displayed big
at the time, we displayed tons of SVGs in the same screen, and processing all those SVGs slowed a lot the display.

Feel free to replace the local cache versions with the pixel perfect server versions.


Add to UX in the “main window” the HT URL/User/Expiration information

The HyperThought server URL, Project and Directory Path are now in the UI. Having a countdown to when the token expires would be great.

see #10 for the timer refresh


Create genre class

Create Genre class #3
Project Requirement

Create a Genre class with an association to the Item class (in a separate .rb file).
All Genre class properties visible in the diagram are defined and set up in the constructor method.

General requirements

There are no linter errors.
Used correct Gitflow.
Documented work in a professional way.
Follow list of best practices for Ruby.

Projec Approved.
Congrats!! 🎉🎉
It's time to merge it!


Translate content/pt/docs/concepts/cluster-administration/logging.md into Portugues

Translated documentation referent logs
Copied examples files used in the doc

/approved

I'll review the PR later today.

/lgtm

/approve


Adding An "All" Button to the classList()

Hey, everyone!
I've implemented the code from our second Javascript exercise here, (if you scroll down) you can toggle the different lines sung by each member. Thinking on it, I realized I really wanted to put in an "All" button, which would toggle every member's lines all at once.
But, I've been having trouble actually writing the code to get this to work. I have... something kind of close, but it's rather broken. I added this to the JS:
            case "Alltoggle": {
      for (e=0; e < AllLines.length; e++)
      {AllLines[e].classList.toggle("on")}
             for (var checkbox of checkboxes) {
       checkbox.checked = this.checked;}
       var e;
       };
      break;

If you click the All button in its current state, it applies the "on" class to every song_line and checks each box (which won't happen without that checkbox part of the code), which is good! But... if you happen to toggle off the some of the other boxes while the All box is still toggled, and then toggle the All box off those other boxes will turn on again! It's hard to explain, but basically this code is only really functional if just the All box is used, and no other box is touched at all. That'd be very confusing for users, right?
This isn't a super pressing issue, but I'd really like to get it working. This song has 13 different people on the track, and clicking all 13 buttons just to see every lines seems a bit ridiculous!
If anyone has any advice, I'd greatly appreciate it!

@PiperBaron We'll need to see the code that you're selecting with your AllLines variable. My guess is that there's a mismatch in collecting them all. The classList() toggle needs to add the class of "on" to all the lines, and then remove them all when you toggle it off...Let's take a look at all the code for this if you can send us to your HTML file and the JS file?

@PiperBaron I just realized something about this issue. After you have toggled ALL to be on, you  need to remove "on" before you can isolate just one to turn on. So you need to toggle OFF before you can toggle the individuals on, right?

@ebeshero
I pushed the new All-button-version of the files to both the GitHub and Newtfire web-space: here's the new version of the page. The HTML file is here and the JS file here.
Ideally, the All button would "turn on" every other box in such a way that the user could un-toggle the other boxes with no issue. For example, in the BTS song, the user would be able to click "All," then un-toggle the "Non-Member" button so they could see only the lines sung by the 7 BTS members, without the whole thing getting messed up like it is now.
I'm not really sure how to do that, so we can settle on toggling off everything before the user can toggle on the individuals.

@PiperBaron I thought my reply posted yesterday, but I see it didn't! Yikes. Okay. Looking at your code for the HTML, CSS, and JS was definitely helpful. Here's the issue: You're juggling some layers of classes here, right? The All is working with one value only, and it's adding "on" to your series of @class values on the basis of just one value.
Suppose we remove the "on" value by toggling one of the vocalists on the list, but we keep "All" selected. JavaScript's logic will remove the "on" value for that one vocalist. Then if we toggle "All" again, there's an interesting effect! we remove highlighting from everyone other than the vocalist we selected, and that vocalist gets togged "on" so it's the only one showing (even though we'd de-selected that one from the list earlier!
What this means is the "switchboard" is overly complicated. It's complicated for a lot of reasons, not just for the toggling. You have lots of song files you've marked, each with a distinct array of vocalists to output with distinct styling. I'm not sure you want to be "hard-coding" so many very different JS files. Is there a simpler way you can manage this?
This is what occurs to me based on your posting here. What if you:

output all the diverse styling (and CSS) for the individual vocalists because you can (if you wish to be able to illuminate this data in the HTML and find it interesting and useful).
Write one JS file that will work over all of the song files, regardless of which group / vocalists are performing. That might mean just toggling the color display for  "Members" vs. "Nonmembers"(?) Or try organizing your vocalists into larger categories that can help illuminate a collection of them at once?
You may have other ideas here!

We could take this further, if you still want the capacity to click on each and every vocalist's name in a fieldset and see their portions of the song lyrics: What we'd want to do is collect a JavaScript array, and we can study up on how to do this--so JS collects all the values of a set of elements in your HTML document, and responds to the array in a function...But you're still giving your visitors lots of complex options to choose from, when maybe it's sufficient to share a legend of color codes, and select the highlights to be visible in groups. What do you think?


Installer

This might be a stretch, but InnoSetup can install dependencies automatically (powershell). Then we could have shortcuts, too.

[x] Deploy ps1 and other files
[x] add shortcuts for RH, RH config editor
[x] make x64-only
[x] download and install PS -> bundle instead
[x] handle updates, uninstall previous version, if any
[x] change shortcut to start pwsh with ps1 param
[x] change icon
[x] show license, ask for accept
[x] create roaming, local appdata folders
[x] start miners in local
[x] change script to use roaming folder for config, local folder for miners etc
[x] change config generator to load json from/to roaming folder by default

Then script is under program files, config is under appdata.
Links to rudehash and config generator.
Start in must be figured out, some miners place files in working dir, e.g. Firmware.bin

Installer could also set execution policy.

Miners should download to localappdata, same goes for temp. Maybe that should be starting dir too.

Gotta add a shortcut for emptying localappdata folder.

Since installer installs fixed version of ps, it's easy to create shortcuts.

File's Id cannot contain dashes, because reasons.

Advertised shortcut cannot use Arguments, because reasons.

Non-advertised shortcut cannot be system-wide (or something), because reasons.

You always gotta add the <Directory Id="TARGETDIR" Name="SourceDir"> magic line to every MSI installer, because reasons!

You're encouraged to make every FRIGGIN file a separate component, but if you're installing them per-user, they EACH need to have their own registry key added, because a per-user file cannot be keypath, because reasons!!

Components cannot have dirs in them, because reasons!

Target needs to be a FULL path, even if the target binary is IN path, so you gotta hardcode powershell executable's version number, and break your own shortcuts whenever the user updates PowerShell, because REASONS!!!!!

 I tell you why!

Well duh. Need an option on finish page to open config editor.

Finish Page Nsis2Io Error
MUI2.nsi
Advanced Welcome/Finish Example Script