Introduce initial version of CODEOWNERS

@blanquicet @blixtra @eiffel-fl @burak-ok @claudiamarcubina @flyth @mqasimsarfraz please feel free to suggest areas you're interested in being code owners.

I wouldn't mind taking/sharing these:
/cmd/common/registry.go @flyth
/pkg/columns/ @flyth
/pkg/gadget-context/ @flyth
/pkg/gadget-registry/ @flyth
/pkg/gadget-service/ @flyth
/pkg/params/ @flyth
/pkg/operators/operators.go @flyth
/pkg/runtime/ @flyth

I would like to suggest myself for:
/.github/ @mqasimsarfraz
/Dockerfiles/ @mqasimsarfraz
/charts/ @mqasimsarfraz
/integration/ @mqasimsarfraz
/pkg/container-collection/ @mqasimsarfraz
/pkg/container-utils/ @mqasimsarfraz
/tools/ @mqasimsarfraz

/pkg/container-utils/containerd/ @burak-ok
/pkg/operators/kubeipresolver/ @burak-ok
/pkg/operators/kubenameresolver/ @burak-ok
/pkg/gadgets/run/ @burak-ok

Not so sure about scope, ...
/integration/ @burak-ok
/gadgets/ @burak-ok

Not so sure about scope, ...
/integration/ @burak-ok
/gadgets/ @burak-ok

I'm not sure I follow. What do you mean?

Not so sure about scope, ...
/integration/ @burak-ok
/gadgets/ @burak-ok

I'm not sure I follow. What do you mean?

I am not sure if I should be a codeowner for the whole integration subdirectory or not.
Or the gadgets subdirectory

I'm interested in these:
cmd/ig/
integration/
pkg/container-collection/
pkg/container-utils/
pkg/gadgets/internal/networktracer/
pkg/gadgets/profile/tcprtt/
pkg/gadgets/snapshot/socket/
pkg/gadgets/trace/dns
pkg/gadgets/trace/network
pkg/gadgets/trace/sni
pkg/histogram/
pkg/ig-manager/
pkg/types/

Please let me know if you think I missed something I could take 🙂.

I am not sure if I should be a codeowner for the whole integration subdirectory or not.
Or the gadgets subdirectory

It's totally up to you. For integration we already have @blanquicet and @mqasimsarfraz, for the whole gadgets sub-directory I didn't put anybody. (that'd default to me and Alban). Perhaps it's better if there is any specific gadget you want to own.

ok folks, thanks a lot. I think we have a very good "coverage" for the first iteration. Please somebody review and approve.
Also, remember that this list is dynamic, we can add and remove owners later on.


Update lint hook to only lint files that have been changed for the current branch

The lint command takes around 10 seconds to run. This is fine when it's run on CI, but it feels a bit uncomfortable when run as a part of a push.
Ideally, what we want is something like this:

Full run (check or fix):

Run ESLint on all *.js and *.ts files, omitting those in .gitignore
Run Prettier on all *.json, *.md, and *.yml files, omitting those in .gitignore, as well as CHANGELOG.mds in any packages, CHANGELOG.old.md, and .yarnrc.yml

Partial run (changed files only):

Run ESLint on all changed *.js and *.ts files, omitting those in .gitignore
Run Prettier on all changed *.json, *.md, and *.yml files, omitting those in .gitignore, as well as CHANGELOG.mds in any packages, CHANGELOG.old.md, and .yarnrc.yml

More details below:

The Snaps monorepo attempts to reduce the runtime by using lint-staged to only linting files that have been staged. There are two wrinkles with the approach that the Snaps monorepo takes that would prevent us from copying it to this repo, however.
First, lint-staged is designed to be paired with a pre-commit hook, but we use a pre-push hook instead, so we'd need a different solution. So minimally, we could use something like lint-changed instead.
However, lint-changed (and lint-staged, for that matter) assume that you don't want to customize the set of files that are processed when running a full lint. For ESLint, that's not a problem, as we can get away with asking it to lint the whole project and then use .gitignore to filter out undesired files. Prettier, however, doesn't use .gitignore by default, so we tell it to use .gitignore, but then we also filter out more files on top of that.
So if we were to start using lint-changed, we'd have to have a separate way of running Prettier. We'd need a way to run file paths that lint-changed has reported as changed, but continue to filter out undesired files that aren't covered by .gitignore.
The Prettier team has made this somewhat easier by allowing multiple ignore file paths to be passed: https://github.com/prettier/prettier/pull/14332. So we could pull out the list of files that we're excluding to a .prettierignore and then instruct the prettier command to use that in addition to .gitignore.
However, one problem would remain: we'd have to accommodate two ways of calling — and configuring — our lint commands.
Say we were able to reduce package.json to something like this:
{
  "scripts": {
    "lint": "yarn lint:js && yarn lint:misc --check && yarn constraints",
    "lint:fix": "yarn lint:js --fix && yarn lint:misc --write && yarn constraints --fix",
    "lint:js": "eslint . --cache --ext js,ts",
    "lint:misc": "prettier '**/*.json' '**/*.md' '**/*.yml' --ignore-path .gitignore --ignore-path .prettierignore"
  }
}

Now say we were to add lint-changed. That might look something like this:
{
  "scripts": {
    "lint": "yarn lint:js --check && yarn lint:misc --check && yarn constraints",
    "lint:fix": "yarn lint:js --fix && yarn lint:misc --write && yarn constraints --fix",
    "lint:js": "eslint --cache --ext js,ts .",
    "lint:misc": "prettier --ignore-path .gitignore --ignore-path .prettierignore '**/*.json' '**/*.md' '**/*.yml'"
  },
  "lint-staged": {
    "*.{js,ts}": "eslint --cache --ext js,ts",
    "*.{json,md,yml}": "prettier --ignore-path .gitignore --ignore-path .prettierignore"
  }
}

(We don't specify any file paths for lint-staged because it fills them in for us.)
Note how we have to specify two ways of running the eslint and prettier commands, and we have to specify acceptable file extensions twice. It'd be nice if we could just say:
{
  "scripts": {
    "lint": "scripts/lint.sh --check",
    "lint:fix": "scripts/lint.sh --fix"
  },
  "lint-staged": {
    "*": "scripts/lint.sh --check"
  }
}

To get this to work, such a lint script would have to:

figure out which file extensions go with which command, and specify them in the way that the tool understands
accept a set of file patterns, or else default to . if no file patterns were specified, and pass the result off to the tool

So this ticket depends on the release of Prettier 3.0, but it also depends on writing such a lint script.

I've started a branch to work on this: https://github.com/MetaMask/core/tree/use-lint-changed

It's possible that ESLint may run a lot faster after we upgrade to ESLint 9. So we can hold off on working on this until that's done.


Add "BatchParameters" to the Target options of CloudWatch Events

Hi,
It would be nice iff you guys update the code to support the "BatchParameters" option for the CloudWatch Targets.
I would need to trigger a batch Job from CloudFormation and it is not available there yet.
Can you help me with this?
Thanks,
Gabriel

I believe you are referring to this which according to the CloudFormation docs here has not been implemented (in CloudFormation) yet.

Hi,
Do you know when that will be implemented ?
Do you know a way around to schedule batch job submissions to the batch queue ?
Thanks,

@skydread1 - you can add add lambda as an intermediary for this, event -> lambda -> batch, you can pass the job definition and queue info within the input field in the event.

Hi,
See that its developed on your side. When can I expect release with this change ??

picked up in https://github.com/cloudtools/troposphere/commit/326002606209cdcb92e4134af2e0cf50d2f838f0 and released in 2.5.3


DL-4026 - fixed issue with "Get help with this page"

DL-4026 - fixed issue with "Get help with this page"

assets-frontend versions 4.x.x have unresolved issues with rendering "Get help with this page" partials. Downgrading to 3.12.0 seems to have resolved the issue.

https://jira.tools.tax.service.gov.uk/browse/DL-4067 superceeds


Fixes after sync freeze on MacOS

Checklist

[ ] I have filed an issue about this change and discussed potential changes with the maintainers.
[ ] I have received the approval from the maintainers to make this change.
[ ] This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
Description of this change
CLion freezes every time after sync because the XcodeCompilerSettings are resolved under read lock.
I think we can drop the read lock for the entire workspace update since as far as I can tell nothing actually requires a read lock. And the actual update of the workspace is performed under write lock.
Or we could just move the compiler settings resolution before the read lock is taken. But dropping the read lock might prevent freezes in future.

I see that a while ago RA was pushed down in a045eabbfae7944b02d0aa5d7026f57d5e5d8853, but I'm not sure what part of update actually requires RA. Is it so that no runtime warnings for missing RA are reported? It could be that OCWorkspace.getConfigurations requires it, but it's not mentioned in the doc.


How to use it?

How to use it?Is there a tutorial?I can do a video tutorial if I can.
Love u :)

it dont have a tutorial because it's under developement
just use it as a server core

it dont have a tutorial because it's under developement
just use it as a server core

java -jar EZ4H.jar

java -jar EZ4H.jar


Fix Log Issues

This PR will fix the log issues that was discovered recently. I spent a little more time and found some other issues. All of these are documented in the "change log" section of logging.md (the following is the exact copy of the change log).
Changed

Changed the action for removing related entity rows from delete/recordset/related to delete/record/related.
Fixed a bug that would cause record load requests to be reported as update.
Fixed the issue of reporting both load and update requests of record page as record/main. Now they are being logged with proper action.

Impact: We cannot determine the number of record page loads prior to this fix. This only affects deployments that allow their users to create new records since the update request would only fire if the user updates any of the related entities.

recordset/export was used as action for export from both record and recordset which is changed to export.
Changed the template object that is reported with export action to only include the displayname and type.
Instead of logging the whole template document in the export action, we're just going to include displayname and type.{
  "action": "export",
  "template": {
      "displayname": "sample template",
      "type": "BAG"
  }
}

Fixed the action of scalar column requests.
Changed the recordedit/default action to default.

Added

Added proper dcctx logging to viewer app.
ppid and pcid has been added to the main request of each app which shows the parent pid and cid.
New actions have been attached to schema ("model/schema") and catalog ("model/catalog") requests.
catalog has been added to all the requests.
column has been added to requests for getting a scalar facet data.
If there are preselected facets, in entity mode we have to get the row-name corresponding to the selected value. Customized action (recordset/facet/init) has been added for this request.
Added proper action recordset/facet/histogram to the request for getting buckets of a range picker facet.
Added cfacet, cfacet_str, and cfacet_path.

ermrestjs PR: ermerstjs#773
related issues: #1740 #1516 #1518 ermrestjs#768

@jrchudy I updated the code and documentation to reflect the changes after the discussion that I had with @hongsudt. Both PRs are ready to be reviewed and merged.

@jrchudy I changed the test cases that you mentioned. Can you please try running the test cases again?

The test cases are passing for me now.


Treesitter Highlighting Looks Worse for Rust

Thanks for this plugin. I love onedark and I think your approach to it is the easiest one to use.
I just noticed today that I didn't have the Rust treesitter parser installed. I was getting syntax highlighting probably through the "rust-tools.nvim" plugin previously.
When I enable treesitter highlighting with TSEnable highlight, almost everything remains the same except for three things:

? operators
& operators
Angle brackets

The highlight for these nodes makes them hard to distinguish from other text.
Is this intended? Or do I have a conflict somewhere?
Here's some pictures for reference:
TS Highlighting Disabled:

TS Highlighting Enabled:

Here's my config:
-- Color scheme config
require("onedark").setup({
    style = "deep",
    toggle_style_key = "<leader>ts",
    lualine = {
        transparent = true,
    },
    highlights = {
        MatchParen = { fg = "$red", bg = "$none", fmt = "underline" },

        TelescopeBorder = { fg = "$light_grey" },
        TelescopePromptBorder = { fg = "$light_grey" },
        TelescopeResultsBorder = { fg = "$light_grey" },
        TelescopePreviewBorder = { fg = "$light_grey" },
        TelescopeMatching = { fg = "$orange", fmt = "bold" },
        TelescopePromptPrefix = { fg = "$red" },

        CurSearch = { bg = "$fg" },
        IncSearch = { bg = "$fg" },
        Search = { bg = "$blue" },

        FoldColumn = { bg = "$bg0" },
    },
    diagnostics = {
        darker = true,
        undercurl = true,
    },
})
require("onedark").load()

Thank you.

Also, I can't figure out the highlight keyword for the ? operator. Treesitter says the node is try_expression but this doesn't work:
["@try_expression"] = { fg = "$red"}

I think I'm not understanding how to identify treesitter keywords from the readme.


the pip version is not up to date and doesn't work

it gave me an error because print did not have parentheses.

@lordadamson : Tested the latest version(0.0.8) with pip2 and pip3 install and have verified it works. Please update the version and you should be good.


roll the version so we can release new package with MIT license.

Forgot to roll versions to allow for us to release a package with new license.

Well, this is why build scripts shouldn't be in the repo.  They are better managed separately.  I can't figure out how to update the build script to install .Net5.0 because it is using the script from master...

Ok, got the check build to pass, how do we set up an automated release?

And should squash this merge, it is pretty messy

And should squash this merge, it is pretty messy

Agreed. I will take care of preparing a new release.


New UI Filtering

What's Changed

Adds filtering capability to the drawer on list views
Adds a schema for the model's FilterSet
Adds live searching against the q filter in the navbar

(This is a combined feature branch of several stories)
TODO

[ ] Explanation of Change(s)
[ ] Added change log fragment(s) (for more information see the documentation)
[ ] Attached Screenshots, Payload Example
[ ] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
[ ] Example Plugin Updates (when adding/changing features)
[ ] Outline Remaining Work, Constraints from Design

I'm noticing that the q filter isn't getting the remove/add elements in the filter panel. Is this intentional?

Nitpick: This message on the home page search box is a bit ambiguous. With this message I would assume that the search box doesn't work anywhere, but it's really just the home page where it's not implemented yet.


Please include Plant Maintenance in the feed generator

Topic details

Name: Plant Maintenance
URL: https://community.sap.com/t5/c-khhcw49343/PLM+Enterprise+Asset+Management+%252528EAM%252529%25252FPlant+Maintenance+%252528PM%252529/pd-p/430019464658497915145476514330950
URL: https://community.sap.com/t5/c-khhcw49343/SAP+Predictive+Maintenance+and+Service%25252C+on-premise+edition/pd-p/73555000100800000307

@ajmaradiaga please check

@abap-weasel will be available in the next run


[Bug]: \relax appears in my bib file, causing the reference compile failed.

Debug log ID
LQNNPFL3-apse
What happened?
A bug happened!

I used Better BibTex plugin to output my bib file.
I noticed that \relax appears in my bib file.
When I use overleaf or VScode latex-workshop to compile my porject, reference always compile failed.
When I replace \relax to   in the bib file and compile project again, reference will appear.
So my conclusion is that, \relax appears in my bib file, causing the reference compile failed.

I need a debug log as per point 1 of the instruction above.
Do you have a minimal LaTeX document that reproduces the compilation error?

This compiles without issue for me:
\documentclass[a4paper, 12pt]{article}

\usepackage{filecontents}

\begin{filecontents*}{\jobname.bib}
@article{Astrakharchik2007,
  title = {Weakly interacting two-dimensional system of dipoles: {{Limitations}} of the mean-field theory},
  shorttitle = {Weakly interacting two-dimensional system of dipoles},
  author = {Fritzsche, Victor and Bao, Sam and Hofmann, {\relax Ph}ilippe and Polčik, Martin and Schindler, Ken and Bradshaw, Arthur and Davis, Robin and Woodruff, Dennis},

  year = {2007},
  month = jun,
  journal = {Physical Review A},
  volume = {75},
  number = {6},
  pages = {063630},
  issn = {1050-2947, 1094-1622},
  doi = {10.1103/PhysRevA.75.063630},
  langid = {english}
}
\end{filecontents*}

\begin{document}
\title{Autumn Term Report}
\author{myself}
\date{\today}
\maketitle

HI \cite{Astrakharchik2007}

\bibliographystyle{apalike}
\bibliography{\jobname}
\end{document}

FD6RMFQ6-refs-apse exports to this for me -- I see no \relax
@inproceedings{Lam2015,
  title = {Numba: a {{LLVM-based Python JIT}} compiler},
  shorttitle = {Numba},
  booktitle = {Proc. {{Second Workshop LLVM Compil}}. {{Infrastruct}}. {{HPC}}},
  author = {Lam, Siu Kwan and Pitrou, Antoine and Seibert, Stanley},
  year = {2015},
  month = nov,
  pages = {1--6},
  publisher = {{ACM}},
  address = {{Austin, Texas}},
  doi = {10.1145/2833157.2833162},
  isbn = {978-1-4503-4005-2},
  langid = {english}
}

I update the ID FD6RMFQ6-refs-apse
This is a minimal LaTeX document

\documentclass[a4paper, 12pt]{article}

\usepackage[backend=biber]{biblatex}

\usepackage{filecontents}

\begin{filecontents*}{\jobname.bib}
  @article{Hasan2021A,
  title = {A Machine Learning Framework to Predict the Risk of Opioid Use Disorder},
  author = {Hasan, Md Mahmudul and Young, Gary J. and Patel, Mehul Rakeshkumar and Modestino, Alicia Sasser and Sanchez, Leon D. and {Noor-E-Alam}, {\relax Md}},
  year = {2021},
  month = dec,
  journal = {Machine Learning with Applications},
  volume = {6},
  pages = {100144},
  issn = {2666-8270}
}
\end{filecontents*}

\begin{document}
\title{Autumn Term Report}
\author{myself}
\date{\today}
\maketitle

HI \cite{Astrakharchik2007}

\printbibliography[heading = bibintoc]

\end{document}

You see. The reference failed

I have the problem reprodicible, working on it, but if you're using biblatex, why not export as Better BibLaTeX?

You are right. It was my fault. I wasn't even aware of the problem.

Yeah in a BibTeX MWE the entry compiles correctly. \relax is something for bibtex, biblatex does initials differently.

Thank you very much. My problem is solved.


Using numeric inputs instead of sliders

I find the sliders difficult to use for most of the victron inputs. Sometimes the step size is too large, sometimes just swiping on the mobile phone moves important sliders to their min or max values. I would rather use regular, numeric input fields...

+1, fully agree. I think, sliders are dangerous.

I would feel more for making this configureable through the settings of the integration.
Rather than changing it to numeric input for everybody.
I'm open to a PR for this change.
Otherwise it might take a while since I currently do not have a lot of spare time

Please try the release v0.1.0 this includes support to using numeric number entities by unchecking the newly introduced specific configuration option for slider mode.
Feel free to report back if there are any issues or if it's working as intended

Feel free to report back if there are any issues or if it's working as intended

I've only used this to change the ESS grid setpoint, but it seems to work great for me. Thank you! The slider is handy, but it isn't nearly granular enough--in my case, it's in increments of 300W. If my finger moves even a bit while lifting, I could end up moving 3-4000W off target!
I think the ideal interface would be something like my hot water heater, perhaps with a configuration option to specify the increment of 1, 10, 50, 100W. (the GX device moves in 10W increments, by the way)

Not to be nit-picky, but I did also notice that number.victron_settings_ess_acpowersetpoint2, number.victron_settings_ess_batterylife_minimumsoc, number.victron_settings_ess_maxfeedinpower (and perhaps others?) show a ".0" (tenths of watts) precision:

Closing this issue as completed.
Tracking the tenths of a watt @randyoo reported in #196


Implement RX1/RX2 listening using RxTimeout from radio

This PR implements preamble-detection using Radio timeout and rips out most of the timer functionality during RX1 and RX2 windows. This probably makes #198 obsolete.
Tested with:

sx1262
sx1272

I tested this on the stm32wl/lora_lorawan example without success. I need to look more into what is going on. My guess is that we're arriving too early perhaps and the timeout fires too soon? I'm not too sure.

I looked more closely at this today and I think I understand the issue a bit better. I believe this "symbol timeout" may work for EU868 because the on-air-time of the 12 join symbols is much longer. It didn't work for US915, because the on-air-time is much less.
Because of this intuition, I tried reducing rx_window_offset from -50. Joins appear to work again from -25 to -3. Part of the reason for this apparently flexibility is because the preamble may be detected even if you don't catch the whole preamble (I remember reading this in a Semtech app note somewhere).
However, tuning rx_window_offset to an arbitrary number isn't a very reliable fix; in my opinion, it should work more reliably (albeit less efficiently) the bigger the value gets. In other words, the intention of rx_window_offset is to provide some fudge factor; the time before the window where you want to start arming receive. Not only does this give you time to execute the SPI transactions to configure the radio, but it also accounts for the non-deterministic delays between the interrupts and their handling (at least with a cooperative scheduler like embassy). That is to say, I don't have good guarantees from the moment the "send complete" interrupt fires and when I execute the Timer::reset which becomes the reference for when I schedule the Radio::rx_setup. On top of that, we don't have strong guarantees for when Timer::at(ms).await will return, as another task could be executing as we wait for our turn.

One simple fix that I think we should consider is to include the rx_window_offset in the preamble timeout. But it's difficult to do at the moment because our timeout is symbol based at the moment. Was there a reason to not use the time-based timeout of the SX12xx?

Thanks @lthiery, I have pulled in your changes and then did some rebasing and reworking, so commits follow somewhat logical order: https://github.com/plaes/lora-rs/tree/preamble-rxtimeout-rebase


Treemap Polish (1/2)

See code changes from #79 and #110 to incorporate into these changes; some work has been done already.
See tooltip (material tooltip) implementation on the table columns for example.

Link to the O*net page for each occupation. See this example for how to add hyperlinks to d3 objects. The link can be on either the cell or the job title
Display transition shares as formatted percents with 2 decimal places. So a transition rate of .12345 would be displayed as “12.35 %”

closing issue per merged pr.

closing issue per merged pr.


Fix backgroundColor is not working in title #11874

Brief Information
This pull request is in the type of:

[x] bug fixing
[ ] new feature
[ ] others

What does this PR do?
Fix title backgroundColor is not working without borderWidth
Fixed issues
Close #11874
Details

After: How is it fixed in this PR?

Usage
Are there any API changes?

[ ] The API has been changed.

Related test cases or examples to use the new APIs
NA.
Others
Merging options

[x] Please squash the commits into a single one when merge.

Other information

Thanks siwen!


Feat: rewrite find-music recommend page

before
after

Add song card hover effect

Add new song view


Facing issue for explain instance with custom classifier function

exp = explainer.explain_instance(df_val_final.Description[idx],predproba_list,num_features=5, top_labels=2)
While executing the explain instance of LimeTextExplainer, above statement keeps on executing continously with below warning message. Execution stops only if i interrupt the kernel
C:\ProgramData\Anaconda3\lib\site-packages\fastai\torch_core.py:83: UserWarning: Tensor is int32: upgrading to int64; for better performance use int64 input
warn('Tensor is int32: upgrading to int64; for better performance use int64 input')
C:\ProgramData\Anaconda3\lib\site-packages\fastai\torch_core.py:83: UserWarning: Tensor is int32: upgrading to int64; for better performance use int64 input
warn('Tensor is int32: upgrading to int64; for better performance use int64 input')
C:\ProgramData\Anaconda3\lib\site-packages\fastai\torch_core.py:83: UserWarning: Tensor is int32: upgrading to int64; for better performance use int64 input
warn('Tensor is int32: upgrading to int64; for better performance use int64 input')
I want to use my own custom classifier model and hence I wrote a classifier function - predproba_list, which returns a numpy array of predicted probabilties for the classes
Below is the function code
def predproba_list(test1) :
pred = learn_clf.predict(test1)
return np.array(pred[2])
pred[2] vaue is tensor([0.1423, 0.2133, 0.6444]) which i then convert to a numpy array
Can you please advise if the return value of the function is as expected by the explain instance's classifier function, and what could be causing the code to keep on executing without any result
Thanks in advance

Now I am getting the below error,
ValueError: Found input variables with inconsistent numbers of samples: [5000, 1].
5000 is the default value for argument num_samples in function explain_instance() if it is not explicitly defined.
How is the value for num_samples determined if need to set it explicitly

The output should be a 2d array , where columns are prediction probabilities for different labels. If you only have one label, it should still be (n, 1)


[PE-D][Tester E] add command outdated for quickstart

add command still uses AddressBook command in quickstart

Labels: type.DocumentationBug severity.Low
original: darkvoid32/ped#9

Duplicate of #113


Quickaccess systemtray launcher

Summary of the Pull Request
This PR introduces a new way of launching various PowerToys modules by clicking on the icon in the system tray.
Features:

Layout showing activated modules that can be launched using the launcher.
The tooltip of each module shows the activation shortcut.
Settings and docs can be opened.
Modules that are disabled will not be shown.
If there's an update available, this will be shown for awereness.

Things to do:

Proper window management (calling the flyout, opening the Settings screen etc.)
Localization & a11y
Telemetry?
Probably more :)

Open questions:

Do we want to support turning on / off features (like KBM) in the initial version?
Do we want to show modules that are disabled as disabled icons?

PR Checklist

[X] Closes: #6751
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Do we want to show modules that are disabled as disabled icons?

Actually, my personal thought is comparing this with the action center ight of Windows. Here you can also find things that are on/off, and this is the place to turn it on. So, For me, this would be a no-brainer :)

That does mean that there would be like 18 modules here in the window...
Would also be nice if this could replace the full current PT icon menu ("report bug" etc.)

Do we want to show modules that are disabled as disabled icons?

Actually, my personal thought is comparing this with the Action Center. Here you can also find things that are on/off, and this is the place to turn it on. So, for me, this would be a no-brainer :)

That does mean that there would be like 18 modules here in the window...
Would also be nice if this could replace the full current PT icon menu ("report bug" etc.)

That's why I'm not in favor in supporting it 😁: it's meant to be a launcher, that allows launching modules that can only be triggered by a keyboard shortcut. There's little value in turning on/off context-menu modules?
Quick Actions only supports settings that users regurly toggle between - for PT, I could imagine a toggle for KBM and Awake modes?

@niels9001

I think it should be a launcher and information center only.
Some additional features would be nice: Showing the active fz layouts per monitor, controling awake, controling vcm. I think it could be realized that wen we click on the module icon the additional features panel for the module is expanding.
If an update is shown, can the user open the settings by clicking on the update info?
Personally I would replace the document symbol with a help/question symbol.
A third symbol to open the scoobe/oobe page might be useful.

Support for easy turning on/off would especially be useful for KBM.  I use it when my laptop is undocked to make the condensed keyboard’s alternate Fn behavior (PrtSc, Home, Ins) of F9 F10 F11 keys the main behavior for editing convenience, and so that other function keys behave in programs as their usual purpose, like F3 find-next, F5 refresh, etc.  When docked I turn it off because the bigger keyboard has separate PrtSc, Home, and Ins keys, leaving F1-F12 normal.

I think this idea is amazing and I'd love to see it in whatever form is best.
I think being able to turn on/off all modules from here would be a bit much and overcomplicate it, but options for Awake or KBM could be good. Besides, Settings is just one click away from here. (Although maybe such an option could be added via a context menu when right-clicking a module?)
I also think the file icon for documentation isn't immediately obvious; I'd also agree with using a question mark or help icon would be better.
Either way, I'd love to see this added in!

My opinion is that  like this it imitates the Windows 11 quick action center, ehich primarly is for turning things on/off. I don't think it's very intuitive to use the same design, but a different functionality.

My opinion is that like this it imitates the Windows 11 quick action center, ehich primarly is for turning things on/off. I don't think it's very intuitive to use the same design, but a different functionality.

Fair point - not sure if it'll be a major hurdle, but if so we could adopt the Start Menu grid-like design as it's more inline with app launching.

What's the point of showing the hosts file editor there? That can be launched with just the exe file (at program files\powertoys\modules). As I see it, this is much better suited to launching things that are otherwise accessible only with the keyboard, like Run or the colour picker.
Besides I don't think there's a lot of people that need to edit the hosts file so often that they need a "quick access" thingy for it. If they do, as I said, they can just make a shortcut to its exe file.

My opinion is that like this it imitates the Windows 11 quick action center, ehich primarly is for turning things on/off. I don't think it's very intuitive to use the same design, but a different functionality.

I think we need a Discussion to poll ideas from users. I feel there are different interpretations from us already, so we should ask the users.

Hi @niels9001 ,
@donlaci  will be working on this feature. This branch has the current state of the code, right?

Hi @niels9001 , @donlaci will be working on this feature. This branch has the current state of the code, right?

Yep! I'm expecting some (minor) UI changes and an additional 'app list' view to toggle on/off every module.

Updated the GIF in the original post reflecting the latest changes (still WIP though :)).

Great job! Love it in dark mode! ❤
I know this still a WIP but i want to provide a few feedbacks:

Old systray menu had an "Exit" option to close PT: don't know if this impact normal users but I use it a lot during development.
If you double click on systray icon 2 flyouts are opened instead of open settings window.

I know this still a WIP but i want to provide a few feedbacks:

Old systray menu had an "Exit" option to close PT: don't know if this impact normal users but I use it a lot during development.

Thought this is the X on the right corner of the new fly out (see screenshot)?

Looking at the changes it seems the flyout is replace the right-click menu. Is that supposed to be the idea here? Given that this is on Settings and the what we've experienced with Win app SDK on some machines, this means people would lose access to Bug report and Exiting from the system tray icon.
Wouldn't it make more sense to keep the current context menu on right-click and add this new fly-out on left click?
Thoughts?

Just pushed a fix for the flyout not gaining focus when activated. We were hitting https://github.com/microsoft/microsoft-ui-xaml/issues/7595

I've made changes so that the Settings pages refresh when we enable/disable modules in the flyout.

I've removed VCM from the list of apps. It's legacy and it's only controllable when running as admin. Best leave it out.

Currently trying to figure out this flicker:

It seems to be happening on mouse over and only happens when we're running without debugger attached (the presence of a debugger makes it so that the flicker doesn't occur)
It seems somehow related to the FlyoutMenuButton or the BitmapIcon rendered for it, since that's what's flickering.


Add missing hosts info to the prometheus exporter output.

Description
Sometimes the hostStats object of the agents becomes null in the management server. It is a rare situation, and we haven't found the root cause yet, but it occurs occasionally in our CloudStack deployments with many hosts.
The hostStat is null, even though the agent is UP and hosting multiple VMs. It is possible to access the VM consoles and execute tasks on them.
This pull request doesn't address the issue directly; rather it displays those hosts in Prometheus so we can restart the agent and get the necessary information.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[x] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[x] Major
[ ] Minor
[ ] Trivial

How Has This Been Tested?

Set prometheus.exporter.enable to true.
Execute curl localhost:9595/metrics on management server to make sure that prometheus is working.
Stop any agent.
Run curl localhost:9595/metrics | grep cloudstack_host_missing_info you get nothing in output cause the host state is still there. (If you wait for couple of minutes management server may remove it)
Restart the management server to remove cashed host stats objects in the memory.
Run curl localhost:9595/metrics | grep cloudstack_host_missing_info again to get the following output:

curl localhost:9595/metrics | grep cloudstack_host_missing_info
cloudstack_host_missing_info{zone="testZone1",hostname="node01",filter="hostStats"} -1

How did you try to break this feature and the system with this change?

The change wouldn't affect other area of code as the prometheus module is somehow an independent part of the CloudStack.

@blueorangutan package

@blueorangutan test

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[SF] Trillian test result (tid-8506)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47638 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8328-t8506-kvm-centos7.zip
Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_08_migrate_vm
Error
46.83
test_vm_life_cycle.py


Error in doc.get_page()

Hi, I am getting error in reading a specific page using doc.get_page(). Anything I need to change in this package?
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\Local\Continuum\anaconda3\lib\site-packages\minecart\miner.py", line 350, in get_page
self.interpreter.process_page(page)
File "C:\Users\Local\Continuum\anaconda3\lib\site-packages\pdfminer\pdfinterp.py", line 642, in process_page
self.render_contents(page.resources, page.contents, ctm=ctm)
File "C:\Users\Local\Continuum\anaconda3\lib\site-packages\pdfminer\pdfinterp.py", line 652, in render_contents
self.execute(list_value(streams))
File "C:\Users\Local\Continuum\anaconda3\lib\site-packages\pdfminer\pdfinterp.py", line 675, in execute
func(*args)
File "C:\Users\Local\Continuum\anaconda3\lib\site-packages\pdfminer\pdfinterp.py", line 435, in do_CS
self.scs = self.csmap[literal_name(name)]
KeyError: 'R13'

Which pdfminer are you using? (There are a couple of Python 3 forks floating around)

Can you make sure you've installed pdfminer3k? You might be using the one for Python 2 here, so it could be a bytes vs str issue.

Unfortunately that is based on how the PDF was created. Sometimes they have the equivalent of render_string('Property Address', x, y) and sometimes they have render_string('P', x1, y1); render_string('r', x2, y2) ... etc. When it's the former, pdfminer picks it up in its entirety. When it's the latter you unfortunately get the multiple words.
Pdfminer does have a rudimentary layout analyzer, but for my purposes I always found it easier to do some ad-hoc merging. Of course, it depends on the regularity of your PDFs, your goals etc. which approach you take

Hi, thank you for explaining this.
Here is the sample PDF file I am trying to read :
https://www.appraisalservice-sac.com/documents/appraisal_report.pdf
from page4, I am trying to extract the following field.
Property Address = 4816 Village Sample Drive
City = EI Dorado Hills
state = CA
Zip Code = 95762
when minecart extracts the entire word, it is easier to search using the bbox close to it to extract the address value. but some of pdfs, I get partial words and single letters. Any suggestion how to use this to extract the values?
Thanks a lot.

If the reports are all in the same format, you could determine a reasonable bounding box to use and hard-code that into your script. Then using the iter_in_bbox method you could collect all the Lettering objects in use, sort them based on x coordinate and join them.

Thanks for the suggestion. I will check this method.


Fix double-escaping in internationlized strings

Changes

Disable i18next's escaping functionality in order to fix strings being double-escaped.

Testing
With a string like:
"status_upcoming": "Certification opens on {{date, datetime}}",

Before:

After:

@aligg I think what might be happening in this case is that i18next was turning the slashes into their HTML entity equivalent: /. But React renders that as a string instead of HTML. https://codepen.io/sawyerh-the-sans/pen/NWzxOab?editors=1010


Samsung familyhub available in HA but doesn't allow for TTS..even thought it participates in everywhere

NOTE: For a feature to be created it has to be doable in the Amazon app because we are basically replicating the app for HA. If you can't find it in the app, we probably can't create it here.
Is your feature request related to a problem? Please describe.
So our familyhub fridge got an alexa update a while ago. It even participates in the everywhere group somehow. I also see it on the HA dashboard as another regular alexa.
But i can’t seem to send it a message…:frowning: That would have been so nice :slight_smile:
I tried turning it on as well with media player turn on. no dice.
Anyone have any success with this ? Maybe i should ping it upfront ? Shame the samsung familyhub integration is not working anymore.
Describe the solution you'd like
Able to send it TTS
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Can you send a TTS directly to it using the Alexa app? Third-party integrations are pretty random on what works or doesn't work.

I actually got it to work with tts. Must have been a typo. Thanks, this can be closed.

From: Alan Tse @.>
Sent: 12 January 2023 02:22
To: custom-components/alexa_media_player @.>
Cc: atv2016 @.>; Author @.>
Subject: Re: [custom-components/alexa_media_player] Samsung familyhub available in HA but doesn't allow for TTS..even thought it participates in everywhere (Issue #1821)
Can you send a TTS directly to it using the Alexa app? Third-party integrations are pretty random on what works or doesn't work.
—
Reply to this email directly, view it on GitHubhttps://github.com/custom-components/alexa_media_player/issues/1821#issuecomment-1379729325, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEBCFU3OCI7CJPY7RKANUI3WR5TEXANCNFSM6AAAAAATWT5DKY.
You are receiving this because you authored the thread.Message ID: @.***>


Add labels to runs table and move to left

fixes #106
see also getwilds/rcromwell#43
Before

After

The labels are in the workflow description table, and left unchanged - they're far over on the right - let me know if you want those shifted left too
This requires the version of rcromwell on the dev branch as there's a new function needed that fetches workflow labels

Clarifying question

I don't know 🤷🏽  It's not entirely clear to me what the workflow is now. I'll wait to merge to see what we should do

@tefirman to add to my answer above, e.g., looks like https://github.com/getwilds/rcromwell/milestones are now the PROOF project milestones - whereas I used to use those for release versions for each repo - can i still cut a release of e.g., rcromwell independent of the PROOF project milestones? And i'm not sure how to track/organize releases now if the milestones are used for the PROOF project as a whole

bump @tefirman
thoughts on what the workflow should be for your question above?


External functions getting called twice

Hi,
It is my understanding that with the new version of ink, external functions should only be called once (default behavior "actions", as opposed to the previous behavior where glue "lookahead" often caused functions to be called at any time, and frequently more than once).
However, when running external functions in blade-ink, I'm frequently seeing functions called twice.
I'm assuming this may be an issue in blade-ink, since I'm not seeing people complaining about this in ink issues. Thoughts?
Regards,
Michael A.

I too am running into this problem. Have you resolved it somehow?

It turns out this problem was on my end. i didn't use the bindExternalFunction function that had the lookaheadSafe parameter. I needed to pass in false and it only calls the functions once now!

Keep an eye on it. There hasn't been a new version of Blade-Ink since (because there hasn't been a new Ink version), and I haven't really checked it since - I just stopped trusting Ink again on this point. The mix of Ink and code is complex enough that it's easier to work around the problem than to try and debug it.
But I've encountered times during debugging of other issues where it still seems to be doing this.

https://github.com/bladecoder/blade-ink/blob/759a68138ebae5ca87246d4ca4089efbf9f97e1e/src/main/java/com/bladecoder/ink/runtime/Story.java#L344
 * @param lookaheadSafe The ink engine often evaluates further than you might
 *                      expect beyond the current line just in case it sees glue
 *                      that will cause the two lines to become one. In this
 *                      case it's possible that a function can appear to be
 *                      called twice instead of just once, and earlier than you
 *                      expect. If it's safe for your function to be called in
 *                      this way (since the result and side effect of the
 *                      function will not change), then you can pass 'true'.
 *                      Usually, you want to pass 'false', especially if you
 *                      want some action to be performed in game code when this
 *                      function is called.

https://github.com/bladecoder/blade-ink/blob/759a68138ebae5ca87246d4ca4089efbf9f97e1e/src/main/java/com/bladecoder/ink/runtime/Story.java#L367

	public void bindExternalFunction(String funcName, ExternalFunction<?> func) throws Exception {
		bindExternalFunction(funcName, func, true);
	}

It took a while, but after tracking down all of the times I've reliably been able to reproduce this issue, I've concluded that it's either been the case of an issue like the above (i.e., using bindExternalFunction with the wrong parameters) or related to another bug in my code (as mentioned, I use a lot of custom code, and some of that also had issues).
After I had gone through every binding and fixed the bugs mentioned above, I no longer find this issue occuring.


Unknown X-VC value

Thank you very much for your selfless dedication, can you provide detail documentation for the X-VC value?
client.login('email', 'password', 'device id', 'xvc' /* this */);

Tried to find the X-VC value by capturing connection but it was blocked by kakao client.
Where can I find the X-VC value?
Thank you again for your hard work.

X-VC value is security related thing that made with email, password, user-agent and device id as far as I know. If you put wrong X-VC value here. Your login request will be rejected. I extracted them by dumping memory of official client program.
Note: Currently I'm not maintaining this project unless there are major bug which affects my bot.

I am so pleased to hear from you.
I think I got the proper X-VC value but it still doesn't work.
I got error Error 30. Someof field values are wrong ,
but I rarely got Received wrong response:  Access login ERR 12.
new TalkClient('NAME' /* here! */);

Does the TalkClient name should be device's name ( DESKTOP-XXXXXXX ) ?
Also, is the deviceUUID value from login method base64 string?
I am very thankful that you're considering my problem. Thank you for your attention to this matter and look forward to hearing from you again soon.

X-VC value is security related thing that made with email, password, user-agent and device id as far as I know.

Most error 30 is caused by X-VC value mismatch. Current node-kakao's A header for auth is "KT/3.0.6 Wd/10.0 ko". Current official client is 3.1.1 so it is outdated.
You have to match version string in kakao-api.ts
in kakao-api.ts
static get Version() {
    return '3.0.6';
}

static get InternalAppVersion() {
    return `${this.Version}.${this.InternalAppSubVersion}`;
}

static get InternalAppSubVersion() {
    return '2319';
}

static get OSVersion() {
    return '10.0';
}

static get Language() {
    return 'ko';
}

static get AuthUserAgent() {
    return `KT/${KakaoAPI.Version} Wd/${KakaoAPI.OSVersion} ${KakaoAPI.Language}`;
}

^ this

I also think I got the right X-VC header, but ERROR 30 keeps happening. Can you tell me exactly where i can find device_UUID ? Is this HKEY_CURRENT_USER\SOFTWARE\Kakao\KakaoTalk\DeviceInfo\2020~XXX\dev_id  in pc registry ?

Thank you. It worked for me. I got a proper X-VC value by memory dumping and it worked.
Thank you again for taking the trouble to help me. I do appreciate it. Good luck in everything

Good to hear it worked well for you.
There is device uuid thing in registry but It's not complete key. You need to extract it like x-vc value.
Closing this issue.


amplify env checkout NotAuthorizedException: Refresh Token has expired

Describe the bug
Amplify env checkout, a command that worked well in the past, suddenly encountered a NotAuthorizedException: Refresh Token has expired error.
Amplify CLI Version
amplify -v 4.41.0
To Reproduce
Failed to refresh tokens.
Failed to get credentials.
NotAuthorizedException: Refresh Token has expired
at Request.extractError (/Users/ywroh/work/amplify-cli/node_modules/aws-sdk/lib/protocol/json.js:52:27)
at Request.callListeners (/Users/ywroh/work/amplify-cli/node_modules/aws-sdk/lib/sequential_executor.js:106:20)
at Request.emit (/Users/ywroh/work/amplify-cli/node_modules/aws-sdk/lib/sequential_executor.js:78:10)
at Request.emit (/Users/ywroh/work/amplify-cli/node_modules/aws-sdk/lib/request.js:688:14)
at Request.transition (/Users/ywroh/work/amplify-cli/node_modules/aws-sdk/lib/request.js:22:10)
at AcceptorStateMachine.runTo (/Users/ywroh/work/amplify-cli/node_modules/aws-sdk/lib/state_machine.js:14:12)
at /Users/ywroh/work/amplify-cli/node_modules/aws-sdk/lib/state_machine.js:26:10
at Request. (/Users/ywroh/work/amplify-cli/node_modules/aws-sdk/lib/request.js:38:9)
at Request. (/Users/ywroh/work/amplify-cli/node_modules/aws-sdk/lib/request.js:690:12)
at Request.callListeners (/Users/ywroh/work/amplify-cli/node_modules/aws-sdk/lib/sequential_executor.js:116:18) {
code: 'NotAuthorizedException',
time: 2021-01-15T12:19:50.101Z,
requestId: 'c0d*******1ff',
statusCode: 400,
retryable: false,
retryDelay: 11.501672036823617
}
Expected behavior
I wanted amplify env to change from dev to test.
Screenshots

Desktop (please complete the following information):

OS: macOS Big Sur 11.1
Node Version: v15.2.0

Additional context
[Solved]
As a result of checking the log through amplify-dev, it was confirmed that the configLevel, useProfile, and profileName of the env test in project/amplify/.config/local-aws-info.json were different, and it was fixed by modifying the same as dev.

Glad it's solved, closing the issue.

Glad it's solved, closing the issue.


Further reduce ExecutionContexts in blaze

Trivial mappings and flatMappings are moved to a parasitic ExecutionContext to avoid a thread shift.  All of these could probably use the directec, which is infintesimally faster, but not stack safe.  We don't have to think as hard with this one.
Because parasitic doesn't exist in 2.13, we introduce a compat trait to use the old blaze trampoline on Scala 2.12.

I'm currently looking askance at the call to ExecutionContext in Http1ServerStage.runRequest.

Also discovered as part of #6098.


tusimple training stuck at epoch #1

Hi Harry,
I have checked all the existed issues, and found no solution for this problem. The issue is that when launching tusimple training with the train.py, after train epoch #0, val epoch #0, it will always stuck at train epoch #1. And I wonder the results you get from the readme.md is also from only 1 epoch?
The following is the tensorboard, and you can see there is no logs from val loss. Is it normal?

After setting num_workers=0, this issue of hanging after epoch 1 gets resolved. But there is still no plot showing for val_loss.
@harryhan618 Could you help explain why would you put tensorboard.scalar_summary("val_loss", val_loss, iter_idx) outside of the for loop for line 184 in train.py?

@alchemz hi！
I put tensorboard logging outside of the loop during validation, because during validation, I just want to know the loss situation for the whole epoch. Single iteration during validation is meaningless.


ECS compatibility

Seems like some fields can be mapped to ECS fields.
mutate {
      copy => { "postfix.message_level" => "log.level" }
      copy => { "postfix.client_ip"     => "client.ip" }
      copy => { "postfix.client_port"   => "client.port" }
      copy => { "postfix.relay_ip"      => "destination.ip" }
      copy => { "postfix.relay_port"    => "destination.port" }
      copy => { "postfix.server_ip"     => "server.ip" }
      copy => { "postfix.server_port"   => "server.port" }
}

Fields can be mapped to any 3rd party system, and probably many people do that. But it should be part of the local setup, not of this repository. Not everybody uses ECS.


docs+tests directly in a model

Describe the feature
When I started to learn dbt, I thought that data documentation is part of a model. Which is true, once it is published on the docs server. But when talking about source code, documentation is separated to schema.yml which is not intuitive for me. I would expect to have an option to write the docs close to the code. I can imagine a part of the config for this :

Who will this benefit?
When one is making changes in a model, he can see the docs and moreover edit it immediately + he sees names of columns produced in the model.
Thanks :)

I am coming with another idea. I don't know whether it is a problem for others, but for me the problem is that the documentation

is in another file
have to create the file and also structure in the file manually (sure, there are some helpers #1082 )
have to keep it in sync when the model is changed (probably the biggest pain)
doesn't really document the code itself

The idea is to have the documentation inside the model using comments.  Other programming languages uses comments for documentation, so it could work as well.
For example a comment --docs   could be parsed and used for documentation. The position of such comment would not be important as it holds the column name, so it would work also in long models with many CTEs. It could be another option to document model and could be overridden by schema.yml
What do you think @drewbanin @jrandrews ?
SELECT
       --docs name full name of customer
       full_name
       --docs country country where customer is located based on IP location
       ,country
       --docs language language set in customer browser
       ,browser_language
       --docs date_created_at date customer created
       --this is an unrelated commented to docs
       ,date_created_at
       --docs date_last_login date customer logged in
       ,date_last_login
  FROM analytics.customer

I haven't thought about column level tests yet.

I'm thinking about this in the same way I'm thinking about #2401, which is on our 1.0 to-do list, and could be essentially summarized as: "Reconcile node configs and resource properties, where possible and it makes sense."
Today, it's not totally clear what can be defined in one vs. the other—or both (tags). This is a big point of confusion for new dbt users. Of course, we don't want to create more confusion in the process: We'll need to come up with ways to reconcile config-properties that are set hierarchically in .yml files with the ones set in config() blocks. I think in-file config() should always win, but I could also see wanting to raise a warning if there's conflicting information set at the exact same level (e.g. the same column described twice).
Personally, I find myself agreeing with @jrandrews's point above. I think that, by and large, we'll want to maintain the functional distinction that exists today, recast as a convention:

Configure the behavior of a model's execution with config() or dbt_project.yml
Describe a model's properties in models/*.yml

We had a similar problem and wanted to post an issue. The worst thing for us was that we often forgot to edit the schema file when we added / removed columns. But I think having a description in sql can lead to a lot of commits without changing business logic, let alone merge conflicts. We have created a tool for us that will allow us to check the differences between schema and sql comments + much more. Maybe it can help you - https://github.com/offbi/pre-commit-dbt


Docstring not working in Python

Type: Bug
codes:
def function(a: str, b: bool, c: int):
    ''' the function doc string.
    Here is a bit more.

    args:
        a:  a random string goes here
        b:  lets describe something binary
        c:  we have a whole number

    return:
        gives something back

    '''

When hovering over the function definition in VS Code, the description is formatted correctly.
If the type is wrapped in parentheses after the parameter, the description will appear on the one line
def function(a: str, b: bool, c: int):
    ''' the function doc string.
    Here is a bit more.

    args:
        a(str):  a random string goes here
        b(bool):  lets describe something binary
        c(int):  we have a whole number

    return:
        gives something back

    '''

The same issue has been closed in Microsoft/vscode, they believe it is an issue with vscode-Python.
VS Code version: Code 1.76.1 (5e805b79fcb6ba4c2d23712967df89a089da575b, 2023-03-08T16:32:00.131Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Sandboxed: No

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.78.0. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Related on Stack Overflow: docstring not working in Python on VS Code

@VSCodeTriageBot  Thank you for your reply. I have updated the vscode, but this issue still exists in version 1.78

i am using version 1.78.0 and still experience this issue.

/extPython

It looks like this is caused by the Python extension. Please file the issue to the Python extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!

I am not sure why this is closed when the problem still persists ?


[AutoDiff] Fix return type of subset parameters thunk function

The patch resolves #67402.
When the original function has a tuple result type, we should append thunkedLinearMap as the last element of the tuple to match the function declaration. Before this patch, the compiler used to wrap the original result tuple and thunkedLinearMap into another tuple, and caused the verifier error.
Before the patch:
  return %{{.*}} : $((Float, Double), @callee_guaranteed (X.TangentVector) -> Float)

After the patch:
  return %{{.*}} : $(Float, Double, @callee_guaranteed (Float) -> X.TangentVector)

Before the patch:
  return %{{.*}} : $((Float, Double), @callee_guaranteed (X.TangentVector) -> Float)

After the patch:
  return %{{.*}} : $(Float, Double, @callee_guaranteed (Float) -> X.TangentVector)

Is there a typo in the signature of the linear map in the after section?

Looks good otherwise. Thanks Andrew!

Is there a typo in the signature of the linear map in the after section?

Good catch, thank you.
I've updated the PR description, but not the commit message to avoid re-running CI. We can update it before landing.


inconsistent link to COS directory for model files

the README contains this link to the model files:

http://max-assets.s3-api.us-geo.objectstorage.softlayer.net/pytorch/neuralstyle/neuralstyle.tar.gz

this works. however, it is different than the link in the Dockerfile:

http://max-assets.s3-api.us-geo.objectstorage.softlayer.net/fast-neural-style-transfer/1.0/assets.tar.gz

i would expect both of these to point to the same set of model files.
in addition, both of the links should be pointing to the new US cross region:
s3.us.cloud-object-storage.appdomain.cloud
because the old one has been deprecated:
s3-api.us-geo.objectstorage.softlayer.net

duplicate of #24


would you like to share your pretrained weights?

Yes, I am preparing it

The pretrained weights are available now


Read/Write ?

How do I set up the application for read AND write permissions? In my dashboard I already have my app set to read and write but when a user asks for permission its only asking for read.
I've tried changing my API initializing  as well but it's not working.
const twitter = new twitterAPI({
    consumerKey: 'y7zrtwertwretPZjguuz7P',
    consumerSecret: 'DGjjetyytejwrtT',
    callback: "http://localhost:8080/api/authenticate",
    x_auth_access_type: 'read and write'
});

Had to just add a link to the privacy policy lol >.>


install by pip in anaconda's virtual env (windows), raise this error when importing

import pyanime4k
Traceback (most recent call last):
File "", line 1, in
File "C:\Users*\Anaconda3\envs\mpegtorch\lib\site-packages\pyanime4k_init_.py", line 9, in
import pyanime4k.error
File "C:\Users*\Anaconda3\envs\mpegtorch\lib\site-packages\pyanime4k\error.py", line 9, in
from pyanime4k.wrapper import *
File "C:\Users*\Anaconda3\envs\mpegtorch\lib\site-packages\pyanime4k\wrapper_init_.py", line 9, in
from pyanime4k.wrapper.acwrapper import *
File "C:\Users*\Anaconda3\envs\mpegtorch\lib\site-packages\pyanime4k\wrapper\acwrapper.py", line 22, in
os.path.join(curr_path, ac_lib[platform.system()]))
File "C:\Users*\Anaconda3\envs\mpegtorch\lib\ctypes_init_.py", line 434, in LoadLibrary
return self._dlltype(name)
File "C:\Users*\Anaconda3\envs\mpegtorch\lib\ctypes_init_.py", line 356, in init
self._handle = _dlopen(self._name, mode)
OSError: [WinError 126] 找不到指定的模块。

python 3.7.2

In old version of python(<3.8), you need add dll libs (C:\Users*\Anaconda3\envs\mpegtorch\lib\site-packages\pyanime4k\wrapper\)  to PATH environment variables.

I have fixed it, please upgrade pyanime4k by pip.

I have upgraded pyanime4k but the problem still appears

v2.2.7？

please try to add dll libs (C:\Users*\Anaconda3\envs\mpegtorch\lib\site-packages\pyanime4k\wrapper) to PATH environment variables, if not work, please install vc runtime 2017

Are you running in a local environment or on a server?

local environment
and i'm trying to install vc runtime

is this right?

yes, it is

I have installed it, but the problem still appears...

This problems is beacuse of missing dlls, I don't think there are something still missing. Try to use Python3.8. And what's your video card, some old card doesn't support OpenCL will get this problem too.

My video card is Nvidia 1070. Seems using python 3.8 is the only way

I tested v2.2.6 in python3.7.7, got same problem and fixed it, now everything worked fine, so I'm not sure what's going on now.

conda create -n your_env_name python=X.X

Maybe it's because I installed vs2017 and vs2015? How did you fix it? Installing vc runtime?

No, I added the dll folder to os.environ['PATH'], same as adding system environment variables.

I just tested it in anaconda with python3.7.7 with pyanime4k v2.2.7,  everything worked fine.

Fine, maybe my system has some unknown problems.

I successfully run it in Ubuntu.


Spurious warning

Repro provided by Noel Cross.
Delegate-Repo.zip

Trying to figure out which warning this is about. Is it 4265 "class has virtual functions, but its non-trivial destructor is not virtual; instances of this class may not be destructed correctly"?

The warning in question is

C5205: delete of an abstract class winrt::impl::implements_delegate<winrt::Windows::Foundation::TypedEventHandler<winrt::Windows::Foundation::IInspectable,winrt::Windows::Media::Devices::DefaultAudioRenderDeviceChangedEventArgs>,H> that has a non-virtual destructor results in undefined behavior

This is a real bug, which was fixed in PR 278 in the old xlang repo for build 190405.3. The 18362 SDK comes with build 190111.3 which doesn't have the fix.


[FR] Support telekasten links for backlinking in taskpaper plain-text formatted documents

Please confirm

[X] I am running the latest version of this plugin

Is your feature request related to a problem? Please describe.
No. More an extension of the nice functionality in telekasten for linking.
Describe the solution you'd like
I would like Taskpaper plain-text todo formats (I am working on enhancing the plugin for this in nvim) to be able to use telekasten links of the [[something]] variety in task and project descriptions.
The idea being here that you would then be able to check backlinks on [[something]] and see all Taskpaper tasks or projects related to a particular person or thing (in theory).
Example
Coding:
    Lua:
        - Remember to speak to [[renerocksai]] about supporting taskpaper in telekasten.
           *What is required to make this work with both tasks and notes*
    GoLang:
        - Update [[harsh]] to Go 1.18 and release via goreleaser @due(2022-04-08)

Describe alternatives you've considered
I've thought of changing the taskpaper format in some fundamental way to support this kind of linked "roam" functionality, but it would be soooooo much nicer if it were easily baked into telekasten. I just need to figure out how to work in conjunction to make this work. Also, makes tk a much more robust plain-text for your life solution if you have notes and todos in plain-text all usable and linked.
Additional context
https://support.omnigroup.com/omnifocus-taskpaper-reference/
https://github.com/jessegrosjean/birch-outline

To be sure I understand it properly:
You would like a function like follow_link() but instead of looking in the zettel home, it looks in a folder for your task notes. Is this correct?
I have a few follow-up

How would you (the user) know if [[some text]] is a zettel or a task?
Should TK try to differenciate it itself (you use follow_link no matter what and somehow TK knows what you want), or the idea of a separate function would do it?
Wouldn't it be better if there were a different type of link for task, so we could set a custom highlight for that and make TK differenciate both without requiring a new function?
If so, what would be the link format for tasks?

I think a following extension to that extension would be to have the possibility to show all notes that link to the same task.

@lambtho12
Thanks for picking up the ticket.
Taskpaper is a simple plain text, hierarchical format for Project and task management made (semi) famous by Hog Bay Notebook. It's pretty simple syntax based on indentation and the presense (or absence) of a : end o line for a project, a - to denote a task and @ for tags and such. Basic plugins for vim already exist for it (but I'd like to write a much better one) and a great package for emacs exists.

As a link to a taskpaper note would have a .taskpaper or .todo extension, rather than .md for a zettel, I imagine we could use that to differentiate the link
Mostly I originally saw the functionality as merely allowing me to have people and things linked and then checking backlinks to a page (ie. I click through on [[harsh]], it takes me to my page on that, and then I can use the backlinks look to see all mentions of harsh in both zettels and tasks. In particular though, I like the idea of being able to see all tasks in tasks paper related to a link (for example, all the task I had for hash in my taskpaper.)
And yes, I love the idea of a differentiated link if you are pointing at a specific task
Though we'd probably have to invent a new link type and syntax since a link would be quite long [[2022ToDos.todo/Projects/Perso/harsh]] could point at the project  nested under Projects/Personal/harsh but I am not sure how you'd reference an actual task itself off the type of my head.

Great questions! My use case is somewhat similar to what I do with org-roam in emacs currently. I use an org-roam link like say harsh and then can look at all the linkages into harsh in another (usualyl 1/3 screen buffer). The big thing I'd want for this though and I thinkt he advantage from the perspective of telaksten (and killer feature) would be able to see all the tasks listed that point in towards that task in the preview windows (or to cycle through them as this would be great since you could see what us done or not for a particular backlink. (hope that is a clear explanation.).

Thanks for picking up the ticket.

Lets not get carried out :smile: , I just ask questions so I can see if it is something that I can do myself of if we need to wait for the great return of renerocksai and his legendary skills. Now that I am a contributor, I think I will first devote the little time I have on bugs instead of new features. So this might have to wait a bit.

That does not mean we can not brainstorm a bit more :wink:
In my opinion the best approach would be a custom link format, like [{link to task}] or [(link to task)]. With that, we could probably reuse the majority of existing functions. It would just need a small regex check to determine the type of link and look in the right place after that. Regarding backlinks, it could be even simpler as we could always show all backlinks (both in zettels and tasks). We could even put an option so people can decide in their config or implement custom shortcuts to do each case.


Pass payload/arguments through to thunk?

One thing I'm finding myself wishing for is a way to get the arguments passed from the action creator to the thunk without having to create the function on the fly, e.g.:
function createTaskThunk(dispatch, getState, taskAttrs) {
  dispatch...
  fetch...
    success => dispatch...
}

function createTask() {
  return createTaskThunk;
}

Partly just a stylistic preference, but this also avoids having to instantiate a new function  on every call vs:
function createTask(taskAttrs) {
  return (dispatch, getState) => {
    dispatch...
    fetch...
      success => dispatch...
  };
}

I also like to be able to write tests against what gets dispatched, so if we can have a constant function, we can write tests like:
expect(dispatch).toHaveBeenCalledWith(createTask());

Is there a way that something like this can be accomplished with redux-thunk?

You can do it, but you need to create a new bindActionCreators from redux
function bindActionCreator(actionCreator, dispatch) {
  return (...args) => {
        dispatch((dispatch,state)=>{
             actionCreator(dispatch,state,...args)
        })
    }
}

then you can write your action thunks like so
function createTaskThunk(dispatch, getState, taskAttrs) {
  dispatch...
  fetch...
    success => dispatch...
}

full replacement for bind action creators is here
https://gist.github.com/nullberri/4e6672536c73573c1583725f59b0c884


node.getScript can't find reference when game is published

I have a behavior script creating a prefab. When the prefab loads I'm getting the prefabs attached script using the getScript method [ex. myPrefab.getScript("scriptName")]. This works great in the editor. The problem happens when I publish the game. I get an error saying that it can't find the reference to "scriptName".
I have a temporary solution where I'm just using myNode.scripts[0].

You should use full className with package,  .getScript("a.b.c.YourClass') Not .getScript("YourClass')

Cool that works. Thank you!


Why the locks?

I'm curious why you chose to use a pool of entropy state with locks around it here rather than calling SecureRandom during generation?

👋🏻 It's a good question. Some of the answer is historical and may not be valid anymore. I haven't benchmarked again in awhile.

I was benchmarking throughput of the new UUID versions against the standard SecureRandom.uuid and needed to hit higher throughput numbers. The pool of bytes from SecureRandom.bytes had an faster amortized runtime than hitting the cryptographically secure randomization source every call.
The locks around the top-level Uuidx.vX methods are there because those simple APIs wrap a single generator. If that generator is used from multiple threads, there are theoretical order of operations that could yield the same UUID based on the shared generator state. For example, 2 calls to a v6 generator could theoretically get the same 100ns resolution timestamp and generate the same clock sequence if context switched around the compound assignment.
So, I basically decided to push the locks out to the simple API and allow manual construction of each generator for anyone that wants 1 per thread or whatever other use-case there might be.


Add Unity version defines

Part of #607

ParticleSystemForceField is Behaviour on Unity 2021.3 and higher instead of Component and is matched in earlier case
UnityEngine.XR.WSA.WorldAnchor is removed on Unity 2020.2 and higher
ParticleSystem.CollisionModule.maxPlaneCount is obsolete on Unity 2020.2 and higher

Could you use docs: instead of doc:?


package_info_plus for linux returns empty packageName

expected to return name from pubspec.yaml or, (BINARY_NAME or APPLICATION_ID) from CMAKELists.txt, but at least an App's identifier.

Confirmed that on Linux the Package Name appears as "Not set" when running the example:

On MacOS it appears io.flutter.plugins.packageInfoExample in contrast.

@jpnurmi can you take a look at this when you have time?

The package information is fetched from version.json which is written by the Flutter tool. For some reason Flutter does not write any package name there:
https://github.com/flutter/flutter/blob/49733a485075305b2e62edf9cfe4dbffe901d72e/packages/flutter_tools/lib/src/project.dart#L349

correct, that also applied to web I don't think we can do much here unless we figure out why there is no packageName in version.json, I have opened an issue here, let's see if we get any response. https://github.com/flutter/flutter/issues/84107

I sent a PR https://github.com/flutter/flutter/pull/88457

@mhadaily should package name be added to package_info_plus_linux and package_info_plus_web although with its current implementation(from your PR flutter/flutter/#88457) it would return the same app name for both web and linux package_name ?

yes please do that @fabiancrx and @jpnurmi will review later. thank you


Issues with running commands on Visual Studio

Hi @ranaroussi ,
The static output works fine on visual studio but charts are not showing any output.
1
qs.plots.snapshot(df0['PPL_Return'], title='PPL Performance')`
This command runs but no output is displayed. Is there any other command to add so that output can be displayed?

Hi @ranaroussi,
I too am having this same problem. I am running Python 3.9 in Visual Studio. This produces a quick flash like it is attempting to show a graph but then I see nothing.
s = qs.utils.download_returns('AAPL')
qs.plots.snapshot(s, title='AAPL')
I've looked at the snapshot code but I can't see anything that might cause this.
Thanks!


Lint error: ruff doesn't support pyupgrade anymore

System Health details
N/A
Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of currently previous issues..

Describe the issue
Github lint step always fails:
Run python3 -m ruff check .
error: Failed to parse `/home/runner/work/retry/retry/.ruff.toml`: TOML parse error at line 44, column 2
   |
44 | [pyupgrade]
   |  ^^^^^^^^^
unknown field `pyupgrade`, expected one of `allowed-confusables`, `builtins`, `cache-dir`, `dummy-variable-rgx`, `exclude`, `extend`, `extend-exclude`, `extend-include`, `extend-ignore`, `extend-select`, `extend-fixable`, `extend-unfixable`, `external`, `fix`, `fix-only`, `fixable`, `format`, `force-exclude`, `ignore`, `ignore-init-module-imports`, `include`, `line-length`, `tab-size`, `required-version`, `respect-gitignore`, `select`, `show-source`, `show-fixes`, `src`, `namespace-packages`, `target-version`, `task-tags`, `typing-modules`, `unfixable`, `flake8-annotations`, `flake8-bandit`, `flake8-bugbear`, `flake8-builtins`, `flake8-comprehensions`, `flake8-errmsg`, `flake8-quotes`, `flake8-self`, `flake8-tidy-imports`, `flake8-type-checking`, `flake8-gettext`, `flake8-implicit-str-concat`, `flake8-import-conventions`, `flake8-pytest-style`, `flake8-unused-arguments`, `isort`, `mccabe`, `pep8-naming`, `pycodestyle`, `pydocstyle`, `pylint`, `per-file-ignores`, `extend-per-file-ignores`

Error: Process completed with exit code 2.

The root cause is this PR, which removed pyupgrade from ruff.
Reproduction steps
Link to Github job example: here.
Debug logs
N/A

Diagnostics dump
N/A

ruff is not updated in this repo..
see #110

(Sharing my investigation information just in case it helps, but keeping the bug closed)
@ludeeus , the problem seems to be in .ruff.toml and is not related to the library version. This PR changed the schema of the file, and [pyupgrade] section is not allowed anymore.


Add setup.py and release script for pypi

Hi @cjlin1, this PR is to add setup.py and release script for python bindings so that we can get them easily from pypi. The motivation behind this is:

python-libsvm from ubuntu package list does not link to the active python environment (tried several times on different containers, and only linked to python 2.7). After inspecting the install script, the content of /var/lib/dpkg/info/python-libsvm.list is this:

/.
/usr
/usr/share
/usr/share/pyshared
/usr/share/pyshared/svmutil.py
/usr/share/pyshared/svm.py
/usr/share/doc
/usr/share/doc/python-libsvm
/usr/share/doc/python-libsvm/copyright
/usr/share/doc/python-libsvm/README.gz
/usr/lib
/usr/lib/python2.7
/usr/lib/python2.7/dist-packages
/usr/share/doc/python-libsvm/changelog.Debian.gz
/usr/lib/python2.7/dist-packages/svmutil.py
/usr/lib/python2.7/dist-packages/svm.py

Though you can manually link libsvm binding to your active python environment simply by appending to sys as such:
>>> import sys
>>> sys.path.append('/usr/share/pyshared')

Package to fix similar problem is out there (e.g https://github.com/Salinger/libsvm-python), but would be nice that this binding is rather streamlined with this project and always updated to the current version. Had an issue over here (https://github.com/bukalapak/pybrisque/issues/4) because the binding version isn't compatible with the shared library (apparently it's fine using libsvm 3.21 distributed on Ubuntu 18.04 with python binding 3.14 on that particular project). If the binding is available on pypi for every version, we can easily match it with the shared library from distribution.

Having this binding on pypi would fix another problem on some situation: e.g in pybrisque (https://github.com/bukalapak/pybrisque/blob/master/setup.py), we want libsvm's python binding to be installed right away when user installs pybrisque, but since it's not on pypi, we had to do it using dependency-links. But since process-dependency-links is obsolete in pip >= 19, we couldn't do this anymore. Of course we can alway ask users to install the binding separately, but the former is just easier to the user.

I've put a test package from this PR here https://test.pypi.org/project/libsvm/, you can try to install with this command: pip install -i https://test.pypi.org/simple/ libsvm
Thank you. Cheers

In case it is too much hassle for you to provide the binding on pypi, I am happy to keep my fork up to date with the upstream and release the package on pypi..


Detecting the types automatically when running queries

Motivation
Currently we need to pass the type of the contents twice when we use the Content Delivery client:
deliveryClient.items<Movie>()
  .type('movie')
  .orderParameter('elements.title', SortOrder.desc)
  .getObservable()
  .subscribe(response => console.log(response));

but we already have a mapping defined when we create the deliveryClient:
const deliveryClient = new DeliveryClient({
    projectId: 'xxx',
    typeResolvers: [
        new TypeResolver('movie', () => new Movie()),
    ]
});

Proposed solution
.items<T>() should get information from the typeresolver and apply it to the rest query. and we shouldn't need to have the .type('content_type') call again
deliveryClient.items<Movie>()
  .orderParameter('elements.title', SortOrder.desc)
  .getObservable()
  .subscribe(response => console.log(response));

Additional context
When we use a type safe language like Typescript and we define a mapping in the constructor, we shouldn't use the hardcoded type string in every query. Since type is passed in the first statement it sets the scope of the query and that can resolve the static name of type to be passed to following operator functions.

Hi @mahpour,
Thank you for submitting an issue on our GitHub!
What you are suggesting can and does work in certain languages (C#, Java...), but cannot work with TypeScript as all types are essentially stripped when compiling to JavaScript and this information is not available at runtime.
In order for this to work you would have to pass constructor so that you would have:
deliveryClient.items<Movie>(Movie)
  .type('movie')
  .orderParameter('elements.title', SortOrder.desc)
  .getObservable()
  .subscribe(response => console.log(response));

But that kind of beats the purpose and is not really necessary. If you don't want to use strings for identifying your types I would recommend using string enums such as:
enum ContentType {
    Movie = "movie",
    Actor = "actor",
}

deliveryClient.items<Movie>()
  .type(ContentType.Movie)
  .orderParameter('elements.title', SortOrder.desc)
  .getObservable()
  .subscribe(response => console.log(response));

Alternatively you could also define type instead of enum:
type ContentType = 'movie' | 'actor';

Closing, but feel free to let us know if you have any further questions.

I reviewed the code for deliveryclient here
here's the items method signature
items<TItem extends ContentItem>(): MultipleItemQuery<TItem> {
    return new MultipleItemQuery<TItem>(this.config, this.queryService);
  }

this.config is referring to the configuration object which holds the type resolver definitions here
/**
     * Array of resolvers that are used to create instances of registered classes automatically.
     * If not set, items will be instances of 'ContentItem' class
     */
    typeResolvers?: TypeResolver[];

the same mapping configuration data is also available in the type method but we are explicitly passing the type in and that can create confusion of the logical type we are passing to items method and the name used in type. even the proposed solution of using enums will not avoid sdk users from making mistakes.
we can use typescript instanceof or typeof operator to find the TItem type among the mapping data in typeResolvers property of config object at deliveryClient object and use its key to add more to the queries needed in the API.

Yes, that is correct - you may use instanceof because the content items are resolved using the type resolvers. However, typeResolver is identifying by system.type attribute of each content item and not by generic type passed to method - that is not possible to do in TypeScript.
Passing generic argument to items or item method is only for your benefit and so that you get intellisense, but it has no other use. For example, following 2 calls will produce identical results:
deliveryClient.items(Movie)
  .type('movie')
  .orderParameter('elements.title', SortOrder.desc)
  .getObservable()
  .subscribe(response => console.log(response));

deliveryClient.items<Movie>(Movie)
  .type('movie')
  .orderParameter('elements.title', SortOrder.desc)
  .getObservable()
  .subscribe(response => console.log(response));

In many cases the items response can contain content items from different types and in this case you could use ContentItem generic argument to access common properties (e.g. system, elements...), but you still want those items to be mapped and so instanceof will work for each mapped content item.

That makes more sense now. Thanks for clarification. 🙂


Issue fixes

@MahmoudElSharkawy this PR is still under development/testing.
I'm fixing all the testing issues and I found some hidden issues as well with the configuration manager and other tiny tweaks here and there.


Adds an option to strictly enforce single recipients for emails

Devise sends email containing sensitive values such as confirmation URLs, password reset URLs, and unlock URLs. In most (all?) cases, these should only be sent to a single person so that they alone can click the link. If the email is sent to multiple addresses, another person could click the link.
Set Devise.strict_single_recipient_emails to an array of actions to raise an error when the email would be sent to more than one email address.
By default Devise is secure:

Devise.email_regexp will reject email addresses containing separators (,;)
Devise gets a single email address from record.email

However, when using opts, and particularly if providing untrusted user input to opts, multiple values could be present in to:, cc:, or bcc:.
Example:
# POST https://your-app.com/customised-reset-password?email[]="attacker<EMAIL_ADDRESS>
# Returns the victim's user
user = User.find_by(email: params[:email])

# unsafe, will send the link to two addresses:
Devise.mailer.reset_password_instructions(user, 'fake-token', {to: params[:email]})

# safe, devise will use the user's email address
Devise.reset_password_instructions(user, 'fake-token')

# safe, will raise error:
Devise.strict_single_recipient_emails = [
  :confirmation_instructions,
  :reset_password_instructions,
  :unlock_instructions
]
Devise.mailer.reset_password_instructions(user, 'fake-token', {to: params[:email]})

This work is similar to what I introduced at GitLab, but disabled by default and more configurable:
a) to avoid breaking changes,
b) to make it easier to enable for a subset of actions
GitLab MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/145753
This is my first contribution to Devise - very happy to receive feedback and change things up as needed ❤  Also fine if you'd rather not include this change 👍

This is ready for review @carlosantoniodasilva 🙇

👋 @carlosantoniodasilva do you or another contributor have capacity to review this? If it's not a contribution that's a good fit, I can close it 👍
Thanks for all the time & effort you put in to devise.


FileNotFoundError: [Errno 2] No such file or directory: '/home/Storm/anaconda3/envs/tensorflow/lib/python3.6/site-packages/vis/utils/../../resources/imagenet_class_index.json'

when I run the 'keras-vis/examples/vggnet/activation_maximization.ipynb', the error happens when it reaches the part in the following pictures

This issue is the bug of vis.utils.utils.get_imagenet_label.
It should be fixed.
However, @tianyu0523, If you need to run the examples immediately,
Please do it on environment that keras-vis isn't installed via pip.

Actually, 'get_imagenet_label()' does not exist in the file '\keras-vis\vis\utils\utils.py'. Could you please tell me how to install the keras-vis?

Umm...
get_imagenet_label() was renamed lookup_imagenet_labels() in below commit.
And, This issue is existing in lookup_imagenet_labels(). maybe.
https://github.com/raghakot/keras-vis/commit/56198ddddd47ac1ff9867a60496ae0ffb6f12ea1#diff-42bb00f72e593fae535671061ddf7bbb

Could you please tell me how to install the keras-vis? @keisen

I did as follows.
$ git clone https://github.com/raghakot/keras-vis.git
$ cd keras-vis
$ pip install .... # other than keras-vis
$ jupyter notebook

In addition, the following code was added to the first line of the first code cell of example.
import sys
sys.path.append('../../')

It's not smart, haha.

Sorry, I had not answered your question accurately.
I install keras-vis as follows.
pip install git+https://github.com/raghakot/keras-vis.git@#{commit-id}


AssertionError during discrete parameters

@fmfn
Hi, dear
Thanks for this library.
I want to do bayesian optimizer for discrete parameters, simply code like below, I follow advance tour:
import os
import sys
from bayes_opt import BayesianOptimization
def func_with_discrete_params(dim, bottleneck_dim):
    print(dim,bottleneck_dim)
    assert dim % 32 == 0
    assert bottleneck_dim  % 32 == 0
    result = dim+bottleneck_dim
    return result

def function_to_be_optimized(dim, bottleneck_dim):
    dim = int(dim)
    bottleneck_dim =int(bottleneck_dim)
    return func_with_discrete_params(dim,bottleneck_dim)

optimizer = BayesianOptimization(
    f=function_to_be_optimized,
    pbounds={'dim': (1024,1536 ), 'bottleneck_dim': (128,256)},
    verbose=2,
    random_state=1,
)

optimizer.maximize(
    init_points=2,
    n_iter=4,
)

but I get the error below, how can fix it?
|   iter    |  target   | bottle... |    dim    |
-------------------------------------------------
1392 181
Traceback (most recent call last):
  File "/home/sokhan/.local/lib/python3.6/site-packages/bayes_opt/target_space.py", line 191, in probe
    target = self._cache[_hashable(x)]
KeyError:<PHONE_NUMBER>019295, 1392.806140642385)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 3, in <module>
  File "/home/sokhan/.local/lib/python3.6/site-packages/bayes_opt/bayesian_optimization.py", line 185, in maximize
    self.probe(x_probe, lazy=False)
  File "/home/sokhan/.local/lib/python3.6/site-packages/bayes_opt/bayesian_optimization.py", line 116, in probe
    self._space.probe(params)
  File "/home/sokhan/.local/lib/python3.6/site-packages/bayes_opt/target_space.py", line 194, in probe
    target = self.target_func(**params)
  File "<stdin>", line 4, in function_to_be_optimized
  File "<stdin>", line 4, in func_with_discrete_params
AssertionError

best regards

assert dim % 32 == 0
this line states that the residual of dim/32 should be 0. it isn't, hence the error.

in probe
target = self.target_func(**dict_params)？

target = self.target_func(**dict_params)
    if self._constraint is None:
        self.register(x, target)
        return target

    constraint_value = self._constraint.eval(**dict_params)
    self.register(x, target, constraint_value)
    return target, constraint_value

line 431, in probe
target = self.target_func(**dict_params)，Why?


Add copy command from terminal

Description:
I would like to propose the addition of a feature in Visual Studio Code that allows users to easily copy commands directly from the integrated terminal using mouse right click
Use Case:
Often, while working in the terminal integrated into VS Code, I find myself needing to reuse or share commands with others. Currently, the process of copying commands involves manual selection, right-clicking, and selecting "Copy," which can be time-consuming. This feature aims to streamline this process for improved efficiency.

@meganrogge pls assign this issue to me

why don't you press "assign yourself"

This already exists. Click the command decorations and select copy command.


[WIP] SCIM Patch Demo

Changes

Tests

[ ] make test passing
[ ] make fmt applied
[ ] relevant integration tests applied

Codecov Report
Patch coverage has no change and project coverage change: -0.02 :warning:

Comparison is base (44b51b5) 18.73% compared to head (80e8af7) 18.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   18.73%   18.71%   -0.02%
==========================================
  Files          85       85
  Lines        9229     9237       +8
==========================================
  Hits         1729     1729
- Misses       7351     7359       +8
  Partials      149      149

Impacted Files
Coverage Δ

service/iam/model.go
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Remove io component of PCL.

The io component of PCL brings in VTK, which in turn creates a lot of CMake pollution (such as bringing in Qt, which is completely unnecessary for cartographer_ros).

Thanks!
@wally-the-cartographer merge

Merge requested by authorized user SirVer. Merge queue now has a length of 1.


Improve consistency between Git and API formula handling

I intended to open a PR for this a while back but never did.
It's WIP and I'll hopefully revisit it within the next month. There's been minimal changes since I last presented this (main change is keg_only_reason being now supported).

Review period will end on 2022-03-01 at 14:36:56 UTC.

Review period ended.

Caching is something I've largely ignored. I feel like we should probably investigate what we have as we currently have three caching mechanisms: factory caching, Formulary#cache and the namespace management. The latter is needed for marhsalling reasons etc and wasn't introduced for caching (but is able to work as one), so it's worth investigating whether the former two is actually adding much on top of that.

Agreed that this is worth investigating 👍🏻

I've looked a bit more into the caching and it looks like we do two things:

We always cache when loading a formula from a file path. When loading a formula from a file, we first check to see if the path is in the cache and if so simply return the class that is cached. Here, the formula class (e.g. Formulary::FormulaNamespaceb684604c8244a5905bc797f4e22cc31f::Wget) is cached
We sometimes cache all formulae, regardless of how they're loaded. This is the "factory cache" and needs to be explicitly enabled (which is only done in uses, deps, and unbottled at the moment). When enabled, we create a cache key from the parameters passed to ::factory and compare that with the factory cache. If there's a match, we return that formula and skip the rest of the loading process. Here, the formula instance is cached
If we load from the API or a formula's contents (i.e. from a bottle), we don't have any caching

I'd suggest that we scope the cache to be type-dependent. Meaning, having a separate cache for loading from path and from the API. That way, there's no risk of accidental overlap if we somehow try to load the same formula from the API and a file.
We also could add caching when loading from a bottle, potentially using the bottle path as a cache key. We could also use e.g. a hash of the contents as a cache key. This might help speed up loading from a bottle since we won't need to read the file contents each time, but is also probably outside the scope of this PR.

For consistency, one important thing to note is that loading formulae and casks from the API will take precedence over loading from an installed keg/cask. This is intentional since it mimics the way things work without the API: the most recent version is loaded, even if an installed version is older.

Yeah I agree. Formula files in kegs can get stale. Casks use their equivalent a lot more than the formula side and there have been countless bugs caused by that. One of the goals here was to avoid needing to use them.

Overall, I'm very pleased with how this approach is looking since I've been able to remove a ton of those conditionals. It makes everything feel much more integrated and less like an add-on.

Excellent. That's exactly what I wanted to see the API code become. It's a lot easier to maintain not having to have two different code paths everywhere.

The new brew update process will need to be looked at to make sure that things like tap/formula migrations still are noticed

Is there even an API endpoint for that yet?

There are certain commands (e.g. brew update) that feel like they run slower now since they need to parse the huge formula.json file.

How long doe parsing the file take?

One thing to address at some point (not now) is download integrity.
This could be using standards like JWS, or potentially something more custom if we really want to shoehorn it into existing endpoints.

Is there even an API endpoint for that yet?

Nope

How long does parsing the file take?

Here are the results of some tests I just ran using hyperfine:

Command
Average Time Without API
Average Time With API

brew outdated
702.9 ms
5.076 s

brew ruby -e 'Formulary.factory("abcde")'
935.7 ms
1.416 s

I wonder if there's something else going on in brew update that explains why it takes 70 times longer. More testing can definitely be done.

One thing to address at some point (not now) is download integrity.
This could be using standards like JWS, or potentially something more custom if we really want to shoehorn it into existing endpoints.

Good point, thanks for bringing it up. I don't really know anything about this kind of thing so I'll have to look into it more in the future

Good point, thanks for bringing it up. I don't really know anything about this kind of thing so I'll have to look into it more in the future

I know about JWS at least so if we go that route feel free to ask me about it at the time.

For consistency, one important thing to note is that loading formulae and casks from the API will take precedence over loading from an installed keg/cask. This is intentional since it mimics the way things work without the API: the most recent version is loaded, even if an installed version is older.

Yeah I agree. Formula files in kegs can get stale. Casks use their equivalent a lot more than the formula side and there have been countless bugs caused by that due to our deprecation turnover. One of the goals here was to avoid needing to use them.

we need the latest information anyway for brew outdated etc

Also agreed 👍🏻

I wonder if there's something else going on in brew update that explains why it takes 70 times longer. More testing can definitely be done.

Tried playing with brew prof here? If the answer is "I'm not sure how to do that": shout and I'll give you a hand.

Great! Thanks for getting this started and helping out, @Bo98!


Test Center Server == LabServer?

Hello,
Does this client require Spirent LabServer to be installed?
In other words, if I have STCv, what are my options to use REST API agains the virtual chassis? LabServer only?

yes, this client requires labServer. There is no other option for this client at the moment.

Is it still the case that the REST API requires LabServer? We're running STC v4.81 on a Windows box. Thanks.

You can now use STC’s REST API without LabServer.  It is called “stcweb”, and you can run it from a Windows box.
From: Assil Ksiksi<EMAIL_ADDRESS>Reply-To: Spirent/py-stcrestclient<EMAIL_ADDRESS>Date: Tuesday, October 9, 2018 at 9:09 AM
To: Spirent/py-stcrestclient<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [Spirent/py-stcrestclient] Test Center Server == LabServer? (#4)
Is it still the case that the REST API requires LabServer? We're running STC v4.81 on a Windows box. Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Spirent/py-stcrestclient/issues/4#issuecomment-428253451, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMJQv3G9Pe1WCIWhHb3Ci_B9KiBVZpTPks5ujMpBgaJpZM4M-axP.