Support Intellij env file configuration for Oauth2

Hi @AnWeber, first of all thanks a lot for providing the plugin with all its features!
Relatively recently IntelliJ has introduced Oauth2 support for the http-client in IntelliJ Ultimate.
The public env file can now be configured according to this documentation:
https://www.jetbrains.com/help/idea/oauth-2-0-authorization.html#create-authentication-configuration
I've been trying to get this new configuration to be correctly recognized by httpyac and authorize my requests accordingly but so far have not been successful.
My public env.json file is structured like this:
{
  "local": {
    "Security": {
      "Auth": {
        "auth-id": {
          "type": "OAuth2",
          "Grant Type": "Password",
          "Client Credentials": "basic",
          "Client ID": "clientId",
          "Client Secret": "{{clientSecret}}",
          "Username": "{{username}}",
          "Password": "{{password}}",
          "Token URL": "{{tokenUrl}}"
        }
      }
    }
  },
  "tst": {
    "Security": {
      "Auth": {
        "auth-id": {
          "type": "OAuth2",
          "Grant Type": "Password",
          "Client Credentials": "basic",
          "Client ID": "clientId",
          "Client Secret": "{{clientSecret}}",
          "Username": "{{username}}",
          "Password": "{{password}}",
          "Token URL": "{{tokenUrl}}"
        }
      }
    }
  }
}

My private env.json file is structured like this:
{
  "local": {
    "username": "",
    "password": "",
    "baseUrl": "",
    "tokenUrl": "",
    "authUrl": "",
    "clientSecret": ""
  },
  "tst": {
    ...
  }
}

The authorization of my requests is according to the IntelliJ documentation and looks like this:
GET {{baseUrl}}/PATH/API
Authorization: Bearer {{$auth.token("auth-id")}}

When I run my requests like this, I get the following error message: $auth is not defined
Am I missing something in the documentation, that points out how to configure auth with this kind of structure for my env.json files?
If I understand the docs here: https://httpyac.github.io/guide/variables.html#oauth2-openid-connect correctly I would have to change my authorization for each request and change the structure of my private env.json file when switching from IntelliJ to using VS Code with httpyac?

@EiKeHe Yes, agree that you should implement the interface. I would have tried it before, but there was no documentation online at the time. But there is now. I'll have to see about installing an Intellij IDE again to extract the current interfaces from the JAR.
https://www.jetbrains.com/help/idea/oauth-2-0-authorization.html

Thanks for looking into it, @AnWeber!
If there is anything I can help with or more info needed, please let me know!

Maybe you can post the Api (.d.ts) of the $auth Object. You can view the Interface by navigating with mouseclick on the object (go to definition). In Intellij Idea some Resource of a http-client-plugin.jar was opened the last time I used this trick.

Unfortunately that trick did not work for me so far but I will try again in the coming days.
I had a look at the jar for the plugin and found the full json schemas for the envs and figured that they may be helpful, so I´m attaching them here.
http-client.env-schema.json
http-client.private.env-schema.json

Almost. I checked my intellij idea installation on my work machine. In jar idea-IU-231.9161.38/plugins/restClient/lib/rest-client.jar is a folder com/intellij/ws/rest/client/stubs/. My installation contains no API for OAuth2. Maybe I need to update my installation.

I have been looking a the following version of the rest-client plugin: restClient-241.15989.49, which is the latest AFAIK.
It contains the same interface from your last comment. Don´t know if you already updated on your side but this does not seem to change with version number, at least waht I found so far.
I´m attaching my version of the stubs:
stubs_restClient-241.15989.49.zip

I forgot that Intellij has two different interfaces for HttpClientRequest (request vs response). I don't think I support that properly either

Turns out IntelliJ does not even support it yet in their own CLI tool 😁
https://youtrack.jetbrains.com/issue/IJPL-69639/HTTP-Client-CLI-support-OAuth2-password-and-client-credentials-grant-types

Most flows should work, but only tested Password flow, but need to test all flows. I need to understand all properties of the Intellij Auth Config and try to support most of it. And support for ID Token is missing at the moment.
So there are still a few areas that need to be improved.

I release support for Intellij OAuth2 with v6.13

Thanks a lot for for the implementation!
I'll be sure to test it ASAP and see if I run in any issues apart from the list of unsupported features!

@EiKeHe, did you test it with success ? I'm using httpYac 6.14.0 and seems to be have exactly the same error as you initially : $auth is not defined with the same http-client.env.json and .http file as you.
The weird thing is that it seems to detect the authentification file : when I run the query, the authentification process does run. But after I login, it redirect back to my editor and then the error appear.
I also noticed that the Redirect URL that I provide is ignored, and http://localhost:3000 is always used instead.

@Laurent-PRP, yes, I was able to test it successfully and for me at least working via the httpyac VS code plugin I am still able to successfully send the requests we specified using OAUTH2 and the Intellji HTTP Client env files. Admittedly I am not using any redirect and therefor never tested that case.


Use section break helper

If you ask nicely, you shall receive.
Replaces HTML hr elements with the new govuk_section_break helper.

Hmm actually looks like the gem bump has issues?

Looks like the new html_attributes helper orders classes in a different (and more sensible) order. Fixing up spec now.

Ooh, bit more complicated than that:
expected file /home/runner/work/submit-social-housing-lettings-and-sales-data/submit-social-housing-lettings-and-sales-data/vendor/bundle/ruby/3.1.0/gems/govuk-components-3.0.5/app/components/govuk_component/traits/custom_classes.rb to define constant GovukComponent::Traits::CustomClasses, but didn't

An issue to be filed upstream?


Change HttpStatus.ok to HttpStatus.OK

Greg Spencer:
The HttpStatus.ok was renamed from HttpStatus.OK with the most recent
engine roll (which brought in 0.62 of Dart, which changed that enum
name).

No, we can't just rename it back to OK: that's deprecated in the Dart HTML lib.


MAINT: Mark future versions as post releases on the current major/minor/micro

Right now we have released 1.7.9, so future changes are being marked as 1.8.0.dev..., breaking some of our pins.
This change avoids having to guess the next version and just marks as a post-release: niworkflows-1.7.9.post53+g24f54712e.
Alternatively, if there is a way to ensure X.Y.9 -> X.Y.10.dev..., I'm fine with going that route.

The 9 doesn't matter. The question is whether we're on a development or maintenance branch. Builds from maint/1.7.x will be 1.7.10.dev... and builds from master will be 1.8.0.dev.... If you have a bug-fix branch that you are specifically trying to target 1.7.x for, I would do something like fix/1.7.x-description

I see - this originally came up while playing around with the latest developmental versions of the preps on nibabies. Mainly, the problem is smriprep's hard restriction of niworkflows.
So perhaps the best course here is to just remove the compatiblity pin on smriprep's side.

Yes. I would say the maint/0.11.x branch can pin niworkflows ~= 1.7.x, but master should not.


nextOnTargetClick doesn't trigger onNext callback

I'm not sure if this is intended, but currently if you have nextOnTargetClick as true, then the onNext callback won't be fired. Currently, we need onNext fired all the time to stop and start the tour manually as we need the tour to continue after elements are inserted into the DOM (e.g. modals).

Hi @billyvg,
Hmm... looking at the code, onNext should get called regardless of whether it's through interacting with the target element, the next button, or hopscotch.nextStep(). That said, are you relying on the onNext callback to generate the necessary DOM elements that the next step will target? If so, that might be why onNext isn't getting called... if hopscotch can't find a next step, it ends the tour silently.
We're working on a new revision of hopscotch that should clean up some of these issues we're seeing around callback timing. Ideally, we'd call onNext before attempting to find a next step and that will allow you to defer the tour's next step in the event of DOM operations, XHR, or anything else that requires async processing. I'll add this as part of that milestone so we can take this into account.

The callback handler for the element defined at  nextOnTargetClick is targetClickNextFn.
If you trace through the handler, nextStep is called with no parameters, e.g. doCallbacks in changeStep is false, and onNext doesn't get called because of it.

Same like if we set skipIfNoElement as true it wont skip the elements which are not present.


Redirecting from http -> https causes the HTTP verb to change to GET

Do you want to request a feature or report a bug?
Bug

What did you do?

I implemented a redirect from http to https.
Then I tried POSTing to an endpoint in a flask app that sits behind traefik using both http and https prefixes. The POST to https was successful but the POST to http return Method Not Allowed because by the time it reached my flask container, the request had become a GET request
What did you expect to see?
When I POST to https://api.mysite.com it is successful.
When I POST to http://api.mysite.com it redirects to https and is successful, returning the same result as the https call.
What did you see instead?
When I POST to https://api.mysite.com it is successful.
When I POST to http://api.mysite.com the request received by the flask app is a GET request.
Output of traefik version: (What version of Traefik are you using?)

Version:      v1.3.2
Codename:     raclette
Go version:   go1.8.3
Built:        2017-06-29_04:52:35PM
OS/Arch:      linux/amd64

What is your environment & configuration (arguments, toml, provider, platform, ...)?
logLevel = "DEBUG"
defaultEntryPoints = ["http", "https"]
[entryPoints]
  [entryPoints.http]
  address = ":80"
    [entryPoints.http.redirect]
    regex = "^http://(.*)"
    replacement = "https://$1"
    entryPoint = "https"
  [entryPoints.https]
  address = ":443"
    [entryPoints.https.tls]
      [[entryPoints.https.tls.certificates]]
      certFile = "/etc/traefik/ssl/traefik.crt"
      keyFile = "/etc/traefik/ssl/traefik.key"

I build traefik using a docker compose file:
version: '3.2'
services:
  traefik:
    image: my-traefik-image:latest
    command: --configFile=/etc/traefik/traefik.toml --docker  --docker.swarmmode  --docker.domain=mysite.com  --docker.watch  --web
    volumes:
      - type: bind
        source: "/var/run/docker.sock"
        target: "/var/run/docker.sock"
    networks:
      - traefik-net
    ports:
      - 80:80
      - 443:443
      - 8080:8080
    logging:
      driver: json-file
    deploy:
      placement:
        constraints: [node.role == manager]

networks:
  traefik-net:
    external: true

and a Dockerfile:
FROM traefik
COPY . /etc/traefik

And I have a flask app container started with the following labels:
labels:
        - "traefik.port=80"
        - "traefik.docker.network=traefik-net"
        - "traefik.frontend.rule=Host:api.mysite.com"

If applicable, please paste the log output in debug mode (--debug switch)
Debug output from request is:
traefik_traefik.1.x4avy78pi5q1@swarm-manager000000    | time="2017-07-03T18:01:42Z" level=debug msg="Round trip: http://<IP_ADDRESS>:80, code: 405, duration: 3.04713ms tls:version: 303, tls:resume:false, tls:csuite:c02f, tls:server:api.mysite.com"

Also, debug output contains this, repeated every 15 secs or so:
traefik_traefik.1.x4avy78pi5q1@swarm-manager000000    | time="2017-07-03T18:01:50Z" level=debug msg="Filtering container without port and no traefik.port label bbe_celery.1"
traefik_traefik.1.x4avy78pi5q1@swarm-manager000000    | time="2017-07-03T18:01:50Z" level=debug msg="Filtering container without port and no traefik.port label traefik_traefik.1"
traefik_traefik.1.x4avy78pi5q1@swarm-manager000000    | time="2017-07-03T18:01:50Z" level=debug msg="Validation of load balancer method for backend backend-bbe-web failed: invalid load-balancing method ''. Using default method wrr."
traefik_traefik.1.x4avy78pi5q1@swarm-manager000000    | time="2017-07-03T18:01:50Z" level=debug msg="Configuration received from provider docker: {"backends":{"backend-bbe-web":{"servers":{"server-bbe_web-1":{"url":"http://<IP_ADDRESS>:80","weight":0}},"loadBalancer":{"method":"wrr"}}},"frontends":{"frontend-Host-api-mysite-com":{"entryPoints":["http","https"],"backend":"backend-bbe-web","routes":{"route-frontend-Host-api-mysite-com":{"rule":"Host:api.mysite.com"}},"passHostHeader":true,"priority":0,"basicAuth":[]}}}"
traefik_traefik.1.x4avy78pi5q1@swarm-manager000000    | time="2017-07-03T18:01:50Z" level=info msg="Skipping same configuration for provider docker"

I'm new to traefik so my apologies if this is due to my implementation.
Cheers
Dave

Hey @davidwneary when you do a curl -v -L -X POST http://api.mysite.com does it work properly?

Hi @dtomcej,
That is better. The request is a 'POST' when it reaches my flask app with that command. I get a 'Bad Request' response but I get the same when pointing at the https endpoint so this is probably due to my poor curl skills.
What's the cause of the issue then?
Thanks

When you have a redirect (http -> https), the response is returned to the client as a 301/302. What your client does with that is up to it.
curl -L follows these links, and retries the same command to the new location.

Ah I see, I get it now. The issue seems to be that the response gives a 302 and there is a discrepancy between how different clients respond to this. (I'm using Postman which has an issue on github related to this.
It seems a better response code would be 301?
Which it appears there is already an issue for: #671 .
You said above that the response could be either 301 or 302, what determines this at the moment?

Closing this one then, duplicate of #671

Hi there, i'm commenting on this closed issue as i'm not actually sure it was resolved by the answer provided. I've had the same problem, here's the context:

nodejs express server uses package request and request-promise-native WITH parameter followAllRedirects: true
the express app sends a HTTP POST request to our gitlab's URL
traefik handles the request and redirects HTTP POST to HTTPS GET

In this example, i think the express server and request package follow the redirect correctly, but instead of POSTing my request (which is a commit to gitlab), gitlab sees the request as GET and returns a list of commits.
I've changed my logic to use HTTPS instead of HTTP but that's not consistent with the rest of my logic because all other URLS are HTTP, made to be redirected to HTTPS only of they go through traefik, as we also sometimes send direct requests between local containers using HTTP.

Hi @pciavald , would you mind switching to our Community Forum for continuing the discussion, as closed issues are not the best location for that?
BtW, Traefik only answers with 301 and the header Location, so the behavior you meet depends on the HTTP client, not on Traefik. Reference: https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.3.2.


#18451 Don't disable Use Windows trust store option if it was set by DBeaver

Should be disabled ONLY if user set javax.net.ssl.trustStore to any value and/or javax.net.ssl.trustStoreType not equals to WINDOWS_TRUSTSTORE

verified


[GITEA] add new gitea service (release/languages)

This adds an initial Gitea Service with badges for Releases and Language counts. https://codeberg.org/ (A Gitea Compliant website, albeit using a fork of Gitea) is used for most tests with a dedicated repository for testing again for controlled tests
Private Repository support added and the service document updated.
Uses the new openAPI method instead of old examples.
This would contribute towards issue: #4040, with the aim to add more badges/endpoints overtime.

Cool. I've done a bit of testing. Latest changes LGTM.
One final detail.
For both badges, the example we're using is https://codeberg.org/go-gitea/gitea but that isn't an actual project. Can we pick a repo that exists for the example please.

I've updated the examples to point to https://codeberg.org/forgejo/forgejo/ as that's a guaranteed stable repository at codeborg.org. If ever Gitea do a canonical host we can update theirs later.


testRegex defaults to an array, but type is string

💥 Regression Report
https://github.com/facebook/jest/blob/master/packages/jest-config/src/Defaults.ts#L71
Running jest by importing defaults from jest-config yields unusable configs. Currently, testRegex is an array, but should be type string. If I set the string to empty, I get
● Test suite failed to run

    TypeError: config.testRegex.some is not a function

I am already using testMatch, so I can't set both. I assume this should not break when set to an empty string. If I delete the testRegex, it also breaks.
I guess my question is... should it be a string or an array?
To be clear, I'm still trying to upgrade my tests to the latest jest, but it seems like the typescript changes are causing me more problems than help at the moment since I'm using Jest programmatically and not through the normal CLI.
Last working version
Worked up to version: 23.6.0
Stopped working in version: 24.4.0
To Reproduce
Steps to reproduce the behavior:

Create a config by importing defaults from jest-config
Run jest with said config.

Expected behavior
It should run, but what happens is it throws errors and warnings.
Run npx envinfo --preset jest
Paste the results here:

  System:
    OS: macOS 10.14.3
    CPU: (8) x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
  Binaries:
    Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
    Yarn: 1.13.0 - /usr/local/bin/yarn
    npm: 6.5.0 - ~/git/scripts/node_modules/.bin/npm
  npmPackages:
    jest: 24.4.0 => 24.4.0

I need to vet this more, I think I had something wrong with my linking


<alloca.h> included in <bx.h> means you need compat path for msvc, which brings in conflicting <inttypes.h>...

...bear with me:
I've built bgfx + bx + bimg + nanovg + stb_image as a static Windows library. It all builds fine. I've done the same on macOS/iOS/tvOS and have a functioning project using it.
The slight snag on Window is that using this in a separate Windows app means that when <bx.h> is included, it looks for <alloca.h> which doesn't exist on Windows. So then I thought, ok, so I need to make the compat path available to my app, even though all the stuff in there is irrelevant as I'm building using VS2019/C++17....but compat redefines <inttypes.h>, which gets included instead of the system one, which causes an issue with using PRIx64; not exactly sure what, but it doesn't like the (standard) way I'm using PRIx64 so the build fails.
Maybe that's resolvable, but as a principle I don't really want to be dragging in the compat path to my project. It feels like this should be internal to the bgfx/bx/bimg library build. So maybe the alloca can be somehow removed from the bx.h? If I remove it, then string.inl, included by string.h complains.

All build setting bgfx uses are here: https://github.com/bkaradzic/bx/blob/master/scripts/toolchain.lua
CI for VS2019 doesn't have issue you're talking about: https://ci.appveyor.com/project/bkaradzic/bgfx/build/job/09e91himf18sp3o4

Sure - bgfx is building fine but I'm talking about when you then create a separate project linking against bgfx and including the bgfx/bx/bimg header files. bx.h includes <alloca.h> which doesn't exist on Windows.

I ran into this issue too a while ago.
I have a locally patch/fix, that removes inclusion of alloca.h from the public bx.h header, and instead adds it directly to the bx src .cpp files that need it.

PRIx64

This rings a bell. Try adding -D__STDC_FORMAT_MACROS=1 when you're building bx. I don't know about MSVC, but this works with Mingw-w64.
I don't quite remember what the problem was, but i think inttypes.h will define PRIx64 if this is set, or try to undef it, it's not very clear from the description what is the problem with PRIx64 is.

https://github.com/bkaradzic/bx/blob/4a7aa1eb412f389524e0499327a17bef4c8dbdd3/scripts/toolchain.lua#L522-L524

PRIx64

This rings a bell. Try to add -D__STDC_FORMAT_MACROS=1 when you're building bx. I don't know about MSVC, but this works with Mingw-w64.
I don't quite remember what the problem was, but i think inttypes.h will define PRIx64 if this is set, or try to undef it, it's not very clear from the description what the problem with PRIx64 is.

That's not going to change anything when building a project that simply includes bx headers though, right?
In the end I worked around it by adding just the alloca.h file to a compat folder, for the Windows build of my project.

I didn't encounter this problem when including bx headers and it's hard for me to tell what causes it from the description provided. I don't see #include <inttypes.h> in bx.h so i can only guess that it's included somewhere in malloc.h provided with MSVC, i also don't have MSVC so i can't check myself.
If my guess is correct, then you can try to change compat/msvc/alloca.h like this:
#define __STDC_FORMAT_MACROS
#include <malloc.h>
#undef __STDC_FORMAT_MACROS

and see if it helps. But i guess removing inttypes.h can also work.

I also get this error saying "alloca.h" not found when I include bx.h in my source file and build it in VS 2019. What is the simplest solution people have found for this?

If you're using mingw complier, there's an alloca.h header in bx/include/compat/mingw directory.

This rings a bell. Try to add -D__STDC_FORMAT_MACROS=1 when you're building bx. I don't know about MSVC, but this works with Mingw-w64.
I don't quite remember what the problem was, but i think inttypes.h will define PRIx64 if this is set, or try to undef it, it's not very clear from the description what the problem with PRIx64 is.

Any solution?

You just missing include directories


Import pages shows please login (in develop branch)

Hi,
Every time I try import pages, it asks me to login and there is nothing to login

Which authentication method are you using?

Hi,
I used Db.

@torinfo @FayCross as discussed this morning I get this on one of my installs which is 3.12.27 but not on other installations on the same server and same domain. So all should be identical code base as upgraded at the same time so I can't spot where the difference lies.

@torinfo @FayCross have just been exploring this further but still can't spot where the problem lies. I eliminated a few things e.g.
not browser specific
not user specific
not authentication method specific e.g. I switched from db to static and still the same issue
not project specific e.g. happens in all projects and all project types
nothing useful in the debug log
I downloaded a copy of the install directory and database and set that up via xampp and in that copy import pages works without causing the login issue
so same code and same database but xampp rather than the online server and import pages works
however on the same server most other installs import pages works too so wondered if it was php version related especially as a recent clean install of 3.12.27 on the same subdomain does have the same issue
But I tried different php versions and both those install still have the same issue
I don't have proper access to the php error log and as the local copy doesn't have the same problem I can't debug locally.
@torinfo does any of this help identify where the cause might be? Would be good to resolve this as I need to import pages to a live project on this install but also to progress with our 'closing issues challenge!' ;-)

@torinfo this seems like something is causing a session restart or something like that but any ideas where?
I've been testing with 3 separate Xerte installations, and actually more, but all 3 of these are on the same subdomain so subject to the same PHP version and settings etc
/Install1 long time installation upgraded to 3.12.27 uses db authentication results in please login error after selecting import pages
/Install2 recent clean install of 3.12.27 uses db authentication results in please login error after selecting import pages
/Install3 long time installation upgraded to 3.12.27 uses moodle authentication import pages works
Changing the authentication method on Install1 and/or Install2 doesn't change anything e.g. still get the please login error
Don't understand given the above why /Install3 works but the other two don't. Any ideas what to check next and where to look?


Sample code to support AppInsights quickstart

Related PR
I'm opting to put the sample here in the .NET samples repo (as opposed to creating a new repo in the Azure-Samples org) because it's entirely possible we will continue to contribute changes to the Azure docs, and I really don't want to create a new repo in the Azure-Samples org for each of them. It just means more stuff to maintain.

@IEvangelist This is a rare case in which dist should be source-controlled. The directory is part of the Razor Pages project template.

@IEvangelist David Pine FTE This is a rare case in which dist should be source-controlled. The directory is part of the Razor Pages project template.

Yes, I realized that after the fact - and discussed it with Cam directly.


[ceph] Warn on EC pools

EC pools in general perform poorly when compared to replicated pools. While there are genuine use cases for EC, this check adds a generic warning that applications using Ceph could suffer from performance issues.
Fixes #587.

discussed with pon and agreed that while i understand the motivation for this patch, using ec pools is in itself still supproted and valid so printing a warning like this might be confusing to some people.


added use cases for ggplot theme

added use cases for ggplot theme ("theme_trr") in folder additional_code/R

OK. This is now ready to roll, I guess... Thanks!


HCX-796 : API access secret regenerate and expiry

@KrutikaPhirangi - Resolve the feedback comments and conflicts.


How to build it in VS2008 with .NET Compact Framework?

Expected behavior
Open (with or without ninja hacks) some csproj ou sln in VS2008 and build it in .NET Compact Framework
Actual behavior
It opens only in VS2017.
Version of SharpZipLib
Latest.

Compact Framework is currently not supported.
If you want to attempt to get it working, I'd suggest starting with commit 2c458be35c4f21a66aab2f625fdb0e94d93be809 as it used the old solution syntax.
I don't have VS2008 on any of my machines, nor do I have any experience with CF, so unfortunately I have not been able to test this.


Add Client middleware on server configuration

From https://github.com/mperham/sidekiq/wiki/Middleware:

Remember that the jobs running in the Sidekiq server can themselves
push new jobs to Sidekiq, thus acting as clients.

Is this project not maintained anymore?


go-task: init at 2.8.1

Motivation for this change
to add go-task to nixpkgs (a make alternative). This is my first time contributing to nixpkgs so please let me know if there is anything I'm missing or should have done differently. I didn't try building from source because it appears that go-task uses itself in the build
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I updated the formatting too, was previously looking at godot/default.nix as a reference for the style. I didn't know about nixpkgs-fmt, really happy to discover there is a formatter for nix!

I only have one more small worry before merging this. The go-task binary is task, which is the same name as the binary for taskwarrior. This means that users would not be able to install both packages in their profile side by side. Is this a tool people would typically install in their profile or only in e.g. in the nativeBuildInputs of some other derivation? If the former, we may consider renaming the binary to e.g. go-task.

that's a good point, I only started using the tool myself a few weeks ago, but I have it installed via nix-shell for the projects and use it mostly for development. I could definitely see someone having it installed in their profile side by side task warrior. It would probably be best to rename the binary, I will see if I can't get that sorted

that's a good point, I only started using the tool myself a few weeks ago, but I have it installed via nix-shell for the projects and use it mostly for development. I could definitely see someone having it installed in their profile side by side task warrior. It would probably be best to rename the binary, I will see if I can't get that sorted

Looks great now! I have pushed one more small change (a way of handling the version that is more canonical in nixpkgs). I'll merge the PR when ofborg is happy.


SECOND_PAIRS

How and where to insert the second pair?

Seems to be a well kept secret . Most likely have to create your own .

I Have My Version Open For Sale Which Includes Multiple Pairs


thread 'main' panicked, called Option::unwrap() on a None value

Describe the bug
On running cherrybomb with openapi.json,
below error is observed
Starting Cherrybomb...
Opening OAS file...
Reading OAS file...
Parsing OAS file...
Running active scan...
thread 'main' panicked at cherrybomb-engine/src/scan/active/http_client/req.rs:86:53:
called Option::unwrap() on a None value
To Reproduce
Steps to reproduce the behavior:

Run cherrybomb -f openapi.json --profile=full

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Mac 13.6

CherryBomb : Version 1.0.0 (Also built the codebase locally and ran with latest binary. same error observed)

Additional context
Add any other context about the problem here.

Hello, @abnair24! Could you please provide your OAS file? There appears to be a problem with it. I will check that.

@DeliciousBounty , I cant share the OAS as its restricted to company environment. Also file is throwing any issue in any of spec validators.

@abnair24  There is a server section in the file?


fix warnings and run static analyser

@jpivarski - please, consider the following commit that cleans up warning on:
Apple clang version 12.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin19.6.0
Thread model: posix

and silences a multiCondition static analyser warning:
src/libawkward/forth/ForthOutputBuffer.cpp:127:13: style: Expression is always false because 'else if' condition matches previous condition at line 115. [multiCondition]
    else if (std::is_same<OUT, uint8_t>::value) {
            ^
src/libawkward/forth/ForthOutputBuffer.cpp:130:13: style: Expression is always false because 'else if' condition matches previous condition at line 118. [multiCondition]
    else if (std::is_same<OUT, uint16_t>::value) {
            ^
src/libawkward/forth/ForthOutputBuffer.cpp:133:13: style: Expression is always false because 'else if' condition matches previous condition at line 121. [multiCondition]
    else if (std::is_same<OUT, uint32_t>::value) {
            ^
src/libawkward/forth/ForthOutputBuffer.cpp:136:13: style: Expression is always false because 'else if' condition matches previous condition at line 124. [multiCondition]
    else if (std::is_same<OUT, uint64_t>::value) {
            ^

I was just about to try to do that dependent project fix. Thanks for beating me to it!

I was just about to try to do that dependent project fix. Thanks for beating me to it!

@jpivarski - FYI, by reducing the number of includes, especially in the headers, total build plus test time on my Mac went down from 1 min 40 sec to 32 sec.

@jpivarski - FYI, by reducing the number of includes, especially in the headers, total build plus test time on my Mac went down from 1 min 40 sec to 32 sec.

@jpivarski - FYI, by reducing the number of includes, especially in the headers, total build plus test time on my Mac went down from 1 min 40 sec to 32 sec.

Wow—I'm looking forward to that! I thought most of the compilation time was spent in linking, not repeatedly compiling headers, but maybe.

@jpivarski - FYI, by reducing the number of includes, especially in the headers, total build plus test time on my Mac went down from 1 min 40 sec to 32 sec.

Wow—I'm looking forward to that! I thought most of the compilation time was spent in linking, not repeatedly compiling headers, but maybe.


Addtotests

add test function to make sure username being set through cookies is what we want

The logic here is in good shape, but please add a better description for the overall PR than 'Addtotests'. Test code could also use a couple comment, for example to explain why we need to del the session data.

Took out commit that was part of wrong branch - PR now only deals with testing the login

ping @guberti

Ping @guberti


E2E changes for main branch

Edge-to-edge will be done without a scaffold so closing current PR and will be creating a new one.


Templates: Need design for template market creation

pickers:
text input:
single year picker:
multi-year picker:
full date/time timezone picker:
whole number only input:
number with decimals input:
https://docs.google.com/spreadsheets/d/1Au9rfcojWLsiZ_-1JDr4z6dY-u7LtzEr4LgTOjXl7Sc/edit?ts=5d71490c#gid=0
Ignore below:
examples where needed:
write in team: text input
write in whole number <appends .5>: text input
year or year/year picker: dropdown
full date time, timezone picker: like custom market creation form
points is a whole number picker: text input
# is number picker allows decimals: text input
side note, looking at these template categories:
American Football
Basketball
Baseball
Hockey

this one is done, we are moving on to specific issues now.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative/operations-wg-leads
/assign knative/operations-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping k8s.io/code-generator fb849a7...fb849a7:
bumping knative.dev/caching defaf7b...0755a97:
  > 0755a97 upgrade to latest dependencies (# 617)
bumping knative.dev/eventing 4be06cd...02663e2:
  > 02663e2 Update community files (# 6290)
  > 04eafff Process empty tracing config in test images (# 6289)
  > 3890b39 Wathola Tracing for upgrade tests (# 6219)
  > eb2bfff upgrade to latest dependencies (# 6288)
  > 7001b65 upgrade to latest dependencies (# 6286)
bumping knative.dev/hack 14f832e...f067737:
  > f067737 Adding code of conduct to reference knative/community's CoC (# 162)
bumping k8s.io/api a1613d7...cd271e7:
  > cd271e7 Update dependencies to v0.23.5 tag
  > a6b2207 Merge pull request # 108139 from liggitt/automated-cherry-pick-of-# 108138-upstream-release-1.23
  > 80b93d4 Revert v1beta1 PodDisruptionBudget select patchStrategy
bumping k8s.io/apimachinery 276a8a7...276a8a7:
bumping k8s.io/client-go b425fb6...97582f2:
  > 97582f2 Update dependencies to v0.23.5 tag
bumping knative.dev/pkg e6e3cf0...0a1ec2e:
  > 0a1ec2e upgrade to latest dependencies (# 2474)
  > 1f7514a bump k8s deps to v0.23.5 (# 2469)
  > 19a2589 fix coverage settings (# 2471)
  > 2daa86a Electors can provide an initial set of buckets (# 2473)
bumping knative.dev/serving ccc4040...73d4e7c:
  > 73d4e7c Update net-kourier nightly (# 12794)
  > 40be138 Update net-gateway-api nightly (# 12793)
  > f216d7b Fix racey tests by not adding things directly to the informer cache (# 12795)
  > 15f7a4e Update net-kourier nightly (# 12781)
  > 1255dc7 upgrade to latest dependencies (# 12787)
  > 6a0c9cb Update net-gateway-api nightly (# 12780)
  > ad64980 use ctx setup by the test which has a test logger (# 12784)
  > 0bc4171 Adds progressDeadline annotation on per revision basis (# 12751)
  > 082ed55 Make some of the unit tests a bit more robust (# 12783)

/lgtm
/approve


Limits for CephFS snapshots

The limit is in krbd (and kernel CephFS) since they only allocate 1 4KiB page to handle all the snapshot ids for an image / file.
The snapshot limit only counts for the image where the snapshot actually exists -- it does not apply to the total number of snapshots in the entire grandparent-parent-child hierarchy.
Originally posted by @dillaman in https://github.com/ceph/ceph-csi/issues/1098#issuecomment-638969666
Teeing off from the above comment, we would need to handle this for CephFS as well.
As we do not have any flatten or related operations to reduce the snapshots for a given subvolume, the determined maximum number of snapshots for CephFS would be a hard limit, post which we would need to return RESOURCE_EXHAUSTED errors till some older snapshots are deleted for CreateSnapshot calls.
Cloning volumes from snapshots should not be a concern, as that is a full copy of the source volume. Thus, limits to the same will not apply.
There maybe a limit on how many clone operations are in flight though, for resource consumption reasons.

@joscollin @batrick Request what the current CephFS snapshot limits would be. Also, if CSI should limit outstanding clone operations in any manner.

@ShyamsundarR
Kernel client only supports up to 400 snapshots per filesystem. Please see http://tracker.ceph.com/issues/21420. There is no limit for the number of clones that could be created. The only limitation, I see, would be based on the available system resources.

As we do not have any flatten or related operations to reduce the snapshots for a given subvolume, the determined maximum number of snapshots for CephFS would be a hard limit, post which we would need to return RESOURCE_EXHAUSTED errors till some older snapshots are deleted for CreateSnapshot calls.

The snapshot create command would fail, if you try to create snapshots beyond the limit. I think you need to check for failures at the CSI level and process it.

@joscollin @batrick Request what the current CephFS snapshot limits would be. Also, if CSI should limit outstanding clone operations in any manner.

@ShyamsundarR there is no flattening available as a command for CephFS. Also, the maximum number of snapshots can be configured by below Param. The default value is 100.
mds_max_snaps_per_dir

@ShyamsundarR
Kernel client only supports up to 400 snapshots per filesystem. Please see http://tracker.ceph.com/issues/21420. There is no limit for the number of clones that could be created. The only limitation, I see, would be based on the available system resources.

So total cap for all subvolumes (at the fs layer) is at 400, this seems to be clarified in tracker as well.

As we do not have any flatten or related operations to reduce the snapshots for a given subvolume, the determined maximum number of snapshots for CephFS would be a hard limit, post which we would need to return RESOURCE_EXHAUSTED errors till some older snapshots are deleted for CreateSnapshot calls.

The snapshot create command would fail, if you try to create snapshots beyond the limit. I think you need to check for failures at the CSI level and process it.

If the limits are per filesystem, the best manner for CSI to prevent it is to get an error and process it as above. Thanks.

@joscollin @batrick Request what the current CephFS snapshot limits would be. Also, if CSI should limit outstanding clone operations in any manner.

@ShyamsundarR there is no flattening available as a command for CephFS.

Yes, this is noted in the issue, and we should look at errors like RESOURCE_EXHAUSTED to be returned at the CSI layer.

Also, the maximum number of snapshots can be configured by below Param. The default value is 100.
mds_max_snaps_per_dir

I believe this is a further cap at the per directory level, with the overall limit at 400 per filesystem.

I'm not sure if that 400 snapshot limit applies only to the mount and what it can see. If we have a mount like:
mount -t ceph <mon-ip>:/volumes/_nogroup/foo/<uuid>/
then it will only see snapshots of the _nogroup subvolumegroup and snapshots of _nogroup/foo.
@ukernel, can you tell me if that helps with avoiding the 400 snapshot per-file-system limit?

I tested the following and found no errors from the ceph fs subvolume snapshot create <args> CLI. The subvolumes were not mounted and tested to detect any client side errors.

Create > 100 snapshots per subvolume - Passed

I was able to go upto ~550 snapshots for a single subvolume

Create > 400 snapshots across various subvolumes - Passed

I was able to go upto ~800 snapshots with no CLI errors

I did not find the setting mds_max_snaps_per_dir (tried ceph fs get <fsname> or tried setting it. I am possibly looking at the wrong place for an MDS setting?).
None of the settings are modified otherwise, but it was a Rook deployed CephFS instance, so unsure what other setting are changed by default.
Ceph version used was 14.2.9

I'm not sure if that 400 snapshot limit applies only to the mount and what it can see. If we have a mount like:
mount -t ceph <mon-ip>:/volumes/_nogroup/foo/<uuid>/
then it will only see snapshots of the _nogroup subvolumegroup and snapshots of _nogroup/foo.
@ukernel, can you tell me if that helps with avoiding the 400 snapshot per-file-system limit?

the problem is inodes have multiple links, these inodes are in a dummy snaprealm, which contains all snapshots in the filesystem. For cephfs volume, we only create snapshots at volume root. we can disable the special handling for inodes with multiple links. If the special handling is disabled, that can help avoiding the 400 snapshot per-file-system limit

I'm not sure if that 400 snapshot limit applies only to the mount and what it can see. If we have a mount like:
mount -t ceph <mon-ip>:/volumes/_nogroup/foo/<uuid>/
then it will only see snapshots of the _nogroup subvolumegroup and snapshots of _nogroup/foo.
@ukernel, can you tell me if that helps with avoiding the 400 snapshot per-file-system limit?

the problem is inodes have multiple links, these inodes are in a dummy snaprealm, which contains all snapshots in the filesystem. For cephfs volume, we only create snapshots at volume root.

You mean the "volumes" mgr plugin? We're creating snapshots on each subvolume directory, e.g. /volumes/_nogroup/foo or on the group directory /volumes/_nogroup.

we can disable the special handling for inodes with multiple links. If the special handling is disabled, that can help avoiding the 400 snapshot per-file-system limit

How do we disable this special handling and what are the side-effects for hardlinks?

I'm not sure if that 400 snapshot limit applies only to the mount and what it can see. If we have a mount like:
mount -t ceph <mon-ip>:/volumes/_nogroup/foo/<uuid>/
then it will only see snapshots of the _nogroup subvolumegroup and snapshots of _nogroup/foo.
@ukernel, can you tell me if that helps with avoiding the 400 snapshot per-file-system limit?

the problem is inodes have multiple links, these inodes are in a dummy snaprealm, which contains all snapshots in the filesystem. For cephfs volume, we only create snapshots at volume root.

You mean the "volumes" mgr plugin? We're creating snapshots on each subvolume directory, e.g. /volumes/_nogroup/foo or on the group directory /volumes/_nogroup.

yes

we can disable the special handling for inodes with multiple links. If the special handling is disabled, that can help avoiding the 400 snapshot per-file-system limit

How do we disable this special handling and what are the side-effects for hardlinks?

need to small patch to disable it. the side effect is: if there are hardlinks (to the same inode) across multiple subvolumes, snapshots have no effect for remote links

How do we disable this special handling and what are the side-effects for hardlinks?

need to small patch to disable it. the side effect is: if there are hardlinks (to the same inode) across multiple subvolumes, snapshots have no effect for remote links

Added a tracker for the above patch: https://tracker.ceph.com/issues/46074

@ShyamsundarR  when i tried to create more than 100 snapshots on a subvolume it stated failing
 for i in {0..110};do ceph fs subvolume snapshot create myfs csi-vol-969a0947-dad9-11ea-913c-0242ac110007 test$i --group_name csi;done
Error EINVAL: Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 975, in _handle_command
    return self.handle_command(inbuf, cmd)
  File "/usr/share/ceph/mgr/volumes/module.py", line 260, in handle_command
    return handler(inbuf, cmd)
  File "/usr/share/ceph/mgr/volumes/module.py", line 354, in _cmd_fs_subvolume_snapshot_create
    group_name=cmd.get('group_name', None))
  File "/usr/share/ceph/mgr/volumes/fs/volume.py", line 272, in create_subvolume_snapshot
    subvolume.create_snapshot(snapname)
  File "/usr/share/ceph/mgr/volumes/fs/operations/versions/subvolume_v1.py", line 197, in create_snapshot
    mksnap(self.fs, snappath)
  File "/usr/share/ceph/mgr/volumes/fs/operations/snapshot_util.py", line 18, in mksnap
    raise VolumeException(-e.args[0], e.args[1])
TypeError: bad operand type for unary -: 'str'

Error EINVAL: Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 975, in _handle_command
    return self.handle_command(inbuf, cmd)
  File "/usr/share/ceph/mgr/volumes/module.py", line 260, in handle_command
    return handler(inbuf, cmd)
  File "/usr/share/ceph/mgr/volumes/module.py", line 354, in _cmd_fs_subvolume_snapshot_create
    group_name=cmd.get('group_name', None))
  File "/usr/share/ceph/mgr/volumes/fs/volume.py", line 272, in create_subvolume_snapshot
    subvolume.create_snapshot(snapname)
  File "/usr/share/ceph/mgr/volumes/fs/operations/versions/subvolume_v1.py", line 197, in create_snapshot
    mksnap(self.fs, snappath)
  File "/usr/share/ceph/mgr/volumes/fs/operations/snapshot_util.py", line 18, in mksnap
    raise VolumeException(-e.args[0], e.args[1])
TypeError: bad operand type for unary -: 'str'

$ ceph fs subvolume snapshot ls myfs csi-vol-969a0947-dad9-11ea-913c-0242ac110007 --group_name csi |grep name| wc -l
100

sh-4.2# ceph version
ceph version 14.2.10

with octopus, even max snapshots I can create is 100
100
sh-4.4#
sh-4.4# ceph version
ceph version 15.2.4 (7447c15c6ff58d7fce91843b705a268a1917325c) octopus (stable)

@ShyamsundarR @kotreshhr anything am missing here?

@Madhu-1 the 100 snapshot limit is coming from mds_max_snaps_per_dir as mentioned here https://github.com/ceph/ceph-csi/issues/1133#issuecomment-639288396

@ShyamsundarR when i tried to create more than 100 snapshots on a subvolume it stated failing
 for i in {0..110};do ceph fs subvolume snapshot create myfs csi-vol-969a0947-dad9-11ea-913c-0242ac110007 test$i --group_name csi;done
Error EINVAL: Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 975, in _handle_command
    return self.handle_command(inbuf, cmd)
  File "/usr/share/ceph/mgr/volumes/module.py", line 260, in handle_command
    return handler(inbuf, cmd)
  File "/usr/share/ceph/mgr/volumes/module.py", line 354, in _cmd_fs_subvolume_snapshot_create
    group_name=cmd.get('group_name', None))
  File "/usr/share/ceph/mgr/volumes/fs/volume.py", line 272, in create_subvolume_snapshot
    subvolume.create_snapshot(snapname)
  File "/usr/share/ceph/mgr/volumes/fs/operations/versions/subvolume_v1.py", line 197, in create_snapshot
    mksnap(self.fs, snappath)
  File "/usr/share/ceph/mgr/volumes/fs/operations/snapshot_util.py", line 18, in mksnap
    raise VolumeException(-e.args[0], e.args[1])
TypeError: bad operand type for unary -: 'str'

Error EINVAL: Traceback (most recent call last):
  File "/usr/share/ceph/mgr/mgr_module.py", line 975, in _handle_command
    return self.handle_command(inbuf, cmd)
  File "/usr/share/ceph/mgr/volumes/module.py", line 260, in handle_command
    return handler(inbuf, cmd)
  File "/usr/share/ceph/mgr/volumes/module.py", line 354, in _cmd_fs_subvolume_snapshot_create
    group_name=cmd.get('group_name', None))
  File "/usr/share/ceph/mgr/volumes/fs/volume.py", line 272, in create_subvolume_snapshot
    subvolume.create_snapshot(snapname)
  File "/usr/share/ceph/mgr/volumes/fs/operations/versions/subvolume_v1.py", line 197, in create_snapshot
    mksnap(self.fs, snappath)
  File "/usr/share/ceph/mgr/volumes/fs/operations/snapshot_util.py", line 18, in mksnap
    raise VolumeException(-e.args[0], e.args[1])
TypeError: bad operand type for unary -: 'str'

$ ceph fs subvolume snapshot ls myfs csi-vol-969a0947-dad9-11ea-913c-0242ac110007 --group_name csi |grep name| wc -l
100

sh-4.2# ceph version
ceph version 14.2.10

with octopus, even max snapshots I can create is 100
100
sh-4.4#
sh-4.4# ceph version
ceph version 15.2.4 (7447c15c6ff58d7fce91843b705a268a1917325c) octopus (stable)

@ShyamsundarR @kotreshhr anything am missing here?

The traceback is during the handling of EMLINK error thrown by cephfs for exceeding per directory snapshot limit. Following is the actual error.
Error EINVAL: Traceback (most recent call last):
  File "/root//ceph/src/pybind/mgr/volumes/fs/operations/snapshot_util.py", line 14, in mksnap
    fs.mkdir(snappath, 0o755)
  File "cephfs.pyx", line 1149, in cephfs.LibCephFS.mkdir
cephfs.Error: error in mkdir /volumes/_nogroup/sub_0/6de60cea-b703-47ff-8182-dad0f04b1430/.snap/snap_103: Too many links [Errno 31]

The traceback should not have occurred. It should just returned the error message. This issue [1] is fixed by @ajarr in master and backported to natuilus. Octopus backport is still pending.
[1] https://tracker.ceph.com/issues/46360

The traceback is during the handling of EMLINK error thrown by cephfs for exceeding per directory snapshot limit. Following is the actual error.
Error EINVAL: Traceback (most recent call last):
  File "/root//ceph/src/pybind/mgr/volumes/fs/operations/snapshot_util.py", line 14, in mksnap
    fs.mkdir(snappath, 0o755)
  File "cephfs.pyx", line 1149, in cephfs.LibCephFS.mkdir
cephfs.Error: error in mkdir /volumes/_nogroup/sub_0/6de60cea-b703-47ff-8182-dad0f04b1430/.snap/snap_103: Too many links [Errno 31]

The traceback should not have occurred. It should just returned the error message. This issue [1] is fixed by @ajarr in master and backported to natuilus. Octopus backport is still pending.
[1] https://tracker.ceph.com/issues/46360

Thats great..so to summarize, the limit is imposed by above mentioned configuration (mds_max_snaps_per_dir) and when it exhausted we get EMLINK. Isnt it?

The traceback is during the handling of EMLINK error thrown by cephfs for exceeding per directory snapshot limit. Following is the actual error.
Error EINVAL: Traceback (most recent call last):
  File "/root//ceph/src/pybind/mgr/volumes/fs/operations/snapshot_util.py", line 14, in mksnap
    fs.mkdir(snappath, 0o755)
  File "cephfs.pyx", line 1149, in cephfs.LibCephFS.mkdir
cephfs.Error: error in mkdir /volumes/_nogroup/sub_0/6de60cea-b703-47ff-8182-dad0f04b1430/.snap/snap_103: Too many links [Errno 31]

The traceback should not have occurred. It should just returned the error message. This issue [1] is fixed by @ajarr in master and backported to natuilus. Octopus backport is still pending.
[1] https://tracker.ceph.com/issues/46360

Thats great..so to summarize, the limit is imposed by above mentioned configuration (mds_max_snaps_per_dir) and when it exhausted we get EMLINK. Isnt it?

The above are snapshots per-directory limit which CSI doesn't care about. cephcsi need to worry about the kernel limit (which can cause issues in  mounting a subvolume which is having 400+ snapshots)

@ShyamsundarR when i tried to create more than 100 snapshots on a subvolume it stated failing

Retested this today, at 100 it errors out (or throws a traceback as per the version in use). This limit handling should hence not need any CSI changes, as the call to CreateSnapshot would error out at these limits.

Considering this has been already addressed and looks like we dont need any other adjsutements in CSI code. I am closing this for now and please feel free to reopen if required. Thanks @ShyamsundarR


OPS: Create Shared Styles for Reusability Across Components

Objective
Create a centralized shared-styles folder to house general SCSS styles that can be imported into individual components. This will improve code reusability, maintainability, and ensure consistent styling across the application.
Details

Folder Structure
Create a folder named shared-styles in the appropriate location (e.g., src/styles/shared-styles).

Files to Add
Add SCSS files to define the following reusable styles:

_variables.scss
Define global CSS variables such as:
// Colors
:root {
  --text-color-primary: #;
  --text-color-secondary: #;
  --text-color-alternative: #;
  --background-color-primary: #;
  --background-color-secondary: #;
}

// Font sizes
--font-size-small: #;
--font-size-medium: #;
--font-size-large: #;

_media-queries.scss
Define reusable media query breakpoints:
$screen-sm: 576px;
$screen-md: 768px;
$screen-lg: 992px;
$screen-xl: 1200px;

Tasks

[ ] Create shared-styles folder
[ ] Add the following SCSS files:

_variables.scss for global variables (colors, spacing, font-sizes).
_media-queries.scss for responsive breakpoints.

[ ] Ensure styles can be imported into component-specific SCSS files.

Expected Outcome

A centralized shared-styles folder for managing reusable styles.
Improved consistency across the app with easily accessible variables and mixins.
Components can now import styles like:@use 'src/styles/shared-styles/variables' as *;
@use 'src/styles/shared-styles/media-queries' as *;

.example {
  color: var(--text-color-primary);
  @include respond-to(md) {
    font-size: var(--font-size-large);
  }
}

Começado por @fc46581 .
PR: https://github.com/diverintech/diverintech.github.io/pull/20
Branch: add-css-variables

Example: https://css-tricks.com/approaches-media-queries-sass/


[>.12 draft releases]: Long first remote push kills the release process

On Mac, draft version: &version.Version{SemVer:"canary", GitCommit:"78385afe65500ebb4f546341f229a5f200f1128a", GitTreeState:"clean"}
The image shows you what happens again and again IF you've never pushed before. In this case, pushing to docker.io/squillace. If you immediately rerun draft up, it all succeeds fine, and subsequent rebuilds with changes will push much faster.

This one is interesting. I haven't the foggiest idea what caused it, though it looks like it was a connection timeout error with the port-forwarded connection to tiller. I'll see if I can reproduce. :)
Before that error occurred, were you able to confirm that tiller was indeed running? It's possible that the cluster was still trying to start up.

same cluster, every time. Here it happens again, with the first time deploying to the same AKS cluster as above but from ACR. Wondering whether we're maybe trying to deploy before the image is ready to be pulled? No idea; just guessing here.

Remember: I'm on a home network for which the upload is VASTLY slower than most people's.... might have something to do with it. Look at the original upload times.....

labeling as a good first issue. :)


Zero vs one indexing of stack distance

If we access an item twice in a row, is its stack distance 0 or 1?

[x] Change mattson.py accordingly
[x] Change olken and friends accordingly

If I reuse an element twice in a row, I consider the reuse distance to be zero.


Updated Tool-Bar Broke Images

When the atom package tool-bar was updated to 1.2.0 it broke all of the different images. I read through all the different issues on the tool-bar repository but felt that a new issue needed to be created over here so the images could be fixed.

Same issue here

+1

+1

Now it's fixed, thanks!
However, the SAVE icon looks like an ARCHIVE icon... that is weird :S could you please change that?


add RSI2 strategy

prepare() gets executed on every candle. in your case what you need is the __init__() method:
https://docs.jesse-ai.com/docs/strategies/entering-and-exiting.html#init

@saleh-mir it is updated, please check again

One more thing. Because rod the negative balance exception, you now need to use pass fee_rate in your position sizing. Read example #2:
https://forum.jesse-ai.com/d/102-v082-is-released-possible-breaking-change-is-included

added fee_rate params for SMACrossover too

Awesome job


[RFC] Proposal for refactoring dependency resolution

h/t @keithduncan
This would obsolete #31. We should probably implement benchmarks before really considering this.

@keithduncan Do you think this captures our conversation accurately?

I think all of this will be captured in https://github.com/ArbiterLib/Arbiter/pull/92.


Feature Request: Implement Tensorboard monitoring of training sessions

Is it possible to implement tensorboard to monitoring the training sessions?

Hi! can I work on this?


Unknown motherboard & CPU

Debug info
C:\Users\benno>fetchcord --debug
----out.py----
----DE/WM----
----GPU INFO----
gpuinfo: GPU: NVIDIA GeForce GT 730
gpuvendor: NVIDIA
----CPU INFO----
cpuvendor: Intel
cpumodel: Intel Duo
cpuinfo: CPU: Intel2 Duo CPU E8500@ 3.16GHz
cpuline item 0: CPU: Intel(R) Core(TM)2 Duo CPU E8500@ 3.16GHz
memline: Memory: 3.3GiB / 5.9GiB (54.85%)
----OS INFO----
sysosline: ['OS: Windows 10 Pro']
sysosid: Windows10
diskline: Disk: C: 53.3GiB / 147.9GiB (36.06%)
Disk: E: 193.1GiB / 400.8GiB (48.19%)
Disk: F: 135.0GiB / 232.9GiB (57.97%)
Unknown Motherboard, contact us on github to resolve this.(Keyerror)
unknown CPU, contact us on github to resolve this.(Keyerror)
----testing.py----
moboid: unknown
moboline: ['Motherboard: Hewlett-Packard (3647h)']
----GPU INFO----
gpuvendor: NVIDIA
----CPU INFO----
cpumodel: Intel Duo
Connecting
----run_rpc----
uptime in epoch:<PHONE_NUMBER>.1992097
cpuid:<PHONE_NUMBER>65942099
cpuappid:<PHONE_NUMBER>79197462
RPC Connection Successful.
w_cycle 0
appid:<PHONE_NUMBER>65942099
Operating system & way of installation
Windows 10 Pro (latest updates). Installed (updated) through Pip.
Error/issue
I'm getting the errors "Unknown Motherboard" and "Unknown CPU".
On the previous pip version I only had the unknown motherboard error.
It seems like the Core 2 Duo detection has broken.
Other notes
On my laptop it's working fine now. At least last time I checked.

For now I'll just roll back to version 2.5.3, where the CPU was displayed correctly

does 2.7 work?

I can't find a release 2.7 so I assume the one from the code tab here? I'll see if that one works.

did it work?

If I keep my mouse on the big question mark, it gives me the correct data. But no(t the correct) icon as you can see.

can you send the debug info?

C:\Users\benno>fetchcord --debug
[KeyError]: 'Font:'[KeyError]: 'Font:'----run_rpc----
uptime in epoch:<PHONE_NUMBER>.9925427
cpuid:<PHONE_NUMBER>65942099
cpuappid:<PHONE_NUMBER>79197462
----out.py----
----DE/WM----
----GPU INFO----
gpuinfo: NVIDIA GeForce GT 730
gpuvendor: nvidia
----CPU INFO----
cpuvendor: intel
cpumodel: Intel2 Duo
cpuinfo: Intel(R) Core(TM)2 Duo CPU E8500@ 3.16GHz
cpuline item 0: Intel(R) Core(TM)2 Duo CPU E8500@ 3.16GHz
memline: 3.4GiB / 7.9GiB (43.28%)
----OS INFO----
sysosline: Windows 10 Pro
sysosid:<PHONE_NUMBER>65942099
diskline: C: 59.2GiB / 147.9GiB (39.99%)
----testing.py----
Unknown motherboard, contact us on github to resolve this.
moboid:<PHONE_NUMBER>79197462
moboline: Hewlett-Packard (3647h)
----GPU INFO----
gpuvendor: nvidia
----CPU INFO----
cpumodel: Intel2 Duo
('DEFAULT', <Section: DEFAULT>)
('cycle_0', <Section: cycle_0>)
('cycle_1', <Section: cycle_1>)
('cycle_2', <Section: cycle_2>)
('cycle_3', <Section: cycle_3>)
{}
windows not in : True
try_connect(key="windows") on <pypresence.presence.Presence object at 0x03B9CFD0>
w_cycle 0
Unknown motherboard, contact us on github to resolve this.
try_update(key="windows") on <pypresence.presence.Presence object at 0x03B9CFD0>

As I'm going through the old issues i saw this, does it works now ? I remember fixing something for core 2 duo at some point but dunno when.

It does report as a Intel Core(TM)2 Duo, but it does not show the icon.
Neofetch output:
`benno@BMP-Desktop
OS: Windows 10 Pro
Uptime: 12 minutes and 51 seconds
Local IP: <IP_ADDRESS>
Motherboard: Hewlett-Packard (3647h)
CPU: Intel(R) Core(TM)2 Duo CPU E8500@ 3.16GHz
GPU: NVIDIA GeForce GT 730
Memory: 3.3GiB / 7.9GiB (41.34%)
Disk: C: 53.0GiB / 148.5GiB (35.68%)
E: 189.3GiB / 465.8GiB (40.63%)
F: 54.5GiB / 182.9GiB (29.78%)
G: 28.1GiB / 50.0GiB (56.13%)`
Fetchcord debug output (might have changed):
`OS: Windows 10 Pro
Uptime: 13 minutes and 38 seconds
Local IP: <IP_ADDRESS>
Motherboard: Hewlett-Packard (3647h)
CPU: Intel(R) Core(TM)2 Duo CPU E8500@ 3.16GHz
GPU: NVIDIA GeForce GT 730
Memory: 3.3GiB / 7.9GiB (41.59%)
Disk: C: 53.0GiB / 148.5GiB (35.68%)
E: 189.3GiB / 465.8GiB (40.63%)
F: 54.5GiB / 182.9GiB (29.78%)
G: 28.1GiB / 50.0GiB (56.13%)
[KeyError]: 'Font:'[KeyError]: 'Font:'----run_rpc----
uptime in epoch:<PHONE_NUMBER>.7384765
cpuid:<PHONE_NUMBER>65942099
cpuappid:<PHONE_NUMBER>79197462
----out.py----
----DE/WM----
----GPU INFO----
gpuinfo: NVIDIA GeForce GT 730
gpuvendor: nvidia
----CPU INFO----
cpuvendor: intel
cpumodel: Intel2 Duo
cpuinfo: Intel(R) Core(TM)2 Duo CPU E8500@ 3.16GHz
cpuline item 0: Intel(R) Core(TM)2 Duo CPU E8500@ 3.16GHz
memline: 3.3GiB / 7.9GiB (41.59%)
----OS INFO----
sysosline: Windows 10 Pro
sysosid:<PHONE_NUMBER>65942099
diskline: C: 53.0GiB / 148.5GiB (35.68%)
----testing.py----
Unknown motherboard, contact us on github to resolve this.
moboid:<PHONE_NUMBER>79197462
moboline: Hewlett-Packard (3647h)
----GPU INFO----
gpuvendor: nvidia
----CPU INFO----
cpumodel: Intel2 Duo
('DEFAULT', <Section: DEFAULT>)
('cycle_0', <Section: cycle_0>)
('cycle_1', <Section: cycle_1>)
('cycle_2', <Section: cycle_2>)
('cycle_3', <Section: cycle_3>)
{}
windows not in : True
try_connect(key="windows") on <pypresence.presence.Presence object at 0x0000020BB1300730>
w_cycle 0
Unknown motherboard, contact us on github to resolve this.
try_update(key="windows") on <pypresence.presence.Presence object at 0x0000020BB1300730>`


Add cache example to README

Such an example never made it to the docs after the feature got introduced (https://github.com/lycheeverse/lychee/pull/443).
Now, that https://github.com/lycheeverse/lychee/issues/647 is resolved and --cache works again... 👍
What do you think about my approach and the cache setup?
Would you adjust the default cache age value, or do you think some comments could be helpful?

Great idea, I like it! Should we add another step at the end which stores the cache for the next run? I'd assume that's what most people would want to do. Apart from that it looks fine.

0.10.1 is the default version now. 🎉 Can you update that section and I'll merge it right away?

I updated the docs accordingly, and thanks for taking care of including the explanation. 👍

Noice! Let's gooo! 🚀


Load server side generated Waveform image

I have large mp3 files and this give me a error.
I would now generate the waveform on my server with lame. The png file would i use to show the waveform. How can i do this?
Thanks

First time trying out wavesurfer.js and I also had this issue, and this thread helped. However I need a little more information.
@Heinerlutscher Could you share how you loaded the c++ library onto your server? Is it simply just a matter of adding the directory to your code base or is the process more involved?

Hello everyone
I can not build audiowaveform by BBC R&D on windows
Could you send audiofwaveform exe file?
Best Regards


Solved : the display is broken when inside bootstrap modal withPortal

Solved : the display is broken when inside bootstrap modal withPortal

yellow box is modal
Red box is datepicker

added this css to make it a center inside modal
.react-datepicker__portal {   left: 0;   right: 0;   top: 0;   bottom: 0;   width: 100% !important;   height: auto !important;   background: rgba(128, 128, 128, 0.7) !important; }
and results like this

@dananw Can you update title of the issue with something like this Solved : the display is broken when inside bootstrap modal withPortal .
It will help to find it easier. Thx.

@ArtemBernatskyy Thx for correction.


Lines with different y-axis values

Is your feature request related to a problem? Please describe.
I want to draw two lines with lightweight. The vertical coordinates of the two lines are dates. But the horizontal coordinates may not be of the same order of magnitude, one is the normal transaction price, but the other is the number of corresponding transactions. Is there any implementation example of this? Thanks
Describe the solution you'd like

Additional context

Could you provide a screenshot of the desired implementation?


Not working with ANGULAR 17

This is not rendering content in angular v17 with standalone component

This package is not standalone ready yet. There is a open PR https://github.com/sibiraj-s/ngx-tiptap/pull/70. If thats not the case, kindly provide more info.

You can use it inside a standalone component by importing the module. I've had to do this with all the material components too
@Component({
  selector: 'my-custom-component',
  standalone: true,
  imports: [NgxTiptapModule],
…

Yeah, I would suggest importing module inside components like @bboyle . Standalone will be supported in next major.


The adversarial loss

Thanks very much for your work, I haved benefit much from it ~ But I found your adversarial loss is a little different from the paper.  Maybe it is similiar to SRGAN's adversarial loss ? just like make fake_img more realistic? I found ESRGAN also make real_img less realistic... Or I misunderstand it ?
I want to change it to make it the same as the paper, like this change in your code:
adversarial_loss = adversarial_criterion(fake_output - torch.mean(real_output), real_label) +
adversarial_criterion(real_output - torch.mean(fake_output), fake_label)
Is it right? Thank you in advance for your help

adversarial_loss = adversarial_criterion(fake_output - torch.mean(real_output), real_label) + adversarial_criterion(real_output - torch.mean(fake_output), fake_label)

It look right

thanks


Fix should regen docs from compiler on build

@tjprescott, @markcowl: I believe this PR added about 15 minutes to the build times of pipelines "typespec - CI" and "typespec-azure - CI".  Is this expected?


Hidden links for buildings

This PR adds support for hidden links, created by generating UUIDs unique to a specific building.
I'm keeping this in draft until we've decided upon an output format for the the UUID endpoints.

PR is up-to-date, now contains public building pages that show the upcoming schedule.


userData simple restAPI R

Hi,
I can not figure out through the documentation what the userData object should be and contain?
httr::POST(
url = "http://revigo.irb.hr/Revigo",
body = list(
cutoff = "0.7",
valueType = "pvalue",
speciesTaxon = "0",
measure = "SIMREL",
goList = userData
),
encode = "form"
) -> res
is it a list, df, matrix?
Could you provide an reproducible example?
Hugo

Hi Hugo,
First, if you want more results than a simple result table, use a Advanced job method (See our FAQ page for details and examples).
The result from a RestfulAPI method is in html (a quote from our FAQ):
"The output is in HTML format, it has "ErrorMessage" element in which you can find error description(s) (if any error occured) and table for each available namespace with the following names: "BiologicalProcess", "CellularComponent" and "MolecularFunction". The tables have following columns: "Term ID", "Name", "Frequency", "Value", "Uniqueness", "Dispensability", "Eliminated" and "Representative"".
You can view the output yourself from the web browser with the following HTML code (save in file as, for example, test.html):

		<title>Revigo RestfulAPI test page</title>

		<form action="http://revigo.irb.hr/Revigo" method="post">
			<textarea name="goList" cols="80" rows="10">
			</textarea>

			<input name="cutoff" type="text" value="0.70" />

			<input name="valueType" type="text" value="pvalue"/>

			<input name="speciesTaxon" type="text" value="0"/>

			<input name="measure" type="text" value="SIMREL"/>

			<input name="autoStart" type="text" value="false"/>

			<input name="submitForm" type="submit" value="Submit"/>
		</form>

More specific, the output looks more like this:
<!DOCTYPE html>

	<title>Revigo RESTful results</title>

			Term ID
			Name
			Frequency
			Value
			Uniqueness
			Dispensability
			Eliminated
			Representative

...table data...

The same content as first table, but for Cellular component namespace, if available

The same content as first table, but for Molecular function namespace, if available

Hope this helps ;)


Events receiving HTTP 400 in v2.1.2

Exactly what it says on the tin. After upgrading from 2.1.1 to 2.1.2 this morning, events sent to our on-prem Sentry would get back an HTTP 400 with the following response body: {"error":"No JSON data was found"}. Upon further investigation (hampered by the fact that there's no debug option for the PHP SDK), I discovered that the request being made did, in fact, have an empty body. This was seen by manually dumping out both the request and response bodies from the catch in HttpTransport->cleanupPendingRequests().
My init takes only a DSN and environment - everything else is left to the defaults.
I then worked around the issue by reverting to 2.1.1.

Take a look at #857 since that fixed a bug where the request was actually not be compressed before sending, but if your server is misconfigured then you get the exact error you are reporting.

I stumbled over the same problem, also after upgrading from 2.1.1 to 2.1.2. I'm using sentry.io, not Sentry on on-prem, so I would guess that Nginx is configured correctly there, right?
Dumping the silenced exception in HttpTransport->cleanupPendingRequests() I also see a HTTP 400, and I also see an empty Request body.
So, is this a bug in the SDK, a misconfiguration of the sentry.io servers or something I missed?

Can you please test whether it works if you set the enable_compression option to false?

I can confirm, enable_compression: false fixes the issue

@NGTOne Can you please check whether rewinding the stream before dumping the request body gives you some data?

I am observing the same behavior as @kralos. We're using Sentry+Symfony and seeing this response from the sentry.io endpoint:
{"error":"No JSON data was found"}

What is odd is that we only see this issue on CLI, but not in web requests. Setting enable_compression: false fixes the issue on CLI.
We have the same issue on PHP 7.2 and PHP 7.3.

I get this error using php 7.3, gesentry/sentry-laravel and a self hosted sentry instance.
I played around a bit and calling wait on the CurlPromise right away works.
I believe this is because cleanupPendingRequests is called from the destructor of the HttpTransport.
The destructor method will be called as soon as all references to a particular object are removed or when the object is explicitly destroyed or in any order in shutdown sequence.

The GzipEncodeStream object or some object depending on it has already been destructed at this point.
Just a theory thought, I have not been able to come up with a way to confirm this yet.

After investigating I found out that we may have hit hard some PHP bug, otherwise I don't have any other explanation for this. Basically, the problem arises when using exit. This little script reproduces the problem:
use Http\Message\Encoding\GzipEncodeStream;
use Zend\Diactoros\StreamFactory;

require_once __DIR__ . '/vendor/autoload.php';

register_shutdown_function(function () {
    $stream = (new StreamFactory())->createStream('hello world');
    $stream->rewind();

    $stream = new GzipEncodeStream($stream);

    var_dump($stream->getContents()); // This outputs an empty string
});

exit(1); // If this line is commented out the var_dump works as expected

After investigating I found out that we may have hit hard some PHP bug, otherwise I don't have any other explanation for this. Basically, the problem arises when using exit.

This sounds more like a race condition bug to me, exit could be forcing php shutdown before the stream has data.

I also see that the destructor of the user filter is called before the onClose method. This PHP bug may somewhat be related maybe

It happens even with exceptions

We've hit some issues issues as well. We're using the sentry/sdk package, and it seems the only solutions seem to specifically require and downgrade sentry/sentry (to 2.1.1), or set the default enable_compression to false.
So the basic 'Getting Started' from the documentation currently does not work:
Sentry\init(['dsn' => '...' ]);

// Doesn't show up in Sentry
throw new Exception("My first Sentry error!");

It also seems that the request hangs for quite a while in our application.

enable_compression: true: 5–10s (plus the event doesn't get sent at all)
enable_compression: false: ~600ms

Note that this doesn't seem to happen in a reduced test case, only in our application.

I can confirm #877 fixes that.
Our composer.json:
"sentry/sdk": "^2.0",
"sentry/sentry": "dev-no-streaming-gzip as 2.1.2",

You should run composer update sentry/sdk --with-dependencies though!

Verified on my project as now fixed, nice work @stayallive
php-http/guzzle6-adapter               v2.0.1
sentry/sdk                             2.0.3
sentry/sentry                          2.1.3
sentry/sentry-symfony                  3.1.0
symfony/monolog-bridge                 v4.3.4
symfony/monolog-bundle                 v3.4.0

@cRUSHr2012 please update to sentry/sentry 2.1.3, this will fix it without needing to disable the compression.

Currently, I has the same issue as @robertlemke
I solved it by downgrading to sentry/sentry 2.1.1.

@jni-heyloyalty do you still have this issue on 2.2.x (2.2.6 is the latest at the time of this comment)?
I would try upgrading instead of downgrading and if you still have this issue on 2.2.x please open a new issue!

@stayallive
The sentry/sentry 2.1.3 works but produces duplicated events, while 2.2.6 seems to work and produces only one event.
Thanks for your effort.

@jni-heyloyalty Yep, please use the latest and greatest, a lot of offert went in 2.2 including fixes for duplicated events. If you still have issues please do open up a new issue so we can investigate!

Works :)
"sentry/sdk": "^2.0",
"sentry/sentry": "2.2.6",
"sentry/sentry-laravel": "1.5.0",

@stayallive Instead of suppressing errors please let them bubble up or send them to the centralized log for the respective system it is integrated into, it would have saved me lots of time.

@jni-heyloyalty please open up a new issue if you think something is broken (but first search for related issues like #907, #935).


Executive Diversity Scorecard

As a candidate, I want to know how much diversity there is in the executive team.
AC:

All members of the executive team can be added to a company with their name, position, gender, and race
Race and gender match the options for users
The percentage of non-male execs is clear in a single aggregated statistic on the company view
The percentage of non-white execs is clear in a single aggregated statistic on the company view

Notes:

Race and gender should probably put into globals

This is now on Master


Adding overlap keyword to make_fixed_length_epochs

Describe the new feature or enhancement
I am trying to use time-frequency analysis that is present in mne without converting to arrays first. There is no way to do this using the Raw object, and one must convert to Epochs, with each epoch "representing" the window that will have tfr methods applied. E.g. I want to compute the multitaper FFT, and/or morlet wavelet transform to get an AverageTfr object for multiple frequency bands, alpha, beta, gamma, etc.
Normally, one would like some overlap of these windows. For example, if you do multitpaer FFT, then you usually use a sliding window with some overlap (e.g. 1 sec window with 0.5 sec step).
In https://mne.tools/stable/generated/mne.make_fixed_length_events.html#mne.make_fixed_length_events
there is an overlap keyword.
However, in make_fixed_legnth_epochs there is not.
https://mne.tools/stable/generated/mne.make_fixed_length_epochs.html#mne.make_fixed_length_epochs
Describe your proposed implementation
Is it possible to add the overlap keyword argument here?
Describe possible alternatives
I'm still not quite sure what the optimal way to apply tfr analysis to a Raw object. Obviously one can always convert to arrays, but then they lose the structure present in the mne data structures. I would prefer staying with the data structures mne has (e.g. Epochs for TFR). If what I said up there is not the optimal way to construct TFR then please let me know.
Additional comments
I can update an existing example to show this functionality off if needed.

ok to add overlap param to make_fixed_length_epochs
yet I am not sure what you aim to obtain for TFR on raw. You want a spectrogram?

ok to add overlap param to make_fixed_length_epochs
yet I am not sure what you aim to obtain for TFR on raw. You want a spectrogram?

Yep I'm essentially after a spectrogram.

Yep I'm essentially after a spectrogram.

one idea now we refactored the raw.plot would be to add plot of spectrogram
in each "horizontal" band of the plot.
I've seen this in certain software for sleep data.
did you try scipy.signal.spectrogram?

one idea now we refactored the raw.plot would be to add plot of spectrogram
in each "horizontal" band of the plot.
I've seen this in certain software for sleep data.
did you try scipy.signal.spectrogram?

one idea now we refactored the raw.plot would be to add plot of spectrogram in each "horizontal" band of the plot.
This sounds interesting to me. Would you elaborate what the "horizontal band" mean? like a frequency band?

And do you mean we could add a compute_spectrogram function for Raw, where we can specify say a frequency band, and/or a list of frequencies with an average kwarg?

I've seen this in certain software for sleep data. did you try scipy.signal.spectrogram?
Nope haven't tried this approach yet, since mne has the tfr functions that operate on arrays. I feel like the scipy spectrogram is a bit more low level and I generally do tfr analysis as a benchmark (and prefer not to have to think as much :p), so I like going pure mne API.

one idea now we refactored the raw.plot would be to add plot of spectrogram in each "horizontal" band of the plot.
This sounds interesting to me. Would you elaborate what the "horizontal band" mean? like a frequency band?

And do you mean we could add a compute_spectrogram function for Raw, where we can specify say a frequency band, and/or a list of frequencies with an average kwarg?

I've seen this in certain software for sleep data. did you try scipy.signal.spectrogram?
Nope haven't tried this approach yet, since mne has the tfr functions that operate on arrays. I feel like the scipy spectrogram is a bit more low level and I generally do tfr analysis as a benchmark (and prefer not to have to think as much :p), so I like going pure mne API.

my concern is that TFRs are often bigger than the initial raw data (one
signal gives an image),
so it makes sense to compute it on the fly when you need and do not store
it to disk.
A TFR for 300 MEG channels for 6 mins of sample data would be huge.

my concern is that TFRs are often bigger than the initial raw data (one
signal gives an image),
so it makes sense to compute it on the fly when you need and do not store
it to disk.
A TFR for 300 MEG channels for 6 mins of sample data would be huge.

my concern is that TFRs are often bigger than the initial raw data (one signal gives an image), so it makes sense to compute it on the fly when you need and do not store it to disk. A TFR for 300 MEG channels for 6 mins of sample data would be huge.
…

I agree storing the full (ch, freqs, time) array would be huge, but in many cases, one might jsut want (ch, time) for a certain frequency band, so for example, I want spectrograms for my iEEG Raw object for delta, theta, alpha, beta, gamma, highgamma frequency bands. Since I do post-hoc analyses, I want to then save these at least. (this would be similar in size to the original Raw object, since you're "combining" the power across the frequency axis).
The combination scheme can be "mean", or "median" for example, or more generally a func (maybe one is interested in the quantile, or min, or max).
Overall, I think the general use-case of getting one of these averaged spectrogram directly from Raw is very useful without doing roundabouts like going to array, or going to Epochs/Evoked.
Is the idea of computing a spectrogram directly from Raw even feasible rn?

my concern is that TFRs are often bigger than the initial raw data (one signal gives an image), so it makes sense to compute it on the fly when you need and do not store it to disk. A TFR for 300 MEG channels for 6 mins of sample data would be huge.
…

I agree storing the full (ch, freqs, time) array would be huge, but in many cases, one might jsut want (ch, time) for a certain frequency band, so for example, I want spectrograms for my iEEG Raw object for delta, theta, alpha, beta, gamma, highgamma frequency bands. Since I do post-hoc analyses, I want to then save these at least. (this would be similar in size to the original Raw object, since you're "combining" the power across the frequency axis).
The combination scheme can be "mean", or "median" for example, or more generally a func (maybe one is interested in the quantile, or min, or max).
Overall, I think the general use-case of getting one of these averaged spectrogram directly from Raw is very useful without doing roundabouts like going to array, or going to Epochs/Evoked.
Is the idea of computing a spectrogram directly from Raw even feasible rn?

try to cook something for your needs and share it when it does the job for
you.
then we'll see what to consider for inclusion in mne

try to cook something for your needs and share it when it does the job for
you.
then we'll see what to consider for inclusion in mne

👨💻

👨💻

I am working on this


Feature flags should be defined in opensearch.yml

Currently, these flags are passed as JVM args to the process that launches the server. The general (though not universal) convention today is that JVM args are mostly used for tuning the JVM itself, and OpenSearch application configuration is specified via settings in opensearch.yml. It would make for a better user experience for the feature flags to be a configuration option in opensearch.yml, i.e. something like experimental.features: ["feature-1", "feature-2"].
See the previous discussion in #4024

Hi,
I am giving my thoughts on this issue. Ideally, feature flags should be allowed to toggle, but with YAML that won't be easier. The ideal technique to allow toggling of features is via an API or Database. So, was wondering if this is still a valid use case because I felt it could be termed as configuration management and not a feature flag.
Whether the convention sticks along or not, I would like to give this PR a try.
Do let me know your thoughts and also if possible please answer these doubts for me:

I assume the feature flags would go in this file opensearch.yaml-rest-test.properties?
Currently, the master branch has these two flags. So I can consider adding those as false by default?

@tan31989 Thanks for your interest in this issue.

Hi,
I am giving my thoughts on this issue. Ideally, feature flags should be allowed to toggle, but with YAML that won't be easier. The ideal technique to allow toggling of features is via an API or Database. So, was wondering if this is still a valid use case because I felt it could be termed as configuration management and not a feature flag.

The idea behind these feature flags is that they gate an experimental feature that is not ready to be enabled in production.  With the flag enabled, an additional setting becomes available that may toggle a particular feature on/off.  For example for Segment Replication, the feature flag currently needs to be enabled via a jvm flag, in addition to the index created with the setting enabled.
curl -X PUT "localhost:9200/<index-name>?pretty" -H 'Content-Type: application/json' -d '{
  "settings": {
    "index": {
      "replication": {
        "type" : "SEGMENT"
      }
    }
  }
}'

Without the flag enabled, attempting the request above will return that the setting is not found.
{
  "error" : {
    "root_cause" : [
      {
        "type" : "illegal_argument_exception",
        "reason" : "unknown setting [index.replication.type] please check that any required plugins are installed, or check the breaking changes documentation for removed settings"
      }
    ],
    "type" : "illegal_argument_exception",
    "reason" : "unknown setting [index.replication.type] please check that any required plugins are installed, or check the breaking changes documentation for removed settings"
  },
  "status" : 400
}

I assume the feature flags would go in this file opensearch.yaml-rest-test.properties?

The flags could be defined in opensearch.yml manually or provided as default options here to be included in the distribution.

Currently, the master branch has these two flags. So I can consider adding those as false by default?

Correct these are currently the only two flags.

Thanks, @mch2 for the details.
How can one test if it's added as part of the default options here of the distribution?
Could you provide some more inputs on the build and testing?

Hi @tan31989, check this out - https://discuss.elastic.co/t/how-to-setup-unit-testing-for-elastissearch-configuration/11016/2
Seems like the configurations can be set using System.setProperty

I am looking for an issue for my first contribution . Can you help me here. Can I take on this .

Sorry for the no reply here @tan31989.
To test I would suggest creating a test feature flag that is passed in an IT as a node level setting with internalCluster().startNode(nodeSettings);.  You can then use the settings API to fetch node level settings and see that the flag is enabled.
I would also test with an IT that uses existing flags, you can also enable the flag at the node scope and run the test as normal. Example for Segment Replication.
@xuezhou25 is looking to make the flags pluggable for our integ tests so they can be injected into the Node/Environment rather than hardcoded in jvm args.  I don't think #3818 makes sense if we are moving to a config setting, because we can set the node setting with internalCluster().startNode(nodeSettings);
https://github.com/opensearch-project/OpenSearch/issues/3818#issuecomment-1261766324

@tan31989 Do you still have interest in picking this up?  If not @techrajdeep its all yours.

Thanks @tan31989 I will assign to you. Let me know if you have further questions on the issue.

Thanks for your interest @techrajdeep! I would suggest filtering by the tag good first issue to find these issues.

@tan31989: Are you still working on this issue ? Please let know in case you need any help.

@dreamer-89, apologies for the delay. Yes, I am still trying to work on this. I should have this completed by the 31st.

@dreamer-89, apologies for the delay. Yes, I am still trying to work on this. I should have this completed by the 31st.

Thank you @tan31989 for working on this issue and updating on progress. Feel free to post here in case you are stuck.

Thank you @tan31989 again for working on this issue. As relevant PR https://github.com/opensearch-project/OpenSearch/pull/4959 merged, closing this issue.


Add Node Image Variable to Kind

fixes: https://github.com/envoyproxy/gateway/issues/241
Signed-off-by: hejianpeng<EMAIL_ADDRESS>

Codecov Report

Merging #242 (66d91dd) into main (d99f32f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   57.62%   57.62%
=======================================
  Files          30       30
  Lines        2702     2702
=======================================
  Hits         1557     1557
  Misses       1054     1054
  Partials       91       91

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Support bosh links for tsa information.

It would be preferable to use bosh links to discover the tsa's IP vs having this defined statically. You can also get the host_public_key using links.

@jasonkeene Thanks! Ideally we would like to not have this release at all. If we can add the windows jobs to the upstream concourse release, we may not actually need this at all.

Closing in favor of https://github.com/pivotal-cf-experimental/concourse-windows-worker-release/issues/7 since we lost the story for this issue


chore/pod-container-count

we calculate the number of containers from the row.status but if the pod was evicted, we won't get any containerStatuses which makes the pod's READY column to be 0/0 thus being colored blue which is good when in fact it's not.
Better to calculate the number of containers from row.spec

Ah clever!


[Bug] image inputRule not well

Initial checklist

[X] I agree to follow the code of conduct
[X] I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected packages and versions
latest
Link to runnable example
No response
Steps to reproduce
输入![img](https://milkdown.dev/milkdown-mini.svg)后空格或回车，会变成图片，但是前面有个叹号!
https://user-images.githubusercontent.com/1715916/187477092-0afa4b02-672e-419c-a606-48dcd82eeff1.mov
Expected behavior
正常显示，不留!
Actual behavior
图片显示，但留下了!
Runtime
No response
OS
No response
Build and bundle tools
No response

Fixed


Add S3 source key parameter

This pull request allows the S3 object key for the Lambda deployment package to be optionally specified as a parameter to facilitate deployment from continuous deployment pipelines such as CodePipeline.
For example, this permits a single CodePipeline pipeline to build the Lambda deployment package and deploy it to S3, then invoke CloudFormation to deploy the template with the deployment package fetched directly from the CodePipeline artifact store. The location of the Lambda deployment package is specified by providing parameter overrides in the pipeline's CloudFormation deploy action such as:
{
  "S3SourceBucket": {
    "Fn::GetArtifactAtt": ["BuildArtifact", "BucketName"]
  },
  "S3SourceKey": {
    "Fn::GetArtifactAtt": ["BuildArtifact", "ObjectKey"]
  }
}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks @williterate PR approved


Adds lgtm badges

Codecov Report

Merging #11 (dc21e92) into main (50627f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   63.63%   63.63%
=======================================
  Files           3        3
  Lines          55       55
=======================================
  Hits           35       35
  Misses         20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50627f8...dc21e92. Read the comment docs.


reverse support

Hello @Hilbert2048
Thanks for opening the PR,
I will check it next week

I created a new issue and tagged your PR. I will implement a solution for that respecting your PR, thanks! @Hilbert2048

I added the support for reverse. If you set it to true, you have to add it to your GridView and ReorderableBuilder.
If you are using a scrollable widget outside ReorderableBuilder, ensure that the reverse flag is also added to that widget.
You can try it with version 5.3.0 of this package. @Hilbert2048


Include loaded_from_api key in Tab

This PR adds a loaded_from_api item to a formula's Tab. Whether the formula was loaded from the API or not is determined by checking the formula namespace to see if it starts with FormulaNamespaceAPI which would only be the case when loading from the API. This change will allow us to check whether formulae were installed from the API or not which could be helpful for debugging or other things like that.
I'd also like to note this for casks somehow too, but I'm not totally sure what the best way to do that is. Maybe put it in config.json somehow?

Review period will end on 2022-09-13 at 00:00:00 UTC.

Review period skipped due to critical label.

Perfect, thanks again @Rylan12!


Anjuta, the GNOME IDE

Hi,
I'd like an Anjuta AppImage, but as I realized you'd tell me to request it from the upstream developers I have requested it at its bugzilla https://bugzilla.gnome.org/show_bug.cgi?id=772538. I suspect they'll provide a flatpak instead, however, as that's what the GNOME Project has been doing with its apps. I thought I'd start this issue to inform ya of this and see if anyone's interested in building this AppImage. I haven't the foggiest how to, because firstly no Ubuntu PPAs I've found provides the latest Anjuta release and secondly because building the latest release manually on Ubuntu 16.04.1 hasn't gone well (and yes I did remember to run sudo apt-get build-dep anjuta first, in case you're wondering if this is why). I haven't found any distribution (and I've searched in Fedora and openSUSE repositories) that's reasonably old, yet still supported, that provides the latest Anjuta release.
Thanks for your time,
Brenton

Thanks for requesting it from the upstream developers, let's see how they react. GNOME might push GNOME Builder instead?

Possibly, I know they have a flatpak for GNOME Builder already.


About Node.js npm install yarn -g

this Npm support Vue front to run?
i try CMD npm install yarn -g was code EPERM

Hi. Modules containing native code will not work, so installing yarn directly through npm is unsupported.
Regarding Vue, you can download this template project: https://github.com/bummoblizard/vue-archive.git
and run
npm install .
node index.js

ok


init.py file seems to be missing fileformats import

🐛 Bug Report
Cannot import fileformats. Seems to be because it is not included in the main init.py file for iris.
How To Reproduce
Steps to reproduce the behaviour:

install iris v3.2.1.post0
import iris
iris.fileformats

Expected behaviour
AttributeError: module 'iris' has no attribute 'fileformats'
Environment

macOS 12.4
iris v3.2.1.post0

Additional context
Adding from iris import fileformats to the main init.py file resolves the issue.

This is not really broken, it is just that we minimised all our imports, so "iris.fileformats" is no longer automatically imported when you simply "import iris". See this note in the v3.1 release notes
We have previously been caught out ourselves when subpackages that were previously "automatically present", then disappeared in later versions of a package.
I think our view of this is that all subpackages should be explicitly imported.