Project structure not Gradle compliant.

Sorry for filing this. But Android Studio has been around for some time now. Looking forward to contribute to this open source project when I have free time.
PS: Thanks for the great tool. It helped me in development a lot.

The migration is done, but the whole procedure isn't finished yet, I will update the wiki later.

@eolwral alright cool. Thanks.

Wiki updated. Closed


Adding messages to assert_* macros

It would be great to extend the assert_* macros to accept a custom panic message, the way assert_eq! does:
assert_eq!(a, b, "Failed to compare a and b; a={}, b={}", a, b);

Yeah! This seems like a great idea!

@brendanzab I've attempted a fix for this.
Due to parsing ambiguities arising from adding a second repeating pattern, I took the approach of separating the panic message args from the rest of the macro args with a ;, like so:
($given:expr, $expected:expr $(, $opt:ident = $val:expr)*; $($arg:tt)*)
                                                        ^^^

which allows us to do this:
assert_abs_diff_eq!(x, y, epsilon = epsilon; "Should panic. x = {:?}, y = {:?},
    epsilon: {:?}", x, y, epsilon);

It feels rather hacky though, and deviates from how Rust asserts behave. If you've got a better idea on how to tackle this, I'm all ears.


Migrate TestBrokerTrigger and TestBrokerWithConfig broker e2e test to new rekt test

This is the first of a series of PRs to migrate the e2e tests in test/e2e_broker to the new reconciler-test framework.
Proposed Changes

:broom: Migrate TestBrokerTrigger test
:broom: Migrate TestBrokerWithConfig` test

Running go test with args: -count=1 -race -tags=e2e -timeout=1h ./test/e2e_new_broker/...
PASS test/e2e_new_broker.TestBrokerWithConfig/Trigger_filters_events/Setup/Create_broker_config (0.13s)
PASS test/e2e_new_broker.TestBrokerWithConfig/Trigger_filters_events/Setup/Install_broker (0.15s)
PASS test/e2e_new_broker.TestBrokerWithConfig/Trigger_filters_events/Assert/[Stable/MUST]Broker_ready (3.13s)
PASS test/e2e_new_broker.TestBrokerWithConfig/Trigger_filters_events/Assert/[Stable/MUST]Topic_is_ready (0.06s)
PASS test/e2e_new_broker.TestBrokerWithConfig/Trigger_filters_events/Assert/[Stable/MUST]Replication_factor (0.04s)
PASS test/e2e_new_broker.TestBrokerWithConfig/Trigger_filters_events/Assert/[Stable/MUST]Number_of_partitions (0.04s)
PASS test/e2e_new_broker.TestBrokerWithConfig (5.80s)
PASS test/e2e_new_broker.TestBrokerTrigger/Trigger_filters_events/Setup/Create_broker_config (0.14s)
PASS test/e2e_new_broker.TestBrokerTrigger/Trigger_filters_events/Setup/Install_broker (0.18s)
PASS test/e2e_new_broker.TestBrokerTrigger/Trigger_filters_events/Setup/Install_sink (25.67s)
PASS test/e2e_new_broker.TestBrokerTrigger/Trigger_filters_events/Setup/Create_trigger (0.15s)
PASS test/e2e_new_broker.TestBrokerTrigger/Trigger_filters_events/Requirement/Send_matching_event (3.57s)
PASS test/e2e_new_broker.TestBrokerTrigger/Trigger_filters_events/Requirement/Send_non-matching_event (3.56s)
PASS test/e2e_new_broker.TestBrokerTrigger/Trigger_filters_events/Assert/[Stable/MUST]Broker_ready (0.04s)
PASS test/e2e_new_broker.TestBrokerTrigger/Trigger_filters_events/Assert/[Stable/MUST]Trigger_ready (0.04s)
PASS test/e2e_new_broker.TestBrokerTrigger/Trigger_filters_events/Assert/[Stable/MUST]Matching_event_received (0.00s)
PASS test/e2e_new_broker.TestBrokerTrigger/Trigger_filters_events/Assert/[Stable/MUST]Non_matching_event_is_not_received (20.00s)
PASS test/e2e_new_broker.TestBrokerTrigger (55.41s)
PASS test/e2e_new_broker

DONE 18 tests in 58.421s
Finished run, return code is 0

/assign @aliok @pierDipi @matzew

/test unit-tests

/test unit-tests

/test integration-tests

From reconciler-tests_eventing-kafka-broker_main/1620400568868540416:
Running go test with args: -count=1 -race -tags=e2e -timeout=1h ./test/e2e_new_broker/...


Added and Changed certain items

Added assorted barrows items, Changed Dart animation, Added dragon knife special attack and lastly blazing blowpipe + venator bow

Thanks for the PR - can you please reword the commit message to contain all of the information in your comment?

I think that may have worked? sorry new at this whole thing

I want to remove the 'ur nan' commit and only have the contents and message for 6a6ab59f3c3f0b7091fbe960fea4a6a17e59a12c. Try doing something like this: git reset --soft HEAD~3 ; git commit -m 'Added assorted barrows items, Changed Dart animation, Added dragon knife special attack and lastly blazing blowpipe + venator bow'

I am going to close this real quick and just restart. that did not work


Standardize dataframe keynames

This applies some basic sanity checks to the keys generated by
dask.dataframe.

cc @jcrist are you ok with these changes?  We're becoming a bit dumber in generating keynames

LGTM.


On CI, run unit tests in parallel

One of @iliakur's comments on my original diff, which I really liked.
The alternative is to add this to the pytest.ini so that tests always run parallel -- but I don't like the experience of pytest path/to/file.py still running parallel.

Followup: the speedup is a bit less than i thought it would be. So happy to abandon this diff if we don't think it's worth it!
Before:

After:

My two cents. I'd be interested in running the pipeline several times for this PR to see if there is actually a speed-up compared to what happens normally. Maybe Travis.ci gives us such low-powered machines that they can't actually handle the extra load from parallelization :D

totally agree! i don't see any reason for us to do anything beyond letting contributors know they can install pytest-xdist on their own. i'll certainly keep using it, since it cuts the test time in half (maybe more) for me. i found 3 processes to be my magic number, so i added that to the docs.

FWIW, i know nothing about travis CI. but i did wonder what the extra 45 mins were up to.... but also at the end of the day, the switch to pytest is about readability / maintainability, and less about optimization. i'd rather not add too much complexity shaving a few mins off a thing that works pretty well!

New speedup! (Mostly from not caching nltk_data)
Before:

After:

Is there consensus yet? My preference is less complexity, in the interests of maintainability.

thanks for following up!
this pull request kind of morphed, but nothing in it is particularly pressing. i'm just gonna close it.


Screenshot view is opened upon renaming in the Terra wdio tool window

Steps to reproduce

Open the Terra Wdio tool window
Start renaming a screenshot via the context menu action.
Hit enter in the rename popup dialog.

Expected results
The dialog closes and the screenshot is not opened.
Actual results
The dialog closes and the screenshot opens in a new editor.
Technical notes
The issue happens only when hitting Enter in the dialog, but not when clicking on the Ok button. This is because there is focus on the screenshot node being renamed, in the tool window, and since opening one of the screenshot views is bound to the Enter shortcut key, it is triggered as well.
A feasible solution could be to remove the focus from the screenshot node right before the rename dialog is opened.
Versions affected
0.1.0, 0.2.0, 0.3.0
Out of scope

N/A

Completed.

Completed.


Rely on matched route to emit path parameter

Finding out and folding correct path from the request's URL is error prone. Instead we can rely on current request's matched route and emit its path as the path label.
This removes any need of users needing to manually providing any input for custom URL folding. We just rely on their route definitions to which OpenAPM has access to.

Nest.js Metrics


Remove map method from answer store

What is the context of this PR?
From @ajmaddaford: "The Answer Store map method was originally created to output a WTForms POST data compatible format. This is then used to serialise the form data back into the WTForms form object.
The map method has since been used in the summary context, accessing the answer values from this flattened list. Accessing the answers in this way is unclear and from https://github.com/ONSdigital/eq-survey-runner/pull/1158 will mean both the mapped answer values (used for answer values) and the answer store are being used."
Latest changes include adding method chaining to the answer store objects as well as reducing the overall complexity of building summary context.
How to review

Complete survey and check summary page displays expected results
Ensure changes are clear and obvious
Check tests all pass across environments

All changes work for me, as they should

@shahi645 @ajmaddaford @dwyeradam a lot of big changes to the answer store interface just pushed up.

Summary pages display as expected, and all tests pass. LGTM 👍🏿

@jcox-dev  Squishy squashy


TensorRT provider failing with default options

ort = { version = "1.15.2", features = ["load-dynamic", "tensorrt"] }

Environment::builder()
   .with_execution_providers([ExecutionProvider::TensorRT(Default::default())])
   .build()?
   .into_arc();

ort::execution_providers: An error occurred when attempting to register `TensorrtExecutionProvider`: key/value cannot be empty

I spent some time poking around the onnxruntime and ort code. It looks like maybe onnxruntime is not getting the provider options somehow?

See

https://github.com/pykeio/ort/blob/ba9df1923026fcdf7f4e13152a8d5b8a901ffc0f/src/execution_providers.rs#L484
https://github.com/pykeio/ort/blob/ba9df1923026fcdf7f4e13152a8d5b8a901ffc0f/src/execution_providers.rs#L624

map_keys! needs in include a call to .retain(|k, v| !v.is_empty()) to remove all the empty strings for default arguments.

I've just used the v2 branch in the mean time.

You can test if my patch fixes it with
ort = { git = "https://github.com/bharrisau/ort.git", branch = "trt_config" , ... }
Else move to the v2 branch that seems to work for me
ort = { git = "https://github.com/pykeio/ort.git", branch = "v2" , ... }


Biological issue about BackSPIN ?

Hi @slinnarsson and All,
The loom data you deposited in http://mousebrain.org/downloads.html that had downloaded myself.
However It seem to me that i hardly known how to using the data 'l5_all.loom' that you upload as reference data to annotate my own data cells from scRNA-seq of mouse brain.
should i use the data 'l5_all.loom' to annotate my own scRNA cells using BackSPIN software?
Finally, how can i convert my normal count data into cef format data?
Any advice would be grateful.

If you want to use BackSPIN with cef files, all doc about cef is found here:
https://github.com/linnarsson-lab/ceftools
The cef format is basically a well-structured tab-delimited file with some annotations at the top. We use .loom now instead which is based on hd5. You can access it and convert it using R or python, python doc is here:
http://loompy.org/
We also switched from BackSPIN for clustering to cytograph which is still under development:
https://github.com/linnarsson-lab/cytograph
Since you write "count data" I guess your data is not UMI-based generated using 10X chromium like ours, so it may behave differently in the analysis software.
Once you generate lists of the most enriched genes in your cell clusters you should be able to compare the enriched gene lists against those in our clusters (available as an attribute in the aggregated l5_all_agg.loom file).
good luck
Peter Lönnerberg
Linnarsson Lab
Laboratory of Molecular Neurobiology
Dept. of Medical Biochemistry and Biophysics
Karolinska Institutet
SE-171 77 Stockholm
Sweden

Från: Alec hong<EMAIL_ADDRESS>Skickat: den 5 juni 2020 12:12
Till: linnarsson-lab/BackSPIN<EMAIL_ADDRESS>Kopia: Subscribed<EMAIL_ADDRESS>Ämne: [linnarsson-lab/BackSPIN] Biological issue about BackSPIN ? (#12)
Hi @slinnarssonhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fslinnarsson&data=02|01|peter.lonnerberg%40ki.se|d10fec49c8604a4085b308d80938f6d6|bff7eef1cf4b4f32be3da1dda043c05d|0|0|637269487543073486&sdata=EYKcPlKoimpTuzjfjytRcP3R9LpFFiQX6rjM2D8D2xE%3D&reserved=0 and All,
The loom data you deposited in http://mousebrain.org/downloads.htmlhttps://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmousebrain.org%2Fdownloads.html&data=02|01|peter.lonnerberg%40ki.se|d10fec49c8604a4085b308d80938f6d6|bff7eef1cf4b4f32be3da1dda043c05d|0|0|637269487543083486&sdata=Yok3RrXH0BVo%2FLVOQIs4aM1oTkq9GBK1KalomIPm1PE%3D&reserved=0 that had downloaded myself.
However It seem to me that i hardly known how to using the data 'l5_all.loom' that you upload as reference data to annotate my own data cells from scRNA-seq of mouse brain.
should i use the data 'l5_all.loom' to annotate my own scRNA cells using BackSPIN software?
Finally, how can i convert my normal count data into cef format data?
Any advice would be grateful.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flinnarsson-lab%2FBackSPIN%2Fissues%2F12&data=02|01|peter.lonnerberg%40ki.se|d10fec49c8604a4085b308d80938f6d6|bff7eef1cf4b4f32be3da1dda043c05d|0|0|637269487543083486&sdata=Xc7%2BKFogfohHJXlvNaVdMDrbjwJCIynZyZsn0%2FS2du8%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACE5O32X7236XMCQSLL7S4DRVDAJBANCNFSM4NTNMBXA&data=02|01|peter.lonnerberg%40ki.se|d10fec49c8604a4085b308d80938f6d6|bff7eef1cf4b4f32be3da1dda043c05d|0|0|637269487543093477&sdata=eTnGFsdPU6f80Ip7wXJh2sqW0yCOw3zhGT%2F1hudXTLw%3D&reserved=0.
När du skickar e-post till Karolinska Institutet (KI) innebär detta att KI kommer att behandla dina personuppgifter. Här finns information om hur KI behandlar personuppgifterhttps://ki.se/medarbetare/integritetsskyddspolicy.
Sending email to Karolinska Institutet (KI) will result in KI processing your personal data. You can read more about KI’s processing of personal data herehttps://ki.se/en/staff/data-protection-policy.


option to disable retina thumbnails added

should take care of this https://github.com/concrete5/concrete5/issues/2633

I tested this pull request and it works as described.
After checking "Disable retina thumbnails", retina thumbnails are not created for newly uploaded images.
Images that were uploaded to concrete5 before disabling retina thumbnails, do not display the retina thumbnail in the File Manager file Properties and Thumbnails, but the retina thumbnails exist in application/files/thumbnails. Rescanning existing images and clearing the thumbnail cache does not remove the retina thumbnails.

@MrKarlDilkington thanks for checking this.
I just figured that this is correct since thumbnails are left on the disk when I delete a thumbnail type too. I guess deleting, or more importantely, recreating them, would take a ton of time it might even break the site. Marking a file as stale would be nice.
Maybe a note would help to let users know that they should clear the thumbnail cache - once that has been fixed. Haven't tested it, but it might require this to be merged first https://github.com/concrete5/concrete5/pull/5900

This is a good addition, but can we change the way that the settings are worded? How about

Make the config key concrete.file_manager.images.create_high_dpi_thumbnails (so it's not tied to retina), and default this to true in application/config/concrete.php.
Make it so that in order to turn this off you simply uncheck the check box in the settings page (rather than clicking the checkbox in order to disable it.)

Thanks, this will definitely help upload times and site file sizes for many sites.

sure thing! Just made those changes

Thanks!


Update "Affiliate Entity Information" to "Immediate Parent Entity" & "Top-holding Parent Entity"

Per RIG guidance, we should change the "Affiliate Entity Information" to "Immediate Parent Entity" & "Top-holding Parent Entity".
"109(b) uses parent or top-holding parent entity.  I think we need to use those terms for the sections.  Affiliate is too broad and has other meanings, so it isn't quite accurate."
This needs to be updated on three pages:

"View your Financial Institution Profile"
"Update your Financial Institution Profile"
"Sign and Submit"

@chynnakeys @angelcardoz @dan-padgett
Does this look good?
View financial institution profile

Update financial institution profile

Sign and submit

@natalia-fitzgerald Apart from making the headings consistent with "(if applicable)" this seems to fit with the update request.

@angelcardoz @chynnakeys
We made these changes before beta launch. Is there any more work to do on this ticket in terms of tracking the work? If not can we close?


Trace boto3 rds data cs 24

:tada: This PR is included in version 1.75.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore: release

🤖 New release

lumina-cli: 0.3.1 -> 0.4.0 (✓ API compatible changes)
celestia-rpc: 0.4.1 -> 0.5.0 (✓ API compatible changes)
celestia-types: 0.5.0 -> 0.6.0 (⚠ API breaking changes)
celestia-proto: 0.3.1 -> 0.4.0 (⚠ API breaking changes)
lumina-node: 0.4.0 -> 0.5.0 (⚠ API breaking changes)
lumina-node-wasm: 0.3.0 -> 0.4.0

⚠ celestia-types breaking changes
--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/inherent_method_missing.ron

Failed in:
  ExtendedDataSquare::get_namespaced_data, previously in file /tmp/.tmpv8uEyg/celestia-types/src/rsmt2d.rs:398

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/method_parameter_count_changed.ron

Failed in:
  celestia_types::sample::Sample::new now takes 4 parameters instead of 5, in /tmp/.tmp4dzxZE/lumina/types/src/sample.rs:96
  celestia_types::sample::Sample::verify now takes 3 parameters instead of 2, in /tmp/.tmp4dzxZE/lumina/types/src/sample.rs:126
  celestia_types::row::Row::new now takes 2 parameters instead of 3, in /tmp/.tmp4dzxZE/lumina/types/src/row.rs:62
  celestia_types::row::Row::verify now takes 3 parameters instead of 2, in /tmp/.tmp4dzxZE/lumina/types/src/row.rs:69

--- failure module_missing: pub module removed or renamed ---

Description:
A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/module_missing.ron

Failed in:
  mod celestia_types::namespaced_data, previously in file /tmp/.tmpv8uEyg/celestia-types/src/namespaced_data.rs:1

--- failure pub_module_level_const_missing: pub module-level const is missing ---

Description:
A public const is missing, renamed, or changed from const to static.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/pub_module_level_const_missing.ron

Failed in:
  NAMESPACED_DATA_ID_MULTIHASH_CODE in file /tmp/.tmpv8uEyg/celestia-types/src/namespaced_data.rs:24
  NAMESPACED_DATA_ID_CODEC in file /tmp/.tmpv8uEyg/celestia-types/src/namespaced_data.rs:26

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/struct_missing.ron

Failed in:
  struct celestia_types::NamespacedRow, previously in file /tmp/.tmpv8uEyg/celestia-types/src/share.rs:36
  struct celestia_types::namespaced_data::NamespacedData, previously in file /tmp/.tmpv8uEyg/celestia-types/src/namespaced_data.rs:45
  struct celestia_types::namespaced_data::NamespacedDataId, previously in file /tmp/.tmpv8uEyg/celestia-types/src/namespaced_data.rs:34
  struct celestia_types::NamespacedShares, previously in file /tmp/.tmpv8uEyg/celestia-types/src/share.rs:28
  struct celestia_types::RawShare, previously in file /tmp/.tmpv8uEyg/celestia-types/src/share.rs:194

--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---

Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/struct_pub_field_missing.ron

Failed in:
  field id of struct Sample, previously in file /tmp/.tmpv8uEyg/celestia-types/src/sample.rs:46
  field id of struct Row, previously in file /tmp/.tmpv8uEyg/celestia-types/src/row.rs:43

⚠ celestia-proto breaking changes
--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_missing.ron

Failed in:
  enum celestia_proto::share::p2p::shwap::ProofType, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/share.p2p.shwap.rs:40
  enum celestia_proto::share::p2p::shrex::nd::StatusCode, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/share.p2p.shrex.nd.rs:29

--- failure module_missing: pub module removed or renamed ---

Description:
A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/module_missing.ron

Failed in:
  mod celestia_proto::share::p2p::shwap, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/mod.rs:88
  mod celestia_proto::share::p2p, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/mod.rs:82
  mod celestia_proto::share::p2p::shrex::nd, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/mod.rs:84
  mod celestia_proto::share::p2p::shrex, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/mod.rs:83

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/struct_missing.ron

Failed in:
  struct celestia_proto::share::p2p::shrex::nd::NamespaceRowResponse, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/share.p2p.shrex.nd.rs:20
  struct celestia_proto::share::p2p::shwap::Row, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/share.p2p.shwap.rs:6
  struct celestia_proto::share::p2p::shwap::Data, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/share.p2p.shwap.rs:30
  struct celestia_proto::share::p2p::shwap::Sample, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/share.p2p.shwap.rs:16
  struct celestia_proto::share::p2p::shrex::nd::GetSharesByNamespaceRequest, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/share.p2p.shrex.nd.rs:4
  struct celestia_proto::share::p2p::shrex::nd::GetSharesByNamespaceStatusResponse, previously in file /tmp/.tmpv8uEyg/celestia-proto/target/semver-checks/local-celestia_proto-0_3_1/target/semver-checks/target/debug/build/celestia-proto-be43742c3fc9969a/out/share.p2p.shrex.nd.rs:12

⚠ lumina-node breaking changes
--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_variant_added.ron

Failed in:
  variant P2pError:Shwap in /tmp/.tmp4dzxZE/lumina/node/src/p2p.rs:149

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/inherent_method_missing.ron

Failed in:
  Node::request_namespaced_data, previously in file /tmp/.tmpv8uEyg/lumina-node/src/node.rs:357
  Node::request_namespaced_data, previously in file /tmp/.tmpv8uEyg/lumina-node/src/node.rs:357

Changelog
lumina-cli

0.4.0 - 2024-10-03
Added

(node,node-wasm) [breaking] Integrate graceful shutdown in WASM (#396)

celestia-rpc

0.5.0 - 2024-10-03
Added

[breaking] shwap protocol updates (#369)

celestia-types

0.6.0 - 2024-10-03
Added

[breaking] shwap protocol updates (#369)
(types) align for building for riscv32 (#393)

celestia-proto

0.4.0 - 2024-10-03
Added

[breaking] shwap protocol updates (#369)

lumina-node

0.5.0 - 2024-10-03
Added

[breaking] shwap protocol updates (#369)
(node,node-wasm) [breaking] Integrate graceful shutdown in WASM (#396)

lumina-node-wasm

0.4.0 - 2024-10-03
Added

(node,node-wasm) [breaking] Integrate graceful shutdown in WASM (#396)

Other

Include API in readme  (#409)
(node-wasm) Switch to bundler target for wasm-pack for manifest v3 (#398)
(node-wasm) clarify edge case when polling worker on startup (#390)

This PR was generated with release-plz.

closing to re-run initial PR generation


Include transaction metadata in coin selection and fee calculations

Issue Number
ADP-307 / #2075
Overview
Adds metadata as a parameter of coin selection and fee calculation functions.
Comments

Based on PR #2089 branch.

bors r+

superseded by #2096


Add graphite sink for databus metrics

@rajubairishetti  - Can you review this?

Looks good to me overall

Please merge. Also tested on graphite staging endpoint.

Thanks Abhishek for the contribution


Hi,
I used your guide to run a Background Service via JobScheduler and send that information with broadcast receiver to the main activity.
My app gathering barometer sensor data in the background.
The problem is that Android Destroy the JobService after a few minutes.
Is there any option to run JobService forever?
Thanks

Found solution:
https://stackoverflow.com/questions/47531742/startforeground-fail-after-upgrade-to-android-8-1/51281297#51281297


Crash on startup due to mismatched DPI

Current behavior
The app will open with a blank window and then crash before loading content.
How to reproduce it (as minimally and precisely as possible)

Open DevToys-Preview from the Start menu
It crashes
After changing my system scaling (which is normally 125%) to 100%, it started working. On changing back to 125%, it now launches correctly.

Expected behavior
The app should launch.
Screenshots
No response
Workaround
Change DPI in system settings and back. Unclear if app needs to be launched in between changing.
Affected platforms
Windows
Affected DevToys kind
DevToys (app with GUI)
DevToys Version
Version 2.0-preview.1 | Windows 11 26100.712
Relevant Assets/Logs
Exception from Visual Studio debugger:
WebView2: Initialization failed due to a mismatch in DPI awareness. Please ensure that the DPI awareness of the host app matches the DPI awareness of current WebView2 processes using the same user data folder.

Hi,
Thanks for sharing. My machine is often in 125% too and I never encountered this issue unfortunately. 🤨
I would need more data. Perhaps you can share the logs by any chance? See https://devtoys.app/doc/articles/sysadmin/logs.html?tabs=windows

Sure, this is the log from when I first ran it. log-20240203T122628.txt
When I ran it in the debugger it did not get past [1]	App is starting... because it was stopping at the WebView2 initialization.
This is what the debugger output looked like. native output.txt
I’m not certain it would fix the issue, but DevToys should declare per-monitor/per-monitor v2 scaling either way. Right now, it’s running in System scaling. It looks like WPF does not respect the declaration in the .csproj file and it has to be specified in the SxS manifest.

Indeed, at least I should add this to the manifest!


Pin takes forever to send

when testing on live, pin takes forever to send

Could be Paystack downtime. Please, reopen if the issue persists.


Expose WorkflowIdConflictPolicy

What was changed
Added enum WorkflowIdConflictPolicy that can be passed to WorkflowOptions in the client API.
Updated protobuf DTOs.
A breaking change was detected in https://github.com/temporalio/api/pull/393, which broke the mapping of WorkflowExecutionInfo. The change has been accounted for.
Checklist

Closes #416
How was this tested: added tests for WorkflowOptions
Wait for https://github.com/roadrunner-php/roadrunner-api-dto/pull/11
Wait for https://github.com/temporalio/sdk-go/pull/1418 ❓

@roxblnfk This PR only adds the support for StartWorkflow, not SignalWithStart, is that correct? If so, I've filed https://github.com/temporalio/sdk-php/issues/479 as a follow-up.


Jumping LDR readings

Duplicating https://github.com/QuentinCG/Arduino-Light-Dependent-Resistor-Library/issues/7#issue-1084082122 - it could be solved there or here, waiting for the library's author to decide:
when I built a device with a display that was expected to adapt to ambient lighting, I noticed the readings of my GL5528 jumping around as soon as ceiling lighting was powered on. This lighting consists of LEDs controlled by phase-cut dimmers.
It seems that the LDR, which has a top speed of 20ms (==50 readings per second) was sensitive to this kind of dimmers. There hadn't been any "jumping values" with classic halogene bulbs.
So I was wondering whether it would be a good idea to implement some kind of smoothing within the library, offering a parameter specifiying the number of past readings to be used for smoothing?

(Of course I will contribute and implement the smoothing, if accepted)

I created a PR for the LDR library.
Nevertheless, my problem still persists. As this definitely isn't a software issue, I'll close this "Issue" and create a discussion.

I created a PR for the LDR library. After the owner of the library accepts the PR, @o0shojo0o would need to

add a parameter in the photocell constructor specifying the number of readings to be used for smoothing (I'd recommend at least 10, which would smooth along 10 readings, taking 10 seconds to fully adapt for permanent changes, but maybe even 20 or 30).
replace calls to getCurrentLux() by getSmoothedLux()

I still have trouble with my LDR, but will continue this in a discussion.

Fluctuations could be because of unstable supply / voltage drop or unstable voltage reference of the ESP.
Mine is mostly stable, but sometimes PixelIt changes back and forth between two brighness levels. I did some smoothing in node-red before the brighness regulation feature got built in.

Added BH1750 support, which partly mitigates this issue.
I'll keep this issue open, as smoothing still might be helpful (only available with LDR, not with BH1750).

Solved by 0.3.16


MSCRM Plugin Registration: Object reference not set to instance of an object.

Hi Wael,
We are having this issue when using MSCRM Plugin Registration task and this issue is happening while trying to register "Create" step for plugin assembly.

Is it possible to get more details to understand the error cause?
Thanks,
Zeshan

@WaelHamze Can you please update on this?
thanks..

@devmzeshan please set system.debug = true and share the logs

@WaelHamze Apologies for the delayed response, I have attached the logs.
ReleaseLogs_63.zip

@WaelHamze any updates on this?

I seem to experience a similar issue.
the registration seems to work tough.
plugin assembly, plugin and the step get registered, but it still throws an exception.
##[debug]Caught exception from task script. ##[debug]Error record: ##[debug]Set-XrmPluginRegistration : Object reference not set to an instance of an object. ##[debug]At C:\Agent\_work\tools\MSCRMBuildTools\9.1.2\xRMCIFramework\9.0.0\PluginRegistration.ps1:40 char:1 ##[debug]+ Set-XrmPluginRegistration -RegistrationType $RegistrationType -Assemb ... ##[debug]+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ##[debug]    + CategoryInfo          : NotSpecified: (:) [Set-XrmPluginRegistration], NullReferenceException ##[debug]    + FullyQualifiedErrorId : System.NullReferenceException,Xrm.Framework.CI.PowerShell.Cmdlets.SetXrmPluginRegistrati    on ##[debug]  ##[debug]Script stack trace: ##[debug]at <ScriptBlock>, C:\Agent\_work\tools\MSCRMBuildTools\9.1.2\xRMCIFramework\9.0.0\PluginRegistration.ps1: line 40 ##[debug]at <ScriptBlock>, C:\Agent\_work\_tasks\MSCRMPluginRegistration_a48708ef-a5d6-4af5-a9be-589847132834\11.0.1\MSCRMPluginRegistration.ps1: line 38 ##[debug]at <ScriptBlock>, <No file>: line 1 ##[debug]at <ScriptBlock>, <No file>: line 22 ##[debug]at <ScriptBlock>, <No file>: line 18 ##[debug]at <ScriptBlock>, <No file>: line 1 ##[debug]Exception: ##[debug]System.NullReferenceException: Object reference not set to an instance of an object. ##[debug]   at Xrm.Framework.CI.Common.PluginRegistrationHelper.UpsertPluginTypeAndSteps(Guid parentId, Type pluginType, String solutionName, RegistrationTypeEnum registrationType) ##[debug]   at Xrm.Framework.CI.PowerShell.Cmdlets.SetXrmPluginRegistration.ProcessRecord() ##[debug]   at System.Management.Automation.CommandProcessor.ProcessRecord()

I am actually just having troubles figuring out how to generate the plugin mapping file. There doesn't seem to be any documentation around this, although I did find the schema and a sample json so I guess I'll manually build it.
PS @devmzeshan Just wanted to highlight that your password is in your logs, if you haven't already changed it.

@qdi-jeffd, you can only generate a schema based on an existing registration. You can do that with the power shell cmdlets. But for new registrations, you'll have to create the mapping manually

@qdi-jeffd If you have plug-ins in your environment already. You can use this script to generate the mapping file.
https://github.com/WaelHamze/dyn365-ce-devops-sample/blob/master/Sample/Xrm.CI.Framework.Sample/Xrm.CI.Framework.Sample.Plugins/GetPluginRegistration.ps1
I see many users generate the steps etc.. using plug-in registration tool in env and then generate a json from that.
You can also do this manually if you like and if you are familiar with the object model. You can link your mapping file to this schema file in visual studio which will give you some intellisense
https://github.com/WaelHamze/xrm-ci-framework/blob/master/MSDYNV9/Xrm.Framework.CI/Xrm.Framework.CI.Common/PluginRegistration/PluginRegistrationSchema.json

@strwase can you share the mapping file?
I am specifically interested in what is in the mapping file after this step and how is this different than previous steps.
2019-06-24T06:34:28.6261028Z ##[debug]Upsert SdkMessageProcessingStep 7c18d1a2-1b3a-4e89-990b-d2d1d8ed43bf completed

Hi @WaelHamze,
here is the mappingfile i'm using.
{ 	"$schema": "./PluginRegistrationSchema.json", 	"Id": "{9e9d9681-b7b5-46a4-8c45-77a4f56a6a95}", 	"Name": "Norriq.Crm.Codipack.Plugins.dll", 	"IsolationMode": "Sandbox", 	"SourceType": "Database", 	"PluginTypes": [ 		{ 			"Id": "{8876e445-d064-4b0f-84ec-4d9932cb5983}", 			"Name": "Norriq.Crm.Codipack.Plugins.QuotePropertyTemplate.CopyTemplateQuestions: Create of nrq_quotepropertiestemplate", 			"FriendlyName": "0d6cf174-4b19-437a-ac51-9ba0c4c37cab", 			"TypeName": "Norriq.Crm.Codipack.Plugins.QuotePropertyTemplate.CopyTemplateQuestions", 			"Steps": [ 				{ 					"Id": "{c4a291af-33b9-4802-8ffa-5ed99187c9b5}", 					"Name": "Norriq.Crm.Codipack.Plugins.QuotePropertyTemplate.CopyTemplateQuestions: Create of nrq_quotepropertiestemplate", 					"MessageName": "Create", 					"PrimaryEntityName": "nrq_quotepropertiestemplate", 					"Mode": "Synchronous", 					"Stage": "Postoperation", 					"SupportedDeployment": "ServerOnly", 					"StateCode": "Enabled", 					"Rank": 1, 					"AsyncAutoDelete": false 				} 			] 		} 	] }
as far as I can tell, the step registration completes, but then an exception get thrown from somewhere.
##[debug]Upsert SdkMessageProcessingStep c4a291af-33b9-4802-8ffa-5ed99187c9b5 completed ##[debug]Caught exception from task script. ##[debug]Error record: ##[debug]Set-XrmPluginRegistration : Object reference not set to an instance of an object. ##[debug]At C:\Agent\_work\tools\MSCRMBuildTools\9.1.2\xRMCIFramework\9.0.0\PluginRegistration.ps1:40 char:1 ##[debug]+ Set-XrmPluginRegistration -RegistrationType $RegistrationType -Assemb ...

@WaelHamze I do have an existing plugin that I am trying to automate deployment of. I cannot get that script to work for my environment it seems though. I am connecting to an organization on D365 and if I use the url of the organization I get the following:
The service '/XRMServices/2011/Discovery.svc' cannot be activated due to an exception during compilation.  The exception message is: Could not load file or assembly
'Microsoft.Crm.Site.Services.
Which a little research shows for that for D365 I need to use the discovery url, but providing that isn't working either. The error I get when I switch to the disco url is:
Unable to login to Dynamics CRM, Error was : clientCredentials.UserName.UserName or clientCredentials.Windows.ClientCredential.UserName MUST be populated!
I have been providing the credentials though. I started building the mapping file manually, but it would be great to figure out what I am doing wrong to generate it via the script.
Thanks!

I still am having no luck with getting the script to generate my mapping file. I was able to get a connection string formatted that works through XrmToolBox (turns out some of the issues I was having were due to federated security on my account and MFA). Using an App registration and client secret I can get xrmtoolkit connecting, but not the powershell script. I am getting the error I mentioned above about Microsoft.Crm.Site.Services even when I use the disco url.
With a manually created partial mapping file (just did the first plugin and step). I get to the same point as the other two users here and get the Object reference error.
Any help you can give is appreciated. If it helps to know more about our environments to see what is common I am running the plugin registration through a pipeline in Azure DevOps On prem. The build agents run on Windows Server, I could grab some other versions if needed but Power Shell is on version 5.1.14409.1018.

@strwase @devmzeshan FYI In my case it turned out to be bad json for the plugins. Specifically that I had put
"Images": null
Instead of
"Images": []
As the specific plugin that I was testing with did not have images for any of it's steps.
I still cannot generate the json file though.
Jeff

Try copying your plugin dll to your script folder where you are running.  I was getting a blank json file generated before I did this.  Works great now.


Incorrect RavenDB OneTimeToken query

I bet you hate seeing all these new bug reports from me.
In relation to log error:
[19:23:11 Error] Aguacongas.IdentityServer.Admin.Services.TokenCleanerHost
Exception removing expired grants: Raven.Server.Documents.Queries.Parser.QueryParser+ParseException: 2:25 Expected end of query but got: -03-29T21:53:11.0026085Z
In your RQL functions (e.g. for OneTimeToken cleanup), you need to wrap dateTime in quotes e.g.
from OneTimeTokens where Expiration < 2021-03-29T21:53:11.0026085Z order by CreatedAt
becomes
from OneTimeTokens where Expiration < "2021-03-29T21:53:11.0026085Z" order by CreatedAt
ISO8601 dates are sorted lexicographically provided they are in the same timezone (these all appear to be UTC).

By the way, the RavenDB models aren't really modelled in the "document db" way ... it's more like a relational model dropped into RavenDB. This tends to pollute the collections quite a bit (e.g. my RavenDB collections against IdentityServer2 were only about 6 different collections from memory). It'd be good to prefix the class names with a common prefix (using a DocumentStore convention if you can't change the class names) e.g. TheIdSrvCOLLECTION.
store.Conventions.FindCollectionName = type => {     if (typeof(Client).IsAssignableFrom(type)) return "TheIdSrv"+DocumentConventions.DefaultGetCollectionName(type);     return DocumentConventions.DefaultGetCollectionName(type); };

@ben-jacobs :-D no I don't. I like people contributing to open source, and you are really helpful to me.
Yes, the RavenDb models is not modelled in a "no SQL way" to be easier to map from relational model using OData like request and be able to handle expand instructions. So it's why I've to design the document store like this.
Can you open a new enhancement for the collection prefix please ?

I get why you've done it the way you have and no complaints from me :)
The collection prefix is kind of a middle-ground to separate concerns at the database level (e.g. one of your collection names collided with one of my existing ones).
Will do an enhancement request (I think the most complex bit of that will be in resolving the collection names when you're building up the query string).
As always, you've made a great project that really tries to simplify what can be a VERY frustrating part of app development - I've been using IdSrv (mainly 2) for over 5 years, and I always cringe when I have to touch my codebase relating to identity.


:Helptags does not work if script is never run

Now that Vim has native package support, I don't always call pathogen#infect(), but I would still like to use the :Helptags command.  But because the autoload script is never executed, the command is never added.
Maybe the :command Helptags ... should be in plugin/pathogen.vim?  The downside of this is installation is no longer as super-simple.
Alternatively, the whole file could move into plugin/.  Most people run it first thing in their .vimrc anyway.  My particular scenario happens to be the worst case for needlessly loading.

:Helptags was always intended to be called interactively. If you really must generate help tags on every startup, you can call pathogen#helptags().

I misread, you do want to call it interactively. You can runtime! autoload/pathogen.vim in your vimrc. I'm not changing changing the installation method this late in the game.

You misunderstand. I want to add the command on every startup, not call it.

I'm not changing changing the installation method this late in the game.

Fair enough.


Change Default Commandline Configuration Name to Release

Fix for issue #708 so that the commandline default configuration is Release rather than Debug

Thanks!


Request to Add Support for MySQL Versions Prior to 5.7 (e.g., 5.0 and 5.6) in Zig Library

I hope this message finds you well. I am currently using your Zig library and would like to request support for MySQL versions prior to 5.7, specifically versions like 5.0 and 5.6. It appears that the library is primarily optimized for newer MySQL versions, and I have a requirement to interact with databases running on older MySQL installations.
Could you please consider adding compatibility for MySQL versions such as 5.0 and 5.6 in your library? Alternatively, any guidance on how to adapt the library to work with these older versions would be greatly appreciated.
Thank you for your attention to this matter. I look forward to your response.

@gaogaogoo Thanks for filing this issue. Yes, you are right that this lib is mostly for newer version of MySQL, as I would have assume that most users wont have MySQL version older than that. Are 5.0 and 5.6 the versions of MySQL which you are using this library to connect to?

@gaogaogoo Thanks for filing this issue. Yes, you are right that this lib is mostly for newer version of MySQL, as I would have assume that most users wont have MySQL version older than that. Are 5.0 and 5.6 the versions of MySQL which you are using this library to connect to?

Yes, I am trying to use the library to connect to MySQL version 5.0, but it returns an UnsupportedAuthPlugin error. We have some old projects without source code that cannot be updated but require further functionality, so we need to connect to older MySQL versions. We like the Zig language and plan to use it in future work, so we hope to use this library.

@gaogaogoo What is the name of the plugin? It should be printed along with the error
https://github.com/speed2exe/myzql/blob/main/src/conn.zig#L86

I re-tested it and encountered the array out-of-bounds error again. After considering it, I plan to use Zig to statically link the Rust MySQL client library and access MySQL through Rust to resolve the issue of MySQL not supporting older versions. Thank you, and I'll close this issue for now.


Fix hyundai EV gas signal

There was some use in the Discord that mentioned this code worked for him BTW. We have some other users waiting on this.

superseded by #1694


schema: Introduce an IPv6 CIDR for the vm network

What this PR does / why we need it:
When using the masquerade binding method, an internal IPv6 network is used
for the pod-vm communication.
This change introduces the ability to customize this network address in
scenarios where the default one cannot be used.
Special notes for your reviewer:
Tests are missing for both CIDR 4 and 6.
Release note:
Add `vmIPv6NetworkCIDR` under `NetworkSource.pod` to support custom IPv6 CIDR for the vm network when using masquerade binding.

/cc @AlonaKaplan , @maiqueb , @qinqon

/cc @AlonaKaplan @maiqueb @qinqon

The change lgtm. Would love to see e2e test. Do you plan to add it in a separate PR?

The change lgtm. Would love to see e2e test. Do you plan to add it in a separate PR?

Thanks!
I plan to add them here once I arrange the current mess.

#3460 introduces tests for the IPv4 CIDR scenario.
Unfortunately, doing the same for IPv6 is more challenging and requires modifications to the existing code (i.e. refactoring).

/lgtm

Can you add tests?

I commented about it (see above). The current implementation does not allow doing it without a refactor effort. However, https://github.com/kubevirt/kubevirt/pull/3454 may do the job and then it will be easy.

I commented about it (see above). The current implementation does not allow doing it without a refactor effort. However, #3454 may do the job and then it will be easy.

Ok.
/hold
Let's wait for tests. Feel free to cancel the hold once they are there.

/sig network

/remove-lifecycle stale

/hold cancel

/approve

/retest

/retest


Crashing obsidian on Android

My vault is about 3k notes and if I have sync turned my obsidian crashes shortly after launching it. After disabling sync it runs fine. Couldn't be due to memory allocation.

Update: If I have the plugin disabled and then turn it on after a while, it seems to not crash. Therefore, a delay option could help.


Bump dev wallet to v0.7.2

Codecov Report

Merging #1103 (b1dcdbb) into master (bf397db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1103   +/-   ##
=======================================
  Coverage   39.33%   39.33%
=======================================
  Files          37       37
  Lines        1866     1866
=======================================
  Hits          734      734
  Misses       1047     1047
  Partials       85       85

Flag
Coverage Δ

unittests
39.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jribbink  likely needs a go mod tidy


Refactor tests

From the Makefile:
test:
	poetry run tox

testOnlyDocTests:
	poetry run pytest --doctest-modules --cov-report term-missing --cov-report html:htmlcov --cov=src/cltkv1 src/cltkv1/ --ignore=tests

testOnlyTestsDir:
	poetry run pytest --disable-warnings tests

testOnlyDocTests takes 24 mins with the models already downloaded.
Let's see how it runs on the server … might not be much faster than before.

Refactored doctests all pass: https://travis-ci.org/github/cltk/cltkv1/builds/701420862
Going to try the full suite next

Here's what the matrix build looks like, currently first passed second running: https://travis-ci.org/github/cltk/cltkv1/builds/701438712

Things looking like all will: pass https://travis-ci.org/github/cltk/cltkv1/builds/701488078


Download and Documentation links are stale

The Documentation and Download links point to java.net which has been shut-down for awhile now. Please refresh these URLs with the current locations.

@edbratt - I updated this and this link on the Wiki to at least have some reference to the latest download SE TCK zip and the original Reference Guide.
I think this maybe provides a bare minimum access to this.
Obviously there's a lot that could be improved, but in the meantime if there's something else specific you were looking for, please add a comment.

That's much better and good enough for now. Thanks!


Unable to create a index

elastalert-create-index
Traceback (most recent call last):
File "/bin/elastalert-create-index", line 5, in
from pkg_resources import load_entry_point
File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 3011, in
parse_requirements(requires), Environment()
File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 626, in resolve
raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: requests==2.2.1

You can either run python -m elastalert.create_index.
Or, uninstall elastalert and reinstall via pip install elastalert.
Or attempt to fix the dependencies, pip install requests==2.2.1.
Sorry about that. I need to remove setuptools (python setup.py install) from the documentation..

Thanks Qmando


adapt to new SurrogatesBase and improve performance of add_points

what version of SurrogatesBase are you referring to?

samuelbelko/SurrogatesBase.jl#1

I merged all proposed changes while adapting to recent changes of SurrogatesBase. Copying of the arguments is not yet optional though.


Testing for existance of exec()

Tests for existence of exec() function so as not to raise notices on systems where "exec() has been disabled for security reasons".

LGTM

I took me some digging to confirm that function_exists actually returns false for disabled functions, because there are a lot of things online saying that it will return true but just error out. It seems that as of at least 5.3+ if a function is disabled via the ini file then this method will work. I think that is good enough.


Setting Nonce

OS: Mac OS Monterey 12.5
Device: iPhone 8 (Global)
IOS: 15.6.1
I received the following permissions/privilege error when trying to set nonce
localhost:/ root# nvram com.apple.System.boot-nonce=0x1111111111111111
Error setting variable - 'com.apple.System.boot-nonce': (iokit/common) privilege violation.

maybe try a older ipsw, like 14.8

you know what, im just reverting that change i made a few days ago to remove ibec

kernel patch is needed for this to work, ugh

can you run git pull
then recreate the ramdisk, then ./sshrd.sh set-nonce 0x1111111111111111

Is the nonce supposed to stay set? After setting nonce it immediately reboots then I go back into pwndfu mode and use irecovery -q to check the nonce and it is different (doesn't match my blobs). When I repeat and nonce is again different every time?

yyeah futurerestore is probably better at the nonce part. i cant figure out why it's not writing that ONLY var to the nvram

Thanks for looking into it for me! I tried a few more times but they didn't get set and saved. Then I decided to use the a11dfu.sh script to do recovery then dfu with futurerestore and it started working right after that.


Renderton processes do not seem to terminate

After running the rendertron for a couple of days, I have several dozen of its processes eating up server resources:
root      2086  0.0  0.1 4763004 39344 ?       Sl   Oct22   0:00 /srv/renderton/git/node_modules/puppeteer/.local-chromium/linux-722234/chrome-linux/chrome --type=renderer --no-sandbox --al
root      2234  0.0  0.1 4763004 36428 ?       Sl   Oct22   0:00 /srv/renderton/git/node_modules/puppeteer/.local-chromium/linux-722234/chrome-linux/chrome --type=renderer --no-sandbox --al

have I overlooked some parameter in the configuration, or is this maybe a known issue?

It looks like Chromium isn't removing its renderer child processes.
This might be addressed with #502 so keep an eye on that :)

Did you try it with Rendertron 3.1.0 and the new (optional) closeBrowser config flag set to true?

ok, deployed the 3.1.0, will see how it works ;)

@marek99 Any news? :)

Seems fine by now. Five chrome processes running (four of them since last deployment).

Alright, thanks for the feedback! I'll close this bug for the moment, feel free to reopen if this issue reappears!


⚠ Bofrost.at has degraded performance

In 157ae19, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2454 ms

Resolved: Bofrost.at performance has improved in e889b22 after 6 minutes.


Feature Request: Show a browser notification on golden cookie or reindeer

Per the title, when a golden cookie or a reindeer appears, CM could show a browser notification to allow clicking on it to be brought to the tab immediately.

I'd be willing to undertake this if you're okay with the feature.

Sorry for the late response.  Sure!  That be a great feature!

This has now been added to the dev-branch!


Fix kth_smallest not accounting for duplicate elements, and any_of

Fixes #65 and #60.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9e60787) 96.91% compared to head (1da904f) 96.84%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   96.91%   96.84%   -0.08%
==========================================
  Files          56       56
  Lines        3701     3708       +7
==========================================
+ Hits         3587     3591       +4
- Misses        114      117       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Changes look good.


Cannot gauge amount of content based on scrollbar

Describe the bug
It is not possible to tell how close to the "end" of content you are with the scrollbar position. Many times it will change because more content loads as you near the end. This may confuse users who want an idea of their reading position.

Let's revisit in refinement and see if we can find a good way to fix

This should be much improved with the work in #321


autocomplete: Show tags on focus, close dropdown on loss of hover.

It would be a nice option for autocomplete to show tags on focus and close dropdown on loss of hover.
Otherwise the user needs to click somewhere else for the menu to close.

Sorry for not replying sooner.
I honestly have never seen that behavior in any autocomplete/dropdown list. But I don't mind ngTagsInput supporting that scenario as longs as it's opt-in. I'll add this to the backlog.
FWIW, the user can close the autocomplete list by doing one of the following things:

Clicking elsewhere on the page;
By pressing the escape key;
By selecting a suggestion.

it makes sense as an alternative to multiselect, i would also like to see this

Thanks @Jakobovski for submitting this issue. It is a very surprising behavior.
Go to one of your demos or check out the attachment:

Add a country, and type enter. The tag is added, the lists opens again.
Now remove a country using the backspace key. The tag is removed, the lists does NOT open again.
@mbenford I think @Jakobovski and myself would like to have the list close itself after a tag is added.
Thanks,

This issue was selected to be spring-cleaned by a script. More information can be found here.
If anyone thinks this was a mistake and this issue should be reopened, please leave a message below explaining why. Before doing so, please consider reading the CONTRIBUTING file.


Private channels do not respond to renames properly

Description
when a channel is renamed, it does not get renamed in irslackd
Steps to reproduce

... create channel in slack
... rename channel in slack
... note that channel is not renamed in irslackd

Expected behavior
channel should be renamed

hmmm ... i lie ... it looks like maybe it just takes a little bit?  closing for now

it looks like this happens for private channels

Tracking here https://github.com/adsr/irslackd/issues/75


Release PR for public release r1.2 (M4)

What type of PR is this?
Add one of the following kinds:

documentation
subproject management

What this PR does / why we need it:
Issues #95  and #97
Which issue(s) this PR fixes:

Fixes #95 and #97
Special notes for reviewers:
Changelog input
 release-note

Additional documentation
This section can be blank.
docs

^ just those minor tweaks above otherwise LGTM @maheshc01

@maheshc01 @Kevsy according to the release numbering this is r1.2, not r1.1 (you have already the tag r1.1). If it make sense to keep the releases notes of r1.1 within the CHANGELOG might be an open topic, but currently the guidelines say that the new release is just added on the top, leaving the history unchanged.

API versioning was decoupled from release numbering:
https://wiki.camaraproject.org/display/CAM/API+versioning
https://wiki.camaraproject.org/display/CAM/API+Release+Process#APIReleaseProcess-APIreleasenumbering
So every reference to r1.1-rc.1 should be changed to r1.2
The example of changes  for M4 and the CHANGELOG structure for QoD: https://github.com/camaraproject/QualityOnDemand/pull/353

updates to CHANGELOG is what is not clear to me.
I am trying to refer other CAMARA APIs but still doesnt help. for example full changelog currently points to 1.1. Would that be just replaced with 1.2 and the content of the full change log needs to be same as 1.1?

@maheshc01 In this special situation (only one pre-release, no previous public release to compare with) I have full understanding for the confusion. Yes, r1.2 would more or less repeat the changes from r1.1. But you might want to select and reformulate for a different audience: while the pre-release was (theoretically) for implementors, the public release has now also API Customers as audience.
An example which which shows r1.1 and r1.2 in the CHANGELOG.md and also that r1.2 could be a selection out of r1.1 changes: https://github.com/camaraproject/HomeDevicesQoD/pull/70

updates to CHANGELOG is what is not clear to me.
I am trying to refer other CAMARA APIs but still doesnt help. for example full changelog currently points to 1.1. Would that be just replaced with 1.2 and the content of the full change log needs to be same as 1.1?

@maheshc01 In this special situation (only one pre-release, no previous public release to compare with) I have full understanding for the confusion. Yes, r1.2 would more or less repeat the changes from r1.1. But you might want to select and reformulate for a different audience: while the pre-release was (theoretically) for implementors, the public release has now also API Customers as audience.
An example which which shows r1.1 and r1.2 in the CHANGELOG.md and also that r1.2 could be a selection out of r1.1 changes: camaraproject/HomeDevicesQoD#70

have made the updates to use release r1.2.
in the changelog i have made the information on individual APIs look more concise to avoid repeating the same text twice. Hope that looks ok.
@hdamker please review and let me know if i have missed anything or further changes are required.

Hi @rartych,
I have committed changes to apply the fixes based on your review comments.
both the changes are related to updates made to changelog as follows:

revert the content that was part of r1.1 to keep the history of the file unchanged and only add updates related to r1.2
naming convention for the APIs followed as per the release mgmt guidelines.

requesting for your review.

Contact field in Camara specifications does not include valuable information.
It was decided to remove optional fields from info object:
https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#info-object
I suggest to remove contact from info object in all yaml files

have made the updates to use release r1.2.
in the changelog i have made the information on individual APIs look more concise to avoid repeating the same text twice. Hope that looks ok.
@hdamker please review and let me know if i have missed anything or further changes are required.

@maheshc01 Consider the release notes for r1.2 as completely independent from the previous content of the CHANGELOG, listing all changes since the last public release. An API user who is relying on the latest public release should not be forced to read the pre-release notes. (see https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.30.md#v1300 for an - extreme - example).
We copy currently exactly this part into the release description of GitHub.
I suggest that the release notes for r1.2  in your case should at least mention that this is the first public release of these APIs (which is not obvious as the version numbers are already 0.3.0 or 0.4.0) - to justify why there are no changes mentioned in the release notes. If previous versions where published somewhere else then maybe a reference might make sense and then listing the changes for those who know the previous APIs. Many of the changes happened all in one PR, so the format used by other APIs (one change more or less equal one PR) won't work here.

have made the updates to use release r1.2.
in the changelog i have made the information on individual APIs look more concise to avoid repeating the same text twice. Hope that looks ok.
@hdamker please review and let me know if i have missed anything or further changes are required.

@maheshc01 Consider the release notes for r1.2 as completely independent from the previous content of the CHANGELOG, listing all changes since the last public release. An API user who is relying on the latest public release should not be forced to read the pre-release notes. (see https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.30.md#v1300 for an - extreme - example).
We copy currently exactly this part into the release description of GitHub.
I suggest that the release notes for r1.2 in your case should at least mention that this is the first public release of these APIs (which is not obvious as the version numbers are already 0.3.0 or 0.4.0) - to justify why there are no changes mentioned in the release notes. If previous versions where published somewhere else then maybe a reference might make sense and then listing the changes for those who know the previous APIs. Many of the changes happened all in one PR, so the format used by other APIs (one change more or less equal one PR) won't work here.

Hi @hdamker
based on your review comments i have made 2 updates to the README

reworded to highlight that this is the first public release

r1.2 is the first public release of connectivity insights with the following API definitions:

removed the link to changelog and added below note clarifying that this being the first public release,  change log is not applicable

Note: This being the first public release of the API, list of changes as compared to previous public release is not applicable and hence not provided.

Note: This being the first public release of the API, list of changes as compared to previous public release is not applicable and hence not provided.

Fine for me. But the line from the template with the link to CHANGELOG.md wouldn't do any harm, as the CHANGELOG.md has some change information about r1.1, could stay unchanged within next releases and would be more consistent across the READMEs (I'm not aware of other APIs who have your note, but haven't checked this explicitly).

@maheshc01 Looking on https://patch-diff.githubusercontent.com/raw/camaraproject/ConnectivityInsights/pull/98.patch it seems that the commits which can't be checked by EasyCLA are done with<EMAIL_ADDRESS>while the successful check ones are done with<EMAIL_ADDRESS>Maybe adding the first address to your GitHub account will solve the issue and unblock the PR to be merged?

@maheshc01 Looking on https://patch-diff.githubusercontent.com/raw/camaraproject/ConnectivityInsights/pull/98.patch it seems that the commits which can't be checked by EasyCLA are done with<EMAIL_ADDRESS>while the successful check ones are done with<EMAIL_ADDRESS>Maybe adding the first address to your GitHub account will solve the issue and unblock the PR to be merged?

Hi @hdamker ,
I already have<EMAIL_ADDRESS>as my primary email address on github account.
I will be reaching out to Casey today to see if he can help me with this.
Meanwhile would you know if there is any way to proceed on this?
@Kevsy  can you check if you can make any update to move this forward.
Thanks,
Mahesh. C

@maheshc01 @Kevsy I've tried a small change (you can revert it if you like) with https://github.com/camaraproject/ConnectivityInsights/pull/98/commits/e46f07bfcb46d3e4b392b6fc91aae98d7bc4fd26 to trigger a new check. Check is updated, but still not happy - maybe past commits can't be claimed by setting the email within GitHub.
@maheshc01 what you can try if not yet done: deactivate the "Keep my email addresses private" options within the GitHub Settings -> Emails. Could be that this prevents the match.
Beyond that I have recognised that the branch is one (merge) commit behind main. Something worth to correct before starting other options (like downloading the files and upload them in another, new branch as new commits).

I was able to work with Casey to resolve the easy cla related issue for the commit. have also ensure the branch is updated with the latest code from main.
Do I have a go ahead to merge? @hdamker @rartych
@Kevsy you might still have to approve the changes.

thanks for the quick actions. I see that i have all the approvals on this.
Should i still wait for an explicit go ahead for the merge approval or am i good to go ahead and merge the code.
Please confirm @rartych @hdamker .


Generate Track 2 Management libraries locally and copy them over to reference docs website as short term solution

Hi Scott
Per our discussion, opening this issue as short term solution
The package list is in these two commits:
(Package list)
https://github.com/Azure/azure-docs-sdk-java/commit/50fa8000eb9602a898040a9a048d431c4001fb34
(Exclude path)
https://github.com/Azure/azure-docs-sdk-java/commit/b072988c5a5fe6035cd464b7c2fc98bfea4feb5e
Thanks a lot and really appreciate it

👍


Replace WindowAssignment OldDoFn by FlatMap in FLink Runner

The streaming runner had an OldDoFn that was used for assigning windows
using a WindowFn. This is now done with a FlatMap.
R: @mxm for review please
CC: @kennknowles I thought you might enjoy seeing OldDoFns removed. 😃
This is the first step towards getting rid of OldDoFn in the Flink runner. The next steps are:

https://issues.apache.org/jira/browse/BEAM-956: Execute ReduceFnRunner Directly in Flink Runner
https://issues.apache.org/jira/browse/BEAM-843: Use New DoFn Directly in Flink Runner

LGTM!

👍 👏 🍾


[glog] fix not work on windows cuda nvcc compiler.

Describe the pull request

What does your PR fix?
Fixes  not work on on windows cuda nvcc compiler. #27899

Which triplets are supported/not supported?

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

many ports on linux fail, I may not have time to look.

I'm able to repro the windows build failure. Here's the error message:

evaluation file to be written multiple times for different configurations

After searching the error message, I realized that it's because the generator expression <COMPILE_LANGUAGE:CXX> does not work properly with Visual Studio generator. See link below:
https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html

Note that with Visual Studio Generators and Xcode there is no way to represent target-wide compile definitions or include directories separately for C and CXX languages. Also, with Visual Studio Generators there is no way to represent target-wide flags separately for C and CXX languages. Under these generators, expressions for both C and C++ sources will be evaluated using CXX if there are any C++ sources and otherwise using C. A workaround is to create separate libraries for each source file language instead

A possible workaround is to modify the generator expression to check CUDA language instead:
"$<$<NOT:$<COMPILE_LANGUAGE:CUDA>>:/Zc:__cplusplus>"

For linux build failures, you may not remove the following condition check:
if ((MSVC) AND (MSVC_VERSION GREATER_EQUAL 1914))


[atspi-proxies] Remove alien methods from Application interface

This removes two methods from Application interface that do not belong there. These belong to- and are found in Registry interface.
/// DeregisterEventListener method
fn deregister_event_listener(&self, event: &str) -> zbus::Result<()>;

/// RegisterEventListener method
fn register_event_listener(&self, event: &str) -> zbus::Result<()>;

Thank you Luuk for cleaning up some of my messes!


Enhacne error message when trying to access storage var without .self prefix

Closes #261

[x] I have updated CHANGELOG.md
[ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
[x] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
[x] I have run all the tests locally and no test failure was reported
[x] I have run the linter, formatter and spellchecker
[x] I did not do unrelated and/or undiscussed refactorings

@anton-trunov what if we try to find the variable name in all of the structs in the current context, not only self?

Let's add similar tests for traits

what if we try to find the variable name in all of the structs in the current context, not only self?

hmmm, not sure about this one, because it might return several result (different struct types can have identical field names)

Let's add similar tests for traits

done


Variable Urls for multiple microservices

Hi,
I'm in a tricky situation with my code base, im not sure whats the best approach.
We have a project where, we are using multiple microservices, in production they exist like this:
https://cool.com/user-service/
https://cool.com/cool-service/
And in the swift code, i have one instance of webservice which has the base url set as https://cool.com, then i have "service" classes which add to the path, e.g. UserService.swift would have "/user-service".
But when we operate locally, because our services are all microservices, they are actually operating on
http://localhost:8081/
http://localhost:8082/
I'm wonder what the best practice is from the Siesta team, with dealing with this. I dont want to have a separate instance of the web service object for every service. I also dont want to have to put in the full path url when making a request for every request.
Thoughts and suggestions?
Thanks
Andrew.

At the moment im using a preprocessor macro to handle the switch between the base url overall. e.g. https://cool.com and http://localhost, but that doesnt fix the issue with ports etc.

You can create a service without a baseURL. See this comment for more info.
I’d recommend doing that, then providing a convience method for each microservice:
final func coolResource(path: String) -> Resource {
    return resource(absoluteURL: coolBaseURL).child(path)
}

final func userResource(path: String) -> Resource {
    return resource(absoluteURL: userBaseURL).child(path)
}

Then you can set up coolBaseURL and userBaseURL however you like.
You’ll lose the nice thing Siesta does to prevent redundant leading slashes; that is, you’ll need to decide either to put a trailing slash on coolBaseURL or a leading slash on path, but not both. Otherwise, this will work exactly like baseURL.
Hmm, you know, it would be nice for Siesta to provide Service.resource(baseURL:path:) as a convenience. I’ll keep this issue open as a reminder to add that.

I dont want to have a separate instance of the web service object for every service.

If the microservices link to each other, then yes, you want just one service to guarantee resource uniqueness. (That is, if you use Resource.relative() to traverse from https://cool.com/cool-service/xyz to https://cool.com/user-service/users/1, then you’d need a single service instance to ensure that you have a single resource for /users/1.)
Otherwise, there’s no problem with having multiple ones. Service doesn’t have a particularly large per-instance overhead.

ok, sounds good. Thanks


th.css not used when DEBUG=False

Even after a
python manage.py collectstatic

The CSS is not used and return a 404 when we access to the app by <IP_ADDRESS>:8000, but it"s found when using NGINX (for example)

I am on it. :+1:

This is expected behavior..  with DEBUG=False you local development server does not attempt to support static files and leaves it for the webserver (e.g nginx or apache) to handle. collectstatic only job is "collecting" the statics from different apps to the statics folder. from there it's the web server job.  While running with debug you don't need to collect statics..

With DEBUG=False, you can run python manage.py runserver --insecure to make django server instead of production server serve the static files.

@alonisser I thought about that.
So with debug to false, one cant just use the app on his/her desktop without setting up a http server.

Using no secure is a bad option, Please notice the docs about that

@foxmask I'll send a PR explaining the options.

@alonisser to explain what i'd like:
Recently someone installed the app on his desktop, all is ok and work fine.
But the app runs in debug. (I did not set debug to false when she clone the repo).
As she has no knowledge in sys admin ; it's complicated for an end user to make them understand of the aspect of those things. So If I tell her ; set DEBUG to False, the render will be "broken".
This is why I expected to be able to display the CSS with debug to false without setting up a HTTP server.
The solution I can see is to embed the css in the main html file. But it's not so nice :/
I'll read your suggestions with pleasure.

@foxmask Maybe I'm missing something. Is the intended setup of this project to run on a personal laptop of a non technical person? If so then I would suggest packaging it better.. (maybe composed dockers + a run command to abstract it? Maybe something else), currently It's packaged as a professional software development project.
If this is a specific edge case, which is not the intended use of the project, then by all means, let them run with DEBUG=True, or with "runserver --unsecure" (can be wrapped in a shell/batch script to hide this fact) while professional deployments are deployed as designed .
I've seen far too many professional django deployments running with DEBUG=True because people don't know how to solve this and I think explaining the correct solution is better

it's packaged to be use as professional software project, yes.
In my previous comment, I explained a specific use case, so ok for DEBUG=True or runserver --insecure will do the trick.
Thank you for all the explanations

thanks you to both of you


[nrf fromtree] cmake: remove base_name for dep file

With CMake 3.20 relative path inside DEPFILEs are treated relative to
CMAKE_CURRENT_BINARY_DIR and are transformed by CMake in its internal
dep file.
Therefore Zephyr build system must no longer add base_name to the
-MT argument for the preprocessor.
Signed-off-by: Torsten Rasmussen<EMAIL_ADDRESS>

I'd appreciate it if next time a link to the PR is added to the commit message.
The PR often contains useful context and it's a bit awkward to find the PR from the fromtree commit.


how to get more objects like segment anything online demo?

the image has a high resolution : 5472x3648
How can we achieve a similar detection performance as the online demo for detecting numerous small targets, while using SAM+YOLOV8 that currently detects only a few targets

https://segment-anything.com/demo result : got lot of objects

-----------sam+yolov8-seg

from metaseg import SahiAutoSegmentation, sahi_sliced_predict
image_path = "pests.jpg"
boxes = sahi_sliced_predict(
image_path=image_path,
detection_model_type="yolov8",  # yolov8, detectron2, mmdetection, torchvision
detection_model_path="yolov8x-seg.pt",
conf_th=0.25,
image_size=1024,
slice_height=256,
slice_width=256,
overlap_height_ratio=0.2,
overlap_width_ratio=0.2,
)
SahiAutoSegmentation().image_predict(
source=image_path,
model_type="vit_b",
input_box=boxes,
multimask_output=False,
random_color=False,
show=True,
save=False,
)

Does SAHI algorithm support yolov8 segmentation model? I think no. This repo uses Sam's detection results and performs segmentation.


Fixing Laravel version error with Livewire

Question
Answer

Issue or Enhancement
Issue

License
MIT

What's in this PR?

Fixes the bug that when using Laravel in version 10.xx.xx '@if(app()->version() >= 7)' was not being validated correctly.
Checklist

[ ] I tested these changes.
[ ] I have linked the related issues.

@bulfaitelo Thanks, it was good that you have spotted this bug!


feat: aws-provider version bump to >= 2.41, < 4.0

Description
Bumping aws-provider requirement to ">= 2.41, < 4.0"
Bumping terraform requirement to ">= 0.12.6, < 0.14"
Motivation and Context
There is newer terraform and provider version available.
Breaking Changes
As stated here
How Has This Been Tested?
Run it locally on aws 2.41, aws 2.7, aws 3.0 and aws 3.1

This is needed, and this change LGTM

Thanks, @cageyv !
v3.6.0 has been just released.


sqladmin.v1beta4.database on an existing DB

Hi,
I'm trying to manage an existing CloudSQL database with DM.
My config is:
-  type: sqladmin.v1beta4.database
   name: db-test-mysql-dbname
   properties:
     instance: $(ref.db-test-mysql.name)
     name: dbname
     charset: utf8
     collation: utf8_general_ci
     project: <mi_project>
   metadata:
     dependsOn:
     - db-test-mysql

and I've the following error after :
ERROR: (gcloud.deployment-manager.deployments.update) Error in Operation [operation-1509978536738-55d51464cfcd0-f415ec62-9971347b]: errors:
- code: RESOURCE_ERROR
  location: /deployments/resources/resources/db-test-mysql-dbname
  message: '{"ResourceType":"sqladmin.v1beta4.database","ResourceErrorCode":"INTERNAL_ERROR","ResourceErrorMessage":""}'

Where is the issue? I can't understand the problem.

Hi,
It appears that the sqladmin API sent an INTERNAL_ERROR response to DM's insert request.
If the error code seen in DM's API is 'RESOURCE_ERROR', then that means DM is proxying the error from the underlying API, not creating the error itself.
Can you see any errors in the Cloud Console Logging page? Specifically for a Cloud SQL Database in the timespan of that operation?

Hi,
yes I've it:
---
insertId: 55D51D004B1C1.A9814E5.1C0ECCC7
logName: projects/<project>/logs/cloudaudit.googleapis.com%2Factivity
protoPayload:
  '@type': type.googleapis.com/google.cloud.audit.AuditLog
  authenticationInfo:
    principalEmail<EMAIL_ADDRESS>  authorizationInfo:
  - authorizationLoggingOptions:
      permissionType: ADMIN_WRITE
    granted: true
    permission: cloudsql.instances.create
    resource: instances/<project>:db-test-mysql
  methodName: cloudsql.instances.create
  request:
    '@type': type.googleapis.com/cloudsql.admin.InstancesInsertRequest
    clientIp: <IP_ADDRESS>
    resource:
      backendType: SECOND_GEN
      databaseVersion: MYSQL_5_6
      failoverReplica:
        available: false
      instanceName:
        fullProjectId: <project>
        instanceId:db-test-mysql
      instanceType: CLOUDSQL_INSTANCE
      region: australia-southeast1
      settings:
        activationPolicy: ALWAYS
        backupConfig:
          binaryLogEnabled: true
          enabled: true
          specification: every day 13:00
        dataDiskSizeGb: '10'
        dataDiskType: PD_SSD
        ipConfiguration:
          enabled: true
          requireSsl: true
        labels:
        - key: hex
          value: 7ce691c82ba3
        locationPreference:
          gceZone: australia-southeast1-a
        maintenanceWindow:
          dayOfWeek: 2
          hourOfDay: 17
        storageAutoResize: true
        storageAutoResizeLimit: '100'
        tier: db-g1-small
  requestMetadata:
    callerIp: <IP_ADDRESS>
  resourceName: instances/<project>:db-test-mysql
  response:
    '@type': type.googleapis.com/cloudsql.admin.InstancesInsertResponse
  serviceName: cloudsql.googleapis.com
  status:
    code: 2
    message: UNKNOWN
receiveTimestamp: '2017-11-06T15:07:28.438225330Z'
resource:
  labels:
    database_id: <project>:db-test-mysql
    project_id: <project>
    region: australia-southeast1
  type: cloudsql_database
severity: ERROR
timestamp: '2017-11-06T15:07:27.231Z'

Talking with some folks at Cloud SQL, it seems that the underlying error was:
Can't create database '<redacted>'; database exists

I am following up with them to make sure this gets a more infomative error message in the future.

I have hit the same problem. If the database already exists, shouldn't DM acquire the resource instead than just failing?


Fuzzer action: surround loop-safe statements in arbitrary well-behaved loop

Once we have #211, we can do things like inserting:
int i = 0;

for (i = 0; i < 4 /* random small positive int */; i++) {
  // loop-safe statements here
}

This would also serve as a very good way to find fuzzer actions that are not loop-safe :D

This is done, but needs some tweaking as it seems to keep triggering run timeouts.


[Feature Request] Support FT Environment

Description
Nest uses a Field Test environment that is served by different endpoints.
It would be fantastic if this integration would allow to select the field test environment in addition to the (default) prod environment.
homebridge-nest is doing a great job managing the endpoints and authentication.
Happy to help testing or provide more information if useful!
Device (optional)
No response
Additional information
No response

@SeraphimSerapis thanks for your feature request! What would be a reason to have a Field Test environment as a choice?
I indeed saw this feature in HomeBridge, however I didn't understand the need. :-)

@iMicknl I appreciate your swift response. This environment is where Nest/Google employees and a sizeable group of external testers evaluate new features/actively reports issues with new app versions/... before they become available GA.

Makes sense, it should be a relatively small change indeed. I am just thinking how to reflect this in the Home Assistant interface. Just a dropdown during initial configuration, where you can select 'Production' vs 'Field Test' environment sounds the best to me currently.
If this was just for Google employees, adding it to the Configuration Flow wouldn't make a lot of sense, but it makes sense if groups of external users are using this as well.

@SeraphimSerapis could you give https://github.com/iMicknl/ha-nest-protect/archive/refs/heads/enhancement/support_field_test_env.zip a try? Extract this file and place custom_components/nest_protect in your custom_components folder.

Done! I got this:
This error originated from a custom integration.

Logger: custom_components.nest_protect
Source: custom_components/nest_protect/pynest/client.py:189
Integration: Nest Protect (documentation, issues)
First occurred: 20:15:04 (1 occurrences)
Last logged: 20:15:04

__init__() got an unexpected keyword argument 'error'
Traceback (most recent call last):
  File "/config/custom_components/nest_protect/config_flow.py", line 87, in async_step_account_link
    refresh_token = await self.async_validate_input(user_input)
  File "/config/custom_components/nest_protect/config_flow.py", line 45, in async_validate_input
    await client.authenticate(
  File "/config/custom_components/nest_protect/pynest/client.py", line 189, in authenticate
    self.nest_session = NestResponse(**nest_response)
TypeError: __init__() got an unexpected keyword argument 'error'

I tried fixing it by changing the following in pynest/const.py:
NEST_ENVIRONMENTS: dict[str, NestEnvironment] = {
    "production": NestEnvironment(
        name="Google Account",
        client_id="733249279899-1gpkq9duqmdp55a7e5lft1pr2smumdla.apps.googleusercontent.com",  # Nest iOS application
        host="home.nest.com", # Regular Nest host
    ),
    "fieldtest": NestEnvironment(
        name="Google Account (Field Test)",
        client_id="384529615266-57v6vaptkmhm64n9hn5dcmkr4at14p8j.apps.googleusercontent.com",  # Test Flight Beta Nest iOS application
        host="home.ft.nest.com", # Nest FT host
    ),
}

And in pynest/client.py I replaced every occurrence of home.nest.com with f"{self.environment.host}". Example:
async with self.session.get(
            f"https://{self.environment.host}/session",
            headers={
                "Authorization": f"Basic {nest_auth.jwt}",
                "cookie": "G_ENABLED_IDPS=google; eu_cookie_accepted=1; viewer-volume=0.5; cztoken="
                + nest_auth.jwt,
            },
        ) as ...
```

However, I now get the following error message, so I must have messed up somewhere:
<img width="593" alt="Screen Shot 2022-04-29 at 20 32 38" src="https://user-images.githubusercontent.com/160543/166004276-bed2482b-86cc-421a-9b4c-051f3648dffe.png">

The logs sadly don't help with additional details.

Thanks, I will have a look! I missed that another URL is required as well. :)

@SeraphimSerapis could you try another version of https://github.com/iMicknl/ha-nest-protect/archive/refs/heads/enhancement/support_field_test_env.zip? :)

Getting there! Entering the token works now, however devices are not retrieved. I get the following error:
This error originated from a custom integration.

Logger: homeassistant.config_entries
Source: custom_components/nest_protect/pynest/client.py:209
Integration: Nest Protect (documentation, issues)
First occurred: 22:43:28 (1 occurrences)
Last logged: 22:43:28

Error setting up entry Nest Protect for nest_protect
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 335, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/nest_protect/__init__.py", line 70, in async_setup_entry
    data = await client.get_first_data(nest.access_token, nest.userid)
  File "/config/custom_components/nest_protect/pynest/client.py", line 209, in get_first_data
    self.transport_url = result["service_urls"]["urls"]["transport_url"]
KeyError: 'service_urls'

Thanks! Can you perhaps share your diagnostics information? I am not sure which other differences there are between both environments, I would say that 'service_urls' are still present...

Ah, I believe I found the culprit:
# App launch API endpoint
APP_LAUNCH_URL_FORMAT = "https://home.nest.com/api/0.1/user/{user_id}/app_launch"

This one would also need to change to home.ft.nest.com. So I changed it to APP_LAUNCH_URL_FORMAT = "{host}/api/0.1/user/{user_id}/app_launch" in const.py and applied this change to client.py:
async def get_first_data(self, nest_access_token: str, user_id: str) -> Any:
        """Get a Nest refresh token from an authorization code."""
        async with self.session.post(
            APP_LAUNCH_URL_FORMAT.format(host=self.environment.host, user_id=user_id),
            json=NEST_REQUEST,
            headers={
                "Authorization": f"Basic {nest_access_token}",
                "X-nl-user-id": user_id,
                "X-nl-protocol-version": str(1),
            },
        ) as response:

Applied these changes and things work great now! Thanks for making this happen!

Ah oops, I missed that one! Thanks, I will fix this and merge.

Thanks for the debug help and to get this feature in! Could you confirm that latest main works?

It seems like something in the config screen may have gotten lost in the merging process:

@iMicknl please let me know how I can best help. I'm happy to keep on testing!

@SeraphimSerapis to which language is your Home Assistant instance? I can not reproduce this behaviour. Can you double check if you replaced all files correctly? It seems that your translation folder didn't come through.

@iMicknl Not sure what happened. I deleted the whole folder, cloned your main branch and am using that version now successfully. This is good to go! Thanks again!


[BUG] Cannot get view in DashBoard - jaeger-hotrod

I get a x_content_parse_exception while triying .\examples\jaeger-hotrod Steps to reproduce the behavior:

Go to localhost:8080 and click some buttons on Hot ROD page. 2. Open http://<IP_ADDRESS>:5601/app/observability-traces , select Data-Prepper and click refresh button
See Error (details in opensearch-dasboard container) /***********
{"statusCode":200,"responseTime":8,"contentLength":9},"message":"POST /api/observability/trace_analytics/query 200 8ms - 9.0B"}
StatusCodeError: [parsing_exception] [term] query does not support [dispatchConfig], with { line=1 & col=328 } at respond (/usr/share/opensearch-dashboards/node_modules/elasticsearch/src/lib/transport.js:349:15) at checkRespForFailure (/usr/share/opensearch-dashboards/node_modules/elasticsearch/src/lib/transport.js:306:7) at HttpConnector. (/usr/share/opensearch-dashboards/node_modules/elasticsearch/src/lib/connectors/http.js:173:7) at IncomingMessage.wrapper (/usr/share/opensearch-dashboards/node_modules/lodash/lodash.js:4991:19) at IncomingMessage.emit (node:events:525:35) at IncomingMessage.emit (node:domain:489:12) at endReadableNT (node:internal/streams/readable:1359:12) at processTicksAndRejections (node:internal/process/task_queues:82:21) { status: 400, displayName: 'BadRequest', path: '/otel-v1-apm-span-*/_search', query: { size: 0 }, body: { error: { root_cause: [Array], type: 'x_content_parse_exception', reason: '[1:328] [bool] failed to parse field [must]', caused_by: [Object] }, status: 400 }, statusCode: 400, response: '{"error":{"root_cause":[{"type":"parsing_exception","reason":"[term] query does not support [dispatchConfig]","line":1,"col":328}],"type":"x_content_parse_exception","reason":"[1:328] [bool] failed to parse field [must]","caused_by":{"type":"parsing_exception","reason":"[term] query does not support [dispatchConfig]","line":1,"col":328}},"status":400}', toString: [Function (anonymous)], toJSON: [Function (anonymous)]
}
/*********** I expected to see : some data on this page If applicable, add screenshots to help explain your problem. Environment (please complete the following information): - OS: [e.g. Ubuntu 20.04 LTS] - Version [e.g. 22] Additional context
Add any other context about the problem here. My Environment is Windows 10 and i disabled security features in configurations. I attached all releated files as zip file.
files.zip

If I pull the files from the repository and run docker-compose directly, I get the following errors:
data-prepper | 2023-10-13T13:11:35,339 [service-map-pipeline-sink-worker-4-thread-1] WARN org.opensearch.dataprepper.plugins.sink.opensearch.OpenSearchSink - Failed to initialize OpenSearch sink, retrying: PKIX path validation failed: java.security.cert.CertPathValidatorException: Path does not chain with any of the trust anchors
jaeger-hotrod-jaeger-hot-rod-1  | 2023/10/13 13:12:34 traces export: Post "http://localhost:4318/v1/traces": dial tcp <IP_ADDRESS>:4318: connect: connection refused

@balamir1979 , I am also seeing something similar. There may be some issues with the versions of the different dependencies.
You may wish to try out the trace-analytics-sample-app instead. It is working for me.
https://github.com/opensearch-project/data-prepper/tree/main/examples/trace-analytics-sample-app

same for me

I clarified this in #4972. All TLS certificates for opensearch's Docker Image point to https://node-0.example.com, and the TLS certificates have a very long validity period. If you did not switch the hostname of the opensearch Docker Container to node-0.example.com, you need to consider letting Data Prepper ignore the TLS certification of the opensearch Docker Container, or generate a separate TLS certificate for OpenSearch that is intuitive and has a shorter validity period.


Migrate gp library to pure ESM

GP library is starting to hit issues with still using Common JS.  Notably modern flatgeobuf node client module is a pure ESM module and using it in CJS environment have struggled to make it work, so we are pinned to an older version of flatgeobuf.  But the flatgeobuf format seems to have had a breaking change, GDAL 3.5 and up produces flatgeobuf files that flatgeobuf node module v3.17.4 cannot read, produces a "Not a flatgeobuf file" error.  The solution is downgrading to GDAL 3.2.2 or below.
We might be able to solve getting latest flatgeobuf node module to load and kick the can down the road, but the longer we stick with CJS, the greater the pain will be.  The question is are all the gp dependencies esm-ready?  Is Jest?  Webpack? Storybook?
The crux things to solve for gp are:

webpack still works for building and running/loading gp functions (node) and clients (browser)
Renaming files to .js and getting jest to still work with its separate transpiler
Local cog works with ts-node for precalc, but loading from seasketch geoprocessing does not
Flatgeobuf works
Ensuring the gp projects can use gp lib still, everything works.

Changes required

In CommonJS in node you can import a directory, and if a index.js exists in that directory, it will open that. ESM requires exact paths
Update package.json to include ”type”: “module” and correct exports field
Refactor all require statements to use import
Refactor all relative-path import statements to include .js file extension
Update Babel Configuration in React to support “import assertions”
__dirname doesn't exist, you only have import.meta

Requirements

[ ] add eslint
[ ] add webpack 5
[ ] upgrade to latest flatgeobuf
[ ] esModuleInterop, should it be true or become false?
[ ] #158

Approach
Geoprocessing library:

[ ] defined as esmodule
[ ] code written in typescript
[ ] src build transpiles to es2020
[ ] scripts build transpiles to es2020?

GP project:

[ ] defined as esmodule
[ ] code written in typescript
[ ] gp functions transpile to ?
[ ] clients transpile to ?
[ ] build transpiles to es2019 or later?

References

flatgeobuf pure esm written in typescript (https://github.com/flatgeobuf/flatgeobuf/blob/master/package.json)
Supporting CommonJS and ESM with Typescript and Node (March 2023) - https://evertpot.com/universal-commonjs-esm-typescript-packages/
See notes here: https://github.com/seasketch/geoprocessing/issues/85#issuecomment-969555844
Community steps and doc links: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

Resolved via #272