NextjsSite hangs on deploy (ESM issue I think)

I have a new frontend stack using NextjsSite
When I try to deploy it - it just hangs forever. No error message. EdgeLambdaBucket custom resource appears to be the problem. It takes hours to time out.
Using latest SST.
Slack thread: https://serverless-stack.slack.com/archives/C01JG3B20RY/p1654126838160149

i didn't find a match for the physical ID in CW but I found /aws/lambda/mish-myapp-frontend-EdgeLambdaBucketProviderCBE2EF-n5Au2yqOFDIN
which has the error:
    "errorMessage": "Must use import to load ES Module: /var/task/s3-bucket.js\nrequire() of ES modules is not supported.\nrequire() of /var/task/s3-bucket.js from /var/runtime/UserFunction.js is an ES module file as it is a .js file whose nearest parent package.json contains \"type\": \"module\" which defines all .js files in that package scope as ES modules.\nInstead rename s3-bucket.js to end in .cjs, change the requiring code to use import(), or remove \"type\": \"module\" from /var/task/package.json.\n",
    "code": "ERR_REQUIRE_ESM",
    "stack": [
        "Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /var/task/s3-bucket.js",
        "require() of ES modules is not supported.",
        "require() of /var/task/s3-bucket.js from /var/runtime/UserFunction.js is an ES module file as it is a .js file whose nearest parent package.json contains \"type\": \"module\" which defines all .js files in that package scope as ES modules.",
        "Instead rename s3-bucket.js to end in .cjs, change the requiring code to use import(), or remove \"type\": \"module\" from /var/task/package.json.",
        "",
        "    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1015:13)",
        "    at Module.load (internal/modules/cjs/loader.js:863:32)",
        "    at Function.Module._load (internal/modules/cjs/loader.js:708:14)",
        "    at Module.require (internal/modules/cjs/loader.js:887:19)",
        "    at require (internal/modules/cjs/helpers.js:74:18)",
        "    at _tryRequire (/var/runtime/UserFunction.js:75:12)",
        "    at _loadUserApp (/var/runtime/UserFunction.js:95:12)",
        "    at Object.module.exports.load (/var/runtime/UserFunction.js:140:17)",
        "    at Object.<anonymous> (/var/runtime/index.js:43:30)",
        "    at Module._compile (internal/modules/cjs/loader.js:999:30)"
    ]
}

2022-06-02T05:36:47.654Z undefined ERROR Uncaught Exception {"errorType":"Error","errorMessage":"Must use import to load ES Module: /var/task/s3-bucket.js\nrequire() of ES modules is not supported.\nrequire() of /var/task/s3-bucket.js from /var/runtime/UserFunction.js is an ES module file as it is a .js file whose nearest parent package.json contains \"type\": \"module\" which defines all .js files in that package scope as ES modules.\nInstead rename s3-bucket.js to end in .cjs, change the requiring code to use import(), or remove \"type\": \"module\" from /var/task/package.json.\n","code":"ERR_REQUIRE_ESM","stack":["Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /var/task/s3-bucket.js","require() of ES modules is not supported.","require() of /var/task/s3-bucket.js from /var/runtime/UserFunction.js is an ES module file as it is a .js file whose nearest parent package.json contains \"type\": \"module\" which defines all .js files in that package scope as ES modules.","Instead rename s3-bucket.js to end in .cjs, change the requiring code to use import(), or remove \"type\": \"module\" from /var/task/package.json.",""," at Object.Module._extensions..js (internal/modules/cjs/loader.js:1015:13)"," at Module.load (internal/modules/cjs/loader.js:863:32)"," at Function.Module._load (internal/modules/cjs/loader.js:708:14)"," at Module.require (internal/modules/cjs/loader.js:887:19)"," at require (internal/modules/cjs/helpers.js:74:18)"," at _tryRequire (/var/runtime/UserFunction.js:75:12)"," at _loadUserApp (/var/runtime/UserFunction.js:95:12)"," at Object.module.exports.load (/var/runtime/UserFunction.js:140:17)"," at Object.<anonymous> (/var/runtime/index.js:43:30)"," at Module._compile (internal/modules/cjs/loader.js:999:30)"]}

Hey @thdxr & @fwang, I am sorry, but how can I install this snapshot build?

Hey @thdxr & @fwang, I am sorry, but how can I install this snapshot build?

Try setting the version in package.json or doing yarn sst update 0.0.0-20220608144900

Hey, thanks - I was now able to install this version and in the Lambda console I can see the code is correct now (no require in there). But the CloudWatch logs still show the same error message:
`/aws/lambda/prod-foresight-MyStack-EdgeLambdaBucketProviderCBE-M76PApgY08Di
2022-06-09T06:25:41.163Z	undefined	ERROR	Uncaught Exception 	{
"errorType": "Error",
"errorMessage": "Must use import to load ES Module: /var/task/s3-bucket.js\nrequire() of ES modules is not supported.\nrequire() of /var/task/s3-bucket.js from /var/runtime/UserFunction.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.\nInstead rename s3-bucket.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /var/task/package.json.\n",
"code": "ERR_REQUIRE_ESM",
"stack": [
"Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /var/task/s3-bucket.js",
"require() of ES modules is not supported.",
"require() of /var/task/s3-bucket.js from /var/runtime/UserFunction.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.",
"Instead rename s3-bucket.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /var/task/package.json.",
"",
"    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1015:13)",
"    at Module.load (internal/modules/cjs/loader.js:863:32)",
"    at Function.Module._load (internal/modules/cjs/loader.js:708:14)",
"    at Module.require (internal/modules/cjs/loader.js:887:19)",
"    at require (internal/modules/cjs/helpers.js:74:18)",
"    at _tryRequire (/var/runtime/UserFunction.js:75:12)",
"    at _loadUserApp (/var/runtime/UserFunction.js:95:12)",
"    at Object.module.exports.load (/var/runtime/UserFunction.js:140:17)",
"    at Object. (/var/runtime/index.js:43:30)",
"    at Module._compile (internal/modules/cjs/loader.js:999:30)"
]
}
`
I saw there is a similar issue in other projects: https://github.com/dherault/serverless-offline/issues/1014#issuecomment-810440099 ... which also mentions this post on StackOverflow: https://stackoverflow.com/questions/66676555/nodejs-14-x-native-aws-lambda-import-export-support/66688901#66688901
As all the Lambda functions seem to be using the nodejs12.x runtime, would it be possible to update it, to use the nodejs14.x or 16.x runtime?

Hey @stefanullinger, can you give 1.2.20 a try?

Hey @fwang, awesome - just tried it and it works smoothly!🥳
I saw you've changed the runtime to nodejs 16.x - is this the only change that was necessary?
Thanks a lot to all people involved! 👏

I'm still getting the same error on a fresh deploy. My lambdas still look like they're on 12.x. Am I looking at the right ones? 🤔

Yeah! ... Updating was easy using the command @revmischa provided. I used npx sst update 1.2.20... I am so happy now guys! 👏

I updated to latest sst using npx sst update -
➜  sst-prisma git:(master) pnpm ls @serverless-stack/cli                  <aws:tombo-dev>
Legend: production dependency, optional only, dev only

<EMAIL_ADDRESS>/Users/cyber/dev/sst-prisma

dependencies:
@serverless-stack/cli 1.2.11
➜  sst-prisma git:(master) pnpm ls @serverless-stack/resources            <aws:tombo-dev>
Legend: production dependency, optional only, dev only

<EMAIL_ADDRESS>/Users/cyber/dev/sst-prisma

dependencies:
@serverless-stack/resources 1.2.11

I still see nodejs12.x being used as the runtime for the resource
  "EdgeLambdaBucketProviderCBE2EFD7": {
   "Type": "AWS::Lambda::Function",
   "Properties": {
    "Code": {
     "S3Bucket": "cdk-hnb659fds-assets-887085912587-us-west-2",
     "S3Key": "d886ca7d58b9c9a3581bf3f70b2b1c145f2bf9e4aece62ba8dddce71bb4a523b.zip"
    },
    "Role": {
     "Fn::GetAtt": [
      "EdgeLambdaBucketProviderServiceRoleB21F58C0",
      "Arn"
     ]
    },
    "Handler": "s3-bucket.handler",
    "MemorySize": 1024,
    "Runtime": "nodejs12.x",  //  <-----

Working for me now, thanks!


Manage Packages Dialog has Unnecessary Horizontal Scrollbar

In notebook, change to Jupyter kernel, choose Manage packages. Notice horizontal scrollbar that impedes functionality:

Both the vertical and horizontal scrollbars are showing again since the July release.

@lucyzhang929 is this something that you can look at for November, or do we need to punt?

I can take a look for November


Feature Needed: Support to be able to have Checkbox.android on ios

It would be nice to have this feature to have react native paper Checkbox Android on iOs as iphone has this weird tick sign instead for a default checkbox .
 <Checkbox.Android       status={checked ? 'checked' : 'unchecked'}       onPress={() => {         setChecked(!checked);       }}     />

Ok will let you know when released

Sorry, in React Native Paper, the Checkbox.Android component is specifically designed for Android, and there is also a Checkbox.IOS component for iOS. If you use Checkbox.Android on an iOS device, it won't render as expected, and you may face compatibility issues.


Update Workflow scripts

This contains fixes to support releasing from multiple branches and configures job concurrency appropriately

Thank you @gastaldi for fixing the workflow issue!

@all-contributors please add @gastaldi for code


Expose get_revocation_status out of state machine

Codecov Report

Merging #769 (8e74eba) into main (516bdb9) will decrease coverage by 24.78%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #769       +/-   ##
===========================================
- Coverage   54.64%   29.86%   -24.78%
===========================================
  Files         380      378        -2
  Lines       36752    30527     -6225
  Branches     8084     6276     -1808
===========================================
- Hits        20082     9118    -10964
- Misses      10690    18697     +8007
+ Partials     5980     2712     -3268

Flag
Coverage Δ

unittests-aries-vcx
29.86% <0.00%> (-24.67%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Issue #7419 fixed

Issue Reference
#7419

@vijay-webkul
The start and end time is not visible. please find the screenshot Here

@vijay-webkul
This is working fine.

@vijay-webkul
Resolved the conflicts.


Makes jibExportDockerContext.targetDir configurable from build.gradle.

This makes jibExportDockerContext configurable like:
build.gradle:
jibExportDockerContext {
    targetDir = 'my-dir'
}

Whereas before it could only be configured from a command line property --jib.dockerDir

@loosebazooka is it gradle custom to allow the user to place build outputs outside of the build directory?

Filed #493 to not allow exporting outside of build output directory.

@coollog FWIW I'm not strongly opinionated about whether these files should even be considered build outputs. Just asking the question.

Yea we'll have exportDockerContext match whatever we decide for the tarball export feature.


Prevent talonscript language files from being active in sleep mode

Adding mode: command to all talonscript language files to prevent them from being active in sleep mode.
fixes #561
The headers are getting quite verbose but right now I don't know of any better way to support both automatic language detection and forced languages that are only active in command mode.
EDIT:
One option if we are allowed pervert the applications context is to define an application for each language.
In code.py we could iterate the list of each language and define an application context for each of them.
for lang in extension_lang_map.values():
    mod.apps[f"lang_{lang}"] = f"""
    mode: command
    and mode: user.{lang}
    mode: command
    and mode: user.auto_lang
    and code.language: {lang}
    """

Then in talonscript just use this simple header
app: lang_python
-

@lunixbochs @knausj85 Is this a workable solution or should we stick to the verbose headers?
ps.
Just to clarify. The whole reason for the verbose header is that code.language doesn't update when forcing a language so until you switch file and code.language updates you have two active languages at the same time. Being able to force code.language to refresh would solve the issue in a better way I think.

Please don't overload app: for this


obcpbft Executor split

This changeset is intended to logically split the obc functions from the pbft ones.
It is specifically intended to address issue #751, but also closes issues #739 and #695.  Other consensus related bugs, in particular ones involving state transfer, are possibly fixed through this changeset as well.
There is a new file obc-executor.go which is responsible for all of the interactions with the ledger, both through executions and through state transfer.  All PBFT implementations (classic, batch, and sieve) now only depend on the network oriented pieces of OBC.  The core PBFT implementation in pbft-core.go no longer contains any references to obc, other than logging and a single crypto hash utility.
The test framework has been restructured extensively.  Previously, there was a testnet which contained a list of instances, which implemented both the consensus.Stack and innerStack interfaces.  This conflation caused considerable problems in removing ledger dependence from the pbft tests.  To address this, testnet was moved to its own mock_network_test.go file and has been changed to refer only to endpoints which have a limited interface.  Then, a pbftTestnet to be used to interact with the pbft-core and a consumerTestnet designed to interact with the pbft plugins were created in pbft-core_mock_test.go and mock_consumer_test.go respectively.
There is also a new omniProto type in the file mock_utilities_test.go which implements most interfaces used in obcpbft.  It contains default implementations which panic, but can be overridden setting a corresponding <Function>Impl variable.  This allows for tests to create one-off limited implementations simply.
This is unfortunately a rather large changeset.  Although all go tests, and behave tests pass, it definitely deserves a degree of scrutiny in code review.  I'd appreciate it if @kchristidis @corecode and @tuand27613 could all take a look.
Please do not merge until the people listed above have had a chance to review.
Signed-off-by: Jason Yellick<EMAIL_ADDRESS>

@corecode I've pushed another commit to address the 'Seive' misspelling, as well as to handle the null checkpoint request.
@tuand27613 @kchristidis would still love to hear any feedback you might have.

(@jyellick Not ignoring this, just tied up with #756.)

@tuand27613 @kchristidis @corecode I think this is just about ready to be pulled, but I'd appreciate any last minute looks it could get before doing so.
There was a bug that was fixed where the ledger was not setting the previous block hash which was causing the Sieve behave test to occasionally fail.
There was also a race in the new Sieve path which should now be fixed.
Additionally, the pbft logging was cleaned up a bit so that we wouldn't get all of the 'out of view window' warning messages in the log constantly.  Instead, we now only log at warning if it is outside of the view window and not on the lower boundary.

With the inclusion of a5fdf8e the troubles I was seeing with high volumes of requests seem to have gone away.  Was able to successfully commit 2000 transactions via behave with a checkpoint interval of 2 (which typically exacerbates the problem).  @tuand27613 If you could double check that the tests pass on a system that isn't mine, I think this should be in merge-able shape.

For posterity's sake, here is some quick documentation on the latest Sieve deadlock that was causing problems.
Execution was happening like this:

Sieve does speculative execution, sends out Verify, executor thread is now blocked until decision
Verify set arrives via PBFT, unblocks executor thread with decision which triggers state transfer
Executor thread requests state transfer, executor thread blocks
New speculative execution queued
Verify set arrives via PBFT, blocks waiting for second speculative execution to complete

The threads are now in a deadlocked condition.  The state transfer messages are stuck behind the PBFT message, and cannot be delivered, the execute thread is waiting on state transfer, and the PBFT message is waiting on the execution thread.
The solution was to introduce yet another thread to handle the PBFT execution's tasks, immediately unblocking so that the message thread can complete the state transfer.


v9: Incompatibility with terraform-aws-eks module - self-managed node groups (target_group_arns)

If your request is for a new feature, please use the Feature request template.

[x] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]: 9.0.0

Terraform version: 1.5.7

Provider version(s): + provider registry.terraform.io/hashicorp/aws v5.23.1

Reproduction Code [Required]
Steps to reproduce the behavior:
terraform-aws-eks v19 expects a list of strings for the target_group_arns variable
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/51cc6bec880ac8dc361b60a4b05d5f2bcd98eb6a/modules/self-managed-node-group/variables.tf#L401-L405
https://registry.terraform.io/modules/terraform-aws-modules/eks/aws/latest/submodules/self-managed-node-group#input_target_group_arns
This worked so far but after alb/nlb switched to maps, this now fails with
│ Error: Invalid value for input variable
│
│   on .terraform/modules/cluster_prod.cluster/node_groups.tf line 411, in module "self_managed_node_group":
│  411:   target_group_arns         = try(each.value.target_group_arns, var.self_managed_node_group_defaults.target_group_arns, [])
│
│ The given value is not suitable for module.cluster_prod.module.cluster.module.self_managed_node_group["base_small"].var.target_group_arns declared at
│ .terraform/modules/cluster_prod.cluster/modules/self-managed-node-group/variables.tf:401,1-29: list of string required.

Expected behavior
Works OOB.
Actual behavior
Fails with error.
Terminal Output Screenshot(s)

Additional context
The changelog could be updated with a note that the new target_group_arns output is a map and must be coerced to a list for other modules to work with it. (or state that other modules might also switch to maps in the next major and one should wait to update).
(NB: while writing this, I haven't yet found out how to do so programmatically, i.e. address the correct child object. I used hardcoded values as a workaround for now).

You can just iterate over the output of target_groups and extract the values you wish to use, such as:
locals {
  target_group_arns = [for k,v in module.alb.target_groups: v.arn]
}

closing with solution provided above


Stats log uses old interface

Describe the bug
When opening the statistics log to view the adapter statistics, the old interface is still used.
Reporter
Ricardo
Category
Use following Tags to categorize your bug report

Frank Console

To Reproduce
Steps to reproduce the behavior:

Go to 'https://ibis4example.ibissource.org/iaf/gui/#!/logging?directory=%2Fopt%2Ftomcat%2Flogs%2Fibis4example&file=ibis4example-stats_2021W07.log'
See old-style interface for statistics

Expected behavior
To be styled the same as the rest of the GUI.
Screenshots
N/A
Environment:

Application server: [e.g. Tomcat/WebSphere/JBOSS/Jetty]: Tomcat
DBMS: [e.g. Oracle, MSSQL, MariaDB, MySql,PostgreSQL]: N/A
Browser: [e.g. Chrome, Safari, Edge]: Chrome
IAF Version: [e.g. 7.5, 7.6]: 7.6-SNAPSHOT

Additional context
N/A

We want to refactor the statistics and not waste effort on styling for now

Functionality has been removed in #5722.


Update Banksy to bioc version + added configurations

Resolves Issue #172
I still had to install it from GitHub because the Bioc (devel) release requires R4.4, which has not been released yet.
Setting dependencies=FALSE reduced installation time tremendously. Instead, I had to add some packages to the yaml, which also meant I could pin their versions.

In this case the questions is whether it makes sense to wait until it is properly released on Bioconductor?
@naveedishaque

I guess we could, but that would not be until April-May when the next Bioconductor release is published with R 4.4.


[AutoPR containerservices/resource-manager] [AKS] add nodeResourceGroup property

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/3203

(message created by the CI based on PR content)

Codecov Report

Merging #2707 into restapi_auto_containerservices/resource-manager will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@                                 Coverage Diff                                 @@
##           restapi_auto_containerservices/resource-manager    #2707      +/-   ##
===================================================================================
- Coverage                                            55.89%   55.89%   -0.01%
===================================================================================
  Files                                                 7213     7213
  Lines                                               151649   151651       +2
===================================================================================
  Hits                                                 84767    84767
- Misses                                               66882    66884       +2

Impacted Files
Coverage Δ

...re/mgmt/containerservice/models/managed_cluster.py
27.77% <0%> (-1.64%)
:arrow_down:

...gmt/containerservice/models/managed_cluster_py3.py
27.77% <0%> (-1.64%)
:arrow_down:

...inerservice/azure/mgmt/containerservice/version.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412e27e...5419157. Read the comment docs.

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/2708


[code bug] the index++ may reach negative value

https://github.com/apache/rocketmq/blob/adb83ca09633b76150fd3dca294803d96a4dfd60/client/src/main/java/org/apache/rocketmq/client/latency/MQFaultStrategy.java#L61-L63
for example
        int index=0x7FFFFFFF;
        for(int i=0;i<10;i++)
        {
            System.out.println(index++) ;//will reach negative;
        }

Nice catch! And this logic changed in #5181, we should review it again.
https://github.com/apache/rocketmq/pull/5181/files#diff-771f2a9ff3067ee7ec67d5282228514e9e709c549eafe34ae7402b279487d656L87-L93

int index = tpInfo.getSendWhichQueue().incrementAndGet();
this line is outside the for loop ,will cause unevenly distributed message just like https://github.com/apache/rocketmq/issues/5672#issuecomment-1357085525 discussed.


fix fix regression case "nereids_p0/runtimefilter"

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0


Allow other tags to occur between <error> tags

Fixes #64

Thanks for your PR!
Are you sure, that this does the intended thing? I expect the non-contiguous stack-traces to be separate, while this solution treats them as contiguous, doesn't it?

Yes, this doesn't fix the problem with multiple stack traces. It only fixes the problem described in the linked issue.
(technically, it does fix the panic for multiple stack traces, but it doesn't make any progress towards properly handling them)
I have since made a patch that switches from serde (which isn't that well-suited for handling XML) to strong-xml, see here. This fixes both issues, and handling for multiple stacks only needs some work in the frontend. I can open a pull request for that one if you want, then this one would become obsolete.

Oh, I had the idea of migrating away from serde for the XML-parsing a while ago, but didn't have time to implement it. I'm excited for your solution. In the meantime I don't think blocking this PR on your other work is necessary. Your PR does prevent some panics at the price of some longer stack traces (when concatenated, they don't look fully right, but maybe it helps the user by showing more context).
So: either feel free to fix the merge conflict and we'll land this PR now or close the PR and keep working on the (good) proper long-term solution.
Nevertheless: huge thanks for your work, it's very appreciated.


Invalid Region.Op - only INTERSECT and DIFFERENCE

Showing error Invalid Region.Op - only INTERSECT and DIFFERENCE on Android Pie.

I have solved this problem with this commit ：e647498
Please use the latest version 2.1.0

It Worked. Thanx a lot


Turbolinks 5.2 deferred caching strategy support

Hi guys,
after hours of headache I've noticed that Turbolinks 5.2 does not work with React On Rails 11 due to the new Deferred caching strategy introduced in turbolinks 5.2
Turbolinks 5.2 Deferred caching PR
Do you have plan to support turbolinks 5.2? It would be nice, it's faster than the 5.1 with the new deferred caching strategy.
Thank you so much

@risinglf and others that would like to migrate to Turbolinks 5.2:
PRs Welcome
I'm very open to taking a PR on this. Would you be interested in creating one? I can provide some guidance.

Pro Support
I can do this for your company if you join ShakaCode Pro Support plan. Please email me for more info.
Here are a couple of references for what we do:

HVMN’s 90% Reduction in Server Response Time from React on Rails Pro
A testimonial.

Thanks,
Justin
<EMAIL_ADDRESS>

I did read up a bit on the PR mentioned. I'm not clear on what the change would be.
Here is the relevant code to hack on:
function renderInit() {
  // Install listeners when running on the client (browser).
  // We must do this check for turbolinks AFTER the document is loaded because we load the
  // Webpack bundles first.
  if (!turbolinksInstalled() || !turbolinksSupported()) {
    debugTurbolinks('NOT USING TURBOLINKS: calling reactOnRailsPageLoaded');
    reactOnRailsPageLoaded();
    return;
  }

  if (turbolinksVersion5()) {
    debugTurbolinks(
      'USING TURBOLINKS 5: document added event listeners ' +
      'turbolinks:before-render and turbolinks:render.');
    document.addEventListener('turbolinks:before-render', reactOnRailsPageUnloaded);
    document.addEventListener('turbolinks:render', reactOnRailsPageLoaded);
    reactOnRailsPageLoaded();
  } else {
    debugTurbolinks(
      'USING TURBOLINKS 2: document added event listeners page:before-unload and ' +
      'page:change.');
    document.addEventListener('page:before-unload', reactOnRailsPageUnloaded);
    document.addEventListener('page:change', reactOnRailsPageLoaded);
  }
}

The current test suite does test turbolinks:
I did read up a bit on the PR mentioned. I'm not clear on what the change would be.
Here is the relevant code to hack on:
function renderInit() {
  // Install listeners when running on the client (browser).
  // We must do this check for turbolinks AFTER the document is loaded because we load the
  // Webpack bundles first.
  if (!turbolinksInstalled() || !turbolinksSupported()) {
    debugTurbolinks('NOT USING TURBOLINKS: calling reactOnRailsPageLoaded');
    reactOnRailsPageLoaded();
    return;
  }

  if (turbolinksVersion5()) {
    debugTurbolinks(
      'USING TURBOLINKS 5: document added event listeners ' +
      'turbolinks:before-render and turbolinks:render.');
    document.addEventListener('turbolinks:before-render', reactOnRailsPageUnloaded);
    document.addEventListener('turbolinks:render', reactOnRailsPageLoaded);
    reactOnRailsPageLoaded();
  } else {
    debugTurbolinks(
      'USING TURBOLINKS 2: document added event listeners page:before-unload and ' +
      'page:change.');
    document.addEventListener('page:before-unload', reactOnRailsPageUnloaded);
    document.addEventListener('page:change', reactOnRailsPageLoaded);
  }
}

The current test suite does test turbolinks:
https://github.com/shakacode/react_on_rails/blob/master/spec/dummy/Gemfile.lock#L288
If you want to try out updating to 5.2 turbolinks, let me know how it goes.

@risinglf did you ever find the solution?

@risinglf did you ever find the solution?

Hi @justin808 no I did not. We lock the Turbolinks version to 5.1.
Thanks

Hi @justin808 no I did not. We lock the Turbolinks version to 5.1.
Thanks


Switching to TESTNET leads to failed verification

Swiched a completely  snyced and set up node to testnet and snced and setup there again.
A try to connect to a faucet for testnet end up this way:
` lncli connect 0270685ca81a8e4d4d01beec5781f4cc924684072ae52c507f8ebe9daf0caaab7b@<IP_ADDRESS>:9735
[lncli] rpc error: code = Unknown desc = verification failed: signature mismatch after caveat verification
`

testnet3 was quite messed up over the last of weeks. I kind of ignored it ... but will try to repair support for version 1.0 next month. Until then I will be afk for vacation.

TODO: Retesting switching to testnet.
TODO: Use/test new network.chain.sh config script
TODO: Add Dialogs to 00menu.sh - replace 95switchTestMain.sh

@jagottsicher about the failed verification ERROR -> when using lncli on testnet the parameter --network=testnet is mandatory
see https://github.com/Stadicus/guides/issues/240#issuecomment-428923161

OK - I adapted and tested (one testrun) all scripts to run with testnet again. Will be part of next sd card release.  closing ticket for now.


Remove cruft in interop commands for Go and Java

Stop compiling Go's client.go every invocation; it's already compiled.
The working directory does not need to be set. There's no need for using
bash. There's no need for interactive. server_host_override should not
be set, since the server_host is the correct value to use.
CC @dfawley

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,965,918      Total (=)      1,965,918

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,891,797      Total (>)     10,891,794

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

Those are good points, thanks for noticing those. The go__master and java__master files are just a subset of what actually needs to be edited to fix those (they are actually generated by https://github.com/grpc/grpc/blob/master/tools/interop_matrix/create_testcases.sh, which in turn uses run_interop_tests.py).
I know run_interop_tests.py and expecially run_interop_matrix.py are in need of simplification and cleanup, so I'll try to incorporate the suggested changes once I have get a chance.
Add using -i (interactive). I think those are being used because they make it possible to kill the entire run_interop_tests.py run in case you are running the script locally - so I might keep the -i. For other changes suggested, I don't have any reservations.

I see. The working directory may be needed for some other languages, but I sort of expect it would be rarely needed. server_host_override is currently necessary for C-based languages, but after some of the stuff is worked out from #16759 it shouldn't be specified for grpc-test.sandbox.googleapis.com and similar. (It should only be specified when we're using the test certificates; so in conjunction with --test_ca)
I've created #16911 to make it clear to others that these scripts are generated.

This has been partially addressed by https://github.com/grpc/grpc/pull/17407/files.
I think java__master and go__master should be regenerated (https://github.com/grpc/grpc/tree/master/tools/interop_matrix#instructions-for-creating-new-test-cases) to reflect the changes to run_interop_tests.py

@jtattermusch, I'm confused as to why the files weren't regenerated in #17407 when run_interop_tests.py was changed. I don't understand the process.

Sorry for the delay, things are turning out to be more complex than I expected. I've tried to regenerate the test cases in https://github.com/grpc/grpc/pull/18878 according to the instructions (https://github.com/grpc/grpc/tree/master/tools/interop_matrix#instructions-for-creating-new-test-cases), but I'm facing a few more issues - let's discuss on that PR (the PR basically supersedes this one).


add hero styling and background image

Love this PR so much. Really brings everything together. two minor issues to address but looking excellent :+1:

Thanks gareth, I've made those changes and pushed them


feat: Data.Finset.NatAntidiagonal.antidiagonal_equiv_fin

as suggested by @ocfnash in https://github.com/leanprover-community/mathlib4/pull/6425#discussion_r1304089614

Thanks!
bors d+


Find labels that don't include branch folder

[x] indentation is made with 4 spaces
[x] your pull request contains only changes intended (no refactoring, line return added, ... that could make code review harder. Make another one if you think it is needed...)
[x] run and verify that existing tests pass. Add some new units tests, if needed.
[x] update the documentation, if needed.
[x] update the release notes file

This is to fix #1125. I've dropped the item filter that checks whether the branch folder is specifically listed in the label. It made the label query a little slower in my case, but only because it actually started finding labels.
The query is still only over the scope of the branch so there shouldn't be too much extra data coming back. As we're no longer guaranteed to have at least one item within the folder (the branch folder itself, previously), I've made sure to only return labels with relevant items.
I also noticed after adding some debugging statements to GetLabels that is seems to be called twice for each branch due to the .Count() going to trace, so this is also fixed.

Thanks a lot! Merged with #1179


feat: include context in authorizer response serialization

Merge activity

Aug 28, 9:37 PM GMT+2: @pevisscher started a stack merge that includes this pull request via Graphite.

#203  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pevisscher and the rest of your teammates on  Graphite


Initial work.

This PR contains the initial work on Liftbridge Operator, which comprises the initial iteration on the definition of the LiftbridgeCluster CRD, the scaffolding of the main application and the type definitions (and associated code generation step).

Thanks!


Prepare package

Candidate for a pip installable package.

Notebooks moved to designated repo.
Toolkits moved to designated repo.
setup.py added.

no longer relevant. closing this.


Make default query context show up in sql query logs

Fixes an issue where when you look at the sql query request logs emitted via an emitter or logged would be missing default query context values set in runtime.properties

Description

Added DefaultQueryConfig to SqlLifecycle ...

This was chosen because while the default query context is added as part of QueryLifecycle it was never added as part of the sql lifecycle meaning it wouldn't show up in the logs or when emitted via an emitter. Since this is a duplicate value with the values being added at QueryLifecycle there should no worries about the eventual double write of default query context values

Key changed/added classes in this PR

SqlLifecycle

This PR has:

[x] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[x] been tested in a test Druid cluster.

@kfaraz I'll see what I can do about implementing those two tests you want


dist in 2.1.2 broken

After upgrade from 2.1.1 to 2.1.2 I get an error in console
[Vue warn]: You are using the runtime-only build of Vue where the template compiler is not available. Either pre-compile the templates into render functions, or use the compiler-included build.

found in

---> <TreeView>

and component not working anymore

Hi @arvidkahl ! Some of us are using the runtime only. In your index.js, you should define a render function. I can submit a PR if your want.

That would be fantastic. Please do!

Same issue here..

Again, I am not actively using this any more. If anyone wants to supply a working pull request, I will merge it.

See https://github.com/arvidkahl/vue-json-tree-view/issues/10#issuecomment-379007256

Closed as seems to be a duplicate of #10


Connection with Quarkus Backend

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
3.5.0
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
3.0.8
Public or Confidential Client?
Public
Description
I have integrated MSAL into my Angular frontend application.
My Quarkus 3.6.4 backend is configured with OIDC, but I am consistently receiving an "Unauthorized" response from it.
The user is logged in, and all relevant information is stored in local storage. Everything else appears to be functioning correctly.
I think it is a problem with MSAL
MSAL Configuration
const msalPublicClientApplication: PublicClientApplication = new PublicClientApplication({
  auth: {
    clientId: environment.auth.clientId,
    authority: environment.auth.authority,
    redirectUri: environment.auth.redirectUri,
    navigateToLoginRequestUrl: false,

  },
  cache: {
    cacheLocation: environment.auth.cacheLocation,
  },
  system: {
    allowNativeBroker: false,
    loggerOptions: {
      // loggerCallback,
      // logLevel: LogLevel.Info,
      // piiLoggingEnabled: false
    }
  }
});

Relevant Code Snippets
auth: {
    clientId: '{CLIENT-ID}',
    authority: 'https://login.microsoft.com/{ID}',
    redirectUri: window.location.origin,
    postLogoutRedirectUri: 'https://localhost:4200',
    cacheLocation: BrowserCacheLocation.LocalStorage,
    authRequest: {
      scopes: ['user.read']
    },
    protectedResourceMap: new Map([
      ['https://graph.microsoft.com/v1.0/me', ['user.read']],
      ['http://localhost:8080/api/v1', ['user.read']],
    ]),
  },

Quarkus Config:
quarkus.oidc.auth-server-url=https://login.microsoft.com/{id}
quarkus.oidc.provider=MICROSOFT
quarkus.oidc.client-id={client-id}
quarkus.oidc.application-type=SERVICE

Identity Provider
Azure AD / MSA
Source
External (Customer)

I'm not familiar with Quarkus and unfortunately without more information about what specifically is wrong we won't be able to provide support. Let us know if there's more detail you can provide.


Add support for "swizzled stores"

This was a known issue in our IR representation, which was now biting a user. The basic problem is that in code like the following:
RWStructureBuffer<float4> buffer;
...
buffer[index].xz = value;

we ideally want to be able to reproduce the original HLSL code exactly, but that requires directly encoding the way that this code writes to two elements of a vector, but not the others.
The currently lowering strategy we had produced IR something like:
float4 tmp = buffer[index];
tmp.xz = value;
buffer[index] = tmp;

That transformation might seem valid, but it has some big problems:

It generates UAV reads that are not needed, which could impact performance
It performs read-modify-write operations on memory that the programmer didn't explicitly write, which could create data races

The fix here is somewhat obvious: if the "base" of a swizzle operation on a left-hand side resolves to a pointer in our IR, then we can output a "swizzled store" instead of the read-modify-write dance. We currently keep the read-modify-write around since it is potentially needed as a fallback in the general case.
Along the way I also tried to make sure that we handle the case where we have a swizzle of a swizzle on the left-hand side:
buffer[index].xz.y = value;

That code should behave the same as buffer[index].z = value. I am currently detecting and cleaning up this logic in the lowering path for SwizzleExpr, because that is the only place in the lowering logic that "swizzled l-values" currently get created.

Note: this change might actually create complications for SSA promotion of vector variables that get written to with swizzles. A follow-on change should fix up the SSA-promotion pass to handle cases where a local variable gets written to with swizzledStore and still allow it to be promoted.


Webpack3 + ES6 Exports

This PR modernizes the Victory build and offerings. Generally:

Provide an es/ directory alongside lib/ that has ES module export / imports (but everything else babel built) per the redux model. This model allows webpack2+ to use ESM resolution and enable tree-shaking, while is still backwards compatible with webpack1 which will use lib/
Remove all references to .jsx since we don't use those anymore.
Clean up and hone down a lot of stuff.

/cc @boygirl @chrisbolin
Cross-reference PRs
First, infrastructure:

https://github.com/FormidableLabs/builder-victory-component-dev/pull/7
https://github.com/FormidableLabs/builder-victory-component/pull/92

Second, core:

https://github.com/FormidableLabs/victory-core/pull/266

Third, dependers:

https://github.com/FormidableLabs/victory-pie/pull/149
https://github.com/FormidableLabs/victory-chart/pull/495

Finally, parent:

https://github.com/FormidableLabs/victory/pull/651

Tickets
Implemented / fixed:

Provide es6 build to use with Webpack. Fixes https://github.com/FormidableLabs/victory/issues/256
Provide efficient webpack helpers for tree-shaking + DCE. Fixes https://github.com/FormidableLabs/victory/issues/548

Opened / still open:

Webpack tree shaking does not completely remove unused re-exports. https://github.com/FormidableLabs/victory/issues/549

Bundles
The main goal here is not the victory bundle, but enabling webpack2+ users to get more efficient builds going off the es/ directory. And with the dedupe plugin being removed in webpack2+, our dev bundle is definitely bigger. But, fortunately, the prod minified bundles aren't that different:
Before / webpack1
$ find ../victory*/dist -type f -exec wc -c {} \;
  993198 ../victory-chart/dist/victory-chart.js
 1323555 ../victory-chart/dist/victory-chart.js.map
  438868 ../victory-chart/dist/victory-chart.min.js
 2634923 ../victory-chart/dist/victory-chart.min.js.map
  659513 ../victory-core/dist/victory-core.js
  915723 ../victory-core/dist/victory-core.js.map
  276427 ../victory-core/dist/victory-core.min.js
 1734458 ../victory-core/dist/victory-core.min.js.map
  674687 ../victory-pie/dist/victory-pie.js
  836742 ../victory-pie/dist/victory-pie.js.map
  284790 ../victory-pie/dist/victory-pie.min.js
 1814890 ../victory-pie/dist/victory-pie.min.js.map
 1013340 ../victory/dist/victory.js
 1235399 ../victory/dist/victory.js.map
  450323 ../victory/dist/victory.min.js
 2747731 ../victory/dist/victory.min.js.map

After / webpack3
$ find ../victory*/dist -type f -exec wc -c {} \;
 1663000 ../victory-chart/dist/victory-chart.js
 1602704 ../victory-chart/dist/victory-chart.js.map
  434851 ../victory-chart/dist/victory-chart.min.js
 3349108 ../victory-chart/dist/victory-chart.min.js.map
  975040 ../victory-core/dist/victory-core.js
  941706 ../victory-core/dist/victory-core.js.map
  265075 ../victory-core/dist/victory-core.min.js
 1930341 ../victory-core/dist/victory-core.min.js.map
 1219152 ../victory-pie/dist/victory-pie.js
 1092945 ../victory-pie/dist/victory-pie.js.map
  304427 ../victory-pie/dist/victory-pie.min.js
 2396990 ../victory-pie/dist/victory-pie.min.js.map
 1869374 ../victory/dist/victory.js
 1680468 ../victory/dist/victory.js.map
  487115 ../victory/dist/victory.min.js
 3846520 ../victory/dist/victory.min.js.map

@ryan-roemer I think this is failing linting

@boygirl -- Yep. Fixed.

@ryan-roemer once this goes in, I'd like to do a major version bump on the archetypes. Does that sounds appropriate?

@boygirl -- Yep. Major for archetypes. But fortunately, minor for victory repos.


Extended response methods to optionally return

Added an optional parameter to allow the methods (confirm, error, invalid, sendResponse) to return the response as a string rather than exit the program.
This allows for a cleaner integration with frameworks that deal in Request-Response objects.

This kind of feels clunky, with different behaviour triggered by anonymous flags passed into the methods. I wonder if there is a better way to handle this. I think new methods to get access to the messages would be better. It could even be one method with a "result type" parameter that takes a constant defined to indicate the result e.g. $message = $response->getMessage($response::RESULT_ERROR, $url, $reason).

I'm happy to make the phpdoc annotations clearer if that would help. This is just a quick fix I did to get the package to work with Symfony - thought that I might as well make it a pull request in case anyone else found it useful.
I agree that there is a better way to handle this - I think the ResponseInterface should have methods for testing whether a response requires an answer (similar to isRedirect()). The Symfony HttpFoundation component is already a dependency - so that could be used to provide the HTTP response "answers" in a framework friendly way.
I also think that use of the confirm(), invalid() and error() methods can be handled by the gateway. The gateway should use invalid() if the signature is invalid, error() if the parameters passed to completePurchase() don't match and confirm() if everything is okay.


Week Three Report Meeting (Feb 10 at 3:00pm)

Still need to schedule meeting (email has been sent) Scheduled
Ensure the week's GitHub updates are done and the demonstration is read the day before the meeting.

Done


Read email message.snippet  link: with no params

While reading emails i noticed there is a bug that my links are missing params
example  instead of
getting https://example.com/aedead2a5d6ada6da5da4dada
i got
https://example.com/

i figured out  my snippet is not complet because of length can u please increase snippet length over 200 characters ..


ServiceException: 409 bucket already exists

$ gsutil mb gs://delta-essence-114723-flank/
Creating gs://delta-essence-114723-flank/...
ServiceException: 409 Bucket delta-essence-114723-flank already exists.

We should probably check to see if the bucket exists before running the make bucket command.

https://github.com/GoogleCloudPlatform/gsutil/blob/master/gslib/tests/test_mb.py#L28

gsutil checks stderror for "bucket exists". The same fix would work for flank. If this message is detected, then remove it from the debug error output.

Should be fixed now.


Added: Add score feedback display options to MatchingPairsGame

This pull request adds the functionality to display score feedback in the MatchingPairsGame component. It includes the following changes:

Added a new prop called scoreFeedbackDisplay to the MatchingPairs component.

Refactored the MatchingPairs component to support the scoreFeedbackDisplay prop.

Added a new option called SCORE_FEEDBACK_DISPLAY to the MatchingPairs component.

Updated the WithSmallBottomRightScoreFeedback story to demonstrate the new score feedback display option.

Resolves #716

FYI, on develop the "score_feedback_display" is now called "display_score", and is a kwarg on experiment.rules.actions.playback.MatchingPairs initialization. Feel free to move it up to Playback instead, but since we usually don't include scores in players, I thought to move it only to the MatchingPairs player types. Also, feel free to rename. I tried to emulate your options. Perhaps the backend should also get a definition of the different options that are allowed for the display options? We might add them as "score display types" to the top of playback.py and adjust typing so it only allows one of the three strings?

FYI, on develop the "score_feedback_display" is now called "display_score", and is a kwarg on experiment.actions.playback.MatchingPairs initialization. Feel free to move it up to Playback instead, but since we usually don't include scores in players, I thought to move it only to the MatchingPairs player types. Also, feel free to rename. I tried to emulate your options. Perhaps the backend should also get a definition of the different options that are allowed for the display options? We might add them as "score display types" to the top of playback.py and adjust typing so it only allows one of the three strings?

FYI, on develop the "score_feedback_display" is now called "display_score", and is a kwarg on experiment.actions.playback.MatchingPairs initialization. Feel free to move it up to Playback instead, but since we usually don't include scores in players, I thought to move it only to the MatchingPairs player types. Also, feel free to rename. I tried to emulate your options. Perhaps the backend should also get a definition of the different options that are allowed for the display options? We might add them as "score display types" to the top of playback.py and adjust typing so it only allows one of the three strings?

Huh? Is this new or did I just overlook the existing prop completely?

This is new, after the merge of Evert's pull request, which kinda but not quite addressed a similar request.


Provide a compatibility matrix for PG, TSDB, Extension, Connector versions

We currently don't surface to users which versions of these components work together.

Promscale version compatibility matrix

Connector
Extension
TSDB
Postgres

0.12.x
0.5.0 and above
2.6.1 and above*
12.x, 13.x, 14.x

0.11.x
0.5.0 and above
2.6.1 and above*
12.x, 13.x, 14.x

0.10.x
up to 0.3.2**
1.7.3 and above**
12.x, 13.x, 14.x

0.9.x
up to 0.3.2**
1.7.3 and above**
12.x, 13.x, 14.x

* single-node only
** optional

^ @antekresic's chart looks right. I would suggest changing 0.5.0 and above to 0.5.x for the extension version since I am not sure we want to commit to indefinite backwards compatibility.


Two false negatives from official document

Hi! Recently, I found two false negatives about using when used Error Prone. After reading official document, I think errorprone should have recognized it because yhey are related to FloatingPointLiteralPrecision.
Actually, it cannot recognize the officical case.
The minimmal case is listed below:
public void testFloatingPointLiteralPrecision() {
    double d = 1.9999999999999999999999999999999;  // should report a warning here
    float f = 1.99999999999999999999999f;  // should report a warning here
}

Expected output: two bug warnings
Actual output: No warnings and d and f are regarded as 2.0

I can't reproduce. Note that by default the check is a warning, not an error, so it won't fail the build.
Which build system integration are you using?
T.java:4: warning: [UnusedVariable] The local variable 'd' is never read.
    double d = 1.9999999999999999999999999999999; // should report a warning here
           ^
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean to remove this line?
T.java:5: warning: [UnusedVariable] The local variable 'f' is never read.
    float f = 1.99999999999999999999999f; // should report a warning here
          ^
    (see https://errorprone.info/bugpattern/UnusedVariable)
  Did you mean to remove this line?
T.java:4: warning: [FloatingPointLiteralPrecision] Floating point literal loses precision
    double d = 1.9999999999999999999999999999999; // should report a warning here
               ^
    (see https://errorprone.info/bugpattern/FloatingPointLiteralPrecision)
  Did you mean 'double d = 2.0;'?
T.java:5: warning: [FloatingPointLiteralPrecision] Floating point literal loses precision
    float f = 1.99999999999999999999999f; // should report a warning here
              ^
    (see https://errorprone.info/bugpattern/FloatingPointLiteralPrecision)
  Did you mean 'float f = 2.0f;'?
4 warnings

OK. Got it, thanks for your help.


Latest registered version of ACE.jl not pushed to ACEsuit/ACE.jl repository

@cortner: I just noticed that the new version (0.12.46) of ACE.jl has been registered here:
["0.12.46"]
git-tree-sha1 = "f509917bb160462da82b97fa9210170a06d2a533"
However, the relevant commit has, as far as I can see, not been pushed to ACEsuit/ACE.jl.

fixing it now. Thank you for tracking this down and sorry for the delay.

should now be fixed. Please check?


Spyder 3 Icons are huge - DPI scaling?

Description of your problem
Spyder 3 GUI scaling is off. Icons are huge. This was supposedly fixed in 3.0.1 I thought?

What steps will reproduce the problem?

Running Spyder from CLI
Running spider from Anaconda Navigator

What is the expected output? What do you see instead?
I expect the icons to be normal sized. Instead, I see icons that appear to be enlarged.
Please provide any additional information below
Possibly due to a DPI scaling?
Versions and main components

Spyder Version: 3.0.1 (Anaconda distribution )
Python Version: 3.5.2
Operating system: Ubuntu 16.04.1

Dependencies
Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:
jedi >=0.8.1     :  0.9.0 (OK)
matplotlib >=1.0 :  1.5.3 (OK)
nbconvert >=4.0  :  4.2.0 (OK)
numpy >=1.7      :  1.11.2 (OK)
pandas >=0.13.1  :  0.19.0 (OK)
pep8 >=0.6       :  1.7.0 (OK)
psutil >=0.3     :  4.4.2 (OK)
pyflakes >=0.6.0 :  1.3.0 (OK)
pygments >=2.0   :  2.1.3 (OK)
pylint >=0.25    :  1.5.2 (OK)
qtconsole >=4.2.0:  4.2.1 (OK)
rope >=0.9.4     :  0.9.4-1 (OK)
sphinx >=0.6.6   :  1.4.8 (OK)
sympy >=0.7.3    :  1.0 (OK)

Thanks for reporting. This error will be fixed in Spyder 3.0.2 :-)


Duplicate ts declaration

In  this file I see the declaration of the interface
In this file I see the implementation of the interface
My suggestion:
Infer the interface using the implementation, Note that they are configuration constant, and no one else can ever implement the interface i.e.
export type ZeitUIThemesPalette=typeof palette

This can be done together with #353 .


Upgrade CI image version

As stated in travis docs:

Trusty is EOL by Canonical, try updating to a newer image and see our Trusty to Xenial Migration Guide.

we should upgrade Precise and Trusty to Xenial.

Coverage remained the same at 100.0% when pulling 671a68256151d7bdda31ec345596e477ebb85baa on fix-CI into e7452d87783fbf6e9d320d515675e26dfd1271c5 on develop.


add cats typeclass instances

The package catsSupport was renamed to cats.
The package circeSupport was renamed to circe.
Package objects will be deprecated and removed soon, so these are now objects.
A bit of documentation was added for the usage of Cats instances.

I'm not familiar enough with mill so I didn't know how to build the documentation locally, but I tested the examples.

Good job. Can you also rename the zioJsonSupport package to zioJson?

Sure, forgot to comment I wasn't sure what you wanted to do with that one, so I left it.

@Iltotore whenever you have some time, may I ask you to release a snapshot/milestone or another RC? Thank you!

A new one with (probably) SJS/SN support will be released the next week or this weekend if possible.


NIFI-5090: Create move target dir dynamically at FetchFTP and FetchSFTP

NOTES
This PR contains two commits. The first one 3dc909d is mandatory.
The 2nd one 8ec8a25 improves 'disable directory listing' scenario. Before this commit, if directory listing was disabled and parent directory was not found, FetchSFTP did not try creating the missing parent directories. The 2nd commit made the processor to create parent directories. It affects to PutSFTP, too.
I didn't create another JIRA for the 2nd commit, since these can be tested and reviewed easier at the same time. Please let me know if you, reviewer think it should be managed separately.
I used following docker images for testing:

atmoz/sftp
stilliard/pure-ftpd:hardened

A NiFi flow template is also available here:
https://gist.github.com/ijokarumawak/4fb05da103fd10f3ae6038f3388eb062
Thanks!

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing...


Marked v14.0.0

Marked v14.0.0 has been released.
https://github.com/markedjs/marked/releases/tag/v14.0.0
But marked.min.js hasn't been updated since Marked v13.0.3.
Clearing the jsDelivr cache makes no difference.
https://cdn.jsdelivr.net/npm/marked/marked.min.js
Therefore, the update to Marked v14.0.0 is on hold.

This issue is resolved and I can work.


Add Slack invite link

Description
Use shared Slack invite link instead of custom invite service.
Motivation and Context
Use built-in Slack invite functionality that removes the need to host the service ourselves.

Since the slack.dita-ot.org subdomain appears in several released versions of the docs and has been publicly communicated as recently as this year's DITA-OT Day 2 days ago, I would prefer to retain it.
I replaced the existing CNAME entry that pointed to herokudns.com with a new Netlify domain alias, and redirected the latter to the Slack shared invite URL in 740e857 instead.


Failed to load prerender page

Hi
I have prerender-node as middle ware. Its working fine in Local and not working the same in production. Here is the code i am using for production. Please check and update me the fixes.
// PRODUCTION
app.use(require('prerender-node')).set({
prerender: 'http://service.prerender.io/',
protocol: 'https', // also tried https, which is what our site uses
host: 'example.me',
prerenderToken: 'XXXXXXXXXXXXXXXXX'
});
I have added the below html code to head tag

When i call http://service.prerender.io/https://example.me url, it rendered html content properly.
But when i called this https://example.me/?escaped_fragment= , nothing pre-rendered. I am unable to find out the issue.

Can you send an email to<EMAIL_ADDRESS>with your URL and your account email address so we can help test?
Thanks!

Hi Team
Here is my website url and account details, Please help me to find out the
exact issue.
https://www.servio.me/
<EMAIL_ADDRESS>On Wed, Sep 6, 2017 at 6:50 PM, Todd Hooper<EMAIL_ADDRESS>wrote:

Can you send an email to<EMAIL_ADDRESS>with your URL and your
account email address so we can help test?
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/prerender/prerender/issues/427#issuecomment-327508366,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ4gyoG-l-x6N9kh8eeIfsOxfjNjYNmbks5sfrE_gaJpZM4POX37
.

--
Thanks & Regards
Kavya V Sagar
Software Engineer, Light Faith IT
m:<PHONE_NUMBER> a: DTECH2, DSO
e<EMAIL_ADDRESS>


Mac shortcut Cmd + Shift + Slash broken after 1.31.1

I use the Mac shortcut Cmd + Shift + / quite often, to navigate the menu of an application (as described here: https://www.imore.com/how-use-macs-help-menu). This shortcut seems to be broken in version 1.31.1. Nothing happens, it also doesn't seem to be bound to a new command.
It's also broken in the insiders build, and when starting without extensions.

VSCode Version: 1.31.1
OS Version: macOS High Sierra 10.13.6

Steps to Reproduce:

Press Cmd + Shift + /
Mac OS should open the help window, in stead, nothing happens

Does this issue occur when all extensions are disabled?: Yes

Cmd + Shift + / works only when there are no open editors

Related to #69375
It looks like Cmd + Shift + / is broken for many Electron based applications.
I am unable to use Cmd + Shift + / on MacOS 10.14.5 for

Spotify Desktop App <IP_ADDRESS>3.g9f48828e
Slack Desktop App 3.4.2

I opened electron/electron#19048 to see if the electron team can help

This is confirmed to be still broken:
Version: 1.37.1
Commit: f06011ac164ae4dc8e753a3fe7f9549844d15e35
Date: 2019-08-15T16:16:34.800Z
Electron: 4.2.7
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.7.0

Filed upstream as https://github.com/electron/electron/issues/19048 . Please comment there.

@bpasero @deepak1556 Assigning to you, as this is 100% an Electron issue. The way this should work via cmd+shift+/ has nothing to do with out keybindings story.

This issue is now fixed for me in VSCode.
Version: 1.55.0
Commit: c185983a683d14c396952dd432459097bc7f757f
Date: 2021-03-30T16:01:05.981Z (1 wk ago)
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0

See the corresponding issue I opened in electron https://github.com/electron/electron/issues/19048 mentioned in https://github.com/microsoft/vscode/issues/68604#issuecomment-506972872.
See the fix in PR https://github.com/electron/electron/pull/27701

I'm trying to set cmd+shift+slash to make a block comment in vscode, but vscode doesn't even recognize the shortcut.
When recording my keys, vscode interprets 'shift+cmd+/' as just 'shift+cmd'.
Using 1.56.0.
Update: strangely enough, upgrading to 1.56.2 fixed my problem. What...

Seeing this on 1.60.0 for the first time.. On a mac running big sur 11.2.3

Sorry missed on following-up here, the relevant upstream issue fix has been available in our stable build for a while now. Verified that https://github.com/microsoft/vscode/issues/68604#issue-409715138 works.

@tnrich please open a separate issue for the issue you are seeing, can you also run the command "Toggle keyboard shortcuts troubleshooting", then use that keybinding and attach the output in the issue. Thanks!


error in scanpy setup command

Hi,
I tried to install the required packages on a freshly set up conda environment with Python 3.6.9 and pip 19.2.3. After the command pip install -r requirements.txt I ran into a problem with scanpy:
Complete output (1 lines):
    error in scanpy setup command: "values of 'package_data' dict" must be a list of strings (got '*.txt')
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

I am now trying to use the latest version of scanpy (1.4.4) and hope that the notebook will run.
Any ideas?

I encountered the same error trying to install scanpy 1.3.4 on Mac OS X 10.14.5:
$ python --version
Python 3.6.9

$ pip --version
pip 19.3.1 from /Users/charles/codes/single_cell_clustering_notebook/vp/lib/python3.6/site-packages/pip (python 3.6)

$ pip install scanpy==1.3.4
Collecting scanpy==1.3.4
  Using cached https://files.pythonhosted.org/packages/47/a2/3edd61806453cccad8828fc74b0d9377cf419abc14b737ed57187e446460/scanpy-1.3.4.tar.gz
    ERROR: Command errored out with exit status 1:
     command: /Users/charles/codes/single_cell_clustering_notebook/vp/bin/python3.6 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/qn/bgn0p0v96w1g6fxsdmvd3qrm0000gq/T/pip-install-qk28r2py/scanpy/setup.py'"'"'; __file__='"'"'/private/var/folders/qn/bgn0p0v96w1g6fxsdmvd3qrm0000gq/T/pip-install-qk28r2py/scanpy/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/qn/bgn0p0v96w1g6fxsdmvd3qrm0000gq/T/pip-install-qk28r2py/scanpy/pip-egg-info
         cwd: /private/var/folders/qn/bgn0p0v96w1g6fxsdmvd3qrm0000gq/T/pip-install-qk28r2py/scanpy/
    Complete output (1 lines):
    error in scanpy setup command: "values of 'package_data' dict" must be a list of strings (got '*.txt')
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Installing the latest version of scanpy (1.4.5.post2) goes okay, not sure if notebook will run though.


image export timeout context deadline exceeded

I am using gcloud compute images export to export an image to GS.
The export build keeps failing after two hours, and I get the following error:
[image-export.image-export-export-disk.wait-for-inst-image-export-export-disk]: 2020-04-30T00:05:05Z WaitForInstancesSignal: Instance "inst-image-export-export-disk-image-export-image-export--03d7b": StatusMatch found: "GCEExport: Read 1.2 TiB of 4.9 TiB (230 MiB/sec), total written size: 221 GiB (32 MiB/sec)"
TIMEOUT
ERROR: context deadline exceeded

Have you tried using the --timeout flag of gcloud compute images export? Based on the progress in 2hrs, setting the timeout to 9hrs should be enough.

I didn't know that this flag existed! Where is it documented? Is the format --timeout=9h?

Hah! I'll try that and report back! Thanks!

Hi Alexandre,
2 hours is the default timeout setting for image export. Your disk is up to
4.9TB, which is pretty large compared to the average level, thus 2 hours is
not enough. Please manually override the timeout value.
Per our internal testing, it takes around 12 hours per TB. You may set the
timeout to 72 hours or even longer if you don't care: just add a
"--timeout=72h". If you don't want to be blocked on the cmd terminal, you
can add a "--async", and check the status from "cloudbuild" tab of the
google cloud UI.
Thanks,
-Tony
On Wed, Apr 29, 2020 at 9:17 PM Alexandre Viau<EMAIL_ADDRESS>wrote:

I am using gcloud compute images export to export an image to GS.
The export build keeps failing after two hours, and I get the following
error:
[image-export.image-export-export-disk.wait-for-inst-image-export-export-disk]: 2020-04-30T00:05:05Z WaitForInstancesSignal: Instance "inst-image-export-export-disk-image-export-image-export--03d7b": StatusMatch found: "GCEExport: Read 1.2 TiB of 4.9 TiB (230 MiB/sec), total written size: 221 GiB (32 MiB/sec)"
TIMEOUT
ERROR: context deadline exceeded
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/compute-image-tools/issues/1190,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AICZZ266D6ROCXL2VSN44KDRPD3VHANCNFSM4MVEY4EQ
.

--
Thanks,
-Tony
Tony Zhang |  Software Engineer |<EMAIL_ADDRESS>|<PHONE_NUMBER>

24 hours is the current limit


Auto-upload new minimized file

Hello,
Is it possible to add a setting that allow us to auto-upload the newly minimized file?
That can be a great feature!
Thanks!

Hey!
Well, I havent thought about such extended features yet. What exactly do you mean with auto-upload? Via SSH? Via FTP?

I use SFTP!
Actually I have your package and remote-sync, and when I save a CSS/JS file it automatically upload the current file via SFTP (remote-sync) and minimize it into a new file that is not upload (your package) :/

Ok, interessting feature request... I think I put it on my roadmap!
What about the credentials? Is this information saved in Atom? Or do you enter it every time you upload the files?

I think they are saved into Atom because I don't need to put them each time it auto-upload or when I restart Atom.


Add tests for descriptor set validation

This is a top-level issue to capture adding validation tests for descriptor set validation cases. The comprehensive list of validation layer checks is contained in vk_validation_layer_details.md. Checks that don't currently have tests identified are below. Tests should be added where missing and the document should be updated.
INVALID_SET
INVALID_LAYOUT
DESCRIPTOR_STAGEFLAGS_MISMATCH
DESCRIPTOR_UPDATE_OUT_OF_BOUNDS
INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE
BUFFERINFO_DESCRIPTOR_ERROR
MISSING_ATTACHMENT_REFERENCE
Descriptor sets also need a test where descriptors are updated with consecutive bindings both correctly and incorrectly based on descriptorsets-updates-consecutive of specification

Completed via SHA-1: 9d2e7a3

tests: GH421 vkUpdateDescriptorSets tests

A) Adding the WriteDescriptorSetIntegrityCheck test, which verifies
some requirements of chapter 13.2.3 of the Vulkan Spec

A uniform buffer update must have a valid buffer index.
When using an array of descriptors in a single WriteDescriptor,
the descriptor types and stageflags must all be the same.
Immutable Sampler state must match across descriptors
The above tests also exercise cases where descriptors are updated with
consecutive bindings both correctly and incorrectly

B) adding a MissingClearAttachment test that points to a wrong
colorAttachment index in a VkClearAttachment structure passed to
vkCmdClearAttachments
C) update vk_validation_layer_details.md to reflect above changes.
Change-Id: I3f4f2233371b68caf23b5a4111d63a94765121c3


Add contributor

Thanks you @hackjutsu for the merge. If you don't mind, please allow me to add myself to contributors.

I've done it in dev branch:)

Thanks!


Vue 3 Support

Do this package support Vue 3? As Vue 3 has RC It will be a good idea to add support for Vue 3.
Regards.

yes, the name may be confused, but it should be works with vue 3 as well.

@mercs600 Great. Thanks. Closing this. I will probably use your package from tomorrow morning and will let you know if there's any issues.

Hi @mercs600
I have tested it in the fresh Vue 3 project and I am getting error. This is due to the render function API is changed for vue 3. Also if it will good to update lifecycle hooks to mitigate the console warning.

Awaiting your response.

Thank you for tests @jd-0001 I will check it

@mercs600 any progress with this?

Thanks to @crutch12 we have created separate version for vue3 -> https://github.com/mercs600/vue3-perfect-scrollbar


revert #7091

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #7181.

Test cases are retained and other is revert.

Very apprieciated. Sorry, we made the wrong call before full evaluation.

Never mind.


no main manifest attribute, in Yeti-1.0.jar

Tired running java -jar Yeti-1.0.jar but get no main manifest attribute. Is this a runnable java file? The install went good. I am on Linux Mint 20.
home@home-computer:~/Downloads/yeti-master/target$ java -jar Yeti-1.0.jar
Error: Could not find or load main class classes.com.sensepost.yeti.FrmMain.class
Caused by: java.lang.ClassNotFoundException: classes.com.sensepost.yeti.FrmMain.class
home@home-computer:~/Downloads/yeti-master/target$ java -jar Yeti-1.0.jar
no main manifest attribute, in Yeti-1.0.jar
home@home-computer:~/Downloads/yeti-master/target$ java -version
openjdk version "11.0.18" 2023-01-17
OpenJDK Runtime Environment (build 11.0.18+10-post-Ubuntu-0ubuntu120.04.1)
OpenJDK 64-Bit Server VM (build 11.0.18+10-post-Ubuntu-0ubuntu120.04.1, mixed mode, sharing)
home@home-computer:~/Downloads/yeti-master/target$ ls -la
total 74524
drwxrwxr-x 9 home home     4096 Mar  2 12:38 .
drwx------ 4 home home     4096 Mar  2 10:28 ..
drwxrwxr-x 2 home home     4096 Mar  2 10:28 archive-tmp
drwxrwxr-x 3 home home     4096 Mar  2 10:28 classes
drwxrwxr-x 3 home home     4096 Mar  2 10:28 generated-sources
drwxrwxr-x 3 home home     4096 Mar  2 10:28 generated-test-sources
drwxrwxr-x 2 home home     4096 Mar  2 10:28 maven-archiver
drwxrwxr-x 3 home home     4096 Mar  2 10:28 maven-status
drwxrwxr-x 3 home home     4096 Mar  2 10:28 test-classes
-rw-rw-r-- 1 home home 43614399 Mar  2 10:28 Yeti-1.0-distribution.zip
-rwxr-xr-x 1 home home 31866837 Mar  2 10:28 Yeti-1.0-inc.jar
-rwxr-xr-x 1 home home   787476 Mar  2 12:38 Yeti-1.0.jar
MANIFEST.MF looks like this
Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven 3.6.3
Built-By: home
Build-Jdk: 11.0.18

I figured it out. I didn't unzip that file that was created from the install. Once I did that I was able to open the yeti1.0-inc file with execute permission from the command line in yeti1.0 folder. Thanks :). God bless :).


Decouple event listeners from flow

What about decoupling the event listeners one can define in their flow into own classes which can be triggered by a compiler pass?

@daFish, is this still relevant?

No and I'll close the issue.


[BUG] Response status code does not indicate success:  403 during Visual Studio 2022 17.10 startup

Describe the bug
During Startup of VS2022 I get an error message from StartIsBack+ telling that something went wrong.
To Reproduce
Steps to reproduce the behavior:

start Visual Studio
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS] Windows 11 23H2
VS2022 17.10

Additional context
Add any other context about the problem here.

Hi André
SP+ is simply reporting an error that it received from a web request. The error itself had to have come from amazonaws.com
The only place in SP+ that I would ever expect to see such an error is when opening a Developer News item, which I know you don’t use.
Does the error keep happening? Or is it just a one-off? What are you doing just before you see the error?
Yann

yes, it comes from the url https://vsstartpage.blob.core.windows.net/news/vs . Even when I turn Developer News off the extension still tries to read the URL.
Btw, can you please merge my PR #37 ?

Same error here in vs2022 with disabled 'developer news'. The error appears 1-2 times once I open Start+ in VS for the first time.

I use a different feed now to avoid this error


Add styling to requests list (React, HTML, CSS) for Hacktoberfest

Hacktoberfest Introduction
Click here for a description of the issue.
We're currently looking for developers who are in React, TypeScript, JavaScript, HTML, CSS, Algolia, and/or Firebase. development.  We strive to implement best practices for implementing Clean Code techniques, including test driven development and object oriented programming.  If you want to learn about these techniques or would like to work on a team that implements these practices, join us!
This is a great team to work if you want to work with other developers or if you want to work solo.
We have daily pair and mob (collaborative) programming collaborative coding.  In these sessions, you can work on implementing a feature or addressing an issue together with other developers. This is good both for learning about the product when you are first starting and you may find you like working this way better than working on your own.  You will be listed as a co-author for any changes that are committed during a session, which will increase your GitHub contribution statistics.
Joseph or Ethan are available to work with you on video conference to fix or implement the hacktoberfest issue or you can fix the issue on your own.
The best way to get ahold of them is through the Reach4Help Slack workspace or email<EMAIL_ADDRESS>The readme.md(https://github.com/reach4help/reach4help/blob/hacktoberfest/README.md) will give you information on starting the project.  Please do pull requests to the hacktoberfest branch.
https://github.com/reach4help/reach4help/blob/hacktoberfest/README.md

Feature Description
Modify the tabbed page for requests and offers to look like the below image.  We will accept pull requests for implementation of any change that furthers the UI towards this image - you don't need to do all the changes.
The URL path for this page is list/my/offers or list/my/requests.  The URL to create new requests is create/.  The drop down should have the options All Requests, Pending, Ongoing, or Closed.

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

ZenHub Information
This information is updated automatically. To modify it, please use ZenHub.

I will try it

@edwinfelipe Great!  If you need help, you can Slack me or @ashwinkjoseph on the Reach4Help channel or mention my name in the issue.  You are more likely to get an answer in Slack.  I am also available for phone / video conference typically 9 AM to 5 PM EST and @ashwinkjoseph is 7.5 hours ahead of me.

Any comments on how to improve the issue or documentation would be greatly appreciated.

@edwinfelipe Please use development branch, instructions previously referred to the hacktoberfest branch.

@edwinfelipe I have not seen any progress, so I am unassigning.

Yes.  @ashwinkjoseph and I are available for questions and we can pair with you.  Slack is the best way to communicate with us on the team-development channel, but we will also reply to posts in this issue.  We like to have updates every couple of days or let us know when you plan to start working on it.  I have assigned it to you.

@ethanstrominger sounds good. I spent some time on setup and read through the CodingConventions documentation today. I plan to start working on this on Monday.

@felix-chin Can you sign up for Slack and send @ashwinkjoseph a Slack message?  If it works for you, it is easiest for us to communicate there.


Grammarly login URL https://www.grammarly.com/login does not exist

When trying to login to the Grammarly account in the VS Code plugin, it redirects to https://www.grammarly.com/login which is not a valid login URL, instead use https://www.grammarly.com/signin as the Sign-In URL.

You should use "Grammarly: Signin to grammarly.com" command. I'll update the link though.

You should use "Grammarly: Signin to grammarly.com" command. I'll update the link though.


StringLiteralDuplication potential false positive with interpolated strings

Expected Behavior
No finding.
Observed Behavior

Test.kt:76:21 (see cursor in screenshot): Multiple occurrences of the same string literal within a single file detected. Prefer extracting the string literal into a property or constant. [StringLiteralDuplication]

Steps to Reproduce

Context
As you can see in the screenshot above, the dynamic test names are being detected as duplicate. This would be fine, because at first glance all the "cycle start-end" strings "look" the same, but if you look at the start/end variables, you can see they all have different types. At this point, I'm unsure if this detection is valid, because there would be no function that could be extracted to simplify the code.
Your Environment

Version of detekt used: 1.23.6
Version of Gradle used (if applicable): 8.7
Gradle scan link (add --scan option when running the gradle task): N/A
Operating System and version: N/A
Link to your project (if it's a public repository): N/A

At this point, I'm unsure if this detection is valid, because there would be no function that could be extracted to simplify the code.

A function that receives Any. You only care about the toString of those classes.
Anyway, should this rule check strings with variables inside it? I'm not sure.

🤦🏻♂ that makes so much sense. So this is a viable option:
fun cycle(start: Any, end: Any): String =
    "cycle ${start}-${end}"

I guess your observation will hold true for any expression inside an interpolated string. So extracting a function with String or Any params is a viable way to fix the duplication.
Could this be just a doc update with a hint then? (TBH, I haven't read the docs of this rule yet, might be already there...)

Could this be just a doc update with a hint then?

No sure about what could we write there for this case but sure, any improvement on the docs is more than welcome.

This issue is stale because it has been open 90 days with no activity. Please comment or this will be closed in 7 days.

This issue was closed because it has been stalled for 7 days with no activity.


How can I mention a user?

See https://api.slack.com/docs/formatting
Trying "Hey <@U024BE7LH|bob>, did you see my file?" won't convert the userstring to a proper mention.

Hi @h-teske,
I've just tested this out and it worked correctly.
poster.send_message("<@U04UQC3NF|Daniel> is a nice guy") converted the message with the right mention to the user on my team.
How are you sending the message? Could you share some code?


When updating Visual Studio Code is asking for a password to Add Helper

VSCode Version: 1.7.1
OS Version: macOS Sierra 10.12.2

Steps to Reproduce:

Click check for updates
The following dialog pops up, if you enter your password it says an update is available, but when clicking to restart it doesn't do anything
This doesn't happen with a fresh install

On more investigation I'm getting the following error in dev tools when I don't give the password.
Failed to clear temp storage: It was determined that certain files are unsafe for access within a Web application, or that too many calls are being made on file resources. SecurityError

This dialog shows up when you had VS Code installed in one location and then you downloaded it again to another location and the auto update kicks in.

Hi, I did not move VS Code to a different location but I am getting the same message when auto update kicks in. Furthermore it fails to install the update and I need to install new versions of VS Code manually. It seems that this happens since I am on Sierra public beta.

@joaomoreno any more clues where this could come from? I only saw it once on Sandeepds machine when he downloaded VS Code to a new location, started it and it was auto updated.

This is #7426. It happens to me when Code is in the Downloads folder. @JohnGinger where is your application bundle located?

It looks like it is the same issue, Code is in the Downloads folder.

If you put it in the Desktop, for example, does it work?

It doesn't seem to update, but it doesn't prompt for a password before saying an update is avaliable.

It keeps asking for password again and again

it's linking to com.apple.quarantine feature in sierra, here is the WA.

remove vscode completely using appdelete or others. you cannot just simply remove vscode inside from app.
change com.apple.quarantine attribute
xattr -dr com.apple.quarantine "/Applications/Visual Studio Code - Insiders.app"

after that, run vscode won't get a prompt of having a password to install helper, you will receive a new error message indicate no permission to create temp files. Off cause, the update still fail.
3. change permission.
sudo chown myuser:staff /Users/myuser/Library/Caches/com.microsoft.VSCode.ShipIt/*
change myuser to your user id.
4. re-try update.

@xcity It's better if you link people to my post in #7426

I have the same issue. Is there a less manual solution to this?


Add support for subdomains.

Under development :hourglass_flowing_sand: Please ignore :see_no_evil:

[X] Modify the realm registration form
[X] Validate login so that the user is logged in correct subdomain
[x] Change the confirmation link
[x] Show error if sub domain doesn't exists
[ ] Add support for more than 1 open realms
[ ] Tests

Automated message from Dropbox CLA bot
@hackerkid, it looks like you've already signed the Dropbox CLA. Thanks!

Cool!  Do you have a plan for how this new feature should work in a Zulip development environment, where there's only one DNS name (localhost:9991) configured by default?  I can think of a few approaches:

Encourage the user to put some stuff in /etc/hosts to create more DNS names for localhost (seems hackish and an annoying setup cost, but could be OK)
Use different ports for the different realms in development
Just use different URLs for this feature on localhost, e.g. <IP_ADDRESS>:9991/realms/example.com/ would be the URL prefix for the example.com realm.

@timabbott Encourage the user to put some stuff in /etc/hosts to create more DNS names for localhost
I tried this by adding some *zulip.dev subomains to /etc/conf.
<IP_ADDRESS>   hello.zulip.dev
<IP_ADDRESS>   www.zulip.dev
<IP_ADDRESS>   awesome.zulip.dev

Bottom script correctly identify the subdomain outside the vagrant env.
domain = request.META.get('HTTP_HOST') or request.META.get('SERVER_NAME')
pieces = domain.split('.')
 subdomain = ".".join(pieces[:-2])

But  in vagrant env if we open the url in browser it gets resolved to localhost.
There is a fix for this solution. To use prax. I am having a little trouble with prax right now but I think i can fix it. But introducing prax involves making changes in the host computer. So I don't think this is a good solution for testing.
http://awesomeprogrammer.com/blog/2014/12/07/vagrant-setup-for-multiple-subdomains-application/

Yeah, seems messy.  How about this as a proposal:

We do a more complex set of settings:

UNIQUE_REALM_URLS is checked in most places and controls whether this feature is happening at all (e.g. whether the user needs to input a realm key in the UI when creating the realm).  And then there are two other settings controlling the implementation:
REALMS_HAVE_URL_PREFIX: default=True in development (and available to production servers that want to use it) does the e.g. <IP_ADDRESS>/r/example.com/ style URL prefixes.
REALMS_HAVE_SUBDOMAINS: default=False in development.  Uses actual subdomains with a wildcard certificate; I think this could share the vast majority of the code with the REALM_URL_PREFIX feature.

@timabbott Sounds good. This will simplify the development and testing.

@timabbott Actually the script to obtain subdomain works in a  normal django development server running in vagrant machine.  But zulip dev server keeps on returning localhost:9991 as the domain.(Even after changing the /etc/hosts file of vagrant machine and making a request using wget in server) Any idea why this occur?

It's probably because of either this setting:
zproject/dev_settings.py:EXTERNAL_HOST = 'localhost:9991'
Or how run-dev.py does the proxying...

@timabbott Found a fix for this by using  get_host() method. It returns the domain correctly.

@timabbott I have completed a working version. Please check. You can test the sub domains by adding subdomains in /etchosts. Also you have to change the value of localhost in dev-settings to the domain to make it work.

The structure here looks pretty reasonable; I won't have a chance to look here in detail until Wednesday though (looks like you have some test failures to fix in the meantime anyway).

@timabbott Updated the code. Tests are passing.

@timabbott I think the logic of implementing by-urls would be different from that of subdomains. We are depending a lot on get_host method for the subdomain feature. I think there is a good chance that the subdomain feature may get broken even if the by-urls one is working. Travis has support of custom subdomains. I think we can use them for testing.

Well, the tests need to run locally (either in Vagrant or via manual setup), not just in Travis CI.  There's a few different testing methods we should be thinking about here:

Manual testing.  For this, the by-urls concept is probably easiest, since we don't want to be in the business of modifying /etc/hosts on users' host machines.
Backend tests.  For this, we can mock the DNS calls to make the subdomains version work, either in Python or via an LD_PRELOAD hack like http://jhrozek.livejournal.com/4301.html.  I think those approaches may suffice for testing the subdomains codepath.
Casper tests.  For this, the by-urls set of pages will be the same (but with different URLs), so it might be good enough to just do that (or we can use the LD_PRELOAD approach or Travis' support for custom subdomains to do it with subdomains).

Does that make sense?

@timabbott Yeah got it. Working on this.

@hackerkid wanted to check in -- have you resolved the comments I posted?

@timabbott Yeah. Those are resolved. I am facing slight problems in re-running the casper tests again for subdomains. Full front end tests would be completed by tomorrow.

Looks like the tests fail with Python 3; @sharmaeklavya2 can you help @hackerkid debug?

@sharmaeklavya2 Thanks. :)

@timabbott Tests are passing. :)

Dev settings for testing subdomains. Use zulip.zulipdev.com for logging with<EMAIL_ADDRESS>or the any other default accounts when REALMS_HAVE_SUBDOMAINS is enabled.
# For the Dev VM environment, we use the same settings as the
# sample local_settings.py file, with a few exceptions.
from .local_settings_template import *

LOCAL_UPLOADS_DIR = 'uploads'
EXTERNAL_HOST = 'zulipdev.com:9991'
ALLOWED_HOSTS = ['zulipdev.com']
AUTHENTICATION_BACKENDS = ('zproject.backends.DevAuthBackend',)
# Add some of the below if you're testing other backends
# AUTHENTICATION_BACKENDS = ('zproject.backends.EmailAuthBackend',
#                            'zproject.backends.GoogleMobileOauth2Backend',)
EXTERNAL_URI_SCHEME = "http://"
EMAIL_GATEWAY_PATTERN = "%s@" + EXTERNAL_HOST
ADMIN_DOMAIN = "zulip.com"
NOTIFICATION_BOT =<EMAIL_ADDRESS>ERROR_BOT =<EMAIL_ADDRESS>NEW_USER_BOT =<EMAIL_ADDRESS>EMAIL_GATEWAY_BOT =<EMAIL_ADDRESS>EXTRA_INSTALLED_APPS = ["zilencer", "analytics"]
# Disable Camo in development
CAMO_URI = ''
OPEN_REALM_CREATION = True
REALMS_HAVE_SUBDOMAINS = True
# Use ".zulipdev.com" when testing sub domains
SESSION_COOKIE_DOMAIN = ".zulipdev.com"

After running the migration in my development environment, I get this on the Zulip development environment homepage (<IP_ADDRESS>:9991/):

I think we probably want to make the development experience here still good; maybe DevAuthBackend should still display the list of users on the homepage in development even with this setting enabled?

I tested this out; it appears sending messages is broken in this branch with this traceback:
2016-07-19 00:06:50,454 ERROR    Problem handling data on queue message_sender
Traceback (most recent call last):
  File "/home/tabbott/zulip/zerver/worker/queue_processors.py", line 72, in consume_wrapper
    self.consume(data)
  File "/home/tabbott/zulip/zerver/worker/queue_processors.py", line 321, in consume
    result = {'response': ujson.loads(resp_content), 'req_id': event['req_id'],
ValueError: Expected object or value

This is caused by some messy complexities in how the message sending code path works.  Basically, sending messages involves the frontend sending a websockets request to Tornado, which dumps the message sending content into a queue that is eventually handled by MessageSenderWorker in zerver/worker/queue_processors.py.  MessageSenderWorker creates a fake WSGIRequest object based on the data, and then passes it to the Django request system to process.  The bug here is that we're not passing through and setting the HTTP_HOST header in that fake WSGIRequest.  Does that make sense @hackerkid?

Thanks for all your work on this so far @hackerkid!  I posted several comments above and also some bug reports from trying it out.

Cool, thanks for working on this @hackerkid!  I think it would have been better to split your Casper refactoring into a larger number of small, clear, correct, commits; to demonstrate what I had in mind I've split your changes into a series of smaller commits in this branch:
https://github.com/timabbott/zulip/tree/casper-refactor
The final state of that branch is the same as the final state after your second commit in this branch, but it's split into more commits.
My intent is to merge all the but the last two commits; the second-to-last commit is contains the changes from your branch that I would have asked you to change in review:

the comment for the subprocess.Popen being detached from the code it refers to,
Some extra whitespace changes
Indenting a """ block, which would have the effect of changing the error message to have extra spaces before each line (probably not intended)
Passing the arguments to run_tests as kwargs unnecessarily.
Moving where run-dev.py is started to be further away from the try/except block intended to shut it down (structurally, this should come run after run-dev.py is started).

The final commit contains changes that I think belong most correctly in your Add support for subdomains commit, so I've left it separate; I also have one bit of feedback on that, which is that I think it'd be cleanest to have realms_have_subdomains be the second argument to the function.
In the future, when doing complex refactoring projects to existing, it'd be great if you did your work in the style demonstrated by the branch I posted; with that style, it's a lot easier to catch little issues like this, both in your own code and for reviewers.
Thanks @hackerkid!

(I merged the first N commits of that branch into master).

@timabbott All casper tests are passing when REALMS_HAVE_SUBDOMAINS is enabled.

Cool!
Some UI comments from the accounts/register page:

"You can change this later on the admin page" -> I would make this smaller
"Acme" -> would change this to "Acme Corporation", to make the distinction between the org name and subdomain a little clearer
"Team subdomain" -> subdomain. I don't think we have a concept of a team anymore.
I would add some explanation below the subdomain box. E.g. "Your zulip instance will live at .domain.com. You can change this later on the admin page.".
The register button feels a tad too large to me, but maybe that's how we have it on the rest of the site as well.

Also, I haven't quite managed to get it working. When I hit Register on http://zulip.zulipdev.com:9991/accounts/register/:

If subdomain is not in ALLOWED_HOSTS, I get sent to http://.zulipdev:9991/invite/ which results in a server not found error. For the dev environment, ALLOWED_HOSTS = ['*'] seems reasonable.
If subdomain is in ALLOWED_HOSTS, I get to the Realm Does Not Exist page.

My dev_settings.py is
from .prod_settings_template import *

LOCAL_UPLOADS_DIR = 'uploads'
EXTERNAL_HOST = 'zulipdev:9991'
ALLOWED_HOSTS = ['*']
AUTHENTICATION_BACKENDS = ('zproject.backends.DevAuthBackend',)
# Add some of the below if you're testing other backends
# AUTHENTICATION_BACKENDS = ('zproject.backends.EmailAuthBackend',
#                            'zproject.backends.GoogleMobileOauth2Backend',)
EXTERNAL_URI_SCHEME = "http://"
EMAIL_GATEWAY_PATTERN = "%s@" + EXTERNAL_HOST
ADMIN_DOMAIN = "zulip.com"
NOTIFICATION_BOT =<EMAIL_ADDRESS>ERROR_BOT =<EMAIL_ADDRESS>NEW_USER_BOT =<EMAIL_ADDRESS>EMAIL_GATEWAY_BOT =<EMAIL_ADDRESS>EXTRA_INSTALLED_APPS = ["zilencer", "analytics"]
# Disable Camo in development
CAMO_URI = ''
OPEN_REALM_CREATION = True
REALMS_HAVE_SUBDOMAINS = True
# Use ".zulipdev.com" when testing sub domains
SESSION_COOKIE_DOMAIN = ".zulipdev.com"

SAVE_FRONTEND_STACKTRACES = True

Thanks!

@rishig Thanks for the review.

If subdomain is in ALLOWED_HOSTS, I get to the Realm Does Not Exist page.

Did you ran provision.py before testing this. I made some changes in zilencer/management/commands/populate_db.py so that the subdomain of the default realm is set to zulip.

@timabbott Please check :)

cool! Still playing around with it, but it generally looks great. I changed a bunch of the href's to point to domain/XXX instead of subdomain.domain/XXX (e.g. for XXX = terms, about, api, integrations, apps, etc) and rebased onto master -- you can grab the changes from rishig/zulip/review-1154.

@brainwane Updated !

@hackerkid I owe you an update -- over the last few days. @rishig and I fixed a bunch of minor issues around this branch (E.g. making the /integrations page show your subdomain, fixing all of the emails Zulip generates to show the subdomain, etc.) and are now using a version of this on zulipchat.com; I need to reorganize the code and add some more tests so that we can merge it into master, but I just wanted to let you know we're now using this in production, and it works great.
I'll post more when I get a chance in the next day or so.  Huge huge thanks for building this @hackerkid!

@timabbott Pleasure is mine. I learned a lot working on this one. I hope to start working on pending projects in a few days. I have been a bit busy due to University works in the last month. :)

I just finished merging this into master today, including code for enforcing that you can't use the API with the wrong subdomain.  So, we can finally close this PR.  There's a few follow-up issues I'll open soon.


Grammar error, lack of symbol.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks!