ThorChain decimals changed to 8

Description
ThorChain decimals changed to correct value 8.  It has been changed in assets repo info already.
Testing instructions
Unit tests.  Retrieve balance from Thorchain RPC.
Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] Prefix PR title with [WIP] if necessary.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] I have read the guidelines for adding a new blockchain
[x] If there is a related Issue, mention it in the description (e.g. Fixes #<issue_number> ).

On Sat, Jun 5, 2021, 8:17 PM hewigovens @.***> wrote:

@.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/trustwallet/wallet-core/pull/1455#pullrequestreview-676816470,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APJ46KIMRGTDLVM3R35J4FTTRK5DBANCNFSM46FE5H7A
.

Kryptonitechic


jsonBodyOf has to use Body.Of internally

Expected Behavior

Actual Behavior

Mention any other details that might be useful

Steps to reproduce the behavior

The log given by the failure.

closed with pr #44


Heatmap-Query

Write a Incremental MapReduce Query that generates a collection with triangulated packet-data. Output should approximately look like this:
{ time: '2334349834', location: { type: 'Point', coordinates: [Lng,Lat] }}

Done and checked in


Docs: replace emoji with regular warning

The docs don't render emoji, so replaced the :warning: with a **Warning**: to keep the formatting consistent with **Note**: used in other parts of the docs.
Fixes https://github.com/docker/docker/issues/17281

There are a couple more in docs/deploying.md.  Could you get those too please? :warning:  :black_joker:

@RichardScothern sure! didn't look further :)

There you go! :+1:

LGTM
Farewell sweet emoji :crying_cat_face:

@RichardScothern we can probably add it back, as a UTF-8 character

Thx!


Swagger schema operationId

Informations

Type
Version

Bug
4.x

Description
operationId in the swagger json should be the actual name of the function in the controller.
For example:
Controller: HomeCtrl
Function/Method name: home
The operationId is generated as "HomeCtrl.home_1" instead of "home", which is not appropriate to use with code generators or client SDKs.
Acceptance criterias

[ ] Example:
Current Example:         "operationId": "HomeCtrl.home_1",
To Example:                        "operationId": "home",

fixed

Hi Romain,
In which version the fix is available or how to test it?
Regards,
Keshav
On 2 June 2018 at 09:51, Romain Lenzotti<EMAIL_ADDRESS>wrote:

Closed #377 https://github.com/Romakita/ts-express-decorators/issues/377
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Romakita/ts-express-decorators/issues/377#event-1659533550,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmpR4vvmTPKvZlwcjdnnbIj1Mb-c3V7ks5t4kP4gaJpZM4UXJn2
.

--
Thanks,
Keshav

@dgkmurthy Latest version :) 4.19.0

@Romakita Still the operationId is coming has "operationId": "AuthDeviceCtrl.register", instead it should be "operationId": "register" without "." for code generators to generate the working methods correctly.

@Romakita
Here is the working code under: services/SwaggerService.ts
        this.getOperationId = (targetName, methodName) => {
            let operationId = methodName;
            if (this.OPERATION_IDS[targetName] == undefined) {
                this.OPERATION_IDS[targetName] = {};
            }
            if (this.OPERATION_IDS[targetName][methodName] !== undefined) {
                this.OPERATION_IDS[targetName][methodName]++;
                operationId = methodName + "_" + this.OPERATION_IDS[targetName][methodName];
            } else {
                this.OPERATION_IDS[targetName][methodName] = 0;
            }
            return operationId;
        };

Ok I'll integrate it ASAP :)

Hi @dgkmurthy,
I'v added a new options in swagger configuration. Now you'll able to change the operationId format.
Example:

@ServerSettings({
   swagger: {
     operationIdFormat: "%c.%m"  //  %c => className, %m => method name
   }
})
class Server extends ServerLoader {
}

Version 4.27.1
See you,
Romain

Hi @Romain,
Thats' perfect.
Thanks,
DGKM
On Thu, 19 Jul 2018 at 13:56, Romain Lenzotti<EMAIL_ADDRESS>wrote:

Hi @dgkmurthy https://github.com/dgkmurthy,
I'v added a new options in swagger configuration. Now you'll able to
change the operationId format.
Example:
@ServerSettings({
swagger: {
operationIdFormat: "%c.%m"  //  %c => className, %m => method name   }
})class Server extends ServerLoader {
}
Version 4.27.1
See you,
Romain
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Romakita/ts-express-decorators/issues/377#issuecomment-406250778,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmpR57-poh3ZnIfGMbaIn9uhlcDPbVJks5uIHQCgaJpZM4UXJn2
.

--
Thanks,
Keshav

Hi @Romain,
After looking at the code I see an issue when using %m only, then the
counter will begin on just %m which is not correct when we have 2
functions/methods having the same under 2 different controllers.  The
counter should be at the %C.%M level and then only it should append "_1"
for overloaded methods/function names.
Regards,
DGKM
On Thu, 19 Jul 2018 at 13:56, Romain Lenzotti<EMAIL_ADDRESS>wrote:

Hi @dgkmurthy https://github.com/dgkmurthy,
I'v added a new options in swagger configuration. Now you'll able to
change the operationId format.
Example:
@ServerSettings({
swagger: {
operationIdFormat: "%c.%m"  //  %c => className, %m => method name   }
})class Server extends ServerLoader {
}
Version 4.27.1
See you,
Romain
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Romakita/ts-express-decorators/issues/377#issuecomment-406250778,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmpR57-poh3ZnIfGMbaIn9uhlcDPbVJks5uIHQCgaJpZM4UXJn2
.

--
Thanks,
Keshav

@dgkmurthy The problem is, operationId must be unique for the all spec. Try in swagger editor, you'll seen the spec isn't valid when two operationId have the same name. Use only %m isn't sufficient to generate a uniqueId, this is why a use className + methodName.
What is your tool to generate the code ?

https://swagger.io/docs/specification/paths-and-operations/

@Romain, The operationId's must be unique in the spec, but when we do "Grouping
Operations With Tags" then operationId have to be unique within operations
under a given tag group and not necessarily across the whole spec.
https://swagger.io/docs/specification/grouping-operations-with-tags/
In general the code generators use "tags" as the class name and
"operationId" as method names.
Try checking yourself at  https://editor.swagger.io/ as follows:

Modify at least 2-3 operationIds to the same name under each tag such
as pet, store, user.
then generate the client code for typescript-angular
open the code in the editor then see how the operationIds are
converted to the method names and how they are indexed under each file when
they are not unique

Regards,
DGKM
On Fri, 20 Jul 2018 at 07:33, Romain Lenzotti<EMAIL_ADDRESS>wrote:

https://swagger.io/docs/specification/paths-and-operations/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Romakita/ts-express-decorators/issues/377#issuecomment-406493733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACmpR3n2nSDeSK0zr1Np1OKd_N37_xvjks5uIWuOgaJpZM4UXJn2
.

--
Thanks,
Keshav

Fixed :)

Perfect 💯, thanks :)


{{version}} Should not include version metadata

Cargo supports having metadata in it's version numbers: https://doc.rust-lang.org/cargo/reference/resolver.html#version-metadata
In the https://github.com/gfx-rs/rspirv/ crate we're using this to specify which upstream SPIR-V headers we're compiling against while keeping our own releases compatible with SemVer. However, cargo dependencies can't contain metadata information.
So for example; a package has version of 0.1.0+1.54 for example, in it's Cargo.toml file, the version should still be listed as 0.1.0.
Right now when we're using cargo release we specify the version number like so cargo release -- 0.1.0+1.54, however this populates the {{version}} regex replacement attribute with 0.1.0+1.54 which isn't valid in a lot of cases. Ideally it should strip everything after the + sign and emit that (or alternatively there ought to be a {{version_no_metadata}}.

Thanks fior reporting this! I think having two replacement variables is the way to go, the question just being what to call them

How about {{version}} and {{complete_version}}?

Been giving this thought and my suggestions are either

{{version}} (no metadata) and {{metadata}} (only metadata)
{{version}} (no metadata) and {{version_metadata}} (only metadata)

And users can combine them as they wish
Thoughts?

@epage I'd argue that {{version}} is commonly used in a position to fill a line in READMEs showcasing what to copy-paste, or to update other crates' dependencies inside the same git repo. Both shouldn't use metadata and I'm all in favour for dropping that from {{version}} as you describe, even if not backwards compatible.
For your examples, does the {{*metadata}} include or exclude the +? That is, to compose the original version back, would users have to write {{version}}+{{version_metadata}}?

I was thinking it would exclude the +.  In the case of the OP, this would mean {{metadata|| would directly map to the version they are tracking which you can't do if you have +.  This just requires a little more work to reconstruct but ends up being the most flexible.

btw I'm  working on another PR that will have shared work with this effort

Its in

@epage I have to say I'm in favor of your suggestion - like @MarijnS95 said, {{version}} is usually used in places where you want users to copy-paste a working version directly into their dependencies list (or update a dependencies list as part of the release process).
If you want I can close my PR in favor of your refactoring.

My refactoring is in and ready for someone to implement this on top of it.  We now have pkg.version.full_version (to get metadata) and pkg.version.bare_version_string (no metadata).

If it'd help, feel free to add a Version::metadata_string variable

Was looking at this again and the annoying thing is we have

prev_version
version
next_version

Each can have its own metadata.  Unsure if I should do similar (prev_metadata, metadata, next_metadata).  Thoughts?


Request marshaling uses singleton like response marshaling

Request marshaling is stateless by design and can be turned into a singleton like the response marshaling.
Description
For educational purposes I was trying to understand the inner working of the SDK. I realized that the response marshalers are singletons. I was wondering why the request marshalers haven't been made singletons as well. I analyzed a few and came to the conclusion all of those can be made singletons by design since the state they gatter is per method invication. So I went ahead and changed the generator to turn the request marshalers into singletons as well. This will save an allocation per method call on the SDK for each service.
Furthermore while testing out my changes I got tired of waiting for the generator so I implemented the generation calls on the driver with a Parallel.ForEach wich drastically reduces the generation time.
Motivation and Context

Less allocations on the hot path (one less object allocation per API call)
More speed while generating the SDK types

Testing

Run the generator and compile the SDK (that's all I did)

Screenshots (if appropriate)
Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have read the README document
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

License

[X] I confirm that this pull request can be released under the Apache 2 license

Impressive to dive deep into the code generator. It is a good idea to convert the request marshallers into singleton. I'm getting a lot of compile errors after running the generator. I think the call to AddRequestSingletonMethod is not in the right place in the RestXmlRequestMarshaller.tt.
Also the S3 request marshallers for S3 are hand coded for legacy reasons. They would need the singleton property added.

I compiled the net 4.5 solution which compiled successfully. Let me verify and fix then

Am 14.07.2017 um 03:08 schrieb Norm Johanson<EMAIL_ADDRESS>Impressive to dive deep into the code generator. It is a good idea to convert the request marshallers into singleton. I'm getting a lot of compile errors after running the generator. I think the call to AddRequestSingletonMethod is not in the right place in the RestXmlRequestMarshaller.tt.
Also the S3 request marshallers for S3 are hand coded for legacy reasons. They would need the singleton property added.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@normj Updated the code. I hope I got all the legacy request handlers.

I don't want to be that guy... can't resist... ok let's do it: any updates? ;)

Any updates?

So should I close this PR because there is no interest to continue here? Is it worth investing my time to rebase?

ok did a quick rebase attempt, fingers crossed

ping @normj

@normj @PavelSafronov any reason why this is not moving along? The PR is now open for a long time. If you don't want to take it for some reasons please spell out the reasons and I'll close this PR.

Hehe. Cool thanks for the update. Looking forward to the review

Rebased

So this will never be merged?

@normj @sstevenkang @vellozzi
If you guys need any more input from my side or want me to tweak a few things on this PR feel free to ping me.

I rebased this branch because I still think this is a valuable contribution ;)

Not sure why this didn't get marked as merged but it is finally merged. Here you can see your commits.
Thanks for your patience with this getting merged.


add getBlockReceipts

Creating new type TransactionReceipt along with enums:

TransactionReceiptKind (for the transaction "type" field).
TransactionReceiptStatus (for success vs failed transactions)

Add ethrpc method eth_getBlockRecipts according to the spec defined here is as in https://ethereum.github.io/execution-apis/api-documentation/#eth_getblockreceipts

We got it now! @tifrel figured out the serde stuff.

Accepted all suggestions.

All done. The only thing not addressed as suggested was removing flatten on the Status enum. Not sure if that was intentional or what, but its no good.

The only thing not addressed as suggested was removing flatten on the Status enum. Not sure if that was intentional or what, but it's no good.

It was intentional. There is no need to flatten as the enum has no inner fields. The issue is that you are manually specifying it as a tag-ged enum, when it shouldn't be and then it would not require a flatten. For an example, look at BlockTag, which does not require flattening to use.

All fixed up. Thanks for bearing with me here. Future PRs will be smoother.
I will follow this up with a few other methods that return TransactionReceipts.

I did the things. Wasn't very articulate on the enum level docs strings...

Wen merge?


Encapsulate metadata aggregates

As step 0 towards getting some metadata API improvements, encapsulate metadata batch internals so that every random system isn't reaching inside anymore. The API presented is not ergonomic or honestly good in any way, but it does at least separate data from logic so we can iterate going forward.

There's a corresponding internal CL that'll need to land simultaneously with this.


400 Bad Request when request other port with SSL

For example when I try to POST data to
https://example.com:9999

It wil happen..
Maybe I was wrong? But I do not know how to fix it..

BTW: I know we can reconfig the Nginx in server, but we can not do like that now.. so, I can only fix it in client..

LuaSocket does not include SSL support directly.  If you have LuaSec installed, you can use the request() function fromssl.https in much the same way you would use the request() function from socket.http.  Please let me know if this solves your problem.
We're reviewing open items in preparation for a release.  If action is needed here, please add a comment.  Otherwise, this issue will be closed on or after 24-Feb-2019.
Thanks!


[CodeCompletion] Allow type variable in MakeAbstractConformanceForGenericType

When TypeChecker::typesSatisfyConstraint() is called with openArchetypes true, archetypes are substituted with type variables. If they have conformances, they used to hit assertion in MakeAbstractConformanceForGenericType::operator() because it doesn't accept TypeVariableType.
Adjust the assetion to accept TypeVariableType.
rdar://problem/56834798

@swift-ci Please smoke test

@slavapestov I'm not 100% sure this is the right solution. Could you take a look?
FWIW, in all known reproducers, typealiases are involved and hit the assertion in this SubstitutionMap::subst
https://github.com/apple/swift/blob/5c04e0d3627dcb31dbabed829fa90470e51f9003/lib/AST/Type.cpp#L3602-L3603

This doesn’t feel right. Why does the caller need opened archetypes in the first place?

@CodaFi

Why does the caller need opened archetypes in the first place?

For example, given:
func takeArray<T>(_ x: [T]) {}
var foobar: [Int] = []

takeArray(#^COMPLETE^#)

We want to suggest foobar([Int]) is convertible to [T]. Without opening archetypes, typesSatisfyConstraint() with ConstraintKind::Conversion returns false.

Another solution (workaround?) I found is to desugar typealias when the parent ends up with type variables:
diff --git a/lib/AST/Type.cpp b/lib/AST/Type.cpp
index 31f898b14ad..f91e2a147b6 100644
--- a/lib/AST/Type.cpp
+++ b/lib/AST/Type.cpp
@@ -3602,7 +3602,8 @@ static Type substType(Type derivedType,
                              substitutions, lookupConformances, options);
       auto underlyingTy = substType(aliasTy->getSinglyDesugaredType(),
                                     substitutions, lookupConformances, options);
-      if (parentTy && parentTy->isExistentialType())
+      if (parentTy &&
+          (parentTy->isExistentialType() || parentTy->hasTypeVariable()))
         return underlyingTy;
       auto subMap = aliasTy->getSubstitutionMap()
           .subst(substitutions, lookupConformances, options);

Does this look better?

We might be applying the wrong substitutions somewhere. I have no objections to the original change, but the fact that it only shows up with type aliases is a bit odd. I'll take a look.

Can one of the admins verify this patch?

Merging as is for now.


Update Jaeger community-operators to v1.20.0

Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

New Submissions

[x] Does your operator have nested directory structure?
[x] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[x] Are you familiar with our contribution guidelines?
[x] Have you packaged and deployed your Operator for Operator Framework?

[x] Is your submission signed?

Updates to existing Operators

[x] Is your new CSV pointing to the previous version with the  property?
[x] Is your new CSV referenced in the appropriate channel defined in the  ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Submit operators to both  and  at once
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/test CVP

CVP/operator-catalog-initialization Pending

Is this job stuck?

/test CVP


Unexpected value() method behavior when querying Eloquent models.

Laravel Version
11.7.0
PHP Version
8.3.7
Database Driver & Version
SQLite
Description
User::find(1)->value('email') generates 2 SQL queries and returns incorrect result while it is expected to work the same as User::where('id', 1)->value('email') that generates 1 query and returns correct result.
Correct query produced by User::where('id', 1)->value('email'):
SELECT
  `email`
FROM
  `users`
WHERE
  `id` = 1
LIMIT
  1

Incorrect 2 queries produced by User::find(1)->value('email'):
SELECT
  *
FROM
  `users`
WHERE
  `users`.`id` = 1
LIMIT
  1

SELECT
  `email`
FROM
  `users`
LIMIT
  1

So the value() method in the second case returns the value of email column of the row returned by DB without filtering by id column.
Steps To Reproduce

Get a fresh Laravel 11.7.0 (or 10.48.4) installation;
Create either MySQL or SQLite database
Run php artisan migrate:fresh --seed;
Run App\Models\User::where('id', 1)->value('email') then run App\Models\User::find(1)->value('email');
Compare sql queries produced.

That's intended. find is a direct search and retrieve method while value was intended to be used in combination with the query builder like you've demonstrated.


Ideas

This issue is literally related to ideas that could potentially translate into packages and functionalities. Having this here just for now so I can easily add comment when I get creative moment.

All of the tooling from the [solgo](https://github.com/unpackdev/solgo should be implemented into this package to really allow this Web3 package to shine.

This project needs to be fully open sourced and available to everyone.


Package Rustpad

Project description
Rustpad (live demo: https://rustpad.io) is an efficient and minimal open-source collaborative text editor based on the operational transformation algorithm. It lets users collaborate in real time while writing code in their browser. Rustpad is completely self-hosted and fits in a tiny Docker image, no database required.
Metadata

homepage URL: https://rustpad.io
source URL: https://github.com/ekzhang/rustpad
license: mit
platforms: unix (probably)

The Dockerfile gives a first idea of what needs doing:

rustwasm
server
some NPM/Typescript GUI

https://github.com/NixOS/nixpkgs/blob/30c3cc499d4715b050de8f4a39dbf4b8edde7e5c/pkgs/servers/kanidm/default.nix#L76
The wasm part is sadly not in nixpkgs yet

This is the issue tracking wasm32-unknown-unknown https://github.com/NixOS/nixpkgs/issues/89426


Added Riviera support for Icache Ibex test

Hey!
This pull request is for Riviera support for Ibex Icache tests

Hey!
On new commit I added required changes, now should be fine.
About regex expression, I remove ^, we have control under this message and is unique so requirement about start of the line is not necessary

@dawidzim You'll need to add a signed-off-by line to your commit, you can update the commit with git commit --amend -s. This should make CI pass.

Ok, thanks. Now I think should be ok. @imphil @sriyerg can you review this?

Thanks for help @imphil . I added all your comments and merged all commits to one


feat(precheck): add support for 3v3 templates

Notes:

We could infer 3v3 projects either from the existence of a VAPWR port or from the different project area. But I think we can save ourselves from some surprises down the line if we make this choice explicit, so I've added an extra uses_3v3 field to info.yaml and use that as a single source of truth.
For this version of the precheck I'm explicitly disallowing analog / custom gds projects with zero analog pins and access to 3v3 power. It might make sense to allow it in a follow-up patch if we can handle it properly.

Thanks! I added uses_3v3 to the analog template. Can you please also update the https://tinytapeout.com/specs/analog/ with the new field?

For this version of the precheck I'm explicitly disallowing analog / custom gds projects with zero analog pins and access to 3v3 power. It might make sense to allow it in a follow-up patch if we can handle it properly.

What should change for handling it properly?

Thanks! I added uses_3v3 to the analog template. Can you please also update the https://tinytapeout.com/specs/analog/ with the new field?

Done.

For this version of the precheck I'm explicitly disallowing analog / custom gds projects with zero analog pins and access to 3v3 power. It might make sense to allow it in a follow-up patch if we can handle it properly.

What should change for handling it properly?

It depends whether we want to put it on a digital or an analog mux.
If we put it on a digital mux:

do we need new def templates?
do we need new power gate sizes?
do we need to restrict available tile sizes for 3v3 custom gds projects?

If we put it on an analog mux:

do we assume anywhere in our tools that analog_pins=0 implies digital?
do we want to charge extra for limited real estate on the analog muxes?

Thanks for explaining!


Make it possible to use or with slot values

Proposed changes:

fix #8933

Status (please check what you already did):

[x] added some tests for the functionality
[x] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

Just checked it: slot_was_set doesn't affect the visualization at all — so nothing needs to be adapted in rasa.shared.core.training_data.visualization


Allow _target links to be opened up in the same way as UIWebView.

Fixes https://github.com/react-native-community/react-native-webview/issues/139 .

:tada: This PR is included in version 4.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Use Span to reduce memory pressure

This way a user may pre-allocate a buffer for calling the FFTpower and FFTfreq and then reuse those arrays later, during the lifetime of the application.

Adding Span overloads on FFT transform methods to avoid allocation of arrays and with that reducing pressure on LOH and GC.
Adding dependency on System.Memory to use spans in netstandard2.0
Using ArrayBuffer to rent temporary arrays for intermediate calculations
Adding unit tests

On thing to consider is to multitarget netstandard2.0 and net5.0 (net6 in a few weeks). In net5.0 the nuget package is part of the appframework, so we would not need to list it explicitly.


docs: clarify dataloader usage with nestjs

Currently, there's no clarification if the dataloader feature work with @nestjs/graphql. If so, some example like this should be added to docs:
@Entity()
class Book {
  @ManyToOne(() => User, user => user.books)
  public author: Rel<User>
}

@Resolver(() => Book)
class BookResolver {
  public constructor(private readonly entityManager: EntityManager) {}

  @ResolveField(() => User)
  public async author(@Parent() { author }: Book) {
    return this.entityManager.findOne(User, { id: author.id })
  }
}

Btw there is apparently one alternative if you dont want to use the Ref wrapper - you can create it via wrap helper dynamically and return that from your resolver:
  @ResolveField(() => User)
  public async author(@Parent() book: Book) {
    return wrap(book.author).toReference().load();
  }

(at least that's what one user recently said worked for them)
I would still rather suggest using it - type safe relations (Loaded type) depend on this too.

Thank you for the quick response, I've tried here and just works!

hope this makes it clearer, PR welcome if you see more room for improvements


iPhone scroll entire screen

This is a (multiple allowed):

[x] bug
Swiper Version: 4.5.0.
Platform/Target and Browser Versions: iPhone, all iOS devises.

What you did
On iPhone you are able to scroll the whole screen to the right and view blank white space when swiping normal web content. You can then see all the other images in wrapper. If you are on last image you can not swip whole screen.
How can I stop this scrolling on iPhone?
Expected Behavior
Unbale to scroll entire screen and view blank space.

Have found a solution to this.
Add stying to html.
Insert the scroller within:
`

`

Have found a solution to this.
Add stying to html.
Insert the scroller within:
`
`

Please explain a bit more?


Batch submit task

Adds https://github.com/PrefectHQ/prefect-aws/issues/38

Perhaps another PR, and I think @mtconger97 might be interested in helping out with it!


⚠ Samsung has degraded performance

In 2a2a3f9, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2237 ms

Resolved: Samsung performance has improved in dd21352.


Update all TemplateParts to Match Convention

Describe the bug
Certain controls do not properly name their template parts. These should be renamed to follow convention before the 11.0 release as it is a breaking change for the styles.
This is the breaking-change following PR #7911 and #7994.
Also discussed in #7432
I will also close this one, just adding to keep track of it.
Expected behavior
All template parts should start with the "PART_" prefix as is done in WPF and most controls.
Screenshots
N/A
Desktop (please complete the following information):

OS: [e.g. Windows, Mac, Linux (State distribution)]
Version [e.g. 0.10.0-rc1 or 0.9.12]

Additional context
Add any other context about the problem here.

@Takoooooo @maxkatz6
I'm waiting on the big styling updates branch to be merged before I do this. However, it still needs to be done before 11.0. If you want, just let me know a good time to open a PR and I can do this quickly.

Yes, it should be done after control theme changes, otherwise huge conflicts are unavoidable.
Also, not really necessary to have this done in first preview versions.

Now that all the control theme updates are made, I'm going to go through and update template parts within the next week or so.

Adding link to a specific discussion: https://github.com/AvaloniaUI/Avalonia/issues/3538#issuecomment-1141275108

Well, I had no visibility on the Preview 1 release date or I would have got this in. However, there is a draft PR now.


apps:run test with lengthy output -- don't log actual output on failure

When/if this apps:run test fails, the Expect statement proceeds to log the entire command's output, corrupting the user's terminal and crowding out logs with byte code.
We should re-jigger the test, perhaps checking first if the byte array does not match expected (outside of Expect) and then, if not, logging some standard error/failure message accordingly.

Alas, since the output is stored in sess.Out.ContentsI(), Ginkgo will log this anytime the test fails (no matter how test is failed).  Wondering if there's another way to eliminate logging of output?  Or, another way to test this case?  ping @mboersma

This issue was moved to teamhephy/workflow-e2e#2


fix(store): use symlinks for empty blocks heighs

There is limitation on max amount of hard links in ext4 filesystem of 65000. Some chains have more empty blocks (arabica). We will use symlinks for empty blocks to avoid this limitation, while keeping hard-links for non-empty blocks.

Codecov Report
Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (shwap@89e8781). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

store/store.go
85.71%
1 Missing and 1 partial :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##             shwap    #3747   +/-   ##
========================================
  Coverage         ?   46.69%
========================================
  Files            ?      314
  Lines            ?    17869
  Branches         ?        0
========================================
  Hits             ?     8344
  Misses           ?     8507
  Partials         ?     1018

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(gotrue/client): add noResolveJson options in GoTrueClient constructor

What kind of change does this PR introduce?
This is a new feature, implementing the parameter noResolveJson that will be used in _handleRequest function in https://github.com/supabase/gotrue-js/blob/master/src/lib/fetch.ts#L79
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

hi @canserkanuren, can you please explain why we need to add this to the constructor?


Allow labels to be created with the service

I've been trying out Rancher the past week or so and this was an awesome
find. I've since learn't that for my set up to work I need to add labels
in order for my load balancer (traefik) to recognise my containers.
As my CI/CD pipeline is dev => gitlab => rancher, I found it pointless
setting this up only to have to add the labels manually.
This fixes that, so now I am able to build review branches on the fly
without having to push my commits, wait for the tests, docker build,
docker push and hit the Rancher API for me to then manually add the
labels.
Please be aware this is the first bit of python code I've ever written, so please let me know if there are any changes you want me to make.

Hey @cdrx, this PR looks great, is well documented, very useful and works as expected - could you merge it? :) If you don't have enough time to maintain this project - maybe i could help a bit? :)

Thanks for the PR!


CI test - supply ZET binary instead of building it every time

In CI this change uses the binary built by cmake.yml.
Running locally, you must set a var, e.g., ZITI_EDGE_TUNNEL_BIN=./build/programs/ziti-edge-tunnel/Release/ziti-edge-tunnel ./docker/docker.test.bash.

I expect the checks on this branch to succeed after the branch merges on which this twig is based.


Treat two-width character incorrectly

Describe the bug
context
| 模型    | 时间    |
|---------|---------|
| BBFN    | 2021-07 |

expectation
| 模型    | 时间    |
| ------- | ------- |
| BBFN    | 2021-07 |

bug
| 模型      | 时间      |
| ------- | ------- |
| BBFN    | 2021-07 |

problem
Asian characters have double width.
Reproduce the bug
mdformat a table containing Asian characters.
| 模型    | 时间    |
|---------|---------|
| BBFN    | 2021-07 |

List your environment
No response

Thanks for the issue!
I moved this to mdformat-tables issue tracker as mdformat core does not format tables.
Is there a database/mapping somewhere that shows the width of Unicode characters? If the width is font dependent, I'd be inclined to perhaps stick to current style where each Unicode character is considered to have the same width.

Is there a database/mapping somewhere that shows the width of Unicode characters?

https://github.com/jquast/wcwidth should be your need.

Any progress about this issue?

FYI, I'm taking a look at: https://github.com/hukkin/mdformat-gfm/issues/33
And might be able to help make this change in parallel

I have a PR ready, pending the other changes I have open: https://github.com/KyleKing/mdformat-tables/pull/1
Hopefully the patch should be released in the next few weeks if still useful to you 🤞🏻


[v1.14] test: Remove duplicate Cilium deployments in some datapath config tests

When disabling IPv6 BPF masquerading in datapath configuration tests using the host firewall, we accidentally duplicated the command to deploy Cilium for some of the tests. Let's clean this up to avoid slowing down the tests.
Fixes: 934e1f2df26c ("daemon: Forbid IPv6 BPF masquerading with the host firewall")
Partial backport from https://github.com/cilium/cilium/pull/31511.

/test-backport-1.14

/ipv4

Think we can merge - this only touches test code, and the relevant tests are green.


Add support for php 7.1

Hello,
With Magento 2.2, PHP 7.1 is now supported, which is great since we can finally use our distros' official packages. Unfortunately, this module is the last one blocking the upgrade, since its composer.json only supports php ~7.0.0.
Could you review the code and up the php version requirement ? Thanks!

Hi,
we have tested the module on Magento 2.2 and PHP 7.1 and a new version has been released allowing the install.
We now presume the module is compatible with all PHP 7 versions and Magento 2 versions to not limit the use of the module to early PHP or Magento new version testers.
Regards.

Fixed in 1.0.9 version : https://github.com/PayboxByVerifone/Magento2/releases/tag/v1.0.9


Internal PartitionKeyRangeHandler : Adds code to expose bug

Internal PartitionKeyRangeHandler : Adds code to expose bug
Description
This code reverses the priority of epk ranges. It now favors the parent epk range over the child. If PartitionKeyRangeHandler was working properly it would return a split exception and and the FeedRangeIteratorCore class would handle it. Currently it just sends the request to the first of the children and pretends nothing went wrong. This is a bug that will be caught in integration tests.
Related to :
https://github.com/Azure/azure-cosmos-dotnet-v3/issues/1935

Don't see the point of merging a code change to force an integration bug or break the behavior of components just to point at a design issue on one of the components. Rather propose a refactoring that you think it's better and improve the current contracts instead?

There is no refactoring needed. From the issue linked it is clear that the code just needs to checked the epk range set in the request and honor it. It's a bug at the end of the day and nothing more.

This code path no longer exists due to this PR:
https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1947


feat/overlay

Codecov Report

Merging #773 (7c2e715) into dev (e5b67ae) will increase coverage by 0.09%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##              dev     #773      +/-   ##
==========================================
+ Coverage   95.41%   95.50%   +0.09%
==========================================
  Files         221      236      +15
  Lines        5408     5566     +158
  Branches      994     1028      +34
==========================================
+ Hits         5160     5316     +156
- Misses        248      250       +2

Impacted Files
Coverage Δ

packages/varlet-ui/src/overlay/Overlay.tsx
95.00% <95.00%> (ø)

packages/varlet-ui/src/overlay/index.ts
100.00% <100.00%> (ø)

packages/varlet-ui/src/overlay/props.ts
100.00% <100.00%> (ø)

packages/varlet-ui/src/popup/Popup.tsx
100.00% <0.00%> (ø)

packages/varlet-ui/src/result/Empty.vue
100.00% <0.00%> (ø)

packages/varlet-ui/src/result/Error.vue
100.00% <0.00%> (ø)

packages/varlet-ui/src/result/Warning.vue
100.00% <0.00%> (ø)

packages/varlet-ui/src/result/Info.vue
100.00% <0.00%> (ø)

packages/varlet-ui/src/result/Result.vue
100.00% <0.00%> (ø)

packages/varlet-ui/src/loading-bar/index.ts
100.00% <0.00%> (ø)

... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Connection to multiple market - PANIC

Hi,
I am trying to connect to multiple markets but the program keeps crashing in UpdateWidth function (orderbook.go).
Here's the code to reproduce this issue. It takes a minute or so to get the error message.
https://paste.ubuntu.com/p/yrMhhDBRsn/
What am I doing wrong? Thanks for your help...
David

Hi @JacobPlaster. Would you please take a look at this issue? Is there any way how to handle 429 status code? Also if I use "defer c.Close", program panics after all reconnection attempts finish.
https://paste.ubuntu.com/p/49w26kFYmq/

Hi @dklodner  sorry for the late reply. Ill check that out for you

@dklodner again sorry for the late reply. Did you manage to sort this out? It seems like the above error that you posted was caused by our API gateway rate limits

API rate limiting can't crash the program, don't you think? It looks like the library isn't handling 429 rate limiting error messages (increasing reconnection timeouts?) and it panics once the reconnection process ends after predefined number of tries.

@dklodner yes I agree, but It doesnt seem like its the rate limiting bad hanshake is causing the crash here. The library attempts the reconnect which is to be expected but does not panic until it exhausts all of its attempts and then finally proceeds to kill the process. I think this is more of a problem with the lib not shutting down gracefully.  I wonder if you would still get this problem if you increased the reconnection timeouts/attempts so that the lib re-establishes the connection using something like this:
p := websocket.NewDefaultParameters()
// Enable orderbook checksum verification
p.ManageOrderbook = true
p.ReconnectAttempts = 100
p.ReconnectInterval = time.Second * 60
c := websocket.NewWithParams(p)

err := c.Connect()
if err != nil {
    log.Fatal("Error connecting to web socket : ", err)
}

The bitfinex API limits can vary in a range of 10 to 90 requests per minute so setting the interval to be a minute should reset the limits. In the meantime though ill definitely look into the shutdown logic of the lib

That's what I ended up doing. It would be great if you were able to find a permanent solution. Thanks for your help.


object storage benchmarks on GCP should not copy the gcloud logs

The Object Storage benchmarks copy the .config/gcloud directory in order to get permissions.  As part of this it also copies the logs from the local machine.
Ideally GCP should use the delegated auth mode vs trying to copy in permissions.
However in the short term we should just stop copying the logs.

Fix in pr #383 out for review.

PR merged. Fixed.


Feature/push relabel

Description:

This pull request adds a C implementation of the Push Relabel Algorithm for computing the maximum flow in a flow network. The Push Relabel algorithm is a highly efficient method, particularly suitable for networks with a large number of edges, as it uses local operations to update flow values rather than relying solely on augmenting paths.

Importance:

Efficiency: The Push Relabel algorithm can handle larger and more complex flow networks efficiently, making it a valuable addition for applications requiring maximum flow calculations.
Performance: It often outperforms traditional methods like the Ford-Fulkerson algorithm, especially in dense graphs.

Additional Notes:
The implementation follows the standard approach, using an adjacency matrix to represent the flow network.
Ensure that the graph data structure conforms to the expected format for proper functionality.
Future enhancements could include optimizing the push and relabel operations or implementing variations of the algorithm for specific use cases.

Added Push Relabel Algorithm and it's documentation in readme.md file.


Build Overlay component

Issue #756

[x] Create Overlay generic component

Proof

@Ovifer13 how can I test this?

@sofiaromorales create a useState for the open and setOpen props, and do an onclick function to set it to true so the Overlay actives.

@sofiaromorales already did the fix that you told me to do, looking way better!


Add schema compatibility strategy on topic level

Motivation
Currently, the compatibility strategy for a schema is set at namespace level, which means that all the topics of a namespace will need to adhere to the same compatibility check, this level particle size is relatively large, so add schema compatibility strategy on topic level.
Modifications

Add set and get schema compatibility strategy API to broker and admin module
Add schema compatibility strategy action to TopicOperation

Verifying this change

[x] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): no
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: no

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] doc-required
[ ] no-need-doc
[ ] doc

Signed-off-by: Zixuan Liu<EMAIL_ADDRESS>

Hi @nodece please do not delete backticks (for example, doc-required ✅, doc-required ❌) or else Bot does not recognize the label, thanks.

@Jason918 Could you please help review this PR?


Add additional documentation

On top of auto-generated doc, add

Setup
Demos

done in #11 , to be added to rolling, galactic, foxy

done


Add ARM / Apple Silicon builds

It looks like there might have been ARM builds in the past, but they were removed.
Would it be possible to add ARM builds for Apple Silicon users?

Yeah, I don't remember why they were removed, but I think we had an issue with building on macOS and no time to debug back then.
It's definitely the right time to revisit it though.

This should be complete as of the merging of https://github.com/svix/svix-webhooks/pull/325.

Yay! I just want to merge #323, and then we'll do another release. :)


Slashes in proxy service

This does not work:
http://api-dev.freme-project.eu/current/e-entity/freme-ner/documents/?informat=text&input=Diego Maradona is from Argentina.&outformat=json-ld&language=en&dataset=dbpedia
This works:
http://api-dev.freme-project.eu/current/e-entity/freme-ner/documents?informat=text&input=Diego Maradona is from Argentina.&outformat=json-ld&language=en&dataset=dbpedia
The difference is the slash after documents. I think the problem lies within the proxy service.

Problem solved.


Check/update R-CNN for Caffe v0.999

Caffe v0.999 introduced a fair number of changes, so I suspect R-CNN might need a few adjustments. We can update the vetted R-CNN release once it's ready!

Hello! I noticed before some changes in r-cnn code in order to be compatible with Matlabr2014a. May you indicate to me the #issue to find it ? Thank u in advance!

Dear @rbgirshick  I've tried to finetune net on my own dataset but it seems there are some incompatibilities with caffe 0.999. Finetune.net is not placed anywhere and when I tried to finetune the network with  caffe train --solver= mysolver.prototxt -weights _iter_5000.caffemodel, i could find executable caffe. May you suggest some other way to solve this issue. I have already make windows files for my dataset.


TNO-2907 Add status to disable send

This logic, disables the send in case the instance is already accepted, so it wouldn't make sense to re-send it.
Once you unblock or start the new report, the you would be able to send again, and the send flow isn't blocked on the "Submitted" status.

I don't think we want to block the ability to resend.   There is technically wrong with sending a report again, although subscribers would receive multiple copies.

I don't think we want to block the ability to resend. There is technically wrong with sending a report again, although subscribers would receive multiple copies.

The main issue was on the status not being updated on resend, and then getting locked. The change on the service will do it.

Changes on service addressed this error.
This won't be necessary anymore.


Bikes on Muni light rail are banned, so such routes shouldn't be returned

We can either

Manually mark Muni light rail lines (and streetcars and cable cars), somehow, as not allowing bikes; or,
Override various other transit agencies' GTFS feeds that say that bikes aren't allowed while the official policy is actually that they are allowed. (We found at least one example of this - was it County Connection?)

This should block private beta, because we're pretty much immediately going to give people illegal routes through the Twin Peaks Tunnel and Sunset Tunnel, which we shouldn't do.
A more ambitious version of this issue would be to allow the user to specify if their bike is a folding bike, which is allowed on Muni light rail, but still not allowed on Muni cable cars and historic streetcars. (See Muni bike rules) I don't think GTFS captures that complexity right now.

was thinking we should have bikesAllowedOverride as a request param with some structured data in operator/mode that allows us to specify where bikes are not allowed. and then have that as a hardcoded constant in the front end or in bay-area-config.yml (whatever makes the most sense philosophically)

We're not returning these anymore, but it would be a good idea to no longer hardcode these fixes.  In the mid term, by having some pre-build step that uses https://github.com/interline-io/transitland-lib to fix data. In the long term, by fixing the data in the GTFS feed itself.


python_library: Add robot.logger.debug

for debugging stuff

We are actually moving away from adding scripts to repository in favor of separate npm packages per scripts. See #1113 for details, and let us know if you have any questions about getting going with that!


Search capability

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 MetadataTreeMergeChunkChange.cs#L42: Constructor has 8 parameters, which is greater than the 7 authorized.

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 MetadataTreeMergeChunkChange.cs#L42: Constructor has 8 parameters, which is greater than the 7 authorized.


Wrong comparison between dates

Hi,
I have a collection with two datetime columns, start and end. However, when I'm trying to filter by date, I'm getting a seemingly wrong result -- see the attached screenshot:

Shouldn't the string "2023-08-06T00:04:33Z" compare as less than the start column?

The date field value must be in the format Y-m-d H:i:s.uZ, aka. without the T.
We are using space instead of T as separator for backward compatibility with earlier versions.
This may change in the future as there are plans to introduce date filter normalizations to allow searching by custom timezone.


How to avoid multiple 'extra credentials' errors on page

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Expected or Desired Behavior
In some scenario's users get the error message that there is something wrong with their credentials and they have to 'click here' to fix it. This usually does fix the issue, but this error message gets re-added for every call we do via the graph client. This can add up to quite a few messages if you have a full intranet homepage with a bunch of SPFx components.
Is there some way we can verify the user is correctly logged in before we start doing calls? I can't find anything in the docs for the MSGraphClient regarding this. Right now we use this:
(docs; https://docs.microsoft.com/en-us/sharepoint/dev/spfx/use-msgraph)
this.context.msGraphClientFactory
               .getClient()
               .then((client: MSGraphClient): void => {
   	// do stuff here with our client
   	// any client.get() done here will add an error message to the page
   },
   error => {
   	// handle errors, this doesn't go off ever
   }
);

Observed Behavior
A whole bunch of errors (Dutch, sorry) get added when doing MSGraphClient calls and there is something wrong with the current user token/login

I've been told this happens mostly when switching networks or when switching accounts isn't done properly. The error is correct and it's fine that it shows, but once is enough ;)
Perhaps it is also possible to add to the SPFx SSO backlog that the errormessage only gets shown once on the page?

No-one has a clue how to prevent this?
Should I update this ticket to be a bug then? It doesn't seem quite right to have this many errors. It's also very noticeable to Safari users as that browser tends to have a lot of issues with SPFx SSO.

I get this issue some times too but it seems more like a general issue in SharePoint. I was not able to fix it now.

This has been fixed, we now only see one error.


pipenv doesn't appear in list of interpreters

I'm using pipenv for a workspace, with a Pipfile and Pipfile.lock, but when I go to Python: Select Interpreter, I only see python binaries from my $PATH, but I don't see any pipenv in the list.
I have also set "python.venvPath": "~/.virtualenvs", in my VSC settings.

Why was this closed?

The "Select interpreter" dropdown list shows 6 items by default. If there are more, then you need to scroll down. The seventh item was the pipenv Python. Unfortunately, the scroll bar does not appear (at least on Mac) until you actually scroll, so I didn't think to just scroll down further.


drivers: gnss: Fix nano parameter not being checked in __ASSERT

          str is being checked instead of nano

Originally posted by @michael-whg in https://github.com/zephyrproject-rtos/zephyr/pull/61073#discussion_r1393471924

@michael-whg please fix the signed-off

@michael-whg thanks for following up on this


docs: community page translated into Korean

Background
We translated the Using with community page.
If you think there are aspects that need improvement, please let me know, and I would be happy to make the adjustments. Thank you!
I have requested a Korean translation review from one reviewer in the FSD Discord Korean community to ensure that my Korean writing is well done. I would appreciate it if you could merge it after the review is completed.

Hello Maintainer,
I have completed the review of this translation, and the contributor has incorporated the suggested changes. Upon re-review, I did not find any issues. Please take a look when you have time.
Thank you!

@illright


All Changes page - add links to lines

Request from Joe:

On the all changes section would you be able to add a 179 link for the 79 and a 660 under the 260 section (as well as the 260 link).

Double-check that the Line Details pages also have these links.

Made changes to the doc and re-ran the notebook to generate the links for 79 and 660, however I'm not sure which links you are talking about for the Line Details pages. Is it 79 and 179? 660 or 260? As it stands the 179 looks like this:

Pitching back to you for you to provide more details @matikin9 !


Use testdata folder

as in grpc source (https://github.com/grpc/grpc-go/tree/master/interop/server) or golang source (https://github.com/golang/go/tree/f78a4c84ac8ed44aaf331989aa32e40081fd8f13/src/strconv/testdata && https://github.com/golang/go/tree/f78a4c84ac8ed44aaf331989aa32e40081fd8f13/src/net/testdata)

This will also drop direct dependency on neptulon/ca package which is always nice.


Upgrade python-jose dependency to fix ImportError

ImportError: cannot import name 'Mapping' from 'collections' (/usr/local/lib/python3.10/collections/init.py)
should be fixed with python-jose==3.3.0
ImportError verified in Python 3.10 (probably also in 3.9)

@bjinwright @kingtong any update on this? It would be good to have a new version published in PyPi that's compatible with Python 3.10.


Not founding resources

The current version doesn't found the resources on mongo 3.0, it occurs because the adapter uses IDs as strings and not as ObjectID.
Replace ids for ids.map((id)=>new ObjectID(id)) should fix.

Actually, I decided that ObjectID should just be avoided, because it's heuristically difficult to tell if a string should be cast to an ObjectID or not. In this commit https://github.com/daliwali/fortune-mongodb/commit/333139076a434fa70cf0ba5570cba5fc24668622 it just generates random strings as the ID on document creation.

Nice. Thanks.


IPMIView: update src hash

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Please format the title and commit message like IPMIView:: update src hash.

Please format the title and commit message like IPMIView:: update src hash.

done

Hmm, that has does not work for me either:
trying https://www.supermicro.com/wftp/utility/IPMIView/Linux/IPMIView_2.17.0_build.200505_bundleJRE_Linux_x64.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   152  100   152    0     0    234      0 --:--:-- --:--:-- --:--:--   234
100  189k    0  189k    0     0   237k      0 --:--:-- --:--:-- --:--:--  237k
hash mismatch in fixed-output derivation '/nix/store/dcibg5lhw552197ckzh3iky61fkjxv9z-IPMIView_2.17.0_build.200505_bundleJRE_Linux_x64.tar.gz':
  wanted: sha256:1k2cjpq73j2d4vnjj7q9b38pbccjmls1qp1zy2vb1iv2yh2d76z6
  got:    sha256:1r0zmk9navx6sivgpxslghq75qpsav9llqc5ckhbrc10n5zakcph
cannot build derivation '/nix/store/q7hqvl4rczwip4f0z8chyc7gqjh7xfkv-IPMIView-2.17.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/q7hqvl4rczwip4f0z8chyc7gqjh7xfkv-IPMIView-2.17.0.drv' failed

Looks like we need to update to 2.18 which can be downloaded from https://www.supermicro.com/wftp/utility/IPMIView/Linux/IPMIView_2.18.0_build.201007_bundleJRE_Linux_x64.tar.gz

Unfortunately patchelf fails on libiKVM_v11_64.so:
patchelf --set-rpath /nix/store/7in2alrzhkpcax5fk4823ismvsmdk1aj-gcc-9.3.0-lib/lib ./libiKVM_v11_64.so
patchelf: no section headers. The input file is probably a statically linked, self-decompressing binary

patching is still neceserry:
ldd libiKVM_v11_64.so
	linux-vdso.so.1 (0x00007ffc3bdfb000)
	libstdc++.so.6 => not found
	libm.so.6 => /nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libm.so.6 (0x00007f243859e000)
	libgcc_s.so.1 => /nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libgcc_s.so.1 (0x00007f2438584000)
	libc.so.6 => /nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib/libc.so.6 (0x00007f24383c5000)
	/nix/store/9df65igwjmf2wbw0gbrrgair6piqjgmi-glibc-2.31/lib64/ld-linux-x86-64.so.2 (0x00007f243d004000)

index 4b740a943c0..370b58709b0 100644
--- a/pkgs/applications/misc/ipmiview/default.nix
+++ b/pkgs/applications/misc/ipmiview/default.nix
@@ -13,12 +13,12 @@

 stdenv.mkDerivation rec {
   pname = "IPMIView";
-  version = "2.17.0";
-  buildVersion = "200505";
+  version = "2.18.0";
+  buildVersion = "201007";

   src = fetchurl {
     url = "https://www.supermicro.com/wftp/utility/IPMIView/Linux/IPMIView_${version}_build.${buildVersion}_bundleJRE_Linux_x64.tar.gz";
-    sha256 = "1k2cjpq73j2d4vnjj7q9b38pbccjmls1qp1zy2vb1iv2yh2d76z6";
+    sha256 = "10cv63yhh81gjxahsg4y3zp4mjivc217m4z1vcpwvvnds46c65h8";
   };

The above diff fixes the download issue for me. Unfortunately patchelf failse. May need another approach like presetting LD_LIBRARY_PATH

me close this task and open for update to the version 2.18.0 ?

I am fine with either adjusting this PR or opening up a new one.

I am fine with either adjusting this PR or opening up a new one.

https://github.com/NixOS/nixpkgs/pull/106428

Superseeded by #106428


authentication/sociallogins.rst "Enabling authentication using Facebook, Google and other external providers"

[Edit by Rick-Anderson]

[x] HaoK's complaint above
[ ] Specify the "Valid OAuth redirect URIs" for Facebook (and other providers). E.g. http://localhost:12345/signin-facebook. See https://github.com/aspnet/Security/blob/dev/src/Microsoft.AspNetCore.Authentication.Facebook/FacebookOptions.cs#L22
[ ] #1908  add copy the https URL also in the Launch URL from the Visual Studio IDE same page.
[ ] update entire article
[ ] #86
[x]  A walk-through for Google, MicrosoftAccount, LinkedIn and Twitter that highlights some if their eccentricities.
[ ]  A reference to https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers for additional providers
[ ]  Requesting more data with Scopes (general oauth) and Fields (Facebook specific).
[ ]  Using the OnCreatingTicket event to map additional data into claims
[ ]  How to map provider claims into the Identity database
[ ]  Specify the "Valid OAuth redirect URIs" for Facebook (and other providers). See Tratcher comment below

-- original which is now fixec
There appears to be a new step that needs to be done via App registration in facebook.
I got an error saying my AppDomain was not registered.
The fix is to add localhost to the AppDomain text box during the WebSite platform registration.

[ ] HaoK's complaint above
[ ] update entire article

Specify the "Valid OAuth redirect URIs" for Facebook (and other providers). E.g. http://localhost:12345/signin-facebook

I have also noticed this could use some TLC. Is anyone working on it? If not, I can start making some changes.

@daveabrock  that would be great.

On it! I'll have a pull request soon in the next few days for cleanup and addressing @HaoK's comment (me seeing it myself brought me here) and then will address @Rick-Anderson's list a little later on.

@daveabrock  can you review the check boxes at the top and let me know what's completed?

@01binary can you review the check boxes at the top and let me know what's completed?

@Rick-Anderson:
A reference to https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers for additional providers
See Other Providers linked to from a bullet list on Social Providers Index page. While this doesn't link to their GitHub page, it does link to NuGet packages (which I think is more convenient). The NuGet page then links to GitHub page with Project Site item on the left sidebar.

Specify the "Valid OAuth redirect URIs" for Facebook (and other providers). See Tratcher comment below
All social login pages in the following set:
Facebook logins
Google logins
Microsoft logins
[Twitter logins] (https://github.com/aspnet/Docs/blob/master/aspnetcore/security/authentication/social/twitter-logins.md)
Contain the following paragraph and two notes which address this issue:
Enter your current site URL with signin-provider appended into the Callback URL field. For example, https://localhost:44320/signin-provider.
[!NOTE] When deploying the site you'll need to register a new public url.
[!NOTE] You don't need to configure signin-twitter as a route in your app. The Twitter middleware automatically intercepts requests at this route and handles them to implement the OAuth flow.
Please note that the first post in this issue thread has not one but two checkboxes for duplicate issue (valid OAuth redirect URLs).
I am not seeing anything else that can be checked off at the moment.

Moved to #16210


Refactor Response model to allow for separate Error field or model

Refactor Response model to allow for separate Error field or model

@pavel-ship-it can you also make the description the title of the PR? We need to keep our formatting of pull requests unified.

@pavel-ship-it can you also make the description the title of the PR? We need to keep our formatting of pull requests unified.

@pavel-ship-it should we close this considering the alternate route we took?

@pavel-ship-it should we close this considering the alternate route we took?


bug: the result of String() of FixedAmountPlan and RatioPlan don't include EpochAmount or EpochRatio.

Currently String() method both FixedAmountPlan and RatioPlan use is implemented only in BasePlan.
We need to implement String() for both types to correctly include EpochAmount or EpochRatio in the result.
Also, we should discuss whether to use MarshalYAML() for String() or not.
We could just use the default String() implementation.
@dongsam @kogisin How do you think?

@hallazzang
Is there a place where String() is currently used? Currently farmingd q farming plans --output json | jq or http://<IP_ADDRESS>:1317/cosmos/farming/v1beta1/plans returns with @type include EpochAmount or EpochRatio through ctx.PrintProto or ctx.Codec.MarshalJSON
{
  "plans": [
    {
      "@type": "/cosmos.farming.v1beta1.RatioPlan",
      "base_plan": {
        "id": "1",
        "name": "First Public Ratio Plan",
        "type": "PLAN_TYPE_PUBLIC",
        "farming_pool_address": "cosmos1228ryjucdpdv3t87rxle0ew76a56ulvnfst0hq0sscd3nafgjpqqkcxcky",
        "termination_address": "cosmos1228ryjucdpdv3t87rxle0ew76a56ulvnfst0hq0sscd3nafgjpqqkcxcky",
        "staking_coin_weights": [
          {
            "denom": "pool93E069B333B5ECEBFE24C6E1437E814003248E0DD7FF8B9F82119F4587449BA5",
            "amount": "0.500000000000000000"
          },
          {
            "denom": "poolD35A0CC16EE598F90B044CE296A405BA9C381E38837599D96F2F70C2F02A23A4",
            "amount": "0.500000000000000000"
          }
        ],
        "start_time": "2021-09-01T00:00:00Z",
        "end_time": "2031-09-30T00:00:00Z",
        "terminated": false,
        "last_distribution_time": null,
        "distributed_coins": []
      },
      "epoch_ratio": "0.900000000000000000"
    }
  ],
  "pagination": {
    "next_key": null,
    "total": "0"
  }
}

I'm not 100% sure but I think we're using yaml representation for command line output when we don't specify --output json. I'll find out where it's used.

@hallazzang  Yes, Thanks, here is the result when we call farmingd q farming plans  or farmingd q farming plans --output text
pagination:
  next_key: null
  total: "0"
plans:
- '@type': /cosmos.farming.v1beta1.RatioPlan
  base_plan:
    distributed_coins: []
    end_time: "2031-09-30T00:00:00Z"
    farming_pool_address: cosmos1228ryjucdpdv3t87rxle0ew76a56ulvnfst0hq0sscd3nafgjpqqkcxcky
    id: "1"
    last_distribution_time: null
    name: First Public Ratio Plan
    staking_coin_weights:
    - amount: "0.500000000000000000"
      denom: pool93E069B333B5ECEBFE24C6E1437E814003248E0DD7FF8B9F82119F4587449BA5
    - amount: "0.500000000000000000"
      denom: poolD35A0CC16EE598F90B044CE296A405BA9C381E38837599D96F2F70C2F02A23A4
    start_time: "2021-09-01T00:00:00Z"
    terminated: false
    termination_address: cosmos1228ryjucdpdv3t87rxle0ew76a56ulvnfst0hq0sscd3nafgjpqqkcxcky
    type: PLAN_TYPE_PUBLIC
  epoch_ratio: "0.900000000000000000"

Thank you for checking it. Then I think CLI is using custom printer for YAML output.
I think now we can safely remove String and MarshalYAML. then.
I'm just curious why x/auth is using such custom String() implementation though.

If It's not difficult to add custom strings, and it could be ended quickly, it won't be bad to add them.  Right?

@hallazzang Yes, we could use default String() implementation provided by protobuf if there are no problems on cli, API output.


Allow before game comment, remove commentMove and commentBefore

The before game comment is the comment before any move is done. This comment could then be used to allow the following:

Add a comment before the first move, so that the commentMove (and commentBefore) comments are not necessary any more. By having this, there will no commentMove any more, because this was the only useful way to have it.
Add a comment, even when there are no moves at all (e.g. by showing a board only). That is a simple way to have some comment shown under the board. (This could as well done by pure HTML of course.) This is implemented by #34

By implementing this, the structure of the JSON changes, and a new (minor) version has to be rolled-out.

After having thought it over and over again, I think the following is needed:

gameComment (see #34) that replaces (most of) the commentMove. Exception is, when a RAV has a comment at the beginning.
commentBefore can be skipped, I never ever saw a game using it. So the spec is here very permissive, without need. Statement (Spec about comments

Comment text may appear in PGN data. ... Comments cannot appear inside any token.

This would allow comments at any place outside of a symbol. I could construct completely unreadable PGN that is valid from the spec, and will be denied by all parser available. I have checked the following 3 implementations, with the following example:
{[%csl Ya1] before} 1. {after number} e4 {after move} {[%cal Ga1h1]}

Chesstempo: Result here is: {[%csl Ya1]} { before } { after number } 1.e4 { after move } {[%cal Ga1h1]} ==> before and after are merged here, and shown before the move number then. The rest is working as expected.
Lichess: Result here is: { after number } { before } { [%csl Ya1] } 1. e4 { after move } { [%cal Ga1h1] } ==> before and after are merged in the wrong order, output of them is before the move number.
Scid (local installation): Result here is: {[%csl Ya1] beforeafter number} 1.e4 {after move[%cal Ga1h1]} ==> before and after are merged (including stripping whitespace), ewar ia ok.
ChessBase Reader: I was not able to use that at all, the import was not working as expected. I will not pay for ChessBase, so if anyone has experience how that works, please give me the result.

Decision

3 kind of comments per move are too much, the comment after the move number but before the SAN is not interpreted well by any reader / writer of PGN. commentBefore will be removed completely.
There is a need for comments before the moves

For the games as a whole (including no moves, only a board) to have the option to annotate positions. This is the gameComment in the future.
At the beginning of a RAV, before the first move. This will be used more for text comments, that are part of that variation, and not of the previous (main line) move.

commentMove (for RAV) and commentAfter (everywhere) will be kept.


Configure CloudWatch Event to Invoke pollQueue() Once a Minute

Relevant doc: https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/RunLambdaSchedule.html

Les already configure it.


distance_map.comp: One of the planes of the map is all black

Hello there, me again! I noticed when I ported this compute shader to Unity that one of the planes in the 3D texture is all black. I fixed it by storing the initial value (gi1jk) in the output's initial position. I'm not sure if that's the correct way of doing it, but I thought I could mention it here :)
In Unity, I added this line: OutMap[position] = ByteToFloat[uint2(prev, 0)];, which is basically storing gi1jk in the output before starting the for loops.
Adding a couple of images to explain better:

Hmm, I'm not seeing this occurring on any of the test images.
Could you see if it happens when you run your image through this codebase, in case there is a typo in your port?

Looking at the code it doesn't look like a typo, but I'll try running it through your application sometime next week! I'm afraid my problem might be a bit weirder 😅
HLSL, at least with Unity, doesn't support loading byte (or uint) data from textures, so it will always be a float between 0 and 1. The way I "fixed" that was by making a byte texture consisting of the values 0-255 that I could use as a lookup-table with [distance, 0] as coordinates when storing the distance, and when loading from the input image I would multiply the value by  255 and then floor it. It's possible that there are some rounding errors that come from this.


SHA-256 for current firmware issue (IDFGH-2812)

0x40081480: call_start_cpu1 at /home/sahilsoni/esp/esp-idf/components/esp32/cpu_start.c:274
I (0) cpu_start: App cpu up.
I (523) heap_init: Initializing. RAM available for dynamic allocation:
I (530) heap_init: At 3FFAE6E0 len 00001920 (6 KiB): DRAM
I (536) heap_init: At 3FFB98D8 len 00026728 (153 KiB): DRAM
I (543) heap_init: At 3FFE0440 len 00003AE0 (14 KiB): D/IRAM
I (549) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (555) heap_init: At 40095840 len 0000A7C0 (41 KiB): IRAM
I (562) cpu_start: Pro cpu start user code
I (580) spi_flash: detected chip: gd
I (580) spi_flash: flash io: dio
I (581) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (591) native_ota_example: SHA-256 for the partition table: : d1c0e9d02fa9d26cd2e1984e7b5dd20157204f501ddc83ce82229e5f3175ee8b
I (621) native_ota_example: SHA-256 for bootloader: : 6e0d03b4e66823c4dcd681b7790996e4915f0e3ca9cde7616a340425bbd33041
/////////////////////////////////////////////////////////////////////////////////////////*
file: native_ota.bin
file **size:8,48,656bytes
SHA-256native_ota.bin:feba2f6b5301b4c46c99237b2d6ce4684dd17ca4c5a014833db0b616736cdfc7
*///////////////////////////////////////////////////////////////////////////////////////
label of running app:factory
address of running app:65536
size of running app:1048576
I (911) native_ota_example: SHA-256 for current firmware: : afa366e53e86c32eeac1402c6c4c7a59c083fddeaa488f1edbadfd14ab8367e3
/////////////////////////////////////////////////////////////////////////////////////////////////*
if i am comparing theSHA-256  current firmware with native_ota.bin file it is not matching.And also size difference between current firmware(1048576) and native_ota.bin(848656)
may be reason is code take whole size of allocated space factory app but burn file is smaller then that.
*////////////////////////////////////////////////////////////////////

Hi @sahilsoni1 ,
Sorry for the delay in getting back to you.
The printout of "SHA-256 for current firmware" is based on the result of the esp_ota_get_running_partition() function is the value of a SHA-256 hash appended to the firmware file itself, and used for verification.
To print this value locally, run something like:
esptool.py --chip esp32 image_info build/firmware.bin

... the value printed here should match, but the SHA-256 of the entire .bin file will not be the same (because there is a SHA-256 appended to the .bin file itself.)
More details can be found at the documentation link, above.

And also size difference between current firmware(1048576) and native_ota.bin(848656)
may be reason is code take whole size of allocated space factory app but burn file is smaller then that.

The native_ota example doesn't print this information, so the answer depends on what code was added to print it. If you're printing partition.size then this is the size of the app partition, not the size of the app binary.
To get a more detailed answer, please provide the code which prints this line and also the exact ESP-IDF version that you're using (this is printed in the boot log, usually.)

@sahilsoni1 Thanks for reporting. Would you please help share if any updates or details for this issue? Thanks.

@sahilsoni1 Thanks for reporting. Would you please help share if any updates or details for this issue? Thanks.

Closing due to a lack of updates.


GitHub Flavored Markdown support

Hi!
First thanks for an awesome project.
I've started using it and I'm interested will the GFM be supported in the next versions?
It will be especially great if you could add source code syntax highlight.

Just wanted to follow up on this, has there been more thought put towards supporting Github flavored Markdown?


Thoughts on HCCString.h

Hi,
The explicit keyword on BasicString constructors on line 956
doesn't allow code like this (unless being pedantic):
#define FOO L"foo"
constexpr Core::WideString::CharType * foo = L"foo";

void Bar( const Core::WideString & s ) {...}

later...
{
   Bar( FOO );  // flagged as error, fixed (pedantic) as Bar( Core::WideString( FOO ) );
   Bar( foo ); // flagged as error, fixed (pedantic) as Bar( Core::WideString( foo ) );
}

Constructor at 961 suffers the same problem (imagine Bar( { FOO, _countof( FOO ) } ) )
Compiled with VS2022 community and C++ 20.
Is that by design?
Thanks
Edited

Yes, for now, it's by design. This constructor wasn't explicit to begin with, but ended up in an implicit conversion, causing a bug.
Making it explicit, fixed the problem.
Best regards
Espen Harlinn

Thank you for your answer.
I've skimmed through the class code (HCCString) and I've noticed some subtleties
but it could be my non-familiar with the class design.
Without building fancy examples you can see one of the subtleties just using the following code:
WideString s;
s.Insert( 0, 1, L'H' );

This should crash.
That's because, following your code, the const iterator is constructed when the inner reference data is not yet allocated, then memove references a null pointer.
Best Regards

Thanks for locating this embarrassing bug, I've reimplemented Insert and added a few unit tests. It was, unfortunately, not covered by the tests.  If you find anything else I would certainly like to know :-)
Best regards
Espen Harlinn

Glad I could help.
Best Regards


Add tips detection to auto mapping in bone mapper

Fixes #89725.
GodotHumanoid does not have a metacarpal for fingers other than the thumb. To avoid assigning them incorrectly, it is necessary to assign from the ends. However, some models might have "Tips" or "Leaf" bones to provide length information, so assigning from the ends is problematic.
This PR, make auto mapping can detected Tips and the mapping will be offset when candidate bones for the fingers has the name Tip or Leaf, or if none of the meshes have weights bound to them.
If the joint count of fingers excluding the thumb is the same, if even one Tip is detected, it will be apply by all bones. This is because the ReadyPlayerMe model is weird since only the index finger tips has weight.
This becomes a problem in cases where you intentionally have tips on only one finger, so if the number of bones is different, determine the tips individually. Still it may be a problem if the number of fingers is the same and you forget to bind only a specific finger, but I consider it is a rare case.

Added some more test files which do not contain any mesh.
I am skeptical of using mesh vertex-based approaches, since files such as these do not contain any mesh at all:
simple_vrm_rig.glb.gz - This one is in T-pose
simple_vrm_rig_anim4.blend
simple_vrm_rig_nlaonly2.fbx - this is animated and not in t-pose
I'll test the PR and see if I can offer any changes.
For example, I ran into a similar problem in Unidot (which uses a copy of Godot's skeleton profile guesser) and I came up with this approach:
https://github.com/V-Sekai/unidot_importer/commit/4f4f62ca886b054e28ff48e540be3f3cbf043e28
However, I am a little concerned that this does not sufficiently address cases where there are two _End bones (which happens when importing and re-exporting an animation FBX with the default setting of "Add Leaf Bone"
But maybe it will mitigate the most common cases

Indeed it is little skeptical, but since BoneMap is reusable, so I think this implementation would be a not big problem. So it would work as a workaround to use a BoneMap generated for a model with a mesh in an animation file without a mesh, as long as they have the same bone name.

From discussed with @lyuma, we think we can add a couple of decision points, so I will add them.
So the steps with the following priority order should be used for estimation:

put "distal" in the search suggestions
if the number of thumb bones is 4, there are Tips
look at the mesh weights

Detection by the number of thumb children conflicts with detection from weights. Probably, given the existence of skeletons without skins, detection by the number of thumb children should be preferred. Therefore, I will adopt @lyuma's method overall, thanks.

Thanks!


Make pkg_files.strip_prefix more intuitive

NOTE: This is currently a work-in-progress that I had some spare time to hack on.  It's mostly functional, but among other things, I don't yet have:

The migrator functional outside of rules_pkg itself in a clean manner.  Might be good enough as-is.
The right name for srcs_strip_prefix; I chose local_strip_prefix instead for some reason.  Easy enough to change.
Manual cleanup done to rules_pkg itself
A more interesting commit message

I will likely force-push this to consolidate it down to fewer, easier to understand commits.  Probably one each for the change, migrator, and migrator application.
The most interesting parts are the new files in migration/ and the updates to pkg/mappings.bzl itself.  Code changes implemented are everything in https://github.com/bazelbuild/rules_pkg/issues/354#issuecomment-987099885.
For the migration scriptage chose to use libcst instead of anything starlark-specific because the tooling is currently limited.  I (or at least a month ago) was not able to find any sort of starlark tooling that let me manipulate the AST that was not in buildifier itself.  buildozer , while largely effective, doesn't at this time seem to have a good way to handle in-rule macros like strip_prefix on the command-line.
libcst has a robust query system and allows for preservation of whitespace so that users migrating do not have to have buildifier-style reformatting done to the output.  Users can run buildifier after the fact if they want.
Fixes #354.

Is there any way we can move this along without being blocked on a rewriter?
Perhaps

make a new attrbute strip that has the new strip_prefix behavior
keep strip_prefix too, but do not allow both
eventually add a deprecation warning
a release or 2 after the migration tool works we drop the old strip_prefix

Is there any way we can move this along without being blocked on a rewriter? Perhaps
* make a new attrbute `strip` that has the new strip_prefix behavior

* keep strip_prefix too, but do not allow both

* eventually add a deprecation warning

* a release or 2 after the migration tool works we drop the old strip_prefix

I do not believe that asking users to do migrations like this is burdensome, especially when the migration script works (it does, albeit not as quickly as I would like).
That being said, we could have both strip_prefix and srcs_strip_prefix exist at the same time.  We do not need a new strip attribute for this.  I would not be opposed to this.
This leads to a broader question: what are our compatibility guarantees?  How could Bazel be changed to facilitate them more easily, as opposed to writing one-off wrapper macros?

I don't see how this is more intuitive.
We still only have a single strip prefix (local_strip_prefix) and uses still have to use the strip_prefix.from_package() or strip_prefix.from_root().  Back at the meeting in June we decided to not have from_package() that was always to be done, and to have a distinct flag for flatten.  That would strip_prefix could use direct strings and not need the strip_prefix set of functions.

(Apparently I edited your message instead of writing a new one.  No idea how I did that, my bad).
The most recent time we came to consensus on this was in our meeting on 2021-12-06.  I have implemented pretty much what was desired there, with some naming goofs.
The increase in intuition is that strip_prefix now does the less surprising thing of assuming package-relative paths by default, and that srcs_strip_prefix (which it should be named, not local_strip_prefix like I did here).  strip_prefix.flatten() makes more sense than strip_prefix.files_only().
The problem with the flatten flag IMO is that it does surprising things when combined with srcs_strip_prefix.  You shouldn't be able to provide both a the same time, and it complicates the interface a bit.
While it still requires users to look at documentation, the strip_prefix pseudomodule makes for better reading than something like "/foo/bar" or "foo/bar".  To what do they apply?  With the pseudomodule at least, there's a higher chance of the difference being visually apparent.  Using a string makes plenty of sense if we don't need to support the from_root style of stripping, but we do have valid use cases for this.

I guess a problem for me is that I can't use the strip_prefix.foo() functions when I import into Google, because that won't match the semantics of some widely used internal rules and that will confuse my user base. I'm going to have to wrap the rules in macros that use pure string values, even if it means multiple ones.
FWIW.  The current model we have moved to is
strip_prefix = '.'    is flatten
strip_prefix = 'foo'    is  strip from package.    srcs = glob([foo/**.h] ... strips the foo
strip_prefix = '%workspace%/foo   strips from root.
FWIW... the patterns of usage I see in my code base are
strip_prefix='%workspace%/...'  only about 200 times
strip_prefix='.'  about 1000 times
strip_prefix='foo' about 45K times
out of ~80K places where this could be used.
=> I have about 35K instances using the default of strip_prefix='.' (flatten).
So I am going to have a lot of headwind against strip_prefix='string' not being the normal behavior.
But those numbers to inform us as to live usage patterns. For example, the disuse of %workspace% stripping confirms our expectation that  few people ever want the full path to their package in the file names of the things they are packaging. Project layout != product layout.

So I am going to have a lot of headwind against strip_prefix='string' not being the normal behavior.

I'm afraid I have the inverse problem.  My codebase exclusively relies on the pseudomodule.  I don't explicitly need it to be used, and a transformation would not be difficult.  I also don't think my users would mind all that much (see below).
That being said, moving back to a string directly here feels like a step backward: from "this is saying what it is doing" to "this is the magic incantation to do this thing".
Regardless, something that looks nice is not necessarily a requirement.  Empirically, as long as there is convenient a way to specify the strip_prefix, users will do what is needed regardless of how pretty it looks.  Even if it looks ugly, users can just look at the documentation.
Also empirically, users will avoid looking at the documentation and even understanding what's going on in favor of looking at nearby examples and copying/pasting relevant code segments that look correct enough.
I guess the string might be easier to intuit in this case, but it limits our flexibility.  The whole point of the pseudomodule (due to my interpretation of the original specification in #36) was that people didn't know what the string meant by looking at it, and that implementing an abstraction that just calls out what it's doing
I guess I don't mind going the string route here, but it doesn't feel right to me.

But those numbers to inform us as to live usage patterns. For example, the disuse of %workspace% stripping confirms our expectation that few people ever want the full path to their package in the file names of the things they are packaging. Project layout != product layout.

Fair point, but while the %workspace% usage is minimal, it, or something like
it is still valuable to have.  We both have numerous uses for it.

Regardless, something that looks nice is not necessarily a requirement. Empirically, as long as there is convenient a way to specify the strip_prefix, users will do what is needed regardless of how pretty it looks. Even if it looks ugly, users can just look at the documentation.

Actually, I think looking nice, or at least being obvious to understand is a key requirement. People don't read documentation unless the default behavior is not doing what they want. And the default behavior should do the most commonly requrested thing, based on past experience.  I think the default, without any strip_prefix, should be unflattened file names without the path to the package.  That is  //a/b:c should be c and //a/b:d/e should be d/e.
Then you can add flattening. And you can do something else special to get the /a/b back in there.
Now we get to the question of if   /a/b ... flattened to c,e is ever an option we should provide? If so, then
it would be hard to do that if flatten were not a distinct attribute.

Actually, I think looking nice, or at least being obvious to understand is a key requirement.  People don't read documentation unless the default behavior is not doing what they want. And the default behavior should do the most commonly requrested thing, based on past experience. I think the default, without any strip_prefix, should be unflattened file names without the path to the package. That is //a/b:c should be c and //a/b:d/e should be d/e.

We are still in agreement about this, but I think we're talking around each other and have rather different visions and somewhat different requirements for this interface.
Here are what I believe to be the remaining questions.  I'll leave my answers here:
What should this attribute be named?
srcs_strip_prefix, as discussed.
How should its contents be specified?
A macro that creates a string value that represents how the prefix stripping should occur.
Should flattening even be an option?
Yes.  It's a convenient shorthand for "remove everything" without having to know what it is.  This is especially useful for filegroups.
A good compromise, perhaps, would be to consider an option where flattening is banned if all files don't start with the same directory prefix, but I don't know what sort of ripple effects this might have.  It could make updating the tree I manage (which relies heavily on flattening) difficult.  I'm about to finish a project that will get our tree up to an instance of rules_pkg from December 2021, and I'm not going to be able to do it again for some time.
If so, how should flattening be specified?
An additional value to the srcs_strip_prefix macro.
I don't really like the idea of making a new distinct flatten attribute.  It seems that the interactions with (srcs_)strip_prefix could be potentially confusing to users.

It'll be a few days until I can look again.u have my bazelcon slides to do
On Mon, Oct 31, 2022, 9:32 AM Andrew Psaltis @.***>
wrote:

@aiuto https://github.com/aiuto I'm looking into this again. Given the
points in my previous (very old) message, do you have additional comments
or concerns?
—
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_pkg/pull/492#issuecomment-1297097887,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXHHHGM2IKTYS2C6SRJGUDWF7C7VANCNFSM5KLMVRIQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have this about ready to go, but I'll make a new PR to keep the flow cleaner.


python3Packages.gios: 1.0.2 -> 2.0.0

Motivation for this change
Update to latest upstream release 2.0.0
Change log: https://github.com/bieniu/gios/releases/tag/2.0.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 131699 run on x86_64-linux 1

1 package failed to build:

home-assistant

2 packages built:

python38Packages.gios
python39Packages.gios


Process Testing

Codecov Report

Merging #53 into master will increase coverage by 10.65%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master      #53       +/-   ##
===========================================
+ Coverage   72.19%   82.85%   +10.65%
===========================================
  Files          22        5       -17
  Lines         241      140      -101
  Branches       31       17       -14
===========================================
- Hits          174      116       -58
+ Misses         55        9       -46
- Partials       12       15        +3

Impacted Files
Coverage Δ

...pp/navpages/notification/notification.component.ts

.../src/app/service/firebase/pomodoro/data.service.ts

angular/src/app/navpages/page0/page0.component.ts

...lar/src/app/service/increment-decrement.service.ts

angular/src/app/navpages/main/main.component.ts

angular/src/app/navbars/navbar/navbar.component.ts

angular/src/test.ts

...service/firebase/notification-firestore.service.ts

angular/src/app/navpages/svg/svg.component.ts

angular/src/app/navpages/home/home.component.ts

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8d77f...28ba1bf. Read the comment docs.


Web - IOU - Page opens up waypoint RHP while URL is invalid

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Navigate to staging.new.expensify.com
Click on FAB > Submit expense> Distance tab
Click on start
Copy the URL
Open any chat and paste the URL and add anything at the end to make the URL invalid (e.g of the invalid URL: https://staging.new.expensify.com/create/request/waypoint/1/undefined/0?backTo=%2Fcreate%2Frequest%2Fstart%2F1%2F1557579756269441%2Fdistance/anything
)
Click on the sent URL
Input any valid address and click on the suggestion

Expected Result:
Not here page should load right away when user clicks on the invalid URL
Actual Result:
Waypoint editor RHP first opens up and after user inserts an address and clicks on the suggestion the not here view loads
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/6859d8b5-101b-472e-8c4a-fbe876d96173

View all open jobs on GitHub

We think this issue might be related to the #collect project.

Manually changing the URL is not expected user behavior so I don't think this is worth fixing right now.


Code Sync issue after plugin installation

I have no idea whether this issue is exactly issue of this plugin or not. But since I am facing this issue after installing plugin, I wanna know the fix:
I have phone gap folder which has folder www and it had certain html, js files. After that I added android platform, in result android folder got created under platforms folder.
After that I added some files to android folder. Everything was fine till I install this plugin under phonegap folder.
As soon as this plugin got installed, I lost android specific files under android folder.
I am wondering what could be the issue and trying to recover files. Please help me.

This has nothing to do with the plugin.
Please read the docs on cordova/phonegap.
Hint: you don't add ANYTHING under the platforms folder. The folder is recreated when you build and changes will be lost.


Remove vestigial baselines

These baselines are leftovers and can be removed?

gulp runtests doesn't recreate them.
The tests all pass without them.

What I did was:

Add git rm -r --quiet tests/baselines/reference :^tests/baselines/reference/docker :^tests/baselines/reference/user -> .github/workflows/accept-baselines-fix-lints.yaml
Run that workflow to remove any unused baselines.

Thanks!


Generate subprojects

This updates the split command to take a prompt for a project name, a selector(s), and the resulting resources into a simple dictionary for later use.
Not at all married to the design of any of it, mostly just wanted to prove out the use of the Python API to do a dbt ls to get the components of a subproject.

@nicholasyager totally aligned with the subprojects being LocalDbtProjects! I was noodling on that but wasn't sure how to properly do that, given that subprojects don't exist yet! would welcome some code on the right way to handle that abstraction.
re: a meshify abstraction around the dbtRunner, I am all for it! i imagine that's a separate class that effectively houses the dbt_operation method (among other things)?

re: a meshify abstraction around the dbtRunner, I am all for it! i imagine that's a separate class that effectively houses the dbt_operation method (among other things)?

That's what I'm thinking, too! Definitely work for very near future.

@nicholasyager totally aligned with the subprojects being LocalDbtProjects! I was noodling on that but wasn't sure how to properly do that, given that subprojects don't exist yet! would welcome some code on the right way to handle that abstraction.

Roger that! I'll touch on this in my discussion item re: class design.